From xen-devel-bounces@lists.xenproject.org Fri Oct 01 00:28:17 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Oct 2021 00:28:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.200298.354774 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mW6PF-0006hJ-G4; Fri, 01 Oct 2021 00:28:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 200298.354774; Fri, 01 Oct 2021 00:28:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mW6PF-0006hC-CM; Fri, 01 Oct 2021 00:28:05 +0000
Received: by outflank-mailman (input) for mailman id 200298;
 Fri, 01 Oct 2021 00:28:03 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=cSXX=OV=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1mW6PD-0006h6-Jz
 for xen-devel@lists.xenproject.org; Fri, 01 Oct 2021 00:28:03 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 6f68a826-224e-11ec-bd77-12813bfff9fa;
 Fri, 01 Oct 2021 00:28:01 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id B524E61A52;
 Fri,  1 Oct 2021 00:28:00 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6f68a826-224e-11ec-bd77-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1633048081;
	bh=Gca05auYLtYsux7FG9M8AgPP+KNgsckUybc/bkiYwuk=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=dRYz4/cCKgU9EwApsJCbyIXKtAWKsYlIWUr8sCnYiVGh3RB7KpCWfRmudDjHxLcrm
	 rebdlciIo2Ki3KL3e/bSf2ajNNEgYgonfZgpEp2j6P0q3bxSEVKhnwPuMOZwlAsCjk
	 FWznVlXau++BHlUoBCZhihQk/GE/joXKXEfb4WIdpERNXHiVU6TIrp1dS+omH4EKA1
	 iEmg0+qQc7XyUlWEy83473S1VUUDkclc33ccgrdv3yf7wql/U6/1WEGizjqRBHtlRY
	 AyjmGh6ra5DgvBkhG5oQ/Wwz9/lloaHXa8//Z+DeRUPjAspXDRybdDMtpgPmhxniNp
	 kyfFe+RnyUyuw==
Date: Thu, 30 Sep 2021 17:27:59 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Oleksandr Andrushchenko <andr2000@gmail.com>
cc: xen-devel@lists.xenproject.org, julien@xen.org, sstabellini@kernel.org, 
    oleksandr_tyshchenko@epam.com, volodymyr_babchuk@epam.com, 
    Artem_Mygaiev@epam.com, roger.pau@citrix.com, bertrand.marquis@arm.com, 
    rahul.singh@arm.com, 
    Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Subject: Re: [PATCH v3 02/11] xen/arm: Add new device type for PCI
In-Reply-To: <20210930071326.857390-3-andr2000@gmail.com>
Message-ID: <alpine.DEB.2.21.2109301727510.3209@sstabellini-ThinkPad-T480s>
References: <20210930071326.857390-1-andr2000@gmail.com> <20210930071326.857390-3-andr2000@gmail.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Thu, 30 Sep 2021, Oleksandr Andrushchenko wrote:
> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> 
> Add new device type (DEV_PCI) to distinguish PCI devices from platform
> DT devices, so some drivers, like IOMMU, can handle PCI devices
> differently.
> 
> Also add a helper which is when given a struct device returns the
> corresponding struct pci_dev which this device is a part of.
> 
> Because of the header cross-dependencies, e.g. we need both
> struct pci_dev and struct arch_pci_dev at the same time, this cannot be
> done with an inline.
> 
> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>

Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>


> ---
> Since v2:
>  - !! dropped Stefano's r-b because of the changes
>  - simplified dev_to_pci to use a single
>    container_of(dev, struct pci_dev, arch.dev) (Jan)
> Since v1:
>  - Folded new device type (DEV_PCI) into this patch.
> ---
>  xen/arch/arm/pci/pci.c       | 7 +++++++
>  xen/include/asm-arm/device.h | 4 ++--
>  xen/include/asm-arm/pci.h    | 7 +++++++
>  3 files changed, 16 insertions(+), 2 deletions(-)
> 
> diff --git a/xen/arch/arm/pci/pci.c b/xen/arch/arm/pci/pci.c
> index 84d8f0d63430..9fc522e566a9 100644
> --- a/xen/arch/arm/pci/pci.c
> +++ b/xen/arch/arm/pci/pci.c
> @@ -27,6 +27,13 @@ int arch_pci_clean_pirqs(struct domain *d)
>      return 0;
>  }
>  
> +struct pci_dev *dev_to_pci(struct device *dev)
> +{
> +    ASSERT(dev->type == DEV_PCI);
> +
> +    return container_of(dev, struct pci_dev, arch.dev);
> +}
> +
>  static int __init dt_pci_init(void)
>  {
>      struct dt_device_node *np;
> diff --git a/xen/include/asm-arm/device.h b/xen/include/asm-arm/device.h
> index ebe84ea853cd..7bf040560363 100644
> --- a/xen/include/asm-arm/device.h
> +++ b/xen/include/asm-arm/device.h
> @@ -4,6 +4,7 @@
>  enum device_type
>  {
>      DEV_DT,
> +    DEV_PCI,
>  };
>  
>  struct dev_archdata {
> @@ -25,8 +26,7 @@ typedef struct device device_t;
>  
>  #include <xen/device_tree.h>
>  
> -/* TODO: Correctly implement dev_is_pci when PCI is supported on ARM */
> -#define dev_is_pci(dev) ((void)(dev), 0)
> +#define dev_is_pci(dev) ((dev)->type == DEV_PCI)
>  #define dev_is_dt(dev)  ((dev)->type == DEV_DT)
>  
>  enum device_class
> diff --git a/xen/include/asm-arm/pci.h b/xen/include/asm-arm/pci.h
> index 7cb2e2f1edaf..603a1fc072d1 100644
> --- a/xen/include/asm-arm/pci.h
> +++ b/xen/include/asm-arm/pci.h
> @@ -26,6 +26,13 @@ struct arch_pci_dev {
>      struct device dev;
>  };
>  
> +/*
> + * Because of the header cross-dependencies, e.g. we need both
> + * struct pci_dev and struct arch_pci_dev at the same time, this cannot be
> + * done with an inline here. Macro can be implemented, but looks scary.
> + */
> +struct pci_dev *dev_to_pci(struct device *dev);
> +
>  /* Arch-specific MSI data for vPCI. */
>  struct vpci_arch_msi {
>  };
> -- 
> 2.25.1
> 


From xen-devel-bounces@lists.xenproject.org Fri Oct 01 00:29:48 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Oct 2021 00:29:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.200304.354785 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mW6Qt-0007IN-RO; Fri, 01 Oct 2021 00:29:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 200304.354785; Fri, 01 Oct 2021 00:29:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mW6Qt-0007IG-OR; Fri, 01 Oct 2021 00:29:47 +0000
Received: by outflank-mailman (input) for mailman id 200304;
 Fri, 01 Oct 2021 00:29:47 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=cSXX=OV=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1mW6Qt-0007IA-3t
 for xen-devel@lists.xenproject.org; Fri, 01 Oct 2021 00:29:47 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id adc52158-224e-11ec-bd77-12813bfff9fa;
 Fri, 01 Oct 2021 00:29:46 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id 472C3619F8;
 Fri,  1 Oct 2021 00:29:45 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: adc52158-224e-11ec-bd77-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1633048185;
	bh=jGydmyNGPvK6YZC2gvSXz5PCk+zK4utdoQqXCNBCLr0=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=G6ckTti9f2dp93mz+Ka9XZxOwaDxYE74DKyr5P5Pev0mijHLhKdpF7TjXabaX9CYq
	 55ZIqFPmrqd47VP+wdHmyYEdGS95udNASYLyWDUFjD+uIL3t3CpaJ5aYC+mwY89kE9
	 FmkjDEBRpYQ0T6G0swNeXGx5g2vgqn/qFpgRmaN/ykaHY3eIJHDTTz6nn3cn8SnsJe
	 lCz0bZbcquzeHa3wrzWMz0eqyy3fJWCmgD+PVCYinBnF6xmaG9nnRHnxZujKmZ9+zY
	 9eMdb+ZYjrKhh2rsSgP/lacPiKwMuS2wbED/FwPnuoWoOkwz8scgraDeMR09gmxV2P
	 j57M1G5QDoGIw==
Date: Thu, 30 Sep 2021 17:29:43 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Oleksandr Andrushchenko <andr2000@gmail.com>
cc: xen-devel@lists.xenproject.org, julien@xen.org, sstabellini@kernel.org, 
    oleksandr_tyshchenko@epam.com, volodymyr_babchuk@epam.com, 
    Artem_Mygaiev@epam.com, roger.pau@citrix.com, bertrand.marquis@arm.com, 
    rahul.singh@arm.com, 
    Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Subject: Re: [PATCH v3 03/11] xen/arm: Introduce pci_find_host_bridge_node
 helper
In-Reply-To: <20210930071326.857390-4-andr2000@gmail.com>
Message-ID: <alpine.DEB.2.21.2109301729210.3209@sstabellini-ThinkPad-T480s>
References: <20210930071326.857390-1-andr2000@gmail.com> <20210930071326.857390-4-andr2000@gmail.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Thu, 30 Sep 2021, Oleksandr Andrushchenko wrote:
> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> 
> Get host bridge node given a PCI device attached to it.
> 
> This helper will be re-used for adding PCI devices by the subsequent
> patches.
> 
> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> 
> ---
> Since v2:
>  - !! dropped Stefano's r-b because of the changes
>  - s/PRI_pci/%pp after rebase onto Arm series
> ---
>  xen/arch/arm/pci/pci-host-common.c | 16 ++++++++++++++++
>  xen/include/asm-arm/pci.h          |  1 +
>  2 files changed, 17 insertions(+)
> 
> diff --git a/xen/arch/arm/pci/pci-host-common.c b/xen/arch/arm/pci/pci-host-common.c
> index 593beeb48ce4..592c01aae5bb 100644
> --- a/xen/arch/arm/pci/pci-host-common.c
> +++ b/xen/arch/arm/pci/pci-host-common.c
> @@ -276,6 +276,22 @@ int pci_get_host_bridge_segment(const struct dt_device_node *node,
>      return -EINVAL;
>  }
>  
> +/*
> + * Get host bridge node given a device attached to it.
> + */
> +struct dt_device_node *pci_find_host_bridge_node(struct device *dev)
> +{
> +    struct pci_host_bridge *bridge;
> +    struct pci_dev *pdev = dev_to_pci(dev);
> +
> +    bridge = pci_find_host_bridge(pdev->seg, pdev->bus);
> +    if ( unlikely(!bridge) )
> +    {
> +        printk(XENLOG_ERR "Unable to find PCI bridge for %pp\n", &pdev->sbdf);
> +        return NULL;
> +    }
> +    return bridge->dt_node;
> +}
>  /*
>   * Local variables:
>   * mode: C
> diff --git a/xen/include/asm-arm/pci.h b/xen/include/asm-arm/pci.h
> index 603a1fc072d1..e6d4000e2ac8 100644
> --- a/xen/include/asm-arm/pci.h
> +++ b/xen/include/asm-arm/pci.h
> @@ -99,6 +99,7 @@ void __iomem *pci_ecam_map_bus(struct pci_host_bridge *bridge,
>  struct pci_host_bridge *pci_find_host_bridge(uint16_t segment, uint8_t bus);
>  int pci_get_host_bridge_segment(const struct dt_device_node *node,
>                                  uint16_t *segment);
> +struct dt_device_node *pci_find_host_bridge_node(struct device *dev);
>  
>  static always_inline bool is_pci_passthrough_enabled(void)
>  {
> -- 
> 2.25.1
> 


From xen-devel-bounces@lists.xenproject.org Fri Oct 01 00:30:14 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Oct 2021 00:30:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.200310.354795 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mW6RK-00007c-49; Fri, 01 Oct 2021 00:30:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 200310.354795; Fri, 01 Oct 2021 00:30:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mW6RK-00007V-12; Fri, 01 Oct 2021 00:30:14 +0000
Received: by outflank-mailman (input) for mailman id 200310;
 Fri, 01 Oct 2021 00:30:13 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=cSXX=OV=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1mW6RJ-00007P-95
 for xen-devel@lists.xenproject.org; Fri, 01 Oct 2021 00:30:13 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id d723d2e5-8ee0-40a5-b59c-b43602099123;
 Fri, 01 Oct 2021 00:30:12 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id 6C4C1619F8;
 Fri,  1 Oct 2021 00:30:11 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d723d2e5-8ee0-40a5-b59c-b43602099123
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1633048211;
	bh=A4UT5UMPTUTuCdooBtSch4hmu7SDaU5wwi2Xxm20lEg=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=ZeL2GpYvtAZ4uzqCOBBF6Hq+52UnMuz2X6hg4SO1jRqmWsNOxyE2ezubxus/ge1gN
	 q5hxwV/78zR83NUt3ZMNqfh9ZbANlsAu28a0uSexccIB8rb0zXjvXHjywoOp+POCGW
	 8cGlhqYzmNy1AY8Gd56T/zNm+OtYggA12j9PPloIwx58z370jh0cIWZshEaYzayDpi
	 kr5pgctgjX76cp+wO7qbsbVCXVkmTK8G2ZRsqKk/iCJv2JhkvpCjhxpTiI3Y8/tBxR
	 gtno5uYBa4atXPr0eOE1cKy7hgvjyVptd2VbAGdwkrOoha2iR7TE/Nue1Rz10uuU4y
	 IEckTTDrLUD0w==
Date: Thu, 30 Sep 2021 17:30:10 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Stefano Stabellini <sstabellini@kernel.org>
cc: Oleksandr Andrushchenko <andr2000@gmail.com>, 
    xen-devel@lists.xenproject.org, julien@xen.org, 
    oleksandr_tyshchenko@epam.com, volodymyr_babchuk@epam.com, 
    Artem_Mygaiev@epam.com, roger.pau@citrix.com, bertrand.marquis@arm.com, 
    rahul.singh@arm.com, 
    Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Subject: Re: [PATCH v3 03/11] xen/arm: Introduce pci_find_host_bridge_node
 helper
In-Reply-To: <alpine.DEB.2.21.2109301729210.3209@sstabellini-ThinkPad-T480s>
Message-ID: <alpine.DEB.2.21.2109301730010.3209@sstabellini-ThinkPad-T480s>
References: <20210930071326.857390-1-andr2000@gmail.com> <20210930071326.857390-4-andr2000@gmail.com> <alpine.DEB.2.21.2109301729210.3209@sstabellini-ThinkPad-T480s>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Thu, 30 Sep 2021, Stefano Stabellini wrote:
> On Thu, 30 Sep 2021, Oleksandr Andrushchenko wrote:
> > From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> > 
> > Get host bridge node given a PCI device attached to it.
> > 
> > This helper will be re-used for adding PCI devices by the subsequent
> > patches.
> > 
> > Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> > Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>

I meant to say:

Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>


> > ---
> > Since v2:
> >  - !! dropped Stefano's r-b because of the changes
> >  - s/PRI_pci/%pp after rebase onto Arm series
> > ---
> >  xen/arch/arm/pci/pci-host-common.c | 16 ++++++++++++++++
> >  xen/include/asm-arm/pci.h          |  1 +
> >  2 files changed, 17 insertions(+)
> > 
> > diff --git a/xen/arch/arm/pci/pci-host-common.c b/xen/arch/arm/pci/pci-host-common.c
> > index 593beeb48ce4..592c01aae5bb 100644
> > --- a/xen/arch/arm/pci/pci-host-common.c
> > +++ b/xen/arch/arm/pci/pci-host-common.c
> > @@ -276,6 +276,22 @@ int pci_get_host_bridge_segment(const struct dt_device_node *node,
> >      return -EINVAL;
> >  }
> >  
> > +/*
> > + * Get host bridge node given a device attached to it.
> > + */
> > +struct dt_device_node *pci_find_host_bridge_node(struct device *dev)
> > +{
> > +    struct pci_host_bridge *bridge;
> > +    struct pci_dev *pdev = dev_to_pci(dev);
> > +
> > +    bridge = pci_find_host_bridge(pdev->seg, pdev->bus);
> > +    if ( unlikely(!bridge) )
> > +    {
> > +        printk(XENLOG_ERR "Unable to find PCI bridge for %pp\n", &pdev->sbdf);
> > +        return NULL;
> > +    }
> > +    return bridge->dt_node;
> > +}
> >  /*
> >   * Local variables:
> >   * mode: C
> > diff --git a/xen/include/asm-arm/pci.h b/xen/include/asm-arm/pci.h
> > index 603a1fc072d1..e6d4000e2ac8 100644
> > --- a/xen/include/asm-arm/pci.h
> > +++ b/xen/include/asm-arm/pci.h
> > @@ -99,6 +99,7 @@ void __iomem *pci_ecam_map_bus(struct pci_host_bridge *bridge,
> >  struct pci_host_bridge *pci_find_host_bridge(uint16_t segment, uint8_t bus);
> >  int pci_get_host_bridge_segment(const struct dt_device_node *node,
> >                                  uint16_t *segment);
> > +struct dt_device_node *pci_find_host_bridge_node(struct device *dev);
> >  
> >  static always_inline bool is_pci_passthrough_enabled(void)
> >  {
> > -- 
> > 2.25.1
> > 
> 


From xen-devel-bounces@lists.xenproject.org Fri Oct 01 00:34:35 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Oct 2021 00:34:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.200319.354806 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mW6VT-0000rp-LF; Fri, 01 Oct 2021 00:34:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 200319.354806; Fri, 01 Oct 2021 00:34:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mW6VT-0000ri-IP; Fri, 01 Oct 2021 00:34:31 +0000
Received: by outflank-mailman (input) for mailman id 200319;
 Fri, 01 Oct 2021 00:34:30 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=cSXX=OV=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1mW6VS-0000rc-8W
 for xen-devel@lists.xenproject.org; Fri, 01 Oct 2021 00:34:30 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 5666c457-224f-11ec-bd77-12813bfff9fa;
 Fri, 01 Oct 2021 00:34:29 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id 3A1BA60F4B;
 Fri,  1 Oct 2021 00:34:28 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5666c457-224f-11ec-bd77-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1633048468;
	bh=D8IZbxLhA+ZhjMPOMMpFwzwfko2pn9o15xrHXzH0mlY=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=dbyXAwPbkSNX/uc5syot0YSApoJarV1MhJxj5WH0xiPvazY/h1iTInKmHMRhYM+da
	 9NH+65M9LjfTph8GeYuhSRq3YJc861jaZ7H41dlrXTJCpX1m+j3QpeQTvPY/rtnmH2
	 n8CN+hDpFiTjcjvD48k2jxTwP+Ts5eynmzSRdptYflX97duQVrZ65gvZSw9O60f+xH
	 u9NS/5ylvq2UgS4be5BTfdSt2HyoBEmS0AoqvAhdvm2R6zSv9DpGjb0E2FgXu8rJVV
	 VMNmy+B2W0n8ycyYzX/3UeRSPAbyuFa7kMPhr2/D9tFLoDUVcHrV1PkI02bh2qkO3m
	 1zoNNXRi44ATA==
Date: Thu, 30 Sep 2021 17:34:27 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Oleksandr Andrushchenko <andr2000@gmail.com>
cc: xen-devel@lists.xenproject.org, julien@xen.org, sstabellini@kernel.org, 
    oleksandr_tyshchenko@epam.com, volodymyr_babchuk@epam.com, 
    Artem_Mygaiev@epam.com, roger.pau@citrix.com, bertrand.marquis@arm.com, 
    rahul.singh@arm.com, 
    Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Subject: Re: [PATCH v3 05/11] xen/arm: Mark device as PCI while creating
 one
In-Reply-To: <20210930071326.857390-6-andr2000@gmail.com>
Message-ID: <alpine.DEB.2.21.2109301733250.3209@sstabellini-ThinkPad-T480s>
References: <20210930071326.857390-1-andr2000@gmail.com> <20210930071326.857390-6-andr2000@gmail.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="8323329-1455477428-1633048468=:3209"

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-1455477428-1633048468=:3209
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT

On Thu, 30 Sep 2021, Oleksandr Andrushchenko wrote:
> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> 
> While adding a PCI device mark it as such, so other frameworks
> can distinguish it from DT devices.
> For that introduce an architecture defined helper which may perform
> additional initialization of the newly created PCI device.
> 
> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>

I get a build failure without CONFIG_PCI on ARM64:

In file included from /local/repos/xen-upstream/xen/include/xen/pci.h:66:0,
                 from /local/repos/xen-upstream/xen/include/xen/iommu.h:25,
                 from /local/repos/xen-upstream/xen/include/xen/sched.h:12,
                 from arch/arm/arm64/asm-offsets.c:9:
/local/repos/xen-upstream/xen/include/asm/pci.h:127:46: error: ‘struct pci_dev’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
 static inline void arch_pci_init_pdev(struct pci_dev *pdev) {}
                                              ^~~~~~~
cc1: all warnings being treated as errors


> ---
> Since v2:
>  - !! dropped Stefano's r-b because of the changes
>  - introduced arch_pci_init_pdev (Jan)
> Since v1:
>  - moved the assignment from iommu_add_device to alloc_pdev
> ---
>  xen/arch/arm/pci/pci.c        | 5 +++++
>  xen/drivers/passthrough/pci.c | 2 ++
>  xen/include/asm-arm/pci.h     | 5 +++++
>  xen/include/asm-x86/pci.h     | 2 ++
>  4 files changed, 14 insertions(+)
> 
> diff --git a/xen/arch/arm/pci/pci.c b/xen/arch/arm/pci/pci.c
> index 9fc522e566a9..a8d10e869603 100644
> --- a/xen/arch/arm/pci/pci.c
> +++ b/xen/arch/arm/pci/pci.c
> @@ -34,6 +34,11 @@ struct pci_dev *dev_to_pci(struct device *dev)
>      return container_of(dev, struct pci_dev, arch.dev);
>  }
>  
> +void arch_pci_init_pdev(struct pci_dev *pdev)
> +{
> +    pci_to_dev(pdev)->type = DEV_PCI;
> +}
> +
>  static int __init dt_pci_init(void)
>  {
>      struct dt_device_node *np;
> diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci.c
> index 38eb451448a3..9f804a50e780 100644
> --- a/xen/drivers/passthrough/pci.c
> +++ b/xen/drivers/passthrough/pci.c
> @@ -329,6 +329,8 @@ static struct pci_dev *alloc_pdev(struct pci_seg *pseg, u8 bus, u8 devfn)
>      *((u8*) &pdev->devfn) = devfn;
>      pdev->domain = NULL;
>  
> +    arch_pci_init_pdev(pdev);
> +
>      rc = pdev_msi_init(pdev);
>      if ( rc )
>      {
> diff --git a/xen/include/asm-arm/pci.h b/xen/include/asm-arm/pci.h
> index e6d4000e2ac8..566a9436a18e 100644
> --- a/xen/include/asm-arm/pci.h
> +++ b/xen/include/asm-arm/pci.h
> @@ -105,6 +105,9 @@ static always_inline bool is_pci_passthrough_enabled(void)
>  {
>      return pci_passthrough_enabled;
>  }
> +
> +void arch_pci_init_pdev(struct pci_dev *pdev);
> +
>  #else   /*!CONFIG_HAS_PCI*/
>  
>  struct arch_pci_dev { };
> @@ -121,5 +124,7 @@ static inline int pci_get_host_bridge_segment(const struct dt_device_node *node,
>      return -EINVAL;
>  }
>  
> +static inline void arch_pci_init_pdev(struct pci_dev *pdev) {}
> +
>  #endif  /*!CONFIG_HAS_PCI*/
>  #endif /* __ARM_PCI_H__ */
> diff --git a/xen/include/asm-x86/pci.h b/xen/include/asm-x86/pci.h
> index 61b940c91d4a..e7f10beb4eb8 100644
> --- a/xen/include/asm-x86/pci.h
> +++ b/xen/include/asm-x86/pci.h
> @@ -38,4 +38,6 @@ static always_inline bool is_pci_passthrough_enabled(void)
>      return true;
>  }
>  
> +static inline void arch_pci_init_pdev(struct pci_dev *pdev) {}
> +
>  #endif /* __X86_PCI_H__ */
> -- 
> 2.25.1
> 
--8323329-1455477428-1633048468=:3209--


From xen-devel-bounces@lists.xenproject.org Fri Oct 01 00:38:50 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Oct 2021 00:38:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.200328.354818 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mW6Zd-0001jU-9E; Fri, 01 Oct 2021 00:38:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 200328.354818; Fri, 01 Oct 2021 00:38:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mW6Zd-0001jN-6L; Fri, 01 Oct 2021 00:38:49 +0000
Received: by outflank-mailman (input) for mailman id 200328;
 Fri, 01 Oct 2021 00:38:47 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=cSXX=OV=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1mW6Zb-0001jH-L2
 for xen-devel@lists.xenproject.org; Fri, 01 Oct 2021 00:38:47 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id eff7b274-224f-11ec-bd77-12813bfff9fa;
 Fri, 01 Oct 2021 00:38:46 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id C54B761439;
 Fri,  1 Oct 2021 00:38:45 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: eff7b274-224f-11ec-bd77-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1633048726;
	bh=cd2WhwfsF89bAF8W/xWc7AMqgy0VDlXR6nG/JjsO7LE=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=OStWoSnwYj728LzcWHxmN8cI4cnUIvrEpAiN04ynrYZ3gyDRlnosKqv4TOoWZ5/yf
	 yB/cUi7s9ZtbFgDmOU7rP5nlSp0s/G8BJ7AA8KGYnHbNL9r9u8Koe2siHvBRGxpPp2
	 /0Xt/fpAHznBAN7Y3RwG69BrMJ4p61R1aocsRLikQTWO2dMTWjhfxWqXa61dFdNwF/
	 kZ2H9UawUFxQxYpb1hZRJT9Q0mTt/V+2zkl/gED3gj0vLmFJeyXpCrBRnlBmf4tb/B
	 qgwxHt9gIcCBfZ3g/Mx5t559GTaHdoL+GWkYMx5cxylIx3JccY0hLbxZ0XIgoSUUGQ
	 1mKwlL+njgs5w==
Date: Thu, 30 Sep 2021 17:38:44 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Oleksandr Andrushchenko <andr2000@gmail.com>
cc: xen-devel@lists.xenproject.org, julien@xen.org, sstabellini@kernel.org, 
    oleksandr_tyshchenko@epam.com, volodymyr_babchuk@epam.com, 
    Artem_Mygaiev@epam.com, roger.pau@citrix.com, bertrand.marquis@arm.com, 
    rahul.singh@arm.com, 
    Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>, 
    Ian Jackson <iwj@xenproject.org>, Juergen Gross <jgross@suse.com>
Subject: Re: [PATCH v3 07/11] libxl: Allow removing PCI devices for all types
 of domains
In-Reply-To: <20210930071326.857390-8-andr2000@gmail.com>
Message-ID: <alpine.DEB.2.21.2109301737500.3209@sstabellini-ThinkPad-T480s>
References: <20210930071326.857390-1-andr2000@gmail.com> <20210930071326.857390-8-andr2000@gmail.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Thu, 30 Sep 2021, Oleksandr Andrushchenko wrote:
> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> 
> The PCI device remove path may now be used by PVH on ARM, so the
> assert is no longer valid.
> 
> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> Cc: Ian Jackson <iwj@xenproject.org>
> Cc: Juergen Gross <jgross@suse.com>

Acked-by: Stefano Stabellini <sstabellini@kernel.org>


> ---
>  tools/libs/light/libxl_pci.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/tools/libs/light/libxl_pci.c b/tools/libs/light/libxl_pci.c
> index 1a1c2630803b..59f3686fc85e 100644
> --- a/tools/libs/light/libxl_pci.c
> +++ b/tools/libs/light/libxl_pci.c
> @@ -1947,8 +1947,6 @@ static void do_pci_remove(libxl__egc *egc, pci_remove_state *prs)
>              goto out_fail;
>          }
>      } else {
> -        assert(type == LIBXL_DOMAIN_TYPE_PV);
> -
>          char *sysfs_path = GCSPRINTF(SYSFS_PCI_DEV"/"PCI_BDF"/resource", pci->domain,
>                                       pci->bus, pci->dev, pci->func);
>          FILE *f = fopen(sysfs_path, "r");
> -- 
> 2.25.1
> 


From xen-devel-bounces@lists.xenproject.org Fri Oct 01 00:40:07 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Oct 2021 00:40:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.200334.354829 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mW6aq-0002eZ-LG; Fri, 01 Oct 2021 00:40:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 200334.354829; Fri, 01 Oct 2021 00:40:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mW6aq-0002db-Hg; Fri, 01 Oct 2021 00:40:04 +0000
Received: by outflank-mailman (input) for mailman id 200334;
 Fri, 01 Oct 2021 00:40:03 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=cSXX=OV=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1mW6ap-0002Xi-NM
 for xen-devel@lists.xenproject.org; Fri, 01 Oct 2021 00:40:03 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 1c467b1d-2250-11ec-bd77-12813bfff9fa;
 Fri, 01 Oct 2021 00:40:01 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id AFD0D615E2;
 Fri,  1 Oct 2021 00:40:00 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1c467b1d-2250-11ec-bd77-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1633048801;
	bh=UU0tMQdSFglZOhxkwVYy4fkqRv8jiVmtjy7FK8HRH34=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=bn35gKTcx3oyeeOig50NU4vub4Jyo5MzVx99krRNVyrjfiRPEmKRkBt5Vhq7X/3Rv
	 XUTyOgoxitAAGqhL6Do6tvtnATpYxTX15QcVBM+GE10ocD6RUWKa0cum1M0ee7ttOR
	 Nuw7nSuybOGzApLsa6QuOxjkcGccAbuPtgi34a9FUYJ2+xYpWOySCMSo1lKwQaiten
	 KM+eTtBNxIO7YKEQU4m2dbWdR0D0nyD9/xk0tKZ0e6yaN5/T0mT2sXz+ScWqUpKHJ5
	 Jo/SWCH0MFisJ1zasHUCqGJHEanr2kTx0zuRIWBxp8LOIEQaxFScG617To7HYJK+02
	 rL9iE05ShyHNg==
Date: Thu, 30 Sep 2021 17:39:59 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Oleksandr Andrushchenko <andr2000@gmail.com>
cc: xen-devel@lists.xenproject.org, julien@xen.org, sstabellini@kernel.org, 
    oleksandr_tyshchenko@epam.com, volodymyr_babchuk@epam.com, 
    Artem_Mygaiev@epam.com, roger.pau@citrix.com, bertrand.marquis@arm.com, 
    rahul.singh@arm.com, 
    Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>, 
    Ian Jackson <iwj@xenproject.org>, Juergen Gross <jgross@suse.com>
Subject: Re: [PATCH v3 08/11] libxl: Only map legacy PCI IRQs if they are
 supported
In-Reply-To: <20210930071326.857390-9-andr2000@gmail.com>
Message-ID: <alpine.DEB.2.21.2109301739520.3209@sstabellini-ThinkPad-T480s>
References: <20210930071326.857390-1-andr2000@gmail.com> <20210930071326.857390-9-andr2000@gmail.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Thu, 30 Sep 2021, Oleksandr Andrushchenko wrote:
> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> 
> Arm's PCI passthrough implementation doesn't support legacy interrupts,
> but MSI/MSI-X. This can be the case for other platforms too.
> For that reason introduce a new CONFIG_PCI_SUPP_LEGACY_IRQ and add
> it to the CFLAGS and compile the relevant code in the toolstack only if
> applicable.
> 
> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> Cc: Ian Jackson <iwj@xenproject.org>
> Cc: Juergen Gross <jgross@suse.com>

Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>


> ---
> Since v1:
>  - Minimized #idefery by introducing pci_supp_legacy_irq function
>    for relevant checks
> ---
>  tools/libs/light/Makefile    |  4 ++++
>  tools/libs/light/libxl_pci.c | 13 +++++++++++++
>  2 files changed, 17 insertions(+)
> 
> diff --git a/tools/libs/light/Makefile b/tools/libs/light/Makefile
> index 7d8c51d49242..bd3f6be2a183 100644
> --- a/tools/libs/light/Makefile
> +++ b/tools/libs/light/Makefile
> @@ -46,6 +46,10 @@ CFLAGS += -Wno-format-zero-length -Wmissing-declarations \
>  	-Wno-declaration-after-statement -Wformat-nonliteral
>  CFLAGS += -I.
>  
> +ifeq ($(CONFIG_X86),y)
> +CFLAGS += -DCONFIG_PCI_SUPP_LEGACY_IRQ
> +endif
> +
>  SRCS-$(CONFIG_X86) += libxl_cpuid.c
>  SRCS-$(CONFIG_X86) += libxl_x86.c
>  SRCS-$(CONFIG_X86) += libxl_psr.c
> diff --git a/tools/libs/light/libxl_pci.c b/tools/libs/light/libxl_pci.c
> index 59f3686fc85e..4c2d7aeefbb2 100644
> --- a/tools/libs/light/libxl_pci.c
> +++ b/tools/libs/light/libxl_pci.c
> @@ -1364,6 +1364,15 @@ static void pci_add_timeout(libxl__egc *egc, libxl__ev_time *ev,
>      pci_add_dm_done(egc, pas, rc);
>  }
>  
> +static bool pci_supp_legacy_irq(void)
> +{
> +#ifdef CONFIG_PCI_SUPP_LEGACY_IRQ
> +    return true;
> +#else
> +    return false;
> +#endif
> +}
> +
>  static void pci_add_dm_done(libxl__egc *egc,
>                              pci_add_state *pas,
>                              int rc)
> @@ -1434,6 +1443,8 @@ static void pci_add_dm_done(libxl__egc *egc,
>          }
>      }
>      fclose(f);
> +    if (!pci_supp_legacy_irq())
> +        goto out_no_irq;
>      sysfs_path = GCSPRINTF(SYSFS_PCI_DEV"/"PCI_BDF"/irq", pci->domain,
>                                  pci->bus, pci->dev, pci->func);
>      f = fopen(sysfs_path, "r");
> @@ -1983,6 +1994,8 @@ static void do_pci_remove(libxl__egc *egc, pci_remove_state *prs)
>          }
>          fclose(f);
>  skip1:
> +        if (!pci_supp_legacy_irq())
> +            goto skip_irq;
>          sysfs_path = GCSPRINTF(SYSFS_PCI_DEV"/"PCI_BDF"/irq", pci->domain,
>                                 pci->bus, pci->dev, pci->func);
>          f = fopen(sysfs_path, "r");
> -- 
> 2.25.1
> 


From xen-devel-bounces@lists.xenproject.org Fri Oct 01 00:45:42 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Oct 2021 00:45:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.200340.354840 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mW6gD-0003hs-A5; Fri, 01 Oct 2021 00:45:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 200340.354840; Fri, 01 Oct 2021 00:45:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mW6gD-0003hl-5Q; Fri, 01 Oct 2021 00:45:37 +0000
Received: by outflank-mailman (input) for mailman id 200340;
 Fri, 01 Oct 2021 00:45:35 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=cSXX=OV=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1mW6gB-0003hf-TX
 for xen-devel@lists.xenproject.org; Fri, 01 Oct 2021 00:45:35 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id ada8c754-4718-41bf-8074-2189646f23c4;
 Fri, 01 Oct 2021 00:45:34 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id B493D61A52;
 Fri,  1 Oct 2021 00:45:33 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ada8c754-4718-41bf-8074-2189646f23c4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1633049134;
	bh=8EjGWH9okjcA9+Y1aqHRf0E4FpSc5FABVCAjGTZllqQ=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=A5XmxzVqrOy+ji81JitKUKUqueLhVK/iW7A3WgkX0eYWILP1Jz9EyayO26WY8fP5N
	 5SBp1P5Jmo6WO3piqaedgrUTHqVsjAwbnWf/UXz2/u/klvVKL6k1UENGwtRid1FpSd
	 jPhEae+gtAgurKBGBkJgX6SaX57/gr+itMmi6061VU59JFL8j9HEYCFm8ebMYNqpa7
	 1Yp4EuM6Q/sRe09gY5otSM9k5Fl125+kdUeZuByDsEQvOPE/7+TbzA2dx1gWdYtyht
	 X5iajOjCWxPq/d3gWlDHAO2y9BayTczo51/LlLKarxSWhP+5VTMdQF2J5EkE2XAPLP
	 OTPOjoUM5YX+Q==
Date: Thu, 30 Sep 2021 17:45:33 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Oleksandr Andrushchenko <andr2000@gmail.com>
cc: xen-devel@lists.xenproject.org, julien@xen.org, sstabellini@kernel.org, 
    oleksandr_tyshchenko@epam.com, volodymyr_babchuk@epam.com, 
    Artem_Mygaiev@epam.com, roger.pau@citrix.com, bertrand.marquis@arm.com, 
    rahul.singh@arm.com, 
    Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Subject: Re: [PATCH v3 09/11] xen/arm: Setup MMIO range trap handlers for
 hardware domain
In-Reply-To: <20210930071326.857390-10-andr2000@gmail.com>
Message-ID: <alpine.DEB.2.21.2109301742300.3209@sstabellini-ThinkPad-T480s>
References: <20210930071326.857390-1-andr2000@gmail.com> <20210930071326.857390-10-andr2000@gmail.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Thu, 30 Sep 2021, Oleksandr Andrushchenko wrote:
> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> 
> In order for vPCI to work it needs to maintain guest and hardware
> domain's views of the configuration space. For example, BARs and
> COMMAND registers require emulation for guests and the guest view
> of the registers needs to be in sync with the real contents of the
> relevant registers. For that ECAM address space needs to also be
> trapped for the hardware domain, so we need to implement PCI host
> bridge specific callbacks to properly setup MMIO handlers for those
> ranges depending on particular host bridge implementation.
> 
> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> 
> ---
> Since v2:
> - removed unneeded assignment (count = 0)
> - removed unneeded header inclusion
> - update commit message
> Since v1:
>  - Dynamically calculate the number of MMIO handlers required for vPCI
>    and update the total number accordingly
>  - s/clb/cb
>  - Do not introduce a new callback for MMIO handler setup
> ---
>  xen/arch/arm/domain.c              |  2 ++
>  xen/arch/arm/pci/pci-host-common.c | 28 +++++++++++++++++++++++++
>  xen/arch/arm/vpci.c                | 33 ++++++++++++++++++++++++++++++
>  xen/arch/arm/vpci.h                |  6 ++++++
>  xen/include/asm-arm/pci.h          |  5 +++++
>  5 files changed, 74 insertions(+)
> 
> diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
> index 79012bf77757..fa6fcc5e467c 100644
> --- a/xen/arch/arm/domain.c
> +++ b/xen/arch/arm/domain.c
> @@ -733,6 +733,8 @@ int arch_domain_create(struct domain *d,
>      if ( (rc = domain_vgic_register(d, &count)) != 0 )
>          goto fail;
>  
> +    count += domain_vpci_get_num_mmio_handlers(d);
> +
>      if ( (rc = domain_io_init(d, count + MAX_IO_HANDLER)) != 0 )
>          goto fail;
>  
> diff --git a/xen/arch/arm/pci/pci-host-common.c b/xen/arch/arm/pci/pci-host-common.c
> index 592c01aae5bb..1eb4daa87365 100644
> --- a/xen/arch/arm/pci/pci-host-common.c
> +++ b/xen/arch/arm/pci/pci-host-common.c
> @@ -292,6 +292,34 @@ struct dt_device_node *pci_find_host_bridge_node(struct device *dev)
>      }
>      return bridge->dt_node;
>  }
> +
> +int pci_host_iterate_bridges(struct domain *d,
> +                             int (*cb)(struct domain *d,
> +                                       struct pci_host_bridge *bridge))
> +{
> +    struct pci_host_bridge *bridge;
> +    int err;
> +
> +    list_for_each_entry( bridge, &pci_host_bridges, node )
> +    {
> +        err = cb(d, bridge);
> +        if ( err )
> +            return err;
> +    }
> +    return 0;
> +}
> +
> +int pci_host_get_num_bridges(void)
> +{
> +    struct pci_host_bridge *bridge;
> +    int count = 0;
> +
> +    list_for_each_entry( bridge, &pci_host_bridges, node )
> +        count++;
> +
> +    return count;
> +}
> +
>  /*
>   * Local variables:
>   * mode: C
> diff --git a/xen/arch/arm/vpci.c b/xen/arch/arm/vpci.c
> index 76c12b92814f..5d6c29c8dcd9 100644
> --- a/xen/arch/arm/vpci.c
> +++ b/xen/arch/arm/vpci.c
> @@ -80,17 +80,50 @@ static const struct mmio_handler_ops vpci_mmio_handler = {
>      .write = vpci_mmio_write,
>  };
>  
> +static int vpci_setup_mmio_handler(struct domain *d,
> +                                   struct pci_host_bridge *bridge)
> +{
> +    struct pci_config_window *cfg = bridge->cfg;
> +
> +    register_mmio_handler(d, &vpci_mmio_handler,
> +                          cfg->phys_addr, cfg->size, NULL);
> +    return 0;
> +}
> +
>  int domain_vpci_init(struct domain *d)
>  {
>      if ( !has_vpci(d) )
>          return 0;
>  
> +    if ( is_hardware_domain(d) )
> +        return pci_host_iterate_bridges(d, vpci_setup_mmio_handler);
> +
> +    /* Guest domains use what is programmed in their device tree. */
>      register_mmio_handler(d, &vpci_mmio_handler,
>                            GUEST_VPCI_ECAM_BASE, GUEST_VPCI_ECAM_SIZE, NULL);
>  
>      return 0;
>  }
>  
> +int domain_vpci_get_num_mmio_handlers(struct domain *d)
> +{
> +    int count;
> +
> +    if ( is_hardware_domain(d) )
> +        /* For each PCI host bridge's configuration space. */
> +        count = pci_host_get_num_bridges();
> +    else
> +        /*
> +         * VPCI_MSIX_MEM_NUM handlers for MSI-X tables per each PCI device
> +         * being passed through. Maximum number of supported devices
> +         * is 32 as virtual bus topology emulates the devices as embedded
> +         * endpoints.
> +         * +1 for a single emulated host bridge's configuration space. */

Code style: Xen multiline comments are like this:

/*
 * comment
 * more comment
 */

Aside from this minor comment:

Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>


> +        count = VPCI_MSIX_MEM_NUM * 32 + 1;
> +
> +    return count;
> +}
> +
>  /*
>   * Local variables:
>   * mode: C
> diff --git a/xen/arch/arm/vpci.h b/xen/arch/arm/vpci.h
> index d8a7b0e3e802..27a2b069abd2 100644
> --- a/xen/arch/arm/vpci.h
> +++ b/xen/arch/arm/vpci.h
> @@ -17,11 +17,17 @@
>  
>  #ifdef CONFIG_HAS_VPCI
>  int domain_vpci_init(struct domain *d);
> +int domain_vpci_get_num_mmio_handlers(struct domain *d);
>  #else
>  static inline int domain_vpci_init(struct domain *d)
>  {
>      return 0;
>  }
> +
> +static inline int domain_vpci_get_num_mmio_handlers(struct domain *d)
> +{
> +    return 0;
> +}
>  #endif
>  
>  #endif /* __ARCH_ARM_VPCI_H__ */
> diff --git a/xen/include/asm-arm/pci.h b/xen/include/asm-arm/pci.h
> index 566a9436a18e..0d0266b13cba 100644
> --- a/xen/include/asm-arm/pci.h
> +++ b/xen/include/asm-arm/pci.h
> @@ -108,6 +108,11 @@ static always_inline bool is_pci_passthrough_enabled(void)
>  
>  void arch_pci_init_pdev(struct pci_dev *pdev);
>  
> +int pci_host_iterate_bridges(struct domain *d,
> +                             int (*clb)(struct domain *d,
> +                                        struct pci_host_bridge *bridge));
> +int pci_host_get_num_bridges(void);
> +
>  #else   /*!CONFIG_HAS_PCI*/
>  
>  struct arch_pci_dev { };
> -- 
> 2.25.1
> 


From xen-devel-bounces@lists.xenproject.org Fri Oct 01 01:09:18 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Oct 2021 01:09:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.200350.354850 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mW732-0004k3-4l; Fri, 01 Oct 2021 01:09:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 200350.354850; Fri, 01 Oct 2021 01:09:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mW732-0004jw-1p; Fri, 01 Oct 2021 01:09:12 +0000
Received: by outflank-mailman (input) for mailman id 200350;
 Fri, 01 Oct 2021 01:09:10 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=cSXX=OV=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1mW730-0004jq-Pz
 for xen-devel@lists.xenproject.org; Fri, 01 Oct 2021 01:09:10 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 2e0ae154-2254-11ec-bd7a-12813bfff9fa;
 Fri, 01 Oct 2021 01:09:09 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id E0F716127B;
 Fri,  1 Oct 2021 01:09:07 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2e0ae154-2254-11ec-bd7a-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1633050548;
	bh=EgIYp7CcK6/zwuKJVT3PxJON2FWlnUG2Cgu6gqEF6kc=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=DHxWQxzFlkbO9bXQiPVec721zolW2jKzJed1wFRfhOUFvgajKyPEZKZyEVRapug+9
	 fXT4pHo5xBSu3GSn5FbacpblS981tyrTxTPlltKVKZMIW6PM9K1u1kQ83YRI6OFGp6
	 ssKH14Kz6vTd/EKOeR880a8QzAzp+JGvorqZn/IXVXIOGXzwt5fR47joUhh5LpveJ8
	 clRLtg0+T71877husGU9uJ14INS+b/dkKKteZGwJqGdhWandMKJzXH/EvlssGiDwZh
	 DjXr7qgpMc/VG8DZzTZ0QSOUI3/gO/d2eB408S4ov9tXZpA6TDA7VKAKGbwYTTD3VO
	 N6+av7Qb0Csrg==
Date: Thu, 30 Sep 2021 18:09:07 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Oleksandr Andrushchenko <andr2000@gmail.com>
cc: xen-devel@lists.xenproject.org, julien@xen.org, sstabellini@kernel.org, 
    oleksandr_tyshchenko@epam.com, volodymyr_babchuk@epam.com, 
    Artem_Mygaiev@epam.com, roger.pau@citrix.com, bertrand.marquis@arm.com, 
    rahul.singh@arm.com, 
    Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Subject: Re: [PATCH v3 10/11] xen/arm: Do not map PCI ECAM and MMIO space to
 Domain-0's p2m
In-Reply-To: <20210930071326.857390-11-andr2000@gmail.com>
Message-ID: <alpine.DEB.2.21.2109301755050.3209@sstabellini-ThinkPad-T480s>
References: <20210930071326.857390-1-andr2000@gmail.com> <20210930071326.857390-11-andr2000@gmail.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Thu, 30 Sep 2021, Oleksandr Andrushchenko wrote:
> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> 
> PCI host bridges are special devices in terms of implementing PCI
> passthrough. According to [1] the current implementation depends on
> Domain-0 to perform the initialization of the relevant PCI host
> bridge hardware and perform PCI device enumeration. In order to
> achieve that one of the required changes is to not map all the memory
> ranges in map_range_to_domain as we traverse the device tree on startup
> and perform some additional checks if the range needs to be mapped to
> Domain-0.
> 
> The generic PCI host controller device tree binding says [2]:
> - ranges: As described in IEEE Std 1275-1994, but must provide
>           at least a definition of non-prefetchable memory. One
>           or both of prefetchable Memory and IO Space may also
>           be provided.
> 
> - reg   : The Configuration Space base address and size, as accessed
>           from the parent bus.  The base address corresponds to
>           the first bus in the "bus-range" property.  If no
>           "bus-range" is specified, this will be bus 0 (the default).
> 
> >From the above none of the memory ranges from the "ranges" property
> needs to be mapped to Domain-0 at startup as MMIO mapping is going to
> be handled dynamically by vPCI as we assign PCI devices, e.g. each
> device assigned to Domain-0/guest will have its MMIOs mapped/unmapped
> as needed by Xen.
> 
> The "reg" property covers not only ECAM space, but may also have other
> then the configuration memory ranges described, for example [3]:
> - reg: Should contain rc_dbi, config registers location and length.
> - reg-names: Must include the following entries:
>    "rc_dbi": controller configuration registers;
>    "config": PCIe configuration space registers.
> 
> This patch makes it possible to not map all the ranges from the
> "ranges" property and also ECAM from the "reg". All the rest from the
> "reg" property still needs to be mapped to Domain-0, so the PCI
> host bridge remains functional in Domain-0.
> 
> [1] https://lists.xenproject.org/archives/html/xen-devel/2020-07/msg00777.html
> [2] https://www.kernel.org/doc/Documentation/devicetree/bindings/pci/host-generic-pci.txt
> [3] https://www.kernel.org/doc/Documentation/devicetree/bindings/pci/hisilicon-pcie.txt
> 
> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>

This is a lot better, we are almost there. I only have a couple of
comments left.

> ---
> Since v2:
>  - removed check in map_range_to_domain for PCI_DEV
>    and moved it to handle_device, so the code is
>    simpler
>  - s/map_pci_bridge/skip_mapping
>  - extended comment in pci_host_bridge_mappings
>  - minor code restructure in construct_dom0
>  - s/.need_p2m_mapping/.need_p2m_hwdom_mapping and related
>    callbacks
>  - unsigned int i; in pci_host_bridge_mappings
> Since v1:
>  - Added better description of why and what needs to be mapped into
>    Domain-0's p2m and what doesn't
>  - Do not do any mappings for PCI devices while traversing the DT
>  - Walk all the bridges and make required mappings in one go
> ---
>  xen/arch/arm/domain_build.c        | 45 ++++++++++++++-------------
>  xen/arch/arm/pci/ecam.c            | 14 +++++++++
>  xen/arch/arm/pci/pci-host-common.c | 49 ++++++++++++++++++++++++++++++
>  xen/arch/arm/pci/pci-host-zynqmp.c |  1 +
>  xen/include/asm-arm/pci.h          | 10 ++++++
>  xen/include/asm-arm/setup.h        | 13 ++++++++
>  6 files changed, 111 insertions(+), 21 deletions(-)
> 
> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
> index 026c9e5c6cc4..ed46bcf8e7eb 100644
> --- a/xen/arch/arm/domain_build.c
> +++ b/xen/arch/arm/domain_build.c
> @@ -10,7 +10,6 @@
>  #include <asm/regs.h>
>  #include <xen/errno.h>
>  #include <xen/err.h>
> -#include <xen/device_tree.h>
>  #include <xen/libfdt/libfdt.h>
>  #include <xen/guest_access.h>
>  #include <xen/iocap.h>
> @@ -47,12 +46,6 @@ static int __init parse_dom0_mem(const char *s)
>  }
>  custom_param("dom0_mem", parse_dom0_mem);
>  
> -struct map_range_data
> -{
> -    struct domain *d;
> -    p2m_type_t p2mt;
> -};
> -
>  /* Override macros from asm/page.h to make them work with mfn_t */
>  #undef virt_to_mfn
>  #define virt_to_mfn(va) _mfn(__virt_to_mfn(va))
> @@ -1388,13 +1381,13 @@ static int __init map_dt_irq_to_domain(const struct dt_device_node *dev,
>      return 0;
>  }
>  
> -static int __init map_range_to_domain(const struct dt_device_node *dev,
> -                                      u64 addr, u64 len,
> -                                      void *data)
> +int __init map_range_to_domain(const struct dt_device_node *dev,
> +                               u64 addr, u64 len, void *data)
>  {
>      struct map_range_data *mr_data = data;
>      struct domain *d = mr_data->d;
> -    bool need_mapping = !dt_device_for_passthrough(dev);
> +    bool need_mapping = !dt_device_for_passthrough(dev) &&
> +                        !mr_data->skip_mapping;

This should be just:

bool need_mapping = !mr_data->skip_mapping;

also see below


>      int res;
>  
>      /*
> @@ -1446,23 +1439,21 @@ static int __init map_range_to_domain(const struct dt_device_node *dev,
>   * then we may need to perform additional mappings in order to make
>   * the child resources available to domain 0.
>   */
> -static int __init map_device_children(struct domain *d,
> -                                      const struct dt_device_node *dev,
> -                                      p2m_type_t p2mt)
> +static int __init map_device_children(const struct dt_device_node *dev,
> +                                      struct map_range_data *mr_data)
>  {
> -    struct map_range_data mr_data = { .d = d, .p2mt = p2mt };
> -    int ret;
> -
>      if ( dt_device_type_is_equal(dev, "pci") )
>      {
> +        int ret;
> +
>          dt_dprintk("Mapping children of %s to guest\n",
>                     dt_node_full_name(dev));
>  
> -        ret = dt_for_each_irq_map(dev, &map_dt_irq_to_domain, d);
> +        ret = dt_for_each_irq_map(dev, &map_dt_irq_to_domain, mr_data->d);

I think it would be best if we pass mr_data instead of mr_data->d so
that at the beginning of map_dt_irq_to_domain we can do:

bool need_mapping = !mr_data->skip_mapping;


>          if ( ret < 0 )
>              return ret;
>  
> -        ret = dt_for_each_range(dev, &map_range_to_domain, &mr_data);
> +        ret = dt_for_each_range(dev, &map_range_to_domain, mr_data);
>          if ( ret < 0 )
>              return ret;
>      }
> @@ -1543,6 +1534,12 @@ static int __init handle_device(struct domain *d, struct dt_device_node *dev,
>      int res;
>      u64 addr, size;
>      bool need_mapping = !dt_device_for_passthrough(dev);
> +    struct map_range_data mr_data = {
> +        .d = d,
> +        .p2mt = p2mt,
> +        .skip_mapping = is_pci_passthrough_enabled() &&
> +                        (device_get_class(dev) == DEVICE_PCI)

I think this should be:

.skip_mapping = !need_mapping ||
                (is_pci_passthrough_enabled() &&
                 (device_get_class(dev) == DEVICE_PCI))


> +    };
>  
>      naddr = dt_number_of_address(dev);
>  
> @@ -1582,7 +1579,6 @@ static int __init handle_device(struct domain *d, struct dt_device_node *dev,
>      /* Give permission and map MMIOs */
>      for ( i = 0; i < naddr; i++ )
>      {
> -        struct map_range_data mr_data = { .d = d, .p2mt = p2mt };
>          res = dt_device_get_address(dev, i, &addr, &size);
>          if ( res )
>          {
> @@ -1596,7 +1592,7 @@ static int __init handle_device(struct domain *d, struct dt_device_node *dev,
>              return res;
>      }
>  
> -    res = map_device_children(d, dev, p2mt);
> +    res = map_device_children(dev, &mr_data);
>      if ( res )
>          return res;
>  
> @@ -2754,7 +2750,14 @@ static int __init construct_dom0(struct domain *d)
>          return rc;
>  
>      if ( acpi_disabled )
> +    {
>          rc = prepare_dtb_hwdom(d, &kinfo);
> +        if ( rc < 0 )
> +            return rc;
> +#ifdef CONFIG_HAS_PCI
> +        rc = pci_host_bridge_mappings(d, p2m_mmio_direct_c);
> +#endif
> +    }
>      else
>          rc = prepare_acpi(d, &kinfo);
>  
> diff --git a/xen/arch/arm/pci/ecam.c b/xen/arch/arm/pci/ecam.c
> index 602d00799c8d..b81620074a91 100644
> --- a/xen/arch/arm/pci/ecam.c
> +++ b/xen/arch/arm/pci/ecam.c
> @@ -40,6 +40,19 @@ void __iomem *pci_ecam_map_bus(struct pci_host_bridge *bridge,
>      return base + (PCI_DEVFN2(sbdf.bdf) << devfn_shift) + where;
>  }
>  
> +bool pci_ecam_need_p2m_hwdom_mapping(struct domain *d,
> +                                     struct pci_host_bridge *bridge,
> +                                     uint64_t addr)
> +{
> +    struct pci_config_window *cfg = bridge->cfg;
> +
> +    /*
> +     * We do not want ECAM address space to be mapped in Domain-0's p2m,
> +     * so we can trap access to it.
> +     */
> +    return cfg->phys_addr != addr;
> +}
> +
>  /* ECAM ops */
>  const struct pci_ecam_ops pci_generic_ecam_ops = {
>      .bus_shift  = 20,
> @@ -47,6 +60,7 @@ const struct pci_ecam_ops pci_generic_ecam_ops = {
>          .map_bus                = pci_ecam_map_bus,
>          .read                   = pci_generic_config_read,
>          .write                  = pci_generic_config_write,
> +        .need_p2m_hwdom_mapping = pci_ecam_need_p2m_hwdom_mapping,
>      }
>  };
>  
> diff --git a/xen/arch/arm/pci/pci-host-common.c b/xen/arch/arm/pci/pci-host-common.c
> index 1eb4daa87365..085f08e23e0c 100644
> --- a/xen/arch/arm/pci/pci-host-common.c
> +++ b/xen/arch/arm/pci/pci-host-common.c
> @@ -18,6 +18,7 @@
>  
>  #include <xen/init.h>
>  #include <xen/pci.h>
> +#include <asm/setup.h>
>  #include <xen/rwlock.h>
>  #include <xen/sched.h>
>  #include <xen/vmap.h>
> @@ -320,6 +321,54 @@ int pci_host_get_num_bridges(void)
>      return count;
>  }
>  
> +int __init pci_host_bridge_mappings(struct domain *d, p2m_type_t p2mt)
> +{
> +    struct pci_host_bridge *bridge;
> +    struct map_range_data mr_data = {
> +        .d = d,
> +        .p2mt = p2mt,
> +        .skip_mapping = false
> +    };
> +
> +    /*
> +     * For each PCI host bridge we need to only map those ranges
> +     * which are used by Domain-0 to properly initialize the bridge,
> +     * e.g. we do not want to map ECAM configuration space which lives in
> +     * "reg" or "assigned-addresses" device tree property, but we want to
> +     * map other regions of the host bridge. The PCI aperture defined by
> +     * the "ranges" device tree property should also be skipped.
> +     */
> +    list_for_each_entry( bridge, &pci_host_bridges, node )
> +    {
> +        const struct dt_device_node *dev = bridge->dt_node;
> +        unsigned int i;
> +
> +        for ( i = 0; i < dt_number_of_address(dev); i++ )
> +        {
> +            uint64_t addr, size;
> +            int err;
> +
> +            err = dt_device_get_address(dev, i, &addr, &size);
> +            if ( err )
> +            {
> +                printk(XENLOG_ERR
> +                       "Unable to retrieve address range index=%u for %s\n",
> +                       i, dt_node_full_name(dev));
> +                return err;
> +            }
> +
> +            if ( bridge->ops->need_p2m_hwdom_mapping(d, bridge, addr) )
> +            {
> +                err = map_range_to_domain(dev, addr, size, &mr_data);
> +                if ( err )
> +                    return err;
> +            }
> +        }
> +    }
> +
> +    return 0;
> +}
> +
>  /*
>   * Local variables:
>   * mode: C
> diff --git a/xen/arch/arm/pci/pci-host-zynqmp.c b/xen/arch/arm/pci/pci-host-zynqmp.c
> index 6ccbfd15c968..a57bf0fbc1cc 100644
> --- a/xen/arch/arm/pci/pci-host-zynqmp.c
> +++ b/xen/arch/arm/pci/pci-host-zynqmp.c
> @@ -33,6 +33,7 @@ const struct pci_ecam_ops nwl_pcie_ops = {
>          .map_bus                = pci_ecam_map_bus,
>          .read                   = pci_generic_config_read,
>          .write                  = pci_generic_config_write,
> +        .need_p2m_hwdom_mapping = pci_ecam_need_p2m_hwdom_mapping,
>      }
>  };
>  
> diff --git a/xen/include/asm-arm/pci.h b/xen/include/asm-arm/pci.h
> index 0d0266b13cba..1bfba3da8f51 100644
> --- a/xen/include/asm-arm/pci.h
> +++ b/xen/include/asm-arm/pci.h
> @@ -17,6 +17,8 @@
>  
>  #ifdef CONFIG_HAS_PCI
>  
> +#include <asm/p2m.h>
> +
>  #define pci_to_dev(pcidev) (&(pcidev)->arch.dev)
>  
>  extern bool_t pci_passthrough_enabled;
> @@ -73,6 +75,9 @@ struct pci_ops {
>                  uint32_t reg, uint32_t len, uint32_t *value);
>      int (*write)(struct pci_host_bridge *bridge, pci_sbdf_t sbdf,
>                   uint32_t reg, uint32_t len, uint32_t value);
> +    bool (*need_p2m_hwdom_mapping)(struct domain *d,
> +                                   struct pci_host_bridge *bridge,
> +                                   uint64_t addr);
>  };
>  
>  /*
> @@ -96,6 +101,9 @@ int pci_generic_config_write(struct pci_host_bridge *bridge, pci_sbdf_t sbdf,
>                               uint32_t reg, uint32_t len, uint32_t value);
>  void __iomem *pci_ecam_map_bus(struct pci_host_bridge *bridge,
>                                 pci_sbdf_t sbdf, uint32_t where);
> +bool pci_ecam_need_p2m_hwdom_mapping(struct domain *d,
> +                                     struct pci_host_bridge *bridge,
> +                                     uint64_t addr);
>  struct pci_host_bridge *pci_find_host_bridge(uint16_t segment, uint8_t bus);
>  int pci_get_host_bridge_segment(const struct dt_device_node *node,
>                                  uint16_t *segment);
> @@ -113,6 +121,8 @@ int pci_host_iterate_bridges(struct domain *d,
>                                          struct pci_host_bridge *bridge));
>  int pci_host_get_num_bridges(void);
>  
> +int pci_host_bridge_mappings(struct domain *d, p2m_type_t p2mt);
> +
>  #else   /*!CONFIG_HAS_PCI*/
>  
>  struct arch_pci_dev { };
> diff --git a/xen/include/asm-arm/setup.h b/xen/include/asm-arm/setup.h
> index 95da0b7ab9cd..5b30135fda38 100644
> --- a/xen/include/asm-arm/setup.h
> +++ b/xen/include/asm-arm/setup.h
> @@ -2,6 +2,8 @@
>  #define __ARM_SETUP_H_
>  
>  #include <public/version.h>
> +#include <asm/p2m.h>
> +#include <xen/device_tree.h>
>  
>  #define MIN_FDT_ALIGN 8
>  #define MAX_FDT_SIZE SZ_2M
> @@ -77,6 +79,14 @@ struct bootinfo {
>  #endif
>  };
>  
> +struct map_range_data
> +{
> +    struct domain *d;
> +    p2m_type_t p2mt;
> +    /* Set if mappings for PCI host bridges must not be skipped. */

This comment needs updating


> +    bool skip_mapping;
> +};
> +
>  extern struct bootinfo bootinfo;
>  
>  extern domid_t max_init_domid;
> @@ -124,6 +134,9 @@ void device_tree_get_reg(const __be32 **cell, u32 address_cells,
>  u32 device_tree_get_u32(const void *fdt, int node,
>                          const char *prop_name, u32 dflt);
>  
> +int map_range_to_domain(const struct dt_device_node *dev,
> +                        u64 addr, u64 len, void *data);
> +
>  #endif
>  /*
>   * Local variables:
> -- 
> 2.25.1
> 


From xen-devel-bounces@lists.xenproject.org Fri Oct 01 01:14:33 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Oct 2021 01:14:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.200359.354861 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mW788-0006BV-SC; Fri, 01 Oct 2021 01:14:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 200359.354861; Fri, 01 Oct 2021 01:14:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mW788-0006BO-PK; Fri, 01 Oct 2021 01:14:28 +0000
Received: by outflank-mailman (input) for mailman id 200359;
 Fri, 01 Oct 2021 01:14:27 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=cSXX=OV=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1mW787-0006BD-0a
 for xen-devel@lists.xenproject.org; Fri, 01 Oct 2021 01:14:27 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id dda81101-ccd0-4ccb-a91a-2979da8fd426;
 Fri, 01 Oct 2021 01:14:26 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id D64F1611C1;
 Fri,  1 Oct 2021 01:14:24 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: dda81101-ccd0-4ccb-a91a-2979da8fd426
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1633050865;
	bh=0bahfwyBvoWRAssg3uo2NSnESAJF5lSFaD5tiCAaUmc=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=Zy+RR4x/Oi6DTLp2RUFNmsay78WjDRgzWtxBrorCOlaEQW324QN0iAeJL4YXqKaCz
	 tj1fllcRx2EMV/hV6gR9HrzVNXZsC7bPO0PqL9tNBgQl+uSN7W4w7bL0dnlZ55MkEP
	 So/DqhTaGXTcxh9VRuXpwgWQsQRo7atgPnSFLXE7D4ZVyIKFVLFy1bJHEQz5EKKGFC
	 DTEP/Hl78vFiaXDnmFWJeYCyMx2kD42xkzv8ljj2/4W1gEx4+fJ0J5slF0cFM17Kr8
	 GOSJYh4HoMHVziY5sLk0PclMtjWvMf0izbJhRXWI2LqtaCpiIowMdO0x4D5lb1BAHb
	 bwnnISO7/GltQ==
Date: Thu, 30 Sep 2021 18:14:24 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Oleksandr Andrushchenko <andr2000@gmail.com>
cc: xen-devel@lists.xenproject.org, julien@xen.org, sstabellini@kernel.org, 
    oleksandr_tyshchenko@epam.com, volodymyr_babchuk@epam.com, 
    Artem_Mygaiev@epam.com, roger.pau@citrix.com, bertrand.marquis@arm.com, 
    rahul.singh@arm.com, 
    Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Subject: Re: [PATCH v3 11/11] xen/arm: Process pending vPCI map/unmap
 operations
In-Reply-To: <20210930071326.857390-12-andr2000@gmail.com>
Message-ID: <alpine.DEB.2.21.2109301814170.3209@sstabellini-ThinkPad-T480s>
References: <20210930071326.857390-1-andr2000@gmail.com> <20210930071326.857390-12-andr2000@gmail.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Thu, 30 Sep 2021, Oleksandr Andrushchenko wrote:
> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> 
> vPCI may map and unmap PCI device memory (BARs) being passed through which
> may take a lot of time. For this those operations may be deferred to be
> performed later, so that they can be safely preempted.
> 
> Currently this deferred processing is happening in common IOREQ code
> which doesn't seem to be the right place for x86 and is even more
> doubtful because IOREQ may not be enabled for Arm at all.
> So, for Arm the pending vPCI work may have no chance to be executed
> if the processing is left as is in the common IOREQ code only.
> For that reason make vPCI processing happen in arch specific code.
> 
> Please be aware that there are a few outstanding TODOs affecting this
> code path, see xen/drivers/vpci/header.c:map_range and
> xen/drivers/vpci/header.c:vpci_process_pending.
> 
> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>

Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>


> ---
> Since v2:
>  - update commit message with more insight on x86, IOREQ and Arm
>  - restored order of invocation for IOREQ and vPCI processing (Jan)
> Since v1:
>  - Moved the check for pending vpci work from the common IOREQ code
>    to hvm_do_resume on x86
>  - Re-worked the code for Arm to ensure we don't miss pending vPCI work
> ---
>  xen/arch/arm/traps.c   | 13 +++++++++++++
>  xen/arch/x86/hvm/hvm.c |  6 ++++++
>  xen/common/ioreq.c     |  9 ---------
>  3 files changed, 19 insertions(+), 9 deletions(-)
> 
> diff --git a/xen/arch/arm/traps.c b/xen/arch/arm/traps.c
> index 219ab3c3fbde..b246f51086e3 100644
> --- a/xen/arch/arm/traps.c
> +++ b/xen/arch/arm/traps.c
> @@ -34,6 +34,7 @@
>  #include <xen/symbols.h>
>  #include <xen/version.h>
>  #include <xen/virtual_region.h>
> +#include <xen/vpci.h>
>  
>  #include <public/sched.h>
>  #include <public/xen.h>
> @@ -2304,6 +2305,18 @@ static bool check_for_vcpu_work(void)
>      }
>  #endif
>  
> +    if ( has_vpci(v->domain) )
> +    {
> +        bool pending;
> +
> +        local_irq_enable();
> +        pending = vpci_process_pending(v);
> +        local_irq_disable();
> +
> +        if ( pending )
> +            return true;
> +    }
> +
>      if ( likely(!v->arch.need_flush_to_ram) )
>          return false;
>  
> diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c
> index 7b48a1b925bb..38bf697c5b04 100644
> --- a/xen/arch/x86/hvm/hvm.c
> +++ b/xen/arch/x86/hvm/hvm.c
> @@ -546,6 +546,12 @@ void hvm_do_resume(struct vcpu *v)
>  
>      pt_restore_timer(v);
>  
> +    if ( has_vpci(v->domain) && vpci_process_pending(v) )
> +    {
> +        raise_softirq(SCHEDULE_SOFTIRQ);
> +        return;
> +    }
> +
>      if ( !vcpu_ioreq_handle_completion(v) )
>          return;
>  
> diff --git a/xen/common/ioreq.c b/xen/common/ioreq.c
> index d732dc045df9..689d256544c8 100644
> --- a/xen/common/ioreq.c
> +++ b/xen/common/ioreq.c
> @@ -25,9 +25,7 @@
>  #include <xen/lib.h>
>  #include <xen/paging.h>
>  #include <xen/sched.h>
> -#include <xen/softirq.h>
>  #include <xen/trace.h>
> -#include <xen/vpci.h>
>  
>  #include <asm/guest_atomics.h>
>  #include <asm/ioreq.h>
> @@ -212,19 +210,12 @@ static bool wait_for_io(struct ioreq_vcpu *sv, ioreq_t *p)
>  
>  bool vcpu_ioreq_handle_completion(struct vcpu *v)
>  {
> -    struct domain *d = v->domain;
>      struct vcpu_io *vio = &v->io;
>      struct ioreq_server *s;
>      struct ioreq_vcpu *sv;
>      enum vio_completion completion;
>      bool res = true;
>  
> -    if ( has_vpci(d) && vpci_process_pending(v) )
> -    {
> -        raise_softirq(SCHEDULE_SOFTIRQ);
> -        return false;
> -    }
> -
>      while ( (sv = get_pending_vcpu(v, &s)) != NULL )
>          if ( !wait_for_io(sv, get_ioreq(s, v)) )
>              return false;
> -- 
> 2.25.1
> 


From xen-devel-bounces@lists.xenproject.org Fri Oct 01 01:31:49 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Oct 2021 01:31:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.200366.354872 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mW7Oi-0000Ga-Ag; Fri, 01 Oct 2021 01:31:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 200366.354872; Fri, 01 Oct 2021 01:31:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mW7Oi-0000GT-7a; Fri, 01 Oct 2021 01:31:36 +0000
Received: by outflank-mailman (input) for mailman id 200366;
 Fri, 01 Oct 2021 01:31:35 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=cSXX=OV=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1mW7Oh-0000GM-0v
 for xen-devel@lists.xenproject.org; Fri, 01 Oct 2021 01:31:35 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 9415e72b-44ea-4c8d-9a8c-0118239f446a;
 Fri, 01 Oct 2021 01:31:33 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id 9B02260F5B;
 Fri,  1 Oct 2021 01:31:32 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9415e72b-44ea-4c8d-9a8c-0118239f446a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1633051893;
	bh=sZxlshwitUX9/kpFFURc5YnmHjnh9zBGb4HL5Udalg8=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=cLVFWqacMMGgn+NFmrRr7BTtM6rfOOz3nsOoEkZwKqKwRTdZll5LyGo8W4KgxX1rX
	 2UEww/MaAkHJAZ30SjGXPlDCh+0D5aH2YGBBzWkNCwodUG2J1zjVtf4vhuRYiKZuc/
	 0WcD5HSAOZUbzABQmOY7w5LQfpzcTWsaZ9J987fiCaJWk7QcK+ldtDTQKeq/33JE7r
	 dEUVwQKmMOYX7yZ7wP2eOHjl1bSYrAdxA3fxXTNsc+2WpA9farOYJxpB/N/nI1Z+j9
	 Wsh1F65ciSLGpNG5PTGG0SG+6SIXTFkLqerU7OSoeTbM0eUF0/pfnWVMrcE+olGbsF
	 F+0yf0MK7jIEQ==
Date: Thu, 30 Sep 2021 18:31:32 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Rahul Singh <rahul.singh@arm.com>
cc: xen-devel@lists.xenproject.org, bertrand.marquis@arm.com, 
    Andre.Przywara@arm.com, Jan Beulich <jbeulich@suse.com>, 
    Andrew Cooper <andrew.cooper3@citrix.com>, 
    =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= <roger.pau@citrix.com>, 
    Wei Liu <wl@xen.org>, George Dunlap <george.dunlap@citrix.com>, 
    Ian Jackson <iwj@xenproject.org>, Julien Grall <julien@xen.org>, 
    Stefano Stabellini <sstabellini@kernel.org>, Paul Durrant <paul@xen.org>, 
    Daniel De Graaf <dgdegra@tycho.nsa.gov>, 
    "Daniel P. Smith" <dpsmith@apertussolutions.com>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, 
    Juergen Gross <jgross@suse.com>, 
    Anthony PERARD <anthony.perard@citrix.com>
Subject: Re: [PATCH v3 00/17] PCI devices passthrough on Arm
In-Reply-To: <cover.1632847120.git.rahul.singh@arm.com>
Message-ID: <alpine.DEB.2.21.2109301829580.3209@sstabellini-ThinkPad-T480s>
References: <cover.1632847120.git.rahul.singh@arm.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

To make the series a bit easier to manage, given that they were fully
acked, I committed patches #1, #2, #6, #7, #8 from the series.


On Tue, 28 Sep 2021, Rahul Singh wrote:
> Hello All,
> 
> The purpose of this patch series is to add PCI passthrough support to Xen on
> Arm. PCI passthrough support on ARM is the collaboration work between EPAM and
> ARM. ARM submitted the partial RFC [1][2] last year to get early feedback. We
> tried to fix all the comments and added more features to this patch series.
> 
> Working POC with all the features can be found at [3]. Working POC is tested
> on x86 so that there will be no regression on x86. Design presentation can be
> found at [4]
> 
> PCI passthrough support is divided into different patches. This patch series
> includes following features: 
> 
> Preparatory work to implement the PCI passthrough support for the ARM:
> - Refactor MSI code.
> - Fixed compilation error when HAS_PCI enabled for ARM.
> 
> Discovering PCI Host Bridge in XEN:
> - PCI init to initialize the PCI driver.
> - PCI host bridge discovery in XEN and map the PCI ECAM configuration space to
>   the XEN memory.
> - PCI access functions.
> 
> Discovering PCI devices:
> - To support the PCI passthrough, XEN should be aware of the PCI
>   devices.
> - Hardware domain is in charge of doing the PCI enumeration and will discover
>   the PCI devices and then communicate to the XEN via a hypercall to add the
>   PCI devices in XEN.
> 
> Enable the existing x86 virtual PCI support for ARM:
> - Add VPCI trap handler for each of the PCI device added for config space
>   access.
> - Register the trap handler in XEN for each of the host bridge PCI ECAM config
>   space access.
> 
> Emulated PCI device tree node in libxl:
> - Create a virtual PCI device tree node in libxl to enable the guest OS to
>   discover the virtual PCI during guest boot.
> 
> This patch series does not inlcude the following features. Following features
> will be send for review in the next version of the patch series once initial
> patch series merged.
> 
> - VPCI support for DOMU guests (Non-identity mappings guest view of the BARs)
> - Virtual bus topology implementation
> - IOMMU related changes (generic, SMMUv2, SMMUv3)
> - MSI support for DOMU guests.
> - Virual ITS support for DOMU guests
> 
> [1] https://lists.xenproject.org/archives/html/xen-devel/2020-07/msg01184.html
> [2] https://lists.xenproject.org/archives/html/xen-devel/2020-07/threads.html#01184
> [3] https://gitlab.com/rahsingh/xen-integration/-/commits/pci-passthrough-upstream-all
> [4] https://static.sched.com/hosted_files/xen2021/e4/PCI_Device_Passthrough_On_Arm.pdf
> 
> Oleksandr Andrushchenko (1):
>   xen/arm: Add support for Xilinx ZynqMP PCI host controller
> 
> Rahul Singh (16):
>   xen/pci: Refactor MSI code that implements MSI functionality within
>     XEN
>   xen/arm: pci: Add stubs to allow selecting HAS_PCI
>   xen/arm: solve compilation error on ARM with ACPI && HAS_PCI
>   xen/arm: xc_domain_ioport_permission(..) not supported on ARM.
>   xen/arm: Add PHYSDEVOP_pci_device_* support for ARM
>   xen/device-tree: Add dt_property_read_variable_u32_array helper
>   xen/device-tree: Add dt_property_read_u32_array helper
>   xen/device-tree: Add dt_get_pci_domain_nr helper
>   xen/arm: Add support for PCI init to initialize the PCI driver.
>   xen/arm: Add cmdline boot option "pci-passthrough = <boolean>"
>   xen/arm: PCI host bridge discovery within XEN on ARM
>   xen/arm: Implement pci access functions
>   xen/arm: Enable the existing x86 virtual PCI support for ARM.
>   xen/arm: Transitional change to build HAS_VPCI on ARM.
>   arm/libxl: Emulated PCI device tree node in libxl
>   xen/arm: Add linux,pci-domain property for hwdom if not available.
> 
>  docs/misc/xen-command-line.pandoc   |   7 +
>  tools/include/libxl.h               |   6 +
>  tools/libs/ctrl/xc_domain.c         |   9 +
>  tools/libs/light/libxl_arm.c        | 105 ++++++++++
>  tools/libs/light/libxl_create.c     |   3 +
>  tools/libs/light/libxl_types.idl    |   1 +
>  tools/xl/xl_parse.c                 |   2 +
>  xen/arch/arm/Makefile               |   2 +
>  xen/arch/arm/domain.c               |   8 +-
>  xen/arch/arm/domain_build.c         |  19 ++
>  xen/arch/arm/pci/Makefile           |   6 +
>  xen/arch/arm/pci/ecam.c             |  61 ++++++
>  xen/arch/arm/pci/pci-access.c       | 140 ++++++++++++++
>  xen/arch/arm/pci/pci-host-common.c  | 287 ++++++++++++++++++++++++++++
>  xen/arch/arm/pci/pci-host-generic.c |  46 +++++
>  xen/arch/arm/pci/pci-host-zynqmp.c  |  63 ++++++
>  xen/arch/arm/pci/pci.c              |  98 ++++++++++
>  xen/arch/arm/physdev.c              |   5 +-
>  xen/arch/arm/vpci.c                 | 102 ++++++++++
>  xen/arch/arm/vpci.h                 |  36 ++++
>  xen/arch/x86/Kconfig                |   1 +
>  xen/arch/x86/domain.c               |   6 +
>  xen/arch/x86/physdev.c              |  50 +----
>  xen/arch/x86/x86_64/physdev.c       |   4 +-
>  xen/common/Makefile                 |   1 +
>  xen/common/device_tree.c            |  73 +++++++
>  xen/common/domain.c                 |   2 +-
>  xen/common/physdev.c                |  87 +++++++++
>  xen/drivers/passthrough/Makefile    |   1 +
>  xen/drivers/passthrough/arm/iommu.c |   9 +
>  xen/drivers/passthrough/msi.c       |  83 ++++++++
>  xen/drivers/passthrough/pci.c       |  69 +++----
>  xen/drivers/pci/Kconfig             |   4 +
>  xen/drivers/vpci/Makefile           |   3 +-
>  xen/drivers/vpci/header.c           |   2 +
>  xen/include/asm-arm/device.h        |   1 +
>  xen/include/asm-arm/domain.h        |   8 +-
>  xen/include/asm-arm/hypercall.h     |   2 -
>  xen/include/asm-arm/numa.h          |   5 +
>  xen/include/asm-arm/pci.h           | 116 ++++++++++-
>  xen/include/asm-x86/hypercall.h     |   9 +-
>  xen/include/asm-x86/pci.h           |  10 +-
>  xen/include/public/arch-arm.h       |  17 ++
>  xen/include/public/domctl.h         |   4 +-
>  xen/include/xen/device_tree.h       |  73 +++++++
>  xen/include/xen/hypercall.h         |   8 +
>  xen/include/xen/msi.h               |  43 +++++
>  xen/include/xen/pci.h               |   5 +-
>  xen/xsm/flask/hooks.c               |   8 +-
>  49 files changed, 1593 insertions(+), 117 deletions(-)
>  create mode 100644 xen/arch/arm/pci/Makefile
>  create mode 100644 xen/arch/arm/pci/ecam.c
>  create mode 100644 xen/arch/arm/pci/pci-access.c
>  create mode 100644 xen/arch/arm/pci/pci-host-common.c
>  create mode 100644 xen/arch/arm/pci/pci-host-generic.c
>  create mode 100644 xen/arch/arm/pci/pci-host-zynqmp.c
>  create mode 100644 xen/arch/arm/pci/pci.c
>  create mode 100644 xen/arch/arm/vpci.c
>  create mode 100644 xen/arch/arm/vpci.h
>  create mode 100644 xen/common/physdev.c
>  create mode 100644 xen/drivers/passthrough/msi.c
>  create mode 100644 xen/include/xen/msi.h
> 
> -- 
> 2.17.1
> 


From xen-devel-bounces@lists.xenproject.org Fri Oct 01 02:48:12 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Oct 2021 02:48:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.200379.354904 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mW8ad-0007tY-3Y; Fri, 01 Oct 2021 02:47:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 200379.354904; Fri, 01 Oct 2021 02:47:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mW8ac-0007tR-Vs; Fri, 01 Oct 2021 02:47:58 +0000
Received: by outflank-mailman (input) for mailman id 200379;
 Fri, 01 Oct 2021 02:47:57 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=cSXX=OV=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1mW8ab-0007tL-Bt
 for xen-devel@lists.xenproject.org; Fri, 01 Oct 2021 02:47:57 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 3a183c22-fd24-4feb-8d41-684cea6150db;
 Fri, 01 Oct 2021 02:47:56 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id 0379F61350;
 Fri,  1 Oct 2021 02:47:54 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3a183c22-fd24-4feb-8d41-684cea6150db
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1633056475;
	bh=T7VK3k+54wAwE84wO37+TlISG0mSpDmKNShcKJniDJw=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=cLJojt3tb+m07+8YjCGSw2+lfGO1OMFPccg8UlKvHCzmj3hWO3CKlZZvNM1R/h2We
	 vmoc9e3cI9YCzoeJ+455BZ5Wus2TIoeJCraetZNNWVc8j+16/lZXj/ecZ4ckOcjtbb
	 v4gIGeHGe09E6ZLinF/zOTDoAHqESNbmUs+eD19VkUu3tBVU1RqQGOdfLFv2gsURKR
	 DEWvPk0D7Xkmp7rxieVL3f5DFyHEu9gSnA7bbaRzffk4y2yElsXQN/PJXHuEH6H7vF
	 hh2Fn/sU1UQSGSEcCu5gy3j6GEG0H76D4NdCaa+aASeRyuCuB5CQKObTRyghCd/c41
	 qmJHvyxO6zlOA==
Date: Thu, 30 Sep 2021 19:47:54 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Sai Kiran Kumar Reddy Y <ysaikiran1997@gmail.com>
cc: Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>, 
    Bertrand Marquis <bertrand.marquis@arm.com>, 
    Jan Beulich <jbeulich@suse.com>, Luca Fancellu <luca.fancellu@arm.com>, 
    xen-devel@lists.xenproject.org, kannan@cimware.in
Subject: Re: Xen Booting Problem on ARM Machine
In-Reply-To: <CAEsO4uyjNs97Cx8n2owDk4kKTVCycji377pm7aXHcPWzeszUTw@mail.gmail.com>
Message-ID: <alpine.DEB.2.21.2109301942370.3209@sstabellini-ThinkPad-T480s>
References: <33C29853-D896-4E4E-91D3-4D2FA89A9B91@hxcore.ol> <eb5fd47b-6bc9-2eec-7f46-9ab9a42c9f1f@xen.org> <CAEsO4uzsCnsTtTmYHAT4NN6=girCY2NHHdAHbH6GG33D7jwe_A@mail.gmail.com> <alpine.DEB.2.21.2109131437030.10523@sstabellini-ThinkPad-T480s>
 <CAEsO4uwpiDO2QoqLRTOxpsYM9YSPAsbX0P=gagdEy21pk1VsPQ@mail.gmail.com> <alpine.DEB.2.21.2109141825330.21985@sstabellini-ThinkPad-T480s> <CAEsO4uyjNs97Cx8n2owDk4kKTVCycji377pm7aXHcPWzeszUTw@mail.gmail.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: multipart/mixed; BOUNDARY="8323329-445217707-1633056263=:3209"
Content-ID: <alpine.DEB.2.21.2109301944380.3209@sstabellini-ThinkPad-T480s>

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-445217707-1633056263=:3209
Content-Type: text/plain; CHARSET=UTF-8
Content-Transfer-Encoding: 8BIT
Content-ID: <alpine.DEB.2.21.2109301944381.3209@sstabellini-ThinkPad-T480s>

Yes there are other ways but without serial is going to be difficult
because you are not going to see anything until everything works.

How do you boot Xen and Dom0 exactly from EDK2? Are you using GRUB or
loading Xen directly from the EDK2 prompt? Please provide as many
details as possible so that I might be able to spot any errors.

Can you provide the Device Tree you are using? If you are not passing
any Device Tree  binary explicitely, then it might be passed
automatically from EDK2 to Linux/Xen. In that case, just boot from Linux
then do the following to retrieve the Device Tree:

dtc -I fs -O dts /proc/device-tree > host.dts

Then please attach host.dts to this email thread.


Also for your information it looks like Linux actually booted from ACPI,
not from Device Tree, as you can see from all the "ACPI" messages in the
kernel logs.

If you need to boot from ACPI, then you need to enable ACPI support in
Xen, which is disabled by default. You can do that using make
menuconfig.


On Thu, 30 Sep 2021, Sai Kiran Kumar Reddy Y wrote:
> Hi,
> Sorry about the delay. We have been trying to access the serial of the machine. Tried with couple of JTAG connectors. There's still no
> debug messages on the serial. Is there any other way of figuring this out?
> 
> On Wed, Sep 15, 2021, 7:02 AM Stefano Stabellini <sstabellini@kernel.org> wrote:
>       Something is off. When you enabled earlyprintk in Xen, you should see
>       something like this at boot time:
>       https://marc.info/?l=xen-devel&m=158829968025334
> 
>       All the Xen logs starting with "(XEN)" on the serial. Do you have access
>       to the serial of the machine? Without it, it is going to be hard to
>       debug.
> 
> 
>       On Tue, 14 Sep 2021, Sai Kiran Kumar Reddy Y wrote:
>       > In the folder "/var/log", there's a file called "xen", which is empty. As far as the boot logs are concerned, I don't see any
>       debug
>       > messages related to xen. I am attaching the log files, "kern.txt" and "boot.txt"
>       >
>       > On Tue, Sep 14, 2021 at 3:08 AM Stefano Stabellini <sstabellini@kernel.org> wrote:
>       >       On Mon, 13 Sep 2021, Sai Kiran Kumar Reddy Y wrote:
>       >       > On Fri, Sep 10, 2021 at 7:30 PM Julien Grall <julien@xen.org> wrote:
>       >       >
>       >       >
>       >       >       On 08/09/2021 11:43, Sai Kiran wrote:
>       >       >       > Hello,
>       >       >
>       >       >       Hi,
>       >       >
>       >       >       Thank you for the report. Moving the discussion back to xen-devel
>       >       >       because this looks like a potential issue in the UEFI stub in Xen.
>       >       >
>       >       >       > I have Xen-4.15.0 on an ARM Machine, with Debian 11 installed on it.
>       >       >
>       >       >       Would you be able to give more details on the Arm machine you are using?
>       >       >       Also, are you using ACPI or DT to boot?
>       >       >
>       >       >
>       >       >    Sai >> DT . ACPI configuration is disabled in Boot settings    
>       >       >
>       >       >       >  I
>       >       >       > am able to do “make world” and “make install”, after “./configure”, as
>       >       >       > specified in README file. When I reboot the system, I get the following
>       >       >       > message:
>       >       >       >
>       >       >       > Warning: All 128 bootinfo mem banks exhausted.
>       >       >       >
>       >       >       > Warning: All 128 bootinfo mem banks exhausted.
>       >       >
>       >       >       Hmmm... This means that you have more than 128 memory regions described
>       >       >       in the EFI memory map. That's quite a lot.
>       >       >
>       >       >       Although, this should be harmless as it means Xen will not use the extra
>       >       >       memory banks.
>       >       >
>       >       >       >
>       >       >       > Cannot exit boot services: ErrCode: 0x8000000000000002
>       >       >
>       >       >       This means EFI_INVALID_PARAMETER. We have code to retry because AFAICT
>       >       >       ExitBootServices() may sometime fails (I have CCed Jan may have more
>       >       >       idea what's happening).
>       >       >
>       >       >       Would you be able to provide more details on the UEFI firmware you are
>       >       >       using? Is it EDK2 or U-boot?
>       >       >
>       >       > Sai >>  EDK2 
>       >       >       Also, do you know if Linux is boot on the same system?
>       >       >
>       >       > Sai >> Yes 
>       >       >       However, AFAICT, the error message would not prevent Xen to continue
>       >       >       booting. So you may get stuck later in the boot process.
>       >       >
>       >       >       My suggestion would be to enable earlyprintk for your platform. You can
>       >       >       setup it up from the menuconfig in "Debugging Options".
>       >       >
>       >       > Sai >> Yes, I have enabled earlyprintk.
>       >       > I tried changing NR_MEM_BANKS(in xen/include/asm-arm/setup.h) value to 256, from 128. The error message is no longer
>       seen,
>       >       but the device
>       >       > is stuck in the boot process.
>       >
>       >       Could you please post the boot logs now that you enabled earlyprintk?
>       >       Ideally not a camera picture but a textual copy/paste from the target
>       >       serial?
>       >
>       >       Earlyprintk is pretty verbose, we should be able to figure out where it
>       >       gets stuck.
>       >
>       >
>       >
> 
> 
> 
--8323329-445217707-1633056263=:3209--


From xen-devel-bounces@lists.xenproject.org Fri Oct 01 05:59:58 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Oct 2021 05:59:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.200393.354915 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mWBaB-0002Tp-0I; Fri, 01 Oct 2021 05:59:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 200393.354915; Fri, 01 Oct 2021 05:59:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mWBaA-0002Ti-Sh; Fri, 01 Oct 2021 05:59:42 +0000
Received: by outflank-mailman (input) for mailman id 200393;
 Fri, 01 Oct 2021 05:59:41 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=KCT2=OV=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mWBa9-0002Tc-C1
 for xen-devel@lists.xenproject.org; Fri, 01 Oct 2021 05:59:41 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 0835b70e-57a4-45e4-889e-47fb2d937ef6;
 Fri, 01 Oct 2021 05:59:40 +0000 (UTC)
Received: from EUR03-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur03lp2052.outbound.protection.outlook.com [104.47.9.52]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-40-FEFkweeIPiWtwPZ_ROhyIg-1; Fri, 01 Oct 2021 07:59:37 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0401MB2445.eurprd04.prod.outlook.com (2603:10a6:800:55::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.19; Fri, 1 Oct
 2021 05:59:36 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4566.014; Fri, 1 Oct 2021
 05:59:35 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS8P251CA0024.EURP251.PROD.OUTLOOK.COM (2603:10a6:20b:2f2::27) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4566.13 via Frontend Transport; Fri, 1 Oct 2021 05:59:35 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0835b70e-57a4-45e4-889e-47fb2d937ef6
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1633067978;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=G9G37LirOMccvt1T8p/BOjzvkJxVoSMMiY2ReACiTdQ=;
	b=asVqOwgkpgKR5Nu5VBvPO7Rz0NMTBw0uuJTWbISEKAhQjsELPpwmvjI8Jod/Z17+RySlMK
	Z+GhXrBNfSQQl8e1qI6cRvIfdzZQ5S/X2HltNrcFtJTvCEs7R/Yjt22a99T7cknanDIO/c
	h9jePlM/NvHIBW+2dcaVxornQdzIuz8=
X-MC-Unique: FEFkweeIPiWtwPZ_ROhyIg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=l5J3yCYFXvrsAqVxQD90bC1jvUQ2kPkfHMvHkxdR/jISnNr8+dcOxHgZX5h94+ZI1PQ3PePVuZoqF1ACsFeGRJsKlcSYYDqpxJvGNPrDvtciz/h5W1UyL6sAWafig2Zp+wyYDEuuVWgaTdsBMfK1uJpoge/maADfYufvVKGcqAhOTpZSQjdy3Oo9KGyyCbMM/uPT1TszvrAb87i6I4ZeVgUlvU2yUwHVdGUiO09CUU6be9rCj6qHGRGkQiBTjToQz6heZ11l7UKuzUS2U9xu4KcCCFj0Od639ZM+GFtq3ujdz6KGhBaMmhFwzZQYoxd4ZZPAdQ1ULFCdc5AjchhRug==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=G9G37LirOMccvt1T8p/BOjzvkJxVoSMMiY2ReACiTdQ=;
 b=WXndeGLlDb2XBUCj0P2AzaDzCiZfEZrbhvO9vPIVdlutCljqThIhWf9xTi4YX7ImoslM+7kMe29I59LAIuRBQo5IWDKhRzIosHFbBcIZFMQHiCl3G+YskdHxY5DbupIglTK6069ODsUCDJGeflVEVDvGS9mBFn7JLuc63Buo3nLl2roXuvNiszOueOUqm4sb5P/zbBFPHS5VK8IbTZ5VXL18Q98PyrYYIW+CCor7w22gDxMNTvKGbBLnsFohk0NmrwfXtSXrmlezqFNjDbhhzJS61o1uVeTZoTEzpK7WrITvL+UqOmF3gPPw8HTfGwpILQPPVXYw/oobsqxr2cRYrQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: sh_unshadow_for_p2m_change() vs p2m_set_entry()
To: Tim Deegan <tim@xen.org>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <ae8b6cf1-d1ae-8a55-7b88-7ef24db0c554@suse.com>
 <YVIo1sR283L/MUeN@deinos.phlegethon.org>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <59b46317-e0ce-afcb-55d0-90379c4600e1@suse.com>
Date: Fri, 1 Oct 2021 07:59:33 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <YVIo1sR283L/MUeN@deinos.phlegethon.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8P251CA0024.EURP251.PROD.OUTLOOK.COM
 (2603:10a6:20b:2f2::27) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: d660c41c-b59e-4eed-b373-08d984a0a57e
X-MS-TrafficTypeDiagnostic: VI1PR0401MB2445:
X-Microsoft-Antispam-PRVS:
	<VI1PR0401MB2445BC4806AB11E80FF4DDFEB3AB9@VI1PR0401MB2445.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	S46aK5uDZbDviF1ekL9mSHctBrNeIU+n0zsEwRcL44XzHCuSqnrgcJuDxHstvGWjNUqYAvoQX5v6zasscts9q8ayFMEJiqbpYNCQXUhkSgzhWEDnXbCNBiGU4BLG9MySV8SMKoRwxq8hj3rW4i1+PX7tBCMsC/pNnEbyYNLT8a3jAPZ+IbmGJVi/y9hEEIL0wRoJcSybcyGOLkPSfqvAXnANdr5K0s2Jg9e2KzQydV5C0jYPbOMJNtc+IP0+hVmZKSi8+/jrTH+DJPWndLg8a9nDoACpRejNaxVta3N3GPBqdMTHnwKoocl/+HQBbtbVtm4x8VQZ8NVX3LBPZHAA38/dg9JA+0MHg1LNjt4H1nvVNi38mLX2ek3Ecp27spfugod3DXOw58i5EsX4b+tQBL86ZIgin+WW8LiKRkf/IpE1HCnsGGpwA+jR1AAg9qObdeolHkUHaPHqcyo78tsOQqMizFbaHigAnhpzGPABf7yX9GD+rffYza/Bm7AgmWR1UPeRUyo3vUl9t90Hdig0TUd7yrPm7RwVouhIDlxG4zytYd5BWOZpLwI9LQbKRg9ATZ4cVTshrkpeUerrwgF3N+gtg5IJEaUabbeNwZogJ+zNA1IKLOF0H9boWQOzu6HRMeEKY3U97VhapaQz8GTX83Z/Z1cp+BjFN389TBd4N8YSw8nkbpulLLd8ST1azWSGNlzO3BZRVubZPEg9aryt0dYeON0VnURCirve6LphUR59dbZS83pHqPoN08wCYSZFsBPlRoz/0aUFqzu8ESqCdw==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(316002)(5660300002)(16576012)(26005)(38100700002)(956004)(53546011)(2616005)(8676002)(36756003)(6916009)(31696002)(8936002)(31686004)(508600001)(4326008)(6486002)(2906002)(186003)(86362001)(66556008)(66946007)(66476007)(70780200001)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?N0hER25qVHVmL3FPc2YwdWlUNG1HMXZYV0lXakNLR3cyY0hWdUpFU252M3I5?=
 =?utf-8?B?U1ZMbjE0bTUwUTNpOHFYTWk0VXZ6eE9CUVZ2VFhQRy84Y21nWDZGcVVPSDVx?=
 =?utf-8?B?bjhoN2dnZHpMT2kzTktURU9aWWFXT0JHMG5lV0NHWGQ5YTR0U1JRdTFZQmNW?=
 =?utf-8?B?amY0NGdEZHdCYVhMbjRmaFNZT1lKUWgxOGxCVm1rNHNBRTE0eUZZVGdYeXE3?=
 =?utf-8?B?MGtVTVA0cVZmNHYvQUhiV3JRMTMwVWhVUk1wUWM4Ky9wNzYyTW9jSkZNdnov?=
 =?utf-8?B?VjF3UUNxUEtSWjFZTDYrNW1CdW9VV2pRRjRrRDF1OUtoY0NiTHJxeDN0aElp?=
 =?utf-8?B?a01rdjBaZ3pMYytjWFVhdkpKaUF4UnRkVnc3aUVkSktVd2IwcmlKQkRZNUJ6?=
 =?utf-8?B?RU4vMjZQNmI0RnNXWFNMNDdhRDdjOUU4dVdMWlZUTHJoWlpiN3Jla1Y5QzZn?=
 =?utf-8?B?SVpxNDUrVVhUYzdGa1krTmZXQXZGa2FoU2lVUW8rQ20zNjJDZnhKblNsVHJq?=
 =?utf-8?B?dUFUSTJ5cmJpY09qS3BZRVdSaUxwK2FIMXpEQTIzdExTdGs2RXl1eml6WjRi?=
 =?utf-8?B?eTJKbU1tSHkxb2JmVzV4MWxMbkJ2bTIvYVNlY0RIRFJ1ZFZ0K0draE5JbE5G?=
 =?utf-8?B?R0hWWmJZU0dKYVJxRkZCbWZnL0FnYkszY2JhWjc2eXNaUUVocGMzdXp2ci9T?=
 =?utf-8?B?eWtHMHFGUEtUVVFNMElEYUZNb1FrN3o2QngwbGZ0bnJ3NzNIRWdJM0ZXZGRn?=
 =?utf-8?B?cWhsdkdhNVNCRzY1TDkyWlRQckx0Z1l0N3pLZ2xBVmtOeDA4VXNzRlpydTNB?=
 =?utf-8?B?Q2Mrb0ZYVXYybldCSXl6N1pqSzI3NW9mcmRWV1dmOVlOYnFWQmRhaUJac1Nn?=
 =?utf-8?B?dnhXNk0xMklpSWJrbUg0UElxdDhKaWlvVUFiekh6dkMySkZzd2V2ZWpkUURn?=
 =?utf-8?B?MStsUzUzWlluN0hGdVpGQW5EQXJTc1lQZkxwSzdVSm5UbDVlREh5Nm9EYnVN?=
 =?utf-8?B?dHlXRnRwOG91TjRFVE9WSzR6TVJkRExuMkVaT0ZMdXFjRGtTYzdzVG1JUjJu?=
 =?utf-8?B?NlBMRDhtODR3VEJoOWpUMUlHMkJsUDRraHhMNXA0LzltdytiQzNvN2YrNzEx?=
 =?utf-8?B?dkxLUTNYdmRRcjZyWjQ0WUdhSjRTWE9uaDMwd1o2NitMVWNGODlKTzNwRG4x?=
 =?utf-8?B?WnlsWUYzYzYyQWxmb3BuN0JKck5FS2cvelVTRS9KSm5sSENKVVhvZ2pQajE1?=
 =?utf-8?B?c1ZsdWQ4TDlTZnBac1crUUN0RTdPLzdrMUV3QXh6NUR1WHluRkgzR1dzQWw3?=
 =?utf-8?B?NFJXODhVNDMyTHAxV3lxMUw5ODVvQnEybjRscFZZUzBHOXdJRk53SWZKSjdl?=
 =?utf-8?B?MmNPY0Vqc0ZieXR5aTVTMnpaLzdHdzUyMzVOaHpNUGVNQnd3Zk1TcmlvZmdE?=
 =?utf-8?B?R0RBSVE5bHlHT0VNVnMxVEpaR21OMFpLWVZQWlZyZmZ1SU1tMktkeWRiL3g5?=
 =?utf-8?B?eFlpeDNkY0pibEJUUjdMUXVCVE9BeVBCeG9OTk41NEFUb01TelJweExlM2lQ?=
 =?utf-8?B?N05mcWwzcm84ZnZZdkw2czJNc3J4V1Y5ellBeHRXanZoVVp0NC9JWThYaEhF?=
 =?utf-8?B?aVh1VDN5dm5IR3BSdmxYaE1mcFJEN1M0RU8ybGNKZ3Q4V0lYQWZOT2RaVXk2?=
 =?utf-8?B?WHFFbXlYQStFYnA1dWpVY3FyRFFOWXNhRlBjTnNleWpYMVpybkdQMGZYcmUw?=
 =?utf-8?Q?2Y/srx5jMZhMrXfmMQ1Re/f8dCtsdcByL+Zx4HD?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d660c41c-b59e-4eed-b373-08d984a0a57e
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Oct 2021 05:59:35.8712
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: UF93w3NtHjniZCPkyXZhlUYGiQd1iX7wAbTR+Uy5PiRazDt8yEUa6oPHhAdge/Y76zHoqjmvhnSMQiywp9voyA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2445

On 27.09.2021 22:25, Tim Deegan wrote:
> At 13:31 +0200 on 24 Sep (1632490304), Jan Beulich wrote:
>> The 2M logic also first checks _PAGE_PRESENT (and _PAGE_PSE), while
>> the 4k logic appears to infer that the old page was present from
>> p2m_is_{valid,grant}().
> 
> I think the p2m_type check is the right one (rather than
> _PAGE_PRESENT), since that's the one that the p2m lookups will obey
> when causing things to get shadowed.  But the extra _PAGE_PSE check
> should stay.

Actually, having transformed things into patch form, I'm now puzzled
by you explicitly saying this. Wasn't this check wrong in the first
place? I don't see anything preventing an L1 page table getting
zapped (or replaced by a 2M mapping) all in one go. The full range
of GFNs would need checking in this case as well, just like in the
opposite case (2M mapping getting replaced by an L1 pt).

This scenario may not be overly likely right now, but would become
more likely once we start re-coalescing large pages (which I'm
planning to investigate using the same scheme currently proposed
on the IOMMU side, to see whether this actually happens frequently
enough to be worthwhile).

Jan



From xen-devel-bounces@lists.xenproject.org Fri Oct 01 06:44:21 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Oct 2021 06:44:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.200403.354926 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mWCHG-0007wD-Go; Fri, 01 Oct 2021 06:44:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 200403.354926; Fri, 01 Oct 2021 06:44:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mWCHG-0007w6-DF; Fri, 01 Oct 2021 06:44:14 +0000
Received: by outflank-mailman (input) for mailman id 200403;
 Fri, 01 Oct 2021 06:44:13 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=22t+=OV=epam.com=prvs=09080f3fa0=oleksandr_andrushchenko@srs-us1.protection.inumbo.net>)
 id 1mWCHE-0007vy-NK
 for xen-devel@lists.xenproject.org; Fri, 01 Oct 2021 06:44:12 +0000
Received: from mx0b-0039f301.pphosted.com (unknown [148.163.137.242])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 6c7c722c-129f-4277-a787-e34a5e94ad7b;
 Fri, 01 Oct 2021 06:44:11 +0000 (UTC)
Received: from pps.filterd (m0174680.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 1916Sadr002384; 
 Fri, 1 Oct 2021 06:44:09 GMT
Received: from eur04-db3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2058.outbound.protection.outlook.com [104.47.12.58])
 by mx0b-0039f301.pphosted.com with ESMTP id 3bdw3gr1n4-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Fri, 01 Oct 2021 06:44:08 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by AM0PR03MB3586.eurprd03.prod.outlook.com (2603:10a6:208:43::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.15; Fri, 1 Oct
 2021 06:44:06 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::e966:6290:5736:b7bd]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::e966:6290:5736:b7bd%7]) with mapi id 15.20.4566.015; Fri, 1 Oct 2021
 06:44:06 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6c7c722c-129f-4277-a787-e34a5e94ad7b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=cCoFeg0AIRzfA5qv8KeBTC67DG6VRC0MZJOuJT6kbjt03Er61Jr0vqD3IRx1vLOfpv16Ly++6XRELg5+5VJLLrOuLExnIkq7Btpq0O9efdHx9Y4fQPqYB8wbNX5BYywb5+fkBqQF7l89F7pjoc9xs6bDdk43wraBq0ELKvA5X1RtMdyviql1sVonh69wsIa5/9C9QvpF1RoTCJCiV8kHuFmQdeibJ9JbNl69l712KMD/bh5cjGo25fyqie4W1snP28unTnnBVwdcLOKJFop5rP7OznBDVD+jXOGChZadnPP8c+KF8X67gbzNwzdZaRjXx4GziK1PQx4zrj9sASDkLA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=L8McOopZ7VYJo3QBix0nYIjZHyBOF/jivVjH0poyI5c=;
 b=UEabVqWbCDWCtkrTxRi/U8PmKANTTt0b7i/XWOrsanO+7iROx75M5G35ktiUgWg+d3oviCGHvi8AdPqOwxDNue3MnGm/2rHOBnChKRK8u5NSU+ayQ6XL1lFEl0JV61GEerXnhLliEtZobT7NsP931x3u9HNNXgMr2+dH6K+Yp/CFR3ZJ8QBsHUGxNxWd3ZdJgzkkq2DBuqhw/+Iz7uAmh0JaMY88g1/ys6j5qgQxc5JBp3r+dSGPwYuDr3dIqsui3VuqR6j7uqk/YUniUqVFp0JNbmMdY3izCmIE5ETsJfnio9cZdAi/XhJLeTgPgm5ugqeEGEg30OKQ307bu7ONIw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=L8McOopZ7VYJo3QBix0nYIjZHyBOF/jivVjH0poyI5c=;
 b=4TJcyDqzy/e3G4eQlJ+w4/sUdalpneyOeHUYHEFvs7aHzq9iIVS3x86Tv6dm9JxCdOZRnXpTvK/ocwObnMp5QzB2jGE5KhM5JYj+BOFpMLFtMuJ+AjKjGMCm+FFWHlH0cKQ8qF2XoTgEVmQigSXaiyRVadiiLs8lnhcMBT9wv66UrHmSrOrtQW/Y7qFq2AQEVte6blJbFq8hIrz9s+gm3HTlupk9UgSI3loxNNbMmMDcJh6VzxswuUU8drKIpz0vfUHLRG0xZhtuj9vCmh2wPcEBw9OVRO0X4Hq/jXEqtOq56jEkc0JBHimqLO7grtUMGmMEhucxGoVnz9dVK+OK0w==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Stefano Stabellini <sstabellini@kernel.org>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        "julien@xen.org" <julien@xen.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "roger.pau@citrix.com" <roger.pau@citrix.com>,
        Bertrand Marquis
	<bertrand.marquis@arm.com>,
        Rahul Singh <rahul.singh@arm.com>,
        Oleksandr
 Andrushchenko <Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH v3 09/11] xen/arm: Setup MMIO range trap handlers for
 hardware domain
Thread-Topic: [PATCH v3 09/11] xen/arm: Setup MMIO range trap handlers for
 hardware domain
Thread-Index: AQHXtcqz/jFZdzuyGUmCDWKb0tIV16u9T7KAgABkLIA=
Date: Fri, 1 Oct 2021 06:44:06 +0000
Message-ID: <bf6c9756-4d41-682f-24c6-3f4b7589afb8@epam.com>
References: <20210930071326.857390-1-andr2000@gmail.com>
 <20210930071326.857390-10-andr2000@gmail.com>
 <alpine.DEB.2.21.2109301742300.3209@sstabellini-ThinkPad-T480s>
In-Reply-To: <alpine.DEB.2.21.2109301742300.3209@sstabellini-ThinkPad-T480s>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
authentication-results: kernel.org; dkim=none (message not signed)
 header.d=none;kernel.org; dmarc=none action=none header.from=epam.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 06530992-af07-4e8d-f778-08d984a6dd54
x-ms-traffictypediagnostic: AM0PR03MB3586:
x-ms-exchange-transport-forked: True
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <AM0PR03MB35861D9AB95A81B166A845BCE7AB9@AM0PR03MB3586.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:2582;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 5PCXZx6Ldt1f1oDlzh5RYKlAVSwXqXjRpSp5dW97cwoh4pibsSS2iSC57BvtcuGNR9/uSumyG8sbrx+xKiY4KU+jMIZrKCEdEDpfBKisg4Kwbmw2YnJtgZnCaAEJ68bV88umQyWO0zWdBwXjlPnPcY3uUHHrhLQQ+vIEdgz/TVFEaR4VvZjiUr/eYeFFBSS04Wbb8Hqz9+L89Q/P3IIZJurPNu2bQiPNU+mMMOlzx2ykWXIiXu0aL8YGu5Ll3MV5xBV2EytKdusATmGgNnLnP7MDSY1uB3IfLy4dRiVVjH4U2nbScNRTQ900Bz50Y7Tx3uATT3WxoCZ3lt0lAEfj5nfy/PjmKjQ91CKPXikZXldWaOf/JMSrxXyPH4Wctla53xsAYDsMr4KFrp+b2u0GFv4KOVlobgqw1pq3JwQQHt2uBT7nPawUP8NrtjvTZwbwSMaivPqET+XHS80znUAF7+PA3Im15i1z/BkKMPLqhNKmUCGWZCsfjJVIN+4VlzCYgIjaBGcB8YtMs0W30alHdEbMPrHbcuH9pT0WmZTJ+KRtDPJfuPSNLOLuM4bqSU/qXkMsnLPyyx+8s1HkEG2QwhfZhsL+jtdZLBDh8F4D2U7T7/yD00QAEvSqhOO6sOzMdm9MWUO0Xg+Dm2yKyI9YIWJTQsVfQSQwbsoXLltTbYIxBUFKeg+RM9Vyh3eRyKXPeKBcKTxupFlgEnCrzuTNDScp+xeE3+qcyDVxbPg6a/7rTvCILdevfTIVD/kh6qEE
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(71200400001)(6916009)(186003)(316002)(4326008)(38070700005)(54906003)(31686004)(83380400001)(38100700002)(26005)(36756003)(122000001)(31696002)(6506007)(66556008)(66476007)(5660300002)(66946007)(86362001)(53546011)(64756008)(76116006)(66446008)(2906002)(91956017)(2616005)(508600001)(6486002)(6512007)(8936002)(8676002)(107886003)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?V1dJL0NSbS9PY1MvNHlwQUhQdEdWYUFIMHZvQ1hwUEQ0bUFGdm9VaTRteGpu?=
 =?utf-8?B?eE9zd3FDL0drRTVLZ2RoNk03M0dqOC81ZjJsV0k0RkwvODdBcUNKQ05iZjJo?=
 =?utf-8?B?Q0VHRXdVT2Evc0ttMzR4aGJheURGNmJTYTZTRFJETmpoeVdwVXR5VmQ5Ymkr?=
 =?utf-8?B?eHUzZTNOUnkxZW9yVzBuMFBOOWpUZ1lXUlo3SHdDaTQ2T3g3Z2VnSGpGRSsr?=
 =?utf-8?B?azlQSFhTS2lULzdrVERUSEJBaWFURE9MdTB6VyswTDZ4KzhlVDBxbXZ5cGJl?=
 =?utf-8?B?TkdCRmZWRXhRNVhBQWl5eDVBdUlFTll1NWs5bm13ZDNaWGlqUVF1aFA5cmQy?=
 =?utf-8?B?b0dCTlBMZjgyRHRhdGNjcnVxWEdieExqQVArREc3U3NPdlNlc0E0Q3g2NVNQ?=
 =?utf-8?B?Z2lXcThHSnlSRHZETk0vbVlFK3FSTnpHTUJsbmhVcWx3OFAyVWw0MTVYM2k2?=
 =?utf-8?B?bkJVMmVRRk9UNXRQaDhPSG9TVnc4M1JhQnJpT2lUVzZMR2VESmVwNC9ucnZX?=
 =?utf-8?B?aWVaa3RpTmpPdVc3QzJSWEdSMUMyeVlnY0I0dEovRldPSUo5UzFCaDA4WGhQ?=
 =?utf-8?B?WjFHT2NETjhSNDBJQ1FTbnZFUmZIRTc3S3RnM3VhM0tieFFJaVJmSC9OcjJG?=
 =?utf-8?B?eG95V0hiRUtQQjlDSUJXa0dybnh5MzQwVDlRQUsraGRoUThlY2VCYnFPbTNX?=
 =?utf-8?B?UHBlNHFSTFEvaURyV0N0Slh5c3pmMnpwTXpodXpCM0QrZ040K2QwT3kyTmE5?=
 =?utf-8?B?RDVnZDZqMUM3aWdhNVVTbytwWnIxZTg3STZiKzFrQVhFdmpEM2tjeXBhcTQr?=
 =?utf-8?B?OFRaSTRqTVJJVlo0ZmhCM3FMbDhHQjZNZ1ZZaVIzYUJUSzdUdjdwR1Rwb0Uv?=
 =?utf-8?B?K0tzUDRpWElia0E4L3ZqaHVkc3hxVXByazhkZDFaQXpZWXhGMEFqMnR5cHY0?=
 =?utf-8?B?NGcwTjNuM2xlcUloSUVSZlRuNXNQMHBGUC9BOHhkWnFuTGlPN0JCbUQ4d3dO?=
 =?utf-8?B?ZkRueFcwWmpqMW1ndkJucG9GZUVZZU02VWpKNVBKNVpJem1wVkNYNzNJV1JB?=
 =?utf-8?B?VEpHSWFwSEtxT1owZC9WVStRZG10UUxrZ2ZmM2RsUDNXZWZmbXB5SFFkRWsy?=
 =?utf-8?B?cGFKSlF5NU9kWkZhSC9ROFNQSTV6Q25xdkRkQTRUbHZ4bi8zYWsxL045RDdp?=
 =?utf-8?B?RytoUGNNUWxhVGgvSGVDeEJQRk1SVHFCTEJNOE12eXhlSC9saHRyY0htUjFT?=
 =?utf-8?B?YjVER1dqdnpOc3ZIcWw4QXBqZ0N5c3piVFFKalUzcW9OVEJiNkszN3hLcjd4?=
 =?utf-8?B?eHM2QndQSzRKNDBKTGc4Q1JXTXU1TjM3cUw0a2lIbWdZT3RIdWswWEhDZDRZ?=
 =?utf-8?B?UExyVWpjYU9pR0xSL0FRN3pSdDdKa3ZnVHA3aG1ua3JCUmU4TXJqMitqNlJ6?=
 =?utf-8?B?cnAyRng5VUR1UDJzOUhCWVFZM2l5VVZ0eXFHS2J0dXpKK0cvNC9iaitUSXRz?=
 =?utf-8?B?YlI3WkZnaHdiMWRqY2NTTVBTbThPYVM0c0dyMGllRC9FbW9VbUgwTmUvQ0Z1?=
 =?utf-8?B?RjJzVjlHbmVjd3QyQldIN3dGUjdTRkNDdjJYTWgzQnRLZnVrRzAzYWVRR3JT?=
 =?utf-8?B?RnJzOW5GcnRVS1p1RitNNk5BMEN6ZzhDekg3dDlMemdZQ3FJMm8vZm03QVBJ?=
 =?utf-8?B?WnNIVXBuNnNHeEpiTk51MElJN0VjQnVKRzFiMHROWmd0QnhyR2lQb1g5c0hN?=
 =?utf-8?Q?Cgpen6F6iDyEsWyErFC+dPgpoG8UN26L2xIQHW4?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <2389B732E35AFA4B861784A4BAA93A38@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 06530992-af07-4e8d-f778-08d984a6dd54
X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Oct 2021 06:44:06.1281
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: FmV6htP6JemTo4C6Gl1ZAq+jXBBmMdFsoVJoQ3/WVo/DGjyZqB/YZmk+2PmfSZopSb+n8hU5MsneSKaNN7Mm9ogf7I7hmKvFpouazC1cGRh0GrcIq092052FfABYMBJi
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR03MB3586
X-Proofpoint-GUID: zmsYezIog8Fu7O-5IUItlKpiVvHuH-om
X-Proofpoint-ORIG-GUID: zmsYezIog8Fu7O-5IUItlKpiVvHuH-om
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.391,FMLib:17.0.607.475
 definitions=2021-09-30_07,2021-09-30_01,2020-04-07_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 malwarescore=0
 spamscore=0 bulkscore=0 adultscore=0 priorityscore=1501 clxscore=1015
 mlxlogscore=999 phishscore=0 suspectscore=0 impostorscore=0
 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2109230001 definitions=main-2110010044

DQoNCk9uIDAxLjEwLjIxIDAzOjQ1LCBTdGVmYW5vIFN0YWJlbGxpbmkgd3JvdGU6DQo+IE9uIFRo
dSwgMzAgU2VwIDIwMjEsIE9sZWtzYW5kciBBbmRydXNoY2hlbmtvIHdyb3RlOg0KPj4gRnJvbTog
T2xla3NhbmRyIEFuZHJ1c2hjaGVua28gPG9sZWtzYW5kcl9hbmRydXNoY2hlbmtvQGVwYW0uY29t
Pg0KPj4NCj4+IEluIG9yZGVyIGZvciB2UENJIHRvIHdvcmsgaXQgbmVlZHMgdG8gbWFpbnRhaW4g
Z3Vlc3QgYW5kIGhhcmR3YXJlDQo+PiBkb21haW4ncyB2aWV3cyBvZiB0aGUgY29uZmlndXJhdGlv
biBzcGFjZS4gRm9yIGV4YW1wbGUsIEJBUnMgYW5kDQo+PiBDT01NQU5EIHJlZ2lzdGVycyByZXF1
aXJlIGVtdWxhdGlvbiBmb3IgZ3Vlc3RzIGFuZCB0aGUgZ3Vlc3Qgdmlldw0KPj4gb2YgdGhlIHJl
Z2lzdGVycyBuZWVkcyB0byBiZSBpbiBzeW5jIHdpdGggdGhlIHJlYWwgY29udGVudHMgb2YgdGhl
DQo+PiByZWxldmFudCByZWdpc3RlcnMuIEZvciB0aGF0IEVDQU0gYWRkcmVzcyBzcGFjZSBuZWVk
cyB0byBhbHNvIGJlDQo+PiB0cmFwcGVkIGZvciB0aGUgaGFyZHdhcmUgZG9tYWluLCBzbyB3ZSBu
ZWVkIHRvIGltcGxlbWVudCBQQ0kgaG9zdA0KPj4gYnJpZGdlIHNwZWNpZmljIGNhbGxiYWNrcyB0
byBwcm9wZXJseSBzZXR1cCBNTUlPIGhhbmRsZXJzIGZvciB0aG9zZQ0KPj4gcmFuZ2VzIGRlcGVu
ZGluZyBvbiBwYXJ0aWN1bGFyIGhvc3QgYnJpZGdlIGltcGxlbWVudGF0aW9uLg0KPj4NCj4+IFNp
Z25lZC1vZmYtYnk6IE9sZWtzYW5kciBBbmRydXNoY2hlbmtvIDxvbGVrc2FuZHJfYW5kcnVzaGNo
ZW5rb0BlcGFtLmNvbT4NCj4+DQo+PiAtLS0NCj4+IFNpbmNlIHYyOg0KPj4gLSByZW1vdmVkIHVu
bmVlZGVkIGFzc2lnbm1lbnQgKGNvdW50ID0gMCkNCj4+IC0gcmVtb3ZlZCB1bm5lZWRlZCBoZWFk
ZXIgaW5jbHVzaW9uDQo+PiAtIHVwZGF0ZSBjb21taXQgbWVzc2FnZQ0KPj4gU2luY2UgdjE6DQo+
PiAgIC0gRHluYW1pY2FsbHkgY2FsY3VsYXRlIHRoZSBudW1iZXIgb2YgTU1JTyBoYW5kbGVycyBy
ZXF1aXJlZCBmb3IgdlBDSQ0KPj4gICAgIGFuZCB1cGRhdGUgdGhlIHRvdGFsIG51bWJlciBhY2Nv
cmRpbmdseQ0KPj4gICAtIHMvY2xiL2NiDQo+PiAgIC0gRG8gbm90IGludHJvZHVjZSBhIG5ldyBj
YWxsYmFjayBmb3IgTU1JTyBoYW5kbGVyIHNldHVwDQo+PiAtLS0NCj4+ICAgeGVuL2FyY2gvYXJt
L2RvbWFpbi5jICAgICAgICAgICAgICB8ICAyICsrDQo+PiAgIHhlbi9hcmNoL2FybS9wY2kvcGNp
LWhvc3QtY29tbW9uLmMgfCAyOCArKysrKysrKysrKysrKysrKysrKysrKysrDQo+PiAgIHhlbi9h
cmNoL2FybS92cGNpLmMgICAgICAgICAgICAgICAgfCAzMyArKysrKysrKysrKysrKysrKysrKysr
KysrKysrKysNCj4+ICAgeGVuL2FyY2gvYXJtL3ZwY2kuaCAgICAgICAgICAgICAgICB8ICA2ICsr
KysrKw0KPj4gICB4ZW4vaW5jbHVkZS9hc20tYXJtL3BjaS5oICAgICAgICAgIHwgIDUgKysrKysN
Cj4+ICAgNSBmaWxlcyBjaGFuZ2VkLCA3NCBpbnNlcnRpb25zKCspDQo+Pg0KPj4gZGlmZiAtLWdp
dCBhL3hlbi9hcmNoL2FybS9kb21haW4uYyBiL3hlbi9hcmNoL2FybS9kb21haW4uYw0KPj4gaW5k
ZXggNzkwMTJiZjc3NzU3Li5mYTZmY2M1ZTQ2N2MgMTAwNjQ0DQo+PiAtLS0gYS94ZW4vYXJjaC9h
cm0vZG9tYWluLmMNCj4+ICsrKyBiL3hlbi9hcmNoL2FybS9kb21haW4uYw0KPj4gQEAgLTczMyw2
ICs3MzMsOCBAQCBpbnQgYXJjaF9kb21haW5fY3JlYXRlKHN0cnVjdCBkb21haW4gKmQsDQo+PiAg
ICAgICBpZiAoIChyYyA9IGRvbWFpbl92Z2ljX3JlZ2lzdGVyKGQsICZjb3VudCkpICE9IDAgKQ0K
Pj4gICAgICAgICAgIGdvdG8gZmFpbDsNCj4+ICAgDQo+PiArICAgIGNvdW50ICs9IGRvbWFpbl92
cGNpX2dldF9udW1fbW1pb19oYW5kbGVycyhkKTsNCj4+ICsNCj4+ICAgICAgIGlmICggKHJjID0g
ZG9tYWluX2lvX2luaXQoZCwgY291bnQgKyBNQVhfSU9fSEFORExFUikpICE9IDAgKQ0KPj4gICAg
ICAgICAgIGdvdG8gZmFpbDsNCj4+ICAgDQo+PiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gvYXJtL3Bj
aS9wY2ktaG9zdC1jb21tb24uYyBiL3hlbi9hcmNoL2FybS9wY2kvcGNpLWhvc3QtY29tbW9uLmMN
Cj4+IGluZGV4IDU5MmMwMWFhZTViYi4uMWViNGRhYTg3MzY1IDEwMDY0NA0KPj4gLS0tIGEveGVu
L2FyY2gvYXJtL3BjaS9wY2ktaG9zdC1jb21tb24uYw0KPj4gKysrIGIveGVuL2FyY2gvYXJtL3Bj
aS9wY2ktaG9zdC1jb21tb24uYw0KPj4gQEAgLTI5Miw2ICsyOTIsMzQgQEAgc3RydWN0IGR0X2Rl
dmljZV9ub2RlICpwY2lfZmluZF9ob3N0X2JyaWRnZV9ub2RlKHN0cnVjdCBkZXZpY2UgKmRldikN
Cj4+ICAgICAgIH0NCj4+ICAgICAgIHJldHVybiBicmlkZ2UtPmR0X25vZGU7DQo+PiAgIH0NCj4+
ICsNCj4+ICtpbnQgcGNpX2hvc3RfaXRlcmF0ZV9icmlkZ2VzKHN0cnVjdCBkb21haW4gKmQsDQo+
PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICBpbnQgKCpjYikoc3RydWN0IGRvbWFpbiAq
ZCwNCj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBzdHJ1Y3QgcGNp
X2hvc3RfYnJpZGdlICpicmlkZ2UpKQ0KPj4gK3sNCj4+ICsgICAgc3RydWN0IHBjaV9ob3N0X2Jy
aWRnZSAqYnJpZGdlOw0KPj4gKyAgICBpbnQgZXJyOw0KPj4gKw0KPj4gKyAgICBsaXN0X2Zvcl9l
YWNoX2VudHJ5KCBicmlkZ2UsICZwY2lfaG9zdF9icmlkZ2VzLCBub2RlICkNCj4+ICsgICAgew0K
Pj4gKyAgICAgICAgZXJyID0gY2IoZCwgYnJpZGdlKTsNCj4+ICsgICAgICAgIGlmICggZXJyICkN
Cj4+ICsgICAgICAgICAgICByZXR1cm4gZXJyOw0KPj4gKyAgICB9DQo+PiArICAgIHJldHVybiAw
Ow0KPj4gK30NCj4+ICsNCj4+ICtpbnQgcGNpX2hvc3RfZ2V0X251bV9icmlkZ2VzKHZvaWQpDQo+
PiArew0KPj4gKyAgICBzdHJ1Y3QgcGNpX2hvc3RfYnJpZGdlICpicmlkZ2U7DQo+PiArICAgIGlu
dCBjb3VudCA9IDA7DQo+PiArDQo+PiArICAgIGxpc3RfZm9yX2VhY2hfZW50cnkoIGJyaWRnZSwg
JnBjaV9ob3N0X2JyaWRnZXMsIG5vZGUgKQ0KPj4gKyAgICAgICAgY291bnQrKzsNCj4+ICsNCj4+
ICsgICAgcmV0dXJuIGNvdW50Ow0KPj4gK30NCj4+ICsNCj4+ICAgLyoNCj4+ICAgICogTG9jYWwg
dmFyaWFibGVzOg0KPj4gICAgKiBtb2RlOiBDDQo+PiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gvYXJt
L3ZwY2kuYyBiL3hlbi9hcmNoL2FybS92cGNpLmMNCj4+IGluZGV4IDc2YzEyYjkyODE0Zi4uNWQ2
YzI5YzhkY2Q5IDEwMDY0NA0KPj4gLS0tIGEveGVuL2FyY2gvYXJtL3ZwY2kuYw0KPj4gKysrIGIv
eGVuL2FyY2gvYXJtL3ZwY2kuYw0KPj4gQEAgLTgwLDE3ICs4MCw1MCBAQCBzdGF0aWMgY29uc3Qg
c3RydWN0IG1taW9faGFuZGxlcl9vcHMgdnBjaV9tbWlvX2hhbmRsZXIgPSB7DQo+PiAgICAgICAu
d3JpdGUgPSB2cGNpX21taW9fd3JpdGUsDQo+PiAgIH07DQo+PiAgIA0KPj4gK3N0YXRpYyBpbnQg
dnBjaV9zZXR1cF9tbWlvX2hhbmRsZXIoc3RydWN0IGRvbWFpbiAqZCwNCj4+ICsgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgIHN0cnVjdCBwY2lfaG9zdF9icmlkZ2UgKmJyaWRnZSkN
Cj4+ICt7DQo+PiArICAgIHN0cnVjdCBwY2lfY29uZmlnX3dpbmRvdyAqY2ZnID0gYnJpZGdlLT5j
Zmc7DQo+PiArDQo+PiArICAgIHJlZ2lzdGVyX21taW9faGFuZGxlcihkLCAmdnBjaV9tbWlvX2hh
bmRsZXIsDQo+PiArICAgICAgICAgICAgICAgICAgICAgICAgICBjZmctPnBoeXNfYWRkciwgY2Zn
LT5zaXplLCBOVUxMKTsNCj4+ICsgICAgcmV0dXJuIDA7DQo+PiArfQ0KPj4gKw0KPj4gICBpbnQg
ZG9tYWluX3ZwY2lfaW5pdChzdHJ1Y3QgZG9tYWluICpkKQ0KPj4gICB7DQo+PiAgICAgICBpZiAo
ICFoYXNfdnBjaShkKSApDQo+PiAgICAgICAgICAgcmV0dXJuIDA7DQo+PiAgIA0KPj4gKyAgICBp
ZiAoIGlzX2hhcmR3YXJlX2RvbWFpbihkKSApDQo+PiArICAgICAgICByZXR1cm4gcGNpX2hvc3Rf
aXRlcmF0ZV9icmlkZ2VzKGQsIHZwY2lfc2V0dXBfbW1pb19oYW5kbGVyKTsNCj4+ICsNCj4+ICsg
ICAgLyogR3Vlc3QgZG9tYWlucyB1c2Ugd2hhdCBpcyBwcm9ncmFtbWVkIGluIHRoZWlyIGRldmlj
ZSB0cmVlLiAqLw0KPj4gICAgICAgcmVnaXN0ZXJfbW1pb19oYW5kbGVyKGQsICZ2cGNpX21taW9f
aGFuZGxlciwNCj4+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBHVUVTVF9WUENJX0VDQU1f
QkFTRSwgR1VFU1RfVlBDSV9FQ0FNX1NJWkUsIE5VTEwpOw0KPj4gICANCj4+ICAgICAgIHJldHVy
biAwOw0KPj4gICB9DQo+PiAgIA0KPj4gK2ludCBkb21haW5fdnBjaV9nZXRfbnVtX21taW9faGFu
ZGxlcnMoc3RydWN0IGRvbWFpbiAqZCkNCj4+ICt7DQo+PiArICAgIGludCBjb3VudDsNCj4+ICsN
Cj4+ICsgICAgaWYgKCBpc19oYXJkd2FyZV9kb21haW4oZCkgKQ0KPj4gKyAgICAgICAgLyogRm9y
IGVhY2ggUENJIGhvc3QgYnJpZGdlJ3MgY29uZmlndXJhdGlvbiBzcGFjZS4gKi8NCj4+ICsgICAg
ICAgIGNvdW50ID0gcGNpX2hvc3RfZ2V0X251bV9icmlkZ2VzKCk7DQo+PiArICAgIGVsc2UNCj4+
ICsgICAgICAgIC8qDQo+PiArICAgICAgICAgKiBWUENJX01TSVhfTUVNX05VTSBoYW5kbGVycyBm
b3IgTVNJLVggdGFibGVzIHBlciBlYWNoIFBDSSBkZXZpY2UNCj4+ICsgICAgICAgICAqIGJlaW5n
IHBhc3NlZCB0aHJvdWdoLiBNYXhpbXVtIG51bWJlciBvZiBzdXBwb3J0ZWQgZGV2aWNlcw0KPj4g
KyAgICAgICAgICogaXMgMzIgYXMgdmlydHVhbCBidXMgdG9wb2xvZ3kgZW11bGF0ZXMgdGhlIGRl
dmljZXMgYXMgZW1iZWRkZWQNCj4+ICsgICAgICAgICAqIGVuZHBvaW50cy4NCj4+ICsgICAgICAg
ICAqICsxIGZvciBhIHNpbmdsZSBlbXVsYXRlZCBob3N0IGJyaWRnZSdzIGNvbmZpZ3VyYXRpb24g
c3BhY2UuICovDQo+IENvZGUgc3R5bGU6IFhlbiBtdWx0aWxpbmUgY29tbWVudHMgYXJlIGxpa2Ug
dGhpczoNCldpbGwgZml4DQo+DQo+IC8qDQo+ICAgKiBjb21tZW50DQo+ICAgKiBtb3JlIGNvbW1l
bnQNCj4gICAqLw0KPg0KPiBBc2lkZSBmcm9tIHRoaXMgbWlub3IgY29tbWVudDoNCj4NCj4gUmV2
aWV3ZWQtYnk6IFN0ZWZhbm8gU3RhYmVsbGluaSA8c3N0YWJlbGxpbmlAa2VybmVsLm9yZz4NCj4N
Cj4NCj4+ICsgICAgICAgIGNvdW50ID0gVlBDSV9NU0lYX01FTV9OVU0gKiAzMiArIDE7DQo+PiAr
DQo+PiArICAgIHJldHVybiBjb3VudDsNCj4+ICt9DQo+PiArDQo+PiAgIC8qDQo+PiAgICAqIExv
Y2FsIHZhcmlhYmxlczoNCj4+ICAgICogbW9kZTogQw0KPj4gZGlmZiAtLWdpdCBhL3hlbi9hcmNo
L2FybS92cGNpLmggYi94ZW4vYXJjaC9hcm0vdnBjaS5oDQo+PiBpbmRleCBkOGE3YjBlM2U4MDIu
LjI3YTJiMDY5YWJkMiAxMDA2NDQNCj4+IC0tLSBhL3hlbi9hcmNoL2FybS92cGNpLmgNCj4+ICsr
KyBiL3hlbi9hcmNoL2FybS92cGNpLmgNCj4+IEBAIC0xNywxMSArMTcsMTcgQEANCj4+ICAgDQo+
PiAgICNpZmRlZiBDT05GSUdfSEFTX1ZQQ0kNCj4+ICAgaW50IGRvbWFpbl92cGNpX2luaXQoc3Ry
dWN0IGRvbWFpbiAqZCk7DQo+PiAraW50IGRvbWFpbl92cGNpX2dldF9udW1fbW1pb19oYW5kbGVy
cyhzdHJ1Y3QgZG9tYWluICpkKTsNCj4+ICAgI2Vsc2UNCj4+ICAgc3RhdGljIGlubGluZSBpbnQg
ZG9tYWluX3ZwY2lfaW5pdChzdHJ1Y3QgZG9tYWluICpkKQ0KPj4gICB7DQo+PiAgICAgICByZXR1
cm4gMDsNCj4+ICAgfQ0KPj4gKw0KPj4gK3N0YXRpYyBpbmxpbmUgaW50IGRvbWFpbl92cGNpX2dl
dF9udW1fbW1pb19oYW5kbGVycyhzdHJ1Y3QgZG9tYWluICpkKQ0KPj4gK3sNCj4+ICsgICAgcmV0
dXJuIDA7DQo+PiArfQ0KPj4gICAjZW5kaWYNCj4+ICAgDQo+PiAgICNlbmRpZiAvKiBfX0FSQ0hf
QVJNX1ZQQ0lfSF9fICovDQo+PiBkaWZmIC0tZ2l0IGEveGVuL2luY2x1ZGUvYXNtLWFybS9wY2ku
aCBiL3hlbi9pbmNsdWRlL2FzbS1hcm0vcGNpLmgNCj4+IGluZGV4IDU2NmE5NDM2YTE4ZS4uMGQw
MjY2YjEzY2JhIDEwMDY0NA0KPj4gLS0tIGEveGVuL2luY2x1ZGUvYXNtLWFybS9wY2kuaA0KPj4g
KysrIGIveGVuL2luY2x1ZGUvYXNtLWFybS9wY2kuaA0KPj4gQEAgLTEwOCw2ICsxMDgsMTEgQEAg
c3RhdGljIGFsd2F5c19pbmxpbmUgYm9vbCBpc19wY2lfcGFzc3Rocm91Z2hfZW5hYmxlZCh2b2lk
KQ0KPj4gICANCj4+ICAgdm9pZCBhcmNoX3BjaV9pbml0X3BkZXYoc3RydWN0IHBjaV9kZXYgKnBk
ZXYpOw0KPj4gICANCj4+ICtpbnQgcGNpX2hvc3RfaXRlcmF0ZV9icmlkZ2VzKHN0cnVjdCBkb21h
aW4gKmQsDQo+PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICBpbnQgKCpjbGIpKHN0cnVj
dCBkb21haW4gKmQsDQo+PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
IHN0cnVjdCBwY2lfaG9zdF9icmlkZ2UgKmJyaWRnZSkpOw0KPj4gK2ludCBwY2lfaG9zdF9nZXRf
bnVtX2JyaWRnZXModm9pZCk7DQo+PiArDQo+PiAgICNlbHNlICAgLyohQ09ORklHX0hBU19QQ0kq
Lw0KPj4gICANCj4+ICAgc3RydWN0IGFyY2hfcGNpX2RldiB7IH07DQo+PiAtLSANCj4+IDIuMjUu
MQ0KPj4NCg==


From xen-devel-bounces@lists.xenproject.org Fri Oct 01 07:12:22 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Oct 2021 07:12:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.200415.354937 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mWCiE-00034t-OZ; Fri, 01 Oct 2021 07:12:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 200415.354937; Fri, 01 Oct 2021 07:12:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mWCiE-00034m-LR; Fri, 01 Oct 2021 07:12:06 +0000
Received: by outflank-mailman (input) for mailman id 200415;
 Fri, 01 Oct 2021 07:12:05 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=22t+=OV=epam.com=prvs=09080f3fa0=oleksandr_andrushchenko@srs-us1.protection.inumbo.net>)
 id 1mWCiD-00034g-CV
 for xen-devel@lists.xenproject.org; Fri, 01 Oct 2021 07:12:05 +0000
Received: from mx0a-0039f301.pphosted.com (unknown [148.163.133.242])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id e0d9640e-2286-11ec-bd94-12813bfff9fa;
 Fri, 01 Oct 2021 07:12:04 +0000 (UTC)
Received: from pps.filterd (m0174677.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 1916xOe1017939; 
 Fri, 1 Oct 2021 07:12:02 GMT
Received: from eur04-he1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2055.outbound.protection.outlook.com [104.47.13.55])
 by mx0a-0039f301.pphosted.com with ESMTP id 3bdwhsr1n4-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Fri, 01 Oct 2021 07:12:01 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by VI1PR0302MB3470.eurprd03.prod.outlook.com (2603:10a6:803:1f::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.15; Fri, 1 Oct
 2021 07:11:59 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::e966:6290:5736:b7bd]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::e966:6290:5736:b7bd%7]) with mapi id 15.20.4566.015; Fri, 1 Oct 2021
 07:11:58 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e0d9640e-2286-11ec-bd94-12813bfff9fa
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=TyFOx7v7Mx+h+Ll5M1j1rA2/44gTVpwNfiQcpmHK+Q+cUn4kfkrL7YPMjPYnhuiZtFZCSKQbnfg1CKn5Noa4U8rS/umCrRLzQeslna89Dk+KgchvrDdlodz+WCqtH79g+jyTwrSiPJ33L7819wfSR6o+EKXvoZZ660kXPz7gPDN1xDKfXj9CZauWqe1ml9XNHnLQqkQTLp0CqQxwj2MvUfP/IE24Lch5EvoDf8uxCebrit69D3RtF6pu9skdJCqRt0Tqv3OSG8BDfrq7i1SMaMoIsd6Y9850GdI7/FeMyOXvkt0i2OdCyvWuYvg0YOvgPZWReT7pNp4UfwfRg0X1qw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=FOaDHZkgcRQbYueAnxlvdHHKOop6q82+9hNK1tPzRDo=;
 b=GQ/SIgloxGbKUzrS9r2PydxcHumQ/NuNnvsU8XYALyw0t0/8a4nuvWn8pKb0JNk5R23yl+jQ7n8C7RaHZaYuqzz0w7bwmU8TygrsMQEa8kjjPqmHJP+RrqdcOttdcik5KVK8U9PuqMXYgEPMYGZpoKI2+5W4dVLf4s9q/Xw5cJH2pslpQQt7/uTohV75ez9bWw3qT2852ecX65Gn2glt98vKawXoMvY88/ibZmoA3mc9zSdWB6gUNLbC6h9dnFIMo0hhYdic0XN5VCk4JiE3Nx5sE5/mRzIu6XEvH8zaWI9xmXvgzadPJz0GUXz956+jDWimVDznC0BKyWV1YFhsHw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=FOaDHZkgcRQbYueAnxlvdHHKOop6q82+9hNK1tPzRDo=;
 b=kRXcdWf3AYXXbq/k1n9EL7JiuQZYPWGn5fgZKbZtVXiugCsGOGOf+/5lm0eYOSWsbI9qIBjgycj5WEW+DSAkQmsrxP5CgVQ1Cu6ys2nkws+fbgYdgS+5AaMv68fUom0S3J6Krxa/svRqNcYc62ITnvl4qoxwHN3k1CZiWTKiju3yf7SsH2DlGn0VZ6+LSdNEuAdvZbbdtVldt6G2wKpdXCvLfUnIDxKyoTpF5jyxBC/LOD3NHG4sG1Lix/RMszIjs0tWHVIC3TgQZ8dMw6ZiqAYTMhde0ecHv9dcgaZNFP5BSsJ8hQgnzMCBX22nOPnzCmJauQs0mBj9NeC8Fbr9Zw==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Stefano Stabellini <sstabellini@kernel.org>,
        Jan Beulich
	<jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        "julien@xen.org" <julien@xen.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "roger.pau@citrix.com" <roger.pau@citrix.com>,
        Bertrand Marquis
	<bertrand.marquis@arm.com>,
        Rahul Singh <rahul.singh@arm.com>,
        Oleksandr
 Andrushchenko <Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH v3 05/11] xen/arm: Mark device as PCI while creating one
Thread-Topic: [PATCH v3 05/11] xen/arm: Mark device as PCI while creating one
Thread-Index: AQHXtcqxBmbIjyoLuU2towH4iHJ8hau9TJiAgABvEQA=
Date: Fri, 1 Oct 2021 07:11:58 +0000
Message-ID: <8641a887-f579-bb73-781d-403917a7b765@epam.com>
References: <20210930071326.857390-1-andr2000@gmail.com>
 <20210930071326.857390-6-andr2000@gmail.com>
 <alpine.DEB.2.21.2109301733250.3209@sstabellini-ThinkPad-T480s>
In-Reply-To: <alpine.DEB.2.21.2109301733250.3209@sstabellini-ThinkPad-T480s>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
authentication-results: kernel.org; dkim=none (message not signed)
 header.d=none;kernel.org; dmarc=none action=none header.from=epam.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 3cbe488e-25d4-4d4b-6ab3-08d984aac25c
x-ms-traffictypediagnostic: VI1PR0302MB3470:
x-ms-exchange-transport-forked: True
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <VI1PR0302MB34704F19F7E0CC9885050F42E7AB9@VI1PR0302MB3470.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:5516;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 O9B8ZaA7T5mWglmLN4wxQXM88Hbn10Fv7ArYezvrWFSJDOVLgBa7cZtBLZ1skAS+idB7Jz4ncbEBoQRUPRMipKB8gZFUlMX/UTJlQ35EpLrHMPwt8AIQovmHZKwj9Vbe7esBArdS8V+UCH4bvWyb4lt9RD0tnO1D8eItGBy85PT44L034idoU110kFv3PBjibCC7lZMHNbkVoVeF8MVhonjoWY2xS/y9P08IZjUmD6NPb1e8Xx7JQaxPnMDUxJir3xHsZyy4K7l95zfGwPYp5ak0OL0mr4wLmLjEfnJ/kq0a3YM8Wen1JaEuGJHAzOXpp8FwFfQ7JX6WNuPaohele/onm9S38Bg0Nz9slEnr7X2Vgoj6ub/Zo9J/PbDXD77xb3nqPxJtTkTB7VpwjDQkrn66IZTD9A0oVwgIZ0mOxfFKEKU1t3QsBrpj4v0/m1tsUuFNkPAoNiZX9WObIszqKh9KCX5ZIh3LZrDoBOu6YbZl9wRzipgLRIVp3y6vEQfXzVWOR5SybYpIAZlCAlaPj8yU2wwNG+z0ytGdCZfuQPAwY1lht4aT4BtjymU0pFa/77uyqBDmq+/5eSeSZrK6HeHtKKhkgLbqv9XC0dUksZyYHKa7QWVi6A5mJyFs4VyFaxZraWhxihO7DK0hbOmHbK87jyewXPsbNoasEwJ3zrwNddARtrC/lv7wUpzXqCErtqCqMjSMIBWs7Lv7OG07XOvv89jL14WDV+WW1/bOrrpWWVx3qCGyeviSO85/+TDh
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(316002)(4326008)(508600001)(2906002)(110136005)(53546011)(2616005)(71200400001)(8936002)(5660300002)(26005)(6506007)(8676002)(186003)(54906003)(107886003)(38070700005)(86362001)(122000001)(31696002)(36756003)(6486002)(38100700002)(6512007)(66446008)(83380400001)(64756008)(66556008)(66476007)(66946007)(91956017)(76116006)(31686004)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?dDczRkNkTzFOWEhJd1NSaWZtcFFZem1mU0pROGg4V3Zydzd6MTNzS2dEeGV1?=
 =?utf-8?B?QUpNd1NobEJ2WDZHRFpkRktNL3d6ZmV6M0V2YXdIcC9VdDhiSkp6a2FoM0VQ?=
 =?utf-8?B?c0p6S2d4REdhTHM0azNueFYrTW1SREFIbFo5WmFMZlRhL0JFUTZPZ1c0eGw2?=
 =?utf-8?B?NTkvb1M0bDZWcDJ6Q1hKYW5qbVlDUnF3QU1QQXh6Q1BTWTBrWGZxLzhrYTJ2?=
 =?utf-8?B?YnJBWWVXMmlrTTFaZklGQWN4K3F5dVBQU244ZVpjc0duNmFaZEFGeFhDc1Nj?=
 =?utf-8?B?YVNrSzVhZ0ZwTGV6ZW1pQ0dWdmxhd3JhVVJsbnZ5WWNNU01rTU9NS0h6Mm5E?=
 =?utf-8?B?Tk1IaklhaXB3d3RHcENqWk9scyt5WVhoZkZmMXFSVEo1UDhnUVRrdjFWemhm?=
 =?utf-8?B?SU9LcHA1SGxkOEpXM0F4ZlRBNWtCRU1aczRQb2ovQ0NNRjJVcThkN21kTWxB?=
 =?utf-8?B?MFpkZ08zMys3TFNpSGF2TTlFWEtsdjdzMEgxVXRwRlo4and4UjEwNWNKcVJn?=
 =?utf-8?B?ZUJQblVmcDQrMHhObWlMbWNXZGFVTis2TXZNTG96YTV6VHNDK2Y3dnlvL0cz?=
 =?utf-8?B?d0oxK2xUTFF1ZUsreldXd1NTZ0FYZzhGRUU2Vlh4YW9Zdm0vNWViWEZrZHow?=
 =?utf-8?B?TXU4RHRnS0hXUkR0TFdHSVNZTGhLbUpSSGhQTExoUG1kRE1LR216eTJ0WllV?=
 =?utf-8?B?ZXpkRXRjVjBnU2RXUDM3TlpVdzhXZlduRlppbVBXVDZqbWFuWVR4aWFUd1hn?=
 =?utf-8?B?d1NpY2NvZlY4YVd1WXhPZUNTdUhod0pjREQ0Mit1SUxCUVlxTGM5alFUc3Zp?=
 =?utf-8?B?NmYwSXlxUVJjTXhMa2VKMjQyVHF3Rmp0bTA5bE1zMEViSzdSNUNaWFRPYi9y?=
 =?utf-8?B?eTF4R3k3TXF5bWkrRVdrWkFiUWZuK082RWNsQ0FxOVJNQ1h3ZTB0bHFTc0lh?=
 =?utf-8?B?RGxIeW5IZG1zVllTMlJkMDlhZ1V2SWZubTRIbjFIR0h1Q2srejBUQVNQa29t?=
 =?utf-8?B?RGYzTmF1NnQvL1daRTVNNm5tMXRmTXBmc1RYUkZSbDlVSXozMktFem9PQW01?=
 =?utf-8?B?YWY0aGJzMktkSlVFVXBDZEVZT0RldlVnUFgyR1hPNDhicjE3YWhFTGNyZ05u?=
 =?utf-8?B?RHV3SjJ1c011VEFLN0U2NGw1Uzd4dVdTUnZzcE50WG1WOW52cm1MdkpqVjMx?=
 =?utf-8?B?RUhtYi9BbDZNTHpBYS9qb085N01iaTYrMmJYNXd5elJFNWJ0cTlJcVBhT05J?=
 =?utf-8?B?SXZrMzZQWFcyTk53RFAyWFh3bFdhOGUyeTQxazdXaVZESHY5RWVEMFJISkk4?=
 =?utf-8?B?anFMYmY0Z05sQWZOSmREenRGM1B6S05oYnpLTlpyM0NBY1VYTWdVVXZ0VzlK?=
 =?utf-8?B?NG9RMEl4QWtpTXFVbklnWWtKL3lCZjNSK1dVcjVmM25qbkFpVGhSd25YRXdm?=
 =?utf-8?B?S3hsV3E0aFlUVkxqL3psTlpLMlRycmJVdmJNUVN3akRtT2VtMis2TmpzVkJM?=
 =?utf-8?B?SHRvTUVEclV0eFRiTHJpdndwcFpoMFY4ZmRSQXFjQzdHeEF4OUc5U0dFK2wr?=
 =?utf-8?B?U2c4NnErWEE3N0Zwcmg2eDc1cGN2MlZkeGZvamFEZ2crVDVwMDdFN2ZXVFR4?=
 =?utf-8?B?ZHlrc0dyM3orK2RLelArNkhhUXZQR2N4WU56SlBsUjJHL2dSbHZVUjdZREow?=
 =?utf-8?B?YzZXb1Z2QWpFcG5CbDgxUXZjZ2M4Z0FKaU15WmJsWnlUWFVLbzJ3M2ExMnR5?=
 =?utf-8?Q?3caFQL14QigmLsNHamk2LdoAMsnedunraUVGzGS?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <DB01A9980C4E6D49B63748B2FE63A2DA@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3cbe488e-25d4-4d4b-6ab3-08d984aac25c
X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Oct 2021 07:11:58.7977
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: nM40KrBcLsr5A5TdrIJIkc92XklQzQm3zywxmPBpXx9JIpWZ1XTcrtHn3fS22z9F3sAkmMsE2mfjezU3/xaeO0zy+hfH9bKHado2j1pxX1LKq9xcQAkp6fox2GGqrJ9p
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0302MB3470
X-Proofpoint-ORIG-GUID: dIHrmShFm-6RliGSvRMSDdX3med1pLoJ
X-Proofpoint-GUID: dIHrmShFm-6RliGSvRMSDdX3med1pLoJ
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.391,FMLib:17.0.607.475
 definitions=2021-09-30_07,2021-09-30_01,2020-04-07_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 suspectscore=0
 spamscore=0 mlxlogscore=999 lowpriorityscore=0 malwarescore=0 bulkscore=0
 clxscore=1015 phishscore=0 priorityscore=1501 impostorscore=0 adultscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109230001
 definitions=main-2110010048

DQoNCk9uIDAxLjEwLjIxIDAzOjM0LCBTdGVmYW5vIFN0YWJlbGxpbmkgd3JvdGU6DQo+IE9uIFRo
dSwgMzAgU2VwIDIwMjEsIE9sZWtzYW5kciBBbmRydXNoY2hlbmtvIHdyb3RlOg0KPj4gRnJvbTog
T2xla3NhbmRyIEFuZHJ1c2hjaGVua28gPG9sZWtzYW5kcl9hbmRydXNoY2hlbmtvQGVwYW0uY29t
Pg0KPj4NCj4+IFdoaWxlIGFkZGluZyBhIFBDSSBkZXZpY2UgbWFyayBpdCBhcyBzdWNoLCBzbyBv
dGhlciBmcmFtZXdvcmtzDQo+PiBjYW4gZGlzdGluZ3Vpc2ggaXQgZnJvbSBEVCBkZXZpY2VzLg0K
Pj4gRm9yIHRoYXQgaW50cm9kdWNlIGFuIGFyY2hpdGVjdHVyZSBkZWZpbmVkIGhlbHBlciB3aGlj
aCBtYXkgcGVyZm9ybQ0KPj4gYWRkaXRpb25hbCBpbml0aWFsaXphdGlvbiBvZiB0aGUgbmV3bHkg
Y3JlYXRlZCBQQ0kgZGV2aWNlLg0KPj4NCj4+IFNpZ25lZC1vZmYtYnk6IE9sZWtzYW5kciBBbmRy
dXNoY2hlbmtvIDxvbGVrc2FuZHJfYW5kcnVzaGNoZW5rb0BlcGFtLmNvbT4NCj4gSSBnZXQgYSBi
dWlsZCBmYWlsdXJlIHdpdGhvdXQgQ09ORklHX1BDSSBvbiBBUk02NDoNCj4NCj4gSW4gZmlsZSBp
bmNsdWRlZCBmcm9tIC9sb2NhbC9yZXBvcy94ZW4tdXBzdHJlYW0veGVuL2luY2x1ZGUveGVuL3Bj
aS5oOjY2OjAsDQo+ICAgICAgICAgICAgICAgICAgIGZyb20gL2xvY2FsL3JlcG9zL3hlbi11cHN0
cmVhbS94ZW4vaW5jbHVkZS94ZW4vaW9tbXUuaDoyNSwNCj4gICAgICAgICAgICAgICAgICAgZnJv
bSAvbG9jYWwvcmVwb3MveGVuLXVwc3RyZWFtL3hlbi9pbmNsdWRlL3hlbi9zY2hlZC5oOjEyLA0K
PiAgICAgICAgICAgICAgICAgICBmcm9tIGFyY2gvYXJtL2FybTY0L2FzbS1vZmZzZXRzLmM6OToN
Cj4gL2xvY2FsL3JlcG9zL3hlbi11cHN0cmVhbS94ZW4vaW5jbHVkZS9hc20vcGNpLmg6MTI3OjQ2
OiBlcnJvcjog4oCYc3RydWN0IHBjaV9kZXbigJkgZGVjbGFyZWQgaW5zaWRlIHBhcmFtZXRlciBs
aXN0IHdpbGwgbm90IGJlIHZpc2libGUgb3V0c2lkZSBvZiB0aGlzIGRlZmluaXRpb24gb3IgZGVj
bGFyYXRpb24gWy1XZXJyb3JdDQo+ICAgc3RhdGljIGlubGluZSB2b2lkIGFyY2hfcGNpX2luaXRf
cGRldihzdHJ1Y3QgcGNpX2RldiAqcGRldikge30NCj4gICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICBefn5+fn5+DQo+IGNjMTogYWxsIHdhcm5pbmdzIGJlaW5n
IHRyZWF0ZWQgYXMgZXJyb3JzDQpBaCwgdGhpcyB0aGVuIG5lZWRzIHRvIGJlDQpzdHJ1Y3QgcGNp
X2RldjsNCg0Kc3RhdGljIGlubGluZSB2b2lkIGFyY2hfcGNpX2luaXRfcGRldihzdHJ1Y3QgcGNp
X2RldiAqcGRldikge30NCg0KSmFuLCBhcyB0aGlzIGlzIGdvaW5nIHRvIGJlIEFybSBjaGFuZ2Us
IHNvIGNhbiBJIGtlZXAgeW91ciBBY2sgcGxlYXNlPw0KDQpUaGFuayB5b3UsDQpPbGVrc2FuZHI=


From xen-devel-bounces@lists.xenproject.org Fri Oct 01 07:39:02 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Oct 2021 07:39:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.200433.354948 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mWD87-0005zg-VT; Fri, 01 Oct 2021 07:38:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 200433.354948; Fri, 01 Oct 2021 07:38:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mWD87-0005zZ-SD; Fri, 01 Oct 2021 07:38:51 +0000
Received: by outflank-mailman (input) for mailman id 200433;
 Fri, 01 Oct 2021 07:38:50 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=KCT2=OV=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mWD86-0005zT-G5
 for xen-devel@lists.xenproject.org; Fri, 01 Oct 2021 07:38:50 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 9d75c56e-228a-11ec-bd96-12813bfff9fa;
 Fri, 01 Oct 2021 07:38:49 +0000 (UTC)
Received: from EUR03-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur03lp2052.outbound.protection.outlook.com [104.47.10.52]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-38-yTekr-byP9KYo0PwxfznLA-1; Fri, 01 Oct 2021 09:38:47 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB4605.eurprd04.prod.outlook.com (2603:10a6:803:65::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.18; Fri, 1 Oct
 2021 07:38:44 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4566.014; Fri, 1 Oct 2021
 07:38:44 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS8PR04CA0109.eurprd04.prod.outlook.com (2603:10a6:20b:31e::24) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.19 via Frontend
 Transport; Fri, 1 Oct 2021 07:38:43 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9d75c56e-228a-11ec-bd96-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1633073928;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=un8cewv+5XiF86rYpM9Kna5lC2JX9xinmMFx65Wv6rk=;
	b=L1drohkhPkTwyAFCZZvVKUHE8/aycU5TddEA9cv4Qb8AExeS4a1i1XZ3JNQ7IW/AdZ/cWP
	tAZ7Ej0vZzGH+XKLX5dpxMA1FQi/9TTq6lqqm4GdS+8pRyS0t2hrbgF/ESXD/mzOvDH3z7
	CxGiWzXI6NvZPdKJ39vDQfOxbtUnnxQ=
X-MC-Unique: yTekr-byP9KYo0PwxfznLA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=NBChRCwWzIK9ZXy7Lvm8m4Sq1dgroFrVNN9Cy2UuK0ls2lvdTbWcNEX1Axxvmw4ass2qFINPrvQw7gJWafJ8svwJ8Qv8K239tLZtzLL80lJBhiSv6zeuBxp/jPURBofQMKXYOPsYEiSGpDzRG4pK6reoriUo3SDKM3ZBQUgBVxyOJ0n9gUhaxYV45+9snQ+cFLfdL+v1D/UKOH/98swlF2Ujrxd96XfmBw/53GdgYphzVWN5NA/oEW9dYV5c9GUSTMf4ZwsYvldOWJKYiu1cjTmKFg10GHxsh1cAYX66QPXwc2TptNympPahCOonwtYaA53YjyyfFxi1rL8kPZlzlA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=tZVg+2B5aThpQgfrfAXQsiwDuMSxNZvMVYryRGymatc=;
 b=HyJnbiovKyAvNz8+oTJcOOnezojlQ2pSWtqN+lGD1FtonHcaQpY8pp6n2MyfeFqMfCAI8dCbFgnRKj2qKF79dJoRk66Ibp7rn+yzHI3ZgLShu9YXEjwg8+zahWVmaOuSB0NPz36OW0xAH1d/qKcbPBmKD9WSQXuAWxUvN8wFvzM72ws4k4cX6Q6jG2vtiGhpfj2xNZcckZxGjoXs4MlOgZjZwwtiSK2OQdZi4gDIfjpINANmD59JIcnL7/Dpd4We4siXoEiJ5mhPNOJmoKaT8HXVUYCdwJPnJYWEQXlVs1pH6xALlPuCPvcnfcejgCOFbwGu0dbb5k1JziMHsC6MEQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: kernel.org; dkim=none (message not signed)
 header.d=none;kernel.org; dmarc=none action=none header.from=suse.com;
Subject: Re: [PATCH v3 05/11] xen/arm: Mark device as PCI while creating one
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 "julien@xen.org" <julien@xen.org>,
 Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Artem Mygaiev <Artem_Mygaiev@epam.com>,
 "roger.pau@citrix.com" <roger.pau@citrix.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Rahul Singh <rahul.singh@arm.com>,
 Stefano Stabellini <sstabellini@kernel.org>
References: <20210930071326.857390-1-andr2000@gmail.com>
 <20210930071326.857390-6-andr2000@gmail.com>
 <alpine.DEB.2.21.2109301733250.3209@sstabellini-ThinkPad-T480s>
 <8641a887-f579-bb73-781d-403917a7b765@epam.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <8ba874e2-89ca-2647-76f5-885f8b16d426@suse.com>
Date: Fri, 1 Oct 2021 09:38:41 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <8641a887-f579-bb73-781d-403917a7b765@epam.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS8PR04CA0109.eurprd04.prod.outlook.com
 (2603:10a6:20b:31e::24) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 63b8e308-fdbb-43b4-5022-08d984ae7f40
X-MS-TrafficTypeDiagnostic: VI1PR04MB4605:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB46056B5C9838569D6C01E530B3AB9@VI1PR04MB4605.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8273;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	aeyhFiB/W5h2o8JqEHuj803DFmVBO/XfBiJ61Te5sS1bcVYQj722VpSQIbzIlBCHRplJX97hUukQR3WL7gGKBBbQrjeEuMyZcwE02Nn2ccyfBzpJ4zkoQR2g06C7QbMDFXeQNm7VUZ5QKubgNAYxUM00jeQaAIrXmBKB08L8P0buXn9cNq3MnOifVNlgkwOcFISVzAOnyXPi0RzQspRYYK0deEA5fUoliqSTNbirPgnT3uED8UyCZzKpRXym91mX6+OsqrXYtVNayMiMZNOaxYWOH5nM/SnZV/073Caohh01UUZejm57rQZapKRCOPREYNJLE2hAEwrqREQr9Xbz2rw29abMDyWbg0SAUA5Bmzp9+fWSFFFkC14HAcPHVCdF+qs75eC/jPr9WhQdfeFCPdtg8tM49L0AhZqjFWAOPXG++P2+drwObJCn2RvP1ieh6ruoXoq+LkaZvJh0VUu//vm6x8cNrZRlbRiYfkcE6PBmziUIvlPmBswyYdr7KOn01pjOnxhX7ZBDXkOajpZg9cPipwTfv3FHorbs12Cn/Sh5YVzaPQbIQzqS0UgFHrWKLoE2dREccmdQ6Ar6XWiDycYkZ79YMzpC0peOLk6GixLC6SDDUphrHLI0jq5uHMBNE08w5RP/M9ptM0BJL0WmNbp5TrmlmNgLzrbnDXftDAp8Gjz7Z/4xVN+meaitT3teYmC41kQL3/vHra/BsXrldBFHgp3EQSzLFMV9xnUT6DQ=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(2906002)(186003)(38100700002)(7416002)(8936002)(26005)(8676002)(36756003)(31696002)(316002)(4326008)(6486002)(86362001)(54906003)(66946007)(508600001)(5660300002)(956004)(66556008)(66476007)(2616005)(31686004)(6916009)(16576012)(53546011)(83380400001)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?CEyPspERchX65H6hEvI0Nze5pHEbqzlkWlez94F40fx4bwNQYi+tu01UdReZ?=
 =?us-ascii?Q?RTYODcMvtK3tvNIJ1J7d7jUqJC3T8XokCYaHp7dkb3pY9SOdM0h5A06uLMvZ?=
 =?us-ascii?Q?5hrZYY69JJA4LoYEe4OkQo7lnIvauXAvZ4cZ0YbmddvoMA+uuLaIimRXj1ru?=
 =?us-ascii?Q?CZPPuv6V2VjuXjXhIVkcZMrcLoqNvkJ6z4Qr+cpqUnimvSDOqiWUWhzt5QkF?=
 =?us-ascii?Q?QDTZIbIgC28MyeCEWI4aaZ4Pvq6Py9ggds/ranbjOIjiXNn4VHM9CgBWgOcL?=
 =?us-ascii?Q?Ce+e7/9YFo30MVXsoFbGXaGedNjtNog6yrPX0H4GWHSWn9wIRgOcJSsIvZbC?=
 =?us-ascii?Q?eCsUiWw4FXLd3l27pSUFjmKyCAaE6U0gqZq+n6i6vcYe1YnAg6pi31QQsruI?=
 =?us-ascii?Q?1Jkc+zsMnvFlO9DpA6ZEhyklptR7N23hTWUbWa5vHrJZT+i8xPa4p20YhrB7?=
 =?us-ascii?Q?xx58xT1hbLtZpfmhZU/ZTyfwWZgJBY+JLaOUqBvZ1NAYUNUIsp/A/sPC9tig?=
 =?us-ascii?Q?PoGuIPJkEA7cfPEwe6kSxbttTZfXYgV306iKIdaluNusoFd4Mz5PUbW9fbFk?=
 =?us-ascii?Q?4uG5W+6t6sSsRHty7YF/p/19UFui+YKydlX0u2oUkmRCUH8zSh+oF+e0o5AC?=
 =?us-ascii?Q?E5IhqnG3/u4k5YOJoBescf0yED4u8gPnRg2zA9rJnepgr7cMjwtYslS5DyJl?=
 =?us-ascii?Q?gWVtaym9GVm7ntWPfB9QoUZmUkHq97qIbac4aF9Z/VXCoSBhoXzqu6uzCnFE?=
 =?us-ascii?Q?VJFlU3VDmiZqZW8Zalb/BtBAPQiJCePjBbAlW4amxWv3vrWIfS+2wmcwLMfq?=
 =?us-ascii?Q?b2J2f774K64cSP1i0jZrnQDSzQaNfdSndoSydcyQAZQBnh/FMnquhPs9jaPI?=
 =?us-ascii?Q?+kcKTxHZmoIwUSGdz8WlKPiwyN+cQL1fo4QVXY825zLbQZcZEZxWzhEhQJLJ?=
 =?us-ascii?Q?DdVjsKOuxuQd/wJVPc5TmIk+mK70an5UoPomMYWsnggRIKzCjsa1vl/jLiM/?=
 =?us-ascii?Q?W1PTss4GQP4lVF2w0DDCl2cAed+JEP/U9sZnjhFhNjmYbHqqJR0+zZuYBYuT?=
 =?us-ascii?Q?F52r3fXYcJjwB26E1b+LqFtKajHX7q8MIcPtcM2SzQ5wdTAdy8L4qkxOArnS?=
 =?us-ascii?Q?qve3Ap8nc+YdwfKu66cVRyt1ymc4SFkK3G/CwFjkR5U8/rY6SvuHYVu8QFFK?=
 =?us-ascii?Q?cyL/DZuzyS00dTD7bLiMHJSmsHLmY1zOZuhUquJGXV+zEIc6d0MXnRb9PA0H?=
 =?us-ascii?Q?L3KruYaATmmWHlAIywgZ3cd0P5nU8/C36mHJAeS0ClTNhyGCpP6kQeDv1nyz?=
 =?us-ascii?Q?p/3EzYH0nHqYvkbptx3W3PHb?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 63b8e308-fdbb-43b4-5022-08d984ae7f40
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Oct 2021 07:38:44.4492
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: yGdoCKxABqov8l7sY8x+zLw1+j5PLAvSpeSnDcQ3q+2RVJwBmpYD8DVzkXIdLQ/grYjFll3yCRKRQ0nfd5G3oQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4605

On 01.10.2021 09:11, Oleksandr Andrushchenko wrote:
> On 01.10.21 03:34, Stefano Stabellini wrote:
>> On Thu, 30 Sep 2021, Oleksandr Andrushchenko wrote:
>>> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
>>>
>>> While adding a PCI device mark it as such, so other frameworks
>>> can distinguish it from DT devices.
>>> For that introduce an architecture defined helper which may perform
>>> additional initialization of the newly created PCI device.
>>>
>>> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.co=
m>
>> I get a build failure without CONFIG_PCI on ARM64:
>>
>> In file included from /local/repos/xen-upstream/xen/include/xen/pci.h:66=
:0,
>>                   from /local/repos/xen-upstream/xen/include/xen/iommu.h=
:25,
>>                   from /local/repos/xen-upstream/xen/include/xen/sched.h=
:12,
>>                   from arch/arm/arm64/asm-offsets.c:9:
>> /local/repos/xen-upstream/xen/include/asm/pci.h:127:46: error: =E2=80=98=
struct pci_dev=E2=80=99 declared inside parameter list will not be visible =
outside of this definition or declaration [-Werror]
>>   static inline void arch_pci_init_pdev(struct pci_dev *pdev) {}
>>                                                ^~~~~~~
>> cc1: all warnings being treated as errors
> Ah, this then needs to be
> struct pci_dev;
>=20
> static inline void arch_pci_init_pdev(struct pci_dev *pdev) {}
>=20
> Jan, as this is going to be Arm change, so can I keep your Ack please?

Of course you can, and me having said anyway "Applicable parts" makes
me wonder why you ask. The ack clearly doesn't extend to Arm code; I
can't give (valid) acks for code I'm not a maintainer of. This would
be different for R-b, though.

Jan



From xen-devel-bounces@lists.xenproject.org Fri Oct 01 07:42:44 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Oct 2021 07:42:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.200440.354959 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mWDBr-0007Le-Fm; Fri, 01 Oct 2021 07:42:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 200440.354959; Fri, 01 Oct 2021 07:42:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mWDBr-0007LX-Ca; Fri, 01 Oct 2021 07:42:43 +0000
Received: by outflank-mailman (input) for mailman id 200440;
 Fri, 01 Oct 2021 07:42:42 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=KCT2=OV=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mWDBq-0007LN-Qb
 for xen-devel@lists.xenproject.org; Fri, 01 Oct 2021 07:42:42 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 27d40ad6-228b-11ec-bd96-12813bfff9fa;
 Fri, 01 Oct 2021 07:42:41 +0000 (UTC)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2109.outbound.protection.outlook.com [104.47.18.109])
 (Using TLS) by relay.mimecast.com with ESMTP id
 de-mta-31-KYWTeJ7yOqS9wIYvo3mRKw-1; Fri, 01 Oct 2021 09:42:39 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0401MB2336.eurprd04.prod.outlook.com (2603:10a6:800:27::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.19; Fri, 1 Oct
 2021 07:42:38 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4566.014; Fri, 1 Oct 2021
 07:42:38 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6P193CA0054.EURP193.PROD.OUTLOOK.COM (2603:10a6:209:8e::31) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4566.15 via Frontend Transport; Fri, 1 Oct 2021 07:42:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 27d40ad6-228b-11ec-bd96-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1633074160;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=9xP72K9E84/Z65IXSYyPcSwIPDNA9ioINlak2iyvKX0=;
	b=G6IGjjjciaBJ8EZIqE589nR1oJWCjsrH5OjbZdcoOyywAlATybbHZAGK/8ZL3a49+LbTV8
	hrnGS/R8Mee5h0rNWKEG3ZirFkOI6XFKwycTMIT02glnMCQ2u6/AAfUg3CMKhqvZf0dseQ
	kmXcppS18IDJY/QEZ6wkvj1UVlBAT8g=
X-MC-Unique: KYWTeJ7yOqS9wIYvo3mRKw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=oQj6RKQd+2rt/1QxpyDmQNuMwPgKyZryUbMb37i9HlEBsROS4rdAsSiXDcChFz714jqltd4f79AXtjVADTV/8AeGBAc+kKlFL9graDArayzDRnXVUSbh6Zi0AHzui3FvY6i4rcmqDsXPRMG9bQJNTyG4lrL6tiUSd/Uz7FbveEP/VjO2LaegqkW7xiW8qjegDrtzT2L+M3h7ufZOK7/In3gPvXCK1ykmiJqxxLenDEwUhCJjLv1UvfUul5kIPKx51mfdKfPh53BriQdh0WHzN/g9X0xGNOrBE7zMUXIm6xoomFaBLhDfboqzAuEIOcVkqN60kMZOihpy8HJYnSnHHA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=9xP72K9E84/Z65IXSYyPcSwIPDNA9ioINlak2iyvKX0=;
 b=LEf0rf1kFZ1VpT9H1o7W/QSd4hoESPxSTkktWphvdGe/KD92dR9SeYUcdGMOxogBQXG6JIQgWQdT0blX9AXihFTIG205+I0PGndZHqYmCLI25S8lTMBqxpQell4VojfMsy6WlBI9xC9lU1rjEFryWhM76TEED/o8XNWke46ApNOay4U30DOnioCiysziLs/jnKSWDLoYus6OcKt/4Pwl9luLy8m/juqWRoB/JANNuE9AWZw5DgRrooUu2wEq1T73tTsjLvucS2zU7eV6Xicb6tkmdy+n3vO+gAKxBllI9JqjbAaJIrgwciU2i6IPyFgILOsVq2Ymt1FuFSPXexVD6Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [PATCH v3 11/11] xen/arm: Translate virtual PCI bus topology for
 guests
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
Cc: "julien@xen.org" <julien@xen.org>,
 "sstabellini@kernel.org" <sstabellini@kernel.org>,
 Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Artem Mygaiev <Artem_Mygaiev@epam.com>,
 "roger.pau@citrix.com" <roger.pau@citrix.com>,
 Oleksandr Andrushchenko <andr2000@gmail.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Rahul Singh <rahul.singh@arm.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <20210930075223.860329-1-andr2000@gmail.com>
 <20210930075223.860329-12-andr2000@gmail.com>
 <2bbf1de4-75cf-4f67-a96b-52762332d220@suse.com>
 <68a608f5-4159-5734-4c08-5a70ae9d3ff4@epam.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <062c2801-26be-ef3b-71d1-70c598705b94@suse.com>
Date: Fri, 1 Oct 2021 09:42:35 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <68a608f5-4159-5734-4c08-5a70ae9d3ff4@epam.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P193CA0054.EURP193.PROD.OUTLOOK.COM
 (2603:10a6:209:8e::31) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 1d6b8f60-c4f0-4aa8-c7cb-08d984af0a67
X-MS-TrafficTypeDiagnostic: VI1PR0401MB2336:
X-Microsoft-Antispam-PRVS:
	<VI1PR0401MB23365437AFBD560FD469A24BB3AB9@VI1PR0401MB2336.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8273;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	7esy1Mei2J7/7FcEQfhCn8GwQ7fcflKCzA1Lp126eozPAQyAQdLusDx2uN36IX2F0WWImDjmyPweZJtUdnNnwZegtDDL8ld6HSJhbLFjB977vFpqI5ydS1uj+vksALjxSyvWc+nQQLcdii6H3oSp4XC8HaBAkN9u0wL8LmsYkE6MXcgmYqbA5g/6+6RJWayQ08PAb3Z6/V5xNBGhbveExzNnf4tCQFy8HMoyBGmIUZzfRzMdstG38KuX1j1iZOYRqUB29Qmhv4MsfmpjPy6nbZgsIGMtCqrfqv+gfGU0hNM5S3vZae6+xWb8Y6kTt5pkd/BlKzTejxj1hgJf0xBbkc65vzauIAPW2hh8lveH7RObrhOCFG5rtmUl72nRpNYXANEWuKnI2Rgtbhn086RQGagdpbgdpluh2OK+l0OIATIWe3yfYpLqcIswCwnCjmY5uMfuJZoYYfxLgheodrT8VDssqJQEf1TccPh4p5ff85dNPTlyJkTmNrzDJfSGc3QkagYWvri/nF5yBbQcrYXsa7dvlxfZjeMmkOHBXw6bvVUIXd9WY6uy3c21Ey5ViZIr10DXaTevmvjuMh2ayWKPh07ZWGGYXpax65laMoqXuDLiqCGJ8B8o/pqqtgeIYQ1I1C8tSq33ksn/6lsp2GoXaeOYS7+aLu4igmax5eh6ql69pj4Dfkq65lxsag/dyNw7J1QQ+YV+IzP+ifvNJ0TfHAN2cVxb9JswOweP9EjALvQ=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(316002)(956004)(2906002)(4326008)(2616005)(7416002)(16576012)(83380400001)(36756003)(8676002)(8936002)(53546011)(86362001)(38100700002)(508600001)(5660300002)(6916009)(6486002)(66946007)(31686004)(26005)(186003)(31696002)(66476007)(66556008)(54906003)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?enRweU4yUTQvZ1VsUFhIUVlaMVFqVXgrcGMxa2s0RnEwdDJRN1FMcG9BbHFh?=
 =?utf-8?B?Z0FpcFpGcHlVZEhPdHU4SXRRZUg4YVlOTis4cW5IcmxZaE1seFYxQXRrYVg1?=
 =?utf-8?B?K0hnTEhVQm44S1Fqbmw1WVZSRktKOS96dXo2LzlabTJtaVBtZlFtcG4xcTZ4?=
 =?utf-8?B?dzVabnIwdG9DZ1JwUkRMVzdvT2hKQ0V6aXZtRkYwaFR2ci9ZUkFuYUJYc216?=
 =?utf-8?B?MHM2bk1WT240YXJhbEl0UDVFbWUxelV5ejdIdUFCazNxQ3UvL1VQVzdVUmZs?=
 =?utf-8?B?bDcwSkk0YmpNTEdsWWdPYzZWbnErQW01elI4VUk5NkF3YXNMU3dkaDdTOVdK?=
 =?utf-8?B?TFdCaFEvLy9leEk0Q0x4YjQ1RC9kV3h5ZkZKcHVnMlExdjgrSUs2cnVWUDFJ?=
 =?utf-8?B?ZlFWdEdQMW11dGJMQjRQcTR4NTB0UVNVK2pSQUpBQlMzdFg2cTZWK3VLd1pF?=
 =?utf-8?B?ZXZKbUdhTGliaGI5d0pnOWVyTWdubVBmYUVRMWhRb0RNdVpIRVlYQ2FQMUFy?=
 =?utf-8?B?SUthcnlaNzU4SE1oN29SRXJkaVhrM1Y2dEYzQ3JIbEtBb2ZJcUxhaXNXbkNh?=
 =?utf-8?B?YW1KZnVQakNlTzBUdU1OeGZyZ0dMZXpnVGZ5c0NOV250THovdm1jci9nd2gw?=
 =?utf-8?B?U3V1WEdlOE1OdzJoK0NIbVZvdS9XVGxVcXYva1NVWEI1OW5YTlVsMElqUE5o?=
 =?utf-8?B?NytYTlRxLzRDUEFVeXZKQ3NXU2I3bXZNSTVKemNsZjdqYzRCWjVVQ0U1WENq?=
 =?utf-8?B?R3o5NDY0cUYrakpnU1RXb1ZCd09ZQms4anlGaUJlMUV1N0EzQ2dLWkxGVFhG?=
 =?utf-8?B?OFVOYzZNbEdCSkJMODZxdUZObWprT21wTFh2enpCb29yVndxVzI1NmQ0MUlC?=
 =?utf-8?B?VDFjTHZyQTU2NVc4NTQxYjFsRlFCR3dJYVk3NHlVTWQxcUI3Smdha21LODBP?=
 =?utf-8?B?a1NZTEVUSEtIL3hXbzdVaWNXN2t6MXJSMmpHdU9EN242MzRBUDU1Z3RaMmpB?=
 =?utf-8?B?dFdzOE8vaTNuMUJ6T2pZaTA4U2ZLTGlPMEdoaTlSa2VvbDIyWjZ0R09Gc29w?=
 =?utf-8?B?UkxZa1hYYmlTKzJlV0QyQ1krK0NpTUxFelNmQnNGOU4yUXRZZEd5Y2RNcDRG?=
 =?utf-8?B?NDVRekJWVURhWkVtUXd5VkNEQjNOWTdvWkdWTFlCQ0E5aG1qNUQ5RkdJRHU3?=
 =?utf-8?B?SmNRVXNHNU0wUWEvTlE5RXJibWd0N0l0ODNiSXZJeDdPV2xOR1Z1SVM0M05m?=
 =?utf-8?B?ZkEvUzhVNWQzVzhNaG40V2xWbGhkcGNoNHFXaDJlM3JnQUJzQjYyQmJNVEha?=
 =?utf-8?B?MDhvd3MxWThNV0pJbnZlWUNVcDBHQWlCWnFoVjlzNk5lK1l5NnNnUjRrMkpq?=
 =?utf-8?B?bUovY21DMis3RGFObWVtWDF1TXZNdm01KzQ0d3BsVDAySFNkTDhSSUpoekJn?=
 =?utf-8?B?aE9FcklJM0FueUcwcXlkemtQWjhubmNMVExIZlNvbGxKV2F2MEhhd0dCbWcz?=
 =?utf-8?B?QlNxZXp0Y1BJbHFTYmE2M3lyTU9HeWJVQnNaSlFISjZwMXpQWGhZZWMzNmhM?=
 =?utf-8?B?Vm5nbkZUYzdZNHpQcG9mb2ZRWlAzMnZOejdXYVlIWUtlc3I2dVIrQ3FKOUNr?=
 =?utf-8?B?dW5xSlJaU291endyaWJDWWdFOTlIcE5Zb0FBSnBQY1NYOFNGVWZva2FxVTQr?=
 =?utf-8?B?b0ZIdVRBQ0hWZStLM2oyTDZHYjYyVjhLQ2xhTVIvblFYOXpaNC9YQzdjekhs?=
 =?utf-8?Q?M/B0rppbwkivJcS4DT24mj00GWyWm0XtMjoiupa?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1d6b8f60-c4f0-4aa8-c7cb-08d984af0a67
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Oct 2021 07:42:37.9002
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: EDBS84pjfT8e8SLOQh8ebe80vTAITjy5JWJcGm++MYWT8Uj9Zw8iX0bvgtEybd/ewFeBGnvjqrfEGcm2J8z5Ow==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2336

On 30.09.2021 18:57, Oleksandr Andrushchenko wrote:
> [snip]
> 
>>> +    bool found = false;
>>> +
>>> +    pcidevs_lock();
>>> +    list_for_each_entry ( vdev, &d->vdev_list, list )
>>> +    {
>>> +        if ( vdev->sbdf.sbdf == sbdf->sbdf )
>>> +        {
>>> +            /* Replace virtual SBDF with the physical one. */
>>> +            *sbdf = vdev->pdev->sbdf;
>>> +            found = true;
>>> +            break;
>>> +        }
>>> +    }
>>> +    pcidevs_unlock();
>> As per the comments on the earlier patch, locking as well as placement
>> may need reconsidering.
> I was thinking about the locking happening here.
> So, there are 4 sources where we need to manipulate d->vdev_list:
> 1. XEN_DOMCTL_assign_device
> 2. XEN_DOMCTL_test_assign_device
> 3. XEN_DOMCTL_deassign_device
> 4. MMIO handlers
> 5. Do I miss others?
> 
> The first three already use pcidevs_{lock|unlock} and there it seems
> to be ok as those get called when PCI devices are discovered by Dom0
> and during guest domain creation. So, this is assumed not to happen
> frequently and can be accepted wrt global locking.
> 
> What is more important is the fourth case, where in order to redirect
> configuration space access from virtual SBDF to physical SBDF we need
> to traverse the d->vdev_list each time the guest accesses PCI configuration
> space. This means that with each such access we take a BIG PCI lock...
> 
> That being said, I think that we may want having a dedicated per-domain
> lock for d->vdev_list handling, e.g. d->vdev_lock.
> At the same time we may also consider that even for guests it is acceptable
> to use pcidevs_{lock|unlock} as this will not affect PCI memory space access
> and only has influence during device setup.
> 
> I would love to hear your opinion on this

I've voiced my opinion already: Using the global lock really is an
abuse, which would require good justification. Hence unless there's
anything speaking against a per-domain lock, that's imo the only
suitable route to go. Nesting rules with the global lock may want
explicitly spelling out.

Jan



From xen-devel-bounces@lists.xenproject.org Fri Oct 01 07:51:13 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Oct 2021 07:51:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.200449.354969 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mWDJw-0000Tt-Af; Fri, 01 Oct 2021 07:51:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 200449.354969; Fri, 01 Oct 2021 07:51:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mWDJw-0000Tm-75; Fri, 01 Oct 2021 07:51:04 +0000
Received: by outflank-mailman (input) for mailman id 200449;
 Fri, 01 Oct 2021 07:51:02 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=KCT2=OV=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mWDJu-0000Tg-KF
 for xen-devel@lists.xenproject.org; Fri, 01 Oct 2021 07:51:02 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 5165302e-228c-11ec-bd96-12813bfff9fa;
 Fri, 01 Oct 2021 07:51:00 +0000 (UTC)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2177.outbound.protection.outlook.com [104.47.17.177])
 (Using TLS) by relay.mimecast.com with ESMTP id
 de-mta-30-Ramz9tJON6u9dsal3ZuEYA-2; Fri, 01 Oct 2021 09:50:58 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VE1PR04MB6478.eurprd04.prod.outlook.com (2603:10a6:803:12a::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.18; Fri, 1 Oct
 2021 07:50:55 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4566.014; Fri, 1 Oct 2021
 07:50:55 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 FR0P281CA0053.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:48::17) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4587.11 via Frontend Transport; Fri, 1 Oct 2021 07:50:54 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5165302e-228c-11ec-bd96-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1633074659;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=FS3M77QyqTSgF3aukoaB+MKaXGKK9/uwme7/4adiMq8=;
	b=EwCmcvT0Fii2RbmeIP7IKaT8Z74mvLXWtLzRaTnPY8DFea/nUACOM/wSz/RiQCbp0UsT6U
	ag8rilXumdaff2yyjoymxd/062T1iGF7ySgThBCXSIehxj4iGE7sUBHM+pI0ihi+UxCjU6
	tB8kY/arRaA5WwC8U4GZeedalgyzmjg=
X-MC-Unique: Ramz9tJON6u9dsal3ZuEYA-2
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=cP7m0WWF6up00OpUH/RaMfpwIDB5Y9Iu+sxHjBe9NvakzWEg/Zm5X/r55s38tQQ5EHZeg4hC0yOCoVK979xV9sU4uueHiGFqime8vYSpwT9tdSRxMtswbg5B/soQLdzm/KOrwBxo8AOzJq4wCBGv0qX8XnN+9yxEnKkOqmZej5vBFrGDFT67/PxXCIZW97KqXIB3qErN8lO8I8k0eCci3Fr4QbpfrS/p2bw9FSQnwB9ijjNG99ZO3l6uz2U5C2qtJY+Umr/c1AgKtLol+5vujinWB6Yp7msFIiMJh0L2C9kfbuQ27RKJJWGH8mT+vKPAnSDYRbQNu7zIcSgdk5danA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=FS3M77QyqTSgF3aukoaB+MKaXGKK9/uwme7/4adiMq8=;
 b=l3IagNSjf1b4LewabkJfzyGeYll9rZo2ms2KLpvjTq4cwKegFpw/8C8zsEK9tCyvsbGfdEzdl2BCve6qpZpgDv74ZZ7Re5AvVpNqzCy2aONulZ+i7Tt+GmFVK/poBwNvxTkMDxYROItgss+BM2+LYDSlvjIVH0rJHHlZLxOiR/HCHoJfZz9AxBC5kr8UbVwEuQfJKnIQBko+r8FWOuz9w78GreJiQXjVgd0wRSLsuLABeucKYiTCmsELJQWz2lNaep4ktlAMxg5yr8s0a+aPinJftqaKl9xMVELXMW8QfSYGavIwvBQdBddeNjtQr003o7DFK9LjsksmRWwxk2nHpg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: gmail.com; dkim=none (message not signed)
 header.d=none;gmail.com; dmarc=none action=none header.from=suse.com;
Subject: Re: [PATCH V4 1/3] xen: Introduce "gpaddr_bits" field to
 XEN_SYSCTL_physinfo
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: xen-devel@lists.xenproject.org,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>,
 Anthony PERARD <anthony.perard@citrix.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Juergen Gross <jgross@suse.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Oleksandr Tyshchenko <olekstysh@gmail.com>
References: <1632955927-27911-1-git-send-email-olekstysh@gmail.com>
 <1632955927-27911-2-git-send-email-olekstysh@gmail.com>
 <alpine.DEB.2.21.2109301600060.3209@sstabellini-ThinkPad-T480s>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <05b040b0-a069-47a1-1f5e-85be62fa35f3@suse.com>
Date: Fri, 1 Oct 2021 09:50:52 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <alpine.DEB.2.21.2109301600060.3209@sstabellini-ThinkPad-T480s>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR0P281CA0053.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:48::17) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 9abbd8ee-f8f5-4af0-e3a7-08d984b03311
X-MS-TrafficTypeDiagnostic: VE1PR04MB6478:
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS:
	<VE1PR04MB64789440493F8575F813EFD5B3AB9@VE1PR04MB6478.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:2958;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	HqSwwe9cNKYfT1sv8sXWf1gkb8Nb+qdklg1S1AIhRvbXe9CPeWDB1Gz1UYUc8kmyvbAO24RsMhZ/ZTPtUlj9Wcg/Js1VeX9qz/0j2tBbFuuBGi4LFKYHGYnZhPVqRcG7mFIiGBulaT+Ip6fNlk6SztMwWmErA3XS5HVBaR1MyFMY1zfR6BrWdxAazy49kl+zIE0k0JgmzZR7rBeXLEcxxGblr10HVXBjeX8Ttv26X+gvSTvQg9mbapnZ684VwCB9wQG8rHFKKI4PaUN3NmIUZRnqNWv7rf8uI6isJGswW8Qx/L4jJaqkiyYRgGBu7WN8+fhlfQ+7jGGG/txn2pCxMQRnlSqti38vh8GXJ1ZTZ4bHrYxKcYyLYeFd3QIpri8awpdWSkQ7gjBWblpzGvrxnJjIxDL+3td20tiGwsh1LoGJvF2QGyvTpRPz77BE7FA8osdJAoXQlg0cG9Dtwa8/jPFSMmrd4Moj5l3QeuVke5A+4pkVHCO4vTG/tnwEXHTKFxvaMOXQkOGTq6ndmotTFv2DBI46OlXlZoPniwHzfJ4+o9CuCN5ka9hpu7PhYaySMJvA/zZIrSHLtYcepSdCvcNSQlsGjaKBnHJmt23j5ey3dEskG4HJaY2C2ECoMAUhx5mmJxjutwufUP2+tdhvAOiW2qyzf61XDi1sK+oIdgybZimBX6SvNlDQnVBHPKfc3Emhvw0pAEnBxlF+wH6vRX3DI5DB9MUTBkdwNyUJSE86oM+gg2OOt28FB19fsLzpFdeyt7hVa2TQqYOgt3U3SpSCE1lWIvxNuNXxngjbp9WkYofWEsmAiARE0o/IX2Cp0Y1274ZiNPcoMq+kpcwckg==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(31686004)(8676002)(36756003)(83380400001)(5660300002)(66476007)(66556008)(38100700002)(8936002)(4326008)(6486002)(186003)(26005)(53546011)(316002)(7416002)(2906002)(66946007)(6916009)(16576012)(31696002)(2616005)(86362001)(956004)(54906003)(508600001)(966005)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?eFIvS09tZlZiNW1CeDlBZlJDMDQzRmg1T0RZY3lsajVyVmdKdmRiVlA5RGVV?=
 =?utf-8?B?MFVKR3dNR1N3RW1ocWJqV0tDZGJ0bmltN0FzM0dvdTBjYktxMExqRm5iTy8x?=
 =?utf-8?B?WGVPVWp4RUNQbDVlMUdQRkJ4dmJnUzdZWjhrYXhYbjQ5ODdyV1dDbFo4Y3do?=
 =?utf-8?B?NXJTNk9oc1NiQWZLcHFMQTcrTGlOYWppVm9zWmFhN2dvVUpyU0FzTVJ4enph?=
 =?utf-8?B?Z0xwRDFKbmxYU05pRjY4S0VKZ0ZvODFVOE5nN21FNGxtUzd4QWFQdkJOWU9o?=
 =?utf-8?B?d3NvYU5waUQzcm5KU1ViV1FhSmdpUHZCSWtnTmhINkRLbW83S01keWVoaGVF?=
 =?utf-8?B?V1FzMlljdTNsVjlQSzdkWE9vc3RGQUJKeTFuQjF0Sjd4aTZTTDN6L2ZVQURQ?=
 =?utf-8?B?NVZKN0FpQVlmTTR3Q1VKS1NLRTR1NlJSQ1lrYXJTQWxCVldDbTRUQnJKRSto?=
 =?utf-8?B?NWR2bHo0QWZzODBmbnpCcFE2b0pZWXJYTGNMYStwMHFHNThhU3MyWDVZWjhp?=
 =?utf-8?B?WmJVNjdaN2ZVcUR1amVwYzBjQUhDTFVnU1FUQ1dIdnpoakZ2ZlZSQ3RjK2Ra?=
 =?utf-8?B?b0tvcXc1YXRHaE4rNzBUQjB6Z0Qxb1BZM2JlYVJuRG84SXBTTHl5RGV1OUdt?=
 =?utf-8?B?WWJ4N0Zza2k4RVRTTDJ3TkdFVHhvcS9IaFJpaXN0aGpGZy9IRG41eGZSN1JE?=
 =?utf-8?B?VE5EanFRQXNDdkZ6SDhObWVQVVN3OEQ4dE03V0N6UGt4Y2U0azBTWU16Rkdl?=
 =?utf-8?B?Y1V2N3ZWYUZ5R056WGluVnI4K1E3andCU1FiMVg0VzBOVzczQjI1dGZIQTR6?=
 =?utf-8?B?QjVNRkQxSWZCWEtzOUE1NVhYS2ZFTmp6RkJ2TEFxWlJvVHpyaTM4TjRlUE5w?=
 =?utf-8?B?NWQxZHgxQmlsTTZ4TGFiZDRPUmcwNnBjYUlMTXAyWlluUHFEdCtCWEtJU3BQ?=
 =?utf-8?B?eElnUmplMlhZRXJsOC9ocnFoakVyRTU0blo0Z09wQW9Kb282NDNiNWh0cGRK?=
 =?utf-8?B?a21wMUlGQXY0clBFb2thSXdpRmRSNzkzcEZXYm9VaHhpT3RVdEU0YnVSSFNV?=
 =?utf-8?B?Z3Bqd2xNVUwwNGo4N2xRbm9yTHN3RnQzZUhBSVkwNVlLem05bnRqLzN3ei9H?=
 =?utf-8?B?U0xJcWI2UkRRWFlmYy8yRzFXSjJBTDNpaG5Kc000Nk82MzJVMm5IQkpSbmhj?=
 =?utf-8?B?RG0wc0dnVGNrUTVYRGlTZVhER0ZDOXNvdmFtbTczaEJBZEZ0MDhubS9YTm5z?=
 =?utf-8?B?ZXRFYXZQclg5YWFOUWpBczE1OW1ScmlyTFQ1M1l6ZTZSalBNbjJIZFBDS0ky?=
 =?utf-8?B?M3VaOVAyVEoxQng1NnhtR3hRb29IQUcwN2tNMk93YlZTN2VhVURpMnVlUklN?=
 =?utf-8?B?RldGYUxBenliL0lJZXNFbE5Ecnl4bG55OGh4QzVtSmJyZXFCdUg5Tk9wbjJm?=
 =?utf-8?B?YkUxUE9XSzVEcnV1SCt0b3M2VmZkcnZzaUcvU2o5a3hFWHhCNjdJdEprc1lI?=
 =?utf-8?B?TlhkVlRvVDBneTVxOGhhZFlTcUJVcWRJbXNueS9NaitxMVRFUzBvakluL3lM?=
 =?utf-8?B?N1BlTi9PUllSRkphZWx1SUNjeDVqWG9CaDg1cjJ2VnhCZ2JBaFdIRFZEUEEx?=
 =?utf-8?B?Mk1KL0gzVWZyaFl1cnhoL1hEWTFpei95VjlRdlBJOG9uQS9CWHA1UmVpN0oz?=
 =?utf-8?B?azRTTUUydnVEelhQM1A1cFNxQ2xFaGNGeHVqcVM5aTFqMkNxbktpUmpsYVNa?=
 =?utf-8?Q?oloLMqGzcxFG6F44mWalwrEgmLTRC+Qn4HAc47R?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9abbd8ee-f8f5-4af0-e3a7-08d984b03311
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Oct 2021 07:50:55.6286
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: VXWL7q42yJEjzn7SlOXjGKWgTIRL8nlGbW5ADjk/EF83XtPHlOe0OBKbANx16vOuvZp4s1hjma1424Hq42pXPg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6478

On 01.10.2021 01:00, Stefano Stabellini wrote:
> On Thu, 30 Sep 2021, Oleksandr Tyshchenko wrote:
>> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>>
>> We need to pass info about maximum supported guest address
>> space size to the toolstack on Arm in order to properly
>> calculate the base and size of the extended region (safe range)
>> for the guest. The extended region is unused address space which
>> could be safely used by domain for foreign/grant mappings on Arm.
>> The extended region itself will be handled by the subsequents
>> patch.
>>
>> Use p2m_ipa_bits variable on Arm, the x86 equivalent is
>> hap_paddr_bits.
>>
>> As we change the size of structure bump the interface version.
>>
>> Suggested-by: Julien Grall <jgrall@amazon.com>
>> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>> Reviewed-by: Michal Orzel <michal.orzel@arm.com>
> 
> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>

I have to admit that I'm a little puzzled to see these R-b-s when ...

>> Please note, that review comments for the RFC version [1] haven't been addressed yet.
>> It is not forgotten, some clarification is needed. It will be addressed for the next version.
>>
>> [1] https://lore.kernel.org/xen-devel/973f5344-aa10-3ad6-ff02-ad5f358ad279@citrix.com/

... Oleksandr makes clear this patch isn't really ready yet. The tags
could misguide a committer into putting in this series despite the
open issue(s).

Jan



From xen-devel-bounces@lists.xenproject.org Fri Oct 01 07:57:33 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Oct 2021 07:57:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.200462.354981 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mWDQ8-0001M5-45; Fri, 01 Oct 2021 07:57:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 200462.354981; Fri, 01 Oct 2021 07:57:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mWDQ8-0001Ly-14; Fri, 01 Oct 2021 07:57:28 +0000
Received: by outflank-mailman (input) for mailman id 200462;
 Fri, 01 Oct 2021 07:57:26 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=22t+=OV=epam.com=prvs=09080f3fa0=oleksandr_andrushchenko@srs-us1.protection.inumbo.net>)
 id 1mWDQ6-0001Ls-Oc
 for xen-devel@lists.xenproject.org; Fri, 01 Oct 2021 07:57:26 +0000
Received: from mx0b-0039f301.pphosted.com (unknown [148.163.137.242])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 374f499c-228d-11ec-bd96-12813bfff9fa;
 Fri, 01 Oct 2021 07:57:25 +0000 (UTC)
Received: from pps.filterd (m0174681.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 1917YHZJ013384; 
 Fri, 1 Oct 2021 07:57:23 GMT
Received: from eur05-vi1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2174.outbound.protection.outlook.com [104.47.17.174])
 by mx0b-0039f301.pphosted.com with ESMTP id 3bdx2702ew-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Fri, 01 Oct 2021 07:57:23 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by AM9PR03MB6963.eurprd03.prod.outlook.com (2603:10a6:20b:2d5::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.15; Fri, 1 Oct
 2021 07:57:18 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::e966:6290:5736:b7bd]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::e966:6290:5736:b7bd%7]) with mapi id 15.20.4566.015; Fri, 1 Oct 2021
 07:57:18 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 374f499c-228d-11ec-bd96-12813bfff9fa
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Vht6sfeNUOEv61EmalB08Bfav3VJZLlJBv1G3+CMv2rzWpKXk7gFN7tg+WqEhQziC1p5Cn9YabI4WbHKVNRJYVYTnGx5XcBmZo8NQaKBzpUkHT1YTGPIMykWgxEKzHzJBPAIY/JVxwxHBZ1v5C9ajUInpuM888t5ngvAz8PHh6LVhkROZcT8irDFHSKWbYMWExZr8cSaPq1k660DQ0kk4YaDH3O+/zdECxHdz1ycSQ+w95hZ7sQQujdaLzxlGR8ASNuQecOBkjTbkcpaIPf2/ANypaF84I31FDeUjC5Oud9eVzWGVBfvlYfqS6fPQkYalFDYgBVV/Ez8yf45q1vIig==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=oul6kvddgGmqeZvIIOQ6ekwdrkDx2Bt8XLV61qriklE=;
 b=l/1j3ILZF2o6BgTJDPdt4E4KbRNMri+aCogkkky+wlnVZ9bOvueePMQ8NUm2Fl5AzT3Fgm/4l86A+1g/v30zZRWBYMYKeVTdP2dX2XWRGvmeaDqiVLBkc933EuU5voMD/PbM/lMQiGDi0m0BkTajyj9GFRjRfSn9odBNB+yiak9SH07dkH++qWaOYrYSe+tklPCfktM+Mk0V3fB+jefrD2DnA3hE7/wotz7kByl5CqPR7ukuyXFp93jKWjqVnKGl4fwq4x9x9HmRZVrzsMi3Y7AGXyP8nxz6Goo5FgpVaBtcFqPOPiAJ3Ef7zh/iIR0NK4jRjEX2fSj8Bf+0/tvSfg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=oul6kvddgGmqeZvIIOQ6ekwdrkDx2Bt8XLV61qriklE=;
 b=066QraXEP8R7Syh/bvX25W2QtOl6oS2yf85ZezZwmaKTtYiX91n2IqbGF16ee+Zh6kRZJFub8Hi/qp30yJ+gJdgDzKkmCtE7TO+cYBQhsc3qCpn0W2QnoHGUzsuVh1g8R9GvJBW//tyI+kRAtCG+QHjVCyFuUuR3L8vP4pAj6+CryVChxSFjj3UWt3lYgsK+eDgnwBgOVuTYibDd88VNYsiGtVt0rhIl8JtD2+tHLUWF9GKF1D6cb0RD+Kk1m2UIaESSHb4rRz2r1/nbEjiwJWd7Gz6uAc64uBKsANtWScksNLYx3mDgGQ5/4vpkqs/2sMYmRyp7lsjMYUNZtzxM/A==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org"
	<sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "roger.pau@citrix.com" <roger.pau@citrix.com>,
        Bertrand Marquis
	<bertrand.marquis@arm.com>,
        Rahul Singh <rahul.singh@arm.com>,
        "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        Oleksandr
 Andrushchenko <Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH v3 11/11] xen/arm: Translate virtual PCI bus topology for
 guests
Thread-Topic: [PATCH v3 11/11] xen/arm: Translate virtual PCI bus topology for
 guests
Thread-Index: AQHXtdAlBwDHpaYUBUq6q0PlsxoTp6u8Ra2AgACHPgCAAPdBgIAABBwA
Date: Fri, 1 Oct 2021 07:57:18 +0000
Message-ID: <5a8d1ad1-c10d-16ea-4ab9-5c0e1600b3b2@epam.com>
References: <20210930075223.860329-1-andr2000@gmail.com>
 <20210930075223.860329-12-andr2000@gmail.com>
 <2bbf1de4-75cf-4f67-a96b-52762332d220@suse.com>
 <68a608f5-4159-5734-4c08-5a70ae9d3ff4@epam.com>
 <062c2801-26be-ef3b-71d1-70c598705b94@suse.com>
In-Reply-To: <062c2801-26be-ef3b-71d1-70c598705b94@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
authentication-results: suse.com; dkim=none (message not signed)
 header.d=none;suse.com; dmarc=none action=none header.from=epam.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 2ed33cd5-43fd-471d-9edc-08d984b1178c
x-ms-traffictypediagnostic: AM9PR03MB6963:
x-ms-exchange-transport-forked: True
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <AM9PR03MB6963084B727DAD7108EC2644E7AB9@AM9PR03MB6963.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:9508;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 tmayT1ceZC4sqhYrWFyKggUeoCkjD9meC8nHRo0PbG5KldiHvPjn6stmbv6C/ekvXWUrDMb9U1Szt8Z2nOIzHNfap9TTqEP7O0zoRKn1ZdB1O4+x7EflgwaTHrjPVejfmx+5Tc7LB//HoKBV3+MuyOVN43f5G5WRVYEbfPrIJS1wXLKenZ3E/Ctj35d7o216Rjp5RanqdlcZkN06/JGBid/VbipGeY36Z28x0znltNY3VAKEdpFGFKrjEbqq9hNsvK6R2l0oAjZlZIgOu+1ky1OKXGGfoktM0znkFtlB0JEfCGGzkQrefvlOZvBJILmUoHTxrh4W068AXwu2tbuVii5Nr1CcLfySxNDPOvZBfLOS/1CenSlWzZv617+4xS5FgwxWQMPPg61uz7w8hlVp1qkG28voLdrCU8NscZN/0eji4dZkIkdVmXt0H5itfFAQ8XITyt5sNk8abgdA7FyAZC0IUD86QW1MlKbYjiBQTzFfP0y+0XHzdD9MKGcimHo+oQzcQEtFWp0cgSxN0JaIdtQYYO80Gjt8Qz67GHmwISCyza5rbQ75Q7CJmbxaK8E1ENJUYIKNUClOkXu9jLcVadD+26uF5i8ZR6KcnYP9MaWmfDjX5abkAgN1CzXtXmIrKm149XNsKurhjGPV5B3AMaXCFFHjzGKeN3n4CJOCSYrQ225tjdf2I2mZt0B1sbgmLRitybUD91ouBSWNlrK/ORH1p1WPL4Cz7IecnNYIU4S7nN3jFm5ty04WbuyPJck/
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(8936002)(54906003)(5660300002)(31696002)(8676002)(6512007)(83380400001)(26005)(36756003)(53546011)(6506007)(186003)(122000001)(38100700002)(2616005)(71200400001)(4326008)(64756008)(2906002)(107886003)(31686004)(66946007)(66476007)(91956017)(76116006)(66446008)(38070700005)(66556008)(6916009)(508600001)(86362001)(6486002)(316002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?UFZWeHRmdWt0QzNaakhaNktzUzIzd2RRRUFRV29rbGhDY1NsQ3NXU0swSGxB?=
 =?utf-8?B?dE9pYXdHbzhzTlJjdTYzMU9jdzJRTHZhZ1dxTHMzVTh5TG9qWVJZWnNvOWtW?=
 =?utf-8?B?MWZKR3dMWGNYeUNVMDBiNElHODNsc2R2NHpCdGVPNnpudlMweENxMWhyY0FV?=
 =?utf-8?B?aFVvbjhqM1NibGkyR0hFNENUVm1sRHdsMlVPRjBNeWdrRnRTMVY4NEp1aWFx?=
 =?utf-8?B?WlB1cXZKakJuV01aMkpLVVB1RGVnN3hjcVFuZmhCYWQ0MGs5TTdOZjYwTTN1?=
 =?utf-8?B?TUpVRmNXdGJIUjY1Z2NCb0tSdVZ4Q3RTcldsYnpvT1h0WHIyU3gwcVZsS1Nh?=
 =?utf-8?B?SllkRFNqZzZiQVJVQlVCditLSEFDSFVoQklDcVJ2VmJiN01VU1JpS0pLdDd2?=
 =?utf-8?B?ZjZrU0hhcUhRd3V4OGRyT3A5TFNDcHU0czU2RFNta3U3dGlGRVp4My9jdklF?=
 =?utf-8?B?ZTdXY3IxQ1hXdEZ3Wm5abmFaU3FCTGtVQ2sxanBrclp6M2JUc1Z2c2lJMVZW?=
 =?utf-8?B?UkQ5b0VHMS9UM1N1c2VTVE83QlYzdnBkTHZSVXFoakxaNHN6TDdJS3ByVXdF?=
 =?utf-8?B?NTVUNXN1RUJrZjBsN2Z1TGx2bmczd2dYbFhiMjdEZm9RTE9EeVBhVG1YeXJF?=
 =?utf-8?B?ZWYxUzN3T1d5WmhiQXIzWW5CT2wwQ3JtZGxoa3NjMHJiUkFrOXl6ZHl4cUo4?=
 =?utf-8?B?ZmVNRTJ0SkpIamFrRU5Ybjk5c2x2SE0vdi9EaVpEZzVHSnRRb0k2MG1lVnBT?=
 =?utf-8?B?VHJGQzBiL2RXS1NOMEMvVzVyRDJDaFVXKzJ5NzVtNE5hYXhKWi95RWNzZFUv?=
 =?utf-8?B?aWJLekM1MmhqeStja2RXZEUwYjlBdTB3cWc4elZEeGsxVE5mNWhYS1BHdTNn?=
 =?utf-8?B?QXp4eDh3a2o1bVBHTndnVmo5MEpSQjRqN2F6SitGUDRIWnpmTmsvbWRmdGZE?=
 =?utf-8?B?WGVzOWlFSUZ3YUN4T1JTeW9uOS96eitybDFkbzVRdktWVm51RE0zOHBFQkNn?=
 =?utf-8?B?VzdMRmowRks1OWhNczlzY1NUQWZ3bS9RSmxsdTIzRXNCeGF2ZVRkajFWa2ls?=
 =?utf-8?B?QkthdnRodExLczNzVDF3eDZwU2tqTm13K2c5OC9IT1pQS0hrM05EVElXZW0v?=
 =?utf-8?B?bUlobE1PQlBOSVZyV0wvN0ZWalJmOWF2TUlRdlFBYUlYblNVakVSbHEwUVE0?=
 =?utf-8?B?UHM0RWYrWitpMGZGa2lweEpQTWFnWnRySkowNFFuK3ZpS0JPaHhoYUxwcUhN?=
 =?utf-8?B?WG1LTCtoWC90K3hFbmZPR1d1K0pkdkt5R0pUbjlHV3JqdDBMZmtaL2tveVhQ?=
 =?utf-8?B?RnU0QnhVdmVuN3NQSmpVQjVTNnhPSVF5QTMwbVU4M1J5UTQzbjM2UGxFamd3?=
 =?utf-8?B?ZkljY2FpUGpIUDlyc2tTUUVzSzZoeTZSeWhFQlNmMW95TmxOUk1GM05YOUtL?=
 =?utf-8?B?OWt2Q2h3c1lIWUF6elgva2dzK2VrK2tKaDd2WlBtbmRpcmx2KzRDVitDbFJT?=
 =?utf-8?B?SElGVDFRcXNHYW5CdXg1ZXExRk9PbTd6R0d5R2c3VXJwbzZvdjA4Z2ltbDM4?=
 =?utf-8?B?dlZSeG1XUTJiQUpzcUF5aC91UkZxVWxJWXE5c1NEdUtNOW9zMkJSR0dzRHlU?=
 =?utf-8?B?TGxMRmZTbVlYaTVyMzJaVjdkQWJOT0RobVV4b2hlbzdFSlZXUzY1MldFTUNP?=
 =?utf-8?B?YU5RM0VmaVJqbnVQcHFGc2dtVnNPVGRnY1VjaStoTFJrblp2NnpDbEt5Ynpn?=
 =?utf-8?Q?8TY5nEZBIyfKntzZ4Vdfaew2HWxIyFCvwCU9fb1?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <FB380916FDA97549AA06335376921C02@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2ed33cd5-43fd-471d-9edc-08d984b1178c
X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Oct 2021 07:57:18.7172
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: SPl3COCLCqJL3NugTzwqCcniVMNu5HY4p2EqsAZjK8WnAM/H+WjRssI5QtwFYeWjzQLSDjCE/UUCEvbrTDIUlb4XQ1Bp58cwqNfq/xoPqJepzKDntQ8wZ3O/bEeAEJlL
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR03MB6963
X-Proofpoint-GUID: GQzY6pUBPlENbikOFZpMDjpZ5kmS4dOZ
X-Proofpoint-ORIG-GUID: GQzY6pUBPlENbikOFZpMDjpZ5kmS4dOZ
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.391,FMLib:17.0.607.475
 definitions=2021-09-30_07,2021-09-30_01,2020-04-07_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 mlxscore=0
 impostorscore=0 phishscore=0 lowpriorityscore=0 clxscore=1015 adultscore=0
 mlxlogscore=999 suspectscore=0 priorityscore=1501 bulkscore=0 spamscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109230001
 definitions=main-2110010054

DQoNCk9uIDAxLjEwLjIxIDEwOjQyLCBKYW4gQmV1bGljaCB3cm90ZToNCj4gT24gMzAuMDkuMjAy
MSAxODo1NywgT2xla3NhbmRyIEFuZHJ1c2hjaGVua28gd3JvdGU6DQo+PiBbc25pcF0NCj4+DQo+
Pj4+ICsgICAgYm9vbCBmb3VuZCA9IGZhbHNlOw0KPj4+PiArDQo+Pj4+ICsgICAgcGNpZGV2c19s
b2NrKCk7DQo+Pj4+ICsgICAgbGlzdF9mb3JfZWFjaF9lbnRyeSAoIHZkZXYsICZkLT52ZGV2X2xp
c3QsIGxpc3QgKQ0KPj4+PiArICAgIHsNCj4+Pj4gKyAgICAgICAgaWYgKCB2ZGV2LT5zYmRmLnNi
ZGYgPT0gc2JkZi0+c2JkZiApDQo+Pj4+ICsgICAgICAgIHsNCj4+Pj4gKyAgICAgICAgICAgIC8q
IFJlcGxhY2UgdmlydHVhbCBTQkRGIHdpdGggdGhlIHBoeXNpY2FsIG9uZS4gKi8NCj4+Pj4gKyAg
ICAgICAgICAgICpzYmRmID0gdmRldi0+cGRldi0+c2JkZjsNCj4+Pj4gKyAgICAgICAgICAgIGZv
dW5kID0gdHJ1ZTsNCj4+Pj4gKyAgICAgICAgICAgIGJyZWFrOw0KPj4+PiArICAgICAgICB9DQo+
Pj4+ICsgICAgfQ0KPj4+PiArICAgIHBjaWRldnNfdW5sb2NrKCk7DQo+Pj4gQXMgcGVyIHRoZSBj
b21tZW50cyBvbiB0aGUgZWFybGllciBwYXRjaCwgbG9ja2luZyBhcyB3ZWxsIGFzIHBsYWNlbWVu
dA0KPj4+IG1heSBuZWVkIHJlY29uc2lkZXJpbmcuDQo+PiBJIHdhcyB0aGlua2luZyBhYm91dCB0
aGUgbG9ja2luZyBoYXBwZW5pbmcgaGVyZS4NCj4+IFNvLCB0aGVyZSBhcmUgNCBzb3VyY2VzIHdo
ZXJlIHdlIG5lZWQgdG8gbWFuaXB1bGF0ZSBkLT52ZGV2X2xpc3Q6DQo+PiAxLiBYRU5fRE9NQ1RM
X2Fzc2lnbl9kZXZpY2UNCj4+IDIuIFhFTl9ET01DVExfdGVzdF9hc3NpZ25fZGV2aWNlDQo+PiAz
LiBYRU5fRE9NQ1RMX2RlYXNzaWduX2RldmljZQ0KPj4gNC4gTU1JTyBoYW5kbGVycw0KPj4gNS4g
RG8gSSBtaXNzIG90aGVycz8NCj4+DQo+PiBUaGUgZmlyc3QgdGhyZWUgYWxyZWFkeSB1c2UgcGNp
ZGV2c197bG9ja3x1bmxvY2t9IGFuZCB0aGVyZSBpdCBzZWVtcw0KPj4gdG8gYmUgb2sgYXMgdGhv
c2UgZ2V0IGNhbGxlZCB3aGVuIFBDSSBkZXZpY2VzIGFyZSBkaXNjb3ZlcmVkIGJ5IERvbTANCj4+
IGFuZCBkdXJpbmcgZ3Vlc3QgZG9tYWluIGNyZWF0aW9uLiBTbywgdGhpcyBpcyBhc3N1bWVkIG5v
dCB0byBoYXBwZW4NCj4+IGZyZXF1ZW50bHkgYW5kIGNhbiBiZSBhY2NlcHRlZCB3cnQgZ2xvYmFs
IGxvY2tpbmcuDQo+Pg0KPj4gV2hhdCBpcyBtb3JlIGltcG9ydGFudCBpcyB0aGUgZm91cnRoIGNh
c2UsIHdoZXJlIGluIG9yZGVyIHRvIHJlZGlyZWN0DQo+PiBjb25maWd1cmF0aW9uIHNwYWNlIGFj
Y2VzcyBmcm9tIHZpcnR1YWwgU0JERiB0byBwaHlzaWNhbCBTQkRGIHdlIG5lZWQNCj4+IHRvIHRy
YXZlcnNlIHRoZSBkLT52ZGV2X2xpc3QgZWFjaCB0aW1lIHRoZSBndWVzdCBhY2Nlc3NlcyBQQ0kg
Y29uZmlndXJhdGlvbg0KPj4gc3BhY2UuIFRoaXMgbWVhbnMgdGhhdCB3aXRoIGVhY2ggc3VjaCBh
Y2Nlc3Mgd2UgdGFrZSBhIEJJRyBQQ0kgbG9jay4uLg0KPj4NCj4+IFRoYXQgYmVpbmcgc2FpZCwg
SSB0aGluayB0aGF0IHdlIG1heSB3YW50IGhhdmluZyBhIGRlZGljYXRlZCBwZXItZG9tYWluDQo+
PiBsb2NrIGZvciBkLT52ZGV2X2xpc3QgaGFuZGxpbmcsIGUuZy4gZC0+dmRldl9sb2NrLg0KPj4g
QXQgdGhlIHNhbWUgdGltZSB3ZSBtYXkgYWxzbyBjb25zaWRlciB0aGF0IGV2ZW4gZm9yIGd1ZXN0
cyBpdCBpcyBhY2NlcHRhYmxlDQo+PiB0byB1c2UgcGNpZGV2c197bG9ja3x1bmxvY2t9IGFzIHRo
aXMgd2lsbCBub3QgYWZmZWN0IFBDSSBtZW1vcnkgc3BhY2UgYWNjZXNzDQo+PiBhbmQgb25seSBo
YXMgaW5mbHVlbmNlIGR1cmluZyBkZXZpY2Ugc2V0dXAuDQo+Pg0KPj4gSSB3b3VsZCBsb3ZlIHRv
IGhlYXIgeW91ciBvcGluaW9uIG9uIHRoaXMNCj4gSSd2ZSB2b2ljZWQgbXkgb3BpbmlvbiBhbHJl
YWR5OiBVc2luZyB0aGUgZ2xvYmFsIGxvY2sgcmVhbGx5IGlzIGFuDQo+IGFidXNlLCB3aGljaCB3
b3VsZCByZXF1aXJlIGdvb2QganVzdGlmaWNhdGlvbi4gSGVuY2UgdW5sZXNzIHRoZXJlJ3MNCj4g
YW55dGhpbmcgc3BlYWtpbmcgYWdhaW5zdCBhIHBlci1kb21haW4gbG9jaywgdGhhdCdzIGltbyB0
aGUgb25seQ0KPiBzdWl0YWJsZSByb3V0ZSB0byBnby4gTmVzdGluZyBydWxlcyB3aXRoIHRoZSBn
bG9iYWwgbG9jayBtYXkgd2FudA0KPiBleHBsaWNpdGx5IHNwZWxsaW5nIG91dC4NCkkgZG8gdW5k
ZXJzdGFuZCB5b3VyIGNvbmNlcm4gaGVyZSBhbmQgYWxzbyBzdXBwb3J0IHRoZSBpZGVhIHRoYXQN
CnRoZSBsZXNzIHdlIHdhaXQgZm9yIGxvY2tzIHRoZSBiZXR0ZXIuIE5ldmVydGhlbGVzcywgZXZl
biBpZiBJIGludHJvZHVjZQ0KZC0+dmRldl9sb2NrLCB3aGljaCB3aWxsIG9idmlvdXNseSBoZWxw
IE1NSU8gdHJhcHMsIHRoZSByZXN0IHdpbGwgcmVtYWluDQp1bmRlciBwY2lkZXZzX3tsb2NrfHVu
bG9ja30sIGUuZy4gWEVOX0RPTUNUTF9hc3NpZ25fZGV2aWNlLA0KWEVOX0RPTUNUTF90ZXN0X2Fz
c2lnbl9kZXZpY2UgYW5kIFhFTl9ET01DVExfZGVhc3NpZ25fZGV2aWNlDQphbmQgdGhlIHVuZGVy
bHlpbmcgY29kZSBsaWtlIHZwY2lfe2Fzc2lnbnxkZWFzc2lnbn1fZGV2aWNlIGluIG15IGNhc2UN
Cg0KQW55d2F5cywgSSdsbCBpbXBsZW1lbnQgYSBwZXItZG9tYWluIGQtPnZkZXZfbG9jaw0KPg0K
PiBKYW4NCj4NClRoYW5rIHlvdSwNCk9sZWtzYW5kcg==


From xen-devel-bounces@lists.xenproject.org Fri Oct 01 08:12:58 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Oct 2021 08:12:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.200474.354992 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mWDea-0004GO-JS; Fri, 01 Oct 2021 08:12:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 200474.354992; Fri, 01 Oct 2021 08:12:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mWDea-0004GH-Fv; Fri, 01 Oct 2021 08:12:24 +0000
Received: by outflank-mailman (input) for mailman id 200474;
 Fri, 01 Oct 2021 08:12:23 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=KCT2=OV=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mWDeZ-0004GB-SI
 for xen-devel@lists.xenproject.org; Fri, 01 Oct 2021 08:12:23 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 4861ad23-6d47-41d9-903f-9d326632f5eb;
 Fri, 01 Oct 2021 08:12:22 +0000 (UTC)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2110.outbound.protection.outlook.com [104.47.17.110])
 (Using TLS) by relay.mimecast.com with ESMTP id
 de-mta-9-dWZp93euOMCJ2u3leiZl3w-1; Fri, 01 Oct 2021 10:12:20 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VE1PR04MB7360.eurprd04.prod.outlook.com (2603:10a6:800:1a3::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.13; Fri, 1 Oct
 2021 08:12:17 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4566.014; Fri, 1 Oct 2021
 08:12:17 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6PR0502CA0072.eurprd05.prod.outlook.com (2603:10a6:20b:56::49) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.14 via Frontend
 Transport; Fri, 1 Oct 2021 08:12:16 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4861ad23-6d47-41d9-903f-9d326632f5eb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1633075941;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=hjTFJmy1tiJaHbXpmCxP7LXYNpizK2SLCaAHIzeMneY=;
	b=YfS+jEMZPmdQH8MpO/LfEHgkTkD1zqoBHOIfpb1ZzfmdUs9meT2a6awdATNbVlIJt/HlMm
	YYHWZfikdRSF7o8L2xXHjYuCLmFCGOyWfKDjK0dySHGUIJEFdwJ+q9nN5kIRT8aRH8aduY
	zXQnnZajQIDqnNT452H19emuGR7hyqQ=
X-MC-Unique: dWZp93euOMCJ2u3leiZl3w-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=aqexgPUOadpc4sGJZEvIRdTaZC3rQiN+/COxMEclxLFgK6LwWawWmNCZcvNpVeOHgNyi0Sl7NKSpf4G26kcKM/JVM4CealAWGKV/KAdXsMdbbR9lsEjNTQEZgXP+m9MurCSKBuI7PLGERaeg4fAdS9r6+hzjUOD6p3evR8x9gjNpLoVnuPqyZXwngPny673qvSIRpEgm4M8UA+xU2ZmfZ/yJ0v0Qa3ie3PVa8z0n2UwEFm+ghh1EOZwtDiflmKt0/VoNY1WZUndWpi6XitlLpd1OvArIZRURMUypm9pIgAU6g1zjLd18Xs4Zf7/jr6uFqD+S9r0F6VPE8bj52R93cA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=hjTFJmy1tiJaHbXpmCxP7LXYNpizK2SLCaAHIzeMneY=;
 b=bkovvuayGma+YY2AijwnnqSylmL2rc1yQ+snai0FMUXABTDOeIlh1Jx8AbAQp/m4Q+dDYuDB+1H/UUrhhwve2OW2o+JwhheorAImQyWyEJ1fqi9e8T9SFqiTP9gI9UIIj+JoL4MPfmwSSQZ08gEmSqQYr/xyheYrQIcWZCiPe+sZpub4KAqiPvqOUY2zU++uSNOX585wI/f/9T5o0yj4Uw1Cy2rDtKEYLjeoIhzUcYqIOmILs6xw01yNENBD4T3EqSJr6INShFt3xycX7x6DZCiyz+JxeoNQvUVED3JPQq0bzy6F0y4l0B6512tCXSnmDnWBDHEhZkiNj6s2B8QMNw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [PATCH v3 11/11] xen/arm: Translate virtual PCI bus topology for
 guests
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
Cc: "julien@xen.org" <julien@xen.org>,
 "sstabellini@kernel.org" <sstabellini@kernel.org>,
 Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Artem Mygaiev <Artem_Mygaiev@epam.com>,
 "roger.pau@citrix.com" <roger.pau@citrix.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Rahul Singh <rahul.singh@arm.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <20210930075223.860329-1-andr2000@gmail.com>
 <20210930075223.860329-12-andr2000@gmail.com>
 <2bbf1de4-75cf-4f67-a96b-52762332d220@suse.com>
 <68a608f5-4159-5734-4c08-5a70ae9d3ff4@epam.com>
 <062c2801-26be-ef3b-71d1-70c598705b94@suse.com>
 <5a8d1ad1-c10d-16ea-4ab9-5c0e1600b3b2@epam.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <707ebe0d-24c0-80cd-672e-0996eeb27583@suse.com>
Date: Fri, 1 Oct 2021 10:12:15 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <5a8d1ad1-c10d-16ea-4ab9-5c0e1600b3b2@epam.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR0502CA0072.eurprd05.prod.outlook.com
 (2603:10a6:20b:56::49) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: b105d40e-644d-4fb2-2861-08d984b32f43
X-MS-TrafficTypeDiagnostic: VE1PR04MB7360:
X-Microsoft-Antispam-PRVS:
	<VE1PR04MB7360BDACBE9B57AC81A62A13B3AB9@VE1PR04MB7360.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Lwo9nyHh/HI4+z7vd0NBCX5lx2cgXItFePqCUo4Y48Cbr93Ik2hNqBkTyusDYMv/bkciq1bqWdKxuo59UBygqsN9Hf9SE2HEIMkXOtw6IwqqN5QGjPG4XwgTtJEYakiTigrLa20hJ5X3how1VHxI8i6khonMz6by0RvLCpdZc1eDKfL4tDDZBH+2hjjA/m44nuYmEM5zO6JrK4JYqhUzljvHP4Q2E3l97T7/N/b3q2ks8wlYWjQF5A+VGoeflpuUSV/qcJRyvIzHP5Igjf5jwRlptdkrV86Y3/Q7tOhy4DlZQOgDhWHXNa5OA6n54Nmc4zZ9Q4qQ8RrJUJDFUNh9ef946Z8BrZ9F1f0mC+UMBk3sQKp+xxRO0M1ccoTwXHfqRilR1KavjZmbCOgO3qRS0dmgaUdmVOB5BBu7y5vJ/S6lh3PXNtUCgWRuxidQo1ozzxd0IKcJP2vtdJ+xapbmizwNDCROujD1HmywQXff7cW0RZ3ngfqtXOemHAZDwXHiJ82ZdDD+7UtlBjUaRvhN4qpAXpzyMqHcY4jXcwe/IhrsNdv9wd98WVNqmsxJ26IcyDu3wW8HerUKIysU2Cc42cqVSjMdHFvSYReQMEy6Upwn2hYOVYKPxtjJdfpGLrwrG9O9qrnGvW4yvsjfzjVUk/25uphWA8FMzIdjRvQN5W7GhhWfc3ency5LBZ323NxnukCL2i+Z6TSBRgaVI3pb8Im20NYWzKCp6AX9PaMorxDFFbRthfBBgEttOtfKfc0R
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(6916009)(83380400001)(7416002)(54906003)(38100700002)(316002)(86362001)(31696002)(6486002)(16576012)(66946007)(26005)(66556008)(66476007)(5660300002)(956004)(36756003)(2616005)(2906002)(508600001)(4326008)(31686004)(186003)(8676002)(53546011)(8936002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?TkpPVzQzUVczNGo1aUpzUnNpQUFLR3dkTHNjcDVEMWxxbUxubHVUcXhSVE93?=
 =?utf-8?B?ekNyYS9xbU1HZ1R5cHdCdEpjZWRSNmJaSXFpalp2aG8wck9LcDg3ZXpIR2lY?=
 =?utf-8?B?bWQ1VEhsaWZTeGk3MEVhTFNTdjRmWHZrdERhaWYyZ2lUeDVtQ1F6MGZYL1Jy?=
 =?utf-8?B?Tm5GWk81VW5OVmtMSHdzQmVmRy9hUE1nTEJvclBCSEd3dVRVZGNXa3NFRU5Q?=
 =?utf-8?B?bVJIdlhDUlVmUFZ2SXhkMWoxUUE3Z2M2RVliUmp3NW1oQ2dVakViaVNUd25i?=
 =?utf-8?B?VzEzam5UZ3UyZlZIMzh6aEJrZTRDamNqTXIraDJCZXFZVnNEZU1PSGpOZ0FZ?=
 =?utf-8?B?T3hxRElraXhIS1pjWXRucHd4NThJMXRPQVBqL2hqd3JJT05GdWxhVFQ2UzBx?=
 =?utf-8?B?TkF1V0ZFc2VYRi82VTF3S3NqRXlBWTNxUENlb2U4cEd3dEpnT200UG4rVVRS?=
 =?utf-8?B?cWUyaEVxaEFXZVBxZ1c3ZDJIQjRsK210N2MzREl4TlE1Q1lyWWZzTDhQRkZW?=
 =?utf-8?B?SlRpN04vdmtmR1FyYmlUcnpsWUlhV2dYV2didG9iMTcydFBwRDdHVm1Yd0Ja?=
 =?utf-8?B?b3pHeHFwWklsbG9GWURDZVExU0dBQ3RvSStydFlkYjJCcHpZMUVaUEtuQzlR?=
 =?utf-8?B?VFo3M2ZOS01NNTdrZ2tRMVlRWGZaQXJxNXEzVEpXZGJEMFdYYkh4SkFNY3kz?=
 =?utf-8?B?b1k0aDlKSnlkWVZGVWJDWUUvWXhHL29rYmIzZkg3eWxvRXFpU0NGVlJzZHBK?=
 =?utf-8?B?cVAyT0dXVU1MS0h1dzVnMDBYRm1WdVNlQ2pVY1JwYUJQUmlrRDlVVWxIMFht?=
 =?utf-8?B?L0lQRWIzbVRzNVRpVXY3R09ya1pnL08xcGlGZ2dlZGllNzJ1WlJZL1BxS25u?=
 =?utf-8?B?cjJrTHNETjhISFA5ekVudzJvM3RPam9TTC8rdHZqSHNPZVRhQWE3ODlpNUJo?=
 =?utf-8?B?Z2ZHdlE5TjhMZEduZ2Y4R3l4THJvQXcva1pyMFhGL0x2WFYwcnZRMDU5c3la?=
 =?utf-8?B?RDgzLys0VDJUc01NVmZ3OW91SHBqbWNISVAyTUU4YXEvQnhrTTAxbjJqZTBZ?=
 =?utf-8?B?VlN0V1I4dGErYjlxOThpRUhsYTMzSXBVQXFLOWx1bzFGWm5BVDk1ZnJIZERh?=
 =?utf-8?B?cjdKbmh6MWxuN05SbDgzQStib2I2RFkyYkRiTVYvd3dzdGNML2pJQWZhVXFM?=
 =?utf-8?B?eVZKUnIxM0RBdi9XRGxlZEhyL3lPRlg4b0lwNlR4REpqV1RZUThITjN4dkZH?=
 =?utf-8?B?UkZYRGppekdVWTl3Q01xYXFJM3MrZnRZNURTMzBLNWpqcFUzSWFSU1B0dXNt?=
 =?utf-8?B?VmFjbDArMGFYeXM1V3FxdHVZSzJjZWtrYTdHQzc1aXVNdGVpOE9rSUg0cDQy?=
 =?utf-8?B?YXFJTFZlcXJXVlVLYXBWZVgzcWlUVVYzM0R6WkthNXc1Uk9FREhlaklsVmEz?=
 =?utf-8?B?TjIxekJvUUp1RFhvaUxsa1RLcnZ2RGlEWXhOc1FTamUwUG5NdFkxZ09EQVk0?=
 =?utf-8?B?bVdTQm5KaE5BY3ZNRFFEZGNjVlR6SnJ5cXVuY1AzNzBvaEMwa1F3cXYrRXE5?=
 =?utf-8?B?Y1BNK3djTzFlR2toTGxxM3FCbFZ1VzlvZzQ0VXN2SENIY3JERGpJVUlxYS9y?=
 =?utf-8?B?QWZKSll2NnRvTlBTYWtxQjNVN25FWEU4MlZxWTlGcEV3OFduUjJIQXlmNGlR?=
 =?utf-8?B?QU1GT2IvNVJHdjY3TVcrUGdxTEptVDF4YWZicFZKMFFwZ1IwOWNWREpkWXN4?=
 =?utf-8?Q?cc8UBUdSDyMs1l8T6lwwDTYMdWIsRebuw+VtpX0?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b105d40e-644d-4fb2-2861-08d984b32f43
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Oct 2021 08:12:17.7528
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Qq06HKiEleevsS0Qk5fLbd60pvgyf4PxTaVLFWirISjmw/ZfErkw3ySAY7vndyKI3djnG4LfwiaOEfduB0CfNA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB7360

On 01.10.2021 09:57, Oleksandr Andrushchenko wrote:
> 
> 
> On 01.10.21 10:42, Jan Beulich wrote:
>> On 30.09.2021 18:57, Oleksandr Andrushchenko wrote:
>>> [snip]
>>>
>>>>> +    bool found = false;
>>>>> +
>>>>> +    pcidevs_lock();
>>>>> +    list_for_each_entry ( vdev, &d->vdev_list, list )
>>>>> +    {
>>>>> +        if ( vdev->sbdf.sbdf == sbdf->sbdf )
>>>>> +        {
>>>>> +            /* Replace virtual SBDF with the physical one. */
>>>>> +            *sbdf = vdev->pdev->sbdf;
>>>>> +            found = true;
>>>>> +            break;
>>>>> +        }
>>>>> +    }
>>>>> +    pcidevs_unlock();
>>>> As per the comments on the earlier patch, locking as well as placement
>>>> may need reconsidering.
>>> I was thinking about the locking happening here.
>>> So, there are 4 sources where we need to manipulate d->vdev_list:
>>> 1. XEN_DOMCTL_assign_device
>>> 2. XEN_DOMCTL_test_assign_device
>>> 3. XEN_DOMCTL_deassign_device
>>> 4. MMIO handlers
>>> 5. Do I miss others?
>>>
>>> The first three already use pcidevs_{lock|unlock} and there it seems
>>> to be ok as those get called when PCI devices are discovered by Dom0
>>> and during guest domain creation. So, this is assumed not to happen
>>> frequently and can be accepted wrt global locking.
>>>
>>> What is more important is the fourth case, where in order to redirect
>>> configuration space access from virtual SBDF to physical SBDF we need
>>> to traverse the d->vdev_list each time the guest accesses PCI configuration
>>> space. This means that with each such access we take a BIG PCI lock...
>>>
>>> That being said, I think that we may want having a dedicated per-domain
>>> lock for d->vdev_list handling, e.g. d->vdev_lock.
>>> At the same time we may also consider that even for guests it is acceptable
>>> to use pcidevs_{lock|unlock} as this will not affect PCI memory space access
>>> and only has influence during device setup.
>>>
>>> I would love to hear your opinion on this
>> I've voiced my opinion already: Using the global lock really is an
>> abuse, which would require good justification. Hence unless there's
>> anything speaking against a per-domain lock, that's imo the only
>> suitable route to go. Nesting rules with the global lock may want
>> explicitly spelling out.
> I do understand your concern here and also support the idea that
> the less we wait for locks the better. Nevertheless, even if I introduce
> d->vdev_lock, which will obviously help MMIO traps, the rest will remain
> under pcidevs_{lock|unlock}, e.g. XEN_DOMCTL_assign_device,
> XEN_DOMCTL_test_assign_device and XEN_DOMCTL_deassign_device
> and the underlying code like vpci_{assign|deassign}_device in my case

Well, it's entirely usual that certain operations require more than one
lock.

> Anyways, I'll implement a per-domain d->vdev_lock

Thanks.

Jan



From xen-devel-bounces@lists.xenproject.org Fri Oct 01 08:20:01 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Oct 2021 08:20:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.200482.355003 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mWDle-00055O-By; Fri, 01 Oct 2021 08:19:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 200482.355003; Fri, 01 Oct 2021 08:19:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mWDle-00055H-8w; Fri, 01 Oct 2021 08:19:42 +0000
Received: by outflank-mailman (input) for mailman id 200482;
 Fri, 01 Oct 2021 08:19:41 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=tcpL=OV=gmail.com=olekstysh@srs-us1.protection.inumbo.net>)
 id 1mWDlc-00055B-TT
 for xen-devel@lists.xenproject.org; Fri, 01 Oct 2021 08:19:41 +0000
Received: from mail-lf1-x12c.google.com (unknown [2a00:1450:4864:20::12c])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 5fc64892-f7f6-47b1-8e13-1ef00c4c38f0;
 Fri, 01 Oct 2021 08:19:39 +0000 (UTC)
Received: by mail-lf1-x12c.google.com with SMTP id i25so35706152lfg.6
 for <xen-devel@lists.xenproject.org>; Fri, 01 Oct 2021 01:19:39 -0700 (PDT)
Received: from [192.168.1.7] ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id 8sm600788ljr.10.2021.10.01.01.19.37
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Fri, 01 Oct 2021 01:19:38 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5fc64892-f7f6-47b1-8e13-1ef00c4c38f0
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-transfer-encoding:content-language;
        bh=R1+zef/LR7kVhhXEmdP6iIBCi010Oykuu31XKn+GGII=;
        b=mhyA9da7dX2Q8z+ZRcoubqjmlBCyJA/yUeUgYbWFkUsMiC/6+9g7x0P5QdylX50DOs
         UeE2teyenWQ0tENUBtvDyuw5l/clCxl6Aol2P8YaRaO1n5/t/5n0X9EWnPcqP1kz39D8
         //MifxjA/GLqRYLjMrjVk8bjIgnrLkHvOwVQD5U9V3xzz1rh9CgZufDXpV+ZTuftpMgX
         FKyosz9A0C7dzuumsGHTFLna6xtgiiLxmXFyV+bZddky5rSHucH42GTW62CgBtAY6jQu
         nWnJX5VJXd3A/8dEEyNWX+5ibp1KLsvtquaWaHjZFxwRP36CrknMdwgND4DVZdTl/30K
         cISw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding
         :content-language;
        bh=R1+zef/LR7kVhhXEmdP6iIBCi010Oykuu31XKn+GGII=;
        b=Ul+gLvVKEvpmH0vyaEiC98xrgBzSGJvxrx7qTsnAoJSKASrsiUK1v0prCp8KZR6eW5
         35DHCG02BNuqTiRt3fW5ElhX2DCtMMy8TZc0VzS7YfOIWZebwIG1TW/qgqtVmTWK3f0H
         NI0+gHMNDANwODsounIGM2vqBRITE5fx66b5SNtEf+JsGClLvmdWshfHaAMEfgMvhKV6
         AAzahOhMqqjfr8cPqwJFuLQ4hKP7CsO25oQfaU6VvnD0RRp6jFjnIjbsTRqDbyjAtytt
         GptJoicw5T3DnGFhKtrvT4z1zUTL/QAALUkiJHbI7Cyb25tOLeTSUSApJ8YMiTq0pvlE
         KcoQ==
X-Gm-Message-State: AOAM530mrABPHI4EbQmv/xgdgbcy8Jjrx7YhT2JTySkrlz9Um1f9Riu6
	0iBdHNWrQqX/hUTVK3qT/20=
X-Google-Smtp-Source: ABdhPJzzU4Uf4RUlVFBstKgqJ++y6nd9xgptmKSYgIwMoVvwqRY5pQ6QJAms3KFTCOapMOZmr7HguQ==
X-Received: by 2002:ac2:48b7:: with SMTP id u23mr4083116lfg.51.1633076378871;
        Fri, 01 Oct 2021 01:19:38 -0700 (PDT)
Subject: Re: [PATCH V4 1/3] xen: Introduce "gpaddr_bits" field to
 XEN_SYSCTL_physinfo
To: Jan Beulich <jbeulich@suse.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 xen-devel@lists.xenproject.org,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>,
 Anthony PERARD <anthony.perard@citrix.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Juergen Gross <jgross@suse.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <1632955927-27911-1-git-send-email-olekstysh@gmail.com>
 <1632955927-27911-2-git-send-email-olekstysh@gmail.com>
 <alpine.DEB.2.21.2109301600060.3209@sstabellini-ThinkPad-T480s>
 <05b040b0-a069-47a1-1f5e-85be62fa35f3@suse.com>
From: Oleksandr <olekstysh@gmail.com>
Message-ID: <bbbceae1-c382-5e48-0c6b-fbb23fc720f5@gmail.com>
Date: Fri, 1 Oct 2021 11:19:37 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <05b040b0-a069-47a1-1f5e-85be62fa35f3@suse.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US


On 01.10.21 10:50, Jan Beulich wrote:

Hi Jan

> On 01.10.2021 01:00, Stefano Stabellini wrote:
>> On Thu, 30 Sep 2021, Oleksandr Tyshchenko wrote:
>>> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>>>
>>> We need to pass info about maximum supported guest address
>>> space size to the toolstack on Arm in order to properly
>>> calculate the base and size of the extended region (safe range)
>>> for the guest. The extended region is unused address space which
>>> could be safely used by domain for foreign/grant mappings on Arm.
>>> The extended region itself will be handled by the subsequents
>>> patch.
>>>
>>> Use p2m_ipa_bits variable on Arm, the x86 equivalent is
>>> hap_paddr_bits.
>>>
>>> As we change the size of structure bump the interface version.
>>>
>>> Suggested-by: Julien Grall <jgrall@amazon.com>
>>> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>>> Reviewed-by: Michal Orzel <michal.orzel@arm.com>
>> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
> I have to admit that I'm a little puzzled to see these R-b-s when ...
>
>>> Please note, that review comments for the RFC version [1] haven't been addressed yet.
>>> It is not forgotten, some clarification is needed. It will be addressed for the next version.
>>>
>>> [1] https://lore.kernel.org/xen-devel/973f5344-aa10-3ad6-ff02-ad5f358ad279@citrix.com/
> ... Oleksandr makes clear this patch isn't really ready yet.

Unfortunately, this is true. I am still waiting for the clarification [1]



> The tags
> could misguide a committer into putting in this series despite the
> open issue(s).
>
> Jan


[1] 
https://lore.kernel.org/xen-devel/6a2a183d-c9d8-df2a-41aa-b25283fab197@gmail.com/

-- 
Regards,

Oleksandr Tyshchenko



From xen-devel-bounces@lists.xenproject.org Fri Oct 01 08:22:26 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Oct 2021 08:22:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.200491.355013 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mWDoH-0006UI-U7; Fri, 01 Oct 2021 08:22:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 200491.355013; Fri, 01 Oct 2021 08:22:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mWDoH-0006UB-R5; Fri, 01 Oct 2021 08:22:25 +0000
Received: by outflank-mailman (input) for mailman id 200491;
 Fri, 01 Oct 2021 08:22:24 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=wBg0=OV=citrix.com=anthony.perard@srs-us1.protection.inumbo.net>)
 id 1mWDoG-0006U5-23
 for xen-devel@lists.xenproject.org; Fri, 01 Oct 2021 08:22:24 +0000
Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 34f88ce9-e327-472e-8cec-96ba0c1942c0;
 Fri, 01 Oct 2021 08:22:22 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 34f88ce9-e327-472e-8cec-96ba0c1942c0
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1633076542;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:content-transfer-encoding:in-reply-to;
  bh=ZiGk4NDtrVug4ya2/5PA4fG3vz7ezTa7Zl8doUDMxSQ=;
  b=e6zL2uFw/HEs2oUjbJwpWUCkOCTq6VcvYSi+gAopy3Lj4PYp9umMhoyn
   87tgit01Vu3AP/wqHXULCWLL7sTakCXdyRWPFpApcCex37AkWk60js2Sg
   dRleklU0u+mzV2llo11LZlwQbrijD6V9ttYe71mnt9vTKIBdWe1hFAFAC
   c=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: xjNuC5huCGOgSsZo8JWW09tuGFvRFIs9PxbBPY+iAPb15W/Ohc8HgpPHXmqcjeM9qc2ESbmm1o
 xn1Bwy+a1/9+4yA568AsXGqOIYxIaGI6q3R6KrWJMeABWPveoOCYoio3Pga6ea2PWJKXUlMNOl
 sQK7LgR28t0q5frvhRozzwYkhCyJ9zK4CvhrXVxNdD8eAQHfD78Z7jUojOILQnJ5Xt48GYhIEK
 rs+kMw4Alykl5EgXmKP8XfoH7tcvlV2uEGZW2esPvUGSy5dzfjMGH9GSLh+D3ILijGNyBwcWdj
 t3PqoGB3WuAi3zrGrfEl9Oti
X-SBRS: 5.1
X-MesageID: 55941337
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:2FpJxaiMeUcNhNF9qhNf6vHOX161vBcKZh0ujC45NGQN5FlHY01je
 htvWD2PPaqDYDb8e9BwaIy19kgFsJ7cnYRlQAZqpS9hQSgb9cadCdqndUqhZCn6wu8v7a5EA
 2fyTvGacajYm1eF/k/F3oAMKRCQ7InQLlbGILes1htZGEk0FU/NtTo5w7Rg29Yw2IDja++wk
 YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq
 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx
 /1A7LihECFyYZTu28M+ED9AMz93ZaFJreqvzXiX6aR/zmXDenrohf5vEFs3LcsT/eMf7WNmr
 KJCbmpXN1ba2rzwkOnTpupE36zPKOHiOp8fvXdxiynUF/88TbjIQrnQ5M8e1zA17ixLNauDN
 pZAMmEwBPjGSzFmY1gHK5gypsPyukTOUiJZiX/FlJNitgA/yyQuieOwYbI5YOeiTsxPkkGVj
 mnP5Wj+D1cRM9n34TOD7nKrgP6JhS7hUZgePLK9//9uxlaUwwQ7GBAQEFe2v/S9okq/QM5Eb
 VwZ/DI0qqo//1DtScPyNyBUu1bd4ERaAYAJVbRntkfdkcI4/jp1GEAJFxpQMfp96/YUBhsJl
 XmRv83gXTBg5ej9pW2myp+Yqja7OC4wJGAEZDMZQQZt3+QPsL3fnTqVEI88QffdYsndXGGom
 m/W/EDSkp1J1aY2O7OHEUcrat5GjrbOVBJ9wgzKUm+/4gp9aeZJjKTzsgODvJ6swGuDJ2RtX
 UToeeDCsYji7rnXzURhpdnh+pnyu55p1xWG3zZS82EJrWjFxpJaVdk4DMtCDEloKN0YXjTif
 VXevwhcjLcKYiDxNfUoONzoVpR7pUQFKTgDfquIBjapSsIvHDJrAQk0PRLAt4wTuBJEfV4D1
 WezLp/3UCdy5VVPxzuqXeYNuYLHNQhlrV4/savTlkz9uZLHPSb9Ye5cbDOmM7BohIvZ8V692
 4sOaKO3J+B3DbSWjt//qtVIczjn7BETWPjLliCgXrTYf1U6SD1/Ua+5LHFIU9UNopm5X9zgp
 hmVMnK0AnKk7ZEeAQnVOH1ldp31WpNz8SAyMSA2ZA760Hk/e4e/qqwYcsJvL7Ug8eViy99yT
 uUEJJrcUqgeFGyf9mRPd4T5oaxjaA+v2VCEMR26bWVtZJVnXQHIpIPpJ1O96CkUAyOrnsIiu
 Ln8hBjDSJ8OSl06XsbbYf6i1X2run0ZlL4gVkfEOIALKk7t7JJrO2r6ifpue5MALhDKxz270
 QeKAEhH+bmR8tFtqNSQ3PKKtYakFed6D3F2JWiD4ObkLzTe80qi3ZREDLSCcwfCWT6m466lf
 +hUka3xaaVVgFZQvoNgOL931qZitcD3rrpXwwk4TnXGa1OnVuFpLnWchJQds6RMwvlSuBesW
 1LJ8d5fYO3bNMTgGV8XBQwkcuXciq1ExmiMtaw4cBfg+St63LubSkEDbRCDhRtUIKZxLI54k
 /wqv9Qb6lDnhxcnWjpcYvu4K4hYwqQ8bpga
IronPort-HdrOrdr: A9a23:MoPd6aHBnsQ+/4TLpLqE0MeALOsnbusQ8zAXP0AYc31om+ij5q
 eTdZMgpHnJYVcqKRUdcL+7VJVoLUmyyXcx2/hpAV7AZniChILLFvAA0WKK+VSJcEeSygce79
 YDT0EXMqyJMbEQt6bHCWeDfeod/A==
X-IronPort-AV: E=Sophos;i="5.85,337,1624334400"; 
   d="scan'208";a="55941337"
Date: Fri, 1 Oct 2021 09:21:46 +0100
From: Anthony PERARD <anthony.perard@citrix.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
CC: <xen-devel@lists.xenproject.org>, Anthony PERARD
	<anthony.perard@gmail.com>, Doug Goldstein <cardoe@cardoe.com>
Subject: Re: [XEN PATCH 2/2] automation: Add qemu to debian:stretch container
 for smoke test
Message-ID: <YVbFGqWEMIVyr1JY@perard>
References: <20210930161720.825098-1-anthony.perard@citrix.com>
 <20210930161720.825098-3-anthony.perard@citrix.com>
 <c242d263-25e1-1540-419b-11c74b2719d5@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <c242d263-25e1-1540-419b-11c74b2719d5@citrix.com>

On Thu, Sep 30, 2021 at 06:05:44PM +0100, Andrew Cooper wrote:
> On 30/09/2021 17:17, Anthony PERARD wrote:
> > --- a/automation/scripts/qemu-smoke-x86-64.sh
> > +++ b/automation/scripts/qemu-smoke-x86-64.sh
> > @@ -6,9 +6,11 @@ set -ex
> >  variant=$1
> >  
> >  # Install QEMU
> > -export DEBIAN_FRONTENT=noninteractive
> > -apt-get -qy update
> > -apt-get -qy install qemu-system-x86
> > +if ! type qemu-system-x86_64; then
> > +    export DEBIAN_FRONTENT=noninteractive
> > +    apt-get -qy update
> > +    apt-get -qy install qemu-system-x86
> > +fi
> 
> I'd just delete this all.� It's wrong for running smoke tests in other
> containers anyway.
> 
> Can fix commit too.

Sounds good, thanks. In that case, I need to push the updated container
before we commit the patch.

Cheers,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Fri Oct 01 10:56:38 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Oct 2021 10:56:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.200527.355033 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mWGDJ-0004xJ-15; Fri, 01 Oct 2021 10:56:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 200527.355033; Fri, 01 Oct 2021 10:56:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mWGDI-0004xC-U8; Fri, 01 Oct 2021 10:56:24 +0000
Received: by outflank-mailman (input) for mailman id 200527;
 Fri, 01 Oct 2021 10:56:23 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=LRx5=OV=arm.com=Rahul.Singh@srs-us1.protection.inumbo.net>)
 id 1mWGDH-0004x6-3H
 for xen-devel@lists.xenproject.org; Fri, 01 Oct 2021 10:56:23 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com (unknown
 [40.107.6.73]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id cd897907-829c-4ef9-852f-a7b9cbe3c3b9;
 Fri, 01 Oct 2021 10:56:19 +0000 (UTC)
Received: from AM5PR0201CA0006.eurprd02.prod.outlook.com
 (2603:10a6:203:3d::16) by DB7PR08MB4618.eurprd08.prod.outlook.com
 (2603:10a6:10:78::21) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.15; Fri, 1 Oct
 2021 10:56:17 +0000
Received: from AM5EUR03FT026.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:203:3d:cafe::69) by AM5PR0201CA0006.outlook.office365.com
 (2603:10a6:203:3d::16) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.14 via Frontend
 Transport; Fri, 1 Oct 2021 10:56:17 +0000
Received: from 64aa7808-outbound-2.mta.getcheckrecipient.com (63.33.187.114)
 by AM5EUR03FT026.mail.protection.outlook.com (10.152.16.155) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4566.14 via Frontend Transport; Fri, 1 Oct 2021 10:56:16 +0000
Received: ("Tessian outbound 3c48586a377f:v103");
 Fri, 01 Oct 2021 10:56:16 +0000
Received: from 16dce784b55f.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 3F37F741-CFA7-4992-BF6B-2D002A33611F.1; 
 Fri, 01 Oct 2021 10:56:04 +0000
Received: from EUR03-VE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 16dce784b55f.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 01 Oct 2021 10:56:04 +0000
Received: from AS8PR08MB6919.eurprd08.prod.outlook.com (2603:10a6:20b:39e::10)
 by AS8PR08MB6231.eurprd08.prod.outlook.com (2603:10a6:20b:298::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.13; Fri, 1 Oct
 2021 10:56:01 +0000
Received: from AS8PR08MB6919.eurprd08.prod.outlook.com
 ([fe80::c8de:afad:1d5a:efd0]) by AS8PR08MB6919.eurprd08.prod.outlook.com
 ([fe80::c8de:afad:1d5a:efd0%7]) with mapi id 15.20.4544.022; Fri, 1 Oct 2021
 10:56:00 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: cd897907-829c-4ef9-852f-a7b9cbe3c3b9
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=PMC8C8S3srz1acfz0PVOTwhW7CYkqeFUHKm0A5iBjyc=;
 b=qNynLcZDInCB0i3NV3RTkmW8tZkWESEdgmH1oiVWeqJOgvvEdifGhf0l7xpLH/nAboebZHvBZCBkH5C+Si/zZVZ5HVsvxGoOuBcK/SNYtarWvbCP6OP42MaLxpy0r/EqwRdhQQ2MssTygbXxptsSzucztqcqoLTQtazmBSL6QVE=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.33.187.114)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.33.187.114 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.33.187.114; helo=64aa7808-outbound-2.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 0cb3bee530746eeb
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=cVJARB+lxiIQ+ucnvTjhWzY3HCrpGH4mApLN1sw0v4x8/VWuKtZKuq5bmXV5euWehgyd1b/mpGsU0Gcy+n8JCHt+o/7AoW+kbrNQ3KO4zBG1acZyhsxFDfgcLlT3N0vFg1w5T3k5FBTlGwlPirEkJNKyQI/uNVvwB1SinVmjaQ3O3QOPcE/P7LXod4oWIHJXLQfI3Sbk1GuQ8KrHwNEt/X0szYIjq9oabffjvbuekbGlsZYLMv98UISFc7UpjKUuhj9piqjBLVS/fDZ2PfgqFN+lUvu3gBYdwlOpgGc2+tw+aC5IccRO6VpzHEKvYUaQuUIyKBpvRT7kzadbyYqG0A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=PMC8C8S3srz1acfz0PVOTwhW7CYkqeFUHKm0A5iBjyc=;
 b=cMJ/4X+j/fTewmAOQtXoqVQIBnH2oCl7Tmp8fQrD1P0CIXaDMuy6KG4jzb2URcf9ICDj3TcQ2AZdrwaCLkE8jL4AlMs8OWSEnrxtsOzDqyPnPKortw4m7Gmmbint8aMsbQCh30viUCURByccpAzDRxjkn5g+tLrlPyI/JM2GnISUv6/K+njHQO2LbV8azTINtBH6hsIS3jyVkSmNqqGPbgJFb7GRuRoL91Q252VNqLh22Qj0ggOiE9lfRl6CNXhXcS2/Ru74vZ3n0rUWLYjc5T2v2Ym0ICsI5FEeZEp9zKNvtczwrVcABlakzDqG+Ex22vDJEaER1Nwej+HmUCiW0g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=PMC8C8S3srz1acfz0PVOTwhW7CYkqeFUHKm0A5iBjyc=;
 b=qNynLcZDInCB0i3NV3RTkmW8tZkWESEdgmH1oiVWeqJOgvvEdifGhf0l7xpLH/nAboebZHvBZCBkH5C+Si/zZVZ5HVsvxGoOuBcK/SNYtarWvbCP6OP42MaLxpy0r/EqwRdhQQ2MssTygbXxptsSzucztqcqoLTQtazmBSL6QVE=
From: Rahul Singh <Rahul.Singh@arm.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Bertrand Marquis <Bertrand.Marquis@arm.com>, Andre Przywara
	<Andre.Przywara@arm.com>, Andrew Cooper <andrew.cooper3@citrix.com>, George
 Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>, Julien
 Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>, Wei Liu
	<wl@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	=?iso-8859-1?Q?Roger_Pau_Monn=E9?= <roger.pau@citrix.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v3 10/17] xen/arm: Add cmdline boot option
 "pci-passthrough = <boolean>"
Thread-Topic: [PATCH v3 10/17] xen/arm: Add cmdline boot option
 "pci-passthrough = <boolean>"
Thread-Index: AQHXtJXG2o5Yt51spkWvVbiV4Q7GQKu8rowAgAFOHAA=
Date: Fri, 1 Oct 2021 10:55:59 +0000
Message-ID: <6F9450F5-90D3-46A7-8461-529F8995A1CE@arm.com>
References: <cover.1632847120.git.rahul.singh@arm.com>
 <edd6689cc977292fa874059861474993e5819c14.1632847120.git.rahul.singh@arm.com>
 <8b9dc108-c20a-bce3-42cf-18a44e369776@suse.com>
In-Reply-To: <8b9dc108-c20a-bce3-42cf-18a44e369776@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
Authentication-Results-Original: suse.com; dkim=none (message not signed)
 header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: 7fa729fe-9a5b-43bf-e9a7-08d984ca17d6
x-ms-traffictypediagnostic: AS8PR08MB6231:|DB7PR08MB4618:
x-ms-exchange-transport-forked: True
X-Microsoft-Antispam-PRVS:
	<DB7PR08MB46180C895D8B976679DFB2BCFCAB9@DB7PR08MB4618.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:8882;OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 TCFMf4r4VCJ/Bso+P+Yi38JwS9pNUIgc6j+6yEtItjfcoLRexwjUiVs2C0r2LsF40xVfz4kTOU1NQQtLnZQFV57bQV8NVJAdcTxJE9qrfn8DrEVbm+tDOCMhOYXuFNGYPpZ3b+qL5ivVk5FOM9CyOKxuGax+MQEPP+WEdj3k/vnSusiLpqQUm6eZYM3G2iPagfShc2ECDRYRW8zM0EqMLobKOF+/fvZ6mnO9rW1VzamGm9s1pSIWUYr5BRAJKiUDcG6DtYH+lX7q/iyFKCje36o3OmR3w8MmRqceRlXIseGiMUKoIaYYmnqyGjIJR+hluwQ2ifybrBisNEHr7V3wHiPuLUH01XTHdquU2hEbUGNRLpeHs57oUpBNf6XkzmH8O5AtVf3cG+EQX0Pq2PwICcDYstDzFNNB4XG99Jb/EVxj3b3jhaTPurqfAhPdG6dp0LpRgRPgSCPkcNzR0c4i5n443ogrMRBSH70T7IpNGN4+QThe8AysasJNPxjnAboydBRchnRX9rllqtO3XN3HEMYCVkdpZAVCdrWnVnabaqX+Eem9puulY98GaPH5vHlaZmoLetQu2ZI6RNepgmWi0kU/VDmvESs8rJ5ImoSmGYLeahx+ybDj4bomr77QZHRbsPNKZ+wD2b2ryGTCUf0SazYvsxJncZ3ukgXesnlg7QvMLMNg4ftvVdTgQk0cUs257fmeeNlJfLJxujlJwR+THsuY5BHdWxKcRA5n0pxKvInvrnZO2hHEXTMkVVb8j1a4
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6919.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(36756003)(6512007)(508600001)(83380400001)(122000001)(6916009)(86362001)(5660300002)(2616005)(54906003)(316002)(2906002)(33656002)(8676002)(71200400001)(8936002)(66476007)(66556008)(64756008)(66446008)(26005)(7416002)(38100700002)(91956017)(76116006)(6506007)(53546011)(186003)(6486002)(4326008)(38070700005)(66946007)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="iso-8859-1"
Content-ID: <7E125D4F00E3E34880C860980D98FD1E@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6231
Original-Authentication-Results: suse.com; dkim=none (message not signed)
 header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM5EUR03FT026.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	db0ce3f1-f1d1-4ae8-5313-08d984ca0de9
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	SnkkQlnYvJIMd1mt+5WYDQjwkSc/7ICH+EI5SsFRQ6QGLmDT8LZLX2wwBEdxqV3drHN69keiRNnEGBm0ylGNc5JvUlsvwfFYX625HdvAhGcEhf9yKBJ7pQen6vrJIVMTBRkVAd2T0x/56pB2rrUsfmyfVHSzxFvZ4zOofGhloITEaKoHYLsB994x6xjDx+yU0yHxxs+HlDvinCsLEomO6ItiLkfCVMT7hCAeat2BN+pYUCOft8+tjJJMEXHsN+dFQqJXYBAU35hb9mAJRZAfs+jqq8tGw8NuhyfM2z/WA3t4BpUQQMKryoXBtnwyCdsNFfun8sTiUYj2YwlpwVs4dtH5ePpZhpbXPcr9dxQaMopwKd9MyAlrRtu5QbNp2zV1bc/vZ2sDn06ZG923O6emOFElExyDq2gjiJy01YrozRW3Vk7iXQ69D6i0F48dwwGIAvo6Ns1RTqreM55eE0kqQ3Uci0ooZXDqx1xW5z7+hQUXRYXjr3IG6yB3HepAIKAJSVWdIOl2bDbrZz6RRb/5kBcb+PmV8w9gt0hhU84+TXGGpMUkEyOT0uKmYqIMChjl23osdlsR6OuO2Pk9cZDDWkFMJgEQbkbjzKAd80k15PRnAV6BoO85X0dtsCDr5/7oRYcczGB/hcjOpBi7EeBZ7paH13BFdrZJHtIw/GD0Pc9zSWCvvM9c/f6LvaNLdniS5vSatdmdIZ9fkWfJLNFtZA==
X-Forefront-Antispam-Report:
	CIP:63.33.187.114;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-2.mta.getcheckrecipient.com;PTR:ec2-63-33-187-114.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(70206006)(83380400001)(70586007)(82310400003)(8936002)(6512007)(6486002)(47076005)(86362001)(316002)(36860700001)(53546011)(336012)(4326008)(8676002)(5660300002)(2906002)(6862004)(54906003)(508600001)(26005)(6506007)(186003)(33656002)(2616005)(356005)(36756003)(81166007);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Oct 2021 10:56:16.7296
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 7fa729fe-9a5b-43bf-e9a7-08d984ca17d6
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.33.187.114];Helo=[64aa7808-outbound-2.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM5EUR03FT026.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB4618

Hi Jan,

> On 30 Sep 2021, at 4:00 pm, Jan Beulich <jbeulich@suse.com> wrote:
>=20
> On 28.09.2021 20:18, Rahul Singh wrote:
>> @@ -62,8 +63,21 @@ static int __init acpi_pci_init(void)
>> }
>> #endif
>>=20
>> +/*
>> + * By default pci passthrough is disabled
>> + */
>=20
> Nit: This is a single line comment.
Ack.
>=20
>> +bool __read_mostly pci_passthrough_enabled =3D false;
>=20
> Nit: Unnecessary initializer.

Ack.=20
>=20
>> --- a/xen/common/physdev.c
>> +++ b/xen/common/physdev.c
>> @@ -19,6 +19,9 @@ ret_t do_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(vo=
id) arg)
>>         struct pci_dev_info pdev_info;
>>         nodeid_t node;
>>=20
>> +        if ( !is_pci_passthrough_enabled() )
>> +            return -ENOSYS;
>=20
> Here and ...
>=20
>> @@ -54,6 +57,9 @@ ret_t do_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(vo=
id) arg)
>>     case PHYSDEVOP_pci_device_remove: {
>>         struct physdev_pci_device dev;
>>=20
>> +        if ( !is_pci_passthrough_enabled() )
>> +            return -ENOSYS;
>=20
> ... here -EOPNOTSUPP (or any other suitable value, which -ENOSYS is not
> from all I can tell) please.

I checked all the possible errors and came to the conclusion that
 -EOPNOTSUPP is the right choice here.

>=20
>> --- a/xen/include/asm-x86/pci.h
>> +++ b/xen/include/asm-x86/pci.h
>> @@ -32,4 +32,12 @@ bool_t pci_ro_mmcfg_decode(unsigned long mfn, unsigne=
d int *seg,
>> extern int pci_mmcfg_config_num;
>> extern struct acpi_mcfg_allocation *pci_mmcfg_config;
>>=20
>> +/*
>> + * Unlike ARM, PCI passthrough is always enabled for x86.
>> + */
>=20
> Nit: This again is a single line comment.

Ack.

Regards,
Rahul
>=20
> Jan
>=20



From xen-devel-bounces@lists.xenproject.org Fri Oct 01 11:02:33 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Oct 2021 11:02:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.200538.355044 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mWGJB-0006UK-NU; Fri, 01 Oct 2021 11:02:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 200538.355044; Fri, 01 Oct 2021 11:02:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mWGJB-0006UD-KH; Fri, 01 Oct 2021 11:02:29 +0000
Received: by outflank-mailman (input) for mailman id 200538;
 Fri, 01 Oct 2021 11:02:28 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=KCT2=OV=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mWGJA-0006U7-MZ
 for xen-devel@lists.xenproject.org; Fri, 01 Oct 2021 11:02:28 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id b5069137-a4a1-4543-a8a9-d415cfcac6af;
 Fri, 01 Oct 2021 11:02:27 +0000 (UTC)
Received: from EUR02-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur02lp2055.outbound.protection.outlook.com [104.47.4.55]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-12-T4f074yVOoyH22-5GOVMfw-1; Fri, 01 Oct 2021 13:02:25 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB3295.eurprd04.prod.outlook.com (2603:10a6:802:f::25) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.13; Fri, 1 Oct
 2021 11:02:23 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4566.014; Fri, 1 Oct 2021
 11:02:23 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6P195CA0042.EURP195.PROD.OUTLOOK.COM (2603:10a6:209:87::19) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4566.14 via Frontend Transport; Fri, 1 Oct 2021 11:02:22 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b5069137-a4a1-4543-a8a9-d415cfcac6af
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1633086146;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=Ph6KaMbPkah9J+JxsGqXX1y6eNR6L6NWApTdufs4h/Q=;
	b=D8qfhSWcyBVoiLkWDez1YpV+N4A75TTvSeN4drXoh2PfhwiCk8bzGPmM+qVead9Z09XX3c
	Bf0u99w36l/RUmF9u77FcDBiG08zjgN2Wmx17Y1ESh1yKAH/rF526PI+w2W8J1McsllsSg
	7molv5SgT4+yCFOxZ7veGDNfiZWsVCw=
X-MC-Unique: T4f074yVOoyH22-5GOVMfw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=OvbnVegP7m2yzbDQ/Vw5KQEzE4p5t53q0PQHitooL8tZY+FrwZpjAZeA2LNQ/3W+wTa5bFdpGp5lbjy0HOwpjElnzT3uk5J+DCRUSFT7XSSiT5iFPb0UUFSWLbgRNzKjxk6cLvitYbba3G6ZkrsAvUMBCSl16WzFGec2gBRJp9ryNXk0YeOXeVU4cPyQKHaNDeWBZ98KVFCfo1pbONKKdtX3oC+d37T8vTy7BzQrPv2ge851UC3rxUIkgEhZSbXweXkDFXosuGP14mbPGJMlz0F9KTT6X0AL8/W1oA1ON+Q+WHW8vC09yNe2udnBgJTWbRpnBneCDdSU7qzMD2s7lQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Ph6KaMbPkah9J+JxsGqXX1y6eNR6L6NWApTdufs4h/Q=;
 b=j47QE0dntEYJuLXVS2x/GGhNSQPZzVfyV1nI3N/3/FxnyMqRj0q8GkqJHBhre6SNELgilfe6MqlcJRI1JsEk9LIkIzT1Ij6ea1RhFdm/OPnthMsPlTEANRK8bHpteKNntsYZCaSOCrhKB3hI0kvVj6/WAGQFTovIOQPplzPHcns3FLQdBWYHEs72QOqEbFSUg37ChqQ0+8PBcKtFxydmNLVHGF3JOfiDNeUbklL2dgre28gz8vTLXVnSnAL0ceAVc8uz+/BL+v4eoHLPo4MTprVl13UrbKrKQRPG4PRp1xseOt341YTAuTz3k7Um+4RX1j0oj5UT518loG9IBSDLAw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [PATCH v4 2/3] arm/efi: Use dom0less configuration when using EFI
 boot
To: Luca Fancellu <luca.fancellu@arm.com>
Cc: bertrand.marquis@arm.com, wei.chen@arm.com,
 Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Wei Liu <wl@xen.org>, xen-devel@lists.xenproject.org
References: <20210930142846.13348-1-luca.fancellu@arm.com>
 <20210930142846.13348-3-luca.fancellu@arm.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <2fa4be34-9c69-21cb-632f-f566caf622ca@suse.com>
Date: Fri, 1 Oct 2021 13:02:21 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <20210930142846.13348-3-luca.fancellu@arm.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P195CA0042.EURP195.PROD.OUTLOOK.COM
 (2603:10a6:209:87::19) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 7f56697d-1063-4dd0-bea7-08d984caf27a
X-MS-TrafficTypeDiagnostic: VI1PR04MB3295:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB329507DCC9BD2A532D7417A5B3AB9@VI1PR04MB3295.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:173;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	HphvIm+8SKJGM4w/KENOPeO2DSekkrsLRO9tcuxH4G+C2uD78DRBauD9LKTYFL6NDd3ZMQoRPVTh8n0227FOnFXUXOrRFT7x6agNKj9ogxPzLJoXlGWDQ9jhNa1Y+n1O5KE+fURtVw+W6r1Q2rx/iroZDevR5ctpDQHwQj5pHIpmGsrntgGJXoGr3KbbBFUZERKnAjgzer77HnIGznUoukSr3jj57OlIDjS3P5mUqDJViGk7z4QzpxO+Wprm76/iFt2PdRGDpkQNDxlOnG5tbuI6VbEn0B6DFJc8Z/gG2Gze04gGpdA5s+HcJ8onHPQulo2V6z4U3v5uREd9cNGLTjUbVZBvLdJ+z+fk5hiT3yeHWrnzmCAykhdpG/w86WogmwxbZxcfqSkpaQp/ZqdPBQTTBrpgKMhrB3nvZl3S79y8P4dn+RlR1hjVTzQuPYmrQ2YOhuwu4WR89wthsGIAqMAc0mSrycT0Uy/uOTsN6EWy7nhMPymNkgvZ+JAIVNYOQzorLKLJWJY7fq3vdUxGF8MwFb+QOPA9uNJ9dKTqtx0Acxy1+amA9EyvThhXMJIAn5tWMdh/GyrBK3jFbtm0vYaYHUX0hfIw7Bxe6wtIGgk50JKgPscuNu85+oyw2wEidniIoNLTv3P4COTr9kNUaeNZTVFO+mlJFyARAHxwq4NWbFCmfuSpRG5n5YKv3nlOs+0q2hHYazDHsbT8KamqdTtZfja7ACgI31Qou6GpKUh7zSL9ER1oGOEAI6SdvDPKSW2i1NLaijaZZ/szKuyvAQ==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(16576012)(2616005)(83380400001)(38100700002)(508600001)(956004)(36756003)(186003)(6916009)(4326008)(6486002)(2906002)(66476007)(5660300002)(31696002)(54906003)(86362001)(7416002)(8936002)(66946007)(316002)(31686004)(8676002)(66556008)(26005)(53546011)(32563001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?RXVKNy9WclZHK2RvZS9oRzU3L04zU0pjWk9GdE5yRnp1TVZKSHV4eEF5VUQ4?=
 =?utf-8?B?RlhpckoyTSsvZ2lHU21UYVpWOEpUK3NFNjVxbmtPaFhaSWI2K1hsWFU5TUVC?=
 =?utf-8?B?eG5Xb0RPOG9VM2FqL1JJVEFEdFVvMWN1c2ZXUkRTaXU1REJ6dnRRMTQ2Yk9W?=
 =?utf-8?B?TUNyR045TGFPTlRNcHBBM3hTOUZSS29WVkJERjBQSXVYYnFDZy91TmRENHl0?=
 =?utf-8?B?QTZTWTZ6QlBPOVArRDBFSTUyQTUzbjdEQ1N1d3owK0s0cndpRG50dXk5TUN6?=
 =?utf-8?B?WHFGN0FYNmI4VUFIZjgramk0OXo0SUo5dDJGMDJoa3BjY08zK0YyTitzcDc4?=
 =?utf-8?B?RzE3Sm4xMHNsczdTUjVUN3BYb2dZaU9MbWg1dERhRmxYSmgyTTRlODE5ODJF?=
 =?utf-8?B?TlVRcThpdmovbUdYNElJZ05xdTNRS2RXd2d5cHo2QUhSdGJTbzVkcTRBU3FZ?=
 =?utf-8?B?eGl1TlA4R1RIZG9ZejROUWNnaERCQml4U2crTWRqMHVCV0ZsV3l6SXBJWVBO?=
 =?utf-8?B?R2FKQmZZVGdxdEI2SCtZYXl0T2E1MHgzblR5V1ZPdWljd2JhbUJ1STJYTkZJ?=
 =?utf-8?B?K0FEdjEvTFIvTXgzcmljRExMM0VZak9idEtHYlJNU21xcmoyTWx2RjJoL2Ra?=
 =?utf-8?B?T2w3eFhkMjVZQnJXS3o1MnVnNDkvckZOSGJqMm9yZk54S0w3NmNFQ3F6WHli?=
 =?utf-8?B?UmhKbjFNMXU3aFhVbVZ2T1ZKclQ4cnhid0t3Ym5MMXJlek9NUm1Ta1piMkZS?=
 =?utf-8?B?T1VtUlZlOW04L0ZUWGd6MEpSa2dpNTI2U0RrR0JuR2EwczlubHh3d0pQa3FD?=
 =?utf-8?B?RWxsellON3VONjdCNzFRRjdMcUFNbWhWSS9UQUxBaTFqSjR1R2xHWmlzKzlK?=
 =?utf-8?B?aVRqV0w3alZPY0FMaDI5NU9lcmRyQjJiWnVkTGloVFdIV3R6bnFUWVAvWU4y?=
 =?utf-8?B?S0p4K3Z5YnZFN09BMU1pWU0wL0xoMStpTkFySGZYL3FvSzJCKzlBZytjbGtP?=
 =?utf-8?B?RDdmbS9nSitxUTZzYjRQUEczblRZc2NOTGY1ZHBCdGVoODZLS09URm1BVmYy?=
 =?utf-8?B?TjBPb3hKcTdPY1FvM3dNei9WczJuR0FCK2lIQW5qaFQyMnBhTkRpdjlqcUNn?=
 =?utf-8?B?RmxCTmR5UXgwWDNlSjdFV2FVL2doL01zNmJIZmxZVFlVYzc5MjhnVVFGYjZp?=
 =?utf-8?B?emN6cVNkZUhGanN5TFI2ZTVmQ1JQV0xaN2NQMlJUN0h3S1lNSUJkMEs5NVk1?=
 =?utf-8?B?VXdHd0dPVFlFUmNZa1pSV2d1MWcxdUF5Q2JUVzg3QVZzR29hZm9xRG40TlNJ?=
 =?utf-8?B?YjQzRUhCY2dmdTByOWJiWXFrb0l0NkU0UFdKZ05IZnhGdUU0VjZCWTRTZWQ4?=
 =?utf-8?B?WVNyYU16TWVabGVqZnBFZjFWR1R2ZjNPaThyeFRieWNBWnRpVVI4dkkyeGFl?=
 =?utf-8?B?Z1RPdm1TS2dZTDJONXVhUlBiOXMyM1poditGMHFFR0JMTHRNYkVHR1g1U2hw?=
 =?utf-8?B?MlJSSWJYc0hEV1U2OGxPL2VqOVlKLzdtdU9aSUxoZW5LYW04dmh6c1hhYlds?=
 =?utf-8?B?b28vVHNVbXp6a3BvYmlQYzlxdVBQZXFPdkpzVGdXRERvWTJ6QjFLWnlJQ0x2?=
 =?utf-8?B?MTIxOEZaNVo5NkFmME9oWVkvYWdtckFRRkgyL0hKa28vak1MRWMwWkxnRHd2?=
 =?utf-8?B?ZzcvdmlaZDI3QThZY084TURUQkNVbXRjSzY2ckFQM25RQk13MGtJRHo2SVl2?=
 =?utf-8?Q?xLaG72d4IbN5lZueHeTBQUg14XGrlLRZHXnQu+i?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7f56697d-1063-4dd0-bea7-08d984caf27a
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Oct 2021 11:02:23.8735
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: NW++IzWQvWTvIHmjqZh8Mi4kLyPPqbZwUcD5U6h0QZdQqHrSJGnqUl1QDR3Mslwh0e1ziGUVRLST1Vlxri97bg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB3295

On 30.09.2021 16:28, Luca Fancellu wrote:
> --- a/xen/common/efi/boot.c
> +++ b/xen/common/efi/boot.c
> @@ -1127,15 +1127,17 @@ efi_start(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE *SystemTable)
>      static EFI_GUID __initdata shim_lock_guid = SHIM_LOCK_PROTOCOL_GUID;
>      EFI_LOADED_IMAGE *loaded_image;
>      EFI_STATUS status;
> -    unsigned int i, argc;
> -    CHAR16 **argv, *file_name, *cfg_file_name = NULL, *options = NULL;
> +    unsigned int i, argc = 0;
> +    CHAR16 **argv, *file_name = NULL, *cfg_file_name = NULL, *options = NULL;

Are these two changes really still needed?

> @@ -1285,14 +1286,13 @@ efi_start(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE *SystemTable)
>              efi_bs->FreePool(name.w);
>          }
>  
> -        if ( !name.s )
> -            blexit(L"No Dom0 kernel image specified.");
> -
>          efi_arch_cfg_file_early(loaded_image, dir_handle, section.s);
>  
> -        option_str = split_string(name.s);
> +        if ( name.s )
> +            option_str = split_string(name.s);

        option_str = name.s ? split_string(name.s) : NULL;

would be the less intrusive change (eliminating the need to add an
initialized for option_str). Or if you really want to stick to your
model, then please at the same time at least move option_str into
the more narrow scope.

> @@ -1361,12 +1361,30 @@ efi_start(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE *SystemTable)
>          efi_bs->FreePages(cfg.addr, PFN_UP(cfg.size));
>          cfg.addr = 0;
>  
> -        dir_handle->Close(dir_handle);
> -
>          if ( gop && !base_video )
>              gop_mode = efi_find_gop_mode(gop, cols, rows, depth);
>      }
>  
> +#ifdef CONFIG_HAS_DEVICE_TREE
> +    /* Get the number of boot modules specified on the DT or an error (<0) */
> +    dt_modules_found = efi_arch_check_dt_boot(dir_handle);
> +#endif

So I had asked to add a stub enclosed in such an #ifdef, to avoid the
#ifdef here. I may be willing to let you keep things as you have them
now, but I'd like to understand why you've picked that different
approach despite the prior discussion.

> +    dir_handle->Close(dir_handle);
> +
> +    if ( dt_modules_found < 0 )
> +        /* efi_arch_check_dt_boot throws some error */
> +        blexit(L"Error processing boot modules on DT.");
> +
> +    /*
> +     * Check if a proper configuration is provided to start Xen:
> +     *  - Dom0 specified (minimum required)
> +     *  - Dom0 and DomU(s) specified
> +     *  - DomU(s) specified
> +     */

May I suggest to shorten the three bullet points to "At least one
of Dom0 or DomU(s) specified"?

> +    if ( !dt_modules_found && !kernel.addr )
> +        blexit(L"No Dom0 kernel image specified.");

And may I also ask to alter the text here, to be less confusing to
dom0less folks? E.g. "No initial domain kernel specified"?

Jan



From xen-devel-bounces@lists.xenproject.org Fri Oct 01 11:16:57 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Oct 2021 11:16:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.200547.355054 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mWGX6-00089m-4U; Fri, 01 Oct 2021 11:16:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 200547.355054; Fri, 01 Oct 2021 11:16:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mWGX6-00089f-1c; Fri, 01 Oct 2021 11:16:52 +0000
Received: by outflank-mailman (input) for mailman id 200547;
 Fri, 01 Oct 2021 11:16:51 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=KCT2=OV=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mWGX5-00089Z-6v
 for xen-devel@lists.xenproject.org; Fri, 01 Oct 2021 11:16:51 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id d34dc883-5416-4f8f-b109-c8a407262826;
 Fri, 01 Oct 2021 11:16:50 +0000 (UTC)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2054.outbound.protection.outlook.com [104.47.12.54]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-22-__Wb4LEvMXas0AfxZJ6qFQ-1; Fri, 01 Oct 2021 13:16:48 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB6302.eurprd04.prod.outlook.com (2603:10a6:803:102::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.15; Fri, 1 Oct
 2021 11:16:45 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4566.014; Fri, 1 Oct 2021
 11:16:45 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS8PR04CA0075.eurprd04.prod.outlook.com (2603:10a6:20b:313::20) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.16 via Frontend
 Transport; Fri, 1 Oct 2021 11:16:44 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d34dc883-5416-4f8f-b109-c8a407262826
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1633087009;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=J88066DRHprCmPmq6onKz4kV4U88D+q7ClEowJcpkBE=;
	b=NyCj3oLtDLsLFqkpO+RL6siACGtd55vI3XJXyVLV5VxKrrPWII/KjOaaJLKrvdc94j/1uq
	uzudj5lsSL3uxEI4vSNOvX3sdQWZN6jkykAwZ+XQwmQMAwFIB+hVKBe7SuwMDcqyZaqfoB
	7mNCITYzsO6VK5pyR8w03WUay1l22sk=
X-MC-Unique: __Wb4LEvMXas0AfxZJ6qFQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=CZ6Xc+3cAW+y9BcO1XxCesIq6alphxZZYh5aQNppn1It/yMtY+jpyWYnohdOXXhbr4YzLQPDmrsRD53qyKBHxmzbSWYSX4eiqlmTbJleWsjHBfyH5aQ7TbIfm8eO7VBYTLpaVyPedHrwAXAYQ45LrgTznXSWX8sRfiEBhZnpU++rtAor0Sy0aEiVQwYgtupUE9g9CRaf74UWo75D1FUBtVxQVg+vQx75/5eiUT82by1p5oFNMSn7gV16P39n4rzYREaBnSsBrlp50mm3fm/vH5GOHoAF7MrBpjekLRackYqlCWCY3gcxGWOqsqiysc2IL/WzhkwqBNnzd9nIBkNI7g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=J88066DRHprCmPmq6onKz4kV4U88D+q7ClEowJcpkBE=;
 b=ibZ1cS0rPTm5lJ+XpNu5am2qvMLA4l+ArOdyo4g2AQnzDWZfLqHmF54HnQlJ1bu49eA2NKObUream1nYKg1q89w+T6bU10z7u0sHIW1cdreOT62oGYwWtK/8cStbS5gvC2lrROSUN3lZwZqqughyBA2jnoHTpafLdzou+WAqgQiley4N5PDu4JeyhFI+JwW3wJxPEWM9vMb3J4cPpnx0PpVwlUNGk+ZDq0p8gKDmZh8ukoVGI/JLLHhcBDY4fGd0iPkdThSTteK1mD1mDXPdYTgf1n6awTUrWO3OzZRN5rjw0wI1XrhW9fIgjYoYVTt0aY3Ii7XFd7ItAn9W+QmzzQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [PATCH v4 3/3] arm/efi: load dom0 modules from DT using UEFI
To: Luca Fancellu <luca.fancellu@arm.com>
Cc: bertrand.marquis@arm.com, wei.chen@arm.com,
 Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Wei Liu <wl@xen.org>, xen-devel@lists.xenproject.org
References: <20210930142846.13348-1-luca.fancellu@arm.com>
 <20210930142846.13348-4-luca.fancellu@arm.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <21f9af33-0d09-fb2e-95fa-f4c5796671ca@suse.com>
Date: Fri, 1 Oct 2021 13:16:43 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <20210930142846.13348-4-luca.fancellu@arm.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8PR04CA0075.eurprd04.prod.outlook.com
 (2603:10a6:20b:313::20) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 93b0ec75-1e51-44ad-4494-08d984ccf44a
X-MS-TrafficTypeDiagnostic: VI1PR04MB6302:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB63020A329FD268E214881530B3AB9@VI1PR04MB6302.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	UXqgg+Cng6Bdge1llfzpeDBXm+HZJJv/bnjbEkI7b3PfO7dl1h67CojSK2mXwxVZE8KD8ayKDCewC8s3H4YvAnQdwkVPqkzNjQ5CdQ51rdXdeCR7Oao0JKv2aloX5BlXm7BwXws2bjZOLIuDHpDeiGWOgO9C66npIJhHao3Ux/MbedYw98Ds4qsgbIWWR5skFnpoUucAEjlzoFA5q11RhxkkZZuwGQhVMzYi9FzB/u8KiXCMV+NX8UE9ilIcW1KdkYnQLqZUZL2nMWqDGyS64pYxMv2yF17HClXnuCzNB0abGZIghhpEAc6AYASBJW9fkrctTDsZD9s851EWVZbvQDCRLtGeTFqX5rAk6jx8Xjie5zhjZGZHNCeLA5vUvOmfW8qF8PUSogzIVl2emGj2hMh+hzvW6jQwNOCmwO/Us+x5cYHaE58wdXEXgUYEKZHYjPz4ObmB586Ox3yWkAlmBjJmaQJGa/D71tdDpec89X7+jLj1lQoV7jft8fmCnxVVrAHk1CMATkfL9Srmph+Skl391Q4TSjnFNgpTI8MI2PA8c5Er/IVj+3jDX14topDfhPhUer5Z1C9wzTFD/E9Nt5DDSLFjxGf5XTeUNjXDv5+a9IT/CYCT924kIf/CSY8/TIly5e9hVRKr4/twEdZ3TIipU9nvnaJwzapKMsDiO+pW8oJDt3Pcfk6rTskTVnt1vVDGj4sw4Hi1kblXBGITk55uTrhliOXhKz8LlSMa9mzG2eObcTTjzwvjt3hMI+Wn
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(5660300002)(508600001)(4326008)(2616005)(83380400001)(7416002)(26005)(6486002)(31696002)(53546011)(8936002)(956004)(38100700002)(8676002)(54906003)(36756003)(16576012)(6916009)(31686004)(316002)(186003)(66946007)(66476007)(2906002)(66556008)(86362001)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?b0ZBUVJESHNMQkpaRXZoYys1cHcvVEpUQUVKdmZuQ3J6Rk9HZmF5SUhVNGlL?=
 =?utf-8?B?bGY1bHVvemhYamJQQ1VkNTlvSlNpQ0Q4SGFRRmJzMTh2NE9pR3N0UHQvdFdL?=
 =?utf-8?B?bnZrdEh3cE52NzVNY1p3VEc4U2dYU3Y3a0M2eDF1bzFYYTlYNWxBOHh1ZVpT?=
 =?utf-8?B?MmJEcWcvUDJKd1FkZE5aeEI4alBUYUI0K0k2REMxK0xDWkVra2FLTGJKZ3NS?=
 =?utf-8?B?b1VZZmExYjFNNm5uMHBWRStiMk92eFRiUFBFU2ZKV0tiS1p1YjRmd1JBSEtS?=
 =?utf-8?B?Y1RjWk5TQXJPMXNGbzhTbEhqbXB0Z05Kc0dXVWx6NjVaT0J1d21TUTJBT0ZC?=
 =?utf-8?B?dWQ5NVVZMVVqZ3dkT0VSK2pJWkpwRFJrOUNRQ2Y5K2QxdjBPanNNM1V0a3hm?=
 =?utf-8?B?KzZBOUZySzAzRFhmbk9FWGJjVEhHZndMbHhlaHQ1L2lvTDZZV0RIdzhyMnJV?=
 =?utf-8?B?VlZJT0RXancvQi8yWlBOYzkzV3JxZ0NRakVRamdGOGdHamgrbnZQVUxQTk5B?=
 =?utf-8?B?Z3BVSU9xUVAxVUJEWU5ZUjJVY1FJQmhIRlhtTFFwaVhBSXI0T0JRekRRc2gw?=
 =?utf-8?B?dXkvVTVNV1FjTTUrSlZaNGpaOTkvRW1WWmhEbm5ISEkyWEloZWxVMkdkZDAy?=
 =?utf-8?B?aklmNVN2MUwwYlBNdU1TV2ZmaGhlSUcrVHRhcmJpZHRJbWxhSC9hcThmVHRE?=
 =?utf-8?B?SW5DUlZkWFArYnprZFBUay9wcWw0QlBvdVo5ejJLQVc3V3lYbHcvN2thSmgr?=
 =?utf-8?B?TnE1dFJCZ1lqMnJqOE5BazlqSDRBa1RaU3hBendzcXlQeUtxK0Q2TkFPTDZl?=
 =?utf-8?B?NFhFZE4wTVlaNS9RbWNYV1NIN1EySU1BMkVjZVgyc1lTV1ZLS2d3QU5TY2Vl?=
 =?utf-8?B?ejQrUDdFZm0zUVZCMHYxZFUrbDUreFRLa0MvRnlOb2dCVXF1dEFrNE9EZUlK?=
 =?utf-8?B?L0lzT1FJakhDK3k4cldrVHdzVXliOUt4TEwzdzBTN095TW50aXFraHY1M3Nh?=
 =?utf-8?B?WGhLYm84NlhFcitmTXRFTG9zbEQwT2s1aERHbk9zYnBqWFpLL1FMZUFBTkho?=
 =?utf-8?B?cTBVQml6RVhVbVIwZHJHZjZOYWpvcWVDSEkrVkpGa2Z1QzBxenZzcjNWZ3A2?=
 =?utf-8?B?R0VpYWZSY2xScElBbUcyeSt4SE9Sb1R1Y0xSbUQ4SnF1N3JYQzdCQkJQZFRq?=
 =?utf-8?B?TVNSemFNT2dZVVYwNWozU3h4KzBUVXFxZnprUmpxbUh3cFB4OEV6T0JSbUVZ?=
 =?utf-8?B?Ty84RllsZjRyM0Vvd3lORU1iNnJ6STgvV2huS05WVFNMRm5rVUJxcWdvSXRY?=
 =?utf-8?B?Ui9LN2RtNHNOOTZ5bDcrczkvNmpONHFaYlhJQ1hPTVl3MmpkRlVuaWpjRFI2?=
 =?utf-8?B?THgxb3RneS9uK2hkZFdaOXBHNVVRcVY1OTA4S1Iyalg1cjllK0dQaTRlTS9T?=
 =?utf-8?B?OTBaMi9iMEI3YmVYSHpsMStYeHRZL0Z3RklEeUxjakVIa1ZnQ1pvd3pRRTRF?=
 =?utf-8?B?R0VaR2NMbmkxWkM1TUMzSzdlTnlnZlhQbldjRVR0b2l5N2dhNkY5SFpka3ls?=
 =?utf-8?B?YjU0WTNRY1hUZktBR0pPMmhDMWpaS2pORGNYVXJmbVhtbGdoRUpTaVhVdXhr?=
 =?utf-8?B?bGtGNmVTRkR5Sk13RnE5NnhHejNNbG5aRlFva2QyYjEwamZlVWZ3cW5LYWtH?=
 =?utf-8?B?N1lCL0FUZ1p6MHV6KzNiZ1pPblo1bGpYU3RZbEtzbFdjWnhlQzd0R2ZoeGVx?=
 =?utf-8?Q?d0vUvyMUmFXJvyrHuN0mmBeCT50Qx2MeIczNMTc?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 93b0ec75-1e51-44ad-4494-08d984ccf44a
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Oct 2021 11:16:45.7358
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ROEmxfHHRy61gZSZj0LPHyHV6nBtKb8liQW5URAUIeJwxjmO5Qr3Fxb4xxsBwJMf4WPSD9HdiDSQf3FTGDDZHw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6302

On 30.09.2021 16:28, Luca Fancellu wrote:
> Add support to load Dom0 boot modules from
> the device tree using the xen,uefi-binary property.
> 
> Update documentation about that.
> 
> Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>

Acked-by: Jan Beulich <jbeulich@suse.com>
despite ...

> @@ -1385,6 +1380,17 @@ efi_start(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE *SystemTable)
>      if ( !dt_modules_found && !kernel.addr )
>          blexit(L"No Dom0 kernel image specified.");
>  
> +    /*
> +     * The Dom0 kernel can be loaded from the configuration file or by the
> +     * device tree through the efi_arch_check_dt_boot function, in this stage
> +     * verify it.
> +     */
> +    if ( kernel.addr &&

... me still being a little unhappy with the inconsistent use of the
union fields so close together: This one is now consistent with the
one visible further up in context, but ...

> +         !EFI_ERROR(efi_bs->LocateProtocol(&shim_lock_guid, NULL,> +                                           (void **)&shim_lock)) &&
> +         (status = shim_lock->Verify(kernel.ptr, kernel.size)) != EFI_SUCCESS )

... is now inconsistent with this use. But yeah - read_file() is
even worse in that sense, except that there the different uses are
for specific reasons, while here the only requirement is to satisfy
shim_lock->Verify().

Please feel free to retain my ack in case you decide to use .ptr in
all three places.

Jan



From xen-devel-bounces@lists.xenproject.org Fri Oct 01 11:22:59 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Oct 2021 11:22:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.200553.355066 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mWGcx-0001Eg-RI; Fri, 01 Oct 2021 11:22:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 200553.355066; Fri, 01 Oct 2021 11:22:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mWGcx-0001EZ-NE; Fri, 01 Oct 2021 11:22:55 +0000
Received: by outflank-mailman (input) for mailman id 200553;
 Fri, 01 Oct 2021 11:22:54 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=p9Zs=OV=xen.org=tim@srs-us1.protection.inumbo.net>)
 id 1mWGcw-0001ET-Kk
 for xen-devel@lists.xenproject.org; Fri, 01 Oct 2021 11:22:54 +0000
Received: from deinos.phlegethon.org (unknown [2001:41d0:8:b1d7::1])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 2ee288be-ef50-430a-85ba-7a17e9aa2ae8;
 Fri, 01 Oct 2021 11:22:53 +0000 (UTC)
Received: from tjd by deinos.phlegethon.org with local (Exim 4.94.2 (FreeBSD))
 (envelope-from <tim@xen.org>)
 id 1mWGcu-0009Cq-7O; Fri, 01 Oct 2021 11:22:52 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2ee288be-ef50-430a-85ba-7a17e9aa2ae8
Date: Fri, 1 Oct 2021 12:22:52 +0100
From: Tim Deegan <tim@xen.org>
To: Jan Beulich <jbeulich@suse.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: sh_unshadow_for_p2m_change() vs p2m_set_entry()
Message-ID: <YVbvjKU/m8FZtRPX@deinos.phlegethon.org>
References: <ae8b6cf1-d1ae-8a55-7b88-7ef24db0c554@suse.com>
 <YVIo1sR283L/MUeN@deinos.phlegethon.org>
 <59b46317-e0ce-afcb-55d0-90379c4600e1@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <59b46317-e0ce-afcb-55d0-90379c4600e1@suse.com>
X-SA-Known-Good: Yes
X-SA-Exim-Connect-IP: <locally generated>
X-SA-Exim-Mail-From: tim@xen.org
X-SA-Exim-Scanned: No (on deinos.phlegethon.org); SAEximRunCond expanded to false

At 07:59 +0200 on 01 Oct (1633075173), Jan Beulich wrote:
> On 27.09.2021 22:25, Tim Deegan wrote:
> > At 13:31 +0200 on 24 Sep (1632490304), Jan Beulich wrote:
> >> The 2M logic also first checks _PAGE_PRESENT (and _PAGE_PSE), while
> >> the 4k logic appears to infer that the old page was present from
> >> p2m_is_{valid,grant}().
> > 
> > I think the p2m_type check is the right one (rather than
> > _PAGE_PRESENT), since that's the one that the p2m lookups will obey
> > when causing things to get shadowed.  But the extra _PAGE_PSE check
> > should stay.
> 
> Actually, having transformed things into patch form, I'm now puzzled
> by you explicitly saying this. Wasn't this check wrong in the first
> place? I don't see anything preventing an L1 page table getting
> zapped (or replaced by a 2M mapping) all in one go.

ISTR that this couldn't happen, but I don't remember exactly exactly
why.  It may just be that the p2m update code didn't have that path,
but it's a bit fragile to rely on that.

> The full range
> of GFNs would need checking in this case as well, just like in the
> opposite case (2M mapping getting replaced by an L1 pt).

Yes.  Any case where we're inserting or removing an L1 table would
need to check all 512 L1Es.

Cheers,

Tim.


From xen-devel-bounces@lists.xenproject.org Fri Oct 01 11:36:50 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Oct 2021 11:36:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.200561.355076 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mWGqJ-0002pX-0I; Fri, 01 Oct 2021 11:36:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 200561.355076; Fri, 01 Oct 2021 11:36:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mWGqI-0002pQ-Th; Fri, 01 Oct 2021 11:36:42 +0000
Received: by outflank-mailman (input) for mailman id 200561;
 Fri, 01 Oct 2021 11:36:41 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=wBg0=OV=citrix.com=anthony.perard@srs-us1.protection.inumbo.net>)
 id 1mWGqH-0002pK-7I
 for xen-devel@lists.xenproject.org; Fri, 01 Oct 2021 11:36:41 +0000
Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 21035c22-fb66-4b0b-8e4f-1b0fe8f4d506;
 Fri, 01 Oct 2021 11:36:39 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 21035c22-fb66-4b0b-8e4f-1b0fe8f4d506
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1633088199;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=26LQk5eAfzqIVg+MS7ERysMyqBCQ9TCP6tfHR15Yj28=;
  b=MP0obStfKq8H1AyDu/R4SjsrzOwoF/4hMX5VPLpLAq9f2unyT+xSR6I3
   aicZ9Juc6ngZtzKixXDHOOKhokZQQXhREVDxM50cK4FBV9C8+VLrrOOir
   UXem+G28bL/zAt8uabW+dXzwqclEjgCLO7ULX0WjG7mwIcpF5azW9mfen
   I=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: +50nVW9FiLNllIiudHsg9bxE2UEAxWZ30B09aScdgmk7ByzklQrj6vnRB/24Wzat64PnP5ZhwH
 JOZitmVbwNcPTRsao4djVwaMYWrZGp1i/zPyYinkMJEpt1kIbQaVAi0c2+qCgEQHmC5lJ9WdsV
 Aw763X11BAVobbS2zA5JoVWGMs1scYCRBeMWivZUkG+REVQvqG32lFCrZBvHrjMPdEcEm8hfsN
 ceN9f9mYm1KvNUSC1LbgmhHfdoGgK+XnCQ5WrrXAwyvTl9BDWMtJoZ2LSXtPHH6DuAlcWAf2s1
 O+li8fkWPX0/HWHludtNeudt
X-SBRS: 5.1
X-MesageID: 54131767
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:US57Y6/xiDlTIj9HVq9gDrUDY3mTJUtcMsCJ2f8bNWPcYEJGY0x3n
 2EYXjyOaKuPNGf0L4p+b9u2/B8D6sfXydJnSgpq+Xw8E34SpcT7XtnIdU2Y0wF+jyHgoOCLy
 +1EN7Es+ehtFie0Si9AttENlFEkvU2ybuOU5NXsZ2YhGGeIdA970Ug6wrZh29Yy6TSEK1jlV
 e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH
 I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPhD0
 f9XkaygTD0JI/zho8QYFBYHFntxaPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us
 6ZCcXZUM07F17neLLGTE4GAguwqKtXrO4UO/Glt1zjDAd4tQIzZQrWM7thdtNs1rp0SRK2HO
 JRGAdZpRAzOPwVPAHcHM58zvsinukahaQR8hU3A8MLb5ECMlVcsgdABKuH9e8OIbdVYmF6Co
 WDL9Hi/BQsVXPSAzRKV/3TqgfXA9Qv6Q4sTF7y+s/JvgUGJ10QCARsaWEv9u+TRol6zXZdTJ
 lIZ/gIqrLMu7wq7Q9/lRRq6rXWY+BkGVLJt//YSsV/XjPCOukDAWzZCHmUphMEaWNEedyUAz
 Hu5j9bTJSE+nYa1TDWSqbLOombnUcQKFlMqaSgBRAoDxtDspoAvkx7CJupe/L6JYs7dQ2+pn
 GHTxMQqr/BD1ZdUi/XTEUXv2WrEm3TfcuIiCuw7tEqL6RllLKqseoCl81TS6fsowG2xFQLa5
 ClsdyRz9okz4XCxeM6lHLhl8FKBva/t3NjgbbhHRMVJG9OFoSDLQGyoyGsiTHqFy+5dEdMTX
 GfduBlK+LhYN2awYKl8buqZUppxlvC6So+7D62EP7Kih6SdkifcoEmCgmbKgQjQfLUEy/lja
 f93j+72ZZrlNUiX5GXvHLpMuVPa7is/2XnSVfjGI+ePitKjiIquYe5dajOmN7lhhIvd+Vm92
 4sPZqOilkQEOMWjM3a/zGLmBQ1TRZTNLcut8JI/my/qClcOJVzN/NeLmu5+J9w5wf4F/goKl
 1nkMnJlJJPErSWvAW23hrpLMtsDhL5z8iA2OzICJ1Gt1yRxaIqj9v5HJZA2YaMm5KpoyvstF
 6sJfMCJA/JuTDXb+mtCMcmh/dI6LBn71xiTOyeFYSQke8IyTQL+5dK5LBDk8zMDD3TruJJm8
 aGgzA7SXbEKWx9mUJTNcPuqwl7o5Sodlet+UlHmON5WfEmwooFmJzao1q08It0WKAWFzTyfj
 l7EDRAdrOjLgok07NiW2vzU89b3S7NzRxMIEXPa4LC6MTjh0lCimYIQAvyVeT39VX/v/Pnwb
 +ti0PyhYuYMm0xHstQgHu8zn74+/dbmu5RT0h9gQCfQd12uB75tfiuG0M1IuvEfz7NVo1LrC
 EeG+90cMrSVIsL1VlUWIVN9POiE0PgVnBjU7Og0fxqmtHMmouLfXBUAJQSIhQxcMKBxYdEsz
 uoWscIL7xCy10gxOdGcgyEIr2mBIxTsiUn8Wk321GMztjcW9w==
IronPort-HdrOrdr: A9a23:thF7YaEJmUgnhwyGpLqE6MeALOsnbusQ8zAXP0AYc3Jom+ij5q
 STdZUgpHrJYVkqNU3I9ertBEDEewK6yXcX2/hyAV7BZmnbUQKTRekIh7cKgQeQeBEWntQts5
 uIGJIeNDSfNzdHsfo=
X-IronPort-AV: E=Sophos;i="5.85,337,1624334400"; 
   d="scan'208";a="54131767"
Date: Fri, 1 Oct 2021 12:36:16 +0100
From: Anthony PERARD <anthony.perard@citrix.com>
To: Dmitry Isaykin <isaikin-dmitry@yandex.ru>
CC: <xen-devel@lists.xenproject.org>, Ian Jackson <iwj@xenproject.org>, Wei
 Liu <wl@xen.org>
Subject: Re: [SUSPECTED SPAM][PATCH v4] tools/xl: fix autoballoon regex
Message-ID: <YVbysEUbylUZTY6E@perard>
References: <57f69075b77651c64b7dc6d86acd03fe03b4a18f.1632907890.git.isaikin-dmitry@yandex.ru>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <57f69075b77651c64b7dc6d86acd03fe03b4a18f.1632907890.git.isaikin-dmitry@yandex.ru>

On Wed, Sep 29, 2021 at 03:44:33PM +0300, Dmitry Isaykin wrote:
> This regex is used for auto-balloon mode detection based on Xen command line.
> 
> The case of specifying a negative size was handled incorrectly.
> From misc/xen-command-line documentation:
> 
>     dom0_mem (x86)
>     = List of ( min:<sz> | max:<sz> | <sz> )
> 
>     If a size is positive, it represents an absolute value.
>     If a size is negative, it is subtracted from the total available memory.
> 
> Also add support for [tT] granularity suffix.
> Also add support for memory fractions (i.e. '50%' or '1G+25%').
> 
> Signed-off-by: Dmitry Isaykin <isaikin-dmitry@yandex.ru>
> ---

> +#define SIZE_PATTERN "-?[0-9]+[bBkKmMgGtT]?"
> +
>      ret = regcomp(&regex,
> -                  "(^| )dom0_mem=((|min:|max:)[0-9]+[bBkKmMgG]?,?)+($| )",
> +                  "(^| )dom0_mem=((|min:|max:)(" SIZE_PATTERN "|(" SIZE_PATTERN "\\+)?[0-9]{1,2}%),?)+($| )",
>                    REG_NOSUB | REG_EXTENDED);

Reviewed-by: Anthony PERARD <anthony.perard@citrix.com>

Thanks,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Fri Oct 01 11:37:21 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Oct 2021 11:37:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.200568.355087 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mWGqv-0003Uc-9Q; Fri, 01 Oct 2021 11:37:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 200568.355087; Fri, 01 Oct 2021 11:37:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mWGqv-0003UV-6M; Fri, 01 Oct 2021 11:37:21 +0000
Received: by outflank-mailman (input) for mailman id 200568;
 Fri, 01 Oct 2021 11:37:20 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=KCT2=OV=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mWGqu-0003Sx-0Z
 for xen-devel@lists.xenproject.org; Fri, 01 Oct 2021 11:37:20 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id e2c7f694-27c8-406b-a1cd-866dd8bd2377;
 Fri, 01 Oct 2021 11:37:15 +0000 (UTC)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2174.outbound.protection.outlook.com [104.47.17.174])
 (Using TLS) by relay.mimecast.com with ESMTP id
 de-mta-25-Q0aPpbM0NW2zoeqh9t7IJA-1; Fri, 01 Oct 2021 13:37:13 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0402MB3389.eurprd04.prod.outlook.com (2603:10a6:803:b::27)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.15; Fri, 1 Oct
 2021 11:37:12 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4566.014; Fri, 1 Oct 2021
 11:37:12 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS8PR04CA0100.eurprd04.prod.outlook.com (2603:10a6:20b:31e::15) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.16 via Frontend
 Transport; Fri, 1 Oct 2021 11:37:12 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e2c7f694-27c8-406b-a1cd-866dd8bd2377
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1633088234;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=COHAO2ioaNtZiSiI2FN60iFBiB2A1fK4DC2JbR5HJUI=;
	b=mnQlXSGVnJqmGPdBcLRX1j/lBKda0fckbNA5YWaHQa65P01z1usWqH9rCkJZXBPDFS8rTb
	aDgyIlWVmwqfUd+aHhUrPNL9y8zzc2nQ/s7JFww4vHk+7UksMKRRnFS3yTO3lmRfyUSqbz
	+TJGlqEMIz0llJvN23rYBMQPHEHuT3A=
X-MC-Unique: Q0aPpbM0NW2zoeqh9t7IJA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=SwZFwwcav57pb8g3x+UgIXOPOLGtjJxTodXIk44S4jYn9lLxe14D+lzVesOY8LjnQOdSs73Zha3fblASlEZj1XU3srvkmsByNrqyVkJ2oSVoe33m/rrDvdCGXptGIpOCItdKFu1lHP/t+tznfMzTZksyqX1aBbZ3Nj5pbBsdj1cb4cCT+RIslyOjexV6nr41xYtJNZpHxci3jnzY6YCY5jyd285OOlImjCwoqpxzE9Vrq9DiVsJiPsfvBRTIbwRtnDt22piS/K3n/XT9OofC3GlxAHKQkIQNe2SABXnv/s120Zpqv7aAfuqAefpObIfq/Xu3GZnIM39mZI6tPUp9Gw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=COHAO2ioaNtZiSiI2FN60iFBiB2A1fK4DC2JbR5HJUI=;
 b=L/airL83yfv7ZKlwyiX3SqpHOyfVtvqQNA1sd5zxRNlDSYWidhWxqnGBiwsRjXE9otNxggzO3z/Dp3cL1BhWPho7NFderNuC5vZqMGlCFhPCM9ZiJyZ6qERfdmx4ueq/kkSrYi8cEEpTk5dJu5hu7v1HimmNJ+ncVTtv694zLnnaPu4syAymY3muqVp8h/wvrrtsFNzf6q8De07P//zwdY168Vn/BaoMHxLu/D9doKN7+u1Cvu/NNy7AhpvubajMBFLPcza7xJ2b1xjA26SB4rSi9oRPMfLOjgdjNvzdEuH2K5iSyzvIW9z03csX+gFB41KYd6up7TzkH7siARMb0Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: sh_unshadow_for_p2m_change() vs p2m_set_entry()
To: Tim Deegan <tim@xen.org>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <ae8b6cf1-d1ae-8a55-7b88-7ef24db0c554@suse.com>
 <YVIo1sR283L/MUeN@deinos.phlegethon.org>
 <59b46317-e0ce-afcb-55d0-90379c4600e1@suse.com>
 <YVbvjKU/m8FZtRPX@deinos.phlegethon.org>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <2b89654d-702b-d335-43fb-8cd1b02a94aa@suse.com>
Date: Fri, 1 Oct 2021 13:37:10 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <YVbvjKU/m8FZtRPX@deinos.phlegethon.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8PR04CA0100.eurprd04.prod.outlook.com
 (2603:10a6:20b:31e::15) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 60b98803-d5c0-4a5b-0236-08d984cfcf64
X-MS-TrafficTypeDiagnostic: VI1PR0402MB3389:
X-Microsoft-Antispam-PRVS:
	<VI1PR0402MB3389E7ADA0371C0FFBC33CBCB3AB9@VI1PR0402MB3389.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:1468;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	RCZ7HAkhiguD74ryGOVZ0LV+twxGkdlBdRi+KWPSKRPyhwD/uFcs4ZB6PgX/XKZyRj6pIu6QiEcpW6JiMKOo+02AUBpnmVcWlBB4nFR9uwNjCoVaD61U9ZtwDZA7/K0tMe6bLV+7QIskmJpWwkn7iEg105S5j8qLeNWEUO08JRgVOMlFEDvZmEbYU6stzM8F1Q9AD2Wl6U+Bl0z3ILWbLJG+UFCMJv4WbFM6s3zeFUl9sgtUpNV7DOj3pP0YX7klWFsAyxu2xSljfogOfiqWufJyevZqCDtUUNRRrK+n3zRzOR83CmOeu9t+pLfKJpcbYE0qmM2nMeNld25r3KA6R2Xccx9kyAMj+3bTWY6GMCI/o3fwfGbHQ+ndmWyqx0q3YH1MWDTeTXug572HczgXFikLUu7Dxkh8//03tlAjlUIOfHFKz0ATbN6fnpxdqwsQImr/Q0QgLsCHir+1QlGpWd0LQW9psmRO/ADP/2BG0mSOUx1Wpx2raTMspg+n3jJI5fsipk6NLZP+dFxPItBAAKbBRPzfkGQ9kdnfeJ0dP52fI/CxXLQJECWp14PKahu74zEzuGo7p6tC7DeR+7Xlc+AoCnPHPNIXrrVaIEnCY2cfdIzxXQ+DYUstgz8tpjgS+YKSfNhUy63fntRFcRumjgGEvDHFliQMGCishMiTbKbAkRNGSiiON5HRf3g7RDXAqlAPRjJejOPqKzmnCg6nQmCDQzYGzBaB/gQx1OyKEB/WsgmBqV3Wkv5N4HUvMeoQ48r+saebnBi5XSd2tIG7tQ==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(4326008)(83380400001)(31696002)(6486002)(36756003)(53546011)(26005)(8676002)(8936002)(31686004)(186003)(66476007)(66556008)(956004)(5660300002)(2906002)(38100700002)(508600001)(6916009)(2616005)(86362001)(16576012)(66946007)(316002)(70780200001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?NW04M3VYeXkzblQ4a1RoVzJQdjhBdk12aE1TVVY2eFhUUTNRdWtBVnBvckpF?=
 =?utf-8?B?U2RqT3A1YWMvaWpCUi9ubE1rcms2ai9sWUNwdHpVeks4L051dCs2emZhWWY3?=
 =?utf-8?B?MTAyc0tLeWt4NDUvODZhai9XTklZbU5PN2VxRjZOMnBpeWNLdVhnRVBzbGhx?=
 =?utf-8?B?SWFGMGM1VldaTlhKeHFsR3I5NFh4cXhMYmcwcml5UEg1SW9PRTV1NW5oUG5u?=
 =?utf-8?B?TXBPNzJ1cE53blJ0VW9RM3o5RHBxc1RpMkNuQ1VVODFWR0FNMlBDeFVINlg2?=
 =?utf-8?B?c01BOWlhVUt3emRXTWtuR1RFRzhSVkRLa2Q1L3psRzhOWGJPL2xwS25YVExS?=
 =?utf-8?B?YURRV3JLWTJnN0tZRllSRitmdjZJaGs4blFjTDlTNEx2aFpOellOdE11SWRt?=
 =?utf-8?B?TkJaL0lEcVFnVHJ3d0Zsd2JYL0EzZjFZSW5JNmFaUDZlL0lOMnI1dnUvOHFn?=
 =?utf-8?B?T2ErVmhSKzh2ZlQyS215SlZESmtid3htYzdmVWFZWmNXYkF0NGtENjZGc2U3?=
 =?utf-8?B?MU4rY0hPSEVGWnFLa2hBclVWbWFlQjNRaVpQMFVBYmN1UUl4OFZCVkNSUWpC?=
 =?utf-8?B?MU9QU2t6UGgvMHB5RjFnZ0dXcWRSYUtEaC9zWFMzcVZVS1dGV3NVZXBTL3dX?=
 =?utf-8?B?emJuK2dXbkRvck5QYUN2SlhOM0lkVGdxcDFHeW1vMWNsMTBDanc5dE5BMjNX?=
 =?utf-8?B?WGNBbkRZVU54NlN5M245M0k4SGc5aEsyQ21FN1ErUUVYd1ZybFRqL2dDckdp?=
 =?utf-8?B?aDFiWGFDakgwUDZ2Ry8wWXh6bGxPV21YN0R3UlJveWE0czA4Yi9wMm01NDh3?=
 =?utf-8?B?NUlmdFNPQjRxemFIOFByUmJ0RkFGaEo0NmZQb1UrVVVQM3RlN2ZEQys0cUxH?=
 =?utf-8?B?bEpmcFFnemxSTFlwOXJwUWx1cWFjWHBid05IK2psT1grZUVqRjdoOWM1RHg3?=
 =?utf-8?B?TE1zekhPZ1VHcFk4MG8rZ1l1enQ1WnlpQWRJZW9wblZwUmdEaEk0RVJMUlVZ?=
 =?utf-8?B?VDVzNmpvWXQ0dWZIWE9aa2paWVRuTEdZTE1HMFlXejk4dEQrZkMrOTVmZ0U2?=
 =?utf-8?B?VDJIZ1MzNGZkZktSaXlTTHE1RXJDS1VCVmxpVzl6Z0NWK04xWlRIRXU4S09r?=
 =?utf-8?B?M2Y1amcvSWU2eHpNTjRxMENXdGdFS2E1MENTeSs3bXk3L2lncjVFQUpjZWI5?=
 =?utf-8?B?QVpRODJCc2hlbzNjVG5TbTgyckF6T3hxcXpGN1l6ZStlWUR4MXVDazJETUc3?=
 =?utf-8?B?UmJTbjFrUlpKOWorQk0vdXB5cHRHaXdFUGczSjcvbUgzUm94QkNXQU8rK3Ey?=
 =?utf-8?B?THpSTlhSSUdJdHJ3TnJmT1ZTOXlyVnUzc2svWnczMUkzSEY2dE1HUDFaVk0z?=
 =?utf-8?B?NW9Nc0hicC9vZHB5S2RYYTJaU0dWZVBwNjRKYkkwQ2R2bHJLa2psMDI5OFgz?=
 =?utf-8?B?YVVsVHlaaURJMWd6czN2dUhBQlVjUzBGK2FmeTBsS1FoOWg1eVdWYTNjTnly?=
 =?utf-8?B?cnJUSHhlNHpob0JnN1Vkc0FmeHR4Qm16ZW9CY3pUUWtYL3I1d3A1c1o3THpt?=
 =?utf-8?B?N1RiVWh0TWZzN0JtTkN4c0xWdkJTQjA3OFI2MFB3c2RUamxRejUrY3V4VlR6?=
 =?utf-8?B?Z1VVNmVhR1lDOTcvM3hxUFduS2l1cnZTZUZaRkhuWnI3dmtuanpwVVg5RmZu?=
 =?utf-8?B?Rmk1RHpweVU5ZWF0cmU3d1F4Ulk4ZWVwWXBHTlJqUVVjd3dObnFESzlEeGlk?=
 =?utf-8?Q?F7DsrAer4k1voSMEDvJpCR2lD29Xx14eCBkoN8i?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 60b98803-d5c0-4a5b-0236-08d984cfcf64
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Oct 2021 11:37:12.3199
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1TcWfrSHm0sBO+bjyytBSITdyyck2Sh9hoxeKOcaVlRKyazs53dWgsFTDktd2jI8vDerA2bRA2TvlPHL6YNoVg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3389

On 01.10.2021 13:22, Tim Deegan wrote:
> At 07:59 +0200 on 01 Oct (1633075173), Jan Beulich wrote:
>> On 27.09.2021 22:25, Tim Deegan wrote:
>>> At 13:31 +0200 on 24 Sep (1632490304), Jan Beulich wrote:
>>>> The 2M logic also first checks _PAGE_PRESENT (and _PAGE_PSE), while
>>>> the 4k logic appears to infer that the old page was present from
>>>> p2m_is_{valid,grant}().
>>>
>>> I think the p2m_type check is the right one (rather than
>>> _PAGE_PRESENT), since that's the one that the p2m lookups will obey
>>> when causing things to get shadowed.  But the extra _PAGE_PSE check
>>> should stay.
>>
>> Actually, having transformed things into patch form, I'm now puzzled
>> by you explicitly saying this. Wasn't this check wrong in the first
>> place? I don't see anything preventing an L1 page table getting
>> zapped (or replaced by a 2M mapping) all in one go.
> 
> ISTR that this couldn't happen, but I don't remember exactly exactly
> why.  It may just be that the p2m update code didn't have that path,
> but it's a bit fragile to rely on that.

I'm guessing that this is what the vague "potential errors when hap is
disabled" may have been referring to in that pretty old commit that I
had dug out.

Jan



From xen-devel-bounces@lists.xenproject.org Fri Oct 01 11:44:48 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Oct 2021 11:44:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.200579.355098 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mWGy2-00052o-54; Fri, 01 Oct 2021 11:44:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 200579.355098; Fri, 01 Oct 2021 11:44:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mWGy2-00052h-1x; Fri, 01 Oct 2021 11:44:42 +0000
Received: by outflank-mailman (input) for mailman id 200579;
 Fri, 01 Oct 2021 11:44:40 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=LRx5=OV=arm.com=Rahul.Singh@srs-us1.protection.inumbo.net>)
 id 1mWGy0-00052b-Oy
 for xen-devel@lists.xenproject.org; Fri, 01 Oct 2021 11:44:40 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com (unknown
 [40.107.6.80]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id f55a7af1-22ac-11ec-bd9d-12813bfff9fa;
 Fri, 01 Oct 2021 11:44:39 +0000 (UTC)
Received: from AM6PR08CA0017.eurprd08.prod.outlook.com (2603:10a6:20b:b2::29)
 by DBAPR08MB5574.eurprd08.prod.outlook.com (2603:10a6:10:1ab::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.13; Fri, 1 Oct
 2021 11:44:35 +0000
Received: from AM5EUR03FT039.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:b2:cafe::b5) by AM6PR08CA0017.outlook.office365.com
 (2603:10a6:20b:b2::29) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.14 via Frontend
 Transport; Fri, 1 Oct 2021 11:44:35 +0000
Received: from 64aa7808-outbound-2.mta.getcheckrecipient.com (63.33.187.114)
 by AM5EUR03FT039.mail.protection.outlook.com (10.152.17.185) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4566.14 via Frontend Transport; Fri, 1 Oct 2021 11:44:35 +0000
Received: ("Tessian outbound 0e48c0de19a3:v103");
 Fri, 01 Oct 2021 11:44:30 +0000
Received: from 4e00c071d7da.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 5840AD74-C597-428A-86EE-CDDCA7D11CF0.1; 
 Fri, 01 Oct 2021 11:44:19 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 4e00c071d7da.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 01 Oct 2021 11:44:19 +0000
Received: from AS8PR08MB6919.eurprd08.prod.outlook.com (2603:10a6:20b:39e::10)
 by AM6PR08MB3240.eurprd08.prod.outlook.com (2603:10a6:209:49::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.14; Fri, 1 Oct
 2021 11:44:17 +0000
Received: from AS8PR08MB6919.eurprd08.prod.outlook.com
 ([fe80::c8de:afad:1d5a:efd0]) by AS8PR08MB6919.eurprd08.prod.outlook.com
 ([fe80::c8de:afad:1d5a:efd0%7]) with mapi id 15.20.4544.022; Fri, 1 Oct 2021
 11:44:15 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f55a7af1-22ac-11ec-bd9d-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Ww3YhWzFzgwNJME0fXWreJsT0pyiJ/loE2Ammw1ruaw=;
 b=blRD9+ABtYjgjGfyfpdRDYLAzrWlRxCulxvrCuD+cxrEeNTuk5EeMJvfvS5mIuFxsKS9Zo1KtShf6HvMWvpw/H1GiAKIAbDJEOtyMQLXkJ4nCvJtTJyezCv0RrqD1m/rtc39fbjpqd/ecNF/UlqPWZr7fwzBkKFPgCqszApF6LI=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.33.187.114)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.33.187.114 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.33.187.114; helo=64aa7808-outbound-2.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: b744de02b018b1ed
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=bS8K3w79/GOdCftEwneko+uRNDapI7sxKAg3LzfNkhLgrqDkEiwCjnfEhaWjGCgLTSP9O//nWduh9aStU7fKN5KvesOKH5XahEg1JunQ5zMcnH3HK8MVrl5ap808z5kV+d4TA+YuyBB15ts5vmf6yr3S8rav1Juf1sW/H2gXkme/429ZNrMZr4M1Jp1wCUckR644o8Acgkn7PKn1i6UnYLS0zGA6Yz9G3ae/3Z6tu4BOZd1yDa+7AywsyxLOYtaKj2mrYKLH0/1bKox56MG+NqwK+uuEWSs+/QpE4rJLBx0Rloo2Zx1ybJk9TYrbLiWNTLWyy9wdqs4iLN73Aztp9A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Ww3YhWzFzgwNJME0fXWreJsT0pyiJ/loE2Ammw1ruaw=;
 b=LEopWJr5+2vzbgC2nN71ki/ZvCYUZdfr5FJRftmaHJ2uRXUC/29lwc6kvNgDzC+NxqfFY3a/YZHRMIfM9/85/QiXeS+i9D/dfze2+cHMNpvipMlT+Uqb0X1StEFLIYRTjNr80NiEg2SR9ZemIt3gzh8oggHl+dwQBafwaHjpAgD6O9rsJ+KDcDP1SsvdwBgSoMMQH2YvPPG7crMsrwDFgInmX5ZBit92nOE8dYMwxjtMHYPwbix3i2fxJsLs1PNPAsDExJF58YXqPwiR61PTxJx646PKmH+aP28xtueZbcO8zxDZqX9fJ1uO9z5qQUt3717rQ25IkKm0heOyKy85mg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Ww3YhWzFzgwNJME0fXWreJsT0pyiJ/loE2Ammw1ruaw=;
 b=blRD9+ABtYjgjGfyfpdRDYLAzrWlRxCulxvrCuD+cxrEeNTuk5EeMJvfvS5mIuFxsKS9Zo1KtShf6HvMWvpw/H1GiAKIAbDJEOtyMQLXkJ4nCvJtTJyezCv0RrqD1m/rtc39fbjpqd/ecNF/UlqPWZr7fwzBkKFPgCqszApF6LI=
From: Rahul Singh <Rahul.Singh@arm.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Bertrand Marquis <Bertrand.Marquis@arm.com>, Andre Przywara
	<Andre.Przywara@arm.com>, Stefano Stabellini <sstabellini@kernel.org>, Julien
 Grall <julien@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>, George Dunlap
	<george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>, Wei Liu
	<wl@xen.org>, =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>,
	Paul Durrant <paul@xen.org>, xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v3 14/17] xen/arm: Enable the existing x86 virtual PCI
 support for ARM.
Thread-Topic: [PATCH v3 14/17] xen/arm: Enable the existing x86 virtual PCI
 support for ARM.
Thread-Index: AQHXtJX8zP5xkk7akk+L97tLPArIN6u8s9KAgAFWUgA=
Date: Fri, 1 Oct 2021 11:44:15 +0000
Message-ID: <F537F4D7-A4D3-45D4-9A0C-AB573CAA724A@arm.com>
References: <cover.1632847120.git.rahul.singh@arm.com>
 <d7f62249e6aa7b33017ef707d6bc451b5e2c7047.1632847120.git.rahul.singh@arm.com>
 <491a49c0-d609-c122-f64a-999b16ef3a83@suse.com>
In-Reply-To: <491a49c0-d609-c122-f64a-999b16ef3a83@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
Authentication-Results-Original: suse.com; dkim=none (message not signed)
 header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: c8371f53-286e-4494-fe70-08d984d0d776
x-ms-traffictypediagnostic: AM6PR08MB3240:|DBAPR08MB5574:
x-ms-exchange-transport-forked: True
X-Microsoft-Antispam-PRVS:
	<DBAPR08MB5574111F35BC6E2D4C3A3F8CFCAB9@DBAPR08MB5574.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:10000;OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 ZtiPnpb1Nysi9OjwylNdfxV9UwC+diaLbGM7LJ9gO8u2SOUKQgHTT66bxMBiXqsmjx+bkiRUfYHm2BweYt1bI0WbKII+uynQabk8+zex3MDvuBfZw2ziF1auD9lOOIziLrxyqsOnVSUQw7xYjCRTdxk0iNq5nwm2cj/JMjXPqb+iHvR29mc7BhqLkQTwHhXnfFRi1LrBb6oXvZzvv74Fc3Md5G1Mw5LvjvspHJw5g2/TQCMfdMRpJAnbLoS+IOXaNQh2Y3sGDwk47CuFQFd/xJ6+JiZtzgtA+4AD9pDf+QwrKrN2uXN94a79OC6JxS+imgGFBK8IBfxU/6iI9lrYVXb3sH+TIysCrsX59/GOyXHBTRqtISxajq4oBgu81SKyArjPSoYcZYXEzY6Y3ro5zOUz36NEGXRB0JFQ4jRdfvrrI0tmxOmgdypYxdYH0MLqje1FRg7jnFp0XLF/B0+9P2iowqA9wf0rWM1Okw7rg4hF5S19hpD3dJ0PjlriSQqLA+nI1QRaXWJl0ZevHeNcXNt8Tg4uktQL1l6ZqfbC5VjB2c2SdkotF+2pj7f79rftOaChhe1SXK5FoQjRrOpK8wYmGm+ghs6Zz7eCzBaZn96lfoGXmLsU7ZpbBDeiAGmJECYd6bqoP2onSUh8v1MIcQxETmVFwDlHzu3NYOQrvp+EQnRNQ0BFv1wqrxrRmIaR1xRjhJEKMS4aH7MaYeZ9Jm8pzGLWzXm9BC5MBj0i1Ya6qfyQg1fqg4Hk8S0WMpJt
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6919.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(122000001)(2906002)(6512007)(6506007)(6486002)(53546011)(66946007)(26005)(8676002)(33656002)(36756003)(54906003)(38070700005)(6916009)(66556008)(66476007)(186003)(66446008)(64756008)(2616005)(4326008)(7416002)(71200400001)(76116006)(91956017)(38100700002)(8936002)(5660300002)(316002)(86362001)(508600001)(83380400001)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-ID: <126C29721BD71F438D187BF1D1CCDE59@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3240
Original-Authentication-Results: suse.com; dkim=none (message not signed)
 header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM5EUR03FT039.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	e6de3438-0147-410c-328e-08d984d0cb9b
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	HNaarUwf3xYb1GtpeHATDP5pcAzsjq91VIPJm2GYe7WaFuu9waprdbe7Enbr7hnzDnXPr3SZcrfo26yatroYAIf973BYlWZPGAtOysxWB1r9cCp9htNCsaIqhmaavsQxEM87AC0vugPkf9kveMx2Kqobv4EcRGgmqWwOjvEEru2pfVBODngyKRbFdTk+kyW3EXAHbM+SioeWvbDMrhfa6YmWFbDD10I8+/wsStsVe0SPfxaNdpGtIvi9307VozyNUJj5yuEJnaHs0FFC8Y1EDhQAMSAAn2tDY0/DMKVNXRBBx3NfDmP6TOoOZNez8KYhgouTyoKMr5yVWLJr9KnV5VHL+mDuwqKgjQfjK/VkzAicuWY4HntdGFbk2zjh/EyVX7+4u5yfa7bVnVehe/f/73k7YM99hAZM+2eAcIqDez0tV1vtgMRWUbWlwFodpkz+a2dov/a+XVGwhEp8J2qs3rMBBEwvDBcy+2ccMKE8fHH7kmR/oBSfzndGKWsUfdKhQJGVSbmzTT5U3XhpPJIYTMl01FYA+SC+4Xn8QE2+ax6EGUrwfQFwvWvZ8cHGEJ2XNx4hW7Khbl6OeMPEkzVZJwE03TIf1U7ZmMbZHE9murnyJr9dwhdrYWqTdKmNYPAK7ti85BAGBmXolXHluj2fnB2nphGQXSHR9x2tuKO/2dEYsa1BmE1PmeW/LOahRqBDNjVqI8X0fKZlnoFImJE30w==
X-Forefront-Antispam-Report:
	CIP:63.33.187.114;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-2.mta.getcheckrecipient.com;PTR:ec2-63-33-187-114.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(356005)(6486002)(316002)(6512007)(26005)(8936002)(36860700001)(5660300002)(6862004)(8676002)(6506007)(53546011)(36756003)(83380400001)(508600001)(82310400003)(2616005)(33656002)(86362001)(81166007)(186003)(47076005)(70586007)(54906003)(2906002)(4326008)(336012)(70206006);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Oct 2021 11:44:35.1750
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: c8371f53-286e-4494-fe70-08d984d0d776
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.33.187.114];Helo=[64aa7808-outbound-2.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM5EUR03FT039.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR08MB5574

SGkgSmFuLA0KDQo+IE9uIDMwIFNlcCAyMDIxLCBhdCA0OjE5IHBtLCBKYW4gQmV1bGljaCA8amJl
dWxpY2hAc3VzZS5jb20+IHdyb3RlOg0KPiANCj4gT24gMjguMDkuMjAyMSAyMDoxOCwgUmFodWwg
U2luZ2ggd3JvdGU6DQo+PiBUaGUgZXhpc3RpbmcgVlBDSSBzdXBwb3J0IGF2YWlsYWJsZSBmb3Ig
WDg2IGlzIGFkYXB0ZWQgZm9yIEFybS4NCj4+IFdoZW4gdGhlIGRldmljZSBpcyBhZGRlZCB0byBY
RU4gdmlhIHRoZSBoeXBlciBjYWxsDQo+PiDigJxQSFlTREVWT1BfcGNpX2RldmljZV9hZGTigJ0s
IFZQQ0kgaGFuZGxlciBmb3IgdGhlIGNvbmZpZyBzcGFjZQ0KPj4gYWNjZXNzIGlzIGFkZGVkIHRv
IHRoZSBYZW4gdG8gZW11bGF0ZSB0aGUgUENJIGRldmljZXMgY29uZmlnIHNwYWNlLg0KPj4gDQo+
PiBBIE1NSU8gdHJhcCBoYW5kbGVyIGZvciB0aGUgUENJIEVDQU0gc3BhY2UgaXMgcmVnaXN0ZXJl
ZCBpbiBYRU4NCj4+IHNvIHRoYXQgd2hlbiBndWVzdCBpcyB0cnlpbmcgdG8gYWNjZXNzIHRoZSBQ
Q0kgY29uZmlnIHNwYWNlLFhFTg0KPj4gd2lsbCB0cmFwIHRoZSBhY2Nlc3MgYW5kIGVtdWxhdGUg
cmVhZC93cml0ZSB1c2luZyB0aGUgVlBDSSBhbmQNCj4+IG5vdCB0aGUgcmVhbCBQQ0kgaGFyZHdh
cmUuDQo+IA0KPiBBbGwgb2YgdGhpcyBpcyBqdXN0IGZvciBEb20wLCBJIHVuZGVyc3RhbmQ/IENv
dWxkIHlvdSBzYXkgc28sIHBlcmhhcHMNCj4gYWxyZWFkeSBpbiB0aGUgdGl0bGU/DQo+IA0KDQpE
T01VIGd1ZXN0IHdpbGwgYWxzbyB1c2UgdGhlIHNhbWUgVlBDSSBoYW5kbGVyLiBXaGVuIHdlIGFz
c2lnbiB0aGUgUENJIGRldmljZXMgdG8gRE9NVSBndWVzdHMNClhFTiB3aWxsIGRlcmVnaXN0ZXIg
dGhlIFZQQ0kgaGFuZGxlciBmcm9tIERPTTAgYW5kIHJlZ2lzdGVyIGl0IGZvciBET01VIGd1ZXN0
cy4gDQoNCg0KPj4gRm9yIERvbTBsZXNzIHN5c3RlbXMgc2Nhbl9wY2lfZGV2aWNlcygpIHdvdWxk
IGJlIHVzZWQgdG8gZGlzY292ZXIgdGhlDQo+PiBQQ0kgZGV2aWNlIGluIFhFTiBhbmQgVlBDSSBo
YW5kbGVyIHdpbGwgYmUgYWRkZWQgZHVyaW5nIFhFTiBib290cy4NCj4gDQo+IFNvICJ3b3VsZCBi
ZSIgaGVyZSBtZWFucyBhdCBzb21lIHBvaW50IGluIHRoZSBmdXR1cmUsIHJhdGhlciB0aGFuDQo+
IGJlZm9yZSBvciBpbiB0aGlzIHBhdGNoPyBUaGlzIGNvdWxkIGRvIHdpdGggbWFraW5nIHVuYW1i
aWd1b3VzLg0KDQpZZXMgd2UgYXJlIGN1cnJlbnRseSB3b3JraW5nIG9uIHRvIGltcGxlbWVudCBz
dXBwb3J0IGZvciBEb20wbGVzcy4gSSB0aG91Z2h0IGl0IGlzIGdvb2QgDQp0byBtZW50aW9uIGhl
cmUgaG93IHdlIGdvaW5nIHRvIGFkZCB0aGUgdnBjaV9oYW5kbGVyKC4uKSBmb3IgRG9tMGxlc3Mg
c3lzdGVtLiAgDQo+IA0KPj4gLS0tIGEveGVuL2FyY2gveDg2L2RvbWFpbi5jDQo+PiArKysgYi94
ZW4vYXJjaC94ODYvZG9tYWluLmMNCj4+IEBAIC02NjIsNiArNjYyLDEyIEBAIGludCBhcmNoX3Nh
bml0aXNlX2RvbWFpbl9jb25maWcoc3RydWN0IHhlbl9kb21jdGxfY3JlYXRlZG9tYWluICpjb25m
aWcpDQo+PiAgICAgICAgIHJldHVybiAtRUlOVkFMOw0KPj4gICAgIH0NCj4+IA0KPj4gKyAgICBp
ZiAoIGNvbmZpZy0+ZmxhZ3MgJiBYRU5fRE9NQ1RMX0NERl92cGNpICkNCj4+ICsgICAgew0KPj4g
KyAgICAgICAgZHByaW50ayhYRU5MT0dfSU5GTywgIlZQQ0kgbm90IHN1cHBvcnRlZFxuIik7DQo+
IA0KPiBUaGlzIGlzIGEgbWlzbGVhZGluZyBtZXNzYWdlLCBhdCBsZWFzdCBpZiBmb3Igc29tZSBy
ZWFzb24gaXQgd2FzIHRvDQo+IHRyaWdnZXIgZm9yIERvbTAuIEJ1dCBkb3duIHRoZSByb2FkIHBl
cmhhcHMgYWxzbyBmb3IgRG9tVSwgYXMgSSBjb3VsZA0KPiBpbWFnaW5lIHZQQ0kgdG8gZ2V0IGVu
YWJsZWQgYWxvbmdzaWRlIHBhc3N0aHJvdWdoIHJhdGhlciB0aGFuIHZpYSBhDQo+IHNlcGFyYXRl
IGNvbnRyb2wuDQoNCkNhbiBJIHNpbGVudGx5IHJlamVjdCB0aGUgZmxhZyBvciBkbyB5b3UgaGF2
ZSBhbnkgc3VnZ2VzdGlvbiBmb3IgdGhlIGNvbW1pdCBtZXNzYWdlLg0KDQo+PiAtLS0gYS94ZW4v
ZHJpdmVycy9wYXNzdGhyb3VnaC9wY2kuYw0KPj4gKysrIGIveGVuL2RyaXZlcnMvcGFzc3Rocm91
Z2gvcGNpLmMNCj4+IEBAIC03NjcsNiArNzY3LDE4IEBAIGludCBwY2lfYWRkX2RldmljZSh1MTYg
c2VnLCB1OCBidXMsIHU4IGRldmZuLA0KPj4gICAgIGVsc2UNCj4+ICAgICAgICAgaW9tbXVfZW5h
YmxlX2RldmljZShwZGV2KTsNCj4+IA0KPj4gKyNpZmRlZiBDT05GSUdfQVJNDQo+PiArICAgIC8q
DQo+PiArICAgICAqIE9uIEFSTSBQQ0kgZGV2aWNlcyBkaXNjb3Zlcnkgd2lsbCBiZSBkb25lIGJ5
IERvbTAuIEFkZCB2cGNpIGhhbmRsZXIgd2hlbg0KPj4gKyAgICAgKiBEb20wIGluZm9ybSBYRU4g
dG8gYWRkIHRoZSBQQ0kgZGV2aWNlcyBpbiBYRU4uDQo+PiArICAgICAqLw0KPj4gKyAgICByZXQg
PSB2cGNpX2FkZF9oYW5kbGVycyhwZGV2KTsNCj4+ICsgICAgaWYgKCByZXQgKSB7DQo+IA0KPiBO
aXQ6IFN0eWxlLg0KQWNrLg0KPiANCj4+ICsgICAgICAgIHByaW50ayhYRU5MT0dfRVJSICJzZXR1
cCBvZiB2UENJIGZvciBmYWlsZWQ6ICVkXG4iLHJldCk7DQo+IA0KPiBOaXQ6IFN0eWxlIGFnYWlu
Lg0KDQpBY2suDQo+IA0KPj4gKyAgICAgICAgZ290byBvdXQ7DQo+IA0KPiBObyBvdGhlciBlcnJv
ciBoYW5kbGluZyAoY2xlYW51cCk/DQo+IA0KDQpJIHdpbGwgYWRkIHRoZSBiZWxvdyBlcnJvciBo
YW5kbGluZyBuZXh0IHZlcnNpb24gOg0KDQojZGVmaW5lIENPTkZJR19BUk0NCnJldCA9IHZwY2lf
YWRkX2hhbmRsZXJzKHBkZXYpOw0KaWYgKCByZXQgKSANCnsNCiAgICAgICAgcHJpbnRrKFhFTkxP
R19FUlIgInNldHVwIG9mIHZQQ0kgZm9yIGZhaWxlZDogJWRcbuKAnSwgcmV0KTsNCiAgICAgICAg
aW9tbXVfcmVtb3ZlX2RldmljZShwZGV2KTsNCiAgICAgICAgaWYgKCBwZGV2LT5kb21haW4gKQ0K
ICAgICAgICAgICBsaXN0X2RlbCgmcGRldi0+ZG9tYWluX2xpc3QpOw0KICAgICAgICBmcmVlX3Bk
ZXYocHNlZywgcGRldik7DQogICAgICAgIGdvdG8gb3V0Ow0KfQ0KI2VuZGlmDQoNCj4+IC0tLSBh
L3hlbi9pbmNsdWRlL2FzbS1hcm0vZG9tYWluLmgNCj4+ICsrKyBiL3hlbi9pbmNsdWRlL2FzbS1h
cm0vZG9tYWluLmgNCj4+IEBAIC0yNjIsNyArMjYzLDEyIEBAIHN0YXRpYyBpbmxpbmUgdm9pZCBh
cmNoX3ZjcHVfYmxvY2soc3RydWN0IHZjcHUgKnYpIHt9DQo+PiANCj4+ICNkZWZpbmUgYXJjaF92
bV9hc3Npc3RfdmFsaWRfbWFzayhkKSAoMVVMIDw8IFZNQVNTVF9UWVBFX3J1bnN0YXRlX3VwZGF0
ZV9mbGFnKQ0KPj4gDQo+PiAtI2RlZmluZSBoYXNfdnBjaShkKSAgICAoeyAodm9pZCkoZCk7IGZh
bHNlOyB9KQ0KPj4gKy8qDQo+PiArICogRm9yIFg4NiBWUENJIGlzIGVuYWJsZWQgYW5kIHRlc3Rl
ZCBmb3IgUFZIIERPTTAgb25seSBidXQNCj4+ICsgKiBmb3IgQVJNIHdlIGVuYWJsZSBzdXBwb3J0
IFZQQ0kgZm9yIGd1ZXN0IGRvbWFpbiBhbHNvLg0KPj4gKyAqLw0KPj4gKyNkZWZpbmUgaGFzX3Zw
Y2koZCkgKCh2b2lkKShkKSwgXA0KPj4gKyAgICAgICAgZXZhbHVhdGVfbm9zcGVjKGQtPm9wdGlv
bnMgJiBYRU5fRE9NQ1RMX0NERl92cGNpKSkNCj4gDQo+IFdoeSB0aGUgKHZvaWQpKGQpPyBJbnN0
ZWFkIHlvdSB3YW50IHRvIHBhcmVudGhlc2l6ZSB0aGUgb3RoZXIgdXNlIG9mIGQuDQoNCkkgd2ls
bCBtb2RpZnkgYXMgYmVsb3c6DQojZGVmaW5lIGhhc192cGNpKGQpIChldmFsdWF0ZV9ub3BzZWMo
KGQpLT5vcHRpb25zICYgWEVOX0RPTUNUTF9DREZfdnBjaSkpDQoNCg0KPiBKYW4NCj4gDQogDQpS
ZWdhcmRzLA0KUmFodWwNCg0KDQo=


From xen-devel-bounces@lists.xenproject.org Fri Oct 01 12:24:43 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Oct 2021 12:24:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.200590.355110 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mWHaW-00017b-9z; Fri, 01 Oct 2021 12:24:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 200590.355110; Fri, 01 Oct 2021 12:24:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mWHaW-00017U-6B; Fri, 01 Oct 2021 12:24:28 +0000
Received: by outflank-mailman (input) for mailman id 200590;
 Fri, 01 Oct 2021 12:24:27 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=81MA=OV=yandex.ru=isaikin-dmitry@srs-us1.protection.inumbo.net>)
 id 1mWHaU-00017J-9Y
 for xen-devel@lists.xenproject.org; Fri, 01 Oct 2021 12:24:26 +0000
Received: from forward103j.mail.yandex.net (unknown [5.45.198.246])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id ac2f2a9e-3bbd-40cd-b167-6b5527d66fe2;
 Fri, 01 Oct 2021 12:24:23 +0000 (UTC)
Received: from forward100q.mail.yandex.net (forward100q.mail.yandex.net
 [IPv6:2a02:6b8:c0e:4b:0:640:4012:bb97])
 by forward103j.mail.yandex.net (Yandex) with ESMTP id B5AF4100B45;
 Fri,  1 Oct 2021 15:24:20 +0300 (MSK)
Received: from vla1-faefe240866f.qloud-c.yandex.net
 (vla1-faefe240866f.qloud-c.yandex.net
 [IPv6:2a02:6b8:c0d:98f:0:640:faef:e240])
 by forward100q.mail.yandex.net (Yandex) with ESMTP id B189D6F40014;
 Fri,  1 Oct 2021 15:24:20 +0300 (MSK)
Received: from vla1-62318bfe5573.qloud-c.yandex.net
 (2a02:6b8:c0d:3819:0:640:6231:8bfe [2a02:6b8:c0d:3819:0:640:6231:8bfe])
 by vla1-faefe240866f.qloud-c.yandex.net (mxback/Yandex) with ESMTP id
 64SiCh0TmR-OKFeHp6E; Fri, 01 Oct 2021 15:24:20 +0300
Received: by vla1-62318bfe5573.qloud-c.yandex.net (smtp/Yandex) with ESMTPS id
 ZeWstiiHda-OJ38tSTD; Fri, 01 Oct 2021 15:24:19 +0300
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
 (Client certificate not present)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ac2f2a9e-3bbd-40cd-b167-6b5527d66fe2
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1633091060;
	bh=bgmuj30dggJ7JshrLX22yk3c/wj3X4um4/1rOX+GNV8=;
	h=Message-Id:Date:Subject:To:From:Cc;
	b=Jf0BGjyM4VfJWgVBAtilRqTFxxfRbqscRW/q9fNRpGUUUL79t1lHF26C7d6kNAmbC
	 h/Cf+kFwiKPPDejFjCSIveJO24RSym6WYRA2vAqM3yG/WNnwVuc5M9NqJHPZl/61L6
	 Ey0bKK7hDCL55kOPEtE0/SzYCMASaD02wwXhDrHc=
Authentication-Results: vla1-faefe240866f.qloud-c.yandex.net; dkim=pass header.i=@yandex.ru
From: Dmitry Isaykin <isaikin-dmitry@yandex.ru>
To: xen-devel@lists.xenproject.org
Cc: Dmitry Isaykin <isaikin-dmitry@yandex.ru>,
	Ian Jackson <iwj@xenproject.org>,
	Wei Liu <wl@xen.org>,
	Anthony PERARD <anthony.perard@citrix.com>
Subject: [PATCH v5] tools/xl: fix autoballoon regex
Date: Fri,  1 Oct 2021 15:24:16 +0300
Message-Id: <54c1bcb40afa8a6f36ab4bec8c91523a535c911b.1633090722.git.isaikin-dmitry@yandex.ru>
X-Mailer: git-send-email 2.33.0
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

This regex is used for auto-balloon mode detection based on Xen command line.

The case of specifying a negative size was handled incorrectly.
>From misc/xen-command-line documentation:

    dom0_mem (x86)
    = List of ( min:<sz> | max:<sz> | <sz> )

    If a size is positive, it represents an absolute value.
    If a size is negative, it is subtracted from the total available memory.

Also add support for [tT] granularity suffix.
Also add support for memory fractions (i.e. '50%' or '1G+25%').

Signed-off-by: Dmitry Isaykin <isaikin-dmitry@yandex.ru>
Reviewed-by: Anthony PERARD <anthony.perard@citrix.com>
---
Changes in v5:
- add Anthony's reviewed-by

Changes in v4:
- improve regex after code review

Changes in v3:
- add support for [tT] granularity suffix
- add support for memory fractions

Changes in v2:
- add missing Signed-off-by tag

NB! New autoballon regex pattern is good enough, but not fully correct.
See test below.

```
import pytest
import re

size_pattern = r"-?[0-9]+[bBkKmMgGtT]?"
pattern = r"(^| )dom0_mem=((|min:|max:)({size}|({size}\+)?[0-9]{{1,2}}%),?)+($| )".format(size=size_pattern)

@pytest.mark.parametrize('cmdline', [
    'dom0_mem=1',
    ' dom0_mem=1',
    'dom0_mem=1G',
    'dom0_mem=25%',
    'dom0_mem=1g+25% ',
    ' dom0_mem=1G+10%,max:100T+50%',
    'dom0_mem=-1B',
    'dom0_mem=-10240M+5%,min:512M ',
    ' dom0_mem=min:-2048m,max:-2048M ',
])
def test_autoballoon_regex_match(cmdline):
    assert re.match(pattern, cmdline)

@pytest.mark.parametrize('cmdline', [
    'dom0_mem = 1',
    'dom0_mem= ',
    'dom0_mem',
    'DOM0_mem=10G',
    'dom0_mem=-10%', # does not pass
    ' dom0_mem=-10%+10G ',
    'dom0_mem=1G,', # does not pass
    'dom0_mem=1G,max:25%,', #does not pass
])
def test_autoballoon_regex_dont_match(cmdline):
    assert not re.match(pattern, cmdline)
```
---
 tools/xl/xl.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/tools/xl/xl.c b/tools/xl/xl.c
index 4107d10fd4..f422f9fed5 100644
--- a/tools/xl/xl.c
+++ b/tools/xl/xl.c
@@ -80,14 +80,20 @@ static int auto_autoballoon(void)
     if (!info)
         return 1; /* default to on */
 
+#define SIZE_PATTERN "-?[0-9]+[bBkKmMgGtT]?"
+
     ret = regcomp(&regex,
-                  "(^| )dom0_mem=((|min:|max:)[0-9]+[bBkKmMgG]?,?)+($| )",
+                  "(^| )dom0_mem=((|min:|max:)(" SIZE_PATTERN "|(" SIZE_PATTERN "\\+)?[0-9]{1,2}%),?)+($| )",
                   REG_NOSUB | REG_EXTENDED);
+
+#undef SIZE_PATTERN
+
     if (ret)
         return 1;
 
     ret = regexec(&regex, info->commandline, 0, NULL, 0);
     regfree(&regex);
+
     return ret == REG_NOMATCH;
 }
 
-- 
2.33.0



From xen-devel-bounces@lists.xenproject.org Fri Oct 01 12:41:09 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Oct 2021 12:41:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.200600.355121 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mWHqY-0003ZW-Nv; Fri, 01 Oct 2021 12:41:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 200600.355121; Fri, 01 Oct 2021 12:41:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mWHqY-0003ZP-Kz; Fri, 01 Oct 2021 12:41:02 +0000
Received: by outflank-mailman (input) for mailman id 200600;
 Fri, 01 Oct 2021 12:41:00 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=KCT2=OV=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mWHqW-0003ZJ-Ed
 for xen-devel@lists.xenproject.org; Fri, 01 Oct 2021 12:41:00 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id d357e728-22b4-11ec-bda0-12813bfff9fa;
 Fri, 01 Oct 2021 12:40:58 +0000 (UTC)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2053.outbound.protection.outlook.com [104.47.12.53]) (Using
 TLS) by relay.mimecast.com with ESMTP id de-mta-9-0zuZFZCIM3uFSwhEQyF8Pw-1;
 Fri, 01 Oct 2021 14:40:56 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VE1PR04MB6382.eurprd04.prod.outlook.com (2603:10a6:803:122::31)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.19; Fri, 1 Oct
 2021 12:40:53 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4566.014; Fri, 1 Oct 2021
 12:40:53 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS8P251CA0002.EURP251.PROD.OUTLOOK.COM (2603:10a6:20b:2f2::15) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4566.14 via Frontend Transport; Fri, 1 Oct 2021 12:40:51 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d357e728-22b4-11ec-bda0-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1633092057;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=Sk5xXoMECgoAPRmqrXjkZhP6tXMUOjqsXm6deHY5wuo=;
	b=k3u4bHfdVQXAggqaAmWH/bTkS7usQzxdlHkVGijptl6dQNAE+0jUn/cbVVUjg+Q2Jlk9O0
	4ERmXHg681SFWqIi6jDh5LvSs6V9F0DRBNY4pTm7vGyVNOiofyuhGzNr+jyQMnUrBO/t5c
	1H/yE0mSD3VNuQlgE4Om09vlQL08+Jk=
X-MC-Unique: 0zuZFZCIM3uFSwhEQyF8Pw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=EujXjLyN+emKrpVByOg+VrL8cwUOIBm01XecQ0HyeOtPJfmmrHwitJw18IjKOQ137OObiCdz0eY3Z5OgSyJ4um+Zx6lHWUSpMDh0oVWiUjmpklY9zjCQu4q0nhBValZo8tUKH9xCDsA+i7KWra5xGDL9hcSkBMf1HLTre/T4QFf/D0ZR5eBu7jmAViiPP/wPx0T9HPSAInu502mCYAScWYA0erWiOxhPRjby+9np53XQ4lETOCFZZs3mjM7v12eeb2uSwzjpVojYF6L0nBht5cfHzxSag7pss5sS2mQeAAoOKacu4Yqq3t+R3/XyvpUSgo7l0PQzbwVJ9mlJ0iLqvQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=6HVoRp3HJtQ+BByKx+UH2Z/rmdwcUrvQZUxWIiCqngs=;
 b=c0DVgl0TtpGBiOhEHBm+E44GLB7W+j7YQdgrTqKdaCeRjOMRgQ+c7JYmqh8eA1nKJkHVVyGz8/MdWc5AXCZ8DR7c0F4uEL4uyT6lGkI0aBc3oI0fG4YzAZpVJvlFna2C0BQCl8IHM1bFNWzcrpFlVIFgTTETj96gpPhaWRL/M2txZn3qS4i6qfVpTRM3zw8T5PUsfHGer4dG1N4elVi5IuWeAYg7rBWthc2QQ1feov8u6sR3c3wP5xy9nDmHxncztXccHpge2kZrFQAEHY8wRiaZT6iJ64AcT7g+PVWXr8yqaet9LnYggNfuusXxo/LXhRdbUD5PJvil1Ys3yG0pFw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [PATCH v3 14/17] xen/arm: Enable the existing x86 virtual PCI
 support for ARM.
To: Rahul Singh <Rahul.Singh@arm.com>
CC: Bertrand Marquis <Bertrand.Marquis@arm.com>,
 Andre Przywara <Andre.Przywara@arm.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Wei Liu <wl@xen.org>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>, Paul Durrant <paul@xen.org>,
 xen-devel <xen-devel@lists.xenproject.org>
References: <cover.1632847120.git.rahul.singh@arm.com>
 <d7f62249e6aa7b33017ef707d6bc451b5e2c7047.1632847120.git.rahul.singh@arm.com>
 <491a49c0-d609-c122-f64a-999b16ef3a83@suse.com>
 <F537F4D7-A4D3-45D4-9A0C-AB573CAA724A@arm.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <38119531-4c0b-42b5-59ee-eebb70c1f9b4@suse.com>
Date: Fri, 1 Oct 2021 14:40:49 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <F537F4D7-A4D3-45D4-9A0C-AB573CAA724A@arm.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS8P251CA0002.EURP251.PROD.OUTLOOK.COM
 (2603:10a6:20b:2f2::15) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: aa1f8539-2cce-43ea-e159-08d984d8b505
X-MS-TrafficTypeDiagnostic: VE1PR04MB6382:
X-Microsoft-Antispam-PRVS:
	<VE1PR04MB638286DF49F8351C6F68EB1DB3AB9@VE1PR04MB6382.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	fxJQuGcQ0KL9IvkljzWkPxAJaiw2upmu7WzH80eEmyg9DApOeQOkjNT4Ug/48Cjw0QBluvOib45qLrhr9Mi6mARlwKfLwHFxH0D17LrLdOTEVH5jK7nzAU7cahBhCCIx6f//bA4/eORjvNpqf/RjRJ1HgjeMdy7Gq2pi0DXUn3lutK9N5slLASMFYZBBNCGE5usgcss1D6zp+vFZOfwkfAgx4+RVS7EYnZ+C6eH458pPLbe9Fs6nlvd6HHBVo1D+erKGoRlrV85RDt75KFDJyTqD1KTdREEbrBaO1Xg0Po0OXQNtzUBqXq+tuWBUtOIKX7OaYS849H1iVO4kRD2JZQ763rRFjakWPhuzAwyG9aZBkatsm6sXHkuo6q35WNFxvhTSTOkYIe7eAFGfzS9VpwQ7CNMxcfm2zGNk4U2weAAz5T2KmRfKl7vL999f8gPvOpf9ZPsesvd83X8fDMV1tQjAxE11Co7q8H84ls2x/PC+IU8wKRF8rybG66jgR2ULnZPCVUpwTI9aY0Q54VGwkYEtiw7WXzl+y2ziZtG1bKwssdP6k64kAx81i0VyRQCzMrjkJoNb0Vms5X0Lhq+qiuCDztzaZpOYBoNTJLlZH1gs4FeTQUaDZuGzmN+RF6pqUeDcCVpeqdrf0nYk4sSgFwrT9ccKU5Yc+gmYd9IN4bwAsvZghrXnGo8TzI1OEOBVPDQF2Rbbv15oGEhgbl/5thv/GJmHw9lM526YSkP+PSw=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(7416002)(53546011)(54906003)(26005)(16576012)(38100700002)(31686004)(4326008)(316002)(5660300002)(2906002)(36756003)(66946007)(956004)(31696002)(83380400001)(6916009)(8676002)(186003)(66556008)(86362001)(2616005)(66476007)(8936002)(6486002)(508600001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?KdlnC/zlg0i1K/Ac7o78umcZuSHVu9m6ToW9zBkWHt9gawJ5sMtWsCPCq/q+?=
 =?us-ascii?Q?r3TT1cTRAxK4dekH4gkz+4EFh8V7FhGz66LhhazHzj3v4rg3K8nksUcOhn9d?=
 =?us-ascii?Q?do4DoT8VfRV1CGleRdsVRlKkjSLSVMfbhCyibZqUi30IleEMoIHkRaAZRj/X?=
 =?us-ascii?Q?Zoy9PlSnTcZYgoEqRr0Dbb6QAqp4j2aFOyBknx/TcFZ+8Jz7UXj2kNQSb0dq?=
 =?us-ascii?Q?FTXlllDxIeDK4Gx71B5HsXjv0m6pqpmza8YODHBdY90Yr6nMsoQ2A+HodlOq?=
 =?us-ascii?Q?Ao1SAcBP66xfUed8MVTY/2YZGZR/WsnyiS06VuVJjJ3Qn1DecYS5XrQ6Vns3?=
 =?us-ascii?Q?NTEZ9kMEMEJETMN6qwjOze2RkotuYgnCO47mBtB5KObC9cHqgP/CH6/IrLPw?=
 =?us-ascii?Q?KG9pFKB+OMrElaVlkAVpxDRcMJ6K7EBo+ETE3mWUoWd2nroG3KhK8UF1gQug?=
 =?us-ascii?Q?OCk2i8S0hvMmGNLo35yuDCbINpPdTkrSn7FVhm0YxJUDeDv/twB3ApPFNDpJ?=
 =?us-ascii?Q?vlOyX/nww2sdOXBzEu7r7rmSeqz9yx3Z/dDf4vwvL9b20Smf+btLs1+vk41A?=
 =?us-ascii?Q?lpzAG58r5SjKOXBb7S1QFX7yHKb/IBQVVzHBhxgvbBtNQjP/PxqY8i0Ifi6S?=
 =?us-ascii?Q?1V2BIUT++FFceIo2xm+0C1uxXvzj4gRRoEEgt6JFpcoKY245BZF0X4/K5fAg?=
 =?us-ascii?Q?zBskkgQgHkvHYAMOB/4hWmKCYHReV58X4hzHOF4sYWrA5JvaO7CGR1KFCbqp?=
 =?us-ascii?Q?WidjhksTDu4kdS4ADmFbp/DPcGmYmgzJ3WAPoAMUqyrv/CSFdIdwT4ozN2QF?=
 =?us-ascii?Q?5dI+p9P68Tr/U4a4jYBanJWWR251i2S0G+QjHU+07+OGYnx9TELVId+QsfZu?=
 =?us-ascii?Q?bgIEFaLrUJ9e0wnV30BqUViFAsD6CllHLuudiSxlRm87/hQ6xdbhrfOLxauQ?=
 =?us-ascii?Q?mc0VKMvtq5Xol7kThU/AqninNtGaX2i0hUPYqtltU0GThub4HfZfI5F9MSeJ?=
 =?us-ascii?Q?YDB9xEWv+SkE+Um/bTrV5GnsnArQyHDXkiTqZW/jyHw2LtFpabzb3i3FS2Vo?=
 =?us-ascii?Q?tF0PGrhvPfxVRVXPX+ZJOiv99HGVquQoQzA5HTsSm+fMQBguH0/k0Acd73C/?=
 =?us-ascii?Q?rP0r7iZTYkrPpvP0ZjjeJNW3ehPDRIO9lHESQz+Mxil718iamYjaoT+UI69M?=
 =?us-ascii?Q?a+rdsSx6fROC5aH5r/4Pkw7eIrvFZwnmu8dUWs7shWHMkAY96p5AtEGqMxcF?=
 =?us-ascii?Q?NBh7jaYZAfL4v7WrvQ5yowlgPS4XT4hgzIwoiIYkuZtCp+auesWlgzn1T3Rg?=
 =?us-ascii?Q?Q0c6/h5tqTFqXK6TnbvygQmv?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: aa1f8539-2cce-43ea-e159-08d984d8b505
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Oct 2021 12:40:53.6028
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ZcD+66yDWbIKvcmvV6W6FTBKHkU2kbIKARBYE7e3UgmxWp4y9BCailPxnlr6bzVSf3tku2YzRSOqdD7cHI6pcA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6382

On 01.10.2021 13:44, Rahul Singh wrote:
>> On 30 Sep 2021, at 4:19 pm, Jan Beulich <jbeulich@suse.com> wrote:
>>
>> On 28.09.2021 20:18, Rahul Singh wrote:
>>> The existing VPCI support available for X86 is adapted for Arm.
>>> When the device is added to XEN via the hyper call
>>> =E2=80=9CPHYSDEVOP_pci_device_add=E2=80=9D, VPCI handler for the config=
 space
>>> access is added to the Xen to emulate the PCI devices config space.
>>>
>>> A MMIO trap handler for the PCI ECAM space is registered in XEN
>>> so that when guest is trying to access the PCI config space,XEN
>>> will trap the access and emulate read/write using the VPCI and
>>> not the real PCI hardware.
>>
>> All of this is just for Dom0, I understand? Could you say so, perhaps
>> already in the title?
>>
>=20
> DOMU guest will also use the same VPCI handler. When we assign the PCI de=
vices to DOMU guests
> XEN will deregister the VPCI handler from DOM0 and register it for DOMU g=
uests.=20

But that logic is not fit for DomU use, is it? Aiui some of the other
series on the list are aiming to work towards making it usable.

>>> --- a/xen/arch/x86/domain.c
>>> +++ b/xen/arch/x86/domain.c
>>> @@ -662,6 +662,12 @@ int arch_sanitise_domain_config(struct xen_domctl_=
createdomain *config)
>>>         return -EINVAL;
>>>     }
>>>
>>> +    if ( config->flags & XEN_DOMCTL_CDF_vpci )
>>> +    {
>>> +        dprintk(XENLOG_INFO, "VPCI not supported\n");
>>
>> This is a misleading message, at least if for some reason it was to
>> trigger for Dom0. But down the road perhaps also for DomU, as I could
>> imagine vPCI to get enabled alongside passthrough rather than via a
>> separate control.
>=20
> Can I silently reject the flag or do you have any suggestion for the comm=
it message.

Whether to issue a message can be judged by all the other code in this
function. Which makes the answer "no, you can't silently reject the
flag". As to the message itself, maybe "vPCI cannot be enabled this way"
or "vPCI cannot be enabled yet"?

>>> --- a/xen/include/asm-arm/domain.h
>>> +++ b/xen/include/asm-arm/domain.h
>>> @@ -262,7 +263,12 @@ static inline void arch_vcpu_block(struct vcpu *v)=
 {}
>>>
>>> #define arch_vm_assist_valid_mask(d) (1UL << VMASST_TYPE_runstate_updat=
e_flag)
>>>
>>> -#define has_vpci(d)    ({ (void)(d); false; })
>>> +/*
>>> + * For X86 VPCI is enabled and tested for PVH DOM0 only but
>>> + * for ARM we enable support VPCI for guest domain also.
>>> + */
>>> +#define has_vpci(d) ((void)(d), \
>>> +        evaluate_nospec(d->options & XEN_DOMCTL_CDF_vpci))
>>
>> Why the (void)(d)? Instead you want to parenthesize the other use of d.
>=20
> I will modify as below:
> #define has_vpci(d) (evaluate_nopsec((d)->options & XEN_DOMCTL_CDF_vpci))

Please also omit the outer pair of parentheses, unless the Arm maintainers
insist on having them despite being redundant.

Jan



From xen-devel-bounces@lists.xenproject.org Fri Oct 01 13:27:05 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Oct 2021 13:27:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.200612.355144 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mWIYs-0008El-FF; Fri, 01 Oct 2021 13:26:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 200612.355144; Fri, 01 Oct 2021 13:26:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mWIYs-0008Ee-BR; Fri, 01 Oct 2021 13:26:50 +0000
Received: by outflank-mailman (input) for mailman id 200612;
 Fri, 01 Oct 2021 13:26:49 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=KCT2=OV=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mWIYr-0008EY-N9
 for xen-devel@lists.xenproject.org; Fri, 01 Oct 2021 13:26:49 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 67ccd2e3-a35b-4d06-9cd6-7034d837dc7b;
 Fri, 01 Oct 2021 13:26:48 +0000 (UTC)
Received: from EUR03-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur03lp2054.outbound.protection.outlook.com [104.47.8.54]) (Using
 TLS) by relay.mimecast.com with ESMTP id de-mta-2-X-5VjzGRNQ2-bNzpWWd7rw-1;
 Fri, 01 Oct 2021 15:26:46 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB5327.eurprd04.prod.outlook.com (2603:10a6:803:5c::23)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.15; Fri, 1 Oct
 2021 13:26:44 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4566.014; Fri, 1 Oct 2021
 13:26:44 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS8PR04CA0056.eurprd04.prod.outlook.com (2603:10a6:20b:312::31) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.14 via Frontend
 Transport; Fri, 1 Oct 2021 13:26:43 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 67ccd2e3-a35b-4d06-9cd6-7034d837dc7b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1633094807;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=XXYUFjcGJFQCjxv4Au0IkJJBheckl/vMH4V+bUlEVUU=;
	b=MX5floONA83MwXeQCPDPkIU97pR1TUu5Wvqmr3UIBJF2Bl3fc5JDZdBEUMIWqXh10buJpH
	4i9O+x1wiyl35Cv9J4SMZLxXjjfz+Z3IGAy5k/BR31PakWgeTQORQ7cPBOaYPAzYWCZeab
	PzvipMy27WSJUouCeqg12yDE7m0/RlI=
X-MC-Unique: X-5VjzGRNQ2-bNzpWWd7rw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=oFXK3gB9xzb1aJK2KstEPu8el19w5K5boCJiF2U/Z1StXt413/6lmIftG27ZA0N2xtdtb4LM7eW1bYSzxX82KeZ2nZwkLYjgmzp03himKP05aRZppOUSaVXSN0nCOrD0Oo4Xb2wJnWB3pGCkelS3BEQih0Pt4+qHsnPNL3XZNlyiMF5qvn3QAe269wqqg7tOOhUEnTLWaAVyuZQ9myIqziVq/34IWnOFPhgEnFKIF5VOaxWmFjl04ZB83jnGWvZ1S2W5Q14D0SwR/ly330wTa2IV322v3WEMet9mQ3vTbcJ3K84zbRI4ui4JY2uyaH/AhZGhrWLcyAjSuuLpQX4bdw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=XXYUFjcGJFQCjxv4Au0IkJJBheckl/vMH4V+bUlEVUU=;
 b=GI83HN3xHdLbj0Rw9QDNvciXOshYaqUkXWo0spdqnhXg0+44h2inKVpWu+mStgDNtXaR3tGUoWAj2GCvZG8DFJfZi8JCsE8S4Woe03sO0XwiXVBFlR/GOw/jFCDnw1yZwL7ZkLsJ4N5BaBSoh6DywODi8yBcW9fd+59h5KbX5wbM2/uMdYxV+wHMoHMVnZ3x+HVGmF4I7FvttVEj1a0eCDN+lS4rWy85GM93BKSpU1sUS5iGOUzZeorbkR7v4BmAKw95EqfCU/4j/d+48yTar+aGfMZk1vdHZD+kqBD5pC2RaxGK9wYOSqOyRFaxQMBuAVT5kcZplaSyMUov9fnBgA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [PATCH v3 04/11] vpci/header: Add and remove register handlers
 dynamically
To: Oleksandr Andrushchenko <andr2000@gmail.com>
Cc: julien@xen.org, sstabellini@kernel.org, oleksandr_tyshchenko@epam.com,
 volodymyr_babchuk@epam.com, Artem_Mygaiev@epam.com, roger.pau@citrix.com,
 bertrand.marquis@arm.com, rahul.singh@arm.com,
 Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>,
 xen-devel@lists.xenproject.org
References: <20210930075223.860329-1-andr2000@gmail.com>
 <20210930075223.860329-5-andr2000@gmail.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <2b575750-83a5-588e-fd6b-dd9cdb9500dd@suse.com>
Date: Fri, 1 Oct 2021 15:26:41 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <20210930075223.860329-5-andr2000@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8PR04CA0056.eurprd04.prod.outlook.com
 (2603:10a6:20b:312::31) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: d352f913-2c81-4481-571f-08d984df1c95
X-MS-TrafficTypeDiagnostic: VI1PR04MB5327:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB532716E9184BECF36032007EB3AB9@VI1PR04MB5327.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	AvQjgvFNIvZ2CHLPR5SyglB50dD2fLW//9eik4BV1jdd2l6pDjSZAsb2jkWeiFmEYQOSIRCtYruC5iJhPxNEf5mVhL4WH7aXPcpcoKJ/dTBQQTakKjLfh7U9skVBLl5sQySQydQa3tA8me2UafE6Fkier2uuN13XCKnLXkuSwcTe+IKlcTMB9iTlW57hsAmtlvGW9ri9ZAd5VHKhtMyJSGc2kKdV2NHdH4mvhbRNOm0SCc3LFlHq4XrrEGzs7qBQYxXxGzJKqQFQlsO9kstbEM5s1U2T6Flw1i9YGYCoN17QCXLBi7ETnirYoI8quvJIqkhJKrJDFky0n2lQYDPcdhg3LlC0D151qxdGouT5d5XZwGyp+zvv7N1yn1x9frudY0okHgj159TdDmG1es4p46qD4LmE1py7iqnc5h07YcRJ01E8Qn57dn5e/ytGvgkG+h3phq2lVsicacfiCNonJRUQqALXWGd1jk18m1H751mG4wbXsiJsJyQye8spXYaDCHQ/qKc5gOkCldakoP8rGFenY04IL9v+A+kF+qOy73y3ckdPgawZl/sCZ3ocUzDC70yHA6YVjcQ3P1vIx78LS05EhqPLxBCdqZz7FOxt7P/qq8Jv1wNhFjUTn/PBbsup13hY5PhXAkmbKdvJY3eethj+MqLvcge2ZjXAZxTLTeOg/XXc1+l7B/TBqNh7RPdRFBTn53n7Ks/n9p/tN1d2dlZSDTElTDcJB25yW0IOAvMZabhYOCTSiu4if94DMY9g
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(36756003)(53546011)(31686004)(5660300002)(8936002)(2616005)(86362001)(31696002)(7416002)(8676002)(4326008)(6486002)(26005)(956004)(6916009)(186003)(66556008)(66946007)(38100700002)(2906002)(508600001)(316002)(16576012)(66476007)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?UnpLcFBmWlNKYkVtQ25aN1NnMmJ0elJxMUFoeGRhY1VtYmgvekY4SDZWc1Iw?=
 =?utf-8?B?cnU0UjhBR3FFdGx2Sk9jTzdhdU9BNzVEb1R6S040ZDRMWGl6Umx6N1pmOFFl?=
 =?utf-8?B?QlNKWlh5dEhCbXQxYnJubEsvMVZQNWE0SUlUak43ZnZ1R2s0VWg4ekNmTTI1?=
 =?utf-8?B?c1NZaXF3bGphdkpxbWg5TUY3SXVXaGw1RTFsYzZyWEVvZnJ2Zkd3RkEvSkpl?=
 =?utf-8?B?dHVnUEZIMmU5K2dyTzRSU3ZiUXJWZUFIZXlFZis0UXVxR0MyRC9pU21Ka1o0?=
 =?utf-8?B?QTBPaUMzdjhxTnY1cG1ycTRxR25ORDRMbHVsaEMzbkVWTldwYSswSmM0aDZT?=
 =?utf-8?B?bkkyQjJKODJiRzY4SkRDOFRWM01RMmlwRFpUUG9KTEpJbTM1czhhR3VBOUc3?=
 =?utf-8?B?Qmh4REk2VHhvK3U0dFgxTGw5d2xpRjE0S2NRRGI4bHZEeWcwaFFWbXBSdXZU?=
 =?utf-8?B?NWpxcDBwZjcvekhHOFRxUGUxc3ZMZldFa3BwN29NV3J1TmRpNnBmdXM5OTdW?=
 =?utf-8?B?QVNuTDRoTTJ2RWo3SGVreFMyZ0FTRUhnS3ArcUZTVzNzOWxVSC8yc3hiWDNJ?=
 =?utf-8?B?R0NkdG5nTG1UZ3h0YkZZTlNxa3ZVL1VlOXRpY2EvN1k4QVd1TUMraEM5OE41?=
 =?utf-8?B?ZFRaVUo5eFZDSW10dlEyNU5Ha2cycFVWeGEvZWRNMjJNSHExWmM3bUthand4?=
 =?utf-8?B?MENMM1dpanhaSkd4VWNHRkdRdnJyeDJmR1VqTHZXM2JkbTZFdDFDdDJmRUFs?=
 =?utf-8?B?QnJzQ0I3NituOFBVOUowUGtpTDZ3a0lyWnhERndEdXZvS25uVllKTVpudjRE?=
 =?utf-8?B?QWhVZG1xYzU5OTl4aVk2UlI1ejVzb2hkYVIvMnhkOGNPWUYvNWhNQWtpUVVG?=
 =?utf-8?B?enAzaEZTUmEvZ0Znd3d6OXpHbUw1T3QvQkRaQVVSUjVBNFg4UFNHaWlIMkg2?=
 =?utf-8?B?MjY2dFhZTlJYWVplOTZGREV6QnEwUG5veC9abTBSVSt3LzZadXYxbys0QTN1?=
 =?utf-8?B?S0ZaMmdRczFYNHY4bFRlQU52YnFCQlFEVnpWTmdERGRuWjdtTFEyam5EcVBw?=
 =?utf-8?B?YUw5bW5TVXpLeWRKT2YxbG5nQzVibXdaRXd5Rml5OTg1TzYralBJRGt0a3Fo?=
 =?utf-8?B?OU5hZU5IM1ZUM0pFVk1zZmhWQ29CQzk3UE55MUR3M2gxTFAxZVFzQUlBekE3?=
 =?utf-8?B?aDZ2ZTZBRGhWUFBaWk01UHFtanJvaE4ybmFzVy9INk1LQlF0UzJ6WjQwSFlq?=
 =?utf-8?B?WjhJci9uajVBL3N5VG05WU95WTVMNGE1b050d245YVNyY2pvOFJ2d1pZK0dC?=
 =?utf-8?B?YXMvRFJsZk9qbndZbUpYQ3NSa2ZtTmlZOUIwQU1lOFd0R3UzdWZQMDFKanpT?=
 =?utf-8?B?SVNpRGxCV3hCV1pWdVpLc2QyV1pQUEpjTENoN0tVTmlDS2s3TkVlVXBmeEUy?=
 =?utf-8?B?NDFFTEFmN3FQVlJYZmM4N0dxWmdDb0NYTCtsbmFMeFBycUs5SjRxeE5uOW9Y?=
 =?utf-8?B?WEwranplbmpRK0YveVZxb1BVUUV3aDR2Q0ltQ3hRbWlDeDFCczJhdWFBbVlw?=
 =?utf-8?B?VTAyQi9mekxRV3p4aS94cHVFbDBsZENENWR2UDBrWWx1MVV2eEc0RFhNNHlF?=
 =?utf-8?B?N0dVZlNEdE5JVFNNNlMyL1VpRUhhaDFLQy9JNHVxaThSQ2VTZmlubkNmNXgv?=
 =?utf-8?B?bVpXbWU0M2NOaTRkVjNvWFdmUEh0ZG1yYmZSMCtadXlmRm5wTGpJZGtxcFo2?=
 =?utf-8?Q?JXGJn32lfLWYpyK9VmcOg2ehhLnE9K8wdtYq4qh?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d352f913-2c81-4481-571f-08d984df1c95
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Oct 2021 13:26:44.2837
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: fs5qXrJVhelOftrTNrFybAe7Q6G/MQV43trbO0YW0yYfuutdwdBCKpF/483y4ET9W98ofRCTST5NWRynvyhKzg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5327

On 30.09.2021 09:52, Oleksandr Andrushchenko wrote:
> @@ -445,14 +456,25 @@ static void rom_write(const struct pci_dev *pdev, unsigned int reg,
>          rom->addr = val & PCI_ROM_ADDRESS_MASK;
>  }
>  
> -static int add_bar_handlers(const struct pci_dev *pdev)
> +static void guest_rom_write(const struct pci_dev *pdev, unsigned int reg,
> +                            uint32_t val, void *data)
> +{
> +}
> +
> +static uint32_t guest_rom_read(const struct pci_dev *pdev, unsigned int reg,
> +                               void *data)
> +{
> +    return 0xffffffff;
> +}
> +
> +static int add_bar_handlers(const struct pci_dev *pdev, bool is_hwdom)

I remain unconvinced that this boolean is the best way to go here, but
I'll leave the decision there to Roger. Just a couple of nits:

> @@ -593,6 +625,30 @@ static int init_bars(struct pci_dev *pdev)
>  }
>  REGISTER_VPCI_INIT(init_bars, VPCI_PRIORITY_MIDDLE);
>  
> +#ifdef CONFIG_HAS_VPCI_GUEST_SUPPORT
> +int vpci_bar_add_handlers(const struct domain *d, const struct pci_dev *pdev)
> +{
> +    int rc;
> +
> +    /* Remove previously added registers. */
> +    vpci_remove_device_registers(pdev);
> +
> +    rc = add_bar_handlers(pdev, is_hardware_domain(d));
> +    if ( rc )
> +        gdprintk(XENLOG_ERR,
> +                 "%pp: failed to add BAR handlers for dom%pd: %d\n",

Only %pd please, as that already expands to d<num>.

> +                 &pdev->sbdf, d, rc);
> +    return rc;

Blank line please ahead of the main return statement of a function.

Jan



From xen-devel-bounces@lists.xenproject.org Fri Oct 01 13:32:06 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Oct 2021 13:32:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.200619.355155 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mWIdu-0001JF-1r; Fri, 01 Oct 2021 13:32:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 200619.355155; Fri, 01 Oct 2021 13:32:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mWIdt-0001J8-UZ; Fri, 01 Oct 2021 13:32:01 +0000
Received: by outflank-mailman (input) for mailman id 200619;
 Fri, 01 Oct 2021 13:32:00 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=KCT2=OV=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mWIds-0001J2-65
 for xen-devel@lists.xenproject.org; Fri, 01 Oct 2021 13:32:00 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id f33d6df4-22bb-11ec-bda9-12813bfff9fa;
 Fri, 01 Oct 2021 13:31:58 +0000 (UTC)
Received: from EUR02-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur02lp2053.outbound.protection.outlook.com [104.47.4.53]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-34-eEybLmrtNRSCgdrLTXQ-xw-1; Fri, 01 Oct 2021 15:31:56 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB5471.eurprd04.prod.outlook.com (2603:10a6:803:d0::33)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.18; Fri, 1 Oct
 2021 13:31:55 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4566.014; Fri, 1 Oct 2021
 13:31:55 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS9PR06CA0266.eurprd06.prod.outlook.com (2603:10a6:20b:45f::15) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.13 via Frontend
 Transport; Fri, 1 Oct 2021 13:31:54 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f33d6df4-22bb-11ec-bda9-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1633095117;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=YhsLwXJe7nzHQDzW8lEmGU2YmeM3dFTlymztpAfcM+A=;
	b=nMrUwo3mHTCdWsQPU1dx6O3LtCv9JNlimyUfFWWfdzseYnzXS1UV9vuH3cKLnRYvcPKF0i
	isqON15Blnh10v5PsvCt2m25AWfMbY09APj+peHeZ9FrQYsE+oh6gBznl3ndSOHeh4B/DL
	VjkOYv8CNr7ZOd5PsGCKQm1LS/Jujbo=
X-MC-Unique: eEybLmrtNRSCgdrLTXQ-xw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=i6jkLYBS0B+81meqnqsJN8Eyoek7Fcu2Ve4gXec2sY8GwKg4jlDwQcoQTiZcty0gzJPEewiPvyjlorJAxHk3jkIF4wT+tUh4wl4vjUT7Ot/juL9DPZIJF14b9yafaU6ePIyyFQaxcCu5kw1oBJ7LExK338RccngqvQJQXMoKI+qfw57FXla16oPhbvC2eALqjs4Yj5wvQKNQSg2lglezN9FzbxLepopbFL1VHk+geT/Y++fBoHrEYdouPKMlkI+APdRgawz123wyQXmRfB2YXo0K1a24Cet7WeHWKTMLwAylOtHn4qwl64npeuqgLAlJzzx74cQ7DQv+T1+4UMpk/Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=YhsLwXJe7nzHQDzW8lEmGU2YmeM3dFTlymztpAfcM+A=;
 b=kLfhVSpNJ6RhDEHGtkw3BmjO2ORHDoSJXtEmGDdqRk0ESxmCLVBln37CXSinHwQndt06bj0fwfJJfmvAh9VEMAy1NCCNu8v553F74NUt9m8y3TCHEeBq10u7kIB+CmtvPvri7Rl4tDNn0j8ZvoeOTeOww2zYWxax8ajGlGDWC2EkrN90Hqrf6d4BKhsf7WGvvUmsWKICYtYmA3ZTzCyg6nIvhRpPuYdIecgbtQncyljd9CnTro9aLIhqK6JlGDC9HhAvI3BaWN9EvzMAdCEFgjf7NG9bCoxEpM9+z6ohIrQMf8IxVgNG2hr8NXPB6kTmDWOJH9eYsFiOVt2U1oCjeA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [PATCH v3 05/11] vpci/header: Implement guest BAR register
 handlers
To: Oleksandr Andrushchenko <andr2000@gmail.com>
Cc: julien@xen.org, sstabellini@kernel.org, oleksandr_tyshchenko@epam.com,
 volodymyr_babchuk@epam.com, Artem_Mygaiev@epam.com, roger.pau@citrix.com,
 bertrand.marquis@arm.com, rahul.singh@arm.com,
 Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>,
 Michal Orzel <michal.orzel@arm.com>, xen-devel@lists.xenproject.org
References: <20210930075223.860329-1-andr2000@gmail.com>
 <20210930075223.860329-6-andr2000@gmail.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <a0a965b2-321d-31c7-4d6c-2a010ba52112@suse.com>
Date: Fri, 1 Oct 2021 15:31:52 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <20210930075223.860329-6-andr2000@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0266.eurprd06.prod.outlook.com
 (2603:10a6:20b:45f::15) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: f2d36d07-70f9-48f9-2987-08d984dfd5ba
X-MS-TrafficTypeDiagnostic: VI1PR04MB5471:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB5471F1F5DF43A7BE4F2C34FAB3AB9@VI1PR04MB5471.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8273;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	mvR/+99kdnx9oIaVNpgoIXon+qtArW3Cvzf1d+orea96FziJjWDZHHb/ezjQn2Pa5U2E1wfOYS6O1NDUkUCBzlbs2oeuu3gmYlyteNApDHdwgsWyAmrJ9xo0rOdaZzpHNs5bLHZQIfpGrt2wv1W/7JY4/MSdnX4n06KmhWFBDJnY4zKIFJ1Om9jSz/QJgXtRPNW3xDtM4uQ3o1wC+9bJvJWCI14w43i7p9hY0HZg64kcZU1fbla4ITuGfedpGSfduMeglgnJbqtqJXwkrnsmSEgXwN42EOoLGA88effULL2e+6yIb5zygy0MyWCaxNHtkISQk3mxu5O96XKKuQJ/dDPKDB7/Ay67RvlLX5lGpFYW4jNkgWFTPkNqAdyycv47/gVnHq9gOli1q2ryeenngYf+cFYgz0q4ijMEqXLK1eFbypT+JesTclCN75cIGaYN+777sNOM0RPTz4DbfKKSa7gax6HDjv73nf7Q+LG7DidSChqtC1SNtYI2J+bqZRnP6CH1f1LtuBezE6WCPnE/8ajsFLigaYzt9BLT6OFZDyPRqS997Y08Yf+OKfWdOuEJXsQ++uNYUjtl8pSszfqYXGccGygDw6m0HiZwvar71/8ycsCzAtkpf0qdYl84TcE+Ptfra5pxD+DzJo3k7R9PnrAAK9wXfvGS6Inv65RYmC7lh9GfNSH0s+HBrREg7YPNFyYi98U9g0QsDhQKUaZ5gzzqpxghXBgTE6IzJwOhiwHFdtlsVNBh8tHY2yeZPg0Q
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(186003)(2616005)(508600001)(16576012)(38100700002)(5660300002)(316002)(956004)(54906003)(86362001)(36756003)(4744005)(6486002)(4326008)(31696002)(8676002)(2906002)(8936002)(7416002)(66476007)(66556008)(66946007)(6916009)(31686004)(26005)(53546011)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?SHR0UG40NTlXN3k2NEt2Tk1oSXd6WUZSRXhXS2wzUlZjUExHQ1pZOE5OQkI3?=
 =?utf-8?B?VFdYUlMyaEE5cmJRUEFyQ24yTnh5QnFQaUNLbk5oa3M4TzFyRUVlQWNSTWJk?=
 =?utf-8?B?ai9hai9aaE1sRmlRcTJacnZpdUF1anNMNEp1RXVYK2ZUVWJBTVA1SEpNVE5k?=
 =?utf-8?B?TnRjUnlHNnlxUno0blVNTmtHb1dIQVdSTDlhaS9vUjE4UlM4b3hObTRMVUZC?=
 =?utf-8?B?NVBzNWdtNEVIU1h2Z014eXZXeGtveHdMN2kySUVxVlVKa3c1c05nb2w0M1lM?=
 =?utf-8?B?aHJ6bm1iOVpMTlBOOGNUTEhoY1dYV3A4OGVuUkVPbEN0YWFWTzgwSlplUTVu?=
 =?utf-8?B?b3ZwU0o2SzFibFh5T3EvNithWkpSUTJWMUJaUEYya1FuWEVhWFVQUjlteEc0?=
 =?utf-8?B?ZG9pYWx4dDNBWmUwSkM1YmhMbmpSUFQxdUdiM3VUUDhLWCtoQ3Vab2lWRkNR?=
 =?utf-8?B?K2RUQzhnaGxPM0MxcWVWdGUxdTZIdzNoTUovY0FyTmZWNzRHVUZud2xsc2o5?=
 =?utf-8?B?aGptZlhWWUZRM2YwbmpyWmRJV05ocDBSdDhWT0V1VEZPSlVmemtOOGkwMEdE?=
 =?utf-8?B?NUZ6RmRuYk5ZRzVvcnFWL1NidG0vSVJ2M1ZPT2pNbWxpd29mVSswdVJmajd6?=
 =?utf-8?B?UWdnQzZhN1pwT3NGVktualY3ay9VTk5ObGVhbU9CMk1vb2VEU2dMbk5UWlJo?=
 =?utf-8?B?ZzFLRTVQSU94WElleFNCd3kxa2pkMEtOWEhqVjFyZmlwNDFIRUgxdXFway9C?=
 =?utf-8?B?ck1HSFBLYkhvQk9ydXlYbXhuL0U4cGQ1YXNSZS9DUEtKVjNwQXFhVTdNb3p6?=
 =?utf-8?B?Vzc5Nm43a2wrUGFVVU9jQjF0TTdmeEVrZG54dFZYUWUwRkJFS2FKYmFkNHRj?=
 =?utf-8?B?RG9ZcXM3TXdsbDRHUy9hQXB3c2wyVVdjQXRKOXVheXcvTTRCQVJNRnZqekdK?=
 =?utf-8?B?K1Q5NmhFakJYMmZKL1dIcTJiMTFZVHY4NkE2alBLT3VGTm9QTitDQi95WjA3?=
 =?utf-8?B?V3VERllJZDFQVTJsSXU2SXhxYWdKTExjZEU0NFlhb1p5QnZWRVlIUTR6c01R?=
 =?utf-8?B?T1VFRWtTUFJ1S2FIMTQrSFNWMGZjdlIvbkdNK1IwQlVXaWN5ZTBwcmY2WXpL?=
 =?utf-8?B?eFJDOFlqZUljMnRLWFNUeERTQzZycmQxOG5ZelhOYkVaQkJEK0cvVmRKNkVX?=
 =?utf-8?B?L1dscTd4SU1WVVBuRmViTllZY0dYSXlPQkEydHRyS0h6dVIvS25ZTEpsaFhX?=
 =?utf-8?B?V1IrRXJ5ZEJVdWoyK0VzQm1ON2dWaXNYcndocGJ6Rm5vLzZYN2dGYTNsSWdB?=
 =?utf-8?B?ZGVmb241dkc2Wm1WTkttbWtrMUJDeW5NT1JqUjJidGJiR1NuS2xNNUVNUU95?=
 =?utf-8?B?ajIwejFKUmJVbnNNU0ZOMTBDWTY1U0pkbUZDWlVXL2tORXozMEhaZTNEdWcz?=
 =?utf-8?B?eGRRZ0kwQlhRZVlZMEpEOGpRTU4rS1V3dWgzOVV5VnZmNnFmVTVxRHlOUHJU?=
 =?utf-8?B?UHpIRWJkMG5MRlZON01wWVNLRVF5bm1ORldPYjZiQTRlYmgyMXl4SjlpbFBE?=
 =?utf-8?B?NUExYnNibVd5eTU1T3ZSQ25zaUN6cWNPbDB6azQ2R2pPRmpLWWRtQ0VhNVFx?=
 =?utf-8?B?V3pzaHFXU2h4Y1VkRjlLWkZQYzZmY3JYZ0Nabm9zcEFsNE9zS2wrQXVGeXB0?=
 =?utf-8?B?bkpEazVSanBxWldwUUphaTk4Y0ZQVndmUXB0VzZ5SnNid2JEbVl1bWdsRVFI?=
 =?utf-8?Q?NIV5F8fZ1b628Vn25/3kpR+3xUiBZhtZGmY4V4U?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f2d36d07-70f9-48f9-2987-08d984dfd5ba
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Oct 2021 13:31:54.9255
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ccDzjdfIKaSOGtk/aNUtm4pGrHqhsXQd3TV7IkTP6c9MTWebMY5ycZt3mrf5ZYKBJqY6N0xcGQau9GVMQXpmPQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5471

On 30.09.2021 09:52, Oleksandr Andrushchenko wrote:
> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> 
> Emulate guest BAR register values: this allows creating a guest view
> of the registers and emulates size and properties probe as it is done
> during PCI device enumeration by the guest.
> 
> ROM BAR is only handled for the hardware domain and for guest domains
> there is a stub: at the moment PCI expansion ROM is x86 only, so it
> might not be used by other architectures without emulating x86. Other
> use-cases may include using that expansion ROM before Xen boots, hence
> no emulation is needed in Xen itself. Or when a guest wants to use the
> ROM code which seems to be rare.
> 
> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> Reviewed-by: Michal Orzel <michal.orzel@arm.com>

Reviewed-by: Jan Beulich <jbeulich@suse.com>



From xen-devel-bounces@lists.xenproject.org Fri Oct 01 13:38:34 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Oct 2021 13:38:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.200629.355166 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mWIk9-000295-S0; Fri, 01 Oct 2021 13:38:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 200629.355166; Fri, 01 Oct 2021 13:38:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mWIk9-00028y-OP; Fri, 01 Oct 2021 13:38:29 +0000
Received: by outflank-mailman (input) for mailman id 200629;
 Fri, 01 Oct 2021 13:38:28 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=KCT2=OV=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mWIk8-00028s-4W
 for xen-devel@lists.xenproject.org; Fri, 01 Oct 2021 13:38:28 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 7507fe94-6313-4912-89a8-21b46f92ee36;
 Fri, 01 Oct 2021 13:38:27 +0000 (UTC)
Received: from EUR02-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur02lp2056.outbound.protection.outlook.com [104.47.5.56]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-27-UBPy5Rq4PnG7vn_SyT5nzw-1; Fri, 01 Oct 2021 15:38:25 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB4607.eurprd04.prod.outlook.com (2603:10a6:803:71::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.14; Fri, 1 Oct
 2021 13:38:22 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4566.014; Fri, 1 Oct 2021
 13:38:22 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 FR3P281CA0072.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4b::23) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4587.7 via Frontend Transport; Fri, 1 Oct 2021 13:38:22 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7507fe94-6313-4912-89a8-21b46f92ee36
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1633095506;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=kmm97YkAc0S+VpA1HX4CbzpqfCrFhQlyQfEIZZkjp68=;
	b=Tko8oBcJJ3cTt4w4umQjDB+OBWJaRaK6/N123cWv20EgVjHvXMqiTqaJotzoW4HwLKfnFo
	EN5G15j/ZSeLyKj3Rc0R/QDnEXdKZRNybh4hnh34wCL3hmo4ZQEZ0hyLjJ9SzIajfTtewt
	ZPPbwFZujgiyZKp3ebChqL6GDjCUS4g=
X-MC-Unique: UBPy5Rq4PnG7vn_SyT5nzw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=bawwOhO4hek9Kss+TpavW3diqwKvfyE7DNqlsasrAtN6B0Ay4N1l+ICY2rr9HiI5Q0FEvLXMp26gTDmIyuD72M8tvKUiw3ZmRLUvPNPqpBh5NT0SyS/bwMNuxtwzN4wvd8R587VczDUG6eAlqx+lklmVQIAspx8OX7b4ML58x/WQiMgqTl937La2ZaZbFGg6bAQcHXLLsNTh6sYNIBcYBiCGP9KQCZUhA47oGWmyLZYJDj7BX+OsQD1mzsJUo4Nr39AeutUM3VFmn6UnE/wTCQ+8eB00MYyvvr9ZgnQ7+nTgDPlVuGynXKn9gnyLrcvQ0IhdbJppYU4oKBCiA9AqnA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=kmm97YkAc0S+VpA1HX4CbzpqfCrFhQlyQfEIZZkjp68=;
 b=FlQZTl9Iqs6kF7h1M83sItMjkOIMjtWXIDsm9JUCAbSTMksWz1eqU7EuwQaDMJGK5yOIRX1Z4mBfiKGTtdOTiAmn8dW7Uw24exD6k9WcQ6SDiC5wOUdiFDgaQt7ITW+Q5bt/PQAEs+DXq0z/R2RfJ1d+2gnQFEN+tQg7Z2ptfCRielfsTm3b00owrvp6Jv8oDM5T5WDxzvBQL5raCN+0bIohU31GpDnbwiD6JCPvYTwyb5/sHyscvg7vkVWheNvNyHlnDZtutDOmVoZolB3k83GTdzMRIA80clpJuezQhrs9mzQUMPh5FTylo5D4HdTQa1nbNsySnIYZDItttHp6pQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [PATCH v3 07/11] vpci/header: program p2m with guest BAR view
To: Oleksandr Andrushchenko <andr2000@gmail.com>
Cc: julien@xen.org, sstabellini@kernel.org, oleksandr_tyshchenko@epam.com,
 volodymyr_babchuk@epam.com, Artem_Mygaiev@epam.com, roger.pau@citrix.com,
 bertrand.marquis@arm.com, rahul.singh@arm.com,
 Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>,
 xen-devel@lists.xenproject.org
References: <20210930075223.860329-1-andr2000@gmail.com>
 <20210930075223.860329-8-andr2000@gmail.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <39d756cb-6ea1-b787-b5e6-4d88e763feb1@suse.com>
Date: Fri, 1 Oct 2021 15:38:20 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <20210930075223.860329-8-andr2000@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR3P281CA0072.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:4b::23) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: f8dc15ee-7e65-4526-171e-08d984e0bcd8
X-MS-TrafficTypeDiagnostic: VI1PR04MB4607:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB4607D4866D4643B5C25BDCACB3AB9@VI1PR04MB4607.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6790;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	QtL/K4x1tzyPXR+/uANB0eMqa3k6NUIqbBks0eiDm0NTzjH/Uxplw3dfZLHO13qLdEpbILh6X/HMVfsdJorkZxLZTnwJU51WfAfYTMHD7wRBeEDqDrIysZAHtRejyN7OVU6jl7BEkg7E02M94zRGq0pwgodCqz3c2G9F2ohJAzHByQ6I6pI5fXRTQ491q8Wu2AdVE4MTpDWwhcdsxDfgQrShOugMtfHAVUy+fXkj+lqXPpT85nrVPnifFaTKoSwKli0N4yPGLglAyd2d6sX43YUzy4f3O6/O3yXSXgi81JotAmohMKLxH53ZLBZ/FMe7xcb+B/MFYUdJNPiu580iAUJ1uo/L8/kNpI4rqiY/RJgtMTBk1yosld56Iv4Vc0w2WFMs19FvLnI23h842s9cg2y3rEbpLxwHmVKJozeFaWaOYCq5jlXfyyZlXEjNURwbUMenI1t9B+gWWxcE5JwJiwGHmp/lB1cSAfaAZdr+tdhgJvumE7TzszuWEQ/i/1em9YLPE483x7YGoXfOaEJ/fi4xlf+i13OxaXNhTFQwjmC0S/qosQG3Nr+dIRr0dc+ErzsaNy2ncQad8avEO3Hf/XIaY6nyVLE9ex2FAjpdhmcJPS7rG2BDAsf3bLdR7x6+yCfc7eiHxcqbKU5ZiTVj1Hqn+bTUJLk8ufRuNz+YeP23MGiXNXMiW9mY9QgjjcQL3tOrBuHVrtFAVPGmjX7/9l0o9j2nkEn9NddwbaQL0CchSd9RxWjWcxYAEZ3OHATn
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(53546011)(7416002)(316002)(66556008)(16576012)(6486002)(66476007)(66946007)(31686004)(186003)(83380400001)(26005)(38100700002)(6916009)(508600001)(36756003)(2616005)(31696002)(2906002)(956004)(8936002)(5660300002)(86362001)(4326008)(8676002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?bGdidktZVGliMDltdXQ3UmNxR2Y1di9pU3ByNlZOMmdHZEVoN3lsWDdDVkxs?=
 =?utf-8?B?NHdCYi9ueGtMdHBsWG9Mc2MzOVl5MHJYQ0I5ZmFNRUJ5NGF4eU1PTVBoTmdp?=
 =?utf-8?B?b3h6Y3NqQVpMb200TnRuOXp4ZTVTUmFySVJ3VWEvS29rckkrK1NMbzZFeEtM?=
 =?utf-8?B?MmVucU9nNGJUcUZEUHNjbHFUVVFrUzQrRmRjZ0R4TGNkQklsbTFMK2RkWVNZ?=
 =?utf-8?B?Sytvd08zdGFucTZrYmJCNFZlandnVC94UHRjOHNIV1YxUGdXQms4NkI2d09z?=
 =?utf-8?B?a3dyOTFYckhRRFhnOWhscHNrandER051OE9zS1BoL3BKQU03L21pNksrYk5z?=
 =?utf-8?B?VFJVdmZvTllCYWoraFRVY3huYnRjSUhNMjEzSzBFdHB2Qmk0MGh4YW9yWGdp?=
 =?utf-8?B?MWVqejMxekNEcVYwVWVQVjVDUGNGU1JJNzNvTFZ5VitOcktWMXNlbm4rRjA0?=
 =?utf-8?B?aVRGTFRaRHRTb2k5TzdkWnN4SjBIQzBMb0YvSk5ETStHSTdaeHBXeXllSGcz?=
 =?utf-8?B?VjE2NWlmOGpXMUJSQVU1a1pzelU2d0IyR0JiQkdUQ0ZnS2JRWHlsVjEwb2Ra?=
 =?utf-8?B?K3NFU2Y3cUkyL1N6SllEVWZYRUliaUlsWU5obVNaaTZIRVZ4YklhTTJ0WE1B?=
 =?utf-8?B?US90SVNhYUpacHJOMVZYaTRlOXpyRXlOV3N6SEU3d3FtRXFBb2crRXl1dzRk?=
 =?utf-8?B?OGJXOE8vdlZ4dDZ0cWxVbndudWlJYWVWQXNqTVJoLzBNR2JHSytJWElScmVQ?=
 =?utf-8?B?OHhCTmk2UUlHdnlrbTRScUNDVm1wcUIxd1JrQXdoQXQ1UmM3S1BETk1JME1J?=
 =?utf-8?B?Q2hzOHBHWlhPbkM0dHNSRzBXUy9wY2Q5N01YTlZxSnN4S2l2a0ZoMTk2SmlS?=
 =?utf-8?B?Zm1lM09iazFva1l2dGl0R1dFU1BLaTRrOWdoMlVkbFc5TnBrUFFCNlkyV3V1?=
 =?utf-8?B?T3JacFdvUVNBZEJxVFZJdVZzN2ZDV2ZpQThTK3ZyS0NBQitzQ0grb0pMdHVT?=
 =?utf-8?B?T1k0UXJDSmNMVlBld3Y1cjRQaXJLK3BiRmlCeEh3YVk4WkZCZ1ZuaDEzK09E?=
 =?utf-8?B?SVJmcVlzcWtyajYyTFRldGZ2UkhjWXFtbjVHamxxZGJEVGNUajB6Y2xEOHdL?=
 =?utf-8?B?bG9ydGhwSVVNTXVQMVA1amdOaVJlcWY4WThWOFhlTGdsa3ROeDZRUDVkR1dr?=
 =?utf-8?B?YUZ1RDBTTXNmd3VDY0pkR0E1Q3RDS1czeWFrRU9mbzNxanJoT0lyM3p1SzNY?=
 =?utf-8?B?S2xqYUJzYURseTB4Q0sySVNUWkhqK2IxQWhkcFV4ZUoxbHI2cW5neEtCZ2ZG?=
 =?utf-8?B?ZUNqZmZOMVJDWDAwdnJ1RDBKTGl4SE55NlZrNUVZbTJrbzY1NWxTb0hxVFdy?=
 =?utf-8?B?RVdEU09UM2lteGYzVlRzdmZPTEtLcjJzcHkvSXVncVFOaXpSVk5UMXFicEcy?=
 =?utf-8?B?N1F1TjlodS8zY3I5RUcvT3RoeGFVdXJFamJMR1VXY0llVmVsMlh0WHFiV2hS?=
 =?utf-8?B?aU1WNWhpL0FyNnU5VUdZbXVlNWxmei9lUWd4UFVZNHltMGFSMFJjMWVodlJp?=
 =?utf-8?B?bFdnWWNSUlNKNjYrRGx2YkdyemI0N0R5N1dQWGlaZ1loU3R3L1QyNUdrVXV2?=
 =?utf-8?B?QXRuMGhGRzkzSlE3c1hOUEpiTytxa2RFRldVeVNBYW5KeE5rTHJQMWJpWlJG?=
 =?utf-8?B?SUFpWU9sMlhiYkIyeWx1SWZRZXl4MlBKMmhZVkY4dkF4YU1oc1hrK2lTenV1?=
 =?utf-8?Q?CS8PpHE2fToK+Yiyd7KquAJ6SZETntBggOcEGvi?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f8dc15ee-7e65-4526-171e-08d984e0bcd8
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Oct 2021 13:38:22.6934
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: qwX+jazrGSBMTuiVlbOKq4DFQHhLEcEgC3XtzzJ+AVJIU1vJxZV5rAFQMWSuJ8MFJgWVnLRgT1vrb95olYMPvQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4607

On 30.09.2021 09:52, Oleksandr Andrushchenko wrote:
> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> 
> Take into account guest's BAR view and program its p2m accordingly:
> gfn is guest's view of the BAR and mfn is the physical BAR value as set
> up by the host bridge in the hardware domain.
> This way hardware doamin sees physical BAR values and guest sees
> emulated ones.
> 
> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>

Just a couple of nits, as I remain unconvinced of the rangeset related
choice in the earlier patch.

> @@ -37,12 +41,28 @@ static int map_range(unsigned long s, unsigned long e, void *data,
>                       unsigned long *c)
>  {
>      const struct map_data *map = data;
> +    gfn_t start_gfn;
>      int rc;
>  
>      for ( ; ; )
>      {
>          unsigned long size = e - s + 1;
>  
> +        /*
> +         * Any BAR may have holes in its memory we want to map, e.g.
> +         * we don't want to map MSI-X regions which may be a part of that BAR,
> +         * e.g. when a single BAR is used for both MMIO and MSI-X.

This second "e.g." seems, to me at least, quite redundant with the first
one.

> +         * In this case MSI-X regions are subtracted from the mapping, but
> +         * map->start_gfn still points to the very beginning of the BAR.
> +         * So if there is a hole present then we need to adjust start_gfn
> +         * to reflect the fact of that substraction.
> +         */
> +        start_gfn = gfn_add(map->start_gfn, s - mfn_x(map->start_mfn));
> +
> +        printk(XENLOG_G_DEBUG

Do you really mean this to be active even in release builds? Might get
quite noisy ...

> +               "%smap [%lx, %lx] -> %#"PRI_gfn" for d%d\n",

%pd please in new or altered code.

Jan



From xen-devel-bounces@lists.xenproject.org Fri Oct 01 13:56:33 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Oct 2021 13:56:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.200637.355177 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mWJ1W-0004Wg-BG; Fri, 01 Oct 2021 13:56:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 200637.355177; Fri, 01 Oct 2021 13:56:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mWJ1W-0004WZ-8K; Fri, 01 Oct 2021 13:56:26 +0000
Received: by outflank-mailman (input) for mailman id 200637;
 Fri, 01 Oct 2021 13:56:25 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=LCz3=OV=arm.com=Luca.Fancellu@srs-us1.protection.inumbo.net>)
 id 1mWJ1U-0004WT-Q9
 for xen-devel@lists.xenproject.org; Fri, 01 Oct 2021 13:56:25 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com (unknown
 [2a01:111:f400:fe0c::600])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id b8e63f10-7398-436f-a887-1718033ed6ff;
 Fri, 01 Oct 2021 13:56:21 +0000 (UTC)
Received: from AM5PR0202CA0007.eurprd02.prod.outlook.com
 (2603:10a6:203:69::17) by PA4PR08MB6141.eurprd08.prod.outlook.com
 (2603:10a6:102:f2::14) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.15; Fri, 1 Oct
 2021 13:56:19 +0000
Received: from VE1EUR03FT041.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:203:69:cafe::87) by AM5PR0202CA0007.outlook.office365.com
 (2603:10a6:203:69::17) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.19 via Frontend
 Transport; Fri, 1 Oct 2021 13:56:19 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT041.mail.protection.outlook.com (10.152.19.163) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4566.14 via Frontend Transport; Fri, 1 Oct 2021 13:56:18 +0000
Received: ("Tessian outbound ab2dc3678fa9:v103");
 Fri, 01 Oct 2021 13:56:14 +0000
Received: from abe9f799f279.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 E8428BAF-6CB9-476A-8657-2A04D795EB55.1; 
 Fri, 01 Oct 2021 13:56:03 +0000
Received: from EUR03-AM5-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id abe9f799f279.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 01 Oct 2021 13:56:03 +0000
Received: from PAXPR08MB6816.eurprd08.prod.outlook.com (2603:10a6:102:130::10)
 by PAXPR08MB6544.eurprd08.prod.outlook.com (2603:10a6:102:157::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.15; Fri, 1 Oct
 2021 13:56:01 +0000
Received: from PAXPR08MB6816.eurprd08.prod.outlook.com
 ([fe80::c1b4:db1c:376f:b697]) by PAXPR08MB6816.eurprd08.prod.outlook.com
 ([fe80::c1b4:db1c:376f:b697%9]) with mapi id 15.20.4566.015; Fri, 1 Oct 2021
 13:56:01 +0000
Received: from smtpclient.apple (82.8.129.65) by
 LO4P123CA0268.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:194::21) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4566.17 via Frontend Transport; Fri, 1 Oct 2021 13:56:00 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b8e63f10-7398-436f-a887-1718033ed6ff
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=j9eHqhA/5n8OoLHibObMnB8sQbWbmRiNVdzckY4JUJM=;
 b=k5Bbnvmhsflx3tBQrj0UA/pyt6+C0GDSaZOC/faQELYAyvKkYNl7Iydr5k8GqURZP/1bSiwQUK1VmB9JpIQTRxQlcfR+9SEDNWRbI8A/VtuwdzLwS/95GVtb8JzF653N2AYDGiazVhzgXqV///FCTRHQDw7nI1vrlHHHZBLSWvk=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 16236d1882e8c77d
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=f3l0wk/JQxmUc9olb0vVjn0pIAvEAcm99xVxdgwCWpnj9fyz2ecNqFOB59cx9FaEIcqSZASdKSLj/1LoFMYn//Sbi47MszjoD0h75Cy47VCaH24ZhyiizOLpQ9QO2cy4CZKhToJkMd++OReMG+8yWGYxDp8JdKb563hsyUYnPCWeQoUcfNl2599Rb+4mcnnufYoBdMSivhWhX2OktFbYqmnPhPqwntWfeV1TqcY56AZzNP+HpBdx/d2cPXT6LXiClNVCT6YM085yvVbdzThhdNeXfb+n1E/C590j26PAMM/FQ7R9H1ogZG9becdMpPzISNUg11SUndOc423ShWNZQg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=j9eHqhA/5n8OoLHibObMnB8sQbWbmRiNVdzckY4JUJM=;
 b=YP9C6mLWmet1Ft4/9R45TpGPdVsQkYuSo8hEHEZNwiBq8/V2k6lodo0fetM9dBlalaRJGtuUp4umy8ot8KhLPB84UpernLxT1Elo0ata4qBScgfBs5YELDPtBu7isJQdXfy0BtyRZ6hf6XKIzUQgPSkGDZ5g/VvrK+Ye745ybhOJXQuCO8eaPVbSNM5T80mPLC2s3+UanCTxChgiCt3XGO1PHUC9qql6EtI3Nx113fXFPQOYxlzfHG+O/5NXlNvnzJEjDf82N2OUE3OcJlpcCuofdkmuuRk9QBSeORA7okmgKMlpiMPcRoQ4VVsO0HAP1a9H+9pWWepx/KC+uvYdXw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=j9eHqhA/5n8OoLHibObMnB8sQbWbmRiNVdzckY4JUJM=;
 b=k5Bbnvmhsflx3tBQrj0UA/pyt6+C0GDSaZOC/faQELYAyvKkYNl7Iydr5k8GqURZP/1bSiwQUK1VmB9JpIQTRxQlcfR+9SEDNWRbI8A/VtuwdzLwS/95GVtb8JzF653N2AYDGiazVhzgXqV///FCTRHQDw7nI1vrlHHHZBLSWvk=
Authentication-Results-Original: suse.com; dkim=none (message not signed)
 header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
Content-Type: text/plain;
	charset=utf-8
Subject: Re: [PATCH v4 2/3] arm/efi: Use dom0less configuration when using EFI
 boot
From: Luca Fancellu <luca.fancellu@arm.com>
In-Reply-To: <2fa4be34-9c69-21cb-632f-f566caf622ca@suse.com>
Date: Fri, 1 Oct 2021 14:55:54 +0100
Cc: Bertrand Marquis <bertrand.marquis@arm.com>,
 wei.chen@arm.com,
 Stefano Stabellini <sstabellini@kernel.org>,
 Julien Grall <julien@xen.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Ian Jackson <iwj@xenproject.org>,
 Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <6DFF05BA-8250-4C6C-86DF-67997F8DAD46@arm.com>
References: <20210930142846.13348-1-luca.fancellu@arm.com>
 <20210930142846.13348-3-luca.fancellu@arm.com>
 <2fa4be34-9c69-21cb-632f-f566caf622ca@suse.com>
To: Jan Beulich <jbeulich@suse.com>
X-Mailer: Apple Mail (2.3654.120.0.1.13)
X-ClientProxiedBy: LO4P123CA0268.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:194::21) To PAXPR08MB6816.eurprd08.prod.outlook.com
 (2603:10a6:102:130::10)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 75f43dbf-652b-4a5c-6a41-08d984e33e7a
X-MS-TrafficTypeDiagnostic: PAXPR08MB6544:|PA4PR08MB6141:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS:
	<PA4PR08MB614130CE7B2A71F7F48408BCE4AB9@PA4PR08MB6141.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Oob-TLC-OOBClassifiers: OLM:457;OLM:457;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 Kd7Rga7ZMG4v2wESccQhuQWVlwmvB33+2G6eNATF8s/Ax6EDNINup5M5TDBOC6ZK6oCoRESYSnssmAzGyEmffitx/hUo47cOnnC7Hr0RRHX4bstdX0Fhu/x9KVnVxkGbyPmFd/mMDhJTBVhiiz3P4jZT3sbKBaH5eiYZDKasv1fi5YcmknZ4tpVIfzQp78wdw6sKnf6OKpb+9XOD03Oem8kzhjpPpZBBCPy6xrV7/tq2BC+kVausYUCQwyRHoXG32kA2dkK8gWx9evM+8wXYDOSKnW8YBAvpues8Uh86TlxhnOCmbjzHVyR/uYIKD2rPxt9sHBmwnipLDuDlOe8EpG/w7zmDGfJ8k7xJZdqpFSztr/wg8Sii+DYtrCibcBnXsNgf3UnVRg57I082ZyBE5VrPai3WE0Bym/ifzqEHntuH1Tvu9057s3RNlMfBX8fFOSbTvi0CxY+MMTE6TyqxferOQ1HKXqyzLCDi57VJLCS5oLUl7aKUYF0e/2s7CSGMiSbhAkTfybwRuEPoPtdG8I0qqt9F886gFrgbUYymGOZ12VnVdFC+J/Mx3PLS+i8p8wehzi/Sy8WXctwclpXw2jS+UwimaVizpRtNjMwTqlL6iCHx7yhI1xz2IEeO5/ByqZ6P8T4LchBX6oRBmz2/Npkk5UY4miWl6QLhmNhQOtr7K29tji9SCFz12EL+7/SWHoZw4GrAZDRu0dr9+QZVqSDEzCOww2pGamkbVYMrO9FXIOnIEmvXrhUU5BkD3LTre7RUzus86LLOWpfA7P7y1A==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB6816.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(956004)(6666004)(86362001)(26005)(2906002)(66556008)(53546011)(66946007)(5660300002)(2616005)(66476007)(6486002)(44832011)(33656002)(508600001)(54906003)(8676002)(6506007)(4326008)(36756003)(316002)(186003)(8936002)(52116002)(6512007)(38350700002)(38100700002)(6916009)(83380400001)(32563001)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6544
Original-Authentication-Results: suse.com; dkim=none (message not signed)
 header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT041.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	3845f063-00e3-412a-f59b-08d984e333ee
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	RvsjHjNbXcMBMEKqsLXgbtDEwcT/pfkG/C1V7gn9wn4JGhfD940deBEa02FKQ1Gv7OjdF9k6RGF+gKVV1gioDb0qRc3GUDPOB7lVn/FAqaeC574/cLlk1DoD6WN7Ur5q4k5yMZd0KddPx9ES82FnTqCAWS3v3xmC975i3sufGqP9xvdzvKn5Gamxef8EuMCU6tHhuTO2V0iOJ2fHVZ33Ogrj0ocATk7Ujw6FQ629XDzP8Ve020g6hPRP+Oe1dxdUFC2fZQ/Mjw0Bi7vQbi+vzRbZ0ZpC/K7YLnysoUhCgwpW3iMH2AM53MkFfful0WjiQzSFft3UM/y1xzocg0/bj1qUMEJyvwwtX95DfC+1m6Ja2Pm7oFqcU8qLZ6FvbwWvROUT7EPRZyylD/Iw1RR/9cbMVHaHewEepdndQiWQEcjg1B7iRHd7NwdwVt1krB22PBDtZp2u7UNJ+WARiehHe0+63LaAz3EU5siAfbqTnXxUnv12aFsjizBUqwJSlagl96cuvBAohXFjyhyf5QpuchZxciX/BVFpwmMkDRCFrm+rIZNkfWD1JpwV2aCuJ+gBfFupaq2kNhDhFVpLHGNSr9j+OJsogRThvaLM/UrvaK311PfoZ4QzyL6dXRNeOwk+RU1LXIWQ6rS/X6rQ4DIHHc6dvKeLCYqYzVUnSqCvGU6T0hCHvLBjk8UVfowWXJLCcQzvHIGUrMf8MrlcyWE1j2IrQ9ti0sCiEE3m/amgItE=
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(44832011)(6666004)(186003)(47076005)(2906002)(33656002)(4326008)(36860700001)(6506007)(956004)(26005)(2616005)(86362001)(8936002)(336012)(82310400003)(6512007)(81166007)(36756003)(70206006)(316002)(70586007)(356005)(508600001)(6862004)(54906003)(8676002)(83380400001)(53546011)(6486002)(5660300002)(32563001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Oct 2021 13:56:18.8939
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 75f43dbf-652b-4a5c-6a41-08d984e33e7a
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT041.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB6141



> On 1 Oct 2021, at 12:02, Jan Beulich <jbeulich@suse.com> wrote:
>=20
> On 30.09.2021 16:28, Luca Fancellu wrote:
>> --- a/xen/common/efi/boot.c
>> +++ b/xen/common/efi/boot.c
>> @@ -1127,15 +1127,17 @@ efi_start(EFI_HANDLE ImageHandle, EFI_SYSTEM_TAB=
LE *SystemTable)
>>     static EFI_GUID __initdata shim_lock_guid =3D SHIM_LOCK_PROTOCOL_GUI=
D;
>>     EFI_LOADED_IMAGE *loaded_image;
>>     EFI_STATUS status;
>> -    unsigned int i, argc;
>> -    CHAR16 **argv, *file_name, *cfg_file_name =3D NULL, *options =3D NU=
LL;
>> +    unsigned int i, argc =3D 0;
>> +    CHAR16 **argv, *file_name =3D NULL, *cfg_file_name =3D NULL, *optio=
ns =3D NULL;
>=20
> Are these two changes really still needed?

Yes you are right, I will revert back them.

>=20
>> @@ -1285,14 +1286,13 @@ efi_start(EFI_HANDLE ImageHandle, EFI_SYSTEM_TAB=
LE *SystemTable)
>>             efi_bs->FreePool(name.w);
>>         }
>>=20
>> -        if ( !name.s )
>> -            blexit(L"No Dom0 kernel image specified.");
>> -
>>         efi_arch_cfg_file_early(loaded_image, dir_handle, section.s);
>>=20
>> -        option_str =3D split_string(name.s);
>> +        if ( name.s )
>> +            option_str =3D split_string(name.s);
>=20
>        option_str =3D name.s ? split_string(name.s) : NULL;

I will use your suggestion above so I don=E2=80=99t have to initialise it.

>=20
> would be the less intrusive change (eliminating the need to add an
> initialized for option_str). Or if you really want to stick to your
> model, then please at the same time at least move option_str into
> the more narrow scope.
>=20
>> @@ -1361,12 +1361,30 @@ efi_start(EFI_HANDLE ImageHandle, EFI_SYSTEM_TAB=
LE *SystemTable)
>>         efi_bs->FreePages(cfg.addr, PFN_UP(cfg.size));
>>         cfg.addr =3D 0;
>>=20
>> -        dir_handle->Close(dir_handle);
>> -
>>         if ( gop && !base_video )
>>             gop_mode =3D efi_find_gop_mode(gop, cols, rows, depth);
>>     }
>>=20
>> +#ifdef CONFIG_HAS_DEVICE_TREE
>> +    /* Get the number of boot modules specified on the DT or an error (=
<0) */
>> +    dt_modules_found =3D efi_arch_check_dt_boot(dir_handle);
>> +#endif
>=20
> So I had asked to add a stub enclosed in such an #ifdef, to avoid the
> #ifdef here. I may be willing to let you keep things as you have them
> now, but I'd like to understand why you've picked that different
> approach despite the prior discussion.

There must be a misunderstanding, your message in the v3 was:

"Every time I see this addition I'm getting puzzled. As a result I'm
afraid I now need to finally ask you to do something about this (and
I'm sorry for doing so only now). There would better be no notion of
DT in x86 code, and there would better also not be a need for
architectures not supporting DT to each supply such a stub. Instead
I think you want to put this stub in xen/common/efi/boot.c, inside a
suitable #ifdef.=E2=80=9D

So I thought you wanted me to remove the stub in x86 (since it doesn=E2=80=
=99t support DT)
and put this call under #ifdef so it won=E2=80=99t be compiled for arch not=
 supporting DT.


>=20
>> +    dir_handle->Close(dir_handle);
>> +
>> +    if ( dt_modules_found < 0 )
>> +        /* efi_arch_check_dt_boot throws some error */
>> +        blexit(L"Error processing boot modules on DT.");
>> +
>> +    /*
>> +     * Check if a proper configuration is provided to start Xen:
>> +     *  - Dom0 specified (minimum required)
>> +     *  - Dom0 and DomU(s) specified
>> +     *  - DomU(s) specified
>> +     */
>=20
> May I suggest to shorten the three bullet points to "At least one
> of Dom0 or DomU(s) specified"?

Sure I will change to:

/* Check if at least one of Dom0 or DomU(s) is specified */

>=20
>> +    if ( !dt_modules_found && !kernel.addr )
>> +        blexit(L"No Dom0 kernel image specified.");
>=20
> And may I also ask to alter the text here, to be less confusing to
> dom0less folks? E.g. "No initial domain kernel specified"?

Yes I will change that.

Cheers,
Luca

>=20
> Jan
>=20



From xen-devel-bounces@lists.xenproject.org Fri Oct 01 14:09:07 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Oct 2021 14:09:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.200648.355188 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mWJDj-0006Ia-HX; Fri, 01 Oct 2021 14:09:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 200648.355188; Fri, 01 Oct 2021 14:09:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mWJDj-0006IT-Dj; Fri, 01 Oct 2021 14:09:03 +0000
Received: by outflank-mailman (input) for mailman id 200648;
 Fri, 01 Oct 2021 14:09:02 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=LCz3=OV=arm.com=Luca.Fancellu@srs-us1.protection.inumbo.net>)
 id 1mWJDi-0006IN-Bk
 for xen-devel@lists.xenproject.org; Fri, 01 Oct 2021 14:09:02 +0000
Received: from EUR01-HE1-obe.outbound.protection.outlook.com (unknown
 [2a01:111:f400:fe1e::625])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id e57c8f1f-8b47-475f-a27e-32ed10c33dfe;
 Fri, 01 Oct 2021 14:09:00 +0000 (UTC)
Received: from DB6PR07CA0013.eurprd07.prod.outlook.com (2603:10a6:6:2d::23) by
 AM7PR08MB5318.eurprd08.prod.outlook.com (2603:10a6:20b:104::13) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.14; Fri, 1 Oct
 2021 14:08:57 +0000
Received: from DB5EUR03FT037.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:6:2d:cafe::52) by DB6PR07CA0013.outlook.office365.com
 (2603:10a6:6:2d::23) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.7 via Frontend
 Transport; Fri, 1 Oct 2021 14:08:57 +0000
Received: from 64aa7808-outbound-2.mta.getcheckrecipient.com (63.33.187.114)
 by DB5EUR03FT037.mail.protection.outlook.com (10.152.20.215) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4566.14 via Frontend Transport; Fri, 1 Oct 2021 14:08:57 +0000
Received: ("Tessian outbound 173d710607ad:v103");
 Fri, 01 Oct 2021 14:08:55 +0000
Received: from b273526e1d15.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 4A1060D8-A6D0-4CD9-B123-5C7C4CA110AD.1; 
 Fri, 01 Oct 2021 14:08:38 +0000
Received: from EUR01-VE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id b273526e1d15.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 01 Oct 2021 14:08:38 +0000
Received: from PAXPR08MB6816.eurprd08.prod.outlook.com (2603:10a6:102:130::10)
 by PAXPR08MB6672.eurprd08.prod.outlook.com (2603:10a6:102:137::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.15; Fri, 1 Oct
 2021 14:08:33 +0000
Received: from PAXPR08MB6816.eurprd08.prod.outlook.com
 ([fe80::c1b4:db1c:376f:b697]) by PAXPR08MB6816.eurprd08.prod.outlook.com
 ([fe80::c1b4:db1c:376f:b697%9]) with mapi id 15.20.4566.015; Fri, 1 Oct 2021
 14:08:32 +0000
Received: from smtpclient.apple (82.8.129.65) by
 LO4P123CA0470.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a8::7) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4566.13 via Frontend Transport; Fri, 1 Oct 2021 14:08:32 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e57c8f1f-8b47-475f-a27e-32ed10c33dfe
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=7W0V/lf165q/NgEj5qNLR9RyPxMNVprhjpZD5BqeGoU=;
 b=4xYVFu/YsGcnsFT63CZ1xoZ1G0lSNYzuauYn+S1/GbEV2JhpZGc1yn3lfh2l4jfdt22z9wqliPZ5GOxJewpht1TLy09vSSO8fUAaX2xmuQuQ8jIyBeGlAkdTmi3VMDJhvWKXHXbAJn2cqb83KvhOGvjOQQ9IkBDVJbpcVy/QsUs=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.33.187.114)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.33.187.114 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.33.187.114; helo=64aa7808-outbound-2.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 61ab3b9f47b3317d
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=P1AKCzhm7ACNSwCHKB8Q6RNunfF/RBawi39gnIRVMtlKGjVczsE/9P3TyDU8mYFX9FlYJLWhp1ylpf2/wVK2+KJHyRSUJH4SamXIVHdp12KSyCj9l+/lUdGymSFidqAO+QOta2cerXnVJK3BTMu0r9m/T6DNu61eLNeE5oL/DjS/1NJx+F6zS0ZXpvnPf62VqtmxPxXDRuJ2QdFA7X8i7alJk0FeUz5sTyXR/7WG56R16iZaJ9q2hylYdOe0+Xn3uhTCSJYWsF2IBv6uD7Msrl4ihyKYEOL7wiWdgrQSuyA1cooqjF284+7CIQIBo95oLf7AMPY7sW+lazQrCqe7nA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=7W0V/lf165q/NgEj5qNLR9RyPxMNVprhjpZD5BqeGoU=;
 b=el17IGTIJ5nSZZcDUrbGYP8IGye56QjNwq9fQI/V2ZIo2Cp3m5mv01vum2X8fSfKIPbiydfrOa7rHmW/HxdR0FhBdZij9Rj1n6GjoLe5StewPYxPkDGz0JETa42JiYtzFgYOZ5YEkLOaYmTxIwUeBsdDAKvrRDV3OWE0iRrn0mPb3n66pfhxukEFj8djMkWci4+XedYLF3pEwueJhu4QzQuSGB3WwbePd2O/1bH4OtpB7Z0EPd5rIpGqD0j0jWVJoncHmKswP/MhuYP4obIN31gSPSroifXX/c1DjD/uiaC86qK0CgpX8olO+YNWuNqlYcG5FpKeyebykhEbFk5X5g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=7W0V/lf165q/NgEj5qNLR9RyPxMNVprhjpZD5BqeGoU=;
 b=4xYVFu/YsGcnsFT63CZ1xoZ1G0lSNYzuauYn+S1/GbEV2JhpZGc1yn3lfh2l4jfdt22z9wqliPZ5GOxJewpht1TLy09vSSO8fUAaX2xmuQuQ8jIyBeGlAkdTmi3VMDJhvWKXHXbAJn2cqb83KvhOGvjOQQ9IkBDVJbpcVy/QsUs=
Authentication-Results-Original: suse.com; dkim=none (message not signed)
 header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
Content-Type: text/plain;
	charset=us-ascii
Subject: Re: [PATCH v4 3/3] arm/efi: load dom0 modules from DT using UEFI
From: Luca Fancellu <luca.fancellu@arm.com>
In-Reply-To: <21f9af33-0d09-fb2e-95fa-f4c5796671ca@suse.com>
Date: Fri, 1 Oct 2021 15:08:26 +0100
Cc: Bertrand Marquis <bertrand.marquis@arm.com>,
 wei.chen@arm.com,
 Stefano Stabellini <sstabellini@kernel.org>,
 Julien Grall <julien@xen.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Ian Jackson <iwj@xenproject.org>,
 Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <29BFC7F8-5173-4395-952C-FFF0E1F4C9FB@arm.com>
References: <20210930142846.13348-1-luca.fancellu@arm.com>
 <20210930142846.13348-4-luca.fancellu@arm.com>
 <21f9af33-0d09-fb2e-95fa-f4c5796671ca@suse.com>
To: Jan Beulich <jbeulich@suse.com>
X-Mailer: Apple Mail (2.3654.120.0.1.13)
X-ClientProxiedBy: LO4P123CA0470.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:1a8::7) To PAXPR08MB6816.eurprd08.prod.outlook.com
 (2603:10a6:102:130::10)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: bac63946-cbea-45fa-67e7-08d984e50278
X-MS-TrafficTypeDiagnostic: PAXPR08MB6672:|AM7PR08MB5318:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS:
	<AM7PR08MB5318B3FFA65A845B9F991CADE4AB9@AM7PR08MB5318.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 IPcJv74lL2a2BTkwwiHgHPSs9r++E2r6xJeUF8QWqQJzCqH8DmtpnNZ0i0QFn15DR4aAWz47lxd9dGWkap+vTvexuHrpoAi6UaTt/mlugW7ImxrLM2DVspAvBH5q/hQQlJvj3Z6ScmECTY5zj4eHZeglBZmf/Jdk4KU/TGzFcm2DVFyMNyfZ+qqLM8p+kHUyp6AoKBletaEkPkvJ7H9rPyOAbr++7llffUX9CJzpDIhNg7bnbYivY/0rR93cztBmPe46BeKtddYQrDET/jfQhM0/jFWDPLh8qlWX0vI41mb7G54hZanc9i6/jFqIpHrPpAb5k3kOh9EAq1m9ximuwp1oo0VaPJhTCsZ7x4JX3ned4sCGk/lnmFJVMUibtsmZDSz15fzUTWVC2LtE/LYxXlUsRMhb37Q4DnOVYJqTdaO0V+4TNCS4UHH1T6v7YEBQd24l15hOrY9A33nErPOkUf1Y9Kf/x2nlt0pHuDg6QxibijWjm0zHRhfjmHOxeuNq5+1sOowyNMzGtyJ0B72DwvYM/suXbDO6LzVruF/utvgFmkK+Ux6Qo7Clt9mE9vBgZ9JLtaUb8gwo9IdJgzWL/MSJmsXI3Jd+w0lX1o1mSmYtHRzjI1M75nXiM/08JOWk07dejZ9cScURc/YT3cf0SG0POfIi7gstCAK1DcHYfP6UQlXjJx0Fd/8weE7bhxcFzH4tSn3uc4Ad7/OGowlhNnx/p+Q0+DtkRGVue9GINCo=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB6816.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(316002)(6486002)(8676002)(6506007)(33656002)(8936002)(53546011)(186003)(54906003)(6916009)(66476007)(508600001)(2616005)(956004)(26005)(83380400001)(5660300002)(38100700002)(44832011)(36756003)(38350700002)(6512007)(2906002)(6666004)(66946007)(66556008)(52116002)(86362001)(4326008)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6672
Original-Authentication-Results: suse.com; dkim=none (message not signed)
 header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT037.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	3c6b1035-211f-4591-e96f-08d984e4f3c2
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	kE5cteSDJ5oYoz+OzQ9OWVrZ3tTTtsy92Lf7H4is1CeeTT8W46S3tn+/qCChnv/D5oFPY8N+8q1rqeCMldGJ7suiBnTSlSYWZZMACrhR1FACYzIUYBvcOLdDIB+GhDkk+YKFeLQGx6zAfe/NYfZ/wai+5LWxq//bPHaFbh+d2Ju6j27keuLJSehvaacfWOgI1iE0LDHiMUADRz7uJ2GsCHem644pWNxbxCwUfLFKa11vwGoRkDZTTrlZMnzyhZUGErqhDSEihpejt7LtaqtOJEHL36QoZltO4X7FzW/Ub0shEuP4uYaxwYVFQ8+V0rjIbKZbG3Cq2nIA9JFwxLOloxXg6D3bnEZ6AXC54GlCJkxE+I+VG5UvUpjTlGVqLeG3OywbrHnJz+1/uuRLJAe1rJj4VJMdKbvB6q7fkHwRqcA1qgq41FbwqwUGI79hoQSJVMdsKh1wgyz3UHwuD7hWKe4HbIC3mFnnbG6JEdWsQB5T8Y4n6+YRWuudX380jiHCoWUfzBNrRR3MPxC+N3vezXK73j5AE8cmYLoSrLzstqA0c+0MVycsFmRFoUDcl+0w0JmoCYDiumgHhA+lhsU1KBXT8JnTvHlcdwys9VOiJuCMqUu+9Ym7C3pDjN5QenJWHCqq4HC+g6VpNsUaAd8PfydxTDiOXOgK49E1hSXXskUvR1YBhmoc6X3uwglzTyJwP6oBnInNSR4PtfFHC3EU+A==
X-Forefront-Antispam-Report:
	CIP:63.33.187.114;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-2.mta.getcheckrecipient.com;PTR:ec2-63-33-187-114.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(33656002)(316002)(26005)(47076005)(36756003)(36860700001)(83380400001)(81166007)(82310400003)(44832011)(54906003)(6506007)(53546011)(6512007)(6666004)(70206006)(2616005)(4326008)(508600001)(186003)(336012)(70586007)(5660300002)(8676002)(86362001)(6862004)(356005)(956004)(6486002)(2906002)(8936002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Oct 2021 14:08:57.3388
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: bac63946-cbea-45fa-67e7-08d984e50278
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.33.187.114];Helo=[64aa7808-outbound-2.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT037.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR08MB5318



> On 1 Oct 2021, at 12:16, Jan Beulich <jbeulich@suse.com> wrote:
>=20
> On 30.09.2021 16:28, Luca Fancellu wrote:
>> Add support to load Dom0 boot modules from
>> the device tree using the xen,uefi-binary property.
>>=20
>> Update documentation about that.
>>=20
>> Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>
>=20
> Acked-by: Jan Beulich <jbeulich@suse.com>
> despite ...
>=20
>> @@ -1385,6 +1380,17 @@ efi_start(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABL=
E *SystemTable)
>>     if ( !dt_modules_found && !kernel.addr )
>>         blexit(L"No Dom0 kernel image specified.");
>>=20
>> +    /*
>> +     * The Dom0 kernel can be loaded from the configuration file or by =
the
>> +     * device tree through the efi_arch_check_dt_boot function, in this=
 stage
>> +     * verify it.
>> +     */
>> +    if ( kernel.addr &&
>=20
> ... me still being a little unhappy with the inconsistent use of the
> union fields so close together: This one is now consistent with the
> one visible further up in context, but ...
>=20
>> +         !EFI_ERROR(efi_bs->LocateProtocol(&shim_lock_guid, NULL,> +   =
                                        (void **)&shim_lock)) &&
>> +         (status =3D shim_lock->Verify(kernel.ptr, kernel.size)) !=3D E=
FI_SUCCESS )
>=20
> ... is now inconsistent with this use. But yeah - read_file() is
> even worse in that sense, except that there the different uses are
> for specific reasons, while here the only requirement is to satisfy
> shim_lock->Verify().
>=20
> Please feel free to retain my ack in case you decide to use .ptr in
> all three places.

Hi Jan,

Sure I will do the modification you suggested, I will fix also my silly mis=
take that
Stefano pointed out.

Just to be sure, I explain what I will do:

In the second patch I will change:

    if ( !dt_modules_found && !kernel.addr )

To=20

    if ( !dt_modules_found && !kernel.ptr )


And in this patch I will use:

if ( kernel.ptr &&
         !EFI_ERROR(efi_bs->LocateProtocol(&shim_lock_guid, NULL,
                                           (void **)&shim_lock)) &&
         (status =3D shim_lock->Verify(kernel.ptr, kernel.size)) !=3D EFI_S=
UCCESS )
        PrintErrMesg(L"Dom0 kernel image could not be verified", status);

Do you agree on them? Can I retain your ack to this patch doing these chang=
es?

Cheers,
Luca

>=20
> Jan
>=20



From xen-devel-bounces@lists.xenproject.org Fri Oct 01 14:20:06 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Oct 2021 14:20:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.200658.355199 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mWJOJ-0007ue-Kn; Fri, 01 Oct 2021 14:19:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 200658.355199; Fri, 01 Oct 2021 14:19:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mWJOJ-0007uX-Hp; Fri, 01 Oct 2021 14:19:59 +0000
Received: by outflank-mailman (input) for mailman id 200658;
 Fri, 01 Oct 2021 14:19:58 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=KCT2=OV=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mWJOI-0007uR-37
 for xen-devel@lists.xenproject.org; Fri, 01 Oct 2021 14:19:58 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id a6a6bf7a-22c2-11ec-bdad-12813bfff9fa;
 Fri, 01 Oct 2021 14:19:56 +0000 (UTC)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2058.outbound.protection.outlook.com [104.47.12.58]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-21-PlamOJ8PNa-is6FXeEormA-1; Fri, 01 Oct 2021 16:19:54 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB5472.eurprd04.prod.outlook.com (2603:10a6:803:d3::28)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.14; Fri, 1 Oct
 2021 14:19:52 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4566.014; Fri, 1 Oct 2021
 14:19:51 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS8PR04CA0101.eurprd04.prod.outlook.com (2603:10a6:20b:31e::16) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.15 via Frontend
 Transport; Fri, 1 Oct 2021 14:19:50 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a6a6bf7a-22c2-11ec-bdad-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1633097995;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=EFA3Mz6g9J+y/mj3uFG2Q48UVqwmg78UIH6qNplzTRw=;
	b=aibUWJlJbMATvTK7sMOnRTm5NYvoZ67sHPbCUXm2o45mwLJ2vPaqn8vMUqL7OYuc3WKV2M
	WsTBRz5lL+5/mxnSQ7qjMkFevrpWTFKHHeQO2hbHQOnOCQbKxIthaxCsO9MZDAdbV/dKee
	/E17kwkLzgGkfYptIHb9VcRLtiVL3SQ=
X-MC-Unique: PlamOJ8PNa-is6FXeEormA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=US4KmR/23x7/RbAGbhAagvZfEYpVUl2RhZFeWjyD6CVdBvObkMiH9XgezXaJ6DHHTGS6azuMOZ+10W/1B9lKh0S3G9u17JkqDSacB55JeuY7kkFjg9GlaONEihsWQhkeLHn5qHc/ojtcuW3r7YivxYBxtcGJxaW4VYTqkCY/87AQJ4fOVVIj5eVdsTQGnq2zt9GCfwWVTCapk3mRhqMPmXt0JSR79TuqhhNXEPsCoavz7mXTXEE4HITicaNUF7GVptgTenc6WOXTdFsH572v6Lyf+G60CHbccPem0b0x4e7IlujljfJ1SZjS9A46L6dRUHztPclbPmdQCGezKmNBqA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=EFA3Mz6g9J+y/mj3uFG2Q48UVqwmg78UIH6qNplzTRw=;
 b=NoRGoUOWXuBaIIC6PtOr06B39yyzXAui1WXm23sfvUdsDUzMf/UoRTRzkTXEIL7sELH2Z1E5iimGcfzpKLQbnnzlov7w3IWnZG4CMg71V5ABuP8Bjo7xOx9LoF/+1tqFf3o2iU0cevAMIwoy2vd6g17n9GCBxO6/mFEsDrInHQh/JxKaqYkPlwJzYcUs6+IIATek+M7QEbRJCCee/lb7LEI79TwV6SQe5uEqMfj1Ybqi8a2vA5oSY0bRl6us1Ew/J44MCSi8iuxgVoEzU3PkMXYrHrMCmbaf+eU+J7vDuF0xF3/aY+QCckVUp5tg0KPZvDqP0hYH1X5vZaQRu5poEQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [PATCH 1/1] x86: centralize default APIC id definition
To: Alex Olson <this.is.a0lson@gmail.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>, Wei Liu
 <wl@xen.org>, Ian Jackson <iwj@xenproject.org>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Juergen Gross
 <jgross@suse.com>, Anthony PERARD <anthony.perard@citrix.com>,
 Alex Olson <alex.olson@starlab.io>, xen-devel@lists.xenproject.org
References: <cover.1632512149.git.this.is.a0lson@gmail.com>
 <85b59046315b8a84afa8538aacdea92b19200faa.1632512149.git.this.is.a0lson@gmail.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <d899b058-a201-e2f8-35d2-f0e59ab4bab3@suse.com>
Date: Fri, 1 Oct 2021 16:19:49 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <85b59046315b8a84afa8538aacdea92b19200faa.1632512149.git.this.is.a0lson@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8PR04CA0101.eurprd04.prod.outlook.com
 (2603:10a6:20b:31e::16) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: b7f33d82-b48b-4687-0738-08d984e68876
X-MS-TrafficTypeDiagnostic: VI1PR04MB5472:
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB54727D87AF9392D2DDC606CEB3AB9@VI1PR04MB5472.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	LMEq9kKKPe3Jh/jkmIGoiU+YKznpCevN1qSuxu1mWSwyIRE33jGgNZ5uKPJGs4cEVH6DR3k4lueJbVb266D33+MuJ8/5fKV/u60mFqBNdLyf/ItZkL5m/r8BVC7TCN6uw5/7P7B4ywqlaXPb6b/zmxIZ2qN/++C3DdO80YAb0UF6TkNr1ZGM8/MQcrXeHpUof4bpH65WHTS/VP4nfY3fxAyOyOzEDXrNY+NqEv/gXM9CGh2RaZYFhiGor8cxfS+AUWLTrVCsE7BM72sA3XFax+p1PjLjJMi1siJOlNyojtGKcq8ObkTH79B4TXPjSezXkN2OOE1kGmZutZ+RyQ3r+JcF1Lqdycu1co0AFs1YxUHM2QK8jZczegmZRwEW/4r4fuC+rQwMihJzVqwllMfnHh8VdQLz0ldBUiP+IceUjYaxTiY5HCsf8YLQXmdb38R0XTcaQzaSv3aCI4/UoRa+nUKTzzkOrOVdnS2OONicktbVBwtTa4c8szErMH6/Y1isRJuy5VNGJZ0yqzvqXaj4T16rHfUrRA6Gm0RM9nPZOU7cWhBOZ7D5sB3JWjfo1Wl5xM0RgsgOZ58TXVJkzsccQrWN9mS78Y7S2Tk8JfM5K7mgGS5FxbJHrHFv+NN8LRiS85GF4wXMHvM+YKqZXmdc9/TqBgp+o1DGfb062za/QbOqeCJ0MHVadB3bP8PrWqt1pIAwXEitmw1jD2wPcY3ZLtI9U4hRafdf/X1mXneFk8e7LfNuJIVL6tC8SH5P1Zbq
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(26005)(8676002)(956004)(5660300002)(66946007)(54906003)(316002)(6486002)(16576012)(38100700002)(8936002)(2906002)(66556008)(66476007)(53546011)(4326008)(83380400001)(186003)(2616005)(6916009)(31686004)(7416002)(508600001)(36756003)(31696002)(86362001)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?S2dBNW4xRXk1RHpOcHlidTlUNGlaWjdaMnYydVowYjNac0hGUU5NbkpPakJv?=
 =?utf-8?B?MnJoa3pPMysrNkhvM3lOWkNHSHd5MU03ZGR4TnVsVHBHeGRDMzJBMzNkSVdN?=
 =?utf-8?B?bVI2OS9ZRHU0VWIyRnJSanFVekFCR2pjWU1hSlpXRmsxakFNY2dtQ3ZJQzVv?=
 =?utf-8?B?RzhRblRFRnN5d3FCdTNZOWo4cTJHK091eGVRV1dJNm9wQ1hLd3BVRE40aStF?=
 =?utf-8?B?eUl0YXZuWi9DdFNnSTlkSUpENjNZdEhqTHloQkZMamtqNGlLWngzWkVnZTQ4?=
 =?utf-8?B?UGgzNC91TmczWklpeTRhM1pHMDBLYlk0anJHb0tldzhqR1JXNjR6TXh4WE5W?=
 =?utf-8?B?a0czbWZhOHRBcEU5d2g2MC9wVmxDSXVhTEhyTFVqRHBsM0V6aWxlajN5ZUtM?=
 =?utf-8?B?b3JON2QydXhXYU94b054V0x6VSszTkNPK1ZXV2F1WUZ3RWxGZXNPUjdQTXVB?=
 =?utf-8?B?dDdjNDlYdUE0bFJrVU5xcy9CaXduaE4wL21reDBtUXkwZmtuYUFqUTgyUGhX?=
 =?utf-8?B?OE5aQkdsWG5kaDF2L2x3THp5bWxzT3N5ajg0U0tyQTE4V3dZM05ZRnJOenNv?=
 =?utf-8?B?VnVRSXp5OVgvSFI5MzMwaDVHODJ6Z253M0J4RVVQOFlFU2EzcWY4Wi80enRE?=
 =?utf-8?B?amxhcmtjNDhPb2lFSVhabGlyK0RWVFF1T1B4RUJkSlU2UWRzeUl6MTBJM3dC?=
 =?utf-8?B?VSs1ZXV0d0ljRWd5S0VyS1ZRclQ5SW9hTHFuVG53dlFDVlFQM0xRUzkwUTA5?=
 =?utf-8?B?b3RCRWNyU3FhbFk1ZHc2anV2VnMyVHNFcmQzZ2xuamxUUEdxWk9oT2VaTFcz?=
 =?utf-8?B?ZmJ2OFBWN1FXM0NYU3psSVVXZmRmeVRnWExzUGFEdGJKd2llcThxQ3hRK0Z4?=
 =?utf-8?B?UnFoQnNOeERpUGswWGRaM1d3MmZOOEZ3RVFRRDFOKzBncDNYTHp1VEpkRDNt?=
 =?utf-8?B?MlZraWNldjk5ajhLaHByQVYxaGRiR3VYMHBydjhUR2FqVHNYenVWOHZBSHl5?=
 =?utf-8?B?bG9hYnZJRGJpTmx4anRBcVlLeTZaMHc5ekw0M2pFemVWQUFla2YrRnZscTBn?=
 =?utf-8?B?QUd0cTFJVjcvUndtc21nVW1BSW81RXlzSm96MWF3VXFlWUNPVldYSFJFN1Fx?=
 =?utf-8?B?Nk5OL0RuYmRUbGJVUUJUdm5zb3ZkRGhWYUROa0FwM3FGbU11MmkwMXkvSFF3?=
 =?utf-8?B?S1BBUmo0YVozUUwzK1owTzhsdnVXeHNMejBURHY1cTJNazVieEE3bm5ucHQx?=
 =?utf-8?B?NnZDUjBKcWNuSjhmNkljcXhpdGJOVEhtMW5hZnJlMldPSTM5c1p1cDlsN0t3?=
 =?utf-8?B?Wm1UVWVEV2xIRUNaNmRMSkFOMDFVU3luRGs1NHJCc3ZoWkVWQVppQmUxT0p5?=
 =?utf-8?B?bVloVXBLUC9lVU1YeTcrZnB6YWErc0o3akltVjRoQ0NyWFR5ZC9OaDZHVVRv?=
 =?utf-8?B?NDkzSkthc0J3MHlZVUhGQytvMWI5dWVLNGxka2ZXOFcxV2FCSnFhd2pZUkFy?=
 =?utf-8?B?YWM2WDRtT24zb3BVL04vUUpvNHEzUHZCa3NHU3UrZ3ZNa283bEg0QXQ5Slc2?=
 =?utf-8?B?ZmVWaE95QWRvVmw4b1BuOE1jYjlGWUdQdU1pTnFLR2RRWW9LQ3NLWUtZbUND?=
 =?utf-8?B?enJ0dWUvUjVjaTh6T2dXY2VOV0E2cTBobUdkUzZ0Z05iMTVlSHpEZ3VpbEEv?=
 =?utf-8?B?amNHVVhxeS85Q1JQeUU0WC9VZUQyNVhSRVJjZXFEQVlXOWlNd2ZzRmQzR3V2?=
 =?utf-8?Q?DuktVmmLFyVE11nKwuKk711uiO7huzbHohYyrUx?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b7f33d82-b48b-4687-0738-08d984e68876
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Oct 2021 14:19:51.7616
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: IBcybx8RfoN3KidUpFbmx+pYFvZR84okqdQOwiNCIDuExIOj1Xw9gfCK5Nc9ha4x2Qbs+3cAOk+Qz6caudb27g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5472

On 24.09.2021 21:39, Alex Olson wrote:
> Inspired by an earlier attempt by Chao Gao <chao.gao@intel.com>,
> this revision aims to put the hypervisor in control of x86 APIC identifier
> definition instead of hard-coding a formula in multiple places
> (libxl, hvmloader, hypervisor).
> 
> This is intended as a first step toward exposing/altering CPU topology
> seen by guests.
> 
> Changes:
> 
> - Add field to vlapic for holding default ID (on reset)
> 
> - add HVMOP_get_vcpu_topology_id hypercall so libxl (for PVH domains)
>   can access APIC ids needed for ACPI table definition prior to domain start.
> 
> - For HVM guests, hvmloader now also uses the same hypercall.
> 
> - Make CPUID code use vlapic ID instead of hard-coded formula
>   for runtime reporting to guests

I'm afraid a primary question from back at the time remains: How is
migration of a guest from an old hypervisor to one with this change
in place going to work?

> --- a/tools/libs/light/libxl_x86_acpi.c
> +++ b/tools/libs/light/libxl_x86_acpi.c
> @@ -79,9 +79,13 @@ static void acpi_mem_free(struct acpi_ctxt *ctxt,
>  {
>  }
>  
> -static uint32_t acpi_lapic_id(unsigned cpu)
> +static uint32_t acpi_lapic_id(unsigned cpu, void *arg)
>  {
> -    return cpu * 2;
> +    struct xc_dom_image *dom = (struct xc_dom_image *)arg;

No need for the cast.

> +    uint32_t ret = 0xdeadbeef;
> +    int rc;
> +    rc = xc_get_vcpu_topology_id(dom->xch, dom->guest_domid, cpu, &ret);
> +    return ret;
>  }

No need for the local variable "rc" if you don't evaluate it.

> --- a/xen/arch/x86/cpuid.c
> +++ b/xen/arch/x86/cpuid.c
> @@ -867,8 +867,10 @@ void guest_cpuid(const struct vcpu *v, uint32_t leaf,
>      case 0x1:
>          /* TODO: Rework topology logic. */
>          res->b &= 0x00ffffffu;
> -        if ( is_hvm_domain(d) )
> -            res->b |= (v->vcpu_id * 2) << 24;
> +
> +#ifdef CONFIG_HVM
> +        res->b |= vlapic_get_default_id(v) << 24;
> +#endif

How come you drop the is_hvm_domain() here? There also should be no
need for such an #ifdef here ...

> @@ -1049,7 +1051,13 @@ void guest_cpuid(const struct vcpu *v, uint32_t leaf,
>              *(uint8_t *)&res->c = subleaf;
>  
>              /* Fix the x2APIC identifier. */
> -            res->d = v->vcpu_id * 2;
> +#ifdef CONFIG_HVM
> +            res->d = vlapic_get_default_id(v);
> +#endif

... or here.

> +        }
> +        else
> +        {
> +            *res = EMPTY_LEAF;
>          }

No need for braces in such a case.

> --- a/xen/arch/x86/hvm/hvm.c
> +++ b/xen/arch/x86/hvm/hvm.c
> @@ -1555,7 +1555,7 @@ int hvm_vcpu_initialise(struct vcpu *v)
>          goto fail1;
>  
>      /* NB: vlapic_init must be called before hvm_funcs.vcpu_initialise */
> -    rc = vlapic_init(v);
> +    rc = vlapic_init(v, v->vcpu_id * 2);

Now that's odd: The goal of the patch is to eliminate such, and
here's you're adding a new instance?

> @@ -5084,6 +5084,40 @@ long do_hvm_op(unsigned long op, XEN_GUEST_HANDLE_PARAM(void) arg)
>          rc = current->hcall_compat ? compat_altp2m_op(arg) : do_altp2m_op(arg);
>          break;
>  
> +    case HVMOP_get_vcpu_topology_id:
> +    {
> +        struct domain *d;
> +        struct xen_vcpu_topology_id tid;
> +
> +        if ( copy_from_guest(&tid, arg, 1) )
> +            return -EFAULT;
> +
> +        if (tid.domid != DOMID_SELF && !is_hardware_domain(current->domain))

This wants to be a proper XSM check, I suppose, and allow more than
just the hardware domain to access this in case the controller of
the domain doesn't run in Dom0 (see XSM_TARGET).

Also, nit: Style (see all the other if()s).

> +            return -EPERM;
> +
> +        if ( (d = rcu_lock_domain_by_any_id(tid.domid)) == NULL )
> +            return -ESRCH;
> +
> +        if ( !is_hvm_domain(d))

Nit: Style again.

> +        {
> +            rc = -EOPNOTSUPP;
> +            goto get_cpu_topology_failed;
> +        }
> +
> +        if ( tid.vcpu_id >= d->max_vcpus )

Please use domain_vcpu() ...

> +        {
> +            rc = -EINVAL;
> +            goto get_cpu_topology_failed;
> +        }
> +        tid.topology_id = vlapic_get_default_id(d->vcpu[tid.vcpu_id]);

... to guard this array access.

> @@ -1508,7 +1514,7 @@ static void lapic_load_fixup(struct vlapic *vlapic)
>           * here, but can be dropped as soon as it is found to conflict with
>           * other (future) changes.
>           */
> -        if ( GET_xAPIC_ID(id) != vlapic_vcpu(vlapic)->vcpu_id * 2 ||
> +        if ( GET_xAPIC_ID(id) != vlapic->hw.default_id ||
>               id != SET_xAPIC_ID(GET_xAPIC_ID(id)) )
>              printk(XENLOG_G_WARNING "%pv: bogus APIC ID %#x loaded\n",
>                     vlapic_vcpu(vlapic), id);

As to my initial comment - I expect this warning will trigger for
about every vCPU of a guest migrating in from an older hypervisor.

> --- a/xen/include/public/hvm/hvm_op.h
> +++ b/xen/include/public/hvm/hvm_op.h
> @@ -183,6 +183,23 @@ struct xen_hvm_get_mem_type {
>  typedef struct xen_hvm_get_mem_type xen_hvm_get_mem_type_t;
>  DEFINE_XEN_GUEST_HANDLE(xen_hvm_get_mem_type_t);
>  
> +/*
> + * HVMOP_get_cpu_topology is used by guest to acquire vcpu topology from
> + * hypervisor.
> + */
> +#define HVMOP_get_vcpu_topology_id     16

Careful with the number choice here - 16 used to be HVMOP_inject_msi
until dm-op was introduced. Interfaces exposed to guests themselves
need to not invoke unexpected operations on older hypervisors.

> +struct xen_vcpu_topology_id {
> +    /* IN */
> +    domid_t domid;
> +    uint32_t vcpu_id;

Please make padding explict, checking it to be zero on input.

Jan



From xen-devel-bounces@lists.xenproject.org Fri Oct 01 14:22:40 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Oct 2021 14:22:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.200665.355209 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mWJQu-0000nt-2S; Fri, 01 Oct 2021 14:22:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 200665.355209; Fri, 01 Oct 2021 14:22:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mWJQt-0000nm-Vg; Fri, 01 Oct 2021 14:22:39 +0000
Received: by outflank-mailman (input) for mailman id 200665;
 Fri, 01 Oct 2021 14:22:38 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=KCT2=OV=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mWJQr-0000ne-VZ
 for xen-devel@lists.xenproject.org; Fri, 01 Oct 2021 14:22:38 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id b529e4a6-0ced-487d-a0a7-126aac6f371f;
 Fri, 01 Oct 2021 14:22:37 +0000 (UTC)
Received: from EUR02-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur02lp2053.outbound.protection.outlook.com [104.47.4.53]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-34-yxqGr9SmPmuSbDw-hyRuFQ-1; Fri, 01 Oct 2021 16:22:35 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB7150.eurprd04.prod.outlook.com (2603:10a6:800:12a::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.19; Fri, 1 Oct
 2021 14:22:33 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4566.014; Fri, 1 Oct 2021
 14:22:33 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6P193CA0101.EURP193.PROD.OUTLOOK.COM (2603:10a6:209:88::42) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4566.14 via Frontend Transport; Fri, 1 Oct 2021 14:22:32 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b529e4a6-0ced-487d-a0a7-126aac6f371f
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1633098156;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=nzzBDYgH4BIG6954eGEJMmkJty9VN39Y8naWpdE9Yek=;
	b=SNjMLWeCS0FHExvG3SVy9dPQ4yPues4ZkE+RIp9W/v+3HJBN1Xi1+aBf0wmUPcHzah3D7A
	mSnMJnjbG3GcEFWmAdMjKHkQZ5oJSkUgjk+pYyuC/wXljFEgReL/ITyzcbP2T0wHn6CTd4
	gb50kWn/sxK7IQt9G/hzQcdMDBdFeUg=
X-MC-Unique: yxqGr9SmPmuSbDw-hyRuFQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=mBvpjqnJJHStY6I2pA1JrffE+VkYwtB1Ar7BoN+wSpeWxm7B/hkj9CFgWJeGsnhZJZ5HQGdrQ3ipCPWWFd1CHwOfvEupQ6fmjs7G+DDUt6t4LM+Bh9NeAp6SvRiUA8aB+0oqcH4dcI+cY2KeC1cQCEINp/v/sGrMb88zUhEo+n10gtKbD855vlSAAwseu0ydAdf0rxJp/Q9PzKmYy/mToXiKJDzfVOReySnanl2z2bBepn1LJbXLSYZIpp84l09U8CqTFKwMkva0lqqjTkJsXoaZJZtKc5YHW9zB0yC76UsRk0ZiTpDcw8WgZxhJUiEf9WcNgpnWZ4r/nZrPDsTCtw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=XLNmfXCum9NOo3tqNOI002MiiiM9/ogQsZzO6YqF58M=;
 b=j9kn86gy5WE2DONtlm9TNJbuEcwxUfretty0SpN36ODrzTFYbh7nacQd2AFE06zxzwVLFsoUjg9a1Rz7Wn94PuwFoAKD70xJFgYdAGNiM58GLxLrS1jWznCH73Aov8ZSaYL5cn5LmsSQjjP0wnr1PC4HRFKdTjViC3Gpkb9agIooMYoRd0ENU6q7y7bBwacBo58xZ+afdRfVgE2mxOwFXEYDFvCI4/5/kQC9mew9Rjm9iu5dziJuAn91VgXRngesJjUg+FDlLicxyP2W1ipmZRlCAWLSGK03q/982t2mihbJbNBf8KZDt+lzLyc0e4wFsfS5iIETGu5PdVAlgsMS+w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [PATCH v4 2/3] arm/efi: Use dom0less configuration when using EFI
 boot
To: Luca Fancellu <luca.fancellu@arm.com>
CC: Bertrand Marquis <bertrand.marquis@arm.com>, wei.chen@arm.com,
 Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Wei Liu <wl@xen.org>, xen-devel@lists.xenproject.org
References: <20210930142846.13348-1-luca.fancellu@arm.com>
 <20210930142846.13348-3-luca.fancellu@arm.com>
 <2fa4be34-9c69-21cb-632f-f566caf622ca@suse.com>
 <6DFF05BA-8250-4C6C-86DF-67997F8DAD46@arm.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <ce8e7fda-4d74-4bce-78bd-387f9b7a395f@suse.com>
Date: Fri, 1 Oct 2021 16:22:31 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <6DFF05BA-8250-4C6C-86DF-67997F8DAD46@arm.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6P193CA0101.EURP193.PROD.OUTLOOK.COM
 (2603:10a6:209:88::42) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 1e2c52bd-e162-4040-a20d-08d984e6e8ed
X-MS-TrafficTypeDiagnostic: VI1PR04MB7150:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB7150DA00CDE21C358A66F2B5B3AB9@VI1PR04MB7150.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:5236;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	osYEys2sxkcV/FlJwEvq45uMATh6I1GlWKoAl/LJwaFKrjC8ALX9S2QQSn9idN/fQC/1kvsbWy3icDp/+IsIFfojriqtUr1U3v14aMaYxb8e7UWuVQr0Yc2OOabwAq6x7qCg3hGCeqxF+VLMWbB+uyRGy5hRQq8Hdt+ah24z1nhXums8KYdtwl1jdA+qtTYeH6MR5H/wiIvfOIqwOI94GfPLzXgVvaCD5toxS0P/JcHs0dcMS3pvgDh5nlRJg700/0HijFATdwVPLyGNeCvB+L60t1OXfa5dkmhvJ3U8XEY6Lj0YC+obrsPphsvukBz68DrpohNblKXoJdRJXwFbWgOs4i7gcbLXu+3r4ONlq6+1KaUqkvQexI3ZFME8MkuhOojUZZmFUcFoQG7hf1KmihRdfHCslL/ntA3/GeYoQ51m0PemwNlYhIhpstOoLJep1MXvBd34Es6w9iBVm9j38KbkTVimPFW7Mxwd0k5BZPzbdFjiJ0hgy0I2lYEW6lN+Aju4t7F/YweIsHEgknnecO6+WTpIpGNtJe37TPVAFJlbIaSOY75oOo1A9S8QGMFjj04Zn04scPhzVlaUaiyx4dYhtEu5bUWInJGsto/1/ULzrkESCmdOGnQGLjhG9Pw87AwSN9w0fNpumk+IuMTOCwItmRqzivaM41AlhxhEcqyLNqYRrARKM3le5dfmjPvo7Pj93GppwJHs1pszA47GSgsDniCV4bLOvF8nRGCH0ldrSH3V8B/Wc4N9dpb9LEfM3auBGRrGTZoHbw9o+xt+Kg==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(31696002)(83380400001)(36756003)(956004)(66946007)(66476007)(8936002)(2616005)(66556008)(86362001)(508600001)(6486002)(6916009)(186003)(8676002)(26005)(16576012)(7416002)(53546011)(54906003)(5660300002)(2906002)(316002)(38100700002)(31686004)(4326008)(32563001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?++b2gI2gRHxhCOlOXyI0SG8BKInEW7qFjYEf5EAQ23uKFJWzLv2vTzyXtX6M?=
 =?us-ascii?Q?Cx8L5WPrJ2FnCZtYHk8w45VKtYW1TRvxleBUugyxJg7QkCF/bM4MqzPpDJCk?=
 =?us-ascii?Q?mmDjZiZPqZqnSjv7wdm6PI0tVPYvMWwXMCuRfN/xW+JOii92OTnc7YtgW4Sm?=
 =?us-ascii?Q?cCI7EAhWYy5l9YxjE7G/cMZZhu7VM89T+pa/KLHsvVyRRIsI5c52T4f+a7HN?=
 =?us-ascii?Q?fjyFhkvTxQniaRZ8iKtej2e5hXN0jG2tZWEllqsqm9Y+62NepvdLrfqjNQx9?=
 =?us-ascii?Q?n2397XEnFbPDmYOz0fP06PqdjJi+k2xZ5b5NzIlIcPS6r/PfvExaBYzlVy12?=
 =?us-ascii?Q?2Car2ijN2or5cIp2r9huES0NytruoVV9tM2dmmZLAHHwfTedNHrC4X/KZHQi?=
 =?us-ascii?Q?Pa6ixgmahA7nqhfxN94t3EbYkIVQFEWi7LXEPlD6qgOjXluxJlzz1v9obmPr?=
 =?us-ascii?Q?Djq/Nc78ua+9OS7KNHT576yUG+Ur/3MrIzWyrq85SEEhwht60aRDwsose6kK?=
 =?us-ascii?Q?xs0iCm/XvtyU20rTgQGt0wCdwBU3FphMEM+1dW+ZVt1E7+So8OvEccE/7MeX?=
 =?us-ascii?Q?B8C7LUS72b9atloMdYQfpHTC9616ZsgrEKp6/waLMk2pT1warwoansFO46Og?=
 =?us-ascii?Q?9zuuyCqrkBxZC/blrEw/GtRuHk7/egLLV/7PfA7bO3BHGSaeakgyexB60qqt?=
 =?us-ascii?Q?nfeX8v72cSxXAfykUbXWaAXN4lPuvKomJArlyrQqxoRgsqYer0tColWRQxLz?=
 =?us-ascii?Q?/w+1RGSNdcNOraqImRIIO9i1ARQoLHVQJqXKLLsT06lGSRReF5i+FlXMIQ+y?=
 =?us-ascii?Q?MVeoSQ71wplDLMwzKLkm6wd2APzZ8xhCRE51v3KLrLu4WxFHCP4gZvnAZnE2?=
 =?us-ascii?Q?wyr4j5gO8qCaEfWoQgWODrjpr+3Gbym8K+jnY12pUXz6c++VzyAkt+cS/lp3?=
 =?us-ascii?Q?gsC6/KxsWt95OdHvCTft8VVDXE2HI1VwtVzAP3ez5ftRQvvIVyfEyfMYXmIm?=
 =?us-ascii?Q?A9KZdQFQbWawddhUeAGMxAvHg6WFgS65wI85qMTRC7gd2U/1kenLU09TcpCZ?=
 =?us-ascii?Q?/HE1mVKjeamCkaSyCz0HHYx8VaX7kV3zVjEwyh350V+ygrDS5ejErIPLdoQN?=
 =?us-ascii?Q?pMUGiRkMVXB8jsVcOcYGYZ1LPmVNW5UdcMMzeNp7luwO+BsZ5+7z5IuAYRST?=
 =?us-ascii?Q?mYwbTQxF/gMu37biTcDM+eYHRn7669k05Kqy+wlqP1vHWD+a1UuiNYLJSzlK?=
 =?us-ascii?Q?q7IHTSes5S2veccLGQc6ovgT878b5R3ctEvgW2l1VJTHsGig4gFpfAfmXq5C?=
 =?us-ascii?Q?j+yixwPx/qOqEcylCzPPZM98?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1e2c52bd-e162-4040-a20d-08d984e6e8ed
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Oct 2021 14:22:33.6557
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: GZHVxdS6tt0r8v/V2YEoVedDQsRaLo6lHSmDP62Ld7SPR06algjdfm05hfYlCS+J3Nvm5IhJsSAndk1kUd39IQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7150

On 01.10.2021 15:55, Luca Fancellu wrote:
>> On 1 Oct 2021, at 12:02, Jan Beulich <jbeulich@suse.com> wrote:
>> On 30.09.2021 16:28, Luca Fancellu wrote:
>>> @@ -1361,12 +1361,30 @@ efi_start(EFI_HANDLE ImageHandle, EFI_SYSTEM_TA=
BLE *SystemTable)
>>>         efi_bs->FreePages(cfg.addr, PFN_UP(cfg.size));
>>>         cfg.addr =3D 0;
>>>
>>> -        dir_handle->Close(dir_handle);
>>> -
>>>         if ( gop && !base_video )
>>>             gop_mode =3D efi_find_gop_mode(gop, cols, rows, depth);
>>>     }
>>>
>>> +#ifdef CONFIG_HAS_DEVICE_TREE
>>> +    /* Get the number of boot modules specified on the DT or an error =
(<0) */
>>> +    dt_modules_found =3D efi_arch_check_dt_boot(dir_handle);
>>> +#endif
>>
>> So I had asked to add a stub enclosed in such an #ifdef, to avoid the
>> #ifdef here. I may be willing to let you keep things as you have them
>> now, but I'd like to understand why you've picked that different
>> approach despite the prior discussion.
>=20
> There must be a misunderstanding, your message in the v3 was:
>=20
> "Every time I see this addition I'm getting puzzled. As a result I'm
> afraid I now need to finally ask you to do something about this (and
> I'm sorry for doing so only now). There would better be no notion of
> DT in x86 code, and there would better also not be a need for
> architectures not supporting DT to each supply such a stub. Instead
> I think you want to put this stub in xen/common/efi/boot.c, inside a
> suitable #ifdef.=E2=80=9D
>=20
> So I thought you wanted me to remove the stub in x86 (since it doesn=E2=
=80=99t support DT)
> and put this call under #ifdef so it won=E2=80=99t be compiled for arch n=
ot supporting DT.

So FTAOD I'll repeat the crucial part: "I think you want to put this
stub in xen/common/efi/boot.c". There was nothing about removing the
stub altogether.

Jan



From xen-devel-bounces@lists.xenproject.org Fri Oct 01 14:24:19 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Oct 2021 14:24:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.200672.355221 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mWJSV-0001RY-Er; Fri, 01 Oct 2021 14:24:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 200672.355221; Fri, 01 Oct 2021 14:24:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mWJSV-0001RR-Bl; Fri, 01 Oct 2021 14:24:19 +0000
Received: by outflank-mailman (input) for mailman id 200672;
 Fri, 01 Oct 2021 14:24:19 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=KCT2=OV=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mWJSV-0001RL-26
 for xen-devel@lists.xenproject.org; Fri, 01 Oct 2021 14:24:19 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 42a668a8-22c3-11ec-bdad-12813bfff9fa;
 Fri, 01 Oct 2021 14:24:18 +0000 (UTC)
Received: from EUR02-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur02lp2050.outbound.protection.outlook.com [104.47.4.50]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-24-5VccNSuFOPa-Df0pm1P35g-1; Fri, 01 Oct 2021 16:24:16 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB7150.eurprd04.prod.outlook.com (2603:10a6:800:12a::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.19; Fri, 1 Oct
 2021 14:24:15 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4566.014; Fri, 1 Oct 2021
 14:24:15 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS9PR06CA0353.eurprd06.prod.outlook.com (2603:10a6:20b:466::30) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.14 via Frontend
 Transport; Fri, 1 Oct 2021 14:24:14 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 42a668a8-22c3-11ec-bdad-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1633098257;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=i6DXaUMdkvaSJhGgZy3nnIavS2SZ7o5MouOVK78/7VM=;
	b=Md3e9vCK8mJ3PXMCwfrUXUQzWrfqU40MoXuv2UbXmqZoqBFAKyRyL9Xo4A0U4Dq0dhx0OL
	aR2hRWquDrp750bOml9PWMBCU7HQRxFJCxS2G32q2WPRLMh+C8IvLZBYNHA7cL8qDVglCn
	uauPWyNywc8oCjjzofH2fMpTBbzg64g=
X-MC-Unique: 5VccNSuFOPa-Df0pm1P35g-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Rj8K8KfdNl9olEgPnIxJHmeXSdNCduqItLkemPqYAOf6M8wuILtoVxX0f6Ft3IpKXcUL6g8OBmib6P3e4cGJu7C5uAMGuUAtQvTnC6+/SWJUCqOgHXjmC7Fwpva1Gf1cZj/KxXaDc0dFeDgKjnWgg2ktzMKVVNBM+Oxxh2S8RfelRq2suInW4suAcmnusne8pgIEpBR6sV+LETcOzMJ/Iz/2wL/cNp4SUzdlh3zxR2JTquPlc09uK3A/B02RuodgMzZMhJhS6l2jnkegwwaVbFO45u6qiey+8rZY/M+FRW5P7L8csPjQpRfwrX/JMDrDorXwN9wPWnNCoXy4DtM9Wg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=i6DXaUMdkvaSJhGgZy3nnIavS2SZ7o5MouOVK78/7VM=;
 b=GS7ygT4CkPj3GTz731FHsQyyxs1SzUIYqd1HSEhhKwgf0AkMYCCrzhbp56w7zGx2lpRPKqxXlCc3hevUFf+/kuiFsfKHLZRgcRTwPIKcxXOi6mYdXk3WXA+XtGN8hkI6RzVXOGNFUGzdluUY18oJBfopRq0F8PFukO4aLDzX85n/lMOExqRPl/ZefG5e95DD+yOsV6pvMIWNs9H7GJ3HLRntP8W4tFW1GBeTAMbvc9OSj9d/sc8o7JEY6ZWXE8XLUj+xVT+2FNg7i1XsB2s03Mtydr3YLIEm/doRPPakHzymCfmGISbeK1t9BhvxOnl+KONtg/RweEG3E2T1ZcFrQw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [PATCH v4 3/3] arm/efi: load dom0 modules from DT using UEFI
To: Luca Fancellu <luca.fancellu@arm.com>
Cc: Bertrand Marquis <bertrand.marquis@arm.com>, wei.chen@arm.com,
 Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Wei Liu <wl@xen.org>, xen-devel@lists.xenproject.org
References: <20210930142846.13348-1-luca.fancellu@arm.com>
 <20210930142846.13348-4-luca.fancellu@arm.com>
 <21f9af33-0d09-fb2e-95fa-f4c5796671ca@suse.com>
 <29BFC7F8-5173-4395-952C-FFF0E1F4C9FB@arm.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <0fc3fc76-30f6-4683-6bac-2b1adbe56cfc@suse.com>
Date: Fri, 1 Oct 2021 16:24:12 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <29BFC7F8-5173-4395-952C-FFF0E1F4C9FB@arm.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0353.eurprd06.prod.outlook.com
 (2603:10a6:20b:466::30) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: feed6e4f-0aa5-46dc-452f-08d984e72579
X-MS-TrafficTypeDiagnostic: VI1PR04MB7150:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB715050E16C8369F7EB2632BBB3AB9@VI1PR04MB7150.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	lXer9a/qe0v01f0aCH9J4i1n52oKJ5URyB5Q5LrgXN0UZ3wPmaaPzqay6t05I0NSOYO7HivyOZ6HzDQIRKb8Lb/vXBxyJ7KsJOx+2Lhu4ZLza9T0xEyKtVWwqJomj+MQV6MWh7cgmtD8KajGe9duOAaPwtFLDprXyO9JLGqiBFGgiWXNqO0+StobHxFtBMIq3cRTVUWmTvMiCiuQG5PZqckCpC+ed/9Ab4sDVwp2Xw5BVZlNjwjk8n05TP1Lejle0r4CoBUKNkhukVPGtuTGQu5A13/dPN82WQwpfT+r1QFDGJAzC1aq5Xi5eOJlCisCSo/psMGB9lejq3ztDy26rZvQfzsUttwt76hhzRUgJhYEGODPXOHL0vrUUJehS5WmSBuSX7L/cB2+eC9HblMemDaeERRz9kKIdjcVwZq6p1XPNFKBrJ9DoM11t1FVeGYhtYTkpfbr2PgJ2HO1qQGjUHOFf4DiJmB0GJq9sEuE6rzldV8ZysYKE9J3Fv093JOcS6AXLftygOp5U7Xsr+OCC54wOInwTW7JFrbNsJ2rsGZVrN394zuBWAvCtXONmCAwn77jaqQxH+nOGqAA+xM3u4Oym40SsAT6IXUOXdynS/oDAVRvCmKhRW5JVLycZ+WVbucZ9aT0KHmV/DpsG5zH2LcM5uEm3R0uo28Ha8CTeh0Dpr69+0Voa07IGJTXXqqkqmZa7aXN9GsrU3VDQv64LrGfUwPjNgyFxPo5VjtSDWjSQNT3yCSfYsnMrO1xHmLf
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(31696002)(83380400001)(36756003)(956004)(66946007)(66476007)(8936002)(2616005)(66556008)(86362001)(508600001)(6486002)(6916009)(186003)(8676002)(26005)(16576012)(7416002)(53546011)(54906003)(5660300002)(2906002)(316002)(38100700002)(31686004)(4326008)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?STJKRnBDUzZvVzZ3cElhS2p0Sjh1cytEUFQ2c2UrK0VYWEpnV2dhZFVsNnZX?=
 =?utf-8?B?YjZnWHo4MXZVZjFaVnBOelpHS1BWbHJHTnZtMFBlS3JyS0VpYkJtbzRXUzEx?=
 =?utf-8?B?UGZnU2VCWkJZaTYrTWQxa0FQd2hRZDNmcVZoVWhtVExqaktIeVhiQUx0REhj?=
 =?utf-8?B?NjEvalRNbGlYeVMzWXpodGJHcUZvRTJycDMvTWdDaUxzRVV6c3NyU3FJTUs4?=
 =?utf-8?B?M0xUQitpUEVpb2R1bTludk5jZXprTWkybUhENWdsWnNTU3NkVEl1MDFiYjlw?=
 =?utf-8?B?dFhCV0tlS1BDc05vTllpSnhZbzU3aDdCa0w5UjRFaElMa1hpczAwTWZ1RExS?=
 =?utf-8?B?STNVMk9uVWNNOVp1d3lmSTY4RWR2MkJhcmFremlkM21FbHFSZFVjZi9VYm50?=
 =?utf-8?B?cTBLS01RYU9rdFBqOUw0SE9Mc1V4YnBZWTN4ekRRQWRIZ2JydVB1OElSQ2Iz?=
 =?utf-8?B?ZFBSczNzd3R2TUg5MmM1cjRsU213dmpXSXJES2o0R3I0Z3lKN1BZRUxtVjR1?=
 =?utf-8?B?Y1Y0NEM4Tm5zTHd1WTRtWDVmbGdFekdxRGVMbmw2bnlPc253Z3liZEttY0Zv?=
 =?utf-8?B?SC9SQWdxVGQwaWNSbWFaTWVnVzNqUGRYRENkQzhYRXJqMW8zMERrZzZVazdP?=
 =?utf-8?B?MCtzbldMd3Rzek5iSVd6QjlEaU8rd1MvejkrU1lKd0t4cm9qL254dmt5VkFn?=
 =?utf-8?B?OC8ycnRxRE1YVzNFZ000SDNySkhvY3A0V215bHRDd21GcG9sK0h5SWlMMG95?=
 =?utf-8?B?Y295TlAxOWNzQkcxR2M0Qm5BdkNtbi9sMzZ2RWhqdlFxTzRLQmlhSjVWVEl0?=
 =?utf-8?B?ZWFtWExNNmVOcmVYOVdCOVhEYzdDWFpZNFEvd3N3bHZBZzFUUWNCZWdhNGNY?=
 =?utf-8?B?U3NmQ2hmT2t3QkYxNTJ2eS9BS013ZlFqZ2wrUjFUaUlTenBWQ0o0Sk5tdnc1?=
 =?utf-8?B?UCtnQTBsQ3cxeGZUM2dTUUtWT1MyVWlBbTNPY3lZSEExbzgyZktYL1Q3cEtX?=
 =?utf-8?B?UDltNWlpNWJTa3dkNFZGR3VEalR1YS9YeXJxMDJ2Z1B3aHdabXB4WCthc0Vm?=
 =?utf-8?B?eXpZUWMraHN3S01zSWlGMHdleUJtSk5IcjhoUzhkQkFNdnZOS2ptVVNSbEtt?=
 =?utf-8?B?RTNPa1RwMmo1Z09PMGdhcW5GK1VvWjZvSEVneGtjbzk2NVh2Y0pQRnJyNkNW?=
 =?utf-8?B?emFsU2tsVG5VczJTU3B1bSthT3ArblJuWU1xaGl2aTR0Z2RYdi92ckR1NSsx?=
 =?utf-8?B?ZFhYbHd0SlNmbG1pRUhmMmZ5MEZkZ1g0US82UnExcFdhWUpDRURNNi9lQzdC?=
 =?utf-8?B?bnNPdFNOcGlDcnltOXlxMXBTTWVuNC9FYzI4RUs0RlBvWjZ2Skp4Qk9hTzVG?=
 =?utf-8?B?VzVDdGg1Q2NqUWxMSjZLajc0R3c2UVZ1RkZFcUVsZVJZWmJmLzZWSzN6RUEz?=
 =?utf-8?B?cEtnSzQvNEM5V3A5U2FmVVpDeDBTckdEdkJ4SG9DTkEzZGNESHQ0c0NnOWw0?=
 =?utf-8?B?WFdYQkR6RnN3b0NHUjdOcDBjY3NXRmV1TXA3a21NUTV2Q3NteldSMnR0MUpC?=
 =?utf-8?B?M3BESGV6YWNvT1MxcDNHOTBSa3k5Zk1LaHRINjBpQ0JJN05BbHgxNldQU2g5?=
 =?utf-8?B?OTVVUy9jVjgrcXVoRU5wOHpMMEw0WkYxaFc1RkgzY0lxa2pFRHVMWXFHeXhs?=
 =?utf-8?B?MFBnTXBYOWVXbHBycU92bnJHdS9UVHJXbWFZTTBUOWpDeXJ1WE9wS3JBNWRH?=
 =?utf-8?Q?jvET3sXKf1XpSDwbsaifQaSZ+GP8lYhpBJPBCcj?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: feed6e4f-0aa5-46dc-452f-08d984e72579
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Oct 2021 14:24:15.1841
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2JdVPWlYofTHBUqBR4NleoezPjuMDy+1NeSnulfjfKKdkEK2FoNYBWXEvsBlo88+jJU6olG+fQ2H646yuHwp/g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7150

On 01.10.2021 16:08, Luca Fancellu wrote:
> 
> 
>> On 1 Oct 2021, at 12:16, Jan Beulich <jbeulich@suse.com> wrote:
>>
>> On 30.09.2021 16:28, Luca Fancellu wrote:
>>> Add support to load Dom0 boot modules from
>>> the device tree using the xen,uefi-binary property.
>>>
>>> Update documentation about that.
>>>
>>> Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>
>>
>> Acked-by: Jan Beulich <jbeulich@suse.com>
>> despite ...
>>
>>> @@ -1385,6 +1380,17 @@ efi_start(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE *SystemTable)
>>>     if ( !dt_modules_found && !kernel.addr )
>>>         blexit(L"No Dom0 kernel image specified.");
>>>
>>> +    /*
>>> +     * The Dom0 kernel can be loaded from the configuration file or by the
>>> +     * device tree through the efi_arch_check_dt_boot function, in this stage
>>> +     * verify it.
>>> +     */
>>> +    if ( kernel.addr &&
>>
>> ... me still being a little unhappy with the inconsistent use of the
>> union fields so close together: This one is now consistent with the
>> one visible further up in context, but ...
>>
>>> +         !EFI_ERROR(efi_bs->LocateProtocol(&shim_lock_guid, NULL,> +                                           (void **)&shim_lock)) &&
>>> +         (status = shim_lock->Verify(kernel.ptr, kernel.size)) != EFI_SUCCESS )
>>
>> ... is now inconsistent with this use. But yeah - read_file() is
>> even worse in that sense, except that there the different uses are
>> for specific reasons, while here the only requirement is to satisfy
>> shim_lock->Verify().
>>
>> Please feel free to retain my ack in case you decide to use .ptr in
>> all three places.
> 
> Hi Jan,
> 
> Sure I will do the modification you suggested, I will fix also my silly mistake that
> Stefano pointed out.
> 
> Just to be sure, I explain what I will do:
> 
> In the second patch I will change:
> 
>     if ( !dt_modules_found && !kernel.addr )
> 
> To 
> 
>     if ( !dt_modules_found && !kernel.ptr )
> 
> 
> And in this patch I will use:
> 
> if ( kernel.ptr &&
>          !EFI_ERROR(efi_bs->LocateProtocol(&shim_lock_guid, NULL,
>                                            (void **)&shim_lock)) &&
>          (status = shim_lock->Verify(kernel.ptr, kernel.size)) != EFI_SUCCESS )
>         PrintErrMesg(L"Dom0 kernel image could not be verified", status);
> 
> Do you agree on them?

Yes and ...

> Can I retain your ack to this patch doing these changes?

... as previously said, yes.

Jan



From xen-devel-bounces@lists.xenproject.org Fri Oct 01 14:31:04 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Oct 2021 14:31:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.200688.355231 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mWJYq-00031Y-7J; Fri, 01 Oct 2021 14:30:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 200688.355231; Fri, 01 Oct 2021 14:30:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mWJYq-00031R-4L; Fri, 01 Oct 2021 14:30:52 +0000
Received: by outflank-mailman (input) for mailman id 200688;
 Fri, 01 Oct 2021 14:30:51 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=m+lB=OV=citrix.com=Andrew.Cooper3@srs-us1.protection.inumbo.net>)
 id 1mWJYp-00031L-4n
 for xen-devel@lists.xenproject.org; Fri, 01 Oct 2021 14:30:51 +0000
Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 2c18cb66-22c4-11ec-bdad-12813bfff9fa;
 Fri, 01 Oct 2021 14:30:49 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2c18cb66-22c4-11ec-bdad-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1633098649;
  h=subject:to:cc:references:from:message-id:date:
   in-reply-to:content-transfer-encoding:mime-version;
  bh=Ux5ZG5p8Rq1aWtqnGKE7zRihNadmfPytGMbtDhPUsEo=;
  b=GtzcdjuUDTZu5ssH4rNaCSINlWdWm2vrUtA9kezbL/RS8RRO6FBFElKf
   BTD0eOdPKlQjQZbzSn74Xydpz2KeyRo9sVfEnAbMCd64//gXjeBvR1cVi
   rNCSac5M6bkxCuLw+jTVlRnYtIKYueMdVDGzquCm5JwYDHs8T6K2Tl7xz
   g=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: lhFB2B95WOp6wj9X7X4vLofYa/wkwbdYPxLbQA7eraW+aLdfHV7ipGg72J2ENit0hsF0Vdwu/I
 +kNKfth9i16zdG5ceaWfn0YjWNGKYmda4BOC86dCrpXVOnQ07yF8JkvglnpLf/vJpDwKOd7Hzy
 IAL74kUvRR33ZUHpCzUhwS6aQwkq0B+dA7qYMfXN/HCK2OEG7wsvn6KmieLrrg6Ie55rPzIBJy
 hFphftuPGerGx3ZIAGluRexBbt52mPFvRgMVP8jyyAmX8m9NOw/u3JO4hf9/ld0Yl0wTmBTAQ/
 sLfv7eEpTRxfMCaMFLtdPQ19
X-SBRS: 5.1
X-MesageID: 54148693
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:yHQFpagRRzmX2888enJDDtR6X161BRYKZh0ujC45NGQN5FlHY01je
 htvDG7QbKuKYWDzftsjPdjn8EgGsZ7QmodgGwJlrC8yQyob9cadCdqndUqhZCn6wu8v7a5EA
 2fyTvGacajYm1eF/k/F3oAMKRCQ7InQLlbGILes1htZGEk0FU/NtTo5w7Rg29Yw2IDia++wk
 YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq
 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx
 /1cuazzUFkQYJHsu6MRXAhnSA5CO5xZreqvzXiX6aR/zmXDenrohf5vEFs3LcsT/eMf7WNmr
 KJCbmpXN1ba2rzwkOnTpupE36zPKOHCOo8Ft24m5jbeFfs8GrjIQrnQ5M8e1zA17ixLNauCP
 pZJN2s0BPjGSwV1FggIDo4up8ex2EugWhcbjnmeooNitgA/yyQuieOwYbI5YOeiWsF9jkue4
 GXc8AzRAw4YHMySzyKf9XChjfOJmjn0MKoQHrCl8v9hgHWI23ceThYRUDOTvfm4kQi/QJRWc
 0gP/SwGoq079UjtRd74NzW6vXqFsxg0S9dWVeog52mlw67Z80CeAnMDSBZadNU8sMY8Az0tv
 neZktWsCTFxvbm9TXOG6qzSvT60ITISL2IJeWkDVwRty8L4vIg5gxbLT9BiOK24lNv4HXf32
 T/ihCoxnbIIluYQyr62u1vAhlqRSoPhF1BvoF+NByT8s10/NNXNi5GUBUbz/Ppwb5/Hdwe9n
 FtDl8eP07shMZe8i3nYKAkSJ42B6/GAOTzapFdgGZg96jigk0KekZBsDCJWfhkwbZddEdP9S
 AqD4VoOuM870G6CN/cfXm6nNyg9IUEM//zLUerIJv5Hf5R8bgOO+CwGiaW4hDu2yBlEfU3SI
 /6mnSeQ4ZQyVfkPINmeHb51PVoXKsYWnj+7qXfTlUrP7FZmTCTJIYrpyXPXBgzD0IuKoR/O7
 /FUPNaQxhNUXYXWO3eMqtZJcgtUdCVrVPgaTvC7kMbYfmKK/0l7VZfsLU4JIdQ5z8y5aM+Sl
 p1CZqOo4AWm3iCWQel7QntidKnuTf5CQYETZkQR0aKT8yF7O+6Htf5HH7NuJOVP3LEznJZcE
 qheE+3dU6snd9gy02lEBXULhNc5L0rDaMPnF3fNXQXTiLY6HFGWpo+4IFG/nMTMZwLu3fYDT
 3Sb/lqzabIIRhh4DdaQb/SqzlirumMalv40VEzNSuS/sm2xmGSzAyCu3PIxPe8WLhDPmmmT2
 wqMWE9KrujRuY4lttLOgPnc/YuuFuJ/GGtcHnXasunqZXWLoDL7zN8SSvuMcBDcSHjwpPeoa
 9JKwqyuK/YAhltL7dZxSu450aIk6tLzjLZG1QA4Tm7TZlGmB+o4cHmL1MVCrINXwbpdtVfkU
 06D4IACa76IJNnkABgaIw98NraP0vQdmz/z6/UpIRqluH8rreTfCUgLZkuCki1QKrdxIbgJ+
 +Z5tZ5E8RG7hzorLs2C0nJe+VOTIyFSSK4grJwbXtPm01J51lFYbJXAISbq+5XTOc5UO0wnL
 zLI1qrPg7NQmhjLf3YpTCWf2ONcgdIFuQxQzU9ELFOMw4KXivgy1RxX0DI2UgUKkUkXj7MtY
 jBmZx9vOKGD3zZ0n8wSDWmjFjZICACd5kGsmUACk3fUThXwW2HARIHn1T1hIKzNH7pgQwVm
IronPort-HdrOrdr: A9a23:DkqNQqoj8FuAruANPpq8wXsaV5u8L9V00zEX/kB9WHVpm5Oj+P
 xGzc526farslsssREb+OxpOMG7MBfhHO1OkPYs1NCZLXXbUQqTXfxfBO7ZrQEIdBeOjtK1uZ
 0QFZSWTeeAd2SS7vyKkDVQcexQueVvmZrA7Yy1rwYPPHJXguNbnmBE426gYzxLrWJ9dPgE/f
 Snl696TnabCA8qhpPRPAh6YwGPnayGqLvWJTo9QzI34giHij2lrJb8Dhijxx8bFxdC260r/2
 TpmxHwovzLiYD09jbsk0voq7hGktrozdVOQOSKl8guMz3pziKlfp5oVbGutC085Muv9FEput
 /RpApIBbU911rhOkWO5Tf90Qjp1zgjr1fk1F+jmHPm5ff0QTorYvAxzr5xQ1/80Q4Nrdt82K
 VE0yayrJxMFy7Nmyz7+pzhSwxqvlDcmwtgrccjy1hkFacOYr5YqoISuGlPFo0bIS784Ic7VM
 FzEcDn4upMe1/yVQGYgoBW+q3oYp0PJGbDfqBb0fbllAS+3UoJjnfw/fZv3Evpr/kGOt95D+
 etCNUhqFgBdL5OUUrRbN1xNvdfMVa9NC4kBljiaGgPJJt3SU4llKSHlIndxNvaMqDgn6FC1a
 gobjtjxBgPkgTVeJWz4KE=
X-IronPort-AV: E=Sophos;i="5.85,339,1624334400"; 
   d="scan'208";a="54148693"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=M97n2Xb4Gxs+wS7RYIMshAiZEdA8kERcT8tSyB3TQXqy2FdKFkruKYjHFr3enAy7KbYDE++KYpxewJs7dUy5YAm2IQ3BZbtlPeXduZ2Mrtywr3o2cdFfxcKtL689vem9cFt39gPPiJOQfV2XwX5Ur1KcGpyDT53T/HTQa2WUI+Hho7bsPaJZNibfoMU+R2RxIsjHZ0VdrYEgrOR4Tg2sXhWlHIZwGENH04h9iKck9xKZcwmCKn602UVXa3Db8CSrjE1aSd8ivjAfnkFAxd0K/h/G01T5/jNAYWiBlYC7azcXzysWUrIIb4eimwGcZDGTn4ZsGyecgdQ3k/9Gznfnkg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=bu5lfKqc/MOtq0lV000NQTbgxDYRjVUN3tPlvMIgE4I=;
 b=n+V/pu4bnnxu0jqw3bOJOLKQVh3l076Q1d68YQytSUWDS1KaitOTQoJSxkdLr8jxJkB6J7cr61o3IfCejMj++1vRJaApeE6oyPj8UlQ6isbGBr6wWP61kqgNlkZqKcPMPXEUXwJZHxUn2NAknevd63nRR4DLQuhcxECHtmcNu/RGRxFHPuRARLpnG9RVQ6cYEzhDcn6fS/Veof1k+RTkZfZdIZZpIHWgOnHOyxcpeo0m/nIGaWJZv/QCtc95xEpmZbAAEuG/fPDOdd5l1CrdQqu+VieRB3BuVfzvYmyc465s8ugx2EwG8PN5X8yENCOc+43IyhALbU1eQXugE/ViZw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=bu5lfKqc/MOtq0lV000NQTbgxDYRjVUN3tPlvMIgE4I=;
 b=vULegu22qhYX6QN6dEJw215Ln6E0I3i0ROAhH6od2oWJVi0Xo7EBn74GkDV7MbvoOrkWQLlxSF3wcbxCyEWuKnCBnmJiWsE/UJn9w1Ra39JzuH7sME+Jh/9lNitc2VqFya8f0YRQmmxQrVNgKb3DJ1JeAUKn8Uqh44FkjZwuxrM=
Subject: Re: [PATCH 1/1] x86: centralize default APIC id definition
To: Jan Beulich <jbeulich@suse.com>, Alex Olson <this.is.a0lson@gmail.com>
CC: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>, Wei Liu
	<wl@xen.org>, Ian Jackson <iwj@xenproject.org>, George Dunlap
	<george.dunlap@citrix.com>, Julien Grall <julien@xen.org>, Stefano Stabellini
	<sstabellini@kernel.org>, Juergen Gross <jgross@suse.com>, Anthony PERARD
	<anthony.perard@citrix.com>, Alex Olson <alex.olson@starlab.io>,
	<xen-devel@lists.xenproject.org>
References: <cover.1632512149.git.this.is.a0lson@gmail.com>
 <85b59046315b8a84afa8538aacdea92b19200faa.1632512149.git.this.is.a0lson@gmail.com>
 <d899b058-a201-e2f8-35d2-f0e59ab4bab3@suse.com>
From: Andrew Cooper <andrew.cooper3@citrix.com>
Message-ID: <d63a0e7d-7f9d-0dcb-0ac9-8995e56698b4@citrix.com>
Date: Fri, 1 Oct 2021 15:29:45 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <d899b058-a201-e2f8-35d2-f0e59ab4bab3@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Content-Language: en-GB
X-ClientProxiedBy: LO3P123CA0006.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:ba::11) To BYAPR03MB3623.namprd03.prod.outlook.com
 (2603:10b6:a02:aa::12)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 99d2d192-42a5-477d-5849-08d984e7efb0
X-MS-TrafficTypeDiagnostic: BY5PR03MB4966:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <BY5PR03MB4966CDF53532BC3A0134A557BAAB9@BY5PR03MB4966.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: PBJZTNWxQEBt3XNfC5yjAlStZz6WC0Qbpk5xs08oinOx90OLsLsJsFz2wdjBp8MeE1SYJkqPjG9esbJbeeIChGvBcF26gpNoeFnezrGYhjEh602UMiwI2MpQf0pdNsZ5jUPrAtdeH9Vh051Mh1aL0Rs6N2m8pSdUO05/6TRLty5cbzxteG1znS1mQgSJoBktuHuXHICf8QRq5k49dMY5p6sMe4RTx96kw5TsKpkuOcZg6t1kQV9XMh020RcGlCLcLXZpYWNPCy/CJe4OLevGqJ8GNdVaVfIYo9ZqpKQuv3AjgMVpWO7RFkJDaxJJkfC1d0BFwpYUr7nfkLQNvV6P44n7IwZIipTXGRNnhtOl10Xm1tYWXjpovMZgwwtJDpzOhsFk1l1cMec5ZHudWM3PYFQaRw9dLCC13Fdl34a7OjFj+I1Vc5ewz9fsIGH/SCyxzxA3WV7iN6gcHn028Fi6y5yGJQmI577wmBp7SbatLtxAhS+s6k4M4TRHFz3fZ4ABPgUIgleIxak2gHxWE6sColmIBgZYU0rNZu1X4khNg2RKx9BCxVUdUeekwfsp5ZVAJNgxnTOQ6SFsG8MXhj1DeLiPF3gpYy/SMdfdSkExJwgVzFNA+Heu4Bk5gQxJm5ROOUHvY3nO1ISYa2fZZTiBSeNKihSQwLL2O2bT9D9BzeAq0r/XupMX/E6Reu3FStgd8WDAtbyq5IcyGsusXPuVoGpohWSsFjIbDBxxR7ohEQOMSuNfkcGC5aaEow6qaX7n
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(26005)(31696002)(956004)(508600001)(55236004)(2616005)(8936002)(31686004)(38100700002)(36756003)(5660300002)(54906003)(4326008)(83380400001)(53546011)(66946007)(6666004)(8676002)(110136005)(316002)(2906002)(186003)(16576012)(6486002)(66476007)(86362001)(66556008)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eHhWbjBuaXFJZzRUbm51cWxsVG9md3ZaRkhiNmlzM3FJN0wyU2xHK1JEVUJ1?=
 =?utf-8?B?QUFwakJqeVdqZ1daTHkwQW5HWVpQdHJZWHJ3OUJTcEU2aVc2cmpTVjcvK2wv?=
 =?utf-8?B?QSthZ01ZRHRkMk5tOVREVk4yZXJyUDdkOGl3ZTJIQ3ByeXppR2RFV3YxRXVR?=
 =?utf-8?B?VjYzaE9PbUk2a1FFNzcrc0h2MVI5MDRZc0E2Q3kyaTJkeEc3bnpzODZ3RE1p?=
 =?utf-8?B?L3pURVFlQ21FbVpVSW5tQUIzOXF1bk80TUdGb0VBTi9zajBnMUx1UFlrYzRB?=
 =?utf-8?B?MjA4Yk1hdnY5SzBNVUR6WDBETU1LRE04emhtcnphRXJISVo4VzF0eFlUWjhZ?=
 =?utf-8?B?U0o3ZEFuclZxOUZLOCtBL2s3Sk5WL2M0TTJ0clJpb1FiQk11b21TdWhuSE8r?=
 =?utf-8?B?S0QzdE1icmxBMmwxU3VIb3psZy81bW5wdUhmUEJUdkFMVC92cXVMa1VMNmpX?=
 =?utf-8?B?NWs3SEJ6SVhwTENhY0RFbC92bllhSUpUVVE0TWxSYkN6QnozcXQzQmxvTHhv?=
 =?utf-8?B?bVgwcjZ3K1R0NXJKTm5FNjlndVF0VCtsZG13ZG9JeUU0ZGpWMFZGK2c5NjZN?=
 =?utf-8?B?ckliWXFpUkE1SE11bVlqV1FuR0JZcFR2ZDZIdTk1aVkrVUFNeENpOThUUXU5?=
 =?utf-8?B?RDYzUHVmdWkvakJ2bTVmV1FYQnM2YmhZMXdjZXFxRHhrSllHK1dMcUFoaUo1?=
 =?utf-8?B?S21xaTJhZGRDRDJhdGMxSVhkKzRnL0VIeGhqWE9EMDB4MWFQZmkzSHB0SVFQ?=
 =?utf-8?B?UEl1aTR6Rit0Z1cyYVFvQVprT3hjNGt0TWRnSWY4N2dwbVhnVFBmSWZvbllq?=
 =?utf-8?B?TVFjQVhvYmtQVG1DOCtrVkQwN2VpZFV3bG4zWUNYNWF3RHo3ZU1YNWZJb0hr?=
 =?utf-8?B?Rzl0MnErZkEwc0lYekxBQU9KNFNUMWRvL1dlYWNKSzJGVjQwdVBpa2xuNGxY?=
 =?utf-8?B?TGtVN0dQN05JeDJYdEwzakNEYURxd2l3YjdOQTEwNWhqUzVBZkpCeFFWS1dm?=
 =?utf-8?B?NUZ1VllJbGdDclhpcFl5dVpCemtjcVBBaTVTbzZpdTBBV3R5Qk9CQmVSZ2Iw?=
 =?utf-8?B?NEJiU0xvWjN4YStQWHhyS1dxK1RtMk1LQ0lNZ3FtSElLYmtHbzZMNFZTd0RT?=
 =?utf-8?B?SHlnSTNBcXZiNFR4U0lDcDhOd0NNNFAwYmpUSjZ4RlgvalJ6WTYxQ1JoQWRM?=
 =?utf-8?B?cnp5STZ2Mmd4Rk1VYTcyelh5a1dqcXlsN2x3d3hMUzBveFM5Uld4aEFUUmNs?=
 =?utf-8?B?ZDJiUEZtZFVicVVrdHEyVm1Vb2RDRkFvUEozbWVkb1NqcmRHTUhiUDdDOFIv?=
 =?utf-8?B?ejgxUVRWM1N3eWVvZkdKdndWVDZsL2NOZGZ2VkVuS1NlMTVGT0t1TC9yYnB3?=
 =?utf-8?B?MHEra3dmZm81YTNPU3hNNFd4WUFxaVArOVo3R1FySExRVUdmZWlKVXVLaWdi?=
 =?utf-8?B?aEh4VzRQbU5yMHY5Nmw2QUQ2eGRxMTdtMjN0RXZOSGxVQ2FlSUZIcHBVUE1U?=
 =?utf-8?B?eVNNWkZZRllJYmtPbnpXRWd2WjNqSjFUcklnRFFNT0w4ZTgyeEowN2YyeDVP?=
 =?utf-8?B?LzRhbVdaYVlXMkRFSFl6OFhJMURuYkYrRGhWZU1ua1RIeFhvdmRoM0RyT0RV?=
 =?utf-8?B?N3FuUVRGV242UE5KcHJIRm5aZ1FNRzQ3U3hNRDJ2VUl1MG9hcHFEQVRkdFdN?=
 =?utf-8?B?NVZwYnIrOEtIaTNWOUVLQ3p5MDVlWGtJMWJscUZEZm9waUF3dDh3b0lyL1Fx?=
 =?utf-8?Q?N3HYQHZHUM6um0vSiIiyXKGLb5Ywz8MnTncv0b3?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 99d2d192-42a5-477d-5849-08d984e7efb0
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Oct 2021 14:30:14.7482
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8G14BTS4nGz/BVVwbZUXqT9Ff30lSekRrkJHs2Z/0knL04JZyiBwlC3+dKXha29XzD1S1yK6bD+UA+wsDss3s5tHnQxI1AP27WafXIFLOHs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR03MB4966
X-OriginatorOrg: citrix.com

On 01/10/2021 15:19, Jan Beulich wrote:
> On 24.09.2021 21:39, Alex Olson wrote:
>> Inspired by an earlier attempt by Chao Gao <chao.gao@intel.com>,
>> this revision aims to put the hypervisor in control of x86 APIC identifier
>> definition instead of hard-coding a formula in multiple places
>> (libxl, hvmloader, hypervisor).
>>
>> This is intended as a first step toward exposing/altering CPU topology
>> seen by guests.
>>
>> Changes:
>>
>> - Add field to vlapic for holding default ID (on reset)
>>
>> - add HVMOP_get_vcpu_topology_id hypercall so libxl (for PVH domains)
>>   can access APIC ids needed for ACPI table definition prior to domain start.
>>
>> - For HVM guests, hvmloader now also uses the same hypercall.
>>
>> - Make CPUID code use vlapic ID instead of hard-coded formula
>>   for runtime reporting to guests
> I'm afraid a primary question from back at the time remains: How is
> migration of a guest from an old hypervisor to one with this change
> in place going to work?

I'm afraid its not.

Fixing this is incredibly complicated.  I have a vague plan, but it
needs building on the still-pending libxl cpuid work of Rogers.

Both the toolstack and Xen need to learn about how to describe topology
correctly (and I'm afraid this patch isn't correct even for a number of
the simple cases), and know about "every VM booted up until this point
in time" being wrong.

~Andrew


From xen-devel-bounces@lists.xenproject.org Fri Oct 01 15:00:55 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Oct 2021 15:00:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.200703.355254 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mWK1s-0006mx-N0; Fri, 01 Oct 2021 15:00:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 200703.355254; Fri, 01 Oct 2021 15:00:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mWK1s-0006mo-Jp; Fri, 01 Oct 2021 15:00:52 +0000
Received: by outflank-mailman (input) for mailman id 200703;
 Fri, 01 Oct 2021 15:00:51 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=kuDH=OV=suse.com=jgross@srs-us1.protection.inumbo.net>)
 id 1mWK1r-0006hf-5l
 for xen-devel@lists.xenproject.org; Fri, 01 Oct 2021 15:00:51 +0000
Received: from smtp-out1.suse.de (unknown [195.135.220.28])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 5b9457da-22c8-11ec-bdb2-12813bfff9fa;
 Fri, 01 Oct 2021 15:00:47 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 7D86022535;
 Fri,  1 Oct 2021 15:00:46 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 3E69113C6D;
 Fri,  1 Oct 2021 15:00:46 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id EJKvDZ4iV2G5OgAAMHmgww
 (envelope-from <jgross@suse.com>); Fri, 01 Oct 2021 15:00:46 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5b9457da-22c8-11ec-bdb2-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1633100446; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=cGmcOPkibPwxJCbGpIQrWUFBFpAyeOL3a0/tpnlA0K8=;
	b=jCy/X2qe8LzUWplBb4fqWdHHsghMwHFlw2mtHj180FsXrYTwQqEnqDAZqxrcRqeILxa+t2
	sR1WL+z1Zx2eg0PcU6/kVJE6AgCbnKNXscBOqV/g/14VIrMt0lMqJv5B6q2FuU0dHErlR7
	I5UNhlOXEK53i6mUgd8UV4L+NdcZtlE=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org,
	linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org
Cc: Juergen Gross <jgross@suse.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: [PATCH v5 2/3] usb: Introduce Xen pvUSB frontend (xen hcd)
Date: Fri,  1 Oct 2021 17:00:38 +0200
Message-Id: <20211001150039.15921-3-jgross@suse.com>
X-Mailer: git-send-email 2.26.2
In-Reply-To: <20211001150039.15921-1-jgross@suse.com>
References: <20211001150039.15921-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Introduces the Xen pvUSB frontend. With pvUSB it is possible for a Xen
domU to communicate with a USB device assigned to that domU. The
communication is all done via the pvUSB backend in a driver domain
(usually Dom0) which is owner of the physical device.

The pvUSB frontend is a USB hcd for a virtual USB host connector.

The code is taken from the pvUSB implementation in Xen done by Fujitsu
based on Linux kernel 2.6.18.

Changes from the original version are:
- port to upstream kernel
- put all code in just one source file
- move module to appropriate location in kernel tree
- adapt to Linux style guide
- minor code modifications to increase readability

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 drivers/usb/host/Kconfig   |   11 +
 drivers/usb/host/Makefile  |    1 +
 drivers/usb/host/xen-hcd.c | 1641 ++++++++++++++++++++++++++++++++++++
 3 files changed, 1653 insertions(+)
 create mode 100644 drivers/usb/host/xen-hcd.c

diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig
index c4736d1d020c..c0a398aeb7c6 100644
--- a/drivers/usb/host/Kconfig
+++ b/drivers/usb/host/Kconfig
@@ -770,3 +770,14 @@ config USB_HCD_TEST_MODE
 	  This option is of interest only to developers who need to validate
 	  their USB hardware designs.  It is not needed for normal use.  If
 	  unsure, say N.
+
+config USB_XEN_HCD
+	tristate "Xen usb virtual host driver"
+	depends on XEN
+	select XEN_XENBUS_FRONTEND
+	help
+	  The Xen usb virtual host driver serves as a frontend driver enabling
+	  a Xen guest system to access USB Devices passed through to the guest
+	  by the Xen host (usually Dom0).
+	  Only needed if the kernel is running in a Xen guest and generic
+	  access to a USB device is needed.
diff --git a/drivers/usb/host/Makefile b/drivers/usb/host/Makefile
index 171de4df50bd..2948983618fb 100644
--- a/drivers/usb/host/Makefile
+++ b/drivers/usb/host/Makefile
@@ -85,3 +85,4 @@ obj-$(CONFIG_USB_HCD_BCMA)	+= bcma-hcd.o
 obj-$(CONFIG_USB_HCD_SSB)	+= ssb-hcd.o
 obj-$(CONFIG_USB_FOTG210_HCD)	+= fotg210-hcd.o
 obj-$(CONFIG_USB_MAX3421_HCD)	+= max3421-hcd.o
+obj-$(CONFIG_USB_XEN_HCD)	+= xen-hcd.o
diff --git a/drivers/usb/host/xen-hcd.c b/drivers/usb/host/xen-hcd.c
new file mode 100644
index 000000000000..88692ee088dd
--- /dev/null
+++ b/drivers/usb/host/xen-hcd.c
@@ -0,0 +1,1641 @@
+/*
+ * xen-hcd.c
+ *
+ * Xen USB Virtual Host Controller driver
+ *
+ * Copyright (C) 2009, FUJITSU LABORATORIES LTD.
+ * Author: Noboru Iwamatsu <n_iwamatsu@jp.fujitsu.com>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, see <http://www.gnu.org/licenses/>.
+ *
+ * Or, by your choice:
+ *
+ * When distributed separately from the Linux kernel or incorporated into
+ * other software packages, subject to the following license:
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a copy
+ * of this software and associated documentation files (the "Software"), to
+ * deal in the Software without restriction, including without limitation the
+ * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or
+ * sell copies of the Software, and to permit persons to whom the Software is
+ * furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice shall be included in
+ * all copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+ * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
+ * DEALINGS IN THE SOFTWARE.
+ */
+
+#include <linux/module.h>
+#include <linux/usb.h>
+#include <linux/list.h>
+#include <linux/usb/hcd.h>
+#include <linux/io.h>
+
+#include <xen/xen.h>
+#include <xen/xenbus.h>
+#include <xen/grant_table.h>
+#include <xen/events.h>
+#include <xen/page.h>
+
+#include <xen/interface/io/usbif.h>
+
+/* Private per-URB data */
+struct urb_priv {
+	struct list_head list;
+	struct urb *urb;
+	int req_id;		/* RING_REQUEST id for submitting */
+	int unlink_req_id;	/* RING_REQUEST id for unlinking */
+	int status;
+	bool unlinked;		/* dequeued marker */
+};
+
+/* virtual roothub port status */
+struct rhport_status {
+	__u32 status;
+	bool resuming;		/* in resuming */
+	bool c_connection;	/* connection changed */
+	unsigned long timeout;
+};
+
+/* status of attached device */
+struct vdevice_status {
+	int devnum;
+	enum usb_device_state status;
+	enum usb_device_speed speed;
+};
+
+/* RING request shadow */
+struct usb_shadow {
+	struct xenusb_urb_request req;
+	struct urb *urb;
+};
+
+struct xenhcd_info {
+	/* Virtual Host Controller has 4 urb queues */
+	struct list_head pending_submit_list;
+	struct list_head pending_unlink_list;
+	struct list_head in_progress_list;
+	struct list_head giveback_waiting_list;
+
+	spinlock_t lock;
+
+	/* timer that kick pending and giveback waiting urbs */
+	struct timer_list watchdog;
+	unsigned long actions;
+
+	/* virtual root hub */
+	int rh_numports;
+	struct rhport_status ports[XENUSB_MAX_PORTNR];
+	struct vdevice_status devices[XENUSB_MAX_PORTNR];
+
+	/* Xen related staff */
+	struct xenbus_device *xbdev;
+	int urb_ring_ref;
+	int conn_ring_ref;
+	struct xenusb_urb_front_ring urb_ring;
+	struct xenusb_conn_front_ring conn_ring;
+
+	unsigned int evtchn;
+	unsigned int irq;
+	struct usb_shadow shadow[XENUSB_URB_RING_SIZE];
+	unsigned int shadow_free;
+
+	bool error;
+};
+
+#define GRANT_INVALID_REF 0
+
+#define XENHCD_RING_JIFFIES (HZ/200)
+#define XENHCD_SCAN_JIFFIES 1
+
+enum xenhcd_timer_action {
+	TIMER_RING_WATCHDOG,
+	TIMER_SCAN_PENDING_URBS,
+};
+
+static struct kmem_cache *xenhcd_urbp_cachep;
+
+static inline struct xenhcd_info *xenhcd_hcd_to_info(struct usb_hcd *hcd)
+{
+	return (struct xenhcd_info *)hcd->hcd_priv;
+}
+
+static inline struct usb_hcd *xenhcd_info_to_hcd(struct xenhcd_info *info)
+{
+	return container_of((void *)info, struct usb_hcd, hcd_priv);
+}
+
+static void xenhcd_set_error(struct xenhcd_info *info, const char *msg)
+{
+	info->error = true;
+
+	pr_alert("xen-hcd: protocol error: %s!\n", msg);
+}
+
+static inline void xenhcd_timer_action_done(struct xenhcd_info *info,
+					    enum xenhcd_timer_action action)
+{
+	clear_bit(action, &info->actions);
+}
+
+static void xenhcd_timer_action(struct xenhcd_info *info,
+				enum xenhcd_timer_action action)
+{
+	if (timer_pending(&info->watchdog) &&
+	    test_bit(TIMER_SCAN_PENDING_URBS, &info->actions))
+		return;
+
+	if (!test_and_set_bit(action, &info->actions)) {
+		unsigned long t;
+
+		switch (action) {
+		case TIMER_RING_WATCHDOG:
+			t = XENHCD_RING_JIFFIES;
+			break;
+		default:
+			t = XENHCD_SCAN_JIFFIES;
+			break;
+		}
+		mod_timer(&info->watchdog, t + jiffies);
+	}
+}
+
+/*
+ * set virtual port connection status
+ */
+static void xenhcd_set_connect_state(struct xenhcd_info *info, int portnum)
+{
+	int port;
+
+	port = portnum - 1;
+	if (info->ports[port].status & USB_PORT_STAT_POWER) {
+		switch (info->devices[port].speed) {
+		case XENUSB_SPEED_NONE:
+			info->ports[port].status &=
+				~(USB_PORT_STAT_CONNECTION |
+				  USB_PORT_STAT_ENABLE |
+				  USB_PORT_STAT_LOW_SPEED |
+				  USB_PORT_STAT_HIGH_SPEED |
+				  USB_PORT_STAT_SUSPEND);
+			break;
+		case XENUSB_SPEED_LOW:
+			info->ports[port].status |= USB_PORT_STAT_CONNECTION;
+			info->ports[port].status |= USB_PORT_STAT_LOW_SPEED;
+			break;
+		case XENUSB_SPEED_FULL:
+			info->ports[port].status |= USB_PORT_STAT_CONNECTION;
+			break;
+		case XENUSB_SPEED_HIGH:
+			info->ports[port].status |= USB_PORT_STAT_CONNECTION;
+			info->ports[port].status |= USB_PORT_STAT_HIGH_SPEED;
+			break;
+		default: /* error */
+			return;
+		}
+		info->ports[port].status |= (USB_PORT_STAT_C_CONNECTION << 16);
+	}
+}
+
+/*
+ * set virtual device connection status
+ */
+static int xenhcd_rhport_connect(struct xenhcd_info *info, __u8 portnum,
+				 __u8 speed)
+{
+	int port;
+
+	if (portnum < 1 || portnum > info->rh_numports)
+		return -EINVAL; /* invalid port number */
+
+	port = portnum - 1;
+	if (info->devices[port].speed != speed) {
+		switch (speed) {
+		case XENUSB_SPEED_NONE: /* disconnect */
+			info->devices[port].status = USB_STATE_NOTATTACHED;
+			break;
+		case XENUSB_SPEED_LOW:
+		case XENUSB_SPEED_FULL:
+		case XENUSB_SPEED_HIGH:
+			info->devices[port].status = USB_STATE_ATTACHED;
+			break;
+		default: /* error */
+			return -EINVAL;
+		}
+		info->devices[port].speed = speed;
+		info->ports[port].c_connection = true;
+
+		xenhcd_set_connect_state(info, portnum);
+	}
+
+	return 0;
+}
+
+/*
+ * SetPortFeature(PORT_SUSPENDED)
+ */
+static void xenhcd_rhport_suspend(struct xenhcd_info *info, int portnum)
+{
+	int port;
+
+	port = portnum - 1;
+	info->ports[port].status |= USB_PORT_STAT_SUSPEND;
+	info->devices[port].status = USB_STATE_SUSPENDED;
+}
+
+/*
+ * ClearPortFeature(PORT_SUSPENDED)
+ */
+static void xenhcd_rhport_resume(struct xenhcd_info *info, int portnum)
+{
+	int port;
+
+	port = portnum - 1;
+	if (info->ports[port].status & USB_PORT_STAT_SUSPEND) {
+		info->ports[port].resuming = true;
+		info->ports[port].timeout = jiffies + msecs_to_jiffies(20);
+	}
+}
+
+/*
+ * SetPortFeature(PORT_POWER)
+ */
+static void xenhcd_rhport_power_on(struct xenhcd_info *info, int portnum)
+{
+	int port;
+
+	port = portnum - 1;
+	if ((info->ports[port].status & USB_PORT_STAT_POWER) == 0) {
+		info->ports[port].status |= USB_PORT_STAT_POWER;
+		if (info->devices[port].status != USB_STATE_NOTATTACHED)
+			info->devices[port].status = USB_STATE_POWERED;
+		if (info->ports[port].c_connection)
+			xenhcd_set_connect_state(info, portnum);
+	}
+}
+
+/*
+ * ClearPortFeature(PORT_POWER)
+ * SetConfiguration(non-zero)
+ * Power_Source_Off
+ * Over-current
+ */
+static void xenhcd_rhport_power_off(struct xenhcd_info *info, int portnum)
+{
+	int port;
+
+	port = portnum - 1;
+	if (info->ports[port].status & USB_PORT_STAT_POWER) {
+		info->ports[port].status = 0;
+		if (info->devices[port].status != USB_STATE_NOTATTACHED)
+			info->devices[port].status = USB_STATE_ATTACHED;
+	}
+}
+
+/*
+ * ClearPortFeature(PORT_ENABLE)
+ */
+static void xenhcd_rhport_disable(struct xenhcd_info *info, int portnum)
+{
+	int port;
+
+	port = portnum - 1;
+	info->ports[port].status &= ~USB_PORT_STAT_ENABLE;
+	info->ports[port].status &= ~USB_PORT_STAT_SUSPEND;
+	info->ports[port].resuming = false;
+	if (info->devices[port].status != USB_STATE_NOTATTACHED)
+		info->devices[port].status = USB_STATE_POWERED;
+}
+
+/*
+ * SetPortFeature(PORT_RESET)
+ */
+static void xenhcd_rhport_reset(struct xenhcd_info *info, int portnum)
+{
+	int port;
+
+	port = portnum - 1;
+	info->ports[port].status &= ~(USB_PORT_STAT_ENABLE |
+				      USB_PORT_STAT_LOW_SPEED |
+				      USB_PORT_STAT_HIGH_SPEED);
+	info->ports[port].status |= USB_PORT_STAT_RESET;
+
+	if (info->devices[port].status != USB_STATE_NOTATTACHED)
+		info->devices[port].status = USB_STATE_ATTACHED;
+
+	/* 10msec reset signaling */
+	info->ports[port].timeout = jiffies + msecs_to_jiffies(10);
+}
+
+#ifdef CONFIG_PM
+static int xenhcd_bus_suspend(struct usb_hcd *hcd)
+{
+	struct xenhcd_info *info = xenhcd_hcd_to_info(hcd);
+	int ret = 0;
+	int i, ports;
+
+	ports = info->rh_numports;
+
+	spin_lock_irq(&info->lock);
+	if (!test_bit(HCD_FLAG_HW_ACCESSIBLE, &hcd->flags)) {
+		ret = -ESHUTDOWN;
+	} else {
+		/* suspend any active ports*/
+		for (i = 1; i <= ports; i++)
+			xenhcd_rhport_suspend(info, i);
+	}
+	spin_unlock_irq(&info->lock);
+
+	del_timer_sync(&info->watchdog);
+
+	return ret;
+}
+
+static int xenhcd_bus_resume(struct usb_hcd *hcd)
+{
+	struct xenhcd_info *info = xenhcd_hcd_to_info(hcd);
+	int ret = 0;
+	int i, ports;
+
+	ports = info->rh_numports;
+
+	spin_lock_irq(&info->lock);
+	if (!test_bit(HCD_FLAG_HW_ACCESSIBLE, &hcd->flags)) {
+		ret = -ESHUTDOWN;
+	} else {
+		/* resume any suspended ports*/
+		for (i = 1; i <= ports; i++)
+			xenhcd_rhport_resume(info, i);
+	}
+	spin_unlock_irq(&info->lock);
+
+	return ret;
+}
+#endif
+
+static void xenhcd_hub_descriptor(struct xenhcd_info *info,
+				  struct usb_hub_descriptor *desc)
+{
+	__u16 temp;
+	int ports = info->rh_numports;
+
+	desc->bDescriptorType = 0x29;
+	desc->bPwrOn2PwrGood = 10; /* EHCI says 20ms max */
+	desc->bHubContrCurrent = 0;
+	desc->bNbrPorts = ports;
+
+	/* size of DeviceRemovable and PortPwrCtrlMask fields */
+	temp = 1 + (ports / 8);
+	desc->bDescLength = 7 + 2 * temp;
+
+	/* bitmaps for DeviceRemovable and PortPwrCtrlMask */
+	memset(&desc->u.hs.DeviceRemovable[0], 0, temp);
+	memset(&desc->u.hs.DeviceRemovable[temp], 0xff, temp);
+
+	/* per-port over current reporting and no power switching */
+	temp = 0x000a;
+	desc->wHubCharacteristics = cpu_to_le16(temp);
+}
+
+/* port status change mask for hub_status_data */
+#define PORT_C_MASK	((USB_PORT_STAT_C_CONNECTION |		\
+			  USB_PORT_STAT_C_ENABLE |		\
+			  USB_PORT_STAT_C_SUSPEND |		\
+			  USB_PORT_STAT_C_OVERCURRENT |		\
+			  USB_PORT_STAT_C_RESET) << 16)
+
+/*
+ * See USB 2.0 Spec, 11.12.4 Hub and Port Status Change Bitmap.
+ * If port status changed, writes the bitmap to buf and return
+ * that length(number of bytes).
+ * If Nothing changed, return 0.
+ */
+static int xenhcd_hub_status_data(struct usb_hcd *hcd, char *buf)
+{
+	struct xenhcd_info *info = xenhcd_hcd_to_info(hcd);
+	int ports;
+	int i;
+	unsigned long flags;
+	int ret;
+	int changed = 0;
+
+	/* initialize the status to no-changes */
+	ports = info->rh_numports;
+	ret = 1 + (ports / 8);
+	memset(buf, 0, ret);
+
+	spin_lock_irqsave(&info->lock, flags);
+
+	for (i = 0; i < ports; i++) {
+		/* check status for each port */
+		if (info->ports[i].status & PORT_C_MASK) {
+			buf[(i + 1) / 8] |= 1 << (i + 1) % 8;
+			changed = 1;
+		}
+	}
+
+	if ((hcd->state == HC_STATE_SUSPENDED) && (changed == 1))
+		usb_hcd_resume_root_hub(hcd);
+
+	spin_unlock_irqrestore(&info->lock, flags);
+
+	return changed ? ret : 0;
+}
+
+static int xenhcd_hub_control(struct usb_hcd *hcd, __u16 typeReq, __u16 wValue,
+			      __u16 wIndex, char *buf, __u16 wLength)
+{
+	struct xenhcd_info *info = xenhcd_hcd_to_info(hcd);
+	int ports = info->rh_numports;
+	unsigned long flags;
+	int ret = 0;
+	int i;
+	int changed = 0;
+
+	spin_lock_irqsave(&info->lock, flags);
+	switch (typeReq) {
+	case ClearHubFeature:
+		/* ignore this request */
+		break;
+	case ClearPortFeature:
+		if (!wIndex || wIndex > ports)
+			goto error;
+
+		switch (wValue) {
+		case USB_PORT_FEAT_SUSPEND:
+			xenhcd_rhport_resume(info, wIndex);
+			break;
+		case USB_PORT_FEAT_POWER:
+			xenhcd_rhport_power_off(info, wIndex);
+			break;
+		case USB_PORT_FEAT_ENABLE:
+			xenhcd_rhport_disable(info, wIndex);
+			break;
+		case USB_PORT_FEAT_C_CONNECTION:
+			info->ports[wIndex - 1].c_connection = false;
+			fallthrough;
+		default:
+			info->ports[wIndex - 1].status &= ~(1 << wValue);
+			break;
+		}
+		break;
+	case GetHubDescriptor:
+		xenhcd_hub_descriptor(info, (struct usb_hub_descriptor *)buf);
+		break;
+	case GetHubStatus:
+		/* always local power supply good and no over-current exists. */
+		*(__le32 *)buf = cpu_to_le32(0);
+		break;
+	case GetPortStatus:
+		if (!wIndex || wIndex > ports)
+			goto error;
+
+		wIndex--;
+
+		/* resume completion */
+		if (info->ports[wIndex].resuming &&
+		    time_after_eq(jiffies, info->ports[wIndex].timeout)) {
+			info->ports[wIndex].status |=
+				USB_PORT_STAT_C_SUSPEND << 16;
+			info->ports[wIndex].status &= ~USB_PORT_STAT_SUSPEND;
+		}
+
+		/* reset completion */
+		if ((info->ports[wIndex].status & USB_PORT_STAT_RESET) != 0 &&
+		    time_after_eq(jiffies, info->ports[wIndex].timeout)) {
+			info->ports[wIndex].status |=
+				USB_PORT_STAT_C_RESET << 16;
+			info->ports[wIndex].status &= ~USB_PORT_STAT_RESET;
+
+			if (info->devices[wIndex].status !=
+			    USB_STATE_NOTATTACHED) {
+				info->ports[wIndex].status |=
+					USB_PORT_STAT_ENABLE;
+				info->devices[wIndex].status =
+					USB_STATE_DEFAULT;
+			}
+
+			switch (info->devices[wIndex].speed) {
+			case XENUSB_SPEED_LOW:
+				info->ports[wIndex].status |=
+					USB_PORT_STAT_LOW_SPEED;
+				break;
+			case XENUSB_SPEED_HIGH:
+				info->ports[wIndex].status |=
+					USB_PORT_STAT_HIGH_SPEED;
+				break;
+			default:
+				break;
+			}
+		}
+
+		*(__le32 *)buf = cpu_to_le32(info->ports[wIndex].status);
+		break;
+	case SetPortFeature:
+		if (!wIndex || wIndex > ports)
+			goto error;
+
+		switch (wValue) {
+		case USB_PORT_FEAT_POWER:
+			xenhcd_rhport_power_on(info, wIndex);
+			break;
+		case USB_PORT_FEAT_RESET:
+			xenhcd_rhport_reset(info, wIndex);
+			break;
+		case USB_PORT_FEAT_SUSPEND:
+			xenhcd_rhport_suspend(info, wIndex);
+			break;
+		default:
+			if (info->ports[wIndex-1].status & USB_PORT_STAT_POWER)
+				info->ports[wIndex-1].status |= (1 << wValue);
+		}
+		break;
+
+	case SetHubFeature:
+		/* not supported */
+	default:
+error:
+		ret = -EPIPE;
+	}
+	spin_unlock_irqrestore(&info->lock, flags);
+
+	/* check status for each port */
+	for (i = 0; i < ports; i++) {
+		if (info->ports[i].status & PORT_C_MASK)
+			changed = 1;
+	}
+	if (changed)
+		usb_hcd_poll_rh_status(hcd);
+
+	return ret;
+}
+
+static void xenhcd_free_urb_priv(struct urb_priv *urbp)
+{
+	urbp->urb->hcpriv = NULL;
+	kmem_cache_free(xenhcd_urbp_cachep, urbp);
+}
+
+static inline unsigned int xenhcd_get_id_from_freelist(struct xenhcd_info *info)
+{
+	unsigned int free;
+
+	free = info->shadow_free;
+	info->shadow_free = info->shadow[free].req.id;
+	info->shadow[free].req.id = 0x0fff; /* debug */
+	return free;
+}
+
+static inline void xenhcd_add_id_to_freelist(struct xenhcd_info *info,
+					     unsigned int id)
+{
+	info->shadow[id].req.id	= info->shadow_free;
+	info->shadow[id].urb = NULL;
+	info->shadow_free = id;
+}
+
+static inline int xenhcd_count_pages(void *addr, int length)
+{
+	unsigned long vaddr = (unsigned long)addr;
+
+	return PFN_UP(vaddr + length) - PFN_DOWN(vaddr);
+}
+
+static void xenhcd_gnttab_map(struct xenhcd_info *info, void *addr, int length,
+			      grant_ref_t *gref_head,
+			      struct xenusb_request_segment *seg,
+			      int nr_pages, int flags)
+{
+	grant_ref_t ref;
+	unsigned long buffer_mfn;
+	unsigned int offset;
+	unsigned int len = length;
+	unsigned int bytes;
+	int i;
+
+	for (i = 0; i < nr_pages; i++) {
+		buffer_mfn = PFN_DOWN(arbitrary_virt_to_machine(addr).maddr);
+		offset = offset_in_page(addr);
+
+		bytes = PAGE_SIZE - offset;
+		if (bytes > len)
+			bytes = len;
+
+		ref = gnttab_claim_grant_reference(gref_head);
+		gnttab_grant_foreign_access_ref(ref, info->xbdev->otherend_id,
+						buffer_mfn, flags);
+		seg[i].gref = ref;
+		seg[i].offset = (__u16)offset;
+		seg[i].length = (__u16)bytes;
+
+		addr += bytes;
+		len -= bytes;
+	}
+}
+
+static __u32 xenhcd_pipe_urb_to_xenusb(__u32 urb_pipe, __u8 port)
+{
+	static __u32 pipe;
+
+	pipe = usb_pipedevice(urb_pipe) << XENUSB_PIPE_DEV_SHIFT;
+	pipe |= usb_pipeendpoint(urb_pipe) << XENUSB_PIPE_EP_SHIFT;
+	if (usb_pipein(urb_pipe))
+		pipe |= XENUSB_PIPE_DIR;
+	switch (usb_pipetype(urb_pipe)) {
+	case PIPE_ISOCHRONOUS:
+		pipe |= XENUSB_PIPE_TYPE_ISOC << XENUSB_PIPE_TYPE_SHIFT;
+		break;
+	case PIPE_INTERRUPT:
+		pipe |= XENUSB_PIPE_TYPE_INT << XENUSB_PIPE_TYPE_SHIFT;
+		break;
+	case PIPE_CONTROL:
+		pipe |= XENUSB_PIPE_TYPE_CTRL << XENUSB_PIPE_TYPE_SHIFT;
+		break;
+	case PIPE_BULK:
+		pipe |= XENUSB_PIPE_TYPE_BULK << XENUSB_PIPE_TYPE_SHIFT;
+		break;
+	}
+	pipe = xenusb_setportnum_pipe(pipe, port);
+
+	return pipe;
+}
+
+static int xenhcd_map_urb_for_request(struct xenhcd_info *info, struct urb *urb,
+				      struct xenusb_urb_request *req)
+{
+	grant_ref_t gref_head;
+	int nr_buff_pages = 0;
+	int nr_isodesc_pages = 0;
+	int nr_grants = 0;
+
+	if (urb->transfer_buffer_length) {
+		nr_buff_pages = xenhcd_count_pages(urb->transfer_buffer,
+						urb->transfer_buffer_length);
+
+		if (usb_pipeisoc(urb->pipe))
+			nr_isodesc_pages = xenhcd_count_pages(
+				&urb->iso_frame_desc[0],
+				sizeof(struct usb_iso_packet_descriptor) *
+				urb->number_of_packets);
+
+		nr_grants = nr_buff_pages + nr_isodesc_pages;
+		if (nr_grants > XENUSB_MAX_SEGMENTS_PER_REQUEST) {
+			pr_err("xenhcd: error: %d grants\n", nr_grants);
+			return -E2BIG;
+		}
+
+		if (gnttab_alloc_grant_references(nr_grants, &gref_head)) {
+			pr_err("xenhcd: gnttab_alloc_grant_references() error\n");
+			return -ENOMEM;
+		}
+
+		xenhcd_gnttab_map(info, urb->transfer_buffer,
+				  urb->transfer_buffer_length, &gref_head,
+				  &req->seg[0], nr_buff_pages,
+				  usb_pipein(urb->pipe) ? 0 : GTF_readonly);
+	}
+
+	req->pipe = xenhcd_pipe_urb_to_xenusb(urb->pipe, urb->dev->portnum);
+	req->transfer_flags = 0;
+	if (urb->transfer_flags & URB_SHORT_NOT_OK)
+		req->transfer_flags |= XENUSB_SHORT_NOT_OK;
+	req->buffer_length = urb->transfer_buffer_length;
+	req->nr_buffer_segs = nr_buff_pages;
+
+	switch (usb_pipetype(urb->pipe)) {
+	case PIPE_ISOCHRONOUS:
+		req->u.isoc.interval = urb->interval;
+		req->u.isoc.start_frame = urb->start_frame;
+		req->u.isoc.number_of_packets = urb->number_of_packets;
+		req->u.isoc.nr_frame_desc_segs = nr_isodesc_pages;
+
+		xenhcd_gnttab_map(info, &urb->iso_frame_desc[0],
+				  sizeof(struct usb_iso_packet_descriptor) *
+				  urb->number_of_packets,
+				  &gref_head, &req->seg[nr_buff_pages],
+				  nr_isodesc_pages, 0);
+		break;
+	case PIPE_INTERRUPT:
+		req->u.intr.interval = urb->interval;
+		break;
+	case PIPE_CONTROL:
+		if (urb->setup_packet)
+			memcpy(req->u.ctrl, urb->setup_packet, 8);
+		break;
+	case PIPE_BULK:
+		break;
+	default:
+		break;
+	}
+
+	if (nr_grants)
+		gnttab_free_grant_references(gref_head);
+
+	return 0;
+}
+
+static void xenhcd_gnttab_done(struct usb_shadow *shadow)
+{
+	int nr_segs = 0;
+	int i;
+
+	nr_segs = shadow->req.nr_buffer_segs;
+
+	if (xenusb_pipeisoc(shadow->req.pipe))
+		nr_segs += shadow->req.u.isoc.nr_frame_desc_segs;
+
+	for (i = 0; i < nr_segs; i++)
+		gnttab_end_foreign_access(shadow->req.seg[i].gref, 0, 0UL);
+
+	shadow->req.nr_buffer_segs = 0;
+	shadow->req.u.isoc.nr_frame_desc_segs = 0;
+}
+
+static int xenhcd_translate_status(int status)
+{
+	switch (status) {
+	case XENUSB_STATUS_OK:
+		return 0;
+	case XENUSB_STATUS_NODEV:
+		return -ENODEV;
+	case XENUSB_STATUS_INVAL:
+		return -EINVAL;
+	case XENUSB_STATUS_STALL:
+		return -EPIPE;
+	case XENUSB_STATUS_IOERROR:
+		return -EPROTO;
+	case XENUSB_STATUS_BABBLE:
+		return -EOVERFLOW;
+	default:
+		return -ESHUTDOWN;
+	}
+}
+
+static void xenhcd_giveback_urb(struct xenhcd_info *info, struct urb *urb,
+				int status)
+{
+	struct urb_priv *urbp = (struct urb_priv *)urb->hcpriv;
+	int priv_status = urbp->status;
+
+	list_del_init(&urbp->list);
+	xenhcd_free_urb_priv(urbp);
+
+	if (urb->status == -EINPROGRESS)
+		urb->status = xenhcd_translate_status(status);
+
+	spin_unlock(&info->lock);
+	usb_hcd_giveback_urb(xenhcd_info_to_hcd(info), urb,
+			     priv_status <= 0 ? priv_status : urb->status);
+	spin_lock(&info->lock);
+}
+
+static int xenhcd_do_request(struct xenhcd_info *info, struct urb_priv *urbp)
+{
+	struct xenusb_urb_request *req;
+	struct urb *urb = urbp->urb;
+	unsigned int id;
+	int notify;
+	int ret;
+
+	id = xenhcd_get_id_from_freelist(info);
+	req = &info->shadow[id].req;
+	req->id = id;
+
+	if (unlikely(urbp->unlinked)) {
+		req->u.unlink.unlink_id = urbp->req_id;
+		req->pipe = xenusb_setunlink_pipe(xenhcd_pipe_urb_to_xenusb(
+						 urb->pipe, urb->dev->portnum));
+		urbp->unlink_req_id = id;
+	} else {
+		ret = xenhcd_map_urb_for_request(info, urb, req);
+		if (ret) {
+			xenhcd_add_id_to_freelist(info, id);
+			return ret;
+		}
+		urbp->req_id = id;
+	}
+
+	req = RING_GET_REQUEST(&info->urb_ring, info->urb_ring.req_prod_pvt);
+	*req = info->shadow[id].req;
+
+	info->urb_ring.req_prod_pvt++;
+	info->shadow[id].urb = urb;
+
+	RING_PUSH_REQUESTS_AND_CHECK_NOTIFY(&info->urb_ring, notify);
+	if (notify)
+		notify_remote_via_irq(info->irq);
+
+	return 0;
+}
+
+static void xenhcd_kick_pending_urbs(struct xenhcd_info *info)
+{
+	struct urb_priv *urbp;
+
+	while (!list_empty(&info->pending_submit_list)) {
+		if (RING_FULL(&info->urb_ring)) {
+			xenhcd_timer_action(info, TIMER_RING_WATCHDOG);
+			return;
+		}
+
+		urbp = list_entry(info->pending_submit_list.next,
+				  struct urb_priv, list);
+		if (!xenhcd_do_request(info, urbp))
+			list_move_tail(&urbp->list, &info->in_progress_list);
+		else
+			xenhcd_giveback_urb(info, urbp->urb, -ESHUTDOWN);
+	}
+	xenhcd_timer_action_done(info, TIMER_SCAN_PENDING_URBS);
+}
+
+/*
+ * caller must lock info->lock
+ */
+static void xenhcd_cancel_all_enqueued_urbs(struct xenhcd_info *info)
+{
+	struct urb_priv *urbp, *tmp;
+	int req_id;
+
+	list_for_each_entry_safe(urbp, tmp, &info->in_progress_list, list) {
+		req_id = urbp->req_id;
+		if (!urbp->unlinked) {
+			xenhcd_gnttab_done(&info->shadow[req_id]);
+			if (urbp->urb->status == -EINPROGRESS)
+				/* not dequeued */
+				xenhcd_giveback_urb(info, urbp->urb,
+						    -ESHUTDOWN);
+			else	/* dequeued */
+				xenhcd_giveback_urb(info, urbp->urb,
+						    urbp->urb->status);
+		}
+		info->shadow[req_id].urb = NULL;
+	}
+
+	list_for_each_entry_safe(urbp, tmp, &info->pending_submit_list, list)
+		xenhcd_giveback_urb(info, urbp->urb, -ESHUTDOWN);
+}
+
+/*
+ * caller must lock info->lock
+ */
+static void xenhcd_giveback_unlinked_urbs(struct xenhcd_info *info)
+{
+	struct urb_priv *urbp, *tmp;
+
+	list_for_each_entry_safe(urbp, tmp, &info->giveback_waiting_list, list)
+		xenhcd_giveback_urb(info, urbp->urb, urbp->urb->status);
+}
+
+static int xenhcd_submit_urb(struct xenhcd_info *info, struct urb_priv *urbp)
+{
+	int ret;
+
+	if (RING_FULL(&info->urb_ring)) {
+		list_add_tail(&urbp->list, &info->pending_submit_list);
+		xenhcd_timer_action(info, TIMER_RING_WATCHDOG);
+		return 0;
+	}
+
+	if (!list_empty(&info->pending_submit_list)) {
+		list_add_tail(&urbp->list, &info->pending_submit_list);
+		xenhcd_timer_action(info, TIMER_SCAN_PENDING_URBS);
+		return 0;
+	}
+
+	ret = xenhcd_do_request(info, urbp);
+	if (ret == 0)
+		list_add_tail(&urbp->list, &info->in_progress_list);
+
+	return ret;
+}
+
+static int xenhcd_unlink_urb(struct xenhcd_info *info, struct urb_priv *urbp)
+{
+	int ret;
+
+	/* already unlinked? */
+	if (urbp->unlinked)
+		return -EBUSY;
+
+	urbp->unlinked = true;
+
+	/* the urb is still in pending_submit queue */
+	if (urbp->req_id == ~0) {
+		list_move_tail(&urbp->list, &info->giveback_waiting_list);
+		xenhcd_timer_action(info, TIMER_SCAN_PENDING_URBS);
+		return 0;
+	}
+
+	/* send unlink request to backend */
+	if (RING_FULL(&info->urb_ring)) {
+		list_move_tail(&urbp->list, &info->pending_unlink_list);
+		xenhcd_timer_action(info, TIMER_RING_WATCHDOG);
+		return 0;
+	}
+
+	if (!list_empty(&info->pending_unlink_list)) {
+		list_move_tail(&urbp->list, &info->pending_unlink_list);
+		xenhcd_timer_action(info, TIMER_SCAN_PENDING_URBS);
+		return 0;
+	}
+
+	ret = xenhcd_do_request(info, urbp);
+	if (ret == 0)
+		list_move_tail(&urbp->list, &info->in_progress_list);
+
+	return ret;
+}
+
+static int xenhcd_urb_request_done(struct xenhcd_info *info)
+{
+	struct xenusb_urb_response res;
+	struct urb *urb;
+	RING_IDX i, rp;
+	__u16 id;
+	int more_to_do = 0;
+	unsigned long flags;
+
+	spin_lock_irqsave(&info->lock, flags);
+
+	rp = info->urb_ring.sring->rsp_prod;
+	if (RING_RESPONSE_PROD_OVERFLOW(&info->urb_ring, rp)) {
+		xenhcd_set_error(info, "Illegal index on urb-ring");
+		return 0;
+	}
+	rmb(); /* ensure we see queued responses up to "rp" */
+
+	for (i = info->urb_ring.rsp_cons; i != rp; i++) {
+		RING_COPY_RESPONSE(&info->urb_ring, i, &res);
+		id = res.id;
+		if (id >= XENUSB_URB_RING_SIZE) {
+			xenhcd_set_error(info, "Illegal data on urb-ring");
+			continue;
+		}
+
+		if (likely(xenusb_pipesubmit(info->shadow[id].req.pipe))) {
+			xenhcd_gnttab_done(&info->shadow[id]);
+			urb = info->shadow[id].urb;
+			if (likely(urb)) {
+				urb->actual_length = res.actual_length;
+				urb->error_count = res.error_count;
+				urb->start_frame = res.start_frame;
+				xenhcd_giveback_urb(info, urb, res.status);
+			}
+		}
+
+		xenhcd_add_id_to_freelist(info, id);
+	}
+	info->urb_ring.rsp_cons = i;
+
+	if (i != info->urb_ring.req_prod_pvt)
+		RING_FINAL_CHECK_FOR_RESPONSES(&info->urb_ring, more_to_do);
+	else
+		info->urb_ring.sring->rsp_event = i + 1;
+
+	spin_unlock_irqrestore(&info->lock, flags);
+
+	return more_to_do;
+}
+
+static int xenhcd_conn_notify(struct xenhcd_info *info)
+{
+	struct xenusb_conn_response res;
+	struct xenusb_conn_request *req;
+	RING_IDX rc, rp;
+	__u16 id;
+	__u8 portnum, speed;
+	int more_to_do = 0;
+	int notify;
+	int port_changed = 0;
+	unsigned long flags;
+
+	spin_lock_irqsave(&info->lock, flags);
+
+	rc = info->conn_ring.rsp_cons;
+	rp = info->conn_ring.sring->rsp_prod;
+	if (RING_RESPONSE_PROD_OVERFLOW(&info->conn_ring, rp)) {
+		xenhcd_set_error(info, "Illegal index on conn-ring");
+		return 0;
+	}
+	rmb(); /* ensure we see queued responses up to "rp" */
+
+	while (rc != rp) {
+		RING_COPY_RESPONSE(&info->conn_ring, rc, &res);
+		id = res.id;
+		portnum = res.portnum;
+		speed = res.speed;
+		info->conn_ring.rsp_cons = ++rc;
+
+		if (xenhcd_rhport_connect(info, portnum, speed)) {
+			xenhcd_set_error(info, "Illegal data on conn-ring");
+			return 0;
+		}
+
+		if (info->ports[portnum - 1].c_connection)
+			port_changed = 1;
+
+		barrier();
+
+		req = RING_GET_REQUEST(&info->conn_ring,
+				       info->conn_ring.req_prod_pvt);
+		req->id = id;
+		info->conn_ring.req_prod_pvt++;
+	}
+
+	if (rc != info->conn_ring.req_prod_pvt)
+		RING_FINAL_CHECK_FOR_RESPONSES(&info->conn_ring, more_to_do);
+	else
+		info->conn_ring.sring->rsp_event = rc + 1;
+
+	RING_PUSH_REQUESTS_AND_CHECK_NOTIFY(&info->conn_ring, notify);
+	if (notify)
+		notify_remote_via_irq(info->irq);
+
+	spin_unlock_irqrestore(&info->lock, flags);
+
+	if (port_changed)
+		usb_hcd_poll_rh_status(xenhcd_info_to_hcd(info));
+
+	return more_to_do;
+}
+
+static irqreturn_t xenhcd_int(int irq, void *dev_id)
+{
+	struct xenhcd_info *info = (struct xenhcd_info *)dev_id;
+
+	if (unlikely(info->error))
+		return IRQ_HANDLED;
+
+	while (xenhcd_urb_request_done(info) | xenhcd_conn_notify(info))
+		/* Yield point for this unbounded loop. */
+		cond_resched();
+
+	return IRQ_HANDLED;
+}
+
+static void xenhcd_destroy_rings(struct xenhcd_info *info)
+{
+	if (info->irq)
+		unbind_from_irqhandler(info->irq, info);
+	info->irq = 0;
+
+	if (info->urb_ring_ref != GRANT_INVALID_REF) {
+		gnttab_end_foreign_access(info->urb_ring_ref, 0,
+					  (unsigned long)info->urb_ring.sring);
+		info->urb_ring_ref = GRANT_INVALID_REF;
+	}
+	info->urb_ring.sring = NULL;
+
+	if (info->conn_ring_ref != GRANT_INVALID_REF) {
+		gnttab_end_foreign_access(info->conn_ring_ref, 0,
+					  (unsigned long)info->conn_ring.sring);
+		info->conn_ring_ref = GRANT_INVALID_REF;
+	}
+	info->conn_ring.sring = NULL;
+}
+
+static int xenhcd_setup_rings(struct xenbus_device *dev,
+			      struct xenhcd_info *info)
+{
+	struct xenusb_urb_sring *urb_sring;
+	struct xenusb_conn_sring *conn_sring;
+	grant_ref_t gref;
+	int err;
+
+	info->urb_ring_ref = GRANT_INVALID_REF;
+	info->conn_ring_ref = GRANT_INVALID_REF;
+
+	urb_sring = (struct xenusb_urb_sring *)get_zeroed_page(
+							GFP_NOIO | __GFP_HIGH);
+	if (!urb_sring) {
+		xenbus_dev_fatal(dev, -ENOMEM, "allocating urb ring");
+		return -ENOMEM;
+	}
+	SHARED_RING_INIT(urb_sring);
+	FRONT_RING_INIT(&info->urb_ring, urb_sring, PAGE_SIZE);
+
+	err = xenbus_grant_ring(dev, urb_sring, 1, &gref);
+	if (err < 0) {
+		free_page((unsigned long)urb_sring);
+		info->urb_ring.sring = NULL;
+		goto fail;
+	}
+	info->urb_ring_ref = gref;
+
+	conn_sring = (struct xenusb_conn_sring *)get_zeroed_page(
+							GFP_NOIO | __GFP_HIGH);
+	if (!conn_sring) {
+		xenbus_dev_fatal(dev, -ENOMEM, "allocating conn ring");
+		err = -ENOMEM;
+		goto fail;
+	}
+	SHARED_RING_INIT(conn_sring);
+	FRONT_RING_INIT(&info->conn_ring, conn_sring, PAGE_SIZE);
+
+	err = xenbus_grant_ring(dev, conn_sring, 1, &gref);
+	if (err < 0) {
+		free_page((unsigned long)conn_sring);
+		info->conn_ring.sring = NULL;
+		goto fail;
+	}
+	info->conn_ring_ref = gref;
+
+	err = xenbus_alloc_evtchn(dev, &info->evtchn);
+	if (err) {
+		xenbus_dev_fatal(dev, err, "xenbus_alloc_evtchn");
+		goto fail;
+	}
+
+	err = bind_evtchn_to_irq(info->evtchn);
+	if (err <= 0) {
+		xenbus_dev_fatal(dev, err, "bind_evtchn_to_irq");
+		goto fail;
+	}
+
+	info->irq = err;
+
+	err = request_threaded_irq(info->irq, NULL, xenhcd_int,
+				   IRQF_ONESHOT, "xenhcd", info);
+	if (err) {
+		xenbus_dev_fatal(dev, err, "request_threaded_irq");
+		goto free_irq;
+	}
+
+	return 0;
+
+free_irq:
+	unbind_from_irqhandler(info->irq, info);
+fail:
+	xenhcd_destroy_rings(info);
+	return err;
+}
+
+static int xenhcd_talk_to_backend(struct xenbus_device *dev,
+				  struct xenhcd_info *info)
+{
+	const char *message;
+	struct xenbus_transaction xbt;
+	int err;
+
+	err = xenhcd_setup_rings(dev, info);
+	if (err)
+		return err;
+
+again:
+	err = xenbus_transaction_start(&xbt);
+	if (err) {
+		xenbus_dev_fatal(dev, err, "starting transaction");
+		goto destroy_ring;
+	}
+
+	err = xenbus_printf(xbt, dev->nodename, "urb-ring-ref", "%u",
+			    info->urb_ring_ref);
+	if (err) {
+		message = "writing urb-ring-ref";
+		goto abort_transaction;
+	}
+
+	err = xenbus_printf(xbt, dev->nodename, "conn-ring-ref", "%u",
+			    info->conn_ring_ref);
+	if (err) {
+		message = "writing conn-ring-ref";
+		goto abort_transaction;
+	}
+
+	err = xenbus_printf(xbt, dev->nodename, "event-channel", "%u",
+			    info->evtchn);
+	if (err) {
+		message = "writing event-channel";
+		goto abort_transaction;
+	}
+
+	err = xenbus_transaction_end(xbt, 0);
+	if (err) {
+		if (err == -EAGAIN)
+			goto again;
+		xenbus_dev_fatal(dev, err, "completing transaction");
+		goto destroy_ring;
+	}
+
+	return 0;
+
+abort_transaction:
+	xenbus_transaction_end(xbt, 1);
+	xenbus_dev_fatal(dev, err, "%s", message);
+
+destroy_ring:
+	xenhcd_destroy_rings(info);
+
+	return err;
+}
+
+static int xenhcd_connect(struct xenbus_device *dev)
+{
+	struct xenhcd_info *info = dev_get_drvdata(&dev->dev);
+	struct xenusb_conn_request *req;
+	int idx, err;
+	int notify;
+	char name[TASK_COMM_LEN];
+	struct usb_hcd *hcd;
+
+	hcd = xenhcd_info_to_hcd(info);
+	snprintf(name, TASK_COMM_LEN, "xenhcd.%d", hcd->self.busnum);
+
+	err = xenhcd_talk_to_backend(dev, info);
+	if (err)
+		return err;
+
+	/* prepare ring for hotplug notification */
+	for (idx = 0; idx < XENUSB_CONN_RING_SIZE; idx++) {
+		req = RING_GET_REQUEST(&info->conn_ring, idx);
+		req->id = idx;
+	}
+	info->conn_ring.req_prod_pvt = idx;
+
+	RING_PUSH_REQUESTS_AND_CHECK_NOTIFY(&info->conn_ring, notify);
+	if (notify)
+		notify_remote_via_irq(info->irq);
+
+	return 0;
+}
+
+static void xenhcd_disconnect(struct xenbus_device *dev)
+{
+	struct xenhcd_info *info = dev_get_drvdata(&dev->dev);
+	struct usb_hcd *hcd = xenhcd_info_to_hcd(info);
+
+	usb_remove_hcd(hcd);
+	xenbus_frontend_closed(dev);
+}
+
+static void xenhcd_watchdog(struct timer_list *timer)
+{
+	struct xenhcd_info *info = from_timer(info, timer, watchdog);
+	unsigned long flags;
+
+	spin_lock_irqsave(&info->lock, flags);
+	if (likely(HC_IS_RUNNING(xenhcd_info_to_hcd(info)->state))) {
+		xenhcd_timer_action_done(info, TIMER_RING_WATCHDOG);
+		xenhcd_giveback_unlinked_urbs(info);
+		xenhcd_kick_pending_urbs(info);
+	}
+	spin_unlock_irqrestore(&info->lock, flags);
+}
+
+/*
+ * one-time HC init
+ */
+static int xenhcd_setup(struct usb_hcd *hcd)
+{
+	struct xenhcd_info *info = xenhcd_hcd_to_info(hcd);
+
+	spin_lock_init(&info->lock);
+	INIT_LIST_HEAD(&info->pending_submit_list);
+	INIT_LIST_HEAD(&info->pending_unlink_list);
+	INIT_LIST_HEAD(&info->in_progress_list);
+	INIT_LIST_HEAD(&info->giveback_waiting_list);
+	timer_setup(&info->watchdog, xenhcd_watchdog, 0);
+
+	hcd->has_tt = (hcd->driver->flags & HCD_MASK) != HCD_USB11;
+
+	return 0;
+}
+
+/*
+ * start HC running
+ */
+static int xenhcd_run(struct usb_hcd *hcd)
+{
+	hcd->uses_new_polling = 1;
+	clear_bit(HCD_FLAG_POLL_RH, &hcd->flags);
+	hcd->state = HC_STATE_RUNNING;
+	return 0;
+}
+
+/*
+ * stop running HC
+ */
+static void xenhcd_stop(struct usb_hcd *hcd)
+{
+	struct xenhcd_info *info = xenhcd_hcd_to_info(hcd);
+
+	del_timer_sync(&info->watchdog);
+	spin_lock_irq(&info->lock);
+	/* cancel all urbs */
+	hcd->state = HC_STATE_HALT;
+	xenhcd_cancel_all_enqueued_urbs(info);
+	xenhcd_giveback_unlinked_urbs(info);
+	spin_unlock_irq(&info->lock);
+}
+
+/*
+ * called as .urb_enqueue()
+ * non-error returns are promise to giveback the urb later
+ */
+static int xenhcd_urb_enqueue(struct usb_hcd *hcd, struct urb *urb,
+			      gfp_t mem_flags)
+{
+	struct xenhcd_info *info = xenhcd_hcd_to_info(hcd);
+	struct urb_priv *urbp;
+	unsigned long flags;
+	int ret;
+
+	if (unlikely(info->error))
+		return -ESHUTDOWN;
+
+	urbp = kmem_cache_zalloc(xenhcd_urbp_cachep, mem_flags);
+	if (!urbp)
+		return -ENOMEM;
+
+	spin_lock_irqsave(&info->lock, flags);
+
+	urbp->urb = urb;
+	urb->hcpriv = urbp;
+	urbp->req_id = ~0;
+	urbp->unlink_req_id = ~0;
+	INIT_LIST_HEAD(&urbp->list);
+	urbp->status = 1;
+	urb->unlinked = false;
+
+	ret = xenhcd_submit_urb(info, urbp);
+
+	if (ret)
+		xenhcd_free_urb_priv(urbp);
+
+	spin_unlock_irqrestore(&info->lock, flags);
+
+	return ret;
+}
+
+/*
+ * called as .urb_dequeue()
+ */
+static int xenhcd_urb_dequeue(struct usb_hcd *hcd, struct urb *urb, int status)
+{
+	struct xenhcd_info *info = xenhcd_hcd_to_info(hcd);
+	struct urb_priv *urbp;
+	unsigned long flags;
+	int ret = 0;
+
+	spin_lock_irqsave(&info->lock, flags);
+
+	urbp = urb->hcpriv;
+	if (urbp) {
+		urbp->status = status;
+		ret = xenhcd_unlink_urb(info, urbp);
+	}
+
+	spin_unlock_irqrestore(&info->lock, flags);
+
+	return ret;
+}
+
+/*
+ * called from usb_get_current_frame_number(),
+ * but, almost all drivers not use such function.
+ */
+static int xenhcd_get_frame(struct usb_hcd *hcd)
+{
+	/* it means error, but probably no problem :-) */
+	return 0;
+}
+
+static struct hc_driver xenhcd_usb20_hc_driver = {
+	.description = "xen-hcd",
+	.product_desc = "Xen USB2.0 Virtual Host Controller",
+	.hcd_priv_size = sizeof(struct xenhcd_info),
+	.flags = HCD_USB2,
+
+	/* basic HC lifecycle operations */
+	.reset = xenhcd_setup,
+	.start = xenhcd_run,
+	.stop = xenhcd_stop,
+
+	/* managing urb I/O */
+	.urb_enqueue = xenhcd_urb_enqueue,
+	.urb_dequeue = xenhcd_urb_dequeue,
+	.get_frame_number = xenhcd_get_frame,
+
+	/* root hub operations */
+	.hub_status_data = xenhcd_hub_status_data,
+	.hub_control = xenhcd_hub_control,
+#ifdef CONFIG_PM
+	.bus_suspend = xenhcd_bus_suspend,
+	.bus_resume = xenhcd_bus_resume,
+#endif
+};
+
+static struct hc_driver xenhcd_usb11_hc_driver = {
+	.description = "xen-hcd",
+	.product_desc = "Xen USB1.1 Virtual Host Controller",
+	.hcd_priv_size = sizeof(struct xenhcd_info),
+	.flags = HCD_USB11,
+
+	/* basic HC lifecycle operations */
+	.reset = xenhcd_setup,
+	.start = xenhcd_run,
+	.stop = xenhcd_stop,
+
+	/* managing urb I/O */
+	.urb_enqueue = xenhcd_urb_enqueue,
+	.urb_dequeue = xenhcd_urb_dequeue,
+	.get_frame_number = xenhcd_get_frame,
+
+	/* root hub operations */
+	.hub_status_data = xenhcd_hub_status_data,
+	.hub_control = xenhcd_hub_control,
+#ifdef CONFIG_PM
+	.bus_suspend = xenhcd_bus_suspend,
+	.bus_resume = xenhcd_bus_resume,
+#endif
+};
+
+static struct usb_hcd *xenhcd_create_hcd(struct xenbus_device *dev)
+{
+	int i;
+	int err = 0;
+	int num_ports;
+	int usb_ver;
+	struct usb_hcd *hcd = NULL;
+	struct xenhcd_info *info;
+
+	err = xenbus_scanf(XBT_NIL, dev->otherend, "num-ports", "%d",
+			   &num_ports);
+	if (err != 1) {
+		xenbus_dev_fatal(dev, err, "reading num-ports");
+		return ERR_PTR(-EINVAL);
+	}
+	if (num_ports < 1 || num_ports > XENUSB_MAX_PORTNR) {
+		xenbus_dev_fatal(dev, err, "invalid num-ports");
+		return ERR_PTR(-EINVAL);
+	}
+
+	err = xenbus_scanf(XBT_NIL, dev->otherend, "usb-ver", "%d", &usb_ver);
+	if (err != 1) {
+		xenbus_dev_fatal(dev, err, "reading usb-ver");
+		return ERR_PTR(-EINVAL);
+	}
+	switch (usb_ver) {
+	case XENUSB_VER_USB11:
+		hcd = usb_create_hcd(&xenhcd_usb11_hc_driver, &dev->dev,
+				     dev_name(&dev->dev));
+		break;
+	case XENUSB_VER_USB20:
+		hcd = usb_create_hcd(&xenhcd_usb20_hc_driver, &dev->dev,
+				     dev_name(&dev->dev));
+		break;
+	default:
+		xenbus_dev_fatal(dev, err, "invalid usb-ver");
+		return ERR_PTR(-EINVAL);
+	}
+	if (!hcd) {
+		xenbus_dev_fatal(dev, err,
+				 "fail to allocate USB host controller");
+		return ERR_PTR(-ENOMEM);
+	}
+
+	info = xenhcd_hcd_to_info(hcd);
+	info->xbdev = dev;
+	info->rh_numports = num_ports;
+
+	for (i = 0; i < XENUSB_URB_RING_SIZE; i++) {
+		info->shadow[i].req.id = i + 1;
+		info->shadow[i].urb = NULL;
+	}
+	info->shadow[XENUSB_URB_RING_SIZE - 1].req.id = 0x0fff;
+
+	return hcd;
+}
+
+static void xenhcd_backend_changed(struct xenbus_device *dev,
+				   enum xenbus_state backend_state)
+{
+	switch (backend_state) {
+	case XenbusStateInitialising:
+	case XenbusStateReconfiguring:
+	case XenbusStateReconfigured:
+	case XenbusStateUnknown:
+		break;
+
+	case XenbusStateInitWait:
+	case XenbusStateInitialised:
+	case XenbusStateConnected:
+		if (dev->state != XenbusStateInitialising)
+			break;
+		if (!xenhcd_connect(dev))
+			xenbus_switch_state(dev, XenbusStateConnected);
+		break;
+
+	case XenbusStateClosed:
+		if (dev->state == XenbusStateClosed)
+			break;
+		fallthrough;	/* Missed the backend's Closing state. */
+	case XenbusStateClosing:
+		xenhcd_disconnect(dev);
+		break;
+
+	default:
+		xenbus_dev_fatal(dev, -EINVAL, "saw state %d at frontend",
+				 backend_state);
+		break;
+	}
+}
+
+static int xenhcd_remove(struct xenbus_device *dev)
+{
+	struct xenhcd_info *info = dev_get_drvdata(&dev->dev);
+	struct usb_hcd *hcd = xenhcd_info_to_hcd(info);
+
+	xenhcd_destroy_rings(info);
+	usb_put_hcd(hcd);
+
+	return 0;
+}
+
+static int xenhcd_probe(struct xenbus_device *dev,
+			const struct xenbus_device_id *id)
+{
+	int err;
+	struct usb_hcd *hcd;
+	struct xenhcd_info *info;
+
+	if (usb_disabled())
+		return -ENODEV;
+
+	hcd = xenhcd_create_hcd(dev);
+	if (IS_ERR(hcd)) {
+		err = PTR_ERR(hcd);
+		xenbus_dev_fatal(dev, err,
+				 "fail to create usb host controller");
+		return err;
+	}
+
+	info = xenhcd_hcd_to_info(hcd);
+	dev_set_drvdata(&dev->dev, info);
+
+	err = usb_add_hcd(hcd, 0, 0);
+	if (err) {
+		xenbus_dev_fatal(dev, err, "fail to add USB host controller");
+		usb_put_hcd(hcd);
+		dev_set_drvdata(&dev->dev, NULL);
+	}
+
+	return err;
+}
+
+static const struct xenbus_device_id xenhcd_ids[] = {
+	{ "vusb" },
+	{ "" },
+};
+
+static struct xenbus_driver xenhcd_driver = {
+	.ids			= xenhcd_ids,
+	.probe			= xenhcd_probe,
+	.otherend_changed	= xenhcd_backend_changed,
+	.remove			= xenhcd_remove,
+};
+
+static int __init xenhcd_init(void)
+{
+	if (!xen_domain())
+		return -ENODEV;
+
+	xenhcd_urbp_cachep = kmem_cache_create("xenhcd_urb_priv",
+					sizeof(struct urb_priv), 0, 0, NULL);
+	if (!xenhcd_urbp_cachep) {
+		pr_err("xenhcd failed to create kmem cache\n");
+		return -ENOMEM;
+	}
+
+	return xenbus_register_frontend(&xenhcd_driver);
+}
+module_init(xenhcd_init);
+
+static void __exit xenhcd_exit(void)
+{
+	kmem_cache_destroy(xenhcd_urbp_cachep);
+	xenbus_unregister_driver(&xenhcd_driver);
+}
+module_exit(xenhcd_exit);
+
+MODULE_ALIAS("xen:vusb");
+MODULE_AUTHOR("Juergen Gross <jgross@suse.com>");
+MODULE_DESCRIPTION("Xen USB Virtual Host Controller driver (xen-hcd)");
+MODULE_LICENSE("Dual BSD/GPL");
-- 
2.26.2



From xen-devel-bounces@lists.xenproject.org Fri Oct 01 15:00:55 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Oct 2021 15:00:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.200704.355265 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mWK1u-00073o-6W; Fri, 01 Oct 2021 15:00:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 200704.355265; Fri, 01 Oct 2021 15:00:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mWK1u-00073d-1e; Fri, 01 Oct 2021 15:00:54 +0000
Received: by outflank-mailman (input) for mailman id 200704;
 Fri, 01 Oct 2021 15:00:53 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=kuDH=OV=suse.com=jgross@srs-us1.protection.inumbo.net>)
 id 1mWK1t-0006Wg-Hy
 for xen-devel@lists.xenproject.org; Fri, 01 Oct 2021 15:00:53 +0000
Received: from smtp-out2.suse.de (unknown [195.135.220.29])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id dc9f6f49-7456-411c-8772-91da1ec71824;
 Fri, 01 Oct 2021 15:00:47 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 3582A1FEE4;
 Fri,  1 Oct 2021 15:00:46 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 00D7C13C71;
 Fri,  1 Oct 2021 15:00:45 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id cACHOp0iV2G5OgAAMHmgww
 (envelope-from <jgross@suse.com>); Fri, 01 Oct 2021 15:00:45 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: dc9f6f49-7456-411c-8772-91da1ec71824
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1633100446; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=dcomfE/I4gWeFT5yjEawNoXU0FH7/AhouMgmX29rWv4=;
	b=fGKxmTC33s/db7GJSj0C8FYPJzsLNGizh38n2VIqbf4opC4ZKq5h7J8EUJ2sbfBkNW6+M3
	N0lbDne0HELxsteADvCticK9b8xED09/cbUF6HsfwBvmINyNKsB3OtyvgzpRkCLeDSVsoa
	3phyJ8Fzv//jbvp+52l70AV2AoYxQE4=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org,
	linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org
Cc: Juergen Gross <jgross@suse.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>
Subject: [PATCH v5 1/3] usb: Add Xen pvUSB protocol description
Date: Fri,  1 Oct 2021 17:00:37 +0200
Message-Id: <20211001150039.15921-2-jgross@suse.com>
X-Mailer: git-send-email 2.26.2
In-Reply-To: <20211001150039.15921-1-jgross@suse.com>
References: <20211001150039.15921-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Add the definition of pvUSB protocol used between the pvUSB frontend in
a Xen domU and the pvUSB backend in a Xen driver domain (usually Dom0).

This header was originally provided by Fujitsu for Xen based on Linux
2.6.18.

Changes are:
- adapt to Linux kernel style guide
- use Xen namespace
- add lots of comments
- don't use kernel internal defines

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 include/xen/interface/io/usbif.h | 421 +++++++++++++++++++++++++++++++
 1 file changed, 421 insertions(+)
 create mode 100644 include/xen/interface/io/usbif.h

diff --git a/include/xen/interface/io/usbif.h b/include/xen/interface/io/usbif.h
new file mode 100644
index 000000000000..9494b1c9be99
--- /dev/null
+++ b/include/xen/interface/io/usbif.h
@@ -0,0 +1,421 @@
+/*
+ * usbif.h
+ *
+ * USB I/O interface for Xen guest OSes.
+ *
+ * Copyright (C) 2009, FUJITSU LABORATORIES LTD.
+ * Author: Noboru Iwamatsu <n_iwamatsu@jp.fujitsu.com>
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a copy
+ * of this software and associated documentation files (the "Software"), to
+ * deal in the Software without restriction, including without limitation the
+ * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or
+ * sell copies of the Software, and to permit persons to whom the Software is
+ * furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice shall be included in
+ * all copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+ * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
+ * DEALINGS IN THE SOFTWARE.
+ */
+
+#ifndef __XEN_PUBLIC_IO_USBIF_H__
+#define __XEN_PUBLIC_IO_USBIF_H__
+
+#include "ring.h"
+#include "../grant_table.h"
+
+/*
+ * Detailed Interface Description
+ * ==============================
+ * The pvUSB interface is using a split driver design: a frontend driver in
+ * the guest and a backend driver in a driver domain (normally dom0) having
+ * access to the physical USB device(s) being passed to the guest.
+ *
+ * The frontend and backend drivers use XenStore to initiate the connection
+ * between them, the I/O activity is handled via two shared ring pages and an
+ * event channel. As the interface between frontend and backend is at the USB
+ * host connector level, multiple (up to 31) physical USB devices can be
+ * handled by a single connection.
+ *
+ * The Xen pvUSB device name is "qusb", so the frontend's XenStore entries are
+ * to be found under "device/qusb", while the backend's XenStore entries are
+ * under "backend/<guest-dom-id>/qusb".
+ *
+ * When a new pvUSB connection is established, the frontend needs to setup the
+ * two shared ring pages for communication and the event channel. The ring
+ * pages need to be made available to the backend via the grant table
+ * interface.
+ *
+ * One of the shared ring pages is used by the backend to inform the frontend
+ * about USB device plug events (device to be added or removed). This is the
+ * "conn-ring".
+ *
+ * The other ring page is used for USB I/O communication (requests and
+ * responses). This is the "urb-ring".
+ *
+ * Feature and Parameter Negotiation
+ * =================================
+ * The two halves of a Xen pvUSB driver utilize nodes within the XenStore to
+ * communicate capabilities and to negotiate operating parameters. This
+ * section enumerates these nodes which reside in the respective front and
+ * backend portions of the XenStore, following the XenBus convention.
+ *
+ * Any specified default value is in effect if the corresponding XenBus node
+ * is not present in the XenStore.
+ *
+ * XenStore nodes in sections marked "PRIVATE" are solely for use by the
+ * driver side whose XenBus tree contains them.
+ *
+ *****************************************************************************
+ *                            Backend XenBus Nodes
+ *****************************************************************************
+ *
+ *------------------ Backend Device Identification (PRIVATE) ------------------
+ *
+ * num-ports
+ *      Values:         unsigned [1...31]
+ *
+ *      Number of ports for this (virtual) USB host connector.
+ *
+ * usb-ver
+ *      Values:         unsigned [1...2]
+ *
+ *      USB version of this host connector: 1 = USB 1.1, 2 = USB 2.0.
+ *
+ * port/[1...31]
+ *      Values:         string
+ *
+ *      Physical USB device connected to the given port, e.g. "3-1.5".
+ *
+ *****************************************************************************
+ *                            Frontend XenBus Nodes
+ *****************************************************************************
+ *
+ *----------------------- Request Transport Parameters -----------------------
+ *
+ * event-channel
+ *      Values:         unsigned
+ *
+ *      The identifier of the Xen event channel used to signal activity
+ *      in the ring buffer.
+ *
+ * urb-ring-ref
+ *      Values:         unsigned
+ *
+ *      The Xen grant reference granting permission for the backend to map
+ *      the sole page in a single page sized ring buffer. This is the ring
+ *      buffer for urb requests.
+ *
+ * conn-ring-ref
+ *      Values:         unsigned
+ *
+ *      The Xen grant reference granting permission for the backend to map
+ *      the sole page in a single page sized ring buffer. This is the ring
+ *      buffer for connection/disconnection requests.
+ *
+ * protocol
+ *      Values:         string (XEN_IO_PROTO_ABI_*)
+ *      Default Value:  XEN_IO_PROTO_ABI_NATIVE
+ *
+ *      The machine ABI rules governing the format of all ring request and
+ *      response structures.
+ *
+ * Protocol Description
+ * ====================
+ *
+ *-------------------------- USB device plug events --------------------------
+ *
+ * USB device plug events are send via the "conn-ring" shared page. As only
+ * events are being sent, the respective requests from the frontend to the
+ * backend are just dummy ones.
+ * The events sent to the frontend have the following layout:
+ *         0                1                 2               3        octet
+ * +----------------+----------------+----------------+----------------+
+ * |               id                |    portnum     |     speed      | 4
+ * +----------------+----------------+----------------+----------------+
+ *   id - uint16_t, event id (taken from the actual frontend dummy request)
+ *   portnum - uint8_t, port number (1 ... 31)
+ *   speed - uint8_t, device XENUSB_SPEED_*, XENUSB_SPEED_NONE == unplug
+ *
+ * The dummy request:
+ *         0                1        octet
+ * +----------------+----------------+
+ * |               id                | 2
+ * +----------------+----------------+
+ *   id - uint16_t, guest supplied value (no need for being unique)
+ *
+ *-------------------------- USB I/O request ---------------------------------
+ *
+ * A single USB I/O request on the "urb-ring" has the following layout:
+ *         0                1                 2               3        octet
+ * +----------------+----------------+----------------+----------------+
+ * |               id                |         nr_buffer_segs          | 4
+ * +----------------+----------------+----------------+----------------+
+ * |                               pipe                                | 8
+ * +----------------+----------------+----------------+----------------+
+ * |         transfer_flags          |          buffer_length          | 12
+ * +----------------+----------------+----------------+----------------+
+ * |                       request type specific                       | 16
+ * |                               data                                | 20
+ * +----------------+----------------+----------------+----------------+
+ * |                              seg[0]                               | 24
+ * |                               data                                | 28
+ * +----------------+----------------+----------------+----------------+
+ * |/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/|
+ * +----------------+----------------+----------------+----------------+
+ * |             seg[XENUSB_MAX_SEGMENTS_PER_REQUEST - 1]              | 144
+ * |                               data                                | 148
+ * +----------------+----------------+----------------+----------------+
+ * Bit field bit number 0 is always least significant bit, undefined bits must
+ * be zero.
+ *   id - uint16_t, guest supplied value
+ *   nr_buffer_segs - uint16_t, number of segment entries in seg[] array
+ *   pipe - uint32_t, bit field with multiple information:
+ *     bits 0-4: port request to send to
+ *     bit 5: unlink request with specified id (cancel I/O) if set (see below)
+ *     bit 7: direction (1 = read from device)
+ *     bits 8-14: device number on port
+ *     bits 15-18: endpoint of device
+ *     bits 30-31: request type: 00 = isochronous, 01 = interrupt,
+ *                               10 = control, 11 = bulk
+ *   transfer_flags - uint16_t, bit field with processing flags:
+ *     bit 0: less data than specified allowed
+ *   buffer_length - uint16_t, total length of data
+ *   request type specific data - 8 bytes, see below
+ *   seg[] - array with 8 byte elements, see below
+ *
+ * Request type specific data for isochronous request:
+ *         0                1                 2               3        octet
+ * +----------------+----------------+----------------+----------------+
+ * |            interval             |           start_frame           | 4
+ * +----------------+----------------+----------------+----------------+
+ * |       number_of_packets         |       nr_frame_desc_segs        | 8
+ * +----------------+----------------+----------------+----------------+
+ *   interval - uint16_t, time interval in msecs between frames
+ *   start_frame - uint16_t, start frame number
+ *   number_of_packets - uint16_t, number of packets to transfer
+ *   nr_frame_desc_segs - uint16_t number of seg[] frame descriptors elements
+ *
+ * Request type specific data for interrupt request:
+ *         0                1                 2               3        octet
+ * +----------------+----------------+----------------+----------------+
+ * |            interval             |                0                | 4
+ * +----------------+----------------+----------------+----------------+
+ * |                                 0                                 | 8
+ * +----------------+----------------+----------------+----------------+
+ *   interval - uint16_t, time in msecs until interruption
+ *
+ * Request type specific data for control request:
+ *         0                1                 2               3        octet
+ * +----------------+----------------+----------------+----------------+
+ * |                      data of setup packet                         | 4
+ * |                                                                   | 8
+ * +----------------+----------------+----------------+----------------+
+ *
+ * Request type specific data for bulk request:
+ *         0                1                 2               3        octet
+ * +----------------+----------------+----------------+----------------+
+ * |                                 0                                 | 4
+ * |                                 0                                 | 8
+ * +----------------+----------------+----------------+----------------+
+ *
+ * Request type specific data for unlink request:
+ *         0                1                 2               3        octet
+ * +----------------+----------------+----------------+----------------+
+ * |           unlink_id             |                0                | 4
+ * +----------------+----------------+----------------+----------------+
+ * |                                 0                                 | 8
+ * +----------------+----------------+----------------+----------------+
+ *   unlink_id - uint16_t, request id of request to terminate
+ *
+ * seg[] array element layout:
+ *         0                1                 2               3        octet
+ * +----------------+----------------+----------------+----------------+
+ * |                               gref                                | 4
+ * +----------------+----------------+----------------+----------------+
+ * |             offset              |             length              | 8
+ * +----------------+----------------+----------------+----------------+
+ *   gref - uint32_t, grant reference of buffer page
+ *   offset - uint16_t, offset of buffer start in page
+ *   length - uint16_t, length of buffer in page
+ *
+ *-------------------------- USB I/O response --------------------------------
+ *
+ *         0                1                 2               3        octet
+ * +----------------+----------------+----------------+----------------+
+ * |               id                |          start_frame            | 4
+ * +----------------+----------------+----------------+----------------+
+ * |                              status                               | 8
+ * +----------------+----------------+----------------+----------------+
+ * |                          actual_length                            | 12
+ * +----------------+----------------+----------------+----------------+
+ * |                           error_count                             | 16
+ * +----------------+----------------+----------------+----------------+
+ *   id - uint16_t, id of the request this response belongs to
+ *   start_frame - uint16_t, start_frame this response (iso requests only)
+ *   status - int32_t, XENUSB_STATUS_* (non-iso requests)
+ *   actual_length - uint32_t, actual size of data transferred
+ *   error_count - uint32_t, number of errors (iso requests)
+ */
+
+enum xenusb_spec_version {
+	XENUSB_VER_UNKNOWN = 0,
+	XENUSB_VER_USB11,
+	XENUSB_VER_USB20,
+	XENUSB_VER_USB30,	/* not supported yet */
+};
+
+/*
+ *  USB pipe in xenusb_request
+ *
+ *  - port number:      bits 0-4
+ *                              (USB_MAXCHILDREN is 31)
+ *
+ *  - operation flag:   bit 5
+ *                              (0 = submit urb,
+ *                               1 = unlink urb)
+ *
+ *  - direction:        bit 7
+ *                              (0 = Host-to-Device [Out]
+ *                               1 = Device-to-Host [In])
+ *
+ *  - device address:   bits 8-14
+ *
+ *  - endpoint:         bits 15-18
+ *
+ *  - pipe type:        bits 30-31
+ *                              (00 = isochronous, 01 = interrupt,
+ *                               10 = control, 11 = bulk)
+ */
+
+#define XENUSB_PIPE_PORT_MASK	0x0000001f
+#define XENUSB_PIPE_UNLINK	0x00000020
+#define XENUSB_PIPE_DIR		0x00000080
+#define XENUSB_PIPE_DEV_MASK	0x0000007f
+#define XENUSB_PIPE_DEV_SHIFT	8
+#define XENUSB_PIPE_EP_MASK	0x0000000f
+#define XENUSB_PIPE_EP_SHIFT	15
+#define XENUSB_PIPE_TYPE_MASK	0x00000003
+#define XENUSB_PIPE_TYPE_SHIFT	30
+#define XENUSB_PIPE_TYPE_ISOC	0
+#define XENUSB_PIPE_TYPE_INT	1
+#define XENUSB_PIPE_TYPE_CTRL	2
+#define XENUSB_PIPE_TYPE_BULK	3
+
+#define xenusb_pipeportnum(pipe)		((pipe) & XENUSB_PIPE_PORT_MASK)
+#define xenusb_setportnum_pipe(pipe, portnum)	((pipe) | (portnum))
+
+#define xenusb_pipeunlink(pipe)			((pipe) & XENUSB_PIPE_UNLINK)
+#define xenusb_pipesubmit(pipe)			(!xenusb_pipeunlink(pipe))
+#define xenusb_setunlink_pipe(pipe)		((pipe) | XENUSB_PIPE_UNLINK)
+
+#define xenusb_pipein(pipe)			((pipe) & XENUSB_PIPE_DIR)
+#define xenusb_pipeout(pipe)			(!xenusb_pipein(pipe))
+
+#define xenusb_pipedevice(pipe)			\
+	(((pipe) >> XENUSB_PIPE_DEV_SHIFT) & XENUSB_PIPE_DEV_MASK)
+
+#define xenusb_pipeendpoint(pipe)		\
+	(((pipe) >> XENUSB_PIPE_EP_SHIFT) & XENUSB_PIPE_EP_MASK)
+
+#define xenusb_pipetype(pipe)			\
+	(((pipe) >> XENUSB_PIPE_TYPE_SHIFT) & XENUSB_PIPE_TYPE_MASK)
+#define xenusb_pipeisoc(pipe)	(xenusb_pipetype(pipe) == XENUSB_PIPE_TYPE_ISOC)
+#define xenusb_pipeint(pipe)	(xenusb_pipetype(pipe) == XENUSB_PIPE_TYPE_INT)
+#define xenusb_pipectrl(pipe)	(xenusb_pipetype(pipe) == XENUSB_PIPE_TYPE_CTRL)
+#define xenusb_pipebulk(pipe)	(xenusb_pipetype(pipe) == XENUSB_PIPE_TYPE_BULK)
+
+#define XENUSB_MAX_SEGMENTS_PER_REQUEST (16)
+#define XENUSB_MAX_PORTNR		31
+#define XENUSB_RING_SIZE		4096
+
+/*
+ * RING for transferring urbs.
+ */
+struct xenusb_request_segment {
+	grant_ref_t gref;
+	uint16_t offset;
+	uint16_t length;
+};
+
+struct xenusb_urb_request {
+	uint16_t id;			/* request id */
+	uint16_t nr_buffer_segs;	/* number of urb->transfer_buffer segments */
+
+	/* basic urb parameter */
+	uint32_t pipe;
+	uint16_t transfer_flags;
+#define XENUSB_SHORT_NOT_OK	0x0001
+	uint16_t buffer_length;
+	union {
+		uint8_t ctrl[8];	/* setup_packet (Ctrl) */
+
+		struct {
+			uint16_t interval;	/* maximum (1024*8) in usb core */
+			uint16_t start_frame;	/* start frame */
+			uint16_t number_of_packets;	/* number of ISO packet */
+			uint16_t nr_frame_desc_segs;	/* number of iso_frame_desc segments */
+		} isoc;
+
+		struct {
+			uint16_t interval;	/* maximum (1024*8) in usb core */
+			uint16_t pad[3];
+		} intr;
+
+		struct {
+			uint16_t unlink_id;	/* unlink request id */
+			uint16_t pad[3];
+		} unlink;
+
+	} u;
+
+	/* urb data segments */
+	struct xenusb_request_segment seg[XENUSB_MAX_SEGMENTS_PER_REQUEST];
+};
+
+struct xenusb_urb_response {
+	uint16_t id;		/* request id */
+	uint16_t start_frame;	/* start frame (ISO) */
+	int32_t status;		/* status (non-ISO) */
+#define XENUSB_STATUS_OK	0
+#define XENUSB_STATUS_NODEV	(-19)
+#define XENUSB_STATUS_INVAL	(-22)
+#define XENUSB_STATUS_STALL	(-32)
+#define XENUSB_STATUS_IOERROR	(-71)
+#define XENUSB_STATUS_BABBLE	(-75)
+#define XENUSB_STATUS_SHUTDOWN	(-108)
+	int32_t actual_length;	/* actual transfer length */
+	int32_t error_count;	/* number of ISO errors */
+};
+
+DEFINE_RING_TYPES(xenusb_urb, struct xenusb_urb_request, struct xenusb_urb_response);
+#define XENUSB_URB_RING_SIZE __CONST_RING_SIZE(xenusb_urb, XENUSB_RING_SIZE)
+
+/*
+ * RING for notifying connect/disconnect events to frontend
+ */
+struct xenusb_conn_request {
+	uint16_t id;
+};
+
+struct xenusb_conn_response {
+	uint16_t id;		/* request id */
+	uint8_t portnum;	/* port number */
+	uint8_t speed;		/* usb_device_speed */
+#define XENUSB_SPEED_NONE	0
+#define XENUSB_SPEED_LOW	1
+#define XENUSB_SPEED_FULL	2
+#define XENUSB_SPEED_HIGH	3
+};
+
+DEFINE_RING_TYPES(xenusb_conn, struct xenusb_conn_request, struct xenusb_conn_response);
+#define XENUSB_CONN_RING_SIZE __CONST_RING_SIZE(xenusb_conn, XENUSB_RING_SIZE)
+
+#endif /* __XEN_PUBLIC_IO_USBIF_H__ */
-- 
2.26.2



From xen-devel-bounces@lists.xenproject.org Fri Oct 01 15:00:55 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Oct 2021 15:00:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.200702.355243 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mWK1q-0006Wu-Gv; Fri, 01 Oct 2021 15:00:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 200702.355243; Fri, 01 Oct 2021 15:00:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mWK1q-0006Wn-CI; Fri, 01 Oct 2021 15:00:50 +0000
Received: by outflank-mailman (input) for mailman id 200702;
 Fri, 01 Oct 2021 15:00:48 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=kuDH=OV=suse.com=jgross@srs-us1.protection.inumbo.net>)
 id 1mWK1o-0006Wg-MZ
 for xen-devel@lists.xenproject.org; Fri, 01 Oct 2021 15:00:48 +0000
Received: from smtp-out2.suse.de (unknown [195.135.220.29])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id e1f0ca15-7fb3-4013-aef2-accd8260ee8a;
 Fri, 01 Oct 2021 15:00:47 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id F0B441FEDA;
 Fri,  1 Oct 2021 15:00:45 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id AEA8013C6D;
 Fri,  1 Oct 2021 15:00:45 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id k+lWKJ0iV2G5OgAAMHmgww
 (envelope-from <jgross@suse.com>); Fri, 01 Oct 2021 15:00:45 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e1f0ca15-7fb3-4013-aef2-accd8260ee8a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1633100445; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:  content-transfer-encoding:content-transfer-encoding;
	bh=6xWZoy2a5K0CyrmBK/cVhYbX7E69zDWhy7ff7dORPUU=;
	b=ZMIuyG/UzkBdS4Z6/2OmD79XnIC6522CSe/v7FuBL+11XhxC+pU2Kv698BPIAMRvkWZfXJ
	lGQWS9Zac+HWBPC9/YSSWYrGfHS1zao6wfPFT3a9fad1LZ8wGJvRt6URdvy83xhCyXy29X
	8YK1VaTp5Tm3ehoBjQJWa6o9+w/tv+o=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org,
	linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org
Cc: Juergen Gross <jgross@suse.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: [PATCH v5 0/3] xen, usb: support pvUSB frontend driver
Date: Fri,  1 Oct 2021 17:00:36 +0200
Message-Id: <20211001150039.15921-1-jgross@suse.com>
X-Mailer: git-send-email 2.26.2
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

This series adds XEN guest pvUSB support. With pvUSB it is possible to
use physical USB devices from a XEN domain.

Since V4 a lot of time (several years) has passed. This is a revived
attempt to get the frontend into the kernel.

The support consists of a frontend in form of a virtual hcd driver in
the unprivileged domU passing I/O-requests to the backend in a driver
domain (usually Dom0). The backend is not part of this patch series,
as it is supported via qemu.

The code is taken (and adapted) from the original pvUSB implementation
done for Linux 2.6 in 2008 by Fujitsu.

Normal operation of USB devices by adding and removing them dynamically
to/from a domain has been tested using various USB devices (USB 1.1,
2.0 and 3.0) using the qemu based backend.

Changes in V5:
- added interface documentation to patch 1
- frontend no longer trusts backend to return only sane values

Changes in V4:
- remove sysfs file from frontend, as it violated the "one value per file"
  rule and didn't serve any real purpose.

Changes in V3:
- move frontend to drivers/usb/host and rename it to xen-hcd.
- changed name prefixes in patch 1 to "xenusb" as requested by Greg
- use __u<n> types rather than uint<n>_t as requested by Greg

Changes in V2:
- removed backend, as it can be implemented in user land
- added some access macros and definitions to the pvUSB interface
  description to make it independant from linux kernel USB internals
- adapted frontend to newer kernel version and use new pvUSB
  interface macros
- set port status in one chunk as suggested by Oliver Neukum

Juergen Gross (3):
  usb: Add Xen pvUSB protocol description
  usb: Introduce Xen pvUSB frontend (xen hcd)
  xen: add Xen pvUSB maintainer

 MAINTAINERS                      |    8 +
 drivers/usb/host/Kconfig         |   11 +
 drivers/usb/host/Makefile        |    1 +
 drivers/usb/host/xen-hcd.c       | 1641 ++++++++++++++++++++++++++++++
 include/xen/interface/io/usbif.h |  421 ++++++++
 5 files changed, 2082 insertions(+)
 create mode 100644 drivers/usb/host/xen-hcd.c
 create mode 100644 include/xen/interface/io/usbif.h

-- 
2.26.2



From xen-devel-bounces@lists.xenproject.org Fri Oct 01 15:00:59 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Oct 2021 15:00:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.200705.355276 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mWK1z-0007Pa-EO; Fri, 01 Oct 2021 15:00:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 200705.355276; Fri, 01 Oct 2021 15:00:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mWK1z-0007PR-Az; Fri, 01 Oct 2021 15:00:59 +0000
Received: by outflank-mailman (input) for mailman id 200705;
 Fri, 01 Oct 2021 15:00:58 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=kuDH=OV=suse.com=jgross@srs-us1.protection.inumbo.net>)
 id 1mWK1y-0006Wg-I5
 for xen-devel@lists.xenproject.org; Fri, 01 Oct 2021 15:00:58 +0000
Received: from smtp-out2.suse.de (unknown [195.135.220.29])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 1dc1d647-12eb-454f-985a-57c7ef8eb6bb;
 Fri, 01 Oct 2021 15:00:47 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id B77812005F;
 Fri,  1 Oct 2021 15:00:46 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 801AE13C71;
 Fri,  1 Oct 2021 15:00:46 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id YPkFHp4iV2G5OgAAMHmgww
 (envelope-from <jgross@suse.com>); Fri, 01 Oct 2021 15:00:46 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1dc1d647-12eb-454f-985a-57c7ef8eb6bb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1633100446; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=oyuxf2Y1J+lyDb6SpUAj+J2Bo2Nkah6NWr6tdJdZLO8=;
	b=jo1x8PD9yL9dIXeua2bgw/yOpomsDEtePlNPQzVzLpCyps40A189+sdJu7dRFoPGe3NNmC
	Dt+fG2kheCL1JLztcphycrL3l5Jf45I29loB95W91kXj9XgsF4i1KreM0IDENfLhK1wBCn
	SSZX1BnAhZ0g19WVnsSczVhJ3wpvvZU=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org,
	linux-kernel@vger.kernel.org
Cc: Juergen Gross <jgross@suse.com>,
	Konrad Rzeszutek Wilk <Konrad.wilk@oracle.com>
Subject: [PATCH v5 3/3] xen: add Xen pvUSB maintainer
Date: Fri,  1 Oct 2021 17:00:39 +0200
Message-Id: <20211001150039.15921-4-jgross@suse.com>
X-Mailer: git-send-email 2.26.2
In-Reply-To: <20211001150039.15921-1-jgross@suse.com>
References: <20211001150039.15921-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Add myself as maintainer for the Xen pvUSB stuff.

Signed-off-by: Juergen Gross <jgross@suse.com>
Acked-by: Konrad Rzeszutek Wilk <Konrad.wilk@oracle.com>
---
 MAINTAINERS | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index bc68a13a7655..069724ff5628 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -20529,6 +20529,14 @@ F:	drivers/scsi/xen-scsifront.c
 F:	drivers/xen/xen-scsiback.c
 F:	include/xen/interface/io/vscsiif.h
 
+XEN PVUSB DRIVER
+M:	Juergen Gross <jgross@suse.com>
+L:	xen-devel@lists.xenproject.org (moderated for non-subscribers)
+L:	linux-usb@vger.kernel.org
+S:	Supported
+F:	divers/usb/host/xen*
+F:	include/xen/interface/io/usbif.h
+
 XEN SOUND FRONTEND DRIVER
 M:	Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
 L:	xen-devel@lists.xenproject.org (moderated for non-subscribers)
-- 
2.26.2



From xen-devel-bounces@lists.xenproject.org Fri Oct 01 15:09:08 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Oct 2021 15:09:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.200733.355287 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mWK9o-0000kx-AX; Fri, 01 Oct 2021 15:09:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 200733.355287; Fri, 01 Oct 2021 15:09:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mWK9o-0000kq-6q; Fri, 01 Oct 2021 15:09:04 +0000
Received: by outflank-mailman (input) for mailman id 200733;
 Fri, 01 Oct 2021 15:09:02 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=kuDH=OV=suse.com=jgross@srs-us1.protection.inumbo.net>)
 id 1mWK9m-0000kk-Og
 for xen-devel@lists.xenproject.org; Fri, 01 Oct 2021 15:09:02 +0000
Received: from smtp-out2.suse.de (unknown [195.135.220.29])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 824b920c-22c9-11ec-bdb3-12813bfff9fa;
 Fri, 01 Oct 2021 15:09:01 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id CD32B1FEDA;
 Fri,  1 Oct 2021 15:09:00 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 780FA13C6D;
 Fri,  1 Oct 2021 15:09:00 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id c6sYHIwkV2FVPwAAMHmgww
 (envelope-from <jgross@suse.com>); Fri, 01 Oct 2021 15:09:00 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 824b920c-22c9-11ec-bdb3-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1633100940; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=uCuBT5tgF8p5Dex86InSy5Qi/RM5e8rP5mvOOKS7cT4=;
	b=TN0ergq45NhnaLE3x2d92L2Ki5wIJfTxU717e/ex8tarSC3uPJv/3r1t8iKGYKlADFou5Z
	YUqzpEzion7/P7Jy24M/fN8VsAdObIxFictoxe3gcYMkQGwxGbRlcQigNnOndBu/bVJ5/3
	yi0JyAB8R5a8ceC6pV06GLkYQNCn4pM=
To: Andrew Cooper <andrew.cooper3@citrix.com>, Jan Beulich
 <jbeulich@suse.com>, Alex Olson <this.is.a0lson@gmail.com>
Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Ian Jackson <iwj@xenproject.org>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Anthony PERARD <anthony.perard@citrix.com>,
 Alex Olson <alex.olson@starlab.io>, xen-devel@lists.xenproject.org
References: <cover.1632512149.git.this.is.a0lson@gmail.com>
 <85b59046315b8a84afa8538aacdea92b19200faa.1632512149.git.this.is.a0lson@gmail.com>
 <d899b058-a201-e2f8-35d2-f0e59ab4bab3@suse.com>
 <d63a0e7d-7f9d-0dcb-0ac9-8995e56698b4@citrix.com>
From: Juergen Gross <jgross@suse.com>
Subject: Re: [PATCH 1/1] x86: centralize default APIC id definition
Message-ID: <2ff385c7-55bd-4647-efb5-9909addca226@suse.com>
Date: Fri, 1 Oct 2021 17:08:58 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <d63a0e7d-7f9d-0dcb-0ac9-8995e56698b4@citrix.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="qFnRQ2vezRbBQsa6Pi5FUPWd9zwwnp5nX"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--qFnRQ2vezRbBQsa6Pi5FUPWd9zwwnp5nX
Content-Type: multipart/mixed; boundary="qloal8KDuf0hTndT05o5FZvYOhMa5RJ0J";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>, Jan Beulich
 <jbeulich@suse.com>, Alex Olson <this.is.a0lson@gmail.com>
Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Ian Jackson <iwj@xenproject.org>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Anthony PERARD <anthony.perard@citrix.com>,
 Alex Olson <alex.olson@starlab.io>, xen-devel@lists.xenproject.org
Message-ID: <2ff385c7-55bd-4647-efb5-9909addca226@suse.com>
Subject: Re: [PATCH 1/1] x86: centralize default APIC id definition
References: <cover.1632512149.git.this.is.a0lson@gmail.com>
 <85b59046315b8a84afa8538aacdea92b19200faa.1632512149.git.this.is.a0lson@gmail.com>
 <d899b058-a201-e2f8-35d2-f0e59ab4bab3@suse.com>
 <d63a0e7d-7f9d-0dcb-0ac9-8995e56698b4@citrix.com>
In-Reply-To: <d63a0e7d-7f9d-0dcb-0ac9-8995e56698b4@citrix.com>

--qloal8KDuf0hTndT05o5FZvYOhMa5RJ0J
Content-Type: multipart/mixed;
 boundary="------------B0C5C823692A514D8492CBCF"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------B0C5C823692A514D8492CBCF
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 01.10.21 16:29, Andrew Cooper wrote:
> On 01/10/2021 15:19, Jan Beulich wrote:
>> On 24.09.2021 21:39, Alex Olson wrote:
>>> Inspired by an earlier attempt by Chao Gao <chao.gao@intel.com>,
>>> this revision aims to put the hypervisor in control of x86 APIC ident=
ifier
>>> definition instead of hard-coding a formula in multiple places
>>> (libxl, hvmloader, hypervisor).
>>>
>>> This is intended as a first step toward exposing/altering CPU topolog=
y
>>> seen by guests.
>>>
>>> Changes:
>>>
>>> - Add field to vlapic for holding default ID (on reset)
>>>
>>> - add HVMOP_get_vcpu_topology_id hypercall so libxl (for PVH domains)=

>>>    can access APIC ids needed for ACPI table definition prior to doma=
in start.
>>>
>>> - For HVM guests, hvmloader now also uses the same hypercall.
>>>
>>> - Make CPUID code use vlapic ID instead of hard-coded formula
>>>    for runtime reporting to guests
>> I'm afraid a primary question from back at the time remains: How is
>> migration of a guest from an old hypervisor to one with this change
>> in place going to work?
>=20
> I'm afraid its not.
>=20
> Fixing this is incredibly complicated.=C2=A0 I have a vague plan, but i=
t
> needs building on the still-pending libxl cpuid work of Rogers.
>=20
> Both the toolstack and Xen need to learn about how to describe topology=

> correctly (and I'm afraid this patch isn't correct even for a number of=

> the simple cases), and know about "every VM booted up until this point
> in time" being wrong.

What about:

- adding APIC-Id to the migration stream
- adding an optional translation layer for guest APIC-Id to the
   hypervisor
- adding the functionality to set a specific APIC-Id for a vcpu
   (will use the translation layer if not the same as preferred
   by the hypervisor)


Juergen


--------------B0C5C823692A514D8492CBCF
Content-Type: application/pgp-keys;
 name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Transfer-Encoding: quoted-printable
Content-Description: OpenPGP public key
Content-Disposition: attachment;
 filename="OpenPGP_0xB0DE9DD628BF132F.asc"

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy=
cWx
w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O=
f8Z
d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y=
9bf
IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq=
G7/
377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR=
3Jv
c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA=
QIe
AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT=
hpw
dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0=
MbD
1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv=
oPH
Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v=
5QL
+qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ=
2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC=
QoL
BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr=
Wf0
teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC=
/nu
AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh=
ITT
d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm=
XBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz=
80h
SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC=
AcD
AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn=
FOX
gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1=
jnD
kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0=
N51
N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l=
otu
fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1=
tqS
EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA=
hsD
BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3=
g3O
ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5=
dM7
wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5=
D+j
LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm=
V2x
AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N=
Eaw
QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW=
nHI
s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR=
wgn
BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV=
bVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk=
pEd
IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA=
QAB
wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw=
Tbe
8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1=
vJz
Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8=
VGi
wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW=
svi
uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX=
zXs
ZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------B0C5C823692A514D8492CBCF--

--qloal8KDuf0hTndT05o5FZvYOhMa5RJ0J--

--qFnRQ2vezRbBQsa6Pi5FUPWd9zwwnp5nX
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmFXJIoFAwAAAAAACgkQsN6d1ii/Ey9Z
2Qf/fUUv8rgcstveoCfe0PTSI5EvBDh6gFSxZjKUEKnnCi/mXJHz2kf/J8F/hGuG1bJqRxL0PvBx
y3qYY2Nx7QhbJ8jUIOeYN4L4cmvNBEsGxqs0Cq8fOuwW3UnOjyjEioDktSSxL+G6B/pakNiSj+YH
kj+KdvvIDisu4x6quHnfWRoV/+eVA/+8Uukno1l2tjGqLTQjq1MmB3ic7BF8ocVOzb+yIcIn2mfq
m6a72r+sM60aq3GXdAqCvZkGAwM8izyoALUpf/ugYML0Tb2FZNbPJQACA0GWSs6pPrHurxt9sifw
Ez+qVXD4X36mJ4/d03B26r6leh8WI4R5ExjhBAaByw==
=IWGm
-----END PGP SIGNATURE-----

--qFnRQ2vezRbBQsa6Pi5FUPWd9zwwnp5nX--


From xen-devel-bounces@lists.xenproject.org Fri Oct 01 15:13:48 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Oct 2021 15:13:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.200740.355298 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mWKEM-0002C8-Vw; Fri, 01 Oct 2021 15:13:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 200740.355298; Fri, 01 Oct 2021 15:13:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mWKEM-0002C1-So; Fri, 01 Oct 2021 15:13:46 +0000
Received: by outflank-mailman (input) for mailman id 200740;
 Fri, 01 Oct 2021 15:13:45 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=1xS6=OV=linuxfoundation.org=gregkh@srs-us1.protection.inumbo.net>)
 id 1mWKEL-0002Bv-5n
 for xen-devel@lists.xenproject.org; Fri, 01 Oct 2021 15:13:45 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 41729e8c-2b9f-4fa2-b198-e559fa171c6c;
 Fri, 01 Oct 2021 15:13:44 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id 0EB1761A03;
 Fri,  1 Oct 2021 15:13:42 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 41729e8c-2b9f-4fa2-b198-e559fa171c6c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org;
	s=korg; t=1633101223;
	bh=lBCw9bkSZZDHUXzzaKop+6Hnc/MB752lkrnFW0SX3Yw=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=VldMVTz6nDca+vkVL8e0kiTzKzysrG6rFWnNAdrhL29IS+EMl5QwhGpw8dSZLXlBh
	 RYbctzhceiSbuD4LaWuLtoUIuBQXVmxEPSlh4UE5F+8UMCNeglXC361wnol0MdUsAc
	 ExxYnVHJCfPy1EhxNh6TSc2+qsyiFjynOVMT4zPg=
Date: Fri, 1 Oct 2021 17:13:40 +0200
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Juergen Gross <jgross@suse.com>
Cc: xen-devel@lists.xenproject.org, linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 2/3] usb: Introduce Xen pvUSB frontend (xen hcd)
Message-ID: <YVclpB4HP4hynENV@kroah.com>
References: <20211001150039.15921-1-jgross@suse.com>
 <20211001150039.15921-3-jgross@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211001150039.15921-3-jgross@suse.com>

On Fri, Oct 01, 2021 at 05:00:38PM +0200, Juergen Gross wrote:
> --- /dev/null
> +++ b/drivers/usb/host/xen-hcd.c
> @@ -0,0 +1,1641 @@
> +/*
> + * xen-hcd.c

Need a SPDX line here, instead of the license boiler-plate text you
have.

Did you run checkpatch on this thing?  I thought that would have told
you about this.

> + *
> + * Xen USB Virtual Host Controller driver
> + *
> + * Copyright (C) 2009, FUJITSU LABORATORIES LTD.
> + * Author: Noboru Iwamatsu <n_iwamatsu@jp.fujitsu.com>
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; either version 2 of the License, or
> + * (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program; if not, see <http://www.gnu.org/licenses/>.
> + *
> + * Or, by your choice:
> + *
> + * When distributed separately from the Linux kernel or incorporated into
> + * other software packages, subject to the following license:
> + *
> + * Permission is hereby granted, free of charge, to any person obtaining a copy
> + * of this software and associated documentation files (the "Software"), to
> + * deal in the Software without restriction, including without limitation the
> + * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or
> + * sell copies of the Software, and to permit persons to whom the Software is
> + * furnished to do so, subject to the following conditions:
> + *
> + * The above copyright notice and this permission notice shall be included in
> + * all copies or substantial portions of the Software.
> + *
> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
> + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
> + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
> + * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
> + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
> + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
> + * DEALINGS IN THE SOFTWARE.

Dual licensing a USB host controller driver is, um, a very dubious
thing given that you can only interact with symbols exported with
EXPORT_SYMBOL_GPL() from the USB stack.

So you might want to change this...

If not, and you want to keep the dual license, I need some explaination
from a legal person at your company included in the changelog text, and
a signed-off-by from them as well.

thanks,

greg k-h


From xen-devel-bounces@lists.xenproject.org Fri Oct 01 15:14:16 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Oct 2021 15:14:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.200746.355309 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mWKEn-0002iM-AH; Fri, 01 Oct 2021 15:14:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 200746.355309; Fri, 01 Oct 2021 15:14:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mWKEn-0002iF-6W; Fri, 01 Oct 2021 15:14:13 +0000
Received: by outflank-mailman (input) for mailman id 200746;
 Fri, 01 Oct 2021 15:14:11 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=LCz3=OV=arm.com=Luca.Fancellu@srs-us1.protection.inumbo.net>)
 id 1mWKEl-0002i3-JU
 for xen-devel@lists.xenproject.org; Fri, 01 Oct 2021 15:14:11 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com (unknown
 [40.107.6.81]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 3a3cd7c2-22ca-11ec-bdb3-12813bfff9fa;
 Fri, 01 Oct 2021 15:14:10 +0000 (UTC)
Received: from AM6P195CA0017.EURP195.PROD.OUTLOOK.COM (2603:10a6:209:81::30)
 by AM9PR08MB7053.eurprd08.prod.outlook.com (2603:10a6:20b:410::19) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.15; Fri, 1 Oct
 2021 15:14:00 +0000
Received: from VE1EUR03FT008.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:209:81:cafe::11) by AM6P195CA0017.outlook.office365.com
 (2603:10a6:209:81::30) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.14 via Frontend
 Transport; Fri, 1 Oct 2021 15:14:00 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT008.mail.protection.outlook.com (10.152.18.75) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4566.14 via Frontend Transport; Fri, 1 Oct 2021 15:13:59 +0000
Received: ("Tessian outbound c21c48fbc857:v103");
 Fri, 01 Oct 2021 15:13:58 +0000
Received: from 506da9928403.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 A2EB8E77-DA12-432E-8606-FDCEB36E1DB3.1; 
 Fri, 01 Oct 2021 15:13:47 +0000
Received: from EUR03-DB5-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 506da9928403.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 01 Oct 2021 15:13:46 +0000
Received: from PAXPR08MB6816.eurprd08.prod.outlook.com (2603:10a6:102:130::10)
 by PR3PR08MB5754.eurprd08.prod.outlook.com (2603:10a6:102:91::15)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.14; Fri, 1 Oct
 2021 15:13:44 +0000
Received: from PAXPR08MB6816.eurprd08.prod.outlook.com
 ([fe80::c1b4:db1c:376f:b697]) by PAXPR08MB6816.eurprd08.prod.outlook.com
 ([fe80::c1b4:db1c:376f:b697%9]) with mapi id 15.20.4566.015; Fri, 1 Oct 2021
 15:13:43 +0000
Received: from smtpclient.apple (82.8.129.65) by
 LO2P265CA0208.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:9e::28) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4566.14 via Frontend Transport; Fri, 1 Oct 2021 15:13:43 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3a3cd7c2-22ca-11ec-bdb3-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=m2nTysSJReSsS5P/E2b3SW9+rjjhEy4D2yd+3EaRrrk=;
 b=xnN7Gn8z2+Fr46nfLZ9JbnoKEeUTkkyL1xq5kmnKH7AodIYJvwrr1FJrroKNLe+XbggqEOzs1tZ/EB5ML+YyTeYiiG0wYdh6JM50vUfE9pesNPy5ig9bFk3Zz7h73SyGoA17RlloZCXnetAYHKhROR11u0LuLAqfTZaTcGhh8hA=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: ac90298bd2fb9610
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ZlX+HrW+YtUm7lbxcNzrDIl9j0g2jDAJ63OOniBpSvkYufkX3DZ11C47o/EO03W3RCbprQBBY2rN2Iyv1YQEvof1oIoZ+hW3O3ARniGbUzmaoIM1A2ekgxQXzERwQxgIRLW9b1Jy+r7dQ2x3cvwvI6d6rq1Oi7e87S7uuepXMWZQXP9LYQW9W05vxQH9HtSFlRz4uCIB5hImCaUqWqweCnwmmHcb6GG6nA1nRLRXVefsBMa1DyQiw7Oq9PSyhT5Lhzex0OHJdqQEsvPEuhL+tYPR2XJdmEYyKWY3yDvWxrPzpv6pGGSem4xcjg/s6nOp8LQGxtsqydsahPeCXizsuw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=m2nTysSJReSsS5P/E2b3SW9+rjjhEy4D2yd+3EaRrrk=;
 b=ck7z8BnRxrDgER1VRnnrgn4f/cktcrRUc8XgpPgSc3BsLlah9ZkS3cvZzhCr651p/xzNEWe3cy93xg2vd6yFa0wClRPChM3KYiQcaYBPeIPv4xEaYuaXye0BPaeYpTFU7wNRUadmPUDBvl4092d9GBkRfG58QnaBh/CJwYybAuyeDfwAxDm2pVF0KZaH9lySat2z5togUUWgETtUBkV1LxFDqP2MODLC+RNZZiiqAnfwbj54e2wFkheSKRo3E+GOPKiXbdzlK2Cxy9mZoM7RFxJOCXqSGRrYYumHp6UM4AvgLHXXYl0L89+IQT81GhnplMaZvMs8cZ35OjYNc22Aig==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=m2nTysSJReSsS5P/E2b3SW9+rjjhEy4D2yd+3EaRrrk=;
 b=xnN7Gn8z2+Fr46nfLZ9JbnoKEeUTkkyL1xq5kmnKH7AodIYJvwrr1FJrroKNLe+XbggqEOzs1tZ/EB5ML+YyTeYiiG0wYdh6JM50vUfE9pesNPy5ig9bFk3Zz7h73SyGoA17RlloZCXnetAYHKhROR11u0LuLAqfTZaTcGhh8hA=
Authentication-Results-Original: suse.com; dkim=none (message not signed)
 header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
Content-Type: text/plain;
	charset=utf-8
Subject: Re: [PATCH v4 2/3] arm/efi: Use dom0less configuration when using EFI
 boot
From: Luca Fancellu <luca.fancellu@arm.com>
In-Reply-To: <ce8e7fda-4d74-4bce-78bd-387f9b7a395f@suse.com>
Date: Fri, 1 Oct 2021 16:13:37 +0100
Cc: Bertrand Marquis <bertrand.marquis@arm.com>,
 wei.chen@arm.com,
 Stefano Stabellini <sstabellini@kernel.org>,
 Julien Grall <julien@xen.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Ian Jackson <iwj@xenproject.org>,
 Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <55D6C05A-C0B4-4503-A7F8-D0BA11E0779B@arm.com>
References: <20210930142846.13348-1-luca.fancellu@arm.com>
 <20210930142846.13348-3-luca.fancellu@arm.com>
 <2fa4be34-9c69-21cb-632f-f566caf622ca@suse.com>
 <6DFF05BA-8250-4C6C-86DF-67997F8DAD46@arm.com>
 <ce8e7fda-4d74-4bce-78bd-387f9b7a395f@suse.com>
To: Jan Beulich <jbeulich@suse.com>
X-Mailer: Apple Mail (2.3654.120.0.1.13)
X-ClientProxiedBy: LO2P265CA0208.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:9e::28) To PAXPR08MB6816.eurprd08.prod.outlook.com
 (2603:10a6:102:130::10)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 60c22685-9744-4961-da12-08d984ee188b
X-MS-TrafficTypeDiagnostic: PR3PR08MB5754:|AM9PR08MB7053:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS:
	<AM9PR08MB7053938762421C0CF8A741D0E4AB9@AM9PR08MB7053.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Oob-TLC-OOBClassifiers: OLM:4941;OLM:4941;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 NlQyih+uS55X1pUizs96tGiP1vMoJQZtVE6TlJwl7U6QGNpiDtoqaNqB+pZV7EYa1XdVg/z2eOX1xXzDM24+DmJfHDlopk183pyHc6oDW49Utyi6qS/ZfLigeltDDuCL2oK+pP3P/I4oQtAJrKCYpeFrkbcVL5RclYqsg78fiIyX4qNzi3cb3/E+gRjrIvNnQlpqaa/gCiLIk0f9zcsl88kWVxppoux27gr+9Cej/liMNkSoxaSrXDeSTnpygIazkjpZe97beyq9R+N0Wrid4dGXHeBSG0W4eHjU0uyHYle+8grpCTPT3aGoIr4DOjach3D8WBkxl+B3z8T61AkzndYf9Wt5aV9FxgJtHjwdveNRnl5Hm1yihvCLVolbIynxETeTf+iddThPsKeej/AkiQKA1ERP5icQzR39SeWU/4F7XofYuz1zM9co/9REiFcFO/FnrQcJ8bEIxMVCH81iHPiNaYf44aFismuCNFKwlkSKqXaul6eDZO4YNl7i6un7w/+KcetK/lOTtwusGTnKd1cc7x3+okFdiwRW0DT661lybC9V6d/JeUkF8OtjW+1O1oezyhF/3D6URdIQfNOOt5eejcQCyLv7PMvDNqU3IXr6WVvJXu7iKwcEVMySzPoV5CU7JcJF7Pc9JQwpG1pjikNS0iv7H6TPOSr5H91qPwwYBVqTz3aDaI3SJfxt/2v88c95/kJvs/T8fyubt3DZywtOdUAPc/9QEDQSXtFpFXLk8S2IQ+/uQYFmv3r11323kSctBTubUOJazxq4WjozMA==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB6816.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(8676002)(5660300002)(86362001)(38100700002)(38350700002)(316002)(508600001)(6666004)(44832011)(8936002)(66556008)(66476007)(54906003)(6512007)(66946007)(2906002)(6916009)(83380400001)(52116002)(33656002)(6486002)(36756003)(186003)(2616005)(956004)(6506007)(26005)(4326008)(53546011)(32563001)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR08MB5754
Original-Authentication-Results: suse.com; dkim=none (message not signed)
 header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT008.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	addb74ce-5bab-45bf-58d8-08d984ee0ef7
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	hWmNk1fz8UPYHF+facAvqXXSLzH5VTfBm6e3aMVAE1RsyC+SZSJSxaNyAxz1VNFYTtQXa7DStWgNpnM8a2LybVNtbq1ipCKGV+Ex5dJZ3jRxUFQibaa3XbpotUCaTXS6XbPUnU6YbbualI1akPFJXXENYxFcpEUKPqrBFcBLmzSdKEusHqY4i/wp4DXACG1BDlbn+dqqmoZMyQdgg7n2SwVZFeewHbYVG6IIXPVgT0FIhjKVf9bgdcGGWPn4qlDynrLkgBWNN5cNPNx+OvF30KpWU71WfKQs0j/La/u36q5XM3W5nDvYUa9JOe6p9Ht8zJbOYI/KB0rnDe2BiIGmDIfxeXCrZW4WZOQdc1i9HZoooxNFHpn14bpsDZN/0Sh35RHcIp03fhN9i4KeFVLnZ2r+npv40L/zI7CueiGWxlYc6sVYTjnbKNkEyXcs/8C/mQpJGegxvl9XqqQ5OmUWxMo0ymnD1OrxI924uTgqrYz6R3dWwLEJsxMsLubYoE8rie4DVn+685fxkMeyYd4Kty1LQ2fudlRVhF42SmE+7XAqqqBffCWosSJ5J0IuvHWHgN08qkgNHtCep72KLLMrkgXMy0e/ldu30bhHvbdkd/BxS5wYLKQlI0hVxtNWvsNv6rMPtagAUe482qsn3fIk8yEfjF8JNQXu+PvqEpQ41hgzp7o/xal5HX3YQNwOzPJ66WS0l54zHk8gkpg5vP06XdjgAahWUDP3CoWZopnJVDA=
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(33656002)(4326008)(83380400001)(336012)(6486002)(54906003)(36860700001)(36756003)(53546011)(6862004)(26005)(6506007)(8676002)(6512007)(8936002)(186003)(44832011)(5660300002)(356005)(956004)(81166007)(82310400003)(2906002)(508600001)(86362001)(2616005)(6666004)(47076005)(70586007)(70206006)(316002)(32563001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Oct 2021 15:13:59.7507
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 60c22685-9744-4961-da12-08d984ee188b
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT008.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB7053



> On 1 Oct 2021, at 15:22, Jan Beulich <jbeulich@suse.com> wrote:
>=20
> On 01.10.2021 15:55, Luca Fancellu wrote:
>>> On 1 Oct 2021, at 12:02, Jan Beulich <jbeulich@suse.com> wrote:
>>> On 30.09.2021 16:28, Luca Fancellu wrote:
>>>> @@ -1361,12 +1361,30 @@ efi_start(EFI_HANDLE ImageHandle, EFI_SYSTEM_T=
ABLE *SystemTable)
>>>>        efi_bs->FreePages(cfg.addr, PFN_UP(cfg.size));
>>>>        cfg.addr =3D 0;
>>>>=20
>>>> -        dir_handle->Close(dir_handle);
>>>> -
>>>>        if ( gop && !base_video )
>>>>            gop_mode =3D efi_find_gop_mode(gop, cols, rows, depth);
>>>>    }
>>>>=20
>>>> +#ifdef CONFIG_HAS_DEVICE_TREE
>>>> +    /* Get the number of boot modules specified on the DT or an error=
 (<0) */
>>>> +    dt_modules_found =3D efi_arch_check_dt_boot(dir_handle);
>>>> +#endif
>>>=20
>>> So I had asked to add a stub enclosed in such an #ifdef, to avoid the
>>> #ifdef here. I may be willing to let you keep things as you have them
>>> now, but I'd like to understand why you've picked that different
>>> approach despite the prior discussion.
>>=20
>> There must be a misunderstanding, your message in the v3 was:
>>=20
>> "Every time I see this addition I'm getting puzzled. As a result I'm
>> afraid I now need to finally ask you to do something about this (and
>> I'm sorry for doing so only now). There would better be no notion of
>> DT in x86 code, and there would better also not be a need for
>> architectures not supporting DT to each supply such a stub. Instead
>> I think you want to put this stub in xen/common/efi/boot.c, inside a
>> suitable #ifdef.=E2=80=9D
>>=20
>> So I thought you wanted me to remove the stub in x86 (since it doesn=E2=
=80=99t support DT)
>> and put this call under #ifdef so it won=E2=80=99t be compiled for arch =
not supporting DT.
>=20
> So FTAOD I'll repeat the crucial part: "I think you want to put this
> stub in xen/common/efi/boot.c". There was nothing about removing the
> stub altogether.

Oh ok, now I see, so in your opinion this is a better idea:

#ifndef CONFIG_HAS_DEVICE_TREE
static inline int __init efi_arch_check_dt_boot(EFI_FILE_HANDLE dir_handle)
{
    return 0;
}
#endif

But I would like to understand the advantage respect of my approach, could =
you
explain me?

Cheers,
Luca


>=20
> Jan
>=20



From xen-devel-bounces@lists.xenproject.org Fri Oct 01 15:20:57 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Oct 2021 15:20:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.200754.355319 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mWKLA-0004IG-0C; Fri, 01 Oct 2021 15:20:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 200754.355319; Fri, 01 Oct 2021 15:20:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mWKL9-0004I9-Tb; Fri, 01 Oct 2021 15:20:47 +0000
Received: by outflank-mailman (input) for mailman id 200754;
 Fri, 01 Oct 2021 15:20:46 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=kuDH=OV=suse.com=jgross@srs-us1.protection.inumbo.net>)
 id 1mWKL8-0004Hn-EH
 for xen-devel@lists.xenproject.org; Fri, 01 Oct 2021 15:20:46 +0000
Received: from smtp-out2.suse.de (unknown [195.135.220.29])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id a1b0d5ae-b3d0-462c-a74f-7cc97aa39a8a;
 Fri, 01 Oct 2021 15:20:45 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id A3BF920063;
 Fri,  1 Oct 2021 15:20:44 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 826FA13C6D;
 Fri,  1 Oct 2021 15:20:44 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id pf6EHkwnV2FyRQAAMHmgww
 (envelope-from <jgross@suse.com>); Fri, 01 Oct 2021 15:20:44 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a1b0d5ae-b3d0-462c-a74f-7cc97aa39a8a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1633101644; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=bVBXsAy0b+itOER7N3I1oQ05RMyRcTR4aLXyKhF7/ow=;
	b=WnVojoIqXGMCT3eLYfMopamfp7uBnYbCeyIQb5gjrfzq7m1Xl3Q/TJCmSZYUAFy0RkpQ7n
	onDxqjmTbJ1Nx62uwCUVJo4GYn20sVBfZC+SdbZMn6VMtH87h2FOfmefDgGJ+dEcs8mGgd
	iE38tX47/B4oO9zPcFRF1y1uFDhCKAU=
Subject: Re: [PATCH v5 2/3] usb: Introduce Xen pvUSB frontend (xen hcd)
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: xen-devel@lists.xenproject.org, linux-usb@vger.kernel.org,
 linux-kernel@vger.kernel.org
References: <20211001150039.15921-1-jgross@suse.com>
 <20211001150039.15921-3-jgross@suse.com> <YVclpB4HP4hynENV@kroah.com>
From: Juergen Gross <jgross@suse.com>
Message-ID: <de25b52e-7db3-3845-38e9-dc8353b23308@suse.com>
Date: Fri, 1 Oct 2021 17:20:43 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <YVclpB4HP4hynENV@kroah.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="Hrj6TJnAjNUwTljeSgccEyMV8hhYdDI7S"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--Hrj6TJnAjNUwTljeSgccEyMV8hhYdDI7S
Content-Type: multipart/mixed; boundary="Rd4R2m5iuBTmN24qGWaADmT8GM6YKMIGa";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: xen-devel@lists.xenproject.org, linux-usb@vger.kernel.org,
 linux-kernel@vger.kernel.org
Message-ID: <de25b52e-7db3-3845-38e9-dc8353b23308@suse.com>
Subject: Re: [PATCH v5 2/3] usb: Introduce Xen pvUSB frontend (xen hcd)
References: <20211001150039.15921-1-jgross@suse.com>
 <20211001150039.15921-3-jgross@suse.com> <YVclpB4HP4hynENV@kroah.com>
In-Reply-To: <YVclpB4HP4hynENV@kroah.com>

--Rd4R2m5iuBTmN24qGWaADmT8GM6YKMIGa
Content-Type: multipart/mixed;
 boundary="------------12BBFCA059E989F27D2F36B1"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------12BBFCA059E989F27D2F36B1
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 01.10.21 17:13, Greg Kroah-Hartman wrote:
> On Fri, Oct 01, 2021 at 05:00:38PM +0200, Juergen Gross wrote:
>> --- /dev/null
>> +++ b/drivers/usb/host/xen-hcd.c
>> @@ -0,0 +1,1641 @@
>> +/*
>> + * xen-hcd.c
>=20
> Need a SPDX line here, instead of the license boiler-plate text you
> have.
>=20
> Did you run checkpatch on this thing?  I thought that would have told
> you about this.
>=20
>> + *
>> + * Xen USB Virtual Host Controller driver
>> + *
>> + * Copyright (C) 2009, FUJITSU LABORATORIES LTD.
>> + * Author: Noboru Iwamatsu <n_iwamatsu@jp.fujitsu.com>
>> + *
>> + * This program is free software; you can redistribute it and/or modi=
fy
>> + * it under the terms of the GNU General Public License as published =
by
>> + * the Free Software Foundation; either version 2 of the License, or
>> + * (at your option) any later version.
>> + *
>> + * This program is distributed in the hope that it will be useful,
>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
>> + * GNU General Public License for more details.
>> + *
>> + * You should have received a copy of the GNU General Public License
>> + * along with this program; if not, see <http://www.gnu.org/licenses/=
>.
>> + *
>> + * Or, by your choice:
>> + *
>> + * When distributed separately from the Linux kernel or incorporated =
into
>> + * other software packages, subject to the following license:
>> + *
>> + * Permission is hereby granted, free of charge, to any person obtain=
ing a copy
>> + * of this software and associated documentation files (the "Software=
"), to
>> + * deal in the Software without restriction, including without limita=
tion the
>> + * rights to use, copy, modify, merge, publish, distribute, sublicens=
e, and/or
>> + * sell copies of the Software, and to permit persons to whom the Sof=
tware is
>> + * furnished to do so, subject to the following conditions:
>> + *
>> + * The above copyright notice and this permission notice shall be inc=
luded in
>> + * all copies or substantial portions of the Software.
>> + *
>> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EX=
PRESS OR
>> + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTAB=
ILITY,
>> + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT =
SHALL THE
>> + * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR O=
THER
>> + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, AR=
ISING
>> + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHE=
R
>> + * DEALINGS IN THE SOFTWARE.
>=20
> Dual licensing a USB host controller driver is, um, a very dubious
> thing given that you can only interact with symbols exported with
> EXPORT_SYMBOL_GPL() from the USB stack.
>=20
> So you might want to change this...

Ah, right. I thought I wouldn't be able to do so, as the original driver
was including above license text, but reading it again I think I can
just make it GPL-V2.


Juergen

--------------12BBFCA059E989F27D2F36B1
Content-Type: application/pgp-keys;
 name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Transfer-Encoding: quoted-printable
Content-Description: OpenPGP public key
Content-Disposition: attachment;
 filename="OpenPGP_0xB0DE9DD628BF132F.asc"

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy=
cWx
w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O=
f8Z
d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y=
9bf
IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq=
G7/
377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR=
3Jv
c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA=
QIe
AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT=
hpw
dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0=
MbD
1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv=
oPH
Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v=
5QL
+qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ=
2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC=
QoL
BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr=
Wf0
teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC=
/nu
AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh=
ITT
d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm=
XBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz=
80h
SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC=
AcD
AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn=
FOX
gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1=
jnD
kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0=
N51
N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l=
otu
fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1=
tqS
EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA=
hsD
BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3=
g3O
ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5=
dM7
wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5=
D+j
LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm=
V2x
AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N=
Eaw
QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW=
nHI
s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR=
wgn
BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV=
bVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk=
pEd
IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA=
QAB
wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw=
Tbe
8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1=
vJz
Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8=
VGi
wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW=
svi
uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX=
zXs
ZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------12BBFCA059E989F27D2F36B1--

--Rd4R2m5iuBTmN24qGWaADmT8GM6YKMIGa--

--Hrj6TJnAjNUwTljeSgccEyMV8hhYdDI7S
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmFXJ0sFAwAAAAAACgkQsN6d1ii/Ey9C
twf/Te9k/zYG2ynHFJXt3Ui3BhE+h5hZmqEvNpXtPnu1iQI9iRSVsSFBO7hIdbAhCWYubVGXxe4A
1bijW5NnHOo891xlHI9VCgRQv3Wmg80oFVXtU5kQTIK+iacHkowzull4b9WnOZV1Yo9ROd8/PotQ
PbCLiGrfNiUXGikjD30glIjvLOGpQIPXdGsWsxXWxM81gG/X74/863Sh4QrroGxC/J1a9v7j+xgr
x5Jgd8AX85q0I0K7yGjBphj5vQZHkLd82WxH+be301EfJjwqUFsyNXxFn9wEZTpMlWPa7PWKA4pk
k4t69HGXEgfO+zOptlC2E99ZusHYh7sdcDfoy3Crzg==
=xvfH
-----END PGP SIGNATURE-----

--Hrj6TJnAjNUwTljeSgccEyMV8hhYdDI7S--


From xen-devel-bounces@lists.xenproject.org Fri Oct 01 15:29:06 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Oct 2021 15:29:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.200764.355331 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mWKT6-00059j-UO; Fri, 01 Oct 2021 15:29:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 200764.355331; Fri, 01 Oct 2021 15:29:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mWKT6-00059c-RJ; Fri, 01 Oct 2021 15:29:00 +0000
Received: by outflank-mailman (input) for mailman id 200764;
 Fri, 01 Oct 2021 15:28:59 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=1xS6=OV=linuxfoundation.org=gregkh@srs-us1.protection.inumbo.net>)
 id 1mWKT5-00059W-Fm
 for xen-devel@lists.xenproject.org; Fri, 01 Oct 2021 15:28:59 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 4bdfbcfe-22cc-11ec-bdb4-12813bfff9fa;
 Fri, 01 Oct 2021 15:28:58 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id 7E40661A6F;
 Fri,  1 Oct 2021 15:28:57 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4bdfbcfe-22cc-11ec-bdb4-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org;
	s=korg; t=1633102138;
	bh=niK2N0n5hIFSNGOKBWBl+J6uRun5yG+bcgN8gmYM7Vk=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=SyK+OXYcQH6Wu+IUyJxCMR2ZWu1juVPrb3ea9UOVZDOOpROfob9jNNaA+8fYyV+Cv
	 6o3VzanXkwB27G4TBqHFvvFW/wZYrzziqcnqGnF7rbafo40YlnXkB+Yh9sYtN6dvlB
	 CtNrCP/W8ZfGE6Gu0rJw5761qvZXLCTVvz1ylZ9A=
Date: Fri, 1 Oct 2021 17:28:55 +0200
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Juergen Gross <jgross@suse.com>
Cc: xen-devel@lists.xenproject.org, linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>
Subject: Re: [PATCH v5 0/3] xen, usb: support pvUSB frontend driver
Message-ID: <YVcpNwTtnm2KAnP+@kroah.com>
References: <20211001150039.15921-1-jgross@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211001150039.15921-1-jgross@suse.com>

On Fri, Oct 01, 2021 at 05:00:36PM +0200, Juergen Gross wrote:
> This series adds XEN guest pvUSB support. With pvUSB it is possible to
> use physical USB devices from a XEN domain.
> 
> Since V4 a lot of time (several years) has passed. This is a revived
> attempt to get the frontend into the kernel.
> 
> The support consists of a frontend in form of a virtual hcd driver in
> the unprivileged domU passing I/O-requests to the backend in a driver
> domain (usually Dom0). The backend is not part of this patch series,
> as it is supported via qemu.
> 
> The code is taken (and adapted) from the original pvUSB implementation
> done for Linux 2.6 in 2008 by Fujitsu.
> 
> Normal operation of USB devices by adding and removing them dynamically
> to/from a domain has been tested using various USB devices (USB 1.1,
> 2.0 and 3.0) using the qemu based backend.
> 
> Changes in V5:
> - added interface documentation to patch 1
> - frontend no longer trusts backend to return only sane values

You forgot to send patch 3/3 to the linux-usb list :(


From xen-devel-bounces@lists.xenproject.org Fri Oct 01 15:53:22 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Oct 2021 15:53:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.200774.355342 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mWKqQ-0008MT-UW; Fri, 01 Oct 2021 15:53:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 200774.355342; Fri, 01 Oct 2021 15:53:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mWKqQ-0008MM-Qo; Fri, 01 Oct 2021 15:53:06 +0000
Received: by outflank-mailman (input) for mailman id 200774;
 Fri, 01 Oct 2021 15:53:05 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=wCRN=OV=linuxfoundation.org=aweltz@srs-us1.protection.inumbo.net>)
 id 1mWKqP-0008MG-1G
 for xen-devel@lists.xenproject.org; Fri, 01 Oct 2021 15:53:05 +0000
Received: from mail-io1-xd2d.google.com (unknown [2607:f8b0:4864:20::d2d])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id cd0e8980-9b07-4a66-8ada-ff847f3b22f5;
 Fri, 01 Oct 2021 15:53:03 +0000 (UTC)
Received: by mail-io1-xd2d.google.com with SMTP id b78so12217197iof.2
 for <xen-devel@lists.xenproject.org>; Fri, 01 Oct 2021 08:53:03 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: cd0e8980-9b07-4a66-8ada-ff847f3b22f5
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linuxfoundation.org; s=google;
        h=mime-version:from:date:message-id:subject:to:cc;
        bh=Dz/fPEdYqX9+LABAefdwyNZbqnTPpSNKVGckoTyTTa8=;
        b=aMp2kteUgmJdwg2O9VraGGnWydWYUOenENknWOP7klMlqLg4/RDBwycMj6EqTkIahB
         skDfMldZetu2+Qu9kKTT6KV3yX6D5jF+SpxTeVugDD93DeYWwhoW7hLxlyugy5DzuZ8+
         XImODqUE1Q8aTgFnULZLFpNZdqMNuVC54xsB8=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc;
        bh=Dz/fPEdYqX9+LABAefdwyNZbqnTPpSNKVGckoTyTTa8=;
        b=lQJHc/jGmklnfbvEc/Pg/G2908kfbaPZhDgd7zgg+wIS6VKfLcTVAvnSfZW2sGPh+o
         JlYc97F3a3vLKMIcJaFiyfclwHPGNBuKwS+AsAKrLuqhXt2jKg/Vs5VX/PPV2X2ABxCw
         u/D5kMTBSDHMnKeC7i9nHPXPQfzIGaEtdzKT/iihN7l3JCKwfuORFdf5m/EiDBnWrUQn
         On9AOk4XQItlcLEiwpy2ofGyzAc8ImkiEvGeHQHs7y8hCA74Z3/2gIqbDiwHq6espdIC
         2dr4RdWFf0SfJMN+h++bnh1LgSUVyUomo3IJ02Fpe/m1TeHsmAiZF+bkUVgREyD+lwNQ
         yL/A==
X-Gm-Message-State: AOAM530+rwnKABXNbmLVWUFT7uCeF46EmlC0wIzdEfrW5z/2fUelzZAO
	+3wAf69/fBwYr5IT9KLwUUFH452D0Xd9JvoXjoVGBw==
X-Google-Smtp-Source: ABdhPJy3SgRPLFpEVUX+8pkI/+R9VMVdZF75NHR6fsIneCc4TPWoGaFQ9dQ3A23VV9+VrGsMZynrFzpEaj1OXKSWw6U=
X-Received: by 2002:a5d:80d7:: with SMTP id h23mr8559247ior.68.1633103582546;
 Fri, 01 Oct 2021 08:53:02 -0700 (PDT)
MIME-Version: 1.0
From: Ashley Weltz <aweltz@linuxfoundation.org>
Date: Fri, 1 Oct 2021 11:52:52 -0400
Message-ID: <CADT4064VW2uG2SfOQmCjGJTmQGgWz=YeAVpS27CQiL-tvW5QqQ@mail.gmail.com>
Subject: Call for agenda items for October 5th Community Call @ 1500 UTC
To: amit@infradead.org, andrew.cooper3@citrix.com, Artem_Mygaiev@epam.com, 
	ash.j.wilding@gmail.com, ben@exotanium.io, bobby.eshleman@gmail.com, 
	brendank310@gmail.com, brian.woods@xilinx.com, cardoe@cardoe.com, 
	christopher.w.clark@gmail.com, Corey Minyard <cminyard@mvista.com>, 
	daniel.kiper@oracle.com, deepthi.m@ltts.com, dpsmith@apertussolutions.com, 
	dwmw@amazon.co.uk, edgar.iglesias@xilinx.com, Ian.Jackson@citrix.com, 
	insurgo@riseup.net, intel-xen@intel.com, Jarvis.Roach@dornerworks.com, 
	Jeff.Kubascik@dornerworks.com, jgross@suse.com, john.ji@intel.com, 
	julien@xen.org, kevin.pearson@ortmanconsulting.com, Matt.Spencer@arm.com, 
	=?UTF-8?Q?Mirela_Simonovi=C4=87?= <mirela.simonovic@aggios.com>, 
	oleksandr_andrushchenko@epam.com, oleksandr_tyshchenko@epam.com, 
	olivier.lambert@vates.fr, pdurrant@amazon.com, persaur@gmail.com, 
	piotr.krol@3mdeb.com, Rahul.Singh@arm.com, rianquinn@gmail.com, 
	rob.townley@gmail.com, robin.randhawa@arm.com, roger.pau@citrix.com, 
	scottwd@gmail.com, sergey.dyasli@citrix.com, sstabellini@kernel.org, 
	Stewart.Hildebrand@dornerworks.com, tamas.k.lengyel@gmail.com, 
	varadgautam@gmail.com, volodymyr_babchuk@epam.com, wl@xen.org
Cc: xen-devel@lists.xenproject.org
Content-Type: multipart/alternative; boundary="000000000000eb625805cd4c8ed5"

--000000000000eb625805cd4c8ed5
Content-Type: text/plain; charset="UTF-8"

Hi everyone,

Our next meeting is this upcoming Tuesday at 1500 UTC.

The proposed agenda is in
https://cryptpad.fr/pad/#/2/pad/edit/dcsJegMwUJOPrLTIscYT4bBa/ Please add
or edit any items to this agenda. Alternatively, please feel free to email
me directly with agenda items.

Please put your name beside any items if you edit the document.

We will plan to start the meeting 5 minutes past the hour.

* If you want to be CC'ed please add or remove yourself from the
sign-up-sheet at
https://cryptpad.fr/pad/#/2/pad/edit/D9vGzihPxxAOe6RFPz0sRCf+/

Again, please let me know if you have any questions. See you on Tuesday!

Cheers,
Ashley

-- 
Ashley Weltz, Project Coordinator
The Linux Foundation
aweltz@linuxfoundation.org

--000000000000eb625805cd4c8ed5
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div>Hi everyone,</div><div><br></div><div>Our next meetin=
g is this upcoming Tuesday at 1500 UTC.=C2=A0</div><div><br></div><div>The =
proposed agenda is in=C2=A0<a href=3D"https://cryptpad.fr/pad/#/2/pad/edit/=
dcsJegMwUJOPrLTIscYT4bBa/">https://cryptpad.fr/pad/#/2/pad/edit/dcsJegMwUJO=
PrLTIscYT4bBa/</a>=C2=A0Please add or edit any items to this agenda. Altern=
atively, please feel free to email me directly with agenda items.=C2=A0</di=
v><div><br>Please put your name beside any items if you edit the document.<=
br><br>We will plan to start the meeting 5 minutes past the hour.=C2=A0<br>=
<br>* If you want to be CC&#39;ed please add or remove yourself from the si=
gn-up-sheet at=C2=A0<a href=3D"https://cryptpad.fr/pad/#/2/pad/edit/D9vGzih=
PxxAOe6RFPz0sRCf+/" rel=3D"noreferrer" target=3D"_blank">https://cryptpad.f=
r/pad/#/2/pad/edit/D9vGzihPxxAOe6RFPz0sRCf+/</a></div><div><br></div><div>A=
gain, please let me know if you have any questions. See you on Tuesday!</di=
v><div><br></div><div>Cheers,</div><div>Ashley</div><div><br></div>-- <br><=
div dir=3D"ltr" class=3D"gmail_signature" data-smartmail=3D"gmail_signature=
"><div dir=3D"ltr">Ashley Weltz, Project Coordinator=C2=A0<div>The Linux Fo=
undation</div><div><a href=3D"mailto:aweltz@linuxfoundation.org" target=3D"=
_blank">aweltz@linuxfoundation.org</a></div></div></div></div>

--000000000000eb625805cd4c8ed5--


From xen-devel-bounces@lists.xenproject.org Fri Oct 01 16:20:19 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Oct 2021 16:20:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.200783.355353 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mWLGe-0003t1-4l; Fri, 01 Oct 2021 16:20:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 200783.355353; Fri, 01 Oct 2021 16:20:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mWLGe-0003su-1S; Fri, 01 Oct 2021 16:20:12 +0000
Received: by outflank-mailman (input) for mailman id 200783;
 Fri, 01 Oct 2021 16:20:11 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=LRx5=OV=arm.com=Rahul.Singh@srs-us1.protection.inumbo.net>)
 id 1mWLGc-0003so-Sf
 for xen-devel@lists.xenproject.org; Fri, 01 Oct 2021 16:20:11 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com (unknown
 [40.107.7.83]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 71254dc4-22d3-11ec-bdbf-12813bfff9fa;
 Fri, 01 Oct 2021 16:20:08 +0000 (UTC)
Received: from AM5PR0201CA0011.eurprd02.prod.outlook.com
 (2603:10a6:203:3d::21) by DB9PR08MB6716.eurprd08.prod.outlook.com
 (2603:10a6:10:2a9::8) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.16; Fri, 1 Oct
 2021 16:20:04 +0000
Received: from AM5EUR03FT033.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:203:3d:cafe::da) by AM5PR0201CA0011.outlook.office365.com
 (2603:10a6:203:3d::21) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.16 via Frontend
 Transport; Fri, 1 Oct 2021 16:20:04 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM5EUR03FT033.mail.protection.outlook.com (10.152.16.99) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4566.14 via Frontend Transport; Fri, 1 Oct 2021 16:20:03 +0000
Received: ("Tessian outbound a492f2284909:v103");
 Fri, 01 Oct 2021 16:20:01 +0000
Received: from a4d7aab8aa4b.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 5A60EDF5-98B9-4CD8-9F56-8143456E35B3.1; 
 Fri, 01 Oct 2021 16:19:50 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id a4d7aab8aa4b.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 01 Oct 2021 16:19:50 +0000
Received: from AS8PR08MB6919.eurprd08.prod.outlook.com (2603:10a6:20b:39e::10)
 by AM6PR08MB4707.eurprd08.prod.outlook.com (2603:10a6:20b:c2::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.24; Fri, 1 Oct
 2021 16:19:47 +0000
Received: from AS8PR08MB6919.eurprd08.prod.outlook.com
 ([fe80::c8de:afad:1d5a:efd0]) by AS8PR08MB6919.eurprd08.prod.outlook.com
 ([fe80::c8de:afad:1d5a:efd0%7]) with mapi id 15.20.4544.022; Fri, 1 Oct 2021
 16:19:47 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 71254dc4-22d3-11ec-bdbf-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=a3eNJBTmmjo0IsHO8feZrC8diB2cDpGX4jzdW2FiT2k=;
 b=OpPRFkLCmcSKtFIDBGcvufbEKXVdrW1wMuOVskUDG3FEiq99k+aasBFyVvodl7d1Rc8TlNL3IwrR09c4fKQIcofJULGWGfpzlvVYB4ETeUuLXAzSpZtSUVfTLpPs1a9dynB9CsXCsDeHkwNNG4qmvvhzmdOwQs/ko+YOsOx7k/w=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 7600e407f9ccc04a
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=O1X6b0gZHuXaZmlA26KR5wWqa14EsKAWxYSURR1MAPpBzZE18WPtDbG3lymAPbFXS5PlWWQxYbX4iM9nWB8RhJjDBtE4ly/Re1Og0Z9Yq8xyF1igazo9nOQWfTaUkf4Dje6Ve8627F48KsBgqh+6DfkmISYkMX8AcqOxXG+JSNrUT6suQY1DZdPd4JUFsOUANcGv+aqw07rWHQXwk/BEOBM2T1llXtD8Sqg49Qf/aDuSGXyvW+gI6lVSQp3nUwk+FBo8UMYo3KD6/XXO7CgE/wNZPf5pbnOuCbacIFs7NcbHLunh6o3mDzCbQyycuKR5S7tc+KBnKYnbShIwGZ6RDQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=a3eNJBTmmjo0IsHO8feZrC8diB2cDpGX4jzdW2FiT2k=;
 b=ixvWX49ns3fYSU7Ur260dPCc2+LbtYqFi/QIc4N/acNaMwEPXiFNjJ9lVbl8dXDlRJ234qQh3BkkB3phrlqnWZVUhczy1prWQywxWcE6nz/v4ieheEit3xvdBrgxPDa7YWJR00txG0VwtrP/H1ttvevykUwExcmaFO2AUTzCo3Wl5ektMV3DLwhncSnoQFUnkB6lZ2t7w9WqTZzoOq5zvi9b2nPwVI9rs/sBphnGOhTrtzoermoXSWK5Cm+vRf+uMor/LMAoq9Sg/eeXeE0bm9IjzmFBdGfSghOY1LmFT0ZGRcQEoOcg4xSdUksa9Hk2MUts0XPA/tOyTLLMDFLbQw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=a3eNJBTmmjo0IsHO8feZrC8diB2cDpGX4jzdW2FiT2k=;
 b=OpPRFkLCmcSKtFIDBGcvufbEKXVdrW1wMuOVskUDG3FEiq99k+aasBFyVvodl7d1Rc8TlNL3IwrR09c4fKQIcofJULGWGfpzlvVYB4ETeUuLXAzSpZtSUVfTLpPs1a9dynB9CsXCsDeHkwNNG4qmvvhzmdOwQs/ko+YOsOx7k/w=
From: Rahul Singh <Rahul.Singh@arm.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Bertrand Marquis <Bertrand.Marquis@arm.com>, Andre Przywara
	<Andre.Przywara@arm.com>, Stefano Stabellini <sstabellini@kernel.org>, Julien
 Grall <julien@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>, George Dunlap
	<george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>, Wei Liu
	<wl@xen.org>, =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>,
	xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v3 05/17] xen/arm: Add PHYSDEVOP_pci_device_* support for
 ARM
Thread-Topic: [PATCH v3 05/17] xen/arm: Add PHYSDEVOP_pci_device_* support for
 ARM
Thread-Index: AQHXtJWOAdm1vouco0OtrnAS4p/NLau8rAQAgAGrHIA=
Date: Fri, 1 Oct 2021 16:19:47 +0000
Message-ID: <7FE915FF-5743-48E5-B50E-9F5688344C45@arm.com>
References: <cover.1632847120.git.rahul.singh@arm.com>
 <f8ac00f7d52f4853d276b4da24294fbeb3602245.1632847120.git.rahul.singh@arm.com>
 <f4ff4369-3be1-eed0-d3e3-6c9d93952526@suse.com>
In-Reply-To: <f4ff4369-3be1-eed0-d3e3-6c9d93952526@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: yes
X-MS-TNEF-Correlator:
Authentication-Results-Original: suse.com; dkim=none (message not signed)
 header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: 7c571e19-367b-4542-4d1f-08d984f75351
x-ms-traffictypediagnostic: AM6PR08MB4707:|DB9PR08MB6716:
x-ms-exchange-transport-forked: True
X-Microsoft-Antispam-PRVS:
	<DB9PR08MB6716646BFE4400C265257379FCAB9@DB9PR08MB6716.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:9508;OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 EP3zzdbzq7uSdytRM+mB9nZITUOqq1aO6xqSbof9jv+lgkGd2p3K9BXmHen/JfnVDBZMVAoxoGG9cK3te6P+7jZ5NaW304UX/8X6l7LAxbWLNGO834zjckjbdceMmJcQh441HURQB6dGfg5Xnm9mnZKb9Z1nW39t11C1UkZTzHm4HyqNeEVplkVNyjmutz1/BTMXpegrZCUdr9P3qtaI8GxdC0oQJ4/a6+EavwpxikqYJmpV++MYOUCTVhJrFNm/FpqM9thpBmvXWWSxSSdSDq3s/pz4C3Xlh6H5vMscOKMpn9TqCg2uVap+3CYfJmUScU3RgggC0vwPSrEt2HeMFdCNoZwIWf6ah+pu0RMq4/8fSLHOT2OrxzGW3rFq0IXqFt3gPN6xnBfPyohjAjTjqtED0bzMAkRNW2Vsyp7s/Xju4enfiN6i/1E5bTxNYslL6mWC7f1eCzFnW7HOc3SuSv1GRHy/Z+iZMcUdIZbq68f0mRx24GELxecCWOo3L8fEmzUMrcUA6BH05/hDGyl1SXx7qnvE0tlWBv1K7cYBIIsXjZIMCyi5t+Kn+qYXarlHQqqVZWr+sQghxjG6SQroA1BY/eINq39lTtKK/zeyKHqsKJiAEmCO9CeiJ2J8ul0dxUdxQOeN9unUnRiSduX/UjjO0+tyqbSXIuQUBjHEYajqX/IcjKhlzXNI762dA7AoCdf01IMH9ZuEJiUoq8GcobK9N7IjmocR5rIsUAsQe0xY6qYM0rSJgR3M6XEva1HB
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6919.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(86362001)(316002)(122000001)(6506007)(53546011)(54906003)(7416002)(38100700002)(26005)(8676002)(186003)(508600001)(36756003)(99936003)(71200400001)(4326008)(6916009)(38070700005)(2616005)(66446008)(91956017)(66946007)(8936002)(6486002)(5660300002)(66616009)(66476007)(64756008)(76116006)(33656002)(83380400001)(6512007)(66556008)(2906002)(45980500001);DIR:OUT;SFP:1101;
Content-Type: multipart/mixed;
	boundary="_004_7FE915FF574348E5B50E9F5688344C45armcom_"
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB4707
Original-Authentication-Results: suse.com; dkim=none (message not signed)
 header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM5EUR03FT033.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	6d5da7e1-20fc-4e27-371b-08d984f74969
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	h8JekRJ14USQRx6cJXJWcyMkPGpGI+0jfuB/YDmUHzNz6PMaj79K9SDwwzDzqDO5U5aTL3ekrBSf3DMolJrqtGf1qYEMzScR4SGqgsAdhEi/1xGtF9oI+qfGOKI3ecHqrRr7koFnXAyHtaj6KW3P0xKX3KOh/ftIqkuFDOgX/Sq2qOWfyLBZC2y4bql96dkfEm8Ef0/9d6D6wJ7YNInxozhgP9XS8m4+CnPrgtjUEpuvkSuFyh2Pw5paNtHyNdSWKCzRLK1HYculTDc49J7WsegVaJKPCxZ95HC9Na2xcsC2hQz5E++B0G5Z0rk+jyG/SxTiyiF7KMIEz3gEtQ7rNPKBshPL+x3BqIvejD/XZOeIZ+8XYu8wAlcgEmZlRCK+TvMpHCZbcygfjSLCYqzcTpwk30wHUm2tKYF6m5XcwcU9/4YZq+VqekXtm/VyZizxM6Hzf8bzvY4o4JgVRYh1Q4grhWxJI22zMFGBuI4Qbd1av79USJui9dqUjHMRlJZUVvj1dFDEXQeB6VkKyJxqMWpAnoftd4y2k40oTHnID3UsAEeCAOss8Xvh13E3hhJsCtohLIVyQhsUw3SHm9B+Z/P7lXc2DB4EXujUAA3cq88coRYl0nnx2AzP+nelhKyGXL0R8rkefJB7Zv/tS7eOgeMi4b0fcNvwXhxygxGsAMEE3WboSbOsKHAySxpx4GM/E/5kGf6Tb7Nbo1wFvEk8UA==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(81166007)(6486002)(2906002)(70586007)(235185007)(66616009)(6506007)(33656002)(70206006)(54906003)(86362001)(8936002)(6512007)(4326008)(99936003)(33964004)(2616005)(336012)(508600001)(45080400002)(356005)(186003)(6862004)(316002)(82310400003)(5660300002)(26005)(47076005)(36860700001)(83380400001)(53546011)(36756003)(8676002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Oct 2021 16:20:03.8471
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 7c571e19-367b-4542-4d1f-08d984f75351
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM5EUR03FT033.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB6716

--_004_7FE915FF574348E5B50E9F5688344C45armcom_
Content-Type: multipart/alternative;
	boundary="_000_7FE915FF574348E5B50E9F5688344C45armcom_"

--_000_7FE915FF574348E5B50E9F5688344C45armcom_
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64

SGkgSmFuLA0KDQo+IE9uIDMwIFNlcCAyMDIxLCBhdCAzOjUxIHBtLCBKYW4gQmV1bGljaCA8amJl
dWxpY2hAc3VzZS5jb20+IHdyb3RlOg0KPg0KPiBPbiAyOC4wOS4yMDIxIDIwOjE4LCBSYWh1bCBT
aW5naCB3cm90ZToNCj4+IEhhcmR3YXJlIGRvbWFpbiBpcyBpbiBjaGFyZ2Ugb2YgZG9pbmcgdGhl
IFBDSSBlbnVtZXJhdGlvbiBhbmQgd2lsbA0KPj4gZGlzY292ZXIgdGhlIFBDSSBkZXZpY2VzIGFu
ZCB0aGVuIHdpbGwgY29tbXVuaWNhdGUgdG8gWEVOIHZpYSBoeXBlcg0KPj4gY2FsbCBQSFlTREVW
T1BfcGNpX2RldmljZV9hZGQoLi4pIHRvIGFkZCB0aGUgUENJIGRldmljZXMgaW4gWEVOLg0KPj4N
Cj4+IEFsc28gaW1wbGVtZW50IFBIWVNERVZPUF9wY2lfZGV2aWNlX3JlbW92ZSguLikgdG8gcmVt
b3ZlIHRoZSBQQ0kgZGV2aWNlLg0KPj4NCj4+IEFzIG1vc3Qgb2YgdGhlIGNvZGUgZm9yIFBIWVNE
RVZPUF9wY2lfZGV2aWNlXyogaXMgdGhlIHNhbWUgYmV0d2VlbiB4ODYNCj4+IGFuZCBBUk0sIG1v
dmUgdGhlIGNvZGUgdG8gYSBjb21tb24gZmlsZSB0byBhdm9pZCBkdXBsaWNhdGlvbi4NCj4+DQo+
PiBTaWduZWQtb2ZmLWJ5OiBSYWh1bCBTaW5naCA8cmFodWwuc2luZ2hAYXJtLmNvbT4NCj4NCj4g
T24gdjEgSnVsaWVuIHNhaWQ6DQo+DQo+ICJUaGVyZSBhcmUgb3RoZXIgUEhZU0RFVk9QIG9wZXJh
dGlvbnMgdG8gYWRkIFBDSSBkZXZpY2VzLiBJIHRoaW5rIGl0IGlzDQo+IGZpbmUgdG8gb25seSBp
bXBsZW1lbnQgdGhlIGxhdGVzdCAoQ0MgSmFuIGZvciBzb21lIG9waW5pb24gYW5kIGNvbmZpcm0N
Cj4gdGhpcyBpcyB0aGUgbGF0ZXN0KS4gSG93ZXZlciwgdGhpcyBvdWdodCB0byBiZSBleHBsYWlu
ZWQgaW4gdGhlIGNvbW1pdA0KPiBtZXNzYWdlLiINCg0KT2suSSB3aWxsIGFkZCB0aGF0IGluZm9y
bWF0aW9uIGluIGNvbW1pdCBtc2cuDQo+DQo+PiBAQCAtODIsNiArODMsNyBAQCBDSEVDS19waHlz
ZGV2X3BjaV9kZXZpY2UNCj4+IHR5cGVkZWYgaW50IHJldF90Ow0KPj4NCj4+ICNpbmNsdWRlICIu
Li9waHlzZGV2LmMiDQo+PiArI2luY2x1ZGUgIi4uLy4uLy4uL2NvbW1vbi9waHlzZGV2LmMiDQo+
DQo+IFBsZWFzZSBkb24ndCB1bmxlc3MgZW50aXJlbHkgdW5hdm9pZGFibGU6IGNvbW1vbi8gaGFz
IGl0cyBvd24NCj4gY29tbW9uL2NvbXBhdC8uDQo+DQo+PiAtLS0gL2Rldi9udWxsDQo+PiArKysg
Yi94ZW4vY29tbW9uL3BoeXNkZXYuYw0KPj4gQEAgLTAsMCArMSw4MSBAQA0KPj4gKw0KPj4gKyNp
bmNsdWRlIDx4ZW4vZ3Vlc3RfYWNjZXNzLmg+DQo+PiArI2luY2x1ZGUgPHhlbi9oeXBlcmNhbGwu
aD4NCj4+ICsjaW5jbHVkZSA8eGVuL2luaXQuaD4NCj4+ICsNCj4+ICsjaWZuZGVmIENPTVBBVA0K
Pj4gK3R5cGVkZWYgbG9uZyByZXRfdDsNCj4+ICsjZW5kaWYNCj4+ICsNCj4+ICtyZXRfdCBkb19w
aHlzZGV2X29wKGludCBjbWQsIFhFTl9HVUVTVF9IQU5ETEVfUEFSQU0odm9pZCkgYXJnKQ0KPj4g
K3sNCj4+ICsgICAgcmV0X3QgcmV0Ow0KPj4gKw0KPj4gKyAgICBzd2l0Y2ggKCBjbWQgKQ0KPj4g
KyAgICB7DQo+PiArI2lmZGVmIENPTkZJR19IQVNfUENJDQo+DQo+IEFsbCBvZiB0aGUgZW5jbG9z
ZWQgY29kZSBzaG91bGQgcmVhbGx5IGJlIHVuZGVyIGRyaXZlcnMvcGNpLyBvciBpbg0KPiBkcml2
ZXJzL3Bhc3N0aHJvdWdoL3BjaS5jLCBlLmcuIGluIGEgcGNpX3BoeXNkZXZfb3AoKSBmdW5jdGlv
bg0KPiBjYWxsZWQgZnJvbSBib3RoIEFybSBhbmQgeDg2LiBVbmxlc3MsIEkgd2lsbCBhZG1pdCwg
dGhpcyB3b3VsZCBwb3NlDQo+IHVuZHVlIHByb2JsZW1zIGZvciB4ODYnZXMgY29tcGF0IGhhbmRs
aW5nLiBCdXQgSSdkIGxpa2UgdG8ga25vdw0KPiB3aGV0aGVyIHRoYXQgcm91dGUgd2FzIGF0IGxl
YXN0IGV4cGxvcmVkLiAoSS5lLiBJJ20gYWZyYWlkIEp1bGllbidzDQo+IHJlcXVlc3QgdG8gbW92
ZSB0aGlzIGNvZGUgdG8gImNvbW1vbiIgd2FzIHVuZGVyc3Rvb2QgdG9vIG11Y2ggdG8gdGhlDQo+
IHdvcmQsIHNvcnJ5LikNCg0KSSB0cmllZCB0byBtb3ZlIHRoZSBjb2RlIHRvIGRyaXZlci9wY2kv
IGFuZCBJIGFsc28gZmVlbCBpdCBpcyBiZXR0ZXIgdGhhbiBtb3ZpbmcgY29kZSB0byBjb21tb24v
cGh5c2Rldi5jDQpJIGF0dGFjaGVkIHRoZSBwYXRjaCBmb3IgZWFybHkgZmVlZGJhY2sgcGxlYXNl
IGhhdmUgYSBsb29rIG9uY2UuDQoNCg0KPg0KPj4gKyAgICBjYXNlIFBIWVNERVZPUF9wY2lfZGV2
aWNlX2FkZDogew0KPj4gKyAgICAgICAgc3RydWN0IHBoeXNkZXZfcGNpX2RldmljZV9hZGQgYWRk
Ow0KPj4gKyAgICAgICAgc3RydWN0IHBjaV9kZXZfaW5mbyBwZGV2X2luZm87DQo+PiArICAgICAg
ICBub2RlaWRfdCBub2RlOw0KPj4gKw0KPj4gKyAgICAgICAgcmV0ID0gLUVGQVVMVDsNCj4+ICsg
ICAgICAgIGlmICggY29weV9mcm9tX2d1ZXN0KCZhZGQsIGFyZywgMSkgIT0gMCApDQo+PiArICAg
ICAgICAgICAgYnJlYWs7DQo+PiArDQo+PiArICAgICAgICBwZGV2X2luZm8uaXNfZXh0Zm4gPSAh
IShhZGQuZmxhZ3MgJiBYRU5fUENJX0RFVl9FWFRGTik7DQo+DQo+IFdoaWxlIEknbSBub3QgZ29p
bmcgdG8gaW5zaXN0IChhcyB5b3UncmUgbWVyZWx5IG1vdmluZyB0aGlzIGNvZGUpLCBpdA0KPiB3
b3VsZCBiZSBuaWNlIGlmIHRoZSAhISgpIHdhcyBkcm9wcGVkIGhlcmUsIC4uLg0KDQpBY2suDQo+
DQo+PiArICAgICAgICBpZiAoIGFkZC5mbGFncyAmIFhFTl9QQ0lfREVWX1ZJUlRGTiApDQo+PiAr
ICAgICAgICB7DQo+PiArICAgICAgICAgICAgcGRldl9pbmZvLmlzX3ZpcnRmbiA9IDE7DQo+DQo+
IC4uLiAidHJ1ZSIgd2FzIHVzZWQgaGVyZSwgYW5kIC4uLg0KDQpBY2suDQo+DQo+PiArICAgICAg
ICAgICAgcGRldl9pbmZvLnBoeXNmbi5idXMgPSBhZGQucGh5c2ZuLmJ1czsNCj4+ICsgICAgICAg
ICAgICBwZGV2X2luZm8ucGh5c2ZuLmRldmZuID0gYWRkLnBoeXNmbi5kZXZmbjsNCj4+ICsgICAg
ICAgIH0NCj4+ICsgICAgICAgIGVsc2UNCj4+ICsgICAgICAgICAgICBwZGV2X2luZm8uaXNfdmly
dGZuID0gMDsNCj4NCj4gLi4uICJmYWxzZSIgaGVyZSB3aGlsZSBtb3ZpbmcsIGFzIGJvdGggZmll
bGRzIGFyZSBib29sLg0KQWNrLg0KPg0KPj4gKyAgICAgICAgaWYgKCBhZGQuZmxhZ3MgJiBYRU5f
UENJX0RFVl9QWE0gKQ0KPj4gKyAgICAgICAgew0KPj4gKyAgICAgICAgICAgIHVpbnQzMl90IHB4
bTsNCj4+ICsgICAgICAgICAgICBzaXplX3Qgb3B0YXJyX29mZiA9IG9mZnNldG9mKHN0cnVjdCBw
aHlzZGV2X3BjaV9kZXZpY2VfYWRkLCBvcHRhcnIpIC8NCj4+ICsgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgIHNpemVvZihhZGQub3B0YXJyWzBdKTsNCj4+ICsNCj4+ICsgICAgICAgICAg
ICBpZiAoIGNvcHlfZnJvbV9ndWVzdF9vZmZzZXQoJnB4bSwgYXJnLCBvcHRhcnJfb2ZmLCAxKSAp
DQo+PiArICAgICAgICAgICAgICAgIGJyZWFrOw0KPj4gKw0KPj4gKyAgICAgICAgICAgIG5vZGUg
PSBweG1fdG9fbm9kZShweG0pOw0KPj4gKyAgICAgICAgfQ0KPj4gKyAgICAgICAgZWxzZQ0KPg0K
PiBJIHRoaW5rIHRoaXMgY29kZSBzaG91bGQgYmVjb21lIENPTkZJR19OVU1BIGRlcGVuZGVudCwg
bm93IHRoYXQgaXQNCj4gZ2V0cyBtb3ZlZCB0byBjb21tb24gY29kZS4gVGhpcyB3b3VsZCBzYXZl
IHlvdSBmcm9tIChvZGRseTsgc2VlDQo+IGJlbG93KSBpbXBsZW1lbnRpbmcgcHhtX3RvX25vZGUo
KSBvbiBBcm0uDQoNCk9rLg0KPg0KPj4gKyAgICAgICAgICAgIG5vZGUgPSBOVU1BX05PX05PREU7
DQo+PiArDQo+PiArICAgICAgICByZXQgPSBwY2lfYWRkX2RldmljZShhZGQuc2VnLCBhZGQuYnVz
LCBhZGQuZGV2Zm4sICZwZGV2X2luZm8sIG5vZGUpOw0KPj4gKyAgICAgICAgYnJlYWs7DQo+PiAr
ICAgIH0NCj4+ICsNCj4+ICsgICAgY2FzZSBQSFlTREVWT1BfcGNpX2RldmljZV9yZW1vdmU6IHsN
Cj4+ICsgICAgICAgIHN0cnVjdCBwaHlzZGV2X3BjaV9kZXZpY2UgZGV2Ow0KPj4gKw0KPj4gKyAg
ICAgICAgcmV0ID0gLUVGQVVMVDsNCj4+ICsgICAgICAgIGlmICggY29weV9mcm9tX2d1ZXN0KCZk
ZXYsIGFyZywgMSkgIT0gMCApDQo+PiArICAgICAgICAgICAgYnJlYWs7DQo+PiArDQo+PiArICAg
ICAgICByZXQgPSBwY2lfcmVtb3ZlX2RldmljZShkZXYuc2VnLCBkZXYuYnVzLCBkZXYuZGV2Zm4p
Ow0KPj4gKyAgICAgICAgYnJlYWs7DQo+PiArICAgIH0NCj4+ICsjZW5kaWYNCj4+ICsgICAgZGVm
YXVsdDoNCj4NCj4gQmxhbmsgbGluZSBiZXR3ZWVuIG5vbi1mYWxsLXRocm91Z2ggY2FzZSBibG9j
a3MgcGxlYXNlLg0KQWNrLg0KPg0KPj4gLS0tIGEveGVuL2luY2x1ZGUvYXNtLWFybS9udW1hLmgN
Cj4+ICsrKyBiL3hlbi9pbmNsdWRlL2FzbS1hcm0vbnVtYS5oDQo+PiBAQCAtMjUsNiArMjUsMTEg
QEAgZXh0ZXJuIG1mbl90IGZpcnN0X3ZhbGlkX21mbjsNCj4+ICNkZWZpbmUgbm9kZV9zdGFydF9w
Zm4obmlkKSAobWZuX3goZmlyc3RfdmFsaWRfbWZuKSkNCj4+ICNkZWZpbmUgX19ub2RlX2Rpc3Rh
bmNlKGEsIGIpICgyMCkNCj4+DQo+PiArc3RhdGljIGlubGluZSBub2RlaWRfdCBweG1fdG9fbm9k
ZSh1bnNpZ25lZCBweG0pDQo+PiArew0KPj4gKyAgICByZXR1cm4gMHhmZjsNCj4NCj4gSWYgeW91
IGNhbiB1c2UgTlVNQV9OT19OT0RFIGluIGRvX3BoeXNkZXZfb3AoKSwgd2h5IG5vdCBhbHNvIGhl
cmU/DQo+IChBc3N1bWluZyB0aGlzIGZ1bmN0aW9uIGlzIGdvaW5nIHRvIHN1cnZpdmUgaW4gdGhp
cyBzZXJpZXMgaW4gdGhlDQo+IGZpcnN0IHBsYWNlLCBhcyBwZXIgdGhlIGVhcmxpZXIgY29tbWVu
dC4pDQoNCk5VTUFfTk9fTk9ERSBpcyBkZWZpbmVkIGluICAieGVuL251bWEuaOKAnSBidXQgImFz
bS9udW1hLmgiIGlzIGluY2x1ZGUgaW4gInhlbi9udW1hLmjigJ0NCmJlZm9yZSBkZWZpbmluZyBO
VU1BX05PX05PREUuDQoNCkkgd2lsbCBmaXggdGhpcyBsaWtlIHdlIGZpeCBmb3IgcGNpLiAgTW92
ZSB0aGUgImFzbS9udW1hLmgiIGluICJ4ZW4vbnVtYS5oIiAgYWZ0ZXIgZGVmaW5pbmcgTlVNQV9O
T19OT0RFDQoNCg0KUmVnYXJkcywNClJhaHVsDQo+IEphbg0KPg0KDQo=

--_000_7FE915FF574348E5B50E9F5688344C45armcom_
Content-Type: text/html; charset="utf-8"
Content-ID: <20B481E885623E4DAD9427834B647567@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64

PGh0bWw+DQo8aGVhZD4NCjxtZXRhIGh0dHAtZXF1aXY9IkNvbnRlbnQtVHlwZSIgY29udGVudD0i
dGV4dC9odG1sOyBjaGFyc2V0PXV0Zi04Ij4NCjwvaGVhZD4NCjxib2R5Pg0KPGRpdiBjbGFzcz0i
Qm9keUZyYWdtZW50Ij48Zm9udCBzaXplPSIyIj48c3BhbiBzdHlsZT0iZm9udC1zaXplOjExcHQ7
Ij4NCjxkaXYgY2xhc3M9IlBsYWluVGV4dCI+SGkgSmFuLDxicj4NCjxicj4NCiZndDsgT24gMzAg
U2VwIDIwMjEsIGF0IDM6NTEgcG0sIEphbiBCZXVsaWNoICZsdDtqYmV1bGljaEBzdXNlLmNvbSZn
dDsgd3JvdGU6PGJyPg0KJmd0OyA8YnI+DQomZ3Q7IE9uIDI4LjA5LjIwMjEgMjA6MTgsIFJhaHVs
IFNpbmdoIHdyb3RlOjxicj4NCiZndDsmZ3Q7IEhhcmR3YXJlIGRvbWFpbiBpcyBpbiBjaGFyZ2Ug
b2YgZG9pbmcgdGhlIFBDSSBlbnVtZXJhdGlvbiBhbmQgd2lsbDxicj4NCiZndDsmZ3Q7IGRpc2Nv
dmVyIHRoZSBQQ0kgZGV2aWNlcyBhbmQgdGhlbiB3aWxsIGNvbW11bmljYXRlIHRvIFhFTiB2aWEg
aHlwZXI8YnI+DQomZ3Q7Jmd0OyBjYWxsIFBIWVNERVZPUF9wY2lfZGV2aWNlX2FkZCguLikgdG8g
YWRkIHRoZSBQQ0kgZGV2aWNlcyBpbiBYRU4uPGJyPg0KJmd0OyZndDsgPGJyPg0KJmd0OyZndDsg
QWxzbyBpbXBsZW1lbnQgUEhZU0RFVk9QX3BjaV9kZXZpY2VfcmVtb3ZlKC4uKSB0byByZW1vdmUg
dGhlIFBDSSBkZXZpY2UuPGJyPg0KJmd0OyZndDsgPGJyPg0KJmd0OyZndDsgQXMgbW9zdCBvZiB0
aGUgY29kZSBmb3IgUEhZU0RFVk9QX3BjaV9kZXZpY2VfKiBpcyB0aGUgc2FtZSBiZXR3ZWVuIHg4
Njxicj4NCiZndDsmZ3Q7IGFuZCBBUk0sIG1vdmUgdGhlIGNvZGUgdG8gYSBjb21tb24gZmlsZSB0
byBhdm9pZCBkdXBsaWNhdGlvbi48YnI+DQomZ3Q7Jmd0OyA8YnI+DQomZ3Q7Jmd0OyBTaWduZWQt
b2ZmLWJ5OiBSYWh1bCBTaW5naCAmbHQ7cmFodWwuc2luZ2hAYXJtLmNvbSZndDs8YnI+DQomZ3Q7
IDxicj4NCiZndDsgT24gdjEgSnVsaWVuIHNhaWQ6PGJyPg0KJmd0OyA8YnI+DQomZ3Q7ICZxdW90
O1RoZXJlIGFyZSBvdGhlciBQSFlTREVWT1Agb3BlcmF0aW9ucyB0byBhZGQgUENJIGRldmljZXMu
IEkgdGhpbmsgaXQgaXMgPGJyPg0KJmd0OyBmaW5lIHRvIG9ubHkgaW1wbGVtZW50IHRoZSBsYXRl
c3QgKENDIEphbiBmb3Igc29tZSBvcGluaW9uIGFuZCBjb25maXJtIDxicj4NCiZndDsgdGhpcyBp
cyB0aGUgbGF0ZXN0KS4gSG93ZXZlciwgdGhpcyBvdWdodCB0byBiZSBleHBsYWluZWQgaW4gdGhl
IGNvbW1pdCA8YnI+DQomZ3Q7IG1lc3NhZ2UuJnF1b3Q7PGJyPg0KPGJyPg0KT2suSSB3aWxsIGFk
ZCB0aGF0IGluZm9ybWF0aW9uIGluIGNvbW1pdCBtc2cuPGJyPg0KJmd0OyA8YnI+DQomZ3Q7Jmd0
OyBAQCAtODIsNiArODMsNyBAQCBDSEVDS19waHlzZGV2X3BjaV9kZXZpY2U8YnI+DQomZ3Q7Jmd0
OyB0eXBlZGVmIGludCByZXRfdDs8YnI+DQomZ3Q7Jmd0OyA8YnI+DQomZ3Q7Jmd0OyAjaW5jbHVk
ZSAmcXVvdDsuLi9waHlzZGV2LmMmcXVvdDs8YnI+DQomZ3Q7Jmd0OyArI2luY2x1ZGUgJnF1b3Q7
Li4vLi4vLi4vY29tbW9uL3BoeXNkZXYuYyZxdW90Ozxicj4NCiZndDsgPGJyPg0KJmd0OyBQbGVh
c2UgZG9uJ3QgdW5sZXNzIGVudGlyZWx5IHVuYXZvaWRhYmxlOiBjb21tb24vIGhhcyBpdHMgb3du
PGJyPg0KJmd0OyBjb21tb24vY29tcGF0Ly48YnI+DQomZ3Q7IDxicj4NCiZndDsmZ3Q7IC0tLSAv
ZGV2L251bGw8YnI+DQomZ3Q7Jmd0OyArKysgYi94ZW4vY29tbW9uL3BoeXNkZXYuYzxicj4NCiZn
dDsmZ3Q7IEBAIC0wLDAgKzEsODEgQEA8YnI+DQomZ3Q7Jmd0OyArPGJyPg0KJmd0OyZndDsgKyNp
bmNsdWRlICZsdDt4ZW4vZ3Vlc3RfYWNjZXNzLmgmZ3Q7PGJyPg0KJmd0OyZndDsgKyNpbmNsdWRl
ICZsdDt4ZW4vaHlwZXJjYWxsLmgmZ3Q7PGJyPg0KJmd0OyZndDsgKyNpbmNsdWRlICZsdDt4ZW4v
aW5pdC5oJmd0Ozxicj4NCiZndDsmZ3Q7ICs8YnI+DQomZ3Q7Jmd0OyArI2lmbmRlZiBDT01QQVQ8
YnI+DQomZ3Q7Jmd0OyArdHlwZWRlZiBsb25nIHJldF90Ozxicj4NCiZndDsmZ3Q7ICsjZW5kaWY8
YnI+DQomZ3Q7Jmd0OyArPGJyPg0KJmd0OyZndDsgK3JldF90IGRvX3BoeXNkZXZfb3AoaW50IGNt
ZCwgWEVOX0dVRVNUX0hBTkRMRV9QQVJBTSh2b2lkKSBhcmcpPGJyPg0KJmd0OyZndDsgK3s8YnI+
DQomZ3Q7Jmd0OyArJm5ic3A7Jm5ic3A7Jm5ic3A7IHJldF90IHJldDs8YnI+DQomZ3Q7Jmd0OyAr
PGJyPg0KJmd0OyZndDsgKyZuYnNwOyZuYnNwOyZuYnNwOyBzd2l0Y2ggKCBjbWQgKTxicj4NCiZn
dDsmZ3Q7ICsmbmJzcDsmbmJzcDsmbmJzcDsgezxicj4NCiZndDsmZ3Q7ICsjaWZkZWYgQ09ORklH
X0hBU19QQ0k8YnI+DQomZ3Q7IDxicj4NCiZndDsgQWxsIG9mIHRoZSBlbmNsb3NlZCBjb2RlIHNo
b3VsZCByZWFsbHkgYmUgdW5kZXIgZHJpdmVycy9wY2kvIG9yIGluPGJyPg0KJmd0OyBkcml2ZXJz
L3Bhc3N0aHJvdWdoL3BjaS5jLCBlLmcuIGluIGEgcGNpX3BoeXNkZXZfb3AoKSBmdW5jdGlvbjxi
cj4NCiZndDsgY2FsbGVkIGZyb20gYm90aCBBcm0gYW5kIHg4Ni4gVW5sZXNzLCBJIHdpbGwgYWRt
aXQsIHRoaXMgd291bGQgcG9zZTxicj4NCiZndDsgdW5kdWUgcHJvYmxlbXMgZm9yIHg4NidlcyBj
b21wYXQgaGFuZGxpbmcuIEJ1dCBJJ2QgbGlrZSB0byBrbm93PGJyPg0KJmd0OyB3aGV0aGVyIHRo
YXQgcm91dGUgd2FzIGF0IGxlYXN0IGV4cGxvcmVkLiAoSS5lLiBJJ20gYWZyYWlkIEp1bGllbidz
PGJyPg0KJmd0OyByZXF1ZXN0IHRvIG1vdmUgdGhpcyBjb2RlIHRvICZxdW90O2NvbW1vbiZxdW90
OyB3YXMgdW5kZXJzdG9vZCB0b28gbXVjaCB0byB0aGU8YnI+DQomZ3Q7IHdvcmQsIHNvcnJ5Lik8
YnI+DQo8YnI+DQpJIHRyaWVkIHRvIG1vdmUgdGhlIGNvZGUgdG8gZHJpdmVyL3BjaS8gYW5kIEkg
YWxzbyBmZWVsIGl0IGlzIGJldHRlciB0aGFuIG1vdmluZyBjb2RlIHRvIGNvbW1vbi9waHlzZGV2
LmM8YnI+DQpJIGF0dGFjaGVkIHRoZSBwYXRjaCBmb3IgZWFybHkgZmVlZGJhY2sgcGxlYXNlIGhh
dmUgYSBsb29rIG9uY2UuPGJyPg0KPGJyPg0KPC9kaXY+DQo8L3NwYW4+PC9mb250PjwvZGl2Pg0K
PGRpdiBjbGFzcz0iQm9keUZyYWdtZW50Ij48Zm9udCBzaXplPSIyIj48c3BhbiBzdHlsZT0iZm9u
dC1zaXplOjExcHQ7Ij4NCjxkaXYgY2xhc3M9IlBsYWluVGV4dCI+PGJyPg0KJmd0OyA8YnI+DQom
Z3Q7Jmd0OyArJm5ic3A7Jm5ic3A7Jm5ic3A7IGNhc2UgUEhZU0RFVk9QX3BjaV9kZXZpY2VfYWRk
OiB7PGJyPg0KJmd0OyZndDsgKyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZu
YnNwOyBzdHJ1Y3QgcGh5c2Rldl9wY2lfZGV2aWNlX2FkZCBhZGQ7PGJyPg0KJmd0OyZndDsgKyZu
YnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyBzdHJ1Y3QgcGNpX2Rldl9p
bmZvIHBkZXZfaW5mbzs8YnI+DQomZ3Q7Jmd0OyArJm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5i
c3A7Jm5ic3A7Jm5ic3A7IG5vZGVpZF90IG5vZGU7PGJyPg0KJmd0OyZndDsgKzxicj4NCiZndDsm
Z3Q7ICsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsgcmV0ID0gLUVG
QVVMVDs8YnI+DQomZ3Q7Jmd0OyArJm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7
Jm5ic3A7IGlmICggY29weV9mcm9tX2d1ZXN0KCZhbXA7YWRkLCBhcmcsIDEpICE9IDAgKTxicj4N
CiZndDsmZ3Q7ICsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJz
cDsmbmJzcDsmbmJzcDsmbmJzcDsgYnJlYWs7PGJyPg0KJmd0OyZndDsgKzxicj4NCiZndDsmZ3Q7
ICsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsgcGRldl9pbmZvLmlz
X2V4dGZuID0gISEoYWRkLmZsYWdzICZhbXA7IFhFTl9QQ0lfREVWX0VYVEZOKTs8YnI+DQomZ3Q7
IDxicj4NCiZndDsgV2hpbGUgSSdtIG5vdCBnb2luZyB0byBpbnNpc3QgKGFzIHlvdSdyZSBtZXJl
bHkgbW92aW5nIHRoaXMgY29kZSksIGl0PGJyPg0KJmd0OyB3b3VsZCBiZSBuaWNlIGlmIHRoZSAh
ISgpIHdhcyBkcm9wcGVkIGhlcmUsIC4uLjxicj4NCjxicj4NCkFjay48YnI+DQomZ3Q7IDxicj4N
CiZndDsmZ3Q7ICsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsgaWYg
KCBhZGQuZmxhZ3MgJmFtcDsgWEVOX1BDSV9ERVZfVklSVEZOICk8YnI+DQomZ3Q7Jmd0OyArJm5i
c3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7IHs8YnI+DQomZ3Q7Jmd0OyAr
Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5i
c3A7Jm5ic3A7IHBkZXZfaW5mby5pc192aXJ0Zm4gPSAxOzxicj4NCiZndDsgPGJyPg0KJmd0OyAu
Li4gJnF1b3Q7dHJ1ZSZxdW90OyB3YXMgdXNlZCBoZXJlLCBhbmQgLi4uPGJyPg0KPGJyPg0KQWNr
Ljxicj4NCiZndDsgPGJyPg0KJmd0OyZndDsgKyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNw
OyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyBwZGV2X2luZm8ucGh5c2ZuLmJ1
cyA9IGFkZC5waHlzZm4uYnVzOzxicj4NCiZndDsmZ3Q7ICsmbmJzcDsmbmJzcDsmbmJzcDsmbmJz
cDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsgcGRldl9pbmZvLnBo
eXNmbi5kZXZmbiA9IGFkZC5waHlzZm4uZGV2Zm47PGJyPg0KJmd0OyZndDsgKyZuYnNwOyZuYnNw
OyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyB9PGJyPg0KJmd0OyZndDsgKyZuYnNwOyZu
YnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyBlbHNlPGJyPg0KJmd0OyZndDsgKyZu
YnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNw
OyZuYnNwOyBwZGV2X2luZm8uaXNfdmlydGZuID0gMDs8YnI+DQomZ3Q7IDxicj4NCiZndDsgLi4u
ICZxdW90O2ZhbHNlJnF1b3Q7IGhlcmUgd2hpbGUgbW92aW5nLCBhcyBib3RoIGZpZWxkcyBhcmUg
Ym9vbC48YnI+DQpBY2suPGJyPg0KJmd0OyA8YnI+DQomZ3Q7Jmd0OyArJm5ic3A7Jm5ic3A7Jm5i
c3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7IGlmICggYWRkLmZsYWdzICZhbXA7IFhFTl9QQ0lf
REVWX1BYTSApPGJyPg0KJmd0OyZndDsgKyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZu
YnNwOyZuYnNwOyB7PGJyPg0KJmd0OyZndDsgKyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNw
OyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyB1aW50MzJfdCBweG07PGJyPg0K
Jmd0OyZndDsgKyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNw
OyZuYnNwOyZuYnNwOyZuYnNwOyBzaXplX3Qgb3B0YXJyX29mZiA9IG9mZnNldG9mKHN0cnVjdCBw
aHlzZGV2X3BjaV9kZXZpY2VfYWRkLCBvcHRhcnIpIC88YnI+DQomZ3Q7Jmd0OyArJm5ic3A7Jm5i
c3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7
Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5i
c3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7
Jm5ic3A7IHNpemVvZihhZGQub3B0YXJyWzBdKTs8YnI+DQomZ3Q7Jmd0OyArPGJyPg0KJmd0OyZn
dDsgKyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNw
OyZuYnNwOyZuYnNwOyBpZiAoIGNvcHlfZnJvbV9ndWVzdF9vZmZzZXQoJmFtcDtweG0sIGFyZywg
b3B0YXJyX29mZiwgMSkgKTxicj4NCiZndDsmZ3Q7ICsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsm
bmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJz
cDsmbmJzcDsgYnJlYWs7PGJyPg0KJmd0OyZndDsgKzxicj4NCiZndDsmZ3Q7ICsmbmJzcDsmbmJz
cDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsg
bm9kZSA9IHB4bV90b19ub2RlKHB4bSk7PGJyPg0KJmd0OyZndDsgKyZuYnNwOyZuYnNwOyZuYnNw
OyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyB9PGJyPg0KJmd0OyZndDsgKyZuYnNwOyZuYnNwOyZu
YnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyBlbHNlPGJyPg0KJmd0OyA8YnI+DQomZ3Q7IEkg
dGhpbmsgdGhpcyBjb2RlIHNob3VsZCBiZWNvbWUgQ09ORklHX05VTUEgZGVwZW5kZW50LCBub3cg
dGhhdCBpdDxicj4NCiZndDsgZ2V0cyBtb3ZlZCB0byBjb21tb24gY29kZS4gVGhpcyB3b3VsZCBz
YXZlIHlvdSBmcm9tIChvZGRseTsgc2VlPGJyPg0KJmd0OyBiZWxvdykgaW1wbGVtZW50aW5nIHB4
bV90b19ub2RlKCkgb24gQXJtLjxicj4NCjxicj4NCk9rLjxicj4NCiZndDsgPGJyPg0KJmd0OyZn
dDsgKyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNw
OyZuYnNwOyZuYnNwOyBub2RlID0gTlVNQV9OT19OT0RFOzxicj4NCiZndDsmZ3Q7ICs8YnI+DQom
Z3Q7Jmd0OyArJm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7IHJldCA9
IHBjaV9hZGRfZGV2aWNlKGFkZC5zZWcsIGFkZC5idXMsIGFkZC5kZXZmbiwgJmFtcDtwZGV2X2lu
Zm8sIG5vZGUpOzxicj4NCiZndDsmZ3Q7ICsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsm
bmJzcDsmbmJzcDsgYnJlYWs7PGJyPg0KJmd0OyZndDsgKyZuYnNwOyZuYnNwOyZuYnNwOyB9PGJy
Pg0KJmd0OyZndDsgKzxicj4NCiZndDsmZ3Q7ICsmbmJzcDsmbmJzcDsmbmJzcDsgY2FzZSBQSFlT
REVWT1BfcGNpX2RldmljZV9yZW1vdmU6IHs8YnI+DQomZ3Q7Jmd0OyArJm5ic3A7Jm5ic3A7Jm5i
c3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7IHN0cnVjdCBwaHlzZGV2X3BjaV9kZXZpY2UgZGV2
Ozxicj4NCiZndDsmZ3Q7ICs8YnI+DQomZ3Q7Jmd0OyArJm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7
Jm5ic3A7Jm5ic3A7Jm5ic3A7IHJldCA9IC1FRkFVTFQ7PGJyPg0KJmd0OyZndDsgKyZuYnNwOyZu
YnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyBpZiAoIGNvcHlfZnJvbV9ndWVzdCgm
YW1wO2RldiwgYXJnLCAxKSAhPSAwICk8YnI+DQomZ3Q7Jmd0OyArJm5ic3A7Jm5ic3A7Jm5ic3A7
Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7IGJyZWFrOzxi
cj4NCiZndDsmZ3Q7ICs8YnI+DQomZ3Q7Jmd0OyArJm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5i
c3A7Jm5ic3A7Jm5ic3A7IHJldCA9IHBjaV9yZW1vdmVfZGV2aWNlKGRldi5zZWcsIGRldi5idXMs
IGRldi5kZXZmbik7PGJyPg0KJmd0OyZndDsgKyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNw
OyZuYnNwOyZuYnNwOyBicmVhazs8YnI+DQomZ3Q7Jmd0OyArJm5ic3A7Jm5ic3A7Jm5ic3A7IH08
YnI+DQomZ3Q7Jmd0OyArI2VuZGlmPGJyPg0KJmd0OyZndDsgKyZuYnNwOyZuYnNwOyZuYnNwOyBk
ZWZhdWx0Ojxicj4NCiZndDsgPGJyPg0KJmd0OyBCbGFuayBsaW5lIGJldHdlZW4gbm9uLWZhbGwt
dGhyb3VnaCBjYXNlIGJsb2NrcyBwbGVhc2UuPGJyPg0KQWNrLjxicj4NCiZndDsgPGJyPg0KJmd0
OyZndDsgLS0tIGEveGVuL2luY2x1ZGUvYXNtLWFybS9udW1hLmg8YnI+DQomZ3Q7Jmd0OyArKysg
Yi94ZW4vaW5jbHVkZS9hc20tYXJtL251bWEuaDxicj4NCiZndDsmZ3Q7IEBAIC0yNSw2ICsyNSwx
MSBAQCBleHRlcm4gbWZuX3QgZmlyc3RfdmFsaWRfbWZuOzxicj4NCiZndDsmZ3Q7ICNkZWZpbmUg
bm9kZV9zdGFydF9wZm4obmlkKSAobWZuX3goZmlyc3RfdmFsaWRfbWZuKSk8YnI+DQomZ3Q7Jmd0
OyAjZGVmaW5lIF9fbm9kZV9kaXN0YW5jZShhLCBiKSAoMjApPGJyPg0KJmd0OyZndDsgPGJyPg0K
Jmd0OyZndDsgK3N0YXRpYyBpbmxpbmUgbm9kZWlkX3QgcHhtX3RvX25vZGUodW5zaWduZWQgcHht
KTxicj4NCiZndDsmZ3Q7ICt7PGJyPg0KJmd0OyZndDsgKyZuYnNwOyZuYnNwOyZuYnNwOyByZXR1
cm4gMHhmZjs8YnI+DQomZ3Q7IDxicj4NCiZndDsgSWYgeW91IGNhbiB1c2UgTlVNQV9OT19OT0RF
IGluIGRvX3BoeXNkZXZfb3AoKSwgd2h5IG5vdCBhbHNvIGhlcmU/PGJyPg0KJmd0OyAoQXNzdW1p
bmcgdGhpcyBmdW5jdGlvbiBpcyBnb2luZyB0byBzdXJ2aXZlIGluIHRoaXMgc2VyaWVzIGluIHRo
ZTxicj4NCiZndDsgZmlyc3QgcGxhY2UsIGFzIHBlciB0aGUgZWFybGllciBjb21tZW50Lik8YnI+
DQo8YnI+DQpOVU1BX05PX05PREUgaXMgZGVmaW5lZCBpbiZuYnNwOyAmcXVvdDt4ZW4vbnVtYS5o
4oCdIGJ1dCAmcXVvdDthc20vbnVtYS5oJnF1b3Q7IGlzIGluY2x1ZGUgaW4gJnF1b3Q7eGVuL251
bWEuaOKAnTxicj4NCmJlZm9yZSBkZWZpbmluZyBOVU1BX05PX05PREUuPGJyPg0KPGJyPg0KSSB3
aWxsIGZpeCB0aGlzIGxpa2Ugd2UgZml4IGZvciBwY2kuJm5ic3A7IE1vdmUgdGhlICZxdW90O2Fz
bS9udW1hLmgmcXVvdDsgaW4gJnF1b3Q7eGVuL251bWEuaCZxdW90OyZuYnNwOyBhZnRlciBkZWZp
bmluZyBOVU1BX05PX05PREU8YnI+DQo8YnI+DQo8YnI+DQpSZWdhcmRzLDxicj4NClJhaHVsPGJy
Pg0KJmd0OyBKYW48YnI+DQomZ3Q7IDxicj4NCjxicj4NCjwvZGl2Pg0KPC9zcGFuPjwvZm9udD48
L2Rpdj4NCjwvYm9keT4NCjwvaHRtbD4NCg==

--_000_7FE915FF574348E5B50E9F5688344C45armcom_--

--_004_7FE915FF574348E5B50E9F5688344C45armcom_
Content-Type: application/octet-stream;
	name="0001-xen-arm-Add-PHYSDEVOP_pci_device_-add-remove-support.patch"
Content-Description:
 0001-xen-arm-Add-PHYSDEVOP_pci_device_-add-remove-support.patch
Content-Disposition: attachment;
	filename="0001-xen-arm-Add-PHYSDEVOP_pci_device_-add-remove-support.patch";
	size=7741; creation-date="Fri, 01 Oct 2021 16:19:46 GMT";
	modification-date="Fri, 01 Oct 2021 16:19:46 GMT"
Content-ID: <2493E6BFE9CB3143BF4B56CDF64DEF00@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64

RnJvbSA3YTcyM2FlYmZkYTdjZGIyNjdhMzY4MzQ0N2E2MzgzOTUwODY4ZDExIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpNZXNzYWdlLUlkOiA8N2E3MjNhZWJmZGE3Y2RiMjY3YTM2ODM0NDdhNjM4
Mzk1MDg2OGQxMS4xNjMzMTA1MDYxLmdpdC5yYWh1bC5zaW5naEBhcm0uY29tPgpGcm9tOiBSYWh1
bCBTaW5naCA8cmFodWwuc2luZ2hAYXJtLmNvbT4KRGF0ZTogVHVlLCAyNyBKdWwgMjAyMSAxODo0
ODo0NiArMDEwMApTdWJqZWN0OiBbUEFUQ0hdIHhlbi9hcm06IEFkZCBQSFlTREVWT1BfcGNpX2Rl
dmljZV8oKmFkZC9yZW1vdmUpIHN1cHBvcnQgZm9yCiBBUk0KCkhhcmR3YXJlIGRvbWFpbiBpcyBp
biBjaGFyZ2Ugb2YgZG9pbmcgdGhlIFBDSSBlbnVtZXJhdGlvbiBhbmQgd2lsbApkaXNjb3ZlciB0
aGUgUENJIGRldmljZXMgYW5kIHRoZW4gd2lsbCBjb21tdW5pY2F0ZSB0byBYRU4gdmlhIGh5cGVy
CmNhbGwgUEhZU0RFVk9QX3BjaV9kZXZpY2VfYWRkKC4uKSB0byBhZGQgdGhlIFBDSSBkZXZpY2Vz
IGluIFhFTi4KCkFsc28gaW1wbGVtZW50IFBIWVNERVZPUF9wY2lfZGV2aWNlX3JlbW92ZSguLikg
dG8gcmVtb3ZlIHRoZSBQQ0kgZGV2aWNlLgoKQXMgbW9zdCBvZiB0aGUgY29kZSBmb3IgUEhZU0RF
Vk9QX3BjaV9kZXZpY2VfKiBpcyB0aGUgc2FtZSBiZXR3ZWVuIHg4NgphbmQgQVJNLCBtb3ZlIHRo
ZSBjb2RlIHRvIGEgY29tbW9uIGZpbGUgdG8gYXZvaWQgZHVwbGljYXRpb24uCgpUaGVyZSBhcmUg
b3RoZXIgUEhZU0RFVk9QX3BjaV9kZXZpY2VfKiBvcGVyYXRpb25zIHRvIGFkZCBQQ0kgZGV2aWNl
cy4KQ3VycmVudGx5IGltcGxlbWVudGVkIFBIWVNERVZPUF9wY2lfZGV2aWNlX3JlbW92ZSguLikg
YW5kClBIWVNERVZPUF9wY2lfZGV2aWNlX2FkZCguLikgb25seSBhcyB0aG9zZSBhcmUgbWluaW11
bSByZXF1aXJlZCB0bwpzdXBwb3J0IFBDSSBwYXNzdGhyb3VnaCBvbiBBUk0uCgpJc3N1ZS1JRDog
U0NNLTMxNzEKU2lnbmVkLW9mZi1ieTogUmFodWwgU2luZ2ggPHJhaHVsLnNpbmdoQGFybS5jb20+
CkNoYW5nZS1JZDogSTM1OTljZWY4NGIwMmIxMzkzMzg3ZGJhZTQ1MWE5ZDkxZmM0NjAzNDMKLS0t
CkNoYW5nZSBpbiB2NDoKLSBNb3ZlIGZpbGUgY29tbW9tL3BoeXNkZXYuYyB0byBkcml2ZXJzL3Bj
aS9waHlzZGV2LmMKLSBtaW5vciBjb21tZW50cy4KQ2hhbmdlIGluIHYzOiBGaXhlZCBtaW5vciBj
b21tZW50LgpDaGFuZ2UgaW4gdjI6Ci0gQWRkIHN1cHBvcnQgZm9yIFBIWVNERVZPUF9wY2lfZGV2
aWNlX3JlbW92ZSgpCi0gTW92ZSBjb2RlIHRvIGNvbW1vbiBjb2RlCi0tLQotLS0KIHhlbi9hcmNo
L2FybS9waHlzZGV2LmMgICAgICAgIHwgIDUgKy0tCiB4ZW4vYXJjaC94ODYvcGh5c2Rldi5jICAg
ICAgICB8IDUyICstLS0tLS0tLS0tLS0tLS0tLS0tLS0tCiB4ZW4vYXJjaC94ODYveDg2XzY0L3Bo
eXNkZXYuYyB8ICAyICstCiB4ZW4vZHJpdmVycy9wY2kvTWFrZWZpbGUgICAgICB8ICAxICsKIHhl
bi9kcml2ZXJzL3BjaS9waHlzZGV2LmMgICAgIHwgODAgKysrKysrKysrKysrKysrKysrKysrKysr
KysrKysrKysrKysKIHhlbi9pbmNsdWRlL3hlbi9oeXBlcmNhbGwuaCAgIHwgMTEgKysrKysKIDYg
ZmlsZXMgY2hhbmdlZCwgOTcgaW5zZXJ0aW9ucygrKSwgNTQgZGVsZXRpb25zKC0pCiBjcmVhdGUg
bW9kZSAxMDA2NDQgeGVuL2RyaXZlcnMvcGNpL3BoeXNkZXYuYwoKZGlmZiAtLWdpdCBhL3hlbi9h
cmNoL2FybS9waHlzZGV2LmMgYi94ZW4vYXJjaC9hcm0vcGh5c2Rldi5jCmluZGV4IGU5MTM1NWZl
MjIuLmQ3NjY5Nzg2MjkgMTAwNjQ0Ci0tLSBhL3hlbi9hcmNoL2FybS9waHlzZGV2LmMKKysrIGIv
eGVuL2FyY2gvYXJtL3BoeXNkZXYuYwpAQCAtOCwxMyArOCwxMiBAQAogI2luY2x1ZGUgPHhlbi9s
aWIuaD4KICNpbmNsdWRlIDx4ZW4vZXJybm8uaD4KICNpbmNsdWRlIDx4ZW4vc2NoZWQuaD4KLSNp
bmNsdWRlIDxhc20vaHlwZXJjYWxsLmg+CisjaW5jbHVkZSA8eGVuL2h5cGVyY2FsbC5oPgogCiAK
IGludCBkb19waHlzZGV2X29wKGludCBjbWQsIFhFTl9HVUVTVF9IQU5ETEVfUEFSQU0odm9pZCkg
YXJnKQogewotICAgIGdkcHJpbnRrKFhFTkxPR19ERUJVRywgIlBIWVNERVZPUCBjbWQ9JWQ6IG5v
dCBpbXBsZW1lbnRlZFxuIiwgY21kKTsKLSAgICByZXR1cm4gLUVOT1NZUzsKKyAgICByZXR1cm4g
cGNpX3BoeXNkZXZfb3AoY21kLCBhcmcpOwogfQogCiAvKgpkaWZmIC0tZ2l0IGEveGVuL2FyY2gv
eDg2L3BoeXNkZXYuYyBiL3hlbi9hcmNoL3g4Ni9waHlzZGV2LmMKaW5kZXggMjM0NjViY2QwMC4u
ZWEzOGJlOGI3OSAxMDA2NDQKLS0tIGEveGVuL2FyY2gveDg2L3BoeXNkZXYuYworKysgYi94ZW4v
YXJjaC94ODYvcGh5c2Rldi5jCkBAIC0xMiw3ICsxMiw3IEBACiAjaW5jbHVkZSA8YXNtL2lvX2Fw
aWMuaD4KICNpbmNsdWRlIDxhc20vbXNpLmg+CiAjaW5jbHVkZSA8YXNtL2h2bS9pcnEuaD4KLSNp
bmNsdWRlIDxhc20vaHlwZXJjYWxsLmg+CisjaW5jbHVkZSA8eGVuL2h5cGVyY2FsbC5oPgogI2lu
Y2x1ZGUgPHB1YmxpYy94ZW4uaD4KICNpbmNsdWRlIDxwdWJsaWMvcGh5c2Rldi5oPgogI2luY2x1
ZGUgPHhzbS94c20uaD4KQEAgLTQ4MCw1NCArNDgwLDYgQEAgcmV0X3QgZG9fcGh5c2Rldl9vcChp
bnQgY21kLCBYRU5fR1VFU1RfSEFORExFX1BBUkFNKHZvaWQpIGFyZykKICAgICAgICAgYnJlYWs7
CiAgICAgfQogCi0gICAgY2FzZSBQSFlTREVWT1BfcGNpX2RldmljZV9hZGQ6IHsKLSAgICAgICAg
c3RydWN0IHBoeXNkZXZfcGNpX2RldmljZV9hZGQgYWRkOwotICAgICAgICBzdHJ1Y3QgcGNpX2Rl
dl9pbmZvIHBkZXZfaW5mbzsKLSAgICAgICAgbm9kZWlkX3Qgbm9kZTsKLQotICAgICAgICByZXQg
PSAtRUZBVUxUOwotICAgICAgICBpZiAoIGNvcHlfZnJvbV9ndWVzdCgmYWRkLCBhcmcsIDEpICE9
IDAgKQotICAgICAgICAgICAgYnJlYWs7Ci0KLSAgICAgICAgcGRldl9pbmZvLmlzX2V4dGZuID0g
ISEoYWRkLmZsYWdzICYgWEVOX1BDSV9ERVZfRVhURk4pOwotICAgICAgICBpZiAoIGFkZC5mbGFn
cyAmIFhFTl9QQ0lfREVWX1ZJUlRGTiApCi0gICAgICAgIHsKLSAgICAgICAgICAgIHBkZXZfaW5m
by5pc192aXJ0Zm4gPSAxOwotICAgICAgICAgICAgcGRldl9pbmZvLnBoeXNmbi5idXMgPSBhZGQu
cGh5c2ZuLmJ1czsKLSAgICAgICAgICAgIHBkZXZfaW5mby5waHlzZm4uZGV2Zm4gPSBhZGQucGh5
c2ZuLmRldmZuOwotICAgICAgICB9Ci0gICAgICAgIGVsc2UKLSAgICAgICAgICAgIHBkZXZfaW5m
by5pc192aXJ0Zm4gPSAwOwotCi0gICAgICAgIGlmICggYWRkLmZsYWdzICYgWEVOX1BDSV9ERVZf
UFhNICkKLSAgICAgICAgewotICAgICAgICAgICAgdWludDMyX3QgcHhtOwotICAgICAgICAgICAg
c2l6ZV90IG9wdGFycl9vZmYgPSBvZmZzZXRvZihzdHJ1Y3QgcGh5c2Rldl9wY2lfZGV2aWNlX2Fk
ZCwgb3B0YXJyKSAvCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHNpemVvZihhZGQu
b3B0YXJyWzBdKTsKLQotICAgICAgICAgICAgaWYgKCBjb3B5X2Zyb21fZ3Vlc3Rfb2Zmc2V0KCZw
eG0sIGFyZywgb3B0YXJyX29mZiwgMSkgKQotICAgICAgICAgICAgICAgIGJyZWFrOwotCi0gICAg
ICAgICAgICBub2RlID0gcHhtX3RvX25vZGUocHhtKTsKLSAgICAgICAgfQotICAgICAgICBlbHNl
Ci0gICAgICAgICAgICBub2RlID0gTlVNQV9OT19OT0RFOwotCi0gICAgICAgIHJldCA9IHBjaV9h
ZGRfZGV2aWNlKGFkZC5zZWcsIGFkZC5idXMsIGFkZC5kZXZmbiwgJnBkZXZfaW5mbywgbm9kZSk7
Ci0gICAgICAgIGJyZWFrOwotICAgIH0KLQotICAgIGNhc2UgUEhZU0RFVk9QX3BjaV9kZXZpY2Vf
cmVtb3ZlOiB7Ci0gICAgICAgIHN0cnVjdCBwaHlzZGV2X3BjaV9kZXZpY2UgZGV2OwotCi0gICAg
ICAgIHJldCA9IC1FRkFVTFQ7Ci0gICAgICAgIGlmICggY29weV9mcm9tX2d1ZXN0KCZkZXYsIGFy
ZywgMSkgIT0gMCApCi0gICAgICAgICAgICBicmVhazsKLQotICAgICAgICByZXQgPSBwY2lfcmVt
b3ZlX2RldmljZShkZXYuc2VnLCBkZXYuYnVzLCBkZXYuZGV2Zm4pOwotICAgICAgICBicmVhazsK
LSAgICB9Ci0KICAgICBjYXNlIFBIWVNERVZPUF9wcmVwYXJlX21zaXg6CiAgICAgY2FzZSBQSFlT
REVWT1BfcmVsZWFzZV9tc2l4OiB7CiAgICAgICAgIHN0cnVjdCBwaHlzZGV2X3BjaV9kZXZpY2Ug
ZGV2OwpAQCAtNjYzLDcgKzYxNSw3IEBAIHJldF90IGRvX3BoeXNkZXZfb3AoaW50IGNtZCwgWEVO
X0dVRVNUX0hBTkRMRV9QQVJBTSh2b2lkKSBhcmcpCiAgICAgfQogCiAgICAgZGVmYXVsdDoKLSAg
ICAgICAgcmV0ID0gLUVOT1NZUzsKKyAgICAgICAgcmV0ID0gcGNpX3BoeXNkZXZfb3AoY21kLCBh
cmcpOwogICAgICAgICBicmVhazsKICAgICB9CiAKZGlmZiAtLWdpdCBhL3hlbi9hcmNoL3g4Ni94
ODZfNjQvcGh5c2Rldi5jIGIveGVuL2FyY2gveDg2L3g4Nl82NC9waHlzZGV2LmMKaW5kZXggMGE1
MGNiZDRkOC4uZTNjYmQ1ZWJjYiAxMDA2NDQKLS0tIGEveGVuL2FyY2gveDg2L3g4Nl82NC9waHlz
ZGV2LmMKKysrIGIveGVuL2FyY2gveDg2L3g4Nl82NC9waHlzZGV2LmMKQEAgLTksNyArOSw3IEBA
IEVNSVRfRklMRTsKICNpbmNsdWRlIDxjb21wYXQveGVuLmg+CiAjaW5jbHVkZSA8Y29tcGF0L2V2
ZW50X2NoYW5uZWwuaD4KICNpbmNsdWRlIDxjb21wYXQvcGh5c2Rldi5oPgotI2luY2x1ZGUgPGFz
bS9oeXBlcmNhbGwuaD4KKyNpbmNsdWRlIDx4ZW4vaHlwZXJjYWxsLmg+CiAKICNkZWZpbmUgZG9f
cGh5c2Rldl9vcCBjb21wYXRfcGh5c2Rldl9vcAogCmRpZmYgLS1naXQgYS94ZW4vZHJpdmVycy9w
Y2kvTWFrZWZpbGUgYi94ZW4vZHJpdmVycy9wY2kvTWFrZWZpbGUKaW5kZXggYTk4MDM1ZGY0Yy4u
OTcyYzkyM2RiMCAxMDA2NDQKLS0tIGEveGVuL2RyaXZlcnMvcGNpL01ha2VmaWxlCisrKyBiL3hl
bi9kcml2ZXJzL3BjaS9NYWtlZmlsZQpAQCAtMSArMSwyIEBACiBvYmoteSArPSBwY2kubworb2Jq
LXkgKz0gcGh5c2Rldi5vCmRpZmYgLS1naXQgYS94ZW4vZHJpdmVycy9wY2kvcGh5c2Rldi5jIGIv
eGVuL2RyaXZlcnMvcGNpL3BoeXNkZXYuYwpuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAw
MDAwMDAwLi40ZjNlMWE5NmMwCi0tLSAvZGV2L251bGwKKysrIGIveGVuL2RyaXZlcnMvcGNpL3Bo
eXNkZXYuYwpAQCAtMCwwICsxLDgwIEBACisKKyNpbmNsdWRlIDx4ZW4vZ3Vlc3RfYWNjZXNzLmg+
CisjaW5jbHVkZSA8eGVuL2h5cGVyY2FsbC5oPgorI2luY2x1ZGUgPHhlbi9pbml0Lmg+CisKKyNp
Zm5kZWYgQ09NUEFUCit0eXBlZGVmIGxvbmcgcmV0X3Q7CisjZW5kaWYKKworcmV0X3QgcGNpX3Bo
eXNkZXZfb3AoaW50IGNtZCwgWEVOX0dVRVNUX0hBTkRMRV9QQVJBTSh2b2lkKSBhcmcpCit7Cisg
ICAgcmV0X3QgcmV0OworCisgICAgc3dpdGNoICggY21kICkKKyAgICB7CisgICAgY2FzZSBQSFlT
REVWT1BfcGNpX2RldmljZV9hZGQ6IHsKKyAgICAgICAgc3RydWN0IHBoeXNkZXZfcGNpX2Rldmlj
ZV9hZGQgYWRkOworICAgICAgICBzdHJ1Y3QgcGNpX2Rldl9pbmZvIHBkZXZfaW5mbzsKKyAgICAg
ICAgbm9kZWlkX3Qgbm9kZSA9IE5VTUFfTk9fTk9ERTsKKworICAgICAgICByZXQgPSAtRUZBVUxU
OworICAgICAgICBpZiAoIGNvcHlfZnJvbV9ndWVzdCgmYWRkLCBhcmcsIDEpICE9IDAgKQorICAg
ICAgICAgICAgYnJlYWs7CisKKyAgICAgICAgcGRldl9pbmZvLmlzX2V4dGZuID0gKGFkZC5mbGFn
cyAmIFhFTl9QQ0lfREVWX0VYVEZOKTsKKyAgICAgICAgaWYgKCBhZGQuZmxhZ3MgJiBYRU5fUENJ
X0RFVl9WSVJURk4gKQorICAgICAgICB7CisgICAgICAgICAgICBwZGV2X2luZm8uaXNfdmlydGZu
ID0gdHJ1ZTsKKyAgICAgICAgICAgIHBkZXZfaW5mby5waHlzZm4uYnVzID0gYWRkLnBoeXNmbi5i
dXM7CisgICAgICAgICAgICBwZGV2X2luZm8ucGh5c2ZuLmRldmZuID0gYWRkLnBoeXNmbi5kZXZm
bjsKKyAgICAgICAgfQorICAgICAgICBlbHNlCisgICAgICAgICAgICBwZGV2X2luZm8uaXNfdmly
dGZuID0gZmFsc2U7CisKKyNpZmRlZiBDT05GSUdfTlVNQQorICAgICAgICBpZiAoIGFkZC5mbGFn
cyAmIFhFTl9QQ0lfREVWX1BYTSApCisgICAgICAgIHsKKyAgICAgICAgICAgIHVpbnQzMl90IHB4
bTsKKyAgICAgICAgICAgIHNpemVfdCBvcHRhcnJfb2ZmID0gb2Zmc2V0b2Yoc3RydWN0IHBoeXNk
ZXZfcGNpX2RldmljZV9hZGQsIG9wdGFycikgLworICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICBzaXplb2YoYWRkLm9wdGFyclswXSk7CisKKyAgICAgICAgICAgIGlmICggY29weV9mcm9t
X2d1ZXN0X29mZnNldCgmcHhtLCBhcmcsIG9wdGFycl9vZmYsIDEpICkKKyAgICAgICAgICAgICAg
ICBicmVhazsKKworICAgICAgICAgICAgbm9kZSA9IHB4bV90b19ub2RlKHB4bSk7CisgICAgICAg
IH0KKyNlbmRpZgorCisgICAgICAgIHJldCA9IHBjaV9hZGRfZGV2aWNlKGFkZC5zZWcsIGFkZC5i
dXMsIGFkZC5kZXZmbiwgJnBkZXZfaW5mbywgbm9kZSk7CisgICAgICAgIGJyZWFrOworICAgIH0K
KworICAgIGNhc2UgUEhZU0RFVk9QX3BjaV9kZXZpY2VfcmVtb3ZlOiB7CisgICAgICAgIHN0cnVj
dCBwaHlzZGV2X3BjaV9kZXZpY2UgZGV2OworCisgICAgICAgIHJldCA9IC1FRkFVTFQ7CisgICAg
ICAgIGlmICggY29weV9mcm9tX2d1ZXN0KCZkZXYsIGFyZywgMSkgIT0gMCApCisgICAgICAgICAg
ICBicmVhazsKKworICAgICAgICByZXQgPSBwY2lfcmVtb3ZlX2RldmljZShkZXYuc2VnLCBkZXYu
YnVzLCBkZXYuZGV2Zm4pOworICAgICAgICBicmVhazsKKyAgICB9CisKKyAgICBkZWZhdWx0Ogor
ICAgICAgICByZXQgPSAtRU5PU1lTOworICAgICAgICBicmVhazsKKyAgICB9CisKKyAgICByZXR1
cm4gcmV0OworfQorCisvKgorICogTG9jYWwgdmFyaWFibGVzOgorICogbW9kZTogQworICogYy1m
aWxlLXN0eWxlOiAiQlNEIgorICogYy1iYXNpYy1vZmZzZXQ6IDQKKyAqIHRhYi13aWR0aDogNAor
ICogaW5kZW50LXRhYnMtbW9kZTogbmlsCisgKiBFbmQ6CisgKi8KZGlmZiAtLWdpdCBhL3hlbi9p
bmNsdWRlL3hlbi9oeXBlcmNhbGwuaCBiL3hlbi9pbmNsdWRlL3hlbi9oeXBlcmNhbGwuaAppbmRl
eCAzNzcxNDg3YTMwLi43MDk2Y2M0ZmU0IDEwMDY0NAotLS0gYS94ZW4vaW5jbHVkZS94ZW4vaHlw
ZXJjYWxsLmgKKysrIGIveGVuL2luY2x1ZGUveGVuL2h5cGVyY2FsbC5oCkBAIC00NSw2ICs0NSwx
NyBAQCBleHRlcm4gbG9uZwogZG9fcGxhdGZvcm1fb3AoCiAgICAgWEVOX0dVRVNUX0hBTkRMRV9Q
QVJBTSh4ZW5fcGxhdGZvcm1fb3BfdCkgdV94ZW5wZl9vcCk7CiAKKyNpZmRlZiBDT05GSUdfSEFT
X1BDSQorZXh0ZXJuIGxvbmcKK3BjaV9waHlzZGV2X29wKAorICAgIGludCBjbWQsIFhFTl9HVUVT
VF9IQU5ETEVfUEFSQU0odm9pZCkgYXJnKTsKKyNlbHNlCitzdGF0aWMgaW5saW5lIGxvbmcgcGNp
X3BoeXNkZXZfb3AoaW50IGNtZCwgWEVOX0dVRVNUX0hBTkRMRV9QQVJBTSh2b2lkKSBhcmcpCit7
CisgICAgZ2RwcmludGsoWEVOTE9HX0RFQlVHLCAiUEhZU0RFVk9QIGNtZD0lZDogbm90IGltcGxl
bWVudGVkXG4iLCBjbWQpOworICAgIHJldHVybiAtRU5PU1lTOworfQorI2VuZGlmCiAvKgogICog
VG8gYWxsb3cgc2FmZSByZXN1bWUgb2YgZG9fbWVtb3J5X29wKCkgYWZ0ZXIgcHJlZW1wdGlvbiwg
d2UgbmVlZCB0byBrbm93CiAgKiBhdCB3aGF0IHBvaW50IGluIHRoZSBwYWdlIGxpc3QgdG8gcmVz
dW1lLiBGb3IgdGhpcyBwdXJwb3NlIEkgc3RlYWwgdGhlCi0tIAoyLjI1LjEKCg==

--_004_7FE915FF574348E5B50E9F5688344C45armcom_--


From xen-devel-bounces@lists.xenproject.org Fri Oct 01 17:38:48 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Oct 2021 17:38:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.200799.355364 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mWMUR-0002st-1u; Fri, 01 Oct 2021 17:38:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 200799.355364; Fri, 01 Oct 2021 17:38:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mWMUQ-0002sm-VA; Fri, 01 Oct 2021 17:38:30 +0000
Received: by outflank-mailman (input) for mailman id 200799;
 Fri, 01 Oct 2021 17:38:29 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=m+lB=OV=citrix.com=Andrew.Cooper3@srs-us1.protection.inumbo.net>)
 id 1mWMUP-0002sg-Ci
 for xen-devel@lists.xenproject.org; Fri, 01 Oct 2021 17:38:29 +0000
Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 912d481b-9f7a-4d53-9161-7cdac3ca1033;
 Fri, 01 Oct 2021 17:38:27 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 912d481b-9f7a-4d53-9161-7cdac3ca1033
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1633109907;
  h=to:cc:references:from:subject:message-id:date:
   in-reply-to:content-transfer-encoding:mime-version;
  bh=9hnbtrZYVEo5wCc6TgGO5kTiiF5U8l2lVknkRriU0NU=;
  b=J1M3IfxDiA4MyzXQOmeRBLVvrea2EoQM4W95CsIovcRZOzLp/61ZuK5b
   jImVx8707xBg2GogqKpAs8LT+J2hoXOEXrlMsYqjg+6FYG9BHbO6YEATf
   qpFc2l8UIO5ODbO4THMIiIdz3Aaw6M2aOsGIpSafNL5P1bz2Su6kff88P
   0=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: m60S6CW2clrddJUFrbnbgZgVBN0mzt3rEnmuBsgVTR3whthKBiq2TcKNB4Nj5dtR+Vi9euQfu7
 rFEzhGLG5T1rIx7tArDqhuMP4QL1DOroff85ov/Rz4w4yj2Rp8hF5sAeJ5RCy9TJyBs7Ya138N
 RuE13kEOhksBj00qUCz9RIbTXesy0WncFAt7sY8Y/yZ+H+swgpAOImhEUsIDiH7bIBpAP4D6rS
 oGO6slRYMOTHqqAbC2xHC+NxDc42cnYiQK6vdgm+v3yq22NIMvx04tvxst0fMpupStVgEkfE1n
 O+9kuvsXIuoqoZkxfTCk/BH7
X-SBRS: 5.1
X-MesageID: 54561083
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:1OBGwqINslfBMAaqFE+RtJMlxSXFcZb7ZxGr2PjKsXjdYENSgmZRz
 zRMCzvQOa6OYGWhLop0Odu0oR5Sv8CHmN8yG1FlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s
 q3yv/GZdJhcokcxIn5BC5C5xZVG/fjgqoHUVaiUZ0ideSc+EH140Eo7wrZi6mJVqYPR7z2l6
 IuaT/L3YDdJ6xYsWo7Dw/vewP/HlK2aVAIw5jTSV9gS1LPtvyB94KYkDbOwNxPFrrx8RYZWc
 QphIIaRpQs19z91Yj+sfy2SnkciGtY+NiDW4pZatjTLbrGvaUXe345iXMfwZ3u7hB2lwcBxz
 fdPn6eVRC4iAfHUts8GcD9XRnQW0a1uoNcrIFC6uM2XiUbHb2Ht07NlC0Re0Y8wo7gtRzsUr
 LpBdW5LPkvra+GemdpXTsFFgMg5IdatF4QYonx6lhnSDOo8QICFSKLPjTNd9Gps254XRaaFD
 yYfQTdjXh2ZRiYWAxQGMqwCu+6OoSfdcDIN/Tp5ooJoujOOnWSdyoPFLNrUYZqLXoNcxkKDo
 WTu8GHwAxVcP9uaoRKa9lq8i+mJmjn0MKoQG6e/7eVCm0CIyyoYDxh+fVmxrOS9i0W+c8lCM
 EFS8S0rxYAz606DXtT7Rwe/onOPolgbQdU4O+Q+5RHLza7P5ACxHXQNVDpIYpons6ceVTEsk
 1OEgd7tLThuq6GOD2KQ8K+OqjG/MjRTKnUNDQcGUA8E7t/LsIw1yBXVQb5LC7Wph9f4HTXxx
 TGiryUkgbgXy8kR2M2GEUvv2mz24MKTF0hsu1uRDjnNAh5FiJCNS9K46V3579x7CYuwRWbdp
 FYvgOu447VbZX2SrxClTOIIFbCvwv+KNjzAnFJid6UcGySRF22LJ94Jv2AnTKt9GoNUIWa2P
 B+7VRZ5vsc7AZe8UUNgj2td4ewEyrL8XfDsS/zZdNZHZpUZmOSvp3o1PR/4M4wAiiERfUAD1
 XWzLZvE4ZUyU/0PIN+KqwE1iuNDKscWnz27eHwD5077uYdynVbMIVv/DHOAb/oi8ISPqxjP/
 tBUOqOikksEC7WkPXKJqNNDfDjmyETX47it96S7kcbZfGJb9JwJUaeNkdvNhaQ/90iqqgs41
 i7kARIJoLYOrXbGNR+LehhehEDHBv5CQYYAFXV0Zz6AgiF7Ca72tft3X8ZnLNEPqb04pdYpH
 qZtRil1KqkWItgx029GNseVQU0LXEnDuD9iyAL/O2VgI848GVaZkjImFyO2nBQz4uOMnZJWi
 5Wr1x/BQIpFQAJnDc3Mb+mowU/3tn8Y8N+elWOSSjWKUEmzooVsNQLrifo7f5MFJRnZn2PI3
 AeKGxYI4+LKptZtotXOgKmFqaavEvd/QRUGTzWKs+7uOHmI5HenzK9BTP2MIWLXWlTr9fjwf
 u5S1fz9bqEKxQ4Yr4pmHr935qsi/N+z9aRCxwFpESyTPVSmA79tOFec2sxLuvEfz7NVo1LuC
 EmO5sNbKfOCP8a8SAwdIw8sb+Ki0/AIm2aNsaRpcRuivCIupeiJS0RfORWImRdxFrotPdN32
 /olte4X9xe71kggPOGZg30G7G+LNHEBDfkq78lIHI/xhwM34VheepiAWDTu6ZSCZtgQYEknJ
 jiY2PjLi7hGnxeQdnMyET7G3PZHhIRIsxdPlQdQK1OMk9vDp/k2wBwOrmhnElULlk1Kg7BpJ
 2xmF0xpPqHfrT5nif9KU32oBwwcVgaS/Vb8ygdRmWDUJ6Vyurch8IHp1T6xwX0k
IronPort-HdrOrdr: A9a23:ipD1gaw9yESn5JcOUOwEKrPx/OskLtp133Aq2lEZdPULSKalfp
 GV98jziyWdtN9xYgBrpTnkAsS9qBznhPtICOUqU4tKGTOW3ldAT7sSoLcKoQeQfxEWn9Q1uc
 hdmupFebrN5DNB7foSlTPIcerIt+P3k5xA692+855Fd3ATV4hQqyNCTiqLGEx/QwdLQbAjEo
 CH28ZBrz28PVwKc8WSHBA+Lqf+juyOsKijTQ8NBhYh5gXLpyiv8qTGHx+R2Qpbey9TwI0l7X
 POn2XCl+ueWrCAu17hPl3ontdrcejau5l+7fm3+4gowm+FsHfSWG0uYczGgNl/mpDX1L9jqq
 i3n/5nBbU+15qZRBDJnfO5szOQrwoG+jvsz0SVjmDkptG8TDUmC9BZjYYcaRfB7VE81esMmJ
 6j8ljpwaa/Nymw1RgVJuK4JS1Chw6xuz4vgOQTh3tQXc8Xb6JQt5UW+AdPHJIJDEvBmfca+M
 EHNrCj2B5+GWnqE0wxflMftOBEe05DVStubnJyyvB94gIm6UyRlXFotfD3tk1wh64Adw==
X-IronPort-AV: E=Sophos;i="5.85,339,1624334400"; 
   d="scan'208";a="54561083"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=IfxEgeSjoEGRQ5Hb/e1XRlvbiBldgTlyCpQayR2XFP3PZs5iJ45488lemR+zyfQVoR3HtwrJPXHdW1HHOSI2JV3IA113gQkaSMJmAHvf8KKOdi6HSuI0JNeVjJ6ll8YOghgTfDI819pwqbkKxKPjVfOVVwGUgLlWV941FX56B5Jz3GnUb6RHwTHaL8iQC+rG2ZU+CARaxfQ13EFkt3GXbIwf1vJL1Afn/ipAzgbTr+YOd7s8G0Mg3sxDBxnrVjhIbOtvGXEdtVPLgcbu3etTivS44ctkSMGlP4blTkWYDiLJIPiMhroAMMT7Jd6yS4C0Ry0/9xIsHLZbXdOOe8Z8rQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=9hnbtrZYVEo5wCc6TgGO5kTiiF5U8l2lVknkRriU0NU=;
 b=WQ19KQCDtscx1jVC4N8DVq6dKMQgHolmmlo+t/GOyb1NjxW19FEUQ42xZ9G4Qw383TxlGW1nl/8NA1JpdHnjVoPqqqz5ZnaEdBeR5f5lUX21w/qZJ8EZHEF4Euvg2UGPxizVDRss7peDuMgWM7IojZvrA3xK2jkBnn3AytR9Sv2AlLuG3BohCc9LP3k6X1tBju1T5Q7StH1mz+FxPhul/3nomz9kXb1yT22+FZzj6XB7ULZF6w60/W7xCr0a9e69uvEPgYazY4h/ghQowcDuuLYYnTpAKRg7mqc0KxtmJQtbunfv/8Ks8MtZTWELiI6jTJCqqiRNSo/2DyCUQFIiSw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=9hnbtrZYVEo5wCc6TgGO5kTiiF5U8l2lVknkRriU0NU=;
 b=SWtFT2pulIuxmlFy/yUE6BzMobUJ1QhdHBdUgOqkEs9XvUMfCNKR/70Qv1eeiKvdAUBLXJvhxbAQygJUa5PCI9DVTwyo9kvTa5svNQblc0sH0QNmjXsPkq3JrskRE/0o7XaEeoYFCyIjKF/yYkNatohHRKGIkr1NuyPCpD9Ev70=
To: Juergen Gross <jgross@suse.com>, Jan Beulich <jbeulich@suse.com>, Alex
 Olson <this.is.a0lson@gmail.com>
CC: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>, Wei Liu
	<wl@xen.org>, Ian Jackson <iwj@xenproject.org>, George Dunlap
	<george.dunlap@citrix.com>, Julien Grall <julien@xen.org>, Stefano Stabellini
	<sstabellini@kernel.org>, Anthony PERARD <anthony.perard@citrix.com>, Alex
 Olson <alex.olson@starlab.io>, <xen-devel@lists.xenproject.org>
References: <cover.1632512149.git.this.is.a0lson@gmail.com>
 <85b59046315b8a84afa8538aacdea92b19200faa.1632512149.git.this.is.a0lson@gmail.com>
 <d899b058-a201-e2f8-35d2-f0e59ab4bab3@suse.com>
 <d63a0e7d-7f9d-0dcb-0ac9-8995e56698b4@citrix.com>
 <2ff385c7-55bd-4647-efb5-9909addca226@suse.com>
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH 1/1] x86: centralize default APIC id definition
Message-ID: <5464f556-4932-ee6b-b98c-78ad1bc6bdce@citrix.com>
Date: Fri, 1 Oct 2021 18:38:12 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <2ff385c7-55bd-4647-efb5-9909addca226@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Content-Language: en-GB
X-ClientProxiedBy: LO4P123CA0227.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:1a6::16) To BYAPR03MB3623.namprd03.prod.outlook.com
 (2603:10b6:a02:aa::12)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 5d463de5-83f6-4079-3cbf-08d9850241f7
X-MS-TrafficTypeDiagnostic: BYAPR03MB3799:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <BYAPR03MB37996E14065670816085F708BAAB9@BYAPR03MB3799.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: H828yHrhhmMVgo8sjNjR3ovbhWt0SuRcrykZI8dhWmauIQq9QWpd4Rip5Bw8mx/8/OqtCv4X3JAZYdvBEm8ZeP8SIIBTesvqxKmib69eNaS23EyJB2/8WTttzTOfbDeASvFOffQ5g16xMbRGH16uz7QUXERXAVaMGVJD4S1ui1kkaiyFDrXRDxftg9kPpJci6VVcROmjY6Ddu6AqZVLLMwOCTjRpmeB2DXtoqBi1kYysKgqkTFV1k8dBLe6ju/tRQ+AzQY6c5EOoSi5YXeHSZAsDwQvl71wQEvqeAGSp6bZ9phKNv2aUKthwVkD55xPQv20acPfpPEgmAHtnH3cixhqMpZ6ZS2fGwtLV9lXD6XwrGpEq+JrdElywsFPrioPja6GDFBYl/pzl+0t3TdZ5nFREE2WyvGIdpJ97ZFXghIvvoVr/dsNLlSDYR92l4nZ1w8vIIyGfISjQJsfap5biOPT16KpzDlmwJCIaHA9xs66M3AyKB0d94c6rsSHjJctvDPUhfhWDKnfRJL6dr8zhST38n+J1BSIhF1kLo8l55La1wORo4472jZsTPCrdzFnQSADQa0boESg4ZBB8LFzD4yqJboRx3dr3G8em/9Z2aO6kaGQpEx7ui9pbwE1C6snsYnUd3FuOnMynioKTUcb8Cwi111dowUMMq8uYLm7zcFF9HGo9N4dqWYw5Tf1ckmsRC/w9FfOCuBzfByG9TfojIkOzdfn36p09xVxoTHFo6lk=
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(8936002)(2906002)(6486002)(26005)(53546011)(8676002)(86362001)(38100700002)(31686004)(55236004)(316002)(36756003)(186003)(54906003)(31696002)(110136005)(956004)(2616005)(6666004)(83380400001)(5660300002)(4326008)(66946007)(66476007)(66556008)(16576012)(508600001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T0JnVlpRVG9tQTNwVU9TMzV0MG9jNUdKRFpZUktKNW5rVHlXbmdxb0wxUUEx?=
 =?utf-8?B?ZkNTOTkwbG1kUTdSYTBHSnRWbHFGOUdjUDJVUThTYXBOSEl6bWs3TVdJc2VC?=
 =?utf-8?B?MlFwWXNaZUVMSHNNV1EwNHN2VCtFUmpxYW1nZEZqWlUrQXVXTm1ZZkJydnZo?=
 =?utf-8?B?STd6VGRPTDBlQ1N6d2o2TnJmdk5Pb3JqaW0rQXpPRS9aQnYzY2pNb3hoSTVn?=
 =?utf-8?B?QnZ6RkR6cm9WWkYvb0gvMFNuNFRWcnA5Zk5ENmsrallUOTRPOTZmYmVhZWZQ?=
 =?utf-8?B?azArUmV1ZXhUQVVRalpFaUh6OXd5eWRzcUQwdCtlS3VVN2dVaWxEcXhNY3Ex?=
 =?utf-8?B?aTlOR3cySUtXL05IcUF5ZWUxMFJpa05IN0podHA1VE1iYmhvY1d1RlVLNXg3?=
 =?utf-8?B?LzNsamNuQU12UjlZL0RmK3ZuOWJYM3IrNnA2UzU3OEJualcxU2txMWx6MzVJ?=
 =?utf-8?B?ck1vVWp2U1RwYURSc0dtTGtFb2VTc0dZNnNMRm1VdUY1RFJuekJUdUxjcGRq?=
 =?utf-8?B?c1ZSajdYZGFGZWxTb3NXTzUvS3RyVTBUMncrNEprYk04SjltQ2NpaE0zaVUv?=
 =?utf-8?B?dFRtMGZVeTNiYVV4NzhndVFGcFRnSCsvK3Q5NWFnRnRyUVl4NndXNDY3SU5U?=
 =?utf-8?B?eUxRT2V0SFZlQzI1bXlQVUlabDg3VXBNeDJkcmtzTXYzQU1FNEN6LzdNQTNM?=
 =?utf-8?B?V29lNzBsTzhmYzE3bHF6M0YwUndta2EwOGtkelk0N3ZFUTdlSWpYWEJ3Vi96?=
 =?utf-8?B?cjFjc3BkRkVUaFFtQUlVam5nc2xTT3I4VjQ4QitXdTZtZVhIM3VLeU5HYm1z?=
 =?utf-8?B?YkdIeGJIWHAvTTFDLzVqak9MWkNMNjVUTVJCUUszdlEyMERmeTd6MUtaNUEr?=
 =?utf-8?B?U2x3M0pNY0FSbE5sOEcxMG1vQ1ZLOW9zVzVOOTVvN3Z4QVNrTUpvWE4rNmxQ?=
 =?utf-8?B?aTYyV2V6bHdncXArK20rakoydTV3cWZtcDJqWUFkc1JXQzExYXBXY0Evc2FS?=
 =?utf-8?B?N1JCN1VzVDh1ME8xNzhoMXNiM21EMU9RYWNBUjJxS3ZEVEQ4cmRXajlma1J4?=
 =?utf-8?B?ampKSm5wTnJwN215bk5LUG1LOU83TmxmNzQ4czJRWSsvRlpRYml0MlQ2OE1q?=
 =?utf-8?B?cFBqdmhLUGhxMUZoeWt5a0dkeks1aUJHSlpyMVY5RG9kSzFIUExUeVJZZXlu?=
 =?utf-8?B?a2daSXpkb2x0dGhGdG95aGhWQnVaUzBGVk9YUUppMmRYUloxZ01zK0VwTFpa?=
 =?utf-8?B?czRrOUdsK1c1N2YwTGlodktDQTllRUJpTTE3dVd6SVQ1VnAxSDAwRHpEcE0x?=
 =?utf-8?B?LzBEbnRZTldEcmxxcFlVU2J6VHBUK0p6SzVLSzh4ZmdhV0dlcHRQSG5RRjJV?=
 =?utf-8?B?cmVLVGhlOFRTdTJJVExsR0c0QkVvRHNURFhnL2hza0lDNWZ1SFNoN3BDeWRZ?=
 =?utf-8?B?NzNuV3NsYlMvemNxSzZ2OHRnZEpianZNMFdjK1hkMXhDeTJQZjV1alFMVkUy?=
 =?utf-8?B?a2xPOFE2c2hNQk1PKzJsSHQwR0I0TTczdnVQUG5uUE81Q0tVR1RkdUJqcmUz?=
 =?utf-8?B?a2xzMm5oRW9nbjBtV0sxMW9GS05FQkdZait0dnBQOURQcE4xdFZEd2RHcE9y?=
 =?utf-8?B?N0dRMkpLVlB5M2cwM0JwRTZjQzlUaHFiVitDSWhhTmJTZm9RKzJxR1NBUCtJ?=
 =?utf-8?B?MnBWN3dBK0RWdFRYN2JWZUpYSHlXR293OGtmZ01qR3NZU2JNV1NKRE5SWWND?=
 =?utf-8?Q?9KT+olfZ3GAmPG628YJdWQp0it6K146QwfzftFS?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 5d463de5-83f6-4079-3cbf-08d9850241f7
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Oct 2021 17:38:19.4785
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Kv/lVLPzZBDVb8vrPmqLfyNgMueEHoDQQMRBP40HEJ4Xs3cKAEeWl9jN4ZgtZ4eSKsHZwpI3GakkP2R313RyfMcbdG4Kj+g6VFeNHWmiNak=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB3799
X-OriginatorOrg: citrix.com

On 01/10/2021 16:08, Juergen Gross wrote:
> On 01.10.21 16:29, Andrew Cooper wrote:
>> On 01/10/2021 15:19, Jan Beulich wrote:
>>> On 24.09.2021 21:39, Alex Olson wrote:
>>>> Inspired by an earlier attempt by Chao Gao <chao.gao@intel.com>,
>>>> this revision aims to put the hypervisor in control of x86 APIC
>>>> identifier
>>>> definition instead of hard-coding a formula in multiple places
>>>> (libxl, hvmloader, hypervisor).
>>>>
>>>> This is intended as a first step toward exposing/altering CPU topology
>>>> seen by guests.
>>>>
>>>> Changes:
>>>>
>>>> - Add field to vlapic for holding default ID (on reset)
>>>>
>>>> - add HVMOP_get_vcpu_topology_id hypercall so libxl (for PVH domains)
>>>> =C2=A0=C2=A0 can access APIC ids needed for ACPI table definition prio=
r to
>>>> domain start.
>>>>
>>>> - For HVM guests, hvmloader now also uses the same hypercall.
>>>>
>>>> - Make CPUID code use vlapic ID instead of hard-coded formula
>>>> =C2=A0=C2=A0 for runtime reporting to guests
>>> I'm afraid a primary question from back at the time remains: How is
>>> migration of a guest from an old hypervisor to one with this change
>>> in place going to work?
>>
>> I'm afraid its not.
>>
>> Fixing this is incredibly complicated.=C2=A0 I have a vague plan, but it
>> needs building on the still-pending libxl cpuid work of Rogers.
>>
>> Both the toolstack and Xen need to learn about how to describe topology
>> correctly (and I'm afraid this patch isn't correct even for a number of
>> the simple cases), and know about "every VM booted up until this point
>> in time" being wrong.
>
> What about:
>
> - adding APIC-Id to the migration stream
> - adding an optional translation layer for guest APIC-Id to the
> =C2=A0 hypervisor
> - adding the functionality to set a specific APIC-Id for a vcpu
> =C2=A0 (will use the translation layer if not the same as preferred
> =C2=A0 by the hypervisor)

The vCPU APIC IDs are already in the migration stream.=C2=A0 They're just t=
oo
late in the stream for any easy fixup.

A second problem we have is that (x)APIC IDs are writeable under Xen,
but writeability of the register is a model specific trait to being
with.=C2=A0 Furthermore, you get potentially differing behaviour depending =
on
whether APICV is enabled or not.=C2=A0 I plan to fix this by simply outlawi=
ng
it - OSes don't renumber the APICs in the first place (just like they
don't move the MMIO window), and all they'll do is break things.

The main topology problem is that we have no interlink between the
CPUID-described data, and the default APIC IDs chosen.=C2=A0 There are 5
different algorithms to choose from (vendor and CPU dependent) and we
implement 0 of them.

The xl config file needs more than just cpuid=3D data to express the
topology correctly, because for non-power-of-two systems, there need to
be gaps in the APIC_ID space, and this needs communicating to Xen too.=C2=
=A0
(For old AMD, we also need a slide, but we can probably leave that as an
exercise to anyone who cares, which seems to be noone so far).

Either way, when the toolstack can reason about topologies correctly, we
can extend the xl json in the stream.=C2=A0 The absense of the marker serve=
s
as "This VM didn't boot with sane topology", which we can use the
fallback logic (see libxl__cpuid_legacy() and the soon to exist
companion in libxc) to re-synthesize the old pattern for when data is
missing in the stream.

Any change to the topology algorithms before the toolstack is capable of
doing everything else leaves us with two[1] different kinds of VMs that
we can't tell apart, and cannot cope with in a compatible way.

~Andrew

[1] Actually 3.=C2=A0 XenServer still has a revert of ca2eee92df44 in the
patchqueue because that broke VMs which migrated across the point.=C2=A0 As
it's from 2008, pre-and-post VMs aren't something we need to care about,
because anyone still running Xen 3.3 has far bigger problems than this
to worry about.



From xen-devel-bounces@lists.xenproject.org Fri Oct 01 19:08:23 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Oct 2021 19:08:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.200808.355375 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mWNt8-0003dX-Mc; Fri, 01 Oct 2021 19:08:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 200808.355375; Fri, 01 Oct 2021 19:08:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mWNt8-0003dQ-JD; Fri, 01 Oct 2021 19:08:06 +0000
Received: by outflank-mailman (input) for mailman id 200808;
 Fri, 01 Oct 2021 19:08:04 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=GmoI=OV=gmail.com=this.is.a0lson@srs-us1.protection.inumbo.net>)
 id 1mWNt6-0003d8-Dw
 for xen-devel@lists.xenproject.org; Fri, 01 Oct 2021 19:08:04 +0000
Received: from mail-qt1-x830.google.com (unknown [2607:f8b0:4864:20::830])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 0d103af8-ef0e-420e-9c0e-efa612e329d3;
 Fri, 01 Oct 2021 19:08:02 +0000 (UTC)
Received: by mail-qt1-x830.google.com with SMTP id e16so9917831qte.13
 for <xen-devel@lists.xenproject.org>; Fri, 01 Oct 2021 12:08:02 -0700 (PDT)
Received: from development ([24.214.236.228])
 by smtp.gmail.com with ESMTPSA id v1sm3464287qkv.37.2021.10.01.12.08.00
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Fri, 01 Oct 2021 12:08:01 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0d103af8-ef0e-420e-9c0e-efa612e329d3
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=message-id:subject:from:to:cc:date:in-reply-to:references
         :user-agent:mime-version:content-transfer-encoding;
        bh=wOSN/23E1YtC/bsgmWNfyTXDkqv22zJD+bK79ix+BB8=;
        b=MQPDan3lsBieNH7UBdxhTdu5ryG4l7iEHz+M5fkLLfvv2GJHp0m0nMgiFsFoRQ934J
         8h+UtYNbp5/PiS2VmULQpJBqTVcvIGaiUfokFwjKIImI9R/I1OjiSKp3bEprVwds2+L5
         kju5+ZfBbkDTUXPuy5IQVMqJ5grOmXa9jVgu9sO+05d+K9qiUW+1cBP/1/BE15G4BP+l
         qfU4KshWTM0YPJcUCyYlNnmQexogCeOZvAW4YwT4ZuYCfjROQebpx2MCqXtIaCIPrKEH
         zE/lw6297mzZw0TISXSJmJ3+kPiGp2O8339+sDC8pPU9l6nu+rMJEQpHvGeJf8afXBh8
         ZV+A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to
         :references:user-agent:mime-version:content-transfer-encoding;
        bh=wOSN/23E1YtC/bsgmWNfyTXDkqv22zJD+bK79ix+BB8=;
        b=4xsIf6oMzx2Jm4yOPhE1XiixCrVcEq9fdl9wfObmp3KLL6VvPz6fmTMJKbAFxMvndZ
         /gwcQU4TdJZeCuxhUek+cVjfWuuPTyUxHFWyVx/Dr5QRMrCKX1WXKK1w69c4Dhn5WL8W
         YNTJOYwoegsgt0YdLNEUssk56X3pcHwBG/hEhMFw+C+F9GuLa5rNnoXSMCqQI/bRZJno
         EfL1JqOqLwBaFchqS4yQouBgzp5URJVWj2sKOHMMptTPFIEOQDPyDHuhEPly53A3W0G/
         HkVhtUkBuCZA8tnRNLHa9FkvkCAqFbWku+TpKtYXfgljs7T7sfBPWBpb1PIOAoeYyCxF
         ZDug==
X-Gm-Message-State: AOAM531QYd/z+awdIzn+IQFgnh0xofiBy3F27U1IoVJj1EIvWOhkYLZF
	Er2i6lvOQe1pVtKAp63Fp+4=
X-Google-Smtp-Source: ABdhPJwuFp86pYiOUIVy4/oDalxruLAqFyJgC/M0dX/IG+z3OjfIRjCGzLWQj6zNxbuz6V9sC0wAsg==
X-Received: by 2002:ac8:1c6:: with SMTP id b6mr14579275qtg.221.1633115282336;
        Fri, 01 Oct 2021 12:08:02 -0700 (PDT)
Message-ID: <9c69a0cdbdfe6f29cd295802e13df46509abd5bb.camel@gmail.com>
Subject: Re: [PATCH 1/1] x86: centralize default APIC id definition
From: Alex Olson <this.is.a0lson@gmail.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>, Juergen Gross
 <jgross@suse.com>,  Jan Beulich <jbeulich@suse.com>
Cc: Roger Pau =?ISO-8859-1?Q?Monn=E9?= <roger.pau@citrix.com>, Wei Liu
 <wl@xen.org>, Ian Jackson <iwj@xenproject.org>, George Dunlap
 <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>, Stefano
 Stabellini <sstabellini@kernel.org>, Anthony PERARD
 <anthony.perard@citrix.com>, Alex Olson <alex.olson@starlab.io>,
 xen-devel@lists.xenproject.org
Date: Fri, 01 Oct 2021 14:07:59 -0500
In-Reply-To: <5464f556-4932-ee6b-b98c-78ad1bc6bdce@citrix.com>
References: <cover.1632512149.git.this.is.a0lson@gmail.com>
	 <85b59046315b8a84afa8538aacdea92b19200faa.1632512149.git.this.is.a0lson@gmail.com>
	 <d899b058-a201-e2f8-35d2-f0e59ab4bab3@suse.com>
	 <d63a0e7d-7f9d-0dcb-0ac9-8995e56698b4@citrix.com>
	 <2ff385c7-55bd-4647-efb5-9909addca226@suse.com>
	 <5464f556-4932-ee6b-b98c-78ad1bc6bdce@citrix.com>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.36.5-0ubuntu1 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit

I hadn't seriously considered the scenario of VM migration from older
Xen versions,  but If I understand Andrew's last statement correctly,
it sounds like my patch will break things in new ways that cannot be
fixed at this time. If that is the case, I'll abandon my efforts with
this patch. 

Thank you for the reviews and detailed feedback,

-Alex

On Fri, 2021-10-01 at 18:38 +0100, Andrew Cooper wrote:
> On 01/10/2021 16:08, Juergen Gross wrote:
> > On 01.10.21 16:29, Andrew Cooper wrote:
> > > On 01/10/2021 15:19, Jan Beulich wrote:
> > > > On 24.09.2021 21:39, Alex Olson wrote:
> > > > > Inspired by an earlier attempt by Chao Gao <
> > > > > chao.gao@intel.com>,
> > > > > this revision aims to put the hypervisor in control of x86
> > > > > APIC
> > > > > identifier
> > > > > definition instead of hard-coding a formula in multiple
> > > > > places
> > > > > (libxl, hvmloader, hypervisor).
> > > > > 
> > > > > This is intended as a first step toward exposing/altering CPU
> > > > > topology
> > > > > seen by guests.
> > > > > 
> > > > > Changes:
> > > > > 
> > > > > - Add field to vlapic for holding default ID (on reset)
> > > > > 
> > > > > - add HVMOP_get_vcpu_topology_id hypercall so libxl (for PVH
> > > > > domains)
> > > > >    can access APIC ids needed for ACPI table definition prior
> > > > > to
> > > > > domain start.
> > > > > 
> > > > > - For HVM guests, hvmloader now also uses the same hypercall.
> > > > > 
> > > > > - Make CPUID code use vlapic ID instead of hard-coded formula
> > > > >    for runtime reporting to guests
> > > > I'm afraid a primary question from back at the time remains:
> > > > How is
> > > > migration of a guest from an old hypervisor to one with this
> > > > change
> > > > in place going to work?
> > > 
> > > I'm afraid its not.
> > > 
> > > Fixing this is incredibly complicated.  I have a vague plan, but
> > > it
> > > needs building on the still-pending libxl cpuid work of Rogers.
> > > 
> > > Both the toolstack and Xen need to learn about how to describe
> > > topology
> > > correctly (and I'm afraid this patch isn't correct even for a
> > > number of
> > > the simple cases), and know about "every VM booted up until this
> > > point
> > > in time" being wrong.
> > 
> > What about:
> > 
> > - adding APIC-Id to the migration stream
> > - adding an optional translation layer for guest APIC-Id to the
> >   hypervisor
> > - adding the functionality to set a specific APIC-Id for a vcpu
> >   (will use the translation layer if not the same as preferred
> >   by the hypervisor)
> 
> The vCPU APIC IDs are already in the migration stream.  They're just
> too
> late in the stream for any easy fixup.
> 
> A second problem we have is that (x)APIC IDs are writeable under Xen,
> but writeability of the register is a model specific trait to being
> with.  Furthermore, you get potentially differing behaviour depending
> on
> whether APICV is enabled or not.  I plan to fix this by simply
> outlawing
> it - OSes don't renumber the APICs in the first place (just like they
> don't move the MMIO window), and all they'll do is break things.
> 
> The main topology problem is that we have no interlink between the
> CPUID-described data, and the default APIC IDs chosen.  There are 5
> different algorithms to choose from (vendor and CPU dependent) and we
> implement 0 of them.
> 
> The xl config file needs more than just cpuid= data to express the
> topology correctly, because for non-power-of-two systems, there need
> to
> be gaps in the APIC_ID space, and this needs communicating to Xen
> too. 
> (For old AMD, we also need a slide, but we can probably leave that as
> an
> exercise to anyone who cares, which seems to be noone so far).
> 
> Either way, when the toolstack can reason about topologies correctly,
> we
> can extend the xl json in the stream.  The absense of the marker
> serves
> as "This VM didn't boot with sane topology", which we can use the
> fallback logic (see libxl__cpuid_legacy() and the soon to exist
> companion in libxc) to re-synthesize the old pattern for when data is
> missing in the stream.
> 
> Any change to the topology algorithms before the toolstack is capable
> of
> doing everything else leaves us with two[1] different kinds of VMs
> that
> we can't tell apart, and cannot cope with in a compatible way.
> 
> ~Andrew
> 
> [1] Actually 3.  XenServer still has a revert of ca2eee92df44 in the
> patchqueue because that broke VMs which migrated across the point. 
> As
> it's from 2008, pre-and-post VMs aren't something we need to care
> about,
> because anyone still running Xen 3.3 has far bigger problems than
> this
> to worry about.
> 



From xen-devel-bounces@lists.xenproject.org Fri Oct 01 23:24:36 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Oct 2021 23:24:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.200838.355385 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mWRt4-0003Ar-Pd; Fri, 01 Oct 2021 23:24:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 200838.355385; Fri, 01 Oct 2021 23:24:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mWRt4-0003Ak-MH; Fri, 01 Oct 2021 23:24:18 +0000
Received: by outflank-mailman (input) for mailman id 200838;
 Fri, 01 Oct 2021 23:24:17 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=cSXX=OV=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1mWRt3-0003AY-CM
 for xen-devel@lists.xenproject.org; Fri, 01 Oct 2021 23:24:17 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id a7a4aa65-3f40-4177-a981-0562461300d5;
 Fri, 01 Oct 2021 23:24:16 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id F360C61AAB;
 Fri,  1 Oct 2021 23:24:14 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a7a4aa65-3f40-4177-a981-0562461300d5
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1633130655;
	bh=cQSyH4lur8SXtMu+/dsjdmdzaTeH2ijSyA9OTpNwYx0=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=ViyZ8aHNcW5LsbhXKJH76Qmje64yqQR/ntJJq00M4GJgxUGnUIKUCJwxI41TJWIHA
	 MSDPOZ6pFASyuJARsbrJO9e888AkAX49El5WumlTs5fgb7GI6tiJpHwhmfbM7HrC19
	 WBfB5ccgfPVGflXQMvruHGDlc64/hZeyjlqYwG+/w4sagCu8CWTBSwRz31PNWoZedu
	 x09w9Ym6IL+zRSegQ6qwBv5wt/TbjvG0MxHfE8Aa1cHurME0AJVZ8TQVvbvDNGzXNo
	 nphnOPcT++AkLJW958Vsd+TrvFKUigq46Ky+8TeLbz8ewV532YD6F5+lcz38YX3qBw
	 dDHTzWE3QKMOg==
Date: Fri, 1 Oct 2021 16:24:14 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Oleksandr <olekstysh@gmail.com>
cc: Jan Beulich <jbeulich@suse.com>, 
    Stefano Stabellini <sstabellini@kernel.org>, 
    xen-devel@lists.xenproject.org, 
    Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, 
    Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>, 
    Anthony PERARD <anthony.perard@citrix.com>, 
    Andrew Cooper <andrew.cooper3@citrix.com>, 
    George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>, 
    Juergen Gross <jgross@suse.com>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, 
    =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= <roger.pau@citrix.com>, 
    Bertrand.Marquis@arm.com
Subject: Re: [PATCH V4 1/3] xen: Introduce "gpaddr_bits" field to
 XEN_SYSCTL_physinfo
In-Reply-To: <bbbceae1-c382-5e48-0c6b-fbb23fc720f5@gmail.com>
Message-ID: <alpine.DEB.2.21.2110011244000.3209@sstabellini-ThinkPad-T480s>
References: <1632955927-27911-1-git-send-email-olekstysh@gmail.com> <1632955927-27911-2-git-send-email-olekstysh@gmail.com> <alpine.DEB.2.21.2109301600060.3209@sstabellini-ThinkPad-T480s> <05b040b0-a069-47a1-1f5e-85be62fa35f3@suse.com>
 <bbbceae1-c382-5e48-0c6b-fbb23fc720f5@gmail.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

Bertrand, see comment on ID_AA64MMFR0_EL1 below, any ideas?


On Fri, 1 Oct 2021, Oleksandr wrote:
> On 01.10.21 10:50, Jan Beulich wrote:
> > On 01.10.2021 01:00, Stefano Stabellini wrote:
> > > On Thu, 30 Sep 2021, Oleksandr Tyshchenko wrote:
> > > > From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> > > > 
> > > > We need to pass info about maximum supported guest address
> > > > space size to the toolstack on Arm in order to properly
> > > > calculate the base and size of the extended region (safe range)
> > > > for the guest. The extended region is unused address space which
> > > > could be safely used by domain for foreign/grant mappings on Arm.
> > > > The extended region itself will be handled by the subsequents
> > > > patch.
> > > > 
> > > > Use p2m_ipa_bits variable on Arm, the x86 equivalent is
> > > > hap_paddr_bits.
> > > > 
> > > > As we change the size of structure bump the interface version.
> > > > 
> > > > Suggested-by: Julien Grall <jgrall@amazon.com>
> > > > Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> > > > Reviewed-by: Michal Orzel <michal.orzel@arm.com>
> > > Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
> > I have to admit that I'm a little puzzled to see these R-b-s when ...
> > 
> > > > Please note, that review comments for the RFC version [1] haven't been
> > > > addressed yet.
> > > > It is not forgotten, some clarification is needed. It will be addressed
> > > > for the next version.
> > > > 
> > > > [1]
> > > > https://lore.kernel.org/xen-devel/973f5344-aa10-3ad6-ff02-ad5f358ad279@citrix.com/
> > ... Oleksandr makes clear this patch isn't really ready yet.
> 
> Unfortunately, this is true. I am still waiting for the clarification [1]

Although I was aware of comments to older versions, this is actually the
first version of this patch that I reviewed with any level of details; I
didn't read previous comments very closely. I tried to find any bugs or
problems with it and I couldn't see any, so I gave my reviewed-by. I
should have clarified that was meant for the ARM part as I don't have a
full understanding of the implications of using hap_paddr_bits on x86
for VM migration.


But let me take this opportunity to say that although I think the
hypercall is OK, I wish we didn't need this patch at all: it is
problematic because it touches tools, x86 and ARM hypervisor code all
together. It needs at least three acks/reviewed-by to get accepted: from
an x86 maintainer, an arm maintainer and from a tools maintainer. I
don't say this to criticize the patch acceptance process: this patch
makes changes to an existing hypercall so it is only fair that it needs
to go through extra levels of scrutiny. For the sake of simplicity and
decoupling (reducing dependencies between patches and between
components), I think it would be best to introduce an #define for the
minimum value of gpaddr_bits and then move this patch at the end of the
series; that way it becomes optional. Unfortunately the minimum value
is 32 (in practice I have never seen less than 40 but the architecture
supports 32 as minimum).


Actually, the info we are looking for is already exposed via
ID_AA64MMFR0_EL1. ID_AA64MMFR0_EL1 can be read from a virtual machine,
and Linux let userspace read it [1]. Regardless of this patch series, we
should make sure that Xen exposes the right mm64.pa_range value to guest
virtual machines. If that is done right, then you can just add support
for reading ID_AA64MMFR0_EL1 in libxl/libxc and then we don't need any
hypercall modifications changes.

So, in theory we already have all the interfaces we need, but in
practice they don't work: unfortunaly both Xen and Linux mark
ID_AA64MMFR0_EL1 as FTR_HIDDEN in cpufeature.c so neither Linux from
Xen, not userspace from Linux can actually read the real value :-/
They always read zero.

(Also I think we have an issue today with p2m_restrict_ipa_bits not
updating the mm64.pa_range value. I think that it should be fixed.)

Bertrand, do you have any ideas in regards to ID_AA64MMFR0_EL1?

If not, maybe we could just go with
#define MIN_GPADDR_BITS 32


[1] https://01.org/linuxgraphics/gfx-docs/drm/arm64/cpu-feature-registers.html


From xen-devel-bounces@lists.xenproject.org Fri Oct 01 23:29:35 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Oct 2021 23:29:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.200848.355396 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mWRy8-0003zh-Gp; Fri, 01 Oct 2021 23:29:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 200848.355396; Fri, 01 Oct 2021 23:29:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mWRy8-0003za-Du; Fri, 01 Oct 2021 23:29:32 +0000
Received: by outflank-mailman (input) for mailman id 200848;
 Fri, 01 Oct 2021 23:29:31 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=cSXX=OV=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1mWRy7-0003zU-6n
 for xen-devel@lists.xenproject.org; Fri, 01 Oct 2021 23:29:31 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id e8892f3f-e042-42ca-99d3-aeda4c89f371;
 Fri, 01 Oct 2021 23:29:30 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id 0037C6136A;
 Fri,  1 Oct 2021 23:29:28 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e8892f3f-e042-42ca-99d3-aeda4c89f371
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1633130969;
	bh=wO8clBFBjw27WMKhvHNDBxmZYXWEDLvSmp5JvSJ1cZo=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=gVVjg6/2qK1sRVbqgIM1iwzXFAYhL/ttaaOyRVQjwf8lkFrN/dhQuC+KEnz+EikdW
	 lWFY8xNMWJ/yY4afPfN5j4UW4w+v98GnBYe/HXDZMKn7BdHS+RBsme3/5MtYwDBqn/
	 rnGN1nc2G7pc0uZmgtTUulr9qEGV8rq/dRMXocaoEkID86rzpkchWmMx7D3lOyna7p
	 q2Nu/ReSukeL0nMSMPyQxVG39GN1QmY8ByICHwt87Fz5foMKbqo3Q0JkxMTva0dCpv
	 YGOb/dLxbQKnlQaJBiVGPMM0ccVt/YYxSHu4UyXXxIhOsUlMI5/AkavTt5zxJfSLBq
	 3BVwFAbY2oxiA==
Date: Fri, 1 Oct 2021 16:29:28 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Bertrand Marquis <Bertrand.Marquis@arm.com>
cc: Luca Fancellu <Luca.Fancellu@arm.com>, 
    Xen-devel <xen-devel@lists.xenproject.org>, Wei Chen <Wei.Chen@arm.com>, 
    Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, 
    Andrew Cooper <andrew.cooper3@citrix.com>, 
    George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>, 
    Jan Beulich <jbeulich@suse.com>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH v4 1/3] arm/efi: Introduce xen,uefi-cfg-load DT
 property
In-Reply-To: <0A3942A2-C668-4BDD-A1A0-D6EFD2738560@arm.com>
Message-ID: <alpine.DEB.2.21.2110011629170.3209@sstabellini-ThinkPad-T480s>
References: <20210930142846.13348-1-luca.fancellu@arm.com> <20210930142846.13348-2-luca.fancellu@arm.com> <0A3942A2-C668-4BDD-A1A0-D6EFD2738560@arm.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Thu, 30 Sep 2021, Bertrand Marquis wrote:
> Hi Luca,
> 
> > On 30 Sep 2021, at 15:28, Luca Fancellu <Luca.Fancellu@arm.com> wrote:
> > 
> > Introduce the xen,uefi-cfg-load DT property of /chosen
> > node for ARM whose presence decide whether to force
> > the load of the UEFI Xen configuration file.
> > 
> > The logic is that if any multiboot,module is found in
> > the DT, then the xen,uefi-cfg-load property is used to see
> > if the UEFI Xen configuration file is needed.
> > 
> > Modify a comment in efi_arch_use_config_file, removing
> > the part that states "dom0 required" because it's not
> > true anymore with this commit.
> > 
> > Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>
> > Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
> Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>

I committed this patch


> > ---
> > v4 changes:
> > - modify property name to xen,uefi-cfg-load
> > v3 changes:
> > - add documentation to misc/arm/device-tree/booting.txt
> > - Modified variable name and logic from skip_cfg_file to
> > load_cfg_file
> > - Add in the commit message that I'm modifying a comment.
> > v2 changes:
> > - Introduced uefi,cfg-load property
> > - Add documentation about the property
> > ---
> > docs/misc/arm/device-tree/booting.txt |  8 ++++++++
> > docs/misc/efi.pandoc                  |  2 ++
> > xen/arch/arm/efi/efi-boot.h           | 28 ++++++++++++++++++++++-----
> > 3 files changed, 33 insertions(+), 5 deletions(-)
> > 
> > diff --git a/docs/misc/arm/device-tree/booting.txt b/docs/misc/arm/device-tree/booting.txt
> > index 44cd9e1a9a..352b0ec43a 100644
> > --- a/docs/misc/arm/device-tree/booting.txt
> > +++ b/docs/misc/arm/device-tree/booting.txt
> > @@ -121,6 +121,14 @@ A Xen-aware bootloader would set xen,xen-bootargs for Xen, xen,dom0-bootargs
> > for Dom0 and bootargs for native Linux.
> > 
> > 
> > +UEFI boot and DT
> > +================
> > +
> > +When Xen is booted using UEFI, it doesn't read the configuration file if any
> > +multiboot module is specified. To force Xen to load the configuration file, the
> > +boolean property xen,uefi-cfg-load must be declared in the /chosen node.
> > +
> > +
> > Creating Multiple Domains directly from Xen
> > ===========================================
> > 
> > diff --git a/docs/misc/efi.pandoc b/docs/misc/efi.pandoc
> > index ac3cd58cae..ed85351541 100644
> > --- a/docs/misc/efi.pandoc
> > +++ b/docs/misc/efi.pandoc
> > @@ -14,6 +14,8 @@ loaded the modules and describes them in the device tree provided to Xen.  If a
> > bootloader provides a device tree containing modules then any configuration
> > files are ignored, and the bootloader is responsible for populating all
> > relevant device tree nodes.
> > +The property "xen,uefi-cfg-load" can be specified in the /chosen node to force
> > +Xen to load the configuration file even if multiboot modules are found.
> > 
> > Once built, `make install-xen` will place the resulting binary directly into
> > the EFI boot partition, provided `EFI_VENDOR` is set in the environment (and
> > diff --git a/xen/arch/arm/efi/efi-boot.h b/xen/arch/arm/efi/efi-boot.h
> > index cf9c37153f..a3e46453d4 100644
> > --- a/xen/arch/arm/efi/efi-boot.h
> > +++ b/xen/arch/arm/efi/efi-boot.h
> > @@ -581,22 +581,40 @@ static void __init efi_arch_load_addr_check(EFI_LOADED_IMAGE *loaded_image)
> > 
> > static bool __init efi_arch_use_config_file(EFI_SYSTEM_TABLE *SystemTable)
> > {
> > +    bool load_cfg_file = true;
> >     /*
> >      * For arm, we may get a device tree from GRUB (or other bootloader)
> >      * that contains modules that have already been loaded into memory.  In
> > -     * this case, we do not use a configuration file, and rely on the
> > -     * bootloader to have loaded all required modules and appropriate
> > -     * options.
> > +     * this case, we search for the property xen,uefi-cfg-load in the /chosen
> > +     * node to decide whether to skip the UEFI Xen configuration file or not.
> >      */
> > 
> >     fdt = lookup_fdt_config_table(SystemTable);
> >     dtbfile.ptr = fdt;
> >     dtbfile.need_to_free = false; /* Config table memory can't be freed. */
> > -    if ( !fdt || fdt_node_offset_by_compatible(fdt, 0, "multiboot,module") < 0 )
> > +
> > +    if ( fdt_node_offset_by_compatible(fdt, 0, "multiboot,module") > 0 )
> > +    {
> > +        /* Locate chosen node */
> > +        int node = fdt_subnode_offset(fdt, 0, "chosen");
> > +        const void *cfg_load_prop;
> > +        int cfg_load_len;
> > +
> > +        if ( node > 0 )
> > +        {
> > +            /* Check if xen,uefi-cfg-load property exists */
> > +            cfg_load_prop = fdt_getprop(fdt, node, "xen,uefi-cfg-load",
> > +                                        &cfg_load_len);
> > +            if ( !cfg_load_prop )
> > +                load_cfg_file = false;
> > +        }
> > +    }
> > +
> > +    if ( !fdt || load_cfg_file )
> >     {
> >         /*
> >          * We either have no FDT, or one without modules, so we must have a
> > -         * Xen EFI configuration file to specify modules.  (dom0 required)
> > +         * Xen EFI configuration file to specify modules.
> >          */
> >         return true;
> >     }
> > -- 
> > 2.17.1
> > 
> 


From xen-devel-bounces@lists.xenproject.org Fri Oct 01 23:58:27 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 01 Oct 2021 23:58:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.200858.355411 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mWSQ1-0007Me-R6; Fri, 01 Oct 2021 23:58:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 200858.355411; Fri, 01 Oct 2021 23:58:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mWSQ1-0007MX-Ng; Fri, 01 Oct 2021 23:58:21 +0000
Received: by outflank-mailman (input) for mailman id 200858;
 Fri, 01 Oct 2021 23:58:20 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=cSXX=OV=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1mWSQ0-0007MR-An
 for xen-devel@lists.xenproject.org; Fri, 01 Oct 2021 23:58:20 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id c96d8ed4-e3bd-4f4c-aee7-67e29258680b;
 Fri, 01 Oct 2021 23:58:19 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id 78ECB61AA4;
 Fri,  1 Oct 2021 23:58:17 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c96d8ed4-e3bd-4f4c-aee7-67e29258680b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1633132698;
	bh=jb0Rhb8NhJdRBN9XKZIK1XqwcZ8oGhony91KCCa0n6w=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=Dv25pNuQAMYUQ4NF2DoJdG95DbJsE1hGAbSHNIVi40JSIN0F7vzv4n14h/QfEJ6Jz
	 Tr4+vkBjaoxl/TYLf2D0pEs3ha2hC0DXxFPOX7tb/fTuzcxXJ/uklS3AfzJFr76wEt
	 DepVXEh2wSOyHNEstqO/dpBQPEDnOWKL4KZd9AXV6usQa2rRTeZPDeZbTf6nRGqWrk
	 6t/Nm4r2ujjXBXRdPBiWS4wJvuUU/EEtqDWTEfOhU+Wc/hihvvlFkwJFggeWSKcb8I
	 Blxxiyk/nbda5wr5FF1WizYyy9i68QPyveo7BIhq6SdlG5gd4QyeCff7bi1SSnJy+o
	 Syq/Jf4Ba0X+w==
Date: Fri, 1 Oct 2021 16:58:16 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Oleksandr Tyshchenko <olekstysh@gmail.com>
cc: Stefano Stabellini <sstabellini@kernel.org>, 
    xen-devel <xen-devel@lists.xenproject.org>, 
    Christopher Clark <christopher.w.clark@gmail.com>, 
    =?UTF-8?Q?Alex_Benn=C3=A9e?= <alex.bennee@linaro.org>, 
    =?UTF-8?Q?Marek_Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>, 
    Artem Mygaiev <Artem_Mygaiev@epam.com>, Sergio Lopez <slp@redhat.com>, 
    Wei Liu <wl@xen.org>, Stefan Hajnoczi <stefanha@gmail.com>, 
    Rust-VMM Mailing List <rust-vmm@lists.opendev.org>, 
    Doug Goldstein <cardoe@cardoe.com>, 
    Andrew Cooper <andrew.cooper3@citrix.com>, 
    Arnd Bergmann <arnd.bergmann@linaro.org>, 
    David Woodhouse <dwmw2@infradead.org>, 
    Stratos Mailing List <stratos-dev@op-lists.linaro.org>, 
    Rich Persaud <persaur@gmail.com>, 
    Daniel Smith <dpsmith@apertussolutions.com>, Paul Durrant <paul@xen.org>, 
    openxt <openxt@googlegroups.com>
Subject: Re: [Stratos-dev] Xen Rust VirtIO demos work breakdown for Project
 Stratos
In-Reply-To: <CAPD2p-=MdGB_a+oEsFrPQpLo7GeKkMwYyAWcQt3z0qrGr3vR7w@mail.gmail.com>
Message-ID: <alpine.DEB.2.21.2110011649220.3209@sstabellini-ThinkPad-T480s>
References: <87pmsylywy.fsf@linaro.org> <YU5mW396S04IsCBr@mail-itl> <874ka68h96.fsf@linaro.org> <CACMJ4GbgnQVQbH1N3Duxmx10n-Qv+zzncqarNyuhmKhE-wqdqA@mail.gmail.com> <alpine.DEB.2.21.2109272323160.5022@sstabellini-ThinkPad-T480s>
 <CAPD2p-=MdGB_a+oEsFrPQpLo7GeKkMwYyAWcQt3z0qrGr3vR7w@mail.gmail.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="8323329-1419400918-1633132698=:3209"

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-1419400918-1633132698=:3209
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT

On Tue, 28 Sep 2021, Oleksandr Tyshchenko wrote:
> On Tue, Sep 28, 2021 at 9:26 AM Stefano Stabellini <sstabellini@kernel.org> wrote:
> 
> Hi Stefano, all
> 
> [Sorry for the possible format issues]
> 
> 
>       On Mon, 27 Sep 2021, Christopher Clark wrote:
>       > On Mon, Sep 27, 2021 at 3:06 AM Alex Bennée via Stratos-dev <stratos-dev@op-lists.linaro.org> wrote:
>       >
>       >       Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com> writes:
>       >
>       >       > [[PGP Signed Part:Undecided]]
>       >       > On Fri, Sep 24, 2021 at 05:02:46PM +0100, Alex Bennée wrote:
>       >       >> Hi,
>       >       >
>       >       > Hi,
>       >       >
>       >       >> 2.1 Stable ABI for foreignmemory mapping to non-dom0 ([STR-57])
>       >       >> ───────────────────────────────────────────────────────────────
>       >       >>
>       >       >>   Currently the foreign memory mapping support only works for dom0 due
>       >       >>   to reference counting issues. If we are to support backends running in
>       >       >>   their own domains this will need to get fixed.
>       >       >>
>       >       >>   Estimate: 8w
>       >       >>
>       >       >>
>       >       >> [STR-57] <https://linaro.atlassian.net/browse/STR-57>
>       >       >
>       >       > I'm pretty sure it was discussed before, but I can't find relevant
>       >       > (part of) thread right now: does your model assumes the backend (running
>       >       > outside of dom0) will gain ability to map (or access in other way)
>       >       > _arbitrary_ memory page of a frontend domain? Or worse: any domain?
>       >
>       >       The aim is for some DomU's to host backends for other DomU's instead of
>       >       all backends being in Dom0. Those backend DomU's would have to be
>       >       considered trusted because as you say the default memory model of VirtIO
>       >       is to have full access to the frontend domains memory map.
>       >
>       >
>       > I share Marek's concern. I believe that there are Xen-based systems that will want to run guests using VirtIO devices without
>       extending
>       > this level of trust to the backend domains.
> 
>       >From a safety perspective, it would be challenging to deploy a system
>       with privileged backends. From a safety perspective, it would be a lot
>       easier if the backend were unprivileged.
> 
>       This is one of those times where safety and security requirements are
>       actually aligned.
> 
> 
> Well, the foreign memory mapping has one advantage in the context of Virtio use-case
> which is that Virtio infrastructure in Guest doesn't require any modifications to run on top Xen.
> The only issue with foreign memory here is that Guest memory actually mapped without its agreement
> which doesn't perfectly fit into the security model. (although there is one more issue with XSA-300,
> but I think it will go away sooner or later, at least there are some attempts to eliminate it).
> While the ability to map any part of Guest memory is not an issue for the backend running in Dom0
> (which we usually trust), this will certainly violate Xen security model if we want to run it in other
> domain, so I completely agree with the existing concern.

Yep, that's what I was referring to.


> It was discussed before [1], but I couldn't find any decisions regarding that. As I understand,
> the one of the possible ideas is to have some entity in Xen (PV IOMMU/virtio-iommu/whatever)
> that works in protection mode, so it denies all foreign mapping requests from the backend running in DomU
> by default and only allows requests with mapping which were *implicitly* granted by the Guest before.
> For example, Xen could be informed which MMIOs hold the queue PFN and notify registers
> (as it traps the accesses to these registers anyway) and could theoretically parse the frontend request
> and retrieve descriptors to make a decision which GFNs are actually *allowed*.
> 
> I can't say for sure (sorry not familiar enough with the topic), but implementing the virtio-iommu device
> in Xen we could probably avoid Guest modifications at all. Of course, for this to work
> the Virtio infrastructure in Guest should use DMA API as mentioned in [1].
> 
> Would the “restricted foreign mapping” solution retain the Xen security model and be accepted
> by the Xen community? I wonder, has someone already looked in this direction, are there any
> pitfalls here or is this even feasible?
> 
> [1] https://lore.kernel.org/xen-devel/464e91ec-2b53-2338-43c7-a018087fc7f6@arm.com/

The discussion that went further is actually one based on the idea that
there is a pre-shared memory area and the frontend always passes
addresses from it. For ease of implementation, the pre-shared area is
the virtqueue itself so this approach has been called "fat virtqueue".
But it requires guest modifications and it probably results in
additional memory copies.

I am not sure if the approach you mentioned could be implemented
completely without frontend changes. It looks like Xen would have to
learn how to inspect virtqueues in order to verify implicit grants
without frontend changes. With or without guest modifications, I am not
aware of anyone doing research and development on this approach.
--8323329-1419400918-1633132698=:3209--


From xen-devel-bounces@lists.xenproject.org Sat Oct 02 00:33:48 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 02 Oct 2021 00:33:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.200866.355423 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mWSy8-0003fJ-0P; Sat, 02 Oct 2021 00:33:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 200866.355423; Sat, 02 Oct 2021 00:33:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mWSy7-0003fC-Tg; Sat, 02 Oct 2021 00:33:35 +0000
Received: by outflank-mailman (input) for mailman id 200866;
 Sat, 02 Oct 2021 00:33:34 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=z3Fi=OW=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1mWSy6-0003es-3V
 for xen-devel@lists.xenproject.org; Sat, 02 Oct 2021 00:33:34 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 66040418-944d-470e-934b-bb327b10c45f;
 Sat, 02 Oct 2021 00:33:31 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id 26C9D61A51;
 Sat,  2 Oct 2021 00:33:29 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 66040418-944d-470e-934b-bb327b10c45f
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1633134809;
	bh=OtD5FJUAiMBFKGd12jsJ4zZobKJY86KNCZqevn/kxT4=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=sZZ3C/+TSiuzGgr41dofM3N7xdx0Z4oKtraGJOSEKKDYSsTa9QYtotiJxXxuk+M+3
	 iGSZzxJEI1wf1+6iVlGXrzY8wnnQnPB4C2wfAUX0cUxaLyN+s8PxwY18Y05rqHfS27
	 /aNl70ealNsKSrSuz3wCtKVTZKIlCurxeTMbQ/XdCFYE4HpdznVtpTtYf5g+vJX898
	 JybwsnK9tYN17Tr0F4anlJuBYnJkGX8b0ROyFdFG3J+JkDgXg1hQG8vFt0pe0HeFws
	 bzTfTJDfYtV3aqDui3Nmr8LwGUz9gQJSwQFQeRN5XwSSda81cxC81i12cRsiRUk5Tx
	 TW6ULTYYhdIYg==
Date: Fri, 1 Oct 2021 17:33:28 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Oleksandr Tyshchenko <olekstysh@gmail.com>
cc: xen-devel@lists.xenproject.org, 
    Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, 
    Andrew Cooper <andrew.cooper3@citrix.com>, 
    George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>, 
    Jan Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>, 
    Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH V4 2/3] xen/arm: Add handling of extended regions for
 Dom0
In-Reply-To: <1632955927-27911-3-git-send-email-olekstysh@gmail.com>
Message-ID: <alpine.DEB.2.21.2110011704350.3209@sstabellini-ThinkPad-T480s>
References: <1632955927-27911-1-git-send-email-olekstysh@gmail.com> <1632955927-27911-3-git-send-email-olekstysh@gmail.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Thu, 30 Sep 2021, Oleksandr Tyshchenko wrote:
> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> 
> The extended region (safe range) is a region of guest physical
> address space which is unused and could be safely used to create
> grant/foreign mappings instead of wasting real RAM pages from
> the domain memory for establishing these mappings.
> 
> The extended regions are chosen at the domain creation time and
> advertised to it via "reg" property under hypervisor node in
> the guest device-tree. As region 0 is reserved for grant table
> space (always present), the indexes for extended regions are 1...N.
> If extended regions could not be allocated for some reason,
> Xen doesn't fail and behaves as usual, so only inserts region 0.
> 
> Please note the following limitations:
> - The extended region feature is only supported for 64-bit domain
>   currently.
> - The ACPI case is not covered.
> 
> ***
> 
> As Dom0 is direct mapped domain on Arm (e.g. MFN == GFN)
> the algorithm to choose extended regions for it is different
> in comparison with the algorithm for non-direct mapped DomU.
> What is more, that extended regions should be chosen differently
> whether IOMMU is enabled or not.
> 
> Provide RAM not assigned to Dom0 if IOMMU is disabled or memory
> holes found in host device-tree if otherwise. Make sure that
> extended regions are 2MB-aligned and located within maximum possible
> addressable physical memory range. The minimum size of extended
> region is 64MB. The maximum number of extended regions is 128,
> which is an artificial limit to minimize code changes (we reuse
> struct meminfo to describe extended regions, so there are an array
> field for 128 elements).
> 
> It worth mentioning that unallocated memory solution (when the IOMMU
> is disabled) will work safely until Dom0 is able to allocate memory
> outside of the original range.
> 
> Also introduce command line option to be able to globally enable or
> disable support for extended regions for Dom0 (enabled by default).
> 
> Suggested-by: Julien Grall <jgrall@amazon.com>
> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>

I thought about it and I decided to commit this patch because it doesn't
actually need anything from the other two patches, and it is very useful
on its own (both of them are for domU, while this one is for dom0).

In regards to Julien's suggestion: as explained in earlier emails I
prefer this version but I don't have a strong opinion. If Julien still
prefers the other approach we can still change it in time for 4.16
(Oleksandr has already implemented both and I am happy to review.)


> ---
> Please note, we need to decide which approach to use in find_unallocated_memory(),
> you can find details at:
> https://lore.kernel.org/xen-devel/28503e09-44c3-f623-bb8d-8778bb94225f@gmail.com/
> 
> Changes RFC -> V2:
>    - update patch description
>    - drop uneeded "extended-region" DT property
> 
> Changes V2 -> V3:
>    - update patch description
>    - add comment for "size" calculation in add_ext_regions()
>    - clarify "end" calculation in find_unallocated_memory() and
>      find_memory_holes()
>    - only pick up regions with size >= 64MB
>    - allocate reg dynamically instead of keeping on the stack in
>      make_hypervisor_node()
>    - do not show warning for 32-bit domain
>    - drop Linux specific limits EXT_REGION_*
>    - also cover "ranges" property in find_memory_holes()
>    - add command line arg to enable/disable extended region support
> 
> Changes V3 -> V4:
>   - update opt_ext_regions purpose and comment in code
>   - reorganize make_hypervisor_node() to move allocations after initial
>     checks, allocate only required amount of elements instead of maximum
>     possible
> ---
>  docs/misc/xen-command-line.pandoc |  11 ++
>  xen/arch/arm/domain_build.c       | 286 +++++++++++++++++++++++++++++++++++++-
>  2 files changed, 294 insertions(+), 3 deletions(-)
> 
> diff --git a/docs/misc/xen-command-line.pandoc b/docs/misc/xen-command-line.pandoc
> index 177e656..5cae4ad 100644
> --- a/docs/misc/xen-command-line.pandoc
> +++ b/docs/misc/xen-command-line.pandoc
> @@ -1081,6 +1081,17 @@ hardware domain is architecture dependent.
>  Note that specifying zero as domU value means zero, while for dom0 it means
>  to use the default.
>  
> +### ext_regions (Arm)
> +> `= <boolean>`
> +
> +> Default : `true`
> +
> +Flag to enable or disable support for extended regions for Dom0.
> +
> +Extended regions are ranges of unused address space exposed to Dom0 as
> +"safe to use" for special memory mappings. Disable if your board device
> +tree is incomplete.
> +
>  ### flask
>  > `= permissive | enforcing | late | disabled`
>  
> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
> index d233d63..c5afbe2 100644
> --- a/xen/arch/arm/domain_build.c
> +++ b/xen/arch/arm/domain_build.c
> @@ -34,6 +34,10 @@
>  static unsigned int __initdata opt_dom0_max_vcpus;
>  integer_param("dom0_max_vcpus", opt_dom0_max_vcpus);
>  
> +/* If true, the extended regions support is enabled for dom0 */
> +static bool __initdata opt_ext_regions = true;
> +boolean_param("ext_regions", opt_ext_regions);
> +
>  static u64 __initdata dom0_mem;
>  static bool __initdata dom0_mem_set;
>  
> @@ -886,6 +890,232 @@ static int __init make_memory_node(const struct domain *d,
>      return res;
>  }
>  
> +static int __init add_ext_regions(unsigned long s, unsigned long e, void *data)
> +{
> +    struct meminfo *ext_regions = data;
> +    paddr_t start, size;
> +
> +    if ( ext_regions->nr_banks >= ARRAY_SIZE(ext_regions->bank) )
> +        return 0;
> +
> +    /* Both start and size of the extended region should be 2MB aligned */
> +    start = (s + SZ_2M - 1) & ~(SZ_2M - 1);
> +    if ( start > e )
> +        return 0;
> +
> +    /*
> +     * e is actually "end-1" because it is called by rangeset functions
> +     * which are inclusive of the last address.
> +     */
> +    e += 1;
> +    size = (e - start) & ~(SZ_2M - 1);
> +    if ( size < MB(64) )
> +        return 0;
> +
> +    ext_regions->bank[ext_regions->nr_banks].start = start;
> +    ext_regions->bank[ext_regions->nr_banks].size = size;
> +    ext_regions->nr_banks++;
> +
> +    return 0;
> +}
> +
> +static int __init find_unallocated_memory(const struct kernel_info *kinfo,
> +                                          struct meminfo *ext_regions)
> +{
> +    const struct meminfo *assign_mem = &kinfo->mem;
> +    struct rangeset *unalloc_mem;
> +    paddr_t start, end;
> +    unsigned int i;
> +    int res;
> +
> +    dt_dprintk("Find unallocated memory for extended regions\n");
> +
> +    unalloc_mem = rangeset_new(NULL, NULL, 0);
> +    if ( !unalloc_mem )
> +        return -ENOMEM;
> +
> +    /* Start with all available RAM */
> +    for ( i = 0; i < bootinfo.mem.nr_banks; i++ )
> +    {
> +        start = bootinfo.mem.bank[i].start;
> +        end = bootinfo.mem.bank[i].start + bootinfo.mem.bank[i].size;
> +        res = rangeset_add_range(unalloc_mem, start, end - 1);
> +        if ( res )
> +        {
> +            printk(XENLOG_ERR "Failed to add: %#"PRIx64"->%#"PRIx64"\n",
> +                   start, end);
> +            goto out;
> +        }
> +    }
> +
> +    /* Remove RAM assigned to Dom0 */
> +    for ( i = 0; i < assign_mem->nr_banks; i++ )
> +    {
> +        start = assign_mem->bank[i].start;
> +        end = assign_mem->bank[i].start + assign_mem->bank[i].size;
> +        res = rangeset_remove_range(unalloc_mem, start, end - 1);
> +        if ( res )
> +        {
> +            printk(XENLOG_ERR "Failed to remove: %#"PRIx64"->%#"PRIx64"\n",
> +                   start, end);
> +            goto out;
> +        }
> +    }
> +
> +    /* Remove reserved-memory regions */
> +    for ( i = 0; i < bootinfo.reserved_mem.nr_banks; i++ )
> +    {
> +        start = bootinfo.reserved_mem.bank[i].start;
> +        end = bootinfo.reserved_mem.bank[i].start +
> +            bootinfo.reserved_mem.bank[i].size;
> +        res = rangeset_remove_range(unalloc_mem, start, end - 1);
> +        if ( res )
> +        {
> +            printk(XENLOG_ERR "Failed to remove: %#"PRIx64"->%#"PRIx64"\n",
> +                   start, end);
> +            goto out;
> +        }
> +    }
> +
> +    /* Remove grant table region */
> +    start = kinfo->gnttab_start;
> +    end = kinfo->gnttab_start + kinfo->gnttab_size;
> +    res = rangeset_remove_range(unalloc_mem, start, end - 1);
> +    if ( res )
> +    {
> +        printk(XENLOG_ERR "Failed to remove: %#"PRIx64"->%#"PRIx64"\n",
> +               start, end);
> +        goto out;
> +    }
> +
> +    start = 0;
> +    end = (1ULL << p2m_ipa_bits) - 1;
> +    res = rangeset_report_ranges(unalloc_mem, start, end,
> +                                 add_ext_regions, ext_regions);
> +    if ( res )
> +        ext_regions->nr_banks = 0;
> +    else if ( !ext_regions->nr_banks )
> +        res = -ENOENT;
> +
> +out:
> +    rangeset_destroy(unalloc_mem);
> +
> +    return res;
> +}
> +
> +static int __init find_memory_holes(const struct kernel_info *kinfo,
> +                                    struct meminfo *ext_regions)
> +{
> +    struct dt_device_node *np;
> +    struct rangeset *mem_holes;
> +    paddr_t start, end;
> +    unsigned int i;
> +    int res;
> +
> +    dt_dprintk("Find memory holes for extended regions\n");
> +
> +    mem_holes = rangeset_new(NULL, NULL, 0);
> +    if ( !mem_holes )
> +        return -ENOMEM;
> +
> +    /* Start with maximum possible addressable physical memory range */
> +    start = 0;
> +    end = (1ULL << p2m_ipa_bits) - 1;
> +    res = rangeset_add_range(mem_holes, start, end);
> +    if ( res )
> +    {
> +        printk(XENLOG_ERR "Failed to add: %#"PRIx64"->%#"PRIx64"\n",
> +               start, end);
> +        goto out;
> +    }
> +
> +    /*
> +     * Remove regions described by "reg" and "ranges" properties where
> +     * the memory is addressable (MMIO, RAM, PCI BAR, etc).
> +     */
> +    dt_for_each_device_node( dt_host, np )
> +    {
> +        unsigned int naddr;
> +        u64 addr, size;
> +
> +        naddr = dt_number_of_address(np);
> +
> +        for ( i = 0; i < naddr; i++ )
> +        {
> +            res = dt_device_get_address(np, i, &addr, &size);
> +            if ( res )
> +            {
> +                printk(XENLOG_ERR "Unable to retrieve address %u for %s\n",
> +                       i, dt_node_full_name(np));
> +                goto out;
> +            }
> +
> +            start = addr & PAGE_MASK;
> +            end = PAGE_ALIGN(addr + size);
> +            res = rangeset_remove_range(mem_holes, start, end - 1);
> +            if ( res )
> +            {
> +                printk(XENLOG_ERR "Failed to remove: %#"PRIx64"->%#"PRIx64"\n",
> +                       start, end);
> +                goto out;
> +            }
> +        }
> +
> +        if ( dt_device_type_is_equal(np, "pci" ) )
> +        {
> +            unsigned int range_size, nr_ranges;
> +            int na, ns, pna;
> +            const __be32 *ranges;
> +            u32 len;
> +
> +            /*
> +             * Looking for non-empty ranges property which in this context
> +             * describes the PCI host bridge aperture.
> +             */
> +            ranges = dt_get_property(np, "ranges", &len);
> +            if ( !ranges || !len )
> +                continue;
> +
> +            pna = dt_n_addr_cells(np);
> +            na = dt_child_n_addr_cells(np);
> +            ns = dt_child_n_size_cells(np);
> +            range_size = pna + na + ns;
> +            nr_ranges = len / sizeof(__be32) / range_size;
> +
> +            for ( i = 0; i < nr_ranges; i++, ranges += range_size )
> +            {
> +                /* Skip the child address and get the parent (CPU) address */
> +                addr = dt_read_number(ranges + na, pna);
> +                size = dt_read_number(ranges + na + pna, ns);
> +
> +                start = addr & PAGE_MASK;
> +                end = PAGE_ALIGN(addr + size);
> +                res = rangeset_remove_range(mem_holes, start, end - 1);
> +                if ( res )
> +                {
> +                    printk(XENLOG_ERR "Failed to remove: %#"PRIx64"->%#"PRIx64"\n",
> +                           start, end);
> +                    goto out;
> +                }
> +            }
> +        }
> +    }
> +
> +    start = 0;
> +    end = (1ULL << p2m_ipa_bits) - 1;
> +    res = rangeset_report_ranges(mem_holes, start, end,
> +                                 add_ext_regions,  ext_regions);
> +    if ( res )
> +        ext_regions->nr_banks = 0;
> +    else if ( !ext_regions->nr_banks )
> +        res = -ENOENT;
> +
> +out:
> +    rangeset_destroy(mem_holes);
> +
> +    return res;
> +}
> +
>  static int __init make_hypervisor_node(struct domain *d,
>                                         const struct kernel_info *kinfo,
>                                         int addrcells, int sizecells)
> @@ -893,11 +1123,12 @@ static int __init make_hypervisor_node(struct domain *d,
>      const char compat[] =
>          "xen,xen-"__stringify(XEN_VERSION)"."__stringify(XEN_SUBVERSION)"\0"
>          "xen,xen";
> -    __be32 reg[4];
> +    __be32 *reg, *cells;
>      gic_interrupt_t intr;
> -    __be32 *cells;
>      int res;
>      void *fdt = kinfo->fdt;
> +    struct meminfo *ext_regions = NULL;
> +    unsigned int i, nr_ext_regions;
>  
>      dt_dprintk("Create hypervisor node\n");
>  
> @@ -919,12 +1150,61 @@ static int __init make_hypervisor_node(struct domain *d,
>      if ( res )
>          return res;
>  
> +    if ( !opt_ext_regions )
> +    {
> +        printk(XENLOG_DEBUG "The extended regions support is disabled\n");
> +        nr_ext_regions = 0;
> +    }
> +    else if ( is_32bit_domain(d) )
> +    {
> +        printk(XENLOG_DEBUG "The extended regions are only supported for 64-bit guest currently\n");
> +        nr_ext_regions = 0;
> +    }
> +    else
> +    {
> +        ext_regions = xzalloc(struct meminfo);
> +        if ( !ext_regions )
> +            return -ENOMEM;
> +
> +        if ( !is_iommu_enabled(d) )
> +            res = find_unallocated_memory(kinfo, ext_regions);
> +        else
> +            res = find_memory_holes(kinfo, ext_regions);
> +
> +        if ( res )
> +            printk(XENLOG_WARNING "Failed to allocate extended regions\n");
> +        nr_ext_regions = ext_regions->nr_banks;
> +    }
> +
> +    reg = xzalloc_array(__be32, (nr_ext_regions + 1) * (addrcells + sizecells));
> +    if ( !reg )
> +    {
> +        xfree(ext_regions);
> +        return -ENOMEM;
> +    }
> +
>      /* reg 0 is grant table space */
>      cells = &reg[0];
>      dt_child_set_range(&cells, addrcells, sizecells,
>                         kinfo->gnttab_start, kinfo->gnttab_size);
> +    /* reg 1...N are extended regions */
> +    for ( i = 0; i < nr_ext_regions; i++ )
> +    {
> +        u64 start = ext_regions->bank[i].start;
> +        u64 size = ext_regions->bank[i].size;
> +
> +        dt_dprintk("Extended region %d: %#"PRIx64"->%#"PRIx64"\n",
> +                   i, start, start + size);
> +
> +        dt_child_set_range(&cells, addrcells, sizecells, start, size);
> +    }
> +
>      res = fdt_property(fdt, "reg", reg,
> -                       dt_cells_to_size(addrcells + sizecells));
> +                       dt_cells_to_size(addrcells + sizecells) *
> +                       (nr_ext_regions + 1));
> +    xfree(ext_regions);
> +    xfree(reg);
> +
>      if ( res )
>          return res;
>  
> -- 
> 2.7.4
> 


From xen-devel-bounces@lists.xenproject.org Sat Oct 02 00:34:11 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 02 Oct 2021 00:34:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.200873.355434 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mWSyh-0004GO-E5; Sat, 02 Oct 2021 00:34:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 200873.355434; Sat, 02 Oct 2021 00:34:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mWSyh-0004GH-Ak; Sat, 02 Oct 2021 00:34:11 +0000
Received: by outflank-mailman (input) for mailman id 200873;
 Sat, 02 Oct 2021 00:34:10 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=zBmR=OW=oracle.com=boris.ostrovsky@srs-us1.protection.inumbo.net>)
 id 1mWSyg-0004Ed-5w
 for xen-devel@lists.xenproject.org; Sat, 02 Oct 2021 00:34:10 +0000
Received: from mx0a-00069f02.pphosted.com (unknown [205.220.165.32])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 5693e26b-53ea-4a43-b5e4-50c86a46635e;
 Sat, 02 Oct 2021 00:34:07 +0000 (UTC)
Received: from pps.filterd (m0246627.ppops.net [127.0.0.1])
 by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 191NcfNj015729; 
 Sat, 2 Oct 2021 00:34:05 GMT
Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71])
 by mx0b-00069f02.pphosted.com with ESMTP id 3be440kdh6-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Sat, 02 Oct 2021 00:34:05 +0000
Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1])
 by aserp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 1920VMTD140459;
 Sat, 2 Oct 2021 00:34:04 GMT
Received: from nam11-co1-obe.outbound.protection.outlook.com
 (mail-co1nam11lp2171.outbound.protection.outlook.com [104.47.56.171])
 by aserp3030.oracle.com with ESMTP id 3bd5wdcpff-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Sat, 02 Oct 2021 00:34:04 +0000
Received: from BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10)
 by BL0PR10MB3443.namprd10.prod.outlook.com (2603:10b6:208:74::26)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.15; Sat, 2 Oct
 2021 00:34:02 +0000
Received: from BLAPR10MB5009.namprd10.prod.outlook.com
 ([fe80::3c49:46aa:83e1:a329]) by BLAPR10MB5009.namprd10.prod.outlook.com
 ([fe80::3c49:46aa:83e1:a329%5]) with mapi id 15.20.4566.019; Sat, 2 Oct 2021
 00:34:02 +0000
Received: from [10.74.98.147] (160.34.88.147) by
 SN7PR04CA0173.namprd04.prod.outlook.com (2603:10b6:806:125::28) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.15 via Frontend
 Transport; Sat, 2 Oct 2021 00:34:01 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5693e26b-53ea-4a43-b5e4-50c86a46635e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc :
 references : from : message-id : date : in-reply-to : content-type :
 content-transfer-encoding : mime-version; s=corp-2021-07-09;
 bh=Il7X1neTcjDAsgJXlsMa3DeMdWggDdEomMiTzBSgJRc=;
 b=FXjGROCV3bOH+ACz655PhqADcoOAGQwSy3AsCE4zCqi7YoeIoX/kDLah3ikudpL9sWlj
 2xKXyOW6Ic82+BmEWwWl2bGtsRIkwB32j5f74GICYlJB0d1ITHIAdOWCRpkVKYe4riR+
 GJbOVGO46vgEEGUM6dFL/UigVR/es7XW8jAYpUL+K5ZKcNKzbPJKbtQv2DqYXWa5oF3x
 JFyhmfWouPu/3D7F+enRuqShUm9MGUysU77aLkR9yV928ZyUtGCYwo3gDH/Ay2phYRGH
 ZIdZtq1DT+5morcgfLbaAkb5mryIZyZRaSLZcXqvgjWzGo7wKpJdi0esdUBQniEv0btl Pg== 
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=CxGQ1+uDLGEAL5uwt/NG4Vkq/mB+XXmJokTqLKyoL9HeQlOTXGiJGuw6Zv5lVP8HVz3yvGTuyy/PD+G9FRrSRTynfX9N9L833n03RNfTWH3Lk7XKCiTDW2eOl35BAurAxQfs109759LOm1zfHFX0LZQikXbj4iqYFGXnTlQ+WqYSK4cICPuMKUg9bMHS87EMRx415eF35CUw1xh133hqjNfo3KCvHw3O1yhnjf9MJPQzAu8+ksdDlETMsW51EpnVekBQtEahse61FvxaWRulEnYp4x4fT89kbVfWGKQVXBTs1eYvDYOpEf1STph/egZTxUXvc7brrIeuv6FmsenQlA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Il7X1neTcjDAsgJXlsMa3DeMdWggDdEomMiTzBSgJRc=;
 b=j8LgZR5agCSqYXbKc9Tl5iwbB37K3QyriQjwWJ0Ux1NGKRzW0RnN9OERzAEAG5Rt64/HDFbsJIutqASP1krsncc8g4Ecm/nL3L5jXa5bC7xptEcUeNbGtdX6MHkH1wWY0G0JmQ1/X6/E1feSaiuFP6HxN6vcPnSychdRGCauvkQa/8nS+zLQ4rACdQrpXyYLn29zNvfKZHzSY6IZV65Bmo/MXQOEDu6sY9W3MtbP9668CggYVHXitBFFovHooGTUgjh2HwipqyQd9ZpMv5mTxEQUqs3mnVYGJZ/guKgMFUaPPwAo6BAeOq/ku+OXrfOC8XxQEIzYOTJKp2a9F12X/g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com;
 dkim=pass header.d=oracle.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Il7X1neTcjDAsgJXlsMa3DeMdWggDdEomMiTzBSgJRc=;
 b=CAISp9nWcYaQuu1ebMqltZammNQ+8OmfgxwlOKy3E8ESzOErypzeUYBENcL+X4MQUbdNpRe/ovfbmNtPvTsvef1dEvVX66J+XHCXjU6c7I4rNe4x8nPA9FothskBl3mZ+YNJpEeG/DIAvconf4BZC8kkoYJmLODqYiMocSEA5rM=
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=oracle.com;
Subject: Re: [PATCH 0/6] xen/x86: PV boot speedup
To: Jan Beulich <jbeulich@suse.com>, Juergen Gross <jgross@suse.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
        lkml <linux-kernel@vger.kernel.org>,
        "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <022b1a5e-4121-6bae-f07c-4ad5eac12481@suse.com>
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Message-ID: <9f49ecdb-26d3-c38d-56a4-8425a567bf0d@oracle.com>
Date: Fri, 1 Oct 2021 20:33:58 -0400
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0)
 Gecko/20100101 Thunderbird/78.14.0
In-Reply-To: <022b1a5e-4121-6bae-f07c-4ad5eac12481@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Content-Language: en-US
X-ClientProxiedBy: SN7PR04CA0173.namprd04.prod.outlook.com
 (2603:10b6:806:125::28) To BLAPR10MB5009.namprd10.prod.outlook.com
 (2603:10b6:208:321::10)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: c5c4f0f2-ed71-4f91-2388-08d9853c5504
X-MS-TrafficTypeDiagnostic: BL0PR10MB3443:
X-Microsoft-Antispam-PRVS: 
	<BL0PR10MB34433E0FF0FD37CD12A8A29A8AAC9@BL0PR10MB3443.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7219;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 
	lJqn8tVqEuRpvueDBVRI4RJlLtZrnwH2ejGbtLim8pdQm0M70KrpIPQeFerjG0loNpi02OAgIYOoadw1SQ0cwRQl9qMa3VOqzh7acPlwCj+V7FYtp7QrU9DfuR0Owyrg5brZZrNJbhFPc0Y8Xy/DqxnOWLgDWO9jWvuAuSIHtNSMfQRxYm8V82d4F5U5E5pzwe6tkNyAxQDp+08iiVqAKolxxQ7U76/XXdJRaDHxdaagmKBWrxSD1J+w8c8tudA+JHdBC0XYnKd4Qxsi4ZIzBpJaooIPpDkpHGXz7mIUDC/S4SQ7jrgUuEkIWpV7cWnsIHs8r/X6zNRV/qGzf24lkynYr36MRetZF5C1IjbDBtfxNaSmNS2J+H0xMEi8d/fNaD4FDy0UZm8JfsaRIK7qLxMB7ArXDaYXLec0+dzIgQPIz7i4vkqgXx5SeQau3ZKHe1PfOcJuBKK3ZesQTF6pG7FqKhJ2ABOAdC+JyEj2750jl8sczHSPw1Pf4D6zA6KZmpArMTt+r4wh8CUDqUpjdxqwUOcsCqCY5gsh5a6AEUKJmypp8/sV62oHD4YaSF5IfaOOTd/Vu4OrdWZHcivciI+stmTlk1vlpcnUOsKobUNZcgLAXPi7bz46sKthY3p10kXQ/2BifHSCuIiURYqZTS7Gbsk/n7jcc3152j7IX2MQtkiZ/6RP43Ea4jcYmTNYjZ2wdrGh6GAsFujn5MDQ9KX/wZUWBRHnKtde7NEqiwU=
X-Forefront-Antispam-Report: 
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB5009.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(31686004)(66556008)(8676002)(66476007)(66946007)(186003)(508600001)(86362001)(6666004)(4744005)(4326008)(26005)(54906003)(110136005)(36756003)(16576012)(8936002)(5660300002)(83380400001)(2906002)(316002)(53546011)(2616005)(956004)(38100700002)(31696002)(44832011)(6486002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?bWJDenUzY2U4Q1FOQ0pBVjVHeG9hQUhLYU9qa2h2UGxwZHZsRWFIaUN5RzdL?=
 =?utf-8?B?aG9oQm9zanQvSHVjblluaHJjMTdmdEpsWXdvL1gxVCtjMjlHUTd0eTNiazB1?=
 =?utf-8?B?TklPdHJoUktucWpUQ2Vab0tmN2dwRk1Db2VLSnB1SHRHMXloUkh5NGlxc2No?=
 =?utf-8?B?amR6c3Ivdk03MzVYcStDS0hYemE5K0krdkRMbzBDNklVSllVNWU1Y0JUKzdS?=
 =?utf-8?B?U2paNTB3cUNsSnpGN3N6T2wreFdCUldnTWVOcVhreW11L3VHaVE4T21pdmdM?=
 =?utf-8?B?VFZWQm9JVXA0VXM1R1VXSFE4ZWFQNmYzeDV5bllqcno0cnovYjNOZ2hJTlNZ?=
 =?utf-8?B?Y1IzQ0FteW9GRjZNMXB2bHZ6NUVJdDA4M0ljYTFNb0xlOExTSEhjVUIzVlk0?=
 =?utf-8?B?cDdpOXNKL0crNFBndHE2SmE3d1cxTHhBN0lCMEkvVHdVbFJMQXVLQ3A5VHNa?=
 =?utf-8?B?VjhEcE9yUm9BMlVGcGVseEtqaTRXbytEdWZ1Yi8rMWlFTkxiR2RBdnArc05h?=
 =?utf-8?B?ZU43aVBQNWtEZEdreDBRY1BDU0plV29Bd1Y4T2hhZnptcVBEU0JtM1I3anB1?=
 =?utf-8?B?OGVzb1NaTVBUV2pOYW9zb2ZMVnZJTWRGb2RKa0EzczRybHFFbzQxaER4dkFC?=
 =?utf-8?B?YStVNTdDelp5ejdxcDA2aDlPVlFWUnVPTElTZHkwNFpIZ0hJYk42d0Q1TndZ?=
 =?utf-8?B?TG81c0hydytTSlJtdkc5UnNsOVZyeFQyUGc4MWhhSTdzRnlGZmdMNjdiVEFM?=
 =?utf-8?B?ZEVPV2VTYjYvNk8rNDBXNWNYWHpsSDVMOCtydFEwR3JzVEQrTmRtYS9FMzZX?=
 =?utf-8?B?WitlcFM2RnFtdHVBNnZ6VFI0ZHpxVmJHM1VVNWErMVV2UFIwQ05zZW9hOTVn?=
 =?utf-8?B?cWl6TTNzUFo1Z3hESHhwY2lwRUlxU3NSZ0t2MUxTc1VOakdJRWxVUzJ0TXhO?=
 =?utf-8?B?L3NYVElERXJZall1YWVqWEQ2U042YlBVV0FCcHFORFJGYWJGOXpiMnJHRnoz?=
 =?utf-8?B?NDhpS2xabUJvMDRyWDZJK3dXZmJCemNONEg5S0ZJa3R2dTJPMnp6dnRaQVFz?=
 =?utf-8?B?UjhWZk1JWGhhaUNXSEhuMlcxakxTSkN4cncyekljWDFhU1VWR05SeUlqS2Fr?=
 =?utf-8?B?eTF3U3kwYlFwS0tmRlhHMU1RK0c3YWlSRzZoaWtvdjUxbWdJVktLaUtDUk41?=
 =?utf-8?B?T1ZyWHNtT1QvL3M5TG5uRnlmZjNFY0xGRjBQWFo1WktLWi93cUFmOVZoRHVo?=
 =?utf-8?B?aTg3K3gyTE93dEdnSkdVZ0I3bFZPZTcvcGdwZjB6M2p3MzBsK0RDNUdUZmFU?=
 =?utf-8?B?QkJJNUpuU2xuZ2FoUWhKMXZ1ZVBhVDMzN2V0S3pkWVk1R0J5YnplTjl3L3Zu?=
 =?utf-8?B?MGYrMloxZ1BaWDE5a1RCbnFiV01kUVlMYTUrOFhhV0Q1ZTJSMHkwMFlKSk50?=
 =?utf-8?B?bU5qSFQ0cE5FSFN1NmRmUmJkdk5qeEVuYUQ0bDVOMlJVVDRrbGFMbmRLWXVm?=
 =?utf-8?B?NEp3TGVrZnBkOEFGM2N3dE9rZlpOQmtveFl3WXIzdjdBNjNkNDFQdHpJbGQ0?=
 =?utf-8?B?MUFBdGloSHJySFBZWVhLUG0vdnRUcXNReEZHUy9jOTRCT2FGekhUOGVzclVh?=
 =?utf-8?B?Ym1XZ21PMGlNZVJVY2N3dVU1T2hKYlMwTDUvSmFWYlUyUU1zMHhrWmxzR3BM?=
 =?utf-8?B?ZHZ0SlZ2MHRSY1NyRVVzbFVZNjVyZVA4alp2S2ZSaTF4aWh4Z3M3ZlhUbnlw?=
 =?utf-8?Q?AJBaEqVJcN0JctzioJVFkwmonYSDEu17OA+Z4pF?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c5c4f0f2-ed71-4f91-2388-08d9853c5504
X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Oct 2021 00:34:02.2414
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: HYe+sSBSRPnhQHGXObjEvBujmY0RVJiHWgBUdMJr+/Z5oCc8a0/QI/zQgFOcj8S3Nu89DHjlGemQEoLEmejK2zCFKYyQ5SyE1cTm4Wq6B90=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR10MB3443
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10124 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 phishscore=0 malwarescore=0
 suspectscore=0 spamscore=0 mlxlogscore=999 bulkscore=0 adultscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109230001
 definitions=main-2110020000
X-Proofpoint-ORIG-GUID: Gz9AbWBCSqxz8FxFYc1rCVUBPlNW0MQy
X-Proofpoint-GUID: Gz9AbWBCSqxz8FxFYc1rCVUBPlNW0MQy


On 9/30/21 8:33 AM, Jan Beulich wrote:
> The observed (by the human eye) performance difference of early boot
> between native and PV-on-Xen was just too large to not look into. As
> it turns out, gaining performance back wasn't all that difficult.
>
> While the series (re)introduces a small number of PTWR emulations on
> the boot path (from phys_pte_init()), there has been a much larger
> number of them post-boot. Hence I think if this was of concern, the
> post-boot instances would want eliminating first.
>
> Some of the later changes aren'r directly related to the main goal of
> the series; these address aspects noticed while doing the investigation.
>
> 1: streamline set_pte_mfn()
> 2: restore (fix) xen_set_pte_init() behavior
> 3: adjust xen_set_fixmap()
> 4: adjust handling of the L3 user vsyscall special page table
> 5: there's no highmem anymore in PV mode
> 6: restrict PV Dom0 identity mapping



For the series:


Reviewed-by: Boris Ostrovsky <boris.ostrovksy@oracle.com>



From xen-devel-bounces@lists.xenproject.org Sat Oct 02 00:41:31 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 02 Oct 2021 00:41:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.200884.355445 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mWT5k-0005nc-6q; Sat, 02 Oct 2021 00:41:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 200884.355445; Sat, 02 Oct 2021 00:41:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mWT5k-0005nV-38; Sat, 02 Oct 2021 00:41:28 +0000
Received: by outflank-mailman (input) for mailman id 200884;
 Sat, 02 Oct 2021 00:41:27 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=zBmR=OW=oracle.com=boris.ostrovsky@srs-us1.protection.inumbo.net>)
 id 1mWT5j-0005nP-6q
 for xen-devel@lists.xenproject.org; Sat, 02 Oct 2021 00:41:27 +0000
Received: from mx0a-00069f02.pphosted.com (unknown [205.220.165.32])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 38c8f25f-2063-469c-955e-2fac1e3377c3;
 Sat, 02 Oct 2021 00:41:25 +0000 (UTC)
Received: from pps.filterd (m0246629.ppops.net [127.0.0.1])
 by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 19200osO012501; 
 Sat, 2 Oct 2021 00:41:24 GMT
Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80])
 by mx0b-00069f02.pphosted.com with ESMTP id 3bdevvj1bb-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Sat, 02 Oct 2021 00:41:23 +0000
Received: from pps.filterd (userp3030.oracle.com [127.0.0.1])
 by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 1920eYUZ069980;
 Sat, 2 Oct 2021 00:41:22 GMT
Received: from nam12-bn8-obe.outbound.protection.outlook.com
 (mail-bn8nam12lp2177.outbound.protection.outlook.com [104.47.55.177])
 by userp3030.oracle.com with ESMTP id 3bechsgtmh-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Sat, 02 Oct 2021 00:41:22 +0000
Received: from BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10)
 by BL0PR10MB2835.namprd10.prod.outlook.com (2603:10b6:208:31::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.17; Sat, 2 Oct
 2021 00:41:20 +0000
Received: from BLAPR10MB5009.namprd10.prod.outlook.com
 ([fe80::3c49:46aa:83e1:a329]) by BLAPR10MB5009.namprd10.prod.outlook.com
 ([fe80::3c49:46aa:83e1:a329%5]) with mapi id 15.20.4566.019; Sat, 2 Oct 2021
 00:41:20 +0000
Received: from [10.74.98.147] (160.34.88.147) by
 SN7PR04CA0220.namprd04.prod.outlook.com (2603:10b6:806:127::15) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.17 via Frontend
 Transport; Sat, 2 Oct 2021 00:41:19 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 38c8f25f-2063-469c-955e-2fac1e3377c3
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc :
 references : from : message-id : date : in-reply-to : content-type :
 content-transfer-encoding : mime-version; s=corp-2021-07-09;
 bh=jOA1OW3f4FLdi3yHgOlrFGlyDwX0rJiFhNEb9s9/Nbw=;
 b=W5ffz/Yl9S0w35Xi+P24nXqLDo3Uu+pdmYnRwlrwQN58ULWTNLBGjusRLMK2o/mD6T1l
 NJlPO1JdwDijXZF9EfIXMWggIIYx1ld2yqlT4m9KnKF12DTARzo8gM+qaYzsoX+Nugp8
 k2eMd2An4rVkqgqP+QDLtDHe3OG3QtehyDcF2yv6l+IXDWiL3pa2rGbYGwaMPC/yBvMz
 iAVg/9Z2O/NP3TfRMYZfbaaFtUZXncvdoQ8o+KIAGdxYIUn6fjlMsZ5byLTXZI8b9Jn4
 ORiXMl4BbHUWSlYszOSE/UfmfxIVcjx8cd7yBJDOU+smDyXw2PuSKQ6DycV1kvb57WFM 5A== 
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=g8OXQaF9Axm0jZ8VQ20wEzE+hpV+VfuqG4MIGIrLiFl4ADsmHv2+983QFNIojDDVnyoF+qGeza4vvDQWeeFtQrC2fnxGJP/TfR++LYKAGMG8RZSTqxlaMIph1S6K113s//hLIJ1XKRPrDdaIARQKs4OjusByWTZCmZKvaXeg3WMN8vG4Ub81++Kxr423z+JjFCF8K98JSxE//xv1ED7c89QRX/bSYZrCNRNxEeho+0yBgsAFxEdaJ35RHnZyd/Z8mcSYjJgUB2RDTaNB1W9NzoG4JJvosZf11H0/uEIQMk2P8GuSOGWXGBryqCY53u2AZUOLBlbDS7Vwt9CxGYFxWQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=jOA1OW3f4FLdi3yHgOlrFGlyDwX0rJiFhNEb9s9/Nbw=;
 b=Qgm0zyEJK1U5VZTcTRToJDsi612ez7i2KW+JxecMx+z7qRMS1nNYLfPAu+yD/HsUyWbC89EsA2O2K2ZarrCsaNUUWoDnmMEjLMMuCZ6eL2RBKtMhxG6J1muEVcNZ2aQZ7Clf4k6gE66hXkLIsXKV2Ehwlpndm8qoF0j5OAwp6MQFi0e033Tc5uC+XDO9fkE9PsyqnGBaUvR25F7to61C+0AQe6+ykhQqBNFIq6ZRHrXZh7y9m+3ux6aZMN9pl9hiqUJhWucCJFFeXiL3d6+qI3Xs6wNU/pLTAHP6f2Jl2AVMYiY/k127+bLTSakcyXHXJ29BJLA+PJ8ahilPtIH+oQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com;
 dkim=pass header.d=oracle.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=jOA1OW3f4FLdi3yHgOlrFGlyDwX0rJiFhNEb9s9/Nbw=;
 b=OjeKvNV9q9xu5dPhK/AusHmZ9HN/sKn3g8bqnE7MgcfCpqBVW5UXknxcdR8ZlxGbzGvmvCTcG9+8RylaroZksRpZafmcvqnKucLGy0upDfN+d/Ji/4AoHBmNClb11i1JqUze2oODsXkpa5m0p9odFHd8gEO09Cuw0xZtkTTNu64=
Authentication-Results: kernel.org; dkim=none (message not signed)
 header.d=none;kernel.org; dmarc=none action=none header.from=oracle.com;
Subject: Re: [PATCH v5 1/3] usb: Add Xen pvUSB protocol description
To: Juergen Gross <jgross@suse.com>, xen-devel@lists.xenproject.org,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Stefano Stabellini <sstabellini@kernel.org>
References: <20211001150039.15921-1-jgross@suse.com>
 <20211001150039.15921-2-jgross@suse.com>
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Message-ID: <e13367e4-2152-c99a-9b98-05d424019322@oracle.com>
Date: Fri, 1 Oct 2021 20:41:17 -0400
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0)
 Gecko/20100101 Thunderbird/78.14.0
In-Reply-To: <20211001150039.15921-2-jgross@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Content-Language: en-US
X-ClientProxiedBy: SN7PR04CA0220.namprd04.prod.outlook.com
 (2603:10b6:806:127::15) To BLAPR10MB5009.namprd10.prod.outlook.com
 (2603:10b6:208:321::10)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 6722244b-3698-4062-2887-08d9853d5a5c
X-MS-TrafficTypeDiagnostic: BL0PR10MB2835:
X-Microsoft-Antispam-PRVS: 
	<BL0PR10MB2835F75988731904618589628AAC9@BL0PR10MB2835.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:2449;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 
	BkwpCcilQB05rBdtsmQ9D+qdlOdLKWMuS2FBGtwNsZM8MzVTnQjEa3oh8BLBoZUIWrYgJOWPDNS+5PoBwddmNgIi05UZwU9iy15IxgCda+j+x2ms9UfLhGdPPxTJZ9YXIb3q2tZqxe47grU0ZF/2BRPwr4yyACH/J8loAYxiUN78t3Wgbpx970JscMxhDobdhiaiLIv7GDj3TpWt5vvGDLz9cMjToFmHgyJBQKhOkYvbQPVTB2lJc2WDaxscsgMDqio1mNNgx2qBGz3geGxrty55dy/FoFL/JIuhIKc/4yuchh9fW4h4ZbY+hy8l3voe3T5nQvmtupl/h0FXxOJuadm9Rl5oJgOy3AXLT1jnasmBcPxhAKzm6wXrZXhS+nVaIrNHyPf2eXm4r03rjBLHFgr8jWBjEwq14Cch/91FnWotjkujI0nW0d+0yI29kmZVD0SJybJklL2ghhSr9WoZjV9RiQy6aVhmjSvuR2quKo1bc1F0ENTipw5ANi7kPSyhM18rjDdFnJ12Q8pN7V2j298e9OWPrm14iBbRqmV5F35EEeGUyGWhL5vTds8IWxKp9smccepNd1OS1hzPBWriJRH9rZS5lyY+f/DnbekTsG/YJDV5iW36ZG8uDLaXDEFVa0G4LndpGJMpwKSSZaBr3V4WxEWOvz9BSjO2apPu6DBh4hc8OtNNxvfpLEV+tvmiTXgj6fJ+Z9zrXQUNSd191OUIzsNlyS77bGUKzw6DK9/cJo9HwbcSbDQ0HLrumBR4
X-Forefront-Antispam-Report: 
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB5009.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(44832011)(508600001)(8936002)(31696002)(956004)(6486002)(86362001)(2906002)(66946007)(4744005)(53546011)(38100700002)(2616005)(66556008)(26005)(16576012)(31686004)(8676002)(36756003)(4326008)(5660300002)(66476007)(316002)(186003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?dnZwOGU4Ym9scHI2Q1NVSFRkb2duYms3S2oya3lWbkVQa2xXWWZRbDhwZzZ4?=
 =?utf-8?B?MC8zV3FpOEVSYzU3RVp1cVJDU1RwVElGekdQMjRWWHFOaHdxL1RPMzg3WEZW?=
 =?utf-8?B?bzJJYk5FaG5SRGtyWVQ1OWdPN1ZCTUpxWnpCanhVdXhsLzVaZmtiWjlBbUlQ?=
 =?utf-8?B?dFhUSDg1elVsWEhJVFdqdHFwMS8rT3ZyN3d2MlV6Vi9JTzI2ZWlGL1hSN0to?=
 =?utf-8?B?SnRSOG5QMUluV1IwNStiM3RzeS9vaCtRRjY3ZFJCSDM4NzJLMWpENXhuRWpX?=
 =?utf-8?B?djJBazFzVWFteHYvVkNyVGNZeVNOQ1pjUGRKYnh3MmZ0eDNXZEw5bWJoSGNC?=
 =?utf-8?B?Vy9NSENlaGU3R0lUN29wZWhHU1F6YU1qa3RUZkQwVWp6dEhPR3gvVEFoYzlV?=
 =?utf-8?B?alJrMHhUMUJKbWQ3R2YwTy8zZXFuVEd2emI0bnpCcUlSUjNZU2VUV09FOS9C?=
 =?utf-8?B?Q2QvN0p2c081ODAyRjd1Rkx0S0crN2dteGw2WUhhTldZbEdibExDV1crdzFs?=
 =?utf-8?B?cCt0UVRLZFE1R0drczhOMjROdUc2OFNjdWliait2Wkg0OFUyL3JRbDN4TVNo?=
 =?utf-8?B?aVVPWVh2cEVjYkE4WGJrYW5LWllrUEhGYVRtZWowNzVVU3BwcFRKMyt4MWps?=
 =?utf-8?B?UUFkTXI2ZnZWVFNicFVaUTdyRUlCQ1Y1ejI4VjZzWGJENitISjNhOUdCVVgz?=
 =?utf-8?B?d29SN0huUmNOeng2SmJUVTBld0I5NFFzMS9zRHRmcGJKS1NlRXFZOGVRWUpn?=
 =?utf-8?B?TC8rREVkWDdHNVVka2JHMkZlbmdjQ2pPajFSTUM1OXRKd0YvRndTYjJ6eTZS?=
 =?utf-8?B?T1NHOW82QUljL3pjNmNTK3V6R2FWVWErOUVJNkEwenpVWldLVmhTK08rSFRN?=
 =?utf-8?B?S0E2TW1nYnlQUDJyR1hLWjVOSllEM2Q1VVAxWG9VTVNXMXpacG4xaTh4T0Jp?=
 =?utf-8?B?bWd5eW5McjJpOXlIa1B3TDlMUk80TXFPTWhBYTd4U3dqYlQ1dEovd1NHWDdT?=
 =?utf-8?B?WUNGcHdVdm5YZ1RoZE9nbkhHa09FYTk3V0hrc3cvWGYxY21kREhMek1VT0xR?=
 =?utf-8?B?YTZyLy9KaDdXcTZvc01USWwvMjlGZkd5eW1wdFpFTGt6YW9EaEJ3YTBIaG5I?=
 =?utf-8?B?L1Zkano0Q3B3UGdOSm9zeUJ6R3hzTHZVOHlUZnZCaFpoV0g3dVFGYzRGSWsr?=
 =?utf-8?B?cnZXQTQ1RGh5ZnJ1Tkx2QTk0UGtrTGphVDlGNjBreTNMVnF0akw4cmhtYlRX?=
 =?utf-8?B?TDBBTUFVK1ZmdGdFYUh3TUxwV1ZMaWRaa3hmSDdyeHFuZXJjNEZnOEFUdDNE?=
 =?utf-8?B?dDZhSWwwU1l2a3E4SnorUVh3T1p1T1NiUDdla0NBNy9pL1JLZjg1UEZlY1E2?=
 =?utf-8?B?SUVsdmg5OG1Qbm8rbVRyQzNtdnl5ZW42aTdEV3lwR3BJbmNzenBDaG1tWmRY?=
 =?utf-8?B?aHlpUVB1bUJMSnpJekFPQVl1RzkvN0RkWWVLdGJzTWVEOU5hSW82L0JhaU9G?=
 =?utf-8?B?TVFMQXRDbnpQTC9rMEZtQlU0ejBOOStRNllCV0ZlaGJOeU84N0ViaVM3Q3R1?=
 =?utf-8?B?ZDB0Y0NaZ2FFbHVmZ3JHWHJ0R0NHbndtM25VWmRLeWJpL1pxWFh3R3F2NWEw?=
 =?utf-8?B?cUFIcE1oRkhlcGpoTTM3anJ6VFl2SjB2YTB2Y2FYaFdFcG5GTlJVMXNvL2RO?=
 =?utf-8?B?SUtxdHllbFdCcnYvSnFTcDNCYm00OW1nRkx6SGFoWEFZUU1jOVVwMTFpTGdu?=
 =?utf-8?Q?2+zDcegdcNJShHfoIVhAK85Qw9NoIvXXoGXimfg?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6722244b-3698-4062-2887-08d9853d5a5c
X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Oct 2021 00:41:20.6478
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: rDhLROxoAdXP6X/9Q36TszibltVr0lXN8u6q8aUgWF66J0Ok1oXi+mG832zIOtgjAAXKauRE1tCI08eifSmFS7CqIQfDhNBzOkA/9PIrmYo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR10MB2835
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10124 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 adultscore=0
 mlxlogscore=999 phishscore=0 suspectscore=0 mlxscore=0 spamscore=0
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2109230001 definitions=main-2110020001
X-Proofpoint-ORIG-GUID: 2qMlHNNWSjhRUMUzUrM4TsP0pIE-2QlV
X-Proofpoint-GUID: 2qMlHNNWSjhRUMUzUrM4TsP0pIE-2QlV


On 10/1/21 11:00 AM, Juergen Gross wrote:
> Add the definition of pvUSB protocol used between the pvUSB frontend in
> a Xen domU and the pvUSB backend in a Xen driver domain (usually Dom0).
>
> This header was originally provided by Fujitsu for Xen based on Linux
> 2.6.18.
>
> Changes are:
> - adapt to Linux kernel style guide
> - use Xen namespace
> - add lots of comments
> - don't use kernel internal defines
>
> Signed-off-by: Juergen Gross <jgross@suse.com>



Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>



From xen-devel-bounces@lists.xenproject.org Sat Oct 02 02:35:44 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 02 Oct 2021 02:35:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.200895.355460 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mWUs7-0000cK-Bq; Sat, 02 Oct 2021 02:35:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 200895.355460; Sat, 02 Oct 2021 02:35:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mWUs7-0000cD-87; Sat, 02 Oct 2021 02:35:31 +0000
Received: by outflank-mailman (input) for mailman id 200895;
 Sat, 02 Oct 2021 02:35:29 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=dbdP=OW=m5p.com=ehem@srs-us1.protection.inumbo.net>)
 id 1mWUs5-0000c7-Rs
 for xen-devel@lists.xenproject.org; Sat, 02 Oct 2021 02:35:29 +0000
Received: from mailhost.m5p.com (unknown [74.104.188.4])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 675dc3a6-2329-11ec-bde5-12813bfff9fa;
 Sat, 02 Oct 2021 02:35:28 +0000 (UTC)
Received: from m5p.com (mailhost.m5p.com [IPv6:2001:470:1f07:15ff:0:0:0:f7])
 by mailhost.m5p.com (8.16.1/8.15.2) with ESMTPS id 1922ZGs4028143
 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO);
 Fri, 1 Oct 2021 22:35:22 -0400 (EDT) (envelope-from ehem@m5p.com)
Received: (from ehem@localhost)
 by m5p.com (8.16.1/8.15.2/Submit) id 1922ZG44028142;
 Fri, 1 Oct 2021 19:35:16 -0700 (PDT) (envelope-from ehem)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 675dc3a6-2329-11ec-bde5-12813bfff9fa
Date: Fri, 1 Oct 2021 19:35:16 -0700
From: Elliott Mitchell <ehem+xen@m5p.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: xen-devel@lists.xenproject.org
Subject: Re: HVM/PVH Balloon crash
Message-ID: <YVfFZKRIPTYi/9bH@mattapan.m5p.com>
References: <YTZ+XsnoKNnV4IOz@mattapan.m5p.com>
 <1b3d4cb1-ba61-0f61-5097-9978462a2401@suse.com>
 <YTd/SFtvuzejeiik@mattapan.m5p.com>
 <935dc03f-74f5-4b49-3a45-71148364fb5a@suse.com>
 <YUFdIPLo1AfM5BT2@mattapan.m5p.com>
 <3efe115b-1ff7-dcf1-8198-37bd7d7fb52f@suse.com>
 <YVD59QVbmdVwzYQI@mattapan.m5p.com>
 <033cc499-34de-d27a-7b1b-2a0a7ce38672@suse.com>
 <YVSGvGZc67ZLMdKm@mattapan.m5p.com>
 <03052a89-cb51-250d-4fcd-b9d8ceb93e39@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <03052a89-cb51-250d-4fcd-b9d8ceb93e39@suse.com>
X-Spam-Status: No, score=0.4 required=10.0 tests=KHOP_HELO_FCRDNS autolearn=no
	autolearn_force=no version=3.4.5
X-Spam-Checker-Version: SpamAssassin 3.4.5 (2021-03-20) on mattapan.m5p.com

On Thu, Sep 30, 2021 at 09:08:34AM +0200, Jan Beulich wrote:
> On 29.09.2021 17:31, Elliott Mitchell wrote:
> > 
> > Copy and paste from the xl.cfg man page:
> > 
> >        nestedhvm=BOOLEAN
> >            Enable or disables guest access to hardware virtualisation
> >            features, e.g. it allows a guest Operating System to also function
> >            as a hypervisor. You may want this option if you want to run
> >            another hypervisor (including another copy of Xen) within a Xen
> >            guest or to support a guest Operating System which uses hardware
> >            virtualisation extensions (e.g. Windows XP compatibility mode on
> >            more modern Windows OS).  This option is disabled by default.
> > 
> > "This option is disabled by default." doesn't mean "this is an
> > experimental feature with no security support and is likely to crash the
> > hypervisor".
> 
> Correct, but this isn't the only place to look at. Quoting
> SUPPORT.md:

You expect everyone to memorize SUPPORT.md (almost 1000 lines) before
trying to use Xen?

Your statement amounts to saying you really expect that.  People who want
to get work done will look at `man xl.cfg` when needed, and follow
instructions.

Mentioning something in `man xl.cfg` amounts to a statment "this is
supported".  Experimental/unsupported options need to be marked
"EXPERIMENTAL: DO NOT ENABLE IN PRODUCTION ENVIRONMENTS".


> Yet that's still a configuration error (of the guest), not a bug in
> Xen.

Documentation that poor amounts to a security vulnerability.



I would suggest this needs 2 extra enablers.

First, this has potential to panic the hypervisor.  As such there needs
to be an "enable_experimental=" option for the Xen command-line.  The
argument would be a list of features to enable ("nestedhvm" for this
case).  If this is absent, the hypervisor should ideally disable as much
of the code related to the unsupported/experimental features as possible.

Second, since this needs to be enabled per-domain, there should be a
similar "enable_experimental" setting for xl.cfg options.



I think this really is bad enough to warrant a security vulnerability
and updates to all branches.


-- 
(\___(\___(\______          --=> 8-) EHM <=--          ______/)___/)___/)
 \BS (    |         ehem+sigmsg@m5p.com  PGP 87145445         |    )   /
  \_CS\   |  _____  -O #include <stddisclaimer.h> O-   _____  |   /  _/
8A19\___\_|_/58D2 7E3D DDF4 7BA6 <-PGP-> 41D1 B375 37D0 8714\_|_/___/5445




From xen-devel-bounces@lists.xenproject.org Sat Oct 02 07:36:30 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 02 Oct 2021 07:36:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.201056.355471 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mWZZ7-0003VQ-Bp; Sat, 02 Oct 2021 07:36:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 201056.355471; Sat, 02 Oct 2021 07:36:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mWZZ7-0003VJ-82; Sat, 02 Oct 2021 07:36:13 +0000
Received: by outflank-mailman (input) for mailman id 201056;
 Sat, 02 Oct 2021 07:36:12 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=vLOl=OW=gmail.com=julien.grall.oss@srs-us1.protection.inumbo.net>)
 id 1mWZZ6-0003VD-Aa
 for xen-devel@lists.xenproject.org; Sat, 02 Oct 2021 07:36:12 +0000
Received: from mail-ed1-x535.google.com (unknown [2a00:1450:4864:20::535])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 536a1f1d-9bb5-4e73-a590-c3f50ae51405;
 Sat, 02 Oct 2021 07:36:09 +0000 (UTC)
Received: by mail-ed1-x535.google.com with SMTP id s17so42205132edd.8
 for <xen-devel@lists.xenproject.org>; Sat, 02 Oct 2021 00:36:09 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 536a1f1d-9bb5-4e73-a590-c3f50ae51405
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=O7ubnJ+U+MIePACuBV8RqRT2/S4lsdDFm7w1PbFmvTE=;
        b=LzKWw7uP4WimDNvuftM2YZ4G7ZOd6VhBJiSXX0WMIO/gdxor+/ZuM33GMWdFcMGrxO
         RjVFb59s4m065xBodECjwWVaH+D7j+kw+jVmSo+/Xu429AG7YoWHv6W6/PEurDS0M2Pa
         DUTQRSwLCLqTUbLSkGCMOyLyoPkDEP8dI4m905esSkJkurM1WBpBEZF4ehBrNj9qva5q
         jVZ03bZmC2IHuDfeeNv+IGa/PeA4tSCwIB7ybpvi39hzjTsg74Ofa12Qrf/7PP9RiN7A
         bZAm/PQkxg23kQPlB7xltGGD0re5eL9NpZctFhC1DxFc0XmMNOHjczjqO0CwK/r1xF4x
         c62A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=O7ubnJ+U+MIePACuBV8RqRT2/S4lsdDFm7w1PbFmvTE=;
        b=EYF4EdqmLPwQN2+xBpSur8vdhu/3ZXTI4rFJaHkLZmGm4ZhblLDNF4L3f4yT+pGKS8
         Rvmbu7vHjw3+n5DaxVEwjdUjEfTJo8o5PnRxaRUOvuQ1UJtDW3ZDK7GcC769zz5Y9xML
         E+b4dY3OJQOn9YSrd1n3d+ecARwA2CVeqWiAWvEKxGFmWLc+mkcsUWKjEeRpaRsvuN2j
         plTgXK/qqCkBGC2z7Kn0XXWavNvdDpb9UIIkP5zqrjCCm1jhzeqmei+35Z7iTTZu3Ynb
         oN8Qm3bCk23IVGHGItArhTp245QwTAcA83/ymmdnLYFQXWZGERGF9MPfyHda10pYh/NL
         oNqw==
X-Gm-Message-State: AOAM533RIKV4twdYCQkJF5A558Iv++9FaXkaZRZk/xyK4YRnUlr2zw79
	wScz/Va7AMvPNrmGNnW9oFPk/zTGpHcTbDvPFsM=
X-Google-Smtp-Source: ABdhPJyutU+ibK0Cgqqz3JYUqYEET9/84iAEz6jJ8cWEkpAjRo53gCs5Ugw0FfYWsFrH6dFI6HxAJO+nC6Lne28RE4Q=
X-Received: by 2002:aa7:c2d3:: with SMTP id m19mr2444179edp.267.1633160168922;
 Sat, 02 Oct 2021 00:36:08 -0700 (PDT)
MIME-Version: 1.0
References: <1632955927-27911-1-git-send-email-olekstysh@gmail.com>
 <1632955927-27911-2-git-send-email-olekstysh@gmail.com> <alpine.DEB.2.21.2109301600060.3209@sstabellini-ThinkPad-T480s>
 <05b040b0-a069-47a1-1f5e-85be62fa35f3@suse.com> <bbbceae1-c382-5e48-0c6b-fbb23fc720f5@gmail.com>
 <alpine.DEB.2.21.2110011244000.3209@sstabellini-ThinkPad-T480s>
In-Reply-To: <alpine.DEB.2.21.2110011244000.3209@sstabellini-ThinkPad-T480s>
From: Julien Grall <julien.grall.oss@gmail.com>
Date: Sat, 2 Oct 2021 09:35:54 +0200
Message-ID: <CAJ=z9a2bT4tMn2argJzePUMR2Ke4bmabj+j5QevvwpfnA9ST_w@mail.gmail.com>
Subject: Re: [PATCH V4 1/3] xen: Introduce "gpaddr_bits" field to XEN_SYSCTL_physinfo
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: Oleksandr <olekstysh@gmail.com>, Jan Beulich <jbeulich@suse.com>, 
	xen-devel <xen-devel@lists.xenproject.org>, 
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>, 
	Anthony PERARD <anthony.perard@citrix.com>, Andrew Cooper <andrew.cooper3@citrix.com>, 
	George Dunlap <george.dunlap@citrix.com>, Juergen Gross <jgross@suse.com>, 
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= <roger.pau@citrix.com>, 
	Bertrand Marquis <Bertrand.Marquis@arm.com>
Content-Type: multipart/alternative; boundary="000000000000bae1fc05cd59bbf6"

--000000000000bae1fc05cd59bbf6
Content-Type: text/plain; charset="UTF-8"

Hi

On Sat, 2 Oct 2021, 01:24 Stefano Stabellini, <sstabellini@kernel.org>
wrote:

> Bertrand, see comment on ID_AA64MMFR0_EL1 below, any ideas?
>
>
> On Fri, 1 Oct 2021, Oleksandr wrote:
> > On 01.10.21 10:50, Jan Beulich wrote:
> > > On 01.10.2021 01:00, Stefano Stabellini wrote:
> > > > On Thu, 30 Sep 2021, Oleksandr Tyshchenko wrote:
> > > > > From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> > > > >
> > > > > We need to pass info about maximum supported guest address
> > > > > space size to the toolstack on Arm in order to properly
> > > > > calculate the base and size of the extended region (safe range)
> > > > > for the guest. The extended region is unused address space which
> > > > > could be safely used by domain for foreign/grant mappings on Arm.
> > > > > The extended region itself will be handled by the subsequents
> > > > > patch.
> > > > >
> > > > > Use p2m_ipa_bits variable on Arm, the x86 equivalent is
> > > > > hap_paddr_bits.
> > > > >
> > > > > As we change the size of structure bump the interface version.
> > > > >
> > > > > Suggested-by: Julien Grall <jgrall@amazon.com>
> > > > > Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com
> >
> > > > > Reviewed-by: Michal Orzel <michal.orzel@arm.com>
> > > > Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
> > > I have to admit that I'm a little puzzled to see these R-b-s when ...
> > >
> > > > > Please note, that review comments for the RFC version [1] haven't
> been
> > > > > addressed yet.
> > > > > It is not forgotten, some clarification is needed. It will be
> addressed
> > > > > for the next version.
> > > > >
> > > > > [1]
> > > > >
> https://lore.kernel.org/xen-devel/973f5344-aa10-3ad6-ff02-ad5f358ad279@citrix.com/
> > > ... Oleksandr makes clear this patch isn't really ready yet.
> >
> > Unfortunately, this is true. I am still waiting for the clarification [1]
>
> Although I was aware of comments to older versions, this is actually the
> first version of this patch that I reviewed with any level of details; I
> didn't read previous comments very closely. I tried to find any bugs or
> problems with it and I couldn't see any, so I gave my reviewed-by. I
> should have clarified that was meant for the ARM part as I don't have a
> full understanding of the implications of using hap_paddr_bits on x86
> for VM migration.


>
> But let me take this opportunity to say that although I think the
> hypercall is OK, I wish we didn't need this patch at all: it is
> problematic because it touches tools, x86 and ARM hypervisor code all
> together. It needs at least three acks/reviewed-by to get accepted: from
> an x86 maintainer, an arm maintainer and from a tools maintainer. I
> don't say this to criticize the patch acceptance process: this patch
> makes changes to an existing hypercall so it is only fair that it needs
> to go through extra levels of scrutiny. For the sake of simplicity and
> decoupling (reducing dependencies between patches and between
> components), I think it would be best to introduce an #define for the
> minimum value of gpaddr_bits and then move this patch at the end of the
> series; that way it becomes optional.


It depends what you mean by optional. Yes we can add hack to avoid the
hypercall... But the more scalable solution is the hypercall.

I am slightly concerned that if we don't push for the hypercall now, then
there will be no incentive to do it afterwards...

So I went through Andrew's e-mail to understand what's the request. I
understand that there are some problem with migration. But it doesn't look
like we need to solve them now. Instead,  AFAICT, his main ask for this
series is to switch to a domctl.

It seems the conversation is simply stuck on waiting for Andrew to provide
details on what would look like. Did we ping Andrew on IRC?

Unfortunately the minimum value
> is 32 (in practice I have never seen less than 40 but the architecture
> supports 32 as minimum).


>
> Actually, the info we are looking for is already exposed via
> ID_AA64MMFR0_EL1. ID_AA64MMFR0_EL1 can be read from a virtual machine,
> and Linux let userspace read it [1]. Regardless of this patch series, we
> should make sure that Xen exposes the right mm64.pa_range value to guest
> virtual machines. If that is done right, then you can just add support
> for reading ID_AA64MMFR0_EL1 in libxl/libxc and then we don't need any
> hypercall modifications changes.


>From my understanding, from a VM PoV "pa_range" should represent the size
of the guest physical address space.

Today, it happens that every VM is using the same P2M size. However, I
would rather not make such assumption in the userspace.


> So, in theory we already have all the interfaces we need, but in
> practice they don't work: unfortunaly both Xen and Linux mark
> ID_AA64MMFR0_EL1 as FTR_HIDDEN in cpufeature.c so neither Linux from
> Xen, not userspace from Linux can actually read the real value :-/
> They always read zero.
>
> (Also I think we have an issue today with p2m_restrict_ipa_bits not
> updating the mm64.pa_range value. I think that it should be fixed.)


It looks like it. That should be handled in a separate patch though.


> Bertrand, do you have any ideas in regards to ID_AA64MMFR0_EL1?
>
> If not, maybe we could just go with
> #define MIN_GPADDR_BITS 32.


The toolstack would have to consider it as the "maximum" because it may not
be safe to expose anything above.

With 32, we are going to be limited in term of space we can find.

We could potentially use 40 bits as a minimum. Although it still feels a
bit of a hack to me given that the IOMMU may restrict it further and the
architecture can in theory support less.

Overall, I still strongly prefer the hypercall approach. If a common one is
difficult to achieve, then we can extend the domctl to create a domain to
provide the p2m_bits (in the same way as we deal for the GIC version) in an
arch specific way.

Cheers,


>
> [1]
> https://01.org/linuxgraphics/gfx-docs/drm/arm64/cpu-feature-registers.html
>

--000000000000bae1fc05cd59bbf6
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"auto"><div>Hi<br><br><div class=3D"gmail_quote"><div dir=3D"ltr=
" class=3D"gmail_attr">On Sat, 2 Oct 2021, 01:24 Stefano Stabellini, &lt;<a=
 href=3D"mailto:sstabellini@kernel.org" target=3D"_blank" rel=3D"noreferrer=
">sstabellini@kernel.org</a>&gt; wrote:<br></div><blockquote class=3D"gmail=
_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:=
1ex">Bertrand, see comment on ID_AA64MMFR0_EL1 below, any ideas?<br>
<br>
<br>
On Fri, 1 Oct 2021, Oleksandr wrote:<br>
&gt; On 01.10.21 10:50, Jan Beulich wrote:<br>
&gt; &gt; On 01.10.2021 01:00, Stefano Stabellini wrote:<br>
&gt; &gt; &gt; On Thu, 30 Sep 2021, Oleksandr Tyshchenko wrote:<br>
&gt; &gt; &gt; &gt; From: Oleksandr Tyshchenko &lt;<a href=3D"mailto:oleksa=
ndr_tyshchenko@epam.com" rel=3D"noreferrer noreferrer" target=3D"_blank">ol=
eksandr_tyshchenko@epam.com</a>&gt;<br>
&gt; &gt; &gt; &gt; <br>
&gt; &gt; &gt; &gt; We need to pass info about maximum supported guest addr=
ess<br>
&gt; &gt; &gt; &gt; space size to the toolstack on Arm in order to properly=
<br>
&gt; &gt; &gt; &gt; calculate the base and size of the extended region (saf=
e range)<br>
&gt; &gt; &gt; &gt; for the guest. The extended region is unused address sp=
ace which<br>
&gt; &gt; &gt; &gt; could be safely used by domain for foreign/grant mappin=
gs on Arm.<br>
&gt; &gt; &gt; &gt; The extended region itself will be handled by the subse=
quents<br>
&gt; &gt; &gt; &gt; patch.<br>
&gt; &gt; &gt; &gt; <br>
&gt; &gt; &gt; &gt; Use p2m_ipa_bits variable on Arm, the x86 equivalent is=
<br>
&gt; &gt; &gt; &gt; hap_paddr_bits.<br>
&gt; &gt; &gt; &gt; <br>
&gt; &gt; &gt; &gt; As we change the size of structure bump the interface v=
ersion.<br>
&gt; &gt; &gt; &gt; <br>
&gt; &gt; &gt; &gt; Suggested-by: Julien Grall &lt;<a href=3D"mailto:jgrall=
@amazon.com" rel=3D"noreferrer noreferrer" target=3D"_blank">jgrall@amazon.=
com</a>&gt;<br>
&gt; &gt; &gt; &gt; Signed-off-by: Oleksandr Tyshchenko &lt;<a href=3D"mail=
to:oleksandr_tyshchenko@epam.com" rel=3D"noreferrer noreferrer" target=3D"_=
blank">oleksandr_tyshchenko@epam.com</a>&gt;<br>
&gt; &gt; &gt; &gt; Reviewed-by: Michal Orzel &lt;<a href=3D"mailto:michal.=
orzel@arm.com" rel=3D"noreferrer noreferrer" target=3D"_blank">michal.orzel=
@arm.com</a>&gt;<br>
&gt; &gt; &gt; Reviewed-by: Stefano Stabellini &lt;<a href=3D"mailto:sstabe=
llini@kernel.org" rel=3D"noreferrer noreferrer" target=3D"_blank">sstabelli=
ni@kernel.org</a>&gt;<br>
&gt; &gt; I have to admit that I&#39;m a little puzzled to see these R-b-s =
when ...<br>
&gt; &gt; <br>
&gt; &gt; &gt; &gt; Please note, that review comments for the RFC version [=
1] haven&#39;t been<br>
&gt; &gt; &gt; &gt; addressed yet.<br>
&gt; &gt; &gt; &gt; It is not forgotten, some clarification is needed. It w=
ill be addressed<br>
&gt; &gt; &gt; &gt; for the next version.<br>
&gt; &gt; &gt; &gt; <br>
&gt; &gt; &gt; &gt; [1]<br>
&gt; &gt; &gt; &gt; <a href=3D"https://lore.kernel.org/xen-devel/973f5344-a=
a10-3ad6-ff02-ad5f358ad279@citrix.com/" rel=3D"noreferrer noreferrer norefe=
rrer" target=3D"_blank">https://lore.kernel.org/xen-devel/973f5344-aa10-3ad=
6-ff02-ad5f358ad279@citrix.com/</a><br>
&gt; &gt; ... Oleksandr makes clear this patch isn&#39;t really ready yet.<=
br>
&gt; <br>
&gt; Unfortunately, this is true. I am still waiting for the clarification =
[1]<br>
<br>
Although I was aware of comments to older versions, this is actually the<br=
>
first version of this patch that I reviewed with any level of details; I<br=
>
didn&#39;t read previous comments very closely. I tried to find any bugs or=
<br>
problems with it and I couldn&#39;t see any, so I gave my reviewed-by. I<br=
>
should have clarified that was meant for the ARM part as I don&#39;t have a=
<br>
full understanding of the implications of using hap_paddr_bits on x86<br>
for VM migration.</blockquote><blockquote class=3D"gmail_quote" style=3D"ma=
rgin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
<br>
But let me take this opportunity to say that although I think the<br>
hypercall is OK, I wish we didn&#39;t need this patch at all: it is<br>
problematic because it touches tools, x86 and ARM hypervisor code all<br>
together. It needs at least three acks/reviewed-by to get accepted: from<br=
>
an x86 maintainer, an arm maintainer and from a tools maintainer. I<br>
don&#39;t say this to criticize the patch acceptance process: this patch<br=
>
makes changes to an existing hypercall so it is only fair that it needs<br>
to go through extra levels of scrutiny. For the sake of simplicity and<br>
decoupling (reducing dependencies between patches and between<br>
components), I think it would be best to introduce an #define for the<br>
minimum value of gpaddr_bits and then move this patch at the end of the<br>
series; that way it becomes optional.</blockquote></div></div><div dir=3D"a=
uto"><br></div><div dir=3D"auto">It depends what you mean by optional. Yes =
we can add hack to avoid the hypercall... But the more scalable solution is=
 the hypercall.</div><div dir=3D"auto"><br></div><div dir=3D"auto">I am sli=
ghtly concerned that if we don&#39;t push for the hypercall now, then there=
 will be no incentive to do it afterwards...</div><div dir=3D"auto"><br></d=
iv><div dir=3D"auto">So I went through Andrew&#39;s e-mail to understand wh=
at&#39;s the request. I understand that there are some problem with migrati=
on. But it doesn&#39;t look like we need to solve them now. Instead,=C2=A0 =
AFAICT, his main ask for this series is to switch to a domctl.</div><div di=
r=3D"auto"><br></div><div dir=3D"auto">It seems the conversation is simply =
stuck on waiting for Andrew to provide details on what would look like. Did=
 we ping Andrew on IRC?</div><div dir=3D"auto"><br></div><div dir=3D"auto">=
<div class=3D"gmail_quote"><blockquote class=3D"gmail_quote" style=3D"margi=
n:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> Unfortunately th=
e minimum value<br>
is 32 (in practice I have never seen less than 40 but the architecture<br>
supports 32 as minimum).</blockquote></div></div><div dir=3D"auto"></div><d=
iv dir=3D"auto"><div class=3D"gmail_quote"><blockquote class=3D"gmail_quote=
" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
<br>
Actually, the info we are looking for is already exposed via<br>
ID_AA64MMFR0_EL1. ID_AA64MMFR0_EL1 can be read from a virtual machine,<br>
and Linux let userspace read it [1]. Regardless of this patch series, we<br=
>
should make sure that Xen exposes the right mm64.pa_range value to guest<br=
>
virtual machines. If that is done right, then you can just add support<br>
for reading ID_AA64MMFR0_EL1 in libxl/libxc and then we don&#39;t need any<=
br>
hypercall modifications changes.</blockquote></div></div><div dir=3D"auto">=
<br></div><div dir=3D"auto">From my understanding, from a VM PoV &quot;pa_r=
ange&quot; should represent the size of the guest physical address space.</=
div><div dir=3D"auto"><br></div><div dir=3D"auto">Today, it happens that ev=
ery VM is using the same P2M size. However, I would rather not make such as=
sumption in the userspace.</div><div dir=3D"auto"><br></div><div dir=3D"aut=
o"><div class=3D"gmail_quote"><blockquote class=3D"gmail_quote" style=3D"ma=
rgin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
So, in theory we already have all the interfaces we need, but in<br>
practice they don&#39;t work: unfortunaly both Xen and Linux mark<br>
ID_AA64MMFR0_EL1 as FTR_HIDDEN in cpufeature.c so neither Linux from<br>
Xen, not userspace from Linux can actually read the real value :-/<br>
They always read zero.<br>
<br>
(Also I think we have an issue today with p2m_restrict_ipa_bits not<br>
updating the mm64.pa_range value. I think that it should be fixed.)</blockq=
uote></div></div><div dir=3D"auto"><br></div><div dir=3D"auto">It looks lik=
e it. That should be handled in a separate patch though.</div><div dir=3D"a=
uto"></div><div dir=3D"auto"><br></div><div dir=3D"auto"><div class=3D"gmai=
l_quote"><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;borde=
r-left:1px #ccc solid;padding-left:1ex">
<br>
Bertrand, do you have any ideas in regards to ID_AA64MMFR0_EL1?<br>
<br>
If not, maybe we could just go with<br>
#define MIN_GPADDR_BITS 32.</blockquote></div></div><div dir=3D"auto"><br><=
/div><div dir=3D"auto">The toolstack would have to consider it as the &quot=
;maximum&quot; because it may not be safe to expose anything above.</div><d=
iv dir=3D"auto"><br></div><div dir=3D"auto">With 32, we are going to be lim=
ited in term of space we can find.</div><div dir=3D"auto"><br></div><div di=
r=3D"auto">We could potentially use 40 bits as a minimum. Although it still=
 feels a bit of a hack to me given that the IOMMU may restrict it further a=
nd the architecture can in theory support less.</div><div dir=3D"auto"><br>=
</div><div dir=3D"auto">Overall, I still strongly prefer the hypercall appr=
oach. If a common one is difficult to achieve, then we can extend the domct=
l to create a domain to provide the p2m_bits (in the same way as we deal fo=
r the GIC version) in an arch specific way.</div><div dir=3D"auto"><br></di=
v><div dir=3D"auto">Cheers,</div><div dir=3D"auto"><br></div><div dir=3D"au=
to"></div><div dir=3D"auto"><div class=3D"gmail_quote"><blockquote class=3D=
"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding=
-left:1ex">
<br>
<br>
[1] <a href=3D"https://01.org/linuxgraphics/gfx-docs/drm/arm64/cpu-feature-=
registers.html" rel=3D"noreferrer noreferrer noreferrer" target=3D"_blank">=
https://01.org/linuxgraphics/gfx-docs/drm/arm64/cpu-feature-registers.html<=
/a><br>
</blockquote></div></div></div>

--000000000000bae1fc05cd59bbf6--


From xen-devel-bounces@lists.xenproject.org Sat Oct 02 12:40:59 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 02 Oct 2021 12:40:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.201069.355482 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mWeJm-0005Qs-6G; Sat, 02 Oct 2021 12:40:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 201069.355482; Sat, 02 Oct 2021 12:40:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mWeJm-0005Ql-3J; Sat, 02 Oct 2021 12:40:42 +0000
Received: by outflank-mailman (input) for mailman id 201069;
 Sat, 02 Oct 2021 12:40:40 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+enT=OW=gmail.com=olekstysh@srs-us1.protection.inumbo.net>)
 id 1mWeJk-0005Qf-8A
 for xen-devel@lists.xenproject.org; Sat, 02 Oct 2021 12:40:40 +0000
Received: from mail-lf1-x132.google.com (unknown [2a00:1450:4864:20::132])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 6a7f1b47-d2c4-4bc1-8d4b-bc9bcf4fa323;
 Sat, 02 Oct 2021 12:40:36 +0000 (UTC)
Received: by mail-lf1-x132.google.com with SMTP id x27so49359927lfa.9
 for <xen-devel@lists.xenproject.org>; Sat, 02 Oct 2021 05:40:36 -0700 (PDT)
Received: from [192.168.1.7] ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id d13sm1034116lfe.21.2021.10.02.05.40.34
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Sat, 02 Oct 2021 05:40:34 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6a7f1b47-d2c4-4bc1-8d4b-bc9bcf4fa323
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-transfer-encoding:content-language;
        bh=6hF3HXnGdZcZAtzK7CE3tv51dDQlqDJAhzskya9FjfE=;
        b=R99152PKZCD+yTmYAJ5yayJtQmlLD+nDHEODsHhm1Fo36+MsPWcdrSu8PcUG1Mk42a
         XoOsZnxC7zVzvIo4VCvVzWMvNagnO/kBiRpB67IV3YFPTzBsPhYJ1ID6WQlucsyxkJKF
         pwrL5oNuW2kAmhLBdmEP+DklUbqUACnMaiIysKE12Y/vt1e0VE2mKQQXT04DqaCkdaWS
         vDPYFS3asdGQtMsRHcyLCA/i+LLF91WKVbBz462TDvnIRBq9iR6FLvJcZY3u+aTtifa/
         7ct1fEpUCRS4FfLWPR6/ZE1BhtDQCRFAOpDN9aUHCTG9gKmEEt36PNPze3PQautXuUfL
         rzrA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding
         :content-language;
        bh=6hF3HXnGdZcZAtzK7CE3tv51dDQlqDJAhzskya9FjfE=;
        b=RJ0S5jBvtIouguRQ/hGmtmiIE7j+SAkbIdQiOvItByrETrmkDc49bHeJObRRg2Drvg
         6J/MNPdQgKVnP22MQhI6Xw3H4wtQt6VntUScMUUItrSkwry5i0iOIohfc7pDDLacmXYI
         aiS8YYi+4S27hjYwUYUugd7dU7ecYdwOKHStvHXVq33aqrdf4Ea+e83OMxNNirNfhB+1
         LeKMp37QVZY2Fr+GNUWBC7uMHTqJAJuFe5SdBD3S1JznyzVSpNq+qrfqNmZwBMglLQ4y
         qxhaVv5sAW3Rb7sl9KHXXh71RLxBlDLtKh0uaD/iVA1Xzi5jBb3pQxqLMHqYPcPWZhmL
         0lWQ==
X-Gm-Message-State: AOAM533cJarZuWamOyT2Db7kjzH5HbSkRAMY5nRJoNtFhjqrV8VPOun2
	8E7aRTV7jgacC2K3m5XFP9A=
X-Google-Smtp-Source: ABdhPJyXeN1WtreSjmjL3lk34csk5AT9YPx2Pt1fpOQCjisiUJuLwxLSY/awy0VwlwAX88mr7sMkGA==
X-Received: by 2002:ac2:5cd7:: with SMTP id f23mr3778929lfq.652.1633178435092;
        Sat, 02 Oct 2021 05:40:35 -0700 (PDT)
Subject: Re: [PATCH V4 2/3] xen/arm: Add handling of extended regions for Dom0
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: xen-devel@lists.xenproject.org,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Jan Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>,
 Wei Liu <wl@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <1632955927-27911-1-git-send-email-olekstysh@gmail.com>
 <1632955927-27911-3-git-send-email-olekstysh@gmail.com>
 <alpine.DEB.2.21.2110011704350.3209@sstabellini-ThinkPad-T480s>
From: Oleksandr <olekstysh@gmail.com>
Message-ID: <7e0a9915-ed26-afde-19d7-9c76bb476a24@gmail.com>
Date: Sat, 2 Oct 2021 15:40:33 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.21.2110011704350.3209@sstabellini-ThinkPad-T480s>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US


On 02.10.21 03:33, Stefano Stabellini wrote:

Hi Stefano

> On Thu, 30 Sep 2021, Oleksandr Tyshchenko wrote:
>> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>>
>> The extended region (safe range) is a region of guest physical
>> address space which is unused and could be safely used to create
>> grant/foreign mappings instead of wasting real RAM pages from
>> the domain memory for establishing these mappings.
>>
>> The extended regions are chosen at the domain creation time and
>> advertised to it via "reg" property under hypervisor node in
>> the guest device-tree. As region 0 is reserved for grant table
>> space (always present), the indexes for extended regions are 1...N.
>> If extended regions could not be allocated for some reason,
>> Xen doesn't fail and behaves as usual, so only inserts region 0.
>>
>> Please note the following limitations:
>> - The extended region feature is only supported for 64-bit domain
>>    currently.
>> - The ACPI case is not covered.
>>
>> ***
>>
>> As Dom0 is direct mapped domain on Arm (e.g. MFN == GFN)
>> the algorithm to choose extended regions for it is different
>> in comparison with the algorithm for non-direct mapped DomU.
>> What is more, that extended regions should be chosen differently
>> whether IOMMU is enabled or not.
>>
>> Provide RAM not assigned to Dom0 if IOMMU is disabled or memory
>> holes found in host device-tree if otherwise. Make sure that
>> extended regions are 2MB-aligned and located within maximum possible
>> addressable physical memory range. The minimum size of extended
>> region is 64MB. The maximum number of extended regions is 128,
>> which is an artificial limit to minimize code changes (we reuse
>> struct meminfo to describe extended regions, so there are an array
>> field for 128 elements).
>>
>> It worth mentioning that unallocated memory solution (when the IOMMU
>> is disabled) will work safely until Dom0 is able to allocate memory
>> outside of the original range.
>>
>> Also introduce command line option to be able to globally enable or
>> disable support for extended regions for Dom0 (enabled by default).
>>
>> Suggested-by: Julien Grall <jgrall@amazon.com>
>> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> I thought about it and I decided to commit this patch because it doesn't
> actually need anything from the other two patches, and it is very useful
> on its own (both of them are for domU, while this one is for dom0).

Thank you.


>
> In regards to Julien's suggestion: as explained in earlier emails I
> prefer this version but I don't have a strong opinion. If Julien still
> prefers the other approach we can still change it in time for 4.16
> (Oleksandr has already implemented both and I am happy to review.)

Sure, we will able to do it if needed.


>
>
>> ---
>> Please note, we need to decide which approach to use in find_unallocated_memory(),
>> you can find details at:
>> https://lore.kernel.org/xen-devel/28503e09-44c3-f623-bb8d-8778bb94225f@gmail.com/
>>
>> Changes RFC -> V2:
>>     - update patch description
>>     - drop uneeded "extended-region" DT property
>>
>> Changes V2 -> V3:
>>     - update patch description
>>     - add comment for "size" calculation in add_ext_regions()
>>     - clarify "end" calculation in find_unallocated_memory() and
>>       find_memory_holes()
>>     - only pick up regions with size >= 64MB
>>     - allocate reg dynamically instead of keeping on the stack in
>>       make_hypervisor_node()
>>     - do not show warning for 32-bit domain
>>     - drop Linux specific limits EXT_REGION_*
>>     - also cover "ranges" property in find_memory_holes()
>>     - add command line arg to enable/disable extended region support
>>
>> Changes V3 -> V4:
>>    - update opt_ext_regions purpose and comment in code
>>    - reorganize make_hypervisor_node() to move allocations after initial
>>      checks, allocate only required amount of elements instead of maximum
>>      possible
>> ---
>>   docs/misc/xen-command-line.pandoc |  11 ++
>>   xen/arch/arm/domain_build.c       | 286 +++++++++++++++++++++++++++++++++++++-
>>   2 files changed, 294 insertions(+), 3 deletions(-)
>>
>> diff --git a/docs/misc/xen-command-line.pandoc b/docs/misc/xen-command-line.pandoc
>> index 177e656..5cae4ad 100644
>> --- a/docs/misc/xen-command-line.pandoc
>> +++ b/docs/misc/xen-command-line.pandoc
>> @@ -1081,6 +1081,17 @@ hardware domain is architecture dependent.
>>   Note that specifying zero as domU value means zero, while for dom0 it means
>>   to use the default.
>>   
>> +### ext_regions (Arm)
>> +> `= <boolean>`
>> +
>> +> Default : `true`
>> +
>> +Flag to enable or disable support for extended regions for Dom0.
>> +
>> +Extended regions are ranges of unused address space exposed to Dom0 as
>> +"safe to use" for special memory mappings. Disable if your board device
>> +tree is incomplete.
>> +
>>   ### flask
>>   > `= permissive | enforcing | late | disabled`
>>   
>> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
>> index d233d63..c5afbe2 100644
>> --- a/xen/arch/arm/domain_build.c
>> +++ b/xen/arch/arm/domain_build.c
>> @@ -34,6 +34,10 @@
>>   static unsigned int __initdata opt_dom0_max_vcpus;
>>   integer_param("dom0_max_vcpus", opt_dom0_max_vcpus);
>>   
>> +/* If true, the extended regions support is enabled for dom0 */
>> +static bool __initdata opt_ext_regions = true;
>> +boolean_param("ext_regions", opt_ext_regions);
>> +
>>   static u64 __initdata dom0_mem;
>>   static bool __initdata dom0_mem_set;
>>   
>> @@ -886,6 +890,232 @@ static int __init make_memory_node(const struct domain *d,
>>       return res;
>>   }
>>   
>> +static int __init add_ext_regions(unsigned long s, unsigned long e, void *data)
>> +{
>> +    struct meminfo *ext_regions = data;
>> +    paddr_t start, size;
>> +
>> +    if ( ext_regions->nr_banks >= ARRAY_SIZE(ext_regions->bank) )
>> +        return 0;
>> +
>> +    /* Both start and size of the extended region should be 2MB aligned */
>> +    start = (s + SZ_2M - 1) & ~(SZ_2M - 1);
>> +    if ( start > e )
>> +        return 0;
>> +
>> +    /*
>> +     * e is actually "end-1" because it is called by rangeset functions
>> +     * which are inclusive of the last address.
>> +     */
>> +    e += 1;
>> +    size = (e - start) & ~(SZ_2M - 1);
>> +    if ( size < MB(64) )
>> +        return 0;
>> +
>> +    ext_regions->bank[ext_regions->nr_banks].start = start;
>> +    ext_regions->bank[ext_regions->nr_banks].size = size;
>> +    ext_regions->nr_banks++;
>> +
>> +    return 0;
>> +}
>> +
>> +static int __init find_unallocated_memory(const struct kernel_info *kinfo,
>> +                                          struct meminfo *ext_regions)
>> +{
>> +    const struct meminfo *assign_mem = &kinfo->mem;
>> +    struct rangeset *unalloc_mem;
>> +    paddr_t start, end;
>> +    unsigned int i;
>> +    int res;
>> +
>> +    dt_dprintk("Find unallocated memory for extended regions\n");
>> +
>> +    unalloc_mem = rangeset_new(NULL, NULL, 0);
>> +    if ( !unalloc_mem )
>> +        return -ENOMEM;
>> +
>> +    /* Start with all available RAM */
>> +    for ( i = 0; i < bootinfo.mem.nr_banks; i++ )
>> +    {
>> +        start = bootinfo.mem.bank[i].start;
>> +        end = bootinfo.mem.bank[i].start + bootinfo.mem.bank[i].size;
>> +        res = rangeset_add_range(unalloc_mem, start, end - 1);
>> +        if ( res )
>> +        {
>> +            printk(XENLOG_ERR "Failed to add: %#"PRIx64"->%#"PRIx64"\n",
>> +                   start, end);
>> +            goto out;
>> +        }
>> +    }
>> +
>> +    /* Remove RAM assigned to Dom0 */
>> +    for ( i = 0; i < assign_mem->nr_banks; i++ )
>> +    {
>> +        start = assign_mem->bank[i].start;
>> +        end = assign_mem->bank[i].start + assign_mem->bank[i].size;
>> +        res = rangeset_remove_range(unalloc_mem, start, end - 1);
>> +        if ( res )
>> +        {
>> +            printk(XENLOG_ERR "Failed to remove: %#"PRIx64"->%#"PRIx64"\n",
>> +                   start, end);
>> +            goto out;
>> +        }
>> +    }
>> +
>> +    /* Remove reserved-memory regions */
>> +    for ( i = 0; i < bootinfo.reserved_mem.nr_banks; i++ )
>> +    {
>> +        start = bootinfo.reserved_mem.bank[i].start;
>> +        end = bootinfo.reserved_mem.bank[i].start +
>> +            bootinfo.reserved_mem.bank[i].size;
>> +        res = rangeset_remove_range(unalloc_mem, start, end - 1);
>> +        if ( res )
>> +        {
>> +            printk(XENLOG_ERR "Failed to remove: %#"PRIx64"->%#"PRIx64"\n",
>> +                   start, end);
>> +            goto out;
>> +        }
>> +    }
>> +
>> +    /* Remove grant table region */
>> +    start = kinfo->gnttab_start;
>> +    end = kinfo->gnttab_start + kinfo->gnttab_size;
>> +    res = rangeset_remove_range(unalloc_mem, start, end - 1);
>> +    if ( res )
>> +    {
>> +        printk(XENLOG_ERR "Failed to remove: %#"PRIx64"->%#"PRIx64"\n",
>> +               start, end);
>> +        goto out;
>> +    }
>> +
>> +    start = 0;
>> +    end = (1ULL << p2m_ipa_bits) - 1;
>> +    res = rangeset_report_ranges(unalloc_mem, start, end,
>> +                                 add_ext_regions, ext_regions);
>> +    if ( res )
>> +        ext_regions->nr_banks = 0;
>> +    else if ( !ext_regions->nr_banks )
>> +        res = -ENOENT;
>> +
>> +out:
>> +    rangeset_destroy(unalloc_mem);
>> +
>> +    return res;
>> +}
>> +
>> +static int __init find_memory_holes(const struct kernel_info *kinfo,
>> +                                    struct meminfo *ext_regions)
>> +{
>> +    struct dt_device_node *np;
>> +    struct rangeset *mem_holes;
>> +    paddr_t start, end;
>> +    unsigned int i;
>> +    int res;
>> +
>> +    dt_dprintk("Find memory holes for extended regions\n");
>> +
>> +    mem_holes = rangeset_new(NULL, NULL, 0);
>> +    if ( !mem_holes )
>> +        return -ENOMEM;
>> +
>> +    /* Start with maximum possible addressable physical memory range */
>> +    start = 0;
>> +    end = (1ULL << p2m_ipa_bits) - 1;
>> +    res = rangeset_add_range(mem_holes, start, end);
>> +    if ( res )
>> +    {
>> +        printk(XENLOG_ERR "Failed to add: %#"PRIx64"->%#"PRIx64"\n",
>> +               start, end);
>> +        goto out;
>> +    }
>> +
>> +    /*
>> +     * Remove regions described by "reg" and "ranges" properties where
>> +     * the memory is addressable (MMIO, RAM, PCI BAR, etc).
>> +     */
>> +    dt_for_each_device_node( dt_host, np )
>> +    {
>> +        unsigned int naddr;
>> +        u64 addr, size;
>> +
>> +        naddr = dt_number_of_address(np);
>> +
>> +        for ( i = 0; i < naddr; i++ )
>> +        {
>> +            res = dt_device_get_address(np, i, &addr, &size);
>> +            if ( res )
>> +            {
>> +                printk(XENLOG_ERR "Unable to retrieve address %u for %s\n",
>> +                       i, dt_node_full_name(np));
>> +                goto out;
>> +            }
>> +
>> +            start = addr & PAGE_MASK;
>> +            end = PAGE_ALIGN(addr + size);
>> +            res = rangeset_remove_range(mem_holes, start, end - 1);
>> +            if ( res )
>> +            {
>> +                printk(XENLOG_ERR "Failed to remove: %#"PRIx64"->%#"PRIx64"\n",
>> +                       start, end);
>> +                goto out;
>> +            }
>> +        }
>> +
>> +        if ( dt_device_type_is_equal(np, "pci" ) )
>> +        {
>> +            unsigned int range_size, nr_ranges;
>> +            int na, ns, pna;
>> +            const __be32 *ranges;
>> +            u32 len;
>> +
>> +            /*
>> +             * Looking for non-empty ranges property which in this context
>> +             * describes the PCI host bridge aperture.
>> +             */
>> +            ranges = dt_get_property(np, "ranges", &len);
>> +            if ( !ranges || !len )
>> +                continue;
>> +
>> +            pna = dt_n_addr_cells(np);
>> +            na = dt_child_n_addr_cells(np);
>> +            ns = dt_child_n_size_cells(np);
>> +            range_size = pna + na + ns;
>> +            nr_ranges = len / sizeof(__be32) / range_size;
>> +
>> +            for ( i = 0; i < nr_ranges; i++, ranges += range_size )
>> +            {
>> +                /* Skip the child address and get the parent (CPU) address */
>> +                addr = dt_read_number(ranges + na, pna);
>> +                size = dt_read_number(ranges + na + pna, ns);
>> +
>> +                start = addr & PAGE_MASK;
>> +                end = PAGE_ALIGN(addr + size);
>> +                res = rangeset_remove_range(mem_holes, start, end - 1);
>> +                if ( res )
>> +                {
>> +                    printk(XENLOG_ERR "Failed to remove: %#"PRIx64"->%#"PRIx64"\n",
>> +                           start, end);
>> +                    goto out;
>> +                }
>> +            }
>> +        }
>> +    }
>> +
>> +    start = 0;
>> +    end = (1ULL << p2m_ipa_bits) - 1;
>> +    res = rangeset_report_ranges(mem_holes, start, end,
>> +                                 add_ext_regions,  ext_regions);
>> +    if ( res )
>> +        ext_regions->nr_banks = 0;
>> +    else if ( !ext_regions->nr_banks )
>> +        res = -ENOENT;
>> +
>> +out:
>> +    rangeset_destroy(mem_holes);
>> +
>> +    return res;
>> +}
>> +
>>   static int __init make_hypervisor_node(struct domain *d,
>>                                          const struct kernel_info *kinfo,
>>                                          int addrcells, int sizecells)
>> @@ -893,11 +1123,12 @@ static int __init make_hypervisor_node(struct domain *d,
>>       const char compat[] =
>>           "xen,xen-"__stringify(XEN_VERSION)"."__stringify(XEN_SUBVERSION)"\0"
>>           "xen,xen";
>> -    __be32 reg[4];
>> +    __be32 *reg, *cells;
>>       gic_interrupt_t intr;
>> -    __be32 *cells;
>>       int res;
>>       void *fdt = kinfo->fdt;
>> +    struct meminfo *ext_regions = NULL;
>> +    unsigned int i, nr_ext_regions;
>>   
>>       dt_dprintk("Create hypervisor node\n");
>>   
>> @@ -919,12 +1150,61 @@ static int __init make_hypervisor_node(struct domain *d,
>>       if ( res )
>>           return res;
>>   
>> +    if ( !opt_ext_regions )
>> +    {
>> +        printk(XENLOG_DEBUG "The extended regions support is disabled\n");
>> +        nr_ext_regions = 0;
>> +    }
>> +    else if ( is_32bit_domain(d) )
>> +    {
>> +        printk(XENLOG_DEBUG "The extended regions are only supported for 64-bit guest currently\n");
>> +        nr_ext_regions = 0;
>> +    }
>> +    else
>> +    {
>> +        ext_regions = xzalloc(struct meminfo);
>> +        if ( !ext_regions )
>> +            return -ENOMEM;
>> +
>> +        if ( !is_iommu_enabled(d) )
>> +            res = find_unallocated_memory(kinfo, ext_regions);
>> +        else
>> +            res = find_memory_holes(kinfo, ext_regions);
>> +
>> +        if ( res )
>> +            printk(XENLOG_WARNING "Failed to allocate extended regions\n");
>> +        nr_ext_regions = ext_regions->nr_banks;
>> +    }
>> +
>> +    reg = xzalloc_array(__be32, (nr_ext_regions + 1) * (addrcells + sizecells));
>> +    if ( !reg )
>> +    {
>> +        xfree(ext_regions);
>> +        return -ENOMEM;
>> +    }
>> +
>>       /* reg 0 is grant table space */
>>       cells = &reg[0];
>>       dt_child_set_range(&cells, addrcells, sizecells,
>>                          kinfo->gnttab_start, kinfo->gnttab_size);
>> +    /* reg 1...N are extended regions */
>> +    for ( i = 0; i < nr_ext_regions; i++ )
>> +    {
>> +        u64 start = ext_regions->bank[i].start;
>> +        u64 size = ext_regions->bank[i].size;
>> +
>> +        dt_dprintk("Extended region %d: %#"PRIx64"->%#"PRIx64"\n",
>> +                   i, start, start + size);
>> +
>> +        dt_child_set_range(&cells, addrcells, sizecells, start, size);
>> +    }
>> +
>>       res = fdt_property(fdt, "reg", reg,
>> -                       dt_cells_to_size(addrcells + sizecells));
>> +                       dt_cells_to_size(addrcells + sizecells) *
>> +                       (nr_ext_regions + 1));
>> +    xfree(ext_regions);
>> +    xfree(reg);
>> +
>>       if ( res )
>>           return res;
>>   
>> -- 
>> 2.7.4
>>
-- 
Regards,

Oleksandr Tyshchenko



From xen-devel-bounces@lists.xenproject.org Sat Oct 02 14:08:34 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 02 Oct 2021 14:08:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.201077.355492 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mWfgb-0004Sp-EN; Sat, 02 Oct 2021 14:08:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 201077.355492; Sat, 02 Oct 2021 14:08:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mWfgb-0004Si-BR; Sat, 02 Oct 2021 14:08:21 +0000
Received: by outflank-mailman (input) for mailman id 201077;
 Sat, 02 Oct 2021 14:08:19 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+enT=OW=gmail.com=olekstysh@srs-us1.protection.inumbo.net>)
 id 1mWfgZ-0004Sc-PQ
 for xen-devel@lists.xenproject.org; Sat, 02 Oct 2021 14:08:19 +0000
Received: from mail-lf1-x134.google.com (unknown [2a00:1450:4864:20::134])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id e2fcc462-1edb-45e6-bf61-5adb574e05c9;
 Sat, 02 Oct 2021 14:08:16 +0000 (UTC)
Received: by mail-lf1-x134.google.com with SMTP id i25so50446655lfg.6
 for <xen-devel@lists.xenproject.org>; Sat, 02 Oct 2021 07:08:16 -0700 (PDT)
Received: from [192.168.1.7] ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id 11sm228781lfr.267.2021.10.02.07.08.14
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Sat, 02 Oct 2021 07:08:15 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e2fcc462-1edb-45e6-bf61-5adb574e05c9
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-language;
        bh=QMUC0K2Ps8HQjCCG1Rlh7+xCnhuD+dz8MT5HW5UUGps=;
        b=UlzfPaEQaV2hZPjLC1FuubUQ15iBXQ5E7MzzZUMkbs8AJA0VKDwk6OcgLzpOMq9BAw
         2X3CDgk3q9tM1iV7y1kNoswSwzHXoGKUt9e7Aj7BFNnRjrjZK5ltF0Qpfu4j6yHl9ZPN
         k+CIQxCK9eq6T/5y34wQVf0mtrctfeGmULb7ByfjRj7TnSYzkxb4VZwOoeQjq26Sw5gO
         vkHVh1CeJkKCRn/bnb5UWF3lfLNM2cEiHVc7C5FQcVERsX9UVlvpiRtjny1Xph8gFDPw
         opLty+ApLNdGgfkgG4GSnZKN82YYmi0OHKC5wjDEm63JhVdUXPHjYriupFA2ha6LVGia
         IjSw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-language;
        bh=QMUC0K2Ps8HQjCCG1Rlh7+xCnhuD+dz8MT5HW5UUGps=;
        b=46n44pg8IvejdVGW53/TSVlmvXckOe4aYJGB+q4X32ecl5QyaczdSzpfTJIEaq4yu3
         nvz/4zH8GOMUX31PK0HK7SvtxvWKl/c7mq2fg6G+d/+wXI/H1JwvuLxBCDx696s4oJlm
         VDW5oDWV5z/dktcY0/5ApLby+NuCh4IXfPdkE6qV9vdTi9wS9Q9a61SoUc8HbYWw+HZy
         H5s2zGs8yHLOiQFxJfx5+XHOLU72H5FOSGKRSXVtjYnHXMFAmd7P2Z4HsTi7ToZ1TF5c
         v8TS/fBIlLrZNL9IqsvC4d73pZLVTeMsANptOfyCn9FRMwjtjC35iyrpg6/tYYqA/vse
         Em0Q==
X-Gm-Message-State: AOAM531Nic0w/2fVeFskDtTUuxSueYaea+8pIGP866YoXrNR7q1vY+WS
	hS3xaxJ8v+6u+8gQJfQNUDUk1v81XV8=
X-Google-Smtp-Source: ABdhPJxapSDc6xMCl8RqWJHvN+p1EeZLF/wKTOoPbLaGRLTvfiSqr/7QAaSwOb8L8mgtwHEVFN1h5Q==
X-Received: by 2002:a05:6512:3d13:: with SMTP id d19mr3743813lfv.607.1633183695752;
        Sat, 02 Oct 2021 07:08:15 -0700 (PDT)
Subject: Re: [PATCH V4 1/3] xen: Introduce "gpaddr_bits" field to
 XEN_SYSCTL_physinfo
To: Julien Grall <julien.grall.oss@gmail.com>,
 Stefano Stabellini <sstabellini@kernel.org>
Cc: Jan Beulich <jbeulich@suse.com>,
 xen-devel <xen-devel@lists.xenproject.org>,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>,
 Anthony PERARD <anthony.perard@citrix.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Juergen Gross <jgross@suse.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Bertrand Marquis <Bertrand.Marquis@arm.com>
References: <1632955927-27911-1-git-send-email-olekstysh@gmail.com>
 <1632955927-27911-2-git-send-email-olekstysh@gmail.com>
 <alpine.DEB.2.21.2109301600060.3209@sstabellini-ThinkPad-T480s>
 <05b040b0-a069-47a1-1f5e-85be62fa35f3@suse.com>
 <bbbceae1-c382-5e48-0c6b-fbb23fc720f5@gmail.com>
 <alpine.DEB.2.21.2110011244000.3209@sstabellini-ThinkPad-T480s>
 <CAJ=z9a2bT4tMn2argJzePUMR2Ke4bmabj+j5QevvwpfnA9ST_w@mail.gmail.com>
From: Oleksandr <olekstysh@gmail.com>
Message-ID: <093bc1d5-bf6a-da0a-78b5-7a8dd471a063@gmail.com>
Date: Sat, 2 Oct 2021 17:08:14 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <CAJ=z9a2bT4tMn2argJzePUMR2Ke4bmabj+j5QevvwpfnA9ST_w@mail.gmail.com>
Content-Type: multipart/alternative;
 boundary="------------1CA69BF45EAC1E3C26988D15"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------1CA69BF45EAC1E3C26988D15
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit


On 02.10.21 10:35, Julien Grall wrote:

Hi Julien, Stefano.


Thank you for your comments!

> Hi
>
> On Sat, 2 Oct 2021, 01:24 Stefano Stabellini, <sstabellini@kernel.org 
> <mailto:sstabellini@kernel.org>> wrote:
>
>     Bertrand, see comment on ID_AA64MMFR0_EL1 below, any ideas?
>
>
>     On Fri, 1 Oct 2021, Oleksandr wrote:
>     > On 01.10.21 10:50, Jan Beulich wrote:
>     > > On 01.10.2021 01:00, Stefano Stabellini wrote:
>     > > > On Thu, 30 Sep 2021, Oleksandr Tyshchenko wrote:
>     > > > > From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com
>     <mailto:oleksandr_tyshchenko@epam.com>>
>     > > > >
>     > > > > We need to pass info about maximum supported guest address
>     > > > > space size to the toolstack on Arm in order to properly
>     > > > > calculate the base and size of the extended region (safe
>     range)
>     > > > > for the guest. The extended region is unused address space
>     which
>     > > > > could be safely used by domain for foreign/grant mappings
>     on Arm.
>     > > > > The extended region itself will be handled by the subsequents
>     > > > > patch.
>     > > > >
>     > > > > Use p2m_ipa_bits variable on Arm, the x86 equivalent is
>     > > > > hap_paddr_bits.
>     > > > >
>     > > > > As we change the size of structure bump the interface version.
>     > > > >
>     > > > > Suggested-by: Julien Grall <jgrall@amazon.com
>     <mailto:jgrall@amazon.com>>
>     > > > > Signed-off-by: Oleksandr Tyshchenko
>     <oleksandr_tyshchenko@epam.com <mailto:oleksandr_tyshchenko@epam.com>>
>     > > > > Reviewed-by: Michal Orzel <michal.orzel@arm.com
>     <mailto:michal.orzel@arm.com>>
>     > > > Reviewed-by: Stefano Stabellini <sstabellini@kernel.org
>     <mailto:sstabellini@kernel.org>>
>     > > I have to admit that I'm a little puzzled to see these R-b-s
>     when ...
>     > >
>     > > > > Please note, that review comments for the RFC version [1]
>     haven't been
>     > > > > addressed yet.
>     > > > > It is not forgotten, some clarification is needed. It will
>     be addressed
>     > > > > for the next version.
>     > > > >
>     > > > > [1]
>     > > > >
>     https://lore.kernel.org/xen-devel/973f5344-aa10-3ad6-ff02-ad5f358ad279@citrix.com/
>     > > ... Oleksandr makes clear this patch isn't really ready yet.
>     >
>     > Unfortunately, this is true. I am still waiting for the
>     clarification [1]
>
>     Although I was aware of comments to older versions, this is
>     actually the
>     first version of this patch that I reviewed with any level of
>     details; I
>     didn't read previous comments very closely. I tried to find any
>     bugs or
>     problems with it and I couldn't see any, so I gave my reviewed-by. I
>     should have clarified that was meant for the ARM part as I don't
>     have a
>     full understanding of the implications of using hap_paddr_bits on x86
>     for VM migration.
>
>
>
>     But let me take this opportunity to say that although I think the
>     hypercall is OK, I wish we didn't need this patch at all: it is
>     problematic because it touches tools, x86 and ARM hypervisor code all
>     together. It needs at least three acks/reviewed-by to get
>     accepted: from
>     an x86 maintainer, an arm maintainer and from a tools maintainer. I
>     don't say this to criticize the patch acceptance process: this patch
>     makes changes to an existing hypercall so it is only fair that it
>     needs
>     to go through extra levels of scrutiny. For the sake of simplicity and
>     decoupling (reducing dependencies between patches and between
>     components), I think it would be best to introduce an #define for the
>     minimum value of gpaddr_bits and then move this patch at the end
>     of the
>     series; that way it becomes optional.
>
>
> It depends what you mean by optional. Yes we can add hack to avoid the 
> hypercall... But the more scalable solution is the hypercall.
>
> I am slightly concerned that if we don't push for the hypercall now, 
> then there will be no incentive to do it afterwards...
>
> So I went through Andrew's e-mail to understand what's the request. I 
> understand that there are some problem with migration. But it doesn't 
> look like we need to solve them now. Instead,  AFAICT, his main ask 
> for this series is to switch to a domctl.
>
> It seems the conversation is simply stuck on waiting for Andrew to 
> provide details on what would look like. Did we ping Andrew on IRC?
>
>     Unfortunately the minimum value
>     is 32 (in practice I have never seen less than 40 but the architecture
>     supports 32 as minimum).
>
>
>
>     Actually, the info we are looking for is already exposed via
>     ID_AA64MMFR0_EL1. ID_AA64MMFR0_EL1 can be read from a virtual machine,
>     and Linux let userspace read it [1]. Regardless of this patch
>     series, we
>     should make sure that Xen exposes the right mm64.pa_range value to
>     guest
>     virtual machines. If that is done right, then you can just add support
>     for reading ID_AA64MMFR0_EL1 in libxl/libxc and then we don't need any
>     hypercall modifications changes.
>
>
> From my understanding, from a VM PoV "pa_range" should represent the 
> size of the guest physical address space.
>
> Today, it happens that every VM is using the same P2M size. However, I 
> would rather not make such assumption in the userspace.
>
>
>     So, in theory we already have all the interfaces we need, but in
>     practice they don't work: unfortunaly both Xen and Linux mark
>     ID_AA64MMFR0_EL1 as FTR_HIDDEN in cpufeature.c so neither Linux from
>     Xen, not userspace from Linux can actually read the real value :-/
>     They always read zero.
>
>     (Also I think we have an issue today with p2m_restrict_ipa_bits not
>     updating the mm64.pa_range value. I think that it should be fixed.)
>
>
> It looks like it. That should be handled in a separate patch though.
>
>
>     Bertrand, do you have any ideas in regards to ID_AA64MMFR0_EL1?
>
>     If not, maybe we could just go with
>     #define MIN_GPADDR_BITS 32.
>
>
> The toolstack would have to consider it as the "maximum" because it 
> may not be safe to expose anything above.
>
> With 32, we are going to be limited in term of space we can find.
>
> We could potentially use 40 bits as a minimum. Although it still feels 
> a bit of a hack to me given that the IOMMU may restrict it further and 
> the architecture can in theory support less.
>
> Overall, I still strongly prefer the hypercall approach. If a common 
> one is difficult to achieve, then we can extend the domctl to create a 
> domain to provide the p2m_bits (in the same way as we deal for the GIC 
> version) in an arch specific way.


To summarize:
If we don't query the hypervisor to provide gpaddr_bits we have two options:
- The safe option is to use minimum possible value which is 32 bits on 
Arm64. But, there would be of no practical use.
- The unsafe option is to use let's say "default" 40 bits and pray it 
will work in all cases on Arm64 (it is ok on Arm32).

So we definitely need to query the hypervisor. As it turned out the 
sysctl approach is not welcome, in the long term we want to have this 
information per domain. I have been absolutely OK with that valid ask 
since RFC, I just wanted to know what was the preferred way to do this 
(new domctl, existing, etc)...

I analyzed what Julien had suggested regarding pass gpaddr_bits via 
Arm's struct xen_arch_domainconfig (I assume, this should be an OUT 
parameter) and I think it makes sense. Taking into the account that the 
feature freeze date is coming, I will wait a few days, and if there are 
no objections I will send updated version (patch #3 also needs updating 
as it expects the gpaddr_bits to be in physinfo).


>
> Cheers,
>
>
>
>     [1]
>     https://01.org/linuxgraphics/gfx-docs/drm/arm64/cpu-feature-registers.html
>
-- 
Regards,

Oleksandr Tyshchenko


--------------1CA69BF45EAC1E3C26988D15
Content-Type: text/html; charset=utf-8
Content-Transfer-Encoding: 8bit

<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
  </head>
  <body>
    <p><br>
    </p>
    <div class="moz-cite-prefix">On 02.10.21 10:35, Julien Grall wrote:</div>
    <div class="moz-cite-prefix"><br>
    </div>
    <div class="moz-cite-prefix">Hi Julien, Stefano.<br>
    </div>
    <div class="moz-cite-prefix"><br>
    </div>
    <div class="moz-cite-prefix"><br>
    </div>
    <div class="moz-cite-prefix">Thank you for your comments!<br>
    </div>
    <div class="moz-cite-prefix"><br>
    </div>
    <blockquote type="cite"
cite="mid:CAJ=z9a2bT4tMn2argJzePUMR2Ke4bmabj+j5QevvwpfnA9ST_w@mail.gmail.com">
      <meta http-equiv="content-type" content="text/html; charset=UTF-8">
      <div dir="auto">
        <div>Hi<br>
          <br>
          <div class="gmail_quote">
            <div dir="ltr" class="gmail_attr">On Sat, 2 Oct 2021, 01:24
              Stefano Stabellini, &lt;<a
                href="mailto:sstabellini@kernel.org" target="_blank"
                rel="noreferrer" moz-do-not-send="true">sstabellini@kernel.org</a>&gt;
              wrote:<br>
            </div>
            <blockquote class="gmail_quote" style="margin:0 0 0
              .8ex;border-left:1px #ccc solid;padding-left:1ex">Bertrand,
              see comment on ID_AA64MMFR0_EL1 below, any ideas?<br>
              <br>
              <br>
              On Fri, 1 Oct 2021, Oleksandr wrote:<br>
              &gt; On 01.10.21 10:50, Jan Beulich wrote:<br>
              &gt; &gt; On 01.10.2021 01:00, Stefano Stabellini wrote:<br>
              &gt; &gt; &gt; On Thu, 30 Sep 2021, Oleksandr Tyshchenko
              wrote:<br>
              &gt; &gt; &gt; &gt; From: Oleksandr Tyshchenko &lt;<a
                href="mailto:oleksandr_tyshchenko@epam.com"
                rel="noreferrer noreferrer" target="_blank"
                moz-do-not-send="true">oleksandr_tyshchenko@epam.com</a>&gt;<br>
              &gt; &gt; &gt; &gt; <br>
              &gt; &gt; &gt; &gt; We need to pass info about maximum
              supported guest address<br>
              &gt; &gt; &gt; &gt; space size to the toolstack on Arm in
              order to properly<br>
              &gt; &gt; &gt; &gt; calculate the base and size of the
              extended region (safe range)<br>
              &gt; &gt; &gt; &gt; for the guest. The extended region is
              unused address space which<br>
              &gt; &gt; &gt; &gt; could be safely used by domain for
              foreign/grant mappings on Arm.<br>
              &gt; &gt; &gt; &gt; The extended region itself will be
              handled by the subsequents<br>
              &gt; &gt; &gt; &gt; patch.<br>
              &gt; &gt; &gt; &gt; <br>
              &gt; &gt; &gt; &gt; Use p2m_ipa_bits variable on Arm, the
              x86 equivalent is<br>
              &gt; &gt; &gt; &gt; hap_paddr_bits.<br>
              &gt; &gt; &gt; &gt; <br>
              &gt; &gt; &gt; &gt; As we change the size of structure
              bump the interface version.<br>
              &gt; &gt; &gt; &gt; <br>
              &gt; &gt; &gt; &gt; Suggested-by: Julien Grall &lt;<a
                href="mailto:jgrall@amazon.com" rel="noreferrer
                noreferrer" target="_blank" moz-do-not-send="true">jgrall@amazon.com</a>&gt;<br>
              &gt; &gt; &gt; &gt; Signed-off-by: Oleksandr Tyshchenko
              &lt;<a href="mailto:oleksandr_tyshchenko@epam.com"
                rel="noreferrer noreferrer" target="_blank"
                moz-do-not-send="true">oleksandr_tyshchenko@epam.com</a>&gt;<br>
              &gt; &gt; &gt; &gt; Reviewed-by: Michal Orzel &lt;<a
                href="mailto:michal.orzel@arm.com" rel="noreferrer
                noreferrer" target="_blank" moz-do-not-send="true">michal.orzel@arm.com</a>&gt;<br>
              &gt; &gt; &gt; Reviewed-by: Stefano Stabellini &lt;<a
                href="mailto:sstabellini@kernel.org" rel="noreferrer
                noreferrer" target="_blank" moz-do-not-send="true">sstabellini@kernel.org</a>&gt;<br>
              &gt; &gt; I have to admit that I'm a little puzzled to see
              these R-b-s when ...<br>
              &gt; &gt; <br>
              &gt; &gt; &gt; &gt; Please note, that review comments for
              the RFC version [1] haven't been<br>
              &gt; &gt; &gt; &gt; addressed yet.<br>
              &gt; &gt; &gt; &gt; It is not forgotten, some
              clarification is needed. It will be addressed<br>
              &gt; &gt; &gt; &gt; for the next version.<br>
              &gt; &gt; &gt; &gt; <br>
              &gt; &gt; &gt; &gt; [1]<br>
              &gt; &gt; &gt; &gt; <a
href="https://lore.kernel.org/xen-devel/973f5344-aa10-3ad6-ff02-ad5f358ad279@citrix.com/"
                rel="noreferrer noreferrer noreferrer" target="_blank"
                moz-do-not-send="true">https://lore.kernel.org/xen-devel/973f5344-aa10-3ad6-ff02-ad5f358ad279@citrix.com/</a><br>
              &gt; &gt; ... Oleksandr makes clear this patch isn't
              really ready yet.<br>
              &gt; <br>
              &gt; Unfortunately, this is true. I am still waiting for
              the clarification [1]<br>
              <br>
              Although I was aware of comments to older versions, this
              is actually the<br>
              first version of this patch that I reviewed with any level
              of details; I<br>
              didn't read previous comments very closely. I tried to
              find any bugs or<br>
              problems with it and I couldn't see any, so I gave my
              reviewed-by. I<br>
              should have clarified that was meant for the ARM part as I
              don't have a<br>
              full understanding of the implications of using
              hap_paddr_bits on x86<br>
              for VM migration.</blockquote>
            <blockquote class="gmail_quote" style="margin:0 0 0
              .8ex;border-left:1px #ccc solid;padding-left:1ex">
              <br>
              <br>
              But let me take this opportunity to say that although I
              think the<br>
              hypercall is OK, I wish we didn't need this patch at all:
              it is<br>
              problematic because it touches tools, x86 and ARM
              hypervisor code all<br>
              together. It needs at least three acks/reviewed-by to get
              accepted: from<br>
              an x86 maintainer, an arm maintainer and from a tools
              maintainer. I<br>
              don't say this to criticize the patch acceptance process:
              this patch<br>
              makes changes to an existing hypercall so it is only fair
              that it needs<br>
              to go through extra levels of scrutiny. For the sake of
              simplicity and<br>
              decoupling (reducing dependencies between patches and
              between<br>
              components), I think it would be best to introduce an
              #define for the<br>
              minimum value of gpaddr_bits and then move this patch at
              the end of the<br>
              series; that way it becomes optional.</blockquote>
          </div>
        </div>
        <div dir="auto"><br>
        </div>
        <div dir="auto">It depends what you mean by optional. Yes we can
          add hack to avoid the hypercall... But the more scalable
          solution is the hypercall.</div>
        <div dir="auto"><br>
        </div>
        <div dir="auto">I am slightly concerned that if we don't push
          for the hypercall now, then there will be no incentive to do
          it afterwards...</div>
        <div dir="auto"><br>
        </div>
        <div dir="auto">So I went through Andrew's e-mail to understand
          what's the request. I understand that there are some problem
          with migration. But it doesn't look like we need to solve them
          now. Instead,  AFAICT, his main ask for this series is to
          switch to a domctl.</div>
        <div dir="auto"><br>
        </div>
        <div dir="auto">It seems the conversation is simply stuck on
          waiting for Andrew to provide details on what would look like.
          Did we ping Andrew on IRC?</div>
        <div dir="auto"><br>
        </div>
        <div dir="auto">
          <div class="gmail_quote">
            <blockquote class="gmail_quote" style="margin:0 0 0
              .8ex;border-left:1px #ccc solid;padding-left:1ex">
              Unfortunately the minimum value<br>
              is 32 (in practice I have never seen less than 40 but the
              architecture<br>
              supports 32 as minimum).</blockquote>
          </div>
        </div>
        <div dir="auto">
          <div class="gmail_quote">
            <blockquote class="gmail_quote" style="margin:0 0 0
              .8ex;border-left:1px #ccc solid;padding-left:1ex">
              <br>
              <br>
              Actually, the info we are looking for is already exposed
              via<br>
              ID_AA64MMFR0_EL1. ID_AA64MMFR0_EL1 can be read from a
              virtual machine,<br>
              and Linux let userspace read it [1]. Regardless of this
              patch series, we<br>
              should make sure that Xen exposes the right mm64.pa_range
              value to guest<br>
              virtual machines. If that is done right, then you can just
              add support<br>
              for reading ID_AA64MMFR0_EL1 in libxl/libxc and then we
              don't need any<br>
              hypercall modifications changes.</blockquote>
          </div>
        </div>
        <div dir="auto"><br>
        </div>
        <div dir="auto">From my understanding, from a VM PoV "pa_range"
          should represent the size of the guest physical address space.</div>
        <div dir="auto"><br>
        </div>
        <div dir="auto">Today, it happens that every VM is using the
          same P2M size. However, I would rather not make such
          assumption in the userspace.</div>
        <div dir="auto"><br>
        </div>
        <div dir="auto">
          <div class="gmail_quote">
            <blockquote class="gmail_quote" style="margin:0 0 0
              .8ex;border-left:1px #ccc solid;padding-left:1ex">
              <br>
              So, in theory we already have all the interfaces we need,
              but in<br>
              practice they don't work: unfortunaly both Xen and Linux
              mark<br>
              ID_AA64MMFR0_EL1 as FTR_HIDDEN in cpufeature.c so neither
              Linux from<br>
              Xen, not userspace from Linux can actually read the real
              value :-/<br>
              They always read zero.<br>
              <br>
              (Also I think we have an issue today with
              p2m_restrict_ipa_bits not<br>
              updating the mm64.pa_range value. I think that it should
              be fixed.)</blockquote>
          </div>
        </div>
        <div dir="auto"><br>
        </div>
        <div dir="auto">It looks like it. That should be handled in a
          separate patch though.</div>
        <div dir="auto"><br>
        </div>
        <div dir="auto">
          <div class="gmail_quote">
            <blockquote class="gmail_quote" style="margin:0 0 0
              .8ex;border-left:1px #ccc solid;padding-left:1ex">
              <br>
              Bertrand, do you have any ideas in regards to
              ID_AA64MMFR0_EL1?<br>
              <br>
              If not, maybe we could just go with<br>
              #define MIN_GPADDR_BITS 32.</blockquote>
          </div>
        </div>
        <div dir="auto"><br>
        </div>
        <div dir="auto">The toolstack would have to consider it as the
          "maximum" because it may not be safe to expose anything above.</div>
        <div dir="auto"><br>
        </div>
        <div dir="auto">With 32, we are going to be limited in term of
          space we can find.</div>
        <div dir="auto"><br>
        </div>
        <div dir="auto">We could potentially use 40 bits as a minimum.
          Although it still feels a bit of a hack to me given that the
          IOMMU may restrict it further and the architecture can in
          theory support less.</div>
        <div dir="auto"><br>
        </div>
        <div dir="auto">Overall, I still strongly prefer the hypercall
          approach. If a common one is difficult to achieve, then we can
          extend the domctl to create a domain to provide the p2m_bits
          (in the same way as we deal for the GIC version) in an arch
          specific way.</div>
      </div>
    </blockquote>
    <p><br>
    </p>
    To summarize:<br>
    If we don't query the hypervisor to provide gpaddr_bits we have two
    options:<br>
    - The safe option is to use minimum possible value which is 32 bits
    on Arm64. But, there would be of no practical use.<br>
    - The unsafe option is to use let's say "default" 40 bits and pray
    it will work in all cases on Arm64 (it is ok on Arm32).<br>
    <br>
    So we definitely need to query the hypervisor. As it turned out the
    sysctl approach is not welcome, in the long term we want to have
    this information per domain. I have been absolutely OK with that
    valid ask since RFC, I just wanted to know what was the preferred
    way to do this (new domctl, existing, etc)...<br>
    <br>
    I analyzed what Julien had suggested regarding pass gpaddr_bits via
    Arm's struct xen_arch_domainconfig (I assume, this should be an OUT
    parameter) and I think it makes sense. Taking into the account that
    the feature freeze date is coming, I will wait a few days, and if
    there are no objections I will send updated version (patch #3 also
    needs updating as it expects the gpaddr_bits to be in physinfo).<br>
    <p><br>
    </p>
    <blockquote type="cite"
cite="mid:CAJ=z9a2bT4tMn2argJzePUMR2Ke4bmabj+j5QevvwpfnA9ST_w@mail.gmail.com">
      <div dir="auto">
        <div dir="auto"><br>
        </div>
        <div dir="auto">Cheers,</div>
        <div dir="auto"><br>
        </div>
        <div dir="auto">
          <div class="gmail_quote">
            <blockquote class="gmail_quote" style="margin:0 0 0
              .8ex;border-left:1px #ccc solid;padding-left:1ex">
              <br>
              <br>
              [1] <a
href="https://01.org/linuxgraphics/gfx-docs/drm/arm64/cpu-feature-registers.html"
                rel="noreferrer noreferrer noreferrer" target="_blank"
                moz-do-not-send="true">https://01.org/linuxgraphics/gfx-docs/drm/arm64/cpu-feature-registers.html</a><br>
            </blockquote>
          </div>
        </div>
      </div>
    </blockquote>
    <pre class="moz-signature" cols="72">-- 
Regards,

Oleksandr Tyshchenko</pre>
  </body>
</html>

--------------1CA69BF45EAC1E3C26988D15--


From xen-devel-bounces@lists.xenproject.org Sat Oct 02 17:56:02 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 02 Oct 2021 17:56:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.201087.355504 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mWjEe-0008CS-Ra; Sat, 02 Oct 2021 17:55:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 201087.355504; Sat, 02 Oct 2021 17:55:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mWjEe-0008CL-ON; Sat, 02 Oct 2021 17:55:44 +0000
Received: by outflank-mailman (input) for mailman id 201087;
 Sat, 02 Oct 2021 17:55:43 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+enT=OW=gmail.com=olekstysh@srs-us1.protection.inumbo.net>)
 id 1mWjEd-0008CF-49
 for xen-devel@lists.xenproject.org; Sat, 02 Oct 2021 17:55:43 +0000
Received: from mail-wr1-x42a.google.com (unknown [2a00:1450:4864:20::42a])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id fb6ae533-aec7-41fb-aa02-5116749ef5e4;
 Sat, 02 Oct 2021 17:55:40 +0000 (UTC)
Received: by mail-wr1-x42a.google.com with SMTP id e12so865637wra.4
 for <xen-devel@lists.xenproject.org>; Sat, 02 Oct 2021 10:55:40 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fb6ae533-aec7-41fb-aa02-5116749ef5e4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=dGngKMFKjPa3XOQmsnwRlPEwLV/SMPNEraEuuXUBR+Y=;
        b=VaD604MIZtcUU+dz0a7QMfUoYaOkkqkxtXje+TMg6U5JYhxBI2HlE/wKafZPxFaeq9
         rX2Q5+6IXm7LEPGSACTLHaE0YMefhZohXkLZvK8zuuFYOaezRGQYFh+4XFG94oZfuy8X
         F4cNt6BQo7SGfVhlLkMESiQwS4NG96aXfsopktY+merkhc9aHpwqU7WUbtt51jK41qym
         RcfZUpJRjhWDp05rzdWll9WBgyycC3FWFi6R6iygvujxDRHJhYYV9XmFilVS6CKyZ2mE
         iILVjtvnJ/+yQq8KCJgRt+tzcOBSADUEjd0an1uzdW2LGN2Zo56hSUTIfJx92WVXUqYR
         oiRQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=dGngKMFKjPa3XOQmsnwRlPEwLV/SMPNEraEuuXUBR+Y=;
        b=f52HMMX6m6gWzZHzEeNwaQMKk61pMC5F4b5qCdeN0PJB/NiJ2E4RAsZ5zQyeKQ9ZEb
         FH3HAttO8zoKil+0YOkKd9i8xNrup6P/dguG/Gd3OKCYMHzVcbDS5jVAOKK3ZIt4Ah4Z
         MN0MKh46scHOhpxUCJC+NNvIvPUz16etaVspFqHSUCG5gPhpBKBTvNQthVy5UmqZLK/x
         yS2sWAS3Owe9AST9TYnNQV2GlcT2nfII5h6LdLFX8Dd6N9SPcqfI2FCsnOnoxHcXB8Hf
         01Iz7EdrToZeZ7e31b5+bv51Tf7wVoBWdokFZhQAlsflA8SUZ2dBwKzl78DSOg24FsrB
         43bQ==
X-Gm-Message-State: AOAM531aOOULrQcqxiXpHnqaMwxoQ1vcw3AKB4nIRlsUZjMHXGykLhSa
	PlIptdnjCdREpoJGcdnERCuQpxuOL9omPDvvxko=
X-Google-Smtp-Source: ABdhPJxeZ05uzvzfMnZZ8T3qniKSC5fkVQ+eJ6gLzDs/dkJkBIKbPHC8xlD699miunEqPLBln5s9iUBH6XHCpUMVV64=
X-Received: by 2002:a5d:4882:: with SMTP id g2mr4282753wrq.399.1633197339442;
 Sat, 02 Oct 2021 10:55:39 -0700 (PDT)
MIME-Version: 1.0
References: <87pmsylywy.fsf@linaro.org> <YU5mW396S04IsCBr@mail-itl>
 <874ka68h96.fsf@linaro.org> <CACMJ4GbgnQVQbH1N3Duxmx10n-Qv+zzncqarNyuhmKhE-wqdqA@mail.gmail.com>
 <alpine.DEB.2.21.2109272323160.5022@sstabellini-ThinkPad-T480s>
 <CAPD2p-=MdGB_a+oEsFrPQpLo7GeKkMwYyAWcQt3z0qrGr3vR7w@mail.gmail.com> <alpine.DEB.2.21.2110011649220.3209@sstabellini-ThinkPad-T480s>
In-Reply-To: <alpine.DEB.2.21.2110011649220.3209@sstabellini-ThinkPad-T480s>
From: Oleksandr Tyshchenko <olekstysh@gmail.com>
Date: Sat, 2 Oct 2021 20:55:28 +0300
Message-ID: <CAPD2p-m=hYbG1YjPZ9yZ7Qzs6KjCT2jSHpaDUPB0sFJoZfY4uw@mail.gmail.com>
Subject: Re: [Stratos-dev] Xen Rust VirtIO demos work breakdown for Project Stratos
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: xen-devel <xen-devel@lists.xenproject.org>, 
	Christopher Clark <christopher.w.clark@gmail.com>, =?UTF-8?B?QWxleCBCZW5uw6ll?= <alex.bennee@linaro.org>, 
	=?UTF-8?Q?Marek_Marczykowski=2DG=C3=B3recki?= <marmarek@invisiblethingslab.com>, 
	Artem Mygaiev <Artem_Mygaiev@epam.com>, Sergio Lopez <slp@redhat.com>, Wei Liu <wl@xen.org>, 
	Stefan Hajnoczi <stefanha@gmail.com>, Rust-VMM Mailing List <rust-vmm@lists.opendev.org>, 
	Doug Goldstein <cardoe@cardoe.com>, Andrew Cooper <andrew.cooper3@citrix.com>, 
	Arnd Bergmann <arnd.bergmann@linaro.org>, David Woodhouse <dwmw2@infradead.org>, 
	Stratos Mailing List <stratos-dev@op-lists.linaro.org>, Rich Persaud <persaur@gmail.com>, 
	Daniel Smith <dpsmith@apertussolutions.com>, Paul Durrant <paul@xen.org>, 
	openxt <openxt@googlegroups.com>, Julien Grall <julien@xen.org>
Content-Type: multipart/alternative; boundary="0000000000004401fb05cd6263d8"

--0000000000004401fb05cd6263d8
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Sat, Oct 2, 2021 at 2:58 AM Stefano Stabellini <sstabellini@kernel.org>
wrote:

Hi Stefano, all

[Sorry for the possible format issues]
[I have CCed Julien]


On Tue, 28 Sep 2021, Oleksandr Tyshchenko wrote:
> > On Tue, Sep 28, 2021 at 9:26 AM Stefano Stabellini <
> sstabellini@kernel.org> wrote:
> >
> > Hi Stefano, all
> >
> > [Sorry for the possible format issues]
> >
> >
> >       On Mon, 27 Sep 2021, Christopher Clark wrote:
> >       > On Mon, Sep 27, 2021 at 3:06 AM Alex Benn=C3=A9e via Stratos-de=
v <
> stratos-dev@op-lists.linaro.org> wrote:
> >       >
> >       >       Marek Marczykowski-G=C3=B3recki <
> marmarek@invisiblethingslab.com> writes:
> >       >
> >       >       > [[PGP Signed Part:Undecided]]
> >       >       > On Fri, Sep 24, 2021 at 05:02:46PM +0100, Alex Benn=C3=
=A9e
> wrote:
> >       >       >> Hi,
> >       >       >
> >       >       > Hi,
> >       >       >
> >       >       >> 2.1 Stable ABI for foreignmemory mapping to non-dom0
> ([STR-57])
> >       >       >>
> =E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=
=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=
=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=
=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=
=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=
=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=
=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=
=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80
> >       >       >>
> >       >       >>   Currently the foreign memory mapping support only
> works for dom0 due
> >       >       >>   to reference counting issues. If we are to support
> backends running in
> >       >       >>   their own domains this will need to get fixed.
> >       >       >>
> >       >       >>   Estimate: 8w
> >       >       >>
> >       >       >>
> >       >       >> [STR-57] <https://linaro.atlassian.net/browse/STR-57>
> >       >       >
> >       >       > I'm pretty sure it was discussed before, but I can't
> find relevant
> >       >       > (part of) thread right now: does your model assumes the
> backend (running
> >       >       > outside of dom0) will gain ability to map (or access in
> other way)
> >       >       > _arbitrary_ memory page of a frontend domain? Or worse:
> any domain?
> >       >
> >       >       The aim is for some DomU's to host backends for other
> DomU's instead of
> >       >       all backends being in Dom0. Those backend DomU's would
> have to be
> >       >       considered trusted because as you say the default memory
> model of VirtIO
> >       >       is to have full access to the frontend domains memory map=
.
> >       >
> >       >
> >       > I share Marek's concern. I believe that there are Xen-based
> systems that will want to run guests using VirtIO devices without
> >       extending
> >       > this level of trust to the backend domains.
> >
> >       >From a safety perspective, it would be challenging to deploy a
> system
> >       with privileged backends. From a safety perspective, it would be =
a
> lot
> >       easier if the backend were unprivileged.
> >
> >       This is one of those times where safety and security requirements
> are
> >       actually aligned.
> >
> >
> > Well, the foreign memory mapping has one advantage in the context of
> Virtio use-case
> > which is that Virtio infrastructure in Guest doesn't require any
> modifications to run on top Xen.
> > The only issue with foreign memory here is that Guest memory actually
> mapped without its agreement
> > which doesn't perfectly fit into the security model. (although there is
> one more issue with XSA-300,
> > but I think it will go away sooner or later, at least there are some
> attempts to eliminate it).
> > While the ability to map any part of Guest memory is not an issue for
> the backend running in Dom0
> > (which we usually trust), this will certainly violate Xen security mode=
l
> if we want to run it in other
> > domain, so I completely agree with the existing concern.
>
> Yep, that's what I was referring to.
>
>
> > It was discussed before [1], but I couldn't find any decisions regardin=
g
> that. As I understand,
> > the one of the possible ideas is to have some entity in Xen (PV
> IOMMU/virtio-iommu/whatever)
> > that works in protection mode, so it denies all foreign mapping request=
s
> from the backend running in DomU
> > by default and only allows requests with mapping which were *implicitly=
*
> granted by the Guest before.
> > For example, Xen could be informed which MMIOs hold the queue PFN and
> notify registers
> > (as it traps the accesses to these registers anyway) and could
> theoretically parse the frontend request
> > and retrieve descriptors to make a decision which GFNs are actually
> *allowed*.
> >
> > I can't say for sure (sorry not familiar enough with the topic), but
> implementing the virtio-iommu device
> > in Xen we could probably avoid Guest modifications at all. Of course,
> for this to work
> > the Virtio infrastructure in Guest should use DMA API as mentioned in
> [1].
> >
> > Would the =E2=80=9Crestricted foreign mapping=E2=80=9D solution retain =
the Xen security
> model and be accepted
> > by the Xen community? I wonder, has someone already looked in this
> direction, are there any
> > pitfalls here or is this even feasible?
> >
> > [1]
> https://lore.kernel.org/xen-devel/464e91ec-2b53-2338-43c7-a018087fc7f6@ar=
m.com/
>
> The discussion that went further is actually one based on the idea that
> there is a pre-shared memory area and the frontend always passes
> addresses from it. For ease of implementation, the pre-shared area is
> the virtqueue itself so this approach has been called "fat virtqueue".
> But it requires guest modifications and it probably results in
> additional memory copies.
>

I got it. Although we would need to map that pre-shared area anyway (I
presume it could be done at once during initialization), I think it much
better than
map arbitrary pages at runtime. If there is a way for Xen to know the
pre-shared area location in advance it will be able to allow mapping this
region only and deny other attempts.




>
> I am not sure if the approach you mentioned could be implemented
> completely without frontend changes. It looks like Xen would have to
> learn how to inspect virtqueues in order to verify implicit grants
> without frontend changes.


I looked through the virtio-iommu specification and corresponding Linux
driver but I am sure I don't see all the challenges and pitfalls. Having a
limited knowledge of IOMMU infrastructure in Linux, below is just my guess,
which might be wrong.

1. I think, if we want to avoid frontend changes the backend in Xen would
need to fully conform to the specification, I am afraid that besides just
inspecting virtqueues, the backend needs to properly and completely emulate
the virtio device, handle shadow page tables, etc. Otherwise we might break
the guest. I expect a huge amount of work to implement this properly.

2. Also, if I got the things correctly, it looks like when enabling
virtio-iommu, all addresses passed in requests to the virtio devices behind
the virtio-iommu will be in guest virtual address space (IOVA). So we would
need to find a way for userspace (if the backend is IOREQ server) to
translate them to guest physical addresses (IPA) via these shadow page
tables in the backend in front of mapping them via foreign memory map
calls. So I expect Xen, toolstack and Linux privcmd driver changes and
additional complexity taking into account how the data structures could be
accessed (data structures being continuously in IOVA, could be
discontinuous in IPA, indirect table descriptors, etc).
I am wondering, would it be possible to have identity IOMMU mapping (IOVA
=3D=3D GPA) at the guest side but without bypassing an IOMMU, as we need th=
e
virtio-iommu frontend to send map/unmap requests, can we control this
behaviour somehow?
I think this would simplify things.

3. Also, we would probably want to have a single virtio-iommu device
instance per guest, so all virtio devices which belong to this guest will
share the IOMMU mapping for the optimization purposes. For this to work all
virtio devices inside a guest should be attached to the same IOMMU domain.
Probably, we could control that, but I am not 100% sure.





> With or without guest modifications, I am not
> aware of anyone doing research and development on this approach.





--=20
Regards,

Oleksandr Tyshchenko

--0000000000004401fb05cd6263d8
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote">=
<div dir=3D"ltr" class=3D"gmail_attr">On Sat, Oct 2, 2021 at 2:58 AM Stefan=
o Stabellini &lt;<a href=3D"mailto:sstabellini@kernel.org">sstabellini@kern=
el.org</a>&gt; wrote:<br></div><div dir=3D"ltr" class=3D"gmail_attr"><br></=
div><div class=3D"gmail_attr">Hi Stefano, all</div><div class=3D"gmail_attr=
"><br></div><div class=3D"gmail_attr">[Sorry for the possible format issues=
]</div><div class=3D"gmail_attr">[I have CCed Julien]</div><div dir=3D"ltr"=
 class=3D"gmail_attr"><br></div><div dir=3D"ltr" class=3D"gmail_attr"><br><=
/div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;bo=
rder-left:1px solid rgb(204,204,204);padding-left:1ex">On Tue, 28 Sep 2021,=
 Oleksandr Tyshchenko wrote:<br>
&gt; On Tue, Sep 28, 2021 at 9:26 AM Stefano Stabellini &lt;<a href=3D"mail=
to:sstabellini@kernel.org" target=3D"_blank">sstabellini@kernel.org</a>&gt;=
 wrote:<br>
&gt; <br>
&gt; Hi Stefano, all<br>
&gt; <br>
&gt; [Sorry for the possible format issues]<br>
&gt; <br>
&gt; <br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0On Mon, 27 Sep 2021, Christopher Clark wrote=
:<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt; On Mon, Sep 27, 2021 at 3:06 AM Alex Be=
nn=C3=A9e via Stratos-dev &lt;<a href=3D"mailto:stratos-dev@op-lists.linaro=
.org" target=3D"_blank">stratos-dev@op-lists.linaro.org</a>&gt; wrote:<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0Marek Marczyk=
owski-G=C3=B3recki &lt;<a href=3D"mailto:marmarek@invisiblethingslab.com" t=
arget=3D"_blank">marmarek@invisiblethingslab.com</a>&gt; writes:<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt; [[PGP Si=
gned Part:Undecided]]<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt; On Fri, =
Sep 24, 2021 at 05:02:46PM +0100, Alex Benn=C3=A9e wrote:<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;&gt; Hi,<=
br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt; Hi,<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;&gt; 2.1 =
Stable ABI for foreignmemory mapping to non-dom0 ([STR-57])<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;&gt; =E2=
=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=
=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=
=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=
=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=
=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=
=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=
=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=
=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;&gt;=C2=
=A0 =C2=A0Currently the foreign memory mapping support only works for dom0 =
due<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;&gt;=C2=
=A0 =C2=A0to reference counting issues. If we are to support backends runni=
ng in<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;&gt;=C2=
=A0 =C2=A0their own domains this will need to get fixed.<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;&gt;=C2=
=A0 =C2=A0Estimate: 8w<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;&gt; [STR=
-57] &lt;<a href=3D"https://linaro.atlassian.net/browse/STR-57" rel=3D"nore=
ferrer" target=3D"_blank">https://linaro.atlassian.net/browse/STR-57</a>&gt=
;<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt; I&#39;m =
pretty sure it was discussed before, but I can&#39;t find relevant<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt; (part of=
) thread right now: does your model assumes the backend (running<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt; outside =
of dom0) will gain ability to map (or access in other way)<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt; _arbitra=
ry_ memory page of a frontend domain? Or worse: any domain?<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0The aim is fo=
r some DomU&#39;s to host backends for other DomU&#39;s instead of<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0all backends =
being in Dom0. Those backend DomU&#39;s would have to be<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0considered tr=
usted because as you say the default memory model of VirtIO<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0is to have fu=
ll access to the frontend domains memory map.<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt; I share Marek&#39;s concern. I believe =
that there are Xen-based systems that will want to run guests using VirtIO =
devices without<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0extending<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt; this level of trust to=C2=A0the backend=
 domains.<br>
&gt; <br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;From a safety perspective, it would be c=
hallenging to deploy a system<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0with privileged backends. From a safety pers=
pective, it would be a lot<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0easier if the backend were unprivileged.<br>
&gt; <br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0This is one of those times where safety and =
security requirements are<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0actually aligned.<br>
&gt; <br>
&gt; <br>
&gt; Well, the foreign memory mapping has one advantage in the context of V=
irtio use-case<br>
&gt; which is that Virtio infrastructure in Guest doesn&#39;t require any m=
odifications to run on top Xen.<br>
&gt; The only issue with foreign memory here is that Guest memory actually =
mapped without its agreement<br>
&gt; which doesn&#39;t perfectly fit into=C2=A0the security model. (althoug=
h there is one more issue with XSA-300,<br>
&gt; but I think it will go away sooner or later, at least there are some a=
ttempts to eliminate it).<br>
&gt; While the ability to map any part of Guest memory is not an issue for =
the backend running in Dom0<br>
&gt; (which we usually trust), this will certainly violate Xen security mod=
el if we want to run it in other<br>
&gt; domain, so I completely agree with the existing concern.<br>
<br>
Yep, that&#39;s what I was referring to.<br>
<br>
<br>
&gt; It was discussed before [1], but I couldn&#39;t find any decisions reg=
arding that. As I understand,<br>
&gt; the one of the possible ideas is to have some entity in Xen (PV IOMMU/=
virtio-iommu/whatever)<br>
&gt; that works in protection mode, so it denies all foreign mapping reques=
ts from the backend running in DomU<br>
&gt; by default and only allows requests with mapping which were *implicitl=
y* granted by the Guest before.<br>
&gt; For example, Xen could be informed which MMIOs hold the queue PFN and =
notify registers<br>
&gt; (as it traps the accesses to these registers anyway) and could theoret=
ically parse the frontend request<br>
&gt; and retrieve descriptors to make a decision which GFNs are actually *a=
llowed*.<br>
&gt; <br>
&gt; I can&#39;t say for sure (sorry not familiar enough with the topic), b=
ut implementing the virtio-iommu device<br>
&gt; in Xen we could probably avoid Guest modifications at all. Of course, =
for this to work<br>
&gt; the Virtio infrastructure in Guest should use DMA API as mentioned in =
[1].<br>
&gt; <br>
&gt; Would the =E2=80=9Crestricted foreign mapping=E2=80=9D solution retain=
 the Xen security model and be accepted<br>
&gt; by the Xen community? I wonder, has someone already looked in this dir=
ection, are there any<br>
&gt; pitfalls here or is this even feasible?<br>
&gt; <br>
&gt; [1] <a href=3D"https://lore.kernel.org/xen-devel/464e91ec-2b53-2338-43=
c7-a018087fc7f6@arm.com/" rel=3D"noreferrer" target=3D"_blank">https://lore=
.kernel.org/xen-devel/464e91ec-2b53-2338-43c7-a018087fc7f6@arm.com/</a><br>
<br>
The discussion that went further is actually one based on the idea that<br>
there is a pre-shared memory area and the frontend always passes<br>
addresses from it. For ease of implementation, the pre-shared area is<br>
the virtqueue itself so this approach has been called &quot;fat virtqueue&q=
uot;.<br>
But it requires guest modifications and it probably results in<br>
additional memory copies.<br></blockquote><div>=C2=A0</div><div>I got it. A=
lthough we would need to map that=C2=A0pre-shared area anyway (I presume it=
 could be done at once during initialization), I think it much better than<=
/div><div>map arbitrary pages at runtime. If there is a way for Xen to know=
 the pre-shared area location in advance it will be able to allow mapping t=
his region only and deny other attempts.</div><div><br></div><div><br></div=
><div>=C2=A0</div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px=
 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
I am not sure if the approach you mentioned could be implemented<br>
completely without frontend changes. It looks like Xen would have to<br>
learn how to inspect virtqueues in order to verify implicit grants<br>
without frontend changes.</blockquote><div>=C2=A0</div><div>I looked throug=
h the virtio-iommu specification and corresponding Linux driver but I am su=
re I don&#39;t see all the challenges=C2=A0and pitfalls. Having a limited k=
nowledge of IOMMU infrastructure=C2=A0in Linux, below is just my guess, whi=
ch might be wrong.</div><div><br></div><div>1. I think, if we want to avoid=
=C2=A0frontend changes the backend in Xen would need to fully conform to th=
e specification, I am afraid that besides just inspecting virtqueues, the b=
ackend needs to properly and completely emulate the virtio device, handle s=
hadow page tables, etc. Otherwise we might=C2=A0break the guest. I expect a=
 huge amount of work to=C2=A0implement this properly.</div><div><br></div><=
div>2. Also, if I got the things correctly, it looks like when enabling vir=
tio-iommu, all addresses passed in=C2=A0requests to the virtio devices behi=
nd the virtio-iommu will be in guest virtual address space (IOVA). So we wo=
uld need to find a way for userspace (if the backend is IOREQ server) to tr=
anslate them to guest physical addresses (IPA) via these shadow page tables=
 in the backend in front of mapping them via foreign memory map calls. So I=
 expect Xen, toolstack and Linux privcmd driver changes and additional comp=
lexity taking into account how the data structures could be accessed (data =
structures=C2=A0being continuously in IOVA, could be discontinuous in IPA, =
indirect table descriptors, etc).=C2=A0</div><div>I am wondering, would it =
be possible to have identity IOMMU mapping (IOVA =3D=3D GPA) at the guest s=
ide but without bypassing an IOMMU, as we need the virtio-iommu frontend to=
 send map/unmap requests, can we control this behaviour somehow?</div><div>=
I think this would simplify things.</div><div><br></div><div>3. Also, we wo=
uld probably want to have a single virtio-iommu device instance per guest, =
so all virtio devices which belong to this guest will share the IOMMU mappi=
ng for the optimization purposes. For this to work all virtio devices insid=
e a guest should be attached to the same IOMMU domain. Probably, we could=
=C2=A0control=C2=A0that, but I am not 100% sure.=C2=A0=C2=A0</div><div><br>=
</div><div><br></div><div><br></div><div>=C2=A0</div><blockquote class=3D"g=
mail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204=
,204,204);padding-left:1ex">With or without guest modifications, I am not<b=
r>
aware of anyone doing research and development on this approach.</blockquot=
e><div><br></div><div>=C2=A0</div></div><br clear=3D"all"><div><br></div>--=
 <br><div dir=3D"ltr" class=3D"gmail_signature"><div dir=3D"ltr"><div><div =
dir=3D"ltr"><div><div dir=3D"ltr"><span style=3D"background-color:rgb(255,2=
55,255)"><font size=3D"2"><span style=3D"color:rgb(51,51,51);font-family:Ar=
ial,sans-serif">Regards,</span></font></span></div><div dir=3D"ltr"><br></d=
iv><div dir=3D"ltr"><div><span style=3D"background-color:rgb(255,255,255)">=
<font size=3D"2">Oleksandr Tyshchenko</font></span></div></div></div></div>=
</div></div></div></div>

--0000000000004401fb05cd6263d8--


From xen-devel-bounces@lists.xenproject.org Sun Oct 03 04:47:47 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 03 Oct 2021 04:47:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.201095.355515 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mWtPK-0003tz-5U; Sun, 03 Oct 2021 04:47:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 201095.355515; Sun, 03 Oct 2021 04:47:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mWtPK-0003ts-1O; Sun, 03 Oct 2021 04:47:26 +0000
Received: by outflank-mailman (input) for mailman id 201095;
 Sun, 03 Oct 2021 04:47:24 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=xgPy=OX=invisiblethingslab.com=marmarek@srs-us1.protection.inumbo.net>)
 id 1mWtPI-0003tm-I6
 for xen-devel@lists.xenproject.org; Sun, 03 Oct 2021 04:47:24 +0000
Received: from wout1-smtp.messagingengine.com (unknown [64.147.123.24])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 2e24ca65-8992-4f6c-98fc-c94ab568b96a;
 Sun, 03 Oct 2021 04:47:23 +0000 (UTC)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.west.internal (Postfix) with ESMTP id CB78732003C0;
 Sun,  3 Oct 2021 00:47:21 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute1.internal (MEProxy); Sun, 03 Oct 2021 00:47:22 -0400
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun,
 3 Oct 2021 00:47:20 -0400 (EDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2e24ca65-8992-4f6c-98fc-c94ab568b96a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:content-type:date:from:message-id
	:mime-version:subject:to:x-me-proxy:x-me-proxy:x-me-sender
	:x-me-sender:x-sasl-enc; s=fm1; bh=1y8M4P/hiJ1PP8+Pb/DaVZFVNJQSS
	bnivk0mqqAPAC4=; b=FBy2L5gsgRLJHoOnf+zW+zHoiS+tEBQ7pm2Jyw2hw+sFj
	ifzy77IxYGZL5QnBoGUGNoXecla/Pp6v5zYIJ33zl6LTjMBqIl4SS6Tji75B5MG2
	FFsc99TOO4m2LUIRFULECpHDWfH2bo89OxYABl6rvmnFm5Mqap3uqNL660LgK2Xm
	VO0RFUoDcCwEbOCz7SJgu1IZ3gcuO6cf/SItxEmsIUMU0zR/Vp/4ftwQbuhzrQAu
	yIrgt+PfqYPckEmFwzMXjSdvHwHaa3BBrHbiVrXpWJjvIrmNLczOvRNwE9Punazj
	p2hJANoKJZ/yPrs3IaHXFNOcuJ+UdKdV8X86cpnxw==
X-ME-Sender: <xms:2TVZYXGtbvXHSLCsnKxyXudjUtaerhZPhsotFJOSSMjtCDxWVky30Q>
    <xme:2TVZYUV7FRoBBeO1LxljpnyyZ03vsJTufUCG6bXmGjbHrujOCI4-3dJsv-BU-yFmF
    Y7BmgPGmlD1SA>
X-ME-Received: <xmr:2TVZYZLS4diMq691WY8CCPF6avkwiZk17Oy3KtW2rS3uXtXXBOGvP2ddeIfOe2X5tmBReqDpdkrV8EgTSqfnyNH5FIHzQ1Bt>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrudekledgkeeiucetufdoteggodetrfdotf
    fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
    uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
    cujfgurhepfffhvffukfggtggusehgtderredttdejnecuhfhrohhmpeforghrvghkucfo
    rghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesihhnvhhish
    hisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpedtudfgtedu
    veduieevvefgteeujeelgffggffhhffhhedtffeffefgudeugeefhfenucevlhhushhtvg
    hrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrghrmhgrrhgvkhesihhn
    vhhishhisghlvghthhhinhhgshhlrggsrdgtohhm
X-ME-Proxy: <xmx:2TVZYVFA0Tqb_5ijL4J8LdqtwW9BeNh0bVTtO2J9IN2TADctm7LOIA>
    <xmx:2TVZYdXs0M_kXmJ-7aEGWZ3iEiXm1RWXCu7jM8bYHVRe3dONj7d-eg>
    <xmx:2TVZYQPR_rt3dGRdFwX9AkLwPifvvV5LoLt8woD_zsRbGg8sEDxGgw>
    <xmx:2TVZYefvS3y-rP56-ojneMlnc3Q0yzeU9lLi9camo2p-ij523_vTLA>
Date: Sun, 3 Oct 2021 06:47:17 +0200
From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
To: xen-devel <xen-devel@lists.xenproject.org>
Cc: Juergen Gross <jgross@suse.com>, Jan Beulich <jbeulich@suse.com>
Subject: xen-balloon thread using 100% of CPU, regression in 5.4.150
Message-ID: <YVk11h2l/u4GJNv0@mail-itl>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="oLSao2sPpm0inQ0V"
Content-Disposition: inline


--oLSao2sPpm0inQ0V
Content-Type: text/plain; protected-headers=v1; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Date: Sun, 3 Oct 2021 06:47:17 +0200
From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
To: xen-devel <xen-devel@lists.xenproject.org>
Cc: Juergen Gross <jgross@suse.com>, Jan Beulich <jbeulich@suse.com>
Subject: xen-balloon thread using 100% of CPU, regression in 5.4.150

Hi,

After updating a PVH domU to 5.4.150, I see xen-balloon thread using
100% CPU (one thread).
This is a domain started with memory=3Dmaxmem=3D716800KiB (via libvirt). Th=
en,
inside, I see:

# cat /sys/devices/system/xen_memory/xen_memory0/target_kb
716924
# cat /sys/devices/system/xen_memory/xen_memory0/info/current_kb
716400

Doing `cat info/current_kb > target_kb` "fixes" the issue. But still,
something is wrong - on earlier kernel (5.4.143 to be precise), it
wasn't spinning, with exactly the same values reported in sysfs. It
shouldn't run in circles if it can't get that much memory it wants. I
strongly suspect "xen/balloon: use a kernel thread instead a workqueue"
or related commit being responsible, but I haven't verified it.

This specific test is from Xen 4.8.5 (+quite a lot of patches), but I've
got report of the same issue on 4.14.3 too. Anyway, I don't think Xen
version matters here much.

I have _not_ managed to reproduce the issue on 5.10.70, nor 5.14.9. In
both cases, just after starting the domain, I see
current_kb=3Dtarget_kb=3D716412. And writing 716924 to target_kb manually
does not cause xen-balloon thread to spin.

--=20
Best Regards,
Marek Marczykowski-G=C3=B3recki
Invisible Things Lab

--oLSao2sPpm0inQ0V
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmFZNdUACgkQ24/THMrX
1yzJkQf/fy7zmFrnXFbpxTfQN2a7fMxJKm2wHAYJpd9I95rXRWM1ryt7TUE8GjmN
PxUkltEitH8tM6VzM7TqkpcQqIkK9u+r7ahP2WsMiVR4tUz75RZTGAO19p66ojle
2afTAqZKIxrMimfolEOhWEqvigCOxHLES5fKsfvMO/g0sr/mIOygaH0B3rGZO8kg
K253XN6QgKf6hp+YCH1JxSaS7tikEbPrKCaMnShsaFk7Q/q0Duv7VDD2nvzus5ql
N06cnoBb14ikkHz8S+swTb+MLTggSlQt/NWmRZZcC6NulnXRUwaN3XI9+Pl2YdYg
Bm4h3NnbMgVAOfMlLhhOgkjvKp0CYA==
=nn/A
-----END PGP SIGNATURE-----

--oLSao2sPpm0inQ0V--


From xen-devel-bounces@lists.xenproject.org Sun Oct 03 10:11:10 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 03 Oct 2021 10:11:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.201109.355526 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mWyS4-0007sh-5G; Sun, 03 Oct 2021 10:10:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 201109.355526; Sun, 03 Oct 2021 10:10:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mWyS4-0007sa-1O; Sun, 03 Oct 2021 10:10:36 +0000
Received: by outflank-mailman (input) for mailman id 201109;
 Sun, 03 Oct 2021 10:10:35 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=DbZ3=OX=riomar.se=rio@srs-us1.protection.inumbo.net>)
 id 1mWyS3-0007sU-AP
 for xen-devel@lists.xenproject.org; Sun, 03 Oct 2021 10:10:35 +0000
Received: from mail2.riocities.com (unknown [185.20.14.89])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id bac5c4b1-313c-479d-ae8b-fd57cbef9355;
 Sun, 03 Oct 2021 10:10:34 +0000 (UTC)
Received: from mail.riomar.se (81-230-197-241-no510.tbcn.telia.com
 [81.230.197.241])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mail2.riocities.com (Postfix) with ESMTPSA id 204C34018A
 for <xen-devel@lists.xenproject.org>; Sun,  3 Oct 2021 11:52:15 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: bac5c4b1-313c-479d-ae8b-fd57cbef9355
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=riomar.se; s=mail;
	t=1633254735; bh=p3Dx0Ok4EjvyMD83V6zwqjWJQHNk1P8tDcD2oZvEp4s=;
	h=Date:From:To:Subject:From;
	b=wnJVUkN+5fPRp5qm9quSWOdvy97zIdXva2zqQrtEGG7PuqxQM2jd7jodMzqGtsjpf
	 sXO/mWYMOoOD4WweMNyZgOixFrMSZXnJLwdQjT0DEDW86vw/SGyBGN/uYegsW9QDNQ
	 7ubFkq7+FWuL/IxnBp4DD3YH/KaAxWaNeLXhtCc0=
Date: Sun, 3 Oct 2021 11:52:13 +0200
From: Henrik Riomar <rio@riomar.se>
To: xen-devel@lists.xenproject.org
Subject: xen-balloon and 5.10.70
Message-Id: <20211003115213.d7d9d4c1a1bc371cd4b7dc76@riomar.se>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

Hi,

Running 5.10.70 on a dom0 shows 100% load on one core for the
xen-balloon kernel thread (was a workqueue before 5.10.70).

I have upgraded two dom0's to 5.10.70 and both of them shows this issue.

Xen version is 4.15.1.

To trigger the problem:
 dom_mem=3000M,max:3000M

Does not trigger the problem:
 dom_mem=3000M

(the other system with the issue has "dom0_mem=4096M,max:4096M")

/etc/xl/xl.conf:
 #autoballon="auto" 
 or
 autoballon="off"
 or 
 autoballon="on"

does not matter, in trigging the problem (i.e. autoballon="off", still
gets [xen-ballon] to hog down one core).

Can not see the problem before starting the first domU, and shutting
down all domUs stops xen-balloon to hog the core.

Workaround in a running system is to lower
 /sys/devices/system/xen_memory/xen_memory0/target_kb.

With max:3000M this was 3072000 (kb), and just lowering it to 3069952
(i.e. by 2 meg) "solved" the issue, and stopped the fan in my laptop :-)

/ Henrik


From xen-devel-bounces@lists.xenproject.org Sun Oct 03 23:29:35 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 03 Oct 2021 23:29:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.201119.355537 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXAue-00008a-9M; Sun, 03 Oct 2021 23:28:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 201119.355537; Sun, 03 Oct 2021 23:28:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXAue-00008T-5s; Sun, 03 Oct 2021 23:28:56 +0000
Received: by outflank-mailman (input) for mailman id 201119;
 Sun, 03 Oct 2021 23:28:54 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Jt1B=OX=arm.com=Wei.Chen@srs-us1.protection.inumbo.net>)
 id 1mXAuc-00008M-MN
 for xen-devel@lists.xenproject.org; Sun, 03 Oct 2021 23:28:54 +0000
Received: from EUR01-HE1-obe.outbound.protection.outlook.com (unknown
 [40.107.13.80]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id aa2bbaf2-24a1-11ec-be8f-12813bfff9fa;
 Sun, 03 Oct 2021 23:28:51 +0000 (UTC)
Received: from AM6PR01CA0037.eurprd01.prod.exchangelabs.com
 (2603:10a6:20b:e0::14) by AM6PR08MB5237.eurprd08.prod.outlook.com
 (2603:10a6:20b:e9::11) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.22; Sun, 3 Oct
 2021 23:28:49 +0000
Received: from AM5EUR03FT060.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:e0:cafe::65) by AM6PR01CA0037.outlook.office365.com
 (2603:10a6:20b:e0::14) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.19 via Frontend
 Transport; Sun, 3 Oct 2021 23:28:49 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM5EUR03FT060.mail.protection.outlook.com (10.152.16.160) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4566.14 via Frontend Transport; Sun, 3 Oct 2021 23:28:48 +0000
Received: ("Tessian outbound 78bf72cc015a:v103");
 Sun, 03 Oct 2021 23:28:45 +0000
Received: from 8ba20bcd8b62.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 A1228FB6-735E-4D45-B266-965D72DB1E54.1; 
 Sun, 03 Oct 2021 23:28:34 +0000
Received: from EUR03-AM5-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 8ba20bcd8b62.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Sun, 03 Oct 2021 23:28:34 +0000
Received: from DB9PR08MB6857.eurprd08.prod.outlook.com (2603:10a6:10:2a2::7)
 by DB7PR08MB3530.eurprd08.prod.outlook.com (2603:10a6:10:4a::30) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.18; Sun, 3 Oct
 2021 23:28:26 +0000
Received: from DB9PR08MB6857.eurprd08.prod.outlook.com
 ([fe80::2c28:50cf:49fd:da32]) by DB9PR08MB6857.eurprd08.prod.outlook.com
 ([fe80::2c28:50cf:49fd:da32%9]) with mapi id 15.20.4566.022; Sun, 3 Oct 2021
 23:28:25 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: aa2bbaf2-24a1-11ec-be8f-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=A+sl+QmdON37r2Y1vVseZ0fz/o2b+UWWKmtDOBu8j4c=;
 b=mOTeNOIeyeFVnMPrjbeQmhwXa2h//0hBmeti5CLbeZeGdXHYcWgHCcy92k1g2B5s96b1NF9isiQrcEdYq+YaUPfmJIMkQo2N7K66KHUNlF3nZc4pRM4IxvXBWqzoPZXF8qvU71kPA9aTl1AXyOlO0u8VXWeRRpajRGNuDY5GQ8Q=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Ag/jpizJH81xOpM7UJRf4qGVIC87NX7MHOEA1kXfGd8uG6I/y6W8qhbKPqj4dRoBWEP2+W209VmLCRhqEDv7+LDedcpBassIIIDiIjApV5SmOjO3cFW9d2YJPjPbIj06Gp3dUkmtQsItFkyc7z7kwkDuGmI6fYWnR8KtumRjmFaz41lc4H1y+hrZmGXgNUj8Vo1ds5QguOzhq/EMH/noxn3lF0ApSfLeRGor30D0HIQTcyUh2X+t41vx/XktmrNPiyCiyFB8srLhimN23SQ25J9eOJMltmvXsgQ0NjXWNQ57qjRAgGu/+fuwxJV+OTvAgOinRCwbn814cZttCoH0iw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=A+sl+QmdON37r2Y1vVseZ0fz/o2b+UWWKmtDOBu8j4c=;
 b=eRDRx/5C9l+lZagKMlmmHaS68pyaSZjatIe5XavWpfV+3lXELOBX7sS13/jUycaEJretAO/XgCC0+zufJ1LJP0jCBN+iotd8twDgF/1/iqOnoOJW9wgefGCfqeJ/g4rRu/a5SB5/gosVTPLuhuq42yKnXoz9evSqG6xdFxpOpXbUO4NhOSYXOOu+kbJ0WQBTLq4PrUF0TP2oQqAyqs/hloAQwzfVt/6i+bE0d7aQIBoq+o3bo3YKzNNA9eVue+KJj69Ur8Sy9Agl+nQFIxfOlfWMCoACSRv9/aDHFWoKx/eQGqk4HlflV1pSqvKHDhu5RKDYsglv7qA3mEoZIkowzQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=A+sl+QmdON37r2Y1vVseZ0fz/o2b+UWWKmtDOBu8j4c=;
 b=mOTeNOIeyeFVnMPrjbeQmhwXa2h//0hBmeti5CLbeZeGdXHYcWgHCcy92k1g2B5s96b1NF9isiQrcEdYq+YaUPfmJIMkQo2N7K66KHUNlF3nZc4pRM4IxvXBWqzoPZXF8qvU71kPA9aTl1AXyOlO0u8VXWeRRpajRGNuDY5GQ8Q=
From: Wei Chen <Wei.Chen@arm.com>
To: Jan Beulich <jbeulich@suse.com>, Stefano Stabellini
	<sstabellini@kernel.org>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	"julien@xen.org" <julien@xen.org>, Bertrand Marquis
	<Bertrand.Marquis@arm.com>
Subject: RE: [PATCH 20/37] xen: introduce CONFIG_EFI to stub API for non-EFI
 architecture
Thread-Topic: [PATCH 20/37] xen: introduce CONFIG_EFI to stub API for non-EFI
 architecture
Thread-Index:
 AQHXsHMtR+l18+MmpE6rl/RjSXTBgquyYmkAgAA2xQCAADnbAIAAKWhQgAAGUwCAAxtPwIABk+MwgAD1aACAACGFAIAAIfsAgAAyrICACN3+0A==
Date: Sun, 3 Oct 2021 23:28:24 +0000
Message-ID:
 <DB9PR08MB68576ADE0EC584A49C63E5FE9EAD9@DB9PR08MB6857.eurprd08.prod.outlook.com>
References: <20210923120236.3692135-1-wei.chen@arm.com>
 <20210923120236.3692135-21-wei.chen@arm.com>
 <alpine.DEB.2.21.2109231811420.17979@sstabellini-ThinkPad-T480s>
 <PAXPR08MB68640027443F267495804A529EA49@PAXPR08MB6864.eurprd08.prod.outlook.com>
 <b4433faf-bb70-d083-126c-0224da3d9a82@suse.com>
 <DB9PR08MB685742B691E39FD3161BFE289EA49@DB9PR08MB6857.eurprd08.prod.outlook.com>
 <a295cc34-9cc0-468b-c85a-2e5d1238d9a3@suse.com>
 <DB9PR08MB6857EE6294A1062EE0FAF0289EA69@DB9PR08MB6857.eurprd08.prod.outlook.com>
 <DB9PR08MB6857AB9DBB66A4E02140987B9EA79@DB9PR08MB6857.eurprd08.prod.outlook.com>
 <alpine.DEB.2.21.2109271420560.5022@sstabellini-ThinkPad-T480s>
 <DB9PR08MB6857E57847E38C400F6571EA9EA89@DB9PR08MB6857.eurprd08.prod.outlook.com>
 <alpine.DEB.2.21.2109272159590.5022@sstabellini-ThinkPad-T480s>
 <f872f421-dddf-7fde-34ce-210ddc55a87f@suse.com>
In-Reply-To: <f872f421-dddf-7fde-34ce-210ddc55a87f@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: 16A9AFD859E6A04383507FF1235A9FEB.0
x-checkrecipientchecked: true
Authentication-Results-Original: suse.com; dkim=none (message not signed)
 header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: 57f1ac77-14cd-4752-fa9a-08d986c58d0e
x-ms-traffictypediagnostic: DB7PR08MB3530:|AM6PR08MB5237:
x-ms-exchange-transport-forked: True
X-Microsoft-Antispam-PRVS:
	<AM6PR08MB5237D6FABE0166E0826FD3049EAD9@AM6PR08MB5237.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:10000;OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 uMxVi7D8kt4zC9EBN+/7bGqNRvTF8BNg/5GhiI+MEyCsXZGDvWN0YxyYPtQ5ZMbDwqG/egFYNxvEwWvZGkgSpgSXOQPZPVI6EBNQq2YC7rYJEzAAY6OrfjnDPb1tQXQWIyL1RfAqVzMMKPI2ti47iomeRHcAADgJIVwzoUO3YIKtvQayzymxWgz2JbmHOi0clGLR4ugsb8lr7e33o8GET489hVPcbhw1xHbIUh75YRuVCV/ceIhbND/nDzzDOayGJFE/iy3iYnnHhiNEzlN3SpDO5BW1gssWL7rnqEfYuAPNdLdsy+0ew45o5uamYGzYz0LQih9uCZfMAhsXUh0cAWT34vu6TerzBMWuas9zzvHy349VCDbUl7VzdAouYO3htQxh8ycT4F7bA4TcrJqHEK229wXXfb3uSe8KtW1GuMQhW7dp1VsQIiFPKl5KBllpxPMC4YVNsAkCVAwBHBrz5aWIqncvMPiKKGZPekqdIxvx5ualdRi+P8mAhqVMHyUKV+T8SdMD41ZKHXO2tyss43QVlSwG80f5paJXX3qlu4CiCJ9jLqWD8257+w4FxEXUmrRvDMPVAdvk45atwnLNESudpcCwjtLvvrejUnuLzhG5Cxq0wShx5rpD8sLDHSvdDa1/FW6EmoSwT1BrVIsM7CLdMp4kOR1BySb/VZrowMWHCPze/clPIMFmcIkDWbwP2om3JeB1ZgosT6QYOp+dlrE+aar2ZzaajF5i19wGoo7DMhKAFbm9weVLy+lcTaojMbpZMxWZTiwgFFjnGuCrKsD1L0LT+HeQDlHs/Pp42Yo=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB9PR08MB6857.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(8676002)(55016002)(38070700005)(122000001)(8936002)(966005)(5660300002)(71200400001)(508600001)(52536014)(4326008)(9686003)(83380400001)(26005)(316002)(7696005)(38100700002)(66446008)(64756008)(66556008)(66476007)(54906003)(66946007)(33656002)(2906002)(186003)(76116006)(53546011)(6506007)(86362001)(110136005);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3530
Original-Authentication-Results: suse.com; dkim=none (message not signed)
 header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM5EUR03FT060.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	8f6a3ed3-2a43-4b16-fc27-08d986c57f6c
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	cghE9VhTqFqELf8hd+jtAM8/ui2WFpRPnn4nMMCJdWZPxZeTnp4W5jeF8Jucp+qZAxKxxWlE4Vc4xb/Ny/OzfO2sM1XHid497XZakKNgM50slAKQED6lbu/A3Tvvn6Z1yJg3TQvQYmHbyRAG5F5RaQt9tOVtdQGrSIiZ6SASYUlKgyaGxojh8lwoPYyNsiLAkEWMGWhzAySxwHBBBk5L8Q0nAupRJd2f9Hu95qGQjsXvNs9rNNZafHe35Kme+jK/I0N5qQJ4y+ylnrbM3QI256wN8yf0w4AGIfccnl1FRT9KXbFLUIe7CIpwIkA+bUkWxWm6xjGsGqmt8cVRGy0CpDB7Tz7BSb84PYcbET848loF52Jl+1s/e/6Mp/e99bQ+5c8nB/p8vOEg5rJ4QPnuUxeaZHEh8noJIRP0/TiVOEAO49FWTsI0th2w/4aQaY1c4+kU1u0udShA/Z6ysDGnO2V2fpYOla9W6FnEvxe4OeyZRmcN3uruOzB0ysmo+rlmuMy9Ge9+CUt4TqsYsD4lB5/sVVMLtN1ug9JsQhipD9MMMnGvqRAnMrOcxfmPSeDmnVBPCYTGJ2AzjyF6i+qOaime4v5ix+3kM9XW4Vls9okzdEm4YIlfTA/MidK+356o3PDbp4TRhWQex2XLiSelA3fZfVZDXQv6yF64AwltXOeo2x57B9c5QvZEQrq8UhYgaxpWeLsI6dbfQM8Faf9p1HAUY1oQYG+rCyfuURIXblt+NLGLVHzSNtDQVHrIAr/oX2KkHXFwZcgYOAjhO+7G1ibukZE7taZn7Kp/s7/w2zk=
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(52536014)(55016002)(4326008)(54906003)(8936002)(9686003)(33656002)(70586007)(81166007)(356005)(186003)(26005)(508600001)(2906002)(110136005)(316002)(8676002)(82310400003)(6506007)(966005)(47076005)(336012)(70206006)(7696005)(53546011)(83380400001)(86362001)(36860700001)(5660300002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Oct 2021 23:28:48.2194
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 57f1ac77-14cd-4752-fa9a-08d986c58d0e
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM5EUR03FT060.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB5237

DQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogSmFuIEJldWxpY2ggPGpi
ZXVsaWNoQHN1c2UuY29tPg0KPiBTZW50OiAyMDIx5bm0OeaciDI45pelIDE2OjAzDQo+IFRvOiBT
dGVmYW5vIFN0YWJlbGxpbmkgPHNzdGFiZWxsaW5pQGtlcm5lbC5vcmc+OyBXZWkgQ2hlbg0KPiA8
V2VpLkNoZW5AYXJtLmNvbT4NCj4gQ2M6IHhlbi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZzsg
anVsaWVuQHhlbi5vcmc7IEJlcnRyYW5kIE1hcnF1aXMNCj4gPEJlcnRyYW5kLk1hcnF1aXNAYXJt
LmNvbT4NCj4gU3ViamVjdDogUmU6IFtQQVRDSCAyMC8zN10geGVuOiBpbnRyb2R1Y2UgQ09ORklH
X0VGSSB0byBzdHViIEFQSSBmb3Igbm9uLQ0KPiBFRkkgYXJjaGl0ZWN0dXJlDQo+IA0KPiBPbiAy
OC4wOS4yMDIxIDA3OjAxLCBTdGVmYW5vIFN0YWJlbGxpbmkgd3JvdGU6DQo+ID4gT24gVHVlLCAy
OCBTZXAgMjAyMSwgV2VpIENoZW4gd3JvdGU6DQo+ID4+PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2Ut
LS0tLQ0KPiA+Pj4gRnJvbTogU3RlZmFubyBTdGFiZWxsaW5pIDxzc3RhYmVsbGluaUBrZXJuZWwu
b3JnPg0KPiA+Pj4gU2VudDogMjAyMeW5tDnmnIgyOOaXpSA5OjAwDQo+ID4+PiBUbzogV2VpIENo
ZW4gPFdlaS5DaGVuQGFybS5jb20+DQo+ID4+PiBDYzogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1
c2UuY29tPjsgeGVuLWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnOw0KPiA+Pj4ganVsaWVuQHhl
bi5vcmc7IEJlcnRyYW5kIE1hcnF1aXMgPEJlcnRyYW5kLk1hcnF1aXNAYXJtLmNvbT47IFN0ZWZh
bm8NCj4gPj4+IFN0YWJlbGxpbmkgPHNzdGFiZWxsaW5pQGtlcm5lbC5vcmc+DQo+ID4+PiBTdWJq
ZWN0OiBSRTogW1BBVENIIDIwLzM3XSB4ZW46IGludHJvZHVjZSBDT05GSUdfRUZJIHRvIHN0dWIg
QVBJIGZvcg0KPiBub24tDQo+ID4+PiBFRkkgYXJjaGl0ZWN0dXJlDQo+ID4+Pg0KPiA+Pj4gT24g
TW9uLCAyNyBTZXAgMjAyMSwgV2VpIENoZW4gd3JvdGU6DQo+ID4+Pj4+IC0tLS0tT3JpZ2luYWwg
TWVzc2FnZS0tLS0tDQo+ID4+Pj4+IEZyb206IFhlbi1kZXZlbCA8eGVuLWRldmVsLWJvdW5jZXNA
bGlzdHMueGVucHJvamVjdC5vcmc+IE9uIEJlaGFsZg0KPiBPZg0KPiA+Pj4gV2VpDQo+ID4+Pj4+
IENoZW4NCj4gPj4+Pj4gU2VudDogMjAyMeW5tDnmnIgyNuaXpSAxODoyNQ0KPiA+Pj4+PiBUbzog
SmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPg0KPiA+Pj4+PiBDYzogeGVuLWRldmVsQGxp
c3RzLnhlbnByb2plY3Qub3JnOyBqdWxpZW5AeGVuLm9yZzsgQmVydHJhbmQgTWFycXVpcw0KPiA+
Pj4+PiA8QmVydHJhbmQuTWFycXVpc0Bhcm0uY29tPjsgU3RlZmFubyBTdGFiZWxsaW5pDQo+IDxz
c3RhYmVsbGluaUBrZXJuZWwub3JnPg0KPiA+Pj4+PiBTdWJqZWN0OiBSRTogW1BBVENIIDIwLzM3
XSB4ZW46IGludHJvZHVjZSBDT05GSUdfRUZJIHRvIHN0dWIgQVBJIGZvcg0KPiA+Pj4gbm9uLQ0K
PiA+Pj4+PiBFRkkgYXJjaGl0ZWN0dXJlDQo+ID4+Pj4+DQo+ID4+Pj4+IEhpIEphbiwNCj4gPj4+
Pj4NCj4gPj4+Pj4+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+ID4+Pj4+PiBGcm9tOiBY
ZW4tZGV2ZWwgPHhlbi1kZXZlbC1ib3VuY2VzQGxpc3RzLnhlbnByb2plY3Qub3JnPiBPbiBCZWhh
bGYNCj4gPj4+IE9mDQo+ID4+Pj4+IEphbg0KPiA+Pj4+Pj4gQmV1bGljaA0KPiA+Pj4+Pj4gU2Vu
dDogMjAyMeW5tDnmnIgyNOaXpSAxODo0OQ0KPiA+Pj4+Pj4gVG86IFdlaSBDaGVuIDxXZWkuQ2hl
bkBhcm0uY29tPg0KPiA+Pj4+Pj4gQ2M6IHhlbi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZzsg
anVsaWVuQHhlbi5vcmc7IEJlcnRyYW5kDQo+IE1hcnF1aXMNCj4gPj4+Pj4+IDxCZXJ0cmFuZC5N
YXJxdWlzQGFybS5jb20+OyBTdGVmYW5vIFN0YWJlbGxpbmkNCj4gPj4+IDxzc3RhYmVsbGluaUBr
ZXJuZWwub3JnPg0KPiA+Pj4+Pj4gU3ViamVjdDogUmU6IFtQQVRDSCAyMC8zN10geGVuOiBpbnRy
b2R1Y2UgQ09ORklHX0VGSSB0byBzdHViIEFQSQ0KPiBmb3INCj4gPj4+Pj4gbm9uLQ0KPiA+Pj4+
Pj4gRUZJIGFyY2hpdGVjdHVyZQ0KPiA+Pj4+Pj4NCj4gPj4+Pj4+IE9uIDI0LjA5LjIwMjEgMTI6
MzEsIFdlaSBDaGVuIHdyb3RlOg0KPiA+Pj4+Pj4+PiBGcm9tOiBKYW4gQmV1bGljaCA8amJldWxp
Y2hAc3VzZS5jb20+DQo+ID4+Pj4+Pj4+IFNlbnQ6IDIwMjHlubQ55pyIMjTml6UgMTU6NTkNCj4g
Pj4+Pj4+Pj4NCj4gPj4+Pj4+Pj4gT24gMjQuMDkuMjAyMSAwNjozNCwgV2VpIENoZW4gd3JvdGU6
DQo+ID4+Pj4+Pj4+Pj4gRnJvbTogU3RlZmFubyBTdGFiZWxsaW5pIDxzc3RhYmVsbGluaUBrZXJu
ZWwub3JnPg0KPiA+Pj4+Pj4+Pj4+IFNlbnQ6IDIwMjHlubQ55pyIMjTml6UgOToxNQ0KPiA+Pj4+
Pj4+Pj4+DQo+ID4+Pj4+Pj4+Pj4gT24gVGh1LCAyMyBTZXAgMjAyMSwgV2VpIENoZW4gd3JvdGU6
DQo+ID4+Pj4+Pj4+Pj4+IC0tLSBhL3hlbi9jb21tb24vS2NvbmZpZw0KPiA+Pj4+Pj4+Pj4+PiAr
KysgYi94ZW4vY29tbW9uL0tjb25maWcNCj4gPj4+Pj4+Pj4+Pj4gQEAgLTExLDYgKzExLDE2IEBA
IGNvbmZpZyBDT01QQVQNCj4gPj4+Pj4+Pj4+Pj4gIGNvbmZpZyBDT1JFX1BBUktJTkcNCj4gPj4+
Pj4+Pj4+Pj4gIAlib29sDQo+ID4+Pj4+Pj4+Pj4+DQo+ID4+Pj4+Pj4+Pj4+ICtjb25maWcgRUZJ
DQo+ID4+Pj4+Pj4+Pj4+ICsJYm9vbA0KPiA+Pj4+Pj4+Pj4+DQo+ID4+Pj4+Pj4+Pj4gV2l0aG91
dCB0aGUgdGl0bGUgdGhlIG9wdGlvbiBpcyBub3QgdXNlci1zZWxlY3RhYmxlIChvciBkZS0NCj4g
Pj4+Pj4+IHNlbGVjdGFibGUpLg0KPiA+Pj4+Pj4+Pj4+IFNvIHRoZSBoZWxwIG1lc3NhZ2UgYmVs
b3cgY2FuIG5ldmVyIGJlIHNlZW4uDQo+ID4+Pj4+Pj4+Pj4NCj4gPj4+Pj4+Pj4+PiBFaXRoZXIg
YWRkIGEgdGl0bGUsIGUuZy46DQo+ID4+Pj4+Pj4+Pj4NCj4gPj4+Pj4+Pj4+PiBib29sICJFRkkg
c3VwcG9ydCINCj4gPj4+Pj4+Pj4+Pg0KPiA+Pj4+Pj4+Pj4+IE9yIGZ1bGx5IG1ha2UgdGhlIG9w
dGlvbiBhIHNpbGVudCBvcHRpb24gYnkgcmVtb3ZpbmcgdGhlIGhlbHANCj4gPj4+IHRleHQuDQo+
ID4+Pj4+Pj4+Pg0KPiA+Pj4+Pj4+Pj4gT0ssIGluIGN1cnJlbnQgWGVuIGNvZGUsIEVGSSBpcyB1
bmNvbmRpdGlvbmFsbHkgY29tcGlsZWQuIEJlZm9yZQ0KPiA+Pj4+Pj4+Pj4gd2UgY2hhbmdlIHJl
bGF0ZWQgY29kZSwgSSBwcmVmZXIgdG8gcmVtb3ZlIHRoZSBoZWxwIHRleHQuDQo+ID4+Pj4+Pj4+
DQo+ID4+Pj4+Pj4+IEJ1dCB0aGF0J3Mgbm90IHRydWU6IEF0IGxlYXN0IG9uIHg4NiBFRkkgZ2V0
cyBjb21waWxlZCBkZXBlbmRpbmcNCj4gPj4+IG9uDQo+ID4+Pj4+Pj4+IHRvb2wgY2hhaW4gY2Fw
YWJpbGl0aWVzLiBVbHRpbWF0ZWx5IHdlIG1heSBpbmRlZWQgd2FudCBhIHVzZXINCj4gPj4+Pj4+
Pj4gc2VsZWN0YWJsZSBvcHRpb24gaGVyZSwgYnV0IHVudGlsIHRoZW4gSSdtIGFmcmFpZCBoYXZp
bmcgdGhpcw0KPiA+Pj4gb3B0aW9uDQo+ID4+Pj4+Pj4+IGF0IGFsbCBtYXkgYmUgbWlzbGVhZGlu
ZyBvbiB4ODYuDQo+ID4+Pj4+Pj4+DQo+ID4+Pj4+Pj4NCj4gPj4+Pj4+PiBJIGNoZWNrIHRoZSBi
dWlsZCBzY3JpcHRzLCB5ZXMsIHlvdSdyZSByaWdodC4gRm9yIHg4NiwgRUZJIGlzIG5vdA0KPiA+
Pj4gYQ0KPiA+Pj4+Pj4+IHNlbGVjdGFibGUgb3B0aW9uIGluIEtjb25maWcuIEkgYWdyZWUgd2l0
aCB5b3UsIHdlIGNhbid0IHVzZQ0KPiA+Pj4gS2NvbmZpZw0KPiA+Pj4+Pj4+IHN5c3RlbSB0byBk
ZWNpZGUgdG8gZW5hYmxlIEVGSSBidWlsZCBmb3IgeDg2IG9yIG5vdC4NCj4gPj4+Pj4+Pg0KPiA+
Pj4+Pj4+IFNvIGhvdyBhYm91dCB3ZSBqdXN0IHVzZSB0aGlzIEVGSSBvcHRpb24gZm9yIEFybSBv
bmx5PyBCZWNhdXNlIG9uDQo+ID4+PiBBcm0sDQo+ID4+Pj4+Pj4gd2UgZG8gbm90IGhhdmUgc3Vj
aCB0b29sY2hhaW4gZGVwZW5kZW5jeS4NCj4gPj4+Pj4+DQo+ID4+Pj4+PiBUbyBiZSBob25lc3Qg
LSBkb24ndCBrbm93LiBUaGF0J3MgYmVjYXVzZSBJIGRvbid0IGtub3cgd2hhdCB5b3UNCj4gd2Fu
dA0KPiA+Pj4+Pj4gdG8gdXNlIHRoZSBvcHRpb24gZm9yIHN1YnNlcXVlbnRseS4NCj4gPj4+Pj4+
DQo+ID4+Pj4+DQo+ID4+Pj4+IEluIGxhc3QgdmVyc2lvbiwgSSBoYWQgaW50cm9kdWNlZCBhbiBh
cmNoLWhlbHBlciB0byBzdHViIEVGSV9CT09UDQo+ID4+Pj4+IGluIEFybSdzIGNvbW1vbiBjb2Rl
IGZvciBBcm0zMi4gQmVjYXVzZSBBcm0zMiBkb2Vzbid0IHN1cHBvcnQgRUZJLg0KPiA+Pj4+PiBT
byBKdWxpZW4gc3VnZ2VzdGVkIG1lIHRvIGludHJvZHVjZSBhIENPTkZJR19FRkkgb3B0aW9uIGZv
ciBub24tRUZJDQo+ID4+Pj4+IHN1cHBvcnRlZCBhcmNoaXRlY3R1cmVzIHRvIHN0dWIgaW4gRUZJ
IGxheWVyLg0KPiA+Pj4+Pg0KPiA+Pj4+PiBbMV0gaHR0cHM6Ly9saXN0cy54ZW5wcm9qZWN0Lm9y
Zy9hcmNoaXZlcy9odG1sL3hlbi1kZXZlbC8yMDIxLQ0KPiA+Pj4+PiAwOC9tc2cwMDgwOC5odG1s
DQo+ID4+Pj4+DQo+ID4+Pj4NCj4gPj4+PiBBcyBKYW4nIHJlbWluZGVkLCB4ODYgZG9lc24ndCBk
ZXBlbmQgb24gS2NvbmZpZyB0byBidWlsZCBFRkkgY29kZS4NCj4gPj4+PiBTbywgaWYgd2UgQ09O
RklHX0VGSSB0byBzdHViIEVGSSBBUEkncyBmb3IgeDg2LCB3ZSB3aWxsIGVuY291bnRlcg0KPiA+
Pj4+IHRoYXQgdG9vbGNoYWlucyBlbmFibGUgRUZJLCBidXQgS2NvbmZpZyBkaXNhYmxlIEVGSS4g
T3IgS2NvbmZpZw0KPiA+Pj4+IGVuYWJsZSBFRkkgYnV0IHRvb2xjaGFpbiBkb2Vzbid0IHByb3Zp
ZGUgRUZJIGJ1aWxkIHN1cHBvcnRzLiBBbmQNCj4gPj4+PiB0aGVuIHg4NiBjb3VsZCBub3Qgd29y
ayB3ZWxsLg0KPiA+Pj4+DQo+ID4+Pj4gSWYgd2UgdXNlIENPTkZJR19FRkkgZm9yIEFybSBvbmx5
LCB0aGF0IG1lYW5zIENPTkZJR19FRkkgZm9yIHg4Ng0KPiA+Pj4+IGlzIG9mZiwgdGhpcyB3aWxs
IGFsc28gY2F1c2UgcHJvYmxlbS4NCj4gPj4+Pg0KPiA+Pj4+IFNvLCBjYW4gd2Ugc3RpbGwgdXNl
IHByZXZpb3VzIGFyY2hfaGVscGVycyB0byBzdHViIGZvciBBcm0zMj8NCj4gPj4+PiB1bnRpbCB4
ODYgY2FuIHVzZSB0aGlzIHNlbGVjdGFibGUgb3B0aW9uPw0KPiA+Pj4NCj4gPj4+IEVGSSBkb2Vz
bid0IGhhdmUgdG8gYmUgbmVjZXNzYXJpbHkgYSB1c2VyLXZpc2libGUgb3B0aW9uIGluIEtjb25m
aWcgYXQNCj4gPj4+IHRoaXMgcG9pbnQuIEkgdGhpbmsgSnVsaWVuIHdhcyBqdXN0IGFza2luZyB0
byBtYWtlIHRoZSAjaWZkZWYgYmFzZWQgb24NCj4gPj4+IGEgRUZJLXJlbGF0ZWQgY29uZmlnIHJh
dGhlciB0aGFuIGp1c3QgYmFzZWQgQ09ORklHX0FSTTY0Lg0KPiA+Pj4NCj4gPj4+IE9uIHg4NiBF
RkkgaXMgZGV0ZWN0ZWQgYmFzZWQgb24gY29tcGlsZXIgc3VwcG9ydCwgc2V0dGluZw0KPiBYRU5f
QlVJTERfRUZJDQo+ID4+PiBpbiB4ZW4vYXJjaC94ODYvTWFrZWZpbGUuIExldCdzIHNheSB0aGF0
IHdlIGtlZXAgdXNpbmcgdGhlIHNhbWUgbmFtZQ0KPiA+Pj4gIlhFTl9CVUlMRF9FRkkiIG9uIEFS
TSBhcyB3ZWxsLg0KPiA+Pj4NCj4gPj4+IE9uIEFSTTMyLCBYRU5fQlVJTERfRUZJIHNob3VsZCBi
ZSBhbHdheXMgdW5zZXQuDQo+ID4+Pg0KPiA+Pj4gT24gQVJNNjQgWEVOX0JVSUxEX0VGSSBzaG91
bGQgYmUgYWx3YXlzIHNldC4NCj4gPj4+DQo+ID4+PiBUaGF0J3MgaXQsIHJpZ2h0PyBJJ2QgYXJn
dWUgdGhhdCBDT05GSUdfRUZJIG9yIEhBU19FRkkgYXJlIGJldHRlcg0KPiBuYW1lcw0KPiA+Pj4g
dGhhbiBYRU5fQlVJTERfRUZJLCBidXQgdGhhdCdzIE9LIGFueXdheS4gU28gZm9yIGluc3RhbmNl
IHlvdSBjYW4gbWFrZQ0KPiA+Pj4gWEVOX0JVSUxEX0VGSSBhbiBpbnZpc2libGUgc3ltYm9sIGlu
IHhlbi9hcmNoL2FybS9LY29uZmlnIGFuZCBzZWxlY3QNCj4gaXQNCj4gPj4+IG9ubHkgb24gQVJN
NjQuDQo+ID4+DQo+ID4+IFRoYW5rcywgdGhpcyBpcyBhIGdvb2QgYXBwcm9hY2guIEJ1dCBpZiB3
ZSBwbGFjZSBYRU5fQlVJTERfRUZJIGluDQo+IEtjb25maWcNCj4gPj4gaXQgd2lsbCBiZSB0cmFu
c2ZlciB0byBDT05GSUdfWEVOX0JVSUxEX0VGSS4gSG93IGFib3V0IHVzaW5nIGFub3RoZXINCj4g
bmFtZQ0KPiA+PiBpbiBLY29uZmlnIGxpa2UgQVJNX0VGSSwgYnV0IHVzZSBDT05GSUdfQVJNX0VG
SSBpbiBjb25maWcuaCB0byBkZWZpbmUNCj4gPj4gWEVOX0JVSUxEX0VGST8NCj4gPg0KPiA+IEkg
YW0gT0sgd2l0aCB0aGF0LiBBbm90aGVyIG9wdGlvbiBpcyB0byByZW5hbWUgWEVOX0JVSUxEX0VG
SSB0bw0KPiA+IENPTkZJR19YRU5fQlVJTERfRUZJIG9uIHg4Ni4gRWl0aGVyIHdheSBpcyBmaW5l
IGJ5IG1lLiBKYW4sIGRvIHlvdSBoYXZlYQ0KPiA+IHByZWZlcmVuY2U/DQo+IA0KPiBZZXMsIEkg
ZG86IE5vIG5ldyBDT05GSUdfKiBzZXR0aW5ncyBwbGVhc2UgdGhhdCBkb24ndCBvcmlnaW5hdGUg
ZnJvbQ0KPiBLY29uZmlnLiBIZW5jZSBJJ20gYWZyYWlkIHRoaXMgaXMgYSAibm8iIHRvIHlvdXIg
c3VnZ2VzdGlvbi4NCj4gDQo+IE1pZC10ZXJtIHdlIHNob3VsZCB0cnkgdG8gZ2V0IHJpZCBvZiB0
aGUgcmVtYWluaW5nIENPTkZJR18qIHdoaWNoDQo+IGdldCAjZGVmaW5lLWQgaW4gZS5nLiBhc20v
Y29uZmlnLmguDQo+IA0KDQpJIHdpbGwgZG8gc29tZXRoaW5nIGxpa2UgdGhpczogDQogLSBpbnRy
b2R1Y2UgYW4gQVJNX0VGSSBpbnZpc2libGUgc3ltYm9sIGluIGtjb25maWcsIHNlbGVjdGVkIGJ5
IEFSTTY0IG9ubHkNCiAtIHVzZSBDT05GSUdfQVJNX0VGSSB0byBkZWZpbmUgWEVOX0JVSUxEX0VG
SSBpbiBjb25maWcuaA0KDQo+IEphbg0KDQo=


From xen-devel-bounces@lists.xenproject.org Mon Oct 04 05:32:15 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Oct 2021 05:32:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.201166.355583 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXGZm-0000TV-7I; Mon, 04 Oct 2021 05:31:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 201166.355583; Mon, 04 Oct 2021 05:31:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXGZm-0000TO-4D; Mon, 04 Oct 2021 05:31:46 +0000
Received: by outflank-mailman (input) for mailman id 201166;
 Mon, 04 Oct 2021 05:31:44 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=7SE7=OY=suse.com=jgross@srs-us1.protection.inumbo.net>)
 id 1mXGZj-0000TI-Vd
 for xen-devel@lists.xenproject.org; Mon, 04 Oct 2021 05:31:44 +0000
Received: from smtp-out2.suse.de (unknown [195.135.220.29])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 5ad447de-24d4-11ec-be99-12813bfff9fa;
 Mon, 04 Oct 2021 05:31:42 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 6F7221FFBE;
 Mon,  4 Oct 2021 05:31:41 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 5523F133A6;
 Mon,  4 Oct 2021 05:31:41 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id 9i6KE72RWmEWTgAAMHmgww
 (envelope-from <jgross@suse.com>); Mon, 04 Oct 2021 05:31:41 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5ad447de-24d4-11ec-be99-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1633325501; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=iPYUIllycLo2HuYYYxhIELFRTEakrWpSdfB6Up0ETSo=;
	b=SWad/84HQ5ljVDQK9/ibzcgN7HRJ3+Vu5n47syOeFMzJdXpNw16G99QirMCG3pzxQk94a1
	P/B6pMxft+YNoL0qDdNVia8cj7OWXzk5Eg5WmFJXEPuTyi/3iu3ZfVdgRzBwh/AGZ+XDmT
	e4rbANiPBZbEAgEyedsc5VW5KTl7lHE=
Subject: Re: xen-balloon thread using 100% of CPU, regression in 5.4.150
To: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?=
 <marmarek@invisiblethingslab.com>, xen-devel <xen-devel@lists.xenproject.org>
Cc: Jan Beulich <jbeulich@suse.com>
References: <YVk11h2l/u4GJNv0@mail-itl>
From: Juergen Gross <jgross@suse.com>
Message-ID: <37c22c61-80be-fc48-18e6-2b1ee22cc765@suse.com>
Date: Mon, 4 Oct 2021 07:31:40 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <YVk11h2l/u4GJNv0@mail-itl>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="mtOEZHnRc6942ExwsnPtn5QoGrfi6Z7sr"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--mtOEZHnRc6942ExwsnPtn5QoGrfi6Z7sr
Content-Type: multipart/mixed; boundary="kU7Kewd1kBfd9MEHYRfjjRc4wJoH9HC07";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?=
 <marmarek@invisiblethingslab.com>, xen-devel <xen-devel@lists.xenproject.org>
Cc: Jan Beulich <jbeulich@suse.com>
Message-ID: <37c22c61-80be-fc48-18e6-2b1ee22cc765@suse.com>
Subject: Re: xen-balloon thread using 100% of CPU, regression in 5.4.150
References: <YVk11h2l/u4GJNv0@mail-itl>
In-Reply-To: <YVk11h2l/u4GJNv0@mail-itl>

--kU7Kewd1kBfd9MEHYRfjjRc4wJoH9HC07
Content-Type: multipart/mixed;
 boundary="------------2AAC713BCC362BE157EB8760"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------2AAC713BCC362BE157EB8760
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 03.10.21 06:47, Marek Marczykowski-G=C3=B3recki wrote:
> Hi,
>=20
> After updating a PVH domU to 5.4.150, I see xen-balloon thread using
> 100% CPU (one thread).
> This is a domain started with memory=3Dmaxmem=3D716800KiB (via libvirt)=
=2E Then,
> inside, I see:
>=20
> # cat /sys/devices/system/xen_memory/xen_memory0/target_kb
> 716924
> # cat /sys/devices/system/xen_memory/xen_memory0/info/current_kb
> 716400
>=20
> Doing `cat info/current_kb > target_kb` "fixes" the issue. But still,
> something is wrong - on earlier kernel (5.4.143 to be precise), it
> wasn't spinning, with exactly the same values reported in sysfs. It
> shouldn't run in circles if it can't get that much memory it wants. I
> strongly suspect "xen/balloon: use a kernel thread instead a workqueue"=

> or related commit being responsible, but I haven't verified it.

I think you are right. I need to handle the BP_ECANCELED case similar to
BP_EAGAIN in the kernel thread (wait until target size changes again).

One further question: do you see any kernel message in the guest related
to the looping balloon thread?


Juergen

--------------2AAC713BCC362BE157EB8760
Content-Type: application/pgp-keys;
 name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Transfer-Encoding: quoted-printable
Content-Description: OpenPGP public key
Content-Disposition: attachment;
 filename="OpenPGP_0xB0DE9DD628BF132F.asc"

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy=
cWx
w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O=
f8Z
d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y=
9bf
IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq=
G7/
377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR=
3Jv
c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA=
QIe
AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT=
hpw
dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0=
MbD
1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv=
oPH
Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v=
5QL
+qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ=
2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC=
QoL
BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr=
Wf0
teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC=
/nu
AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh=
ITT
d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm=
XBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz=
80h
SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC=
AcD
AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn=
FOX
gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1=
jnD
kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0=
N51
N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l=
otu
fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1=
tqS
EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA=
hsD
BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3=
g3O
ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5=
dM7
wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5=
D+j
LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm=
V2x
AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N=
Eaw
QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW=
nHI
s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR=
wgn
BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV=
bVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk=
pEd
IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA=
QAB
wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw=
Tbe
8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1=
vJz
Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8=
VGi
wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW=
svi
uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX=
zXs
ZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------2AAC713BCC362BE157EB8760--

--kU7Kewd1kBfd9MEHYRfjjRc4wJoH9HC07--

--mtOEZHnRc6942ExwsnPtn5QoGrfi6Z7sr
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmFakbwFAwAAAAAACgkQsN6d1ii/Ey+e
rAgAlIL/+2IQYU0lMZSEniNCp3F69HVu1rhqmX4CKBaalDngzNsYwr8UGNEpLiciz/hfl2le/phV
mS6NXf2ZNPxAk7f6xgy7A+pCAHcenL5tSc7LGVRy2Dk0z2kCJq52y/xug4prPhzNkcs1rNkb3Qvf
ogwnelnfITC4axnGXUpzdxMv5ecwa2Dm37mmqwKUi/Ngh/8pUG6bmUo7MrGUmazbA+0f2ZG8shQi
/35QWWKTho9wYmR6A3Xe+S8gH3Z6vfkLWE+8hQ7xKzGzUiRT2jLO6kwAwVyNqQRokKtldK8Ndfwd
CGpOFZO1pum5eJwsLU/yqGie4xmknx4Fi8p2L6xt7A==
=myLl
-----END PGP SIGNATURE-----

--mtOEZHnRc6942ExwsnPtn5QoGrfi6Z7sr--


From xen-devel-bounces@lists.xenproject.org Mon Oct 04 05:58:46 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Oct 2021 05:58:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.201176.355594 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXGzd-0002tp-GR; Mon, 04 Oct 2021 05:58:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 201176.355594; Mon, 04 Oct 2021 05:58:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXGzd-0002ti-DU; Mon, 04 Oct 2021 05:58:29 +0000
Received: by outflank-mailman (input) for mailman id 201176;
 Mon, 04 Oct 2021 05:58:28 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=h/Ch=OY=epam.com=prvs=0911b85996=oleksandr_andrushchenko@srs-us1.protection.inumbo.net>)
 id 1mXGzc-0002tJ-CD
 for xen-devel@lists.xenproject.org; Mon, 04 Oct 2021 05:58:28 +0000
Received: from mx0a-0039f301.pphosted.com (unknown [148.163.133.242])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id d65eb80c-57a2-4eb3-a531-e6a7fe3d4ad0;
 Mon, 04 Oct 2021 05:58:27 +0000 (UTC)
Received: from pps.filterd (m0174677.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 1945mJtS024268; 
 Mon, 4 Oct 2021 05:58:24 GMT
Received: from eur01-ve1-obe.outbound.protection.outlook.com
 (mail-ve1eur01lp2052.outbound.protection.outlook.com [104.47.1.52])
 by mx0a-0039f301.pphosted.com with ESMTP id 3bfu8mg25w-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Mon, 04 Oct 2021 05:58:24 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by VI1PR0302MB2766.eurprd03.prod.outlook.com (2603:10a6:800:dd::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.15; Mon, 4 Oct
 2021 05:58:21 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::e966:6290:5736:b7bd]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::e966:6290:5736:b7bd%7]) with mapi id 15.20.4566.022; Mon, 4 Oct 2021
 05:58:21 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d65eb80c-57a2-4eb3-a531-e6a7fe3d4ad0
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=moWQp0X0lh74gaXilzCwfi4JBDX9c8aBFkhRzqF9yhmt+vqT51NwaD/ka2H6OGiajLmIp4U6rlU4MFhz3uw6e7OdxshRNUji+UAsLbdnT0jYqA7YlYupCNCG2m3iDwGIszyFRt5YkNFnWpZ4Q13XlcE7/QitGmU9pvJPh1tzM51hvvcQDQzj1Iv8Vyp0JJ9ESv3gu6eZUjMZzi61vGajEq5k2meqVSF835nJ009YrVMPQZbJb8996ldNPpqh1JwW5/5ohAsxzDyXVgZvIK/ShjAvUkdWW7GUD+gn+cYU1MV6zGfZtlT9zHp2jgWHhDb/5xVb/7BlIWYtd+JvNMy1qw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Or5bN5AFgnGV9W2xYcfJ1mgb0piJ8h17FuIPymu2rQo=;
 b=YuWSZPK4mb60ah32UWfKN2CXoTaEKv5KIzdU5qHCHmTX7n3m+nKUpUPYJVU4uXfgVqYZ9p/vkUyng+Z4uaJbSUfrz2P1NT0/egy65yLrazTBc/8f4fYULzBrg0uNxiPdeUhCR/qO7aJmr6HvSQjpdL97Hlq89jbUmWTE/ZLJkf2kRoEkdb0sRqPOJqd/kUVQukTxpxUsSe4LcjKHZZFP+Zogyp1+tl77iuAJQP/qBmndLgaG7s2+VyP3R9WP8csz8da5IGnvkBaOui3kFNAL8r95s9o94ZBOvAX+9T1fkSoW2/meXpJ0+buGDV8A7lkJaBbj+wSxFsh48L+rdSzq6A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Or5bN5AFgnGV9W2xYcfJ1mgb0piJ8h17FuIPymu2rQo=;
 b=3P0Q23mxJ1RAdvFQBjELiqKQBeTb/v2JWG2XFWXhDYXd0HXZsk6Mr8Vq7+lsmAGBr3rM9KXSMFhluNLdH7L5JVAWMU66Y9fUVp68xXpw+PFqjq2GtnNtfoCfCarUGszMVNtI9WdhiGmtsMRDUsUsMHrUeeBTSNzlckrmWv4b4Oc8SQQ3r92bdNqlHVaMB2OSGGetBFZmRZFjea6nQb6wFscM3Z8/gJwmQIXHmWfA3iyQW9nAm9///iLqa4+RrdgqRWgo23NFWK2rog6vsOkLHCyyxA0UyVXwlZx+n3Ehi/hlCGId8BUrvgYFDMXbWQJZHBzC4JOT6M3RfTFop7irtQ==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org"
	<sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "roger.pau@citrix.com" <roger.pau@citrix.com>,
        Bertrand Marquis
	<bertrand.marquis@arm.com>,
        Rahul Singh <rahul.singh@arm.com>,
        "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        Oleksandr
 Andrushchenko <Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH v3 04/11] vpci/header: Add and remove register handlers
 dynamically
Thread-Topic: [PATCH v3 04/11] vpci/header: Add and remove register handlers
 dynamically
Thread-Index: AQHXtdAhL3wGQmCTxkGG8eG4L2Ylc6u+JFCAgAQ5ugA=
Date: Mon, 4 Oct 2021 05:58:20 +0000
Message-ID: <e3730616-c51f-c453-3f74-584473313e54@epam.com>
References: <20210930075223.860329-1-andr2000@gmail.com>
 <20210930075223.860329-5-andr2000@gmail.com>
 <2b575750-83a5-588e-fd6b-dd9cdb9500dd@suse.com>
In-Reply-To: <2b575750-83a5-588e-fd6b-dd9cdb9500dd@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
authentication-results: suse.com; dkim=none (message not signed)
 header.d=none;suse.com; dmarc=none action=none header.from=epam.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: cced4e55-ee7d-4c7f-b267-08d986fbf853
x-ms-traffictypediagnostic: VI1PR0302MB2766:
x-ms-exchange-transport-forked: True
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <VI1PR0302MB2766DE9213766BE98FD2BAE1E7AE9@VI1PR0302MB2766.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 iQ0Z03GSoEBQk/4IyjhGSGKGj4rSGFwzWzgJE7FThupUqlYWkaVuw2enmqugEaAidEOC3D2OayQyoXEld/nKzks6XgLPhzu4Aagx90sPAa0OGqDJLZ3wyADizevPZajECeM1SvtoHrnsKohYT/0l8Rxt/DWttPymNRA6OwwawLjmixB8cASST17aHflTguBq7aYdyo7bBLnHXGKXJE8nbVFVxvHkQP7qpqSAkKV453dozLAn6ztM27VFx3rQx6g6j4tkjlkqKaoCrGeBnpcvnKSehwlySlECWLjrio+5PFdFdBbdXo2fXo6XRwzvyHuMJSB8hq2xv02I8ThqmtUXjXBNg6ccbO0ECiRptDKG3czV/ZOPVnMtiWx6DzuoaNK1mJ85Ql215nkhE32+711iUDX23sODI20yV9+ZrKgtaIN6VN0CMFkZ5zxue8Pp63NBUMhLm6Wy4BrAnCvCL0SNdQgObmGnWlQyBGWtrwpRcO1/IkTF0BmviARXrGyNTR/OegAZ1VaO+qZCmQ3tUOsDU90sVoPyLxRiilDbHdtAFDDXNVbuMjKWccIWCEUcpKAcPhnHPZvMa+cPRgfUKmLmgGv3pIzVAd3L7GB3t0XgpX/Mdhv2KXxtLsKeToOoxBGa+qBeHanrvp26xFT4A0V1NqBkrWLnx492dNxLgCWCaaeCAABY5+kX5SDz/PR0PVys185mwbqNkFpiMnCJB0SEsQxB1wZVVA6SmAXitbYMQzhOoL/jpeQAu+QyphPdM2B6
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(86362001)(6512007)(55236004)(53546011)(66946007)(6506007)(2906002)(38070700005)(66556008)(64756008)(66446008)(66476007)(91956017)(6486002)(2616005)(76116006)(107886003)(4326008)(508600001)(122000001)(71200400001)(8936002)(31686004)(6916009)(5660300002)(31696002)(36756003)(186003)(54906003)(8676002)(316002)(26005)(38100700002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?cjBZaTYxTGQ5ZDh0VUU5VEpON1hJcGphTXdVTFVvY1N4bVZlQVF6RVhvdjl0?=
 =?utf-8?B?c0VNNnZWNzZQcVVWa2YyN3BmZElHdk9ZN01Ubm9HeFVxZVVyKzdjMEJLeDZv?=
 =?utf-8?B?QVduclErQUR4NUVWVjNZYTE0dmY2NGhVMTRMWjVSRU5RZ3FmMnk4QVV4Qmhm?=
 =?utf-8?B?UzNXbjN0RUZuVlhIVnpSd2EzRUh4SG10UjBaT0o0WlROejN1alNmUGU1dlJD?=
 =?utf-8?B?dWl2TzNsVlhuQ01DOTE5QVZ6L3BQaWxrSS9odjBQV3NRR0dqYnRuNUV0VXdu?=
 =?utf-8?B?aW9MRHVZTzJkenJDYTI5Wkh4Mm9aSDBIYUc5MkhWQmNoaWFVMFR4VFFLaU9o?=
 =?utf-8?B?V2FkallrTEhXZGI4Nm01cmppRVUvOTRyWDNzQU1UOFhGN3lPUk1lMWlPWUJH?=
 =?utf-8?B?dmdVeEpSS0t3MHphWTNrZlFzVXdmLzJWNTJVVzh0eVR6VVF0cmN6N2lnOWt0?=
 =?utf-8?B?RnkxcGhodlhRb0NCeFdyRG1mMXZ0aE5sY083a2ZCV2tvUXVxOVp5THZ3c3FT?=
 =?utf-8?B?cVVHdTdPSFQ1UUtiR1RXd0FNdlBWSXl6VEpYdEVRQUxpVC9jOTdTY1FEZ0FB?=
 =?utf-8?B?aGp1UHhsaitZQ3VFbFhJOUl0NlZjNWN6NndhYnZNQ1Vaa1hBUE5UYlB0T0dF?=
 =?utf-8?B?TzVVRG9ydlp3bG55N3JhckNlRldmVUg3a1BEakVuZ1hSTVM4d1Z3VFM2ZVls?=
 =?utf-8?B?aDJxQmVGdkxqN3JrNWowT09qNlN5QTRHM21Lblo3VkplUG5MMzQ4UllhZWQ1?=
 =?utf-8?B?L1NKaU1tZXNXdE5DZXFEekJxT1hweGU5M3pKQWhNQ1Irc0N4bTRsVFhHb1NC?=
 =?utf-8?B?RlJoZUd2NUFMeVBhVExpa2Zlamc3RU9JM2FrQXNQSWUydmtJZkxZdHovMVBz?=
 =?utf-8?B?TWZ2T2JSSFAra3ZHWlFMK3Y4TERLWlBHQWFWU05zdDVBSnRNUy9sL3FJcHVF?=
 =?utf-8?B?THRsVks0RStJSkRySXJHUEwwYTlvc3dRR0dXMzNnYnFxTHJ1UDRLWVZiQThZ?=
 =?utf-8?B?Rm1pWXRUWEt4MEluMnBJeUVKWW5lRE81cEtIcDZBMnpabHUzRjBYTkJ4YUFw?=
 =?utf-8?B?M3Nac1RpWCtJZVFDaEFHck5XbFFuQXp1Y1FqSFFMRnMzV1Y5V05zNnRFZWhW?=
 =?utf-8?B?Y25RK1cwT1VTbzJhZU55OU5BS0swWDdtRFN0bEpCUFY0ZGxQQ2phSzFuM3VC?=
 =?utf-8?B?d25wbHNYTVFEQndlNUl5RHdkMkRLbGdhL3o4MkQ1THpZZktyN1VPdURFUVph?=
 =?utf-8?B?YUphMWhOK3lzNStaQ1IrazZxZkNETXc0d3V5aWcyYzlrS21Xam11bnFxT2dB?=
 =?utf-8?B?TFFrMHVkc1VhRElXdFU3THh4c2ttWXVvZXI2eS8rYXlUNXA3bXcxTmhnYnpo?=
 =?utf-8?B?K29xVW9ZVDVvWTdqOWM4cFByaE1Ia0tkWElFM2dGUkRSSkRhU3lwbTY2OVdW?=
 =?utf-8?B?bWNOenVVOFFpeXhUckh6NUhmRjhPTTdQM2lKSEpTU1dzNmloU3lXeDhmdUNK?=
 =?utf-8?B?RkV6M2pKbG5kOVdxbkl6RDhQaWJjKzN5dkNQcHpKYm4vSDg4QTh2eS9ueHI0?=
 =?utf-8?B?Z2RvT2s0aGgwTGxGWUtUK3Q5dUxHTWpKUnJiOVlYSFpLcFRuYUIyUHJIa0ZR?=
 =?utf-8?B?a3ZzZlNpQ3M3TFFWMFNGNExPQWFQdEoybUlVYUZaK0ZGNDM1NncydlJJVkFl?=
 =?utf-8?B?VjBIQ0UyY2ZkdU85M3QvNlBKS25nK0JDR0YzNHdYaWlKUHR1ejJIcHVPa1ph?=
 =?utf-8?B?Q3hKalRFVCtzU3UzQVJwY1krTE1YZzdwamVWbCtKNjZpNGt0bnZCL3dxbHVJ?=
 =?utf-8?B?OVNsdEZrSytFNHE0a0t1dz09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <05E45539709DC94F8AD9FA355B991980@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cced4e55-ee7d-4c7f-b267-08d986fbf853
X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Oct 2021 05:58:20.9260
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: a7MY/dcZS3zXipvIRPxMlhr4ROiviaauciAXBwA8ShdAfryO966Uis1p/sgjLJwVqnfJgj/csZm/dRt0aNgXw/TSMcAyjLvjLEZZ0EMVKBOlKSBz5niBs62l/bIg4JA3
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0302MB2766
X-Proofpoint-GUID: xazyIYOI8ok6FRNFUwhiWo3rhSA74Qlu
X-Proofpoint-ORIG-GUID: xazyIYOI8ok6FRNFUwhiWo3rhSA74Qlu
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.391,FMLib:17.0.607.475
 definitions=2021-10-04_01,2021-10-01_02,2020-04-07_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 adultscore=0
 bulkscore=0 priorityscore=1501 mlxscore=0 clxscore=1015 suspectscore=0
 impostorscore=0 lowpriorityscore=0 malwarescore=0 spamscore=0
 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2109230001 definitions=main-2110040042

DQoNCk9uIDAxLjEwLjIxIDE2OjI2LCBKYW4gQmV1bGljaCB3cm90ZToNCj4gT24gMzAuMDkuMjAy
MSAwOTo1MiwgT2xla3NhbmRyIEFuZHJ1c2hjaGVua28gd3JvdGU6DQo+PiBAQCAtNDQ1LDE0ICs0
NTYsMjUgQEAgc3RhdGljIHZvaWQgcm9tX3dyaXRlKGNvbnN0IHN0cnVjdCBwY2lfZGV2ICpwZGV2
LCB1bnNpZ25lZCBpbnQgcmVnLA0KPj4gICAgICAgICAgIHJvbS0+YWRkciA9IHZhbCAmIFBDSV9S
T01fQUREUkVTU19NQVNLOw0KPj4gICB9DQo+PiAgIA0KPj4gLXN0YXRpYyBpbnQgYWRkX2Jhcl9o
YW5kbGVycyhjb25zdCBzdHJ1Y3QgcGNpX2RldiAqcGRldikNCj4+ICtzdGF0aWMgdm9pZCBndWVz
dF9yb21fd3JpdGUoY29uc3Qgc3RydWN0IHBjaV9kZXYgKnBkZXYsIHVuc2lnbmVkIGludCByZWcs
DQo+PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgIHVpbnQzMl90IHZhbCwgdm9pZCAqZGF0
YSkNCj4+ICt7DQo+PiArfQ0KPj4gKw0KPj4gK3N0YXRpYyB1aW50MzJfdCBndWVzdF9yb21fcmVh
ZChjb25zdCBzdHJ1Y3QgcGNpX2RldiAqcGRldiwgdW5zaWduZWQgaW50IHJlZywNCj4+ICsgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgdm9pZCAqZGF0YSkNCj4+ICt7DQo+PiArICAgIHJl
dHVybiAweGZmZmZmZmZmOw0KPj4gK30NCj4+ICsNCj4+ICtzdGF0aWMgaW50IGFkZF9iYXJfaGFu
ZGxlcnMoY29uc3Qgc3RydWN0IHBjaV9kZXYgKnBkZXYsIGJvb2wgaXNfaHdkb20pDQo+IEkgcmVt
YWluIHVuY29udmluY2VkIHRoYXQgdGhpcyBib29sZWFuIGlzIHRoZSBiZXN0IHdheSB0byBnbyBo
ZXJlLA0KSSBjYW4gcmVtb3ZlICJib29sIGlzX2h3ZG9tIiBhbmQgaGF2ZSB0aGUgY2hlY2tzIGxp
a2U6DQoNCnN0YXRpYyBpbnQgYWRkX2Jhcl9oYW5kbGVycyhjb25zdCBzdHJ1Y3QgcGNpX2RldiAq
cGRldikNCnsNCi4uLg0KIMKgwqDCoCBpZiAoIGlzX2hhcmR3YXJlX2RvbWFpbihwZGV2LT5kb21h
aW4pICkNCiDCoMKgwqDCoMKgwqDCoCByYyA9IHZwY2lfYWRkX3JlZ2lzdGVyKHBkZXYtPnZwY2ks
IHZwY2lfaHdfcmVhZDE2LCBjbWRfd3JpdGUsDQogwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIFBDSV9DT01NQU5ELCAyLCBoZWFkZXIp
Ow0KIMKgwqDCoCBlbHNlDQogwqDCoMKgwqDCoMKgwqAgcmMgPSB2cGNpX2FkZF9yZWdpc3Rlcihw
ZGV2LT52cGNpLCB2cGNpX2h3X3JlYWQxNiwgZ3Vlc3RfY21kX3dyaXRlLA0KIMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBQQ0lfQ09N
TUFORCwgMiwgaGVhZGVyKTsNCklzIHRoaXMgZ29pbmcgdG8gYmUgYmV0dGVyPw0KPiAgIGJ1dA0K
PiBJJ2xsIGxlYXZlIHRoZSBkZWNpc2lvbiB0aGVyZSB0byBSb2dlci4gSnVzdCBhIGNvdXBsZSBv
ZiBuaXRzOg0KPg0KPj4gQEAgLTU5Myw2ICs2MjUsMzAgQEAgc3RhdGljIGludCBpbml0X2JhcnMo
c3RydWN0IHBjaV9kZXYgKnBkZXYpDQo+PiAgIH0NCj4+ICAgUkVHSVNURVJfVlBDSV9JTklUKGlu
aXRfYmFycywgVlBDSV9QUklPUklUWV9NSURETEUpOw0KPj4gICANCj4+ICsjaWZkZWYgQ09ORklH
X0hBU19WUENJX0dVRVNUX1NVUFBPUlQNCj4+ICtpbnQgdnBjaV9iYXJfYWRkX2hhbmRsZXJzKGNv
bnN0IHN0cnVjdCBkb21haW4gKmQsIGNvbnN0IHN0cnVjdCBwY2lfZGV2ICpwZGV2KQ0KPj4gK3sN
Cj4+ICsgICAgaW50IHJjOw0KPj4gKw0KPj4gKyAgICAvKiBSZW1vdmUgcHJldmlvdXNseSBhZGRl
ZCByZWdpc3RlcnMuICovDQo+PiArICAgIHZwY2lfcmVtb3ZlX2RldmljZV9yZWdpc3RlcnMocGRl
dik7DQo+PiArDQo+PiArICAgIHJjID0gYWRkX2Jhcl9oYW5kbGVycyhwZGV2LCBpc19oYXJkd2Fy
ZV9kb21haW4oZCkpOw0KPj4gKyAgICBpZiAoIHJjICkNCj4+ICsgICAgICAgIGdkcHJpbnRrKFhF
TkxPR19FUlIsDQo+PiArICAgICAgICAgICAgICAgICAiJXBwOiBmYWlsZWQgdG8gYWRkIEJBUiBo
YW5kbGVycyBmb3IgZG9tJXBkOiAlZFxuIiwNCj4gT25seSAlcGQgcGxlYXNlLCBhcyB0aGF0IGFs
cmVhZHkgZXhwYW5kcyB0byBkPG51bT4uDQpHb29kIGNhdGNoLCB0aGFuayB5b3UhDQo+DQo+PiAr
ICAgICAgICAgICAgICAgICAmcGRldi0+c2JkZiwgZCwgcmMpOw0KPj4gKyAgICByZXR1cm4gcmM7
DQo+IEJsYW5rIGxpbmUgcGxlYXNlIGFoZWFkIG9mIHRoZSBtYWluIHJldHVybiBzdGF0ZW1lbnQg
b2YgYSBmdW5jdGlvbi4NCldpbGwgYWRkDQo+DQo+IEphbg0KPg0KVGhhbmsgeW91LA0KT2xla3Nh
bmRy


From xen-devel-bounces@lists.xenproject.org Mon Oct 04 06:26:26 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Oct 2021 06:26:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.201185.355606 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXHQP-0006Gw-Oj; Mon, 04 Oct 2021 06:26:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 201185.355606; Mon, 04 Oct 2021 06:26:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXHQP-0006Gp-LY; Mon, 04 Oct 2021 06:26:09 +0000
Received: by outflank-mailman (input) for mailman id 201185;
 Mon, 04 Oct 2021 06:26:08 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=h/Ch=OY=epam.com=prvs=0911b85996=oleksandr_andrushchenko@srs-us1.protection.inumbo.net>)
 id 1mXHQO-0006Gj-Hf
 for xen-devel@lists.xenproject.org; Mon, 04 Oct 2021 06:26:08 +0000
Received: from mx0b-0039f301.pphosted.com (unknown [148.163.137.242])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id c8b82507-9200-454d-ae90-e7b2a686ecbf;
 Mon, 04 Oct 2021 06:26:07 +0000 (UTC)
Received: from pps.filterd (m0174682.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 1945m8O4021351; 
 Mon, 4 Oct 2021 06:26:04 GMT
Received: from eur05-vi1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2177.outbound.protection.outlook.com [104.47.17.177])
 by mx0b-0039f301.pphosted.com with ESMTP id 3bfkk5gqy3-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Mon, 04 Oct 2021 06:26:04 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by AM0PR03MB6065.eurprd03.prod.outlook.com (2603:10a6:208:15c::28)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.14; Mon, 4 Oct
 2021 06:26:01 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::e966:6290:5736:b7bd]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::e966:6290:5736:b7bd%7]) with mapi id 15.20.4566.022; Mon, 4 Oct 2021
 06:26:01 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c8b82507-9200-454d-ae90-e7b2a686ecbf
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=DfT+QLxmAa5p+QEBkIpCyM9LQIlO3pIwp/1IPp/AgXtAkCW09c6oBPDfGW+v4vaatAeKjnrlowFzDwK4NJ3VOcZzTS3vRA2EXY0JHmkk6esO0ZIX8NT9zm9uQAImeH223CgtuYK7zPn7Mg19zwRd8gOYQyJBLy1OiQp2nNImt4lMk/uENh3b3BiD7NhZn+5g91RMK97wKWQBvw72v35OlAeJP0Y1vwW2txiMq3foICVQX4LOnaxhgy8WIviOfOnHWH/lB9uOYlydGkwOEpNZieogl6Q6glkuUAN2SvP29JIoEtnoohCYi4fyl+pVpqvruoSXYmFRipD6/n4e5Dx3mg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=baeOjaEe3e1UPUT4aYEJ5w1rhkqLJaAl/i8/ADtDl5M=;
 b=VjmYzXr6PciMst8v5fw1jX0VlG7XoDKuSkhzNDNlpcRokpH2xYiLWRlYLeXJCLYjEFQWVuV9+A43ZXeysH4t344BhYoj6rZs+/6ZD9Bhm3HjqYIRpjWJvpC+AYL7FYIpZ6vvMeWTSutads0G2fEhrDNhHwM/VWSZDtRQ/EcMB9actJrhkLph5DRA0vSbwfKkiuVc/BClL2U6KOYVhDFyMsRFKxaC5EuA0yaR01kZKyXh/WTvfhMeuB8+SMM8RvdD+pZy1G8h4rI7KgUDl6B3NVcMcefs6nFUlq/XALGnLz9NBQChlbMKRVIMHPUBdI/T+F1HmmqXO5OFjPUBSzBZ+w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=baeOjaEe3e1UPUT4aYEJ5w1rhkqLJaAl/i8/ADtDl5M=;
 b=lCPvn8CdVtVoClNYdzISNhfuhsuSZSMX1fijdtxbzBoE1c6WFUvRZc1rfmIt1v2UKoZHzSjzJgUn/uOCgC3v1rrgIcup5z9lM2A9hU3LnFmKPVE25qio4jQnxB6zn0JYR8v5EhsORL2ufHkND6zJ3jxVbkZVK615UIza7ykspp8fwdF9UunJfUYoN8p/cQ8ntaindf/pJkO2SkDpiIG/JdsFWXnHLky16222aLPMy9ldEuKr4HJpDX2snqrK4NqwiUBDlZVUeZl7++oAMYbO9DbY6ZFTUcDzLLuuAtp3TEYdGFNixhgBm1Knx7nmgQ0uwSjYS4kOgrCnUCl331OnmA==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org"
	<sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "roger.pau@citrix.com" <roger.pau@citrix.com>,
        Bertrand Marquis
	<bertrand.marquis@arm.com>,
        Rahul Singh <rahul.singh@arm.com>,
        "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        Oleksandr
 Andrushchenko <Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH v3 07/11] vpci/header: program p2m with guest BAR view
Thread-Topic: [PATCH v3 07/11] vpci/header: program p2m with guest BAR view
Thread-Index: AQHXtdAjmfMhzz5BYkuDgpOXg2armqu+J5EAgAQ+NYA=
Date: Mon, 4 Oct 2021 06:26:01 +0000
Message-ID: <0d73ef42-0395-92c3-fc4f-81183ce5d5cb@epam.com>
References: <20210930075223.860329-1-andr2000@gmail.com>
 <20210930075223.860329-8-andr2000@gmail.com>
 <39d756cb-6ea1-b787-b5e6-4d88e763feb1@suse.com>
In-Reply-To: <39d756cb-6ea1-b787-b5e6-4d88e763feb1@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
authentication-results: suse.com; dkim=none (message not signed)
 header.d=none;suse.com; dmarc=none action=none header.from=epam.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: ce857d4e-de2e-4b87-387b-08d986ffd62c
x-ms-traffictypediagnostic: AM0PR03MB6065:
x-ms-exchange-transport-forked: True
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <AM0PR03MB6065F68982ED3693D8290E19E7AE9@AM0PR03MB6065.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:8273;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 W7Ot9ITtqa5FnDhrXzR1d0DbcTjTEhGZI5pmsVjKnX6/YkW3E/We3NiCs/1Lodx68JOa5stayXbhvS6onAtG742Yg43PD0CivkCAtgWR5/B01a34nhAYhje8jAq7VgZCoYZqPydKRfcmxCPnCcuOvDf8ZGzIVUBWKmu317Rpjims6ARhz5nBaRqB/9DX3aouOiOgw+1sOY8hWjS+3GHqjZ/W9XOUUNHkONkO4ZYc/Za5BdbPY2i2uPsgYMIFpgfOSgg+HKv1sGz6Q0dHR18vuBl7YQOHrE+VGR7BwHy+SJcY0ZFiq5C5ZEc5okVJ9Vrku4CP25l/Cc8uag0y8YmmZI43fbEJZl7ljmLxgik/eH4VG81FqwaLyO/f21Rqdtdd7se+yciQIXKvlMJ4CgtXoYTqgGE4uU06MShL6Je3gaLORn/MaPC3NfJa2gdeGNrQlvLt1EV3Ws24ElSD+gl6K0oEUUkWyutx/zRO8G8lk9lv0ZyLU2DoGdycTYZEj67w0kmLbzO1zkMzofgZy8LRypoJhDEDYcDx6M9dcnfOH1/pkklc6LWtSUMGshi2r9d8FFMrqGHfm3iOWq9mPnDDDepS2OpadkzX2V/ChEdA725vR7eWESRTcInX8GNSYlcq02TAio7wX2m3oEmULk+xX+wTa3H8jGEj6z4o/MBcDiGOfyCzPCypIBigqhhqNEskNfbZSdhB1i4uYTrLV37iuMU1hnXuGZrf4RhaeX01mVdqqz8VGy1JISRasfLWRY4J
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(53546011)(64756008)(6486002)(6512007)(66476007)(38100700002)(316002)(8676002)(55236004)(66556008)(66946007)(36756003)(66446008)(122000001)(83380400001)(6506007)(508600001)(26005)(107886003)(2616005)(76116006)(31686004)(31696002)(71200400001)(5660300002)(54906003)(38070700005)(186003)(2906002)(4326008)(86362001)(8936002)(6916009)(91956017)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?cWZYNDBrYzFZQ2h5UGZjOEx6RVRCUkZCd01DTUpINkhEZlBTYVhJZ1lQc3lj?=
 =?utf-8?B?VzFqaldMU2VMZG9iZXpZd2tpRnRteHVzZUk1V2xuZ3laZ3VWbWJoRjRxT0pV?=
 =?utf-8?B?NXNRc05mZTdJdkNXTStPaTBja3E0aTkvNGh6TWxXM2hyenBsOWpEZHFBYk9Y?=
 =?utf-8?B?UlpkZzBGM291NE9abE1zcVpoanFvSXBBUVZldkpNNUR4c2xER2JRNHdaYXZP?=
 =?utf-8?B?TUozcXFMRncxRVNvalJlNGVUTXVoZkNZQ1pqZEV1T2NQS3BNQm9MYkowVDNt?=
 =?utf-8?B?RExrZ0tBTDFHeCtuZDdJWENTcHlrT2lqcHM5NjlHV1g1KzZ5MUt4d090WFZF?=
 =?utf-8?B?a29xbjFKYkhsR1dkYnRzTmxPUTduY1JWZ0UvaUZyM3VwOUZGNUVKYmcvSUVM?=
 =?utf-8?B?WWc2aDZ1QXhUUlg0QnlZbXFYa01XTllyMnlXZTQvSWlsa1JFWkxUN3V1Rmo3?=
 =?utf-8?B?ZnVLMUR2a2MxUGJkRkpiQVpoSU1NVFl2OGx2M2psbkY2WFVrRDExazNscEdH?=
 =?utf-8?B?NXRNcVNlSkliQUNiLzAwemF4WWVZK1ZmS3RQVjJhSDBpeXY4MEErdjQ1eUho?=
 =?utf-8?B?OFZidy9xTlpPd3VRcWRMam96NmE4Y0orRGdGM3hjdTVUQldjRnJrd2dOUHpP?=
 =?utf-8?B?WnBpNEFVdEFaMXpYSlFnTWhZK3ZnUFozUmVqeW1uQmNuZzFub2RlemJQdDI2?=
 =?utf-8?B?WG53WkRuWEVQaE9sdmRMMGw2NVhWaE9QQzdHVlo4bHduU1ZQMWtrTHJGelh5?=
 =?utf-8?B?ckxIOHMxNVdsU0Z2UVRZT0Myb0JROUo0WHpSV0tyT3Bxa29VZHlMcTU2NytD?=
 =?utf-8?B?d0JjQXhERWE3VUhqMDdQRFdBTXlmMnZMVHZYWUkwd1VPSENrbkt2bzMvd0Jz?=
 =?utf-8?B?cVRZQnZySFhoQmdHMXRpZkw2cVdLdDVqMVl6SnVHZHFTcEw4VFBmNUd3dzQ1?=
 =?utf-8?B?MjhLNXppTGkxUVJyUTVyUGNIY1BucHJ0YU1rUE1sUFdPY2E2YmJ0R0QxNHBQ?=
 =?utf-8?B?T1lFakx4bWVIWVhvaE5Ob2JITlNKbS9DZnNjaVlrRU4zUEZsQmxmZDhwOUtw?=
 =?utf-8?B?YUh2SWZ1MlozYUQ3eW5TUEZZVjlNajBRUndDek9Zd0JqNENDUFc0RkxDak5G?=
 =?utf-8?B?ZXd0d3dGOGphbHNEQjJBTlhrWTR5OEd4UkIxb1plY28vS25TWnpVbUxXTEFa?=
 =?utf-8?B?RjIwZnlJZFZPS2FXbVA4WE00REtRMm5LYi9uS3I1eWUyNFRxa0dRQzltQVoz?=
 =?utf-8?B?b2drdFkrSVVoSGFiZXNCRUZBTVNFaXpUVFdCOEY4eWttMVUzTUV5WVpXcHpi?=
 =?utf-8?B?QjVVRGhrcWFtSzZnRkhBdC9aVHVUWFNPenl3bXZjNkhEODAzUVRRR2NiTWFB?=
 =?utf-8?B?VkJOUFpmdldEK0pRSFhPRkR0SzRMbVhBcnIrRytGMU4yRlg2ZVhqdktuMlBW?=
 =?utf-8?B?bnpaUkNVMEZxd2o1eHBlUUhMSkxkY2FYa3lkbTJ2bGppWnhLeW1KckQ4dFRB?=
 =?utf-8?B?MFJra2s3NXlqRHBoRS9zY2NpV3E5Q0hWTm93amcxZWZ5NTJ3d2w4cnI2U1pS?=
 =?utf-8?B?eCtkbWJ2bXUwZ3I0cjd5aE1rUHhmQmkrTXhLcGIrZnJrTFA4Tjd4NjFNbThy?=
 =?utf-8?B?aXYza1JUQ0NWMllSRHZPR3kvV1J0SFIrOW10Wno2SkRHcHQ2UlRNUkRBSVNn?=
 =?utf-8?B?RzlpcWRxWmtVdXloaXdOWWY5eHFHZCtqWGZSd2w2cE9WU2Z0dHpsUTVhSHRa?=
 =?utf-8?B?elN1RXBIMEdXYmZ0WjMrL3o2SThKd2NpdWE3aVpoYlNKL0IyYkFDZFRJc0dC?=
 =?utf-8?B?SUxYOTN6OVN0eWw2THBBZz09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <05AA2340532E544B8A8DB44D69A6B6D7@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ce857d4e-de2e-4b87-387b-08d986ffd62c
X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Oct 2021 06:26:01.6017
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: dr0X/NxzAvN4yFC/pIB+3NmRzRi8zptUsNvCkXJaqqOodu1c+H8Ym+cdX2z88V0N7x3G7duK1gKYE7GAD4NG/gt54i58czap+SFzulUMR+ak2cGPDcGWNHGNfdNIp7mQ
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR03MB6065
X-Proofpoint-GUID: wDpre0daeQzV7uLfshEPclCh4sWpSzqu
X-Proofpoint-ORIG-GUID: wDpre0daeQzV7uLfshEPclCh4sWpSzqu
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.391,FMLib:17.0.607.475
 definitions=2021-10-04_01,2021-10-01_02,2020-04-07_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 suspectscore=0
 spamscore=0 phishscore=0 mlxlogscore=999 mlxscore=0 adultscore=0
 malwarescore=0 impostorscore=0 lowpriorityscore=0 priorityscore=1501
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2109230001 definitions=main-2110040045

DQoNCk9uIDAxLjEwLjIxIDE2OjM4LCBKYW4gQmV1bGljaCB3cm90ZToNCj4gT24gMzAuMDkuMjAy
MSAwOTo1MiwgT2xla3NhbmRyIEFuZHJ1c2hjaGVua28gd3JvdGU6DQo+PiBGcm9tOiBPbGVrc2Fu
ZHIgQW5kcnVzaGNoZW5rbyA8b2xla3NhbmRyX2FuZHJ1c2hjaGVua29AZXBhbS5jb20+DQo+Pg0K
Pj4gVGFrZSBpbnRvIGFjY291bnQgZ3Vlc3QncyBCQVIgdmlldyBhbmQgcHJvZ3JhbSBpdHMgcDJt
IGFjY29yZGluZ2x5Og0KPj4gZ2ZuIGlzIGd1ZXN0J3MgdmlldyBvZiB0aGUgQkFSIGFuZCBtZm4g
aXMgdGhlIHBoeXNpY2FsIEJBUiB2YWx1ZSBhcyBzZXQNCj4+IHVwIGJ5IHRoZSBob3N0IGJyaWRn
ZSBpbiB0aGUgaGFyZHdhcmUgZG9tYWluLg0KPj4gVGhpcyB3YXkgaGFyZHdhcmUgZG9hbWluIHNl
ZXMgcGh5c2ljYWwgQkFSIHZhbHVlcyBhbmQgZ3Vlc3Qgc2Vlcw0KPj4gZW11bGF0ZWQgb25lcy4N
Cj4+DQo+PiBTaWduZWQtb2ZmLWJ5OiBPbGVrc2FuZHIgQW5kcnVzaGNoZW5rbyA8b2xla3NhbmRy
X2FuZHJ1c2hjaGVua29AZXBhbS5jb20+DQo+IEp1c3QgYSBjb3VwbGUgb2Ygbml0cywgYXMgSSBy
ZW1haW4gdW5jb252aW5jZWQgb2YgdGhlIHJhbmdlc2V0IHJlbGF0ZWQNCj4gY2hvaWNlIGluIHRo
ZSBlYXJsaWVyIHBhdGNoLg0KPg0KPj4gQEAgLTM3LDEyICs0MSwyOCBAQCBzdGF0aWMgaW50IG1h
cF9yYW5nZSh1bnNpZ25lZCBsb25nIHMsIHVuc2lnbmVkIGxvbmcgZSwgdm9pZCAqZGF0YSwNCj4+
ICAgICAgICAgICAgICAgICAgICAgICAgdW5zaWduZWQgbG9uZyAqYykNCj4+ICAgew0KPj4gICAg
ICAgY29uc3Qgc3RydWN0IG1hcF9kYXRhICptYXAgPSBkYXRhOw0KPj4gKyAgICBnZm5fdCBzdGFy
dF9nZm47DQo+PiAgICAgICBpbnQgcmM7DQo+PiAgIA0KPj4gICAgICAgZm9yICggOyA7ICkNCj4+
ICAgICAgIHsNCj4+ICAgICAgICAgICB1bnNpZ25lZCBsb25nIHNpemUgPSBlIC0gcyArIDE7DQo+
PiAgIA0KPj4gKyAgICAgICAgLyoNCj4+ICsgICAgICAgICAqIEFueSBCQVIgbWF5IGhhdmUgaG9s
ZXMgaW4gaXRzIG1lbW9yeSB3ZSB3YW50IHRvIG1hcCwgZS5nLg0KPj4gKyAgICAgICAgICogd2Ug
ZG9uJ3Qgd2FudCB0byBtYXAgTVNJLVggcmVnaW9ucyB3aGljaCBtYXkgYmUgYSBwYXJ0IG9mIHRo
YXQgQkFSLA0KPj4gKyAgICAgICAgICogZS5nLiB3aGVuIGEgc2luZ2xlIEJBUiBpcyB1c2VkIGZv
ciBib3RoIE1NSU8gYW5kIE1TSS1YLg0KPiBUaGlzIHNlY29uZCAiZS5nLiIgc2VlbXMsIHRvIG1l
IGF0IGxlYXN0LCBxdWl0ZSByZWR1bmRhbnQgd2l0aCB0aGUgZmlyc3QNCj4gb25lLg0KT2sNCj4N
Cj4+ICsgICAgICAgICAqIEluIHRoaXMgY2FzZSBNU0ktWCByZWdpb25zIGFyZSBzdWJ0cmFjdGVk
IGZyb20gdGhlIG1hcHBpbmcsIGJ1dA0KPj4gKyAgICAgICAgICogbWFwLT5zdGFydF9nZm4gc3Rp
bGwgcG9pbnRzIHRvIHRoZSB2ZXJ5IGJlZ2lubmluZyBvZiB0aGUgQkFSLg0KPj4gKyAgICAgICAg
ICogU28gaWYgdGhlcmUgaXMgYSBob2xlIHByZXNlbnQgdGhlbiB3ZSBuZWVkIHRvIGFkanVzdCBz
dGFydF9nZm4NCj4+ICsgICAgICAgICAqIHRvIHJlZmxlY3QgdGhlIGZhY3Qgb2YgdGhhdCBzdWJz
dHJhY3Rpb24uDQo+PiArICAgICAgICAgKi8NCj4+ICsgICAgICAgIHN0YXJ0X2dmbiA9IGdmbl9h
ZGQobWFwLT5zdGFydF9nZm4sIHMgLSBtZm5feChtYXAtPnN0YXJ0X21mbikpOw0KPj4gKw0KPj4g
KyAgICAgICAgcHJpbnRrKFhFTkxPR19HX0RFQlVHDQo+IERvIHlvdSByZWFsbHkgbWVhbiB0aGlz
IHRvIGJlIGFjdGl2ZSBldmVuIGluIHJlbGVhc2UgYnVpbGRzPyBNaWdodCBnZXQNCj4gcXVpdGUg
bm9pc3kgLi4uDQpJIGNhbiBjaGFuZ2UgdGhpcyBvbmUgdG8gImdkcHJpbnRrKFhFTkxPR19HX0RF
QlVHIg0KYW5kIGxlYXZlIHRoZSBiZWxvdyBvbmUgYXMgInByaW50ayhYRU5MT0dfR19XQVJOSU5H
Ig0KT3IgeW91IGFsc28gbWVhbiB0aGUgd2FybmluZyB0byBiZSBnZHByaW50az8NCj4NCj4+ICsg
ICAgICAgICAgICAgICAiJXNtYXAgWyVseCwgJWx4XSAtPiAlIyJQUklfZ2ZuIiBmb3IgZCVkXG4i
LA0KPiAlcGQgcGxlYXNlIGluIG5ldyBvciBhbHRlcmVkIGNvZGUuDQpXaWxsIGNoYW5nZQ0KPg0K
PiBKYW4NCj4NClRoYW5rIHlvdSwNCk9sZWtzYW5kcg==


From xen-devel-bounces@lists.xenproject.org Mon Oct 04 06:42:24 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Oct 2021 06:42:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.201194.355617 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXHfh-0008Vd-VW; Mon, 04 Oct 2021 06:41:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 201194.355617; Mon, 04 Oct 2021 06:41:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXHfh-0008VW-Sd; Mon, 04 Oct 2021 06:41:57 +0000
Received: by outflank-mailman (input) for mailman id 201194;
 Mon, 04 Oct 2021 06:41:56 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mXHfg-0008VP-52
 for xen-devel@lists.xenproject.org; Mon, 04 Oct 2021 06:41:56 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mXHfd-0005Oi-PE; Mon, 04 Oct 2021 06:41:53 +0000
Received: from laubervilliers-658-1-38-51.w217-128.abo.wanadoo.fr
 ([217.128.182.51] helo=[192.168.84.62])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mXHfd-0005KO-FW; Mon, 04 Oct 2021 06:41:53 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=VZzRJ1f0EbcrV3t9fSr9jAh3C0eP9022KE2MRf/+xsY=; b=OOYslnTDL0Ap4MtGfIGQ2KkRw4
	bazfo8m/wcIN842DecSNBPH6gvAVkgnzPN4kL9LRRDS+naI5HbCg6kdl/2MN05J40VayN5o3oPJOf
	sO7DvZ403k92WL0D6UTFXsoSzb5AUtNEEsmt4YPSt2bcG2T4fUcCwyoV3YBDdaiz5CDQ=;
Message-ID: <c0f3969a-5d44-063e-6ab2-f6f5d904901d@xen.org>
Date: Mon, 4 Oct 2021 08:41:49 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.1.2
Subject: Re: [PATCH V4 2/3] xen/arm: Add handling of extended regions for Dom0
To: Stefano Stabellini <sstabellini@kernel.org>,
 Oleksandr Tyshchenko <olekstysh@gmail.com>
Cc: xen-devel@lists.xenproject.org,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Jan Beulich <jbeulich@suse.com>, Wei Liu <wl@xen.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <1632955927-27911-1-git-send-email-olekstysh@gmail.com>
 <1632955927-27911-3-git-send-email-olekstysh@gmail.com>
 <alpine.DEB.2.21.2110011704350.3209@sstabellini-ThinkPad-T480s>
From: Julien Grall <julien@xen.org>
In-Reply-To: <alpine.DEB.2.21.2110011704350.3209@sstabellini-ThinkPad-T480s>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Stefano,

On 02/10/2021 02:33, Stefano Stabellini wrote:
> On Thu, 30 Sep 2021, Oleksandr Tyshchenko wrote:
>> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>>
>> The extended region (safe range) is a region of guest physical
>> address space which is unused and could be safely used to create
>> grant/foreign mappings instead of wasting real RAM pages from
>> the domain memory for establishing these mappings.
>>
>> The extended regions are chosen at the domain creation time and
>> advertised to it via "reg" property under hypervisor node in
>> the guest device-tree. As region 0 is reserved for grant table
>> space (always present), the indexes for extended regions are 1...N.
>> If extended regions could not be allocated for some reason,
>> Xen doesn't fail and behaves as usual, so only inserts region 0.
>>
>> Please note the following limitations:
>> - The extended region feature is only supported for 64-bit domain
>>    currently.
>> - The ACPI case is not covered.
>>
>> ***
>>
>> As Dom0 is direct mapped domain on Arm (e.g. MFN == GFN)
>> the algorithm to choose extended regions for it is different
>> in comparison with the algorithm for non-direct mapped DomU.
>> What is more, that extended regions should be chosen differently
>> whether IOMMU is enabled or not.
>>
>> Provide RAM not assigned to Dom0 if IOMMU is disabled or memory
>> holes found in host device-tree if otherwise. Make sure that
>> extended regions are 2MB-aligned and located within maximum possible
>> addressable physical memory range. The minimum size of extended
>> region is 64MB. The maximum number of extended regions is 128,
>> which is an artificial limit to minimize code changes (we reuse
>> struct meminfo to describe extended regions, so there are an array
>> field for 128 elements).
>>
>> It worth mentioning that unallocated memory solution (when the IOMMU
>> is disabled) will work safely until Dom0 is able to allocate memory
>> outside of the original range.
>>
>> Also introduce command line option to be able to globally enable or
>> disable support for extended regions for Dom0 (enabled by default).
>>
>> Suggested-by: Julien Grall <jgrall@amazon.com>
>> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> 
> I thought about it and I decided to commit this patch because it doesn't
> actually need anything from the other two patches, and it is very useful
> on its own (both of them are for domU, while this one is for dom0).
> 
> In regards to Julien's suggestion: as explained in earlier emails I
> prefer this version but I don't have a strong opinion. If Julien still
> prefers the other approach we can still change it in time for 4.16
> (Oleksandr has already implemented both and I am happy to review.)

Lets keep the committed approach for the 4.16. This is not something we 
tie into the ABI so it can be modified later on if we find some issues 
(i.e. more and more ranges to exclude).

However, I would still like to see some changes on top of this patch for 
4.16 (will comment separately).

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Mon Oct 04 06:59:45 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Oct 2021 06:59:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.201219.355646 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXHwj-0002e6-UL; Mon, 04 Oct 2021 06:59:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 201219.355646; Mon, 04 Oct 2021 06:59:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXHwj-0002dz-RI; Mon, 04 Oct 2021 06:59:33 +0000
Received: by outflank-mailman (input) for mailman id 201219;
 Mon, 04 Oct 2021 06:59:32 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mXHwi-0002dp-OF
 for xen-devel@lists.xenproject.org; Mon, 04 Oct 2021 06:59:32 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mXHwh-0005gc-10; Mon, 04 Oct 2021 06:59:31 +0000
Received: from laubervilliers-658-1-38-51.w217-128.abo.wanadoo.fr
 ([217.128.182.51] helo=[192.168.84.62])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mXHwg-0006RE-Ip; Mon, 04 Oct 2021 06:59:30 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=elwgOqd3+lRP4tNYx8iXy3UajTcx1WFUT1QsQk1sKK0=; b=jmkUu5rMvALr2fx492IDN8TKtu
	lOoOYW5Bnoc/fAJAIWE6oXvl5/hDjbYglinWTyStuaTScFPfdebIJRIcKJ1cdFeaX8ia1/3N9fIBV
	aT3a/0/5Xuq3mIKHhxZZDibGTIeTo2p5UEx96JRqJgE7DxQ6cIRKiVXB479cdagx9zr0=;
Message-ID: <8318a7b0-80fa-ccd6-75c5-c3135b82235d@xen.org>
Date: Mon, 4 Oct 2021 08:59:27 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.1.2
Subject: Re: [PATCH V4 2/3] xen/arm: Add handling of extended regions for Dom0
To: Oleksandr Tyshchenko <olekstysh@gmail.com>, xen-devel@lists.xenproject.org
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Jan Beulich <jbeulich@suse.com>, Stefano Stabellini
 <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <1632955927-27911-1-git-send-email-olekstysh@gmail.com>
 <1632955927-27911-3-git-send-email-olekstysh@gmail.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <1632955927-27911-3-git-send-email-olekstysh@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Oleksandr,

I saw Stefano committed this patch on Friday. However, I didn't have a 
chance go to through a second time and would like to request some 
follow-up changes.

On 30/09/2021 00:52, Oleksandr Tyshchenko wrote:
> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> 
> The extended region (safe range) is a region of guest physical
> address space which is unused and could be safely used to create
> grant/foreign mappings instead of wasting real RAM pages from
> the domain memory for establishing these mappings.
> 
> The extended regions are chosen at the domain creation time and
> advertised to it via "reg" property under hypervisor node in
> the guest device-tree. As region 0 is reserved for grant table
> space (always present), the indexes for extended regions are 1...N.
> If extended regions could not be allocated for some reason,
> Xen doesn't fail and behaves as usual, so only inserts region 0.
> 
> Please note the following limitations:
> - The extended region feature is only supported for 64-bit domain
>    currently.
> - The ACPI case is not covered.
> 
> ***
> 
> As Dom0 is direct mapped domain on Arm (e.g. MFN == GFN)
> the algorithm to choose extended regions for it is different
> in comparison with the algorithm for non-direct mapped DomU.
> What is more, that extended regions should be chosen differently
> whether IOMMU is enabled or not.
> 
> Provide RAM not assigned to Dom0 if IOMMU is disabled or memory
> holes found in host device-tree if otherwise. Make sure that
> extended regions are 2MB-aligned and located within maximum possible
> addressable physical memory range. The minimum size of extended
> region is 64MB. 

You explained below why the 128 limits, but I don't see any explanation 
on why 2MB and 64MB.

IIRC, 2MB was to potentally allow superpage mapping. I am not entirely 
sure for 64MB.

Could you add an in-code comment explaining the two limits?

> The maximum number of extended regions is 128,
> which is an artificial limit to minimize code changes (we reuse
> struct meminfo to describe extended regions, so there are an array
> field for 128 elements).
> 
> It worth mentioning that unallocated memory solution (when the IOMMU
> is disabled) will work safely until Dom0 is able to allocate memory
> outside of the original range.
> 
> Also introduce command line option to be able to globally enable or
> disable support for extended regions for Dom0 (enabled by default).
> 
> Suggested-by: Julien Grall <jgrall@amazon.com>
> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> ---
> Please note, we need to decide which approach to use in find_unallocated_memory(),
> you can find details at:
> https://lore.kernel.org/xen-devel/28503e09-44c3-f623-bb8d-8778bb94225f@gmail.com/
> 
> Changes RFC -> V2:
>     - update patch description
>     - drop uneeded "extended-region" DT property
> 
> Changes V2 -> V3:
>     - update patch description
>     - add comment for "size" calculation in add_ext_regions()
>     - clarify "end" calculation in find_unallocated_memory() and
>       find_memory_holes()
>     - only pick up regions with size >= 64MB
>     - allocate reg dynamically instead of keeping on the stack in
>       make_hypervisor_node()
>     - do not show warning for 32-bit domain
>     - drop Linux specific limits EXT_REGION_*
>     - also cover "ranges" property in find_memory_holes()
>     - add command line arg to enable/disable extended region support
> 
> Changes V3 -> V4:
>    - update opt_ext_regions purpose and comment in code
>    - reorganize make_hypervisor_node() to move allocations after initial
>      checks, allocate only required amount of elements instead of maximum
>      possible
> ---
>   docs/misc/xen-command-line.pandoc |  11 ++
>   xen/arch/arm/domain_build.c       | 286 +++++++++++++++++++++++++++++++++++++-

The document in docs/misc/arm/device-tree/guest.txt needs to be updated 
to reflect the change in the binding.

>   2 files changed, 294 insertions(+), 3 deletions(-)
> 
> diff --git a/docs/misc/xen-command-line.pandoc b/docs/misc/xen-command-line.pandoc
> index 177e656..5cae4ad 100644
> --- a/docs/misc/xen-command-line.pandoc
> +++ b/docs/misc/xen-command-line.pandoc
> @@ -1081,6 +1081,17 @@ hardware domain is architecture dependent.
>   Note that specifying zero as domU value means zero, while for dom0 it means
>   to use the default.
>   
> +### ext_regions (Arm)
> +> `= <boolean>`
> +
> +> Default : `true`
> +
> +Flag to enable or disable support for extended regions for Dom0.
> +
> +Extended regions are ranges of unused address space exposed to Dom0 as
> +"safe to use" for special memory mappings. Disable if your board device
> +tree is incomplete.
> +
>   ### flask
>   > `= permissive | enforcing | late | disabled`
>   
> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
> index d233d63..c5afbe2 100644
> --- a/xen/arch/arm/domain_build.c
> +++ b/xen/arch/arm/domain_build.c
> @@ -34,6 +34,10 @@
>   static unsigned int __initdata opt_dom0_max_vcpus;
>   integer_param("dom0_max_vcpus", opt_dom0_max_vcpus);
>   
> +/* If true, the extended regions support is enabled for dom0 */
> +static bool __initdata opt_ext_regions = true;
> +boolean_param("ext_regions", opt_ext_regions);
> +
>   static u64 __initdata dom0_mem;
>   static bool __initdata dom0_mem_set;
>   
> @@ -886,6 +890,232 @@ static int __init make_memory_node(const struct domain *d,
>       return res;
>   }
>   
> +static int __init add_ext_regions(unsigned long s, unsigned long e, void *data)
> +{
> +    struct meminfo *ext_regions = data;
> +    paddr_t start, size;
> +
> +    if ( ext_regions->nr_banks >= ARRAY_SIZE(ext_regions->bank) )
> +        return 0;
> +
> +    /* Both start and size of the extended region should be 2MB aligned */
> +    start = (s + SZ_2M - 1) & ~(SZ_2M - 1);
> +    if ( start > e )
> +        return 0;
> +
> +    /*
> +     * e is actually "end-1" because it is called by rangeset functions
> +     * which are inclusive of the last address.
> +     */
> +    e += 1;
> +    size = (e - start) & ~(SZ_2M - 1);
> +    if ( size < MB(64) )
> +        return 0;
> +
> +    ext_regions->bank[ext_regions->nr_banks].start = start;
> +    ext_regions->bank[ext_regions->nr_banks].size = size;
> +    ext_regions->nr_banks++;
> +
> +    return 0;
> +}
> +
> +static int __init find_unallocated_memory(const struct kernel_info *kinfo,
> +                                          struct meminfo *ext_regions)

It would be good to have a comment on top of this function summarizing 
how this is meant to work.

> +{
> +    const struct meminfo *assign_mem = &kinfo->mem;
> +    struct rangeset *unalloc_mem;
> +    paddr_t start, end;
> +    unsigned int i;
> +    int res;
> +
> +    dt_dprintk("Find unallocated memory for extended regions\n");
> +
> +    unalloc_mem = rangeset_new(NULL, NULL, 0);
> +    if ( !unalloc_mem )
> +        return -ENOMEM;
> +
> +    /* Start with all available RAM */
> +    for ( i = 0; i < bootinfo.mem.nr_banks; i++ )
> +    {
> +        start = bootinfo.mem.bank[i].start;
> +        end = bootinfo.mem.bank[i].start + bootinfo.mem.bank[i].size;
> +        res = rangeset_add_range(unalloc_mem, start, end - 1);
> +        if ( res )
> +        {
> +            printk(XENLOG_ERR "Failed to add: %#"PRIx64"->%#"PRIx64"\n",

start and end are paddr_t. So you want to use PRIpaddr rather than PRIx64.

> +                   start, end);
> +            goto out;
> +        }
> +    }
> +
> +    /* Remove RAM assigned to Dom0 */
> +    for ( i = 0; i < assign_mem->nr_banks; i++ )
> +    {
> +        start = assign_mem->bank[i].start;
> +        end = assign_mem->bank[i].start + assign_mem->bank[i].size;
> +        res = rangeset_remove_range(unalloc_mem, start, end - 1);
> +        if ( res )
> +        {
> +            printk(XENLOG_ERR "Failed to remove: %#"PRIx64"->%#"PRIx64"\n",

Ditto.

> +                   start, end);
> +            goto out;
> +        }
> +    }
> +
> +    /* Remove reserved-memory regions */
> +    for ( i = 0; i < bootinfo.reserved_mem.nr_banks; i++ )
> +    {
> +        start = bootinfo.reserved_mem.bank[i].start;
> +        end = bootinfo.reserved_mem.bank[i].start +
> +            bootinfo.reserved_mem.bank[i].size;
> +        res = rangeset_remove_range(unalloc_mem, start, end - 1);
> +        if ( res )
> +        {
> +            printk(XENLOG_ERR "Failed to remove: %#"PRIx64"->%#"PRIx64"\n",

Ditto.

> +                   start, end);
> +            goto out;
> +        }
> +    }
> +
> +    /* Remove grant table region */
> +    start = kinfo->gnttab_start;
> +    end = kinfo->gnttab_start + kinfo->gnttab_size;
> +    res = rangeset_remove_range(unalloc_mem, start, end - 1);
> +    if ( res )
> +    {
> +        printk(XENLOG_ERR "Failed to remove: %#"PRIx64"->%#"PRIx64"\n",

ditto.

> +               start, end);
> +        goto out;
> +    }
> +
> +    start = 0;
> +    end = (1ULL << p2m_ipa_bits) - 1;
> +    res = rangeset_report_ranges(unalloc_mem, start, end,
> +                                 add_ext_regions, ext_regions);
> +    if ( res )
> +        ext_regions->nr_banks = 0;
> +    else if ( !ext_regions->nr_banks )
> +        res = -ENOENT;
> +
> +out:
> +    rangeset_destroy(unalloc_mem);
> +
> +    return res;
> +}
> +
> +static int __init find_memory_holes(const struct kernel_info *kinfo,
> +                                    struct meminfo *ext_regions)

I think it would be good to have a comment on top of the function how 
this is meant to work.

> +{
> +    struct dt_device_node *np;
> +    struct rangeset *mem_holes;
> +    paddr_t start, end;
> +    unsigned int i;
> +    int res;
> +
> +    dt_dprintk("Find memory holes for extended regions\n");
> +
> +    mem_holes = rangeset_new(NULL, NULL, 0);
> +    if ( !mem_holes )
> +        return -ENOMEM;
> +
> +    /* Start with maximum possible addressable physical memory range */
> +    start = 0;
> +    end = (1ULL << p2m_ipa_bits) - 1;
> +    res = rangeset_add_range(mem_holes, start, end);
> +    if ( res )
> +    {
> +        printk(XENLOG_ERR "Failed to add: %#"PRIx64"->%#"PRIx64"\n",

Please use PRIpaddr.

> +               start, end);
> +        goto out;
> +    }
> +
> +    /*
> +     * Remove regions described by "reg" and "ranges" properties where
> +     * the memory is addressable (MMIO, RAM, PCI BAR, etc).
> +     */
> +    dt_for_each_device_node( dt_host, np )
> +    {
> +        unsigned int naddr;
> +        u64 addr, size;
> +
> +        naddr = dt_number_of_address(np);
> +
> +        for ( i = 0; i < naddr; i++ )
> +        {
> +            res = dt_device_get_address(np, i, &addr, &size);
> +            if ( res )
> +            {
> +                printk(XENLOG_ERR "Unable to retrieve address %u for %s\n",
> +                       i, dt_node_full_name(np));
> +                goto out;
> +            }
> +
> +            start = addr & PAGE_MASK;
> +            end = PAGE_ALIGN(addr + size);
> +            res = rangeset_remove_range(mem_holes, start, end - 1);
> +            if ( res )
> +            {
> +                printk(XENLOG_ERR "Failed to remove: %#"PRIx64"->%#"PRIx64"\n",
> +                       start, end);
> +                goto out;
> +            }
> +        }
> +
> +        if ( dt_device_type_is_equal(np, "pci" ) )
> +        {

The code below looks like an open-coding version of dt_for_each_range(). 
Can you try to re-use it please? This will help to reduce the complexity 
of this function.

> +            unsigned int range_size, nr_ranges;
> +            int na, ns, pna;
> +            const __be32 *ranges;
> +            u32 len;
> +
> +            /*
> +             * Looking for non-empty ranges property which in this context
> +             * describes the PCI host bridge aperture.
> +             */
> +            ranges = dt_get_property(np, "ranges", &len);
> +            if ( !ranges || !len )
> +                continue;
> +
> +            pna = dt_n_addr_cells(np);
> +            na = dt_child_n_addr_cells(np);
> +            ns = dt_child_n_size_cells(np);
> +            range_size = pna + na + ns;
> +            nr_ranges = len / sizeof(__be32) / range_size;
> +
> +            for ( i = 0; i < nr_ranges; i++, ranges += range_size )
> +            {
> +                /* Skip the child address and get the parent (CPU) address */
> +                addr = dt_read_number(ranges + na, pna);
> +                size = dt_read_number(ranges + na + pna, ns);
> +
> +                start = addr & PAGE_MASK;
> +                end = PAGE_ALIGN(addr + size);
> +                res = rangeset_remove_range(mem_holes, start, end - 1);
> +                if ( res )
> +                {
> +                    printk(XENLOG_ERR "Failed to remove: %#"PRIx64"->%#"PRIx64"\n",

This should be PRIpaddr.

> +                           start, end);
> +                    goto out;
> +                }
> +            }
> +        }
> +    }
> +
> +    start = 0;
> +    end = (1ULL << p2m_ipa_bits) - 1;
> +    res = rangeset_report_ranges(mem_holes, start, end,
> +                                 add_ext_regions,  ext_regions);
> +    if ( res )
> +        ext_regions->nr_banks = 0;
> +    else if ( !ext_regions->nr_banks )
> +        res = -ENOENT;
> +
> +out:
> +    rangeset_destroy(mem_holes);
> +
> +    return res;
> +}
> +
>   static int __init make_hypervisor_node(struct domain *d,
>                                          const struct kernel_info *kinfo,
>                                          int addrcells, int sizecells)
> @@ -893,11 +1123,12 @@ static int __init make_hypervisor_node(struct domain *d,
>       const char compat[] =
>           "xen,xen-"__stringify(XEN_VERSION)"."__stringify(XEN_SUBVERSION)"\0"
>           "xen,xen";
> -    __be32 reg[4];
> +    __be32 *reg, *cells;
>       gic_interrupt_t intr;
> -    __be32 *cells;
>       int res;
>       void *fdt = kinfo->fdt;
> +    struct meminfo *ext_regions = NULL;
> +    unsigned int i, nr_ext_regions;
>   
>       dt_dprintk("Create hypervisor node\n");
>   
> @@ -919,12 +1150,61 @@ static int __init make_hypervisor_node(struct domain *d,
>       if ( res )
>           return res;
>   
> +    if ( !opt_ext_regions )
> +    {
> +        printk(XENLOG_DEBUG "The extended regions support is disabled\n");

The extended regions is going to be critical for the performance in 
dom0. So I think this at least want to be a XENLOG_INFO.

> +        nr_ext_regions = 0;
> +    }
> +    else if ( is_32bit_domain(d) )
> +    {
> +        printk(XENLOG_DEBUG "The extended regions are only supported for 64-bit guest currently\n");

This would want to be use XENLOG_WARN.

> +        nr_ext_regions = 0;
> +    }
> +    else
> +    {
> +        ext_regions = xzalloc(struct meminfo);
> +        if ( !ext_regions )
> +            return -ENOMEM;
> +
> +        if ( !is_iommu_enabled(d) )
> +            res = find_unallocated_memory(kinfo, ext_regions);
> +        else
> +            res = find_memory_holes(kinfo, ext_regions);
> +
> +        if ( res )
> +            printk(XENLOG_WARNING "Failed to allocate extended regions\n");
> +        nr_ext_regions = ext_regions->nr_banks;
> +    }
> +
> +    reg = xzalloc_array(__be32, (nr_ext_regions + 1) * (addrcells + sizecells));
> +    if ( !reg )
> +    {
> +        xfree(ext_regions);
> +        return -ENOMEM;
> +    }
> +
>       /* reg 0 is grant table space */
>       cells = &reg[0];
>       dt_child_set_range(&cells, addrcells, sizecells,
>                          kinfo->gnttab_start, kinfo->gnttab_size);
> +    /* reg 1...N are extended regions */
> +    for ( i = 0; i < nr_ext_regions; i++ )
> +    {
> +        u64 start = ext_regions->bank[i].start;
> +        u64 size = ext_regions->bank[i].size;
> +
> +        dt_dprintk("Extended region %d: %#"PRIx64"->%#"PRIx64"\n",
> +                   i, start, start + size);

I would prefer if this is a printk() so we get the extended region 
listed from the beginning.

> +
> +        dt_child_set_range(&cells, addrcells, sizecells, start, size);
> +    }
> +
>       res = fdt_property(fdt, "reg", reg,
> -                       dt_cells_to_size(addrcells + sizecells));
> +                       dt_cells_to_size(addrcells + sizecells) *
> +                       (nr_ext_regions + 1));
> +    xfree(ext_regions);
> +    xfree(reg);
> +
>       if ( res )
>           return res;
>   
> 

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Mon Oct 04 09:14:45 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Oct 2021 09:14:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.201234.355657 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXK3G-0007Pt-Pa; Mon, 04 Oct 2021 09:14:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 201234.355657; Mon, 04 Oct 2021 09:14:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXK3G-0007Pm-LK; Mon, 04 Oct 2021 09:14:26 +0000
Received: by outflank-mailman (input) for mailman id 201234;
 Mon, 04 Oct 2021 09:14:25 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=VfnQ=OY=invisiblethingslab.com=marmarek@srs-us1.protection.inumbo.net>)
 id 1mXK3F-0007Pg-4B
 for xen-devel@lists.xenproject.org; Mon, 04 Oct 2021 09:14:25 +0000
Received: from out2-smtp.messagingengine.com (unknown [66.111.4.26])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 773c1766-24f3-11ec-bea7-12813bfff9fa;
 Mon, 04 Oct 2021 09:14:23 +0000 (UTC)
Received: from compute3.internal (compute3.nyi.internal [10.202.2.43])
 by mailout.nyi.internal (Postfix) with ESMTP id 9CBD05C00DF;
 Mon,  4 Oct 2021 05:14:23 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
 by compute3.internal (MEProxy); Mon, 04 Oct 2021 05:14:23 -0400
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon,
 4 Oct 2021 05:14:22 -0400 (EDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 773c1766-24f3-11ec-bea7-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:content-type:date:from:in-reply-to
	:message-id:mime-version:references:subject:to:x-me-proxy
	:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=FsTLAS
	qaOF28jU4O+Te0Kc4zpL99ewTaWCNEN3wKHR4=; b=P13CN9LJGdcQVK/cjUo298
	Z87hHI2kb3MWrgorjfF21xJSIiHb5SNTWCc5PKoWBdCZ/GjdjKEpjL3KwFTr6Orx
	M36JGjRq1WvoH/83g1bisIpRaLho50BclkOKHg7RoLu2pGRVEYeiV3IsbYVo3m9j
	L4HqLrVmGcmNRdc+xFXZQhnY4KdwRq6+36USYd/9Ud/yrdeO4vJSuDrAtp4TrWut
	3DUaGjyK1n9BsH8yr1dMeMX3i09d9x6Lkc6z1NopCO32RimDPaslivaI837ipz42
	yITd6ehfE47wpFNYhOg9M4GK/sHVa5NakP8Ty2wyiQ1tmeYj1d4kQVGfixSW5kyg
	==
X-ME-Sender: <xms:78VaYc3ByFQEtMQiBJoymjSiSjzW2jjsYtNagbPMG-ezekwsrazkIw>
    <xme:78VaYXHOii4INI7VUFxiz_N9QvQ936uz8O_gx56N5jIe4osrGeb4IZB4mrMwMO2ub
    9nSo09GODwYIg>
X-ME-Received: <xmr:78VaYU7EH8wvAt5B0Z3v8w5LQS6QUR4R-5GrqWMKq1umcOt48zRT5jz4l9k37qlOBQi7TLygSz9HEf5cdYZf-24K7zgdoyHs>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrudelvddgudduucetufdoteggodetrfdotf
    fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
    uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
    cujfgurhepfffhvffukfhfgggtuggjsehgtderredttdejnecuhfhrohhmpeforghrvghk
    ucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesihhnvh
    hishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpeetveff
    iefghfekhffggeeffffhgeevieektedthfehveeiheeiiedtudegfeetffenucevlhhush
    htvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrghrmhgrrhgvkhes
    ihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm
X-ME-Proxy: <xmx:78VaYV0VsFQPRHCyQqH3UOVenzfIucuRRN3sQvis5eKhEaNOKDFCug>
    <xmx:78VaYfFqKtZATjjyVGfdZ2aTSQnd1eEj8_CMM3_XiK9re6nF8LO0cg>
    <xmx:78VaYe-qNmEDO00E0riRd_odCVQIzDwTBhYpjOiTJLsM5n1WUwKWlA>
    <xmx:78VaYSPdlwT0nbwLnlOrKiE0GJbH66NhlFAW46bZAGCIcS-M-00KdA>
Date: Mon, 4 Oct 2021 11:14:18 +0200
From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
To: Juergen Gross <jgross@suse.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>,
	Jan Beulich <jbeulich@suse.com>
Subject: Re: xen-balloon thread using 100% of CPU, regression in 5.4.150
Message-ID: <YVrF65BAVsXTgRsd@mail-itl>
References: <YVk11h2l/u4GJNv0@mail-itl>
 <37c22c61-80be-fc48-18e6-2b1ee22cc765@suse.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="m5hzGpkATQskl05r"
Content-Disposition: inline
In-Reply-To: <37c22c61-80be-fc48-18e6-2b1ee22cc765@suse.com>


--m5hzGpkATQskl05r
Content-Type: text/plain; protected-headers=v1; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Date: Mon, 4 Oct 2021 11:14:18 +0200
From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
To: Juergen Gross <jgross@suse.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>,
	Jan Beulich <jbeulich@suse.com>
Subject: Re: xen-balloon thread using 100% of CPU, regression in 5.4.150

On Mon, Oct 04, 2021 at 07:31:40AM +0200, Juergen Gross wrote:
> On 03.10.21 06:47, Marek Marczykowski-G=C3=B3recki wrote:
> > Hi,
> >=20
> > After updating a PVH domU to 5.4.150, I see xen-balloon thread using
> > 100% CPU (one thread).
> > This is a domain started with memory=3Dmaxmem=3D716800KiB (via libvirt)=
=2E Then,
> > inside, I see:
> >=20
> > # cat /sys/devices/system/xen_memory/xen_memory0/target_kb
> > 716924
> > # cat /sys/devices/system/xen_memory/xen_memory0/info/current_kb
> > 716400
> >=20
> > Doing `cat info/current_kb > target_kb` "fixes" the issue. But still,
> > something is wrong - on earlier kernel (5.4.143 to be precise), it
> > wasn't spinning, with exactly the same values reported in sysfs. It
> > shouldn't run in circles if it can't get that much memory it wants. I
> > strongly suspect "xen/balloon: use a kernel thread instead a workqueue"
> > or related commit being responsible, but I haven't verified it.
>=20
> I think you are right. I need to handle the BP_ECANCELED case similar to
> BP_EAGAIN in the kernel thread (wait until target size changes again).
>=20
> One further question: do you see any kernel message in the guest related
> to the looping balloon thread?

Nothing, only the usual "xen:balloon: Initialising balloon driver", and
nothing related to balloon after that.


--=20
Best Regards,
Marek Marczykowski-G=C3=B3recki
Invisible Things Lab

--m5hzGpkATQskl05r
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmFaxeoACgkQ24/THMrX
1yyblQgAmTE2UvnLHp+i61/5OwVDq7bcGnN8XmESmfNa3uTZzmBM/MXsb3T9QPHj
fcYlak+NOnufpv0qFWaJj/cbworXembown0ZKboAEbIQu33CjMkXAAl2gwUhf03h
QBMkkvibOMiYhwElqzUKWY8mwVACYypFwoWReYgSJXI7LJr2tn+19byXDCC3h0VB
Wp2SXPAiqOe7Re93YCmfJrcgny7wrvx0WXjHttFD8hXnEBUUSdNKqoMeP/wSGZQb
DOdfkMxcoNdJNZqxbtqEx09KaUBUhJYktN8jLClsIfTKLcLojHgqt6M16i2Ii52Z
CLF/+mV8xZahy97LqbsIwlD/RRcQlQ==
=nbaV
-----END PGP SIGNATURE-----

--m5hzGpkATQskl05r--


From xen-devel-bounces@lists.xenproject.org Mon Oct 04 09:40:22 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Oct 2021 09:40:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.201244.355671 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXKS6-000272-QP; Mon, 04 Oct 2021 09:40:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 201244.355671; Mon, 04 Oct 2021 09:40:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXKS6-00026v-NS; Mon, 04 Oct 2021 09:40:06 +0000
Received: by outflank-mailman (input) for mailman id 201244;
 Mon, 04 Oct 2021 09:40:05 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=7SE7=OY=suse.com=jgross@srs-us1.protection.inumbo.net>)
 id 1mXKS5-00024g-IZ
 for xen-devel@lists.xenproject.org; Mon, 04 Oct 2021 09:40:05 +0000
Received: from smtp-out2.suse.de (unknown [195.135.220.29])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 0c309f9c-24f7-11ec-bea7-12813bfff9fa;
 Mon, 04 Oct 2021 09:40:02 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id CADA62019A;
 Mon,  4 Oct 2021 09:40:01 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 9787A13A13;
 Mon,  4 Oct 2021 09:40:01 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id /oXMI/HLWmG5RAAAMHmgww
 (envelope-from <jgross@suse.com>); Mon, 04 Oct 2021 09:40:01 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0c309f9c-24f7-11ec-bea7-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1633340401; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:  content-transfer-encoding:content-transfer-encoding;
	bh=2fFPIPlC+atciMa/6CO3r585X3XUQbQXFh8lKdi63pg=;
	b=fl0U3dzb+07pemGi4N7J3gF5T+LVvmLKYcoGqCxtVVtGrYkT7V6oTkEyIcz1mH1CxsLooO
	0JG7aiedEVgf9JI6KPA/IY19M1Q9O8l7xrUI/tESKvw5rP8rYFWKzp4umKyo8MjDl9P05k
	DGouRhytjCBn19afksaVzJBTnXNaz+Y=
From: Juergen Gross <jgross@suse.com>
To: minios-devel@lists.xenproject.org,
	xen-devel@lists.xenproject.org
Cc: samuel.thibault@ens-lyon.org,
	wl@xen.org,
	Juergen Gross <jgross@suse.com>
Subject: [PATCH v4] xenbus: support large messages
Date: Mon,  4 Oct 2021 11:40:00 +0200
Message-Id: <20211004094000.29868-1-jgross@suse.com>
X-Mailer: git-send-email 2.26.2
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Today the implementation of the xenbus protocol in Mini-OS will only
allow to transfer the complete message to or from the ring page buffer.
This is limiting the maximum message size to lower values as the xenbus
protocol normally would allow.

Change that by allowing to transfer the xenbus message in chunks as
soon as they are available.

Avoid crashing Mini-OS in case of illegal data read from the ring
buffer.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
V2:
- drop redundant if (Samuel Thibault)
- move rmb() (Samuel Thibault)
V3:
- correct notification test (Samuel Thibault)
V4:
- more memory barriers (Samuel Thibault)
---
 xenbus/xenbus.c | 210 ++++++++++++++++++++++++++++--------------------
 1 file changed, 122 insertions(+), 88 deletions(-)

diff --git a/xenbus/xenbus.c b/xenbus/xenbus.c
index 23de61e..b687678 100644
--- a/xenbus/xenbus.c
+++ b/xenbus/xenbus.c
@@ -29,6 +29,7 @@
 #include <xen/hvm/params.h>
 #include <mini-os/spinlock.h>
 #include <mini-os/xmalloc.h>
+#include <mini-os/semaphore.h>
 
 #define min(x,y) ({                       \
         typeof(x) tmpx = (x);                 \
@@ -46,6 +47,7 @@
 static struct xenstore_domain_interface *xenstore_buf;
 static DECLARE_WAIT_QUEUE_HEAD(xb_waitq);
 DECLARE_WAIT_QUEUE_HEAD(xenbus_watch_queue);
+static __DECLARE_SEMAPHORE_GENERIC(xb_write_sem, 1);
 
 xenbus_event_queue xenbus_events;
 static struct watch {
@@ -231,75 +233,103 @@ char *xenbus_wait_for_state_change(const char* path, XenbusState *state, xenbus_
 }
 
 
+static void xenbus_read_data(char *buf, unsigned int len)
+{
+    unsigned int off = 0;
+    unsigned int prod, cons;
+    unsigned int size;
+
+    while (off != len)
+    {
+        wait_event(xb_waitq, xenstore_buf->rsp_prod != xenstore_buf->rsp_cons);
+
+        prod = xenstore_buf->rsp_prod;
+        cons = xenstore_buf->rsp_cons;
+        DEBUG("Rsp_cons %d, rsp_prod %d.\n", cons, prod);
+        size = min(len - off, prod - cons);
+
+        rmb();   /* Make sure data read from ring is ordered with rsp_prod. */
+        memcpy_from_ring(xenstore_buf->rsp, buf + off,
+                         MASK_XENSTORE_IDX(cons), size);
+        off += size;
+        mb();    /* memcpy() and rsp_cons update must not be reordered. */
+        xenstore_buf->rsp_cons += size;
+        mb();    /* rsp_cons must be visible before we look at rsp_prod. */
+        if (xenstore_buf->rsp_prod - cons >= XENSTORE_RING_SIZE)
+            notify_remote_via_evtchn(xenbus_evtchn);
+    }
+}
+
 static void xenbus_thread_func(void *ign)
 {
     struct xsd_sockmsg msg;
-    unsigned prod = xenstore_buf->rsp_prod;
+    char *data;
 
     for (;;) {
-        wait_event(xb_waitq, prod != xenstore_buf->rsp_prod);
-        while (1) {
-            prod = xenstore_buf->rsp_prod;
-            DEBUG("Rsp_cons %d, rsp_prod %d.\n", xenstore_buf->rsp_cons,
-                  xenstore_buf->rsp_prod);
-            if (xenstore_buf->rsp_prod - xenstore_buf->rsp_cons < sizeof(msg))
-                break;
-            rmb();
-            memcpy_from_ring(xenstore_buf->rsp, &msg,
-                             MASK_XENSTORE_IDX(xenstore_buf->rsp_cons),
-                             sizeof(msg));
-            DEBUG("Msg len %d, %d avail, id %d.\n", msg.len + sizeof(msg),
-                  xenstore_buf->rsp_prod - xenstore_buf->rsp_cons, msg.req_id);
-
-            if (xenstore_buf->rsp_prod - xenstore_buf->rsp_cons <
-                sizeof(msg) + msg.len)
-                break;
-
-            DEBUG("Message is good.\n");
-
-            if (msg.type == XS_WATCH_EVENT) {
-                struct xenbus_event *event = malloc(sizeof(*event) + msg.len);
-                xenbus_event_queue *events = NULL;
-                char *data = (char*)event + sizeof(*event);
-                struct watch *watch;
-
-                memcpy_from_ring(xenstore_buf->rsp, data,
-                    MASK_XENSTORE_IDX(xenstore_buf->rsp_cons + sizeof(msg)),
-                    msg.len);
-
-                event->path = data;
-                event->token = event->path + strlen(event->path) + 1;
-
-                mb();
-                xenstore_buf->rsp_cons += msg.len + sizeof(msg);
-
-                for (watch = watches; watch; watch = watch->next)
-                    if (!strcmp(watch->token, event->token)) {
-                        events = watch->events;
-                        break;
-                    }
-
-                if (events) {
-                    event->next = *events;
-                    *events = event;
-                    wake_up(&xenbus_watch_queue);
-                } else {
-                    printk("unexpected watch token %s\n", event->token);
-                    free(event);
+        xenbus_read_data((char *)&msg, sizeof(msg));
+        DEBUG("Msg len %d, %d avail, id %d.\n", msg.len + sizeof(msg),
+              xenstore_buf->rsp_prod - xenstore_buf->rsp_cons, msg.req_id);
+
+        if (msg.len > XENSTORE_PAYLOAD_MAX) {
+            printk("Xenstore violates protocol, message longer than allowed.\n");
+            return;
+        }
+
+        if (msg.type == XS_WATCH_EVENT) {
+            struct xenbus_event *event = malloc(sizeof(*event) + msg.len);
+            xenbus_event_queue *events = NULL;
+            struct watch *watch;
+            char *c;
+            int zeroes = 0;
+
+            data = (char*)event + sizeof(*event);
+            xenbus_read_data(data, msg.len);
+
+            for (c = data; c < data + msg.len; c++)
+                if (!*c)
+                    zeroes++;
+            if (zeroes != 2) {
+                printk("Xenstore: illegal watch event data\n");
+                free(event);
+                continue;
+            }
+
+            event->path = data;
+            event->token = event->path + strlen(event->path) + 1;
+
+            for (watch = watches; watch; watch = watch->next)
+                if (!strcmp(watch->token, event->token)) {
+                    events = watch->events;
+                    break;
                 }
+
+            if (events) {
+                event->next = *events;
+                *events = event;
+                wake_up(&xenbus_watch_queue);
             } else {
-                req_info[msg.req_id].reply = malloc(sizeof(msg) + msg.len);
-                memcpy_from_ring(xenstore_buf->rsp, req_info[msg.req_id].reply,
-                                 MASK_XENSTORE_IDX(xenstore_buf->rsp_cons),
-                                 msg.len + sizeof(msg));
-                mb();
-                xenstore_buf->rsp_cons += msg.len + sizeof(msg);
-                wake_up(&req_info[msg.req_id].waitq);
+                printk("Xenstore: unexpected watch token %s\n", event->token);
+                free(event);
             }
 
-            wmb();
-            notify_remote_via_evtchn(xenbus_evtchn);
+            continue;
         }
+
+        data = malloc(sizeof(msg) + msg.len);
+        memcpy(data, &msg, sizeof(msg));
+        xenbus_read_data(data + sizeof(msg), msg.len);
+
+        if (msg.req_id >= NR_REQS || !req_info[msg.req_id].in_use) {
+            printk("Xenstore: illegal request id %d\n", msg.req_id);
+            free(data);
+            continue;
+        }
+
+        DEBUG("Message is good.\n");
+
+        req_info[msg.req_id].reply = data;
+
+        wake_up(&req_info[msg.req_id].waitq);
     }
 }
 
@@ -451,36 +481,40 @@ static void xb_write(int type, int req_id, xenbus_transaction_t trans_id,
 
     cur_req = &header_req;
 
-    BUG_ON(len > XENSTORE_RING_SIZE);
-    /* Wait for the ring to drain to the point where we can send the
-       message. */
-    prod = xenstore_buf->req_prod;
-    if (prod + len - xenstore_buf->req_cons > XENSTORE_RING_SIZE) 
-    {
-        /* Wait for there to be space on the ring */
-        DEBUG("prod %d, len %d, cons %d, size %d; waiting.\n",
-                prod, len, xenstore_buf->req_cons, XENSTORE_RING_SIZE);
-        wait_event(xb_waitq,
-                xenstore_buf->req_prod + len - xenstore_buf->req_cons <=
-                XENSTORE_RING_SIZE);
-        DEBUG("Back from wait.\n");
-        prod = xenstore_buf->req_prod;
-    }
+    BUG_ON(len > XENSTORE_PAYLOAD_MAX);
+
+    /* Make sure we are the only thread trying to write. */
+    down(&xb_write_sem);
 
-    /* We're now guaranteed to be able to send the message without
-       overflowing the ring.  Do so. */
+    /* Send the message in chunks using free ring space when available. */
     total_off = 0;
     req_off = 0;
-    while (total_off < len) 
+    while (total_off < len)
     {
+        prod = xenstore_buf->req_prod;
+        if (prod - xenstore_buf->req_cons >= XENSTORE_RING_SIZE)
+        {
+            /* Send evtchn to notify remote */
+            notify_remote_via_evtchn(xenbus_evtchn);
+
+            /* Wait for there to be space on the ring */
+            DEBUG("prod %d, len %d, cons %d, size %d; waiting.\n", prod,
+                  len - total_off, xenstore_buf->req_cons, XENSTORE_RING_SIZE);
+            wait_event(xb_waitq,
+                       prod - xenstore_buf->req_cons < XENSTORE_RING_SIZE);
+            DEBUG("Back from wait.\n");
+        }
+
         this_chunk = min(cur_req->len - req_off,
-                XENSTORE_RING_SIZE - MASK_XENSTORE_IDX(prod));
+                         XENSTORE_RING_SIZE - MASK_XENSTORE_IDX(prod));
+        this_chunk = min(this_chunk,
+                         xenstore_buf->req_cons + XENSTORE_RING_SIZE - prod);
         memcpy((char *)xenstore_buf->req + MASK_XENSTORE_IDX(prod),
-                (char *)cur_req->data + req_off, this_chunk);
+               (char *)cur_req->data + req_off, this_chunk);
         prod += this_chunk;
         req_off += this_chunk;
         total_off += this_chunk;
-        if (req_off == cur_req->len) 
+        if (req_off == cur_req->len)
         {
             req_off = 0;
             if (cur_req == &header_req)
@@ -488,20 +522,20 @@ static void xb_write(int type, int req_id, xenbus_transaction_t trans_id,
             else
                 cur_req++;
         }
+
+        /* Remote must see entire message before updating indexes */
+        wmb();
+        xenstore_buf->req_prod = prod;
     }
 
+    /* Send evtchn to notify remote */
+    notify_remote_via_evtchn(xenbus_evtchn);
+
     DEBUG("Complete main loop of xb_write.\n");
     BUG_ON(req_off != 0);
     BUG_ON(total_off != len);
-    BUG_ON(prod > xenstore_buf->req_cons + XENSTORE_RING_SIZE);
 
-    /* Remote must see entire message before updating indexes */
-    wmb();
-
-    xenstore_buf->req_prod += len;
-
-    /* Send evtchn to notify remote */
-    notify_remote_via_evtchn(xenbus_evtchn);
+    up(&xb_write_sem);
 }
 
 /* Send a mesasge to xenbus, in the same fashion as xb_write, and
-- 
2.26.2



From xen-devel-bounces@lists.xenproject.org Mon Oct 04 09:54:32 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Oct 2021 09:54:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.201256.355697 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXKfu-00042K-C3; Mon, 04 Oct 2021 09:54:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 201256.355697; Mon, 04 Oct 2021 09:54:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXKfu-00042D-8o; Mon, 04 Oct 2021 09:54:22 +0000
Received: by outflank-mailman (input) for mailman id 201256;
 Mon, 04 Oct 2021 09:54:21 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=sY6e=OY=gmail.com=rm.skakun@srs-us1.protection.inumbo.net>)
 id 1mXKft-0003kC-Bi
 for xen-devel@lists.xenproject.org; Mon, 04 Oct 2021 09:54:21 +0000
Received: from mail-lf1-x131.google.com (unknown [2a00:1450:4864:20::131])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 89649863-3125-4d7c-a32c-023248b3999f;
 Mon, 04 Oct 2021 09:54:16 +0000 (UTC)
Received: by mail-lf1-x131.google.com with SMTP id b20so69477941lfv.3
 for <xen-devel@lists.xenproject.org>; Mon, 04 Oct 2021 02:54:16 -0700 (PDT)
Received: from localhost ([178.151.124.169])
 by smtp.gmail.com with ESMTPSA id d26sm252462lfi.154.2021.10.04.02.54.14
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Mon, 04 Oct 2021 02:54:15 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 89649863-3125-4d7c-a32c-023248b3999f
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=pKeIejZMmAWUKSzpNfYJ7ftj0OuVVZzScF0RA9xJMh8=;
        b=IwNzQ2/zRS6NytwyXdzbEIDWmskxGJk/uioBO4rV+JHcIAiTW+yc300kIMSmWFflvD
         BaGaqMAIGZkc3PkDOd2A7LRBLWQp/jXIhuTK/sJKU67zPgVG5wakyrWfTiZR3R0NGATh
         QGQvOTXCr9mz4mZvBOSYxLWbWsumJlXqQPHdoDSYPCs9EjE+XHm2dRxMfFlsxf4i6NJ0
         9bEozKqLe6lvqANCD1qVPo2h+r3/8hv48cphH41yAF8rxYTAD3EeU6cou6xHZVNWtHnr
         5mdXklpXrM86ALocZ5SFCWUkKzrc/fLiLGwwNQz1TYa8SMy44qbGI8odaApBRqykrdcr
         zJ0w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=pKeIejZMmAWUKSzpNfYJ7ftj0OuVVZzScF0RA9xJMh8=;
        b=kqYLSgyvmD3w0OLzUU0PEfHbxhHIXIgJGXFjm+CTSH//imhQsNjri6sxjXzCDgh+iW
         V/Spb9WkbMT5fTMyOEgH5b96sSgpqx55Z0I82w7R+kFMv4IsLrkQ9d7O3SGe4crLM75Z
         8jSEKaozKvcXKZ5TIOy7GHtM0TuUu8fULKKDibja9YGl/6h/IYUsOtPdzU08MVKnhijx
         Evxxz1v79i3FDzgeHkLrKJzQBDyNOLXZJMoHwikLD32Z14AI88ep/nAKrNUG4lC26Q7d
         zF2p0mHXVbwdUZKneY9b2Yh6yXA7HXxi7VBe7T9KhBoyrRVIzvObNp1mR4Elk/+rs0UG
         5GLw==
X-Gm-Message-State: AOAM531m46a6bWEwhpMD1nOfyDcgg7h6CSGK1hBGst7sRZYFyLKi2MPZ
	X84C0UTQ8iWuqjiGEkaqiWD0AYfjIqpTkwO2
X-Google-Smtp-Source: ABdhPJyeztrkU+uxCkN1Q5o9nLEW+laMiQoaZtMd9zaApCallzLBMawwyhb4zEQIneNj/grWipTyvQ==
X-Received: by 2002:ac2:4e0a:: with SMTP id e10mr150199lfr.225.1633341255568;
        Mon, 04 Oct 2021 02:54:15 -0700 (PDT)
From: Roman Skakun <rm.skakun@gmail.com>
X-Google-Original-From: Roman Skakun <Roman_Skakun@epam.com>
To: Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	xen-devel@lists.xenproject.org
Cc: Roman Skakun <roman_skakun@epam.com>,
	Roman Skakun <rm.skakun@gmail.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Andrii Anisov <andrii_anisov@epam.com>
Subject: [RFC 1/1] xen/arm: set iommu property for IOMMU-protected devices
Date: Mon,  4 Oct 2021 12:54:02 +0300
Message-Id: <5b101e4e85668bbb18da83044520b0350344f408.1633106362.git.roman_skakun@epam.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <cover.1633106362.git.roman_skakun@epam.com>
References: <cover.1633106362.git.roman_skakun@epam.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Roman Skakun <roman_skakun@epam.com>

Xen is not exposing any IOMMU properties to Dom0.
So Dom0 assumes that all it's devices are not protected by IOMMU.

To make Dom0 aware of IOMMU-protected devices, we need to mark
them somehow. With this approach Dom0 Linux kernel will be able
to selectively disable swiotlb-xen fops for them which will remove
unnecessary buffer bounces.

This patch adds mechanism to describe IOMMU-protected devices by
adding `xen,behind-iommu` property to relevant device nodes in
Dom0 device tree.

Signed-off-by: Roman Skakun <roman_skakun@epam.com>
---
 xen/arch/arm/domain_build.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
index 69fff7fc29..99e2c42b6c 100644
--- a/xen/arch/arm/domain_build.c
+++ b/xen/arch/arm/domain_build.c
@@ -580,6 +580,13 @@ static int __init write_properties(struct domain *d, struct kernel_info *kinfo,
             return res;
     }
 
+    if ( iommu_node && is_iommu_enabled(d) && dt_device_is_protected(node) )
+    {
+        res = fdt_property(kinfo->fdt, "xen,behind-iommu", NULL, 0);
+        if ( res )
+            return res;
+    }
+
     /*
      * Override the property "status" to disable the device when it's
      * marked for passthrough.
-- 
2.27.0



From xen-devel-bounces@lists.xenproject.org Mon Oct 04 09:54:32 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Oct 2021 09:54:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.201255.355685 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXKfq-0003lN-41; Mon, 04 Oct 2021 09:54:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 201255.355685; Mon, 04 Oct 2021 09:54:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXKfq-0003ky-0u; Mon, 04 Oct 2021 09:54:18 +0000
Received: by outflank-mailman (input) for mailman id 201255;
 Mon, 04 Oct 2021 09:54:16 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=sY6e=OY=gmail.com=rm.skakun@srs-us1.protection.inumbo.net>)
 id 1mXKfo-0003kC-EE
 for xen-devel@lists.xenproject.org; Mon, 04 Oct 2021 09:54:16 +0000
Received: from mail-lf1-x136.google.com (unknown [2a00:1450:4864:20::136])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 887292d1-525d-42b3-8227-f4ab322db6e8;
 Mon, 04 Oct 2021 09:54:15 +0000 (UTC)
Received: by mail-lf1-x136.google.com with SMTP id b20so69477628lfv.3
 for <xen-devel@lists.xenproject.org>; Mon, 04 Oct 2021 02:54:15 -0700 (PDT)
Received: from localhost ([178.151.124.169])
 by smtp.gmail.com with ESMTPSA id be14sm1567669ljb.7.2021.10.04.02.54.13
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Mon, 04 Oct 2021 02:54:13 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 887292d1-525d-42b3-8227-f4ab322db6e8
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:mime-version
         :content-transfer-encoding;
        bh=0umGd92a5dhGAHF7Qb3MENIFYI1Ca0QKQfItQDzaBxM=;
        b=IJXsSg7f7CuqFLZDozayVwOcdOWRbDcPFeXiQtPrVxoH4DVpZ/R4MqsC1jpL69JCVJ
         OJYW4CWbZsLty43lxWD0WUBPW9IhH6ZgfmA8baGlwA3FRkdIcXLQ7AwoSOFrGb53L2P9
         i2CglZWLyZwUk4tk7oOqQLYAPT9tT5BELPtnWH+Qnafczo9dmOJoDoSXySrtZFUCR882
         9NsPHDWdVZZeLQWbBK6efcsF6o7oykMINmGjWybpA0IEaJWiF0F2cQdAatBeK6dEQvc+
         3ORqbK913Q9Il9yLCTq3ESI7+O4XonfW2WBTthAKIcD0ckyTIudJnLJAsl9UXG/Jtvm1
         pN4A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version
         :content-transfer-encoding;
        bh=0umGd92a5dhGAHF7Qb3MENIFYI1Ca0QKQfItQDzaBxM=;
        b=pVa6QY5OLnnBXsh9sA3Pkm6dZkQO4Y1GsQWSOr6iTATRQT8vWJ7eB0ct/tzZCjji6L
         FzWcmv5T7QwXIxQlnVq92/LSc8DwyYofS2qMhqlvf52xDw6eCxQkVTUccarGttL3FqOj
         1xGkEgvX4yP4tkS5tft0TlfLlSjkpGNywBfkfFC1gKLUPpvxLGzArLYlatF36GAxIbNl
         xKnG6aCdJpcx2O9vLG/3cGa2kgt9HGaU+wSkFtFQxNJF1k4w4c5Ww3sbdttjJVZhnT9S
         k9W7Tt67EOwLIJlq+53rp1enxMj8MS233qk4vJQZuUj6pZo/rsM4er6tE8qKGGXRCtyL
         Wbeg==
X-Gm-Message-State: AOAM533uVX9MlSi4u+Td81RM+qAelQMxGVNrmpegODUgnqICCYFM0eln
	pxdl6adwflzDSTq8uuvIi5E=
X-Google-Smtp-Source: ABdhPJwp405WaBYmXsqHCSb7cDL4QAlEtFiejN/aKi+OD7BtyLRtbMLig4/eOqFY/iW31AZt1z2S/Q==
X-Received: by 2002:a05:6512:39ca:: with SMTP id k10mr14186305lfu.54.1633341254121;
        Mon, 04 Oct 2021 02:54:14 -0700 (PDT)
From: Roman Skakun <rm.skakun@gmail.com>
X-Google-Original-From: Roman Skakun <Roman_Skakun@epam.com>
To: Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	xen-devel@lists.xenproject.org
Cc: Roman Skakun <roman_skakun@epam.com>,
	Roman Skakun <rm.skakun@gmail.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Andrii Anisov <andrii_anisov@epam.com>
Subject: [RFC 0/1] tag IOMMU-protected devices in Dom0 fdt
Date: Mon,  4 Oct 2021 12:54:01 +0300
Message-Id: <cover.1633106362.git.roman_skakun@epam.com>
X-Mailer: git-send-email 2.30.2
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Roman Skakun <roman_skakun@epam.com>

At the moment, Dom0 can't distinguish which devices are protected by
IOMMU and which are not. In some cases, this can cause swiotlb bounce
buffer use for DMA addresses above 32 bits, which in turn can lead
to poor performance. I started a conversation at [1], where we discussed
addition of a new device tree property to mark IOMMU-protected devices for Dom0.

As a result of negotiation at [1], I would like to present two
patches:

1. The first patch for the hypervisor. It adds a new device property
'xen,behind-iommu' to a relevant device node when the device is
IOMMU-protected.

2. The second patch is a Linux kernel counterpart. It detects the said
property and disables swiotlb for a device.

There is a possible issue: some devices may not be able to use DMA
addresses above 32 bit boundaries, so we can have problems in the
direct DMA mechanism when swiotlb-xen is disabled for a such
device. More generally, this can affect any device which DMA address
range is narrower than CPU one.
 
In this case,
the device DMA address should be no bigger than 32 bit boundaries for
each device that is not using swiotlb-xen.

Several ideas on how to overcome it:
1. Do not use high memory for Dom0.
2. Set DMA 32bit mask for each device if swiotlb is not used for this device.
3. Force balloon driver to allocate buffers only below 4GB.

I will be glad to get any comments or suggestions.

[1] https://lore.kernel.org/xen-devel/AM7PR03MB65936E5D0B25567D1B2FAECA85CC9@AM7PR03MB6593.eurprd03.prod.outlook.com/

Roman Skakun (1):
  xen/arm: set iommu property for IOMMU-protected devices

 xen/arch/arm/domain_build.c | 7 +++++++
 1 file changed, 7 insertions(+)

-- 
2.27.0



From xen-devel-bounces@lists.xenproject.org Mon Oct 04 09:54:37 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Oct 2021 09:54:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.201257.355708 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXKfz-0004Mb-Le; Mon, 04 Oct 2021 09:54:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 201257.355708; Mon, 04 Oct 2021 09:54:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXKfz-0004MU-Gq; Mon, 04 Oct 2021 09:54:27 +0000
Received: by outflank-mailman (input) for mailman id 201257;
 Mon, 04 Oct 2021 09:54:26 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=sY6e=OY=gmail.com=rm.skakun@srs-us1.protection.inumbo.net>)
 id 1mXKfy-0003kC-Br
 for xen-devel@lists.xenproject.org; Mon, 04 Oct 2021 09:54:26 +0000
Received: from mail-lf1-x133.google.com (unknown [2a00:1450:4864:20::133])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 7cfb36a7-985a-4f7a-8746-bb783082fc2f;
 Mon, 04 Oct 2021 09:54:18 +0000 (UTC)
Received: by mail-lf1-x133.google.com with SMTP id i4so69637767lfv.4
 for <xen-devel@lists.xenproject.org>; Mon, 04 Oct 2021 02:54:17 -0700 (PDT)
Received: from localhost ([178.151.124.169])
 by smtp.gmail.com with ESMTPSA id w14sm1612368ljw.73.2021.10.04.02.54.16
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Mon, 04 Oct 2021 02:54:16 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7cfb36a7-985a-4f7a-8746-bb783082fc2f
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=dvnwbtKXuUTovX39gB85uB/X6CcafQCm1x1qqRSoYLU=;
        b=YNmeI4BJ3NA50ZgVWUtmG53Yz9NzRqEsySE7NtRQV0dVt15bwba1LF7cnFL3leFtCf
         pBEheknC/K/zeSTz3nPcdD830yk8aH0N4ClnDpWJh8AZSzlj0hDbgiCz2+Q2WrRSSYRH
         VJP+uNx6H8U36Rvv15TKmBEulFJBQlHAqa8qZOba1sC1XPebeTCdnl041eT0jGop3wol
         iissrEgIuk8pDlrT1Nnt5f7YPjeQoUu3zS4muj4nBlYYohyYcsHpf3KCAztRqh3OsGqg
         EUMmofKcocqfEFa03Jd2cInRnoDTxY5Ofq/F62slQloVVaPpRL72OuIMol9aZVrGXD7Z
         WMXw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=dvnwbtKXuUTovX39gB85uB/X6CcafQCm1x1qqRSoYLU=;
        b=nJ50rz7cER+32P5FywPKwms5LGlPw+5P5S3fUJ/6gxDBy6N436nkKntwgOM7da0y+U
         rxLGMGh/+B0nwGQLMvcpSlXx1DDFbe8QTPDoont26BGcTwYigs4Pci+2rcytyYqmkjye
         NuOkErsCn537CjArvzPh0Bx5j2ir87HIzlMQvex4m3p3ReWCEV4TweXi0lf3SU/oOuhI
         n8S9TYSv53eY5wtVzqYp4k9dLNy2Tc6eWuuENfeiikwPafUvZ3/JAd5px7l+k60xV2uI
         99oaqTj2uMob+XGH8/23o5a1VFT/QyfRhPfYcwdAN9w5i9ZEQcLixhfcgTUd0s/0Cxg2
         1AAw==
X-Gm-Message-State: AOAM531pzWy7rdBumeF9G5EK1By+/oAErWko7rvEkKYEGJDr+Zn145MN
	Dn3YA2QCIpMuNZqgjP+XSds=
X-Google-Smtp-Source: ABdhPJzyJGasKtm3y+zLqxQVYpV5fmsIGojp/kBAB//FqkuWucfSlK8Vxl8hFgwI2mPCd49zyc8X8g==
X-Received: by 2002:a2e:504a:: with SMTP id v10mr14456170ljd.9.1633341257004;
        Mon, 04 Oct 2021 02:54:17 -0700 (PDT)
From: Roman Skakun <rm.skakun@gmail.com>
X-Google-Original-From: Roman Skakun <Roman_Skakun@epam.com>
To: Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	xen-devel@lists.xenproject.org
Cc: Roman Skakun <roman_skakun@epam.com>,
	Roman Skakun <rm.skakun@gmail.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Andrii Anisov <andrii_anisov@epam.com>,
	Roman Skakun <Roman_Skakun@epam.com>
Subject: [RFC PATCH] dma-mapping: don't set swiotlb-xen fops for IOMMU-protected devices
Date: Mon,  4 Oct 2021 12:54:03 +0300
Message-Id: <20211004095415.100756-1-Roman_Skakun@epam.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <cover.1633106362.git.roman_skakun@epam.com>
References: <cover.1633106362.git.roman_skakun@epam.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Prior to this patch swiotlb-xen fops are set for all devices when
we are booting as as Dom0 or direct-mapped DomU.

Since Xen now marks devices which are IOMMU-protected by
adding additional property to the relevant device, we can
check for this property and don't set swiotlb-xen fops for
any IOMMU-protected device.

Signed-off-by: Roman Skakun <Roman_Skakun@epam.com>
---
 arch/arm/mm/dma-mapping.c   | 2 +-
 arch/arm/xen/enlighten.c    | 4 ++++
 arch/arm64/mm/dma-mapping.c | 2 +-
 include/xen/xen.h           | 2 ++
 4 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/arch/arm/mm/dma-mapping.c b/arch/arm/mm/dma-mapping.c
index c4b8df2ad328..c3e5841d871e 100644
--- a/arch/arm/mm/dma-mapping.c
+++ b/arch/arm/mm/dma-mapping.c
@@ -2280,7 +2280,7 @@ void arch_setup_dma_ops(struct device *dev, u64 dma_base, u64 size,
 	set_dma_ops(dev, dma_ops);
 
 #ifdef CONFIG_XEN
-	if (xen_initial_domain())
+	if (xen_initial_domain() && !xen_is_device_protected(dev))
 		dev->dma_ops = &xen_swiotlb_dma_ops;
 #endif
 	dev->archdata.dma_ops_setup = true;
diff --git a/arch/arm/xen/enlighten.c b/arch/arm/xen/enlighten.c
index 49f566ad9acb..6ddef3233095 100644
--- a/arch/arm/xen/enlighten.c
+++ b/arch/arm/xen/enlighten.c
@@ -425,6 +425,10 @@ static int __init xen_pm_init(void)
 }
 late_initcall(xen_pm_init);
 
+bool xen_is_device_protected(void *obj) {
+	struct device *dev = obj;
+	return of_property_read_bool(dev->of_node, "xen,behind-iommu");
+}
 
 /* empty stubs */
 void xen_arch_pre_suspend(void) { }
diff --git a/arch/arm64/mm/dma-mapping.c b/arch/arm64/mm/dma-mapping.c
index 93e87b287556..0af5f7a63124 100644
--- a/arch/arm64/mm/dma-mapping.c
+++ b/arch/arm64/mm/dma-mapping.c
@@ -53,7 +53,7 @@ void arch_setup_dma_ops(struct device *dev, u64 dma_base, u64 size,
 		iommu_setup_dma_ops(dev, dma_base, size);
 
 #ifdef CONFIG_XEN
-	if (xen_initial_domain())
+	if (xen_initial_domain() && !xen_is_device_protected(dev))
 		dev->dma_ops = &xen_swiotlb_dma_ops;
 #endif
 }
diff --git a/include/xen/xen.h b/include/xen/xen.h
index 43efba045acc..3725d69de6f9 100644
--- a/include/xen/xen.h
+++ b/include/xen/xen.h
@@ -61,4 +61,6 @@ void xen_free_unpopulated_pages(unsigned int nr_pages, struct page **pages);
 #include <xen/balloon.h>
 #endif
 
+bool xen_is_device_protected(void *obj);
+
 #endif	/* _XEN_XEN_H */
-- 
2.27.0



From xen-devel-bounces@lists.xenproject.org Mon Oct 04 11:52:44 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Oct 2021 11:52:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.201297.355736 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXMWL-0000El-MM; Mon, 04 Oct 2021 11:52:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 201297.355736; Mon, 04 Oct 2021 11:52:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXMWL-0000Ed-JO; Mon, 04 Oct 2021 11:52:37 +0000
Received: by outflank-mailman (input) for mailman id 201297;
 Mon, 04 Oct 2021 11:52:36 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=TJPG=OY=arm.com=rahul.singh@srs-us1.protection.inumbo.net>)
 id 1mXMWK-0000EW-Dc
 for xen-devel@lists.xenproject.org; Mon, 04 Oct 2021 11:52:36 +0000
Received: from foss.arm.com (unknown [217.140.110.172])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTP
 id 6cea0d38-7203-4a32-a265-b74a8951cb8b;
 Mon, 04 Oct 2021 11:52:33 +0000 (UTC)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A66411FB;
 Mon,  4 Oct 2021 04:52:32 -0700 (PDT)
Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com
 [10.1.199.62])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7190E3F70D;
 Mon,  4 Oct 2021 04:52:30 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6cea0d38-7203-4a32-a265-b74a8951cb8b
From: Rahul Singh <rahul.singh@arm.com>
To: xen-devel@lists.xenproject.org
Cc: bertrand.marquis@arm.com,
	rahul.singh@arm.com,
	Andre.Przywara@arm.com,
	Jan Beulich <jbeulich@suse.com>,
	Paul Durrant <paul@xen.org>,
	Ian Jackson <iwj@xenproject.org>,
	Wei Liu <wl@xen.org>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	Christian Lindig <christian.lindig@citrix.com>,
	David Scott <dave@recoil.org>,
	Anthony PERARD <anthony.perard@citrix.com>
Subject: [PATCH v4 00/14] PCI devices passthrough on Arm
Date: Mon,  4 Oct 2021 12:51:55 +0100
Message-Id: <cover.1633340795.git.rahul.singh@arm.com>
X-Mailer: git-send-email 2.25.1
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Hello All,

The purpose of this patch series is to add PCI passthrough support to Xen on
Arm. PCI passthrough support on ARM is the collaboration work between EPAM and
ARM. ARM submitted the partial RFC [1][2] last year to get early feedback. We
tried to fix all the comments and added more features to this patch series.

Working POC with all the features can be found at [3]. Working POC is tested
on x86 so that there will be no regression on x86. Design presentation can be
found at [4]

PCI passthrough support is divided into different patches. This patch series
includes following features: 

Preparatory work to implement the PCI passthrough support for the ARM:
- Refactor MSI code.
- Fixed compilation error when HAS_PCI enabled for ARM.

Discovering PCI Host Bridge in XEN:
- PCI init to initialize the PCI driver.
- PCI host bridge discovery in XEN and map the PCI ECAM configuration space to
  the XEN memory.
- PCI access functions.

Discovering PCI devices:
- To support the PCI passthrough, XEN should be aware of the PCI
  devices.
- Hardware domain is in charge of doing the PCI enumeration and will discover
  the PCI devices and then communicate to the XEN via a hypercall to add the
  PCI devices in XEN.

Enable the existing x86 virtual PCI support for ARM:
- Add VPCI trap handler for each of the PCI device added for config space
  access.
- Register the trap handler in XEN for each of the host bridge PCI ECAM config
  space access.

Emulated PCI device tree node in libxl:
- Create a virtual PCI device tree node in libxl to enable the guest OS to
  discover the virtual PCI during guest boot.

This patch series does not inlcude the following features. Following features
will be send for review in the next version of the patch series once initial
patch series merged.

- VPCI support for DOMU guests (Non-identity mappings guest view of the BARs)
- Virtual bus topology implementation
- IOMMU related changes (generic, SMMUv2, SMMUv3)
- MSI support for DOMU guests.
- Virual ITS support for DOMU guests

[1] https://lists.xenproject.org/archives/html/xen-devel/2020-07/msg01184.html
[2] https://lists.xenproject.org/archives/html/xen-devel/2020-07/threads.html#01184
[3] https://gitlab.com/rahsingh/xen-integration/-/commits/pci-passthrough-upstream-all
[4] https://static.sched.com/hosted_files/xen2021/e4/PCI_Device_Passthrough_On_Arm.pdf

Oleksandr Andrushchenko (1):
  xen/arm: Add support for Xilinx ZynqMP PCI host controller

Rahul Singh (13):
  xen/pci: gate APEI support on ARM
  xen/arm: xc_domain_ioport_permission(..) not supported on ARM.
  xen/arm: Add PHYSDEVOP_pci_device_(*add/remove) support for ARM
  xen/pci: Include asm/pci.h after pci_sbdf_t in xen/pci.h
  xen/arm: Add support for PCI init to initialize the PCI driver.
  xen/arm: Add cmdline boot option "pci-passthrough = <boolean>"
  xen/arm: PCI host bridge discovery within XEN on ARM
  xen/arm: Implement pci access functions
  xen/domctl: Introduce XEN_DOMCTL_CDF_vpci flag
  xen/arm: Enable the existing x86 virtual PCI support for ARM.
  xen/arm: Transitional change to build HAS_VPCI on ARM.
  arm/libxl: Emulated PCI device tree node in libxl
  xen/arm: Add linux,pci-domain property for hwdom if not available.

 docs/misc/xen-command-line.pandoc   |   7 +
 tools/include/libxl.h               |   6 +
 tools/libs/ctrl/xc_domain.c         |   9 +
 tools/libs/light/libxl_arm.c        | 105 ++++++++++
 tools/libs/light/libxl_create.c     |   9 +
 tools/libs/light/libxl_types.idl    |   1 +
 tools/ocaml/libs/xc/xenctrl.ml      |   1 +
 tools/ocaml/libs/xc/xenctrl.mli     |   1 +
 tools/xl/xl_parse.c                 |   8 +
 xen/arch/arm/Makefile               |   1 +
 xen/arch/arm/domain.c               |   8 +-
 xen/arch/arm/domain_build.c         |  19 ++
 xen/arch/arm/pci/Makefile           |   5 +
 xen/arch/arm/pci/ecam.c             |  61 ++++++
 xen/arch/arm/pci/pci-access.c       | 140 ++++++++++++++
 xen/arch/arm/pci/pci-host-common.c  | 287 ++++++++++++++++++++++++++++
 xen/arch/arm/pci/pci-host-generic.c |  48 +++++
 xen/arch/arm/pci/pci-host-zynqmp.c  |  65 +++++++
 xen/arch/arm/pci/pci.c              |  63 ++++++
 xen/arch/arm/physdev.c              |   5 +-
 xen/arch/arm/vpci.c                 | 102 ++++++++++
 xen/arch/arm/vpci.h                 |  36 ++++
 xen/arch/x86/domain.c               |   6 +
 xen/arch/x86/physdev.c              |  52 +----
 xen/arch/x86/x86_64/physdev.c       |   2 +-
 xen/common/domain.c                 |   2 +-
 xen/drivers/passthrough/pci.c       |  20 +-
 xen/drivers/pci/Makefile            |   1 +
 xen/drivers/pci/physdev.c           |  86 +++++++++
 xen/drivers/vpci/Makefile           |   3 +-
 xen/drivers/vpci/header.c           |   2 +
 xen/include/asm-arm/device.h        |   1 +
 xen/include/asm-arm/domain.h        |   7 +-
 xen/include/asm-arm/pci.h           |  85 ++++++++
 xen/include/asm-x86/pci.h           |   8 +-
 xen/include/public/arch-arm.h       |  21 +-
 xen/include/public/domctl.h         |   4 +-
 xen/include/xen/hypercall.h         |  11 ++
 xen/include/xen/pci.h               |   5 +-
 39 files changed, 1238 insertions(+), 65 deletions(-)
 create mode 100644 xen/arch/arm/pci/ecam.c
 create mode 100644 xen/arch/arm/pci/pci-access.c
 create mode 100644 xen/arch/arm/pci/pci-host-common.c
 create mode 100644 xen/arch/arm/pci/pci-host-generic.c
 create mode 100644 xen/arch/arm/pci/pci-host-zynqmp.c
 create mode 100644 xen/arch/arm/vpci.c
 create mode 100644 xen/arch/arm/vpci.h
 create mode 100644 xen/drivers/pci/physdev.c

-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Mon Oct 04 11:53:05 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Oct 2021 11:53:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.201301.355748 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXMWn-0000fu-1Q; Mon, 04 Oct 2021 11:53:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 201301.355748; Mon, 04 Oct 2021 11:53:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXMWm-0000fn-T9; Mon, 04 Oct 2021 11:53:04 +0000
Received: by outflank-mailman (input) for mailman id 201301;
 Mon, 04 Oct 2021 11:53:03 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=TJPG=OY=arm.com=rahul.singh@srs-us1.protection.inumbo.net>)
 id 1mXMWl-0000bX-SY
 for xen-devel@lists.xenproject.org; Mon, 04 Oct 2021 11:53:03 +0000
Received: from foss.arm.com (unknown [217.140.110.172])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTP
 id 9ebeedf2-2509-11ec-beab-12813bfff9fa;
 Mon, 04 Oct 2021 11:52:59 +0000 (UTC)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B5B80D6E;
 Mon,  4 Oct 2021 04:52:58 -0700 (PDT)
Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com
 [10.1.199.62])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B51833F70D;
 Mon,  4 Oct 2021 04:52:57 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9ebeedf2-2509-11ec-beab-12813bfff9fa
From: Rahul Singh <rahul.singh@arm.com>
To: xen-devel@lists.xenproject.org
Cc: bertrand.marquis@arm.com,
	rahul.singh@arm.com,
	Andre.Przywara@arm.com,
	Jan Beulich <jbeulich@suse.com>,
	Paul Durrant <paul@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>
Subject: [PATCH v4 01/14] xen/pci: gate APEI support on ARM
Date: Mon,  4 Oct 2021 12:51:56 +0100
Message-Id: <86152436450756519f255309b7ea9cf23823517d.1633340795.git.rahul.singh@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <cover.1633340795.git.rahul.singh@arm.com>
References: <cover.1633340795.git.rahul.singh@arm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

APEI not supported on ARM yet move the code under CONFIG_X86 flag to
gate the code for ARM.

This patch is the preparatory work to enable HAS_PCI on ARM to avoid
compilation error on ARM.

prelink.o: In function `pcie_aer_get_firmware_first’:
drivers/passthrough/pci.c:1251: undefined reference to `apei_hest_parse'

Signed-off-by: Rahul Singh <rahul.singh@arm.com>
Acked-by: Stefano Stabellini <sstabellini@kernel.org>
Acked-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>
---
Chane in v4:
- Modify commit message based on received comment.
- Added Acked-by: Jan Beulich <jbeulich@suse.com>
- Added Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>
Change in v3: Added Acked-by: Stefano Stabellini <sstabellini@kernel.org>
Change in v2: Add in code comment "APEI not supported on ARM yet"
---
---
 xen/drivers/passthrough/pci.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci.c
index 5456ca3a63..e1b735d9e8 100644
--- a/xen/drivers/passthrough/pci.c
+++ b/xen/drivers/passthrough/pci.c
@@ -1149,7 +1149,8 @@ void __hwdom_init setup_hwdom_pci_devices(
     pcidevs_unlock();
 }
 
-#ifdef CONFIG_ACPI
+/* APEI not supported on ARM yet. */
+#if defined(CONFIG_ACPI) && defined(CONFIG_X86)
 #include <acpi/acpi.h>
 #include <acpi/apei.h>
 
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Mon Oct 04 11:53:19 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Oct 2021 11:53:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.201305.355758 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXMX1-0001B4-8f; Mon, 04 Oct 2021 11:53:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 201305.355758; Mon, 04 Oct 2021 11:53:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXMX1-0001At-5C; Mon, 04 Oct 2021 11:53:19 +0000
Received: by outflank-mailman (input) for mailman id 201305;
 Mon, 04 Oct 2021 11:53:18 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=TJPG=OY=arm.com=rahul.singh@srs-us1.protection.inumbo.net>)
 id 1mXMX0-00019E-9K
 for xen-devel@lists.xenproject.org; Mon, 04 Oct 2021 11:53:18 +0000
Received: from foss.arm.com (unknown [217.140.110.172])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTP
 id a9ca6546-2509-11ec-beab-12813bfff9fa;
 Mon, 04 Oct 2021 11:53:17 +0000 (UTC)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4EE5C1FB;
 Mon,  4 Oct 2021 04:53:17 -0700 (PDT)
Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com
 [10.1.199.62])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 33AB23F70D;
 Mon,  4 Oct 2021 04:53:16 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a9ca6546-2509-11ec-beab-12813bfff9fa
From: Rahul Singh <rahul.singh@arm.com>
To: xen-devel@lists.xenproject.org
Cc: bertrand.marquis@arm.com,
	rahul.singh@arm.com,
	Andre.Przywara@arm.com,
	Ian Jackson <iwj@xenproject.org>,
	Wei Liu <wl@xen.org>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>
Subject: [PATCH v4 02/14] xen/arm: xc_domain_ioport_permission(..) not supported on ARM.
Date: Mon,  4 Oct 2021 12:51:57 +0100
Message-Id: <0be5813a0d5c17ef650e42a7c7c5098c6bcd6c97.1633340795.git.rahul.singh@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <cover.1633340795.git.rahul.singh@arm.com>
References: <cover.1633340795.git.rahul.singh@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

ARM architecture does not implement I/O ports. Ignore this call on ARM
to avoid the overhead of making a hypercall just for Xen to return
-ENOSYS.

Signed-off-by: Rahul Singh <rahul.singh@arm.com>
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>
---
Change in v4:
- Added Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>
Change in v3: Added Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
Change in v2:
- Instead of returning success in XEN, ignored the call in xl.
---
---
 tools/libs/ctrl/xc_domain.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/tools/libs/ctrl/xc_domain.c b/tools/libs/ctrl/xc_domain.c
index 23322b70b5..25c95f6596 100644
--- a/tools/libs/ctrl/xc_domain.c
+++ b/tools/libs/ctrl/xc_domain.c
@@ -1348,6 +1348,14 @@ int xc_domain_ioport_permission(xc_interface *xch,
                                 uint32_t nr_ports,
                                 uint32_t allow_access)
 {
+#if defined(__arm__) || defined(__aarch64__)
+    /*
+     * The ARM architecture does not implement I/O ports.
+     * Avoid the overhead of making a hypercall just for Xen to return -ENOSYS.
+     * It is safe to ignore this call on ARM so we just return 0.
+     */
+    return 0;
+#else
     DECLARE_DOMCTL;
 
     domctl.cmd = XEN_DOMCTL_ioport_permission;
@@ -1357,6 +1365,7 @@ int xc_domain_ioport_permission(xc_interface *xch,
     domctl.u.ioport_permission.allow_access = allow_access;
 
     return do_domctl(xch, &domctl);
+#endif
 }
 
 int xc_availheap(xc_interface *xch,
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Mon Oct 04 11:53:34 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Oct 2021 11:53:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.201310.355769 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXMXG-0001lo-Jy; Mon, 04 Oct 2021 11:53:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 201310.355769; Mon, 04 Oct 2021 11:53:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXMXG-0001lh-Gz; Mon, 04 Oct 2021 11:53:34 +0000
Received: by outflank-mailman (input) for mailman id 201310;
 Mon, 04 Oct 2021 11:53:32 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=TJPG=OY=arm.com=rahul.singh@srs-us1.protection.inumbo.net>)
 id 1mXMXE-0001hd-RK
 for xen-devel@lists.xenproject.org; Mon, 04 Oct 2021 11:53:32 +0000
Received: from foss.arm.com (unknown [217.140.110.172])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTP
 id b23755fe-2509-11ec-beab-12813bfff9fa;
 Mon, 04 Oct 2021 11:53:31 +0000 (UTC)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6D27B1FB;
 Mon,  4 Oct 2021 04:53:31 -0700 (PDT)
Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com
 [10.1.199.62])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 9C8A23F70D;
 Mon,  4 Oct 2021 04:53:29 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b23755fe-2509-11ec-beab-12813bfff9fa
From: Rahul Singh <rahul.singh@arm.com>
To: xen-devel@lists.xenproject.org
Cc: bertrand.marquis@arm.com,
	rahul.singh@arm.com,
	Andre.Przywara@arm.com,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Ian Jackson <iwj@xenproject.org>,
	Jan Beulich <jbeulich@suse.com>,
	Wei Liu <wl@xen.org>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>
Subject: [PATCH v4 03/14] xen/arm: Add PHYSDEVOP_pci_device_(*add/remove) support for ARM
Date: Mon,  4 Oct 2021 12:51:58 +0100
Message-Id: <99ee039a6cdd9ac7d54f1f01649d1dd3eeea3763.1633340795.git.rahul.singh@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <cover.1633340795.git.rahul.singh@arm.com>
References: <cover.1633340795.git.rahul.singh@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Hardware domain is in charge of doing the PCI enumeration and will
discover the PCI devices and then will communicate to XEN via hyper
call PHYSDEVOP_pci_device_add(..) to add the PCI devices in XEN.

Also implement PHYSDEVOP_pci_device_remove(..) to remove the PCI device.

As most of the code for PHYSDEVOP_pci_device_* is the same between x86
and ARM, move the code to a common file to avoid duplication.

There are other PHYSDEVOP_pci_device_* operations to add PCI devices.
Currently implemented PHYSDEVOP_pci_device_remove(..) and
PHYSDEVOP_pci_device_add(..) only as those are minimum required to
support PCI passthrough on ARM.

Signed-off-by: Rahul Singh <rahul.singh@arm.com>
---
Change in v4:
- Move file commom/physdev.c to drivers/pci/physdev.c
- minor comments.
Change in v3: Fixed minor comment.
Change in v2:
- Add support for PHYSDEVOP_pci_device_remove()
- Move code to common code
---
---
 xen/arch/arm/physdev.c        |  5 +--
 xen/arch/x86/physdev.c        | 52 +----------------------
 xen/arch/x86/x86_64/physdev.c |  2 +-
 xen/drivers/pci/Makefile      |  1 +
 xen/drivers/pci/physdev.c     | 80 +++++++++++++++++++++++++++++++++++
 xen/include/public/arch-arm.h |  4 +-
 xen/include/xen/hypercall.h   | 11 +++++
 7 files changed, 100 insertions(+), 55 deletions(-)
 create mode 100644 xen/drivers/pci/physdev.c

diff --git a/xen/arch/arm/physdev.c b/xen/arch/arm/physdev.c
index e91355fe22..d766978629 100644
--- a/xen/arch/arm/physdev.c
+++ b/xen/arch/arm/physdev.c
@@ -8,13 +8,12 @@
 #include <xen/lib.h>
 #include <xen/errno.h>
 #include <xen/sched.h>
-#include <asm/hypercall.h>
+#include <xen/hypercall.h>
 
 
 int do_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
 {
-    gdprintk(XENLOG_DEBUG, "PHYSDEVOP cmd=%d: not implemented\n", cmd);
-    return -ENOSYS;
+    return pci_physdev_op(cmd, arg);
 }
 
 /*
diff --git a/xen/arch/x86/physdev.c b/xen/arch/x86/physdev.c
index 23465bcd00..ea38be8b79 100644
--- a/xen/arch/x86/physdev.c
+++ b/xen/arch/x86/physdev.c
@@ -12,7 +12,7 @@
 #include <asm/io_apic.h>
 #include <asm/msi.h>
 #include <asm/hvm/irq.h>
-#include <asm/hypercall.h>
+#include <xen/hypercall.h>
 #include <public/xen.h>
 #include <public/physdev.h>
 #include <xsm/xsm.h>
@@ -480,54 +480,6 @@ ret_t do_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
         break;
     }
 
-    case PHYSDEVOP_pci_device_add: {
-        struct physdev_pci_device_add add;
-        struct pci_dev_info pdev_info;
-        nodeid_t node;
-
-        ret = -EFAULT;
-        if ( copy_from_guest(&add, arg, 1) != 0 )
-            break;
-
-        pdev_info.is_extfn = !!(add.flags & XEN_PCI_DEV_EXTFN);
-        if ( add.flags & XEN_PCI_DEV_VIRTFN )
-        {
-            pdev_info.is_virtfn = 1;
-            pdev_info.physfn.bus = add.physfn.bus;
-            pdev_info.physfn.devfn = add.physfn.devfn;
-        }
-        else
-            pdev_info.is_virtfn = 0;
-
-        if ( add.flags & XEN_PCI_DEV_PXM )
-        {
-            uint32_t pxm;
-            size_t optarr_off = offsetof(struct physdev_pci_device_add, optarr) /
-                                sizeof(add.optarr[0]);
-
-            if ( copy_from_guest_offset(&pxm, arg, optarr_off, 1) )
-                break;
-
-            node = pxm_to_node(pxm);
-        }
-        else
-            node = NUMA_NO_NODE;
-
-        ret = pci_add_device(add.seg, add.bus, add.devfn, &pdev_info, node);
-        break;
-    }
-
-    case PHYSDEVOP_pci_device_remove: {
-        struct physdev_pci_device dev;
-
-        ret = -EFAULT;
-        if ( copy_from_guest(&dev, arg, 1) != 0 )
-            break;
-
-        ret = pci_remove_device(dev.seg, dev.bus, dev.devfn);
-        break;
-    }
-
     case PHYSDEVOP_prepare_msix:
     case PHYSDEVOP_release_msix: {
         struct physdev_pci_device dev;
@@ -663,7 +615,7 @@ ret_t do_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
     }
 
     default:
-        ret = -ENOSYS;
+        ret = pci_physdev_op(cmd, arg);
         break;
     }
 
diff --git a/xen/arch/x86/x86_64/physdev.c b/xen/arch/x86/x86_64/physdev.c
index 0a50cbd4d8..e3cbd5ebcb 100644
--- a/xen/arch/x86/x86_64/physdev.c
+++ b/xen/arch/x86/x86_64/physdev.c
@@ -9,7 +9,7 @@ EMIT_FILE;
 #include <compat/xen.h>
 #include <compat/event_channel.h>
 #include <compat/physdev.h>
-#include <asm/hypercall.h>
+#include <xen/hypercall.h>
 
 #define do_physdev_op compat_physdev_op
 
diff --git a/xen/drivers/pci/Makefile b/xen/drivers/pci/Makefile
index a98035df4c..972c923db0 100644
--- a/xen/drivers/pci/Makefile
+++ b/xen/drivers/pci/Makefile
@@ -1 +1,2 @@
 obj-y += pci.o
+obj-y += physdev.o
diff --git a/xen/drivers/pci/physdev.c b/xen/drivers/pci/physdev.c
new file mode 100644
index 0000000000..4f3e1a96c0
--- /dev/null
+++ b/xen/drivers/pci/physdev.c
@@ -0,0 +1,80 @@
+
+#include <xen/guest_access.h>
+#include <xen/hypercall.h>
+#include <xen/init.h>
+
+#ifndef COMPAT
+typedef long ret_t;
+#endif
+
+ret_t pci_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
+{
+    ret_t ret;
+
+    switch ( cmd )
+    {
+    case PHYSDEVOP_pci_device_add: {
+        struct physdev_pci_device_add add;
+        struct pci_dev_info pdev_info;
+        nodeid_t node = NUMA_NO_NODE;
+
+        ret = -EFAULT;
+        if ( copy_from_guest(&add, arg, 1) != 0 )
+            break;
+
+        pdev_info.is_extfn = (add.flags & XEN_PCI_DEV_EXTFN);
+        if ( add.flags & XEN_PCI_DEV_VIRTFN )
+        {
+            pdev_info.is_virtfn = true;
+            pdev_info.physfn.bus = add.physfn.bus;
+            pdev_info.physfn.devfn = add.physfn.devfn;
+        }
+        else
+            pdev_info.is_virtfn = false;
+
+#ifdef CONFIG_NUMA
+        if ( add.flags & XEN_PCI_DEV_PXM )
+        {
+            uint32_t pxm;
+            size_t optarr_off = offsetof(struct physdev_pci_device_add, optarr) /
+                                sizeof(add.optarr[0]);
+
+            if ( copy_from_guest_offset(&pxm, arg, optarr_off, 1) )
+                break;
+
+            node = pxm_to_node(pxm);
+        }
+#endif
+
+        ret = pci_add_device(add.seg, add.bus, add.devfn, &pdev_info, node);
+        break;
+    }
+
+    case PHYSDEVOP_pci_device_remove: {
+        struct physdev_pci_device dev;
+
+        ret = -EFAULT;
+        if ( copy_from_guest(&dev, arg, 1) != 0 )
+            break;
+
+        ret = pci_remove_device(dev.seg, dev.bus, dev.devfn);
+        break;
+    }
+
+    default:
+        ret = -ENOSYS;
+        break;
+    }
+
+    return ret;
+}
+
+/*
+ * Local variables:
+ * mode: C
+ * c-file-style: "BSD"
+ * c-basic-offset: 4
+ * tab-width: 4
+ * indent-tabs-mode: nil
+ * End:
+ */
diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h
index 6b5a5f818a..d46c61fca9 100644
--- a/xen/include/public/arch-arm.h
+++ b/xen/include/public/arch-arm.h
@@ -107,7 +107,9 @@
  *   All generic sub-operations
  *
  *  HYPERVISOR_physdev_op
- *   No sub-operations are currenty supported
+ *   Exactly these sub-operations are supported:
+ *   PHYSDEVOP_pci_device_add
+ *   PHYSDEVOP_pci_device_remove
  *
  *  HYPERVISOR_sysctl
  *   All generic sub-operations, with the exception of:
diff --git a/xen/include/xen/hypercall.h b/xen/include/xen/hypercall.h
index 3771487a30..7096cc4fe4 100644
--- a/xen/include/xen/hypercall.h
+++ b/xen/include/xen/hypercall.h
@@ -45,6 +45,17 @@ extern long
 do_platform_op(
     XEN_GUEST_HANDLE_PARAM(xen_platform_op_t) u_xenpf_op);
 
+#ifdef CONFIG_HAS_PCI
+extern long
+pci_physdev_op(
+    int cmd, XEN_GUEST_HANDLE_PARAM(void) arg);
+#else
+static inline long pci_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
+{
+    gdprintk(XENLOG_DEBUG, "PHYSDEVOP cmd=%d: not implemented\n", cmd);
+    return -ENOSYS;
+}
+#endif
 /*
  * To allow safe resume of do_memory_op() after preemption, we need to know
  * at what point in the page list to resume. For this purpose I steal the
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Mon Oct 04 11:53:57 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Oct 2021 11:53:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.201321.355781 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXMXc-0002UE-Sx; Mon, 04 Oct 2021 11:53:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 201321.355781; Mon, 04 Oct 2021 11:53:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXMXc-0002U7-P6; Mon, 04 Oct 2021 11:53:56 +0000
Received: by outflank-mailman (input) for mailman id 201321;
 Mon, 04 Oct 2021 11:53:56 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=TJPG=OY=arm.com=rahul.singh@srs-us1.protection.inumbo.net>)
 id 1mXMXc-0002MH-3Y
 for xen-devel@lists.xenproject.org; Mon, 04 Oct 2021 11:53:56 +0000
Received: from foss.arm.com (unknown [217.140.110.172])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTP
 id befd8b32-2509-11ec-beab-12813bfff9fa;
 Mon, 04 Oct 2021 11:53:53 +0000 (UTC)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D781A1FB;
 Mon,  4 Oct 2021 04:53:52 -0700 (PDT)
Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com
 [10.1.199.62])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 6C3BE3F70D;
 Mon,  4 Oct 2021 04:53:51 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: befd8b32-2509-11ec-beab-12813bfff9fa
From: Rahul Singh <rahul.singh@arm.com>
To: xen-devel@lists.xenproject.org
Cc: bertrand.marquis@arm.com,
	rahul.singh@arm.com,
	Andre.Przywara@arm.com,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Ian Jackson <iwj@xenproject.org>,
	Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wl@xen.org>
Subject: [PATCH v4 04/14] xen/pci: Include asm/pci.h after pci_sbdf_t in xen/pci.h
Date: Mon,  4 Oct 2021 12:51:59 +0100
Message-Id: <32f30d33e93a971ad748ff8857567846be5c9e31.1633340795.git.rahul.singh@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <cover.1633340795.git.rahul.singh@arm.com>
References: <cover.1633340795.git.rahul.singh@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Prototypes declared in asm/pci.h that take argument of type pci_sbdf_t
are included in xen/pci.h before defining pci_sbdf_t.

Include asm/pci.h after pci_sbdf_t in xen/pci.h to fix the issue.

Signed-off-by: Rahul Singh <rahul.singh@arm.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
---
Change in v4: Added in this version
---
---
 xen/include/xen/pci.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/xen/include/xen/pci.h b/xen/include/xen/pci.h
index 8e3d4d9454..70ac25345c 100644
--- a/xen/include/xen/pci.h
+++ b/xen/include/xen/pci.h
@@ -15,7 +15,6 @@
 #include <xen/pfn.h>
 #include <asm/device.h>
 #include <asm/numa.h>
-#include <asm/pci.h>
 
 /*
  * The PCI interface treats multi-function devices as independent
@@ -62,6 +61,8 @@ typedef union {
     };
 } pci_sbdf_t;
 
+#include <asm/pci.h>
+
 struct pci_dev_info {
     /*
      * VF's 'is_extfn' field is used to indicate whether its PF is an extended
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Mon Oct 04 11:54:11 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Oct 2021 11:54:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.201323.355791 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXMXr-00031O-3u; Mon, 04 Oct 2021 11:54:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 201323.355791; Mon, 04 Oct 2021 11:54:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXMXr-00031B-0g; Mon, 04 Oct 2021 11:54:11 +0000
Received: by outflank-mailman (input) for mailman id 201323;
 Mon, 04 Oct 2021 11:54:10 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=TJPG=OY=arm.com=rahul.singh@srs-us1.protection.inumbo.net>)
 id 1mXMXp-0002zQ-VJ
 for xen-devel@lists.xenproject.org; Mon, 04 Oct 2021 11:54:09 +0000
Received: from foss.arm.com (unknown [217.140.110.172])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTP
 id c877973e-2509-11ec-beab-12813bfff9fa;
 Mon, 04 Oct 2021 11:54:09 +0000 (UTC)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C24AC1FB;
 Mon,  4 Oct 2021 04:54:08 -0700 (PDT)
Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com
 [10.1.199.62])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C1CFB3F70D;
 Mon,  4 Oct 2021 04:54:07 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c877973e-2509-11ec-beab-12813bfff9fa
From: Rahul Singh <rahul.singh@arm.com>
To: xen-devel@lists.xenproject.org
Cc: bertrand.marquis@arm.com,
	rahul.singh@arm.com,
	Andre.Przywara@arm.com,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: [PATCH v4 05/14] xen/arm: Add support for PCI init to initialize the PCI driver.
Date: Mon,  4 Oct 2021 12:52:00 +0100
Message-Id: <ad94a4a8ed1cf313a97baecd2bfad108821416bf.1633340795.git.rahul.singh@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <cover.1633340795.git.rahul.singh@arm.com>
References: <cover.1633340795.git.rahul.singh@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

pci_init(..) will be called during xen startup to initialize and probe
the PCI host-bridge driver.

Signed-off-by: Rahul Singh <rahul.singh@arm.com>
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>
---
Change in v4:
- Added Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>
- Added Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
Change in v3:
- Some nit for device_init(..) return logic
- Remove inline from acpi_pci_init(..)
- Modify return value for apci_pci_init(..) to return -EOPNOTSUPP
Change in v2:
- ACPI init function to return int
- pci_segments_init() called before dt/acpi init
---
---
 xen/arch/arm/pci/pci.c       | 51 ++++++++++++++++++++++++++++++++++++
 xen/include/asm-arm/device.h |  1 +
 2 files changed, 52 insertions(+)

diff --git a/xen/arch/arm/pci/pci.c b/xen/arch/arm/pci/pci.c
index a7a7bc3213..e359bab9ea 100644
--- a/xen/arch/arm/pci/pci.c
+++ b/xen/arch/arm/pci/pci.c
@@ -12,6 +12,10 @@
  * along with this program.  If not, see <http://www.gnu.org/licenses/>.
  */
 
+#include <xen/acpi.h>
+#include <xen/device_tree.h>
+#include <xen/errno.h>
+#include <xen/init.h>
 #include <xen/pci.h>
 
 /*
@@ -22,6 +26,53 @@ int arch_pci_clean_pirqs(struct domain *d)
     return 0;
 }
 
+static int __init dt_pci_init(void)
+{
+    struct dt_device_node *np;
+    int rc;
+
+    dt_for_each_device_node(dt_host, np)
+    {
+        rc = device_init(np, DEVICE_PCI, NULL);
+        /*
+         * Ignore the following error codes:
+         *   - EBADF: Indicate the current device is not a pci device.
+         *   - ENODEV: The pci device is not present or cannot be used by
+         *     Xen.
+         */
+        if( !rc || rc == -EBADF || rc == -ENODEV )
+            continue;
+
+        return rc;
+    }
+
+    return 0;
+}
+
+#ifdef CONFIG_ACPI
+static int __init acpi_pci_init(void)
+{
+    printk(XENLOG_ERR "ACPI pci init not supported \n");
+    return -EOPNOTSUPP;
+}
+#else
+static int __init acpi_pci_init(void)
+{
+    return -EINVAL;
+}
+#endif
+
+static int __init pci_init(void)
+{
+    pci_segments_init();
+
+    if ( acpi_disabled )
+        return dt_pci_init();
+    else
+        return acpi_pci_init();
+}
+__initcall(pci_init);
+
 /*
  * Local variables:
  * mode: C
diff --git a/xen/include/asm-arm/device.h b/xen/include/asm-arm/device.h
index ee7cff2d44..5ecd5e7bd1 100644
--- a/xen/include/asm-arm/device.h
+++ b/xen/include/asm-arm/device.h
@@ -34,6 +34,7 @@ enum device_class
     DEVICE_SERIAL,
     DEVICE_IOMMU,
     DEVICE_GIC,
+    DEVICE_PCI,
     /* Use for error */
     DEVICE_UNKNOWN,
 };
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Mon Oct 04 11:54:39 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Oct 2021 11:54:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.201336.355802 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXMYJ-0003mH-Cd; Mon, 04 Oct 2021 11:54:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 201336.355802; Mon, 04 Oct 2021 11:54:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXMYJ-0003mA-9e; Mon, 04 Oct 2021 11:54:39 +0000
Received: by outflank-mailman (input) for mailman id 201336;
 Mon, 04 Oct 2021 11:54:38 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=TJPG=OY=arm.com=rahul.singh@srs-us1.protection.inumbo.net>)
 id 1mXMYI-0003lY-5C
 for xen-devel@lists.xenproject.org; Mon, 04 Oct 2021 11:54:38 +0000
Received: from foss.arm.com (unknown [217.140.110.172])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTP
 id d93d11a3-2509-11ec-beab-12813bfff9fa;
 Mon, 04 Oct 2021 11:54:37 +0000 (UTC)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0CC88D6E;
 Mon,  4 Oct 2021 04:54:37 -0700 (PDT)
Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com
 [10.1.199.62])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 6002D3F70D;
 Mon,  4 Oct 2021 04:54:35 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d93d11a3-2509-11ec-beab-12813bfff9fa
From: Rahul Singh <rahul.singh@arm.com>
To: xen-devel@lists.xenproject.org
Cc: bertrand.marquis@arm.com,
	rahul.singh@arm.com,
	Andre.Przywara@arm.com,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Ian Jackson <iwj@xenproject.org>,
	Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wl@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>
Subject: [PATCH v4 06/14] xen/arm: Add cmdline boot option "pci-passthrough = <boolean>"
Date: Mon,  4 Oct 2021 12:52:01 +0100
Message-Id: <0e0454c55a6b41db8bc71e4158f0036f746d6f97.1633340795.git.rahul.singh@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <cover.1633340795.git.rahul.singh@arm.com>
References: <cover.1633340795.git.rahul.singh@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Add cmdline boot option "pci-passthrough = = <boolean>" to enable or
disable the PCI passthrough support on ARM.

Signed-off-by: Rahul Singh <rahul.singh@arm.com>
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>
---
Change in v4:
- Fixe minor comments
- Added Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>
- Added Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
Change in v3:
- Remove "define pci_passthrough_enabled (false)"
- Fixed coding style and minor comment
Change in v2:
- Add option in xen-command-line.pandoc
- Change pci option to pci-passthrough
- modify option from custom_param to boolean param
---
---
 docs/misc/xen-command-line.pandoc |  7 +++++++
 xen/arch/arm/pci/pci.c            | 12 ++++++++++++
 xen/drivers/pci/physdev.c         |  6 ++++++
 xen/include/asm-arm/pci.h         | 11 +++++++++++
 xen/include/asm-x86/pci.h         |  6 ++++++
 5 files changed, 42 insertions(+)

diff --git a/docs/misc/xen-command-line.pandoc b/docs/misc/xen-command-line.pandoc
index 5cae4adc58..b1f7978aa4 100644
--- a/docs/misc/xen-command-line.pandoc
+++ b/docs/misc/xen-command-line.pandoc
@@ -1819,6 +1819,13 @@ All numbers specified must be hexadecimal ones.
 
 This option can be specified more than once (up to 8 times at present).
 
+### pci-passthrough (arm)
+> `= <boolean>`
+
+> Default: `false`
+
+Flag to enable or disable support for PCI passthrough
+
 ### pcid (x86)
 > `= <boolean> | xpti=<bool>`
 
diff --git a/xen/arch/arm/pci/pci.c b/xen/arch/arm/pci/pci.c
index e359bab9ea..73540045d1 100644
--- a/xen/arch/arm/pci/pci.c
+++ b/xen/arch/arm/pci/pci.c
@@ -16,6 +16,7 @@
 #include <xen/device_tree.h>
 #include <xen/errno.h>
 #include <xen/init.h>
+#include <xen/param.h>
 #include <xen/pci.h>
 
 /*
@@ -62,8 +63,19 @@ static int __init acpi_pci_init(void)
 }
 #endif
 
+/* By default pci passthrough is disabled. */
+bool __read_mostly pci_passthrough_enabled;
+boolean_param("pci-passthrough", pci_passthrough_enabled);
+
 static int __init pci_init(void)
 {
+    /*
+     * Enable PCI passthrough when has been enabled explicitly
+     * (pci-passthrough=on).
+     */
+    if ( !pci_passthrough_enabled )
+        return 0;
+
     pci_segments_init();
 
     if ( acpi_disabled )
diff --git a/xen/drivers/pci/physdev.c b/xen/drivers/pci/physdev.c
index 4f3e1a96c0..42db3e6d13 100644
--- a/xen/drivers/pci/physdev.c
+++ b/xen/drivers/pci/physdev.c
@@ -18,6 +18,9 @@ ret_t pci_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
         struct pci_dev_info pdev_info;
         nodeid_t node = NUMA_NO_NODE;
 
+        if ( !is_pci_passthrough_enabled() )
+            return -EOPNOTSUPP;
+
         ret = -EFAULT;
         if ( copy_from_guest(&add, arg, 1) != 0 )
             break;
@@ -53,6 +56,9 @@ ret_t pci_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
     case PHYSDEVOP_pci_device_remove: {
         struct physdev_pci_device dev;
 
+        if ( !is_pci_passthrough_enabled() )
+            return -EOPNOTSUPP;
+
         ret = -EFAULT;
         if ( copy_from_guest(&dev, arg, 1) != 0 )
             break;
diff --git a/xen/include/asm-arm/pci.h b/xen/include/asm-arm/pci.h
index 7dd9eb3dba..0cf849e26f 100644
--- a/xen/include/asm-arm/pci.h
+++ b/xen/include/asm-arm/pci.h
@@ -19,14 +19,25 @@
 
 #define pci_to_dev(pcidev) (&(pcidev)->arch.dev)
 
+extern bool_t pci_passthrough_enabled;
+
 /* Arch pci dev struct */
 struct arch_pci_dev {
     struct device dev;
 };
 
+static always_inline bool is_pci_passthrough_enabled(void)
+{
+    return pci_passthrough_enabled;
+}
 #else   /*!CONFIG_HAS_PCI*/
 
 struct arch_pci_dev { };
 
+static always_inline bool is_pci_passthrough_enabled(void)
+{
+    return false;
+}
+
 #endif  /*!CONFIG_HAS_PCI*/
 #endif /* __ARM_PCI_H__ */
diff --git a/xen/include/asm-x86/pci.h b/xen/include/asm-x86/pci.h
index cc05045e9c..e076951032 100644
--- a/xen/include/asm-x86/pci.h
+++ b/xen/include/asm-x86/pci.h
@@ -32,4 +32,10 @@ bool_t pci_ro_mmcfg_decode(unsigned long mfn, unsigned int *seg,
 extern int pci_mmcfg_config_num;
 extern struct acpi_mcfg_allocation *pci_mmcfg_config;
 
+/* Unlike ARM, PCI passthrough is always enabled for x86. */
+static always_inline bool is_pci_passthrough_enabled(void)
+{
+    return true;
+}
+
 #endif /* __X86_PCI_H__ */
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Mon Oct 04 11:55:14 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Oct 2021 11:55:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.201345.355814 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXMYr-0004Or-NO; Mon, 04 Oct 2021 11:55:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 201345.355814; Mon, 04 Oct 2021 11:55:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXMYr-0004Ok-Jo; Mon, 04 Oct 2021 11:55:13 +0000
Received: by outflank-mailman (input) for mailman id 201345;
 Mon, 04 Oct 2021 11:55:12 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=TJPG=OY=arm.com=rahul.singh@srs-us1.protection.inumbo.net>)
 id 1mXMYq-0004Ls-8w
 for xen-devel@lists.xenproject.org; Mon, 04 Oct 2021 11:55:12 +0000
Received: from foss.arm.com (unknown [217.140.110.172])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTP
 id e983768c-2509-11ec-beab-12813bfff9fa;
 Mon, 04 Oct 2021 11:55:04 +0000 (UTC)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2D4A1D6E;
 Mon,  4 Oct 2021 04:55:04 -0700 (PDT)
Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com
 [10.1.199.62])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 102F83F70D;
 Mon,  4 Oct 2021 04:55:02 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e983768c-2509-11ec-beab-12813bfff9fa
From: Rahul Singh <rahul.singh@arm.com>
To: xen-devel@lists.xenproject.org
Cc: bertrand.marquis@arm.com,
	rahul.singh@arm.com,
	Andre.Przywara@arm.com,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: [PATCH v4 07/14] xen/arm: PCI host bridge discovery within XEN on ARM
Date: Mon,  4 Oct 2021 12:52:02 +0100
Message-Id: <ac38f0d1b590686bbf55aa779108f7ce850dba93.1633340795.git.rahul.singh@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <cover.1633340795.git.rahul.singh@arm.com>
References: <cover.1633340795.git.rahul.singh@arm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

XEN during boot will read the PCI device tree node “reg” property
and will map the PCI config space to the XEN memory.

As of now only "pci-host-ecam-generic" compatible board is supported.

"linux,pci-domain" device tree property assigns a fixed PCI domain
number to a host bridge, otherwise an unstable (across boots) unique
number will be assigned by Linux. XEN access the PCI devices based on
Segment:Bus:Device:Function. A Segment number in the XEN is same as a
domain number in Linux. Segment number and domain number has to be in
sync to access the correct PCI devices.

XEN will read the “linux,pci-domain” property from the device tree node
and configure the host bridge segment number accordingly. If this
property is not available XEN will allocate the unique segment number
to the host bridge.

Signed-off-by: Rahul Singh <rahul.singh@arm.com>
---
Chane in v4:
- Move "#include <asm/pci.h>" in "xen/pci.h" after pci_sbdf_t
  sbdf declaration change to separate patch.
- Make gen_pci_dt_match as __initconstrel
- Make pci_host_generic_probe as __init
Change in v3:
- Modify commit msg based on received comments.
- Remove added struct match_table{} struct in struct device{}
- Replace uint32_t sbdf to pci_sbdf_t sbdf to avoid typecast
- Remove bus_start,bus_end and void *sysdata from struct pci_host_bridge{}
- Move "#include <asm/pci.h>" in "xen/pci.h" after pci_sbdf_t sbdf declaration
- Add pci_host_generic_probe() function
Change in v2:
- Add more info in commit msg
- Add callback to parse register index.
- Merge patch pci_ecam_operation into this patch to avoid confusion
- Add new struct in struct device for match table
---
---
 xen/arch/arm/pci/Makefile           |   4 +
 xen/arch/arm/pci/ecam.c             |  61 +++++++
 xen/arch/arm/pci/pci-access.c       |  83 ++++++++++
 xen/arch/arm/pci/pci-host-common.c  | 247 ++++++++++++++++++++++++++++
 xen/arch/arm/pci/pci-host-generic.c |  48 ++++++
 xen/include/asm-arm/pci.h           |  56 +++++++
 6 files changed, 499 insertions(+)
 create mode 100644 xen/arch/arm/pci/ecam.c
 create mode 100644 xen/arch/arm/pci/pci-access.c
 create mode 100644 xen/arch/arm/pci/pci-host-common.c
 create mode 100644 xen/arch/arm/pci/pci-host-generic.c

diff --git a/xen/arch/arm/pci/Makefile b/xen/arch/arm/pci/Makefile
index a98035df4c..6f32fbbe67 100644
--- a/xen/arch/arm/pci/Makefile
+++ b/xen/arch/arm/pci/Makefile
@@ -1 +1,5 @@
 obj-y += pci.o
+obj-y += pci-access.o
+obj-y += pci-host-generic.o
+obj-y += pci-host-common.o
+obj-y += ecam.o
diff --git a/xen/arch/arm/pci/ecam.c b/xen/arch/arm/pci/ecam.c
new file mode 100644
index 0000000000..602d00799c
--- /dev/null
+++ b/xen/arch/arm/pci/ecam.c
@@ -0,0 +1,61 @@
+/*
+ * Based on Linux drivers/pci/ecam.c
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ */
+
+#include <xen/pci.h>
+#include <xen/sched.h>
+
+/*
+ * Function to implement the pci_ops->map_bus method.
+ */
+void __iomem *pci_ecam_map_bus(struct pci_host_bridge *bridge,
+                               pci_sbdf_t sbdf, uint32_t where)
+{
+    const struct pci_config_window *cfg = bridge->cfg;
+    struct pci_ecam_ops *ops =
+        container_of(bridge->ops, struct pci_ecam_ops, pci_ops);
+    unsigned int devfn_shift = ops->bus_shift - 8;
+    void __iomem *base;
+
+    unsigned int busn = PCI_BUS(sbdf.bdf);
+
+    if ( busn < cfg->busn_start || busn > cfg->busn_end )
+        return NULL;
+
+    busn -= cfg->busn_start;
+    base = cfg->win + (busn << ops->bus_shift);
+
+    return base + (PCI_DEVFN2(sbdf.bdf) << devfn_shift) + where;
+}
+
+/* ECAM ops */
+const struct pci_ecam_ops pci_generic_ecam_ops = {
+    .bus_shift  = 20,
+    .pci_ops    = {
+        .map_bus                = pci_ecam_map_bus,
+        .read                   = pci_generic_config_read,
+        .write                  = pci_generic_config_write,
+    }
+};
+
+/*
+ * Local variables:
+ * mode: C
+ * c-file-style: "BSD"
+ * c-basic-offset: 4
+ * tab-width: 4
+ * indent-tabs-mode: nil
+ * End:
+ */
diff --git a/xen/arch/arm/pci/pci-access.c b/xen/arch/arm/pci/pci-access.c
new file mode 100644
index 0000000000..3cd14a4b87
--- /dev/null
+++ b/xen/arch/arm/pci/pci-access.c
@@ -0,0 +1,83 @@
+/*
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ */
+
+#include <xen/pci.h>
+#include <asm/io.h>
+
+#define INVALID_VALUE (~0U)
+
+int pci_generic_config_read(struct pci_host_bridge *bridge, pci_sbdf_t sbdf,
+                            uint32_t reg, uint32_t len, uint32_t *value)
+{
+    void __iomem *addr = bridge->ops->map_bus(bridge, sbdf, reg);
+
+    if ( !addr )
+    {
+        *value = INVALID_VALUE;
+        return -ENODEV;
+    }
+
+    switch ( len )
+    {
+    case 1:
+        *value = readb(addr);
+        break;
+    case 2:
+        *value = readw(addr);
+        break;
+    case 4:
+        *value = readl(addr);
+        break;
+    default:
+        ASSERT_UNREACHABLE();
+    }
+
+    return 0;
+}
+
+int pci_generic_config_write(struct pci_host_bridge *bridge, pci_sbdf_t sbdf,
+                             uint32_t reg, uint32_t len, uint32_t value)
+{
+    void __iomem *addr = bridge->ops->map_bus(bridge, sbdf, reg);
+
+    if ( !addr )
+        return -ENODEV;
+
+    switch ( len )
+    {
+    case 1:
+        writeb(value, addr);
+        break;
+    case 2:
+        writew(value, addr);
+        break;
+    case 4:
+        writel(value, addr);
+        break;
+    default:
+        ASSERT_UNREACHABLE();
+    }
+
+    return 0;
+}
+
+/*
+ * Local variables:
+ * mode: C
+ * c-file-style: "BSD"
+ * c-basic-offset: 4
+ * tab-width: 4
+ * indent-tabs-mode: nil
+ * End:
+ */
diff --git a/xen/arch/arm/pci/pci-host-common.c b/xen/arch/arm/pci/pci-host-common.c
new file mode 100644
index 0000000000..a08e06cea1
--- /dev/null
+++ b/xen/arch/arm/pci/pci-host-common.c
@@ -0,0 +1,247 @@
+/*
+ * Based on Linux drivers/pci/ecam.c
+ * Based on Linux drivers/pci/controller/pci-host-common.c
+ * Based on Linux drivers/pci/controller/pci-host-generic.c
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ */
+
+#include <xen/init.h>
+#include <xen/pci.h>
+#include <xen/rwlock.h>
+#include <xen/sched.h>
+#include <xen/vmap.h>
+
+/*
+ * List for all the pci host bridges.
+ */
+
+static LIST_HEAD(pci_host_bridges);
+
+static atomic_t domain_nr = ATOMIC_INIT(-1);
+
+static inline void __iomem *pci_remap_cfgspace(paddr_t start, size_t len)
+{
+    return ioremap_nocache(start, len);
+}
+
+static void pci_ecam_free(struct pci_config_window *cfg)
+{
+    if ( cfg->win )
+        iounmap(cfg->win);
+
+    xfree(cfg);
+}
+
+static struct pci_config_window * __init
+gen_pci_init(struct dt_device_node *dev, const struct pci_ecam_ops *ops)
+{
+    int err, cfg_reg_idx;
+    u32 bus_range[2];
+    paddr_t addr, size;
+    struct pci_config_window *cfg;
+
+    cfg = xzalloc(struct pci_config_window);
+    if ( !cfg )
+        return NULL;
+
+    err = dt_property_read_u32_array(dev, "bus-range", bus_range,
+                                     ARRAY_SIZE(bus_range));
+    if ( err ) {
+        cfg->busn_start = 0;
+        cfg->busn_end = 0xff;
+        printk(XENLOG_INFO "%s: No bus range found for pci controller\n",
+               dt_node_full_name(dev));
+    } else {
+        cfg->busn_start = bus_range[0];
+        cfg->busn_end = bus_range[1];
+        if ( cfg->busn_end > cfg->busn_start + 0xff )
+            cfg->busn_end = cfg->busn_start + 0xff;
+    }
+
+    if ( ops->cfg_reg_index )
+    {
+        cfg_reg_idx = ops->cfg_reg_index(dev);
+        if ( cfg_reg_idx < 0 )
+            goto err_exit;
+    }
+    else
+        cfg_reg_idx = 0;
+
+    /* Parse our PCI ecam register address */
+    err = dt_device_get_address(dev, cfg_reg_idx, &addr, &size);
+    if ( err )
+        goto err_exit;
+
+    cfg->phys_addr = addr;
+    cfg->size = size;
+
+    /*
+     * On 64-bit systems, we do a single ioremap for the whole config space
+     * since we have enough virtual address range available.  On 32-bit, we
+     * ioremap the config space for each bus individually.
+     * As of now only 64-bit is supported 32-bit is not supported.
+     *
+     * TODO: For 32-bit implement the ioremap/iounmap of config space
+     * dynamically for each read/write call.
+     */
+    cfg->win = pci_remap_cfgspace(cfg->phys_addr, cfg->size);
+    if ( !cfg->win )
+    {
+        printk(XENLOG_ERR "ECAM ioremap failed\n");
+        goto err_exit;
+    }
+    printk("ECAM at [mem 0x%"PRIpaddr"-0x%"PRIpaddr"] for [bus %x-%x] \n",
+            cfg->phys_addr, cfg->phys_addr + cfg->size - 1,
+            cfg->busn_start, cfg->busn_end);
+
+    if ( ops->init )
+    {
+        err = ops->init(cfg);
+        if ( err )
+            goto err_exit;
+    }
+
+    return cfg;
+
+err_exit:
+    pci_ecam_free(cfg);
+
+    return NULL;
+}
+
+struct pci_host_bridge *pci_alloc_host_bridge(void)
+{
+    struct pci_host_bridge *bridge = xzalloc(struct pci_host_bridge);
+
+    if ( !bridge )
+        return NULL;
+
+    INIT_LIST_HEAD(&bridge->node);
+
+    return bridge;
+}
+
+void pci_add_host_bridge(struct pci_host_bridge *bridge)
+{
+    list_add_tail(&bridge->node, &pci_host_bridges);
+}
+
+static int pci_get_new_domain_nr(void)
+{
+    return atomic_inc_return(&domain_nr);
+}
+
+static int pci_bus_find_domain_nr(struct dt_device_node *dev)
+{
+    static int use_dt_domains = -1;
+    int domain;
+
+    domain = dt_get_pci_domain_nr(dev);
+
+    /*
+     * Check DT domain and use_dt_domains values.
+     *
+     * If DT domain property is valid (domain >= 0) and
+     * use_dt_domains != 0, the DT assignment is valid since this means
+     * we have not previously allocated a domain number by using
+     * pci_get_new_domain_nr(); we should also update use_dt_domains to
+     * 1, to indicate that we have just assigned a domain number from
+     * DT.
+     *
+     * If DT domain property value is not valid (ie domain < 0), and we
+     * have not previously assigned a domain number from DT
+     * (use_dt_domains != 1) we should assign a domain number by
+     * using the:
+     *
+     * pci_get_new_domain_nr()
+     *
+     * API and update the use_dt_domains value to keep track of method we
+     * are using to assign domain numbers (use_dt_domains = 0).
+     *
+     * All other combinations imply we have a platform that is trying
+     * to mix domain numbers obtained from DT and pci_get_new_domain_nr(),
+     * which is a recipe for domain mishandling and it is prevented by
+     * invalidating the domain value (domain = -1) and printing a
+     * corresponding error.
+     */
+    if ( domain >= 0 && use_dt_domains )
+    {
+        use_dt_domains = 1;
+    }
+    else if ( domain < 0 && use_dt_domains != 1 )
+    {
+        use_dt_domains = 0;
+        domain = pci_get_new_domain_nr();
+    }
+    else
+    {
+        domain = -1;
+    }
+
+    return domain;
+}
+
+int pci_host_common_probe(struct dt_device_node *dev, const void *data)
+{
+    struct pci_host_bridge *bridge;
+    struct pci_config_window *cfg;
+    struct pci_ecam_ops *ops;
+    int err;
+
+    if ( dt_device_for_passthrough(dev) )
+        return 0;
+
+    ops = (struct pci_ecam_ops *) data;
+
+    bridge = pci_alloc_host_bridge();
+    if ( !bridge )
+        return -ENOMEM;
+
+    /* Parse and map our Configuration Space windows */
+    cfg = gen_pci_init(dev, ops);
+    if ( !cfg )
+    {
+        err = -ENOMEM;
+        goto err_exit;
+    }
+
+    bridge->dt_node = dev;
+    bridge->cfg = cfg;
+    bridge->ops = &ops->pci_ops;
+
+    bridge->segment = pci_bus_find_domain_nr(dev);
+    if ( bridge->segment < 0 )
+    {
+        printk(XENLOG_ERR "Inconsistent \"linux,pci-domain\" property in DT\n");
+        BUG();
+    }
+    pci_add_host_bridge(bridge);
+
+    return 0;
+
+err_exit:
+    xfree(bridge);
+
+    return err;
+}
+
+/*
+ * Local variables:
+ * mode: C
+ * c-file-style: "BSD"
+ * c-basic-offset: 4
+ * tab-width: 4
+ * indent-tabs-mode: nil
+ * End:
+ */
diff --git a/xen/arch/arm/pci/pci-host-generic.c b/xen/arch/arm/pci/pci-host-generic.c
new file mode 100644
index 0000000000..33457fbe96
--- /dev/null
+++ b/xen/arch/arm/pci/pci-host-generic.c
@@ -0,0 +1,48 @@
+/*
+ * Based on Linux drivers/pci/controller/pci-host-common.c
+ * Based on Linux drivers/pci/controller/pci-host-generic.c
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ */
+
+#include <xen/init.h>
+#include <xen/pci.h>
+#include <asm/device.h>
+#include <asm/pci.h>
+
+static const struct dt_device_match __initconstrel gen_pci_dt_match[] =
+{
+    { .compatible = "pci-host-ecam-generic" },
+    { },
+};
+
+static int __init pci_host_generic_probe(struct dt_device_node *dev,
+                                         const void *data)
+{
+    return pci_host_common_probe(dev, &pci_generic_ecam_ops);
+}
+
+DT_DEVICE_START(pci_gen, "PCI HOST GENERIC", DEVICE_PCI)
+.dt_match = gen_pci_dt_match,
+.init = pci_host_generic_probe,
+DT_DEVICE_END
+
+/*
+ * Local variables:
+ * mode: C
+ * c-file-style: "BSD"
+ * c-basic-offset: 4
+ * tab-width: 4
+ * indent-tabs-mode: nil
+ * End:
+ */
diff --git a/xen/include/asm-arm/pci.h b/xen/include/asm-arm/pci.h
index 0cf849e26f..bb7eda6705 100644
--- a/xen/include/asm-arm/pci.h
+++ b/xen/include/asm-arm/pci.h
@@ -26,6 +26,62 @@ struct arch_pci_dev {
     struct device dev;
 };
 
+/*
+ * struct to hold the mappings of a config space window. This
+ * is expected to be used as sysdata for PCI controllers that
+ * use ECAM.
+ */
+struct pci_config_window {
+    paddr_t         phys_addr;
+    paddr_t         size;
+    uint8_t         busn_start;
+    uint8_t         busn_end;
+    void __iomem    *win;
+};
+
+/*
+ * struct to hold pci host bridge information
+ * for a PCI controller.
+ */
+struct pci_host_bridge {
+    struct dt_device_node *dt_node;  /* Pointer to the associated DT node */
+    struct list_head node;           /* Node in list of host bridges */
+    uint16_t segment;                /* Segment number */
+    struct pci_config_window* cfg;   /* Pointer to the bridge config window */
+    struct pci_ops *ops;
+};
+
+struct pci_ops {
+    void __iomem *(*map_bus)(struct pci_host_bridge *bridge, pci_sbdf_t sbdf,
+                             uint32_t offset);
+    int (*read)(struct pci_host_bridge *bridge, pci_sbdf_t sbdf,
+                uint32_t reg, uint32_t len, uint32_t *value);
+    int (*write)(struct pci_host_bridge *bridge, pci_sbdf_t sbdf,
+                 uint32_t reg, uint32_t len, uint32_t value);
+};
+
+/*
+ * struct to hold pci ops and bus shift of the config window
+ * for a PCI controller.
+ */
+struct pci_ecam_ops {
+    unsigned int            bus_shift;
+    struct pci_ops          pci_ops;
+    int (*cfg_reg_index)(struct dt_device_node *dev);
+    int (*init)(struct pci_config_window *);
+};
+
+/* Default ECAM ops */
+extern const struct pci_ecam_ops pci_generic_ecam_ops;
+
+int pci_host_common_probe(struct dt_device_node *dev, const void *data);
+int pci_generic_config_read(struct pci_host_bridge *bridge, pci_sbdf_t sbdf,
+                            uint32_t reg, uint32_t len, uint32_t *value);
+int pci_generic_config_write(struct pci_host_bridge *bridge, pci_sbdf_t sbdf,
+                             uint32_t reg, uint32_t len, uint32_t value);
+void __iomem *pci_ecam_map_bus(struct pci_host_bridge *bridge,
+                               pci_sbdf_t sbdf, uint32_t where);
+
 static always_inline bool is_pci_passthrough_enabled(void)
 {
     return pci_passthrough_enabled;
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Mon Oct 04 11:55:24 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Oct 2021 11:55:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.201349.355825 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXMZ2-0004nR-6y; Mon, 04 Oct 2021 11:55:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 201349.355825; Mon, 04 Oct 2021 11:55:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXMZ2-0004nG-3b; Mon, 04 Oct 2021 11:55:24 +0000
Received: by outflank-mailman (input) for mailman id 201349;
 Mon, 04 Oct 2021 11:55:23 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=TJPG=OY=arm.com=rahul.singh@srs-us1.protection.inumbo.net>)
 id 1mXMZ1-0004iv-4U
 for xen-devel@lists.xenproject.org; Mon, 04 Oct 2021 11:55:23 +0000
Received: from foss.arm.com (unknown [217.140.110.172])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTP
 id f371b6b8-5f2a-431f-b039-ac925266b2ff;
 Mon, 04 Oct 2021 11:55:21 +0000 (UTC)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 66BE3D6E;
 Mon,  4 Oct 2021 04:55:21 -0700 (PDT)
Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com
 [10.1.199.62])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4B6F13F70D;
 Mon,  4 Oct 2021 04:55:20 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f371b6b8-5f2a-431f-b039-ac925266b2ff
From: Rahul Singh <rahul.singh@arm.com>
To: xen-devel@lists.xenproject.org
Cc: bertrand.marquis@arm.com,
	rahul.singh@arm.com,
	Andre.Przywara@arm.com,
	Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: [PATCH v4 08/14] xen/arm: Add support for Xilinx ZynqMP PCI host controller
Date: Mon,  4 Oct 2021 12:52:03 +0100
Message-Id: <0d4157f3446a974cc69005b9ea0d5b1716e78f41.1633340795.git.rahul.singh@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <cover.1633340795.git.rahul.singh@arm.com>
References: <cover.1633340795.git.rahul.singh@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>

Add support for Xilinx ZynqMP PCI host controller to map the PCI config
space to the XEN memory.

Patch helps to understand how the generic infrastructure for PCI
host-bridge discovery will be used for future references.

Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Signed-off-by: Rahul Singh <rahul.singh@arm.com>
Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>
---
Change in v4:
- Add __initconstrel and __init for struct and functions
- Added Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>
Change in v3:
- nwl_cfg_reg_index(..) as static function
- Add support for pci_host_generic_probe()
Change in v2:
- Add more info in commit msg
---
---
 xen/arch/arm/pci/Makefile          |  1 +
 xen/arch/arm/pci/pci-host-zynqmp.c | 65 ++++++++++++++++++++++++++++++
 2 files changed, 66 insertions(+)
 create mode 100644 xen/arch/arm/pci/pci-host-zynqmp.c

diff --git a/xen/arch/arm/pci/Makefile b/xen/arch/arm/pci/Makefile
index 6f32fbbe67..1d045ade01 100644
--- a/xen/arch/arm/pci/Makefile
+++ b/xen/arch/arm/pci/Makefile
@@ -3,3 +3,4 @@ obj-y += pci-access.o
 obj-y += pci-host-generic.o
 obj-y += pci-host-common.o
 obj-y += ecam.o
+obj-y += pci-host-zynqmp.o
diff --git a/xen/arch/arm/pci/pci-host-zynqmp.c b/xen/arch/arm/pci/pci-host-zynqmp.c
new file mode 100644
index 0000000000..61a9807d3d
--- /dev/null
+++ b/xen/arch/arm/pci/pci-host-zynqmp.c
@@ -0,0 +1,65 @@
+/*
+ * Based on Linux drivers/pci/controller/pci-host-common.c
+ * Based on Linux drivers/pci/controller/pci-host-generic.c
+ * Based on xen/arch/arm/pci/pci-host-generic.c
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ */
+
+#include <xen/init.h>
+#include <xen/pci.h>
+#include <asm/device.h>
+#include <asm/pci.h>
+
+static int __init nwl_cfg_reg_index(struct dt_device_node *np)
+{
+    return dt_property_match_string(np, "reg-names", "cfg");
+}
+
+/* ECAM ops */
+const struct pci_ecam_ops nwl_pcie_ops = {
+    .bus_shift  = 20,
+    .cfg_reg_index = nwl_cfg_reg_index,
+    .pci_ops    = {
+        .map_bus                = pci_ecam_map_bus,
+        .read                   = pci_generic_config_read,
+        .write                  = pci_generic_config_write,
+    }
+};
+
+static const struct dt_device_match __initconstrel nwl_pcie_dt_match[] =
+{
+    { .compatible = "xlnx,nwl-pcie-2.11" },
+    { },
+};
+
+static int __init pci_host_generic_probe(struct dt_device_node *dev,
+                                         const void *data)
+{
+    return pci_host_common_probe(dev, &nwl_pcie_ops);
+}
+
+DT_DEVICE_START(pci_gen, "PCI HOST ZYNQMP", DEVICE_PCI)
+.dt_match = nwl_pcie_dt_match,
+.init = pci_host_generic_probe,
+DT_DEVICE_END
+
+/*
+ * Local variables:
+ * mode: C
+ * c-file-style: "BSD"
+ * c-basic-offset: 4
+ * tab-width: 4
+ * indent-tabs-mode: nil
+ * End:
+ */
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Mon Oct 04 11:55:59 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Oct 2021 11:55:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.201360.355836 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXMZb-0005fd-Gy; Mon, 04 Oct 2021 11:55:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 201360.355836; Mon, 04 Oct 2021 11:55:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXMZb-0005fW-Ds; Mon, 04 Oct 2021 11:55:59 +0000
Received: by outflank-mailman (input) for mailman id 201360;
 Mon, 04 Oct 2021 11:55:57 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=TJPG=OY=arm.com=rahul.singh@srs-us1.protection.inumbo.net>)
 id 1mXMZZ-0005fB-Oc
 for xen-devel@lists.xenproject.org; Mon, 04 Oct 2021 11:55:57 +0000
Received: from foss.arm.com (unknown [217.140.110.172])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTP
 id 08b95a08-250a-11ec-beab-12813bfff9fa;
 Mon, 04 Oct 2021 11:55:56 +0000 (UTC)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 91079D6E;
 Mon,  4 Oct 2021 04:55:56 -0700 (PDT)
Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com
 [10.1.199.62])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 8561F3F70D;
 Mon,  4 Oct 2021 04:55:55 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 08b95a08-250a-11ec-beab-12813bfff9fa
From: Rahul Singh <rahul.singh@arm.com>
To: xen-devel@lists.xenproject.org
Cc: bertrand.marquis@arm.com,
	rahul.singh@arm.com,
	Andre.Przywara@arm.com,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: [PATCH v4 09/14] xen/arm: Implement pci access functions
Date: Mon,  4 Oct 2021 12:52:04 +0100
Message-Id: <041f428f49f9168fb2e69993fff787740ddca970.1633340795.git.rahul.singh@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <cover.1633340795.git.rahul.singh@arm.com>
References: <cover.1633340795.git.rahul.singh@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Implement generic pci access functions to read/write the configuration
space.

Signed-off-by: Rahul Singh <rahul.singh@arm.com>
Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
---
Change in v4:
- Added Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
- Added Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>
Change in v3:
- Remove PRI_pci as not used.
- Replace uint32_t sbdf to pci_sbdf_t sbdf to avoid typecast
Change in v2: Fixed comments
---
---
 xen/arch/arm/pci/pci-access.c      | 57 ++++++++++++++++++++++++++++++
 xen/arch/arm/pci/pci-host-common.c | 19 ++++++++++
 xen/include/asm-arm/pci.h          |  1 +
 3 files changed, 77 insertions(+)

diff --git a/xen/arch/arm/pci/pci-access.c b/xen/arch/arm/pci/pci-access.c
index 3cd14a4b87..9f9aac43d7 100644
--- a/xen/arch/arm/pci/pci-access.c
+++ b/xen/arch/arm/pci/pci-access.c
@@ -16,6 +16,7 @@
 #include <asm/io.h>
 
 #define INVALID_VALUE (~0U)
+#define PCI_ERR_VALUE(len) GENMASK(0, len * 8)
 
 int pci_generic_config_read(struct pci_host_bridge *bridge, pci_sbdf_t sbdf,
                             uint32_t reg, uint32_t len, uint32_t *value)
@@ -72,6 +73,62 @@ int pci_generic_config_write(struct pci_host_bridge *bridge, pci_sbdf_t sbdf,
     return 0;
 }
 
+static uint32_t pci_config_read(pci_sbdf_t sbdf, unsigned int reg,
+                                unsigned int len)
+{
+    uint32_t val = PCI_ERR_VALUE(len);
+    struct pci_host_bridge *bridge = pci_find_host_bridge(sbdf.seg, sbdf.bus);
+
+    if ( unlikely(!bridge) )
+        return val;
+
+    if ( unlikely(!bridge->ops->read) )
+        return val;
+
+    bridge->ops->read(bridge, sbdf, reg, len, &val);
+
+    return val;
+}
+
+static void pci_config_write(pci_sbdf_t sbdf, unsigned int reg,
+                             unsigned int len, uint32_t val)
+{
+    struct pci_host_bridge *bridge = pci_find_host_bridge(sbdf.seg, sbdf.bus);
+
+    if ( unlikely(!bridge) )
+        return;
+
+    if ( unlikely(!bridge->ops->write) )
+        return;
+
+    bridge->ops->write(bridge, sbdf, reg, len, val);
+}
+
+/*
+ * Wrappers for all PCI configuration access functions.
+ */
+
+#define PCI_OP_WRITE(size, type)                            \
+    void pci_conf_write##size(pci_sbdf_t sbdf,              \
+                              unsigned int reg, type val)   \
+{                                                           \
+    pci_config_write(sbdf, reg, size / 8, val);             \
+}
+
+#define PCI_OP_READ(size, type)                             \
+    type pci_conf_read##size(pci_sbdf_t sbdf,               \
+                              unsigned int reg)             \
+{                                                           \
+    return pci_config_read(sbdf, reg, size / 8);            \
+}
+
+PCI_OP_READ(8, uint8_t)
+PCI_OP_READ(16, uint16_t)
+PCI_OP_READ(32, uint32_t)
+PCI_OP_WRITE(8, uint8_t)
+PCI_OP_WRITE(16, uint16_t)
+PCI_OP_WRITE(32, uint32_t)
+
 /*
  * Local variables:
  * mode: C
diff --git a/xen/arch/arm/pci/pci-host-common.c b/xen/arch/arm/pci/pci-host-common.c
index a08e06cea1..c5941b10e9 100644
--- a/xen/arch/arm/pci/pci-host-common.c
+++ b/xen/arch/arm/pci/pci-host-common.c
@@ -236,6 +236,25 @@ err_exit:
     return err;
 }
 
+/*
+ * This function will lookup an hostbridge based on the segment and bus
+ * number.
+ */
+struct pci_host_bridge *pci_find_host_bridge(uint16_t segment, uint8_t bus)
+{
+    struct pci_host_bridge *bridge;
+
+    list_for_each_entry( bridge, &pci_host_bridges, node )
+    {
+        if ( bridge->segment != segment )
+            continue;
+        if ( (bus < bridge->cfg->busn_start) || (bus > bridge->cfg->busn_end) )
+            continue;
+        return bridge;
+    }
+
+    return NULL;
+}
 /*
  * Local variables:
  * mode: C
diff --git a/xen/include/asm-arm/pci.h b/xen/include/asm-arm/pci.h
index bb7eda6705..49c9622902 100644
--- a/xen/include/asm-arm/pci.h
+++ b/xen/include/asm-arm/pci.h
@@ -81,6 +81,7 @@ int pci_generic_config_write(struct pci_host_bridge *bridge, pci_sbdf_t sbdf,
                              uint32_t reg, uint32_t len, uint32_t value);
 void __iomem *pci_ecam_map_bus(struct pci_host_bridge *bridge,
                                pci_sbdf_t sbdf, uint32_t where);
+struct pci_host_bridge *pci_find_host_bridge(uint16_t segment, uint8_t bus);
 
 static always_inline bool is_pci_passthrough_enabled(void)
 {
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Mon Oct 04 11:56:45 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Oct 2021 11:56:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.201370.355847 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXMaK-0006KQ-RB; Mon, 04 Oct 2021 11:56:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 201370.355847; Mon, 04 Oct 2021 11:56:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXMaK-0006KJ-N7; Mon, 04 Oct 2021 11:56:44 +0000
Received: by outflank-mailman (input) for mailman id 201370;
 Mon, 04 Oct 2021 11:56:43 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=TJPG=OY=arm.com=rahul.singh@srs-us1.protection.inumbo.net>)
 id 1mXMaI-0006Jn-V8
 for xen-devel@lists.xenproject.org; Mon, 04 Oct 2021 11:56:42 +0000
Received: from foss.arm.com (unknown [217.140.110.172])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTP
 id 1f972611-3141-4d9f-b216-6868f93f684d;
 Mon, 04 Oct 2021 11:56:40 +0000 (UTC)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9E438D6E;
 Mon,  4 Oct 2021 04:56:40 -0700 (PDT)
Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com
 [10.1.199.62])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id BC3D93F70D;
 Mon,  4 Oct 2021 04:56:38 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1f972611-3141-4d9f-b216-6868f93f684d
From: Rahul Singh <rahul.singh@arm.com>
To: xen-devel@lists.xenproject.org
Cc: bertrand.marquis@arm.com,
	rahul.singh@arm.com,
	Andre.Przywara@arm.com,
	Christian Lindig <christian.lindig@citrix.com>,
	David Scott <dave@recoil.org>,
	Ian Jackson <iwj@xenproject.org>,
	Wei Liu <wl@xen.org>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>
Subject: [PATCH v4 10/14] xen/domctl: Introduce XEN_DOMCTL_CDF_vpci flag
Date: Mon,  4 Oct 2021 12:52:05 +0100
Message-Id: <f22c06abf5faa0a2f9c044f5b4009a99d7942215.1633340795.git.rahul.singh@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <cover.1633340795.git.rahul.singh@arm.com>
References: <cover.1633340795.git.rahul.singh@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Introduce XEN_DOMCTL_CDF_vpci flag to enable VPCI support in XEN.
Reject the use of this new flag for x86 as VPCI is not supported for
DOMU guests for x86.

Signed-off-by: Rahul Singh <rahul.singh@arm.com>
---
Change in v4: Added in this version
---
---
 tools/ocaml/libs/xc/xenctrl.ml  | 1 +
 tools/ocaml/libs/xc/xenctrl.mli | 1 +
 xen/arch/arm/domain.c           | 4 ++--
 xen/arch/x86/domain.c           | 6 ++++++
 xen/common/domain.c             | 2 +-
 xen/include/public/domctl.h     | 4 +++-
 6 files changed, 14 insertions(+), 4 deletions(-)

diff --git a/tools/ocaml/libs/xc/xenctrl.ml b/tools/ocaml/libs/xc/xenctrl.ml
index a5588c643f..7ed1c00e47 100644
--- a/tools/ocaml/libs/xc/xenctrl.ml
+++ b/tools/ocaml/libs/xc/xenctrl.ml
@@ -69,6 +69,7 @@ type domain_create_flag =
 	| CDF_XS_DOMAIN
 	| CDF_IOMMU
 	| CDF_NESTED_VIRT
+	| CDF_VPCI
 
 type domain_create_iommu_opts =
 	| IOMMU_NO_SHAREPT
diff --git a/tools/ocaml/libs/xc/xenctrl.mli b/tools/ocaml/libs/xc/xenctrl.mli
index 6e94940a8a..391d4abdf8 100644
--- a/tools/ocaml/libs/xc/xenctrl.mli
+++ b/tools/ocaml/libs/xc/xenctrl.mli
@@ -62,6 +62,7 @@ type domain_create_flag =
   | CDF_XS_DOMAIN
   | CDF_IOMMU
   | CDF_NESTED_VIRT
+  | CDF_VPCI
 
 type domain_create_iommu_opts =
   | IOMMU_NO_SHAREPT
diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
index 19c756ac3d..36138c1b2e 100644
--- a/xen/arch/arm/domain.c
+++ b/xen/arch/arm/domain.c
@@ -622,8 +622,8 @@ int arch_sanitise_domain_config(struct xen_domctl_createdomain *config)
 {
     unsigned int max_vcpus;
 
-    /* HVM and HAP must be set. IOMMU may or may not be */
-    if ( (config->flags & ~XEN_DOMCTL_CDF_iommu) !=
+    /* HVM and HAP must be set. IOMMU and VPCI may or may not be */
+    if ( (config->flags & ~XEN_DOMCTL_CDF_iommu & ~XEN_DOMCTL_CDF_vpci) !=
          (XEN_DOMCTL_CDF_hvm | XEN_DOMCTL_CDF_hap) )
     {
         dprintk(XENLOG_INFO, "Unsupported configuration %#x\n",
diff --git a/xen/arch/x86/domain.c b/xen/arch/x86/domain.c
index ef1812dc14..79c2aa4636 100644
--- a/xen/arch/x86/domain.c
+++ b/xen/arch/x86/domain.c
@@ -662,6 +662,12 @@ int arch_sanitise_domain_config(struct xen_domctl_createdomain *config)
         return -EINVAL;
     }
 
+    if ( config->flags & XEN_DOMCTL_CDF_vpci )
+    {
+        dprintk(XENLOG_INFO, "vPCI cannot be enabled yet\n");
+        return -EINVAL;
+    }
+
     if ( config->vmtrace_size )
     {
         unsigned int size = config->vmtrace_size;
diff --git a/xen/common/domain.c b/xen/common/domain.c
index 6ee5d033b0..40d67ec342 100644
--- a/xen/common/domain.c
+++ b/xen/common/domain.c
@@ -483,7 +483,7 @@ static int sanitise_domain_config(struct xen_domctl_createdomain *config)
          ~(XEN_DOMCTL_CDF_hvm | XEN_DOMCTL_CDF_hap |
            XEN_DOMCTL_CDF_s3_integrity | XEN_DOMCTL_CDF_oos_off |
            XEN_DOMCTL_CDF_xs_domain | XEN_DOMCTL_CDF_iommu |
-           XEN_DOMCTL_CDF_nested_virt) )
+           XEN_DOMCTL_CDF_nested_virt | XEN_DOMCTL_CDF_vpci) )
     {
         dprintk(XENLOG_INFO, "Unknown CDF flags %#x\n", config->flags);
         return -EINVAL;
diff --git a/xen/include/public/domctl.h b/xen/include/public/domctl.h
index 96696e3842..4245da3f45 100644
--- a/xen/include/public/domctl.h
+++ b/xen/include/public/domctl.h
@@ -70,9 +70,11 @@ struct xen_domctl_createdomain {
 #define XEN_DOMCTL_CDF_iommu          (1U<<_XEN_DOMCTL_CDF_iommu)
 #define _XEN_DOMCTL_CDF_nested_virt   6
 #define XEN_DOMCTL_CDF_nested_virt    (1U << _XEN_DOMCTL_CDF_nested_virt)
+#define _XEN_DOMCTL_CDF_vpci          7
+#define XEN_DOMCTL_CDF_vpci           (1U << _XEN_DOMCTL_CDF_vpci)
 
 /* Max XEN_DOMCTL_CDF_* constant.  Used for ABI checking. */
-#define XEN_DOMCTL_CDF_MAX XEN_DOMCTL_CDF_nested_virt
+#define XEN_DOMCTL_CDF_MAX XEN_DOMCTL_CDF_vpci
 
     uint32_t flags;
 
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Mon Oct 04 11:57:34 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Oct 2021 11:57:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.201378.355858 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXMb8-00070U-5Z; Mon, 04 Oct 2021 11:57:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 201378.355858; Mon, 04 Oct 2021 11:57:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXMb8-00070N-1M; Mon, 04 Oct 2021 11:57:34 +0000
Received: by outflank-mailman (input) for mailman id 201378;
 Mon, 04 Oct 2021 11:57:32 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=TJPG=OY=arm.com=rahul.singh@srs-us1.protection.inumbo.net>)
 id 1mXMb6-0006zq-Rg
 for xen-devel@lists.xenproject.org; Mon, 04 Oct 2021 11:57:32 +0000
Received: from foss.arm.com (unknown [217.140.110.172])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTP
 id db4b6544-c31e-4f0d-84dd-2883e49dd428;
 Mon, 04 Oct 2021 11:57:31 +0000 (UTC)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D0678D6E;
 Mon,  4 Oct 2021 04:57:30 -0700 (PDT)
Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com
 [10.1.199.62])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0D4D53F70D;
 Mon,  4 Oct 2021 04:57:28 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: db4b6544-c31e-4f0d-84dd-2883e49dd428
From: Rahul Singh <rahul.singh@arm.com>
To: xen-devel@lists.xenproject.org
Cc: bertrand.marquis@arm.com,
	rahul.singh@arm.com,
	Andre.Przywara@arm.com,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Ian Jackson <iwj@xenproject.org>,
	Jan Beulich <jbeulich@suse.com>,
	Wei Liu <wl@xen.org>,
	Paul Durrant <paul@xen.org>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>
Subject: [PATCH v4 11/14] xen/arm: Enable the existing x86 virtual PCI support for ARM.
Date: Mon,  4 Oct 2021 12:52:06 +0100
Message-Id: <f093de681c2560a7196895bcd666ef8840885c1d.1633340795.git.rahul.singh@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <cover.1633340795.git.rahul.singh@arm.com>
References: <cover.1633340795.git.rahul.singh@arm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The existing VPCI support available for X86 is adapted for Arm.
When the device is added to XEN via the hyper call
“PHYSDEVOP_pci_device_add”, VPCI handler for the config space
access is added to the Xen to emulate the PCI devices config space.

A MMIO trap handler for the PCI ECAM space is registered in XEN
so that when guest is trying to access the PCI config space,XEN
will trap the access and emulate read/write using the VPCI and
not the real PCI hardware.

For Dom0less systems scan_pci_devices() would be used to discover the
PCI device in XEN and VPCI handler will be added during XEN boots.

Signed-off-by: Rahul Singh <rahul.singh@arm.com>
---
Change in v4:
- Move addition of XEN_DOMCTL_CDF_vpci flag to separate patch
Change in v3:
- Use is_pci_passthrough_enabled() in place of pci_passthrough_enabled variable
- Reject XEN_DOMCTL_CDF_vpci for x86 in arch_sanitise_domain_config()
- Remove IS_ENABLED(CONFIG_HAS_VPCI) from has_vpci()
Change in v2:
- Add new XEN_DOMCTL_CDF_vpci flag
- modify has_vpci() to include XEN_DOMCTL_CDF_vpci
- enable vpci support when pci-passthough option is enabled.
---
---
 xen/arch/arm/Makefile         |   1 +
 xen/arch/arm/domain.c         |   4 ++
 xen/arch/arm/domain_build.c   |   3 +
 xen/arch/arm/vpci.c           | 102 ++++++++++++++++++++++++++++++++++
 xen/arch/arm/vpci.h           |  36 ++++++++++++
 xen/drivers/passthrough/pci.c |  17 ++++++
 xen/include/asm-arm/domain.h  |   7 ++-
 xen/include/asm-x86/pci.h     |   2 -
 xen/include/public/arch-arm.h |   7 +++
 xen/include/xen/pci.h         |   2 +
 10 files changed, 178 insertions(+), 3 deletions(-)
 create mode 100644 xen/arch/arm/vpci.c
 create mode 100644 xen/arch/arm/vpci.h

diff --git a/xen/arch/arm/Makefile b/xen/arch/arm/Makefile
index 44d7cc81fa..fb9c976ea2 100644
--- a/xen/arch/arm/Makefile
+++ b/xen/arch/arm/Makefile
@@ -7,6 +7,7 @@ ifneq ($(CONFIG_NO_PLAT),y)
 obj-y += platforms/
 endif
 obj-$(CONFIG_TEE) += tee/
+obj-$(CONFIG_HAS_VPCI) += vpci.o
 
 obj-$(CONFIG_HAS_ALTERNATIVE) += alternative.o
 obj-y += bootfdt.init.o
diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
index 36138c1b2e..fbb52f78f1 100644
--- a/xen/arch/arm/domain.c
+++ b/xen/arch/arm/domain.c
@@ -39,6 +39,7 @@
 #include <asm/vgic.h>
 #include <asm/vtimer.h>
 
+#include "vpci.h"
 #include "vuart.h"
 
 DEFINE_PER_CPU(struct vcpu *, curr_vcpu);
@@ -767,6 +768,9 @@ int arch_domain_create(struct domain *d,
     if ( is_hardware_domain(d) && (rc = domain_vuart_init(d)) )
         goto fail;
 
+    if ( (rc = domain_vpci_init(d)) != 0 )
+        goto fail;
+
     return 0;
 
 fail:
diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
index c5afbe2e05..f4c89bde8c 100644
--- a/xen/arch/arm/domain_build.c
+++ b/xen/arch/arm/domain_build.c
@@ -3053,6 +3053,9 @@ void __init create_dom0(void)
     if ( iommu_enabled )
         dom0_cfg.flags |= XEN_DOMCTL_CDF_iommu;
 
+    if ( is_pci_passthrough_enabled() )
+        dom0_cfg.flags |= XEN_DOMCTL_CDF_vpci;
+
     dom0 = domain_create(0, &dom0_cfg, true);
     if ( IS_ERR(dom0) || (alloc_dom0_vcpu0(dom0) == NULL) )
         panic("Error creating domain 0\n");
diff --git a/xen/arch/arm/vpci.c b/xen/arch/arm/vpci.c
new file mode 100644
index 0000000000..76c12b9281
--- /dev/null
+++ b/xen/arch/arm/vpci.c
@@ -0,0 +1,102 @@
+/*
+ * xen/arch/arm/vpci.c
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+#include <xen/sched.h>
+
+#include <asm/mmio.h>
+
+#define REGISTER_OFFSET(addr)  ( (addr) & 0x00000fff)
+
+/* Do some sanity checks. */
+static bool vpci_mmio_access_allowed(unsigned int reg, unsigned int len)
+{
+    /* Check access size. */
+    if ( len > 8 )
+        return false;
+
+    /* Check that access is size aligned. */
+    if ( (reg & (len - 1)) )
+        return false;
+
+    return true;
+}
+
+static int vpci_mmio_read(struct vcpu *v, mmio_info_t *info,
+                          register_t *r, void *p)
+{
+    unsigned int reg;
+    pci_sbdf_t sbdf;
+    unsigned long data = ~0UL;
+    unsigned int size = 1U << info->dabt.size;
+
+    sbdf.sbdf = MMCFG_BDF(info->gpa);
+    reg = REGISTER_OFFSET(info->gpa);
+
+    if ( !vpci_mmio_access_allowed(reg, size) )
+        return 0;
+
+    data = vpci_read(sbdf, reg, min(4u, size));
+    if ( size == 8 )
+        data |= (uint64_t)vpci_read(sbdf, reg + 4, 4) << 32;
+
+    *r = data;
+
+    return 1;
+}
+
+static int vpci_mmio_write(struct vcpu *v, mmio_info_t *info,
+                           register_t r, void *p)
+{
+    unsigned int reg;
+    pci_sbdf_t sbdf;
+    unsigned long data = r;
+    unsigned int size = 1U << info->dabt.size;
+
+    sbdf.sbdf = MMCFG_BDF(info->gpa);
+    reg = REGISTER_OFFSET(info->gpa);
+
+    if ( !vpci_mmio_access_allowed(reg, size) )
+        return 0;
+
+    vpci_write(sbdf, reg, min(4u, size), data);
+    if ( size == 8 )
+        vpci_write(sbdf, reg + 4, 4, data >> 32);
+
+    return 1;
+}
+
+static const struct mmio_handler_ops vpci_mmio_handler = {
+    .read  = vpci_mmio_read,
+    .write = vpci_mmio_write,
+};
+
+int domain_vpci_init(struct domain *d)
+{
+    if ( !has_vpci(d) )
+        return 0;
+
+    register_mmio_handler(d, &vpci_mmio_handler,
+                          GUEST_VPCI_ECAM_BASE, GUEST_VPCI_ECAM_SIZE, NULL);
+
+    return 0;
+}
+
+/*
+ * Local variables:
+ * mode: C
+ * c-file-style: "BSD"
+ * c-basic-offset: 4
+ * indent-tabs-mode: nil
+ * End:
+ */
+
diff --git a/xen/arch/arm/vpci.h b/xen/arch/arm/vpci.h
new file mode 100644
index 0000000000..d8a7b0e3e8
--- /dev/null
+++ b/xen/arch/arm/vpci.h
@@ -0,0 +1,36 @@
+/*
+ * xen/arch/arm/vpci.h
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+
+#ifndef __ARCH_ARM_VPCI_H__
+#define __ARCH_ARM_VPCI_H__
+
+#ifdef CONFIG_HAS_VPCI
+int domain_vpci_init(struct domain *d);
+#else
+static inline int domain_vpci_init(struct domain *d)
+{
+    return 0;
+}
+#endif
+
+#endif /* __ARCH_ARM_VPCI_H__ */
+
+/*
+ * Local variables:
+ * mode: C
+ * c-file-style: "BSD"
+ * c-basic-offset: 4
+ * indent-tabs-mode: nil
+ * End:
+ */
diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci.c
index e1b735d9e8..b36d5a4811 100644
--- a/xen/drivers/passthrough/pci.c
+++ b/xen/drivers/passthrough/pci.c
@@ -766,6 +766,23 @@ int pci_add_device(u16 seg, u8 bus, u8 devfn,
     else
         iommu_enable_device(pdev);
 
+#ifdef CONFIG_ARM
+    /*
+     * On ARM PCI devices discovery will be done by Dom0. Add vpci handler when
+     * Dom0 inform XEN to add the PCI devices in XEN.
+     */
+    ret = vpci_add_handlers(pdev);
+    if ( ret )
+    {
+        printk(XENLOG_ERR "setup of vPCI failed: %d\n", ret);
+        ret = iommu_remove_device(pdev);
+        if ( pdev->domain )
+            list_del(&pdev->domain_list);
+        free_pdev(pseg, pdev);
+        goto out;
+    }
+#endif
+
     pci_enable_acs(pdev);
 
 out:
diff --git a/xen/include/asm-arm/domain.h b/xen/include/asm-arm/domain.h
index c9277b5c6d..91d614b37e 100644
--- a/xen/include/asm-arm/domain.h
+++ b/xen/include/asm-arm/domain.h
@@ -2,6 +2,7 @@
 #define __ASM_DOMAIN_H__
 
 #include <xen/cache.h>
+#include <xen/nospec.h>
 #include <xen/timer.h>
 #include <asm/page.h>
 #include <asm/p2m.h>
@@ -262,7 +263,11 @@ static inline void arch_vcpu_block(struct vcpu *v) {}
 
 #define arch_vm_assist_valid_mask(d) (1UL << VMASST_TYPE_runstate_update_flag)
 
-#define has_vpci(d)    ({ (void)(d); false; })
+/*
+ * For X86 VPCI is enabled and tested for PVH DOM0 only but
+ * for ARM we enable support VPCI for guest domain also.
+ */
+#define has_vpci(d) evaluate_nospec((d)->options & XEN_DOMCTL_CDF_vpci)
 
 #endif /* __ASM_DOMAIN_H__ */
 
diff --git a/xen/include/asm-x86/pci.h b/xen/include/asm-x86/pci.h
index e076951032..c4a4fdcbc2 100644
--- a/xen/include/asm-x86/pci.h
+++ b/xen/include/asm-x86/pci.h
@@ -6,8 +6,6 @@
 #define CF8_ADDR_HI(cf8) (  ((cf8) & 0x0f000000) >> 16)
 #define CF8_ENABLED(cf8) (!!((cf8) & 0x80000000))
 
-#define MMCFG_BDF(addr)  ( ((addr) & 0x0ffff000) >> 12)
-
 #define IS_SNB_GFX(id) (id == 0x01068086 || id == 0x01168086 \
                         || id == 0x01268086 || id == 0x01028086 \
                         || id == 0x01128086 || id == 0x01228086 \
diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h
index d46c61fca9..44be337dec 100644
--- a/xen/include/public/arch-arm.h
+++ b/xen/include/public/arch-arm.h
@@ -418,6 +418,13 @@ typedef uint64_t xen_callback_t;
 #define GUEST_GICV3_GICR0_BASE     xen_mk_ullong(0x03020000) /* vCPU0..127 */
 #define GUEST_GICV3_GICR0_SIZE     xen_mk_ullong(0x01000000)
 
+/*
+ * 256 MB is reserved for VPCI configuration space based on calculation
+ * 256 buses × 32 devices × 8 functions × 4 KB = 256 MB
+ */
+#define GUEST_VPCI_ECAM_BASE    xen_mk_ullong(0x10000000)
+#define GUEST_VPCI_ECAM_SIZE    xen_mk_ullong(0x10000000)
+
 /* ACPI tables physical address */
 #define GUEST_ACPI_BASE xen_mk_ullong(0x20000000)
 #define GUEST_ACPI_SIZE xen_mk_ullong(0x02000000)
diff --git a/xen/include/xen/pci.h b/xen/include/xen/pci.h
index 70ac25345c..43b8a08170 100644
--- a/xen/include/xen/pci.h
+++ b/xen/include/xen/pci.h
@@ -40,6 +40,8 @@
 #define PCI_SBDF3(s,b,df) \
     ((pci_sbdf_t){ .sbdf = (((s) & 0xffff) << 16) | PCI_BDF2(b, df) })
 
+#define MMCFG_BDF(addr)  (((addr) & 0x0ffff000) >> 12)
+
 typedef union {
     uint32_t sbdf;
     struct {
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Mon Oct 04 11:57:47 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Oct 2021 11:57:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.201380.355869 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXMbH-0007NX-IL; Mon, 04 Oct 2021 11:57:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 201380.355869; Mon, 04 Oct 2021 11:57:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXMbH-0007NO-F6; Mon, 04 Oct 2021 11:57:43 +0000
Received: by outflank-mailman (input) for mailman id 201380;
 Mon, 04 Oct 2021 11:57:42 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=TJPG=OY=arm.com=rahul.singh@srs-us1.protection.inumbo.net>)
 id 1mXMbG-0007MT-Jc
 for xen-devel@lists.xenproject.org; Mon, 04 Oct 2021 11:57:42 +0000
Received: from foss.arm.com (unknown [217.140.110.172])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTP
 id 46a03865-250a-11ec-beab-12813bfff9fa;
 Mon, 04 Oct 2021 11:57:41 +0000 (UTC)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8EB0BD6E;
 Mon,  4 Oct 2021 04:57:41 -0700 (PDT)
Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com
 [10.1.199.62])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 716B83F70D;
 Mon,  4 Oct 2021 04:57:40 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 46a03865-250a-11ec-beab-12813bfff9fa
From: Rahul Singh <rahul.singh@arm.com>
To: xen-devel@lists.xenproject.org
Cc: bertrand.marquis@arm.com,
	rahul.singh@arm.com,
	Andre.Przywara@arm.com,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: [PATCH v4 12/14] xen/arm: Transitional change to build HAS_VPCI on ARM.
Date: Mon,  4 Oct 2021 12:52:07 +0100
Message-Id: <da9b11bf4ce9a2a34eeda8630b361f964b67d437.1633340795.git.rahul.singh@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <cover.1633340795.git.rahul.singh@arm.com>
References: <cover.1633340795.git.rahul.singh@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

This patch will be reverted once we add support for VPCI MSI/MSIX
support on ARM.

Signed-off-by: Rahul Singh <rahul.singh@arm.com>
Acked-by: Stefano Stabellini <sstabellini@kernel.org>
Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>
---
Change in v4:
- Added Acked-by: Stefano Stabellini <sstabellini@kernel.org>
- Added Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>
Change in v3: none
Change in v2: Patch introduced in v2
---
---
 xen/drivers/vpci/Makefile | 3 ++-
 xen/drivers/vpci/header.c | 2 ++
 xen/include/asm-arm/pci.h | 8 ++++++++
 3 files changed, 12 insertions(+), 1 deletion(-)

diff --git a/xen/drivers/vpci/Makefile b/xen/drivers/vpci/Makefile
index 55d1bdfda0..1a1413b93e 100644
--- a/xen/drivers/vpci/Makefile
+++ b/xen/drivers/vpci/Makefile
@@ -1 +1,2 @@
-obj-y += vpci.o header.o msi.o msix.o
+obj-y += vpci.o header.o
+obj-$(CONFIG_HAS_PCI_MSI) += msi.o msix.o
diff --git a/xen/drivers/vpci/header.c b/xen/drivers/vpci/header.c
index ba9a036202..f8cd55e7c0 100644
--- a/xen/drivers/vpci/header.c
+++ b/xen/drivers/vpci/header.c
@@ -96,8 +96,10 @@ static void modify_decoding(const struct pci_dev *pdev, uint16_t cmd,
      * FIXME: punching holes after the p2m has been set up might be racy for
      * DomU usage, needs to be revisited.
      */
+#ifdef CONFIG_HAS_PCI_MSI
     if ( map && !rom_only && vpci_make_msix_hole(pdev) )
         return;
+#endif
 
     for ( i = 0; i < ARRAY_SIZE(header->bars); i++ )
     {
diff --git a/xen/include/asm-arm/pci.h b/xen/include/asm-arm/pci.h
index 49c9622902..5532ce3977 100644
--- a/xen/include/asm-arm/pci.h
+++ b/xen/include/asm-arm/pci.h
@@ -26,6 +26,14 @@ struct arch_pci_dev {
     struct device dev;
 };
 
+/* Arch-specific MSI data for vPCI. */
+struct vpci_arch_msi {
+};
+
+/* Arch-specific MSI-X entry data for vPCI. */
+struct vpci_arch_msix_entry {
+};
+
 /*
  * struct to hold the mappings of a config space window. This
  * is expected to be used as sysdata for PCI controllers that
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Mon Oct 04 11:58:05 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Oct 2021 11:58:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.201390.355880 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXMbc-0008AB-Ra; Mon, 04 Oct 2021 11:58:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 201390.355880; Mon, 04 Oct 2021 11:58:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXMbc-0008A4-Ob; Mon, 04 Oct 2021 11:58:04 +0000
Received: by outflank-mailman (input) for mailman id 201390;
 Mon, 04 Oct 2021 11:58:03 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=TJPG=OY=arm.com=rahul.singh@srs-us1.protection.inumbo.net>)
 id 1mXMbb-00085s-OB
 for xen-devel@lists.xenproject.org; Mon, 04 Oct 2021 11:58:03 +0000
Received: from foss.arm.com (unknown [217.140.110.172])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTP
 id 53805712-250a-11ec-beab-12813bfff9fa;
 Mon, 04 Oct 2021 11:58:02 +0000 (UTC)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2282DD6E;
 Mon,  4 Oct 2021 04:58:02 -0700 (PDT)
Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com
 [10.1.199.62])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id AAB753F70D;
 Mon,  4 Oct 2021 04:58:00 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 53805712-250a-11ec-beab-12813bfff9fa
From: Rahul Singh <rahul.singh@arm.com>
To: xen-devel@lists.xenproject.org
Cc: bertrand.marquis@arm.com,
	rahul.singh@arm.com,
	Andre.Przywara@arm.com,
	Ian Jackson <iwj@xenproject.org>,
	Wei Liu <wl@xen.org>,
	Anthony PERARD <anthony.perard@citrix.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: [PATCH v4 13/14] arm/libxl: Emulated PCI device tree node in libxl
Date: Mon,  4 Oct 2021 12:52:08 +0100
Message-Id: <3ad42008f534671ae7f5b25da91253ce7cd4a3e9.1633340795.git.rahul.singh@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <cover.1633340795.git.rahul.singh@arm.com>
References: <cover.1633340795.git.rahul.singh@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

libxl will create an emulated PCI device tree node in the device tree to
enable the guest OS to discover the virtual PCI during guest boot.
Emulated PCI device tree node will only be created when there is any
device assigned to guest.

A new area has been reserved in the arm guest physical map at
which the VPCI bus is declared in the device tree (reg and ranges
parameters of the node).

Signed-off-by: Rahul Singh <rahul.singh@arm.com>
---
Change in v4:
- Gate code for x86 for setting the XEN_DOMCTL_CDF_vpci for x86.
Change in v3:
- Make GUEST_VPCI_MEM_ADDR address 2MB aligned
Change in v2:
- enable doamin_vpci_init() when XEN_DOMCTL_CDF_vpci is set for domain.
---
---
 tools/include/libxl.h            |   6 ++
 tools/libs/light/libxl_arm.c     | 105 +++++++++++++++++++++++++++++++
 tools/libs/light/libxl_create.c  |   9 +++
 tools/libs/light/libxl_types.idl |   1 +
 tools/xl/xl_parse.c              |   8 +++
 xen/include/public/arch-arm.h    |  10 +++
 6 files changed, 139 insertions(+)

diff --git a/tools/include/libxl.h b/tools/include/libxl.h
index b9ba16d698..3362073b21 100644
--- a/tools/include/libxl.h
+++ b/tools/include/libxl.h
@@ -358,6 +358,12 @@
  */
 #define LIBXL_HAVE_BUILDINFO_ARM_VUART 1
 
+/*
+ * LIBXL_HAVE_BUILDINFO_ARM_VPCI indicates that the toolstack supports virtual
+ * PCI for ARM.
+ */
+#define LIBXL_HAVE_BUILDINFO_ARM_VPCI 1
+
 /*
  * LIBXL_HAVE_BUILDINFO_GRANT_LIMITS indicates that libxl_domain_build_info
  * has the max_grant_frames and max_maptrack_frames fields.
diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c
index e3140a6e00..52f1ddce48 100644
--- a/tools/libs/light/libxl_arm.c
+++ b/tools/libs/light/libxl_arm.c
@@ -269,6 +269,58 @@ static int fdt_property_regs(libxl__gc *gc, void *fdt,
     return fdt_property(fdt, "reg", regs, sizeof(regs));
 }
 
+static int fdt_property_values(libxl__gc *gc, void *fdt,
+        const char *name, unsigned num_cells, ...)
+{
+    uint32_t prop[num_cells];
+    be32 *cells = &prop[0];
+    int i;
+    va_list ap;
+    uint32_t arg;
+
+    va_start(ap, num_cells);
+    for (i = 0 ; i < num_cells; i++) {
+        arg = va_arg(ap, uint32_t);
+        set_cell(&cells, 1, arg);
+    }
+    va_end(ap);
+
+    return fdt_property(fdt, name, prop, sizeof(prop));
+}
+
+static int fdt_property_vpci_ranges(libxl__gc *gc, void *fdt,
+                                    unsigned addr_cells,
+                                    unsigned size_cells,
+                                    unsigned num_regs, ...)
+{
+    uint32_t regs[num_regs*((addr_cells*2)+size_cells+1)];
+    be32 *cells = &regs[0];
+    int i;
+    va_list ap;
+    uint64_t arg;
+
+    va_start(ap, num_regs);
+    for (i = 0 ; i < num_regs; i++) {
+        /* Set the memory bit field */
+        arg = va_arg(ap, uint32_t);
+        set_cell(&cells, 1, arg);
+
+        /* Set the vpci bus address */
+        arg = addr_cells ? va_arg(ap, uint64_t) : 0;
+        set_cell(&cells, addr_cells , arg);
+
+        /* Set the cpu bus address where vpci address is mapped */
+        set_cell(&cells, addr_cells, arg);
+
+        /* Set the vpci size requested */
+        arg = size_cells ? va_arg(ap, uint64_t) : 0;
+        set_cell(&cells, size_cells, arg);
+    }
+    va_end(ap);
+
+    return fdt_property(fdt, "ranges", regs, sizeof(regs));
+}
+
 static int make_root_properties(libxl__gc *gc,
                                 const libxl_version_info *vers,
                                 void *fdt)
@@ -668,6 +720,53 @@ static int make_vpl011_uart_node(libxl__gc *gc, void *fdt,
     return 0;
 }
 
+static int make_vpci_node(libxl__gc *gc, void *fdt,
+        const struct arch_info *ainfo,
+        struct xc_dom_image *dom)
+{
+    int res;
+    const uint64_t vpci_ecam_base = GUEST_VPCI_ECAM_BASE;
+    const uint64_t vpci_ecam_size = GUEST_VPCI_ECAM_SIZE;
+    const char *name = GCSPRINTF("pcie@%"PRIx64, vpci_ecam_base);
+
+    res = fdt_begin_node(fdt, name);
+    if (res) return res;
+
+    res = fdt_property_compat(gc, fdt, 1, "pci-host-ecam-generic");
+    if (res) return res;
+
+    res = fdt_property_string(fdt, "device_type", "pci");
+    if (res) return res;
+
+    res = fdt_property_regs(gc, fdt, GUEST_ROOT_ADDRESS_CELLS,
+            GUEST_ROOT_SIZE_CELLS, 1, vpci_ecam_base, vpci_ecam_size);
+    if (res) return res;
+
+    res = fdt_property_values(gc, fdt, "bus-range", 2, 0, 255);
+    if (res) return res;
+
+    res = fdt_property_cell(fdt, "#address-cells", 3);
+    if (res) return res;
+
+    res = fdt_property_cell(fdt, "#size-cells", 2);
+    if (res) return res;
+
+    res = fdt_property_string(fdt, "status", "okay");
+    if (res) return res;
+
+    res = fdt_property_vpci_ranges(gc, fdt, GUEST_ROOT_ADDRESS_CELLS,
+        GUEST_ROOT_SIZE_CELLS, 2,
+        GUEST_VPCI_ADDR_TYPE_MEM, GUEST_VPCI_MEM_ADDR, GUEST_VPCI_MEM_SIZE,
+        GUEST_VPCI_ADDR_TYPE_PREFETCH_MEM, GUEST_VPCI_PREFETCH_MEM_ADDR,
+        GUEST_VPCI_PREFETCH_MEM_SIZE);
+    if (res) return res;
+
+    res = fdt_end_node(fdt);
+    if (res) return res;
+
+    return 0;
+}
+
 static const struct arch_info *get_arch_info(libxl__gc *gc,
                                              const struct xc_dom_image *dom)
 {
@@ -971,6 +1070,9 @@ next_resize:
         if (info->tee == LIBXL_TEE_TYPE_OPTEE)
             FDT( make_optee_node(gc, fdt) );
 
+        if (libxl_defbool_val(info->arch_arm.vpci))
+            FDT( make_vpci_node(gc, fdt, ainfo, dom) );
+
         if (pfdt)
             FDT( copy_partial_fdt(gc, fdt, pfdt) );
 
@@ -1189,6 +1291,9 @@ void libxl__arch_domain_build_info_setdefault(libxl__gc *gc,
     /* ACPI is disabled by default */
     libxl_defbool_setdefault(&b_info->acpi, false);
 
+    /* VPCI is disabled by default */
+    libxl_defbool_setdefault(&b_info->arch_arm.vpci, false);
+
     if (b_info->type != LIBXL_DOMAIN_TYPE_PV)
         return;
 
diff --git a/tools/libs/light/libxl_create.c b/tools/libs/light/libxl_create.c
index e356b2106d..9408526036 100644
--- a/tools/libs/light/libxl_create.c
+++ b/tools/libs/light/libxl_create.c
@@ -632,6 +632,15 @@ int libxl__domain_make(libxl__gc *gc, libxl_domain_config *d_config,
         if (info->passthrough == LIBXL_PASSTHROUGH_SYNC_PT)
             create.iommu_opts |= XEN_DOMCTL_IOMMU_no_sharept;
 
+#if defined(__arm__) || defined(__aarch64__)
+        /*
+         * Enable VPCI support for ARM. VPCI support for DOMU guest is not
+         * supported for x86.
+         */
+        if ( libxl_defbool_val(b_info->arch_arm.vpci) )
+            create.flags |= XEN_DOMCTL_CDF_vpci;
+#endif
+
         /* Ultimately, handle is an array of 16 uint8_t, same as uuid */
         libxl_uuid_copy(ctx, (libxl_uuid *)&create.handle, &info->uuid);
 
diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_types.idl
index 3f9fff653a..78b1ddf0b8 100644
--- a/tools/libs/light/libxl_types.idl
+++ b/tools/libs/light/libxl_types.idl
@@ -644,6 +644,7 @@ libxl_domain_build_info = Struct("domain_build_info",[
 
     ("arch_arm", Struct(None, [("gic_version", libxl_gic_version),
                                ("vuart", libxl_vuart_type),
+                               ("vpci", libxl_defbool),
                               ])),
     ("arch_x86", Struct(None, [("msr_relaxed", libxl_defbool),
                               ])),
diff --git a/tools/xl/xl_parse.c b/tools/xl/xl_parse.c
index 17dddb4cd5..576af67daa 100644
--- a/tools/xl/xl_parse.c
+++ b/tools/xl/xl_parse.c
@@ -1497,6 +1497,14 @@ void parse_config_data(const char *config_source,
         }
         if (d_config->num_pcidevs && c_info->type == LIBXL_DOMAIN_TYPE_PV)
             libxl_defbool_set(&b_info->u.pv.e820_host, true);
+#if defined(__arm__) || defined(__aarch64__)
+        /*
+         * Enable VPCI support for ARM. VPCI support for DOMU guest is not
+         * supported for x86.
+         */
+        if (d_config->num_pcidevs)
+            libxl_defbool_set(&b_info->arch_arm.vpci, true);
+#endif
     }
 
     if (!xlu_cfg_get_list (config, "dtdev", &dtdevs, 0, 0)) {
diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h
index 44be337dec..45aac5d18f 100644
--- a/xen/include/public/arch-arm.h
+++ b/xen/include/public/arch-arm.h
@@ -433,6 +433,11 @@ typedef uint64_t xen_callback_t;
 #define GUEST_PL011_BASE    xen_mk_ullong(0x22000000)
 #define GUEST_PL011_SIZE    xen_mk_ullong(0x00001000)
 
+/* Guest PCI-PCIe memory space where config space and BAR will be available.*/
+#define GUEST_VPCI_ADDR_TYPE_MEM            xen_mk_ullong(0x02000000)
+#define GUEST_VPCI_MEM_ADDR                 xen_mk_ullong(0x23000000)
+#define GUEST_VPCI_MEM_SIZE                 xen_mk_ullong(0x10000000)
+
 /*
  * 16MB == 4096 pages reserved for guest to use as a region to map its
  * grant table in.
@@ -448,6 +453,11 @@ typedef uint64_t xen_callback_t;
 #define GUEST_RAM0_BASE   xen_mk_ullong(0x40000000) /* 3GB of low RAM @ 1GB */
 #define GUEST_RAM0_SIZE   xen_mk_ullong(0xc0000000)
 
+/* 4GB @ 4GB Prefetch Memory for VPCI */
+#define GUEST_VPCI_ADDR_TYPE_PREFETCH_MEM   xen_mk_ullong(0x42000000)
+#define GUEST_VPCI_PREFETCH_MEM_ADDR        xen_mk_ullong(0x100000000)
+#define GUEST_VPCI_PREFETCH_MEM_SIZE        xen_mk_ullong(0x100000000)
+
 #define GUEST_RAM1_BASE   xen_mk_ullong(0x0200000000) /* 1016GB of RAM @ 8GB */
 #define GUEST_RAM1_SIZE   xen_mk_ullong(0xfe00000000)
 
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Mon Oct 04 11:58:10 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Oct 2021 11:58:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.201393.355891 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXMbi-0008Uf-4n; Mon, 04 Oct 2021 11:58:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 201393.355891; Mon, 04 Oct 2021 11:58:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXMbi-0008UY-1J; Mon, 04 Oct 2021 11:58:10 +0000
Received: by outflank-mailman (input) for mailman id 201393;
 Mon, 04 Oct 2021 11:58:08 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=TJPG=OY=arm.com=rahul.singh@srs-us1.protection.inumbo.net>)
 id 1mXMbg-0008TZ-SW
 for xen-devel@lists.xenproject.org; Mon, 04 Oct 2021 11:58:08 +0000
Received: from foss.arm.com (unknown [217.140.110.172])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTP
 id b60816e1-6511-4ec7-b41e-9c1873d76d34;
 Mon, 04 Oct 2021 11:58:07 +0000 (UTC)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 42C9BD6E;
 Mon,  4 Oct 2021 04:58:07 -0700 (PDT)
Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com
 [10.1.199.62])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 3FE313F70D;
 Mon,  4 Oct 2021 04:58:06 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b60816e1-6511-4ec7-b41e-9c1873d76d34
From: Rahul Singh <rahul.singh@arm.com>
To: xen-devel@lists.xenproject.org
Cc: bertrand.marquis@arm.com,
	rahul.singh@arm.com,
	Andre.Przywara@arm.com,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: [PATCH v4 14/14] xen/arm: Add linux,pci-domain property for hwdom if not available.
Date: Mon,  4 Oct 2021 12:52:09 +0100
Message-Id: <0def9a7fc9280d733b5a048572321bfeaf13a6d4.1633340795.git.rahul.singh@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <cover.1633340795.git.rahul.singh@arm.com>
References: <cover.1633340795.git.rahul.singh@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

If the property is not present in the device tree node for host bridge,
XEN while creating the dtb for hwdom will create this property and
assigns the already allocated segment to the host bridge
so that XEN and linux will have the same segment for the host bridges.

Signed-off-by: Rahul Singh <rahul.singh@arm.com>
Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
---
Change in v4:
- Added Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
- Added Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>
Change in v3:
- Use is_pci_passthrough_enabled()
Change in v2:
- Add linux,pci-domain only when pci-passthrough command line option is enabeld
---
---
 xen/arch/arm/domain_build.c        | 16 ++++++++++++++++
 xen/arch/arm/pci/pci-host-common.c | 21 +++++++++++++++++++++
 xen/include/asm-arm/pci.h          |  9 +++++++++
 3 files changed, 46 insertions(+)

diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
index f4c89bde8c..8739e3285e 100644
--- a/xen/arch/arm/domain_build.c
+++ b/xen/arch/arm/domain_build.c
@@ -747,6 +747,22 @@ static int __init write_properties(struct domain *d, struct kernel_info *kinfo,
             return res;
     }
 
+    if ( is_pci_passthrough_enabled() && dt_device_type_is_equal(node, "pci") )
+    {
+        if ( !dt_find_property(node, "linux,pci-domain", NULL) )
+        {
+            uint16_t segment;
+
+            res = pci_get_host_bridge_segment(node, &segment);
+            if ( res < 0 )
+                return res;
+
+            res = fdt_property_cell(kinfo->fdt, "linux,pci-domain", segment);
+            if ( res )
+                return res;
+        }
+    }
+
     /*
      * Override the property "status" to disable the device when it's
      * marked for passthrough.
diff --git a/xen/arch/arm/pci/pci-host-common.c b/xen/arch/arm/pci/pci-host-common.c
index c5941b10e9..593beeb48c 100644
--- a/xen/arch/arm/pci/pci-host-common.c
+++ b/xen/arch/arm/pci/pci-host-common.c
@@ -255,6 +255,27 @@ struct pci_host_bridge *pci_find_host_bridge(uint16_t segment, uint8_t bus)
 
     return NULL;
 }
+
+/*
+ * This function will lookup an hostbridge based on config space address.
+ */
+int pci_get_host_bridge_segment(const struct dt_device_node *node,
+                                uint16_t *segment)
+{
+    struct pci_host_bridge *bridge;
+
+    list_for_each_entry( bridge, &pci_host_bridges, node )
+    {
+        if ( bridge->dt_node != node )
+            continue;
+
+        *segment = bridge->segment;
+        return 0;
+    }
+
+    return -EINVAL;
+}
+
 /*
  * Local variables:
  * mode: C
diff --git a/xen/include/asm-arm/pci.h b/xen/include/asm-arm/pci.h
index 5532ce3977..7cb2e2f1ed 100644
--- a/xen/include/asm-arm/pci.h
+++ b/xen/include/asm-arm/pci.h
@@ -90,6 +90,8 @@ int pci_generic_config_write(struct pci_host_bridge *bridge, pci_sbdf_t sbdf,
 void __iomem *pci_ecam_map_bus(struct pci_host_bridge *bridge,
                                pci_sbdf_t sbdf, uint32_t where);
 struct pci_host_bridge *pci_find_host_bridge(uint16_t segment, uint8_t bus);
+int pci_get_host_bridge_segment(const struct dt_device_node *node,
+                                uint16_t *segment);
 
 static always_inline bool is_pci_passthrough_enabled(void)
 {
@@ -104,5 +106,12 @@ static always_inline bool is_pci_passthrough_enabled(void)
     return false;
 }
 
+static inline int pci_get_host_bridge_segment(const struct dt_device_node *node,
+                                              uint16_t *segment)
+{
+    ASSERT_UNREACHABLE();
+    return -EINVAL;
+}
+
 #endif  /*!CONFIG_HAS_PCI*/
 #endif /* __ARM_PCI_H__ */
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Mon Oct 04 12:08:49 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Oct 2021 12:08:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.201413.355902 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXMll-0002G7-Hs; Mon, 04 Oct 2021 12:08:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 201413.355902; Mon, 04 Oct 2021 12:08:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXMll-0002G0-Dj; Mon, 04 Oct 2021 12:08:33 +0000
Received: by outflank-mailman (input) for mailman id 201413;
 Mon, 04 Oct 2021 12:08:32 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=61te=OY=gmail.com=olekstysh@srs-us1.protection.inumbo.net>)
 id 1mXMlj-0002E4-VW
 for xen-devel@lists.xenproject.org; Mon, 04 Oct 2021 12:08:32 +0000
Received: from mail-lf1-x133.google.com (unknown [2a00:1450:4864:20::133])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 24f4cb74-99fd-41c8-ab81-0ff4b6c7b14b;
 Mon, 04 Oct 2021 12:08:29 +0000 (UTC)
Received: by mail-lf1-x133.google.com with SMTP id i24so22146933lfj.13
 for <xen-devel@lists.xenproject.org>; Mon, 04 Oct 2021 05:08:29 -0700 (PDT)
Received: from [192.168.1.7] ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id y11sm1589986ljn.138.2021.10.04.05.08.24
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Mon, 04 Oct 2021 05:08:24 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 24f4cb74-99fd-41c8-ab81-0ff4b6c7b14b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-transfer-encoding:content-language;
        bh=vYA2zzrCCOf293yZPTn09v4CFZYyOayDZz1LTSvf8VE=;
        b=S9f6LfDF3zdZCstfgNEW569lzCzz5LcWSGNrwM7L/E3HZ6a4+2ouww+FqdRq3uNxcg
         Uqs9WOuptL9fmgwYQ1RQNOucU1Ddn71Kt1Yz1iO/PQC7EpR6d8QnRVYa8+2SYvvQmLpf
         JHqUzazBDtwVsR4opVsQw28nHy2Rhkl60rzaSYmu6ljuwLAzbJOddpWXN3YgSafCeeZH
         UlFvxTEKVNZ591ur+N+0VTfYW5jQ0q+JBnIJEkUB58wujM5mhSYBPI1qS1wBXUg9cGyE
         CjfrQDeW5fHFFHbVirQICSIYoK0PHlfA2pB4YiO/iZzdTHxPBr9loPnB/2Gc2CB45lAU
         u9iA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding
         :content-language;
        bh=vYA2zzrCCOf293yZPTn09v4CFZYyOayDZz1LTSvf8VE=;
        b=uJd5aYbN5J/ETzLoT1olf3l7s6/vC5QBRIibYqpAA56CvHSYk8Tv3k/93Tb/TMsPyH
         K6AoiJyiKt9WOXFpM6A0VYWZBgltpEbJsLYYsFOskS2xMKrQp7CR2bLOwytj7udpBbPf
         S54KcXUKiphnOByOQQEeq27OL1QKU33/Otk2eRanleh1G/wrTl5n2juRrZdCBEtw0v+F
         inx/MiBIk4H515xhAGawOm/L8rhLcrLGHw+MLSCJFVCxIHOcJ2XnXK1Tp4wwsq9Umcts
         WP2BqwvR4oHfWI7TvfOPIe96JYsScc+b72FI8X5ODubCUcYIF0TV2BLoQZ6O92IgDpZU
         E2rQ==
X-Gm-Message-State: AOAM532lAouKyBUxCw9U+Ikb0f994WdnP2/Nbd6+4jdqh8djO924AURP
	L73xbuZUOeNSttPqzgXEjZY=
X-Google-Smtp-Source: ABdhPJxBqqjlvlI4/LORc5JeNdERztQ6JNvixI+BWhb7j8bPeD0Na5zThQDMnpNV3BTixvHtTLVHCA==
X-Received: by 2002:a2e:974b:: with SMTP id f11mr15259025ljj.385.1633349305244;
        Mon, 04 Oct 2021 05:08:25 -0700 (PDT)
Subject: Re: [PATCH V4 2/3] xen/arm: Add handling of extended regions for Dom0
To: Julien Grall <julien@xen.org>
Cc: xen-devel@lists.xenproject.org,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Jan Beulich <jbeulich@suse.com>, Stefano Stabellini
 <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <1632955927-27911-1-git-send-email-olekstysh@gmail.com>
 <1632955927-27911-3-git-send-email-olekstysh@gmail.com>
 <8318a7b0-80fa-ccd6-75c5-c3135b82235d@xen.org>
From: Oleksandr <olekstysh@gmail.com>
Message-ID: <20f00d52-76c8-2afe-6544-6f1396e121e9@gmail.com>
Date: Mon, 4 Oct 2021 15:08:23 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <8318a7b0-80fa-ccd6-75c5-c3135b82235d@xen.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US


On 04.10.21 09:59, Julien Grall wrote:
> Hi Oleksandr,

Hi Julien


>
> I saw Stefano committed this patch on Friday. However, I didn't have a 
> chance go to through a second time and would like to request some 
> follow-up changes.

ok, do you prefer the follow-up patch to be pushed separately or within 
the rest patches of this series (#1 and #3)?  If the former, I will try 
to push it today to close this question.


>
>
> On 30/09/2021 00:52, Oleksandr Tyshchenko wrote:
>> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>>
>> The extended region (safe range) is a region of guest physical
>> address space which is unused and could be safely used to create
>> grant/foreign mappings instead of wasting real RAM pages from
>> the domain memory for establishing these mappings.
>>
>> The extended regions are chosen at the domain creation time and
>> advertised to it via "reg" property under hypervisor node in
>> the guest device-tree. As region 0 is reserved for grant table
>> space (always present), the indexes for extended regions are 1...N.
>> If extended regions could not be allocated for some reason,
>> Xen doesn't fail and behaves as usual, so only inserts region 0.
>>
>> Please note the following limitations:
>> - The extended region feature is only supported for 64-bit domain
>>    currently.
>> - The ACPI case is not covered.
>>
>> ***
>>
>> As Dom0 is direct mapped domain on Arm (e.g. MFN == GFN)
>> the algorithm to choose extended regions for it is different
>> in comparison with the algorithm for non-direct mapped DomU.
>> What is more, that extended regions should be chosen differently
>> whether IOMMU is enabled or not.
>>
>> Provide RAM not assigned to Dom0 if IOMMU is disabled or memory
>> holes found in host device-tree if otherwise. Make sure that
>> extended regions are 2MB-aligned and located within maximum possible
>> addressable physical memory range. The minimum size of extended
>> region is 64MB. 
>
> You explained below why the 128 limits, but I don't see any 
> explanation on why 2MB and 64MB.
>
> IIRC, 2MB was to potentally allow superpage mapping. I am not entirely 
> sure for 64MB.
>
> Could you add an in-code comment explaining the two limits?

Yes. There was a discussion at [1]. 64MB was chosen as a reasonable 
value to deal with between initial 2MB (we might end up having a lot of 
small ranges which are not quite useful but increase bookkeeping) and 
suggested 1GB (we might not be able find a suitable regions at all).


>
>
>> The maximum number of extended regions is 128,
>> which is an artificial limit to minimize code changes (we reuse
>> struct meminfo to describe extended regions, so there are an array
>> field for 128 elements).
>>
>> It worth mentioning that unallocated memory solution (when the IOMMU
>> is disabled) will work safely until Dom0 is able to allocate memory
>> outside of the original range.
>>
>> Also introduce command line option to be able to globally enable or
>> disable support for extended regions for Dom0 (enabled by default).
>>
>> Suggested-by: Julien Grall <jgrall@amazon.com>
>> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>> ---
>> Please note, we need to decide which approach to use in 
>> find_unallocated_memory(),
>> you can find details at:
>> https://lore.kernel.org/xen-devel/28503e09-44c3-f623-bb8d-8778bb94225f@gmail.com/ 
>>
>>
>> Changes RFC -> V2:
>>     - update patch description
>>     - drop uneeded "extended-region" DT property
>>
>> Changes V2 -> V3:
>>     - update patch description
>>     - add comment for "size" calculation in add_ext_regions()
>>     - clarify "end" calculation in find_unallocated_memory() and
>>       find_memory_holes()
>>     - only pick up regions with size >= 64MB
>>     - allocate reg dynamically instead of keeping on the stack in
>>       make_hypervisor_node()
>>     - do not show warning for 32-bit domain
>>     - drop Linux specific limits EXT_REGION_*
>>     - also cover "ranges" property in find_memory_holes()
>>     - add command line arg to enable/disable extended region support
>>
>> Changes V3 -> V4:
>>    - update opt_ext_regions purpose and comment in code
>>    - reorganize make_hypervisor_node() to move allocations after initial
>>      checks, allocate only required amount of elements instead of 
>> maximum
>>      possible
>> ---
>>   docs/misc/xen-command-line.pandoc |  11 ++
>>   xen/arch/arm/domain_build.c       | 286 
>> +++++++++++++++++++++++++++++++++++++-
>
> The document in docs/misc/arm/device-tree/guest.txt needs to be 
> updated to reflect the change in the binding.

Good point. Will update.


>
>>   2 files changed, 294 insertions(+), 3 deletions(-)
>>
>> diff --git a/docs/misc/xen-command-line.pandoc 
>> b/docs/misc/xen-command-line.pandoc
>> index 177e656..5cae4ad 100644
>> --- a/docs/misc/xen-command-line.pandoc
>> +++ b/docs/misc/xen-command-line.pandoc
>> @@ -1081,6 +1081,17 @@ hardware domain is architecture dependent.
>>   Note that specifying zero as domU value means zero, while for dom0 
>> it means
>>   to use the default.
>>   +### ext_regions (Arm)
>> +> `= <boolean>`
>> +
>> +> Default : `true`
>> +
>> +Flag to enable or disable support for extended regions for Dom0.
>> +
>> +Extended regions are ranges of unused address space exposed to Dom0 as
>> +"safe to use" for special memory mappings. Disable if your board device
>> +tree is incomplete.
>> +
>>   ### flask
>>   > `= permissive | enforcing | late | disabled`
>>   diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
>> index d233d63..c5afbe2 100644
>> --- a/xen/arch/arm/domain_build.c
>> +++ b/xen/arch/arm/domain_build.c
>> @@ -34,6 +34,10 @@
>>   static unsigned int __initdata opt_dom0_max_vcpus;
>>   integer_param("dom0_max_vcpus", opt_dom0_max_vcpus);
>>   +/* If true, the extended regions support is enabled for dom0 */
>> +static bool __initdata opt_ext_regions = true;
>> +boolean_param("ext_regions", opt_ext_regions);
>> +
>>   static u64 __initdata dom0_mem;
>>   static bool __initdata dom0_mem_set;
>>   @@ -886,6 +890,232 @@ static int __init make_memory_node(const 
>> struct domain *d,
>>       return res;
>>   }
>>   +static int __init add_ext_regions(unsigned long s, unsigned long 
>> e, void *data)
>> +{
>> +    struct meminfo *ext_regions = data;
>> +    paddr_t start, size;
>> +
>> +    if ( ext_regions->nr_banks >= ARRAY_SIZE(ext_regions->bank) )
>> +        return 0;
>> +
>> +    /* Both start and size of the extended region should be 2MB 
>> aligned */
>> +    start = (s + SZ_2M - 1) & ~(SZ_2M - 1);
>> +    if ( start > e )
>> +        return 0;
>> +
>> +    /*
>> +     * e is actually "end-1" because it is called by rangeset functions
>> +     * which are inclusive of the last address.
>> +     */
>> +    e += 1;
>> +    size = (e - start) & ~(SZ_2M - 1);
>> +    if ( size < MB(64) )
>> +        return 0;
>> +
>> +    ext_regions->bank[ext_regions->nr_banks].start = start;
>> +    ext_regions->bank[ext_regions->nr_banks].size = size;
>> +    ext_regions->nr_banks++;
>> +
>> +    return 0;
>> +}
>> +
>> +static int __init find_unallocated_memory(const struct kernel_info 
>> *kinfo,
>> +                                          struct meminfo *ext_regions)
>
> It would be good to have a comment on top of this function summarizing 
> how this is meant to work.

Will add.


>
>
>> +{
>> +    const struct meminfo *assign_mem = &kinfo->mem;
>> +    struct rangeset *unalloc_mem;
>> +    paddr_t start, end;
>> +    unsigned int i;
>> +    int res;
>> +
>> +    dt_dprintk("Find unallocated memory for extended regions\n");
>> +
>> +    unalloc_mem = rangeset_new(NULL, NULL, 0);
>> +    if ( !unalloc_mem )
>> +        return -ENOMEM;
>> +
>> +    /* Start with all available RAM */
>> +    for ( i = 0; i < bootinfo.mem.nr_banks; i++ )
>> +    {
>> +        start = bootinfo.mem.bank[i].start;
>> +        end = bootinfo.mem.bank[i].start + bootinfo.mem.bank[i].size;
>> +        res = rangeset_add_range(unalloc_mem, start, end - 1);
>> +        if ( res )
>> +        {
>> +            printk(XENLOG_ERR "Failed to add: 
>> %#"PRIx64"->%#"PRIx64"\n",
>
> start and end are paddr_t. So you want to use PRIpaddr rather than PRIx64.

ok for this and the similar comments below.


>
>
>> +                   start, end);
>> +            goto out;
>> +        }
>> +    }
>> +
>> +    /* Remove RAM assigned to Dom0 */
>> +    for ( i = 0; i < assign_mem->nr_banks; i++ )
>> +    {
>> +        start = assign_mem->bank[i].start;
>> +        end = assign_mem->bank[i].start + assign_mem->bank[i].size;
>> +        res = rangeset_remove_range(unalloc_mem, start, end - 1);
>> +        if ( res )
>> +        {
>> +            printk(XENLOG_ERR "Failed to remove: 
>> %#"PRIx64"->%#"PRIx64"\n",
>
> Ditto.
>
>> +                   start, end);
>> +            goto out;
>> +        }
>> +    }
>> +
>> +    /* Remove reserved-memory regions */
>> +    for ( i = 0; i < bootinfo.reserved_mem.nr_banks; i++ )
>> +    {
>> +        start = bootinfo.reserved_mem.bank[i].start;
>> +        end = bootinfo.reserved_mem.bank[i].start +
>> +            bootinfo.reserved_mem.bank[i].size;
>> +        res = rangeset_remove_range(unalloc_mem, start, end - 1);
>> +        if ( res )
>> +        {
>> +            printk(XENLOG_ERR "Failed to remove: 
>> %#"PRIx64"->%#"PRIx64"\n",
>
> Ditto.
>
>> +                   start, end);
>> +            goto out;
>> +        }
>> +    }
>> +
>> +    /* Remove grant table region */
>> +    start = kinfo->gnttab_start;
>> +    end = kinfo->gnttab_start + kinfo->gnttab_size;
>> +    res = rangeset_remove_range(unalloc_mem, start, end - 1);
>> +    if ( res )
>> +    {
>> +        printk(XENLOG_ERR "Failed to remove: %#"PRIx64"->%#"PRIx64"\n",
>
> ditto.
>
>> +               start, end);
>> +        goto out;
>> +    }
>> +
>> +    start = 0;
>> +    end = (1ULL << p2m_ipa_bits) - 1;
>> +    res = rangeset_report_ranges(unalloc_mem, start, end,
>> +                                 add_ext_regions, ext_regions);
>> +    if ( res )
>> +        ext_regions->nr_banks = 0;
>> +    else if ( !ext_regions->nr_banks )
>> +        res = -ENOENT;
>> +
>> +out:
>> +    rangeset_destroy(unalloc_mem);
>> +
>> +    return res;
>> +}
>> +
>> +static int __init find_memory_holes(const struct kernel_info *kinfo,
>> +                                    struct meminfo *ext_regions)
>
> I think it would be good to have a comment on top of the function how 
> this is meant to work.

Will add.


>
>
>> +{
>> +    struct dt_device_node *np;
>> +    struct rangeset *mem_holes;
>> +    paddr_t start, end;
>> +    unsigned int i;
>> +    int res;
>> +
>> +    dt_dprintk("Find memory holes for extended regions\n");
>> +
>> +    mem_holes = rangeset_new(NULL, NULL, 0);
>> +    if ( !mem_holes )
>> +        return -ENOMEM;
>> +
>> +    /* Start with maximum possible addressable physical memory range */
>> +    start = 0;
>> +    end = (1ULL << p2m_ipa_bits) - 1;
>> +    res = rangeset_add_range(mem_holes, start, end);
>> +    if ( res )
>> +    {
>> +        printk(XENLOG_ERR "Failed to add: %#"PRIx64"->%#"PRIx64"\n",
>
> Please use PRIpaddr.
>
>> +               start, end);
>> +        goto out;
>> +    }
>> +
>> +    /*
>> +     * Remove regions described by "reg" and "ranges" properties where
>> +     * the memory is addressable (MMIO, RAM, PCI BAR, etc).
>> +     */
>> +    dt_for_each_device_node( dt_host, np )
>> +    {
>> +        unsigned int naddr;
>> +        u64 addr, size;
>> +
>> +        naddr = dt_number_of_address(np);
>> +
>> +        for ( i = 0; i < naddr; i++ )
>> +        {
>> +            res = dt_device_get_address(np, i, &addr, &size);
>> +            if ( res )
>> +            {
>> +                printk(XENLOG_ERR "Unable to retrieve address %u for 
>> %s\n",
>> +                       i, dt_node_full_name(np));
>> +                goto out;
>> +            }
>> +
>> +            start = addr & PAGE_MASK;
>> +            end = PAGE_ALIGN(addr + size);
>> +            res = rangeset_remove_range(mem_holes, start, end - 1);
>> +            if ( res )
>> +            {
>> +                printk(XENLOG_ERR "Failed to remove: 
>> %#"PRIx64"->%#"PRIx64"\n",
>> +                       start, end);
>> +                goto out;
>> +            }
>> +        }
>> +
>> +        if ( dt_device_type_is_equal(np, "pci" ) )
>> +        {
>
> The code below looks like an open-coding version of 
> dt_for_each_range(). Can you try to re-use it please? This will help 
> to reduce the complexity of this function.

You are right, it makes sense, will definitely reuse. If I was aware of 
that function before I would safe some time I spent on the investigation 
how to parse that)


diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
index ef2a177..8820b9c 100644
--- a/xen/arch/arm/domain_build.c
+++ b/xen/arch/arm/domain_build.c
@@ -1003,6 +1003,26 @@ out:
      return res;
  }

+static int __init handle_pci_range(const struct dt_device_node *dev,
+                                   u64 addr, u64 len, void *data)
+{
+    struct rangeset *mem_holes = data;
+    paddr_t start, end;
+    int res;
+
+    start = addr & PAGE_MASK;
+    end = PAGE_ALIGN(addr + len);
+    res = rangeset_remove_range(mem_holes, start, end - 1);
+    if ( res )
+    {
+        printk(XENLOG_ERR "Failed to remove: %#"PRIx64"->%#"PRIx64"\n",
+               start, end);
+        return res;
+    }
+
+    return 0;
+}
+
  static int __init find_memory_holes(const struct kernel_info *kinfo,
                                      struct meminfo *ext_regions)
  {
@@ -1061,43 +1081,19 @@ static int __init find_memory_holes(const struct 
kernel_info *kinfo,
              }
          }

-        if ( dt_device_type_is_equal(np, "pci" ) )
+        if ( dt_device_type_is_equal(np, "pci") )
          {
-            unsigned int range_size, nr_ranges;
-            int na, ns, pna;
-            const __be32 *ranges;
-            u32 len;
-
              /*
-             * Looking for non-empty ranges property which in this context
-             * describes the PCI host bridge aperture.
+             * The ranges property in this context describes the PCI host
+             * bridge aperture. It shall be absent if no addresses are 
mapped
+             * through the bridge.
               */
-            ranges = dt_get_property(np, "ranges", &len);
-            if ( !ranges || !len )
+            if ( !dt_get_property(np, "ranges", NULL) )
                  continue;

-            pna = dt_n_addr_cells(np);
-            na = dt_child_n_addr_cells(np);
-            ns = dt_child_n_size_cells(np);
-            range_size = pna + na + ns;
-            nr_ranges = len / sizeof(__be32) / range_size;
-
-            for ( i = 0; i < nr_ranges; i++, ranges += range_size )
-            {
-                /* Skip the child address and get the parent (CPU) 
address */
-                addr = dt_read_number(ranges + na, pna);
-                size = dt_read_number(ranges + na + pna, ns);
-
-                start = addr & PAGE_MASK;
-                end = PAGE_ALIGN(addr + size);
-                res = rangeset_remove_range(mem_holes, start, end - 1);
-                if ( res )
-                {
-                    printk(XENLOG_ERR "Failed to remove: 
%#"PRIx64"->%#"PRIx64"\n",
-                           start, end);
-                    goto out;
-                }
-            }
+            res = dt_for_each_range(np, &handle_pci_range, mem_holes);
+            if ( res )
+                goto out;
          }
      }

(END)


>
>
>> +            unsigned int range_size, nr_ranges;
>> +            int na, ns, pna;
>> +            const __be32 *ranges;
>> +            u32 len;
>> +
>> +            /*
>> +             * Looking for non-empty ranges property which in this 
>> context
>> +             * describes the PCI host bridge aperture.
>> +             */
>> +            ranges = dt_get_property(np, "ranges", &len);
>> +            if ( !ranges || !len )
>> +                continue;
>> +
>> +            pna = dt_n_addr_cells(np);
>> +            na = dt_child_n_addr_cells(np);
>> +            ns = dt_child_n_size_cells(np);
>> +            range_size = pna + na + ns;
>> +            nr_ranges = len / sizeof(__be32) / range_size;
>> +
>> +            for ( i = 0; i < nr_ranges; i++, ranges += range_size )
>> +            {
>> +                /* Skip the child address and get the parent (CPU) 
>> address */
>> +                addr = dt_read_number(ranges + na, pna);
>> +                size = dt_read_number(ranges + na + pna, ns);
>> +
>> +                start = addr & PAGE_MASK;
>> +                end = PAGE_ALIGN(addr + size);
>> +                res = rangeset_remove_range(mem_holes, start, end - 1);
>> +                if ( res )
>> +                {
>> +                    printk(XENLOG_ERR "Failed to remove: 
>> %#"PRIx64"->%#"PRIx64"\n",
>
> This should be PRIpaddr.
>
>> +                           start, end);
>> +                    goto out;
>> +                }
>> +            }
>> +        }
>> +    }
>> +
>> +    start = 0;
>> +    end = (1ULL << p2m_ipa_bits) - 1;
>> +    res = rangeset_report_ranges(mem_holes, start, end,
>> +                                 add_ext_regions, ext_regions);
>> +    if ( res )
>> +        ext_regions->nr_banks = 0;
>> +    else if ( !ext_regions->nr_banks )
>> +        res = -ENOENT;
>> +
>> +out:
>> +    rangeset_destroy(mem_holes);
>> +
>> +    return res;
>> +}
>> +
>>   static int __init make_hypervisor_node(struct domain *d,
>>                                          const struct kernel_info 
>> *kinfo,
>>                                          int addrcells, int sizecells)
>> @@ -893,11 +1123,12 @@ static int __init make_hypervisor_node(struct 
>> domain *d,
>>       const char compat[] =
>> "xen,xen-"__stringify(XEN_VERSION)"."__stringify(XEN_SUBVERSION)"\0"
>>           "xen,xen";
>> -    __be32 reg[4];
>> +    __be32 *reg, *cells;
>>       gic_interrupt_t intr;
>> -    __be32 *cells;
>>       int res;
>>       void *fdt = kinfo->fdt;
>> +    struct meminfo *ext_regions = NULL;
>> +    unsigned int i, nr_ext_regions;
>>         dt_dprintk("Create hypervisor node\n");
>>   @@ -919,12 +1150,61 @@ static int __init 
>> make_hypervisor_node(struct domain *d,
>>       if ( res )
>>           return res;
>>   +    if ( !opt_ext_regions )
>> +    {
>> +        printk(XENLOG_DEBUG "The extended regions support is 
>> disabled\n");
>
> The extended regions is going to be critical for the performance in 
> dom0. So I think this at least want to be a XENLOG_INFO.

ok


>
>
>> +        nr_ext_regions = 0;
>> +    }
>> +    else if ( is_32bit_domain(d) )
>> +    {
>> +        printk(XENLOG_DEBUG "The extended regions are only supported 
>> for 64-bit guest currently\n");
>
> This would want to be use XENLOG_WARN.

ok, it seems this was in my initial version.


>
>
>> +        nr_ext_regions = 0;
>> +    }
>> +    else
>> +    {
>> +        ext_regions = xzalloc(struct meminfo);
>> +        if ( !ext_regions )
>> +            return -ENOMEM;
>> +
>> +        if ( !is_iommu_enabled(d) )
>> +            res = find_unallocated_memory(kinfo, ext_regions);
>> +        else
>> +            res = find_memory_holes(kinfo, ext_regions);
>> +
>> +        if ( res )
>> +            printk(XENLOG_WARNING "Failed to allocate extended 
>> regions\n");
>> +        nr_ext_regions = ext_regions->nr_banks;
>> +    }
>> +
>> +    reg = xzalloc_array(__be32, (nr_ext_regions + 1) * (addrcells + 
>> sizecells));
>> +    if ( !reg )
>> +    {
>> +        xfree(ext_regions);
>> +        return -ENOMEM;
>> +    }
>> +
>>       /* reg 0 is grant table space */
>>       cells = &reg[0];
>>       dt_child_set_range(&cells, addrcells, sizecells,
>>                          kinfo->gnttab_start, kinfo->gnttab_size);
>> +    /* reg 1...N are extended regions */
>> +    for ( i = 0; i < nr_ext_regions; i++ )
>> +    {
>> +        u64 start = ext_regions->bank[i].start;
>> +        u64 size = ext_regions->bank[i].size;
>> +
>> +        dt_dprintk("Extended region %d: %#"PRIx64"->%#"PRIx64"\n",
>> +                   i, start, start + size);
>
> I would prefer if this is a printk() so we get the extended region 
> listed from the beginning.

ok


>
>
>> +
>> +        dt_child_set_range(&cells, addrcells, sizecells, start, size);
>> +    }
>> +
>>       res = fdt_property(fdt, "reg", reg,
>> -                       dt_cells_to_size(addrcells + sizecells));
>> +                       dt_cells_to_size(addrcells + sizecells) *
>> +                       (nr_ext_regions + 1));
>> +    xfree(ext_regions);
>> +    xfree(reg);
>> +
>>       if ( res )
>>           return res;
>>
>
[1] 
https://lore.kernel.org/xen-devel/b349e43a-91d9-16ba-57c6-34e790b8b31c@gmail.com/


Thank you.


-- 
Regards,

Oleksandr Tyshchenko



From xen-devel-bounces@lists.xenproject.org Mon Oct 04 12:22:11 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Oct 2021 12:22:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.201420.355912 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXMys-0004UA-NP; Mon, 04 Oct 2021 12:22:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 201420.355912; Mon, 04 Oct 2021 12:22:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXMys-0004U3-KR; Mon, 04 Oct 2021 12:22:06 +0000
Received: by outflank-mailman (input) for mailman id 201420;
 Mon, 04 Oct 2021 12:22:05 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mXMyr-0004Tx-AA
 for xen-devel@lists.xenproject.org; Mon, 04 Oct 2021 12:22:05 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mXMyr-0003JE-6k
 for xen-devel@lists.xenproject.org; Mon, 04 Oct 2021 12:22:05 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mXMyr-0004l0-5N
 for xen-devel@lists.xenproject.org; Mon, 04 Oct 2021 12:22:05 +0000
Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89)
 (envelope-from <iwj@xenproject.org>)
 id 1mXMyp-0005VP-6b; Mon, 04 Oct 2021 13:22:03 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:To:Date:
	Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From;
	bh=+fsfgGeZ4qqUEfE2iKExcwVirGCGdw0KtX4yevEB2+M=; b=UzBsYXJ0N486M/h7rV4crfZRJs
	MUt3sAFL2CboL1JaGdGIM+2s5wzcwgrQAUrvCNdssECI8HfX34We4d3eKMY3RRCN1HqkAJdlNIkYM
	07nHYPDb2LJI/4Ewu5IvKI/0Ui8HSe4X1w3HAtWW6DFyQfbEtwo26XUFIWi+anz5cTd0=;
From: Ian Jackson <iwj@xenproject.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <24922.61930.715312.781769@mariner.uk.xensource.com>
Date: Mon, 4 Oct 2021 13:22:02 +0100
To: xen-devel@lists.xenproject.org,
    committers@xenproject.org
Subject: Re: osstest down, PDU failure
In-Reply-To: <24917.61577.291999.406078@mariner.uk.xensource.com>
References: <24916.14069.358118.417330@mariner.uk.xensource.com>
	<24916.53633.593814.456485@mariner.uk.xensource.com>
	<24917.61577.291999.406078@mariner.uk.xensource.com>
X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu)

We replaced two PDUs and did a number of other on-site repairs etc.

Service is in the process of being restored.  I hope to be fully
operational by the end of the day.

Ian.


From xen-devel-bounces@lists.xenproject.org Mon Oct 04 13:00:07 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Oct 2021 13:00:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.201437.355927 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXNZR-0007vP-Qa; Mon, 04 Oct 2021 12:59:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 201437.355927; Mon, 04 Oct 2021 12:59:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXNZR-0007vI-N5; Mon, 04 Oct 2021 12:59:53 +0000
Received: by outflank-mailman (input) for mailman id 201437;
 Mon, 04 Oct 2021 12:59:52 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=r6Rd=OY=pengutronix.de=ukl@srs-us1.protection.inumbo.net>)
 id 1mXNZQ-0007vB-Fe
 for xen-devel@lists.xenproject.org; Mon, 04 Oct 2021 12:59:52 +0000
Received: from metis.ext.pengutronix.de (unknown
 [2001:67c:670:201:290:27ff:fe1d:cc33])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 078b5df6-85fe-4a89-b7fc-468d2d28a5bb;
 Mon, 04 Oct 2021 12:59:50 +0000 (UTC)
Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2])
 by metis.ext.pengutronix.de with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92)
 (envelope-from <ukl@pengutronix.de>)
 id 1mXNZH-00054g-5h; Mon, 04 Oct 2021 14:59:43 +0200
Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de)
 by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.92)
 (envelope-from <ukl@pengutronix.de>)
 id 1mXNZF-0000L2-HD; Mon, 04 Oct 2021 14:59:41 +0200
Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.92)
 (envelope-from <ukl@pengutronix.de>)
 id 1mXNZF-0000cM-GA; Mon, 04 Oct 2021 14:59:41 +0200
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 078b5df6-85fe-4a89-b7fc-468d2d28a5bb
From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
To: Bjorn Helgaas <helgaas@kernel.org>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>
Cc: linux-pci@vger.kernel.org,
	kernel@pengutronix.de,
	Stefano Stabellini <sstabellini@kernel.org>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	xen-devel@lists.xenproject.org,
	Christoph Hellwig <hch@lst.de>
Subject: [PATCH v6 03/11] xen/pci: Drop some checks that are always true
Date: Mon,  4 Oct 2021 14:59:27 +0200
Message-Id: <20211004125935.2300113-4-u.kleine-koenig@pengutronix.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20211004125935.2300113-1-u.kleine-koenig@pengutronix.de>
References: <20211004125935.2300113-1-u.kleine-koenig@pengutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
X-Patch-Hashes: v=1; h=sha256; i=7QOFRnoxyPrPqaGt2Yf8oJvx3xwgCvlMdm130sPrxr8=; m=Ixh7t2kv5MnS1JaJxFtVrqNhjBtz3xQyoCGo2anqbI0=; p=dOfuuSLv1l/M9DCuxyIBdCuX9kCH+yUzno229EZfUDs=; g=9e481f95a51887868b05f8a86c3e5a9f8aff47c6
X-Patch-Sig: m=pgp; i=u.kleine-koenig@pengutronix.de; s=0x0D2511F322BFAB1C1580266BE2DCDD9132669BD6; b=iQEzBAABCgAdFiEEfnIqFpAYrP8+dKQLwfwUeK3K7AkFAmFa+ocACgkQwfwUeK3K7Amivgf+JL3 VuSxNpZrDO5AQClHSuKBtHBaW7oTZrnAnrcEOp1mfJQ0APZDzc4FyTrDOrUqKGOTJKFHVWuxJGT5k TV31y+QhV/acV/nGCdglSS0qVvPZWqpehJx1tUmYnbE+pljLQXJM1iULrwC6v1Wx0B879pKQ1o4P3 7f+xl1YwNv+uOF52e0xNSTJ/PkPZucaNDdq6UtbfOtxHrPBrNmTp1KOgxWymujpRDxvtiNbBz7uGk XG1wfHDNRrB/TpXbkJVRPm842O3/GnSCKiV5BAgsFqeYcUc1vBOZ9afXqseT1w7tG3/4uovlnIqKZ 0yDw0Ltrn/A3l39G2RtzPL+eLsre9Pg==
Content-Transfer-Encoding: 8bit
X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2
X-SA-Exim-Mail-From: ukl@pengutronix.de
X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false
X-PTX-Original-Recipient: xen-devel@lists.xenproject.org

pcifront_common_process() has a check at the start that exits early if
pcidev or pdidev->driver are NULL. So simplify the following code by not
checking these two again.

Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
 drivers/pci/xen-pcifront.c | 57 +++++++++++++++++---------------------
 1 file changed, 25 insertions(+), 32 deletions(-)

diff --git a/drivers/pci/xen-pcifront.c b/drivers/pci/xen-pcifront.c
index 2156c632524d..f2d7f70a7a10 100644
--- a/drivers/pci/xen-pcifront.c
+++ b/drivers/pci/xen-pcifront.c
@@ -594,7 +594,6 @@ static pci_ers_result_t pcifront_common_process(int cmd,
 	int devfn = pdev->sh_info->aer_op.devfn;
 	int domain = pdev->sh_info->aer_op.domain;
 	struct pci_dev *pcidev;
-	int flag = 0;
 
 	dev_dbg(&pdev->xdev->dev,
 		"pcifront AER process: cmd %x (bus:%x, devfn%x)",
@@ -609,40 +608,34 @@ static pci_ers_result_t pcifront_common_process(int cmd,
 	}
 	pdrv = pcidev->driver;
 
-	if (pdrv) {
-		if (pdrv->err_handler && pdrv->err_handler->error_detected) {
-			pci_dbg(pcidev, "trying to call AER service\n");
-			if (pcidev) {
-				flag = 1;
-				switch (cmd) {
-				case XEN_PCI_OP_aer_detected:
-					result = pdrv->err_handler->
-						 error_detected(pcidev, state);
-					break;
-				case XEN_PCI_OP_aer_mmio:
-					result = pdrv->err_handler->
-						 mmio_enabled(pcidev);
-					break;
-				case XEN_PCI_OP_aer_slotreset:
-					result = pdrv->err_handler->
-						 slot_reset(pcidev);
-					break;
-				case XEN_PCI_OP_aer_resume:
-					pdrv->err_handler->resume(pcidev);
-					break;
-				default:
-					dev_err(&pdev->xdev->dev,
-						"bad request in aer recovery "
-						"operation!\n");
-
-				}
-			}
+	if (pdrv->err_handler && pdrv->err_handler->error_detected) {
+		pci_dbg(pcidev, "trying to call AER service\n");
+		switch (cmd) {
+		case XEN_PCI_OP_aer_detected:
+			result = pdrv->err_handler->
+				 error_detected(pcidev, state);
+			break;
+		case XEN_PCI_OP_aer_mmio:
+			result = pdrv->err_handler->
+				 mmio_enabled(pcidev);
+			break;
+		case XEN_PCI_OP_aer_slotreset:
+			result = pdrv->err_handler->
+				 slot_reset(pcidev);
+			break;
+		case XEN_PCI_OP_aer_resume:
+			pdrv->err_handler->resume(pcidev);
+			break;
+		default:
+			dev_err(&pdev->xdev->dev,
+				"bad request in aer recovery "
+				"operation!\n");
 		}
+
+		return result;
 	}
-	if (!flag)
-		result = PCI_ERS_RESULT_NONE;
 
-	return result;
+	return PCI_ERS_RESULT_NONE;
 }
 
 
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Mon Oct 04 13:00:38 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Oct 2021 13:00:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.201442.355937 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXNaA-0000mg-49; Mon, 04 Oct 2021 13:00:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 201442.355937; Mon, 04 Oct 2021 13:00:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXNaA-0000mZ-1D; Mon, 04 Oct 2021 13:00:38 +0000
Received: by outflank-mailman (input) for mailman id 201442;
 Mon, 04 Oct 2021 13:00:36 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=r6Rd=OY=pengutronix.de=ukl@srs-us1.protection.inumbo.net>)
 id 1mXNa8-0000lF-RR
 for xen-devel@lists.xenproject.org; Mon, 04 Oct 2021 13:00:36 +0000
Received: from metis.ext.pengutronix.de (unknown
 [2001:67c:670:201:290:27ff:fe1d:cc33])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 1db01d4a-e897-45fd-884c-4aeae5ee23a0;
 Mon, 04 Oct 2021 13:00:34 +0000 (UTC)
Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2])
 by metis.ext.pengutronix.de with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92)
 (envelope-from <ukl@pengutronix.de>)
 id 1mXNZL-00055S-Ir; Mon, 04 Oct 2021 14:59:47 +0200
Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de)
 by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.92)
 (envelope-from <ukl@pengutronix.de>)
 id 1mXNZH-0000LX-AH; Mon, 04 Oct 2021 14:59:43 +0200
Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.92)
 (envelope-from <ukl@pengutronix.de>)
 id 1mXNZH-0000d3-7t; Mon, 04 Oct 2021 14:59:43 +0200
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1db01d4a-e897-45fd-884c-4aeae5ee23a0
From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: linux-pci@vger.kernel.org,
	kernel@pengutronix.de,
	Russell Currey <ruscur@russell.cc>,
	"Oliver O'Halloran" <oohall@gmail.com>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@redhat.com>,
	Namhyung Kim <namhyung@kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Borislav Petkov <bp@alien8.de>,
	x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>,
	Frederic Barrat <fbarrat@linux.ibm.com>,
	Andrew Donnellan <ajd@linux.ibm.com>,
	Arnd Bergmann <arnd@arndb.de>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Mathias Nyman <mathias.nyman@intel.com>,
	linuxppc-dev@lists.ozlabs.org,
	linux-perf-users@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	linux-usb@vger.kernel.org
Subject: [PATCH v6 10/11] PCI: Replace pci_dev::driver usage by pci_dev::dev.driver
Date: Mon,  4 Oct 2021 14:59:34 +0200
Message-Id: <20211004125935.2300113-11-u.kleine-koenig@pengutronix.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20211004125935.2300113-1-u.kleine-koenig@pengutronix.de>
References: <20211004125935.2300113-1-u.kleine-koenig@pengutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
X-Patch-Hashes: v=1; h=sha256; i=/pZgVMb346xYWFyKXoYzQiwqLbFb4Qw5wqFIqjkKa+4=; m=FyMqGYUG+9Ut7bWwCBeeUgHOxoK/KbMAjt+cyx+MULA=; p=Av5qfMnrDTtNxfRgMp26LOqOMV4xtxFiJlRkPzujoa8=; g=83869c2c7c1ddaa0f90cc111fab61100dab63d9d
X-Patch-Sig: m=pgp; i=u.kleine-koenig@pengutronix.de; s=0x0D2511F322BFAB1C1580266BE2DCDD9132669BD6; b=iQEzBAABCgAdFiEEfnIqFpAYrP8+dKQLwfwUeK3K7AkFAmFa+qgACgkQwfwUeK3K7AldKwf/cPy CnIgfE0NaztkicLWjXoy3/B+C9RMJD0L7z5jWhMxqk13IoI6/sBomAxA2l+x3fMXkjYrXON8De6P8 LKG9sUd7VSMFEAWwQmnEdgVrniKWDgQEWOm8LIC/IOHVJe3vvWlMAb8Lp+ZlCqfga5N5OeAWq2RGp zK+W9FzcN+QvmZmKRRLwSDNE9LHV8cxSe702ZABCWlpLr/2wUmzMkLluchD+GSX60P92lk6Y1vDS1 rhqVcpO2/o39jIUBb1Ek3p3oHAUlq66h5s5z2lVvpdo8MAtSPK3y/hsHsPNuePaCJHRzbEsaM3nox QoZR2AME45/sUgeaNeMYg+wotfusCpg==
Content-Transfer-Encoding: 8bit
X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2
X-SA-Exim-Mail-From: ukl@pengutronix.de
X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false
X-PTX-Original-Recipient: xen-devel@lists.xenproject.org

struct pci_dev::driver contains (apart from a constant offset) the same
data as struct pci_dev::dev->driver. Replace all remaining users of the
former pointer by the latter to allow removing the former.

Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
 arch/powerpc/kernel/eeh_driver.c | 10 ++---
 arch/x86/events/intel/uncore.c   |  2 +-
 arch/x86/kernel/probe_roms.c     | 10 +++--
 drivers/misc/cxl/guest.c         | 24 +++++-----
 drivers/misc/cxl/pci.c           | 30 ++++++++-----
 drivers/pci/iov.c                | 33 ++++++++++----
 drivers/pci/pci-driver.c         | 76 +++++++++++++++++++-------------
 drivers/pci/pci.c                |  4 +-
 drivers/pci/pcie/err.c           | 36 ++++++++-------
 drivers/pci/xen-pcifront.c       |  4 +-
 drivers/usb/host/xhci-pci.c      |  2 +-
 11 files changed, 140 insertions(+), 91 deletions(-)

diff --git a/arch/powerpc/kernel/eeh_driver.c b/arch/powerpc/kernel/eeh_driver.c
index 3eff6a4888e7..350dab18e137 100644
--- a/arch/powerpc/kernel/eeh_driver.c
+++ b/arch/powerpc/kernel/eeh_driver.c
@@ -104,13 +104,13 @@ static bool eeh_edev_actionable(struct eeh_dev *edev)
  */
 static inline struct pci_driver *eeh_pcid_get(struct pci_dev *pdev)
 {
-	if (!pdev || !pdev->driver)
+	if (!pdev || !pdev->dev.driver)
 		return NULL;
 
-	if (!try_module_get(pdev->driver->driver.owner))
+	if (!try_module_get(pdev->dev.driver->owner))
 		return NULL;
 
-	return pdev->driver;
+	return to_pci_driver(pdev->dev.driver);
 }
 
 /**
@@ -122,10 +122,10 @@ static inline struct pci_driver *eeh_pcid_get(struct pci_dev *pdev)
  */
 static inline void eeh_pcid_put(struct pci_dev *pdev)
 {
-	if (!pdev || !pdev->driver)
+	if (!pdev || !pdev->dev.driver)
 		return;
 
-	module_put(pdev->driver->driver.owner);
+	module_put(pdev->dev.driver->owner);
 }
 
 /**
diff --git a/arch/x86/events/intel/uncore.c b/arch/x86/events/intel/uncore.c
index c72e368dd164..f1ba6ab2e97e 100644
--- a/arch/x86/events/intel/uncore.c
+++ b/arch/x86/events/intel/uncore.c
@@ -1187,7 +1187,7 @@ static int uncore_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id
 	 * PCI slot and func to indicate the uncore box.
 	 */
 	if (id->driver_data & ~0xffff) {
-		struct pci_driver *pci_drv = pdev->driver;
+		struct pci_driver *pci_drv = to_pci_driver(pdev->dev.driver);
 
 		pmu = uncore_pci_find_dev_pmu(pdev, pci_drv->id_table);
 		if (pmu == NULL)
diff --git a/arch/x86/kernel/probe_roms.c b/arch/x86/kernel/probe_roms.c
index 9e1def3744f2..deaaef6efe34 100644
--- a/arch/x86/kernel/probe_roms.c
+++ b/arch/x86/kernel/probe_roms.c
@@ -80,15 +80,17 @@ static struct resource video_rom_resource = {
  */
 static bool match_id(struct pci_dev *pdev, unsigned short vendor, unsigned short device)
 {
-	struct pci_driver *drv = pdev->driver;
 	const struct pci_device_id *id;
 
 	if (pdev->vendor == vendor && pdev->device == device)
 		return true;
 
-	for (id = drv ? drv->id_table : NULL; id && id->vendor; id++)
-		if (id->vendor == vendor && id->device == device)
-			break;
+	if (pdev->dev.driver) {
+		struct pci_driver *drv = to_pci_driver(pdev->dev.driver);
+		for (id = drv->id_table; id && id->vendor; id++)
+			if (id->vendor == vendor && id->device == device)
+				break;
+	}
 
 	return id && id->vendor;
 }
diff --git a/drivers/misc/cxl/guest.c b/drivers/misc/cxl/guest.c
index 186308f1f8eb..d997c9c3ebb5 100644
--- a/drivers/misc/cxl/guest.c
+++ b/drivers/misc/cxl/guest.c
@@ -25,28 +25,32 @@ static void pci_error_handlers(struct cxl_afu *afu,
 		return;
 
 	list_for_each_entry(afu_dev, &afu->phb->bus->devices, bus_list) {
-		if (!afu_dev->driver)
+		struct pci_driver *afu_drv;
+
+		if (!afu_dev->dev.driver)
 			continue;
 
+		afu_drv = to_pci_driver(afu_dev->dev.driver);
+
 		switch (bus_error_event) {
 		case CXL_ERROR_DETECTED_EVENT:
 			afu_dev->error_state = state;
 
-			if (afu_dev->driver->err_handler &&
-			    afu_dev->driver->err_handler->error_detected)
-				afu_dev->driver->err_handler->error_detected(afu_dev, state);
+			if (afu_drv->err_handler &&
+			    afu_drv->err_handler->error_detected)
+				afu_drv->err_handler->error_detected(afu_dev, state);
 		break;
 		case CXL_SLOT_RESET_EVENT:
 			afu_dev->error_state = state;
 
-			if (afu_dev->driver->err_handler &&
-			    afu_dev->driver->err_handler->slot_reset)
-				afu_dev->driver->err_handler->slot_reset(afu_dev);
+			if (afu_drv->err_handler &&
+			    afu_drv->err_handler->slot_reset)
+				afu_drv->err_handler->slot_reset(afu_dev);
 		break;
 		case CXL_RESUME_EVENT:
-			if (afu_dev->driver->err_handler &&
-			    afu_dev->driver->err_handler->resume)
-				afu_dev->driver->err_handler->resume(afu_dev);
+			if (afu_drv->err_handler &&
+			    afu_drv->err_handler->resume)
+				afu_drv->err_handler->resume(afu_dev);
 		break;
 		}
 	}
diff --git a/drivers/misc/cxl/pci.c b/drivers/misc/cxl/pci.c
index 2ba899f5659f..7e7545d01e27 100644
--- a/drivers/misc/cxl/pci.c
+++ b/drivers/misc/cxl/pci.c
@@ -1805,14 +1805,16 @@ static pci_ers_result_t cxl_vphb_error_detected(struct cxl_afu *afu,
 		return result;
 
 	list_for_each_entry(afu_dev, &afu->phb->bus->devices, bus_list) {
-		if (!afu_dev->driver)
+		struct pci_driver *afu_drv;
+		if (!afu_dev->dev.driver)
 			continue;
 
+		afu_drv = to_pci_driver(afu_dev->dev.driver);
+
 		afu_dev->error_state = state;
 
-		if (afu_dev->driver->err_handler)
-			afu_result = afu_dev->driver->err_handler->error_detected(afu_dev,
-										  state);
+		if (afu_drv->err_handler)
+			afu_result = afu_drv->err_handler->error_detected(afu_dev, state);
 		/* Disconnect trumps all, NONE trumps NEED_RESET */
 		if (afu_result == PCI_ERS_RESULT_DISCONNECT)
 			result = PCI_ERS_RESULT_DISCONNECT;
@@ -2003,6 +2005,8 @@ static pci_ers_result_t cxl_pci_slot_reset(struct pci_dev *pdev)
 			continue;
 
 		list_for_each_entry(afu_dev, &afu->phb->bus->devices, bus_list) {
+			struct pci_driver *afu_drv;
+
 			/* Reset the device context.
 			 * TODO: make this less disruptive
 			 */
@@ -2028,12 +2032,14 @@ static pci_ers_result_t cxl_pci_slot_reset(struct pci_dev *pdev)
 			 * shouldn't start new work until we call
 			 * their resume function.
 			 */
-			if (!afu_dev->driver)
+			if (!afu_dev->dev.driver)
 				continue;
 
-			if (afu_dev->driver->err_handler &&
-			    afu_dev->driver->err_handler->slot_reset)
-				afu_result = afu_dev->driver->err_handler->slot_reset(afu_dev);
+			afu_drv = to_pci_driver(afu_dev->dev.driver);
+
+			if (afu_drv->err_handler &&
+			    afu_drv->err_handler->slot_reset)
+				afu_result = afu_drv->err_handler->slot_reset(afu_dev);
 
 			if (afu_result == PCI_ERS_RESULT_DISCONNECT)
 				result = PCI_ERS_RESULT_DISCONNECT;
@@ -2074,9 +2080,11 @@ static void cxl_pci_resume(struct pci_dev *pdev)
 			continue;
 
 		list_for_each_entry(afu_dev, &afu->phb->bus->devices, bus_list) {
-			if (afu_dev->driver && afu_dev->driver->err_handler &&
-			    afu_dev->driver->err_handler->resume)
-				afu_dev->driver->err_handler->resume(afu_dev);
+			struct pci_driver *afu_drv;
+			if (afu_dev->dev.driver &&
+			    (afu_drv = to_pci_driver(afu_dev->dev.driver))->err_handler &&
+			    afu_drv->err_handler->resume)
+				afu_drv->err_handler->resume(afu_dev);
 		}
 	}
 	spin_unlock(&adapter->afu_list_lock);
diff --git a/drivers/pci/iov.c b/drivers/pci/iov.c
index dafdc652fcd0..0d0a34347868 100644
--- a/drivers/pci/iov.c
+++ b/drivers/pci/iov.c
@@ -164,13 +164,18 @@ static ssize_t sriov_vf_total_msix_show(struct device *dev,
 					char *buf)
 {
 	struct pci_dev *pdev = to_pci_dev(dev);
+	struct pci_driver *pdrv;
 	u32 vf_total_msix = 0;
 
 	device_lock(dev);
-	if (!pdev->driver || !pdev->driver->sriov_get_vf_total_msix)
+	if (!dev->driver)
 		goto unlock;
 
-	vf_total_msix = pdev->driver->sriov_get_vf_total_msix(pdev);
+	pdrv = to_pci_driver(dev->driver);
+	if (!pdrv->sriov_get_vf_total_msix)
+		goto unlock;
+
+	vf_total_msix = pdrv->sriov_get_vf_total_msix(pdev);
 unlock:
 	device_unlock(dev);
 	return sysfs_emit(buf, "%u\n", vf_total_msix);
@@ -183,6 +188,7 @@ static ssize_t sriov_vf_msix_count_store(struct device *dev,
 {
 	struct pci_dev *vf_dev = to_pci_dev(dev);
 	struct pci_dev *pdev = pci_physfn(vf_dev);
+	struct pci_driver *pdrv;
 	int val, ret;
 
 	ret = kstrtoint(buf, 0, &val);
@@ -193,13 +199,19 @@ static ssize_t sriov_vf_msix_count_store(struct device *dev,
 		return -EINVAL;
 
 	device_lock(&pdev->dev);
-	if (!pdev->driver || !pdev->driver->sriov_set_msix_vec_count) {
+	if (!pdev->dev.driver) {
+		ret = -EOPNOTSUPP;
+		goto err_pdev;
+	}
+
+	pdrv = to_pci_driver(pdev->dev.driver);
+	if (!pdrv->sriov_set_msix_vec_count) {
 		ret = -EOPNOTSUPP;
 		goto err_pdev;
 	}
 
 	device_lock(&vf_dev->dev);
-	if (vf_dev->driver) {
+	if (vf_dev->dev.driver) {
 		/*
 		 * A driver is already attached to this VF and has configured
 		 * itself based on the current MSI-X vector count. Changing
@@ -209,7 +221,7 @@ static ssize_t sriov_vf_msix_count_store(struct device *dev,
 		goto err_dev;
 	}
 
-	ret = pdev->driver->sriov_set_msix_vec_count(vf_dev, val);
+	ret = pdrv->sriov_set_msix_vec_count(vf_dev, val);
 
 err_dev:
 	device_unlock(&vf_dev->dev);
@@ -376,6 +388,7 @@ static ssize_t sriov_numvfs_store(struct device *dev,
 				  const char *buf, size_t count)
 {
 	struct pci_dev *pdev = to_pci_dev(dev);
+	struct pci_driver *pdrv;
 	int ret;
 	u16 num_vfs;
 
@@ -392,14 +405,16 @@ static ssize_t sriov_numvfs_store(struct device *dev,
 		goto exit;
 
 	/* is PF driver loaded */
-	if (!pdev->driver) {
+	if (!pdev->dev.driver) {
 		pci_info(pdev, "no driver bound to device; cannot configure SR-IOV\n");
 		ret = -ENOENT;
 		goto exit;
 	}
 
+	pdrv = to_pci_driver(pdev->dev.driver);
+
 	/* is PF driver loaded w/callback */
-	if (!pdev->driver->sriov_configure) {
+	if (!pdrv->sriov_configure) {
 		pci_info(pdev, "driver does not support SR-IOV configuration via sysfs\n");
 		ret = -ENOENT;
 		goto exit;
@@ -407,7 +422,7 @@ static ssize_t sriov_numvfs_store(struct device *dev,
 
 	if (num_vfs == 0) {
 		/* disable VFs */
-		ret = pdev->driver->sriov_configure(pdev, 0);
+		ret = pdrv->sriov_configure(pdev, 0);
 		goto exit;
 	}
 
@@ -419,7 +434,7 @@ static ssize_t sriov_numvfs_store(struct device *dev,
 		goto exit;
 	}
 
-	ret = pdev->driver->sriov_configure(pdev, num_vfs);
+	ret = pdrv->sriov_configure(pdev, num_vfs);
 	if (ret < 0)
 		goto exit;
 
diff --git a/drivers/pci/pci-driver.c b/drivers/pci/pci-driver.c
index 50449ec622a3..8654fe70cd66 100644
--- a/drivers/pci/pci-driver.c
+++ b/drivers/pci/pci-driver.c
@@ -457,7 +457,7 @@ static int pci_device_probe(struct device *dev)
 static void pci_device_remove(struct device *dev)
 {
 	struct pci_dev *pci_dev = to_pci_dev(dev);
-	struct pci_driver *drv = pci_dev->driver;
+	struct pci_driver *drv = to_pci_driver(pci_dev->dev.driver);
 
 	if (drv->remove) {
 		pm_runtime_get_sync(dev);
@@ -493,12 +493,15 @@ static void pci_device_remove(struct device *dev)
 static void pci_device_shutdown(struct device *dev)
 {
 	struct pci_dev *pci_dev = to_pci_dev(dev);
-	struct pci_driver *drv = pci_dev->driver;
 
 	pm_runtime_resume(dev);
 
-	if (drv && drv->shutdown)
-		drv->shutdown(pci_dev);
+	if (pci_dev->dev.driver) {
+		struct pci_driver *drv = to_pci_driver(pci_dev->dev.driver);
+
+		if (drv->shutdown)
+			drv->shutdown(pci_dev);
+	}
 
 	/*
 	 * If this is a kexec reboot, turn off Bus Master bit on the
@@ -589,22 +592,25 @@ static int pci_pm_reenable_device(struct pci_dev *pci_dev)
 static int pci_legacy_suspend(struct device *dev, pm_message_t state)
 {
 	struct pci_dev *pci_dev = to_pci_dev(dev);
-	struct pci_driver *drv = pci_dev->driver;
 
-	if (drv && drv->suspend) {
-		pci_power_t prev = pci_dev->current_state;
-		int error;
+	if (dev->driver) {
+		struct pci_driver *drv = to_pci_driver(dev->driver);
 
-		error = drv->suspend(pci_dev, state);
-		suspend_report_result(drv->suspend, error);
-		if (error)
-			return error;
+		if (drv->suspend) {
+			pci_power_t prev = pci_dev->current_state;
+			int error;
 
-		if (!pci_dev->state_saved && pci_dev->current_state != PCI_D0
-		    && pci_dev->current_state != PCI_UNKNOWN) {
-			pci_WARN_ONCE(pci_dev, pci_dev->current_state != prev,
-				      "PCI PM: Device state not saved by %pS\n",
-				      drv->suspend);
+			error = drv->suspend(pci_dev, state);
+			suspend_report_result(drv->suspend, error);
+			if (error)
+				return error;
+
+			if (!pci_dev->state_saved && pci_dev->current_state != PCI_D0
+			    && pci_dev->current_state != PCI_UNKNOWN) {
+				pci_WARN_ONCE(pci_dev, pci_dev->current_state != prev,
+					      "PCI PM: Device state not saved by %pS\n",
+					      drv->suspend);
+			}
 		}
 	}
 
@@ -630,12 +636,17 @@ static int pci_legacy_suspend_late(struct device *dev, pm_message_t state)
 static int pci_legacy_resume(struct device *dev)
 {
 	struct pci_dev *pci_dev = to_pci_dev(dev);
-	struct pci_driver *drv = pci_dev->driver;
 
 	pci_fixup_device(pci_fixup_resume, pci_dev);
 
-	return drv && drv->resume ?
-			drv->resume(pci_dev) : pci_pm_reenable_device(pci_dev);
+	if (pci_dev->dev.driver) {
+		struct pci_driver *drv = to_pci_driver(pci_dev->dev.driver);
+
+		if (drv->resume)
+			return drv->resume(pci_dev);
+	}
+
+	return pci_pm_reenable_device(pci_dev);
 }
 
 /* Auxiliary functions used by the new power management framework */
@@ -649,8 +660,14 @@ static void pci_pm_default_suspend(struct pci_dev *pci_dev)
 
 static bool pci_has_legacy_pm_support(struct pci_dev *pci_dev)
 {
-	struct pci_driver *drv = pci_dev->driver;
-	bool ret = drv && (drv->suspend || drv->resume);
+	struct pci_driver *drv;
+	bool ret;
+
+	if (!pci_dev->dev.driver)
+		return false;
+
+	drv = to_pci_driver(pci_dev->dev.driver);
+	ret = drv && (drv->suspend || drv->resume);
 
 	/*
 	 * Legacy PM support is used by default, so warn if the new framework is
@@ -1242,11 +1259,11 @@ static int pci_pm_runtime_suspend(struct device *dev)
 	int error;
 
 	/*
-	 * If pci_dev->driver is not set (unbound), we leave the device in D0,
+	 * If pci_dev->dev.driver is not set (unbound), we leave the device in D0,
 	 * but it may go to D3cold when the bridge above it runtime suspends.
 	 * Save its config space in case that happens.
 	 */
-	if (!pci_dev->driver) {
+	if (!pci_dev->dev.driver) {
 		pci_save_state(pci_dev);
 		return 0;
 	}
@@ -1303,7 +1320,7 @@ static int pci_pm_runtime_resume(struct device *dev)
 	 */
 	pci_restore_standard_config(pci_dev);
 
-	if (!pci_dev->driver)
+	if (!dev->driver)
 		return 0;
 
 	pci_fixup_device(pci_fixup_resume_early, pci_dev);
@@ -1322,14 +1339,13 @@ static int pci_pm_runtime_resume(struct device *dev)
 
 static int pci_pm_runtime_idle(struct device *dev)
 {
-	struct pci_dev *pci_dev = to_pci_dev(dev);
 	const struct dev_pm_ops *pm = dev->driver ? dev->driver->pm : NULL;
 
 	/*
-	 * If pci_dev->driver is not set (unbound), the device should
+	 * If dev->driver is not set (unbound), the device should
 	 * always remain in D0 regardless of the runtime PM status
 	 */
-	if (!pci_dev->driver)
+	if (!dev->driver)
 		return 0;
 
 	if (!pm)
@@ -1436,8 +1452,8 @@ static struct pci_driver pci_compat_driver = {
  */
 struct pci_driver *pci_dev_driver(const struct pci_dev *dev)
 {
-	if (dev->driver)
-		return dev->driver;
+	if (dev->dev.driver)
+		return to_pci_driver(dev->dev.driver);
 	else {
 		int i;
 		for (i = 0; i <= PCI_ROM_RESOURCE; i++)
diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
index ce2ab62b64cf..ccecf740de59 100644
--- a/drivers/pci/pci.c
+++ b/drivers/pci/pci.c
@@ -5089,7 +5089,7 @@ EXPORT_SYMBOL_GPL(pci_dev_unlock);
 static void pci_dev_save_and_disable(struct pci_dev *dev)
 {
 	const struct pci_error_handlers *err_handler =
-			dev->driver ? dev->driver->err_handler : NULL;
+			dev->dev.driver ? to_pci_driver(dev->dev.driver)->err_handler : NULL;
 
 	/*
 	 * dev->driver->err_handler->reset_prepare() is protected against
@@ -5120,7 +5120,7 @@ static void pci_dev_save_and_disable(struct pci_dev *dev)
 static void pci_dev_restore(struct pci_dev *dev)
 {
 	const struct pci_error_handlers *err_handler =
-			dev->driver ? dev->driver->err_handler : NULL;
+			dev->dev.driver ? to_pci_driver(dev->dev.driver)->err_handler : NULL;
 
 	pci_restore_state(dev);
 
diff --git a/drivers/pci/pcie/err.c b/drivers/pci/pcie/err.c
index b576aa890c76..b314b54f7821 100644
--- a/drivers/pci/pcie/err.c
+++ b/drivers/pci/pcie/err.c
@@ -49,14 +49,15 @@ static int report_error_detected(struct pci_dev *dev,
 				 pci_channel_state_t state,
 				 enum pci_ers_result *result)
 {
+	struct pci_driver *pdrv;
 	pci_ers_result_t vote;
 	const struct pci_error_handlers *err_handler;
 
 	device_lock(&dev->dev);
 	if (!pci_dev_set_io_state(dev, state) ||
-		!dev->driver ||
-		!dev->driver->err_handler ||
-		!dev->driver->err_handler->error_detected) {
+		!dev->dev.driver ||
+		!(pdrv = to_pci_driver(dev->dev.driver))->err_handler ||
+		!pdrv->err_handler->error_detected) {
 		/*
 		 * If any device in the subtree does not have an error_detected
 		 * callback, PCI_ERS_RESULT_NO_AER_DRIVER prevents subsequent
@@ -70,7 +71,7 @@ static int report_error_detected(struct pci_dev *dev,
 			vote = PCI_ERS_RESULT_NONE;
 		}
 	} else {
-		err_handler = dev->driver->err_handler;
+		err_handler = pdrv->err_handler;
 		vote = err_handler->error_detected(dev, state);
 	}
 	pci_uevent_ers(dev, vote);
@@ -92,15 +93,16 @@ static int report_normal_detected(struct pci_dev *dev, void *data)
 static int report_mmio_enabled(struct pci_dev *dev, void *data)
 {
 	pci_ers_result_t vote, *result = data;
+	struct pci_driver *pdrv;
 	const struct pci_error_handlers *err_handler;
 
 	device_lock(&dev->dev);
-	if (!dev->driver ||
-		!dev->driver->err_handler ||
-		!dev->driver->err_handler->mmio_enabled)
+	if (!dev->dev.driver ||
+		!(pdrv = to_pci_driver(dev->dev.driver))->err_handler ||
+		!pdrv->err_handler->mmio_enabled)
 		goto out;
 
-	err_handler = dev->driver->err_handler;
+	err_handler = pdrv->err_handler;
 	vote = err_handler->mmio_enabled(dev);
 	*result = merge_result(*result, vote);
 out:
@@ -112,14 +114,15 @@ static int report_slot_reset(struct pci_dev *dev, void *data)
 {
 	pci_ers_result_t vote, *result = data;
 	const struct pci_error_handlers *err_handler;
+	struct pci_driver *pdrv;
 
 	device_lock(&dev->dev);
-	if (!dev->driver ||
-		!dev->driver->err_handler ||
-		!dev->driver->err_handler->slot_reset)
+	if (!dev->dev.driver ||
+		!(pdrv = to_pci_driver(dev->dev.driver))->err_handler ||
+		!pdrv->err_handler->slot_reset)
 		goto out;
 
-	err_handler = dev->driver->err_handler;
+	err_handler = pdrv->err_handler;
 	vote = err_handler->slot_reset(dev);
 	*result = merge_result(*result, vote);
 out:
@@ -130,15 +133,16 @@ static int report_slot_reset(struct pci_dev *dev, void *data)
 static int report_resume(struct pci_dev *dev, void *data)
 {
 	const struct pci_error_handlers *err_handler;
+	struct pci_driver *pdrv;
 
 	device_lock(&dev->dev);
 	if (!pci_dev_set_io_state(dev, pci_channel_io_normal) ||
-		!dev->driver ||
-		!dev->driver->err_handler ||
-		!dev->driver->err_handler->resume)
+		!dev->dev.driver ||
+		!(pdrv = to_pci_driver(dev->dev.driver))->err_handler ||
+		!pdrv->err_handler->resume)
 		goto out;
 
-	err_handler = dev->driver->err_handler;
+	err_handler = pdrv->err_handler;
 	err_handler->resume(dev);
 out:
 	pci_uevent_ers(dev, PCI_ERS_RESULT_RECOVERED);
diff --git a/drivers/pci/xen-pcifront.c b/drivers/pci/xen-pcifront.c
index f2d7f70a7a10..73831fb87a1e 100644
--- a/drivers/pci/xen-pcifront.c
+++ b/drivers/pci/xen-pcifront.c
@@ -601,12 +601,12 @@ static pci_ers_result_t pcifront_common_process(int cmd,
 	result = PCI_ERS_RESULT_NONE;
 
 	pcidev = pci_get_domain_bus_and_slot(domain, bus, devfn);
-	if (!pcidev || !pcidev->driver) {
+	if (!pcidev || !pcidev->dev.driver) {
 		dev_err(&pdev->xdev->dev, "device or AER driver is NULL\n");
 		pci_dev_put(pcidev);
 		return result;
 	}
-	pdrv = pcidev->driver;
+	pdrv = to_pci_driver(pcidev->dev.driver);
 
 	if (pdrv->err_handler && pdrv->err_handler->error_detected) {
 		pci_dbg(pcidev, "trying to call AER service\n");
diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c
index 2c9f25ca8edd..2f4729f4f1e0 100644
--- a/drivers/usb/host/xhci-pci.c
+++ b/drivers/usb/host/xhci-pci.c
@@ -103,7 +103,7 @@ static void xhci_pci_quirks(struct device *dev, struct xhci_hcd *xhci)
 	struct xhci_driver_data         *driver_data;
 	const struct pci_device_id      *id;
 
-	id = pci_match_id(pdev->driver->id_table, pdev);
+	id = pci_match_id(to_pci_driver(pdev->dev.driver)->id_table, pdev);
 
 	if (id && id->driver_data) {
 		driver_data = (struct xhci_driver_data *)id->driver_data;
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Mon Oct 04 13:01:13 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Oct 2021 13:01:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.201451.355949 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXNaj-0001NF-Ha; Mon, 04 Oct 2021 13:01:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 201451.355949; Mon, 04 Oct 2021 13:01:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXNaj-0001N8-EB; Mon, 04 Oct 2021 13:01:13 +0000
Received: by outflank-mailman (input) for mailman id 201451;
 Mon, 04 Oct 2021 13:01:12 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=r6Rd=OY=pengutronix.de=ukl@srs-us1.protection.inumbo.net>)
 id 1mXNai-0001My-G8
 for xen-devel@lists.xenproject.org; Mon, 04 Oct 2021 13:01:12 +0000
Received: from metis.ext.pengutronix.de (unknown
 [2001:67c:670:201:290:27ff:fe1d:cc33])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 7661aec7-69c4-4279-9fd1-5e2d149b7319;
 Mon, 04 Oct 2021 13:01:10 +0000 (UTC)
Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2])
 by metis.ext.pengutronix.de with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92)
 (envelope-from <ukl@pengutronix.de>)
 id 1mXNZO-00054e-PH; Mon, 04 Oct 2021 14:59:50 +0200
Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de)
 by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.92)
 (envelope-from <ukl@pengutronix.de>)
 id 1mXNZF-0000Kt-4h; Mon, 04 Oct 2021 14:59:41 +0200
Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.92)
 (envelope-from <ukl@pengutronix.de>)
 id 1mXNZE-0000ay-Vr; Mon, 04 Oct 2021 14:59:40 +0200
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7661aec7-69c4-4279-9fd1-5e2d149b7319
From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: linux-pci@vger.kernel.org,
	kernel@pengutronix.de,
	Alexander Duyck <alexanderduyck@fb.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Andrew Donnellan <ajd@linux.ibm.com>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Arnd Bergmann <arnd@arndb.de>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Borislav Petkov <bp@alien8.de>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	"David S. Miller" <davem@davemloft.net>,
	Fiona Trahe <fiona.trahe@intel.com>,
	Frederic Barrat <fbarrat@linux.ibm.com>,
	Giovanni Cabiddu <giovanni.cabiddu@intel.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Ido Schimmel <idosch@nvidia.com>,
	Ingo Molnar <mingo@redhat.com>,
	Jack Xu <jack.xu@intel.com>,
	Jakub Kicinski <kuba@kernel.org>,
	Jesse Brandeburg <jesse.brandeburg@intel.com>,
	Jiri Olsa <jolsa@redhat.com>,
	Jiri Pirko <jiri@nvidia.com>,
	Juergen Gross <jgross@suse.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Marco Chiappero <marco.chiappero@intel.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Mathias Nyman <mathias.nyman@intel.com>,
	Michael Buesch <m@bues.ch>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Namhyung Kim <namhyung@kernel.org>,
	"Oliver O'Halloran" <oohall@gmail.com>,
	Paul Mackerras <paulus@samba.org>,
	Peter Zijlstra <peterz@infradead.org>,
	=?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= <zajec5@gmail.com>,
	Russell Currey <ruscur@russell.cc>,
	Salil Mehta <salil.mehta@huawei.com>,
	Sathya Prakash <sathya.prakash@broadcom.com>,
	Simon Horman <simon.horman@corigine.com>,
	Sreekanth Reddy <sreekanth.reddy@broadcom.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Suganath Prabu Subramani <suganath-prabu.subramani@broadcom.com>,
	Taras Chornyi <tchornyi@marvell.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Tomaszx Kowalik <tomaszx.kowalik@intel.com>,
	Vadym Kochan <vkochan@marvell.com>,
	Wojciech Ziemba <wojciech.ziemba@intel.com>,
	Yisen Zhuang <yisen.zhuang@huawei.com>,
	Zhou Wang <wangzhou1@hisilicon.com>,
	linux-crypto@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-perf-users@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-scsi@vger.kernel.org,
	linux-usb@vger.kernel.org,
	linux-wireless@vger.kernel.org,
	MPT-FusionLinux.pdl@broadcom.com,
	netdev@vger.kernel.org,
	oss-drivers@corigine.com,
	qat-linux@intel.com,
	x86@kernel.org,
	xen-devel@lists.xenproject.org
Subject: [PATCH v6 00/11] PCI: Drop duplicated tracking of a pci_dev's bound driver
Date: Mon,  4 Oct 2021 14:59:24 +0200
Message-Id: <20211004125935.2300113-1-u.kleine-koenig@pengutronix.de>
X-Mailer: git-send-email 2.30.2
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2
X-SA-Exim-Mail-From: ukl@pengutronix.de
X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false
X-PTX-Original-Recipient: xen-devel@lists.xenproject.org

Hello,

this is v6 of the quest to drop the "driver" member from struct pci_dev
which tracks the same data (apart from a constant offset) as dev.driver.

Changes since v5:
 - Some Acks added
 - Some fixes in "PCI: Replace pci_dev::driver usage by
   pci_dev::dev.driver" to properly handle that
   to_pci_driver(X) is wrong if X is NULL.
   This should fix the problem reported by Ido Schimmel.

Full range diff below.

This patch stack survived an allmodconfig build on arm64, m68k, powerpc,
riscv, s390, sparc64 and x86_64 on top of v5.15-rc3.

Best regards
Uwe

Uwe Kleine-König (11):
  PCI: Simplify pci_device_remove()
  PCI: Drop useless check from pci_device_probe()
  xen/pci: Drop some checks that are always true
  bcma: simplify reference to the driver's name
  powerpc/eeh: Don't use driver member of struct pci_dev and further
    cleanups
  ssb: Simplify determination of driver name
  PCI: Replace pci_dev::driver usage that gets the driver name
  scsi: message: fusion: Remove unused parameter of mpt_pci driver's
    probe()
  crypto: qat - simplify adf_enable_aer()
  PCI: Replace pci_dev::driver usage by pci_dev::dev.driver
  PCI: Drop duplicated tracking of a pci_dev's bound driver

 arch/powerpc/include/asm/ppc-pci.h            |  5 -
 arch/powerpc/kernel/eeh.c                     |  8 ++
 arch/powerpc/kernel/eeh_driver.c              | 10 +-
 arch/x86/events/intel/uncore.c                |  2 +-
 arch/x86/kernel/probe_roms.c                  | 10 +-
 drivers/bcma/host_pci.c                       |  6 +-
 drivers/crypto/hisilicon/qm.c                 |  2 +-
 drivers/crypto/qat/qat_4xxx/adf_drv.c         |  7 +-
 drivers/crypto/qat/qat_c3xxx/adf_drv.c        |  7 +-
 drivers/crypto/qat/qat_c62x/adf_drv.c         |  7 +-
 drivers/crypto/qat/qat_common/adf_aer.c       | 10 +-
 .../crypto/qat/qat_common/adf_common_drv.h    |  3 +-
 drivers/crypto/qat/qat_dh895xcc/adf_drv.c     |  7 +-
 drivers/message/fusion/mptbase.c              |  7 +-
 drivers/message/fusion/mptbase.h              |  2 +-
 drivers/message/fusion/mptctl.c               |  4 +-
 drivers/message/fusion/mptlan.c               |  2 +-
 drivers/misc/cxl/guest.c                      | 24 +++--
 drivers/misc/cxl/pci.c                        | 30 +++---
 .../ethernet/hisilicon/hns3/hns3_ethtool.c    |  2 +-
 .../ethernet/marvell/prestera/prestera_pci.c  |  2 +-
 drivers/net/ethernet/mellanox/mlxsw/pci.c     |  2 +-
 .../ethernet/netronome/nfp/nfp_net_ethtool.c  |  3 +-
 drivers/pci/iov.c                             | 33 +++++--
 drivers/pci/pci-driver.c                      | 96 ++++++++++---------
 drivers/pci/pci.c                             |  4 +-
 drivers/pci/pcie/err.c                        | 36 +++----
 drivers/pci/xen-pcifront.c                    | 63 ++++++------
 drivers/ssb/pcihost_wrapper.c                 |  6 +-
 drivers/usb/host/xhci-pci.c                   |  2 +-
 include/linux/pci.h                           |  1 -
 31 files changed, 208 insertions(+), 195 deletions(-)

Range-diff against v5:
 -:  ------------ >  1:  c2b53ab26a6b PCI: Simplify pci_device_remove()
 -:  ------------ >  2:  2c733e1d5186 PCI: Drop useless check from pci_device_probe()
 -:  ------------ >  3:  547ca5a7aa16 xen/pci: Drop some checks that are always true
 -:  ------------ >  4:  40eb07353844 bcma: simplify reference to the driver's name
 -:  ------------ >  5:  bab59c1dff6d powerpc/eeh: Don't use driver member of struct pci_dev and further cleanups
 1:  abd70de9782d !  6:  92f4d61bbac3 ssb: Simplify determination of driver name
    @@ Commit message
         This has the upside of not requiring the driver member of struct pci_dev
         which is about to be removed and being simpler.
     
    +    Acked-by: Michael Büsch <m@bues.ch>
         Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
     
      ## drivers/ssb/pcihost_wrapper.c ##
 2:  735845bd26b9 !  7:  6303f03ab2aa PCI: Replace pci_dev::driver usage that gets the driver name
    @@ Commit message
         driver name by dev_driver_string() which implicitly makes use of struct
         pci_dev::dev->driver.
     
    +    Acked-by: Simon Horman <simon.horman@corigine.com> (for NFP)
         Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
     
      ## drivers/crypto/hisilicon/qm.c ##
 3:  1e58019165b9 =  8:  658a6c00ec96 scsi: message: fusion: Remove unused parameter of mpt_pci driver's probe()
 4:  dea72a470141 =  9:  aceaf5321603 crypto: qat - simplify adf_enable_aer()
 5:  b4165dda38ea ! 10:  80648d999985 PCI: Replace pci_dev::driver usage by pci_dev::dev.driver
    @@ arch/x86/kernel/probe_roms.c: static struct resource video_rom_resource = {
      static bool match_id(struct pci_dev *pdev, unsigned short vendor, unsigned short device)
      {
     -	struct pci_driver *drv = pdev->driver;
    -+	struct pci_driver *drv = to_pci_driver(pdev->dev.driver);
      	const struct pci_device_id *id;
      
      	if (pdev->vendor == vendor && pdev->device == device)
    + 		return true;
    + 
    +-	for (id = drv ? drv->id_table : NULL; id && id->vendor; id++)
    +-		if (id->vendor == vendor && id->device == device)
    +-			break;
    ++	if (pdev->dev.driver) {
    ++		struct pci_driver *drv = to_pci_driver(pdev->dev.driver);
    ++		for (id = drv->id_table; id && id->vendor; id++)
    ++			if (id->vendor == vendor && id->device == device)
    ++				break;
    ++	}
    + 
    + 	return id && id->vendor;
    + }
     
      ## drivers/misc/cxl/guest.c ##
     @@ drivers/misc/cxl/guest.c: static void pci_error_handlers(struct cxl_afu *afu,
    @@ drivers/pci/iov.c: static ssize_t sriov_vf_total_msix_show(struct device *dev,
      
      	device_lock(dev);
     -	if (!pdev->driver || !pdev->driver->sriov_get_vf_total_msix)
    -+	pdrv = to_pci_driver(dev->driver);
    -+	if (!pdrv || !pdrv->sriov_get_vf_total_msix)
    ++	if (!dev->driver)
      		goto unlock;
      
     -	vf_total_msix = pdev->driver->sriov_get_vf_total_msix(pdev);
    ++	pdrv = to_pci_driver(dev->driver);
    ++	if (!pdrv->sriov_get_vf_total_msix)
    ++		goto unlock;
    ++
     +	vf_total_msix = pdrv->sriov_get_vf_total_msix(pdev);
      unlock:
      	device_unlock(dev);
    @@ drivers/pci/iov.c: static ssize_t sriov_vf_msix_count_store(struct device *dev,
      
      	device_lock(&pdev->dev);
     -	if (!pdev->driver || !pdev->driver->sriov_set_msix_vec_count) {
    ++	if (!pdev->dev.driver) {
    ++		ret = -EOPNOTSUPP;
    ++		goto err_pdev;
    ++	}
    ++
     +	pdrv = to_pci_driver(pdev->dev.driver);
    -+	if (!pdrv || !pdrv->sriov_set_msix_vec_count) {
    ++	if (!pdrv->sriov_set_msix_vec_count) {
      		ret = -EOPNOTSUPP;
      		goto err_pdev;
      	}
    @@ drivers/pci/pci-driver.c: static void pci_device_remove(struct device *dev)
      {
      	struct pci_dev *pci_dev = to_pci_dev(dev);
     -	struct pci_driver *drv = pci_dev->driver;
    -+	struct pci_driver *drv = to_pci_driver(pci_dev->dev.driver);
      
      	pm_runtime_resume(dev);
      
    +-	if (drv && drv->shutdown)
    +-		drv->shutdown(pci_dev);
    ++	if (pci_dev->dev.driver) {
    ++		struct pci_driver *drv = to_pci_driver(pci_dev->dev.driver);
    ++
    ++		if (drv->shutdown)
    ++			drv->shutdown(pci_dev);
    ++	}
    + 
    + 	/*
    + 	 * If this is a kexec reboot, turn off Bus Master bit on the
     @@ drivers/pci/pci-driver.c: static int pci_pm_reenable_device(struct pci_dev *pci_dev)
      static int pci_legacy_suspend(struct device *dev, pm_message_t state)
      {
      	struct pci_dev *pci_dev = to_pci_dev(dev);
     -	struct pci_driver *drv = pci_dev->driver;
    -+	struct pci_driver *drv = to_pci_driver(dev->driver);
      
    - 	if (drv && drv->suspend) {
    - 		pci_power_t prev = pci_dev->current_state;
    +-	if (drv && drv->suspend) {
    +-		pci_power_t prev = pci_dev->current_state;
    +-		int error;
    ++	if (dev->driver) {
    ++		struct pci_driver *drv = to_pci_driver(dev->driver);
    + 
    +-		error = drv->suspend(pci_dev, state);
    +-		suspend_report_result(drv->suspend, error);
    +-		if (error)
    +-			return error;
    ++		if (drv->suspend) {
    ++			pci_power_t prev = pci_dev->current_state;
    ++			int error;
    + 
    +-		if (!pci_dev->state_saved && pci_dev->current_state != PCI_D0
    +-		    && pci_dev->current_state != PCI_UNKNOWN) {
    +-			pci_WARN_ONCE(pci_dev, pci_dev->current_state != prev,
    +-				      "PCI PM: Device state not saved by %pS\n",
    +-				      drv->suspend);
    ++			error = drv->suspend(pci_dev, state);
    ++			suspend_report_result(drv->suspend, error);
    ++			if (error)
    ++				return error;
    ++
    ++			if (!pci_dev->state_saved && pci_dev->current_state != PCI_D0
    ++			    && pci_dev->current_state != PCI_UNKNOWN) {
    ++				pci_WARN_ONCE(pci_dev, pci_dev->current_state != prev,
    ++					      "PCI PM: Device state not saved by %pS\n",
    ++					      drv->suspend);
    ++			}
    + 		}
    + 	}
    + 
     @@ drivers/pci/pci-driver.c: static int pci_legacy_suspend_late(struct device *dev, pm_message_t state)
      static int pci_legacy_resume(struct device *dev)
      {
      	struct pci_dev *pci_dev = to_pci_dev(dev);
     -	struct pci_driver *drv = pci_dev->driver;
    -+	struct pci_driver *drv = to_pci_driver(pci_dev->dev.driver);
      
      	pci_fixup_device(pci_fixup_resume, pci_dev);
      
    +-	return drv && drv->resume ?
    +-			drv->resume(pci_dev) : pci_pm_reenable_device(pci_dev);
    ++	if (pci_dev->dev.driver) {
    ++		struct pci_driver *drv = to_pci_driver(pci_dev->dev.driver);
    ++
    ++		if (drv->resume)
    ++			return drv->resume(pci_dev);
    ++	}
    ++
    ++	return pci_pm_reenable_device(pci_dev);
    + }
    + 
    + /* Auxiliary functions used by the new power management framework */
     @@ drivers/pci/pci-driver.c: static void pci_pm_default_suspend(struct pci_dev *pci_dev)
      
      static bool pci_has_legacy_pm_support(struct pci_dev *pci_dev)
      {
     -	struct pci_driver *drv = pci_dev->driver;
    -+	struct pci_driver *drv = to_pci_driver(pci_dev->dev.driver);
    - 	bool ret = drv && (drv->suspend || drv->resume);
    +-	bool ret = drv && (drv->suspend || drv->resume);
    ++	struct pci_driver *drv;
    ++	bool ret;
    ++
    ++	if (!pci_dev->dev.driver)
    ++		return false;
    ++
    ++	drv = to_pci_driver(pci_dev->dev.driver);
    ++	ret = drv && (drv->suspend || drv->resume);
      
      	/*
    + 	 * Legacy PM support is used by default, so warn if the new framework is
     @@ drivers/pci/pci-driver.c: static int pci_pm_runtime_suspend(struct device *dev)
      	int error;
      
 6:  d93a138bd7ab = 11:  2686d69bca17 PCI: Drop duplicated tracking of a pci_dev's bound driver

base-commit: 5816b3e6577eaa676ceb00a848f0fd65fe2adc29
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Mon Oct 04 14:12:20 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Oct 2021 14:12:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.201466.355960 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXOhD-0008QT-Fs; Mon, 04 Oct 2021 14:11:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 201466.355960; Mon, 04 Oct 2021 14:11:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXOhD-0008QM-Cn; Mon, 04 Oct 2021 14:11:59 +0000
Received: by outflank-mailman (input) for mailman id 201466;
 Mon, 04 Oct 2021 14:11:58 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=U/Qt=OY=gmail.com=andr2000@srs-us1.protection.inumbo.net>)
 id 1mXOhC-0008QG-HW
 for xen-devel@lists.xenproject.org; Mon, 04 Oct 2021 14:11:58 +0000
Received: from mail-lf1-x12b.google.com (unknown [2a00:1450:4864:20::12b])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id e7119be3-e1ee-4df1-9ab7-77b6af9936dd;
 Mon, 04 Oct 2021 14:11:57 +0000 (UTC)
Received: by mail-lf1-x12b.google.com with SMTP id e15so72225018lfr.10
 for <xen-devel@lists.xenproject.org>; Mon, 04 Oct 2021 07:11:57 -0700 (PDT)
Received: from localhost.localdomain (host-176-36-245-220.b024.la.net.ua.
 [176.36.245.220])
 by smtp.gmail.com with ESMTPSA id n12sm1076809lfe.145.2021.10.04.07.11.52
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Mon, 04 Oct 2021 07:11:53 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e7119be3-e1ee-4df1-9ab7-77b6af9936dd
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:mime-version
         :content-transfer-encoding;
        bh=WsOpifpsOxtx/89eDSKv6jrXALsdW46waxc0qV6yaCU=;
        b=Vj0nRmiwciVoHjPaOjjFiSgbrkxgBNS56qAtBB70b36pVaaHK146k9SUlNZIipqr5W
         4yQgaJddnnlF8sVCGPLfARgISDtwIiTm2Dj8Py3IzJ0OhJIZXafvSRXlwR6rxl+ZwvlW
         uxFXPbBBWhYbz0EcUPiDmm+EV82IKhhXTtbPAzoS7pV+C8o9CZELr5HcA+8MJy466HyX
         rXJ6ZlpvmkWNzzqKFh8VHbxfdTwo02XkE42XnH84R6DQzUavaEVIInPLU64g/zq4zLuG
         s8OHWqDbJ3ysOtNUVl6Jb788Ncm5zliP/6cZUfMM1pqXIPcBo7D7H6QEvZ28bJ5BnGJi
         N6aQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version
         :content-transfer-encoding;
        bh=WsOpifpsOxtx/89eDSKv6jrXALsdW46waxc0qV6yaCU=;
        b=LyXMyyIq1VWor7M0xCGcxiVmBIWvInajzd9uSflE9pgft2nG/JF2SngDV1XEBB7uWA
         9h7nIcxYe4GdXJNWYgqP3yLPysnjeG6WiIpgU8c49jReQV6b1Ef5VuBbyWvCK/fbG3d+
         t4hdfwWkC6rs/0R4FdcLuqHwx11MFkXRJV6RQSu88OOGndOerqhf3k/rH9IaUNMDpbo2
         e06kc7Gz9UBTKKeamylzsAHKHYBlheku5UHYVy6l2cEuXjATub2yHCkgNj1srVGwXo6R
         MKr3nDO300Q38SFQMq3crwdDiSqaobTDxrg+yaISEHOo6LLeMPSDjTgCaUGuSeQwy6lJ
         r0gA==
X-Gm-Message-State: AOAM5315mCeSHk5Mzd8znBPYEres3iTY2XqcFe1zfGPRfS1eCXKWTige
	UYCZwLdgrKm2Ook55UOOgX2Ixug26To=
X-Google-Smtp-Source: ABdhPJwB/a1zy6Ef/4Lj6tH2TNIceuwzXWD04m55Gg0d9hbchYpf9rv8pc8D40AzumYOBkn9a5ylRg==
X-Received: by 2002:ac2:5c0f:: with SMTP id r15mr2380137lfp.564.1633356713814;
        Mon, 04 Oct 2021 07:11:53 -0700 (PDT)
From: Oleksandr Andrushchenko <andr2000@gmail.com>
To: xen-devel@lists.xenproject.org
Cc: julien@xen.org,
	sstabellini@kernel.org,
	oleksandr_tyshchenko@epam.com,
	volodymyr_babchuk@epam.com,
	Artem_Mygaiev@epam.com,
	roger.pau@citrix.com,
	jbeulich@suse.com,
	andrew.cooper3@citrix.com,
	george.dunlap@citrix.com,
	paul@xen.org,
	bertrand.marquis@arm.com,
	rahul.singh@arm.com,
	Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Subject: [PATCH v4 00/11] PCI devices passthrough on Arm, part 2
Date: Mon,  4 Oct 2021 17:11:40 +0300
Message-Id: <20211004141151.132231-1-andr2000@gmail.com>
X-Mailer: git-send-email 2.25.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>

Hi, all!

This is an assorted series of patches which aim is to make some further
basis for PCI passthrough on Arm support. The series continues the work
published earlier by Arm [1] and adds new helpers and clears the way for
vPCI changes which will follow.

RFC is at [2], [3]. Design presentation can be found at [4].

Thank you,
Oleksandr

[1] https://patchwork.kernel.org/project/xen-devel/list/?series=557111
[2] https://lists.xenproject.org/archives/html/xen-devel/2020-07/msg01184.html
[3] https://lists.xenproject.org/archives/html/xen-devel/2020-07/threads.html#01184
[4] https://static.sched.com/hosted_files/xen2021/e4/PCI_Device_Passthrough_On_Arm.pdf

Oleksandr Andrushchenko (10):
  xen/arm: Fix dev_is_dt macro definition
  xen/arm: Add new device type for PCI
  xen/arm: Introduce pci_find_host_bridge_node helper
  xen/device-tree: Make dt_find_node_by_phandle global
  xen/arm: Mark device as PCI while creating one
  libxl: Allow removing PCI devices for all types of domains
  libxl: Only map legacy PCI IRQs if they are supported
  xen/arm: Setup MMIO range trap handlers for hardware domain
  xen/arm: Do not map PCI ECAM and MMIO space to Domain-0's p2m
  xen/arm: Process pending vPCI map/unmap operations

Oleksandr Tyshchenko (1):
  xen/domain: Call pci_release_devices() when releasing domain resources

 tools/libs/light/Makefile          |  4 ++
 tools/libs/light/libxl_pci.c       | 15 ++++-
 xen/arch/arm/domain.c              | 11 +++-
 xen/arch/arm/domain_build.c        | 50 ++++++++--------
 xen/arch/arm/pci/ecam.c            | 14 +++++
 xen/arch/arm/pci/pci-host-common.c | 93 ++++++++++++++++++++++++++++++
 xen/arch/arm/pci/pci-host-zynqmp.c |  1 +
 xen/arch/arm/pci/pci.c             | 12 ++++
 xen/arch/arm/traps.c               | 13 +++++
 xen/arch/arm/vpci.c                | 34 +++++++++++
 xen/arch/arm/vpci.h                |  6 ++
 xen/arch/x86/hvm/hvm.c             |  6 ++
 xen/common/device_tree.c           |  2 +-
 xen/common/ioreq.c                 |  9 ---
 xen/drivers/passthrough/pci.c      |  2 +
 xen/include/asm-arm/device.h       |  6 +-
 xen/include/asm-arm/pci.h          | 30 ++++++++++
 xen/include/asm-arm/setup.h        | 13 +++++
 xen/include/asm-x86/pci.h          |  2 +
 xen/include/xen/device_tree.h      |  2 +
 20 files changed, 286 insertions(+), 39 deletions(-)

-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Mon Oct 04 14:12:20 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Oct 2021 14:12:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.201467.355970 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXOhI-0000G2-NA; Mon, 04 Oct 2021 14:12:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 201467.355970; Mon, 04 Oct 2021 14:12:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXOhI-0000Fq-K5; Mon, 04 Oct 2021 14:12:04 +0000
Received: by outflank-mailman (input) for mailman id 201467;
 Mon, 04 Oct 2021 14:12:03 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=U/Qt=OY=gmail.com=andr2000@srs-us1.protection.inumbo.net>)
 id 1mXOhH-0008QG-DL
 for xen-devel@lists.xenproject.org; Mon, 04 Oct 2021 14:12:03 +0000
Received: from mail-lf1-x130.google.com (unknown [2a00:1450:4864:20::130])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 6d1dcbb3-cf72-42f4-b41d-3dccba6c6d2d;
 Mon, 04 Oct 2021 14:11:59 +0000 (UTC)
Received: by mail-lf1-x130.google.com with SMTP id b20so72639255lfv.3
 for <xen-devel@lists.xenproject.org>; Mon, 04 Oct 2021 07:11:59 -0700 (PDT)
Received: from localhost.localdomain (host-176-36-245-220.b024.la.net.ua.
 [176.36.245.220])
 by smtp.gmail.com with ESMTPSA id n12sm1076809lfe.145.2021.10.04.07.11.56
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Mon, 04 Oct 2021 07:11:57 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6d1dcbb3-cf72-42f4-b41d-3dccba6c6d2d
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=6SnkOg3n8e3cKJ07G/rY49f9q+Znw0T7C7j0b8OToUE=;
        b=cG3bTjz1jG08qYOXTlqDkOVKK6Tg673becU6zGcsV/7A2cAwe7yX+KGh9RDSf3gYpq
         Kz0RCQi9yqcM2Zwsb257xGhctCVFRdpcQsF4Q+KEMyYQIhnyyC2/aYIOYtVwDJeAoQL3
         4kfFLdH20LTN2Gj4DoTAMB/dQO9EWm5x+GO5X3XTgheRLMMseqaTHTVE7AhZedsiQnO1
         7SkNLG+45kk6n8ws49Du7rmm6Gzf7moLsJCxMWgcpHUhm3HPojpIOihojoCtUH5Id6Qs
         gu5vqXMmVPkWYRaitGnOJIPy3BB46drDrXe+ierlC/yl/Qwo/2/AlRqCkoFd98fFIORz
         G/zQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=6SnkOg3n8e3cKJ07G/rY49f9q+Znw0T7C7j0b8OToUE=;
        b=mbNYvbCXX96n2XtVo3KapwZD7QfaCBRrpyCbKagBzTiaSfZN2FXx3EFAUd/GMxDy2Z
         HQXe3l0Hei4Idq+cbpnFOMsOkyMB1oLG8fj92JjJajwjrgKS6xokifrrwWv3YHkFfu8b
         UTFEK9xZCwl9tfE2lceMxJw8m5j02TQpeV6K3HuYhli/Zd6hUmaPVbK9bTvI5zf7KNej
         PB55kXZLZHWh+llTAQqnO81lujnBmkh34HOr8nbAT9RfYUgyxqUTcB3EJ89op9/qsiaN
         xOHCJuGeXx/+vTQicEhQzwKQ+Sn1Xr3IjuOc8QPjz50231gPOg8QWmSGq8CG1JeVPkoU
         9IGA==
X-Gm-Message-State: AOAM5330ddfyC3DM1/3sZFmCcCwUbCxP5BZg3MHFiWZu4o+q0j3r9QjY
	lvM0rJlLGtamp6QT0wJg4NX8tyXfJbA=
X-Google-Smtp-Source: ABdhPJzpujgVo0AAnDsvX0/mO7rPD9uSovOIu8r7ciZeOT0kK7o5OIiRJSqZhSSxGquwC3JhyagoMg==
X-Received: by 2002:a2e:7d15:: with SMTP id y21mr15846457ljc.70.1633356717899;
        Mon, 04 Oct 2021 07:11:57 -0700 (PDT)
From: Oleksandr Andrushchenko <andr2000@gmail.com>
To: xen-devel@lists.xenproject.org
Cc: julien@xen.org,
	sstabellini@kernel.org,
	oleksandr_tyshchenko@epam.com,
	volodymyr_babchuk@epam.com,
	Artem_Mygaiev@epam.com,
	roger.pau@citrix.com,
	jbeulich@suse.com,
	andrew.cooper3@citrix.com,
	george.dunlap@citrix.com,
	paul@xen.org,
	bertrand.marquis@arm.com,
	rahul.singh@arm.com,
	Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Subject: [PATCH v4 03/11] xen/arm: Introduce pci_find_host_bridge_node helper
Date: Mon,  4 Oct 2021 17:11:43 +0300
Message-Id: <20211004141151.132231-4-andr2000@gmail.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20211004141151.132231-1-andr2000@gmail.com>
References: <20211004141151.132231-1-andr2000@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>

Get host bridge node given a PCI device attached to it.

This helper will be re-used for adding PCI devices by the subsequent
patches.

Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
---
Since v2:
 - !! dropped Stefano's r-b because of the changes
 - s/PRI_pci/%pp after rebase onto Arm series
---
 xen/arch/arm/pci/pci-host-common.c | 16 ++++++++++++++++
 xen/include/asm-arm/pci.h          |  1 +
 2 files changed, 17 insertions(+)

diff --git a/xen/arch/arm/pci/pci-host-common.c b/xen/arch/arm/pci/pci-host-common.c
index 593beeb48ce4..592c01aae5bb 100644
--- a/xen/arch/arm/pci/pci-host-common.c
+++ b/xen/arch/arm/pci/pci-host-common.c
@@ -276,6 +276,22 @@ int pci_get_host_bridge_segment(const struct dt_device_node *node,
     return -EINVAL;
 }
 
+/*
+ * Get host bridge node given a device attached to it.
+ */
+struct dt_device_node *pci_find_host_bridge_node(struct device *dev)
+{
+    struct pci_host_bridge *bridge;
+    struct pci_dev *pdev = dev_to_pci(dev);
+
+    bridge = pci_find_host_bridge(pdev->seg, pdev->bus);
+    if ( unlikely(!bridge) )
+    {
+        printk(XENLOG_ERR "Unable to find PCI bridge for %pp\n", &pdev->sbdf);
+        return NULL;
+    }
+    return bridge->dt_node;
+}
 /*
  * Local variables:
  * mode: C
diff --git a/xen/include/asm-arm/pci.h b/xen/include/asm-arm/pci.h
index 603a1fc072d1..e6d4000e2ac8 100644
--- a/xen/include/asm-arm/pci.h
+++ b/xen/include/asm-arm/pci.h
@@ -99,6 +99,7 @@ void __iomem *pci_ecam_map_bus(struct pci_host_bridge *bridge,
 struct pci_host_bridge *pci_find_host_bridge(uint16_t segment, uint8_t bus);
 int pci_get_host_bridge_segment(const struct dt_device_node *node,
                                 uint16_t *segment);
+struct dt_device_node *pci_find_host_bridge_node(struct device *dev);
 
 static always_inline bool is_pci_passthrough_enabled(void)
 {
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Mon Oct 04 14:12:24 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Oct 2021 14:12:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.201469.355993 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXOhS-0000w2-Hf; Mon, 04 Oct 2021 14:12:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 201469.355993; Mon, 04 Oct 2021 14:12:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXOhS-0000vv-Db; Mon, 04 Oct 2021 14:12:14 +0000
Received: by outflank-mailman (input) for mailman id 201469;
 Mon, 04 Oct 2021 14:12:13 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=U/Qt=OY=gmail.com=andr2000@srs-us1.protection.inumbo.net>)
 id 1mXOhR-0008QG-Do
 for xen-devel@lists.xenproject.org; Mon, 04 Oct 2021 14:12:13 +0000
Received: from mail-lf1-x134.google.com (unknown [2a00:1450:4864:20::134])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 0caa8cc2-efeb-4b20-b8a3-ef921042cb49;
 Mon, 04 Oct 2021 14:12:02 +0000 (UTC)
Received: by mail-lf1-x134.google.com with SMTP id e15so72226530lfr.10
 for <xen-devel@lists.xenproject.org>; Mon, 04 Oct 2021 07:12:02 -0700 (PDT)
Received: from localhost.localdomain (host-176-36-245-220.b024.la.net.ua.
 [176.36.245.220])
 by smtp.gmail.com with ESMTPSA id n12sm1076809lfe.145.2021.10.04.07.11.58
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Mon, 04 Oct 2021 07:11:58 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0caa8cc2-efeb-4b20-b8a3-ef921042cb49
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=SW5l0COaWEZ5SQENULoKJ23OIO+t8l75C/PAXs3yYFM=;
        b=ntx/K3knoi+iSrMn9p7uItv9/iGeeiMOipiMNZeTVU5nuNZ81z0AVPCeDVNH6fFtXj
         n4FD7JaU0nV+5PfWFuErnZCLpfEGURbI5pWJ8pdUjEWUCEG5tIoS3GHEep1WgXBw9DI6
         reXVG2AwzazcS8x51rUKNBCpWtXXpuTD2hy5qg2TirkzLqK+HpYfJCO0maaOvqIFJIJd
         64CyohDiVBjsHgKJvrjFqwRLJ7OguMNaRRdZXnnsVTRUVl/HSWGqUMc2bVXrQbAiPgyw
         X8TKrtziWgyknLX3aLJouNNqrAVC72J8mtXnjzMY6gbZhVVtR+O9yrNPJLxd4ik0UcI1
         frRA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=SW5l0COaWEZ5SQENULoKJ23OIO+t8l75C/PAXs3yYFM=;
        b=yaB5SkjynifH43GaVYOJXW9S2nnBeokShVQC7o1HV00fUblIlFsxqqk5s2HcBsAC2Y
         qP9tQW+d2Dzk6nH2zbAWPfZzU2Bfsw/ZNS7eveNmkITzlZjSuCrACI0uJ7CIrlPoHFoI
         epIOfoljEcHHhnz8chdKg3Y5eibFgYG17GCditvz8Ezm6uTCJT7zh2Z1pnLIN5cSu9QY
         MA3yml5jo3oPjhsyUMbgKEmYeRfX/haPoy7PKdZW/5bimkdeIPimMd2bwlxwK6D/BfS3
         5iDckt+8dcR6aGAO2TAiNLwJsZxGJW1Qxq2LLSVROUhLpvRlEjd0jQ9YrjnAnNLh4kEh
         m8XQ==
X-Gm-Message-State: AOAM533cC6M5ZZG70Q7UwrBx/s7awn7nZtq73RoboFkr2YggJ1fgCI4A
	lYMZDWyNp1EMVAvnrLdMtzm4G8J2zx4=
X-Google-Smtp-Source: ABdhPJyavFO/o6GxpHltCcx8E2ZFYORwrVAopkK4TzGlo178OgdWxxMtjW60ncVsqyVALdP4IhHpKA==
X-Received: by 2002:a05:6512:114d:: with SMTP id m13mr2588483lfg.382.1633356719174;
        Mon, 04 Oct 2021 07:11:59 -0700 (PDT)
From: Oleksandr Andrushchenko <andr2000@gmail.com>
To: xen-devel@lists.xenproject.org
Cc: julien@xen.org,
	sstabellini@kernel.org,
	oleksandr_tyshchenko@epam.com,
	volodymyr_babchuk@epam.com,
	Artem_Mygaiev@epam.com,
	roger.pau@citrix.com,
	jbeulich@suse.com,
	andrew.cooper3@citrix.com,
	george.dunlap@citrix.com,
	paul@xen.org,
	bertrand.marquis@arm.com,
	rahul.singh@arm.com,
	Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Subject: [PATCH v4 04/11] xen/device-tree: Make dt_find_node_by_phandle global
Date: Mon,  4 Oct 2021 17:11:44 +0300
Message-Id: <20211004141151.132231-5-andr2000@gmail.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20211004141151.132231-1-andr2000@gmail.com>
References: <20211004141151.132231-1-andr2000@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>

Make dt_find_node_by_phandle globally visible, so it can be re-used by
other frameworks.

Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
---
 xen/common/device_tree.c      | 2 +-
 xen/include/xen/device_tree.h | 2 ++
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/xen/common/device_tree.c b/xen/common/device_tree.c
index ea93da1725f6..4aae281e89bf 100644
--- a/xen/common/device_tree.c
+++ b/xen/common/device_tree.c
@@ -1047,7 +1047,7 @@ int dt_for_each_range(const struct dt_device_node *dev,
  *
  * Returns a node pointer.
  */
-static struct dt_device_node *dt_find_node_by_phandle(dt_phandle handle)
+struct dt_device_node *dt_find_node_by_phandle(dt_phandle handle)
 {
     struct dt_device_node *np;
 
diff --git a/xen/include/xen/device_tree.h b/xen/include/xen/device_tree.h
index 2297c59ce66d..fd6cd00b433a 100644
--- a/xen/include/xen/device_tree.h
+++ b/xen/include/xen/device_tree.h
@@ -849,6 +849,8 @@ int dt_count_phandle_with_args(const struct dt_device_node *np,
  */
 int dt_get_pci_domain_nr(struct dt_device_node *node);
 
+struct dt_device_node *dt_find_node_by_phandle(dt_phandle handle);
+
 #ifdef CONFIG_DEVICE_TREE_DEBUG
 #define dt_dprintk(fmt, args...)  \
     printk(XENLOG_DEBUG fmt, ## args)
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Mon Oct 04 14:12:25 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Oct 2021 14:12:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.201468.355982 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXOhO-0000ac-2A; Mon, 04 Oct 2021 14:12:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 201468.355982; Mon, 04 Oct 2021 14:12:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXOhN-0000aT-Ul; Mon, 04 Oct 2021 14:12:09 +0000
Received: by outflank-mailman (input) for mailman id 201468;
 Mon, 04 Oct 2021 14:12:08 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=U/Qt=OY=gmail.com=andr2000@srs-us1.protection.inumbo.net>)
 id 1mXOhM-0008QG-DX
 for xen-devel@lists.xenproject.org; Mon, 04 Oct 2021 14:12:08 +0000
Received: from mail-lf1-x136.google.com (unknown [2a00:1450:4864:20::136])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 2a84c4a3-d15a-4ce4-b8c6-68ed5b4f4ef1;
 Mon, 04 Oct 2021 14:11:59 +0000 (UTC)
Received: by mail-lf1-x136.google.com with SMTP id x27so72243825lfu.5
 for <xen-devel@lists.xenproject.org>; Mon, 04 Oct 2021 07:11:59 -0700 (PDT)
Received: from localhost.localdomain (host-176-36-245-220.b024.la.net.ua.
 [176.36.245.220])
 by smtp.gmail.com with ESMTPSA id n12sm1076809lfe.145.2021.10.04.07.11.55
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Mon, 04 Oct 2021 07:11:56 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2a84c4a3-d15a-4ce4-b8c6-68ed5b4f4ef1
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=mico79NSg1dTzXgY8IQRVxF4SlAfW6DJKkQE/et5l+E=;
        b=ICTepnxsockaYNS6J7TvmXTgJKo44BlX5+Dwx/rzhbLH9pAOqtVErpd8UCPGo6wHei
         vDMr2/dAU8tinEvhYOkGYarLsqxSUu9fSU6vVD6oZrIZFLcx0cL8AQXeLk0RU233XNFY
         buy5VZZ137b3oTlIiiwmd+6SO72Pfe/8FI6EgG+YXljtjB2J8el+FU2tLYNEaSKyt5i5
         6uwEzOunBNDhnCC3oDDg3cLkSRA5wxFTSTbLYZ/C9ybq607EV5l7tPzMKAi07PQEqrrV
         odMDsApervGjMsT8Dg93Nt4gbuXCMesvjhmBB5LH4vNceiuQjQ/H7wS88eqTJK5xme+s
         ExXw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=mico79NSg1dTzXgY8IQRVxF4SlAfW6DJKkQE/et5l+E=;
        b=2L0eAwl9kOv1i2W/X6CC3FV5p7mHIlopnO5157zxA1fm1ZrjQ9neAJieC4vlU85uG+
         6bVIiUFuDL0q87t4UP4JoYg1Po98ycq5RnNFaiEAgnOgCjk6G40GeX+bV12JiONQFg8k
         7VkliVHliZx7X2DIKquvkhOIw6LoZxZ9TvKFZKupnKLZhOOFv/LOlsBZC+NVbC5IYEMV
         evbTCDwJwUfNWzcFhqWQAl/2WEC1VM6jkhtwgSa2b5dQIrYjEK+07ZTqavoj6TSP6KrC
         3MkKhZv1kuSRvvAVL/EN6rwK8Pd/sXAHywroPyHgtkndnUeJJro9V9M0e5TO/6Y0QXdF
         9Auw==
X-Gm-Message-State: AOAM530tHiOedjao5shnxnDp+xM9yMZoerJoi7hpcuDOUkNBRxwBf7ak
	EzUoc0ZajR+jbJ2/1mbDavAoRPwepqA=
X-Google-Smtp-Source: ABdhPJx6BLkwzCWXnYzL8PCkpvh5BukwzmSkRNCjUNZQtrb5PtZlYg9g1G4HfyIGbc5giXQbXeZV3Q==
X-Received: by 2002:ac2:5e31:: with SMTP id o17mr15074866lfg.36.1633356716497;
        Mon, 04 Oct 2021 07:11:56 -0700 (PDT)
From: Oleksandr Andrushchenko <andr2000@gmail.com>
To: xen-devel@lists.xenproject.org
Cc: julien@xen.org,
	sstabellini@kernel.org,
	oleksandr_tyshchenko@epam.com,
	volodymyr_babchuk@epam.com,
	Artem_Mygaiev@epam.com,
	roger.pau@citrix.com,
	jbeulich@suse.com,
	andrew.cooper3@citrix.com,
	george.dunlap@citrix.com,
	paul@xen.org,
	bertrand.marquis@arm.com,
	rahul.singh@arm.com,
	Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Subject: [PATCH v4 02/11] xen/arm: Add new device type for PCI
Date: Mon,  4 Oct 2021 17:11:42 +0300
Message-Id: <20211004141151.132231-3-andr2000@gmail.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20211004141151.132231-1-andr2000@gmail.com>
References: <20211004141151.132231-1-andr2000@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>

Add new device type (DEV_PCI) to distinguish PCI devices from platform
DT devices, so some drivers, like IOMMU, can handle PCI devices
differently.

Also add a helper which is when given a struct device returns the
corresponding struct pci_dev which this device is a part of.

Because of the header cross-dependencies, e.g. we need both
struct pci_dev and struct arch_pci_dev at the same time, this cannot be
done with an inline.

Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
---
Since v2:
 - !! dropped Stefano's r-b because of the changes
 - simplified dev_to_pci to use a single
   container_of(dev, struct pci_dev, arch.dev) (Jan)
Since v1:
 - Folded new device type (DEV_PCI) into this patch.
---
 xen/arch/arm/pci/pci.c       | 7 +++++++
 xen/include/asm-arm/device.h | 4 ++--
 xen/include/asm-arm/pci.h    | 7 +++++++
 3 files changed, 16 insertions(+), 2 deletions(-)

diff --git a/xen/arch/arm/pci/pci.c b/xen/arch/arm/pci/pci.c
index 73540045d187..138da19284ab 100644
--- a/xen/arch/arm/pci/pci.c
+++ b/xen/arch/arm/pci/pci.c
@@ -27,6 +27,13 @@ int arch_pci_clean_pirqs(struct domain *d)
     return 0;
 }
 
+struct pci_dev *dev_to_pci(struct device *dev)
+{
+    ASSERT(dev->type == DEV_PCI);
+
+    return container_of(dev, struct pci_dev, arch.dev);
+}
+
 static int __init dt_pci_init(void)
 {
     struct dt_device_node *np;
diff --git a/xen/include/asm-arm/device.h b/xen/include/asm-arm/device.h
index ebe84ea853cd..7bf040560363 100644
--- a/xen/include/asm-arm/device.h
+++ b/xen/include/asm-arm/device.h
@@ -4,6 +4,7 @@
 enum device_type
 {
     DEV_DT,
+    DEV_PCI,
 };
 
 struct dev_archdata {
@@ -25,8 +26,7 @@ typedef struct device device_t;
 
 #include <xen/device_tree.h>
 
-/* TODO: Correctly implement dev_is_pci when PCI is supported on ARM */
-#define dev_is_pci(dev) ((void)(dev), 0)
+#define dev_is_pci(dev) ((dev)->type == DEV_PCI)
 #define dev_is_dt(dev)  ((dev)->type == DEV_DT)
 
 enum device_class
diff --git a/xen/include/asm-arm/pci.h b/xen/include/asm-arm/pci.h
index 7cb2e2f1edaf..603a1fc072d1 100644
--- a/xen/include/asm-arm/pci.h
+++ b/xen/include/asm-arm/pci.h
@@ -26,6 +26,13 @@ struct arch_pci_dev {
     struct device dev;
 };
 
+/*
+ * Because of the header cross-dependencies, e.g. we need both
+ * struct pci_dev and struct arch_pci_dev at the same time, this cannot be
+ * done with an inline here. Macro can be implemented, but looks scary.
+ */
+struct pci_dev *dev_to_pci(struct device *dev);
+
 /* Arch-specific MSI data for vPCI. */
 struct vpci_arch_msi {
 };
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Mon Oct 04 14:12:29 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Oct 2021 14:12:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.201470.356003 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXOhX-0001ON-Qq; Mon, 04 Oct 2021 14:12:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 201470.356003; Mon, 04 Oct 2021 14:12:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXOhX-0001OC-Nb; Mon, 04 Oct 2021 14:12:19 +0000
Received: by outflank-mailman (input) for mailman id 201470;
 Mon, 04 Oct 2021 14:12:18 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=U/Qt=OY=gmail.com=andr2000@srs-us1.protection.inumbo.net>)
 id 1mXOhW-0008QG-E8
 for xen-devel@lists.xenproject.org; Mon, 04 Oct 2021 14:12:18 +0000
Received: from mail-lf1-x12a.google.com (unknown [2a00:1450:4864:20::12a])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 2b54face-c132-49cc-8c13-b830f68026ae;
 Mon, 04 Oct 2021 14:12:03 +0000 (UTC)
Received: by mail-lf1-x12a.google.com with SMTP id m3so71513774lfu.2
 for <xen-devel@lists.xenproject.org>; Mon, 04 Oct 2021 07:12:03 -0700 (PDT)
Received: from localhost.localdomain (host-176-36-245-220.b024.la.net.ua.
 [176.36.245.220])
 by smtp.gmail.com with ESMTPSA id n12sm1076809lfe.145.2021.10.04.07.11.53
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Mon, 04 Oct 2021 07:11:54 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2b54face-c132-49cc-8c13-b830f68026ae
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=IBrpPALaHgEu2bRfUzTni2BaAuDBWtjiAy9s9dEtWuo=;
        b=Ez3QUU4M+ZzyRJzYI7PxNH6KFybpw2X52IIyCfolA/goD64BD0H1ylyW/UjcmfXbQm
         T9LUfCMCd3cOx44P7lzDKzq6KTS04CXPeOjx3ExEBRD6chKSC8hwx+jzUciYnpJh+Q9x
         xJh0RPoWKHUuZGpX41d2p6iEbR4DbO6Yjd85Fk5ZRu7Dcj/sAXHyv5QZewIDyPOrbbWf
         Uj1298AJ46nwJev0K9WD/T4PsdnpR0B7Q32JIVWIs4+SOeN3ey1J1yEOxkEVddEpkjGw
         ADp+s6yhOEDIMVO4uG7g5QzmzXKwqkgE1JmHfTe+wak/eKZ3zBIoxyjR158UG5pHKTAL
         +EKw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=IBrpPALaHgEu2bRfUzTni2BaAuDBWtjiAy9s9dEtWuo=;
        b=aa6fEVcu68NwYYn3aCywFJk7NwPSk8RorkdQPg9V6DdfCr/13jNoFrqllZkwMcA+/t
         68gJFB9+HNk17IA0aOksf7wnSHrw/YQwTUuDpxfb97cd1v23qBey6sfty18mMiYUPdvH
         JQqeXYVmM/2t3h7OAuiM3KqznuzBoylmpAzzR5zR18BtFLgCtOa6hFWg1DOBdW54Yz28
         CNsmWSeUsZmTnBYCQMYxnJlhgWFJFbJhsaTCYZIZp9SwpWIDWz6BjEG7n7pHyZj16eZo
         KDMLZe3dXytJALAqAacB2Yd9hbEopnM9fGSk5zHZ2nAeEd41nblNpmIJGbXYVDDLccmy
         6Rpg==
X-Gm-Message-State: AOAM532eE2z13AjRfdckATepEJ7RaTChM99IgTxPBX1b3uhgEugVbRrY
	APJUntPNmquJzMFjKdZl0/vIbkA73iQ=
X-Google-Smtp-Source: ABdhPJz1SHMt2ZTDbeA6PPu/8DUsuEKadrrUL9iIVMY3wTj3Updc7wVxwvB7+bWha+S4A5GsivnE5A==
X-Received: by 2002:a05:6512:3d86:: with SMTP id k6mr15180736lfv.120.1633356715255;
        Mon, 04 Oct 2021 07:11:55 -0700 (PDT)
From: Oleksandr Andrushchenko <andr2000@gmail.com>
To: xen-devel@lists.xenproject.org
Cc: julien@xen.org,
	sstabellini@kernel.org,
	oleksandr_tyshchenko@epam.com,
	volodymyr_babchuk@epam.com,
	Artem_Mygaiev@epam.com,
	roger.pau@citrix.com,
	jbeulich@suse.com,
	andrew.cooper3@citrix.com,
	george.dunlap@citrix.com,
	paul@xen.org,
	bertrand.marquis@arm.com,
	rahul.singh@arm.com,
	Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>,
	Michal Orzel <michal.orzel@arm.com>
Subject: [PATCH v4 01/11] xen/arm: Fix dev_is_dt macro definition
Date: Mon,  4 Oct 2021 17:11:41 +0300
Message-Id: <20211004141151.132231-2-andr2000@gmail.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20211004141151.132231-1-andr2000@gmail.com>
References: <20211004141151.132231-1-andr2000@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>

This macro is not currently used, but still has an error in it:
a missing parenthesis. Fix this, so the macro is properly defined.

Fixes: 6c5d3075d97e ("xen/arm: Introduce a generic way to describe device")

Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
Reviewed-by: Michal Orzel <michal.orzel@arm.com>
---
New in v2
---
 xen/include/asm-arm/device.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/include/asm-arm/device.h b/xen/include/asm-arm/device.h
index 5ecd5e7bd15e..ebe84ea853cd 100644
--- a/xen/include/asm-arm/device.h
+++ b/xen/include/asm-arm/device.h
@@ -27,7 +27,7 @@ typedef struct device device_t;
 
 /* TODO: Correctly implement dev_is_pci when PCI is supported on ARM */
 #define dev_is_pci(dev) ((void)(dev), 0)
-#define dev_is_dt(dev)  ((dev->type == DEV_DT)
+#define dev_is_dt(dev)  ((dev)->type == DEV_DT)
 
 enum device_class
 {
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Mon Oct 04 14:12:35 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Oct 2021 14:12:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.201472.356015 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXOhd-0001sH-6O; Mon, 04 Oct 2021 14:12:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 201472.356015; Mon, 04 Oct 2021 14:12:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXOhd-0001rx-1k; Mon, 04 Oct 2021 14:12:25 +0000
Received: by outflank-mailman (input) for mailman id 201472;
 Mon, 04 Oct 2021 14:12:23 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=U/Qt=OY=gmail.com=andr2000@srs-us1.protection.inumbo.net>)
 id 1mXOhb-0008QG-EE
 for xen-devel@lists.xenproject.org; Mon, 04 Oct 2021 14:12:23 +0000
Received: from mail-lf1-x12a.google.com (unknown [2a00:1450:4864:20::12a])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 2fadc80f-0717-4551-9792-16413c61196a;
 Mon, 04 Oct 2021 14:12:04 +0000 (UTC)
Received: by mail-lf1-x12a.google.com with SMTP id y26so72533785lfa.11
 for <xen-devel@lists.xenproject.org>; Mon, 04 Oct 2021 07:12:04 -0700 (PDT)
Received: from localhost.localdomain (host-176-36-245-220.b024.la.net.ua.
 [176.36.245.220])
 by smtp.gmail.com with ESMTPSA id n12sm1076809lfe.145.2021.10.04.07.12.00
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Mon, 04 Oct 2021 07:12:01 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2fadc80f-0717-4551-9792-16413c61196a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=+Ihu8WIsBNrrd/XYg45D3f8fvmiiGUNqVLLkujQ3kSQ=;
        b=P7FVi5NuBKlmOjDovaxcHsNZRDofWPqtuFCfvvhbn0xNCa0CQGm89iQ9ZsvGJHba3W
         s0f5tFt5ltgrt9gCI/v0qEQ4tWx46I7yfrTBL5+LjQgHSvExeS7i8YHyIEk+uITRBdYl
         xQKpm3kBFS0rrUNOia93qQaHI/rgNOPYn0A+L+EdmwQ1PF4sY9k0BAm/ITZBA8ukHi57
         zegm3KJSAhzxH1euJoHijWltm001sKQZLIgyTPVTQ7Kcqx22lxIdPkH5WirvXb/B3H3k
         t/jHyx/x+IBolejEuaeFJQPty82Xg1nmIAfwiAxBQcMOXJzBMeIyooNJ421SRnxcMr8L
         5SwQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=+Ihu8WIsBNrrd/XYg45D3f8fvmiiGUNqVLLkujQ3kSQ=;
        b=fOd3X2cdTrQKewA6Hg0czKql6yQocTYUg53F+hE3UMYicwdw5f8s/9nVoiVXOQjUXZ
         o2Yf0LWjpiqHlj25eWBX4MpqaPa5RykHQSkoMXh4+fheOiZiq1V+z2ApcSw8v3Tqp9Sb
         k9YE91JgJPsMoxFM32KO7WYLnxxuUCQ3NU+oZJ83MoQZCi9eWg8EiWJXOijMQ/sjehkn
         oq1Id5FoOJQXoABV3gFDAUxV0NW4AkaKW0cILrfYTiug121wEfdOPvr8h0AP2rTrYV6Q
         qbD5NAsRx/3DoXJVnfwzitf0+LwGJzWvdM0LajPXxyTVfI2cSdpPLAU95I6Dw32CmlM6
         GL2Q==
X-Gm-Message-State: AOAM533a0ftl8/KWO5twyE23aoZhzK0dRtTgNe+MDD5u76SnTUk8fIGZ
	yTyzdvDq7kNuekYzn8j0MJi8jlUOua0=
X-Google-Smtp-Source: ABdhPJyHpK9g16BM2BPUWlUCc1BuvoSI7jQvDCN3PstgDPofILOIH1rVzq6oomDhq2WyFkeAx9W9kg==
X-Received: by 2002:a05:6512:3e1e:: with SMTP id i30mr14503161lfv.273.1633356722040;
        Mon, 04 Oct 2021 07:12:02 -0700 (PDT)
From: Oleksandr Andrushchenko <andr2000@gmail.com>
To: xen-devel@lists.xenproject.org
Cc: julien@xen.org,
	sstabellini@kernel.org,
	oleksandr_tyshchenko@epam.com,
	volodymyr_babchuk@epam.com,
	Artem_Mygaiev@epam.com,
	roger.pau@citrix.com,
	jbeulich@suse.com,
	andrew.cooper3@citrix.com,
	george.dunlap@citrix.com,
	paul@xen.org,
	bertrand.marquis@arm.com,
	rahul.singh@arm.com,
	Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Subject: [PATCH v4 06/11] xen/domain: Call pci_release_devices() when releasing domain resources
Date: Mon,  4 Oct 2021 17:11:46 +0300
Message-Id: <20211004141151.132231-7-andr2000@gmail.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20211004141151.132231-1-andr2000@gmail.com>
References: <20211004141151.132231-1-andr2000@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>

This is the very same that we already do for DT devices. Moreover, x86
already calls pci_release_devices().

Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
---
Since v1:
 - re-wording in the commit message
---
 xen/arch/arm/domain.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
index fbb52f78f1a6..79012bf77757 100644
--- a/xen/arch/arm/domain.c
+++ b/xen/arch/arm/domain.c
@@ -985,7 +985,8 @@ static int relinquish_memory(struct domain *d, struct page_list_head *list)
  * function which may return -ERESTART.
  */
 enum {
-    PROG_tee = 1,
+    PROG_pci = 1,
+    PROG_tee,
     PROG_xen,
     PROG_page,
     PROG_mapping,
@@ -1022,6 +1023,12 @@ int domain_relinquish_resources(struct domain *d)
 #ifdef CONFIG_IOREQ_SERVER
         ioreq_server_destroy_all(d);
 #endif
+#ifdef CONFIG_HAS_PCI
+    PROGRESS(pci):
+        ret = pci_release_devices(d);
+        if ( ret )
+            return ret;
+#endif
 
     PROGRESS(tee):
         ret = tee_relinquish_resources(d);
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Mon Oct 04 14:12:39 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Oct 2021 14:12:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.201475.356026 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXOhh-0002Qc-Iq; Mon, 04 Oct 2021 14:12:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 201475.356026; Mon, 04 Oct 2021 14:12:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXOhh-0002QP-DG; Mon, 04 Oct 2021 14:12:29 +0000
Received: by outflank-mailman (input) for mailman id 201475;
 Mon, 04 Oct 2021 14:12:28 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=U/Qt=OY=gmail.com=andr2000@srs-us1.protection.inumbo.net>)
 id 1mXOhg-0008QG-EO
 for xen-devel@lists.xenproject.org; Mon, 04 Oct 2021 14:12:28 +0000
Received: from mail-lf1-x132.google.com (unknown [2a00:1450:4864:20::132])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id e72701a1-b62e-4ec6-ab73-34ca2ca8a6d9;
 Mon, 04 Oct 2021 14:12:04 +0000 (UTC)
Received: by mail-lf1-x132.google.com with SMTP id e15so72226937lfr.10
 for <xen-devel@lists.xenproject.org>; Mon, 04 Oct 2021 07:12:04 -0700 (PDT)
Received: from localhost.localdomain (host-176-36-245-220.b024.la.net.ua.
 [176.36.245.220])
 by smtp.gmail.com with ESMTPSA id n12sm1076809lfe.145.2021.10.04.07.11.59
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Mon, 04 Oct 2021 07:12:00 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e72701a1-b62e-4ec6-ab73-34ca2ca8a6d9
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=Nrv8Q7YNNTYEmccS6yS28+CJYz+9hljBpl00ZO95JOI=;
        b=nHuD21akS1FNyvIKBPdF6k+GqRtBWoOQJqggbF4XIO3yURxuakjo8JjEARjNGJ/4Mg
         WfTvVAT5I5o6ZU+MbvJb3Tj/KcCPI6VoaqiJ05HXRRTiBm6t34rg3/m85WvcLmfrowJ/
         R+UZsE1C8easZFmv5iXiFnTWuyAcJmxcsF/+zx8ga1h717rcjGaa3rXtvoUXWepavkEB
         xMbCejYM6qEP67QHbHlDsoLkV02Bs/+PHQs1KeNnVEsc5tziliRzG9hXNw/SQZJdbJpU
         7FqiFK2kY1BHxmUJ0gGQEzHT52jM8K8KbD8pNBWW82B46ohRvq9PRq8wRq4xIqY3NGL7
         wZsQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=Nrv8Q7YNNTYEmccS6yS28+CJYz+9hljBpl00ZO95JOI=;
        b=QkDa5yPT6MEIkGHtzxSfHoY9oQ5yDxQYOlKlcKImX2oXCjqhNNBa0fJGCyIJjJrBWG
         jgnzn5nj3zmQfrlhibpG5ZS5lGQzvlxy53rvjW2oL2EJ6ZXfyLlJPhnS0Y/tEvvq44yg
         c0GhH+MT0LhM9QaQa/pUaurmuojJX+UfUgHBayJYUJauIg1YedzX5y3ytvrSwZ+Pohbg
         cg4iiXG4hzCJF3rrMBlbXNnABUCNlE/fUHofRCM/PntR0PCBTRi/vinM8GHTKz4Uumw2
         uRt6dt9tsGO4yFoNVFjiGTkBURYFXA0ZVPoZ9O3iJRe3BUgKI7xw26q3TbOZvFMyiJPD
         lBKg==
X-Gm-Message-State: AOAM5314s+tBHfc6+nFKEqzGMNnwvEjX9HO1odES1Emx1DEns/zQfNnK
	hR2EMJcrxWuzjVwbxKbdqaj+dx46bWQ=
X-Google-Smtp-Source: ABdhPJx9kKhnJbCVxMMJxRpcRGYsGoLBXte/mgqMMAh+YYTdLQh7eBnZZ9pPdA0Flx+hyPuS8jf1JQ==
X-Received: by 2002:a2e:9cd:: with SMTP id 196mr16213782ljj.434.1633356720823;
        Mon, 04 Oct 2021 07:12:00 -0700 (PDT)
From: Oleksandr Andrushchenko <andr2000@gmail.com>
To: xen-devel@lists.xenproject.org
Cc: julien@xen.org,
	sstabellini@kernel.org,
	oleksandr_tyshchenko@epam.com,
	volodymyr_babchuk@epam.com,
	Artem_Mygaiev@epam.com,
	roger.pau@citrix.com,
	jbeulich@suse.com,
	andrew.cooper3@citrix.com,
	george.dunlap@citrix.com,
	paul@xen.org,
	bertrand.marquis@arm.com,
	rahul.singh@arm.com,
	Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Subject: [PATCH v4 05/11] xen/arm: Mark device as PCI while creating one
Date: Mon,  4 Oct 2021 17:11:45 +0300
Message-Id: <20211004141151.132231-6-andr2000@gmail.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20211004141151.132231-1-andr2000@gmail.com>
References: <20211004141151.132231-1-andr2000@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>

While adding a PCI device mark it as such, so other frameworks
can distinguish it from DT devices.
For that introduce an architecture defined helper which may perform
additional initialization of the newly created PCI device.

Cc: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Paul Durrant <paul@xen.org>
Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
[applicable parts]
Acked-by: Jan Beulich <jbeulich@suse.com>
---
Since v3:
- fixed Arm build without CONFIG_HAS_PCI
Since v2:
 - !! dropped Stefano's r-b because of the changes
 - introduced arch_pci_init_pdev (Jan)
Since v1:
 - moved the assignment from iommu_add_device to alloc_pdev
---
 xen/arch/arm/pci/pci.c        | 5 +++++
 xen/drivers/passthrough/pci.c | 2 ++
 xen/include/asm-arm/pci.h     | 7 +++++++
 xen/include/asm-x86/pci.h     | 2 ++
 4 files changed, 16 insertions(+)

diff --git a/xen/arch/arm/pci/pci.c b/xen/arch/arm/pci/pci.c
index 138da19284ab..082c14e127a8 100644
--- a/xen/arch/arm/pci/pci.c
+++ b/xen/arch/arm/pci/pci.c
@@ -34,6 +34,11 @@ struct pci_dev *dev_to_pci(struct device *dev)
     return container_of(dev, struct pci_dev, arch.dev);
 }
 
+void arch_pci_init_pdev(struct pci_dev *pdev)
+{
+    pci_to_dev(pdev)->type = DEV_PCI;
+}
+
 static int __init dt_pci_init(void)
 {
     struct dt_device_node *np;
diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci.c
index b36d5a481162..9e6246afeef5 100644
--- a/xen/drivers/passthrough/pci.c
+++ b/xen/drivers/passthrough/pci.c
@@ -329,6 +329,8 @@ static struct pci_dev *alloc_pdev(struct pci_seg *pseg, u8 bus, u8 devfn)
     *((u8*) &pdev->devfn) = devfn;
     pdev->domain = NULL;
 
+    arch_pci_init_pdev(pdev);
+
     rc = pdev_msi_init(pdev);
     if ( rc )
     {
diff --git a/xen/include/asm-arm/pci.h b/xen/include/asm-arm/pci.h
index e6d4000e2ac8..ea87ec6006fc 100644
--- a/xen/include/asm-arm/pci.h
+++ b/xen/include/asm-arm/pci.h
@@ -105,6 +105,9 @@ static always_inline bool is_pci_passthrough_enabled(void)
 {
     return pci_passthrough_enabled;
 }
+
+void arch_pci_init_pdev(struct pci_dev *pdev);
+
 #else   /*!CONFIG_HAS_PCI*/
 
 struct arch_pci_dev { };
@@ -121,5 +124,9 @@ static inline int pci_get_host_bridge_segment(const struct dt_device_node *node,
     return -EINVAL;
 }
 
+struct pci_dev;
+
+static inline void arch_pci_init_pdev(struct pci_dev *pdev) {}
+
 #endif  /*!CONFIG_HAS_PCI*/
 #endif /* __ARM_PCI_H__ */
diff --git a/xen/include/asm-x86/pci.h b/xen/include/asm-x86/pci.h
index c4a4fdcbc239..443f25347d08 100644
--- a/xen/include/asm-x86/pci.h
+++ b/xen/include/asm-x86/pci.h
@@ -36,4 +36,6 @@ static always_inline bool is_pci_passthrough_enabled(void)
     return true;
 }
 
+static inline void arch_pci_init_pdev(struct pci_dev *pdev) {}
+
 #endif /* __X86_PCI_H__ */
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Mon Oct 04 14:12:45 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Oct 2021 14:12:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.201478.356036 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXOhm-00037I-SV; Mon, 04 Oct 2021 14:12:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 201478.356036; Mon, 04 Oct 2021 14:12:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXOhm-000373-Nc; Mon, 04 Oct 2021 14:12:34 +0000
Received: by outflank-mailman (input) for mailman id 201478;
 Mon, 04 Oct 2021 14:12:33 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=U/Qt=OY=gmail.com=andr2000@srs-us1.protection.inumbo.net>)
 id 1mXOhl-0008QG-ER
 for xen-devel@lists.xenproject.org; Mon, 04 Oct 2021 14:12:33 +0000
Received: from mail-lf1-x12d.google.com (unknown [2a00:1450:4864:20::12d])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 7e868626-1a8c-4afb-a1b9-319849fb2127;
 Mon, 04 Oct 2021 14:12:05 +0000 (UTC)
Received: by mail-lf1-x12d.google.com with SMTP id y26so72533951lfa.11
 for <xen-devel@lists.xenproject.org>; Mon, 04 Oct 2021 07:12:05 -0700 (PDT)
Received: from localhost.localdomain (host-176-36-245-220.b024.la.net.ua.
 [176.36.245.220])
 by smtp.gmail.com with ESMTPSA id n12sm1076809lfe.145.2021.10.04.07.12.02
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Mon, 04 Oct 2021 07:12:02 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7e868626-1a8c-4afb-a1b9-319849fb2127
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=WDh679uaxt3D3xG8n+dCNUszLzt3im/1WQOSXJPkVhE=;
        b=HIvpuPPvTQxm3OTLHvl+Tw3Oj3SBy3az2jhK/UzxV42Oc9je52k9hFyz6y33ZEuQSX
         WzcUKPT99S0mmEQUwgbSIXjgTzQ/yY586VLPk2uvwSr3rpCyVlUrTppqznKhsN5E2/YB
         UldBiS9bJ/fs4Tm+CzQDybmbQCMQJvX43OR8cy+SWzUD6lNAzcEVHYznJ4U47WrLi5t9
         W0iaARnFPLag0YC+LhHxM10iyfTdPkEfon74PSjA05kLmtrdgry+vjRJ8PHsKMCo9EZ8
         paDkuXb69ZcUT8Vhy85wLax9E3bpHx6FCiuR6ATpH9r8kwiHO+2ZO6sugk1s+S3dWlZA
         Un/g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=WDh679uaxt3D3xG8n+dCNUszLzt3im/1WQOSXJPkVhE=;
        b=0LpYe6gN9R44hRo2SPLtZwQD7w2QvT/bSGJqyW1Wb0Apj735JTgdHQa2ISLq3hPEaw
         yQQ53eRMtB00KUY4iTl7YMFBlAIDbqXYqfhjUpOd9wkFLvNFoHWVwd/eAKG04TTATYoW
         cNBv1VNH2MFUFHmF2LGuV+6JQzoH/BojL8XSJbr1FWA/Z23ERKo6CfB65JcAJWW2OMQM
         Hx8H3tgQ6m6xZ4iEjRvGH7hW/xGhuDR7fRvMSFXdafpJb3lgTybgLKZUDn5FnR65bP2+
         HczLoeGtR7Ns5XJCAeYhrFabmIGc64nrP+UR1lwjTpqjm3n2+0cmATFUMUritRvTGvsA
         qQQQ==
X-Gm-Message-State: AOAM531C2lLWnd7WS2fQ21eDBYp7FAvV366bTCd3i3jskZYQ08+BczSV
	X24zsjEVmKlV/sHGoai/hFcROoHnSgmzBw==
X-Google-Smtp-Source: ABdhPJxAec2PEhmXVf/JTyEZPASdhB7S68QQTKy/dhI+wiEenp0e1SIg5plQ7m+2kt83+jHKWv7Dsg==
X-Received: by 2002:a2e:70a:: with SMTP id 10mr16039162ljh.89.1633356723577;
        Mon, 04 Oct 2021 07:12:03 -0700 (PDT)
From: Oleksandr Andrushchenko <andr2000@gmail.com>
To: xen-devel@lists.xenproject.org
Cc: julien@xen.org,
	sstabellini@kernel.org,
	oleksandr_tyshchenko@epam.com,
	volodymyr_babchuk@epam.com,
	Artem_Mygaiev@epam.com,
	roger.pau@citrix.com,
	jbeulich@suse.com,
	andrew.cooper3@citrix.com,
	george.dunlap@citrix.com,
	paul@xen.org,
	bertrand.marquis@arm.com,
	rahul.singh@arm.com,
	Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>,
	Ian Jackson <iwj@xenproject.org>,
	Juergen Gross <jgross@suse.com>
Subject: [PATCH v4 07/11] libxl: Allow removing PCI devices for all types of domains
Date: Mon,  4 Oct 2021 17:11:47 +0300
Message-Id: <20211004141151.132231-8-andr2000@gmail.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20211004141151.132231-1-andr2000@gmail.com>
References: <20211004141151.132231-1-andr2000@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>

The PCI device remove path may now be used by PVH on ARM, so the
assert is no longer valid.

Cc: Ian Jackson <iwj@xenproject.org>
Cc: Juergen Gross <jgross@suse.com>
Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Acked-by: Stefano Stabellini <sstabellini@kernel.org>
---
 tools/libs/light/libxl_pci.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/tools/libs/light/libxl_pci.c b/tools/libs/light/libxl_pci.c
index 1a1c2630803b..59f3686fc85e 100644
--- a/tools/libs/light/libxl_pci.c
+++ b/tools/libs/light/libxl_pci.c
@@ -1947,8 +1947,6 @@ static void do_pci_remove(libxl__egc *egc, pci_remove_state *prs)
             goto out_fail;
         }
     } else {
-        assert(type == LIBXL_DOMAIN_TYPE_PV);
-
         char *sysfs_path = GCSPRINTF(SYSFS_PCI_DEV"/"PCI_BDF"/resource", pci->domain,
                                      pci->bus, pci->dev, pci->func);
         FILE *f = fopen(sysfs_path, "r");
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Mon Oct 04 14:12:55 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Oct 2021 14:12:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.201485.356048 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXOhx-0003xn-5h; Mon, 04 Oct 2021 14:12:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 201485.356048; Mon, 04 Oct 2021 14:12:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXOhx-0003xS-1J; Mon, 04 Oct 2021 14:12:45 +0000
Received: by outflank-mailman (input) for mailman id 201485;
 Mon, 04 Oct 2021 14:12:43 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=U/Qt=OY=gmail.com=andr2000@srs-us1.protection.inumbo.net>)
 id 1mXOhv-0008QG-ET
 for xen-devel@lists.xenproject.org; Mon, 04 Oct 2021 14:12:43 +0000
Received: from mail-lf1-x12b.google.com (unknown [2a00:1450:4864:20::12b])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 184555a2-32a8-4530-a7e4-70f36408f919;
 Mon, 04 Oct 2021 14:12:09 +0000 (UTC)
Received: by mail-lf1-x12b.google.com with SMTP id j5so67294813lfg.8
 for <xen-devel@lists.xenproject.org>; Mon, 04 Oct 2021 07:12:09 -0700 (PDT)
Received: from localhost.localdomain (host-176-36-245-220.b024.la.net.ua.
 [176.36.245.220])
 by smtp.gmail.com with ESMTPSA id n12sm1076809lfe.145.2021.10.04.07.12.03
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Mon, 04 Oct 2021 07:12:04 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 184555a2-32a8-4530-a7e4-70f36408f919
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=WtoV9kcozcsPgkYbTZ9sQ3MmnsSfH8oWiuIZRPzZ8Ac=;
        b=AZ+cyo6GcrFP4hY/gE6hDkzOR9T02GILiuinadnUzET4hfCR1Srfx/E6RgvAfWIsa9
         bOBBw36L/JXpoXRYFTZfST5OU9O/ZvWkROEQV1EDN9Fg5Hh0qKTUgclN/86LumqYrGh+
         d8oJZUnRALtfC/3d9KlBg9W0gofCLJtG/e94oiI2xezAxfCFME0HLP0IGsEjZ4qqU5O0
         xo6c5yOSz8p9zKMK39OwMYQ7KerZe0xpGbLWH0dJFmyqPOLDnbh1h9Yvj7EkkcIydy0b
         zzVpfDeq15pPw2oVD9CMCHKz7qG4zlF1QBSUu8vKTUMukFUoqL+JL30pEka2uvB8161b
         87fA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=WtoV9kcozcsPgkYbTZ9sQ3MmnsSfH8oWiuIZRPzZ8Ac=;
        b=g76AWiFkunYJpGkh9LvTH2CM+ICema9Q/9bdXuqmiicfGkHs+YaGAyURDFMnY8peqp
         IvwD1Zmko30jBQM5KJU2acIWHfESy/SPBel+hAEHW0KehaVbcfWfi4NEgodjXMCPrK1N
         de5MzRIJ3TxoJ9/ZkzMR6e6HHbQfPyrq9Q4pPiTVUo4Mi3oNFgaijHF2ROLl+DedFe1y
         D3Ptqn79UgDnd7EuR+H3BA3wR+DgWMY98fREu4UheRIHBA3yH3HR4Yg3BvuMZ3yVRVMC
         ovYr5fMd7+IdZ+iKKujInT+dhBJmEJFnl0kVM7XU6Wk0hiJB4ZVhtEuwewrKl9KAVFUa
         vRRA==
X-Gm-Message-State: AOAM532LzBWOCwRO0Tqru80vBtfRNMqZ+Quv8hafIozh2Ii5BGn4DLwz
	TDNCWCWN87GfH+B+oj6dc2sfD0g6arQvGw==
X-Google-Smtp-Source: ABdhPJx7yYnDt/IPOUn/fYX+ZAr0w8Wz5KXnxNDbO6A4Jyp69+rQKY5NEvMdRFUBepGVdWzeBMqIUg==
X-Received: by 2002:a05:6512:1053:: with SMTP id c19mr14669899lfb.283.1633356725200;
        Mon, 04 Oct 2021 07:12:05 -0700 (PDT)
From: Oleksandr Andrushchenko <andr2000@gmail.com>
To: xen-devel@lists.xenproject.org
Cc: julien@xen.org,
	sstabellini@kernel.org,
	oleksandr_tyshchenko@epam.com,
	volodymyr_babchuk@epam.com,
	Artem_Mygaiev@epam.com,
	roger.pau@citrix.com,
	jbeulich@suse.com,
	andrew.cooper3@citrix.com,
	george.dunlap@citrix.com,
	paul@xen.org,
	bertrand.marquis@arm.com,
	rahul.singh@arm.com,
	Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>,
	Ian Jackson <iwj@xenproject.org>,
	Juergen Gross <jgross@suse.com>
Subject: [PATCH v4 08/11] libxl: Only map legacy PCI IRQs if they are supported
Date: Mon,  4 Oct 2021 17:11:48 +0300
Message-Id: <20211004141151.132231-9-andr2000@gmail.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20211004141151.132231-1-andr2000@gmail.com>
References: <20211004141151.132231-1-andr2000@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>

Arm's PCI passthrough implementation doesn't support legacy interrupts,
but MSI/MSI-X. This can be the case for other platforms too.
For that reason introduce a new CONFIG_PCI_SUPP_LEGACY_IRQ and add
it to the CFLAGS and compile the relevant code in the toolstack only if
applicable.

Cc: Ian Jackson <iwj@xenproject.org>
Cc: Juergen Gross <jgross@suse.com>
Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
---
Since v1:
 - Minimized #idefery by introducing pci_supp_legacy_irq function
   for relevant checks
---
 tools/libs/light/Makefile    |  4 ++++
 tools/libs/light/libxl_pci.c | 13 +++++++++++++
 2 files changed, 17 insertions(+)

diff --git a/tools/libs/light/Makefile b/tools/libs/light/Makefile
index 7d8c51d49242..bd3f6be2a183 100644
--- a/tools/libs/light/Makefile
+++ b/tools/libs/light/Makefile
@@ -46,6 +46,10 @@ CFLAGS += -Wno-format-zero-length -Wmissing-declarations \
 	-Wno-declaration-after-statement -Wformat-nonliteral
 CFLAGS += -I.
 
+ifeq ($(CONFIG_X86),y)
+CFLAGS += -DCONFIG_PCI_SUPP_LEGACY_IRQ
+endif
+
 SRCS-$(CONFIG_X86) += libxl_cpuid.c
 SRCS-$(CONFIG_X86) += libxl_x86.c
 SRCS-$(CONFIG_X86) += libxl_psr.c
diff --git a/tools/libs/light/libxl_pci.c b/tools/libs/light/libxl_pci.c
index 59f3686fc85e..4c2d7aeefbb2 100644
--- a/tools/libs/light/libxl_pci.c
+++ b/tools/libs/light/libxl_pci.c
@@ -1364,6 +1364,15 @@ static void pci_add_timeout(libxl__egc *egc, libxl__ev_time *ev,
     pci_add_dm_done(egc, pas, rc);
 }
 
+static bool pci_supp_legacy_irq(void)
+{
+#ifdef CONFIG_PCI_SUPP_LEGACY_IRQ
+    return true;
+#else
+    return false;
+#endif
+}
+
 static void pci_add_dm_done(libxl__egc *egc,
                             pci_add_state *pas,
                             int rc)
@@ -1434,6 +1443,8 @@ static void pci_add_dm_done(libxl__egc *egc,
         }
     }
     fclose(f);
+    if (!pci_supp_legacy_irq())
+        goto out_no_irq;
     sysfs_path = GCSPRINTF(SYSFS_PCI_DEV"/"PCI_BDF"/irq", pci->domain,
                                 pci->bus, pci->dev, pci->func);
     f = fopen(sysfs_path, "r");
@@ -1983,6 +1994,8 @@ static void do_pci_remove(libxl__egc *egc, pci_remove_state *prs)
         }
         fclose(f);
 skip1:
+        if (!pci_supp_legacy_irq())
+            goto skip_irq;
         sysfs_path = GCSPRINTF(SYSFS_PCI_DEV"/"PCI_BDF"/irq", pci->domain,
                                pci->bus, pci->dev, pci->func);
         f = fopen(sysfs_path, "r");
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Mon Oct 04 14:17:16 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Oct 2021 14:17:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.201509.356059 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXOmG-0005ZI-Rw; Mon, 04 Oct 2021 14:17:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 201509.356059; Mon, 04 Oct 2021 14:17:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXOmG-0005ZB-P2; Mon, 04 Oct 2021 14:17:12 +0000
Received: by outflank-mailman (input) for mailman id 201509;
 Mon, 04 Oct 2021 14:17:11 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=U/Qt=OY=gmail.com=andr2000@srs-us1.protection.inumbo.net>)
 id 1mXOiP-0008QG-F1
 for xen-devel@lists.xenproject.org; Mon, 04 Oct 2021 14:13:13 +0000
Received: from mail-lf1-x12f.google.com (unknown [2a00:1450:4864:20::12f])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id e6cbbff4-ca33-483a-85a9-6b924cb03d70;
 Mon, 04 Oct 2021 14:12:17 +0000 (UTC)
Received: by mail-lf1-x12f.google.com with SMTP id m3so71516962lfu.2
 for <xen-devel@lists.xenproject.org>; Mon, 04 Oct 2021 07:12:17 -0700 (PDT)
Received: from localhost.localdomain (host-176-36-245-220.b024.la.net.ua.
 [176.36.245.220])
 by smtp.gmail.com with ESMTPSA id n12sm1076809lfe.145.2021.10.04.07.12.07
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Mon, 04 Oct 2021 07:12:08 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e6cbbff4-ca33-483a-85a9-6b924cb03d70
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=Mt9OWBAhbT//DIBCaDBPG1KX4to8WfBEU/gi6Ti13xs=;
        b=Zo/VaiBmlmMtZhzxzoT0AEknQqXI/pGqOzRD37w9kRaNWip0ilJ9I+DTC3inQe6gVQ
         ydV9F4HqQ30/x1fOg98A3JjKM2O7FrIkUAeD0wv5cZMB/ImlkT+BAuVcfbhCWxl2DFAY
         HxBGYFA2Qn7ny2406U5W8QCXYG/Shb4sBOY1NB/7pEYErmiOf8F63oJ2QdUJTGGcaDam
         tEEIvpAZrj3RSEnuuqJuiyECYW0wKCvtxOcFj8dt7vMkPGPWp4uI91oB3PDW0TwvkD8x
         fMcLaTDHUaFOT+zEjPEa4d9OZZ7HmD/VlTn4vRmYfwOqH2iA52GAsuRGi1iu/m182ufW
         EASA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=Mt9OWBAhbT//DIBCaDBPG1KX4to8WfBEU/gi6Ti13xs=;
        b=PyLJwHno8xFfiRGzx+Z/ZDFc6oRzLDEdHMPuyl8ftnCMpLrELoQvuWIA0A+NWwb8gV
         1Y0etFCsTV1iGCcJpQ3UqveTpiCCNHtjoY3vM3Vri+GeAXdSinkwf/et/cM7v0hqLsym
         4QiDpBdPSt/M1nVMm6IBWZfJkCSTvDb5/+BDgu9jOGzXi/TzR0rvsNzweSCSsHbOIemB
         dpL/cIQZWV5AZEv8ORZxqqY3N2q+G+fadR3UYeOqZJnZqXExW0U6GBogVxknIEDF6RGB
         h5oLPhNSk3LzjdNM1W0L9OizOJgAPdlzeLN8RuNKeDE4h3qk/oNfRpcwDDvLMiL9R52h
         xOag==
X-Gm-Message-State: AOAM53095FaXYS/wQR5EUVDu5dSqB6jAbajQGQx36EaPNg5y50ZdAeVy
	F0lzb3SPjm92sSs56rQO6Si/IXOIBBrlOA==
X-Google-Smtp-Source: ABdhPJzVgJE4NpanPPuA1m9xh0vQ+K01UWveq9p7UsP19uF85d6cp+WkxfT9exshD+EyIpsPzcM74A==
X-Received: by 2002:ac2:5c51:: with SMTP id s17mr7230247lfp.32.1633356728996;
        Mon, 04 Oct 2021 07:12:08 -0700 (PDT)
From: Oleksandr Andrushchenko <andr2000@gmail.com>
To: xen-devel@lists.xenproject.org
Cc: julien@xen.org,
	sstabellini@kernel.org,
	oleksandr_tyshchenko@epam.com,
	volodymyr_babchuk@epam.com,
	Artem_Mygaiev@epam.com,
	roger.pau@citrix.com,
	jbeulich@suse.com,
	andrew.cooper3@citrix.com,
	george.dunlap@citrix.com,
	paul@xen.org,
	bertrand.marquis@arm.com,
	rahul.singh@arm.com,
	Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Subject: [PATCH v4 11/11] xen/arm: Process pending vPCI map/unmap operations
Date: Mon,  4 Oct 2021 17:11:51 +0300
Message-Id: <20211004141151.132231-12-andr2000@gmail.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20211004141151.132231-1-andr2000@gmail.com>
References: <20211004141151.132231-1-andr2000@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>

vPCI may map and unmap PCI device memory (BARs) being passed through which
may take a lot of time. For this those operations may be deferred to be
performed later, so that they can be safely preempted.

Currently this deferred processing is happening in common IOREQ code
which doesn't seem to be the right place for x86 and is even more
doubtful because IOREQ may not be enabled for Arm at all.
So, for Arm the pending vPCI work may have no chance to be executed
if the processing is left as is in the common IOREQ code only.
For that reason make vPCI processing happen in arch specific code.

Please be aware that there are a few outstanding TODOs affecting this
code path, see xen/drivers/vpci/header.c:map_range and
xen/drivers/vpci/header.c:vpci_process_pending.

Cc: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Paul Durrant <paul@xen.org>
Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
[x86 changes]
Acked-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
---
Since v2:
 - update commit message with more insight on x86, IOREQ and Arm
 - restored order of invocation for IOREQ and vPCI processing (Jan)
Since v1:
 - Moved the check for pending vpci work from the common IOREQ code
   to hvm_do_resume on x86
 - Re-worked the code for Arm to ensure we don't miss pending vPCI work
---
 xen/arch/arm/traps.c   | 13 +++++++++++++
 xen/arch/x86/hvm/hvm.c |  6 ++++++
 xen/common/ioreq.c     |  9 ---------
 3 files changed, 19 insertions(+), 9 deletions(-)

diff --git a/xen/arch/arm/traps.c b/xen/arch/arm/traps.c
index 219ab3c3fbde..b246f51086e3 100644
--- a/xen/arch/arm/traps.c
+++ b/xen/arch/arm/traps.c
@@ -34,6 +34,7 @@
 #include <xen/symbols.h>
 #include <xen/version.h>
 #include <xen/virtual_region.h>
+#include <xen/vpci.h>
 
 #include <public/sched.h>
 #include <public/xen.h>
@@ -2304,6 +2305,18 @@ static bool check_for_vcpu_work(void)
     }
 #endif
 
+    if ( has_vpci(v->domain) )
+    {
+        bool pending;
+
+        local_irq_enable();
+        pending = vpci_process_pending(v);
+        local_irq_disable();
+
+        if ( pending )
+            return true;
+    }
+
     if ( likely(!v->arch.need_flush_to_ram) )
         return false;
 
diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c
index aa418a3ca1b7..c491242e4b8b 100644
--- a/xen/arch/x86/hvm/hvm.c
+++ b/xen/arch/x86/hvm/hvm.c
@@ -546,6 +546,12 @@ void hvm_do_resume(struct vcpu *v)
 
     pt_restore_timer(v);
 
+    if ( has_vpci(v->domain) && vpci_process_pending(v) )
+    {
+        raise_softirq(SCHEDULE_SOFTIRQ);
+        return;
+    }
+
     if ( !vcpu_ioreq_handle_completion(v) )
         return;
 
diff --git a/xen/common/ioreq.c b/xen/common/ioreq.c
index d732dc045df9..689d256544c8 100644
--- a/xen/common/ioreq.c
+++ b/xen/common/ioreq.c
@@ -25,9 +25,7 @@
 #include <xen/lib.h>
 #include <xen/paging.h>
 #include <xen/sched.h>
-#include <xen/softirq.h>
 #include <xen/trace.h>
-#include <xen/vpci.h>
 
 #include <asm/guest_atomics.h>
 #include <asm/ioreq.h>
@@ -212,19 +210,12 @@ static bool wait_for_io(struct ioreq_vcpu *sv, ioreq_t *p)
 
 bool vcpu_ioreq_handle_completion(struct vcpu *v)
 {
-    struct domain *d = v->domain;
     struct vcpu_io *vio = &v->io;
     struct ioreq_server *s;
     struct ioreq_vcpu *sv;
     enum vio_completion completion;
     bool res = true;
 
-    if ( has_vpci(d) && vpci_process_pending(v) )
-    {
-        raise_softirq(SCHEDULE_SOFTIRQ);
-        return false;
-    }
-
     while ( (sv = get_pending_vcpu(v, &s)) != NULL )
         if ( !wait_for_io(sv, get_ioreq(s, v)) )
             return false;
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Mon Oct 04 14:17:23 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Oct 2021 14:17:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.201511.356070 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXOmR-0005uX-6H; Mon, 04 Oct 2021 14:17:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 201511.356070; Mon, 04 Oct 2021 14:17:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXOmR-0005uO-1O; Mon, 04 Oct 2021 14:17:23 +0000
Received: by outflank-mailman (input) for mailman id 201511;
 Mon, 04 Oct 2021 14:17:21 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=U/Qt=OY=gmail.com=andr2000@srs-us1.protection.inumbo.net>)
 id 1mXOiA-0008QG-En
 for xen-devel@lists.xenproject.org; Mon, 04 Oct 2021 14:12:58 +0000
Received: from mail-lf1-x132.google.com (unknown [2a00:1450:4864:20::132])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 4bf38a16-77d4-4f1a-ab9a-067fdb94d0a6;
 Mon, 04 Oct 2021 14:12:11 +0000 (UTC)
Received: by mail-lf1-x132.google.com with SMTP id x27so72247055lfu.5
 for <xen-devel@lists.xenproject.org>; Mon, 04 Oct 2021 07:12:10 -0700 (PDT)
Received: from localhost.localdomain (host-176-36-245-220.b024.la.net.ua.
 [176.36.245.220])
 by smtp.gmail.com with ESMTPSA id n12sm1076809lfe.145.2021.10.04.07.12.06
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Mon, 04 Oct 2021 07:12:07 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4bf38a16-77d4-4f1a-ab9a-067fdb94d0a6
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=zoz1k75+2CYj6hEa3rYdIM6cYztNjgw6hV+gMEf3DZ0=;
        b=BDtgP8HFUjTqP7ZCzOT6MCtyPD//wmbU4pPY/JP0l0aURIKImh8Jx6oxinnj7KcCm2
         U1ZvAuOs6MWxz/Lw7idNx5QkHRdahJcUVQl6/y1tzx7TgyFIzENYl0TG1EjNl2LYSOiB
         RF0bn1A7j60tDQ5B/Oa+muir6Rmc+rtqA0Zn8R4Z8ILqiZ5vl5kglDGzajKu8R0Q3P8V
         d1AV3PZIF5KivLcMyG4TwCZN3egJ4b3YSsUwvrZevhlS7yH1vTRZMNCS43fhcpkw52dr
         cWN9UQzZG9b2pkN6/qaFLqDDHVrsKPnbx9ADuBP2BU2kPCUAAUrLCYEiFoJOYEV3mE/H
         WJEA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=zoz1k75+2CYj6hEa3rYdIM6cYztNjgw6hV+gMEf3DZ0=;
        b=tZ+l6inPXJTHXK6pe1SWYxV0WHfIuIUhrCTqPL0/8cS7sr1zJhVFKv4ln9Va3wV2XT
         Dhq1GmVMIvnGbQqrBIMztcbWm8oT2KvNTL9ApdEjhHHTPMVfFo0Zyx7eAjapsv52p72t
         SMEyJTDmvzOkx7anSG8kFPNgwM7p4agmKU+wTW38X9T5ewE4oFXOWoeWUsC+2P1dfmeL
         7MExs7KtMrrKSZ/Xja9GSz4AKqBtimQvc065CoyAgomzNURZSl9JiKg+5m572zFWTPUU
         RteO7/ng2gLXEqhle8LorQk59HQqHwAID/NeSVchIklFwSzU8JQ8CJRsWUxI9l6x9IkP
         sP/g==
X-Gm-Message-State: AOAM533sbsJJD/9tnEbcMHvlVKgwypnVRRlmaRnEnmJsBKzySccHA3Ii
	FIiwCHunDZX5FWZHr5Jyi6gPephQTbtclA==
X-Google-Smtp-Source: ABdhPJyOEdsyl3+0ouniYrimebBFO5KD+mDsA2TST5Lp3VkTQZjVgrKjs5/mxecpwSrSR76K0Fbdbw==
X-Received: by 2002:a05:6512:118a:: with SMTP id g10mr14437388lfr.580.1633356727740;
        Mon, 04 Oct 2021 07:12:07 -0700 (PDT)
From: Oleksandr Andrushchenko <andr2000@gmail.com>
To: xen-devel@lists.xenproject.org
Cc: julien@xen.org,
	sstabellini@kernel.org,
	oleksandr_tyshchenko@epam.com,
	volodymyr_babchuk@epam.com,
	Artem_Mygaiev@epam.com,
	roger.pau@citrix.com,
	jbeulich@suse.com,
	andrew.cooper3@citrix.com,
	george.dunlap@citrix.com,
	paul@xen.org,
	bertrand.marquis@arm.com,
	rahul.singh@arm.com,
	Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Subject: [PATCH v4 10/11] xen/arm: Do not map PCI ECAM and MMIO space to Domain-0's p2m
Date: Mon,  4 Oct 2021 17:11:50 +0300
Message-Id: <20211004141151.132231-11-andr2000@gmail.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20211004141151.132231-1-andr2000@gmail.com>
References: <20211004141151.132231-1-andr2000@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>

PCI host bridges are special devices in terms of implementing PCI
passthrough. According to [1] the current implementation depends on
Domain-0 to perform the initialization of the relevant PCI host
bridge hardware and perform PCI device enumeration. In order to
achieve that one of the required changes is to not map all the memory
ranges in map_range_to_domain as we traverse the device tree on startup
and perform some additional checks if the range needs to be mapped to
Domain-0.

The generic PCI host controller device tree binding says [2]:
- ranges: As described in IEEE Std 1275-1994, but must provide
          at least a definition of non-prefetchable memory. One
          or both of prefetchable Memory and IO Space may also
          be provided.

- reg   : The Configuration Space base address and size, as accessed
          from the parent bus.  The base address corresponds to
          the first bus in the "bus-range" property.  If no
          "bus-range" is specified, this will be bus 0 (the default).

>From the above none of the memory ranges from the "ranges" property
needs to be mapped to Domain-0 at startup as MMIO mapping is going to
be handled dynamically by vPCI as we assign PCI devices, e.g. each
device assigned to Domain-0/guest will have its MMIOs mapped/unmapped
as needed by Xen.

The "reg" property covers not only ECAM space, but may also have other
then the configuration memory ranges described, for example [3]:
- reg: Should contain rc_dbi, config registers location and length.
- reg-names: Must include the following entries:
   "rc_dbi": controller configuration registers;
   "config": PCIe configuration space registers.

This patch makes it possible to not map all the ranges from the
"ranges" property and also ECAM from the "reg". All the rest from the
"reg" property still needs to be mapped to Domain-0, so the PCI
host bridge remains functional in Domain-0.

[1] https://lists.xenproject.org/archives/html/xen-devel/2020-07/msg00777.html
[2] https://www.kernel.org/doc/Documentation/devicetree/bindings/pci/host-generic-pci.txt
[3] https://www.kernel.org/doc/Documentation/devicetree/bindings/pci/hisilicon-pcie.txt

Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
---
Since v3:
 - pass struct map_range_data to map_dt_irq_to_domain
 - remove redundant check from map_range_to_domain
 - fix handle_device's .skip_mapping
Since v2:
 - removed check in map_range_to_domain for PCI_DEV
   and moved it to handle_device, so the code is
   simpler
 - s/map_pci_bridge/skip_mapping
 - extended comment in pci_host_bridge_mappings
 - minor code restructure in construct_dom0
 - s/.need_p2m_mapping/.need_p2m_hwdom_mapping and related
   callbacks
 - unsigned int i; in pci_host_bridge_mappings
Since v1:
 - Added better description of why and what needs to be mapped into
   Domain-0's p2m and what doesn't
 - Do not do any mappings for PCI devices while traversing the DT
 - Walk all the bridges and make required mappings in one go
---
 xen/arch/arm/domain_build.c        | 50 ++++++++++++++++--------------
 xen/arch/arm/pci/ecam.c            | 14 +++++++++
 xen/arch/arm/pci/pci-host-common.c | 49 +++++++++++++++++++++++++++++
 xen/arch/arm/pci/pci-host-zynqmp.c |  1 +
 xen/include/asm-arm/pci.h          | 10 ++++++
 xen/include/asm-arm/setup.h        | 13 ++++++++
 6 files changed, 114 insertions(+), 23 deletions(-)

diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
index 8739e3285ef4..2a3c641476bd 100644
--- a/xen/arch/arm/domain_build.c
+++ b/xen/arch/arm/domain_build.c
@@ -10,7 +10,6 @@
 #include <asm/regs.h>
 #include <xen/errno.h>
 #include <xen/err.h>
-#include <xen/device_tree.h>
 #include <xen/libfdt/libfdt.h>
 #include <xen/guest_access.h>
 #include <xen/iocap.h>
@@ -51,12 +50,6 @@ static int __init parse_dom0_mem(const char *s)
 }
 custom_param("dom0_mem", parse_dom0_mem);
 
-struct map_range_data
-{
-    struct domain *d;
-    p2m_type_t p2mt;
-};
-
 /* Override macros from asm/page.h to make them work with mfn_t */
 #undef virt_to_mfn
 #define virt_to_mfn(va) _mfn(__virt_to_mfn(va))
@@ -1641,10 +1634,11 @@ static int __init map_dt_irq_to_domain(const struct dt_device_node *dev,
                                        const struct dt_irq *dt_irq,
                                        void *data)
 {
-    struct domain *d = data;
+    struct map_range_data *mr_data = data;
+    struct domain *d = mr_data->d;
     unsigned int irq = dt_irq->irq;
     int res;
-    bool need_mapping = !dt_device_for_passthrough(dev);
+    bool need_mapping = !mr_data->skip_mapping;
 
     if ( irq < NR_LOCAL_IRQS )
     {
@@ -1668,13 +1662,12 @@ static int __init map_dt_irq_to_domain(const struct dt_device_node *dev,
     return 0;
 }
 
-static int __init map_range_to_domain(const struct dt_device_node *dev,
-                                      u64 addr, u64 len,
-                                      void *data)
+int __init map_range_to_domain(const struct dt_device_node *dev,
+                               u64 addr, u64 len, void *data)
 {
     struct map_range_data *mr_data = data;
     struct domain *d = mr_data->d;
-    bool need_mapping = !dt_device_for_passthrough(dev);
+    bool need_mapping = !mr_data->skip_mapping;
     int res;
 
     /*
@@ -1726,23 +1719,21 @@ static int __init map_range_to_domain(const struct dt_device_node *dev,
  * then we may need to perform additional mappings in order to make
  * the child resources available to domain 0.
  */
-static int __init map_device_children(struct domain *d,
-                                      const struct dt_device_node *dev,
-                                      p2m_type_t p2mt)
+static int __init map_device_children(const struct dt_device_node *dev,
+                                      struct map_range_data *mr_data)
 {
-    struct map_range_data mr_data = { .d = d, .p2mt = p2mt };
-    int ret;
-
     if ( dt_device_type_is_equal(dev, "pci") )
     {
+        int ret;
+
         dt_dprintk("Mapping children of %s to guest\n",
                    dt_node_full_name(dev));
 
-        ret = dt_for_each_irq_map(dev, &map_dt_irq_to_domain, d);
+        ret = dt_for_each_irq_map(dev, &map_dt_irq_to_domain, mr_data);
         if ( ret < 0 )
             return ret;
 
-        ret = dt_for_each_range(dev, &map_range_to_domain, &mr_data);
+        ret = dt_for_each_range(dev, &map_range_to_domain, mr_data);
         if ( ret < 0 )
             return ret;
     }
@@ -1823,6 +1814,13 @@ static int __init handle_device(struct domain *d, struct dt_device_node *dev,
     int res;
     u64 addr, size;
     bool need_mapping = !dt_device_for_passthrough(dev);
+    struct map_range_data mr_data = {
+        .d = d,
+        .p2mt = p2mt,
+        .skip_mapping = !need_mapping ||
+                        (is_pci_passthrough_enabled() &&
+                         (device_get_class(dev) == DEVICE_PCI))
+    };
 
     naddr = dt_number_of_address(dev);
 
@@ -1862,7 +1860,6 @@ static int __init handle_device(struct domain *d, struct dt_device_node *dev,
     /* Give permission and map MMIOs */
     for ( i = 0; i < naddr; i++ )
     {
-        struct map_range_data mr_data = { .d = d, .p2mt = p2mt };
         res = dt_device_get_address(dev, i, &addr, &size);
         if ( res )
         {
@@ -1876,7 +1873,7 @@ static int __init handle_device(struct domain *d, struct dt_device_node *dev,
             return res;
     }
 
-    res = map_device_children(d, dev, p2mt);
+    res = map_device_children(dev, &mr_data);
     if ( res )
         return res;
 
@@ -3034,7 +3031,14 @@ static int __init construct_dom0(struct domain *d)
         return rc;
 
     if ( acpi_disabled )
+    {
         rc = prepare_dtb_hwdom(d, &kinfo);
+        if ( rc < 0 )
+            return rc;
+#ifdef CONFIG_HAS_PCI
+        rc = pci_host_bridge_mappings(d, p2m_mmio_direct_c);
+#endif
+    }
     else
         rc = prepare_acpi(d, &kinfo);
 
diff --git a/xen/arch/arm/pci/ecam.c b/xen/arch/arm/pci/ecam.c
index 602d00799c8d..b81620074a91 100644
--- a/xen/arch/arm/pci/ecam.c
+++ b/xen/arch/arm/pci/ecam.c
@@ -40,6 +40,19 @@ void __iomem *pci_ecam_map_bus(struct pci_host_bridge *bridge,
     return base + (PCI_DEVFN2(sbdf.bdf) << devfn_shift) + where;
 }
 
+bool pci_ecam_need_p2m_hwdom_mapping(struct domain *d,
+                                     struct pci_host_bridge *bridge,
+                                     uint64_t addr)
+{
+    struct pci_config_window *cfg = bridge->cfg;
+
+    /*
+     * We do not want ECAM address space to be mapped in Domain-0's p2m,
+     * so we can trap access to it.
+     */
+    return cfg->phys_addr != addr;
+}
+
 /* ECAM ops */
 const struct pci_ecam_ops pci_generic_ecam_ops = {
     .bus_shift  = 20,
@@ -47,6 +60,7 @@ const struct pci_ecam_ops pci_generic_ecam_ops = {
         .map_bus                = pci_ecam_map_bus,
         .read                   = pci_generic_config_read,
         .write                  = pci_generic_config_write,
+        .need_p2m_hwdom_mapping = pci_ecam_need_p2m_hwdom_mapping,
     }
 };
 
diff --git a/xen/arch/arm/pci/pci-host-common.c b/xen/arch/arm/pci/pci-host-common.c
index 1eb4daa87365..085f08e23e0c 100644
--- a/xen/arch/arm/pci/pci-host-common.c
+++ b/xen/arch/arm/pci/pci-host-common.c
@@ -18,6 +18,7 @@
 
 #include <xen/init.h>
 #include <xen/pci.h>
+#include <asm/setup.h>
 #include <xen/rwlock.h>
 #include <xen/sched.h>
 #include <xen/vmap.h>
@@ -320,6 +321,54 @@ int pci_host_get_num_bridges(void)
     return count;
 }
 
+int __init pci_host_bridge_mappings(struct domain *d, p2m_type_t p2mt)
+{
+    struct pci_host_bridge *bridge;
+    struct map_range_data mr_data = {
+        .d = d,
+        .p2mt = p2mt,
+        .skip_mapping = false
+    };
+
+    /*
+     * For each PCI host bridge we need to only map those ranges
+     * which are used by Domain-0 to properly initialize the bridge,
+     * e.g. we do not want to map ECAM configuration space which lives in
+     * "reg" or "assigned-addresses" device tree property, but we want to
+     * map other regions of the host bridge. The PCI aperture defined by
+     * the "ranges" device tree property should also be skipped.
+     */
+    list_for_each_entry( bridge, &pci_host_bridges, node )
+    {
+        const struct dt_device_node *dev = bridge->dt_node;
+        unsigned int i;
+
+        for ( i = 0; i < dt_number_of_address(dev); i++ )
+        {
+            uint64_t addr, size;
+            int err;
+
+            err = dt_device_get_address(dev, i, &addr, &size);
+            if ( err )
+            {
+                printk(XENLOG_ERR
+                       "Unable to retrieve address range index=%u for %s\n",
+                       i, dt_node_full_name(dev));
+                return err;
+            }
+
+            if ( bridge->ops->need_p2m_hwdom_mapping(d, bridge, addr) )
+            {
+                err = map_range_to_domain(dev, addr, size, &mr_data);
+                if ( err )
+                    return err;
+            }
+        }
+    }
+
+    return 0;
+}
+
 /*
  * Local variables:
  * mode: C
diff --git a/xen/arch/arm/pci/pci-host-zynqmp.c b/xen/arch/arm/pci/pci-host-zynqmp.c
index 61a9807d3d58..6ad2b31e810d 100644
--- a/xen/arch/arm/pci/pci-host-zynqmp.c
+++ b/xen/arch/arm/pci/pci-host-zynqmp.c
@@ -34,6 +34,7 @@ const struct pci_ecam_ops nwl_pcie_ops = {
         .map_bus                = pci_ecam_map_bus,
         .read                   = pci_generic_config_read,
         .write                  = pci_generic_config_write,
+        .need_p2m_hwdom_mapping = pci_ecam_need_p2m_hwdom_mapping,
     }
 };
 
diff --git a/xen/include/asm-arm/pci.h b/xen/include/asm-arm/pci.h
index a62d8bc60086..d9a3c2a4f3b3 100644
--- a/xen/include/asm-arm/pci.h
+++ b/xen/include/asm-arm/pci.h
@@ -17,6 +17,8 @@
 
 #ifdef CONFIG_HAS_PCI
 
+#include <asm/p2m.h>
+
 #define pci_to_dev(pcidev) (&(pcidev)->arch.dev)
 
 extern bool_t pci_passthrough_enabled;
@@ -73,6 +75,9 @@ struct pci_ops {
                 uint32_t reg, uint32_t len, uint32_t *value);
     int (*write)(struct pci_host_bridge *bridge, pci_sbdf_t sbdf,
                  uint32_t reg, uint32_t len, uint32_t value);
+    bool (*need_p2m_hwdom_mapping)(struct domain *d,
+                                   struct pci_host_bridge *bridge,
+                                   uint64_t addr);
 };
 
 /*
@@ -96,6 +101,9 @@ int pci_generic_config_write(struct pci_host_bridge *bridge, pci_sbdf_t sbdf,
                              uint32_t reg, uint32_t len, uint32_t value);
 void __iomem *pci_ecam_map_bus(struct pci_host_bridge *bridge,
                                pci_sbdf_t sbdf, uint32_t where);
+bool pci_ecam_need_p2m_hwdom_mapping(struct domain *d,
+                                     struct pci_host_bridge *bridge,
+                                     uint64_t addr);
 struct pci_host_bridge *pci_find_host_bridge(uint16_t segment, uint8_t bus);
 int pci_get_host_bridge_segment(const struct dt_device_node *node,
                                 uint16_t *segment);
@@ -113,6 +121,8 @@ int pci_host_iterate_bridges(struct domain *d,
                                         struct pci_host_bridge *bridge));
 int pci_host_get_num_bridges(void);
 
+int pci_host_bridge_mappings(struct domain *d, p2m_type_t p2mt);
+
 #else   /*!CONFIG_HAS_PCI*/
 
 struct arch_pci_dev { };
diff --git a/xen/include/asm-arm/setup.h b/xen/include/asm-arm/setup.h
index 95da0b7ab9cd..5b30135fda38 100644
--- a/xen/include/asm-arm/setup.h
+++ b/xen/include/asm-arm/setup.h
@@ -2,6 +2,8 @@
 #define __ARM_SETUP_H_
 
 #include <public/version.h>
+#include <asm/p2m.h>
+#include <xen/device_tree.h>
 
 #define MIN_FDT_ALIGN 8
 #define MAX_FDT_SIZE SZ_2M
@@ -77,6 +79,14 @@ struct bootinfo {
 #endif
 };
 
+struct map_range_data
+{
+    struct domain *d;
+    p2m_type_t p2mt;
+    /* Set if mappings for PCI host bridges must not be skipped. */
+    bool skip_mapping;
+};
+
 extern struct bootinfo bootinfo;
 
 extern domid_t max_init_domid;
@@ -124,6 +134,9 @@ void device_tree_get_reg(const __be32 **cell, u32 address_cells,
 u32 device_tree_get_u32(const void *fdt, int node,
                         const char *prop_name, u32 dflt);
 
+int map_range_to_domain(const struct dt_device_node *dev,
+                        u64 addr, u64 len, void *data);
+
 #endif
 /*
  * Local variables:
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Mon Oct 04 14:17:37 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Oct 2021 14:17:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.201519.356081 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXOmf-0006Ta-Dv; Mon, 04 Oct 2021 14:17:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 201519.356081; Mon, 04 Oct 2021 14:17:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXOmf-0006TN-Ay; Mon, 04 Oct 2021 14:17:37 +0000
Received: by outflank-mailman (input) for mailman id 201519;
 Mon, 04 Oct 2021 14:17:36 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=U/Qt=OY=gmail.com=andr2000@srs-us1.protection.inumbo.net>)
 id 1mXOi0-0008QG-Ea
 for xen-devel@lists.xenproject.org; Mon, 04 Oct 2021 14:12:48 +0000
Received: from mail-lf1-x12a.google.com (unknown [2a00:1450:4864:20::12a])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 9ba3d850-b21d-4a3c-8497-b91f56f96571;
 Mon, 04 Oct 2021 14:12:09 +0000 (UTC)
Received: by mail-lf1-x12a.google.com with SMTP id y15so6465418lfk.7
 for <xen-devel@lists.xenproject.org>; Mon, 04 Oct 2021 07:12:09 -0700 (PDT)
Received: from localhost.localdomain (host-176-36-245-220.b024.la.net.ua.
 [176.36.245.220])
 by smtp.gmail.com with ESMTPSA id n12sm1076809lfe.145.2021.10.04.07.12.05
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Mon, 04 Oct 2021 07:12:06 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9ba3d850-b21d-4a3c-8497-b91f56f96571
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=yH0ib0fYHnpnXYuN0yIUp+P4aLOSl8TIjVaiKqqDoME=;
        b=FTHD1NrKz0elS/22hvRlyOVDFIaBeZCOjaYcvaH/NI4fV0l5+mCWELmxleSwhfqgA2
         IxkBWtN5/1FBPLoqIGvY/7fUhsV57sWlA23IANz+DNsYGoTwbGuQSVK/PH6YWoTs3U4a
         nIA5oSI7sPmuAH7xgyMVjnx+k+kbZZWWfXzGzz1pZXAbFJ9aHEZ7rAcjwv6rkk6nITr3
         KF5VKOnWFC0a4dYcXo0Bacz8X8NC8Wp1JjhUMy5WfwTCVhCHi0fZBDCk4RXg7lfoqK0Y
         h4HB1VKDZ+y/L4yb+fAqFnmEs9LuR+VfuUR60QXcR95hzIYd4zKENoUw4cq13IBDpEJB
         jxZQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=yH0ib0fYHnpnXYuN0yIUp+P4aLOSl8TIjVaiKqqDoME=;
        b=NeMGuai8SsEBHvE62YEb3+es/Twwzrut10j47YZoq3GA/BVjkUwjOW77rXQCURYn9b
         6L5gT55wF8xv20FXZoOINjC6lxAXnPOo/ZWfTgD30yGBlBXy4QZK1Y1D1DOWwPW1PCky
         g45+JwRTVUjL2FTkhUBxLCCkmEk/lAIMBflGR/OobVgw2nBsvTDX0497Y+bbSGSyifAL
         h2aZnjLlE9xG57fs70x0MpRRhSfIXW8DkAJU5g1VtA6QkycsrFkck3Qu6Xqeb7WMvtxS
         DOaLkxgaCReGIg2ktN2ZfyiXfSQAQzfpSU0WwC1G5hxYpfQpa1HR9MJmQ4l2cn/XyvTG
         WqjQ==
X-Gm-Message-State: AOAM533HidWK0EAvTYf6MzegQgEjXHueJHKMMhw0C+RhDlRcG9bHTNRr
	RQ4sCGpwzGWVQS3onu79nXbkYdnMQmmFmQ==
X-Google-Smtp-Source: ABdhPJxVEGVDIYMCWDv/jI0j9PHqrZZVAaBwU09bl5gdNZ5UX5C9BDoC8SDNudI2U3hzaJ41m+FXaw==
X-Received: by 2002:a05:6512:acd:: with SMTP id n13mr14617608lfu.247.1633356726402;
        Mon, 04 Oct 2021 07:12:06 -0700 (PDT)
From: Oleksandr Andrushchenko <andr2000@gmail.com>
To: xen-devel@lists.xenproject.org
Cc: julien@xen.org,
	sstabellini@kernel.org,
	oleksandr_tyshchenko@epam.com,
	volodymyr_babchuk@epam.com,
	Artem_Mygaiev@epam.com,
	roger.pau@citrix.com,
	jbeulich@suse.com,
	andrew.cooper3@citrix.com,
	george.dunlap@citrix.com,
	paul@xen.org,
	bertrand.marquis@arm.com,
	rahul.singh@arm.com,
	Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Subject: [PATCH v4 09/11] xen/arm: Setup MMIO range trap handlers for hardware domain
Date: Mon,  4 Oct 2021 17:11:49 +0300
Message-Id: <20211004141151.132231-10-andr2000@gmail.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20211004141151.132231-1-andr2000@gmail.com>
References: <20211004141151.132231-1-andr2000@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>

In order for vPCI to work it needs to maintain guest and hardware
domain's views of the configuration space. For example, BARs and
COMMAND registers require emulation for guests and the guest view
of the registers needs to be in sync with the real contents of the
relevant registers. For that ECAM address space needs to also be
trapped for the hardware domain, so we need to implement PCI host
bridge specific callbacks to properly setup MMIO handlers for those
ranges depending on particular host bridge implementation.

Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
---
Since v3:
- fixed comment formatting
Since v2:
- removed unneeded assignment (count = 0)
- removed unneeded header inclusion
- update commit message
Since v1:
 - Dynamically calculate the number of MMIO handlers required for vPCI
   and update the total number accordingly
 - s/clb/cb
 - Do not introduce a new callback for MMIO handler setup
---
 xen/arch/arm/domain.c              |  2 ++
 xen/arch/arm/pci/pci-host-common.c | 28 ++++++++++++++++++++++++
 xen/arch/arm/vpci.c                | 34 ++++++++++++++++++++++++++++++
 xen/arch/arm/vpci.h                |  6 ++++++
 xen/include/asm-arm/pci.h          |  5 +++++
 5 files changed, 75 insertions(+)

diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
index 79012bf77757..fa6fcc5e467c 100644
--- a/xen/arch/arm/domain.c
+++ b/xen/arch/arm/domain.c
@@ -733,6 +733,8 @@ int arch_domain_create(struct domain *d,
     if ( (rc = domain_vgic_register(d, &count)) != 0 )
         goto fail;
 
+    count += domain_vpci_get_num_mmio_handlers(d);
+
     if ( (rc = domain_io_init(d, count + MAX_IO_HANDLER)) != 0 )
         goto fail;
 
diff --git a/xen/arch/arm/pci/pci-host-common.c b/xen/arch/arm/pci/pci-host-common.c
index 592c01aae5bb..1eb4daa87365 100644
--- a/xen/arch/arm/pci/pci-host-common.c
+++ b/xen/arch/arm/pci/pci-host-common.c
@@ -292,6 +292,34 @@ struct dt_device_node *pci_find_host_bridge_node(struct device *dev)
     }
     return bridge->dt_node;
 }
+
+int pci_host_iterate_bridges(struct domain *d,
+                             int (*cb)(struct domain *d,
+                                       struct pci_host_bridge *bridge))
+{
+    struct pci_host_bridge *bridge;
+    int err;
+
+    list_for_each_entry( bridge, &pci_host_bridges, node )
+    {
+        err = cb(d, bridge);
+        if ( err )
+            return err;
+    }
+    return 0;
+}
+
+int pci_host_get_num_bridges(void)
+{
+    struct pci_host_bridge *bridge;
+    int count = 0;
+
+    list_for_each_entry( bridge, &pci_host_bridges, node )
+        count++;
+
+    return count;
+}
+
 /*
  * Local variables:
  * mode: C
diff --git a/xen/arch/arm/vpci.c b/xen/arch/arm/vpci.c
index 76c12b92814f..6e179cd3010b 100644
--- a/xen/arch/arm/vpci.c
+++ b/xen/arch/arm/vpci.c
@@ -80,17 +80,51 @@ static const struct mmio_handler_ops vpci_mmio_handler = {
     .write = vpci_mmio_write,
 };
 
+static int vpci_setup_mmio_handler(struct domain *d,
+                                   struct pci_host_bridge *bridge)
+{
+    struct pci_config_window *cfg = bridge->cfg;
+
+    register_mmio_handler(d, &vpci_mmio_handler,
+                          cfg->phys_addr, cfg->size, NULL);
+    return 0;
+}
+
 int domain_vpci_init(struct domain *d)
 {
     if ( !has_vpci(d) )
         return 0;
 
+    if ( is_hardware_domain(d) )
+        return pci_host_iterate_bridges(d, vpci_setup_mmio_handler);
+
+    /* Guest domains use what is programmed in their device tree. */
     register_mmio_handler(d, &vpci_mmio_handler,
                           GUEST_VPCI_ECAM_BASE, GUEST_VPCI_ECAM_SIZE, NULL);
 
     return 0;
 }
 
+int domain_vpci_get_num_mmio_handlers(struct domain *d)
+{
+    int count;
+
+    if ( is_hardware_domain(d) )
+        /* For each PCI host bridge's configuration space. */
+        count = pci_host_get_num_bridges();
+    else
+        /*
+         * VPCI_MSIX_MEM_NUM handlers for MSI-X tables per each PCI device
+         * being passed through. Maximum number of supported devices
+         * is 32 as virtual bus topology emulates the devices as embedded
+         * endpoints.
+         * +1 for a single emulated host bridge's configuration space.
+         */
+        count = VPCI_MSIX_MEM_NUM * 32 + 1;
+
+    return count;
+}
+
 /*
  * Local variables:
  * mode: C
diff --git a/xen/arch/arm/vpci.h b/xen/arch/arm/vpci.h
index d8a7b0e3e802..27a2b069abd2 100644
--- a/xen/arch/arm/vpci.h
+++ b/xen/arch/arm/vpci.h
@@ -17,11 +17,17 @@
 
 #ifdef CONFIG_HAS_VPCI
 int domain_vpci_init(struct domain *d);
+int domain_vpci_get_num_mmio_handlers(struct domain *d);
 #else
 static inline int domain_vpci_init(struct domain *d)
 {
     return 0;
 }
+
+static inline int domain_vpci_get_num_mmio_handlers(struct domain *d)
+{
+    return 0;
+}
 #endif
 
 #endif /* __ARCH_ARM_VPCI_H__ */
diff --git a/xen/include/asm-arm/pci.h b/xen/include/asm-arm/pci.h
index ea87ec6006fc..a62d8bc60086 100644
--- a/xen/include/asm-arm/pci.h
+++ b/xen/include/asm-arm/pci.h
@@ -108,6 +108,11 @@ static always_inline bool is_pci_passthrough_enabled(void)
 
 void arch_pci_init_pdev(struct pci_dev *pdev);
 
+int pci_host_iterate_bridges(struct domain *d,
+                             int (*clb)(struct domain *d,
+                                        struct pci_host_bridge *bridge));
+int pci_host_get_num_bridges(void);
+
 #else   /*!CONFIG_HAS_PCI*/
 
 struct arch_pci_dev { };
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Mon Oct 04 14:19:37 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Oct 2021 14:19:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.201540.356096 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXOob-0007XX-1x; Mon, 04 Oct 2021 14:19:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 201540.356096; Mon, 04 Oct 2021 14:19:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXOoa-0007XQ-Um; Mon, 04 Oct 2021 14:19:36 +0000
Received: by outflank-mailman (input) for mailman id 201540;
 Mon, 04 Oct 2021 14:19:35 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=7SE7=OY=suse.com=jgross@srs-us1.protection.inumbo.net>)
 id 1mXOoZ-0007UW-Qs
 for xen-devel@lists.xenproject.org; Mon, 04 Oct 2021 14:19:35 +0000
Received: from smtp-out2.suse.de (unknown [195.135.220.29])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id b55e299b-80d0-4722-ae83-8c39b72cd2a2;
 Mon, 04 Oct 2021 14:19:29 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 638A220206;
 Mon,  4 Oct 2021 14:19:28 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 2CD2B13342;
 Mon,  4 Oct 2021 14:19:28 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id YB2xCXANW2EjcAAAMHmgww
 (envelope-from <jgross@suse.com>); Mon, 04 Oct 2021 14:19:28 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b55e299b-80d0-4722-ae83-8c39b72cd2a2
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1633357168; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:  content-transfer-encoding:content-transfer-encoding;
	bh=0AOhPZV+JXqC2xfl8dUUkVHXeqvYXj7VLkoveiuIiaU=;
	b=KVeGLE7kpF7v7Zc1Q51PTlyg47fyQALvDke73b8ICABdPJ8HgHcoAiNzVCrjUvJP2qaUsg
	ACXY2nqc1NyrAfql+VIjUTPyBnKnWw0gWBUZSSMQRDT8zeSGeEv0Q+rk/pbuwSrZmZRV9K
	iQ4YxONqNpFwm8iurtHzjJas/ILOOHg=
From: Juergen Gross <jgross@suse.com>
To: minios-devel@lists.xenproject.org,
	xen-devel@lists.xenproject.org
Cc: samuel.thibault@ens-lyon.org,
	wl@xen.org,
	Juergen Gross <jgross@suse.com>
Subject: [PATCH 0/2] mini-os: prepare mini-os stubdoms to use stable libs only
Date: Mon,  4 Oct 2021 16:19:22 +0200
Message-Id: <20211004141924.7088-1-jgross@suse.com>
X-Mailer: git-send-email 2.26.2
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

When built as stubdom Mini-OS can't be linked to use only stable Xen
libraries, as there is only one config option for adding Xen library
support, which includes libxenctrl.

This series is changing that by adding dedicated config options for
each Xen library needing special support in Mini-OS.

Juergen Gross (2):
  mini-os: fix testbuilds regarding CONFIG_XC
  mini-os: add config options for xen libraries

 Config.mk                     | 8 +++++++-
 arch/x86/testbuild/all-no     | 4 +++-
 arch/x86/testbuild/all-yes    | 8 +++++---
 arch/x86/testbuild/newxen-yes | 8 +++++---
 lib/sys.c                     | 8 ++++++--
 5 files changed, 26 insertions(+), 10 deletions(-)

-- 
2.26.2



From xen-devel-bounces@lists.xenproject.org Mon Oct 04 14:19:47 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Oct 2021 14:19:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.201542.356111 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXOol-0007xz-Cq; Mon, 04 Oct 2021 14:19:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 201542.356111; Mon, 04 Oct 2021 14:19:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXOol-0007xq-9Z; Mon, 04 Oct 2021 14:19:47 +0000
Received: by outflank-mailman (input) for mailman id 201542;
 Mon, 04 Oct 2021 14:19:45 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=7SE7=OY=suse.com=jgross@srs-us1.protection.inumbo.net>)
 id 1mXOoj-0007UW-R5
 for xen-devel@lists.xenproject.org; Mon, 04 Oct 2021 14:19:45 +0000
Received: from smtp-out2.suse.de (unknown [195.135.220.29])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id eb28ed18-8dd0-44f3-b308-9b2cd0eaf583;
 Mon, 04 Oct 2021 14:19:29 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 90F1820208;
 Mon,  4 Oct 2021 14:19:28 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 679A913AEF;
 Mon,  4 Oct 2021 14:19:28 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id gL4rGHANW2EjcAAAMHmgww
 (envelope-from <jgross@suse.com>); Mon, 04 Oct 2021 14:19:28 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: eb28ed18-8dd0-44f3-b308-9b2cd0eaf583
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1633357168; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=fH3DuqnGZJpT+DNy0zo8NCI7OWmYxQHUzvQItaNzehQ=;
	b=KNCxsc5Tvfa4QZzFM/Ijgv0HbzzfqF41gbC0lJPL8exwmbYrfbyQcKFCbChlwsQOHOmfre
	xity+WYdsZ2I0ZHUooPKjABuxS2xDWDPpygv/CWaILHvinmf1E1DXb1s4Ocwpfji83wJQ4
	0koLcmspZmP2bLr067oGSw342JTVEEY=
From: Juergen Gross <jgross@suse.com>
To: minios-devel@lists.xenproject.org,
	xen-devel@lists.xenproject.org
Cc: samuel.thibault@ens-lyon.org,
	wl@xen.org,
	Juergen Gross <jgross@suse.com>
Subject: [PATCH 1/2] mini-os: fix testbuilds regarding CONFIG_XC
Date: Mon,  4 Oct 2021 16:19:23 +0200
Message-Id: <20211004141924.7088-2-jgross@suse.com>
X-Mailer: git-send-email 2.26.2
In-Reply-To: <20211004141924.7088-1-jgross@suse.com>
References: <20211004141924.7088-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

CONFIG_GC is requiring external support, so disable it in testbuilds.

The only reason this is working right now is its usage being inside
a HAVE_LIBC section.

Make that more obvious by making the default setting of CONFIG_XC
depending on libc being available.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 Config.mk                     | 3 ++-
 arch/x86/testbuild/all-yes    | 3 ++-
 arch/x86/testbuild/newxen-yes | 3 ++-
 3 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/Config.mk b/Config.mk
index 15311ef..8f4cea9 100644
--- a/Config.mk
+++ b/Config.mk
@@ -62,6 +62,7 @@ MINIOS_COMPILE_ARCH    ?= $(shell uname -m | sed -e s/i.86/x86_32/ \
 MINIOS_TARGET_ARCH     ?= $(MINIOS_COMPILE_ARCH)
 endif
 
+stubdom ?= n
 libc = $(stubdom)
 
 XEN_INTERFACE_VERSION ?= 0x00030205
@@ -179,7 +180,6 @@ CONFIG-y += CONFIG_FBFRONT
 CONFIG-y += CONFIG_KBDFRONT
 CONFIG-y += CONFIG_CONSFRONT
 CONFIG-y += CONFIG_XENBUS
-CONFIG-y += CONFIG_XC
 CONFIG-n += CONFIG_QEMU_XS_ARGS
 CONFIG-n += CONFIG_TEST
 CONFIG-n += CONFIG_PCIFRONT
@@ -195,6 +195,7 @@ CONFIG-y += CONFIG_PARAVIRT
 else
 CONFIG-n += CONFIG_PARAVIRT
 endif
+CONFIG-$(libc) += CONFIG_XC
 CONFIG-$(lwip) += CONFIG_LWIP
 
 $(foreach i,$(CONFIG-y),$(eval $(i) ?= y))
diff --git a/arch/x86/testbuild/all-yes b/arch/x86/testbuild/all-yes
index 8732e69..5464342 100644
--- a/arch/x86/testbuild/all-yes
+++ b/arch/x86/testbuild/all-yes
@@ -13,7 +13,8 @@ CONFIG_FBFRONT = y
 CONFIG_KBDFRONT = y
 CONFIG_CONSFRONT = y
 CONFIG_XENBUS = y
-CONFIG_XC = y
+# XC is special: it needs support from outside
+CONFIG_XC = n
 # LWIP is special: it needs support from outside
 CONFIG_LWIP = n
 CONFIG_BALLOON = y
diff --git a/arch/x86/testbuild/newxen-yes b/arch/x86/testbuild/newxen-yes
index 9c30c00..2a3ed2e 100644
--- a/arch/x86/testbuild/newxen-yes
+++ b/arch/x86/testbuild/newxen-yes
@@ -13,7 +13,8 @@ CONFIG_FBFRONT = y
 CONFIG_KBDFRONT = y
 CONFIG_CONSFRONT = y
 CONFIG_XENBUS = y
-CONFIG_XC = y
+# XC is special: it needs support from outside
+CONFIG_XC = n
 # LWIP is special: it needs support from outside
 CONFIG_LWIP = n
 CONFIG_BALLOON = y
-- 
2.26.2



From xen-devel-bounces@lists.xenproject.org Mon Oct 04 14:19:52 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Oct 2021 14:19:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.201543.356122 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXOoq-0008MK-Lf; Mon, 04 Oct 2021 14:19:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 201543.356122; Mon, 04 Oct 2021 14:19:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXOoq-0008M8-IJ; Mon, 04 Oct 2021 14:19:52 +0000
Received: by outflank-mailman (input) for mailman id 201543;
 Mon, 04 Oct 2021 14:19:50 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=7SE7=OY=suse.com=jgross@srs-us1.protection.inumbo.net>)
 id 1mXOoo-0007UW-R6
 for xen-devel@lists.xenproject.org; Mon, 04 Oct 2021 14:19:50 +0000
Received: from smtp-out2.suse.de (unknown [195.135.220.29])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id fea165a3-9fc8-4659-87e8-c3c3207b87ac;
 Mon, 04 Oct 2021 14:19:29 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id C11A320209;
 Mon,  4 Oct 2021 14:19:28 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 9662E13342;
 Mon,  4 Oct 2021 14:19:28 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id EBd+I3ANW2EjcAAAMHmgww
 (envelope-from <jgross@suse.com>); Mon, 04 Oct 2021 14:19:28 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fea165a3-9fc8-4659-87e8-c3c3207b87ac
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1633357168; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=y5GfRa8P1HM/l2d/V3JUY7JMhDq7I4DxXT7aS9qRvTY=;
	b=W3eGR43ESS6dXdxEmY4LcCwF28K5utJUzvDFY9+A42Rt0U0pJy4aIE9Nv4P9mofsPdFDIQ
	hDOODF0d5Xk/l616m8UcyenxTdkMgfsiG7AnBveF/a3k/m2M/qMaWZJlS53ozqHhiqYgTv
	s2GzF6oqJniMQaDs8QGYmfaUngdCF3Y=
From: Juergen Gross <jgross@suse.com>
To: minios-devel@lists.xenproject.org,
	xen-devel@lists.xenproject.org
Cc: samuel.thibault@ens-lyon.org,
	wl@xen.org,
	Juergen Gross <jgross@suse.com>
Subject: [PATCH 2/2] mini-os: add config options for xen libraries
Date: Mon,  4 Oct 2021 16:19:24 +0200
Message-Id: <20211004141924.7088-3-jgross@suse.com>
X-Mailer: git-send-email 2.26.2
In-Reply-To: <20211004141924.7088-1-jgross@suse.com>
References: <20211004141924.7088-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Today close hooks into libxenctrl, libxenevtchn and libxengnttab are
under the CONFIG_XC umbrella. In order to support Mini-OS builds using
stable Xen libraries only, add CONFIG_LIBXENCTRL, CONFIG_LIBXENEVTCHN
and CONFIG_LIBXENGNTTAB config options.

In case CONFIG_XC was specified in the Mini-OS config explicitly, set
the three new variables to the specified value.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 Config.mk                     | 7 ++++++-
 arch/x86/testbuild/all-no     | 4 +++-
 arch/x86/testbuild/all-yes    | 9 +++++----
 arch/x86/testbuild/newxen-yes | 9 +++++----
 lib/sys.c                     | 8 ++++++--
 5 files changed, 25 insertions(+), 12 deletions(-)

diff --git a/Config.mk b/Config.mk
index 8f4cea9..5e66089 100644
--- a/Config.mk
+++ b/Config.mk
@@ -195,7 +195,12 @@ CONFIG-y += CONFIG_PARAVIRT
 else
 CONFIG-n += CONFIG_PARAVIRT
 endif
-CONFIG-$(libc) += CONFIG_XC
+# Support legacy CONFIG_XC value
+CONFIG_XC ?= $(libc)
+CONFIG-$(CONFIG_XC) += CONFIG_LIBXENCTRL
+CONFIG-$(CONFIG_XC) += CONFIG_LIBXENEVTCHN
+CONFIG-$(CONFIG_XC) += CONFIG_LIBXENGNTTAB
+
 CONFIG-$(lwip) += CONFIG_LWIP
 
 $(foreach i,$(CONFIG-y),$(eval $(i) ?= y))
diff --git a/arch/x86/testbuild/all-no b/arch/x86/testbuild/all-no
index 1c50bba..7972ecd 100644
--- a/arch/x86/testbuild/all-no
+++ b/arch/x86/testbuild/all-no
@@ -13,7 +13,9 @@ CONFIG_FBFRONT = n
 CONFIG_KBDFRONT = n
 CONFIG_CONSFRONT = n
 CONFIG_XENBUS = n
-CONFIG_XC = n
+CONFIG_LIBXENCTRL = n
+CONFIG_LIBXENEVTCHN = n
+CONFIG_LIBXENGNTTAB = n
 CONFIG_LWIP = n
 CONFIG_BALLOON = n
 CONFIG_USE_XEN_CONSOLE = n
diff --git a/arch/x86/testbuild/all-yes b/arch/x86/testbuild/all-yes
index 5464342..bc8eea5 100644
--- a/arch/x86/testbuild/all-yes
+++ b/arch/x86/testbuild/all-yes
@@ -13,9 +13,10 @@ CONFIG_FBFRONT = y
 CONFIG_KBDFRONT = y
 CONFIG_CONSFRONT = y
 CONFIG_XENBUS = y
-# XC is special: it needs support from outside
-CONFIG_XC = n
-# LWIP is special: it needs support from outside
-CONFIG_LWIP = n
 CONFIG_BALLOON = y
 CONFIG_USE_XEN_CONSOLE = y
+# The following are special: they need support from outside
+CONFIG_LIBXENCTRL = n
+CONFIG_LIBXENEVTCHN = n
+CONFIG_LIBXENGNTTAB = n
+CONFIG_LWIP = n
diff --git a/arch/x86/testbuild/newxen-yes b/arch/x86/testbuild/newxen-yes
index 2a3ed2e..f72123b 100644
--- a/arch/x86/testbuild/newxen-yes
+++ b/arch/x86/testbuild/newxen-yes
@@ -13,10 +13,11 @@ CONFIG_FBFRONT = y
 CONFIG_KBDFRONT = y
 CONFIG_CONSFRONT = y
 CONFIG_XENBUS = y
-# XC is special: it needs support from outside
-CONFIG_XC = n
-# LWIP is special: it needs support from outside
-CONFIG_LWIP = n
 CONFIG_BALLOON = y
 CONFIG_USE_XEN_CONSOLE = y
 XEN_INTERFACE_VERSION=__XEN_LATEST_INTERFACE_VERSION__
+# The following are special: they need support from outside
+CONFIG_LIBXENCTRL = n
+CONFIG_LIBXENEVTCHN = n
+CONFIG_LIBXENGNTTAB = n
+CONFIG_LWIP = n
diff --git a/lib/sys.c b/lib/sys.c
index c6a7b9f..e8d5eb2 100644
--- a/lib/sys.c
+++ b/lib/sys.c
@@ -437,13 +437,17 @@ int close(int fd)
 	    return res;
 	}
 #endif
-#ifdef CONFIG_XC
+#ifdef CONFIG_LIBXENCTRL
 	case FTYPE_XC:
 	    minios_interface_close_fd(fd);
 	    return 0;
+#endif
+#ifdef CONFIG_LIBXENEVTCHN
 	case FTYPE_EVTCHN:
 	    minios_evtchn_close_fd(fd);
             return 0;
+#endif
+#ifdef CONFIG_LIBXENGNTTAB
 	case FTYPE_GNTMAP:
 	    minios_gnttab_close_fd(fd);
 	    return 0;
@@ -1373,7 +1377,7 @@ void *mmap(void *start, size_t length, int prot, int flags, int fd, off_t offset
 
     if (fd == -1)
         return map_zero(n, 1);
-#ifdef CONFIG_XC
+#ifdef CONFIG_LIBXENCTRL
     else if (files[fd].type == FTYPE_XC) {
         unsigned long zero = 0;
         return map_frames_ex(&zero, n, 0, 0, 1, DOMID_SELF, NULL, 0);
-- 
2.26.2



From xen-devel-bounces@lists.xenproject.org Mon Oct 04 14:23:02 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Oct 2021 14:23:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.201560.356137 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXOrq-0001ox-9C; Mon, 04 Oct 2021 14:22:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 201560.356137; Mon, 04 Oct 2021 14:22:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXOrq-0001oq-5C; Mon, 04 Oct 2021 14:22:58 +0000
Received: by outflank-mailman (input) for mailman id 201560;
 Mon, 04 Oct 2021 14:22:56 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=DuXV=OY=citrix.com=christian.lindig@srs-us1.protection.inumbo.net>)
 id 1mXOro-0001ok-9p
 for xen-devel@lists.xenproject.org; Mon, 04 Oct 2021 14:22:56 +0000
Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 8c97d8ea-251e-11ec-beaf-12813bfff9fa;
 Mon, 04 Oct 2021 14:22:54 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8c97d8ea-251e-11ec-beaf-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1633357374;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:mime-version;
  bh=rZSHagQkHdaLmioOS0zrAPmUfj06qxIyOaQuIhkt7tE=;
  b=VGozFb/TSprIQ78kWIWZ2+9T718omcvILsuFedulJrHd8/eTRU304Bxf
   x5Icf0DhYZ/sjqBfiPD18JFyZxpxLRpmYwukSZVQcdpAA9m5idVAGf1vj
   8wyuPtQZi0rX1+zrCgziJFxzpGvDP11/QPRvnfvxN24NC1esEvla9gAAS
   0=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: +tZ9VkADjW3Wwb7919f+oyQ1Pa3KI6L0IgMNDdpH6WH73xdOGPHjV7fBiCRGHl5yEgyI0lrQAy
 Zrl77Apk4fIsDzgkRUdghRPtiCJxyaPc9U+icyQ7QerV6nbRvp5rLI7nPQ7KirHBASEvfM+xJb
 6UOWAp2EPpEwuZV7ZFC96NiQCXcY6jkZkvo89fgqxQK8/b38/Z5mAVJKfMrAbsCxcz3CbTuidk
 w4/tBRPrLg7kZbV23jK/yqtfAVEfjTEpmtdowfJEt7zKPATgWtxpbL4YitzN5ncFOZmsTpV3W/
 v3G1vJFDR2plBd6cM+GldbCJ
X-SBRS: 5.1
X-MesageID: 54276737
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:HMc6HKw1qg3ex3nybzN6t+cmwCrEfRIJ4+MujC+fZmUNrF6WrkVRn
 WoaCjzSbv2IMzH8eI13YNm/8RsB6pDUz4dmSQFt/CAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx
 59DAjUVBJlsFhcwnvopW1TYhSEUOZugH9IQM8aZfHAsLeNYYH1500s6w7Zl2tQAbeWRWGthh
 /uj+6UzB3f9s9JEGjp8B3Wr8U4HUFza4Vv0j3RmDRx5lAa2e0o9VfrzEZqZPXrgKrS4K8bhL
 wr1IBNVyUuCl/slIovNfr8W6STmSJaKVeSFoiI+t6RPHnGuD8H9u0o2HKN0VKtZt9mGt/1ck
 flB7KSScgwoBbXrp80yWjVAPhgraMWq+JefSZS+mcmazkmAeHrw2fR+SkoxOOX0+M4uXzsIr
 6ZBbmlQMFbT3Ipaw5riIgVors8jNsjwIIIWvDdkzDfVDPkOSpHfWaTao9Rf2V/cg+gTQayBO
 ZVCNlKDajzlfxdzGkUVBqkvhbv2tmLnIidUhH+K8P9fD2/7k1UqjemF3MDuUt6ASNhRn02Yj
 nnb5Gm/CRYfXPSAzRKV/3TqgfXA9Qv5RYYTGbuQ5vNsxlqJyQQ7NhoSUleqpOijvWS3UdlfN
 k889zInqO4580nDZsLmQxSyrXqAvxgdc9ldCes37EeK0KW8yweGBEAUQzhZctskucQqAzsw2
 Tehj97vQDBirrCRYXac7auP6yO/PzAPKm0PbjNCShEKi/H5qYEuilTUT9BsEIa8lNizEjb1q
 xiAoTIinbwVgYgO3r+i4FHcqzu2o97CSQtdzgneQG+N9A5yY4+hIYuy5jDzxPBMNovfdkOTr
 WcNgcG25foLS5qKkUSwrP4lRe/zoazfaXuF3AApT8JJGymRF2CLUK0JzD0nHGVSOcc/YRjWS
 WDalRt83coGVJe1VpNfb4W0AsUs6KHvE9X5S/zZBuZzjohNmByvpn83Oh/Jt4z5uA18yfhgZ
 cfzndOEVy5yNEhx8Nahqw7xO5cFwToijUfaWJz21Riu1bf2iJW9EuxeaArmggzU9sq5TOTpH
 zR3a5TiJ/Z3CrSWjszrHWg7dwpiwZ8TX8+eliCvXrTfSjeK4Ul4YxMr/ZsvepZ+g4NenfrS8
 3e2VydwkQSk3ieXd1nSMCA+OdsDuKqTS1phYETA2n7yixAejXuHtv9DJ/Pbg5F9nACc8RKEZ
 6ZcIJjRahi+Yj/G5y4cffHAQH9KL3yWafa1F3P9OlAXJsc4LySQo4OMVla/pUEmU3vs3eNj8
 uLI6+8uacdaL+iUJJ2NM6zHIpLYlSV1pd+eqGOSeYQMJBWwrtI6Q8Ez59duS/wxxdz47mLy/
 y6dAAsCpPmLpIkw8dLTgruDoZvvGOx7dne21UGAhVpvHSWFrGel36FaV+OEIWLUWG/uof3wb
 uRJ1fDsdvYAmQ8S4YZ7Fr9qy4M45sfu+OAGnlg1Qi2TYgT5EK5kL1mHwdJL6v9HyIhGtFbkQ
 UmI4NRbZ+mEYZu3DF4LKQM5Re2fzvVIyCLK5PE4LRyiti969baKS2tIOByIhHAPJbd5Ktp9k
 +wgpNQX+0q0jR9zaoSKiSVd9mKtKH0cUvp46sFGUdGz0gdykwNMe53RDCPy8aqjUdQUPxl4O
 CKQiYrDm69YmhjIfU0sGCWfxuFan5kP5kxHlQdQO1STl9PZrfYrxxkNoy8vRwFYwxgbgeJ+P
 m9nax98KamUpmo6gcFCWyanGh1bBQ3f8Uv0kgNbmGrcRkiud2rMMGxiZrrdoBFHqzpRLmpB4
 bWV6Gf5SjK7Lsj+0xw7VVNht/G+H8d68RfPmZz/EsmId3XgjeEJXkN6ibI0liba
IronPort-HdrOrdr: A9a23:/d7PAa31b+IP9T1JTmKmQAqjBR9yeYIsimQD101hICG9Lfb2qy
 n+ppgmPEHP5Qr5AEtQ5OxpOMG7MBbhHO1OkPUs1NaZLUfbUQ6TQr2KgrGSugEIdxeOldK1kJ
 0QCZSWa+eATGSS7/yKmDVQeuxIqLLskcCVbKXlvgxQpGlRGvpdBmxCe2Km+zhNNW977O0CZf
 2hD6R81lidUEVSSv7+KmgOXuDFqdGOvonhewQ6Cxku7xTLpS+06ZbheiLonis2Yndq+/MP4G
 LFmwv26uGIqPeg0CLR0GfV8tB/hMbh8N1eH8aB4/JlaQkEyzzYJriJaYfy+Azdk9vfr2rCV+
 O85SvICv4Drk85uFvF+CcFlTOQiArGoEWStmNwyUGT3/ARAghKUfapzLgpAifx+g4uuspx37
 lM2H/cv51LDQnYlCC4/NTQUQp2/3DE7EbLAYYo/g1iuKYlGfRsRLYkjQlo+VY7bVXHwZFiFP
 MrANDX5f5Qf1/fZ3fFvnN3yNjpWngoBB+JTkULp8TQilFt7T9E5lpdwNZakmYL9Zo7RZUB7+
 PYMr5wnLULSsMNd6pyCOoIXMPyAG3QRhDHNn6UPD3cZe06EmOIr4Sy7KQ+5emsdpBNxJwumI
 7ZWFcdrmI2c1KGM7zH4HSKyGGFfIyZZ0WY9ihz3ekKhlTMfsucDcTYciFcryKJmYRrPvHm
X-IronPort-AV: E=Sophos;i="5.85,346,1624334400"; 
   d="scan'208,217";a="54276737"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Lcfk0UOP+kqU5PwGC3R2zm4ItL/kVusW6AkCYv6FF0Of5gIyZ4n4BJGZ0rxraBSIIh4UVMiZZl1pR1tQt0DW79FGu8398X7DvM5S2NIRTRVS0nmP3MF7tUtaNvKs91JGzN/bTmd2e07imenZ/77mkdRHrhcIkKWJrYWjwkfr2Ag7hL5gXia9Xb6mPzwM17HHh7F9fBGdQFcYY7TvCU78A5CrNO9HrNUN/Mvzma4xo/ji06peZMrgN3/5gIspku+NH1QzxvTsTOSamXH/wzLwxlJVZVqpBZ7sS5btnJV8sLDpKlZMfKGWXlWabBU1ag92NwlR22veAYEjthL/Xg6bKQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=x29O2RVr+mDsxew5znG3uS3IAdHgrAzsGnuFb49Im38=;
 b=Pz+w6ASQh1Kd5xn6twpvzG4twTcvV76nSm9UOgxe/l97JDg4ATPhpsP2hSNjknmQuz6kezIa2bhdfrcXOZIitXX19IPCWYiDJvSvAR79HvFptfxN4PMfQbxoTwnR1Cd/Z+K5H6nKn1eHJBCq1NUojuURWhEi5HI/84xs8s1kChMN1ZHbAU4p5B7uaZAK9Cxg8baJ5Iq6qImo9mKOFPbIaIXs/dkABkB4+B2VJvJoLtpE8bykijtsSq8xmtGEjPxKmBxMrjBOKzPjC8wn//kYnQPfR26LWLUsmjtP04Dc6puhRHCtwODdQEa4AtYtZjZpRX0JvccUwUGmbPBavSrXIg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=x29O2RVr+mDsxew5znG3uS3IAdHgrAzsGnuFb49Im38=;
 b=Cp5hyjAjesoa2roHgWe156G03QaxUwEoJb6lagxIxhdc5Qi5AtZqfcpvyXrlcYjncoS5AF6BRMf8FxfueJf0CD/JCMoWvfQspkh/nU43z1rnrp3KsjRC/cy32bpK/iZJzgsylizld20l/9v+0SrVU/4QKB/oaMuWBjR7SiIDgJs=
From: Christian Lindig <christian.lindig@citrix.com>
To: Rahul Singh <rahul.singh@arm.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	"bertrand.marquis@arm.com" <bertrand.marquis@arm.com>,
	"Andre.Przywara@arm.com" <Andre.Przywara@arm.com>, David Scott
	<dave@recoil.org>, Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>,
	Andrew Cooper <Andrew.Cooper3@citrix.com>, George Dunlap
	<George.Dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>, Julien Grall
	<julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>, "Volodymyr
 Babchuk" <Volodymyr_Babchuk@epam.com>, Roger Pau Monne <roger.pau@citrix.com>
Subject: Re: [PATCH v4 10/14] xen/domctl: Introduce XEN_DOMCTL_CDF_vpci flag
Thread-Topic: [PATCH v4 10/14] xen/domctl: Introduce XEN_DOMCTL_CDF_vpci flag
Thread-Index: AQHXuRb8re94wMW7AE6VMwXrx9xiTKvC5EKA
Date: Mon, 4 Oct 2021 14:22:11 +0000
Message-ID: <33A48340-2DA2-434D-A6BC-97E48C7FB236@citrix.com>
References: <cover.1633340795.git.rahul.singh@arm.com>
 <f22c06abf5faa0a2f9c044f5b4009a99d7942215.1633340795.git.rahul.singh@arm.com>
In-Reply-To: <f22c06abf5faa0a2f9c044f5b4009a99d7942215.1633340795.git.rahul.singh@arm.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3608.120.23.2.4)
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 36b0f5a5-c01e-4887-f7e9-08d987425b2d
x-ms-traffictypediagnostic: CO6PR03MB6211:
x-ms-exchange-transport-forked: True
x-microsoft-antispam-prvs: <CO6PR03MB6211F64C057DB4CAC730F053F6AE9@CO6PR03MB6211.namprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:7219;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: D+mWRlv1wXXwVdU2/IjRxQGWfoveM27IhQOavBReUwLKZjjHFm8UEPYDuBT0FAPBeUKvGmSaFJyt+98ph1clHwSnhMGssoKznGJvcS5Gks0CNsF3d6cVne/tAtaLaCzJK08a/cb7V+LnIRFiWZ0gOMiS0O6/WeGX7d6wTSe8mF9d597ofewE5+chrKD3ZWgvJHa0HhOiCWR6KZ38EfNj5eZCCXoSG3OpvsGHLl0ahCP+qgIXXnqjJsAjifh9I0RjbcE5QeiGb7F3KdpggxgMEKLDkpiCJcF7h2Xo8p7LRrgWM22lqPHhFjApxJwNdCwzI3bO8BwpAk8M0uw6+TeC11wDoiRzu6Hz0soKDWycuABb79cOpLoQ8xrHebS+nuhdoUnyo6jAG9heYvuIT74NOEjNrMPbCHDePHpbM9C49otePDSc8OwSQRdtMPhHXOmwImmXDs2o6gdFqywcHHuWIgt5u5cJ2i17pp1xuwLhznpMJCMxbiT1NcTLjazrlxFFxvAMvs7AnRLYVhdXdbeeD3J/eCP2AfI/5zh1wG49r0i4GZte8jNXgc9QoPyZeQembYKcxoHML8Xcsob284VSUeLRhovaiSX1gSTgHGkx8I6rgnMdm9N4vspbph+NyfLmoGfMyEk/MuYviQDIKrSxp8nqj3dn/RGjXr8trVGHt6FVuIzt16l+HVPJBOVBDPuThOfo3uvaHdCdKY82hoFIV4pS13xFjYDBfoujtvFGYkQ=
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR03MB6380.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(38100700002)(122000001)(2616005)(6506007)(54906003)(53546011)(33656002)(8936002)(26005)(5660300002)(55236004)(66446008)(64756008)(76116006)(66556008)(91956017)(66946007)(508600001)(4326008)(6512007)(186003)(66476007)(316002)(8676002)(4744005)(107886003)(86362001)(44832011)(36756003)(2906002)(6916009)(6486002)(71200400001)(7416002)(83380400001)(38070700005)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?WXZlazKO43xxC8NpczL99QGFUXYG2DLglApTHvS/ceDiY58U5F+dsSeaULUG?=
 =?us-ascii?Q?Yl7S0d7D7TNO2K9TgVbP7DeIeexmTTQ2HY6QM2N9FzQMdjFiOf9Ww+8imy/c?=
 =?us-ascii?Q?Sg+tCPxAYpqEy82SAa73A3gA6PHOs7Pk0yMyESFJT44EK4v3odihh/d+q/uB?=
 =?us-ascii?Q?+mhl1C4tqbrFlaAP7KG3MtfE/7xzvesisD/0LNQ3AECN79mQUQqC9leQifGp?=
 =?us-ascii?Q?qWkLspKTUYTKmnYk7uNjEoD38/AddA2YNm0kAwWSbu22UC7Zh8gfndPtCMTp?=
 =?us-ascii?Q?kwcxfrUe9xJyl0IAy/wiIxE3QwiWaw1fWHWCws9fFPG3v6O0P6qGfVIimsRk?=
 =?us-ascii?Q?hvJCLZx7Q/5OEtPlozWkEeR1omlMpoLviMDkyLx6EUvRWYausLBAObVpNIEn?=
 =?us-ascii?Q?BWh8bJ+bZH6NX6DaoG9CPjpdlpzmUPyTT9P7LYbd8wBn2929PyM6HqsHUkzc?=
 =?us-ascii?Q?wuU7tCL07K0E9g1h22bdwrQcte/WTDKo7y/N24OpTPzIUwTtCVRPbDl7OrvM?=
 =?us-ascii?Q?J/KiebeQJXSYIERhSDtFRgG8DYGjRNzm2XV/WNKqZvhY/lpVnOnJ3ShFidtU?=
 =?us-ascii?Q?BCVj6/eXCTjfmtkodp6GyqJp46QoXo6RfAz2B19fe3jwQ/EdXAsFwGh1gm3f?=
 =?us-ascii?Q?eJInozSZfrP5O8B2GGZO7D8/PY0pyOJ/F36IQwZGoBXlasuk9/NBV/CeW+Zj?=
 =?us-ascii?Q?ob8LkTrVtoXjEQ4yK4eBNA0HY/JVPouelqFCQmxH+rsm1JrVt0lYELrEPbow?=
 =?us-ascii?Q?DG8FgRu8agA5l/PC1sGYQyYrcPDndNHUGwfngr1b5i1pz4ISUh5lhE4dp77Y?=
 =?us-ascii?Q?2yCrYnySmsUuCJJ02OVUkWgmtTg0bd9JZ23bwWHD6Uzw41g3RPALWrE6ghR3?=
 =?us-ascii?Q?f9FD7a2mEmvsPK2v4XEFcbiMJWNSkLphzWog70g0ni7gZn4Q13z7N5AHyGBB?=
 =?us-ascii?Q?0n3ZbQv9n8fNz2bnf9gcAgpWAqUcV97qXKwYqLSvheNnRbrqvokzcUCXsL6D?=
 =?us-ascii?Q?P1wC1JGxdHZp6KvwugB4ZdApbelll3GUVnel2qFHdxelrdMh+pgM3uljacW6?=
 =?us-ascii?Q?uXd3+AQ8D8BuQxnDtdz3xVkRISPVxQpkNZ91BDn/mnO/EhlR5fgZRgao05CY?=
 =?us-ascii?Q?lSAAPJ8TvxoBfwTjFUnO2nmugU9KXiXGhwigdv56y/eBEiDLUEa5ojgs+b8h?=
 =?us-ascii?Q?2EeS0MSJz0ZyJDGySU+v/M+6Wjzh508TQKy+vRyIMeU0uy+YPqa6xpVovUmS?=
 =?us-ascii?Q?pBseCCMo5BbJVz8AVcmxzVg3jkLfzEVpxBxS87FSJl6Pyzmh097uv10Wvzq5?=
 =?us-ascii?Q?zYsueEhw7pT3OKlxyruWAMRL?=
Content-Type: multipart/alternative;
	boundary="_000_33A483402DA2434DA6BC97E48C7FB236citrixcom_"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MW4PR03MB6380.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 36b0f5a5-c01e-4887-f7e9-08d987425b2d
X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Oct 2021 14:22:11.5552
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Jzv0Kp7reTs/5GnIKzfmu8Mrqiqa70sdW5u3b4lW98LH3RlnwIFIOv4WZAm3R99INOeRGbh2KkFPwZFNjV4kLu11q+KCigJ3S2X9y85hffk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR03MB6211
X-OriginatorOrg: citrix.com

--_000_33A483402DA2434DA6BC97E48C7FB236citrixcom_
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable



On 4 Oct 2021, at 12:52, Rahul Singh <rahul.singh@arm.com<mailto:rahul.sing=
h@arm.com>> wrote:

ntroduce XEN_DOMCTL_CDF_vpci flag to enable VPCI support in XEN.
Reject the use of this new flag for x86 as VPCI is not supported for
DOMU guests for x86.

Signed-off-by: Rahul Singh <rahul.singh@arm.com<mailto:rahul.singh@arm.com>=
>
---
Change in v4: Added in this version
---
---
tools/ocaml/libs/xc/xenctrl.ml  | 1 +
tools/ocaml/libs/xc/xenctrl.mli | 1 +
xen/arch/arm/domain.c           | 4 ++--
xen/arch/x86/domain.c           | 6 ++++++
xen/common/domain.c             | 2 +-
xen/include/public/domctl.h     | 4 +++-
6 files changed, 14 insertions(+), 4 deletions(-)

Acked-by: Christian Lindig <christian.lindig@citrix.com<mailto:christian.li=
ndig@citrix.com>>

--_000_33A483402DA2434DA6BC97E48C7FB236citrixcom_
Content-Type: text/html; charset="us-ascii"
Content-ID: <D7E7FE3D4E6B2D41B8EDE97BD1674EEE@namprd03.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable

<html>
<head>
<meta http-equiv=3D"Content-Type" content=3D"text/html; charset=3Dus-ascii"=
>
</head>
<body style=3D"word-wrap: break-word; -webkit-nbsp-mode: space; line-break:=
 after-white-space;" class=3D"">
<br class=3D"">
<div><br class=3D"">
<blockquote type=3D"cite" class=3D"">
<div class=3D"">On 4 Oct 2021, at 12:52, Rahul Singh &lt;<a href=3D"mailto:=
rahul.singh@arm.com" class=3D"">rahul.singh@arm.com</a>&gt; wrote:</div>
<br class=3D"Apple-interchange-newline">
<div class=3D""><span style=3D"caret-color: rgb(0, 0, 0); font-family: Helv=
etica; font-size: 12px; font-style: normal; font-variant-caps: normal; font=
-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0p=
x; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-te=
xt-stroke-width: 0px; text-decoration: none; float: none; display: inline !=
important;" class=3D"">ntroduce
 XEN_DOMCTL_CDF_vpci flag to enable VPCI support in XEN.</span><br style=3D=
"caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-s=
tyle: normal; font-variant-caps: normal; font-weight: normal; letter-spacin=
g: normal; text-align: start; text-indent: 0px; text-transform: none; white=
-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-dec=
oration: none;" class=3D"">
<span style=3D"caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size=
: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal;=
 letter-spacing: normal; text-align: start; text-indent: 0px; text-transfor=
m: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width:=
 0px; text-decoration: none; float: none; display: inline !important;" clas=
s=3D"">Reject
 the use of this new flag for x86 as VPCI is not supported for</span><br st=
yle=3D"caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; =
font-style: normal; font-variant-caps: normal; font-weight: normal; letter-=
spacing: normal; text-align: start; text-indent: 0px; text-transform: none;=
 white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; te=
xt-decoration: none;" class=3D"">
<span style=3D"caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size=
: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal;=
 letter-spacing: normal; text-align: start; text-indent: 0px; text-transfor=
m: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width:=
 0px; text-decoration: none; float: none; display: inline !important;" clas=
s=3D"">DOMU
 guests for x86.</span><br style=3D"caret-color: rgb(0, 0, 0); font-family:=
 Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal;=
 font-weight: normal; letter-spacing: normal; text-align: start; text-inden=
t: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webk=
it-text-stroke-width: 0px; text-decoration: none;" class=3D"">
<br style=3D"caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: =
12px; font-style: normal; font-variant-caps: normal; font-weight: normal; l=
etter-spacing: normal; text-align: start; text-indent: 0px; text-transform:=
 none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0=
px; text-decoration: none;" class=3D"">
<span style=3D"caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size=
: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal;=
 letter-spacing: normal; text-align: start; text-indent: 0px; text-transfor=
m: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width:=
 0px; text-decoration: none; float: none; display: inline !important;" clas=
s=3D"">Signed-off-by:
 Rahul Singh &lt;</span><a href=3D"mailto:rahul.singh@arm.com" style=3D"fon=
t-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps=
: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-=
align: start; text-indent: 0px; text-transform: none; white-space: normal; =
widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-te=
xt-stroke-width: 0px;" class=3D"">rahul.singh@arm.com</a><span style=3D"car=
et-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style=
: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: n=
ormal; text-align: start; text-indent: 0px; text-transform: none; white-spa=
ce: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decorat=
ion: none; float: none; display: inline !important;" class=3D"">&gt;</span>=
<br style=3D"caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: =
12px; font-style: normal; font-variant-caps: normal; font-weight: normal; l=
etter-spacing: normal; text-align: start; text-indent: 0px; text-transform:=
 none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0=
px; text-decoration: none;" class=3D"">
<span style=3D"caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size=
: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal;=
 letter-spacing: normal; text-align: start; text-indent: 0px; text-transfor=
m: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width:=
 0px; text-decoration: none; float: none; display: inline !important;" clas=
s=3D"">---</span><br style=3D"caret-color: rgb(0, 0, 0); font-family: Helve=
tica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-=
weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px=
; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-tex=
t-stroke-width: 0px; text-decoration: none;" class=3D"">
<span style=3D"caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size=
: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal;=
 letter-spacing: normal; text-align: start; text-indent: 0px; text-transfor=
m: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width:=
 0px; text-decoration: none; float: none; display: inline !important;" clas=
s=3D"">Change
 in v4: Added in this version</span><br style=3D"caret-color: rgb(0, 0, 0);=
 font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-=
caps: normal; font-weight: normal; letter-spacing: normal; text-align: star=
t; text-indent: 0px; text-transform: none; white-space: normal; word-spacin=
g: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=3D"">
<span style=3D"caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size=
: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal;=
 letter-spacing: normal; text-align: start; text-indent: 0px; text-transfor=
m: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width:=
 0px; text-decoration: none; float: none; display: inline !important;" clas=
s=3D"">---</span><br style=3D"caret-color: rgb(0, 0, 0); font-family: Helve=
tica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-=
weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px=
; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-tex=
t-stroke-width: 0px; text-decoration: none;" class=3D"">
<span style=3D"caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size=
: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal;=
 letter-spacing: normal; text-align: start; text-indent: 0px; text-transfor=
m: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width:=
 0px; text-decoration: none; float: none; display: inline !important;" clas=
s=3D"">---</span><br style=3D"caret-color: rgb(0, 0, 0); font-family: Helve=
tica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-=
weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px=
; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-tex=
t-stroke-width: 0px; text-decoration: none;" class=3D"">
<span style=3D"caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size=
: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal;=
 letter-spacing: normal; text-align: start; text-indent: 0px; text-transfor=
m: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width:=
 0px; text-decoration: none; float: none; display: inline !important;" clas=
s=3D"">tools/ocaml/libs/xc/xenctrl.ml
 &nbsp;| 1 +</span><br style=3D"caret-color: rgb(0, 0, 0); font-family: Hel=
vetica; font-size: 12px; font-style: normal; font-variant-caps: normal; fon=
t-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0=
px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-t=
ext-stroke-width: 0px; text-decoration: none;" class=3D"">
<span style=3D"caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size=
: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal;=
 letter-spacing: normal; text-align: start; text-indent: 0px; text-transfor=
m: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width:=
 0px; text-decoration: none; float: none; display: inline !important;" clas=
s=3D"">tools/ocaml/libs/xc/xenctrl.mli
 | 1 +</span><br style=3D"caret-color: rgb(0, 0, 0); font-family: Helvetica=
; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weig=
ht: normal; letter-spacing: normal; text-align: start; text-indent: 0px; te=
xt-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-st=
roke-width: 0px; text-decoration: none;" class=3D"">
<span style=3D"caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size=
: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal;=
 letter-spacing: normal; text-align: start; text-indent: 0px; text-transfor=
m: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width:=
 0px; text-decoration: none; float: none; display: inline !important;" clas=
s=3D"">xen/arch/arm/domain.c
 &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;| 4 ++--</span=
><br style=3D"caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size:=
 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; =
letter-spacing: normal; text-align: start; text-indent: 0px; text-transform=
: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: =
0px; text-decoration: none;" class=3D"">
<span style=3D"caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size=
: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal;=
 letter-spacing: normal; text-align: start; text-indent: 0px; text-transfor=
m: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width:=
 0px; text-decoration: none; float: none; display: inline !important;" clas=
s=3D"">xen/arch/x86/domain.c
 &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;| 6 ++++++</sp=
an><br style=3D"caret-color: rgb(0, 0, 0); font-family: Helvetica; font-siz=
e: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal=
; letter-spacing: normal; text-align: start; text-indent: 0px; text-transfo=
rm: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width=
: 0px; text-decoration: none;" class=3D"">
<span style=3D"caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size=
: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal;=
 letter-spacing: normal; text-align: start; text-indent: 0px; text-transfor=
m: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width:=
 0px; text-decoration: none; float: none; display: inline !important;" clas=
s=3D"">xen/common/domain.c
 &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;| =
2 +-</span><br style=3D"caret-color: rgb(0, 0, 0); font-family: Helvetica; =
font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight=
: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text=
-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stro=
ke-width: 0px; text-decoration: none;" class=3D"">
<span style=3D"caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size=
: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal;=
 letter-spacing: normal; text-align: start; text-indent: 0px; text-transfor=
m: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width:=
 0px; text-decoration: none; float: none; display: inline !important;" clas=
s=3D"">xen/include/public/domctl.h
 &nbsp;&nbsp;&nbsp;&nbsp;| 4 +++-</span><br style=3D"caret-color: rgb(0, 0,=
 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-vari=
ant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: =
start; text-indent: 0px; text-transform: none; white-space: normal; word-sp=
acing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=
=3D"">
<span style=3D"caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size=
: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal;=
 letter-spacing: normal; text-align: start; text-indent: 0px; text-transfor=
m: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width:=
 0px; text-decoration: none; float: none; display: inline !important;" clas=
s=3D"">6
 files changed, 14 insertions(+), 4 deletions(-)</span></div>
</blockquote>
</div>
<br class=3D"">
<div class=3D""><span style=3D"font-family: Menlo; font-size: 14px;" class=
=3D"">Acked-by: Christian Lindig &lt;</span><a href=3D"mailto:christian.lin=
dig@citrix.com" class=3D"" style=3D"font-family: Menlo; font-size: 14px;">c=
hristian.lindig@citrix.com</a><span style=3D"font-family: Menlo; font-size:=
 14px;" class=3D"">&gt;</span></div>
</body>
</html>

--_000_33A483402DA2434DA6BC97E48C7FB236citrixcom_--


From xen-devel-bounces@lists.xenproject.org Mon Oct 04 15:23:16 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Oct 2021 15:23:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.201574.356148 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXPnn-0007qy-Ne; Mon, 04 Oct 2021 15:22:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 201574.356148; Mon, 04 Oct 2021 15:22:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXPnn-0007qr-K7; Mon, 04 Oct 2021 15:22:51 +0000
Received: by outflank-mailman (input) for mailman id 201574;
 Mon, 04 Oct 2021 15:22:50 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mXPnm-0007ql-E5
 for xen-devel@lists.xenproject.org; Mon, 04 Oct 2021 15:22:50 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mXPnm-0006Sq-71
 for xen-devel@lists.xenproject.org; Mon, 04 Oct 2021 15:22:50 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mXPnm-0001L0-5q
 for xen-devel@lists.xenproject.org; Mon, 04 Oct 2021 15:22:50 +0000
Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89)
 (envelope-from <iwj@xenproject.org>)
 id 1mXPnh-00069f-3w; Mon, 04 Oct 2021 16:22:45 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:To:Date:
	Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From;
	bh=WmCVz8cIuJXVv4OwZK710il+hN8M1FemURRpKATNDTI=; b=daCVzO0XpmIw5Wtl1E1cz82p3S
	0c5kOA2ecaSwRa88mMQq97qoHMsl8lFptmLfemnkDhEQvu2TjLu0MjBlJ2OK5Tzflv3wulsaOs/nJ
	boYXryHqav5btIi3j+8RkjAunu35ZnnrztLJ3Ng+wq8zDjowrMmJOAP5H8+HmQ7j0TAE=;
From: Ian Jackson <iwj@xenproject.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <24923.7236.871825.647092@mariner.uk.xensource.com>
Date: Mon, 4 Oct 2021 16:22:44 +0100
To: Jan Beulich <jbeulich@suse.com>,
    Julien Grall <julien.grall.oss@gmail.com>,
    xen-devel <xen-devel@lists.xenproject.org>,
    Stefano Stabellini <sstabellini@kernel.org>,
    dpsmith@apertussolutions.com
Subject: Re: [xen-unstable test] 164996: regressions - FAIL
In-Reply-To: <24915.16323.60012.172236@mariner.uk.xensource.com>
References: <osstest-164996-mainreport@xen.org>
	<d049ba60-db81-aaa4-1769-54c6964cfd06@suse.com>
	<24904.44119.940679.241639@mariner.uk.xensource.com>
	<alpine.DEB.2.21.2109211631330.17979@sstabellini-ThinkPad-T480s>
	<19906cf8-365b-63c9-5c59-aef8dae41505@suse.com>
	<alpine.DEB.2.21.2109221807131.17979@sstabellini-ThinkPad-T480s>
	<CAJ=z9a1W9BqeOGFu3F2+qbXM6UNo8ZO=0y-zYsnK01MNSNdbkw@mail.gmail.com>
	<dda286dc-1edc-4505-a049-e82047b44590@suse.com>
	<24915.16323.60012.172236@mariner.uk.xensource.com>
X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu)

Ian Jackson writes ("Re: [xen-unstable test] 164996: regressions - FAIL"):
> Thanks.  The attachment didn't git-am but I managed to make a tree
> with it in (but a bogus commit message).
> 
> I have a repro of 165218 test-arm64-arm64-libvirt-raw (that's the last
> xen-unstable flight) running.  If all goes well it will rebuild Linux
> from my branch (new flight 165241) and then run the test using that
> kernel (new flight 165242).  I have told it to report to the people on
> this thread (and the list).
> 
> It will probably report in an hour or two (since it needs to rebuild a
> kernel and then negotiate to get a host to run the repro on).
> I didn't ask it to keep the host for me, but it ought to publish the
> logs and as I say, send an email report here.

This was disrupted by the osstest failure.  I'm running it again.
165354 and 165355.

Ian.

For my reference:

./mg-transient-task ./mg-repro-setup -P -Exen-devel@lists.xenproject.org,jbeulich@suse.com,julien.grall.oss@gmail.com,iwj@xenproject.org,sstabellini@kernel.org,dpsmith@apertussolutions.com 165218 test-arm64-arm64-libvirt-raw X --rebuild +linux=https://xenbits.xen.org/git-http/people/iwj/linux.git#164996-fix alloc:'{equiv-rochester,real}


From xen-devel-bounces@lists.xenproject.org Mon Oct 04 15:56:52 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Oct 2021 15:56:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.201583.356158 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXQKb-0002hg-BI; Mon, 04 Oct 2021 15:56:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 201583.356158; Mon, 04 Oct 2021 15:56:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXQKb-0002hZ-7x; Mon, 04 Oct 2021 15:56:45 +0000
Received: by outflank-mailman (input) for mailman id 201583;
 Mon, 04 Oct 2021 15:56:44 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ilK6=OY=greensocs.com=damien.hedde@srs-us1.protection.inumbo.net>)
 id 1mXQKZ-0002hT-Rq
 for xen-devel@lists.xenproject.org; Mon, 04 Oct 2021 15:56:44 +0000
Received: from beetle.greensocs.com (unknown [5.135.226.135])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id ebe53308-76b0-40f3-9609-e9e699a3d2cc;
 Mon, 04 Oct 2021 15:56:41 +0000 (UTC)
Received: from [192.168.15.181] (unknown [195.68.53.70])
 by beetle.greensocs.com (Postfix) with ESMTPSA id 9EA69208A1;
 Mon,  4 Oct 2021 15:56:37 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ebe53308-76b0-40f3-9609-e9e699a3d2cc
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=greensocs.com;
	s=mail; t=1633362999;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=iW9CkzSuzFakm6dIMJ0sNZe5+RrBD4UyGJTesU86nTs=;
	b=a2cCLUvTKZXBLhv9F9vzjODrDddU+GRb/bGgbfYX1V67qNfIyX2cw/OZgoF/aKX24W6ybD
	FNXCOc8NsqQBgH48p0sW6ehRGMq8ptmJ8fhWhIyHRQPJjXwoGvEqqDH7EBJJf97Jpo5tsU
	do+k4yCJpn9ox7UUcKfLuS0Bcthgddc=
Message-ID: <2ba3a11b-9022-e537-d713-4aa173020a87@greensocs.com>
Date: Mon, 4 Oct 2021 17:56:36 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.1.2
Subject: Re: [RFC PATCH v2 00/16] Initial support for machine creation via QMP
Content-Language: en-US-large
To: qemu-devel@nongnu.org
Cc: Alistair Francis <Alistair.Francis@wdc.com>,
 =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= <marcandre.lureau@redhat.com>,
 Paolo Bonzini <pbonzini@redhat.com>, Eduardo Habkost <ehabkost@redhat.com>,
 Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
 =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= <berrange@redhat.com>,
 "Michael S. Tsirkin" <mst@redhat.com>, Igor Mammedov <imammedo@redhat.com>,
 Ani Sinha <ani@anisinha.ca>, Gerd Hoffmann <kraxel@redhat.com>,
 Eric Auger <eric.auger@redhat.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Anthony Perard <anthony.perard@citrix.com>, Paul Durrant <paul@xen.org>,
 Peter Xu <peterx@redhat.com>, David Hildenbrand <david@redhat.com>,
 "Dr. David Alan Gilbert" <dgilbert@redhat.com>,
 Markus Armbruster <armbru@redhat.com>, Eric Blake <eblake@redhat.com>,
 qemu-riscv@nongnu.org, xen-devel@lists.xenproject.org,
 mark.burton@greensocs.com, mirela.grujic@greensocs.com, edgari@xilinx.com,
 Peter Maydell <peter.maydell@linaro.org>, John Snow <jsnow@redhat.com>,
 Kevin Wolf <kwolf@redhat.com>
References: <20210922161405.140018-1-damien.hedde@greensocs.com>
From: Damien Hedde <damien.hedde@greensocs.com>
In-Reply-To: <20210922161405.140018-1-damien.hedde@greensocs.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

This is both a ping and a small update. It would be great to have some 
feedback about patches 1 and 3.

Right now the device part of this series conflicts with Kevin 's work 
about replacing the QemuOpts by a QemuDict in device_add:
https://lists.gnu.org/archive/html/qemu-devel/2021-09/msg06136.html

So I'll have at least to rebase on top of his series, remove and rework 
some of the patches.

Maybe this series is too big and we should split it anyway ? We could 
for example target 3 smaller series:
  1. -> about stopping during the machine 'initialized' phase
  2. -> about enabling using device_add QMP commands during this phase
  3. -> about the sysbus device case (some of the patches are even 
independent)

Thanks,
Damien

On 9/22/21 18:13, Damien Hedde wrote:
> Hi,
> 
> The goal of this work is to bring dynamic machine creation to QEMU:
> we want to setup a machine without compiling a specific machine C
> code. It would ease supporting highly configurable platforms (for
> example resulting from an automated design flow). The requirements
> for such configuration include begin able to specify the number of
> cores, available peripherals, emmory mapping, IRQ mapping, etc.
> 
> This series focuses on the first step: populating a machine with
> devices during its creation. We propose patches to support this
> using QMP commands. This is a working set of patches and improves
> over the earlier rfc (posted in May):
> https://lists.gnu.org/archive/html/qemu-devel/2021-05/msg03706.html
> 
> Although it is working and could be merged, it is tag as an RFC:
> we probably need to discuss the conditions for allowing a device to
> be created at an early stage. Patches 6, 10 and 13, 15 and 16 depend
> on such conditions and are subject to change. Other patches are
> unrelated to this point.
> 
> We address several issues in this series. They are detailed below.
> 
> ## 1. Stoping QEMU to populate the machine with devices
> 
> QEMU goes through several steps (called _machine phases_) when
> creating the machine: 'no-machine', 'machine-created',
> 'accel-created', 'initialized', and finally 'ready'. At 'ready'
> phase, QEMU is ready to start (see Paolo's page
> https://wiki.qemu.org/User:Paolo_Bonzini/Machine_init_sequence for
> more details).
> 
> Using the -preconfig CLI option, QEMU can be stopped today during
> the 'accel-created' phase. Then the 'x-exit-preconfig' QMP command
> triggers QEMU moving forwards to the completion of the machine
> creation ('ready' phase).
> 
> The devices are created during the 'initialized' phase.
> In this phase the machine init() method has been executed and thus
> machine properties have been handled. Although the sysbus exists and
> the machine may have been populated by the init(),
> _machine_init_done_ notifiers have not been called yet. At this point
> we can add more devices to a machine.
> 
> We propose to add 2 QMP commands:
> + The 'query-machine-phase' command would return the current machine
>    phase.
> + The 'x-machine-init' command would advance the machine phase to
>    'initialized'. 'x-exit-preconfig' could then still be used to
>    advance to the last phase.
> 
> ## 2. Adding devices
> 
> Right now, the user can create devices in 2 ways: using '-device' CLI
> option or 'device_add' QMP command. Both are executed after the
> machine is ready: such devices are hot-plugged. We propose to allow
> 'device_add' QMP command to be used during the 'initialized' phase.
> 
> In this series, we keep the constraint that the device must be
> 'user-creatable' (this is a device class flag). We do not see any
> reason why a device the user can hot-plug could not be created at an
> earlier stage.
> 
> This part is still RFC because, as Peter mentioned it (in this thread
> https://lists.gnu.org/archive/html/qemu-devel/2021-08/msg01933.html),
> we may want additional or distinct conditions for:
> + device we can hot-plug
> + device we can add in '-preconfig' (cold-plug)
> We are open to suggestions. We could for example add a
> 'preconfig-creatable' or 'init-creatable' flag to device class, which
> can identify a set of devices we can create this way.
> 
> The main addition is how we handle the case of sysbus devices. Sysbus
> devices are particular because unlike, for example, pci devices, you
> have to manually handle the memory mapping and interrupts wiring. So
> right now, a sysbus device is dynamically creatable (using -device
> CLI option or device_add QMP command) only if:
> + it is 'user_creatable' (like any other device),
> + and it is in the current machine sysbus device allow list.
> 
> In this series, we propose to relax the second constraint during the
> earlier phases of machine creation so that when using -preconfig we
> can create any 'user-creatable' sysbus device. When the machine
> progresses to the 'ready' phase, sysbus devices creation will come
> back to the legacy behavior: it will be possible only based on the
> per-machine authorization basis.
> 
> For sysbus devices, wiring interrupts is not a problem as we can use
> the 'qom-set' QMP command, but memory mapping is.
> 
> ## 3. Memory mapping
> 
> There is no point allowing the creation sysbus devices if we cannot
> map them onto the memory bus (the 'sysbus').
> 
> As far as we know, right now, there is no way to add memory mapping
> for sysbus device using QMP commands. We propose a 'x-sysbus-mmio-map'
> command to do this. This command would only be allowed during the
> 'initialized' phase when using -preconfig.
> 
> ## 4. Working example
> 
> The last patches of the series add and modify devices in order to
> build a working machine starting from the 'none' machine.
> 
> We add a new sysbus device modeling a simple memory (ram or rom). We
> also set 'user-creatable' flag of some sysbus devices. These are
> trivial patches, but they depends on the conditions we choose to allow
> creating devices with -preconfig. Therefore, there is really no need
> to review them until we settled on the device conditions first.
> 
> With these devices (memory, ibex_uart, ibex_plic) we can dynamically
> configure a part (we did not add the timer, but we could) the
> opentitan machine very easily and run firmwares which demonstrates
> interrupts and memory-mapping are working.
> 
> We use the existing qmp-shell script to issue machine devices
> from a qmp commands script file which contains qmp commands listed in
> a file.
> 
> The following qmp commands add some memories, an interrupt controller
> and an uart with an interrupt.
> 
> cat > opentitan.qmp <<EOF
> x-machine-init
> 
> # ROM 0x00008000
> device_add        driver=sysbus-memory id=rom size=0x4000 readonly=true
> x-sysbus-mmio-map device=rom addr=32768
> 
> # FLASH 0x20000000
> device_add        driver=sysbus-memory id=flash size=0x80000 readonly=true
> x-sysbus-mmio-map device=flash addr=536870912
> 
> # RAM 0x10000000
> device_add        driver=sysbus-memory id=ram size=0x10000
> x-sysbus-mmio-map device=ram addr=268435456
> 
> # PLIC 0x41010000
> device_add        driver=ibex-plic id=plic
> x-sysbus-mmio-map device=plic addr=1090584576
> 
> # UART 0x40000000
> device_add        driver=ibex-uart id=uart chardev=serial0
> x-sysbus-mmio-map device=uart addr=1073741824
> qom-set path=uart property=sysbus-irq[1] value=plic/unnamed-gpio-in[2]
> 
> x-exit-preconfig
> EOF
> 
> We've put the opentitan.qmp and a firmware opentitan-echo.elf here
> (among some other qmp machine files we are working on):
> https://github.com/GreenSocs/qemu-qmp-machines
> This firmware is just a small interrupt-based program echoing back
> whatever is sent in the uart.
> 
> QEMU should be run using the following command:
> qemu-system-riscv32 -preconfig -qmp unix:/tmp/qmp-socket,server \
>      -display none \
>      -M none -cpu lowrisc-ibex \
>      -serial mon:stdio \
>      -device loader,addr=0x8090,cpu-num=0 \
>      -device loader,file=opentitan-hello.elf \
> 
> and in other terminal to do the configuration (grep is just here to
> remove comments):
> grep -v -e '^#' opentitan.qmp | qmp-shell -v /tmp/qmp-socket
> 
> Alternatively we can load the firmware on the existing machine and
> observe the same behavior:
> qemu-system-riscv32 -display none \
>       -M opentitan \
>       -serial mon:stdio \
>       -kernel opentitan-echo.elf
> 
> We chose this example because it is very simple and does not need a
> lot of devices.
> 
> This work has still a lot of limitations. Cpus config is done the
> normal way (the C machine does that): in our example we used the
> 'none' machine. We have work to do for handling backend
> connection (for example net/nic are complicated) because the way it
> is done in machine C code does not translate easily in QMP commands.
> Firmware loading is also a bit tricky. We plan to work on this in
> follow-up series.
> 
> The series is organized as follows:
> - Patches 1 to 3 add qmp support to stop QEMU at an early phase
>    to populate the machine with devices.
> - Patches 4 to 6 prepare and allow issuing device_add during this phase.
> - Patches 7 to 10 prepare and allow creating sysbus device during this phase.
> - Patches 11 and 12 add the x-sysbus-mmio-map QMP command
> - Patch 13 add the memory sysbus device to model ram and rom
> - Patch 14 adds some documentation
> - Patches 15 and 16 set 'user_creatable' flag of ibex_uart and ibex_plic.
> 
> This work is supported by Greensocs, Sifive and Xilinx.
> 
> Thanks,
> --
> Damien
> 
> Damien Hedde (12):
>    softmmu/qdev-monitor: add error handling in qdev_set_id
>    qdev-monitor: prevent conflicts between qmp/device_add and cli/-device
>    hw/core/machine: add machine_class_is_dynamic_sysbus_dev_allowed
>    qdev-monitor: Check sysbus device type before creating it
>    hw/core/machine: Remove the dynamic sysbus devices type check
>    qdev-monitor: allow adding any sysbus device before machine is ready
>    softmmu/memory: add memory_region_try_add_subregion function
>    add x-sysbus-mmio-map qmp command
>    hw/mem/system-memory: add a memory sysbus device
>    docs/system: add doc about the initialized machine phase and an
>      example
>    hw/char/ibex_uart: set user_creatable
>    hw/intc/ibex_plic: set user_creatable
> 
> Mirela Grujic (4):
>    rename MachineInitPhase enum constants for QAPI compatibility
>    qapi: Implement query-machine-phase QMP command
>    qapi: Implement x-machine-init QMP command
>    qapi: Allow device_add to execute in machine initialized phase
> 
>   docs/system/managed-startup.rst | 77 +++++++++++++++++++++++++++++
>   qapi/machine.json               | 79 ++++++++++++++++++++++++++++++
>   qapi/qdev.json                  | 24 ++++++++-
>   include/exec/memory.h           | 22 +++++++++
>   include/hw/boards.h             | 18 ++++++-
>   include/hw/mem/sysbus-memory.h  | 32 ++++++++++++
>   include/hw/qdev-core.h          | 30 +-----------
>   include/monitor/qdev.h          | 25 +++++++++-
>   hw/char/ibex_uart.c             |  1 +
>   hw/core/machine-qmp-cmds.c      | 11 ++++-
>   hw/core/machine.c               | 48 ++++++------------
>   hw/core/qdev.c                  |  7 ++-
>   hw/core/sysbus.c                | 41 ++++++++++++++++
>   hw/intc/ibex_plic.c             |  1 +
>   hw/mem/sysbus-memory.c          | 83 +++++++++++++++++++++++++++++++
>   hw/pci/pci.c                    |  2 +-
>   hw/usb/core.c                   |  2 +-
>   hw/virtio/virtio-iommu.c        |  2 +-
>   hw/xen/xen-legacy-backend.c     |  3 +-
>   monitor/hmp.c                   |  2 +-
>   monitor/misc.c                  |  2 +-
>   softmmu/memory.c                | 22 ++++++---
>   softmmu/qdev-monitor.c          | 86 +++++++++++++++++++++++++++------
>   softmmu/vl.c                    | 23 ++++++---
>   ui/console.c                    |  3 +-
>   hw/mem/meson.build              |  2 +
>   26 files changed, 547 insertions(+), 101 deletions(-)
>   create mode 100644 include/hw/mem/sysbus-memory.h
>   create mode 100644 hw/mem/sysbus-memory.c
> 


From xen-devel-bounces@lists.xenproject.org Mon Oct 04 16:28:54 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Oct 2021 16:28:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.201593.356170 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXQpW-0006ZI-Sl; Mon, 04 Oct 2021 16:28:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 201593.356170; Mon, 04 Oct 2021 16:28:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXQpW-0006ZB-Pm; Mon, 04 Oct 2021 16:28:42 +0000
Received: by outflank-mailman (input) for mailman id 201593;
 Mon, 04 Oct 2021 16:28:41 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenbits.xen.org>) id 1mXQpV-0006Z5-2S
 for xen-devel@lists.xenproject.org; Mon, 04 Oct 2021 16:28:41 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenbits.xen.org>)
 id 1mXQpU-00086j-KH; Mon, 04 Oct 2021 16:28:40 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenbits.xen.org>)
 id 1mXQpU-0003Ah-Ak; Mon, 04 Oct 2021 16:28:40 +0000
Received: from iwj by osstest.test-lab.xenproject.org with local (Exim 4.92)
 (envelope-from <iwj@xenbits.xen.org>)
 id 1mXQpU-0003hw-A4; Mon, 04 Oct 2021 16:28:40 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
To: xen-devel@lists.xenproject.org,jbeulich@suse.com,julien.grall.oss@gmail.com,iwj@xenproject.org,sstabellini@kernel.org,dpsmith@apertussolutions.com
Subject: [adhoc test] 165354: all pass
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Message-Id: <E1mXQpU-0003hw-A4@osstest.test-lab.xenproject.org>
From: iwj@xenbits.xen.org
Date: Mon, 04 Oct 2021 16:28:40 +0000

[adhoc adhoc] <testing.git master /dev/pts/39>
harness 3a3089c9: mfi-common: Drop Linux dom0 i386 tests for newer Lin...
165354: all pass

flight 165354 xen-unstable adhoc [adhoc]
http://logs.test-lab.xenproject.org/osstest/logs/165354/

Perfect :-)
All tests in this flight passed as required

jobs:
 build-arm64-pvops                                            pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary



From xen-devel-bounces@lists.xenproject.org Mon Oct 04 16:36:33 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Oct 2021 16:36:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.201602.356181 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXQwu-0007xp-Kz; Mon, 04 Oct 2021 16:36:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 201602.356181; Mon, 04 Oct 2021 16:36:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXQwu-0007xi-Hn; Mon, 04 Oct 2021 16:36:20 +0000
Received: by outflank-mailman (input) for mailman id 201602;
 Mon, 04 Oct 2021 16:36:18 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mXQws-0007xc-MA
 for xen-devel@lists.xenproject.org; Mon, 04 Oct 2021 16:36:18 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mXQws-0008E2-5x
 for xen-devel@lists.xenproject.org; Mon, 04 Oct 2021 16:36:18 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mXQws-0007Rm-4s
 for xen-devel@lists.xenproject.org; Mon, 04 Oct 2021 16:36:18 +0000
Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89)
 (envelope-from <iwj@xenproject.org>)
 id 1mXQwq-0006JB-Eu; Mon, 04 Oct 2021 17:36:16 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:To:Date:
	Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From;
	bh=J+A+dJc9NQ1vxPcmG92HlCZ1+ykOPq6IrZjabbIK8Ek=; b=S/JzVE8atBDOfHEtJSeAzuRMsw
	6FViQPtSNWvj6K/OYErj4yirbP9XUKEbxwHeImwmA1js5BALfA0ceplX7BEad25tCFhOMVUKnP6fd
	WmxIvp3DSD4lS/3D/lL/nOBKfWZR5gVJtwGQmalz2Rfd7ERe2c81Ta1EB/zTZlBH8WHE=;
From: Ian Jackson <iwj@xenproject.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <24923.11648.199884.55909@mariner.uk.xensource.com>
Date: Mon, 4 Oct 2021 17:36:16 +0100
To: xen-devel@lists.xenproject.org,
    jbeulich@suse.com,
    julien.grall.oss@gmail.com,
    iwj@xenproject.org,
    sstabellini@kernel.org,
    dpsmith@apertussolutions.com
Subject: Re: [adhoc test] 165354: all pass
In-Reply-To: <E1mXQpU-0003hw-A4@osstest.test-lab.xenproject.org>
References: <E1mXQpU-0003hw-A4@osstest.test-lab.xenproject.org>
X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu)

iwj@xenbits.xen.org writes ("[adhoc test] 165354: all pass"):
> [adhoc adhoc] <testing.git master /dev/pts/39>
> harness 3a3089c9: mfi-common: Drop Linux dom0 i386 tests for newer Lin...
> 165354: all pass
> 
> flight 165354 xen-unstable adhoc [adhoc]
> http://logs.test-lab.xenproject.org/osstest/logs/165354/
> 
> Perfect :-)
> All tests in this flight passed as required
> 
> jobs:
>  build-arm64-pvops                                            pass    

I botched the host allocation syntax and I'm having to run this
again...

Ian.


From xen-devel-bounces@lists.xenproject.org Mon Oct 04 17:07:08 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Oct 2021 17:07:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.201609.356192 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXRQf-0002pL-1f; Mon, 04 Oct 2021 17:07:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 201609.356192; Mon, 04 Oct 2021 17:07:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXRQe-0002p9-SQ; Mon, 04 Oct 2021 17:07:04 +0000
Received: by outflank-mailman (input) for mailman id 201609;
 Mon, 04 Oct 2021 17:07:03 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <ijackson@chiark.greenend.org.uk>) id 1mXRQd-0002oW-E5
 for xen-devel@lists.xenproject.org; Mon, 04 Oct 2021 17:07:03 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <ijackson@chiark.greenend.org.uk>) id 1mXRQd-0000L3-CJ
 for xen-devel@lists.xenproject.org; Mon, 04 Oct 2021 17:07:03 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <ijackson@chiark.greenend.org.uk>) id 1mXRQd-0005fz-BG
 for xen-devel@lists.xenproject.org; Mon, 04 Oct 2021 17:07:03 +0000
Received: from [172.18.45.5] (helo=zealot.relativity.greenend.org.uk)
 by mariner.uk.xensource.com with esmtp (Exim 4.89)
 (envelope-from <ijackson@chiark.greenend.org.uk>)
 id 1mXRQb-0006NI-Et; Mon, 04 Oct 2021 18:07:01 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:
	Message-Id:Date:Subject:Cc:To:From;
	bh=/TfkwhZvbisooqp6bNw5GKYK4ugeo2SrDFrIijYr5B4=; b=3a2kCR86Bb9ZMHDHG26OhDV9m0
	1Rjv7/7k9y5rSiaACSPFdacDRsGJvI3ZZkNK46WOhM2h69bAA7kCRAJSQaeBGRCxsRNXs/tlQ015a
	Ozwe3n/PnZDTgOjsJWAEz82g6+IyOsDfBNisGLpN2GPC0qf14PsfRuXcI9Jm2Pe7TDUA=;
From: Ian Jackson <iwj@xenproject.org>
To: xen-devel@lists.xenproject.org
Cc: Ian Jackson <iwj@xenproject.org>
Subject: [OSSTEST PATCH 0/6] allocation / test fixes
Date: Mon,  4 Oct 2021 18:06:48 +0100
Message-Id: <20211004170654.21864-1-iwj@xenproject.org>
X-Mailer: git-send-email 2.20.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

These patches fix problems detected while doing maintenance work.

1 host lifecycle: Use correct taskid column for runvar reconstruction

In principle this might affect any job that picks up a host that was
messed with by a stale task.  It could even cause production flights
to fail.  I think this is a bugfix we want in production.

My Release Manager hat agrees.

2 mg-repro-setup: Promote an error test to before builds (nfc)
3 mg-allocate: Break out sub precheck (nfc)
4 mg-allocate: Add --dry-run mode
5 mg-allocate: feasibility check: print a reassuring message
6 mg-repro-setup: Check allocation feasibility at the start

These are fixes to manual and ad-hoc maintenance commands.  They don't
have any effect on db or host contents.  So they have no release
implications.

Therefore, all six:

Release-acked-by: Ian Jackson <iwj@xenproject.org>

I will push them to pretest shortly.


From xen-devel-bounces@lists.xenproject.org Mon Oct 04 17:07:08 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Oct 2021 17:07:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.201612.356211 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXRQg-00038L-4C; Mon, 04 Oct 2021 17:07:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 201612.356211; Mon, 04 Oct 2021 17:07:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXRQf-000351-Rv; Mon, 04 Oct 2021 17:07:05 +0000
Received: by outflank-mailman (input) for mailman id 201612;
 Mon, 04 Oct 2021 17:07:04 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <ijackson@chiark.greenend.org.uk>) id 1mXRQe-0002oo-3n
 for xen-devel@lists.xenproject.org; Mon, 04 Oct 2021 17:07:04 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <ijackson@chiark.greenend.org.uk>) id 1mXRQe-0000LF-33
 for xen-devel@lists.xenproject.org; Mon, 04 Oct 2021 17:07:04 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <ijackson@chiark.greenend.org.uk>) id 1mXRQe-0005gf-26
 for xen-devel@lists.xenproject.org; Mon, 04 Oct 2021 17:07:04 +0000
Received: from [172.18.45.5] (helo=zealot.relativity.greenend.org.uk)
 by mariner.uk.xensource.com with esmtp (Exim 4.89)
 (envelope-from <ijackson@chiark.greenend.org.uk>)
 id 1mXRQc-0006NI-9c; Mon, 04 Oct 2021 18:07:02 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:
	References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From;
	bh=XYt2DosNXLq9+lZ570jI4CtVdnLCG9pQnFvcIZ+ueg4=; b=TctHtNUxXO6WZdZxl2JaSU4qcZ
	NP1PRUnxPEoYmd7c8KS5Ml5kXT6L+SG8zhTXOpcUKq+FOW3ZXlqPP8KpZZvIX9MSf+3Bna0nxM18B
	kABMUYs2lb7TBINH66HOtBQ0RNCnvcv8mpqfw1/RYvkn1Qf9PMoqZgCsCCYMUpPz5Ty0=;
From: Ian Jackson <iwj@xenproject.org>
To: xen-devel@lists.xenproject.org
Cc: Ian Jackson <iwj@xenproject.org>
Subject: [OSSTEST PATCH 3/6] mg-allocate: Break out sub precheck (nfc)
Date: Mon,  4 Oct 2021 18:06:51 +0100
Message-Id: <20211004170654.21864-4-iwj@xenproject.org>
X-Mailer: git-send-email 2.20.1
In-Reply-To: <20211004170654.21864-1-iwj@xenproject.org>
References: <20211004170654.21864-1-iwj@xenproject.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Signed-off-by: Ian Jackson <iwj@xenproject.org>
---
 mg-allocate | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

diff --git a/mg-allocate b/mg-allocate
index 14c46e0cc..8eca59e2c 100755
--- a/mg-allocate
+++ b/mg-allocate
@@ -647,14 +647,16 @@ if (defined $donate_spec) {
 	if grep { m/^!/ } @ARGV;
 }
 
+sub precheck () {
+    logm("pre-checking resources (dry run)...");
+    local $Osstest::TestSupport::logm_prefix = $logm_prefix.' (precheck)';
+    execute(1);
+}
+
 if ($duration) {
     die "--donate and --steal are incompatible with the planning system\n"
-	if @steal_specs || defined $donate_spec;
-    {
-	logm("pre-checking resources (dry run)...");
-	local $Osstest::TestSupport::logm_prefix = $logm_prefix.' (precheck)';
-	execute(1);
-    };
+        if @steal_specs || defined $donate_spec;
+    precheck();
     plan();
 } else {
     execute();
-- 
2.20.1



From xen-devel-bounces@lists.xenproject.org Mon Oct 04 17:07:08 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Oct 2021 17:07:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.201610.356197 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXRQf-0002rF-A8; Mon, 04 Oct 2021 17:07:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 201610.356197; Mon, 04 Oct 2021 17:07:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXRQf-0002pz-42; Mon, 04 Oct 2021 17:07:05 +0000
Received: by outflank-mailman (input) for mailman id 201610;
 Mon, 04 Oct 2021 17:07:03 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <ijackson@chiark.greenend.org.uk>) id 1mXRQd-0002oc-Oi
 for xen-devel@lists.xenproject.org; Mon, 04 Oct 2021 17:07:03 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <ijackson@chiark.greenend.org.uk>) id 1mXRQd-0000L7-Nr
 for xen-devel@lists.xenproject.org; Mon, 04 Oct 2021 17:07:03 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <ijackson@chiark.greenend.org.uk>) id 1mXRQd-0005gF-N1
 for xen-devel@lists.xenproject.org; Mon, 04 Oct 2021 17:07:03 +0000
Received: from [172.18.45.5] (helo=zealot.relativity.greenend.org.uk)
 by mariner.uk.xensource.com with esmtp (Exim 4.89)
 (envelope-from <ijackson@chiark.greenend.org.uk>)
 id 1mXRQb-0006NI-OK; Mon, 04 Oct 2021 18:07:01 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:
	References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From;
	bh=T94U9z+a5DsOSr2q2nxD2XUprqIrdu2ze8pMDFZ0Qko=; b=jAvAwnXVBx47CSt+3PTpMkmqtL
	j6BV0iSYdG9C1ZvBrkUwayBetQe01BY+DvkcmRjBfm3ZjGEztYrKI0UfOyntQDzCjNekww1M6DJv4
	zm7VvGRnrDJ+FznpPNKMXFh/ICqruK5GXmn++RrS2/yDP0CCr2dXkldE82kaK/oPh7zQ=;
From: Ian Jackson <iwj@xenproject.org>
To: xen-devel@lists.xenproject.org
Cc: Ian Jackson <iwj@xenproject.org>
Subject: [OSSTEST PATCH 1/6] host lifecycle: Use correct taskid column for runvar reconstruction
Date: Mon,  4 Oct 2021 18:06:49 +0100
Message-Id: <20211004170654.21864-2-iwj@xenproject.org>
X-Mailer: git-send-email 2.20.1
In-Reply-To: <20211004170654.21864-1-iwj@xenproject.org>
References: <20211004170654.21864-1-iwj@xenproject.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

t.taskid might be NULL since the task may have been deleted.

Signed-off-by: Ian Jackson <iwj@xenproject.org>
---
 Osstest/JobDB/Executive.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Osstest/JobDB/Executive.pm b/Osstest/JobDB/Executive.pm
index 097c8d75b..c5db2691b 100644
--- a/Osstest/JobDB/Executive.pm
+++ b/Osstest/JobDB/Executive.pm
@@ -542,7 +542,7 @@ END
 
     my $scanq = $dbh_tests->prepare(<<END);
 	   SELECT h.flight, h.job, h.isprep, h.ident, h.stepno,
-                  t.live, t.taskid,
+                  t.live, h.taskid,
                   h2.lcseq later_notprep
 	     FROM host_lifecycle h
         LEFT JOIN host_lifecycle h2
-- 
2.20.1



From xen-devel-bounces@lists.xenproject.org Mon Oct 04 17:07:08 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Oct 2021 17:07:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.201614.356226 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXRQg-0003Nq-Vu; Mon, 04 Oct 2021 17:07:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 201614.356226; Mon, 04 Oct 2021 17:07:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXRQg-0003Kr-Is; Mon, 04 Oct 2021 17:07:06 +0000
Received: by outflank-mailman (input) for mailman id 201614;
 Mon, 04 Oct 2021 17:07:04 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <ijackson@chiark.greenend.org.uk>) id 1mXRQe-0002p3-KQ
 for xen-devel@lists.xenproject.org; Mon, 04 Oct 2021 17:07:04 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <ijackson@chiark.greenend.org.uk>) id 1mXRQe-0000LN-Jg
 for xen-devel@lists.xenproject.org; Mon, 04 Oct 2021 17:07:04 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <ijackson@chiark.greenend.org.uk>) id 1mXRQe-0005hE-In
 for xen-devel@lists.xenproject.org; Mon, 04 Oct 2021 17:07:04 +0000
Received: from [172.18.45.5] (helo=zealot.relativity.greenend.org.uk)
 by mariner.uk.xensource.com with esmtp (Exim 4.89)
 (envelope-from <ijackson@chiark.greenend.org.uk>)
 id 1mXRQc-0006NI-Qb; Mon, 04 Oct 2021 18:07:02 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:
	References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From;
	bh=yisPODdEzgt40Em95XrW2+0eACmf9EcBBEEdifxOE30=; b=t5ghfjmx3xpFGn91XyM5vqzvsy
	TIlRpUR8rv7E5oUhwmZpT0P2e+aG+uCm26EIRvcK47+QyQ9oC4V/eir3OBuYfZ9tai1wZ/IB15p/a
	MeWJWW8o3xClOXiwCxJP0jlGm6T1BRRaPLr8qg8Q8Wc1CdLzvUqKr9TK0uTaos5okb5s=;
From: Ian Jackson <iwj@xenproject.org>
To: xen-devel@lists.xenproject.org
Cc: Ian Jackson <iwj@xenproject.org>
Subject: [OSSTEST PATCH 5/6] mg-allocate: feasibility check: print a reassuring message
Date: Mon,  4 Oct 2021 18:06:53 +0100
Message-Id: <20211004170654.21864-6-iwj@xenproject.org>
X-Mailer: git-send-email 2.20.1
In-Reply-To: <20211004170654.21864-1-iwj@xenproject.org>
References: <20211004170654.21864-1-iwj@xenproject.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Signed-off-by: Ian Jackson <iwj@xenproject.org>
---
 mg-allocate | 1 +
 1 file changed, 1 insertion(+)

diff --git a/mg-allocate b/mg-allocate
index 7dc2c7650..e700be185 100755
--- a/mg-allocate
+++ b/mg-allocate
@@ -393,6 +393,7 @@ sub execute (;$) {
 
 	if ($dryrun) {
 	    db_retry_abort();
+	    logm("allocation feasible in principle (subject to planning)");
 	    return;
 	}
         if (!$allok) {
-- 
2.20.1



From xen-devel-bounces@lists.xenproject.org Mon Oct 04 17:07:08 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Oct 2021 17:07:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.201611.356202 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXRQf-0002vI-Im; Mon, 04 Oct 2021 17:07:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 201611.356202; Mon, 04 Oct 2021 17:07:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXRQf-0002tI-CG; Mon, 04 Oct 2021 17:07:05 +0000
Received: by outflank-mailman (input) for mailman id 201611;
 Mon, 04 Oct 2021 17:07:03 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <ijackson@chiark.greenend.org.uk>) id 1mXRQd-0002oh-RD
 for xen-devel@lists.xenproject.org; Mon, 04 Oct 2021 17:07:03 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <ijackson@chiark.greenend.org.uk>) id 1mXRQd-0000LB-QO
 for xen-devel@lists.xenproject.org; Mon, 04 Oct 2021 17:07:03 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <ijackson@chiark.greenend.org.uk>) id 1mXRQd-0005gN-PZ
 for xen-devel@lists.xenproject.org; Mon, 04 Oct 2021 17:07:03 +0000
Received: from [172.18.45.5] (helo=zealot.relativity.greenend.org.uk)
 by mariner.uk.xensource.com with esmtp (Exim 4.89)
 (envelope-from <ijackson@chiark.greenend.org.uk>)
 id 1mXRQc-0006NI-1i; Mon, 04 Oct 2021 18:07:02 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:
	References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From;
	bh=CZXTOm6EiFeioottqvohyfKjfSXSIATOkpOGe8mezEE=; b=bRVCG2xceg36dY5Ziea5BA1UwM
	u8N3hPp7ABP2aVmijg+wFH0CUv/sVafcOAyIoIkwI2BhUjOO+em/1jOEk3/a0XU+IJnVzHO1ZkiXI
	GMDeXQFB/qK+2IMUdSLAYVVhpPsB0drP5t/xZvvVMVHGnnP7GDyoRTOUeTazpbOVHiG8=;
From: Ian Jackson <iwj@xenproject.org>
To: xen-devel@lists.xenproject.org
Cc: Ian Jackson <iwj@xenproject.org>
Subject: [OSSTEST PATCH 2/6] mg-repro-setup: Promote an error test to before builds (nfc)
Date: Mon,  4 Oct 2021 18:06:50 +0100
Message-Id: <20211004170654.21864-3-iwj@xenproject.org>
X-Mailer: git-send-email 2.20.1
In-Reply-To: <20211004170654.21864-1-iwj@xenproject.org>
References: <20211004170654.21864-1-iwj@xenproject.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Signed-off-by: Ian Jackson <iwj@xenproject.org>
---
 mg-repro-setup | 16 +++++++++-------
 1 file changed, 9 insertions(+), 7 deletions(-)

diff --git a/mg-repro-setup b/mg-repro-setup
index 374176f03..56d27d4ef 100755
--- a/mg-repro-setup
+++ b/mg-repro-setup
@@ -253,6 +253,15 @@ while [ $# -ne 0 ]; do
 	esac
 done
 
+if [ "${alloc_idents[*]}" ]; then
+        if [ x"$OSSTEST_TASK" = x ]; then
+                # We would have to make a dynamic task and hold the
+                #  fd for it in this script.  Would be quite awkward.
+                echo >&2 'cannot hand-allocate in a way that will free'
+                exit 1
+        fi
+fi
+
 flight=$(./cs-adjust-flight new:$blessing)
 progress "new flight is $flight"
 
@@ -281,13 +290,6 @@ if $statictask; then
 fi
 
 if [ "${alloc_idents[*]}" ]; then
-        if [ x"$OSSTEST_TASK" = x ]; then
-                # We would have to make a dynamic task and hold the
-                #  fd for it in this script.  Would be quite awkward.
-                echo >&2 'cannot hand-allocate in a way that will free'
-                exit 1
-        fi
-
 	progress "allocating ${alloc_idents[*]} ..."
 	alloc_output=tmp/$flight.allocations
 	./mg-allocate \
-- 
2.20.1



From xen-devel-bounces@lists.xenproject.org Mon Oct 04 17:07:09 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Oct 2021 17:07:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.201613.356221 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXRQg-0003Gl-KS; Mon, 04 Oct 2021 17:07:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 201613.356221; Mon, 04 Oct 2021 17:07:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXRQg-0003F4-7C; Mon, 04 Oct 2021 17:07:06 +0000
Received: by outflank-mailman (input) for mailman id 201613;
 Mon, 04 Oct 2021 17:07:04 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <ijackson@chiark.greenend.org.uk>) id 1mXRQe-0002ou-Bk
 for xen-devel@lists.xenproject.org; Mon, 04 Oct 2021 17:07:04 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <ijackson@chiark.greenend.org.uk>) id 1mXRQe-0000LJ-B0
 for xen-devel@lists.xenproject.org; Mon, 04 Oct 2021 17:07:04 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <ijackson@chiark.greenend.org.uk>) id 1mXRQe-0005gu-9K
 for xen-devel@lists.xenproject.org; Mon, 04 Oct 2021 17:07:04 +0000
Received: from [172.18.45.5] (helo=zealot.relativity.greenend.org.uk)
 by mariner.uk.xensource.com with esmtp (Exim 4.89)
 (envelope-from <ijackson@chiark.greenend.org.uk>)
 id 1mXRQc-0006NI-Im; Mon, 04 Oct 2021 18:07:02 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:
	References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From;
	bh=geBFP+eayjby41kJSRPRW6i6OwZW9KlE+w5lSJk+b68=; b=twBiiETLQhqLhZ4ZUz/WVoojVP
	H1BM9XhLmhZEVRjSvzqXgJGEHEwEry12d5bAQybZcEsMXNNaHqDI+DQFcZCRlc+u/6kNEwnJPmj7g
	OtAlMKN7/Z3AokUs2GCoHEmZCVEQskJ6tIZDYajHmVi+5k2qZQk6Ws4iICMqR4cya8gw=;
From: Ian Jackson <iwj@xenproject.org>
To: xen-devel@lists.xenproject.org
Cc: Ian Jackson <iwj@xenproject.org>
Subject: [OSSTEST PATCH 4/6] mg-allocate: Add --dry-run mode
Date: Mon,  4 Oct 2021 18:06:52 +0100
Message-Id: <20211004170654.21864-5-iwj@xenproject.org>
X-Mailer: git-send-email 2.20.1
In-Reply-To: <20211004170654.21864-1-iwj@xenproject.org>
References: <20211004170654.21864-1-iwj@xenproject.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Signed-off-by: Ian Jackson <iwj@xenproject.org>
---
 mg-allocate | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/mg-allocate b/mg-allocate
index 8eca59e2c..7dc2c7650 100755
--- a/mg-allocate
+++ b/mg-allocate
@@ -26,6 +26,8 @@
 #   -U             allocate with high priority (makes sense with
 #                  specified duration only)
 #
+#   --dry-run      Do not actually allocate, just check feasibility.
+#
 #   --as <task-spec>
 #                  Run as the task <task-spec> (rather than looking
 #                  at OSSTEST_TASK).  Allocation will allocate
@@ -93,6 +95,7 @@ $|=1;
 
 our $tid;
 our %magictask;
+our $dry_run;
 our $list_only;
 our $donate_spec;
 our $donate_taskid;
@@ -536,6 +539,8 @@ while (@ARGV && $ARGV[0] =~ m/^[-0-9]/) {
         } elsif (s/^\-l/-/ || s/^--list$/--/) {
 	    $list_only++;
 	    die "-l may be repeated only thrice\n" if $list_only > 3;
+        } elsif (s/^--dry-run$/-/) {
+	    $dry_run= 1;
         } elsif (s/^--as$/-/) {
 	    die "--as needs task\n" unless @ARGV;
 	    $ENV{OSSTEST_TASK} = shift @ARGV;
@@ -653,7 +658,9 @@ sub precheck () {
     execute(1);
 }
 
-if ($duration) {
+if ($dry_run) {
+    precheck();
+} elsif ($duration) {
     die "--donate and --steal are incompatible with the planning system\n"
         if @steal_specs || defined $donate_spec;
     precheck();
-- 
2.20.1



From xen-devel-bounces@lists.xenproject.org Mon Oct 04 17:07:08 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Oct 2021 17:07:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.201615.356235 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXRQh-0003YG-Eb; Mon, 04 Oct 2021 17:07:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 201615.356235; Mon, 04 Oct 2021 17:07:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXRQh-0003U8-0N; Mon, 04 Oct 2021 17:07:07 +0000
Received: by outflank-mailman (input) for mailman id 201615;
 Mon, 04 Oct 2021 17:07:04 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <ijackson@chiark.greenend.org.uk>) id 1mXRQe-0002pF-Sp
 for xen-devel@lists.xenproject.org; Mon, 04 Oct 2021 17:07:04 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <ijackson@chiark.greenend.org.uk>) id 1mXRQe-0000LS-SC
 for xen-devel@lists.xenproject.org; Mon, 04 Oct 2021 17:07:04 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <ijackson@chiark.greenend.org.uk>) id 1mXRQe-0005hQ-R8
 for xen-devel@lists.xenproject.org; Mon, 04 Oct 2021 17:07:04 +0000
Received: from [172.18.45.5] (helo=zealot.relativity.greenend.org.uk)
 by mariner.uk.xensource.com with esmtp (Exim 4.89)
 (envelope-from <ijackson@chiark.greenend.org.uk>)
 id 1mXRQd-0006NI-3c; Mon, 04 Oct 2021 18:07:03 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:
	References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From;
	bh=X7uAEedSKghPplBPVQkmGaLlxU/DlARIutYlzLjpc7A=; b=3RKal3uEH1ebhXOTeOIlrQyvXn
	L+qTj0n+65x4yJuO4sG15tg3VYJ5TL4PgclpAwZ2Kav7yBaIzgty+Ul53/BJPh/xoed4Uc8WIRyds
	VQ7nw4tL7tyGJxYDdowIMCrOnMmN5uuO5sTKRzM+kcgQkQ2PjWIXJmZ2LaAT00vjeMCM=;
From: Ian Jackson <iwj@xenproject.org>
To: xen-devel@lists.xenproject.org
Cc: Ian Jackson <iwj@xenproject.org>
Subject: [OSSTEST PATCH 6/6] mg-repro-setup: Check allocation feasibility at the start
Date: Mon,  4 Oct 2021 18:06:54 +0100
Message-Id: <20211004170654.21864-7-iwj@xenproject.org>
X-Mailer: git-send-email 2.20.1
In-Reply-To: <20211004170654.21864-1-iwj@xenproject.org>
References: <20211004170654.21864-1-iwj@xenproject.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Signed-off-by: Ian Jackson <iwj@xenproject.org>
---
 mg-repro-setup | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/mg-repro-setup b/mg-repro-setup
index 56d27d4ef..895f29963 100755
--- a/mg-repro-setup
+++ b/mg-repro-setup
@@ -260,6 +260,17 @@ if [ "${alloc_idents[*]}" ]; then
                 echo >&2 'cannot hand-allocate in a way that will free'
                 exit 1
         fi
+
+	set +e
+	alloc_output=$(
+		./mg-allocate --dry-run $duration "${alloc_specs[@]}" 2>&1
+	)
+	alloc_rc=$?
+	set -e
+	test $alloc_rc = 0 ||
+	fail "requested allocation(s) infeasible:
+$alloc_output
+"
 fi
 
 flight=$(./cs-adjust-flight new:$blessing)
-- 
2.20.1



From xen-devel-bounces@lists.xenproject.org Mon Oct 04 17:39:07 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Oct 2021 17:39:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.201660.356269 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXRvL-0001P1-Vi; Mon, 04 Oct 2021 17:38:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 201660.356269; Mon, 04 Oct 2021 17:38:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXRvL-0001Ou-Sj; Mon, 04 Oct 2021 17:38:47 +0000
Received: by outflank-mailman (input) for mailman id 201660;
 Mon, 04 Oct 2021 17:38:46 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mXRvK-0001Ok-QA; Mon, 04 Oct 2021 17:38:46 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mXRvK-0000uQ-F9; Mon, 04 Oct 2021 17:38:46 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mXRvK-0005SJ-5g; Mon, 04 Oct 2021 17:38:46 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mXRvK-0001aX-5K; Mon, 04 Oct 2021 17:38:46 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=TW9hGdTHe7YCFWb0c/iQQLygw2decUpwkxiJOZ2omJU=; b=4EKu/96zwcxd6H80cLvhRlgRlZ
	EjrVbp7pqJu1Yj0TPSymZX2rYWpNhLXwi7JHgJVhpoAhLVRaSyk+3XACzx23zwlU/xBxY0r4Myzhz
	8b6UnnD2bA0bobcLfyn4z1EMCyXVv8YxWFu4vZnXBWfUEDL/RU1MbOZ9cgMqZaQ9JwWY=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165350-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 165350: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=b6fe410936e30b2089cc8c6d54d786e535efafa3
X-Osstest-Versions-That:
    xen=ab4a83023eda9f04ad864877c1956b087ec6fc4f
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 04 Oct 2021 17:38:46 +0000

flight 165350 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165350/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  b6fe410936e30b2089cc8c6d54d786e535efafa3
baseline version:
 xen                  ab4a83023eda9f04ad864877c1956b087ec6fc4f

Last test of basis   165317  2021-09-29 20:22:11 Z    4 days
Testing same since   165350  2021-10-04 13:00:25 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Anthony PERARD <anthony.perard@citrix.com>
  Anthony PERARD <anthony.perard@gmail.com>
  Jan Beulich <jbeulich@suse.com>
  Juergen Gross <jgross@suse.com>
  Luca Fancellu <luca.fancellu@arm.com>
  Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
  Rahul Singh <rahul.singh@arm.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   ab4a83023e..b6fe410936  b6fe410936e30b2089cc8c6d54d786e535efafa3 -> smoke


From xen-devel-bounces@lists.xenproject.org Mon Oct 04 18:09:40 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Oct 2021 18:09:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.201669.356283 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXSP8-0004kt-F2; Mon, 04 Oct 2021 18:09:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 201669.356283; Mon, 04 Oct 2021 18:09:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXSP8-0004km-Aa; Mon, 04 Oct 2021 18:09:34 +0000
Received: by outflank-mailman (input) for mailman id 201669;
 Mon, 04 Oct 2021 18:09:33 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenbits.xen.org>) id 1mXSP7-0004kg-54
 for xen-devel@lists.xenproject.org; Mon, 04 Oct 2021 18:09:33 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenbits.xen.org>)
 id 1mXSP6-0001Vy-Ne; Mon, 04 Oct 2021 18:09:32 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenbits.xen.org>)
 id 1mXSP6-0006iN-DH; Mon, 04 Oct 2021 18:09:32 +0000
Received: from iwj by osstest.test-lab.xenproject.org with local (Exim 4.92)
 (envelope-from <iwj@xenbits.xen.org>)
 id 1mXSP6-00088y-Cp; Mon, 04 Oct 2021 18:09:32 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
To: xen-devel@lists.xenproject.org,jbeulich@suse.com,julien.grall.oss@gmail.com,iwj@xenproject.org,sstabellini@kernel.org,dpsmith@apertussolutions.com
Subject: [adhoc test] 165358: all pass
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Message-Id: <E1mXSP6-00088y-Cp@osstest.test-lab.xenproject.org>
From: iwj@xenbits.xen.org
Date: Mon, 04 Oct 2021 18:09:32 +0000

[adhoc adhoc] <testing.git master /dev/pts/39>
harness 3a3089c9: mfi-common: Drop Linux dom0 i386 tests for newer Lin...
165358: all pass

flight 165358 xen-unstable adhoc [adhoc]
http://logs.test-lab.xenproject.org/osstest/logs/165358/

Perfect :-)
All tests in this flight passed as required

jobs:
 build-arm64-pvops                                            pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary



From xen-devel-bounces@lists.xenproject.org Mon Oct 04 18:36:33 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Oct 2021 18:36:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.201678.356294 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXSp8-0007vL-J1; Mon, 04 Oct 2021 18:36:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 201678.356294; Mon, 04 Oct 2021 18:36:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXSp8-0007vE-G0; Mon, 04 Oct 2021 18:36:26 +0000
Received: by outflank-mailman (input) for mailman id 201678;
 Mon, 04 Oct 2021 18:36:25 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mXSp7-0007v8-BR
 for xen-devel@lists.xenproject.org; Mon, 04 Oct 2021 18:36:25 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mXSp7-0001wC-A6
 for xen-devel@lists.xenproject.org; Mon, 04 Oct 2021 18:36:25 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mXSp7-00037k-8x
 for xen-devel@lists.xenproject.org; Mon, 04 Oct 2021 18:36:25 +0000
Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89)
 (envelope-from <iwj@xenproject.org>)
 id 1mXSp5-0006a5-HS; Mon, 04 Oct 2021 19:36:23 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:To:Date:
	Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From;
	bh=hqGfY5gddIbntlXghcUwsteOJh9EezHbcrrPmodZmgs=; b=VvLQvLPHMQxBf4sRMxssnPZURY
	YR15bjDZ15PW6uT8KqIYLDxCJusvProhpj4+H7wffIYEsh0iUhomBoKsLTxchpp6bnrckuuBm0zkJ
	AUuCFRU7dcXBeJYG3Bfr0O2a90r0XrOBK8LdICtw2+PE5ZNVi+PgOyK3AJ23j3es4WXY=;
From: Ian Jackson <iwj@xenproject.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <24923.18855.156848.559332@mariner.uk.xensource.com>
Date: Mon, 4 Oct 2021 19:36:23 +0100
To: xen-devel@lists.xenproject.org,
    committers@xenproject.org
Subject: Re: osstest down, PDU failure
In-Reply-To: <24922.61930.715312.781769@mariner.uk.xensource.com>
References: <24916.14069.358118.417330@mariner.uk.xensource.com>
	<24916.53633.593814.456485@mariner.uk.xensource.com>
	<24917.61577.291999.406078@mariner.uk.xensource.com>
	<24922.61930.715312.781769@mariner.uk.xensource.com>
X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu)

Ian Jackson writes ("Re: osstest down, PDU failure"):
> We replaced two PDUs and did a number of other on-site repairs etc.
> 
> Service is in the process of being restored.  I hope to be fully
> operational by the end of the day.

Everything seems to be good.  All the machines that were in service
before the PDU incident are once more operational.

Some other machines were repaired and will be put into service after
commissioning tests.

Some new machines were wired up and will be undergoing testing.  If
and when they seem in good shape I will ask my Release Manager hat :-)
whether we want to put them into service.

Ian.


From xen-devel-bounces@lists.xenproject.org Mon Oct 04 19:17:02 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Oct 2021 19:17:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.201690.356305 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXTS7-0003fT-Fp; Mon, 04 Oct 2021 19:16:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 201690.356305; Mon, 04 Oct 2021 19:16:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXTS7-0003fM-CH; Mon, 04 Oct 2021 19:16:43 +0000
Received: by outflank-mailman (input) for mailman id 201690;
 Mon, 04 Oct 2021 19:16:42 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenbits.xen.org>) id 1mXTS6-0003fG-1N
 for xen-devel@lists.xenproject.org; Mon, 04 Oct 2021 19:16:42 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenbits.xen.org>)
 id 1mXTS5-0002c1-Ki; Mon, 04 Oct 2021 19:16:41 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenbits.xen.org>)
 id 1mXTS5-0001Ss-A1; Mon, 04 Oct 2021 19:16:41 +0000
Received: from iwj by osstest.test-lab.xenproject.org with local (Exim 4.92)
 (envelope-from <iwj@xenbits.xen.org>)
 id 1mXTS5-00046z-9X; Mon, 04 Oct 2021 19:16:41 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
To: xen-devel@lists.xenproject.org,jbeulich@suse.com,julien.grall.oss@gmail.com,iwj@xenproject.org,sstabellini@kernel.org,dpsmith@apertussolutions.com
Subject: [adhoc test] 165359: tolerable truncated
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Message-Id: <E1mXTS5-00046z-9X@osstest.test-lab.xenproject.org>
From: iwj@xenbits.xen.org
Date: Mon, 04 Oct 2021 19:16:41 +0000

[adhoc play] <testing.git master not a tty>
harness 3a3089c9: mfi-common: Drop Linux dom0 i386 tests for newer Lin...
165359: tolerable truncated

flight 165359 xen-unstable play [play]
http://logs.test-lab.xenproject.org/osstest/logs/165359/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail  like 165218
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail  like 165218

baseline version:
 flight               165218

jobs:
 test-arm64-arm64-libvirt-raw                                 truncated


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary



From xen-devel-bounces@lists.xenproject.org Mon Oct 04 21:12:04 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Oct 2021 21:12:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.201723.356333 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXVFS-0007J1-6N; Mon, 04 Oct 2021 21:11:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 201723.356333; Mon, 04 Oct 2021 21:11:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXVFS-0007Iu-34; Mon, 04 Oct 2021 21:11:46 +0000
Received: by outflank-mailman (input) for mailman id 201723;
 Mon, 04 Oct 2021 21:11:44 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Ik8X=OY=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1mXVFQ-0007Io-LK
 for xen-devel@lists.xenproject.org; Mon, 04 Oct 2021 21:11:44 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id ac1c8039-2557-11ec-bebd-12813bfff9fa;
 Mon, 04 Oct 2021 21:11:42 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id 525D0610C7;
 Mon,  4 Oct 2021 21:11:41 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ac1c8039-2557-11ec-bebd-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1633381901;
	bh=QOCsCFQ+z1LjbasUQQYJvIPHsL/KVRjx9nntde4xsGs=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=txPcqJN5rqxL7DIs5n66KlwbDTmHGg6vDKrpE7IhD6kiWUOBdRS6spoft24xt2Kc6
	 LtYcyscS4m6H22n1iO2HCNtq0MOO9Ff1fBdUK70VHGbOr/BVzjpFprkmuelFl//O8q
	 jw/3/6hdu08QAmapojDM7csxEdXj7kafXC2FeNqFI+jW8BzDXwJh5iilHEP243LbE3
	 cBWswj/Qc+4oxOO9Lk/RIHsslBc/hFgor8kbHFPB5iiWNTKqoFtyCKCNr92Xb0+VZa
	 V/7Gp7p4rle05aCiX7F8waqy3b9NWmVmEtC32Y6BTSKAnN/OEWc3mukf8nFuLlxM+m
	 qHAeafWX4DuEQ==
Date: Mon, 4 Oct 2021 14:11:39 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Oleksandr <olekstysh@gmail.com>
cc: Julien Grall <julien.grall.oss@gmail.com>, 
    Stefano Stabellini <sstabellini@kernel.org>, 
    Jan Beulich <jbeulich@suse.com>, 
    xen-devel <xen-devel@lists.xenproject.org>, 
    Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, 
    Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>, 
    Anthony PERARD <anthony.perard@citrix.com>, 
    Andrew Cooper <andrew.cooper3@citrix.com>, 
    George Dunlap <george.dunlap@citrix.com>, Juergen Gross <jgross@suse.com>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, 
    =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= <roger.pau@citrix.com>, 
    Bertrand Marquis <Bertrand.Marquis@arm.com>
Subject: Re: [PATCH V4 1/3] xen: Introduce "gpaddr_bits" field to
 XEN_SYSCTL_physinfo
In-Reply-To: <093bc1d5-bf6a-da0a-78b5-7a8dd471a063@gmail.com>
Message-ID: <alpine.DEB.2.21.2110041411100.3209@sstabellini-ThinkPad-T480s>
References: <1632955927-27911-1-git-send-email-olekstysh@gmail.com> <1632955927-27911-2-git-send-email-olekstysh@gmail.com> <alpine.DEB.2.21.2109301600060.3209@sstabellini-ThinkPad-T480s> <05b040b0-a069-47a1-1f5e-85be62fa35f3@suse.com>
 <bbbceae1-c382-5e48-0c6b-fbb23fc720f5@gmail.com> <alpine.DEB.2.21.2110011244000.3209@sstabellini-ThinkPad-T480s> <CAJ=z9a2bT4tMn2argJzePUMR2Ke4bmabj+j5QevvwpfnA9ST_w@mail.gmail.com> <093bc1d5-bf6a-da0a-78b5-7a8dd471a063@gmail.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="8323329-254547066-1633381901=:3209"

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-254547066-1633381901=:3209
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT

On Sat, 2 Oct 2021, Oleksandr wrote:
> On 02.10.21 10:35, Julien Grall wrote:
> 
> Thank you for your comments!
> 
>       Hi
> 
>       On Sat, 2 Oct 2021, 01:24 Stefano Stabellini, <sstabellini@kernel.org> wrote:
>       Bertrand, see comment on ID_AA64MMFR0_EL1 below, any ideas?
> 
> 
>       On Fri, 1 Oct 2021, Oleksandr wrote:
>       > On 01.10.21 10:50, Jan Beulich wrote:
>       > > On 01.10.2021 01:00, Stefano Stabellini wrote:
>       > > > On Thu, 30 Sep 2021, Oleksandr Tyshchenko wrote:
>       > > > > From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>       > > > >
>       > > > > We need to pass info about maximum supported guest address
>       > > > > space size to the toolstack on Arm in order to properly
>       > > > > calculate the base and size of the extended region (safe range)
>       > > > > for the guest. The extended region is unused address space which
>       > > > > could be safely used by domain for foreign/grant mappings on Arm.
>       > > > > The extended region itself will be handled by the subsequents
>       > > > > patch.
>       > > > >
>       > > > > Use p2m_ipa_bits variable on Arm, the x86 equivalent is
>       > > > > hap_paddr_bits.
>       > > > >
>       > > > > As we change the size of structure bump the interface version.
>       > > > >
>       > > > > Suggested-by: Julien Grall <jgrall@amazon.com>
>       > > > > Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>       > > > > Reviewed-by: Michal Orzel <michal.orzel@arm.com>
>       > > > Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
>       > > I have to admit that I'm a little puzzled to see these R-b-s when ...
>       > >
>       > > > > Please note, that review comments for the RFC version [1] haven't been
>       > > > > addressed yet.
>       > > > > It is not forgotten, some clarification is needed. It will be addressed
>       > > > > for the next version.
>       > > > >
>       > > > > [1]
>       > > > > https://lore.kernel.org/xen-devel/973f5344-aa10-3ad6-ff02-ad5f358ad279@citrix.com/
>       > > ... Oleksandr makes clear this patch isn't really ready yet.
>       >
>       > Unfortunately, this is true. I am still waiting for the clarification [1]
> 
>       Although I was aware of comments to older versions, this is actually the
>       first version of this patch that I reviewed with any level of details; I
>       didn't read previous comments very closely. I tried to find any bugs or
>       problems with it and I couldn't see any, so I gave my reviewed-by. I
>       should have clarified that was meant for the ARM part as I don't have a
>       full understanding of the implications of using hap_paddr_bits on x86
>       for VM migration.
> 
> 
> 
>       But let me take this opportunity to say that although I think the
>       hypercall is OK, I wish we didn't need this patch at all: it is
>       problematic because it touches tools, x86 and ARM hypervisor code all
>       together. It needs at least three acks/reviewed-by to get accepted: from
>       an x86 maintainer, an arm maintainer and from a tools maintainer. I
>       don't say this to criticize the patch acceptance process: this patch
>       makes changes to an existing hypercall so it is only fair that it needs
>       to go through extra levels of scrutiny. For the sake of simplicity and
>       decoupling (reducing dependencies between patches and between
>       components), I think it would be best to introduce an #define for the
>       minimum value of gpaddr_bits and then move this patch at the end of the
>       series; that way it becomes optional.
> 
> 
> It depends what you mean by optional. Yes we can add hack to avoid the hypercall... But the more scalable solution is the hypercall.
> 
> I am slightly concerned that if we don't push for the hypercall now, then there will be no incentive to do it afterwards...
> 
> So I went through Andrew's e-mail to understand what's the request. I understand that there are some problem with migration. But it
> doesn't look like we need to solve them now. Instead,  AFAICT, his main ask for this series is to switch to a domctl.
> 
> It seems the conversation is simply stuck on waiting for Andrew to provide details on what would look like. Did we ping Andrew on
> IRC?
> 
>       Unfortunately the minimum value
>       is 32 (in practice I have never seen less than 40 but the architecture
>       supports 32 as minimum).
> 
> 
> 
>       Actually, the info we are looking for is already exposed via
>       ID_AA64MMFR0_EL1. ID_AA64MMFR0_EL1 can be read from a virtual machine,
>       and Linux let userspace read it [1]. Regardless of this patch series, we
>       should make sure that Xen exposes the right mm64.pa_range value to guest
>       virtual machines. If that is done right, then you can just add support
>       for reading ID_AA64MMFR0_EL1 in libxl/libxc and then we don't need any
>       hypercall modifications changes.
> 
> 
> From my understanding, from a VM PoV "pa_range" should represent the size of the guest physical address space.
> 
> Today, it happens that every VM is using the same P2M size. However, I would rather not make such assumption in the userspace.
> 
> 
>       So, in theory we already have all the interfaces we need, but in
>       practice they don't work: unfortunaly both Xen and Linux mark
>       ID_AA64MMFR0_EL1 as FTR_HIDDEN in cpufeature.c so neither Linux from
>       Xen, not userspace from Linux can actually read the real value :-/
>       They always read zero.
> 
>       (Also I think we have an issue today with p2m_restrict_ipa_bits not
>       updating the mm64.pa_range value. I think that it should be fixed.)
> 
> 
> It looks like it. That should be handled in a separate patch though.
> 
> 
>       Bertrand, do you have any ideas in regards to ID_AA64MMFR0_EL1?
> 
>       If not, maybe we could just go with
>       #define MIN_GPADDR_BITS 32.
> 
> 
> The toolstack would have to consider it as the "maximum" because it may not be safe to expose anything above.
> 
> With 32, we are going to be limited in term of space we can find.
> 
> We could potentially use 40 bits as a minimum. Although it still feels a bit of a hack to me given that the IOMMU may restrict it
> further and the architecture can in theory support less.
> 
> Overall, I still strongly prefer the hypercall approach. If a common one is difficult to achieve, then we can extend the domctl to
> create a domain to provide the p2m_bits (in the same way as we deal for the GIC version) in an arch specific way.
> 
> 
> To summarize:
> If we don't query the hypervisor to provide gpaddr_bits we have two options:
> - The safe option is to use minimum possible value which is 32 bits on Arm64. But, there would be of no practical use.
> - The unsafe option is to use let's say "default" 40 bits and pray it will work in all cases on Arm64 (it is ok on Arm32).
> 
> So we definitely need to query the hypervisor. As it turned out the sysctl approach is not welcome, in the long term we want to have this
> information per domain. I have been absolutely OK with that valid ask since RFC, I just wanted to know what was the preferred way to do
> this (new domctl, existing, etc)...
> 
> I analyzed what Julien had suggested regarding pass gpaddr_bits via Arm's struct xen_arch_domainconfig (I assume, this should be an OUT
> parameter) and I think it makes sense. Taking into the account that the feature freeze date is coming, I will wait a few days, and if there
> are no objections I will send updated version (patch #3 also needs updating as it expects the gpaddr_bits to be in physinfo).


No objections from me, I think Julien's suggestion is a good one.
--8323329-254547066-1633381901=:3209--


From xen-devel-bounces@lists.xenproject.org Mon Oct 04 21:53:39 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Oct 2021 21:53:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.201734.356348 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXVts-000307-Bx; Mon, 04 Oct 2021 21:53:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 201734.356348; Mon, 04 Oct 2021 21:53:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXVts-000300-8e; Mon, 04 Oct 2021 21:53:32 +0000
Received: by outflank-mailman (input) for mailman id 201734;
 Mon, 04 Oct 2021 21:53:30 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Ik8X=OY=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1mXVtq-0002z9-R4
 for xen-devel@lists.xenproject.org; Mon, 04 Oct 2021 21:53:30 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 82107399-255d-11ec-bebd-12813bfff9fa;
 Mon, 04 Oct 2021 21:53:29 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id 895D361526;
 Mon,  4 Oct 2021 21:53:27 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 82107399-255d-11ec-bebd-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1633384408;
	bh=3ZCBAhE3tZV9HfZi1lWSNSACyQ0DzDfymMxDbNez3DU=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=kiwAFS4dJQZZ5v45mB7nJMZ1qMj1sXsdrVk6Mr5o4eDGRCJ5idYAIGgnoGEbU3omy
	 gwIEhWJ8DoVMYaaxGLOSAk9RPEBVSszDXtzvqxaIbhDGqU0E0LelQ7iN9uZWDyXpVE
	 8OQk60X6xkFjezYthmkR4MdiuI0dFdmrBdFJ7K7JLbnwEo4KgemYlBhomNf25RDQYG
	 muMqJrEBfxl4IzRB1OUqmAROKDWieHhAxbLNynoDVTcLrGV0MSlRfyUq+ZD0JTJvRd
	 G4lOE4Q3OxXyuynIKouICxzj2zJ4If/+iaNkM7E45lfUB42aeWP7nYiAh8qV9kJiUA
	 qQUa+Y8ZwOwng==
Date: Mon, 4 Oct 2021 14:53:26 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Oleksandr Tyshchenko <olekstysh@gmail.com>
cc: Stefano Stabellini <sstabellini@kernel.org>, 
    xen-devel <xen-devel@lists.xenproject.org>, 
    Christopher Clark <christopher.w.clark@gmail.com>, 
    =?UTF-8?Q?Alex_Benn=C3=A9e?= <alex.bennee@linaro.org>, 
    =?UTF-8?Q?Marek_Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>, 
    Artem Mygaiev <Artem_Mygaiev@epam.com>, Sergio Lopez <slp@redhat.com>, 
    Wei Liu <wl@xen.org>, Stefan Hajnoczi <stefanha@gmail.com>, 
    Rust-VMM Mailing List <rust-vmm@lists.opendev.org>, 
    Doug Goldstein <cardoe@cardoe.com>, 
    Andrew Cooper <andrew.cooper3@citrix.com>, 
    Arnd Bergmann <arnd.bergmann@linaro.org>, 
    David Woodhouse <dwmw2@infradead.org>, 
    Stratos Mailing List <stratos-dev@op-lists.linaro.org>, 
    Rich Persaud <persaur@gmail.com>, 
    Daniel Smith <dpsmith@apertussolutions.com>, Paul Durrant <paul@xen.org>, 
    openxt <openxt@googlegroups.com>, Julien Grall <julien@xen.org>, 
    jgross@suse.com
Subject: Re: [Stratos-dev] Xen Rust VirtIO demos work breakdown for Project
 Stratos
In-Reply-To: <CAPD2p-m=hYbG1YjPZ9yZ7Qzs6KjCT2jSHpaDUPB0sFJoZfY4uw@mail.gmail.com>
Message-ID: <alpine.DEB.2.21.2110041436070.3209@sstabellini-ThinkPad-T480s>
References: <87pmsylywy.fsf@linaro.org> <YU5mW396S04IsCBr@mail-itl> <874ka68h96.fsf@linaro.org> <CACMJ4GbgnQVQbH1N3Duxmx10n-Qv+zzncqarNyuhmKhE-wqdqA@mail.gmail.com> <alpine.DEB.2.21.2109272323160.5022@sstabellini-ThinkPad-T480s>
 <CAPD2p-=MdGB_a+oEsFrPQpLo7GeKkMwYyAWcQt3z0qrGr3vR7w@mail.gmail.com> <alpine.DEB.2.21.2110011649220.3209@sstabellini-ThinkPad-T480s> <CAPD2p-m=hYbG1YjPZ9yZ7Qzs6KjCT2jSHpaDUPB0sFJoZfY4uw@mail.gmail.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: multipart/mixed; BOUNDARY="8323329-2024082214-1633383612=:3209"
Content-ID: <alpine.DEB.2.21.2110041440170.3209@sstabellini-ThinkPad-T480s>

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-2024082214-1633383612=:3209
Content-Type: text/plain; CHARSET=UTF-8
Content-Transfer-Encoding: 8BIT
Content-ID: <alpine.DEB.2.21.2110041440171.3209@sstabellini-ThinkPad-T480s>

On Sat, 2 Oct 2021, Oleksandr Tyshchenko wrote:
> On Sat, Oct 2, 2021 at 2:58 AM Stefano Stabellini <sstabellini@kernel.org> wrote:
> 
> Hi Stefano, all
> 
> [Sorry for the possible format issues]
> [I have CCed Julien]
> 
> 
>       On Tue, 28 Sep 2021, Oleksandr Tyshchenko wrote:
>       > On Tue, Sep 28, 2021 at 9:26 AM Stefano Stabellini <sstabellini@kernel.org> wrote:
>       >
>       > Hi Stefano, all
>       >
>       > [Sorry for the possible format issues]
>       >
>       >
>       >       On Mon, 27 Sep 2021, Christopher Clark wrote:
>       >       > On Mon, Sep 27, 2021 at 3:06 AM Alex Bennée via Stratos-dev <stratos-dev@op-lists.linaro.org> wrote:
>       >       >
>       >       >       Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com> writes:
>       >       >
>       >       >       > [[PGP Signed Part:Undecided]]
>       >       >       > On Fri, Sep 24, 2021 at 05:02:46PM +0100, Alex Bennée wrote:
>       >       >       >> Hi,
>       >       >       >
>       >       >       > Hi,
>       >       >       >
>       >       >       >> 2.1 Stable ABI for foreignmemory mapping to non-dom0 ([STR-57])
>       >       >       >> ───────────────────────────────────────────────────────────────
>       >       >       >>
>       >       >       >>   Currently the foreign memory mapping support only works for dom0 due
>       >       >       >>   to reference counting issues. If we are to support backends running in
>       >       >       >>   their own domains this will need to get fixed.
>       >       >       >>
>       >       >       >>   Estimate: 8w
>       >       >       >>
>       >       >       >>
>       >       >       >> [STR-57] <https://linaro.atlassian.net/browse/STR-57>
>       >       >       >
>       >       >       > I'm pretty sure it was discussed before, but I can't find relevant
>       >       >       > (part of) thread right now: does your model assumes the backend (running
>       >       >       > outside of dom0) will gain ability to map (or access in other way)
>       >       >       > _arbitrary_ memory page of a frontend domain? Or worse: any domain?
>       >       >
>       >       >       The aim is for some DomU's to host backends for other DomU's instead of
>       >       >       all backends being in Dom0. Those backend DomU's would have to be
>       >       >       considered trusted because as you say the default memory model of VirtIO
>       >       >       is to have full access to the frontend domains memory map.
>       >       >
>       >       >
>       >       > I share Marek's concern. I believe that there are Xen-based systems that will want to run guests using VirtIO devices
>       without
>       >       extending
>       >       > this level of trust to the backend domains.
>       >
>       >       >From a safety perspective, it would be challenging to deploy a system
>       >       with privileged backends. From a safety perspective, it would be a lot
>       >       easier if the backend were unprivileged.
>       >
>       >       This is one of those times where safety and security requirements are
>       >       actually aligned.
>       >
>       >
>       > Well, the foreign memory mapping has one advantage in the context of Virtio use-case
>       > which is that Virtio infrastructure in Guest doesn't require any modifications to run on top Xen.
>       > The only issue with foreign memory here is that Guest memory actually mapped without its agreement
>       > which doesn't perfectly fit into the security model. (although there is one more issue with XSA-300,
>       > but I think it will go away sooner or later, at least there are some attempts to eliminate it).
>       > While the ability to map any part of Guest memory is not an issue for the backend running in Dom0
>       > (which we usually trust), this will certainly violate Xen security model if we want to run it in other
>       > domain, so I completely agree with the existing concern.
> 
>       Yep, that's what I was referring to.
> 
> 
>       > It was discussed before [1], but I couldn't find any decisions regarding that. As I understand,
>       > the one of the possible ideas is to have some entity in Xen (PV IOMMU/virtio-iommu/whatever)
>       > that works in protection mode, so it denies all foreign mapping requests from the backend running in DomU
>       > by default and only allows requests with mapping which were *implicitly* granted by the Guest before.
>       > For example, Xen could be informed which MMIOs hold the queue PFN and notify registers
>       > (as it traps the accesses to these registers anyway) and could theoretically parse the frontend request
>       > and retrieve descriptors to make a decision which GFNs are actually *allowed*.
>       >
>       > I can't say for sure (sorry not familiar enough with the topic), but implementing the virtio-iommu device
>       > in Xen we could probably avoid Guest modifications at all. Of course, for this to work
>       > the Virtio infrastructure in Guest should use DMA API as mentioned in [1].
>       >
>       > Would the “restricted foreign mapping” solution retain the Xen security model and be accepted
>       > by the Xen community? I wonder, has someone already looked in this direction, are there any
>       > pitfalls here or is this even feasible?
>       >
>       > [1] https://lore.kernel.org/xen-devel/464e91ec-2b53-2338-43c7-a018087fc7f6@arm.com/
> 
>       The discussion that went further is actually one based on the idea that
>       there is a pre-shared memory area and the frontend always passes
>       addresses from it. For ease of implementation, the pre-shared area is
>       the virtqueue itself so this approach has been called "fat virtqueue".
>       But it requires guest modifications and it probably results in
>       additional memory copies.
> 
>  
> I got it. Although we would need to map that pre-shared area anyway (I presume it could be done at once during initialization), I think it
> much better than
> map arbitrary pages at runtime.

Yeah that's the idea


> If there is a way for Xen to know the pre-shared area location in advance it will be able to allow mapping
> this region only and deny other attempts.
 
No, but there are patches (not yet upstream) to introduce a way to
pre-share memory regions between VMs using xl:
https://github.com/Xilinx/xen/commits/xilinx/release-2021.1?after=4bd2da58b5b008f77429007a307b658db9c0f636+104&branch=xilinx%2Frelease-2021.1

So I think it would probably be the other way around: xen/libxl
advertises on device tree (or ACPI) the presence of the pre-shared
regions to both domains. Then frontend and backend would start using it.

 
>       I am not sure if the approach you mentioned could be implemented
>       completely without frontend changes. It looks like Xen would have to
>       learn how to inspect virtqueues in order to verify implicit grants
>       without frontend changes.
> 
>  
> I looked through the virtio-iommu specification and corresponding Linux driver but I am sure I don't see all the challenges and pitfalls.
> Having a limited knowledge of IOMMU infrastructure in Linux, below is just my guess, which might be wrong.
> 
> 1. I think, if we want to avoid frontend changes the backend in Xen would need to fully conform to the specification, I am afraid that
> besides just inspecting virtqueues, the backend needs to properly and completely emulate the virtio device, handle shadow page tables, etc.
> Otherwise we might break the guest. I expect a huge amount of work to implement this properly.

Yeah, I think we would want to stay away from shadow pagetables unless
we are really forced to go there.


> 2. Also, if I got the things correctly, it looks like when enabling virtio-iommu, all addresses passed in requests to the virtio devices
> behind the virtio-iommu will be in guest virtual address space (IOVA). So we would need to find a way for userspace (if the backend is
> IOREQ server) to translate them to guest physical addresses (IPA) via these shadow page tables in the backend in front of mapping them via
> foreign memory map calls. So I expect Xen, toolstack and Linux privcmd driver changes and additional complexity taking into account how the
> data structures could be accessed (data structures being continuously in IOVA, could be discontinuous in IPA, indirect table descriptors,
> etc). 
> I am wondering, would it be possible to have identity IOMMU mapping (IOVA == GPA) at the guest side but without bypassing an IOMMU, as we
> need the virtio-iommu frontend to send map/unmap requests, can we control this behaviour somehow?
> I think this would simplify things.

None of the above looks easy. I think you are right that we would need
IOVA == GPA to make the implementation feasible and with decent
performance. But if we need a spec change, then I think Juergen's
proposal of introducing a new transport that uses grant table references
instead of GPAs is worth considering.


> 3. Also, we would probably want to have a single virtio-iommu device instance per guest, so all virtio devices which belong to this guest
> will share the IOMMU mapping for the optimization purposes. For this to work all virtio devices inside a guest should be attached to the
> same IOMMU domain. Probably, we could control that, but I am not 100% sure.  
--8323329-2024082214-1633383612=:3209--


From xen-devel-bounces@lists.xenproject.org Mon Oct 04 23:46:19 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Oct 2021 23:46:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.201766.356380 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXXes-0005oX-UL; Mon, 04 Oct 2021 23:46:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 201766.356380; Mon, 04 Oct 2021 23:46:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXXes-0005oQ-R8; Mon, 04 Oct 2021 23:46:10 +0000
Received: by outflank-mailman (input) for mailman id 201766;
 Mon, 04 Oct 2021 23:46:09 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Ik8X=OY=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1mXXer-0005oK-6G
 for xen-devel@lists.xenproject.org; Mon, 04 Oct 2021 23:46:09 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 3e7085f0-256d-11ec-bec2-12813bfff9fa;
 Mon, 04 Oct 2021 23:46:07 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id 14D1C61381;
 Mon,  4 Oct 2021 23:46:06 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3e7085f0-256d-11ec-bec2-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1633391166;
	bh=rrxVg0eOPYdj+folgW4BeDEArJaKlSmbBGg7semWN2k=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=l/JK/Ce4VXdDtIaof7wmkn25HGYvc1wFSW7JsBn4dHu9sgN8KXIR7Bw5jarkMgkQL
	 qGBx+g03Egy8SejYSWQ7AQwRRkoyYKf3wY9Cysj/2k7KmD3aMCt3A/zT2Gny/okyU/
	 EP0YP7JrmaIruYVjtaxIEEaOL1ReYsZmICUNudaoYL0IT/AtzsFdxytYRd322fLYhb
	 t8X3/9kt3Kc4uIEtCgDIVzagijv/mPwcJmqzAmPBmoYIiTtfaqlXqTUYKlIwsuNgbJ
	 rZO3j+JVt2OEmo3BGFrC2VBKTLCDCfiliu9sR0HyxcNeG7hZRmuC1xPqxiui1G5u9z
	 Vnw8PZLxUbRbQ==
Date: Mon, 4 Oct 2021 16:46:05 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Rahul Singh <rahul.singh@arm.com>
cc: xen-devel@lists.xenproject.org, bertrand.marquis@arm.com, 
    Andre.Przywara@arm.com, Stefano Stabellini <sstabellini@kernel.org>, 
    Julien Grall <julien@xen.org>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, 
    Andrew Cooper <andrew.cooper3@citrix.com>, 
    George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>, 
    Jan Beulich <jbeulich@suse.com>, Wei Liu <wl@xen.org>, 
    =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= <roger.pau@citrix.com>
Subject: Re: [PATCH v4 03/14] xen/arm: Add PHYSDEVOP_pci_device_(*add/remove)
 support for ARM
In-Reply-To: <99ee039a6cdd9ac7d54f1f01649d1dd3eeea3763.1633340795.git.rahul.singh@arm.com>
Message-ID: <alpine.DEB.2.21.2110041639560.3209@sstabellini-ThinkPad-T480s>
References: <cover.1633340795.git.rahul.singh@arm.com> <99ee039a6cdd9ac7d54f1f01649d1dd3eeea3763.1633340795.git.rahul.singh@arm.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Mon, 4 Oct 2021, Rahul Singh wrote:
> Hardware domain is in charge of doing the PCI enumeration and will
> discover the PCI devices and then will communicate to XEN via hyper
> call PHYSDEVOP_pci_device_add(..) to add the PCI devices in XEN.
> 
> Also implement PHYSDEVOP_pci_device_remove(..) to remove the PCI device.
> 
> As most of the code for PHYSDEVOP_pci_device_* is the same between x86
> and ARM, move the code to a common file to avoid duplication.
> 
> There are other PHYSDEVOP_pci_device_* operations to add PCI devices.
> Currently implemented PHYSDEVOP_pci_device_remove(..) and
> PHYSDEVOP_pci_device_add(..) only as those are minimum required to
> support PCI passthrough on ARM.
> 
> Signed-off-by: Rahul Singh <rahul.singh@arm.com>
> ---
> Change in v4:
> - Move file commom/physdev.c to drivers/pci/physdev.c
> - minor comments.
> Change in v3: Fixed minor comment.
> Change in v2:
> - Add support for PHYSDEVOP_pci_device_remove()
> - Move code to common code
> ---
> ---
>  xen/arch/arm/physdev.c        |  5 +--
>  xen/arch/x86/physdev.c        | 52 +----------------------
>  xen/arch/x86/x86_64/physdev.c |  2 +-
>  xen/drivers/pci/Makefile      |  1 +
>  xen/drivers/pci/physdev.c     | 80 +++++++++++++++++++++++++++++++++++
>  xen/include/public/arch-arm.h |  4 +-
>  xen/include/xen/hypercall.h   | 11 +++++
>  7 files changed, 100 insertions(+), 55 deletions(-)
>  create mode 100644 xen/drivers/pci/physdev.c
> 
> diff --git a/xen/arch/arm/physdev.c b/xen/arch/arm/physdev.c
> index e91355fe22..d766978629 100644
> --- a/xen/arch/arm/physdev.c
> +++ b/xen/arch/arm/physdev.c
> @@ -8,13 +8,12 @@
>  #include <xen/lib.h>
>  #include <xen/errno.h>
>  #include <xen/sched.h>
> -#include <asm/hypercall.h>
> +#include <xen/hypercall.h>
>  
>  
>  int do_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
>  {
> -    gdprintk(XENLOG_DEBUG, "PHYSDEVOP cmd=%d: not implemented\n", cmd);
> -    return -ENOSYS;
> +    return pci_physdev_op(cmd, arg);
>  }
>  
>  /*
> diff --git a/xen/arch/x86/physdev.c b/xen/arch/x86/physdev.c
> index 23465bcd00..ea38be8b79 100644
> --- a/xen/arch/x86/physdev.c
> +++ b/xen/arch/x86/physdev.c
> @@ -12,7 +12,7 @@
>  #include <asm/io_apic.h>
>  #include <asm/msi.h>
>  #include <asm/hvm/irq.h>
> -#include <asm/hypercall.h>
> +#include <xen/hypercall.h>
>  #include <public/xen.h>
>  #include <public/physdev.h>
>  #include <xsm/xsm.h>
> @@ -480,54 +480,6 @@ ret_t do_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
>          break;
>      }
>  
> -    case PHYSDEVOP_pci_device_add: {
> -        struct physdev_pci_device_add add;
> -        struct pci_dev_info pdev_info;
> -        nodeid_t node;
> -
> -        ret = -EFAULT;
> -        if ( copy_from_guest(&add, arg, 1) != 0 )
> -            break;
> -
> -        pdev_info.is_extfn = !!(add.flags & XEN_PCI_DEV_EXTFN);
> -        if ( add.flags & XEN_PCI_DEV_VIRTFN )
> -        {
> -            pdev_info.is_virtfn = 1;
> -            pdev_info.physfn.bus = add.physfn.bus;
> -            pdev_info.physfn.devfn = add.physfn.devfn;
> -        }
> -        else
> -            pdev_info.is_virtfn = 0;
> -
> -        if ( add.flags & XEN_PCI_DEV_PXM )
> -        {
> -            uint32_t pxm;
> -            size_t optarr_off = offsetof(struct physdev_pci_device_add, optarr) /
> -                                sizeof(add.optarr[0]);
> -
> -            if ( copy_from_guest_offset(&pxm, arg, optarr_off, 1) )
> -                break;
> -
> -            node = pxm_to_node(pxm);
> -        }
> -        else
> -            node = NUMA_NO_NODE;
> -
> -        ret = pci_add_device(add.seg, add.bus, add.devfn, &pdev_info, node);
> -        break;
> -    }
> -
> -    case PHYSDEVOP_pci_device_remove: {
> -        struct physdev_pci_device dev;
> -
> -        ret = -EFAULT;
> -        if ( copy_from_guest(&dev, arg, 1) != 0 )
> -            break;
> -
> -        ret = pci_remove_device(dev.seg, dev.bus, dev.devfn);
> -        break;
> -    }
> -
>      case PHYSDEVOP_prepare_msix:
>      case PHYSDEVOP_release_msix: {
>          struct physdev_pci_device dev;
> @@ -663,7 +615,7 @@ ret_t do_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
>      }
>  
>      default:
> -        ret = -ENOSYS;
> +        ret = pci_physdev_op(cmd, arg);
>          break;
>      }
>  
> diff --git a/xen/arch/x86/x86_64/physdev.c b/xen/arch/x86/x86_64/physdev.c
> index 0a50cbd4d8..e3cbd5ebcb 100644
> --- a/xen/arch/x86/x86_64/physdev.c
> +++ b/xen/arch/x86/x86_64/physdev.c
> @@ -9,7 +9,7 @@ EMIT_FILE;
>  #include <compat/xen.h>
>  #include <compat/event_channel.h>
>  #include <compat/physdev.h>
> -#include <asm/hypercall.h>
> +#include <xen/hypercall.h>
>  
>  #define do_physdev_op compat_physdev_op
>  
> diff --git a/xen/drivers/pci/Makefile b/xen/drivers/pci/Makefile
> index a98035df4c..972c923db0 100644
> --- a/xen/drivers/pci/Makefile
> +++ b/xen/drivers/pci/Makefile
> @@ -1 +1,2 @@
>  obj-y += pci.o
> +obj-y += physdev.o
> diff --git a/xen/drivers/pci/physdev.c b/xen/drivers/pci/physdev.c
> new file mode 100644
> index 0000000000..4f3e1a96c0
> --- /dev/null
> +++ b/xen/drivers/pci/physdev.c
> @@ -0,0 +1,80 @@
> +
> +#include <xen/guest_access.h>
> +#include <xen/hypercall.h>
> +#include <xen/init.h>
> +
> +#ifndef COMPAT
> +typedef long ret_t;
> +#endif
> +
> +ret_t pci_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
> +{
> +    ret_t ret;
> +
> +    switch ( cmd )
> +    {
> +    case PHYSDEVOP_pci_device_add: {
> +        struct physdev_pci_device_add add;
> +        struct pci_dev_info pdev_info;
> +        nodeid_t node = NUMA_NO_NODE;
> +
> +        ret = -EFAULT;
> +        if ( copy_from_guest(&add, arg, 1) != 0 )
> +            break;
> +
> +        pdev_info.is_extfn = (add.flags & XEN_PCI_DEV_EXTFN);
> +        if ( add.flags & XEN_PCI_DEV_VIRTFN )
> +        {
> +            pdev_info.is_virtfn = true;
> +            pdev_info.physfn.bus = add.physfn.bus;
> +            pdev_info.physfn.devfn = add.physfn.devfn;
> +        }
> +        else
> +            pdev_info.is_virtfn = false;
> +
> +#ifdef CONFIG_NUMA
> +        if ( add.flags & XEN_PCI_DEV_PXM )
> +        {
> +            uint32_t pxm;
> +            size_t optarr_off = offsetof(struct physdev_pci_device_add, optarr) /
> +                                sizeof(add.optarr[0]);
> +
> +            if ( copy_from_guest_offset(&pxm, arg, optarr_off, 1) )
> +                break;
> +
> +            node = pxm_to_node(pxm);
> +        }
> +#endif
> +
> +        ret = pci_add_device(add.seg, add.bus, add.devfn, &pdev_info, node);
> +        break;
> +    }
> +
> +    case PHYSDEVOP_pci_device_remove: {
> +        struct physdev_pci_device dev;
> +
> +        ret = -EFAULT;
> +        if ( copy_from_guest(&dev, arg, 1) != 0 )
> +            break;
> +
> +        ret = pci_remove_device(dev.seg, dev.bus, dev.devfn);
> +        break;
> +    }
> +
> +    default:
> +        ret = -ENOSYS;
> +        break;
> +    }
> +
> +    return ret;
> +}
> +
> +/*
> + * Local variables:
> + * mode: C
> + * c-file-style: "BSD"
> + * c-basic-offset: 4
> + * tab-width: 4
> + * indent-tabs-mode: nil
> + * End:
> + */
> diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h
> index 6b5a5f818a..d46c61fca9 100644
> --- a/xen/include/public/arch-arm.h
> +++ b/xen/include/public/arch-arm.h
> @@ -107,7 +107,9 @@
>   *   All generic sub-operations
>   *
>   *  HYPERVISOR_physdev_op
> - *   No sub-operations are currenty supported
> + *   Exactly these sub-operations are supported:
> + *   PHYSDEVOP_pci_device_add
> + *   PHYSDEVOP_pci_device_remove
>   *
>   *  HYPERVISOR_sysctl
>   *   All generic sub-operations, with the exception of:
> diff --git a/xen/include/xen/hypercall.h b/xen/include/xen/hypercall.h
> index 3771487a30..7096cc4fe4 100644
> --- a/xen/include/xen/hypercall.h
> +++ b/xen/include/xen/hypercall.h
> @@ -45,6 +45,17 @@ extern long
>  do_platform_op(
>      XEN_GUEST_HANDLE_PARAM(xen_platform_op_t) u_xenpf_op);
>  
> +#ifdef CONFIG_HAS_PCI
> +extern long
> +pci_physdev_op(
> +    int cmd, XEN_GUEST_HANDLE_PARAM(void) arg);
> +#else
> +static inline long pci_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
> +{
> +    gdprintk(XENLOG_DEBUG, "PHYSDEVOP cmd=%d: not implemented\n", cmd);
> +    return -ENOSYS;
> +}
> +#endif

Everything looks good up until here and you seemed to have addressed
Jan's comments well.

However, for this last change to hypercall.h: hypercall.h doesn't seem
to be the right place to add the static inline stub for the
!CONFIG_HAS_PCI case. 

Given that only ARM needs the !CONFIG_HAS_PCI stub, I would add it
directly to xen/arch/arm/physdev.c. Or just add an #ifdef directly
within do_physdev_op in xen/arch/arm/physdev.c.


From xen-devel-bounces@lists.xenproject.org Mon Oct 04 23:55:18 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Oct 2021 23:55:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.201775.356391 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXXnc-0007L0-Tp; Mon, 04 Oct 2021 23:55:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 201775.356391; Mon, 04 Oct 2021 23:55:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXXnc-0007Kt-PR; Mon, 04 Oct 2021 23:55:12 +0000
Received: by outflank-mailman (input) for mailman id 201775;
 Mon, 04 Oct 2021 23:55:12 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Ik8X=OY=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1mXXnc-0007Kn-5i
 for xen-devel@lists.xenproject.org; Mon, 04 Oct 2021 23:55:12 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 7d08a221-9475-40ef-989d-a4b7af40236a;
 Mon, 04 Oct 2021 23:55:09 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id 17A0C61401;
 Mon,  4 Oct 2021 23:55:09 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7d08a221-9475-40ef-989d-a4b7af40236a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1633391709;
	bh=YprroowCBIr3ntuk0NZGn3U11jwNEtVjX/nNCZ357iM=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=psYLrq1hPBZQQInsBOUUSS+6/8Prdf8NOQk641pS6ZDahK5KVZRb7e59sNrVsq8Qu
	 R9iSjamrXntuBWFpwQUuBgQscVaRqsDI4V+bq4hbKEyWIfO3jvIpO18I8zMzeIuHbR
	 lf0wJLVbXhfA5z9VEqK0wmrbzpi9iDjhF7/xAerNGsG+l5G9EeR8OwhT7XCA8QXKma
	 kHz7Tc5YTdppMWMW15GxNZOoS1At2ZNqnWwCsnDEDY/Li21v1k4fS9MWCe3u54biZW
	 jhKlxHqVtq1vLLg3FVuJ/uUX6PegucM2EJQTuN4G4m2P9om+o1bPB8UxVeuZiY1VHc
	 ZiuccVvHAAlhw==
Date: Mon, 4 Oct 2021 16:55:08 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Rahul Singh <rahul.singh@arm.com>
cc: xen-devel@lists.xenproject.org, bertrand.marquis@arm.com, 
    Andre.Przywara@arm.com, Stefano Stabellini <sstabellini@kernel.org>, 
    Julien Grall <julien@xen.org>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH v4 07/14] xen/arm: PCI host bridge discovery within XEN
 on ARM
In-Reply-To: <ac38f0d1b590686bbf55aa779108f7ce850dba93.1633340795.git.rahul.singh@arm.com>
Message-ID: <alpine.DEB.2.21.2110041654410.3209@sstabellini-ThinkPad-T480s>
References: <cover.1633340795.git.rahul.singh@arm.com> <ac38f0d1b590686bbf55aa779108f7ce850dba93.1633340795.git.rahul.singh@arm.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="8323329-251712677-1633391709=:3209"

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-251712677-1633391709=:3209
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT

On Mon, 4 Oct 2021, Rahul Singh wrote:
> XEN during boot will read the PCI device tree node “reg” property
> and will map the PCI config space to the XEN memory.
> 
> As of now only "pci-host-ecam-generic" compatible board is supported.
> 
> "linux,pci-domain" device tree property assigns a fixed PCI domain
> number to a host bridge, otherwise an unstable (across boots) unique
> number will be assigned by Linux. XEN access the PCI devices based on
> Segment:Bus:Device:Function. A Segment number in the XEN is same as a
> domain number in Linux. Segment number and domain number has to be in
> sync to access the correct PCI devices.
> 
> XEN will read the “linux,pci-domain” property from the device tree node
> and configure the host bridge segment number accordingly. If this
> property is not available XEN will allocate the unique segment number
> to the host bridge.
> 
> Signed-off-by: Rahul Singh <rahul.singh@arm.com>

Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>


> ---
> Chane in v4:
> - Move "#include <asm/pci.h>" in "xen/pci.h" after pci_sbdf_t
>   sbdf declaration change to separate patch.
> - Make gen_pci_dt_match as __initconstrel
> - Make pci_host_generic_probe as __init
> Change in v3:
> - Modify commit msg based on received comments.
> - Remove added struct match_table{} struct in struct device{}
> - Replace uint32_t sbdf to pci_sbdf_t sbdf to avoid typecast
> - Remove bus_start,bus_end and void *sysdata from struct pci_host_bridge{}
> - Move "#include <asm/pci.h>" in "xen/pci.h" after pci_sbdf_t sbdf declaration
> - Add pci_host_generic_probe() function
> Change in v2:
> - Add more info in commit msg
> - Add callback to parse register index.
> - Merge patch pci_ecam_operation into this patch to avoid confusion
> - Add new struct in struct device for match table
> ---
> ---
>  xen/arch/arm/pci/Makefile           |   4 +
>  xen/arch/arm/pci/ecam.c             |  61 +++++++
>  xen/arch/arm/pci/pci-access.c       |  83 ++++++++++
>  xen/arch/arm/pci/pci-host-common.c  | 247 ++++++++++++++++++++++++++++
>  xen/arch/arm/pci/pci-host-generic.c |  48 ++++++
>  xen/include/asm-arm/pci.h           |  56 +++++++
>  6 files changed, 499 insertions(+)
>  create mode 100644 xen/arch/arm/pci/ecam.c
>  create mode 100644 xen/arch/arm/pci/pci-access.c
>  create mode 100644 xen/arch/arm/pci/pci-host-common.c
>  create mode 100644 xen/arch/arm/pci/pci-host-generic.c
> 
> diff --git a/xen/arch/arm/pci/Makefile b/xen/arch/arm/pci/Makefile
> index a98035df4c..6f32fbbe67 100644
> --- a/xen/arch/arm/pci/Makefile
> +++ b/xen/arch/arm/pci/Makefile
> @@ -1 +1,5 @@
>  obj-y += pci.o
> +obj-y += pci-access.o
> +obj-y += pci-host-generic.o
> +obj-y += pci-host-common.o
> +obj-y += ecam.o
> diff --git a/xen/arch/arm/pci/ecam.c b/xen/arch/arm/pci/ecam.c
> new file mode 100644
> index 0000000000..602d00799c
> --- /dev/null
> +++ b/xen/arch/arm/pci/ecam.c
> @@ -0,0 +1,61 @@
> +/*
> + * Based on Linux drivers/pci/ecam.c
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program.  If not, see <http://www.gnu.org/licenses/>.
> + */
> +
> +#include <xen/pci.h>
> +#include <xen/sched.h>
> +
> +/*
> + * Function to implement the pci_ops->map_bus method.
> + */
> +void __iomem *pci_ecam_map_bus(struct pci_host_bridge *bridge,
> +                               pci_sbdf_t sbdf, uint32_t where)
> +{
> +    const struct pci_config_window *cfg = bridge->cfg;
> +    struct pci_ecam_ops *ops =
> +        container_of(bridge->ops, struct pci_ecam_ops, pci_ops);
> +    unsigned int devfn_shift = ops->bus_shift - 8;
> +    void __iomem *base;
> +
> +    unsigned int busn = PCI_BUS(sbdf.bdf);
> +
> +    if ( busn < cfg->busn_start || busn > cfg->busn_end )
> +        return NULL;
> +
> +    busn -= cfg->busn_start;
> +    base = cfg->win + (busn << ops->bus_shift);
> +
> +    return base + (PCI_DEVFN2(sbdf.bdf) << devfn_shift) + where;
> +}
> +
> +/* ECAM ops */
> +const struct pci_ecam_ops pci_generic_ecam_ops = {
> +    .bus_shift  = 20,
> +    .pci_ops    = {
> +        .map_bus                = pci_ecam_map_bus,
> +        .read                   = pci_generic_config_read,
> +        .write                  = pci_generic_config_write,
> +    }
> +};
> +
> +/*
> + * Local variables:
> + * mode: C
> + * c-file-style: "BSD"
> + * c-basic-offset: 4
> + * tab-width: 4
> + * indent-tabs-mode: nil
> + * End:
> + */
> diff --git a/xen/arch/arm/pci/pci-access.c b/xen/arch/arm/pci/pci-access.c
> new file mode 100644
> index 0000000000..3cd14a4b87
> --- /dev/null
> +++ b/xen/arch/arm/pci/pci-access.c
> @@ -0,0 +1,83 @@
> +/*
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program.  If not, see <http://www.gnu.org/licenses/>.
> + */
> +
> +#include <xen/pci.h>
> +#include <asm/io.h>
> +
> +#define INVALID_VALUE (~0U)
> +
> +int pci_generic_config_read(struct pci_host_bridge *bridge, pci_sbdf_t sbdf,
> +                            uint32_t reg, uint32_t len, uint32_t *value)
> +{
> +    void __iomem *addr = bridge->ops->map_bus(bridge, sbdf, reg);
> +
> +    if ( !addr )
> +    {
> +        *value = INVALID_VALUE;
> +        return -ENODEV;
> +    }
> +
> +    switch ( len )
> +    {
> +    case 1:
> +        *value = readb(addr);
> +        break;
> +    case 2:
> +        *value = readw(addr);
> +        break;
> +    case 4:
> +        *value = readl(addr);
> +        break;
> +    default:
> +        ASSERT_UNREACHABLE();
> +    }
> +
> +    return 0;
> +}
> +
> +int pci_generic_config_write(struct pci_host_bridge *bridge, pci_sbdf_t sbdf,
> +                             uint32_t reg, uint32_t len, uint32_t value)
> +{
> +    void __iomem *addr = bridge->ops->map_bus(bridge, sbdf, reg);
> +
> +    if ( !addr )
> +        return -ENODEV;
> +
> +    switch ( len )
> +    {
> +    case 1:
> +        writeb(value, addr);
> +        break;
> +    case 2:
> +        writew(value, addr);
> +        break;
> +    case 4:
> +        writel(value, addr);
> +        break;
> +    default:
> +        ASSERT_UNREACHABLE();
> +    }
> +
> +    return 0;
> +}
> +
> +/*
> + * Local variables:
> + * mode: C
> + * c-file-style: "BSD"
> + * c-basic-offset: 4
> + * tab-width: 4
> + * indent-tabs-mode: nil
> + * End:
> + */
> diff --git a/xen/arch/arm/pci/pci-host-common.c b/xen/arch/arm/pci/pci-host-common.c
> new file mode 100644
> index 0000000000..a08e06cea1
> --- /dev/null
> +++ b/xen/arch/arm/pci/pci-host-common.c
> @@ -0,0 +1,247 @@
> +/*
> + * Based on Linux drivers/pci/ecam.c
> + * Based on Linux drivers/pci/controller/pci-host-common.c
> + * Based on Linux drivers/pci/controller/pci-host-generic.c
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program.  If not, see <http://www.gnu.org/licenses/>.
> + */
> +
> +#include <xen/init.h>
> +#include <xen/pci.h>
> +#include <xen/rwlock.h>
> +#include <xen/sched.h>
> +#include <xen/vmap.h>
> +
> +/*
> + * List for all the pci host bridges.
> + */
> +
> +static LIST_HEAD(pci_host_bridges);
> +
> +static atomic_t domain_nr = ATOMIC_INIT(-1);
> +
> +static inline void __iomem *pci_remap_cfgspace(paddr_t start, size_t len)
> +{
> +    return ioremap_nocache(start, len);
> +}
> +
> +static void pci_ecam_free(struct pci_config_window *cfg)
> +{
> +    if ( cfg->win )
> +        iounmap(cfg->win);
> +
> +    xfree(cfg);
> +}
> +
> +static struct pci_config_window * __init
> +gen_pci_init(struct dt_device_node *dev, const struct pci_ecam_ops *ops)
> +{
> +    int err, cfg_reg_idx;
> +    u32 bus_range[2];
> +    paddr_t addr, size;
> +    struct pci_config_window *cfg;
> +
> +    cfg = xzalloc(struct pci_config_window);
> +    if ( !cfg )
> +        return NULL;
> +
> +    err = dt_property_read_u32_array(dev, "bus-range", bus_range,
> +                                     ARRAY_SIZE(bus_range));
> +    if ( err ) {
> +        cfg->busn_start = 0;
> +        cfg->busn_end = 0xff;
> +        printk(XENLOG_INFO "%s: No bus range found for pci controller\n",
> +               dt_node_full_name(dev));
> +    } else {
> +        cfg->busn_start = bus_range[0];
> +        cfg->busn_end = bus_range[1];
> +        if ( cfg->busn_end > cfg->busn_start + 0xff )
> +            cfg->busn_end = cfg->busn_start + 0xff;
> +    }
> +
> +    if ( ops->cfg_reg_index )
> +    {
> +        cfg_reg_idx = ops->cfg_reg_index(dev);
> +        if ( cfg_reg_idx < 0 )
> +            goto err_exit;
> +    }
> +    else
> +        cfg_reg_idx = 0;
> +
> +    /* Parse our PCI ecam register address */
> +    err = dt_device_get_address(dev, cfg_reg_idx, &addr, &size);
> +    if ( err )
> +        goto err_exit;
> +
> +    cfg->phys_addr = addr;
> +    cfg->size = size;
> +
> +    /*
> +     * On 64-bit systems, we do a single ioremap for the whole config space
> +     * since we have enough virtual address range available.  On 32-bit, we
> +     * ioremap the config space for each bus individually.
> +     * As of now only 64-bit is supported 32-bit is not supported.
> +     *
> +     * TODO: For 32-bit implement the ioremap/iounmap of config space
> +     * dynamically for each read/write call.
> +     */
> +    cfg->win = pci_remap_cfgspace(cfg->phys_addr, cfg->size);
> +    if ( !cfg->win )
> +    {
> +        printk(XENLOG_ERR "ECAM ioremap failed\n");
> +        goto err_exit;
> +    }
> +    printk("ECAM at [mem 0x%"PRIpaddr"-0x%"PRIpaddr"] for [bus %x-%x] \n",
> +            cfg->phys_addr, cfg->phys_addr + cfg->size - 1,
> +            cfg->busn_start, cfg->busn_end);
> +
> +    if ( ops->init )
> +    {
> +        err = ops->init(cfg);
> +        if ( err )
> +            goto err_exit;
> +    }
> +
> +    return cfg;
> +
> +err_exit:
> +    pci_ecam_free(cfg);
> +
> +    return NULL;
> +}
> +
> +struct pci_host_bridge *pci_alloc_host_bridge(void)
> +{
> +    struct pci_host_bridge *bridge = xzalloc(struct pci_host_bridge);
> +
> +    if ( !bridge )
> +        return NULL;
> +
> +    INIT_LIST_HEAD(&bridge->node);
> +
> +    return bridge;
> +}
> +
> +void pci_add_host_bridge(struct pci_host_bridge *bridge)
> +{
> +    list_add_tail(&bridge->node, &pci_host_bridges);
> +}
> +
> +static int pci_get_new_domain_nr(void)
> +{
> +    return atomic_inc_return(&domain_nr);
> +}
> +
> +static int pci_bus_find_domain_nr(struct dt_device_node *dev)
> +{
> +    static int use_dt_domains = -1;
> +    int domain;
> +
> +    domain = dt_get_pci_domain_nr(dev);
> +
> +    /*
> +     * Check DT domain and use_dt_domains values.
> +     *
> +     * If DT domain property is valid (domain >= 0) and
> +     * use_dt_domains != 0, the DT assignment is valid since this means
> +     * we have not previously allocated a domain number by using
> +     * pci_get_new_domain_nr(); we should also update use_dt_domains to
> +     * 1, to indicate that we have just assigned a domain number from
> +     * DT.
> +     *
> +     * If DT domain property value is not valid (ie domain < 0), and we
> +     * have not previously assigned a domain number from DT
> +     * (use_dt_domains != 1) we should assign a domain number by
> +     * using the:
> +     *
> +     * pci_get_new_domain_nr()
> +     *
> +     * API and update the use_dt_domains value to keep track of method we
> +     * are using to assign domain numbers (use_dt_domains = 0).
> +     *
> +     * All other combinations imply we have a platform that is trying
> +     * to mix domain numbers obtained from DT and pci_get_new_domain_nr(),
> +     * which is a recipe for domain mishandling and it is prevented by
> +     * invalidating the domain value (domain = -1) and printing a
> +     * corresponding error.
> +     */
> +    if ( domain >= 0 && use_dt_domains )
> +    {
> +        use_dt_domains = 1;
> +    }
> +    else if ( domain < 0 && use_dt_domains != 1 )
> +    {
> +        use_dt_domains = 0;
> +        domain = pci_get_new_domain_nr();
> +    }
> +    else
> +    {
> +        domain = -1;
> +    }
> +
> +    return domain;
> +}
> +
> +int pci_host_common_probe(struct dt_device_node *dev, const void *data)
> +{
> +    struct pci_host_bridge *bridge;
> +    struct pci_config_window *cfg;
> +    struct pci_ecam_ops *ops;
> +    int err;
> +
> +    if ( dt_device_for_passthrough(dev) )
> +        return 0;
> +
> +    ops = (struct pci_ecam_ops *) data;
> +
> +    bridge = pci_alloc_host_bridge();
> +    if ( !bridge )
> +        return -ENOMEM;
> +
> +    /* Parse and map our Configuration Space windows */
> +    cfg = gen_pci_init(dev, ops);
> +    if ( !cfg )
> +    {
> +        err = -ENOMEM;
> +        goto err_exit;
> +    }
> +
> +    bridge->dt_node = dev;
> +    bridge->cfg = cfg;
> +    bridge->ops = &ops->pci_ops;
> +
> +    bridge->segment = pci_bus_find_domain_nr(dev);
> +    if ( bridge->segment < 0 )
> +    {
> +        printk(XENLOG_ERR "Inconsistent \"linux,pci-domain\" property in DT\n");
> +        BUG();
> +    }
> +    pci_add_host_bridge(bridge);
> +
> +    return 0;
> +
> +err_exit:
> +    xfree(bridge);
> +
> +    return err;
> +}
> +
> +/*
> + * Local variables:
> + * mode: C
> + * c-file-style: "BSD"
> + * c-basic-offset: 4
> + * tab-width: 4
> + * indent-tabs-mode: nil
> + * End:
> + */
> diff --git a/xen/arch/arm/pci/pci-host-generic.c b/xen/arch/arm/pci/pci-host-generic.c
> new file mode 100644
> index 0000000000..33457fbe96
> --- /dev/null
> +++ b/xen/arch/arm/pci/pci-host-generic.c
> @@ -0,0 +1,48 @@
> +/*
> + * Based on Linux drivers/pci/controller/pci-host-common.c
> + * Based on Linux drivers/pci/controller/pci-host-generic.c
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program.  If not, see <http://www.gnu.org/licenses/>.
> + */
> +
> +#include <xen/init.h>
> +#include <xen/pci.h>
> +#include <asm/device.h>
> +#include <asm/pci.h>
> +
> +static const struct dt_device_match __initconstrel gen_pci_dt_match[] =
> +{
> +    { .compatible = "pci-host-ecam-generic" },
> +    { },
> +};
> +
> +static int __init pci_host_generic_probe(struct dt_device_node *dev,
> +                                         const void *data)
> +{
> +    return pci_host_common_probe(dev, &pci_generic_ecam_ops);
> +}
> +
> +DT_DEVICE_START(pci_gen, "PCI HOST GENERIC", DEVICE_PCI)
> +.dt_match = gen_pci_dt_match,
> +.init = pci_host_generic_probe,
> +DT_DEVICE_END
> +
> +/*
> + * Local variables:
> + * mode: C
> + * c-file-style: "BSD"
> + * c-basic-offset: 4
> + * tab-width: 4
> + * indent-tabs-mode: nil
> + * End:
> + */
> diff --git a/xen/include/asm-arm/pci.h b/xen/include/asm-arm/pci.h
> index 0cf849e26f..bb7eda6705 100644
> --- a/xen/include/asm-arm/pci.h
> +++ b/xen/include/asm-arm/pci.h
> @@ -26,6 +26,62 @@ struct arch_pci_dev {
>      struct device dev;
>  };
>  
> +/*
> + * struct to hold the mappings of a config space window. This
> + * is expected to be used as sysdata for PCI controllers that
> + * use ECAM.
> + */
> +struct pci_config_window {
> +    paddr_t         phys_addr;
> +    paddr_t         size;
> +    uint8_t         busn_start;
> +    uint8_t         busn_end;
> +    void __iomem    *win;
> +};
> +
> +/*
> + * struct to hold pci host bridge information
> + * for a PCI controller.
> + */
> +struct pci_host_bridge {
> +    struct dt_device_node *dt_node;  /* Pointer to the associated DT node */
> +    struct list_head node;           /* Node in list of host bridges */
> +    uint16_t segment;                /* Segment number */
> +    struct pci_config_window* cfg;   /* Pointer to the bridge config window */
> +    struct pci_ops *ops;
> +};
> +
> +struct pci_ops {
> +    void __iomem *(*map_bus)(struct pci_host_bridge *bridge, pci_sbdf_t sbdf,
> +                             uint32_t offset);
> +    int (*read)(struct pci_host_bridge *bridge, pci_sbdf_t sbdf,
> +                uint32_t reg, uint32_t len, uint32_t *value);
> +    int (*write)(struct pci_host_bridge *bridge, pci_sbdf_t sbdf,
> +                 uint32_t reg, uint32_t len, uint32_t value);
> +};
> +
> +/*
> + * struct to hold pci ops and bus shift of the config window
> + * for a PCI controller.
> + */
> +struct pci_ecam_ops {
> +    unsigned int            bus_shift;
> +    struct pci_ops          pci_ops;
> +    int (*cfg_reg_index)(struct dt_device_node *dev);
> +    int (*init)(struct pci_config_window *);
> +};
> +
> +/* Default ECAM ops */
> +extern const struct pci_ecam_ops pci_generic_ecam_ops;
> +
> +int pci_host_common_probe(struct dt_device_node *dev, const void *data);
> +int pci_generic_config_read(struct pci_host_bridge *bridge, pci_sbdf_t sbdf,
> +                            uint32_t reg, uint32_t len, uint32_t *value);
> +int pci_generic_config_write(struct pci_host_bridge *bridge, pci_sbdf_t sbdf,
> +                             uint32_t reg, uint32_t len, uint32_t value);
> +void __iomem *pci_ecam_map_bus(struct pci_host_bridge *bridge,
> +                               pci_sbdf_t sbdf, uint32_t where);
> +
>  static always_inline bool is_pci_passthrough_enabled(void)
>  {
>      return pci_passthrough_enabled;
> -- 
> 2.25.1
> 
--8323329-251712677-1633391709=:3209--


From xen-devel-bounces@lists.xenproject.org Mon Oct 04 23:57:40 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 04 Oct 2021 23:57:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.201783.356401 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXXpz-0007xk-AD; Mon, 04 Oct 2021 23:57:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 201783.356401; Mon, 04 Oct 2021 23:57:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXXpz-0007xd-7M; Mon, 04 Oct 2021 23:57:39 +0000
Received: by outflank-mailman (input) for mailman id 201783;
 Mon, 04 Oct 2021 23:57:38 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mXXpy-0007xV-7c
 for xen-devel@lists.xenproject.org; Mon, 04 Oct 2021 23:57:38 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mXXpy-0007MK-5m
 for xen-devel@lists.xenproject.org; Mon, 04 Oct 2021 23:57:38 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mXXpy-0000qr-4j
 for xen-devel@lists.xenproject.org; Mon, 04 Oct 2021 23:57:38 +0000
Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89)
 (envelope-from <iwj@xenproject.org>)
 id 1mXXpw-0007EX-9S; Tue, 05 Oct 2021 00:57:36 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:To:Date:
	Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From;
	bh=wiPgQbXcvgN21haKZ+QwoJo2Mo+inINXjEusETAl+Os=; b=xk1/BC1eRYN34Ji9ZdQ5fQHL/U
	g+xkJwTCw8SyvJ0FaTOiCZFgZXspu0+/gJw3jzo8olp8BYPGw9131Q9HmefKsSF0jYxYYoe2l47Oe
	GgsQfQwlKCOjNQeIuGiWUXJq1hCcy3Z5Hb6eRPvfWiYq9RkpIgjL/YEVEhSvcWseootg=;
From: Ian Jackson <iwj@xenproject.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <24923.38127.990669.853370@mariner.uk.xensource.com>
Date: Tue, 5 Oct 2021 00:57:35 +0100
To: xen-devel@lists.xenproject.org,
    jbeulich@suse.com,
    julien.grall.oss@gmail.com,
    iwj@xenproject.org,
    sstabellini@kernel.org,
    dpsmith@apertussolutions.com
Subject: Re: [adhoc test] 165359: tolerable truncated
In-Reply-To: <E1mXTS5-00046z-9X@osstest.test-lab.xenproject.org>
References: <E1mXTS5-00046z-9X@osstest.test-lab.xenproject.org>
X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu)

iwj@xenbits.xen.org writes ("[adhoc test] 165359: tolerable truncated"):
> [adhoc play] <testing.git master not a tty>
> harness 3a3089c9: mfi-common: Drop Linux dom0 i386 tests for newer Lin...
> 165359: tolerable truncated
...
> Tests which did not succeed, but are not blocking:
>  test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail  like 165218
>  test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail  like 165218

This means that the kernel patch fixed the problem.  Nothing went
wrong here other than that arm64 doesn't support save/restore and
migraiton.

Ian.


From xen-devel-bounces@lists.xenproject.org Tue Oct 05 00:02:05 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Oct 2021 00:02:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.201791.356413 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXXuD-0001Wo-Cd; Tue, 05 Oct 2021 00:02:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 201791.356413; Tue, 05 Oct 2021 00:02:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXXuD-0001Wh-9k; Tue, 05 Oct 2021 00:02:01 +0000
Received: by outflank-mailman (input) for mailman id 201791;
 Tue, 05 Oct 2021 00:01:59 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+0nn=OZ=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1mXXuB-0001Wb-Mv
 for xen-devel@lists.xenproject.org; Tue, 05 Oct 2021 00:01:59 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 0e357281-1c92-4a94-aa74-7fce28abf6e5;
 Tue, 05 Oct 2021 00:01:58 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id ABDBA6109F;
 Tue,  5 Oct 2021 00:01:57 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0e357281-1c92-4a94-aa74-7fce28abf6e5
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1633392118;
	bh=QDXR8GQPm28lq9EFaB3/ihK8Y0H6KJF1g8s2pyNW1iQ=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=CSLoUPxW5qzG+59ZH21g3i5gDp2K00BKePLVl8JPZlQtu4c4IkUfQq83a400tUn1K
	 vaAJGUy/oNB0s6Do0qazm5GbAbaneIDZ9mt9N8Cn1bB5rymF1IoStedsgETm5nr8gw
	 tZ3KtKagZVs6zfyTAfqT7Hx4VUf0pBhnC2386TCCW6/ekWz+p3ZSVJ76OIazGgmW1m
	 tqvZ58Ab1dH/wLq+Nqh8izv/5v4ihvX6QDQponqijtfegi9Kqg4RscBPJWmE9m4219
	 w9t1sU1wyHCYvAZ8V9e3rj7W1NUp1Emqysqr6CuJdtFT4UEwksNql/L6uSA6a91O6H
	 sAJkwQStprwEg==
Date: Mon, 4 Oct 2021 17:01:56 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Rahul Singh <rahul.singh@arm.com>
cc: xen-devel@lists.xenproject.org, bertrand.marquis@arm.com, 
    Andre.Przywara@arm.com, 
    Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>, 
    Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH v4 08/14] xen/arm: Add support for Xilinx ZynqMP PCI host
 controller
In-Reply-To: <0d4157f3446a974cc69005b9ea0d5b1716e78f41.1633340795.git.rahul.singh@arm.com>
Message-ID: <alpine.DEB.2.21.2110041659500.3209@sstabellini-ThinkPad-T480s>
References: <cover.1633340795.git.rahul.singh@arm.com> <0d4157f3446a974cc69005b9ea0d5b1716e78f41.1633340795.git.rahul.singh@arm.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Mon, 4 Oct 2021, Rahul Singh wrote:
> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> 
> Add support for Xilinx ZynqMP PCI host controller to map the PCI config
> space to the XEN memory.
> 
> Patch helps to understand how the generic infrastructure for PCI
> host-bridge discovery will be used for future references.
> 
> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> Signed-off-by: Rahul Singh <rahul.singh@arm.com>
> Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>

Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>


> ---
> Change in v4:
> - Add __initconstrel and __init for struct and functions
> - Added Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>
> Change in v3:
> - nwl_cfg_reg_index(..) as static function
> - Add support for pci_host_generic_probe()
> Change in v2:
> - Add more info in commit msg
> ---
> ---
>  xen/arch/arm/pci/Makefile          |  1 +
>  xen/arch/arm/pci/pci-host-zynqmp.c | 65 ++++++++++++++++++++++++++++++
>  2 files changed, 66 insertions(+)
>  create mode 100644 xen/arch/arm/pci/pci-host-zynqmp.c
> 
> diff --git a/xen/arch/arm/pci/Makefile b/xen/arch/arm/pci/Makefile
> index 6f32fbbe67..1d045ade01 100644
> --- a/xen/arch/arm/pci/Makefile
> +++ b/xen/arch/arm/pci/Makefile
> @@ -3,3 +3,4 @@ obj-y += pci-access.o
>  obj-y += pci-host-generic.o
>  obj-y += pci-host-common.o
>  obj-y += ecam.o
> +obj-y += pci-host-zynqmp.o
> diff --git a/xen/arch/arm/pci/pci-host-zynqmp.c b/xen/arch/arm/pci/pci-host-zynqmp.c
> new file mode 100644
> index 0000000000..61a9807d3d
> --- /dev/null
> +++ b/xen/arch/arm/pci/pci-host-zynqmp.c
> @@ -0,0 +1,65 @@
> +/*
> + * Based on Linux drivers/pci/controller/pci-host-common.c
> + * Based on Linux drivers/pci/controller/pci-host-generic.c
> + * Based on xen/arch/arm/pci/pci-host-generic.c
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program.  If not, see <http://www.gnu.org/licenses/>.
> + */
> +
> +#include <xen/init.h>
> +#include <xen/pci.h>
> +#include <asm/device.h>
> +#include <asm/pci.h>
> +
> +static int __init nwl_cfg_reg_index(struct dt_device_node *np)
> +{
> +    return dt_property_match_string(np, "reg-names", "cfg");
> +}
> +
> +/* ECAM ops */
> +const struct pci_ecam_ops nwl_pcie_ops = {
> +    .bus_shift  = 20,
> +    .cfg_reg_index = nwl_cfg_reg_index,
> +    .pci_ops    = {
> +        .map_bus                = pci_ecam_map_bus,
> +        .read                   = pci_generic_config_read,
> +        .write                  = pci_generic_config_write,
> +    }
> +};
> +
> +static const struct dt_device_match __initconstrel nwl_pcie_dt_match[] =
> +{
> +    { .compatible = "xlnx,nwl-pcie-2.11" },
> +    { },
> +};
> +
> +static int __init pci_host_generic_probe(struct dt_device_node *dev,
> +                                         const void *data)
> +{
> +    return pci_host_common_probe(dev, &nwl_pcie_ops);
> +}
> +
> +DT_DEVICE_START(pci_gen, "PCI HOST ZYNQMP", DEVICE_PCI)
> +.dt_match = nwl_pcie_dt_match,
> +.init = pci_host_generic_probe,
> +DT_DEVICE_END
> +
> +/*
> + * Local variables:
> + * mode: C
> + * c-file-style: "BSD"
> + * c-basic-offset: 4
> + * tab-width: 4
> + * indent-tabs-mode: nil
> + * End:
> + */
> -- 
> 2.25.1
> 


From xen-devel-bounces@lists.xenproject.org Tue Oct 05 00:37:39 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Oct 2021 00:37:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.201825.356444 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXYSV-0005uw-PX; Tue, 05 Oct 2021 00:37:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 201825.356444; Tue, 05 Oct 2021 00:37:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXYSV-0005up-MZ; Tue, 05 Oct 2021 00:37:27 +0000
Received: by outflank-mailman (input) for mailman id 201825;
 Tue, 05 Oct 2021 00:37:26 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+0nn=OZ=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1mXYSU-0005uj-Iw
 for xen-devel@lists.xenproject.org; Tue, 05 Oct 2021 00:37:26 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 94e98f6b-478d-4a84-88cf-8d795dec6553;
 Tue, 05 Oct 2021 00:37:25 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id 2AC5360F4F;
 Tue,  5 Oct 2021 00:37:24 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 94e98f6b-478d-4a84-88cf-8d795dec6553
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1633394244;
	bh=/OBAD6y6OpNx8hBvi8f4fvGJls6xCRs5ywm8yH2lHbs=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=sX8usGeKSFEd3Y+dPb8hBbrU6XY9dNyuC/LWNJVY3A1hszjhdEFrWCUX0UYKSdYp6
	 sax95SX6zr7IUucEMrYnRWtGTeKOZ3pDbbfApPC7UyO4dsX6Tt+pH3tn38eqUhk4UG
	 Qa0MeMbB1JXmRzjgOEgdpnvtgNGJ4kKGfsYzsFolQNrXRmvABcHnwZKn7aNiIcnZAn
	 oM6pRipwrnRUhnFTFq3i2gQpC00q/+eryE1c5tt28mh8VSCu7AKP3tlm+KxWE1HbZJ
	 uMljQltDrlYPCD+Qa2jcPuJ+zsMRXSiNvKtfCdTcryTASJk6DkhxXzlPtxycp+9CRd
	 2pUkjKKKk/SGg==
Date: Mon, 4 Oct 2021 17:37:23 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Rahul Singh <rahul.singh@arm.com>
cc: xen-devel@lists.xenproject.org, bertrand.marquis@arm.com, 
    Andre.Przywara@arm.com, Christian Lindig <christian.lindig@citrix.com>, 
    David Scott <dave@recoil.org>, Ian Jackson <iwj@xenproject.org>, 
    Wei Liu <wl@xen.org>, Andrew Cooper <andrew.cooper3@citrix.com>, 
    George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>, 
    Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, 
    =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= <roger.pau@citrix.com>
Subject: Re: [PATCH v4 10/14] xen/domctl: Introduce XEN_DOMCTL_CDF_vpci
 flag
In-Reply-To: <f22c06abf5faa0a2f9c044f5b4009a99d7942215.1633340795.git.rahul.singh@arm.com>
Message-ID: <alpine.DEB.2.21.2110041711160.3209@sstabellini-ThinkPad-T480s>
References: <cover.1633340795.git.rahul.singh@arm.com> <f22c06abf5faa0a2f9c044f5b4009a99d7942215.1633340795.git.rahul.singh@arm.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Mon, 4 Oct 2021, Rahul Singh wrote:
> Introduce XEN_DOMCTL_CDF_vpci flag to enable VPCI support in XEN.
> Reject the use of this new flag for x86 as VPCI is not supported for
> DOMU guests for x86.
> 
> Signed-off-by: Rahul Singh <rahul.singh@arm.com>

Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>


> ---
> Change in v4: Added in this version
> ---
> ---
>  tools/ocaml/libs/xc/xenctrl.ml  | 1 +
>  tools/ocaml/libs/xc/xenctrl.mli | 1 +
>  xen/arch/arm/domain.c           | 4 ++--
>  xen/arch/x86/domain.c           | 6 ++++++
>  xen/common/domain.c             | 2 +-
>  xen/include/public/domctl.h     | 4 +++-
>  6 files changed, 14 insertions(+), 4 deletions(-)
> 
> diff --git a/tools/ocaml/libs/xc/xenctrl.ml b/tools/ocaml/libs/xc/xenctrl.ml
> index a5588c643f..7ed1c00e47 100644
> --- a/tools/ocaml/libs/xc/xenctrl.ml
> +++ b/tools/ocaml/libs/xc/xenctrl.ml
> @@ -69,6 +69,7 @@ type domain_create_flag =
>  	| CDF_XS_DOMAIN
>  	| CDF_IOMMU
>  	| CDF_NESTED_VIRT
> +	| CDF_VPCI
>  
>  type domain_create_iommu_opts =
>  	| IOMMU_NO_SHAREPT
> diff --git a/tools/ocaml/libs/xc/xenctrl.mli b/tools/ocaml/libs/xc/xenctrl.mli
> index 6e94940a8a..391d4abdf8 100644
> --- a/tools/ocaml/libs/xc/xenctrl.mli
> +++ b/tools/ocaml/libs/xc/xenctrl.mli
> @@ -62,6 +62,7 @@ type domain_create_flag =
>    | CDF_XS_DOMAIN
>    | CDF_IOMMU
>    | CDF_NESTED_VIRT
> +  | CDF_VPCI
>  
>  type domain_create_iommu_opts =
>    | IOMMU_NO_SHAREPT
> diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
> index 19c756ac3d..36138c1b2e 100644
> --- a/xen/arch/arm/domain.c
> +++ b/xen/arch/arm/domain.c
> @@ -622,8 +622,8 @@ int arch_sanitise_domain_config(struct xen_domctl_createdomain *config)
>  {
>      unsigned int max_vcpus;
>  
> -    /* HVM and HAP must be set. IOMMU may or may not be */
> -    if ( (config->flags & ~XEN_DOMCTL_CDF_iommu) !=
> +    /* HVM and HAP must be set. IOMMU and VPCI may or may not be */
> +    if ( (config->flags & ~XEN_DOMCTL_CDF_iommu & ~XEN_DOMCTL_CDF_vpci) !=
>           (XEN_DOMCTL_CDF_hvm | XEN_DOMCTL_CDF_hap) )
>      {
>          dprintk(XENLOG_INFO, "Unsupported configuration %#x\n",
> diff --git a/xen/arch/x86/domain.c b/xen/arch/x86/domain.c
> index ef1812dc14..79c2aa4636 100644
> --- a/xen/arch/x86/domain.c
> +++ b/xen/arch/x86/domain.c
> @@ -662,6 +662,12 @@ int arch_sanitise_domain_config(struct xen_domctl_createdomain *config)
>          return -EINVAL;
>      }
>  
> +    if ( config->flags & XEN_DOMCTL_CDF_vpci )
> +    {
> +        dprintk(XENLOG_INFO, "vPCI cannot be enabled yet\n");
> +        return -EINVAL;
> +    }
> +
>      if ( config->vmtrace_size )
>      {
>          unsigned int size = config->vmtrace_size;
> diff --git a/xen/common/domain.c b/xen/common/domain.c
> index 6ee5d033b0..40d67ec342 100644
> --- a/xen/common/domain.c
> +++ b/xen/common/domain.c
> @@ -483,7 +483,7 @@ static int sanitise_domain_config(struct xen_domctl_createdomain *config)
>           ~(XEN_DOMCTL_CDF_hvm | XEN_DOMCTL_CDF_hap |
>             XEN_DOMCTL_CDF_s3_integrity | XEN_DOMCTL_CDF_oos_off |
>             XEN_DOMCTL_CDF_xs_domain | XEN_DOMCTL_CDF_iommu |
> -           XEN_DOMCTL_CDF_nested_virt) )
> +           XEN_DOMCTL_CDF_nested_virt | XEN_DOMCTL_CDF_vpci) )
>      {
>          dprintk(XENLOG_INFO, "Unknown CDF flags %#x\n", config->flags);
>          return -EINVAL;
> diff --git a/xen/include/public/domctl.h b/xen/include/public/domctl.h
> index 96696e3842..4245da3f45 100644
> --- a/xen/include/public/domctl.h
> +++ b/xen/include/public/domctl.h
> @@ -70,9 +70,11 @@ struct xen_domctl_createdomain {
>  #define XEN_DOMCTL_CDF_iommu          (1U<<_XEN_DOMCTL_CDF_iommu)
>  #define _XEN_DOMCTL_CDF_nested_virt   6
>  #define XEN_DOMCTL_CDF_nested_virt    (1U << _XEN_DOMCTL_CDF_nested_virt)
> +#define _XEN_DOMCTL_CDF_vpci          7
> +#define XEN_DOMCTL_CDF_vpci           (1U << _XEN_DOMCTL_CDF_vpci)
>  
>  /* Max XEN_DOMCTL_CDF_* constant.  Used for ABI checking. */
> -#define XEN_DOMCTL_CDF_MAX XEN_DOMCTL_CDF_nested_virt
> +#define XEN_DOMCTL_CDF_MAX XEN_DOMCTL_CDF_vpci
>  
>      uint32_t flags;
>  
> -- 
> 2.25.1
> 


From xen-devel-bounces@lists.xenproject.org Tue Oct 05 00:38:17 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Oct 2021 00:38:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.201831.356455 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXYTJ-0006Ri-2Z; Tue, 05 Oct 2021 00:38:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 201831.356455; Tue, 05 Oct 2021 00:38:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXYTI-0006RZ-Vs; Tue, 05 Oct 2021 00:38:16 +0000
Received: by outflank-mailman (input) for mailman id 201831;
 Tue, 05 Oct 2021 00:38:16 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+0nn=OZ=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1mXYTI-0006RF-Dn
 for xen-devel@lists.xenproject.org; Tue, 05 Oct 2021 00:38:16 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 85ce5bb9-9657-4de7-889f-24590606130f;
 Tue, 05 Oct 2021 00:38:15 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id E87CA60F4F;
 Tue,  5 Oct 2021 00:38:13 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 85ce5bb9-9657-4de7-889f-24590606130f
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1633394294;
	bh=DKWVGzVyybEyhWDPwDrmLIWOAqRlHMVB5gN2nOOrAbU=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=I0vKJaTaz2R6VwlMnTPDnxGztXUvB9ASRRJuoWbCtULvKVgpbj/F6KJb+vL5DKWDg
	 vfA6UW1dTuBJ4fRuYlkHY4Ev4OIElTbIYSs9txAAQ0SpUU153Vdfrbi4HfGI+8OBTh
	 TvZ2jpYvyBOJvtBqOd1Ver7LC6VkM4PhxDSUVhl9lhao4re1VEEjBROvBRL5afoMR+
	 stQrobQwBe2MkzkWHLGYjWggh9NTL5UnF1gukzSzgrVcq7atfY6hcnQ/0duGQ0YKfY
	 mTlTfFYA8MnfOnp4DOJITj4hiLYkO/nUEEo8/+xDf/UoFv+het4S8RjhUO4gqcHvIG
	 TdrLowj2g+FrA==
Date: Mon, 4 Oct 2021 17:38:13 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Rahul Singh <rahul.singh@arm.com>
cc: xen-devel@lists.xenproject.org, bertrand.marquis@arm.com, 
    Andre.Przywara@arm.com, Stefano Stabellini <sstabellini@kernel.org>, 
    Julien Grall <julien@xen.org>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, 
    Andrew Cooper <andrew.cooper3@citrix.com>, 
    George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>, 
    Jan Beulich <jbeulich@suse.com>, Wei Liu <wl@xen.org>, 
    Paul Durrant <paul@xen.org>, 
    =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= <roger.pau@citrix.com>
Subject: Re: [PATCH v4 11/14] xen/arm: Enable the existing x86 virtual PCI
 support for ARM.
In-Reply-To: <f093de681c2560a7196895bcd666ef8840885c1d.1633340795.git.rahul.singh@arm.com>
Message-ID: <alpine.DEB.2.21.2110041709380.3209@sstabellini-ThinkPad-T480s>
References: <cover.1633340795.git.rahul.singh@arm.com> <f093de681c2560a7196895bcd666ef8840885c1d.1633340795.git.rahul.singh@arm.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: multipart/mixed; BOUNDARY="8323329-412816568-1633392638=:3209"
Content-ID: <alpine.DEB.2.21.2110041710460.3209@sstabellini-ThinkPad-T480s>

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-412816568-1633392638=:3209
Content-Type: text/plain; CHARSET=UTF-8
Content-Transfer-Encoding: 8BIT
Content-ID: <alpine.DEB.2.21.2110041710461.3209@sstabellini-ThinkPad-T480s>

On Mon, 4 Oct 2021, Rahul Singh wrote:
> The existing VPCI support available for X86 is adapted for Arm.
> When the device is added to XEN via the hyper call
> “PHYSDEVOP_pci_device_add”, VPCI handler for the config space
> access is added to the Xen to emulate the PCI devices config space.
> 
> A MMIO trap handler for the PCI ECAM space is registered in XEN
> so that when guest is trying to access the PCI config space,XEN
> will trap the access and emulate read/write using the VPCI and
> not the real PCI hardware.
> 
> For Dom0less systems scan_pci_devices() would be used to discover the
> PCI device in XEN and VPCI handler will be added during XEN boots.
> 
> Signed-off-by: Rahul Singh <rahul.singh@arm.com>
> ---
> Change in v4:
> - Move addition of XEN_DOMCTL_CDF_vpci flag to separate patch
> Change in v3:
> - Use is_pci_passthrough_enabled() in place of pci_passthrough_enabled variable
> - Reject XEN_DOMCTL_CDF_vpci for x86 in arch_sanitise_domain_config()
> - Remove IS_ENABLED(CONFIG_HAS_VPCI) from has_vpci()
> Change in v2:
> - Add new XEN_DOMCTL_CDF_vpci flag
> - modify has_vpci() to include XEN_DOMCTL_CDF_vpci
> - enable vpci support when pci-passthough option is enabled.
> ---
> ---
>  xen/arch/arm/Makefile         |   1 +
>  xen/arch/arm/domain.c         |   4 ++
>  xen/arch/arm/domain_build.c   |   3 +
>  xen/arch/arm/vpci.c           | 102 ++++++++++++++++++++++++++++++++++
>  xen/arch/arm/vpci.h           |  36 ++++++++++++
>  xen/drivers/passthrough/pci.c |  17 ++++++
>  xen/include/asm-arm/domain.h  |   7 ++-
>  xen/include/asm-x86/pci.h     |   2 -
>  xen/include/public/arch-arm.h |   7 +++
>  xen/include/xen/pci.h         |   2 +
>  10 files changed, 178 insertions(+), 3 deletions(-)
>  create mode 100644 xen/arch/arm/vpci.c
>  create mode 100644 xen/arch/arm/vpci.h
> 
> diff --git a/xen/arch/arm/Makefile b/xen/arch/arm/Makefile
> index 44d7cc81fa..fb9c976ea2 100644
> --- a/xen/arch/arm/Makefile
> +++ b/xen/arch/arm/Makefile
> @@ -7,6 +7,7 @@ ifneq ($(CONFIG_NO_PLAT),y)
>  obj-y += platforms/
>  endif
>  obj-$(CONFIG_TEE) += tee/
> +obj-$(CONFIG_HAS_VPCI) += vpci.o
>  
>  obj-$(CONFIG_HAS_ALTERNATIVE) += alternative.o
>  obj-y += bootfdt.init.o
> diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
> index 36138c1b2e..fbb52f78f1 100644
> --- a/xen/arch/arm/domain.c
> +++ b/xen/arch/arm/domain.c
> @@ -39,6 +39,7 @@
>  #include <asm/vgic.h>
>  #include <asm/vtimer.h>
>  
> +#include "vpci.h"
>  #include "vuart.h"
>  
>  DEFINE_PER_CPU(struct vcpu *, curr_vcpu);
> @@ -767,6 +768,9 @@ int arch_domain_create(struct domain *d,
>      if ( is_hardware_domain(d) && (rc = domain_vuart_init(d)) )
>          goto fail;
>  
> +    if ( (rc = domain_vpci_init(d)) != 0 )
> +        goto fail;
> +
>      return 0;
>  
>  fail:
> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
> index c5afbe2e05..f4c89bde8c 100644
> --- a/xen/arch/arm/domain_build.c
> +++ b/xen/arch/arm/domain_build.c
> @@ -3053,6 +3053,9 @@ void __init create_dom0(void)
>      if ( iommu_enabled )
>          dom0_cfg.flags |= XEN_DOMCTL_CDF_iommu;
>  
> +    if ( is_pci_passthrough_enabled() )
> +        dom0_cfg.flags |= XEN_DOMCTL_CDF_vpci;
> +
>      dom0 = domain_create(0, &dom0_cfg, true);
>      if ( IS_ERR(dom0) || (alloc_dom0_vcpu0(dom0) == NULL) )
>          panic("Error creating domain 0\n");
> diff --git a/xen/arch/arm/vpci.c b/xen/arch/arm/vpci.c
> new file mode 100644
> index 0000000000..76c12b9281
> --- /dev/null
> +++ b/xen/arch/arm/vpci.c
> @@ -0,0 +1,102 @@
> +/*
> + * xen/arch/arm/vpci.c
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; either version 2 of the License, or
> + * (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + */
> +#include <xen/sched.h>
> +
> +#include <asm/mmio.h>
> +
> +#define REGISTER_OFFSET(addr)  ( (addr) & 0x00000fff)
> +
> +/* Do some sanity checks. */
> +static bool vpci_mmio_access_allowed(unsigned int reg, unsigned int len)
> +{
> +    /* Check access size. */
> +    if ( len > 8 )
> +        return false;
> +
> +    /* Check that access is size aligned. */
> +    if ( (reg & (len - 1)) )
> +        return false;
> +
> +    return true;
> +}
> +
> +static int vpci_mmio_read(struct vcpu *v, mmio_info_t *info,
> +                          register_t *r, void *p)
> +{
> +    unsigned int reg;
> +    pci_sbdf_t sbdf;
> +    unsigned long data = ~0UL;
> +    unsigned int size = 1U << info->dabt.size;
> +
> +    sbdf.sbdf = MMCFG_BDF(info->gpa);
> +    reg = REGISTER_OFFSET(info->gpa);
> +
> +    if ( !vpci_mmio_access_allowed(reg, size) )
> +        return 0;
> +
> +    data = vpci_read(sbdf, reg, min(4u, size));
> +    if ( size == 8 )
> +        data |= (uint64_t)vpci_read(sbdf, reg + 4, 4) << 32;
> +
> +    *r = data;
> +
> +    return 1;
> +}
> +
> +static int vpci_mmio_write(struct vcpu *v, mmio_info_t *info,
> +                           register_t r, void *p)
> +{
> +    unsigned int reg;
> +    pci_sbdf_t sbdf;
> +    unsigned long data = r;
> +    unsigned int size = 1U << info->dabt.size;
> +
> +    sbdf.sbdf = MMCFG_BDF(info->gpa);
> +    reg = REGISTER_OFFSET(info->gpa);
> +
> +    if ( !vpci_mmio_access_allowed(reg, size) )
> +        return 0;
> +
> +    vpci_write(sbdf, reg, min(4u, size), data);
> +    if ( size == 8 )
> +        vpci_write(sbdf, reg + 4, 4, data >> 32);
> +
> +    return 1;
> +}
> +
> +static const struct mmio_handler_ops vpci_mmio_handler = {
> +    .read  = vpci_mmio_read,
> +    .write = vpci_mmio_write,
> +};
> +
> +int domain_vpci_init(struct domain *d)
> +{
> +    if ( !has_vpci(d) )
> +        return 0;
> +
> +    register_mmio_handler(d, &vpci_mmio_handler,
> +                          GUEST_VPCI_ECAM_BASE, GUEST_VPCI_ECAM_SIZE, NULL);
> +
> +    return 0;
> +}
> +
> +/*
> + * Local variables:
> + * mode: C
> + * c-file-style: "BSD"
> + * c-basic-offset: 4
> + * indent-tabs-mode: nil
> + * End:
> + */
> +
> diff --git a/xen/arch/arm/vpci.h b/xen/arch/arm/vpci.h
> new file mode 100644
> index 0000000000..d8a7b0e3e8
> --- /dev/null
> +++ b/xen/arch/arm/vpci.h
> @@ -0,0 +1,36 @@
> +/*
> + * xen/arch/arm/vpci.h
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; either version 2 of the License, or
> + * (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + */
> +
> +#ifndef __ARCH_ARM_VPCI_H__
> +#define __ARCH_ARM_VPCI_H__
> +
> +#ifdef CONFIG_HAS_VPCI
> +int domain_vpci_init(struct domain *d);
> +#else
> +static inline int domain_vpci_init(struct domain *d)
> +{
> +    return 0;
> +}
> +#endif
> +
> +#endif /* __ARCH_ARM_VPCI_H__ */
> +
> +/*
> + * Local variables:
> + * mode: C
> + * c-file-style: "BSD"
> + * c-basic-offset: 4
> + * indent-tabs-mode: nil
> + * End:
> + */
> diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci.c
> index e1b735d9e8..b36d5a4811 100644
> --- a/xen/drivers/passthrough/pci.c
> +++ b/xen/drivers/passthrough/pci.c
> @@ -766,6 +766,23 @@ int pci_add_device(u16 seg, u8 bus, u8 devfn,
>      else
>          iommu_enable_device(pdev);
>  
> +#ifdef CONFIG_ARM
> +    /*
> +     * On ARM PCI devices discovery will be done by Dom0. Add vpci handler when
> +     * Dom0 inform XEN to add the PCI devices in XEN.
> +     */
> +    ret = vpci_add_handlers(pdev);
> +    if ( ret )
> +    {
> +        printk(XENLOG_ERR "setup of vPCI failed: %d\n", ret);

I would also call:

  pci_cleanup_msi(pdev);


I know it does nothing on ARM today, but it serves as a reminder that in
the future likely MSIs will have to be cleaned up here.

With that:

Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>



> +        ret = iommu_remove_device(pdev);
> +        if ( pdev->domain )
> +            list_del(&pdev->domain_list);
> +        free_pdev(pseg, pdev);
> +        goto out;
> +    }
> +#endif
> +
>      pci_enable_acs(pdev);
>  
>  out:
> diff --git a/xen/include/asm-arm/domain.h b/xen/include/asm-arm/domain.h
> index c9277b5c6d..91d614b37e 100644
> --- a/xen/include/asm-arm/domain.h
> +++ b/xen/include/asm-arm/domain.h
> @@ -2,6 +2,7 @@
>  #define __ASM_DOMAIN_H__
>  
>  #include <xen/cache.h>
> +#include <xen/nospec.h>
>  #include <xen/timer.h>
>  #include <asm/page.h>
>  #include <asm/p2m.h>
> @@ -262,7 +263,11 @@ static inline void arch_vcpu_block(struct vcpu *v) {}
>  
>  #define arch_vm_assist_valid_mask(d) (1UL << VMASST_TYPE_runstate_update_flag)
>  
> -#define has_vpci(d)    ({ (void)(d); false; })
> +/*
> + * For X86 VPCI is enabled and tested for PVH DOM0 only but
> + * for ARM we enable support VPCI for guest domain also.
> + */
> +#define has_vpci(d) evaluate_nospec((d)->options & XEN_DOMCTL_CDF_vpci)
>  
>  #endif /* __ASM_DOMAIN_H__ */
>  
> diff --git a/xen/include/asm-x86/pci.h b/xen/include/asm-x86/pci.h
> index e076951032..c4a4fdcbc2 100644
> --- a/xen/include/asm-x86/pci.h
> +++ b/xen/include/asm-x86/pci.h
> @@ -6,8 +6,6 @@
>  #define CF8_ADDR_HI(cf8) (  ((cf8) & 0x0f000000) >> 16)
>  #define CF8_ENABLED(cf8) (!!((cf8) & 0x80000000))
>  
> -#define MMCFG_BDF(addr)  ( ((addr) & 0x0ffff000) >> 12)
> -
>  #define IS_SNB_GFX(id) (id == 0x01068086 || id == 0x01168086 \
>                          || id == 0x01268086 || id == 0x01028086 \
>                          || id == 0x01128086 || id == 0x01228086 \
> diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h
> index d46c61fca9..44be337dec 100644
> --- a/xen/include/public/arch-arm.h
> +++ b/xen/include/public/arch-arm.h
> @@ -418,6 +418,13 @@ typedef uint64_t xen_callback_t;
>  #define GUEST_GICV3_GICR0_BASE     xen_mk_ullong(0x03020000) /* vCPU0..127 */
>  #define GUEST_GICV3_GICR0_SIZE     xen_mk_ullong(0x01000000)
>  
> +/*
> + * 256 MB is reserved for VPCI configuration space based on calculation
> + * 256 buses × 32 devices × 8 functions × 4 KB = 256 MB
> + */
> +#define GUEST_VPCI_ECAM_BASE    xen_mk_ullong(0x10000000)
> +#define GUEST_VPCI_ECAM_SIZE    xen_mk_ullong(0x10000000)
> +
>  /* ACPI tables physical address */
>  #define GUEST_ACPI_BASE xen_mk_ullong(0x20000000)
>  #define GUEST_ACPI_SIZE xen_mk_ullong(0x02000000)
> diff --git a/xen/include/xen/pci.h b/xen/include/xen/pci.h
> index 70ac25345c..43b8a08170 100644
> --- a/xen/include/xen/pci.h
> +++ b/xen/include/xen/pci.h
> @@ -40,6 +40,8 @@
>  #define PCI_SBDF3(s,b,df) \
>      ((pci_sbdf_t){ .sbdf = (((s) & 0xffff) << 16) | PCI_BDF2(b, df) })
>  
> +#define MMCFG_BDF(addr)  (((addr) & 0x0ffff000) >> 12)
> +
>  typedef union {
>      uint32_t sbdf;
>      struct {
> -- 
> 2.25.1
> 
--8323329-412816568-1633392638=:3209--


From xen-devel-bounces@lists.xenproject.org Tue Oct 05 00:38:59 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Oct 2021 00:38:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.201836.356467 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXYTy-00074c-Ck; Tue, 05 Oct 2021 00:38:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 201836.356467; Tue, 05 Oct 2021 00:38:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXYTy-00074V-9g; Tue, 05 Oct 2021 00:38:58 +0000
Received: by outflank-mailman (input) for mailman id 201836;
 Tue, 05 Oct 2021 00:38:57 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+0nn=OZ=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1mXYTx-00074N-Lg
 for xen-devel@lists.xenproject.org; Tue, 05 Oct 2021 00:38:57 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 95f577a0-2f0e-482a-864c-5f2ee567d558;
 Tue, 05 Oct 2021 00:38:56 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id 6B5D761159;
 Tue,  5 Oct 2021 00:38:55 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 95f577a0-2f0e-482a-864c-5f2ee567d558
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1633394335;
	bh=Qq1v/4TnBtzsHKL+De8ZsvINWwI8vawbly4nf366SPo=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=lOoLCcYdoxphpWvQZIN8VDiNMMiw5M9HW0V6hWX6kl/fhfVKBMjyJDwycnktBDSlb
	 ptAhNGEybjzJmL8JShgNl0DkPARvObjfQy6Y2hWhl0cVTEmERQHccZWlKVQOOAch91
	 lfysXB6eT2fLy+iEK2f3KGPUZO913K6z3RaFicLiJeE7dtNfHlm1IYUJks1tSB4Wcs
	 XvJPWos4cOr25p5mgfDJlhDXfkychQsBCtTwG1fMGDgY7gOlQFZtU5Wmke/ugFRMor
	 XmP1DlVSOT6rie57mB52Af9/ZGHNdiL47VaKA9C7J8OkoAfSS20RG4t/JCd3eitI7C
	 tnEj6Vwsa4YiA==
Date: Mon, 4 Oct 2021 17:38:54 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Rahul Singh <rahul.singh@arm.com>
cc: xen-devel@lists.xenproject.org, bertrand.marquis@arm.com, 
    Andre.Przywara@arm.com, Ian Jackson <iwj@xenproject.org>, 
    Wei Liu <wl@xen.org>, Anthony PERARD <anthony.perard@citrix.com>, 
    Juergen Gross <jgross@suse.com>, 
    Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH v4 13/14] arm/libxl: Emulated PCI device tree node in
 libxl
In-Reply-To: <3ad42008f534671ae7f5b25da91253ce7cd4a3e9.1633340795.git.rahul.singh@arm.com>
Message-ID: <alpine.DEB.2.21.2110041714410.3209@sstabellini-ThinkPad-T480s>
References: <cover.1633340795.git.rahul.singh@arm.com> <3ad42008f534671ae7f5b25da91253ce7cd4a3e9.1633340795.git.rahul.singh@arm.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Mon, 4 Oct 2021, Rahul Singh wrote:
> libxl will create an emulated PCI device tree node in the device tree to
> enable the guest OS to discover the virtual PCI during guest boot.
> Emulated PCI device tree node will only be created when there is any
> device assigned to guest.
> 
> A new area has been reserved in the arm guest physical map at
> which the VPCI bus is declared in the device tree (reg and ranges
> parameters of the node).
> 
> Signed-off-by: Rahul Singh <rahul.singh@arm.com>
> ---
> Change in v4:
> - Gate code for x86 for setting the XEN_DOMCTL_CDF_vpci for x86.
> Change in v3:
> - Make GUEST_VPCI_MEM_ADDR address 2MB aligned
> Change in v2:
> - enable doamin_vpci_init() when XEN_DOMCTL_CDF_vpci is set for domain.
> ---
> ---
>  tools/include/libxl.h            |   6 ++
>  tools/libs/light/libxl_arm.c     | 105 +++++++++++++++++++++++++++++++
>  tools/libs/light/libxl_create.c  |   9 +++
>  tools/libs/light/libxl_types.idl |   1 +
>  tools/xl/xl_parse.c              |   8 +++
>  xen/include/public/arch-arm.h    |  10 +++
>  6 files changed, 139 insertions(+)
> 
> diff --git a/tools/include/libxl.h b/tools/include/libxl.h
> index b9ba16d698..3362073b21 100644
> --- a/tools/include/libxl.h
> +++ b/tools/include/libxl.h
> @@ -358,6 +358,12 @@
>   */
>  #define LIBXL_HAVE_BUILDINFO_ARM_VUART 1
>  
> +/*
> + * LIBXL_HAVE_BUILDINFO_ARM_VPCI indicates that the toolstack supports virtual
> + * PCI for ARM.
> + */
> +#define LIBXL_HAVE_BUILDINFO_ARM_VPCI 1
> +
>  /*
>   * LIBXL_HAVE_BUILDINFO_GRANT_LIMITS indicates that libxl_domain_build_info
>   * has the max_grant_frames and max_maptrack_frames fields.
> diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c
> index e3140a6e00..52f1ddce48 100644
> --- a/tools/libs/light/libxl_arm.c
> +++ b/tools/libs/light/libxl_arm.c
> @@ -269,6 +269,58 @@ static int fdt_property_regs(libxl__gc *gc, void *fdt,
>      return fdt_property(fdt, "reg", regs, sizeof(regs));
>  }
>  
> +static int fdt_property_values(libxl__gc *gc, void *fdt,
> +        const char *name, unsigned num_cells, ...)
> +{
> +    uint32_t prop[num_cells];
> +    be32 *cells = &prop[0];
> +    int i;
> +    va_list ap;
> +    uint32_t arg;
> +
> +    va_start(ap, num_cells);
> +    for (i = 0 ; i < num_cells; i++) {
> +        arg = va_arg(ap, uint32_t);
> +        set_cell(&cells, 1, arg);
> +    }
> +    va_end(ap);
> +
> +    return fdt_property(fdt, name, prop, sizeof(prop));
> +}
> +
> +static int fdt_property_vpci_ranges(libxl__gc *gc, void *fdt,
> +                                    unsigned addr_cells,
> +                                    unsigned size_cells,
> +                                    unsigned num_regs, ...)
> +{
> +    uint32_t regs[num_regs*((addr_cells*2)+size_cells+1)];
> +    be32 *cells = &regs[0];
> +    int i;
> +    va_list ap;
> +    uint64_t arg;
> +
> +    va_start(ap, num_regs);
> +    for (i = 0 ; i < num_regs; i++) {
> +        /* Set the memory bit field */
> +        arg = va_arg(ap, uint32_t);
> +        set_cell(&cells, 1, arg);
> +
> +        /* Set the vpci bus address */
> +        arg = addr_cells ? va_arg(ap, uint64_t) : 0;
> +        set_cell(&cells, addr_cells , arg);
> +
> +        /* Set the cpu bus address where vpci address is mapped */
> +        set_cell(&cells, addr_cells, arg);
> +
> +        /* Set the vpci size requested */
> +        arg = size_cells ? va_arg(ap, uint64_t) : 0;
> +        set_cell(&cells, size_cells, arg);
> +    }
> +    va_end(ap);
> +
> +    return fdt_property(fdt, "ranges", regs, sizeof(regs));
> +}
> +
>  static int make_root_properties(libxl__gc *gc,
>                                  const libxl_version_info *vers,
>                                  void *fdt)
> @@ -668,6 +720,53 @@ static int make_vpl011_uart_node(libxl__gc *gc, void *fdt,
>      return 0;
>  }
>  
> +static int make_vpci_node(libxl__gc *gc, void *fdt,
> +        const struct arch_info *ainfo,
> +        struct xc_dom_image *dom)
> +{
> +    int res;
> +    const uint64_t vpci_ecam_base = GUEST_VPCI_ECAM_BASE;
> +    const uint64_t vpci_ecam_size = GUEST_VPCI_ECAM_SIZE;
> +    const char *name = GCSPRINTF("pcie@%"PRIx64, vpci_ecam_base);
> +
> +    res = fdt_begin_node(fdt, name);
> +    if (res) return res;
> +
> +    res = fdt_property_compat(gc, fdt, 1, "pci-host-ecam-generic");
> +    if (res) return res;
> +
> +    res = fdt_property_string(fdt, "device_type", "pci");
> +    if (res) return res;
> +
> +    res = fdt_property_regs(gc, fdt, GUEST_ROOT_ADDRESS_CELLS,
> +            GUEST_ROOT_SIZE_CELLS, 1, vpci_ecam_base, vpci_ecam_size);
> +    if (res) return res;
> +
> +    res = fdt_property_values(gc, fdt, "bus-range", 2, 0, 255);
> +    if (res) return res;
> +
> +    res = fdt_property_cell(fdt, "#address-cells", 3);
> +    if (res) return res;
> +
> +    res = fdt_property_cell(fdt, "#size-cells", 2);
> +    if (res) return res;
> +
> +    res = fdt_property_string(fdt, "status", "okay");
> +    if (res) return res;
> +
> +    res = fdt_property_vpci_ranges(gc, fdt, GUEST_ROOT_ADDRESS_CELLS,
> +        GUEST_ROOT_SIZE_CELLS, 2,
> +        GUEST_VPCI_ADDR_TYPE_MEM, GUEST_VPCI_MEM_ADDR, GUEST_VPCI_MEM_SIZE,
> +        GUEST_VPCI_ADDR_TYPE_PREFETCH_MEM, GUEST_VPCI_PREFETCH_MEM_ADDR,
> +        GUEST_VPCI_PREFETCH_MEM_SIZE);
> +    if (res) return res;
> +
> +    res = fdt_end_node(fdt);
> +    if (res) return res;
> +
> +    return 0;
> +}
> +
>  static const struct arch_info *get_arch_info(libxl__gc *gc,
>                                               const struct xc_dom_image *dom)
>  {
> @@ -971,6 +1070,9 @@ next_resize:
>          if (info->tee == LIBXL_TEE_TYPE_OPTEE)
>              FDT( make_optee_node(gc, fdt) );
>  
> +        if (libxl_defbool_val(info->arch_arm.vpci))
> +            FDT( make_vpci_node(gc, fdt, ainfo, dom) );
> +
>          if (pfdt)
>              FDT( copy_partial_fdt(gc, fdt, pfdt) );
>  
> @@ -1189,6 +1291,9 @@ void libxl__arch_domain_build_info_setdefault(libxl__gc *gc,
>      /* ACPI is disabled by default */
>      libxl_defbool_setdefault(&b_info->acpi, false);
>  
> +    /* VPCI is disabled by default */
> +    libxl_defbool_setdefault(&b_info->arch_arm.vpci, false);
> +
>      if (b_info->type != LIBXL_DOMAIN_TYPE_PV)
>          return;
>  
> diff --git a/tools/libs/light/libxl_create.c b/tools/libs/light/libxl_create.c
> index e356b2106d..9408526036 100644
> --- a/tools/libs/light/libxl_create.c
> +++ b/tools/libs/light/libxl_create.c
> @@ -632,6 +632,15 @@ int libxl__domain_make(libxl__gc *gc, libxl_domain_config *d_config,
>          if (info->passthrough == LIBXL_PASSTHROUGH_SYNC_PT)
>              create.iommu_opts |= XEN_DOMCTL_IOMMU_no_sharept;
>  
> +#if defined(__arm__) || defined(__aarch64__)
> +        /*
> +         * Enable VPCI support for ARM. VPCI support for DOMU guest is not
> +         * supported for x86.
> +         */
> +        if ( libxl_defbool_val(b_info->arch_arm.vpci) )
> +            create.flags |= XEN_DOMCTL_CDF_vpci;
> +#endif

I don't think the #ifdef is required, is it? The check is based on
b_info->arch_arm.vpci which is already ARM-specific and couldn't be
enabled on X86. We have another similar check in libxl_create.c for
d_config->b_info.arch_arm.vuart without #ifdef.

My suggestion would be to just keep the in-code comment, but leave the
libxl_defbool_val check as it was before.


> +
>          /* Ultimately, handle is an array of 16 uint8_t, same as uuid */
>          libxl_uuid_copy(ctx, (libxl_uuid *)&create.handle, &info->uuid);
>  
> diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_types.idl
> index 3f9fff653a..78b1ddf0b8 100644
> --- a/tools/libs/light/libxl_types.idl
> +++ b/tools/libs/light/libxl_types.idl
> @@ -644,6 +644,7 @@ libxl_domain_build_info = Struct("domain_build_info",[
>  
>      ("arch_arm", Struct(None, [("gic_version", libxl_gic_version),
>                                 ("vuart", libxl_vuart_type),
> +                               ("vpci", libxl_defbool),
>                                ])),
>      ("arch_x86", Struct(None, [("msr_relaxed", libxl_defbool),
>                                ])),
> diff --git a/tools/xl/xl_parse.c b/tools/xl/xl_parse.c
> index 17dddb4cd5..576af67daa 100644
> --- a/tools/xl/xl_parse.c
> +++ b/tools/xl/xl_parse.c
> @@ -1497,6 +1497,14 @@ void parse_config_data(const char *config_source,
>          }
>          if (d_config->num_pcidevs && c_info->type == LIBXL_DOMAIN_TYPE_PV)
>              libxl_defbool_set(&b_info->u.pv.e820_host, true);
> +#if defined(__arm__) || defined(__aarch64__)
> +        /*
> +         * Enable VPCI support for ARM. VPCI support for DOMU guest is not
> +         * supported for x86.
> +         */
> +        if (d_config->num_pcidevs)
> +            libxl_defbool_set(&b_info->arch_arm.vpci, true);
> +#endif
>      }
>  
>      if (!xlu_cfg_get_list (config, "dtdev", &dtdevs, 0, 0)) {
> diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h
> index 44be337dec..45aac5d18f 100644
> --- a/xen/include/public/arch-arm.h
> +++ b/xen/include/public/arch-arm.h
> @@ -433,6 +433,11 @@ typedef uint64_t xen_callback_t;
>  #define GUEST_PL011_BASE    xen_mk_ullong(0x22000000)
>  #define GUEST_PL011_SIZE    xen_mk_ullong(0x00001000)
>  
> +/* Guest PCI-PCIe memory space where config space and BAR will be available.*/
> +#define GUEST_VPCI_ADDR_TYPE_MEM            xen_mk_ullong(0x02000000)
> +#define GUEST_VPCI_MEM_ADDR                 xen_mk_ullong(0x23000000)
> +#define GUEST_VPCI_MEM_SIZE                 xen_mk_ullong(0x10000000)
> +
>  /*
>   * 16MB == 4096 pages reserved for guest to use as a region to map its
>   * grant table in.
> @@ -448,6 +453,11 @@ typedef uint64_t xen_callback_t;
>  #define GUEST_RAM0_BASE   xen_mk_ullong(0x40000000) /* 3GB of low RAM @ 1GB */
>  #define GUEST_RAM0_SIZE   xen_mk_ullong(0xc0000000)
>  
> +/* 4GB @ 4GB Prefetch Memory for VPCI */
> +#define GUEST_VPCI_ADDR_TYPE_PREFETCH_MEM   xen_mk_ullong(0x42000000)
> +#define GUEST_VPCI_PREFETCH_MEM_ADDR        xen_mk_ullong(0x100000000)
> +#define GUEST_VPCI_PREFETCH_MEM_SIZE        xen_mk_ullong(0x100000000)
> +
>  #define GUEST_RAM1_BASE   xen_mk_ullong(0x0200000000) /* 1016GB of RAM @ 8GB */
>  #define GUEST_RAM1_SIZE   xen_mk_ullong(0xfe00000000)
>  
> -- 
> 2.25.1
> 


From xen-devel-bounces@lists.xenproject.org Tue Oct 05 00:57:44 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Oct 2021 00:57:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.201851.356477 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXYlz-00015U-4T; Tue, 05 Oct 2021 00:57:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 201851.356477; Tue, 05 Oct 2021 00:57:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXYlz-00015N-1I; Tue, 05 Oct 2021 00:57:35 +0000
Received: by outflank-mailman (input) for mailman id 201851;
 Tue, 05 Oct 2021 00:57:33 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+0nn=OZ=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1mXYlx-00015H-Gv
 for xen-devel@lists.xenproject.org; Tue, 05 Oct 2021 00:57:33 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 383deef3-2577-11ec-bec4-12813bfff9fa;
 Tue, 05 Oct 2021 00:57:32 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id C8BBE611AE;
 Tue,  5 Oct 2021 00:57:30 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 383deef3-2577-11ec-bec4-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1633395451;
	bh=9cbpxFS0frQFic+/fGdaKjkdAEQkKQxLYMRZqk4vCfU=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=nI931NCAqHArTXHtMiPdWpGTksguAfj5FMSRmZiBMWVIkHVwR1AoygJmiB9AiSxyR
	 z+QfNFuDslu3YAkHTEcVR/f4sVDcuaub4ZZ4nrLQIY92Gocf34lymWzFSDDfKb91hv
	 pF5U3hbheGHQ6Nv+VsAetYcMufHOc0azWjXELGDLyacS83vXJeGtEENtS1A/zNwskb
	 OE/tSqGbAqckigtfRHa2hpA90UAJKb70fsdId0pceYJW6+BC2CQmg56FzIiMb8p9ha
	 PpI19d3BCYTfIf9Xk1US/u8TRgb5qecJFgZojRiB1+ITXtqS+armBDf79oLDCvUKVS
	 1ISVDsl/Jb0og==
Date: Mon, 4 Oct 2021 17:57:29 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Rahul Singh <rahul.singh@arm.com>
cc: xen-devel@lists.xenproject.org, bertrand.marquis@arm.com, 
    Andre.Przywara@arm.com, Jan Beulich <jbeulich@suse.com>, 
    Paul Durrant <paul@xen.org>, Ian Jackson <iwj@xenproject.org>, 
    Wei Liu <wl@xen.org>, Juergen Gross <jgross@suse.com>, 
    Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, 
    Andrew Cooper <andrew.cooper3@citrix.com>, 
    George Dunlap <george.dunlap@citrix.com>, 
    =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= <roger.pau@citrix.com>, 
    Christian Lindig <christian.lindig@citrix.com>, 
    David Scott <dave@recoil.org>, Anthony PERARD <anthony.perard@citrix.com>
Subject: Re: [PATCH v4 00/14] PCI devices passthrough on Arm
In-Reply-To: <cover.1633340795.git.rahul.singh@arm.com>
Message-ID: <alpine.DEB.2.21.2110041753090.3209@sstabellini-ThinkPad-T480s>
References: <cover.1633340795.git.rahul.singh@arm.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

I committed patches #1, #4, #5 of this series


On Mon, 4 Oct 2021, Rahul Singh wrote:
> Hello All,
> 
> The purpose of this patch series is to add PCI passthrough support to Xen on
> Arm. PCI passthrough support on ARM is the collaboration work between EPAM and
> ARM. ARM submitted the partial RFC [1][2] last year to get early feedback. We
> tried to fix all the comments and added more features to this patch series.
> 
> Working POC with all the features can be found at [3]. Working POC is tested
> on x86 so that there will be no regression on x86. Design presentation can be
> found at [4]
> 
> PCI passthrough support is divided into different patches. This patch series
> includes following features: 
> 
> Preparatory work to implement the PCI passthrough support for the ARM:
> - Refactor MSI code.
> - Fixed compilation error when HAS_PCI enabled for ARM.
> 
> Discovering PCI Host Bridge in XEN:
> - PCI init to initialize the PCI driver.
> - PCI host bridge discovery in XEN and map the PCI ECAM configuration space to
>   the XEN memory.
> - PCI access functions.
> 
> Discovering PCI devices:
> - To support the PCI passthrough, XEN should be aware of the PCI
>   devices.
> - Hardware domain is in charge of doing the PCI enumeration and will discover
>   the PCI devices and then communicate to the XEN via a hypercall to add the
>   PCI devices in XEN.
> 
> Enable the existing x86 virtual PCI support for ARM:
> - Add VPCI trap handler for each of the PCI device added for config space
>   access.
> - Register the trap handler in XEN for each of the host bridge PCI ECAM config
>   space access.
> 
> Emulated PCI device tree node in libxl:
> - Create a virtual PCI device tree node in libxl to enable the guest OS to
>   discover the virtual PCI during guest boot.
> 
> This patch series does not inlcude the following features. Following features
> will be send for review in the next version of the patch series once initial
> patch series merged.
> 
> - VPCI support for DOMU guests (Non-identity mappings guest view of the BARs)
> - Virtual bus topology implementation
> - IOMMU related changes (generic, SMMUv2, SMMUv3)
> - MSI support for DOMU guests.
> - Virual ITS support for DOMU guests
> 
> [1] https://lists.xenproject.org/archives/html/xen-devel/2020-07/msg01184.html
> [2] https://lists.xenproject.org/archives/html/xen-devel/2020-07/threads.html#01184
> [3] https://gitlab.com/rahsingh/xen-integration/-/commits/pci-passthrough-upstream-all
> [4] https://static.sched.com/hosted_files/xen2021/e4/PCI_Device_Passthrough_On_Arm.pdf
> 
> Oleksandr Andrushchenko (1):
>   xen/arm: Add support for Xilinx ZynqMP PCI host controller
> 
> Rahul Singh (13):
>   xen/pci: gate APEI support on ARM
>   xen/arm: xc_domain_ioport_permission(..) not supported on ARM.
>   xen/arm: Add PHYSDEVOP_pci_device_(*add/remove) support for ARM
>   xen/pci: Include asm/pci.h after pci_sbdf_t in xen/pci.h
>   xen/arm: Add support for PCI init to initialize the PCI driver.
>   xen/arm: Add cmdline boot option "pci-passthrough = <boolean>"
>   xen/arm: PCI host bridge discovery within XEN on ARM
>   xen/arm: Implement pci access functions
>   xen/domctl: Introduce XEN_DOMCTL_CDF_vpci flag
>   xen/arm: Enable the existing x86 virtual PCI support for ARM.
>   xen/arm: Transitional change to build HAS_VPCI on ARM.
>   arm/libxl: Emulated PCI device tree node in libxl
>   xen/arm: Add linux,pci-domain property for hwdom if not available.
> 
>  docs/misc/xen-command-line.pandoc   |   7 +
>  tools/include/libxl.h               |   6 +
>  tools/libs/ctrl/xc_domain.c         |   9 +
>  tools/libs/light/libxl_arm.c        | 105 ++++++++++
>  tools/libs/light/libxl_create.c     |   9 +
>  tools/libs/light/libxl_types.idl    |   1 +
>  tools/ocaml/libs/xc/xenctrl.ml      |   1 +
>  tools/ocaml/libs/xc/xenctrl.mli     |   1 +
>  tools/xl/xl_parse.c                 |   8 +
>  xen/arch/arm/Makefile               |   1 +
>  xen/arch/arm/domain.c               |   8 +-
>  xen/arch/arm/domain_build.c         |  19 ++
>  xen/arch/arm/pci/Makefile           |   5 +
>  xen/arch/arm/pci/ecam.c             |  61 ++++++
>  xen/arch/arm/pci/pci-access.c       | 140 ++++++++++++++
>  xen/arch/arm/pci/pci-host-common.c  | 287 ++++++++++++++++++++++++++++
>  xen/arch/arm/pci/pci-host-generic.c |  48 +++++
>  xen/arch/arm/pci/pci-host-zynqmp.c  |  65 +++++++
>  xen/arch/arm/pci/pci.c              |  63 ++++++
>  xen/arch/arm/physdev.c              |   5 +-
>  xen/arch/arm/vpci.c                 | 102 ++++++++++
>  xen/arch/arm/vpci.h                 |  36 ++++
>  xen/arch/x86/domain.c               |   6 +
>  xen/arch/x86/physdev.c              |  52 +----
>  xen/arch/x86/x86_64/physdev.c       |   2 +-
>  xen/common/domain.c                 |   2 +-
>  xen/drivers/passthrough/pci.c       |  20 +-
>  xen/drivers/pci/Makefile            |   1 +
>  xen/drivers/pci/physdev.c           |  86 +++++++++
>  xen/drivers/vpci/Makefile           |   3 +-
>  xen/drivers/vpci/header.c           |   2 +
>  xen/include/asm-arm/device.h        |   1 +
>  xen/include/asm-arm/domain.h        |   7 +-
>  xen/include/asm-arm/pci.h           |  85 ++++++++
>  xen/include/asm-x86/pci.h           |   8 +-
>  xen/include/public/arch-arm.h       |  21 +-
>  xen/include/public/domctl.h         |   4 +-
>  xen/include/xen/hypercall.h         |  11 ++
>  xen/include/xen/pci.h               |   5 +-
>  39 files changed, 1238 insertions(+), 65 deletions(-)
>  create mode 100644 xen/arch/arm/pci/ecam.c
>  create mode 100644 xen/arch/arm/pci/pci-access.c
>  create mode 100644 xen/arch/arm/pci/pci-host-common.c
>  create mode 100644 xen/arch/arm/pci/pci-host-generic.c
>  create mode 100644 xen/arch/arm/pci/pci-host-zynqmp.c
>  create mode 100644 xen/arch/arm/vpci.c
>  create mode 100644 xen/arch/arm/vpci.h
>  create mode 100644 xen/drivers/pci/physdev.c
> 
> -- 
> 2.25.1
> 


From xen-devel-bounces@lists.xenproject.org Tue Oct 05 00:57:47 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Oct 2021 00:57:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.201853.356489 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXYmB-0001Pc-CS; Tue, 05 Oct 2021 00:57:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 201853.356489; Tue, 05 Oct 2021 00:57:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXYmB-0001PT-92; Tue, 05 Oct 2021 00:57:47 +0000
Received: by outflank-mailman (input) for mailman id 201853;
 Tue, 05 Oct 2021 00:57:46 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+0nn=OZ=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1mXYmA-0001Oo-1E
 for xen-devel@lists.xenproject.org; Tue, 05 Oct 2021 00:57:46 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 40245a20-2577-11ec-bec4-12813bfff9fa;
 Tue, 05 Oct 2021 00:57:45 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id 363696140B;
 Tue,  5 Oct 2021 00:57:44 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 40245a20-2577-11ec-bec4-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1633395464;
	bh=PrNXBNszwWDc2/Ya6RS7TEevhzR3nEWnHU7H6WQvUCw=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=OIcrMmmaeaVRe9KJKh7U5UmnsA057Fp2598gFKi60HhSLfLwWl1uvaTHULAWNOyka
	 /VK0HKN5fI39AebI4mRUy5gqgrJC+qeQ4eFFvLK0z58eEvJYy/Ppcr5v/qtplbo61x
	 kYJlGlwhfjQJc3SQK1UsfgXCpq6/DTnpxO0qH5lHJqQGAoh6oFelpGNJ0USq/OQzuN
	 n8mUfQDMILPl85CEN7/1yp61huutFadn+xlNDwJz96WKN6ib8ts2EaWJSTaUmpw+JU
	 tr/ej5sUQdV6z3a8Z9dfZSJ9vZUHRePa40Qqy4FzBA0sb0+UiH8TNHWR/Opd98a33b
	 p36wY4W8jDmPg==
Date: Mon, 4 Oct 2021 17:57:43 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Oleksandr Andrushchenko <andr2000@gmail.com>
cc: xen-devel@lists.xenproject.org, julien@xen.org, sstabellini@kernel.org, 
    oleksandr_tyshchenko@epam.com, volodymyr_babchuk@epam.com, 
    Artem_Mygaiev@epam.com, roger.pau@citrix.com, jbeulich@suse.com, 
    andrew.cooper3@citrix.com, george.dunlap@citrix.com, paul@xen.org, 
    bertrand.marquis@arm.com, rahul.singh@arm.com, 
    Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>, 
    Michal Orzel <michal.orzel@arm.com>
Subject: Re: [PATCH v4 01/11] xen/arm: Fix dev_is_dt macro definition
In-Reply-To: <20211004141151.132231-2-andr2000@gmail.com>
Message-ID: <alpine.DEB.2.21.2110041757350.3209@sstabellini-ThinkPad-T480s>
References: <20211004141151.132231-1-andr2000@gmail.com> <20211004141151.132231-2-andr2000@gmail.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Mon, 4 Oct 2021, Oleksandr Andrushchenko wrote:
> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> 
> This macro is not currently used, but still has an error in it:
> a missing parenthesis. Fix this, so the macro is properly defined.
> 
> Fixes: 6c5d3075d97e ("xen/arm: Introduce a generic way to describe device")
> 
> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
> Reviewed-by: Michal Orzel <michal.orzel@arm.com>

I committed this patch


> ---
> New in v2
> ---
>  xen/include/asm-arm/device.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/xen/include/asm-arm/device.h b/xen/include/asm-arm/device.h
> index 5ecd5e7bd15e..ebe84ea853cd 100644
> --- a/xen/include/asm-arm/device.h
> +++ b/xen/include/asm-arm/device.h
> @@ -27,7 +27,7 @@ typedef struct device device_t;
>  
>  /* TODO: Correctly implement dev_is_pci when PCI is supported on ARM */
>  #define dev_is_pci(dev) ((void)(dev), 0)
> -#define dev_is_dt(dev)  ((dev->type == DEV_DT)
> +#define dev_is_dt(dev)  ((dev)->type == DEV_DT)
>  
>  enum device_class
>  {
> -- 
> 2.25.1
> 


From xen-devel-bounces@lists.xenproject.org Tue Oct 05 01:24:22 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Oct 2021 01:24:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.201891.356534 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXZBl-0004T7-4P; Tue, 05 Oct 2021 01:24:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 201891.356534; Tue, 05 Oct 2021 01:24:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXZBl-0004T0-12; Tue, 05 Oct 2021 01:24:13 +0000
Received: by outflank-mailman (input) for mailman id 201891;
 Tue, 05 Oct 2021 01:24:11 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+0nn=OZ=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1mXZBj-0004St-7x
 for xen-devel@lists.xenproject.org; Tue, 05 Oct 2021 01:24:11 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id f0691b5c-257a-11ec-bec4-12813bfff9fa;
 Tue, 05 Oct 2021 01:24:09 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id 48F3E61163;
 Tue,  5 Oct 2021 01:24:08 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f0691b5c-257a-11ec-bec4-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1633397048;
	bh=sZ4BNQbKMvlZ8RiQrEIduUbVXZNWsnIZNs2UFVHpPYY=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=kXL5EUNbyd8VXlSwOkVUE6DeOa5lj8soVHWsBXlKbzKPhto3mwtOigmxghmQ2yc8W
	 Jc2x/4CsGmg68THHP/d97hEtGYFaAbbRvW3kDlDayFVdO1Oxz8pbM2hc8/GPx1pHWQ
	 XmwhBgwQ9ZyioCbyOvF9zdKbdFlsYNQK+LTff08hIsxyVmVKk/6LBFsugGIBUS9Z9C
	 R2ANmb42FkLnFvfqDRnnfI7J5lIvLbgzoH/rZMxOJ896ZAA75NKaAHXLRiWHVfKP0s
	 x4/mLblRHZkE3kzr0F1sCaZ2IHfz61dxGo5Cyp6M38zNqT5awhVJGYi/rXpe9Dx0kZ
	 Mrr6NIQFnoBJg==
Date: Mon, 4 Oct 2021 18:24:06 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Oleksandr Andrushchenko <andr2000@gmail.com>
cc: xen-devel@lists.xenproject.org, julien@xen.org, sstabellini@kernel.org, 
    oleksandr_tyshchenko@epam.com, volodymyr_babchuk@epam.com, 
    Artem_Mygaiev@epam.com, roger.pau@citrix.com, jbeulich@suse.com, 
    andrew.cooper3@citrix.com, george.dunlap@citrix.com, paul@xen.org, 
    bertrand.marquis@arm.com, rahul.singh@arm.com, 
    Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Subject: Re: [PATCH v4 10/11] xen/arm: Do not map PCI ECAM and MMIO space to
 Domain-0's p2m
In-Reply-To: <20211004141151.132231-11-andr2000@gmail.com>
Message-ID: <alpine.DEB.2.21.2110041812270.3209@sstabellini-ThinkPad-T480s>
References: <20211004141151.132231-1-andr2000@gmail.com> <20211004141151.132231-11-andr2000@gmail.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Mon, 4 Oct 2021, Oleksandr Andrushchenko wrote:
> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> 
> PCI host bridges are special devices in terms of implementing PCI
> passthrough. According to [1] the current implementation depends on
> Domain-0 to perform the initialization of the relevant PCI host
> bridge hardware and perform PCI device enumeration. In order to
> achieve that one of the required changes is to not map all the memory
> ranges in map_range_to_domain as we traverse the device tree on startup
> and perform some additional checks if the range needs to be mapped to
> Domain-0.
> 
> The generic PCI host controller device tree binding says [2]:
> - ranges: As described in IEEE Std 1275-1994, but must provide
>           at least a definition of non-prefetchable memory. One
>           or both of prefetchable Memory and IO Space may also
>           be provided.
> 
> - reg   : The Configuration Space base address and size, as accessed
>           from the parent bus.  The base address corresponds to
>           the first bus in the "bus-range" property.  If no
>           "bus-range" is specified, this will be bus 0 (the default).
> 
> >From the above none of the memory ranges from the "ranges" property
> needs to be mapped to Domain-0 at startup as MMIO mapping is going to
> be handled dynamically by vPCI as we assign PCI devices, e.g. each
> device assigned to Domain-0/guest will have its MMIOs mapped/unmapped
> as needed by Xen.
> 
> The "reg" property covers not only ECAM space, but may also have other
> then the configuration memory ranges described, for example [3]:
> - reg: Should contain rc_dbi, config registers location and length.
> - reg-names: Must include the following entries:
>    "rc_dbi": controller configuration registers;
>    "config": PCIe configuration space registers.
> 
> This patch makes it possible to not map all the ranges from the
> "ranges" property and also ECAM from the "reg". All the rest from the
> "reg" property still needs to be mapped to Domain-0, so the PCI
> host bridge remains functional in Domain-0.
> 
> [1] https://lists.xenproject.org/archives/html/xen-devel/2020-07/msg00777.html
> [2] https://www.kernel.org/doc/Documentation/devicetree/bindings/pci/host-generic-pci.txt
> [3] https://www.kernel.org/doc/Documentation/devicetree/bindings/pci/hisilicon-pcie.txt
> 
> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> ---
> Since v3:
>  - pass struct map_range_data to map_dt_irq_to_domain
>  - remove redundant check from map_range_to_domain
>  - fix handle_device's .skip_mapping
> Since v2:
>  - removed check in map_range_to_domain for PCI_DEV
>    and moved it to handle_device, so the code is
>    simpler
>  - s/map_pci_bridge/skip_mapping
>  - extended comment in pci_host_bridge_mappings
>  - minor code restructure in construct_dom0
>  - s/.need_p2m_mapping/.need_p2m_hwdom_mapping and related
>    callbacks
>  - unsigned int i; in pci_host_bridge_mappings
> Since v1:
>  - Added better description of why and what needs to be mapped into
>    Domain-0's p2m and what doesn't
>  - Do not do any mappings for PCI devices while traversing the DT
>  - Walk all the bridges and make required mappings in one go
> ---
>  xen/arch/arm/domain_build.c        | 50 ++++++++++++++++--------------
>  xen/arch/arm/pci/ecam.c            | 14 +++++++++
>  xen/arch/arm/pci/pci-host-common.c | 49 +++++++++++++++++++++++++++++
>  xen/arch/arm/pci/pci-host-zynqmp.c |  1 +
>  xen/include/asm-arm/pci.h          | 10 ++++++
>  xen/include/asm-arm/setup.h        | 13 ++++++++
>  6 files changed, 114 insertions(+), 23 deletions(-)
> 
> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
> index 8739e3285ef4..2a3c641476bd 100644
> --- a/xen/arch/arm/domain_build.c
> +++ b/xen/arch/arm/domain_build.c
> @@ -10,7 +10,6 @@
>  #include <asm/regs.h>
>  #include <xen/errno.h>
>  #include <xen/err.h>
> -#include <xen/device_tree.h>
>  #include <xen/libfdt/libfdt.h>
>  #include <xen/guest_access.h>
>  #include <xen/iocap.h>
> @@ -51,12 +50,6 @@ static int __init parse_dom0_mem(const char *s)
>  }
>  custom_param("dom0_mem", parse_dom0_mem);
>  
> -struct map_range_data
> -{
> -    struct domain *d;
> -    p2m_type_t p2mt;
> -};
> -
>  /* Override macros from asm/page.h to make them work with mfn_t */
>  #undef virt_to_mfn
>  #define virt_to_mfn(va) _mfn(__virt_to_mfn(va))
> @@ -1641,10 +1634,11 @@ static int __init map_dt_irq_to_domain(const struct dt_device_node *dev,
>                                         const struct dt_irq *dt_irq,
>                                         void *data)
>  {
> -    struct domain *d = data;
> +    struct map_range_data *mr_data = data;
> +    struct domain *d = mr_data->d;
>      unsigned int irq = dt_irq->irq;
>      int res;
> -    bool need_mapping = !dt_device_for_passthrough(dev);
> +    bool need_mapping = !mr_data->skip_mapping;
>  
>      if ( irq < NR_LOCAL_IRQS )
>      {
> @@ -1668,13 +1662,12 @@ static int __init map_dt_irq_to_domain(const struct dt_device_node *dev,
>      return 0;
>  }
>  
> -static int __init map_range_to_domain(const struct dt_device_node *dev,
> -                                      u64 addr, u64 len,
> -                                      void *data)
> +int __init map_range_to_domain(const struct dt_device_node *dev,
> +                               u64 addr, u64 len, void *data)
>  {
>      struct map_range_data *mr_data = data;
>      struct domain *d = mr_data->d;
> -    bool need_mapping = !dt_device_for_passthrough(dev);
> +    bool need_mapping = !mr_data->skip_mapping;
>      int res;
>  
>      /*
> @@ -1726,23 +1719,21 @@ static int __init map_range_to_domain(const struct dt_device_node *dev,
>   * then we may need to perform additional mappings in order to make
>   * the child resources available to domain 0.
>   */
> -static int __init map_device_children(struct domain *d,
> -                                      const struct dt_device_node *dev,
> -                                      p2m_type_t p2mt)
> +static int __init map_device_children(const struct dt_device_node *dev,
> +                                      struct map_range_data *mr_data)
>  {
> -    struct map_range_data mr_data = { .d = d, .p2mt = p2mt };
> -    int ret;
> -
>      if ( dt_device_type_is_equal(dev, "pci") )
>      {
> +        int ret;
> +
>          dt_dprintk("Mapping children of %s to guest\n",
>                     dt_node_full_name(dev));
>  
> -        ret = dt_for_each_irq_map(dev, &map_dt_irq_to_domain, d);
> +        ret = dt_for_each_irq_map(dev, &map_dt_irq_to_domain, mr_data);
>          if ( ret < 0 )
>              return ret;
>  
> -        ret = dt_for_each_range(dev, &map_range_to_domain, &mr_data);
> +        ret = dt_for_each_range(dev, &map_range_to_domain, mr_data);
>          if ( ret < 0 )
>              return ret;
>      }
> @@ -1823,6 +1814,13 @@ static int __init handle_device(struct domain *d, struct dt_device_node *dev,
>      int res;
>      u64 addr, size;
>      bool need_mapping = !dt_device_for_passthrough(dev);
> +    struct map_range_data mr_data = {
> +        .d = d,
> +        .p2mt = p2mt,
> +        .skip_mapping = !need_mapping ||
> +                        (is_pci_passthrough_enabled() &&
> +                         (device_get_class(dev) == DEVICE_PCI))
> +    };

I would prefer if we did this:

diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
index 2a3c641476..1e7cdd11c7 100644
--- a/xen/arch/arm/domain_build.c
+++ b/xen/arch/arm/domain_build.c
@@ -1813,13 +1813,13 @@ static int __init handle_device(struct domain *d, struct dt_device_node *dev,
     unsigned int i;
     int res;
     u64 addr, size;
-    bool need_mapping = !dt_device_for_passthrough(dev);
+    bool need_mapping = !dt_device_for_passthrough(dev) &&
+                        !(is_pci_passthrough_enabled() &&
+                          (device_get_class(dev) == DEVICE_PCI))
     struct map_range_data mr_data = {
         .d = d,
         .p2mt = p2mt,
-        .skip_mapping = !need_mapping ||
-                        (is_pci_passthrough_enabled() &&
-                         (device_get_class(dev) == DEVICE_PCI))
+        .skip_mapping = !need_mapping
     };
 
     naddr = dt_number_of_address(dev);


This actually makes a difference because otherwise
handle_device_interrupts could still be called with need_mapping ==
true for PCI devices.

What do you think?  One more comment below.


>      naddr = dt_number_of_address(dev);
>  
> @@ -1862,7 +1860,6 @@ static int __init handle_device(struct domain *d, struct dt_device_node *dev,
>      /* Give permission and map MMIOs */
>      for ( i = 0; i < naddr; i++ )
>      {
> -        struct map_range_data mr_data = { .d = d, .p2mt = p2mt };
>          res = dt_device_get_address(dev, i, &addr, &size);
>          if ( res )
>          {
> @@ -1876,7 +1873,7 @@ static int __init handle_device(struct domain *d, struct dt_device_node *dev,
>              return res;
>      }
>  
> -    res = map_device_children(d, dev, p2mt);
> +    res = map_device_children(dev, &mr_data);
>      if ( res )
>          return res;
>  
> @@ -3034,7 +3031,14 @@ static int __init construct_dom0(struct domain *d)
>          return rc;
>  
>      if ( acpi_disabled )
> +    {
>          rc = prepare_dtb_hwdom(d, &kinfo);
> +        if ( rc < 0 )
> +            return rc;
> +#ifdef CONFIG_HAS_PCI
> +        rc = pci_host_bridge_mappings(d, p2m_mmio_direct_c);
> +#endif
> +    }
>      else
>          rc = prepare_acpi(d, &kinfo);
>  
> diff --git a/xen/arch/arm/pci/ecam.c b/xen/arch/arm/pci/ecam.c
> index 602d00799c8d..b81620074a91 100644
> --- a/xen/arch/arm/pci/ecam.c
> +++ b/xen/arch/arm/pci/ecam.c
> @@ -40,6 +40,19 @@ void __iomem *pci_ecam_map_bus(struct pci_host_bridge *bridge,
>      return base + (PCI_DEVFN2(sbdf.bdf) << devfn_shift) + where;
>  }
>  
> +bool pci_ecam_need_p2m_hwdom_mapping(struct domain *d,
> +                                     struct pci_host_bridge *bridge,
> +                                     uint64_t addr)
> +{
> +    struct pci_config_window *cfg = bridge->cfg;
> +
> +    /*
> +     * We do not want ECAM address space to be mapped in Domain-0's p2m,
> +     * so we can trap access to it.
> +     */
> +    return cfg->phys_addr != addr;
> +}
> +
>  /* ECAM ops */
>  const struct pci_ecam_ops pci_generic_ecam_ops = {
>      .bus_shift  = 20,
> @@ -47,6 +60,7 @@ const struct pci_ecam_ops pci_generic_ecam_ops = {
>          .map_bus                = pci_ecam_map_bus,
>          .read                   = pci_generic_config_read,
>          .write                  = pci_generic_config_write,
> +        .need_p2m_hwdom_mapping = pci_ecam_need_p2m_hwdom_mapping,
>      }
>  };
>  
> diff --git a/xen/arch/arm/pci/pci-host-common.c b/xen/arch/arm/pci/pci-host-common.c
> index 1eb4daa87365..085f08e23e0c 100644
> --- a/xen/arch/arm/pci/pci-host-common.c
> +++ b/xen/arch/arm/pci/pci-host-common.c
> @@ -18,6 +18,7 @@
>  
>  #include <xen/init.h>
>  #include <xen/pci.h>
> +#include <asm/setup.h>
>  #include <xen/rwlock.h>
>  #include <xen/sched.h>
>  #include <xen/vmap.h>
> @@ -320,6 +321,54 @@ int pci_host_get_num_bridges(void)
>      return count;
>  }
>  
> +int __init pci_host_bridge_mappings(struct domain *d, p2m_type_t p2mt)
> +{
> +    struct pci_host_bridge *bridge;
> +    struct map_range_data mr_data = {
> +        .d = d,
> +        .p2mt = p2mt,
> +        .skip_mapping = false
> +    };
> +
> +    /*
> +     * For each PCI host bridge we need to only map those ranges
> +     * which are used by Domain-0 to properly initialize the bridge,
> +     * e.g. we do not want to map ECAM configuration space which lives in
> +     * "reg" or "assigned-addresses" device tree property, but we want to
> +     * map other regions of the host bridge. The PCI aperture defined by
> +     * the "ranges" device tree property should also be skipped.
> +     */
> +    list_for_each_entry( bridge, &pci_host_bridges, node )
> +    {
> +        const struct dt_device_node *dev = bridge->dt_node;
> +        unsigned int i;
> +
> +        for ( i = 0; i < dt_number_of_address(dev); i++ )
> +        {
> +            uint64_t addr, size;
> +            int err;
> +
> +            err = dt_device_get_address(dev, i, &addr, &size);
> +            if ( err )
> +            {
> +                printk(XENLOG_ERR
> +                       "Unable to retrieve address range index=%u for %s\n",
> +                       i, dt_node_full_name(dev));
> +                return err;
> +            }
> +
> +            if ( bridge->ops->need_p2m_hwdom_mapping(d, bridge, addr) )
> +            {
> +                err = map_range_to_domain(dev, addr, size, &mr_data);
> +                if ( err )
> +                    return err;
> +            }
> +        }
> +    }
> +
> +    return 0;
> +}
> +
>  /*
>   * Local variables:
>   * mode: C
> diff --git a/xen/arch/arm/pci/pci-host-zynqmp.c b/xen/arch/arm/pci/pci-host-zynqmp.c
> index 61a9807d3d58..6ad2b31e810d 100644
> --- a/xen/arch/arm/pci/pci-host-zynqmp.c
> +++ b/xen/arch/arm/pci/pci-host-zynqmp.c
> @@ -34,6 +34,7 @@ const struct pci_ecam_ops nwl_pcie_ops = {
>          .map_bus                = pci_ecam_map_bus,
>          .read                   = pci_generic_config_read,
>          .write                  = pci_generic_config_write,
> +        .need_p2m_hwdom_mapping = pci_ecam_need_p2m_hwdom_mapping,
>      }
>  };
>  
> diff --git a/xen/include/asm-arm/pci.h b/xen/include/asm-arm/pci.h
> index a62d8bc60086..d9a3c2a4f3b3 100644
> --- a/xen/include/asm-arm/pci.h
> +++ b/xen/include/asm-arm/pci.h
> @@ -17,6 +17,8 @@
>  
>  #ifdef CONFIG_HAS_PCI
>  
> +#include <asm/p2m.h>
> +
>  #define pci_to_dev(pcidev) (&(pcidev)->arch.dev)
>  
>  extern bool_t pci_passthrough_enabled;
> @@ -73,6 +75,9 @@ struct pci_ops {
>                  uint32_t reg, uint32_t len, uint32_t *value);
>      int (*write)(struct pci_host_bridge *bridge, pci_sbdf_t sbdf,
>                   uint32_t reg, uint32_t len, uint32_t value);
> +    bool (*need_p2m_hwdom_mapping)(struct domain *d,
> +                                   struct pci_host_bridge *bridge,
> +                                   uint64_t addr);
>  };
>  
>  /*
> @@ -96,6 +101,9 @@ int pci_generic_config_write(struct pci_host_bridge *bridge, pci_sbdf_t sbdf,
>                               uint32_t reg, uint32_t len, uint32_t value);
>  void __iomem *pci_ecam_map_bus(struct pci_host_bridge *bridge,
>                                 pci_sbdf_t sbdf, uint32_t where);
> +bool pci_ecam_need_p2m_hwdom_mapping(struct domain *d,
> +                                     struct pci_host_bridge *bridge,
> +                                     uint64_t addr);
>  struct pci_host_bridge *pci_find_host_bridge(uint16_t segment, uint8_t bus);
>  int pci_get_host_bridge_segment(const struct dt_device_node *node,
>                                  uint16_t *segment);
> @@ -113,6 +121,8 @@ int pci_host_iterate_bridges(struct domain *d,
>                                          struct pci_host_bridge *bridge));
>  int pci_host_get_num_bridges(void);
>  
> +int pci_host_bridge_mappings(struct domain *d, p2m_type_t p2mt);
> +
>  #else   /*!CONFIG_HAS_PCI*/
>  
>  struct arch_pci_dev { };
> diff --git a/xen/include/asm-arm/setup.h b/xen/include/asm-arm/setup.h
> index 95da0b7ab9cd..5b30135fda38 100644
> --- a/xen/include/asm-arm/setup.h
> +++ b/xen/include/asm-arm/setup.h
> @@ -2,6 +2,8 @@
>  #define __ARM_SETUP_H_
>  
>  #include <public/version.h>
> +#include <asm/p2m.h>
> +#include <xen/device_tree.h>
>  
>  #define MIN_FDT_ALIGN 8
>  #define MAX_FDT_SIZE SZ_2M
> @@ -77,6 +79,14 @@ struct bootinfo {
>  #endif
>  };
>  
> +struct map_range_data
> +{
> +    struct domain *d;
> +    p2m_type_t p2mt;
> +    /* Set if mappings for PCI host bridges must not be skipped. */

This comment still needs updating.


> +    bool skip_mapping;
> +};
> +
>  extern struct bootinfo bootinfo;
>  
>  extern domid_t max_init_domid;
> @@ -124,6 +134,9 @@ void device_tree_get_reg(const __be32 **cell, u32 address_cells,
>  u32 device_tree_get_u32(const void *fdt, int node,
>                          const char *prop_name, u32 dflt);
>  
> +int map_range_to_domain(const struct dt_device_node *dev,
> +                        u64 addr, u64 len, void *data);
> +
>  #endif
>  /*
>   * Local variables:
> -- 
> 2.25.1
> 


From xen-devel-bounces@lists.xenproject.org Tue Oct 05 01:26:22 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Oct 2021 01:26:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.201901.356544 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXZDp-00058l-KN; Tue, 05 Oct 2021 01:26:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 201901.356544; Tue, 05 Oct 2021 01:26:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXZDp-00058e-HP; Tue, 05 Oct 2021 01:26:21 +0000
Received: by outflank-mailman (input) for mailman id 201901;
 Tue, 05 Oct 2021 01:26:20 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+0nn=OZ=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1mXZDo-00058W-G0
 for xen-devel@lists.xenproject.org; Tue, 05 Oct 2021 01:26:20 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 3e18049e-257b-11ec-bec4-12813bfff9fa;
 Tue, 05 Oct 2021 01:26:19 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id ED78161406;
 Tue,  5 Oct 2021 01:26:18 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3e18049e-257b-11ec-bec4-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1633397179;
	bh=fphcFAyIr9Owp7rjYXg1gmcORGGWpJyRFdOdnO36iIY=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=CKjCii2P955VGT+LsEXyUkw7Bt5BvgldS1iD46j8NX0aKolKxhrTr8HdWZzc9nft2
	 QDRXFJQ5FBTbCAYBsWr6FoH8hAbE3widBayb5bh3oW6UaWilxyZvi655jLpBguoaWE
	 q1Qu5Hm4rW0k29YzH6MFsPGQOo7XifnkIV2llqGG99S5rOgrhAnqY6f2DjuKPtgTsn
	 fWAOMXjgu12t540qNx4XT4W3iwBfLLfmWRhWEJQeeDdfYSigp8Hu7yimBzSVKyjyvQ
	 cFC72bOUK6cQaHuXKuAxFu053+VsBVBVY/9oQlAJIcpSxekduN6rp4zTJw7+HK3eGV
	 BuC2UuKA1DJLg==
Date: Mon, 4 Oct 2021 18:26:17 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Ian Jackson <iwj@xenproject.org>
cc: xen-devel@lists.xenproject.org, jbeulich@suse.com, 
    julien.grall.oss@gmail.com, sstabellini@kernel.org, 
    dpsmith@apertussolutions.com
Subject: Re: [adhoc test] 165359: tolerable truncated
In-Reply-To: <24923.38127.990669.853370@mariner.uk.xensource.com>
Message-ID: <alpine.DEB.2.21.2110041824350.3209@sstabellini-ThinkPad-T480s>
References: <E1mXTS5-00046z-9X@osstest.test-lab.xenproject.org> <24923.38127.990669.853370@mariner.uk.xensource.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Tue, 5 Oct 2021, Ian Jackson wrote:
> iwj@xenbits.xen.org writes ("[adhoc test] 165359: tolerable truncated"):
> > [adhoc play] <testing.git master not a tty>
> > harness 3a3089c9: mfi-common: Drop Linux dom0 i386 tests for newer Lin...
> > 165359: tolerable truncated
> ...
> > Tests which did not succeed, but are not blocking:
> >  test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail  like 165218
> >  test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail  like 165218
> 
> This means that the kernel patch fixed the problem.  Nothing went
> wrong here other than that arm64 doesn't support save/restore and
> migraiton.

Fantastic! Let me know if you would like my help updating the Linux
kernel tree for ARM [1].


[1] git://xenbits.xen.org/arm/linux.git:linux-arm-xen


From xen-devel-bounces@lists.xenproject.org Tue Oct 05 02:13:47 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Oct 2021 02:13:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.201986.356628 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXZxg-0006Vg-P8; Tue, 05 Oct 2021 02:13:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 201986.356628; Tue, 05 Oct 2021 02:13:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXZxg-0006VZ-LN; Tue, 05 Oct 2021 02:13:44 +0000
Received: by outflank-mailman (input) for mailman id 201986;
 Tue, 05 Oct 2021 02:13:43 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mXZxf-0006VJ-H8; Tue, 05 Oct 2021 02:13:43 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mXZxf-0000Fp-Ah; Tue, 05 Oct 2021 02:13:43 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mXZxe-000234-Vs; Tue, 05 Oct 2021 02:13:43 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mXZxe-0007Cd-Tn; Tue, 05 Oct 2021 02:13:42 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=aD9OHCO5myUl8QGu//8/3a10c/q6Kd+xJeeywIVsgzU=; b=3m8BpSGu+RTy2l2+TUmcMjlCaO
	ZgOlPBOypgFT/Le29l1NaEDarkTqQQqw2D/Voma5kPEe+jptYdpcXyemNjrMbVOrM3f609zC0KOj4
	Lm63ji77s2Y0McirGSROLUGLw0GWpfmLRIE4EKdeqZLhLK4zV5w5HoIxaKiK92+GfffM=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165344-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 165344: regressions - FAIL
X-Osstest-Failures:
    xen-unstable:test-arm64-arm64-libvirt-raw:guest-start/debian.repeat:fail:regression
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=ab4a83023eda9f04ad864877c1956b087ec6fc4f
X-Osstest-Versions-That:
    xen=c76cfada1cfad05aaf64ce3ad305c5467650e782
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 05 Oct 2021 02:13:42 +0000

flight 165344 xen-unstable real [real]
flight 165370 xen-unstable real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/165344/
http://logs.test-lab.xenproject.org/osstest/logs/165370/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-arm64-arm64-libvirt-raw 17 guest-start/debian.repeat fail REGR. vs. 164945

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 164945
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 164945
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 164945
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 164945
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 164945
 test-armhf-armhf-xl-rtds     18 guest-start/debian.repeat    fail  like 164945
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 164945
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 164945
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 164945
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 164945
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 164945
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 164945
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 164945
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  ab4a83023eda9f04ad864877c1956b087ec6fc4f
baseline version:
 xen                  c76cfada1cfad05aaf64ce3ad305c5467650e782

Last test of basis   164945  2021-09-10 21:23:48 Z   24 days
Failing since        164951  2021-09-12 00:14:36 Z   23 days   37 attempts
Testing same since   165327  2021-09-30 05:56:17 Z    4 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Anthony PERARD <anthony.perard@citrix.com>
  Bertrand Marquis <bertrand.marquis@arm.com>
  Daniel P. Smith <dpsmith@apertussolutions.com>
  Ian Jackson <iwj@xenproject.org>
  Igor Druzhinin <igor.druzhinin@citrix.com>
  Jan Beulich <jbeulich@suse.com>
  Juergen Gross <jgross@suse.com>
  Julien Grall <jgrall@amazon.com>
  Kevin Stefanov <kevin.stefanov@citrix.com>
  Nick Rosbrook <rosbrookn@ainfosec.com>
  Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
  Penny Zheng <penny.zheng@arm.com>
  Roger Pau Monne <roger.pau@citrix.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Stefano Stabellini <sstabellini@kernel.org>
  Stefano Stabellini <stefano.stabellini@xilinx.com>
  Tamas K Lengyel <tamas.lengyel@intel.com>
  Wei Chen <wei.chen@arm.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 fail    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 1151 lines long.)


From xen-devel-bounces@lists.xenproject.org Tue Oct 05 04:33:02 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Oct 2021 04:33:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.201997.356642 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXc8E-0002fH-3Q; Tue, 05 Oct 2021 04:32:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 201997.356642; Tue, 05 Oct 2021 04:32:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXc8E-0002fA-0G; Tue, 05 Oct 2021 04:32:46 +0000
Received: by outflank-mailman (input) for mailman id 201997;
 Tue, 05 Oct 2021 04:32:44 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=p2+O=OZ=epam.com=prvs=0912e3e650=oleksandr_andrushchenko@srs-us1.protection.inumbo.net>)
 id 1mXc8C-0002el-DT
 for xen-devel@lists.xenproject.org; Tue, 05 Oct 2021 04:32:44 +0000
Received: from mx0a-0039f301.pphosted.com (unknown [148.163.133.242])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 4779167b-b961-4ffc-b9e7-ffb73c9751ef;
 Tue, 05 Oct 2021 04:32:41 +0000 (UTC)
Received: from pps.filterd (m0174677.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 1954EhFn023677; 
 Tue, 5 Oct 2021 04:32:39 GMT
Received: from eur05-am6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2106.outbound.protection.outlook.com [104.47.18.106])
 by mx0a-0039f301.pphosted.com with ESMTP id 3bgfgar16a-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Tue, 05 Oct 2021 04:32:39 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by AM0PR03MB5940.eurprd03.prod.outlook.com (2603:10a6:208:15a::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.19; Tue, 5 Oct
 2021 04:32:35 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::e966:6290:5736:b7bd]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::e966:6290:5736:b7bd%7]) with mapi id 15.20.4566.022; Tue, 5 Oct 2021
 04:32:35 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4779167b-b961-4ffc-b9e7-ffb73c9751ef
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=bsW++0HO13JeQok5rcqrIJqPIjypFucVK+kFv6Rc6hJ4qr1+S5OmjM6S0ngitVV9VXac9mvao+B1sKeSRLSakiD9gd0vMNfJw6NJnQ75Q/ES5ZRHhLUA+0QpjMx15R3iSvgVuq/VTHYzjh6A8eOBlBTboCKvh61odTm69b+KemU+Zy2s5Tcct732wwLWcjcqejE4LPOgXHUdgYCOJAZWhm4fJvU3xdjRMsQJcAYSVIyyDgqrJvmkXGpZKqv6AT0U9o2J3l8fSSbK9mrat5WsF/WVs1Q2LnULbfWmCa9GoCib66NDMO+8HbV2kN/F+ro8kSGnCNsjIetGEsdvwextqA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=9uxkSi5IHwoug/1d+a5HId+ZXNEfLsZX93PWcZU0Eso=;
 b=LstWLwN93wpC7I6H6a2lmorRFaQV5s0qKqFNZnIZidVCV4nmeF9A8QIJVHzuwLsUPXUENelflCQrgDrswdFEBgnMIMnUxhra/R5ytlir2dQrZ3RCPDSchvzCWFgqLfCZMUHm5a4caasAC8kYk7eF7lxcaM9xL//ze0z25LqyszE1sb97YxDLe4o9e7LvSZ+M1QHZoAUDZPgxHhYgAzXzzbjmC6smWGsGMvHSjOruO2nTYUdm3KJlt+suhx9fHMafnCAkzIiPbzX/lpocUA/iA4C37wprU+mm657y44hOfEHPegttlUKagWbHwtr/CRXtAU/K+Cmz2doW/Odw/gVeqA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=9uxkSi5IHwoug/1d+a5HId+ZXNEfLsZX93PWcZU0Eso=;
 b=ELufdl9MQWJ2eDyeTM034ajHyk80eFIcGNmUK5AGwYjt53fl3NjT1IUuTC3rKxUxJOR/7nXNWegpQWeHH9cDaUBMSFvsH3KXNxfHkUiURBHNeaZfewtEordeq/RJdLjztc10rC7rLrAq6JA68sfinmegRLiF4qOHB9FBNIZ0yRc0irHqkfH8iPglnbX63XD8jlpGLdMqoPaN/unte2MJNQ4UK7Uw02/G3/q+X/CE7BbkxOPXpX1bUYva1965VTlxAKHCQDk2hUjk1MWibyqXPxTiPxmDBvIAs5c11EaBkPYlMJF2Ut3XkiUuL/rCakJV16eTHA7NNz7caeLW+F9u/w==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Stefano Stabellini <sstabellini@kernel.org>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        "julien@xen.org" <julien@xen.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "roger.pau@citrix.com" <roger.pau@citrix.com>,
        "jbeulich@suse.com"
	<jbeulich@suse.com>,
        "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
        "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
        "paul@xen.org"
	<paul@xen.org>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Rahul Singh
	<rahul.singh@arm.com>,
        Oleksandr Andrushchenko
	<Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH v4 10/11] xen/arm: Do not map PCI ECAM and MMIO space to
 Domain-0's p2m
Thread-Topic: [PATCH v4 10/11] xen/arm: Do not map PCI ECAM and MMIO space to
 Domain-0's p2m
Thread-Index: AQHXuSnVYm3k8/clOk2qiNUr9gxPGKvDnQwAgAA0qQA=
Date: Tue, 5 Oct 2021 04:32:35 +0000
Message-ID: <7b42e2aa-658a-74a1-045a-a35fb89a37b0@epam.com>
References: <20211004141151.132231-1-andr2000@gmail.com>
 <20211004141151.132231-11-andr2000@gmail.com>
 <alpine.DEB.2.21.2110041812270.3209@sstabellini-ThinkPad-T480s>
In-Reply-To: <alpine.DEB.2.21.2110041812270.3209@sstabellini-ThinkPad-T480s>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
authentication-results: kernel.org; dkim=none (message not signed)
 header.d=none;kernel.org; dmarc=none action=none header.from=epam.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 12552a2c-617d-4bcb-cfb2-08d987b927e2
x-ms-traffictypediagnostic: AM0PR03MB5940:
x-ms-exchange-transport-forked: True
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <AM0PR03MB59407CBFA816AF2B0D1E338DE7AF9@AM0PR03MB5940.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:4125;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 vs8yslSQ3QzP3YP8b76VRvmG8I32BD31/qgxXFulylqDDtcFc2poWJUzhvKJPgFjcqFIe/4KSVIV+MCSi2IkfnvJ1ownTeDcil9gojhyq0k80HI7/sXM90Djl0VRT+4yb8gypOw+aZWwvonhtWKJ17qMF+Pp5QyH5XNOKc14Cxu0COY2jaGLGv/g8CtZcl2vsXXOvMMZTT8DDZhLGVQQPo9gOOd9NHh84/9Yokpb2ZGw/1rK/eqcf7jsTQcvXmO1wNY1eMf/xA0rQXCiHV0x6BxZIo84rciJk4NrXR7+TUENDjFBvgZhcH1M0n5CgkP6IzeOTRhrvnEQ9b+Az62tcrb10y5SHxBmdoSMj9+YP9w+rhYjsqzAqvK+n965YoM0vTHz8N3mYXToUaXD2YN4XZyOEb3gtN8LcoVPhIwtyhTqfDBDY6GCuzhJzUtdkwea5E7lHgN6sVr4P8598NOFCPa3gjSORmsCJi+6V+3cCdyPGU7Um4c6MCpKYKX4UDkXywLK/KCl5m/jxcqqGjMYWjRh2b2yvH0Qh/XLOG23o9RWmqcIXuxFj5dPCG/h/ElnTN+Mb0ccCxEcKihy7EVUCq8I/PuAAjOKvZCWtPCpFT61YQWpZjiu6D6svvg99QtSjXZMTfeDxYOmNie4ZejAecGRXC9Rz4dlXUApLEGO0nGalhJJ7U7xuvipFjT31QuT7ml/o1f+pSBIEYc1m8gtwHjE/3r+a7uBQNp7v62pi1hNgDcuWzUejeGrVmOkzXXrLbfisp09nehTaqZRYkKFrhk5+D8ssPrSVFQhWBzYfLBG/yAZjxOByc6QtLG0kusjwgAa1UNn3sEonPEjSkr+TBxNlyJrAuk7OAe8NL5gprw=
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(316002)(66556008)(8936002)(6512007)(8676002)(53546011)(71200400001)(36756003)(2616005)(122000001)(66946007)(86362001)(26005)(66446008)(66476007)(91956017)(76116006)(38100700002)(31696002)(107886003)(6506007)(2906002)(6916009)(186003)(508600001)(64756008)(30864003)(966005)(31686004)(83380400001)(5660300002)(54906003)(6486002)(4326008)(7416002)(38070700005)(55236004)(39920500001)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?N09ueTRvQ0RuczBpVzJzdFdydERyNTRxM25hU3VFUXlrdkRTV1BobExTdXZ2?=
 =?utf-8?B?RzlPUzdydXRpUHdJL0pKNlV5VFVyVDRTcEkrTWZiQVRUeUlMaGdQb0tFNHNZ?=
 =?utf-8?B?QThiSUtDS0MwVHc1eDkzWkJuU3FuMVd6d2dVN1o1VXBmQ1FZaVZFSEI1b3Vy?=
 =?utf-8?B?NHZuTXlHOFg2ZVVMZmc2Q1Y0MEo5dk0xaHVOK2lsWnFpakpad3U4L0NsVUtk?=
 =?utf-8?B?eit5a1JKOHNzRGtnUjc0RW5zVTBJdllMall5eFBDZmk4R2dVWTdFcS9BNkZK?=
 =?utf-8?B?bGlTWkIvMDAzRkRCSDZZdEh5U3NVTXYvNVFjOURmTEsvQWZmY0dwRk91MUlK?=
 =?utf-8?B?Z3ZJTmt4dWM0dW5mM2RxOER4dE5XakhGZE1WanZkTlZsbDROVUhBTzkxNCsz?=
 =?utf-8?B?TTR0djJWc1QzRFR4YXI5Vmk2T0hFQys1TUVjQ282ZStVOWQ5RElic0JiTjhF?=
 =?utf-8?B?MkdEdGE0VTF2bUo4OGh1TnJvMTJEd3lrQ1NXWTBiRWs5NDBXNWNEM1Y1QktO?=
 =?utf-8?B?a3FBb05aQVZJSlFDZU1FdHIyREJRaVE3K1dQLzE2RWxRWWhKK20xeWJzQTFs?=
 =?utf-8?B?ZVVqb1ZSYVdvYWsrQjFnYi9PZUV0U01hemladDl6WjBRbjJJTVpiaXNXeS9D?=
 =?utf-8?B?UGk4U3ZTYXQvYjhaYTVpTWZPR3lKdG9MNENqblJoSVlHeWt0NXdEaGpRZ1VN?=
 =?utf-8?B?Tlllb0s5bTV1RlVzdUxyckJJbk1OdGFhQWIvRVk5L0l2Z3Q1KzFNL1B6MjE1?=
 =?utf-8?B?Nmo0ay9Jd29FSnB2eWJUVmlxRUF3Z2xUS1B1QU1nZERpVzlxaXdlWmg4VHVD?=
 =?utf-8?B?Z3ZvRFd5STZUQVJzZ0l4N2VkUlBRTitsZnFWUUNoWlBtUTF2MlZwQW1CbDhi?=
 =?utf-8?B?QTRiMnhSVkFleC9aTzlGUzBDV3RqeGV0SmZPc1VSUnNpbTh0UVFWZDhxayt2?=
 =?utf-8?B?dlRSQUQyd3FBTEwxcUlabGRmUnNJOXNKR1FpZUZaRS9ZdU1MQlYrUnJFUm1Y?=
 =?utf-8?B?YmdnQzQwbGtGeVpyemhoZ1pFclplRlJDUno5elRwM2x4UU5ield4K29LTXA5?=
 =?utf-8?B?M1dnVTY3VEFTVkwvVTlNajFwNWZZWTQ2VmVCWWpneDJ2TlN2UUtFbW9RNi91?=
 =?utf-8?B?Q3NXVGhodkNRNkgyajJYeDRwcjI4SlRlMjNaMFl1QXRXTTNSMW5TNUJLUXFp?=
 =?utf-8?B?TzZwQTBKT3Uramx5dmZuSEpyWndJWWpPYk1ZYnY2eHVkUElXK1k3a3NjemYr?=
 =?utf-8?B?MmE2dnV0TU1VZGpHMGtJTWlFU2x1MUU5ZHBFbjJ2MEM2Z0tQTEFORzdsRDFX?=
 =?utf-8?B?ellHV1dGejNkZWhUOUx5NjNYTER2UGE4RWdJWUlQVWNpeDlNVCs4MktQZklh?=
 =?utf-8?B?dFh4Sk92RzBZRDFJb3phQnN5OXdaRGFDQmRBTGsrZ2ovV09ONGd0cExpNHdS?=
 =?utf-8?B?L2hBdWYyWWNQMnYrTE5QcDJYR211Znp4V2ZBUkYwck5VSnB0VTdzVWZxbTRv?=
 =?utf-8?B?ZVVabndpc25pWTZVNExvamUzVTVSMENsSmc5UExQWFVoTVEwOEpVZ2l6Umh0?=
 =?utf-8?B?NmJHWFN6enpmVkp5VGo2SXQrc0crM2ZuNkdFWWFEUVhHTGtQdjREWHlhQ2tM?=
 =?utf-8?B?OCt4M0dMMkNIZUhHUCtBa3NZZHFDK0MxcUpJOFNwaUNSSC9HSXdDNlZlY3ZF?=
 =?utf-8?B?VG1ONWFMUlVEd0Z2UHh4Y0hNb21RVjRiSDJtczZ5SEJsb3I0dkNLZkpKbGZv?=
 =?utf-8?B?YUFlSDd5RHJlb1E0UnlqQzk1aFc3RU9iYXdXSnovL2VNZDV2YzdHUGdodE1p?=
 =?utf-8?B?QzRhUHFGZVdsQlpkczJNUT09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <9734B28A36439C4A834159793E6CB737@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 12552a2c-617d-4bcb-cfb2-08d987b927e2
X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Oct 2021 04:32:35.6186
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: kJLkz+LPgjAfAa4wrOx1WHWXeEpOH34y1aI3LDvZcr9n56K6TPFJ5AGUd0kFogdq3UBA9YYSiqy1LWlksD4hvMhZquMlvLR2q6i5fr452y+15CxjCULvug58SUtV6v1E
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR03MB5940
X-Proofpoint-GUID: Vs9_aT_JXgr3CH9oFTQN-II3KDWC0Vld
X-Proofpoint-ORIG-GUID: Vs9_aT_JXgr3CH9oFTQN-II3KDWC0Vld
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.391,FMLib:17.0.607.475
 definitions=2021-10-04_05,2021-10-04_01,2020-04-07_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0
 mlxlogscore=999 mlxscore=0 bulkscore=0 lowpriorityscore=0 clxscore=1015
 priorityscore=1501 adultscore=0 impostorscore=0 phishscore=0
 malwarescore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2109230001 definitions=main-2110050025

DQoNCk9uIDA1LjEwLjIxIDA0OjI0LCBTdGVmYW5vIFN0YWJlbGxpbmkgd3JvdGU6DQo+IE9uIE1v
biwgNCBPY3QgMjAyMSwgT2xla3NhbmRyIEFuZHJ1c2hjaGVua28gd3JvdGU6DQo+PiBGcm9tOiBP
bGVrc2FuZHIgQW5kcnVzaGNoZW5rbyA8b2xla3NhbmRyX2FuZHJ1c2hjaGVua29AZXBhbS5jb20+
DQo+Pg0KPj4gUENJIGhvc3QgYnJpZGdlcyBhcmUgc3BlY2lhbCBkZXZpY2VzIGluIHRlcm1zIG9m
IGltcGxlbWVudGluZyBQQ0kNCj4+IHBhc3N0aHJvdWdoLiBBY2NvcmRpbmcgdG8gWzFdIHRoZSBj
dXJyZW50IGltcGxlbWVudGF0aW9uIGRlcGVuZHMgb24NCj4+IERvbWFpbi0wIHRvIHBlcmZvcm0g
dGhlIGluaXRpYWxpemF0aW9uIG9mIHRoZSByZWxldmFudCBQQ0kgaG9zdA0KPj4gYnJpZGdlIGhh
cmR3YXJlIGFuZCBwZXJmb3JtIFBDSSBkZXZpY2UgZW51bWVyYXRpb24uIEluIG9yZGVyIHRvDQo+
PiBhY2hpZXZlIHRoYXQgb25lIG9mIHRoZSByZXF1aXJlZCBjaGFuZ2VzIGlzIHRvIG5vdCBtYXAg
YWxsIHRoZSBtZW1vcnkNCj4+IHJhbmdlcyBpbiBtYXBfcmFuZ2VfdG9fZG9tYWluIGFzIHdlIHRy
YXZlcnNlIHRoZSBkZXZpY2UgdHJlZSBvbiBzdGFydHVwDQo+PiBhbmQgcGVyZm9ybSBzb21lIGFk
ZGl0aW9uYWwgY2hlY2tzIGlmIHRoZSByYW5nZSBuZWVkcyB0byBiZSBtYXBwZWQgdG8NCj4+IERv
bWFpbi0wLg0KPj4NCj4+IFRoZSBnZW5lcmljIFBDSSBob3N0IGNvbnRyb2xsZXIgZGV2aWNlIHRy
ZWUgYmluZGluZyBzYXlzIFsyXToNCj4+IC0gcmFuZ2VzOiBBcyBkZXNjcmliZWQgaW4gSUVFRSBT
dGQgMTI3NS0xOTk0LCBidXQgbXVzdCBwcm92aWRlDQo+PiAgICAgICAgICAgIGF0IGxlYXN0IGEg
ZGVmaW5pdGlvbiBvZiBub24tcHJlZmV0Y2hhYmxlIG1lbW9yeS4gT25lDQo+PiAgICAgICAgICAg
IG9yIGJvdGggb2YgcHJlZmV0Y2hhYmxlIE1lbW9yeSBhbmQgSU8gU3BhY2UgbWF5IGFsc28NCj4+
ICAgICAgICAgICAgYmUgcHJvdmlkZWQuDQo+Pg0KPj4gLSByZWcgICA6IFRoZSBDb25maWd1cmF0
aW9uIFNwYWNlIGJhc2UgYWRkcmVzcyBhbmQgc2l6ZSwgYXMgYWNjZXNzZWQNCj4+ICAgICAgICAg
ICAgZnJvbSB0aGUgcGFyZW50IGJ1cy4gIFRoZSBiYXNlIGFkZHJlc3MgY29ycmVzcG9uZHMgdG8N
Cj4+ICAgICAgICAgICAgdGhlIGZpcnN0IGJ1cyBpbiB0aGUgImJ1cy1yYW5nZSIgcHJvcGVydHku
ICBJZiBubw0KPj4gICAgICAgICAgICAiYnVzLXJhbmdlIiBpcyBzcGVjaWZpZWQsIHRoaXMgd2ls
bCBiZSBidXMgMCAodGhlIGRlZmF1bHQpLg0KPj4NCj4+ID5Gcm9tIHRoZSBhYm92ZSBub25lIG9m
IHRoZSBtZW1vcnkgcmFuZ2VzIGZyb20gdGhlICJyYW5nZXMiIHByb3BlcnR5DQo+PiBuZWVkcyB0
byBiZSBtYXBwZWQgdG8gRG9tYWluLTAgYXQgc3RhcnR1cCBhcyBNTUlPIG1hcHBpbmcgaXMgZ29p
bmcgdG8NCj4+IGJlIGhhbmRsZWQgZHluYW1pY2FsbHkgYnkgdlBDSSBhcyB3ZSBhc3NpZ24gUENJ
IGRldmljZXMsIGUuZy4gZWFjaA0KPj4gZGV2aWNlIGFzc2lnbmVkIHRvIERvbWFpbi0wL2d1ZXN0
IHdpbGwgaGF2ZSBpdHMgTU1JT3MgbWFwcGVkL3VubWFwcGVkDQo+PiBhcyBuZWVkZWQgYnkgWGVu
Lg0KPj4NCj4+IFRoZSAicmVnIiBwcm9wZXJ0eSBjb3ZlcnMgbm90IG9ubHkgRUNBTSBzcGFjZSwg
YnV0IG1heSBhbHNvIGhhdmUgb3RoZXINCj4+IHRoZW4gdGhlIGNvbmZpZ3VyYXRpb24gbWVtb3J5
IHJhbmdlcyBkZXNjcmliZWQsIGZvciBleGFtcGxlIFszXToNCj4+IC0gcmVnOiBTaG91bGQgY29u
dGFpbiByY19kYmksIGNvbmZpZyByZWdpc3RlcnMgbG9jYXRpb24gYW5kIGxlbmd0aC4NCj4+IC0g
cmVnLW5hbWVzOiBNdXN0IGluY2x1ZGUgdGhlIGZvbGxvd2luZyBlbnRyaWVzOg0KPj4gICAgICJy
Y19kYmkiOiBjb250cm9sbGVyIGNvbmZpZ3VyYXRpb24gcmVnaXN0ZXJzOw0KPj4gICAgICJjb25m
aWciOiBQQ0llIGNvbmZpZ3VyYXRpb24gc3BhY2UgcmVnaXN0ZXJzLg0KPj4NCj4+IFRoaXMgcGF0
Y2ggbWFrZXMgaXQgcG9zc2libGUgdG8gbm90IG1hcCBhbGwgdGhlIHJhbmdlcyBmcm9tIHRoZQ0K
Pj4gInJhbmdlcyIgcHJvcGVydHkgYW5kIGFsc28gRUNBTSBmcm9tIHRoZSAicmVnIi4gQWxsIHRo
ZSByZXN0IGZyb20gdGhlDQo+PiAicmVnIiBwcm9wZXJ0eSBzdGlsbCBuZWVkcyB0byBiZSBtYXBw
ZWQgdG8gRG9tYWluLTAsIHNvIHRoZSBQQ0kNCj4+IGhvc3QgYnJpZGdlIHJlbWFpbnMgZnVuY3Rp
b25hbCBpbiBEb21haW4tMC4NCj4+DQo+PiBbMV0gaHR0cHM6Ly9saXN0cy54ZW5wcm9qZWN0Lm9y
Zy9hcmNoaXZlcy9odG1sL3hlbi1kZXZlbC8yMDIwLTA3L21zZzAwNzc3Lmh0bWwNCj4+IFsyXSBo
dHRwczovL3d3dy5rZXJuZWwub3JnL2RvYy9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGlu
Z3MvcGNpL2hvc3QtZ2VuZXJpYy1wY2kudHh0DQo+PiBbM10gaHR0cHM6Ly93d3cua2VybmVsLm9y
Zy9kb2MvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL3BjaS9oaXNpbGljb24tcGNp
ZS50eHQNCj4+DQo+PiBTaWduZWQtb2ZmLWJ5OiBPbGVrc2FuZHIgQW5kcnVzaGNoZW5rbyA8b2xl
a3NhbmRyX2FuZHJ1c2hjaGVua29AZXBhbS5jb20+DQo+PiAtLS0NCj4+IFNpbmNlIHYzOg0KPj4g
ICAtIHBhc3Mgc3RydWN0IG1hcF9yYW5nZV9kYXRhIHRvIG1hcF9kdF9pcnFfdG9fZG9tYWluDQo+
PiAgIC0gcmVtb3ZlIHJlZHVuZGFudCBjaGVjayBmcm9tIG1hcF9yYW5nZV90b19kb21haW4NCj4+
ICAgLSBmaXggaGFuZGxlX2RldmljZSdzIC5za2lwX21hcHBpbmcNCj4+IFNpbmNlIHYyOg0KPj4g
ICAtIHJlbW92ZWQgY2hlY2sgaW4gbWFwX3JhbmdlX3RvX2RvbWFpbiBmb3IgUENJX0RFVg0KPj4g
ICAgIGFuZCBtb3ZlZCBpdCB0byBoYW5kbGVfZGV2aWNlLCBzbyB0aGUgY29kZSBpcw0KPj4gICAg
IHNpbXBsZXINCj4+ICAgLSBzL21hcF9wY2lfYnJpZGdlL3NraXBfbWFwcGluZw0KPj4gICAtIGV4
dGVuZGVkIGNvbW1lbnQgaW4gcGNpX2hvc3RfYnJpZGdlX21hcHBpbmdzDQo+PiAgIC0gbWlub3Ig
Y29kZSByZXN0cnVjdHVyZSBpbiBjb25zdHJ1Y3RfZG9tMA0KPj4gICAtIHMvLm5lZWRfcDJtX21h
cHBpbmcvLm5lZWRfcDJtX2h3ZG9tX21hcHBpbmcgYW5kIHJlbGF0ZWQNCj4+ICAgICBjYWxsYmFj
a3MNCj4+ICAgLSB1bnNpZ25lZCBpbnQgaTsgaW4gcGNpX2hvc3RfYnJpZGdlX21hcHBpbmdzDQo+
PiBTaW5jZSB2MToNCj4+ICAgLSBBZGRlZCBiZXR0ZXIgZGVzY3JpcHRpb24gb2Ygd2h5IGFuZCB3
aGF0IG5lZWRzIHRvIGJlIG1hcHBlZCBpbnRvDQo+PiAgICAgRG9tYWluLTAncyBwMm0gYW5kIHdo
YXQgZG9lc24ndA0KPj4gICAtIERvIG5vdCBkbyBhbnkgbWFwcGluZ3MgZm9yIFBDSSBkZXZpY2Vz
IHdoaWxlIHRyYXZlcnNpbmcgdGhlIERUDQo+PiAgIC0gV2FsayBhbGwgdGhlIGJyaWRnZXMgYW5k
IG1ha2UgcmVxdWlyZWQgbWFwcGluZ3MgaW4gb25lIGdvDQo+PiAtLS0NCj4+ICAgeGVuL2FyY2gv
YXJtL2RvbWFpbl9idWlsZC5jICAgICAgICB8IDUwICsrKysrKysrKysrKysrKystLS0tLS0tLS0t
LS0tLQ0KPj4gICB4ZW4vYXJjaC9hcm0vcGNpL2VjYW0uYyAgICAgICAgICAgIHwgMTQgKysrKysr
KysrDQo+PiAgIHhlbi9hcmNoL2FybS9wY2kvcGNpLWhvc3QtY29tbW9uLmMgfCA0OSArKysrKysr
KysrKysrKysrKysrKysrKysrKysrKw0KPj4gICB4ZW4vYXJjaC9hcm0vcGNpL3BjaS1ob3N0LXp5
bnFtcC5jIHwgIDEgKw0KPj4gICB4ZW4vaW5jbHVkZS9hc20tYXJtL3BjaS5oICAgICAgICAgIHwg
MTAgKysrKysrDQo+PiAgIHhlbi9pbmNsdWRlL2FzbS1hcm0vc2V0dXAuaCAgICAgICAgfCAxMyAr
KysrKysrKw0KPj4gICA2IGZpbGVzIGNoYW5nZWQsIDExNCBpbnNlcnRpb25zKCspLCAyMyBkZWxl
dGlvbnMoLSkNCj4+DQo+PiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gvYXJtL2RvbWFpbl9idWlsZC5j
IGIveGVuL2FyY2gvYXJtL2RvbWFpbl9idWlsZC5jDQo+PiBpbmRleCA4NzM5ZTMyODVlZjQuLjJh
M2M2NDE0NzZiZCAxMDA2NDQNCj4+IC0tLSBhL3hlbi9hcmNoL2FybS9kb21haW5fYnVpbGQuYw0K
Pj4gKysrIGIveGVuL2FyY2gvYXJtL2RvbWFpbl9idWlsZC5jDQo+PiBAQCAtMTAsNyArMTAsNiBA
QA0KPj4gICAjaW5jbHVkZSA8YXNtL3JlZ3MuaD4NCj4+ICAgI2luY2x1ZGUgPHhlbi9lcnJuby5o
Pg0KPj4gICAjaW5jbHVkZSA8eGVuL2Vyci5oPg0KPj4gLSNpbmNsdWRlIDx4ZW4vZGV2aWNlX3Ry
ZWUuaD4NCj4+ICAgI2luY2x1ZGUgPHhlbi9saWJmZHQvbGliZmR0Lmg+DQo+PiAgICNpbmNsdWRl
IDx4ZW4vZ3Vlc3RfYWNjZXNzLmg+DQo+PiAgICNpbmNsdWRlIDx4ZW4vaW9jYXAuaD4NCj4+IEBA
IC01MSwxMiArNTAsNiBAQCBzdGF0aWMgaW50IF9faW5pdCBwYXJzZV9kb20wX21lbShjb25zdCBj
aGFyICpzKQ0KPj4gICB9DQo+PiAgIGN1c3RvbV9wYXJhbSgiZG9tMF9tZW0iLCBwYXJzZV9kb20w
X21lbSk7DQo+PiAgIA0KPj4gLXN0cnVjdCBtYXBfcmFuZ2VfZGF0YQ0KPj4gLXsNCj4+IC0gICAg
c3RydWN0IGRvbWFpbiAqZDsNCj4+IC0gICAgcDJtX3R5cGVfdCBwMm10Ow0KPj4gLX07DQo+PiAt
DQo+PiAgIC8qIE92ZXJyaWRlIG1hY3JvcyBmcm9tIGFzbS9wYWdlLmggdG8gbWFrZSB0aGVtIHdv
cmsgd2l0aCBtZm5fdCAqLw0KPj4gICAjdW5kZWYgdmlydF90b19tZm4NCj4+ICAgI2RlZmluZSB2
aXJ0X3RvX21mbih2YSkgX21mbihfX3ZpcnRfdG9fbWZuKHZhKSkNCj4+IEBAIC0xNjQxLDEwICsx
NjM0LDExIEBAIHN0YXRpYyBpbnQgX19pbml0IG1hcF9kdF9pcnFfdG9fZG9tYWluKGNvbnN0IHN0
cnVjdCBkdF9kZXZpY2Vfbm9kZSAqZGV2LA0KPj4gICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICBjb25zdCBzdHJ1Y3QgZHRfaXJxICpkdF9pcnEsDQo+PiAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHZvaWQgKmRhdGEpDQo+PiAgIHsNCj4+IC0g
ICAgc3RydWN0IGRvbWFpbiAqZCA9IGRhdGE7DQo+PiArICAgIHN0cnVjdCBtYXBfcmFuZ2VfZGF0
YSAqbXJfZGF0YSA9IGRhdGE7DQo+PiArICAgIHN0cnVjdCBkb21haW4gKmQgPSBtcl9kYXRhLT5k
Ow0KPj4gICAgICAgdW5zaWduZWQgaW50IGlycSA9IGR0X2lycS0+aXJxOw0KPj4gICAgICAgaW50
IHJlczsNCj4+IC0gICAgYm9vbCBuZWVkX21hcHBpbmcgPSAhZHRfZGV2aWNlX2Zvcl9wYXNzdGhy
b3VnaChkZXYpOw0KPj4gKyAgICBib29sIG5lZWRfbWFwcGluZyA9ICFtcl9kYXRhLT5za2lwX21h
cHBpbmc7DQo+PiAgIA0KPj4gICAgICAgaWYgKCBpcnEgPCBOUl9MT0NBTF9JUlFTICkNCj4+ICAg
ICAgIHsNCj4+IEBAIC0xNjY4LDEzICsxNjYyLDEyIEBAIHN0YXRpYyBpbnQgX19pbml0IG1hcF9k
dF9pcnFfdG9fZG9tYWluKGNvbnN0IHN0cnVjdCBkdF9kZXZpY2Vfbm9kZSAqZGV2LA0KPj4gICAg
ICAgcmV0dXJuIDA7DQo+PiAgIH0NCj4+ICAgDQo+PiAtc3RhdGljIGludCBfX2luaXQgbWFwX3Jh
bmdlX3RvX2RvbWFpbihjb25zdCBzdHJ1Y3QgZHRfZGV2aWNlX25vZGUgKmRldiwNCj4+IC0gICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHU2NCBhZGRyLCB1NjQgbGVuLA0KPj4g
LSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdm9pZCAqZGF0YSkNCj4+ICtp
bnQgX19pbml0IG1hcF9yYW5nZV90b19kb21haW4oY29uc3Qgc3RydWN0IGR0X2RldmljZV9ub2Rl
ICpkZXYsDQo+PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHU2NCBhZGRyLCB1NjQg
bGVuLCB2b2lkICpkYXRhKQ0KPj4gICB7DQo+PiAgICAgICBzdHJ1Y3QgbWFwX3JhbmdlX2RhdGEg
Km1yX2RhdGEgPSBkYXRhOw0KPj4gICAgICAgc3RydWN0IGRvbWFpbiAqZCA9IG1yX2RhdGEtPmQ7
DQo+PiAtICAgIGJvb2wgbmVlZF9tYXBwaW5nID0gIWR0X2RldmljZV9mb3JfcGFzc3Rocm91Z2go
ZGV2KTsNCj4+ICsgICAgYm9vbCBuZWVkX21hcHBpbmcgPSAhbXJfZGF0YS0+c2tpcF9tYXBwaW5n
Ow0KPj4gICAgICAgaW50IHJlczsNCj4+ICAgDQo+PiAgICAgICAvKg0KPj4gQEAgLTE3MjYsMjMg
KzE3MTksMjEgQEAgc3RhdGljIGludCBfX2luaXQgbWFwX3JhbmdlX3RvX2RvbWFpbihjb25zdCBz
dHJ1Y3QgZHRfZGV2aWNlX25vZGUgKmRldiwNCj4+ICAgICogdGhlbiB3ZSBtYXkgbmVlZCB0byBw
ZXJmb3JtIGFkZGl0aW9uYWwgbWFwcGluZ3MgaW4gb3JkZXIgdG8gbWFrZQ0KPj4gICAgKiB0aGUg
Y2hpbGQgcmVzb3VyY2VzIGF2YWlsYWJsZSB0byBkb21haW4gMC4NCj4+ICAgICovDQo+PiAtc3Rh
dGljIGludCBfX2luaXQgbWFwX2RldmljZV9jaGlsZHJlbihzdHJ1Y3QgZG9tYWluICpkLA0KPj4g
LSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgY29uc3Qgc3RydWN0IGR0X2Rl
dmljZV9ub2RlICpkZXYsDQo+PiAtICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICBwMm1fdHlwZV90IHAybXQpDQo+PiArc3RhdGljIGludCBfX2luaXQgbWFwX2RldmljZV9jaGls
ZHJlbihjb25zdCBzdHJ1Y3QgZHRfZGV2aWNlX25vZGUgKmRldiwNCj4+ICsgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgIHN0cnVjdCBtYXBfcmFuZ2VfZGF0YSAqbXJfZGF0YSkN
Cj4+ICAgew0KPj4gLSAgICBzdHJ1Y3QgbWFwX3JhbmdlX2RhdGEgbXJfZGF0YSA9IHsgLmQgPSBk
LCAucDJtdCA9IHAybXQgfTsNCj4+IC0gICAgaW50IHJldDsNCj4+IC0NCj4+ICAgICAgIGlmICgg
ZHRfZGV2aWNlX3R5cGVfaXNfZXF1YWwoZGV2LCAicGNpIikgKQ0KPj4gICAgICAgew0KPj4gKyAg
ICAgICAgaW50IHJldDsNCj4+ICsNCj4+ICAgICAgICAgICBkdF9kcHJpbnRrKCJNYXBwaW5nIGNo
aWxkcmVuIG9mICVzIHRvIGd1ZXN0XG4iLA0KPj4gICAgICAgICAgICAgICAgICAgICAgZHRfbm9k
ZV9mdWxsX25hbWUoZGV2KSk7DQo+PiAgIA0KPj4gLSAgICAgICAgcmV0ID0gZHRfZm9yX2VhY2hf
aXJxX21hcChkZXYsICZtYXBfZHRfaXJxX3RvX2RvbWFpbiwgZCk7DQo+PiArICAgICAgICByZXQg
PSBkdF9mb3JfZWFjaF9pcnFfbWFwKGRldiwgJm1hcF9kdF9pcnFfdG9fZG9tYWluLCBtcl9kYXRh
KTsNCj4+ICAgICAgICAgICBpZiAoIHJldCA8IDAgKQ0KPj4gICAgICAgICAgICAgICByZXR1cm4g
cmV0Ow0KPj4gICANCj4+IC0gICAgICAgIHJldCA9IGR0X2Zvcl9lYWNoX3JhbmdlKGRldiwgJm1h
cF9yYW5nZV90b19kb21haW4sICZtcl9kYXRhKTsNCj4+ICsgICAgICAgIHJldCA9IGR0X2Zvcl9l
YWNoX3JhbmdlKGRldiwgJm1hcF9yYW5nZV90b19kb21haW4sIG1yX2RhdGEpOw0KPj4gICAgICAg
ICAgIGlmICggcmV0IDwgMCApDQo+PiAgICAgICAgICAgICAgIHJldHVybiByZXQ7DQo+PiAgICAg
ICB9DQo+PiBAQCAtMTgyMyw2ICsxODE0LDEzIEBAIHN0YXRpYyBpbnQgX19pbml0IGhhbmRsZV9k
ZXZpY2Uoc3RydWN0IGRvbWFpbiAqZCwgc3RydWN0IGR0X2RldmljZV9ub2RlICpkZXYsDQo+PiAg
ICAgICBpbnQgcmVzOw0KPj4gICAgICAgdTY0IGFkZHIsIHNpemU7DQo+PiAgICAgICBib29sIG5l
ZWRfbWFwcGluZyA9ICFkdF9kZXZpY2VfZm9yX3Bhc3N0aHJvdWdoKGRldik7DQo+PiArICAgIHN0
cnVjdCBtYXBfcmFuZ2VfZGF0YSBtcl9kYXRhID0gew0KPj4gKyAgICAgICAgLmQgPSBkLA0KPj4g
KyAgICAgICAgLnAybXQgPSBwMm10LA0KPj4gKyAgICAgICAgLnNraXBfbWFwcGluZyA9ICFuZWVk
X21hcHBpbmcgfHwNCj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAoaXNfcGNpX3Bhc3N0aHJv
dWdoX2VuYWJsZWQoKSAmJg0KPj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAoZGV2aWNlX2dl
dF9jbGFzcyhkZXYpID09IERFVklDRV9QQ0kpKQ0KPj4gKyAgICB9Ow0KPiBJIHdvdWxkIHByZWZl
ciBpZiB3ZSBkaWQgdGhpczoNCj4NCj4gZGlmZiAtLWdpdCBhL3hlbi9hcmNoL2FybS9kb21haW5f
YnVpbGQuYyBiL3hlbi9hcmNoL2FybS9kb21haW5fYnVpbGQuYw0KPiBpbmRleCAyYTNjNjQxNDc2
Li4xZTdjZGQxMWM3IDEwMDY0NA0KPiAtLS0gYS94ZW4vYXJjaC9hcm0vZG9tYWluX2J1aWxkLmMN
Cj4gKysrIGIveGVuL2FyY2gvYXJtL2RvbWFpbl9idWlsZC5jDQo+IEBAIC0xODEzLDEzICsxODEz
LDEzIEBAIHN0YXRpYyBpbnQgX19pbml0IGhhbmRsZV9kZXZpY2Uoc3RydWN0IGRvbWFpbiAqZCwg
c3RydWN0IGR0X2RldmljZV9ub2RlICpkZXYsDQo+ICAgICAgIHVuc2lnbmVkIGludCBpOw0KPiAg
ICAgICBpbnQgcmVzOw0KPiAgICAgICB1NjQgYWRkciwgc2l6ZTsNCj4gLSAgICBib29sIG5lZWRf
bWFwcGluZyA9ICFkdF9kZXZpY2VfZm9yX3Bhc3N0aHJvdWdoKGRldik7DQo+ICsgICAgYm9vbCBu
ZWVkX21hcHBpbmcgPSAhZHRfZGV2aWNlX2Zvcl9wYXNzdGhyb3VnaChkZXYpICYmDQo+ICsgICAg
ICAgICAgICAgICAgICAgICAgICAhKGlzX3BjaV9wYXNzdGhyb3VnaF9lbmFibGVkKCkgJiYNCj4g
KyAgICAgICAgICAgICAgICAgICAgICAgICAgKGRldmljZV9nZXRfY2xhc3MoZGV2KSA9PSBERVZJ
Q0VfUENJKSkNCj4gICAgICAgc3RydWN0IG1hcF9yYW5nZV9kYXRhIG1yX2RhdGEgPSB7DQo+ICAg
ICAgICAgICAuZCA9IGQsDQo+ICAgICAgICAgICAucDJtdCA9IHAybXQsDQo+IC0gICAgICAgIC5z
a2lwX21hcHBpbmcgPSAhbmVlZF9tYXBwaW5nIHx8DQo+IC0gICAgICAgICAgICAgICAgICAgICAg
ICAoaXNfcGNpX3Bhc3N0aHJvdWdoX2VuYWJsZWQoKSAmJg0KPiAtICAgICAgICAgICAgICAgICAg
ICAgICAgIChkZXZpY2VfZ2V0X2NsYXNzKGRldikgPT0gREVWSUNFX1BDSSkpDQo+ICsgICAgICAg
IC5za2lwX21hcHBpbmcgPSAhbmVlZF9tYXBwaW5nDQo+ICAgICAgIH07DQo+ICAgDQo+ICAgICAg
IG5hZGRyID0gZHRfbnVtYmVyX29mX2FkZHJlc3MoZGV2KTsNCj4NCj4NCj4gVGhpcyBhY3R1YWxs
eSBtYWtlcyBhIGRpZmZlcmVuY2UgYmVjYXVzZSBvdGhlcndpc2UNCj4gaGFuZGxlX2RldmljZV9p
bnRlcnJ1cHRzIGNvdWxkIHN0aWxsIGJlIGNhbGxlZCB3aXRoIG5lZWRfbWFwcGluZyA9PQ0KPiB0
cnVlIGZvciBQQ0kgZGV2aWNlcy4NCkFuZCB0aGlzIGlzIHRvdGFsbHkgZmluZS4gUmVtZW1iZXIg
dGhlIG5hbWUgb2YgdGhlIHBhdGNoOiB3ZSBkbyBub3QNCndhbnQgdG8gbWFwIG1lbW9yeSwgYnV0
IGludGVycnVwdHMgYXJlIHN0aWxsIG5lZWRlZCBmb3IgdGhlIGJyaWRnZSB0bw0KZnVuY3Rpb24g
aW4gRG9tMC4gVGhlIHNhbWUgYXMgaXQgbmVlZHMgYWxsLCBidXQgImNmZyIgZnJvbSAicmVncyIu
DQpTbywgbmVlZF9tYXBwaW5nID09IHRydWUgZm9yIGludGVycnVwdHMgaXMgd2hhdCB3ZSB3YW50
OiBsZWdhY3kgSU5UeA0KYXJlIG5vdCBzdXBwb3J0ZWQgYnkgZGVzaWduIGFuZCBvbmx5IE1TSS9N
U0ktWCBhcmUgc3VwcG9ydGVkLg0KPg0KPiBXaGF0IGRvIHlvdSB0aGluaz8gIE9uZSBtb3JlIGNv
bW1lbnQgYmVsb3cuDQo+DQo+DQo+PiAgICAgICBuYWRkciA9IGR0X251bWJlcl9vZl9hZGRyZXNz
KGRldik7DQo+PiAgIA0KPj4gQEAgLTE4NjIsNyArMTg2MCw2IEBAIHN0YXRpYyBpbnQgX19pbml0
IGhhbmRsZV9kZXZpY2Uoc3RydWN0IGRvbWFpbiAqZCwgc3RydWN0IGR0X2RldmljZV9ub2RlICpk
ZXYsDQo+PiAgICAgICAvKiBHaXZlIHBlcm1pc3Npb24gYW5kIG1hcCBNTUlPcyAqLw0KPj4gICAg
ICAgZm9yICggaSA9IDA7IGkgPCBuYWRkcjsgaSsrICkNCj4+ICAgICAgIHsNCj4+IC0gICAgICAg
IHN0cnVjdCBtYXBfcmFuZ2VfZGF0YSBtcl9kYXRhID0geyAuZCA9IGQsIC5wMm10ID0gcDJtdCB9
Ow0KPj4gICAgICAgICAgIHJlcyA9IGR0X2RldmljZV9nZXRfYWRkcmVzcyhkZXYsIGksICZhZGRy
LCAmc2l6ZSk7DQo+PiAgICAgICAgICAgaWYgKCByZXMgKQ0KPj4gICAgICAgICAgIHsNCj4+IEBA
IC0xODc2LDcgKzE4NzMsNyBAQCBzdGF0aWMgaW50IF9faW5pdCBoYW5kbGVfZGV2aWNlKHN0cnVj
dCBkb21haW4gKmQsIHN0cnVjdCBkdF9kZXZpY2Vfbm9kZSAqZGV2LA0KPj4gICAgICAgICAgICAg
ICByZXR1cm4gcmVzOw0KPj4gICAgICAgfQ0KPj4gICANCj4+IC0gICAgcmVzID0gbWFwX2Rldmlj
ZV9jaGlsZHJlbihkLCBkZXYsIHAybXQpOw0KPj4gKyAgICByZXMgPSBtYXBfZGV2aWNlX2NoaWxk
cmVuKGRldiwgJm1yX2RhdGEpOw0KPj4gICAgICAgaWYgKCByZXMgKQ0KPj4gICAgICAgICAgIHJl
dHVybiByZXM7DQo+PiAgIA0KPj4gQEAgLTMwMzQsNyArMzAzMSwxNCBAQCBzdGF0aWMgaW50IF9f
aW5pdCBjb25zdHJ1Y3RfZG9tMChzdHJ1Y3QgZG9tYWluICpkKQ0KPj4gICAgICAgICAgIHJldHVy
biByYzsNCj4+ICAgDQo+PiAgICAgICBpZiAoIGFjcGlfZGlzYWJsZWQgKQ0KPj4gKyAgICB7DQo+
PiAgICAgICAgICAgcmMgPSBwcmVwYXJlX2R0Yl9od2RvbShkLCAma2luZm8pOw0KPj4gKyAgICAg
ICAgaWYgKCByYyA8IDAgKQ0KPj4gKyAgICAgICAgICAgIHJldHVybiByYzsNCj4+ICsjaWZkZWYg
Q09ORklHX0hBU19QQ0kNCj4+ICsgICAgICAgIHJjID0gcGNpX2hvc3RfYnJpZGdlX21hcHBpbmdz
KGQsIHAybV9tbWlvX2RpcmVjdF9jKTsNCj4+ICsjZW5kaWYNCj4+ICsgICAgfQ0KPj4gICAgICAg
ZWxzZQ0KPj4gICAgICAgICAgIHJjID0gcHJlcGFyZV9hY3BpKGQsICZraW5mbyk7DQo+PiAgIA0K
Pj4gZGlmZiAtLWdpdCBhL3hlbi9hcmNoL2FybS9wY2kvZWNhbS5jIGIveGVuL2FyY2gvYXJtL3Bj
aS9lY2FtLmMNCj4+IGluZGV4IDYwMmQwMDc5OWM4ZC4uYjgxNjIwMDc0YTkxIDEwMDY0NA0KPj4g
LS0tIGEveGVuL2FyY2gvYXJtL3BjaS9lY2FtLmMNCj4+ICsrKyBiL3hlbi9hcmNoL2FybS9wY2kv
ZWNhbS5jDQo+PiBAQCAtNDAsNiArNDAsMTkgQEAgdm9pZCBfX2lvbWVtICpwY2lfZWNhbV9tYXBf
YnVzKHN0cnVjdCBwY2lfaG9zdF9icmlkZ2UgKmJyaWRnZSwNCj4+ICAgICAgIHJldHVybiBiYXNl
ICsgKFBDSV9ERVZGTjIoc2JkZi5iZGYpIDw8IGRldmZuX3NoaWZ0KSArIHdoZXJlOw0KPj4gICB9
DQo+PiAgIA0KPj4gK2Jvb2wgcGNpX2VjYW1fbmVlZF9wMm1faHdkb21fbWFwcGluZyhzdHJ1Y3Qg
ZG9tYWluICpkLA0KPj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBzdHJ1
Y3QgcGNpX2hvc3RfYnJpZGdlICpicmlkZ2UsDQo+PiArICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgIHVpbnQ2NF90IGFkZHIpDQo+PiArew0KPj4gKyAgICBzdHJ1Y3QgcGNpX2Nv
bmZpZ193aW5kb3cgKmNmZyA9IGJyaWRnZS0+Y2ZnOw0KPj4gKw0KPj4gKyAgICAvKg0KPj4gKyAg
ICAgKiBXZSBkbyBub3Qgd2FudCBFQ0FNIGFkZHJlc3Mgc3BhY2UgdG8gYmUgbWFwcGVkIGluIERv
bWFpbi0wJ3MgcDJtLA0KPj4gKyAgICAgKiBzbyB3ZSBjYW4gdHJhcCBhY2Nlc3MgdG8gaXQuDQo+
PiArICAgICAqLw0KPj4gKyAgICByZXR1cm4gY2ZnLT5waHlzX2FkZHIgIT0gYWRkcjsNCj4+ICt9
DQo+PiArDQo+PiAgIC8qIEVDQU0gb3BzICovDQo+PiAgIGNvbnN0IHN0cnVjdCBwY2lfZWNhbV9v
cHMgcGNpX2dlbmVyaWNfZWNhbV9vcHMgPSB7DQo+PiAgICAgICAuYnVzX3NoaWZ0ICA9IDIwLA0K
Pj4gQEAgLTQ3LDYgKzYwLDcgQEAgY29uc3Qgc3RydWN0IHBjaV9lY2FtX29wcyBwY2lfZ2VuZXJp
Y19lY2FtX29wcyA9IHsNCj4+ICAgICAgICAgICAubWFwX2J1cyAgICAgICAgICAgICAgICA9IHBj
aV9lY2FtX21hcF9idXMsDQo+PiAgICAgICAgICAgLnJlYWQgICAgICAgICAgICAgICAgICAgPSBw
Y2lfZ2VuZXJpY19jb25maWdfcmVhZCwNCj4+ICAgICAgICAgICAud3JpdGUgICAgICAgICAgICAg
ICAgICA9IHBjaV9nZW5lcmljX2NvbmZpZ193cml0ZSwNCj4+ICsgICAgICAgIC5uZWVkX3AybV9o
d2RvbV9tYXBwaW5nID0gcGNpX2VjYW1fbmVlZF9wMm1faHdkb21fbWFwcGluZywNCj4+ICAgICAg
IH0NCj4+ICAgfTsNCj4+ICAgDQo+PiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gvYXJtL3BjaS9wY2kt
aG9zdC1jb21tb24uYyBiL3hlbi9hcmNoL2FybS9wY2kvcGNpLWhvc3QtY29tbW9uLmMNCj4+IGlu
ZGV4IDFlYjRkYWE4NzM2NS4uMDg1ZjA4ZTIzZTBjIDEwMDY0NA0KPj4gLS0tIGEveGVuL2FyY2gv
YXJtL3BjaS9wY2ktaG9zdC1jb21tb24uYw0KPj4gKysrIGIveGVuL2FyY2gvYXJtL3BjaS9wY2kt
aG9zdC1jb21tb24uYw0KPj4gQEAgLTE4LDYgKzE4LDcgQEANCj4+ICAgDQo+PiAgICNpbmNsdWRl
IDx4ZW4vaW5pdC5oPg0KPj4gICAjaW5jbHVkZSA8eGVuL3BjaS5oPg0KPj4gKyNpbmNsdWRlIDxh
c20vc2V0dXAuaD4NCj4+ICAgI2luY2x1ZGUgPHhlbi9yd2xvY2suaD4NCj4+ICAgI2luY2x1ZGUg
PHhlbi9zY2hlZC5oPg0KPj4gICAjaW5jbHVkZSA8eGVuL3ZtYXAuaD4NCj4+IEBAIC0zMjAsNiAr
MzIxLDU0IEBAIGludCBwY2lfaG9zdF9nZXRfbnVtX2JyaWRnZXModm9pZCkNCj4+ICAgICAgIHJl
dHVybiBjb3VudDsNCj4+ICAgfQ0KPj4gICANCj4+ICtpbnQgX19pbml0IHBjaV9ob3N0X2JyaWRn
ZV9tYXBwaW5ncyhzdHJ1Y3QgZG9tYWluICpkLCBwMm1fdHlwZV90IHAybXQpDQo+PiArew0KPj4g
KyAgICBzdHJ1Y3QgcGNpX2hvc3RfYnJpZGdlICpicmlkZ2U7DQo+PiArICAgIHN0cnVjdCBtYXBf
cmFuZ2VfZGF0YSBtcl9kYXRhID0gew0KPj4gKyAgICAgICAgLmQgPSBkLA0KPj4gKyAgICAgICAg
LnAybXQgPSBwMm10LA0KPj4gKyAgICAgICAgLnNraXBfbWFwcGluZyA9IGZhbHNlDQo+PiArICAg
IH07DQo+PiArDQo+PiArICAgIC8qDQo+PiArICAgICAqIEZvciBlYWNoIFBDSSBob3N0IGJyaWRn
ZSB3ZSBuZWVkIHRvIG9ubHkgbWFwIHRob3NlIHJhbmdlcw0KPj4gKyAgICAgKiB3aGljaCBhcmUg
dXNlZCBieSBEb21haW4tMCB0byBwcm9wZXJseSBpbml0aWFsaXplIHRoZSBicmlkZ2UsDQo+PiAr
ICAgICAqIGUuZy4gd2UgZG8gbm90IHdhbnQgdG8gbWFwIEVDQU0gY29uZmlndXJhdGlvbiBzcGFj
ZSB3aGljaCBsaXZlcyBpbg0KPj4gKyAgICAgKiAicmVnIiBvciAiYXNzaWduZWQtYWRkcmVzc2Vz
IiBkZXZpY2UgdHJlZSBwcm9wZXJ0eSwgYnV0IHdlIHdhbnQgdG8NCj4+ICsgICAgICogbWFwIG90
aGVyIHJlZ2lvbnMgb2YgdGhlIGhvc3QgYnJpZGdlLiBUaGUgUENJIGFwZXJ0dXJlIGRlZmluZWQg
YnkNCj4+ICsgICAgICogdGhlICJyYW5nZXMiIGRldmljZSB0cmVlIHByb3BlcnR5IHNob3VsZCBh
bHNvIGJlIHNraXBwZWQuDQo+PiArICAgICAqLw0KPj4gKyAgICBsaXN0X2Zvcl9lYWNoX2VudHJ5
KCBicmlkZ2UsICZwY2lfaG9zdF9icmlkZ2VzLCBub2RlICkNCj4+ICsgICAgew0KPj4gKyAgICAg
ICAgY29uc3Qgc3RydWN0IGR0X2RldmljZV9ub2RlICpkZXYgPSBicmlkZ2UtPmR0X25vZGU7DQo+
PiArICAgICAgICB1bnNpZ25lZCBpbnQgaTsNCj4+ICsNCj4+ICsgICAgICAgIGZvciAoIGkgPSAw
OyBpIDwgZHRfbnVtYmVyX29mX2FkZHJlc3MoZGV2KTsgaSsrICkNCj4+ICsgICAgICAgIHsNCj4+
ICsgICAgICAgICAgICB1aW50NjRfdCBhZGRyLCBzaXplOw0KPj4gKyAgICAgICAgICAgIGludCBl
cnI7DQo+PiArDQo+PiArICAgICAgICAgICAgZXJyID0gZHRfZGV2aWNlX2dldF9hZGRyZXNzKGRl
diwgaSwgJmFkZHIsICZzaXplKTsNCj4+ICsgICAgICAgICAgICBpZiAoIGVyciApDQo+PiArICAg
ICAgICAgICAgew0KPj4gKyAgICAgICAgICAgICAgICBwcmludGsoWEVOTE9HX0VSUg0KPj4gKyAg
ICAgICAgICAgICAgICAgICAgICAgIlVuYWJsZSB0byByZXRyaWV2ZSBhZGRyZXNzIHJhbmdlIGlu
ZGV4PSV1IGZvciAlc1xuIiwNCj4+ICsgICAgICAgICAgICAgICAgICAgICAgIGksIGR0X25vZGVf
ZnVsbF9uYW1lKGRldikpOw0KPj4gKyAgICAgICAgICAgICAgICByZXR1cm4gZXJyOw0KPj4gKyAg
ICAgICAgICAgIH0NCj4+ICsNCj4+ICsgICAgICAgICAgICBpZiAoIGJyaWRnZS0+b3BzLT5uZWVk
X3AybV9od2RvbV9tYXBwaW5nKGQsIGJyaWRnZSwgYWRkcikgKQ0KPj4gKyAgICAgICAgICAgIHsN
Cj4+ICsgICAgICAgICAgICAgICAgZXJyID0gbWFwX3JhbmdlX3RvX2RvbWFpbihkZXYsIGFkZHIs
IHNpemUsICZtcl9kYXRhKTsNCj4+ICsgICAgICAgICAgICAgICAgaWYgKCBlcnIgKQ0KPj4gKyAg
ICAgICAgICAgICAgICAgICAgcmV0dXJuIGVycjsNCj4+ICsgICAgICAgICAgICB9DQo+PiArICAg
ICAgICB9DQo+PiArICAgIH0NCj4+ICsNCj4+ICsgICAgcmV0dXJuIDA7DQo+PiArfQ0KPj4gKw0K
Pj4gICAvKg0KPj4gICAgKiBMb2NhbCB2YXJpYWJsZXM6DQo+PiAgICAqIG1vZGU6IEMNCj4+IGRp
ZmYgLS1naXQgYS94ZW4vYXJjaC9hcm0vcGNpL3BjaS1ob3N0LXp5bnFtcC5jIGIveGVuL2FyY2gv
YXJtL3BjaS9wY2ktaG9zdC16eW5xbXAuYw0KPj4gaW5kZXggNjFhOTgwN2QzZDU4Li42YWQyYjMx
ZTgxMGQgMTAwNjQ0DQo+PiAtLS0gYS94ZW4vYXJjaC9hcm0vcGNpL3BjaS1ob3N0LXp5bnFtcC5j
DQo+PiArKysgYi94ZW4vYXJjaC9hcm0vcGNpL3BjaS1ob3N0LXp5bnFtcC5jDQo+PiBAQCAtMzQs
NiArMzQsNyBAQCBjb25zdCBzdHJ1Y3QgcGNpX2VjYW1fb3BzIG53bF9wY2llX29wcyA9IHsNCj4+
ICAgICAgICAgICAubWFwX2J1cyAgICAgICAgICAgICAgICA9IHBjaV9lY2FtX21hcF9idXMsDQo+
PiAgICAgICAgICAgLnJlYWQgICAgICAgICAgICAgICAgICAgPSBwY2lfZ2VuZXJpY19jb25maWdf
cmVhZCwNCj4+ICAgICAgICAgICAud3JpdGUgICAgICAgICAgICAgICAgICA9IHBjaV9nZW5lcmlj
X2NvbmZpZ193cml0ZSwNCj4+ICsgICAgICAgIC5uZWVkX3AybV9od2RvbV9tYXBwaW5nID0gcGNp
X2VjYW1fbmVlZF9wMm1faHdkb21fbWFwcGluZywNCj4+ICAgICAgIH0NCj4+ICAgfTsNCj4+ICAg
DQo+PiBkaWZmIC0tZ2l0IGEveGVuL2luY2x1ZGUvYXNtLWFybS9wY2kuaCBiL3hlbi9pbmNsdWRl
L2FzbS1hcm0vcGNpLmgNCj4+IGluZGV4IGE2MmQ4YmM2MDA4Ni4uZDlhM2MyYTRmM2IzIDEwMDY0
NA0KPj4gLS0tIGEveGVuL2luY2x1ZGUvYXNtLWFybS9wY2kuaA0KPj4gKysrIGIveGVuL2luY2x1
ZGUvYXNtLWFybS9wY2kuaA0KPj4gQEAgLTE3LDYgKzE3LDggQEANCj4+ICAgDQo+PiAgICNpZmRl
ZiBDT05GSUdfSEFTX1BDSQ0KPj4gICANCj4+ICsjaW5jbHVkZSA8YXNtL3AybS5oPg0KPj4gKw0K
Pj4gICAjZGVmaW5lIHBjaV90b19kZXYocGNpZGV2KSAoJihwY2lkZXYpLT5hcmNoLmRldikNCj4+
ICAgDQo+PiAgIGV4dGVybiBib29sX3QgcGNpX3Bhc3N0aHJvdWdoX2VuYWJsZWQ7DQo+PiBAQCAt
NzMsNiArNzUsOSBAQCBzdHJ1Y3QgcGNpX29wcyB7DQo+PiAgICAgICAgICAgICAgICAgICB1aW50
MzJfdCByZWcsIHVpbnQzMl90IGxlbiwgdWludDMyX3QgKnZhbHVlKTsNCj4+ICAgICAgIGludCAo
KndyaXRlKShzdHJ1Y3QgcGNpX2hvc3RfYnJpZGdlICpicmlkZ2UsIHBjaV9zYmRmX3Qgc2JkZiwN
Cj4+ICAgICAgICAgICAgICAgICAgICB1aW50MzJfdCByZWcsIHVpbnQzMl90IGxlbiwgdWludDMy
X3QgdmFsdWUpOw0KPj4gKyAgICBib29sICgqbmVlZF9wMm1faHdkb21fbWFwcGluZykoc3RydWN0
IGRvbWFpbiAqZCwNCj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHN0cnVj
dCBwY2lfaG9zdF9icmlkZ2UgKmJyaWRnZSwNCj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgIHVpbnQ2NF90IGFkZHIpOw0KPj4gICB9Ow0KPj4gICANCj4+ICAgLyoNCj4+IEBA
IC05Niw2ICsxMDEsOSBAQCBpbnQgcGNpX2dlbmVyaWNfY29uZmlnX3dyaXRlKHN0cnVjdCBwY2lf
aG9zdF9icmlkZ2UgKmJyaWRnZSwgcGNpX3NiZGZfdCBzYmRmLA0KPj4gICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgIHVpbnQzMl90IHJlZywgdWludDMyX3QgbGVuLCB1aW50MzJfdCB2YWx1
ZSk7DQo+PiAgIHZvaWQgX19pb21lbSAqcGNpX2VjYW1fbWFwX2J1cyhzdHJ1Y3QgcGNpX2hvc3Rf
YnJpZGdlICpicmlkZ2UsDQo+PiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBwY2lf
c2JkZl90IHNiZGYsIHVpbnQzMl90IHdoZXJlKTsNCj4+ICtib29sIHBjaV9lY2FtX25lZWRfcDJt
X2h3ZG9tX21hcHBpbmcoc3RydWN0IGRvbWFpbiAqZCwNCj4+ICsgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgc3RydWN0IHBjaV9ob3N0X2JyaWRnZSAqYnJpZGdlLA0KPj4gKyAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB1aW50NjRfdCBhZGRyKTsNCj4+ICAg
c3RydWN0IHBjaV9ob3N0X2JyaWRnZSAqcGNpX2ZpbmRfaG9zdF9icmlkZ2UodWludDE2X3Qgc2Vn
bWVudCwgdWludDhfdCBidXMpOw0KPj4gICBpbnQgcGNpX2dldF9ob3N0X2JyaWRnZV9zZWdtZW50
KGNvbnN0IHN0cnVjdCBkdF9kZXZpY2Vfbm9kZSAqbm9kZSwNCj4+ICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICB1aW50MTZfdCAqc2VnbWVudCk7DQo+PiBAQCAtMTEzLDYgKzEyMSw4
IEBAIGludCBwY2lfaG9zdF9pdGVyYXRlX2JyaWRnZXMoc3RydWN0IGRvbWFpbiAqZCwNCj4+ICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHN0cnVjdCBwY2lfaG9zdF9i
cmlkZ2UgKmJyaWRnZSkpOw0KPj4gICBpbnQgcGNpX2hvc3RfZ2V0X251bV9icmlkZ2VzKHZvaWQp
Ow0KPj4gICANCj4+ICtpbnQgcGNpX2hvc3RfYnJpZGdlX21hcHBpbmdzKHN0cnVjdCBkb21haW4g
KmQsIHAybV90eXBlX3QgcDJtdCk7DQo+PiArDQo+PiAgICNlbHNlICAgLyohQ09ORklHX0hBU19Q
Q0kqLw0KPj4gICANCj4+ICAgc3RydWN0IGFyY2hfcGNpX2RldiB7IH07DQo+PiBkaWZmIC0tZ2l0
IGEveGVuL2luY2x1ZGUvYXNtLWFybS9zZXR1cC5oIGIveGVuL2luY2x1ZGUvYXNtLWFybS9zZXR1
cC5oDQo+PiBpbmRleCA5NWRhMGI3YWI5Y2QuLjViMzAxMzVmZGEzOCAxMDA2NDQNCj4+IC0tLSBh
L3hlbi9pbmNsdWRlL2FzbS1hcm0vc2V0dXAuaA0KPj4gKysrIGIveGVuL2luY2x1ZGUvYXNtLWFy
bS9zZXR1cC5oDQo+PiBAQCAtMiw2ICsyLDggQEANCj4+ICAgI2RlZmluZSBfX0FSTV9TRVRVUF9I
Xw0KPj4gICANCj4+ICAgI2luY2x1ZGUgPHB1YmxpYy92ZXJzaW9uLmg+DQo+PiArI2luY2x1ZGUg
PGFzbS9wMm0uaD4NCj4+ICsjaW5jbHVkZSA8eGVuL2RldmljZV90cmVlLmg+DQo+PiAgIA0KPj4g
ICAjZGVmaW5lIE1JTl9GRFRfQUxJR04gOA0KPj4gICAjZGVmaW5lIE1BWF9GRFRfU0laRSBTWl8y
TQ0KPj4gQEAgLTc3LDYgKzc5LDE0IEBAIHN0cnVjdCBib290aW5mbyB7DQo+PiAgICNlbmRpZg0K
Pj4gICB9Ow0KPj4gICANCj4+ICtzdHJ1Y3QgbWFwX3JhbmdlX2RhdGENCj4+ICt7DQo+PiArICAg
IHN0cnVjdCBkb21haW4gKmQ7DQo+PiArICAgIHAybV90eXBlX3QgcDJtdDsNCj4+ICsgICAgLyog
U2V0IGlmIG1hcHBpbmdzIGZvciBQQ0kgaG9zdCBicmlkZ2VzIG11c3Qgbm90IGJlIHNraXBwZWQu
ICovDQo+IFRoaXMgY29tbWVudCBzdGlsbCBuZWVkcyB1cGRhdGluZy4NClNvcnJ5LCBJIG1pc3Nl
ZCB0aGlzIG9uZQ0KPg0KPg0KPj4gKyAgICBib29sIHNraXBfbWFwcGluZzsNCj4+ICt9Ow0KPj4g
Kw0KPj4gICBleHRlcm4gc3RydWN0IGJvb3RpbmZvIGJvb3RpbmZvOw0KPj4gICANCj4+ICAgZXh0
ZXJuIGRvbWlkX3QgbWF4X2luaXRfZG9taWQ7DQo+PiBAQCAtMTI0LDYgKzEzNCw5IEBAIHZvaWQg
ZGV2aWNlX3RyZWVfZ2V0X3JlZyhjb25zdCBfX2JlMzIgKipjZWxsLCB1MzIgYWRkcmVzc19jZWxs
cywNCj4+ICAgdTMyIGRldmljZV90cmVlX2dldF91MzIoY29uc3Qgdm9pZCAqZmR0LCBpbnQgbm9k
ZSwNCj4+ICAgICAgICAgICAgICAgICAgICAgICAgICAgY29uc3QgY2hhciAqcHJvcF9uYW1lLCB1
MzIgZGZsdCk7DQo+PiAgIA0KPj4gK2ludCBtYXBfcmFuZ2VfdG9fZG9tYWluKGNvbnN0IHN0cnVj
dCBkdF9kZXZpY2Vfbm9kZSAqZGV2LA0KPj4gKyAgICAgICAgICAgICAgICAgICAgICAgIHU2NCBh
ZGRyLCB1NjQgbGVuLCB2b2lkICpkYXRhKTsNCj4+ICsNCj4+ICAgI2VuZGlmDQo+PiAgIC8qDQo+
PiAgICAqIExvY2FsIHZhcmlhYmxlczoNCj4+IC0tIA0KPj4gMi4yNS4xDQo+Pg0K


From xen-devel-bounces@lists.xenproject.org Tue Oct 05 04:47:55 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Oct 2021 04:47:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.202008.356652 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXcMo-0004TC-Jj; Tue, 05 Oct 2021 04:47:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 202008.356652; Tue, 05 Oct 2021 04:47:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXcMo-0004T5-Gv; Tue, 05 Oct 2021 04:47:50 +0000
Received: by outflank-mailman (input) for mailman id 202008;
 Tue, 05 Oct 2021 04:47:50 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mXcMo-0004Sv-1m; Tue, 05 Oct 2021 04:47:50 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mXcMn-0002wD-So; Tue, 05 Oct 2021 04:47:49 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mXcMn-0002gh-Jo; Tue, 05 Oct 2021 04:47:49 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mXcMn-0003fe-JG; Tue, 05 Oct 2021 04:47:49 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=pvD3pkbQ603k44JXUD8BePFUNfIKTnOvqha9YD0JKyA=; b=RPSbZaA3v2g53pgYpNcrH0xD+m
	bnqoWjhqwLPCTJbqkGUtwsokNgUXAYD1gh2xMvjjP927pPZYhVZeZmmp86I2ota1EG8ZmczQ6DVHw
	9EE3+cKQFC/T11moBawbFgYEav9h37VZl96yM9b3c31cwXKyDcBweSpJ86iQ5xLUGjNM=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165369-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 165369: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=d6bdad32cbb5dfbc68fac32078cc5882071c4f1d
X-Osstest-Versions-That:
    xen=b6fe410936e30b2089cc8c6d54d786e535efafa3
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 05 Oct 2021 04:47:49 +0000

flight 165369 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165369/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  d6bdad32cbb5dfbc68fac32078cc5882071c4f1d
baseline version:
 xen                  b6fe410936e30b2089cc8c6d54d786e535efafa3

Last test of basis   165350  2021-10-04 13:00:25 Z    0 days
Testing same since   165369  2021-10-05 01:01:42 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Jan Beulich <jbeulich@suse.com>
  Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
  Rahul Singh <rahul.singh@arm.com>
  Stefano Stabellini <sstabellini@kernel.org>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   b6fe410936..d6bdad32cb  d6bdad32cbb5dfbc68fac32078cc5882071c4f1d -> smoke


From xen-devel-bounces@lists.xenproject.org Tue Oct 05 05:49:09 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Oct 2021 05:49:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.202017.356666 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXdJj-0002H1-1M; Tue, 05 Oct 2021 05:48:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 202017.356666; Tue, 05 Oct 2021 05:48:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXdJi-0002Gu-Um; Tue, 05 Oct 2021 05:48:42 +0000
Received: by outflank-mailman (input) for mailman id 202017;
 Tue, 05 Oct 2021 05:48:41 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mXdJh-0002Gk-Hx; Tue, 05 Oct 2021 05:48:41 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mXdJh-0004GS-9f; Tue, 05 Oct 2021 05:48:41 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mXdJg-0005f9-Sx; Tue, 05 Oct 2021 05:48:41 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mXdJg-0005AZ-SP; Tue, 05 Oct 2021 05:48:40 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=5wMM4hm1J3mpLPLHawWYztEtcTcasd3sxo0+ugmrGDU=; b=JRnKU1x6MPGG5u2g6Csy4JKti7
	SQfxUfNbmPpATiJE1hc4AON/qtGiU8RUyd9gzXEY0XwogE2moqtRWMnIEakaC/5ks0t6t6jv2DPZH
	shaxaqGrSKGTpPk+y4c/gUaMsmI8cy5HyuZVing594DvR7jXyK5Vr89IeLirVxgR1jew=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165345-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 165345: regressions - FAIL
X-Osstest-Failures:
    qemu-mainline:test-arm64-arm64-libvirt-raw:guest-start/debian.repeat:fail:regression
    qemu-mainline:test-amd64-i386-libvirt-xsm:guest-start/debian.repeat:fail:heisenbug
    qemu-mainline:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=30bd1db58b09c12b68c35f041f919014b885482d
X-Osstest-Versions-That:
    qemuu=99c44988d5ba1866a411450c877ed818b1b70081
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 05 Oct 2021 05:48:40 +0000

flight 165345 qemu-mainline real [real]
flight 165372 qemu-mainline real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/165345/
http://logs.test-lab.xenproject.org/osstest/logs/165372/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-arm64-arm64-libvirt-raw 17 guest-start/debian.repeat fail REGR. vs. 164950

Tests which are failing intermittently (not blocking):
 test-amd64-i386-libvirt-xsm 20 guest-start/debian.repeat fail pass in 165372-retest

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds    18 guest-start/debian.repeat fail REGR. vs. 164950

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 164950
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 164950
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 164950
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 164950
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 164950
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 164950
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 164950
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 164950
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 qemuu                30bd1db58b09c12b68c35f041f919014b885482d
baseline version:
 qemuu                99c44988d5ba1866a411450c877ed818b1b70081

Last test of basis   164950  2021-09-11 18:57:22 Z   23 days
Failing since        164967  2021-09-13 13:06:52 Z   21 days   32 attempts
Testing same since   165345  2021-10-04 12:39:09 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Alex Chen <alex.chen@huawei.com>
  Alexander Graf <agraf@csgraf.de>
  Alexandra Clifford <aclifford@draper.com>
  AlexChen <alex.chen@huawei.com>
  Alistair Francis <alistair.francis@wdc.com>
  Amanda Strnad <astrnad@draper.com>
  Andrew Jeffery <andrew@aj.id.au>
  Anup Patel <anup.patel@wdc.com>
  BALATON Zoltan <balaton@eik.bme.hu>
  Bin Meng <bin.meng@windriver.com>
  Bin Meng <bmeng.cn@gmail.com>
  Cai Huoqing <caihuoqing@baidu.com>
  Chris Rauer <crauer@google.com>
  Cleber Rosa <crosa@redhat.com>
  Cornelia Huck <cohuck@redhat.com>
  Cédric Le Goater <clg@kaod.org>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniel P. Berrangé <berrange@redhat.com>
  David Gibson <david@gibson.dropbear.id.au>
  David Hildenbrand <david@redhat.com>
  Dongli Zhang <dongli.zhang@oracle.com>
  Dr. David Alan Gilbert <dgilbert@redhat.com>
  Edgar E. Iglesias <edgar.iglesias@xilinx.com>
  Eric Blake <eblake@redhat.com>
  Frank Chang <frank.chang@sifive.com>
  G S Niteesh Babu <niteesh.gs@gmail.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Green Wan <green.wan@sifive.com>
  Guenter Roeck <linux@roeck-us.net>
  Hanna Reitz <hreitz@redhat.com>
  Igor Mammedov <imammedo@redhat.com>
  Ilya Leoshkevich <iii@linux.ibm.com>
  Jason Wang <jasowang@redhat.com>
  Joel Stanley <joel@jms.id.au>
  John Arbuckle <programmingkidx@gmail.com>
  John Snow <jsnow@redhat.com>
  John Snow <jsnow@redhat.com> (Feel free to merge.)
  Jose R. Ziviani <jziviani@suse.de>
  Justin Restivo <jrestivo@draper.com>
  Kai Huang <kai.huang@intel.com>
  Kirill Tkhai <ktkhai@virtuozzo.com>
  Klaus Jensen <k.jensen@samsung.com>
  Lara Lazier <laramglazier@gmail.com>
  Laurent Vivier <laurent@vivier.eu>
  LIU Zhiwei <zhiwei_liu@c-sky.com>
  Luc Michel <lmichel@kalray.eu>
  Luis Pires <luis.pires@eldorado.org.br>
  Marc Zyngier <maz@kernel.org>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
  Markus Armbruster <armbru@redhat.com>
  Matheus Ferst <matheus.ferst@eldorado.org.br>
  Max Hsu <max.hsu@sifive.com>
  Max Reitz <mreitz@redhat.com>
  Michael S. Tsirkin <mst@redhat.com>
  Michael Tokarev <mjt@tls.msk.ru>
  Michal Privoznik <mprivozn@redhat.com>
  Naveen Nagar <naveen.n1@samsung.com>
  Neil Armstrong <narmstrong@baylibre.com>
  nia <nia@NetBSD.org>
  Nia Alarie <nia@NetBSD.org>
  Niek Linnenbank <nieklinnenbank@gmail.com>
  Nir Soffer <nirsof@gmail.com>
  Nir Soffer <nsoffer@redhat.com>
  Pankaj Gupta <pankaj.gupta.linux@gmail.com>
  Pankaj Raghav <p.raghav@samsung.com>
  Paolo Bonzini <pbonzini@redhat.com>
  Pavel Dovgalyuk <Pavel.Dovgaluk@ispras.ru>
  Pavel Dovgalyuk <Pavel.Dovgalyuk@ispras.ru>
  Peter Collingbourne <pcc@google.com>
  Peter Delevoryas <pdel@fb.com>
  Peter Maydell <peter.maydell@linaro.org>
  Peter Xu <peterx@redhat.com>
  Philippe Mathieu-Daudé <f4bug@amsat.org>
  Philippe Mathieu-Daudé <philmd@redhat.com>
  Reinoud Zandijk <Reinoud@NetBSD.org>
  Richard Henderson <richard.henderson@linaro.org>
  Richard W.M. Jones <rjones@redhat.com>
  Roman Bolshakov <r.bolshakov@yadro.com>
  Roman Bolshakov <r.bolshakov@yadro.com> (x86 only)
  Sai Pavan Boddu <sai.pavan.boddu@xilinx.com>
  Sean Christopherson <sean.j.christopherson@intel.com>
  Sergio Lopez <slp@redhat.com>
  Shashi Mallela <shashi.mallela@linaro.org>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Weil <sw@weilnetz.de>
  Stefano Garzarella <sgarzare@redhat.com>
  Thomas Huth <thuth@redhat.com>
  Tong Ho <tong.ho@xilinx.com>
  Viktor Prutyanov <viktor.prutyanov@phystech.edu>
  Vitaly Kuznetsov <vkuznets@redhat.com>
  Vivek Kasireddy <vivek.kasireddy@intel.com>
  Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
  Wainer dos Santos Moschetta <wainersm@redhat.com>
  Willian Rampazzo <willianr@redhat.com>
  Xuzhou Cheng <xuzhou.cheng@windriver.com>
  Yanan Wang <wangyanan55@huawei.com>
  Yang Zhong <yang.zhong@intel.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  fail    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 fail    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 11144 lines long.)


From xen-devel-bounces@lists.xenproject.org Tue Oct 05 06:39:04 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Oct 2021 06:39:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.202026.356681 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXe6L-0007Me-ME; Tue, 05 Oct 2021 06:38:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 202026.356681; Tue, 05 Oct 2021 06:38:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXe6L-0007MX-Ia; Tue, 05 Oct 2021 06:38:57 +0000
Received: by outflank-mailman (input) for mailman id 202026;
 Tue, 05 Oct 2021 06:38:56 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=/jnY=OZ=suse.com=jgross@srs-us1.protection.inumbo.net>)
 id 1mXe6J-0007MR-W9
 for xen-devel@lists.xenproject.org; Tue, 05 Oct 2021 06:38:56 +0000
Received: from smtp-out2.suse.de (unknown [195.135.220.29])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id e8e216be-25a6-11ec-beca-12813bfff9fa;
 Tue, 05 Oct 2021 06:38:54 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 1C0331FD36;
 Tue,  5 Oct 2021 06:38:54 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E35551342A;
 Tue,  5 Oct 2021 06:38:53 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id fy0SNv3yW2FXNQAAMHmgww
 (envelope-from <jgross@suse.com>); Tue, 05 Oct 2021 06:38:53 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e8e216be-25a6-11ec-beca-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1633415934; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=u2W/0sxDK5AgRn31zQVuvVIXL6AfZ7cpXZaqC4+mztM=;
	b=rrJL+J42VjixomPyBgL7vDUJbWWKd9BEntB5ONZ35Z5mKlBDMV/5HwyYiTsSOT0ed+elDJ
	OWIEy5ZnJPiYFOeVtucXOFEr4WrspX9JrgN/XYE4/FlqCq6F3JcHzFHj1Sv1zpg4wnXGjD
	48faCppWhh34QVyQ0XYG7zBBs/Ln0JI=
Subject: Re: [PATCH v2 0/9] xen/x86: PVH Dom0 fixes and fallout adjustments
To: Jan Beulich <jbeulich@suse.com>,
 Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 lkml <linux-kernel@vger.kernel.org>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <9a26d4ff-80a1-e0c1-f528-31a8568d41f7@suse.com>
From: Juergen Gross <jgross@suse.com>
Message-ID: <e3f4db18-fe1b-ef73-84d6-a3351d83f8f3@suse.com>
Date: Tue, 5 Oct 2021 08:38:53 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <9a26d4ff-80a1-e0c1-f528-31a8568d41f7@suse.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="k1flIbnjlsz2Q2MNiCXDWuMdIfECCPdRQ"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--k1flIbnjlsz2Q2MNiCXDWuMdIfECCPdRQ
Content-Type: multipart/mixed; boundary="lO92llj5y9yTNSIOiYW1T1WQ1BtZ6KvPL";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Jan Beulich <jbeulich@suse.com>,
 Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 lkml <linux-kernel@vger.kernel.org>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Message-ID: <e3f4db18-fe1b-ef73-84d6-a3351d83f8f3@suse.com>
Subject: Re: [PATCH v2 0/9] xen/x86: PVH Dom0 fixes and fallout adjustments
References: <9a26d4ff-80a1-e0c1-f528-31a8568d41f7@suse.com>
In-Reply-To: <9a26d4ff-80a1-e0c1-f528-31a8568d41f7@suse.com>

--lO92llj5y9yTNSIOiYW1T1WQ1BtZ6KvPL
Content-Type: multipart/mixed;
 boundary="------------1FD4F71C571D2E8C96218F6F"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------1FD4F71C571D2E8C96218F6F
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 30.09.21 14:12, Jan Beulich wrote:
> In order to try to debug hypervisor side breakage from XSA-378 I found
> myself urged to finally give PVH Dom0 a try. Sadly things didn't work
> quite as expected. In the course of investigating these issues I actual=
ly
> spotted one piece of PV Dom0 breakage as well, a fix for which is also
> included here.
>=20
> There are one immediate remaining issues: Dom0, unlike in the PV case,
> cannot access the screen (to use as a console) when in a non-default
> mode (i.e. not 80x25 text), as the necessary information (in particular=

> about VESA-bases LFB modes) is not communicated. On the hypervisor side=

> this looks like deliberate behavior, but it is unclear to me what the
> intentions were towards an alternative model. (X may be able to access
> the screen depending on whether it has a suitable driver besides the
> presently unusable /dev/fb<N> based one.)
>=20
> v2 merely addresses small review comments in patches 7 and 9 (see there=
).
>=20
> 1: xen/x86: prevent PVH type from getting clobbered
> 2: xen/x86: allow PVH Dom0 without XEN_PV=3Dy
> 3: xen/x86: make "earlyprintk=3Dxen" work better for PVH Dom0
> 4: xen/x86: allow "earlyprintk=3Dxen" to work for PV Dom0
> 5: xen/x86: make "earlyprintk=3Dxen" work for HVM/PVH DomU
> 6: xen/x86: generalize preferred console model from PV to PVH Dom0
> 7: xen/x86: hook up xen_banner() also for PVH
> 8: x86/PVH: adjust function/data placement
> 9: xen/x86: adjust data placement

Series pushed to xen/tip.git for-linus-5.15b


Juergen


--------------1FD4F71C571D2E8C96218F6F
Content-Type: application/pgp-keys;
 name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Transfer-Encoding: quoted-printable
Content-Description: OpenPGP public key
Content-Disposition: attachment;
 filename="OpenPGP_0xB0DE9DD628BF132F.asc"

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy=
cWx
w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O=
f8Z
d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y=
9bf
IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq=
G7/
377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR=
3Jv
c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA=
QIe
AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT=
hpw
dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0=
MbD
1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv=
oPH
Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v=
5QL
+qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ=
2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC=
QoL
BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr=
Wf0
teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC=
/nu
AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh=
ITT
d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm=
XBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz=
80h
SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC=
AcD
AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn=
FOX
gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1=
jnD
kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0=
N51
N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l=
otu
fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1=
tqS
EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA=
hsD
BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3=
g3O
ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5=
dM7
wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5=
D+j
LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm=
V2x
AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N=
Eaw
QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW=
nHI
s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR=
wgn
BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV=
bVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk=
pEd
IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA=
QAB
wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw=
Tbe
8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1=
vJz
Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8=
VGi
wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW=
svi
uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX=
zXs
ZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------1FD4F71C571D2E8C96218F6F--

--lO92llj5y9yTNSIOiYW1T1WQ1BtZ6KvPL--

--k1flIbnjlsz2Q2MNiCXDWuMdIfECCPdRQ
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmFb8v0FAwAAAAAACgkQsN6d1ii/Ey/r
ygf+JsV9JgkOA9ziBmzoFUbqdSlb+9FIA4VJWD1jM5K9/QeDROVDGg8n0hcHQlEFjMw6z42qK28X
Q18A2UgSACIRTT0gXypsKCZM2y5y+WTHtsVY6c/Bs70kaV+3EKDzaWPRfNWeB5h62i3EbW5G+As+
t76FduJiec8hgRwG1DJNqvNa9+puyoZB1TTa+y0kQhFWgCE8fuYKwVi5g6gbuc8sKbbmS+at6m1r
lEq/Xb4ZaVD+QsCGSqtWsoOdg2vITcqDBUP72kpmXIHn2z8MSHWeew0moilVX1+m/k3LqZpvJ9EG
UmYk9QcagAjF2gxN9POs+w+ajL4hsdpWay92Okym+w==
=OtMC
-----END PGP SIGNATURE-----

--k1flIbnjlsz2Q2MNiCXDWuMdIfECCPdRQ--


From xen-devel-bounces@lists.xenproject.org Tue Oct 05 06:39:29 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Oct 2021 06:39:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.202033.356691 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXe6r-0007wX-3t; Tue, 05 Oct 2021 06:39:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 202033.356691; Tue, 05 Oct 2021 06:39:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXe6r-0007wQ-0T; Tue, 05 Oct 2021 06:39:29 +0000
Received: by outflank-mailman (input) for mailman id 202033;
 Tue, 05 Oct 2021 06:39:28 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=/jnY=OZ=suse.com=jgross@srs-us1.protection.inumbo.net>)
 id 1mXe6q-0007wI-Jx
 for xen-devel@lists.xenproject.org; Tue, 05 Oct 2021 06:39:28 +0000
Received: from smtp-out2.suse.de (unknown [195.135.220.29])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 7eb21f64-ef94-4474-b53b-ba036ae8cfb1;
 Tue, 05 Oct 2021 06:39:27 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 8E44B1FD36;
 Tue,  5 Oct 2021 06:39:26 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 5AF241342A;
 Tue,  5 Oct 2021 06:39:26 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id uyf5FB7zW2GGNQAAMHmgww
 (envelope-from <jgross@suse.com>); Tue, 05 Oct 2021 06:39:26 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7eb21f64-ef94-4474-b53b-ba036ae8cfb1
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1633415966; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=dWYpEXYV9sjNPviGehLG0pP9wHzleObNDw/mavVWl/0=;
	b=fft6JuCzb5unoiuZjBVsXizE72EcINeWW9YXg8vd4h1k9qfFOK8xA0Cj9V56Iy7OUsSuOg
	E3JTl+MwA9PmxWNB5hWqGEDzwojCjROECkkk86pzOAVw2qBu7+YljGw8KCDt1V87wOjTG+
	G80T0q4MnUwbZ6Vg+Atf+ULM3WXMuao=
Subject: Re: [PATCH 0/3] xen/privcmd: misc corrections
To: Jan Beulich <jbeulich@suse.com>,
 Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 lkml <linux-kernel@vger.kernel.org>
References: <0f0db6fa-2604-9a0d-1138-0063b5a39a87@suse.com>
From: Juergen Gross <jgross@suse.com>
Message-ID: <c3988598-4adb-5790-9469-737a14cce3fa@suse.com>
Date: Tue, 5 Oct 2021 08:39:25 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <0f0db6fa-2604-9a0d-1138-0063b5a39a87@suse.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="94Eoth6dECSDxrwwJtHA7upVUo2q7SqXq"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--94Eoth6dECSDxrwwJtHA7upVUo2q7SqXq
Content-Type: multipart/mixed; boundary="jbfv3Avx4L5Q5VbqwZrboCOrhcGGH7iRD";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Jan Beulich <jbeulich@suse.com>,
 Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 lkml <linux-kernel@vger.kernel.org>
Message-ID: <c3988598-4adb-5790-9469-737a14cce3fa@suse.com>
Subject: Re: [PATCH 0/3] xen/privcmd: misc corrections
References: <0f0db6fa-2604-9a0d-1138-0063b5a39a87@suse.com>
In-Reply-To: <0f0db6fa-2604-9a0d-1138-0063b5a39a87@suse.com>

--jbfv3Avx4L5Q5VbqwZrboCOrhcGGH7iRD
Content-Type: multipart/mixed;
 boundary="------------54CD2FB1622E45F5F21292E1"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------54CD2FB1622E45F5F21292E1
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 22.09.21 12:14, Jan Beulich wrote:
> The three changes here are largely independent, except for a contextual=

> dependency between 2 and 3. Note that patch 1 will need actually testin=
g,
> on Arm.
>=20
> 1: replace kcalloc() by kvcalloc() when allocating empty pages
> 2: fix error handling in mmap-resource processing
> 3: drop "pages" parameter from xen_remap_pfn()

Series pushed to xen/tip.git for-linus-5.15b


Juergen


--------------54CD2FB1622E45F5F21292E1
Content-Type: application/pgp-keys;
 name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Transfer-Encoding: quoted-printable
Content-Description: OpenPGP public key
Content-Disposition: attachment;
 filename="OpenPGP_0xB0DE9DD628BF132F.asc"

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy=
cWx
w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O=
f8Z
d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y=
9bf
IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq=
G7/
377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR=
3Jv
c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA=
QIe
AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT=
hpw
dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0=
MbD
1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv=
oPH
Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v=
5QL
+qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ=
2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC=
QoL
BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr=
Wf0
teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC=
/nu
AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh=
ITT
d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm=
XBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz=
80h
SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC=
AcD
AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn=
FOX
gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1=
jnD
kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0=
N51
N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l=
otu
fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1=
tqS
EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA=
hsD
BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3=
g3O
ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5=
dM7
wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5=
D+j
LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm=
V2x
AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N=
Eaw
QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW=
nHI
s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR=
wgn
BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV=
bVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk=
pEd
IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA=
QAB
wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw=
Tbe
8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1=
vJz
Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8=
VGi
wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW=
svi
uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX=
zXs
ZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------54CD2FB1622E45F5F21292E1--

--jbfv3Avx4L5Q5VbqwZrboCOrhcGGH7iRD--

--94Eoth6dECSDxrwwJtHA7upVUo2q7SqXq
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmFb8x0FAwAAAAAACgkQsN6d1ii/Ey87
4wf+LDJVPtgCNGkpNMUiMKx/jTOwSKHvS55sxRFr4eUAaKXiPcMC2cxOGa9MahpQABIkLvGqW/FV
MG/pQz8HqwsikoAXU9N2prLJTULnbPydckVC73cnp2xoelZMSzeJd2O2qrZ9BTUCgNHELZhuGuew
WCapGpHlYfEZimQheR0qw1YgxyHEeRhy8S8Jee9CXC4tW6OOU2uTLa+eLTYbQnNHOoMgjGXfFLfq
OuWpATsx5kq7pnkR3wUePGTld12Rmeb+tYLsHLQ+E6dGm4ISeAnepdDlVtSENVagPlBIB7BDTdNk
ORMX8xE74G5HPajrVi799kd+3YkydONObRyTrc8s/A==
=xBsz
-----END PGP SIGNATURE-----

--94Eoth6dECSDxrwwJtHA7upVUo2q7SqXq--


From xen-devel-bounces@lists.xenproject.org Tue Oct 05 07:32:00 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Oct 2021 07:32:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.202044.356702 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXevJ-0005RC-26; Tue, 05 Oct 2021 07:31:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 202044.356702; Tue, 05 Oct 2021 07:31:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXevI-0005R5-VN; Tue, 05 Oct 2021 07:31:36 +0000
Received: by outflank-mailman (input) for mailman id 202044;
 Tue, 05 Oct 2021 07:31:35 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mXevH-0005Qv-RN; Tue, 05 Oct 2021 07:31:35 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mXevH-00063B-LP; Tue, 05 Oct 2021 07:31:35 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mXevH-0003dE-96; Tue, 05 Oct 2021 07:31:35 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mXevH-0006lt-8a; Tue, 05 Oct 2021 07:31:35 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=1tqaf1zw9e3ShtR2BGl6Bg9Ur2wxVguP22XWjR/kjOk=; b=enALwnpiesTfauz45/FQfwXe35
	kg0zHeBw+mCEb0bHtxcPdYkjWOzOxmte2IrX0tmeIYq3SaJP6pZDj85p4BetcX/JnHdXLWZ+UbEAM
	9UtsCAHgOMvaQrUtuypZsodGQ3BAuQFC4Ks3XzHmSBRAXCoAQsTvTkMEcLq3fg1CwZ10=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165349-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xtf test] 165349: all pass - PUSHED
X-Osstest-Versions-This:
    xtf=61e6f40b07d256bd62ae7b231a3eeecd49d0b15b
X-Osstest-Versions-That:
    xtf=91d215a4ed1463ab14d1f68e497117ac1255e05e
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 05 Oct 2021 07:31:35 +0000

flight 165349 xtf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165349/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 xtf                  61e6f40b07d256bd62ae7b231a3eeecd49d0b15b
baseline version:
 xtf                  91d215a4ed1463ab14d1f68e497117ac1255e05e

Last test of basis   164867  2021-09-07 00:10:12 Z   28 days
Testing same since   165349  2021-10-04 12:43:20 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Michal Orzel <michal.orzel@arm.com>

jobs:
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-amd64-pvops                                            pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xtf.git
   91d215a..61e6f40  61e6f40b07d256bd62ae7b231a3eeecd49d0b15b -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Tue Oct 05 07:43:44 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Oct 2021 07:43:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.202053.356716 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXf6y-0006zn-5u; Tue, 05 Oct 2021 07:43:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 202053.356716; Tue, 05 Oct 2021 07:43:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXf6y-0006zg-2w; Tue, 05 Oct 2021 07:43:40 +0000
Received: by outflank-mailman (input) for mailman id 202053;
 Tue, 05 Oct 2021 07:43:39 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=u4De=OZ=arm.com=Rahul.Singh@srs-us1.protection.inumbo.net>)
 id 1mXf6w-0006za-TJ
 for xen-devel@lists.xenproject.org; Tue, 05 Oct 2021 07:43:39 +0000
Received: from EUR02-VE1-obe.outbound.protection.outlook.com (unknown
 [40.107.2.45]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 0e7bb8f0-c546-4065-9e1b-9b0060d13ea4;
 Tue, 05 Oct 2021 07:43:35 +0000 (UTC)
Received: from DU2PR04CA0176.eurprd04.prod.outlook.com (2603:10a6:10:2b0::31)
 by AM9PR08MB5891.eurprd08.prod.outlook.com (2603:10a6:20b:2da::15)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.16; Tue, 5 Oct
 2021 07:43:32 +0000
Received: from DB5EUR03FT059.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:10:2b0:cafe::71) by DU2PR04CA0176.outlook.office365.com
 (2603:10a6:10:2b0::31) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.14 via Frontend
 Transport; Tue, 5 Oct 2021 07:43:32 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT059.mail.protection.outlook.com (10.152.21.175) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4566.14 via Frontend Transport; Tue, 5 Oct 2021 07:43:32 +0000
Received: ("Tessian outbound ab2dc3678fa9:v103");
 Tue, 05 Oct 2021 07:43:29 +0000
Received: from 9fe1b0cac182.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 4FFAC81B-2474-44A9-9E7F-F05F85B4957C.1; 
 Tue, 05 Oct 2021 07:34:18 +0000
Received: from EUR01-HE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 9fe1b0cac182.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Tue, 05 Oct 2021 07:34:18 +0000
Received: from AS8PR08MB6919.eurprd08.prod.outlook.com (2603:10a6:20b:39e::10)
 by AS8PR08MB5894.eurprd08.prod.outlook.com (2603:10a6:20b:23d::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.22; Tue, 5 Oct
 2021 07:34:15 +0000
Received: from AS8PR08MB6919.eurprd08.prod.outlook.com
 ([fe80::51ee:e7de:6c0a:bcf9]) by AS8PR08MB6919.eurprd08.prod.outlook.com
 ([fe80::51ee:e7de:6c0a:bcf9%7]) with mapi id 15.20.4566.022; Tue, 5 Oct 2021
 07:34:15 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0e7bb8f0-c546-4065-9e1b-9b0060d13ea4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=621Gdoql2gRLF9H+142u83hVc6sJjBA7jvCykI/wD44=;
 b=EwiBKIqSEhRJK1aelsWDasp3lBSjd2RwJP4O+EzG4QQk83gklA7gS7nkARC0Qdk22dga4ObbydAFSm8Iziedb53a271muJSajRT0CDhkhHfYGTZ2grPyqhQTqJRn5CPPpV4BcwpzUtcVMzKx40NUV+g64B3G0VoDz83gY4UP5Rc=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 4a96208a4dffac71
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=PdOIo8jUMKzjcF3FJzFKpxqL2GFWJprZZKK7G6b5hOJYpVlKdp+6DFqEIPTe6MGeLCSAoQ2QkJYM//Wj0d2Lzxcaew1xIJskE0ta0+8kPX0aKmXSfexVKTfgWdCG4yhvFVNdgoux6ErKsHxhhk1lkAE/adcWIpbgmxOVm9ZOsiSrduuqoynmuMltzaVo09I0FCcrPZXX1FDA6B+r0641p0ILJVb1whVKEXmbwBqu2Mg9XYHz/jLv/EY00DF7rUxU8V5rZ8yeMxPKeHTngUxLnaG+7mJMEXvCMp5Nbj3xajOJLTWmd3bj6/fxM/1sLmDJRDwPtLaLucLYOSpYlgHPOw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=621Gdoql2gRLF9H+142u83hVc6sJjBA7jvCykI/wD44=;
 b=PzjRuRn0rBoi/MO4WtA+wMHX3segF7DCNKmuVg5HN0+7vk8gL3+GXRSznkoeV9SUeaLQhohC3CzU8QhPin6UHdeEYDcz/VBjhiiiouK67E3vRs2JwwZKTZ3xg0HytieCngDco8RrDxMdndq7AYNV8V8BydxjTCpqXNkvhsWeSWyxwws9LV0ymm+pybdJmduc+P9LtNrLPy2i4DKoYVTTkuBiqexbf4qb0PeA3hsB87CeHetrKlz3rBmcDfnI3LmFnuWfs4201j3xO2SVRFcEoHwumqTcbgtNLuEBqVOhmqIOa08kdZovJ49crfCIvKSLsN+CUMIFWMfuYThejH07XA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=621Gdoql2gRLF9H+142u83hVc6sJjBA7jvCykI/wD44=;
 b=EwiBKIqSEhRJK1aelsWDasp3lBSjd2RwJP4O+EzG4QQk83gklA7gS7nkARC0Qdk22dga4ObbydAFSm8Iziedb53a271muJSajRT0CDhkhHfYGTZ2grPyqhQTqJRn5CPPpV4BcwpzUtcVMzKx40NUV+g64B3G0VoDz83gY4UP5Rc=
From: Rahul Singh <Rahul.Singh@arm.com>
To: Stefano Stabellini <sstabellini@kernel.org>
CC: xen-devel <xen-devel@lists.xenproject.org>, Bertrand Marquis
	<Bertrand.Marquis@arm.com>, Andre Przywara <Andre.Przywara@arm.com>, Julien
 Grall <julien@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>, George Dunlap
	<george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>, Jan Beulich
	<jbeulich@suse.com>, Wei Liu <wl@xen.org>, Paul Durrant <paul@xen.org>,
	=?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>
Subject: Re: [PATCH v4 11/14] xen/arm: Enable the existing x86 virtual PCI
 support for ARM.
Thread-Topic: [PATCH v4 11/14] xen/arm: Enable the existing x86 virtual PCI
 support for ARM.
Thread-Index: AQHXuRcRiSW8RsNjUEeU84oxStOA9qvDkGCAgAB0PAA=
Date: Tue, 5 Oct 2021 07:34:15 +0000
Message-ID: <EF3D84D5-0719-4578-BA5F-8EB45379A950@arm.com>
References: <cover.1633340795.git.rahul.singh@arm.com>
 <f093de681c2560a7196895bcd666ef8840885c1d.1633340795.git.rahul.singh@arm.com>
 <alpine.DEB.2.21.2110041709380.3209@sstabellini-ThinkPad-T480s>
In-Reply-To: <alpine.DEB.2.21.2110041709380.3209@sstabellini-ThinkPad-T480s>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
Authentication-Results-Original: kernel.org; dkim=none (message not signed)
 header.d=none;kernel.org; dmarc=none action=none header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: 6dae416e-2049-4ef6-e9a7-08d987d3d458
x-ms-traffictypediagnostic: AS8PR08MB5894:|AM9PR08MB5891:
x-ms-exchange-transport-forked: True
X-Microsoft-Antispam-PRVS:
	<AM9PR08MB5891681893DCADED47A6121FFCAF9@AM9PR08MB5891.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:4125;OLM:4125;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 NGYusHwlzZQdgvlznjuxVrW/037ExiPoXvub0Q9NDEYrqUMPumdecBopySRFbcZjII21YWkg61oztv/nwHjvjy9wARGes4pIu1wQGiEAwxrVuY6VnYdWQd1ruDvG9vB7S1k/ubNIOx0Tq/O+6PpNzd5UkDuiPPywcLessjcFGZ2ApRAZp2/2A0cyAAm+NBbBrsAI75scqI1u20bpAlQHAwMUwziZiMOJXjxetyc5SpzQxJ+ifo8PLCxCrMfKs3a2UMGvjlLeGVv9QK3V2L0paiVOt1XH7zr38iS+u7Fd67dmBkRVTYSxttFaRCZIry7HXd0VnfcMrTStxnD7rhrhl1zPCUBH2t88hRCZaOufTUpyvJcSWOyhoQaNodePloz7afzcBaE3r8zhPT6fNB+oB3vD9mn2vH4GTECgx69+ZjxGgmYyGtWV4TGkFQK/sc9oV4e1uPRX98Ec/oWBvfArCwafBuiDzGFrNraPv0CivQqqi3UAoGKsgkjS5rIJ9jbKYkeRArzyX0STuWdiatf6n1osk+/1PJ8IQ+/oHrX/znCsr9ZkQOMztBhu/GNy8ibLhtaQ/UkFZI60Bk+B/2k1IAPs+XrQ9F4gepE32ThYjtPh3lu0Vb5ByzhEnDO7twzQuyMNa+a2BVQJdDOPSyzbDmmQiBRXotvRY8YaTbOob1W32StCS8w51+vUnK6zCY8IWnt+nnQ7GKTj9I4FueMtfR3lsIvJ0lf/53zt5fWPTMmtdVHxX7Wl2s5bHVaHC8nTwx0a0l5sYiErAT4OKnuAlA==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6919.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(33656002)(36756003)(8936002)(26005)(6916009)(7416002)(6486002)(186003)(2616005)(83380400001)(53546011)(508600001)(76116006)(5660300002)(86362001)(66946007)(316002)(71200400001)(122000001)(38100700002)(6512007)(54906003)(38070700005)(2906002)(4326008)(8676002)(30864003)(64756008)(6506007)(66476007)(66446008)(91956017)(66556008)(2004002)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-ID: <B0AAD840AC06B4468D98EA0510456483@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB5894
Original-Authentication-Results: kernel.org; dkim=none (message not signed)
 header.d=none;kernel.org; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT059.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	f45054a7-a4de-4b44-f76a-08d987d2889c
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	hi7HuPpFiQwIjGjMOSsGsyZztWH9y6RuJKkAEwO8mrWepVTuhiilw8XOF0Q8+epv8ChH9hZvdL6rGzX4Z9h3DGrye9mqAnXBbIf6h1DZ+/DjWwE7reabX1Oso/s/4rdQAZVaqTrEW8O3I4a3V1tTmIsvmUB7sttjOzgKonyDizFmlkABHRgO8striNiDvZfhmQ0J3FmifwXzJDoSQqjoN8t3rBICYw9ALxxR1qb2wswyfkt3ABRcgdHY0EmVEhdGaPrHSDvLQrxXob98kcQSqvXIGR/cf4jEBlT/mDaPe4NdE34hrsePJAKI1LcvOlzDVGPnED0sK1wfLx0WoY15Yz7FGj6bZgUmhptglANF2vB41vesrHPlyql5LghqM2uMxg/LiNmpn1il0dTFU3pnxFvYSihpF21Nem3DUZHqc4oyo0y9jAFfEM0z23Ul88YqB2lU9f3OaxYeELiT/XkZ8we5tVP5EgVEVbdqf043m6yR2xkB6kcg09u8sd272RWBoQ7OmqBTuSxYlZU3B9gDJcqCTTxSHvhBbbJVqre3Rz4mPG9ll7FRWmijZwun/8+fDYGsW0bKQMlsIldlH+P/NKkQurj/8hqd3u0+5Bs8xmTnYLmXbkQ1paLcF1EhCfoLpsPTHRMjxF9YrvhE2VvOVHLyMqCWSLpVd64uLsqqvLrBE/wbn1AU2jd8HHarYPQ5tnzRcxSop1mF3HkRKSUGaWlsTuVouX2S4hbq0tcWYok=
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(6506007)(6512007)(82310400003)(2906002)(47076005)(316002)(6486002)(53546011)(336012)(4326008)(54906003)(508600001)(30864003)(83380400001)(26005)(2616005)(107886003)(6862004)(8676002)(86362001)(70206006)(186003)(36756003)(36860700001)(81166007)(8936002)(33656002)(70586007)(356005)(5660300002)(2004002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Oct 2021 07:43:32.0001
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 6dae416e-2049-4ef6-e9a7-08d987d3d458
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT059.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB5891

SGkgU3RlZmFubywNCg0KPiBPbiA1IE9jdCAyMDIxLCBhdCAxOjM4IGFtLCBTdGVmYW5vIFN0YWJl
bGxpbmkgPHNzdGFiZWxsaW5pQGtlcm5lbC5vcmc+IHdyb3RlOg0KPiANCj4gT24gTW9uLCA0IE9j
dCAyMDIxLCBSYWh1bCBTaW5naCB3cm90ZToNCj4+IFRoZSBleGlzdGluZyBWUENJIHN1cHBvcnQg
YXZhaWxhYmxlIGZvciBYODYgaXMgYWRhcHRlZCBmb3IgQXJtLg0KPj4gV2hlbiB0aGUgZGV2aWNl
IGlzIGFkZGVkIHRvIFhFTiB2aWEgdGhlIGh5cGVyIGNhbGwNCj4+IOKAnFBIWVNERVZPUF9wY2lf
ZGV2aWNlX2FkZOKAnSwgVlBDSSBoYW5kbGVyIGZvciB0aGUgY29uZmlnIHNwYWNlDQo+PiBhY2Nl
c3MgaXMgYWRkZWQgdG8gdGhlIFhlbiB0byBlbXVsYXRlIHRoZSBQQ0kgZGV2aWNlcyBjb25maWcg
c3BhY2UuDQo+PiANCj4+IEEgTU1JTyB0cmFwIGhhbmRsZXIgZm9yIHRoZSBQQ0kgRUNBTSBzcGFj
ZSBpcyByZWdpc3RlcmVkIGluIFhFTg0KPj4gc28gdGhhdCB3aGVuIGd1ZXN0IGlzIHRyeWluZyB0
byBhY2Nlc3MgdGhlIFBDSSBjb25maWcgc3BhY2UsWEVODQo+PiB3aWxsIHRyYXAgdGhlIGFjY2Vz
cyBhbmQgZW11bGF0ZSByZWFkL3dyaXRlIHVzaW5nIHRoZSBWUENJIGFuZA0KPj4gbm90IHRoZSBy
ZWFsIFBDSSBoYXJkd2FyZS4NCj4+IA0KPj4gRm9yIERvbTBsZXNzIHN5c3RlbXMgc2Nhbl9wY2lf
ZGV2aWNlcygpIHdvdWxkIGJlIHVzZWQgdG8gZGlzY292ZXIgdGhlDQo+PiBQQ0kgZGV2aWNlIGlu
IFhFTiBhbmQgVlBDSSBoYW5kbGVyIHdpbGwgYmUgYWRkZWQgZHVyaW5nIFhFTiBib290cy4NCj4+
IA0KPj4gU2lnbmVkLW9mZi1ieTogUmFodWwgU2luZ2ggPHJhaHVsLnNpbmdoQGFybS5jb20+DQo+
PiAtLS0NCj4+IENoYW5nZSBpbiB2NDoNCj4+IC0gTW92ZSBhZGRpdGlvbiBvZiBYRU5fRE9NQ1RM
X0NERl92cGNpIGZsYWcgdG8gc2VwYXJhdGUgcGF0Y2gNCj4+IENoYW5nZSBpbiB2MzoNCj4+IC0g
VXNlIGlzX3BjaV9wYXNzdGhyb3VnaF9lbmFibGVkKCkgaW4gcGxhY2Ugb2YgcGNpX3Bhc3N0aHJv
dWdoX2VuYWJsZWQgdmFyaWFibGUNCj4+IC0gUmVqZWN0IFhFTl9ET01DVExfQ0RGX3ZwY2kgZm9y
IHg4NiBpbiBhcmNoX3Nhbml0aXNlX2RvbWFpbl9jb25maWcoKQ0KPj4gLSBSZW1vdmUgSVNfRU5B
QkxFRChDT05GSUdfSEFTX1ZQQ0kpIGZyb20gaGFzX3ZwY2koKQ0KPj4gQ2hhbmdlIGluIHYyOg0K
Pj4gLSBBZGQgbmV3IFhFTl9ET01DVExfQ0RGX3ZwY2kgZmxhZw0KPj4gLSBtb2RpZnkgaGFzX3Zw
Y2koKSB0byBpbmNsdWRlIFhFTl9ET01DVExfQ0RGX3ZwY2kNCj4+IC0gZW5hYmxlIHZwY2kgc3Vw
cG9ydCB3aGVuIHBjaS1wYXNzdGhvdWdoIG9wdGlvbiBpcyBlbmFibGVkLg0KPj4gLS0tDQo+PiAt
LS0NCj4+IHhlbi9hcmNoL2FybS9NYWtlZmlsZSAgICAgICAgIHwgICAxICsNCj4+IHhlbi9hcmNo
L2FybS9kb21haW4uYyAgICAgICAgIHwgICA0ICsrDQo+PiB4ZW4vYXJjaC9hcm0vZG9tYWluX2J1
aWxkLmMgICB8ICAgMyArDQo+PiB4ZW4vYXJjaC9hcm0vdnBjaS5jICAgICAgICAgICB8IDEwMiAr
KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrDQo+PiB4ZW4vYXJjaC9hcm0vdnBjaS5o
ICAgICAgICAgICB8ICAzNiArKysrKysrKysrKysNCj4+IHhlbi9kcml2ZXJzL3Bhc3N0aHJvdWdo
L3BjaS5jIHwgIDE3ICsrKysrKw0KPj4geGVuL2luY2x1ZGUvYXNtLWFybS9kb21haW4uaCAgfCAg
IDcgKystDQo+PiB4ZW4vaW5jbHVkZS9hc20teDg2L3BjaS5oICAgICB8ICAgMiAtDQo+PiB4ZW4v
aW5jbHVkZS9wdWJsaWMvYXJjaC1hcm0uaCB8ICAgNyArKysNCj4+IHhlbi9pbmNsdWRlL3hlbi9w
Y2kuaCAgICAgICAgIHwgICAyICsNCj4+IDEwIGZpbGVzIGNoYW5nZWQsIDE3OCBpbnNlcnRpb25z
KCspLCAzIGRlbGV0aW9ucygtKQ0KPj4gY3JlYXRlIG1vZGUgMTAwNjQ0IHhlbi9hcmNoL2FybS92
cGNpLmMNCj4+IGNyZWF0ZSBtb2RlIDEwMDY0NCB4ZW4vYXJjaC9hcm0vdnBjaS5oDQo+PiANCj4+
IGRpZmYgLS1naXQgYS94ZW4vYXJjaC9hcm0vTWFrZWZpbGUgYi94ZW4vYXJjaC9hcm0vTWFrZWZp
bGUNCj4+IGluZGV4IDQ0ZDdjYzgxZmEuLmZiOWM5NzZlYTIgMTAwNjQ0DQo+PiAtLS0gYS94ZW4v
YXJjaC9hcm0vTWFrZWZpbGUNCj4+ICsrKyBiL3hlbi9hcmNoL2FybS9NYWtlZmlsZQ0KPj4gQEAg
LTcsNiArNyw3IEBAIGlmbmVxICgkKENPTkZJR19OT19QTEFUKSx5KQ0KPj4gb2JqLXkgKz0gcGxh
dGZvcm1zLw0KPj4gZW5kaWYNCj4+IG9iai0kKENPTkZJR19URUUpICs9IHRlZS8NCj4+ICtvYmot
JChDT05GSUdfSEFTX1ZQQ0kpICs9IHZwY2kubw0KPj4gDQo+PiBvYmotJChDT05GSUdfSEFTX0FM
VEVSTkFUSVZFKSArPSBhbHRlcm5hdGl2ZS5vDQo+PiBvYmoteSArPSBib290ZmR0LmluaXQubw0K
Pj4gZGlmZiAtLWdpdCBhL3hlbi9hcmNoL2FybS9kb21haW4uYyBiL3hlbi9hcmNoL2FybS9kb21h
aW4uYw0KPj4gaW5kZXggMzYxMzhjMWIyZS4uZmJiNTJmNzhmMSAxMDA2NDQNCj4+IC0tLSBhL3hl
bi9hcmNoL2FybS9kb21haW4uYw0KPj4gKysrIGIveGVuL2FyY2gvYXJtL2RvbWFpbi5jDQo+PiBA
QCAtMzksNiArMzksNyBAQA0KPj4gI2luY2x1ZGUgPGFzbS92Z2ljLmg+DQo+PiAjaW5jbHVkZSA8
YXNtL3Z0aW1lci5oPg0KPj4gDQo+PiArI2luY2x1ZGUgInZwY2kuaCINCj4+ICNpbmNsdWRlICJ2
dWFydC5oIg0KPj4gDQo+PiBERUZJTkVfUEVSX0NQVShzdHJ1Y3QgdmNwdSAqLCBjdXJyX3ZjcHUp
Ow0KPj4gQEAgLTc2Nyw2ICs3NjgsOSBAQCBpbnQgYXJjaF9kb21haW5fY3JlYXRlKHN0cnVjdCBk
b21haW4gKmQsDQo+PiAgICAgaWYgKCBpc19oYXJkd2FyZV9kb21haW4oZCkgJiYgKHJjID0gZG9t
YWluX3Z1YXJ0X2luaXQoZCkpICkNCj4+ICAgICAgICAgZ290byBmYWlsOw0KPj4gDQo+PiArICAg
IGlmICggKHJjID0gZG9tYWluX3ZwY2lfaW5pdChkKSkgIT0gMCApDQo+PiArICAgICAgICBnb3Rv
IGZhaWw7DQo+PiArDQo+PiAgICAgcmV0dXJuIDA7DQo+PiANCj4+IGZhaWw6DQo+PiBkaWZmIC0t
Z2l0IGEveGVuL2FyY2gvYXJtL2RvbWFpbl9idWlsZC5jIGIveGVuL2FyY2gvYXJtL2RvbWFpbl9i
dWlsZC5jDQo+PiBpbmRleCBjNWFmYmUyZTA1Li5mNGM4OWJkZThjIDEwMDY0NA0KPj4gLS0tIGEv
eGVuL2FyY2gvYXJtL2RvbWFpbl9idWlsZC5jDQo+PiArKysgYi94ZW4vYXJjaC9hcm0vZG9tYWlu
X2J1aWxkLmMNCj4+IEBAIC0zMDUzLDYgKzMwNTMsOSBAQCB2b2lkIF9faW5pdCBjcmVhdGVfZG9t
MCh2b2lkKQ0KPj4gICAgIGlmICggaW9tbXVfZW5hYmxlZCApDQo+PiAgICAgICAgIGRvbTBfY2Zn
LmZsYWdzIHw9IFhFTl9ET01DVExfQ0RGX2lvbW11Ow0KPj4gDQo+PiArICAgIGlmICggaXNfcGNp
X3Bhc3N0aHJvdWdoX2VuYWJsZWQoKSApDQo+PiArICAgICAgICBkb20wX2NmZy5mbGFncyB8PSBY
RU5fRE9NQ1RMX0NERl92cGNpOw0KPj4gKw0KPj4gICAgIGRvbTAgPSBkb21haW5fY3JlYXRlKDAs
ICZkb20wX2NmZywgdHJ1ZSk7DQo+PiAgICAgaWYgKCBJU19FUlIoZG9tMCkgfHwgKGFsbG9jX2Rv
bTBfdmNwdTAoZG9tMCkgPT0gTlVMTCkgKQ0KPj4gICAgICAgICBwYW5pYygiRXJyb3IgY3JlYXRp
bmcgZG9tYWluIDBcbiIpOw0KPj4gZGlmZiAtLWdpdCBhL3hlbi9hcmNoL2FybS92cGNpLmMgYi94
ZW4vYXJjaC9hcm0vdnBjaS5jDQo+PiBuZXcgZmlsZSBtb2RlIDEwMDY0NA0KPj4gaW5kZXggMDAw
MDAwMDAwMC4uNzZjMTJiOTI4MQ0KPj4gLS0tIC9kZXYvbnVsbA0KPj4gKysrIGIveGVuL2FyY2gv
YXJtL3ZwY2kuYw0KPj4gQEAgLTAsMCArMSwxMDIgQEANCj4+ICsvKg0KPj4gKyAqIHhlbi9hcmNo
L2FybS92cGNpLmMNCj4+ICsgKg0KPj4gKyAqIFRoaXMgcHJvZ3JhbSBpcyBmcmVlIHNvZnR3YXJl
OyB5b3UgY2FuIHJlZGlzdHJpYnV0ZSBpdCBhbmQvb3IgbW9kaWZ5DQo+PiArICogaXQgdW5kZXIg
dGhlIHRlcm1zIG9mIHRoZSBHTlUgR2VuZXJhbCBQdWJsaWMgTGljZW5zZSBhcyBwdWJsaXNoZWQg
YnkNCj4+ICsgKiB0aGUgRnJlZSBTb2Z0d2FyZSBGb3VuZGF0aW9uOyBlaXRoZXIgdmVyc2lvbiAy
IG9mIHRoZSBMaWNlbnNlLCBvcg0KPj4gKyAqIChhdCB5b3VyIG9wdGlvbikgYW55IGxhdGVyIHZl
cnNpb24uDQo+PiArICoNCj4+ICsgKiBUaGlzIHByb2dyYW0gaXMgZGlzdHJpYnV0ZWQgaW4gdGhl
IGhvcGUgdGhhdCBpdCB3aWxsIGJlIHVzZWZ1bCwNCj4+ICsgKiBidXQgV0lUSE9VVCBBTlkgV0FS
UkFOVFk7IHdpdGhvdXQgZXZlbiB0aGUgaW1wbGllZCB3YXJyYW50eSBvZg0KPj4gKyAqIE1FUkNI
QU5UQUJJTElUWSBvciBGSVRORVNTIEZPUiBBIFBBUlRJQ1VMQVIgUFVSUE9TRS4gIFNlZSB0aGUN
Cj4+ICsgKiBHTlUgR2VuZXJhbCBQdWJsaWMgTGljZW5zZSBmb3IgbW9yZSBkZXRhaWxzLg0KPj4g
KyAqLw0KPj4gKyNpbmNsdWRlIDx4ZW4vc2NoZWQuaD4NCj4+ICsNCj4+ICsjaW5jbHVkZSA8YXNt
L21taW8uaD4NCj4+ICsNCj4+ICsjZGVmaW5lIFJFR0lTVEVSX09GRlNFVChhZGRyKSAgKCAoYWRk
cikgJiAweDAwMDAwZmZmKQ0KPj4gKw0KPj4gKy8qIERvIHNvbWUgc2FuaXR5IGNoZWNrcy4gKi8N
Cj4+ICtzdGF0aWMgYm9vbCB2cGNpX21taW9fYWNjZXNzX2FsbG93ZWQodW5zaWduZWQgaW50IHJl
ZywgdW5zaWduZWQgaW50IGxlbikNCj4+ICt7DQo+PiArICAgIC8qIENoZWNrIGFjY2VzcyBzaXpl
LiAqLw0KPj4gKyAgICBpZiAoIGxlbiA+IDggKQ0KPj4gKyAgICAgICAgcmV0dXJuIGZhbHNlOw0K
Pj4gKw0KPj4gKyAgICAvKiBDaGVjayB0aGF0IGFjY2VzcyBpcyBzaXplIGFsaWduZWQuICovDQo+
PiArICAgIGlmICggKHJlZyAmIChsZW4gLSAxKSkgKQ0KPj4gKyAgICAgICAgcmV0dXJuIGZhbHNl
Ow0KPj4gKw0KPj4gKyAgICByZXR1cm4gdHJ1ZTsNCj4+ICt9DQo+PiArDQo+PiArc3RhdGljIGlu
dCB2cGNpX21taW9fcmVhZChzdHJ1Y3QgdmNwdSAqdiwgbW1pb19pbmZvX3QgKmluZm8sDQo+PiAr
ICAgICAgICAgICAgICAgICAgICAgICAgICByZWdpc3Rlcl90ICpyLCB2b2lkICpwKQ0KPj4gK3sN
Cj4+ICsgICAgdW5zaWduZWQgaW50IHJlZzsNCj4+ICsgICAgcGNpX3NiZGZfdCBzYmRmOw0KPj4g
KyAgICB1bnNpZ25lZCBsb25nIGRhdGEgPSB+MFVMOw0KPj4gKyAgICB1bnNpZ25lZCBpbnQgc2l6
ZSA9IDFVIDw8IGluZm8tPmRhYnQuc2l6ZTsNCj4+ICsNCj4+ICsgICAgc2JkZi5zYmRmID0gTU1D
RkdfQkRGKGluZm8tPmdwYSk7DQo+PiArICAgIHJlZyA9IFJFR0lTVEVSX09GRlNFVChpbmZvLT5n
cGEpOw0KPj4gKw0KPj4gKyAgICBpZiAoICF2cGNpX21taW9fYWNjZXNzX2FsbG93ZWQocmVnLCBz
aXplKSApDQo+PiArICAgICAgICByZXR1cm4gMDsNCj4+ICsNCj4+ICsgICAgZGF0YSA9IHZwY2lf
cmVhZChzYmRmLCByZWcsIG1pbig0dSwgc2l6ZSkpOw0KPj4gKyAgICBpZiAoIHNpemUgPT0gOCAp
DQo+PiArICAgICAgICBkYXRhIHw9ICh1aW50NjRfdCl2cGNpX3JlYWQoc2JkZiwgcmVnICsgNCwg
NCkgPDwgMzI7DQo+PiArDQo+PiArICAgICpyID0gZGF0YTsNCj4+ICsNCj4+ICsgICAgcmV0dXJu
IDE7DQo+PiArfQ0KPj4gKw0KPj4gK3N0YXRpYyBpbnQgdnBjaV9tbWlvX3dyaXRlKHN0cnVjdCB2
Y3B1ICp2LCBtbWlvX2luZm9fdCAqaW5mbywNCj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAg
ICByZWdpc3Rlcl90IHIsIHZvaWQgKnApDQo+PiArew0KPj4gKyAgICB1bnNpZ25lZCBpbnQgcmVn
Ow0KPj4gKyAgICBwY2lfc2JkZl90IHNiZGY7DQo+PiArICAgIHVuc2lnbmVkIGxvbmcgZGF0YSA9
IHI7DQo+PiArICAgIHVuc2lnbmVkIGludCBzaXplID0gMVUgPDwgaW5mby0+ZGFidC5zaXplOw0K
Pj4gKw0KPj4gKyAgICBzYmRmLnNiZGYgPSBNTUNGR19CREYoaW5mby0+Z3BhKTsNCj4+ICsgICAg
cmVnID0gUkVHSVNURVJfT0ZGU0VUKGluZm8tPmdwYSk7DQo+PiArDQo+PiArICAgIGlmICggIXZw
Y2lfbW1pb19hY2Nlc3NfYWxsb3dlZChyZWcsIHNpemUpICkNCj4+ICsgICAgICAgIHJldHVybiAw
Ow0KPj4gKw0KPj4gKyAgICB2cGNpX3dyaXRlKHNiZGYsIHJlZywgbWluKDR1LCBzaXplKSwgZGF0
YSk7DQo+PiArICAgIGlmICggc2l6ZSA9PSA4ICkNCj4+ICsgICAgICAgIHZwY2lfd3JpdGUoc2Jk
ZiwgcmVnICsgNCwgNCwgZGF0YSA+PiAzMik7DQo+PiArDQo+PiArICAgIHJldHVybiAxOw0KPj4g
K30NCj4+ICsNCj4+ICtzdGF0aWMgY29uc3Qgc3RydWN0IG1taW9faGFuZGxlcl9vcHMgdnBjaV9t
bWlvX2hhbmRsZXIgPSB7DQo+PiArICAgIC5yZWFkICA9IHZwY2lfbW1pb19yZWFkLA0KPj4gKyAg
ICAud3JpdGUgPSB2cGNpX21taW9fd3JpdGUsDQo+PiArfTsNCj4+ICsNCj4+ICtpbnQgZG9tYWlu
X3ZwY2lfaW5pdChzdHJ1Y3QgZG9tYWluICpkKQ0KPj4gK3sNCj4+ICsgICAgaWYgKCAhaGFzX3Zw
Y2koZCkgKQ0KPj4gKyAgICAgICAgcmV0dXJuIDA7DQo+PiArDQo+PiArICAgIHJlZ2lzdGVyX21t
aW9faGFuZGxlcihkLCAmdnBjaV9tbWlvX2hhbmRsZXIsDQo+PiArICAgICAgICAgICAgICAgICAg
ICAgICAgICBHVUVTVF9WUENJX0VDQU1fQkFTRSwgR1VFU1RfVlBDSV9FQ0FNX1NJWkUsIE5VTEwp
Ow0KPj4gKw0KPj4gKyAgICByZXR1cm4gMDsNCj4+ICt9DQo+PiArDQo+PiArLyoNCj4+ICsgKiBM
b2NhbCB2YXJpYWJsZXM6DQo+PiArICogbW9kZTogQw0KPj4gKyAqIGMtZmlsZS1zdHlsZTogIkJT
RCINCj4+ICsgKiBjLWJhc2ljLW9mZnNldDogNA0KPj4gKyAqIGluZGVudC10YWJzLW1vZGU6IG5p
bA0KPj4gKyAqIEVuZDoNCj4+ICsgKi8NCj4+ICsNCj4+IGRpZmYgLS1naXQgYS94ZW4vYXJjaC9h
cm0vdnBjaS5oIGIveGVuL2FyY2gvYXJtL3ZwY2kuaA0KPj4gbmV3IGZpbGUgbW9kZSAxMDA2NDQN
Cj4+IGluZGV4IDAwMDAwMDAwMDAuLmQ4YTdiMGUzZTgNCj4+IC0tLSAvZGV2L251bGwNCj4+ICsr
KyBiL3hlbi9hcmNoL2FybS92cGNpLmgNCj4+IEBAIC0wLDAgKzEsMzYgQEANCj4+ICsvKg0KPj4g
KyAqIHhlbi9hcmNoL2FybS92cGNpLmgNCj4+ICsgKg0KPj4gKyAqIFRoaXMgcHJvZ3JhbSBpcyBm
cmVlIHNvZnR3YXJlOyB5b3UgY2FuIHJlZGlzdHJpYnV0ZSBpdCBhbmQvb3IgbW9kaWZ5DQo+PiAr
ICogaXQgdW5kZXIgdGhlIHRlcm1zIG9mIHRoZSBHTlUgR2VuZXJhbCBQdWJsaWMgTGljZW5zZSBh
cyBwdWJsaXNoZWQgYnkNCj4+ICsgKiB0aGUgRnJlZSBTb2Z0d2FyZSBGb3VuZGF0aW9uOyBlaXRo
ZXIgdmVyc2lvbiAyIG9mIHRoZSBMaWNlbnNlLCBvcg0KPj4gKyAqIChhdCB5b3VyIG9wdGlvbikg
YW55IGxhdGVyIHZlcnNpb24uDQo+PiArICoNCj4+ICsgKiBUaGlzIHByb2dyYW0gaXMgZGlzdHJp
YnV0ZWQgaW4gdGhlIGhvcGUgdGhhdCBpdCB3aWxsIGJlIHVzZWZ1bCwNCj4+ICsgKiBidXQgV0lU
SE9VVCBBTlkgV0FSUkFOVFk7IHdpdGhvdXQgZXZlbiB0aGUgaW1wbGllZCB3YXJyYW50eSBvZg0K
Pj4gKyAqIE1FUkNIQU5UQUJJTElUWSBvciBGSVRORVNTIEZPUiBBIFBBUlRJQ1VMQVIgUFVSUE9T
RS4gIFNlZSB0aGUNCj4+ICsgKiBHTlUgR2VuZXJhbCBQdWJsaWMgTGljZW5zZSBmb3IgbW9yZSBk
ZXRhaWxzLg0KPj4gKyAqLw0KPj4gKw0KPj4gKyNpZm5kZWYgX19BUkNIX0FSTV9WUENJX0hfXw0K
Pj4gKyNkZWZpbmUgX19BUkNIX0FSTV9WUENJX0hfXw0KPj4gKw0KPj4gKyNpZmRlZiBDT05GSUdf
SEFTX1ZQQ0kNCj4+ICtpbnQgZG9tYWluX3ZwY2lfaW5pdChzdHJ1Y3QgZG9tYWluICpkKTsNCj4+
ICsjZWxzZQ0KPj4gK3N0YXRpYyBpbmxpbmUgaW50IGRvbWFpbl92cGNpX2luaXQoc3RydWN0IGRv
bWFpbiAqZCkNCj4+ICt7DQo+PiArICAgIHJldHVybiAwOw0KPj4gK30NCj4+ICsjZW5kaWYNCj4+
ICsNCj4+ICsjZW5kaWYgLyogX19BUkNIX0FSTV9WUENJX0hfXyAqLw0KPj4gKw0KPj4gKy8qDQo+
PiArICogTG9jYWwgdmFyaWFibGVzOg0KPj4gKyAqIG1vZGU6IEMNCj4+ICsgKiBjLWZpbGUtc3R5
bGU6ICJCU0QiDQo+PiArICogYy1iYXNpYy1vZmZzZXQ6IDQNCj4+ICsgKiBpbmRlbnQtdGFicy1t
b2RlOiBuaWwNCj4+ICsgKiBFbmQ6DQo+PiArICovDQo+PiBkaWZmIC0tZ2l0IGEveGVuL2RyaXZl
cnMvcGFzc3Rocm91Z2gvcGNpLmMgYi94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC9wY2kuYw0KPj4g
aW5kZXggZTFiNzM1ZDllOC4uYjM2ZDVhNDgxMSAxMDA2NDQNCj4+IC0tLSBhL3hlbi9kcml2ZXJz
L3Bhc3N0aHJvdWdoL3BjaS5jDQo+PiArKysgYi94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC9wY2ku
Yw0KPj4gQEAgLTc2Niw2ICs3NjYsMjMgQEAgaW50IHBjaV9hZGRfZGV2aWNlKHUxNiBzZWcsIHU4
IGJ1cywgdTggZGV2Zm4sDQo+PiAgICAgZWxzZQ0KPj4gICAgICAgICBpb21tdV9lbmFibGVfZGV2
aWNlKHBkZXYpOw0KPj4gDQo+PiArI2lmZGVmIENPTkZJR19BUk0NCj4+ICsgICAgLyoNCj4+ICsg
ICAgICogT24gQVJNIFBDSSBkZXZpY2VzIGRpc2NvdmVyeSB3aWxsIGJlIGRvbmUgYnkgRG9tMC4g
QWRkIHZwY2kgaGFuZGxlciB3aGVuDQo+PiArICAgICAqIERvbTAgaW5mb3JtIFhFTiB0byBhZGQg
dGhlIFBDSSBkZXZpY2VzIGluIFhFTi4NCj4+ICsgICAgICovDQo+PiArICAgIHJldCA9IHZwY2lf
YWRkX2hhbmRsZXJzKHBkZXYpOw0KPj4gKyAgICBpZiAoIHJldCApDQo+PiArICAgIHsNCj4+ICsg
ICAgICAgIHByaW50ayhYRU5MT0dfRVJSICJzZXR1cCBvZiB2UENJIGZhaWxlZDogJWRcbiIsIHJl
dCk7DQo+IA0KPiBJIHdvdWxkIGFsc28gY2FsbDoNCj4gDQo+ICBwY2lfY2xlYW51cF9tc2kocGRl
dik7DQo+IA0KPiANCj4gSSBrbm93IGl0IGRvZXMgbm90aGluZyBvbiBBUk0gdG9kYXksIGJ1dCBp
dCBzZXJ2ZXMgYXMgYSByZW1pbmRlciB0aGF0IGluDQo+IHRoZSBmdXR1cmUgbGlrZWx5IE1TSXMg
d2lsbCBoYXZlIHRvIGJlIGNsZWFuZWQgdXAgaGVyZS4NCg0KWWVzIG1ha2Ugc2Vuc2UgSSB3aWxs
IGFkZCB0aGUgcGNpX2NsZWFudXBfbXNpKHBkZXYpIGluIG5leHQgdmVyc2lvbi4NCg0KUmVnYXJk
cywNClJhaHVsDQo+IA0KPiBXaXRoIHRoYXQ6DQo+IA0KPiBSZXZpZXdlZC1ieTogU3RlZmFubyBT
dGFiZWxsaW5pIDxzc3RhYmVsbGluaUBrZXJuZWwub3JnPg0KPiANCj4gDQo+IA0KPj4gKyAgICAg
ICAgcmV0ID0gaW9tbXVfcmVtb3ZlX2RldmljZShwZGV2KTsNCj4+ICsgICAgICAgIGlmICggcGRl
di0+ZG9tYWluICkNCj4+ICsgICAgICAgICAgICBsaXN0X2RlbCgmcGRldi0+ZG9tYWluX2xpc3Qp
Ow0KPj4gKyAgICAgICAgZnJlZV9wZGV2KHBzZWcsIHBkZXYpOw0KPj4gKyAgICAgICAgZ290byBv
dXQ7DQo+PiArICAgIH0NCj4+ICsjZW5kaWYNCj4+ICsNCj4+ICAgICBwY2lfZW5hYmxlX2Fjcyhw
ZGV2KTsNCj4+IA0KPj4gb3V0Og0KPj4gZGlmZiAtLWdpdCBhL3hlbi9pbmNsdWRlL2FzbS1hcm0v
ZG9tYWluLmggYi94ZW4vaW5jbHVkZS9hc20tYXJtL2RvbWFpbi5oDQo+PiBpbmRleCBjOTI3N2I1
YzZkLi45MWQ2MTRiMzdlIDEwMDY0NA0KPj4gLS0tIGEveGVuL2luY2x1ZGUvYXNtLWFybS9kb21h
aW4uaA0KPj4gKysrIGIveGVuL2luY2x1ZGUvYXNtLWFybS9kb21haW4uaA0KPj4gQEAgLTIsNiAr
Miw3IEBADQo+PiAjZGVmaW5lIF9fQVNNX0RPTUFJTl9IX18NCj4+IA0KPj4gI2luY2x1ZGUgPHhl
bi9jYWNoZS5oPg0KPj4gKyNpbmNsdWRlIDx4ZW4vbm9zcGVjLmg+DQo+PiAjaW5jbHVkZSA8eGVu
L3RpbWVyLmg+DQo+PiAjaW5jbHVkZSA8YXNtL3BhZ2UuaD4NCj4+ICNpbmNsdWRlIDxhc20vcDJt
Lmg+DQo+PiBAQCAtMjYyLDcgKzI2MywxMSBAQCBzdGF0aWMgaW5saW5lIHZvaWQgYXJjaF92Y3B1
X2Jsb2NrKHN0cnVjdCB2Y3B1ICp2KSB7fQ0KPj4gDQo+PiAjZGVmaW5lIGFyY2hfdm1fYXNzaXN0
X3ZhbGlkX21hc2soZCkgKDFVTCA8PCBWTUFTU1RfVFlQRV9ydW5zdGF0ZV91cGRhdGVfZmxhZykN
Cj4+IA0KPj4gLSNkZWZpbmUgaGFzX3ZwY2koZCkgICAgKHsgKHZvaWQpKGQpOyBmYWxzZTsgfSkN
Cj4+ICsvKg0KPj4gKyAqIEZvciBYODYgVlBDSSBpcyBlbmFibGVkIGFuZCB0ZXN0ZWQgZm9yIFBW
SCBET00wIG9ubHkgYnV0DQo+PiArICogZm9yIEFSTSB3ZSBlbmFibGUgc3VwcG9ydCBWUENJIGZv
ciBndWVzdCBkb21haW4gYWxzby4NCj4+ICsgKi8NCj4+ICsjZGVmaW5lIGhhc192cGNpKGQpIGV2
YWx1YXRlX25vc3BlYygoZCktPm9wdGlvbnMgJiBYRU5fRE9NQ1RMX0NERl92cGNpKQ0KPj4gDQo+
PiAjZW5kaWYgLyogX19BU01fRE9NQUlOX0hfXyAqLw0KPj4gDQo+PiBkaWZmIC0tZ2l0IGEveGVu
L2luY2x1ZGUvYXNtLXg4Ni9wY2kuaCBiL3hlbi9pbmNsdWRlL2FzbS14ODYvcGNpLmgNCj4+IGlu
ZGV4IGUwNzY5NTEwMzIuLmM0YTRmZGNiYzIgMTAwNjQ0DQo+PiAtLS0gYS94ZW4vaW5jbHVkZS9h
c20teDg2L3BjaS5oDQo+PiArKysgYi94ZW4vaW5jbHVkZS9hc20teDg2L3BjaS5oDQo+PiBAQCAt
Niw4ICs2LDYgQEANCj4+ICNkZWZpbmUgQ0Y4X0FERFJfSEkoY2Y4KSAoICAoKGNmOCkgJiAweDBm
MDAwMDAwKSA+PiAxNikNCj4+ICNkZWZpbmUgQ0Y4X0VOQUJMRUQoY2Y4KSAoISEoKGNmOCkgJiAw
eDgwMDAwMDAwKSkNCj4+IA0KPj4gLSNkZWZpbmUgTU1DRkdfQkRGKGFkZHIpICAoICgoYWRkcikg
JiAweDBmZmZmMDAwKSA+PiAxMikNCj4+IC0NCj4+ICNkZWZpbmUgSVNfU05CX0dGWChpZCkgKGlk
ID09IDB4MDEwNjgwODYgfHwgaWQgPT0gMHgwMTE2ODA4NiBcDQo+PiAgICAgICAgICAgICAgICAg
ICAgICAgICB8fCBpZCA9PSAweDAxMjY4MDg2IHx8IGlkID09IDB4MDEwMjgwODYgXA0KPj4gICAg
ICAgICAgICAgICAgICAgICAgICAgfHwgaWQgPT0gMHgwMTEyODA4NiB8fCBpZCA9PSAweDAxMjI4
MDg2IFwNCj4+IGRpZmYgLS1naXQgYS94ZW4vaW5jbHVkZS9wdWJsaWMvYXJjaC1hcm0uaCBiL3hl
bi9pbmNsdWRlL3B1YmxpYy9hcmNoLWFybS5oDQo+PiBpbmRleCBkNDZjNjFmY2E5Li40NGJlMzM3
ZGVjIDEwMDY0NA0KPj4gLS0tIGEveGVuL2luY2x1ZGUvcHVibGljL2FyY2gtYXJtLmgNCj4+ICsr
KyBiL3hlbi9pbmNsdWRlL3B1YmxpYy9hcmNoLWFybS5oDQo+PiBAQCAtNDE4LDYgKzQxOCwxMyBA
QCB0eXBlZGVmIHVpbnQ2NF90IHhlbl9jYWxsYmFja190Ow0KPj4gI2RlZmluZSBHVUVTVF9HSUNW
M19HSUNSMF9CQVNFICAgICB4ZW5fbWtfdWxsb25nKDB4MDMwMjAwMDApIC8qIHZDUFUwLi4xMjcg
Ki8NCj4+ICNkZWZpbmUgR1VFU1RfR0lDVjNfR0lDUjBfU0laRSAgICAgeGVuX21rX3VsbG9uZygw
eDAxMDAwMDAwKQ0KPj4gDQo+PiArLyoNCj4+ICsgKiAyNTYgTUIgaXMgcmVzZXJ2ZWQgZm9yIFZQ
Q0kgY29uZmlndXJhdGlvbiBzcGFjZSBiYXNlZCBvbiBjYWxjdWxhdGlvbg0KPj4gKyAqIDI1NiBi
dXNlcyDDlyAzMiBkZXZpY2VzIMOXIDggZnVuY3Rpb25zIMOXIDQgS0IgPSAyNTYgTUINCj4+ICsg
Ki8NCj4+ICsjZGVmaW5lIEdVRVNUX1ZQQ0lfRUNBTV9CQVNFICAgIHhlbl9ta191bGxvbmcoMHgx
MDAwMDAwMCkNCj4+ICsjZGVmaW5lIEdVRVNUX1ZQQ0lfRUNBTV9TSVpFICAgIHhlbl9ta191bGxv
bmcoMHgxMDAwMDAwMCkNCj4+ICsNCj4+IC8qIEFDUEkgdGFibGVzIHBoeXNpY2FsIGFkZHJlc3Mg
Ki8NCj4+ICNkZWZpbmUgR1VFU1RfQUNQSV9CQVNFIHhlbl9ta191bGxvbmcoMHgyMDAwMDAwMCkN
Cj4+ICNkZWZpbmUgR1VFU1RfQUNQSV9TSVpFIHhlbl9ta191bGxvbmcoMHgwMjAwMDAwMCkNCj4+
IGRpZmYgLS1naXQgYS94ZW4vaW5jbHVkZS94ZW4vcGNpLmggYi94ZW4vaW5jbHVkZS94ZW4vcGNp
LmgNCj4+IGluZGV4IDcwYWMyNTM0NWMuLjQzYjhhMDgxNzAgMTAwNjQ0DQo+PiAtLS0gYS94ZW4v
aW5jbHVkZS94ZW4vcGNpLmgNCj4+ICsrKyBiL3hlbi9pbmNsdWRlL3hlbi9wY2kuaA0KPj4gQEAg
LTQwLDYgKzQwLDggQEANCj4+ICNkZWZpbmUgUENJX1NCREYzKHMsYixkZikgXA0KPj4gICAgICgo
cGNpX3NiZGZfdCl7IC5zYmRmID0gKCgocykgJiAweGZmZmYpIDw8IDE2KSB8IFBDSV9CREYyKGIs
IGRmKSB9KQ0KPj4gDQo+PiArI2RlZmluZSBNTUNGR19CREYoYWRkcikgICgoKGFkZHIpICYgMHgw
ZmZmZjAwMCkgPj4gMTIpDQo+PiArDQo+PiB0eXBlZGVmIHVuaW9uIHsNCj4+ICAgICB1aW50MzJf
dCBzYmRmOw0KPj4gICAgIHN0cnVjdCB7DQo+PiAtLSANCj4+IDIuMjUuMQ0KDQo=


From xen-devel-bounces@lists.xenproject.org Tue Oct 05 07:45:15 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Oct 2021 07:45:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.202061.356727 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXf8U-0007eS-Mu; Tue, 05 Oct 2021 07:45:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 202061.356727; Tue, 05 Oct 2021 07:45:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXf8U-0007eL-Ji; Tue, 05 Oct 2021 07:45:14 +0000
Received: by outflank-mailman (input) for mailman id 202061;
 Tue, 05 Oct 2021 07:45:13 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=u4De=OZ=arm.com=Rahul.Singh@srs-us1.protection.inumbo.net>)
 id 1mXf8T-0007eB-65
 for xen-devel@lists.xenproject.org; Tue, 05 Oct 2021 07:45:13 +0000
Received: from EUR05-AM6-obe.outbound.protection.outlook.com (unknown
 [40.107.22.52]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 2bb9d0d6-25b0-11ec-becf-12813bfff9fa;
 Tue, 05 Oct 2021 07:45:12 +0000 (UTC)
Received: from AS8PR04CA0079.eurprd04.prod.outlook.com (2603:10a6:20b:313::24)
 by AS8PR08MB6405.eurprd08.prod.outlook.com (2603:10a6:20b:332::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.16; Tue, 5 Oct
 2021 07:45:09 +0000
Received: from VE1EUR03FT030.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:313:cafe::15) by AS8PR04CA0079.outlook.office365.com
 (2603:10a6:20b:313::24) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.14 via Frontend
 Transport; Tue, 5 Oct 2021 07:45:09 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT030.mail.protection.outlook.com (10.152.18.66) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4566.14 via Frontend Transport; Tue, 5 Oct 2021 07:45:08 +0000
Received: ("Tessian outbound ab2dc3678fa9:v103");
 Tue, 05 Oct 2021 07:45:05 +0000
Received: from bf461cf99ffe.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 CC14D42E-3832-4E4E-985C-0872EDAA90B2.1; 
 Tue, 05 Oct 2021 07:35:44 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id bf461cf99ffe.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Tue, 05 Oct 2021 07:35:44 +0000
Received: from AS8PR08MB6919.eurprd08.prod.outlook.com (2603:10a6:20b:39e::10)
 by AS8PR08MB6791.eurprd08.prod.outlook.com (2603:10a6:20b:392::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.22; Tue, 5 Oct
 2021 07:35:41 +0000
Received: from AS8PR08MB6919.eurprd08.prod.outlook.com
 ([fe80::51ee:e7de:6c0a:bcf9]) by AS8PR08MB6919.eurprd08.prod.outlook.com
 ([fe80::51ee:e7de:6c0a:bcf9%7]) with mapi id 15.20.4566.022; Tue, 5 Oct 2021
 07:35:41 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2bb9d0d6-25b0-11ec-becf-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=cAXEff3KZooyXzT37QuFAswDLIBVtvYoESXRlRAfQac=;
 b=AJdfdnuFlV8EpzQslzAljcA01aFSx9ywXhQbLGcFyoTu8LKlgotc0gKdv9HVhqO6r7gnvLDCab0UdCI+FybgMgpxI3CZjAe8JLsKUgFi/5hZ6UbCxv6bB7Lkf98JolK5zzYU2b0U/rCuwwrqLXfeukBrNP/sd25ylb1q1esYpcI=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 60a2218a3891971d
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=UrRS7IOczDA0ekmqM7JBqh1IJGy8x013LTnOuvxp542O2afKNTL58dCQmVucQ+HJ1n6JREashRN36jB6SMnLGagOdp093B8/lfj5M5aHqIDtXlHapGbOvZcbyJpWi+vIa+wzlzjUFuPrh7xnXQL18n5+04PgwOpO0LcncArVHsNeCAMoeMcpPlfVTRV//QHgf+xZJq/Wx+kdFTdPUJBDLBk0jQkXDI/MrGagQaMVIlCx8LlRKbG1G4WW1VQqPFHWIozfwFGf0BcDGsUGXJbM4gUJaK8l5vfeMXWsO5n6IBas6JjOG/aiASGCAn7upBPTU8eA4oab2HFD9BCyJdac3w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=cAXEff3KZooyXzT37QuFAswDLIBVtvYoESXRlRAfQac=;
 b=J0eQk5yR9DzM8dHCCZXBUMVAYYhwQuk2/zTUcGLWB0mvv6IJRhX8d7TMMfYCFxzh9l3vl+1jYwQo/DqIz2GWK64BS6nSNELW/M2bU3safpCjXMC87sztFJpka8jRWUDXLASY84bdWftr2e2NAzpXOyR6kUMga1NitChLsYoligxN/X6NIo2ofrinS0uTt6+hBEljoGoqmSRf3rFzHhywPPSbSO1GgdgAhILM0u0kblkCV0OK7f4+johVWR32KbpufU2hZn16X7EgkCf0cxTUTSYALTXhyeICRb8nKROfIgUWAut7I2iaqt7/57qt+U9hAeEmgRN5OVUJmGC0sECXeQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=cAXEff3KZooyXzT37QuFAswDLIBVtvYoESXRlRAfQac=;
 b=AJdfdnuFlV8EpzQslzAljcA01aFSx9ywXhQbLGcFyoTu8LKlgotc0gKdv9HVhqO6r7gnvLDCab0UdCI+FybgMgpxI3CZjAe8JLsKUgFi/5hZ6UbCxv6bB7Lkf98JolK5zzYU2b0U/rCuwwrqLXfeukBrNP/sd25ylb1q1esYpcI=
From: Rahul Singh <Rahul.Singh@arm.com>
To: Stefano Stabellini <sstabellini@kernel.org>
CC: xen-devel <xen-devel@lists.xenproject.org>, Bertrand Marquis
	<Bertrand.Marquis@arm.com>, Andre Przywara <Andre.Przywara@arm.com>, Jan
 Beulich <jbeulich@suse.com>, Paul Durrant <paul@xen.org>, Ian Jackson
	<iwj@xenproject.org>, Wei Liu <wl@xen.org>, Juergen Gross <jgross@suse.com>,
	Julien Grall <julien@xen.org>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>, =?iso-8859-1?Q?Roger_Pau_Monn=E9?=
	<roger.pau@citrix.com>, Christian Lindig <christian.lindig@citrix.com>, David
 Scott <dave@recoil.org>, Anthony PERARD <anthony.perard@citrix.com>
Subject: Re: [PATCH v4 00/14] PCI devices passthrough on Arm
Thread-Topic: [PATCH v4 00/14] PCI devices passthrough on Arm
Thread-Index: AQHXuRZgSgnn8xNCK0GEb4YjlRTuVKvDlcSAgABvQYA=
Date: Tue, 5 Oct 2021 07:35:41 +0000
Message-ID: <C28F78BC-576B-438E-90B5-3F78664FCC47@arm.com>
References: <cover.1633340795.git.rahul.singh@arm.com>
 <alpine.DEB.2.21.2110041753090.3209@sstabellini-ThinkPad-T480s>
In-Reply-To: <alpine.DEB.2.21.2110041753090.3209@sstabellini-ThinkPad-T480s>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
Authentication-Results-Original: kernel.org; dkim=none (message not signed)
 header.d=none;kernel.org; dmarc=none action=none header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: d8810af4-7f34-47fb-d0c1-08d987d40df2
x-ms-traffictypediagnostic: AS8PR08MB6791:|AS8PR08MB6405:
x-ms-exchange-transport-forked: True
X-Microsoft-Antispam-PRVS:
	<AS8PR08MB6405C6B9A5B06775D56C76F4FCAF9@AS8PR08MB6405.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:5236;OLM:5236;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 fVTppeT6dKMRqjB+3DjA9AuSnK2M+qgP6euc5wavbfnAvyDy9O+KVFqul7LdX1eQCFDrreu4BaF9wH0sejFM0B+8AvAmZi4ppesK22BLorQIoccwa0I2gsAQrxRcleDXBnrPLosWbvbYIm9/ImU4baExDv2g1T9cluJX8OhXdJ1CJCJVZYihRVHKSj/Jdl/XpiyM2Le8OI3eE/i6mWzqjTAbCjx+kCrleWdt0wt1/a6Vr2NqQoXhdF8sVyWSYd3dUezqD0Z2C9K8WUc3U1Rfru2F7F9tKRCa4mhCK7d+pdC/5B2lWIUVTbYVIgeryQxVeQb1aCA+bXoIf9iBpXCUxDjdDneL6qpgU5J7W0ZSX++EXXdn3sMv6Us+Nmyc1d79QW1ILnwDKLLHq6wWaBE9nFhS54OCXb7S1pt0DygGPRvvxEFSixNXTAEVott2M0+rEIfawaeM49yBE/gLbbh1xBXOv7pZ0xdZSyw4qIYwNsq2tG1EqmlOMnklZQ+vN1CnqKdyr6Z5VryINaqgXCuOgejND2WNag9lwSurQWpvIKB3GZWed+bhBa58vALjFPC+9vFhr3EaU3cFfpOcWTPhrJ1rr8kD9SVtNJF9Lb3Xq8H5ffwn3jSt7BjVR5YBg761GdYE2Hwj8LtVjnGaWO6vYjCWfpPHRAhQgnvKNdeLxnMlbQ0RQyVjhPmqRyGcNjt/U9a2oQ1waaPdtfZM4+sJx69T9bpmwVRND8htu9+kua3KTniJI8itB+p5yHIHEciy
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6919.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(558084003)(38070700005)(86362001)(122000001)(316002)(2616005)(38100700002)(6916009)(33656002)(6506007)(6512007)(71200400001)(8936002)(4326008)(8676002)(36756003)(6486002)(508600001)(91956017)(54906003)(2906002)(186003)(53546011)(26005)(66946007)(64756008)(66446008)(66556008)(66476007)(7416002)(5660300002)(76116006)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="iso-8859-1"
Content-ID: <03A2730646014D468C3E114B0CBAAB5A@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6791
Original-Authentication-Results: kernel.org; dkim=none (message not signed)
 header.d=none;kernel.org; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT030.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	0bc1b350-a796-4ea8-3cde-08d987d2bc1e
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	PKJ82Mp3p8O0W28Un1c6d0pKzeWepHlvnGrxBLzcb5VSgSXzHWqigNHFnEbg1BREwH0kgJo+cc9pAx4WMyYsZ4tDGFTDQP5YtEVeFihr6V55aFPl+phqQKkZA8PgI8BW5PA6v2jWBsTNwp3jDL63gSuNf5tg4T3wc6Deq1vSe34dZKp+Qlt4gfAFdcvjwdqT9gg8dJyQuIbAKXzbYpRfeVvKuwlpLGm/EBREa2NB7BAk0MI+0+pmJsVBrdgF9L8dwbsLJak6P1Dk0Z5HsM/a+p7hWAkUIvI4QRkvVG08DqDZm11q4hx171R5Y3cJe4UYC66ukwUQwAdXAm4SWPNYQGCNtklxwUHF3OsFOUYqcZ3WqKx33bdW0cnbGfAIA3BbGIg9bPbqGCprH82pTTYnnOL5s+Cy45ZokEdv2qmd5yFh+BENVvEMXqH/XXnKk58NdYDnww22YrENDy6qpJ7lH+s2a/kJw7R3f6fzsoDSgy9lcZn3voity6j0whT3QhqP5PBeFeH2He7YN6B7/jFxYyhBz98kuO2SdcB1NGZRNQbKvKr/+tCf0bxsuzJ5Gig33xFcB607M5/ckWkLGIYkrmghSkwjS/qkYQ9CcuinLQrssfj9gxD9FQiVo5pVIJGxMMV5yKMiGK07BWh9sEoKUlwg1UcRfQtGz0nKucijlyIM4wDPpd3V6nTZ/cII3+ynDvhC9mRoAZ9J8JArOSfBGA==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(81166007)(336012)(2906002)(36756003)(6862004)(70206006)(54906003)(33656002)(8936002)(36860700001)(6506007)(508600001)(53546011)(6486002)(107886003)(70586007)(8676002)(2616005)(186003)(47076005)(5660300002)(6512007)(86362001)(82310400003)(316002)(558084003)(26005)(356005)(4326008);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Oct 2021 07:45:08.5079
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: d8810af4-7f34-47fb-d0c1-08d987d40df2
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT030.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6405

Hi Stefano,

> On 5 Oct 2021, at 1:57 am, Stefano Stabellini <sstabellini@kernel.org> wr=
ote:
>=20
> I committed patches #1, #4, #5 of this series
>=20

Thank you.

Regards,
Rahul
 =


From xen-devel-bounces@lists.xenproject.org Tue Oct 05 07:52:43 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Oct 2021 07:52:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.202071.356738 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXfFd-0000fj-FZ; Tue, 05 Oct 2021 07:52:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 202071.356738; Tue, 05 Oct 2021 07:52:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXfFd-0000fc-BX; Tue, 05 Oct 2021 07:52:37 +0000
Received: by outflank-mailman (input) for mailman id 202071;
 Tue, 05 Oct 2021 07:52:36 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=J6Vb=OZ=gmail.com=julien.grall.oss@srs-us1.protection.inumbo.net>)
 id 1mXfFc-0000fW-Ff
 for xen-devel@lists.xenproject.org; Tue, 05 Oct 2021 07:52:36 +0000
Received: from mail-ed1-x529.google.com (unknown [2a00:1450:4864:20::529])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 2cb34cba-e621-496b-96fa-3fdb2e93c013;
 Tue, 05 Oct 2021 07:52:35 +0000 (UTC)
Received: by mail-ed1-x529.google.com with SMTP id l7so51440021edq.3
 for <xen-devel@lists.xenproject.org>; Tue, 05 Oct 2021 00:52:35 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2cb34cba-e621-496b-96fa-3fdb2e93c013
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=9z/uadWIJuyuNrxC/5DieTUNHRNyX/SWE9HTWrrUT24=;
        b=dl87hZ3pc4j/qlXozpKgiZpbVAUq3Wc11KPNqQQTOrNWMKAgRKr8ynLgka3NSMZAfF
         0+jzETdcTVZ+4s2fphPwY6rTFjXHC/IyWsSHAgOuaxUqw40E8ZIiCEpcQ8u/E6KiX9Ip
         u0iwzI9x8MJlv/ugOyw7V5Be9gjWd/kw7qjaaFqhlrl8P74oSnSFPHeK6sZrE5QGNzbD
         LQyAL3EiK44SKeEX0WP2ccQoPwkNbTAtHA3VvxHA8V/71tB/8zeItRFRmLfn9W729HOe
         aONiLSl38bvO2vbzyAORExFYwjJdDyz0YuQjKeqxOuR9bvCyuXejCMtNGNE5n2SViXzE
         k7Og==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=9z/uadWIJuyuNrxC/5DieTUNHRNyX/SWE9HTWrrUT24=;
        b=midTquHkSPDvAfzuaR7VrOrx/0LbIuZrVW0/mkwbI3WV5+/HFpaMgheyAjymQG2NEW
         VZ5vKYFnkarMnnSzOPUi3RyZ7U1pC32HhLWG4ZCqbb0+Kt0mHtxhSg8FCxy+4RAkJyfK
         LGy4Rr2UB4ncc/wGh9SNxRp0UpiOlMgUettZNlzNIAohG97F6nrWck6IQX+oieUVZYLt
         Vlh8OJwmbJsLRjIdWop50ZDvMvckHDS6l8sra5MpkI9Z9kKhh85+dhHDpVua/Lx38afP
         XWz8kaJt7wtWuv0X3NEi8Va21a5Bc348ogCUCVyt7vvGLpmZ0Jd5cpHWpsKDpsiYSJdm
         wPsQ==
X-Gm-Message-State: AOAM530pCTvzYyWF7R6nozmpQUivX9cpBR3dzxS+5PKilhbDWlmbiCLp
	UC46mwojkjjgUsx4qtCGCnbtQ9ee65fxDcAium0=
X-Google-Smtp-Source: ABdhPJyuEFcx6G3s/Wh+wjCMhZh7+33HtKMLru0ovRkNkp408Ue+EHr+6pOlu/WXyn9YrzHA8c4gVD3hxuvuHFdhTJI=
X-Received: by 2002:a50:cfcb:: with SMTP id i11mr24364572edk.347.1633420354742;
 Tue, 05 Oct 2021 00:52:34 -0700 (PDT)
MIME-Version: 1.0
References: <cover.1633340795.git.rahul.singh@arm.com> <99ee039a6cdd9ac7d54f1f01649d1dd3eeea3763.1633340795.git.rahul.singh@arm.com>
 <alpine.DEB.2.21.2110041639560.3209@sstabellini-ThinkPad-T480s>
In-Reply-To: <alpine.DEB.2.21.2110041639560.3209@sstabellini-ThinkPad-T480s>
From: Julien Grall <julien.grall.oss@gmail.com>
Date: Tue, 5 Oct 2021 09:52:24 +0200
Message-ID: <CAJ=z9a1cTqx=wbQs6WR4NE03yUj80DRXPc67NMEuqvLVdcXsxw@mail.gmail.com>
Subject: Re: [PATCH v4 03/14] xen/arm: Add PHYSDEVOP_pci_device_(*add/remove)
 support for ARM
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: Rahul Singh <rahul.singh@arm.com>, xen-devel <xen-devel@lists.xenproject.org>, 
	Bertrand Marquis <bertrand.marquis@arm.com>, Andre Przywara <Andre.Przywara@arm.com>, 
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, Andrew Cooper <andrew.cooper3@citrix.com>, 
	George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>, 
	Jan Beulich <jbeulich@suse.com>, Wei Liu <wl@xen.org>, 
	=?UTF-8?Q?Roger_Pau_Monn=C3=A9?= <roger.pau@citrix.com>
Content-Type: multipart/alternative; boundary="000000000000036b0d05cd9650b6"

--000000000000036b0d05cd9650b6
Content-Type: text/plain; charset="UTF-8"

On Tue, 5 Oct 2021, 01:46 Stefano Stabellini, <sstabellini@kernel.org>
wrote:

>
> Given that only ARM needs the !CONFIG_HAS_PCI stub, I would add it
> directly to xen/arch/arm/physdev.c. Or just add an #ifdef directly
> within do_physdev_op in xen/arch/arm/physdev.c.


If we want to keep the stub, then it should be the generic code so it can
be used by other arch in the future.

That said, I would also be happy with the #ifdef directly in do_physdev_op.

--000000000000036b0d05cd9650b6
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"auto"><div><br><br><div class=3D"gmail_quote"><div dir=3D"ltr" =
class=3D"gmail_attr">On Tue, 5 Oct 2021, 01:46 Stefano Stabellini, &lt;<a h=
ref=3D"mailto:sstabellini@kernel.org">sstabellini@kernel.org</a>&gt; wrote:=
</div><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-l=
eft:1px #ccc solid;padding-left:1ex">
<br>
Given that only ARM needs the !CONFIG_HAS_PCI stub, I would add it<br>
directly to xen/arch/arm/physdev.c. Or just add an #ifdef directly<br>
within do_physdev_op in xen/arch/arm/physdev.c.</blockquote></div></div><di=
v dir=3D"auto"><br></div><div dir=3D"auto"></div><div dir=3D"auto">If we wa=
nt to keep the stub, then it should be the generic code so it can be used b=
y other arch in the future.</div><div dir=3D"auto"><br></div><div dir=3D"au=
to">That said, I would also be happy with the #ifdef directly in do_physdev=
_op.</div><div dir=3D"auto"><br></div><div dir=3D"auto"><div class=3D"gmail=
_quote"><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border=
-left:1px #ccc solid;padding-left:1ex">
</blockquote></div></div></div>

--000000000000036b0d05cd9650b6--


From xen-devel-bounces@lists.xenproject.org Tue Oct 05 08:03:47 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Oct 2021 08:03:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.202082.356749 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXfQM-0002kx-MI; Tue, 05 Oct 2021 08:03:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 202082.356749; Tue, 05 Oct 2021 08:03:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXfQM-0002kq-JQ; Tue, 05 Oct 2021 08:03:42 +0000
Received: by outflank-mailman (input) for mailman id 202082;
 Tue, 05 Oct 2021 08:03:41 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mXfQL-0002kf-4H; Tue, 05 Oct 2021 08:03:41 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mXfQK-00079V-U9; Tue, 05 Oct 2021 08:03:40 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mXfQK-0005LF-FN; Tue, 05 Oct 2021 08:03:40 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mXfQK-0000uI-CR; Tue, 05 Oct 2021 08:03:40 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=kOQssv/EZopwyK61CLY2VnM4w4ORRyKgl8NPPBU0ToE=; b=Pf7+/vKtz+ewiPkThULqv3PkZ6
	IaMxZk1TF/iklqEi6bRzgrGrGcY0duUMzL9c8vWryaM86WABhMnerPI/CL1/xpgj7XhW+8rbGrOcu
	QVc4jcJI963IV9AFmARtp1ynO+DeTn39cmEzcDXT95iKo68KcOijg8j+jrCjfv+b26p0=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165347-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 165347: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=4cc1458dbe004b1d70534caa55f475f6d19fe14a
X-Osstest-Versions-That:
    ovmf=442e46d3b6c1931b54111c92e0efb5a797bc622b
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 05 Oct 2021 08:03:40 +0000

flight 165347 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165347/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 4cc1458dbe004b1d70534caa55f475f6d19fe14a
baseline version:
 ovmf                 442e46d3b6c1931b54111c92e0efb5a797bc622b

Last test of basis   165321  2021-09-29 20:41:38 Z    5 days
Testing same since   165347  2021-10-04 12:43:18 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Chasel Chiu <chasel.chiu@intel.com>
  Guo Dong <guo.dong@intel.com>
  Jiewen Yao <jiewen.yao@intel.com>
  Kun Qin <kuqin12@gmail.com>
  Nhi Pham <nhi@os.amperecomputing.com>
  Pierre Gondois <Pierre.Gondois@arm.com>
  Sami Mujawar <sami.mujawar@arm.com>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Berger <stefanb@linux.vnet.ibm.com>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   442e46d3b6..4cc1458dbe  4cc1458dbe004b1d70534caa55f475f6d19fe14a -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Tue Oct 05 08:05:44 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Oct 2021 08:05:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.202091.356764 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXfSK-0003Mj-3l; Tue, 05 Oct 2021 08:05:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 202091.356764; Tue, 05 Oct 2021 08:05:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXfSJ-0003Mc-Vx; Tue, 05 Oct 2021 08:05:43 +0000
Received: by outflank-mailman (input) for mailman id 202091;
 Tue, 05 Oct 2021 08:05:42 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=/jnY=OZ=suse.com=jgross@srs-us1.protection.inumbo.net>)
 id 1mXfSH-0003MW-Vl
 for xen-devel@lists.xenproject.org; Tue, 05 Oct 2021 08:05:42 +0000
Received: from smtp-out1.suse.de (unknown [195.135.220.28])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 07f0d304-25b3-11ec-bed0-12813bfff9fa;
 Tue, 05 Oct 2021 08:05:41 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 2C077223DC;
 Tue,  5 Oct 2021 08:05:40 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 11D1913A78;
 Tue,  5 Oct 2021 08:05:40 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id j+oKA1QHXGG8WwAAMHmgww
 (envelope-from <jgross@suse.com>); Tue, 05 Oct 2021 08:05:40 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 07f0d304-25b3-11ec-bed0-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1633421140; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=mNS2wV6jSY6IP0Jf9wHa0Hx2MuFhbu0KcztaVF58z8E=;
	b=ltzMcl7IwVglx+cobDoydm4ULI7+2D/wDbCOxDJXkOE68sOv8LRNfN1i71zSIVb5xlcC89
	OAxsPtxjQR0sNEQookdFwdvpBia2LBRA2UZOnPQbKvlWbq5gTLBRz5kDtkSZckM/r8YDkT
	g2FW7Svz/FGuKy6HtyBD87I8ZyQPYlE=
Subject: Re: xen-balloon thread using 100% of CPU, regression in 5.4.150
To: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?=
 <marmarek@invisiblethingslab.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>,
 Jan Beulich <jbeulich@suse.com>
References: <YVk11h2l/u4GJNv0@mail-itl>
 <37c22c61-80be-fc48-18e6-2b1ee22cc765@suse.com> <YVrF65BAVsXTgRsd@mail-itl>
From: Juergen Gross <jgross@suse.com>
Message-ID: <f707c956-6cdc-9b32-5f22-227e0f5a9f10@suse.com>
Date: Tue, 5 Oct 2021 10:05:39 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <YVrF65BAVsXTgRsd@mail-itl>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="mhwC5aop5uFcSu15uaLNzT91NGrYN4Nv1"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--mhwC5aop5uFcSu15uaLNzT91NGrYN4Nv1
Content-Type: multipart/mixed; boundary="nIt1A3U6j0WdSLKTUVWEjcBmjavjJosFB";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?=
 <marmarek@invisiblethingslab.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>,
 Jan Beulich <jbeulich@suse.com>
Message-ID: <f707c956-6cdc-9b32-5f22-227e0f5a9f10@suse.com>
Subject: Re: xen-balloon thread using 100% of CPU, regression in 5.4.150
References: <YVk11h2l/u4GJNv0@mail-itl>
 <37c22c61-80be-fc48-18e6-2b1ee22cc765@suse.com> <YVrF65BAVsXTgRsd@mail-itl>
In-Reply-To: <YVrF65BAVsXTgRsd@mail-itl>

--nIt1A3U6j0WdSLKTUVWEjcBmjavjJosFB
Content-Type: multipart/mixed;
 boundary="------------C795C15D33C6DCA3DCD191B2"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------C795C15D33C6DCA3DCD191B2
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 04.10.21 11:14, Marek Marczykowski-G=C3=B3recki wrote:
> On Mon, Oct 04, 2021 at 07:31:40AM +0200, Juergen Gross wrote:
>> On 03.10.21 06:47, Marek Marczykowski-G=C3=B3recki wrote:
>>> Hi,
>>>
>>> After updating a PVH domU to 5.4.150, I see xen-balloon thread using
>>> 100% CPU (one thread).
>>> This is a domain started with memory=3Dmaxmem=3D716800KiB (via libvir=
t). Then,
>>> inside, I see:
>>>
>>> # cat /sys/devices/system/xen_memory/xen_memory0/target_kb
>>> 716924
>>> # cat /sys/devices/system/xen_memory/xen_memory0/info/current_kb
>>> 716400
>>>
>>> Doing `cat info/current_kb > target_kb` "fixes" the issue. But still,=

>>> something is wrong - on earlier kernel (5.4.143 to be precise), it
>>> wasn't spinning, with exactly the same values reported in sysfs. It
>>> shouldn't run in circles if it can't get that much memory it wants. I=

>>> strongly suspect "xen/balloon: use a kernel thread instead a workqueu=
e"
>>> or related commit being responsible, but I haven't verified it.
>>
>> I think you are right. I need to handle the BP_ECANCELED case similar =
to
>> BP_EAGAIN in the kernel thread (wait until target size changes again).=

>>
>> One further question: do you see any kernel message in the guest relat=
ed
>> to the looping balloon thread?
>=20
> Nothing, only the usual "xen:balloon: Initialising balloon driver", and=

> nothing related to balloon after that.

Could you try the attached patch, please? I've tested it briefly with
PV and PVH guests.


Juergen


--------------C795C15D33C6DCA3DCD191B2
Content-Type: text/x-patch; charset=UTF-8;
 name="0001-xen-balloon-fix-cancelled-balloon-action.patch"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: attachment;
 filename="0001-xen-balloon-fix-cancelled-balloon-action.patch"

=46rom c0901b425d5939b7f3ce6c3f4bb7a0161b819745 Mon Sep 17 00:00:00 2001
From: Juergen Gross <jgross@suse.com>
Date: Mon, 4 Oct 2021 17:05:48 +0200
Subject: [PATCH] xen/balloon: fix cancelled balloon action
MIME-Version: 1.0
Content-Type: text/plain; charset=3DUTF-8
Content-Transfer-Encoding: 8bit

In case a ballooning action is cancelled the new kernel thread handling
the ballooning might end up in a busy loop.

Fix that by handling the cancelled action gracefully.

Cc: stable@vger.kernel.org
Fixes: 8480ed9c2bbd56 ("xen/balloon: use a kernel thread instead a workqu=
eue")
Reported-by: Marek Marczykowski-G=C3=B3recki <marmarek@invisiblethingslab=
=2Ecom>
Signed-off-by: Juergen Gross <jgross@suse.com>
---
 drivers/xen/balloon.c | 21 +++++++++++++++------
 1 file changed, 15 insertions(+), 6 deletions(-)

diff --git a/drivers/xen/balloon.c b/drivers/xen/balloon.c
index 43ebfe36ac27..3a50f097ed3e 100644
--- a/drivers/xen/balloon.c
+++ b/drivers/xen/balloon.c
@@ -491,12 +491,12 @@ static enum bp_state decrease_reservation(unsigned =
long nr_pages, gfp_t gfp)
 }
=20
 /*
- * Stop waiting if either state is not BP_EAGAIN and ballooning action i=
s
- * needed, or if the credit has changed while state is BP_EAGAIN.
+ * Stop waiting if either state is BP_DONE and ballooning action is
+ * needed, or if the credit has changed while state is not BP_DONE.
  */
 static bool balloon_thread_cond(enum bp_state state, long credit)
 {
-	if (state !=3D BP_EAGAIN)
+	if (state =3D=3D BP_DONE)
 		credit =3D 0;
=20
 	return current_credit() !=3D credit || kthread_should_stop();
@@ -516,10 +516,19 @@ static int balloon_thread(void *unused)
=20
 	set_freezable();
 	for (;;) {
-		if (state =3D=3D BP_EAGAIN)
-			timeout =3D balloon_stats.schedule_delay * HZ;
-		else
+		switch (state) {
+		case BP_DONE:
+		case BP_ECANCELED:
 			timeout =3D 3600 * HZ;
+			break;
+		case BP_EAGAIN:
+			timeout =3D balloon_stats.schedule_delay * HZ;
+			break;
+		case BP_WAIT:
+			timeout =3D HZ;
+			break;
+		}
+
 		credit =3D current_credit();
=20
 		wait_event_freezable_timeout(balloon_thread_wq,
--=20
2.26.2


--------------C795C15D33C6DCA3DCD191B2
Content-Type: application/pgp-keys;
 name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Transfer-Encoding: quoted-printable
Content-Description: OpenPGP public key
Content-Disposition: attachment;
 filename="OpenPGP_0xB0DE9DD628BF132F.asc"

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy=
cWx
w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O=
f8Z
d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y=
9bf
IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq=
G7/
377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR=
3Jv
c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA=
QIe
AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT=
hpw
dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0=
MbD
1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv=
oPH
Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v=
5QL
+qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ=
2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC=
QoL
BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr=
Wf0
teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC=
/nu
AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh=
ITT
d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm=
XBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz=
80h
SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC=
AcD
AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn=
FOX
gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1=
jnD
kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0=
N51
N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l=
otu
fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1=
tqS
EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA=
hsD
BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3=
g3O
ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5=
dM7
wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5=
D+j
LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm=
V2x
AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N=
Eaw
QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW=
nHI
s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR=
wgn
BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV=
bVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk=
pEd
IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA=
QAB
wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw=
Tbe
8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1=
vJz
Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8=
VGi
wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW=
svi
uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX=
zXs
ZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------C795C15D33C6DCA3DCD191B2--

--nIt1A3U6j0WdSLKTUVWEjcBmjavjJosFB--

--mhwC5aop5uFcSu15uaLNzT91NGrYN4Nv1
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmFcB1MFAwAAAAAACgkQsN6d1ii/Ey8p
bwf+JCZ/re4RHkGlzO08wLZNq4/K8sFuWWZeQkgLI3hO7nDw6garNABpOD1BDxX/W6F5Hb+azEPF
xXQrNhMGtRvqQ5mmTw7wUzGEWMX9WzAsE83WkJNayEalFg75brss8PocnAnZ6OlB0LwMxu2Z/G4O
mVc1K9t4/eo75ziYpU1kCzZShdak/tA3pxYkVSWZ0eLPFIAjU9Aprb3vDvlkPgCiuuetnrbiobB0
ZNSav8xtkQnbwQx7n2s500Xn03qoPGoQZ5lf25SFybU9LdozDcjU1Et/Q7v2Gb8XwC5Ix1GFmjB/
Rj8qwXi365mikyHJUr4icj7O3iB+1lqNGp+0N02uuQ==
=6K/6
-----END PGP SIGNATURE-----

--mhwC5aop5uFcSu15uaLNzT91NGrYN4Nv1--


From xen-devel-bounces@lists.xenproject.org Tue Oct 05 08:34:43 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Oct 2021 08:34:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.202101.356775 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXfu6-0006fy-JF; Tue, 05 Oct 2021 08:34:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 202101.356775; Tue, 05 Oct 2021 08:34:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXfu6-0006fr-FM; Tue, 05 Oct 2021 08:34:26 +0000
Received: by outflank-mailman (input) for mailman id 202101;
 Tue, 05 Oct 2021 08:34:25 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=u4De=OZ=arm.com=Rahul.Singh@srs-us1.protection.inumbo.net>)
 id 1mXfu5-0006fl-Rz
 for xen-devel@lists.xenproject.org; Tue, 05 Oct 2021 08:34:25 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com (unknown
 [40.107.8.87]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 5a35f3e6-220c-48e6-aba7-5e9abdaa5fa2;
 Tue, 05 Oct 2021 08:34:23 +0000 (UTC)
Received: from DB6PR07CA0082.eurprd07.prod.outlook.com (2603:10a6:6:2b::20) by
 VE1PR08MB5853.eurprd08.prod.outlook.com (2603:10a6:800:1a5::24) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.15; Tue, 5 Oct
 2021 08:34:20 +0000
Received: from DB5EUR03FT007.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:6:2b:cafe::6d) by DB6PR07CA0082.outlook.office365.com
 (2603:10a6:6:2b::20) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.7 via Frontend
 Transport; Tue, 5 Oct 2021 08:34:19 +0000
Received: from 64aa7808-outbound-2.mta.getcheckrecipient.com (63.33.187.114)
 by DB5EUR03FT007.mail.protection.outlook.com (10.152.20.148) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4566.14 via Frontend Transport; Tue, 5 Oct 2021 08:34:19 +0000
Received: ("Tessian outbound 1fd2edb24cb2:v103");
 Tue, 05 Oct 2021 08:34:15 +0000
Received: from aec08f629fda.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 FA7FC38F-A968-4019-BC18-D810418B83E9.1; 
 Tue, 05 Oct 2021 08:05:12 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id aec08f629fda.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Tue, 05 Oct 2021 08:05:12 +0000
Received: from AS8PR08MB6919.eurprd08.prod.outlook.com (2603:10a6:20b:39e::10)
 by AM6PR08MB4357.eurprd08.prod.outlook.com (2603:10a6:20b:74::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.22; Tue, 5 Oct
 2021 08:05:07 +0000
Received: from AS8PR08MB6919.eurprd08.prod.outlook.com
 ([fe80::51ee:e7de:6c0a:bcf9]) by AS8PR08MB6919.eurprd08.prod.outlook.com
 ([fe80::51ee:e7de:6c0a:bcf9%7]) with mapi id 15.20.4566.022; Tue, 5 Oct 2021
 08:05:07 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5a35f3e6-220c-48e6-aba7-5e9abdaa5fa2
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=NGa1dcADGp7coLjs3vFe1jr5FArixMPZhhHt2PpB+gY=;
 b=gnm1kRyYjSJxZiEPF/M4d8Mp5UHUBGfngnU079dI18P4eI7lRwYDESCSHf8tTCYS8Ch3kESZoTjSwc168jdRbTZNwXLBfEh1cvQCEPOv6Apg2ZDGOIRBMzK577OYd0UFzk8LGtOS/WMb12ghHytjMQHvp6doZE6Fpxt2eUAtu54=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.33.187.114)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.33.187.114 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.33.187.114; helo=64aa7808-outbound-2.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 7afa33c84bd8eb72
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=fV4y6gPm9UT2LzTvHniv3xAl1kcVVhUXBigQLnrFbSdiga3gAbQBa8BdGFDi98gyFmPqm9xkhlE5nI6/gMRcvW2G4y6RB8Gq+mkDAZE+k6WcV+dHH4DOXBws+0Hdrwy4YSjNBaVzZeePOBtO0MhVwJG1yCsc4zgv75Z7v4vYh4NwYaxZvC8X0XXk3AxHR/5X5rupGkIb2bskHInEo0b9fUVv3DZ8iPS74kAiBXcsRB3o4z6sjm2oScJymTzcUvXRf2FjJs8i5/Ycyua+/bC4C/FVXzl89p1Kia2kp59QSkkZ+Oa+jaXcTg3FKhDfRffBSnFdnTvjq26wTsX4Q8mRLA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=NGa1dcADGp7coLjs3vFe1jr5FArixMPZhhHt2PpB+gY=;
 b=WOLd/hFIz6eVx6yRQsXaIWzi6uDfcsyBNc/NjabK+zrCw1rAVUfCMUd/G21yM726h46mOQPrmuiGcQm71lIAdwb+7wYHN1bbP8dA4o8Km6Li98H+E05KsjrGwENcXFaavSr2RcI8uKO4Zed7YR6Uo8H7ocR+V9gH2gENUsCIjHbpAwe9lZOZ+HemCkgJ6Lt2y4Z3iMOLJMZZYrlqq4ZEWHPbZEdGk8Vsyn0yci9i+vMBvyAR66QQunaem1RxM7Iim3yD2ym4Fz2Lxy4l1AhUZR/DzgV5zOZctt/ippX8d8TE9vT8n/d+ePhGrLLzx2MkS2VgziL2Ai6EH/idgNmElQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=NGa1dcADGp7coLjs3vFe1jr5FArixMPZhhHt2PpB+gY=;
 b=gnm1kRyYjSJxZiEPF/M4d8Mp5UHUBGfngnU079dI18P4eI7lRwYDESCSHf8tTCYS8Ch3kESZoTjSwc168jdRbTZNwXLBfEh1cvQCEPOv6Apg2ZDGOIRBMzK577OYd0UFzk8LGtOS/WMb12ghHytjMQHvp6doZE6Fpxt2eUAtu54=
From: Rahul Singh <Rahul.Singh@arm.com>
To: Stefano Stabellini <sstabellini@kernel.org>
CC: xen-devel <xen-devel@lists.xenproject.org>, Bertrand Marquis
	<Bertrand.Marquis@arm.com>, Andre Przywara <Andre.Przywara@arm.com>, Julien
 Grall <julien@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>, George Dunlap
	<george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>, Jan Beulich
	<jbeulich@suse.com>, Wei Liu <wl@xen.org>, =?iso-8859-1?Q?Roger_Pau_Monn=E9?=
	<roger.pau@citrix.com>
Subject: Re: [PATCH v4 03/14] xen/arm: Add PHYSDEVOP_pci_device_(*add/remove)
 support for ARM
Thread-Topic: [PATCH v4 03/14] xen/arm: Add PHYSDEVOP_pci_device_(*add/remove)
 support for ARM
Thread-Index: AQHXuRZ6OQMJi407TUqV/v+mB83zX6vDgdCAgACLbIA=
Date: Tue, 5 Oct 2021 08:05:07 +0000
Message-ID: <50158C0B-C660-4960-8600-A73A28CD149B@arm.com>
References: <cover.1633340795.git.rahul.singh@arm.com>
 <99ee039a6cdd9ac7d54f1f01649d1dd3eeea3763.1633340795.git.rahul.singh@arm.com>
 <alpine.DEB.2.21.2110041639560.3209@sstabellini-ThinkPad-T480s>
In-Reply-To: <alpine.DEB.2.21.2110041639560.3209@sstabellini-ThinkPad-T480s>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
Authentication-Results-Original: kernel.org; dkim=none (message not signed)
 header.d=none;kernel.org; dmarc=none action=none header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: d7ba3079-aa7c-44ca-2880-08d987daecf8
x-ms-traffictypediagnostic: AM6PR08MB4357:|VE1PR08MB5853:
x-ms-exchange-transport-forked: True
X-Microsoft-Antispam-PRVS:
	<VE1PR08MB58532E302D081585B4D1AAFDFCAF9@VE1PR08MB5853.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:8273;OLM:8273;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 5hiGsAjygpAR/+pdiYFnor1ZxDe1Vr1wOr1wlrfcASbcD4I2OpXmVKp6ZzR7NrpQOSL/YHOVqLZAMudHOZgThu6f6xH9OVqnFI0XZ43E+Kc//0tvR9DMhyhcTCU+CsbJyKL7vzSUU9kjwbayIozOtlsYAG1pctUv+1dNyVt93/jbLfc3lVPObParwjm5rrCbHFYPCa0xO4DbQJSNOG62HwBfWWAjOyhzXXw3oQRS/kRcQbbiEGMLw1FY3BwmzC6ksNzgyi0YaVSTUM71O8CV1THEDHoxH8AnTrendoRjD2Q7KSxI+Z+hXJ/njL55UuyFcwx9DDNjpke4thnwr9yZ40GrVi2rMGAkLOBSLku3ZHiIedkb1YUDpEwJPWCGWPq8g1rXksF1D8nClTMxF7MefSq3R7Ywf6J/wiVoT1JlWdQdfFvaLyJgQKgcDzcvVXBsDp1BS4IzLWlpJuAQblhjeXexJ/9ZtJgCcMTyT+LAJAl0rDYb4NXzkgt2/S/63jJlyYgccM5uXBKCEddTaLm8l+JKnHikrXnvFWB3KAaGkDhhZ6diIQ3omUnrHRUgcIpZd4oKV5t8pOH+odzaJAx4k8JS95MWn1VMYEc+F9kbgi/QfaJgWVSLpzdpHJk1ZjoWh2kPkcYqmmStRkLXvKF5TjIaQsgbmFmVIqhA02TGtMXBtp8YnHGJqMoZxeQDMrFrt2SQrgGZopN/id2If8qfHhl66L7/WJFG4cplq02R1fTST+Uv7TYN+92BY9qEeqmK
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6919.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(6486002)(26005)(5660300002)(38070700005)(4326008)(83380400001)(2616005)(186003)(508600001)(8676002)(316002)(7416002)(38100700002)(2906002)(122000001)(8936002)(86362001)(76116006)(91956017)(71200400001)(33656002)(53546011)(66476007)(66556008)(66946007)(6512007)(6506007)(66446008)(64756008)(54906003)(36756003)(6916009)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="iso-8859-1"
Content-ID: <14492B373725984DB977E0BEE0A9F448@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB4357
Original-Authentication-Results: kernel.org; dkim=none (message not signed)
 header.d=none;kernel.org; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT007.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	ddf35a63-db3e-4aa6-cba8-08d987d6d862
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	SEeD12OWNew6XqCAM2hIaIErotUab2ejtKxVBxlENnoDl9k33tQ7mhZZ8HmrlBKi1/jhc8T5ShtKEvNr6zN8fR0d/Li/AQ8Vjkj+1jvfFwpVt2SbD1O80g9KNL7KIAVHTvZlWwr0N6AIgTWxlGVVa2UUDjeXDTeJt/qKsPzIhUJE/R7vgFmhzYqTh07vdIdWjCdNvxTphiV7zddwMzbdOVktqd6dOZLqSYFs+VY2gc3SrPgJno/pSvAPyHDQIDQnk4SxZRX7BU6snWXj6MsivKcA2R5RDOARocIaWc2zXOMJXF45O4jRbARRzWdRNk0hm4AeCSpknDAeTwyjCJiWzHaY4BPN0M2pWdMH2dNMUEL7eRvEAHX90Lt07UiYaJt1Ra5+ZE75UrwJ4b2JDrE2aThTWU4cIqSxRaEKOHGKbqHMvty3TH5EWX82/RGI/lWvaPZeFijJ9bt98V2CGsF7xZQz2ZtsXtCeNEccAgsvXDue3VT7vIqvI8xrKgUOxWdQzuhKb/Yw9WuPFM9TMtBXsQoCCa65eF00zSnkI6Q/7PRisppIA759a9BGRCpgqTWuW6aaMpcM/dnGSeVw/CAFKGixljBoBC6qMZfYxavkR3Wm5YbIU6BNFqEM1/bYTGPzWWbMDmbG28kzu4K6aECD15ux1p9LZetaKbdv9x1uETrT8+PkqgRQfBfrXH31oMVkzyq9EWa46xhCxmXTbLUfNw==
X-Forefront-Antispam-Report:
	CIP:63.33.187.114;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-2.mta.getcheckrecipient.com;PTR:ec2-63-33-187-114.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(4326008)(5660300002)(86362001)(508600001)(83380400001)(33656002)(81166007)(82310400003)(6862004)(36756003)(8936002)(26005)(6512007)(70206006)(316002)(2616005)(70586007)(6486002)(2906002)(6506007)(53546011)(36860700001)(356005)(186003)(336012)(8676002)(54906003)(47076005)(107886003);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Oct 2021 08:34:19.7852
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: d7ba3079-aa7c-44ca-2880-08d987daecf8
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.33.187.114];Helo=[64aa7808-outbound-2.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT007.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5853

Hi Stefano,

> On 5 Oct 2021, at 12:46 am, Stefano Stabellini <sstabellini@kernel.org> w=
rote:
>=20
> On Mon, 4 Oct 2021, Rahul Singh wrote:
>> Hardware domain is in charge of doing the PCI enumeration and will
>> discover the PCI devices and then will communicate to XEN via hyper
>> call PHYSDEVOP_pci_device_add(..) to add the PCI devices in XEN.
>>=20
>> Also implement PHYSDEVOP_pci_device_remove(..) to remove the PCI device.
>>=20
>> As most of the code for PHYSDEVOP_pci_device_* is the same between x86
>> and ARM, move the code to a common file to avoid duplication.
>>=20
>> There are other PHYSDEVOP_pci_device_* operations to add PCI devices.
>> Currently implemented PHYSDEVOP_pci_device_remove(..) and
>> PHYSDEVOP_pci_device_add(..) only as those are minimum required to
>> support PCI passthrough on ARM.
>>=20
>> Signed-off-by: Rahul Singh <rahul.singh@arm.com>
>> ---
>> Change in v4:
>> - Move file commom/physdev.c to drivers/pci/physdev.c
>> - minor comments.
>> Change in v3: Fixed minor comment.
>> Change in v2:
>> - Add support for PHYSDEVOP_pci_device_remove()
>> - Move code to common code
>> ---
>> ---
>> xen/arch/arm/physdev.c        |  5 +--
>> xen/arch/x86/physdev.c        | 52 +----------------------
>> xen/arch/x86/x86_64/physdev.c |  2 +-
>> xen/drivers/pci/Makefile      |  1 +
>> xen/drivers/pci/physdev.c     | 80 +++++++++++++++++++++++++++++++++++
>> xen/include/public/arch-arm.h |  4 +-
>> xen/include/xen/hypercall.h   | 11 +++++
>> 7 files changed, 100 insertions(+), 55 deletions(-)
>> create mode 100644 xen/drivers/pci/physdev.c
>>=20
>> diff --git a/xen/arch/arm/physdev.c b/xen/arch/arm/physdev.c
>> index e91355fe22..d766978629 100644
>> --- a/xen/arch/arm/physdev.c
>> +++ b/xen/arch/arm/physdev.c
>> @@ -8,13 +8,12 @@
>> #include <xen/lib.h>
>> #include <xen/errno.h>
>> #include <xen/sched.h>
>> -#include <asm/hypercall.h>
>> +#include <xen/hypercall.h>
>>=20
>>=20
>> int do_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
>> {
>> -    gdprintk(XENLOG_DEBUG, "PHYSDEVOP cmd=3D%d: not implemented\n", cmd=
);
>> -    return -ENOSYS;
>> +    return pci_physdev_op(cmd, arg);
>> }
>>=20
>> /*
>> diff --git a/xen/arch/x86/physdev.c b/xen/arch/x86/physdev.c
>> index 23465bcd00..ea38be8b79 100644
>> --- a/xen/arch/x86/physdev.c
>> +++ b/xen/arch/x86/physdev.c
>> @@ -12,7 +12,7 @@
>> #include <asm/io_apic.h>
>> #include <asm/msi.h>
>> #include <asm/hvm/irq.h>
>> -#include <asm/hypercall.h>
>> +#include <xen/hypercall.h>
>> #include <public/xen.h>
>> #include <public/physdev.h>
>> #include <xsm/xsm.h>
>> @@ -480,54 +480,6 @@ ret_t do_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM=
(void) arg)
>>         break;
>>     }
>>=20
>> -    case PHYSDEVOP_pci_device_add: {
>> -        struct physdev_pci_device_add add;
>> -        struct pci_dev_info pdev_info;
>> -        nodeid_t node;
>> -
>> -        ret =3D -EFAULT;
>> -        if ( copy_from_guest(&add, arg, 1) !=3D 0 )
>> -            break;
>> -
>> -        pdev_info.is_extfn =3D !!(add.flags & XEN_PCI_DEV_EXTFN);
>> -        if ( add.flags & XEN_PCI_DEV_VIRTFN )
>> -        {
>> -            pdev_info.is_virtfn =3D 1;
>> -            pdev_info.physfn.bus =3D add.physfn.bus;
>> -            pdev_info.physfn.devfn =3D add.physfn.devfn;
>> -        }
>> -        else
>> -            pdev_info.is_virtfn =3D 0;
>> -
>> -        if ( add.flags & XEN_PCI_DEV_PXM )
>> -        {
>> -            uint32_t pxm;
>> -            size_t optarr_off =3D offsetof(struct physdev_pci_device_ad=
d, optarr) /
>> -                                sizeof(add.optarr[0]);
>> -
>> -            if ( copy_from_guest_offset(&pxm, arg, optarr_off, 1) )
>> -                break;
>> -
>> -            node =3D pxm_to_node(pxm);
>> -        }
>> -        else
>> -            node =3D NUMA_NO_NODE;
>> -
>> -        ret =3D pci_add_device(add.seg, add.bus, add.devfn, &pdev_info,=
 node);
>> -        break;
>> -    }
>> -
>> -    case PHYSDEVOP_pci_device_remove: {
>> -        struct physdev_pci_device dev;
>> -
>> -        ret =3D -EFAULT;
>> -        if ( copy_from_guest(&dev, arg, 1) !=3D 0 )
>> -            break;
>> -
>> -        ret =3D pci_remove_device(dev.seg, dev.bus, dev.devfn);
>> -        break;
>> -    }
>> -
>>     case PHYSDEVOP_prepare_msix:
>>     case PHYSDEVOP_release_msix: {
>>         struct physdev_pci_device dev;
>> @@ -663,7 +615,7 @@ ret_t do_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(=
void) arg)
>>     }
>>=20
>>     default:
>> -        ret =3D -ENOSYS;
>> +        ret =3D pci_physdev_op(cmd, arg);
>>         break;
>>     }
>>=20
>> diff --git a/xen/arch/x86/x86_64/physdev.c b/xen/arch/x86/x86_64/physdev=
.c
>> index 0a50cbd4d8..e3cbd5ebcb 100644
>> --- a/xen/arch/x86/x86_64/physdev.c
>> +++ b/xen/arch/x86/x86_64/physdev.c
>> @@ -9,7 +9,7 @@ EMIT_FILE;
>> #include <compat/xen.h>
>> #include <compat/event_channel.h>
>> #include <compat/physdev.h>
>> -#include <asm/hypercall.h>
>> +#include <xen/hypercall.h>
>>=20
>> #define do_physdev_op compat_physdev_op
>>=20
>> diff --git a/xen/drivers/pci/Makefile b/xen/drivers/pci/Makefile
>> index a98035df4c..972c923db0 100644
>> --- a/xen/drivers/pci/Makefile
>> +++ b/xen/drivers/pci/Makefile
>> @@ -1 +1,2 @@
>> obj-y +=3D pci.o
>> +obj-y +=3D physdev.o
>> diff --git a/xen/drivers/pci/physdev.c b/xen/drivers/pci/physdev.c
>> new file mode 100644
>> index 0000000000..4f3e1a96c0
>> --- /dev/null
>> +++ b/xen/drivers/pci/physdev.c
>> @@ -0,0 +1,80 @@
>> +
>> +#include <xen/guest_access.h>
>> +#include <xen/hypercall.h>
>> +#include <xen/init.h>
>> +
>> +#ifndef COMPAT
>> +typedef long ret_t;
>> +#endif
>> +
>> +ret_t pci_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
>> +{
>> +    ret_t ret;
>> +
>> +    switch ( cmd )
>> +    {
>> +    case PHYSDEVOP_pci_device_add: {
>> +        struct physdev_pci_device_add add;
>> +        struct pci_dev_info pdev_info;
>> +        nodeid_t node =3D NUMA_NO_NODE;
>> +
>> +        ret =3D -EFAULT;
>> +        if ( copy_from_guest(&add, arg, 1) !=3D 0 )
>> +            break;
>> +
>> +        pdev_info.is_extfn =3D (add.flags & XEN_PCI_DEV_EXTFN);
>> +        if ( add.flags & XEN_PCI_DEV_VIRTFN )
>> +        {
>> +            pdev_info.is_virtfn =3D true;
>> +            pdev_info.physfn.bus =3D add.physfn.bus;
>> +            pdev_info.physfn.devfn =3D add.physfn.devfn;
>> +        }
>> +        else
>> +            pdev_info.is_virtfn =3D false;
>> +
>> +#ifdef CONFIG_NUMA
>> +        if ( add.flags & XEN_PCI_DEV_PXM )
>> +        {
>> +            uint32_t pxm;
>> +            size_t optarr_off =3D offsetof(struct physdev_pci_device_ad=
d, optarr) /
>> +                                sizeof(add.optarr[0]);
>> +
>> +            if ( copy_from_guest_offset(&pxm, arg, optarr_off, 1) )
>> +                break;
>> +
>> +            node =3D pxm_to_node(pxm);
>> +        }
>> +#endif
>> +
>> +        ret =3D pci_add_device(add.seg, add.bus, add.devfn, &pdev_info,=
 node);
>> +        break;
>> +    }
>> +
>> +    case PHYSDEVOP_pci_device_remove: {
>> +        struct physdev_pci_device dev;
>> +
>> +        ret =3D -EFAULT;
>> +        if ( copy_from_guest(&dev, arg, 1) !=3D 0 )
>> +            break;
>> +
>> +        ret =3D pci_remove_device(dev.seg, dev.bus, dev.devfn);
>> +        break;
>> +    }
>> +
>> +    default:
>> +        ret =3D -ENOSYS;
>> +        break;
>> +    }
>> +
>> +    return ret;
>> +}
>> +
>> +/*
>> + * Local variables:
>> + * mode: C
>> + * c-file-style: "BSD"
>> + * c-basic-offset: 4
>> + * tab-width: 4
>> + * indent-tabs-mode: nil
>> + * End:
>> + */
>> diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm=
.h
>> index 6b5a5f818a..d46c61fca9 100644
>> --- a/xen/include/public/arch-arm.h
>> +++ b/xen/include/public/arch-arm.h
>> @@ -107,7 +107,9 @@
>>  *   All generic sub-operations
>>  *
>>  *  HYPERVISOR_physdev_op
>> - *   No sub-operations are currenty supported
>> + *   Exactly these sub-operations are supported:
>> + *   PHYSDEVOP_pci_device_add
>> + *   PHYSDEVOP_pci_device_remove
>>  *
>>  *  HYPERVISOR_sysctl
>>  *   All generic sub-operations, with the exception of:
>> diff --git a/xen/include/xen/hypercall.h b/xen/include/xen/hypercall.h
>> index 3771487a30..7096cc4fe4 100644
>> --- a/xen/include/xen/hypercall.h
>> +++ b/xen/include/xen/hypercall.h
>> @@ -45,6 +45,17 @@ extern long
>> do_platform_op(
>>     XEN_GUEST_HANDLE_PARAM(xen_platform_op_t) u_xenpf_op);
>>=20
>> +#ifdef CONFIG_HAS_PCI
>> +extern long
>> +pci_physdev_op(
>> +    int cmd, XEN_GUEST_HANDLE_PARAM(void) arg);
>> +#else
>> +static inline long pci_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(void)=
 arg)
>> +{
>> +    gdprintk(XENLOG_DEBUG, "PHYSDEVOP cmd=3D%d: not implemented\n", cmd=
);
>> +    return -ENOSYS;
>> +}
>> +#endif
>=20
> Everything looks good up until here and you seemed to have addressed
> Jan's comments well.
>=20
> However, for this last change to hypercall.h: hypercall.h doesn't seem
> to be the right place to add the static inline stub for the
> !CONFIG_HAS_PCI case.=20
>=20
> Given that only ARM needs the !CONFIG_HAS_PCI stub, I would add it
> directly to xen/arch/arm/physdev.c. Or just add an #ifdef directly
> within do_physdev_op in xen/arch/arm/physdev.c.

Ack . I will modify the code based on your suggestion.

Regards,
Rahul



From xen-devel-bounces@lists.xenproject.org Tue Oct 05 09:09:06 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Oct 2021 09:09:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.202110.356788 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXgRX-0001lB-5c; Tue, 05 Oct 2021 09:08:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 202110.356788; Tue, 05 Oct 2021 09:08:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXgRX-0001l4-2h; Tue, 05 Oct 2021 09:08:59 +0000
Received: by outflank-mailman (input) for mailman id 202110;
 Tue, 05 Oct 2021 09:08:58 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mXgRW-0001ku-7h; Tue, 05 Oct 2021 09:08:58 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mXgRV-0008I4-Um; Tue, 05 Oct 2021 09:08:57 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mXgRV-0001Cs-JR; Tue, 05 Oct 2021 09:08:57 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mXgRV-0003Hj-J2; Tue, 05 Oct 2021 09:08:57 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=DlqMxy4Zz7/bqIOA+FWQTyj+XyKlundJgvgvqIFhJBQ=; b=yTNvrk265zf/tZsSs1Lz6lhval
	C+VEr/G+LEN66DpYqvNgzgaG8g8rVEUaS7Q+RpUmy3QTs/hnBRDs1vAxM2f0yjNYop0tj+8cxX+/Q
	OIuWH9zxbl6gvbYyTJQrYzi2NOdj53dvUJRZwRruXB1J8YlJZxWWPnOgYrwOs5hWMNSU=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165373-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 165373: regressions - FAIL
X-Osstest-Failures:
    libvirt:build-armhf-libvirt:libvirt-build:fail:regression
    libvirt:build-amd64-libvirt:libvirt-build:fail:regression
    libvirt:build-arm64-libvirt:libvirt-build:fail:regression
    libvirt:build-i386-libvirt:libvirt-build:fail:regression
    libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    libvirt=5ff9e851cbfd4f3421086cf95644f4171e412f28
X-Osstest-Versions-That:
    libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 05 Oct 2021 09:08:57 +0000

flight 165373 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165373/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-armhf-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-amd64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-arm64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-i386-libvirt            6 libvirt-build            fail REGR. vs. 151777

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-libvirt-vhd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a

version targeted for testing:
 libvirt              5ff9e851cbfd4f3421086cf95644f4171e412f28
baseline version:
 libvirt              2c846fa6bcc11929c9fb857a22430fb9945654ad

Last test of basis   151777  2020-07-10 04:19:19 Z  452 days
Failing since        151818  2020-07-11 04:18:52 Z  451 days  437 attempts
Testing same since   165373  2021-10-05 04:18:56 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
    Adolfo Jayme Barrientos <fitoschido@gmail.com>
  Aleksandr Alekseev <alexander.alekseev@virtuozzo.com>
  Aleksei Zakharov <zaharov@selectel.ru>
  Andika Triwidada <andika@gmail.com>
  Andrea Bolognani <abologna@redhat.com>
  Ani Sinha <ani@anisinha.ca>
  Balázs Meskó <meskobalazs@mailbox.org>
  Barrett Schonefeld <bschoney@utexas.edu>
  Bastian Germann <bastiangermann@fishpost.de>
  Bastien Orivel <bastien.orivel@diateam.net>
  BiaoXiang Ye <yebiaoxiang@huawei.com>
  Bihong Yu <yubihong@huawei.com>
  Binfeng Wu <wubinfeng@huawei.com>
  Bjoern Walk <bwalk@linux.ibm.com>
  Boris Fiuczynski <fiuczy@linux.ibm.com>
  Brian Turek <brian.turek@gmail.com>
  Bruno Haible <bruno@clisp.org>
  Chris Mayo <aklhfex@gmail.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Ehrhardt <christian.ehrhardt@canonical.com>
  Christian Kirbach <christian.kirbach@gmail.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Cole Robinson <crobinso@redhat.com>
  Collin Walling <walling@linux.ibm.com>
  Cornelia Huck <cohuck@redhat.com>
  Cédric Bosdonnat <cbosdonnat@suse.com>
  Côme Borsoi <fedora@borsoi.fr>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniel Letai <dani@letai.org.il>
  Daniel P. Berrange <berrange@redhat.com>
  Daniel P. Berrangé <berrange@redhat.com>
  Didik Supriadi <didiksupriadi41@gmail.com>
  dinglimin <dinglimin@cmss.chinamobile.com>
  Dmytro Linkin <dlinkin@nvidia.com>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Eric Farman <farman@linux.ibm.com>
  Erik Skultety <eskultet@redhat.com>
  Fabian Affolter <mail@fabian-affolter.ch>
  Fabian Freyer <fabian.freyer@physik.tu-berlin.de>
  Fabiano Fidêncio <fabiano@fidencio.org>
  Fangge Jin <fjin@redhat.com>
  Farhan Ali <alifm@linux.ibm.com>
  Fedora Weblate Translation <i18n@lists.fedoraproject.org>
  gongwei <gongwei@smartx.com>
  Guoyi Tu<tu.guoyi@h3c.com>
  Göran Uddeborg <goeran@uddeborg.se>
  Halil Pasic <pasic@linux.ibm.com>
  Han Han <hhan@redhat.com>
  Hao Wang <wanghao232@huawei.com>
  Hela Basa <r45xveza@pm.me>
  Helmut Grohne <helmut@subdivi.de>
  Hiroki Narukawa <hnarukaw@yahoo-corp.jp>
  Ian Wienand <iwienand@redhat.com>
  Jakob Meng <jakobmeng@web.de>
  Jamie Strandboge <jamie@canonical.com>
  Jamie Strandboge <jamie@ubuntu.com>
  Jan Kuparinen <copper_fin@hotmail.com>
  jason lee <ppark5237@gmail.com>
  Jean-Baptiste Holcroft <jean-baptiste@holcroft.fr>
  Jia Zhou <zhou.jia2@zte.com.cn>
  Jianan Gao <jgao@redhat.com>
  Jim Fehlig <jfehlig@suse.com>
  Jin Yan <jinyan12@huawei.com>
  Jinsheng Zhang <zhangjl02@inspur.com>
  Jiri Denemark <jdenemar@redhat.com>
  John Ferlan <jferlan@redhat.com>
  Jonathan Watt <jwatt@jwatt.org>
  Jonathon Jongsma <jjongsma@redhat.com>
  Julio Faracco <jcfaracco@gmail.com>
  Justin Gatzen <justin.gatzen@gmail.com>
  Ján Tomko <jtomko@redhat.com>
  Kashyap Chamarthy <kchamart@redhat.com>
  Kevin Locke <kevin@kevinlocke.name>
  Kristina Hanicova <khanicov@redhat.com>
  Laine Stump <laine@redhat.com>
  Laszlo Ersek <lersek@redhat.com>
  Lee Yarwood <lyarwood@redhat.com>
  Lei Yang <yanglei209@huawei.com>
  Liao Pingfang <liao.pingfang@zte.com.cn>
  Lin Ma <lma@suse.com>
  Lin Ma <lma@suse.de>
  Lin Ma <morecache@gmail.com>
  Liu Yiding <liuyd.fnst@fujitsu.com>
  Luke Yue <lukedyue@gmail.com>
  Luyao Zhong <luyao.zhong@intel.com>
  Marc Hartmayer <mhartmay@linux.ibm.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Markus Schade <markus.schade@hetzner.com>
  Martin Kletzander <mkletzan@redhat.com>
  Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
  Matej Cepl <mcepl@cepl.eu>
  Matt Coleman <matt@datto.com>
  Matt Coleman <mcoleman@datto.com>
  Mauro Matteo Cascella <mcascell@redhat.com>
  Meina Li <meili@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Michał Smyk <fedora@smyk.it>
  Milo Casagrande <milo@milo.name>
  Moshe Levi <moshele@nvidia.com>
  Muha Aliss <muhaaliss@gmail.com>
  Nathan <nathan95@live.it>
  Neal Gompa <ngompa13@gmail.com>
  Nick Chevsky <nchevsky@gmail.com>
  Nick Shyrokovskiy <nshyrokovskiy@gmail.com>
  Nickys Music Group <nickys.music.group@gmail.com>
  Nico Pache <npache@redhat.com>
  Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
  Olaf Hering <olaf@aepfle.de>
  Olesya Gerasimenko <gammaray@basealt.ru>
  Orion Poplawski <orion@nwra.com>
  Pany <geekpany@gmail.com>
  Patrick Magauran <patmagauran.j@gmail.com>
  Paulo de Rezende Pinatti <ppinatti@linux.ibm.com>
  Pavel Hrdina <phrdina@redhat.com>
  Peng Liang <liangpeng10@huawei.com>
  Peter Krempa <pkrempa@redhat.com>
  Pino Toscano <ptoscano@redhat.com>
  Pino Toscano <toscano.pino@tiscali.it>
  Piotr Drąg <piotrdrag@gmail.com>
  Prathamesh Chavan <pc44800@gmail.com>
  Richard W.M. Jones <rjones@redhat.com>
  Ricky Tigg <ricky.tigg@gmail.com>
  Robin Lee <cheeselee@fedoraproject.org>
  Roman Bogorodskiy <bogorodskiy@gmail.com>
  Roman Bolshakov <r.bolshakov@yadro.com>
  Ryan Gahagan <rgahagan@cs.utexas.edu>
  Ryan Schmidt <git@ryandesign.com>
  Sam Hartman <hartmans@debian.org>
  Scott Shambarger <scott-libvirt@shambarger.net>
  Sebastian Mitterle <smitterl@redhat.com>
  SeongHyun Jo <caelus9536@gmail.com>
  Shalini Chellathurai Saroja <shalini@linux.ibm.com>
  Shaojun Yang <yangshaojun@phytium.com.cn>
  Shi Lei <shi_lei@massclouds.com>
  simmon <simmon@nplob.com>
  Simon Chopin <chopin.simon@gmail.com>
  Simon Gaiser <simon@invisiblethingslab.com>
  Simon Rowe <simon.rowe@nutanix.com>
  Stefan Bader <stefan.bader@canonical.com>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Berger <stefanb@linux.vnet.ibm.com>
  Stefan Hajnoczi <stefanha@gmail.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Szymon Scholz <szymonscholz@gmail.com>
  Thomas Huth <thuth@redhat.com>
  Tim Wiederhake <twiederh@redhat.com>
  Tomáš Golembiovský <tgolembi@redhat.com>
  Tomáš Janoušek <tomi@nomi.cz>
  Tuguoyi <tu.guoyi@h3c.com>
  Victor Toso <victortoso@redhat.com>
  Ville Skyttä <ville.skytta@iki.fi>
  Vinayak Kale <vkale@nvidia.com>
  Wang Xin <wangxinxin.wang@huawei.com>
  WangJian <wangjian161@huawei.com>
  Weblate <noreply@weblate.org>
  Wei Liu <liuwe@microsoft.com>
  Wei Liu <wei.liu@kernel.org>
  William Douglas <william.douglas@intel.com>
  Yalei Li <274268859@qq.com>
  Yalei Li <liyl43@chinatelecom.cn>
  Yang Fei <yangfei85@huawei.com>
  Yang Hang <yanghang44@huawei.com>
  Yanqiu Zhang <yanqzhan@redhat.com>
  Yaroslav Kargin <ykargin@virtuozzo.com>
  Yi Li <yili@winhong.com>
  Yi Wang <wang.yi59@zte.com.cn>
  Yuri Chornoivan <yurchor@ukr.net>
  Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
  zhangjl02 <zhangjl02@inspur.com>
  Zheng Chuan <zhengchuan@huawei.com>
  zhenwei pi <pizhenwei@bytedance.com>
  Zhenyu Ye <yezhenyu2@huawei.com>
  Zhenyu Zheng <zheng.zhenyu@outlook.com>
  Zhenzhong Duan <zhenzhong.duan@intel.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          fail    
 build-arm64-libvirt                                          fail    
 build-armhf-libvirt                                          fail    
 build-i386-libvirt                                           fail    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           blocked 
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-libvirt-xsm                                 blocked 
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-libvirt                                     blocked 
 test-arm64-arm64-libvirt                                     blocked 
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-libvirt-pair                                blocked 
 test-amd64-i386-libvirt-pair                                 blocked 
 test-arm64-arm64-libvirt-qcow2                               blocked 
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-libvirt-vhd                                 blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 76812 lines long.)


From xen-devel-bounces@lists.xenproject.org Tue Oct 05 09:52:06 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Oct 2021 09:52:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.202121.356803 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXh73-0006ni-9C; Tue, 05 Oct 2021 09:51:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 202121.356803; Tue, 05 Oct 2021 09:51:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXh73-0006nb-4r; Tue, 05 Oct 2021 09:51:53 +0000
Received: by outflank-mailman (input) for mailman id 202121;
 Tue, 05 Oct 2021 09:51:52 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mXh72-0006nR-A5; Tue, 05 Oct 2021 09:51:52 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mXh72-0000XQ-0j; Tue, 05 Oct 2021 09:51:52 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mXh71-0003AH-Lv; Tue, 05 Oct 2021 09:51:51 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mXh71-00022D-LO; Tue, 05 Oct 2021 09:51:51 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=LuEdhYwAy3izY1Vtjf59Qzaamw/qUzZZ2LGBBIqFkvo=; b=SQ3AeY2BQ5ZTJJYIPGN/67gvPv
	9oYJ98Hld91BeP6EdYQaj7CHnCrNo9ugmwaOXxgKFfAGi3IiFU4xAXXRmoBrWFGgghllyfEaK0sHv
	+2VgAupRKurslbYgglou4l1cYwR8o+jyp8C/2TzEUCOMzEaEC2kB9ukTHoxlhB+vfXEg=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165346-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-5.4 test] 165346: regressions - FAIL
X-Osstest-Failures:
    linux-5.4:test-armhf-armhf-xl-credit1:guest-start:fail:regression
    linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:xen-boot:fail:heisenbug
    linux-5.4:test-armhf-armhf-xl-credit2:xen-boot:fail:heisenbug
    linux-5.4:test-armhf-armhf-xl-rtds:guest-start.2:fail:allowable
    linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:guest-start/debian.repeat:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=3a7dc5b4cfbdfd8da37cb0e54f439d84cf5a5123
X-Osstest-Versions-That:
    linux=e74e2950a0d6f800858e54860d7124c86e494f62
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 05 Oct 2021 09:51:51 +0000

flight 165346 linux-5.4 real [real]
flight 165375 linux-5.4 real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/165346/
http://logs.test-lab.xenproject.org/osstest/logs/165375/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-armhf-armhf-xl-credit1  14 guest-start              fail REGR. vs. 165206

Tests which are failing intermittently (not blocking):
 test-amd64-i386-xl-qemuu-ws16-amd64  8 xen-boot     fail pass in 165375-retest
 test-armhf-armhf-xl-credit2   8 xen-boot            fail pass in 165375-retest

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds     19 guest-start.2            fail REGR. vs. 165206

Tests which did not succeed, but are not blocking:
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop   fail in 165375 like 165206
 test-armhf-armhf-xl-credit2 15 migrate-support-check fail in 165375 never pass
 test-armhf-armhf-xl-credit2 16 saverestore-support-check fail in 165375 never pass
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165206
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 165206
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 165206
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 165206
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165206
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165206
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 165206
 test-arm64-arm64-libvirt-raw 17 guest-start/debian.repeat    fail  like 165206
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 165206
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 165206
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 165206
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 165206
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 linux                3a7dc5b4cfbdfd8da37cb0e54f439d84cf5a5123
baseline version:
 linux                e74e2950a0d6f800858e54860d7124c86e494f62

Last test of basis   165206  2021-09-26 12:42:13 Z    8 days
Testing same since   165346  2021-10-04 12:42:32 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Alan Stern <stern@rowland.harvard.edu>
  Alexei Starovoitov <ast@kernel.org>
  Andreas Larsson <andreas@gaisler.com>
  Andrew Morton <akpm@linux-foundation.org>
  Andy Shevchenko <andriy.shevchenko@linux.intel.com>
  Antoine Tenart <atenart@kernel.org>
  Anton Eidelman <anton.eidelman@gmail.com>
  Anton Eidelman <anton@lightbitslabs.com>
  Ariel Elior <aelior@marvell.com>
  Arnd Bergmann <arnd@arndb.de>
  Aya Levin <ayal@nvidia.com>
  Baokun Li <libaokun1@huawei.com>
  Bartosz Golaszewski <brgl@bgdev.pl>
  Bixuan Cui <cuibixuan@huawei.com>
  Borislav Petkov <bp@suse.de>
  Carlo Lobrano <c.lobrano@gmail.com>
  Catalin Marinas <catalin.marinas@arm.com>
  Chris Chiu <chris.chiu@canonical.com>
  Christian Brauner <christian.brauner@ubuntu.com>
  Christoph Hellwig <hch@lst.de>
  Claudiu Manoil <claudiu.manoil@nxp.com>
  Dan Carpenter <dan.carpenter@oracle.com>
  Dan Li <ashimida@linux.alibaba.com>
  Daniel Lezcano <daniel.lezcano@linaro.org>
  David Howells <dhowells@redhat.com>
  David S. Miller <davem@davemloft.net>
  David Sterba <dsterba@suse.com>
  Dmitry Bogdanov <d.bogdanov@yadro.com>
  Felipe Balbi <balbi@kernel.org>
  Florian Fainelli <f.fainelli@gmail.com>
  Gao Xiang <hsiangkao@linux.alibaba.com>
  Geert Uytterhoeven <geert@linux-m68k.org>
  Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  Gregory CLEMENT <gregory.clement@bootlin.com>
  Guenter Roeck <linux@roeck-us.net>
  Hans de Goede <hdegoede@redhat.com>
  Helge Deller <deller@gmx.de>
  Hulk Robot <hulkrobot@huawei.com>
  Jan Beulich <jbeulich@suse.com>
  Jens Axboe <axboe@kernel.dk>
  Jesper Nilsson <jesper.nilsson@axis.com>
  Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
  Jiri Slaby <jslaby@suse.cz>
  Johan Hovold <johan@kernel.org>
  Johannes Thumshirn <jth@kernel.org>
  Jon Hunter <jonathanh@nvidia.com>
  Juergen Gross <jgross@suse.com>
  Julian Sikorski <belegdol+github@gmail.com>
  Julian Sikorski <belegdol@gmail.com>
  Kaige Fu <kaige.fu@linux.alibaba.com>
  Karsten Graul <kgraul@linux.ibm.com>
  Kishon Vijay Abraham I <kishon@ti.com>
  Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
  Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
  Li Jinlin <lijinlin3@huawei.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Linux Kernel Functional Testing <lkft@linaro.org>
  Marc Zyngier <maz@kernel.org>
  Mark Rutland <mark.rutland@arm.com>
  Markus Suvanto <markus.suvanto@gmail.com>
  Martin K. Petersen <martin.petersen@oracle.com>
  Michael Chan <michael.chan@broadcom.com>
  Michael Chan <michael.chan@broadocm.com>
  Michal Kalderon <mkalderon@marvell.com>
  Minas Harutyunyan <Minas.Harutyunyan@synopsys.com>
  Moritz Fischer <mdf@kernel.org>
  Nicolas Ferre <nicolas.ferre@microchip.com>
  Oliver Neukum <oneukum@suse.com>
  Ondrej Zary <linux@zary.sk>
  Pali Rohár <pali@kernel.org>
  Qu Wenruo <wqu@suse.com>
  Randy Dunlap <rdunlap@infradead.org>
  Ronnie Sahlberg <lsahlber@redhat.com>
  Sai Krishna Potthuri <lakshmi.sai.krishna.potthuri@xilinx.com>
  Sasha Levin <sashal@kernel.org>
  Shai Malin <smalin@marvell.com>
  Shuah Khan <skhan@linuxfoundation.org>
  Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
  Slark Xiao <slark_xiao@163.com>
  Song Liu <songliubraving@fb.com>
  Srinivas Pandruvada <srinivas.pI andruvada@linux.intel.com>
  Steve French <stfrench@microsoft.com>
  Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
  syzbot+fadc0aaf497e6a493b9f@syzkaller.appspotmail.com
  Tariq Toukan <tariqt@nvidia.com>
  Tejun Heo <tj@kernel.org>
  Todd Kjos <tkjos@google.com>
  Tom Rix <trix@redhat.com>
  Tong Zhang <ztong0001@gmail.com>
  Uwe Brandt <uwe.brandt@gmail.com>
  Wengang Wang <wen.gang.wang@oracle.com>
  Yonghong Song <yhs@fb.com>
  zhang kai <zhangkaiheb@126.com>
  Zhihao Cheng <chengzhihao1@huawei.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  fail    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 fail    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 1974 lines long.)


From xen-devel-bounces@lists.xenproject.org Tue Oct 05 10:11:33 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Oct 2021 10:11:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.202130.356816 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXhPy-0000rM-Td; Tue, 05 Oct 2021 10:11:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 202130.356816; Tue, 05 Oct 2021 10:11:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXhPy-0000rF-QV; Tue, 05 Oct 2021 10:11:26 +0000
Received: by outflank-mailman (input) for mailman id 202130;
 Tue, 05 Oct 2021 10:11:25 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=u4De=OZ=arm.com=Rahul.Singh@srs-us1.protection.inumbo.net>)
 id 1mXhPx-0000r9-HI
 for xen-devel@lists.xenproject.org; Tue, 05 Oct 2021 10:11:25 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com (unknown
 [40.107.8.89]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id ef200d94-fd13-46ca-99a1-582eff625380;
 Tue, 05 Oct 2021 10:11:21 +0000 (UTC)
Received: from AS8P250CA0016.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:330::21)
 by AS8PR08MB7026.eurprd08.prod.outlook.com (2603:10a6:20b:34d::7)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.21; Tue, 5 Oct
 2021 10:11:19 +0000
Received: from AM5EUR03FT028.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:330:cafe::1) by AS8P250CA0016.outlook.office365.com
 (2603:10a6:20b:330::21) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18 via Frontend
 Transport; Tue, 5 Oct 2021 10:11:19 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM5EUR03FT028.mail.protection.outlook.com (10.152.16.118) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4566.14 via Frontend Transport; Tue, 5 Oct 2021 10:11:19 +0000
Received: ("Tessian outbound b9598e0ead92:v103");
 Tue, 05 Oct 2021 10:11:19 +0000
Received: from f146f0c46f64.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 E91CECF4-91F2-4763-9C91-472616ABCD7D.1; 
 Tue, 05 Oct 2021 10:11:08 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id f146f0c46f64.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Tue, 05 Oct 2021 10:11:08 +0000
Received: from AS8PR08MB6919.eurprd08.prod.outlook.com (2603:10a6:20b:39e::10)
 by AS8PR08MB6360.eurprd08.prod.outlook.com (2603:10a6:20b:33e::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.15; Tue, 5 Oct
 2021 10:11:06 +0000
Received: from AS8PR08MB6919.eurprd08.prod.outlook.com
 ([fe80::51ee:e7de:6c0a:bcf9]) by AS8PR08MB6919.eurprd08.prod.outlook.com
 ([fe80::51ee:e7de:6c0a:bcf9%7]) with mapi id 15.20.4566.022; Tue, 5 Oct 2021
 10:11:06 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ef200d94-fd13-46ca-99a1-582eff625380
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=jAA79ZQmEDsAMnBWNqOLwOtluzjsipu4sqaADji4FeA=;
 b=CTePS4BVKHGhmV4AycK2fxMG5Xah27RwXQrHFDFSstl8XWEyceoIsHQBQvuyytQUaKdns75Xt10iGL2qLWc9AUhCXfeaCvzcM03zq6u0sBuBkoQqj52x9WeMXY5b155krkft4ifadW6xgw87LraK7KGlynh5fPzihvhwZ7paEKg=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 354b5eb497511c7e
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=nlfErL42uNxQfutjwYeLI4xLMq7U0SMWSxIDh9lotppzcpq2wmZ3/X++oeVkO7/hAPDbUye9d+qVgU5X+li5xoTCWWVDWNGaHS891s780TvpPg8tRVPG/uT3NRi2h7IcJzo5zoup9bx6U4zUsCfiNiY3Uy0ddUXRwtjaPuWlj7zMqH6gje3DT4SyOE91rq38JztgBvTK6AqlcZPixasdVCngNQOrzfknkxMGmz6vjFaAUalJroxKDyLKeaPdDxKjv3eLum86NQTUc5/GEYhGCWOyMb0ymbD0WGivsXvcmMX8z3M/rcI3iS8599V7G6MFBpTENktFmciN446YkoXtpg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=jAA79ZQmEDsAMnBWNqOLwOtluzjsipu4sqaADji4FeA=;
 b=Z292Mg8R/Ar1xNPMFUTcAtm7rtEHAbrr8rblhDUkDAKoa+WVfAd8KkK+8u/VEF39Mol+mhE4eVCqk5KEnYqFjI695dMAvuLnMmvHc/1v/MPoM+B0WsNdW30zPRRjDAjY1hvKoll6aow8LzgCyoxf+5vE/n1zj6ByOfo2nHlXk5SCjeTeEVWhwYqM0X3jY/OkHi0UeJHrGldOvNjS6gX4K7WjGUMKrB9mlcq5P6aW0fSVfU+l98nZHZR0tx39PcUwdR0tb3Hj3XRz8nLrvc6e5pUR7BnPHTOet3jfHo0ms9pMMURTtLizPvFA1W9pDtv0P1Jr1BTWpMIXBC0jez9H2w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=jAA79ZQmEDsAMnBWNqOLwOtluzjsipu4sqaADji4FeA=;
 b=CTePS4BVKHGhmV4AycK2fxMG5Xah27RwXQrHFDFSstl8XWEyceoIsHQBQvuyytQUaKdns75Xt10iGL2qLWc9AUhCXfeaCvzcM03zq6u0sBuBkoQqj52x9WeMXY5b155krkft4ifadW6xgw87LraK7KGlynh5fPzihvhwZ7paEKg=
From: Rahul Singh <Rahul.Singh@arm.com>
To: Stefano Stabellini <sstabellini@kernel.org>
CC: xen-devel <xen-devel@lists.xenproject.org>, Bertrand Marquis
	<Bertrand.Marquis@arm.com>, Andre Przywara <Andre.Przywara@arm.com>, Ian
 Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>, Anthony PERARD
	<anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>, Julien Grall
	<julien@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH v4 13/14] arm/libxl: Emulated PCI device tree node in
 libxl
Thread-Topic: [PATCH v4 13/14] arm/libxl: Emulated PCI device tree node in
 libxl
Thread-Index: AQHXuRciClWhjFX7R0aQhsW/aixhyqvDkJEAgACf3oA=
Date: Tue, 5 Oct 2021 10:11:06 +0000
Message-ID: <11F169C6-39A4-40F3-8E75-39B8C2CCF022@arm.com>
References: <cover.1633340795.git.rahul.singh@arm.com>
 <3ad42008f534671ae7f5b25da91253ce7cd4a3e9.1633340795.git.rahul.singh@arm.com>
 <alpine.DEB.2.21.2110041714410.3209@sstabellini-ThinkPad-T480s>
In-Reply-To: <alpine.DEB.2.21.2110041714410.3209@sstabellini-ThinkPad-T480s>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
Authentication-Results-Original: kernel.org; dkim=none (message not signed)
 header.d=none;kernel.org; dmarc=none action=none header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: 4158e0e9-0096-48fd-3237-08d987e879c7
x-ms-traffictypediagnostic: AS8PR08MB6360:|AS8PR08MB7026:
x-ms-exchange-transport-forked: True
X-Microsoft-Antispam-PRVS:
	<AS8PR08MB70267F4A0C3A511474F730A8FCAF9@AS8PR08MB7026.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:9508;OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 SGokEHdGGyJU4QAko6K78uCWumLn4vo+b82lV/CXlcW1bQnt9UHl2TYZoHRJ7qtJolRdXpjWBK0FuH0Xqf0zYxP7HImTemJJAtnDu5zDZg44PFXwlI91tKpRaAfBlGNTFkCJFPR26eLBt12lxWjfAsHNbQkgu0E3/hOKBKYhBJNs6ZCJd7gyNIl/bLw+1kC2i4j5rUgQijczgKEduBReOm/Yj4jcI7G+fUbfc3aMM9RxGwPUsxzuXQbFi2do61gY8WN6f/66576m3gZbACf+Av/Rpv1ExfNIicCOiMKhWRQuHX3TIWMW26WfYdC2nvFmHCJx+NsO0smJ/xGhj+p4cJwb/Ar7EpRdRbK/W0pdU3C5aP7PMw2GtDvNrNwS0CM+jecynx/IxIQil45p+V/F26ZAEFxUn/fACUtQG3xGTDOk8CeZpMFsjhcRqGAUAFQXDIhxSK2VimoCdOb/iGknT5biz0zFGPPS5eubpv4K2Le68f4IAGYMmQb7d3arp8GiVpUwzlOEmq7BI6jCLXw1T5nJsj2GcJA+6eMbQqtYjNMg7WhOIq4CSz/7tRFk9sZ2bTIRHCIm1nRPjHtY9yoeFQgGoVNFhRLTnOAcCeLJhq4GxZ0oSq/CK2jh0asGzBDJmPb0MpAsoeT9alFxYT3FHMJyhsmn0BHCP35VCaN5cgNJ43X0QuRMSFBJmp/k9XGbhQELqSvGHueIXPMz8Zl4kztUd/YR/HS5aVGma01xwWHsMjiQrxP0iM4303GoVFeG
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6919.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(6486002)(64756008)(91956017)(26005)(53546011)(8676002)(76116006)(186003)(66476007)(66556008)(6506007)(66946007)(66446008)(4326008)(86362001)(8936002)(71200400001)(54906003)(316002)(122000001)(6512007)(2616005)(83380400001)(30864003)(6916009)(33656002)(36756003)(2906002)(38100700002)(508600001)(38070700005)(5660300002)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-ID: <52AEBA797A055D4FBFA8A02D98069EE8@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6360
Original-Authentication-Results: kernel.org; dkim=none (message not signed)
 header.d=none;kernel.org; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM5EUR03FT028.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	b5f65555-6a45-4dba-af29-08d987e871db
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	MM8F/BMeiVLSJWdeBOFkNzRVm14aTLXVghf7Ny7QcpL7evBfYeRGQZBNgzQxc4ne4CPa4m+rUnaRD9PsqIkfp0qsNdW6u/DKcBLaP5IgO7PU7vQRDBa4GiDzuUHGIKsJrNaWSoM9W/GC9XoW5z/oOwb0e+2hYZmo8cx8KrthrjsAWTR5yMIDRGhSxf6eBkvdtEpSFQ3nHKbXjOTSeYhCBHPxsmZqLL5YrOSf8gF9GGFoKKewdqoOYqI1iUCEX2CZ5QTFNtJKz7hGOLkLXDrogZ557XVZ3p3z8zZ/Nagsw7C/Dcqa3EGdbNS5MQ7GYfRBHstaUPjEuweP3RhVQzIAKInOD3/zIkGxPwh3UvK02ZcoYayaMHu/juPHR8/8MXRiC5XSq6USCezkKaME3AIqYawg+QKfWnQYrCAUWfBRYfzSiR9igTfjVblYMuBqYYFqpDsnk2vJEJ6JZeVrQjPWa5sM+xrPSxCcBtkP/ehpKh6VPWPCrAi2tH4L2edd7WoWgULh9OXn4ChbVRwIyA2elASXuMAEGxLUGzdyACM1X3Wl2iEywJzg7iRgQUpR2zrpyHK5ISUR9jhKFRAZO0eE2+FepsU4748s5Dep5ukcC5SAN+TuF6ID/c5XwzJCGrChG9XFrtCCiMdPzJG2yxSftBtjhwuGBwbsCI+EQkSLg884G+ao+g+YKpEuRUTq1CnC+a5ldyefjN8BGVzlTjvlTA==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(36756003)(336012)(53546011)(33656002)(4326008)(70206006)(6506007)(36860700001)(8936002)(70586007)(54906003)(316002)(2906002)(26005)(356005)(508600001)(6862004)(30864003)(83380400001)(86362001)(8676002)(6512007)(47076005)(107886003)(82310400003)(2616005)(186003)(5660300002)(6486002)(81166007);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Oct 2021 10:11:19.4176
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 4158e0e9-0096-48fd-3237-08d987e879c7
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM5EUR03FT028.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB7026

SGkgU3RlZmFubywNCg0KPiBPbiA1IE9jdCAyMDIxLCBhdCAxOjM4IGFtLCBTdGVmYW5vIFN0YWJl
bGxpbmkgPHNzdGFiZWxsaW5pQGtlcm5lbC5vcmc+IHdyb3RlOg0KPiANCj4gT24gTW9uLCA0IE9j
dCAyMDIxLCBSYWh1bCBTaW5naCB3cm90ZToNCj4+IGxpYnhsIHdpbGwgY3JlYXRlIGFuIGVtdWxh
dGVkIFBDSSBkZXZpY2UgdHJlZSBub2RlIGluIHRoZSBkZXZpY2UgdHJlZSB0bw0KPj4gZW5hYmxl
IHRoZSBndWVzdCBPUyB0byBkaXNjb3ZlciB0aGUgdmlydHVhbCBQQ0kgZHVyaW5nIGd1ZXN0IGJv
b3QuDQo+PiBFbXVsYXRlZCBQQ0kgZGV2aWNlIHRyZWUgbm9kZSB3aWxsIG9ubHkgYmUgY3JlYXRl
ZCB3aGVuIHRoZXJlIGlzIGFueQ0KPj4gZGV2aWNlIGFzc2lnbmVkIHRvIGd1ZXN0Lg0KPj4gDQo+
PiBBIG5ldyBhcmVhIGhhcyBiZWVuIHJlc2VydmVkIGluIHRoZSBhcm0gZ3Vlc3QgcGh5c2ljYWwg
bWFwIGF0DQo+PiB3aGljaCB0aGUgVlBDSSBidXMgaXMgZGVjbGFyZWQgaW4gdGhlIGRldmljZSB0
cmVlIChyZWcgYW5kIHJhbmdlcw0KPj4gcGFyYW1ldGVycyBvZiB0aGUgbm9kZSkuDQo+PiANCj4+
IFNpZ25lZC1vZmYtYnk6IFJhaHVsIFNpbmdoIDxyYWh1bC5zaW5naEBhcm0uY29tPg0KPj4gLS0t
DQo+PiBDaGFuZ2UgaW4gdjQ6DQo+PiAtIEdhdGUgY29kZSBmb3IgeDg2IGZvciBzZXR0aW5nIHRo
ZSBYRU5fRE9NQ1RMX0NERl92cGNpIGZvciB4ODYuDQo+PiBDaGFuZ2UgaW4gdjM6DQo+PiAtIE1h
a2UgR1VFU1RfVlBDSV9NRU1fQUREUiBhZGRyZXNzIDJNQiBhbGlnbmVkDQo+PiBDaGFuZ2UgaW4g
djI6DQo+PiAtIGVuYWJsZSBkb2FtaW5fdnBjaV9pbml0KCkgd2hlbiBYRU5fRE9NQ1RMX0NERl92
cGNpIGlzIHNldCBmb3IgZG9tYWluLg0KPj4gLS0tDQo+PiAtLS0NCj4+IHRvb2xzL2luY2x1ZGUv
bGlieGwuaCAgICAgICAgICAgIHwgICA2ICsrDQo+PiB0b29scy9saWJzL2xpZ2h0L2xpYnhsX2Fy
bS5jICAgICB8IDEwNSArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrDQo+PiB0b29scy9s
aWJzL2xpZ2h0L2xpYnhsX2NyZWF0ZS5jICB8ICAgOSArKysNCj4+IHRvb2xzL2xpYnMvbGlnaHQv
bGlieGxfdHlwZXMuaWRsIHwgICAxICsNCj4+IHRvb2xzL3hsL3hsX3BhcnNlLmMgICAgICAgICAg
ICAgIHwgICA4ICsrKw0KPj4geGVuL2luY2x1ZGUvcHVibGljL2FyY2gtYXJtLmggICAgfCAgMTAg
KysrDQo+PiA2IGZpbGVzIGNoYW5nZWQsIDEzOSBpbnNlcnRpb25zKCspDQo+PiANCj4+IGRpZmYg
LS1naXQgYS90b29scy9pbmNsdWRlL2xpYnhsLmggYi90b29scy9pbmNsdWRlL2xpYnhsLmgNCj4+
IGluZGV4IGI5YmExNmQ2OTguLjMzNjIwNzNiMjEgMTAwNjQ0DQo+PiAtLS0gYS90b29scy9pbmNs
dWRlL2xpYnhsLmgNCj4+ICsrKyBiL3Rvb2xzL2luY2x1ZGUvbGlieGwuaA0KPj4gQEAgLTM1OCw2
ICszNTgsMTIgQEANCj4+ICAqLw0KPj4gI2RlZmluZSBMSUJYTF9IQVZFX0JVSUxESU5GT19BUk1f
VlVBUlQgMQ0KPj4gDQo+PiArLyoNCj4+ICsgKiBMSUJYTF9IQVZFX0JVSUxESU5GT19BUk1fVlBD
SSBpbmRpY2F0ZXMgdGhhdCB0aGUgdG9vbHN0YWNrIHN1cHBvcnRzIHZpcnR1YWwNCj4+ICsgKiBQ
Q0kgZm9yIEFSTS4NCj4+ICsgKi8NCj4+ICsjZGVmaW5lIExJQlhMX0hBVkVfQlVJTERJTkZPX0FS
TV9WUENJIDENCj4+ICsNCj4+IC8qDQo+PiAgKiBMSUJYTF9IQVZFX0JVSUxESU5GT19HUkFOVF9M
SU1JVFMgaW5kaWNhdGVzIHRoYXQgbGlieGxfZG9tYWluX2J1aWxkX2luZm8NCj4+ICAqIGhhcyB0
aGUgbWF4X2dyYW50X2ZyYW1lcyBhbmQgbWF4X21hcHRyYWNrX2ZyYW1lcyBmaWVsZHMuDQo+PiBk
aWZmIC0tZ2l0IGEvdG9vbHMvbGlicy9saWdodC9saWJ4bF9hcm0uYyBiL3Rvb2xzL2xpYnMvbGln
aHQvbGlieGxfYXJtLmMNCj4+IGluZGV4IGUzMTQwYTZlMDAuLjUyZjFkZGNlNDggMTAwNjQ0DQo+
PiAtLS0gYS90b29scy9saWJzL2xpZ2h0L2xpYnhsX2FybS5jDQo+PiArKysgYi90b29scy9saWJz
L2xpZ2h0L2xpYnhsX2FybS5jDQo+PiBAQCAtMjY5LDYgKzI2OSw1OCBAQCBzdGF0aWMgaW50IGZk
dF9wcm9wZXJ0eV9yZWdzKGxpYnhsX19nYyAqZ2MsIHZvaWQgKmZkdCwNCj4+ICAgICByZXR1cm4g
ZmR0X3Byb3BlcnR5KGZkdCwgInJlZyIsIHJlZ3MsIHNpemVvZihyZWdzKSk7DQo+PiB9DQo+PiAN
Cj4+ICtzdGF0aWMgaW50IGZkdF9wcm9wZXJ0eV92YWx1ZXMobGlieGxfX2djICpnYywgdm9pZCAq
ZmR0LA0KPj4gKyAgICAgICAgY29uc3QgY2hhciAqbmFtZSwgdW5zaWduZWQgbnVtX2NlbGxzLCAu
Li4pDQo+PiArew0KPj4gKyAgICB1aW50MzJfdCBwcm9wW251bV9jZWxsc107DQo+PiArICAgIGJl
MzIgKmNlbGxzID0gJnByb3BbMF07DQo+PiArICAgIGludCBpOw0KPj4gKyAgICB2YV9saXN0IGFw
Ow0KPj4gKyAgICB1aW50MzJfdCBhcmc7DQo+PiArDQo+PiArICAgIHZhX3N0YXJ0KGFwLCBudW1f
Y2VsbHMpOw0KPj4gKyAgICBmb3IgKGkgPSAwIDsgaSA8IG51bV9jZWxsczsgaSsrKSB7DQo+PiAr
ICAgICAgICBhcmcgPSB2YV9hcmcoYXAsIHVpbnQzMl90KTsNCj4+ICsgICAgICAgIHNldF9jZWxs
KCZjZWxscywgMSwgYXJnKTsNCj4+ICsgICAgfQ0KPj4gKyAgICB2YV9lbmQoYXApOw0KPj4gKw0K
Pj4gKyAgICByZXR1cm4gZmR0X3Byb3BlcnR5KGZkdCwgbmFtZSwgcHJvcCwgc2l6ZW9mKHByb3Ap
KTsNCj4+ICt9DQo+PiArDQo+PiArc3RhdGljIGludCBmZHRfcHJvcGVydHlfdnBjaV9yYW5nZXMo
bGlieGxfX2djICpnYywgdm9pZCAqZmR0LA0KPj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgIHVuc2lnbmVkIGFkZHJfY2VsbHMsDQo+PiArICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgdW5zaWduZWQgc2l6ZV9jZWxscywNCj4+ICsgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICB1bnNpZ25lZCBudW1fcmVncywgLi4uKQ0KPj4gK3sNCj4+ICsg
ICAgdWludDMyX3QgcmVnc1tudW1fcmVncyooKGFkZHJfY2VsbHMqMikrc2l6ZV9jZWxscysxKV07
DQo+PiArICAgIGJlMzIgKmNlbGxzID0gJnJlZ3NbMF07DQo+PiArICAgIGludCBpOw0KPj4gKyAg
ICB2YV9saXN0IGFwOw0KPj4gKyAgICB1aW50NjRfdCBhcmc7DQo+PiArDQo+PiArICAgIHZhX3N0
YXJ0KGFwLCBudW1fcmVncyk7DQo+PiArICAgIGZvciAoaSA9IDAgOyBpIDwgbnVtX3JlZ3M7IGkr
Kykgew0KPj4gKyAgICAgICAgLyogU2V0IHRoZSBtZW1vcnkgYml0IGZpZWxkICovDQo+PiArICAg
ICAgICBhcmcgPSB2YV9hcmcoYXAsIHVpbnQzMl90KTsNCj4+ICsgICAgICAgIHNldF9jZWxsKCZj
ZWxscywgMSwgYXJnKTsNCj4+ICsNCj4+ICsgICAgICAgIC8qIFNldCB0aGUgdnBjaSBidXMgYWRk
cmVzcyAqLw0KPj4gKyAgICAgICAgYXJnID0gYWRkcl9jZWxscyA/IHZhX2FyZyhhcCwgdWludDY0
X3QpIDogMDsNCj4+ICsgICAgICAgIHNldF9jZWxsKCZjZWxscywgYWRkcl9jZWxscyAsIGFyZyk7
DQo+PiArDQo+PiArICAgICAgICAvKiBTZXQgdGhlIGNwdSBidXMgYWRkcmVzcyB3aGVyZSB2cGNp
IGFkZHJlc3MgaXMgbWFwcGVkICovDQo+PiArICAgICAgICBzZXRfY2VsbCgmY2VsbHMsIGFkZHJf
Y2VsbHMsIGFyZyk7DQo+PiArDQo+PiArICAgICAgICAvKiBTZXQgdGhlIHZwY2kgc2l6ZSByZXF1
ZXN0ZWQgKi8NCj4+ICsgICAgICAgIGFyZyA9IHNpemVfY2VsbHMgPyB2YV9hcmcoYXAsIHVpbnQ2
NF90KSA6IDA7DQo+PiArICAgICAgICBzZXRfY2VsbCgmY2VsbHMsIHNpemVfY2VsbHMsIGFyZyk7
DQo+PiArICAgIH0NCj4+ICsgICAgdmFfZW5kKGFwKTsNCj4+ICsNCj4+ICsgICAgcmV0dXJuIGZk
dF9wcm9wZXJ0eShmZHQsICJyYW5nZXMiLCByZWdzLCBzaXplb2YocmVncykpOw0KPj4gK30NCj4+
ICsNCj4+IHN0YXRpYyBpbnQgbWFrZV9yb290X3Byb3BlcnRpZXMobGlieGxfX2djICpnYywNCj4+
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgY29uc3QgbGlieGxfdmVyc2lvbl9pbmZv
ICp2ZXJzLA0KPj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB2b2lkICpmZHQpDQo+
PiBAQCAtNjY4LDYgKzcyMCw1MyBAQCBzdGF0aWMgaW50IG1ha2VfdnBsMDExX3VhcnRfbm9kZShs
aWJ4bF9fZ2MgKmdjLCB2b2lkICpmZHQsDQo+PiAgICAgcmV0dXJuIDA7DQo+PiB9DQo+PiANCj4+
ICtzdGF0aWMgaW50IG1ha2VfdnBjaV9ub2RlKGxpYnhsX19nYyAqZ2MsIHZvaWQgKmZkdCwNCj4+
ICsgICAgICAgIGNvbnN0IHN0cnVjdCBhcmNoX2luZm8gKmFpbmZvLA0KPj4gKyAgICAgICAgc3Ry
dWN0IHhjX2RvbV9pbWFnZSAqZG9tKQ0KPj4gK3sNCj4+ICsgICAgaW50IHJlczsNCj4+ICsgICAg
Y29uc3QgdWludDY0X3QgdnBjaV9lY2FtX2Jhc2UgPSBHVUVTVF9WUENJX0VDQU1fQkFTRTsNCj4+
ICsgICAgY29uc3QgdWludDY0X3QgdnBjaV9lY2FtX3NpemUgPSBHVUVTVF9WUENJX0VDQU1fU0la
RTsNCj4+ICsgICAgY29uc3QgY2hhciAqbmFtZSA9IEdDU1BSSU5URigicGNpZUAlIlBSSXg2NCwg
dnBjaV9lY2FtX2Jhc2UpOw0KPj4gKw0KPj4gKyAgICByZXMgPSBmZHRfYmVnaW5fbm9kZShmZHQs
IG5hbWUpOw0KPj4gKyAgICBpZiAocmVzKSByZXR1cm4gcmVzOw0KPj4gKw0KPj4gKyAgICByZXMg
PSBmZHRfcHJvcGVydHlfY29tcGF0KGdjLCBmZHQsIDEsICJwY2ktaG9zdC1lY2FtLWdlbmVyaWMi
KTsNCj4+ICsgICAgaWYgKHJlcykgcmV0dXJuIHJlczsNCj4+ICsNCj4+ICsgICAgcmVzID0gZmR0
X3Byb3BlcnR5X3N0cmluZyhmZHQsICJkZXZpY2VfdHlwZSIsICJwY2kiKTsNCj4+ICsgICAgaWYg
KHJlcykgcmV0dXJuIHJlczsNCj4+ICsNCj4+ICsgICAgcmVzID0gZmR0X3Byb3BlcnR5X3JlZ3Mo
Z2MsIGZkdCwgR1VFU1RfUk9PVF9BRERSRVNTX0NFTExTLA0KPj4gKyAgICAgICAgICAgIEdVRVNU
X1JPT1RfU0laRV9DRUxMUywgMSwgdnBjaV9lY2FtX2Jhc2UsIHZwY2lfZWNhbV9zaXplKTsNCj4+
ICsgICAgaWYgKHJlcykgcmV0dXJuIHJlczsNCj4+ICsNCj4+ICsgICAgcmVzID0gZmR0X3Byb3Bl
cnR5X3ZhbHVlcyhnYywgZmR0LCAiYnVzLXJhbmdlIiwgMiwgMCwgMjU1KTsNCj4+ICsgICAgaWYg
KHJlcykgcmV0dXJuIHJlczsNCj4+ICsNCj4+ICsgICAgcmVzID0gZmR0X3Byb3BlcnR5X2NlbGwo
ZmR0LCAiI2FkZHJlc3MtY2VsbHMiLCAzKTsNCj4+ICsgICAgaWYgKHJlcykgcmV0dXJuIHJlczsN
Cj4+ICsNCj4+ICsgICAgcmVzID0gZmR0X3Byb3BlcnR5X2NlbGwoZmR0LCAiI3NpemUtY2VsbHMi
LCAyKTsNCj4+ICsgICAgaWYgKHJlcykgcmV0dXJuIHJlczsNCj4+ICsNCj4+ICsgICAgcmVzID0g
ZmR0X3Byb3BlcnR5X3N0cmluZyhmZHQsICJzdGF0dXMiLCAib2theSIpOw0KPj4gKyAgICBpZiAo
cmVzKSByZXR1cm4gcmVzOw0KPj4gKw0KPj4gKyAgICByZXMgPSBmZHRfcHJvcGVydHlfdnBjaV9y
YW5nZXMoZ2MsIGZkdCwgR1VFU1RfUk9PVF9BRERSRVNTX0NFTExTLA0KPj4gKyAgICAgICAgR1VF
U1RfUk9PVF9TSVpFX0NFTExTLCAyLA0KPj4gKyAgICAgICAgR1VFU1RfVlBDSV9BRERSX1RZUEVf
TUVNLCBHVUVTVF9WUENJX01FTV9BRERSLCBHVUVTVF9WUENJX01FTV9TSVpFLA0KPj4gKyAgICAg
ICAgR1VFU1RfVlBDSV9BRERSX1RZUEVfUFJFRkVUQ0hfTUVNLCBHVUVTVF9WUENJX1BSRUZFVENI
X01FTV9BRERSLA0KPj4gKyAgICAgICAgR1VFU1RfVlBDSV9QUkVGRVRDSF9NRU1fU0laRSk7DQo+
PiArICAgIGlmIChyZXMpIHJldHVybiByZXM7DQo+PiArDQo+PiArICAgIHJlcyA9IGZkdF9lbmRf
bm9kZShmZHQpOw0KPj4gKyAgICBpZiAocmVzKSByZXR1cm4gcmVzOw0KPj4gKw0KPj4gKyAgICBy
ZXR1cm4gMDsNCj4+ICt9DQo+PiArDQo+PiBzdGF0aWMgY29uc3Qgc3RydWN0IGFyY2hfaW5mbyAq
Z2V0X2FyY2hfaW5mbyhsaWJ4bF9fZ2MgKmdjLA0KPj4gICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgY29uc3Qgc3RydWN0IHhjX2RvbV9pbWFnZSAqZG9tKQ0KPj4g
ew0KPj4gQEAgLTk3MSw2ICsxMDcwLDkgQEAgbmV4dF9yZXNpemU6DQo+PiAgICAgICAgIGlmIChp
bmZvLT50ZWUgPT0gTElCWExfVEVFX1RZUEVfT1BURUUpDQo+PiAgICAgICAgICAgICBGRFQoIG1h
a2Vfb3B0ZWVfbm9kZShnYywgZmR0KSApOw0KPj4gDQo+PiArICAgICAgICBpZiAobGlieGxfZGVm
Ym9vbF92YWwoaW5mby0+YXJjaF9hcm0udnBjaSkpDQo+PiArICAgICAgICAgICAgRkRUKCBtYWtl
X3ZwY2lfbm9kZShnYywgZmR0LCBhaW5mbywgZG9tKSApOw0KPj4gKw0KPj4gICAgICAgICBpZiAo
cGZkdCkNCj4+ICAgICAgICAgICAgIEZEVCggY29weV9wYXJ0aWFsX2ZkdChnYywgZmR0LCBwZmR0
KSApOw0KPj4gDQo+PiBAQCAtMTE4OSw2ICsxMjkxLDkgQEAgdm9pZCBsaWJ4bF9fYXJjaF9kb21h
aW5fYnVpbGRfaW5mb19zZXRkZWZhdWx0KGxpYnhsX19nYyAqZ2MsDQo+PiAgICAgLyogQUNQSSBp
cyBkaXNhYmxlZCBieSBkZWZhdWx0ICovDQo+PiAgICAgbGlieGxfZGVmYm9vbF9zZXRkZWZhdWx0
KCZiX2luZm8tPmFjcGksIGZhbHNlKTsNCj4+IA0KPj4gKyAgICAvKiBWUENJIGlzIGRpc2FibGVk
IGJ5IGRlZmF1bHQgKi8NCj4+ICsgICAgbGlieGxfZGVmYm9vbF9zZXRkZWZhdWx0KCZiX2luZm8t
PmFyY2hfYXJtLnZwY2ksIGZhbHNlKTsNCj4+ICsNCj4+ICAgICBpZiAoYl9pbmZvLT50eXBlICE9
IExJQlhMX0RPTUFJTl9UWVBFX1BWKQ0KPj4gICAgICAgICByZXR1cm47DQo+PiANCj4+IGRpZmYg
LS1naXQgYS90b29scy9saWJzL2xpZ2h0L2xpYnhsX2NyZWF0ZS5jIGIvdG9vbHMvbGlicy9saWdo
dC9saWJ4bF9jcmVhdGUuYw0KPj4gaW5kZXggZTM1NmIyMTA2ZC4uOTQwODUyNjAzNiAxMDA2NDQN
Cj4+IC0tLSBhL3Rvb2xzL2xpYnMvbGlnaHQvbGlieGxfY3JlYXRlLmMNCj4+ICsrKyBiL3Rvb2xz
L2xpYnMvbGlnaHQvbGlieGxfY3JlYXRlLmMNCj4+IEBAIC02MzIsNiArNjMyLDE1IEBAIGludCBs
aWJ4bF9fZG9tYWluX21ha2UobGlieGxfX2djICpnYywgbGlieGxfZG9tYWluX2NvbmZpZyAqZF9j
b25maWcsDQo+PiAgICAgICAgIGlmIChpbmZvLT5wYXNzdGhyb3VnaCA9PSBMSUJYTF9QQVNTVEhS
T1VHSF9TWU5DX1BUKQ0KPj4gICAgICAgICAgICAgY3JlYXRlLmlvbW11X29wdHMgfD0gWEVOX0RP
TUNUTF9JT01NVV9ub19zaGFyZXB0Ow0KPj4gDQo+PiArI2lmIGRlZmluZWQoX19hcm1fXykgfHwg
ZGVmaW5lZChfX2FhcmNoNjRfXykNCj4+ICsgICAgICAgIC8qDQo+PiArICAgICAgICAgKiBFbmFi
bGUgVlBDSSBzdXBwb3J0IGZvciBBUk0uIFZQQ0kgc3VwcG9ydCBmb3IgRE9NVSBndWVzdCBpcyBu
b3QNCj4+ICsgICAgICAgICAqIHN1cHBvcnRlZCBmb3IgeDg2Lg0KPj4gKyAgICAgICAgICovDQo+
PiArICAgICAgICBpZiAoIGxpYnhsX2RlZmJvb2xfdmFsKGJfaW5mby0+YXJjaF9hcm0udnBjaSkg
KQ0KPj4gKyAgICAgICAgICAgIGNyZWF0ZS5mbGFncyB8PSBYRU5fRE9NQ1RMX0NERl92cGNpOw0K
Pj4gKyNlbmRpZg0KPiANCj4gSSBkb24ndCB0aGluayB0aGUgI2lmZGVmIGlzIHJlcXVpcmVkLCBp
cyBpdD8gVGhlIGNoZWNrIGlzIGJhc2VkIG9uDQo+IGJfaW5mby0+YXJjaF9hcm0udnBjaSB3aGlj
aCBpcyBhbHJlYWR5IEFSTS1zcGVjaWZpYyBhbmQgY291bGRuJ3QgYmUNCj4gZW5hYmxlZCBvbiBY
ODYuIFdlIGhhdmUgYW5vdGhlciBzaW1pbGFyIGNoZWNrIGluIGxpYnhsX2NyZWF0ZS5jIGZvcg0K
PiBkX2NvbmZpZy0+Yl9pbmZvLmFyY2hfYXJtLnZ1YXJ0IHdpdGhvdXQgI2lmZGVmLg0KPiANCj4g
TXkgc3VnZ2VzdGlvbiB3b3VsZCBiZSB0byBqdXN0IGtlZXAgdGhlIGluLWNvZGUgY29tbWVudCwg
YnV0IGxlYXZlIHRoZQ0KPiBsaWJ4bF9kZWZib29sX3ZhbCBjaGVjayBhcyBpdCB3YXMgYmVmb3Jl
Lg0KPiANCg0KSSBhbHNvIHRob3VnaHQgdGhlIHNhbWUgd2F5IHRoYXQgImJfaW5mby0+YXJjaF9h
cm0udnBjaXwiIGlzIGFybS1zcGVjaWZpYyBidXQgc29tZWhvdyBpdCBpcyBnZXR0aW5nIGVuYWJs
ZWQgZm9yIHg4NiANCndoZW4gd2UgYXNzaWduIHRoZSBQQ0kgZGV2aWNlIHRvIERPTVUgZ3Vlc3Rz
IG9uIHg4NiBQViBET00wIG9uY2UgSSByZW1vdmUgdGhlICNpZmRlZiBmb3IgYmVsb3cgY29kZS4N
Cg0KI2lmIGRlZmluZWQoX19hcm1fXykgfHwgZGVmaW5lZChfX2FhcmNoNjRfXykgICAgICAgICAg
ICAgICAgICAgDQogICAgLyogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICANCiAg
ICAgKiBFbmFibGUgVlBDSSBzdXBwb3J0IGZvciBBUk0uIFZQQ0kgc3VwcG9ydCBmb3IgRE9NVSBn
dWVzdHMgaXMgbm90ICAgIA0KICAgICAqIHN1cHBvcnRlZCBmb3IgeDg2LiAgICAgICAgICAgICAg
ICAgICAgICAgICAgDQogICAgICovICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAN
CiAgICBpZiAoZF9jb25maWctPm51bV9wY2lkZXZzKSAgICAgICAgICAgICAgICAgICAgICAgIA0K
ICAgICAgbGlieGxfZGVmYm9vbF9zZXQoJmJfaW5mby0+YXJjaF9hcm0udnBjaSwgdHJ1ZSk7ICAg
ICAgICAgICANCiNlbmRpZiANCg0KRXJyb3Igb24geDg2Og0KUGFyc2luZyBjb25maWcgZnJvbSBn
dWVzdC5jZmcNCihYRU4pIGRvbWFpbi5jOjY2NzogdlBDSSBjYW5ub3QgYmUgZW5hYmxlZCB5ZXQN
CmxpYnhsOiBlcnJvcjogbGlieGxfY3JlYXRlLmM6NjgzOmxpYnhsX19kb21haW5fbWFrZTogZG9t
YWluIGNyZWF0aW9uIGZhaWw6IEludmFsaWQgYXJndW1lbnQNCmxpYnhsOiBlcnJvcjogbGlieGxf
Y3JlYXRlLmM6MTIzNzppbml0aWF0ZV9kb21haW5fY3JlYXRlOiBjYW5ub3QgbWFrZSBkb21haW46
IC0zDQoNCk9uZSBzb2x1dGlvbiBpcyB3ZSBjYW4gcmVtb3ZlIHRoZSAjaWZkZWYgZnJvbSB0aGUg
YmVsb3cgY29kZSB3aGVuIGNoZWNraW5nIGlmIHZwY2kgaXMgZW5hYmxlZOKApg0KI2lmIGRlZmlu
ZWQoX19hcm1fXykgfHwgZGVmaW5lZChfX2FhcmNoNjRfXykgICAgICAgICAgICAgICAgICAgDQog
ICAgLyogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICANCiAgICAgKiBFbmFibGUg
VlBDSSBzdXBwb3J0IGZvciBBUk0uIFZQQ0kgc3VwcG9ydCBmb3IgRE9NVSBndWVzdHMgaXMgbm90
ICAgIA0KICAgICAqIHN1cHBvcnRlZCBmb3IgeDg2LiAgICAgICAgICAgICAgICAgICAgICAgICAg
DQogICAgICovICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICANCiAgICBpZiAoIGxp
YnhsX2RlZmJvb2xfdmFsKGJfaW5mby0+YXJjaF9hcm0udnBjaSkgKSAgICAgICAgICAgICANCiAg
ICAgIGNyZWF0ZS5mbGFncyB8PSBYRU5fRE9NQ1RMX0NERl92cGNpOyAgICAgICAgICAgICAgICAg
DQojZW5kaWYNCg0KLi5idXQgbm90IGZyb20gaGVyZSB3aGVuIHNldHRpbmcgdGhlIGFyY2hfYXJt
LnZwY2kgd2hlbiB3ZSBhc3NpZ24gdGhlIFBDSSBkZXZpY2UgdG8gdGhlIGd1ZXN0Lg0KDQojaWYg
ZGVmaW5lZChfX2FybV9fKSB8fCBkZWZpbmVkKF9fYWFyY2g2NF9fKSAgICAgICAgICAgICAgICAg
IA0KICAgIC8qICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgDQogICAgICogRW5h
YmxlIFZQQ0kgc3VwcG9ydCBmb3IgQVJNLiBWUENJIHN1cHBvcnQgZm9yIERPTVUgZ3Vlc3RzIGlz
IG5vdCAgICANCiAgICAgKiBzdXBwb3J0ZWQgZm9yIHg4Ni4gICAgICAgICAgICAgICAgICAgICAg
ICAgIA0KICAgICAqLyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgDQogICAgaWYg
KGRfY29uZmlnLT5udW1fcGNpZGV2cykgICAgICAgICAgICAgICAgICAgICAgICANCiAgICAgIGxp
YnhsX2RlZmJvb2xfc2V0KCZiX2luZm8tPmFyY2hfYXJtLnZwY2ksIHRydWUpOyAgICAgICAgICAg
DQojZW5kaWYgDQoNCg0KQWxzbyBpZiBJIHJlbW92ZSAjaWZkZWYgYXMgbWVudGlvbiBhYm92ZSBJ
IG5lZWQgdG8gbW92ZSB0aGUgDQogICAgICAgImxpYnhsX2RlZmJvb2xfc2V0ZGVmYXVsdCgmYl9p
bmZvLT5hcmNoX2FybS52cGNpLCBmYWxzZSk7IOKAnCANCmZyb20gDQogICAgICAgbGlieGxfX2Fy
Y2hfZG9tYWluX2J1aWxkX2luZm9fc2V0ZGVmYXVsdCguLikgDQp0byBjb21tb24gY29kZSANCiAg
ICAgICBsaWJ4bF9fZG9tYWluX2J1aWxkX2luZm9fc2V0ZGVmYXVsdCguLikgdG8gYXZvaWQgZXJy
b3Igb24geDg2Lg0KDQpFcnJvciBvbiB4ODY6DQpyb290QGRvbTA6fiMgeGwgY3JlYXRlIC1jIGd1
ZXN0LmNmZw0KUGFyc2luZyBjb25maWcgZnJvbSBndWVzdC5jZmcNCnhsOiBsaWJ4bC5jOjMzNzog
bGlieGxfZGVmYm9vbF92YWw6IEFzc2VydGlvbiBgIWxpYnhsX2RlZmJvb2xfaXNfZGVmYXVsdChk
YiknIGZhaWxlZC4NCkFib3J0ZWQNCg0KPiANCj4+ICsNCj4+ICAgICAgICAgLyogVWx0aW1hdGVs
eSwgaGFuZGxlIGlzIGFuIGFycmF5IG9mIDE2IHVpbnQ4X3QsIHNhbWUgYXMgdXVpZCAqLw0KPj4g
ICAgICAgICBsaWJ4bF91dWlkX2NvcHkoY3R4LCAobGlieGxfdXVpZCAqKSZjcmVhdGUuaGFuZGxl
LCAmaW5mby0+dXVpZCk7DQo+PiANCj4+IGRpZmYgLS1naXQgYS90b29scy9saWJzL2xpZ2h0L2xp
YnhsX3R5cGVzLmlkbCBiL3Rvb2xzL2xpYnMvbGlnaHQvbGlieGxfdHlwZXMuaWRsDQo+PiBpbmRl
eCAzZjlmZmY2NTNhLi43OGIxZGRmMGI4IDEwMDY0NA0KPj4gLS0tIGEvdG9vbHMvbGlicy9saWdo
dC9saWJ4bF90eXBlcy5pZGwNCj4+ICsrKyBiL3Rvb2xzL2xpYnMvbGlnaHQvbGlieGxfdHlwZXMu
aWRsDQo+PiBAQCAtNjQ0LDYgKzY0NCw3IEBAIGxpYnhsX2RvbWFpbl9idWlsZF9pbmZvID0gU3Ry
dWN0KCJkb21haW5fYnVpbGRfaW5mbyIsWw0KPj4gDQo+PiAgICAgKCJhcmNoX2FybSIsIFN0cnVj
dChOb25lLCBbKCJnaWNfdmVyc2lvbiIsIGxpYnhsX2dpY192ZXJzaW9uKSwNCj4+ICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAoInZ1YXJ0IiwgbGlieGxfdnVhcnRfdHlwZSksDQo+PiAr
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICgidnBjaSIsIGxpYnhsX2RlZmJvb2wpLA0K
Pj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgXSkpLA0KPj4gICAgICgiYXJjaF94ODYi
LCBTdHJ1Y3QoTm9uZSwgWygibXNyX3JlbGF4ZWQiLCBsaWJ4bF9kZWZib29sKSwNCj4+ICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgIF0pKSwNCj4+IGRpZmYgLS1naXQgYS90b29scy94bC94
bF9wYXJzZS5jIGIvdG9vbHMveGwveGxfcGFyc2UuYw0KPj4gaW5kZXggMTdkZGRiNGNkNS4uNTc2
YWY2N2RhYSAxMDA2NDQNCj4+IC0tLSBhL3Rvb2xzL3hsL3hsX3BhcnNlLmMNCj4+ICsrKyBiL3Rv
b2xzL3hsL3hsX3BhcnNlLmMNCj4+IEBAIC0xNDk3LDYgKzE0OTcsMTQgQEAgdm9pZCBwYXJzZV9j
b25maWdfZGF0YShjb25zdCBjaGFyICpjb25maWdfc291cmNlLA0KPj4gICAgICAgICB9DQo+PiAg
ICAgICAgIGlmIChkX2NvbmZpZy0+bnVtX3BjaWRldnMgJiYgY19pbmZvLT50eXBlID09IExJQlhM
X0RPTUFJTl9UWVBFX1BWKQ0KPj4gICAgICAgICAgICAgbGlieGxfZGVmYm9vbF9zZXQoJmJfaW5m
by0+dS5wdi5lODIwX2hvc3QsIHRydWUpOw0KPj4gKyNpZiBkZWZpbmVkKF9fYXJtX18pIHx8IGRl
ZmluZWQoX19hYXJjaDY0X18pDQo+PiArICAgICAgICAvKg0KPj4gKyAgICAgICAgICogRW5hYmxl
IFZQQ0kgc3VwcG9ydCBmb3IgQVJNLiBWUENJIHN1cHBvcnQgZm9yIERPTVUgZ3Vlc3QgaXMgbm90
DQo+PiArICAgICAgICAgKiBzdXBwb3J0ZWQgZm9yIHg4Ni4NCj4+ICsgICAgICAgICAqLw0KPj4g
KyAgICAgICAgaWYgKGRfY29uZmlnLT5udW1fcGNpZGV2cykNCj4+ICsgICAgICAgICAgICBsaWJ4
bF9kZWZib29sX3NldCgmYl9pbmZvLT5hcmNoX2FybS52cGNpLCB0cnVlKTsNCj4+ICsjZW5kaWYN
Cj4+ICAgICB9DQo+PiANCj4+ICAgICBpZiAoIXhsdV9jZmdfZ2V0X2xpc3QgKGNvbmZpZywgImR0
ZGV2IiwgJmR0ZGV2cywgMCwgMCkpIHsNCj4+IGRpZmYgLS1naXQgYS94ZW4vaW5jbHVkZS9wdWJs
aWMvYXJjaC1hcm0uaCBiL3hlbi9pbmNsdWRlL3B1YmxpYy9hcmNoLWFybS5oDQo+PiBpbmRleCA0
NGJlMzM3ZGVjLi40NWFhYzVkMThmIDEwMDY0NA0KPj4gLS0tIGEveGVuL2luY2x1ZGUvcHVibGlj
L2FyY2gtYXJtLmgNCj4+ICsrKyBiL3hlbi9pbmNsdWRlL3B1YmxpYy9hcmNoLWFybS5oDQo+PiBA
QCAtNDMzLDYgKzQzMywxMSBAQCB0eXBlZGVmIHVpbnQ2NF90IHhlbl9jYWxsYmFja190Ow0KPj4g
I2RlZmluZSBHVUVTVF9QTDAxMV9CQVNFICAgIHhlbl9ta191bGxvbmcoMHgyMjAwMDAwMCkNCj4+
ICNkZWZpbmUgR1VFU1RfUEwwMTFfU0laRSAgICB4ZW5fbWtfdWxsb25nKDB4MDAwMDEwMDApDQo+
PiANCj4+ICsvKiBHdWVzdCBQQ0ktUENJZSBtZW1vcnkgc3BhY2Ugd2hlcmUgY29uZmlnIHNwYWNl
IGFuZCBCQVIgd2lsbCBiZSBhdmFpbGFibGUuKi8NCj4+ICsjZGVmaW5lIEdVRVNUX1ZQQ0lfQURE
Ul9UWVBFX01FTSAgICAgICAgICAgIHhlbl9ta191bGxvbmcoMHgwMjAwMDAwMCkNCj4+ICsjZGVm
aW5lIEdVRVNUX1ZQQ0lfTUVNX0FERFIgICAgICAgICAgICAgICAgIHhlbl9ta191bGxvbmcoMHgy
MzAwMDAwMCkNCj4+ICsjZGVmaW5lIEdVRVNUX1ZQQ0lfTUVNX1NJWkUgICAgICAgICAgICAgICAg
IHhlbl9ta191bGxvbmcoMHgxMDAwMDAwMCkNCj4+ICsNCj4+IC8qDQo+PiAgKiAxNk1CID09IDQw
OTYgcGFnZXMgcmVzZXJ2ZWQgZm9yIGd1ZXN0IHRvIHVzZSBhcyBhIHJlZ2lvbiB0byBtYXAgaXRz
DQo+PiAgKiBncmFudCB0YWJsZSBpbi4NCj4+IEBAIC00NDgsNiArNDUzLDExIEBAIHR5cGVkZWYg
dWludDY0X3QgeGVuX2NhbGxiYWNrX3Q7DQo+PiAjZGVmaW5lIEdVRVNUX1JBTTBfQkFTRSAgIHhl
bl9ta191bGxvbmcoMHg0MDAwMDAwMCkgLyogM0dCIG9mIGxvdyBSQU0gQCAxR0IgKi8NCj4+ICNk
ZWZpbmUgR1VFU1RfUkFNMF9TSVpFICAgeGVuX21rX3VsbG9uZygweGMwMDAwMDAwKQ0KPj4gDQo+
PiArLyogNEdCIEAgNEdCIFByZWZldGNoIE1lbW9yeSBmb3IgVlBDSSAqLw0KPj4gKyNkZWZpbmUg
R1VFU1RfVlBDSV9BRERSX1RZUEVfUFJFRkVUQ0hfTUVNICAgeGVuX21rX3VsbG9uZygweDQyMDAw
MDAwKQ0KPj4gKyNkZWZpbmUgR1VFU1RfVlBDSV9QUkVGRVRDSF9NRU1fQUREUiAgICAgICAgeGVu
X21rX3VsbG9uZygweDEwMDAwMDAwMCkNCj4+ICsjZGVmaW5lIEdVRVNUX1ZQQ0lfUFJFRkVUQ0hf
TUVNX1NJWkUgICAgICAgIHhlbl9ta191bGxvbmcoMHgxMDAwMDAwMDApDQo+PiArDQo+PiAjZGVm
aW5lIEdVRVNUX1JBTTFfQkFTRSAgIHhlbl9ta191bGxvbmcoMHgwMjAwMDAwMDAwKSAvKiAxMDE2
R0Igb2YgUkFNIEAgOEdCICovDQo+PiAjZGVmaW5lIEdVRVNUX1JBTTFfU0laRSAgIHhlbl9ta191
bGxvbmcoMHhmZTAwMDAwMDAwKQ0KPj4gDQo+PiAtLSANCj4+IDIuMjUuMQ0KDQo=


From xen-devel-bounces@lists.xenproject.org Tue Oct 05 10:46:19 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Oct 2021 10:46:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.202140.356828 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXhxb-0004Gh-Pm; Tue, 05 Oct 2021 10:46:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 202140.356828; Tue, 05 Oct 2021 10:46:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXhxb-0004Ga-Mk; Tue, 05 Oct 2021 10:46:11 +0000
Received: by outflank-mailman (input) for mailman id 202140;
 Tue, 05 Oct 2021 10:46:09 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mXhxZ-0004GQ-Tc; Tue, 05 Oct 2021 10:46:09 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mXhxZ-0001WY-NS; Tue, 05 Oct 2021 10:46:09 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mXhxZ-0005lF-Cr; Tue, 05 Oct 2021 10:46:09 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mXhxZ-0007Bl-CL; Tue, 05 Oct 2021 10:46:09 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=4GB3o5VFPwgRdjAmuVQPN4UyxOew/Q20kDbuTlMTMEg=; b=3b0mqtM/RFYHqK6BBRpqAH9nEb
	0iGWRIrcouIJDvXB3vhRqwCUDM+RmR5tPM/IhjSXnH34TUhwPaLDiw7zr308NeBEN9rrQ/AhUMOTh
	NaK7xDyfmVCC3vNSKP98LAdcq5qpltfj8u6iAR8GqDSVjKR8uauEOpTnRhGbPlmhZpZs=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165348-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 165348: regressions - FAIL
X-Osstest-Failures:
    linux-linus:test-armhf-armhf-xl-credit1:guest-start/debian.repeat:fail:regression
    linux-linus:test-amd64-amd64-xl-credit2:guest-start/debian.repeat:fail:heisenbug
    linux-linus:test-amd64-amd64-freebsd11-amd64:guest-localmigrate/x10:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=9e1ff307c779ce1f0f810c7ecce3d95bbae40896
X-Osstest-Versions-That:
    linux=deacdb3e3979979016fcd0ffd518c320a62ad166
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 05 Oct 2021 10:46:09 +0000

flight 165348 linux-linus real [real]
flight 165376 linux-linus real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/165348/
http://logs.test-lab.xenproject.org/osstest/logs/165376/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-armhf-armhf-xl-credit1 18 guest-start/debian.repeat fail REGR. vs. 152332

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-xl-credit2 22 guest-start/debian.repeat fail pass in 165376-retest

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-freebsd11-amd64 19 guest-localmigrate/x10 fail baseline untested
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail baseline untested
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 152332
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 152332
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 152332
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 152332
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 152332
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152332
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 152332
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 linux                9e1ff307c779ce1f0f810c7ecce3d95bbae40896
baseline version:
 linux                deacdb3e3979979016fcd0ffd518c320a62ad166

Last test of basis   152332  2020-07-31 19:41:23 Z  430 days
Failing since        152366  2020-08-01 20:49:34 Z  429 days  742 attempts
Testing same since   165348  2021-10-04 12:43:13 Z    0 days    1 attempts

------------------------------------------------------------
7366 people touched revisions under test,
not listing them all

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             fail    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  fail    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 2281308 lines long.)


From xen-devel-bounces@lists.xenproject.org Tue Oct 05 11:12:13 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Oct 2021 11:12:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.202150.356842 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXiMb-0007U8-Ur; Tue, 05 Oct 2021 11:12:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 202150.356842; Tue, 05 Oct 2021 11:12:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXiMb-0007U1-Rq; Tue, 05 Oct 2021 11:12:01 +0000
Received: by outflank-mailman (input) for mailman id 202150;
 Tue, 05 Oct 2021 11:12:01 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=vm5x=OZ=citrix.com=Andrew.Cooper3@srs-us1.protection.inumbo.net>)
 id 1mXiMa-0007Tv-UG
 for xen-devel@lists.xenproject.org; Tue, 05 Oct 2021 11:12:00 +0000
Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id df4361e4-6b74-4007-8e6a-5e68683aa515;
 Tue, 05 Oct 2021 11:11:59 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: df4361e4-6b74-4007-8e6a-5e68683aa515
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1633432319;
  h=from:to:cc:subject:date:message-id:mime-version:
   content-transfer-encoding;
  bh=1ordPe992Mc+PkRdN/4HpjM69JM23Rxqyx9enqhnBlc=;
  b=OQfxePaZxtJ2Kv5lrCUX9kQLv7nEknPqDwXUGqAIAJv+vfcn/9nNt4Bp
   I6G3OFcmdy4gj52Mj3G+pPJn7KqeY8zmbOUpDVNUB3VloF1yXHToStmj4
   aW8HgTK13T+dVRIGGZ8KHCRPS0MiJATA7T5RHnOJeJbjWBEcwuRTx8F7c
   s=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: k8WlLhmY8iWb48otd3aq/rQFEVuHkTnHMe/u+H/HBwAClrnvgmjzs4YN6jsaoHg4kS8TgdSi4v
 P3baCd8JHYPDTOrnuONaou9yNs1nQ8+QYRhFsb9dilvl8z5Qm1MAyLHXWDUCux26FCMjx8V5EJ
 wqzKul50eINfr6AFRrV8PTQJIMgt/hXVewtom0kKW+Iv9i79G98nDLuo+JfIc0rGyl8yxJoO9e
 xwuOFrX546Up+/bUZR/z0mKjEaOlFh6yHoyy7mCzvqMO4lFtaBYxV3o6bmeo1McNsiST8Gwbx6
 lp/ceUZErrd887sW/upqG7Q4
X-SBRS: 5.1
X-MesageID: 53961045
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:Uo+tp6CloQr2SBVW/+fkw5YqxClBgxIJ4kV8jS/XYbTApG4l0WAGx
 mYfDGHXOaqCZmCnfNFyPt/k9ElU65bXnN41QQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA
 xA2M4GYRCwMo/u1Si6FatANl1ElvU2zbue6WLOs1hxZH1c+EX550U87wobVv6Yz6TSHK1LV0
 T/Ni5W31G+Ng1aY5UpNtspvADs21BjDkGtwUm4WPJinj3eH/5UhN7oNJLnZEpfNatI88thW5
 Qr05OrREmvxp3/BAz4++1rxWhVirrX6ZWBihpfKMkQLb9crSiEai84G2PQghUh/mQmNw9ZYz
 u5xv7eAEyU3EfLUvOkXekwNe81+FfUuFL7vJHG+tYqYzlHccmuqyPJrZK00FdRGoKAtWzgIr
 KFGbmBWBvyAr7veLLaTY+9gnMk8auLsO5sSoCpIxjDFF/c2B5vERs0m4PcFh2Zu35gSQJ4yY
 eJDSSh2czjuQSF1AX03BsgyjMmUmHDgJmgwRFW9+vNsvjm7IBZK+KfpGMrYfJqNX8o9tmSyq
 3/C/m/5KgoHL9HZwj2Amlq8i+mKkS7lVYY6ELyj6uUskFCV3nYUChAdSR28u/bRt6Klc4sBc
 QpOoHNo9PVsshzwJjXgY/GmiGy4ukIactxrL+cR2Fuv1IWL+yKUDEFRG1atd+canMMxQDUr0
 HqAkNXoGSFjvdWpdJ6NyluHhWnsYHdEdAfucQdBHVNcvIWzyG0mpkiXJuuPBpJZmTEc9dvY7
 TeQsGAajqgfgNQH3qG2lbwsq2n3/cCYJuLZCx++Y45E0u+bTNL7D2BLwQKChRqlEGp/ZgLd1
 JTjs5LBhN3i9bnXyESwrBwlRdlFHcqtPjzGmkJIFJI87Tmr8HPLVdkOu2olexwxaZxaIGKBj
 KrvVeV5v8M70JyCN/8fXm5MI55ykfiI+SrNDJg4keaikrAuLVTarUmClGab3nz3kVhErE3ME
 czzTCpYNl5DUf4P5GPvH481iOZ3rghjlTK7bc2qlHyPjOvBDEN5vJ9YaTNimMhit/jayOgUm
 v4CX/a3J+J3CrajPXWHrdBJfTjn7xETXPjLliCeTcbbSiIOJY3rI6O5LWoJd9M3kqJLuP3P+
 33hCEZUxECm3S/MKBmQa2AlY7TqBM4toXU+NC0qHFCpx3l8Ptr/sPZBL8M6Les96ehu7f9oV
 P1ZKc+ONetCF2bc8DMHYJij8IE7LEa3hRiDNjaOaSQke8IyXBTA/9LpJ1O99CQHAietm9E5p
 rmsilHSTZYZHlwwB8fKcvO/iVi2uCFFyu51WkLJJPhVeVntr9c2e3Cg0KdvLphVexvZxzac2
 wKHOjsipLHA890v7d3EpaGYtIP1QeFwKVVXQjvA5rGsOCiEomf6md1cUPyFdCz2XX/v/Pnwf
 v1cyvzxPaFVnFtOtIYgQb9nwbhnuonqrr5eiA9lAG/KfxKgDbY5eiuK2sxGt6tswL5FuFTpB
 hLTq4cCYbjZatn4FFMxJRY+arXR3P4ZrTDe8PApLRio/yRw5reGDR1fMhTkZPax91ep3FfJG
 dschfM=
IronPort-HdrOrdr: A9a23:3rTZT6g+SCKf2fWInxCzpgVEWHBQXtYji2hC6mlwRA09TySZ//
 rBoB19726StN9xYgBFpTnuAsm9qB/nmaKdgrNhWItKPjOW21dARbsKheCJrgEIcxeOkNK1vp
 0AT0ERMrLN5CBB/KTH3DU=
X-IronPort-AV: E=Sophos;i="5.85,348,1624334400"; 
   d="scan'208";a="53961045"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Jan Beulich
	<JBeulich@suse.com>, =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?=
	<roger.pau@citrix.com>, Wei Liu <wl@xen.org>
Subject: [PATCH] x86/spec-ctrl: Build with BRANCH_HARDEN lfences by default
Date: Tue, 5 Oct 2021 12:11:46 +0100
Message-ID: <20211005111146.3694-1-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

Branch Harden is enabled by default at compile and boot time.  Invert the code
to compile with lfence by default and nop out in the non-default case.

This has several advantages.  It removes 3829 patch points (in the random
build of Xen I have to hand) by default on boot, 70% (!) of the
.altinstr_replacement section.  For builds of Xen with a non-nops capable tool
chain, the code after `spec-ctrl=no-branch-harden` is better because Xen can
write long nops.

Most importantly however, it means the disassembly actually matches what runs
in the common case, with the ability to distinguish the lfences from other
uses of nops.

Finally, make opt_branch_harden local to spec_ctrl.c and __initdata.  It has
never been used externally, even at it's introduction in c/s 3860d5534df4
"spec: add l1tf-barrier".

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Roger Pau Monné <roger.pau@citrix.com>
CC: Wei Liu <wl@xen.org>
---
 xen/arch/x86/spec_ctrl.c          | 7 ++++---
 xen/include/asm-x86/cpufeatures.h | 2 +-
 xen/include/asm-x86/nospec.h      | 2 +-
 xen/include/asm-x86/spec_ctrl.h   | 1 -
 4 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/xen/arch/x86/spec_ctrl.c b/xen/arch/x86/spec_ctrl.c
index 16d2a1d172b5..a5569c7f2b3f 100644
--- a/xen/arch/x86/spec_ctrl.c
+++ b/xen/arch/x86/spec_ctrl.c
@@ -52,7 +52,7 @@ bool __read_mostly opt_ibpb = true;
 bool __read_mostly opt_ssbd = false;
 int8_t __read_mostly opt_eager_fpu = -1;
 int8_t __read_mostly opt_l1d_flush = -1;
-bool __read_mostly opt_branch_harden = true;
+static bool __initdata opt_branch_harden = true;
 
 bool __initdata bsp_delay_spec_ctrl;
 uint8_t __read_mostly default_xen_spec_ctrl;
@@ -1121,8 +1121,9 @@ void __init init_speculation_mitigations(void)
     else if ( opt_l1d_flush == -1 )
         opt_l1d_flush = cpu_has_bug_l1tf && !(caps & ARCH_CAPS_SKIP_L1DFL);
 
-    if ( opt_branch_harden )
-        setup_force_cpu_cap(X86_FEATURE_SC_BRANCH_HARDEN);
+    /* We compile lfence's in by default, and nop them out if requested. */
+    if ( !opt_branch_harden )
+        setup_force_cpu_cap(X86_FEATURE_SC_NO_BRANCH_HARDEN);
 
     /*
      * We do not disable HT by default on affected hardware.
diff --git a/xen/include/asm-x86/cpufeatures.h b/xen/include/asm-x86/cpufeatures.h
index 72beb7babcce..b10154fc44bb 100644
--- a/xen/include/asm-x86/cpufeatures.h
+++ b/xen/include/asm-x86/cpufeatures.h
@@ -27,7 +27,7 @@ XEN_CPUFEATURE(XEN_SMAP,          X86_SYNTH(11)) /* SMAP gets used by Xen itself
 /* Bit 12 - unused. */
 XEN_CPUFEATURE(IND_THUNK_LFENCE,  X86_SYNTH(13)) /* Use IND_THUNK_LFENCE */
 XEN_CPUFEATURE(IND_THUNK_JMP,     X86_SYNTH(14)) /* Use IND_THUNK_JMP */
-XEN_CPUFEATURE(SC_BRANCH_HARDEN,  X86_SYNTH(15)) /* Conditional Branch Hardening */
+XEN_CPUFEATURE(SC_NO_BRANCH_HARDEN, X86_SYNTH(15)) /* (Disable) Conditional branch hardening */
 XEN_CPUFEATURE(SC_MSR_PV,         X86_SYNTH(16)) /* MSR_SPEC_CTRL used by Xen for PV */
 XEN_CPUFEATURE(SC_MSR_HVM,        X86_SYNTH(17)) /* MSR_SPEC_CTRL used by Xen for HVM */
 XEN_CPUFEATURE(SC_RSB_PV,         X86_SYNTH(18)) /* RSB overwrite needed for PV */
diff --git a/xen/include/asm-x86/nospec.h b/xen/include/asm-x86/nospec.h
index f6eb84eee554..5312ae4c6f31 100644
--- a/xen/include/asm-x86/nospec.h
+++ b/xen/include/asm-x86/nospec.h
@@ -10,7 +10,7 @@
 static always_inline bool barrier_nospec_true(void)
 {
 #ifdef CONFIG_SPECULATIVE_HARDEN_BRANCH
-    alternative("", "lfence", X86_FEATURE_SC_BRANCH_HARDEN);
+    alternative("lfence", "", X86_FEATURE_SC_NO_BRANCH_HARDEN);
 #endif
     return true;
 }
diff --git a/xen/include/asm-x86/spec_ctrl.h b/xen/include/asm-x86/spec_ctrl.h
index e671b6fd8d57..a803d16f9065 100644
--- a/xen/include/asm-x86/spec_ctrl.h
+++ b/xen/include/asm-x86/spec_ctrl.h
@@ -37,7 +37,6 @@ extern bool opt_ibpb;
 extern bool opt_ssbd;
 extern int8_t opt_eager_fpu;
 extern int8_t opt_l1d_flush;
-extern bool opt_branch_harden;
 
 extern bool bsp_delay_spec_ctrl;
 extern uint8_t default_xen_spec_ctrl;
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Tue Oct 05 12:15:53 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Oct 2021 12:15:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.202165.356853 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXjLr-0005Jo-3W; Tue, 05 Oct 2021 12:15:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 202165.356853; Tue, 05 Oct 2021 12:15:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXjLr-0005Jh-0b; Tue, 05 Oct 2021 12:15:19 +0000
Received: by outflank-mailman (input) for mailman id 202165;
 Tue, 05 Oct 2021 12:15:17 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=AOXf=OZ=redhat.com=david@srs-us1.protection.inumbo.net>)
 id 1mXjLp-0005Ja-1q
 for xen-devel@lists.xenproject.org; Tue, 05 Oct 2021 12:15:17 +0000
Received: from us-smtp-delivery-124.mimecast.com (unknown [216.205.24.124])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTP
 id bb1ed096-29ab-41a1-988e-8c5f8a83a96e;
 Tue, 05 Oct 2021 12:15:15 +0000 (UTC)
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-193-sWb1MEcANPiv2spGvuCfbQ-1; Tue, 05 Oct 2021 08:15:11 -0400
Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com
 [10.5.11.23])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 57CCC802921;
 Tue,  5 Oct 2021 12:15:08 +0000 (UTC)
Received: from t480s.redhat.com (unknown [10.39.193.58])
 by smtp.corp.redhat.com (Postfix) with ESMTP id A227F1F6;
 Tue,  5 Oct 2021 12:14:31 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: bb1ed096-29ab-41a1-988e-8c5f8a83a96e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1633436114;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding;
	bh=dCCO8fvaNG5kRPHcw+pvgkkQZNNkJ5hJCAeGZXd3qtE=;
	b=dyotV2OlBJRp8ocPIdaJ6oJabEThrTKiTdYF5FGQReTcUN9L8L1SOPehItTPSx5OhSjfrY
	0EkHvT4OzcO/geLoflLEpV6isdRPfF8TGFjMQjLi2EBZLE9ohXMRD+NJ37ethFvLFI1Cx5
	VkiZpwBh/pBjES2j3nBpwMexBGoHslY=
X-MC-Unique: sWb1MEcANPiv2spGvuCfbQ-1
From: David Hildenbrand <david@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: David Hildenbrand <david@redhat.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Jason Wang <jasowang@redhat.com>,
	Dave Young <dyoung@redhat.com>,
	Baoquan He <bhe@redhat.com>,
	Vivek Goyal <vgoyal@redhat.com>,
	Michal Hocko <mhocko@suse.com>,
	Oscar Salvador <osalvador@suse.de>,
	Mike Rapoport <rppt@kernel.org>,
	"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
	x86@kernel.org,
	xen-devel@lists.xenproject.org,
	virtualization@lists.linux-foundation.org,
	kexec@lists.infradead.org,
	linux-fsdevel@vger.kernel.org,
	linux-mm@kvack.org
Subject: [PATCH v2 0/9] proc/vmcore: sanitize access to virtio-mem memory
Date: Tue,  5 Oct 2021 14:14:21 +0200
Message-Id: <20211005121430.30136-1-david@redhat.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23

As so often with virtio-mem changes that mess with common MM
infrastructure, this might be a good candiate to go via Andrew's tree.

--

After removing /dev/kmem, sanitizing /proc/kcore and handling /dev/mem,
this series tackles the last sane way how a VM could accidentially access
logically unplugged memory managed by a virtio-mem device: /proc/vmcore

When dumping memory via "makedumpfile", PG_offline pages, used by
virtio-mem to flag logically unplugged memory, are already properly
excluded; however, especially when accessing/copying /proc/vmcore "the
usual way", we can still end up reading logically unplugged memory part of
a virtio-mem device.

Patch #1-#3 are cleanups. Patch #4 extends the existing oldmem_pfn_is_ram
mechanism. Patch #5-#7 are virtio-mem refactorings for patch #8, which
implements the virtio-mem logic to query the state of device blocks.

Patch #8:

"
Although virtio-mem currently supports reading unplugged memory in the
hypervisor, this will change in the future, indicated to the device via
a new feature flag. We similarly sanitized /proc/kcore access recently.
[...]
Distributions that support virtio-mem+kdump have to make sure that the
virtio_mem module will be part of the kdump kernel or the kdump initrd;
dracut was recently [2] extended to include virtio-mem in the generated
initrd. As long as no special kdump kernels are used, this will
automatically make sure that virtio-mem will be around in the kdump initrd
and sanitize /proc/vmcore access -- with dracut.
"

This is the last remaining bit to support
VIRTIO_MEM_F_UNPLUGGED_INACCESSIBLE [3] in the Linux implementation of
virtio-mem.

Note: this is best-effort. We'll never be able to control what runs inside
the second kernel, really, but we also don't have to care: we only care
about sane setups where we don't want our VM getting zapped once we
touch the wrong memory location while dumping. While we usually expect sane
setups to use "makedumfile", nothing really speaks against just copying
/proc/vmcore, especially in environments where HWpoisioning isn't typically
expected. Also, we really don't want to put all our trust completely on the
memmap, so sanitizing also makes sense when just using "makedumpfile".

[1] https://lkml.kernel.org/r/20210526093041.8800-1-david@redhat.com
[2] https://github.com/dracutdevs/dracut/pull/1157
[3] https://lists.oasis-open.org/archives/virtio-comment/202109/msg00021.html

v1 -> v2:
- "x86/xen: simplify xen_oldmem_pfn_is_ram()"
-- Simplify even more
- "x86/xen: print a warning when HVMOP_get_mem_type fails"
-- Added
- "virtio-mem: kdump mode to sanitize /proc/vmcore access"
-- Fix wrong range check

Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Borislav Petkov <bp@alien8.de>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: Juergen Gross <jgross@suse.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>
Cc: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Jason Wang <jasowang@redhat.com>
Cc: Dave Young <dyoung@redhat.com>
Cc: Baoquan He <bhe@redhat.com>
Cc: Vivek Goyal <vgoyal@redhat.com>
Cc: Michal Hocko <mhocko@suse.com>
Cc: Oscar Salvador <osalvador@suse.de>
Cc: Mike Rapoport <rppt@kernel.org>
Cc: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
Cc: x86@kernel.org
Cc: xen-devel@lists.xenproject.org
Cc: virtualization@lists.linux-foundation.org
Cc: kexec@lists.infradead.org
Cc: linux-fsdevel@vger.kernel.org
Cc: linux-mm@kvack.org

David Hildenbrand (9):
  x86/xen: update xen_oldmem_pfn_is_ram() documentation
  x86/xen: simplify xen_oldmem_pfn_is_ram()
  x86/xen: print a warning when HVMOP_get_mem_type fails
  proc/vmcore: let pfn_is_ram() return a bool
  proc/vmcore: convert oldmem_pfn_is_ram callback to more generic vmcore
    callbacks
  virtio-mem: factor out hotplug specifics from virtio_mem_init() into
    virtio_mem_init_hotplug()
  virtio-mem: factor out hotplug specifics from virtio_mem_probe() into
    virtio_mem_init_hotplug()
  virtio-mem: factor out hotplug specifics from virtio_mem_remove() into
    virtio_mem_deinit_hotplug()
  virtio-mem: kdump mode to sanitize /proc/vmcore access

 arch/x86/kernel/aperture_64.c |  13 +-
 arch/x86/xen/mmu_hvm.c        |  37 ++---
 drivers/virtio/virtio_mem.c   | 297 ++++++++++++++++++++++++----------
 fs/proc/vmcore.c              | 105 ++++++++----
 include/linux/crash_dump.h    |  26 ++-
 5 files changed, 333 insertions(+), 145 deletions(-)


base-commit: 9e1ff307c779ce1f0f810c7ecce3d95bbae40896
-- 
2.31.1



From xen-devel-bounces@lists.xenproject.org Tue Oct 05 12:15:55 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Oct 2021 12:15:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.202170.356864 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXjMM-0005mZ-E7; Tue, 05 Oct 2021 12:15:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 202170.356864; Tue, 05 Oct 2021 12:15:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXjMM-0005mS-AU; Tue, 05 Oct 2021 12:15:50 +0000
Received: by outflank-mailman (input) for mailman id 202170;
 Tue, 05 Oct 2021 12:15:49 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=AOXf=OZ=redhat.com=david@srs-us1.protection.inumbo.net>)
 id 1mXjML-0005mI-P2
 for xen-devel@lists.xenproject.org; Tue, 05 Oct 2021 12:15:49 +0000
Received: from us-smtp-delivery-124.mimecast.com (unknown [216.205.24.124])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTP
 id 7db6b464-2d07-413c-85cd-6f919e090bb4;
 Tue, 05 Oct 2021 12:15:49 +0000 (UTC)
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-97-3iNft1SuOOCFeMn2zDAogw-1; Tue, 05 Oct 2021 08:15:47 -0400
Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com
 [10.5.11.23])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 898E81922036;
 Tue,  5 Oct 2021 12:15:44 +0000 (UTC)
Received: from t480s.redhat.com (unknown [10.39.193.58])
 by smtp.corp.redhat.com (Postfix) with ESMTP id B3DBAE73F;
 Tue,  5 Oct 2021 12:15:08 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7db6b464-2d07-413c-85cd-6f919e090bb4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1633436148;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=uBxtf9cAE1Ob9GyuKdaY249ysRz4C6IB01yDqx20w58=;
	b=AUopRkNq5+IXC7fw+AdpgcQLyCUcZhgGjo7OFm2sLBDdbl/daI6Hlh4i6c0e+hUFLBLWtT
	vlqgjIRInbPrrb+N7rArABzRElIFLcp1Xg/mno5wi3aQL2A1CsNbyllcyamCpKXRFmzJXK
	gihrLAbMN5gMTg1cn4hLi7WMqMV2Xz0=
X-MC-Unique: 3iNft1SuOOCFeMn2zDAogw-1
From: David Hildenbrand <david@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: David Hildenbrand <david@redhat.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Jason Wang <jasowang@redhat.com>,
	Dave Young <dyoung@redhat.com>,
	Baoquan He <bhe@redhat.com>,
	Vivek Goyal <vgoyal@redhat.com>,
	Michal Hocko <mhocko@suse.com>,
	Oscar Salvador <osalvador@suse.de>,
	Mike Rapoport <rppt@kernel.org>,
	"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
	x86@kernel.org,
	xen-devel@lists.xenproject.org,
	virtualization@lists.linux-foundation.org,
	kexec@lists.infradead.org,
	linux-fsdevel@vger.kernel.org,
	linux-mm@kvack.org,
	Boris Ostrovsky <boris.ostrvsky@oracle.com>
Subject: [PATCH v2 1/9] x86/xen: update xen_oldmem_pfn_is_ram() documentation
Date: Tue,  5 Oct 2021 14:14:22 +0200
Message-Id: <20211005121430.30136-2-david@redhat.com>
In-Reply-To: <20211005121430.30136-1-david@redhat.com>
References: <20211005121430.30136-1-david@redhat.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23

The callback is only used for the vmcore nowadays.

Reviewed-by: Boris Ostrovsky <boris.ostrvsky@oracle.com>
Signed-off-by: David Hildenbrand <david@redhat.com>
---
 arch/x86/xen/mmu_hvm.c | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/arch/x86/xen/mmu_hvm.c b/arch/x86/xen/mmu_hvm.c
index 57409373750f..b242d1f4b426 100644
--- a/arch/x86/xen/mmu_hvm.c
+++ b/arch/x86/xen/mmu_hvm.c
@@ -9,12 +9,9 @@
 
 #ifdef CONFIG_PROC_VMCORE
 /*
- * This function is used in two contexts:
- * - the kdump kernel has to check whether a pfn of the crashed kernel
- *   was a ballooned page. vmcore is using this function to decide
- *   whether to access a pfn of the crashed kernel.
- * - the kexec kernel has to check whether a pfn was ballooned by the
- *   previous kernel. If the pfn is ballooned, handle it properly.
+ * The kdump kernel has to check whether a pfn of the crashed kernel
+ * was a ballooned page. vmcore is using this function to decide
+ * whether to access a pfn of the crashed kernel.
  * Returns 0 if the pfn is not backed by a RAM page, the caller may
  * handle the pfn special in this case.
  */
-- 
2.31.1



From xen-devel-bounces@lists.xenproject.org Tue Oct 05 12:16:17 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Oct 2021 12:16:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.202175.356875 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXjMn-0006JB-NE; Tue, 05 Oct 2021 12:16:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 202175.356875; Tue, 05 Oct 2021 12:16:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXjMn-0006J0-K6; Tue, 05 Oct 2021 12:16:17 +0000
Received: by outflank-mailman (input) for mailman id 202175;
 Tue, 05 Oct 2021 12:16:17 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=AOXf=OZ=redhat.com=david@srs-us1.protection.inumbo.net>)
 id 1mXjMm-0006HZ-VO
 for xen-devel@lists.xenproject.org; Tue, 05 Oct 2021 12:16:16 +0000
Received: from us-smtp-delivery-124.mimecast.com (unknown [216.205.24.124])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTP
 id 1344e3a7-3d6d-467e-b626-32e0603a39e0;
 Tue, 05 Oct 2021 12:16:16 +0000 (UTC)
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-265-B14qeA0YO_ehUZiZU6OrOQ-1; Tue, 05 Oct 2021 08:16:15 -0400
Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com
 [10.5.11.23])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mimecast-mx01.redhat.com (Postfix) with ESMTPS id BC5411006AA2;
 Tue,  5 Oct 2021 12:16:12 +0000 (UTC)
Received: from t480s.redhat.com (unknown [10.39.193.58])
 by smtp.corp.redhat.com (Postfix) with ESMTP id E602A1F6;
 Tue,  5 Oct 2021 12:15:44 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1344e3a7-3d6d-467e-b626-32e0603a39e0
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1633436176;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=m/50e74I6mK0ds4X9rX72a/33EthQOH3jN2qPda+wXk=;
	b=WhIY/ADUaAxjlpq6UbqCLTBis1bEuupekqkuieq++DcAJthI1VQjizdvC44zHWOVgGeZ+s
	LHUEsyHmOOCiDZMdy2XFhvi9oHJRgbfprtbjl/PBQftdpcafx99ZICankCPU+S8yV3kflp
	2Qjdd5P2ErkHr8jLvR+ZICJEggRh0HQ=
X-MC-Unique: B14qeA0YO_ehUZiZU6OrOQ-1
From: David Hildenbrand <david@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: David Hildenbrand <david@redhat.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Jason Wang <jasowang@redhat.com>,
	Dave Young <dyoung@redhat.com>,
	Baoquan He <bhe@redhat.com>,
	Vivek Goyal <vgoyal@redhat.com>,
	Michal Hocko <mhocko@suse.com>,
	Oscar Salvador <osalvador@suse.de>,
	Mike Rapoport <rppt@kernel.org>,
	"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
	x86@kernel.org,
	xen-devel@lists.xenproject.org,
	virtualization@lists.linux-foundation.org,
	kexec@lists.infradead.org,
	linux-fsdevel@vger.kernel.org,
	linux-mm@kvack.org
Subject: [PATCH v2 2/9] x86/xen: simplify xen_oldmem_pfn_is_ram()
Date: Tue,  5 Oct 2021 14:14:23 +0200
Message-Id: <20211005121430.30136-3-david@redhat.com>
In-Reply-To: <20211005121430.30136-1-david@redhat.com>
References: <20211005121430.30136-1-david@redhat.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23

Let's simplify return handling.

Signed-off-by: David Hildenbrand <david@redhat.com>
---
 arch/x86/xen/mmu_hvm.c | 15 +--------------
 1 file changed, 1 insertion(+), 14 deletions(-)

diff --git a/arch/x86/xen/mmu_hvm.c b/arch/x86/xen/mmu_hvm.c
index b242d1f4b426..d1b38c77352b 100644
--- a/arch/x86/xen/mmu_hvm.c
+++ b/arch/x86/xen/mmu_hvm.c
@@ -21,23 +21,10 @@ static int xen_oldmem_pfn_is_ram(unsigned long pfn)
 		.domid = DOMID_SELF,
 		.pfn = pfn,
 	};
-	int ram;
 
 	if (HYPERVISOR_hvm_op(HVMOP_get_mem_type, &a))
 		return -ENXIO;
-
-	switch (a.mem_type) {
-	case HVMMEM_mmio_dm:
-		ram = 0;
-		break;
-	case HVMMEM_ram_rw:
-	case HVMMEM_ram_ro:
-	default:
-		ram = 1;
-		break;
-	}
-
-	return ram;
+	return a.mem_type != HVMMEM_mmio_dm;
 }
 #endif
 
-- 
2.31.1



From xen-devel-bounces@lists.xenproject.org Tue Oct 05 12:16:53 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Oct 2021 12:16:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.202184.356886 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXjNN-0006yh-1Y; Tue, 05 Oct 2021 12:16:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 202184.356886; Tue, 05 Oct 2021 12:16:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXjNM-0006ya-TV; Tue, 05 Oct 2021 12:16:52 +0000
Received: by outflank-mailman (input) for mailman id 202184;
 Tue, 05 Oct 2021 12:16:51 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=AOXf=OZ=redhat.com=david@srs-us1.protection.inumbo.net>)
 id 1mXjNL-0006y6-EJ
 for xen-devel@lists.xenproject.org; Tue, 05 Oct 2021 12:16:51 +0000
Received: from us-smtp-delivery-124.mimecast.com (unknown [170.10.133.124])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTP
 id 1dddb831-25d6-11ec-bedc-12813bfff9fa;
 Tue, 05 Oct 2021 12:16:49 +0000 (UTC)
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-100-fIbnxzTSOKeOo2Y7cHkiOw-1; Tue, 05 Oct 2021 08:16:46 -0400
Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com
 [10.5.11.23])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2A66F1084683;
 Tue,  5 Oct 2021 12:16:44 +0000 (UTC)
Received: from t480s.redhat.com (unknown [10.39.193.58])
 by smtp.corp.redhat.com (Postfix) with ESMTP id 22A421F436;
 Tue,  5 Oct 2021 12:16:12 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1dddb831-25d6-11ec-bedc-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1633436209;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=eNI9g9wwmQcdN9iXnExKxfHZe2dTuiVg+oq/PzETzdk=;
	b=Cp+tOj5SlUt0HQawQjRz6V3qiG5vhuZV2h3jHUP7b5h/s2JlOW62RGb/CsDxZSCERQ7GZ8
	s2E5nSxVSVHuBxe0zWuYZtApenEeSsj/c3tDOYTZURxCGzyv0cA7G5StDDcLMIH9MlsBGZ
	2zJZTgS8fv5q+pi4vVs0F7TV50Pz+7g=
X-MC-Unique: fIbnxzTSOKeOo2Y7cHkiOw-1
From: David Hildenbrand <david@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: David Hildenbrand <david@redhat.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Jason Wang <jasowang@redhat.com>,
	Dave Young <dyoung@redhat.com>,
	Baoquan He <bhe@redhat.com>,
	Vivek Goyal <vgoyal@redhat.com>,
	Michal Hocko <mhocko@suse.com>,
	Oscar Salvador <osalvador@suse.de>,
	Mike Rapoport <rppt@kernel.org>,
	"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
	x86@kernel.org,
	xen-devel@lists.xenproject.org,
	virtualization@lists.linux-foundation.org,
	kexec@lists.infradead.org,
	linux-fsdevel@vger.kernel.org,
	linux-mm@kvack.org
Subject: [PATCH v2 3/9] x86/xen: print a warning when HVMOP_get_mem_type fails
Date: Tue,  5 Oct 2021 14:14:24 +0200
Message-Id: <20211005121430.30136-4-david@redhat.com>
In-Reply-To: <20211005121430.30136-1-david@redhat.com>
References: <20211005121430.30136-1-david@redhat.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23

HVMOP_get_mem_type is not expected to fail, "This call failing is
indication of something going quite wrong and it would be good to know
about this." [1]

Let's add a pr_warn_once().

[1] https://lkml.kernel.org/r/3b935aa0-6d85-0bcd-100e-15098add3c4c@oracle.com

Suggested-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Signed-off-by: David Hildenbrand <david@redhat.com>
---
 arch/x86/xen/mmu_hvm.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/arch/x86/xen/mmu_hvm.c b/arch/x86/xen/mmu_hvm.c
index d1b38c77352b..6ba8826dcdcc 100644
--- a/arch/x86/xen/mmu_hvm.c
+++ b/arch/x86/xen/mmu_hvm.c
@@ -22,8 +22,10 @@ static int xen_oldmem_pfn_is_ram(unsigned long pfn)
 		.pfn = pfn,
 	};
 
-	if (HYPERVISOR_hvm_op(HVMOP_get_mem_type, &a))
+	if (HYPERVISOR_hvm_op(HVMOP_get_mem_type, &a)) {
+		pr_warn_once("Unexpected HVMOP_get_mem_type failure\n");
 		return -ENXIO;
+	}
 	return a.mem_type != HVMMEM_mmio_dm;
 }
 #endif
-- 
2.31.1



From xen-devel-bounces@lists.xenproject.org Tue Oct 05 12:17:16 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Oct 2021 12:17:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.202192.356896 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXjNk-0007bX-9H; Tue, 05 Oct 2021 12:17:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 202192.356896; Tue, 05 Oct 2021 12:17:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXjNk-0007bQ-6R; Tue, 05 Oct 2021 12:17:16 +0000
Received: by outflank-mailman (input) for mailman id 202192;
 Tue, 05 Oct 2021 12:17:14 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=AOXf=OZ=redhat.com=david@srs-us1.protection.inumbo.net>)
 id 1mXjNi-0007b1-Ph
 for xen-devel@lists.xenproject.org; Tue, 05 Oct 2021 12:17:14 +0000
Received: from us-smtp-delivery-124.mimecast.com (unknown [170.10.129.124])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTP
 id 2c6cd782-25d6-11ec-bedc-12813bfff9fa;
 Tue, 05 Oct 2021 12:17:14 +0000 (UTC)
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-9-_yuhuh9aMZqQMTjblstdTw-1; Tue, 05 Oct 2021 08:17:12 -0400
Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com
 [10.5.11.23])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4BF101084685;
 Tue,  5 Oct 2021 12:17:10 +0000 (UTC)
Received: from t480s.redhat.com (unknown [10.39.193.58])
 by smtp.corp.redhat.com (Postfix) with ESMTP id 8D5201F443;
 Tue,  5 Oct 2021 12:16:44 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2c6cd782-25d6-11ec-bedc-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1633436233;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=rRKr51/8zMLS50oc29PqKZsNRavWkybmtHfcIniBEhA=;
	b=BMENpT9hORuvvBknrAemFC4ftDda7a0pNOPkSfg1VibETQ5k6Cz8/vVnGQJ8Dkd54hQ9WK
	mOAJ4xbxe98Kr+UDXjSwf77WuCIqaEOxXFhakffkUlPMxFL8Z1KrNj5QbpgdiqSlKVye87
	+ZyGYeqo6On92CYfjHxMQv7QHAJbNa0=
X-MC-Unique: _yuhuh9aMZqQMTjblstdTw-1
From: David Hildenbrand <david@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: David Hildenbrand <david@redhat.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Jason Wang <jasowang@redhat.com>,
	Dave Young <dyoung@redhat.com>,
	Baoquan He <bhe@redhat.com>,
	Vivek Goyal <vgoyal@redhat.com>,
	Michal Hocko <mhocko@suse.com>,
	Oscar Salvador <osalvador@suse.de>,
	Mike Rapoport <rppt@kernel.org>,
	"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
	x86@kernel.org,
	xen-devel@lists.xenproject.org,
	virtualization@lists.linux-foundation.org,
	kexec@lists.infradead.org,
	linux-fsdevel@vger.kernel.org,
	linux-mm@kvack.org
Subject: [PATCH v2 4/9] proc/vmcore: let pfn_is_ram() return a bool
Date: Tue,  5 Oct 2021 14:14:25 +0200
Message-Id: <20211005121430.30136-5-david@redhat.com>
In-Reply-To: <20211005121430.30136-1-david@redhat.com>
References: <20211005121430.30136-1-david@redhat.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23

The callback should deal with errors internally, it doesn't make sense to
expose these via pfn_is_ram(). We'll rework the callbacks next. Right now
we consider errors as if "it's RAM"; no functional change.

Signed-off-by: David Hildenbrand <david@redhat.com>
---
 fs/proc/vmcore.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/fs/proc/vmcore.c b/fs/proc/vmcore.c
index 9a15334da208..a9bd80ab670e 100644
--- a/fs/proc/vmcore.c
+++ b/fs/proc/vmcore.c
@@ -84,11 +84,11 @@ void unregister_oldmem_pfn_is_ram(void)
 }
 EXPORT_SYMBOL_GPL(unregister_oldmem_pfn_is_ram);
 
-static int pfn_is_ram(unsigned long pfn)
+static bool pfn_is_ram(unsigned long pfn)
 {
 	int (*fn)(unsigned long pfn);
 	/* pfn is ram unless fn() checks pagetype */
-	int ret = 1;
+	bool ret = true;
 
 	/*
 	 * Ask hypervisor if the pfn is really ram.
@@ -97,7 +97,7 @@ static int pfn_is_ram(unsigned long pfn)
 	 */
 	fn = oldmem_pfn_is_ram;
 	if (fn)
-		ret = fn(pfn);
+		ret = !!fn(pfn);
 
 	return ret;
 }
@@ -124,7 +124,7 @@ ssize_t read_from_oldmem(char *buf, size_t count,
 			nr_bytes = count;
 
 		/* If pfn is not ram, return zeros for sparse dump files */
-		if (pfn_is_ram(pfn) == 0)
+		if (!pfn_is_ram(pfn))
 			memset(buf, 0, nr_bytes);
 		else {
 			if (encrypted)
-- 
2.31.1



From xen-devel-bounces@lists.xenproject.org Tue Oct 05 12:17:42 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Oct 2021 12:17:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.202202.356908 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXjOA-0008Cd-JN; Tue, 05 Oct 2021 12:17:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 202202.356908; Tue, 05 Oct 2021 12:17:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXjOA-0008CW-G9; Tue, 05 Oct 2021 12:17:42 +0000
Received: by outflank-mailman (input) for mailman id 202202;
 Tue, 05 Oct 2021 12:17:42 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=AOXf=OZ=redhat.com=david@srs-us1.protection.inumbo.net>)
 id 1mXjOA-0008CH-5L
 for xen-devel@lists.xenproject.org; Tue, 05 Oct 2021 12:17:42 +0000
Received: from us-smtp-delivery-124.mimecast.com (unknown [216.205.24.124])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTP
 id 5e76aff7-672c-4b9e-a4d1-ed5b27b706a5;
 Tue, 05 Oct 2021 12:17:39 +0000 (UTC)
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-413-XNr-A2KOOBWXNVHpZVXueA-1; Tue, 05 Oct 2021 08:17:37 -0400
Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com
 [10.5.11.23])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 94EBE835DE3;
 Tue,  5 Oct 2021 12:17:35 +0000 (UTC)
Received: from t480s.redhat.com (unknown [10.39.193.58])
 by smtp.corp.redhat.com (Postfix) with ESMTP id A90B81F41E;
 Tue,  5 Oct 2021 12:17:10 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5e76aff7-672c-4b9e-a4d1-ed5b27b706a5
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1633436259;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=b08bwJadsrVmMln3sbYIFWClmwweTC89/Y5Un97Ca3s=;
	b=TBdVSkWBl8UXP2BZo5JOPe6aO5Btle2JCyDFS1PA5vSv8owsNEZosduVsUP4mtOouB0ASe
	tROxMNw4umEhGuECF8PVxaRSgFJOU/ZU4kKZK5Xm3VAOe1Wlt2AyZMtrAoSoEnb4yXoBtx
	1LYlRfRKpzLNUXlBYD45yxUae1mtvvg=
X-MC-Unique: XNr-A2KOOBWXNVHpZVXueA-1
From: David Hildenbrand <david@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: David Hildenbrand <david@redhat.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Jason Wang <jasowang@redhat.com>,
	Dave Young <dyoung@redhat.com>,
	Baoquan He <bhe@redhat.com>,
	Vivek Goyal <vgoyal@redhat.com>,
	Michal Hocko <mhocko@suse.com>,
	Oscar Salvador <osalvador@suse.de>,
	Mike Rapoport <rppt@kernel.org>,
	"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
	x86@kernel.org,
	xen-devel@lists.xenproject.org,
	virtualization@lists.linux-foundation.org,
	kexec@lists.infradead.org,
	linux-fsdevel@vger.kernel.org,
	linux-mm@kvack.org
Subject: [PATCH v2 5/9] proc/vmcore: convert oldmem_pfn_is_ram callback to more generic vmcore callbacks
Date: Tue,  5 Oct 2021 14:14:26 +0200
Message-Id: <20211005121430.30136-6-david@redhat.com>
In-Reply-To: <20211005121430.30136-1-david@redhat.com>
References: <20211005121430.30136-1-david@redhat.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23

Let's support multiple registered callbacks, making sure that
registering vmcore callbacks cannot fail. Make the callback return a
bool instead of an int, handling how to deal with errors internally.
Drop unused HAVE_OLDMEM_PFN_IS_RAM.

We soon want to make use of this infrastructure from other drivers:
virtio-mem, registering one callback for each virtio-mem device, to
prevent reading unplugged virtio-mem memory.

Handle it via a generic vmcore_cb structure, prepared for future
extensions: for example, once we support virtio-mem on s390x where the
vmcore is completely constructed in the second kernel, we want to detect
and add plugged virtio-mem memory ranges to the vmcore in order for them
to get dumped properly.

Handle corner cases that are unexpected and shouldn't happen in sane
setups: registering a callback after the vmcore has already been opened
(warn only) and unregistering a callback after the vmcore has already been
opened (warn and essentially read only zeroes from that point on).

Signed-off-by: David Hildenbrand <david@redhat.com>
---
 arch/x86/kernel/aperture_64.c | 13 ++++-
 arch/x86/xen/mmu_hvm.c        | 11 ++--
 fs/proc/vmcore.c              | 99 ++++++++++++++++++++++++-----------
 include/linux/crash_dump.h    | 26 +++++++--
 4 files changed, 111 insertions(+), 38 deletions(-)

diff --git a/arch/x86/kernel/aperture_64.c b/arch/x86/kernel/aperture_64.c
index 10562885f5fc..af3ba08b684b 100644
--- a/arch/x86/kernel/aperture_64.c
+++ b/arch/x86/kernel/aperture_64.c
@@ -73,12 +73,23 @@ static int gart_mem_pfn_is_ram(unsigned long pfn)
 		      (pfn >= aperture_pfn_start + aperture_page_count));
 }
 
+#ifdef CONFIG_PROC_VMCORE
+static bool gart_oldmem_pfn_is_ram(struct vmcore_cb *cb, unsigned long pfn)
+{
+	return !!gart_mem_pfn_is_ram(pfn);
+}
+
+static struct vmcore_cb gart_vmcore_cb = {
+	.pfn_is_ram = gart_oldmem_pfn_is_ram,
+};
+#endif
+
 static void __init exclude_from_core(u64 aper_base, u32 aper_order)
 {
 	aperture_pfn_start = aper_base >> PAGE_SHIFT;
 	aperture_page_count = (32 * 1024 * 1024) << aper_order >> PAGE_SHIFT;
 #ifdef CONFIG_PROC_VMCORE
-	WARN_ON(register_oldmem_pfn_is_ram(&gart_mem_pfn_is_ram));
+	register_vmcore_cb(&gart_vmcore_cb);
 #endif
 #ifdef CONFIG_PROC_KCORE
 	WARN_ON(register_mem_pfn_is_ram(&gart_mem_pfn_is_ram));
diff --git a/arch/x86/xen/mmu_hvm.c b/arch/x86/xen/mmu_hvm.c
index 6ba8826dcdcc..509bdee3ab90 100644
--- a/arch/x86/xen/mmu_hvm.c
+++ b/arch/x86/xen/mmu_hvm.c
@@ -12,10 +12,10 @@
  * The kdump kernel has to check whether a pfn of the crashed kernel
  * was a ballooned page. vmcore is using this function to decide
  * whether to access a pfn of the crashed kernel.
- * Returns 0 if the pfn is not backed by a RAM page, the caller may
+ * Returns "false" if the pfn is not backed by a RAM page, the caller may
  * handle the pfn special in this case.
  */
-static int xen_oldmem_pfn_is_ram(unsigned long pfn)
+static bool xen_vmcore_pfn_is_ram(struct vmcore_cb *cb, unsigned long pfn)
 {
 	struct xen_hvm_get_mem_type a = {
 		.domid = DOMID_SELF,
@@ -24,10 +24,13 @@ static int xen_oldmem_pfn_is_ram(unsigned long pfn)
 
 	if (HYPERVISOR_hvm_op(HVMOP_get_mem_type, &a)) {
 		pr_warn_once("Unexpected HVMOP_get_mem_type failure\n");
-		return -ENXIO;
+		return true;
 	}
 	return a.mem_type != HVMMEM_mmio_dm;
 }
+static struct vmcore_cb xen_vmcore_cb = {
+	.pfn_is_ram = xen_vmcore_pfn_is_ram,
+};
 #endif
 
 static void xen_hvm_exit_mmap(struct mm_struct *mm)
@@ -61,6 +64,6 @@ void __init xen_hvm_init_mmu_ops(void)
 	if (is_pagetable_dying_supported())
 		pv_ops.mmu.exit_mmap = xen_hvm_exit_mmap;
 #ifdef CONFIG_PROC_VMCORE
-	WARN_ON(register_oldmem_pfn_is_ram(&xen_oldmem_pfn_is_ram));
+	register_vmcore_cb(&xen_vmcore_cb);
 #endif
 }
diff --git a/fs/proc/vmcore.c b/fs/proc/vmcore.c
index a9bd80ab670e..7a04b2eca287 100644
--- a/fs/proc/vmcore.c
+++ b/fs/proc/vmcore.c
@@ -62,46 +62,75 @@ core_param(novmcoredd, vmcoredd_disabled, bool, 0);
 /* Device Dump Size */
 static size_t vmcoredd_orig_sz;
 
-/*
- * Returns > 0 for RAM pages, 0 for non-RAM pages, < 0 on error
- * The called function has to take care of module refcounting.
- */
-static int (*oldmem_pfn_is_ram)(unsigned long pfn);
-
-int register_oldmem_pfn_is_ram(int (*fn)(unsigned long pfn))
+static DECLARE_RWSEM(vmcore_cb_rwsem);
+/* List of registered vmcore callbacks. */
+static LIST_HEAD(vmcore_cb_list);
+/* Whether we had a surprise unregistration of a callback. */
+static bool vmcore_cb_unstable;
+/* Whether the vmcore has been opened once. */
+static bool vmcore_opened;
+
+void register_vmcore_cb(struct vmcore_cb *cb)
 {
-	if (oldmem_pfn_is_ram)
-		return -EBUSY;
-	oldmem_pfn_is_ram = fn;
-	return 0;
+	down_write(&vmcore_cb_rwsem);
+	INIT_LIST_HEAD(&cb->next);
+	list_add_tail(&cb->next, &vmcore_cb_list);
+	/*
+	 * Registering a vmcore callback after the vmcore was opened is
+	 * very unusual (e.g., manual driver loading).
+	 */
+	if (vmcore_opened)
+		pr_warn_once("Unexpected vmcore callback registration\n");
+	up_write(&vmcore_cb_rwsem);
 }
-EXPORT_SYMBOL_GPL(register_oldmem_pfn_is_ram);
+EXPORT_SYMBOL_GPL(register_vmcore_cb);
 
-void unregister_oldmem_pfn_is_ram(void)
+void unregister_vmcore_cb(struct vmcore_cb *cb)
 {
-	oldmem_pfn_is_ram = NULL;
-	wmb();
+	down_write(&vmcore_cb_rwsem);
+	list_del(&cb->next);
+	/*
+	 * Unregistering a vmcore callback after the vmcore was opened is
+	 * very unusual (e.g., forced driver removal), but we cannot stop
+	 * unregistering.
+	 */
+	if (vmcore_opened) {
+		pr_warn_once("Unexpected vmcore callback unregistration\n");
+		vmcore_cb_unstable = true;
+	}
+	up_write(&vmcore_cb_rwsem);
 }
-EXPORT_SYMBOL_GPL(unregister_oldmem_pfn_is_ram);
+EXPORT_SYMBOL_GPL(unregister_vmcore_cb);
 
 static bool pfn_is_ram(unsigned long pfn)
 {
-	int (*fn)(unsigned long pfn);
-	/* pfn is ram unless fn() checks pagetype */
+	struct vmcore_cb *cb;
 	bool ret = true;
 
-	/*
-	 * Ask hypervisor if the pfn is really ram.
-	 * A ballooned page contains no data and reading from such a page
-	 * will cause high load in the hypervisor.
-	 */
-	fn = oldmem_pfn_is_ram;
-	if (fn)
-		ret = !!fn(pfn);
+	lockdep_assert_held_read(&vmcore_cb_rwsem);
+	if (unlikely(vmcore_cb_unstable))
+		return false;
+
+	list_for_each_entry(cb, &vmcore_cb_list, next) {
+		if (unlikely(!cb->pfn_is_ram))
+			continue;
+		ret = cb->pfn_is_ram(cb, pfn);
+		if (!ret)
+			break;
+	}
 
 	return ret;
 }
 
+static int open_vmcore(struct inode *inode, struct file *file)
+{
+	down_read(&vmcore_cb_rwsem);
+	vmcore_opened = true;
+	up_read(&vmcore_cb_rwsem);
+
+	return 0;
+}
+
 /* Reads a page from the oldmem device from given offset. */
 ssize_t read_from_oldmem(char *buf, size_t count,
 			 u64 *ppos, int userbuf,
@@ -117,6 +146,7 @@ ssize_t read_from_oldmem(char *buf, size_t count,
 	offset = (unsigned long)(*ppos % PAGE_SIZE);
 	pfn = (unsigned long)(*ppos / PAGE_SIZE);
 
+	down_read(&vmcore_cb_rwsem);
 	do {
 		if (count > (PAGE_SIZE - offset))
 			nr_bytes = PAGE_SIZE - offset;
@@ -136,8 +166,10 @@ ssize_t read_from_oldmem(char *buf, size_t count,
 				tmp = copy_oldmem_page(pfn, buf, nr_bytes,
 						       offset, userbuf);
 
-			if (tmp < 0)
+			if (tmp < 0) {
+				up_read(&vmcore_cb_rwsem);
 				return tmp;
+			}
 		}
 		*ppos += nr_bytes;
 		count -= nr_bytes;
@@ -147,6 +179,7 @@ ssize_t read_from_oldmem(char *buf, size_t count,
 		offset = 0;
 	} while (count);
 
+	up_read(&vmcore_cb_rwsem);
 	return read;
 }
 
@@ -537,14 +570,19 @@ static int vmcore_remap_oldmem_pfn(struct vm_area_struct *vma,
 			    unsigned long from, unsigned long pfn,
 			    unsigned long size, pgprot_t prot)
 {
+	int ret;
+
 	/*
 	 * Check if oldmem_pfn_is_ram was registered to avoid
 	 * looping over all pages without a reason.
 	 */
-	if (oldmem_pfn_is_ram)
-		return remap_oldmem_pfn_checked(vma, from, pfn, size, prot);
+	down_read(&vmcore_cb_rwsem);
+	if (!list_empty(&vmcore_cb_list) || vmcore_cb_unstable)
+		ret = remap_oldmem_pfn_checked(vma, from, pfn, size, prot);
 	else
-		return remap_oldmem_pfn_range(vma, from, pfn, size, prot);
+		ret = remap_oldmem_pfn_range(vma, from, pfn, size, prot);
+	up_read(&vmcore_cb_rwsem);
+	return ret;
 }
 
 static int mmap_vmcore(struct file *file, struct vm_area_struct *vma)
@@ -668,6 +706,7 @@ static int mmap_vmcore(struct file *file, struct vm_area_struct *vma)
 #endif
 
 static const struct proc_ops vmcore_proc_ops = {
+	.proc_open	= open_vmcore,
 	.proc_read	= read_vmcore,
 	.proc_lseek	= default_llseek,
 	.proc_mmap	= mmap_vmcore,
diff --git a/include/linux/crash_dump.h b/include/linux/crash_dump.h
index 2618577a4d6d..0c547d866f1e 100644
--- a/include/linux/crash_dump.h
+++ b/include/linux/crash_dump.h
@@ -91,9 +91,29 @@ static inline void vmcore_unusable(void)
 		elfcorehdr_addr = ELFCORE_ADDR_ERR;
 }
 
-#define HAVE_OLDMEM_PFN_IS_RAM 1
-extern int register_oldmem_pfn_is_ram(int (*fn)(unsigned long pfn));
-extern void unregister_oldmem_pfn_is_ram(void);
+/**
+ * struct vmcore_cb - driver callbacks for /proc/vmcore handling
+ * @pfn_is_ram: check whether a PFN really is RAM and should be accessed when
+ *              reading the vmcore. Will return "true" if it is RAM or if the
+ *              callback cannot tell. If any callback returns "false", it's not
+ *              RAM and the page must not be accessed; zeroes should be
+ *              indicated in the vmcore instead. For example, a ballooned page
+ *              contains no data and reading from such a page will cause high
+ *              load in the hypervisor.
+ * @next: List head to manage registered callbacks internally; initialized by
+ *        register_vmcore_cb().
+ *
+ * vmcore callbacks allow drivers managing physical memory ranges to
+ * coordinate with vmcore handling code, for example, to prevent accessing
+ * physical memory ranges that should not be accessed when reading the vmcore,
+ * although included in the vmcore header as memory ranges to dump.
+ */
+struct vmcore_cb {
+	bool (*pfn_is_ram)(struct vmcore_cb *cb, unsigned long pfn);
+	struct list_head next;
+};
+extern void register_vmcore_cb(struct vmcore_cb *cb);
+extern void unregister_vmcore_cb(struct vmcore_cb *cb);
 
 #else /* !CONFIG_CRASH_DUMP */
 static inline bool is_kdump_kernel(void) { return 0; }
-- 
2.31.1



From xen-devel-bounces@lists.xenproject.org Tue Oct 05 12:18:07 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Oct 2021 12:18:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.202211.356919 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXjOZ-0000OK-1m; Tue, 05 Oct 2021 12:18:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 202211.356919; Tue, 05 Oct 2021 12:18:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXjOY-0000OD-Tw; Tue, 05 Oct 2021 12:18:06 +0000
Received: by outflank-mailman (input) for mailman id 202211;
 Tue, 05 Oct 2021 12:18:05 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=AOXf=OZ=redhat.com=david@srs-us1.protection.inumbo.net>)
 id 1mXjOX-0000Nn-LR
 for xen-devel@lists.xenproject.org; Tue, 05 Oct 2021 12:18:05 +0000
Received: from us-smtp-delivery-124.mimecast.com (unknown [170.10.133.124])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTP
 id f9cacd5c-1332-433a-b088-58b90c71d67e;
 Tue, 05 Oct 2021 12:18:04 +0000 (UTC)
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-604-7eXJYInqNRydT23wsOE_6w-1; Tue, 05 Oct 2021 08:18:03 -0400
Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com
 [10.5.11.23])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B62881006AA2;
 Tue,  5 Oct 2021 12:18:00 +0000 (UTC)
Received: from t480s.redhat.com (unknown [10.39.193.58])
 by smtp.corp.redhat.com (Postfix) with ESMTP id F149E1F41E;
 Tue,  5 Oct 2021 12:17:35 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f9cacd5c-1332-433a-b088-58b90c71d67e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1633436284;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=UbXdn+v660VV5bsfwvBwOBATR8SkkHZUOKA5MNOOqCo=;
	b=aIZK3kicIJIoX7EkLwlqGPuatokGYH3OuQQ+EaHoWPGrq7/YneUqy1RfGMbyJ7NKxooccy
	PjltuAjS0PNb3Rijq6Fo+FdyTMwz/B2KDKBEbZvB8ibrm11Azq2YTUXUjhGKHkawQsoK+V
	G6XFEC9N0eIDNw0L3GzFJcrMdp724Uo=
X-MC-Unique: 7eXJYInqNRydT23wsOE_6w-1
From: David Hildenbrand <david@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: David Hildenbrand <david@redhat.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Jason Wang <jasowang@redhat.com>,
	Dave Young <dyoung@redhat.com>,
	Baoquan He <bhe@redhat.com>,
	Vivek Goyal <vgoyal@redhat.com>,
	Michal Hocko <mhocko@suse.com>,
	Oscar Salvador <osalvador@suse.de>,
	Mike Rapoport <rppt@kernel.org>,
	"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
	x86@kernel.org,
	xen-devel@lists.xenproject.org,
	virtualization@lists.linux-foundation.org,
	kexec@lists.infradead.org,
	linux-fsdevel@vger.kernel.org,
	linux-mm@kvack.org
Subject: [PATCH v2 6/9] virtio-mem: factor out hotplug specifics from virtio_mem_init() into virtio_mem_init_hotplug()
Date: Tue,  5 Oct 2021 14:14:27 +0200
Message-Id: <20211005121430.30136-7-david@redhat.com>
In-Reply-To: <20211005121430.30136-1-david@redhat.com>
References: <20211005121430.30136-1-david@redhat.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23

Let's prepare for a new virtio-mem kdump mode in which we don't actually
hot(un)plug any memory but only observe the state of device blocks.

Signed-off-by: David Hildenbrand <david@redhat.com>
---
 drivers/virtio/virtio_mem.c | 81 ++++++++++++++++++++-----------------
 1 file changed, 44 insertions(+), 37 deletions(-)

diff --git a/drivers/virtio/virtio_mem.c b/drivers/virtio/virtio_mem.c
index bef8ad6bf466..2ba7e8d6ba8d 100644
--- a/drivers/virtio/virtio_mem.c
+++ b/drivers/virtio/virtio_mem.c
@@ -2392,41 +2392,10 @@ static int virtio_mem_init_vq(struct virtio_mem *vm)
 	return 0;
 }
 
-static int virtio_mem_init(struct virtio_mem *vm)
+static int virtio_mem_init_hotplug(struct virtio_mem *vm)
 {
 	const struct range pluggable_range = mhp_get_pluggable_range(true);
 	uint64_t sb_size, addr;
-	uint16_t node_id;
-
-	if (!vm->vdev->config->get) {
-		dev_err(&vm->vdev->dev, "config access disabled\n");
-		return -EINVAL;
-	}
-
-	/*
-	 * We don't want to (un)plug or reuse any memory when in kdump. The
-	 * memory is still accessible (but not mapped).
-	 */
-	if (is_kdump_kernel()) {
-		dev_warn(&vm->vdev->dev, "disabled in kdump kernel\n");
-		return -EBUSY;
-	}
-
-	/* Fetch all properties that can't change. */
-	virtio_cread_le(vm->vdev, struct virtio_mem_config, plugged_size,
-			&vm->plugged_size);
-	virtio_cread_le(vm->vdev, struct virtio_mem_config, block_size,
-			&vm->device_block_size);
-	virtio_cread_le(vm->vdev, struct virtio_mem_config, node_id,
-			&node_id);
-	vm->nid = virtio_mem_translate_node_id(vm, node_id);
-	virtio_cread_le(vm->vdev, struct virtio_mem_config, addr, &vm->addr);
-	virtio_cread_le(vm->vdev, struct virtio_mem_config, region_size,
-			&vm->region_size);
-
-	/* Determine the nid for the device based on the lowest address. */
-	if (vm->nid == NUMA_NO_NODE)
-		vm->nid = memory_add_physaddr_to_nid(vm->addr);
 
 	/* bad device setup - warn only */
 	if (!IS_ALIGNED(vm->addr, memory_block_size_bytes()))
@@ -2496,10 +2465,6 @@ static int virtio_mem_init(struct virtio_mem *vm)
 					      vm->offline_threshold);
 	}
 
-	dev_info(&vm->vdev->dev, "start address: 0x%llx", vm->addr);
-	dev_info(&vm->vdev->dev, "region size: 0x%llx", vm->region_size);
-	dev_info(&vm->vdev->dev, "device block size: 0x%llx",
-		 (unsigned long long)vm->device_block_size);
 	dev_info(&vm->vdev->dev, "memory block size: 0x%lx",
 		 memory_block_size_bytes());
 	if (vm->in_sbm)
@@ -2508,10 +2473,52 @@ static int virtio_mem_init(struct virtio_mem *vm)
 	else
 		dev_info(&vm->vdev->dev, "big block size: 0x%llx",
 			 (unsigned long long)vm->bbm.bb_size);
+
+	return 0;
+}
+
+static int virtio_mem_init(struct virtio_mem *vm)
+{
+	uint16_t node_id;
+
+	if (!vm->vdev->config->get) {
+		dev_err(&vm->vdev->dev, "config access disabled\n");
+		return -EINVAL;
+	}
+
+	/*
+	 * We don't want to (un)plug or reuse any memory when in kdump. The
+	 * memory is still accessible (but not mapped).
+	 */
+	if (is_kdump_kernel()) {
+		dev_warn(&vm->vdev->dev, "disabled in kdump kernel\n");
+		return -EBUSY;
+	}
+
+	/* Fetch all properties that can't change. */
+	virtio_cread_le(vm->vdev, struct virtio_mem_config, plugged_size,
+			&vm->plugged_size);
+	virtio_cread_le(vm->vdev, struct virtio_mem_config, block_size,
+			&vm->device_block_size);
+	virtio_cread_le(vm->vdev, struct virtio_mem_config, node_id,
+			&node_id);
+	vm->nid = virtio_mem_translate_node_id(vm, node_id);
+	virtio_cread_le(vm->vdev, struct virtio_mem_config, addr, &vm->addr);
+	virtio_cread_le(vm->vdev, struct virtio_mem_config, region_size,
+			&vm->region_size);
+
+	/* Determine the nid for the device based on the lowest address. */
+	if (vm->nid == NUMA_NO_NODE)
+		vm->nid = memory_add_physaddr_to_nid(vm->addr);
+
+	dev_info(&vm->vdev->dev, "start address: 0x%llx", vm->addr);
+	dev_info(&vm->vdev->dev, "region size: 0x%llx", vm->region_size);
+	dev_info(&vm->vdev->dev, "device block size: 0x%llx",
+		 (unsigned long long)vm->device_block_size);
 	if (vm->nid != NUMA_NO_NODE && IS_ENABLED(CONFIG_NUMA))
 		dev_info(&vm->vdev->dev, "nid: %d", vm->nid);
 
-	return 0;
+	return virtio_mem_init_hotplug(vm);
 }
 
 static int virtio_mem_create_resource(struct virtio_mem *vm)
-- 
2.31.1



From xen-devel-bounces@lists.xenproject.org Tue Oct 05 12:18:34 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Oct 2021 12:18:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.202221.356930 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXjP0-00018h-AY; Tue, 05 Oct 2021 12:18:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 202221.356930; Tue, 05 Oct 2021 12:18:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXjP0-00018a-6F; Tue, 05 Oct 2021 12:18:34 +0000
Received: by outflank-mailman (input) for mailman id 202221;
 Tue, 05 Oct 2021 12:18:33 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=AOXf=OZ=redhat.com=david@srs-us1.protection.inumbo.net>)
 id 1mXjOz-00018C-93
 for xen-devel@lists.xenproject.org; Tue, 05 Oct 2021 12:18:33 +0000
Received: from us-smtp-delivery-124.mimecast.com (unknown [216.205.24.124])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTP
 id 5ae55fa8-25d6-11ec-bedc-12813bfff9fa;
 Tue, 05 Oct 2021 12:18:32 +0000 (UTC)
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-257-YoFJbj0fMLyMSCfLYRqF7g-1; Tue, 05 Oct 2021 08:18:30 -0400
Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com
 [10.5.11.23])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2FAC1362F8;
 Tue,  5 Oct 2021 12:18:28 +0000 (UTC)
Received: from t480s.redhat.com (unknown [10.39.193.58])
 by smtp.corp.redhat.com (Postfix) with ESMTP id 2AD2E1F442;
 Tue,  5 Oct 2021 12:18:00 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5ae55fa8-25d6-11ec-bedc-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1633436311;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=nJ4bVTfY2RBZ7dKHJReSBumHsyhYfakPMn9Oqd8JPC0=;
	b=W7gAEEUD7tIYemQcYLRpiZvqZgQUFu13haAISMlUafHkPYOfGi4HO7Cwaq2i1VhU6FIzBG
	mzoaeyqQUKjr1dBMAvMQVROFVfqX9/1MRyK6bl7nwNlGqE+m5bFs4EVXjuWh6odSkqKVKX
	7D0aRtMs2RZwDDEGYLdlJhNWLhE1N90=
X-MC-Unique: YoFJbj0fMLyMSCfLYRqF7g-1
From: David Hildenbrand <david@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: David Hildenbrand <david@redhat.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Jason Wang <jasowang@redhat.com>,
	Dave Young <dyoung@redhat.com>,
	Baoquan He <bhe@redhat.com>,
	Vivek Goyal <vgoyal@redhat.com>,
	Michal Hocko <mhocko@suse.com>,
	Oscar Salvador <osalvador@suse.de>,
	Mike Rapoport <rppt@kernel.org>,
	"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
	x86@kernel.org,
	xen-devel@lists.xenproject.org,
	virtualization@lists.linux-foundation.org,
	kexec@lists.infradead.org,
	linux-fsdevel@vger.kernel.org,
	linux-mm@kvack.org
Subject: [PATCH v2 7/9] virtio-mem: factor out hotplug specifics from virtio_mem_probe() into virtio_mem_init_hotplug()
Date: Tue,  5 Oct 2021 14:14:28 +0200
Message-Id: <20211005121430.30136-8-david@redhat.com>
In-Reply-To: <20211005121430.30136-1-david@redhat.com>
References: <20211005121430.30136-1-david@redhat.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23

Let's prepare for a new virtio-mem kdump mode in which we don't actually
hot(un)plug any memory but only observe the state of device blocks.

Signed-off-by: David Hildenbrand <david@redhat.com>
---
 drivers/virtio/virtio_mem.c | 87 +++++++++++++++++++------------------
 1 file changed, 45 insertions(+), 42 deletions(-)

diff --git a/drivers/virtio/virtio_mem.c b/drivers/virtio/virtio_mem.c
index 2ba7e8d6ba8d..1be3ee7f684d 100644
--- a/drivers/virtio/virtio_mem.c
+++ b/drivers/virtio/virtio_mem.c
@@ -260,6 +260,8 @@ static void virtio_mem_fake_offline_going_offline(unsigned long pfn,
 static void virtio_mem_fake_offline_cancel_offline(unsigned long pfn,
 						   unsigned long nr_pages);
 static void virtio_mem_retry(struct virtio_mem *vm);
+static int virtio_mem_create_resource(struct virtio_mem *vm);
+static void virtio_mem_delete_resource(struct virtio_mem *vm);
 
 /*
  * Register a virtio-mem device so it will be considered for the online_page
@@ -2395,7 +2397,8 @@ static int virtio_mem_init_vq(struct virtio_mem *vm)
 static int virtio_mem_init_hotplug(struct virtio_mem *vm)
 {
 	const struct range pluggable_range = mhp_get_pluggable_range(true);
-	uint64_t sb_size, addr;
+	uint64_t unit_pages, sb_size, addr;
+	int rc;
 
 	/* bad device setup - warn only */
 	if (!IS_ALIGNED(vm->addr, memory_block_size_bytes()))
@@ -2474,7 +2477,48 @@ static int virtio_mem_init_hotplug(struct virtio_mem *vm)
 		dev_info(&vm->vdev->dev, "big block size: 0x%llx",
 			 (unsigned long long)vm->bbm.bb_size);
 
+	/* create the parent resource for all memory */
+	rc = virtio_mem_create_resource(vm);
+	if (rc)
+		return rc;
+
+	/* use a single dynamic memory group to cover the whole memory device */
+	if (vm->in_sbm)
+		unit_pages = PHYS_PFN(memory_block_size_bytes());
+	else
+		unit_pages = PHYS_PFN(vm->bbm.bb_size);
+	rc = memory_group_register_dynamic(vm->nid, unit_pages);
+	if (rc < 0)
+		goto out_del_resource;
+	vm->mgid = rc;
+
+	/*
+	 * If we still have memory plugged, we have to unplug all memory first.
+	 * Registering our parent resource makes sure that this memory isn't
+	 * actually in use (e.g., trying to reload the driver).
+	 */
+	if (vm->plugged_size) {
+		vm->unplug_all_required = true;
+		dev_info(&vm->vdev->dev, "unplugging all memory is required\n");
+	}
+
+	/* register callbacks */
+	vm->memory_notifier.notifier_call = virtio_mem_memory_notifier_cb;
+	rc = register_memory_notifier(&vm->memory_notifier);
+	if (rc)
+		goto out_unreg_group;
+	rc = register_virtio_mem_device(vm);
+	if (rc)
+		goto out_unreg_mem;
+
 	return 0;
+out_unreg_mem:
+	unregister_memory_notifier(&vm->memory_notifier);
+out_unreg_group:
+	memory_group_unregister(vm->mgid);
+out_del_resource:
+	virtio_mem_delete_resource(vm);
+	return rc;
 }
 
 static int virtio_mem_init(struct virtio_mem *vm)
@@ -2578,7 +2622,6 @@ static bool virtio_mem_has_memory_added(struct virtio_mem *vm)
 static int virtio_mem_probe(struct virtio_device *vdev)
 {
 	struct virtio_mem *vm;
-	uint64_t unit_pages;
 	int rc;
 
 	BUILD_BUG_ON(sizeof(struct virtio_mem_req) != 24);
@@ -2608,40 +2651,6 @@ static int virtio_mem_probe(struct virtio_device *vdev)
 	if (rc)
 		goto out_del_vq;
 
-	/* create the parent resource for all memory */
-	rc = virtio_mem_create_resource(vm);
-	if (rc)
-		goto out_del_vq;
-
-	/* use a single dynamic memory group to cover the whole memory device */
-	if (vm->in_sbm)
-		unit_pages = PHYS_PFN(memory_block_size_bytes());
-	else
-		unit_pages = PHYS_PFN(vm->bbm.bb_size);
-	rc = memory_group_register_dynamic(vm->nid, unit_pages);
-	if (rc < 0)
-		goto out_del_resource;
-	vm->mgid = rc;
-
-	/*
-	 * If we still have memory plugged, we have to unplug all memory first.
-	 * Registering our parent resource makes sure that this memory isn't
-	 * actually in use (e.g., trying to reload the driver).
-	 */
-	if (vm->plugged_size) {
-		vm->unplug_all_required = true;
-		dev_info(&vm->vdev->dev, "unplugging all memory is required\n");
-	}
-
-	/* register callbacks */
-	vm->memory_notifier.notifier_call = virtio_mem_memory_notifier_cb;
-	rc = register_memory_notifier(&vm->memory_notifier);
-	if (rc)
-		goto out_unreg_group;
-	rc = register_virtio_mem_device(vm);
-	if (rc)
-		goto out_unreg_mem;
-
 	virtio_device_ready(vdev);
 
 	/* trigger a config update to start processing the requested_size */
@@ -2649,12 +2658,6 @@ static int virtio_mem_probe(struct virtio_device *vdev)
 	queue_work(system_freezable_wq, &vm->wq);
 
 	return 0;
-out_unreg_mem:
-	unregister_memory_notifier(&vm->memory_notifier);
-out_unreg_group:
-	memory_group_unregister(vm->mgid);
-out_del_resource:
-	virtio_mem_delete_resource(vm);
 out_del_vq:
 	vdev->config->del_vqs(vdev);
 out_free_vm:
-- 
2.31.1



From xen-devel-bounces@lists.xenproject.org Tue Oct 05 12:19:01 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Oct 2021 12:19:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.202229.356941 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXjPR-0001kz-Jh; Tue, 05 Oct 2021 12:19:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 202229.356941; Tue, 05 Oct 2021 12:19:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXjPR-0001ks-Fm; Tue, 05 Oct 2021 12:19:01 +0000
Received: by outflank-mailman (input) for mailman id 202229;
 Tue, 05 Oct 2021 12:18:59 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=AOXf=OZ=redhat.com=david@srs-us1.protection.inumbo.net>)
 id 1mXjPP-0001aN-ML
 for xen-devel@lists.xenproject.org; Tue, 05 Oct 2021 12:18:59 +0000
Received: from us-smtp-delivery-124.mimecast.com (unknown [216.205.24.124])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTP
 id 7066099e-e735-4ad4-876f-d59bef785e30;
 Tue, 05 Oct 2021 12:18:53 +0000 (UTC)
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-227-gsUiOUynNDCjoMc0VGd1tw-1; Tue, 05 Oct 2021 08:18:52 -0400
Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com
 [10.5.11.23])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E764E802C88;
 Tue,  5 Oct 2021 12:18:49 +0000 (UTC)
Received: from t480s.redhat.com (unknown [10.39.193.58])
 by smtp.corp.redhat.com (Postfix) with ESMTP id 96EF41F41E;
 Tue,  5 Oct 2021 12:18:28 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7066099e-e735-4ad4-876f-d59bef785e30
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1633436333;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=R7+JUDG91uhwuwaeltTRSiOKiaWOQXIYAMDdQ0A5p1w=;
	b=ZbDOYmdJu9TiLDOd7Yq86CcbK/SfHmkpreLegtAAf9bNBZgeXbIcQmYZ9gQNt6JG6oIGcy
	fE86l2QbYpxm00OXvoyGIh3NUQ7gwBbfUx8ppdyexfclH2Qy63j8C5nFlxBUumC4Vpf9dh
	OlhfxZ11lFgx9dVpuvrESJ7aTxDGMzw=
X-MC-Unique: gsUiOUynNDCjoMc0VGd1tw-1
From: David Hildenbrand <david@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: David Hildenbrand <david@redhat.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Jason Wang <jasowang@redhat.com>,
	Dave Young <dyoung@redhat.com>,
	Baoquan He <bhe@redhat.com>,
	Vivek Goyal <vgoyal@redhat.com>,
	Michal Hocko <mhocko@suse.com>,
	Oscar Salvador <osalvador@suse.de>,
	Mike Rapoport <rppt@kernel.org>,
	"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
	x86@kernel.org,
	xen-devel@lists.xenproject.org,
	virtualization@lists.linux-foundation.org,
	kexec@lists.infradead.org,
	linux-fsdevel@vger.kernel.org,
	linux-mm@kvack.org
Subject: [PATCH v2 8/9] virtio-mem: factor out hotplug specifics from virtio_mem_remove() into virtio_mem_deinit_hotplug()
Date: Tue,  5 Oct 2021 14:14:29 +0200
Message-Id: <20211005121430.30136-9-david@redhat.com>
In-Reply-To: <20211005121430.30136-1-david@redhat.com>
References: <20211005121430.30136-1-david@redhat.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23

Let's prepare for a new virtio-mem kdump mode in which we don't actually
hot(un)plug any memory but only observe the state of device blocks.

Signed-off-by: David Hildenbrand <david@redhat.com>
---
 drivers/virtio/virtio_mem.c | 13 ++++++++++---
 1 file changed, 10 insertions(+), 3 deletions(-)

diff --git a/drivers/virtio/virtio_mem.c b/drivers/virtio/virtio_mem.c
index 1be3ee7f684d..76d8aef3cfd2 100644
--- a/drivers/virtio/virtio_mem.c
+++ b/drivers/virtio/virtio_mem.c
@@ -2667,9 +2667,8 @@ static int virtio_mem_probe(struct virtio_device *vdev)
 	return rc;
 }
 
-static void virtio_mem_remove(struct virtio_device *vdev)
+static void virtio_mem_deinit_hotplug(struct virtio_mem *vm)
 {
-	struct virtio_mem *vm = vdev->priv;
 	unsigned long mb_id;
 	int rc;
 
@@ -2716,7 +2715,8 @@ static void virtio_mem_remove(struct virtio_device *vdev)
 	 * away. Warn at least.
 	 */
 	if (virtio_mem_has_memory_added(vm)) {
-		dev_warn(&vdev->dev, "device still has system memory added\n");
+		dev_warn(&vm->vdev->dev,
+			 "device still has system memory added\n");
 	} else {
 		virtio_mem_delete_resource(vm);
 		kfree_const(vm->resource_name);
@@ -2730,6 +2730,13 @@ static void virtio_mem_remove(struct virtio_device *vdev)
 	} else {
 		vfree(vm->bbm.bb_states);
 	}
+}
+
+static void virtio_mem_remove(struct virtio_device *vdev)
+{
+	struct virtio_mem *vm = vdev->priv;
+
+	virtio_mem_deinit_hotplug(vm);
 
 	/* reset the device and cleanup the queues */
 	vdev->config->reset(vdev);
-- 
2.31.1



From xen-devel-bounces@lists.xenproject.org Tue Oct 05 12:19:39 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Oct 2021 12:19:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.202239.356952 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXjQ2-0002Od-V2; Tue, 05 Oct 2021 12:19:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 202239.356952; Tue, 05 Oct 2021 12:19:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXjQ2-0002OW-QC; Tue, 05 Oct 2021 12:19:38 +0000
Received: by outflank-mailman (input) for mailman id 202239;
 Tue, 05 Oct 2021 12:19:37 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=AOXf=OZ=redhat.com=david@srs-us1.protection.inumbo.net>)
 id 1mXjQ1-0002OK-Rg
 for xen-devel@lists.xenproject.org; Tue, 05 Oct 2021 12:19:37 +0000
Received: from us-smtp-delivery-124.mimecast.com (unknown [216.205.24.124])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTP
 id 817f64ce-25d6-11ec-bedc-12813bfff9fa;
 Tue, 05 Oct 2021 12:19:36 +0000 (UTC)
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-511-Q6nJ3M9xMvO3xKykIuWtCQ-1; Tue, 05 Oct 2021 08:19:35 -0400
Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com
 [10.5.11.23])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B72726D50A;
 Tue,  5 Oct 2021 12:19:32 +0000 (UTC)
Received: from t480s.redhat.com (unknown [10.39.193.58])
 by smtp.corp.redhat.com (Postfix) with ESMTP id 50F061F41E;
 Tue,  5 Oct 2021 12:18:50 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 817f64ce-25d6-11ec-bedc-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1633436376;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=iz/bJO8gGfz6X0Xatxi/OuCnSQ7Id+RJEaaGs0FeG00=;
	b=HXZYheV9k5PnHV40d2MYFcGwJhr25VVMdc9kOybnNm83aIrOyTCbKuIjak83GrRAZFZ0q9
	G3h5i3oKkp5wzYgzJB5Qb2iT22glfvuVARdZtf4nFu+7NXOvS+6ypxQ2oJoL5IuEhlnnWG
	f8d6akgOe5UEoBAFt/9EDXTPJiAHi+E=
X-MC-Unique: Q6nJ3M9xMvO3xKykIuWtCQ-1
From: David Hildenbrand <david@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: David Hildenbrand <david@redhat.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Jason Wang <jasowang@redhat.com>,
	Dave Young <dyoung@redhat.com>,
	Baoquan He <bhe@redhat.com>,
	Vivek Goyal <vgoyal@redhat.com>,
	Michal Hocko <mhocko@suse.com>,
	Oscar Salvador <osalvador@suse.de>,
	Mike Rapoport <rppt@kernel.org>,
	"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
	x86@kernel.org,
	xen-devel@lists.xenproject.org,
	virtualization@lists.linux-foundation.org,
	kexec@lists.infradead.org,
	linux-fsdevel@vger.kernel.org,
	linux-mm@kvack.org
Subject: [PATCH v2 9/9] virtio-mem: kdump mode to sanitize /proc/vmcore access
Date: Tue,  5 Oct 2021 14:14:30 +0200
Message-Id: <20211005121430.30136-10-david@redhat.com>
In-Reply-To: <20211005121430.30136-1-david@redhat.com>
References: <20211005121430.30136-1-david@redhat.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23

Although virtio-mem currently supports reading unplugged memory in the
hypervisor, this will change in the future, indicated to the device via
a new feature flag. We similarly sanitized /proc/kcore access recently. [1]

Let's register a vmcore callback, to allow vmcore code to check if a PFN
belonging to a virtio-mem device is either currently plugged and should
be dumped or is currently unplugged and should not be accessed, instead
mapping the shared zeropage or returning zeroes when reading.

This is important when not capturing /proc/vmcore via tools like
"makedumpfile" that can identify logically unplugged virtio-mem memory via
PG_offline in the memmap, but simply by e.g., copying the file.

Distributions that support virtio-mem+kdump have to make sure that the
virtio_mem module will be part of the kdump kernel or the kdump initrd;
dracut was recently [2] extended to include virtio-mem in the generated
initrd. As long as no special kdump kernels are used, this will
automatically make sure that virtio-mem will be around in the kdump initrd
and sanitize /proc/vmcore access -- with dracut.

With this series, we'll send one virtio-mem state request for every
~2 MiB chunk of virtio-mem memory indicated in the vmcore that we intend
to read/map.

In the future, we might want to allow building virtio-mem for kdump
mode only, even without CONFIG_MEMORY_HOTPLUG and friends: this way,
we could support special stripped-down kdump kernels that have many
other config options disabled; we'll tackle that once required. Further,
we might want to try sensing bigger blocks (e.g., memory sections)
first before falling back to device blocks on demand.

Tested with Fedora rawhide, which contains a recent kexec-tools version
(considering "System RAM (virtio_mem)" when creating the vmcore header) and
a recent dracut version (including the virtio_mem module in the kdump
initrd).

[1] https://lkml.kernel.org/r/20210526093041.8800-1-david@redhat.com
[2] https://github.com/dracutdevs/dracut/pull/1157

Signed-off-by: David Hildenbrand <david@redhat.com>
---
 drivers/virtio/virtio_mem.c | 136 ++++++++++++++++++++++++++++++++----
 1 file changed, 124 insertions(+), 12 deletions(-)

diff --git a/drivers/virtio/virtio_mem.c b/drivers/virtio/virtio_mem.c
index 76d8aef3cfd2..3573b78f6b05 100644
--- a/drivers/virtio/virtio_mem.c
+++ b/drivers/virtio/virtio_mem.c
@@ -223,6 +223,9 @@ struct virtio_mem {
 	 * When this lock is held the pointers can't change, ONLINE and
 	 * OFFLINE blocks can't change the state and no subblocks will get
 	 * plugged/unplugged.
+	 *
+	 * In kdump mode, used to serialize requests, last_block_addr and
+	 * last_block_plugged.
 	 */
 	struct mutex hotplug_mutex;
 	bool hotplug_active;
@@ -230,6 +233,9 @@ struct virtio_mem {
 	/* An error occurred we cannot handle - stop processing requests. */
 	bool broken;
 
+	/* Cached valued of is_kdump_kernel() when the device was probed. */
+	bool in_kdump;
+
 	/* The driver is being removed. */
 	spinlock_t removal_lock;
 	bool removing;
@@ -243,6 +249,13 @@ struct virtio_mem {
 	/* Memory notifier (online/offline events). */
 	struct notifier_block memory_notifier;
 
+#ifdef CONFIG_PROC_VMCORE
+	/* vmcore callback for /proc/vmcore handling in kdump mode */
+	struct vmcore_cb vmcore_cb;
+	uint64_t last_block_addr;
+	bool last_block_plugged;
+#endif /* CONFIG_PROC_VMCORE */
+
 	/* Next device in the list of virtio-mem devices. */
 	struct list_head next;
 };
@@ -2293,6 +2306,12 @@ static void virtio_mem_run_wq(struct work_struct *work)
 	uint64_t diff;
 	int rc;
 
+	if (unlikely(vm->in_kdump)) {
+		dev_warn_once(&vm->vdev->dev,
+			     "unexpected workqueue run in kdump kernel\n");
+		return;
+	}
+
 	hrtimer_cancel(&vm->retry_timer);
 
 	if (vm->broken)
@@ -2521,6 +2540,86 @@ static int virtio_mem_init_hotplug(struct virtio_mem *vm)
 	return rc;
 }
 
+#ifdef CONFIG_PROC_VMCORE
+static int virtio_mem_send_state_request(struct virtio_mem *vm, uint64_t addr,
+					 uint64_t size)
+{
+	const uint64_t nb_vm_blocks = size / vm->device_block_size;
+	const struct virtio_mem_req req = {
+		.type = cpu_to_virtio16(vm->vdev, VIRTIO_MEM_REQ_STATE),
+		.u.state.addr = cpu_to_virtio64(vm->vdev, addr),
+		.u.state.nb_blocks = cpu_to_virtio16(vm->vdev, nb_vm_blocks),
+	};
+	int rc = -ENOMEM;
+
+	dev_dbg(&vm->vdev->dev, "requesting state: 0x%llx - 0x%llx\n", addr,
+		addr + size - 1);
+
+	switch (virtio_mem_send_request(vm, &req)) {
+	case VIRTIO_MEM_RESP_ACK:
+		return virtio16_to_cpu(vm->vdev, vm->resp.u.state.state);
+	case VIRTIO_MEM_RESP_ERROR:
+		rc = -EINVAL;
+		break;
+	default:
+		break;
+	}
+
+	dev_dbg(&vm->vdev->dev, "requesting state failed: %d\n", rc);
+	return rc;
+}
+
+static bool virtio_mem_vmcore_pfn_is_ram(struct vmcore_cb *cb,
+					 unsigned long pfn)
+{
+	struct virtio_mem *vm = container_of(cb, struct virtio_mem,
+					     vmcore_cb);
+	uint64_t addr = PFN_PHYS(pfn);
+	bool is_ram;
+	int rc;
+
+	if (!virtio_mem_contains_range(vm, addr, PAGE_SIZE))
+		return true;
+	if (!vm->plugged_size)
+		return false;
+
+	/*
+	 * We have to serialize device requests and access to the information
+	 * about the block queried last.
+	 */
+	mutex_lock(&vm->hotplug_mutex);
+
+	addr = ALIGN_DOWN(addr, vm->device_block_size);
+	if (addr != vm->last_block_addr) {
+		rc = virtio_mem_send_state_request(vm, addr,
+						   vm->device_block_size);
+		/* On any kind of error, we're going to signal !ram. */
+		if (rc == VIRTIO_MEM_STATE_PLUGGED)
+			vm->last_block_plugged = true;
+		else
+			vm->last_block_plugged = false;
+		vm->last_block_addr = addr;
+	}
+
+	is_ram = vm->last_block_plugged;
+	mutex_unlock(&vm->hotplug_mutex);
+	return is_ram;
+}
+#endif /* CONFIG_PROC_VMCORE */
+
+static int virtio_mem_init_kdump(struct virtio_mem *vm)
+{
+#ifdef CONFIG_PROC_VMCORE
+	dev_info(&vm->vdev->dev, "memory hot(un)plug disabled in kdump kernel\n");
+	vm->vmcore_cb.pfn_is_ram = virtio_mem_vmcore_pfn_is_ram;
+	register_vmcore_cb(&vm->vmcore_cb);
+	return 0;
+#else /* CONFIG_PROC_VMCORE */
+	dev_warn(&vm->vdev->dev, "disabled in kdump kernel without vmcore\n");
+	return -EBUSY;
+#endif /* CONFIG_PROC_VMCORE */
+}
+
 static int virtio_mem_init(struct virtio_mem *vm)
 {
 	uint16_t node_id;
@@ -2530,15 +2629,6 @@ static int virtio_mem_init(struct virtio_mem *vm)
 		return -EINVAL;
 	}
 
-	/*
-	 * We don't want to (un)plug or reuse any memory when in kdump. The
-	 * memory is still accessible (but not mapped).
-	 */
-	if (is_kdump_kernel()) {
-		dev_warn(&vm->vdev->dev, "disabled in kdump kernel\n");
-		return -EBUSY;
-	}
-
 	/* Fetch all properties that can't change. */
 	virtio_cread_le(vm->vdev, struct virtio_mem_config, plugged_size,
 			&vm->plugged_size);
@@ -2562,6 +2652,12 @@ static int virtio_mem_init(struct virtio_mem *vm)
 	if (vm->nid != NUMA_NO_NODE && IS_ENABLED(CONFIG_NUMA))
 		dev_info(&vm->vdev->dev, "nid: %d", vm->nid);
 
+	/*
+	 * We don't want to (un)plug or reuse any memory when in kdump. The
+	 * memory is still accessible (but not exposed to Linux).
+	 */
+	if (vm->in_kdump)
+		return virtio_mem_init_kdump(vm);
 	return virtio_mem_init_hotplug(vm);
 }
 
@@ -2640,6 +2736,7 @@ static int virtio_mem_probe(struct virtio_device *vdev)
 	hrtimer_init(&vm->retry_timer, CLOCK_MONOTONIC, HRTIMER_MODE_REL);
 	vm->retry_timer.function = virtio_mem_timer_expired;
 	vm->retry_timer_ms = VIRTIO_MEM_RETRY_TIMER_MIN_MS;
+	vm->in_kdump = is_kdump_kernel();
 
 	/* register the virtqueue */
 	rc = virtio_mem_init_vq(vm);
@@ -2654,8 +2751,10 @@ static int virtio_mem_probe(struct virtio_device *vdev)
 	virtio_device_ready(vdev);
 
 	/* trigger a config update to start processing the requested_size */
-	atomic_set(&vm->config_changed, 1);
-	queue_work(system_freezable_wq, &vm->wq);
+	if (!vm->in_kdump) {
+		atomic_set(&vm->config_changed, 1);
+		queue_work(system_freezable_wq, &vm->wq);
+	}
 
 	return 0;
 out_del_vq:
@@ -2732,11 +2831,21 @@ static void virtio_mem_deinit_hotplug(struct virtio_mem *vm)
 	}
 }
 
+static void virtio_mem_deinit_kdump(struct virtio_mem *vm)
+{
+#ifdef CONFIG_PROC_VMCORE
+	unregister_vmcore_cb(&vm->vmcore_cb);
+#endif /* CONFIG_PROC_VMCORE */
+}
+
 static void virtio_mem_remove(struct virtio_device *vdev)
 {
 	struct virtio_mem *vm = vdev->priv;
 
-	virtio_mem_deinit_hotplug(vm);
+	if (vm->in_kdump)
+		virtio_mem_deinit_kdump(vm);
+	else
+		virtio_mem_deinit_hotplug(vm);
 
 	/* reset the device and cleanup the queues */
 	vdev->config->reset(vdev);
@@ -2750,6 +2859,9 @@ static void virtio_mem_config_changed(struct virtio_device *vdev)
 {
 	struct virtio_mem *vm = vdev->priv;
 
+	if (unlikely(vm->in_kdump))
+		return;
+
 	atomic_set(&vm->config_changed, 1);
 	virtio_mem_retry(vm);
 }
-- 
2.31.1



From xen-devel-bounces@lists.xenproject.org Tue Oct 05 13:32:14 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Oct 2021 13:32:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.202260.356963 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXkXW-0001mf-GP; Tue, 05 Oct 2021 13:31:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 202260.356963; Tue, 05 Oct 2021 13:31:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXkXW-0001mY-DO; Tue, 05 Oct 2021 13:31:26 +0000
Received: by outflank-mailman (input) for mailman id 202260;
 Tue, 05 Oct 2021 13:31:24 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=KREk=OZ=invisiblethingslab.com=marmarek@srs-us1.protection.inumbo.net>)
 id 1mXkXU-0001mS-FU
 for xen-devel@lists.xenproject.org; Tue, 05 Oct 2021 13:31:24 +0000
Received: from out4-smtp.messagingengine.com (unknown [66.111.4.28])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 63476c89-b322-45e5-9025-cb584fd792b7;
 Tue, 05 Oct 2021 13:31:23 +0000 (UTC)
Received: from compute4.internal (compute4.nyi.internal [10.202.2.44])
 by mailout.nyi.internal (Postfix) with ESMTP id 3AB285C026A;
 Tue,  5 Oct 2021 09:31:23 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute4.internal (MEProxy); Tue, 05 Oct 2021 09:31:23 -0400
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue,
 5 Oct 2021 09:31:22 -0400 (EDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 63476c89-b322-45e5-9025-cb584fd792b7
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:content-type:date:from:in-reply-to
	:message-id:mime-version:references:subject:to:x-me-proxy
	:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=EivQqt
	+HIo/wojGUEcP7IuAFUMmltKJUbP1xgnBaQeU=; b=Ka1DWS4GDKhLKbThzTImqa
	nWFLSWeI1Gh/YvH08FjeDsr4LqwlVVUGKzbCRJLLA15tfNVbPnB1m6CCT4VSYFiG
	UXRGOgcG7EmXuyL02tXfIHa0rYFLrJuLVZl7xk29N08GG7lUUovHdWDrVZRhjOk+
	BRDZSSyPDulOASEIKRYaJklVweYjNIBWU0K5KG2YcHoDZDESs5zDPmAEtdaFMoqI
	kl2VP1YmYmsCwyq0aujTLO+1hMwaTyu4XFdCghRHoRv6noHNITyIRAY8yhXqrZDs
	/bFwu53R908FN0GXEW2NVyqSRYD/XMO7k/+rZnZkITPU3po41w/qlBUz1ReCsTNQ
	==
X-ME-Sender: <xms:q1NcYSgGo3j8j-yyTflY9TBS4Xh2aMmZVJP3WGJ1UuQWFCM7zzWJ0Q>
    <xme:q1NcYTCrx3nMF1V0KEoby3FuV2wDzz850nT6ZYi-CYdgM94hzr8a7YkxJURggPXKi
    Y_0RTE__xqIKA>
X-ME-Received: <xmr:q1NcYaFbcaVOcA_akfpPwwUpI074ragm8NJ-S87deb9s_BSXB4TBgl_2QoXPzzkBkWFomMUqSt-HjMzPq2X1S-HSm5fhT0Yk>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrudelgedgieehucetufdoteggodetrfdotf
    fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
    uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
    cujfgurhepfffhvffukfhfgggtuggjsehgtderredttdejnecuhfhrohhmpeforghrvghk
    ucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesihhnvh
    hishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpeetveff
    iefghfekhffggeeffffhgeevieektedthfehveeiheeiiedtudegfeetffenucevlhhush
    htvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrghrmhgrrhgvkhes
    ihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm
X-ME-Proxy: <xmx:q1NcYbQV5qT4sNUfka_It223WyqTP1zP4K-r2PMfE-qZeEXK2e1KGA>
    <xmx:q1NcYfy5qkMs6UO_zzihGXQgXggsvPArM0SOpJqPogF_l3xKWuss5Q>
    <xmx:q1NcYZ40ALBb65Zax9A6-QI6eq56fzcdtvZc0tLj7LE8t10x4Ta6vA>
    <xmx:q1NcYdbrFyEHIRsi0G7mCovyA4F7c9XUG46AEnQTEp-Crcqez0dGvg>
Date: Tue, 5 Oct 2021 15:31:18 +0200
From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
To: Juergen Gross <jgross@suse.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>,
	Jan Beulich <jbeulich@suse.com>
Subject: Re: xen-balloon thread using 100% of CPU, regression in 5.4.150
Message-ID: <YVxTp9rWmxv0wYBl@mail-itl>
References: <YVk11h2l/u4GJNv0@mail-itl>
 <37c22c61-80be-fc48-18e6-2b1ee22cc765@suse.com>
 <YVrF65BAVsXTgRsd@mail-itl>
 <f707c956-6cdc-9b32-5f22-227e0f5a9f10@suse.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="TQOmFEmeMsC7xW5m"
Content-Disposition: inline
In-Reply-To: <f707c956-6cdc-9b32-5f22-227e0f5a9f10@suse.com>


--TQOmFEmeMsC7xW5m
Content-Type: text/plain; protected-headers=v1; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Date: Tue, 5 Oct 2021 15:31:18 +0200
From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
To: Juergen Gross <jgross@suse.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>,
	Jan Beulich <jbeulich@suse.com>
Subject: Re: xen-balloon thread using 100% of CPU, regression in 5.4.150

On Tue, Oct 05, 2021 at 10:05:39AM +0200, Juergen Gross wrote:
> On 04.10.21 11:14, Marek Marczykowski-G=C3=B3recki wrote:
> > On Mon, Oct 04, 2021 at 07:31:40AM +0200, Juergen Gross wrote:
> > > On 03.10.21 06:47, Marek Marczykowski-G=C3=B3recki wrote:
> > > > Hi,
> > > >=20
> > > > After updating a PVH domU to 5.4.150, I see xen-balloon thread using
> > > > 100% CPU (one thread).
> > > > This is a domain started with memory=3Dmaxmem=3D716800KiB (via libv=
irt). Then,
> > > > inside, I see:
> > > >=20
> > > > # cat /sys/devices/system/xen_memory/xen_memory0/target_kb
> > > > 716924
> > > > # cat /sys/devices/system/xen_memory/xen_memory0/info/current_kb
> > > > 716400
> > > >=20
> > > > Doing `cat info/current_kb > target_kb` "fixes" the issue. But stil=
l,
> > > > something is wrong - on earlier kernel (5.4.143 to be precise), it
> > > > wasn't spinning, with exactly the same values reported in sysfs. It
> > > > shouldn't run in circles if it can't get that much memory it wants.=
 I
> > > > strongly suspect "xen/balloon: use a kernel thread instead a workqu=
eue"
> > > > or related commit being responsible, but I haven't verified it.
> > >=20
> > > I think you are right. I need to handle the BP_ECANCELED case similar=
 to
> > > BP_EAGAIN in the kernel thread (wait until target size changes again).
> > >=20
> > > One further question: do you see any kernel message in the guest rela=
ted
> > > to the looping balloon thread?
> >=20
> > Nothing, only the usual "xen:balloon: Initialising balloon driver", and
> > nothing related to balloon after that.
>=20
> Could you try the attached patch, please? I've tested it briefly with
> PV and PVH guests.

Yes, it helps, thanks!

--=20
Best Regards,
Marek Marczykowski-G=C3=B3recki
Invisible Things Lab

--TQOmFEmeMsC7xW5m
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmFcU6cACgkQ24/THMrX
1yxjTQf/aW3yKfiquu0qMc5bvmbmqXYSY8D57IP9xJ9/Ft2hciEkjWs5MgmgogWL
yr76bR1G3WIxZ2YT2lPg6JfBVPgPCkTgDVGW5fyPKcxAh0Fpk/3K0+a3c5zf3c06
iUlZ0zWFydpOayntOfYw1ZBlaHbIdZHvDDceYBv8NSLhoN7qcx12xbWcwKlA7uGh
Gs+Vj0MqlMrD52XeloXRQ51Wpr5rnxgyT9E0/NXFZWI6DOSnbDxVL2Npm60qm8BO
EZxfcyvmKgKNpm98CwoPveNja8tU90GuyHEmgJDRE8m6bPUIou15xmM/qBJlJ/Da
uWTW/W7xu3+fX46e4MPsqlqjf2Jx6A==
=CeFV
-----END PGP SIGNATURE-----

--TQOmFEmeMsC7xW5m--


From xen-devel-bounces@lists.xenproject.org Tue Oct 05 13:33:31 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Oct 2021 13:33:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.202266.356973 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXkZW-0002Mn-TS; Tue, 05 Oct 2021 13:33:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 202266.356973; Tue, 05 Oct 2021 13:33:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXkZW-0002Mg-QV; Tue, 05 Oct 2021 13:33:30 +0000
Received: by outflank-mailman (input) for mailman id 202266;
 Tue, 05 Oct 2021 13:33:28 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=TbO2=OZ=gmail.com=jandryuk@srs-us1.protection.inumbo.net>)
 id 1mXkZU-0002Ma-P9
 for xen-devel@lists.xenproject.org; Tue, 05 Oct 2021 13:33:28 +0000
Received: from mail-lf1-x130.google.com (unknown [2a00:1450:4864:20::130])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 25695209-8304-4eda-96e6-5ebfba86cdd0;
 Tue, 05 Oct 2021 13:33:27 +0000 (UTC)
Received: by mail-lf1-x130.google.com with SMTP id y26so86832756lfa.11
 for <xen-devel@lists.xenproject.org>; Tue, 05 Oct 2021 06:33:27 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 25695209-8304-4eda-96e6-5ebfba86cdd0
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc:content-transfer-encoding;
        bh=kbkSIdI1lyS2W09DNPfwYlXTbieduSGKbyFZ93KqqAs=;
        b=pDoJSSg5iakHHKAAAfAYAauByvpCLMHi5WE0ed2GuuK1e83hL+zne9yWU9yABINO34
         1BvFGV21d0zS8s9HPBNsjZ8XTE5I1scTB/f6/FtoRlgu3czT/3ny+wiAY7GEVvzorTGj
         dq7GkJBGVBECH201hvsKs78KySNKtLZR+XTqGuW15Ev4Ang64Q7IQop4/7MXojk8KndC
         iAB96yxEfPRXoHZg8h3a/ytObmMl8IhK369u56GzzxI4r67KxJ9EprgWZ3FcfForxE1l
         6Exf8P49x39hB88v8OQH4kIk9c0Z5KqCGtwrcpqn1wlglY0qA/VLQYGh8dMk59/IC2Jv
         /x5A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc:content-transfer-encoding;
        bh=kbkSIdI1lyS2W09DNPfwYlXTbieduSGKbyFZ93KqqAs=;
        b=ezBbHa49p5tW8YkWHY6HfzCWSoUJ2netBleCog+MPcishMtY6M2/R8DoqUn2CHvaPN
         945lj4GoBWcbsKlZRuU1y0AvCemRcqzRoSZgO6G4mz+2gHnB/j8kA7h1XJqIjVrCq3mq
         fXiqKoAQg3LjAWHfuAfx0h2hDFYnrpUCGGpBjyoLu2zmhhR8MxKaodsNSdTnijoTtXgZ
         tHtukACGIrZ1Uey2hyXrT/RKq41vTNlOKmtgimP5dMY4tDLV5L8DPGoPhq4jS7KJ8qnP
         ACa74sbj4msryJWxo2lbBP/jmjMoedSRi3F38zccF4Kn7jUe4L5/EdaJGpknlekuW5Si
         IowA==
X-Gm-Message-State: AOAM5302Z20ZXRqIL6ZB8yIi98jzLUiM0nVQQYwy6/r7fzYCdGFDDC54
	7Si1aEWT8Oeu9PeFfaEQbkhW7OISsoNIDlsshhs=
X-Google-Smtp-Source: ABdhPJyo/6SU5wHwI/RDnvtlZJRGLqPhsFcVH4Pb+jrzEbBDFrxYp4EMFF/7hET/brDEEP0F4/XW5SL01mm122nZDUE=
X-Received: by 2002:a05:6512:2287:: with SMTP id f7mr3595653lfu.250.1633440806864;
 Tue, 05 Oct 2021 06:33:26 -0700 (PDT)
MIME-Version: 1.0
References: <YVk11h2l/u4GJNv0@mail-itl> <37c22c61-80be-fc48-18e6-2b1ee22cc765@suse.com>
 <YVrF65BAVsXTgRsd@mail-itl> <f707c956-6cdc-9b32-5f22-227e0f5a9f10@suse.com>
In-Reply-To: <f707c956-6cdc-9b32-5f22-227e0f5a9f10@suse.com>
From: Jason Andryuk <jandryuk@gmail.com>
Date: Tue, 5 Oct 2021 09:33:15 -0400
Message-ID: <CAKf6xpsJT7-6A4CjE6_mvpuNJUhPKY4fBkU4zS9xYry47dWAKw@mail.gmail.com>
Subject: Re: xen-balloon thread using 100% of CPU, regression in 5.4.150
To: Juergen Gross <jgross@suse.com>
Cc: =?UTF-8?Q?Marek_Marczykowski=2DG=C3=B3recki?= <marmarek@invisiblethingslab.com>, 
	xen-devel <xen-devel@lists.xenproject.org>, Jan Beulich <jbeulich@suse.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Oct 5, 2021 at 4:05 AM Juergen Gross <jgross@suse.com> wrote:
>
> On 04.10.21 11:14, Marek Marczykowski-G=C3=B3recki wrote:
> > On Mon, Oct 04, 2021 at 07:31:40AM +0200, Juergen Gross wrote:
> >> On 03.10.21 06:47, Marek Marczykowski-G=C3=B3recki wrote:
> >>> Hi,
> >>>
> >>> After updating a PVH domU to 5.4.150, I see xen-balloon thread using
> >>> 100% CPU (one thread).
> >>> This is a domain started with memory=3Dmaxmem=3D716800KiB (via libvir=
t). Then,
> >>> inside, I see:
> >>>
> >>> # cat /sys/devices/system/xen_memory/xen_memory0/target_kb
> >>> 716924
> >>> # cat /sys/devices/system/xen_memory/xen_memory0/info/current_kb
> >>> 716400
> >>>
> >>> Doing `cat info/current_kb > target_kb` "fixes" the issue. But still,
> >>> something is wrong - on earlier kernel (5.4.143 to be precise), it
> >>> wasn't spinning, with exactly the same values reported in sysfs. It
> >>> shouldn't run in circles if it can't get that much memory it wants. I
> >>> strongly suspect "xen/balloon: use a kernel thread instead a workqueu=
e"
> >>> or related commit being responsible, but I haven't verified it.
> >>
> >> I think you are right. I need to handle the BP_ECANCELED case similar =
to
> >> BP_EAGAIN in the kernel thread (wait until target size changes again).
> >>
> >> One further question: do you see any kernel message in the guest relat=
ed
> >> to the looping balloon thread?
> >
> > Nothing, only the usual "xen:balloon: Initialising balloon driver", and
> > nothing related to balloon after that.
>
> Could you try the attached patch, please? I've tested it briefly with
> PV and PVH guests.

I was seeing the CPU spinning in dom0 with xen command line:
dom0_mem=3Dmin:420M,max:420M,420M

Your patch eliminated the CPU spinning.

Tested-by: Jason Andryuk <jandryuk@gmail.com>

Thanks, Juergen

-Jason


From xen-devel-bounces@lists.xenproject.org Tue Oct 05 13:34:38 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Oct 2021 13:34:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.202273.356985 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXkac-0002zv-7W; Tue, 05 Oct 2021 13:34:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 202273.356985; Tue, 05 Oct 2021 13:34:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXkac-0002zo-4S; Tue, 05 Oct 2021 13:34:38 +0000
Received: by outflank-mailman (input) for mailman id 202273;
 Tue, 05 Oct 2021 13:34:37 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=/jnY=OZ=suse.com=jgross@srs-us1.protection.inumbo.net>)
 id 1mXkab-0002ze-8J
 for xen-devel@lists.xenproject.org; Tue, 05 Oct 2021 13:34:37 +0000
Received: from smtp-out2.suse.de (unknown [195.135.220.29])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 2b68957c-58fc-44b2-a12c-7d1a9f5ec69e;
 Tue, 05 Oct 2021 13:34:36 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 9BBDF20028;
 Tue,  5 Oct 2021 13:34:35 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 6487D13C35;
 Tue,  5 Oct 2021 13:34:35 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id a1xEF2tUXGHnDwAAMHmgww
 (envelope-from <jgross@suse.com>); Tue, 05 Oct 2021 13:34:35 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2b68957c-58fc-44b2-a12c-7d1a9f5ec69e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1633440875; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding;
	bh=muVpN94mowz5PNDdbHLdWMwCxQCzzIFQLh6tPGkXOCw=;
	b=WB084CpVgo7IVkufWcK3GX0mN37NTIXQAwwmpfy8mfvZjcDCTnJJph90jEaoPJ8gs6E5BO
	s7Z+YiKqhftnBIOnEtwSjw6L/5HUFyKN3dBids+HBSzO8WlZAQPyLKQ8bJBkW6WBWRx9Qa
	iO4ZxJ64g3GTX589cF6hqBGZ96qyPzc=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org,
	linux-kernel@vger.kernel.org
Cc: Juergen Gross <jgross@suse.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	stable@vger.kernel.org,
	=?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
Subject: [PATCH] xen/balloon: fix cancelled balloon action
Date: Tue,  5 Oct 2021 15:34:33 +0200
Message-Id: <20211005133433.32008-1-jgross@suse.com>
X-Mailer: git-send-email 2.26.2
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

In case a ballooning action is cancelled the new kernel thread handling
the ballooning might end up in a busy loop.

Fix that by handling the cancelled action gracefully.

While at it introduce a short wait for the BP_WAIT case.

Cc: stable@vger.kernel.org
Fixes: 8480ed9c2bbd56 ("xen/balloon: use a kernel thread instead a workqueue")
Reported-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
Signed-off-by: Juergen Gross <jgross@suse.com>
---
 drivers/xen/balloon.c | 21 +++++++++++++++------
 1 file changed, 15 insertions(+), 6 deletions(-)

diff --git a/drivers/xen/balloon.c b/drivers/xen/balloon.c
index 43ebfe36ac27..3a50f097ed3e 100644
--- a/drivers/xen/balloon.c
+++ b/drivers/xen/balloon.c
@@ -491,12 +491,12 @@ static enum bp_state decrease_reservation(unsigned long nr_pages, gfp_t gfp)
 }
 
 /*
- * Stop waiting if either state is not BP_EAGAIN and ballooning action is
- * needed, or if the credit has changed while state is BP_EAGAIN.
+ * Stop waiting if either state is BP_DONE and ballooning action is
+ * needed, or if the credit has changed while state is not BP_DONE.
  */
 static bool balloon_thread_cond(enum bp_state state, long credit)
 {
-	if (state != BP_EAGAIN)
+	if (state == BP_DONE)
 		credit = 0;
 
 	return current_credit() != credit || kthread_should_stop();
@@ -516,10 +516,19 @@ static int balloon_thread(void *unused)
 
 	set_freezable();
 	for (;;) {
-		if (state == BP_EAGAIN)
-			timeout = balloon_stats.schedule_delay * HZ;
-		else
+		switch (state) {
+		case BP_DONE:
+		case BP_ECANCELED:
 			timeout = 3600 * HZ;
+			break;
+		case BP_EAGAIN:
+			timeout = balloon_stats.schedule_delay * HZ;
+			break;
+		case BP_WAIT:
+			timeout = HZ;
+			break;
+		}
+
 		credit = current_credit();
 
 		wait_event_freezable_timeout(balloon_thread_wq,
-- 
2.26.2



From xen-devel-bounces@lists.xenproject.org Tue Oct 05 18:07:35 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Oct 2021 18:07:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.202287.356995 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXoqW-00039K-N9; Tue, 05 Oct 2021 18:07:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 202287.356995; Tue, 05 Oct 2021 18:07:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXoqW-00039D-KL; Tue, 05 Oct 2021 18:07:20 +0000
Received: by outflank-mailman (input) for mailman id 202287;
 Tue, 05 Oct 2021 18:07:20 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mXoqV-000393-VC; Tue, 05 Oct 2021 18:07:19 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mXoqV-0001B8-Pe; Tue, 05 Oct 2021 18:07:19 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mXoqV-0006Ct-Fy; Tue, 05 Oct 2021 18:07:19 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mXoqV-0002wJ-FP; Tue, 05 Oct 2021 18:07:19 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=KJ6WQoQolZ7EzykfvWe8jqPhGlAr3WJBQXyA9R8bVtY=; b=Wy3lYgu57ZVl2BzI+rHs/XcPpk
	08L2/JFTJYatWkabMKjl51udb4xDq1RaXXaGWTg/wob9kUq/3zcP6wa2OtblwZLdaEKtCq65JzKwH
	EVjKdLcuJI97cnY2HrlaUQkwUsB5Lrm6sB/aiplfNNbQN9fMtSCJJWKdlkUMw2MrNSxE=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165377-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 165377: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=c49cb8f30e6223dc6b55903af178afa1dfde857f
X-Osstest-Versions-That:
    ovmf=4cc1458dbe004b1d70534caa55f475f6d19fe14a
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 05 Oct 2021 18:07:19 +0000

flight 165377 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165377/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 c49cb8f30e6223dc6b55903af178afa1dfde857f
baseline version:
 ovmf                 4cc1458dbe004b1d70534caa55f475f6d19fe14a

Last test of basis   165347  2021-10-04 12:43:18 Z    1 days
Testing same since   165377  2021-10-05 09:40:15 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Nhi Pham <nhi@os.amperecomputing.com>
  Rebecca Cran <rebecca@nuviainc.com>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   4cc1458dbe..c49cb8f30e  c49cb8f30e6223dc6b55903af178afa1dfde857f -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Tue Oct 05 18:39:09 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Oct 2021 18:39:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.202295.357010 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXpLB-0006RY-7b; Tue, 05 Oct 2021 18:39:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 202295.357010; Tue, 05 Oct 2021 18:39:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXpLB-0006RR-3y; Tue, 05 Oct 2021 18:39:01 +0000
Received: by outflank-mailman (input) for mailman id 202295;
 Tue, 05 Oct 2021 18:39:00 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mXpLA-0006RH-35; Tue, 05 Oct 2021 18:39:00 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mXpL9-0001iI-Oc; Tue, 05 Oct 2021 18:38:59 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mXpL9-00082Q-ED; Tue, 05 Oct 2021 18:38:59 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mXpL9-0007Nz-Di; Tue, 05 Oct 2021 18:38:59 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=JSROLyZuGQJ7No+y8YGVM13g7RMS3qrPF8MmvYLKEG0=; b=cq61DSQyue+Rl7jHn6838wtHNU
	2kmQ4y9llnSy2VzgpHMz2zbZdpKW/2tJhVc/LEEk4nZOPqQgxEmS+80KEfYz47kLUM41V17lYSx1m
	7cSZq6aeY+1sSRdKosNDHBqYrFNxVpi5J/kp9MBWS953dnjV4hxbob4lJAKFR9N4ty0A=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165371-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 165371: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-unstable:test-amd64-i386-xl-shadow:guest-localmigrate:fail:heisenbug
    xen-unstable:test-arm64-arm64-libvirt-raw:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=b6fe410936e30b2089cc8c6d54d786e535efafa3
X-Osstest-Versions-That:
    xen=c76cfada1cfad05aaf64ce3ad305c5467650e782
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 05 Oct 2021 18:38:59 +0000

flight 165371 xen-unstable real [real]
flight 165381 xen-unstable real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/165371/
http://logs.test-lab.xenproject.org/osstest/logs/165381/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-i386-xl-shadow    18 guest-localmigrate  fail pass in 165381-retest
 test-arm64-arm64-libvirt-raw 17 guest-start/debian.repeat fail pass in 165381-retest

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 164945
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 164945
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 164945
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 164945
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 164945
 test-armhf-armhf-xl-rtds     18 guest-start/debian.repeat    fail  like 164945
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 164945
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 164945
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 164945
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 164945
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 164945
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 164945
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 164945
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  b6fe410936e30b2089cc8c6d54d786e535efafa3
baseline version:
 xen                  c76cfada1cfad05aaf64ce3ad305c5467650e782

Last test of basis   164945  2021-09-10 21:23:48 Z   24 days
Failing since        164951  2021-09-12 00:14:36 Z   23 days   38 attempts
Testing same since   165371  2021-10-05 02:16:48 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Anthony PERARD <anthony.perard@citrix.com>
  Anthony PERARD <anthony.perard@gmail.com>
  Bertrand Marquis <bertrand.marquis@arm.com>
  Daniel P. Smith <dpsmith@apertussolutions.com>
  Ian Jackson <iwj@xenproject.org>
  Igor Druzhinin <igor.druzhinin@citrix.com>
  Jan Beulich <jbeulich@suse.com>
  Juergen Gross <jgross@suse.com>
  Julien Grall <jgrall@amazon.com>
  Kevin Stefanov <kevin.stefanov@citrix.com>
  Luca Fancellu <luca.fancellu@arm.com>
  Nick Rosbrook <rosbrookn@ainfosec.com>
  Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
  Penny Zheng <penny.zheng@arm.com>
  Rahul Singh <rahul.singh@arm.com>
  Roger Pau Monne <roger.pau@citrix.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Stefano Stabellini <sstabellini@kernel.org>
  Stefano Stabellini <stefano.stabellini@xilinx.com>
  Tamas K Lengyel <tamas.lengyel@intel.com>
  Wei Chen <wei.chen@arm.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 fail    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    fail    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   c76cfada1c..b6fe410936  b6fe410936e30b2089cc8c6d54d786e535efafa3 -> master


From xen-devel-bounces@lists.xenproject.org Tue Oct 05 18:43:30 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Oct 2021 18:43:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.202310.357059 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXpPV-0000Ge-Nx; Tue, 05 Oct 2021 18:43:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 202310.357059; Tue, 05 Oct 2021 18:43:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXpPV-0000GQ-K6; Tue, 05 Oct 2021 18:43:29 +0000
Received: by outflank-mailman (input) for mailman id 202310;
 Tue, 05 Oct 2021 18:43:28 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=zUp0=OZ=xenbits.xen.org=iwj@srs-us1.protection.inumbo.net>)
 id 1mXpPU-0007sp-6j
 for xen-devel@lists.xen.org; Tue, 05 Oct 2021 18:43:28 +0000
Received: from mail.xenproject.org (unknown [104.130.215.37])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id c7faa338-6ff0-4ce1-8566-34655533685a;
 Tue, 05 Oct 2021 18:43:16 +0000 (UTC)
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenbits.xen.org>)
 id 1mXpPC-0001na-3a; Tue, 05 Oct 2021 18:43:10 +0000
Received: from iwj by xenbits.xenproject.org with local (Exim 4.92)
 (envelope-from <iwj@xenbits.xen.org>)
 id 1mXpPC-0006vg-20; Tue, 05 Oct 2021 18:43:10 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c7faa338-6ff0-4ce1-8566-34655533685a
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Date:Message-Id:Subject:CC:From:To:MIME-Version:
	Content-Transfer-Encoding:Content-Type;
	bh=tfi/3QwQXxxrSN8ZOEpf0N6gSqkc9mlvL65nLRNcV9Y=; b=4Xv/9z2YWtWV1lA5qeAWpVtPNQ
	5K6Zq8UEV8nWtHoISUY5o5Ad0avsVPp+/zKMOwnrN7aQ4pK7yN3USz9sHwwLr0yC/NRBt04PfNNMQ
	oxh5eJlwbfCP2baa4EEHoPfnd9pJzxkofsK1zRuc03Pog9Vc1IdaTRHgjcgCN+40Y4iw=;
Content-Type: multipart/mixed; boundary="=separator"; charset="utf-8"
Content-Transfer-Encoding: binary
MIME-Version: 1.0
X-Mailer: MIME-tools 5.509 (Entity 5.509)
To: xen-announce@lists.xen.org, xen-devel@lists.xen.org,
 xen-users@lists.xen.org, oss-security@lists.openwall.com
From: Xen.org security team <security@xen.org>
CC: Xen.org security team <security-team-members@xen.org>
Subject: Xen Security Advisory 386 v1 (CVE-2021-28702) - PCI devices with
 RMRRs not deassigned correctly
Message-Id: <E1mXpPC-0006vg-20@xenbits.xenproject.org>
Date: Tue, 05 Oct 2021 18:43:10 +0000

--=separator
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

            Xen Security Advisory CVE-2021-28702 / XSA-386

            PCI devices with RMRRs not deassigned correctly

ISSUE DESCRIPTION
=================

Certain PCI devices in a system might be assigned Reserved Memory
Regions (specified via Reserved Memory Region Reporting, "RMRR").
These are typically used for platform tasks such as legacy USB
emulation.

If such a device is passed through to a guest, then on guest shutdown
the device is not properly deassigned.  The IOMMU configuration for
these devices which are not properly deassigned ends up pointing to a
freed data structure, including the IO Pagetables.

Subsequent DMA or interrupts from the device will have unpredictable
behaviour, ranging from IOMMU faults to memory corruption.

IMPACT
======

Administrators of guests which have been assigned RMRR-using PCI
devices can cause denial of service and other problems, possibly
including escalation of privilege.

VULNERABLE SYSTEMS
==================

All versions of Xen from at least 4.4 onwards are vulnerable.

Only Intel x86 systems are affected.  AMD x86 systems, and Arm
systems, are all unaffected.

Only systems using PCI passthrough are affected.  (And then, only if
the assigned devices have RMRRs, but whether a device advertises RMRRs
is not easy to discern.)

MITIGATION
==========

There is no mitigation (other than not passing through PCI devices
with RMRRs to guests).

RESOLUTION
==========

Applying the appropriate attached patch resolves this issue.

Note that patches for released versions are generally prepared to
apply to the stable branches, and may not apply cleanly to the most
recent release tarball.  Downstreams are encouraged to update to the
tip of the stable branch before applying these patches.

xsa386.patch           xen-unstable - Xen 4.12.x

$ sha256sum xsa386*
f2f83c825e249bba9454437b48bbd8307fe7a224f56484388a67af124dfd279b  xsa386.patch
$

NOTE CONCERNING LACK OF EMBARGO
===============================

This issue was reported and debugged in public before the security nature
became apparent.
-----BEGIN PGP SIGNATURE-----

iQFABAEBCAAqFiEEI+MiLBRfRHX6gGCng/4UyVfoK9kFAmFcnH8MHHBncEB4ZW4u
b3JnAAoJEIP+FMlX6CvZje0H+QE5A0ZvoaJ5VupZYjAt5ynbQjVqxwxqAxZDTvP7
t3gtpsHSYgrHW+3giULxjGU0ZUGF9daO1JEIZCPCbUdIlmGqGEXdDoqtz0GrXCJJ
swQFeXQVmn9lV4KMTHO0BvGw5aZOft1VgGNrixd3vckFl7c5G8sWFdl7IU7FPDTQ
LiLMg6f1oOntBYjNZUZ2210jqct9GZ4ugURRufwZrwYIpc9H5pFnZAFHKismX/2m
x/PCdmOCeivytmUPA4k62oJVpJdysAL+31XkZz8bbAhjFsUmYBJscW2T5mSfaYIp
TaSrg9WBV+TVW7aNE2iittE2O0/YyOWfpUVh6lliECeFdd0=
=aNEo
-----END PGP SIGNATURE-----

--=separator
Content-Type: application/octet-stream; name="xsa386.patch"
Content-Disposition: attachment; filename="xsa386.patch"
Content-Transfer-Encoding: base64

RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0
OiBWVC1kOiBmaXggZGVhc3NpZ24gb2YgZGV2aWNlIHdpdGggUk1SUgpEYXRl
OiBGcmksIDEgT2N0IDIwMjEgMTU6MDU6NDIgKzAyMDAKCklnbm9yaW5nIGEg
c3BlY2lmaWMgZXJyb3IgY29kZSBoZXJlIHdhcyBub3QgbWVhbnQgdG8gc2hv
cnQgY2lyY3VpdApkZWFzc2lnbiB0byBfanVzdF8gdGhlIHVubWFwcGluZyBv
ZiBSTVJScy4gVGhpcyBidWcgd2FzIHByZXZpb3VzbHkKaGlkZGVuIGJ5IHRo
ZSBib2d1cyAocG90ZW50aWFsbHkgaW5kZWZpbml0ZSkgbG9vcGluZyBpbgpw
Y2lfcmVsZWFzZV9kZXZpY2VzKCksIHVudGlsIGY1OTE3NTU4MjNhNyAoIklP
TU1VL1BDSTogZG9uJ3QgbGV0IGRvbWFpbgpjbGVhbnVwIGNvbnRpbnVlIHdo
ZW4gZGV2aWNlIGRlLWFzc2lnbm1lbnQgZmFpbGVkIikgZml4ZWQgdGhhdCBs
b29wLgoKVGhpcyBpcyBDVkUtMjAyMS0yODcwMiAvIFhTQS0zODYuCgpGaXhl
czogOGI5OWY0NDAwYjY5ICgiVlQtZDogZml4IFJNUlIgcmVsYXRlZCBlcnJv
ciBoYW5kbGluZyIpClJlcG9ydGVkLWJ5OiBJdmFuIEthcmR5a292IDxrYXJk
eWtvdkB0YWJpdC5wcm8+ClNpZ25lZC1vZmYtYnk6IEphbiBCZXVsaWNoIDxq
YmV1bGljaEBzdXNlLmNvbT4KVGVzdGVkLWJ5OiBJdmFuIEthcmR5a292IDxr
YXJkeWtvdkB0YWJpdC5wcm8+CgotLS0gYS94ZW4vZHJpdmVycy9wYXNzdGhy
b3VnaC92dGQvaW9tbXUuYworKysgYi94ZW4vZHJpdmVycy9wYXNzdGhyb3Vn
aC92dGQvaW9tbXUuYwpAQCAtMjQwOSw3ICsyNDA5LDcgQEAgc3RhdGljIGlu
dCByZWFzc2lnbl9kZXZpY2Vfb3duZXJzaGlwKAogICAgICAgICAgICAgICAg
IHJldCA9IGlvbW11X2lkZW50aXR5X21hcHBpbmcoc291cmNlLCBwMm1fYWNj
ZXNzX3gsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICBybXJyLT5iYXNlX2FkZHJlc3MsCiAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBybXJyLT5lbmRfYWRkcmVz
cywgMCk7Ci0gICAgICAgICAgICAgICAgaWYgKCByZXQgIT0gLUVOT0VOVCAp
CisgICAgICAgICAgICAgICAgaWYgKCByZXQgJiYgcmV0ICE9IC1FTk9FTlQg
KQogICAgICAgICAgICAgICAgICAgICByZXR1cm4gcmV0OwogICAgICAgICAg
ICAgfQogICAgIH0KCg==

--=separator--


From xen-devel-bounces@lists.xenproject.org Tue Oct 05 19:28:15 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Oct 2021 19:28:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.202446.357386 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXq6W-0000zU-PZ; Tue, 05 Oct 2021 19:27:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 202446.357386; Tue, 05 Oct 2021 19:27:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXq6W-0000zN-Lj; Tue, 05 Oct 2021 19:27:56 +0000
Received: by outflank-mailman (input) for mailman id 202446;
 Tue, 05 Oct 2021 19:27:55 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=GEJo=OZ=oracle.com=boris.ostrovsky@srs-us1.protection.inumbo.net>)
 id 1mXq6V-0000zH-10
 for xen-devel@lists.xenproject.org; Tue, 05 Oct 2021 19:27:55 +0000
Received: from mx0a-00069f02.pphosted.com (unknown [205.220.165.32])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 4928062f-c449-401d-8835-dc793902cba5;
 Tue, 05 Oct 2021 19:27:52 +0000 (UTC)
Received: from pps.filterd (m0246617.ppops.net [127.0.0.1])
 by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 195Iuftu010252; 
 Tue, 5 Oct 2021 19:27:24 GMT
Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71])
 by mx0b-00069f02.pphosted.com with ESMTP id 3bg3uq2qc2-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Tue, 05 Oct 2021 19:27:23 +0000
Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1])
 by aserp3030.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 195JFwNN068472;
 Tue, 5 Oct 2021 19:27:07 GMT
Received: from nam12-mw2-obe.outbound.protection.outlook.com
 (mail-mw2nam12lp2046.outbound.protection.outlook.com [104.47.66.46])
 by aserp3030.oracle.com with ESMTP id 3bev7trad0-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Tue, 05 Oct 2021 19:27:07 +0000
Received: from BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10)
 by MN2PR10MB4144.namprd10.prod.outlook.com (2603:10b6:208:1d6::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.19; Tue, 5 Oct
 2021 19:27:05 +0000
Received: from BLAPR10MB5009.namprd10.prod.outlook.com
 ([fe80::3c49:46aa:83e1:a329]) by BLAPR10MB5009.namprd10.prod.outlook.com
 ([fe80::3c49:46aa:83e1:a329%5]) with mapi id 15.20.4566.022; Tue, 5 Oct 2021
 19:27:04 +0000
Received: from [10.74.102.28] (160.34.88.28) by
 BYAPR06CA0003.namprd06.prod.outlook.com (2603:10b6:a03:d4::16) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4566.15 via Frontend Transport; Tue, 5 Oct 2021 19:27:00 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4928062f-c449-401d-8835-dc793902cba5
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc :
 references : from : message-id : date : in-reply-to : content-type :
 content-transfer-encoding : mime-version; s=corp-2021-07-09;
 bh=IKPdqbi7QShOVo8FrRIoiMBsCZtwHdkRhfdOyHXIIng=;
 b=nnW5Rh9gl+WgiSoHTQhspc0z3ja04BRDwpaaJcCADk7w1FDDlOn6HOIFV/tqzomF6KQt
 zweHv5apFhB1VQP3fhHm0TJziCPZK2I2l/VSoQFZ+k8CLsUbpnNjLCk0U4x8i2oBs4z1
 pFvBWFSfXyeVI+EWM5l8+9DeGDIKUDC2SI5401EsF8iKhQJotyu59I7Mh8biv3hOPLvw
 Hx/ZipZjtGHmxgP6/zOfsMuF9EbGLhqsF2hHQhuh3RireH1ee0rBiitwkOS7F7yZ3EO3
 aMpkEq/CJkZunc04LmShNG7Jqtoa+3jJ3DV0tFOy/v6kvJAzMZyWRmN13bTK1aYMNqy2 gA== 
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=kZ8jG08xnDw0T6vcHk4QiJwZ0g77Ie3TLKOxRDRu8FHUiljiRv6Qs5f2UmQwmIZiqFftIfGwsWUFtWl2rXTU/fzhkp2Q2ywgy6M6CjI4fZ9zmnQn6FJApBW4YTNN6dnN0bKIH2MvXXekGQQvcdQ7cIdJvYfyVycyE38/Fljx1Y1+nlxWZYw9seJyWahAN0n4gKulrGLWO201Ml8EvyJ0HELy8ac/p8sY0LcylwcbdKyex3ot2E7MDdxuWHVFxe8lEJAo5W4o4g5LVfwaQ1a6HLHKVi9+Ldy4HQlFKtfIBattGeF+kUILr+3BU5MeauBYxgAJkCLREcTbff8fhhp7Mg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=IKPdqbi7QShOVo8FrRIoiMBsCZtwHdkRhfdOyHXIIng=;
 b=ci1RZBZBAuJwx/3hBVZSa6r+OemfHlcrAE3jOsLFEj/KNIF2c+ZgKfORga/5j17kGZe38bwCOEIxBkO6PAbVfiuj/JlA04CCW5VIdowF8n6lt/nR6BiBqNkXpQEWsAuiQGYMg0+/7GxXGvpjFdugrZLEKJpmtzpQBLlzqY7aGZN2X3XvYV9pWxxk753Hbae36Pjq+/PjN1H4dj7xNXlhQy0qch0WLci6miXY6uZtpuM8qKCI5c6f1g+X9TVbRgU9Pl8PPR5gPpHru/4Q8QsS3nipQhRHuyGjMQIzebgMkU5203/uq4OJUFN2h/iJ19PMF65uipr9duRrPqXbxO/LUw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com;
 dkim=pass header.d=oracle.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=IKPdqbi7QShOVo8FrRIoiMBsCZtwHdkRhfdOyHXIIng=;
 b=lPGB66qSctB/tBSLA+PHuymbkUldI+P1pQj3sLutx+f/rCDiW8ffBEur6iUxnhhF1Ar2NLIsqOzoqC9WSnTP1b22e/h3O2Z0JSlmQX9GqolQ7ktxTG2W+6jfcDdG8VuBYXVQcF4jje91PufIm/N8rWAPkp/casHz+Dl2GAtTR8o=
Authentication-Results: kvack.org; dkim=none (message not signed)
 header.d=none;kvack.org; dmarc=none action=none header.from=oracle.com;
Subject: Re: [PATCH v2 2/9] x86/xen: simplify xen_oldmem_pfn_is_ram()
To: David Hildenbrand <david@redhat.com>, linux-kernel@vger.kernel.org
Cc: Andrew Morton <akpm@linux-foundation.org>,
        Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
        Borislav Petkov <bp@alien8.de>, "H. Peter Anvin" <hpa@zytor.com>,
        Juergen Gross <jgross@suse.com>,
        Stefano Stabellini
 <sstabellini@kernel.org>,
        "Michael S. Tsirkin" <mst@redhat.com>,
        Jason Wang <jasowang@redhat.com>, Dave Young <dyoung@redhat.com>,
        Baoquan He <bhe@redhat.com>, Vivek Goyal <vgoyal@redhat.com>,
        Michal Hocko <mhocko@suse.com>, Oscar Salvador <osalvador@suse.de>,
        Mike Rapoport <rppt@kernel.org>,
        "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>, x86@kernel.org,
        xen-devel@lists.xenproject.org,
        virtualization@lists.linux-foundation.org, kexec@lists.infradead.org,
        linux-fsdevel@vger.kernel.org, linux-mm@kvack.org
References: <20211005121430.30136-1-david@redhat.com>
 <20211005121430.30136-3-david@redhat.com>
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Message-ID: <ded331ac-f967-fdd3-e2e6-b79c37ebaa1f@oracle.com>
Date: Tue, 5 Oct 2021 15:26:54 -0400
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0)
 Gecko/20100101 Thunderbird/78.14.0
In-Reply-To: <20211005121430.30136-3-david@redhat.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Content-Language: en-US
X-ClientProxiedBy: BYAPR06CA0003.namprd06.prod.outlook.com
 (2603:10b6:a03:d4::16) To BLAPR10MB5009.namprd10.prod.outlook.com
 (2603:10b6:208:321::10)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 1f2840af-997b-492b-af50-08d988361d1b
X-MS-TrafficTypeDiagnostic: MN2PR10MB4144:
X-Microsoft-Antispam-PRVS: 
	<MN2PR10MB4144EDA7472423EA2F39CEB68AAF9@MN2PR10MB4144.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:185;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 
	HnKNNK+/YutrBMdl4lSOB3m8kcqWHbVZrKIHpeFjCP2YFgxI8LlE3oe7f/cLHhx10c4a5fnNbRVBZ0SLRDWn3sl2t/Exqwns/aOQ8SUL2/5eba7orPyy66Ye/I9iIm19UjGBLn9xGrLdYYyRFiAo0O+XDjTv0CAmvlmIvVLivV/34tA5BVR0TBKw7jw6vYEhtabfNIQSjAboZIWwzg0B85KaRerLmrpQxzJ6Ve/MGvc401eJrYDPWrjxijs2aaVLuYT9t71sr/wTvZaMGn6Fx8bVx2QrOpUtrG4IlgQvzAE4b5V07bbhbpolcg4JDLrQ3BboTvxeCZsi5vtuy5xCn9zJVebYiRsu26cCPMP/dk+ra0PXzpN7eyAWDRVnSi+fKT/rqMLpBCcwTM089nupfA20ayzHBND2nKN6lpnrlHz1iRFm2yyMjcsDyKBEB5yJRHLdvViVxk5wbML6ZhHUa3IRMs5jqaq6SjLciwZfq76bUsd/R/QnrWPf+QhsMkRlPyqTaa8z8pTn9iDgmVVjvgE00ir7/VtwQ+UAZot1Y0OjCtkBBB88cNZsQ71N56FsYsorm29lZfgfdKnDjMF/WhqJOWKOPD1fmHZ1HVkY2C6CwyysEkLW00XXKd2rSEcr2EocMszd3EgoVXOeQSVIcYvt7J3dn4/WQefrfuSy+TbWglwOjlQmk1h1ubz3ZkXNWd/sCaBvVS5M9O+ktm2O8CbAKwGh1I7pJSt5UwPcSOQaVkHvzjX8FDpUHQROs+nl
X-Forefront-Antispam-Report: 
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB5009.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(53546011)(2906002)(8676002)(6666004)(54906003)(4326008)(6486002)(86362001)(26005)(956004)(36756003)(31686004)(2616005)(16576012)(8936002)(7416002)(66946007)(31696002)(66556008)(44832011)(38100700002)(5660300002)(316002)(508600001)(558084003)(66476007)(186003)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?Q3Z4eW1ybzh0RGkydDBadGxSbU1mNlJmb25TNEorS1VtZGNBMmpxZVhxMVJu?=
 =?utf-8?B?Tjc1Z3dzc0wzR0dFTGRsZndqMk1vTVJvVjBQek9vRkNSVDZ1b3hFNkhwWUpO?=
 =?utf-8?B?QWFtdmNXOVAyL1pFWi9zdFp5NnQ1UzA0YnZDQ1p0ZVNucXMvVVlmSGVLKzBG?=
 =?utf-8?B?eExRMGxDT0dwY3l6a0NNY2lIWDNETkFSN1lHR0x2YUxvLzdnb1FXNVQycStP?=
 =?utf-8?B?bE5yc3JjSjVkSVVESGVpMFJDcUdLWG1UU2ZRTHMvMGFLTHA4NEVrekhMK2ZW?=
 =?utf-8?B?T29yTlNTM0ZnanF3YXk0aERCR1NKdi9EcGQzeEY4NFQ2QytVZFdieW5XNGZt?=
 =?utf-8?B?Zk9mWnVTTzRYNnU0U3lnM1JsQ0NZRHJmVjBlNDFmVmROS3lueFFraTZWNGlu?=
 =?utf-8?B?akJ6cVg5OFVvcVI2QlhBV2UzUW5GbkFlSGpQdzdpSGJjK2V6elFGVkw5Qisx?=
 =?utf-8?B?RDVmTHVVQ1dYK01hWEU3MUxQdFlyNituRUJ5KzErQTl4c3p6NWxaNUtIaDdD?=
 =?utf-8?B?WVZCT29qSzQzMHBrN2Z2eitwOHp3c0ZsdnQvdDhYVmU5WjhpdWE4SGIvSDN1?=
 =?utf-8?B?UllEc2VyTi91aGJUNlF0dlJEeHBRK05jNkNhd0wrdkpSQ0VqdGd1bTluLzhE?=
 =?utf-8?B?eUh6OGtLQk5vYXAydThPRFFWT3dIUXVwNzR5amNKdkNrOTZUaHhsZXJDMEtq?=
 =?utf-8?B?OVU0b3J2RGdmUkhhYUhMMTlWL0hSQ1liZU1YSkJmdVJnVmlodzFQTmJkSTJw?=
 =?utf-8?B?OUE1QkpwTjRlVWIzUlpuNVFzeGtPUUFBeElwQThZcDhmbjRtY1pWMk9VZE41?=
 =?utf-8?B?aW9HOURmQXNVajA5N3l3QTVuYUZNUlYyNU5Zc3g5L3hSRDd1eFlIZFlXeGor?=
 =?utf-8?B?YmVzSk56K3JkZEJ3L3o4dkp3SGV5dC9MWlN1Vm1hYzlXbWtmdWphbWM1M2x4?=
 =?utf-8?B?MlUycG1EUkZKdFFEclZaaDR0TGNRV24wd0FJSWZHWnBJTnpmL24rMHdOR1gw?=
 =?utf-8?B?STYxK3ZTd0g5V2JzU0lUcy9OQXVXOGpqcmpETkx3REtZWFpicm9CRE95cjR4?=
 =?utf-8?B?cE52V084M2dwVi9zUXltS25iQVpaeEVOQUN3Y3dDRWdRTGhGNGRyU1piZmt4?=
 =?utf-8?B?QVg3SmhNMk5nU0xPYVA1Z1JoNFJTS0dKNGtidXB4a0c2UEQxVmZ5VlpGSkJL?=
 =?utf-8?B?UmdJVUQxbE9HMWZlV2VheTJIdEZUdndwMHZ6dWZkYXdlYjFTM2NQNDlVSStw?=
 =?utf-8?B?Zjg0amJ6ZmZEYkYxdnhYdEN1YzE1Sk9WN1NpeXhRSUhkRUJQdVZOSlZjRnNX?=
 =?utf-8?B?UUMzWGxVYmpheW0zWHlUU3gwaHplcmpnaGhxZVhzWTNpWmZDaDBTOHdsN3NM?=
 =?utf-8?B?bTZCUlpqK1JoSldjcDVuRmJZaWJSSjlWTUZCTXZYMXc3c2NubGZnMldnYWtD?=
 =?utf-8?B?YmZjSUNUQmhSVzB4QWcwbXhwK0hpaTk3bUhNWFBkZ0pLRlhaN3FKMDZTaWdi?=
 =?utf-8?B?cGN1WlNNNkxiaElJV2pXdnM1V2hxSEpjQ3JUbVNnUjl6dTEzdFovSDZ3Z2xi?=
 =?utf-8?B?cTBTWUNDcnh0YzB3UkUwdDZoRzExWmdjMUxFNEw0RzhyQVc2VEpKUnhSLzB6?=
 =?utf-8?B?c1VYd01paEdWdW1GdUF1WFFLcVplWklUY3duMk9RQUdWRlRRSGhvR2dmWnRv?=
 =?utf-8?B?TWY3ZjhvdFZOSXhuN21yekFlNUtmbmFEb3NMYlVkelBjcHY0UFMySjluTVFj?=
 =?utf-8?Q?A6lzTU5DpebtI/ZnIv6oELrsyx845vXqcpLH/xJ?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1f2840af-997b-492b-af50-08d988361d1b
X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Oct 2021 19:27:04.9074
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: uSiGDlu2cAAB5uQNKFE1ffMtuw3gBbFX+95KUzR2+UcX+1n/R7oW6VDhQuKoGAXtGriwJvR3GTCbHwNreNZaaZU4iF9awHcw8Gwf+Jh2TuQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR10MB4144
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10128 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 mlxlogscore=999 adultscore=0
 bulkscore=0 suspectscore=0 malwarescore=0 spamscore=0 phishscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109230001
 definitions=main-2110050113
X-Proofpoint-ORIG-GUID: 57psMXq2VE5oveGmVVOu08OwAKJQUrof
X-Proofpoint-GUID: 57psMXq2VE5oveGmVVOu08OwAKJQUrof


On 10/5/21 8:14 AM, David Hildenbrand wrote:
> Let's simplify return handling.
>
> Signed-off-by: David Hildenbrand <david@redhat.com>


Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>



From xen-devel-bounces@lists.xenproject.org Tue Oct 05 19:31:01 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Oct 2021 19:31:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.202454.357397 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXq9U-0002PB-6z; Tue, 05 Oct 2021 19:31:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 202454.357397; Tue, 05 Oct 2021 19:31:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXq9U-0002P4-3z; Tue, 05 Oct 2021 19:31:00 +0000
Received: by outflank-mailman (input) for mailman id 202454;
 Tue, 05 Oct 2021 19:30:58 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=GEJo=OZ=oracle.com=boris.ostrovsky@srs-us1.protection.inumbo.net>)
 id 1mXq9S-0002Oy-Ms
 for xen-devel@lists.xenproject.org; Tue, 05 Oct 2021 19:30:58 +0000
Received: from mx0b-00069f02.pphosted.com (unknown [205.220.177.32])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id c3dafdce-2612-11ec-bf0b-12813bfff9fa;
 Tue, 05 Oct 2021 19:30:58 +0000 (UTC)
Received: from pps.filterd (m0246632.ppops.net [127.0.0.1])
 by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 195IlY6R029400; 
 Tue, 5 Oct 2021 19:30:39 GMT
Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79])
 by mx0b-00069f02.pphosted.com with ESMTP id 3bg42ktgy5-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Tue, 05 Oct 2021 19:30:38 +0000
Received: from pps.filterd (userp3020.oracle.com [127.0.0.1])
 by userp3020.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 195JEhGH090684;
 Tue, 5 Oct 2021 19:30:37 GMT
Received: from nam02-sn1-obe.outbound.protection.outlook.com
 (mail-sn1anam02lp2046.outbound.protection.outlook.com [104.47.57.46])
 by userp3020.oracle.com with ESMTP id 3bf16tkrh9-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Tue, 05 Oct 2021 19:30:37 +0000
Received: from BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10)
 by MN2PR10MB4288.namprd10.prod.outlook.com (2603:10b6:208:1dc::7)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.17; Tue, 5 Oct
 2021 19:30:34 +0000
Received: from BLAPR10MB5009.namprd10.prod.outlook.com
 ([fe80::3c49:46aa:83e1:a329]) by BLAPR10MB5009.namprd10.prod.outlook.com
 ([fe80::3c49:46aa:83e1:a329%5]) with mapi id 15.20.4566.022; Tue, 5 Oct 2021
 19:30:34 +0000
Received: from [10.74.102.28] (160.34.88.28) by
 BYAPR08CA0064.namprd08.prod.outlook.com (2603:10b6:a03:117::41) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.20 via Frontend
 Transport; Tue, 5 Oct 2021 19:30:29 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c3dafdce-2612-11ec-bf0b-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc :
 references : from : message-id : date : in-reply-to : content-type :
 content-transfer-encoding : mime-version; s=corp-2021-07-09;
 bh=hagq3upWVQMX0uoE2qylRWfS6OLtiOzrGNSqBcp1/dM=;
 b=ZvTdKpCCNg1zH0jX5r5B14HnxSm/EIgN0GwaSLpVWZSzeEB+VCVihtWCxg7mmD8NsCFZ
 gtOkwBg5OrSo2KYxSEH+bvaZ37NuxDO113LJeSQVT24uxOsWbbI4vsN+amw34POVsBhm
 XD+u3Ei0zyGHDlwjf+CGfTDmkR/YgoV6MNq8hZhxje+kZhTPA0X8nOnrvFnSI2gSIuFQ
 nFTE9ow8H0WsuOZ/Uv+DKM0GScB/NsmEAOdGtx+p5QSGUsVhVa3FyHwn6Lw+R9MM6fkw
 UzOdh/7K9btZ/QvhQTbzLYhuvkd0SAbOR5uAJA7bD5+0Iwu7xizAtoqdxYUqnd3f35pu LQ== 
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=GhG+CHmJv+g13mSyIzn+Q/QOfO3dtXQO6YwGC4re9MHNraMS68qvxKK9wNr7mRkjR+ObY+cHxU0L8QeazjVcZ68XKYrzxkGyFU+/8/WmFDuA/i0C026gpMh3j3kefZY/zTbCwsSTQbTSlkY/10mMqo8UHfHTwcsl3aiCM4sqoEcf1864TlS060yeWs91LJbTlljO3NjJn76AIWl2td7fjOySkVkMuWsfs3Dj5fk8UM/qwGVZmEJ8RizLgqUd3jFwqe4DG3nqtdjwsglnoW9M6ltJuokBRi7LEa3OVkfpLlMgi8dzROX+FZK2U0/cuR7JniEetBH/cC/fJLaDVs4JrA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=hagq3upWVQMX0uoE2qylRWfS6OLtiOzrGNSqBcp1/dM=;
 b=ZwP2jGr4NSEyEL6oMUcxm9QrVokbwf6aD9Kp+jK+X5Vi17PaCnGuo0UHF8m8yGbsS3DPdH54GWvI8yIFXknL/1yw0YrQnea0q1hnJlqJ3WCA3D3OEpNnhev/WatLpmStAaifoUp7ntvceV2j+aEJFy5hNq+WtwgX0LwqwgotxQnf9gW+PpSJcGoFrC1KFUdCOy9o4xkZmIO9TjIRYMt7FXnSqjWp9gDE8kRf3KHLgasG4koQPLAjjE1epz4u1ebHZ8qQFKx9iaO4vT7dgYEORMYrWDWV80OvJFEFP2Af0aC5M5FvtDfBLrsl8r0Qr+ebPrcDIqy+2gfbY7wNNqBpEQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com;
 dkim=pass header.d=oracle.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=hagq3upWVQMX0uoE2qylRWfS6OLtiOzrGNSqBcp1/dM=;
 b=qPylVRxOIlxXKgnIG2P85vz2WJt3m5TZYJT5cb9MBflJ0HUEb4SVajybyGXn4SEFKC5PUa6ciiaYjYnPKRStmBHxoU48B0wtSA5mtnLRwmeWBwCCKMmy8/UCoBPRHq6/ea2Exp5qd5S5ewLhoE8jqIKr6/LjiOdT5mTUVlSSsSU=
Authentication-Results: kvack.org; dkim=none (message not signed)
 header.d=none;kvack.org; dmarc=none action=none header.from=oracle.com;
Subject: Re: [PATCH v2 3/9] x86/xen: print a warning when HVMOP_get_mem_type
 fails
To: David Hildenbrand <david@redhat.com>, linux-kernel@vger.kernel.org
Cc: Andrew Morton <akpm@linux-foundation.org>,
        Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
        Borislav Petkov <bp@alien8.de>, "H. Peter Anvin" <hpa@zytor.com>,
        Juergen Gross <jgross@suse.com>,
        Stefano Stabellini
 <sstabellini@kernel.org>,
        "Michael S. Tsirkin" <mst@redhat.com>,
        Jason Wang <jasowang@redhat.com>, Dave Young <dyoung@redhat.com>,
        Baoquan He <bhe@redhat.com>, Vivek Goyal <vgoyal@redhat.com>,
        Michal Hocko <mhocko@suse.com>, Oscar Salvador <osalvador@suse.de>,
        Mike Rapoport <rppt@kernel.org>,
        "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>, x86@kernel.org,
        xen-devel@lists.xenproject.org,
        virtualization@lists.linux-foundation.org, kexec@lists.infradead.org,
        linux-fsdevel@vger.kernel.org, linux-mm@kvack.org
References: <20211005121430.30136-1-david@redhat.com>
 <20211005121430.30136-4-david@redhat.com>
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Message-ID: <4814ff2e-dc1f-71d5-9082-19f8ede9aeaa@oracle.com>
Date: Tue, 5 Oct 2021 15:30:25 -0400
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0)
 Gecko/20100101 Thunderbird/78.14.0
In-Reply-To: <20211005121430.30136-4-david@redhat.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Content-Language: en-US
X-ClientProxiedBy: BYAPR08CA0064.namprd08.prod.outlook.com
 (2603:10b6:a03:117::41) To BLAPR10MB5009.namprd10.prod.outlook.com
 (2603:10b6:208:321::10)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 312199c2-60a4-41e4-a46e-08d988369a15
X-MS-TrafficTypeDiagnostic: MN2PR10MB4288:
X-Microsoft-Antispam-PRVS: 
	<MN2PR10MB42885A0738B3963CE55D8BA28AAF9@MN2PR10MB4288.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:335;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 
	23Tsd2HQlKw8tGlcFDe8AVzNBsK0PBwnfw8JYR+sbWjt1Bgqkr1A4PUt2bR3a5iZg7C9Wgfi0JmIa2ODkSiYIc8mUNuPn+yBbxFGP7V6whJyUd4a5yIB+Tt2IlJk+mQW3+ncLyBn0FgNgL21rqq0PvknpkevM89CsZeanWJnpmCH/11aUKCPQ16PT2FPBrN1p7ms9wiE34QTg9XXQL/TokW0IB4Sxez/1HknB/r0OgB8aK1SgrPiDV6UEXFBeYn/I3FO5NbUBKY2H495fqSPu9oVeVtQUc+7UGXEfWfGWjASgweQCL1d8yMqvpgyN/wrVZHYsgd+HXit68nDXoIOOHho8hceMXafgoZtrSPls4C0qTD+fPx9p1HvT3v8tskML6nKf9RW/KEx9oLRcG+0y9sGTE2Y481S25ZWDRvP3Q4cilKc5mzu1AqUuoivDvi0oRK25oJKE1CyRMgMwr9ikamnhQYfGfVBkI8zl8k19BVyXmT9zdgwcYZq/c50VZy0UaYgDeu0+CvlKXrTE2cCFOVUBF0ANw10FB9AeXFzEFNLpYbi+VXNzneHHlqb5y6q3R8LelokQU3xf6Z8HplxmZ5gieY5Mi1HYDwZxNeDofl87U7z/bFHFCg6/NBJpldiOTZCo3VUdSn0OiDDC/YMDd1+81a2CMMdjDRaxKg+cOo0u0J8Z0/AzogS1DY2K1SY5HGguyh+lp5VzZM4ShJQpmuLuxyT5pnHzPkhlXczKcm87VjY9hF+BOjsthNZFfMgBjuzpUmbk9OsWooDJqyV2zdi9jmcU+nRIXUFVjIkxzqWZuveW9g9/CLnCb5c6CPLaUGkKjcegSnd5CC1Be4Oxg==
X-Forefront-Antispam-Report: 
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB5009.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(53546011)(8676002)(8936002)(31686004)(44832011)(31696002)(316002)(2616005)(956004)(6486002)(38100700002)(6666004)(508600001)(16576012)(186003)(7416002)(4744005)(5660300002)(26005)(2906002)(966005)(4326008)(66556008)(66946007)(66476007)(86362001)(36756003)(54906003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?d05rRVlmVmtTakJsQ0g4aUg2RTFJMk9KRi9nTTBWWjVoVDZHeWdtV2RwMEZz?=
 =?utf-8?B?T21ZNk01WS9hMHgrUmlMWnFUV3ZyYTNFZitqTDN3QXpzbGt4aUJqSG1FdlE4?=
 =?utf-8?B?RS9WaGlmWjBpYlNKcDFmVW5xVUhTWjRGZjZ6cEdMVm45Q0dYNDAxSTBMd0Ry?=
 =?utf-8?B?WndrWmJWdGw1SklxWHhiQUhTb3U3V0lNdmRzd2J2aUg2cTdGdGFhMkdleW4r?=
 =?utf-8?B?TnlIbkhDYkFnQkJVK09LRktLQ1dQV2YzTlRFNWhPbDBUblRoamhrWEdUdlYv?=
 =?utf-8?B?MFBEK2JJTk1PcmVjbEtHdTFjTEs4UHVCbjRadVpYdm02Y0FKK3JUcDg0M1Bo?=
 =?utf-8?B?Y0MwYVQ4bVcya3BKWkNodnE5QzRORE9yVnB1VTJ1ME1YQnFyREUyVWo1TC90?=
 =?utf-8?B?ZmhsbUJnSlFmN1VJRmJ6SS9KOEVrWndUVHp2MDdUblZ1b0l0UnYzQXlLMUxl?=
 =?utf-8?B?RkRBbG5Va0I3ZHpzRmZlNjcyZCtiQ1lKK0cwVytrY0dFamo4YWZnVnlrZ2tO?=
 =?utf-8?B?cWZUV0N2aE8wM2ZZZWl3NDM0c3hnb2RmRHAzSjhQSDM4MUNTbkpZbkg3dy93?=
 =?utf-8?B?WVQ5NjZ5Tys0MWEzYTFQK0F2SXNCRmtMc2JVRUlnYmpnTDBEWUg2alg3OEhB?=
 =?utf-8?B?NmhhRTg2YTV3QXJRaDhIblJ4Ni9CZ3VZYmxEVm1LcHB4ME52NUdOeWkwa0pV?=
 =?utf-8?B?RDVkdXZ0SjMzaE1vTEhIUVNVcHZnVWpVejhZbVoralkwbVhNMlpUOUU4TU43?=
 =?utf-8?B?OUhkOWpxVTdGVGNSaHpEME53Y1pjbDRNRGhqS0VydkMwN3hSNWtrNGduUVE0?=
 =?utf-8?B?aXN3L0U0SCtwYWI5eGJ4SURuZ01VOHBSaklib2daN2k3dW5zamtmd0Y2VUM1?=
 =?utf-8?B?UEdnK01ydVdEdDYzQ29sR210WEVnUHFtTFlrQkV6VmZKeW9BS0wvbnZqUDE2?=
 =?utf-8?B?dWl0Q0xQYVFyd3RPNHV2eERwLzJtc1BkU0dYcVpQTFFUMkxjeUlDV3ZjYjNw?=
 =?utf-8?B?MFYzOHJzV0xnTGQxb1JnbGpseFI1MlEvajhaTkxkRStaaUhCTzBTbkFQZjVE?=
 =?utf-8?B?ZjJnSGJpU0xUc1F1akJhWVAwL0lsVEp0SUozc3dONEtSSmtwSHRyN0pSbERi?=
 =?utf-8?B?TG90WmsrQVFhQ0VmNWZnK3ZFbEVXcStUd09UejQxOTlJU1JrcmFGWDdOMndq?=
 =?utf-8?B?RmNnK1MzTTZTd2NxUnUxWVh0WXNlMEppT0JHeG40ZXovbG51Lytsc1VlZlNs?=
 =?utf-8?B?UzYvWmt3cnZiSCtwZXkwSVZqWkhRSzE5Tlp1eXJOWlNsUWpJRDRQTWc4RHlO?=
 =?utf-8?B?UjhLc3d4VGF5Z3ZPRCtVc3I0d2Z3Y0hNQ2IxZ3NCc1lpTGpvS3VZcWx1anNs?=
 =?utf-8?B?bGpwRVpXMnk3Ui9NSDV1NVNGbmJobEtQWWtGWk5sN2tmd0ZQL2toTGQ5dlRI?=
 =?utf-8?B?SHJ2dE5HU2IvUHZrM21mSjB3anN4L2c2WCt2OE5JRVVEcEUveVc0eFR0aUMw?=
 =?utf-8?B?Zy9LVVFkSEQ1R0RieDZOWVRDZVR2QlovZll2TlgzUTREd2VLVlp5MTVITHVC?=
 =?utf-8?B?Nk9vdElWV2dxK3ZIZGdRRFFDL3YwYUxIbHdieU9remJ3cVhBU2lsTDBPQjc0?=
 =?utf-8?B?ZW9jL05HU3htMlRuM2VvTnpXckl3dHRFZVFPanEwUXprQkFaRXRKRm0xR1kr?=
 =?utf-8?B?RElFUC9PMUpFWkQxWUM1TURDcWlrY0I0R3BaVWhPeFJkL3k0bEpLZTNMTWxt?=
 =?utf-8?Q?tKw1pXOhijcX1e8+WQiuS1pBXLiB6c1LQA+P2lz?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 312199c2-60a4-41e4-a46e-08d988369a15
X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Oct 2021 19:30:34.6417
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: POou7n8kWBmLvWbSJ2PUsI2Mnu8eSjvULsPjJ2t3gVwTyhXivB3KASVF3npFAUQkDmispqca+JwJQklfVkHN886Vdy805nsmpi0NNXiUacw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR10MB4288
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10128 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 adultscore=0
 phishscore=0 malwarescore=0 bulkscore=0 mlxlogscore=999 mlxscore=0
 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2109230001 definitions=main-2110050113
X-Proofpoint-GUID: cswN1txcG0lsYY_KX0sYrFnNGrS2DbC2
X-Proofpoint-ORIG-GUID: cswN1txcG0lsYY_KX0sYrFnNGrS2DbC2


On 10/5/21 8:14 AM, David Hildenbrand wrote:
> HVMOP_get_mem_type is not expected to fail, "This call failing is
> indication of something going quite wrong and it would be good to know
> about this." [1]
>
> Let's add a pr_warn_once().
>
> [1] https://lkml.kernel.org/r/3b935aa0-6d85-0bcd-100e-15098add3c4c@oracle.com
>
> Suggested-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> Signed-off-by: David Hildenbrand <david@redhat.com>


Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>



From xen-devel-bounces@lists.xenproject.org Tue Oct 05 19:42:29 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Oct 2021 19:42:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.202464.357408 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXqKX-00041L-Bj; Tue, 05 Oct 2021 19:42:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 202464.357408; Tue, 05 Oct 2021 19:42:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXqKX-00041E-8W; Tue, 05 Oct 2021 19:42:25 +0000
Received: by outflank-mailman (input) for mailman id 202464;
 Tue, 05 Oct 2021 19:42:23 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=kL3v=OZ=gmail.com=olekstysh@srs-us1.protection.inumbo.net>)
 id 1mXqKV-000418-77
 for xen-devel@lists.xenproject.org; Tue, 05 Oct 2021 19:42:23 +0000
Received: from mail-lf1-x12f.google.com (unknown [2a00:1450:4864:20::12f])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id db1f637b-24eb-4c96-9dc8-c05457d92f21;
 Tue, 05 Oct 2021 19:42:22 +0000 (UTC)
Received: by mail-lf1-x12f.google.com with SMTP id u18so408001lfd.12
 for <xen-devel@lists.xenproject.org>; Tue, 05 Oct 2021 12:42:20 -0700 (PDT)
Received: from [192.168.1.7] ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id s17sm1161173lfe.10.2021.10.05.12.42.18
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Tue, 05 Oct 2021 12:42:19 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: db1f637b-24eb-4c96-9dc8-c05457d92f21
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:from:to:cc:references:message-id:date:user-agent
         :mime-version:in-reply-to:content-transfer-encoding:content-language;
        bh=T3A0+TZLbkNYb83tjQH7ugFUuKxMDTQ3x0dHrMRAhB8=;
        b=bHQvUNvMTTe3JJPtP3VeowogZjpxLCqy3qjNtCxuzplKEuxFYJph5+rUdgqNxsnZk4
         TBTHBg3ZRC9rxuRhk4wCUVkkxnGEWrCRhaIoXQsCZ+yvpfTIx8du8IroXh/V/CNZWlPq
         LHdPNcpAM1YfNgD8b+2u/5fjx/F589uZuZ6+wZ6W76GiZL0X1a43/L1j+95JoT7rhYUC
         ev2MZADHNSN1QZh16ZgSyYveNsXxp1cbB1qcBHOzEE3p5Tw13QTC0gdtflr+yGqReBq1
         FrwSPeyx182vcdixDnjte16KUMtxOjDALTRqiO9vNYvFFvaW/NKDAm5Pn3+AMlWAAWH3
         qetg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:from:to:cc:references:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding
         :content-language;
        bh=T3A0+TZLbkNYb83tjQH7ugFUuKxMDTQ3x0dHrMRAhB8=;
        b=Rg11gcFO60/jpudz/ylcwqfGX6brN/5TEnJT7DhfSzJc/F0SK8BR+z/Dqi1bBAIGP2
         itqbPIKBoVT5eA7U2AzSGc74Mjn89cAPJOAWkr1+LtLsA4SOxY4ui6WDWZIGPVipYqYp
         vfS4l19m8q5tp1wrbW1MPJqmoKwU1MI5Lx8bDrKYjIGvW7+4+EhZgkJlSU2mf0QfDin4
         7on0gv/TK260kGFop2CIUVaN2Yd/qYm5NZdE08lKitvY3yyl6ZWDyznqTJW+DzlSWQvg
         oAzQ0NeQ5ruFFK3wnMnTmL9IeWXPbaljpZ4ngBRnnQf56YNhqaF+KpOtsIIB0VMrguQp
         FuJA==
X-Gm-Message-State: AOAM531FxwiyyC0uZZ6T8Alwslpcx2AEfGuu5coB4qb/ahVe5Ryvb0gk
	7+Is0/66rU1P0rXu/7olcZ8=
X-Google-Smtp-Source: ABdhPJz2tZgSNrAB5vVpNwPg1bqhxeyZFNbITpnKQZWejDPO36NO8H6S4VpUmuSVkXI7PzqnbQF4Jg==
X-Received: by 2002:a2e:864d:: with SMTP id i13mr24274977ljj.87.1633462939285;
        Tue, 05 Oct 2021 12:42:19 -0700 (PDT)
Subject: Re: [PATCH V4 3/3] libxl/arm: Add handling of extended regions for
 DomU
From: Oleksandr <olekstysh@gmail.com>
To: Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>
Cc: xen-devel@lists.xenproject.org,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>,
 Anthony PERARD <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <1632955927-27911-1-git-send-email-olekstysh@gmail.com>
 <1632955927-27911-4-git-send-email-olekstysh@gmail.com>
Message-ID: <c0184478-4af1-d9e8-a527-49ae7eebcc70@gmail.com>
Date: Tue, 5 Oct 2021 22:42:18 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <1632955927-27911-4-git-send-email-olekstysh@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US


On 30.09.21 01:52, Oleksandr Tyshchenko wrote:

Hi Stefano, Julien.

> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>
> The extended region (safe range) is a region of guest physical
> address space which is unused and could be safely used to create
> grant/foreign mappings instead of wasting real RAM pages from
> the domain memory for establishing these mappings.
>
> The extended regions are chosen at the domain creation time and
> advertised to it via "reg" property under hypervisor node in
> the guest device-tree. As region 0 is reserved for grant table
> space (always present), the indexes for extended regions are 1...N.
> If extended regions could not be allocated for some reason,
> Xen doesn't fail and behaves as usual, so only inserts region 0.
>
> Please note the following limitations:
> - The extended region feature is only supported for 64-bit domain
>    currently.
> - The ACPI case is not covered.
>
> ***
>
> The algorithm to choose extended regions for non-direct mapped
> DomU is simpler in comparison with the algorithm for direct mapped
> Dom0. As we have a lot of unused space above 4GB, provide single
> 2MB-aligned region from the second RAM bank taking into the account
> the maximum supported guest address space size and the amount of
> memory assigned to the guest. The maximum size of the region is 128GB.
> The minimum size is 64MB.
>
> Suggested-by: Julien Grall <jgrall@amazon.com>
> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
> Acked-by: Ian Jackson <iwj@xenproject.org>
> Reviewed-by: Michal Orzel <michal.orzel@arm.com>
> Tested-by: Michal Orzel <michal.orzel@arm.com>

I though a bit more on this and decided to make a patch more functional 
by trying to also allocate extended region below 4GB, I think we could 
do with it.
Actually if guest memory size is less than GUEST_RAM0_SIZE, we are able 
to provide unused space. I have tested with with various guest memory 
sizes and it worked fine. Also I decided to drop limit for maximum 
extended region size (128GB), we don't apply this limit in Dom0 and I 
don't see why we need it here, moreover the calculation became more 
obvious. I will drop all acks and send updated version. Are there any 
objections?



-- 
Regards,

Oleksandr Tyshchenko



From xen-devel-bounces@lists.xenproject.org Tue Oct 05 19:49:10 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Oct 2021 19:49:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.202473.357419 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXqR0-0004mG-4g; Tue, 05 Oct 2021 19:49:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 202473.357419; Tue, 05 Oct 2021 19:49:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXqQz-0004m9-Vq; Tue, 05 Oct 2021 19:49:05 +0000
Received: by outflank-mailman (input) for mailman id 202473;
 Tue, 05 Oct 2021 19:49:05 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=kL3v=OZ=gmail.com=olekstysh@srs-us1.protection.inumbo.net>)
 id 1mXqQz-0004m3-B4
 for xen-devel@lists.xenproject.org; Tue, 05 Oct 2021 19:49:05 +0000
Received: from mail-lf1-x136.google.com (unknown [2a00:1450:4864:20::136])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 04bef19e-f03b-4353-aa1d-95aa9adf4ba2;
 Tue, 05 Oct 2021 19:49:03 +0000 (UTC)
Received: by mail-lf1-x136.google.com with SMTP id u18so474268lfd.12
 for <xen-devel@lists.xenproject.org>; Tue, 05 Oct 2021 12:49:03 -0700 (PDT)
Received: from [192.168.1.7] ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id a11sm2053407lfo.5.2021.10.05.12.49.01
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Tue, 05 Oct 2021 12:49:02 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 04bef19e-f03b-4353-aa1d-95aa9adf4ba2
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-transfer-encoding:content-language;
        bh=oMK54/16mBkwKiFyvSXTk51BEZvTZPD8UUz0Oc5ptB4=;
        b=Li1dIFEbH90MjW3j0l/fG/ggwGkhlCHge4Yp3XaAvHsBXB0NgMNJwVlHYCARvi8wBD
         BLiBVJpNdt791r+Zi7TnSNUxsX4P55vMAC528U1fW1h8M42OXHK2CcQlqVmV6tcE2y6e
         sdwGUqTkovYcY1viLUYRhO9ePmT1DsA5PzPuE78Pm+N9aGhMcTVWJzh2ml0qEcjswImf
         FuximTPIg2YY7N4DTR/M3Q+ITIFoIv8+nr6aExdwgypKRzO89m0K4WzIUyfXSLkm1aDg
         o2NB5qBij+ApG/63s5ogvxa9IIDamy0etgwDMqEMVAwG+oyDFfgN2xpszvm2i2IO4vAK
         /E0Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding
         :content-language;
        bh=oMK54/16mBkwKiFyvSXTk51BEZvTZPD8UUz0Oc5ptB4=;
        b=6SbenD80FhNstgVXDLYKZH0f7HiiUlHwWFgvYtY1rf8h6eKVdMeflwDwcEBBxSwqrX
         FUrkiG2h2oM15ihb+p0ZKzR6aXQeYhGPdu0HoImTs6AvsJZqadIWWrV/1fPN1/gm6Pru
         bW1jPmupcBFf3EVoZ50w9SYoqVS8ni1THmxBnQr2yJwXYWhWNn6zRQuH5JVIv5ffKb6x
         WBOWK1hWAOKTQk+27J9LMjHGluM4+1egpeoOXdnkafzpCHPdG8ZzC1ANQDZox1NA7CTM
         2gde1qU2JXdbdz1flJUz0+NvuJukGT3/2F/BBG6aL2T0S73Oev5Iw28cxJSVRmVB2L28
         VkTQ==
X-Gm-Message-State: AOAM530GD1N+++c+Ma5ryBPBqz8LEndEAOT99LL9DRS/ullsJN6lPjZS
	mMO6etZeCQMSrXtPK0h6BxM=
X-Google-Smtp-Source: ABdhPJy9Xw4zczTR1O1LA9pC182hMbl65+8nFq/tE4bbhhJjd/MiZqrMDmIgtuzB4OpbfZv9SiAO5Q==
X-Received: by 2002:a05:6512:d2:: with SMTP id c18mr5527180lfp.484.1633463342663;
        Tue, 05 Oct 2021 12:49:02 -0700 (PDT)
Subject: Re: [PATCH V4 1/3] xen: Introduce "gpaddr_bits" field to
 XEN_SYSCTL_physinfo
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: Julien Grall <julien.grall.oss@gmail.com>, Jan Beulich
 <jbeulich@suse.com>, xen-devel <xen-devel@lists.xenproject.org>,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>,
 Anthony PERARD <anthony.perard@citrix.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Juergen Gross <jgross@suse.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Bertrand Marquis <Bertrand.Marquis@arm.com>
References: <1632955927-27911-1-git-send-email-olekstysh@gmail.com>
 <1632955927-27911-2-git-send-email-olekstysh@gmail.com>
 <alpine.DEB.2.21.2109301600060.3209@sstabellini-ThinkPad-T480s>
 <05b040b0-a069-47a1-1f5e-85be62fa35f3@suse.com>
 <bbbceae1-c382-5e48-0c6b-fbb23fc720f5@gmail.com>
 <alpine.DEB.2.21.2110011244000.3209@sstabellini-ThinkPad-T480s>
 <CAJ=z9a2bT4tMn2argJzePUMR2Ke4bmabj+j5QevvwpfnA9ST_w@mail.gmail.com>
 <093bc1d5-bf6a-da0a-78b5-7a8dd471a063@gmail.com>
 <alpine.DEB.2.21.2110041411100.3209@sstabellini-ThinkPad-T480s>
From: Oleksandr <olekstysh@gmail.com>
Message-ID: <cdc5a5ef-950f-622b-a0c0-4ec03535ab55@gmail.com>
Date: Tue, 5 Oct 2021 22:49:01 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.21.2110041411100.3209@sstabellini-ThinkPad-T480s>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US


On 05.10.21 00:11, Stefano Stabellini wrote:

Hi Stefano

> On Sat, 2 Oct 2021, Oleksandr wrote:
>> On 02.10.21 10:35, Julien Grall wrote:
>>
>> Thank you for your comments!
>>
>>        Hi
>>
>>        On Sat, 2 Oct 2021, 01:24 Stefano Stabellini, <sstabellini@kernel.org> wrote:
>>        Bertrand, see comment on ID_AA64MMFR0_EL1 below, any ideas?
>>
>>
>>        On Fri, 1 Oct 2021, Oleksandr wrote:
>>        > On 01.10.21 10:50, Jan Beulich wrote:
>>        > > On 01.10.2021 01:00, Stefano Stabellini wrote:
>>        > > > On Thu, 30 Sep 2021, Oleksandr Tyshchenko wrote:
>>        > > > > From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>>        > > > >
>>        > > > > We need to pass info about maximum supported guest address
>>        > > > > space size to the toolstack on Arm in order to properly
>>        > > > > calculate the base and size of the extended region (safe range)
>>        > > > > for the guest. The extended region is unused address space which
>>        > > > > could be safely used by domain for foreign/grant mappings on Arm.
>>        > > > > The extended region itself will be handled by the subsequents
>>        > > > > patch.
>>        > > > >
>>        > > > > Use p2m_ipa_bits variable on Arm, the x86 equivalent is
>>        > > > > hap_paddr_bits.
>>        > > > >
>>        > > > > As we change the size of structure bump the interface version.
>>        > > > >
>>        > > > > Suggested-by: Julien Grall <jgrall@amazon.com>
>>        > > > > Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>>        > > > > Reviewed-by: Michal Orzel <michal.orzel@arm.com>
>>        > > > Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
>>        > > I have to admit that I'm a little puzzled to see these R-b-s when ...
>>        > >
>>        > > > > Please note, that review comments for the RFC version [1] haven't been
>>        > > > > addressed yet.
>>        > > > > It is not forgotten, some clarification is needed. It will be addressed
>>        > > > > for the next version.
>>        > > > >
>>        > > > > [1]
>>        > > > > https://lore.kernel.org/xen-devel/973f5344-aa10-3ad6-ff02-ad5f358ad279@citrix.com/
>>        > > ... Oleksandr makes clear this patch isn't really ready yet.
>>        >
>>        > Unfortunately, this is true. I am still waiting for the clarification [1]
>>
>>        Although I was aware of comments to older versions, this is actually the
>>        first version of this patch that I reviewed with any level of details; I
>>        didn't read previous comments very closely. I tried to find any bugs or
>>        problems with it and I couldn't see any, so I gave my reviewed-by. I
>>        should have clarified that was meant for the ARM part as I don't have a
>>        full understanding of the implications of using hap_paddr_bits on x86
>>        for VM migration.
>>
>>
>>
>>        But let me take this opportunity to say that although I think the
>>        hypercall is OK, I wish we didn't need this patch at all: it is
>>        problematic because it touches tools, x86 and ARM hypervisor code all
>>        together. It needs at least three acks/reviewed-by to get accepted: from
>>        an x86 maintainer, an arm maintainer and from a tools maintainer. I
>>        don't say this to criticize the patch acceptance process: this patch
>>        makes changes to an existing hypercall so it is only fair that it needs
>>        to go through extra levels of scrutiny. For the sake of simplicity and
>>        decoupling (reducing dependencies between patches and between
>>        components), I think it would be best to introduce an #define for the
>>        minimum value of gpaddr_bits and then move this patch at the end of the
>>        series; that way it becomes optional.
>>
>>
>> It depends what you mean by optional. Yes we can add hack to avoid the hypercall... But the more scalable solution is the hypercall.
>>
>> I am slightly concerned that if we don't push for the hypercall now, then there will be no incentive to do it afterwards...
>>
>> So I went through Andrew's e-mail to understand what's the request. I understand that there are some problem with migration. But it
>> doesn't look like we need to solve them now. Instead,  AFAICT, his main ask for this series is to switch to a domctl.
>>
>> It seems the conversation is simply stuck on waiting for Andrew to provide details on what would look like. Did we ping Andrew on
>> IRC?
>>
>>        Unfortunately the minimum value
>>        is 32 (in practice I have never seen less than 40 but the architecture
>>        supports 32 as minimum).
>>
>>
>>
>>        Actually, the info we are looking for is already exposed via
>>        ID_AA64MMFR0_EL1. ID_AA64MMFR0_EL1 can be read from a virtual machine,
>>        and Linux let userspace read it [1]. Regardless of this patch series, we
>>        should make sure that Xen exposes the right mm64.pa_range value to guest
>>        virtual machines. If that is done right, then you can just add support
>>        for reading ID_AA64MMFR0_EL1 in libxl/libxc and then we don't need any
>>        hypercall modifications changes.
>>
>>
>>  From my understanding, from a VM PoV "pa_range" should represent the size of the guest physical address space.
>>
>> Today, it happens that every VM is using the same P2M size. However, I would rather not make such assumption in the userspace.
>>
>>
>>        So, in theory we already have all the interfaces we need, but in
>>        practice they don't work: unfortunaly both Xen and Linux mark
>>        ID_AA64MMFR0_EL1 as FTR_HIDDEN in cpufeature.c so neither Linux from
>>        Xen, not userspace from Linux can actually read the real value :-/
>>        They always read zero.
>>
>>        (Also I think we have an issue today with p2m_restrict_ipa_bits not
>>        updating the mm64.pa_range value. I think that it should be fixed.)
>>
>>
>> It looks like it. That should be handled in a separate patch though.
>>
>>
>>        Bertrand, do you have any ideas in regards to ID_AA64MMFR0_EL1?
>>
>>        If not, maybe we could just go with
>>        #define MIN_GPADDR_BITS 32.
>>
>>
>> The toolstack would have to consider it as the "maximum" because it may not be safe to expose anything above.
>>
>> With 32, we are going to be limited in term of space we can find.
>>
>> We could potentially use 40 bits as a minimum. Although it still feels a bit of a hack to me given that the IOMMU may restrict it
>> further and the architecture can in theory support less.
>>
>> Overall, I still strongly prefer the hypercall approach. If a common one is difficult to achieve, then we can extend the domctl to
>> create a domain to provide the p2m_bits (in the same way as we deal for the GIC version) in an arch specific way.
>>
>>
>> To summarize:
>> If we don't query the hypervisor to provide gpaddr_bits we have two options:
>> - The safe option is to use minimum possible value which is 32 bits on Arm64. But, there would be of no practical use.
>> - The unsafe option is to use let's say "default" 40 bits and pray it will work in all cases on Arm64 (it is ok on Arm32).
>>
>> So we definitely need to query the hypervisor. As it turned out the sysctl approach is not welcome, in the long term we want to have this
>> information per domain. I have been absolutely OK with that valid ask since RFC, I just wanted to know what was the preferred way to do
>> this (new domctl, existing, etc)...
>>
>> I analyzed what Julien had suggested regarding pass gpaddr_bits via Arm's struct xen_arch_domainconfig (I assume, this should be an OUT
>> parameter) and I think it makes sense. Taking into the account that the feature freeze date is coming, I will wait a few days, and if there
>> are no objections I will send updated version (patch #3 also needs updating as it expects the gpaddr_bits to be in physinfo).
>
> No objections from me, I think Julien's suggestion is a good one.

ok, great. I have already implemented/tested that.


Thank you.


-- 
Regards,

Oleksandr Tyshchenko



From xen-devel-bounces@lists.xenproject.org Tue Oct 05 21:17:14 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Oct 2021 21:17:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.202485.357430 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXro6-0005Ba-Lo; Tue, 05 Oct 2021 21:17:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 202485.357430; Tue, 05 Oct 2021 21:17:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXro6-0005BT-IO; Tue, 05 Oct 2021 21:17:02 +0000
Received: by outflank-mailman (input) for mailman id 202485;
 Tue, 05 Oct 2021 21:17:00 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+0nn=OZ=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1mXro4-00058H-Ta
 for xen-devel@lists.xenproject.org; Tue, 05 Oct 2021 21:17:00 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 80c3642e-1d5a-4158-b8bb-72179cc55e30;
 Tue, 05 Oct 2021 21:16:59 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id DEE986113A;
 Tue,  5 Oct 2021 21:16:58 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 80c3642e-1d5a-4158-b8bb-72179cc55e30
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1633468619;
	bh=vVpUKV/mCzq5BK6WfvsHKEW0ub8Ks9916D0PECYNHw8=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=EY72OVjaMXVnevUrUORQP09d3F33kHH/mzYoBHJZllQotpvBnkC38yg8mLx+tPaPu
	 mi7tgZdAKt2VIniFd60RNJcgeBzzHA1DXik280sLi1Ob/innAyI+zNI0nwo25SSxWg
	 cefdwYSmpHCzDfq6oxxLiYgGIbj0NP24DdGKv4+zs9mV3AxJUW9CW2UrI82KEMGr78
	 hEcXxAn1x53Gm4XF4C1RwoFZXlqJq9NKoQnptyPyc01hrdlvnMCEoorCzOPVKFssNw
	 3iUFilhv8dQg2wit0R/MGNa7bDHHL9CCV+WmNVm0yl+yhzOhVqkz2ze9h3r2m7wEai
	 otadrvRJkfw1A==
Date: Tue, 5 Oct 2021 14:16:57 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Stefano Stabellini <sstabellini@kernel.org>
cc: Ian Jackson <iwj@xenproject.org>, xen-devel@lists.xenproject.org, 
    jbeulich@suse.com, julien.grall.oss@gmail.com, 
    dpsmith@apertussolutions.com, andrew.cooper3@citrix.com
Subject: Re: [adhoc test] 165359: tolerable truncated
In-Reply-To: <alpine.DEB.2.21.2110041824350.3209@sstabellini-ThinkPad-T480s>
Message-ID: <alpine.DEB.2.21.2110051416040.3209@sstabellini-ThinkPad-T480s>
References: <E1mXTS5-00046z-9X@osstest.test-lab.xenproject.org> <24923.38127.990669.853370@mariner.uk.xensource.com> <alpine.DEB.2.21.2110041824350.3209@sstabellini-ThinkPad-T480s>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Mon, 4 Oct 2021, Stefano Stabellini wrote:
> On Tue, 5 Oct 2021, Ian Jackson wrote:
> > iwj@xenbits.xen.org writes ("[adhoc test] 165359: tolerable truncated"):
> > > [adhoc play] <testing.git master not a tty>
> > > harness 3a3089c9: mfi-common: Drop Linux dom0 i386 tests for newer Lin...
> > > 165359: tolerable truncated
> > ...
> > > Tests which did not succeed, but are not blocking:
> > >  test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail  like 165218
> > >  test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail  like 165218
> > 
> > This means that the kernel patch fixed the problem.  Nothing went
> > wrong here other than that arm64 doesn't support save/restore and
> > migraiton.
> 
> Fantastic! Let me know if you would like my help updating the Linux
> kernel tree for ARM [1].
> 
> [1] git://xenbits.xen.org/arm/linux.git:linux-arm-xen

FYI linux-arm-xen is now updated with Jan's fixes. Hopefully we'll get a
pass from OSSTest in a few hours.


From xen-devel-bounces@lists.xenproject.org Tue Oct 05 21:26:42 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Oct 2021 21:26:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.202493.357441 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXrxO-0006cQ-Iz; Tue, 05 Oct 2021 21:26:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 202493.357441; Tue, 05 Oct 2021 21:26:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXrxO-0006cJ-FM; Tue, 05 Oct 2021 21:26:38 +0000
Received: by outflank-mailman (input) for mailman id 202493;
 Tue, 05 Oct 2021 21:26:37 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Hd/I=OZ=ens-lyon.org=samuel.thibault@srs-us1.protection.inumbo.net>)
 id 1mXrxN-0006cD-7i
 for xen-devel@lists.xenproject.org; Tue, 05 Oct 2021 21:26:37 +0000
Received: from hera.aquilenet.fr (unknown [185.233.100.1])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 008071b5-0b90-4e3c-9f0b-7548d29c184c;
 Tue, 05 Oct 2021 21:26:34 +0000 (UTC)
Received: from localhost (localhost [127.0.0.1])
 by hera.aquilenet.fr (Postfix) with ESMTP id 28C29456;
 Tue,  5 Oct 2021 23:26:33 +0200 (CEST)
Received: from hera.aquilenet.fr ([127.0.0.1])
 by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id Xkkca_-2_iAr; Tue,  5 Oct 2021 23:26:32 +0200 (CEST)
Received: from begin.home (acaen-652-1-186-147.w86-215.abo.wanadoo.fr
 [86.215.106.147])
 by hera.aquilenet.fr (Postfix) with ESMTPSA id 980D9243;
 Tue,  5 Oct 2021 23:26:31 +0200 (CEST)
Received: from samy by begin.home with local (Exim 4.95)
 (envelope-from <samuel.thibault@ens-lyon.org>) id 1mXrxG-00G23n-Fl;
 Tue, 05 Oct 2021 23:26:30 +0200
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 008071b5-0b90-4e3c-9f0b-7548d29c184c
X-Virus-Scanned: Debian amavisd-new at aquilenet.fr
Date: Tue, 5 Oct 2021 23:26:30 +0200
From: Samuel Thibault <samuel.thibault@ens-lyon.org>
To: Juergen Gross <jgross@suse.com>
Cc: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org,
	wl@xen.org
Subject: Re: [PATCH 1/2] mini-os: fix testbuilds regarding CONFIG_XC
Message-ID: <20211005212630.cj7z6xcuyb4iqvyv@begin>
Mail-Followup-To: Samuel Thibault <samuel.thibault@ens-lyon.org>,
	Juergen Gross <jgross@suse.com>, minios-devel@lists.xenproject.org,
	xen-devel@lists.xenproject.org, wl@xen.org
References: <20211004141924.7088-1-jgross@suse.com>
 <20211004141924.7088-2-jgross@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20211004141924.7088-2-jgross@suse.com>
Organization: I am not organized
User-Agent: NeoMutt/20170609 (1.8.3)
X-Spamd-Bar: --
Authentication-Results: hera.aquilenet.fr
X-Rspamd-Server: hera
X-Rspamd-Queue-Id: 28C29456
X-Spamd-Result: default: False [-2.50 / 15.00];
	 ARC_NA(0.00)[];
	 RCVD_VIA_SMTP_AUTH(0.00)[];
	 FROM_HAS_DN(0.00)[];
	 RCPT_COUNT_THREE(0.00)[4];
	 TO_DN_SOME(0.00)[];
	 TO_MATCH_ENVRCPT_ALL(0.00)[];
	 MIME_GOOD(-0.10)[text/plain];
	 HAS_ORG_HEADER(0.00)[];
	 RCVD_COUNT_THREE(0.00)[3];
	 RCVD_NO_TLS_LAST(0.10)[];
	 FROM_EQ_ENVFROM(0.00)[];
	 MID_RHS_NOT_FQDN(0.50)[];
	 BAYES_HAM(-3.00)[100.00%]

Juergen Gross, le lun. 04 oct. 2021 16:19:23 +0200, a ecrit:
> CONFIG_GC is requiring external support, so disable it in testbuilds.
> 
> The only reason this is working right now is its usage being inside
> a HAVE_LIBC section.
> 
> Make that more obvious by making the default setting of CONFIG_XC
> depending on libc being available.
> 
> Signed-off-by: Juergen Gross <jgross@suse.com>

Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>

Thanks!

> ---
>  Config.mk                     | 3 ++-
>  arch/x86/testbuild/all-yes    | 3 ++-
>  arch/x86/testbuild/newxen-yes | 3 ++-
>  3 files changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/Config.mk b/Config.mk
> index 15311ef..8f4cea9 100644
> --- a/Config.mk
> +++ b/Config.mk
> @@ -62,6 +62,7 @@ MINIOS_COMPILE_ARCH    ?= $(shell uname -m | sed -e s/i.86/x86_32/ \
>  MINIOS_TARGET_ARCH     ?= $(MINIOS_COMPILE_ARCH)
>  endif
>  
> +stubdom ?= n
>  libc = $(stubdom)
>  
>  XEN_INTERFACE_VERSION ?= 0x00030205
> @@ -179,7 +180,6 @@ CONFIG-y += CONFIG_FBFRONT
>  CONFIG-y += CONFIG_KBDFRONT
>  CONFIG-y += CONFIG_CONSFRONT
>  CONFIG-y += CONFIG_XENBUS
> -CONFIG-y += CONFIG_XC
>  CONFIG-n += CONFIG_QEMU_XS_ARGS
>  CONFIG-n += CONFIG_TEST
>  CONFIG-n += CONFIG_PCIFRONT
> @@ -195,6 +195,7 @@ CONFIG-y += CONFIG_PARAVIRT
>  else
>  CONFIG-n += CONFIG_PARAVIRT
>  endif
> +CONFIG-$(libc) += CONFIG_XC
>  CONFIG-$(lwip) += CONFIG_LWIP
>  
>  $(foreach i,$(CONFIG-y),$(eval $(i) ?= y))
> diff --git a/arch/x86/testbuild/all-yes b/arch/x86/testbuild/all-yes
> index 8732e69..5464342 100644
> --- a/arch/x86/testbuild/all-yes
> +++ b/arch/x86/testbuild/all-yes
> @@ -13,7 +13,8 @@ CONFIG_FBFRONT = y
>  CONFIG_KBDFRONT = y
>  CONFIG_CONSFRONT = y
>  CONFIG_XENBUS = y
> -CONFIG_XC = y
> +# XC is special: it needs support from outside
> +CONFIG_XC = n
>  # LWIP is special: it needs support from outside
>  CONFIG_LWIP = n
>  CONFIG_BALLOON = y
> diff --git a/arch/x86/testbuild/newxen-yes b/arch/x86/testbuild/newxen-yes
> index 9c30c00..2a3ed2e 100644
> --- a/arch/x86/testbuild/newxen-yes
> +++ b/arch/x86/testbuild/newxen-yes
> @@ -13,7 +13,8 @@ CONFIG_FBFRONT = y
>  CONFIG_KBDFRONT = y
>  CONFIG_CONSFRONT = y
>  CONFIG_XENBUS = y
> -CONFIG_XC = y
> +# XC is special: it needs support from outside
> +CONFIG_XC = n
>  # LWIP is special: it needs support from outside
>  CONFIG_LWIP = n
>  CONFIG_BALLOON = y
> -- 
> 2.26.2
> 

-- 
Samuel
<k> faut en profiter, aujourd'hui, les blagues bidon sont à 100 dollars
 -+- #sos-bourse -+-


From xen-devel-bounces@lists.xenproject.org Tue Oct 05 21:26:56 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Oct 2021 21:26:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.202497.357456 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXrxf-00075H-TD; Tue, 05 Oct 2021 21:26:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 202497.357456; Tue, 05 Oct 2021 21:26:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXrxf-000757-PA; Tue, 05 Oct 2021 21:26:55 +0000
Received: by outflank-mailman (input) for mailman id 202497;
 Tue, 05 Oct 2021 21:26:55 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Hd/I=OZ=ens-lyon.org=samuel.thibault@srs-us1.protection.inumbo.net>)
 id 1mXrxf-0006zz-6w
 for xen-devel@lists.xenproject.org; Tue, 05 Oct 2021 21:26:55 +0000
Received: from hera.aquilenet.fr (unknown [185.233.100.1])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id f3ca4b3a-2622-11ec-bf16-12813bfff9fa;
 Tue, 05 Oct 2021 21:26:52 +0000 (UTC)
Received: from localhost (localhost [127.0.0.1])
 by hera.aquilenet.fr (Postfix) with ESMTP id 037EA456;
 Tue,  5 Oct 2021 23:26:51 +0200 (CEST)
Received: from hera.aquilenet.fr ([127.0.0.1])
 by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id 4XB4179NegOe; Tue,  5 Oct 2021 23:26:50 +0200 (CEST)
Received: from begin.home (acaen-652-1-186-147.w86-215.abo.wanadoo.fr
 [86.215.106.147])
 by hera.aquilenet.fr (Postfix) with ESMTPSA id B2B53243;
 Tue,  5 Oct 2021 23:26:49 +0200 (CEST)
Received: from samy by begin.home with local (Exim 4.95)
 (envelope-from <samuel.thibault@ens-lyon.org>) id 1mXrxZ-00G25D-2x;
 Tue, 05 Oct 2021 23:26:49 +0200
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f3ca4b3a-2622-11ec-bf16-12813bfff9fa
X-Virus-Scanned: Debian amavisd-new at aquilenet.fr
Date: Tue, 5 Oct 2021 23:26:49 +0200
From: Samuel Thibault <samuel.thibault@ens-lyon.org>
To: Juergen Gross <jgross@suse.com>
Cc: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org,
	wl@xen.org
Subject: Re: [PATCH 2/2] mini-os: add config options for xen libraries
Message-ID: <20211005212649.pqlwdgwd4amkzrv7@begin>
Mail-Followup-To: Samuel Thibault <samuel.thibault@ens-lyon.org>,
	Juergen Gross <jgross@suse.com>, minios-devel@lists.xenproject.org,
	xen-devel@lists.xenproject.org, wl@xen.org
References: <20211004141924.7088-1-jgross@suse.com>
 <20211004141924.7088-3-jgross@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20211004141924.7088-3-jgross@suse.com>
Organization: I am not organized
User-Agent: NeoMutt/20170609 (1.8.3)
X-Spamd-Bar: --
Authentication-Results: hera.aquilenet.fr
X-Rspamd-Server: hera
X-Rspamd-Queue-Id: 037EA456
X-Spamd-Result: default: False [-2.50 / 15.00];
	 ARC_NA(0.00)[];
	 RCVD_VIA_SMTP_AUTH(0.00)[];
	 FROM_HAS_DN(0.00)[];
	 RCPT_COUNT_THREE(0.00)[4];
	 TO_DN_SOME(0.00)[];
	 TO_MATCH_ENVRCPT_ALL(0.00)[];
	 MIME_GOOD(-0.10)[text/plain];
	 HAS_ORG_HEADER(0.00)[];
	 RCVD_COUNT_THREE(0.00)[3];
	 RCVD_NO_TLS_LAST(0.10)[];
	 FROM_EQ_ENVFROM(0.00)[];
	 MID_RHS_NOT_FQDN(0.50)[];
	 BAYES_HAM(-3.00)[100.00%]

Juergen Gross, le lun. 04 oct. 2021 16:19:24 +0200, a ecrit:
> Today close hooks into libxenctrl, libxenevtchn and libxengnttab are
> under the CONFIG_XC umbrella. In order to support Mini-OS builds using
> stable Xen libraries only, add CONFIG_LIBXENCTRL, CONFIG_LIBXENEVTCHN
> and CONFIG_LIBXENGNTTAB config options.
> 
> In case CONFIG_XC was specified in the Mini-OS config explicitly, set
> the three new variables to the specified value.
> 
> Signed-off-by: Juergen Gross <jgross@suse.com>

Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>

Thanks!

> ---
>  Config.mk                     | 7 ++++++-
>  arch/x86/testbuild/all-no     | 4 +++-
>  arch/x86/testbuild/all-yes    | 9 +++++----
>  arch/x86/testbuild/newxen-yes | 9 +++++----
>  lib/sys.c                     | 8 ++++++--
>  5 files changed, 25 insertions(+), 12 deletions(-)
> 
> diff --git a/Config.mk b/Config.mk
> index 8f4cea9..5e66089 100644
> --- a/Config.mk
> +++ b/Config.mk
> @@ -195,7 +195,12 @@ CONFIG-y += CONFIG_PARAVIRT
>  else
>  CONFIG-n += CONFIG_PARAVIRT
>  endif
> -CONFIG-$(libc) += CONFIG_XC
> +# Support legacy CONFIG_XC value
> +CONFIG_XC ?= $(libc)
> +CONFIG-$(CONFIG_XC) += CONFIG_LIBXENCTRL
> +CONFIG-$(CONFIG_XC) += CONFIG_LIBXENEVTCHN
> +CONFIG-$(CONFIG_XC) += CONFIG_LIBXENGNTTAB
> +
>  CONFIG-$(lwip) += CONFIG_LWIP
>  
>  $(foreach i,$(CONFIG-y),$(eval $(i) ?= y))
> diff --git a/arch/x86/testbuild/all-no b/arch/x86/testbuild/all-no
> index 1c50bba..7972ecd 100644
> --- a/arch/x86/testbuild/all-no
> +++ b/arch/x86/testbuild/all-no
> @@ -13,7 +13,9 @@ CONFIG_FBFRONT = n
>  CONFIG_KBDFRONT = n
>  CONFIG_CONSFRONT = n
>  CONFIG_XENBUS = n
> -CONFIG_XC = n
> +CONFIG_LIBXENCTRL = n
> +CONFIG_LIBXENEVTCHN = n
> +CONFIG_LIBXENGNTTAB = n
>  CONFIG_LWIP = n
>  CONFIG_BALLOON = n
>  CONFIG_USE_XEN_CONSOLE = n
> diff --git a/arch/x86/testbuild/all-yes b/arch/x86/testbuild/all-yes
> index 5464342..bc8eea5 100644
> --- a/arch/x86/testbuild/all-yes
> +++ b/arch/x86/testbuild/all-yes
> @@ -13,9 +13,10 @@ CONFIG_FBFRONT = y
>  CONFIG_KBDFRONT = y
>  CONFIG_CONSFRONT = y
>  CONFIG_XENBUS = y
> -# XC is special: it needs support from outside
> -CONFIG_XC = n
> -# LWIP is special: it needs support from outside
> -CONFIG_LWIP = n
>  CONFIG_BALLOON = y
>  CONFIG_USE_XEN_CONSOLE = y
> +# The following are special: they need support from outside
> +CONFIG_LIBXENCTRL = n
> +CONFIG_LIBXENEVTCHN = n
> +CONFIG_LIBXENGNTTAB = n
> +CONFIG_LWIP = n
> diff --git a/arch/x86/testbuild/newxen-yes b/arch/x86/testbuild/newxen-yes
> index 2a3ed2e..f72123b 100644
> --- a/arch/x86/testbuild/newxen-yes
> +++ b/arch/x86/testbuild/newxen-yes
> @@ -13,10 +13,11 @@ CONFIG_FBFRONT = y
>  CONFIG_KBDFRONT = y
>  CONFIG_CONSFRONT = y
>  CONFIG_XENBUS = y
> -# XC is special: it needs support from outside
> -CONFIG_XC = n
> -# LWIP is special: it needs support from outside
> -CONFIG_LWIP = n
>  CONFIG_BALLOON = y
>  CONFIG_USE_XEN_CONSOLE = y
>  XEN_INTERFACE_VERSION=__XEN_LATEST_INTERFACE_VERSION__
> +# The following are special: they need support from outside
> +CONFIG_LIBXENCTRL = n
> +CONFIG_LIBXENEVTCHN = n
> +CONFIG_LIBXENGNTTAB = n
> +CONFIG_LWIP = n
> diff --git a/lib/sys.c b/lib/sys.c
> index c6a7b9f..e8d5eb2 100644
> --- a/lib/sys.c
> +++ b/lib/sys.c
> @@ -437,13 +437,17 @@ int close(int fd)
>  	    return res;
>  	}
>  #endif
> -#ifdef CONFIG_XC
> +#ifdef CONFIG_LIBXENCTRL
>  	case FTYPE_XC:
>  	    minios_interface_close_fd(fd);
>  	    return 0;
> +#endif
> +#ifdef CONFIG_LIBXENEVTCHN
>  	case FTYPE_EVTCHN:
>  	    minios_evtchn_close_fd(fd);
>              return 0;
> +#endif
> +#ifdef CONFIG_LIBXENGNTTAB
>  	case FTYPE_GNTMAP:
>  	    minios_gnttab_close_fd(fd);
>  	    return 0;
> @@ -1373,7 +1377,7 @@ void *mmap(void *start, size_t length, int prot, int flags, int fd, off_t offset
>  
>      if (fd == -1)
>          return map_zero(n, 1);
> -#ifdef CONFIG_XC
> +#ifdef CONFIG_LIBXENCTRL
>      else if (files[fd].type == FTYPE_XC) {
>          unsigned long zero = 0;
>          return map_frames_ex(&zero, n, 0, 0, 1, DOMID_SELF, NULL, 0);
> -- 
> 2.26.2
> 

-- 
Samuel
<y> update-menus: relocation error: update-menus: symbol _ZNSt9basic_iosIcSt11char_traitsIcEE4initEPSt15basic_streambufIcS1_E, version GLIBCPP_3.2 not defined in file libstdc++.so.5 with link time reference
<y> quoi que ça peut bien vouloir dire ?
<D> N a eu la meme merde
<y> c ça que ça veut dire ? wow, c'est bien crypté :)
 -+- #ens-mim s'entraide -+-


From xen-devel-bounces@lists.xenproject.org Tue Oct 05 21:32:42 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Oct 2021 21:32:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.202514.357471 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXs38-0000Qz-QI; Tue, 05 Oct 2021 21:32:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 202514.357471; Tue, 05 Oct 2021 21:32:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXs38-0000Qs-Lt; Tue, 05 Oct 2021 21:32:34 +0000
Received: by outflank-mailman (input) for mailman id 202514;
 Tue, 05 Oct 2021 21:32:33 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+0nn=OZ=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1mXs36-0000Qm-U0
 for xen-devel@lists.xenproject.org; Tue, 05 Oct 2021 21:32:32 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id f991b6dd-4581-4b6a-9b77-50f808c71843;
 Tue, 05 Oct 2021 21:32:31 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id 14621615A3;
 Tue,  5 Oct 2021 21:32:30 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f991b6dd-4581-4b6a-9b77-50f808c71843
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1633469550;
	bh=YlbJnHM0xHsD+C0FOzHJtNg4oAskEUCDbj81em40Ogs=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=DCMEd63StdbdYATxvpl1yM4ojvZFjlvKapMP6+1lqvYVi1sphgeAI1cxVbB79yyaT
	 6y+b7OBvzBEeGqgai4pdAv7nMrebOHBrO314bS2owcuNuAoRsr8kvIn5Zd6zrek+7i
	 jcWqAc2v6eXEWOQ4UMjeCGjzBWBbipJjgunhJkIMZz+00h6F4EHF1AaXJwtERNK7M0
	 +r23rV3Pgp+Lrkyyw55UEFJeUvtP9M5d4IBhPiAyYSsPvXlGhym9ODP0DMR3ynqK+D
	 FH3Xy5bcB2ObNJmLUqhn8Ic7ebV9YMBiCwo8VvpsGsqEsKSc2JOBshawU9aDyE76y1
	 IT5Cp5UbBETjg==
Date: Tue, 5 Oct 2021 14:32:29 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Rahul Singh <Rahul.Singh@arm.com>
cc: Stefano Stabellini <sstabellini@kernel.org>, 
    xen-devel <xen-devel@lists.xenproject.org>, 
    Bertrand Marquis <Bertrand.Marquis@arm.com>, 
    Andre Przywara <Andre.Przywara@arm.com>, Ian Jackson <iwj@xenproject.org>, 
    Wei Liu <wl@xen.org>, Anthony PERARD <anthony.perard@citrix.com>, 
    Juergen Gross <jgross@suse.com>, Julien Grall <julien@xen.org>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH v4 13/14] arm/libxl: Emulated PCI device tree node in
 libxl
In-Reply-To: <11F169C6-39A4-40F3-8E75-39B8C2CCF022@arm.com>
Message-ID: <alpine.DEB.2.21.2110051421520.3209@sstabellini-ThinkPad-T480s>
References: <cover.1633340795.git.rahul.singh@arm.com> <3ad42008f534671ae7f5b25da91253ce7cd4a3e9.1633340795.git.rahul.singh@arm.com> <alpine.DEB.2.21.2110041714410.3209@sstabellini-ThinkPad-T480s> <11F169C6-39A4-40F3-8E75-39B8C2CCF022@arm.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: multipart/mixed; BOUNDARY="8323329-1025287936-1633468972=:3209"
Content-ID: <alpine.DEB.2.21.2110051423510.3209@sstabellini-ThinkPad-T480s>

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-1025287936-1633468972=:3209
Content-Type: text/plain; CHARSET=UTF-8
Content-Transfer-Encoding: 8BIT
Content-ID: <alpine.DEB.2.21.2110051423511.3209@sstabellini-ThinkPad-T480s>

On Tue, 5 Oct 2021, Rahul Singh wrote:
> > On 5 Oct 2021, at 1:38 am, Stefano Stabellini <sstabellini@kernel.org> wrote:
> > 
> > On Mon, 4 Oct 2021, Rahul Singh wrote:
> >> libxl will create an emulated PCI device tree node in the device tree to
> >> enable the guest OS to discover the virtual PCI during guest boot.
> >> Emulated PCI device tree node will only be created when there is any
> >> device assigned to guest.
> >> 
> >> A new area has been reserved in the arm guest physical map at
> >> which the VPCI bus is declared in the device tree (reg and ranges
> >> parameters of the node).
> >> 
> >> Signed-off-by: Rahul Singh <rahul.singh@arm.com>
> >> ---
> >> Change in v4:
> >> - Gate code for x86 for setting the XEN_DOMCTL_CDF_vpci for x86.
> >> Change in v3:
> >> - Make GUEST_VPCI_MEM_ADDR address 2MB aligned
> >> Change in v2:
> >> - enable doamin_vpci_init() when XEN_DOMCTL_CDF_vpci is set for domain.
> >> ---
> >> ---
> >> tools/include/libxl.h            |   6 ++
> >> tools/libs/light/libxl_arm.c     | 105 +++++++++++++++++++++++++++++++
> >> tools/libs/light/libxl_create.c  |   9 +++
> >> tools/libs/light/libxl_types.idl |   1 +
> >> tools/xl/xl_parse.c              |   8 +++
> >> xen/include/public/arch-arm.h    |  10 +++
> >> 6 files changed, 139 insertions(+)
> >> 
> >> diff --git a/tools/include/libxl.h b/tools/include/libxl.h
> >> index b9ba16d698..3362073b21 100644
> >> --- a/tools/include/libxl.h
> >> +++ b/tools/include/libxl.h
> >> @@ -358,6 +358,12 @@
> >>  */
> >> #define LIBXL_HAVE_BUILDINFO_ARM_VUART 1
> >> 
> >> +/*
> >> + * LIBXL_HAVE_BUILDINFO_ARM_VPCI indicates that the toolstack supports virtual
> >> + * PCI for ARM.
> >> + */
> >> +#define LIBXL_HAVE_BUILDINFO_ARM_VPCI 1
> >> +
> >> /*
> >>  * LIBXL_HAVE_BUILDINFO_GRANT_LIMITS indicates that libxl_domain_build_info
> >>  * has the max_grant_frames and max_maptrack_frames fields.
> >> diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c
> >> index e3140a6e00..52f1ddce48 100644
> >> --- a/tools/libs/light/libxl_arm.c
> >> +++ b/tools/libs/light/libxl_arm.c
> >> @@ -269,6 +269,58 @@ static int fdt_property_regs(libxl__gc *gc, void *fdt,
> >>     return fdt_property(fdt, "reg", regs, sizeof(regs));
> >> }
> >> 
> >> +static int fdt_property_values(libxl__gc *gc, void *fdt,
> >> +        const char *name, unsigned num_cells, ...)
> >> +{
> >> +    uint32_t prop[num_cells];
> >> +    be32 *cells = &prop[0];
> >> +    int i;
> >> +    va_list ap;
> >> +    uint32_t arg;
> >> +
> >> +    va_start(ap, num_cells);
> >> +    for (i = 0 ; i < num_cells; i++) {
> >> +        arg = va_arg(ap, uint32_t);
> >> +        set_cell(&cells, 1, arg);
> >> +    }
> >> +    va_end(ap);
> >> +
> >> +    return fdt_property(fdt, name, prop, sizeof(prop));
> >> +}
> >> +
> >> +static int fdt_property_vpci_ranges(libxl__gc *gc, void *fdt,
> >> +                                    unsigned addr_cells,
> >> +                                    unsigned size_cells,
> >> +                                    unsigned num_regs, ...)
> >> +{
> >> +    uint32_t regs[num_regs*((addr_cells*2)+size_cells+1)];
> >> +    be32 *cells = &regs[0];
> >> +    int i;
> >> +    va_list ap;
> >> +    uint64_t arg;
> >> +
> >> +    va_start(ap, num_regs);
> >> +    for (i = 0 ; i < num_regs; i++) {
> >> +        /* Set the memory bit field */
> >> +        arg = va_arg(ap, uint32_t);
> >> +        set_cell(&cells, 1, arg);
> >> +
> >> +        /* Set the vpci bus address */
> >> +        arg = addr_cells ? va_arg(ap, uint64_t) : 0;
> >> +        set_cell(&cells, addr_cells , arg);
> >> +
> >> +        /* Set the cpu bus address where vpci address is mapped */
> >> +        set_cell(&cells, addr_cells, arg);
> >> +
> >> +        /* Set the vpci size requested */
> >> +        arg = size_cells ? va_arg(ap, uint64_t) : 0;
> >> +        set_cell(&cells, size_cells, arg);
> >> +    }
> >> +    va_end(ap);
> >> +
> >> +    return fdt_property(fdt, "ranges", regs, sizeof(regs));
> >> +}
> >> +
> >> static int make_root_properties(libxl__gc *gc,
> >>                                 const libxl_version_info *vers,
> >>                                 void *fdt)
> >> @@ -668,6 +720,53 @@ static int make_vpl011_uart_node(libxl__gc *gc, void *fdt,
> >>     return 0;
> >> }
> >> 
> >> +static int make_vpci_node(libxl__gc *gc, void *fdt,
> >> +        const struct arch_info *ainfo,
> >> +        struct xc_dom_image *dom)
> >> +{
> >> +    int res;
> >> +    const uint64_t vpci_ecam_base = GUEST_VPCI_ECAM_BASE;
> >> +    const uint64_t vpci_ecam_size = GUEST_VPCI_ECAM_SIZE;
> >> +    const char *name = GCSPRINTF("pcie@%"PRIx64, vpci_ecam_base);
> >> +
> >> +    res = fdt_begin_node(fdt, name);
> >> +    if (res) return res;
> >> +
> >> +    res = fdt_property_compat(gc, fdt, 1, "pci-host-ecam-generic");
> >> +    if (res) return res;
> >> +
> >> +    res = fdt_property_string(fdt, "device_type", "pci");
> >> +    if (res) return res;
> >> +
> >> +    res = fdt_property_regs(gc, fdt, GUEST_ROOT_ADDRESS_CELLS,
> >> +            GUEST_ROOT_SIZE_CELLS, 1, vpci_ecam_base, vpci_ecam_size);
> >> +    if (res) return res;
> >> +
> >> +    res = fdt_property_values(gc, fdt, "bus-range", 2, 0, 255);
> >> +    if (res) return res;
> >> +
> >> +    res = fdt_property_cell(fdt, "#address-cells", 3);
> >> +    if (res) return res;
> >> +
> >> +    res = fdt_property_cell(fdt, "#size-cells", 2);
> >> +    if (res) return res;
> >> +
> >> +    res = fdt_property_string(fdt, "status", "okay");
> >> +    if (res) return res;
> >> +
> >> +    res = fdt_property_vpci_ranges(gc, fdt, GUEST_ROOT_ADDRESS_CELLS,
> >> +        GUEST_ROOT_SIZE_CELLS, 2,
> >> +        GUEST_VPCI_ADDR_TYPE_MEM, GUEST_VPCI_MEM_ADDR, GUEST_VPCI_MEM_SIZE,
> >> +        GUEST_VPCI_ADDR_TYPE_PREFETCH_MEM, GUEST_VPCI_PREFETCH_MEM_ADDR,
> >> +        GUEST_VPCI_PREFETCH_MEM_SIZE);
> >> +    if (res) return res;
> >> +
> >> +    res = fdt_end_node(fdt);
> >> +    if (res) return res;
> >> +
> >> +    return 0;
> >> +}
> >> +
> >> static const struct arch_info *get_arch_info(libxl__gc *gc,
> >>                                              const struct xc_dom_image *dom)
> >> {
> >> @@ -971,6 +1070,9 @@ next_resize:
> >>         if (info->tee == LIBXL_TEE_TYPE_OPTEE)
> >>             FDT( make_optee_node(gc, fdt) );
> >> 
> >> +        if (libxl_defbool_val(info->arch_arm.vpci))
> >> +            FDT( make_vpci_node(gc, fdt, ainfo, dom) );
> >> +
> >>         if (pfdt)
> >>             FDT( copy_partial_fdt(gc, fdt, pfdt) );
> >> 
> >> @@ -1189,6 +1291,9 @@ void libxl__arch_domain_build_info_setdefault(libxl__gc *gc,
> >>     /* ACPI is disabled by default */
> >>     libxl_defbool_setdefault(&b_info->acpi, false);
> >> 
> >> +    /* VPCI is disabled by default */
> >> +    libxl_defbool_setdefault(&b_info->arch_arm.vpci, false);
> >> +
> >>     if (b_info->type != LIBXL_DOMAIN_TYPE_PV)
> >>         return;
> >> 
> >> diff --git a/tools/libs/light/libxl_create.c b/tools/libs/light/libxl_create.c
> >> index e356b2106d..9408526036 100644
> >> --- a/tools/libs/light/libxl_create.c
> >> +++ b/tools/libs/light/libxl_create.c
> >> @@ -632,6 +632,15 @@ int libxl__domain_make(libxl__gc *gc, libxl_domain_config *d_config,
> >>         if (info->passthrough == LIBXL_PASSTHROUGH_SYNC_PT)
> >>             create.iommu_opts |= XEN_DOMCTL_IOMMU_no_sharept;
> >> 
> >> +#if defined(__arm__) || defined(__aarch64__)
> >> +        /*
> >> +         * Enable VPCI support for ARM. VPCI support for DOMU guest is not
> >> +         * supported for x86.
> >> +         */
> >> +        if ( libxl_defbool_val(b_info->arch_arm.vpci) )
> >> +            create.flags |= XEN_DOMCTL_CDF_vpci;
> >> +#endif
> > 
> > I don't think the #ifdef is required, is it? The check is based on
> > b_info->arch_arm.vpci which is already ARM-specific and couldn't be
> > enabled on X86. We have another similar check in libxl_create.c for
> > d_config->b_info.arch_arm.vuart without #ifdef.
> > 
> > My suggestion would be to just keep the in-code comment, but leave the
> > libxl_defbool_val check as it was before.
> > 
> 
> I also thought the same way that "b_info->arch_arm.vpci|" is arm-specific but somehow it is getting enabled for x86 
> when we assign the PCI device to DOMU guests on x86 PV DOM0 once I remove the #ifdef for below code.
> 
> #if defined(__arm__) || defined(__aarch64__)                   
>     /*                                    
>      * Enable VPCI support for ARM. VPCI support for DOMU guests is not    
>      * supported for x86.                          
>      */                                   
>     if (d_config->num_pcidevs)                        
>       libxl_defbool_set(&b_info->arch_arm.vpci, true);           
> #endif 
> 
> Error on x86:
> Parsing config from guest.cfg
> (XEN) domain.c:667: vPCI cannot be enabled yet
> libxl: error: libxl_create.c:683:libxl__domain_make: domain creation fail: Invalid argument
> libxl: error: libxl_create.c:1237:initiate_domain_create: cannot make domain: -3
> 
> One solution is we can remove the #ifdef from the below code when checking if vpci is enabled…
> #if defined(__arm__) || defined(__aarch64__)                   
>     /*                                    
>      * Enable VPCI support for ARM. VPCI support for DOMU guests is not    
>      * supported for x86.                          
>      */                                   
>     if ( libxl_defbool_val(b_info->arch_arm.vpci) )             
>       create.flags |= XEN_DOMCTL_CDF_vpci;                 
> #endif
> 
> ..but not from here when setting the arch_arm.vpci when we assign the PCI device to the guest.
> 
> #if defined(__arm__) || defined(__aarch64__)                  
>     /*                                    
>      * Enable VPCI support for ARM. VPCI support for DOMU guests is not    
>      * supported for x86.                          
>      */                                   
>     if (d_config->num_pcidevs)                        
>       libxl_defbool_set(&b_info->arch_arm.vpci, true);           
> #endif 
> 
> 
> Also if I remove #ifdef as mention above I need to move the 
>        "libxl_defbool_setdefault(&b_info->arch_arm.vpci, false); “ 
> from 
>        libxl__arch_domain_build_info_setdefault(..) 
> to common code 
>        libxl__domain_build_info_setdefault(..) to avoid error on x86.
> 
> Error on x86:
> root@dom0:~# xl create -c guest.cfg
> Parsing config from guest.cfg
> xl: libxl.c:337: libxl_defbool_val: Assertion `!libxl_defbool_is_default(db)' failed.
> Aborted

As far as I can tell, the #ifdef in libxl_create.c can be removed by
doing:

        if ( libxl_defbool_val(b_info->arch_arm.vpci) > 0 )
            create.flags |= XEN_DOMCTL_CDF_vpci;

because we need to check for LIBXL__DEFBOOL_TRUE, which is > 0, right?
And vpci should never be set on x86. arch_arm.vpci should be initialized
to zero on x86 which is LIBXL__DEFBOOL_DEFAULT. That should work.


On the other hand you are right that the #ifdef in tools/xl/xl_parse.c
cannot just be removed because otherwise b_info->arch_arm.vpci gets set
on x86, which obviously we don't want.
--8323329-1025287936-1633468972=:3209--


From xen-devel-bounces@lists.xenproject.org Tue Oct 05 21:33:04 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Oct 2021 21:33:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.202518.357482 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXs3c-0000vX-1H; Tue, 05 Oct 2021 21:33:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 202518.357482; Tue, 05 Oct 2021 21:33:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXs3b-0000vQ-UH; Tue, 05 Oct 2021 21:33:03 +0000
Received: by outflank-mailman (input) for mailman id 202518;
 Tue, 05 Oct 2021 21:33:02 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mXs3a-0000v3-QD; Tue, 05 Oct 2021 21:33:02 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mXs3a-0004y4-Kb; Tue, 05 Oct 2021 21:33:02 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mXs3a-0001fA-7r; Tue, 05 Oct 2021 21:33:02 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mXs3a-0008RS-79; Tue, 05 Oct 2021 21:33:02 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=RV23MJvCC/FclyXzMEh6FFcimoc2buv+RNuDt61C9Hw=; b=ShG9jz0aIbQoMepk+iTDB01xNi
	c1QAHvHvQcbc+GhgT7Mn5+iUot69AC0o0JGp+6HDMIb7oekuyWd4dwzYxkQdHqT5Zaa0bdErg7x2w
	uVmC3E4QO1mGbHyH2g6PuL0W6vvqttVFTQ7fovYXRz06BTBBmK0xSd1BRllG4QwLQYJk=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165374-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 165374: regressions - FAIL
X-Osstest-Failures:
    qemu-mainline:test-arm64-arm64-libvirt-raw:guest-start/debian.repeat:fail:regression
    qemu-mainline:test-arm64-arm64-xl-vhd:xen-boot:fail:heisenbug
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:windows-install:fail:heisenbug
    qemu-mainline:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=9618c5badaa8eed25259cf095ff880efb939fbe7
X-Osstest-Versions-That:
    qemuu=99c44988d5ba1866a411450c877ed818b1b70081
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 05 Oct 2021 21:33:02 +0000

flight 165374 qemu-mainline real [real]
flight 165389 qemu-mainline real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/165374/
http://logs.test-lab.xenproject.org/osstest/logs/165389/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-arm64-arm64-libvirt-raw 17 guest-start/debian.repeat fail REGR. vs. 164950

Tests which are failing intermittently (not blocking):
 test-arm64-arm64-xl-vhd       8 xen-boot            fail pass in 165389-retest
 test-amd64-i386-xl-qemuu-ws16-amd64 12 windows-install fail pass in 165389-retest

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds    18 guest-start/debian.repeat fail REGR. vs. 164950

Tests which did not succeed, but are not blocking:
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop   fail in 165389 like 164950
 test-arm64-arm64-xl-vhd     14 migrate-support-check fail in 165389 never pass
 test-arm64-arm64-xl-vhd 15 saverestore-support-check fail in 165389 never pass
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 164950
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 164950
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 164950
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 164950
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 164950
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 164950
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 164950
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 qemuu                9618c5badaa8eed25259cf095ff880efb939fbe7
baseline version:
 qemuu                99c44988d5ba1866a411450c877ed818b1b70081

Last test of basis   164950  2021-09-11 18:57:22 Z   24 days
Failing since        164967  2021-09-13 13:06:52 Z   22 days   33 attempts
Testing same since   165374  2021-10-05 05:51:59 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Alex Bennée <alex.bennee@linaro.org>
  Alex Chen <alex.chen@huawei.com>
  Alexander Graf <agraf@csgraf.de>
  Alexandra Clifford <aclifford@draper.com>
  AlexChen <alex.chen@huawei.com>
  Alistair Francis <alistair.francis@wdc.com>
  Amanda Strnad <astrnad@draper.com>
  Andrew Jeffery <andrew@aj.id.au>
  Anup Patel <anup.patel@wdc.com>
  BALATON Zoltan <balaton@eik.bme.hu>
  Bin Meng <bin.meng@windriver.com>
  Bin Meng <bmeng.cn@gmail.com>
  Cai Huoqing <caihuoqing@baidu.com>
  Chris Rauer <crauer@google.com>
  Cleber Rosa <crosa@redhat.com>
  Cornelia Huck <cohuck@redhat.com>
  Cédric Le Goater <clg@kaod.org>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniel P. Berrangé <berrange@redhat.com>
  David Gibson <david@gibson.dropbear.id.au>
  David Hildenbrand <david@redhat.com>
  Dongli Zhang <dongli.zhang@oracle.com>
  Dr. David Alan Gilbert <dgilbert@redhat.com>
  Edgar E. Iglesias <edgar.iglesias@xilinx.com>
  Eric Blake <eblake@redhat.com>
  Frank Chang <frank.chang@sifive.com>
  G S Niteesh Babu <niteesh.gs@gmail.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Green Wan <green.wan@sifive.com>
  Guenter Roeck <linux@roeck-us.net>
  Hanna Reitz <hreitz@redhat.com>
  Igor Mammedov <imammedo@redhat.com>
  Ilya Leoshkevich <iii@linux.ibm.com>
  Jason Wang <jasowang@redhat.com>
  Joel Stanley <joel@jms.id.au>
  John Arbuckle <programmingkidx@gmail.com>
  John Snow <jsnow@redhat.com>
  John Snow <jsnow@redhat.com> (Feel free to merge.)
  Jose R. Ziviani <jziviani@suse.de>
  Justin Restivo <jrestivo@draper.com>
  Kai Huang <kai.huang@intel.com>
  Kirill Tkhai <ktkhai@virtuozzo.com>
  Klaus Jensen <k.jensen@samsung.com>
  Lara Lazier <laramglazier@gmail.com>
  Laurent Vivier <laurent@vivier.eu>
  LIU Zhiwei <zhiwei_liu@c-sky.com>
  Luc Michel <lmichel@kalray.eu>
  Luis Pires <luis.pires@eldorado.org.br>
  Marc Zyngier <maz@kernel.org>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
  Markus Armbruster <armbru@redhat.com>
  Matheus Ferst <matheus.ferst@eldorado.org.br>
  Max Hsu <max.hsu@sifive.com>
  Max Reitz <mreitz@redhat.com>
  Michael S. Tsirkin <mst@redhat.com>
  Michael Tokarev <mjt@tls.msk.ru>
  Michal Privoznik <mprivozn@redhat.com>
  Naveen Nagar <naveen.n1@samsung.com>
  Neil Armstrong <narmstrong@baylibre.com>
  nia <nia@NetBSD.org>
  Nia Alarie <nia@NetBSD.org>
  Niek Linnenbank <nieklinnenbank@gmail.com>
  Nir Soffer <nirsof@gmail.com>
  Nir Soffer <nsoffer@redhat.com>
  Pankaj Gupta <pankaj.gupta.linux@gmail.com>
  Pankaj Raghav <p.raghav@samsung.com>
  Paolo Bonzini <pbonzini@redhat.com>
  Pavel Dovgalyuk <Pavel.Dovgaluk@ispras.ru>
  Pavel Dovgalyuk <Pavel.Dovgalyuk@ispras.ru>
  Peter Collingbourne <pcc@google.com>
  Peter Delevoryas <pdel@fb.com>
  Peter Maydell <peter.maydell@linaro.org>
  Peter Xu <peterx@redhat.com>
  Philippe Mathieu-Daudé <f4bug@amsat.org>
  Philippe Mathieu-Daudé <philmd@redhat.com>
  Reinoud Zandijk <Reinoud@NetBSD.org>
  Richard Henderson <richard.henderson@linaro.org>
  Richard W.M. Jones <rjones@redhat.com>
  Roman Bolshakov <r.bolshakov@yadro.com>
  Roman Bolshakov <r.bolshakov@yadro.com> (x86 only)
  Sai Pavan Boddu <sai.pavan.boddu@xilinx.com>
  Sean Christopherson <sean.j.christopherson@intel.com>
  Sergio Lopez <slp@redhat.com>
  Shashi Mallela <shashi.mallela@linaro.org>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Weil <sw@weilnetz.de>
  Stefano Garzarella <sgarzare@redhat.com>
  Thomas Huth <thuth@redhat.com>
  Tong Ho <tong.ho@xilinx.com>
  Viktor Prutyanov <viktor.prutyanov@phystech.edu>
  Vitaly Kuznetsov <vkuznets@redhat.com>
  Vivek Kasireddy <vivek.kasireddy@intel.com>
  Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
  Wainer dos Santos Moschetta <wainersm@redhat.com>
  Willian Rampazzo <willianr@redhat.com>
  Xuzhou Cheng <xuzhou.cheng@windriver.com>
  Yanan Wang <wangyanan55@huawei.com>
  Yang Zhong <yang.zhong@intel.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 fail    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      fail    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 11682 lines long.)


From xen-devel-bounces@lists.xenproject.org Tue Oct 05 21:36:13 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Oct 2021 21:36:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.202533.357496 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXs6e-0001lq-Nk; Tue, 05 Oct 2021 21:36:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 202533.357496; Tue, 05 Oct 2021 21:36:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXs6e-0001lj-KV; Tue, 05 Oct 2021 21:36:12 +0000
Received: by outflank-mailman (input) for mailman id 202533;
 Tue, 05 Oct 2021 21:36:11 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+0nn=OZ=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1mXs6d-0001ld-T1
 for xen-devel@lists.xenproject.org; Tue, 05 Oct 2021 21:36:11 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 41ca3360-2624-11ec-bf18-12813bfff9fa;
 Tue, 05 Oct 2021 21:36:11 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id 05D06615A3;
 Tue,  5 Oct 2021 21:36:09 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 41ca3360-2624-11ec-bf18-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1633469770;
	bh=YqAo10Q6c6Ntcw77oIEBE73z4W5HOSuzMrtpiAVLMUM=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=ZLjeiNJVK7lxK+7DhTTGcVKC19QZJBpioOwBqqXFiFovTLWat7TrudAIYhCmbz8LT
	 Z22pJzRq+lsYTbqVy9HDRyndV6CFWbA71IU1FyR3jUfJEn6Y7TypEH7gl3BWVOqsR/
	 SQ6oxtsd2IV+C5AjRuvt2QWwvcKeV1FImiK67AW/ZrOJ+gY350eUvbXDYbF8X/Ub3+
	 hCnJ5z90rwjuIhk+AFv1fha1VjcCU9yqtjxYL9UEl57uCaQgE4u+DZIA/c5RICcmFb
	 FbHple7JOfOsMLzzxOBD6qlWL/yucuY31cxsaxFa1PPBcwNcoooRXZqtNOTBmv48Sr
	 ZaYxSmVIeT88g==
Date: Tue, 5 Oct 2021 14:36:09 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Oleksandr <olekstysh@gmail.com>
cc: Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>, 
    xen-devel@lists.xenproject.org, 
    Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, 
    Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>, 
    Anthony PERARD <anthony.perard@citrix.com>, 
    Juergen Gross <jgross@suse.com>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH V4 3/3] libxl/arm: Add handling of extended regions for
 DomU
In-Reply-To: <c0184478-4af1-d9e8-a527-49ae7eebcc70@gmail.com>
Message-ID: <alpine.DEB.2.21.2110051435200.3209@sstabellini-ThinkPad-T480s>
References: <1632955927-27911-1-git-send-email-olekstysh@gmail.com> <1632955927-27911-4-git-send-email-olekstysh@gmail.com> <c0184478-4af1-d9e8-a527-49ae7eebcc70@gmail.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Tue, 5 Oct 2021, Oleksandr wrote:
> > From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> > 
> > The extended region (safe range) is a region of guest physical
> > address space which is unused and could be safely used to create
> > grant/foreign mappings instead of wasting real RAM pages from
> > the domain memory for establishing these mappings.
> > 
> > The extended regions are chosen at the domain creation time and
> > advertised to it via "reg" property under hypervisor node in
> > the guest device-tree. As region 0 is reserved for grant table
> > space (always present), the indexes for extended regions are 1...N.
> > If extended regions could not be allocated for some reason,
> > Xen doesn't fail and behaves as usual, so only inserts region 0.
> > 
> > Please note the following limitations:
> > - The extended region feature is only supported for 64-bit domain
> >    currently.
> > - The ACPI case is not covered.
> > 
> > ***
> > 
> > The algorithm to choose extended regions for non-direct mapped
> > DomU is simpler in comparison with the algorithm for direct mapped
> > Dom0. As we have a lot of unused space above 4GB, provide single
> > 2MB-aligned region from the second RAM bank taking into the account
> > the maximum supported guest address space size and the amount of
> > memory assigned to the guest. The maximum size of the region is 128GB.
> > The minimum size is 64MB.
> > 
> > Suggested-by: Julien Grall <jgrall@amazon.com>
> > Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> > Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
> > Acked-by: Ian Jackson <iwj@xenproject.org>
> > Reviewed-by: Michal Orzel <michal.orzel@arm.com>
> > Tested-by: Michal Orzel <michal.orzel@arm.com>
> 
> I though a bit more on this and decided to make a patch more functional by
> trying to also allocate extended region below 4GB, I think we could do with
> it.
> Actually if guest memory size is less than GUEST_RAM0_SIZE, we are able to
> provide unused space. I have tested with with various guest memory sizes and
> it worked fine. Also I decided to drop limit for maximum extended region size
> (128GB), we don't apply this limit in Dom0 and I don't see why we need it
> here, moreover the calculation became more obvious. I will drop all acks and
> send updated version. Are there any objections?

I am OK with it; it looks like you made good improvements. One caveat is
that I volunteer to review again no problem, but we'll need a new ack
from Ian Jackson to commit.


From xen-devel-bounces@lists.xenproject.org Tue Oct 05 21:43:19 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Oct 2021 21:43:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.202541.357506 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXsDT-0003Dd-EY; Tue, 05 Oct 2021 21:43:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 202541.357506; Tue, 05 Oct 2021 21:43:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXsDT-0003DW-BR; Tue, 05 Oct 2021 21:43:15 +0000
Received: by outflank-mailman (input) for mailman id 202541;
 Tue, 05 Oct 2021 21:43:14 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+0nn=OZ=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1mXsDS-0003DQ-51
 for xen-devel@lists.xenproject.org; Tue, 05 Oct 2021 21:43:14 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 065234ea-c291-4e00-bae3-1324592daf8a;
 Tue, 05 Oct 2021 21:43:12 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id 03EB361165;
 Tue,  5 Oct 2021 21:43:10 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 065234ea-c291-4e00-bae3-1324592daf8a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1633470191;
	bh=wnR104F1MYfNqGRFlrRsxS88Q/KewO3sWMfja61J1+c=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=S2PY4aeL/GC83eMsqARfrFO3Q65N4oBhVC79jderkBMiYC5veQ2krvvvoaRPbVYXW
	 qxoG1YpAcl/zFA4oAXI7NY9iGoh0NKVl7NP3CGUbY2Wz5waR5Yl3BEiWu0/MUwXfvA
	 M2OQXW3v4aEjKlBjkvaHq1/mkbJA10tRc+zdfipfC31t7vDX5xQU30wXAsXqZg7Qkz
	 fOHSosTkzDiLC+CkifhBzF5JHoil6vnfQTz5C2hYypaanmDJK3aLkvxuNQOyaBsOIP
	 eAp5z0i+GJyWqRtM0CFZfISHoAWThIJk0aScv/h4qYMxVNQy9R7/ilg8xS19A5Hjlb
	 sLkYnGlpk3Lpw==
Date: Tue, 5 Oct 2021 14:43:10 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
cc: Stefano Stabellini <sstabellini@kernel.org>, 
    "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, 
    "julien@xen.org" <julien@xen.org>, 
    Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, 
    Artem Mygaiev <Artem_Mygaiev@epam.com>, 
    "roger.pau@citrix.com" <roger.pau@citrix.com>, 
    "jbeulich@suse.com" <jbeulich@suse.com>, 
    "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>, 
    "george.dunlap@citrix.com" <george.dunlap@citrix.com>, 
    "paul@xen.org" <paul@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>, 
    Rahul Singh <rahul.singh@arm.com>
Subject: Re: [PATCH v4 10/11] xen/arm: Do not map PCI ECAM and MMIO space to
 Domain-0's p2m
In-Reply-To: <7b42e2aa-658a-74a1-045a-a35fb89a37b0@epam.com>
Message-ID: <alpine.DEB.2.21.2110051438140.3209@sstabellini-ThinkPad-T480s>
References: <20211004141151.132231-1-andr2000@gmail.com> <20211004141151.132231-11-andr2000@gmail.com> <alpine.DEB.2.21.2110041812270.3209@sstabellini-ThinkPad-T480s> <7b42e2aa-658a-74a1-045a-a35fb89a37b0@epam.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Tue, 5 Oct 2021, Oleksandr Andrushchenko wrote:
> On 05.10.21 04:24, Stefano Stabellini wrote:
> > On Mon, 4 Oct 2021, Oleksandr Andrushchenko wrote:
> >> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> >>
> >> PCI host bridges are special devices in terms of implementing PCI
> >> passthrough. According to [1] the current implementation depends on
> >> Domain-0 to perform the initialization of the relevant PCI host
> >> bridge hardware and perform PCI device enumeration. In order to
> >> achieve that one of the required changes is to not map all the memory
> >> ranges in map_range_to_domain as we traverse the device tree on startup
> >> and perform some additional checks if the range needs to be mapped to
> >> Domain-0.
> >>
> >> The generic PCI host controller device tree binding says [2]:
> >> - ranges: As described in IEEE Std 1275-1994, but must provide
> >>            at least a definition of non-prefetchable memory. One
> >>            or both of prefetchable Memory and IO Space may also
> >>            be provided.
> >>
> >> - reg   : The Configuration Space base address and size, as accessed
> >>            from the parent bus.  The base address corresponds to
> >>            the first bus in the "bus-range" property.  If no
> >>            "bus-range" is specified, this will be bus 0 (the default).
> >>
> >> >From the above none of the memory ranges from the "ranges" property
> >> needs to be mapped to Domain-0 at startup as MMIO mapping is going to
> >> be handled dynamically by vPCI as we assign PCI devices, e.g. each
> >> device assigned to Domain-0/guest will have its MMIOs mapped/unmapped
> >> as needed by Xen.
> >>
> >> The "reg" property covers not only ECAM space, but may also have other
> >> then the configuration memory ranges described, for example [3]:
> >> - reg: Should contain rc_dbi, config registers location and length.
> >> - reg-names: Must include the following entries:
> >>     "rc_dbi": controller configuration registers;
> >>     "config": PCIe configuration space registers.
> >>
> >> This patch makes it possible to not map all the ranges from the
> >> "ranges" property and also ECAM from the "reg". All the rest from the
> >> "reg" property still needs to be mapped to Domain-0, so the PCI
> >> host bridge remains functional in Domain-0.
> >>
> >> [1] https://lists.xenproject.org/archives/html/xen-devel/2020-07/msg00777.html
> >> [2] https://www.kernel.org/doc/Documentation/devicetree/bindings/pci/host-generic-pci.txt
> >> [3] https://www.kernel.org/doc/Documentation/devicetree/bindings/pci/hisilicon-pcie.txt
> >>
> >> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> >> ---
> >> Since v3:
> >>   - pass struct map_range_data to map_dt_irq_to_domain
> >>   - remove redundant check from map_range_to_domain
> >>   - fix handle_device's .skip_mapping
> >> Since v2:
> >>   - removed check in map_range_to_domain for PCI_DEV
> >>     and moved it to handle_device, so the code is
> >>     simpler
> >>   - s/map_pci_bridge/skip_mapping
> >>   - extended comment in pci_host_bridge_mappings
> >>   - minor code restructure in construct_dom0
> >>   - s/.need_p2m_mapping/.need_p2m_hwdom_mapping and related
> >>     callbacks
> >>   - unsigned int i; in pci_host_bridge_mappings
> >> Since v1:
> >>   - Added better description of why and what needs to be mapped into
> >>     Domain-0's p2m and what doesn't
> >>   - Do not do any mappings for PCI devices while traversing the DT
> >>   - Walk all the bridges and make required mappings in one go
> >> ---
> >>   xen/arch/arm/domain_build.c        | 50 ++++++++++++++++--------------
> >>   xen/arch/arm/pci/ecam.c            | 14 +++++++++
> >>   xen/arch/arm/pci/pci-host-common.c | 49 +++++++++++++++++++++++++++++
> >>   xen/arch/arm/pci/pci-host-zynqmp.c |  1 +
> >>   xen/include/asm-arm/pci.h          | 10 ++++++
> >>   xen/include/asm-arm/setup.h        | 13 ++++++++
> >>   6 files changed, 114 insertions(+), 23 deletions(-)
> >>
> >> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
> >> index 8739e3285ef4..2a3c641476bd 100644
> >> --- a/xen/arch/arm/domain_build.c
> >> +++ b/xen/arch/arm/domain_build.c
> >> @@ -10,7 +10,6 @@
> >>   #include <asm/regs.h>
> >>   #include <xen/errno.h>
> >>   #include <xen/err.h>
> >> -#include <xen/device_tree.h>
> >>   #include <xen/libfdt/libfdt.h>
> >>   #include <xen/guest_access.h>
> >>   #include <xen/iocap.h>
> >> @@ -51,12 +50,6 @@ static int __init parse_dom0_mem(const char *s)
> >>   }
> >>   custom_param("dom0_mem", parse_dom0_mem);
> >>   
> >> -struct map_range_data
> >> -{
> >> -    struct domain *d;
> >> -    p2m_type_t p2mt;
> >> -};
> >> -
> >>   /* Override macros from asm/page.h to make them work with mfn_t */
> >>   #undef virt_to_mfn
> >>   #define virt_to_mfn(va) _mfn(__virt_to_mfn(va))
> >> @@ -1641,10 +1634,11 @@ static int __init map_dt_irq_to_domain(const struct dt_device_node *dev,
> >>                                          const struct dt_irq *dt_irq,
> >>                                          void *data)
> >>   {
> >> -    struct domain *d = data;
> >> +    struct map_range_data *mr_data = data;
> >> +    struct domain *d = mr_data->d;
> >>       unsigned int irq = dt_irq->irq;
> >>       int res;
> >> -    bool need_mapping = !dt_device_for_passthrough(dev);
> >> +    bool need_mapping = !mr_data->skip_mapping;
> >>   
> >>       if ( irq < NR_LOCAL_IRQS )
> >>       {
> >> @@ -1668,13 +1662,12 @@ static int __init map_dt_irq_to_domain(const struct dt_device_node *dev,
> >>       return 0;
> >>   }
> >>   
> >> -static int __init map_range_to_domain(const struct dt_device_node *dev,
> >> -                                      u64 addr, u64 len,
> >> -                                      void *data)
> >> +int __init map_range_to_domain(const struct dt_device_node *dev,
> >> +                               u64 addr, u64 len, void *data)
> >>   {
> >>       struct map_range_data *mr_data = data;
> >>       struct domain *d = mr_data->d;
> >> -    bool need_mapping = !dt_device_for_passthrough(dev);
> >> +    bool need_mapping = !mr_data->skip_mapping;
> >>       int res;
> >>   
> >>       /*
> >> @@ -1726,23 +1719,21 @@ static int __init map_range_to_domain(const struct dt_device_node *dev,
> >>    * then we may need to perform additional mappings in order to make
> >>    * the child resources available to domain 0.
> >>    */
> >> -static int __init map_device_children(struct domain *d,
> >> -                                      const struct dt_device_node *dev,
> >> -                                      p2m_type_t p2mt)
> >> +static int __init map_device_children(const struct dt_device_node *dev,
> >> +                                      struct map_range_data *mr_data)
> >>   {
> >> -    struct map_range_data mr_data = { .d = d, .p2mt = p2mt };
> >> -    int ret;
> >> -
> >>       if ( dt_device_type_is_equal(dev, "pci") )
> >>       {
> >> +        int ret;
> >> +
> >>           dt_dprintk("Mapping children of %s to guest\n",
> >>                      dt_node_full_name(dev));
> >>   
> >> -        ret = dt_for_each_irq_map(dev, &map_dt_irq_to_domain, d);
> >> +        ret = dt_for_each_irq_map(dev, &map_dt_irq_to_domain, mr_data);
> >>           if ( ret < 0 )
> >>               return ret;
> >>   
> >> -        ret = dt_for_each_range(dev, &map_range_to_domain, &mr_data);
> >> +        ret = dt_for_each_range(dev, &map_range_to_domain, mr_data);
> >>           if ( ret < 0 )
> >>               return ret;
> >>       }
> >> @@ -1823,6 +1814,13 @@ static int __init handle_device(struct domain *d, struct dt_device_node *dev,
> >>       int res;
> >>       u64 addr, size;
> >>       bool need_mapping = !dt_device_for_passthrough(dev);
> >> +    struct map_range_data mr_data = {
> >> +        .d = d,
> >> +        .p2mt = p2mt,
> >> +        .skip_mapping = !need_mapping ||
> >> +                        (is_pci_passthrough_enabled() &&
> >> +                         (device_get_class(dev) == DEVICE_PCI))
> >> +    };
> > I would prefer if we did this:
> >
> > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
> > index 2a3c641476..1e7cdd11c7 100644
> > --- a/xen/arch/arm/domain_build.c
> > +++ b/xen/arch/arm/domain_build.c
> > @@ -1813,13 +1813,13 @@ static int __init handle_device(struct domain *d, struct dt_device_node *dev,
> >       unsigned int i;
> >       int res;
> >       u64 addr, size;
> > -    bool need_mapping = !dt_device_for_passthrough(dev);
> > +    bool need_mapping = !dt_device_for_passthrough(dev) &&
> > +                        !(is_pci_passthrough_enabled() &&
> > +                          (device_get_class(dev) == DEVICE_PCI))
> >       struct map_range_data mr_data = {
> >           .d = d,
> >           .p2mt = p2mt,
> > -        .skip_mapping = !need_mapping ||
> > -                        (is_pci_passthrough_enabled() &&
> > -                         (device_get_class(dev) == DEVICE_PCI))
> > +        .skip_mapping = !need_mapping
> >       };
> >   
> >       naddr = dt_number_of_address(dev);
> >
> >
> > This actually makes a difference because otherwise
> > handle_device_interrupts could still be called with need_mapping ==
> > true for PCI devices.
> And this is totally fine. Remember the name of the patch: we do not
> want to map memory, but interrupts are still needed for the bridge to
> function in Dom0. The same as it needs all, but "cfg" from "regs".
> So, need_mapping == true for interrupts is what we want: legacy INTx
> are not supported by design and only MSI/MSI-X are supported.

Ah, makes sense, I momentarily lost sight of that. Could you please add
an in-code comment to explain it, something like:

/*
 * For PCI passthrough we need to remap only interrupts to Dom0. MMIO
 * regions of the PCIe Root Complex and PCIe aperture should not be
 * mapped automatically to Dom0.
 */
struct map_range_data mr_data = {
        .d = d,
        .p2mt = p2mt,
        .skip_mapping = !need_mapping ||
                        (is_pci_passthrough_enabled() &&
                         (device_get_class(dev) == DEVICE_PCI))
    };


> >
> > What do you think?  One more comment below.
> >
> >
> >>       naddr = dt_number_of_address(dev);
> >>   
> >> @@ -1862,7 +1860,6 @@ static int __init handle_device(struct domain *d, struct dt_device_node *dev,
> >>       /* Give permission and map MMIOs */
> >>       for ( i = 0; i < naddr; i++ )
> >>       {
> >> -        struct map_range_data mr_data = { .d = d, .p2mt = p2mt };
> >>           res = dt_device_get_address(dev, i, &addr, &size);
> >>           if ( res )
> >>           {
> >> @@ -1876,7 +1873,7 @@ static int __init handle_device(struct domain *d, struct dt_device_node *dev,
> >>               return res;
> >>       }
> >>   
> >> -    res = map_device_children(d, dev, p2mt);
> >> +    res = map_device_children(dev, &mr_data);
> >>       if ( res )
> >>           return res;
> >>   
> >> @@ -3034,7 +3031,14 @@ static int __init construct_dom0(struct domain *d)
> >>           return rc;
> >>   
> >>       if ( acpi_disabled )
> >> +    {
> >>           rc = prepare_dtb_hwdom(d, &kinfo);
> >> +        if ( rc < 0 )
> >> +            return rc;
> >> +#ifdef CONFIG_HAS_PCI
> >> +        rc = pci_host_bridge_mappings(d, p2m_mmio_direct_c);
> >> +#endif
> >> +    }
> >>       else
> >>           rc = prepare_acpi(d, &kinfo);
> >>   
> >> diff --git a/xen/arch/arm/pci/ecam.c b/xen/arch/arm/pci/ecam.c
> >> index 602d00799c8d..b81620074a91 100644
> >> --- a/xen/arch/arm/pci/ecam.c
> >> +++ b/xen/arch/arm/pci/ecam.c
> >> @@ -40,6 +40,19 @@ void __iomem *pci_ecam_map_bus(struct pci_host_bridge *bridge,
> >>       return base + (PCI_DEVFN2(sbdf.bdf) << devfn_shift) + where;
> >>   }
> >>   
> >> +bool pci_ecam_need_p2m_hwdom_mapping(struct domain *d,
> >> +                                     struct pci_host_bridge *bridge,
> >> +                                     uint64_t addr)
> >> +{
> >> +    struct pci_config_window *cfg = bridge->cfg;
> >> +
> >> +    /*
> >> +     * We do not want ECAM address space to be mapped in Domain-0's p2m,
> >> +     * so we can trap access to it.
> >> +     */
> >> +    return cfg->phys_addr != addr;
> >> +}
> >> +
> >>   /* ECAM ops */
> >>   const struct pci_ecam_ops pci_generic_ecam_ops = {
> >>       .bus_shift  = 20,
> >> @@ -47,6 +60,7 @@ const struct pci_ecam_ops pci_generic_ecam_ops = {
> >>           .map_bus                = pci_ecam_map_bus,
> >>           .read                   = pci_generic_config_read,
> >>           .write                  = pci_generic_config_write,
> >> +        .need_p2m_hwdom_mapping = pci_ecam_need_p2m_hwdom_mapping,
> >>       }
> >>   };
> >>   
> >> diff --git a/xen/arch/arm/pci/pci-host-common.c b/xen/arch/arm/pci/pci-host-common.c
> >> index 1eb4daa87365..085f08e23e0c 100644
> >> --- a/xen/arch/arm/pci/pci-host-common.c
> >> +++ b/xen/arch/arm/pci/pci-host-common.c
> >> @@ -18,6 +18,7 @@
> >>   
> >>   #include <xen/init.h>
> >>   #include <xen/pci.h>
> >> +#include <asm/setup.h>
> >>   #include <xen/rwlock.h>
> >>   #include <xen/sched.h>
> >>   #include <xen/vmap.h>
> >> @@ -320,6 +321,54 @@ int pci_host_get_num_bridges(void)
> >>       return count;
> >>   }
> >>   
> >> +int __init pci_host_bridge_mappings(struct domain *d, p2m_type_t p2mt)
> >> +{
> >> +    struct pci_host_bridge *bridge;
> >> +    struct map_range_data mr_data = {
> >> +        .d = d,
> >> +        .p2mt = p2mt,
> >> +        .skip_mapping = false
> >> +    };
> >> +
> >> +    /*
> >> +     * For each PCI host bridge we need to only map those ranges
> >> +     * which are used by Domain-0 to properly initialize the bridge,
> >> +     * e.g. we do not want to map ECAM configuration space which lives in
> >> +     * "reg" or "assigned-addresses" device tree property, but we want to
> >> +     * map other regions of the host bridge. The PCI aperture defined by
> >> +     * the "ranges" device tree property should also be skipped.
> >> +     */
> >> +    list_for_each_entry( bridge, &pci_host_bridges, node )
> >> +    {
> >> +        const struct dt_device_node *dev = bridge->dt_node;
> >> +        unsigned int i;
> >> +
> >> +        for ( i = 0; i < dt_number_of_address(dev); i++ )
> >> +        {
> >> +            uint64_t addr, size;
> >> +            int err;
> >> +
> >> +            err = dt_device_get_address(dev, i, &addr, &size);
> >> +            if ( err )
> >> +            {
> >> +                printk(XENLOG_ERR
> >> +                       "Unable to retrieve address range index=%u for %s\n",
> >> +                       i, dt_node_full_name(dev));
> >> +                return err;
> >> +            }
> >> +
> >> +            if ( bridge->ops->need_p2m_hwdom_mapping(d, bridge, addr) )
> >> +            {
> >> +                err = map_range_to_domain(dev, addr, size, &mr_data);
> >> +                if ( err )
> >> +                    return err;
> >> +            }
> >> +        }
> >> +    }
> >> +
> >> +    return 0;
> >> +}
> >> +
> >>   /*
> >>    * Local variables:
> >>    * mode: C
> >> diff --git a/xen/arch/arm/pci/pci-host-zynqmp.c b/xen/arch/arm/pci/pci-host-zynqmp.c
> >> index 61a9807d3d58..6ad2b31e810d 100644
> >> --- a/xen/arch/arm/pci/pci-host-zynqmp.c
> >> +++ b/xen/arch/arm/pci/pci-host-zynqmp.c
> >> @@ -34,6 +34,7 @@ const struct pci_ecam_ops nwl_pcie_ops = {
> >>           .map_bus                = pci_ecam_map_bus,
> >>           .read                   = pci_generic_config_read,
> >>           .write                  = pci_generic_config_write,
> >> +        .need_p2m_hwdom_mapping = pci_ecam_need_p2m_hwdom_mapping,
> >>       }
> >>   };
> >>   
> >> diff --git a/xen/include/asm-arm/pci.h b/xen/include/asm-arm/pci.h
> >> index a62d8bc60086..d9a3c2a4f3b3 100644
> >> --- a/xen/include/asm-arm/pci.h
> >> +++ b/xen/include/asm-arm/pci.h
> >> @@ -17,6 +17,8 @@
> >>   
> >>   #ifdef CONFIG_HAS_PCI
> >>   
> >> +#include <asm/p2m.h>
> >> +
> >>   #define pci_to_dev(pcidev) (&(pcidev)->arch.dev)
> >>   
> >>   extern bool_t pci_passthrough_enabled;
> >> @@ -73,6 +75,9 @@ struct pci_ops {
> >>                   uint32_t reg, uint32_t len, uint32_t *value);
> >>       int (*write)(struct pci_host_bridge *bridge, pci_sbdf_t sbdf,
> >>                    uint32_t reg, uint32_t len, uint32_t value);
> >> +    bool (*need_p2m_hwdom_mapping)(struct domain *d,
> >> +                                   struct pci_host_bridge *bridge,
> >> +                                   uint64_t addr);
> >>   };
> >>   
> >>   /*
> >> @@ -96,6 +101,9 @@ int pci_generic_config_write(struct pci_host_bridge *bridge, pci_sbdf_t sbdf,
> >>                                uint32_t reg, uint32_t len, uint32_t value);
> >>   void __iomem *pci_ecam_map_bus(struct pci_host_bridge *bridge,
> >>                                  pci_sbdf_t sbdf, uint32_t where);
> >> +bool pci_ecam_need_p2m_hwdom_mapping(struct domain *d,
> >> +                                     struct pci_host_bridge *bridge,
> >> +                                     uint64_t addr);
> >>   struct pci_host_bridge *pci_find_host_bridge(uint16_t segment, uint8_t bus);
> >>   int pci_get_host_bridge_segment(const struct dt_device_node *node,
> >>                                   uint16_t *segment);
> >> @@ -113,6 +121,8 @@ int pci_host_iterate_bridges(struct domain *d,
> >>                                           struct pci_host_bridge *bridge));
> >>   int pci_host_get_num_bridges(void);
> >>   
> >> +int pci_host_bridge_mappings(struct domain *d, p2m_type_t p2mt);
> >> +
> >>   #else   /*!CONFIG_HAS_PCI*/
> >>   
> >>   struct arch_pci_dev { };
> >> diff --git a/xen/include/asm-arm/setup.h b/xen/include/asm-arm/setup.h
> >> index 95da0b7ab9cd..5b30135fda38 100644
> >> --- a/xen/include/asm-arm/setup.h
> >> +++ b/xen/include/asm-arm/setup.h
> >> @@ -2,6 +2,8 @@
> >>   #define __ARM_SETUP_H_
> >>   
> >>   #include <public/version.h>
> >> +#include <asm/p2m.h>
> >> +#include <xen/device_tree.h>
> >>   
> >>   #define MIN_FDT_ALIGN 8
> >>   #define MAX_FDT_SIZE SZ_2M
> >> @@ -77,6 +79,14 @@ struct bootinfo {
> >>   #endif
> >>   };
> >>   
> >> +struct map_range_data
> >> +{
> >> +    struct domain *d;
> >> +    p2m_type_t p2mt;
> >> +    /* Set if mappings for PCI host bridges must not be skipped. */
> > This comment still needs updating.
> Sorry, I missed this one
> >
> >
> >> +    bool skip_mapping;
> >> +};
> >> +
> >>   extern struct bootinfo bootinfo;
> >>   
> >>   extern domid_t max_init_domid;
> >> @@ -124,6 +134,9 @@ void device_tree_get_reg(const __be32 **cell, u32 address_cells,
> >>   u32 device_tree_get_u32(const void *fdt, int node,
> >>                           const char *prop_name, u32 dflt);
> >>   
> >> +int map_range_to_domain(const struct dt_device_node *dev,
> >> +                        u64 addr, u64 len, void *data);
> >> +
> >>   #endif
> >>   /*
> >>    * Local variables:
> >> -- 
> >> 2.25.1
> >>
> 


From xen-devel-bounces@lists.xenproject.org Tue Oct 05 22:21:02 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Oct 2021 22:21:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.202550.357518 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXsnp-0007NE-9E; Tue, 05 Oct 2021 22:20:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 202550.357518; Tue, 05 Oct 2021 22:20:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXsnp-0007N7-6B; Tue, 05 Oct 2021 22:20:49 +0000
Received: by outflank-mailman (input) for mailman id 202550;
 Tue, 05 Oct 2021 22:20:48 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mXsno-0007Mx-DY; Tue, 05 Oct 2021 22:20:48 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mXsnn-0005mn-VS; Tue, 05 Oct 2021 22:20:47 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mXsnn-0003dE-L8; Tue, 05 Oct 2021 22:20:47 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mXsnn-0005J0-Kf; Tue, 05 Oct 2021 22:20:47 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=FANrFp65yxp3w04dda1ro4N0LkzK5fsNBg4090NjXSU=; b=J8Dsq3dhTx2acarAtIo3aozYEZ
	tBWhWVDW88iIkzjCLc6gy/aSpcx25F6kdQfE97gvjQcAUkc5n3YLe6NShkNnosdru5TK15Ihe4nH3
	4PaZroH0oEedhY5wDky5Qys4fsmgbGh2KHRHORkzKO1WP2cmPXQyyOH6agsThv0Aj0Qs=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165383-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 165383: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=192aaf7e146c0b41dbdd35ccdb13eb33ced13633
X-Osstest-Versions-That:
    xen=d6bdad32cbb5dfbc68fac32078cc5882071c4f1d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 05 Oct 2021 22:20:47 +0000

flight 165383 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165383/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  192aaf7e146c0b41dbdd35ccdb13eb33ced13633
baseline version:
 xen                  d6bdad32cbb5dfbc68fac32078cc5882071c4f1d

Last test of basis   165369  2021-10-05 01:01:42 Z    0 days
Testing same since   165383  2021-10-05 19:01:46 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Ivan Kardykov <kardykov@tabit.pro>
  Jan Beulich <jbeulich@suse.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   d6bdad32cb..192aaf7e14  192aaf7e146c0b41dbdd35ccdb13eb33ced13633 -> smoke


From xen-devel-bounces@lists.xenproject.org Tue Oct 05 23:19:39 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Oct 2021 23:19:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.202562.357532 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXtie-0004Gh-Sm; Tue, 05 Oct 2021 23:19:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 202562.357532; Tue, 05 Oct 2021 23:19:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXtie-0004Ga-PE; Tue, 05 Oct 2021 23:19:32 +0000
Received: by outflank-mailman (input) for mailman id 202562;
 Tue, 05 Oct 2021 23:19:31 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+0nn=OZ=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1mXtid-0004GU-1p
 for xen-devel@lists.xenproject.org; Tue, 05 Oct 2021 23:19:31 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id b060f27f-2632-11ec-bf1e-12813bfff9fa;
 Tue, 05 Oct 2021 23:19:29 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id D5CA061215;
 Tue,  5 Oct 2021 23:19:28 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b060f27f-2632-11ec-bf1e-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1633475969;
	bh=Klam4P8ugIvmCfh98ErxgMh8Qx5cFg4VPlqGCnewslw=;
	h=Date:From:To:cc:Subject:From;
	b=M9nIQmbFbiPgReKYam2l2koeEH24Y5py/G9qG3DgGKraXPAL0PIE6Kl/BqMSqq+nd
	 QKxpCRGNiPKhAfBYqumfMJ09kJ2iHKT7H2qrSQCZikn4TsRxRvb3+eJ+1kUWYOYiBY
	 /2ZJcXAn+HrcBCMbSAuGmrPzRLFCJCj4zAhZYdY1flsPAqwu7GHlK2VcrOay3lgaBQ
	 BvVdHFfUROBqv2/SySeJF4MOBpz7w6wm3AMGrPXZVUVa4+I6g9BgiVbOjxd4lm/BvG
	 obvBQoy2CkVDp6F2ESjqjo1nHjcyOGUf045RgjUNM4R8NnwDH3eQmRA2QWwuv8dq/J
	 tF7CgAPCxDwNQ==
Date: Tue, 5 Oct 2021 16:19:27 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: fam@euphon.net
cc: sstabellini@kernel.org, andrew.cooper3@citrix.com, wl@xen.org, 
    anthony.perard@citrix.com, cardoe@cardoe.com, 
    xen-devel@lists.xenproject.org
Subject: Patchew not working for xen-devel
Message-ID: <alpine.DEB.2.21.2110051610480.3209@sstabellini-ThinkPad-T480s>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

Hi Fam,

Patchew is not applying patches any longer from xen-devel. Would you be
able to look into the issue? We are only 2 weeks away from the Xen 4.16
code freeze; it would be great to have Patchew working (the underlying
gitlab-ci tests are known to work.) If you can't look into it at the
moment, could you give us a couple of pointers so that we can try to see
what's wrong by ourselves?

In the long term maybe you could give the Xen community a quick "tour"
of Patchew so that if something like this happens, somebody else might
know where to look and may be able to help as well.

Thanks in advance for any help you can provide! Even just a couple of
links would be appreciated.

Cheers,

Stefano


From xen-devel-bounces@lists.xenproject.org Tue Oct 05 23:29:59 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 05 Oct 2021 23:29:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.202571.357543 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXtsW-0005l3-Qy; Tue, 05 Oct 2021 23:29:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 202571.357543; Tue, 05 Oct 2021 23:29:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXtsW-0005kw-NS; Tue, 05 Oct 2021 23:29:44 +0000
Received: by outflank-mailman (input) for mailman id 202571;
 Tue, 05 Oct 2021 23:29:43 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mXtsV-0005km-8F; Tue, 05 Oct 2021 23:29:43 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mXtsU-0006vP-Pn; Tue, 05 Oct 2021 23:29:42 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mXtsU-0007jG-Fr; Tue, 05 Oct 2021 23:29:42 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mXtsU-0003Hc-F2; Tue, 05 Oct 2021 23:29:42 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=R8DbZK6WSkL55jfYGapXxVu9DwhJ2ZVwSKOxPLY+gTw=; b=Q71kNqsfeaY9/KqNCjC7uMaBXt
	993LdlCqNOIFyvMN1fQ5bWM9O7xWCkz83F0hiWmM2MjJE1Y7fRFw1tt3weR+wiSswRl/isnXi6D9j
	CJ/l1wo1d6d+IF0hngzYkGPXBHhhpSKXF9aKan+172uxhmI8MsVXBdoE4u5M6pVGKkl4=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165378-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-5.4 test] 165378: regressions - FAIL
X-Osstest-Failures:
    linux-5.4:test-armhf-armhf-xl-credit1:guest-start:fail:regression
    linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:xen-boot:fail:heisenbug
    linux-5.4:test-armhf-armhf-xl-credit2:xen-boot:fail:heisenbug
    linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:heisenbug
    linux-5.4:test-armhf-armhf-xl-rtds:guest-start.2:fail:allowable
    linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:guest-start/debian.repeat:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=3a7dc5b4cfbdfd8da37cb0e54f439d84cf5a5123
X-Osstest-Versions-That:
    linux=e74e2950a0d6f800858e54860d7124c86e494f62
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 05 Oct 2021 23:29:42 +0000

flight 165378 linux-5.4 real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165378/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-armhf-armhf-xl-credit1  14 guest-start              fail REGR. vs. 165206

Tests which are failing intermittently (not blocking):
 test-amd64-i386-xl-qemuu-ws16-amd64  8 xen-boot  fail in 165346 pass in 165378
 test-armhf-armhf-xl-credit2   8 xen-boot         fail in 165346 pass in 165378
 test-armhf-armhf-xl-rtds     18 guest-start/debian.repeat  fail pass in 165346

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds     19 guest-start.2  fail in 165346 REGR. vs. 165206

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165206
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 165206
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 165206
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 165206
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165206
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165206
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 165206
 test-arm64-arm64-libvirt-raw 17 guest-start/debian.repeat    fail  like 165206
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 165206
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 165206
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 165206
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 165206
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 165206
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 linux                3a7dc5b4cfbdfd8da37cb0e54f439d84cf5a5123
baseline version:
 linux                e74e2950a0d6f800858e54860d7124c86e494f62

Last test of basis   165206  2021-09-26 12:42:13 Z    9 days
Testing same since   165346  2021-10-04 12:42:32 Z    1 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
  Alan Stern <stern@rowland.harvard.edu>
  Alexei Starovoitov <ast@kernel.org>
  Andreas Larsson <andreas@gaisler.com>
  Andrew Morton <akpm@linux-foundation.org>
  Andy Shevchenko <andriy.shevchenko@linux.intel.com>
  Antoine Tenart <atenart@kernel.org>
  Anton Eidelman <anton.eidelman@gmail.com>
  Anton Eidelman <anton@lightbitslabs.com>
  Ariel Elior <aelior@marvell.com>
  Arnd Bergmann <arnd@arndb.de>
  Aya Levin <ayal@nvidia.com>
  Baokun Li <libaokun1@huawei.com>
  Bartosz Golaszewski <brgl@bgdev.pl>
  Bixuan Cui <cuibixuan@huawei.com>
  Borislav Petkov <bp@suse.de>
  Carlo Lobrano <c.lobrano@gmail.com>
  Catalin Marinas <catalin.marinas@arm.com>
  Chris Chiu <chris.chiu@canonical.com>
  Christian Brauner <christian.brauner@ubuntu.com>
  Christoph Hellwig <hch@lst.de>
  Claudiu Manoil <claudiu.manoil@nxp.com>
  Dan Carpenter <dan.carpenter@oracle.com>
  Dan Li <ashimida@linux.alibaba.com>
  Daniel Lezcano <daniel.lezcano@linaro.org>
  David Howells <dhowells@redhat.com>
  David S. Miller <davem@davemloft.net>
  David Sterba <dsterba@suse.com>
  Dmitry Bogdanov <d.bogdanov@yadro.com>
  Felipe Balbi <balbi@kernel.org>
  Florian Fainelli <f.fainelli@gmail.com>
  Gao Xiang <hsiangkao@linux.alibaba.com>
  Geert Uytterhoeven <geert@linux-m68k.org>
  Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  Gregory CLEMENT <gregory.clement@bootlin.com>
  Guenter Roeck <linux@roeck-us.net>
  Hans de Goede <hdegoede@redhat.com>
  Helge Deller <deller@gmx.de>
  Hulk Robot <hulkrobot@huawei.com>
  Jan Beulich <jbeulich@suse.com>
  Jens Axboe <axboe@kernel.dk>
  Jesper Nilsson <jesper.nilsson@axis.com>
  Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
  Jiri Slaby <jslaby@suse.cz>
  Johan Hovold <johan@kernel.org>
  Johannes Thumshirn <jth@kernel.org>
  Jon Hunter <jonathanh@nvidia.com>
  Juergen Gross <jgross@suse.com>
  Julian Sikorski <belegdol+github@gmail.com>
  Julian Sikorski <belegdol@gmail.com>
  Kaige Fu <kaige.fu@linux.alibaba.com>
  Karsten Graul <kgraul@linux.ibm.com>
  Kishon Vijay Abraham I <kishon@ti.com>
  Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
  Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
  Li Jinlin <lijinlin3@huawei.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Linux Kernel Functional Testing <lkft@linaro.org>
  Marc Zyngier <maz@kernel.org>
  Mark Rutland <mark.rutland@arm.com>
  Markus Suvanto <markus.suvanto@gmail.com>
  Martin K. Petersen <martin.petersen@oracle.com>
  Michael Chan <michael.chan@broadcom.com>
  Michael Chan <michael.chan@broadocm.com>
  Michal Kalderon <mkalderon@marvell.com>
  Minas Harutyunyan <Minas.Harutyunyan@synopsys.com>
  Moritz Fischer <mdf@kernel.org>
  Nicolas Ferre <nicolas.ferre@microchip.com>
  Oliver Neukum <oneukum@suse.com>
  Ondrej Zary <linux@zary.sk>
  Pali Rohár <pali@kernel.org>
  Qu Wenruo <wqu@suse.com>
  Randy Dunlap <rdunlap@infradead.org>
  Ronnie Sahlberg <lsahlber@redhat.com>
  Sai Krishna Potthuri <lakshmi.sai.krishna.potthuri@xilinx.com>
  Sasha Levin <sashal@kernel.org>
  Shai Malin <smalin@marvell.com>
  Shuah Khan <skhan@linuxfoundation.org>
  Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
  Slark Xiao <slark_xiao@163.com>
  Song Liu <songliubraving@fb.com>
  Srinivas Pandruvada <srinivas.pI andruvada@linux.intel.com>
  Steve French <stfrench@microsoft.com>
  Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
  syzbot+fadc0aaf497e6a493b9f@syzkaller.appspotmail.com
  Tariq Toukan <tariqt@nvidia.com>
  Tejun Heo <tj@kernel.org>
  Todd Kjos <tkjos@google.com>
  Tom Rix <trix@redhat.com>
  Tong Zhang <ztong0001@gmail.com>
  Uwe Brandt <uwe.brandt@gmail.com>
  Wengang Wang <wen.gang.wang@oracle.com>
  Yonghong Song <yhs@fb.com>
  zhang kai <zhangkaiheb@126.com>
  Zhihao Cheng <chengzhihao1@huawei.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 fail    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 1974 lines long.)


From xen-devel-bounces@lists.xenproject.org Wed Oct 06 01:12:10 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Oct 2021 01:12:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.202581.357557 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXvTQ-0006Rw-2P; Wed, 06 Oct 2021 01:11:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 202581.357557; Wed, 06 Oct 2021 01:11:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXvTP-0006Rp-Ti; Wed, 06 Oct 2021 01:11:55 +0000
Received: by outflank-mailman (input) for mailman id 202581;
 Wed, 06 Oct 2021 01:11:54 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=h5pW=O2=oracle.com=boris.ostrovsky@srs-us1.protection.inumbo.net>)
 id 1mXvTN-0006Rj-P3
 for xen-devel@lists.xenproject.org; Wed, 06 Oct 2021 01:11:54 +0000
Received: from mx0b-00069f02.pphosted.com (unknown [205.220.177.32])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 01a377bb-3c01-4f01-bab7-e4d4db0004a8;
 Wed, 06 Oct 2021 01:11:51 +0000 (UTC)
Received: from pps.filterd (m0246631.ppops.net [127.0.0.1])
 by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 1960NenW022627; 
 Wed, 6 Oct 2021 01:11:48 GMT
Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71])
 by mx0b-00069f02.pphosted.com with ESMTP id 3bg454mbs3-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Wed, 06 Oct 2021 01:11:47 +0000
Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1])
 by aserp3030.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 1961A0IT195397;
 Wed, 6 Oct 2021 01:11:47 GMT
Received: from nam11-dm6-obe.outbound.protection.outlook.com
 (mail-dm6nam11lp2177.outbound.protection.outlook.com [104.47.57.177])
 by aserp3030.oracle.com with ESMTP id 3bev7u426v-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Wed, 06 Oct 2021 01:11:47 +0000
Received: from BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10)
 by MN2PR10MB4192.namprd10.prod.outlook.com (2603:10b6:208:1d9::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.15; Wed, 6 Oct
 2021 01:11:45 +0000
Received: from BLAPR10MB5009.namprd10.prod.outlook.com
 ([fe80::3c49:46aa:83e1:a329]) by BLAPR10MB5009.namprd10.prod.outlook.com
 ([fe80::3c49:46aa:83e1:a329%5]) with mapi id 15.20.4566.022; Wed, 6 Oct 2021
 01:11:45 +0000
Received: from [10.74.102.28] (138.3.201.28) by
 SN4PR0201CA0017.namprd02.prod.outlook.com (2603:10b6:803:2b::27) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18 via Frontend
 Transport; Wed, 6 Oct 2021 01:11:44 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 01a377bb-3c01-4f01-bab7-e4d4db0004a8
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc :
 references : from : message-id : date : in-reply-to : content-type :
 content-transfer-encoding : mime-version; s=corp-2021-07-09;
 bh=YDorkgV8Tn0yuTU7JoLBMjLy5LntqUHBOqBVAOnX2W4=;
 b=uoJjetCCzLFm6TyoTMn6NijQphFeAdPYl3PIdMPSW4OGinAe1uQEllMmQ0jJ9PRvJiL/
 5OIZckiLZTc4+kngCI1qU0EIgVAbxjyBvVSpZhfqiBHF0pE6dl2rQPx7E6VU0qxy/Az9
 lb0f2VWwSLK2D/1ZsrNqu4Ah116ej3N16HpgTCGxzME02WWQXYtEB4ZJVBu5eLrmHXvt
 xluH9NZ6B+U1Krtl6k0ng8CY3RT79sWfSCcQUiS0PECbilYUhdUQFA7JSnRUv7Ldef7N
 1Pt7kllYcSXwghTxtbDJ5Bf7JpfUfBbLokqiEESu1nBcnVGPLhtOW+1H3qOOyjurMOmB wg== 
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=BWbCYa10xmwuUdFbIvceXpYWgt3qnP7RqhD1UmHqtVfnaV2Y9tnJvF+aRxGcyMSG8MaYPqy8STPo30z4qAqXKr4T/OoJQb1kveKTHxl4N4OyjlLRpm8+sFavp+yzYPwQ8emR/kDmpm29BpgeqgEJI38w5/5Hg67IPfOeMBSpTGuXNp0TvnLoNDUxai9lQwOTHwnsaSvW9ymlenNHi3lOiRSo9S9mFSlHfgELUFuzCdtXeTuiI7BvO2ATPeCrnNf+//1hKlO82/KbqVXn9RwQ8NUregMfg+rhwfL4jIGAajdBI7io/p4F/uffMQWpaxnoMAm4hIqrH39mhIugMjMJxw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=YDorkgV8Tn0yuTU7JoLBMjLy5LntqUHBOqBVAOnX2W4=;
 b=ibrnUAa0coErFGcKgP3KcvmUnMfZTEjUiMKy+zXZoNk+xgGFSbJ6A1yOVNjG0wtAMwT8dYNa8IlHlooZa1CQUx0bVMC2cWQuPvkdPUYFpoxPTKIxS3Wd+AIZIg7pzYtsZ34XTtcIPu9SDLLwXYRA1OiVF6CxmYDAdPHt705tfftwWgzKirq0pt0q4Up28eVcqFY5i9ImbVX4ROLN2ncuvLfHjfg8IGpyonzXDiHJd9SXobIt3pso/2eaq1jaX5LDypKaxqZqDUvKElsocaNLpuKPWo3FtRQQfpM9WqOu+numAk9tKoD1zFzqlLH60CXacKlUqUg62KeySa0zz2hW9w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com;
 dkim=pass header.d=oracle.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=YDorkgV8Tn0yuTU7JoLBMjLy5LntqUHBOqBVAOnX2W4=;
 b=Os8d3kiG71yQFQ18xGejpokUzroOaYrdGgJCfKZ63+EoH4WP2bhBsLiKASRHEAjFEi4+tGC7OcSSAou8DrReKUr/XcET4Ln37v97xxTcOrZA+rcCGqycZyLSms3okj6v/mG0n24wrPOZgBtkIqyB/oDPv+A93Rwju2LPtivM3AI=
Authentication-Results: invisiblethingslab.com; dkim=none (message not signed)
 header.d=none;invisiblethingslab.com; dmarc=none action=none
 header.from=oracle.com;
Subject: Re: [PATCH] xen/balloon: fix cancelled balloon action
To: Juergen Gross <jgross@suse.com>, xen-devel@lists.xenproject.org,
        linux-kernel@vger.kernel.org
Cc: Stefano Stabellini <sstabellini@kernel.org>, stable@vger.kernel.org,
        =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= <marmarek@invisiblethingslab.com>
References: <20211005133433.32008-1-jgross@suse.com>
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Message-ID: <efaa22aa-2785-b03a-3c14-0ec232429945@oracle.com>
Date: Tue, 5 Oct 2021 21:11:41 -0400
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0)
 Gecko/20100101 Thunderbird/78.14.0
In-Reply-To: <20211005133433.32008-1-jgross@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Content-Language: en-US
X-ClientProxiedBy: SN4PR0201CA0017.namprd02.prod.outlook.com
 (2603:10b6:803:2b::27) To BLAPR10MB5009.namprd10.prod.outlook.com
 (2603:10b6:208:321::10)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 39cc25cb-6488-427a-c708-08d98866438f
X-MS-TrafficTypeDiagnostic: MN2PR10MB4192:
X-Microsoft-Antispam-PRVS: 
	<MN2PR10MB4192298781617BEC8F6CC2908AB09@MN2PR10MB4192.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:1417;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 
	2RWjbLedxCXn7r9Aqj2/a/QmrrUHtRG1l89N8aoMGaVWdU0iTXr7wNv1bp5PH9VHPl+lR2BOnFAsOPJaM1BMsbqwmCn895LUeR+XUSV1BKAbSdeOYtXOnnQ9LKIodNsi1l9Yb9DNI6+l7WE3Y93KW1gfO43aL3DE9d+1f3qdN0S7ccIB7cKkj4mSgFk8pAZEAIhR8yVSHKYgh3Rz8XS6xnwhgkQuBQkhF7sXDmQbwt9TgOy7doYUjZbUezuIVCldgTbA2D2aCpltYzpilTLxmQo+6Fg095G5r1q/8awlRuaHGX39EiXlqY7UnYvbHI7Kvwem7nXuIUS6S/3YYlgzi13n/oR6joqTb1tB8xfAGm49+RjX9wloAaXxtJdXQay/pHsyctzr9v9Y1Dagk0isWCRHYY+hoNaKn0udl7pSa1KYHbGZp2wiuIVR8Vh0izVY/gStyZfugpkhAAvBLdqi9hOwtPjbbJzqtOzJ2+v8Z0ZYfK512xuahCK3+t28Q3MzYxuZ7sZJwAq/H6Hn0krS+KYIFWNZ0/FAMvgVgpU8e9csHzQC6FvfIRTnVWMs/3f2VyDfGQSVRgImkDRvASip+xfsAwhV7C/AQs4M4fRBW0aowG3Td2DDhUxAIxKTThBGCv6k4LjPQKpDyMgk+A1U5H4oD4WA6dOCo1BYveoEzP/YhT9DG6yJajL1HWan4pYDXMkm1Rbiik5hA8Ywg3MGuzff7dvV9z4VxfOgVUGS62970i/UtjrLiPuMgZ7ISxyL
X-Forefront-Antispam-Report: 
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB5009.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(66556008)(186003)(66476007)(31696002)(36756003)(86362001)(53546011)(6666004)(66946007)(4326008)(31686004)(8676002)(6486002)(956004)(26005)(38100700002)(5660300002)(508600001)(44832011)(16576012)(8936002)(54906003)(4744005)(316002)(2906002)(2616005)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?Zi9qc3lKTHE2WUxqTWZleFRkYjJZcWIyWWlvUEZkRDFmbkhjenVPNXcrbjJP?=
 =?utf-8?B?TXBWRnRkV2F2TFMxOWtrNnJiNit1cnJROERWYjRTNlR2WkUya2ZiV0VQemhq?=
 =?utf-8?B?MFJDSHVrcHVjUEVybUoyZk54L0lYdG92NjhVcGNBMGpLVUVwbEpaSDU2ZEpu?=
 =?utf-8?B?WFM0VnhrbWY4UFk4cWxYK2gwQVhicVNTVmVaNTVrQUhNYU43Qm1sS1NEZjd6?=
 =?utf-8?B?Q3dXczh6ZHpnSmQzNGJzWW9FaFVUNnJ4VVA5eS9yNzhwaGYycHJweksrVm5R?=
 =?utf-8?B?UEZxY3lNenI5eUduT3VZMmF1TU44VnUrYlZuZWxVMi94VUlYV1BlUjlDcGJ1?=
 =?utf-8?B?djZSZDV1aFl3dDFwSUNCcVVxZHZEYjdmbk1rNG84eVJoejBXSmU1bmdkL2lj?=
 =?utf-8?B?aUhvd3NqUHZ4UU9VV1hESXJRTnU2UGhmNkZlY3FjV2ZnWGRCS1pSb3VlY2M3?=
 =?utf-8?B?eGdqYmJwb3QyL2UyQ0VEYVBFa0dGb3ZHWWREVkZTa0hGV0VNZFk3NmtzSk1P?=
 =?utf-8?B?b0xwWlFGbXN3RVRaakRYTGZLR2NaWGtwVU1ZMjlzdzZ0YnNGaEE4T0JZTzRZ?=
 =?utf-8?B?OWVsanc3MGV6cG9WT21DR3pHaUdyb0hCZXhqMHFScE1WTE53aFZRK0N3SFl6?=
 =?utf-8?B?UlI5SGdUenFsR2ZKUzJZZDM3YmN3OUVVQ2R4eHFEWGNDdC94ODQvMzBva1dS?=
 =?utf-8?B?aWZLa09Yb09kc2FzWXFleXZHNys4aGlaUVF4S05mSEQ2R0tUWGxjQmtON0No?=
 =?utf-8?B?VXJxdVA1SmJOWFZNUW1tYmp1MXlBU040TTRsTWNVeWdtekNhMkxhZVRMZmhS?=
 =?utf-8?B?dWRwTDJnTmFEelFjMUp2UWZCYjVSWS9Yd0hvdnRROVZiQ0lQdW5HZDB2dnU3?=
 =?utf-8?B?a1pXaU9RQjl1ajgvRzlRbVcycThZaldsMStoTDMzN0FQTkJoeWwyOUpZZW4v?=
 =?utf-8?B?RGZ1bEJWS3RIZm1sZ1Z4amJHb05PS3BURExLa2ZEdUt0NHZpamFsQ1puVEF1?=
 =?utf-8?B?NGtueGVvVEQ1VHRybnJYcW9MR1FyM3dBQzJ0cFkrVU9oNGNQdnVjZnB1cUxO?=
 =?utf-8?B?aUJGSEpGcFZnTXlYMEtWZzlMZkhhVzhIaEYwZ0tBS1JaSVlqQitNTTNKTjNl?=
 =?utf-8?B?MzgrUmFuTENUWWwxcWdCSEcrQndXa2x0UklLQmIrbnpDZkdHNVFvSTNzWWw3?=
 =?utf-8?B?a0laTlB5QzIvVU5KZnl5OWVGcHNESXhLci9rVW9YdjBGcktaZU13M2RuN29x?=
 =?utf-8?B?VWJpS0hVVnRuNlRXRytPcmpRZ1hrRktZdVVoWDJhS1p6YTBWM3BFK3lzVE04?=
 =?utf-8?B?RkgzbGVqeUIxbGxwMjVLSVd5VFl5T2tmQ1E0d1NWS2NXYmVyd0FaelpNd3do?=
 =?utf-8?B?azcrdkkycS9FNks0eHZRR1VHRUZ2ZkpuOFdKT25XaUMrQTlxM0liNjIwUzhZ?=
 =?utf-8?B?Q0Y3c1BQSmQ0dW9CTVovVWdOTmVVdW9uUEg5RWRML0p5aEZ2WjM4MVUyMHV2?=
 =?utf-8?B?amNXYnMvU0p0b21wK1Nib1JEblNyRE14QVhLdkxDWkRTT2VVRWNuVHZtdWRv?=
 =?utf-8?B?eWptT2JJazJmZksvS0xrMU54S2RaRU5CdHdlRWpsRUlQNEhQK05KQ01uN1py?=
 =?utf-8?B?YTVrY0J3c3RKTHZpQW94RHlWM3JpV1J0NlJUaWsyRXhqMzg4eUZ6NWdyOWJZ?=
 =?utf-8?B?aU5Zei9leHI3Qlkrb01nOXJ2bGpBa2VJUXphQWtPTUVJRHBkcDM3b0kxM0pk?=
 =?utf-8?Q?XimDfQbqNAxqewK1OuRLrDxdhG23fkSE/DqtxBh?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 39cc25cb-6488-427a-c708-08d98866438f
X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Oct 2021 01:11:45.3543
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: DrVF9eLBOeT9ZAiFmIThBuDpKLYtDE96ALsOM/6jSDXdaed05JwFATG23T96Od8QH0dL9cU/NqmRxshGTfrlkEzTfyLPaxDule6UJ28Yu0A=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR10MB4192
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10128 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 mlxlogscore=999 adultscore=0
 bulkscore=0 suspectscore=0 malwarescore=0 spamscore=0 phishscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109230001
 definitions=main-2110060006
X-Proofpoint-GUID: jUsOfhKauYI8EwCyZDm6VomFZGcHwVOU
X-Proofpoint-ORIG-GUID: jUsOfhKauYI8EwCyZDm6VomFZGcHwVOU


On 10/5/21 9:34 AM, Juergen Gross wrote:
> In case a ballooning action is cancelled the new kernel thread handling
> the ballooning might end up in a busy loop.
>
> Fix that by handling the cancelled action gracefully.
>
> While at it introduce a short wait for the BP_WAIT case.
>
> Cc: stable@vger.kernel.org
> Fixes: 8480ed9c2bbd56 ("xen/balloon: use a kernel thread instead a workqueue")
> Reported-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
> Signed-off-by: Juergen Gross <jgross@suse.com>


Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>




From xen-devel-bounces@lists.xenproject.org Wed Oct 06 03:18:18 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Oct 2021 03:18:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.202592.357568 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXxRR-0001TF-Ch; Wed, 06 Oct 2021 03:18:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 202592.357568; Wed, 06 Oct 2021 03:18:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXxRR-0001T8-8H; Wed, 06 Oct 2021 03:18:01 +0000
Received: by outflank-mailman (input) for mailman id 202592;
 Wed, 06 Oct 2021 03:18:00 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mXxRQ-0001Sy-6B; Wed, 06 Oct 2021 03:18:00 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mXxRP-00016y-W1; Wed, 06 Oct 2021 03:18:00 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mXxRP-0000gB-I8; Wed, 06 Oct 2021 03:17:59 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mXxRP-0005jE-Gz; Wed, 06 Oct 2021 03:17:59 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=PWv6A3Dje/mDSUUFUgGzB111t+goTARwvDWGx1DRYpk=; b=icXMo/mpcoiBMs06udk7SMBIsn
	u7V26b9PDp3hW15MJTqYHtqvw2NnEFcDFae2mSZbv4JqmxEVhvBfF5KzKSg8CtCN2xy9AOzClJFdD
	JAptwzhSAXE0ZJ+N6xyzzUitVBk8Bam4V7Nox25cEt0TdKLmuj3Vyk2YI3rmgCXDUCck=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165379-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 165379: regressions - FAIL
X-Osstest-Failures:
    linux-linus:test-armhf-armhf-xl-credit1:guest-start/debian.repeat:fail:regression
    linux-linus:test-amd64-amd64-dom0pvh-xl-intel:guest-localmigrate/x10:fail:heisenbug
    linux-linus:test-armhf-armhf-xl-rtds:guest-start:fail:allowable
    linux-linus:test-amd64-amd64-libvirt-qcow2:guest-start/debian.repeat:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=f6274b06e326d8471cdfb52595f989a90f5e888f
X-Osstest-Versions-That:
    linux=deacdb3e3979979016fcd0ffd518c320a62ad166
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 06 Oct 2021 03:17:59 +0000

flight 165379 linux-linus real [real]
flight 165393 linux-linus real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/165379/
http://logs.test-lab.xenproject.org/osstest/logs/165393/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-armhf-armhf-xl-credit1 18 guest-start/debian.repeat fail REGR. vs. 152332

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-dom0pvh-xl-intel 20 guest-localmigrate/x10 fail pass in 165393-retest

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds     14 guest-start              fail REGR. vs. 152332

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt-qcow2 19 guest-start/debian.repeat fail baseline untested
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail baseline untested
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 152332
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 152332
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 152332
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 152332
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 152332
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152332
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 152332
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 linux                f6274b06e326d8471cdfb52595f989a90f5e888f
baseline version:
 linux                deacdb3e3979979016fcd0ffd518c320a62ad166

Last test of basis   152332  2020-07-31 19:41:23 Z  431 days
Failing since        152366  2020-08-01 20:49:34 Z  430 days  743 attempts
Testing same since   165379  2021-10-05 10:47:37 Z    0 days    1 attempts

------------------------------------------------------------
7366 people touched revisions under test,
not listing them all

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            fail    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               fail    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 2281483 lines long.)


From xen-devel-bounces@lists.xenproject.org Wed Oct 06 04:55:33 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Oct 2021 04:55:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.202602.357582 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXyxb-0002gm-Hf; Wed, 06 Oct 2021 04:55:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 202602.357582; Wed, 06 Oct 2021 04:55:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXyxb-0002gf-EO; Wed, 06 Oct 2021 04:55:19 +0000
Received: by outflank-mailman (input) for mailman id 202602;
 Wed, 06 Oct 2021 04:55:18 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=blEf=O2=epam.com=prvs=09137546d4=oleksandr_andrushchenko@srs-us1.protection.inumbo.net>)
 id 1mXyxZ-0002gZ-Rx
 for xen-devel@lists.xenproject.org; Wed, 06 Oct 2021 04:55:18 +0000
Received: from mx0b-0039f301.pphosted.com (unknown [148.163.137.242])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 117063be-7554-4a4b-888a-2d2b5bb6d900;
 Wed, 06 Oct 2021 04:55:15 +0000 (UTC)
Received: from pps.filterd (m0174683.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.0.43) with SMTP id 1963hMgU023741;
 Wed, 6 Oct 2021 04:55:12 GMT
Received: from eur01-he1-obe.outbound.protection.outlook.com
 (mail-he1eur01lp2051.outbound.protection.outlook.com [104.47.0.51])
 by mx0b-0039f301.pphosted.com with ESMTP id 3bh42k042n-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Wed, 06 Oct 2021 04:55:12 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by AM0PR03MB4756.eurprd03.prod.outlook.com (2603:10a6:208:ce::29)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.17; Wed, 6 Oct
 2021 04:55:09 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::e966:6290:5736:b7bd]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::e966:6290:5736:b7bd%7]) with mapi id 15.20.4566.022; Wed, 6 Oct 2021
 04:55:09 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 117063be-7554-4a4b-888a-2d2b5bb6d900
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=RWn1mK2ejOxiycWOy0cE9g5Pu/g/khkEKwhqQQjh90g+Wx7lR0X3OGpWLpQJwYLG9YiawTc7wEp7pSTwk/FMMIqde+ChoCAmggTjNX9PH1Y/+R7ZuI3YzzI1YNXSraZ65TgCGx7LF1RjYCCZx38GVOBig4bzQJwcuFhA97nFEu4bGK6D383jBwv9F3TBHPZoY9/Z3j+7UufpbEinP5Z9gW0qshst65ic7T1Ob6LNerljWfG/hM1NE9fKF4Ku0pUCF+D+z3RWpeV0IdbXtGG/4azyrc5BiETGGec384mqBsSSWNLtCyxvkCaQuqnIf+w9pNjQpIDXCBOx8KQuyGEO6w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=TrjZ6Ti1cYWg5IWpg0C4eMMbfep/ZmZ9dBfZgqRQP9U=;
 b=iJN62Y77SLU0u5IhcAwv8bmJjxDMJM5JUOFQd+kcPbe2LQL5CxRcVtYLECjB6NK2rrSxgevz1rGLxESvt2a/OKWq2rebomMHeMYJXik+m8gtdC5IKtC9lVnMn2D463iaRGm69B2g5f/XHW+ENaoywQerKg05+MdZ8HeqvV9SQCLljbFupAXAGjQ2o2VS1BMR3Bs4DpjnGi5c3dCtzEslrPoj6nprOf3rAzrgVG39OOsxmjy1tcD4eYhbiQosrI4mDHQB0zuaBwYsbu1y09U2cVgdsaXI+uJ7fkec6oojkxVlWh0s0mvj5Dk8hDc8wQqOAFinuEUBXdtrlv0quP9yQQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=TrjZ6Ti1cYWg5IWpg0C4eMMbfep/ZmZ9dBfZgqRQP9U=;
 b=AaEhRZEsD315l67YvbtQHkD7sE1hj919BdnVX8f8JzqZkx2F+602sbIP1WAfZ6CsS7yYKfdtFow0GK5dtzy7pMxGf3eeA5NbGeSLhVxrk9Ny+Kk545utqiTK7tF1qizwsdXEo7At/5M9wIH/MXWBjvs4meM0OpVxZezRc6wUZCPGFOHOthVZQWrIZMSJ3cCsGlACgqQqPmZmpIA1yAXxSF8c5MszYOjwRPdVAuJiz7zYpUM0OkId6nWU6FXdDLjDIfHXzL3BJNj+btVfttgnWJcF5I5zUWlZ9986wNJCG5nprllyYN/GtPDSn1kJfZTnQ3Nme2Z3Tj1XiQGYiG0U9w==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Stefano Stabellini <sstabellini@kernel.org>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        "julien@xen.org" <julien@xen.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "roger.pau@citrix.com" <roger.pau@citrix.com>,
        "jbeulich@suse.com"
	<jbeulich@suse.com>,
        "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
        "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
        "paul@xen.org"
	<paul@xen.org>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Rahul Singh
	<rahul.singh@arm.com>
Subject: Re: [PATCH v4 10/11] xen/arm: Do not map PCI ECAM and MMIO space to
 Domain-0's p2m
Thread-Topic: [PATCH v4 10/11] xen/arm: Do not map PCI ECAM and MMIO space to
 Domain-0's p2m
Thread-Index: AQHXuSnVYm3k8/clOk2qiNUr9gxPGKvDnQwAgAA0qQCAAR/yAIAAeK+A
Date: Wed, 6 Oct 2021 04:55:08 +0000
Message-ID: <e225b18a-78e0-5737-9856-0e98753cdeaa@epam.com>
References: <20211004141151.132231-1-andr2000@gmail.com>
 <20211004141151.132231-11-andr2000@gmail.com>
 <alpine.DEB.2.21.2110041812270.3209@sstabellini-ThinkPad-T480s>
 <7b42e2aa-658a-74a1-045a-a35fb89a37b0@epam.com>
 <alpine.DEB.2.21.2110051438140.3209@sstabellini-ThinkPad-T480s>
In-Reply-To: <alpine.DEB.2.21.2110051438140.3209@sstabellini-ThinkPad-T480s>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
authentication-results: kernel.org; dkim=none (message not signed)
 header.d=none;kernel.org; dmarc=none action=none header.from=epam.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: d282f879-43b6-4d2f-920f-08d9888578e9
x-ms-traffictypediagnostic: AM0PR03MB4756:
x-ms-exchange-transport-forked: True
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <AM0PR03MB4756792753F28BA4E424E930E7B09@AM0PR03MB4756.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:6108;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 vwdsElIu4QYSALaE2RJq8Sx8LEizDl8oJ4YcP1R4Cd+qGoSF+XbSUm8jXgud1J/rPXBeWVtqpxJT6mctCMFo6R7JdXHDDDWZrn41Ctk2KhIBJHi47jqQeIpS0YE4q5fI3bsuYmyjPwnSrn3t9uHPYNr4sfwYMDVogS6Xal2R1KJp17vuoUGJRCOuW+7VliZItDBDU41XGP7wN0O/uixPLzONhRmuDkbrKk49ALKyxbaDqUIEKZa+EzuWP0Kjwn8NxuVbki2TpI1Fr4C7gYXNB4iQShAgAqzx3SdrCIjWi9AsvJvfIs8sPkaxz5FmBprGzN5wLKiSYMG8lN4XeQA//tm19gP4kP73khGQbRlyQs3MiuM7OO0XWszPJRsoRDP9zqckunXkVEkzyGFzos4sGdTkYTcfS/GtFEG88WO1sVnWgp5FRMIIc1wdE9/DDJAkX7KCiK2zMALl3FXIDc9tJILerwTPH44Ey2PybUg2IUtz58/cM7blv3L61BJ2zg5z4YZFn5KQxHNBXhvAmGxqW9+9BQ8vJ7IvOTVIljdFbTayZ8YiRjEqi5cMZ5bsMB1YCl083hkPvt0JPo4FAFKWuZqFTy4YkY5qo4rIWorE5QhuCD1cmECSvnlTOc7Jt+shzUPsMSWhfD7pIkHgLxOs7awVCA2WcvTWm06JNsdxFqfGqdxwCEyuUiFkF22ScG5wKnWuQDHAUsesSFhGrRY8yPJinVOg92SgU3o57TkYUm56/3xHCAsLgCN92MfB97fWMTfVJq+f4Y5RjbWB240rDEqsvDSD0bX6/zeikAU4uzYaDYE0Pfnyl/m0oK/AEDAJx2fgLV6EGNhDaFodj5hFXpLuBWNTPEmWyCXzIobUP9E=
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(186003)(66476007)(8936002)(55236004)(966005)(31696002)(508600001)(91956017)(76116006)(26005)(66946007)(122000001)(8676002)(38100700002)(66556008)(71200400001)(30864003)(2906002)(66446008)(53546011)(6506007)(6916009)(2616005)(64756008)(36756003)(31686004)(6512007)(83380400001)(316002)(54906003)(5660300002)(6486002)(86362001)(4326008)(7416002)(38070700005)(39920500001)(45980500001)(579004);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?TUtuQWdYRXpPR1pQbFUrWVI4ZnQ1K3dSWTB2SHNxdm5zeFVSYmNFZVZEWDE2?=
 =?utf-8?B?ZVAvRnJENGwvWkRKQStOQndxeFZtalMvTEdvTTBaUGpTWERQSk5tYVVsektQ?=
 =?utf-8?B?NHhEY0t2M2lSZEdrdjBXWHVxUUZDOHBCM0xYT2EvM092MHVqd0xwbWtIN1Qz?=
 =?utf-8?B?OHdJcnpVRTAweUxkZzR6RkJBUlJlZ2VtMVFiOE1JMDJlcTA4V1FOT3NaZU9Q?=
 =?utf-8?B?dERmbUtqYXBTMnNBcmRKbVRsS2plWnJEWDREVER3dGxXSm5sMlVHOTF2L1R1?=
 =?utf-8?B?NjdqWDBWOElHSVNvbkVwUXdYQXEzSlFKLzU1UFI3czJPanVCWEFpOWhXRGg0?=
 =?utf-8?B?aEdHRGFiRnJXNTJqb0ptdkdyS1JLalpOUnVLL1k0MC8vUzZaek01SlVJWVpW?=
 =?utf-8?B?M1lUcnZYZTNnbloycGFjMHZEbHVFSmdTZk90QW95T2Y3a1lhc3hpQlJHNGhK?=
 =?utf-8?B?YkxxTDcrbGRJT3hZbXEreUJKai93WHZDdmVoeXlNV1FWamp5NTJ3UlE1c2JW?=
 =?utf-8?B?TjdtTVdmcDdobHlOeEY5OXdCWlBJNHJDNHpaaVh4ZnJPS3BycFkwS2l3eUZU?=
 =?utf-8?B?TmR3YVp4UTBpa1J1OG9JSVg0TVpySlVKUDhtbWlabGIvM1AxODNLbTYvY1o0?=
 =?utf-8?B?SG5odmEwRUx5TjlQd2RKK01FcHQyY1BqbmthdVlxdDZ4OElnalVCN1VJL21X?=
 =?utf-8?B?OXRXbWJoMEVLYmpkOTV4UGUraHNack5mVjNneHVsOFNmUEI3WXNUbytRczZ6?=
 =?utf-8?B?TW9rZFpvL0gzZmxJekJiekFzRlBpRmFWS1cralR3VTlUMm9LVjlCa0Fnb2tl?=
 =?utf-8?B?YkxBajJPTjRUenRvVWZUS2d6THhkSldKSnNoclBGcUVKZC9KN092SDVXTFZn?=
 =?utf-8?B?L2NoeVJvN2tRei9laXlrcElZRlpmZktxVE1nUjRMalorSXpacGozckpnRHl2?=
 =?utf-8?B?emVGWXVRTUZPRUd0VFpFUCtkOHlRcnBnR1J4Rk9USW42ZjhGWTd1U0prWDhR?=
 =?utf-8?B?ZFZXWG4yVTVrZDdVODd2U3M1aXpmbXI5Q0xvYWkzMUxzSldlTm5mQ3VCRFpn?=
 =?utf-8?B?Ym9WNE1GcHNVTEhzR1dCanN3amt2SzZCSHpneGpDSnU1b2FpYi90SHc5T1N2?=
 =?utf-8?B?cXBWU0lmZEJwTHhVVkh3MDh6VmZEaUIyUWhUbHFxVSttWndCSzFvc0t2ZDQ4?=
 =?utf-8?B?K2N4bWViNk5JWlBOd3pjNVRKYjB1M29oR1V5S0FRaDJFRnB4QzgxZVVpQlNz?=
 =?utf-8?B?QUpPRWgybFR1K20wRnNYMkRwQWRJS2l3bCtSUzBOd1VqMnZiZUpIeFI4YU5S?=
 =?utf-8?B?WlhSeHRnZlpDb25KUHh5Q1JRdnhMaUxCQjJCNXFyMWN5T0ZJWjd2U1QvSEJS?=
 =?utf-8?B?cHJWSHBJdmNvRWFzTm12YXJiamFqZ2xFTGNRT2hHbFpYQzdSWS96ZTJCcjdL?=
 =?utf-8?B?WEduRWhkRDlaK3dyY1hBSWVHV3ExRjNqVml2MUh0VFRJTUd0ZXhPRldxaGc0?=
 =?utf-8?B?YkpSOUx6ZitXUGRvYTZCY1pqWFRvWHVCZC9vMkc2aFhTNTZwTTVuRnozU1N3?=
 =?utf-8?B?NFVLTm9tcE8zc2prSHNjNjl3V29BMjZNUldUb1BzaUgrOG53OFJwVVUyME1Y?=
 =?utf-8?B?UzRSTndPbTdiN1ZaZndRSnB4VWxWdjBYbis1NTJqdDZsR0pGRmZIV2x6U0Q3?=
 =?utf-8?B?WWlsLzl1Q3J0dDQ5bktjbVVTaXlRaUFMTGwzZk41T204cWhsOThBNDVydThS?=
 =?utf-8?B?cStSQW5ncWZqUm5KZTg5ZWpXNFJwaThUV3VlZ3k0NGRhaVlWbEtoaS84MFpL?=
 =?utf-8?B?L1JDakp3QW5LM0E5MWdxQT09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <7B3B0312519C684691DBAE203FC8D88A@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d282f879-43b6-4d2f-920f-08d9888578e9
X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Oct 2021 04:55:08.9639
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Rw5WEXMjMeOxhOeMtbA5g+jZR+UFQyZM2qQrxRxfc/IjF4iCrdkwqTVhUc/uuPHmI2a8pQIQ2ktxDJKcyQlmg8NAY0qOP6J6Swfn0zS9gta7ZhGRq9DVK13tZF9hq/dQ
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR03MB4756
X-Proofpoint-ORIG-GUID: vbn80n56Bai269KQ2SXzBg0QQlYzkdLR
X-Proofpoint-GUID: vbn80n56Bai269KQ2SXzBg0QQlYzkdLR
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.391,FMLib:17.0.607.475
 definitions=2021-10-05_06,2021-10-04_01,2020-04-07_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 mlxscore=0
 mlxlogscore=999 phishscore=0 suspectscore=0 impostorscore=0 clxscore=1015
 spamscore=0 lowpriorityscore=0 bulkscore=0 priorityscore=1501 adultscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109230001
 definitions=main-2110060029

DQoNCk9uIDA2LjEwLjIxIDAwOjQzLCBTdGVmYW5vIFN0YWJlbGxpbmkgd3JvdGU6DQo+IE9uIFR1
ZSwgNSBPY3QgMjAyMSwgT2xla3NhbmRyIEFuZHJ1c2hjaGVua28gd3JvdGU6DQo+PiBPbiAwNS4x
MC4yMSAwNDoyNCwgU3RlZmFubyBTdGFiZWxsaW5pIHdyb3RlOg0KPj4+IE9uIE1vbiwgNCBPY3Qg
MjAyMSwgT2xla3NhbmRyIEFuZHJ1c2hjaGVua28gd3JvdGU6DQo+Pj4+IEZyb206IE9sZWtzYW5k
ciBBbmRydXNoY2hlbmtvIDxvbGVrc2FuZHJfYW5kcnVzaGNoZW5rb0BlcGFtLmNvbT4NCj4+Pj4N
Cj4+Pj4gUENJIGhvc3QgYnJpZGdlcyBhcmUgc3BlY2lhbCBkZXZpY2VzIGluIHRlcm1zIG9mIGlt
cGxlbWVudGluZyBQQ0kNCj4+Pj4gcGFzc3Rocm91Z2guIEFjY29yZGluZyB0byBbMV0gdGhlIGN1
cnJlbnQgaW1wbGVtZW50YXRpb24gZGVwZW5kcyBvbg0KPj4+PiBEb21haW4tMCB0byBwZXJmb3Jt
IHRoZSBpbml0aWFsaXphdGlvbiBvZiB0aGUgcmVsZXZhbnQgUENJIGhvc3QNCj4+Pj4gYnJpZGdl
IGhhcmR3YXJlIGFuZCBwZXJmb3JtIFBDSSBkZXZpY2UgZW51bWVyYXRpb24uIEluIG9yZGVyIHRv
DQo+Pj4+IGFjaGlldmUgdGhhdCBvbmUgb2YgdGhlIHJlcXVpcmVkIGNoYW5nZXMgaXMgdG8gbm90
IG1hcCBhbGwgdGhlIG1lbW9yeQ0KPj4+PiByYW5nZXMgaW4gbWFwX3JhbmdlX3RvX2RvbWFpbiBh
cyB3ZSB0cmF2ZXJzZSB0aGUgZGV2aWNlIHRyZWUgb24gc3RhcnR1cA0KPj4+PiBhbmQgcGVyZm9y
bSBzb21lIGFkZGl0aW9uYWwgY2hlY2tzIGlmIHRoZSByYW5nZSBuZWVkcyB0byBiZSBtYXBwZWQg
dG8NCj4+Pj4gRG9tYWluLTAuDQo+Pj4+DQo+Pj4+IFRoZSBnZW5lcmljIFBDSSBob3N0IGNvbnRy
b2xsZXIgZGV2aWNlIHRyZWUgYmluZGluZyBzYXlzIFsyXToNCj4+Pj4gLSByYW5nZXM6IEFzIGRl
c2NyaWJlZCBpbiBJRUVFIFN0ZCAxMjc1LTE5OTQsIGJ1dCBtdXN0IHByb3ZpZGUNCj4+Pj4gICAg
ICAgICAgICAgYXQgbGVhc3QgYSBkZWZpbml0aW9uIG9mIG5vbi1wcmVmZXRjaGFibGUgbWVtb3J5
LiBPbmUNCj4+Pj4gICAgICAgICAgICAgb3IgYm90aCBvZiBwcmVmZXRjaGFibGUgTWVtb3J5IGFu
ZCBJTyBTcGFjZSBtYXkgYWxzbw0KPj4+PiAgICAgICAgICAgICBiZSBwcm92aWRlZC4NCj4+Pj4N
Cj4+Pj4gLSByZWcgICA6IFRoZSBDb25maWd1cmF0aW9uIFNwYWNlIGJhc2UgYWRkcmVzcyBhbmQg
c2l6ZSwgYXMgYWNjZXNzZWQNCj4+Pj4gICAgICAgICAgICAgZnJvbSB0aGUgcGFyZW50IGJ1cy4g
IFRoZSBiYXNlIGFkZHJlc3MgY29ycmVzcG9uZHMgdG8NCj4+Pj4gICAgICAgICAgICAgdGhlIGZp
cnN0IGJ1cyBpbiB0aGUgImJ1cy1yYW5nZSIgcHJvcGVydHkuICBJZiBubw0KPj4+PiAgICAgICAg
ICAgICAiYnVzLXJhbmdlIiBpcyBzcGVjaWZpZWQsIHRoaXMgd2lsbCBiZSBidXMgMCAodGhlIGRl
ZmF1bHQpLg0KPj4+Pg0KPj4+PiA+RnJvbSB0aGUgYWJvdmUgbm9uZSBvZiB0aGUgbWVtb3J5IHJh
bmdlcyBmcm9tIHRoZSAicmFuZ2VzIiBwcm9wZXJ0eQ0KPj4+PiBuZWVkcyB0byBiZSBtYXBwZWQg
dG8gRG9tYWluLTAgYXQgc3RhcnR1cCBhcyBNTUlPIG1hcHBpbmcgaXMgZ29pbmcgdG8NCj4+Pj4g
YmUgaGFuZGxlZCBkeW5hbWljYWxseSBieSB2UENJIGFzIHdlIGFzc2lnbiBQQ0kgZGV2aWNlcywg
ZS5nLiBlYWNoDQo+Pj4+IGRldmljZSBhc3NpZ25lZCB0byBEb21haW4tMC9ndWVzdCB3aWxsIGhh
dmUgaXRzIE1NSU9zIG1hcHBlZC91bm1hcHBlZA0KPj4+PiBhcyBuZWVkZWQgYnkgWGVuLg0KPj4+
Pg0KPj4+PiBUaGUgInJlZyIgcHJvcGVydHkgY292ZXJzIG5vdCBvbmx5IEVDQU0gc3BhY2UsIGJ1
dCBtYXkgYWxzbyBoYXZlIG90aGVyDQo+Pj4+IHRoZW4gdGhlIGNvbmZpZ3VyYXRpb24gbWVtb3J5
IHJhbmdlcyBkZXNjcmliZWQsIGZvciBleGFtcGxlIFszXToNCj4+Pj4gLSByZWc6IFNob3VsZCBj
b250YWluIHJjX2RiaSwgY29uZmlnIHJlZ2lzdGVycyBsb2NhdGlvbiBhbmQgbGVuZ3RoLg0KPj4+
PiAtIHJlZy1uYW1lczogTXVzdCBpbmNsdWRlIHRoZSBmb2xsb3dpbmcgZW50cmllczoNCj4+Pj4g
ICAgICAicmNfZGJpIjogY29udHJvbGxlciBjb25maWd1cmF0aW9uIHJlZ2lzdGVyczsNCj4+Pj4g
ICAgICAiY29uZmlnIjogUENJZSBjb25maWd1cmF0aW9uIHNwYWNlIHJlZ2lzdGVycy4NCj4+Pj4N
Cj4+Pj4gVGhpcyBwYXRjaCBtYWtlcyBpdCBwb3NzaWJsZSB0byBub3QgbWFwIGFsbCB0aGUgcmFu
Z2VzIGZyb20gdGhlDQo+Pj4+ICJyYW5nZXMiIHByb3BlcnR5IGFuZCBhbHNvIEVDQU0gZnJvbSB0
aGUgInJlZyIuIEFsbCB0aGUgcmVzdCBmcm9tIHRoZQ0KPj4+PiAicmVnIiBwcm9wZXJ0eSBzdGls
bCBuZWVkcyB0byBiZSBtYXBwZWQgdG8gRG9tYWluLTAsIHNvIHRoZSBQQ0kNCj4+Pj4gaG9zdCBi
cmlkZ2UgcmVtYWlucyBmdW5jdGlvbmFsIGluIERvbWFpbi0wLg0KPj4+Pg0KPj4+PiBbMV0gaHR0
cHM6Ly91cmxkZWZlbnNlLmNvbS92My9fX2h0dHBzOi8vbGlzdHMueGVucHJvamVjdC5vcmcvYXJj
aGl2ZXMvaHRtbC94ZW4tZGV2ZWwvMjAyMC0wNy9tc2cwMDc3Ny5odG1sX187ISFHRl8yOWRiY1FJ
VUJQQSFuV19MVmM1TmVTN1FRSUk3Q0RPNGgzaWZIaHhkUEF2UXBMU1ZhWDFDUnlYaDNjMWE0YTlj
QnBROVM3U2lBc0RkTWJMNVJrVEpwdyQgW2xpc3RzWy5deGVucHJvamVjdFsuXW9yZ10NCj4+Pj4g
WzJdIGh0dHBzOi8vdXJsZGVmZW5zZS5jb20vdjMvX19odHRwczovL3d3dy5rZXJuZWwub3JnL2Rv
Yy9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvcGNpL2hvc3QtZ2VuZXJpYy1wY2ku
dHh0X187ISFHRl8yOWRiY1FJVUJQQSFuV19MVmM1TmVTN1FRSUk3Q0RPNGgzaWZIaHhkUEF2UXBM
U1ZhWDFDUnlYaDNjMWE0YTljQnBROVM3U2lBc0RkTWJMLXZHdW5oZyQgW2tlcm5lbFsuXW9yZ10N
Cj4+Pj4gWzNdIGh0dHBzOi8vdXJsZGVmZW5zZS5jb20vdjMvX19odHRwczovL3d3dy5rZXJuZWwu
b3JnL2RvYy9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvcGNpL2hpc2lsaWNvbi1w
Y2llLnR4dF9fOyEhR0ZfMjlkYmNRSVVCUEEhbldfTFZjNU5lUzdRUUlJN0NETzRoM2lmSGh4ZFBB
dlFwTFNWYVgxQ1J5WGgzYzFhNGE5Y0JwUTlTN1NpQXNEZE1iS2pMMDR0UkEkIFtrZXJuZWxbLl1v
cmddDQo+Pj4+DQo+Pj4+IFNpZ25lZC1vZmYtYnk6IE9sZWtzYW5kciBBbmRydXNoY2hlbmtvIDxv
bGVrc2FuZHJfYW5kcnVzaGNoZW5rb0BlcGFtLmNvbT4NCj4+Pj4gLS0tDQo+Pj4+IFNpbmNlIHYz
Og0KPj4+PiAgICAtIHBhc3Mgc3RydWN0IG1hcF9yYW5nZV9kYXRhIHRvIG1hcF9kdF9pcnFfdG9f
ZG9tYWluDQo+Pj4+ICAgIC0gcmVtb3ZlIHJlZHVuZGFudCBjaGVjayBmcm9tIG1hcF9yYW5nZV90
b19kb21haW4NCj4+Pj4gICAgLSBmaXggaGFuZGxlX2RldmljZSdzIC5za2lwX21hcHBpbmcNCj4+
Pj4gU2luY2UgdjI6DQo+Pj4+ICAgIC0gcmVtb3ZlZCBjaGVjayBpbiBtYXBfcmFuZ2VfdG9fZG9t
YWluIGZvciBQQ0lfREVWDQo+Pj4+ICAgICAgYW5kIG1vdmVkIGl0IHRvIGhhbmRsZV9kZXZpY2Us
IHNvIHRoZSBjb2RlIGlzDQo+Pj4+ICAgICAgc2ltcGxlcg0KPj4+PiAgICAtIHMvbWFwX3BjaV9i
cmlkZ2Uvc2tpcF9tYXBwaW5nDQo+Pj4+ICAgIC0gZXh0ZW5kZWQgY29tbWVudCBpbiBwY2lfaG9z
dF9icmlkZ2VfbWFwcGluZ3MNCj4+Pj4gICAgLSBtaW5vciBjb2RlIHJlc3RydWN0dXJlIGluIGNv
bnN0cnVjdF9kb20wDQo+Pj4+ICAgIC0gcy8ubmVlZF9wMm1fbWFwcGluZy8ubmVlZF9wMm1faHdk
b21fbWFwcGluZyBhbmQgcmVsYXRlZA0KPj4+PiAgICAgIGNhbGxiYWNrcw0KPj4+PiAgICAtIHVu
c2lnbmVkIGludCBpOyBpbiBwY2lfaG9zdF9icmlkZ2VfbWFwcGluZ3MNCj4+Pj4gU2luY2UgdjE6
DQo+Pj4+ICAgIC0gQWRkZWQgYmV0dGVyIGRlc2NyaXB0aW9uIG9mIHdoeSBhbmQgd2hhdCBuZWVk
cyB0byBiZSBtYXBwZWQgaW50bw0KPj4+PiAgICAgIERvbWFpbi0wJ3MgcDJtIGFuZCB3aGF0IGRv
ZXNuJ3QNCj4+Pj4gICAgLSBEbyBub3QgZG8gYW55IG1hcHBpbmdzIGZvciBQQ0kgZGV2aWNlcyB3
aGlsZSB0cmF2ZXJzaW5nIHRoZSBEVA0KPj4+PiAgICAtIFdhbGsgYWxsIHRoZSBicmlkZ2VzIGFu
ZCBtYWtlIHJlcXVpcmVkIG1hcHBpbmdzIGluIG9uZSBnbw0KPj4+PiAtLS0NCj4+Pj4gICAgeGVu
L2FyY2gvYXJtL2RvbWFpbl9idWlsZC5jICAgICAgICB8IDUwICsrKysrKysrKysrKysrKystLS0t
LS0tLS0tLS0tLQ0KPj4+PiAgICB4ZW4vYXJjaC9hcm0vcGNpL2VjYW0uYyAgICAgICAgICAgIHwg
MTQgKysrKysrKysrDQo+Pj4+ICAgIHhlbi9hcmNoL2FybS9wY2kvcGNpLWhvc3QtY29tbW9uLmMg
fCA0OSArKysrKysrKysrKysrKysrKysrKysrKysrKysrKw0KPj4+PiAgICB4ZW4vYXJjaC9hcm0v
cGNpL3BjaS1ob3N0LXp5bnFtcC5jIHwgIDEgKw0KPj4+PiAgICB4ZW4vaW5jbHVkZS9hc20tYXJt
L3BjaS5oICAgICAgICAgIHwgMTAgKysrKysrDQo+Pj4+ICAgIHhlbi9pbmNsdWRlL2FzbS1hcm0v
c2V0dXAuaCAgICAgICAgfCAxMyArKysrKysrKw0KPj4+PiAgICA2IGZpbGVzIGNoYW5nZWQsIDEx
NCBpbnNlcnRpb25zKCspLCAyMyBkZWxldGlvbnMoLSkNCj4+Pj4NCj4+Pj4gZGlmZiAtLWdpdCBh
L3hlbi9hcmNoL2FybS9kb21haW5fYnVpbGQuYyBiL3hlbi9hcmNoL2FybS9kb21haW5fYnVpbGQu
Yw0KPj4+PiBpbmRleCA4NzM5ZTMyODVlZjQuLjJhM2M2NDE0NzZiZCAxMDA2NDQNCj4+Pj4gLS0t
IGEveGVuL2FyY2gvYXJtL2RvbWFpbl9idWlsZC5jDQo+Pj4+ICsrKyBiL3hlbi9hcmNoL2FybS9k
b21haW5fYnVpbGQuYw0KPj4+PiBAQCAtMTAsNyArMTAsNiBAQA0KPj4+PiAgICAjaW5jbHVkZSA8
YXNtL3JlZ3MuaD4NCj4+Pj4gICAgI2luY2x1ZGUgPHhlbi9lcnJuby5oPg0KPj4+PiAgICAjaW5j
bHVkZSA8eGVuL2Vyci5oPg0KPj4+PiAtI2luY2x1ZGUgPHhlbi9kZXZpY2VfdHJlZS5oPg0KPj4+
PiAgICAjaW5jbHVkZSA8eGVuL2xpYmZkdC9saWJmZHQuaD4NCj4+Pj4gICAgI2luY2x1ZGUgPHhl
bi9ndWVzdF9hY2Nlc3MuaD4NCj4+Pj4gICAgI2luY2x1ZGUgPHhlbi9pb2NhcC5oPg0KPj4+PiBA
QCAtNTEsMTIgKzUwLDYgQEAgc3RhdGljIGludCBfX2luaXQgcGFyc2VfZG9tMF9tZW0oY29uc3Qg
Y2hhciAqcykNCj4+Pj4gICAgfQ0KPj4+PiAgICBjdXN0b21fcGFyYW0oImRvbTBfbWVtIiwgcGFy
c2VfZG9tMF9tZW0pOw0KPj4+PiAgICANCj4+Pj4gLXN0cnVjdCBtYXBfcmFuZ2VfZGF0YQ0KPj4+
PiAtew0KPj4+PiAtICAgIHN0cnVjdCBkb21haW4gKmQ7DQo+Pj4+IC0gICAgcDJtX3R5cGVfdCBw
Mm10Ow0KPj4+PiAtfTsNCj4+Pj4gLQ0KPj4+PiAgICAvKiBPdmVycmlkZSBtYWNyb3MgZnJvbSBh
c20vcGFnZS5oIHRvIG1ha2UgdGhlbSB3b3JrIHdpdGggbWZuX3QgKi8NCj4+Pj4gICAgI3VuZGVm
IHZpcnRfdG9fbWZuDQo+Pj4+ICAgICNkZWZpbmUgdmlydF90b19tZm4odmEpIF9tZm4oX192aXJ0
X3RvX21mbih2YSkpDQo+Pj4+IEBAIC0xNjQxLDEwICsxNjM0LDExIEBAIHN0YXRpYyBpbnQgX19p
bml0IG1hcF9kdF9pcnFfdG9fZG9tYWluKGNvbnN0IHN0cnVjdCBkdF9kZXZpY2Vfbm9kZSAqZGV2
LA0KPj4+PiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjb25zdCBz
dHJ1Y3QgZHRfaXJxICpkdF9pcnEsDQo+Pj4+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgIHZvaWQgKmRhdGEpDQo+Pj4+ICAgIHsNCj4+Pj4gLSAgICBzdHJ1Y3QgZG9t
YWluICpkID0gZGF0YTsNCj4+Pj4gKyAgICBzdHJ1Y3QgbWFwX3JhbmdlX2RhdGEgKm1yX2RhdGEg
PSBkYXRhOw0KPj4+PiArICAgIHN0cnVjdCBkb21haW4gKmQgPSBtcl9kYXRhLT5kOw0KPj4+PiAg
ICAgICAgdW5zaWduZWQgaW50IGlycSA9IGR0X2lycS0+aXJxOw0KPj4+PiAgICAgICAgaW50IHJl
czsNCj4+Pj4gLSAgICBib29sIG5lZWRfbWFwcGluZyA9ICFkdF9kZXZpY2VfZm9yX3Bhc3N0aHJv
dWdoKGRldik7DQo+Pj4+ICsgICAgYm9vbCBuZWVkX21hcHBpbmcgPSAhbXJfZGF0YS0+c2tpcF9t
YXBwaW5nOw0KPj4+PiAgICANCj4+Pj4gICAgICAgIGlmICggaXJxIDwgTlJfTE9DQUxfSVJRUyAp
DQo+Pj4+ICAgICAgICB7DQo+Pj4+IEBAIC0xNjY4LDEzICsxNjYyLDEyIEBAIHN0YXRpYyBpbnQg
X19pbml0IG1hcF9kdF9pcnFfdG9fZG9tYWluKGNvbnN0IHN0cnVjdCBkdF9kZXZpY2Vfbm9kZSAq
ZGV2LA0KPj4+PiAgICAgICAgcmV0dXJuIDA7DQo+Pj4+ICAgIH0NCj4+Pj4gICAgDQo+Pj4+IC1z
dGF0aWMgaW50IF9faW5pdCBtYXBfcmFuZ2VfdG9fZG9tYWluKGNvbnN0IHN0cnVjdCBkdF9kZXZp
Y2Vfbm9kZSAqZGV2LA0KPj4+PiAtICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICB1NjQgYWRkciwgdTY0IGxlbiwNCj4+Pj4gLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgdm9pZCAqZGF0YSkNCj4+Pj4gK2ludCBfX2luaXQgbWFwX3JhbmdlX3RvX2RvbWFp
bihjb25zdCBzdHJ1Y3QgZHRfZGV2aWNlX25vZGUgKmRldiwNCj4+Pj4gKyAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICB1NjQgYWRkciwgdTY0IGxlbiwgdm9pZCAqZGF0YSkNCj4+Pj4gICAg
ew0KPj4+PiAgICAgICAgc3RydWN0IG1hcF9yYW5nZV9kYXRhICptcl9kYXRhID0gZGF0YTsNCj4+
Pj4gICAgICAgIHN0cnVjdCBkb21haW4gKmQgPSBtcl9kYXRhLT5kOw0KPj4+PiAtICAgIGJvb2wg
bmVlZF9tYXBwaW5nID0gIWR0X2RldmljZV9mb3JfcGFzc3Rocm91Z2goZGV2KTsNCj4+Pj4gKyAg
ICBib29sIG5lZWRfbWFwcGluZyA9ICFtcl9kYXRhLT5za2lwX21hcHBpbmc7DQo+Pj4+ICAgICAg
ICBpbnQgcmVzOw0KPj4+PiAgICANCj4+Pj4gICAgICAgIC8qDQo+Pj4+IEBAIC0xNzI2LDIzICsx
NzE5LDIxIEBAIHN0YXRpYyBpbnQgX19pbml0IG1hcF9yYW5nZV90b19kb21haW4oY29uc3Qgc3Ry
dWN0IGR0X2RldmljZV9ub2RlICpkZXYsDQo+Pj4+ICAgICAqIHRoZW4gd2UgbWF5IG5lZWQgdG8g
cGVyZm9ybSBhZGRpdGlvbmFsIG1hcHBpbmdzIGluIG9yZGVyIHRvIG1ha2UNCj4+Pj4gICAgICog
dGhlIGNoaWxkIHJlc291cmNlcyBhdmFpbGFibGUgdG8gZG9tYWluIDAuDQo+Pj4+ICAgICAqLw0K
Pj4+PiAtc3RhdGljIGludCBfX2luaXQgbWFwX2RldmljZV9jaGlsZHJlbihzdHJ1Y3QgZG9tYWlu
ICpkLA0KPj4+PiAtICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjb25zdCBz
dHJ1Y3QgZHRfZGV2aWNlX25vZGUgKmRldiwNCj4+Pj4gLSAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgcDJtX3R5cGVfdCBwMm10KQ0KPj4+PiArc3RhdGljIGludCBfX2luaXQg
bWFwX2RldmljZV9jaGlsZHJlbihjb25zdCBzdHJ1Y3QgZHRfZGV2aWNlX25vZGUgKmRldiwNCj4+
Pj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgc3RydWN0IG1hcF9yYW5n
ZV9kYXRhICptcl9kYXRhKQ0KPj4+PiAgICB7DQo+Pj4+IC0gICAgc3RydWN0IG1hcF9yYW5nZV9k
YXRhIG1yX2RhdGEgPSB7IC5kID0gZCwgLnAybXQgPSBwMm10IH07DQo+Pj4+IC0gICAgaW50IHJl
dDsNCj4+Pj4gLQ0KPj4+PiAgICAgICAgaWYgKCBkdF9kZXZpY2VfdHlwZV9pc19lcXVhbChkZXYs
ICJwY2kiKSApDQo+Pj4+ICAgICAgICB7DQo+Pj4+ICsgICAgICAgIGludCByZXQ7DQo+Pj4+ICsN
Cj4+Pj4gICAgICAgICAgICBkdF9kcHJpbnRrKCJNYXBwaW5nIGNoaWxkcmVuIG9mICVzIHRvIGd1
ZXN0XG4iLA0KPj4+PiAgICAgICAgICAgICAgICAgICAgICAgZHRfbm9kZV9mdWxsX25hbWUoZGV2
KSk7DQo+Pj4+ICAgIA0KPj4+PiAtICAgICAgICByZXQgPSBkdF9mb3JfZWFjaF9pcnFfbWFwKGRl
diwgJm1hcF9kdF9pcnFfdG9fZG9tYWluLCBkKTsNCj4+Pj4gKyAgICAgICAgcmV0ID0gZHRfZm9y
X2VhY2hfaXJxX21hcChkZXYsICZtYXBfZHRfaXJxX3RvX2RvbWFpbiwgbXJfZGF0YSk7DQo+Pj4+
ICAgICAgICAgICAgaWYgKCByZXQgPCAwICkNCj4+Pj4gICAgICAgICAgICAgICAgcmV0dXJuIHJl
dDsNCj4+Pj4gICAgDQo+Pj4+IC0gICAgICAgIHJldCA9IGR0X2Zvcl9lYWNoX3JhbmdlKGRldiwg
Jm1hcF9yYW5nZV90b19kb21haW4sICZtcl9kYXRhKTsNCj4+Pj4gKyAgICAgICAgcmV0ID0gZHRf
Zm9yX2VhY2hfcmFuZ2UoZGV2LCAmbWFwX3JhbmdlX3RvX2RvbWFpbiwgbXJfZGF0YSk7DQo+Pj4+
ICAgICAgICAgICAgaWYgKCByZXQgPCAwICkNCj4+Pj4gICAgICAgICAgICAgICAgcmV0dXJuIHJl
dDsNCj4+Pj4gICAgICAgIH0NCj4+Pj4gQEAgLTE4MjMsNiArMTgxNCwxMyBAQCBzdGF0aWMgaW50
IF9faW5pdCBoYW5kbGVfZGV2aWNlKHN0cnVjdCBkb21haW4gKmQsIHN0cnVjdCBkdF9kZXZpY2Vf
bm9kZSAqZGV2LA0KPj4+PiAgICAgICAgaW50IHJlczsNCj4+Pj4gICAgICAgIHU2NCBhZGRyLCBz
aXplOw0KPj4+PiAgICAgICAgYm9vbCBuZWVkX21hcHBpbmcgPSAhZHRfZGV2aWNlX2Zvcl9wYXNz
dGhyb3VnaChkZXYpOw0KPj4+PiArICAgIHN0cnVjdCBtYXBfcmFuZ2VfZGF0YSBtcl9kYXRhID0g
ew0KPj4+PiArICAgICAgICAuZCA9IGQsDQo+Pj4+ICsgICAgICAgIC5wMm10ID0gcDJtdCwNCj4+
Pj4gKyAgICAgICAgLnNraXBfbWFwcGluZyA9ICFuZWVkX21hcHBpbmcgfHwNCj4+Pj4gKyAgICAg
ICAgICAgICAgICAgICAgICAgIChpc19wY2lfcGFzc3Rocm91Z2hfZW5hYmxlZCgpICYmDQo+Pj4+
ICsgICAgICAgICAgICAgICAgICAgICAgICAgKGRldmljZV9nZXRfY2xhc3MoZGV2KSA9PSBERVZJ
Q0VfUENJKSkNCj4+Pj4gKyAgICB9Ow0KPj4+IEkgd291bGQgcHJlZmVyIGlmIHdlIGRpZCB0aGlz
Og0KPj4+DQo+Pj4gZGlmZiAtLWdpdCBhL3hlbi9hcmNoL2FybS9kb21haW5fYnVpbGQuYyBiL3hl
bi9hcmNoL2FybS9kb21haW5fYnVpbGQuYw0KPj4+IGluZGV4IDJhM2M2NDE0NzYuLjFlN2NkZDEx
YzcgMTAwNjQ0DQo+Pj4gLS0tIGEveGVuL2FyY2gvYXJtL2RvbWFpbl9idWlsZC5jDQo+Pj4gKysr
IGIveGVuL2FyY2gvYXJtL2RvbWFpbl9idWlsZC5jDQo+Pj4gQEAgLTE4MTMsMTMgKzE4MTMsMTMg
QEAgc3RhdGljIGludCBfX2luaXQgaGFuZGxlX2RldmljZShzdHJ1Y3QgZG9tYWluICpkLCBzdHJ1
Y3QgZHRfZGV2aWNlX25vZGUgKmRldiwNCj4+PiAgICAgICAgdW5zaWduZWQgaW50IGk7DQo+Pj4g
ICAgICAgIGludCByZXM7DQo+Pj4gICAgICAgIHU2NCBhZGRyLCBzaXplOw0KPj4+IC0gICAgYm9v
bCBuZWVkX21hcHBpbmcgPSAhZHRfZGV2aWNlX2Zvcl9wYXNzdGhyb3VnaChkZXYpOw0KPj4+ICsg
ICAgYm9vbCBuZWVkX21hcHBpbmcgPSAhZHRfZGV2aWNlX2Zvcl9wYXNzdGhyb3VnaChkZXYpICYm
DQo+Pj4gKyAgICAgICAgICAgICAgICAgICAgICAgICEoaXNfcGNpX3Bhc3N0aHJvdWdoX2VuYWJs
ZWQoKSAmJg0KPj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgIChkZXZpY2VfZ2V0X2NsYXNz
KGRldikgPT0gREVWSUNFX1BDSSkpDQo+Pj4gICAgICAgIHN0cnVjdCBtYXBfcmFuZ2VfZGF0YSBt
cl9kYXRhID0gew0KPj4+ICAgICAgICAgICAgLmQgPSBkLA0KPj4+ICAgICAgICAgICAgLnAybXQg
PSBwMm10LA0KPj4+IC0gICAgICAgIC5za2lwX21hcHBpbmcgPSAhbmVlZF9tYXBwaW5nIHx8DQo+
Pj4gLSAgICAgICAgICAgICAgICAgICAgICAgIChpc19wY2lfcGFzc3Rocm91Z2hfZW5hYmxlZCgp
ICYmDQo+Pj4gLSAgICAgICAgICAgICAgICAgICAgICAgICAoZGV2aWNlX2dldF9jbGFzcyhkZXYp
ID09IERFVklDRV9QQ0kpKQ0KPj4+ICsgICAgICAgIC5za2lwX21hcHBpbmcgPSAhbmVlZF9tYXBw
aW5nDQo+Pj4gICAgICAgIH07DQo+Pj4gICAgDQo+Pj4gICAgICAgIG5hZGRyID0gZHRfbnVtYmVy
X29mX2FkZHJlc3MoZGV2KTsNCj4+Pg0KPj4+DQo+Pj4gVGhpcyBhY3R1YWxseSBtYWtlcyBhIGRp
ZmZlcmVuY2UgYmVjYXVzZSBvdGhlcndpc2UNCj4+PiBoYW5kbGVfZGV2aWNlX2ludGVycnVwdHMg
Y291bGQgc3RpbGwgYmUgY2FsbGVkIHdpdGggbmVlZF9tYXBwaW5nID09DQo+Pj4gdHJ1ZSBmb3Ig
UENJIGRldmljZXMuDQo+PiBBbmQgdGhpcyBpcyB0b3RhbGx5IGZpbmUuIFJlbWVtYmVyIHRoZSBu
YW1lIG9mIHRoZSBwYXRjaDogd2UgZG8gbm90DQo+PiB3YW50IHRvIG1hcCBtZW1vcnksIGJ1dCBp
bnRlcnJ1cHRzIGFyZSBzdGlsbCBuZWVkZWQgZm9yIHRoZSBicmlkZ2UgdG8NCj4+IGZ1bmN0aW9u
IGluIERvbTAuIFRoZSBzYW1lIGFzIGl0IG5lZWRzIGFsbCwgYnV0ICJjZmciIGZyb20gInJlZ3Mi
Lg0KPj4gU28sIG5lZWRfbWFwcGluZyA9PSB0cnVlIGZvciBpbnRlcnJ1cHRzIGlzIHdoYXQgd2Ug
d2FudDogbGVnYWN5IElOVHgNCj4+IGFyZSBub3Qgc3VwcG9ydGVkIGJ5IGRlc2lnbiBhbmQgb25s
eSBNU0kvTVNJLVggYXJlIHN1cHBvcnRlZC4NCj4gQWgsIG1ha2VzIHNlbnNlLCBJIG1vbWVudGFy
aWx5IGxvc3Qgc2lnaHQgb2YgdGhhdC4gQ291bGQgeW91IHBsZWFzZSBhZGQNCj4gYW4gaW4tY29k
ZSBjb21tZW50IHRvIGV4cGxhaW4gaXQsIHNvbWV0aGluZyBsaWtlOg0KPg0KPiAvKg0KPiAgICog
Rm9yIFBDSSBwYXNzdGhyb3VnaCB3ZSBuZWVkIHRvIHJlbWFwIG9ubHkgaW50ZXJydXB0cyB0byBE
b20wLiBNTUlPDQo+ICAgKiByZWdpb25zIG9mIHRoZSBQQ0llIFJvb3QgQ29tcGxleCBhbmQgUENJ
ZSBhcGVydHVyZSBzaG91bGQgbm90IGJlDQo+ICAgKiBtYXBwZWQgYXV0b21hdGljYWxseSB0byBE
b20wLg0KPiAgICovDQo+IHN0cnVjdCBtYXBfcmFuZ2VfZGF0YSBtcl9kYXRhID0gew0KPiAgICAg
ICAgICAuZCA9IGQsDQo+ICAgICAgICAgIC5wMm10ID0gcDJtdCwNCj4gICAgICAgICAgLnNraXBf
bWFwcGluZyA9ICFuZWVkX21hcHBpbmcgfHwNCj4gICAgICAgICAgICAgICAgICAgICAgICAgIChp
c19wY2lfcGFzc3Rocm91Z2hfZW5hYmxlZCgpICYmDQo+ICAgICAgICAgICAgICAgICAgICAgICAg
ICAgKGRldmljZV9nZXRfY2xhc3MoZGV2KSA9PSBERVZJQ0VfUENJKSkNCj4gICAgICB9Ow0KU3Vy
ZSB3aWxsIGFkZCB0aGlzIHNvIHdlIGRvbid0IHN0ZXAgb24gaXQgaW4gdGhlIGZ1dHVyZS4NCk90
aGVyIHRoYW4gdGhpcyBhbmQgdGhlIG1pc3NlZCBjb21tZW50IGJlbG93IGRvIHlvdSB0aGluaw0K
dGhhdCBwYXRjaCBpcyBnb29kIHRvIGdvIG5vdz8NClRoYW5rIHlvdSwNCk9sZWtzYW5kcg0KPg0K
Pj4+IFdoYXQgZG8geW91IHRoaW5rPyAgT25lIG1vcmUgY29tbWVudCBiZWxvdy4NCj4+Pg0KPj4+
DQo+Pj4+ICAgICAgICBuYWRkciA9IGR0X251bWJlcl9vZl9hZGRyZXNzKGRldik7DQo+Pj4+ICAg
IA0KPj4+PiBAQCAtMTg2Miw3ICsxODYwLDYgQEAgc3RhdGljIGludCBfX2luaXQgaGFuZGxlX2Rl
dmljZShzdHJ1Y3QgZG9tYWluICpkLCBzdHJ1Y3QgZHRfZGV2aWNlX25vZGUgKmRldiwNCj4+Pj4g
ICAgICAgIC8qIEdpdmUgcGVybWlzc2lvbiBhbmQgbWFwIE1NSU9zICovDQo+Pj4+ICAgICAgICBm
b3IgKCBpID0gMDsgaSA8IG5hZGRyOyBpKysgKQ0KPj4+PiAgICAgICAgew0KPj4+PiAtICAgICAg
ICBzdHJ1Y3QgbWFwX3JhbmdlX2RhdGEgbXJfZGF0YSA9IHsgLmQgPSBkLCAucDJtdCA9IHAybXQg
fTsNCj4+Pj4gICAgICAgICAgICByZXMgPSBkdF9kZXZpY2VfZ2V0X2FkZHJlc3MoZGV2LCBpLCAm
YWRkciwgJnNpemUpOw0KPj4+PiAgICAgICAgICAgIGlmICggcmVzICkNCj4+Pj4gICAgICAgICAg
ICB7DQo+Pj4+IEBAIC0xODc2LDcgKzE4NzMsNyBAQCBzdGF0aWMgaW50IF9faW5pdCBoYW5kbGVf
ZGV2aWNlKHN0cnVjdCBkb21haW4gKmQsIHN0cnVjdCBkdF9kZXZpY2Vfbm9kZSAqZGV2LA0KPj4+
PiAgICAgICAgICAgICAgICByZXR1cm4gcmVzOw0KPj4+PiAgICAgICAgfQ0KPj4+PiAgICANCj4+
Pj4gLSAgICByZXMgPSBtYXBfZGV2aWNlX2NoaWxkcmVuKGQsIGRldiwgcDJtdCk7DQo+Pj4+ICsg
ICAgcmVzID0gbWFwX2RldmljZV9jaGlsZHJlbihkZXYsICZtcl9kYXRhKTsNCj4+Pj4gICAgICAg
IGlmICggcmVzICkNCj4+Pj4gICAgICAgICAgICByZXR1cm4gcmVzOw0KPj4+PiAgICANCj4+Pj4g
QEAgLTMwMzQsNyArMzAzMSwxNCBAQCBzdGF0aWMgaW50IF9faW5pdCBjb25zdHJ1Y3RfZG9tMChz
dHJ1Y3QgZG9tYWluICpkKQ0KPj4+PiAgICAgICAgICAgIHJldHVybiByYzsNCj4+Pj4gICAgDQo+
Pj4+ICAgICAgICBpZiAoIGFjcGlfZGlzYWJsZWQgKQ0KPj4+PiArICAgIHsNCj4+Pj4gICAgICAg
ICAgICByYyA9IHByZXBhcmVfZHRiX2h3ZG9tKGQsICZraW5mbyk7DQo+Pj4+ICsgICAgICAgIGlm
ICggcmMgPCAwICkNCj4+Pj4gKyAgICAgICAgICAgIHJldHVybiByYzsNCj4+Pj4gKyNpZmRlZiBD
T05GSUdfSEFTX1BDSQ0KPj4+PiArICAgICAgICByYyA9IHBjaV9ob3N0X2JyaWRnZV9tYXBwaW5n
cyhkLCBwMm1fbW1pb19kaXJlY3RfYyk7DQo+Pj4+ICsjZW5kaWYNCj4+Pj4gKyAgICB9DQo+Pj4+
ICAgICAgICBlbHNlDQo+Pj4+ICAgICAgICAgICAgcmMgPSBwcmVwYXJlX2FjcGkoZCwgJmtpbmZv
KTsNCj4+Pj4gICAgDQo+Pj4+IGRpZmYgLS1naXQgYS94ZW4vYXJjaC9hcm0vcGNpL2VjYW0uYyBi
L3hlbi9hcmNoL2FybS9wY2kvZWNhbS5jDQo+Pj4+IGluZGV4IDYwMmQwMDc5OWM4ZC4uYjgxNjIw
MDc0YTkxIDEwMDY0NA0KPj4+PiAtLS0gYS94ZW4vYXJjaC9hcm0vcGNpL2VjYW0uYw0KPj4+PiAr
KysgYi94ZW4vYXJjaC9hcm0vcGNpL2VjYW0uYw0KPj4+PiBAQCAtNDAsNiArNDAsMTkgQEAgdm9p
ZCBfX2lvbWVtICpwY2lfZWNhbV9tYXBfYnVzKHN0cnVjdCBwY2lfaG9zdF9icmlkZ2UgKmJyaWRn
ZSwNCj4+Pj4gICAgICAgIHJldHVybiBiYXNlICsgKFBDSV9ERVZGTjIoc2JkZi5iZGYpIDw8IGRl
dmZuX3NoaWZ0KSArIHdoZXJlOw0KPj4+PiAgICB9DQo+Pj4+ICAgIA0KPj4+PiArYm9vbCBwY2lf
ZWNhbV9uZWVkX3AybV9od2RvbV9tYXBwaW5nKHN0cnVjdCBkb21haW4gKmQsDQo+Pj4+ICsgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgc3RydWN0IHBjaV9ob3N0X2JyaWRnZSAq
YnJpZGdlLA0KPj4+PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHVpbnQ2
NF90IGFkZHIpDQo+Pj4+ICt7DQo+Pj4+ICsgICAgc3RydWN0IHBjaV9jb25maWdfd2luZG93ICpj
ZmcgPSBicmlkZ2UtPmNmZzsNCj4+Pj4gKw0KPj4+PiArICAgIC8qDQo+Pj4+ICsgICAgICogV2Ug
ZG8gbm90IHdhbnQgRUNBTSBhZGRyZXNzIHNwYWNlIHRvIGJlIG1hcHBlZCBpbiBEb21haW4tMCdz
IHAybSwNCj4+Pj4gKyAgICAgKiBzbyB3ZSBjYW4gdHJhcCBhY2Nlc3MgdG8gaXQuDQo+Pj4+ICsg
ICAgICovDQo+Pj4+ICsgICAgcmV0dXJuIGNmZy0+cGh5c19hZGRyICE9IGFkZHI7DQo+Pj4+ICt9
DQo+Pj4+ICsNCj4+Pj4gICAgLyogRUNBTSBvcHMgKi8NCj4+Pj4gICAgY29uc3Qgc3RydWN0IHBj
aV9lY2FtX29wcyBwY2lfZ2VuZXJpY19lY2FtX29wcyA9IHsNCj4+Pj4gICAgICAgIC5idXNfc2hp
ZnQgID0gMjAsDQo+Pj4+IEBAIC00Nyw2ICs2MCw3IEBAIGNvbnN0IHN0cnVjdCBwY2lfZWNhbV9v
cHMgcGNpX2dlbmVyaWNfZWNhbV9vcHMgPSB7DQo+Pj4+ICAgICAgICAgICAgLm1hcF9idXMgICAg
ICAgICAgICAgICAgPSBwY2lfZWNhbV9tYXBfYnVzLA0KPj4+PiAgICAgICAgICAgIC5yZWFkICAg
ICAgICAgICAgICAgICAgID0gcGNpX2dlbmVyaWNfY29uZmlnX3JlYWQsDQo+Pj4+ICAgICAgICAg
ICAgLndyaXRlICAgICAgICAgICAgICAgICAgPSBwY2lfZ2VuZXJpY19jb25maWdfd3JpdGUsDQo+
Pj4+ICsgICAgICAgIC5uZWVkX3AybV9od2RvbV9tYXBwaW5nID0gcGNpX2VjYW1fbmVlZF9wMm1f
aHdkb21fbWFwcGluZywNCj4+Pj4gICAgICAgIH0NCj4+Pj4gICAgfTsNCj4+Pj4gICAgDQo+Pj4+
IGRpZmYgLS1naXQgYS94ZW4vYXJjaC9hcm0vcGNpL3BjaS1ob3N0LWNvbW1vbi5jIGIveGVuL2Fy
Y2gvYXJtL3BjaS9wY2ktaG9zdC1jb21tb24uYw0KPj4+PiBpbmRleCAxZWI0ZGFhODczNjUuLjA4
NWYwOGUyM2UwYyAxMDA2NDQNCj4+Pj4gLS0tIGEveGVuL2FyY2gvYXJtL3BjaS9wY2ktaG9zdC1j
b21tb24uYw0KPj4+PiArKysgYi94ZW4vYXJjaC9hcm0vcGNpL3BjaS1ob3N0LWNvbW1vbi5jDQo+
Pj4+IEBAIC0xOCw2ICsxOCw3IEBADQo+Pj4+ICAgIA0KPj4+PiAgICAjaW5jbHVkZSA8eGVuL2lu
aXQuaD4NCj4+Pj4gICAgI2luY2x1ZGUgPHhlbi9wY2kuaD4NCj4+Pj4gKyNpbmNsdWRlIDxhc20v
c2V0dXAuaD4NCj4+Pj4gICAgI2luY2x1ZGUgPHhlbi9yd2xvY2suaD4NCj4+Pj4gICAgI2luY2x1
ZGUgPHhlbi9zY2hlZC5oPg0KPj4+PiAgICAjaW5jbHVkZSA8eGVuL3ZtYXAuaD4NCj4+Pj4gQEAg
LTMyMCw2ICszMjEsNTQgQEAgaW50IHBjaV9ob3N0X2dldF9udW1fYnJpZGdlcyh2b2lkKQ0KPj4+
PiAgICAgICAgcmV0dXJuIGNvdW50Ow0KPj4+PiAgICB9DQo+Pj4+ICAgIA0KPj4+PiAraW50IF9f
aW5pdCBwY2lfaG9zdF9icmlkZ2VfbWFwcGluZ3Moc3RydWN0IGRvbWFpbiAqZCwgcDJtX3R5cGVf
dCBwMm10KQ0KPj4+PiArew0KPj4+PiArICAgIHN0cnVjdCBwY2lfaG9zdF9icmlkZ2UgKmJyaWRn
ZTsNCj4+Pj4gKyAgICBzdHJ1Y3QgbWFwX3JhbmdlX2RhdGEgbXJfZGF0YSA9IHsNCj4+Pj4gKyAg
ICAgICAgLmQgPSBkLA0KPj4+PiArICAgICAgICAucDJtdCA9IHAybXQsDQo+Pj4+ICsgICAgICAg
IC5za2lwX21hcHBpbmcgPSBmYWxzZQ0KPj4+PiArICAgIH07DQo+Pj4+ICsNCj4+Pj4gKyAgICAv
Kg0KPj4+PiArICAgICAqIEZvciBlYWNoIFBDSSBob3N0IGJyaWRnZSB3ZSBuZWVkIHRvIG9ubHkg
bWFwIHRob3NlIHJhbmdlcw0KPj4+PiArICAgICAqIHdoaWNoIGFyZSB1c2VkIGJ5IERvbWFpbi0w
IHRvIHByb3Blcmx5IGluaXRpYWxpemUgdGhlIGJyaWRnZSwNCj4+Pj4gKyAgICAgKiBlLmcuIHdl
IGRvIG5vdCB3YW50IHRvIG1hcCBFQ0FNIGNvbmZpZ3VyYXRpb24gc3BhY2Ugd2hpY2ggbGl2ZXMg
aW4NCj4+Pj4gKyAgICAgKiAicmVnIiBvciAiYXNzaWduZWQtYWRkcmVzc2VzIiBkZXZpY2UgdHJl
ZSBwcm9wZXJ0eSwgYnV0IHdlIHdhbnQgdG8NCj4+Pj4gKyAgICAgKiBtYXAgb3RoZXIgcmVnaW9u
cyBvZiB0aGUgaG9zdCBicmlkZ2UuIFRoZSBQQ0kgYXBlcnR1cmUgZGVmaW5lZCBieQ0KPj4+PiAr
ICAgICAqIHRoZSAicmFuZ2VzIiBkZXZpY2UgdHJlZSBwcm9wZXJ0eSBzaG91bGQgYWxzbyBiZSBz
a2lwcGVkLg0KPj4+PiArICAgICAqLw0KPj4+PiArICAgIGxpc3RfZm9yX2VhY2hfZW50cnkoIGJy
aWRnZSwgJnBjaV9ob3N0X2JyaWRnZXMsIG5vZGUgKQ0KPj4+PiArICAgIHsNCj4+Pj4gKyAgICAg
ICAgY29uc3Qgc3RydWN0IGR0X2RldmljZV9ub2RlICpkZXYgPSBicmlkZ2UtPmR0X25vZGU7DQo+
Pj4+ICsgICAgICAgIHVuc2lnbmVkIGludCBpOw0KPj4+PiArDQo+Pj4+ICsgICAgICAgIGZvciAo
IGkgPSAwOyBpIDwgZHRfbnVtYmVyX29mX2FkZHJlc3MoZGV2KTsgaSsrICkNCj4+Pj4gKyAgICAg
ICAgew0KPj4+PiArICAgICAgICAgICAgdWludDY0X3QgYWRkciwgc2l6ZTsNCj4+Pj4gKyAgICAg
ICAgICAgIGludCBlcnI7DQo+Pj4+ICsNCj4+Pj4gKyAgICAgICAgICAgIGVyciA9IGR0X2Rldmlj
ZV9nZXRfYWRkcmVzcyhkZXYsIGksICZhZGRyLCAmc2l6ZSk7DQo+Pj4+ICsgICAgICAgICAgICBp
ZiAoIGVyciApDQo+Pj4+ICsgICAgICAgICAgICB7DQo+Pj4+ICsgICAgICAgICAgICAgICAgcHJp
bnRrKFhFTkxPR19FUlINCj4+Pj4gKyAgICAgICAgICAgICAgICAgICAgICAgIlVuYWJsZSB0byBy
ZXRyaWV2ZSBhZGRyZXNzIHJhbmdlIGluZGV4PSV1IGZvciAlc1xuIiwNCj4+Pj4gKyAgICAgICAg
ICAgICAgICAgICAgICAgaSwgZHRfbm9kZV9mdWxsX25hbWUoZGV2KSk7DQo+Pj4+ICsgICAgICAg
ICAgICAgICAgcmV0dXJuIGVycjsNCj4+Pj4gKyAgICAgICAgICAgIH0NCj4+Pj4gKw0KPj4+PiAr
ICAgICAgICAgICAgaWYgKCBicmlkZ2UtPm9wcy0+bmVlZF9wMm1faHdkb21fbWFwcGluZyhkLCBi
cmlkZ2UsIGFkZHIpICkNCj4+Pj4gKyAgICAgICAgICAgIHsNCj4+Pj4gKyAgICAgICAgICAgICAg
ICBlcnIgPSBtYXBfcmFuZ2VfdG9fZG9tYWluKGRldiwgYWRkciwgc2l6ZSwgJm1yX2RhdGEpOw0K
Pj4+PiArICAgICAgICAgICAgICAgIGlmICggZXJyICkNCj4+Pj4gKyAgICAgICAgICAgICAgICAg
ICAgcmV0dXJuIGVycjsNCj4+Pj4gKyAgICAgICAgICAgIH0NCj4+Pj4gKyAgICAgICAgfQ0KPj4+
PiArICAgIH0NCj4+Pj4gKw0KPj4+PiArICAgIHJldHVybiAwOw0KPj4+PiArfQ0KPj4+PiArDQo+
Pj4+ICAgIC8qDQo+Pj4+ICAgICAqIExvY2FsIHZhcmlhYmxlczoNCj4+Pj4gICAgICogbW9kZTog
Qw0KPj4+PiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gvYXJtL3BjaS9wY2ktaG9zdC16eW5xbXAuYyBi
L3hlbi9hcmNoL2FybS9wY2kvcGNpLWhvc3QtenlucW1wLmMNCj4+Pj4gaW5kZXggNjFhOTgwN2Qz
ZDU4Li42YWQyYjMxZTgxMGQgMTAwNjQ0DQo+Pj4+IC0tLSBhL3hlbi9hcmNoL2FybS9wY2kvcGNp
LWhvc3QtenlucW1wLmMNCj4+Pj4gKysrIGIveGVuL2FyY2gvYXJtL3BjaS9wY2ktaG9zdC16eW5x
bXAuYw0KPj4+PiBAQCAtMzQsNiArMzQsNyBAQCBjb25zdCBzdHJ1Y3QgcGNpX2VjYW1fb3BzIG53
bF9wY2llX29wcyA9IHsNCj4+Pj4gICAgICAgICAgICAubWFwX2J1cyAgICAgICAgICAgICAgICA9
IHBjaV9lY2FtX21hcF9idXMsDQo+Pj4+ICAgICAgICAgICAgLnJlYWQgICAgICAgICAgICAgICAg
ICAgPSBwY2lfZ2VuZXJpY19jb25maWdfcmVhZCwNCj4+Pj4gICAgICAgICAgICAud3JpdGUgICAg
ICAgICAgICAgICAgICA9IHBjaV9nZW5lcmljX2NvbmZpZ193cml0ZSwNCj4+Pj4gKyAgICAgICAg
Lm5lZWRfcDJtX2h3ZG9tX21hcHBpbmcgPSBwY2lfZWNhbV9uZWVkX3AybV9od2RvbV9tYXBwaW5n
LA0KPj4+PiAgICAgICAgfQ0KPj4+PiAgICB9Ow0KPj4+PiAgICANCj4+Pj4gZGlmZiAtLWdpdCBh
L3hlbi9pbmNsdWRlL2FzbS1hcm0vcGNpLmggYi94ZW4vaW5jbHVkZS9hc20tYXJtL3BjaS5oDQo+
Pj4+IGluZGV4IGE2MmQ4YmM2MDA4Ni4uZDlhM2MyYTRmM2IzIDEwMDY0NA0KPj4+PiAtLS0gYS94
ZW4vaW5jbHVkZS9hc20tYXJtL3BjaS5oDQo+Pj4+ICsrKyBiL3hlbi9pbmNsdWRlL2FzbS1hcm0v
cGNpLmgNCj4+Pj4gQEAgLTE3LDYgKzE3LDggQEANCj4+Pj4gICAgDQo+Pj4+ICAgICNpZmRlZiBD
T05GSUdfSEFTX1BDSQ0KPj4+PiAgICANCj4+Pj4gKyNpbmNsdWRlIDxhc20vcDJtLmg+DQo+Pj4+
ICsNCj4+Pj4gICAgI2RlZmluZSBwY2lfdG9fZGV2KHBjaWRldikgKCYocGNpZGV2KS0+YXJjaC5k
ZXYpDQo+Pj4+ICAgIA0KPj4+PiAgICBleHRlcm4gYm9vbF90IHBjaV9wYXNzdGhyb3VnaF9lbmFi
bGVkOw0KPj4+PiBAQCAtNzMsNiArNzUsOSBAQCBzdHJ1Y3QgcGNpX29wcyB7DQo+Pj4+ICAgICAg
ICAgICAgICAgICAgICB1aW50MzJfdCByZWcsIHVpbnQzMl90IGxlbiwgdWludDMyX3QgKnZhbHVl
KTsNCj4+Pj4gICAgICAgIGludCAoKndyaXRlKShzdHJ1Y3QgcGNpX2hvc3RfYnJpZGdlICpicmlk
Z2UsIHBjaV9zYmRmX3Qgc2JkZiwNCj4+Pj4gICAgICAgICAgICAgICAgICAgICB1aW50MzJfdCBy
ZWcsIHVpbnQzMl90IGxlbiwgdWludDMyX3QgdmFsdWUpOw0KPj4+PiArICAgIGJvb2wgKCpuZWVk
X3AybV9od2RvbV9tYXBwaW5nKShzdHJ1Y3QgZG9tYWluICpkLA0KPj4+PiArICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICBzdHJ1Y3QgcGNpX2hvc3RfYnJpZGdlICpicmlkZ2UsDQo+
Pj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHVpbnQ2NF90IGFkZHIpOw0K
Pj4+PiAgICB9Ow0KPj4+PiAgICANCj4+Pj4gICAgLyoNCj4+Pj4gQEAgLTk2LDYgKzEwMSw5IEBA
IGludCBwY2lfZ2VuZXJpY19jb25maWdfd3JpdGUoc3RydWN0IHBjaV9ob3N0X2JyaWRnZSAqYnJp
ZGdlLCBwY2lfc2JkZl90IHNiZGYsDQo+Pj4+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgdWludDMyX3QgcmVnLCB1aW50MzJfdCBsZW4sIHVpbnQzMl90IHZhbHVlKTsNCj4+Pj4gICAg
dm9pZCBfX2lvbWVtICpwY2lfZWNhbV9tYXBfYnVzKHN0cnVjdCBwY2lfaG9zdF9icmlkZ2UgKmJy
aWRnZSwNCj4+Pj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHBjaV9zYmRmX3Qg
c2JkZiwgdWludDMyX3Qgd2hlcmUpOw0KPj4+PiArYm9vbCBwY2lfZWNhbV9uZWVkX3AybV9od2Rv
bV9tYXBwaW5nKHN0cnVjdCBkb21haW4gKmQsDQo+Pj4+ICsgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgc3RydWN0IHBjaV9ob3N0X2JyaWRnZSAqYnJpZGdlLA0KPj4+PiArICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHVpbnQ2NF90IGFkZHIpOw0KPj4+PiAg
ICBzdHJ1Y3QgcGNpX2hvc3RfYnJpZGdlICpwY2lfZmluZF9ob3N0X2JyaWRnZSh1aW50MTZfdCBz
ZWdtZW50LCB1aW50OF90IGJ1cyk7DQo+Pj4+ICAgIGludCBwY2lfZ2V0X2hvc3RfYnJpZGdlX3Nl
Z21lbnQoY29uc3Qgc3RydWN0IGR0X2RldmljZV9ub2RlICpub2RlLA0KPj4+PiAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgIHVpbnQxNl90ICpzZWdtZW50KTsNCj4+Pj4gQEAgLTEx
Myw2ICsxMjEsOCBAQCBpbnQgcGNpX2hvc3RfaXRlcmF0ZV9icmlkZ2VzKHN0cnVjdCBkb21haW4g
KmQsDQo+Pj4+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBzdHJ1
Y3QgcGNpX2hvc3RfYnJpZGdlICpicmlkZ2UpKTsNCj4+Pj4gICAgaW50IHBjaV9ob3N0X2dldF9u
dW1fYnJpZGdlcyh2b2lkKTsNCj4+Pj4gICAgDQo+Pj4+ICtpbnQgcGNpX2hvc3RfYnJpZGdlX21h
cHBpbmdzKHN0cnVjdCBkb21haW4gKmQsIHAybV90eXBlX3QgcDJtdCk7DQo+Pj4+ICsNCj4+Pj4g
ICAgI2Vsc2UgICAvKiFDT05GSUdfSEFTX1BDSSovDQo+Pj4+ICAgIA0KPj4+PiAgICBzdHJ1Y3Qg
YXJjaF9wY2lfZGV2IHsgfTsNCj4+Pj4gZGlmZiAtLWdpdCBhL3hlbi9pbmNsdWRlL2FzbS1hcm0v
c2V0dXAuaCBiL3hlbi9pbmNsdWRlL2FzbS1hcm0vc2V0dXAuaA0KPj4+PiBpbmRleCA5NWRhMGI3
YWI5Y2QuLjViMzAxMzVmZGEzOCAxMDA2NDQNCj4+Pj4gLS0tIGEveGVuL2luY2x1ZGUvYXNtLWFy
bS9zZXR1cC5oDQo+Pj4+ICsrKyBiL3hlbi9pbmNsdWRlL2FzbS1hcm0vc2V0dXAuaA0KPj4+PiBA
QCAtMiw2ICsyLDggQEANCj4+Pj4gICAgI2RlZmluZSBfX0FSTV9TRVRVUF9IXw0KPj4+PiAgICAN
Cj4+Pj4gICAgI2luY2x1ZGUgPHB1YmxpYy92ZXJzaW9uLmg+DQo+Pj4+ICsjaW5jbHVkZSA8YXNt
L3AybS5oPg0KPj4+PiArI2luY2x1ZGUgPHhlbi9kZXZpY2VfdHJlZS5oPg0KPj4+PiAgICANCj4+
Pj4gICAgI2RlZmluZSBNSU5fRkRUX0FMSUdOIDgNCj4+Pj4gICAgI2RlZmluZSBNQVhfRkRUX1NJ
WkUgU1pfMk0NCj4+Pj4gQEAgLTc3LDYgKzc5LDE0IEBAIHN0cnVjdCBib290aW5mbyB7DQo+Pj4+
ICAgICNlbmRpZg0KPj4+PiAgICB9Ow0KPj4+PiAgICANCj4+Pj4gK3N0cnVjdCBtYXBfcmFuZ2Vf
ZGF0YQ0KPj4+PiArew0KPj4+PiArICAgIHN0cnVjdCBkb21haW4gKmQ7DQo+Pj4+ICsgICAgcDJt
X3R5cGVfdCBwMm10Ow0KPj4+PiArICAgIC8qIFNldCBpZiBtYXBwaW5ncyBmb3IgUENJIGhvc3Qg
YnJpZGdlcyBtdXN0IG5vdCBiZSBza2lwcGVkLiAqLw0KPj4+IFRoaXMgY29tbWVudCBzdGlsbCBu
ZWVkcyB1cGRhdGluZy4NCj4+IFNvcnJ5LCBJIG1pc3NlZCB0aGlzIG9uZQ0KPj4+DQo+Pj4+ICsg
ICAgYm9vbCBza2lwX21hcHBpbmc7DQo+Pj4+ICt9Ow0KPj4+PiArDQo+Pj4+ICAgIGV4dGVybiBz
dHJ1Y3QgYm9vdGluZm8gYm9vdGluZm87DQo+Pj4+ICAgIA0KPj4+PiAgICBleHRlcm4gZG9taWRf
dCBtYXhfaW5pdF9kb21pZDsNCj4+Pj4gQEAgLTEyNCw2ICsxMzQsOSBAQCB2b2lkIGRldmljZV90
cmVlX2dldF9yZWcoY29uc3QgX19iZTMyICoqY2VsbCwgdTMyIGFkZHJlc3NfY2VsbHMsDQo+Pj4+
ICAgIHUzMiBkZXZpY2VfdHJlZV9nZXRfdTMyKGNvbnN0IHZvaWQgKmZkdCwgaW50IG5vZGUsDQo+
Pj4+ICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNvbnN0IGNoYXIgKnByb3BfbmFtZSwgdTMy
IGRmbHQpOw0KPj4+PiAgICANCj4+Pj4gK2ludCBtYXBfcmFuZ2VfdG9fZG9tYWluKGNvbnN0IHN0
cnVjdCBkdF9kZXZpY2Vfbm9kZSAqZGV2LA0KPj4+PiArICAgICAgICAgICAgICAgICAgICAgICAg
dTY0IGFkZHIsIHU2NCBsZW4sIHZvaWQgKmRhdGEpOw0KPj4+PiArDQo+Pj4+ICAgICNlbmRpZg0K
Pj4+PiAgICAvKg0KPj4+PiAgICAgKiBMb2NhbCB2YXJpYWJsZXM6DQo+Pj4+IC0tIA0KPj4+PiAy
LjI1LjENCj4+Pj4NCg==


From xen-devel-bounces@lists.xenproject.org Wed Oct 06 05:58:36 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Oct 2021 05:58:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.202614.357593 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXzwX-0000kQ-7y; Wed, 06 Oct 2021 05:58:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 202614.357593; Wed, 06 Oct 2021 05:58:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mXzwX-0000kJ-4r; Wed, 06 Oct 2021 05:58:17 +0000
Received: by outflank-mailman (input) for mailman id 202614;
 Wed, 06 Oct 2021 05:58:16 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mXzwW-0000k9-2u; Wed, 06 Oct 2021 05:58:16 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mXzwV-0004DM-Si; Wed, 06 Oct 2021 05:58:15 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mXzwV-00038v-Ka; Wed, 06 Oct 2021 05:58:15 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mXzwV-0005h6-Hk; Wed, 06 Oct 2021 05:58:15 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=wKvA4hR6srM0IUEaOa4YeSIJ0VfBViBW9+L/yM+KpTw=; b=BUQXN3qJtdiDATc2Hbx5BDoLVe
	NaiJkajJtxfT30/GK5B5vj8iyLmdDC2ygljkM8w5ZhUsRVPi0Qh29eVXyJHlVgFrWmH6BYulnjaYj
	Z4rOrv2bjwLRC4HC8tkgtfaray7C5UJqA1WOc1C6IPxlg2YeVMsT1u5Td9g4ci/jTGXY=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165382-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 165382: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=942c9bd357d87cc6eed7c8250c213eff218d674e
X-Osstest-Versions-That:
    ovmf=c49cb8f30e6223dc6b55903af178afa1dfde857f
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 06 Oct 2021 05:58:15 +0000

flight 165382 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165382/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 942c9bd357d87cc6eed7c8250c213eff218d674e
baseline version:
 ovmf                 c49cb8f30e6223dc6b55903af178afa1dfde857f

Last test of basis   165377  2021-10-05 09:40:15 Z    0 days
Testing same since   165382  2021-10-05 18:11:18 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Chris Jones <christopher.jones@arm.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Jiewen Yao <Jiewen.yao@intel.com>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Berger <stefanb@linux.vnet.ibm.com>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   c49cb8f30e..942c9bd357  942c9bd357d87cc6eed7c8250c213eff218d674e -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Wed Oct 06 06:20:03 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Oct 2021 06:20:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.202624.357607 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mY0HV-0003Gw-1U; Wed, 06 Oct 2021 06:19:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 202624.357607; Wed, 06 Oct 2021 06:19:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mY0HU-0003Gp-UQ; Wed, 06 Oct 2021 06:19:56 +0000
Received: by outflank-mailman (input) for mailman id 202624;
 Wed, 06 Oct 2021 06:19:55 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=xI/c=O2=suse.com=jgross@srs-us1.protection.inumbo.net>)
 id 1mY0HT-0003Gg-Ha
 for xen-devel@lists.xenproject.org; Wed, 06 Oct 2021 06:19:55 +0000
Received: from smtp-out1.suse.de (unknown [195.135.220.28])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 5f7ec06c-4b4d-4303-873d-9b48fc30823e;
 Wed, 06 Oct 2021 06:19:54 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 8C6A622470;
 Wed,  6 Oct 2021 06:19:53 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 34CED13DF0;
 Wed,  6 Oct 2021 06:19:53 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id URSDCwlAXWGebAAAMHmgww
 (envelope-from <jgross@suse.com>); Wed, 06 Oct 2021 06:19:53 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5f7ec06c-4b4d-4303-873d-9b48fc30823e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1633501193; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:  content-transfer-encoding:content-transfer-encoding;
	bh=OEUzqfY9J3CJj8oYNpzjv2N/kxiY+V/QZvH33Q4Al1A=;
	b=iRZshKpiC7wF4aJj5AuGpMoKfhXQsUwB/PQWxgWHbFgtCRQFLYg1DoTtWDS8kxwUdPPK0j
	pvoYqwcdODu5OzsKZj0f9BjgRvVWgW0CXV8TQALMuH+bSDAccnaTbtFUDGNGPy1K4A2pZg
	w5dEBFIakM8iMcUprtaHxXfjg7YXLyQ=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org,
	x86@kernel.org,
	linux-kernel@vger.kernel.org
Cc: Juergen Gross <jgross@suse.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	"H. Peter Anvin" <hpa@zytor.com>,
	kernel test robot <lkp@intel.com>
Subject: [PATCH] x86/pvh: add prototype for xen_pvh_init()
Date: Wed,  6 Oct 2021 08:19:50 +0200
Message-Id: <20211006061950.9227-1-jgross@suse.com>
X-Mailer: git-send-email 2.26.2
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

xen_pvh_init() is lacking a prototype in a header, add it.

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Juergen Gross <jgross@suse.com>
---
 arch/x86/include/asm/xen/hypervisor.h | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/x86/include/asm/xen/hypervisor.h b/arch/x86/include/asm/xen/hypervisor.h
index ff4b52e37e60..4957f59deb40 100644
--- a/arch/x86/include/asm/xen/hypervisor.h
+++ b/arch/x86/include/asm/xen/hypervisor.h
@@ -62,4 +62,8 @@ void xen_arch_register_cpu(int num);
 void xen_arch_unregister_cpu(int num);
 #endif
 
+#ifdef CONFIG_PVH
+void __init xen_pvh_init(struct boot_params *boot_params);
+#endif
+
 #endif /* _ASM_X86_XEN_HYPERVISOR_H */
-- 
2.26.2



From xen-devel-bounces@lists.xenproject.org Wed Oct 06 09:45:32 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Oct 2021 09:45:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.202639.357621 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mY3U9-0006Jm-1L; Wed, 06 Oct 2021 09:45:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 202639.357621; Wed, 06 Oct 2021 09:45:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mY3U8-0006Jf-To; Wed, 06 Oct 2021 09:45:12 +0000
Received: by outflank-mailman (input) for mailman id 202639;
 Wed, 06 Oct 2021 09:45:11 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=13oh=O2=arm.com=Rahul.Singh@srs-us1.protection.inumbo.net>)
 id 1mY3U7-0006JY-6T
 for xen-devel@lists.xenproject.org; Wed, 06 Oct 2021 09:45:11 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com (unknown
 [40.107.21.73]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id ade774a0-f274-48ad-a5cd-5e8d0ec0aae3;
 Wed, 06 Oct 2021 09:45:03 +0000 (UTC)
Received: from DB7PR05CA0038.eurprd05.prod.outlook.com (2603:10a6:10:2e::15)
 by AS8PR08MB6344.eurprd08.prod.outlook.com (2603:10a6:20b:319::9) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18; Wed, 6 Oct
 2021 09:44:57 +0000
Received: from DB5EUR03FT063.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:10:2e:cafe::6) by DB7PR05CA0038.outlook.office365.com
 (2603:10a6:10:2e::15) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18 via Frontend
 Transport; Wed, 6 Oct 2021 09:44:57 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT063.mail.protection.outlook.com (10.152.20.209) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4566.14 via Frontend Transport; Wed, 6 Oct 2021 09:44:57 +0000
Received: ("Tessian outbound 8e26f7114b75:v103");
 Wed, 06 Oct 2021 09:44:57 +0000
Received: from cb5c978a3371.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 4675C79D-FE74-4100-B977-3926A3796B04.1; 
 Wed, 06 Oct 2021 09:44:47 +0000
Received: from EUR03-VE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id cb5c978a3371.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Wed, 06 Oct 2021 09:44:47 +0000
Received: from AS8PR08MB6919.eurprd08.prod.outlook.com (2603:10a6:20b:39e::10)
 by AM6PR08MB3815.eurprd08.prod.outlook.com (2603:10a6:20b:8b::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.22; Wed, 6 Oct
 2021 09:44:45 +0000
Received: from AS8PR08MB6919.eurprd08.prod.outlook.com
 ([fe80::51ee:e7de:6c0a:bcf9]) by AS8PR08MB6919.eurprd08.prod.outlook.com
 ([fe80::51ee:e7de:6c0a:bcf9%7]) with mapi id 15.20.4566.023; Wed, 6 Oct 2021
 09:44:44 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ade774a0-f274-48ad-a5cd-5e8d0ec0aae3
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=gfHafwUG2cJRf8ZqsOZq5pZznIXStl5jEM5SUyepV58=;
 b=UhkgxkAICqmuDQrg3wsJbbX19z2ZF/PPzsiw0Hb3d3Vsdsm+srDrpOu1lRcq99RhMmLKVGRg5Qezbgr3kGBWUhMQHSYfezThMqN/EA5tXXZXLelFTzXcr1KGSko2lNI4OxxbkxTlef47nhflwtNWjTyde0REQCi90ZkEBt/PCmM=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 2de6800ed73df552
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=PkohxhQxaCN/DvPDv149AvNLolLDwssWvZNXl8IcpXvofMjuLzaViUJzywkslwdyDIgkTJtgqpzzjvXYvuliPQR88w5qNTJznT5dFMPQ9BdCsBqNXRJ73OzfauhBVy0BBE+Z+rFmz+bYFj/t9vkC8Mrc3pc4Fv7ylukTZ9/gtEJ/AhhulcgiHKdL1wW51SNpsHqiAPiJR+nuwXgKfFWQpqU4i/I2GpJwKVYRTJPHSPPk3PeXULA2WH6FhUOMglBRguavf8KatEG4q4APLqTCvgO6edm1pDW6CINCM9wrkU28gb4s51uIcXLPKtOKcAgjk8PHHVpOGDncwJyQtcJBeg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=gfHafwUG2cJRf8ZqsOZq5pZznIXStl5jEM5SUyepV58=;
 b=oQXQ66qnJW588isOb9bF7MC0k2ZvgoOtcJJDICihXguw7FFp2kg/eq+5ecX1fiNWodMb5yDi462LO48Mk5raI5zLjct6Vk+u2gmx6vuHIfNMkMi4qp+amkK3w8BloiDpZLBeH0Q7Sw/4RMURhsHakMsmm4shaNcC4IUQizbgA36tmZqDZ1t8sHVanltuaeOKGETn+P1emvA9063zm6NewwbytttXuTlyBaQsFMbLQStcvIPpEtwQjwlyS792piuHVbi4e7k97lF4oIMYuAvOgU/j3ptdUw2bYA4qz1b51CtmvxYeQJPIsr8kki6aroc5y9e8qnmb8GW+xwTxp6Uoow==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=gfHafwUG2cJRf8ZqsOZq5pZznIXStl5jEM5SUyepV58=;
 b=UhkgxkAICqmuDQrg3wsJbbX19z2ZF/PPzsiw0Hb3d3Vsdsm+srDrpOu1lRcq99RhMmLKVGRg5Qezbgr3kGBWUhMQHSYfezThMqN/EA5tXXZXLelFTzXcr1KGSko2lNI4OxxbkxTlef47nhflwtNWjTyde0REQCi90ZkEBt/PCmM=
From: Rahul Singh <Rahul.Singh@arm.com>
To: Stefano Stabellini <sstabellini@kernel.org>
CC: xen-devel <xen-devel@lists.xenproject.org>, Bertrand Marquis
	<Bertrand.Marquis@arm.com>, Andre Przywara <Andre.Przywara@arm.com>, Ian
 Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>, Anthony PERARD
	<anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>, Julien Grall
	<julien@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH v4 13/14] arm/libxl: Emulated PCI device tree node in
 libxl
Thread-Topic: [PATCH v4 13/14] arm/libxl: Emulated PCI device tree node in
 libxl
Thread-Index: AQHXuRciClWhjFX7R0aQhsW/aixhyqvDkJEAgACf3oCAAL5hgIAAzJaA
Date: Wed, 6 Oct 2021 09:44:44 +0000
Message-ID: <8B848F95-977F-4DF4-B315-CFEA610BC1C3@arm.com>
References: <cover.1633340795.git.rahul.singh@arm.com>
 <3ad42008f534671ae7f5b25da91253ce7cd4a3e9.1633340795.git.rahul.singh@arm.com>
 <alpine.DEB.2.21.2110041714410.3209@sstabellini-ThinkPad-T480s>
 <11F169C6-39A4-40F3-8E75-39B8C2CCF022@arm.com>
 <alpine.DEB.2.21.2110051421520.3209@sstabellini-ThinkPad-T480s>
In-Reply-To: <alpine.DEB.2.21.2110051421520.3209@sstabellini-ThinkPad-T480s>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
Authentication-Results-Original: kernel.org; dkim=none (message not signed)
 header.d=none;kernel.org; dmarc=none action=none header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: 7a1d84fa-2b34-47e1-01ee-08d988adf529
x-ms-traffictypediagnostic: AM6PR08MB3815:|AS8PR08MB6344:
x-ms-exchange-transport-forked: True
X-Microsoft-Antispam-PRVS:
	<AS8PR08MB6344F9DBBC86AF4158169578FCB09@AS8PR08MB6344.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:10000;OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 ru7D1JnJPgkTOxifyBPwZ5kW1+BopPeUmjV1UFVV7lBtDS5r6EmDeaRYqVcjjG5Ns95zxWSLGJCaVah78vBlEl9IsqCJPkjETHtLCe3t+NYuRzdBCxHwSFWoEg+ta9F0Wn39ry0KOJO2SfVgDNtL7V1lIZ1vYnoKDA1mQVKDhwjyColVHhxyxC32I+tcxVhIgPWx3gT492KOwIuk9s0P9meXCywJoI63Rq3b8UamMGM6l4fdst/UyzrGjuAGKEmVhanHtRL2NcvFt1k8anXitV0Mvv8EvvjhP2Zevs5SBxJMPqlTEp+xtsOBs1QF6joc4FDPLkS1tdGHJtKajud/7bqQSpo1k28Qo1lsL+w4DN/el1ZWBXTwRbL+8gDbSQ8j7WQoeYxWoTgawiDI5bCXf/kRRUYSM7m1Qw1UIzmkEpkRidRjHElvYM8la3Dx+zVM8BfShUdtHMiz69GbY/fNusj/bbYA2BF3R97neDvZNGuaTi+hTGJ9HK9SyhqmUKSRAp9w9ZMNrFd92Fn+CdnSKnZJ0qh+vY2PhCFeiDwf7Okn7oIbz3HKnkXuvQ3grJtJo9V0Lg5xGQZI0tEwF6a9wsFu/nxXd7yqnWN8r3iJOsu42BW0kKZtgeLT4DZhTofMJuhn9nNZes+5H8NjiWxqJHPNOsuduPPJLo7rK1wABwdWwKaDS61vix0kfoms/CnvcDGN2YDiP+KEOdfeqro3AGWN9zz25TSAiNcd3TrprCTASpj2Jmy8AVBjlFtWhPUJ
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6919.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(6506007)(53546011)(4326008)(316002)(8936002)(71200400001)(2906002)(38070700005)(76116006)(91956017)(508600001)(26005)(66446008)(2616005)(36756003)(66556008)(66476007)(6512007)(186003)(66946007)(64756008)(122000001)(83380400001)(5660300002)(38100700002)(6486002)(30864003)(8676002)(33656002)(6916009)(86362001)(54906003)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-ID: <2F6F0C4E2FC48E45824E2C55633A08AD@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3815
Original-Authentication-Results: kernel.org; dkim=none (message not signed)
 header.d=none;kernel.org; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT063.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	e6b5cbab-a0a6-486c-a925-08d988adedb2
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	RvVyp+hIs5jd2Ci7+XW+vCuka1SKzOScFq3Lf6M4L2gu7bozejZLsDNwCn430G36VudpaUT7dP9S/JYkBRwBLGsws9GcFgrcYvOcY4zWnaWFVALu3L3ENvut7xrzPCkS4irPSyjVCK9YFnu+z12QcDsb0iFP8FZ04R3uQpxQ9RC7r325xMjo3lC90AtPZ/+XulGS0YRWSfghgUtGGqNoXlsb8Ia/XrlNzh3rbYqtcdPElE84Oig5zqwq0sVrk7NCxTqrxCcvg7JbX5RpoVWZWCH6iC1+QX1Kcw+BWLXJ7TIQfQQ31FFt/cJ8GoQvPhIRtt/HV1gjqpq6/kgUTlj1YrVd7j/IFpu7W68OAuGteVMwOlSnqQ7BTgBLyrjpjxJQ6kpoR7Bf45Wu4TbgrnA6TUlVGtLZnN4QpkflnR+C76chZszKRu0NcgQYWjB3ElnX/wbOlq4d726pHOnBmrWUqD+py0xTeqGKjUbWkdPsYcJrEnKHVqytJfXByUvmcyVY1fjPzlZzgUWk6VlZ+eXIc0Kf2thGZxU5jg7/bBXGOJn0/lL98EEktxT6TMgEDDM/3PWTH4kSTuGt4lO765gJbF19awoqef/YzyWNlsEj509Efy5Im5QeXvjggdfHQ+wyyRZSr8ag3PO+YilL0eS5G6Sm1JWkGxPxbv+F5QwkS+sVd+IufQsDWx8JXD3/9ddgZdHO9eOnju8cP9p9AsCtYA==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(5660300002)(30864003)(83380400001)(508600001)(6512007)(2616005)(107886003)(26005)(186003)(6862004)(8676002)(4326008)(82310400003)(53546011)(6506007)(316002)(54906003)(36756003)(8936002)(336012)(6486002)(33656002)(36860700001)(81166007)(356005)(70206006)(47076005)(2906002)(86362001)(70586007);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Oct 2021 09:44:57.3381
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 7a1d84fa-2b34-47e1-01ee-08d988adf529
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT063.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6344

SGkgU3RlZmFubywNCg0KPiBPbiA1IE9jdCAyMDIxLCBhdCAxMDozMiBwbSwgU3RlZmFubyBTdGFi
ZWxsaW5pIDxzc3RhYmVsbGluaUBrZXJuZWwub3JnPiB3cm90ZToNCj4gDQo+IE9uIFR1ZSwgNSBP
Y3QgMjAyMSwgUmFodWwgU2luZ2ggd3JvdGU6DQo+Pj4gT24gNSBPY3QgMjAyMSwgYXQgMTozOCBh
bSwgU3RlZmFubyBTdGFiZWxsaW5pIDxzc3RhYmVsbGluaUBrZXJuZWwub3JnPiB3cm90ZToNCj4+
PiANCj4+PiBPbiBNb24sIDQgT2N0IDIwMjEsIFJhaHVsIFNpbmdoIHdyb3RlOg0KPj4+PiBsaWJ4
bCB3aWxsIGNyZWF0ZSBhbiBlbXVsYXRlZCBQQ0kgZGV2aWNlIHRyZWUgbm9kZSBpbiB0aGUgZGV2
aWNlIHRyZWUgdG8NCj4+Pj4gZW5hYmxlIHRoZSBndWVzdCBPUyB0byBkaXNjb3ZlciB0aGUgdmly
dHVhbCBQQ0kgZHVyaW5nIGd1ZXN0IGJvb3QuDQo+Pj4+IEVtdWxhdGVkIFBDSSBkZXZpY2UgdHJl
ZSBub2RlIHdpbGwgb25seSBiZSBjcmVhdGVkIHdoZW4gdGhlcmUgaXMgYW55DQo+Pj4+IGRldmlj
ZSBhc3NpZ25lZCB0byBndWVzdC4NCj4+Pj4gDQo+Pj4+IEEgbmV3IGFyZWEgaGFzIGJlZW4gcmVz
ZXJ2ZWQgaW4gdGhlIGFybSBndWVzdCBwaHlzaWNhbCBtYXAgYXQNCj4+Pj4gd2hpY2ggdGhlIFZQ
Q0kgYnVzIGlzIGRlY2xhcmVkIGluIHRoZSBkZXZpY2UgdHJlZSAocmVnIGFuZCByYW5nZXMNCj4+
Pj4gcGFyYW1ldGVycyBvZiB0aGUgbm9kZSkuDQo+Pj4+IA0KPj4+PiBTaWduZWQtb2ZmLWJ5OiBS
YWh1bCBTaW5naCA8cmFodWwuc2luZ2hAYXJtLmNvbT4NCj4+Pj4gLS0tDQo+Pj4+IENoYW5nZSBp
biB2NDoNCj4+Pj4gLSBHYXRlIGNvZGUgZm9yIHg4NiBmb3Igc2V0dGluZyB0aGUgWEVOX0RPTUNU
TF9DREZfdnBjaSBmb3IgeDg2Lg0KPj4+PiBDaGFuZ2UgaW4gdjM6DQo+Pj4+IC0gTWFrZSBHVUVT
VF9WUENJX01FTV9BRERSIGFkZHJlc3MgMk1CIGFsaWduZWQNCj4+Pj4gQ2hhbmdlIGluIHYyOg0K
Pj4+PiAtIGVuYWJsZSBkb2FtaW5fdnBjaV9pbml0KCkgd2hlbiBYRU5fRE9NQ1RMX0NERl92cGNp
IGlzIHNldCBmb3IgZG9tYWluLg0KPj4+PiAtLS0NCj4+Pj4gLS0tDQo+Pj4+IHRvb2xzL2luY2x1
ZGUvbGlieGwuaCAgICAgICAgICAgIHwgICA2ICsrDQo+Pj4+IHRvb2xzL2xpYnMvbGlnaHQvbGli
eGxfYXJtLmMgICAgIHwgMTA1ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysNCj4+Pj4g
dG9vbHMvbGlicy9saWdodC9saWJ4bF9jcmVhdGUuYyAgfCAgIDkgKysrDQo+Pj4+IHRvb2xzL2xp
YnMvbGlnaHQvbGlieGxfdHlwZXMuaWRsIHwgICAxICsNCj4+Pj4gdG9vbHMveGwveGxfcGFyc2Uu
YyAgICAgICAgICAgICAgfCAgIDggKysrDQo+Pj4+IHhlbi9pbmNsdWRlL3B1YmxpYy9hcmNoLWFy
bS5oICAgIHwgIDEwICsrKw0KPj4+PiA2IGZpbGVzIGNoYW5nZWQsIDEzOSBpbnNlcnRpb25zKCsp
DQo+Pj4+IA0KPj4+PiBkaWZmIC0tZ2l0IGEvdG9vbHMvaW5jbHVkZS9saWJ4bC5oIGIvdG9vbHMv
aW5jbHVkZS9saWJ4bC5oDQo+Pj4+IGluZGV4IGI5YmExNmQ2OTguLjMzNjIwNzNiMjEgMTAwNjQ0
DQo+Pj4+IC0tLSBhL3Rvb2xzL2luY2x1ZGUvbGlieGwuaA0KPj4+PiArKysgYi90b29scy9pbmNs
dWRlL2xpYnhsLmgNCj4+Pj4gQEAgLTM1OCw2ICszNTgsMTIgQEANCj4+Pj4gKi8NCj4+Pj4gI2Rl
ZmluZSBMSUJYTF9IQVZFX0JVSUxESU5GT19BUk1fVlVBUlQgMQ0KPj4+PiANCj4+Pj4gKy8qDQo+
Pj4+ICsgKiBMSUJYTF9IQVZFX0JVSUxESU5GT19BUk1fVlBDSSBpbmRpY2F0ZXMgdGhhdCB0aGUg
dG9vbHN0YWNrIHN1cHBvcnRzIHZpcnR1YWwNCj4+Pj4gKyAqIFBDSSBmb3IgQVJNLg0KPj4+PiAr
ICovDQo+Pj4+ICsjZGVmaW5lIExJQlhMX0hBVkVfQlVJTERJTkZPX0FSTV9WUENJIDENCj4+Pj4g
Kw0KPj4+PiAvKg0KPj4+PiAqIExJQlhMX0hBVkVfQlVJTERJTkZPX0dSQU5UX0xJTUlUUyBpbmRp
Y2F0ZXMgdGhhdCBsaWJ4bF9kb21haW5fYnVpbGRfaW5mbw0KPj4+PiAqIGhhcyB0aGUgbWF4X2dy
YW50X2ZyYW1lcyBhbmQgbWF4X21hcHRyYWNrX2ZyYW1lcyBmaWVsZHMuDQo+Pj4+IGRpZmYgLS1n
aXQgYS90b29scy9saWJzL2xpZ2h0L2xpYnhsX2FybS5jIGIvdG9vbHMvbGlicy9saWdodC9saWJ4
bF9hcm0uYw0KPj4+PiBpbmRleCBlMzE0MGE2ZTAwLi41MmYxZGRjZTQ4IDEwMDY0NA0KPj4+PiAt
LS0gYS90b29scy9saWJzL2xpZ2h0L2xpYnhsX2FybS5jDQo+Pj4+ICsrKyBiL3Rvb2xzL2xpYnMv
bGlnaHQvbGlieGxfYXJtLmMNCj4+Pj4gQEAgLTI2OSw2ICsyNjksNTggQEAgc3RhdGljIGludCBm
ZHRfcHJvcGVydHlfcmVncyhsaWJ4bF9fZ2MgKmdjLCB2b2lkICpmZHQsDQo+Pj4+ICAgIHJldHVy
biBmZHRfcHJvcGVydHkoZmR0LCAicmVnIiwgcmVncywgc2l6ZW9mKHJlZ3MpKTsNCj4+Pj4gfQ0K
Pj4+PiANCj4+Pj4gK3N0YXRpYyBpbnQgZmR0X3Byb3BlcnR5X3ZhbHVlcyhsaWJ4bF9fZ2MgKmdj
LCB2b2lkICpmZHQsDQo+Pj4+ICsgICAgICAgIGNvbnN0IGNoYXIgKm5hbWUsIHVuc2lnbmVkIG51
bV9jZWxscywgLi4uKQ0KPj4+PiArew0KPj4+PiArICAgIHVpbnQzMl90IHByb3BbbnVtX2NlbGxz
XTsNCj4+Pj4gKyAgICBiZTMyICpjZWxscyA9ICZwcm9wWzBdOw0KPj4+PiArICAgIGludCBpOw0K
Pj4+PiArICAgIHZhX2xpc3QgYXA7DQo+Pj4+ICsgICAgdWludDMyX3QgYXJnOw0KPj4+PiArDQo+
Pj4+ICsgICAgdmFfc3RhcnQoYXAsIG51bV9jZWxscyk7DQo+Pj4+ICsgICAgZm9yIChpID0gMCA7
IGkgPCBudW1fY2VsbHM7IGkrKykgew0KPj4+PiArICAgICAgICBhcmcgPSB2YV9hcmcoYXAsIHVp
bnQzMl90KTsNCj4+Pj4gKyAgICAgICAgc2V0X2NlbGwoJmNlbGxzLCAxLCBhcmcpOw0KPj4+PiAr
ICAgIH0NCj4+Pj4gKyAgICB2YV9lbmQoYXApOw0KPj4+PiArDQo+Pj4+ICsgICAgcmV0dXJuIGZk
dF9wcm9wZXJ0eShmZHQsIG5hbWUsIHByb3AsIHNpemVvZihwcm9wKSk7DQo+Pj4+ICt9DQo+Pj4+
ICsNCj4+Pj4gK3N0YXRpYyBpbnQgZmR0X3Byb3BlcnR5X3ZwY2lfcmFuZ2VzKGxpYnhsX19nYyAq
Z2MsIHZvaWQgKmZkdCwNCj4+Pj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
IHVuc2lnbmVkIGFkZHJfY2VsbHMsDQo+Pj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICB1bnNpZ25lZCBzaXplX2NlbGxzLA0KPj4+PiArICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgdW5zaWduZWQgbnVtX3JlZ3MsIC4uLikNCj4+Pj4gK3sNCj4+Pj4gKyAg
ICB1aW50MzJfdCByZWdzW251bV9yZWdzKigoYWRkcl9jZWxscyoyKStzaXplX2NlbGxzKzEpXTsN
Cj4+Pj4gKyAgICBiZTMyICpjZWxscyA9ICZyZWdzWzBdOw0KPj4+PiArICAgIGludCBpOw0KPj4+
PiArICAgIHZhX2xpc3QgYXA7DQo+Pj4+ICsgICAgdWludDY0X3QgYXJnOw0KPj4+PiArDQo+Pj4+
ICsgICAgdmFfc3RhcnQoYXAsIG51bV9yZWdzKTsNCj4+Pj4gKyAgICBmb3IgKGkgPSAwIDsgaSA8
IG51bV9yZWdzOyBpKyspIHsNCj4+Pj4gKyAgICAgICAgLyogU2V0IHRoZSBtZW1vcnkgYml0IGZp
ZWxkICovDQo+Pj4+ICsgICAgICAgIGFyZyA9IHZhX2FyZyhhcCwgdWludDMyX3QpOw0KPj4+PiAr
ICAgICAgICBzZXRfY2VsbCgmY2VsbHMsIDEsIGFyZyk7DQo+Pj4+ICsNCj4+Pj4gKyAgICAgICAg
LyogU2V0IHRoZSB2cGNpIGJ1cyBhZGRyZXNzICovDQo+Pj4+ICsgICAgICAgIGFyZyA9IGFkZHJf
Y2VsbHMgPyB2YV9hcmcoYXAsIHVpbnQ2NF90KSA6IDA7DQo+Pj4+ICsgICAgICAgIHNldF9jZWxs
KCZjZWxscywgYWRkcl9jZWxscyAsIGFyZyk7DQo+Pj4+ICsNCj4+Pj4gKyAgICAgICAgLyogU2V0
IHRoZSBjcHUgYnVzIGFkZHJlc3Mgd2hlcmUgdnBjaSBhZGRyZXNzIGlzIG1hcHBlZCAqLw0KPj4+
PiArICAgICAgICBzZXRfY2VsbCgmY2VsbHMsIGFkZHJfY2VsbHMsIGFyZyk7DQo+Pj4+ICsNCj4+
Pj4gKyAgICAgICAgLyogU2V0IHRoZSB2cGNpIHNpemUgcmVxdWVzdGVkICovDQo+Pj4+ICsgICAg
ICAgIGFyZyA9IHNpemVfY2VsbHMgPyB2YV9hcmcoYXAsIHVpbnQ2NF90KSA6IDA7DQo+Pj4+ICsg
ICAgICAgIHNldF9jZWxsKCZjZWxscywgc2l6ZV9jZWxscywgYXJnKTsNCj4+Pj4gKyAgICB9DQo+
Pj4+ICsgICAgdmFfZW5kKGFwKTsNCj4+Pj4gKw0KPj4+PiArICAgIHJldHVybiBmZHRfcHJvcGVy
dHkoZmR0LCAicmFuZ2VzIiwgcmVncywgc2l6ZW9mKHJlZ3MpKTsNCj4+Pj4gK30NCj4+Pj4gKw0K
Pj4+PiBzdGF0aWMgaW50IG1ha2Vfcm9vdF9wcm9wZXJ0aWVzKGxpYnhsX19nYyAqZ2MsDQo+Pj4+
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjb25zdCBsaWJ4bF92ZXJzaW9uX2luZm8g
KnZlcnMsDQo+Pj4+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB2b2lkICpmZHQpDQo+
Pj4+IEBAIC02NjgsNiArNzIwLDUzIEBAIHN0YXRpYyBpbnQgbWFrZV92cGwwMTFfdWFydF9ub2Rl
KGxpYnhsX19nYyAqZ2MsIHZvaWQgKmZkdCwNCj4+Pj4gICAgcmV0dXJuIDA7DQo+Pj4+IH0NCj4+
Pj4gDQo+Pj4+ICtzdGF0aWMgaW50IG1ha2VfdnBjaV9ub2RlKGxpYnhsX19nYyAqZ2MsIHZvaWQg
KmZkdCwNCj4+Pj4gKyAgICAgICAgY29uc3Qgc3RydWN0IGFyY2hfaW5mbyAqYWluZm8sDQo+Pj4+
ICsgICAgICAgIHN0cnVjdCB4Y19kb21faW1hZ2UgKmRvbSkNCj4+Pj4gK3sNCj4+Pj4gKyAgICBp
bnQgcmVzOw0KPj4+PiArICAgIGNvbnN0IHVpbnQ2NF90IHZwY2lfZWNhbV9iYXNlID0gR1VFU1Rf
VlBDSV9FQ0FNX0JBU0U7DQo+Pj4+ICsgICAgY29uc3QgdWludDY0X3QgdnBjaV9lY2FtX3NpemUg
PSBHVUVTVF9WUENJX0VDQU1fU0laRTsNCj4+Pj4gKyAgICBjb25zdCBjaGFyICpuYW1lID0gR0NT
UFJJTlRGKCJwY2llQCUiUFJJeDY0LCB2cGNpX2VjYW1fYmFzZSk7DQo+Pj4+ICsNCj4+Pj4gKyAg
ICByZXMgPSBmZHRfYmVnaW5fbm9kZShmZHQsIG5hbWUpOw0KPj4+PiArICAgIGlmIChyZXMpIHJl
dHVybiByZXM7DQo+Pj4+ICsNCj4+Pj4gKyAgICByZXMgPSBmZHRfcHJvcGVydHlfY29tcGF0KGdj
LCBmZHQsIDEsICJwY2ktaG9zdC1lY2FtLWdlbmVyaWMiKTsNCj4+Pj4gKyAgICBpZiAocmVzKSBy
ZXR1cm4gcmVzOw0KPj4+PiArDQo+Pj4+ICsgICAgcmVzID0gZmR0X3Byb3BlcnR5X3N0cmluZyhm
ZHQsICJkZXZpY2VfdHlwZSIsICJwY2kiKTsNCj4+Pj4gKyAgICBpZiAocmVzKSByZXR1cm4gcmVz
Ow0KPj4+PiArDQo+Pj4+ICsgICAgcmVzID0gZmR0X3Byb3BlcnR5X3JlZ3MoZ2MsIGZkdCwgR1VF
U1RfUk9PVF9BRERSRVNTX0NFTExTLA0KPj4+PiArICAgICAgICAgICAgR1VFU1RfUk9PVF9TSVpF
X0NFTExTLCAxLCB2cGNpX2VjYW1fYmFzZSwgdnBjaV9lY2FtX3NpemUpOw0KPj4+PiArICAgIGlm
IChyZXMpIHJldHVybiByZXM7DQo+Pj4+ICsNCj4+Pj4gKyAgICByZXMgPSBmZHRfcHJvcGVydHlf
dmFsdWVzKGdjLCBmZHQsICJidXMtcmFuZ2UiLCAyLCAwLCAyNTUpOw0KPj4+PiArICAgIGlmIChy
ZXMpIHJldHVybiByZXM7DQo+Pj4+ICsNCj4+Pj4gKyAgICByZXMgPSBmZHRfcHJvcGVydHlfY2Vs
bChmZHQsICIjYWRkcmVzcy1jZWxscyIsIDMpOw0KPj4+PiArICAgIGlmIChyZXMpIHJldHVybiBy
ZXM7DQo+Pj4+ICsNCj4+Pj4gKyAgICByZXMgPSBmZHRfcHJvcGVydHlfY2VsbChmZHQsICIjc2l6
ZS1jZWxscyIsIDIpOw0KPj4+PiArICAgIGlmIChyZXMpIHJldHVybiByZXM7DQo+Pj4+ICsNCj4+
Pj4gKyAgICByZXMgPSBmZHRfcHJvcGVydHlfc3RyaW5nKGZkdCwgInN0YXR1cyIsICJva2F5Iik7
DQo+Pj4+ICsgICAgaWYgKHJlcykgcmV0dXJuIHJlczsNCj4+Pj4gKw0KPj4+PiArICAgIHJlcyA9
IGZkdF9wcm9wZXJ0eV92cGNpX3JhbmdlcyhnYywgZmR0LCBHVUVTVF9ST09UX0FERFJFU1NfQ0VM
TFMsDQo+Pj4+ICsgICAgICAgIEdVRVNUX1JPT1RfU0laRV9DRUxMUywgMiwNCj4+Pj4gKyAgICAg
ICAgR1VFU1RfVlBDSV9BRERSX1RZUEVfTUVNLCBHVUVTVF9WUENJX01FTV9BRERSLCBHVUVTVF9W
UENJX01FTV9TSVpFLA0KPj4+PiArICAgICAgICBHVUVTVF9WUENJX0FERFJfVFlQRV9QUkVGRVRD
SF9NRU0sIEdVRVNUX1ZQQ0lfUFJFRkVUQ0hfTUVNX0FERFIsDQo+Pj4+ICsgICAgICAgIEdVRVNU
X1ZQQ0lfUFJFRkVUQ0hfTUVNX1NJWkUpOw0KPj4+PiArICAgIGlmIChyZXMpIHJldHVybiByZXM7
DQo+Pj4+ICsNCj4+Pj4gKyAgICByZXMgPSBmZHRfZW5kX25vZGUoZmR0KTsNCj4+Pj4gKyAgICBp
ZiAocmVzKSByZXR1cm4gcmVzOw0KPj4+PiArDQo+Pj4+ICsgICAgcmV0dXJuIDA7DQo+Pj4+ICt9
DQo+Pj4+ICsNCj4+Pj4gc3RhdGljIGNvbnN0IHN0cnVjdCBhcmNoX2luZm8gKmdldF9hcmNoX2lu
Zm8obGlieGxfX2djICpnYywNCj4+Pj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICBjb25zdCBzdHJ1Y3QgeGNfZG9tX2ltYWdlICpkb20pDQo+Pj4+IHsNCj4+Pj4g
QEAgLTk3MSw2ICsxMDcwLDkgQEAgbmV4dF9yZXNpemU6DQo+Pj4+ICAgICAgICBpZiAoaW5mby0+
dGVlID09IExJQlhMX1RFRV9UWVBFX09QVEVFKQ0KPj4+PiAgICAgICAgICAgIEZEVCggbWFrZV9v
cHRlZV9ub2RlKGdjLCBmZHQpICk7DQo+Pj4+IA0KPj4+PiArICAgICAgICBpZiAobGlieGxfZGVm
Ym9vbF92YWwoaW5mby0+YXJjaF9hcm0udnBjaSkpDQo+Pj4+ICsgICAgICAgICAgICBGRFQoIG1h
a2VfdnBjaV9ub2RlKGdjLCBmZHQsIGFpbmZvLCBkb20pICk7DQo+Pj4+ICsNCj4+Pj4gICAgICAg
IGlmIChwZmR0KQ0KPj4+PiAgICAgICAgICAgIEZEVCggY29weV9wYXJ0aWFsX2ZkdChnYywgZmR0
LCBwZmR0KSApOw0KPj4+PiANCj4+Pj4gQEAgLTExODksNiArMTI5MSw5IEBAIHZvaWQgbGlieGxf
X2FyY2hfZG9tYWluX2J1aWxkX2luZm9fc2V0ZGVmYXVsdChsaWJ4bF9fZ2MgKmdjLA0KPj4+PiAg
ICAvKiBBQ1BJIGlzIGRpc2FibGVkIGJ5IGRlZmF1bHQgKi8NCj4+Pj4gICAgbGlieGxfZGVmYm9v
bF9zZXRkZWZhdWx0KCZiX2luZm8tPmFjcGksIGZhbHNlKTsNCj4+Pj4gDQo+Pj4+ICsgICAgLyog
VlBDSSBpcyBkaXNhYmxlZCBieSBkZWZhdWx0ICovDQo+Pj4+ICsgICAgbGlieGxfZGVmYm9vbF9z
ZXRkZWZhdWx0KCZiX2luZm8tPmFyY2hfYXJtLnZwY2ksIGZhbHNlKTsNCj4+Pj4gKw0KPj4+PiAg
ICBpZiAoYl9pbmZvLT50eXBlICE9IExJQlhMX0RPTUFJTl9UWVBFX1BWKQ0KPj4+PiAgICAgICAg
cmV0dXJuOw0KPj4+PiANCj4+Pj4gZGlmZiAtLWdpdCBhL3Rvb2xzL2xpYnMvbGlnaHQvbGlieGxf
Y3JlYXRlLmMgYi90b29scy9saWJzL2xpZ2h0L2xpYnhsX2NyZWF0ZS5jDQo+Pj4+IGluZGV4IGUz
NTZiMjEwNmQuLjk0MDg1MjYwMzYgMTAwNjQ0DQo+Pj4+IC0tLSBhL3Rvb2xzL2xpYnMvbGlnaHQv
bGlieGxfY3JlYXRlLmMNCj4+Pj4gKysrIGIvdG9vbHMvbGlicy9saWdodC9saWJ4bF9jcmVhdGUu
Yw0KPj4+PiBAQCAtNjMyLDYgKzYzMiwxNSBAQCBpbnQgbGlieGxfX2RvbWFpbl9tYWtlKGxpYnhs
X19nYyAqZ2MsIGxpYnhsX2RvbWFpbl9jb25maWcgKmRfY29uZmlnLA0KPj4+PiAgICAgICAgaWYg
KGluZm8tPnBhc3N0aHJvdWdoID09IExJQlhMX1BBU1NUSFJPVUdIX1NZTkNfUFQpDQo+Pj4+ICAg
ICAgICAgICAgY3JlYXRlLmlvbW11X29wdHMgfD0gWEVOX0RPTUNUTF9JT01NVV9ub19zaGFyZXB0
Ow0KPj4+PiANCj4+Pj4gKyNpZiBkZWZpbmVkKF9fYXJtX18pIHx8IGRlZmluZWQoX19hYXJjaDY0
X18pDQo+Pj4+ICsgICAgICAgIC8qDQo+Pj4+ICsgICAgICAgICAqIEVuYWJsZSBWUENJIHN1cHBv
cnQgZm9yIEFSTS4gVlBDSSBzdXBwb3J0IGZvciBET01VIGd1ZXN0IGlzIG5vdA0KPj4+PiArICAg
ICAgICAgKiBzdXBwb3J0ZWQgZm9yIHg4Ni4NCj4+Pj4gKyAgICAgICAgICovDQo+Pj4+ICsgICAg
ICAgIGlmICggbGlieGxfZGVmYm9vbF92YWwoYl9pbmZvLT5hcmNoX2FybS52cGNpKSApDQo+Pj4+
ICsgICAgICAgICAgICBjcmVhdGUuZmxhZ3MgfD0gWEVOX0RPTUNUTF9DREZfdnBjaTsNCj4+Pj4g
KyNlbmRpZg0KPj4+IA0KPj4+IEkgZG9uJ3QgdGhpbmsgdGhlICNpZmRlZiBpcyByZXF1aXJlZCwg
aXMgaXQ/IFRoZSBjaGVjayBpcyBiYXNlZCBvbg0KPj4+IGJfaW5mby0+YXJjaF9hcm0udnBjaSB3
aGljaCBpcyBhbHJlYWR5IEFSTS1zcGVjaWZpYyBhbmQgY291bGRuJ3QgYmUNCj4+PiBlbmFibGVk
IG9uIFg4Ni4gV2UgaGF2ZSBhbm90aGVyIHNpbWlsYXIgY2hlY2sgaW4gbGlieGxfY3JlYXRlLmMg
Zm9yDQo+Pj4gZF9jb25maWctPmJfaW5mby5hcmNoX2FybS52dWFydCB3aXRob3V0ICNpZmRlZi4N
Cj4+PiANCj4+PiBNeSBzdWdnZXN0aW9uIHdvdWxkIGJlIHRvIGp1c3Qga2VlcCB0aGUgaW4tY29k
ZSBjb21tZW50LCBidXQgbGVhdmUgdGhlDQo+Pj4gbGlieGxfZGVmYm9vbF92YWwgY2hlY2sgYXMg
aXQgd2FzIGJlZm9yZS4NCj4+PiANCj4+IA0KPj4gSSBhbHNvIHRob3VnaHQgdGhlIHNhbWUgd2F5
IHRoYXQgImJfaW5mby0+YXJjaF9hcm0udnBjaXwiIGlzIGFybS1zcGVjaWZpYyBidXQgc29tZWhv
dyBpdCBpcyBnZXR0aW5nIGVuYWJsZWQgZm9yIHg4NiANCj4+IHdoZW4gd2UgYXNzaWduIHRoZSBQ
Q0kgZGV2aWNlIHRvIERPTVUgZ3Vlc3RzIG9uIHg4NiBQViBET00wIG9uY2UgSSByZW1vdmUgdGhl
ICNpZmRlZiBmb3IgYmVsb3cgY29kZS4NCj4+IA0KPj4gI2lmIGRlZmluZWQoX19hcm1fXykgfHwg
ZGVmaW5lZChfX2FhcmNoNjRfXykgICAgICAgICAgICAgICAgICAgDQo+PiAgICAvKiAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgIA0KPj4gICAgICogRW5hYmxlIFZQQ0kgc3VwcG9y
dCBmb3IgQVJNLiBWUENJIHN1cHBvcnQgZm9yIERPTVUgZ3Vlc3RzIGlzIG5vdCAgICANCj4+ICAg
ICAqIHN1cHBvcnRlZCBmb3IgeDg2LiAgICAgICAgICAgICAgICAgICAgICAgICAgDQo+PiAgICAg
Ki8gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIA0KPj4gICAgaWYgKGRfY29uZmln
LT5udW1fcGNpZGV2cykgICAgICAgICAgICAgICAgICAgICAgICANCj4+ICAgICAgbGlieGxfZGVm
Ym9vbF9zZXQoJmJfaW5mby0+YXJjaF9hcm0udnBjaSwgdHJ1ZSk7ICAgICAgICAgICANCj4+ICNl
bmRpZiANCj4+IA0KPj4gRXJyb3Igb24geDg2Og0KPj4gUGFyc2luZyBjb25maWcgZnJvbSBndWVz
dC5jZmcNCj4+IChYRU4pIGRvbWFpbi5jOjY2NzogdlBDSSBjYW5ub3QgYmUgZW5hYmxlZCB5ZXQN
Cj4+IGxpYnhsOiBlcnJvcjogbGlieGxfY3JlYXRlLmM6NjgzOmxpYnhsX19kb21haW5fbWFrZTog
ZG9tYWluIGNyZWF0aW9uIGZhaWw6IEludmFsaWQgYXJndW1lbnQNCj4+IGxpYnhsOiBlcnJvcjog
bGlieGxfY3JlYXRlLmM6MTIzNzppbml0aWF0ZV9kb21haW5fY3JlYXRlOiBjYW5ub3QgbWFrZSBk
b21haW46IC0zDQo+PiANCj4+IE9uZSBzb2x1dGlvbiBpcyB3ZSBjYW4gcmVtb3ZlIHRoZSAjaWZk
ZWYgZnJvbSB0aGUgYmVsb3cgY29kZSB3aGVuIGNoZWNraW5nIGlmIHZwY2kgaXMgZW5hYmxlZOKA
pg0KPj4gI2lmIGRlZmluZWQoX19hcm1fXykgfHwgZGVmaW5lZChfX2FhcmNoNjRfXykgICAgICAg
ICAgICAgICAgICAgDQo+PiAgICAvKiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
IA0KPj4gICAgICogRW5hYmxlIFZQQ0kgc3VwcG9ydCBmb3IgQVJNLiBWUENJIHN1cHBvcnQgZm9y
IERPTVUgZ3Vlc3RzIGlzIG5vdCAgICANCj4+ICAgICAqIHN1cHBvcnRlZCBmb3IgeDg2LiAgICAg
ICAgICAgICAgICAgICAgICAgICAgDQo+PiAgICAgKi8gICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgIA0KPj4gICAgaWYgKCBsaWJ4bF9kZWZib29sX3ZhbChiX2luZm8tPmFyY2hfYXJt
LnZwY2kpICkgICAgICAgICAgICAgDQo+PiAgICAgIGNyZWF0ZS5mbGFncyB8PSBYRU5fRE9NQ1RM
X0NERl92cGNpOyAgICAgICAgICAgICAgICAgDQo+PiAjZW5kaWYNCj4+IA0KPj4gLi5idXQgbm90
IGZyb20gaGVyZSB3aGVuIHNldHRpbmcgdGhlIGFyY2hfYXJtLnZwY2kgd2hlbiB3ZSBhc3NpZ24g
dGhlIFBDSSBkZXZpY2UgdG8gdGhlIGd1ZXN0Lg0KPj4gDQo+PiAjaWYgZGVmaW5lZChfX2FybV9f
KSB8fCBkZWZpbmVkKF9fYWFyY2g2NF9fKSAgICAgICAgICAgICAgICAgIA0KPj4gICAgLyogICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICANCj4+ICAgICAqIEVuYWJsZSBWUENJIHN1
cHBvcnQgZm9yIEFSTS4gVlBDSSBzdXBwb3J0IGZvciBET01VIGd1ZXN0cyBpcyBub3QgICAgDQo+
PiAgICAgKiBzdXBwb3J0ZWQgZm9yIHg4Ni4gICAgICAgICAgICAgICAgICAgICAgICAgIA0KPj4g
ICAgICovICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICANCj4+ICAgIGlmIChkX2Nv
bmZpZy0+bnVtX3BjaWRldnMpICAgICAgICAgICAgICAgICAgICAgICAgDQo+PiAgICAgIGxpYnhs
X2RlZmJvb2xfc2V0KCZiX2luZm8tPmFyY2hfYXJtLnZwY2ksIHRydWUpOyAgICAgICAgICAgDQo+
PiAjZW5kaWYgDQo+PiANCj4+IA0KPj4gQWxzbyBpZiBJIHJlbW92ZSAjaWZkZWYgYXMgbWVudGlv
biBhYm92ZSBJIG5lZWQgdG8gbW92ZSB0aGUgDQo+PiAgICAgICAibGlieGxfZGVmYm9vbF9zZXRk
ZWZhdWx0KCZiX2luZm8tPmFyY2hfYXJtLnZwY2ksIGZhbHNlKTsg4oCcIA0KPj4gZnJvbSANCj4+
ICAgICAgIGxpYnhsX19hcmNoX2RvbWFpbl9idWlsZF9pbmZvX3NldGRlZmF1bHQoLi4pIA0KPj4g
dG8gY29tbW9uIGNvZGUgDQo+PiAgICAgICBsaWJ4bF9fZG9tYWluX2J1aWxkX2luZm9fc2V0ZGVm
YXVsdCguLikgdG8gYXZvaWQgZXJyb3Igb24geDg2Lg0KPj4gDQo+PiBFcnJvciBvbiB4ODY6DQo+
PiByb290QGRvbTA6fiMgeGwgY3JlYXRlIC1jIGd1ZXN0LmNmZw0KPj4gUGFyc2luZyBjb25maWcg
ZnJvbSBndWVzdC5jZmcNCj4+IHhsOiBsaWJ4bC5jOjMzNzogbGlieGxfZGVmYm9vbF92YWw6IEFz
c2VydGlvbiBgIWxpYnhsX2RlZmJvb2xfaXNfZGVmYXVsdChkYiknIGZhaWxlZC4NCj4+IEFib3J0
ZWQNCj4gDQo+IEFzIGZhciBhcyBJIGNhbiB0ZWxsLCB0aGUgI2lmZGVmIGluIGxpYnhsX2NyZWF0
ZS5jIGNhbiBiZSByZW1vdmVkIGJ5DQo+IGRvaW5nOg0KPiANCj4gICAgICAgIGlmICggbGlieGxf
ZGVmYm9vbF92YWwoYl9pbmZvLT5hcmNoX2FybS52cGNpKSA+IDAgKQ0KPiAgICAgICAgICAgIGNy
ZWF0ZS5mbGFncyB8PSBYRU5fRE9NQ1RMX0NERl92cGNpOw0KPiANCj4gYmVjYXVzZSB3ZSBuZWVk
IHRvIGNoZWNrIGZvciBMSUJYTF9fREVGQk9PTF9UUlVFLCB3aGljaCBpcyA+IDAsIHJpZ2h0Pw0K
DQpZZXMgcmlnaHQgd2UgaGF2ZSB0byBjaGVjayAgTElCWExfX0RFRkJPT0xfVFJVRSB3aGljaCBp
cyAxLg0KDQo+IEFuZCB2cGNpIHNob3VsZCBuZXZlciBiZSBzZXQgb24geDg2LiBhcmNoX2FybS52
cGNpIHNob3VsZCBiZSBpbml0aWFsaXplZA0KPiB0byB6ZXJvIG9uIHg4NiB3aGljaCBpcyBMSUJY
TF9fREVGQk9PTF9ERUZBVUxULiBUaGF0IHNob3VsZCB3b3JrLg0KDQpsaWJ4bF9kZWZib29sX3Zh
bChsaWJ4bF9kZWZib29sIGRiKSBpcyBpbXBsZW1lbnRlZCBpbiBzdWNoIGEgd2F5IHRoYXQgaXQg
d2lsbCBhc3NlcnQgDQppZiBkYiB2YWx1ZSBpcyB0aGUgZGVmYXVsdC4gVGhlcmVmb3JlIHdlIGhh
dmUgdG8gZXhwbGljaXRseSBzZXQgaXQgdG8gTElCWExfX0RFRkJPT0xfRkFMU0UgZm9yIHg4Ni4N
Cg0KVGhlcmUgYXJlIHR3byBvcHRpb24gZWl0aGVyIHdlIGNhbiBoYXZlICNpZmRlZiBvciB3ZSBj
YW4gbW92ZSB0aGUgDQpsaWJ4bF9kZWZib29sX3NldGRlZmF1bHQoJmJfaW5mby0+YXJjaF9hcm0u
dnBjaSwgZmFsc2UpIHRvIGNvbW1vbiBjb2RlLg0KDQpSZWdhcmRzLA0KUmFodWwNCj4gDQo+IA0K
PiBPbiB0aGUgb3RoZXIgaGFuZCB5b3UgYXJlIHJpZ2h0IHRoYXQgdGhlICNpZmRlZiBpbiB0b29s
cy94bC94bF9wYXJzZS5jDQo+IGNhbm5vdCBqdXN0IGJlIHJlbW92ZWQgYmVjYXVzZSBvdGhlcndp
c2UgYl9pbmZvLT5hcmNoX2FybS52cGNpIGdldHMgc2V0DQo+IG9uIHg4Niwgd2hpY2ggb2J2aW91
c2x5IHdlIGRvbid0IHdhbnQuDQoNCg==


From xen-devel-bounces@lists.xenproject.org Wed Oct 06 10:11:13 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Oct 2021 10:11:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.202650.357631 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mY3tD-0001FJ-3E; Wed, 06 Oct 2021 10:11:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 202650.357631; Wed, 06 Oct 2021 10:11:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mY3tD-0001FC-0D; Wed, 06 Oct 2021 10:11:07 +0000
Received: by outflank-mailman (input) for mailman id 202650;
 Wed, 06 Oct 2021 10:11:05 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=RZr5=O2=gmail.com=olekstysh@srs-us1.protection.inumbo.net>)
 id 1mY3tB-0001F6-B7
 for xen-devel@lists.xenproject.org; Wed, 06 Oct 2021 10:11:05 +0000
Received: from mail-lf1-x129.google.com (unknown [2a00:1450:4864:20::129])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id e3986fbd-6f1f-4fa5-8d49-c9f83aa4ba7e;
 Wed, 06 Oct 2021 10:11:04 +0000 (UTC)
Received: by mail-lf1-x129.google.com with SMTP id u18so8068687lfd.12
 for <xen-devel@lists.xenproject.org>; Wed, 06 Oct 2021 03:11:04 -0700 (PDT)
Received: from [192.168.1.7] ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id h10sm2226396lft.15.2021.10.06.03.11.02
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Wed, 06 Oct 2021 03:11:02 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e3986fbd-6f1f-4fa5-8d49-c9f83aa4ba7e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-transfer-encoding:content-language;
        bh=1mXps78xtQVA4oyAJgDfQqCsJ6bmS0UpCW1znquadlg=;
        b=VL/DZd2PyE/7x6V2vz3SjbEHlotDkniCLUXLwH9I1KYWcuH6AXi2/wMEx3FMbGvpmA
         LGgVDdS9XW7INTaOOBcvgm6CiZBLrqfu4KXcPwFDSkY1vKD4as48+D5QXxiIfZdceV0W
         irGNrO4U58aEelOBVzAUkLgLggRP3yQkvKFJjHDfydHEVjKpwqwKSthF0sUMepqgs96z
         FX0ChNAR0AVAAjA0I56si+nZvTFQBWLPmiEZrwF7dLnn6k91a4IQ06T7o2n2vKv5Ghi8
         8Hhp0Hb+urYM58q39EdaIoRNMj9D+b1xUliOOqvWdYHb2m7g6Mcl/xmmOCaVvnUql42O
         xYeQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding
         :content-language;
        bh=1mXps78xtQVA4oyAJgDfQqCsJ6bmS0UpCW1znquadlg=;
        b=XawE7fKrXxtpwvgSZf3GYkHPhEaHYaCpGm03rjpwNRDSryHylNpM62eu0ohDoX+GZK
         XczCNaGq6c4eb2CILGVWuTEIr+Lq/BDz88/n8lP7ju2JWRTCjhJWXsx0NCqYpzzTB9qx
         JkUWdQfiN1v9mGnfFiOuGh/yJDgmopQdTZ7gaNhxXVPswuKlKwbpUaDWA9UBAuC3Wx1P
         pQjhAKU4xM0dnFurr4lBjNUIu/UAMSz2snBg/5wJnoyTyKBPiQOjriVj7m113Qm7FGET
         B6x2jMngbFPnsUeCHtFMwe+TpedBJzFx8nVI0ms9pt0K7r3J3AKZjPZt0a3q2d5lnN2l
         5HwQ==
X-Gm-Message-State: AOAM532ZnzH96cvlQKQvXuwNgdhnSvN/BxHKaPIOSl0qzkpnjQrGigmK
	DIMe4baMlyg99fsBW8xywbw=
X-Google-Smtp-Source: ABdhPJw4YpcUOZ/9t6aRzho3ql0DlUOFCuzp4GcFut5DBCtseB2kzHmW5z3UjmAgsrciuvMzUEdNfw==
X-Received: by 2002:a05:651c:1505:: with SMTP id e5mr27872758ljf.102.1633515063238;
        Wed, 06 Oct 2021 03:11:03 -0700 (PDT)
Subject: Re: [PATCH V4 3/3] libxl/arm: Add handling of extended regions for
 DomU
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: Julien Grall <julien@xen.org>, xen-devel@lists.xenproject.org,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>,
 Anthony PERARD <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <1632955927-27911-1-git-send-email-olekstysh@gmail.com>
 <1632955927-27911-4-git-send-email-olekstysh@gmail.com>
 <c0184478-4af1-d9e8-a527-49ae7eebcc70@gmail.com>
 <alpine.DEB.2.21.2110051435200.3209@sstabellini-ThinkPad-T480s>
From: Oleksandr <olekstysh@gmail.com>
Message-ID: <b9635e32-3969-8408-01d2-8f2574d32c4f@gmail.com>
Date: Wed, 6 Oct 2021 13:11:01 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.21.2110051435200.3209@sstabellini-ThinkPad-T480s>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US


On 06.10.21 00:36, Stefano Stabellini wrote:

Hi Stefano

> On Tue, 5 Oct 2021, Oleksandr wrote:
>>> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>>>
>>> The extended region (safe range) is a region of guest physical
>>> address space which is unused and could be safely used to create
>>> grant/foreign mappings instead of wasting real RAM pages from
>>> the domain memory for establishing these mappings.
>>>
>>> The extended regions are chosen at the domain creation time and
>>> advertised to it via "reg" property under hypervisor node in
>>> the guest device-tree. As region 0 is reserved for grant table
>>> space (always present), the indexes for extended regions are 1...N.
>>> If extended regions could not be allocated for some reason,
>>> Xen doesn't fail and behaves as usual, so only inserts region 0.
>>>
>>> Please note the following limitations:
>>> - The extended region feature is only supported for 64-bit domain
>>>     currently.
>>> - The ACPI case is not covered.
>>>
>>> ***
>>>
>>> The algorithm to choose extended regions for non-direct mapped
>>> DomU is simpler in comparison with the algorithm for direct mapped
>>> Dom0. As we have a lot of unused space above 4GB, provide single
>>> 2MB-aligned region from the second RAM bank taking into the account
>>> the maximum supported guest address space size and the amount of
>>> memory assigned to the guest. The maximum size of the region is 128GB.
>>> The minimum size is 64MB.
>>>
>>> Suggested-by: Julien Grall <jgrall@amazon.com>
>>> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>>> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
>>> Acked-by: Ian Jackson <iwj@xenproject.org>
>>> Reviewed-by: Michal Orzel <michal.orzel@arm.com>
>>> Tested-by: Michal Orzel <michal.orzel@arm.com>
>> I though a bit more on this and decided to make a patch more functional by
>> trying to also allocate extended region below 4GB, I think we could do with
>> it.
>> Actually if guest memory size is less than GUEST_RAM0_SIZE, we are able to
>> provide unused space. I have tested with with various guest memory sizes and
>> it worked fine. Also I decided to drop limit for maximum extended region size
>> (128GB), we don't apply this limit in Dom0 and I don't see why we need it
>> here, moreover the calculation became more obvious. I will drop all acks and
>> send updated version. Are there any objections?
> I am OK with it; it looks like you made good improvements. One caveat is
> that I volunteer to review again no problem,

Great, thank you.


> but we'll need a new ack
> from Ian Jackson to commit.

Yes, I know that.


-- 
Regards,

Oleksandr Tyshchenko



From xen-devel-bounces@lists.xenproject.org Wed Oct 06 10:15:50 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Oct 2021 10:15:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.202659.357643 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mY3xj-0001u8-Lw; Wed, 06 Oct 2021 10:15:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 202659.357643; Wed, 06 Oct 2021 10:15:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mY3xj-0001u1-I3; Wed, 06 Oct 2021 10:15:47 +0000
Received: by outflank-mailman (input) for mailman id 202659;
 Wed, 06 Oct 2021 10:15:45 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=13oh=O2=arm.com=Rahul.Singh@srs-us1.protection.inumbo.net>)
 id 1mY3xh-0001tv-Q5
 for xen-devel@lists.xenproject.org; Wed, 06 Oct 2021 10:15:45 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com (unknown
 [40.107.8.70]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 65684d62-70fe-49f2-9766-07634c6c7dbb;
 Wed, 06 Oct 2021 10:15:43 +0000 (UTC)
Received: from AM0PR03CA0009.eurprd03.prod.outlook.com (2603:10a6:208:14::22)
 by AM9PR08MB6660.eurprd08.prod.outlook.com (2603:10a6:20b:305::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18; Wed, 6 Oct
 2021 10:15:39 +0000
Received: from AM5EUR03FT037.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:208:14:cafe::67) by AM0PR03CA0009.outlook.office365.com
 (2603:10a6:208:14::22) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.16 via Frontend
 Transport; Wed, 6 Oct 2021 10:15:39 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM5EUR03FT037.mail.protection.outlook.com (10.152.17.241) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4566.14 via Frontend Transport; Wed, 6 Oct 2021 10:15:38 +0000
Received: ("Tessian outbound 16951d3c485e:v103");
 Wed, 06 Oct 2021 10:15:37 +0000
Received: from cb8a15151076.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 FD52AE1D-9ADB-4F9D-A279-3C2124BAC534.1; 
 Wed, 06 Oct 2021 10:15:26 +0000
Received: from EUR03-AM5-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id cb8a15151076.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Wed, 06 Oct 2021 10:15:26 +0000
Received: from AS8PR08MB6919.eurprd08.prod.outlook.com (2603:10a6:20b:39e::10)
 by AM6PR08MB3560.eurprd08.prod.outlook.com (2603:10a6:20b:4c::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.22; Wed, 6 Oct
 2021 10:15:24 +0000
Received: from AS8PR08MB6919.eurprd08.prod.outlook.com
 ([fe80::51ee:e7de:6c0a:bcf9]) by AS8PR08MB6919.eurprd08.prod.outlook.com
 ([fe80::51ee:e7de:6c0a:bcf9%7]) with mapi id 15.20.4566.023; Wed, 6 Oct 2021
 10:15:24 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 65684d62-70fe-49f2-9766-07634c6c7dbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=tj0NMbcGndmhhvAOxSOQixjWVF86tRL0WmY22Aij3fI=;
 b=XLyYBU0Xoc+iKrL4/SdfU5UZAmDjpJq3Fk4ao0nh6d1Ud1nsjl5+n9xqpvAQNQtnKQ6Vb/1T9SZItsyHVoN9rSRjRboB+0iN+gndjCDJVHipUSF1WYjmSEoPqZdS5k6EngtIbhzOqV26sL9/bSTjrTDXlnwC2lx4AWRZ6HgqHYQ=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: c5893583fc5ff38b
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ZvE6ajnvEcAUYc968s44jekB7OyQuaFXjaRte5KE4vXv+DpMXD4p7N9UoSw58/p1HaYif3fTd+VAAxYBcyACsTf7AVf7G82UWHtB4cl3sIFH/6nQyYcB7XJN8/5Xp9/U7wrljtJybHLsQq7dyOlsgIyzkRc0wTyAiGJ06diAvekpKlnTWbUHkBZGjkSXomVcD1RZDH12pLfkIqoHPWwh2SZ8xhb25MEonCgHyx95Z+gQqxXdGfCV+GOTgucm16R2YfRiFdpmbAF272cZzHWI1rSwwsHntCQQ8Y+pqoRaO4XJybRi2LpEqlWHkm61RseH9TuYj0IQGyUaPxDJsL5ZVw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=tj0NMbcGndmhhvAOxSOQixjWVF86tRL0WmY22Aij3fI=;
 b=cQFyyYnFPwBdrXcftkhfZgxsTKTWCNcY/wQLkxwyz6XPlyuxGxUTtfMzHTL1f1zlcluTzXerxfLElyUVXJURMESIbTRI7vSeNXcDbyQ/zfIRNsyXHMYFjnfbhkRv/H5qIyxP2HmnUS4kIDpYpNcbFdV24ihWsSrQGzVfJgDEA9iqCKJ6iV+8iXyyJ4fVUcb5/qui40NCz9r1MLYqeOqvJkrSuv2gkOGPSSu1bt8mzKJ0mkJt7QAolBDgybSWGwGi00FX/loqPq+XHHXOmOC66IhZnJXMGKWXjE4SXUBCE3/Cyhyuee36ad9kSxHEWws+0wKW7720cUKk/sQiY4l3qw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=tj0NMbcGndmhhvAOxSOQixjWVF86tRL0WmY22Aij3fI=;
 b=XLyYBU0Xoc+iKrL4/SdfU5UZAmDjpJq3Fk4ao0nh6d1Ud1nsjl5+n9xqpvAQNQtnKQ6Vb/1T9SZItsyHVoN9rSRjRboB+0iN+gndjCDJVHipUSF1WYjmSEoPqZdS5k6EngtIbhzOqV26sL9/bSTjrTDXlnwC2lx4AWRZ6HgqHYQ=
From: Rahul Singh <Rahul.Singh@arm.com>
To: Oleksandr Andrushchenko <andr2000@gmail.com>
CC: xen-devel <xen-devel@lists.xenproject.org>, Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>, "oleksandr_tyshchenko@epam.com"
	<oleksandr_tyshchenko@epam.com>, "volodymyr_babchuk@epam.com"
	<volodymyr_babchuk@epam.com>, Artem Mygaiev <Artem_Mygaiev@epam.com>,
	=?iso-8859-1?Q?Roger_Pau_Monn=E9?= <roger.pau@citrix.com>, Jan Beulich
	<jbeulich@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>, George Dunlap
	<george.dunlap@citrix.com>, Paul Durrant <paul@xen.org>, Bertrand Marquis
	<Bertrand.Marquis@arm.com>, Oleksandr Andrushchenko
	<oleksandr_andrushchenko@epam.com>
Subject: Re: [PATCH v4 02/11] xen/arm: Add new device type for PCI
Thread-Topic: [PATCH v4 02/11] xen/arm: Add new device type for PCI
Thread-Index: AQHXuSnbiZmskKn6EUq1TwpRsFvaGKvFw9KA
Date: Wed, 6 Oct 2021 10:15:24 +0000
Message-ID: <CD3A622A-9A97-447A-B918-805054F25FBF@arm.com>
References: <20211004141151.132231-1-andr2000@gmail.com>
 <20211004141151.132231-3-andr2000@gmail.com>
In-Reply-To: <20211004141151.132231-3-andr2000@gmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
Authentication-Results-Original: gmail.com; dkim=none (message not signed)
 header.d=none;gmail.com; dmarc=none action=none header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: a7c4e5bc-f4c1-4fa2-bff8-08d988b23e8f
x-ms-traffictypediagnostic: AM6PR08MB3560:|AM9PR08MB6660:
x-ms-exchange-transport-forked: True
X-Microsoft-Antispam-PRVS:
	<AM9PR08MB66606132EFA552CD183EA686FCB09@AM9PR08MB6660.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:9508;OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 jTGF2LcPGJ987mSNyc9aM0aEqA9Uq8HOHxWzSQQ1mqihnawLsCvoONMPndNWfeGID6xtY+1bT/YyM/8FY/SgJGRtRokaPB3QK1ChHxkHm8gRXPbuw/Uuf3aQGKLao8M3Q44POgY0GsaIMtErcdHP8BRncd91AYCrG2KLEAIE50/1DoFo27V9Ck8ImRNcA2ZfENhzG+sXwnPpLKL+P31l6VOj8RzPUIDry2OXANfU0Ky5EQfrHQtCIsyUJCTSg46C+Fu4xyLRlQ8fjQfHiWz9Mn7FBzUZqyax8pAaX/wyBAANgwjzGGd1luxQkYSnVLHnNrPEUWDtcAPbfMEVynsRVoaUZ+euEfq+aWCRw4zLXHnQcRCSXeG//Y3wuyP/WOFm34ZBC0LI/dPkVkLif+ytjiryxr08OOhqpstcVGYomJsGQq2t05J8zxbSc8w8nNDQCmpk0/cg1FheQqksb/OJ2ygWGtiDnZq3YFZ4nL1JGnaj/WmmOPXtt3rkcPWhl1IiNUwxIutA/1IJMHe/NwaoFhX8OEiXH4vbUnBTZ+vN6UkY2lBhJXC2WJxwhTMdMwjKuOAjC1Lt+mG5OZmwtJOhyu6dZ4CAkUiAqdWtI4W2D+SdiTLsWS5/kRP7YBHW+LkdHi31+8Bv75vc8LuqXmYc9bfG8QaH29cEJRj9TgCldbTA408aPxw2Kv3jCAD2ify81Egdkn+u+WdDHMGNUcJKZ9X3K/t+kqKcBvxiCVs1S9I=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6919.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(122000001)(86362001)(26005)(6506007)(186003)(8936002)(8676002)(508600001)(33656002)(71200400001)(7416002)(38100700002)(36756003)(316002)(2616005)(53546011)(6916009)(6486002)(5660300002)(66446008)(64756008)(66556008)(38070700005)(6512007)(66476007)(2906002)(83380400001)(4326008)(54906003)(76116006)(66946007)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="iso-8859-1"
Content-ID: <475234C783ACFD46A4B5037EBB884753@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3560
Original-Authentication-Results: gmail.com; dkim=none (message not signed)
 header.d=none;gmail.com; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM5EUR03FT037.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	c25fc6c2-0e2b-4632-e16a-08d988b2360f
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	VqziR6chZL1POjXOTmcSvFpYKK7qJpnipj84G8FH1y6xN+MQLCGvsvGcGPTnRmh+qE8lA9/OuL+O92I0DugbC+Oej09hfzwiOnG99qCGxH7KOixWircXHD3KlEOLEf4Sv4x7LW3bn4viHtK1HLpmfKbj7Xkzb8WSqPoijmYphjsHBAm41yc7Bp7DFPd96oD/gtZWtrHdwl2tilj12Teb7tWM7ofAFuK2zbOcSmkzdmxFGQOUNRd6/WqUw3mL0eISk10kITizS01h+eYaXRv3JgHWfxuSOhSZQtJn5mxpWUA2wfI9/UAPS0XKQnKo2Ui+J/pO36W+sLiqV6S/LCE3GVPUd6PMISTRx6iqfNGfkBpD1YFvSRtY+qGEAUN9mLdry2wzbFQeZMBTXjSTh3NzKzyEr2ClOtFkPifbo6JeVtrwwAKPhE1+EOMivpuzT6yiVn5uETh3OXz2U1gEoHkfv/z3WrchhRnTHmEb7j/N4TIpy/B3EbPCPjysifct1mrMT3EaG8H0F/W4oqVoHdvbvtzC1JYCBHhxaArv60AngadB5T49C7eM8AVN4XDB3SRWUOZrDZ8DowFbunBieJ3CSHvlMyuxGKzuzKhZq9BGcgKU+FtbcKTjCnqsakOyKPpQifLRYe5RSb9Z9G6jiR3ZFMe+naQCVOIl4va7UNdlb8ox8DXpYyhACqC6sv5op6Q3UA5E5Z48zPnjh7fbKCkdVw==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(6862004)(508600001)(2616005)(186003)(33656002)(54906003)(47076005)(6486002)(82310400003)(86362001)(316002)(70586007)(8676002)(36756003)(70206006)(53546011)(4326008)(2906002)(81166007)(8936002)(6506007)(5660300002)(83380400001)(107886003)(26005)(336012)(6512007)(356005)(36860700001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Oct 2021 10:15:38.4230
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: a7c4e5bc-f4c1-4fa2-bff8-08d988b23e8f
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM5EUR03FT037.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB6660

Hi Oleksandr,

> On 4 Oct 2021, at 3:11 pm, Oleksandr Andrushchenko <andr2000@gmail.com> w=
rote:
>=20
> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
>=20
> Add new device type (DEV_PCI) to distinguish PCI devices from platform
> DT devices, so some drivers, like IOMMU, can handle PCI devices
> differently.
>=20
> Also add a helper which is when given a struct device returns the
> corresponding struct pci_dev which this device is a part of.
>=20
> Because of the header cross-dependencies, e.g. we need both
> struct pci_dev and struct arch_pci_dev at the same time, this cannot be
> done with an inline.
>=20
> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>

Reviewed-by: Rahul Singh <rahul.singh@arm.com>
Tested-by: Rahul Singh <rahul.singh@arm.com>

Regards,
Rahul
>=20
> Since v2:
> - !! dropped Stefano's r-b because of the changes
> - simplified dev_to_pci to use a single
>   container_of(dev, struct pci_dev, arch.dev) (Jan)
> Since v1:
> - Folded new device type (DEV_PCI) into this patch.
> ---
> xen/arch/arm/pci/pci.c       | 7 +++++++
> xen/include/asm-arm/device.h | 4 ++--
> xen/include/asm-arm/pci.h    | 7 +++++++
> 3 files changed, 16 insertions(+), 2 deletions(-)
>=20
> diff --git a/xen/arch/arm/pci/pci.c b/xen/arch/arm/pci/pci.c
> index 73540045d187..138da19284ab 100644
> --- a/xen/arch/arm/pci/pci.c
> +++ b/xen/arch/arm/pci/pci.c
> @@ -27,6 +27,13 @@ int arch_pci_clean_pirqs(struct domain *d)
>     return 0;
> }
>=20
> +struct pci_dev *dev_to_pci(struct device *dev)
> +{
> +    ASSERT(dev->type =3D=3D DEV_PCI);
> +
> +    return container_of(dev, struct pci_dev, arch.dev);
> +}
> +
> static int __init dt_pci_init(void)
> {
>     struct dt_device_node *np;
> diff --git a/xen/include/asm-arm/device.h b/xen/include/asm-arm/device.h
> index ebe84ea853cd..7bf040560363 100644
> --- a/xen/include/asm-arm/device.h
> +++ b/xen/include/asm-arm/device.h
> @@ -4,6 +4,7 @@
> enum device_type
> {
>     DEV_DT,
> +    DEV_PCI,
> };
>=20
> struct dev_archdata {
> @@ -25,8 +26,7 @@ typedef struct device device_t;
>=20
> #include <xen/device_tree.h>
>=20
> -/* TODO: Correctly implement dev_is_pci when PCI is supported on ARM */
> -#define dev_is_pci(dev) ((void)(dev), 0)
> +#define dev_is_pci(dev) ((dev)->type =3D=3D DEV_PCI)
> #define dev_is_dt(dev)  ((dev)->type =3D=3D DEV_DT)
>=20
> enum device_class
> diff --git a/xen/include/asm-arm/pci.h b/xen/include/asm-arm/pci.h
> index 7cb2e2f1edaf..603a1fc072d1 100644
> --- a/xen/include/asm-arm/pci.h
> +++ b/xen/include/asm-arm/pci.h
> @@ -26,6 +26,13 @@ struct arch_pci_dev {
>     struct device dev;
> };
>=20
> +/*
> + * Because of the header cross-dependencies, e.g. we need both
> + * struct pci_dev and struct arch_pci_dev at the same time, this cannot =
be
> + * done with an inline here. Macro can be implemented, but looks scary.
> + */
> +struct pci_dev *dev_to_pci(struct device *dev);
> +
> /* Arch-specific MSI data for vPCI. */
> struct vpci_arch_msi {
> };
> --=20
> 2.25.1
>=20



From xen-devel-bounces@lists.xenproject.org Wed Oct 06 10:23:33 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Oct 2021 10:23:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.202668.357654 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mY45B-0003M9-GG; Wed, 06 Oct 2021 10:23:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 202668.357654; Wed, 06 Oct 2021 10:23:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mY45B-0003M2-CM; Wed, 06 Oct 2021 10:23:29 +0000
Received: by outflank-mailman (input) for mailman id 202668;
 Wed, 06 Oct 2021 10:23:28 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mY45A-0003Ls-OV; Wed, 06 Oct 2021 10:23:28 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mY45A-0000qb-H5; Wed, 06 Oct 2021 10:23:28 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mY45A-000841-87; Wed, 06 Oct 2021 10:23:28 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mY45A-0007s5-5i; Wed, 06 Oct 2021 10:23:28 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=amr64fTOCM24lp97FbMT/HWZR2jk+EFKr8H0Y8qHchI=; b=fenXwsjszXNgizxc8vYBJCOrVw
	7DgSftjw4DmQ8B2rQuLXIs20PZ/+/1cl2kEPEh0eCdIDsEfcxVoilkRuIg7krpujkss4cNBtcWQSU
	sKcVVmYuFcZyWbHQcUL3v+MA4l2wDHU28Jtrh0JAfTSkYsrOLodrfnsb/066WoB3etK0=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165397-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-coverity test] 165397: all pass - PUSHED
X-Osstest-Versions-This:
    xen=192aaf7e146c0b41dbdd35ccdb13eb33ced13633
X-Osstest-Versions-That:
    xen=dd6c062a7a4abdb662c18af03d1396325969d155
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 06 Oct 2021 10:23:28 +0000

flight 165397 xen-unstable-coverity real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165397/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 xen                  192aaf7e146c0b41dbdd35ccdb13eb33ced13633
baseline version:
 xen                  dd6c062a7a4abdb662c18af03d1396325969d155

Last test of basis   165203  2021-09-26 09:19:39 Z   10 days
Testing same since   165397  2021-10-06 09:21:13 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Anthony PERARD <anthony.perard@citrix.com>
  Anthony PERARD <anthony.perard@gmail.com>
  Ian Jackson <iwj@xenproject.org>
  Igor Druzhinin <igor.druzhinin@citrix.com>
  Ivan Kardykov <kardykov@tabit.pro>
  Jan Beulich <jbeulich@suse.com>
  Juergen Gross <jgross@suse.com>
  Luca Fancellu <luca.fancellu@arm.com>
  Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
  Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
  Rahul Singh <rahul.singh@arm.com>
  Stefano Stabellini <sstabellini@kernel.org>

jobs:
 coverity-amd64                                               pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   dd6c062a7a..192aaf7e14  192aaf7e146c0b41dbdd35ccdb13eb33ced13633 -> coverity-tested/smoke


From xen-devel-bounces@lists.xenproject.org Wed Oct 06 10:24:21 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Oct 2021 10:24:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.202676.357668 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mY461-0003wq-Qa; Wed, 06 Oct 2021 10:24:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 202676.357668; Wed, 06 Oct 2021 10:24:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mY461-0003wf-ND; Wed, 06 Oct 2021 10:24:21 +0000
Received: by outflank-mailman (input) for mailman id 202676;
 Wed, 06 Oct 2021 10:24:20 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=13oh=O2=arm.com=Rahul.Singh@srs-us1.protection.inumbo.net>)
 id 1mY460-0003wZ-Ke
 for xen-devel@lists.xenproject.org; Wed, 06 Oct 2021 10:24:20 +0000
Received: from EUR03-DB5-obe.outbound.protection.outlook.com (unknown
 [40.107.4.51]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 8ffb2dd0-268f-11ec-bf57-12813bfff9fa;
 Wed, 06 Oct 2021 10:24:18 +0000 (UTC)
Received: from DB7PR03CA0096.eurprd03.prod.outlook.com (2603:10a6:10:72::37)
 by AM6PR08MB3958.eurprd08.prod.outlook.com (2603:10a6:20b:a6::30) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.22; Wed, 6 Oct
 2021 10:24:15 +0000
Received: from DB5EUR03FT009.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:10:72:cafe::c9) by DB7PR03CA0096.outlook.office365.com
 (2603:10a6:10:72::37) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18 via Frontend
 Transport; Wed, 6 Oct 2021 10:24:15 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT009.mail.protection.outlook.com (10.152.20.117) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4566.14 via Frontend Transport; Wed, 6 Oct 2021 10:24:15 +0000
Received: ("Tessian outbound d5def7722ff7:v103");
 Wed, 06 Oct 2021 10:24:15 +0000
Received: from 1559fed18904.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 96065CF1-C33A-4C57-83B6-8C45D30A5200.1; 
 Wed, 06 Oct 2021 10:24:06 +0000
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 1559fed18904.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Wed, 06 Oct 2021 10:24:06 +0000
Received: from AS8PR08MB6919.eurprd08.prod.outlook.com (2603:10a6:20b:39e::10)
 by AS8PR08MB6776.eurprd08.prod.outlook.com (2603:10a6:20b:350::9)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.22; Wed, 6 Oct
 2021 10:24:02 +0000
Received: from AS8PR08MB6919.eurprd08.prod.outlook.com
 ([fe80::51ee:e7de:6c0a:bcf9]) by AS8PR08MB6919.eurprd08.prod.outlook.com
 ([fe80::51ee:e7de:6c0a:bcf9%7]) with mapi id 15.20.4566.023; Wed, 6 Oct 2021
 10:24:02 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8ffb2dd0-268f-11ec-bf57-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=N3j4r5YO2fyOp4hY/NACH/zn4szN890eJEQyJ5RSjEk=;
 b=tM4QdeD1eu1RF7TAz0SH2aMPkmPP8zEThkv+kIIxv6wzQ54bhnzQdMwBRdmy3m07s3eaJfy2g5dgg6rBmh4qwMhQPtkBx37zvf40tt8Z8SmiWj4er2qm2a2N8nIRSLNHR2v7rOyHrbtViJraorTc2EJ/cpNwp7ZO/HqhiLTqjfY=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: f830691af9f06b86
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=GgDY5bTzQ7na6nyrHcfohSA9FHiNesSEKMwzN2s/41xSzFCk/4hwbuHeHs75ZNzskKOxGdopjBSdU7s5TYPQ5i3XWXto/JwhQer3kQrSgEreRjSAxZx6LL4YdGMQKjoCKerYeIAzrUoxi1FXJclZLgXWbILEA3OexRBfgcRGT73dj01FOogYqInl12GZPlN7jEYvdgBJXW/keG9+Ao0RQ6ezO2c8eR5LZcRuVimzeNS6h14TixbR3XUMU2qQFlg0gRLkkPyhOVJZcqfEabyFenGJL8apIlMHAsYN9KT2J2Xqf7jbFhtGAauBBVlMJCzsPP1wivJQV2UHewPv1G1gmg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=N3j4r5YO2fyOp4hY/NACH/zn4szN890eJEQyJ5RSjEk=;
 b=D3X2jugF3MLzSg6UWuitE4p7eCNKdrfq+T8KXseKksoIHd//5kWjH4mM5UzM9VRUe5aSvapd32M2LbT/NeMscH/3CWseqizqHdHB6DZcF4UFn416RZiVJ/rwXPE9eO1/gkLUgNFKp3ySPzxYIt0ylyChzGDrA0X9twE/y8m2htF7wZYiHJhu4cAbDQK4Lt/IEGiWr8+PP59jIQ01m/wDnZk0O6ZHf9tWdGT/11KxrFOaNhWJKdOkPRqetZ2Im7ss0mCpqaSinuTy1Un8vTE4EhToYUAMCVGyCzT8jiby+kyZalxLjMCW+iQxHhfe44mCYaDXvEDzi1rgdlSdUBcjNg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=N3j4r5YO2fyOp4hY/NACH/zn4szN890eJEQyJ5RSjEk=;
 b=tM4QdeD1eu1RF7TAz0SH2aMPkmPP8zEThkv+kIIxv6wzQ54bhnzQdMwBRdmy3m07s3eaJfy2g5dgg6rBmh4qwMhQPtkBx37zvf40tt8Z8SmiWj4er2qm2a2N8nIRSLNHR2v7rOyHrbtViJraorTc2EJ/cpNwp7ZO/HqhiLTqjfY=
From: Rahul Singh <Rahul.Singh@arm.com>
To: Oleksandr Andrushchenko <andr2000@gmail.com>
CC: xen-devel <xen-devel@lists.xenproject.org>, Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>, "oleksandr_tyshchenko@epam.com"
	<oleksandr_tyshchenko@epam.com>, "volodymyr_babchuk@epam.com"
	<volodymyr_babchuk@epam.com>, Artem Mygaiev <Artem_Mygaiev@epam.com>,
	=?iso-8859-1?Q?Roger_Pau_Monn=E9?= <roger.pau@citrix.com>, Jan Beulich
	<jbeulich@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>, George Dunlap
	<george.dunlap@citrix.com>, Paul Durrant <paul@xen.org>, Bertrand Marquis
	<Bertrand.Marquis@arm.com>, Oleksandr Andrushchenko
	<oleksandr_andrushchenko@epam.com>
Subject: Re: [PATCH v4 03/11] xen/arm: Introduce pci_find_host_bridge_node
 helper
Thread-Topic: [PATCH v4 03/11] xen/arm: Introduce pci_find_host_bridge_node
 helper
Thread-Index: AQHXuSnbk6lAyqcLOUmLtP1GAsLbT6vFxjwA
Date: Wed, 6 Oct 2021 10:24:02 +0000
Message-ID: <DFBD9E2E-06DB-46C6-A807-FFCC442E245B@arm.com>
References: <20211004141151.132231-1-andr2000@gmail.com>
 <20211004141151.132231-4-andr2000@gmail.com>
In-Reply-To: <20211004141151.132231-4-andr2000@gmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
Authentication-Results-Original: gmail.com; dkim=none (message not signed)
 header.d=none;gmail.com; dmarc=none action=none header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: 36543349-8e8f-4eda-253b-08d988b372d7
x-ms-traffictypediagnostic: AS8PR08MB6776:|AM6PR08MB3958:
x-ms-exchange-transport-forked: True
X-Microsoft-Antispam-PRVS:
	<AM6PR08MB39584E380B1E11942473002DFCB09@AM6PR08MB3958.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:3044;OLM:3044;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 15bnOmV3YGGbIHkxpw0Al5Py95K6baXf78avk6FaHSDq9Cr7Ny6h4ko+vQb3PgjFbLqqIYZYsuKT2WX8sR3bfgJ6G0N+Gd15uGLbdaXXzBIEkTsK+7g1qvEqouP722rMusx9f1c3Bu3rFMilL+UaDv+qNjYcSvWm0TBWgx22S7JUAzb36xT2+fbNQEEgpmygCulisE24P6vdqmIKDuUYlnAdeN4QkRHYGsWRD9Z//50Xjgq4tCtRZZYWApZt9iGi8k79pFmFjsRX+XD6kGHyjkqqh5M/ZGw9lvYK05PC4GPw0wbb0bf4EyL5hcUCi/BvYGBELuTZU+95oWcz6v033qWooeR9OQ7Qf6FL8m7mIMNQF9loRHyBzh3ZbpbuGxFctQIVniGz603MvXIcn3eJdcjyNYTGlLJGh7zm3RqhmB4y29Vxp7rraV8XXP5qMz91LDsRuJOQP+Kvi4IcDJbiZiDf/irgjqNHOXSEmxyuiLBoduR9PsoGVHEyo6/RYWkTQ2avEYb39cqwFCW+qU5LdLNRa7S0uolJ/VAH9gAY/j5qLgDps5g2qZvBARRJ5YcIaqF3qf/3TGnCn3vMj7ryvCkQ63y7ZOIZA7STsmwF9iI+9mh6z3dj1KH5vmKqB6tO31lqRHhGH9zGDnzRUKOA2hepAokWiyHI5Fyd6tJqJ6B51ehD0VtCPvkclh5Md453uj4cjpWqK5UFeadtMqIM5AyJv4KiPYAU2Gtk6nXoWyCDa4Yk0YEec4Ii6k5ItDxH
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6919.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(122000001)(316002)(38100700002)(66446008)(71200400001)(6916009)(53546011)(33656002)(5660300002)(508600001)(6486002)(6506007)(2906002)(86362001)(7416002)(91956017)(26005)(66946007)(6512007)(66556008)(2616005)(8676002)(76116006)(4326008)(64756008)(66476007)(38070700005)(8936002)(186003)(36756003)(54906003)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="iso-8859-1"
Content-ID: <11E45BD6FBCA4B44A6035FE2CD4B85AC@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6776
Original-Authentication-Results: gmail.com; dkim=none (message not signed)
 header.d=none;gmail.com; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT009.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	7931c1d4-eb0a-44af-6c1a-08d988b36b07
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	1GqW4XFjv0by59ssFhbvgeViU4SH6LuIge8u6yr+ICuTXDXzLkihP8zD/NUoeQw07nblWXM4/7Q3JngX8kq39Y5KE2+Yjsku0ARIKxQ4LO227wmdLapP1eHbULldoD+Rjd6UpGYiLwBdeHyDXhthGaO1cUVUjqUEkotPLWajhSVZlihTOL7BUbfCIX6L93nCjFq96st4/YpxtJlcDZx1y/29UgcsG3m20R5M/TBPyvjKWr8OJzgG6bnxQBVS7BK0+ql5Ec34L1a9cQJ0kTh9r7lDK/e1P27RtnfrHGmvGsb4xOztVDR4GX53occmLwxPJO9udQqLedNbHyOuPw7JztLZX5axHMuyIj7SV/aMNsvfDvlliSvkI2r1yZQ/WY778Qou/IfXc5v6PHPP5KSYSIKdGcvtxtj4vgvUhh7Id7FqutfbjgOD8lA8zWQnGRmUnKKcSanCIbFweyNYG1wqX3N1CX7OqIwICw0q76nodnMEOPH457jNBNPTR8VHfoP7aCjMXV7ZwwoZq3qGMZsmdsddNeqexgfI/OVAVAd5vDYaavP+D9FO3NXZWumx8a+y9GGogyvE+0JKjjMPkVju8BihOtsgQMf20DD7ns2ysrqj06RSr63AHQlp2H6EY3rL+v+Iq7EYBsLP8l8BoY5soGqaUGD8tPkdoZ4tqHJCWxEqAVEoSCarMzNQuSpGOlKttO0LkW2mzaxj6EAT1RnJAQ==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(508600001)(356005)(6512007)(107886003)(70586007)(70206006)(2906002)(81166007)(6486002)(54906003)(316002)(4326008)(36756003)(6506007)(33656002)(186003)(47076005)(36860700001)(26005)(53546011)(82310400003)(336012)(8936002)(86362001)(8676002)(6862004)(5660300002)(2616005);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Oct 2021 10:24:15.6791
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 36543349-8e8f-4eda-253b-08d988b372d7
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT009.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3958

Hi Oleksandr,

> On 4 Oct 2021, at 3:11 pm, Oleksandr Andrushchenko <andr2000@gmail.com> w=
rote:
>=20
> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
>=20
> Get host bridge node given a PCI device attached to it.
>=20
> This helper will be re-used for adding PCI devices by the subsequent
> patches.
>=20
> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>

Reviewed-by: Rahul Singh <rahul.singh@arm.com>
Tested-by: Rahul Singh <rahul.singh@arm.com>

Regards,
Rahul
> ---
> Since v2:
> - !! dropped Stefano's r-b because of the changes
> - s/PRI_pci/%pp after rebase onto Arm series
> ---
> xen/arch/arm/pci/pci-host-common.c | 16 ++++++++++++++++
> xen/include/asm-arm/pci.h          |  1 +
> 2 files changed, 17 insertions(+)
>=20
> diff --git a/xen/arch/arm/pci/pci-host-common.c b/xen/arch/arm/pci/pci-ho=
st-common.c
> index 593beeb48ce4..592c01aae5bb 100644
> --- a/xen/arch/arm/pci/pci-host-common.c
> +++ b/xen/arch/arm/pci/pci-host-common.c
> @@ -276,6 +276,22 @@ int pci_get_host_bridge_segment(const struct dt_devi=
ce_node *node,
>     return -EINVAL;
> }
>=20
> +/*
> + * Get host bridge node given a device attached to it.
> + */
> +struct dt_device_node *pci_find_host_bridge_node(struct device *dev)
> +{
> +    struct pci_host_bridge *bridge;
> +    struct pci_dev *pdev =3D dev_to_pci(dev);
> +
> +    bridge =3D pci_find_host_bridge(pdev->seg, pdev->bus);
> +    if ( unlikely(!bridge) )
> +    {
> +        printk(XENLOG_ERR "Unable to find PCI bridge for %pp\n", &pdev->=
sbdf);
> +        return NULL;
> +    }
> +    return bridge->dt_node;
> +}
> /*
>  * Local variables:
>  * mode: C
> diff --git a/xen/include/asm-arm/pci.h b/xen/include/asm-arm/pci.h
> index 603a1fc072d1..e6d4000e2ac8 100644
> --- a/xen/include/asm-arm/pci.h
> +++ b/xen/include/asm-arm/pci.h
> @@ -99,6 +99,7 @@ void __iomem *pci_ecam_map_bus(struct pci_host_bridge *=
bridge,
> struct pci_host_bridge *pci_find_host_bridge(uint16_t segment, uint8_t bu=
s);
> int pci_get_host_bridge_segment(const struct dt_device_node *node,
>                                 uint16_t *segment);
> +struct dt_device_node *pci_find_host_bridge_node(struct device *dev);
>=20
> static always_inline bool is_pci_passthrough_enabled(void)
> {
> --=20
> 2.25.1
>=20
>=20



From xen-devel-bounces@lists.xenproject.org Wed Oct 06 10:25:00 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Oct 2021 10:25:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.202685.357679 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mY46e-0004ak-8b; Wed, 06 Oct 2021 10:25:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 202685.357679; Wed, 06 Oct 2021 10:25:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mY46e-0004ad-4f; Wed, 06 Oct 2021 10:25:00 +0000
Received: by outflank-mailman (input) for mailman id 202685;
 Wed, 06 Oct 2021 10:24:58 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=13oh=O2=arm.com=Rahul.Singh@srs-us1.protection.inumbo.net>)
 id 1mY46c-0004aG-Ch
 for xen-devel@lists.xenproject.org; Wed, 06 Oct 2021 10:24:58 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com (unknown
 [40.107.7.70]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id a6f5c298-268f-11ec-bf57-12813bfff9fa;
 Wed, 06 Oct 2021 10:24:57 +0000 (UTC)
Received: from DBBPR09CA0010.eurprd09.prod.outlook.com (2603:10a6:10:c0::22)
 by AS8PR08MB6181.eurprd08.prod.outlook.com (2603:10a6:20b:29a::5) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.22; Wed, 6 Oct
 2021 10:24:53 +0000
Received: from DB5EUR03FT003.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:10:c0:cafe::19) by DBBPR09CA0010.outlook.office365.com
 (2603:10a6:10:c0::22) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.14 via Frontend
 Transport; Wed, 6 Oct 2021 10:24:53 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT003.mail.protection.outlook.com (10.152.20.157) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4566.14 via Frontend Transport; Wed, 6 Oct 2021 10:24:53 +0000
Received: ("Tessian outbound 2e7020cc8961:v103");
 Wed, 06 Oct 2021 10:24:53 +0000
Received: from cb861a1f410b.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 AEA43292-75C6-494E-A4C6-7341D2198B77.1; 
 Wed, 06 Oct 2021 10:24:45 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id cb861a1f410b.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Wed, 06 Oct 2021 10:24:45 +0000
Received: from AS8PR08MB6919.eurprd08.prod.outlook.com (2603:10a6:20b:39e::10)
 by AM6PR08MB4803.eurprd08.prod.outlook.com (2603:10a6:20b:c4::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.19; Wed, 6 Oct
 2021 10:24:40 +0000
Received: from AS8PR08MB6919.eurprd08.prod.outlook.com
 ([fe80::51ee:e7de:6c0a:bcf9]) by AS8PR08MB6919.eurprd08.prod.outlook.com
 ([fe80::51ee:e7de:6c0a:bcf9%7]) with mapi id 15.20.4566.023; Wed, 6 Oct 2021
 10:24:40 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a6f5c298-268f-11ec-bf57-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=IGuEWqhbYe87zQ3H3XB166o8BTmn7TOQc9TQu7yALZU=;
 b=9fOXeKGlAghPm79UG3VMz7OE49MNjsvpSgH70987sr1wYMaidHnA/KBkQo8cGKyZBCKKDzntI2qjtkzKqlFxE+/ZaGRRGjdO+0DzhrRM2pztRR2XE1D9NNvRMGVzGte4+AJoPnY2S4xFGv6l5Y4K3Sb039GOG16AazWvLTvOp+E=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 98cb9726210c6116
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ciM1fqoePA8YofBiWIEWyCBvnoOn/oa7iO6zhXj6f3m/vG6BdXIGWpA0YBYVv9Oo2NiWN4RoGk1oWiqtWLc9c55vWh+wTB48qQz3Zb/yPIVyw4oxlLN+/Lh4h4nNkMIv/KCca+mqnrrNYuzROR7LMaxjQZDBKY5+4sWXREkFdKrfnMGI4kPmSqgY8K5JfHO7mfKvO7FPxLNS7YbFsi7Re77dc0ZY9V+M3/5krqo+zWK+PKFFSUkbOIuTPBxnomoAXXqsiGn28bBZC3gRO2V5N3UUexvloFoUVKbnoV+YC7OgJMd2IpfjsEq2rX8kM7wgb68lENxjdGAzA86/IT+T0Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=IGuEWqhbYe87zQ3H3XB166o8BTmn7TOQc9TQu7yALZU=;
 b=kMvFDsyejWZj/+d6qxEZ3yFRK4V4bTtBAWZTWy3RtlXNEFKNv7oJcvyvguKz74IhNZ+9PHOMGXY01IMG5EMsyRVzVFHC7Lsk7Odg544EmH8DPiKwPp2uKA9MAh/3zDW/nWSgtbb8C0JIvYmeEmcmjmckh30V2zTcy+lG1nRnfKquhFP7+6+tAJIqTSxfnhNaZRff8mdtL9GhPQsg4Hq9xRRmCtxBrcS1/8yyvRwZwJcjjMMifqX4O1T5YQm9GcV4MireIKqGF61u/6qH3spoIjoACMipN4BqoegJcgIh1do1B0UzWiT5Q2/50z/RnVXF1tJj3ApuTVVvE9462cEwwg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=IGuEWqhbYe87zQ3H3XB166o8BTmn7TOQc9TQu7yALZU=;
 b=9fOXeKGlAghPm79UG3VMz7OE49MNjsvpSgH70987sr1wYMaidHnA/KBkQo8cGKyZBCKKDzntI2qjtkzKqlFxE+/ZaGRRGjdO+0DzhrRM2pztRR2XE1D9NNvRMGVzGte4+AJoPnY2S4xFGv6l5Y4K3Sb039GOG16AazWvLTvOp+E=
From: Rahul Singh <Rahul.Singh@arm.com>
To: Oleksandr Andrushchenko <andr2000@gmail.com>
CC: xen-devel <xen-devel@lists.xenproject.org>, Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>, "oleksandr_tyshchenko@epam.com"
	<oleksandr_tyshchenko@epam.com>, "volodymyr_babchuk@epam.com"
	<volodymyr_babchuk@epam.com>, "Artem_Mygaiev@epam.com"
	<Artem_Mygaiev@epam.com>, "roger.pau@citrix.com" <roger.pau@citrix.com>,
	"jbeulich@suse.com" <jbeulich@suse.com>, "andrew.cooper3@citrix.com"
	<andrew.cooper3@citrix.com>, "george.dunlap@citrix.com"
	<george.dunlap@citrix.com>, "paul@xen.org" <paul@xen.org>, Bertrand Marquis
	<Bertrand.Marquis@arm.com>, Oleksandr Andrushchenko
	<oleksandr_andrushchenko@epam.com>
Subject: Re: [PATCH v4 11/11] xen/arm: Process pending vPCI map/unmap
 operations
Thread-Topic: [PATCH v4 11/11] xen/arm: Process pending vPCI map/unmap
 operations
Thread-Index: AQHXuSng2klfq7Tkyke3eqid9tvkWqvFxmkA
Date: Wed, 6 Oct 2021 10:24:40 +0000
Message-ID: <0F6082D7-B252-4E10-857F-6D70748320A9@arm.com>
References: <20211004141151.132231-1-andr2000@gmail.com>
 <20211004141151.132231-12-andr2000@gmail.com>
In-Reply-To: <20211004141151.132231-12-andr2000@gmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
Authentication-Results-Original: gmail.com; dkim=none (message not signed)
 header.d=none;gmail.com; dmarc=none action=none header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: cf884641-d562-4d5e-a99a-08d988b3897a
x-ms-traffictypediagnostic: AM6PR08MB4803:|AS8PR08MB6181:
x-ms-exchange-transport-forked: True
X-Microsoft-Antispam-PRVS:
	<AS8PR08MB618161FA19B2BCF4D02F3F7EFCB09@AS8PR08MB6181.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:425;OLM:425;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 UUmQQhLvDSkcy2G6+dIVexuuu2wm3beL6ThvjhHfWE0wmdacqLmi1mjIS7eGSwoAmd0Rvd5kQVW8rbMhgQV1DDlZ3zC0Swa/FtxCcFvPHfJd2ItQqaoWImr/NfWUCp3Hbz9qGk2A/opUHsUoiJGDgF0tsY8QD0M3Fl64VxP7tw/NIz1cgYYZOr1a/riaQcuM2dfGXONGty4cqxaD0jUG0aP2x3qK//d1LIxXd37fC5vGjUUlpZuLotHTWyIZ9UE+DsFm2LEj43C1xbpmr9FrSVb3TVBrKxk3oFr7llBEm2aJ9aWX4/g/knCZLU5audiAKceu1b9GO8Tii/M1oNGojt+rJQvOjZNYEuScraeVi4pru+/qXVPIaE3K1Y+Wln1x08VvaJ4NiwAd5fklud9+Ti+KE6AgEcSh1fIwIS0RrqIVv5YpPBQa7dFhEGYZjjrn4R8+U/vivn7q0stcyEST1k7sWIUTko2b+vbPe7brwe0h4kSqDNYgN757B2naPCsM38HmZHFNCjMuNLhm8cg3021eSN9Yp1VqQ2nxJSo3z8clz5lec2M0YBx3zbY1kvnx2xqPDzkStqgcx7Hw3gD3SxqAY2upkGzGlI/1WLulahI2Jr6z2v17Vry71cLgyPtelG+zk1EnNhcBTBm1XkvZVsSC4Y8d4zXnLIiEx4dAsyfW8VfPQYgSMrDtRaJbUC0FFTWBGifjDotl4/VuicLaqdLGon0JW238sOomZVKkTfs=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6919.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(316002)(26005)(4326008)(7416002)(508600001)(2906002)(6486002)(54906003)(36756003)(6916009)(8676002)(71200400001)(33656002)(66556008)(53546011)(8936002)(66446008)(91956017)(66476007)(5660300002)(76116006)(2616005)(6506007)(83380400001)(38100700002)(86362001)(6512007)(186003)(66946007)(64756008)(122000001)(38070700005)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="us-ascii"
Content-ID: <21AEF3D1B0606C4C8AF6B1A84C465EC8@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB4803
Original-Authentication-Results: gmail.com; dkim=none (message not signed)
 header.d=none;gmail.com; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT003.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	f66101d1-3e67-4b06-f963-08d988b381b3
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	fhfbq3MayOWG2Sa7vGJITmJhDJQcFleYNUgnAu5GFRJwzV4DbnZbh0ekf1J9EzQHhxPQJqHInF2+hOZC7TNkltNDRqGQopcOs4eefLaknPS3MlG4QFI3H+OGX5ZfuwLYz0C0ngO4zZW6Ys1aKIIx1daJ4OPg4fKZ8DhrsW4Bn+fekMiWBp4dFUTJLjNXjYBRl8dbqW+7b/2RtbHjOJJyhbGLRb71ZVguxtCGfFfEir5vqGL7mz2KJRbSmyTcgNcmI7tNH5i37gaS/vQBCGKdg7aZk+ClEelgm2bBJRw6mbsEsRIbvopR96dsFjqzpeqIygyNkIuAw2T27r3q+HaRzvspsIk9fD5TbSRpK12ht6GgYWTJeQ2jdjXODgyBPPB4jrA3YRcWpKorqy86wVtezgagPCI7K5fOkiAmwD60qlISC4I75qdlX3xkDxLFH9eifzatTxJpmpII9XDP0vIttdLjNYE1PK7IC5gkPag8N4LQfNiOlmU1ZajWsuXhnzZWftM4W21TH44GyWVFfTT0cEnscqlEO2Z2JapSTIIDzLG/xKPfj2ZUiePqMoPkfG4+EuURXS3dT1zgYM2boBFZalfipHgJA7REz2iTi+FEdgcCx68Gj+AaRU9ZCa9UiiawQLQ9DE/M6zDW9YxjApIBpVsLgC8zliAFq6gwJSfKs61mViJLrNMsJYXQfzuiNYoMQltpTaaLHgrkYq/khTQ3kQ==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(36860700001)(83380400001)(186003)(33656002)(82310400003)(6862004)(5660300002)(86362001)(8676002)(336012)(6506007)(26005)(53546011)(2616005)(47076005)(8936002)(4326008)(70206006)(107886003)(70586007)(6512007)(508600001)(316002)(54906003)(2906002)(81166007)(6486002)(36756003)(356005);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Oct 2021 10:24:53.6606
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: cf884641-d562-4d5e-a99a-08d988b3897a
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT003.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6181

Hi Oleksandr,

> On 4 Oct 2021, at 3:11 pm, Oleksandr Andrushchenko <andr2000@gmail.com> w=
rote:
>=20
> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
>=20
> vPCI may map and unmap PCI device memory (BARs) being passed through whic=
h
> may take a lot of time. For this those operations may be deferred to be
> performed later, so that they can be safely preempted.
>=20
> Currently this deferred processing is happening in common IOREQ code
> which doesn't seem to be the right place for x86 and is even more
> doubtful because IOREQ may not be enabled for Arm at all.
> So, for Arm the pending vPCI work may have no chance to be executed
> if the processing is left as is in the common IOREQ code only.
> For that reason make vPCI processing happen in arch specific code.
>=20
> Please be aware that there are a few outstanding TODOs affecting this
> code path, see xen/drivers/vpci/header.c:map_range and
> xen/drivers/vpci/header.c:vpci_process_pending.
>=20
> Cc: Andrew Cooper <andrew.cooper3@citrix.com>
> Cc: Paul Durrant <paul@xen.org>
> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> [x86 changes]
> Acked-by: Jan Beulich <jbeulich@suse.com>
> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>

Reviewed-by: Rahul Singh <rahul.singh@arm.com>
Tested-by: Rahul Singh <rahul.singh@arm.com>

Regards,
Rahul
> ---
> Since v2:
> - update commit message with more insight on x86, IOREQ and Arm
> - restored order of invocation for IOREQ and vPCI processing (Jan)
> Since v1:
> - Moved the check for pending vpci work from the common IOREQ code
>   to hvm_do_resume on x86
> - Re-worked the code for Arm to ensure we don't miss pending vPCI work
> ---
> xen/arch/arm/traps.c   | 13 +++++++++++++
> xen/arch/x86/hvm/hvm.c |  6 ++++++
> xen/common/ioreq.c     |  9 ---------
> 3 files changed, 19 insertions(+), 9 deletions(-)
>=20
> diff --git a/xen/arch/arm/traps.c b/xen/arch/arm/traps.c
> index 219ab3c3fbde..b246f51086e3 100644
> --- a/xen/arch/arm/traps.c
> +++ b/xen/arch/arm/traps.c
> @@ -34,6 +34,7 @@
> #include <xen/symbols.h>
> #include <xen/version.h>
> #include <xen/virtual_region.h>
> +#include <xen/vpci.h>
>=20
> #include <public/sched.h>
> #include <public/xen.h>
> @@ -2304,6 +2305,18 @@ static bool check_for_vcpu_work(void)
>     }
> #endif
>=20
> +    if ( has_vpci(v->domain) )
> +    {
> +        bool pending;
> +
> +        local_irq_enable();
> +        pending =3D vpci_process_pending(v);
> +        local_irq_disable();
> +
> +        if ( pending )
> +            return true;
> +    }
> +
>     if ( likely(!v->arch.need_flush_to_ram) )
>         return false;
>=20
> diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c
> index aa418a3ca1b7..c491242e4b8b 100644
> --- a/xen/arch/x86/hvm/hvm.c
> +++ b/xen/arch/x86/hvm/hvm.c
> @@ -546,6 +546,12 @@ void hvm_do_resume(struct vcpu *v)
>=20
>     pt_restore_timer(v);
>=20
> +    if ( has_vpci(v->domain) && vpci_process_pending(v) )
> +    {
> +        raise_softirq(SCHEDULE_SOFTIRQ);
> +        return;
> +    }
> +
>     if ( !vcpu_ioreq_handle_completion(v) )
>         return;
>=20
> diff --git a/xen/common/ioreq.c b/xen/common/ioreq.c
> index d732dc045df9..689d256544c8 100644
> --- a/xen/common/ioreq.c
> +++ b/xen/common/ioreq.c
> @@ -25,9 +25,7 @@
> #include <xen/lib.h>
> #include <xen/paging.h>
> #include <xen/sched.h>
> -#include <xen/softirq.h>
> #include <xen/trace.h>
> -#include <xen/vpci.h>
>=20
> #include <asm/guest_atomics.h>
> #include <asm/ioreq.h>
> @@ -212,19 +210,12 @@ static bool wait_for_io(struct ioreq_vcpu *sv, iore=
q_t *p)
>=20
> bool vcpu_ioreq_handle_completion(struct vcpu *v)
> {
> -    struct domain *d =3D v->domain;
>     struct vcpu_io *vio =3D &v->io;
>     struct ioreq_server *s;
>     struct ioreq_vcpu *sv;
>     enum vio_completion completion;
>     bool res =3D true;
>=20
> -    if ( has_vpci(d) && vpci_process_pending(v) )
> -    {
> -        raise_softirq(SCHEDULE_SOFTIRQ);
> -        return false;
> -    }
> -
>     while ( (sv =3D get_pending_vcpu(v, &s)) !=3D NULL )
>         if ( !wait_for_io(sv, get_ioreq(s, v)) )
>             return false;
> --=20
> 2.25.1
>=20



From xen-devel-bounces@lists.xenproject.org Wed Oct 06 10:25:42 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Oct 2021 10:25:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.202695.357690 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mY47K-0005CF-J0; Wed, 06 Oct 2021 10:25:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 202695.357690; Wed, 06 Oct 2021 10:25:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mY47K-0005C6-Eq; Wed, 06 Oct 2021 10:25:42 +0000
Received: by outflank-mailman (input) for mailman id 202695;
 Wed, 06 Oct 2021 10:25:41 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=13oh=O2=arm.com=Rahul.Singh@srs-us1.protection.inumbo.net>)
 id 1mY47J-0005Bu-5x
 for xen-devel@lists.xenproject.org; Wed, 06 Oct 2021 10:25:41 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com (unknown
 [2a01:111:f400:fe0c::601])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 8aa5d701-ad6e-49e1-a90e-f3305cc8a59f;
 Wed, 06 Oct 2021 10:25:39 +0000 (UTC)
Received: from AS8PR04CA0119.eurprd04.prod.outlook.com (2603:10a6:20b:31e::34)
 by AM9PR08MB6786.eurprd08.prod.outlook.com (2603:10a6:20b:305::5)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18; Wed, 6 Oct
 2021 10:25:36 +0000
Received: from VE1EUR03FT043.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:31e:cafe::2) by AS8PR04CA0119.outlook.office365.com
 (2603:10a6:20b:31e::34) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.14 via Frontend
 Transport; Wed, 6 Oct 2021 10:25:36 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT043.mail.protection.outlook.com (10.152.19.122) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4566.14 via Frontend Transport; Wed, 6 Oct 2021 10:25:35 +0000
Received: ("Tessian outbound e27daf245730:v103");
 Wed, 06 Oct 2021 10:25:35 +0000
Received: from bf358820dc3b.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 2544AC5A-C5B9-4CFB-A199-222B23AF10B4.1; 
 Wed, 06 Oct 2021 10:25:26 +0000
Received: from EUR02-AM5-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id bf358820dc3b.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Wed, 06 Oct 2021 10:25:26 +0000
Received: from AS8PR08MB6919.eurprd08.prod.outlook.com (2603:10a6:20b:39e::10)
 by AS8PR08MB6776.eurprd08.prod.outlook.com (2603:10a6:20b:350::9)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.22; Wed, 6 Oct
 2021 10:25:23 +0000
Received: from AS8PR08MB6919.eurprd08.prod.outlook.com
 ([fe80::51ee:e7de:6c0a:bcf9]) by AS8PR08MB6919.eurprd08.prod.outlook.com
 ([fe80::51ee:e7de:6c0a:bcf9%7]) with mapi id 15.20.4566.023; Wed, 6 Oct 2021
 10:25:22 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8aa5d701-ad6e-49e1-a90e-f3305cc8a59f
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ae3FB2rpyT/4lXZBaiyLZGMGbJpTMT8SoEC62EmGOYE=;
 b=gTIVm1BOGra4kcF2cdylK0ZNBAx6HY375v0hZ0KurkeltxR6PJ3mSWmlf2+qMmSLJ5s5+sBK1+tJEl6tHbmc2J+J2dAJfqJlacB7AuegGtmEZqwyu/O97ePd7SiMhypzmiCyhXqMrsqDV5q6dcFRBjkMBrxmtD0b45CzHzGOBjM=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 7498e8dd08b00839
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=FyQe2kOZGRf45ZnJkJXDOXE+HL1X1qqe/qFNYHYMxOLQ2+0KTOxCDdEIMEdcnlfssAHHzioRGQqIbMa4+1x18M2oOezhyLESiP+HNVPYOpxzlCBqNGYaLoKfCoeZ/dCv3ThH8HmCSGMMgOAKa/gyJzhvTZI2X7pWu6Fgpj8w57p0mTIUUhfq9W2BQDjnvYq9CkF2t1OWMwlB/MICmbW0oQcLiYL7QT8R1bema8Q/bfE5FX5OZAmVBQhI8UP7Ufj95Toc8W6xynauE6GZ9Wv4PC5sF8v88B3uSdagSXk0TWLSCAmWyi19xisTikE4K9Ds+0Ew5Inex4lwpjViB5myPg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ae3FB2rpyT/4lXZBaiyLZGMGbJpTMT8SoEC62EmGOYE=;
 b=kpbNkb1leFYUODLWOCFyQoKqvzNWtD83cder6F06y7Xjdrd1r7HPWxIwjPJxJLXYOrd8XGC2PpXS1I37yIAuzYVNc2a9S1DJtjUHm/74qvWKa4f0s1ZdjdyJKuZ+N/+egE0XcAPH2Lvri/7Qt8PNQzv8LBC1tn6p1+myYTVyjTl6gSZYYCa5lDz2c6ZKco1iIk9KzlMgQZy3CP19QMs2tuzMbaxrm2PjfYacyqCeX4e10xwxOO1Ggz0wfEHNzyraSoa7cZ7LSeS1ivVLSVA2xjSBrP9flJT+RBzSDbclUjvh8KymeFpqeMfwfeegBz82PZjXmSDCSYYa2kQExrnpBA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ae3FB2rpyT/4lXZBaiyLZGMGbJpTMT8SoEC62EmGOYE=;
 b=gTIVm1BOGra4kcF2cdylK0ZNBAx6HY375v0hZ0KurkeltxR6PJ3mSWmlf2+qMmSLJ5s5+sBK1+tJEl6tHbmc2J+J2dAJfqJlacB7AuegGtmEZqwyu/O97ePd7SiMhypzmiCyhXqMrsqDV5q6dcFRBjkMBrxmtD0b45CzHzGOBjM=
From: Rahul Singh <Rahul.Singh@arm.com>
To: Oleksandr Andrushchenko <andr2000@gmail.com>
CC: xen-devel <xen-devel@lists.xenproject.org>, Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>, "oleksandr_tyshchenko@epam.com"
	<oleksandr_tyshchenko@epam.com>, "volodymyr_babchuk@epam.com"
	<volodymyr_babchuk@epam.com>, Artem Mygaiev <Artem_Mygaiev@epam.com>,
	=?iso-8859-1?Q?Roger_Pau_Monn=E9?= <roger.pau@citrix.com>, Jan Beulich
	<jbeulich@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>, George Dunlap
	<george.dunlap@citrix.com>, "paul@xen.org" <paul@xen.org>, Bertrand Marquis
	<Bertrand.Marquis@arm.com>, Oleksandr Andrushchenko
	<oleksandr_andrushchenko@epam.com>, Ian Jackson <iwj@xenproject.org>, Juergen
 Gross <jgross@suse.com>
Subject: Re: [PATCH v4 07/11] libxl: Allow removing PCI devices for all types
 of domains
Thread-Topic: [PATCH v4 07/11] libxl: Allow removing PCI devices for all types
 of domains
Thread-Index: AQHXuSndFv+e6OSIekuaKFO6u9L6m6vFxpwA
Date: Wed, 6 Oct 2021 10:25:22 +0000
Message-ID: <2C987D26-9566-4F5C-B10B-4C5C74E2B269@arm.com>
References: <20211004141151.132231-1-andr2000@gmail.com>
 <20211004141151.132231-8-andr2000@gmail.com>
In-Reply-To: <20211004141151.132231-8-andr2000@gmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
Authentication-Results-Original: gmail.com; dkim=none (message not signed)
 header.d=none;gmail.com; dmarc=none action=none header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: 5ed95c9f-c060-480e-3dfa-08d988b3a2ad
x-ms-traffictypediagnostic: AS8PR08MB6776:|AM9PR08MB6786:
x-ms-exchange-transport-forked: True
X-Microsoft-Antispam-PRVS:
	<AM9PR08MB6786C3F0CB9922DD03DBBD5BFCB09@AM9PR08MB6786.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:1728;OLM:1728;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 DPwrm6x4Ks+jVLAbDHz+ylfM0FZzp1bj7Jwehim5gg+MPS2ETdlO61i9w40xHJFdFQ6Yp/Z1zTbFJT4Kx9ixWFB4maqdbYx2Fg0ULeFdvbaQBh3vc15BTptecuvaNnEtneyyRl9CDy1KW9SzIaianSW8o7SlOnRk3jEIOYM67FUwPSI89cMLnVnwIqc2tFzLLdBfiLgW20z8HOR6SBFeycpkyYiP/C1LhCEHS4qEMuZuitwljanB3IkT00IgsXng/G0BFFGQhDKHoEDOTVJJ7QJrNOfCZPpfcdpbI4aOypzKD+zxRdKuSCn5DVhgsKgmC4KRX99NP9X1PJAo3JGTImvqiusWz7yIWbnpNt+0hzWldibtpzO3mkX4xvp3JdI3cDdh7rIUNYLlF9gtAm2CA1Nmznw4LWi+F8yne5STGeAZ3f4TloNXyzDGo0pGY0hWc8XWxQiA/0vu1VMQRbHVBBEw9N1WadhCFhBRdIa4YS3XhfGxDAsA8kbjjk816NA8ab+BcQE+xWHkR365M0WZb14f4/lcqXyuRMgRsNzpd/D/pMLg7pjtvXlUPghbjxohfJRskQC9nGvGPr41AjTuu+3W/LqHb/AloPP7f0sdaJCf9Gd6ud6VueQihTd2eHxeZt+0nAlKdSIbsX0YU6Tgygu5w3sKXuHS/odSkPEjdBnGsyF0JydXPaqUEhqMa0LE2Q9erT2UsvKGNR7FTHaXsJOSVrS/RobalHXp45dnbmg=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6919.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(122000001)(316002)(38100700002)(66446008)(71200400001)(6916009)(53546011)(4744005)(33656002)(5660300002)(508600001)(6486002)(6506007)(2906002)(86362001)(7416002)(91956017)(26005)(66946007)(6512007)(83380400001)(66556008)(2616005)(8676002)(76116006)(4326008)(64756008)(66476007)(38070700005)(8936002)(186003)(36756003)(54906003)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="iso-8859-1"
Content-ID: <E4FD7D0FDCAEE548932570548C6CEAE8@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6776
Original-Authentication-Results: gmail.com; dkim=none (message not signed)
 header.d=none;gmail.com; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT043.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	6aa60418-acec-4b5b-5068-08d988b39af4
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	LZ/7tcZ3O9CPPxM2p8aZRQyBh3KgD1k5iCVrlxOr8rhAi4CqR1jlVoogQ2S/Fo3Und7Gu6692Xl75xg9TC1d6C0U7DtEROdayUzHzrp0rPUFCLGQjXGhMR8UW5dP1QOLg4HrAHu3Y0N0gnnah7EKxGWq9YWjnSnKKWsqbOw2QztMtifleDiPPUGcsbFtH/z25x3NjjmtAA35tkr6N2H6sYMRB20A3bJ86Uhjyz5bRjtiO+S7xlYL10o9ILD5HIW0TAnRFM0dGlKER/RaWYh4ZWPsGv4GJ2r9Nb46kOm2SfAXO/509bgZTIDU5t9dRGgIXNdRlgTqz3OUn4VOYfcg8lfChZCkB5FtefVmu010CxaaLjtnJTp9nyXtUYhw0xC+eC3zoGmHJ7xZQUPKLYfmuVWF7bNJD0BqPMNIvwhGTcTnPE3JrNthfmt3GvrPQ/9E813l0sVchQDjKOFg7Wij4cG9ELI3mwobux9d8Izi4vW7x5ok//KWoq5Bev2lDsNCjkOq1/lgjHA3IRBrYUAD572hW6BKNWsf5zktlB5T4zCMgb8iW6LTWMC6Q+lrMusEHA0f/mvo0E9VyPzPGXnaVGQJklN5D3cLgvwOInp9HsWyZ8rSkYOuSFsskdmzdPSbAtq+OZjuPEuwonWzqjqr0vNJrIP9WKbsXGRGKS4A+MHzMJF5CYZSXjYKmaFbSuHgV5MI81K6L33/UZFkxYqURA==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(26005)(2906002)(81166007)(336012)(36756003)(8936002)(356005)(70206006)(54906003)(508600001)(86362001)(186003)(316002)(8676002)(6506007)(107886003)(6512007)(5660300002)(70586007)(53546011)(4326008)(47076005)(83380400001)(2616005)(36860700001)(6486002)(6862004)(82310400003)(33656002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Oct 2021 10:25:35.8332
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 5ed95c9f-c060-480e-3dfa-08d988b3a2ad
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT043.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB6786

Hi Oleksandr,

> On 4 Oct 2021, at 3:11 pm, Oleksandr Andrushchenko <andr2000@gmail.com> w=
rote:
>=20
> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
>=20
> The PCI device remove path may now be used by PVH on ARM, so the
> assert is no longer valid.
>=20
> Cc: Ian Jackson <iwj@xenproject.org>
> Cc: Juergen Gross <jgross@suse.com>
> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> Acked-by: Stefano Stabellini <sstabellini@kernel.org>

Reviewed-by: Rahul Singh <rahul.singh@arm.com>
Tested-by: Rahul Singh <rahul.singh@arm.com>

Regards,
Rahul
> ---
> tools/libs/light/libxl_pci.c | 2 --
> 1 file changed, 2 deletions(-)
>=20
> diff --git a/tools/libs/light/libxl_pci.c b/tools/libs/light/libxl_pci.c
> index 1a1c2630803b..59f3686fc85e 100644
> --- a/tools/libs/light/libxl_pci.c
> +++ b/tools/libs/light/libxl_pci.c
> @@ -1947,8 +1947,6 @@ static void do_pci_remove(libxl__egc *egc, pci_remo=
ve_state *prs)
>             goto out_fail;
>         }
>     } else {
> -        assert(type =3D=3D LIBXL_DOMAIN_TYPE_PV);
> -
>         char *sysfs_path =3D GCSPRINTF(SYSFS_PCI_DEV"/"PCI_BDF"/resource"=
, pci->domain,
>                                      pci->bus, pci->dev, pci->func);
>         FILE *f =3D fopen(sysfs_path, "r");
> --=20
> 2.25.1
>=20



From xen-devel-bounces@lists.xenproject.org Wed Oct 06 10:33:06 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Oct 2021 10:33:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.202705.357701 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mY4EO-0006ht-Am; Wed, 06 Oct 2021 10:33:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 202705.357701; Wed, 06 Oct 2021 10:33:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mY4EO-0006hm-71; Wed, 06 Oct 2021 10:33:00 +0000
Received: by outflank-mailman (input) for mailman id 202705;
 Wed, 06 Oct 2021 10:32:58 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=13oh=O2=arm.com=Rahul.Singh@srs-us1.protection.inumbo.net>)
 id 1mY4EM-0006hg-Ok
 for xen-devel@lists.xenproject.org; Wed, 06 Oct 2021 10:32:58 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com (unknown
 [40.107.20.83]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 405b094b-2478-4505-a622-1ec996e25e33;
 Wed, 06 Oct 2021 10:32:57 +0000 (UTC)
Received: from AS8PR04CA0139.eurprd04.prod.outlook.com (2603:10a6:20b:127::24)
 by PR2PR08MB4812.eurprd08.prod.outlook.com (2603:10a6:101:25::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.14; Wed, 6 Oct
 2021 10:32:52 +0000
Received: from VE1EUR03FT031.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:127:cafe::9a) by AS8PR04CA0139.outlook.office365.com
 (2603:10a6:20b:127::24) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.15 via Frontend
 Transport; Wed, 6 Oct 2021 10:32:52 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT031.mail.protection.outlook.com (10.152.18.69) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4566.14 via Frontend Transport; Wed, 6 Oct 2021 10:32:51 +0000
Received: ("Tessian outbound 8e26f7114b75:v103");
 Wed, 06 Oct 2021 10:32:51 +0000
Received: from fc40289d689c.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 92878B94-E8B5-49C9-AC7C-8EF6B64908E4.1; 
 Wed, 06 Oct 2021 10:32:41 +0000
Received: from EUR01-VE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id fc40289d689c.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Wed, 06 Oct 2021 10:32:41 +0000
Received: from AS8PR08MB6919.eurprd08.prod.outlook.com (2603:10a6:20b:39e::10)
 by AS8PR08MB6295.eurprd08.prod.outlook.com (2603:10a6:20b:295::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.22; Wed, 6 Oct
 2021 10:32:38 +0000
Received: from AS8PR08MB6919.eurprd08.prod.outlook.com
 ([fe80::51ee:e7de:6c0a:bcf9]) by AS8PR08MB6919.eurprd08.prod.outlook.com
 ([fe80::51ee:e7de:6c0a:bcf9%7]) with mapi id 15.20.4566.023; Wed, 6 Oct 2021
 10:32:38 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 405b094b-2478-4505-a622-1ec996e25e33
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=MYlKb19k6G+jjBlNhWheETaiq+KnOR8gjF/VO8Id4ak=;
 b=jJ5S8FCeRkiW9zFnsWLxfJF7G7ByodFKuLiLkazygV2yX0O5sBOHfD/mJ2HF1j9LCDcWnZeA4hNYQwbU9XXgF1MEhTli1I3i+ZG4rEEjp75rHBPZtPK2j0lNN1ZvGEHfy3QRKw9xTGLbIoQ0aCRKu/0jeHpfvvcBHQMUWnlmr4I=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: b4880f216777cfff
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=T1qf7BmmYGc1f77mv1c3O+GMomt8sMfrBDNu/BYROF6EnRFyhUYtieFdOP6FT0JmN+At89iqZ651hoRh3WBXJtWYD1ogOFEuMl3VUN8HbcUOghuF4UfKDplk9TotrH1jvRHhhce607JLJNeo2C06JbgW+zLLMITWlP5hwuOSCOY2gOT/xMNbUAC7lO88NFP7QKhfPAKd2NE8o6STKTScty3hyNbkEdksqzAFqfU+2SnGp2iP3qp319cUE0XGdPvH2LHtJhPlRr6ino1xeiTiV422FHcr1JFheJ6GnYhI4k6Zm0jnhH8b2rGF+ojvLpZJJlvsDgnjSPh9r+2ateXVGA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=MYlKb19k6G+jjBlNhWheETaiq+KnOR8gjF/VO8Id4ak=;
 b=Zcap6jDOvIP6XSLX6xQi3mAsee+kYLoi7uX8+Bf3BdNBa9LwB35hpZbjlIbtjg9F9s84XizgLkvCthHDr+DdLP29tEU+KsQuDq4gKguMQb19McwsRQydRKAazes2JbkWBj4/4XDDGjavFhgg3TzCOfaV+2cIozeb8Vpl2jMWTWTATFFKPtKpX2JvWyE6zNI1p0STgDKLG6TA7Yx++FXQRwfXJrhP6ddJN8jEkhAXS3uKCRwRYJHD8lLG5n6+MbCX0bsbwh1zNkiW0jRdFjyM7RG/K+yq3uEEtqJQ6f2X3xTx7lCmSdqWLcWDLQ1Xx4uLx4xonOywTZwJmJL7tGHLSg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=MYlKb19k6G+jjBlNhWheETaiq+KnOR8gjF/VO8Id4ak=;
 b=jJ5S8FCeRkiW9zFnsWLxfJF7G7ByodFKuLiLkazygV2yX0O5sBOHfD/mJ2HF1j9LCDcWnZeA4hNYQwbU9XXgF1MEhTli1I3i+ZG4rEEjp75rHBPZtPK2j0lNN1ZvGEHfy3QRKw9xTGLbIoQ0aCRKu/0jeHpfvvcBHQMUWnlmr4I=
From: Rahul Singh <Rahul.Singh@arm.com>
To: Oleksandr Andrushchenko <andr2000@gmail.com>
CC: xen-devel <xen-devel@lists.xenproject.org>, Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>, "oleksandr_tyshchenko@epam.com"
	<oleksandr_tyshchenko@epam.com>, "volodymyr_babchuk@epam.com"
	<volodymyr_babchuk@epam.com>, "Artem_Mygaiev@epam.com"
	<Artem_Mygaiev@epam.com>, "roger.pau@citrix.com" <roger.pau@citrix.com>,
	"jbeulich@suse.com" <jbeulich@suse.com>, "andrew.cooper3@citrix.com"
	<andrew.cooper3@citrix.com>, "george.dunlap@citrix.com"
	<george.dunlap@citrix.com>, "paul@xen.org" <paul@xen.org>, Bertrand Marquis
	<Bertrand.Marquis@arm.com>, Oleksandr Andrushchenko
	<oleksandr_andrushchenko@epam.com>
Subject: Re: [PATCH v4 04/11] xen/device-tree: Make dt_find_node_by_phandle
 global
Thread-Topic: [PATCH v4 04/11] xen/device-tree: Make dt_find_node_by_phandle
 global
Thread-Index: AQHXuSnUS32qWIPSZk+UemyYVvX79KvFyKMA
Date: Wed, 6 Oct 2021 10:32:38 +0000
Message-ID: <BE63A8A7-21DF-433B-A879-E3253767C72F@arm.com>
References: <20211004141151.132231-1-andr2000@gmail.com>
 <20211004141151.132231-5-andr2000@gmail.com>
In-Reply-To: <20211004141151.132231-5-andr2000@gmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
Authentication-Results-Original: gmail.com; dkim=none (message not signed)
 header.d=none;gmail.com; dmarc=none action=none header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: 4e834797-301d-4622-4a90-08d988b4a67d
x-ms-traffictypediagnostic: AS8PR08MB6295:|PR2PR08MB4812:
x-ms-exchange-transport-forked: True
X-Microsoft-Antispam-PRVS:
	<PR2PR08MB481255C551F6CDD628141FF7FCB09@PR2PR08MB4812.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:4125;OLM:4125;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 LrSbZ5aLtkVJL3EcG+YAeMn7HpbGa3K0M3jLHa6zdBdhQmw4591cSO7zCLPCcebn+MlMOSDTutBoBq9iSo4+dknYWaYnIgrKOIzKfaFSfNmZhvaktQGmyjHLeZOBjAdGB4IOBayaKk8BlwTfaFww1OWMHmTFNopw43gZ8Gmpc2sbTZDZAbw97JTb0LKZOap7/6KB2J7pJQo2XBEhqULqQKEJc8sZxHijbzNfAO+zseeAeFWB5lzp9G1KXUQChMPeIZpRlCLCsqGjcU7cD4kywk9drrFy7Dn7l+2OPALXgIp3UXg3ZDb++CiyOFkehTWF6lBZ2E33sFd7lBZZqDPFiqYuMdZrB9S+6MGI7rR35NUQOZRTJa+geVLqUDanvqzjWDRjgFqQiIWCdllKoXkqPPJiuGUOMR2dpvr99swZLSiHSIN0djO0+5ObHBABZRblt3HxMMuhtM1DEHQBuBlp8dtKpj9+wF3VO58BGMrBaqCgz1h+Pp/b+DX5Ik66U+rjFLgli51S3nbGRii8gFbf9NJeCktS6WVF5iLxPcL6UdjQLytf3oNeO+RSVZJLX5Cw/g/DR50cFI3OKdxoXL9odEQQb+YXlREdFsm3WktJXiTwGTDiWx8ZBxVIRgy1LEb/M/P8qxjygUtIiqcuEO/DnYvwZDukDVvv380IQh+Ylz4Y2uW5Dxz4t9xPuRRu0oDZvcVUzbpa6QBXif7MkUn9N9PWDIJouSgPBytP32Qhzcpp/FGdKYt01mKoUCKwdDKA
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6919.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(83380400001)(6486002)(2906002)(38070700005)(86362001)(33656002)(5660300002)(4326008)(186003)(508600001)(122000001)(76116006)(36756003)(66446008)(66946007)(8676002)(6916009)(316002)(26005)(38100700002)(6506007)(53546011)(6512007)(91956017)(7416002)(71200400001)(2616005)(64756008)(66476007)(54906003)(8936002)(66556008)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="us-ascii"
Content-ID: <768B4540D8C09D44AAC82B3D603C934E@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6295
Original-Authentication-Results: gmail.com; dkim=none (message not signed)
 header.d=none;gmail.com; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT031.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	1d6efad9-7d26-4c96-3b25-08d988b49eb4
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	VLv8Bm/MhO3Lc0XaGa9Ui7AZrWqjiNiy09uavN1zLZUzNwx4mMjuevOd9LgFlJSTNViW1WXnmTOu4sQzl3PyvaW5pkaHeS+qeZu8WtUqlUib/aTlJ83UrYwS2Yn2K7+ykiNDJSZy/OAlSJehXcSArENAcl/6WXMsH1XAKUrEHnmdXtTwDbJQJAc+YRxVBe0AeMv9vZ2edWOWvxIGEX9lDdFT8GSrTyz1xRgkbn/ovbc8lfYen+dT0RVb5SsmrNWazKUctLLn0kVEf9CnD2UOLJWlrcARfp4okcEIq2oNbrjmky50qmOWVpbuljkCvjLqbOHi51x71W5Xh4ZxuBwd06phX21r+WCEjk8uiEMeBLIb8B9/JDqCloaVCeuZ2rfBob9AdXtGjnghnTaWCtyNldyEnI6eWezczD21JMnRoUjatADJfx7xF3ykqAsk7aHBJ4DMpPEGqSUcETGDybtTDh+OLYG9YUdLJSfOwt4qwR5YHGURaypqvdga1izjo3nNhUmWQI5mIqUOMn/mhvbwSfMqMPc2vNoulCjAh1iRiKOBoefZWXA2nwR+dSJ4siTfa4ypXQF1Ovrt5jIB8h1PUkoyvy4cQ7b2a8fvmy7G505Hag4djiX20+xTfNARLpFMLfUNnAov8p6DMqySShegasrDS25e5fZL0UEJOmNcVR6wlI1zTRaysd8/nuL0cxWAmWK/AYJjegPGklKJPYKO0g==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(6862004)(2616005)(2906002)(8936002)(70206006)(83380400001)(70586007)(6486002)(356005)(8676002)(508600001)(107886003)(336012)(36756003)(81166007)(316002)(186003)(5660300002)(86362001)(54906003)(33656002)(82310400003)(4326008)(47076005)(36860700001)(26005)(53546011)(6506007)(6512007);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Oct 2021 10:32:51.7256
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 4e834797-301d-4622-4a90-08d988b4a67d
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT031.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR2PR08MB4812

Hi Oleksandr,

> On 4 Oct 2021, at 3:11 pm, Oleksandr Andrushchenko <andr2000@gmail.com> w=
rote:
>=20
> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
>=20
> Make dt_find_node_by_phandle globally visible, so it can be re-used by
> other frameworks.
>=20
> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>

Reviewed-by: Rahul Singh <rahul.singh@arm.com>
Tested-by: Rahul Singh <rahul.singh@arm.com>

Regards,
Rahul
> ---
> xen/common/device_tree.c      | 2 +-
> xen/include/xen/device_tree.h | 2 ++
> 2 files changed, 3 insertions(+), 1 deletion(-)
>=20
> diff --git a/xen/common/device_tree.c b/xen/common/device_tree.c
> index ea93da1725f6..4aae281e89bf 100644
> --- a/xen/common/device_tree.c
> +++ b/xen/common/device_tree.c
> @@ -1047,7 +1047,7 @@ int dt_for_each_range(const struct dt_device_node *=
dev,
>  *
>  * Returns a node pointer.
>  */
> -static struct dt_device_node *dt_find_node_by_phandle(dt_phandle handle)
> +struct dt_device_node *dt_find_node_by_phandle(dt_phandle handle)
> {
>     struct dt_device_node *np;
>=20
> diff --git a/xen/include/xen/device_tree.h b/xen/include/xen/device_tree.=
h
> index 2297c59ce66d..fd6cd00b433a 100644
> --- a/xen/include/xen/device_tree.h
> +++ b/xen/include/xen/device_tree.h
> @@ -849,6 +849,8 @@ int dt_count_phandle_with_args(const struct dt_device=
_node *np,
>  */
> int dt_get_pci_domain_nr(struct dt_device_node *node);
>=20
> +struct dt_device_node *dt_find_node_by_phandle(dt_phandle handle);
> +
> #ifdef CONFIG_DEVICE_TREE_DEBUG
> #define dt_dprintk(fmt, args...)  \
>     printk(XENLOG_DEBUG fmt, ## args)
> --=20
> 2.25.1
>=20



From xen-devel-bounces@lists.xenproject.org Wed Oct 06 10:33:58 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Oct 2021 10:33:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.202714.357712 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mY4FJ-0007MR-Pg; Wed, 06 Oct 2021 10:33:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 202714.357712; Wed, 06 Oct 2021 10:33:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mY4FJ-0007MK-LZ; Wed, 06 Oct 2021 10:33:57 +0000
Received: by outflank-mailman (input) for mailman id 202714;
 Wed, 06 Oct 2021 10:33:56 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=13oh=O2=arm.com=Rahul.Singh@srs-us1.protection.inumbo.net>)
 id 1mY4FI-0007M5-7B
 for xen-devel@lists.xenproject.org; Wed, 06 Oct 2021 10:33:56 +0000
Received: from EUR02-VE1-obe.outbound.protection.outlook.com (unknown
 [2a01:111:f400:fe06::60c])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 75005b79-3f6c-4684-a833-c6c636cf90eb;
 Wed, 06 Oct 2021 10:33:54 +0000 (UTC)
Received: from AS9PR06CA0030.eurprd06.prod.outlook.com (2603:10a6:20b:462::35)
 by DB9PR08MB6394.eurprd08.prod.outlook.com (2603:10a6:10:25b::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.19; Wed, 6 Oct
 2021 10:33:39 +0000
Received: from VE1EUR03FT051.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:462:cafe::67) by AS9PR06CA0030.outlook.office365.com
 (2603:10a6:20b:462::35) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.16 via Frontend
 Transport; Wed, 6 Oct 2021 10:33:38 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT051.mail.protection.outlook.com (10.152.19.75) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4566.14 via Frontend Transport; Wed, 6 Oct 2021 10:33:38 +0000
Received: ("Tessian outbound a8bfe25d7364:v103");
 Wed, 06 Oct 2021 10:33:38 +0000
Received: from 76091214e247.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 E7A50BC7-0972-43D0-9F2E-A75B5E5D5C14.1; 
 Wed, 06 Oct 2021 10:33:28 +0000
Received: from EUR01-VE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 76091214e247.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Wed, 06 Oct 2021 10:33:28 +0000
Received: from AS8PR08MB6919.eurprd08.prod.outlook.com (2603:10a6:20b:39e::10)
 by AS8PR08MB6295.eurprd08.prod.outlook.com (2603:10a6:20b:295::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.22; Wed, 6 Oct
 2021 10:33:26 +0000
Received: from AS8PR08MB6919.eurprd08.prod.outlook.com
 ([fe80::51ee:e7de:6c0a:bcf9]) by AS8PR08MB6919.eurprd08.prod.outlook.com
 ([fe80::51ee:e7de:6c0a:bcf9%7]) with mapi id 15.20.4566.023; Wed, 6 Oct 2021
 10:33:26 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 75005b79-3f6c-4684-a833-c6c636cf90eb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=MfyxK1MI+C5wxh9crqmrSeuy3mwY834Ev4S35PnVlmQ=;
 b=G8aouUFZ3OGd5uUNo1S++rbP2tAGp+EWLxc5r0f+FnZ5YK0T2s4XQ9kOH9y1ilPEotIhUoBfC2IjLNWn3hv46FY/tGY/mRrrHQHWxlfwpgpOkv+Mbks1Mcr1J7mmBMoJI7kM6yJbvk5/lK4VPllbk+9upxIPZjJXUDLBRpI1+wc=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 10026ad6ad8b1898
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=blpv3tbyS8Z40FdPzgMZPhLb578NzPUrTjIg7xfzFUzw2acROK97mNhaptJRlcw/j8VbFdTElqjHQQSXncuwYHQOzvIbr0P6mpv50Yy9A483mYudUIMzVeb6+wGIl40nJ6X/bAzNLbE++Wmfib6NlBEQZMHBbzQBoEs1GgQHPRS6L1jdpUgqqBhvL1DqIslw3LGfJKVPA1tX7ZLSkhu2wWrb2MiCGWWDW2uCRIm3pImLH1lbz+o9en6Gq63pSwwYc1gKlgdyCVwnKsuV/xLwtfBmcYjXqW+HBEpiEInYl9Q+OrQJPKlbkCjx2xXQXqHfH1eAseP/Sfq3gYxKkUhxzQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=MfyxK1MI+C5wxh9crqmrSeuy3mwY834Ev4S35PnVlmQ=;
 b=hHhca9T9q1iZPr5yxXPGi5AbVAAMmeOJWGn+YKqgfLP3U7/aZjDjzvY3/DlZlO5V25hticZh6ZroKVnonABPJYo4J64wXJXTYBpOYpTygedNVWakMBJyZtHG4GIANwk2uMojhNOr8GsqmD0GAlwGZaT/J1DAdcLkdouNjQWv+8kQ19KnU437BnhAMoTg5Q21mTGNgc15I0DyQOv+w0Yof6sRmnHSC472tgSxEDrj6ofTmXZZaw0FY+5/RzvzCT3Gc+GNgwtdUcqq1RJCLy3n+uOKrt7/uWvSdXS8Q2CeNQZJOjYJmi2DGVvcz73wNCzDKlwNqCKz9r+A2MnAOthn7A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=MfyxK1MI+C5wxh9crqmrSeuy3mwY834Ev4S35PnVlmQ=;
 b=G8aouUFZ3OGd5uUNo1S++rbP2tAGp+EWLxc5r0f+FnZ5YK0T2s4XQ9kOH9y1ilPEotIhUoBfC2IjLNWn3hv46FY/tGY/mRrrHQHWxlfwpgpOkv+Mbks1Mcr1J7mmBMoJI7kM6yJbvk5/lK4VPllbk+9upxIPZjJXUDLBRpI1+wc=
From: Rahul Singh <Rahul.Singh@arm.com>
To: Oleksandr Andrushchenko <andr2000@gmail.com>
CC: xen-devel <xen-devel@lists.xenproject.org>, Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>, "oleksandr_tyshchenko@epam.com"
	<oleksandr_tyshchenko@epam.com>, "volodymyr_babchuk@epam.com"
	<volodymyr_babchuk@epam.com>, "Artem_Mygaiev@epam.com"
	<Artem_Mygaiev@epam.com>, "roger.pau@citrix.com" <roger.pau@citrix.com>,
	"jbeulich@suse.com" <jbeulich@suse.com>, "andrew.cooper3@citrix.com"
	<andrew.cooper3@citrix.com>, "george.dunlap@citrix.com"
	<george.dunlap@citrix.com>, "paul@xen.org" <paul@xen.org>, Bertrand Marquis
	<Bertrand.Marquis@arm.com>, Oleksandr Andrushchenko
	<oleksandr_andrushchenko@epam.com>
Subject: Re: [PATCH v4 05/11] xen/arm: Mark device as PCI while creating one
Thread-Topic: [PATCH v4 05/11] xen/arm: Mark device as PCI while creating one
Thread-Index: AQHXuSnU8lwk1ustVUiU0ubosHwi/6vFyNuA
Date: Wed, 6 Oct 2021 10:33:25 +0000
Message-ID: <9961E2F7-86E9-410A-9C55-EF1016E4E9B4@arm.com>
References: <20211004141151.132231-1-andr2000@gmail.com>
 <20211004141151.132231-6-andr2000@gmail.com>
In-Reply-To: <20211004141151.132231-6-andr2000@gmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
Authentication-Results-Original: gmail.com; dkim=none (message not signed)
 header.d=none;gmail.com; dmarc=none action=none header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: 32dced6a-bcbd-442a-0249-08d988b4c25e
x-ms-traffictypediagnostic: AS8PR08MB6295:|DB9PR08MB6394:
x-ms-exchange-transport-forked: True
X-Microsoft-Antispam-PRVS:
	<DB9PR08MB6394D3B8CB6834D9D7963EB2FCB09@DB9PR08MB6394.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:4303;OLM:4303;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 +cXmMryUnF6YRGUHeN7ygUpS92M6sef8meveAAzWxanm72qMS6WvurTNV0s8wKsqAny/+HY9Nu8Rj6bR6F8TnVNHf9EJvAwfOwh7L/RX0LI5dCvfrS4fd+OOAa016bQ7xQVaL6QCTz5q9mP0d73cx+4jwk5rFzjZYmIShxmuPyRQQD4x/YNoW/Yf4nRhVH28YdZuUPqMUMqW4YkIGuksOgTTDz0tikHgeYBOWos7XukOUC1KvaKlWTQgIgE63wINHjdgzrHh4egpkkbXufhoxLoAIWaqzAVgew5Z1aLNNn+yUkdk2W55QFz0/ncdPbaLyHTvt9jP9+as50R2Y0Ac7YkRXMll6nj043K9TgawdE0x2cZLaSv6BT42QWv/5SBZqVt/vOwumaBpqIyfThPQdKmla8WI3yRHZmE1gQagntHdcAw4u+EWnrRyr2a03dcQkYXClfFhIkX+V0rMe4v+s+lJezrUTJUD6XSYeattmJBCMAG1v4UvJmwjVI5r1xxJmoKnqcHg7XiC2ilf+93p92ohAq7PfqqDWp13SlEiPiWF8TCfbJ3oBLH/XuDN3IUMqQm/g6GznOomopGwN/5vMRz7YSmsCK84/pD2ChFdrWPiJZW6z1ZXtXifal603D0l45DTVfbtqFZIWNd/UQEyM8/a2dxyHdpgk545NnZEGBYdiy1W6dLOsbuD4mQjLmalurqNgj7kJEwUySpwe4H5JmMrJXXZ5zdaKazJduhaHws=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6919.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(6486002)(2906002)(38070700005)(86362001)(33656002)(5660300002)(4326008)(186003)(508600001)(122000001)(76116006)(36756003)(66446008)(66946007)(8676002)(6916009)(316002)(26005)(38100700002)(6506007)(53546011)(6512007)(91956017)(7416002)(71200400001)(2616005)(64756008)(66476007)(54906003)(8936002)(66556008)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="us-ascii"
Content-ID: <03708749A0976F41ADA533213ACDBDBA@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6295
Original-Authentication-Results: gmail.com; dkim=none (message not signed)
 header.d=none;gmail.com; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT051.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	ee8b7ced-3a65-4fc7-d6b4-08d988b4bae1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	s1TozUR0FqKjroZk9kZqVKZbpoHtAMs24/u10JoOHHwxpILvR4OdvAUjrZoLTn1rVvkHOu8CzwNvdFQDTibc/VYQeTc+6iGisRiMhA/Q3GRjlE1wn40XIkA3O/hy5FFHNMEOtFFXF6Nnt26VUXsCK7PY1AKL5WpaPGP17LjIq/QD9Ufc3dkrdvefZkx+QZW1EvIZwJFRRADmiDdcLmuS/+32D4qYoZpoDWznxY7IQZaVSN0TnlBuDLR1BswRMrxfUA9pHqfrXaJOsyOYoLARj3XzB9bYwlyjTIl5tkCf7PmydmYR3faBhzIxPHRaASON7zLR1fq8SGj+xdTCZygbko1uxeFSop1YeXivr2vWvxUJ9B4mNcCva2Fjld/qpHQtjwjNGiJ1Di5Xed9ykmZwJmLJ4oQpXYYRqoh/M7/2aZzCYW3nzdAt50GX67mMfVtXYZZIiJ4o5Q/H4hDsVJ/AbKKilTxLUlj3xOiqX8LirnYz/YTGxrwVP8rM4xINHtnYUQpFvSDR69hsy52jdVHNoY0YuFqlvUgKMEUUukDcppo1AFV1JiNk1P8Ip30Uh8o2WywE3LUfdGoyekUNM8WdHqE8QZOlDmM/p9rErxrUsfEAQNjNQd3EdjaFFQFr8rHjijxZJYKuv6VICfCUTGqxukB13q3OC8h+e3rsz1I+McklXKK586lZj5Ni6AvaSZbc1hcsfUWNpJXsEuBW/7LZbw==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(107886003)(36860700001)(36756003)(508600001)(356005)(2616005)(86362001)(33656002)(6862004)(81166007)(5660300002)(6512007)(336012)(8936002)(2906002)(4326008)(70586007)(6486002)(47076005)(82310400003)(186003)(54906003)(316002)(8676002)(53546011)(6506007)(26005)(70206006);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Oct 2021 10:33:38.4979
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 32dced6a-bcbd-442a-0249-08d988b4c25e
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT051.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB6394

Hi Oleksandr,

> On 4 Oct 2021, at 3:11 pm, Oleksandr Andrushchenko <andr2000@gmail.com> w=
rote:
>=20
> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
>=20
> While adding a PCI device mark it as such, so other frameworks
> can distinguish it from DT devices.
> For that introduce an architecture defined helper which may perform
> additional initialization of the newly created PCI device.
>=20
> Cc: Andrew Cooper <andrew.cooper3@citrix.com>
> Cc: Paul Durrant <paul@xen.org>
> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> [applicable parts]
> Acked-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: Rahul Singh <rahul.singh@arm.com>
Tested-by: Rahul Singh <rahul.singh@arm.com>

Regards,
Rahul

> ---
> Since v3:
> - fixed Arm build without CONFIG_HAS_PCI
> Since v2:
> - !! dropped Stefano's r-b because of the changes
> - introduced arch_pci_init_pdev (Jan)
> Since v1:
> - moved the assignment from iommu_add_device to alloc_pdev
> ---
> xen/arch/arm/pci/pci.c        | 5 +++++
> xen/drivers/passthrough/pci.c | 2 ++
> xen/include/asm-arm/pci.h     | 7 +++++++
> xen/include/asm-x86/pci.h     | 2 ++
> 4 files changed, 16 insertions(+)
>=20
> diff --git a/xen/arch/arm/pci/pci.c b/xen/arch/arm/pci/pci.c
> index 138da19284ab..082c14e127a8 100644
> --- a/xen/arch/arm/pci/pci.c
> +++ b/xen/arch/arm/pci/pci.c
> @@ -34,6 +34,11 @@ struct pci_dev *dev_to_pci(struct device *dev)
>     return container_of(dev, struct pci_dev, arch.dev);
> }
>=20
> +void arch_pci_init_pdev(struct pci_dev *pdev)
> +{
> +    pci_to_dev(pdev)->type =3D DEV_PCI;
> +}
> +
> static int __init dt_pci_init(void)
> {
>     struct dt_device_node *np;
> diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci.=
c
> index b36d5a481162..9e6246afeef5 100644
> --- a/xen/drivers/passthrough/pci.c
> +++ b/xen/drivers/passthrough/pci.c
> @@ -329,6 +329,8 @@ static struct pci_dev *alloc_pdev(struct pci_seg *pse=
g, u8 bus, u8 devfn)
>     *((u8*) &pdev->devfn) =3D devfn;
>     pdev->domain =3D NULL;
>=20
> +    arch_pci_init_pdev(pdev);
> +
>     rc =3D pdev_msi_init(pdev);
>     if ( rc )
>     {
> diff --git a/xen/include/asm-arm/pci.h b/xen/include/asm-arm/pci.h
> index e6d4000e2ac8..ea87ec6006fc 100644
> --- a/xen/include/asm-arm/pci.h
> +++ b/xen/include/asm-arm/pci.h
> @@ -105,6 +105,9 @@ static always_inline bool is_pci_passthrough_enabled(=
void)
> {
>     return pci_passthrough_enabled;
> }
> +
> +void arch_pci_init_pdev(struct pci_dev *pdev);
> +
> #else   /*!CONFIG_HAS_PCI*/
>=20
> struct arch_pci_dev { };
> @@ -121,5 +124,9 @@ static inline int pci_get_host_bridge_segment(const s=
truct dt_device_node *node,
>     return -EINVAL;
> }
>=20
> +struct pci_dev;
> +
> +static inline void arch_pci_init_pdev(struct pci_dev *pdev) {}
> +
> #endif  /*!CONFIG_HAS_PCI*/
> #endif /* __ARM_PCI_H__ */
> diff --git a/xen/include/asm-x86/pci.h b/xen/include/asm-x86/pci.h
> index c4a4fdcbc239..443f25347d08 100644
> --- a/xen/include/asm-x86/pci.h
> +++ b/xen/include/asm-x86/pci.h
> @@ -36,4 +36,6 @@ static always_inline bool is_pci_passthrough_enabled(vo=
id)
>     return true;
> }
>=20
> +static inline void arch_pci_init_pdev(struct pci_dev *pdev) {}
> +
> #endif /* __X86_PCI_H__ */
> --=20
> 2.25.1
>=20



From xen-devel-bounces@lists.xenproject.org Wed Oct 06 10:35:44 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Oct 2021 10:35:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.202724.357723 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mY4H2-00080P-4s; Wed, 06 Oct 2021 10:35:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 202724.357723; Wed, 06 Oct 2021 10:35:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mY4H2-00080I-1d; Wed, 06 Oct 2021 10:35:44 +0000
Received: by outflank-mailman (input) for mailman id 202724;
 Wed, 06 Oct 2021 10:35:43 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=13oh=O2=arm.com=Rahul.Singh@srs-us1.protection.inumbo.net>)
 id 1mY4H0-000808-Td
 for xen-devel@lists.xenproject.org; Wed, 06 Oct 2021 10:35:42 +0000
Received: from EUR03-AM5-obe.outbound.protection.outlook.com (unknown
 [40.107.3.44]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 2699af4b-2691-11ec-bf58-12813bfff9fa;
 Wed, 06 Oct 2021 10:35:41 +0000 (UTC)
Received: from AM5PR1001CA0005.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:206:2::18)
 by VI1PR08MB4397.eurprd08.prod.outlook.com (2603:10a6:803:f9::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18; Wed, 6 Oct
 2021 10:35:39 +0000
Received: from VE1EUR03FT010.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:206:2:cafe::ce) by AM5PR1001CA0005.outlook.office365.com
 (2603:10a6:206:2::18) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18 via Frontend
 Transport; Wed, 6 Oct 2021 10:35:39 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT010.mail.protection.outlook.com (10.152.18.113) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4566.14 via Frontend Transport; Wed, 6 Oct 2021 10:35:38 +0000
Received: ("Tessian outbound b9598e0ead92:v103");
 Wed, 06 Oct 2021 10:35:38 +0000
Received: from fc3f9b734dc2.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 C38265DB-321B-4DD7-A02A-12337E4D8F4A.1; 
 Wed, 06 Oct 2021 10:35:28 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id fc3f9b734dc2.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Wed, 06 Oct 2021 10:35:28 +0000
Received: from AS8PR08MB6919.eurprd08.prod.outlook.com (2603:10a6:20b:39e::10)
 by AS8PR08MB6007.eurprd08.prod.outlook.com (2603:10a6:20b:29e::15)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.22; Wed, 6 Oct
 2021 10:35:23 +0000
Received: from AS8PR08MB6919.eurprd08.prod.outlook.com
 ([fe80::51ee:e7de:6c0a:bcf9]) by AS8PR08MB6919.eurprd08.prod.outlook.com
 ([fe80::51ee:e7de:6c0a:bcf9%7]) with mapi id 15.20.4566.023; Wed, 6 Oct 2021
 10:35:23 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2699af4b-2691-11ec-bf58-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=FFfEkXibDGx+sdiXSgcsc4LfpmLdbfaAPug/eDcPprc=;
 b=9DcpKwcuo7BjmjFvM5glonHk+qLPLMyAJuv9ajw3VQ7N8Xk6NCly9BBUb0mYcdaLVCZGPX/Cb4iplgqUOb82kpr6O6bLz7d+VduvYAcd1RwWeRh7c7M7q7THRgnQy+woxLyEl1NIbKvhxc0sJvLPgsiphIelpcqdAPk5h4UHFDY=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 60a5dc50d35b4a4d
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=TCoQyFs7IyiUO1+K3cmJ+SezymTPkrXMEayN+Qg9+m29k0o5SU3mSsy32kF9i99qkKyNiYGZBJkpXrhSNyNGliMBm4JyQ8JfIxlJbwfIx6Rym8BHg41lS6zzu3JZsz9VyJHW/HCTB1xmBh1GpXuy5kV3Ce2WHD0uT1yOW+s3qGzM1YnrO3Lb363oXp3kUxUEWg5jLIJzTg5nD2Yr878uR8mnBxHaOtnXfO1kcwWJxYry7+ZnStNjyOkiEdo+A8HGGfQjDGwIz/ZNCgnGOp2qXyARYj74wiHRXmXSudwTxY3+mZm5GGv9WkcuAWdPPyXYBkWkazU2b1YUc04IgCA7IQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=FFfEkXibDGx+sdiXSgcsc4LfpmLdbfaAPug/eDcPprc=;
 b=YyrlESHjbd2skXqguEHFq5wQus4lAvxEgBWqvh0hQ3HGK0QaffQJze0PKYCuG2eqwzgppLgMe3WrRDqMjyfWAtDkctlJBXjjnBHr03aT94U5lIViYAPvavSpxkJOAhqN5yUS5tLAqwX7BsPySZmS19H9X9ZE8MafP70OpkiNtsaRJ+FjFoD2PP1fD1bp4CXZ4dIs3ShEN97rf0Fov3rfdN8S6Be8sestnIjDBN+eajcZovzrcSarbcwnvG/A/WOmJGHGDtEiS57y5dR19HLh1hkcdpIBb4e8+dtSmqtH76CSoZcUp0FikWP58FyKjmm/vc6+ruXLoMPfY0SlBdnusg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=FFfEkXibDGx+sdiXSgcsc4LfpmLdbfaAPug/eDcPprc=;
 b=9DcpKwcuo7BjmjFvM5glonHk+qLPLMyAJuv9ajw3VQ7N8Xk6NCly9BBUb0mYcdaLVCZGPX/Cb4iplgqUOb82kpr6O6bLz7d+VduvYAcd1RwWeRh7c7M7q7THRgnQy+woxLyEl1NIbKvhxc0sJvLPgsiphIelpcqdAPk5h4UHFDY=
From: Rahul Singh <Rahul.Singh@arm.com>
To: Oleksandr Andrushchenko <andr2000@gmail.com>
CC: xen-devel <xen-devel@lists.xenproject.org>, Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>, "oleksandr_tyshchenko@epam.com"
	<oleksandr_tyshchenko@epam.com>, "volodymyr_babchuk@epam.com"
	<volodymyr_babchuk@epam.com>, "Artem_Mygaiev@epam.com"
	<Artem_Mygaiev@epam.com>, "roger.pau@citrix.com" <roger.pau@citrix.com>,
	"jbeulich@suse.com" <jbeulich@suse.com>, "andrew.cooper3@citrix.com"
	<andrew.cooper3@citrix.com>, "george.dunlap@citrix.com"
	<george.dunlap@citrix.com>, "paul@xen.org" <paul@xen.org>, Bertrand Marquis
	<Bertrand.Marquis@arm.com>, Oleksandr Andrushchenko
	<oleksandr_andrushchenko@epam.com>
Subject: Re: [PATCH v4 06/11] xen/domain: Call pci_release_devices() when
 releasing domain resources
Thread-Topic: [PATCH v4 06/11] xen/domain: Call pci_release_devices() when
 releasing domain resources
Thread-Index: AQHXuSnWj8Dry4hpBkuVdc9SAVWBMqvFyWiA
Date: Wed, 6 Oct 2021 10:35:23 +0000
Message-ID: <178D9AC3-84F4-4189-B7DF-9771F7B6CDF5@arm.com>
References: <20211004141151.132231-1-andr2000@gmail.com>
 <20211004141151.132231-7-andr2000@gmail.com>
In-Reply-To: <20211004141151.132231-7-andr2000@gmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
Authentication-Results-Original: gmail.com; dkim=none (message not signed)
 header.d=none;gmail.com; dmarc=none action=none header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: 5a03520e-4c5d-4c1a-cdc8-08d988b50a1d
x-ms-traffictypediagnostic: AS8PR08MB6007:|VI1PR08MB4397:
x-ms-exchange-transport-forked: True
X-Microsoft-Antispam-PRVS:
	<VI1PR08MB439773F2FDA7522A51EC02B9FCB09@VI1PR08MB4397.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:24;OLM:24;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 tp/LJ2TWI+9EsxAcx4np/ZjMnAHf136yArXIKeHwn+g7L7RKpp/Tv2/8nBcdqnx0nGwZdtHNde4h7Gxu7+BIEhbmMPJE/fCnwBBFOpVM5siabsZKWnWWMB9H6r0zwvbtEqvdEEx/S+mNEi2ji2c6dG6FT4KCiuVIjaharnBrmisQFQk7csCnMwVdOn69t8HNrqMd07hAs/fziLnpIpBZ7Ly5YOiatxVfj8jZ8Jmy9hBCbOFrAhjuWaqs+KTOocDY3pEFlV7IsV4WC5BN6greQhvyzxev/Lcoh+gqWfscXqn430hUDihnoYEsfEBmASBNAOQStdOV1yVhmUAGGjYGr+DCpIUtAPEixb9ipE2AwdGe84DFdD98WHuA+DbkXPQZux0QRt0qERckdGt+ynnQWPcNgssdZIOPN3afjL3R5VEyydu9Ywh4p4EzW/mROMhymKOg1AYknTkWXzqaEndnTKVEnH0I0L9GJ525JqZTKYCu8Qc4UA4OCF0sM7vVyJMu7K+cIetzzKFycONMVG5Jzyi/E8pvIh5sBSRN771Xuq6wl/Vc9y/MTcGULwP/DePh5RekwK1ywQ7oFU0dpqAQOz1F6772M55aDihyB6V/ic41on7TdrGPDuEBZC4g1PiaorNd4l3aEWjELAoO1R9GV9Jhb5PW+NLhI8v3vW/13W8F76a7sdYWyx63g+ZSeB72MsuxY977Ay9yjHNCJWchqGlIv1h+tSxYdLS2Y5Zcz0L2EnYMUsGJEE4vi3Bd1So9
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6919.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(91956017)(186003)(66476007)(66556008)(4326008)(8936002)(26005)(83380400001)(64756008)(76116006)(71200400001)(66946007)(53546011)(6512007)(6506007)(66446008)(508600001)(38070700005)(6486002)(54906003)(33656002)(122000001)(2616005)(2906002)(38100700002)(86362001)(8676002)(36756003)(5660300002)(316002)(6916009)(7416002)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="us-ascii"
Content-ID: <CA2ED7415FFFAC41B05909D00B9D02DC@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6007
Original-Authentication-Results: gmail.com; dkim=none (message not signed)
 header.d=none;gmail.com; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT010.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	749ce873-6db8-4623-920b-08d988b500eb
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	BzhYchfTVtK0wPv4udDmMz57gLlbDfw3Y64J6NLe2PVCEclzY15BKnLVbNy65cBTCtor62xTHIXZFfe9LuMeVCDsZxUA/3YML162l2EGxRsBfXhBcH2QUrGSufpqw7ZeCgb6klKgXZSC+AsjSwAnW3CPFzk6ekFqR5f53TN+/MmjI2Dfv9AEc71/Gu1ltht0UcmcWK1/mNQFPOG8AB/Krdl3UWrpr4rjcZtzlroE4pjTsgHD3EXtFawBaGWs+0tAD8N/UbK3nuc8mPGvj0U3aZLTkcs64GW0wtYhf+4EIOeXx1K7gppE0db1ndSAUCmSsZY+ES8EncXZv1dwIso1xtUX+TqBA3/efIWw1jbpTe/gx4zyTonESkZYLujwNRlick3CRSM7NezYo19aQXcIdR0rpI8excXz8b4xu0Ny+NuvRRL/j/AMDP9kyhqLl9TnvhFlWW4T2bKhMY0euFwLJZRmShD0Z/OBMQDCYCSwYQw33rderDBXcXLVVEWZsXHnnZGcWuXrSl4VUYWd8emCT7wTbKNe4PyUCgirL7nducPrgeVr16kl0eROBKCEbpRrzEA90KmYMHv3D8A3OEU6yR75sgmeqSY44ok62OWdRvu7LtALXUv++g6rB1txt4k/d9HkKathQ/pu7cLGnks8c4f+I+ryJFlH2tLnNjBnTH3Vhypd1/H0h6nTRsrFKYBBUFmBq1fiBOEPQC0Ocq7U8w==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(107886003)(6486002)(4326008)(70586007)(54906003)(8676002)(316002)(36756003)(5660300002)(6512007)(356005)(82310400003)(6862004)(186003)(53546011)(36860700001)(81166007)(86362001)(508600001)(2906002)(336012)(2616005)(47076005)(8936002)(26005)(33656002)(70206006)(83380400001)(6506007);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Oct 2021 10:35:38.8749
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 5a03520e-4c5d-4c1a-cdc8-08d988b50a1d
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT010.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB4397

Hi Oleksandr,

> On 4 Oct 2021, at 3:11 pm, Oleksandr Andrushchenko <andr2000@gmail.com> w=
rote:
>=20
> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>=20
> This is the very same that we already do for DT devices. Moreover, x86
> already calls pci_release_devices().
>=20
> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>

Reviewed-by: Rahul Singh <rahul.singh@arm.com>
Tested-by: Rahul Singh <rahul.singh@arm.com>

Regards,
Rahul
> ---
> Since v1:
> - re-wording in the commit message
> ---
> xen/arch/arm/domain.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>=20
> diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
> index fbb52f78f1a6..79012bf77757 100644
> --- a/xen/arch/arm/domain.c
> +++ b/xen/arch/arm/domain.c
> @@ -985,7 +985,8 @@ static int relinquish_memory(struct domain *d, struct=
 page_list_head *list)
>  * function which may return -ERESTART.
>  */
> enum {
> -    PROG_tee =3D 1,
> +    PROG_pci =3D 1,
> +    PROG_tee,
>     PROG_xen,
>     PROG_page,
>     PROG_mapping,
> @@ -1022,6 +1023,12 @@ int domain_relinquish_resources(struct domain *d)
> #ifdef CONFIG_IOREQ_SERVER
>         ioreq_server_destroy_all(d);
> #endif
> +#ifdef CONFIG_HAS_PCI
> +    PROGRESS(pci):
> +        ret =3D pci_release_devices(d);
> +        if ( ret )
> +            return ret;
> +#endif
>=20
>     PROGRESS(tee):
>         ret =3D tee_relinquish_resources(d);
> --=20
> 2.25.1
>=20



From xen-devel-bounces@lists.xenproject.org Wed Oct 06 10:36:31 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Oct 2021 10:36:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.202731.357734 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mY4Hn-00008u-ED; Wed, 06 Oct 2021 10:36:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 202731.357734; Wed, 06 Oct 2021 10:36:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mY4Hn-00008n-B3; Wed, 06 Oct 2021 10:36:31 +0000
Received: by outflank-mailman (input) for mailman id 202731;
 Wed, 06 Oct 2021 10:36:30 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=13oh=O2=arm.com=Rahul.Singh@srs-us1.protection.inumbo.net>)
 id 1mY4Hl-00008d-V6
 for xen-devel@lists.xenproject.org; Wed, 06 Oct 2021 10:36:30 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com (unknown
 [40.107.7.45]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 43044d2a-2691-11ec-bf58-12813bfff9fa;
 Wed, 06 Oct 2021 10:36:28 +0000 (UTC)
Received: from AM5PR0502CA0024.eurprd05.prod.outlook.com
 (2603:10a6:203:91::34) by PR2PR08MB4729.eurprd08.prod.outlook.com
 (2603:10a6:101:17::16) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18; Wed, 6 Oct
 2021 10:36:25 +0000
Received: from VE1EUR03FT022.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:203:91:cafe::23) by AM5PR0502CA0024.outlook.office365.com
 (2603:10a6:203:91::34) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.14 via Frontend
 Transport; Wed, 6 Oct 2021 10:36:25 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT022.mail.protection.outlook.com (10.152.18.64) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4566.14 via Frontend Transport; Wed, 6 Oct 2021 10:36:24 +0000
Received: ("Tessian outbound d5def7722ff7:v103");
 Wed, 06 Oct 2021 10:36:24 +0000
Received: from 132db2c773ee.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 A8966D63-FD15-41D2-A878-87477D8606FD.1; 
 Wed, 06 Oct 2021 10:36:13 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 132db2c773ee.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Wed, 06 Oct 2021 10:36:13 +0000
Received: from AS8PR08MB6919.eurprd08.prod.outlook.com (2603:10a6:20b:39e::10)
 by AM6PR08MB4360.eurprd08.prod.outlook.com (2603:10a6:20b:b3::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.22; Wed, 6 Oct
 2021 10:36:11 +0000
Received: from AS8PR08MB6919.eurprd08.prod.outlook.com
 ([fe80::51ee:e7de:6c0a:bcf9]) by AS8PR08MB6919.eurprd08.prod.outlook.com
 ([fe80::51ee:e7de:6c0a:bcf9%7]) with mapi id 15.20.4566.023; Wed, 6 Oct 2021
 10:36:11 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 43044d2a-2691-11ec-bf58-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=0fBLmCfBWJPKE6FbjGOwoA4ngeLKJ0Mfvw57wCZyXis=;
 b=IjomYJeiLBUAJzeuyuTxl/ZtdGpkqkcrIXWOpFVerpb4giUZ7dR06eyU6/v6/1JIOkXf05Cv+nAZKV9zlCosz/xl5ZZMXbkoiTA41pAntmR1qs6TX7pD84KmpL5e2o7blkS5lTd6azvV5dXtXez9MKkDw2X+ZzzhaESNUHsEZF0=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 245558fb9cc3bd64
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=aRicfiamCfv4D9APVj5sh3p1GE2pLYwvxZszrZVQP52MKN4IZ4HeQvm04UceUmkCoildU0GseKy/gR0bNYAWYzqYgcVATuhZo0mMZh7XCgtKQEvH79sjTvT84WPeHeO4hqp6BPTNJgLPuEAhMEEBK6oo/wmRB2aVIVO/XewwKDvDCTc42fcyi92Hix2mD/aqcUUNfFvIGt5ZYYPwsPylIoCc9VaAgVks3GaTIciozBfrYmzBRE+ArUKT5iLVvfx4ctgRAC4G2TfHITAVmCO9OFshByrxBBsThLZalSG9+zpB5X1bbzHvHUSSmEKgoYb+BzySfbezARJmXcRBInHitA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=0fBLmCfBWJPKE6FbjGOwoA4ngeLKJ0Mfvw57wCZyXis=;
 b=TzxHnSRX1KdDjDHgACmkhDOTp+g7Pmat0lni88QWkrHfc8KuGcfxP6pE6oALjMNn99JfgO+A+K+WZXj6leAq7CiwdpMgs7zAj3xa25VWE6jZfctryobWFGByhmXmovQoCmMucqIVCG7OrAB1sjMVCM57txK9DbwwZ4xaAKHm4L27upsjpWW+9dp4rUVrvGPZiO0YzU1oFDezmiNQyYXmksTHrSZJVopnDjJm25kU5ZoiokQL9W4omxTeoDEWFncX377FOb6/U0RW027EXgvW03XNlVWqzAbD7kLU39SUM5j5zDE2bAsKY3Ays1EIGgjTVC3t7iaM/lr/q6OYbPc/eg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=0fBLmCfBWJPKE6FbjGOwoA4ngeLKJ0Mfvw57wCZyXis=;
 b=IjomYJeiLBUAJzeuyuTxl/ZtdGpkqkcrIXWOpFVerpb4giUZ7dR06eyU6/v6/1JIOkXf05Cv+nAZKV9zlCosz/xl5ZZMXbkoiTA41pAntmR1qs6TX7pD84KmpL5e2o7blkS5lTd6azvV5dXtXez9MKkDw2X+ZzzhaESNUHsEZF0=
From: Rahul Singh <Rahul.Singh@arm.com>
To: Oleksandr Andrushchenko <andr2000@gmail.com>
CC: xen-devel <xen-devel@lists.xenproject.org>, Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>, "oleksandr_tyshchenko@epam.com"
	<oleksandr_tyshchenko@epam.com>, "volodymyr_babchuk@epam.com"
	<volodymyr_babchuk@epam.com>, "Artem_Mygaiev@epam.com"
	<Artem_Mygaiev@epam.com>, "roger.pau@citrix.com" <roger.pau@citrix.com>,
	"jbeulich@suse.com" <jbeulich@suse.com>, "andrew.cooper3@citrix.com"
	<andrew.cooper3@citrix.com>, "george.dunlap@citrix.com"
	<george.dunlap@citrix.com>, "paul@xen.org" <paul@xen.org>, Bertrand Marquis
	<Bertrand.Marquis@arm.com>, Oleksandr Andrushchenko
	<oleksandr_andrushchenko@epam.com>
Subject: Re: [PATCH v4 09/11] xen/arm: Setup MMIO range trap handlers for
 hardware domain
Thread-Topic: [PATCH v4 09/11] xen/arm: Setup MMIO range trap handlers for
 hardware domain
Thread-Index: AQHXuSnY8t5WkxPloUudv/0SZ52eK6vFyaGA
Date: Wed, 6 Oct 2021 10:36:11 +0000
Message-ID: <E9A4ABB2-F5D1-4468-8DBC-5FA95163101D@arm.com>
References: <20211004141151.132231-1-andr2000@gmail.com>
 <20211004141151.132231-10-andr2000@gmail.com>
In-Reply-To: <20211004141151.132231-10-andr2000@gmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
Authentication-Results-Original: gmail.com; dkim=none (message not signed)
 header.d=none;gmail.com; dmarc=none action=none header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: fcda2e0f-2297-46a0-97da-08d988b52588
x-ms-traffictypediagnostic: AM6PR08MB4360:|PR2PR08MB4729:
x-ms-exchange-transport-forked: True
X-Microsoft-Antispam-PRVS:
	<PR2PR08MB4729F33F14B14F3CF03A7DF4FCB09@PR2PR08MB4729.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:2449;OLM:2449;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 jhtBy5s5AtfkUTJMStwBuM3v90sawAQyLNt5kYjYiiX5p0l6fua4mvSLjyRMGKIzGbCGUx2wHvafs6eFpnHmwggpww0xzRlYmREP6DLUfzxGT+iCxP7aIKuzSH+szPKbYKXeQEFzHpyqt5Dg81ABaMdLg/zUzveKvcYc09tVCOF3ZEPLfw/CWMbVj9PZFCXymJ5aq4fQSgp81NXiiSa0ebUlgYQj6ZYYLWpWOnTWgeTopzeGqKfvXr8O9Rwpg++SGulxWL4pCu17wvvhRE6JtQlEdfOnZZ3iBdRON0O245fd76tH8foLpwMSJUFIehHO4cWNFkP25h0L+y8fyL3Avr32XHXdnvYBdzESNMgbfXeWNsih1d/pQnLbjtoa/da5biyhk66yrd8a433SbbVPPMfyzmW26CznCeUi2MkKwiq7bVRofknIPhqg7OEj01VbKIYBieWhIgSkPa1B+nvWrh1eCd30sVZUp2hPn/JnO10RYI2YGyLys8x8QZDWgQeXX5k3SOVosbIQahkLD/qUPOovlAedq+/k3IrYwO7XIQc4bOJwYqf8FnHqGLP7vwjyps3Hi02gXYqnkJ5BAF6lGHrokg459fyZVPWtPU3oE3OLaEjOHNXrqTiZzCuCvyB5Je40NjsZbuxKyvpvhaEfQC65LbcHJ/YTRWjkuuAQ6cnfDB9M6QvV++AJVCysjEbIIeiJdLFHRv35OwB7rgMIkEZjKK6hx7nwDuvLU9gMlqo=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6919.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(8676002)(6512007)(36756003)(2616005)(8936002)(38070700005)(6916009)(54906003)(7416002)(4326008)(316002)(5660300002)(71200400001)(83380400001)(508600001)(6486002)(2906002)(33656002)(6506007)(53546011)(186003)(66476007)(26005)(66556008)(76116006)(64756008)(91956017)(66446008)(38100700002)(86362001)(66946007)(122000001)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="us-ascii"
Content-ID: <FBE57EDFA2A01943A2B14AB12D47A865@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB4360
Original-Authentication-Results: gmail.com; dkim=none (message not signed)
 header.d=none;gmail.com; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT022.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	67a0d868-e048-4e81-cb19-08d988b51da4
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	6NbPB3IsJGF2exkGM69kCXJgBf8q+GjKuuNz2MNp0fYyf7jCd2YeetHvqD8RKUBdn8gx+oQblXn/vWssPzhS+Bwo1cBTV+HeIYz4Wik0xWOnTT6PCujnIaPOnzbvH0ZdwK4aL//2eGaPZlhCxkQUXFJdSjk9bgyTbSU8cMkS9r0EHdgHuy8s1JqzPqO/ucFQV/UNKGGnZzlLMB/TbVN2gOQa7FiXvmcVNVd6koBf1VV1S/i5kGKNyBZY5tJc26M8CmuXsk1OpAtDXPq7PvIDRH/Oq+Hh+/xpZwI2sINidOi1qqPxgybSKk5ciuBnD+1mZYAN6MWAd/LyQm6ic4lsqg8IaU+YOx/TMdjumo5niTeR2PCkTZh5R6ZOVyUrsBVBcJaslD0fA53Qal5TV6GjN9EF7j7Bna0izi9PYX/q8EqzyA3V7S/q5voLU8g6nFmczgO1gS0R8O6eEP+8LLCOrLVhDJ5v9/A7PwHtASZMnFEn814X0UJEPr/oT7h6fHEyN1N2BSYx7dFXB/8hnyFv2wzwAMmKFjFTcVo7xbT+H4IfLXFPwWNfdVn48zNMUEgKUcciEY6rlmhvj47EUbMdFXNHqNvLEmrfKJfELKG9oDfu+xxanHMvAFonH1GooIFcuw4NS0WQdMcpxFBWmK/1QyEkR+xRv6pBWITssDExrEA/zzt+gR5yYP95kr6Rn+NuWpRnKYLxoqNdU8g7RYQPCg==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(33656002)(8936002)(6862004)(83380400001)(47076005)(36860700001)(2906002)(86362001)(107886003)(508600001)(336012)(2616005)(70206006)(6506007)(53546011)(8676002)(316002)(356005)(6486002)(81166007)(36756003)(70586007)(4326008)(186003)(6512007)(54906003)(5660300002)(82310400003)(26005);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Oct 2021 10:36:24.7773
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: fcda2e0f-2297-46a0-97da-08d988b52588
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT022.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR2PR08MB4729

Hi Oleksandr,

> On 4 Oct 2021, at 3:11 pm, Oleksandr Andrushchenko <andr2000@gmail.com> w=
rote:
>=20
> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
>=20
> In order for vPCI to work it needs to maintain guest and hardware
> domain's views of the configuration space. For example, BARs and
> COMMAND registers require emulation for guests and the guest view
> of the registers needs to be in sync with the real contents of the
> relevant registers. For that ECAM address space needs to also be
> trapped for the hardware domain, so we need to implement PCI host
> bridge specific callbacks to properly setup MMIO handlers for those
> ranges depending on particular host bridge implementation.
>=20
> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>

Reviewed-by: Rahul Singh <rahul.singh@arm.com>
Tested-by: Rahul Singh <rahul.singh@arm.com>

Regards,
Rahul

> ---
> Since v3:
> - fixed comment formatting
> Since v2:
> - removed unneeded assignment (count =3D 0)
> - removed unneeded header inclusion
> - update commit message
> Since v1:
> - Dynamically calculate the number of MMIO handlers required for vPCI
>   and update the total number accordingly
> - s/clb/cb
> - Do not introduce a new callback for MMIO handler setup
> ---
> xen/arch/arm/domain.c              |  2 ++
> xen/arch/arm/pci/pci-host-common.c | 28 ++++++++++++++++++++++++
> xen/arch/arm/vpci.c                | 34 ++++++++++++++++++++++++++++++
> xen/arch/arm/vpci.h                |  6 ++++++
> xen/include/asm-arm/pci.h          |  5 +++++
> 5 files changed, 75 insertions(+)
>=20
> diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
> index 79012bf77757..fa6fcc5e467c 100644
> --- a/xen/arch/arm/domain.c
> +++ b/xen/arch/arm/domain.c
> @@ -733,6 +733,8 @@ int arch_domain_create(struct domain *d,
>     if ( (rc =3D domain_vgic_register(d, &count)) !=3D 0 )
>         goto fail;
>=20
> +    count +=3D domain_vpci_get_num_mmio_handlers(d);
> +
>     if ( (rc =3D domain_io_init(d, count + MAX_IO_HANDLER)) !=3D 0 )
>         goto fail;
>=20
> diff --git a/xen/arch/arm/pci/pci-host-common.c b/xen/arch/arm/pci/pci-ho=
st-common.c
> index 592c01aae5bb..1eb4daa87365 100644
> --- a/xen/arch/arm/pci/pci-host-common.c
> +++ b/xen/arch/arm/pci/pci-host-common.c
> @@ -292,6 +292,34 @@ struct dt_device_node *pci_find_host_bridge_node(str=
uct device *dev)
>     }
>     return bridge->dt_node;
> }
> +
> +int pci_host_iterate_bridges(struct domain *d,
> +                             int (*cb)(struct domain *d,
> +                                       struct pci_host_bridge *bridge))
> +{
> +    struct pci_host_bridge *bridge;
> +    int err;
> +
> +    list_for_each_entry( bridge, &pci_host_bridges, node )
> +    {
> +        err =3D cb(d, bridge);
> +        if ( err )
> +            return err;
> +    }
> +    return 0;
> +}
> +
> +int pci_host_get_num_bridges(void)
> +{
> +    struct pci_host_bridge *bridge;
> +    int count =3D 0;
> +
> +    list_for_each_entry( bridge, &pci_host_bridges, node )
> +        count++;
> +
> +    return count;
> +}
> +
> /*
>  * Local variables:
>  * mode: C
> diff --git a/xen/arch/arm/vpci.c b/xen/arch/arm/vpci.c
> index 76c12b92814f..6e179cd3010b 100644
> --- a/xen/arch/arm/vpci.c
> +++ b/xen/arch/arm/vpci.c
> @@ -80,17 +80,51 @@ static const struct mmio_handler_ops vpci_mmio_handle=
r =3D {
>     .write =3D vpci_mmio_write,
> };
>=20
> +static int vpci_setup_mmio_handler(struct domain *d,
> +                                   struct pci_host_bridge *bridge)
> +{
> +    struct pci_config_window *cfg =3D bridge->cfg;
> +
> +    register_mmio_handler(d, &vpci_mmio_handler,
> +                          cfg->phys_addr, cfg->size, NULL);
> +    return 0;
> +}
> +
> int domain_vpci_init(struct domain *d)
> {
>     if ( !has_vpci(d) )
>         return 0;
>=20
> +    if ( is_hardware_domain(d) )
> +        return pci_host_iterate_bridges(d, vpci_setup_mmio_handler);
> +
> +    /* Guest domains use what is programmed in their device tree. */
>     register_mmio_handler(d, &vpci_mmio_handler,
>                           GUEST_VPCI_ECAM_BASE, GUEST_VPCI_ECAM_SIZE, NUL=
L);
>=20
>     return 0;
> }
>=20
> +int domain_vpci_get_num_mmio_handlers(struct domain *d)
> +{
> +    int count;
> +
> +    if ( is_hardware_domain(d) )
> +        /* For each PCI host bridge's configuration space. */
> +        count =3D pci_host_get_num_bridges();
> +    else
> +        /*
> +         * VPCI_MSIX_MEM_NUM handlers for MSI-X tables per each PCI devi=
ce
> +         * being passed through. Maximum number of supported devices
> +         * is 32 as virtual bus topology emulates the devices as embedde=
d
> +         * endpoints.
> +         * +1 for a single emulated host bridge's configuration space.
> +         */
> +        count =3D VPCI_MSIX_MEM_NUM * 32 + 1;
> +
> +    return count;
> +}
> +
> /*
>  * Local variables:
>  * mode: C
> diff --git a/xen/arch/arm/vpci.h b/xen/arch/arm/vpci.h
> index d8a7b0e3e802..27a2b069abd2 100644
> --- a/xen/arch/arm/vpci.h
> +++ b/xen/arch/arm/vpci.h
> @@ -17,11 +17,17 @@
>=20
> #ifdef CONFIG_HAS_VPCI
> int domain_vpci_init(struct domain *d);
> +int domain_vpci_get_num_mmio_handlers(struct domain *d);
> #else
> static inline int domain_vpci_init(struct domain *d)
> {
>     return 0;
> }
> +
> +static inline int domain_vpci_get_num_mmio_handlers(struct domain *d)
> +{
> +    return 0;
> +}
> #endif
>=20
> #endif /* __ARCH_ARM_VPCI_H__ */
> diff --git a/xen/include/asm-arm/pci.h b/xen/include/asm-arm/pci.h
> index ea87ec6006fc..a62d8bc60086 100644
> --- a/xen/include/asm-arm/pci.h
> +++ b/xen/include/asm-arm/pci.h
> @@ -108,6 +108,11 @@ static always_inline bool is_pci_passthrough_enabled=
(void)
>=20
> void arch_pci_init_pdev(struct pci_dev *pdev);
>=20
> +int pci_host_iterate_bridges(struct domain *d,
> +                             int (*clb)(struct domain *d,
> +                                        struct pci_host_bridge *bridge))=
;
> +int pci_host_get_num_bridges(void);
> +
> #else   /*!CONFIG_HAS_PCI*/
>=20
> struct arch_pci_dev { };
> --=20
> 2.25.1
>=20



From xen-devel-bounces@lists.xenproject.org Wed Oct 06 10:40:05 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Oct 2021 10:40:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.202743.357745 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mY4LC-0000y9-23; Wed, 06 Oct 2021 10:40:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 202743.357745; Wed, 06 Oct 2021 10:40:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mY4LB-0000xo-Uf; Wed, 06 Oct 2021 10:40:01 +0000
Received: by outflank-mailman (input) for mailman id 202743;
 Wed, 06 Oct 2021 10:40:01 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=13oh=O2=arm.com=Rahul.Singh@srs-us1.protection.inumbo.net>)
 id 1mY4LB-0000xZ-Hf
 for xen-devel@lists.xenproject.org; Wed, 06 Oct 2021 10:40:01 +0000
Received: from EUR02-AM5-obe.outbound.protection.outlook.com (unknown
 [2a01:111:f400:fe07::623])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 268dfc14-19c9-4e27-9ceb-a0305553be3c;
 Wed, 06 Oct 2021 10:39:59 +0000 (UTC)
Received: from AM5PR1001CA0057.EURPRD10.PROD.OUTLOOK.COM
 (2603:10a6:206:15::34) by VI1PR08MB3453.eurprd08.prod.outlook.com
 (2603:10a6:803:80::26) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.17; Wed, 6 Oct
 2021 10:39:55 +0000
Received: from AM5EUR03FT054.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:206:15:cafe::7b) by AM5PR1001CA0057.outlook.office365.com
 (2603:10a6:206:15::34) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.14 via Frontend
 Transport; Wed, 6 Oct 2021 10:39:55 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM5EUR03FT054.mail.protection.outlook.com (10.152.16.212) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4566.14 via Frontend Transport; Wed, 6 Oct 2021 10:39:55 +0000
Received: ("Tessian outbound a8bfe25d7364:v103");
 Wed, 06 Oct 2021 10:39:55 +0000
Received: from d42df005eecf.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 407665D2-DA7C-4DE9-973C-9EDEAB64F519.1; 
 Wed, 06 Oct 2021 10:39:44 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id d42df005eecf.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Wed, 06 Oct 2021 10:39:43 +0000
Received: from AS8PR08MB6919.eurprd08.prod.outlook.com (2603:10a6:20b:39e::10)
 by AM6PR08MB4968.eurprd08.prod.outlook.com (2603:10a6:20b:e2::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.22; Wed, 6 Oct
 2021 10:39:42 +0000
Received: from AS8PR08MB6919.eurprd08.prod.outlook.com
 ([fe80::51ee:e7de:6c0a:bcf9]) by AS8PR08MB6919.eurprd08.prod.outlook.com
 ([fe80::51ee:e7de:6c0a:bcf9%7]) with mapi id 15.20.4566.023; Wed, 6 Oct 2021
 10:39:42 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 268dfc14-19c9-4e27-9ceb-a0305553be3c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=V2gLukLizB6EvFPvuJs+BvNoF5hefnKCjrPlSL1pTac=;
 b=D+DZBM8pGp87I+aEDDgoO9JOxD2G3IvmRd9vAjqk1/Km0Q9OAjaC6gWGoz4OM5cZyHp7qjwbWTLMop8BbIcr8Clm3J7a+t22oFJPquUfTZ2ggmGRW5j8D9G2rI6K7YL8OOZIyENRr5Mni1I2+q8FBuc1EeZRECMDzoUyQf4CKAY=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 691850f29fb1fea6
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=QhLJoP8TFqFZCsGm/lwsJP9Mby6SJaRvinaQpykAUlS1UyWRA5soXblfLddbKfwBr5sawczwiL7JN621/IhRvl4O0w59gh20JOa930OLYnyvCLhVAjD9AiIeNS4PhKNyhUeGCImELn8I1JeYnRtUdbTj9AYCldj+GA1WgSXhIXd9d+gF3OmcrwUDIUWr700hvLmOuOkM9x0Xy8SbVaXonKcXE3PBCxPKCnkTzffAudy2geohJqBLPIRHHg8Hk6xqDWXZkdadz5O7FR51Z+o1D0giSomdFJnqEnG4JDI3oH4F/MyTuKbw4yuwOo4OKxFNthfz/QBWSgswcljgGIzwBQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=V2gLukLizB6EvFPvuJs+BvNoF5hefnKCjrPlSL1pTac=;
 b=hHXqYKGaZCAJswi71vTAITuKu2rwQWTojlI59KpB6cTvS2ktKnbwelj1E5CDyPYaJSZMhp30Hm214rN6OjFr2EpBldhkY5pDbI4wX4aluHkTZ7B/ACqu8G49/EJO1IkYuKs4Wvzav3uK0ORmkiAibwOW8BdxDS1fW+yrsHfYL9vc4XAqVAHpyxzWc/fLKfig1ROXc619bUbeBapUPWgSUJbIfybqPN0d9Y3PhMV7I+yqOrKqXXvE7aDf/QHbRouN7Xc9zvvN96eYQZUAlAxDBU5mkz4UmNbh3sEzEFRxenLeBCoVKp/rK9pfSGtqPjVRy5hsXYr7IjAIxxriQwBw4A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=V2gLukLizB6EvFPvuJs+BvNoF5hefnKCjrPlSL1pTac=;
 b=D+DZBM8pGp87I+aEDDgoO9JOxD2G3IvmRd9vAjqk1/Km0Q9OAjaC6gWGoz4OM5cZyHp7qjwbWTLMop8BbIcr8Clm3J7a+t22oFJPquUfTZ2ggmGRW5j8D9G2rI6K7YL8OOZIyENRr5Mni1I2+q8FBuc1EeZRECMDzoUyQf4CKAY=
From: Rahul Singh <Rahul.Singh@arm.com>
To: Oleksandr Andrushchenko <andr2000@gmail.com>
CC: xen-devel <xen-devel@lists.xenproject.org>, Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>, "oleksandr_tyshchenko@epam.com"
	<oleksandr_tyshchenko@epam.com>, "volodymyr_babchuk@epam.com"
	<volodymyr_babchuk@epam.com>, "Artem_Mygaiev@epam.com"
	<Artem_Mygaiev@epam.com>, "roger.pau@citrix.com" <roger.pau@citrix.com>,
	"jbeulich@suse.com" <jbeulich@suse.com>, "andrew.cooper3@citrix.com"
	<andrew.cooper3@citrix.com>, "george.dunlap@citrix.com"
	<george.dunlap@citrix.com>, "paul@xen.org" <paul@xen.org>, Bertrand Marquis
	<Bertrand.Marquis@arm.com>, Oleksandr Andrushchenko
	<oleksandr_andrushchenko@epam.com>, Ian Jackson <iwj@xenproject.org>, Juergen
 Gross <jgross@suse.com>
Subject: Re: [PATCH v4 08/11] libxl: Only map legacy PCI IRQs if they are
 supported
Thread-Topic: [PATCH v4 08/11] libxl: Only map legacy PCI IRQs if they are
 supported
Thread-Index: AQHXuSnXiELWieMIEkueEhWKvtLbfKvFypyA
Date: Wed, 6 Oct 2021 10:39:42 +0000
Message-ID: <98FF5F02-ADD2-4A4C-A20C-8CC0CAF1B03E@arm.com>
References: <20211004141151.132231-1-andr2000@gmail.com>
 <20211004141151.132231-9-andr2000@gmail.com>
In-Reply-To: <20211004141151.132231-9-andr2000@gmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
Authentication-Results-Original: gmail.com; dkim=none (message not signed)
 header.d=none;gmail.com; dmarc=none action=none header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: 5c2ceb94-fb93-4e13-7f41-08d988b5a2c8
x-ms-traffictypediagnostic: AM6PR08MB4968:|VI1PR08MB3453:
x-ms-exchange-transport-forked: True
X-Microsoft-Antispam-PRVS:
	<VI1PR08MB3453644C671FBE21BA1A84EAFCB09@VI1PR08MB3453.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:8273;OLM:8273;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 hSU4xofl+9X400QQAiuXPa1rLybkSu3W9uzvf09k/O+cCbgmLlWMUu5dzh66g+FOQN0OHhqNUpgKPDSEoeJmRWQp+piETXPF2tyzyZPSinHwlVhlIaSIzwNWj3bLK9amjV4X8bORzTtXez8kROC4bX25T3v0n3lV3Fo9kQWJ1NcfvSmtoypm6+6Ke5IPtqkrvhuZxr0bKAkJMYBptgYP3CuzFLYOG80WuokDwCN0SxcRi+xjmhVh3XjiBApwerWTyAb0moLf6jSkG5GfgOe31Fj1BVc0JzACKUgLnGomkuUgVNk3plid/Bh+v0QtXr2gS+5AvRdWU4ErM233YqKBIlEvrldVPHzxDpOqTyfgA8+PkL8hBWysbyp2annY+tHKmYiuHWQcxfyf35Ek3mSrrkxu1I0Mlm9udIZvgGMQy0pJ60ZFgVMx0/0sXJtWScx75n/N38KUUOSV2Iz21sThagEglTaBI2n0SjFAOH7e98GQujgfsRlLNL43pQyD4RVKz/4qRntQ3/Dv7RUBeHGb9hthU7nWA11kAr0AqyP7E2rMnLCfv7XY7R3xpTDk1+UhIx61zLLW4Zfu661Q2yLD6GEpqDwY7FkwYpHnNfsKgq5kUrp5qFJfWlrczf8NhMmlxPIBvUvbwXQODKQh9HGJQAZhEQSejbTRBxCgs0byPN/fFH6jO4UxT8LYlMESMFDw5cyinK4FdOgJHqgKDIBXvZEavPaobirZynAezdLenBfZOwKo94opEulOEDcel/8V
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6919.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(38070700005)(83380400001)(53546011)(186003)(33656002)(86362001)(8676002)(5660300002)(2616005)(4326008)(8936002)(6506007)(26005)(66476007)(66946007)(76116006)(66556008)(91956017)(66446008)(64756008)(6486002)(6512007)(508600001)(316002)(6916009)(7416002)(54906003)(2906002)(122000001)(38100700002)(71200400001)(36756003)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2E8D099727178E4AA63C07027370197E@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB4968
Original-Authentication-Results: gmail.com; dkim=none (message not signed)
 header.d=none;gmail.com; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM5EUR03FT054.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	d8fbe1bf-27f9-46b3-290a-08d988b59b1a
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	yg+38KuGqh34Jv5VTqjiu6JENHH1f1bC0NhnFSNoMRm/kPHZl8ccJtU5HMgWtFZZo/XB066NDJMYQWl8mRbHVkz+5SyT74CKjzpNxj1BCh5qdt3RUyVwY8XbQKvQn18MZ4aTA58xC3cRzuojwnVJcKs9Lg+BAqmLHOGB1t+ekFWK9mx/zCXAFomurItFvbWMqO7m6u0P+OlU641Y9MtXsGbyI3rK1eZqlV8jdv6hxk2QuvP6vg1DUIn4ogWCz4sE9VNIBnci8gU2RcuqBMuaOWXUPPQThxWXQ//U+xJaGlAv/jcOs2VIxaVTy2ymU6mTxtfbVZiAfAeWCLsYlgrter2/4wtntGDMxEFN+VaXNpSamTYFZL1WLDmu5X5+Ls13qze6dexplECFIJLvblSHuV+xnpYLJsfEaVIzsRBOmTtK+WxOPIxEifmpO2yc0dhdWzABKCCKptHV3JCCs5/+6TBDLDYly0RpjznOqIl+vyWnwA+HLY7zSVsYIesBNCUGtvoL7tqnYGCG1jXFr9DXYrFAh5bPJeLwDAy34MfPuOJ7TcT1PG6R4YLN7HztuVMM25nllOyFCrOOrOUsjHVqnlEAybQrUddl74vWA0yksigOnnkiRhRui5bLhvlxBYndww3K/xab21Yb7750sKQIs6gKOBtj5t1J8BM8HeiYqiMb2jvwopQDi52nbeiCgT30tVUZ75eMQYTUugVU0Jl6Iw==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(47076005)(86362001)(4326008)(6862004)(5660300002)(70586007)(36860700001)(33656002)(6486002)(356005)(336012)(54906003)(107886003)(81166007)(70206006)(508600001)(36756003)(82310400003)(8676002)(186003)(316002)(8936002)(2906002)(2616005)(6506007)(83380400001)(26005)(53546011)(6512007);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Oct 2021 10:39:55.0543
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 5c2ceb94-fb93-4e13-7f41-08d988b5a2c8
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM5EUR03FT054.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3453

Hi Oleksandr,

> On 4 Oct 2021, at 3:11 pm, Oleksandr Andrushchenko <andr2000@gmail.com> w=
rote:
>=20
> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
>=20
> Arm's PCI passthrough implementation doesn't support legacy interrupts,
> but MSI/MSI-X. This can be the case for other platforms too.
> For that reason introduce a new CONFIG_PCI_SUPP_LEGACY_IRQ and add
> it to the CFLAGS and compile the relevant code in the toolstack only if
> applicable.
>=20
> Cc: Ian Jackson <iwj@xenproject.org>
> Cc: Juergen Gross <jgross@suse.com>
> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>

Reviewed-by: Rahul Singh <rahul.singh@arm.com>
Tested-by: Rahul Singh <rahul.singh@arm.com>

Regards,
Rahul
> ---
> Since v1:
> - Minimized #idefery by introducing pci_supp_legacy_irq function
>   for relevant checks
> ---
> tools/libs/light/Makefile    |  4 ++++
> tools/libs/light/libxl_pci.c | 13 +++++++++++++
> 2 files changed, 17 insertions(+)
>=20
> diff --git a/tools/libs/light/Makefile b/tools/libs/light/Makefile
> index 7d8c51d49242..bd3f6be2a183 100644
> --- a/tools/libs/light/Makefile
> +++ b/tools/libs/light/Makefile
> @@ -46,6 +46,10 @@ CFLAGS +=3D -Wno-format-zero-length -Wmissing-declarat=
ions \
> 	-Wno-declaration-after-statement -Wformat-nonliteral
> CFLAGS +=3D -I.
>=20
> +ifeq ($(CONFIG_X86),y)
> +CFLAGS +=3D -DCONFIG_PCI_SUPP_LEGACY_IRQ
> +endif
> +
> SRCS-$(CONFIG_X86) +=3D libxl_cpuid.c
> SRCS-$(CONFIG_X86) +=3D libxl_x86.c
> SRCS-$(CONFIG_X86) +=3D libxl_psr.c
> diff --git a/tools/libs/light/libxl_pci.c b/tools/libs/light/libxl_pci.c
> index 59f3686fc85e..4c2d7aeefbb2 100644
> --- a/tools/libs/light/libxl_pci.c
> +++ b/tools/libs/light/libxl_pci.c
> @@ -1364,6 +1364,15 @@ static void pci_add_timeout(libxl__egc *egc, libxl=
__ev_time *ev,
>     pci_add_dm_done(egc, pas, rc);
> }
>=20
> +static bool pci_supp_legacy_irq(void)
> +{
> +#ifdef CONFIG_PCI_SUPP_LEGACY_IRQ
> +    return true;
> +#else
> +    return false;
> +#endif
> +}
> +
> static void pci_add_dm_done(libxl__egc *egc,
>                             pci_add_state *pas,
>                             int rc)
> @@ -1434,6 +1443,8 @@ static void pci_add_dm_done(libxl__egc *egc,
>         }
>     }
>     fclose(f);
> +    if (!pci_supp_legacy_irq())
> +        goto out_no_irq;
>     sysfs_path =3D GCSPRINTF(SYSFS_PCI_DEV"/"PCI_BDF"/irq", pci->domain,
>                                 pci->bus, pci->dev, pci->func);
>     f =3D fopen(sysfs_path, "r");
> @@ -1983,6 +1994,8 @@ static void do_pci_remove(libxl__egc *egc, pci_remo=
ve_state *prs)
>         }
>         fclose(f);
> skip1:
> +        if (!pci_supp_legacy_irq())
> +            goto skip_irq;
>         sysfs_path =3D GCSPRINTF(SYSFS_PCI_DEV"/"PCI_BDF"/irq", pci->doma=
in,
>                                pci->bus, pci->dev, pci->func);
>         f =3D fopen(sysfs_path, "r");
> --=20
> 2.25.1
>=20



From xen-devel-bounces@lists.xenproject.org Wed Oct 06 10:58:55 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Oct 2021 10:58:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.202755.357778 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mY4dR-0003tp-6D; Wed, 06 Oct 2021 10:58:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 202755.357778; Wed, 06 Oct 2021 10:58:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mY4dR-0003tg-1U; Wed, 06 Oct 2021 10:58:53 +0000
Received: by outflank-mailman (input) for mailman id 202755;
 Wed, 06 Oct 2021 10:58:52 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Zh4t=O2=arm.com=michal.orzel@srs-us1.protection.inumbo.net>)
 id 1mY4dQ-0003sm-0i
 for xen-devel@lists.xenproject.org; Wed, 06 Oct 2021 10:58:52 +0000
Received: from foss.arm.com (unknown [217.140.110.172])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTP
 id 962e0275-3272-487c-80a3-f57d10fd5fcf;
 Wed, 06 Oct 2021 10:58:50 +0000 (UTC)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0C9411FB;
 Wed,  6 Oct 2021 03:58:50 -0700 (PDT)
Received: from e123311-lin.arm.com (unknown [10.57.19.94])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1FBD53F70D;
 Wed,  6 Oct 2021 03:58:46 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 962e0275-3272-487c-80a3-f57d10fd5fcf
From: Michal Orzel <michal.orzel@arm.com>
To: xen-devel@lists.xenproject.org
Cc: Ian Jackson <iwj@xenproject.org>,
	Wei Liu <wl@xen.org>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Nick Rosbrook <rosbrookn@ainfosec.com>,
	Anthony PERARD <anthony.perard@citrix.com>,
	Juergen Gross <jgross@suse.com>,
	Christian Lindig <christian.lindig@citrix.com>,
	David Scott <dave@recoil.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	bertrand.marquis@arm.com
Subject: [PATCH v2 3/3] xen: Expose the PMU to the guests
Date: Wed,  6 Oct 2021 12:58:27 +0200
Message-Id: <20211006105827.15217-4-michal.orzel@arm.com>
X-Mailer: git-send-email 2.29.0
In-Reply-To: <20211006105827.15217-1-michal.orzel@arm.com>
References: <20211006105827.15217-1-michal.orzel@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Add parameter vpmu to xl domain configuration syntax
to enable the access to PMU registers by disabling
the PMU traps(currently only for ARM).

The current status is that the PMU registers are not
virtualized and the physical registers are directly
accessible when this parameter is enabled. There is no
interrupt support and Xen will not save/restore the
register values on context switches.

Please note that this feature is experimental.

Signed-off-by: Michal Orzel <michal.orzel@arm.com>
Signed-off-by: Julien Grall <julien@xen.org>
---
 docs/man/xl.cfg.5.pod.in             | 17 +++++++++++++++++
 tools/golang/xenlight/helpers.gen.go |  6 ++++++
 tools/golang/xenlight/types.gen.go   |  1 +
 tools/include/libxl.h                |  6 ++++++
 tools/libs/light/libxl_create.c      |  4 ++++
 tools/libs/light/libxl_types.idl     |  2 ++
 tools/ocaml/libs/xc/xenctrl.ml       |  1 +
 tools/ocaml/libs/xc/xenctrl.mli      |  1 +
 tools/xl/xl_parse.c                  |  2 ++
 xen/arch/arm/domain.c                | 10 ++++++++--
 xen/arch/arm/setup.c                 |  1 +
 xen/arch/x86/domain.c                |  6 ++++++
 xen/common/domain.c                  |  9 ++++++++-
 xen/include/asm-arm/domain.h         |  1 +
 xen/include/public/domctl.h          |  5 ++++-
 15 files changed, 68 insertions(+), 4 deletions(-)

diff --git a/docs/man/xl.cfg.5.pod.in b/docs/man/xl.cfg.5.pod.in
index 4b1e3028d2..55c4881205 100644
--- a/docs/man/xl.cfg.5.pod.in
+++ b/docs/man/xl.cfg.5.pod.in
@@ -690,6 +690,23 @@ default.
 B<NOTE>: Acceptable values are platform specific.  For Intel Processor
 Trace, this value must be a power of 2 between 4k and 16M.
 
+=item B<vpmu=BOOLEAN>
+
+Currently ARM only.
+
+Specifies whether to enable the access to PMU registers by disabling
+the PMU traps.
+
+The PMU registers are not virtualized and the physical registers are directly
+accessible when this parameter is enabled. There is no interrupt support and
+Xen will not save/restore the register values on context switches.
+
+vPMU, by design and purpose, exposes system level performance
+information to the guest. Only to be used by sufficiently privileged
+domains. This feature is currently in experimental state.
+
+If this option is not specified then it will default to B<false>.
+
 =back
 
 =head2 Devices
diff --git a/tools/golang/xenlight/helpers.gen.go b/tools/golang/xenlight/helpers.gen.go
index c8669837d8..2449580bad 100644
--- a/tools/golang/xenlight/helpers.gen.go
+++ b/tools/golang/xenlight/helpers.gen.go
@@ -1119,6 +1119,9 @@ return fmt.Errorf("converting field ArchX86.MsrRelaxed: %v", err)
 }
 x.Altp2M = Altp2MMode(xc.altp2m)
 x.VmtraceBufKb = int(xc.vmtrace_buf_kb)
+if err := x.Vpmu.fromC(&xc.vpmu);err != nil {
+return fmt.Errorf("converting field Vpmu: %v", err)
+}
 
  return nil}
 
@@ -1600,6 +1603,9 @@ return fmt.Errorf("converting field ArchX86.MsrRelaxed: %v", err)
 }
 xc.altp2m = C.libxl_altp2m_mode(x.Altp2M)
 xc.vmtrace_buf_kb = C.int(x.VmtraceBufKb)
+if err := x.Vpmu.toC(&xc.vpmu); err != nil {
+return fmt.Errorf("converting field Vpmu: %v", err)
+}
 
  return nil
  }
diff --git a/tools/golang/xenlight/types.gen.go b/tools/golang/xenlight/types.gen.go
index 45f2cba3d2..b2e8bd1a85 100644
--- a/tools/golang/xenlight/types.gen.go
+++ b/tools/golang/xenlight/types.gen.go
@@ -521,6 +521,7 @@ MsrRelaxed Defbool
 }
 Altp2M Altp2MMode
 VmtraceBufKb int
+Vpmu Defbool
 }
 
 type DomainBuildInfoTypeUnion interface {
diff --git a/tools/include/libxl.h b/tools/include/libxl.h
index ec5e3badae..ee73eb06f1 100644
--- a/tools/include/libxl.h
+++ b/tools/include/libxl.h
@@ -508,6 +508,12 @@
  */
 #define LIBXL_HAVE_PHYSINFO_CAP_VPMU 1
 
+/*
+ * LIBXL_HAVE_VPMU indicates that libxl_domain_build_info has a vpmu parameter,
+ * which allows to enable the access to PMU registers.
+ */
+#define LIBXL_HAVE_VPMU 1
+
 /*
  * libxl ABI compatibility
  *
diff --git a/tools/libs/light/libxl_create.c b/tools/libs/light/libxl_create.c
index e356b2106d..d123c2f703 100644
--- a/tools/libs/light/libxl_create.c
+++ b/tools/libs/light/libxl_create.c
@@ -91,6 +91,7 @@ int libxl__domain_build_info_setdefault(libxl__gc *gc,
     }
 
     libxl_defbool_setdefault(&b_info->device_model_stubdomain, false);
+    libxl_defbool_setdefault(&b_info->vpmu, false);
 
     if (libxl_defbool_val(b_info->device_model_stubdomain) &&
         !b_info->device_model_ssidref)
@@ -622,6 +623,9 @@ int libxl__domain_make(libxl__gc *gc, libxl_domain_config *d_config,
                 create.flags |= XEN_DOMCTL_CDF_nested_virt;
         }
 
+        if ( libxl_defbool_val(b_info->vpmu) )
+            create.flags |= XEN_DOMCTL_CDF_vpmu;
+
         assert(info->passthrough != LIBXL_PASSTHROUGH_DEFAULT);
         LOG(DETAIL, "passthrough: %s",
             libxl_passthrough_to_string(info->passthrough));
diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_types.idl
index 993e83acca..b96fb5c47e 100644
--- a/tools/libs/light/libxl_types.idl
+++ b/tools/libs/light/libxl_types.idl
@@ -655,6 +655,8 @@ libxl_domain_build_info = Struct("domain_build_info",[
     # Use zero value to disable this feature.
     ("vmtrace_buf_kb", integer),
 
+    ("vpmu", libxl_defbool),
+
     ], dir=DIR_IN,
        copy_deprecated_fn="libxl__domain_build_info_copy_deprecated",
 )
diff --git a/tools/ocaml/libs/xc/xenctrl.ml b/tools/ocaml/libs/xc/xenctrl.ml
index 6da3ed3c6f..addcf4cc59 100644
--- a/tools/ocaml/libs/xc/xenctrl.ml
+++ b/tools/ocaml/libs/xc/xenctrl.ml
@@ -69,6 +69,7 @@ type domain_create_flag =
 	| CDF_XS_DOMAIN
 	| CDF_IOMMU
 	| CDF_NESTED_VIRT
+	| CDF_VPMU
 
 type domain_create_iommu_opts =
 	| IOMMU_NO_SHAREPT
diff --git a/tools/ocaml/libs/xc/xenctrl.mli b/tools/ocaml/libs/xc/xenctrl.mli
index b8faff6721..0a5ce529e9 100644
--- a/tools/ocaml/libs/xc/xenctrl.mli
+++ b/tools/ocaml/libs/xc/xenctrl.mli
@@ -62,6 +62,7 @@ type domain_create_flag =
   | CDF_XS_DOMAIN
   | CDF_IOMMU
   | CDF_NESTED_VIRT
+  | CDF_VPMU
 
 type domain_create_iommu_opts =
   | IOMMU_NO_SHAREPT
diff --git a/tools/xl/xl_parse.c b/tools/xl/xl_parse.c
index 17dddb4cd5..c503b9be00 100644
--- a/tools/xl/xl_parse.c
+++ b/tools/xl/xl_parse.c
@@ -2750,6 +2750,8 @@ skip_usbdev:
                     "If it fixes an issue you are having please report to "
                     "xen-devel@lists.xenproject.org.\n");
 
+    xlu_cfg_get_defbool(config, "vpmu", &b_info->vpmu, 0);
+
     xlu_cfg_destroy(config);
 }
 
diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
index 19c756ac3d..2dd474da09 100644
--- a/xen/arch/arm/domain.c
+++ b/xen/arch/arm/domain.c
@@ -276,6 +276,8 @@ static void ctxt_switch_to(struct vcpu *n)
      * timer. The interrupt needs to be injected into the guest. */
     WRITE_SYSREG(n->arch.cntkctl, CNTKCTL_EL1);
     virt_timer_restore(n);
+
+    WRITE_SYSREG(n->arch.mdcr_el2, MDCR_EL2);
 }
 
 /* Update per-VCPU guest runstate shared memory area (if registered). */
@@ -586,6 +588,10 @@ int arch_vcpu_create(struct vcpu *v)
 
     v->arch.hcr_el2 = get_default_hcr_flags();
 
+    v->arch.mdcr_el2 = HDCR_TDRA | HDCR_TDOSA | HDCR_TDA;
+    if ( !(v->domain->options & XEN_DOMCTL_CDF_vpmu) )
+        v->arch.mdcr_el2 |= HDCR_TPM | HDCR_TPMCR;
+
     if ( (rc = vcpu_vgic_init(v)) != 0 )
         goto fail;
 
@@ -622,8 +628,8 @@ int arch_sanitise_domain_config(struct xen_domctl_createdomain *config)
 {
     unsigned int max_vcpus;
 
-    /* HVM and HAP must be set. IOMMU may or may not be */
-    if ( (config->flags & ~XEN_DOMCTL_CDF_iommu) !=
+    /* HVM and HAP must be set. IOMMU and PMU may or may not be */
+    if ( (config->flags & ~(XEN_DOMCTL_CDF_iommu | XEN_DOMCTL_CDF_vpmu)) !=
          (XEN_DOMCTL_CDF_hvm | XEN_DOMCTL_CDF_hap) )
     {
         dprintk(XENLOG_INFO, "Unsupported configuration %#x\n",
diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c
index 49dc90d198..85386a765a 100644
--- a/xen/arch/arm/setup.c
+++ b/xen/arch/arm/setup.c
@@ -108,6 +108,7 @@ static void __init processor_id(void)
 
     identify_cpu(c);
     current_cpu_data = *c;
+    vpmu_is_available = cpu_has_pmu;
 
     if ( c->midr.implementer < ARRAY_SIZE(processor_implementers) &&
          processor_implementers[c->midr.implementer] )
diff --git a/xen/arch/x86/domain.c b/xen/arch/x86/domain.c
index ef1812dc14..406824a7a5 100644
--- a/xen/arch/x86/domain.c
+++ b/xen/arch/x86/domain.c
@@ -692,6 +692,12 @@ int arch_sanitise_domain_config(struct xen_domctl_createdomain *config)
         return -EINVAL;
     }
 
+    if ( config->flags & XEN_DOMCTL_CDF_vpmu )
+    {
+        dprintk(XENLOG_INFO, "vpmu support not ready yet\n");
+        return -EINVAL;
+    }
+
     return 0;
 }
 
diff --git a/xen/common/domain.c b/xen/common/domain.c
index 4d0e909eec..37d8c55c69 100644
--- a/xen/common/domain.c
+++ b/xen/common/domain.c
@@ -480,12 +480,13 @@ static int sanitise_domain_config(struct xen_domctl_createdomain *config)
     bool hvm = config->flags & XEN_DOMCTL_CDF_hvm;
     bool hap = config->flags & XEN_DOMCTL_CDF_hap;
     bool iommu = config->flags & XEN_DOMCTL_CDF_iommu;
+    bool vpmu = config->flags & XEN_DOMCTL_CDF_vpmu;
 
     if ( config->flags &
          ~(XEN_DOMCTL_CDF_hvm | XEN_DOMCTL_CDF_hap |
            XEN_DOMCTL_CDF_s3_integrity | XEN_DOMCTL_CDF_oos_off |
            XEN_DOMCTL_CDF_xs_domain | XEN_DOMCTL_CDF_iommu |
-           XEN_DOMCTL_CDF_nested_virt) )
+           XEN_DOMCTL_CDF_nested_virt | XEN_DOMCTL_CDF_vpmu) )
     {
         dprintk(XENLOG_INFO, "Unknown CDF flags %#x\n", config->flags);
         return -EINVAL;
@@ -534,6 +535,12 @@ static int sanitise_domain_config(struct xen_domctl_createdomain *config)
         return -EINVAL;
     }
 
+    if ( vpmu && !vpmu_is_available )
+    {
+        dprintk(XENLOG_INFO, "vpmu requested but not available\n");
+        return -EINVAL;
+    }
+
     return arch_sanitise_domain_config(config);
 }
 
diff --git a/xen/include/asm-arm/domain.h b/xen/include/asm-arm/domain.h
index c9277b5c6d..14e575288f 100644
--- a/xen/include/asm-arm/domain.h
+++ b/xen/include/asm-arm/domain.h
@@ -166,6 +166,7 @@ struct arch_vcpu
 
     /* HYP configuration */
     register_t hcr_el2;
+    register_t mdcr_el2;
 
     uint32_t teecr, teehbr; /* ThumbEE, 32-bit guests only */
 #ifdef CONFIG_ARM_32
diff --git a/xen/include/public/domctl.h b/xen/include/public/domctl.h
index 96696e3842..8f2a07cfe8 100644
--- a/xen/include/public/domctl.h
+++ b/xen/include/public/domctl.h
@@ -70,9 +70,12 @@ struct xen_domctl_createdomain {
 #define XEN_DOMCTL_CDF_iommu          (1U<<_XEN_DOMCTL_CDF_iommu)
 #define _XEN_DOMCTL_CDF_nested_virt   6
 #define XEN_DOMCTL_CDF_nested_virt    (1U << _XEN_DOMCTL_CDF_nested_virt)
+/* Should we expose the vPMU to the guest? */
+#define _XEN_DOMCTL_CDF_vpmu           7
+#define XEN_DOMCTL_CDF_vpmu            (1U << _XEN_DOMCTL_CDF_vpmu)
 
 /* Max XEN_DOMCTL_CDF_* constant.  Used for ABI checking. */
-#define XEN_DOMCTL_CDF_MAX XEN_DOMCTL_CDF_nested_virt
+#define XEN_DOMCTL_CDF_MAX XEN_DOMCTL_CDF_vpmu
 
     uint32_t flags;
 
-- 
2.29.0



From xen-devel-bounces@lists.xenproject.org Wed Oct 06 10:58:55 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Oct 2021 10:58:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.202753.357756 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mY4dJ-0003L7-Kl; Wed, 06 Oct 2021 10:58:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 202753.357756; Wed, 06 Oct 2021 10:58:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mY4dJ-0003L0-Hj; Wed, 06 Oct 2021 10:58:45 +0000
Received: by outflank-mailman (input) for mailman id 202753;
 Wed, 06 Oct 2021 10:58:44 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Zh4t=O2=arm.com=michal.orzel@srs-us1.protection.inumbo.net>)
 id 1mY4dI-0003Ku-Bx
 for xen-devel@lists.xenproject.org; Wed, 06 Oct 2021 10:58:44 +0000
Received: from foss.arm.com (unknown [217.140.110.172])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTP
 id 3f3c6a55-0ed7-44e9-921c-64f920a0d4f1;
 Wed, 06 Oct 2021 10:58:42 +0000 (UTC)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7F4161FB;
 Wed,  6 Oct 2021 03:58:42 -0700 (PDT)
Received: from e123311-lin.arm.com (unknown [10.57.19.94])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id F16243F70D;
 Wed,  6 Oct 2021 03:58:38 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3f3c6a55-0ed7-44e9-921c-64f920a0d4f1
From: Michal Orzel <michal.orzel@arm.com>
To: xen-devel@lists.xenproject.org
Cc: George Dunlap <george.dunlap@citrix.com>,
	Nick Rosbrook <rosbrookn@ainfosec.com>,
	Ian Jackson <iwj@xenproject.org>,
	Wei Liu <wl@xen.org>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Anthony PERARD <anthony.perard@citrix.com>,
	Juergen Gross <jgross@suse.com>,
	Christian Lindig <christian.lindig@citrix.com>,
	David Scott <dave@recoil.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	bertrand.marquis@arm.com
Subject: [PATCH v2 0/3] Expose PMU to the guests
Date: Wed,  6 Oct 2021 12:58:24 +0200
Message-Id: <20211006105827.15217-1-michal.orzel@arm.com>
X-Mailer: git-send-email 2.29.0
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

This patch series is a rework of an already pushed patch
exposing PMU to the guests. In the second version the vpmu
parameter is common and prework in the form of reporting
availability of vPMU on the hardware is added.

The current status is that the PMU registers are not virtualized
and the physical registers are directly accessible when "vpmu"
parameter is enabled in the guest config file. There is no interrupt
support and Xen will not save/restore the register values on context
switches. This is to be done in the future.

Michal Orzel (3):
  xen+tools: Introduce XEN_SYSCTL_PHYSCAP_vpmu
  xen/arm: Check for PMU platform support
  xen: Expose the PMU to the guests

 docs/man/xl.cfg.5.pod.in             | 17 ++++++++++
 tools/golang/xenlight/helpers.gen.go |  8 +++++
 tools/golang/xenlight/types.gen.go   |  2 ++
 tools/include/libxl.h                | 12 +++++++
 tools/libs/light/libxl.c             |  1 +
 tools/libs/light/libxl_create.c      |  4 +++
 tools/libs/light/libxl_types.idl     |  3 ++
 tools/ocaml/libs/xc/xenctrl.ml       |  2 ++
 tools/ocaml/libs/xc/xenctrl.mli      |  2 ++
 tools/xl/xl_info.c                   |  5 +--
 tools/xl/xl_parse.c                  |  2 ++
 xen/arch/arm/domain.c                | 10 ++++--
 xen/arch/arm/setup.c                 |  1 +
 xen/arch/x86/domain.c                |  6 ++++
 xen/common/domain.c                  | 11 ++++++-
 xen/common/sysctl.c                  |  3 ++
 xen/include/asm-arm/cpufeature.h     | 49 ++++++++++++++++++++++++++--
 xen/include/asm-arm/domain.h         |  1 +
 xen/include/public/domctl.h          |  5 ++-
 xen/include/public/sysctl.h          |  8 +++--
 xen/include/xen/domain.h             |  2 ++
 21 files changed, 144 insertions(+), 10 deletions(-)

-- 
2.29.0



From xen-devel-bounces@lists.xenproject.org Wed Oct 06 10:58:56 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Oct 2021 10:58:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.202756.357785 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mY4dR-0003zL-Of; Wed, 06 Oct 2021 10:58:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 202756.357785; Wed, 06 Oct 2021 10:58:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mY4dR-0003xl-G8; Wed, 06 Oct 2021 10:58:53 +0000
Received: by outflank-mailman (input) for mailman id 202756;
 Wed, 06 Oct 2021 10:58:52 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Zh4t=O2=arm.com=michal.orzel@srs-us1.protection.inumbo.net>)
 id 1mY4dQ-0003ap-7U
 for xen-devel@lists.xenproject.org; Wed, 06 Oct 2021 10:58:52 +0000
Received: from foss.arm.com (unknown [217.140.110.172])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTP
 id 6150bc70-2694-11ec-bf5a-12813bfff9fa;
 Wed, 06 Oct 2021 10:58:47 +0000 (UTC)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C88A61FB;
 Wed,  6 Oct 2021 03:58:46 -0700 (PDT)
Received: from e123311-lin.arm.com (unknown [10.57.19.94])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B019D3F70D;
 Wed,  6 Oct 2021 03:58:45 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6150bc70-2694-11ec-bf5a-12813bfff9fa
From: Michal Orzel <michal.orzel@arm.com>
To: xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	bertrand.marquis@arm.com
Subject: [PATCH v2 2/3] xen/arm: Check for PMU platform support
Date: Wed,  6 Oct 2021 12:58:26 +0200
Message-Id: <20211006105827.15217-3-michal.orzel@arm.com>
X-Mailer: git-send-email 2.29.0
In-Reply-To: <20211006105827.15217-1-michal.orzel@arm.com>
References: <20211006105827.15217-1-michal.orzel@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

ID_AA64DFR0_EL1/ID_DFR0_EL1 registers provide
information about PMU support. Replace structure
dbg64/dbg32 with a union and fill in all the
register fields according to document:
ARM Architecture Registers(DDI 0595, 2021-06).

Add macros boot_dbg_feature64/boot_dbg_feature32
to check for a debug feature. Add macro
cpu_has_pmu to check for PMU support.

Signed-off-by: Michal Orzel <michal.orzel@arm.com>
---
 xen/include/asm-arm/cpufeature.h | 49 ++++++++++++++++++++++++++++++--
 1 file changed, 47 insertions(+), 2 deletions(-)

diff --git a/xen/include/asm-arm/cpufeature.h b/xen/include/asm-arm/cpufeature.h
index 5ca09b0bff..4fce23844d 100644
--- a/xen/include/asm-arm/cpufeature.h
+++ b/xen/include/asm-arm/cpufeature.h
@@ -4,6 +4,7 @@
 #ifdef CONFIG_ARM_64
 #define cpu_feature64(c, feat)         ((c)->pfr64.feat)
 #define boot_cpu_feature64(feat)       (system_cpuinfo.pfr64.feat)
+#define boot_dbg_feature64(feat)       (system_cpuinfo.dbg64.feat)
 
 #define cpu_feature64_has_el0_32(c)    (cpu_feature64(c, el0) == 2)
 
@@ -22,6 +23,7 @@
 
 #define cpu_feature32(c, feat)         ((c)->pfr32.feat)
 #define boot_cpu_feature32(feat)       (system_cpuinfo.pfr32.feat)
+#define boot_dbg_feature32(feat)       (system_cpuinfo.dbg32.feat)
 
 #define cpu_has_arm       (boot_cpu_feature32(arm) == 1)
 #define cpu_has_thumb     (boot_cpu_feature32(thumb) >= 1)
@@ -32,8 +34,10 @@
 
 #ifdef CONFIG_ARM_32
 #define cpu_has_gentimer  (boot_cpu_feature32(gentimer) == 1)
+#define cpu_has_pmu       (boot_dbg_feature32(perfmon) >= 1)
 #else
 #define cpu_has_gentimer  (1)
+#define cpu_has_pmu       (boot_dbg_feature64(pmu_ver) >= 1)
 #endif
 #define cpu_has_security  (boot_cpu_feature32(security) > 0)
 
@@ -181,8 +185,28 @@ struct cpuinfo_arm {
         };
     } pfr64;
 
-    struct {
+    union {
         register_t bits[2];
+        struct {
+            /* DFR0 */
+            unsigned long debug_ver:4;
+            unsigned long trace_ver:4;
+            unsigned long pmu_ver:4;
+            unsigned long brps:4;
+            unsigned long __res0:4;
+            unsigned long wrps:4;
+            unsigned long __res1:4;
+            unsigned long ctx_cmps:4;
+            unsigned long pms_ver:4;
+            unsigned long double_lock:4;
+            unsigned long trace_filt:4;
+            unsigned long __res2:4;
+            unsigned long mtpmu:4;
+            unsigned long __res3:12;
+
+            /* DFR1 */
+            unsigned long __res4:64;
+        };
     } dbg64;
 
     struct {
@@ -321,8 +345,29 @@ struct cpuinfo_arm {
         };
     } pfr32;
 
-    struct {
+    union {
         register_t bits[2];
+        struct {
+            /* DFR0 */
+            unsigned long copdbg:4;
+            unsigned long copsdbg:4;
+            unsigned long mmapdbg:4;
+            unsigned long coptrc:4;
+            unsigned long mmaptrc:4;
+            unsigned long mprofdbg:4;
+            unsigned long perfmon:4;
+            unsigned long tracefilt:4;
+#ifdef CONFIG_ARM_64
+            unsigned long __res0:32;
+#endif
+
+            /* DFR1 */
+            unsigned long mtpmu:4;
+            unsigned long __res1:28;
+#ifdef CONFIG_ARM_64
+            unsigned long __res2:32;
+#endif
+        };
     } dbg32;
 
     struct {
-- 
2.29.0



From xen-devel-bounces@lists.xenproject.org Wed Oct 06 10:58:56 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Oct 2021 10:58:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.202754.357767 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mY4dM-0003b6-SZ; Wed, 06 Oct 2021 10:58:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 202754.357767; Wed, 06 Oct 2021 10:58:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mY4dM-0003az-Oz; Wed, 06 Oct 2021 10:58:48 +0000
Received: by outflank-mailman (input) for mailman id 202754;
 Wed, 06 Oct 2021 10:58:47 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Zh4t=O2=arm.com=michal.orzel@srs-us1.protection.inumbo.net>)
 id 1mY4dL-0003ap-8q
 for xen-devel@lists.xenproject.org; Wed, 06 Oct 2021 10:58:47 +0000
Received: from foss.arm.com (unknown [217.140.110.172])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTP
 id 607af6c6-2694-11ec-bf5a-12813bfff9fa;
 Wed, 06 Oct 2021 10:58:45 +0000 (UTC)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 693C5ED1;
 Wed,  6 Oct 2021 03:58:45 -0700 (PDT)
Received: from e123311-lin.arm.com (unknown [10.57.19.94])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C54BE3F70D;
 Wed,  6 Oct 2021 03:58:42 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 607af6c6-2694-11ec-bf5a-12813bfff9fa
From: Michal Orzel <michal.orzel@arm.com>
To: xen-devel@lists.xenproject.org
Cc: George Dunlap <george.dunlap@citrix.com>,
	Nick Rosbrook <rosbrookn@ainfosec.com>,
	Ian Jackson <iwj@xenproject.org>,
	Wei Liu <wl@xen.org>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Anthony PERARD <anthony.perard@citrix.com>,
	Juergen Gross <jgross@suse.com>,
	Christian Lindig <christian.lindig@citrix.com>,
	David Scott <dave@recoil.org>,
	bertrand.marquis@arm.com
Subject: [PATCH v2 1/3] xen+tools: Introduce XEN_SYSCTL_PHYSCAP_vpmu
Date: Wed,  6 Oct 2021 12:58:25 +0200
Message-Id: <20211006105827.15217-2-michal.orzel@arm.com>
X-Mailer: git-send-email 2.29.0
In-Reply-To: <20211006105827.15217-1-michal.orzel@arm.com>
References: <20211006105827.15217-1-michal.orzel@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Introduce flag XEN_SYSCTL_PHYSCAP_vpmu which
indicates whether the platform supports vPMU
functionality. Modify Xen and tools accordingly.

Take the opportunity and fix XEN_SYSCTL_PHYSCAP_vmtrace
definition in sysctl.h which wrongly uses (1<<6)
instead of (1u<<6) and does not follow the standard
of using separate macro for a flag field.

Signed-off-by: Michal Orzel <michal.orzel@arm.com>
---
 tools/golang/xenlight/helpers.gen.go | 2 ++
 tools/golang/xenlight/types.gen.go   | 1 +
 tools/include/libxl.h                | 6 ++++++
 tools/libs/light/libxl.c             | 1 +
 tools/libs/light/libxl_types.idl     | 1 +
 tools/ocaml/libs/xc/xenctrl.ml       | 1 +
 tools/ocaml/libs/xc/xenctrl.mli      | 1 +
 tools/xl/xl_info.c                   | 5 +++--
 xen/common/domain.c                  | 2 ++
 xen/common/sysctl.c                  | 3 +++
 xen/include/public/sysctl.h          | 8 ++++++--
 xen/include/xen/domain.h             | 2 ++
 12 files changed, 29 insertions(+), 4 deletions(-)

diff --git a/tools/golang/xenlight/helpers.gen.go b/tools/golang/xenlight/helpers.gen.go
index bfc1e7f312..c8669837d8 100644
--- a/tools/golang/xenlight/helpers.gen.go
+++ b/tools/golang/xenlight/helpers.gen.go
@@ -3360,6 +3360,7 @@ x.CapHap = bool(xc.cap_hap)
 x.CapShadow = bool(xc.cap_shadow)
 x.CapIommuHapPtShare = bool(xc.cap_iommu_hap_pt_share)
 x.CapVmtrace = bool(xc.cap_vmtrace)
+x.CapVpmu = bool(xc.cap_vpmu)
 
  return nil}
 
@@ -3391,6 +3392,7 @@ xc.cap_hap = C.bool(x.CapHap)
 xc.cap_shadow = C.bool(x.CapShadow)
 xc.cap_iommu_hap_pt_share = C.bool(x.CapIommuHapPtShare)
 xc.cap_vmtrace = C.bool(x.CapVmtrace)
+xc.cap_vpmu = C.bool(x.CapVpmu)
 
  return nil
  }
diff --git a/tools/golang/xenlight/types.gen.go b/tools/golang/xenlight/types.gen.go
index 09a3bb67e2..45f2cba3d2 100644
--- a/tools/golang/xenlight/types.gen.go
+++ b/tools/golang/xenlight/types.gen.go
@@ -1008,6 +1008,7 @@ CapHap bool
 CapShadow bool
 CapIommuHapPtShare bool
 CapVmtrace bool
+CapVpmu bool
 }
 
 type Connectorinfo struct {
diff --git a/tools/include/libxl.h b/tools/include/libxl.h
index b9ba16d698..ec5e3badae 100644
--- a/tools/include/libxl.h
+++ b/tools/include/libxl.h
@@ -502,6 +502,12 @@
  */
 #define LIBXL_HAVE_X86_MSR_RELAXED 1
 
+/*
+ * LIBXL_HAVE_PHYSINFO_CAP_VPMU indicates that libxl_physinfo has a cap_vpmu
+ * field, which indicates the availability of vPMU functionality.
+ */
+#define LIBXL_HAVE_PHYSINFO_CAP_VPMU 1
+
 /*
  * libxl ABI compatibility
  *
diff --git a/tools/libs/light/libxl.c b/tools/libs/light/libxl.c
index 204eb0be2d..a032723fde 100644
--- a/tools/libs/light/libxl.c
+++ b/tools/libs/light/libxl.c
@@ -404,6 +404,7 @@ int libxl_get_physinfo(libxl_ctx *ctx, libxl_physinfo *physinfo)
         !!(xcphysinfo.capabilities & XEN_SYSCTL_PHYSCAP_iommu_hap_pt_share);
     physinfo->cap_vmtrace =
         !!(xcphysinfo.capabilities & XEN_SYSCTL_PHYSCAP_vmtrace);
+    physinfo->cap_vpmu = !!(xcphysinfo.capabilities & XEN_SYSCTL_PHYSCAP_vpmu);
 
     GC_FREE;
     return 0;
diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_types.idl
index 3f9fff653a..993e83acca 100644
--- a/tools/libs/light/libxl_types.idl
+++ b/tools/libs/light/libxl_types.idl
@@ -1061,6 +1061,7 @@ libxl_physinfo = Struct("physinfo", [
     ("cap_shadow", bool),
     ("cap_iommu_hap_pt_share", bool),
     ("cap_vmtrace", bool),
+    ("cap_vpmu", bool),
     ], dir=DIR_OUT)
 
 libxl_connectorinfo = Struct("connectorinfo", [
diff --git a/tools/ocaml/libs/xc/xenctrl.ml b/tools/ocaml/libs/xc/xenctrl.ml
index a5588c643f..6da3ed3c6f 100644
--- a/tools/ocaml/libs/xc/xenctrl.ml
+++ b/tools/ocaml/libs/xc/xenctrl.ml
@@ -121,6 +121,7 @@ type physinfo_cap_flag =
 	| CAP_Shadow
 	| CAP_IOMMU_HAP_PT_SHARE
 	| CAP_Vmtrace
+	| CAP_Vpmu
 
 type physinfo =
 {
diff --git a/tools/ocaml/libs/xc/xenctrl.mli b/tools/ocaml/libs/xc/xenctrl.mli
index 6e94940a8a..b8faff6721 100644
--- a/tools/ocaml/libs/xc/xenctrl.mli
+++ b/tools/ocaml/libs/xc/xenctrl.mli
@@ -106,6 +106,7 @@ type physinfo_cap_flag =
   | CAP_Shadow
   | CAP_IOMMU_HAP_PT_SHARE
   | CAP_Vmtrace
+  | CAP_Vpmu
 
 type physinfo = {
   threads_per_core : int;
diff --git a/tools/xl/xl_info.c b/tools/xl/xl_info.c
index 8383e4a6df..2c86b317b7 100644
--- a/tools/xl/xl_info.c
+++ b/tools/xl/xl_info.c
@@ -210,7 +210,7 @@ static void output_physinfo(void)
          info.hw_cap[4], info.hw_cap[5], info.hw_cap[6], info.hw_cap[7]
         );
 
-    maybe_printf("virt_caps              :%s%s%s%s%s%s%s%s\n",
+    maybe_printf("virt_caps              :%s%s%s%s%s%s%s%s%s\n",
          info.cap_pv ? " pv" : "",
          info.cap_hvm ? " hvm" : "",
          info.cap_hvm && info.cap_hvm_directio ? " hvm_directio" : "",
@@ -218,7 +218,8 @@ static void output_physinfo(void)
          info.cap_hap ? " hap" : "",
          info.cap_shadow ? " shadow" : "",
          info.cap_iommu_hap_pt_share ? " iommu_hap_pt_share" : "",
-         info.cap_vmtrace ? " vmtrace" : ""
+         info.cap_vmtrace ? " vmtrace" : "",
+         info.cap_vpmu ? " vpmu" : ""
         );
 
     vinfo = libxl_get_version_info(ctx);
diff --git a/xen/common/domain.c b/xen/common/domain.c
index 6ee5d033b0..4d0e909eec 100644
--- a/xen/common/domain.c
+++ b/xen/common/domain.c
@@ -84,6 +84,8 @@ vcpu_info_t dummy_vcpu_info;
 
 bool __read_mostly vmtrace_available;
 
+bool __read_mostly vpmu_is_available;
+
 static void __domain_finalise_shutdown(struct domain *d)
 {
     struct vcpu *v;
diff --git a/xen/common/sysctl.c b/xen/common/sysctl.c
index 3558641cd9..6e7189bb3c 100644
--- a/xen/common/sysctl.c
+++ b/xen/common/sysctl.c
@@ -280,6 +280,9 @@ long do_sysctl(XEN_GUEST_HANDLE_PARAM(xen_sysctl_t) u_sysctl)
         if ( vmtrace_available )
             pi->capabilities |= XEN_SYSCTL_PHYSCAP_vmtrace;
 
+        if ( vpmu_is_available )
+            pi->capabilities |= XEN_SYSCTL_PHYSCAP_vpmu;
+
         if ( copy_to_guest(u_sysctl, op, 1) )
             ret = -EFAULT;
     }
diff --git a/xen/include/public/sysctl.h b/xen/include/public/sysctl.h
index 039ccf885c..546e673409 100644
--- a/xen/include/public/sysctl.h
+++ b/xen/include/public/sysctl.h
@@ -100,10 +100,14 @@ struct xen_sysctl_tbuf_op {
 #define _XEN_SYSCTL_PHYSCAP_iommu_hap_pt_share 5
 #define XEN_SYSCTL_PHYSCAP_iommu_hap_pt_share  \
     (1u << _XEN_SYSCTL_PHYSCAP_iommu_hap_pt_share)
-#define XEN_SYSCTL_PHYSCAP_vmtrace       (1 << 6)
+#define _XEN_SYSCTL_PHYSCAP_vmtrace      6
+#define XEN_SYSCTL_PHYSCAP_vmtrace       (1u<<_XEN_SYSCTL_PHYSCAP_vmtrace)
+/* The platform supports vPMU. */
+#define _XEN_SYSCTL_PHYSCAP_vpmu         7
+#define XEN_SYSCTL_PHYSCAP_vpmu          (1u<<_XEN_SYSCTL_PHYSCAP_vpmu)
 
 /* Max XEN_SYSCTL_PHYSCAP_* constant.  Used for ABI checking. */
-#define XEN_SYSCTL_PHYSCAP_MAX XEN_SYSCTL_PHYSCAP_vmtrace
+#define XEN_SYSCTL_PHYSCAP_MAX XEN_SYSCTL_PHYSCAP_vpmu
 
 struct xen_sysctl_physinfo {
     uint32_t threads_per_core;
diff --git a/xen/include/xen/domain.h b/xen/include/xen/domain.h
index 1708c36964..160c8dbdab 100644
--- a/xen/include/xen/domain.h
+++ b/xen/include/xen/domain.h
@@ -133,4 +133,6 @@ static inline void vnuma_destroy(struct vnuma_info *vnuma) { ASSERT(!vnuma); }
 
 extern bool vmtrace_available;
 
+extern bool vpmu_is_available;
+
 #endif /* __XEN_DOMAIN_H__ */
-- 
2.29.0



From xen-devel-bounces@lists.xenproject.org Wed Oct 06 11:07:24 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Oct 2021 11:07:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.202787.357800 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mY4ld-0006gH-GK; Wed, 06 Oct 2021 11:07:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 202787.357800; Wed, 06 Oct 2021 11:07:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mY4ld-0006gA-DN; Wed, 06 Oct 2021 11:07:21 +0000
Received: by outflank-mailman (input) for mailman id 202787;
 Wed, 06 Oct 2021 11:07:20 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mY4lc-0006g4-03
 for xen-devel@lists.xenproject.org; Wed, 06 Oct 2021 11:07:20 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mY4lb-0001df-PJ
 for xen-devel@lists.xenproject.org; Wed, 06 Oct 2021 11:07:19 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mY4lb-0007Zv-Nq
 for xen-devel@lists.xenproject.org; Wed, 06 Oct 2021 11:07:19 +0000
Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89)
 (envelope-from <iwj@xenproject.org>)
 id 1mY4lW-0003Bl-Sh; Wed, 06 Oct 2021 12:07:14 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date
	:Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From;
	bh=8YvJL4OWdFD/N1Sw+3f9Jy2wi9KCpLDkJC7zDxfmC0s=; b=fkI5B5akhfz+w0vjhpcF5EDUTs
	wZ8Z01wduvVs+ssnHf1p8cYZ8u0u2mQEci4blIJXyP2eUnnf4EhUI1/BYH4j2CZaFqaAFMLZ58VEx
	67RPbL3aXfJ2u4Z3854vd5gWX68kVkTvx/WVbQ7FHVlWtbKDLyt/07aoIt7afwl/MI14=;
From: Ian Jackson <iwj@xenproject.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <24925.33634.554859.2131@mariner.uk.xensource.com>
Date: Wed, 6 Oct 2021 12:07:14 +0100
To: Rahul Singh <Rahul.Singh@arm.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
    xen-devel <xen-devel@lists.xenproject.org>,
    Bertrand Marquis <Bertrand.Marquis@arm.com>,
    Andre Przywara <Andre.Przywara@arm.com>,
    Ian  Jackson <iwj@xenproject.org>,
    Wei Liu <wl@xen.org>,
    Anthony PERARD <anthony.perard@citrix.com>,
    Juergen Gross <jgross@suse.com>,
    Julien Grall <julien@xen.org>,
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH v4 13/14] arm/libxl: Emulated PCI device tree node in
 libxl
In-Reply-To: <8B848F95-977F-4DF4-B315-CFEA610BC1C3@arm.com>
References: <cover.1633340795.git.rahul.singh@arm.com>
	<3ad42008f534671ae7f5b25da91253ce7cd4a3e9.1633340795.git.rahul.singh@arm.com>
	<alpine.DEB.2.21.2110041714410.3209@sstabellini-ThinkPad-T480s>
	<11F169C6-39A4-40F3-8E75-39B8C2CCF022@arm.com>
	<alpine.DEB.2.21.2110051421520.3209@sstabellini-ThinkPad-T480s>
	<8B848F95-977F-4DF4-B315-CFEA610BC1C3@arm.com>
X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu)

Rahul Singh writes ("Re: [PATCH v4 13/14] arm/libxl: Emulated PCI device tree node in libxl"):
> libxl_defbool_val(libxl_defbool db) is implemented in such a way that it will assert 
> if db value is the default. Therefore we have to explicitly set it to LIBXL__DEFBOOL_FALSE for x86.
> 
> There are two option either we can have #ifdef or we can move the 
> libxl_defbool_setdefault(&b_info->arch_arm.vpci, false) to common code.

What is wrong with putting it in
libxl__arch_domain_build_info_setdefault
which I think exists precisely for this kind of thing ?

Ian.


From xen-devel-bounces@lists.xenproject.org Wed Oct 06 11:18:04 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Oct 2021 11:18:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.202797.357811 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mY4vt-0008AV-GT; Wed, 06 Oct 2021 11:17:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 202797.357811; Wed, 06 Oct 2021 11:17:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mY4vt-0008AO-DC; Wed, 06 Oct 2021 11:17:57 +0000
Received: by outflank-mailman (input) for mailman id 202797;
 Wed, 06 Oct 2021 11:17:56 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=13oh=O2=arm.com=Rahul.Singh@srs-us1.protection.inumbo.net>)
 id 1mY4vs-0008AI-Cp
 for xen-devel@lists.xenproject.org; Wed, 06 Oct 2021 11:17:56 +0000
Received: from EUR01-VE1-obe.outbound.protection.outlook.com (unknown
 [40.107.14.83]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 62d5d81e-439e-4aff-9f94-b4646ef94a8f;
 Wed, 06 Oct 2021 11:17:54 +0000 (UTC)
Received: from AS9PR06CA0169.eurprd06.prod.outlook.com (2603:10a6:20b:45c::33)
 by AM0PR08MB4404.eurprd08.prod.outlook.com (2603:10a6:208:137::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.15; Wed, 6 Oct
 2021 11:17:52 +0000
Received: from VE1EUR03FT037.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:45c:cafe::a) by AS9PR06CA0169.outlook.office365.com
 (2603:10a6:20b:45c::33) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.14 via Frontend
 Transport; Wed, 6 Oct 2021 11:17:52 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT037.mail.protection.outlook.com (10.152.19.70) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4566.14 via Frontend Transport; Wed, 6 Oct 2021 11:17:52 +0000
Received: ("Tessian outbound f1898412aff1:v103");
 Wed, 06 Oct 2021 11:17:51 +0000
Received: from d3f23fa86b25.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 E4A9FEC4-3A02-4411-BF40-B2FEF15183D0.1; 
 Wed, 06 Oct 2021 11:17:45 +0000
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id d3f23fa86b25.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Wed, 06 Oct 2021 11:17:45 +0000
Received: from AS8PR08MB6919.eurprd08.prod.outlook.com (2603:10a6:20b:39e::10)
 by AS8PR08MB6023.eurprd08.prod.outlook.com (2603:10a6:20b:291::5)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.22; Wed, 6 Oct
 2021 11:17:44 +0000
Received: from AS8PR08MB6919.eurprd08.prod.outlook.com
 ([fe80::51ee:e7de:6c0a:bcf9]) by AS8PR08MB6919.eurprd08.prod.outlook.com
 ([fe80::51ee:e7de:6c0a:bcf9%7]) with mapi id 15.20.4566.023; Wed, 6 Oct 2021
 11:17:44 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 62d5d81e-439e-4aff-9f94-b4646ef94a8f
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=M2PqoS9qf64W0dvbW9fTe7iTB30jPr0hswKZyn0Nll0=;
 b=gQj55cXBuT6WgRof4Yqua29GxKsQB/R3LRloZnVvsfMKuVSDvQ8jAC65S9xfPEAsKzvXB7IVAAre+X7WfytXonlI74JrsyxjWtxlmifJqcFX2eEA6WdQjVUPw4P+OxEgmTkg9WJh/hww1aIMmHgdxahR6ESVwJNbtqJ7sS3aaSo=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 3135a79f486a31a1
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=cs7W92OOtQQHtBAD7Nv0dii6hB5AXAEjY0XeoT8UxeeDGJ5dFip2v+A53kmFsfziPJ+mL7LrBPN2oT8Xf/WxRYV8EcqWeYSUENO9ksxmF5yHcrJiuiV0YxSRMJbNG/Tt814BmZlfEiUecZD+BjpRCVlOdhCnyeP9k4PSre8MF+r3yA4U0eK+t5V2tz8eFiMzYIgKRzGIV+bZYR+xUwpaPXabxYlK+AdMPRiYgrQkRilfPhuvnOWmsvpWYL0y87NU7g5pLok1sy/aX9C13Jun5ryTB2cz7xWZAz+RHRtvtFHJxwRff41Kh3e4VBjLumXsnhEjfF8pncDxnZ9o4Fj3Jw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=M2PqoS9qf64W0dvbW9fTe7iTB30jPr0hswKZyn0Nll0=;
 b=BvT2MTyXlFmKW2w41fyTJwPb+IFicdyIUeIqJSz/1wXX5qBuDvgg8kUnhZ+us1yCNZiJjgWY+jBMsYikLOfCYttg/oeHRlnvJhOpw/4ssTK+b+iBEr/DOo3ubbofmvrIVi8cyNwYucAWQ05txJ0eOVriy9EqBreyzQ1xRCee6/k0g8TwcbkCguA/M9cGFQbuFzz5ATVNUWrVt3pouLk7wzLqXoXNgsPsfFQyIUOt4nwzE1Rc5hCw5fJbsh38AuReMv2yy71MSFHasUV8EM2yp6g+233hg2z4T4hiKAE4ruhPJsBBdOcoGVdNA9jSZrh6a3HA2JmGCtqCNxFm7yeUJA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=M2PqoS9qf64W0dvbW9fTe7iTB30jPr0hswKZyn0Nll0=;
 b=gQj55cXBuT6WgRof4Yqua29GxKsQB/R3LRloZnVvsfMKuVSDvQ8jAC65S9xfPEAsKzvXB7IVAAre+X7WfytXonlI74JrsyxjWtxlmifJqcFX2eEA6WdQjVUPw4P+OxEgmTkg9WJh/hww1aIMmHgdxahR6ESVwJNbtqJ7sS3aaSo=
From: Rahul Singh <Rahul.Singh@arm.com>
To: Ian Jackson <iwj@xenproject.org>
CC: Stefano Stabellini <sstabellini@kernel.org>, xen-devel
	<xen-devel@lists.xenproject.org>, Bertrand Marquis
	<Bertrand.Marquis@arm.com>, Andre Przywara <Andre.Przywara@arm.com>, Wei Liu
	<wl@xen.org>, Anthony PERARD <anthony.perard@citrix.com>, Juergen Gross
	<jgross@suse.com>, Julien Grall <julien@xen.org>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH v4 13/14] arm/libxl: Emulated PCI device tree node in
 libxl
Thread-Topic: [PATCH v4 13/14] arm/libxl: Emulated PCI device tree node in
 libxl
Thread-Index:
 AQHXuRciClWhjFX7R0aQhsW/aixhyqvDkJEAgACf3oCAAL5hgIAAzJaAgAAXDgCAAALtgA==
Date: Wed, 6 Oct 2021 11:17:44 +0000
Message-ID: <BFC5AD62-3DA7-498F-8B6E-AB4C8CAA9731@arm.com>
References: <cover.1633340795.git.rahul.singh@arm.com>
 <3ad42008f534671ae7f5b25da91253ce7cd4a3e9.1633340795.git.rahul.singh@arm.com>
 <alpine.DEB.2.21.2110041714410.3209@sstabellini-ThinkPad-T480s>
 <11F169C6-39A4-40F3-8E75-39B8C2CCF022@arm.com>
 <alpine.DEB.2.21.2110051421520.3209@sstabellini-ThinkPad-T480s>
 <8B848F95-977F-4DF4-B315-CFEA610BC1C3@arm.com>
 <24925.33634.554859.2131@mariner.uk.xensource.com>
In-Reply-To: <24925.33634.554859.2131@mariner.uk.xensource.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
Authentication-Results-Original: xenproject.org; dkim=none (message not
 signed) header.d=none;xenproject.org; dmarc=none action=none
 header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: e7d31a71-6d2c-4005-a074-08d988baf01e
x-ms-traffictypediagnostic: AS8PR08MB6023:|AM0PR08MB4404:
x-ms-exchange-transport-forked: True
X-Microsoft-Antispam-PRVS:
	<AM0PR08MB44044942D559A99976E0944EFCB09@AM0PR08MB4404.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:8273;OLM:8273;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 pYG0K8laRWkek3OH4F9TSEwEDGugPxZ9xYzA+bN9HqMVEL/EkWK1GlKRqQHPximqJdQ2YVAPvYLqQhnHvZEI+cLCvpC8c6fWlime0raNPkny78AR2Yu1JQPUAtaCXQp5LDluwWXrZI/HeDFYNW6CMKUQPEMp7cTwHhAiiBa3FdVdMdOJLVcQdsoZ8aUHXmRo2feIlupSM92/N3VHTGJbWGV6Bu1TGQOl0Z7f9K8RCmkaF1JuGSE4hGarOZe4R7Qp+Dv/5kkfSi2U24RgborCvgbt699PrziperxZ2IwB9JPkrBCm9HzHsrSh5UZ3oM+Ubdj8kODqodAoUJbRY1ZJbGCnVf3rsCcQ/HvnaDDbvcIAaTi9fzLWfmUFcBNxo7R/Dixa3gXNwUDQhvhGlxMqKHLF8NTUhFAB1mfeQwnV9XKYaEfhpD3LMCPl5aGKYUV9vUrmaqgVqO0lNZHdkn4jOa5QpewZsqOaYUiZ8TppTOVnCU4kOE9FK7kUvUE2RLnDm976syphLQB4RULCk83feklyVfUSDp7RDZea+TYxZHhF1uW6Q6sVU4a9pUT8ivI7si4CyyqqEfEJ4kDJiwUKYRaCo48/m6BocKVa33aM8WQduPbq3ZXSP+E3zv2VgRRXT/GhqPiTB2gUHGeSZ0XYWnxIXhTnpxo8bKtO42mPEdhYuRkyPI9vPI3IKxs6rqKYAgjgQ+8BdsLovQqQcTInw8B/4X5JrlJObVyW7RtU0TD8YPdl23T91aLJo9IXZYHw
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6919.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(38070700005)(508600001)(6512007)(38100700002)(4744005)(66946007)(66556008)(66476007)(76116006)(64756008)(71200400001)(66446008)(91956017)(122000001)(2906002)(54906003)(6486002)(6916009)(316002)(36756003)(186003)(6506007)(8936002)(33656002)(4326008)(26005)(86362001)(8676002)(5660300002)(53546011)(2616005)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-ID: <56B072043E7D724E85383B2E85EF6376@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6023
Original-Authentication-Results: xenproject.org; dkim=none (message not signed)
 header.d=none;xenproject.org; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT037.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	2d6c9c6c-48ca-4b04-295a-08d988baeb9b
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	nPtoMiMx7/4G+Nz23xqO8be80E44JW0YuAzFNWIBFNiCjXhZ05uQSzc7+N01wMrSGlVC47nY+AifwV7gOv9znTeWe1B5W+0r7pJsaxsi53d5uy8hK8kTRTcw/jJDzZZnpSD++UG5f8kpy7IfkX61fhvHmQYulEq95er6Y4Rge6rCPlvgWx88xxvaFOf6Lvu2Gwv65hUJvHNpkcrCVwziSC1GAghM0UJrgXQ4RXOVf9QA8lg9CwwYF4TjYJEqk27hp9a6AscmIopDckOKur6O6lbPlK+FrcUnpMl2rQpXkrjnkCd1Z1mHSS+vy+iHELeNSAb2jup/HZOUtSYCwAEGckihryO5BGPELdeYEWtfIPK7+zQSE8/6x7EUpM+pP6mGi4y1yZtMTomZOiDWWvrEfPCZtDY7GmmbSF4vYuPu4uyBcXm7rFkrz83TY2fHa3C8Y7tQxFeIyKLIuWly1qaRIDF5/lTTjRnXXBAR+hHw9y7qxRdnitbAmUjVhb/i+K8kVkaIHvO15HSv0Es0QnPD5rpjrgI/aFdo9MyEwoQB8mnGLFimqsZjkD2EjZymNmqhGZ1CzXyRRFYUfVVeZOXf84tGIDi71FxyPMmTpqOtukDwlbXIjeIMZrbxkthlX7r4wHPoKlyqsvVwCDhHx6I3ngZm5iGJBGi/4ws2lj1+H53E7cNOYIg6Vm8XZpJruBjXwDtVQLCxx9R4wx0zx+nScw==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(5660300002)(316002)(82310400003)(81166007)(4744005)(33656002)(26005)(70586007)(356005)(8936002)(8676002)(6486002)(107886003)(54906003)(6512007)(2906002)(336012)(36860700001)(6506007)(53546011)(47076005)(4326008)(86362001)(186003)(70206006)(508600001)(36756003)(6862004)(2616005);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Oct 2021 11:17:52.2399
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: e7d31a71-6d2c-4005-a074-08d988baf01e
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT037.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB4404

SGkgSWFuCQ0KDQo+IE9uIDYgT2N0IDIwMjEsIGF0IDEyOjA3IHBtLCBJYW4gSmFja3NvbiA8aXdq
QHhlbnByb2plY3Qub3JnPiB3cm90ZToNCj4gDQo+IFJhaHVsIFNpbmdoIHdyaXRlcyAoIlJlOiBb
UEFUQ0ggdjQgMTMvMTRdIGFybS9saWJ4bDogRW11bGF0ZWQgUENJIGRldmljZSB0cmVlIG5vZGUg
aW4gbGlieGwiKToNCj4+IGxpYnhsX2RlZmJvb2xfdmFsKGxpYnhsX2RlZmJvb2wgZGIpIGlzIGlt
cGxlbWVudGVkIGluIHN1Y2ggYSB3YXkgdGhhdCBpdCB3aWxsIGFzc2VydCANCj4+IGlmIGRiIHZh
bHVlIGlzIHRoZSBkZWZhdWx0LiBUaGVyZWZvcmUgd2UgaGF2ZSB0byBleHBsaWNpdGx5IHNldCBp
dCB0byBMSUJYTF9fREVGQk9PTF9GQUxTRSBmb3IgeDg2Lg0KPj4gDQo+PiBUaGVyZSBhcmUgdHdv
IG9wdGlvbiBlaXRoZXIgd2UgY2FuIGhhdmUgI2lmZGVmIG9yIHdlIGNhbiBtb3ZlIHRoZSANCj4+
IGxpYnhsX2RlZmJvb2xfc2V0ZGVmYXVsdCgmYl9pbmZvLT5hcmNoX2FybS52cGNpLCBmYWxzZSkg
dG8gY29tbW9uIGNvZGUuDQo+IA0KPiBXaGF0IGlzIHdyb25nIHdpdGggcHV0dGluZyBpdCBpbg0K
PiBsaWJ4bF9fYXJjaF9kb21haW5fYnVpbGRfaW5mb19zZXRkZWZhdWx0DQo+IHdoaWNoIEkgdGhp
bmsgZXhpc3RzIHByZWNpc2VseSBmb3IgdGhpcyBraW5kIG9mIHRoaW5nID8NCg0KQXMgd2UgaGF2
ZSB0byBzZXQgdGhlIGFyY2hfYXJtLnZwY2kgdG8gZmFsc2UgZm9yIHg4NiBhbmQgQVJNIEkgdGhv
dWdodCBpdCBpcyByaWdodCB0byBtb3ZlIHRoZSBjb2RlIHRvDQpjb21tb24gY29kZSB0byBhdm9p
ZCBkdXBsaWNhdGlvbi4NCg0KQXJlIHlvdSBzdWdnZXN0aW5nIHRvIHB1dCAiIGxpYnhsX2RlZmJv
b2xfc2V0ZGVmYXVsdCgmYl9pbmZvLT5hcmNoX2FybS52cGNpLCBmYWxzZSnigJ1pbiANCmxpYnhs
X19hcmNoX2RvbWFpbl9idWlsZF9pbmZvX3NldGRlZmF1bHQoKSBmb3IgeDg2IGFuZCBBUk0gZGlm
ZmVyZW50bHkuDQoNClJlZ2FyZHMsDQpSYWh1bA0KPiANCj4gSWFuLg0KDQo=


From xen-devel-bounces@lists.xenproject.org Wed Oct 06 11:18:30 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Oct 2021 11:18:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.202802.357822 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mY4wQ-0000Er-PZ; Wed, 06 Oct 2021 11:18:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 202802.357822; Wed, 06 Oct 2021 11:18:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mY4wQ-0000Ek-Lm; Wed, 06 Oct 2021 11:18:30 +0000
Received: by outflank-mailman (input) for mailman id 202802;
 Wed, 06 Oct 2021 11:18:29 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mY4wP-0000EU-E2
 for xen-devel@lists.xenproject.org; Wed, 06 Oct 2021 11:18:29 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mY4wP-0001sM-BR
 for xen-devel@lists.xenproject.org; Wed, 06 Oct 2021 11:18:29 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mY4wP-0000Cg-AM
 for xen-devel@lists.xenproject.org; Wed, 06 Oct 2021 11:18:29 +0000
Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89)
 (envelope-from <iwj@xenproject.org>)
 id 1mY4wN-0003E7-FM; Wed, 06 Oct 2021 12:18:27 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date
	:Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From;
	bh=Oh+Fc/4UGHzNC0C2oafvMPiCWQoBsDdskEOy2qOCf3o=; b=us5d2acbaLmfN3ut/QhXxu8tXm
	JcuexbQc9jGbQeCHXgAi6NQrnbhZ2bE8uz4CY+3hkcKrAS5Z0NkPsT/7jM2HRq3JSLm98zyqJ7dZy
	rOylxgCqa3E610IqiNmGLBJqUIFdbEa8gkDC8YAcyCMI+W8sVfZtdI9j93/VZFRQbUYY=;
From: Ian Jackson <iwj@xenproject.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <24925.34307.187952.463474@mariner.uk.xensource.com>
Date: Wed, 6 Oct 2021 12:18:27 +0100
To: xen-devel@lists.xenproject.org
Cc: committers@xenproject.org
Subject: Re: Xen 4.16 development update
In-Reply-To: <24913.54299.590779.955301@mariner.uk.xensource.com>
References: <24913.54299.590779.955301@mariner.uk.xensource.com>
X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu)

I wrote:
> Planned release schedule for Xen 4.16 (recap):
> 
>   Friday 24th September   PASSED        Last posting date
> 
>     Patches adding new features should be posted to the mailing list
>     by this cate, although perhaps not in their final version.
>     (3 weeks)
> 
>   Friday 15th October                   Feature freeze
>  
>     Patches adding new features should be committed by this date.
>     Straightforward bugfixes may continue to be accepted by
>     maintainers.

As previously noted, we have had a lack of review bandwidth which
means this release will be light on content.  We discussed but
rejected the possibility of extending the release (beyond Christmas,
to some time in January/February).

Under the circumstances, and considering some external constraints, I
am considering trying to *compress* the release schedule by
approximately one week.  The feature freeze data would remain the same
- we need to give people as much time to get things reviewed and into
tree as we can, but I think we can probably cut a week off the freeze.

That would look roughly like this:

>   Friday 15th October                   Feature freeze

      (2 weeks)

    Friday 29th October **tentatve**      Code freeze

      Bugfixes only, all changes to be approved by the Release Manager,
      on the basis of a (progressively stricter[*]) risk assessment.
      (2 weeks)

    Friday 12th November **tentative**    Hard code freeze [*]

      Bugfixes for serious bugs (including regressions), and low-risk
      fixes only.
      (0.5 weeks)

    Tuesday 16th November **tentative**   Branch off staging-4.16

      xen-unstable open again - with caveats to avoid release disruption.
      (1.5 weeks)

    Friday 26th November **tentative**    Final commits (docs/prep only)
    Week of 29th November **tentative**   Release
      (probably Tuesday or Wednesday)

Ian.


From xen-devel-bounces@lists.xenproject.org Wed Oct 06 11:22:36 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Oct 2021 11:22:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.202813.357832 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mY50N-0001iz-Ax; Wed, 06 Oct 2021 11:22:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 202813.357832; Wed, 06 Oct 2021 11:22:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mY50N-0001is-7o; Wed, 06 Oct 2021 11:22:35 +0000
Received: by outflank-mailman (input) for mailman id 202813;
 Wed, 06 Oct 2021 11:22:33 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=RZr5=O2=gmail.com=olekstysh@srs-us1.protection.inumbo.net>)
 id 1mY50L-0001im-LD
 for xen-devel@lists.xenproject.org; Wed, 06 Oct 2021 11:22:33 +0000
Received: from mail-lf1-x129.google.com (unknown [2a00:1450:4864:20::129])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 05e073ce-9d93-457f-88d5-91894cc63882;
 Wed, 06 Oct 2021 11:22:32 +0000 (UTC)
Received: by mail-lf1-x129.google.com with SMTP id n8so8860184lfk.6
 for <xen-devel@lists.xenproject.org>; Wed, 06 Oct 2021 04:22:32 -0700 (PDT)
Received: from otyshchenko.router ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id l14sm1002101lfe.124.2021.10.06.04.22.30
 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
 Wed, 06 Oct 2021 04:22:31 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 05e073ce-9d93-457f-88d5-91894cc63882
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id;
        bh=ZhSLsOP6lsWn/L5EMw3XksYmd81bgikwOdA/ODGGuFU=;
        b=BrAJcUCQ1jhmBKSrWsqilU+HDbqqHOARC63p8U/xATxRZwj2kSVJFrVAuKmjuI1xYW
         a5yLAXFg+j+8LLMfq0SBSWERuA1rLc7VYB1WD8A0ckvuD8fWE3lc6qEzIiKIg9gyNeXy
         1Y5s9sNet9CuMuiEbF+3vTORmojx7M47BbcwdD4zyANpwtDnL8qwxx+i4F2HAyvieA7P
         fEswILbz7SOLoC006SR+w48f+p87cH2DME3bu5EhKaxb8A+KstwrRhHU4HGImtqU8g0P
         EmjlYsvLC2x9UITntDWrSsC/NOlJCCjYzX5fCaY4nYK9MTIV9UG+QUO4rHgvN4K/P8ZD
         t9Jw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id;
        bh=ZhSLsOP6lsWn/L5EMw3XksYmd81bgikwOdA/ODGGuFU=;
        b=PyD58yA8zcnmYeCbMpA0Wcva6TmKJ+D4ZzBFjsSlhkBpbvRGjLf3laJ5u8BV9nU/sM
         S4MOycdnTyevv5KJTJxaSvaphSnmDQ4asZIQ5y5rJG9r5aHRvH4PUvadNxJpn9sFkFuv
         E3HrGQbo5kvtB28HDqRhmWB10O9ldjtuaZckMsklWRzPaXrdBzjYQ5szms2rTBLEpCvr
         dt+UmVRyDEfyFvg88psDojew+5w45CkC5rrfkpTaT4Hcj+h1UBIcloyyYTAp+3taYpCH
         UodM7OI1W8Gm2hQSq5Mz7O4n5bUzYdRbEA8IzenccXrfBMv27jwXTIpTHJ0hEvsANh0F
         HC2g==
X-Gm-Message-State: AOAM532WmCjzavlhH2bS7/vTowiE8hGi8IxmaF7WO6zbc3JW0fBhYejs
	/QAled/kYmmZQhUWY1YSrYCLZ8qzmso=
X-Google-Smtp-Source: ABdhPJyYo4Zu3hM+ebs4ZZYmJR8fy2Cfmjk6/eKIxkjNqqDgCJ//WPZICs4tC9Y58zhrwqDDbYxlfw==
X-Received: by 2002:a05:6512:3190:: with SMTP id i16mr8789406lfe.104.1633519351430;
        Wed, 06 Oct 2021 04:22:31 -0700 (PDT)
From: Oleksandr Tyshchenko <olekstysh@gmail.com>
To: xen-devel@lists.xenproject.org
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Ian Jackson <iwj@xenproject.org>,
	Wei Liu <wl@xen.org>,
	Anthony PERARD <anthony.perard@citrix.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Juergen Gross <jgross@suse.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Henry Wang <Henry.Wang@arm.com>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Wei Chen <Wei.Chen@arm.com>
Subject: [PATCH V5 0/3] Add handling of extended regions (safe ranges) on Arm (Was "xen/memory: Introduce a hypercall to provide unallocated space")
Date: Wed,  6 Oct 2021 14:22:23 +0300
Message-Id: <1633519346-3686-1-git-send-email-olekstysh@gmail.com>
X-Mailer: git-send-email 2.7.4

From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>

You can find an initial discussion at [1]-[5].

The extended region (safe range) is a region of guest physical address space
which is unused and could be safely used to create grant/foreign mappings instead
of wasting real RAM pages from the domain memory for establishing these mappings.

The extended regions are chosen at the domain creation time and advertised
to it via "reg" property under hypervisor node in the guest device-tree
(the indexes for extended regions are 1...N).
No device tree bindings update is needed, guest infers the presense of extended
regions from the number of regions in "reg" property.
New compatible/property will be needed (but only after this patch [6] or alternative
goes in) to indicate that "region 0 is safe to use". Until this patch is merged it is
not safe to use extended regions for the grant table space.

The extended regions are calculated differently for direct mapped Dom0 (with and without
IOMMU) and non-direct mapped DomUs.

Please note the following limitations:
- The extended region feature is only supported for 64-bit domain currently.
- The ACPI case is not covered.

Please note that support for Dom0 [7] was already committed and the last patch in this series
is a requested follow-up.

Xen patch series is also available at [8]. The corresponding Linux patch series is at [9]
for now (last 4 patches).

Tested on Renesas Salvator-X board + H3 ES3.0 SoC (Arm64) with updated virtio-disk backend [10]
running in Dom0 (256MB RAM) and DomD (2GB RAM). In both cases the backend pre-maps DomU memory
which is 3GB. All foreign memory gets mapped into extended regions (so the amount of RAM in
the backend domain is not reduced). No issues were observed.

[1] https://lore.kernel.org/xen-devel/1627489110-25633-1-git-send-email-olekstysh@gmail.com/
[2] https://lore.kernel.org/xen-devel/1631034578-12598-1-git-send-email-olekstysh@gmail.com/
[3] https://lore.kernel.org/xen-devel/1631297924-8658-1-git-send-email-olekstysh@gmail.com/
[4] https://lore.kernel.org/xen-devel/1632437334-12015-1-git-send-email-olekstysh@gmail.com/
[5] https://lore.kernel.org/xen-devel/1632955927-27911-1-git-send-email-olekstysh@gmail.com/
[6] https://lore.kernel.org/xen-devel/1632425551-18910-1-git-send-email-olekstysh@gmail.com/
[7] https://lore.kernel.org/xen-devel/1632955927-27911-3-git-send-email-olekstysh@gmail.com/
[8] https://github.com/otyshchenko1/xen/commits/map_opt_ml6
[9] https://github.com/otyshchenko1/linux/commits/map_opt_ml4
[10] https://github.com/otyshchenko1/virtio-disk/commits/map_opt_next

Oleksandr Tyshchenko (3):
  xen/arm: Introduce gpaddr_bits field to struct xen_arch_domainconfig
  libxl/arm: Add handling of extended regions for DomU
  xen/arm: Updates for extended regions support

 docs/misc/arm/device-tree/guest.txt |  12 ++--
 tools/include/libxl.h               |   5 ++
 tools/libs/light/libxl_arm.c        |  82 +++++++++++++++++++++++++--
 tools/libs/light/libxl_types.idl    |   1 +
 xen/arch/arm/domain.c               |   6 ++
 xen/arch/arm/domain_build.c         | 108 ++++++++++++++++++++++--------------
 xen/include/public/arch-arm.h       |   7 +++
 xen/include/public/domctl.h         |   2 +-
 8 files changed, 170 insertions(+), 53 deletions(-)

-- 
2.7.4



From xen-devel-bounces@lists.xenproject.org Wed Oct 06 11:22:39 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Oct 2021 11:22:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.202814.357843 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mY50R-00021H-MY; Wed, 06 Oct 2021 11:22:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 202814.357843; Wed, 06 Oct 2021 11:22:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mY50R-00021A-J9; Wed, 06 Oct 2021 11:22:39 +0000
Received: by outflank-mailman (input) for mailman id 202814;
 Wed, 06 Oct 2021 11:22:38 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=RZr5=O2=gmail.com=olekstysh@srs-us1.protection.inumbo.net>)
 id 1mY50Q-0001im-Hn
 for xen-devel@lists.xenproject.org; Wed, 06 Oct 2021 11:22:38 +0000
Received: from mail-lf1-x135.google.com (unknown [2a00:1450:4864:20::135])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id c6fdf512-6641-4e7c-be61-80f567d47e2c;
 Wed, 06 Oct 2021 11:22:33 +0000 (UTC)
Received: by mail-lf1-x135.google.com with SMTP id r19so8748166lfe.10
 for <xen-devel@lists.xenproject.org>; Wed, 06 Oct 2021 04:22:33 -0700 (PDT)
Received: from otyshchenko.router ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id l14sm1002101lfe.124.2021.10.06.04.22.31
 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
 Wed, 06 Oct 2021 04:22:32 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c6fdf512-6641-4e7c-be61-80f567d47e2c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references;
        bh=CcbmLT6d9wwXQN2hKHL5MK8rkv/Z2/lvlmA1gHA67xo=;
        b=GsAn4INN10u1/v1hz/ZkEhtBJY66i72oHgoG9pe3ZbRPE2J27yqyldBWdhMOpv3gVG
         iLU2hJIZuCKxakfU9cty7zC2sBb0pto0SWlVbsNHVho0cGq2r436F5NMUSEHxhvhWfXt
         u8eB6agjfiLb5PKyMn3vvXYwdHAjwlMHXnn97ZB6Gb99b/zbiI7roSKIhUSMreMZYzx8
         UKyV4v2NhsYGfrOpunafCxU9psnsrHyj4gMj4Dy0MEH6Y6KH/RqZ/BbwCscwpp0RfoGZ
         tfgGgJI0fofdf0iEsOXy2i08gQ+EVlgAwvPPsdrY9tU90edhAg057Pn7yZgmp58buZkD
         HrIA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references;
        bh=CcbmLT6d9wwXQN2hKHL5MK8rkv/Z2/lvlmA1gHA67xo=;
        b=1PR8IQuPet467s+eV0hXEXrgMX5WmU4oU9XlMbGF1EDwoSIt9Vo5gJRbhPopuesQme
         KL43wBKVF7yXmHKzX2NAUlpPMB3wBJI4ktLwAIq2lrKkbgWNpfi/B7ixFPoE5CaxviK4
         EwxCiwyJtP/Nu2kE2Zfw32jhIeidjDSMqGKCO1g08/gH53l1WHIfWKliXHqwdqLxn8QW
         0fskFcbT0V6iWyB+Y7CGKUI0pzawcvVnB+W0WUNwettyoilSRTDni1X0VZKgwKs4KeyB
         QWSyHuv0/fg7aBgsdUyngcjxb/rD5PGABjvV4UdnOs5w9Xkb0gpfUpmnnfxdWqd98gLG
         1LEQ==
X-Gm-Message-State: AOAM533JVsfhlfFMXT+/0U+N46eQRyQf1sL/+uaSJuxpjbif1UqPCeL7
	jwKb8o7VR2Kk8gSbZBxyDfm0KYtp33E=
X-Google-Smtp-Source: ABdhPJyvoQ2Zt//ZO//Id6aWJq18Tx8FMqiKtwk5cBvQZRuoqXRt40eLqf49yP7vRWFg3N9eGblE2Q==
X-Received: by 2002:a05:651c:1b8:: with SMTP id c24mr29426570ljn.520.1633519352266;
        Wed, 06 Oct 2021 04:22:32 -0700 (PDT)
From: Oleksandr Tyshchenko <olekstysh@gmail.com>
To: xen-devel@lists.xenproject.org
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Ian Jackson <iwj@xenproject.org>,
	Wei Liu <wl@xen.org>,
	Anthony PERARD <anthony.perard@citrix.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Juergen Gross <jgross@suse.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: [PATCH V5 1/3] xen/arm: Introduce gpaddr_bits field to struct xen_arch_domainconfig
Date: Wed,  6 Oct 2021 14:22:24 +0300
Message-Id: <1633519346-3686-2-git-send-email-olekstysh@gmail.com>
X-Mailer: git-send-email 2.7.4
In-Reply-To: <1633519346-3686-1-git-send-email-olekstysh@gmail.com>
References: <1633519346-3686-1-git-send-email-olekstysh@gmail.com>

From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>

We need to pass info about maximum supported guest physical
address space size to the toolstack on Arm in order to properly
calculate the base and size of the extended region (safe range)
for the guest. The extended region is unused address space which
could be safely used by domain for foreign/grant mappings on Arm.
The extended region itself will be handled by the subsequent
patch.

Currently the same guest physical address space size is used
for all guests.

As we add new field to the structure bump the interface version.

Suggested-by: Julien Grall <jgrall@amazon.com>
Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
---
Changes RFC -> V2:
   - update patch subject/description
   - replace arch-specific sub-struct with common gpaddr_bits
     field and update code to reflect that

Changes V2 -> V3:
   - make the field uint8_t and add uint8_t pad[7] after
   - remove leading blanks in libxl.h

Changes V3 -> V4:
   - also print gpaddr_bits from output_physinfo()
   - add Michal's R-b

Changes V4 -> V5:
   - update patch subject and description
   - drop Michal's R-b
   - pass gpaddr_bits via createdomain domctl
     (struct xen_arch_domainconfig)
---
 tools/include/libxl.h            | 5 +++++
 tools/libs/light/libxl_arm.c     | 2 ++
 tools/libs/light/libxl_types.idl | 1 +
 xen/arch/arm/domain.c            | 6 ++++++
 xen/include/public/arch-arm.h    | 5 +++++
 xen/include/public/domctl.h      | 2 +-
 6 files changed, 20 insertions(+), 1 deletion(-)

diff --git a/tools/include/libxl.h b/tools/include/libxl.h
index b9ba16d..33b4bfb 100644
--- a/tools/include/libxl.h
+++ b/tools/include/libxl.h
@@ -279,6 +279,11 @@
 #define LIBXL_HAVE_BUILDINFO_ARCH_ARM_TEE 1
 
 /*
+ * libxl_domain_build_info has the gpaddr_bits field.
+ */
+#define LIBXL_HAVE_BUILDINFO_ARCH_ARM_GPADDR_BITS 1
+
+/*
  * LIBXL_HAVE_SOFT_RESET indicates that libxl supports performing
  * 'soft reset' for domains and there is 'soft_reset' shutdown reason
  * in enum libxl_shutdown_reason.
diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c
index e3140a6..45e0386 100644
--- a/tools/libs/light/libxl_arm.c
+++ b/tools/libs/light/libxl_arm.c
@@ -123,6 +123,8 @@ int libxl__arch_domain_save_config(libxl__gc *gc,
 
     state->clock_frequency = config->arch.clock_frequency;
 
+    d_config->b_info.arch_arm.gpaddr_bits = config->arch.gpaddr_bits;
+
     return 0;
 }
 
diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_types.idl
index 3f9fff6..39482db 100644
--- a/tools/libs/light/libxl_types.idl
+++ b/tools/libs/light/libxl_types.idl
@@ -644,6 +644,7 @@ libxl_domain_build_info = Struct("domain_build_info",[
 
     ("arch_arm", Struct(None, [("gic_version", libxl_gic_version),
                                ("vuart", libxl_vuart_type),
+                               ("gpaddr_bits", uint8),
                               ])),
     ("arch_x86", Struct(None, [("msr_relaxed", libxl_defbool),
                               ])),
diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
index 19c756a..dfecc45 100644
--- a/xen/arch/arm/domain.c
+++ b/xen/arch/arm/domain.c
@@ -767,6 +767,12 @@ int arch_domain_create(struct domain *d,
     if ( is_hardware_domain(d) && (rc = domain_vuart_init(d)) )
         goto fail;
 
+    /*
+     * Pass maximum IPA bits to the toolstack, currently the same guest
+     * physical address space size is used for all guests.
+     */
+    config->arch.gpaddr_bits = p2m_ipa_bits;
+
     return 0;
 
 fail:
diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h
index 6b5a5f8..4a01f8b 100644
--- a/xen/include/public/arch-arm.h
+++ b/xen/include/public/arch-arm.h
@@ -333,6 +333,11 @@ struct xen_arch_domainconfig {
      *
      */
     uint32_t clock_frequency;
+    /*
+     * OUT
+     * Guest physical address space size
+     */
+    uint8_t gpaddr_bits;
 };
 #endif /* __XEN__ || __XEN_TOOLS__ */
 
diff --git a/xen/include/public/domctl.h b/xen/include/public/domctl.h
index 96696e3..f37586e 100644
--- a/xen/include/public/domctl.h
+++ b/xen/include/public/domctl.h
@@ -38,7 +38,7 @@
 #include "hvm/save.h"
 #include "memory.h"
 
-#define XEN_DOMCTL_INTERFACE_VERSION 0x00000014
+#define XEN_DOMCTL_INTERFACE_VERSION 0x00000015
 
 /*
  * NB. xen_domctl.domain is an IN/OUT parameter for this operation.
-- 
2.7.4



From xen-devel-bounces@lists.xenproject.org Wed Oct 06 11:22:45 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Oct 2021 11:22:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.202815.357855 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mY50W-0002NB-Vu; Wed, 06 Oct 2021 11:22:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 202815.357855; Wed, 06 Oct 2021 11:22:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mY50W-0002N4-SZ; Wed, 06 Oct 2021 11:22:44 +0000
Received: by outflank-mailman (input) for mailman id 202815;
 Wed, 06 Oct 2021 11:22:43 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=RZr5=O2=gmail.com=olekstysh@srs-us1.protection.inumbo.net>)
 id 1mY50V-0001im-Hz
 for xen-devel@lists.xenproject.org; Wed, 06 Oct 2021 11:22:43 +0000
Received: from mail-lf1-x135.google.com (unknown [2a00:1450:4864:20::135])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id f8ddf3c1-ae3e-44dd-8455-ddf57fe55064;
 Wed, 06 Oct 2021 11:22:34 +0000 (UTC)
Received: by mail-lf1-x135.google.com with SMTP id b20so9015986lfv.3
 for <xen-devel@lists.xenproject.org>; Wed, 06 Oct 2021 04:22:34 -0700 (PDT)
Received: from otyshchenko.router ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id l14sm1002101lfe.124.2021.10.06.04.22.32
 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
 Wed, 06 Oct 2021 04:22:32 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f8ddf3c1-ae3e-44dd-8455-ddf57fe55064
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references;
        bh=rkR+rU5Y9+3oI0Oc5L3i/ut7iAcwGRf2f4nUZ2wYcHI=;
        b=ZapKta8DabGOllyBOfBN3LVjVOXwV0ftilSu1LyvVMh0+/2iVhbrDx2+Y2W6T+PlIL
         XQR4e0y580xgswyBht/LxLT7mUw134nR9Jn6ljpcMrqaFbN+PVhQpaAaOJIlzUhABKWu
         iCqUtecgUJdQQ2HTt4gac/WMU5wRuyVLbQJ/kjFpBJC4XtC1tHLJkxhrvnQVG+GLhP8g
         p+FtzfGF2aRUtao6q2H4EseWtOWg5BIXKDkEpdZ7g/fE+/VT6UBM4Qpb0DUlKgnyqvRr
         wLExOGK0bu03BqTDsI7ifNYLoYvNtHW/em/nXv6RGWVEMNqENAlUq7c55pnIDwgSAxdk
         7oEw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references;
        bh=rkR+rU5Y9+3oI0Oc5L3i/ut7iAcwGRf2f4nUZ2wYcHI=;
        b=x/TSueLz7T7i8I2gLhnfO1Fyv5UB3hXU/F/Ay0frVt+iBskScwVr2BhVJTpQ1iu31B
         wy+lxFzRln3hEUCqMdt0p07porTulaiF+BfHp+HnxHxeRy+Trjzis96K0Fda9zfkgPLl
         KsuL1O+SIvXycmaDsGjfYyluTiUQs5TiXrYjje1LNEdpttNX3/63SVINeQPjj+B1kfHl
         26yGtsTPnXu8Ql2HdKVwXwKqA8JVqi9e8cYJjTuJz9Ap86ejiQO/o1sawhpBYjPJwbqX
         ReEcMEnYtapJlyM7JlC598HNlPqtxYnAFBHMrqDkw0+mvL+f7Fb4l8c/qEVT4qXqFqns
         GnJQ==
X-Gm-Message-State: AOAM5306mZ/T45YSyP1sw9DpWm2IQPFC5L8+1peLK5U30sFQwBTmi1d2
	BwSSvf2Dil05J9bi7F5q50iYdX8RwV8=
X-Google-Smtp-Source: ABdhPJyA/+wXOBOZGX+gKm18/Y9VPDF1xOB/UR1RkCk7zbNGgSkXV6zNyaSIdSWvtScElmAMn325yA==
X-Received: by 2002:a2e:9b98:: with SMTP id z24mr27491363lji.339.1633519353096;
        Wed, 06 Oct 2021 04:22:33 -0700 (PDT)
From: Oleksandr Tyshchenko <olekstysh@gmail.com>
To: xen-devel@lists.xenproject.org
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Ian Jackson <iwj@xenproject.org>,
	Wei Liu <wl@xen.org>,
	Anthony PERARD <anthony.perard@citrix.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: [PATCH V5 2/3] libxl/arm: Add handling of extended regions for DomU
Date: Wed,  6 Oct 2021 14:22:25 +0300
Message-Id: <1633519346-3686-3-git-send-email-olekstysh@gmail.com>
X-Mailer: git-send-email 2.7.4
In-Reply-To: <1633519346-3686-1-git-send-email-olekstysh@gmail.com>
References: <1633519346-3686-1-git-send-email-olekstysh@gmail.com>

From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>

The extended region (safe range) is a region of guest physical
address space which is unused and could be safely used to create
grant/foreign mappings instead of wasting real RAM pages from
the domain memory for establishing these mappings.

The extended regions are chosen at the domain creation time and
advertised to it via "reg" property under hypervisor node in
the guest device-tree. As region 0 is reserved for grant table
space (always present), the indexes for extended regions are 1...N.
If extended regions could not be allocated for some reason,
Xen doesn't fail and behaves as usual, so only inserts region 0.

Please note the following limitations:
- The extended region feature is only supported for 64-bit domain
  currently.
- The ACPI case is not covered.

***

The algorithm to choose extended regions for non-direct mapped
DomU is simpler in comparison with the algorithm for direct mapped
Dom0. We usually have a lot of unused space above 4GB, and might
have some unused space below 4GB (depends on guest memory size).
Try to allocate separate 2MB-aligned extended regions from the first
(below 4GB) and second (above 4GB) RAM banks taking into the account
the maximum supported guest physical address space size and the amount
of memory assigned to the guest. The minimum size of extended region
the same as for Dom0 (64MB).

Suggested-by: Julien Grall <jgrall@amazon.com>
Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
---
! Stefano, Ian, Michal I dropped your A-b/R-b. I decided to change patch
to make it more functional !

Changes RFC -> V2:
   - update patch description
   - drop uneeded "extended-region" DT property
   - clear reg array in finalise_ext_region() and add a TODO

Changes V2 -> V3:
   - update patch description, comments in code
   - only pick up regions with size >= 64MB
   - move the region calculation to make_hypervisor_node() and drop
     finalise_ext_region()
   - extend the list of arguments for make_hypervisor_node()
   - do not show warning for 32-bit domain
   - change the region alignment from 1GB to 2MB
   - move EXT_REGION_SIZE to public/arch-arm.h

Changes V3 -> V4:
   - add R-b, A-b and T-b

Changes V4 -> V5:
   - update patch description and comments in code
   - reflect changes done in previous patch to pass gpaddr_bits
     via createdomain domctl (struct xen_arch_domainconfig)
   - drop R-b, A-b and T-b
   - drop limit for maximum extended region size (128GB)
   - try to also allocate region below 4GB, optimize code
     for calculating extended regions
---
 tools/libs/light/libxl_arm.c  | 80 ++++++++++++++++++++++++++++++++++++++++---
 xen/include/public/arch-arm.h |  2 ++
 2 files changed, 77 insertions(+), 5 deletions(-)

diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c
index 45e0386..cd743f7 100644
--- a/tools/libs/light/libxl_arm.c
+++ b/tools/libs/light/libxl_arm.c
@@ -600,9 +600,21 @@ static int make_timer_node(libxl__gc *gc, void *fdt,
     return 0;
 }
 
+#define ALIGN_UP_TO_2MB(x)   (((x) + MB(2) - 1) & (~(MB(2) - 1)))
+
 static int make_hypervisor_node(libxl__gc *gc, void *fdt,
-                                const libxl_version_info *vers)
+                                const libxl_version_info *vers,
+                                const libxl_domain_build_info *b_info,
+                                const struct xc_dom_image *dom)
 {
+    uint64_t region_size[GUEST_RAM_BANKS] = {0}, region_base[GUEST_RAM_BANKS],
+        banksize[GUEST_RAM_BANKS], bankend[GUEST_RAM_BANKS], ramsize;
+    uint32_t regs[(GUEST_ROOT_ADDRESS_CELLS + GUEST_ROOT_SIZE_CELLS) *
+                  (GUEST_RAM_BANKS + 1)];
+    be32 *cells = &regs[0];
+    const uint64_t bankbase[] = GUEST_RAM_BANK_BASES;
+    unsigned int i, len, nr_regions = 0;
+    uint8_t gpaddr_bits;
     int res;
     gic_interrupt intr;
 
@@ -617,9 +629,67 @@ static int make_hypervisor_node(libxl__gc *gc, void *fdt,
                               "xen,xen");
     if (res) return res;
 
-    /* reg 0 is grant table space */
-    res = fdt_property_regs(gc, fdt, GUEST_ROOT_ADDRESS_CELLS, GUEST_ROOT_SIZE_CELLS,
-                            1,GUEST_GNTTAB_BASE, GUEST_GNTTAB_SIZE);
+    if (strcmp(dom->guest_type, "xen-3.0-aarch64")) {
+        LOG(WARN, "The extended regions are only supported for 64-bit guest currently");
+        goto out;
+    }
+
+    gpaddr_bits = b_info->arch_arm.gpaddr_bits;
+    assert(gpaddr_bits >= 32 && gpaddr_bits <= 48);
+
+    /*
+     * Try to allocate separate 2MB-aligned extended regions from the first
+     * (below 4GB) and second (above 4GB) RAM banks taking into the account
+     * the maximum supported guest physical address space size and the amount
+     * of memory assigned to the guest.
+     * As the guest memory layout is not populated yet we cannot rely on
+     * dom->rambank_size[], so calculate the actual size of both banks using
+     * "max_memkb" value.
+     */
+    ramsize = b_info->max_memkb * 1024;
+    if (ramsize <= GUEST_RAM0_SIZE) {
+        banksize[0] = ramsize;
+        banksize[1] = 0;
+    } else {
+        banksize[0] = GUEST_RAM0_SIZE;
+        banksize[1] = ramsize - GUEST_RAM0_SIZE;
+    }
+
+    bankend[0] = GUEST_RAM0_BASE + GUEST_RAM0_SIZE;
+    bankend[1] = min(1ULL << gpaddr_bits, GUEST_RAM1_BASE + GUEST_RAM1_SIZE);
+
+    for (i = 0; i < GUEST_RAM_BANKS; i++) {
+        region_base[i] = bankbase[i] + ALIGN_UP_TO_2MB(banksize[i]);
+        if (bankend[i] > region_base[i])
+            region_size[i] = bankend[i] - region_base[i];
+    }
+
+out:
+    /*
+     * The region 0 for grant table space must be always present. If we managed
+     * to allocate the extended regions then insert them as regions 1...N.
+     */
+    set_range(&cells, GUEST_ROOT_ADDRESS_CELLS, GUEST_ROOT_SIZE_CELLS,
+              GUEST_GNTTAB_BASE, GUEST_GNTTAB_SIZE);
+
+    for (i = 0; i < GUEST_RAM_BANKS; i++) {
+        if (region_size[i] < GUEST_EXT_REGION_MIN_SIZE)
+            continue;
+
+        LOG(DEBUG, "Extended region %u: %#"PRIx64"->%#"PRIx64"\n",
+            nr_regions, region_base[i], region_base[i] + region_size[i]);
+
+        set_range(&cells, GUEST_ROOT_ADDRESS_CELLS, GUEST_ROOT_SIZE_CELLS,
+                  region_base[i], region_size[i]);
+        nr_regions ++;
+    }
+
+    if (!nr_regions)
+        LOG(WARN, "The extended regions cannot be allocated, not enough space");
+
+    len = sizeof(regs[0]) * (GUEST_ROOT_ADDRESS_CELLS + GUEST_ROOT_SIZE_CELLS) *
+        (nr_regions + 1);
+    res = fdt_property(fdt, "reg", regs, len);
     if (res) return res;
 
     /*
@@ -965,7 +1035,7 @@ next_resize:
         }
 
         FDT( make_timer_node(gc, fdt, ainfo, state->clock_frequency) );
-        FDT( make_hypervisor_node(gc, fdt, vers) );
+        FDT( make_hypervisor_node(gc, fdt, vers, info, dom) );
 
         if (info->arch_arm.vuart == LIBXL_VUART_TYPE_SBSA_UART)
             FDT( make_vpl011_uart_node(gc, fdt, ainfo, dom) );
diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h
index 4a01f8b..f74cc0b 100644
--- a/xen/include/public/arch-arm.h
+++ b/xen/include/public/arch-arm.h
@@ -454,6 +454,8 @@ typedef uint64_t xen_callback_t;
 #define GUEST_RAM_BANK_BASES   { GUEST_RAM0_BASE, GUEST_RAM1_BASE }
 #define GUEST_RAM_BANK_SIZES   { GUEST_RAM0_SIZE, GUEST_RAM1_SIZE }
 
+#define GUEST_EXT_REGION_MIN_SIZE   xen_mk_ullong(0x0004000000) /* 64MB */
+
 /* Current supported guest VCPUs */
 #define GUEST_MAX_VCPUS 128
 
-- 
2.7.4



From xen-devel-bounces@lists.xenproject.org Wed Oct 06 11:22:50 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Oct 2021 11:22:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.202817.357866 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mY50c-0002nH-9m; Wed, 06 Oct 2021 11:22:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 202817.357866; Wed, 06 Oct 2021 11:22:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mY50c-0002mw-5T; Wed, 06 Oct 2021 11:22:50 +0000
Received: by outflank-mailman (input) for mailman id 202817;
 Wed, 06 Oct 2021 11:22:48 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=RZr5=O2=gmail.com=olekstysh@srs-us1.protection.inumbo.net>)
 id 1mY50a-0001im-IO
 for xen-devel@lists.xenproject.org; Wed, 06 Oct 2021 11:22:48 +0000
Received: from mail-lf1-x12c.google.com (unknown [2a00:1450:4864:20::12c])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 710e5734-36c3-45dd-835d-331db318602f;
 Wed, 06 Oct 2021 11:22:35 +0000 (UTC)
Received: by mail-lf1-x12c.google.com with SMTP id b20so9016152lfv.3
 for <xen-devel@lists.xenproject.org>; Wed, 06 Oct 2021 04:22:34 -0700 (PDT)
Received: from otyshchenko.router ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id l14sm1002101lfe.124.2021.10.06.04.22.33
 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
 Wed, 06 Oct 2021 04:22:33 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 710e5734-36c3-45dd-835d-331db318602f
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references;
        bh=Rtq6Pj4F8ozkEpAk2DlH7ilXrtLILHIJ9p4nUtH8GRQ=;
        b=hSGK7kM9kvHazi1anZypIGHpO3d5E+YfBkg/VhFd2QAjg5JGvWXoPuznbV/hsOUESz
         YRkgvzRYKvmGvmlYBkWNIHouYtRTqcc7s1X5A6MtJAWQBOC5xR+iJ6eL/FKevnq6tC2H
         qZTQpRc2VxhBIwqaOG753EvKP1pyrCgoGaOTJ1YpDh62BXJBY/R5S9tuRMZyAaIpwivU
         XTfderWbKvJw80KELUp36e6KAbcPQUEwmHhm48qCnK8xmq+XxEHj6qxejcuVYIooxhcy
         aUq2ST4V4xnuq8CjnnHZtegYuRalGKdGsM6HXG+Rl7ACWPKzxpi3MqgJ16uTPKIeYkSs
         lPCw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references;
        bh=Rtq6Pj4F8ozkEpAk2DlH7ilXrtLILHIJ9p4nUtH8GRQ=;
        b=siZMa3FzXrZUR7ZwSWh2PcfXFOh8F7PADzceocbfAbZoDTqxGyiOZ2vVljxe/AhZiX
         hlb8ByPo3DD6FXiLvpGnFTBWUSc+cMJXO08fmy2tEtquYk4FYvmSmsr9tZ6gF47pElZT
         qCMNI2+ozKlnzuyWDI2R6Xm3PLUp9nNL17HcrM8oigfMcqsL7xv7sCLhzVdGxMmrSEpj
         avE6ncOicKXG1t5xL+9upO4pT2pgDuJ70nqIsLWOyTxXnbzZYxm33aF3MPHNi2aod+bA
         ZYc4REotsKPpGw4cQfkKkmL20wdHYNqz9gCFto+UEAA++5mWApO7GZBoejRQQ169vFD8
         ifJQ==
X-Gm-Message-State: AOAM5331uj/v+b8MqItNI1niINZ/ALg7tK966/d5y3QECOS61BAopeih
	rhmgrSSP7b5p2IdzWRml+7OTlN4gRpQ=
X-Google-Smtp-Source: ABdhPJwHLieFYd8pJDDpfNyisXMWFeyFFALV5LAJWTfI4EfWgB3D5uFRWSZROcIJMs4U4qL9NAkd0g==
X-Received: by 2002:a2e:8090:: with SMTP id i16mr27135322ljg.296.1633519353796;
        Wed, 06 Oct 2021 04:22:33 -0700 (PDT)
From: Oleksandr Tyshchenko <olekstysh@gmail.com>
To: xen-devel@lists.xenproject.org
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: [PATCH V5 3/3] xen/arm: Updates for extended regions support
Date: Wed,  6 Oct 2021 14:22:26 +0300
Message-Id: <1633519346-3686-4-git-send-email-olekstysh@gmail.com>
X-Mailer: git-send-email 2.7.4
In-Reply-To: <1633519346-3686-1-git-send-email-olekstysh@gmail.com>
References: <1633519346-3686-1-git-send-email-olekstysh@gmail.com>

From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>

This is a follow-up of
"b6fe410 xen/arm: Add handling of extended regions for Dom0"

Add various in-code comments, update Xen hypervisor device tree
bindings text, change the log level for some prints and clarify
format specifier, reuse dt_for_each_range() to avoid open-coding
in find_memory_holes().

Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
---
   New patch
---
 docs/misc/arm/device-tree/guest.txt |  12 ++--
 xen/arch/arm/domain_build.c         | 108 ++++++++++++++++++++++--------------
 2 files changed, 73 insertions(+), 47 deletions(-)

diff --git a/docs/misc/arm/device-tree/guest.txt b/docs/misc/arm/device-tree/guest.txt
index 418f1e9..c115751 100644
--- a/docs/misc/arm/device-tree/guest.txt
+++ b/docs/misc/arm/device-tree/guest.txt
@@ -7,10 +7,14 @@ the following properties:
 	compatible = "xen,xen-<version>", "xen,xen";
   where <version> is the version of the Xen ABI of the platform.
 
-- reg: specifies the base physical address and size of a region in
-  memory where the grant table should be mapped to, using an
-  HYPERVISOR_memory_op hypercall. The memory region is large enough to map
-  the whole grant table (it is larger or equal to gnttab_max_grant_frames()).
+- reg: specifies the base physical address and size of the regions in memory
+  where the special resources should be mapped to, using an HYPERVISOR_memory_op
+  hypercall.
+  Region 0 is reserved for mapping grant table, it must be always present.
+  The memory region is large enough to map the whole grant table (it is larger
+  or equal to gnttab_max_grant_frames()).
+  Regions 1...N are extended regions (unused address space) for mapping foreign
+  GFNs and grants, they might be absent if there is nothing to expose.
   This property is unnecessary when booting Dom0 using ACPI.
 
 - interrupts: the interrupt used by Xen to inject event notifications.
diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
index c5afbe2..d9f40d4 100644
--- a/xen/arch/arm/domain_build.c
+++ b/xen/arch/arm/domain_build.c
@@ -898,7 +898,10 @@ static int __init add_ext_regions(unsigned long s, unsigned long e, void *data)
     if ( ext_regions->nr_banks >= ARRAY_SIZE(ext_regions->bank) )
         return 0;
 
-    /* Both start and size of the extended region should be 2MB aligned */
+    /*
+     * Both start and size of the extended region should be 2MB aligned to
+     * potentially allow superpage mapping.
+     */
     start = (s + SZ_2M - 1) & ~(SZ_2M - 1);
     if ( start > e )
         return 0;
@@ -909,6 +912,12 @@ static int __init add_ext_regions(unsigned long s, unsigned long e, void *data)
      */
     e += 1;
     size = (e - start) & ~(SZ_2M - 1);
+
+    /*
+     * Reasonable size. Not too little to pick up small ranges which are
+     * not quite useful itself but increase bookkeeping and not too much
+     * to skip a large proportion of unused address space.
+     */
     if ( size < MB(64) )
         return 0;
 
@@ -919,6 +928,14 @@ static int __init add_ext_regions(unsigned long s, unsigned long e, void *data)
     return 0;
 }
 
+/*
+ * Find unused regions of Host address space which can be exposed to Dom0
+ * as extended regions for the special memory mappings. In order to calculate
+ * regions we exclude every assigned to Dom0 region from the Host RAM:
+ * - domain RAM
+ * - reserved-memory
+ * - grant table space
+ */
 static int __init find_unallocated_memory(const struct kernel_info *kinfo,
                                           struct meminfo *ext_regions)
 {
@@ -942,7 +959,7 @@ static int __init find_unallocated_memory(const struct kernel_info *kinfo,
         res = rangeset_add_range(unalloc_mem, start, end - 1);
         if ( res )
         {
-            printk(XENLOG_ERR "Failed to add: %#"PRIx64"->%#"PRIx64"\n",
+            printk(XENLOG_ERR "Failed to add: %#"PRIpaddr"->%#"PRIpaddr"\n",
                    start, end);
             goto out;
         }
@@ -956,7 +973,7 @@ static int __init find_unallocated_memory(const struct kernel_info *kinfo,
         res = rangeset_remove_range(unalloc_mem, start, end - 1);
         if ( res )
         {
-            printk(XENLOG_ERR "Failed to remove: %#"PRIx64"->%#"PRIx64"\n",
+            printk(XENLOG_ERR "Failed to remove: %#"PRIpaddr"->%#"PRIpaddr"\n",
                    start, end);
             goto out;
         }
@@ -971,7 +988,7 @@ static int __init find_unallocated_memory(const struct kernel_info *kinfo,
         res = rangeset_remove_range(unalloc_mem, start, end - 1);
         if ( res )
         {
-            printk(XENLOG_ERR "Failed to remove: %#"PRIx64"->%#"PRIx64"\n",
+            printk(XENLOG_ERR "Failed to remove: %#"PRIpaddr"->%#"PRIpaddr"\n",
                    start, end);
             goto out;
         }
@@ -983,7 +1000,7 @@ static int __init find_unallocated_memory(const struct kernel_info *kinfo,
     res = rangeset_remove_range(unalloc_mem, start, end - 1);
     if ( res )
     {
-        printk(XENLOG_ERR "Failed to remove: %#"PRIx64"->%#"PRIx64"\n",
+        printk(XENLOG_ERR "Failed to remove: %#"PRIpaddr"->%#"PRIpaddr"\n",
                start, end);
         goto out;
     }
@@ -1003,6 +1020,35 @@ out:
     return res;
 }
 
+static int __init handle_pci_range(const struct dt_device_node *dev,
+                                   u64 addr, u64 len, void *data)
+{
+    struct rangeset *mem_holes = data;
+    paddr_t start, end;
+    int res;
+
+    start = addr & PAGE_MASK;
+    end = PAGE_ALIGN(addr + len);
+    res = rangeset_remove_range(mem_holes, start, end - 1);
+    if ( res )
+    {
+        printk(XENLOG_ERR "Failed to remove: %#"PRIpaddr"->%#"PRIpaddr"\n",
+               start, end);
+        return res;
+    }
+
+    return 0;
+}
+
+/*
+ * Find the holes in the Host DT which can be exposed to Dom0 as extended
+ * regions for the special memory mappings. In order to calculate regions
+ * we exclude every addressable memory region described by "reg" and "ranges"
+ * properties from the maximum possible addressable physical memory range:
+ * - MMIO
+ * - Host RAM
+ * - PCI bar
+ */
 static int __init find_memory_holes(const struct kernel_info *kinfo,
                                     struct meminfo *ext_regions)
 {
@@ -1024,7 +1070,7 @@ static int __init find_memory_holes(const struct kernel_info *kinfo,
     res = rangeset_add_range(mem_holes, start, end);
     if ( res )
     {
-        printk(XENLOG_ERR "Failed to add: %#"PRIx64"->%#"PRIx64"\n",
+        printk(XENLOG_ERR "Failed to add: %#"PRIpaddr"->%#"PRIpaddr"\n",
                start, end);
         goto out;
     }
@@ -1055,49 +1101,25 @@ static int __init find_memory_holes(const struct kernel_info *kinfo,
             res = rangeset_remove_range(mem_holes, start, end - 1);
             if ( res )
             {
-                printk(XENLOG_ERR "Failed to remove: %#"PRIx64"->%#"PRIx64"\n",
+                printk(XENLOG_ERR "Failed to remove: %#"PRIpaddr"->%#"PRIpaddr"\n",
                        start, end);
                 goto out;
             }
         }
 
-        if ( dt_device_type_is_equal(np, "pci" ) )
+        if ( dt_device_type_is_equal(np, "pci") )
         {
-            unsigned int range_size, nr_ranges;
-            int na, ns, pna;
-            const __be32 *ranges;
-            u32 len;
-
             /*
-             * Looking for non-empty ranges property which in this context
-             * describes the PCI host bridge aperture.
+             * The ranges property in this context describes the PCI host
+             * bridge aperture. It shall be absent if no addresses are mapped
+             * through the bridge.
              */
-            ranges = dt_get_property(np, "ranges", &len);
-            if ( !ranges || !len )
+            if ( !dt_get_property(np, "ranges", NULL) )
                 continue;
 
-            pna = dt_n_addr_cells(np);
-            na = dt_child_n_addr_cells(np);
-            ns = dt_child_n_size_cells(np);
-            range_size = pna + na + ns;
-            nr_ranges = len / sizeof(__be32) / range_size;
-
-            for ( i = 0; i < nr_ranges; i++, ranges += range_size )
-            {
-                /* Skip the child address and get the parent (CPU) address */
-                addr = dt_read_number(ranges + na, pna);
-                size = dt_read_number(ranges + na + pna, ns);
-
-                start = addr & PAGE_MASK;
-                end = PAGE_ALIGN(addr + size);
-                res = rangeset_remove_range(mem_holes, start, end - 1);
-                if ( res )
-                {
-                    printk(XENLOG_ERR "Failed to remove: %#"PRIx64"->%#"PRIx64"\n",
-                           start, end);
-                    goto out;
-                }
-            }
+            res = dt_for_each_range(np, &handle_pci_range, mem_holes);
+            if ( res )
+                goto out;
         }
     }
 
@@ -1152,12 +1174,12 @@ static int __init make_hypervisor_node(struct domain *d,
 
     if ( !opt_ext_regions )
     {
-        printk(XENLOG_DEBUG "The extended regions support is disabled\n");
+        printk(XENLOG_INFO "The extended regions support is disabled\n");
         nr_ext_regions = 0;
     }
     else if ( is_32bit_domain(d) )
     {
-        printk(XENLOG_DEBUG "The extended regions are only supported for 64-bit guest currently\n");
+        printk(XENLOG_WARNING "The extended regions are only supported for 64-bit guest currently\n");
         nr_ext_regions = 0;
     }
     else
@@ -1193,8 +1215,8 @@ static int __init make_hypervisor_node(struct domain *d,
         u64 start = ext_regions->bank[i].start;
         u64 size = ext_regions->bank[i].size;
 
-        dt_dprintk("Extended region %d: %#"PRIx64"->%#"PRIx64"\n",
-                   i, start, start + size);
+        printk("Extended region %d: %#"PRIx64"->%#"PRIx64"\n",
+               i, start, start + size);
 
         dt_child_set_range(&cells, addrcells, sizecells, start, size);
     }
-- 
2.7.4



From xen-devel-bounces@lists.xenproject.org Wed Oct 06 11:33:27 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Oct 2021 11:33:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.202851.357877 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mY5Am-00058j-IN; Wed, 06 Oct 2021 11:33:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 202851.357877; Wed, 06 Oct 2021 11:33:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mY5Am-00058c-DY; Wed, 06 Oct 2021 11:33:20 +0000
Received: by outflank-mailman (input) for mailman id 202851;
 Wed, 06 Oct 2021 11:33:19 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mY5Al-00058W-Gs
 for xen-devel@lists.xenproject.org; Wed, 06 Oct 2021 11:33:19 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mY5Al-0002AJ-FP
 for xen-devel@lists.xenproject.org; Wed, 06 Oct 2021 11:33:19 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mY5Al-0001eQ-EY
 for xen-devel@lists.xenproject.org; Wed, 06 Oct 2021 11:33:19 +0000
Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89)
 (envelope-from <iwj@xenproject.org>)
 id 1mY5Ag-0003Gx-MT; Wed, 06 Oct 2021 12:33:14 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date
	:Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From;
	bh=VpVaj3h60dMQC3FdBiyqTjlopXEX9ICvPgSoVwczmxM=; b=4MgZAkPRoFsmvCH2h/f1DBGySo
	pHuLkLO7NHyfUrNPuf/DAyyAXAUJ3R+9div5xNuzBT2q1D06l3SdfrwIH6H3wFzNCnnUtNA12/tvq
	/q4gGwAVZMQ8j904H6uEFl0ejZwwXvBexQKpYm/JzaWJQIT1iDVELlo/fQPY2NhlesiY=;
From: Ian Jackson <iwj@xenproject.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-16
Content-Transfer-Encoding: 8bit
Message-ID: <24925.35194.369692.94259@mariner.uk.xensource.com>
Date: Wed, 6 Oct 2021 12:33:14 +0100
To: Rahul Singh <Rahul.Singh@arm.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
    xen-devel <xen-devel@lists.xenproject.org>,
    Bertrand Marquis <Bertrand.Marquis@arm.com>,
    Andre Przywara <Andre.Przywara@arm.com>,
    Wei Liu <wl@xen.org>,
    Anthony PERARD <anthony.perard@citrix.com>,
    Juergen Gross <jgross@suse.com>,
    Julien Grall <julien@xen.org>,
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH v4 13/14] arm/libxl: Emulated PCI device tree node in
 libxl
In-Reply-To: <BFC5AD62-3DA7-498F-8B6E-AB4C8CAA9731@arm.com>
References: <cover.1633340795.git.rahul.singh@arm.com>
	<3ad42008f534671ae7f5b25da91253ce7cd4a3e9.1633340795.git.rahul.singh@arm.com>
	<alpine.DEB.2.21.2110041714410.3209@sstabellini-ThinkPad-T480s>
	<11F169C6-39A4-40F3-8E75-39B8C2CCF022@arm.com>
	<alpine.DEB.2.21.2110051421520.3209@sstabellini-ThinkPad-T480s>
	<8B848F95-977F-4DF4-B315-CFEA610BC1C3@arm.com>
	<24925.33634.554859.2131@mariner.uk.xensource.com>
	<BFC5AD62-3DA7-498F-8B6E-AB4C8CAA9731@arm.com>
X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu)

Rahul Singh writes ("Re: [PATCH v4 13/14] arm/libxl: Emulated PCI device tree node in libxl"):
> Hi Ian	
> > What is wrong with putting it in
> > libxl__arch_domain_build_info_setdefault
> > which I think exists precisely for this kind of thing ?
> 
> As we have to set the arch_arm.vpci to false for x86 and ARM I
> thought it is right to move the code to common code to avoid
> duplication.
> 
> Are you suggesting to put "
> libxl_defbool_setdefault(&b_info->arch_arm.vpci, false)�in
> libxl__arch_domain_build_info_setdefault() for x86 and ARM
> differently.

I've gone back and reread the whole thread, which I probably should
have done to start with....

So:

> >> #if defined(__arm__) || defined(__aarch64__)                  
> >>    /*                                    
> >>     * Enable VPCI support for ARM. VPCI support for DOMU guests is not    
> >>     * supported for x86.                          
> >>     */                                   
> >>    if (d_config->num_pcidevs)                        
> >>      libxl_defbool_set(&b_info->arch_arm.vpci, true);           
> >> #endif 

I think this logic probably ought to be in libxl, not in xl.  We try
to make the libxl API "do the right thing" by default.  In this case I
think that means to enable VPCI (i) on platforms where it's available
(ii) if the guest has PCI passthrough devices.  Is that right ?

Sorry to ask these question now, and please forgive my ignorance:

Is VPCI inherently an ARM-specific ABI or protocol ?  When might an
admin want to turn it on explicitly ?

How does this all relate to the (non-arch-specific) "passthrough"
option ?

Ian.


From xen-devel-bounces@lists.xenproject.org Wed Oct 06 11:34:44 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Oct 2021 11:34:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.202858.357888 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mY5C7-0005kC-RN; Wed, 06 Oct 2021 11:34:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 202858.357888; Wed, 06 Oct 2021 11:34:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mY5C7-0005k5-OQ; Wed, 06 Oct 2021 11:34:43 +0000
Received: by outflank-mailman (input) for mailman id 202858;
 Wed, 06 Oct 2021 11:34:42 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mY5C6-0005jx-8d
 for xen-devel@lists.xenproject.org; Wed, 06 Oct 2021 11:34:42 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mY5C6-0002Bz-7r
 for xen-devel@lists.xenproject.org; Wed, 06 Oct 2021 11:34:42 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mY5C6-0001sY-71
 for xen-devel@lists.xenproject.org; Wed, 06 Oct 2021 11:34:42 +0000
Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89)
 (envelope-from <iwj@xenproject.org>)
 id 1mY5C3-0003Hx-0W; Wed, 06 Oct 2021 12:34:39 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date
	:Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From;
	bh=SJfFYgQP6f6wlaBR5TA3Vhdn5P5/jliUd9S5Vklng7w=; b=KduO/Jyiv06KNSSHd1qEsf/VSa
	zPxczgUuEPQ0lWaWXcMYsAeOaEpoMtTdNlUtPzMF8BX/yJtXBsuY2VixxOefGiIdErdGGJ10vWhi1
	hak935qJWpetl8+6JTDZfcWTM2i2/yVP6Tptyd4Zb+yjDsBBNsoRlzygQCccQsGQ3Zyo=;
From: Ian Jackson <iwj@xenproject.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <24925.35278.762786.539238@mariner.uk.xensource.com>
Date: Wed, 6 Oct 2021 12:34:38 +0100
To: Oleksandr Tyshchenko <olekstysh@gmail.com>
Cc: xen-devel@lists.xenproject.org,
    Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
    Wei Liu <wl@xen.org>,
    Anthony PERARD <anthony.perard@citrix.com>,
    Juergen Gross <jgross@suse.com>,
    Stefano Stabellini <sstabellini@kernel.org>,
    Julien Grall <julien@xen.org>,
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH V5 2/3] libxl/arm: Add handling of extended regions for DomU
In-Reply-To: <1633519346-3686-3-git-send-email-olekstysh@gmail.com>
References: <1633519346-3686-1-git-send-email-olekstysh@gmail.com>
	<1633519346-3686-3-git-send-email-olekstysh@gmail.com>
X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu)

Oleksandr Tyshchenko writes ("[PATCH V5 2/3] libxl/arm: Add handling of extended regions for DomU"):
> The extended region (safe range) is a region of guest physical
> address space which is unused and could be safely used to create
> grant/foreign mappings instead of wasting real RAM pages from
> the domain memory for establishing these mappings.

Please forgive me for asking this question now, but: why is this
ARM-specific ?

Ian.


From xen-devel-bounces@lists.xenproject.org Wed Oct 06 12:28:29 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Oct 2021 12:28:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.202887.357898 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mY61w-0002rZ-Bn; Wed, 06 Oct 2021 12:28:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 202887.357898; Wed, 06 Oct 2021 12:28:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mY61w-0002rS-8u; Wed, 06 Oct 2021 12:28:16 +0000
Received: by outflank-mailman (input) for mailman id 202887;
 Wed, 06 Oct 2021 12:28:15 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=RZr5=O2=gmail.com=olekstysh@srs-us1.protection.inumbo.net>)
 id 1mY61v-0002rM-IZ
 for xen-devel@lists.xenproject.org; Wed, 06 Oct 2021 12:28:15 +0000
Received: from mail-lf1-x136.google.com (unknown [2a00:1450:4864:20::136])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id a97713ad-9cd5-4091-8be2-12cd754e4748;
 Wed, 06 Oct 2021 12:28:14 +0000 (UTC)
Received: by mail-lf1-x136.google.com with SMTP id z11so1581364lfj.4
 for <xen-devel@lists.xenproject.org>; Wed, 06 Oct 2021 05:28:14 -0700 (PDT)
Received: from [192.168.1.7] ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id n19sm155140ljc.17.2021.10.06.05.28.12
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Wed, 06 Oct 2021 05:28:13 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a97713ad-9cd5-4091-8be2-12cd754e4748
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-transfer-encoding:content-language;
        bh=aFZKv6XjaT2IKFT3rDwvRVqqHJLtengvMplwha1lUF4=;
        b=pOkdNqaN4XaGZg1z8YJtFSoslyBTfKLL3jTM/pURSyBPue3X4Nh4fBAdMe1CfS332M
         x+JWKc2X3IG8T1gwfGO3YfUhy4loYvesqfT4KAFw38pAR9nd6ZB9dNrIU9d8hgAKYa+2
         oxCxGFx4P0xG9EVyaS/pNXWIPdjXzCm4UcxEJH354ZSL4JaaLVRRWLgTmZ/tR5FRpgyH
         0AX/BYn+0HBwtw9Wb5PFgFPZCm+gm/oue63T/IqJ21bzKFzcfYRrwE8rLcdDHButj9F3
         YCWJrypdCkZCI58/iBugcbzExwTXnjb7OiXa2xz1yLxK4ZU0L1gm2dSrazlpRqmZeW5m
         x4eA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding
         :content-language;
        bh=aFZKv6XjaT2IKFT3rDwvRVqqHJLtengvMplwha1lUF4=;
        b=nEEalHHtosNiSdF5pc6T3KEdxWQauxNwG2SPXpaVGfb18DqS8Krz/qey+rhvhVPYME
         ApxLCxxp1+t1qXjkuj2XxDkm/ura3GJRg9t0m3RTBi6Gj+jGJn5M2SuCtYZupSARHf4N
         Ddpf9xKwfD31RwwfWnzAgVi7294IIstJcSoAy6S+oIopE6oADweWtioTRGvPsoaIsYTF
         eGg5KmqZEbZ0TlZAyGwmWoY+6E9JaBWguH+9L5InOglaPMUAPLYgxyPwxFCemF7qkItX
         Uw5NYAsKZpyP28MH4C+lwbpurff7rs5cfBhFAgAFuZR4YRXk43HMJuF6/1HGjk9J1eUY
         EuGA==
X-Gm-Message-State: AOAM532OyQscZZAgPuZqScC/LXoTgZKiG5dqKcE+cC8WjI58Xv7vCxyU
	9HTrZk8mZ0pZnKtrVNczVdU=
X-Google-Smtp-Source: ABdhPJxoy7mlhNGvbG0ddyBsyayoEzvt8NL0ylBO+8G1aEpOINDfmGwtuHFbGRhUSUTP3d6FQUJ33w==
X-Received: by 2002:a2e:a803:: with SMTP id l3mr2684304ljq.74.1633523293670;
        Wed, 06 Oct 2021 05:28:13 -0700 (PDT)
Subject: Re: [PATCH V5 2/3] libxl/arm: Add handling of extended regions for
 DomU
To: Ian Jackson <iwj@xenproject.org>
Cc: xen-devel@lists.xenproject.org,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, Wei Liu <wl@xen.org>,
 Anthony PERARD <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <1633519346-3686-1-git-send-email-olekstysh@gmail.com>
 <1633519346-3686-3-git-send-email-olekstysh@gmail.com>
 <24925.35278.762786.539238@mariner.uk.xensource.com>
From: Oleksandr <olekstysh@gmail.com>
Message-ID: <224ed316-aac0-3ad4-22a1-efc592e717e2@gmail.com>
Date: Wed, 6 Oct 2021 15:28:12 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <24925.35278.762786.539238@mariner.uk.xensource.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US


On 06.10.21 14:34, Ian Jackson wrote:

Hi Ian

> Oleksandr Tyshchenko writes ("[PATCH V5 2/3] libxl/arm: Add handling of extended regions for DomU"):
>> The extended region (safe range) is a region of guest physical
>> address space which is unused and could be safely used to create
>> grant/foreign mappings instead of wasting real RAM pages from
>> the domain memory for establishing these mappings.
> Please forgive me for asking this question now, but: why is this
> ARM-specific ?


Sorry, I can't say for sure which x86 mode also suffers from that. I 
might be wrong, but as I understand that x86 in PVH (and HVM?) mode uses 
unpopulated memory ranges (which are unused from Linux PoV, actually 
everything not yet allocated or reserved from "iomem_resource") to 
create foreign/grant mappings. So the real RAM pages are not ballooned 
out to get an physical address space to create these mappings. The 
problem is that we cannot follow Linux advise which memory ranges are 
unused on Arm for several reasons, this is why this patch series makes 
the hypervisor to start allocating and exposing these ranges.

>
> Ian.

-- 
Regards,

Oleksandr Tyshchenko



From xen-devel-bounces@lists.xenproject.org Wed Oct 06 12:31:41 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Oct 2021 12:31:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.202895.357910 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mY65E-0004Dt-Sm; Wed, 06 Oct 2021 12:31:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 202895.357910; Wed, 06 Oct 2021 12:31:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mY65E-0004Dm-P7; Wed, 06 Oct 2021 12:31:40 +0000
Received: by outflank-mailman (input) for mailman id 202895;
 Wed, 06 Oct 2021 12:31:40 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=/TVP=O2=citrix.com=christian.lindig@srs-us1.protection.inumbo.net>)
 id 1mY65D-0004Dd-S6
 for xen-devel@lists.xenproject.org; Wed, 06 Oct 2021 12:31:40 +0000
Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id fd0c1732-ea0e-4454-964c-2be1938fe8a1;
 Wed, 06 Oct 2021 12:31:38 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fd0c1732-ea0e-4454-964c-2be1938fe8a1
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1633523498;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:mime-version;
  bh=3Yyc9Y2M8j7XZsCbjZ0DbpEy+MI0pxfhefDMcYSru/c=;
  b=OLvWX10EdbupWAe6UdVCqaXiFxiQuL1MsF3SQg4OXWiQXMp1b4ormKbH
   RvWlc436eVxOSEo/2aCtX0xzMiNMG78MmA6/yXSSKwdLEgeWebTbt3P7M
   6fO01l/f04gUSCOiO4eV1uMFKL7TjGsLisKsFbQaI/mwHIbpo8QO0pxs8
   c=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: ItPhTKARXuXSz7QnPAxegE2DZSTlHxWDzF0gF/J55uK9s9f9a7Otwp3a/kFLxun3twIb5y8iF8
 AFVF00Rc99Nl1ZjhQadh3xPFfFS9LbAHCXkVyueGpqYX7TnaRSVLyqGKUnVxZTJGK6yDrqqFGp
 d7Qgqyzsu+mVoJAQtJWXj/kEutX4T71QvE7My2F1JQVh86f2SINGp1l6WZf8DpGmeTWDNZbAAB
 3nPWuH29uTgcxbzwkBLpJdk8DPaT/LeY6YmTMFDLV1y4a/Yl9EireAowzOLy+JYV8jBU6x/FYZ
 muE9OShu4g4lMmXjohhs7m/T
X-SBRS: 5.1
X-MesageID: 54073838
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:RPXbTahBh0iqrQi0UxV/YZIrX161QxYKZh0ujC45NGQN5FlHY01je
 htvCG/SMqmCYDT0edsjaYqw/B4E7Z+DnYAxGwtvrCA9H34b9cadCdqndUqhZCn6wu8v7a5EA
 2fyTvGacajYm1eF/k/F3oAMKRCQ7InQLlbGILes1htZGEk0FU/NtTo5w7Rg29Yw34Dga++wk
 YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq
 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx
 /1Hm8S7EgMSD5b2wu0vbSUITwQnGYxZreqvzXiX6aR/zmXDenrohf5vEFs3LcsT/eMf7WNmr
 KJCbmpXN1ba2rzwkOnTpupE36zPKOHgPJkeoW1hxDefCfcgTZHMa67L+cVZzHE7gcUm8fP2O
 pZBNmE/N0SojxtnBVslWJ4iwdWToGD/TjZAmE7FjrIs7D2GpOB2+Oe0a4eEEjCQfu1XkVyfv
 Xnu5HniD1cRM9n34SCC6Xi2gejMmwvyWYQcE6a1/bhhh1j77ncIFBQcWF+/oP+4ok2zQdRSL
 woT4CVGhaI/7lCxR9/xGRixumeZvwU0UsBVVeY97Wml9K3Q5AqIA3keeRRIYtcmqcweSCQj0
 xmCmNaBLTBmrrC9U3+W8baQ6zSoNkA9LHAATT8JSxMf5Nvuq511iQjAJv5zHajwgtDrFDXYx
 zGRsDN4l7gVldQM1aiw4RbAmT3Ejp3IRQ484kPQRHCo6itwfovjbIutgXDZ8PJBIYCxXlSH+
 n8elKC27uoDEJWMnyylW/gWEfei4PPtGCLYqU5iGd8m7TvFxpK4VdkOunckfh4va5taP2+yC
 KPOhe9PzJV9ZHDxaZRGWLjrAvYU8fi8MI3Bd++BO7KifaNNXAOA+ShvY2uZ0GbsjFUgnMkDB
 HuLTSq/JSxEUPs2lVJaU89YgedymXxurY/GbcqjpylLx4Zyc5J8pV0tHlyUcqgd5b6IrR/Z+
 tJSXydh404EC7WvCsU7HJR6ELzrEZTZLcyowyC0XrTaSuaDJI3HI6SKqV/GU9Y195m5bs+So
 hmAtrZwkTITf0HvJwSQcWxEY7jyR5t5pn9TFXVyZg30hil+Od7zsP13m34LkV8Pr7cLIRlcF
 altRil9Kq4XFmSvF8o1N/ERU7COhDz03FnTbkJJkRA0foJ6RhyhxzMXVlCHycX6NQLu7ZFWi
 +T5jmvzGMNfLyw/XJe+QK/+lDuZ4ClC8N+eqmOVe7G/jm23q9M0Q8Ew59dqS/wxxeLrnGDHi
 FrGXUlC9YEgYeYdqbH0uExNlK/we8NWFUtGBWjLq7GwMCjR5G24xoFcFu2PeFjguKncpM1Ov
 M1ZkKPxNuMphlFPv9YuGrpn1/tmtdDuu6Vb3kJvG3CSNwanDbZpI3+n28hTt/ISmu8F6FXuA
 k/fqMNHPbipOd/+FAJDLgQSceneh+ofnSPf7KppLRyitjN35reOTW5bIwKI1H5GNLJwPY58m
 bUhtcca5haRkB0vNtra3ClY+37Vdi4LUrk9t4FcC4ju01J5xlZHaJ3aKyn3/JDQNIkcbhh0e
 meZ3fOQia5dy0zOd2sIOULMhecN144TvB1qzUMZIwjbkNTymfJqjgZa9i46T1oJw0wfgf5zI
 GViK2Z8Ob6Ko2VznMFGUm2hR1NBCRme9hCjwlcFjjSEHUyhV2iLJ2whI+edukse9jsELDRc+
 biZzkfjUCrrI56tjndjBxY9pqyxV8F1+y3DhNujTpaMEJQNaDb4hrOjODgToBz9DMJt3EDKq
 IGGJgqrhXEX4cLIn5AGNg==
IronPort-HdrOrdr: A9a23:aYi0hKHyBVHAT1UVpLqFRZHXdLJyesId70hD6qkvc3Nom52j+/
 xGws536fatskdtZJkh8erwXZVoMkmsiaKdgLNhc4tKOTOJhILGFvAa0WKP+UyCJ8S6zJ8m6U
 4CSdk+NDSTNykDsS+S2mDReLxAoOVvsprY/ts2p00dFj2CAJsQizuRfzzrdHGeMzM2YqbReq
 DshPZvln6FQzA6f867Dn4KU6zovNvQjq/rZhYAGloO9BSOpSnA0s+7LzGomjMlFx9fy7Yr9m
 bI1ybj4L+4jv29whjAk0fO8pVtnsf7wNcrPr3OtiFVEESvtu+bXvUkZ1SwhkFznAhp0idtrD
 D4mWZkAy200QKJQoj6m2q05+Cq6kdQ15ar8y7nvZKkm72ieNtyMbswuatJNhTe8EYup9d6ze
 ZC2H+YrYNeCVfakD36/MWgbWAmqqIlyUBS4NL7okYvGrf2UoUh57D3PXklZ6soDWb/8sQqAe
 NuBMbT6LJfdk6bdWnQui1qzMa3Vno+Ex+aSgxa0/blnAR+jTR81Q8V1cYflnAP+NY0TIRF/f
 3NNuBtmKtVRsEbYKphDKMKQNexCGbKXRXQWVjibWjPBeUCITbAupT36LI66KWjf4EJ1oI7nN
 DbXFZRpQcJCgrT4A21rdR2GzX2MRGAtBjWu7NjDqlCy8vBreDQQF6+oXgV4r6dn8k=
X-IronPort-AV: E=Sophos;i="5.85,350,1624334400"; 
   d="scan'208,217";a="54073838"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=HRLUUg49DszpXSwARl5COtBZMouuMYGKMMTNSeUTPwtWP6s8wNQvgeAzCGxjp1ArvzCCoUmiGY3kmViv/wNDkFOEQwncqO1BW8KRH2E37fc2z+GBYlb79vsISJcleVcI2W5TSsdzSig786cbKiNWtPEuea/DNYNoW7RYmMGA2J7zaCjRZvlld8VtSuQWxdvfD92hAj5GgfaZE3ApjkklP0PwqGkl4fJCJ6bhuyYoluvN1oRr/aRJBuJrQDsSNdis8FiiqUJm1Nu3FjZ8Jkq3w/Um8cfj6gCzISwQukLmUsaHfuX9xFq1L3O3PZmsa5tCMyWNFtpes4wiDEuqYOxfTg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=QqwnsqGreIGepn7vGHFKmOXIUoFNtrXVQo/7qYAg5d0=;
 b=SwKMm636IJRFPWCnNTtawO1Yg8bXHsEwTdWoLEmuTaeGpVxdAckqwagJkTUPdRqFY0rUopqR1q278FKM6MoOyJs+/uP61a9rxBS3SAMgym7DRjZwhh8ZXEYXjnl4zYXvj7wBXUfdzkZ7EX/CNwnpKCeFKDBhu06x3DEMvaIyUn/hox+qBsz9hLd0dZNWky7wJTxhU0OpCCW1A5u9AwW2/3f1H7pDRPXCt4//hfIoVnI2WczV9MEOp+DVZTg3xosQH6ny086eCU8Q8nWgL/5tuUCepfdeJAkUuxYngv8Y6e+Gsmm9P8TwgqFsIyE+bkS/rkQC36HEL9/AaHvNblYSFg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=QqwnsqGreIGepn7vGHFKmOXIUoFNtrXVQo/7qYAg5d0=;
 b=XAbLdeiXGOK+fajdBkAKPDG+deFUzxYi9mlQZMlVuq6N/PcB5hnU58+iQe9scRow907H0ESrFERJV0BkFX9XEVp5jGkB+nrkc13LLlylWMfORNbl4cMQaLyq3+0EuUTOtvHFPS9FsG06JwbNvrjULbGRqTJYMAnJHFpt9Ye/fZY=
From: Christian Lindig <christian.lindig@citrix.com>
To: Michal Orzel <michal.orzel@arm.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, "Ian
 Jackson" <iwj@xenproject.org>, Wei Liu <wl@xen.org>, Andrew Cooper
	<Andrew.Cooper3@citrix.com>, George Dunlap <George.Dunlap@citrix.com>, "Jan
 Beulich" <jbeulich@suse.com>, Julien Grall <julien@xen.org>, "Stefano
 Stabellini" <sstabellini@kernel.org>, Nick Rosbrook <rosbrookn@ainfosec.com>,
	Anthony Perard <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>,
	David Scott <dave@recoil.org>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Roger Pau Monne <roger.pau@citrix.com>,
	"bertrand.marquis@arm.com" <bertrand.marquis@arm.com>
Subject: Re: [PATCH v2 3/3] xen: Expose the PMU to the guests
Thread-Topic: [PATCH v2 3/3] xen: Expose the PMU to the guests
Thread-Index: AQHXuqF33PA+mkkVkkOV14cr2obRMKvF5taA
Date: Wed, 6 Oct 2021 12:31:14 +0000
Message-ID: <4EEC0FD3-16ED-4B7F-86A6-0D62656300D0@citrix.com>
References: <20211006105827.15217-1-michal.orzel@arm.com>
 <20211006105827.15217-4-michal.orzel@arm.com>
In-Reply-To: <20211006105827.15217-4-michal.orzel@arm.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3608.120.23.2.4)
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 0639047c-68a9-4805-e733-08d988c52ffe
x-ms-traffictypediagnostic: MWHPR03MB2669:
x-ms-exchange-transport-forked: True
x-microsoft-antispam-prvs: <MWHPR03MB2669C6808C9D2142FAB765CDF6B09@MWHPR03MB2669.namprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:7691;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: c3uoY/V32kmOLjvKt2UGexUXWGcYwXxZpC+g8OjBtqPXsIEzJoxJx4TV56pjFpE3u0Xto6uhjqYFla+YfFCqXnlCTZBKZ03tMMbXqpznQ/dsXH+06lTr0JuMNPN0YqN/JzguMwR8CWfZOy8JaAxzAK5275LVkUZVr/CAXZoHhvwuE4h5HxVETcRwWiS5cvBUVizLTNd5PBurRbLTF6P+ulGxb78AUrdtMmCgvCogd7asMqp1WmncR5iGJJHmfPw0CW9DtXP2SKAyvY41FD2HchGXRJBLH/5/QgqZdAPhsjQ/BBwkV3jjNGmb1vLyiPYp2ESNAoBMQCglYhXFEkGTB9tWhemIapj2gqgrHy/hZVaRnJg7zCM7SCFvcP4nVNpZ2E6JS1X25paBF0/7NJ08XkE23XFUsWZAiccbQ/lJUSmFgo1eyDMXWrUa6WpqJJ6Lv0r7pEZP4upb6elF5pZY1nArmOcc+/dbdADyD2L32T1eQwHlbqw+TQTwcN5pPj+zh56z4CBKQyHqvXb0uf5Ut5nFLiv7gwRIfywCaBJv25c27DrsyqYFBypn6vwZdWlv7X/ziNoSHDp2rUD9ihqrSMAt6XJ3WXGOcvtJz5+OIRa3hGWGYrwX2S40CNE3UpLEYIB5Rlt5mWB9CFntYcR/iZZaz8ra29PK0mdtcP83Vg9ZL59GX6PD8Zzj9WmX5ppdYwzMEalAlXdFRJtD6FMW+lXM+8NWRnK/0+bEOpOsAiA=
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR03MB6380.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(44832011)(83380400001)(5660300002)(6506007)(86362001)(6486002)(33656002)(6512007)(38070700005)(122000001)(2616005)(38100700002)(7416002)(64756008)(66556008)(66476007)(53546011)(55236004)(316002)(76116006)(66946007)(36756003)(66446008)(508600001)(8676002)(186003)(6916009)(54906003)(2906002)(71200400001)(26005)(4326008)(8936002)(91956017)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?fdHVfzK+rYSAujI1wp89aWILm4rc7Up8K4QWQZAGQZR0J+9g05m7GlH0nSLl?=
 =?us-ascii?Q?WpQoxr/4apaNhcY/On5vMLbsCkAjuqiAExzXom5p4pCkpqNxtIZsVkD9U31U?=
 =?us-ascii?Q?sgIeDJYPpr433QID8lMkEcg1aY86CMbcDW/K1le0yrXFD0EKkrFewUAFocnP?=
 =?us-ascii?Q?HeC0MOA7ySnzF7D08VHv1iWNZSsbB7CWMnUufUwUKKDX7Gx3Bcf5hn//mQbP?=
 =?us-ascii?Q?lNcnIbWYiw5SDqniFGxA2I9ufi4m9iKxXeEPLtEMA04io0TAHVPpBpEcOC9f?=
 =?us-ascii?Q?Nnj2jerm+HvFDDQKw9CW0ApF98re+TsJFz2ephdpbsNT/i4zMNgxAjy+0i3h?=
 =?us-ascii?Q?ZHpxR6DmYjXZFYZRqItL8b7dIqJmO1fZ5OCCx/LDAHxPCfJaDrQ5wASid7AU?=
 =?us-ascii?Q?2Ky+nzWPrCvT6hLxWAsK0+GImsY83ecwj59Azd6Loy+VvxvkDPEg30v99JEA?=
 =?us-ascii?Q?0NVb+JDdDJNsMU6YCC1lIlEPGXJ558oH230Pqj3iMy2sEq66AjDb/8koT62/?=
 =?us-ascii?Q?lkfMtvssQ1Ew78GdScAwkeWC0fTf9Ee6hzA6ysVoji+c1SJ051qux3kvgdcy?=
 =?us-ascii?Q?1wRrehcwf/bVN47+w7YBCJpFawI6he/ley5FKKL0+vTW/eoSqHZZ52UGJPl9?=
 =?us-ascii?Q?JKmgYO/0i1eK7tV6RwweLmA5/3Tpbe7xDs2U7pOZS4rOV0MZcxKzqKKRRb07?=
 =?us-ascii?Q?X0NUigjXpZ/XmcZM0nOMGH5yIHtGEeW4QJL/CZhKsCJTR1NrfNXdysaHFOxI?=
 =?us-ascii?Q?Hqe5FL2t3uJNMOqazU4C4slUHyjEc2jx28xShDLFI4MvYstETjUwhCSCv6+a?=
 =?us-ascii?Q?rRdigfiU/dDpUq+xpDB9l909maE1+1f+6fQmwN0vH4HFzsRTn4XnC0qMAhfb?=
 =?us-ascii?Q?+4AFSKtZoSkz9AR0HrJ3izhjxXa92vc4Xz6mH+V3NrKDL+T0YGIPKvAzdXLJ?=
 =?us-ascii?Q?RAnO+OlvNL6RELZcfHgHGw2su4anDcKCmgz0K97Bqr6zKJJneOOzgI6wxcic?=
 =?us-ascii?Q?gXv4PZ6RW83iKxUovNZdsgmvJ7X86UvBt6trbjOAW/jlb2mfm/MAA/bgcDTp?=
 =?us-ascii?Q?UuqKdWZo3LwBKdls7GquoZgn0cGv7pXdnMeNLNP7XIEc5y3glDXoHTBgTTUc?=
 =?us-ascii?Q?5qrywdE5NJGwDRKMi2HH0WQS63hS5EHNJgpRh8YH+WbBtzQol28W2Kpw4bu5?=
 =?us-ascii?Q?DPCDoejxjORm8nn+YP1g2Ex0hCBgkwrPRv1iEyteI0xZXEZqAYgepbK2SVxY?=
 =?us-ascii?Q?NzfnChEfxX8kKYyOB2E/tJUtNRU8HpxUlHe9roeNqKGKEC0kazVNxN0SF85I?=
 =?us-ascii?Q?LebTmIQuGPjBkFoQ8Mtnj3vx?=
Content-Type: multipart/alternative;
	boundary="_000_4EEC0FD316ED4B7F86A60D62656300D0citrixcom_"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MW4PR03MB6380.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0639047c-68a9-4805-e733-08d988c52ffe
X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Oct 2021 12:31:14.1927
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ZvIRJfqDLMDF37f+JKB6QiPsrgONFjugoAVj6RM5vfoaEOLGsdfsv5DPl39MH1yxNJeCxnt0MMRGbH9JEZooHkWmi6VsJP83+aru0pDQ2M8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR03MB2669
X-OriginatorOrg: citrix.com

--_000_4EEC0FD316ED4B7F86A60D62656300D0citrixcom_
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable



On 6 Oct 2021, at 11:58, Michal Orzel <michal.orzel@arm.com<mailto:michal.o=
rzel@arm.com>> wrote:

Add parameter vpmu to xl domain configuration syntax
to enable the access to PMU registers by disabling
the PMU traps(currently only for ARM).

The current status is that the PMU registers are not
virtualized and the physical registers are directly
accessible when this parameter is enabled. There is no
interrupt support and Xen will not save/restore the
register values on context switches.

Please note that this feature is experimental.

Signed-off-by: Michal Orzel <michal.orzel@arm.com<mailto:michal.orzel@arm.c=
om>>
Signed-off-by: Julien Grall <julien@xen.org<mailto:julien@xen.org>>
---
docs/man/xl.cfg.5.pod.in             | 17 +++++++++++++++++
tools/golang/xenlight/helpers.gen.go |  6 ++++++
tools/golang/xenlight/types.gen.go   |  1 +
tools/include/libxl.h                |  6 ++++++
tools/libs/light/libxl_create.c      |  4 ++++
tools/libs/light/libxl_types.idl     |  2 ++
tools/ocaml/libs/xc/xenctrl.ml       |  1 +
tools/ocaml/libs/xc/xenctrl.mli      |  1 +
tools/xl/xl_parse.c                  |  2 ++
xen/arch/arm/domain.c                | 10 ++++++++--
xen/arch/arm/setup.c                 |  1 +
xen/arch/x86/domain.c                |  6 ++++++
xen/common/domain.c                  |  9 ++++++++-
xen/include/asm-arm/domain.h         |  1 +
xen/include/public/domctl.h          |  5 ++++-
15 files changed, 68 insertions(+), 4 deletions(-)

Acked-by: Christian Lindig <christian.lindig@citrix.com<mailto:christian.li=
ndig@citrix.com>>

--_000_4EEC0FD316ED4B7F86A60D62656300D0citrixcom_
Content-Type: text/html; charset="us-ascii"
Content-ID: <4057EA126ECD9C43BCFAB3D7B3D072C2@namprd03.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable

<html>
<head>
<meta http-equiv=3D"Content-Type" content=3D"text/html; charset=3Dus-ascii"=
>
</head>
<body style=3D"word-wrap: break-word; -webkit-nbsp-mode: space; line-break:=
 after-white-space;" class=3D"">
<br class=3D"">
<div><br class=3D"">
<blockquote type=3D"cite" class=3D"">
<div class=3D"">On 6 Oct 2021, at 11:58, Michal Orzel &lt;<a href=3D"mailto=
:michal.orzel@arm.com" class=3D"">michal.orzel@arm.com</a>&gt; wrote:</div>
<br class=3D"Apple-interchange-newline">
<div class=3D""><span style=3D"caret-color: rgb(0, 0, 0); font-family: Helv=
etica; font-size: 12px; font-style: normal; font-variant-caps: normal; font=
-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0p=
x; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-te=
xt-stroke-width: 0px; text-decoration: none; float: none; display: inline !=
important;" class=3D"">Add
 parameter vpmu to xl domain configuration syntax</span><br style=3D"caret-=
color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: n=
ormal; font-variant-caps: normal; font-weight: normal; letter-spacing: norm=
al; text-align: start; text-indent: 0px; text-transform: none; white-space:=
 normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration=
: none;" class=3D"">
<span style=3D"caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size=
: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal;=
 letter-spacing: normal; text-align: start; text-indent: 0px; text-transfor=
m: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width:=
 0px; text-decoration: none; float: none; display: inline !important;" clas=
s=3D"">to
 enable the access to PMU registers by disabling</span><br style=3D"caret-c=
olor: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: no=
rmal; font-variant-caps: normal; font-weight: normal; letter-spacing: norma=
l; text-align: start; text-indent: 0px; text-transform: none; white-space: =
normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration:=
 none;" class=3D"">
<span style=3D"caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size=
: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal;=
 letter-spacing: normal; text-align: start; text-indent: 0px; text-transfor=
m: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width:=
 0px; text-decoration: none; float: none; display: inline !important;" clas=
s=3D"">the
 PMU traps(currently only for ARM).</span><br style=3D"caret-color: rgb(0, =
0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-va=
riant-caps: normal; font-weight: normal; letter-spacing: normal; text-align=
: start; text-indent: 0px; text-transform: none; white-space: normal; word-=
spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=
=3D"">
<br style=3D"caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: =
12px; font-style: normal; font-variant-caps: normal; font-weight: normal; l=
etter-spacing: normal; text-align: start; text-indent: 0px; text-transform:=
 none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0=
px; text-decoration: none;" class=3D"">
<span style=3D"caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size=
: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal;=
 letter-spacing: normal; text-align: start; text-indent: 0px; text-transfor=
m: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width:=
 0px; text-decoration: none; float: none; display: inline !important;" clas=
s=3D"">The
 current status is that the PMU registers are not</span><br style=3D"caret-=
color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: n=
ormal; font-variant-caps: normal; font-weight: normal; letter-spacing: norm=
al; text-align: start; text-indent: 0px; text-transform: none; white-space:=
 normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration=
: none;" class=3D"">
<span style=3D"caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size=
: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal;=
 letter-spacing: normal; text-align: start; text-indent: 0px; text-transfor=
m: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width:=
 0px; text-decoration: none; float: none; display: inline !important;" clas=
s=3D"">virtualized
 and the physical registers are directly</span><br style=3D"caret-color: rg=
b(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; fo=
nt-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-=
align: start; text-indent: 0px; text-transform: none; white-space: normal; =
word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" =
class=3D"">
<span style=3D"caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size=
: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal;=
 letter-spacing: normal; text-align: start; text-indent: 0px; text-transfor=
m: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width:=
 0px; text-decoration: none; float: none; display: inline !important;" clas=
s=3D"">accessible
 when this parameter is enabled. There is no</span><br style=3D"caret-color=
: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal=
; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; t=
ext-align: start; text-indent: 0px; text-transform: none; white-space: norm=
al; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: non=
e;" class=3D"">
<span style=3D"caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size=
: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal;=
 letter-spacing: normal; text-align: start; text-indent: 0px; text-transfor=
m: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width:=
 0px; text-decoration: none; float: none; display: inline !important;" clas=
s=3D"">interrupt
 support and Xen will not save/restore the</span><br style=3D"caret-color: =
rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; =
font-variant-caps: normal; font-weight: normal; letter-spacing: normal; tex=
t-align: start; text-indent: 0px; text-transform: none; white-space: normal=
; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;=
" class=3D"">
<span style=3D"caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size=
: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal;=
 letter-spacing: normal; text-align: start; text-indent: 0px; text-transfor=
m: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width:=
 0px; text-decoration: none; float: none; display: inline !important;" clas=
s=3D"">register
 values on context switches.</span><br style=3D"caret-color: rgb(0, 0, 0); =
font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-c=
aps: normal; font-weight: normal; letter-spacing: normal; text-align: start=
; text-indent: 0px; text-transform: none; white-space: normal; word-spacing=
: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=3D"">
<br style=3D"caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: =
12px; font-style: normal; font-variant-caps: normal; font-weight: normal; l=
etter-spacing: normal; text-align: start; text-indent: 0px; text-transform:=
 none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0=
px; text-decoration: none;" class=3D"">
<span style=3D"caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size=
: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal;=
 letter-spacing: normal; text-align: start; text-indent: 0px; text-transfor=
m: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width:=
 0px; text-decoration: none; float: none; display: inline !important;" clas=
s=3D"">Please
 note that this feature is experimental.</span><br style=3D"caret-color: rg=
b(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; fo=
nt-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-=
align: start; text-indent: 0px; text-transform: none; white-space: normal; =
word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" =
class=3D"">
<br style=3D"caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: =
12px; font-style: normal; font-variant-caps: normal; font-weight: normal; l=
etter-spacing: normal; text-align: start; text-indent: 0px; text-transform:=
 none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0=
px; text-decoration: none;" class=3D"">
<span style=3D"caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size=
: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal;=
 letter-spacing: normal; text-align: start; text-indent: 0px; text-transfor=
m: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width:=
 0px; text-decoration: none; float: none; display: inline !important;" clas=
s=3D"">Signed-off-by:
 Michal Orzel &lt;</span><a href=3D"mailto:michal.orzel@arm.com" style=3D"f=
ont-family: Helvetica; font-size: 12px; font-style: normal; font-variant-ca=
ps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; tex=
t-align: start; text-indent: 0px; text-transform: none; white-space: normal=
; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-=
text-stroke-width: 0px;" class=3D"">michal.orzel@arm.com</a><span style=3D"=
caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-st=
yle: normal; font-variant-caps: normal; font-weight: normal; letter-spacing=
: normal; text-align: start; text-indent: 0px; text-transform: none; white-=
space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-deco=
ration: none; float: none; display: inline !important;" class=3D"">&gt;</sp=
an><br style=3D"caret-color: rgb(0, 0, 0); font-family: Helvetica; font-siz=
e: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal=
; letter-spacing: normal; text-align: start; text-indent: 0px; text-transfo=
rm: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width=
: 0px; text-decoration: none;" class=3D"">
<span style=3D"caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size=
: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal;=
 letter-spacing: normal; text-align: start; text-indent: 0px; text-transfor=
m: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width:=
 0px; text-decoration: none; float: none; display: inline !important;" clas=
s=3D"">Signed-off-by:
 Julien Grall &lt;</span><a href=3D"mailto:julien@xen.org" style=3D"font-fa=
mily: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: no=
rmal; font-weight: normal; letter-spacing: normal; orphans: auto; text-alig=
n: start; text-indent: 0px; text-transform: none; white-space: normal; wido=
ws: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-s=
troke-width: 0px;" class=3D"">julien@xen.org</a><span style=3D"caret-color:=
 rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal;=
 font-variant-caps: normal; font-weight: normal; letter-spacing: normal; te=
xt-align: start; text-indent: 0px; text-transform: none; white-space: norma=
l; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none=
; float: none; display: inline !important;" class=3D"">&gt;</span><br style=
=3D"caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; fon=
t-style: normal; font-variant-caps: normal; font-weight: normal; letter-spa=
cing: normal; text-align: start; text-indent: 0px; text-transform: none; wh=
ite-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-=
decoration: none;" class=3D"">
<span style=3D"caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size=
: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal;=
 letter-spacing: normal; text-align: start; text-indent: 0px; text-transfor=
m: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width:=
 0px; text-decoration: none; float: none; display: inline !important;" clas=
s=3D"">---</span><br style=3D"caret-color: rgb(0, 0, 0); font-family: Helve=
tica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-=
weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px=
; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-tex=
t-stroke-width: 0px; text-decoration: none;" class=3D"">
<span style=3D"caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size=
: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal;=
 letter-spacing: normal; text-align: start; text-indent: 0px; text-transfor=
m: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width:=
 0px; text-decoration: none; float: none; display: inline !important;" clas=
s=3D"">docs/man/xl.cfg.5.pod.in
 &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;| =
17 +++++++++++++++++</span><br style=3D"caret-color: rgb(0, 0, 0); font-fam=
ily: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: nor=
mal; font-weight: normal; letter-spacing: normal; text-align: start; text-i=
ndent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -=
webkit-text-stroke-width: 0px; text-decoration: none;" class=3D"">
<span style=3D"caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size=
: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal;=
 letter-spacing: normal; text-align: start; text-indent: 0px; text-transfor=
m: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width:=
 0px; text-decoration: none; float: none; display: inline !important;" clas=
s=3D"">tools/golang/xenlight/helpers.gen.go
 | &nbsp;6 ++++++</span><br style=3D"caret-color: rgb(0, 0, 0); font-family=
: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal=
; font-weight: normal; letter-spacing: normal; text-align: start; text-inde=
nt: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -web=
kit-text-stroke-width: 0px; text-decoration: none;" class=3D"">
<span style=3D"caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size=
: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal;=
 letter-spacing: normal; text-align: start; text-indent: 0px; text-transfor=
m: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width:=
 0px; text-decoration: none; float: none; display: inline !important;" clas=
s=3D"">tools/golang/xenlight/types.gen.go
 &nbsp;&nbsp;| &nbsp;1 +</span><br style=3D"caret-color: rgb(0, 0, 0); font=
-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps:=
 normal; font-weight: normal; letter-spacing: normal; text-align: start; te=
xt-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0p=
x; -webkit-text-stroke-width: 0px; text-decoration: none;" class=3D"">
<span style=3D"caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size=
: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal;=
 letter-spacing: normal; text-align: start; text-indent: 0px; text-transfor=
m: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width:=
 0px; text-decoration: none; float: none; display: inline !important;" clas=
s=3D"">tools/include/libxl.h
 &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&n=
bsp;&nbsp;&nbsp;| &nbsp;6 ++++++</span><br style=3D"caret-color: rgb(0, 0, =
0); font-family: Helvetica; font-size: 12px; font-style: normal; font-varia=
nt-caps: normal; font-weight: normal; letter-spacing: normal; text-align: s=
tart; text-indent: 0px; text-transform: none; white-space: normal; word-spa=
cing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=3D=
"">
<span style=3D"caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size=
: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal;=
 letter-spacing: normal; text-align: start; text-indent: 0px; text-transfor=
m: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width:=
 0px; text-decoration: none; float: none; display: inline !important;" clas=
s=3D"">tools/libs/light/libxl_create.c
 &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;| &nbsp;4 ++++</span><br style=3D"caret-colo=
r: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: norma=
l; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; =
text-align: start; text-indent: 0px; text-transform: none; white-space: nor=
mal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: no=
ne;" class=3D"">
<span style=3D"caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size=
: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal;=
 letter-spacing: normal; text-align: start; text-indent: 0px; text-transfor=
m: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width:=
 0px; text-decoration: none; float: none; display: inline !important;" clas=
s=3D"">tools/libs/light/libxl_types.idl
 &nbsp;&nbsp;&nbsp;&nbsp;| &nbsp;2 ++</span><br style=3D"caret-color: rgb(0=
, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-=
variant-caps: normal; font-weight: normal; letter-spacing: normal; text-ali=
gn: start; text-indent: 0px; text-transform: none; white-space: normal; wor=
d-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" cla=
ss=3D"">
<span style=3D"caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size=
: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal;=
 letter-spacing: normal; text-align: start; text-indent: 0px; text-transfor=
m: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width:=
 0px; text-decoration: none; float: none; display: inline !important;" clas=
s=3D"">tools/ocaml/libs/xc/xenctrl.ml
 &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;| &nbsp;1 +</span><br style=3D"caret-c=
olor: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: no=
rmal; font-variant-caps: normal; font-weight: normal; letter-spacing: norma=
l; text-align: start; text-indent: 0px; text-transform: none; white-space: =
normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration:=
 none;" class=3D"">
<span style=3D"caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size=
: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal;=
 letter-spacing: normal; text-align: start; text-indent: 0px; text-transfor=
m: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width:=
 0px; text-decoration: none; float: none; display: inline !important;" clas=
s=3D"">tools/ocaml/libs/xc/xenctrl.mli
 &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;| &nbsp;1 +</span><br style=3D"caret-color: =
rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; =
font-variant-caps: normal; font-weight: normal; letter-spacing: normal; tex=
t-align: start; text-indent: 0px; text-transform: none; white-space: normal=
; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;=
" class=3D"">
<span style=3D"caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size=
: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal;=
 letter-spacing: normal; text-align: start; text-indent: 0px; text-transfor=
m: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width:=
 0px; text-decoration: none; float: none; display: inline !important;" clas=
s=3D"">tools/xl/xl_parse.c
 &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&n=
bsp;&nbsp;&nbsp;&nbsp;&nbsp;| &nbsp;2 ++</span><br style=3D"caret-color: rg=
b(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; fo=
nt-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-=
align: start; text-indent: 0px; text-transform: none; white-space: normal; =
word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" =
class=3D"">
<span style=3D"caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size=
: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal;=
 letter-spacing: normal; text-align: start; text-indent: 0px; text-transfor=
m: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width:=
 0px; text-decoration: none; float: none; display: inline !important;" clas=
s=3D"">xen/arch/arm/domain.c
 &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&n=
bsp;&nbsp;&nbsp;| 10 ++++++++--</span><br style=3D"caret-color: rgb(0, 0, 0=
); font-family: Helvetica; font-size: 12px; font-style: normal; font-varian=
t-caps: normal; font-weight: normal; letter-spacing: normal; text-align: st=
art; text-indent: 0px; text-transform: none; white-space: normal; word-spac=
ing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=3D"=
">
<span style=3D"caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size=
: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal;=
 letter-spacing: normal; text-align: start; text-indent: 0px; text-transfor=
m: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width:=
 0px; text-decoration: none; float: none; display: inline !important;" clas=
s=3D"">xen/arch/arm/setup.c
 &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&n=
bsp;&nbsp;&nbsp;&nbsp;| &nbsp;1 +</span><br style=3D"caret-color: rgb(0, 0,=
 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-vari=
ant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: =
start; text-indent: 0px; text-transform: none; white-space: normal; word-sp=
acing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=
=3D"">
<span style=3D"caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size=
: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal;=
 letter-spacing: normal; text-align: start; text-indent: 0px; text-transfor=
m: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width:=
 0px; text-decoration: none; float: none; display: inline !important;" clas=
s=3D"">xen/arch/x86/domain.c
 &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&n=
bsp;&nbsp;&nbsp;| &nbsp;6 ++++++</span><br style=3D"caret-color: rgb(0, 0, =
0); font-family: Helvetica; font-size: 12px; font-style: normal; font-varia=
nt-caps: normal; font-weight: normal; letter-spacing: normal; text-align: s=
tart; text-indent: 0px; text-transform: none; white-space: normal; word-spa=
cing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=3D=
"">
<span style=3D"caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size=
: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal;=
 letter-spacing: normal; text-align: start; text-indent: 0px; text-transfor=
m: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width:=
 0px; text-decoration: none; float: none; display: inline !important;" clas=
s=3D"">xen/common/domain.c
 &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&n=
bsp;&nbsp;&nbsp;&nbsp;&nbsp;| &nbsp;9 ++++++++-</span><br style=3D"caret-co=
lor: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: nor=
mal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal=
; text-align: start; text-indent: 0px; text-transform: none; white-space: n=
ormal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: =
none;" class=3D"">
<span style=3D"caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size=
: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal;=
 letter-spacing: normal; text-align: start; text-indent: 0px; text-transfor=
m: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width:=
 0px; text-decoration: none; float: none; display: inline !important;" clas=
s=3D"">xen/include/asm-arm/domain.h
 &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;| &nbsp;1 +</span><br styl=
e=3D"caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; fo=
nt-style: normal; font-variant-caps: normal; font-weight: normal; letter-sp=
acing: normal; text-align: start; text-indent: 0px; text-transform: none; w=
hite-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text=
-decoration: none;" class=3D"">
<span style=3D"caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size=
: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal;=
 letter-spacing: normal; text-align: start; text-indent: 0px; text-transfor=
m: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width:=
 0px; text-decoration: none; float: none; display: inline !important;" clas=
s=3D"">xen/include/public/domctl.h
 &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;| &nbsp;5 ++++-</spa=
n><br style=3D"caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size=
: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal;=
 letter-spacing: normal; text-align: start; text-indent: 0px; text-transfor=
m: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width:=
 0px; text-decoration: none;" class=3D"">
<span style=3D"caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size=
: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal;=
 letter-spacing: normal; text-align: start; text-indent: 0px; text-transfor=
m: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width:=
 0px; text-decoration: none; float: none; display: inline !important;" clas=
s=3D"">15
 files changed, 68 insertions(+), 4 deletions(-)</span><br style=3D"caret-c=
olor: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: no=
rmal; font-variant-caps: normal; font-weight: normal; letter-spacing: norma=
l; text-align: start; text-indent: 0px; text-transform: none; white-space: =
normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration:=
 none;" class=3D"">
</div>
</blockquote>
</div>
<br class=3D"">
<div class=3D""><span style=3D"font-family: Menlo; font-size: 14px;" class=
=3D"">Acked-by: Christian Lindig &lt;</span><a href=3D"mailto:christian.lin=
dig@citrix.com" class=3D"" style=3D"font-family: Menlo; font-size: 14px;">c=
hristian.lindig@citrix.com</a><span style=3D"font-family: Menlo; font-size:=
 14px;" class=3D"">&gt;</span></div>
</body>
</html>

--_000_4EEC0FD316ED4B7F86A60D62656300D0citrixcom_--


From xen-devel-bounces@lists.xenproject.org Wed Oct 06 12:43:58 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Oct 2021 12:43:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.202907.357921 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mY6H2-0005of-3l; Wed, 06 Oct 2021 12:43:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 202907.357921; Wed, 06 Oct 2021 12:43:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mY6H2-0005oY-0o; Wed, 06 Oct 2021 12:43:52 +0000
Received: by outflank-mailman (input) for mailman id 202907;
 Wed, 06 Oct 2021 12:43:50 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=h5pW=O2=oracle.com=boris.ostrovsky@srs-us1.protection.inumbo.net>)
 id 1mY6H0-0005oS-9k
 for xen-devel@lists.xenproject.org; Wed, 06 Oct 2021 12:43:50 +0000
Received: from mx0a-00069f02.pphosted.com (unknown [205.220.165.32])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 0d3d7c4a-26a3-11ec-bf63-12813bfff9fa;
 Wed, 06 Oct 2021 12:43:49 +0000 (UTC)
Received: from pps.filterd (m0246617.ppops.net [127.0.0.1])
 by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 196Cb86r024850; 
 Wed, 6 Oct 2021 12:43:42 GMT
Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80])
 by mx0b-00069f02.pphosted.com with ESMTP id 3bh10gc244-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Wed, 06 Oct 2021 12:43:42 +0000
Received: from pps.filterd (userp3030.oracle.com [127.0.0.1])
 by userp3030.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 196Ceh3o129747;
 Wed, 6 Oct 2021 12:43:40 GMT
Received: from nam12-mw2-obe.outbound.protection.outlook.com
 (mail-mw2nam12lp2044.outbound.protection.outlook.com [104.47.66.44])
 by userp3030.oracle.com with ESMTP id 3bf0s8djae-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Wed, 06 Oct 2021 12:43:40 +0000
Received: from BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10)
 by BL0PR10MB2818.namprd10.prod.outlook.com (2603:10b6:208:72::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18; Wed, 6 Oct
 2021 12:43:38 +0000
Received: from BLAPR10MB5009.namprd10.prod.outlook.com
 ([fe80::3c49:46aa:83e1:a329]) by BLAPR10MB5009.namprd10.prod.outlook.com
 ([fe80::3c49:46aa:83e1:a329%5]) with mapi id 15.20.4587.019; Wed, 6 Oct 2021
 12:43:37 +0000
Received: from [10.74.97.159] (160.34.89.159) by
 BY3PR05CA0017.namprd05.prod.outlook.com (2603:10b6:a03:254::22) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.16 via Frontend
 Transport; Wed, 6 Oct 2021 12:43:35 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0d3d7c4a-26a3-11ec-bf63-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc :
 references : from : message-id : date : in-reply-to : content-type :
 content-transfer-encoding : mime-version; s=corp-2021-07-09;
 bh=TvBLmxsIAS/sKjJCbLdTJW8Coo6jE/9ghCpgAZ2RtQc=;
 b=kXsr2A3ljdbURVmORafnZoWLJPe1prBPtwekQK/T/PF17YZQxfYG2O3V9O080Paua0Cr
 Tyui8uLe8f0n02KshBLNmP4VcN1yM3fo4Adn5nWOVsgwtN+tGloFOBNO170eNsT7Vme3
 yPT2exdOoSZ143S32E0r7duR6Bfb55ot8UnAzw6gR5TS6t1gROcGacU7Ot2Ez9BsjhG1
 E49Crm3dCKAOdAq2LcGmV89ReizWCupfDdrjF0NQNSl8rBS3RKW0egm+peBBpuYWOajv
 bDgfrLROPfqfyfH8qe1ajHs/bYwQNtN9FG5TDIiGuhyfg4uarTL5b9P8oiHlS0B1dczd JA== 
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=g/U+DPe2hyblPI/x9Pcup5QAvTYKwLKYFwRAUX1kIoi/m8LhfXaiP+yFebdVcUVq2wo76otDtEmFVYOHA6NVuBvycvC8im40sHTRStIOChBpo1wOxM8gSQQvocCRnlL+i3/kzSIS7nxBBW54dGK3dz9KVth0tOWHXlHSPRnVfbKuzTk0XNEut7Qfr+LB8KALHvDFGwXUudWFjrKxZcGyK2mBtbYkTBbtpwOGjTbVYc8MF6ituCqTF/2NrWPZ5jxTOzHTTvjxhXjMP1cb3FgGI9QSEYeZ+qaJnz2RjA48HZn1WgibplQ+AdYgu9T9epiVq6A5SBhe3SfEwnFZfpIrMg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=TvBLmxsIAS/sKjJCbLdTJW8Coo6jE/9ghCpgAZ2RtQc=;
 b=FC9m7x+a4mst9gc+PTalAPWGg3iQ7dAbbXTtSeJxT+6yBzOKojtO5u+uCOOkYGOid/t643L7oi6Or7PMEJB50uDwrdyrW7MQo7G0lBtQI9oeNkIqR6SWP63ZqNqyi6DsU6acjgQeX9KtK196Q8C8Ck8cnSNz1c1GffGhCqnyu8yZFsL7FPK/IMo9Fco3YjNl7qm6N4zpqm3wDDgXAFvFbXm8PH+xetY+wuCH8wgnGfsrHiQXChpLE0eRb9z7V1c+5Exuw+SZEYOnBtT2kEJqcCJpXuhUdLrVSj9+MIZFJiMrzYU8Xl/Ahzy5FuROFfPTCzzOXuzZY6WeAr0rTENBkA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com;
 dkim=pass header.d=oracle.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=TvBLmxsIAS/sKjJCbLdTJW8Coo6jE/9ghCpgAZ2RtQc=;
 b=LXd4N5zCOfKU4tLGZ63SP+zqHnLmq24QCtm5lzb2CrYS/QNDpkKrM35kSzt2zNPBytpnXow6oaY8HEGQ7+RxlO9BAyuzX19XR0gMIakkIxct8fTlzOHB01McOBzo2OxSsg5xH0mWhRWiB7Pc2w9qDwt1apLIqst9Whe9M1GRcfU=
Authentication-Results: intel.com; dkim=none (message not signed)
 header.d=none;intel.com; dmarc=none action=none header.from=oracle.com;
Subject: Re: [PATCH] x86/pvh: add prototype for xen_pvh_init()
To: Juergen Gross <jgross@suse.com>, xen-devel@lists.xenproject.org,
        x86@kernel.org, linux-kernel@vger.kernel.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
        Borislav Petkov <bp@alien8.de>, "H. Peter Anvin" <hpa@zytor.com>,
        kernel test robot <lkp@intel.com>
References: <20211006061950.9227-1-jgross@suse.com>
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Message-ID: <5164486e-b6d5-035d-5eb6-ec03a04284d0@oracle.com>
Date: Wed, 6 Oct 2021 08:43:32 -0400
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0)
 Gecko/20100101 Thunderbird/78.14.0
In-Reply-To: <20211006061950.9227-1-jgross@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Content-Language: en-US
X-ClientProxiedBy: BY3PR05CA0017.namprd05.prod.outlook.com
 (2603:10b6:a03:254::22) To BLAPR10MB5009.namprd10.prod.outlook.com
 (2603:10b6:208:321::10)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: e32ae396-5958-4f90-07ef-08d988c6eaf7
X-MS-TrafficTypeDiagnostic: BL0PR10MB2818:
X-Microsoft-Antispam-PRVS: 
	<BL0PR10MB2818CFE54F5614239B1889208AB09@BL0PR10MB2818.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:486;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 
	58uZ8QMEQAznHJGok8IXSkqa2byUVOSwiUK6LuhRn69Rb1QKzAc079coBY3AumgKrnNhojC075cJuuO5Zz/dvVijje70u/9lxZTr9SA9rWxmQNDiH3jNOwCviAUBN6EehR070LKku+O2LGp+W0KZF7mB7ZllGyCOkJN31nCRQjFcdp4boN2JT1F+U3L4vegjyOtIIZbRV77+kwz8WL1bBksfW0yDO+zkjpGe7m4RG8mj7rlHryBfO+OEwI7erg99rHhrzpNBTF6GX9QF4pUQDbztZulYy/0g0116+3CYnC7u8Xa/Gr5qRJ4uHyUDFO+eA39dnCM/TCNuHVEVboBDc6DDAmJ6pDQVfP4KoK5XcYO+SeXYlBzGJoFGs1hOuSB7wezBcc2uidSH4LOYpW0/GOJWdHohb4UoXPEVKq58yfFslPV7RRCR9KmGpXWvqifC+4xCfbgvpUXj9PxPQ8JeebG1r8ES7mNZ8g8l5Dw9ycrQu//qJh2zya2IjYwxVrLfYW9mNo8kNkR8cilwfS5cubVh1Kr7Fa5EKhVK9J2qLn20bq/aSY3PaEMc3z2VgMR2s+E7bETssRusMZ8JHIwgD8OPqW9zKhIA1z9/UcKMrdaORcMMr6MmlQm4TuiYBMhiL0cg2raEnAmMCu9YtR6t027lcipQVHAcXwjqn9XQ5LE+fxhMbQwALAWwfpqJ2VX9ORViZHbgL66QDKMbDMUdbZ+42/XaJ6YCi65xKoWwAW0=
X-Forefront-Antispam-Report: 
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB5009.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(38100700002)(558084003)(508600001)(31696002)(4326008)(5660300002)(8936002)(8676002)(54906003)(186003)(66946007)(66556008)(86362001)(956004)(31686004)(66476007)(2616005)(316002)(16576012)(26005)(7416002)(53546011)(44832011)(6486002)(2906002)(36756003)(6666004)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?b0kvL01RcVgvZnltNnUya1BUNGMrVEpsWjJ0REFLVnF1SGxBOXpaaVUvd3VZ?=
 =?utf-8?B?TzdZa3RzZXd3U1o0bkxNcTduS2NHbVI0UGVGeTRCcU5yUXVGanZrYXFHREw3?=
 =?utf-8?B?eEhQN3dWZVRvMVltUTl6YndsVjhVbzZyQVB5ZU1wMVU5VDJycytvSmhJMFRz?=
 =?utf-8?B?V0hXZHRlVkg0Mmp6RS8zZ05CL3ZxMFZlUkRObDlIQzhBcitGQVlaQ2NhU3Vl?=
 =?utf-8?B?YnB1bzg4T1lyT3JDRzZyTTd4M1J3bTdUVFB4ZHJkQll6UUdZMG1XcEEyYk5K?=
 =?utf-8?B?SUhFSU9GSTVmeVlFZitXcFMzRVZObXNTeTdxNXI2UVF5VlVVZWhDZWx5N21i?=
 =?utf-8?B?MW5oTGNRbzFRNjBzUHU1V0ovcnZTMDdOWnhlL3VGNUNXTjgyOGhseVFPRWNx?=
 =?utf-8?B?Wk03bnlJelN5UkFjdHJ2UGlNTElmclBDWU5KM1AxQWovUlBCSlE5NlkvVDB5?=
 =?utf-8?B?TzVrMWZ4TlpYN1lXZEkyWm4rV1lZV05kRG5KNFQzamV6NUU5bjNNNEdUN3NT?=
 =?utf-8?B?dWNNRU1TdkYxYUVLT2FTMTVBblpwZzlsQVlzTkhPbGNSYUtoYTIxZFExbEJ4?=
 =?utf-8?B?NmY2SUxOUXZocVB1eXJSbTg1eXJJQVIwWkJHci9jR3lYTWVEdll3cG01Z3Rj?=
 =?utf-8?B?cjViWGhsWmdocW9zN2xvNjJyQUowZW9SZXIzZFJJbjM4SnNxcU5odjNZQ05y?=
 =?utf-8?B?NTIrMXhLZU1FYUxJKzJWdk1nNkdUYjc5NDFaVWVnY29nSFg2aEl2RU9TNU9W?=
 =?utf-8?B?S1hNY01hdituZzJzT2lsc3p1YlRkRWFScnAvOFl3ZFVnamwxNUVOdThmeFFD?=
 =?utf-8?B?enZlSzB1Rk4rcFAwOHVJUnhRRlZoaTBRQWJrUktmdUpTM3dBVVFIRnVJc3Fl?=
 =?utf-8?B?UFhLT2s1NlByZXlPK0JBYWRuSWcwRlNkbVozNkVOUyt4bitvL25XY2JDOEdP?=
 =?utf-8?B?amptZ29ONzJmaUVVaitlQ3phMmkrMlNBeWRadW1ON3B0ejI1NEZ3YTRnenUw?=
 =?utf-8?B?bTF1Tkw1dXN2VkpDN0hZVkw5d3ljRVF5SmVzbFQvRDFSMFVCNXA3ai8xeXB3?=
 =?utf-8?B?bUdyK2ZXUUI5aXRLK0J3NW5qYk41cm00bDIzcnVPQ0ptV1J0KzBPc0U4ckN3?=
 =?utf-8?B?dE93UzJ0cFFnVGtvTTBJRTFCZXVabnkxZGlzZjRTcnJjYno2RWtuMVVwMkMr?=
 =?utf-8?B?cU1RU0N1ZExRRHhyb0lhWnpyYjVmYmZMVmxtM2s1UW44VFljYnVJVnNBVE5J?=
 =?utf-8?B?a09BV0p1Q0xoTGdqb2dmbEpBS2lDK29vUm5hTFViTm95K2xkamVrYzFuU2M0?=
 =?utf-8?B?SWpDWnI3dE5WUHBncjhJd2RFMFpEU2VaOHJkREM2Q3lhbXVTY0ZTR21mQ21O?=
 =?utf-8?B?bzFPTS9QNkVkRHlMQ2ZHVHFvYXRyMTZWcXNzYStFMWJqbVlSZ3dkazFFOXVB?=
 =?utf-8?B?czlvOGNPU0hnS2s0RXRURWl3U0FFRjA0bzVpSzQxTGRESHlnajVYbTdmdUM2?=
 =?utf-8?B?dzAxLytxWVpPWTRDN2lwaDhDWTJaU3ltdzVGYmF5MEFtUHBvWnAzWDZLUjFk?=
 =?utf-8?B?MW9rOXNaalhlOVJENGpDc2pSbFh1VldxM0t2ZXBPbVl6RCtUZHBKMFYweFZR?=
 =?utf-8?B?VlNzcWJMVDRxQ3dmV1pCbUY0cUVremlZNTJFSHJMV1BtdWo2RTdZR1BKZWkv?=
 =?utf-8?B?VFBLS2JpVm1ZVDE4R3pMSURFV0ZpT21YZXR0MmpJcXZaa3FDdW5kcjQ4Ly8z?=
 =?utf-8?Q?Q2wtLHICMlC3REG3rKsjCpxqWXwP0cbt3VmdW9Y?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e32ae396-5958-4f90-07ef-08d988c6eaf7
X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Oct 2021 12:43:37.9413
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: WsJgIKxZhlAoZkkpjWRqsag4kIiiaSQRYjhIv2dU7QZZBxbtdQ8S9wdtDDfu9Xjzak7cVKdplDiQt0gJoFLQIAh+mSfK+Wu0XWPImUpg75c=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR10MB2818
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10128 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=0 adultscore=0
 mlxscore=0 phishscore=0 bulkscore=0 mlxlogscore=999 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109230001
 definitions=main-2110060079
X-Proofpoint-GUID: Jvtsb_5WOjBe9zqUnxy3OilB0n7KhK2D
X-Proofpoint-ORIG-GUID: Jvtsb_5WOjBe9zqUnxy3OilB0n7KhK2D


On 10/6/21 2:19 AM, Juergen Gross wrote:
> xen_pvh_init() is lacking a prototype in a header, add it.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Juergen Gross <jgross@suse.com>



Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>



From xen-devel-bounces@lists.xenproject.org Wed Oct 06 12:45:18 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Oct 2021 12:45:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.202914.357932 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mY6IQ-0006P2-FG; Wed, 06 Oct 2021 12:45:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 202914.357932; Wed, 06 Oct 2021 12:45:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mY6IQ-0006Ov-BU; Wed, 06 Oct 2021 12:45:18 +0000
Received: by outflank-mailman (input) for mailman id 202914;
 Wed, 06 Oct 2021 12:45:16 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=RZr5=O2=gmail.com=olekstysh@srs-us1.protection.inumbo.net>)
 id 1mY6IO-0006On-7P
 for xen-devel@lists.xenproject.org; Wed, 06 Oct 2021 12:45:16 +0000
Received: from mail-ed1-x532.google.com (unknown [2a00:1450:4864:20::532])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id de980cca-115b-4966-a4b9-ff8b2d983a8e;
 Wed, 06 Oct 2021 12:45:15 +0000 (UTC)
Received: by mail-ed1-x532.google.com with SMTP id z20so9289406edc.13
 for <xen-devel@lists.xenproject.org>; Wed, 06 Oct 2021 05:45:15 -0700 (PDT)
Received: from [192.168.1.7] ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id t4sm9975460edc.2.2021.10.06.05.45.13
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Wed, 06 Oct 2021 05:45:13 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: de980cca-115b-4966-a4b9-ff8b2d983a8e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-transfer-encoding:content-language;
        bh=CU5CqIpOCHtcOd9CxtMIwi/oo3TxK0WDN2pzFn/z9CQ=;
        b=WMvX4w2TGGF75p877H0e8sfCvLWKPx51TtpWYklYlIrT448EML7JiMohV3i0aKIMMV
         JZ8Z5cioLigRK57WxaSVs6e1mt588rzx4FZBVY5BF6rRyx6j5M+YY5o87XwzZK1FSAXL
         YxZF1REWbcrNJknEHCcVhsEQSKwSSPcKA7snaMyGcn34ObrBOo4zJZZ4VyaWq+4LcWTn
         dM/0R4EwbbgcNoX6yAfzJKAtARTgCgZZWz67A/KQWNsCfwQP5CAU6EA2gI34mAATDYBH
         rXsi8JAemghp6xpxTyJPWNv6WnAxTqXig0q+2ZEv2iO+Qx/ZVzQbXtD76msRAm+J/4sn
         4FRA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding
         :content-language;
        bh=CU5CqIpOCHtcOd9CxtMIwi/oo3TxK0WDN2pzFn/z9CQ=;
        b=rm09wLns3mhhBS0fE7JT71nFQFpupVE9CMAr2eRwDQfU9y+uqUQArt4jmSsEGit5ro
         R8nhLgSjSyk4OUHjxVGaukvr2K8rZFoSwGDUa+jHF85fffvA6DFvx1bkCdnjrKEk9y4w
         +7MI0JSzBEfFaMrGrrv0z5Xps378f/6cZYgW4lBGBxjnpogOeOgU0MymXrbr5Vr57fx0
         2V2iB+PrclZbHKKww+8bjwcIxoQGZHRlhfjewBWQ18njD9TJbomJZSFhDbESeKC08tAV
         9mN8z3o7mzN1kl462s1Q1Th4lMs90wQXCViO4ViOz9MHC1XXohKaash98QYzQirA1kMx
         CR6g==
X-Gm-Message-State: AOAM532QjI2vnzS3v/rx/3CckjEHjAuqnvY83kv+Iv7YsOjUxE7hoATg
	mzzpnwWpLSHE8tqQ7JwAvluNzU6FbOk=
X-Google-Smtp-Source: ABdhPJzISS1y47ByabQFHMmtwUVPlczNmyQfHM2YI91ugjTR1XLdFFJCdo4vZxsliwgTg9wBXlMhlw==
X-Received: by 2002:a17:906:a2c9:: with SMTP id by9mr27602554ejb.305.1633524314059;
        Wed, 06 Oct 2021 05:45:14 -0700 (PDT)
Subject: Re: [RFC 1/1] xen/arm: set iommu property for IOMMU-protected devices
To: Roman Skakun <rm.skakun@gmail.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>, Julien Grall
 <julien@xen.org>, xen-devel@lists.xenproject.org,
 Roman Skakun <roman_skakun@epam.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrii Anisov <andrii_anisov@epam.com>
References: <cover.1633106362.git.roman_skakun@epam.com>
 <5b101e4e85668bbb18da83044520b0350344f408.1633106362.git.roman_skakun@epam.com>
From: Oleksandr <olekstysh@gmail.com>
Message-ID: <292787a5-503f-72a5-3255-e583a1d014cb@gmail.com>
Date: Wed, 6 Oct 2021 15:45:12 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <5b101e4e85668bbb18da83044520b0350344f408.1633106362.git.roman_skakun@epam.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US


On 04.10.21 12:54, Roman Skakun wrote:

Hi Roman

> From: Roman Skakun <roman_skakun@epam.com>
>
> Xen is not exposing any IOMMU properties to Dom0.
> So Dom0 assumes that all it's devices are not protected by IOMMU.
>
> To make Dom0 aware of IOMMU-protected devices, we need to mark
> them somehow. With this approach Dom0 Linux kernel will be able
> to selectively disable swiotlb-xen fops for them which will remove
> unnecessary buffer bounces.
>
> This patch adds mechanism to describe IOMMU-protected devices by
> adding `xen,behind-iommu` property to relevant device nodes in
> Dom0 device tree.

I think that new property should be documented probably at

docs/misc/arm/device-tree/...

>
> Signed-off-by: Roman Skakun <roman_skakun@epam.com>
> ---
>   xen/arch/arm/domain_build.c | 7 +++++++
>   1 file changed, 7 insertions(+)
>
> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
> index 69fff7fc29..99e2c42b6c 100644
> --- a/xen/arch/arm/domain_build.c
> +++ b/xen/arch/arm/domain_build.c
> @@ -580,6 +580,13 @@ static int __init write_properties(struct domain *d, struct kernel_info *kinfo,
>               return res;
>       }
>   
> +    if ( iommu_node && is_iommu_enabled(d) && dt_device_is_protected(node) )
> +    {
> +        res = fdt_property(kinfo->fdt, "xen,behind-iommu", NULL, 0);
> +        if ( res )
> +            return res;
> +    }
> +
>       /*
>        * Override the property "status" to disable the device when it's
>        * marked for passthrough.

-- 
Regards,

Oleksandr Tyshchenko



From xen-devel-bounces@lists.xenproject.org Wed Oct 06 13:16:49 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Oct 2021 13:16:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.202927.357943 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mY6mo-0001KQ-UU; Wed, 06 Oct 2021 13:16:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 202927.357943; Wed, 06 Oct 2021 13:16:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mY6mo-0001KJ-Q7; Wed, 06 Oct 2021 13:16:42 +0000
Received: by outflank-mailman (input) for mailman id 202927;
 Wed, 06 Oct 2021 13:16:41 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mY6mn-0001K8-5G; Wed, 06 Oct 2021 13:16:41 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mY6mm-0003ue-KY; Wed, 06 Oct 2021 13:16:40 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mY6mm-0000PS-9A; Wed, 06 Oct 2021 13:16:40 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mY6mm-00087x-8P; Wed, 06 Oct 2021 13:16:40 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=f/YpxLk3f25fSCvALcG1tQB/543/Azu1kJpEg/zXwhA=; b=iNyoDurcUbWxcfFTULMcG4+70U
	lT2Sx1LtiZrtOENAN58h+kjeR+eK3nVjnTxFoJvssi2AulQu1RmXutnBnATPTMsBd8HqIxW7HkXMO
	zxU5zvmAmxJoIZCP/iXsH4PPAx8HO7+CWITvV1XQwTCEKfHVAXiPz6HvtqBAiuUGYFr4=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165384-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.12-testing test] 165384: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-4.12-testing:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    xen-4.12-testing:test-arm64-arm64-libvirt-raw:guest-start/debian.repeat:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-4.12-testing:test-amd64-amd64-xl-qcow2:guest-saverestore.2:fail:nonblocking
    xen-4.12-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.12-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.12-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.12-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.12-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.12-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.12-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.12-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.12-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.12-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-4.12-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-4.12-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.12-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-4.12-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-4.12-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.12-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-4.12-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.12-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=95172a6347111247287ca6d7966aff69aa379965
X-Osstest-Versions-That:
    xen=47193c78887734c2f95a50125684bf81419f1565
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 06 Oct 2021 13:16:40 +0000

flight 165384 xen-4.12-testing real [real]
flight 165399 xen-4.12-testing real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/165384/
http://logs.test-lab.xenproject.org/osstest/logs/165399/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 165399-retest

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-libvirt-raw 17 guest-start/debian.repeat fail baseline untested
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail baseline untested
 test-amd64-amd64-xl-qcow2    18 guest-saverestore.2          fail  like 164896
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 164930
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 164930
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 164930
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 164930
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 164930
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 164930
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 164930
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 164930
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 164930
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 164930
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 164930
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 xen                  95172a6347111247287ca6d7966aff69aa379965
baseline version:
 xen                  47193c78887734c2f95a50125684bf81419f1565

Last test of basis   164930  2021-09-10 01:51:03 Z   26 days
Testing same since   165384  2021-10-05 19:06:05 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Ivan Kardykov <kardykov@tabit.pro>
  Jan Beulich <jbeulich@suse.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 fail    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    fail    
 test-arm64-arm64-libvirt-raw                                 fail    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   47193c7888..95172a6347  95172a6347111247287ca6d7966aff69aa379965 -> stable-4.12


From xen-devel-bounces@lists.xenproject.org Wed Oct 06 13:23:13 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Oct 2021 13:23:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.202939.357961 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mY6t4-0002vu-PE; Wed, 06 Oct 2021 13:23:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 202939.357961; Wed, 06 Oct 2021 13:23:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mY6t4-0002vn-MI; Wed, 06 Oct 2021 13:23:10 +0000
Received: by outflank-mailman (input) for mailman id 202939;
 Wed, 06 Oct 2021 13:23:09 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=RZr5=O2=gmail.com=olekstysh@srs-us1.protection.inumbo.net>)
 id 1mY6t3-0002vf-EP
 for xen-devel@lists.xenproject.org; Wed, 06 Oct 2021 13:23:09 +0000
Received: from mail-ed1-x52e.google.com (unknown [2a00:1450:4864:20::52e])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id c0b5a1f4-6f40-4d72-b2ab-cc968618b6f6;
 Wed, 06 Oct 2021 13:23:08 +0000 (UTC)
Received: by mail-ed1-x52e.google.com with SMTP id f4so4519541edr.8
 for <xen-devel@lists.xenproject.org>; Wed, 06 Oct 2021 06:23:08 -0700 (PDT)
Received: from [192.168.1.7] ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id u2sm9584662edb.6.2021.10.06.06.23.06
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Wed, 06 Oct 2021 06:23:06 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c0b5a1f4-6f40-4d72-b2ab-cc968618b6f6
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-transfer-encoding:content-language;
        bh=eYG3bvYYg3J9DsJ4ZiMtpUVtoVVxXpmWgwP1iki8aGc=;
        b=pNCc7XPXjbBTZMr7UjipBVumnKzEq65r7Nae6hKT4ccDOd4ZTbUbRxYrBDEosG0RkO
         Zq6CBuaCB1U/sT0YRv7M+2ID3qmcZ5KsDLMyQhgDkitjZBk2My2RcX78vJ6W2wroMMFx
         V2HvEAFkLZ/zHJN/roBZRvmpU+kHPs9jOOYu/ltXcgIl/+nzmkeKTECb5H83zNr2Argv
         aa18hawD52VcVz070VAGvUZT5zLQtaZEPlVvWN0OpCy/HWQU8Pqf/QDdBtqp65ydCbyv
         7Bc0plJlc87PjSmDo1aTpV/mywgFo0kyaKjN6XLdNEtB42IVgiB87yX5W1OlD8Y7CdMO
         hyxw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding
         :content-language;
        bh=eYG3bvYYg3J9DsJ4ZiMtpUVtoVVxXpmWgwP1iki8aGc=;
        b=sQypcH9P4SW+iTh9yTrjaBtIMYWV1HHK9a2HThq6eok7FcE72cGpB95z1kEiiobdpw
         AAomn7dqDCh4Sewu7AHUKp3nCiGP4czkWhm1CLRDIGBmGDcgtl0afdM0IRxYwb2U0uuJ
         40tp9uGl2g9PsTmUwAzyYmj1vRveAsEweYGP6YcT93KcL02oXd7/71EpjnNmnd8gQJKn
         K41EZfzaOUpbNeOQvYoOj5JH9LrlKmFHz38dsNaHNQL1B6X1DKkZZzfg4i7XqvV79ncW
         7N+/sEe1UdBp2VX1yecBm9KdqH2pD1hl8dvY2HUJrufdld7+z4wuYr/ZvP9GqI4sAHTS
         l6dQ==
X-Gm-Message-State: AOAM5330M+rBFPpsCpqg5c4/08/Jx+u0W0/3YwmcPSfpycyC0ZmutRDO
	5t3QJpcBsEWPG7yuIbS21vw=
X-Google-Smtp-Source: ABdhPJx+T/eHY7FRQKAZNqm/2+tRCK414fst3p0ImjCgRgP/xjviWzsR8Aw4GsHfif+eTUHgUtHRPA==
X-Received: by 2002:a17:906:cc89:: with SMTP id oq9mr31725929ejb.70.1633526586803;
        Wed, 06 Oct 2021 06:23:06 -0700 (PDT)
Subject: [PING] Re: [PATCH] xen/arm: optee: Allocate anonymous domheap pages
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>,
 Julien Grall <julien@xen.org>, Julien Grall <jgrall@amazon.com>
References: <1630935741-17088-1-git-send-email-olekstysh@gmail.com>
 <alpine.DEB.2.21.2109231308200.17979@sstabellini-ThinkPad-T480s>
 <87bl4jrovq.fsf@epam.com>
From: Oleksandr <olekstysh@gmail.com>
Message-ID: <81f7699b-69c1-da52-a1a7-5000343bf872@gmail.com>
Date: Wed, 6 Oct 2021 16:23:05 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <87bl4jrovq.fsf@epam.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US


Hello all


Gentle reminder.


On 23.09.21 23:57, Volodymyr Babchuk wrote:
> Hi Stefano,
>
> Stefano Stabellini <sstabellini@kernel.org> writes:
>
>> On Mon, 6 Sep 2021, Oleksandr Tyshchenko wrote:
>>> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>>>
>>> Allocate anonymous domheap pages as there is no strict need to
>>> account them to a particular domain.
>>>
>>> Since XSA-383 "xen/arm: Restrict the amount of memory that dom0less
>>> domU and dom0 can allocate" the dom0 cannot allocate memory outside
>>> of the pre-allocated region. This means if we try to allocate
>>> non-anonymous page to be accounted to dom0 we will get an
>>> over-allocation issue when assigning that page to the domain.
>>> The anonymous page, in turn, is not assigned to any domain.
>>>
>>> CC: Julien Grall <jgrall@amazon.com>
>>> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>>> Acked-by: Volodymyr Babchuk <volodymyr_babchuk@epam.com>
>> Only one question, which is more architectural: given that these pages
>> are "unlimited", could the guest exploit the interface somehow to force
>> Xen to allocate an very high number of anonymous pages?
>>
>> E.g. could a domain call OPTEE_SMC_RPC_FUNC_ALLOC in a loop to force Xen
>> to exaust all memory pages?
> Generally, OP-TEE mediator tracks all resources allocated and imposes
> limits on them.
>
> OPTEE_SMC_RPC_FUNC_ALLOC case is a bit different, because it is issued
> not by domain, but by OP-TEE itself. As OP-TEE is more trusted piece of
> system we allow it to request as many buffers as it wants. Also, we know
> that OP-TEE asks only for one such buffer per every standard call. And
> number of simultaneous calls is limited by number of OP-TEE threads,
> which is quite low: typically only two.
>
-- 
Regards,

Oleksandr Tyshchenko



From xen-devel-bounces@lists.xenproject.org Wed Oct 06 16:43:25 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Oct 2021 16:43:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.202951.357972 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYA0c-0005Am-6y; Wed, 06 Oct 2021 16:43:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 202951.357972; Wed, 06 Oct 2021 16:43:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYA0c-0005Af-3L; Wed, 06 Oct 2021 16:43:10 +0000
Received: by outflank-mailman (input) for mailman id 202951;
 Wed, 06 Oct 2021 16:43:09 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=RZr5=O2=gmail.com=olekstysh@srs-us1.protection.inumbo.net>)
 id 1mYA0a-0005AZ-Ty
 for xen-devel@lists.xenproject.org; Wed, 06 Oct 2021 16:43:09 +0000
Received: from mail-ed1-x52e.google.com (unknown [2a00:1450:4864:20::52e])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 8e60cb26-19da-475c-8ea1-de069e08fccf;
 Wed, 06 Oct 2021 16:43:07 +0000 (UTC)
Received: by mail-ed1-x52e.google.com with SMTP id g10so11828215edj.1
 for <xen-devel@lists.xenproject.org>; Wed, 06 Oct 2021 09:43:06 -0700 (PDT)
Received: from [192.168.1.7] ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id 21sm9039618ejv.54.2021.10.06.09.43.04
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Wed, 06 Oct 2021 09:43:05 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8e60cb26-19da-475c-8ea1-de069e08fccf
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-transfer-encoding:content-language;
        bh=qyZjXB8gtaRu0Z/QxYOb1rOU+So8fcRfrhgKOe4nKGQ=;
        b=DppPKuE+Bqoh8Skt7ySYDiPE5UsX4cbdhWCqTmepAMqRN18O1OcQJib1wYgnZceEzJ
         U5e45EFZM5utg05p3EWGth88NMObE442VkEnDDXEId3WSbBZZ4zsWgx/5HXe92cVhS6P
         5pdYgLLp9A1yERosaH+Q+QhssiJixes3Hw2dKENbp9X8/zOYVwZkS96T0gcH3/DcLG2M
         Lvs7E3On74jw8cjRn+hLx3bm4Sw86L/x1F8K+5Wmky3T/zZK9HaUS1ihwRghJ54rCrv7
         Z92v3Hl8D4jfIN5wy2dG1xrIdXqp+7IXAeJWh1k+2DuGkIOqL1owUVcEDF21fcSwrtPE
         fbtA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding
         :content-language;
        bh=qyZjXB8gtaRu0Z/QxYOb1rOU+So8fcRfrhgKOe4nKGQ=;
        b=SwFTlVfNPtRB//Uba0fidSfnln94qbz+He6REwMusUxGWqLteKe+qTuSZqOEMokBpq
         OYVad1TSbKMSSbnvQ057WODFvBR6vSQGVubhzktm6OUDhi9W8WdWY/+vPVYgGrSQUS0x
         twR5yPO7BnA02Nj2qCkrY9gZd5p1rqF5Qezppvz0Z7e/NSCMnFGPN7NzvGII64x05w3V
         0uEghP5Xig2jkTK/s218WGgbwWvjX5tNBThAQ6YopdbuDN/KMvn2o78sfRDSACujoeI5
         L302RO6g5DwoX+FqKmk3zpHb9VQcmw6fnkm4yIX8+zoQdBGN4gjuzt4m6p32wb1ruHR3
         BL4w==
X-Gm-Message-State: AOAM531gnrKf4OY+amEJvAamMOC2AHGE2GEZJcblZt8U61Z5L2rlqUwU
	/TDPCXTcH4wp25+5hVofxB4=
X-Google-Smtp-Source: ABdhPJx0e3xIughrIfUerxb9+UmalvBJ2xOUbUz550Rs+pVoxrCQY8t0n8AIiojejcbxGBdpld/uLQ==
X-Received: by 2002:a05:6402:358a:: with SMTP id y10mr34605942edc.238.1633538585551;
        Wed, 06 Oct 2021 09:43:05 -0700 (PDT)
Subject: Re: [Stratos-dev] Xen Rust VirtIO demos work breakdown for Project
 Stratos
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: xen-devel <xen-devel@lists.xenproject.org>,
 Christopher Clark <christopher.w.clark@gmail.com>,
 =?UTF-8?Q?Alex_Benn=c3=a9e?= <alex.bennee@linaro.org>,
 =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?=
 <marmarek@invisiblethingslab.com>, Artem Mygaiev <Artem_Mygaiev@epam.com>,
 Sergio Lopez <slp@redhat.com>, Wei Liu <wl@xen.org>,
 Stefan Hajnoczi <stefanha@gmail.com>,
 Rust-VMM Mailing List <rust-vmm@lists.opendev.org>,
 Doug Goldstein <cardoe@cardoe.com>, Andrew Cooper
 <andrew.cooper3@citrix.com>, Arnd Bergmann <arnd.bergmann@linaro.org>,
 David Woodhouse <dwmw2@infradead.org>,
 Stratos Mailing List <stratos-dev@op-lists.linaro.org>,
 Rich Persaud <persaur@gmail.com>, Daniel Smith
 <dpsmith@apertussolutions.com>, Paul Durrant <paul@xen.org>,
 openxt <openxt@googlegroups.com>, Julien Grall <julien@xen.org>,
 jgross@suse.com
References: <87pmsylywy.fsf@linaro.org> <YU5mW396S04IsCBr@mail-itl>
 <874ka68h96.fsf@linaro.org>
 <CACMJ4GbgnQVQbH1N3Duxmx10n-Qv+zzncqarNyuhmKhE-wqdqA@mail.gmail.com>
 <alpine.DEB.2.21.2109272323160.5022@sstabellini-ThinkPad-T480s>
 <CAPD2p-=MdGB_a+oEsFrPQpLo7GeKkMwYyAWcQt3z0qrGr3vR7w@mail.gmail.com>
 <alpine.DEB.2.21.2110011649220.3209@sstabellini-ThinkPad-T480s>
 <CAPD2p-m=hYbG1YjPZ9yZ7Qzs6KjCT2jSHpaDUPB0sFJoZfY4uw@mail.gmail.com>
 <alpine.DEB.2.21.2110041436070.3209@sstabellini-ThinkPad-T480s>
From: Oleksandr <olekstysh@gmail.com>
Message-ID: <1d6382b6-ddf8-494c-4f7b-afc50a4269a4@gmail.com>
Date: Wed, 6 Oct 2021 19:43:03 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.21.2110041436070.3209@sstabellini-ThinkPad-T480s>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US


On 05.10.21 00:53, Stefano Stabellini wrote:

Hi Stefano, all

> On Sat, 2 Oct 2021, Oleksandr Tyshchenko wrote:
>> On Sat, Oct 2, 2021 at 2:58 AM Stefano Stabellini <sstabellini@kernel.org> wrote:
>>
>> Hi Stefano, all
>>
>> [Sorry for the possible format issues]
>> [I have CCed Julien]
>>
>>
>>        On Tue, 28 Sep 2021, Oleksandr Tyshchenko wrote:
>>        > On Tue, Sep 28, 2021 at 9:26 AM Stefano Stabellini <sstabellini@kernel.org> wrote:
>>        >
>>        > Hi Stefano, all
>>        >
>>        > [Sorry for the possible format issues]
>>        >
>>        >
>>        >       On Mon, 27 Sep 2021, Christopher Clark wrote:
>>        >       > On Mon, Sep 27, 2021 at 3:06 AM Alex Bennée via Stratos-dev <stratos-dev@op-lists.linaro.org> wrote:
>>        >       >
>>        >       >       Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com> writes:
>>        >       >
>>        >       >       > [[PGP Signed Part:Undecided]]
>>        >       >       > On Fri, Sep 24, 2021 at 05:02:46PM +0100, Alex Bennée wrote:
>>        >       >       >> Hi,
>>        >       >       >
>>        >       >       > Hi,
>>        >       >       >
>>        >       >       >> 2.1 Stable ABI for foreignmemory mapping to non-dom0 ([STR-57])
>>        >       >       >> ───────────────────────────────────────────────────────────────
>>        >       >       >>
>>        >       >       >>   Currently the foreign memory mapping support only works for dom0 due
>>        >       >       >>   to reference counting issues. If we are to support backends running in
>>        >       >       >>   their own domains this will need to get fixed.
>>        >       >       >>
>>        >       >       >>   Estimate: 8w
>>        >       >       >>
>>        >       >       >>
>>        >       >       >> [STR-57] <https://linaro.atlassian.net/browse/STR-57>
>>        >       >       >
>>        >       >       > I'm pretty sure it was discussed before, but I can't find relevant
>>        >       >       > (part of) thread right now: does your model assumes the backend (running
>>        >       >       > outside of dom0) will gain ability to map (or access in other way)
>>        >       >       > _arbitrary_ memory page of a frontend domain? Or worse: any domain?
>>        >       >
>>        >       >       The aim is for some DomU's to host backends for other DomU's instead of
>>        >       >       all backends being in Dom0. Those backend DomU's would have to be
>>        >       >       considered trusted because as you say the default memory model of VirtIO
>>        >       >       is to have full access to the frontend domains memory map.
>>        >       >
>>        >       >
>>        >       > I share Marek's concern. I believe that there are Xen-based systems that will want to run guests using VirtIO devices
>>        without
>>        >       extending
>>        >       > this level of trust to the backend domains.
>>        >
>>        >       >From a safety perspective, it would be challenging to deploy a system
>>        >       with privileged backends. From a safety perspective, it would be a lot
>>        >       easier if the backend were unprivileged.
>>        >
>>        >       This is one of those times where safety and security requirements are
>>        >       actually aligned.
>>        >
>>        >
>>        > Well, the foreign memory mapping has one advantage in the context of Virtio use-case
>>        > which is that Virtio infrastructure in Guest doesn't require any modifications to run on top Xen.
>>        > The only issue with foreign memory here is that Guest memory actually mapped without its agreement
>>        > which doesn't perfectly fit into the security model. (although there is one more issue with XSA-300,
>>        > but I think it will go away sooner or later, at least there are some attempts to eliminate it).
>>        > While the ability to map any part of Guest memory is not an issue for the backend running in Dom0
>>        > (which we usually trust), this will certainly violate Xen security model if we want to run it in other
>>        > domain, so I completely agree with the existing concern.
>>
>>        Yep, that's what I was referring to.
>>
>>
>>        > It was discussed before [1], but I couldn't find any decisions regarding that. As I understand,
>>        > the one of the possible ideas is to have some entity in Xen (PV IOMMU/virtio-iommu/whatever)
>>        > that works in protection mode, so it denies all foreign mapping requests from the backend running in DomU
>>        > by default and only allows requests with mapping which were *implicitly* granted by the Guest before.
>>        > For example, Xen could be informed which MMIOs hold the queue PFN and notify registers
>>        > (as it traps the accesses to these registers anyway) and could theoretically parse the frontend request
>>        > and retrieve descriptors to make a decision which GFNs are actually *allowed*.
>>        >
>>        > I can't say for sure (sorry not familiar enough with the topic), but implementing the virtio-iommu device
>>        > in Xen we could probably avoid Guest modifications at all. Of course, for this to work
>>        > the Virtio infrastructure in Guest should use DMA API as mentioned in [1].
>>        >
>>        > Would the “restricted foreign mapping” solution retain the Xen security model and be accepted
>>        > by the Xen community? I wonder, has someone already looked in this direction, are there any
>>        > pitfalls here or is this even feasible?
>>        >
>>        > [1] https://lore.kernel.org/xen-devel/464e91ec-2b53-2338-43c7-a018087fc7f6@arm.com/
>>
>>        The discussion that went further is actually one based on the idea that
>>        there is a pre-shared memory area and the frontend always passes
>>        addresses from it. For ease of implementation, the pre-shared area is
>>        the virtqueue itself so this approach has been called "fat virtqueue".
>>        But it requires guest modifications and it probably results in
>>        additional memory copies.
>>
>>   
>> I got it. Although we would need to map that pre-shared area anyway (I presume it could be done at once during initialization), I think it
>> much better than
>> map arbitrary pages at runtime.
> Yeah that's the idea
>
>
>> If there is a way for Xen to know the pre-shared area location in advance it will be able to allow mapping
>> this region only and deny other attempts.
>   
> No, but there are patches (not yet upstream) to introduce a way to
> pre-share memory regions between VMs using xl:
> https://github.com/Xilinx/xen/commits/xilinx/release-2021.1?after=4bd2da58b5b008f77429007a307b658db9c0f636+104&branch=xilinx%2Frelease-2021.1
>
> So I think it would probably be the other way around: xen/libxl
> advertises on device tree (or ACPI) the presence of the pre-shared
> regions to both domains. Then frontend and backend would start using it.

Thank you for the explanation. I remember this series has already 
appeared in ML. If I got the idea correctly this way we won't need to 
map the foreign memory from the backend at all (I assume this eliminates 
security concern?). It looks like the every pre-shared region (described 
in config file) is mapped by the toolstack at the domains creation time 
and the details of this region are also written to the Xenstore. All 
what backend needs to do is to map the region into its address space 
(via mmap). For this to work the guest should allocate virtqueue from 
Xen specific reserved memory [1].

[1] 
https://www.kernel.org/doc/Documentation/devicetree/bindings/reserved-memory/xen%2Cshared-memory.txt


>   
>>        I am not sure if the approach you mentioned could be implemented
>>        completely without frontend changes. It looks like Xen would have to
>>        learn how to inspect virtqueues in order to verify implicit grants
>>        without frontend changes.
>>
>>   
>> I looked through the virtio-iommu specification and corresponding Linux driver but I am sure I don't see all the challenges and pitfalls.
>> Having a limited knowledge of IOMMU infrastructure in Linux, below is just my guess, which might be wrong.
>>
>> 1. I think, if we want to avoid frontend changes the backend in Xen would need to fully conform to the specification, I am afraid that
>> besides just inspecting virtqueues, the backend needs to properly and completely emulate the virtio device, handle shadow page tables, etc.
>> Otherwise we might break the guest. I expect a huge amount of work to implement this properly.
> Yeah, I think we would want to stay away from shadow pagetables unless
> we are really forced to go there.
>
>
>> 2. Also, if I got the things correctly, it looks like when enabling virtio-iommu, all addresses passed in requests to the virtio devices
>> behind the virtio-iommu will be in guest virtual address space (IOVA). So we would need to find a way for userspace (if the backend is
>> IOREQ server) to translate them to guest physical addresses (IPA) via these shadow page tables in the backend in front of mapping them via
>> foreign memory map calls. So I expect Xen, toolstack and Linux privcmd driver changes and additional complexity taking into account how the
>> data structures could be accessed (data structures being continuously in IOVA, could be discontinuous in IPA, indirect table descriptors,
>> etc).
>> I am wondering, would it be possible to have identity IOMMU mapping (IOVA == GPA) at the guest side but without bypassing an IOMMU, as we
>> need the virtio-iommu frontend to send map/unmap requests, can we control this behaviour somehow?
>> I think this would simplify things.
> None of the above looks easy. I think you are right that we would need
> IOVA == GPA to make the implementation feasible and with decent
> performance.

Yes. Otherwise, I am afraid, the implementation is going to be quite 
difficult with questionable performance at the end.

I found out that IOMMU domain in Linux can be identity mapped 
(IOMMU_DOMAIN_IDENTITY - DMA addresses are system physical addresses) 
and this can be controlled via cmd line.
I admit I didn't test, but from the IOMMU framework code it looks like 
that driver's map/unmap callback won't be called in this mode and as the 
result the IOMMU mapping never reaches the backend. Unfortunately, this 
is not what we want as we won't have any understating what the GFNs are...

> But if we need a spec change, then I think Juergen's
> proposal of introducing a new transport that uses grant table references
> instead of GPAs is worth considering.

Agree, if we the spec changes cannot be avoided then yes.


>
>
>> 3. Also, we would probably want to have a single virtio-iommu device instance per guest, so all virtio devices which belong to this guest
>> will share the IOMMU mapping for the optimization purposes. For this to work all virtio devices inside a guest should be attached to the
>> same IOMMU domain. Probably, we could control that, but I am not 100% sure.

-- 
Regards,

Oleksandr Tyshchenko



From xen-devel-bounces@lists.xenproject.org Wed Oct 06 17:27:25 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Oct 2021 17:27:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.202960.357983 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYAhM-00014u-JD; Wed, 06 Oct 2021 17:27:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 202960.357983; Wed, 06 Oct 2021 17:27:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYAhM-00014n-GA; Wed, 06 Oct 2021 17:27:20 +0000
Received: by outflank-mailman (input) for mailman id 202960;
 Wed, 06 Oct 2021 17:27:19 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mYAhL-00014c-8G; Wed, 06 Oct 2021 17:27:19 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mYAhL-00009n-2X; Wed, 06 Oct 2021 17:27:19 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mYAhK-0004xU-Oj; Wed, 06 Oct 2021 17:27:18 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mYAhK-0004o2-MH; Wed, 06 Oct 2021 17:27:18 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=1ryJcD76M/QBv6767+nbMboA4ID52kk86sm/Wdd+DWI=; b=fjM/odXCksuJ4svHYYlos9aOSj
	QLg9F9bBfGRHf73kTsQhxZnRUqsNsMK2Yr74saQmjk2Z/MeaG5WZkm0h0vYBYDVxUnf46XEuZDA0i
	nIwTs5YbR6Mx2xGD9zY6bKowLZfIqyKpGGjPFSGp8VcxKBhkgk0SRx7AnjTxNvjs0X0I=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165385-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.13-testing test] 165385: regressions - FAIL
X-Osstest-Failures:
    xen-4.13-testing:test-armhf-armhf-xl-arndale:guest-start/debian.repeat:fail:regression
    xen-4.13-testing:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=b4bb02d5999a56c93f0733b589b717e7cece9c09
X-Osstest-Versions-That:
    xen=6e2fc128eb1a7d8ff8c36123a0a03e4e60a4a44c
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 06 Oct 2021 17:27:18 +0000

flight 165385 xen-4.13-testing real [real]
flight 165400 xen-4.13-testing real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/165385/
http://logs.test-lab.xenproject.org/osstest/logs/165400/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-armhf-armhf-xl-arndale 18 guest-start/debian.repeat fail REGR. vs. 164939

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail baseline untested
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 164939
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 164939
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 164939
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 164939
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 164939
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 164939
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 164939
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 164939
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 164939
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 164939
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 164939
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  b4bb02d5999a56c93f0733b589b717e7cece9c09
baseline version:
 xen                  6e2fc128eb1a7d8ff8c36123a0a03e4e60a4a44c

Last test of basis   164939  2021-09-10 07:37:18 Z   26 days
Testing same since   165385  2021-10-05 19:06:15 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Ivan Kardykov <kardykov@tabit.pro>
  Jan Beulich <jbeulich@suse.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  fail    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

------------------------------------------------------------
commit b4bb02d5999a56c93f0733b589b717e7cece9c09
Author: Jan Beulich <jbeulich@suse.com>
Date:   Fri Oct 1 15:05:42 2021 +0200

    VT-d: fix deassign of device with RMRR
    
    Ignoring a specific error code here was not meant to short circuit
    deassign to _just_ the unmapping of RMRRs. This bug was previously
    hidden by the bogus (potentially indefinite) looping in
    pci_release_devices(), until f591755823a7 ("IOMMU/PCI: don't let domain
    cleanup continue when device de-assignment failed") fixed that loop.
    
    This is CVE-2021-28702 / XSA-386.
    
    Fixes: 8b99f4400b69 ("VT-d: fix RMRR related error handling")
    Reported-by: Ivan Kardykov <kardykov@tabit.pro>
    Signed-off-by: Jan Beulich <jbeulich@suse.com>
    Tested-by: Ivan Kardykov <kardykov@tabit.pro>
    (cherry picked from commit 24ebe875a77833696bbe5c9372e9e1590a7e7101)
(qemu changes not included)


From xen-devel-bounces@lists.xenproject.org Wed Oct 06 17:34:57 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Oct 2021 17:34:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.202972.357997 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYAof-0002cN-Gm; Wed, 06 Oct 2021 17:34:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 202972.357997; Wed, 06 Oct 2021 17:34:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYAof-0002cG-DU; Wed, 06 Oct 2021 17:34:53 +0000
Received: by outflank-mailman (input) for mailman id 202972;
 Wed, 06 Oct 2021 17:34:52 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=13oh=O2=arm.com=Rahul.Singh@srs-us1.protection.inumbo.net>)
 id 1mYAoe-0002cA-5R
 for xen-devel@lists.xenproject.org; Wed, 06 Oct 2021 17:34:52 +0000
Received: from EUR01-VE1-obe.outbound.protection.outlook.com (unknown
 [40.107.14.74]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id b4cef376-26cb-11ec-bf8a-12813bfff9fa;
 Wed, 06 Oct 2021 17:34:50 +0000 (UTC)
Received: from DB9PR06CA0015.eurprd06.prod.outlook.com (2603:10a6:10:1db::20)
 by DB7PR08MB3001.eurprd08.prod.outlook.com (2603:10a6:5:23::29) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.22; Wed, 6 Oct
 2021 17:34:47 +0000
Received: from DB5EUR03FT011.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:10:1db:cafe::ed) by DB9PR06CA0015.outlook.office365.com
 (2603:10a6:10:1db::20) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18 via Frontend
 Transport; Wed, 6 Oct 2021 17:34:47 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT011.mail.protection.outlook.com (10.152.20.95) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4587.18 via Frontend Transport; Wed, 6 Oct 2021 17:34:47 +0000
Received: ("Tessian outbound b9598e0ead92:v103");
 Wed, 06 Oct 2021 17:34:47 +0000
Received: from cd1f953a2f77.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 83AFD11C-6476-49D7-BDBB-6D1AB3815E45.1; 
 Wed, 06 Oct 2021 17:34:40 +0000
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id cd1f953a2f77.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Wed, 06 Oct 2021 17:34:40 +0000
Received: from AS8PR08MB6919.eurprd08.prod.outlook.com (2603:10a6:20b:39e::10)
 by AS8PR08MB6743.eurprd08.prod.outlook.com (2603:10a6:20b:399::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.22; Wed, 6 Oct
 2021 17:34:39 +0000
Received: from AS8PR08MB6919.eurprd08.prod.outlook.com
 ([fe80::51ee:e7de:6c0a:bcf9]) by AS8PR08MB6919.eurprd08.prod.outlook.com
 ([fe80::51ee:e7de:6c0a:bcf9%7]) with mapi id 15.20.4566.023; Wed, 6 Oct 2021
 17:34:39 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b4cef376-26cb-11ec-bf8a-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=a0tVOAYFws4w5ave92WBSKB//qoMdO2J2APb3OThhXk=;
 b=ax98qRSnByL5RYkuUMfaGwbPdOUixpo40JHojj6kngzpbAdp61nXVT2KozPnJcaMSRkIWWcaqup37p7gnGPzkWsKVpt3oqgpsAm/P37o4U5TG1Gr9M4Eb9cwyue/+GD/yoET91Hx0Ql/7QWGY9UecJCF7k+etCy3mmVdkzyBv50=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: d9830dec7dbe2d89
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=c+TqKsouKbyXJO48Ah5sABbeWydHvuuVz1gF19lZW4W7/7v0tt2PdrJB0SyLn5lVi4hl+JV3oPZfChpNXUVJ1KAPTqfTJJRWoHyhtgpRFbwA/pUBKjz+1kDc0z16jAmA6giMa8jg4O62iU0Wz7+x7gB1stcXp5Gk6/PBojn6ZJODJUoA9B65nnfVAoHJTKJ/UGS2ogSW0gWza9E69LzlwvztYS5OvEoYhT604ZidipxsYlthPo/2vXhQiTJu4Qh2HRi1KKRbMnNDEqXxpp8F5xZ7vl+LFnmBXxs5/+HZ19agnuH7UnKi0RsCyviJMftT7K+Vj1jIWfiIxTWhHzVruA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=a0tVOAYFws4w5ave92WBSKB//qoMdO2J2APb3OThhXk=;
 b=eCIqM9V/LSUU/QrcTYV2pgVa0dn7jBx3anO6jIiC7/nadNd4RjG6FoTUcH559+sEuRCvLLY4DUaTB9bfZDvT9suXczTOvKjnQoEJ1ysv2GuQzJtsKVwkl/huBhG1GwseWorD1JDBiWyNp/tdQwLU5EsPnJ9sSyJZ3UYztsg5Qp8DRTft+EABPiMRZvNwvlbp2mdb3lVA9mnJvCBegkKwwr1squlLhfwRhC/4LdJS95atooKQogR0oJJ41Y6P6K4ZrlN46bHoiBq2+V24D2YGvEq54OSfBMFLXwbvzpX7cGOZ5O9K2QTDkKeM+YZHyuKhZenEfjEZ6kTh+iMRrSqe/Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=a0tVOAYFws4w5ave92WBSKB//qoMdO2J2APb3OThhXk=;
 b=ax98qRSnByL5RYkuUMfaGwbPdOUixpo40JHojj6kngzpbAdp61nXVT2KozPnJcaMSRkIWWcaqup37p7gnGPzkWsKVpt3oqgpsAm/P37o4U5TG1Gr9M4Eb9cwyue/+GD/yoET91Hx0Ql/7QWGY9UecJCF7k+etCy3mmVdkzyBv50=
From: Rahul Singh <Rahul.Singh@arm.com>
To: Ian Jackson <iwj@xenproject.org>
CC: Stefano Stabellini <sstabellini@kernel.org>, xen-devel
	<xen-devel@lists.xenproject.org>, Bertrand Marquis
	<Bertrand.Marquis@arm.com>, Andre Przywara <Andre.Przywara@arm.com>, Wei Liu
	<wl@xen.org>, Anthony PERARD <anthony.perard@citrix.com>, Juergen Gross
	<jgross@suse.com>, Julien Grall <julien@xen.org>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH v4 13/14] arm/libxl: Emulated PCI device tree node in
 libxl
Thread-Topic: [PATCH v4 13/14] arm/libxl: Emulated PCI device tree node in
 libxl
Thread-Index:
 AQHXuRciClWhjFX7R0aQhsW/aixhyqvDkJEAgACf3oCAAL5hgIAAzJaAgAAXDgCAAALtgIAABFYAgABk+IA=
Date: Wed, 6 Oct 2021 17:34:37 +0000
Message-ID: <5ADA6C46-A69D-459F-868C-DA579FEC36E2@arm.com>
References: <cover.1633340795.git.rahul.singh@arm.com>
 <3ad42008f534671ae7f5b25da91253ce7cd4a3e9.1633340795.git.rahul.singh@arm.com>
 <alpine.DEB.2.21.2110041714410.3209@sstabellini-ThinkPad-T480s>
 <11F169C6-39A4-40F3-8E75-39B8C2CCF022@arm.com>
 <alpine.DEB.2.21.2110051421520.3209@sstabellini-ThinkPad-T480s>
 <8B848F95-977F-4DF4-B315-CFEA610BC1C3@arm.com>
 <24925.33634.554859.2131@mariner.uk.xensource.com>
 <BFC5AD62-3DA7-498F-8B6E-AB4C8CAA9731@arm.com>
 <24925.35194.369692.94259@mariner.uk.xensource.com>
In-Reply-To: <24925.35194.369692.94259@mariner.uk.xensource.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
Authentication-Results-Original: xenproject.org; dkim=none (message not
 signed) header.d=none;xenproject.org; dmarc=none action=none
 header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: e974641f-00c4-42db-4ccc-08d988ef9791
x-ms-traffictypediagnostic: AS8PR08MB6743:|DB7PR08MB3001:
x-ms-exchange-transport-forked: True
X-Microsoft-Antispam-PRVS:
	<DB7PR08MB300182E278ACD4F598F4DB42FCB09@DB7PR08MB3001.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:9508;OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 LghTm4AukYUNtI0Y6pZpop21GYMlb9T8FOMPIXKODaHwKHEQW6hzEJtvmqaF8f6m+BeGns4kIUTNVkhKgoavorEQ1o37oAbrN9U8p8yrACNThWqxbQ1PYEoHkKQKq4TND1+w9bcwTr0TWqrPt2maNgQIMIkzm2QwQpvlA1X9r2rrFlY/Bv7qKEaSGIMSVleCliRebzl1vUnrEYBNuVUdy+GYQ927cN8XV7JKdQvneHJJNoLQi/8TewFaKOosgT10+hFzzqbZOBbkBI/Xck/j2j+D1u4EmChwHvjsFcvilrMr5CDldp8PfZzkTAH4rnZ/sVHNYg7xAeIC1acmA68P0WOy7uY9/K5GJWx41Q70VL3WTY+6fB0axg2rvayT8M0skrglFkMwO/l9aoKz9s/yK/p1PEjc9tg5fBkVuF8Rj51rfk9kTEqS2QjHuerPheV+OrtLHhFRj8lhuTp/86aq5lmEEouShRskCKN6M60Htrv2pst5IS08cYsBRUwTgCKuiYA2Q3W+xUAxm3g9OAviu9EX3jtmjnIx8yi23Rx3SUXTK4Y1MZGlCSbJsxTS6u2v881vwtNZWzxCRS+/CdZphVu1kIY+dOWs5b5sW6QlRusIxpERlyXS8MDINOJGCnzicRIDJkSVHs/rh2dzFpQw7aJVC3Omra759Zk76sL0gP7kLqjS9lJxKJJ8Zf22IaCruV2u7Ay9KEaxS6opL8J+/Ux63nE485X5VAJxnyEGszVfBpbOKL9xXa6dLuGrtDP4
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6919.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(54906003)(6916009)(6512007)(71200400001)(86362001)(6486002)(38070700005)(8936002)(316002)(66946007)(38100700002)(83380400001)(122000001)(53546011)(36756003)(33656002)(5660300002)(6506007)(66476007)(2616005)(26005)(66446008)(91956017)(76116006)(64756008)(186003)(8676002)(2906002)(508600001)(4326008)(66556008)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-ID: <6A53861E93E21941A04C90E028F88AFF@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6743
Original-Authentication-Results: xenproject.org; dkim=none (message not signed)
 header.d=none;xenproject.org; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT011.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	a7acae48-f11c-4ff4-ec6e-08d988ef92c6
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	I73NSbYRn6d+o3jp3bhR/AcoMbYmRIZzPEm8CDYbEKv6EtWG9T01tBuXmyIjpaFZYGg5drElyOgPwS6VILw1frYFw8B/P///eQRl2w/NzvXPu4Lku+JYs+F/qx+R5Sv7GJ+mUwpn+RQ0yFsjypzOwTawBIFBjc16S/LcqHMGh6nhmGWPSJzY4XyP1ZoNsYhnsPT7SaICmgtXYahHuzVmuQLDpMQ5jP74lrvEaiz203L+QMRWACYHMNr3u5O4cq0+hylk0bwVhfqF3FJCoypc5x1/LRMgKwevJJ0n+5cjouKcAPkTiC0db2KvshHH9NFoZB7uA06UM/A9fbW8OX4qq7+dhBb1/3M1Xacdmq0ORhd/9e5hClerA0cMT/ukZTSYiiRMium1kD5De77AGgoG16GgX2dAxi+YV/03dPNjCNkrtaiIUK64WQhSjZDFCoCE5gI3WS1fBzxtagYYKVuUuk0V3gRS2eQk2I6UX78weq4/ovrPFGczr8qwjpKRJnuDWTDXTHjvGwAkosv40vyMg6HGjO4CN8acmR5BD9YBc1IwqOpcR/9rB/TqW/O4/wiKfC7mfzXw0C0238wJV2Qrr5enh6F8myQ+AVQtDLkYul+ReEIsWeL3wjam7nXAtf7GQKGrrsfUKVk3stOM5m3YnArKHRkn41rv/8+6NVOY9iB+VzmyE0cZ7/GpmjlEg53vHmUJ6hTrNiQrPMgpiEpNHQ==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(2616005)(6506007)(107886003)(2906002)(81166007)(5660300002)(86362001)(6486002)(82310400003)(4326008)(33656002)(8936002)(6862004)(6512007)(54906003)(70206006)(53546011)(356005)(47076005)(83380400001)(70586007)(8676002)(336012)(26005)(36860700001)(36756003)(508600001)(186003)(316002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Oct 2021 17:34:47.1009
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: e974641f-00c4-42db-4ccc-08d988ef9791
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT011.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3001

SGkgSWFuLA0KDQo+IE9uIDYgT2N0IDIwMjEsIGF0IDEyOjMzIHBtLCBJYW4gSmFja3NvbiA8aXdq
QHhlbnByb2plY3Qub3JnPiB3cm90ZToNCj4gDQo+IFJhaHVsIFNpbmdoIHdyaXRlcyAoIlJlOiBb
UEFUQ0ggdjQgMTMvMTRdIGFybS9saWJ4bDogRW11bGF0ZWQgUENJIGRldmljZSB0cmVlIG5vZGUg
aW4gbGlieGwiKToNCj4+IEhpIElhbgkNCj4+PiBXaGF0IGlzIHdyb25nIHdpdGggcHV0dGluZyBp
dCBpbg0KPj4+IGxpYnhsX19hcmNoX2RvbWFpbl9idWlsZF9pbmZvX3NldGRlZmF1bHQNCj4+PiB3
aGljaCBJIHRoaW5rIGV4aXN0cyBwcmVjaXNlbHkgZm9yIHRoaXMga2luZCBvZiB0aGluZyA/DQo+
PiANCj4+IEFzIHdlIGhhdmUgdG8gc2V0IHRoZSBhcmNoX2FybS52cGNpIHRvIGZhbHNlIGZvciB4
ODYgYW5kIEFSTSBJDQo+PiB0aG91Z2h0IGl0IGlzIHJpZ2h0IHRvIG1vdmUgdGhlIGNvZGUgdG8g
Y29tbW9uIGNvZGUgdG8gYXZvaWQNCj4+IGR1cGxpY2F0aW9uLg0KPj4gDQo+PiBBcmUgeW91IHN1
Z2dlc3RpbmcgdG8gcHV0ICINCj4+IGxpYnhsX2RlZmJvb2xfc2V0ZGVmYXVsdCgmYl9pbmZvLT5h
cmNoX2FybS52cGNpLCBmYWxzZSnDr8W8xZNpbg0KPj4gbGlieGxfX2FyY2hfZG9tYWluX2J1aWxk
X2luZm9fc2V0ZGVmYXVsdCgpIGZvciB4ODYgYW5kIEFSTQ0KPj4gZGlmZmVyZW50bHkuDQo+IA0K
PiBJJ3ZlIGdvbmUgYmFjayBhbmQgcmVyZWFkIHRoZSB3aG9sZSB0aHJlYWQsIHdoaWNoIEkgcHJv
YmFibHkgc2hvdWxkDQo+IGhhdmUgZG9uZSB0byBzdGFydCB3aXRoLi4uLg0KPiANCj4gU286DQo+
IA0KPj4+PiAjaWYgZGVmaW5lZChfX2FybV9fKSB8fCBkZWZpbmVkKF9fYWFyY2g2NF9fKSAgICAg
ICAgICAgICAgICAgIA0KPj4+PiAgIC8qICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgDQo+Pj4+ICAgICogRW5hYmxlIFZQQ0kgc3VwcG9ydCBmb3IgQVJNLiBWUENJIHN1cHBvcnQg
Zm9yIERPTVUgZ3Vlc3RzIGlzIG5vdCAgICANCj4+Pj4gICAgKiBzdXBwb3J0ZWQgZm9yIHg4Ni4g
ICAgICAgICAgICAgICAgICAgICAgICAgIA0KPj4+PiAgICAqLyAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgDQo+Pj4+ICAgaWYgKGRfY29uZmlnLT5udW1fcGNpZGV2cykgICAgICAg
ICAgICAgICAgICAgICAgICANCj4+Pj4gICAgIGxpYnhsX2RlZmJvb2xfc2V0KCZiX2luZm8tPmFy
Y2hfYXJtLnZwY2ksIHRydWUpOyAgICAgICAgICAgDQo+Pj4+ICNlbmRpZiANCj4gDQo+IEkgdGhp
bmsgdGhpcyBsb2dpYyBwcm9iYWJseSBvdWdodCB0byBiZSBpbiBsaWJ4bCwgbm90IGluIHhsLg0K
DQpJIHdpbGwgbW92ZSB0aGUgY29kZSB0byAibGlieGxfYXJtLmMidG8gYXZvaWQgI2lmZGVmIGlu
IGNvbW1vbiBjb2RlIGFuZCBhbHNvICB0byBhdm9pZCBzZXR0aW5nIHRoZSB2cGNpIGZvciB4ODYN
Cg0KZGlmZiAtLWdpdCBhL3Rvb2xzL2xpYnMvbGlnaHQvbGlieGxfYXJtLmMgYi90b29scy9saWJz
L2xpZ2h0L2xpYnhsX2FybS5jDQppbmRleCBlMzE0MGE2ZTAwLi4yYmUyMDhiOTliIDEwMDY0NA0K
LS0tIGEvdG9vbHMvbGlicy9saWdodC9saWJ4bF9hcm0uYw0KKysrIGIvdG9vbHMvbGlicy9saWdo
dC9saWJ4bF9hcm0uYw0KQEAgLTEwMSw2ICsxMDEsMTIgQEAgaW50IGxpYnhsX19hcmNoX2RvbWFp
bl9wcmVwYXJlX2NvbmZpZyhsaWJ4bF9fZ2MgKmdjLA0KICAgICAgICAgcmV0dXJuIEVSUk9SX0ZB
SUw7DQogICAgIH0NCiANCisgICAgLyogRW5hYmxlIFZQQ0kgc3VwcG9ydC4gKi8NCisgICAgaWYg
KGRfY29uZmlnLT5udW1fcGNpZGV2cykgew0KKyAgICAgICAgY29uZmlnLT5mbGFncyB8PSBYRU5f
RE9NQ1RMX0NERl92cGNpOw0KKyAgICAgICAgbGlieGxfZGVmYm9vbF9zZXQoJmRfY29uZmlnLT5i
X2luZm8uYXJjaF9hcm0udnBjaSwgdHJ1ZSk7DQorICAgIH0NCisNCiAgICAgcmV0dXJuIDA7DQog
fQ0KDQo+ICBXZSB0cnkNCj4gdG8gbWFrZSB0aGUgbGlieGwgQVBJICJkbyB0aGUgcmlnaHQgdGhp
bmciIGJ5IGRlZmF1bHQuICBJbiB0aGlzIGNhc2UgSQ0KPiB0aGluayB0aGF0IG1lYW5zIHRvIGVu
YWJsZSBWUENJIChpKSBvbiBwbGF0Zm9ybXMgd2hlcmUgaXQncyBhdmFpbGFibGUNCj4gKGlpKSBp
ZiB0aGUgZ3Vlc3QgaGFzIFBDSSBwYXNzdGhyb3VnaCBkZXZpY2VzLiAgSXMgdGhhdCByaWdodCA/
DQoNClllcyB5b3UgYXJlIHJpZ2h0IFZQQ0kgd2lsbCBiZSBlbmFibGVkIGZvciBndWVzdCB3aGVu
IGd1ZXN0IGhhcyBQQ0kgcGFzc3Rocm91Z2ggZGV2aWNlIA0KYXNzaWduZWQgYW5kIFZQQ0kgc3Vw
cG9ydCBpcyBhdmFpbGFibGUuICANCj4gDQo+IFNvcnJ5IHRvIGFzayB0aGVzZSBxdWVzdGlvbiBu
b3csIGFuZCBwbGVhc2UgZm9yZ2l2ZSBteSBpZ25vcmFuY2U6DQo+IA0KPiBJcyBWUENJIGluaGVy
ZW50bHkgYW4gQVJNLXNwZWNpZmljIEFCSSBvciBwcm90b2NvbCA/DQoNCkFzIG9mIG5vdyBWUENJ
IGZvciBET01VIGd1ZXN0cyBpcyBvbmx5IGltcGxlbWVudGVkICBmb3IgQVJNLg0KIA0KPiAgV2hl
biBtaWdodCBhbg0KPiBhZG1pbiB3YW50IHRvIHR1cm4gaXQgb24gZXhwbGljaXRseSA/DQoNCkl0
IHdpbGwgYmUgZW5hYmxlZCBkeW5hbWljYWxseSB3aGVuIGFkbWluIGFzc2lnbiBhbnkgUENJIGRl
dmljZSB0byBndWVzdC4NCg0KPiANCj4gSG93IGRvZXMgdGhpcyBhbGwgcmVsYXRlIHRvIHRoZSAo
bm9uLWFyY2gtc3BlY2lmaWMpICJwYXNzdGhyb3VnaCINCj4gb3B0aW9uID8NCg0KVlBDSSB3aWxs
IGJlIGVuYWJsZWQgb25seSB3aGVuIHRoZXJlIGlzIGFueSBQQ0kgZGV2aWNlIGFzc2lnbmVkIHRv
IGd1ZXN0IHRoZXJlZm9yZSBJIHVzZWQgDQoiZF9jb25maWctPm51bV9wY2lkZXZz4oCdIHRvIGVu
YWJsZSBWUENJLg0KDQpSZWdhcmRzLA0KUmFodWwNCg0KPiANCj4gSWFuLg0KDQo=


From xen-devel-bounces@lists.xenproject.org Wed Oct 06 17:40:57 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Oct 2021 17:40:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.202981.358007 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYAuT-00043C-6t; Wed, 06 Oct 2021 17:40:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 202981.358007; Wed, 06 Oct 2021 17:40:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYAuT-000435-3m; Wed, 06 Oct 2021 17:40:53 +0000
Received: by outflank-mailman (input) for mailman id 202981;
 Wed, 06 Oct 2021 17:40:52 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=13oh=O2=arm.com=rahul.singh@srs-us1.protection.inumbo.net>)
 id 1mYAuS-00042x-Az
 for xen-devel@lists.xenproject.org; Wed, 06 Oct 2021 17:40:52 +0000
Received: from foss.arm.com (unknown [217.140.110.172])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTP
 id 32e07ecb-0541-423f-a8a6-52ffe5aae1f2;
 Wed, 06 Oct 2021 17:40:50 +0000 (UTC)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id CBBCD6D;
 Wed,  6 Oct 2021 10:40:49 -0700 (PDT)
Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com
 [10.1.199.62])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 95D793F70D;
 Wed,  6 Oct 2021 10:40:47 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 32e07ecb-0541-423f-a8a6-52ffe5aae1f2
From: Rahul Singh <rahul.singh@arm.com>
To: xen-devel@lists.xenproject.org
Cc: bertrand.marquis@arm.com,
	rahul.singh@arm.com,
	Andre.Przywara@arm.com,
	Ian Jackson <iwj@xenproject.org>,
	Wei Liu <wl@xen.org>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	Christian Lindig <christian.lindig@citrix.com>,
	David Scott <dave@recoil.org>,
	Paul Durrant <paul@xen.org>,
	Anthony PERARD <anthony.perard@citrix.com>
Subject: [PATCH v5 00/11] PCI devices passthrough on Arm
Date: Wed,  6 Oct 2021 18:40:26 +0100
Message-Id: <cover.1633540842.git.rahul.singh@arm.com>
X-Mailer: git-send-email 2.25.1
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Hello All,

The purpose of this patch series is to add PCI passthrough support to Xen on
Arm. PCI passthrough support on ARM is the collaboration work between EPAM and
ARM. ARM submitted the partial RFC [1][2] last year to get early feedback. We
tried to fix all the comments and added more features to this patch series.

Working POC with all the features can be found at [3]. Working POC is tested
on x86 so that there will be no regression on x86. Design presentation can be
found at [4]

PCI passthrough support is divided into different patches. This patch series
includes following features: 

Preparatory work to implement the PCI passthrough support for the ARM:
- Refactor MSI code.
- Fixed compilation error when HAS_PCI enabled for ARM.

Discovering PCI Host Bridge in XEN:
- PCI init to initialize the PCI driver.
- PCI host bridge discovery in XEN and map the PCI ECAM configuration space to
  the XEN memory.
- PCI access functions.

Discovering PCI devices:
- To support the PCI passthrough, XEN should be aware of the PCI
  devices.
- Hardware domain is in charge of doing the PCI enumeration and will discover
  the PCI devices and then communicate to the XEN via a hypercall to add the
  PCI devices in XEN.

Enable the existing x86 virtual PCI support for ARM:
- Add VPCI trap handler for each of the PCI device added for config space
  access.
- Register the trap handler in XEN for each of the host bridge PCI ECAM config
  space access.

Emulated PCI device tree node in libxl:
- Create a virtual PCI device tree node in libxl to enable the guest OS to
  discover the virtual PCI during guest boot.

This patch series does not inlcude the following features. Following features
will be send for review in the next version of the patch series once initial
patch series merged.

- VPCI support for DOMU guests (Non-identity mappings guest view of the BARs)
- Virtual bus topology implementation
- IOMMU related changes (generic, SMMUv2, SMMUv3)
- MSI support for DOMU guests.
- Virual ITS support for DOMU guests

[1] https://lists.xenproject.org/archives/html/xen-devel/2020-07/msg01184.html
[2] https://lists.xenproject.org/archives/html/xen-devel/2020-07/threads.html#01184
[3] https://gitlab.com/rahsingh/xen-integration/-/tree/arm_pci_v4_integrate
[4] https://static.sched.com/hosted_files/xen2021/e4/PCI_Device_Passthrough_On_Arm.pdf

Oleksandr Andrushchenko (1):
  xen/arm: Add support for Xilinx ZynqMP PCI host controller

Rahul Singh (10):
  xen/arm: xc_domain_ioport_permission(..) not supported on ARM.
  xen/arm: Add PHYSDEVOP_pci_device_(*add/remove) support for ARM
  xen/arm: Add cmdline boot option "pci-passthrough = <boolean>"
  xen/arm: PCI host bridge discovery within XEN on ARM
  xen/arm: Implement pci access functions
  xen/domctl: Introduce XEN_DOMCTL_CDF_vpci flag
  xen/arm: Enable the existing x86 virtual PCI support for ARM.
  xen/arm: Transitional change to build HAS_VPCI on ARM.
  arm/libxl: Emulated PCI device tree node in libxl
  xen/arm: Add linux,pci-domain property for hwdom if not available.

 docs/misc/xen-command-line.pandoc   |   7 +
 tools/include/libxl.h               |   6 +
 tools/libs/ctrl/xc_domain.c         |   9 +
 tools/libs/light/libxl_arm.c        | 111 +++++++++++
 tools/libs/light/libxl_types.idl    |   1 +
 tools/ocaml/libs/xc/xenctrl.ml      |   1 +
 tools/ocaml/libs/xc/xenctrl.mli     |   1 +
 xen/arch/arm/Makefile               |   1 +
 xen/arch/arm/domain.c               |   8 +-
 xen/arch/arm/domain_build.c         |  19 ++
 xen/arch/arm/pci/Makefile           |   5 +
 xen/arch/arm/pci/ecam.c             |  61 ++++++
 xen/arch/arm/pci/pci-access.c       | 140 ++++++++++++++
 xen/arch/arm/pci/pci-host-common.c  | 287 ++++++++++++++++++++++++++++
 xen/arch/arm/pci/pci-host-generic.c |  48 +++++
 xen/arch/arm/pci/pci-host-zynqmp.c  |  65 +++++++
 xen/arch/arm/pci/pci.c              |  12 ++
 xen/arch/arm/physdev.c              |   6 +-
 xen/arch/arm/vpci.c                 | 102 ++++++++++
 xen/arch/arm/vpci.h                 |  36 ++++
 xen/arch/x86/domain.c               |   6 +
 xen/arch/x86/physdev.c              |  52 +----
 xen/arch/x86/x86_64/physdev.c       |   2 +-
 xen/common/domain.c                 |   2 +-
 xen/drivers/passthrough/pci.c       |  18 ++
 xen/drivers/pci/Makefile            |   1 +
 xen/drivers/pci/physdev.c           |  86 +++++++++
 xen/drivers/vpci/Makefile           |   3 +-
 xen/drivers/vpci/header.c           |   2 +
 xen/include/asm-arm/domain.h        |   7 +-
 xen/include/asm-arm/pci.h           |  85 ++++++++
 xen/include/asm-x86/pci.h           |   8 +-
 xen/include/public/arch-arm.h       |  21 +-
 xen/include/public/domctl.h         |   4 +-
 xen/include/xen/hypercall.h         |   4 +
 xen/include/xen/pci.h               |   2 +
 36 files changed, 1168 insertions(+), 61 deletions(-)
 create mode 100644 xen/arch/arm/pci/ecam.c
 create mode 100644 xen/arch/arm/pci/pci-access.c
 create mode 100644 xen/arch/arm/pci/pci-host-common.c
 create mode 100644 xen/arch/arm/pci/pci-host-generic.c
 create mode 100644 xen/arch/arm/pci/pci-host-zynqmp.c
 create mode 100644 xen/arch/arm/vpci.c
 create mode 100644 xen/arch/arm/vpci.h
 create mode 100644 xen/drivers/pci/physdev.c

-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Wed Oct 06 17:41:39 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Oct 2021 17:41:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.202986.358019 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYAvD-0004aa-Gd; Wed, 06 Oct 2021 17:41:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 202986.358019; Wed, 06 Oct 2021 17:41:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYAvD-0004aT-DE; Wed, 06 Oct 2021 17:41:39 +0000
Received: by outflank-mailman (input) for mailman id 202986;
 Wed, 06 Oct 2021 17:41:38 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=13oh=O2=arm.com=rahul.singh@srs-us1.protection.inumbo.net>)
 id 1mYAvC-0004aL-8C
 for xen-devel@lists.xenproject.org; Wed, 06 Oct 2021 17:41:38 +0000
Received: from foss.arm.com (unknown [217.140.110.172])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTP
 id 99faeec8-4c4f-4431-98da-99c8bc6ba3f5;
 Wed, 06 Oct 2021 17:41:37 +0000 (UTC)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E57026D;
 Wed,  6 Oct 2021 10:41:36 -0700 (PDT)
Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com
 [10.1.199.62])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C9FE63F70D;
 Wed,  6 Oct 2021 10:41:35 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 99faeec8-4c4f-4431-98da-99c8bc6ba3f5
From: Rahul Singh <rahul.singh@arm.com>
To: xen-devel@lists.xenproject.org
Cc: bertrand.marquis@arm.com,
	rahul.singh@arm.com,
	Andre.Przywara@arm.com,
	Ian Jackson <iwj@xenproject.org>,
	Wei Liu <wl@xen.org>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>
Subject: [PATCH v5 01/11] xen/arm: xc_domain_ioport_permission(..) not supported on ARM.
Date: Wed,  6 Oct 2021 18:40:27 +0100
Message-Id: <d292392268df2c74c4103a82ef917072643407a8.1633540842.git.rahul.singh@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <cover.1633540842.git.rahul.singh@arm.com>
References: <cover.1633540842.git.rahul.singh@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

ARM architecture does not implement I/O ports. Ignore this call on ARM
to avoid the overhead of making a hypercall just for Xen to return
-ENOSYS.

Signed-off-by: Rahul Singh <rahul.singh@arm.com>
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>
---
Change in v5: none
Change in v4:
- Added Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>
Change in v3: Added Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
Change in v2:
- Instead of returning success in XEN, ignored the call in xl.
---
---
 tools/libs/ctrl/xc_domain.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/tools/libs/ctrl/xc_domain.c b/tools/libs/ctrl/xc_domain.c
index 23322b70b5..25c95f6596 100644
--- a/tools/libs/ctrl/xc_domain.c
+++ b/tools/libs/ctrl/xc_domain.c
@@ -1348,6 +1348,14 @@ int xc_domain_ioport_permission(xc_interface *xch,
                                 uint32_t nr_ports,
                                 uint32_t allow_access)
 {
+#if defined(__arm__) || defined(__aarch64__)
+    /*
+     * The ARM architecture does not implement I/O ports.
+     * Avoid the overhead of making a hypercall just for Xen to return -ENOSYS.
+     * It is safe to ignore this call on ARM so we just return 0.
+     */
+    return 0;
+#else
     DECLARE_DOMCTL;
 
     domctl.cmd = XEN_DOMCTL_ioport_permission;
@@ -1357,6 +1365,7 @@ int xc_domain_ioport_permission(xc_interface *xch,
     domctl.u.ioport_permission.allow_access = allow_access;
 
     return do_domctl(xch, &domctl);
+#endif
 }
 
 int xc_availheap(xc_interface *xch,
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Wed Oct 06 17:41:48 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Oct 2021 17:41:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.202989.358030 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYAvM-0004wo-PG; Wed, 06 Oct 2021 17:41:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 202989.358030; Wed, 06 Oct 2021 17:41:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYAvM-0004wh-L5; Wed, 06 Oct 2021 17:41:48 +0000
Received: by outflank-mailman (input) for mailman id 202989;
 Wed, 06 Oct 2021 17:41:47 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=13oh=O2=arm.com=rahul.singh@srs-us1.protection.inumbo.net>)
 id 1mYAvL-0004w1-R7
 for xen-devel@lists.xenproject.org; Wed, 06 Oct 2021 17:41:47 +0000
Received: from foss.arm.com (unknown [217.140.110.172])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTP
 id ad59c5ca-26cc-11ec-bf8b-12813bfff9fa;
 Wed, 06 Oct 2021 17:41:46 +0000 (UTC)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 30DD1113E;
 Wed,  6 Oct 2021 10:41:46 -0700 (PDT)
Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com
 [10.1.199.62])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 81D523F70D;
 Wed,  6 Oct 2021 10:41:44 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ad59c5ca-26cc-11ec-bf8b-12813bfff9fa
From: Rahul Singh <rahul.singh@arm.com>
To: xen-devel@lists.xenproject.org
Cc: bertrand.marquis@arm.com,
	rahul.singh@arm.com,
	Andre.Przywara@arm.com,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Ian Jackson <iwj@xenproject.org>,
	Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wl@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>
Subject: [PATCH v5 03/11] xen/arm: Add cmdline boot option "pci-passthrough = <boolean>"
Date: Wed,  6 Oct 2021 18:40:29 +0100
Message-Id: <e7d91ded71816d07f559b98027e5be1ff172dcab.1633540842.git.rahul.singh@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <cover.1633540842.git.rahul.singh@arm.com>
References: <cover.1633540842.git.rahul.singh@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Add cmdline boot option "pci-passthrough = = <boolean>" to enable or
disable the PCI passthrough support on ARM.

Signed-off-by: Rahul Singh <rahul.singh@arm.com>
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>
---
Change in v5: none
Change in v4:
- Fixe minor comments
- Added Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>
- Added Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
Change in v3:
- Remove "define pci_passthrough_enabled (false)"
- Fixed coding style and minor comment
Change in v2:
- Add option in xen-command-line.pandoc
- Change pci option to pci-passthrough
- modify option from custom_param to boolean param
---
---
 docs/misc/xen-command-line.pandoc |  7 +++++++
 xen/arch/arm/pci/pci.c            | 12 ++++++++++++
 xen/drivers/pci/physdev.c         |  6 ++++++
 xen/include/asm-arm/pci.h         | 11 +++++++++++
 xen/include/asm-x86/pci.h         |  6 ++++++
 5 files changed, 42 insertions(+)

diff --git a/docs/misc/xen-command-line.pandoc b/docs/misc/xen-command-line.pandoc
index 5cae4adc58..b1f7978aa4 100644
--- a/docs/misc/xen-command-line.pandoc
+++ b/docs/misc/xen-command-line.pandoc
@@ -1819,6 +1819,13 @@ All numbers specified must be hexadecimal ones.
 
 This option can be specified more than once (up to 8 times at present).
 
+### pci-passthrough (arm)
+> `= <boolean>`
+
+> Default: `false`
+
+Flag to enable or disable support for PCI passthrough
+
 ### pcid (x86)
 > `= <boolean> | xpti=<bool>`
 
diff --git a/xen/arch/arm/pci/pci.c b/xen/arch/arm/pci/pci.c
index e359bab9ea..73540045d1 100644
--- a/xen/arch/arm/pci/pci.c
+++ b/xen/arch/arm/pci/pci.c
@@ -16,6 +16,7 @@
 #include <xen/device_tree.h>
 #include <xen/errno.h>
 #include <xen/init.h>
+#include <xen/param.h>
 #include <xen/pci.h>
 
 /*
@@ -62,8 +63,19 @@ static int __init acpi_pci_init(void)
 }
 #endif
 
+/* By default pci passthrough is disabled. */
+bool __read_mostly pci_passthrough_enabled;
+boolean_param("pci-passthrough", pci_passthrough_enabled);
+
 static int __init pci_init(void)
 {
+    /*
+     * Enable PCI passthrough when has been enabled explicitly
+     * (pci-passthrough=on).
+     */
+    if ( !pci_passthrough_enabled )
+        return 0;
+
     pci_segments_init();
 
     if ( acpi_disabled )
diff --git a/xen/drivers/pci/physdev.c b/xen/drivers/pci/physdev.c
index 4f3e1a96c0..42db3e6d13 100644
--- a/xen/drivers/pci/physdev.c
+++ b/xen/drivers/pci/physdev.c
@@ -18,6 +18,9 @@ ret_t pci_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
         struct pci_dev_info pdev_info;
         nodeid_t node = NUMA_NO_NODE;
 
+        if ( !is_pci_passthrough_enabled() )
+            return -EOPNOTSUPP;
+
         ret = -EFAULT;
         if ( copy_from_guest(&add, arg, 1) != 0 )
             break;
@@ -53,6 +56,9 @@ ret_t pci_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
     case PHYSDEVOP_pci_device_remove: {
         struct physdev_pci_device dev;
 
+        if ( !is_pci_passthrough_enabled() )
+            return -EOPNOTSUPP;
+
         ret = -EFAULT;
         if ( copy_from_guest(&dev, arg, 1) != 0 )
             break;
diff --git a/xen/include/asm-arm/pci.h b/xen/include/asm-arm/pci.h
index 7dd9eb3dba..0cf849e26f 100644
--- a/xen/include/asm-arm/pci.h
+++ b/xen/include/asm-arm/pci.h
@@ -19,14 +19,25 @@
 
 #define pci_to_dev(pcidev) (&(pcidev)->arch.dev)
 
+extern bool_t pci_passthrough_enabled;
+
 /* Arch pci dev struct */
 struct arch_pci_dev {
     struct device dev;
 };
 
+static always_inline bool is_pci_passthrough_enabled(void)
+{
+    return pci_passthrough_enabled;
+}
 #else   /*!CONFIG_HAS_PCI*/
 
 struct arch_pci_dev { };
 
+static always_inline bool is_pci_passthrough_enabled(void)
+{
+    return false;
+}
+
 #endif  /*!CONFIG_HAS_PCI*/
 #endif /* __ARM_PCI_H__ */
diff --git a/xen/include/asm-x86/pci.h b/xen/include/asm-x86/pci.h
index cc05045e9c..e076951032 100644
--- a/xen/include/asm-x86/pci.h
+++ b/xen/include/asm-x86/pci.h
@@ -32,4 +32,10 @@ bool_t pci_ro_mmcfg_decode(unsigned long mfn, unsigned int *seg,
 extern int pci_mmcfg_config_num;
 extern struct acpi_mcfg_allocation *pci_mmcfg_config;
 
+/* Unlike ARM, PCI passthrough is always enabled for x86. */
+static always_inline bool is_pci_passthrough_enabled(void)
+{
+    return true;
+}
+
 #endif /* __X86_PCI_H__ */
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Wed Oct 06 17:41:50 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Oct 2021 17:41:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.202990.358041 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYAvO-0005Ea-8J; Wed, 06 Oct 2021 17:41:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 202990.358041; Wed, 06 Oct 2021 17:41:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYAvO-0005EJ-52; Wed, 06 Oct 2021 17:41:50 +0000
Received: by outflank-mailman (input) for mailman id 202990;
 Wed, 06 Oct 2021 17:41:48 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=13oh=O2=arm.com=rahul.singh@srs-us1.protection.inumbo.net>)
 id 1mYAvM-0004uL-7x
 for xen-devel@lists.xenproject.org; Wed, 06 Oct 2021 17:41:48 +0000
Received: from foss.arm.com (unknown [217.140.110.172])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTP
 id 4f74e1e9-073c-4c84-8491-69c753fda476;
 Wed, 06 Oct 2021 17:41:44 +0000 (UTC)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4CC006D;
 Wed,  6 Oct 2021 10:41:44 -0700 (PDT)
Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com
 [10.1.199.62])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7B54B3F70D;
 Wed,  6 Oct 2021 10:41:42 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4f74e1e9-073c-4c84-8491-69c753fda476
From: Rahul Singh <rahul.singh@arm.com>
To: xen-devel@lists.xenproject.org
Cc: bertrand.marquis@arm.com,
	rahul.singh@arm.com,
	Andre.Przywara@arm.com,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Ian Jackson <iwj@xenproject.org>,
	Jan Beulich <jbeulich@suse.com>,
	Wei Liu <wl@xen.org>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>
Subject: [PATCH v5 02/11] xen/arm: Add PHYSDEVOP_pci_device_(*add/remove) support for ARM
Date: Wed,  6 Oct 2021 18:40:28 +0100
Message-Id: <0dc4423b2e20c1eb40c961b211b18ed041f707b7.1633540842.git.rahul.singh@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <cover.1633540842.git.rahul.singh@arm.com>
References: <cover.1633540842.git.rahul.singh@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Hardware domain is in charge of doing the PCI enumeration and will
discover the PCI devices and then will communicate to XEN via hyper
call PHYSDEVOP_pci_device_add(..) to add the PCI devices in XEN.

Also implement PHYSDEVOP_pci_device_remove(..) to remove the PCI device.

As most of the code for PHYSDEVOP_pci_device_* is the same between x86
and ARM, move the code to a common file to avoid duplication.

There are other PHYSDEVOP_pci_device_* operations to add PCI devices.
Currently implemented PHYSDEVOP_pci_device_remove(..) and
PHYSDEVOP_pci_device_add(..) only as those are minimum required to
support PCI passthrough on ARM.

Signed-off-by: Rahul Singh <rahul.singh@arm.com>
---
Change in v5:
- Move the pci_physdev_op() stub to xen/arch/arm/physdev.c.
Change in v4:
- Move file commom/physdev.c to drivers/pci/physdev.c
- minor comments.
Change in v3: Fixed minor comment.
Change in v2:
- Add support for PHYSDEVOP_pci_device_remove()
- Move code to common code
---
---
 xen/arch/arm/physdev.c        |  6 ++-
 xen/arch/x86/physdev.c        | 52 +----------------------
 xen/arch/x86/x86_64/physdev.c |  2 +-
 xen/drivers/pci/Makefile      |  1 +
 xen/drivers/pci/physdev.c     | 80 +++++++++++++++++++++++++++++++++++
 xen/include/public/arch-arm.h |  4 +-
 xen/include/xen/hypercall.h   |  4 ++
 7 files changed, 96 insertions(+), 53 deletions(-)
 create mode 100644 xen/drivers/pci/physdev.c

diff --git a/xen/arch/arm/physdev.c b/xen/arch/arm/physdev.c
index e91355fe22..f9aa274dda 100644
--- a/xen/arch/arm/physdev.c
+++ b/xen/arch/arm/physdev.c
@@ -8,13 +8,17 @@
 #include <xen/lib.h>
 #include <xen/errno.h>
 #include <xen/sched.h>
-#include <asm/hypercall.h>
+#include <xen/hypercall.h>
 
 
 int do_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
 {
+#ifdef CONFIG_HAS_PCI
+    return pci_physdev_op(cmd, arg);
+#else
     gdprintk(XENLOG_DEBUG, "PHYSDEVOP cmd=%d: not implemented\n", cmd);
     return -ENOSYS;
+#endif
 }
 
 /*
diff --git a/xen/arch/x86/physdev.c b/xen/arch/x86/physdev.c
index 23465bcd00..ea38be8b79 100644
--- a/xen/arch/x86/physdev.c
+++ b/xen/arch/x86/physdev.c
@@ -12,7 +12,7 @@
 #include <asm/io_apic.h>
 #include <asm/msi.h>
 #include <asm/hvm/irq.h>
-#include <asm/hypercall.h>
+#include <xen/hypercall.h>
 #include <public/xen.h>
 #include <public/physdev.h>
 #include <xsm/xsm.h>
@@ -480,54 +480,6 @@ ret_t do_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
         break;
     }
 
-    case PHYSDEVOP_pci_device_add: {
-        struct physdev_pci_device_add add;
-        struct pci_dev_info pdev_info;
-        nodeid_t node;
-
-        ret = -EFAULT;
-        if ( copy_from_guest(&add, arg, 1) != 0 )
-            break;
-
-        pdev_info.is_extfn = !!(add.flags & XEN_PCI_DEV_EXTFN);
-        if ( add.flags & XEN_PCI_DEV_VIRTFN )
-        {
-            pdev_info.is_virtfn = 1;
-            pdev_info.physfn.bus = add.physfn.bus;
-            pdev_info.physfn.devfn = add.physfn.devfn;
-        }
-        else
-            pdev_info.is_virtfn = 0;
-
-        if ( add.flags & XEN_PCI_DEV_PXM )
-        {
-            uint32_t pxm;
-            size_t optarr_off = offsetof(struct physdev_pci_device_add, optarr) /
-                                sizeof(add.optarr[0]);
-
-            if ( copy_from_guest_offset(&pxm, arg, optarr_off, 1) )
-                break;
-
-            node = pxm_to_node(pxm);
-        }
-        else
-            node = NUMA_NO_NODE;
-
-        ret = pci_add_device(add.seg, add.bus, add.devfn, &pdev_info, node);
-        break;
-    }
-
-    case PHYSDEVOP_pci_device_remove: {
-        struct physdev_pci_device dev;
-
-        ret = -EFAULT;
-        if ( copy_from_guest(&dev, arg, 1) != 0 )
-            break;
-
-        ret = pci_remove_device(dev.seg, dev.bus, dev.devfn);
-        break;
-    }
-
     case PHYSDEVOP_prepare_msix:
     case PHYSDEVOP_release_msix: {
         struct physdev_pci_device dev;
@@ -663,7 +615,7 @@ ret_t do_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
     }
 
     default:
-        ret = -ENOSYS;
+        ret = pci_physdev_op(cmd, arg);
         break;
     }
 
diff --git a/xen/arch/x86/x86_64/physdev.c b/xen/arch/x86/x86_64/physdev.c
index 0a50cbd4d8..e3cbd5ebcb 100644
--- a/xen/arch/x86/x86_64/physdev.c
+++ b/xen/arch/x86/x86_64/physdev.c
@@ -9,7 +9,7 @@ EMIT_FILE;
 #include <compat/xen.h>
 #include <compat/event_channel.h>
 #include <compat/physdev.h>
-#include <asm/hypercall.h>
+#include <xen/hypercall.h>
 
 #define do_physdev_op compat_physdev_op
 
diff --git a/xen/drivers/pci/Makefile b/xen/drivers/pci/Makefile
index a98035df4c..972c923db0 100644
--- a/xen/drivers/pci/Makefile
+++ b/xen/drivers/pci/Makefile
@@ -1 +1,2 @@
 obj-y += pci.o
+obj-y += physdev.o
diff --git a/xen/drivers/pci/physdev.c b/xen/drivers/pci/physdev.c
new file mode 100644
index 0000000000..4f3e1a96c0
--- /dev/null
+++ b/xen/drivers/pci/physdev.c
@@ -0,0 +1,80 @@
+
+#include <xen/guest_access.h>
+#include <xen/hypercall.h>
+#include <xen/init.h>
+
+#ifndef COMPAT
+typedef long ret_t;
+#endif
+
+ret_t pci_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
+{
+    ret_t ret;
+
+    switch ( cmd )
+    {
+    case PHYSDEVOP_pci_device_add: {
+        struct physdev_pci_device_add add;
+        struct pci_dev_info pdev_info;
+        nodeid_t node = NUMA_NO_NODE;
+
+        ret = -EFAULT;
+        if ( copy_from_guest(&add, arg, 1) != 0 )
+            break;
+
+        pdev_info.is_extfn = (add.flags & XEN_PCI_DEV_EXTFN);
+        if ( add.flags & XEN_PCI_DEV_VIRTFN )
+        {
+            pdev_info.is_virtfn = true;
+            pdev_info.physfn.bus = add.physfn.bus;
+            pdev_info.physfn.devfn = add.physfn.devfn;
+        }
+        else
+            pdev_info.is_virtfn = false;
+
+#ifdef CONFIG_NUMA
+        if ( add.flags & XEN_PCI_DEV_PXM )
+        {
+            uint32_t pxm;
+            size_t optarr_off = offsetof(struct physdev_pci_device_add, optarr) /
+                                sizeof(add.optarr[0]);
+
+            if ( copy_from_guest_offset(&pxm, arg, optarr_off, 1) )
+                break;
+
+            node = pxm_to_node(pxm);
+        }
+#endif
+
+        ret = pci_add_device(add.seg, add.bus, add.devfn, &pdev_info, node);
+        break;
+    }
+
+    case PHYSDEVOP_pci_device_remove: {
+        struct physdev_pci_device dev;
+
+        ret = -EFAULT;
+        if ( copy_from_guest(&dev, arg, 1) != 0 )
+            break;
+
+        ret = pci_remove_device(dev.seg, dev.bus, dev.devfn);
+        break;
+    }
+
+    default:
+        ret = -ENOSYS;
+        break;
+    }
+
+    return ret;
+}
+
+/*
+ * Local variables:
+ * mode: C
+ * c-file-style: "BSD"
+ * c-basic-offset: 4
+ * tab-width: 4
+ * indent-tabs-mode: nil
+ * End:
+ */
diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h
index 6b5a5f818a..d46c61fca9 100644
--- a/xen/include/public/arch-arm.h
+++ b/xen/include/public/arch-arm.h
@@ -107,7 +107,9 @@
  *   All generic sub-operations
  *
  *  HYPERVISOR_physdev_op
- *   No sub-operations are currenty supported
+ *   Exactly these sub-operations are supported:
+ *   PHYSDEVOP_pci_device_add
+ *   PHYSDEVOP_pci_device_remove
  *
  *  HYPERVISOR_sysctl
  *   All generic sub-operations, with the exception of:
diff --git a/xen/include/xen/hypercall.h b/xen/include/xen/hypercall.h
index 3771487a30..07b10ec230 100644
--- a/xen/include/xen/hypercall.h
+++ b/xen/include/xen/hypercall.h
@@ -45,6 +45,10 @@ extern long
 do_platform_op(
     XEN_GUEST_HANDLE_PARAM(xen_platform_op_t) u_xenpf_op);
 
+extern long
+pci_physdev_op(
+    int cmd, XEN_GUEST_HANDLE_PARAM(void) arg);
+
 /*
  * To allow safe resume of do_memory_op() after preemption, we need to know
  * at what point in the page list to resume. For this purpose I steal the
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Wed Oct 06 17:41:54 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Oct 2021 17:41:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.202991.358052 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYAvS-0005da-K2; Wed, 06 Oct 2021 17:41:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 202991.358052; Wed, 06 Oct 2021 17:41:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYAvS-0005dR-G8; Wed, 06 Oct 2021 17:41:54 +0000
Received: by outflank-mailman (input) for mailman id 202991;
 Wed, 06 Oct 2021 17:41:53 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=13oh=O2=arm.com=rahul.singh@srs-us1.protection.inumbo.net>)
 id 1mYAvR-0004uL-81
 for xen-devel@lists.xenproject.org; Wed, 06 Oct 2021 17:41:53 +0000
Received: from foss.arm.com (unknown [217.140.110.172])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTP
 id 2a44afd7-e9f6-4b7b-a940-2b1c366ad5cb;
 Wed, 06 Oct 2021 17:41:47 +0000 (UTC)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7DB7C6D;
 Wed,  6 Oct 2021 10:41:47 -0700 (PDT)
Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com
 [10.1.199.62])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 6278C3F70D;
 Wed,  6 Oct 2021 10:41:46 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2a44afd7-e9f6-4b7b-a940-2b1c366ad5cb
From: Rahul Singh <rahul.singh@arm.com>
To: xen-devel@lists.xenproject.org
Cc: bertrand.marquis@arm.com,
	rahul.singh@arm.com,
	Andre.Przywara@arm.com,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: [PATCH v5 04/11] xen/arm: PCI host bridge discovery within XEN on ARM
Date: Wed,  6 Oct 2021 18:40:30 +0100
Message-Id: <d30c88d19ad0f88577a5c5858b7c0d8dea0dd013.1633540842.git.rahul.singh@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <cover.1633540842.git.rahul.singh@arm.com>
References: <cover.1633540842.git.rahul.singh@arm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

XEN during boot will read the PCI device tree node “reg” property
and will map the PCI config space to the XEN memory.

As of now only "pci-host-ecam-generic" compatible board is supported.

"linux,pci-domain" device tree property assigns a fixed PCI domain
number to a host bridge, otherwise an unstable (across boots) unique
number will be assigned by Linux. XEN access the PCI devices based on
Segment:Bus:Device:Function. A Segment number in the XEN is same as a
domain number in Linux. Segment number and domain number has to be in
sync to access the correct PCI devices.

XEN will read the “linux,pci-domain” property from the device tree node
and configure the host bridge segment number accordingly. If this
property is not available XEN will allocate the unique segment number
to the host bridge.

Signed-off-by: Rahul Singh <rahul.singh@arm.com>
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
---
Chane in v5:
- Added Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
Chane in v4:
- Move "#include <asm/pci.h>" in "xen/pci.h" after pci_sbdf_t
  sbdf declaration change to separate patch.
- Make gen_pci_dt_match as __initconstrel
- Make pci_host_generic_probe as __init
Change in v3:
- Modify commit msg based on received comments.
- Remove added struct match_table{} struct in struct device{}
- Replace uint32_t sbdf to pci_sbdf_t sbdf to avoid typecast
- Remove bus_start,bus_end and void *sysdata from struct pci_host_bridge{}
- Move "#include <asm/pci.h>" in "xen/pci.h" after pci_sbdf_t sbdf declaration
- Add pci_host_generic_probe() function
Change in v2:
- Add more info in commit msg
- Add callback to parse register index.
- Merge patch pci_ecam_operation into this patch to avoid confusion
- Add new struct in struct device for match table
---
---
 xen/arch/arm/pci/Makefile           |   4 +
 xen/arch/arm/pci/ecam.c             |  61 +++++++
 xen/arch/arm/pci/pci-access.c       |  83 ++++++++++
 xen/arch/arm/pci/pci-host-common.c  | 247 ++++++++++++++++++++++++++++
 xen/arch/arm/pci/pci-host-generic.c |  48 ++++++
 xen/include/asm-arm/pci.h           |  56 +++++++
 6 files changed, 499 insertions(+)
 create mode 100644 xen/arch/arm/pci/ecam.c
 create mode 100644 xen/arch/arm/pci/pci-access.c
 create mode 100644 xen/arch/arm/pci/pci-host-common.c
 create mode 100644 xen/arch/arm/pci/pci-host-generic.c

diff --git a/xen/arch/arm/pci/Makefile b/xen/arch/arm/pci/Makefile
index a98035df4c..6f32fbbe67 100644
--- a/xen/arch/arm/pci/Makefile
+++ b/xen/arch/arm/pci/Makefile
@@ -1 +1,5 @@
 obj-y += pci.o
+obj-y += pci-access.o
+obj-y += pci-host-generic.o
+obj-y += pci-host-common.o
+obj-y += ecam.o
diff --git a/xen/arch/arm/pci/ecam.c b/xen/arch/arm/pci/ecam.c
new file mode 100644
index 0000000000..602d00799c
--- /dev/null
+++ b/xen/arch/arm/pci/ecam.c
@@ -0,0 +1,61 @@
+/*
+ * Based on Linux drivers/pci/ecam.c
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ */
+
+#include <xen/pci.h>
+#include <xen/sched.h>
+
+/*
+ * Function to implement the pci_ops->map_bus method.
+ */
+void __iomem *pci_ecam_map_bus(struct pci_host_bridge *bridge,
+                               pci_sbdf_t sbdf, uint32_t where)
+{
+    const struct pci_config_window *cfg = bridge->cfg;
+    struct pci_ecam_ops *ops =
+        container_of(bridge->ops, struct pci_ecam_ops, pci_ops);
+    unsigned int devfn_shift = ops->bus_shift - 8;
+    void __iomem *base;
+
+    unsigned int busn = PCI_BUS(sbdf.bdf);
+
+    if ( busn < cfg->busn_start || busn > cfg->busn_end )
+        return NULL;
+
+    busn -= cfg->busn_start;
+    base = cfg->win + (busn << ops->bus_shift);
+
+    return base + (PCI_DEVFN2(sbdf.bdf) << devfn_shift) + where;
+}
+
+/* ECAM ops */
+const struct pci_ecam_ops pci_generic_ecam_ops = {
+    .bus_shift  = 20,
+    .pci_ops    = {
+        .map_bus                = pci_ecam_map_bus,
+        .read                   = pci_generic_config_read,
+        .write                  = pci_generic_config_write,
+    }
+};
+
+/*
+ * Local variables:
+ * mode: C
+ * c-file-style: "BSD"
+ * c-basic-offset: 4
+ * tab-width: 4
+ * indent-tabs-mode: nil
+ * End:
+ */
diff --git a/xen/arch/arm/pci/pci-access.c b/xen/arch/arm/pci/pci-access.c
new file mode 100644
index 0000000000..3cd14a4b87
--- /dev/null
+++ b/xen/arch/arm/pci/pci-access.c
@@ -0,0 +1,83 @@
+/*
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ */
+
+#include <xen/pci.h>
+#include <asm/io.h>
+
+#define INVALID_VALUE (~0U)
+
+int pci_generic_config_read(struct pci_host_bridge *bridge, pci_sbdf_t sbdf,
+                            uint32_t reg, uint32_t len, uint32_t *value)
+{
+    void __iomem *addr = bridge->ops->map_bus(bridge, sbdf, reg);
+
+    if ( !addr )
+    {
+        *value = INVALID_VALUE;
+        return -ENODEV;
+    }
+
+    switch ( len )
+    {
+    case 1:
+        *value = readb(addr);
+        break;
+    case 2:
+        *value = readw(addr);
+        break;
+    case 4:
+        *value = readl(addr);
+        break;
+    default:
+        ASSERT_UNREACHABLE();
+    }
+
+    return 0;
+}
+
+int pci_generic_config_write(struct pci_host_bridge *bridge, pci_sbdf_t sbdf,
+                             uint32_t reg, uint32_t len, uint32_t value)
+{
+    void __iomem *addr = bridge->ops->map_bus(bridge, sbdf, reg);
+
+    if ( !addr )
+        return -ENODEV;
+
+    switch ( len )
+    {
+    case 1:
+        writeb(value, addr);
+        break;
+    case 2:
+        writew(value, addr);
+        break;
+    case 4:
+        writel(value, addr);
+        break;
+    default:
+        ASSERT_UNREACHABLE();
+    }
+
+    return 0;
+}
+
+/*
+ * Local variables:
+ * mode: C
+ * c-file-style: "BSD"
+ * c-basic-offset: 4
+ * tab-width: 4
+ * indent-tabs-mode: nil
+ * End:
+ */
diff --git a/xen/arch/arm/pci/pci-host-common.c b/xen/arch/arm/pci/pci-host-common.c
new file mode 100644
index 0000000000..a08e06cea1
--- /dev/null
+++ b/xen/arch/arm/pci/pci-host-common.c
@@ -0,0 +1,247 @@
+/*
+ * Based on Linux drivers/pci/ecam.c
+ * Based on Linux drivers/pci/controller/pci-host-common.c
+ * Based on Linux drivers/pci/controller/pci-host-generic.c
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ */
+
+#include <xen/init.h>
+#include <xen/pci.h>
+#include <xen/rwlock.h>
+#include <xen/sched.h>
+#include <xen/vmap.h>
+
+/*
+ * List for all the pci host bridges.
+ */
+
+static LIST_HEAD(pci_host_bridges);
+
+static atomic_t domain_nr = ATOMIC_INIT(-1);
+
+static inline void __iomem *pci_remap_cfgspace(paddr_t start, size_t len)
+{
+    return ioremap_nocache(start, len);
+}
+
+static void pci_ecam_free(struct pci_config_window *cfg)
+{
+    if ( cfg->win )
+        iounmap(cfg->win);
+
+    xfree(cfg);
+}
+
+static struct pci_config_window * __init
+gen_pci_init(struct dt_device_node *dev, const struct pci_ecam_ops *ops)
+{
+    int err, cfg_reg_idx;
+    u32 bus_range[2];
+    paddr_t addr, size;
+    struct pci_config_window *cfg;
+
+    cfg = xzalloc(struct pci_config_window);
+    if ( !cfg )
+        return NULL;
+
+    err = dt_property_read_u32_array(dev, "bus-range", bus_range,
+                                     ARRAY_SIZE(bus_range));
+    if ( err ) {
+        cfg->busn_start = 0;
+        cfg->busn_end = 0xff;
+        printk(XENLOG_INFO "%s: No bus range found for pci controller\n",
+               dt_node_full_name(dev));
+    } else {
+        cfg->busn_start = bus_range[0];
+        cfg->busn_end = bus_range[1];
+        if ( cfg->busn_end > cfg->busn_start + 0xff )
+            cfg->busn_end = cfg->busn_start + 0xff;
+    }
+
+    if ( ops->cfg_reg_index )
+    {
+        cfg_reg_idx = ops->cfg_reg_index(dev);
+        if ( cfg_reg_idx < 0 )
+            goto err_exit;
+    }
+    else
+        cfg_reg_idx = 0;
+
+    /* Parse our PCI ecam register address */
+    err = dt_device_get_address(dev, cfg_reg_idx, &addr, &size);
+    if ( err )
+        goto err_exit;
+
+    cfg->phys_addr = addr;
+    cfg->size = size;
+
+    /*
+     * On 64-bit systems, we do a single ioremap for the whole config space
+     * since we have enough virtual address range available.  On 32-bit, we
+     * ioremap the config space for each bus individually.
+     * As of now only 64-bit is supported 32-bit is not supported.
+     *
+     * TODO: For 32-bit implement the ioremap/iounmap of config space
+     * dynamically for each read/write call.
+     */
+    cfg->win = pci_remap_cfgspace(cfg->phys_addr, cfg->size);
+    if ( !cfg->win )
+    {
+        printk(XENLOG_ERR "ECAM ioremap failed\n");
+        goto err_exit;
+    }
+    printk("ECAM at [mem 0x%"PRIpaddr"-0x%"PRIpaddr"] for [bus %x-%x] \n",
+            cfg->phys_addr, cfg->phys_addr + cfg->size - 1,
+            cfg->busn_start, cfg->busn_end);
+
+    if ( ops->init )
+    {
+        err = ops->init(cfg);
+        if ( err )
+            goto err_exit;
+    }
+
+    return cfg;
+
+err_exit:
+    pci_ecam_free(cfg);
+
+    return NULL;
+}
+
+struct pci_host_bridge *pci_alloc_host_bridge(void)
+{
+    struct pci_host_bridge *bridge = xzalloc(struct pci_host_bridge);
+
+    if ( !bridge )
+        return NULL;
+
+    INIT_LIST_HEAD(&bridge->node);
+
+    return bridge;
+}
+
+void pci_add_host_bridge(struct pci_host_bridge *bridge)
+{
+    list_add_tail(&bridge->node, &pci_host_bridges);
+}
+
+static int pci_get_new_domain_nr(void)
+{
+    return atomic_inc_return(&domain_nr);
+}
+
+static int pci_bus_find_domain_nr(struct dt_device_node *dev)
+{
+    static int use_dt_domains = -1;
+    int domain;
+
+    domain = dt_get_pci_domain_nr(dev);
+
+    /*
+     * Check DT domain and use_dt_domains values.
+     *
+     * If DT domain property is valid (domain >= 0) and
+     * use_dt_domains != 0, the DT assignment is valid since this means
+     * we have not previously allocated a domain number by using
+     * pci_get_new_domain_nr(); we should also update use_dt_domains to
+     * 1, to indicate that we have just assigned a domain number from
+     * DT.
+     *
+     * If DT domain property value is not valid (ie domain < 0), and we
+     * have not previously assigned a domain number from DT
+     * (use_dt_domains != 1) we should assign a domain number by
+     * using the:
+     *
+     * pci_get_new_domain_nr()
+     *
+     * API and update the use_dt_domains value to keep track of method we
+     * are using to assign domain numbers (use_dt_domains = 0).
+     *
+     * All other combinations imply we have a platform that is trying
+     * to mix domain numbers obtained from DT and pci_get_new_domain_nr(),
+     * which is a recipe for domain mishandling and it is prevented by
+     * invalidating the domain value (domain = -1) and printing a
+     * corresponding error.
+     */
+    if ( domain >= 0 && use_dt_domains )
+    {
+        use_dt_domains = 1;
+    }
+    else if ( domain < 0 && use_dt_domains != 1 )
+    {
+        use_dt_domains = 0;
+        domain = pci_get_new_domain_nr();
+    }
+    else
+    {
+        domain = -1;
+    }
+
+    return domain;
+}
+
+int pci_host_common_probe(struct dt_device_node *dev, const void *data)
+{
+    struct pci_host_bridge *bridge;
+    struct pci_config_window *cfg;
+    struct pci_ecam_ops *ops;
+    int err;
+
+    if ( dt_device_for_passthrough(dev) )
+        return 0;
+
+    ops = (struct pci_ecam_ops *) data;
+
+    bridge = pci_alloc_host_bridge();
+    if ( !bridge )
+        return -ENOMEM;
+
+    /* Parse and map our Configuration Space windows */
+    cfg = gen_pci_init(dev, ops);
+    if ( !cfg )
+    {
+        err = -ENOMEM;
+        goto err_exit;
+    }
+
+    bridge->dt_node = dev;
+    bridge->cfg = cfg;
+    bridge->ops = &ops->pci_ops;
+
+    bridge->segment = pci_bus_find_domain_nr(dev);
+    if ( bridge->segment < 0 )
+    {
+        printk(XENLOG_ERR "Inconsistent \"linux,pci-domain\" property in DT\n");
+        BUG();
+    }
+    pci_add_host_bridge(bridge);
+
+    return 0;
+
+err_exit:
+    xfree(bridge);
+
+    return err;
+}
+
+/*
+ * Local variables:
+ * mode: C
+ * c-file-style: "BSD"
+ * c-basic-offset: 4
+ * tab-width: 4
+ * indent-tabs-mode: nil
+ * End:
+ */
diff --git a/xen/arch/arm/pci/pci-host-generic.c b/xen/arch/arm/pci/pci-host-generic.c
new file mode 100644
index 0000000000..33457fbe96
--- /dev/null
+++ b/xen/arch/arm/pci/pci-host-generic.c
@@ -0,0 +1,48 @@
+/*
+ * Based on Linux drivers/pci/controller/pci-host-common.c
+ * Based on Linux drivers/pci/controller/pci-host-generic.c
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ */
+
+#include <xen/init.h>
+#include <xen/pci.h>
+#include <asm/device.h>
+#include <asm/pci.h>
+
+static const struct dt_device_match __initconstrel gen_pci_dt_match[] =
+{
+    { .compatible = "pci-host-ecam-generic" },
+    { },
+};
+
+static int __init pci_host_generic_probe(struct dt_device_node *dev,
+                                         const void *data)
+{
+    return pci_host_common_probe(dev, &pci_generic_ecam_ops);
+}
+
+DT_DEVICE_START(pci_gen, "PCI HOST GENERIC", DEVICE_PCI)
+.dt_match = gen_pci_dt_match,
+.init = pci_host_generic_probe,
+DT_DEVICE_END
+
+/*
+ * Local variables:
+ * mode: C
+ * c-file-style: "BSD"
+ * c-basic-offset: 4
+ * tab-width: 4
+ * indent-tabs-mode: nil
+ * End:
+ */
diff --git a/xen/include/asm-arm/pci.h b/xen/include/asm-arm/pci.h
index 0cf849e26f..bb7eda6705 100644
--- a/xen/include/asm-arm/pci.h
+++ b/xen/include/asm-arm/pci.h
@@ -26,6 +26,62 @@ struct arch_pci_dev {
     struct device dev;
 };
 
+/*
+ * struct to hold the mappings of a config space window. This
+ * is expected to be used as sysdata for PCI controllers that
+ * use ECAM.
+ */
+struct pci_config_window {
+    paddr_t         phys_addr;
+    paddr_t         size;
+    uint8_t         busn_start;
+    uint8_t         busn_end;
+    void __iomem    *win;
+};
+
+/*
+ * struct to hold pci host bridge information
+ * for a PCI controller.
+ */
+struct pci_host_bridge {
+    struct dt_device_node *dt_node;  /* Pointer to the associated DT node */
+    struct list_head node;           /* Node in list of host bridges */
+    uint16_t segment;                /* Segment number */
+    struct pci_config_window* cfg;   /* Pointer to the bridge config window */
+    struct pci_ops *ops;
+};
+
+struct pci_ops {
+    void __iomem *(*map_bus)(struct pci_host_bridge *bridge, pci_sbdf_t sbdf,
+                             uint32_t offset);
+    int (*read)(struct pci_host_bridge *bridge, pci_sbdf_t sbdf,
+                uint32_t reg, uint32_t len, uint32_t *value);
+    int (*write)(struct pci_host_bridge *bridge, pci_sbdf_t sbdf,
+                 uint32_t reg, uint32_t len, uint32_t value);
+};
+
+/*
+ * struct to hold pci ops and bus shift of the config window
+ * for a PCI controller.
+ */
+struct pci_ecam_ops {
+    unsigned int            bus_shift;
+    struct pci_ops          pci_ops;
+    int (*cfg_reg_index)(struct dt_device_node *dev);
+    int (*init)(struct pci_config_window *);
+};
+
+/* Default ECAM ops */
+extern const struct pci_ecam_ops pci_generic_ecam_ops;
+
+int pci_host_common_probe(struct dt_device_node *dev, const void *data);
+int pci_generic_config_read(struct pci_host_bridge *bridge, pci_sbdf_t sbdf,
+                            uint32_t reg, uint32_t len, uint32_t *value);
+int pci_generic_config_write(struct pci_host_bridge *bridge, pci_sbdf_t sbdf,
+                             uint32_t reg, uint32_t len, uint32_t value);
+void __iomem *pci_ecam_map_bus(struct pci_host_bridge *bridge,
+                               pci_sbdf_t sbdf, uint32_t where);
+
 static always_inline bool is_pci_passthrough_enabled(void)
 {
     return pci_passthrough_enabled;
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Wed Oct 06 17:41:58 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Oct 2021 17:41:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.202992.358062 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYAvV-00061R-UG; Wed, 06 Oct 2021 17:41:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 202992.358062; Wed, 06 Oct 2021 17:41:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYAvV-00061A-Q8; Wed, 06 Oct 2021 17:41:57 +0000
Received: by outflank-mailman (input) for mailman id 202992;
 Wed, 06 Oct 2021 17:41:56 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=13oh=O2=arm.com=rahul.singh@srs-us1.protection.inumbo.net>)
 id 1mYAvU-0005xz-Do
 for xen-devel@lists.xenproject.org; Wed, 06 Oct 2021 17:41:56 +0000
Received: from foss.arm.com (unknown [217.140.110.172])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTP
 id b2c3fd5a-26cc-11ec-bf8b-12813bfff9fa;
 Wed, 06 Oct 2021 17:41:55 +0000 (UTC)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7226E11B3;
 Wed,  6 Oct 2021 10:41:55 -0700 (PDT)
Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com
 [10.1.199.62])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 55E6D3F70D;
 Wed,  6 Oct 2021 10:41:54 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b2c3fd5a-26cc-11ec-bf8b-12813bfff9fa
From: Rahul Singh <rahul.singh@arm.com>
To: xen-devel@lists.xenproject.org
Cc: bertrand.marquis@arm.com,
	rahul.singh@arm.com,
	Andre.Przywara@arm.com,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: [PATCH v5 09/11] xen/arm: Transitional change to build HAS_VPCI on ARM.
Date: Wed,  6 Oct 2021 18:40:35 +0100
Message-Id: <b9653c6247060574cf68e1f780ef1db3dd0c20d3.1633540842.git.rahul.singh@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <cover.1633540842.git.rahul.singh@arm.com>
References: <cover.1633540842.git.rahul.singh@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

This patch will be reverted once we add support for VPCI MSI/MSIX
support on ARM.

Signed-off-by: Rahul Singh <rahul.singh@arm.com>
Acked-by: Stefano Stabellini <sstabellini@kernel.org>
Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>
---
Change in v5: none
Change in v4:
- Added Acked-by: Stefano Stabellini <sstabellini@kernel.org>
- Added Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>
Change in v3: none
Change in v2: Patch introduced in v2
---
---
 xen/drivers/vpci/Makefile | 3 ++-
 xen/drivers/vpci/header.c | 2 ++
 xen/include/asm-arm/pci.h | 8 ++++++++
 3 files changed, 12 insertions(+), 1 deletion(-)

diff --git a/xen/drivers/vpci/Makefile b/xen/drivers/vpci/Makefile
index 55d1bdfda0..1a1413b93e 100644
--- a/xen/drivers/vpci/Makefile
+++ b/xen/drivers/vpci/Makefile
@@ -1 +1,2 @@
-obj-y += vpci.o header.o msi.o msix.o
+obj-y += vpci.o header.o
+obj-$(CONFIG_HAS_PCI_MSI) += msi.o msix.o
diff --git a/xen/drivers/vpci/header.c b/xen/drivers/vpci/header.c
index ba9a036202..f8cd55e7c0 100644
--- a/xen/drivers/vpci/header.c
+++ b/xen/drivers/vpci/header.c
@@ -96,8 +96,10 @@ static void modify_decoding(const struct pci_dev *pdev, uint16_t cmd,
      * FIXME: punching holes after the p2m has been set up might be racy for
      * DomU usage, needs to be revisited.
      */
+#ifdef CONFIG_HAS_PCI_MSI
     if ( map && !rom_only && vpci_make_msix_hole(pdev) )
         return;
+#endif
 
     for ( i = 0; i < ARRAY_SIZE(header->bars); i++ )
     {
diff --git a/xen/include/asm-arm/pci.h b/xen/include/asm-arm/pci.h
index 49c9622902..5532ce3977 100644
--- a/xen/include/asm-arm/pci.h
+++ b/xen/include/asm-arm/pci.h
@@ -26,6 +26,14 @@ struct arch_pci_dev {
     struct device dev;
 };
 
+/* Arch-specific MSI data for vPCI. */
+struct vpci_arch_msi {
+};
+
+/* Arch-specific MSI-X entry data for vPCI. */
+struct vpci_arch_msix_entry {
+};
+
 /*
  * struct to hold the mappings of a config space window. This
  * is expected to be used as sysdata for PCI controllers that
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Wed Oct 06 17:42:00 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Oct 2021 17:42:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.202993.358074 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYAvY-0006Od-Fb; Wed, 06 Oct 2021 17:42:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 202993.358074; Wed, 06 Oct 2021 17:42:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYAvY-0006OT-Bx; Wed, 06 Oct 2021 17:42:00 +0000
Received: by outflank-mailman (input) for mailman id 202993;
 Wed, 06 Oct 2021 17:41:58 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=13oh=O2=arm.com=rahul.singh@srs-us1.protection.inumbo.net>)
 id 1mYAvW-0004uL-8A
 for xen-devel@lists.xenproject.org; Wed, 06 Oct 2021 17:41:58 +0000
Received: from foss.arm.com (unknown [217.140.110.172])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTP
 id f3328121-f096-40b5-8408-5b1a5cd4830e;
 Wed, 06 Oct 2021 17:41:49 +0000 (UTC)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id CD1F5ED1;
 Wed,  6 Oct 2021 10:41:48 -0700 (PDT)
Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com
 [10.1.199.62])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B1ADF3F70D;
 Wed,  6 Oct 2021 10:41:47 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f3328121-f096-40b5-8408-5b1a5cd4830e
From: Rahul Singh <rahul.singh@arm.com>
To: xen-devel@lists.xenproject.org
Cc: bertrand.marquis@arm.com,
	rahul.singh@arm.com,
	Andre.Przywara@arm.com,
	Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: [PATCH v5 05/11] xen/arm: Add support for Xilinx ZynqMP PCI host controller
Date: Wed,  6 Oct 2021 18:40:31 +0100
Message-Id: <104266db7156a4740615c6a5b4e058e7c492c78c.1633540842.git.rahul.singh@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <cover.1633540842.git.rahul.singh@arm.com>
References: <cover.1633540842.git.rahul.singh@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>

Add support for Xilinx ZynqMP PCI host controller to map the PCI config
space to the XEN memory.

Patch helps to understand how the generic infrastructure for PCI
host-bridge discovery will be used for future references.

Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Signed-off-by: Rahul Singh <rahul.singh@arm.com>
Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
---
Change in v5:
- Added Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
Change in v4:
- Add __initconstrel and __init for struct and functions
- Added Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>
Change in v3:
- nwl_cfg_reg_index(..) as static function
- Add support for pci_host_generic_probe()
Change in v2:
- Add more info in commit msg
---
---
 xen/arch/arm/pci/Makefile          |  1 +
 xen/arch/arm/pci/pci-host-zynqmp.c | 65 ++++++++++++++++++++++++++++++
 2 files changed, 66 insertions(+)
 create mode 100644 xen/arch/arm/pci/pci-host-zynqmp.c

diff --git a/xen/arch/arm/pci/Makefile b/xen/arch/arm/pci/Makefile
index 6f32fbbe67..1d045ade01 100644
--- a/xen/arch/arm/pci/Makefile
+++ b/xen/arch/arm/pci/Makefile
@@ -3,3 +3,4 @@ obj-y += pci-access.o
 obj-y += pci-host-generic.o
 obj-y += pci-host-common.o
 obj-y += ecam.o
+obj-y += pci-host-zynqmp.o
diff --git a/xen/arch/arm/pci/pci-host-zynqmp.c b/xen/arch/arm/pci/pci-host-zynqmp.c
new file mode 100644
index 0000000000..61a9807d3d
--- /dev/null
+++ b/xen/arch/arm/pci/pci-host-zynqmp.c
@@ -0,0 +1,65 @@
+/*
+ * Based on Linux drivers/pci/controller/pci-host-common.c
+ * Based on Linux drivers/pci/controller/pci-host-generic.c
+ * Based on xen/arch/arm/pci/pci-host-generic.c
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ */
+
+#include <xen/init.h>
+#include <xen/pci.h>
+#include <asm/device.h>
+#include <asm/pci.h>
+
+static int __init nwl_cfg_reg_index(struct dt_device_node *np)
+{
+    return dt_property_match_string(np, "reg-names", "cfg");
+}
+
+/* ECAM ops */
+const struct pci_ecam_ops nwl_pcie_ops = {
+    .bus_shift  = 20,
+    .cfg_reg_index = nwl_cfg_reg_index,
+    .pci_ops    = {
+        .map_bus                = pci_ecam_map_bus,
+        .read                   = pci_generic_config_read,
+        .write                  = pci_generic_config_write,
+    }
+};
+
+static const struct dt_device_match __initconstrel nwl_pcie_dt_match[] =
+{
+    { .compatible = "xlnx,nwl-pcie-2.11" },
+    { },
+};
+
+static int __init pci_host_generic_probe(struct dt_device_node *dev,
+                                         const void *data)
+{
+    return pci_host_common_probe(dev, &nwl_pcie_ops);
+}
+
+DT_DEVICE_START(pci_gen, "PCI HOST ZYNQMP", DEVICE_PCI)
+.dt_match = nwl_pcie_dt_match,
+.init = pci_host_generic_probe,
+DT_DEVICE_END
+
+/*
+ * Local variables:
+ * mode: C
+ * c-file-style: "BSD"
+ * c-basic-offset: 4
+ * tab-width: 4
+ * indent-tabs-mode: nil
+ * End:
+ */
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Wed Oct 06 17:42:01 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Oct 2021 17:42:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.202994.358079 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYAvY-0006Sc-VH; Wed, 06 Oct 2021 17:42:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 202994.358079; Wed, 06 Oct 2021 17:42:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYAvY-0006SG-M6; Wed, 06 Oct 2021 17:42:00 +0000
Received: by outflank-mailman (input) for mailman id 202994;
 Wed, 06 Oct 2021 17:41:58 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=13oh=O2=arm.com=rahul.singh@srs-us1.protection.inumbo.net>)
 id 1mYAvW-0005xz-Fg
 for xen-devel@lists.xenproject.org; Wed, 06 Oct 2021 17:41:58 +0000
Received: from foss.arm.com (unknown [217.140.110.172])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTP
 id b3c6aa2c-26cc-11ec-bf8b-12813bfff9fa;
 Wed, 06 Oct 2021 17:41:57 +0000 (UTC)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1DD8411D4;
 Wed,  6 Oct 2021 10:41:57 -0700 (PDT)
Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com
 [10.1.199.62])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A6F5D3F70D;
 Wed,  6 Oct 2021 10:41:55 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b3c6aa2c-26cc-11ec-bf8b-12813bfff9fa
From: Rahul Singh <rahul.singh@arm.com>
To: xen-devel@lists.xenproject.org
Cc: bertrand.marquis@arm.com,
	rahul.singh@arm.com,
	Andre.Przywara@arm.com,
	Ian Jackson <iwj@xenproject.org>,
	Wei Liu <wl@xen.org>,
	Anthony PERARD <anthony.perard@citrix.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: [PATCH v5 10/11] arm/libxl: Emulated PCI device tree node in libxl
Date: Wed,  6 Oct 2021 18:40:36 +0100
Message-Id: <b81b5dea800c8fe47071f3dbd20588b1e472fb99.1633540842.git.rahul.singh@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <cover.1633540842.git.rahul.singh@arm.com>
References: <cover.1633540842.git.rahul.singh@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

libxl will create an emulated PCI device tree node in the device tree to
enable the guest OS to discover the virtual PCI during guest boot.
Emulated PCI device tree node will only be created when there is any
device assigned to guest.

A new area has been reserved in the arm guest physical map at
which the VPCI bus is declared in the device tree (reg and ranges
parameters of the node).

Signed-off-by: Rahul Singh <rahul.singh@arm.com>
---
Change in v5:
- Move setting the arch_arm.vpci and XEN_DOMCTL_CDF_vpci to libxl_arm.c
Change in v4:
- Gate code for x86 for setting the XEN_DOMCTL_CDF_vpci for x86.
Change in v3:
- Make GUEST_VPCI_MEM_ADDR address 2MB aligned
Change in v2:
- enable doamin_vpci_init() when XEN_DOMCTL_CDF_vpci is set for domain.
---
---
 tools/include/libxl.h            |   6 ++
 tools/libs/light/libxl_arm.c     | 111 +++++++++++++++++++++++++++++++
 tools/libs/light/libxl_types.idl |   1 +
 xen/include/public/arch-arm.h    |  10 +++
 4 files changed, 128 insertions(+)

diff --git a/tools/include/libxl.h b/tools/include/libxl.h
index b9ba16d698..3362073b21 100644
--- a/tools/include/libxl.h
+++ b/tools/include/libxl.h
@@ -358,6 +358,12 @@
  */
 #define LIBXL_HAVE_BUILDINFO_ARM_VUART 1
 
+/*
+ * LIBXL_HAVE_BUILDINFO_ARM_VPCI indicates that the toolstack supports virtual
+ * PCI for ARM.
+ */
+#define LIBXL_HAVE_BUILDINFO_ARM_VPCI 1
+
 /*
  * LIBXL_HAVE_BUILDINFO_GRANT_LIMITS indicates that libxl_domain_build_info
  * has the max_grant_frames and max_maptrack_frames fields.
diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c
index e3140a6e00..2be208b99b 100644
--- a/tools/libs/light/libxl_arm.c
+++ b/tools/libs/light/libxl_arm.c
@@ -101,6 +101,12 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc,
         return ERROR_FAIL;
     }
 
+    /* Enable VPCI support. */
+    if (d_config->num_pcidevs) {
+        config->flags |= XEN_DOMCTL_CDF_vpci;
+        libxl_defbool_set(&d_config->b_info.arch_arm.vpci, true);
+    }
+
     return 0;
 }
 
@@ -269,6 +275,58 @@ static int fdt_property_regs(libxl__gc *gc, void *fdt,
     return fdt_property(fdt, "reg", regs, sizeof(regs));
 }
 
+static int fdt_property_values(libxl__gc *gc, void *fdt,
+        const char *name, unsigned num_cells, ...)
+{
+    uint32_t prop[num_cells];
+    be32 *cells = &prop[0];
+    int i;
+    va_list ap;
+    uint32_t arg;
+
+    va_start(ap, num_cells);
+    for (i = 0 ; i < num_cells; i++) {
+        arg = va_arg(ap, uint32_t);
+        set_cell(&cells, 1, arg);
+    }
+    va_end(ap);
+
+    return fdt_property(fdt, name, prop, sizeof(prop));
+}
+
+static int fdt_property_vpci_ranges(libxl__gc *gc, void *fdt,
+                                    unsigned addr_cells,
+                                    unsigned size_cells,
+                                    unsigned num_regs, ...)
+{
+    uint32_t regs[num_regs*((addr_cells*2)+size_cells+1)];
+    be32 *cells = &regs[0];
+    int i;
+    va_list ap;
+    uint64_t arg;
+
+    va_start(ap, num_regs);
+    for (i = 0 ; i < num_regs; i++) {
+        /* Set the memory bit field */
+        arg = va_arg(ap, uint32_t);
+        set_cell(&cells, 1, arg);
+
+        /* Set the vpci bus address */
+        arg = addr_cells ? va_arg(ap, uint64_t) : 0;
+        set_cell(&cells, addr_cells , arg);
+
+        /* Set the cpu bus address where vpci address is mapped */
+        set_cell(&cells, addr_cells, arg);
+
+        /* Set the vpci size requested */
+        arg = size_cells ? va_arg(ap, uint64_t) : 0;
+        set_cell(&cells, size_cells, arg);
+    }
+    va_end(ap);
+
+    return fdt_property(fdt, "ranges", regs, sizeof(regs));
+}
+
 static int make_root_properties(libxl__gc *gc,
                                 const libxl_version_info *vers,
                                 void *fdt)
@@ -668,6 +726,53 @@ static int make_vpl011_uart_node(libxl__gc *gc, void *fdt,
     return 0;
 }
 
+static int make_vpci_node(libxl__gc *gc, void *fdt,
+        const struct arch_info *ainfo,
+        struct xc_dom_image *dom)
+{
+    int res;
+    const uint64_t vpci_ecam_base = GUEST_VPCI_ECAM_BASE;
+    const uint64_t vpci_ecam_size = GUEST_VPCI_ECAM_SIZE;
+    const char *name = GCSPRINTF("pcie@%"PRIx64, vpci_ecam_base);
+
+    res = fdt_begin_node(fdt, name);
+    if (res) return res;
+
+    res = fdt_property_compat(gc, fdt, 1, "pci-host-ecam-generic");
+    if (res) return res;
+
+    res = fdt_property_string(fdt, "device_type", "pci");
+    if (res) return res;
+
+    res = fdt_property_regs(gc, fdt, GUEST_ROOT_ADDRESS_CELLS,
+            GUEST_ROOT_SIZE_CELLS, 1, vpci_ecam_base, vpci_ecam_size);
+    if (res) return res;
+
+    res = fdt_property_values(gc, fdt, "bus-range", 2, 0, 255);
+    if (res) return res;
+
+    res = fdt_property_cell(fdt, "#address-cells", 3);
+    if (res) return res;
+
+    res = fdt_property_cell(fdt, "#size-cells", 2);
+    if (res) return res;
+
+    res = fdt_property_string(fdt, "status", "okay");
+    if (res) return res;
+
+    res = fdt_property_vpci_ranges(gc, fdt, GUEST_ROOT_ADDRESS_CELLS,
+        GUEST_ROOT_SIZE_CELLS, 2,
+        GUEST_VPCI_ADDR_TYPE_MEM, GUEST_VPCI_MEM_ADDR, GUEST_VPCI_MEM_SIZE,
+        GUEST_VPCI_ADDR_TYPE_PREFETCH_MEM, GUEST_VPCI_PREFETCH_MEM_ADDR,
+        GUEST_VPCI_PREFETCH_MEM_SIZE);
+    if (res) return res;
+
+    res = fdt_end_node(fdt);
+    if (res) return res;
+
+    return 0;
+}
+
 static const struct arch_info *get_arch_info(libxl__gc *gc,
                                              const struct xc_dom_image *dom)
 {
@@ -971,6 +1076,9 @@ next_resize:
         if (info->tee == LIBXL_TEE_TYPE_OPTEE)
             FDT( make_optee_node(gc, fdt) );
 
+        if (libxl_defbool_val(info->arch_arm.vpci))
+            FDT( make_vpci_node(gc, fdt, ainfo, dom) );
+
         if (pfdt)
             FDT( copy_partial_fdt(gc, fdt, pfdt) );
 
@@ -1189,6 +1297,9 @@ void libxl__arch_domain_build_info_setdefault(libxl__gc *gc,
     /* ACPI is disabled by default */
     libxl_defbool_setdefault(&b_info->acpi, false);
 
+    /* VPCI is disabled by default */
+    libxl_defbool_setdefault(&b_info->arch_arm.vpci, false);
+
     if (b_info->type != LIBXL_DOMAIN_TYPE_PV)
         return;
 
diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_types.idl
index 3f9fff653a..78b1ddf0b8 100644
--- a/tools/libs/light/libxl_types.idl
+++ b/tools/libs/light/libxl_types.idl
@@ -644,6 +644,7 @@ libxl_domain_build_info = Struct("domain_build_info",[
 
     ("arch_arm", Struct(None, [("gic_version", libxl_gic_version),
                                ("vuart", libxl_vuart_type),
+                               ("vpci", libxl_defbool),
                               ])),
     ("arch_x86", Struct(None, [("msr_relaxed", libxl_defbool),
                               ])),
diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h
index 44be337dec..45aac5d18f 100644
--- a/xen/include/public/arch-arm.h
+++ b/xen/include/public/arch-arm.h
@@ -433,6 +433,11 @@ typedef uint64_t xen_callback_t;
 #define GUEST_PL011_BASE    xen_mk_ullong(0x22000000)
 #define GUEST_PL011_SIZE    xen_mk_ullong(0x00001000)
 
+/* Guest PCI-PCIe memory space where config space and BAR will be available.*/
+#define GUEST_VPCI_ADDR_TYPE_MEM            xen_mk_ullong(0x02000000)
+#define GUEST_VPCI_MEM_ADDR                 xen_mk_ullong(0x23000000)
+#define GUEST_VPCI_MEM_SIZE                 xen_mk_ullong(0x10000000)
+
 /*
  * 16MB == 4096 pages reserved for guest to use as a region to map its
  * grant table in.
@@ -448,6 +453,11 @@ typedef uint64_t xen_callback_t;
 #define GUEST_RAM0_BASE   xen_mk_ullong(0x40000000) /* 3GB of low RAM @ 1GB */
 #define GUEST_RAM0_SIZE   xen_mk_ullong(0xc0000000)
 
+/* 4GB @ 4GB Prefetch Memory for VPCI */
+#define GUEST_VPCI_ADDR_TYPE_PREFETCH_MEM   xen_mk_ullong(0x42000000)
+#define GUEST_VPCI_PREFETCH_MEM_ADDR        xen_mk_ullong(0x100000000)
+#define GUEST_VPCI_PREFETCH_MEM_SIZE        xen_mk_ullong(0x100000000)
+
 #define GUEST_RAM1_BASE   xen_mk_ullong(0x0200000000) /* 1016GB of RAM @ 8GB */
 #define GUEST_RAM1_SIZE   xen_mk_ullong(0xfe00000000)
 
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Wed Oct 06 17:42:05 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Oct 2021 17:42:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.202997.358096 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYAvd-0007Fy-7h; Wed, 06 Oct 2021 17:42:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 202997.358096; Wed, 06 Oct 2021 17:42:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYAvd-0007Fk-3E; Wed, 06 Oct 2021 17:42:05 +0000
Received: by outflank-mailman (input) for mailman id 202997;
 Wed, 06 Oct 2021 17:42:03 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=13oh=O2=arm.com=rahul.singh@srs-us1.protection.inumbo.net>)
 id 1mYAvb-0004uL-8Q
 for xen-devel@lists.xenproject.org; Wed, 06 Oct 2021 17:42:03 +0000
Received: from foss.arm.com (unknown [217.140.110.172])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTP
 id 6d7f437f-a58a-45a2-bef9-8925afe7acd5;
 Wed, 06 Oct 2021 17:41:50 +0000 (UTC)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0D4B76D;
 Wed,  6 Oct 2021 10:41:50 -0700 (PDT)
Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com
 [10.1.199.62])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0CB783F70D;
 Wed,  6 Oct 2021 10:41:48 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6d7f437f-a58a-45a2-bef9-8925afe7acd5
From: Rahul Singh <rahul.singh@arm.com>
To: xen-devel@lists.xenproject.org
Cc: bertrand.marquis@arm.com,
	rahul.singh@arm.com,
	Andre.Przywara@arm.com,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: [PATCH v5 06/11] xen/arm: Implement pci access functions
Date: Wed,  6 Oct 2021 18:40:32 +0100
Message-Id: <b3fd5516dca0bc82b018d75bd85e09b6484888d7.1633540842.git.rahul.singh@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <cover.1633540842.git.rahul.singh@arm.com>
References: <cover.1633540842.git.rahul.singh@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Implement generic pci access functions to read/write the configuration
space.

Signed-off-by: Rahul Singh <rahul.singh@arm.com>
Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
---
Change in v5: none
Change in v4:
- Added Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
- Added Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>
Change in v3:
- Remove PRI_pci as not used.
- Replace uint32_t sbdf to pci_sbdf_t sbdf to avoid typecast
Change in v2: Fixed comments
---
---
 xen/arch/arm/pci/pci-access.c      | 57 ++++++++++++++++++++++++++++++
 xen/arch/arm/pci/pci-host-common.c | 19 ++++++++++
 xen/include/asm-arm/pci.h          |  1 +
 3 files changed, 77 insertions(+)

diff --git a/xen/arch/arm/pci/pci-access.c b/xen/arch/arm/pci/pci-access.c
index 3cd14a4b87..9f9aac43d7 100644
--- a/xen/arch/arm/pci/pci-access.c
+++ b/xen/arch/arm/pci/pci-access.c
@@ -16,6 +16,7 @@
 #include <asm/io.h>
 
 #define INVALID_VALUE (~0U)
+#define PCI_ERR_VALUE(len) GENMASK(0, len * 8)
 
 int pci_generic_config_read(struct pci_host_bridge *bridge, pci_sbdf_t sbdf,
                             uint32_t reg, uint32_t len, uint32_t *value)
@@ -72,6 +73,62 @@ int pci_generic_config_write(struct pci_host_bridge *bridge, pci_sbdf_t sbdf,
     return 0;
 }
 
+static uint32_t pci_config_read(pci_sbdf_t sbdf, unsigned int reg,
+                                unsigned int len)
+{
+    uint32_t val = PCI_ERR_VALUE(len);
+    struct pci_host_bridge *bridge = pci_find_host_bridge(sbdf.seg, sbdf.bus);
+
+    if ( unlikely(!bridge) )
+        return val;
+
+    if ( unlikely(!bridge->ops->read) )
+        return val;
+
+    bridge->ops->read(bridge, sbdf, reg, len, &val);
+
+    return val;
+}
+
+static void pci_config_write(pci_sbdf_t sbdf, unsigned int reg,
+                             unsigned int len, uint32_t val)
+{
+    struct pci_host_bridge *bridge = pci_find_host_bridge(sbdf.seg, sbdf.bus);
+
+    if ( unlikely(!bridge) )
+        return;
+
+    if ( unlikely(!bridge->ops->write) )
+        return;
+
+    bridge->ops->write(bridge, sbdf, reg, len, val);
+}
+
+/*
+ * Wrappers for all PCI configuration access functions.
+ */
+
+#define PCI_OP_WRITE(size, type)                            \
+    void pci_conf_write##size(pci_sbdf_t sbdf,              \
+                              unsigned int reg, type val)   \
+{                                                           \
+    pci_config_write(sbdf, reg, size / 8, val);             \
+}
+
+#define PCI_OP_READ(size, type)                             \
+    type pci_conf_read##size(pci_sbdf_t sbdf,               \
+                              unsigned int reg)             \
+{                                                           \
+    return pci_config_read(sbdf, reg, size / 8);            \
+}
+
+PCI_OP_READ(8, uint8_t)
+PCI_OP_READ(16, uint16_t)
+PCI_OP_READ(32, uint32_t)
+PCI_OP_WRITE(8, uint8_t)
+PCI_OP_WRITE(16, uint16_t)
+PCI_OP_WRITE(32, uint32_t)
+
 /*
  * Local variables:
  * mode: C
diff --git a/xen/arch/arm/pci/pci-host-common.c b/xen/arch/arm/pci/pci-host-common.c
index a08e06cea1..c5941b10e9 100644
--- a/xen/arch/arm/pci/pci-host-common.c
+++ b/xen/arch/arm/pci/pci-host-common.c
@@ -236,6 +236,25 @@ err_exit:
     return err;
 }
 
+/*
+ * This function will lookup an hostbridge based on the segment and bus
+ * number.
+ */
+struct pci_host_bridge *pci_find_host_bridge(uint16_t segment, uint8_t bus)
+{
+    struct pci_host_bridge *bridge;
+
+    list_for_each_entry( bridge, &pci_host_bridges, node )
+    {
+        if ( bridge->segment != segment )
+            continue;
+        if ( (bus < bridge->cfg->busn_start) || (bus > bridge->cfg->busn_end) )
+            continue;
+        return bridge;
+    }
+
+    return NULL;
+}
 /*
  * Local variables:
  * mode: C
diff --git a/xen/include/asm-arm/pci.h b/xen/include/asm-arm/pci.h
index bb7eda6705..49c9622902 100644
--- a/xen/include/asm-arm/pci.h
+++ b/xen/include/asm-arm/pci.h
@@ -81,6 +81,7 @@ int pci_generic_config_write(struct pci_host_bridge *bridge, pci_sbdf_t sbdf,
                              uint32_t reg, uint32_t len, uint32_t value);
 void __iomem *pci_ecam_map_bus(struct pci_host_bridge *bridge,
                                pci_sbdf_t sbdf, uint32_t where);
+struct pci_host_bridge *pci_find_host_bridge(uint16_t segment, uint8_t bus);
 
 static always_inline bool is_pci_passthrough_enabled(void)
 {
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Wed Oct 06 17:42:10 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Oct 2021 17:42:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.203001.358107 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYAvi-0007ze-LM; Wed, 06 Oct 2021 17:42:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 203001.358107; Wed, 06 Oct 2021 17:42:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYAvi-0007zK-F8; Wed, 06 Oct 2021 17:42:10 +0000
Received: by outflank-mailman (input) for mailman id 203001;
 Wed, 06 Oct 2021 17:42:08 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=13oh=O2=arm.com=rahul.singh@srs-us1.protection.inumbo.net>)
 id 1mYAvg-0004uL-8e
 for xen-devel@lists.xenproject.org; Wed, 06 Oct 2021 17:42:08 +0000
Received: from foss.arm.com (unknown [217.140.110.172])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTP
 id 61230fa9-7a97-4842-8854-09560a4c78d6;
 Wed, 06 Oct 2021 17:41:52 +0000 (UTC)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 253AA6D;
 Wed,  6 Oct 2021 10:41:52 -0700 (PDT)
Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com
 [10.1.199.62])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 42DBB3F70D;
 Wed,  6 Oct 2021 10:41:50 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 61230fa9-7a97-4842-8854-09560a4c78d6
From: Rahul Singh <rahul.singh@arm.com>
To: xen-devel@lists.xenproject.org
Cc: bertrand.marquis@arm.com,
	rahul.singh@arm.com,
	Andre.Przywara@arm.com,
	Christian Lindig <christian.lindig@citrix.com>,
	David Scott <dave@recoil.org>,
	Ian Jackson <iwj@xenproject.org>,
	Wei Liu <wl@xen.org>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>
Subject: [PATCH v5 07/11] xen/domctl: Introduce XEN_DOMCTL_CDF_vpci flag
Date: Wed,  6 Oct 2021 18:40:33 +0100
Message-Id: <20d5b9d6a0d01a7b90711d28cbefb5701a88b438.1633540842.git.rahul.singh@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <cover.1633540842.git.rahul.singh@arm.com>
References: <cover.1633540842.git.rahul.singh@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Introduce XEN_DOMCTL_CDF_vpci flag to enable VPCI support in XEN.
Reject the use of this new flag for x86 as VPCI is not supported for
DOMU guests for x86.

Signed-off-by: Rahul Singh <rahul.singh@arm.com>
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
Acked-by: Christian Lindig <christian.lindig@citrix.com>
---
Change in v5:
- Added Acked-by: Christian Lindig <christian.lindig@citrix.com>
- Added Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
Change in v4: Added in this version
---
---
 tools/ocaml/libs/xc/xenctrl.ml  | 1 +
 tools/ocaml/libs/xc/xenctrl.mli | 1 +
 xen/arch/arm/domain.c           | 4 ++--
 xen/arch/x86/domain.c           | 6 ++++++
 xen/common/domain.c             | 2 +-
 xen/include/public/domctl.h     | 4 +++-
 6 files changed, 14 insertions(+), 4 deletions(-)

diff --git a/tools/ocaml/libs/xc/xenctrl.ml b/tools/ocaml/libs/xc/xenctrl.ml
index a5588c643f..7ed1c00e47 100644
--- a/tools/ocaml/libs/xc/xenctrl.ml
+++ b/tools/ocaml/libs/xc/xenctrl.ml
@@ -69,6 +69,7 @@ type domain_create_flag =
 	| CDF_XS_DOMAIN
 	| CDF_IOMMU
 	| CDF_NESTED_VIRT
+	| CDF_VPCI
 
 type domain_create_iommu_opts =
 	| IOMMU_NO_SHAREPT
diff --git a/tools/ocaml/libs/xc/xenctrl.mli b/tools/ocaml/libs/xc/xenctrl.mli
index 6e94940a8a..391d4abdf8 100644
--- a/tools/ocaml/libs/xc/xenctrl.mli
+++ b/tools/ocaml/libs/xc/xenctrl.mli
@@ -62,6 +62,7 @@ type domain_create_flag =
   | CDF_XS_DOMAIN
   | CDF_IOMMU
   | CDF_NESTED_VIRT
+  | CDF_VPCI
 
 type domain_create_iommu_opts =
   | IOMMU_NO_SHAREPT
diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
index 19c756ac3d..36138c1b2e 100644
--- a/xen/arch/arm/domain.c
+++ b/xen/arch/arm/domain.c
@@ -622,8 +622,8 @@ int arch_sanitise_domain_config(struct xen_domctl_createdomain *config)
 {
     unsigned int max_vcpus;
 
-    /* HVM and HAP must be set. IOMMU may or may not be */
-    if ( (config->flags & ~XEN_DOMCTL_CDF_iommu) !=
+    /* HVM and HAP must be set. IOMMU and VPCI may or may not be */
+    if ( (config->flags & ~XEN_DOMCTL_CDF_iommu & ~XEN_DOMCTL_CDF_vpci) !=
          (XEN_DOMCTL_CDF_hvm | XEN_DOMCTL_CDF_hap) )
     {
         dprintk(XENLOG_INFO, "Unsupported configuration %#x\n",
diff --git a/xen/arch/x86/domain.c b/xen/arch/x86/domain.c
index ef1812dc14..79c2aa4636 100644
--- a/xen/arch/x86/domain.c
+++ b/xen/arch/x86/domain.c
@@ -662,6 +662,12 @@ int arch_sanitise_domain_config(struct xen_domctl_createdomain *config)
         return -EINVAL;
     }
 
+    if ( config->flags & XEN_DOMCTL_CDF_vpci )
+    {
+        dprintk(XENLOG_INFO, "vPCI cannot be enabled yet\n");
+        return -EINVAL;
+    }
+
     if ( config->vmtrace_size )
     {
         unsigned int size = config->vmtrace_size;
diff --git a/xen/common/domain.c b/xen/common/domain.c
index 6ee5d033b0..40d67ec342 100644
--- a/xen/common/domain.c
+++ b/xen/common/domain.c
@@ -483,7 +483,7 @@ static int sanitise_domain_config(struct xen_domctl_createdomain *config)
          ~(XEN_DOMCTL_CDF_hvm | XEN_DOMCTL_CDF_hap |
            XEN_DOMCTL_CDF_s3_integrity | XEN_DOMCTL_CDF_oos_off |
            XEN_DOMCTL_CDF_xs_domain | XEN_DOMCTL_CDF_iommu |
-           XEN_DOMCTL_CDF_nested_virt) )
+           XEN_DOMCTL_CDF_nested_virt | XEN_DOMCTL_CDF_vpci) )
     {
         dprintk(XENLOG_INFO, "Unknown CDF flags %#x\n", config->flags);
         return -EINVAL;
diff --git a/xen/include/public/domctl.h b/xen/include/public/domctl.h
index 96696e3842..4245da3f45 100644
--- a/xen/include/public/domctl.h
+++ b/xen/include/public/domctl.h
@@ -70,9 +70,11 @@ struct xen_domctl_createdomain {
 #define XEN_DOMCTL_CDF_iommu          (1U<<_XEN_DOMCTL_CDF_iommu)
 #define _XEN_DOMCTL_CDF_nested_virt   6
 #define XEN_DOMCTL_CDF_nested_virt    (1U << _XEN_DOMCTL_CDF_nested_virt)
+#define _XEN_DOMCTL_CDF_vpci          7
+#define XEN_DOMCTL_CDF_vpci           (1U << _XEN_DOMCTL_CDF_vpci)
 
 /* Max XEN_DOMCTL_CDF_* constant.  Used for ABI checking. */
-#define XEN_DOMCTL_CDF_MAX XEN_DOMCTL_CDF_nested_virt
+#define XEN_DOMCTL_CDF_MAX XEN_DOMCTL_CDF_vpci
 
     uint32_t flags;
 
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Wed Oct 06 17:42:19 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Oct 2021 17:42:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.203010.358118 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYAvr-0000Zx-2b; Wed, 06 Oct 2021 17:42:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 203010.358118; Wed, 06 Oct 2021 17:42:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYAvq-0000Yr-Sw; Wed, 06 Oct 2021 17:42:18 +0000
Received: by outflank-mailman (input) for mailman id 203010;
 Wed, 06 Oct 2021 17:42:18 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=13oh=O2=arm.com=rahul.singh@srs-us1.protection.inumbo.net>)
 id 1mYAvq-0004uL-9C
 for xen-devel@lists.xenproject.org; Wed, 06 Oct 2021 17:42:18 +0000
Received: from foss.arm.com (unknown [217.140.110.172])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTP
 id 20cfea3d-d9ac-4001-b17d-76e1b7f6f7fd;
 Wed, 06 Oct 2021 17:41:54 +0000 (UTC)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 22CEE113E;
 Wed,  6 Oct 2021 10:41:54 -0700 (PDT)
Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com
 [10.1.199.62])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5A7D43F70D;
 Wed,  6 Oct 2021 10:41:52 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 20cfea3d-d9ac-4001-b17d-76e1b7f6f7fd
From: Rahul Singh <rahul.singh@arm.com>
To: xen-devel@lists.xenproject.org
Cc: bertrand.marquis@arm.com,
	rahul.singh@arm.com,
	Andre.Przywara@arm.com,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Ian Jackson <iwj@xenproject.org>,
	Jan Beulich <jbeulich@suse.com>,
	Wei Liu <wl@xen.org>,
	Paul Durrant <paul@xen.org>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>
Subject: [PATCH v5 08/11] xen/arm: Enable the existing x86 virtual PCI support for ARM.
Date: Wed,  6 Oct 2021 18:40:34 +0100
Message-Id: <9bdca2cda5d2e83f94dc2423e55714273539760a.1633540842.git.rahul.singh@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <cover.1633540842.git.rahul.singh@arm.com>
References: <cover.1633540842.git.rahul.singh@arm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The existing VPCI support available for X86 is adapted for Arm.
When the device is added to XEN via the hyper call
“PHYSDEVOP_pci_device_add”, VPCI handler for the config space
access is added to the Xen to emulate the PCI devices config space.

A MMIO trap handler for the PCI ECAM space is registered in XEN
so that when guest is trying to access the PCI config space,XEN
will trap the access and emulate read/write using the VPCI and
not the real PCI hardware.

For Dom0less systems scan_pci_devices() would be used to discover the
PCI device in XEN and VPCI handler will be added during XEN boots.

Signed-off-by: Rahul Singh <rahul.singh@arm.com>
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
---
Change in v5:
- Add pci_cleanup_msi(pdev) in cleanup part.
- Added Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
Change in v4:
- Move addition of XEN_DOMCTL_CDF_vpci flag to separate patch
Change in v3:
- Use is_pci_passthrough_enabled() in place of pci_passthrough_enabled variable
- Reject XEN_DOMCTL_CDF_vpci for x86 in arch_sanitise_domain_config()
- Remove IS_ENABLED(CONFIG_HAS_VPCI) from has_vpci()
Change in v2:
- Add new XEN_DOMCTL_CDF_vpci flag
- modify has_vpci() to include XEN_DOMCTL_CDF_vpci
- enable vpci support when pci-passthough option is enabled.
---
---
 xen/arch/arm/Makefile         |   1 +
 xen/arch/arm/domain.c         |   4 ++
 xen/arch/arm/domain_build.c   |   3 +
 xen/arch/arm/vpci.c           | 102 ++++++++++++++++++++++++++++++++++
 xen/arch/arm/vpci.h           |  36 ++++++++++++
 xen/drivers/passthrough/pci.c |  18 ++++++
 xen/include/asm-arm/domain.h  |   7 ++-
 xen/include/asm-x86/pci.h     |   2 -
 xen/include/public/arch-arm.h |   7 +++
 xen/include/xen/pci.h         |   2 +
 10 files changed, 179 insertions(+), 3 deletions(-)
 create mode 100644 xen/arch/arm/vpci.c
 create mode 100644 xen/arch/arm/vpci.h

diff --git a/xen/arch/arm/Makefile b/xen/arch/arm/Makefile
index 44d7cc81fa..fb9c976ea2 100644
--- a/xen/arch/arm/Makefile
+++ b/xen/arch/arm/Makefile
@@ -7,6 +7,7 @@ ifneq ($(CONFIG_NO_PLAT),y)
 obj-y += platforms/
 endif
 obj-$(CONFIG_TEE) += tee/
+obj-$(CONFIG_HAS_VPCI) += vpci.o
 
 obj-$(CONFIG_HAS_ALTERNATIVE) += alternative.o
 obj-y += bootfdt.init.o
diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
index 36138c1b2e..fbb52f78f1 100644
--- a/xen/arch/arm/domain.c
+++ b/xen/arch/arm/domain.c
@@ -39,6 +39,7 @@
 #include <asm/vgic.h>
 #include <asm/vtimer.h>
 
+#include "vpci.h"
 #include "vuart.h"
 
 DEFINE_PER_CPU(struct vcpu *, curr_vcpu);
@@ -767,6 +768,9 @@ int arch_domain_create(struct domain *d,
     if ( is_hardware_domain(d) && (rc = domain_vuart_init(d)) )
         goto fail;
 
+    if ( (rc = domain_vpci_init(d)) != 0 )
+        goto fail;
+
     return 0;
 
 fail:
diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
index c5afbe2e05..f4c89bde8c 100644
--- a/xen/arch/arm/domain_build.c
+++ b/xen/arch/arm/domain_build.c
@@ -3053,6 +3053,9 @@ void __init create_dom0(void)
     if ( iommu_enabled )
         dom0_cfg.flags |= XEN_DOMCTL_CDF_iommu;
 
+    if ( is_pci_passthrough_enabled() )
+        dom0_cfg.flags |= XEN_DOMCTL_CDF_vpci;
+
     dom0 = domain_create(0, &dom0_cfg, true);
     if ( IS_ERR(dom0) || (alloc_dom0_vcpu0(dom0) == NULL) )
         panic("Error creating domain 0\n");
diff --git a/xen/arch/arm/vpci.c b/xen/arch/arm/vpci.c
new file mode 100644
index 0000000000..76c12b9281
--- /dev/null
+++ b/xen/arch/arm/vpci.c
@@ -0,0 +1,102 @@
+/*
+ * xen/arch/arm/vpci.c
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+#include <xen/sched.h>
+
+#include <asm/mmio.h>
+
+#define REGISTER_OFFSET(addr)  ( (addr) & 0x00000fff)
+
+/* Do some sanity checks. */
+static bool vpci_mmio_access_allowed(unsigned int reg, unsigned int len)
+{
+    /* Check access size. */
+    if ( len > 8 )
+        return false;
+
+    /* Check that access is size aligned. */
+    if ( (reg & (len - 1)) )
+        return false;
+
+    return true;
+}
+
+static int vpci_mmio_read(struct vcpu *v, mmio_info_t *info,
+                          register_t *r, void *p)
+{
+    unsigned int reg;
+    pci_sbdf_t sbdf;
+    unsigned long data = ~0UL;
+    unsigned int size = 1U << info->dabt.size;
+
+    sbdf.sbdf = MMCFG_BDF(info->gpa);
+    reg = REGISTER_OFFSET(info->gpa);
+
+    if ( !vpci_mmio_access_allowed(reg, size) )
+        return 0;
+
+    data = vpci_read(sbdf, reg, min(4u, size));
+    if ( size == 8 )
+        data |= (uint64_t)vpci_read(sbdf, reg + 4, 4) << 32;
+
+    *r = data;
+
+    return 1;
+}
+
+static int vpci_mmio_write(struct vcpu *v, mmio_info_t *info,
+                           register_t r, void *p)
+{
+    unsigned int reg;
+    pci_sbdf_t sbdf;
+    unsigned long data = r;
+    unsigned int size = 1U << info->dabt.size;
+
+    sbdf.sbdf = MMCFG_BDF(info->gpa);
+    reg = REGISTER_OFFSET(info->gpa);
+
+    if ( !vpci_mmio_access_allowed(reg, size) )
+        return 0;
+
+    vpci_write(sbdf, reg, min(4u, size), data);
+    if ( size == 8 )
+        vpci_write(sbdf, reg + 4, 4, data >> 32);
+
+    return 1;
+}
+
+static const struct mmio_handler_ops vpci_mmio_handler = {
+    .read  = vpci_mmio_read,
+    .write = vpci_mmio_write,
+};
+
+int domain_vpci_init(struct domain *d)
+{
+    if ( !has_vpci(d) )
+        return 0;
+
+    register_mmio_handler(d, &vpci_mmio_handler,
+                          GUEST_VPCI_ECAM_BASE, GUEST_VPCI_ECAM_SIZE, NULL);
+
+    return 0;
+}
+
+/*
+ * Local variables:
+ * mode: C
+ * c-file-style: "BSD"
+ * c-basic-offset: 4
+ * indent-tabs-mode: nil
+ * End:
+ */
+
diff --git a/xen/arch/arm/vpci.h b/xen/arch/arm/vpci.h
new file mode 100644
index 0000000000..d8a7b0e3e8
--- /dev/null
+++ b/xen/arch/arm/vpci.h
@@ -0,0 +1,36 @@
+/*
+ * xen/arch/arm/vpci.h
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+
+#ifndef __ARCH_ARM_VPCI_H__
+#define __ARCH_ARM_VPCI_H__
+
+#ifdef CONFIG_HAS_VPCI
+int domain_vpci_init(struct domain *d);
+#else
+static inline int domain_vpci_init(struct domain *d)
+{
+    return 0;
+}
+#endif
+
+#endif /* __ARCH_ARM_VPCI_H__ */
+
+/*
+ * Local variables:
+ * mode: C
+ * c-file-style: "BSD"
+ * c-basic-offset: 4
+ * indent-tabs-mode: nil
+ * End:
+ */
diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci.c
index e1b735d9e8..e568457e60 100644
--- a/xen/drivers/passthrough/pci.c
+++ b/xen/drivers/passthrough/pci.c
@@ -766,6 +766,24 @@ int pci_add_device(u16 seg, u8 bus, u8 devfn,
     else
         iommu_enable_device(pdev);
 
+#ifdef CONFIG_ARM
+    /*
+     * On ARM PCI devices discovery will be done by Dom0. Add vpci handler when
+     * Dom0 inform XEN to add the PCI devices in XEN.
+     */
+    ret = vpci_add_handlers(pdev);
+    if ( ret )
+    {
+        printk(XENLOG_ERR "setup of vPCI failed: %d\n", ret);
+        pci_cleanup_msi(pdev);
+        ret = iommu_remove_device(pdev);
+        if ( pdev->domain )
+            list_del(&pdev->domain_list);
+        free_pdev(pseg, pdev);
+        goto out;
+    }
+#endif
+
     pci_enable_acs(pdev);
 
 out:
diff --git a/xen/include/asm-arm/domain.h b/xen/include/asm-arm/domain.h
index c9277b5c6d..91d614b37e 100644
--- a/xen/include/asm-arm/domain.h
+++ b/xen/include/asm-arm/domain.h
@@ -2,6 +2,7 @@
 #define __ASM_DOMAIN_H__
 
 #include <xen/cache.h>
+#include <xen/nospec.h>
 #include <xen/timer.h>
 #include <asm/page.h>
 #include <asm/p2m.h>
@@ -262,7 +263,11 @@ static inline void arch_vcpu_block(struct vcpu *v) {}
 
 #define arch_vm_assist_valid_mask(d) (1UL << VMASST_TYPE_runstate_update_flag)
 
-#define has_vpci(d)    ({ (void)(d); false; })
+/*
+ * For X86 VPCI is enabled and tested for PVH DOM0 only but
+ * for ARM we enable support VPCI for guest domain also.
+ */
+#define has_vpci(d) evaluate_nospec((d)->options & XEN_DOMCTL_CDF_vpci)
 
 #endif /* __ASM_DOMAIN_H__ */
 
diff --git a/xen/include/asm-x86/pci.h b/xen/include/asm-x86/pci.h
index e076951032..c4a4fdcbc2 100644
--- a/xen/include/asm-x86/pci.h
+++ b/xen/include/asm-x86/pci.h
@@ -6,8 +6,6 @@
 #define CF8_ADDR_HI(cf8) (  ((cf8) & 0x0f000000) >> 16)
 #define CF8_ENABLED(cf8) (!!((cf8) & 0x80000000))
 
-#define MMCFG_BDF(addr)  ( ((addr) & 0x0ffff000) >> 12)
-
 #define IS_SNB_GFX(id) (id == 0x01068086 || id == 0x01168086 \
                         || id == 0x01268086 || id == 0x01028086 \
                         || id == 0x01128086 || id == 0x01228086 \
diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h
index d46c61fca9..44be337dec 100644
--- a/xen/include/public/arch-arm.h
+++ b/xen/include/public/arch-arm.h
@@ -418,6 +418,13 @@ typedef uint64_t xen_callback_t;
 #define GUEST_GICV3_GICR0_BASE     xen_mk_ullong(0x03020000) /* vCPU0..127 */
 #define GUEST_GICV3_GICR0_SIZE     xen_mk_ullong(0x01000000)
 
+/*
+ * 256 MB is reserved for VPCI configuration space based on calculation
+ * 256 buses × 32 devices × 8 functions × 4 KB = 256 MB
+ */
+#define GUEST_VPCI_ECAM_BASE    xen_mk_ullong(0x10000000)
+#define GUEST_VPCI_ECAM_SIZE    xen_mk_ullong(0x10000000)
+
 /* ACPI tables physical address */
 #define GUEST_ACPI_BASE xen_mk_ullong(0x20000000)
 #define GUEST_ACPI_SIZE xen_mk_ullong(0x02000000)
diff --git a/xen/include/xen/pci.h b/xen/include/xen/pci.h
index 70ac25345c..43b8a08170 100644
--- a/xen/include/xen/pci.h
+++ b/xen/include/xen/pci.h
@@ -40,6 +40,8 @@
 #define PCI_SBDF3(s,b,df) \
     ((pci_sbdf_t){ .sbdf = (((s) & 0xffff) << 16) | PCI_BDF2(b, df) })
 
+#define MMCFG_BDF(addr)  (((addr) & 0x0ffff000) >> 12)
+
 typedef union {
     uint32_t sbdf;
     struct {
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Wed Oct 06 17:42:30 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Oct 2021 17:42:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.203019.358129 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYAw1-0001Vo-Go; Wed, 06 Oct 2021 17:42:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 203019.358129; Wed, 06 Oct 2021 17:42:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYAw1-0001Vg-D6; Wed, 06 Oct 2021 17:42:29 +0000
Received: by outflank-mailman (input) for mailman id 203019;
 Wed, 06 Oct 2021 17:42:28 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=13oh=O2=arm.com=rahul.singh@srs-us1.protection.inumbo.net>)
 id 1mYAw0-0004uL-9M
 for xen-devel@lists.xenproject.org; Wed, 06 Oct 2021 17:42:28 +0000
Received: from foss.arm.com (unknown [217.140.110.172])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTP
 id e47cf43d-5ce7-423c-bf74-968a84f4339a;
 Wed, 06 Oct 2021 17:41:58 +0000 (UTC)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5596211B3;
 Wed,  6 Oct 2021 10:41:58 -0700 (PDT)
Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com
 [10.1.199.62])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5107A3F70D;
 Wed,  6 Oct 2021 10:41:57 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e47cf43d-5ce7-423c-bf74-968a84f4339a
From: Rahul Singh <rahul.singh@arm.com>
To: xen-devel@lists.xenproject.org
Cc: bertrand.marquis@arm.com,
	rahul.singh@arm.com,
	Andre.Przywara@arm.com,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: [PATCH v5 11/11] xen/arm: Add linux,pci-domain property for hwdom if not available.
Date: Wed,  6 Oct 2021 18:40:37 +0100
Message-Id: <dcf40709a3397c07c769a4fd0e55bbe3557730ec.1633540842.git.rahul.singh@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <cover.1633540842.git.rahul.singh@arm.com>
References: <cover.1633540842.git.rahul.singh@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

If the property is not present in the device tree node for host bridge,
XEN while creating the dtb for hwdom will create this property and
assigns the already allocated segment to the host bridge
so that XEN and linux will have the same segment for the host bridges.

Signed-off-by: Rahul Singh <rahul.singh@arm.com>
Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
---
Change in v5: none
Change in v4:
- Added Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
- Added Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>
Change in v3:
- Use is_pci_passthrough_enabled()
Change in v2:
- Add linux,pci-domain only when pci-passthrough command line option is enabeld
---
---
 xen/arch/arm/domain_build.c        | 16 ++++++++++++++++
 xen/arch/arm/pci/pci-host-common.c | 21 +++++++++++++++++++++
 xen/include/asm-arm/pci.h          |  9 +++++++++
 3 files changed, 46 insertions(+)

diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
index f4c89bde8c..8739e3285e 100644
--- a/xen/arch/arm/domain_build.c
+++ b/xen/arch/arm/domain_build.c
@@ -747,6 +747,22 @@ static int __init write_properties(struct domain *d, struct kernel_info *kinfo,
             return res;
     }
 
+    if ( is_pci_passthrough_enabled() && dt_device_type_is_equal(node, "pci") )
+    {
+        if ( !dt_find_property(node, "linux,pci-domain", NULL) )
+        {
+            uint16_t segment;
+
+            res = pci_get_host_bridge_segment(node, &segment);
+            if ( res < 0 )
+                return res;
+
+            res = fdt_property_cell(kinfo->fdt, "linux,pci-domain", segment);
+            if ( res )
+                return res;
+        }
+    }
+
     /*
      * Override the property "status" to disable the device when it's
      * marked for passthrough.
diff --git a/xen/arch/arm/pci/pci-host-common.c b/xen/arch/arm/pci/pci-host-common.c
index c5941b10e9..593beeb48c 100644
--- a/xen/arch/arm/pci/pci-host-common.c
+++ b/xen/arch/arm/pci/pci-host-common.c
@@ -255,6 +255,27 @@ struct pci_host_bridge *pci_find_host_bridge(uint16_t segment, uint8_t bus)
 
     return NULL;
 }
+
+/*
+ * This function will lookup an hostbridge based on config space address.
+ */
+int pci_get_host_bridge_segment(const struct dt_device_node *node,
+                                uint16_t *segment)
+{
+    struct pci_host_bridge *bridge;
+
+    list_for_each_entry( bridge, &pci_host_bridges, node )
+    {
+        if ( bridge->dt_node != node )
+            continue;
+
+        *segment = bridge->segment;
+        return 0;
+    }
+
+    return -EINVAL;
+}
+
 /*
  * Local variables:
  * mode: C
diff --git a/xen/include/asm-arm/pci.h b/xen/include/asm-arm/pci.h
index 5532ce3977..7cb2e2f1ed 100644
--- a/xen/include/asm-arm/pci.h
+++ b/xen/include/asm-arm/pci.h
@@ -90,6 +90,8 @@ int pci_generic_config_write(struct pci_host_bridge *bridge, pci_sbdf_t sbdf,
 void __iomem *pci_ecam_map_bus(struct pci_host_bridge *bridge,
                                pci_sbdf_t sbdf, uint32_t where);
 struct pci_host_bridge *pci_find_host_bridge(uint16_t segment, uint8_t bus);
+int pci_get_host_bridge_segment(const struct dt_device_node *node,
+                                uint16_t *segment);
 
 static always_inline bool is_pci_passthrough_enabled(void)
 {
@@ -104,5 +106,12 @@ static always_inline bool is_pci_passthrough_enabled(void)
     return false;
 }
 
+static inline int pci_get_host_bridge_segment(const struct dt_device_node *node,
+                                              uint16_t *segment)
+{
+    ASSERT_UNREACHABLE();
+    return -EINVAL;
+}
+
 #endif  /*!CONFIG_HAS_PCI*/
 #endif /* __ARM_PCI_H__ */
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Wed Oct 06 17:53:41 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Oct 2021 17:53:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.203086.358142 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYB6d-0003wO-H4; Wed, 06 Oct 2021 17:53:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 203086.358142; Wed, 06 Oct 2021 17:53:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYB6d-0003wH-E4; Wed, 06 Oct 2021 17:53:27 +0000
Received: by outflank-mailman (input) for mailman id 203086;
 Wed, 06 Oct 2021 17:53:25 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mYB6b-0003wB-FU
 for xen-devel@lists.xenproject.org; Wed, 06 Oct 2021 17:53:25 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mYB6a-0000eK-06; Wed, 06 Oct 2021 17:53:24 +0000
Received: from [92.174.63.74] (helo=[192.168.1.232])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mYB6Z-0001vV-OU; Wed, 06 Oct 2021 17:53:23 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=4h7p77+ErMgeMDTxObzjnh0L8kKQ4DK5oHqkmJ48N40=; b=ZLP+ruFj0NZA+F4/Kuc5ImBlYU
	j2ndxSd0ry7SA3Qv7fMqcn5KflpaEqgMFItUAlNk+EkRwG31/oAaZjpYdflcTXocLI12kozPLJc5H
	aDBdcuKJn7ENfPVUAwAJ2+eBygbQqrlEfaAsHE97j0KEpqNqhvVBL8+V4B2s3n0UP+zs=;
Message-ID: <f602b716-63b9-a3d2-237b-2048f8fabbcf@xen.org>
Date: Wed, 6 Oct 2021 19:53:19 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.1.2
Subject: Re: [PATCH v4 13/14] arm/libxl: Emulated PCI device tree node in
 libxl
To: Rahul Singh <Rahul.Singh@arm.com>, Ian Jackson <iwj@xenproject.org>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 xen-devel <xen-devel@lists.xenproject.org>,
 Bertrand Marquis <Bertrand.Marquis@arm.com>,
 Andre Przywara <Andre.Przywara@arm.com>, Wei Liu <wl@xen.org>,
 Anthony PERARD <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <cover.1633340795.git.rahul.singh@arm.com>
 <3ad42008f534671ae7f5b25da91253ce7cd4a3e9.1633340795.git.rahul.singh@arm.com>
 <alpine.DEB.2.21.2110041714410.3209@sstabellini-ThinkPad-T480s>
 <11F169C6-39A4-40F3-8E75-39B8C2CCF022@arm.com>
 <alpine.DEB.2.21.2110051421520.3209@sstabellini-ThinkPad-T480s>
 <8B848F95-977F-4DF4-B315-CFEA610BC1C3@arm.com>
 <24925.33634.554859.2131@mariner.uk.xensource.com>
 <BFC5AD62-3DA7-498F-8B6E-AB4C8CAA9731@arm.com>
 <24925.35194.369692.94259@mariner.uk.xensource.com>
 <5ADA6C46-A69D-459F-868C-DA579FEC36E2@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <5ADA6C46-A69D-459F-868C-DA579FEC36E2@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi Rahul,

On 06/10/2021 19:34, Rahul Singh wrote:
>> On 6 Oct 2021, at 12:33 pm, Ian Jackson <iwj@xenproject.org> wrote:
>>
>> Rahul Singh writes ("Re: [PATCH v4 13/14] arm/libxl: Emulated PCI device tree node in libxl"):
>>> Hi Ian	
>>>> What is wrong with putting it in
>>>> libxl__arch_domain_build_info_setdefault
>>>> which I think exists precisely for this kind of thing ?
>>>
>>> As we have to set the arch_arm.vpci to false for x86 and ARM I
>>> thought it is right to move the code to common code to avoid
>>> duplication.
>>>
>>> Are you suggesting to put "
>>> libxl_defbool_setdefault(&b_info->arch_arm.vpci, false)ïżœin
>>> libxl__arch_domain_build_info_setdefault() for x86 and ARM
>>> differently.
>>
>> I've gone back and reread the whole thread, which I probably should
>> have done to start with....
>>
>> So:
>>
>>>>> #if defined(__arm__) || defined(__aarch64__)
>>>>>    /*
>>>>>     * Enable VPCI support for ARM. VPCI support for DOMU guests is not
>>>>>     * supported for x86.
>>>>>     */
>>>>>    if (d_config->num_pcidevs)
>>>>>      libxl_defbool_set(&b_info->arch_arm.vpci, true);
>>>>> #endif
>>
>> I think this logic probably ought to be in libxl, not in xl.
> 
> I will move the code to "libxl_arm.c"to avoid #ifdef in common code and also  to avoid setting the vpci for x86
> 
> diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c
> index e3140a6e00..2be208b99b 100644
> --- a/tools/libs/light/libxl_arm.c
> +++ b/tools/libs/light/libxl_arm.c
> @@ -101,6 +101,12 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc,
>           return ERROR_FAIL;
>       }
>   
> +    /* Enable VPCI support. */
> +    if (d_config->num_pcidevs) {
> +        config->flags |= XEN_DOMCTL_CDF_vpci;
> +        libxl_defbool_set(&d_config->b_info.arch_arm.vpci, true);
> +    }
> +
>       return 0;
>   }
> 
>>   We try
>> to make the libxl API "do the right thing" by default.  In this case I
>> think that means to enable VPCI (i) on platforms where it's available
>> (ii) if the guest has PCI passthrough devices.  Is that right ?
> 
> Yes you are right VPCI will be enabled for guest when guest has PCI passthrough device
> assigned and VPCI support is available.
>>
>> Sorry to ask these question now, and please forgive my ignorance:
>>
>> Is VPCI inherently an ARM-specific ABI or protocol ?
> 
> As of now VPCI for DOMU guests is only implemented  for ARM.

We need to differentiate between what it is currently implemented and 
how it can be used in the future.

In particular, the layout of b_info is exposed to external toolstack 
(e.g. libvirt). So we can't easily remove an option. In other word, if 
we end up to need it for an other arch then we will have to keep some 
compat code.

In this case, I think this option is not arm specific. So the field 
ought to be outside of arch_arm.

>   
>>   When might an
>> admin want to turn it on explicitly ?
> 
> It will be enabled dynamically when admin assign any PCI device to guest.
> 
>>
>> How does this all relate to the (non-arch-specific) "passthrough"
>> option ?
> 
> VPCI will be enabled only when there is any PCI device assigned to guest therefore I used
> "d_config->num_pcidevs” to enable VPCI.

Ok. So we don't expect 'xl' or another toolstack to effectively touch 
the field for the time being. Is that correct?

If so, then I think this option should be hidden from external toolstack 
until we see a use.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Oct 06 18:01:29 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Oct 2021 18:01:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.203095.358154 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYBEK-0005Vi-Br; Wed, 06 Oct 2021 18:01:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 203095.358154; Wed, 06 Oct 2021 18:01:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYBEK-0005Vb-8v; Wed, 06 Oct 2021 18:01:24 +0000
Received: by outflank-mailman (input) for mailman id 203095;
 Wed, 06 Oct 2021 18:01:23 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mYBEJ-0005VV-5c
 for xen-devel@lists.xenproject.org; Wed, 06 Oct 2021 18:01:23 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mYBEI-0000rK-19; Wed, 06 Oct 2021 18:01:22 +0000
Received: from [92.174.63.74] (helo=[192.168.1.232])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mYBEH-0002jE-J3; Wed, 06 Oct 2021 18:01:21 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=MHx/s+wZOzfk6BqqNO2OyRss/FVEruQTbmXK96pzaAk=; b=OpMkMgUhIG1sp4lq1H+d0l2oix
	gJP85WqCo/TkLQcOk+KEBEUN+0k8EsW68JCjpanZkv7hvXNeVlaEnD4eLcmVoZAgw6QNhVV5KgEVj
	45TSxQvqwvGoE/3h+iICYnYf+YApwUHDKggZmuGB/ReJjf2Bb+tN7JIcnqgPShmL7In8=;
Message-ID: <7bdac405-a889-15e1-be19-5876f7253855@xen.org>
Date: Wed, 6 Oct 2021 20:01:15 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.1.2
Subject: Re: [PATCH v5 10/11] arm/libxl: Emulated PCI device tree node in
 libxl
To: Rahul Singh <rahul.singh@arm.com>, xen-devel@lists.xenproject.org
Cc: bertrand.marquis@arm.com, Andre.Przywara@arm.com,
 Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>,
 Anthony PERARD <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <cover.1633540842.git.rahul.singh@arm.com>
 <b81b5dea800c8fe47071f3dbd20588b1e472fb99.1633540842.git.rahul.singh@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <b81b5dea800c8fe47071f3dbd20588b1e472fb99.1633540842.git.rahul.singh@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Rahul,

On 06/10/2021 19:40, Rahul Singh wrote:
> diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_types.idl
> index 3f9fff653a..78b1ddf0b8 100644
> --- a/tools/libs/light/libxl_types.idl
> +++ b/tools/libs/light/libxl_types.idl
> @@ -644,6 +644,7 @@ libxl_domain_build_info = Struct("domain_build_info",[
>   
>       ("arch_arm", Struct(None, [("gic_version", libxl_gic_version),
>                                  ("vuart", libxl_vuart_type),
> +                               ("vpci", libxl_defbool),

I have posted some comments regarding the field in v4. To summarize, 
AFAICT, this option is meant to be only set by libxl but you still let 
the toolstack (e.g. xl, libvirt) to set it.

If you still want to expose to the toolstack, then I think the option 
should be outside of arch_arm. Otherwise, this should be moved in an 
internal structure (Ian, do you have any suggestion?).

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Oct 06 18:11:35 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Oct 2021 18:11:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.203103.358164 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYBO6-00070Z-AW; Wed, 06 Oct 2021 18:11:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 203103.358164; Wed, 06 Oct 2021 18:11:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYBO6-00070S-7g; Wed, 06 Oct 2021 18:11:30 +0000
Received: by outflank-mailman (input) for mailman id 203103;
 Wed, 06 Oct 2021 18:11:29 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mYBO5-00070M-56
 for xen-devel@lists.xenproject.org; Wed, 06 Oct 2021 18:11:29 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mYBO3-00019R-Qt; Wed, 06 Oct 2021 18:11:27 +0000
Received: from [92.174.63.74] (helo=[192.168.1.232])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mYBO3-0003jc-Fa; Wed, 06 Oct 2021 18:11:27 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=xCNrDObPjycS7erXb00FAYZGSsW8E/ULQHOnMGbsdM0=; b=XBc1DdVl1REcWd8wQkiWlNZgaR
	fk3iPcv5RrPVlvwRL3x3Qhp5hziakfm8q+G3BKpUU0wXyeuMLo52WpsB/GfyQ88jkx4y2a2v+dfWb
	qzT6qz9tT/iylLM92chCK1V5TNxvqBuyK3VDqu2g+NMdFE+5ULrpsjEtXVkcObAlk6Jg=;
Message-ID: <bea0e4a3-90fe-79f0-ab4e-44d3b2d93c7f@xen.org>
Date: Wed, 6 Oct 2021 20:11:22 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.1.2
Subject: Re: [PATCH V4 2/3] xen/arm: Add handling of extended regions for Dom0
To: Oleksandr <olekstysh@gmail.com>
Cc: xen-devel@lists.xenproject.org,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Jan Beulich <jbeulich@suse.com>, Stefano Stabellini
 <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <1632955927-27911-1-git-send-email-olekstysh@gmail.com>
 <1632955927-27911-3-git-send-email-olekstysh@gmail.com>
 <8318a7b0-80fa-ccd6-75c5-c3135b82235d@xen.org>
 <20f00d52-76c8-2afe-6544-6f1396e121e9@gmail.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20f00d52-76c8-2afe-6544-6f1396e121e9@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi Oleksandr,

On 04/10/2021 14:08, Oleksandr wrote:
> 
> On 04.10.21 09:59, Julien Grall wrote:
>> Hi Oleksandr,
> 
> Hi Julien

Hi Oleksandr,

> 
> 
>>
>> I saw Stefano committed this patch on Friday. However, I didn't have a 
>> chance go to through a second time and would like to request some 
>> follow-up changes.
> 
> ok, do you prefer the follow-up patch to be pushed separately or within 
> the rest patches of this series (#1 and #3)?  If the former, I will try 
> to push it today to close this question.

I don't mind. My main ask is they are addressed for 4.16.

> 
> 
>>
>>
>> On 30/09/2021 00:52, Oleksandr Tyshchenko wrote:
>>> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>>>
>>> The extended region (safe range) is a region of guest physical
>>> address space which is unused and could be safely used to create
>>> grant/foreign mappings instead of wasting real RAM pages from
>>> the domain memory for establishing these mappings.
>>>
>>> The extended regions are chosen at the domain creation time and
>>> advertised to it via "reg" property under hypervisor node in
>>> the guest device-tree. As region 0 is reserved for grant table
>>> space (always present), the indexes for extended regions are 1...N.
>>> If extended regions could not be allocated for some reason,
>>> Xen doesn't fail and behaves as usual, so only inserts region 0.
>>>
>>> Please note the following limitations:
>>> - The extended region feature is only supported for 64-bit domain
>>>    currently.
>>> - The ACPI case is not covered.
>>>
>>> ***
>>>
>>> As Dom0 is direct mapped domain on Arm (e.g. MFN == GFN)
>>> the algorithm to choose extended regions for it is different
>>> in comparison with the algorithm for non-direct mapped DomU.
>>> What is more, that extended regions should be chosen differently
>>> whether IOMMU is enabled or not.
>>>
>>> Provide RAM not assigned to Dom0 if IOMMU is disabled or memory
>>> holes found in host device-tree if otherwise. Make sure that
>>> extended regions are 2MB-aligned and located within maximum possible
>>> addressable physical memory range. The minimum size of extended
>>> region is 64MB. 
>>
>> You explained below why the 128 limits, but I don't see any 
>> explanation on why 2MB and 64MB.
>>
>> IIRC, 2MB was to potentally allow superpage mapping. I am not entirely 
>> sure for 64MB.
>>
>> Could you add an in-code comment explaining the two limits?
> 
> Yes. There was a discussion at [1]. 64MB was chosen as a reasonable 
> value to deal with between initial 2MB (we might end up having a lot of 
> small ranges which are not quite useful but increase bookkeeping) and 
> suggested 1GB (we might not be able find a suitable regions at all).

Ok. Please document in the code. Note that I don't think this choice 
should be advertised to the OS. This would give us some flexibility to 
change the size in the future (e.g. if we have platform where chunk of 
less than 64MB is beneficial).

>> The code below looks like an open-coding version of 
>> dt_for_each_range(). Can you try to re-use it please? This will help 
>> to reduce the complexity of this function.
> 
> You are right, it makes sense, will definitely reuse. If I was aware of 
> that function before I would safe some time I spent on the investigation 
> how to parse that)

I have only skimmed through the diff below. This looks fine to me. 
Please submit a formal patch.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Oct 06 18:15:29 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Oct 2021 18:15:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.203114.358176 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYBRw-0007fB-Sa; Wed, 06 Oct 2021 18:15:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 203114.358176; Wed, 06 Oct 2021 18:15:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYBRw-0007f4-PF; Wed, 06 Oct 2021 18:15:28 +0000
Received: by outflank-mailman (input) for mailman id 203114;
 Wed, 06 Oct 2021 18:15:27 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=RZr5=O2=gmail.com=olekstysh@srs-us1.protection.inumbo.net>)
 id 1mYBRv-0007ey-7Z
 for xen-devel@lists.xenproject.org; Wed, 06 Oct 2021 18:15:27 +0000
Received: from mail-wr1-x42a.google.com (unknown [2a00:1450:4864:20::42a])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 6de185d7-75f8-4bb7-a08d-daead4cdc0d3;
 Wed, 06 Oct 2021 18:15:25 +0000 (UTC)
Received: by mail-wr1-x42a.google.com with SMTP id s15so11450067wrv.11
 for <xen-devel@lists.xenproject.org>; Wed, 06 Oct 2021 11:15:25 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6de185d7-75f8-4bb7-a08d-daead4cdc0d3
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=In+CPk9Y9hRsGCu4EI/YiOGsZmiwADtJ3T86NdTx2nk=;
        b=GSMTYVd5VZ8fFfYwEiw9pSospUHXDci+OKQ9KLq/Sz5zYRPb1sDIcQRP+D2vMetb/u
         GVwPTnXKrzaXGIAVs3CYFXInRYKwJOal9+wXeMapy+If/0ygBfyYnet5z/ozO/p7ujSG
         B2whru24XPqNXsgaDsM4ON5pUaGNCoTjEA4MgHahx9OSvrub1wkZayRdgA+y9BBU4cEV
         avZPyp/LlOXKzmpTE3yxKuw+JoLeuwVe6++cMNXFGgP77CzasAmU0QODBgG/MQ7nZIz+
         lJ/QqgEhR9T3H+weRoMukY3kyEte7kY4BRGWt/3kMnguCqDpRaVzeD36cStP8UhtcZnA
         0Yrg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=In+CPk9Y9hRsGCu4EI/YiOGsZmiwADtJ3T86NdTx2nk=;
        b=4dhkh2XSZEFCKSHRdMAyQ3pYtxIqyIZ5WfSSgaDa96vO/zSWPNgRogyn9o9tyGd4v9
         DTJ9RbiJXyBbvc2cHaNdDouotiV3QqWpgBET7lf4VYlHP6ff398LI/GIHf8SH+JmCaXx
         jfaPSFuMEHT6jUb6pM1FWTy/MfugeH+Wdy9LDP10LTnd4EhOjf8+3h/6O978hu87QXiN
         TxT8ZKWwDKc5oTFVNW1zfigz4ilGz3mZW4n7LgPwzZKZz8QdDs/jcZkmKkXLa2Tt7CW3
         OHs4po5PT+TdLKPlrtcBiYKuHT5vMiqJEQobVSCbUw6E8KdLT3pN4CuRvyBEv7uyyKIm
         bw9Q==
X-Gm-Message-State: AOAM532ZzgkyCd/6DGYUjSGogkFVahAGVuysOtOiIcWtNN5mDv9Q5ofX
	7h4g9XwT+eE4dj+D2VBiTqrRuwLCgcFPPyMWIqU=
X-Google-Smtp-Source: ABdhPJwyyJ9AiSJwionp2qYKV6mUf2jdnVHRqPXQhaf/5/9tHXh31Q256mUAFonNtEYhWs2ftJpcP/keKmRMS6Kn0nU=
X-Received: by 2002:a5d:4882:: with SMTP id g2mr29905801wrq.399.1633544124993;
 Wed, 06 Oct 2021 11:15:24 -0700 (PDT)
MIME-Version: 1.0
References: <1632955927-27911-1-git-send-email-olekstysh@gmail.com>
 <1632955927-27911-3-git-send-email-olekstysh@gmail.com> <8318a7b0-80fa-ccd6-75c5-c3135b82235d@xen.org>
 <20f00d52-76c8-2afe-6544-6f1396e121e9@gmail.com> <bea0e4a3-90fe-79f0-ab4e-44d3b2d93c7f@xen.org>
In-Reply-To: <bea0e4a3-90fe-79f0-ab4e-44d3b2d93c7f@xen.org>
From: Oleksandr Tyshchenko <olekstysh@gmail.com>
Date: Wed, 6 Oct 2021 21:15:14 +0300
Message-ID: <CAPD2p-mLM-JjfKh6U+A_UTJostXvYDCJ68ac-V3teSeKjmaXTA@mail.gmail.com>
Subject: Re: [PATCH V4 2/3] xen/arm: Add handling of extended regions for Dom0
To: Julien Grall <julien@xen.org>
Cc: xen-devel <xen-devel@lists.xenproject.org>, 
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, Andrew Cooper <andrew.cooper3@citrix.com>, 
	George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>, 
	Jan Beulich <jbeulich@suse.com>, Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>, 
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Content-Type: multipart/alternative; boundary="0000000000004b93a005cdb321ce"

--0000000000004b93a005cdb321ce
Content-Type: text/plain; charset="UTF-8"

On Wed, Oct 6, 2021 at 9:11 PM Julien Grall <julien@xen.org> wrote:

> Hi Oleksandr,
>

Hi Julien

[Sorry for the possible format issues]



>
> On 04/10/2021 14:08, Oleksandr wrote:
> >
> > On 04.10.21 09:59, Julien Grall wrote:
> >> Hi Oleksandr,
> >
> > Hi Julien
>
> Hi Oleksandr,
>
> >
> >
> >>
> >> I saw Stefano committed this patch on Friday. However, I didn't have a
> >> chance go to through a second time and would like to request some
> >> follow-up changes.
> >
> > ok, do you prefer the follow-up patch to be pushed separately or within
> > the rest patches of this series (#1 and #3)?  If the former, I will try
> > to push it today to close this question.
>
> I don't mind. My main ask is they are addressed for 4.16.
>
> >
> >
> >>
> >>
> >> On 30/09/2021 00:52, Oleksandr Tyshchenko wrote:
> >>> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> >>>
> >>> The extended region (safe range) is a region of guest physical
> >>> address space which is unused and could be safely used to create
> >>> grant/foreign mappings instead of wasting real RAM pages from
> >>> the domain memory for establishing these mappings.
> >>>
> >>> The extended regions are chosen at the domain creation time and
> >>> advertised to it via "reg" property under hypervisor node in
> >>> the guest device-tree. As region 0 is reserved for grant table
> >>> space (always present), the indexes for extended regions are 1...N.
> >>> If extended regions could not be allocated for some reason,
> >>> Xen doesn't fail and behaves as usual, so only inserts region 0.
> >>>
> >>> Please note the following limitations:
> >>> - The extended region feature is only supported for 64-bit domain
> >>>    currently.
> >>> - The ACPI case is not covered.
> >>>
> >>> ***
> >>>
> >>> As Dom0 is direct mapped domain on Arm (e.g. MFN == GFN)
> >>> the algorithm to choose extended regions for it is different
> >>> in comparison with the algorithm for non-direct mapped DomU.
> >>> What is more, that extended regions should be chosen differently
> >>> whether IOMMU is enabled or not.
> >>>
> >>> Provide RAM not assigned to Dom0 if IOMMU is disabled or memory
> >>> holes found in host device-tree if otherwise. Make sure that
> >>> extended regions are 2MB-aligned and located within maximum possible
> >>> addressable physical memory range. The minimum size of extended
> >>> region is 64MB.
> >>
> >> You explained below why the 128 limits, but I don't see any
> >> explanation on why 2MB and 64MB.
> >>
> >> IIRC, 2MB was to potentally allow superpage mapping. I am not entirely
> >> sure for 64MB.
> >>
> >> Could you add an in-code comment explaining the two limits?
> >
> > Yes. There was a discussion at [1]. 64MB was chosen as a reasonable
> > value to deal with between initial 2MB (we might end up having a lot of
> > small ranges which are not quite useful but increase bookkeeping) and
> > suggested 1GB (we might not be able find a suitable regions at all).
>
> Ok. Please document in the code. Note that I don't think this choice
> should be advertised to the OS. This would give us some flexibility to
> change the size in the future (e.g. if we have platform where chunk of
> less than 64MB is beneficial).
>
> >> The code below looks like an open-coding version of
> >> dt_for_each_range(). Can you try to re-use it please? This will help
> >> to reduce the complexity of this function.
> >
> > You are right, it makes sense, will definitely reuse. If I was aware of
> > that function before I would safe some time I spent on the investigation
> > how to parse that)
>
> I have only skimmed through the diff below. This looks fine to me.
> Please submit a formal patch.
>

Already submitted, please take a look at [1].

 [1]
https://lore.kernel.org/xen-devel/1633519346-3686-4-git-send-email-olekstysh@gmail.com/

-- 
Regards,

Oleksandr Tyshchenko

--0000000000004b93a005cdb321ce
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote">=
<div dir=3D"ltr" class=3D"gmail_attr">On Wed, Oct 6, 2021 at 9:11 PM Julien=
 Grall &lt;<a href=3D"mailto:julien@xen.org" target=3D"_blank">julien@xen.o=
rg</a>&gt; wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"margi=
n:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex=
">Hi Oleksandr,<br></blockquote><div><br></div><div>Hi Julien</div><div><br=
></div><div>[Sorry for the possible format issues]</div><div><br></div><div=
>=C2=A0</div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px =
0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
On 04/10/2021 14:08, Oleksandr wrote:<br>
&gt; <br>
&gt; On 04.10.21 09:59, Julien Grall wrote:<br>
&gt;&gt; Hi Oleksandr,<br>
&gt; <br>
&gt; Hi Julien<br>
<br>
Hi Oleksandr,<br>
<br>
&gt; <br>
&gt; <br>
&gt;&gt;<br>
&gt;&gt; I saw Stefano committed this patch on Friday. However, I didn&#39;=
t have a <br>
&gt;&gt; chance go to through a second time and would like to request some =
<br>
&gt;&gt; follow-up changes.<br>
&gt; <br>
&gt; ok, do you prefer the follow-up patch to be pushed separately or withi=
n <br>
&gt; the rest patches of this series (#1 and #3)?=C2=A0 If the former, I wi=
ll try <br>
&gt; to push it today to close this question.<br>
<br>
I don&#39;t mind. My main ask is they are addressed for 4.16.<br>
<br>
&gt; <br>
&gt; <br>
&gt;&gt;<br>
&gt;&gt;<br>
&gt;&gt; On 30/09/2021 00:52, Oleksandr Tyshchenko wrote:<br>
&gt;&gt;&gt; From: Oleksandr Tyshchenko &lt;<a href=3D"mailto:oleksandr_tys=
hchenko@epam.com" target=3D"_blank">oleksandr_tyshchenko@epam.com</a>&gt;<b=
r>
&gt;&gt;&gt;<br>
&gt;&gt;&gt; The extended region (safe range) is a region of guest physical=
<br>
&gt;&gt;&gt; address space which is unused and could be safely used to crea=
te<br>
&gt;&gt;&gt; grant/foreign mappings instead of wasting real RAM pages from<=
br>
&gt;&gt;&gt; the domain memory for establishing these mappings.<br>
&gt;&gt;&gt;<br>
&gt;&gt;&gt; The extended regions are chosen at the domain creation time an=
d<br>
&gt;&gt;&gt; advertised to it via &quot;reg&quot; property under hypervisor=
 node in<br>
&gt;&gt;&gt; the guest device-tree. As region 0 is reserved for grant table=
<br>
&gt;&gt;&gt; space (always present), the indexes for extended regions are 1=
...N.<br>
&gt;&gt;&gt; If extended regions could not be allocated for some reason,<br=
>
&gt;&gt;&gt; Xen doesn&#39;t fail and behaves as usual, so only inserts reg=
ion 0.<br>
&gt;&gt;&gt;<br>
&gt;&gt;&gt; Please note the following limitations:<br>
&gt;&gt;&gt; - The extended region feature is only supported for 64-bit dom=
ain<br>
&gt;&gt;&gt; =C2=A0=C2=A0 currently.<br>
&gt;&gt;&gt; - The ACPI case is not covered.<br>
&gt;&gt;&gt;<br>
&gt;&gt;&gt; ***<br>
&gt;&gt;&gt;<br>
&gt;&gt;&gt; As Dom0 is direct mapped domain on Arm (e.g. MFN =3D=3D GFN)<b=
r>
&gt;&gt;&gt; the algorithm to choose extended regions for it is different<b=
r>
&gt;&gt;&gt; in comparison with the algorithm for non-direct mapped DomU.<b=
r>
&gt;&gt;&gt; What is more, that extended regions should be chosen different=
ly<br>
&gt;&gt;&gt; whether IOMMU is enabled or not.<br>
&gt;&gt;&gt;<br>
&gt;&gt;&gt; Provide RAM not assigned to Dom0 if IOMMU is disabled or memor=
y<br>
&gt;&gt;&gt; holes found in host device-tree if otherwise. Make sure that<b=
r>
&gt;&gt;&gt; extended regions are 2MB-aligned and located within maximum po=
ssible<br>
&gt;&gt;&gt; addressable physical memory range. The minimum size of extende=
d<br>
&gt;&gt;&gt; region is 64MB. <br>
&gt;&gt;<br>
&gt;&gt; You explained below why the 128 limits, but I don&#39;t see any <b=
r>
&gt;&gt; explanation on why 2MB and 64MB.<br>
&gt;&gt;<br>
&gt;&gt; IIRC, 2MB was to potentally allow superpage mapping. I am not enti=
rely <br>
&gt;&gt; sure for 64MB.<br>
&gt;&gt;<br>
&gt;&gt; Could you add an in-code comment explaining the two limits?<br>
&gt; <br>
&gt; Yes. There was a discussion at [1]. 64MB was chosen as a reasonable <b=
r>
&gt; value to deal with between initial 2MB (we might end up having a lot o=
f <br>
&gt; small ranges which are not quite useful but increase bookkeeping) and =
<br>
&gt; suggested 1GB (we might not be able find a suitable regions at all).<b=
r>
<br>
Ok. Please document in the code. Note that I don&#39;t think this choice <b=
r>
should be advertised to the OS. This would give us some flexibility to <br>
change the size in the future (e.g. if we have platform where chunk of <br>
less than 64MB is beneficial).<br>
<br>
&gt;&gt; The code below looks like an open-coding version of <br>
&gt;&gt; dt_for_each_range(). Can you try to re-use it please? This will he=
lp <br>
&gt;&gt; to reduce the complexity of this function.<br>
&gt; <br>
&gt; You are right, it makes sense, will definitely reuse. If I was aware o=
f <br>
&gt; that function before I would safe some time I spent on the investigati=
on <br>
&gt; how to parse that)<br>
<br>
I have only skimmed through the diff below. This looks fine to me. <br>
Please submit a formal patch.<br></blockquote><div><br></div><div>Already s=
ubmitted, please take a look at [1].</div><div><br></div><div>=C2=A0[1]=C2=
=A0<a href=3D"https://lore.kernel.org/xen-devel/1633519346-3686-4-git-send-=
email-olekstysh@gmail.com/">https://lore.kernel.org/xen-devel/1633519346-36=
86-4-git-send-email-olekstysh@gmail.com/</a></div></div><div><br></div>-- <=
br><div dir=3D"ltr"><div dir=3D"ltr"><div><div dir=3D"ltr"><div><div dir=3D=
"ltr"><span style=3D"background-color:rgb(255,255,255)"><font size=3D"2"><s=
pan style=3D"color:rgb(51,51,51);font-family:Arial,sans-serif">Regards,</sp=
an></font></span></div><div dir=3D"ltr"><br></div><div dir=3D"ltr"><div><sp=
an style=3D"background-color:rgb(255,255,255)"><font size=3D"2">Oleksandr T=
yshchenko</font></span></div></div></div></div></div></div></div></div>

--0000000000004b93a005cdb321ce--


From xen-devel-bounces@lists.xenproject.org Wed Oct 06 18:32:43 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Oct 2021 18:32:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.203125.358187 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYBiX-0001fY-Hz; Wed, 06 Oct 2021 18:32:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 203125.358187; Wed, 06 Oct 2021 18:32:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYBiX-0001fR-ET; Wed, 06 Oct 2021 18:32:37 +0000
Received: by outflank-mailman (input) for mailman id 203125;
 Wed, 06 Oct 2021 18:32:36 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mYBiW-0001fL-E1
 for xen-devel@lists.xenproject.org; Wed, 06 Oct 2021 18:32:36 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mYBiV-0001U1-06; Wed, 06 Oct 2021 18:32:35 +0000
Received: from [92.174.63.74] (helo=[192.168.1.232])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mYBiU-0005BH-NI; Wed, 06 Oct 2021 18:32:34 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=DGSbHLS92yhnnWE4hrus3xUQS1vIhlkGW6ZQK8/XI3g=; b=xHZW3wpuzSAwouRVOqc91Ixc0Y
	GHgBubECPuSjNQimLfJvRxbMh+BrGawmq2orTPFSYKu9wlLjRVOPwxjuCdukJtRrCXeOtjW6u2ikp
	LTRQZCg3E91uK9jHVFtsFFeHXS8vpyjCVi2lOqjuGsxv70YZZB+xMp5iMOqDQwe51hOY=;
Message-ID: <8691f762-e4ca-b099-8b4e-87b63b16abe0@xen.org>
Date: Wed, 6 Oct 2021 20:32:30 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.1.2
Subject: Re: [PATCH v4 1/3] arm/efi: Introduce xen,uefi-cfg-load DT property
To: Luca Fancellu <luca.fancellu@arm.com>, xen-devel@lists.xenproject.org
Cc: bertrand.marquis@arm.com, wei.chen@arm.com,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Jan Beulich <jbeulich@suse.com>, Wei Liu <wl@xen.org>
References: <20210930142846.13348-1-luca.fancellu@arm.com>
 <20210930142846.13348-2-luca.fancellu@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20210930142846.13348-2-luca.fancellu@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Luca,

Sorry for jumping late in the conversation. While skimming through what 
has been committed, I noticed one potential issue in this patch and have 
also a question.

On 30/09/2021 16:28, Luca Fancellu wrote:
> Introduce the xen,uefi-cfg-load DT property of /chosen
> node for ARM whose presence decide whether to force
> the load of the UEFI Xen configuration file.
> 
> The logic is that if any multiboot,module is found in
> the DT, then the xen,uefi-cfg-load property is used to see
> if the UEFI Xen configuration file is needed.
> 
> Modify a comment in efi_arch_use_config_file, removing
> the part that states "dom0 required" because it's not
> true anymore with this commit.
> 
> Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>
> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
> ---
> v4 changes:
> - modify property name to xen,uefi-cfg-load
> v3 changes:
> - add documentation to misc/arm/device-tree/booting.txt
> - Modified variable name and logic from skip_cfg_file to
> load_cfg_file
> - Add in the commit message that I'm modifying a comment.
> v2 changes:
> - Introduced uefi,cfg-load property
> - Add documentation about the property
> ---
>   docs/misc/arm/device-tree/booting.txt |  8 ++++++++
>   docs/misc/efi.pandoc                  |  2 ++
>   xen/arch/arm/efi/efi-boot.h           | 28 ++++++++++++++++++++++-----
>   3 files changed, 33 insertions(+), 5 deletions(-)
> 
> diff --git a/docs/misc/arm/device-tree/booting.txt b/docs/misc/arm/device-tree/booting.txt
> index 44cd9e1a9a..352b0ec43a 100644
> --- a/docs/misc/arm/device-tree/booting.txt
> +++ b/docs/misc/arm/device-tree/booting.txt
> @@ -121,6 +121,14 @@ A Xen-aware bootloader would set xen,xen-bootargs for Xen, xen,dom0-bootargs
>   for Dom0 and bootargs for native Linux.
>   
>   
> +UEFI boot and DT
> +================
> +
> +When Xen is booted using UEFI, it doesn't read the configuration file if any
> +multiboot module is specified. To force Xen to load the configuration file, the
> +boolean property xen,uefi-cfg-load must be declared in the /chosen node.
> +
> +
>   Creating Multiple Domains directly from Xen
>   ===========================================
>   
> diff --git a/docs/misc/efi.pandoc b/docs/misc/efi.pandoc
> index ac3cd58cae..ed85351541 100644
> --- a/docs/misc/efi.pandoc
> +++ b/docs/misc/efi.pandoc
> @@ -14,6 +14,8 @@ loaded the modules and describes them in the device tree provided to Xen.  If a
>   bootloader provides a device tree containing modules then any configuration
>   files are ignored, and the bootloader is responsible for populating all
>   relevant device tree nodes.
> +The property "xen,uefi-cfg-load" can be specified in the /chosen node to force
> +Xen to load the configuration file even if multiboot modules are found.

I think this wants to be clarified. Lets imagine both the Device-Tree 
and the cfg provides a kernel. Which one will get used?


>   
>   Once built, `make install-xen` will place the resulting binary directly into
>   the EFI boot partition, provided `EFI_VENDOR` is set in the environment (and
> diff --git a/xen/arch/arm/efi/efi-boot.h b/xen/arch/arm/efi/efi-boot.h
> index cf9c37153f..a3e46453d4 100644
> --- a/xen/arch/arm/efi/efi-boot.h
> +++ b/xen/arch/arm/efi/efi-boot.h
> @@ -581,22 +581,40 @@ static void __init efi_arch_load_addr_check(EFI_LOADED_IMAGE *loaded_image)
>   
>   static bool __init efi_arch_use_config_file(EFI_SYSTEM_TABLE *SystemTable)
>   {
> +    bool load_cfg_file = true;
>       /*
>        * For arm, we may get a device tree from GRUB (or other bootloader)
>        * that contains modules that have already been loaded into memory.  In
> -     * this case, we do not use a configuration file, and rely on the
> -     * bootloader to have loaded all required modules and appropriate
> -     * options.
> +     * this case, we search for the property xen,uefi-cfg-load in the /chosen
> +     * node to decide whether to skip the UEFI Xen configuration file or not.
>        */
>   
>       fdt = lookup_fdt_config_table(SystemTable);
>       dtbfile.ptr = fdt;
>       dtbfile.need_to_free = false; /* Config table memory can't be freed. */
> -    if ( !fdt || fdt_node_offset_by_compatible(fdt, 0, "multiboot,module") < 0 )
> +
> +    if ( fdt_node_offset_by_compatible(fdt, 0, "multiboot,module") > 0 )

AFAICT, fdt_node_offset_by_compatible expects 'fdt' to be non-NULL. 
However, lookup_fdt_config_table() may return NULL on platform with no 
Device-Tree (server tends to be ACPI only). So wouldn't this result to 
dereference NULL and crash?

> +    {
> +        /* Locate chosen node */
> +        int node = fdt_subnode_offset(fdt, 0, "chosen");
> +        const void *cfg_load_prop;
> +        int cfg_load_len;
> +
> +        if ( node > 0 )
> +        {
> +            /* Check if xen,uefi-cfg-load property exists */
> +            cfg_load_prop = fdt_getprop(fdt, node, "xen,uefi-cfg-load",
> +                                        &cfg_load_len);
> +            if ( !cfg_load_prop )
> +                load_cfg_file = false;
> +        }
> +    }
> +
> +    if ( !fdt || load_cfg_file )
>       {
>           /*
>            * We either have no FDT, or one without modules, so we must have a
> -         * Xen EFI configuration file to specify modules.  (dom0 required)
> +         * Xen EFI configuration file to specify modules.
>            */
>           return true;
>       }
> 

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Oct 06 18:35:44 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Oct 2021 18:35:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.203133.358198 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYBlY-0002JZ-00; Wed, 06 Oct 2021 18:35:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 203133.358198; Wed, 06 Oct 2021 18:35:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYBlX-0002JS-TA; Wed, 06 Oct 2021 18:35:43 +0000
Received: by outflank-mailman (input) for mailman id 203133;
 Wed, 06 Oct 2021 18:35:43 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mYBlX-0002JM-13
 for xen-devel@lists.xenproject.org; Wed, 06 Oct 2021 18:35:43 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mYBlV-0001YI-HD; Wed, 06 Oct 2021 18:35:41 +0000
Received: from [92.174.63.74] (helo=[192.168.1.232])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mYBlV-0005XP-8u; Wed, 06 Oct 2021 18:35:41 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=wKmQLk4UUow97V9ZfecvccjJZzz1EAHGrhzFhiH7LAc=; b=ol7Qnac3gxgPGV3dstnGYWuCky
	rNU6Wj6zInu9esbCihFtK/WyoTBsei5dc0ZrQlyLVIFJ1JB7ux4USvEFizVz8G2L52hsxRMKNfdhT
	0EewezeVtPbdS8yiL98st2J9jw0cDyZB49FJ/okENxQquwEZy6upQ2s+CA605KkKjGBs=;
Message-ID: <8ce7b98e-72eb-ba70-cb12-bf6869e5f64b@xen.org>
Date: Wed, 6 Oct 2021 20:35:37 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.1.2
Subject: Re: [PATCH V4 2/3] xen/arm: Add handling of extended regions for Dom0
To: Oleksandr Tyshchenko <olekstysh@gmail.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Jan Beulich <jbeulich@suse.com>, Stefano Stabellini
 <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <1632955927-27911-1-git-send-email-olekstysh@gmail.com>
 <1632955927-27911-3-git-send-email-olekstysh@gmail.com>
 <8318a7b0-80fa-ccd6-75c5-c3135b82235d@xen.org>
 <20f00d52-76c8-2afe-6544-6f1396e121e9@gmail.com>
 <bea0e4a3-90fe-79f0-ab4e-44d3b2d93c7f@xen.org>
 <CAPD2p-mLM-JjfKh6U+A_UTJostXvYDCJ68ac-V3teSeKjmaXTA@mail.gmail.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <CAPD2p-mLM-JjfKh6U+A_UTJostXvYDCJ68ac-V3teSeKjmaXTA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi Oleksandr,

On 06/10/2021 20:15, Oleksandr Tyshchenko wrote:
> 
> 
> On Wed, Oct 6, 2021 at 9:11 PM Julien Grall <julien@xen.org 
> <mailto:julien@xen.org>> wrote:
> 
>     Hi Oleksandr,
> 
> 
> Hi Julien
> 
> [Sorry for the possible format issues]
> 
> 
>     On 04/10/2021 14:08, Oleksandr wrote:
>      >
>      > On 04.10.21 09:59, Julien Grall wrote:
>      >> Hi Oleksandr,
>      >
>      > Hi Julien
> 
>     Hi Oleksandr,
> 
>      >
>      >
>      >>
>      >> I saw Stefano committed this patch on Friday. However, I didn't
>     have a
>      >> chance go to through a second time and would like to request some
>      >> follow-up changes.
>      >
>      > ok, do you prefer the follow-up patch to be pushed separately or
>     within
>      > the rest patches of this series (#1 and #3)?  If the former, I
>     will try
>      > to push it today to close this question.
> 
>     I don't mind. My main ask is they are addressed for 4.16.
> 
>      >
>      >
>      >>
>      >>
>      >> On 30/09/2021 00:52, Oleksandr Tyshchenko wrote:
>      >>> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com
>     <mailto:oleksandr_tyshchenko@epam.com>>
>      >>>
>      >>> The extended region (safe range) is a region of guest physical
>      >>> address space which is unused and could be safely used to create
>      >>> grant/foreign mappings instead of wasting real RAM pages from
>      >>> the domain memory for establishing these mappings.
>      >>>
>      >>> The extended regions are chosen at the domain creation time and
>      >>> advertised to it via "reg" property under hypervisor node in
>      >>> the guest device-tree. As region 0 is reserved for grant table
>      >>> space (always present), the indexes for extended regions are 1...N.
>      >>> If extended regions could not be allocated for some reason,
>      >>> Xen doesn't fail and behaves as usual, so only inserts region 0.
>      >>>
>      >>> Please note the following limitations:
>      >>> - The extended region feature is only supported for 64-bit domain
>      >>>    currently.
>      >>> - The ACPI case is not covered.
>      >>>
>      >>> ***
>      >>>
>      >>> As Dom0 is direct mapped domain on Arm (e.g. MFN == GFN)
>      >>> the algorithm to choose extended regions for it is different
>      >>> in comparison with the algorithm for non-direct mapped DomU.
>      >>> What is more, that extended regions should be chosen differently
>      >>> whether IOMMU is enabled or not.
>      >>>
>      >>> Provide RAM not assigned to Dom0 if IOMMU is disabled or memory
>      >>> holes found in host device-tree if otherwise. Make sure that
>      >>> extended regions are 2MB-aligned and located within maximum
>     possible
>      >>> addressable physical memory range. The minimum size of extended
>      >>> region is 64MB.
>      >>
>      >> You explained below why the 128 limits, but I don't see any
>      >> explanation on why 2MB and 64MB.
>      >>
>      >> IIRC, 2MB was to potentally allow superpage mapping. I am not
>     entirely
>      >> sure for 64MB.
>      >>
>      >> Could you add an in-code comment explaining the two limits?
>      >
>      > Yes. There was a discussion at [1]. 64MB was chosen as a reasonable
>      > value to deal with between initial 2MB (we might end up having a
>     lot of
>      > small ranges which are not quite useful but increase bookkeeping)
>     and
>      > suggested 1GB (we might not be able find a suitable regions at all).
> 
>     Ok. Please document in the code. Note that I don't think this choice
>     should be advertised to the OS. This would give us some flexibility to
>     change the size in the future (e.g. if we have platform where chunk of
>     less than 64MB is beneficial).
> 
>      >> The code below looks like an open-coding version of
>      >> dt_for_each_range(). Can you try to re-use it please? This will
>     help
>      >> to reduce the complexity of this function.
>      >
>      > You are right, it makes sense, will definitely reuse. If I was
>     aware of
>      > that function before I would safe some time I spent on the
>     investigation
>      > how to parse that)
> 
>     I have only skimmed through the diff below. This looks fine to me.
>     Please submit a formal patch.
> 
> 
> Already submitted, please take a look at [1].
> 
>   [1] 
> https://lore.kernel.org/xen-devel/1633519346-3686-4-git-send-email-olekstysh@gmail.com/ 
> <https://lore.kernel.org/xen-devel/1633519346-3686-4-git-send-email-olekstysh@gmail.com/>

Thanks! Sorry, my inbox has been growing quite a lot while I was away. I 
will have a look when I am fully back next week :).

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Oct 06 18:46:42 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Oct 2021 18:46:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.203144.358209 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYBw5-0003pC-0d; Wed, 06 Oct 2021 18:46:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 203144.358209; Wed, 06 Oct 2021 18:46:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYBw4-0003p5-Th; Wed, 06 Oct 2021 18:46:36 +0000
Received: by outflank-mailman (input) for mailman id 203144;
 Wed, 06 Oct 2021 18:46:35 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mYBw3-0003oz-ML
 for xen-devel@lists.xenproject.org; Wed, 06 Oct 2021 18:46:35 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mYBw2-0001jU-UP; Wed, 06 Oct 2021 18:46:34 +0000
Received: from [92.174.63.74] (helo=[192.168.1.232])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mYBw2-0006Nk-NK; Wed, 06 Oct 2021 18:46:34 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=+uva9TnyBVL23NIo076URFYFZColAv390fCIpXLLNcU=; b=hLquBk+ndgG9QkxCalkPhl0fW2
	7hO2zzuuBbbuxMIFc8Ssh/FtU4JQu8yWMuAEyHQvk3J/uRcXNXJ8MuzwWX+Gf122g2BG0LV8iGtXu
	hHaPI63Lixs0DYCWJMSfcQpxJucOExj5rMHaId6H7TJHp4hE8/8YLLrlp5Yc6dagBfSA=;
Message-ID: <e612c225-cda6-2c41-bf20-73314ebceb02@xen.org>
Date: Wed, 6 Oct 2021 20:46:30 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.1.2
Subject: Re: [PATCH] xen/arm: optee: Fix arm_smccc_smc's a0 for
 OPTEE_SMC_DISABLE_SHM_CACHE
To: Stefano Stabellini <sstabellini@kernel.org>,
 Oleksandr Tyshchenko <olekstysh@gmail.com>
Cc: xen-devel@lists.xenproject.org,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Volodymyr Babchuk <volodymyr_babchuk@epam.com>, tee-dev@lists.linaro.org
References: <1632750850-28600-1-git-send-email-olekstysh@gmail.com>
 <alpine.DEB.2.21.2109272151260.5022@sstabellini-ThinkPad-T480s>
From: Julien Grall <julien@xen.org>
In-Reply-To: <alpine.DEB.2.21.2109272151260.5022@sstabellini-ThinkPad-T480s>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Stefano,

On 28/09/2021 06:52, Stefano Stabellini wrote:
> On Mon, 27 Sep 2021, Oleksandr Tyshchenko wrote:
>> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>>
>> Fix a possible copy-paste error in arm_smccc_smc's first argument (a0)
>> for OPTEE_SMC_DISABLE_SHM_CACHE case.
>>
>> This error causes Linux > v5.14-rc5 (b5c10dd04b7418793517e3286cde5c04759a86de
>> optee: Clear stale cache entries during initialization) to stuck
>> repeatedly issuing OPTEE_SMC_DISABLE_SHM_CACHE call and waiting for
>> the result to be OPTEE_SMC_RETURN_ENOTAVAIL which will never happen.
>>
>> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> 
> Acked-by: Stefano Stabellini <sstabellini@kernel.org>
> 
> I added Fixes: and Backport: tags to the commit
Per SUPPORT.MD, OP-TEE is still a technical preview. So I would argue 
that we should not do any backport because the feature itself is not 
officially considered supported.

That said, what's missing to make the feature officially supported?

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Oct 06 19:23:17 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Oct 2021 19:23:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.203157.358220 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYCVI-00081H-S5; Wed, 06 Oct 2021 19:23:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 203157.358220; Wed, 06 Oct 2021 19:23:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYCVI-00081A-Oq; Wed, 06 Oct 2021 19:23:00 +0000
Received: by outflank-mailman (input) for mailman id 203157;
 Wed, 06 Oct 2021 19:22:58 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mYCVG-000810-Rj; Wed, 06 Oct 2021 19:22:58 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mYCVG-0002KF-JJ; Wed, 06 Oct 2021 19:22:58 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mYCVG-0004Aj-AH; Wed, 06 Oct 2021 19:22:58 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mYCVG-0005zC-9e; Wed, 06 Oct 2021 19:22:58 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=0MouNFrlRUVkkZ502r92jEoRSaZ41UXiWd4jjJCGI54=; b=pxL04T/+37apX73INOCDEy0lX9
	tredqQdDKkNAe5weKYlTSQwsvh61T2XyDS8aod8SDqCHyU90c+ip1+nEdDfe023j+Yh+NPnR9dfDS
	MqrZL9wJaOw4ah5JSKM99RZMuJopjA+Dg1lgqQP6N0ZvbCIooAsg4Jcb/IOz6IPozkWw=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165391-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-arm-xen test] 165391: tolerable all pass - PUSHED
X-Osstest-Failures:
    linux-arm-xen:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-arm-xen:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-arm-xen:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-arm-xen:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-arm-xen:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-arm-xen:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-arm-xen:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-arm-xen:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-arm-xen:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-arm-xen:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-arm-xen:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-arm-xen:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-arm-xen:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-arm-xen:test-arm64-arm64-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-arm-xen:test-arm64-arm64-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-arm-xen:test-arm64-arm64-xl-rtds:migrate-support-check:fail:nonblocking
    linux-arm-xen:test-arm64-arm64-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-arm-xen:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-arm-xen:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-arm-xen:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-arm-xen:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-arm-xen:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-arm-xen:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-arm-xen:test-arm64-arm64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-arm-xen:test-arm64-arm64-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-arm-xen:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-arm-xen:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-arm-xen:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-arm-xen:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-arm-xen:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-arm-xen:test-arm64-arm64-libvirt:migrate-support-check:fail:nonblocking
    linux-arm-xen:test-arm64-arm64-libvirt:saverestore-support-check:fail:nonblocking
    linux-arm-xen:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-arm-xen:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-arm-xen:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-arm-xen:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-arm-xen:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-arm-xen:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-arm-xen:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-arm-xen:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-arm-xen:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-arm-xen:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-arm-xen:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-arm-xen:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-arm-xen:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-arm-xen:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-arm-xen:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-arm-xen:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=f0f0e602f7c9781699ecda9be763eac0b03d54f0
X-Osstest-Versions-That:
    linux=a6c5dd1dbaffe4cc398d8454546ba9246b9a95c9
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 06 Oct 2021 19:22:58 +0000

flight 165391 linux-arm-xen real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165391/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail baseline untested
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 146859
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 146859
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-arm64-arm64-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-arm64-arm64-xl-rtds     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-rtds     16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-arm64-arm64-libvirt-qcow2 15 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-arm64-arm64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt     16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 linux                f0f0e602f7c9781699ecda9be763eac0b03d54f0
baseline version:
 linux                a6c5dd1dbaffe4cc398d8454546ba9246b9a95c9

Last test of basis   146859  2020-02-11 11:11:57 Z  603 days
Testing same since   165391  2021-10-05 21:41:05 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Jan Beulich <jbeulich@suse.com>
  Juergen Gross <jgross@suse.com>

jobs:
 build-arm64-xsm                                              pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-armhf-armhf-xl-arndale                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-arm64-arm64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-arm64-arm64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-arm64-arm64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-arm64-arm64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   a6c5dd1dbaff..f0f0e602f7c9  f0f0e602f7c9781699ecda9be763eac0b03d54f0 -> tested/linux-arm-xen


From xen-devel-bounces@lists.xenproject.org Wed Oct 06 21:34:00 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Oct 2021 21:34:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.203173.358234 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYEXo-0003sy-5p; Wed, 06 Oct 2021 21:33:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 203173.358234; Wed, 06 Oct 2021 21:33:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYEXo-0003sr-2h; Wed, 06 Oct 2021 21:33:44 +0000
Received: by outflank-mailman (input) for mailman id 203173;
 Wed, 06 Oct 2021 21:33:42 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HdqS=O2=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1mYEXm-0003sl-34
 for xen-devel@lists.xenproject.org; Wed, 06 Oct 2021 21:33:42 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id e20ba118-68a0-4097-bf2e-8e6b47aab016;
 Wed, 06 Oct 2021 21:33:39 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id 4EA4A610CC;
 Wed,  6 Oct 2021 21:33:38 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e20ba118-68a0-4097-bf2e-8e6b47aab016
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1633556018;
	bh=J0+sJOMYY3ummfywCnUi2HaOFZz9PFqC4qBeatGS+F8=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=RGiKrQtnOBDxmkk0pQ5HJj/DA26iSncILfQAfIjI77bvze/+ByQMD7SEa2cPBUlLT
	 K3fmRJSTSae3qF1dIrAvyQpcp8mj8xLK+sqx7ZcT3dv0iwj//jt24KVzQZUnNodMTr
	 wUkoKCHtIeVvo+rglxzIhaFFH4ZlWh17HqunGYPRdFstMV/S57bNJXv6/zly1cNmRK
	 m/9ZYZ9akL3izVJY+4TrO2XDy1fenHFtocOQ9BgUtb6VsHWIEOjucP/Sse8ps17oFU
	 zFGHLOd5oDwI5JYKCMnb73HpOC6vpeqkimFIDWRrUrXkN4lV2yO0HT+q/z87oqKioi
	 sTlb6zdkAF5lQ==
Date: Wed, 6 Oct 2021 14:33:36 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
cc: Stefano Stabellini <sstabellini@kernel.org>, 
    "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, 
    "julien@xen.org" <julien@xen.org>, 
    Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, 
    Artem Mygaiev <Artem_Mygaiev@epam.com>, 
    "roger.pau@citrix.com" <roger.pau@citrix.com>, 
    "jbeulich@suse.com" <jbeulich@suse.com>, 
    "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>, 
    "george.dunlap@citrix.com" <george.dunlap@citrix.com>, 
    "paul@xen.org" <paul@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>, 
    Rahul Singh <rahul.singh@arm.com>
Subject: Re: [PATCH v4 10/11] xen/arm: Do not map PCI ECAM and MMIO space to
 Domain-0's p2m
In-Reply-To: <e225b18a-78e0-5737-9856-0e98753cdeaa@epam.com>
Message-ID: <alpine.DEB.2.21.2110061432310.3209@sstabellini-ThinkPad-T480s>
References: <20211004141151.132231-1-andr2000@gmail.com> <20211004141151.132231-11-andr2000@gmail.com> <alpine.DEB.2.21.2110041812270.3209@sstabellini-ThinkPad-T480s> <7b42e2aa-658a-74a1-045a-a35fb89a37b0@epam.com> <alpine.DEB.2.21.2110051438140.3209@sstabellini-ThinkPad-T480s>
 <e225b18a-78e0-5737-9856-0e98753cdeaa@epam.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Wed, 6 Oct 2021, Oleksandr Andrushchenko wrote:
> On 06.10.21 00:43, Stefano Stabellini wrote:
> > On Tue, 5 Oct 2021, Oleksandr Andrushchenko wrote:
> >> On 05.10.21 04:24, Stefano Stabellini wrote:
> >>> On Mon, 4 Oct 2021, Oleksandr Andrushchenko wrote:
> >>>> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> >>>>
> >>>> PCI host bridges are special devices in terms of implementing PCI
> >>>> passthrough. According to [1] the current implementation depends on
> >>>> Domain-0 to perform the initialization of the relevant PCI host
> >>>> bridge hardware and perform PCI device enumeration. In order to
> >>>> achieve that one of the required changes is to not map all the memory
> >>>> ranges in map_range_to_domain as we traverse the device tree on startup
> >>>> and perform some additional checks if the range needs to be mapped to
> >>>> Domain-0.
> >>>>
> >>>> The generic PCI host controller device tree binding says [2]:
> >>>> - ranges: As described in IEEE Std 1275-1994, but must provide
> >>>>             at least a definition of non-prefetchable memory. One
> >>>>             or both of prefetchable Memory and IO Space may also
> >>>>             be provided.
> >>>>
> >>>> - reg   : The Configuration Space base address and size, as accessed
> >>>>             from the parent bus.  The base address corresponds to
> >>>>             the first bus in the "bus-range" property.  If no
> >>>>             "bus-range" is specified, this will be bus 0 (the default).
> >>>>
> >>>> >From the above none of the memory ranges from the "ranges" property
> >>>> needs to be mapped to Domain-0 at startup as MMIO mapping is going to
> >>>> be handled dynamically by vPCI as we assign PCI devices, e.g. each
> >>>> device assigned to Domain-0/guest will have its MMIOs mapped/unmapped
> >>>> as needed by Xen.
> >>>>
> >>>> The "reg" property covers not only ECAM space, but may also have other
> >>>> then the configuration memory ranges described, for example [3]:
> >>>> - reg: Should contain rc_dbi, config registers location and length.
> >>>> - reg-names: Must include the following entries:
> >>>>      "rc_dbi": controller configuration registers;
> >>>>      "config": PCIe configuration space registers.
> >>>>
> >>>> This patch makes it possible to not map all the ranges from the
> >>>> "ranges" property and also ECAM from the "reg". All the rest from the
> >>>> "reg" property still needs to be mapped to Domain-0, so the PCI
> >>>> host bridge remains functional in Domain-0.
> >>>>
> >>>> [1] https://urldefense.com/v3/__https://lists.xenproject.org/archives/html/xen-devel/2020-07/msg00777.html__;!!GF_29dbcQIUBPA!nW_LVc5NeS7QQII7CDO4h3ifHhxdPAvQpLSVaX1CRyXh3c1a4a9cBpQ9S7SiAsDdMbL5RkTJpw$ [lists[.]xenproject[.]org]
> >>>> [2] https://urldefense.com/v3/__https://www.kernel.org/doc/Documentation/devicetree/bindings/pci/host-generic-pci.txt__;!!GF_29dbcQIUBPA!nW_LVc5NeS7QQII7CDO4h3ifHhxdPAvQpLSVaX1CRyXh3c1a4a9cBpQ9S7SiAsDdMbL-vGunhg$ [kernel[.]org]
> >>>> [3] https://urldefense.com/v3/__https://www.kernel.org/doc/Documentation/devicetree/bindings/pci/hisilicon-pcie.txt__;!!GF_29dbcQIUBPA!nW_LVc5NeS7QQII7CDO4h3ifHhxdPAvQpLSVaX1CRyXh3c1a4a9cBpQ9S7SiAsDdMbKjL04tRA$ [kernel[.]org]
> >>>>
> >>>> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> >>>> ---
> >>>> Since v3:
> >>>>    - pass struct map_range_data to map_dt_irq_to_domain
> >>>>    - remove redundant check from map_range_to_domain
> >>>>    - fix handle_device's .skip_mapping
> >>>> Since v2:
> >>>>    - removed check in map_range_to_domain for PCI_DEV
> >>>>      and moved it to handle_device, so the code is
> >>>>      simpler
> >>>>    - s/map_pci_bridge/skip_mapping
> >>>>    - extended comment in pci_host_bridge_mappings
> >>>>    - minor code restructure in construct_dom0
> >>>>    - s/.need_p2m_mapping/.need_p2m_hwdom_mapping and related
> >>>>      callbacks
> >>>>    - unsigned int i; in pci_host_bridge_mappings
> >>>> Since v1:
> >>>>    - Added better description of why and what needs to be mapped into
> >>>>      Domain-0's p2m and what doesn't
> >>>>    - Do not do any mappings for PCI devices while traversing the DT
> >>>>    - Walk all the bridges and make required mappings in one go
> >>>> ---
> >>>>    xen/arch/arm/domain_build.c        | 50 ++++++++++++++++--------------
> >>>>    xen/arch/arm/pci/ecam.c            | 14 +++++++++
> >>>>    xen/arch/arm/pci/pci-host-common.c | 49 +++++++++++++++++++++++++++++
> >>>>    xen/arch/arm/pci/pci-host-zynqmp.c |  1 +
> >>>>    xen/include/asm-arm/pci.h          | 10 ++++++
> >>>>    xen/include/asm-arm/setup.h        | 13 ++++++++
> >>>>    6 files changed, 114 insertions(+), 23 deletions(-)
> >>>>
> >>>> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
> >>>> index 8739e3285ef4..2a3c641476bd 100644
> >>>> --- a/xen/arch/arm/domain_build.c
> >>>> +++ b/xen/arch/arm/domain_build.c
> >>>> @@ -10,7 +10,6 @@
> >>>>    #include <asm/regs.h>
> >>>>    #include <xen/errno.h>
> >>>>    #include <xen/err.h>
> >>>> -#include <xen/device_tree.h>
> >>>>    #include <xen/libfdt/libfdt.h>
> >>>>    #include <xen/guest_access.h>
> >>>>    #include <xen/iocap.h>
> >>>> @@ -51,12 +50,6 @@ static int __init parse_dom0_mem(const char *s)
> >>>>    }
> >>>>    custom_param("dom0_mem", parse_dom0_mem);
> >>>>    
> >>>> -struct map_range_data
> >>>> -{
> >>>> -    struct domain *d;
> >>>> -    p2m_type_t p2mt;
> >>>> -};
> >>>> -
> >>>>    /* Override macros from asm/page.h to make them work with mfn_t */
> >>>>    #undef virt_to_mfn
> >>>>    #define virt_to_mfn(va) _mfn(__virt_to_mfn(va))
> >>>> @@ -1641,10 +1634,11 @@ static int __init map_dt_irq_to_domain(const struct dt_device_node *dev,
> >>>>                                           const struct dt_irq *dt_irq,
> >>>>                                           void *data)
> >>>>    {
> >>>> -    struct domain *d = data;
> >>>> +    struct map_range_data *mr_data = data;
> >>>> +    struct domain *d = mr_data->d;
> >>>>        unsigned int irq = dt_irq->irq;
> >>>>        int res;
> >>>> -    bool need_mapping = !dt_device_for_passthrough(dev);
> >>>> +    bool need_mapping = !mr_data->skip_mapping;
> >>>>    
> >>>>        if ( irq < NR_LOCAL_IRQS )
> >>>>        {
> >>>> @@ -1668,13 +1662,12 @@ static int __init map_dt_irq_to_domain(const struct dt_device_node *dev,
> >>>>        return 0;
> >>>>    }
> >>>>    
> >>>> -static int __init map_range_to_domain(const struct dt_device_node *dev,
> >>>> -                                      u64 addr, u64 len,
> >>>> -                                      void *data)
> >>>> +int __init map_range_to_domain(const struct dt_device_node *dev,
> >>>> +                               u64 addr, u64 len, void *data)
> >>>>    {
> >>>>        struct map_range_data *mr_data = data;
> >>>>        struct domain *d = mr_data->d;
> >>>> -    bool need_mapping = !dt_device_for_passthrough(dev);
> >>>> +    bool need_mapping = !mr_data->skip_mapping;
> >>>>        int res;
> >>>>    
> >>>>        /*
> >>>> @@ -1726,23 +1719,21 @@ static int __init map_range_to_domain(const struct dt_device_node *dev,
> >>>>     * then we may need to perform additional mappings in order to make
> >>>>     * the child resources available to domain 0.
> >>>>     */
> >>>> -static int __init map_device_children(struct domain *d,
> >>>> -                                      const struct dt_device_node *dev,
> >>>> -                                      p2m_type_t p2mt)
> >>>> +static int __init map_device_children(const struct dt_device_node *dev,
> >>>> +                                      struct map_range_data *mr_data)
> >>>>    {
> >>>> -    struct map_range_data mr_data = { .d = d, .p2mt = p2mt };
> >>>> -    int ret;
> >>>> -
> >>>>        if ( dt_device_type_is_equal(dev, "pci") )
> >>>>        {
> >>>> +        int ret;
> >>>> +
> >>>>            dt_dprintk("Mapping children of %s to guest\n",
> >>>>                       dt_node_full_name(dev));
> >>>>    
> >>>> -        ret = dt_for_each_irq_map(dev, &map_dt_irq_to_domain, d);
> >>>> +        ret = dt_for_each_irq_map(dev, &map_dt_irq_to_domain, mr_data);
> >>>>            if ( ret < 0 )
> >>>>                return ret;
> >>>>    
> >>>> -        ret = dt_for_each_range(dev, &map_range_to_domain, &mr_data);
> >>>> +        ret = dt_for_each_range(dev, &map_range_to_domain, mr_data);
> >>>>            if ( ret < 0 )
> >>>>                return ret;
> >>>>        }
> >>>> @@ -1823,6 +1814,13 @@ static int __init handle_device(struct domain *d, struct dt_device_node *dev,
> >>>>        int res;
> >>>>        u64 addr, size;
> >>>>        bool need_mapping = !dt_device_for_passthrough(dev);
> >>>> +    struct map_range_data mr_data = {
> >>>> +        .d = d,
> >>>> +        .p2mt = p2mt,
> >>>> +        .skip_mapping = !need_mapping ||
> >>>> +                        (is_pci_passthrough_enabled() &&
> >>>> +                         (device_get_class(dev) == DEVICE_PCI))
> >>>> +    };
> >>> I would prefer if we did this:
> >>>
> >>> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
> >>> index 2a3c641476..1e7cdd11c7 100644
> >>> --- a/xen/arch/arm/domain_build.c
> >>> +++ b/xen/arch/arm/domain_build.c
> >>> @@ -1813,13 +1813,13 @@ static int __init handle_device(struct domain *d, struct dt_device_node *dev,
> >>>        unsigned int i;
> >>>        int res;
> >>>        u64 addr, size;
> >>> -    bool need_mapping = !dt_device_for_passthrough(dev);
> >>> +    bool need_mapping = !dt_device_for_passthrough(dev) &&
> >>> +                        !(is_pci_passthrough_enabled() &&
> >>> +                          (device_get_class(dev) == DEVICE_PCI))
> >>>        struct map_range_data mr_data = {
> >>>            .d = d,
> >>>            .p2mt = p2mt,
> >>> -        .skip_mapping = !need_mapping ||
> >>> -                        (is_pci_passthrough_enabled() &&
> >>> -                         (device_get_class(dev) == DEVICE_PCI))
> >>> +        .skip_mapping = !need_mapping
> >>>        };
> >>>    
> >>>        naddr = dt_number_of_address(dev);
> >>>
> >>>
> >>> This actually makes a difference because otherwise
> >>> handle_device_interrupts could still be called with need_mapping ==
> >>> true for PCI devices.
> >> And this is totally fine. Remember the name of the patch: we do not
> >> want to map memory, but interrupts are still needed for the bridge to
> >> function in Dom0. The same as it needs all, but "cfg" from "regs".
> >> So, need_mapping == true for interrupts is what we want: legacy INTx
> >> are not supported by design and only MSI/MSI-X are supported.
> > Ah, makes sense, I momentarily lost sight of that. Could you please add
> > an in-code comment to explain it, something like:
> >
> > /*
> >   * For PCI passthrough we need to remap only interrupts to Dom0. MMIO
> >   * regions of the PCIe Root Complex and PCIe aperture should not be
> >   * mapped automatically to Dom0.
> >   */
> > struct map_range_data mr_data = {
> >          .d = d,
> >          .p2mt = p2mt,
> >          .skip_mapping = !need_mapping ||
> >                          (is_pci_passthrough_enabled() &&
> >                           (device_get_class(dev) == DEVICE_PCI))
> >      };
> Sure will add this so we don't step on it in the future.
> Other than this and the missed comment below do you think
> that patch is good to go now?

Yes, I think it is good to go. I plan to add my reviewed-by next time
just to double-check that everything is as expected.


> >>> What do you think?  One more comment below.
> >>>
> >>>
> >>>>        naddr = dt_number_of_address(dev);
> >>>>    
> >>>> @@ -1862,7 +1860,6 @@ static int __init handle_device(struct domain *d, struct dt_device_node *dev,
> >>>>        /* Give permission and map MMIOs */
> >>>>        for ( i = 0; i < naddr; i++ )
> >>>>        {
> >>>> -        struct map_range_data mr_data = { .d = d, .p2mt = p2mt };
> >>>>            res = dt_device_get_address(dev, i, &addr, &size);
> >>>>            if ( res )
> >>>>            {
> >>>> @@ -1876,7 +1873,7 @@ static int __init handle_device(struct domain *d, struct dt_device_node *dev,
> >>>>                return res;
> >>>>        }
> >>>>    
> >>>> -    res = map_device_children(d, dev, p2mt);
> >>>> +    res = map_device_children(dev, &mr_data);
> >>>>        if ( res )
> >>>>            return res;
> >>>>    
> >>>> @@ -3034,7 +3031,14 @@ static int __init construct_dom0(struct domain *d)
> >>>>            return rc;
> >>>>    
> >>>>        if ( acpi_disabled )
> >>>> +    {
> >>>>            rc = prepare_dtb_hwdom(d, &kinfo);
> >>>> +        if ( rc < 0 )
> >>>> +            return rc;
> >>>> +#ifdef CONFIG_HAS_PCI
> >>>> +        rc = pci_host_bridge_mappings(d, p2m_mmio_direct_c);
> >>>> +#endif
> >>>> +    }
> >>>>        else
> >>>>            rc = prepare_acpi(d, &kinfo);
> >>>>    
> >>>> diff --git a/xen/arch/arm/pci/ecam.c b/xen/arch/arm/pci/ecam.c
> >>>> index 602d00799c8d..b81620074a91 100644
> >>>> --- a/xen/arch/arm/pci/ecam.c
> >>>> +++ b/xen/arch/arm/pci/ecam.c
> >>>> @@ -40,6 +40,19 @@ void __iomem *pci_ecam_map_bus(struct pci_host_bridge *bridge,
> >>>>        return base + (PCI_DEVFN2(sbdf.bdf) << devfn_shift) + where;
> >>>>    }
> >>>>    
> >>>> +bool pci_ecam_need_p2m_hwdom_mapping(struct domain *d,
> >>>> +                                     struct pci_host_bridge *bridge,
> >>>> +                                     uint64_t addr)
> >>>> +{
> >>>> +    struct pci_config_window *cfg = bridge->cfg;
> >>>> +
> >>>> +    /*
> >>>> +     * We do not want ECAM address space to be mapped in Domain-0's p2m,
> >>>> +     * so we can trap access to it.
> >>>> +     */
> >>>> +    return cfg->phys_addr != addr;
> >>>> +}
> >>>> +
> >>>>    /* ECAM ops */
> >>>>    const struct pci_ecam_ops pci_generic_ecam_ops = {
> >>>>        .bus_shift  = 20,
> >>>> @@ -47,6 +60,7 @@ const struct pci_ecam_ops pci_generic_ecam_ops = {
> >>>>            .map_bus                = pci_ecam_map_bus,
> >>>>            .read                   = pci_generic_config_read,
> >>>>            .write                  = pci_generic_config_write,
> >>>> +        .need_p2m_hwdom_mapping = pci_ecam_need_p2m_hwdom_mapping,
> >>>>        }
> >>>>    };
> >>>>    
> >>>> diff --git a/xen/arch/arm/pci/pci-host-common.c b/xen/arch/arm/pci/pci-host-common.c
> >>>> index 1eb4daa87365..085f08e23e0c 100644
> >>>> --- a/xen/arch/arm/pci/pci-host-common.c
> >>>> +++ b/xen/arch/arm/pci/pci-host-common.c
> >>>> @@ -18,6 +18,7 @@
> >>>>    
> >>>>    #include <xen/init.h>
> >>>>    #include <xen/pci.h>
> >>>> +#include <asm/setup.h>
> >>>>    #include <xen/rwlock.h>
> >>>>    #include <xen/sched.h>
> >>>>    #include <xen/vmap.h>
> >>>> @@ -320,6 +321,54 @@ int pci_host_get_num_bridges(void)
> >>>>        return count;
> >>>>    }
> >>>>    
> >>>> +int __init pci_host_bridge_mappings(struct domain *d, p2m_type_t p2mt)
> >>>> +{
> >>>> +    struct pci_host_bridge *bridge;
> >>>> +    struct map_range_data mr_data = {
> >>>> +        .d = d,
> >>>> +        .p2mt = p2mt,
> >>>> +        .skip_mapping = false
> >>>> +    };
> >>>> +
> >>>> +    /*
> >>>> +     * For each PCI host bridge we need to only map those ranges
> >>>> +     * which are used by Domain-0 to properly initialize the bridge,
> >>>> +     * e.g. we do not want to map ECAM configuration space which lives in
> >>>> +     * "reg" or "assigned-addresses" device tree property, but we want to
> >>>> +     * map other regions of the host bridge. The PCI aperture defined by
> >>>> +     * the "ranges" device tree property should also be skipped.
> >>>> +     */
> >>>> +    list_for_each_entry( bridge, &pci_host_bridges, node )
> >>>> +    {
> >>>> +        const struct dt_device_node *dev = bridge->dt_node;
> >>>> +        unsigned int i;
> >>>> +
> >>>> +        for ( i = 0; i < dt_number_of_address(dev); i++ )
> >>>> +        {
> >>>> +            uint64_t addr, size;
> >>>> +            int err;
> >>>> +
> >>>> +            err = dt_device_get_address(dev, i, &addr, &size);
> >>>> +            if ( err )
> >>>> +            {
> >>>> +                printk(XENLOG_ERR
> >>>> +                       "Unable to retrieve address range index=%u for %s\n",
> >>>> +                       i, dt_node_full_name(dev));
> >>>> +                return err;
> >>>> +            }
> >>>> +
> >>>> +            if ( bridge->ops->need_p2m_hwdom_mapping(d, bridge, addr) )
> >>>> +            {
> >>>> +                err = map_range_to_domain(dev, addr, size, &mr_data);
> >>>> +                if ( err )
> >>>> +                    return err;
> >>>> +            }
> >>>> +        }
> >>>> +    }
> >>>> +
> >>>> +    return 0;
> >>>> +}
> >>>> +
> >>>>    /*
> >>>>     * Local variables:
> >>>>     * mode: C
> >>>> diff --git a/xen/arch/arm/pci/pci-host-zynqmp.c b/xen/arch/arm/pci/pci-host-zynqmp.c
> >>>> index 61a9807d3d58..6ad2b31e810d 100644
> >>>> --- a/xen/arch/arm/pci/pci-host-zynqmp.c
> >>>> +++ b/xen/arch/arm/pci/pci-host-zynqmp.c
> >>>> @@ -34,6 +34,7 @@ const struct pci_ecam_ops nwl_pcie_ops = {
> >>>>            .map_bus                = pci_ecam_map_bus,
> >>>>            .read                   = pci_generic_config_read,
> >>>>            .write                  = pci_generic_config_write,
> >>>> +        .need_p2m_hwdom_mapping = pci_ecam_need_p2m_hwdom_mapping,
> >>>>        }
> >>>>    };
> >>>>    
> >>>> diff --git a/xen/include/asm-arm/pci.h b/xen/include/asm-arm/pci.h
> >>>> index a62d8bc60086..d9a3c2a4f3b3 100644
> >>>> --- a/xen/include/asm-arm/pci.h
> >>>> +++ b/xen/include/asm-arm/pci.h
> >>>> @@ -17,6 +17,8 @@
> >>>>    
> >>>>    #ifdef CONFIG_HAS_PCI
> >>>>    
> >>>> +#include <asm/p2m.h>
> >>>> +
> >>>>    #define pci_to_dev(pcidev) (&(pcidev)->arch.dev)
> >>>>    
> >>>>    extern bool_t pci_passthrough_enabled;
> >>>> @@ -73,6 +75,9 @@ struct pci_ops {
> >>>>                    uint32_t reg, uint32_t len, uint32_t *value);
> >>>>        int (*write)(struct pci_host_bridge *bridge, pci_sbdf_t sbdf,
> >>>>                     uint32_t reg, uint32_t len, uint32_t value);
> >>>> +    bool (*need_p2m_hwdom_mapping)(struct domain *d,
> >>>> +                                   struct pci_host_bridge *bridge,
> >>>> +                                   uint64_t addr);
> >>>>    };
> >>>>    
> >>>>    /*
> >>>> @@ -96,6 +101,9 @@ int pci_generic_config_write(struct pci_host_bridge *bridge, pci_sbdf_t sbdf,
> >>>>                                 uint32_t reg, uint32_t len, uint32_t value);
> >>>>    void __iomem *pci_ecam_map_bus(struct pci_host_bridge *bridge,
> >>>>                                   pci_sbdf_t sbdf, uint32_t where);
> >>>> +bool pci_ecam_need_p2m_hwdom_mapping(struct domain *d,
> >>>> +                                     struct pci_host_bridge *bridge,
> >>>> +                                     uint64_t addr);
> >>>>    struct pci_host_bridge *pci_find_host_bridge(uint16_t segment, uint8_t bus);
> >>>>    int pci_get_host_bridge_segment(const struct dt_device_node *node,
> >>>>                                    uint16_t *segment);
> >>>> @@ -113,6 +121,8 @@ int pci_host_iterate_bridges(struct domain *d,
> >>>>                                            struct pci_host_bridge *bridge));
> >>>>    int pci_host_get_num_bridges(void);
> >>>>    
> >>>> +int pci_host_bridge_mappings(struct domain *d, p2m_type_t p2mt);
> >>>> +
> >>>>    #else   /*!CONFIG_HAS_PCI*/
> >>>>    
> >>>>    struct arch_pci_dev { };
> >>>> diff --git a/xen/include/asm-arm/setup.h b/xen/include/asm-arm/setup.h
> >>>> index 95da0b7ab9cd..5b30135fda38 100644
> >>>> --- a/xen/include/asm-arm/setup.h
> >>>> +++ b/xen/include/asm-arm/setup.h
> >>>> @@ -2,6 +2,8 @@
> >>>>    #define __ARM_SETUP_H_
> >>>>    
> >>>>    #include <public/version.h>
> >>>> +#include <asm/p2m.h>
> >>>> +#include <xen/device_tree.h>
> >>>>    
> >>>>    #define MIN_FDT_ALIGN 8
> >>>>    #define MAX_FDT_SIZE SZ_2M
> >>>> @@ -77,6 +79,14 @@ struct bootinfo {
> >>>>    #endif
> >>>>    };
> >>>>    
> >>>> +struct map_range_data
> >>>> +{
> >>>> +    struct domain *d;
> >>>> +    p2m_type_t p2mt;
> >>>> +    /* Set if mappings for PCI host bridges must not be skipped. */
> >>> This comment still needs updating.
> >> Sorry, I missed this one
> >>>
> >>>> +    bool skip_mapping;
> >>>> +};
> >>>> +
> >>>>    extern struct bootinfo bootinfo;
> >>>>    
> >>>>    extern domid_t max_init_domid;
> >>>> @@ -124,6 +134,9 @@ void device_tree_get_reg(const __be32 **cell, u32 address_cells,
> >>>>    u32 device_tree_get_u32(const void *fdt, int node,
> >>>>                            const char *prop_name, u32 dflt);
> >>>>    
> >>>> +int map_range_to_domain(const struct dt_device_node *dev,
> >>>> +                        u64 addr, u64 len, void *data);
> >>>> +
> >>>>    #endif
> >>>>    /*
> >>>>     * Local variables:
> >>>> -- 
> >>>> 2.25.1
> >>>>
> 


From xen-devel-bounces@lists.xenproject.org Wed Oct 06 21:55:15 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Oct 2021 21:55:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.203183.358249 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYEsY-0006IL-Ub; Wed, 06 Oct 2021 21:55:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 203183.358249; Wed, 06 Oct 2021 21:55:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYEsY-0006IE-Qz; Wed, 06 Oct 2021 21:55:10 +0000
Received: by outflank-mailman (input) for mailman id 203183;
 Wed, 06 Oct 2021 21:55:10 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mYEsY-0006I3-4g; Wed, 06 Oct 2021 21:55:10 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mYEsX-0004zM-Uo; Wed, 06 Oct 2021 21:55:09 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mYEsX-0002p9-HZ; Wed, 06 Oct 2021 21:55:09 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mYEsX-0007ZG-FK; Wed, 06 Oct 2021 21:55:09 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=NahL8leqGO7Sxrzl6OrF0HwILOTmNcnCFJ3G1owjOa0=; b=JSSFPCYnyslJElhrAspaZgRRdk
	vCzRT5coWahEv03h2HCBQ0IJjhSzLUg2bK0GxoMu88JnTkIcUKtPLoQ9ts1ei7SICJJkCvYXWQpTt
	lISrVqQEEKYfT3KtqXWbxv2JXGfiRlCllPX2RMTgQR9KqEjPFci/srLk/3dCQvBEIdGI=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165386-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.14-testing test] 165386: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-4.14-testing:test-arm64-arm64-libvirt-raw:guest-start:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=ba45e99aa4da5dae6f42819ceb9372764fea410d
X-Osstest-Versions-That:
    xen=9f2b6c5ec2ded4c1caf149743e862c5f15d6d083
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 06 Oct 2021 21:55:09 +0000

flight 165386 xen-4.14-testing real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165386/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-libvirt-raw 13 guest-start             fail baseline untested
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail baseline untested
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 164942
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 164942
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 164942
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 164942
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 164942
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 164942
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 164942
 test-armhf-armhf-xl-rtds     18 guest-start/debian.repeat    fail  like 164942
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 164942
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 164942
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 164942
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 164942
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass

version targeted for testing:
 xen                  ba45e99aa4da5dae6f42819ceb9372764fea410d
baseline version:
 xen                  9f2b6c5ec2ded4c1caf149743e862c5f15d6d083

Last test of basis   164942  2021-09-10 12:37:25 Z   26 days
Testing same since   165386  2021-10-05 19:06:40 Z    1 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Ivan Kardykov <kardykov@tabit.pro>
  Jan Beulich <jbeulich@suse.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 fail    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   9f2b6c5ec2..ba45e99aa4  ba45e99aa4da5dae6f42819ceb9372764fea410d -> stable-4.14


From xen-devel-bounces@lists.xenproject.org Wed Oct 06 22:42:33 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Oct 2021 22:42:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.203195.358263 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYFcB-0002yu-QC; Wed, 06 Oct 2021 22:42:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 203195.358263; Wed, 06 Oct 2021 22:42:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYFcB-0002yn-Mh; Wed, 06 Oct 2021 22:42:19 +0000
Received: by outflank-mailman (input) for mailman id 203195;
 Wed, 06 Oct 2021 22:42:18 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HdqS=O2=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1mYFcA-0002yh-6P
 for xen-devel@lists.xenproject.org; Wed, 06 Oct 2021 22:42:18 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 56a52a04-6b15-4334-8893-0f808bdae279;
 Wed, 06 Oct 2021 22:42:17 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id 464D060FD8;
 Wed,  6 Oct 2021 22:42:16 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 56a52a04-6b15-4334-8893-0f808bdae279
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1633560136;
	bh=MxQr0kqs9NYKxf+SU5Ptr5l25m00+1tS9Cs9IznIuZI=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=e3CjZOvmC3CN6/uH4ZL+sPZAyQUWnPO1Fgus0sSOLREiPOgvpGmylf07+dorIVFQS
	 ugFOrsMfS45NQme9r0UP7G6ej5PKsbQHrXhP5C7MF/8NTvUe8hHIT1Z5cMr3qhSVFb
	 mGiM/Ybu25rcR09jSCjDIZeLwxhA4HmBreIVlo2+DMeJcKH2OnAt+gnOZZ04uEiGg8
	 /+1PVAvxWUpWm2FlYa8/86HtC24Ft+E35iTlXZQ1HMjC4hhSlpxzB5Qn5FM07ifVlz
	 GCkUYfKDvTmnPy5QUp9ZYUe9aPZpm4+xRknXAIkP5c/tyFZPnblTSTUPRf9AVEuhT8
	 /A9nZNrDi/JQA==
Date: Wed, 6 Oct 2021 15:42:14 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Julien Grall <julien@xen.org>
cc: Stefano Stabellini <sstabellini@kernel.org>, 
    Oleksandr Tyshchenko <olekstysh@gmail.com>, xen-devel@lists.xenproject.org, 
    Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, 
    Volodymyr Babchuk <volodymyr_babchuk@epam.com>, tee-dev@lists.linaro.org
Subject: Re: [PATCH] xen/arm: optee: Fix arm_smccc_smc's a0 for
 OPTEE_SMC_DISABLE_SHM_CACHE
In-Reply-To: <e612c225-cda6-2c41-bf20-73314ebceb02@xen.org>
Message-ID: <alpine.DEB.2.21.2110061537310.3209@sstabellini-ThinkPad-T480s>
References: <1632750850-28600-1-git-send-email-olekstysh@gmail.com> <alpine.DEB.2.21.2109272151260.5022@sstabellini-ThinkPad-T480s> <e612c225-cda6-2c41-bf20-73314ebceb02@xen.org>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Wed, 6 Oct 2021, Julien Grall wrote:
> Hi Stefano,
> 
> On 28/09/2021 06:52, Stefano Stabellini wrote:
> > On Mon, 27 Sep 2021, Oleksandr Tyshchenko wrote:
> > > From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> > > 
> > > Fix a possible copy-paste error in arm_smccc_smc's first argument (a0)
> > > for OPTEE_SMC_DISABLE_SHM_CACHE case.
> > > 
> > > This error causes Linux > v5.14-rc5
> > > (b5c10dd04b7418793517e3286cde5c04759a86de
> > > optee: Clear stale cache entries during initialization) to stuck
> > > repeatedly issuing OPTEE_SMC_DISABLE_SHM_CACHE call and waiting for
> > > the result to be OPTEE_SMC_RETURN_ENOTAVAIL which will never happen.
> > > 
> > > Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> > 
> > Acked-by: Stefano Stabellini <sstabellini@kernel.org>
> > 
> > I added Fixes: and Backport: tags to the commit
> Per SUPPORT.MD, OP-TEE is still a technical preview. So I would argue that we
> should not do any backport because the feature itself is not officially
> considered supported.

Good point!


> That said, what's missing to make the feature officially supported?

If Oleksandr is also happy to make OP-TEE support in Xen "Supported" in
SUPPORT.md I'd be happy with that too. Specifically I suggest to change
it to:

Status: Supported, not security supported

Security Support is a bit of a heavy process and I am thinking that
"Supported, not security supported" would be an excellent next step.


From xen-devel-bounces@lists.xenproject.org Wed Oct 06 23:54:02 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 06 Oct 2021 23:54:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.203204.358274 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYGjE-0001St-7P; Wed, 06 Oct 2021 23:53:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 203204.358274; Wed, 06 Oct 2021 23:53:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYGjE-0001Sm-2F; Wed, 06 Oct 2021 23:53:40 +0000
Received: by outflank-mailman (input) for mailman id 203204;
 Wed, 06 Oct 2021 23:53:39 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HdqS=O2=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1mYGjD-0001Sg-En
 for xen-devel@lists.xenproject.org; Wed, 06 Oct 2021 23:53:39 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 9fe05511-2700-11ec-bfb3-12813bfff9fa;
 Wed, 06 Oct 2021 23:53:38 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id 2F68760F4F;
 Wed,  6 Oct 2021 23:53:37 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9fe05511-2700-11ec-bfb3-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1633564417;
	bh=2ew6kwRO9IN7xHy0/aVljndUL9hn4l2DPhnwBkGgJgU=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=qut7pVVHnLHrCJ4REXA42HLANJ/fUCy58TkpMm3hPxNjOT/6ROZfpU2Ug+3hWqAi0
	 Q82E1wjyOfyzRi0GME+/Pwtq2ZCeUDz80JVFW3E++fxOH8Dg3iAu89Y0V6TgMtZFTH
	 achEyMPey7VxkFQcdoUDeOUigxSI5bFoTLgl9biksrRXpaDQI/ihRwmkDr7HpU6pIC
	 2X8o7mK4XEgjNeQW5HfTCwdH9djObbm0MMG5ECmAKufA6z0vhHo6iNPwkbihAsOOWo
	 M81CpTPaShzF//MEnI4ISR9rM3ACyCQI7QH9Je26aR6skJm0Wlb28OAFqVNJ8UQLSp
	 o+GM+nMouXecQ==
Date: Wed, 6 Oct 2021 16:53:36 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Oleksandr <olekstysh@gmail.com>
cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, 
    Stefano Stabellini <sstabellini@kernel.org>, 
    Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>, 
    Julien Grall <julien@xen.org>, Julien Grall <jgrall@amazon.com>
Subject: Re: [PING] Re: [PATCH] xen/arm: optee: Allocate anonymous domheap
 pages
In-Reply-To: <81f7699b-69c1-da52-a1a7-5000343bf872@gmail.com>
Message-ID: <alpine.DEB.2.21.2110061639050.3209@sstabellini-ThinkPad-T480s>
References: <1630935741-17088-1-git-send-email-olekstysh@gmail.com> <alpine.DEB.2.21.2109231308200.17979@sstabellini-ThinkPad-T480s> <87bl4jrovq.fsf@epam.com> <81f7699b-69c1-da52-a1a7-5000343bf872@gmail.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Wed, 6 Oct 2021, Oleksandr wrote:
> Hello all
> 
> Gentle reminder.
 
Many thanks for the ping, this patch fell off my radar.


 
> On 23.09.21 23:57, Volodymyr Babchuk wrote:
> > Hi Stefano,
> > 
> > Stefano Stabellini <sstabellini@kernel.org> writes:
> > 
> > > On Mon, 6 Sep 2021, Oleksandr Tyshchenko wrote:
> > > > From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> > > > 
> > > > Allocate anonymous domheap pages as there is no strict need to
> > > > account them to a particular domain.
> > > > 
> > > > Since XSA-383 "xen/arm: Restrict the amount of memory that dom0less
> > > > domU and dom0 can allocate" the dom0 cannot allocate memory outside
> > > > of the pre-allocated region. This means if we try to allocate
> > > > non-anonymous page to be accounted to dom0 we will get an
> > > > over-allocation issue when assigning that page to the domain.
> > > > The anonymous page, in turn, is not assigned to any domain.
> > > > 
> > > > CC: Julien Grall <jgrall@amazon.com>
> > > > Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> > > > Acked-by: Volodymyr Babchuk <volodymyr_babchuk@epam.com>
> > > Only one question, which is more architectural: given that these pages
> > > are "unlimited", could the guest exploit the interface somehow to force
> > > Xen to allocate an very high number of anonymous pages?
> > > 
> > > E.g. could a domain call OPTEE_SMC_RPC_FUNC_ALLOC in a loop to force Xen
> > > to exaust all memory pages?
> > Generally, OP-TEE mediator tracks all resources allocated and imposes
> > limits on them.
> > 
> > OPTEE_SMC_RPC_FUNC_ALLOC case is a bit different, because it is issued
> > not by domain, but by OP-TEE itself. As OP-TEE is more trusted piece of
> > system we allow it to request as many buffers as it wants. Also, we know
> > that OP-TEE asks only for one such buffer per every standard call. And
> > number of simultaneous calls is limited by number of OP-TEE threads,
> > which is quite low: typically only two.

So let me repeat it differently to see if I understood correctly:

- OPTEE_SMC_RPC_FUNC_ALLOC is only called by OP-TEE, not by the domain
- OPTEE is trusted and only call it twice anyway

I am OK with this argument, but do we have a check to make sure a domU
cannot issue OPTEE_SMC_RPC_FUNC_ALLOC?


Looking at the patch, there are other two places, in addition to
OPTEE_SMC_RPC_FUNC_ALLOC, where the anonymous memory pages can be
allocated:

1) copy_std_request
2) translate_noncontig

We need to prove that neither 1) or 2) can result in a domU exausting
Xen memory.

In the case of 1), it looks like the memory is freed before returning to
the DomU, right? If so, it should be no problem?

In the case of 2), it looks like the memory could outlive the call where
it is allocated. Is there any kind of protection against issuing
something like OPTEE_MSG_ATTR_TYPE_TMEM_INOUT in a loop? Is it OP-TEE
itself that would refuse the attempt? Thus, the idea is that
do_call_with_arg will return error and we'll just free the memory there?

I cannot see a check for errors returned by do_call_with_arg and memory
freeing done because of that. Sorry I am not super familiar with the
code, I am just trying to make sure we are not offering to DomUs an easy
way to crash the system.

It looks like they could be called from one of the OPTEE operations that
a domU could request? Is there a limit for them?


From xen-devel-bounces@lists.xenproject.org Thu Oct 07 00:00:46 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Oct 2021 00:00:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.203213.358285 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYGq2-0003WH-8x; Thu, 07 Oct 2021 00:00:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 203213.358285; Thu, 07 Oct 2021 00:00:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYGq2-0003WA-5L; Thu, 07 Oct 2021 00:00:42 +0000
Received: by outflank-mailman (input) for mailman id 203213;
 Thu, 07 Oct 2021 00:00:40 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Ti8Z=O3=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1mYGq0-0003W4-A1
 for xen-devel@lists.xenproject.org; Thu, 07 Oct 2021 00:00:40 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 9b0efb76-2701-11ec-bfb3-12813bfff9fa;
 Thu, 07 Oct 2021 00:00:39 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id 7801760F4F;
 Thu,  7 Oct 2021 00:00:38 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9b0efb76-2701-11ec-bfb3-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1633564838;
	bh=yVGEzD0QnY/sQb3XYij716BX+NvfF0pRX14TBpkDD9Y=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=HzYV6O8hbB0PP5yABf02BveurvH6T8n4FpoTgz+tYqznYjkFa4Dz0vftONKPl/R3M
	 N8gNrYHC/OvVNuVrACRUD7si00d1KoApWPeMMRPTiDso8uZGIMHb/wwx9MFQGBvELr
	 fWl6HtjqHCZZ7jGyZ+mSmycmqmOM6zb9Qv1hHbxsTeO3hMoDtDFlo/rp/JPYGknBO5
	 bWhmO7FJc/+cNvxZJ1yzUDVOWNUZpw2ZBBoPblLclFpajCgv9leIvg9bkEEQzKPtq4
	 /NuAzfeAjsb+OrS5M2wGmB05aUr8QwgOBG2MEEd1dz50q6L5s9rdZyiZuoQVb3vyHj
	 VRU9lopQ/a1zQ==
Date: Wed, 6 Oct 2021 17:00:37 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Oleksandr <olekstysh@gmail.com>
cc: Ian Jackson <iwj@xenproject.org>, xen-devel@lists.xenproject.org, 
    Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, Wei Liu <wl@xen.org>, 
    Anthony PERARD <anthony.perard@citrix.com>, 
    Juergen Gross <jgross@suse.com>, 
    Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH V5 2/3] libxl/arm: Add handling of extended regions for
 DomU
In-Reply-To: <224ed316-aac0-3ad4-22a1-efc592e717e2@gmail.com>
Message-ID: <alpine.DEB.2.21.2110061658450.3209@sstabellini-ThinkPad-T480s>
References: <1633519346-3686-1-git-send-email-olekstysh@gmail.com> <1633519346-3686-3-git-send-email-olekstysh@gmail.com> <24925.35278.762786.539238@mariner.uk.xensource.com> <224ed316-aac0-3ad4-22a1-efc592e717e2@gmail.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Wed, 6 Oct 2021, Oleksandr wrote:
> On 06.10.21 14:34, Ian Jackson wrote:
> 
> Hi Ian
> 
> > Oleksandr Tyshchenko writes ("[PATCH V5 2/3] libxl/arm: Add handling of
> > extended regions for DomU"):
> > > The extended region (safe range) is a region of guest physical
> > > address space which is unused and could be safely used to create
> > > grant/foreign mappings instead of wasting real RAM pages from
> > > the domain memory for establishing these mappings.
> > Please forgive me for asking this question now, but: why is this
> > ARM-specific ?
> 
> 
> Sorry, I can't say for sure which x86 mode also suffers from that. I might be
> wrong, but as I understand that x86 in PVH (and HVM?) mode uses unpopulated
> memory ranges (which are unused from Linux PoV, actually everything not yet
> allocated or reserved from "iomem_resource") to create foreign/grant mappings.
> So the real RAM pages are not ballooned out to get an physical address space
> to create these mappings. The problem is that we cannot follow Linux advise
> which memory ranges are unused on Arm for several reasons, this is why this
> patch series makes the hypervisor to start allocating and exposing these
> ranges.

Two more things about this being ARM-specific.

Even if x86 was affected exactly by the same problem, the code to expose
the safe memory ranges to DomU is arch-specific (currently device tree.)

Also the code to calculate the safe memory ranges is arch-specific as it
depends on the DomU memory layout which is arch-specific.


From xen-devel-bounces@lists.xenproject.org Thu Oct 07 00:05:53 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Oct 2021 00:05:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.203222.358296 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYGuz-0004B5-R0; Thu, 07 Oct 2021 00:05:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 203222.358296; Thu, 07 Oct 2021 00:05:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYGuz-0004Ax-Nr; Thu, 07 Oct 2021 00:05:49 +0000
Received: by outflank-mailman (input) for mailman id 203222;
 Thu, 07 Oct 2021 00:05:49 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Ti8Z=O3=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1mYGuz-0004Ar-91
 for xen-devel@lists.xenproject.org; Thu, 07 Oct 2021 00:05:49 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id b29e4874-3b25-489b-89a8-02544800e891;
 Thu, 07 Oct 2021 00:05:48 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id DF2A8611AE;
 Thu,  7 Oct 2021 00:05:46 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b29e4874-3b25-489b-89a8-02544800e891
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1633565147;
	bh=RFun/EXF6Yo5YOmS5cvmtnE5CXekcf4VjcqYO76nN3Q=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=Enbmg8P+SLo3oqyLkjdRi+X2IJO00Gvb3aCSBGTlyWp8k7Oj0NSMAT6thpnus32Mi
	 rCoqYHPzYF2wuIX6i8m6qJw2UsldPJZwyhrIV8Z4t5dA3Uc85ta+Q1Z2h43E1nC3E4
	 06JO0t9oFVtot0AKkq4xSAV46l97Jtg+QVojtLTwh3QEF15gbG5WowkFRNGrPLzUUi
	 zy37sPreS/r8lZN1dnUNBTfKsKXl67cpl0P/Plp9gJMuB/aJ/YmQ8jKFvpe4qZEm4f
	 ABDv+oQS2h+BPzn9Q2AOQyIJYhJweoPDM+Ph6ozLawZz4EzYP3oChahGQLaD4vT2DB
	 eepVlQoBpvcRQ==
Date: Wed, 6 Oct 2021 17:05:45 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Rahul Singh <rahul.singh@arm.com>
cc: xen-devel@lists.xenproject.org, bertrand.marquis@arm.com, 
    Andre.Przywara@arm.com, Stefano Stabellini <sstabellini@kernel.org>, 
    Julien Grall <julien@xen.org>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, 
    Andrew Cooper <andrew.cooper3@citrix.com>, 
    George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>, 
    Jan Beulich <jbeulich@suse.com>, Wei Liu <wl@xen.org>, 
    =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= <roger.pau@citrix.com>
Subject: Re: [PATCH v5 02/11] xen/arm: Add PHYSDEVOP_pci_device_(*add/remove)
 support for ARM
In-Reply-To: <0dc4423b2e20c1eb40c961b211b18ed041f707b7.1633540842.git.rahul.singh@arm.com>
Message-ID: <alpine.DEB.2.21.2110061704280.3209@sstabellini-ThinkPad-T480s>
References: <cover.1633540842.git.rahul.singh@arm.com> <0dc4423b2e20c1eb40c961b211b18ed041f707b7.1633540842.git.rahul.singh@arm.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Wed, 6 Oct 2021, Rahul Singh wrote:
> Hardware domain is in charge of doing the PCI enumeration and will
> discover the PCI devices and then will communicate to XEN via hyper
> call PHYSDEVOP_pci_device_add(..) to add the PCI devices in XEN.
> 
> Also implement PHYSDEVOP_pci_device_remove(..) to remove the PCI device.
> 
> As most of the code for PHYSDEVOP_pci_device_* is the same between x86
> and ARM, move the code to a common file to avoid duplication.
> 
> There are other PHYSDEVOP_pci_device_* operations to add PCI devices.
> Currently implemented PHYSDEVOP_pci_device_remove(..) and
> PHYSDEVOP_pci_device_add(..) only as those are minimum required to
> support PCI passthrough on ARM.
> 
> Signed-off-by: Rahul Singh <rahul.singh@arm.com>

Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>


> ---
> Change in v5:
> - Move the pci_physdev_op() stub to xen/arch/arm/physdev.c.
> Change in v4:
> - Move file commom/physdev.c to drivers/pci/physdev.c
> - minor comments.
> Change in v3: Fixed minor comment.
> Change in v2:
> - Add support for PHYSDEVOP_pci_device_remove()
> - Move code to common code
> ---
> ---
>  xen/arch/arm/physdev.c        |  6 ++-
>  xen/arch/x86/physdev.c        | 52 +----------------------
>  xen/arch/x86/x86_64/physdev.c |  2 +-
>  xen/drivers/pci/Makefile      |  1 +
>  xen/drivers/pci/physdev.c     | 80 +++++++++++++++++++++++++++++++++++
>  xen/include/public/arch-arm.h |  4 +-
>  xen/include/xen/hypercall.h   |  4 ++
>  7 files changed, 96 insertions(+), 53 deletions(-)
>  create mode 100644 xen/drivers/pci/physdev.c
> 
> diff --git a/xen/arch/arm/physdev.c b/xen/arch/arm/physdev.c
> index e91355fe22..f9aa274dda 100644
> --- a/xen/arch/arm/physdev.c
> +++ b/xen/arch/arm/physdev.c
> @@ -8,13 +8,17 @@
>  #include <xen/lib.h>
>  #include <xen/errno.h>
>  #include <xen/sched.h>
> -#include <asm/hypercall.h>
> +#include <xen/hypercall.h>
>  
>  
>  int do_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
>  {
> +#ifdef CONFIG_HAS_PCI
> +    return pci_physdev_op(cmd, arg);
> +#else
>      gdprintk(XENLOG_DEBUG, "PHYSDEVOP cmd=%d: not implemented\n", cmd);
>      return -ENOSYS;
> +#endif
>  }
>  
>  /*
> diff --git a/xen/arch/x86/physdev.c b/xen/arch/x86/physdev.c
> index 23465bcd00..ea38be8b79 100644
> --- a/xen/arch/x86/physdev.c
> +++ b/xen/arch/x86/physdev.c
> @@ -12,7 +12,7 @@
>  #include <asm/io_apic.h>
>  #include <asm/msi.h>
>  #include <asm/hvm/irq.h>
> -#include <asm/hypercall.h>
> +#include <xen/hypercall.h>
>  #include <public/xen.h>
>  #include <public/physdev.h>
>  #include <xsm/xsm.h>
> @@ -480,54 +480,6 @@ ret_t do_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
>          break;
>      }
>  
> -    case PHYSDEVOP_pci_device_add: {
> -        struct physdev_pci_device_add add;
> -        struct pci_dev_info pdev_info;
> -        nodeid_t node;
> -
> -        ret = -EFAULT;
> -        if ( copy_from_guest(&add, arg, 1) != 0 )
> -            break;
> -
> -        pdev_info.is_extfn = !!(add.flags & XEN_PCI_DEV_EXTFN);
> -        if ( add.flags & XEN_PCI_DEV_VIRTFN )
> -        {
> -            pdev_info.is_virtfn = 1;
> -            pdev_info.physfn.bus = add.physfn.bus;
> -            pdev_info.physfn.devfn = add.physfn.devfn;
> -        }
> -        else
> -            pdev_info.is_virtfn = 0;
> -
> -        if ( add.flags & XEN_PCI_DEV_PXM )
> -        {
> -            uint32_t pxm;
> -            size_t optarr_off = offsetof(struct physdev_pci_device_add, optarr) /
> -                                sizeof(add.optarr[0]);
> -
> -            if ( copy_from_guest_offset(&pxm, arg, optarr_off, 1) )
> -                break;
> -
> -            node = pxm_to_node(pxm);
> -        }
> -        else
> -            node = NUMA_NO_NODE;
> -
> -        ret = pci_add_device(add.seg, add.bus, add.devfn, &pdev_info, node);
> -        break;
> -    }
> -
> -    case PHYSDEVOP_pci_device_remove: {
> -        struct physdev_pci_device dev;
> -
> -        ret = -EFAULT;
> -        if ( copy_from_guest(&dev, arg, 1) != 0 )
> -            break;
> -
> -        ret = pci_remove_device(dev.seg, dev.bus, dev.devfn);
> -        break;
> -    }
> -
>      case PHYSDEVOP_prepare_msix:
>      case PHYSDEVOP_release_msix: {
>          struct physdev_pci_device dev;
> @@ -663,7 +615,7 @@ ret_t do_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
>      }
>  
>      default:
> -        ret = -ENOSYS;
> +        ret = pci_physdev_op(cmd, arg);
>          break;
>      }
>  
> diff --git a/xen/arch/x86/x86_64/physdev.c b/xen/arch/x86/x86_64/physdev.c
> index 0a50cbd4d8..e3cbd5ebcb 100644
> --- a/xen/arch/x86/x86_64/physdev.c
> +++ b/xen/arch/x86/x86_64/physdev.c
> @@ -9,7 +9,7 @@ EMIT_FILE;
>  #include <compat/xen.h>
>  #include <compat/event_channel.h>
>  #include <compat/physdev.h>
> -#include <asm/hypercall.h>
> +#include <xen/hypercall.h>
>  
>  #define do_physdev_op compat_physdev_op
>  
> diff --git a/xen/drivers/pci/Makefile b/xen/drivers/pci/Makefile
> index a98035df4c..972c923db0 100644
> --- a/xen/drivers/pci/Makefile
> +++ b/xen/drivers/pci/Makefile
> @@ -1 +1,2 @@
>  obj-y += pci.o
> +obj-y += physdev.o
> diff --git a/xen/drivers/pci/physdev.c b/xen/drivers/pci/physdev.c
> new file mode 100644
> index 0000000000..4f3e1a96c0
> --- /dev/null
> +++ b/xen/drivers/pci/physdev.c
> @@ -0,0 +1,80 @@
> +
> +#include <xen/guest_access.h>
> +#include <xen/hypercall.h>
> +#include <xen/init.h>
> +
> +#ifndef COMPAT
> +typedef long ret_t;
> +#endif
> +
> +ret_t pci_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
> +{
> +    ret_t ret;
> +
> +    switch ( cmd )
> +    {
> +    case PHYSDEVOP_pci_device_add: {
> +        struct physdev_pci_device_add add;
> +        struct pci_dev_info pdev_info;
> +        nodeid_t node = NUMA_NO_NODE;
> +
> +        ret = -EFAULT;
> +        if ( copy_from_guest(&add, arg, 1) != 0 )
> +            break;
> +
> +        pdev_info.is_extfn = (add.flags & XEN_PCI_DEV_EXTFN);
> +        if ( add.flags & XEN_PCI_DEV_VIRTFN )
> +        {
> +            pdev_info.is_virtfn = true;
> +            pdev_info.physfn.bus = add.physfn.bus;
> +            pdev_info.physfn.devfn = add.physfn.devfn;
> +        }
> +        else
> +            pdev_info.is_virtfn = false;
> +
> +#ifdef CONFIG_NUMA
> +        if ( add.flags & XEN_PCI_DEV_PXM )
> +        {
> +            uint32_t pxm;
> +            size_t optarr_off = offsetof(struct physdev_pci_device_add, optarr) /
> +                                sizeof(add.optarr[0]);
> +
> +            if ( copy_from_guest_offset(&pxm, arg, optarr_off, 1) )
> +                break;
> +
> +            node = pxm_to_node(pxm);
> +        }
> +#endif
> +
> +        ret = pci_add_device(add.seg, add.bus, add.devfn, &pdev_info, node);
> +        break;
> +    }
> +
> +    case PHYSDEVOP_pci_device_remove: {
> +        struct physdev_pci_device dev;
> +
> +        ret = -EFAULT;
> +        if ( copy_from_guest(&dev, arg, 1) != 0 )
> +            break;
> +
> +        ret = pci_remove_device(dev.seg, dev.bus, dev.devfn);
> +        break;
> +    }
> +
> +    default:
> +        ret = -ENOSYS;
> +        break;
> +    }
> +
> +    return ret;
> +}
> +
> +/*
> + * Local variables:
> + * mode: C
> + * c-file-style: "BSD"
> + * c-basic-offset: 4
> + * tab-width: 4
> + * indent-tabs-mode: nil
> + * End:
> + */
> diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h
> index 6b5a5f818a..d46c61fca9 100644
> --- a/xen/include/public/arch-arm.h
> +++ b/xen/include/public/arch-arm.h
> @@ -107,7 +107,9 @@
>   *   All generic sub-operations
>   *
>   *  HYPERVISOR_physdev_op
> - *   No sub-operations are currenty supported
> + *   Exactly these sub-operations are supported:
> + *   PHYSDEVOP_pci_device_add
> + *   PHYSDEVOP_pci_device_remove
>   *
>   *  HYPERVISOR_sysctl
>   *   All generic sub-operations, with the exception of:
> diff --git a/xen/include/xen/hypercall.h b/xen/include/xen/hypercall.h
> index 3771487a30..07b10ec230 100644
> --- a/xen/include/xen/hypercall.h
> +++ b/xen/include/xen/hypercall.h
> @@ -45,6 +45,10 @@ extern long
>  do_platform_op(
>      XEN_GUEST_HANDLE_PARAM(xen_platform_op_t) u_xenpf_op);
>  
> +extern long
> +pci_physdev_op(
> +    int cmd, XEN_GUEST_HANDLE_PARAM(void) arg);
> +
>  /*
>   * To allow safe resume of do_memory_op() after preemption, we need to know
>   * at what point in the page list to resume. For this purpose I steal the
> -- 
> 2.25.1
> 


From xen-devel-bounces@lists.xenproject.org Thu Oct 07 00:26:24 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Oct 2021 00:26:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.203231.358307 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYHEo-0006Z5-Ef; Thu, 07 Oct 2021 00:26:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 203231.358307; Thu, 07 Oct 2021 00:26:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYHEo-0006Yy-Am; Thu, 07 Oct 2021 00:26:18 +0000
Received: by outflank-mailman (input) for mailman id 203231;
 Thu, 07 Oct 2021 00:26:16 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Ti8Z=O3=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1mYHEm-0006Ys-Q6
 for xen-devel@lists.xenproject.org; Thu, 07 Oct 2021 00:26:16 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id d7ac35cd-a01a-4944-bae6-e0a9b92699ea;
 Thu, 07 Oct 2021 00:26:15 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id DA24061177;
 Thu,  7 Oct 2021 00:26:13 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d7ac35cd-a01a-4944-bae6-e0a9b92699ea
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1633566374;
	bh=ug17NFCBcwJJwFzw1jUciyoluhIvLcYdMz4E9Tg5xug=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=bTSDPLNrz1yw748Mmabrm7zki5q7aeOn4gWmUBYR4QymwP91fzDh3EFfiSQ52fh0P
	 LhGs6lBg+5drexuaB3GlZmk4gffsveuWdj+aiiFy8pGipBPixb/sn2CujMXFhUx+9Q
	 ju0+EuPyFI7FBli093/EPpSqq8ce2zG+oUw+iQ0tYFq71bi4Kt3vmgyRi6OxA3XX1E
	 /sZvGh2D6BRn0raN4TAnK6ZxgPZvU4fK9sKpablnAmNKWiyEiw8rtviZ3v6Yb4+Sl5
	 RbnjyEQtthohL5bG6GDVh41Rgr661YtP7x+vtzpmdZtSjcxb8gA0wX0ShH27NvGu8R
	 2bCm7B/4ol+Gw==
Date: Wed, 6 Oct 2021 17:26:12 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Julien Grall <julien@xen.org>, iwj@xenproject.org
cc: Rahul Singh <rahul.singh@arm.com>, xen-devel@lists.xenproject.org, 
    bertrand.marquis@arm.com, Andre.Przywara@arm.com, Wei Liu <wl@xen.org>, 
    Anthony PERARD <anthony.perard@citrix.com>, 
    Juergen Gross <jgross@suse.com>, 
    Stefano Stabellini <sstabellini@kernel.org>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH v5 10/11] arm/libxl: Emulated PCI device tree node in
 libxl
In-Reply-To: <7bdac405-a889-15e1-be19-5876f7253855@xen.org>
Message-ID: <alpine.DEB.2.21.2110061708500.3209@sstabellini-ThinkPad-T480s>
References: <cover.1633540842.git.rahul.singh@arm.com> <b81b5dea800c8fe47071f3dbd20588b1e472fb99.1633540842.git.rahul.singh@arm.com> <7bdac405-a889-15e1-be19-5876f7253855@xen.org>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Wed, 6 Oct 2021, Julien Grall wrote:
> Hi Rahul,
> 
> On 06/10/2021 19:40, Rahul Singh wrote:
> > diff --git a/tools/libs/light/libxl_types.idl
> > b/tools/libs/light/libxl_types.idl
> > index 3f9fff653a..78b1ddf0b8 100644
> > --- a/tools/libs/light/libxl_types.idl
> > +++ b/tools/libs/light/libxl_types.idl
> > @@ -644,6 +644,7 @@ libxl_domain_build_info = Struct("domain_build_info",[
> >         ("arch_arm", Struct(None, [("gic_version", libxl_gic_version),
> >                                  ("vuart", libxl_vuart_type),
> > +                               ("vpci", libxl_defbool),
> 
> I have posted some comments regarding the field in v4. To summarize, AFAICT,
> this option is meant to be only set by libxl but you still let the toolstack
> (e.g. xl, libvirt) to set it.
> 
> If you still want to expose to the toolstack, then I think the option should
> be outside of arch_arm. Otherwise, this should be moved in an internal
> structure (Ian, do you have any suggestion?).


First let me premise that the patch is much better already and Rahul
addessed my request well. However, Julien's point about not wanting to
make a potentially breaking ABI change in libxl is a good one. FYI we
had a few libvirt breakages due to this kind of changes in the past and
I would certainly be happier if we didn't cause another one. And in
general, it is better to avoid changes to the libxl ABI if we can.

I think in this case we can: I looked at the patch and
b_info.arch_arm.vpci is only used within tools/libs/light/libxl_arm.c.
Also, we don't need b_info.arch_arm.vpci if we can access
d_config->num_pcidevs given that the check is just based on
d_config->num_pcidevs.

So the only issue is how to check on d_config->num_pcidevs in
libxl__prepare_dtb. libxl__prepare_dtb takes libxl_domain_build_info as
parameter but with container_of we can retrieve libxl_domain_config and
from there check on num_pcidevs.

Something like the appended (untested). It doesn't need any libxl struct
changes but it requires the introduction of container_of (which is a
simple macro). Alternatively, it would be just as simple to change
libxl__arch_domain_init_hw_description and libxl__prepare_dtb to take a
libxl_domain_config *d_config parameter instead of a
libxl_domain_build_info *info parameter.

Ian, any thoughts?


diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c
index 2be208b99b..ee1176519c 100644
--- a/tools/libs/light/libxl_arm.c
+++ b/tools/libs/light/libxl_arm.c
@@ -102,10 +102,8 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc,
     }
 
     /* Enable VPCI support. */
-    if (d_config->num_pcidevs) {
+    if (d_config->num_pcidevs)
         config->flags |= XEN_DOMCTL_CDF_vpci;
-        libxl_defbool_set(&d_config->b_info.arch_arm.vpci, true);
-    }
 
     return 0;
 }
@@ -976,6 +974,7 @@ static int libxl__prepare_dtb(libxl__gc *gc, libxl_domain_build_info *info,
 
     const libxl_version_info *vers;
     const struct arch_info *ainfo;
+    libxl_domain_config *d_config = container_of(info, libxl_domain_config, b_info);
 
     vers = libxl_get_version_info(CTX);
     if (vers == NULL) return ERROR_FAIL;
@@ -1076,7 +1075,7 @@ next_resize:
         if (info->tee == LIBXL_TEE_TYPE_OPTEE)
             FDT( make_optee_node(gc, fdt) );
 
-        if (libxl_defbool_val(info->arch_arm.vpci))
+        if (d_config->num_pcidevs)
             FDT( make_vpci_node(gc, fdt, ainfo, dom) );
 
         if (pfdt)


From xen-devel-bounces@lists.xenproject.org Thu Oct 07 00:49:45 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Oct 2021 00:49:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.203242.358317 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYHbO-0000fK-Fb; Thu, 07 Oct 2021 00:49:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 203242.358317; Thu, 07 Oct 2021 00:49:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYHbO-0000fD-Cf; Thu, 07 Oct 2021 00:49:38 +0000
Received: by outflank-mailman (input) for mailman id 203242;
 Thu, 07 Oct 2021 00:49:36 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Ti8Z=O3=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1mYHbM-0000f7-MG
 for xen-devel@lists.xenproject.org; Thu, 07 Oct 2021 00:49:36 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 70a4e2f4-2708-11ec-bfb4-12813bfff9fa;
 Thu, 07 Oct 2021 00:49:35 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id A85F560FD7;
 Thu,  7 Oct 2021 00:49:33 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 70a4e2f4-2708-11ec-bfb4-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1633567774;
	bh=TgQCipr1/6sCn/WvsLc2KCBd3gphPXHVqBPbySotee0=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=sl0CWTwPKIegIx+8eBUIPF3iknW07+b+AvNaCsM6oZncY0UPhuWR0I3Kzn7HWMInF
	 V8SfW4jW4rG7y41xSLO2+xvINeZ+faTkzaAQTlKJi0nCH4ZKBz8aflXUKeOLv1mnhF
	 XJQddiMRX5tJnP0p40BJDyMQZnSbjM4E+N/KuzygSs+oQB/xT0VNE1nYWlf8jdqAfa
	 /gflfJl2DZqlw38tfRrS5RJZdX+eUMEO45Fvge7vcaJwzAYoX2v50uoCCyQ7uSGb9x
	 GQFu64Do1YPM+fhSXNBhrIohKLHucQYzITxMYW4qdzS8NL6INiYf9xnUy7YRFrk19S
	 umCmm9N4Qm5RQ==
Date: Wed, 6 Oct 2021 17:49:33 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Oleksandr Tyshchenko <olekstysh@gmail.com>
cc: xen-devel@lists.xenproject.org, 
    Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, 
    Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>, 
    Anthony PERARD <anthony.perard@citrix.com>, 
    Andrew Cooper <andrew.cooper3@citrix.com>, 
    George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>, 
    Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>, 
    Juergen Gross <jgross@suse.com>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH V5 1/3] xen/arm: Introduce gpaddr_bits field to struct
 xen_arch_domainconfig
In-Reply-To: <1633519346-3686-2-git-send-email-olekstysh@gmail.com>
Message-ID: <alpine.DEB.2.21.2110061743300.3209@sstabellini-ThinkPad-T480s>
References: <1633519346-3686-1-git-send-email-olekstysh@gmail.com> <1633519346-3686-2-git-send-email-olekstysh@gmail.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Wed, 6 Oct 2021, Oleksandr Tyshchenko wrote:
> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> 
> We need to pass info about maximum supported guest physical
> address space size to the toolstack on Arm in order to properly
> calculate the base and size of the extended region (safe range)
> for the guest. The extended region is unused address space which
> could be safely used by domain for foreign/grant mappings on Arm.
> The extended region itself will be handled by the subsequent
> patch.
> 
> Currently the same guest physical address space size is used
> for all guests.
> 
> As we add new field to the structure bump the interface version.
> 
> Suggested-by: Julien Grall <jgrall@amazon.com>
> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> ---
> Changes RFC -> V2:
>    - update patch subject/description
>    - replace arch-specific sub-struct with common gpaddr_bits
>      field and update code to reflect that
> 
> Changes V2 -> V3:
>    - make the field uint8_t and add uint8_t pad[7] after
>    - remove leading blanks in libxl.h
> 
> Changes V3 -> V4:
>    - also print gpaddr_bits from output_physinfo()
>    - add Michal's R-b
> 
> Changes V4 -> V5:
>    - update patch subject and description
>    - drop Michal's R-b
>    - pass gpaddr_bits via createdomain domctl
>      (struct xen_arch_domainconfig)
> ---
>  tools/include/libxl.h            | 5 +++++
>  tools/libs/light/libxl_arm.c     | 2 ++
>  tools/libs/light/libxl_types.idl | 1 +
>  xen/arch/arm/domain.c            | 6 ++++++
>  xen/include/public/arch-arm.h    | 5 +++++
>  xen/include/public/domctl.h      | 2 +-
>  6 files changed, 20 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/include/libxl.h b/tools/include/libxl.h
> index b9ba16d..33b4bfb 100644
> --- a/tools/include/libxl.h
> +++ b/tools/include/libxl.h
> @@ -279,6 +279,11 @@
>  #define LIBXL_HAVE_BUILDINFO_ARCH_ARM_TEE 1
>  
>  /*
> + * libxl_domain_build_info has the gpaddr_bits field.
> + */
> +#define LIBXL_HAVE_BUILDINFO_ARCH_ARM_GPADDR_BITS 1
> +
> +/*
>   * LIBXL_HAVE_SOFT_RESET indicates that libxl supports performing
>   * 'soft reset' for domains and there is 'soft_reset' shutdown reason
>   * in enum libxl_shutdown_reason.
> diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c
> index e3140a6..45e0386 100644
> --- a/tools/libs/light/libxl_arm.c
> +++ b/tools/libs/light/libxl_arm.c
> @@ -123,6 +123,8 @@ int libxl__arch_domain_save_config(libxl__gc *gc,
>  
>      state->clock_frequency = config->arch.clock_frequency;
>  
> +    d_config->b_info.arch_arm.gpaddr_bits = config->arch.gpaddr_bits;
> +
>      return 0;
>  }
>  
> diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_types.idl
> index 3f9fff6..39482db 100644
> --- a/tools/libs/light/libxl_types.idl
> +++ b/tools/libs/light/libxl_types.idl
> @@ -644,6 +644,7 @@ libxl_domain_build_info = Struct("domain_build_info",[
>  
>      ("arch_arm", Struct(None, [("gic_version", libxl_gic_version),
>                                 ("vuart", libxl_vuart_type),
> +                               ("gpaddr_bits", uint8),
>                                ])),
>      ("arch_x86", Struct(None, [("msr_relaxed", libxl_defbool),
>                                ])),
> diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
> index 19c756a..dfecc45 100644
> --- a/xen/arch/arm/domain.c
> +++ b/xen/arch/arm/domain.c
> @@ -767,6 +767,12 @@ int arch_domain_create(struct domain *d,
>      if ( is_hardware_domain(d) && (rc = domain_vuart_init(d)) )
>          goto fail;
>  
> +    /*
> +     * Pass maximum IPA bits to the toolstack, currently the same guest
> +     * physical address space size is used for all guests.
> +     */
> +    config->arch.gpaddr_bits = p2m_ipa_bits;

This could also be set in arch_sanitise_domain_config together with
config->arch.gic_version. I prefer if it was done in
arch_sanitise_domain_config but also here is OK I think.

Given that everything else looks fine:

Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>


>      return 0;
>  
>  fail:
> diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h
> index 6b5a5f8..4a01f8b 100644
> --- a/xen/include/public/arch-arm.h
> +++ b/xen/include/public/arch-arm.h
> @@ -333,6 +333,11 @@ struct xen_arch_domainconfig {
>       *
>       */
>      uint32_t clock_frequency;
> +    /*
> +     * OUT
> +     * Guest physical address space size
> +     */
> +    uint8_t gpaddr_bits;
>  };
>  #endif /* __XEN__ || __XEN_TOOLS__ */
>  
> diff --git a/xen/include/public/domctl.h b/xen/include/public/domctl.h
> index 96696e3..f37586e 100644
> --- a/xen/include/public/domctl.h
> +++ b/xen/include/public/domctl.h
> @@ -38,7 +38,7 @@
>  #include "hvm/save.h"
>  #include "memory.h"
>  
> -#define XEN_DOMCTL_INTERFACE_VERSION 0x00000014
> +#define XEN_DOMCTL_INTERFACE_VERSION 0x00000015
>  
>  /*
>   * NB. xen_domctl.domain is an IN/OUT parameter for this operation.
> -- 
> 2.7.4
> 


From xen-devel-bounces@lists.xenproject.org Thu Oct 07 01:29:26 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Oct 2021 01:29:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.203251.358329 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYIDc-00034U-Eh; Thu, 07 Oct 2021 01:29:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 203251.358329; Thu, 07 Oct 2021 01:29:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYIDc-00034N-Ba; Thu, 07 Oct 2021 01:29:08 +0000
Received: by outflank-mailman (input) for mailman id 203251;
 Thu, 07 Oct 2021 01:29:07 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Ti8Z=O3=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1mYIDb-00034H-9w
 for xen-devel@lists.xenproject.org; Thu, 07 Oct 2021 01:29:07 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id be71cd88-2481-440f-a932-aedb1224e304;
 Thu, 07 Oct 2021 01:29:05 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id 0B41D6113E;
 Thu,  7 Oct 2021 01:29:03 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: be71cd88-2481-440f-a932-aedb1224e304
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1633570144;
	bh=BxXnFDZenOp5e1f+nZnyQ9AB4Taz/jlmldlmnzsl1yo=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=sT+3JT0CHufLe0AhL1M3VtskNY1gZL9XtEJAYmRj8ZpQ3HoqgPWz/PGprQZ6spCI3
	 rcgpkYTYO0axbPiLJgZ8NAWBDoVXQFzAvfH6uEYAWGK+NK3N88O+wMDTOMLbuTyBiu
	 4ADo77Fyo7M876vluaJ+lEUUYw2GH745ryCPLDzN5FyRnSn4Dn3f3/fH2sxB7CZylW
	 goO//uX+dYzSzXP7ICHmMBX1WAtNHgADihhjVY5kYcNvTnh+/wszoyqYlGFl1cJxD3
	 eZ6heM11mlSSTxX25NtmnIsCOcb7+z7Zq/agcpci0q48Pq/FQzwqXxlP84qm2HFmu7
	 7UIDwfsjq6GcQ==
Date: Wed, 6 Oct 2021 18:29:03 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Oleksandr Tyshchenko <olekstysh@gmail.com>
cc: xen-devel@lists.xenproject.org, 
    Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, 
    Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>, 
    Anthony PERARD <anthony.perard@citrix.com>, 
    Juergen Gross <jgross@suse.com>, 
    Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH V5 2/3] libxl/arm: Add handling of extended regions for
 DomU
In-Reply-To: <1633519346-3686-3-git-send-email-olekstysh@gmail.com>
Message-ID: <alpine.DEB.2.21.2110061808570.3209@sstabellini-ThinkPad-T480s>
References: <1633519346-3686-1-git-send-email-olekstysh@gmail.com> <1633519346-3686-3-git-send-email-olekstysh@gmail.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Wed, 6 Oct 2021, Oleksandr Tyshchenko wrote:
> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> 
> The extended region (safe range) is a region of guest physical
> address space which is unused and could be safely used to create
> grant/foreign mappings instead of wasting real RAM pages from
> the domain memory for establishing these mappings.
> 
> The extended regions are chosen at the domain creation time and
> advertised to it via "reg" property under hypervisor node in
> the guest device-tree. As region 0 is reserved for grant table
> space (always present), the indexes for extended regions are 1...N.
> If extended regions could not be allocated for some reason,
> Xen doesn't fail and behaves as usual, so only inserts region 0.
> 
> Please note the following limitations:
> - The extended region feature is only supported for 64-bit domain
>   currently.
> - The ACPI case is not covered.
> 
> ***
> 
> The algorithm to choose extended regions for non-direct mapped
> DomU is simpler in comparison with the algorithm for direct mapped
> Dom0. We usually have a lot of unused space above 4GB, and might
> have some unused space below 4GB (depends on guest memory size).
> Try to allocate separate 2MB-aligned extended regions from the first
> (below 4GB) and second (above 4GB) RAM banks taking into the account
> the maximum supported guest physical address space size and the amount
> of memory assigned to the guest. The minimum size of extended region
> the same as for Dom0 (64MB).
> 
> Suggested-by: Julien Grall <jgrall@amazon.com>
> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> ---
> ! Stefano, Ian, Michal I dropped your A-b/R-b. I decided to change patch
> to make it more functional !
> 
> Changes RFC -> V2:
>    - update patch description
>    - drop uneeded "extended-region" DT property
>    - clear reg array in finalise_ext_region() and add a TODO
> 
> Changes V2 -> V3:
>    - update patch description, comments in code
>    - only pick up regions with size >= 64MB
>    - move the region calculation to make_hypervisor_node() and drop
>      finalise_ext_region()
>    - extend the list of arguments for make_hypervisor_node()
>    - do not show warning for 32-bit domain
>    - change the region alignment from 1GB to 2MB
>    - move EXT_REGION_SIZE to public/arch-arm.h
> 
> Changes V3 -> V4:
>    - add R-b, A-b and T-b
> 
> Changes V4 -> V5:
>    - update patch description and comments in code
>    - reflect changes done in previous patch to pass gpaddr_bits
>      via createdomain domctl (struct xen_arch_domainconfig)
>    - drop R-b, A-b and T-b
>    - drop limit for maximum extended region size (128GB)
>    - try to also allocate region below 4GB, optimize code
>      for calculating extended regions
> ---
>  tools/libs/light/libxl_arm.c  | 80 ++++++++++++++++++++++++++++++++++++++++---
>  xen/include/public/arch-arm.h |  2 ++
>  2 files changed, 77 insertions(+), 5 deletions(-)
> 
> diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c
> index 45e0386..cd743f7 100644
> --- a/tools/libs/light/libxl_arm.c
> +++ b/tools/libs/light/libxl_arm.c
> @@ -600,9 +600,21 @@ static int make_timer_node(libxl__gc *gc, void *fdt,
>      return 0;
>  }
>  
> +#define ALIGN_UP_TO_2MB(x)   (((x) + MB(2) - 1) & (~(MB(2) - 1)))
> +
>  static int make_hypervisor_node(libxl__gc *gc, void *fdt,
> -                                const libxl_version_info *vers)
> +                                const libxl_version_info *vers,
> +                                const libxl_domain_build_info *b_info,
> +                                const struct xc_dom_image *dom)
>  {
> +    uint64_t region_size[GUEST_RAM_BANKS] = {0}, region_base[GUEST_RAM_BANKS],
> +        banksize[GUEST_RAM_BANKS], bankend[GUEST_RAM_BANKS], ramsize;
> +    uint32_t regs[(GUEST_ROOT_ADDRESS_CELLS + GUEST_ROOT_SIZE_CELLS) *
> +                  (GUEST_RAM_BANKS + 1)];
> +    be32 *cells = &regs[0];
> +    const uint64_t bankbase[] = GUEST_RAM_BANK_BASES;
> +    unsigned int i, len, nr_regions = 0;
> +    uint8_t gpaddr_bits;
>      int res;
>      gic_interrupt intr;
>  
> @@ -617,9 +629,67 @@ static int make_hypervisor_node(libxl__gc *gc, void *fdt,
>                                "xen,xen");
>      if (res) return res;
>  
> -    /* reg 0 is grant table space */
> -    res = fdt_property_regs(gc, fdt, GUEST_ROOT_ADDRESS_CELLS, GUEST_ROOT_SIZE_CELLS,
> -                            1,GUEST_GNTTAB_BASE, GUEST_GNTTAB_SIZE);
> +    if (strcmp(dom->guest_type, "xen-3.0-aarch64")) {
> +        LOG(WARN, "The extended regions are only supported for 64-bit guest currently");
> +        goto out;
> +    }
> +
> +    gpaddr_bits = b_info->arch_arm.gpaddr_bits;
> +    assert(gpaddr_bits >= 32 && gpaddr_bits <= 48);
> +
> +    /*
> +     * Try to allocate separate 2MB-aligned extended regions from the first
> +     * (below 4GB) and second (above 4GB) RAM banks taking into the account
> +     * the maximum supported guest physical address space size and the amount
> +     * of memory assigned to the guest.
> +     * As the guest memory layout is not populated yet we cannot rely on
> +     * dom->rambank_size[], so calculate the actual size of both banks using
> +     * "max_memkb" value.
> +     */
> +    ramsize = b_info->max_memkb * 1024;
> +    if (ramsize <= GUEST_RAM0_SIZE) {
> +        banksize[0] = ramsize;
> +        banksize[1] = 0;
> +    } else {
> +        banksize[0] = GUEST_RAM0_SIZE;
> +        banksize[1] = ramsize - GUEST_RAM0_SIZE;
> +    }
> +
> +    bankend[0] = GUEST_RAM0_BASE + GUEST_RAM0_SIZE;
> +    bankend[1] = min(1ULL << gpaddr_bits, GUEST_RAM1_BASE + GUEST_RAM1_SIZE);
> +
> +    for (i = 0; i < GUEST_RAM_BANKS; i++) {
> +        region_base[i] = bankbase[i] + ALIGN_UP_TO_2MB(banksize[i]);
> +        if (bankend[i] > region_base[i])
> +            region_size[i] = bankend[i] - region_base[i];
> +    }

This seems correct but it looks a bit overkill. I would have written
like this:

    if (ramsize <= GUEST_RAM0_SIZE) {
        region_base[0] = GUEST_RAM0_BASE + ALIGN_UP_TO_2MB(ramsize);
        region_size[0] = GUEST_RAM0_SIZE - ALIGN_UP_TO_2MB(ramsize);
        region_base[1] = GUEST_RAM1_BASE;
        region_size[1] = min(1ULL << gpaddr_bits, GUEST_RAM1_BASE + GUEST_RAM1_SIZE) -
                         region_base[0];
    } else {
        region_size[0] = 0;
        region_base[1] = GUEST_RAM1_BASE + ALIGN_UP_TO_2MB(ramsize - GUEST_RAM0_SIZE);
        region_size[1] = min(1ULL << gpaddr_bits, GUEST_RAM1_BASE + GUEST_RAM1_SIZE) -
                         region_base[1];
    }

Which removes the needs for banksize, bankend, bankbase. What do you
think? Your version works too, so I am OK anyway.



> +out:
> +    /*
> +     * The region 0 for grant table space must be always present. If we managed
> +     * to allocate the extended regions then insert them as regions 1...N.
> +     */
> +    set_range(&cells, GUEST_ROOT_ADDRESS_CELLS, GUEST_ROOT_SIZE_CELLS,
> +              GUEST_GNTTAB_BASE, GUEST_GNTTAB_SIZE);
> +
> +    for (i = 0; i < GUEST_RAM_BANKS; i++) {
> +        if (region_size[i] < GUEST_EXT_REGION_MIN_SIZE)
> +            continue;
> +
> +        LOG(DEBUG, "Extended region %u: %#"PRIx64"->%#"PRIx64"\n",
> +            nr_regions, region_base[i], region_base[i] + region_size[i]);
> +
> +        set_range(&cells, GUEST_ROOT_ADDRESS_CELLS, GUEST_ROOT_SIZE_CELLS,
> +                  region_base[i], region_size[i]);
> +        nr_regions ++;
                     ^ code style


> +    }
> +
> +    if (!nr_regions)
> +        LOG(WARN, "The extended regions cannot be allocated, not enough space");
> +
> +    len = sizeof(regs[0]) * (GUEST_ROOT_ADDRESS_CELLS + GUEST_ROOT_SIZE_CELLS) *
> +        (nr_regions + 1);
> +    res = fdt_property(fdt, "reg", regs, len);
>      if (res) return res;
>  
>      /*
> @@ -965,7 +1035,7 @@ next_resize:
>          }
>  
>          FDT( make_timer_node(gc, fdt, ainfo, state->clock_frequency) );
> -        FDT( make_hypervisor_node(gc, fdt, vers) );
> +        FDT( make_hypervisor_node(gc, fdt, vers, info, dom) );
>  
>          if (info->arch_arm.vuart == LIBXL_VUART_TYPE_SBSA_UART)
>              FDT( make_vpl011_uart_node(gc, fdt, ainfo, dom) );
> diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h
> index 4a01f8b..f74cc0b 100644
> --- a/xen/include/public/arch-arm.h
> +++ b/xen/include/public/arch-arm.h
> @@ -454,6 +454,8 @@ typedef uint64_t xen_callback_t;
>  #define GUEST_RAM_BANK_BASES   { GUEST_RAM0_BASE, GUEST_RAM1_BASE }
>  #define GUEST_RAM_BANK_SIZES   { GUEST_RAM0_SIZE, GUEST_RAM1_SIZE }
>  
> +#define GUEST_EXT_REGION_MIN_SIZE   xen_mk_ullong(0x0004000000) /* 64MB */
> +
>  /* Current supported guest VCPUs */
>  #define GUEST_MAX_VCPUS 128
>  
> -- 
> 2.7.4
> 


From xen-devel-bounces@lists.xenproject.org Thu Oct 07 01:50:47 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Oct 2021 01:50:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.203260.358340 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYIYB-0006Aa-74; Thu, 07 Oct 2021 01:50:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 203260.358340; Thu, 07 Oct 2021 01:50:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYIYB-0006AT-3I; Thu, 07 Oct 2021 01:50:23 +0000
Received: by outflank-mailman (input) for mailman id 203260;
 Thu, 07 Oct 2021 01:50:22 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Ti8Z=O3=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1mYIYA-0006AN-Du
 for xen-devel@lists.xenproject.org; Thu, 07 Oct 2021 01:50:22 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id edc5794e-2710-11ec-bfb6-12813bfff9fa;
 Thu, 07 Oct 2021 01:50:20 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id D58A561177;
 Thu,  7 Oct 2021 01:50:19 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: edc5794e-2710-11ec-bfb6-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1633571420;
	bh=5PG8D2CKaxYwAoBZU6YOzqKGYJTkuU6LJyqa49jq0V8=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=Bjndg9JASRPM3hBPJy1DqNDax+19MlIzdHQqHoOFaWmyduytvIQcKcSy8RCovHSbI
	 vj0Q/a1M6MSe9gKLGv15+bGe1xCWMPtbjGBsxmvHhtdOCPbi/5BzaYyB2UvbceNCOj
	 oIu6sfQmiG3wyOnZfPphfCGyIxAapB8p48gNouvqX35w0aAXql/q81OI5NDisIXQk+
	 ncR5dsKk/QzhJVXA7W+lVDeSMxmzeodMwxX3b7x63/Wia/jT3M8dGVybzlRpH6sCaB
	 rWlFVI+Nwaej6yK0Ibe6IRfuQWBFgGTYujXMyI/bv5DeG07LYTMZW9oyqjxSmWTWG9
	 lkz9hx7hTu+ag==
Date: Wed, 6 Oct 2021 18:50:19 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Oleksandr Tyshchenko <olekstysh@gmail.com>
cc: xen-devel@lists.xenproject.org, 
    Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, 
    Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH V5 3/3] xen/arm: Updates for extended regions support
In-Reply-To: <1633519346-3686-4-git-send-email-olekstysh@gmail.com>
Message-ID: <alpine.DEB.2.21.2110061843360.3209@sstabellini-ThinkPad-T480s>
References: <1633519346-3686-1-git-send-email-olekstysh@gmail.com> <1633519346-3686-4-git-send-email-olekstysh@gmail.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Wed, 6 Oct 2021, Oleksandr Tyshchenko wrote:
> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> 
> This is a follow-up of
> "b6fe410 xen/arm: Add handling of extended regions for Dom0"
> 
> Add various in-code comments, update Xen hypervisor device tree
> bindings text, change the log level for some prints and clarify
> format specifier, reuse dt_for_each_range() to avoid open-coding
> in find_memory_holes().
> 
> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>

Thanks for the patch, it looks like you addressed all Julien's comments
well. A couple of minor issues below.


> ---
>    New patch
> ---
>  docs/misc/arm/device-tree/guest.txt |  12 ++--
>  xen/arch/arm/domain_build.c         | 108 ++++++++++++++++++++++--------------
>  2 files changed, 73 insertions(+), 47 deletions(-)
> 
> diff --git a/docs/misc/arm/device-tree/guest.txt b/docs/misc/arm/device-tree/guest.txt
> index 418f1e9..c115751 100644
> --- a/docs/misc/arm/device-tree/guest.txt
> +++ b/docs/misc/arm/device-tree/guest.txt
> @@ -7,10 +7,14 @@ the following properties:
>  	compatible = "xen,xen-<version>", "xen,xen";
>    where <version> is the version of the Xen ABI of the platform.
>  
> -- reg: specifies the base physical address and size of a region in
> -  memory where the grant table should be mapped to, using an
> -  HYPERVISOR_memory_op hypercall. The memory region is large enough to map
> -  the whole grant table (it is larger or equal to gnttab_max_grant_frames()).
> +- reg: specifies the base physical address and size of the regions in memory
> +  where the special resources should be mapped to, using an HYPERVISOR_memory_op
> +  hypercall.
> +  Region 0 is reserved for mapping grant table, it must be always present.
> +  The memory region is large enough to map the whole grant table (it is larger
> +  or equal to gnttab_max_grant_frames()).
> +  Regions 1...N are extended regions (unused address space) for mapping foreign
> +  GFNs and grants, they might be absent if there is nothing to expose.
>    This property is unnecessary when booting Dom0 using ACPI.
>  
>  - interrupts: the interrupt used by Xen to inject event notifications.
> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
> index c5afbe2..d9f40d4 100644
> --- a/xen/arch/arm/domain_build.c
> +++ b/xen/arch/arm/domain_build.c
> @@ -898,7 +898,10 @@ static int __init add_ext_regions(unsigned long s, unsigned long e, void *data)
>      if ( ext_regions->nr_banks >= ARRAY_SIZE(ext_regions->bank) )
>          return 0;
>  
> -    /* Both start and size of the extended region should be 2MB aligned */
> +    /*
> +     * Both start and size of the extended region should be 2MB aligned to
> +     * potentially allow superpage mapping.
> +     */
>      start = (s + SZ_2M - 1) & ~(SZ_2M - 1);
>      if ( start > e )
>          return 0;
> @@ -909,6 +912,12 @@ static int __init add_ext_regions(unsigned long s, unsigned long e, void *data)
>       */
>      e += 1;
>      size = (e - start) & ~(SZ_2M - 1);
> +
> +    /*
> +     * Reasonable size. Not too little to pick up small ranges which are
> +     * not quite useful itself but increase bookkeeping and not too much
                           ^ remove itself                             ^ large

> +     * to skip a large proportion of unused address space.
> +     */
>      if ( size < MB(64) )
>          return 0;
>  
> @@ -919,6 +928,14 @@ static int __init add_ext_regions(unsigned long s, unsigned long e, void *data)
>      return 0;
>  }
>  
> +/*
> + * Find unused regions of Host address space which can be exposed to Dom0
> + * as extended regions for the special memory mappings. In order to calculate
> + * regions we exclude every assigned to Dom0 region from the Host RAM:
                              ^ region assigned  ^ remove


> + * - domain RAM
> + * - reserved-memory
> + * - grant table space
> + */
>  static int __init find_unallocated_memory(const struct kernel_info *kinfo,
>                                            struct meminfo *ext_regions)
>  {
> @@ -942,7 +959,7 @@ static int __init find_unallocated_memory(const struct kernel_info *kinfo,
>          res = rangeset_add_range(unalloc_mem, start, end - 1);
>          if ( res )
>          {
> -            printk(XENLOG_ERR "Failed to add: %#"PRIx64"->%#"PRIx64"\n",
> +            printk(XENLOG_ERR "Failed to add: %#"PRIpaddr"->%#"PRIpaddr"\n",
>                     start, end);
>              goto out;
>          }
> @@ -956,7 +973,7 @@ static int __init find_unallocated_memory(const struct kernel_info *kinfo,
>          res = rangeset_remove_range(unalloc_mem, start, end - 1);
>          if ( res )
>          {
> -            printk(XENLOG_ERR "Failed to remove: %#"PRIx64"->%#"PRIx64"\n",
> +            printk(XENLOG_ERR "Failed to remove: %#"PRIpaddr"->%#"PRIpaddr"\n",
>                     start, end);
>              goto out;
>          }
> @@ -971,7 +988,7 @@ static int __init find_unallocated_memory(const struct kernel_info *kinfo,
>          res = rangeset_remove_range(unalloc_mem, start, end - 1);
>          if ( res )
>          {
> -            printk(XENLOG_ERR "Failed to remove: %#"PRIx64"->%#"PRIx64"\n",
> +            printk(XENLOG_ERR "Failed to remove: %#"PRIpaddr"->%#"PRIpaddr"\n",
>                     start, end);
>              goto out;
>          }
> @@ -983,7 +1000,7 @@ static int __init find_unallocated_memory(const struct kernel_info *kinfo,
>      res = rangeset_remove_range(unalloc_mem, start, end - 1);
>      if ( res )
>      {
> -        printk(XENLOG_ERR "Failed to remove: %#"PRIx64"->%#"PRIx64"\n",
> +        printk(XENLOG_ERR "Failed to remove: %#"PRIpaddr"->%#"PRIpaddr"\n",
>                 start, end);
>          goto out;
>      }
> @@ -1003,6 +1020,35 @@ out:
>      return res;
>  }
>  
> +static int __init handle_pci_range(const struct dt_device_node *dev,
> +                                   u64 addr, u64 len, void *data)
> +{
> +    struct rangeset *mem_holes = data;
> +    paddr_t start, end;
> +    int res;
> +
> +    start = addr & PAGE_MASK;
> +    end = PAGE_ALIGN(addr + len);
> +    res = rangeset_remove_range(mem_holes, start, end - 1);
> +    if ( res )
> +    {
> +        printk(XENLOG_ERR "Failed to remove: %#"PRIpaddr"->%#"PRIpaddr"\n",
> +               start, end);
> +        return res;
> +    }
> +
> +    return 0;
> +}
> +
> +/*
> + * Find the holes in the Host DT which can be exposed to Dom0 as extended
> + * regions for the special memory mappings. In order to calculate regions
> + * we exclude every addressable memory region described by "reg" and "ranges"
> + * properties from the maximum possible addressable physical memory range:
> + * - MMIO
> + * - Host RAM
> + * - PCI bar
        ^ PCI aperture


> + */
>  static int __init find_memory_holes(const struct kernel_info *kinfo,
>                                      struct meminfo *ext_regions)
>  {
> @@ -1024,7 +1070,7 @@ static int __init find_memory_holes(const struct kernel_info *kinfo,
>      res = rangeset_add_range(mem_holes, start, end);
>      if ( res )
>      {
> -        printk(XENLOG_ERR "Failed to add: %#"PRIx64"->%#"PRIx64"\n",
> +        printk(XENLOG_ERR "Failed to add: %#"PRIpaddr"->%#"PRIpaddr"\n",
>                 start, end);
>          goto out;
>      }
> @@ -1055,49 +1101,25 @@ static int __init find_memory_holes(const struct kernel_info *kinfo,
>              res = rangeset_remove_range(mem_holes, start, end - 1);
>              if ( res )
>              {
> -                printk(XENLOG_ERR "Failed to remove: %#"PRIx64"->%#"PRIx64"\n",
> +                printk(XENLOG_ERR "Failed to remove: %#"PRIpaddr"->%#"PRIpaddr"\n",
>                         start, end);
>                  goto out;
>              }
>          }
>  
> -        if ( dt_device_type_is_equal(np, "pci" ) )
> +        if ( dt_device_type_is_equal(np, "pci") )
>          {
> -            unsigned int range_size, nr_ranges;
> -            int na, ns, pna;
> -            const __be32 *ranges;
> -            u32 len;
> -
>              /*
> -             * Looking for non-empty ranges property which in this context
> -             * describes the PCI host bridge aperture.
> +             * The ranges property in this context describes the PCI host
> +             * bridge aperture. It shall be absent if no addresses are mapped
> +             * through the bridge.
>               */
> -            ranges = dt_get_property(np, "ranges", &len);
> -            if ( !ranges || !len )
> +            if ( !dt_get_property(np, "ranges", NULL) )
>                  continue;
>  
> -            pna = dt_n_addr_cells(np);
> -            na = dt_child_n_addr_cells(np);
> -            ns = dt_child_n_size_cells(np);
> -            range_size = pna + na + ns;
> -            nr_ranges = len / sizeof(__be32) / range_size;
> -
> -            for ( i = 0; i < nr_ranges; i++, ranges += range_size )
> -            {
> -                /* Skip the child address and get the parent (CPU) address */
> -                addr = dt_read_number(ranges + na, pna);
> -                size = dt_read_number(ranges + na + pna, ns);
> -
> -                start = addr & PAGE_MASK;
> -                end = PAGE_ALIGN(addr + size);
> -                res = rangeset_remove_range(mem_holes, start, end - 1);
> -                if ( res )
> -                {
> -                    printk(XENLOG_ERR "Failed to remove: %#"PRIx64"->%#"PRIx64"\n",
> -                           start, end);
> -                    goto out;
> -                }
> -            }
> +            res = dt_for_each_range(np, &handle_pci_range, mem_holes);
> +            if ( res )
> +                goto out;
>          }
>      }
>  
> @@ -1152,12 +1174,12 @@ static int __init make_hypervisor_node(struct domain *d,
>  
>      if ( !opt_ext_regions )
>      {
> -        printk(XENLOG_DEBUG "The extended regions support is disabled\n");
> +        printk(XENLOG_INFO "The extended regions support is disabled\n");
>          nr_ext_regions = 0;
>      }
>      else if ( is_32bit_domain(d) )
>      {
> -        printk(XENLOG_DEBUG "The extended regions are only supported for 64-bit guest currently\n");
> +        printk(XENLOG_WARNING "The extended regions are only supported for 64-bit guest currently\n");
>          nr_ext_regions = 0;
>      }
>      else
> @@ -1193,8 +1215,8 @@ static int __init make_hypervisor_node(struct domain *d,
>          u64 start = ext_regions->bank[i].start;
>          u64 size = ext_regions->bank[i].size;
>  
> -        dt_dprintk("Extended region %d: %#"PRIx64"->%#"PRIx64"\n",
> -                   i, start, start + size);
> +        printk("Extended region %d: %#"PRIx64"->%#"PRIx64"\n",
> +               i, start, start + size);

Also should be PRIpaddr


From xen-devel-bounces@lists.xenproject.org Thu Oct 07 03:07:38 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Oct 2021 03:07:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.203273.358357 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYJkj-00059g-69; Thu, 07 Oct 2021 03:07:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 203273.358357; Thu, 07 Oct 2021 03:07:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYJkj-00059Z-2K; Thu, 07 Oct 2021 03:07:25 +0000
Received: by outflank-mailman (input) for mailman id 203273;
 Thu, 07 Oct 2021 03:07:23 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mYJkh-00059P-GN; Thu, 07 Oct 2021 03:07:23 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mYJkh-0000Vj-9I; Thu, 07 Oct 2021 03:07:23 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mYJkg-0003Md-W3; Thu, 07 Oct 2021 03:07:23 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mYJkg-0002OF-VJ; Thu, 07 Oct 2021 03:07:22 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=vGlkd2EDH5DCwd01yapMEuJhILydRh61V03g+gP3tns=; b=LltmUGqqacrNCP6BD7l1E03Vp7
	nhhT9yF9ZxQ1X7R/xyfHxoyn9n+VIIcLnCKkgD+8Tk1s6Ro+/XrYEI5RxI0ou4Ydk+34p2zhmuw3O
	Jnz7H7UskcSloYpIOrTk+8DgUYpvFZUShb6Fd3UA77JMYp6ahsNq5t438/IrDoeL1HPA=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165387-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.15-testing test] 165387: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-4.15-testing:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    xen-4.15-testing:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    xen-4.15-testing:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=3b98d9f35a9edd2502ff9466341132baa6664cc3
X-Osstest-Versions-That:
    xen=84fa99099b920f7bcde8899e1a9b756078719d7d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 07 Oct 2021 03:07:22 +0000

flight 165387 xen-4.15-testing real [real]
flight 165403 xen-4.15-testing real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/165387/
http://logs.test-lab.xenproject.org/osstest/logs/165403/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 165403-retest
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 165403-retest

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail baseline untested
 test-amd64-amd64-xl-rtds     20 guest-localmigrate/x10       fail  like 164938
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 164938
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 164938
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 164938
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 164938
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 164938
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 164938
 test-armhf-armhf-xl-rtds     18 guest-start/debian.repeat    fail  like 164938
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 164938
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 164938
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 164938
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 164938
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 164938
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  3b98d9f35a9edd2502ff9466341132baa6664cc3
baseline version:
 xen                  84fa99099b920f7bcde8899e1a9b756078719d7d

Last test of basis   164938  2021-09-10 07:07:36 Z   26 days
Testing same since   165387  2021-10-05 19:06:48 Z    1 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Ivan Kardykov <kardykov@tabit.pro>
  Jan Beulich <jbeulich@suse.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 fail    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  fail    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     fail    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   84fa99099b..3b98d9f35a  3b98d9f35a9edd2502ff9466341132baa6664cc3 -> stable-4.15


From xen-devel-bounces@lists.xenproject.org Thu Oct 07 04:43:13 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Oct 2021 04:43:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.203284.358374 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYLFD-0006OV-RA; Thu, 07 Oct 2021 04:42:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 203284.358374; Thu, 07 Oct 2021 04:42:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYLFD-0006OO-O2; Thu, 07 Oct 2021 04:42:59 +0000
Received: by outflank-mailman (input) for mailman id 203284;
 Thu, 07 Oct 2021 04:42:58 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Ti8Z=O3=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1mYLFC-0006OI-BD
 for xen-devel@lists.xenproject.org; Thu, 07 Oct 2021 04:42:58 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 3265f9f2-8c92-44db-b2b5-91cf1a696b86;
 Thu, 07 Oct 2021 04:42:57 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id 4C62860F48;
 Thu,  7 Oct 2021 04:42:56 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3265f9f2-8c92-44db-b2b5-91cf1a696b86
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1633581776;
	bh=rHu53fwSWBMXmFdSyaTkqI/1Yk5EfR0T2AckmGfzY9A=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=ikxO1T8rWfqe5ITMh+/YYB6Ts3Tim91OCqgxWro2KM92Qjr2eNVURQdImnPRGzPxz
	 NTQ8M1FHJnOqG+c/aWdvjT81qymzWGMGdM32haNIod2kxJSARS+5U1tTsM0g88D+9F
	 6cN0qJdWJYDiAtJ2sj+tKX3TGrFlx6ij+Iq0qFU2NIfJLquHFWiMjLtKiuEziEX9YU
	 P9/gPVvgZSqY9rUiNfxkeKXcCMea88A1GQsGNdmqboWuE8ATC23+APRvN2a6QPaoTM
	 W6+Ju46f1WdjrKiEcJIENB3RWrbqShWmrvkGeNy+rkO4qQ6iXgVrCIsiQ//n6zOHtl
	 AiImOW1awfM8w==
Date: Wed, 6 Oct 2021 21:42:55 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Michal Orzel <michal.orzel@arm.com>
cc: xen-devel@lists.xenproject.org, 
    Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, bertrand.marquis@arm.com
Subject: Re: [PATCH v2 2/3] xen/arm: Check for PMU platform support
In-Reply-To: <20211006105827.15217-3-michal.orzel@arm.com>
Message-ID: <alpine.DEB.2.21.2110062137050.3209@sstabellini-ThinkPad-T480s>
References: <20211006105827.15217-1-michal.orzel@arm.com> <20211006105827.15217-3-michal.orzel@arm.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Wed, 6 Oct 2021, Michal Orzel wrote:
> ID_AA64DFR0_EL1/ID_DFR0_EL1 registers provide
> information about PMU support. Replace structure
> dbg64/dbg32 with a union and fill in all the
> register fields according to document:
> ARM Architecture Registers(DDI 0595, 2021-06).
> 
> Add macros boot_dbg_feature64/boot_dbg_feature32
> to check for a debug feature. Add macro
> cpu_has_pmu to check for PMU support.
> 
> Signed-off-by: Michal Orzel <michal.orzel@arm.com>

Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>


> ---
>  xen/include/asm-arm/cpufeature.h | 49 ++++++++++++++++++++++++++++++--
>  1 file changed, 47 insertions(+), 2 deletions(-)
> 
> diff --git a/xen/include/asm-arm/cpufeature.h b/xen/include/asm-arm/cpufeature.h
> index 5ca09b0bff..4fce23844d 100644
> --- a/xen/include/asm-arm/cpufeature.h
> +++ b/xen/include/asm-arm/cpufeature.h
> @@ -4,6 +4,7 @@
>  #ifdef CONFIG_ARM_64
>  #define cpu_feature64(c, feat)         ((c)->pfr64.feat)
>  #define boot_cpu_feature64(feat)       (system_cpuinfo.pfr64.feat)
> +#define boot_dbg_feature64(feat)       (system_cpuinfo.dbg64.feat)
>  
>  #define cpu_feature64_has_el0_32(c)    (cpu_feature64(c, el0) == 2)
>  
> @@ -22,6 +23,7 @@
>  
>  #define cpu_feature32(c, feat)         ((c)->pfr32.feat)
>  #define boot_cpu_feature32(feat)       (system_cpuinfo.pfr32.feat)
> +#define boot_dbg_feature32(feat)       (system_cpuinfo.dbg32.feat)
>  
>  #define cpu_has_arm       (boot_cpu_feature32(arm) == 1)
>  #define cpu_has_thumb     (boot_cpu_feature32(thumb) >= 1)
> @@ -32,8 +34,10 @@
>  
>  #ifdef CONFIG_ARM_32
>  #define cpu_has_gentimer  (boot_cpu_feature32(gentimer) == 1)
> +#define cpu_has_pmu       (boot_dbg_feature32(perfmon) >= 1)
>  #else
>  #define cpu_has_gentimer  (1)
> +#define cpu_has_pmu       (boot_dbg_feature64(pmu_ver) >= 1)
>  #endif
>  #define cpu_has_security  (boot_cpu_feature32(security) > 0)
>  
> @@ -181,8 +185,28 @@ struct cpuinfo_arm {
>          };
>      } pfr64;
>  
> -    struct {
> +    union {
>          register_t bits[2];
> +        struct {
> +            /* DFR0 */
> +            unsigned long debug_ver:4;
> +            unsigned long trace_ver:4;
> +            unsigned long pmu_ver:4;
> +            unsigned long brps:4;
> +            unsigned long __res0:4;
> +            unsigned long wrps:4;
> +            unsigned long __res1:4;
> +            unsigned long ctx_cmps:4;
> +            unsigned long pms_ver:4;
> +            unsigned long double_lock:4;
> +            unsigned long trace_filt:4;
> +            unsigned long __res2:4;
> +            unsigned long mtpmu:4;
> +            unsigned long __res3:12;
> +
> +            /* DFR1 */
> +            unsigned long __res4:64;
> +        };
>      } dbg64;
>  
>      struct {
> @@ -321,8 +345,29 @@ struct cpuinfo_arm {
>          };
>      } pfr32;
>  
> -    struct {
> +    union {
>          register_t bits[2];
> +        struct {
> +            /* DFR0 */
> +            unsigned long copdbg:4;
> +            unsigned long copsdbg:4;
> +            unsigned long mmapdbg:4;
> +            unsigned long coptrc:4;
> +            unsigned long mmaptrc:4;
> +            unsigned long mprofdbg:4;
> +            unsigned long perfmon:4;
> +            unsigned long tracefilt:4;
> +#ifdef CONFIG_ARM_64
> +            unsigned long __res0:32;
> +#endif
> +
> +            /* DFR1 */
> +            unsigned long mtpmu:4;
> +            unsigned long __res1:28;
> +#ifdef CONFIG_ARM_64
> +            unsigned long __res2:32;
> +#endif
> +        };
>      } dbg32;
>  
>      struct {
> -- 
> 2.29.0
> 


From xen-devel-bounces@lists.xenproject.org Thu Oct 07 04:45:34 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Oct 2021 04:45:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.203293.358385 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYLHi-00071O-97; Thu, 07 Oct 2021 04:45:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 203293.358385; Thu, 07 Oct 2021 04:45:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYLHi-00071H-61; Thu, 07 Oct 2021 04:45:34 +0000
Received: by outflank-mailman (input) for mailman id 203293;
 Thu, 07 Oct 2021 04:45:32 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Ti8Z=O3=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1mYLHg-00071B-S1
 for xen-devel@lists.xenproject.org; Thu, 07 Oct 2021 04:45:32 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 66a58120-2729-11ec-bfbc-12813bfff9fa;
 Thu, 07 Oct 2021 04:45:31 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id 4DF7260F48;
 Thu,  7 Oct 2021 04:45:30 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 66a58120-2729-11ec-bfbc-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1633581930;
	bh=bsZjrqCjcDJAfsMIrdbFh6u0y2b5AKa0xeAv8SHBnN0=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=OVAo9w0GRx5XILoiuOSFETQp5I+goK81w8pJDhw9F0azM9jbWcB8Eyt3byl27HwFG
	 0os56uzJswPzx4Fpy3qQeQEa1fetjfb0Bp0sffUGqD7G3mBa8RUUrOjI8Lrowe3n4E
	 tp9b0TTIBEt8vGF9pi722vkVUuQzsO8+nhapqulPAJ40Ws/818If3eb7gyRs/KnDKl
	 VRdJnTM6X2VowzTxEAMK0M6gDsJpApsFXa8QPRgnFfXv3eqC7KCXhY1JkHQkKxmhe6
	 0PgADBjFiE9l19pz3Dp3/J9rmldwMEAlQNNA5ZqELrbsMH/Z3KkN95LjrgAauTyjPg
	 YmPKAiZASHsDQ==
Date: Wed, 6 Oct 2021 21:45:29 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Michal Orzel <michal.orzel@arm.com>
cc: xen-devel@lists.xenproject.org, George Dunlap <george.dunlap@citrix.com>, 
    Nick Rosbrook <rosbrookn@ainfosec.com>, Ian Jackson <iwj@xenproject.org>, 
    Wei Liu <wl@xen.org>, Andrew Cooper <andrew.cooper3@citrix.com>, 
    Jan Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>, 
    Stefano Stabellini <sstabellini@kernel.org>, 
    Anthony PERARD <anthony.perard@citrix.com>, 
    Juergen Gross <jgross@suse.com>, 
    Christian Lindig <christian.lindig@citrix.com>, 
    David Scott <dave@recoil.org>, bertrand.marquis@arm.com
Subject: Re: [PATCH v2 1/3] xen+tools: Introduce XEN_SYSCTL_PHYSCAP_vpmu
In-Reply-To: <20211006105827.15217-2-michal.orzel@arm.com>
Message-ID: <alpine.DEB.2.21.2110062145110.3209@sstabellini-ThinkPad-T480s>
References: <20211006105827.15217-1-michal.orzel@arm.com> <20211006105827.15217-2-michal.orzel@arm.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Wed, 6 Oct 2021, Michal Orzel wrote:
> Introduce flag XEN_SYSCTL_PHYSCAP_vpmu which
> indicates whether the platform supports vPMU
> functionality. Modify Xen and tools accordingly.
> 
> Take the opportunity and fix XEN_SYSCTL_PHYSCAP_vmtrace
> definition in sysctl.h which wrongly uses (1<<6)
> instead of (1u<<6) and does not follow the standard
> of using separate macro for a flag field.
> 
> Signed-off-by: Michal Orzel <michal.orzel@arm.com>

>From the xen/ part:

Acked-by: Stefano Stabellini <sstabellini@kernel.org>


> ---
>  tools/golang/xenlight/helpers.gen.go | 2 ++
>  tools/golang/xenlight/types.gen.go   | 1 +
>  tools/include/libxl.h                | 6 ++++++
>  tools/libs/light/libxl.c             | 1 +
>  tools/libs/light/libxl_types.idl     | 1 +
>  tools/ocaml/libs/xc/xenctrl.ml       | 1 +
>  tools/ocaml/libs/xc/xenctrl.mli      | 1 +
>  tools/xl/xl_info.c                   | 5 +++--
>  xen/common/domain.c                  | 2 ++
>  xen/common/sysctl.c                  | 3 +++
>  xen/include/public/sysctl.h          | 8 ++++++--
>  xen/include/xen/domain.h             | 2 ++
>  12 files changed, 29 insertions(+), 4 deletions(-)
> 
> diff --git a/tools/golang/xenlight/helpers.gen.go b/tools/golang/xenlight/helpers.gen.go
> index bfc1e7f312..c8669837d8 100644
> --- a/tools/golang/xenlight/helpers.gen.go
> +++ b/tools/golang/xenlight/helpers.gen.go
> @@ -3360,6 +3360,7 @@ x.CapHap = bool(xc.cap_hap)
>  x.CapShadow = bool(xc.cap_shadow)
>  x.CapIommuHapPtShare = bool(xc.cap_iommu_hap_pt_share)
>  x.CapVmtrace = bool(xc.cap_vmtrace)
> +x.CapVpmu = bool(xc.cap_vpmu)
>  
>   return nil}
>  
> @@ -3391,6 +3392,7 @@ xc.cap_hap = C.bool(x.CapHap)
>  xc.cap_shadow = C.bool(x.CapShadow)
>  xc.cap_iommu_hap_pt_share = C.bool(x.CapIommuHapPtShare)
>  xc.cap_vmtrace = C.bool(x.CapVmtrace)
> +xc.cap_vpmu = C.bool(x.CapVpmu)
>  
>   return nil
>   }
> diff --git a/tools/golang/xenlight/types.gen.go b/tools/golang/xenlight/types.gen.go
> index 09a3bb67e2..45f2cba3d2 100644
> --- a/tools/golang/xenlight/types.gen.go
> +++ b/tools/golang/xenlight/types.gen.go
> @@ -1008,6 +1008,7 @@ CapHap bool
>  CapShadow bool
>  CapIommuHapPtShare bool
>  CapVmtrace bool
> +CapVpmu bool
>  }
>  
>  type Connectorinfo struct {
> diff --git a/tools/include/libxl.h b/tools/include/libxl.h
> index b9ba16d698..ec5e3badae 100644
> --- a/tools/include/libxl.h
> +++ b/tools/include/libxl.h
> @@ -502,6 +502,12 @@
>   */
>  #define LIBXL_HAVE_X86_MSR_RELAXED 1
>  
> +/*
> + * LIBXL_HAVE_PHYSINFO_CAP_VPMU indicates that libxl_physinfo has a cap_vpmu
> + * field, which indicates the availability of vPMU functionality.
> + */
> +#define LIBXL_HAVE_PHYSINFO_CAP_VPMU 1
> +
>  /*
>   * libxl ABI compatibility
>   *
> diff --git a/tools/libs/light/libxl.c b/tools/libs/light/libxl.c
> index 204eb0be2d..a032723fde 100644
> --- a/tools/libs/light/libxl.c
> +++ b/tools/libs/light/libxl.c
> @@ -404,6 +404,7 @@ int libxl_get_physinfo(libxl_ctx *ctx, libxl_physinfo *physinfo)
>          !!(xcphysinfo.capabilities & XEN_SYSCTL_PHYSCAP_iommu_hap_pt_share);
>      physinfo->cap_vmtrace =
>          !!(xcphysinfo.capabilities & XEN_SYSCTL_PHYSCAP_vmtrace);
> +    physinfo->cap_vpmu = !!(xcphysinfo.capabilities & XEN_SYSCTL_PHYSCAP_vpmu);
>  
>      GC_FREE;
>      return 0;
> diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_types.idl
> index 3f9fff653a..993e83acca 100644
> --- a/tools/libs/light/libxl_types.idl
> +++ b/tools/libs/light/libxl_types.idl
> @@ -1061,6 +1061,7 @@ libxl_physinfo = Struct("physinfo", [
>      ("cap_shadow", bool),
>      ("cap_iommu_hap_pt_share", bool),
>      ("cap_vmtrace", bool),
> +    ("cap_vpmu", bool),
>      ], dir=DIR_OUT)
>  
>  libxl_connectorinfo = Struct("connectorinfo", [
> diff --git a/tools/ocaml/libs/xc/xenctrl.ml b/tools/ocaml/libs/xc/xenctrl.ml
> index a5588c643f..6da3ed3c6f 100644
> --- a/tools/ocaml/libs/xc/xenctrl.ml
> +++ b/tools/ocaml/libs/xc/xenctrl.ml
> @@ -121,6 +121,7 @@ type physinfo_cap_flag =
>  	| CAP_Shadow
>  	| CAP_IOMMU_HAP_PT_SHARE
>  	| CAP_Vmtrace
> +	| CAP_Vpmu
>  
>  type physinfo =
>  {
> diff --git a/tools/ocaml/libs/xc/xenctrl.mli b/tools/ocaml/libs/xc/xenctrl.mli
> index 6e94940a8a..b8faff6721 100644
> --- a/tools/ocaml/libs/xc/xenctrl.mli
> +++ b/tools/ocaml/libs/xc/xenctrl.mli
> @@ -106,6 +106,7 @@ type physinfo_cap_flag =
>    | CAP_Shadow
>    | CAP_IOMMU_HAP_PT_SHARE
>    | CAP_Vmtrace
> +  | CAP_Vpmu
>  
>  type physinfo = {
>    threads_per_core : int;
> diff --git a/tools/xl/xl_info.c b/tools/xl/xl_info.c
> index 8383e4a6df..2c86b317b7 100644
> --- a/tools/xl/xl_info.c
> +++ b/tools/xl/xl_info.c
> @@ -210,7 +210,7 @@ static void output_physinfo(void)
>           info.hw_cap[4], info.hw_cap[5], info.hw_cap[6], info.hw_cap[7]
>          );
>  
> -    maybe_printf("virt_caps              :%s%s%s%s%s%s%s%s\n",
> +    maybe_printf("virt_caps              :%s%s%s%s%s%s%s%s%s\n",
>           info.cap_pv ? " pv" : "",
>           info.cap_hvm ? " hvm" : "",
>           info.cap_hvm && info.cap_hvm_directio ? " hvm_directio" : "",
> @@ -218,7 +218,8 @@ static void output_physinfo(void)
>           info.cap_hap ? " hap" : "",
>           info.cap_shadow ? " shadow" : "",
>           info.cap_iommu_hap_pt_share ? " iommu_hap_pt_share" : "",
> -         info.cap_vmtrace ? " vmtrace" : ""
> +         info.cap_vmtrace ? " vmtrace" : "",
> +         info.cap_vpmu ? " vpmu" : ""
>          );
>  
>      vinfo = libxl_get_version_info(ctx);
> diff --git a/xen/common/domain.c b/xen/common/domain.c
> index 6ee5d033b0..4d0e909eec 100644
> --- a/xen/common/domain.c
> +++ b/xen/common/domain.c
> @@ -84,6 +84,8 @@ vcpu_info_t dummy_vcpu_info;
>  
>  bool __read_mostly vmtrace_available;
>  
> +bool __read_mostly vpmu_is_available;
> +
>  static void __domain_finalise_shutdown(struct domain *d)
>  {
>      struct vcpu *v;
> diff --git a/xen/common/sysctl.c b/xen/common/sysctl.c
> index 3558641cd9..6e7189bb3c 100644
> --- a/xen/common/sysctl.c
> +++ b/xen/common/sysctl.c
> @@ -280,6 +280,9 @@ long do_sysctl(XEN_GUEST_HANDLE_PARAM(xen_sysctl_t) u_sysctl)
>          if ( vmtrace_available )
>              pi->capabilities |= XEN_SYSCTL_PHYSCAP_vmtrace;
>  
> +        if ( vpmu_is_available )
> +            pi->capabilities |= XEN_SYSCTL_PHYSCAP_vpmu;
> +
>          if ( copy_to_guest(u_sysctl, op, 1) )
>              ret = -EFAULT;
>      }
> diff --git a/xen/include/public/sysctl.h b/xen/include/public/sysctl.h
> index 039ccf885c..546e673409 100644
> --- a/xen/include/public/sysctl.h
> +++ b/xen/include/public/sysctl.h
> @@ -100,10 +100,14 @@ struct xen_sysctl_tbuf_op {
>  #define _XEN_SYSCTL_PHYSCAP_iommu_hap_pt_share 5
>  #define XEN_SYSCTL_PHYSCAP_iommu_hap_pt_share  \
>      (1u << _XEN_SYSCTL_PHYSCAP_iommu_hap_pt_share)
> -#define XEN_SYSCTL_PHYSCAP_vmtrace       (1 << 6)
> +#define _XEN_SYSCTL_PHYSCAP_vmtrace      6
> +#define XEN_SYSCTL_PHYSCAP_vmtrace       (1u<<_XEN_SYSCTL_PHYSCAP_vmtrace)
> +/* The platform supports vPMU. */
> +#define _XEN_SYSCTL_PHYSCAP_vpmu         7
> +#define XEN_SYSCTL_PHYSCAP_vpmu          (1u<<_XEN_SYSCTL_PHYSCAP_vpmu)
>  
>  /* Max XEN_SYSCTL_PHYSCAP_* constant.  Used for ABI checking. */
> -#define XEN_SYSCTL_PHYSCAP_MAX XEN_SYSCTL_PHYSCAP_vmtrace
> +#define XEN_SYSCTL_PHYSCAP_MAX XEN_SYSCTL_PHYSCAP_vpmu
>  
>  struct xen_sysctl_physinfo {
>      uint32_t threads_per_core;
> diff --git a/xen/include/xen/domain.h b/xen/include/xen/domain.h
> index 1708c36964..160c8dbdab 100644
> --- a/xen/include/xen/domain.h
> +++ b/xen/include/xen/domain.h
> @@ -133,4 +133,6 @@ static inline void vnuma_destroy(struct vnuma_info *vnuma) { ASSERT(!vnuma); }
>  
>  extern bool vmtrace_available;
>  
> +extern bool vpmu_is_available;
> +
>  #endif /* __XEN_DOMAIN_H__ */
> -- 
> 2.29.0
> 


From xen-devel-bounces@lists.xenproject.org Thu Oct 07 07:15:36 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Oct 2021 07:15:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.203305.358399 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYNcf-0004gQ-9t; Thu, 07 Oct 2021 07:15:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 203305.358399; Thu, 07 Oct 2021 07:15:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYNcf-0004gJ-6p; Thu, 07 Oct 2021 07:15:21 +0000
Received: by outflank-mailman (input) for mailman id 203305;
 Thu, 07 Oct 2021 07:15:20 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=qfpx=O3=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mYNce-0004gD-C8
 for xen-devel@lists.xenproject.org; Thu, 07 Oct 2021 07:15:20 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 76efffc4-66be-4313-865a-752a5b960aea;
 Thu, 07 Oct 2021 07:15:19 +0000 (UTC)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2106.outbound.protection.outlook.com [104.47.18.106])
 (Using TLS) by relay.mimecast.com with ESMTP id
 de-mta-6-UsbZH10rP7Kf4fG1wvppcQ-1; Thu, 07 Oct 2021 09:15:17 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0402MB3391.eurprd04.prod.outlook.com (2603:10a6:803:3::23)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.19; Thu, 7 Oct
 2021 07:15:15 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4587.020; Thu, 7 Oct 2021
 07:15:15 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6P195CA0021.EURP195.PROD.OUTLOOK.COM (2603:10a6:209:81::34) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4587.18 via Frontend Transport; Thu, 7 Oct 2021 07:15:14 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 76efffc4-66be-4313-865a-752a5b960aea
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1633590918;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=NQlA0YVJ/yC7+c0exeig21OlNsmuWay0KQELO8S3tLQ=;
	b=EkPKvgTjaa5/HAKXxdDmJ/PisX28yX6JZtA4w4OCjpTMqSGUfD4Lr59bbmJEXsBHfTX1nK
	dBG3hZsjpRf3FE/HhFiEYMHT6oIHNeUoSBD/BddqhyYXAX21mu/WJsDo4Sp8aiv2ImnV52
	yFOFTzqEsl35SZt5DJ2VyKn5qVWckUY=
X-MC-Unique: UsbZH10rP7Kf4fG1wvppcQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=jiW3rrFxcdv4Qe15sAzPApjeOd0MSQoA3KwUY+/CyAEW/BhzL0593l4Qb7+MGyJFds6z0Cwtzb3kbtJHtf6ALfBVhcS13zYxAq0RXBfE1Ozi+XwzlxQ0Vm+plMAKVsStJWmdliHa6JV2VB05cgzHXwQZ6NYo6IIaP8X1h+cX0xP/x6SoJwmXG9AdTRx22NWzMmc0iC4SmK7gB0eEsOF2D9LNS5ZbiWqOEcpddjhzbDo7lvlwVRzXUSXVr8uYxTxHbud7P5wf+G8Ppa5Xnoj6byieSUBHx10jowQfFOPCSsyME1Uqs/pzrMWCq2r8Y1r3rfF1xrbwx79IVdSSsXQDig==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=1Jf4CdjZAvVVn44BTSBs4eFZdi/nAtCGtwAbF5bgeUQ=;
 b=nlw81IOl99V+JFqY1XJzKDIEkRHySt3sqz0S7BhMId8q7ZBJRPso7xMzsGA7aKA+FThOVhB/S8gJQfD++5NUiJoONPzdxiZRk/HEaS7YF9mTNz1gjtZrn7AVxA1zeYdPq1j28WSRx9wuIflxWg1NniNKyCwEFEX9+r36M8wDftDVewrOM/Dq3EOiL7lxFEfzypr97BaKc7J1HDstBOK5wpavLHB12PbL/bb4b+rw1aJYSWsLrQvdPDdkBqtSvW+ES0J5zh5JzJDnNhq4o4VVnyHpSA5aeewga8woSEMNirZK1zXRbMGbSUpn269mSaKyFsEEbGf3b2JdoQr5fQK2EQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [PATCH v4 2/3] arm/efi: Use dom0less configuration when using EFI
 boot
To: Luca Fancellu <luca.fancellu@arm.com>
CC: Bertrand Marquis <bertrand.marquis@arm.com>, wei.chen@arm.com,
 Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Wei Liu <wl@xen.org>, xen-devel@lists.xenproject.org
References: <20210930142846.13348-1-luca.fancellu@arm.com>
 <20210930142846.13348-3-luca.fancellu@arm.com>
 <2fa4be34-9c69-21cb-632f-f566caf622ca@suse.com>
 <6DFF05BA-8250-4C6C-86DF-67997F8DAD46@arm.com>
 <ce8e7fda-4d74-4bce-78bd-387f9b7a395f@suse.com>
 <55D6C05A-C0B4-4503-A7F8-D0BA11E0779B@arm.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <00328991-2c85-fed8-40d6-c33ecac7e1e8@suse.com>
Date: Thu, 7 Oct 2021 09:15:18 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <55D6C05A-C0B4-4503-A7F8-D0BA11E0779B@arm.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6P195CA0021.EURP195.PROD.OUTLOOK.COM
 (2603:10a6:209:81::34) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: d5ea18d4-cf74-4021-f434-08d9896235c0
X-MS-TrafficTypeDiagnostic: VI1PR0402MB3391:
X-Microsoft-Antispam-PRVS:
	<VI1PR0402MB33912CB8C65ABC511FF2AB45B3B19@VI1PR0402MB3391.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:3826;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	d/DuqHrz4bJ14q6IZ9NA/qLWFIOGrC+EUhxrLytw0j3vaJ7fsYQDCNw8P5xvVW5TJ2FS5tinnQbXXAysOnSTG/CVKuWsFNTeJQ1XB93lDKsJL30ZQEkcJIjqG0zG/fNUZs6raxklnk8Ftsti/XKZCDS8CLX0F/SAmcPR59hl9za9h0AeF+fZREOzkCpYFzjbvDNamJUsDqnIjMjSXo/un4SQeyw4q4izB7drUccO3l7S8rrxO+So5QP5DoiXs62LNzqhN9JahbSOiPywEVG476NoAVtUP+ZhpIeTAFajKdJIU644fV8TN25ikChXTcT284NNlluCu017n5REvVKIldeNvkm+l1KdWKE8pCcLxQnIfl+ZsPnFTUn2k+zVSJkin7w9Dk8qiHIFeWUXrguhUmnPkxd5i8HFl8U/+zUY0is+2/BWIuSdIbDMNs2owP4Lce26Zh3Q/uX80QqlfiBLBrtJLR4Fe4fJY0j2JKjbjFfXHBwM5DfIJ03pKXCitnnP062qVA2hY8viN8YFq/Wmo43LD/bUX6M7cq/jgHsOrHkcTxqdEU338X9G97o71nKLXGeo4k21xP7gvm31Uh3mrkw41OkWcXU1cxMR6+PoHgJsjpIj3AfvoTJTXaWV0SnMaZlJg6H4QNCSayT7RoQzLT5O/kki7AzI0UJYE0V+TNhevFNaKCR0HyXLP4Xzecr8RlNSpKTvmEtHXYL7IA0vbVzydifUoOD55LbBzxgm0i05AG8yDcvL1pxSe0PepbuEA2oogQzGwK6gWBxozAX5ng==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(26005)(4326008)(8676002)(54906003)(31686004)(8936002)(38100700002)(6486002)(5660300002)(956004)(2616005)(6916009)(16576012)(66476007)(53546011)(83380400001)(66556008)(316002)(36756003)(31696002)(2906002)(7416002)(86362001)(186003)(508600001)(66946007)(32563001)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?YWtketlaTTT/QRZEw+Ii/+G+V2+QouqQ8DIvVOpJZ1XndjfORiZUD3reE2UM?=
 =?us-ascii?Q?NFnscEvYGKhGTMmJlMidZ7Xz5Wmc0tB4mOkuOoJmC9SfI13xCLdlAcSNlqNM?=
 =?us-ascii?Q?Bcm4Mi3ydWmnZewlsqdn2A5WShUdfb6g5epnhUyE+ZdPU/1DrGDywSi4Umx5?=
 =?us-ascii?Q?b6SyeiGSPocfuPCFUOA/v00H/4Ko1lL9OBy92mkZHoMjw0Elg8PyFaBQIxLk?=
 =?us-ascii?Q?VhLH7NOV+2rn2waS/3eFVpaDgSMEPp+SFKCjt5SCkdBgnbvlKOBloV+4Wy6d?=
 =?us-ascii?Q?dWOnrt3J1nrBsfqtKB6luvBdZRIwHMsEfYL/xjp1RAoCWxo7gBhQyMMwLIa8?=
 =?us-ascii?Q?z1JLkbYl850n7CMKaG9tCwp4r+wao4oB4O2YBF0tOvEwjwN8WeLz913b9lEm?=
 =?us-ascii?Q?KygLtsqbP+b6LhvOlaQqkX6vkt3U8u0hSn7r8kWa5mBoG87ZBxhShE/7gt55?=
 =?us-ascii?Q?X9mcwbDDH7r+geKt0O22ofIW9QThPzJeiJyMu2PkWft7qyW2inToqVZ1aTkN?=
 =?us-ascii?Q?c02+Ta0q1F17T9c4eHqVFAqFI1bvZCkLdB+XSMArKozsMjojn6lAnqp1mZwz?=
 =?us-ascii?Q?18VWeQkwHCQf3Z7gFSSrfJj4Z26UmS6QhOgcdXbnf3CSq4IjSQCJYWFxYl9o?=
 =?us-ascii?Q?e8YqWUN5Pki4DdI1sB5Rpv3wYQapwsu1QvzVY2+gOtJ7sSSNKb+lI9W7uwbM?=
 =?us-ascii?Q?qYb2y2xERI9rhX/02+MSN9aYwUgXbOCMSHJbkcZ7uRL2HyxcZw8J4VJpRx18?=
 =?us-ascii?Q?2fyIoATGwFR/Z2Bgm8im2F0c8iWh4v0EhxgQP56UxrXjXGDqOPNmLs7O0qB6?=
 =?us-ascii?Q?d5j5GJs+F+A2vl8nRh02XlpJGtZgSFkDNMbDyGw9LTJsoWl/eezhc4CE4tmV?=
 =?us-ascii?Q?iR+EtiOI6OV0X74h1VrtBTTvnIVNuOG1N6A0UA0S8PTBAIj+ZPx7zOXU2k4E?=
 =?us-ascii?Q?yqxm7E+sZPV2havkvz1Qq++8qvO8EOzKNFwECWGuV15cz/jvZ7ITILI4j2Jb?=
 =?us-ascii?Q?OMdypKF97kTCk3f4EDCM/F8jjkeLkAYL3fY5kAz9/4gQvWu2TB+M4olI9MZu?=
 =?us-ascii?Q?Useay6FYkbPN58kD8S7AroGUBae8WjNFa+1RcUMPgwlaiT/iySCSNBnVHLcV?=
 =?us-ascii?Q?c+gYxSIe8bUl2uIKhFVxJ1uULV4pN8uRzMT8zOjNKBEaalReHOOsX2AQIJm+?=
 =?us-ascii?Q?FGeDaXbZYRuYm6Goaw9Id3TxbsHEsXD+WB+c8WRsEOpxtaZSeZCX6GqKphiV?=
 =?us-ascii?Q?ML0MWRzCPRDTWlG/+rhR2a7jObeHhicmlhlRiL91v2ds03+70CZyKRt+h8JW?=
 =?us-ascii?Q?nDjA+Lj0GNVwYJm3FTEnHZ/J?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d5ea18d4-cf74-4021-f434-08d9896235c0
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Oct 2021 07:15:15.2473
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: KdHIP790Rzgas7+MLZR3KXWLCYV8tKMhm/dJyhFK05XcLKqqM6pGhQZY8v+lqfpEeLancAufEHGDVcvI9XsXTQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3391

On 01.10.2021 17:13, Luca Fancellu wrote:
>=20
>=20
>> On 1 Oct 2021, at 15:22, Jan Beulich <jbeulich@suse.com> wrote:
>>
>> On 01.10.2021 15:55, Luca Fancellu wrote:
>>>> On 1 Oct 2021, at 12:02, Jan Beulich <jbeulich@suse.com> wrote:
>>>> On 30.09.2021 16:28, Luca Fancellu wrote:
>>>>> @@ -1361,12 +1361,30 @@ efi_start(EFI_HANDLE ImageHandle, EFI_SYSTEM_=
TABLE *SystemTable)
>>>>>        efi_bs->FreePages(cfg.addr, PFN_UP(cfg.size));
>>>>>        cfg.addr =3D 0;
>>>>>
>>>>> -        dir_handle->Close(dir_handle);
>>>>> -
>>>>>        if ( gop && !base_video )
>>>>>            gop_mode =3D efi_find_gop_mode(gop, cols, rows, depth);
>>>>>    }
>>>>>
>>>>> +#ifdef CONFIG_HAS_DEVICE_TREE
>>>>> +    /* Get the number of boot modules specified on the DT or an erro=
r (<0) */
>>>>> +    dt_modules_found =3D efi_arch_check_dt_boot(dir_handle);
>>>>> +#endif
>>>>
>>>> So I had asked to add a stub enclosed in such an #ifdef, to avoid the
>>>> #ifdef here. I may be willing to let you keep things as you have them
>>>> now, but I'd like to understand why you've picked that different
>>>> approach despite the prior discussion.
>>>
>>> There must be a misunderstanding, your message in the v3 was:
>>>
>>> "Every time I see this addition I'm getting puzzled. As a result I'm
>>> afraid I now need to finally ask you to do something about this (and
>>> I'm sorry for doing so only now). There would better be no notion of
>>> DT in x86 code, and there would better also not be a need for
>>> architectures not supporting DT to each supply such a stub. Instead
>>> I think you want to put this stub in xen/common/efi/boot.c, inside a
>>> suitable #ifdef.=E2=80=9D
>>>
>>> So I thought you wanted me to remove the stub in x86 (since it doesn=E2=
=80=99t support DT)
>>> and put this call under #ifdef so it won=E2=80=99t be compiled for arch=
 not supporting DT.
>>
>> So FTAOD I'll repeat the crucial part: "I think you want to put this
>> stub in xen/common/efi/boot.c". There was nothing about removing the
>> stub altogether.
>=20
> Oh ok, now I see, so in your opinion this is a better idea:
>=20
> #ifndef CONFIG_HAS_DEVICE_TREE
> static inline int __init efi_arch_check_dt_boot(EFI_FILE_HANDLE dir_handl=
e)
> {
>     return 0;
> }
> #endif
>=20
> But I would like to understand the advantage respect of my approach, coul=
d you
> explain me?

Well, to a degree it's a matter of taste. Your approach may lead to a long
series of various #ifdef sections in a single function, harming readability=
.
Having stubs instead (usually placed in headers, albeit not in this case)
allows the main bodies of code to remain more tidy.

Jan



From xen-devel-bounces@lists.xenproject.org Thu Oct 07 07:20:51 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Oct 2021 07:20:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.203314.358411 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYNhv-00066n-UJ; Thu, 07 Oct 2021 07:20:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 203314.358411; Thu, 07 Oct 2021 07:20:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYNhv-00066g-RL; Thu, 07 Oct 2021 07:20:47 +0000
Received: by outflank-mailman (input) for mailman id 203314;
 Thu, 07 Oct 2021 07:20:46 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=qfpx=O3=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mYNhu-00066a-OO
 for xen-devel@lists.xenproject.org; Thu, 07 Oct 2021 07:20:46 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 160c7d2a-273f-11ec-bfc1-12813bfff9fa;
 Thu, 07 Oct 2021 07:20:45 +0000 (UTC)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2053.outbound.protection.outlook.com [104.47.14.53]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-31-WsM9yLtSMv-HhV8vOwKfcA-1; Thu, 07 Oct 2021 09:20:43 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB7039.eurprd04.prod.outlook.com (2603:10a6:800:12b::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.19; Thu, 7 Oct
 2021 07:20:42 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4587.020; Thu, 7 Oct 2021
 07:20:42 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS9PR06CA0082.eurprd06.prod.outlook.com (2603:10a6:20b:464::31) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.16 via Frontend
 Transport; Thu, 7 Oct 2021 07:20:41 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 160c7d2a-273f-11ec-bfc1-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1633591244;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=byc+tgw1tLGHxbylyZSxzsls1fSUa2vD/hgJzfCpBLo=;
	b=QJeGZzTY3VAXbjAq+H5mtYwa/4zlbmANevXic69kPqnqX3S3DcovzODdgwf3DsHEkfpJSL
	XKvOPlcjYVdhQmS11Z6X5jHxFXrgpviDR440iMrD8etDqLCOuPqZJhLphd7V3V4skX31rm
	donoq5ZSVLrcth7pRGjgY28b47x0qyY=
X-MC-Unique: WsM9yLtSMv-HhV8vOwKfcA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Lhunqay0bOLQdzF2lXGFBIV0f2FkweUcobjJ+dLaP/Lx0Siz0JaToOi57zN7RApat0ODFpdX88Stw9iov2DF1SWWHXjSrPZdkiFlDtcO1/tV/CO00VnV+++Q+2/GRyLx8sRicQN2LioNsUU+hwz4l/EayBqx3IEdRy42J5SNjcLXlDFEsZdkRjRF4AFvR3DpKiziHHTMYikOC/mdsNIcbAQDNXEaElRg9DMD6ShBAhAYld9sz7lj7/+ek/1TOSeAWi+TWLGAQU0Nyi3wGbMWgbRI6jR3GE//xBbBZwyTlOKZbrxrqS0X3QXB3DtI+9YVSADz8zToXuCdbgqCyBhFmA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=byc+tgw1tLGHxbylyZSxzsls1fSUa2vD/hgJzfCpBLo=;
 b=f0X2z3vrWNhuQ/65AWOHmk5jBOAy+QG8zo3+Dc4E4t0cX70KnYH+oP4jDjeyRG8m5crTPGjXKskUKQHsjJ+eFQc6pRSxmlufAga5PU2TrtPEZBBfRxgfDV4igAjh3OmbLHiPe7aV0z8EVLB90fCvA2GRJifYzn392FECIEi+yVt9XAn81+16+SQddxdQrNTftFNJpUqiPpIQGrfDSKttX9NiMOdpooLcx4XNFIcQpM92WVilAb3euiYIi3XPscEmjPBO/NwwAB29v8L7HE2gxTWCUg7ZR7y2Db25Z4hyXIzoDNSZYv5E/fZOfTt/gh9iI/FBch6i2xC2EbI+0lal1w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: HVM/PVH Balloon crash
To: Elliott Mitchell <ehem+xen@m5p.com>
Cc: xen-devel@lists.xenproject.org
References: <YTZ+XsnoKNnV4IOz@mattapan.m5p.com>
 <1b3d4cb1-ba61-0f61-5097-9978462a2401@suse.com>
 <YTd/SFtvuzejeiik@mattapan.m5p.com>
 <935dc03f-74f5-4b49-3a45-71148364fb5a@suse.com>
 <YUFdIPLo1AfM5BT2@mattapan.m5p.com>
 <3efe115b-1ff7-dcf1-8198-37bd7d7fb52f@suse.com>
 <YVD59QVbmdVwzYQI@mattapan.m5p.com>
 <033cc499-34de-d27a-7b1b-2a0a7ce38672@suse.com>
 <YVSGvGZc67ZLMdKm@mattapan.m5p.com>
 <03052a89-cb51-250d-4fcd-b9d8ceb93e39@suse.com>
 <YVfFZKRIPTYi/9bH@mattapan.m5p.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <4cb11d0c-8149-d248-583b-abd8fc103c1d@suse.com>
Date: Thu, 7 Oct 2021 09:20:45 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <YVfFZKRIPTYi/9bH@mattapan.m5p.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0082.eurprd06.prod.outlook.com
 (2603:10a6:20b:464::31) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 0829bc59-81d6-4c24-b4be-08d98962f8a9
X-MS-TrafficTypeDiagnostic: VI1PR04MB7039:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB703922E3E0F2C6436DD5F539B3B19@VI1PR04MB7039.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7219;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	zoRWSAanWtLjAL5m0iAtjL5yqhTNS+1WcOAkzgiCXGMXjFAwH7jEGaBs7HtZ8j1UBgc6DNfJMOpqeVLLyAvo/0z4TJqIQwdBTASaTYME5MNcXFSMlZ/SiSvDS2bQhQxTjaP15X6elzkvKbjgFyP4mxtuykvVcfubniE4cKW5NE1Gkt+CyWk9EF/pCDpcho+zdLANFz/zS9/5lgR9xMmVZDY/Br5OPFpCIgDzyTeEj0m9kNDgAwpJ4FS83ntPy+mJdMgd8oVpMJU/XwgJSDIEtqURCTX5dnIqtPl+M6rP+VfTjphO2EsdnYWOKmlCud5au97BNLpkYAOQZQkOGfbes5hIYHZKSns91Jr0h8QksKWYHginDsLLEv+8bQdPQQsksyqWSsQf9efqwWgx2Xm7nmH8Kzob5rUaLOXWXijLZyie5pgT6YS/9ad5M+GClyI/kmwjo52LguvpUTd64dr4DgGrsoD9GBSt+Gg28i42Es/ojsLbQYKBFQuylvLjEJLu10g878px69myWGAYyTR4atZRW8qA9AmA2hzHxkHSpzmFyuMAoLs/oE06oJ2e9pna9VLNpxFWbvCBG1lNOcLyp2OEsp9hSjUofPoan3F7c3FRwGUYCRRWUxgJ/eISbpsWGVyLjYDw3iYPQ6lOL1tLhSYQ2TGo8pg+Jre6e41ihfJ8WLhtCdeqBaPdjiBdUfYOPIMjHAuVOBVBK1jZ5lhX/b+Kp6T/4gAmXduZOxOhtUNOHGI3+/YuIxjmtU8MJdfA
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(26005)(4326008)(8676002)(31686004)(8936002)(6486002)(5660300002)(38100700002)(956004)(2616005)(16576012)(66476007)(53546011)(83380400001)(316002)(36756003)(66556008)(31696002)(2906002)(86362001)(3480700007)(186003)(508600001)(66946007)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?bytsWXErNjQ5V1VKR0F0bGUxUytFS1pMckxQT0luWVRnZ05tclcrSXRPK2xh?=
 =?utf-8?B?N1BoMDBHRzR6eitpaU0vLzg5b1hxNk1vRlVzYVJIUjVzOEtMYUk0KzJ0SGNT?=
 =?utf-8?B?d3ZQdUhLUzlrR3hOdEZ0R1FVcGYvSVpwNWVFMmVPYThqVmgzL0dUUFdsZlJm?=
 =?utf-8?B?dlBRSjZuZ2YrckRSV0tFeTdGUnZrbkY2Q2pHMmR2N2MrQnZjZVFvRXRMbk9h?=
 =?utf-8?B?bnNhT1VsSCtVQ2Fkbk9ua3BGcVE3YzlXcnFKNnU2QXlCWjJqdThLdGt1Zysx?=
 =?utf-8?B?TnlMODBOZVg5U3hRZStxbGh0WGZub09MSm1QN2ZmblhEWGhIcFkybHhjNkl2?=
 =?utf-8?B?UTNTNSt0UG5CVnd1ZFg3VHFwbG1welZsQWQraTQwaHp2YTU5QVNRVkUyRGlQ?=
 =?utf-8?B?ZWllRVM3NHV6cXY2SGovMHMxczAyQWZURXNGaDhKNzJudFlNcmhMLzc3VGcy?=
 =?utf-8?B?TzZPK0swcVEyNEd5ckx3K2xONTh4VVN3aUtvMnFMRytKVHpIdkZ5N0VMSXhh?=
 =?utf-8?B?ZnFzZnI5dUxhc1NiOTEweFhKVmFCdGFzb0ZRTHlWTFRNMEdwcnRvTGE2U0sz?=
 =?utf-8?B?MGdQd2lZTWh4bmlESS9OQm5hZldSN2VwbGxVVUd2WDgxVnRMSU1IMEwrRDdI?=
 =?utf-8?B?ZFhkOXNrQ3QrTE1zZjRRZWdza3VKckxBQ0ZEdHp1UHdzbEpHT3Y5RGVmVWs3?=
 =?utf-8?B?R1lOQmhVTUlYQVB3NDh6TEF2OUhFa1MwdHJVcFJCOGxpZHVCbUZKa0czUUlO?=
 =?utf-8?B?eldGOGFvVmVFSHZGcGV3NWsvQXZPWmp4L1pFQmJ6STlid2lxQzN5N1g0Z2Ry?=
 =?utf-8?B?RWFXNnkzZWlNUjlSYUsyOXFkbE81aTBUMnZDZVVwWGYxUWV1UVNGMU1zQUVt?=
 =?utf-8?B?RlY3QWxYdFAwZ1FBRkRWM1pLMmF6akxsUEhlbTU3VHAwdzhmT3ZyMXJza012?=
 =?utf-8?B?WkRYdno0ZEI0MHF6REFyNEVvaWMzcGVLbDJCczU5WmRFMHdPdUJFb2dnTU1v?=
 =?utf-8?B?Q1dPSVExVm5GeURaZmEydHNwUWl4TGlkandEUFZUMUtBdTU2MnpVRjVyb1lV?=
 =?utf-8?B?dTNXajNJSkhneDZwMTY1ZU4zK0YwMThsY0NBSVV5K1NHcTNQZ1pNZE5EeHho?=
 =?utf-8?B?RlhRSGIrUzVlMTBLTFBWVGhFQU02RW1JYzVRNnpNZ056NjZOSXhTb3FHY3da?=
 =?utf-8?B?eW5IVUYvY1hpQUdwWUUrMzNJckhTWnlLQU9QV2UyTHFyd2VnRkVDVzNwUGdS?=
 =?utf-8?B?TVV5S1JxZ0lOdU95amUzQ0RMYmZUSzhET3dZaWc5WE12dWJJRExPQ3QxZm5z?=
 =?utf-8?B?WVd2SklDY2pXVGkxR1pMOEZrbC9mVzdvUEM4bDIrcW9XRVlwTENsK3o2Rmo4?=
 =?utf-8?B?WkNkSGQxR3FsbHIyVUozNkc0L0FkQlNRZ2Y3RW1meUpORm9aWXhmcW9DUElQ?=
 =?utf-8?B?c3ZBN1g4eXlDOWJHZUpaSXZRRDVQSmJSQWZQS1pIRjJaWXhuQXdVTkFUbTRT?=
 =?utf-8?B?Smt2dlhMamJKODNTSEpLRXpJVzdUWldBM2NzZUxEbVVPeWpYNHRLYjIwMnhp?=
 =?utf-8?B?bE5SNS8rNnZaWEFGSmxvV2V2d0I5cFRLK3Z4b2g0Z2pSYXZwRVdheEdlbXpu?=
 =?utf-8?B?YmFOZFhFaUNqQnJnSVdMUW92YTVVRUZtUllLOExiMTBaR3lybGVhSTh5TEJG?=
 =?utf-8?B?OWpyTUtBRXFjNlFHY0tlbXRRSGxZQlJzT2xFVDZHVW9McmhFcis0VU82cWZu?=
 =?utf-8?Q?DXUPWVyOHEH3TCSl//k5olsDgCceLUDVDDhv81o?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0829bc59-81d6-4c24-b4be-08d98962f8a9
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Oct 2021 07:20:42.2436
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: PaI7FeiUWSigIwwbdcq7qFIVHsrNf9uO7bSbdZ0oUyunKm313lH1cBtXOf+aOoXZwsCiwIS1/c1vYvXN83tglQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7039

On 02.10.2021 04:35, Elliott Mitchell wrote:
> On Thu, Sep 30, 2021 at 09:08:34AM +0200, Jan Beulich wrote:
>> On 29.09.2021 17:31, Elliott Mitchell wrote:
>>>
>>> Copy and paste from the xl.cfg man page:
>>>
>>>        nestedhvm=BOOLEAN
>>>            Enable or disables guest access to hardware virtualisation
>>>            features, e.g. it allows a guest Operating System to also function
>>>            as a hypervisor. You may want this option if you want to run
>>>            another hypervisor (including another copy of Xen) within a Xen
>>>            guest or to support a guest Operating System which uses hardware
>>>            virtualisation extensions (e.g. Windows XP compatibility mode on
>>>            more modern Windows OS).  This option is disabled by default.
>>>
>>> "This option is disabled by default." doesn't mean "this is an
>>> experimental feature with no security support and is likely to crash the
>>> hypervisor".
>>
>> Correct, but this isn't the only place to look at. Quoting
>> SUPPORT.md:
> 
> You expect everyone to memorize SUPPORT.md (almost 1000 lines) before
> trying to use Xen?

I don't see why you say "memorize". When the file was introduced, it was
(aiui) indeed the intention for _it_ to become the main reference. Feel
free to propose alternatives.

> Your statement amounts to saying you really expect that.  People who want
> to get work done will look at `man xl.cfg` when needed, and follow
> instructions.
> 
> Mentioning something in `man xl.cfg` amounts to a statment "this is
> supported".  Experimental/unsupported options need to be marked
> "EXPERIMENTAL: DO NOT ENABLE IN PRODUCTION ENVIRONMENTS".
> 
> 
>> Yet that's still a configuration error (of the guest), not a bug in
>> Xen.
> 
> Documentation that poor amounts to a security vulnerability.

I disagree.

> I would suggest this needs 2 extra enablers.
> 
> First, this has potential to panic the hypervisor.  As such there needs
> to be an "enable_experimental=" option for the Xen command-line.  The
> argument would be a list of features to enable ("nestedhvm" for this
> case).  If this is absent, the hypervisor should ideally disable as much
> of the code related to the unsupported/experimental features as possible.
> 
> Second, since this needs to be enabled per-domain, there should be a
> similar "enable_experimental" setting for xl.cfg options.
> 
> 
> 
> I think this really is bad enough to warrant a security vulnerability
> and updates to all branches.

As above, I don't think I agree. But please feel free to propose patches.

What I'm personally more curious about is whether the patch I did send
you actually made a difference.

Jan



From xen-devel-bounces@lists.xenproject.org Thu Oct 07 07:22:39 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Oct 2021 07:22:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.203323.358422 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYNjj-0006iF-AO; Thu, 07 Oct 2021 07:22:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 203323.358422; Thu, 07 Oct 2021 07:22:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYNjj-0006i8-7A; Thu, 07 Oct 2021 07:22:39 +0000
Received: by outflank-mailman (input) for mailman id 203323;
 Thu, 07 Oct 2021 07:22:37 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=qfpx=O3=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mYNjh-0006hy-BO
 for xen-devel@lists.xenproject.org; Thu, 07 Oct 2021 07:22:37 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 5823abcb-273f-11ec-bfc1-12813bfff9fa;
 Thu, 07 Oct 2021 07:22:36 +0000 (UTC)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2057.outbound.protection.outlook.com [104.47.14.57]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-35-cgq-Jg3bNf6nOD49jXzG-Q-1; Thu, 07 Oct 2021 09:22:34 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB7039.eurprd04.prod.outlook.com (2603:10a6:800:12b::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.19; Thu, 7 Oct
 2021 07:22:33 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4587.020; Thu, 7 Oct 2021
 07:22:33 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6P195CA0095.EURP195.PROD.OUTLOOK.COM (2603:10a6:209:86::36) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4566.14 via Frontend Transport; Thu, 7 Oct 2021 07:22:33 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5823abcb-273f-11ec-bfc1-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1633591355;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=cI7X4EsiLYSb7aU10ZGDQSWXtdjLW+2nC2kviaVSvFs=;
	b=R8q786eBVJjcLUUvBed+ygwiHU3CAlVljLwY7pRe33vbBBuLpbtsDv8jZPUYoMk5u+hfNN
	5ZBepcFKQvRIWWpXWBsup4IIPxxQNKl3/8OpLCd9WakC+RbF5M+Q2n0y2xWSV3qYtaF5xE
	F7/9c3Dgj4prV4c6vWeyuXA2HE46VEM=
X-MC-Unique: cgq-Jg3bNf6nOD49jXzG-Q-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=aTvFIa/TX6Jm4va9oVehmEafsIMDO3vCHwKLFld82OmzRNy5Bb7P5GG6hwGOhi31mG74i0EZIOcmWsHC1/mmhU9fQPMxTQNB0oaubU+Ry4UxHP515GlV7p/gU1KiYbI4eTu43n1DOeBDWuA6XFetO2Q2APwQMaLORIob5rdsXUHpTw8jXCBd6w3zMRy/4xjMTM+K0nakuPVTqFmFialXUdxB1v9l3N6LthcgWPANezq9qxoZkZv+EcdviaffDaEg1Wb5m6i/B0wli8GjN5gZ6III9pE8ZZ1Ph/QTZZS6KNOqHQTU0I0n75qfmWME+nHiWxap5IUxJGEfAWZgSM5nRg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=s0lzn+ru2kljmp/kH5rZue5gIcI9Tn6Yh6XnzBWROIw=;
 b=VpAyVdA+LhyTxsL3NHtpIE0mvKQGSr7zZ/DydiiAOgOQt3Gto1bUDmGBV2GkbdFWPnjRhUji4tYJ6qHYoZaeZh5nNw6XNAwhbuRfH3Kcc4iY9uG7q778dnDQ9nYs2xVarJfcLEaveSYfVJYPVz30xHvvhKf3uH4PXY9LPKOtIb14Q2S1BQt4dSY63WlVOVnSHU1u3fJTX7yT3Chul+OE1bfZD2LRj9FVDDkNcb3CZ8zeLA49Sftfy2TrcX1kry+AXOaQhh2Xu2mI8GVElRTXhwxZlxGqCqpNvL+HLSuHKKLQAePmzh5knr69sfc+regfGhFFsxvBl/n3u0QsVTaKhQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [PATCH v3 04/11] vpci/header: Add and remove register handlers
 dynamically
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
CC: "julien@xen.org" <julien@xen.org>,
 "sstabellini@kernel.org" <sstabellini@kernel.org>,
 Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Artem Mygaiev <Artem_Mygaiev@epam.com>,
 "roger.pau@citrix.com" <roger.pau@citrix.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Rahul Singh <rahul.singh@arm.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <20210930075223.860329-1-andr2000@gmail.com>
 <20210930075223.860329-5-andr2000@gmail.com>
 <2b575750-83a5-588e-fd6b-dd9cdb9500dd@suse.com>
 <e3730616-c51f-c453-3f74-584473313e54@epam.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <672f00b2-3065-34f1-3dda-430edd8eb463@suse.com>
Date: Thu, 7 Oct 2021 09:22:36 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <e3730616-c51f-c453-3f74-584473313e54@epam.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6P195CA0095.EURP195.PROD.OUTLOOK.COM
 (2603:10a6:209:86::36) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 78447563-414c-4dc6-570b-08d989633b1c
X-MS-TrafficTypeDiagnostic: VI1PR04MB7039:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB703985DC9E48568B81C6C7AFB3B19@VI1PR04MB7039.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7691;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	p0cn4KKlADx4y11DDf/I2j6FOcXmzz9wwbCNcETyjc9wHu5CCBNRWXuC2jOtIRjsSYMKtard03orSYRQN6ReIrp+/xh0yEPbSUKMzNQhfvLP8rOaFhcg4GcLHayKF9zh0a8XJzSMooPQUoqr8cZKYwZGKoNdN3DoxNFUmVlDqDFAgdGTvYKgMbjYAGF4toV21L+Qz4ukecKxvwcnwAsoDqR90fuFTluhbmp8jsY9dZoOXRbYpV02/9F2ywq+mR8l91XOzWxYOtN7r70UG89jOIdsmpVu4e8WYgqYlUtLUSm4GdtKXdE8HtTX1AYmCvXJJ4edrnISyehBQA70D9xydlkCI6EYshW/TPatAxcshGzblBJSDZm/q2fI9RuuBkHARaIwZjrs7xuo9fatDqJIimyzKJlvrA3ZZk6PyTKgLT2ie8m/7EeAIsDwxU8JTBnyJdlDiLqTEmupsO3G99/MwK6daHIW4qoJfILPcWzJe/JMwe48BD1tq9LODI+64MHo+ni1nYDz7nF8UUSEDcLknej65OiSEUGrCTIfDco0idm7n4sdGkqix6c1/g3iAOUoPJD2vsww8zExzoxJCKLDmo1mq7i3ugIuLnVkFv8EDB7TDxxCfs29U4J/g9yK5Tyr2W3CS+pI4d1gkfnh3wPOwGakdOY01WIFOHuj18DGMpxNho+w4CQ7B4syRLBfYcVRjhedarhZI1MCKry1PHouChczk16ka6DwM1Ap8jVKE04=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(26005)(4326008)(8676002)(54906003)(31686004)(8936002)(6486002)(5660300002)(38100700002)(956004)(2616005)(6916009)(16576012)(66476007)(53546011)(316002)(36756003)(66556008)(31696002)(2906002)(7416002)(86362001)(186003)(508600001)(66946007)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?1Uay6jbopjJaZfQCE6rfMkd/MWPntjsU96anXC9EwVO8nVw9ZDDxeA9h7aZp?=
 =?us-ascii?Q?Rd1nVSnVPBC6u9uQHym2LDUPKN5lOzHzsYMHi84DS/zz6v84JNrMRb0GlNyf?=
 =?us-ascii?Q?g9zVpeiug8D0y55wqtyfDljc4C6Jdcnz0diw+ARlJq7GOMy2ZrX7HEHKe1IX?=
 =?us-ascii?Q?k+LLueGZwsIRv61zrjWuNQwS7t15luqTvDZLZj4Na92kY0ImtsC5xzxJ9bth?=
 =?us-ascii?Q?gHXv7BEe78eWRrwolYX7yF29W/2AXzZZZ3m4x15rXGOoIRo3cADnfM0n2V5p?=
 =?us-ascii?Q?Zq6R88uy3T97aABGcup6/le8bb/qAo5/bZVwPFcfDmbDFrVvMzvY2GOCbtL1?=
 =?us-ascii?Q?kYhaHOXjvW0+r/i/IiXwq0OxXZAAdZCsewiJp8xYY8O9jBnWMOjIYIH+XF8X?=
 =?us-ascii?Q?jsw4w8w22YtsEi7tZWr/k8fRET8++UiGlTlzO1QNsc0PP7IezfWbx6NUYdCP?=
 =?us-ascii?Q?iOXmCGHJL9EQud3EfvMaMcLm+mKixMxY3kdkpkiqUZa7EI39dLm4O+lWrKFW?=
 =?us-ascii?Q?n1U3VpscbUXuINGU2/Go1Ji7LF1+dBniQJGps4W7YRoEZnlkXIYT9NuNo73H?=
 =?us-ascii?Q?3dwqs2GXC2VWfV22y1HClFskbutiQLWzDt8NUJy2Acs+zCO6F+X+JTsnZlHp?=
 =?us-ascii?Q?7WO4TMGHqivkl22QH/UH+f06fOPprcasqEpar8LhXyM+dZ12dNttaUxsHK7B?=
 =?us-ascii?Q?tFWbdtmcMCHgue94dn4rnv6luiLC4/yrHhZqV6Cj2w6g/Bpy+8slHLLnrqWE?=
 =?us-ascii?Q?mbu/KdScSUuR2uz5FbO1/M1dSfpWIjikZ09ShufviQtjwHuG64fvlmnG92rJ?=
 =?us-ascii?Q?YlSnuqn8nGWNelCu6X/hEwGkJ9PlxZ5CHT/DQBdu8ICzbcJxAoOyuPamfkXO?=
 =?us-ascii?Q?V58NZm/eyzy3fkimar/Udb7HF++RQC14uhP2HwIfy/HPSmTNIQufI5L/ifLg?=
 =?us-ascii?Q?b1/tLxJcYCRdsp8gfG5uNwRZOVnC5myF/twAQPWanu0ZbHIl/QmRe+IOjiPs?=
 =?us-ascii?Q?ySYn1vGFzcHttZis+UTRoHsCwUEYA+qCVqBkaZ+PWbs1oeiuPYDbgBS0RQIt?=
 =?us-ascii?Q?cU+TLxejYGUJ2KAV/GinAXdOnOgWFZRmK2SdjU25jc34LK7t/jfzpsUKJPfC?=
 =?us-ascii?Q?1LJXdnZd0TtlmKOs9CZ0tg8N+7RLc+jprE/UYFaBQVAyN0lCGk7lT+6p+Rva?=
 =?us-ascii?Q?nDtm3atJUzmfepdcJLTS+X6jxEg3/a+F61i5z4hpkUjHEDmOiFj9g8PZ/V2z?=
 =?us-ascii?Q?PpEzwxoB1QV96uExpKAX5I+8Xc17QqepajEESpKy+xI5r+x9u2REDGqcA3YO?=
 =?us-ascii?Q?uiE6cVFaiZIBmF1Xm4FIQDCL?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 78447563-414c-4dc6-570b-08d989633b1c
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Oct 2021 07:22:33.7695
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1CfdNQOVhanvCeUvXearrWtjOERZUeYzTPVlnc8IWDM/Ow1a7efl2oAEtAq8n4HAjapizaqPhiLfn+IKvJKK6A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7039

On 04.10.2021 07:58, Oleksandr Andrushchenko wrote:
>=20
>=20
> On 01.10.21 16:26, Jan Beulich wrote:
>> On 30.09.2021 09:52, Oleksandr Andrushchenko wrote:
>>> @@ -445,14 +456,25 @@ static void rom_write(const struct pci_dev *pdev,=
 unsigned int reg,
>>>           rom->addr =3D val & PCI_ROM_ADDRESS_MASK;
>>>   }
>>>  =20
>>> -static int add_bar_handlers(const struct pci_dev *pdev)
>>> +static void guest_rom_write(const struct pci_dev *pdev, unsigned int r=
eg,
>>> +                            uint32_t val, void *data)
>>> +{
>>> +}
>>> +
>>> +static uint32_t guest_rom_read(const struct pci_dev *pdev, unsigned in=
t reg,
>>> +                               void *data)
>>> +{
>>> +    return 0xffffffff;
>>> +}
>>> +
>>> +static int add_bar_handlers(const struct pci_dev *pdev, bool is_hwdom)
>> I remain unconvinced that this boolean is the best way to go here,
> I can remove "bool is_hwdom" and have the checks like:
>=20
> static int add_bar_handlers(const struct pci_dev *pdev)
> {
> ...
>  =C2=A0=C2=A0=C2=A0 if ( is_hardware_domain(pdev->domain) )
>  =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 rc =3D vpci_add_register(pdev=
->vpci, vpci_hw_read16, cmd_write,
>  =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 PCI_COMMAND, 2, header);
>  =C2=A0=C2=A0=C2=A0 else
>  =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 rc =3D vpci_add_register(pdev=
->vpci, vpci_hw_read16, guest_cmd_write,
>  =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 PCI_COMMAND, 2, header);
> Is this going to be better?

Marginally (plus you'd need to prove that pdev->domain can never be NULL
when making it here). "I remain unconvinced" was rather referring to our
prior discussion.

Jan



From xen-devel-bounces@lists.xenproject.org Thu Oct 07 07:43:10 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Oct 2021 07:43:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.203334.358433 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYO3U-0000jP-8K; Thu, 07 Oct 2021 07:43:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 203334.358433; Thu, 07 Oct 2021 07:43:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYO3U-0000jI-5E; Thu, 07 Oct 2021 07:43:04 +0000
Received: by outflank-mailman (input) for mailman id 203334;
 Thu, 07 Oct 2021 07:43:03 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=qfpx=O3=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mYO3S-0000jC-VC
 for xen-devel@lists.xenproject.org; Thu, 07 Oct 2021 07:43:02 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 53b083b4-13fd-41c4-9248-0ab478ec4fa7;
 Thu, 07 Oct 2021 07:43:01 +0000 (UTC)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2111.outbound.protection.outlook.com [104.47.17.111])
 (Using TLS) by relay.mimecast.com with ESMTP id
 de-mta-37-VfpYth00OZaYJCr0HQpDzg-2; Thu, 07 Oct 2021 09:42:59 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0402MB3775.eurprd04.prod.outlook.com (2603:10a6:803:1a::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.13; Thu, 7 Oct
 2021 07:42:56 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4587.020; Thu, 7 Oct 2021
 07:42:56 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6PR04CA0036.eurprd04.prod.outlook.com (2603:10a6:20b:92::49) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4566.14 via Frontend Transport; Thu, 7 Oct 2021 07:42:55 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 53b083b4-13fd-41c4-9248-0ab478ec4fa7
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1633592580;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=M3JsOkfgsXjB8nNPf3PZ1+oX1U97jEhGbM+4DNGvB6c=;
	b=Yg4u8+WGyrvWmH21+Yj18+zoikXpDi1WMa15VLWHsql1hyVurdr91fFhjUje8fgZprp7nL
	8n8IZV0NBvv24vIanM4/X8ZeZvpQWX5ivEB3xZj4HeY18tE+PEIcXpNYeRVYslr0+i6W60
	SmVDm+MBK/ZxL0qdzKBAyUPJc04v/PI=
X-MC-Unique: VfpYth00OZaYJCr0HQpDzg-2
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Z7IRWWgDhM8vsFFoiHmojfB9njI4TSTQcWiyIs8VIeXVnyh4lQLz8CotLQNeutWL8ssv6DixChHdVQq0yPmzhbbbYOVfrGjXhojGM1K7XTCr6sP/TtrAO973Oa1CtvAppWEFcgaVPEH3+qXr+7TSDFRDgnvDdYhn8JGRH0fM3SQ1DwuW21YVkIgA+RqleCosvo8ylmYw/f+k3sanN6db7gf7OfhQ5DiPLRAQpLC+cz6GWRNCTdOxxWsQda2++zAtdEC+DWyHn/oD7i0plVOpq0ZMD2Gv15+pWhnXtxRU92+fwhfIOvjmGot7hVkBajTY1XJ2Fohfdrl2tjgAdCgXvQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=M3JsOkfgsXjB8nNPf3PZ1+oX1U97jEhGbM+4DNGvB6c=;
 b=VLkHuDO5gfsVrD13i9tob6W8rjWoaAsLG86tpcg3OMyk+dv9iibr9ZlGFrtzOXS8bWzBbYCZEwHOgJ/XT3CbWr7DYNseTVlNhy/rp7s7EDkOGgj97/V4Pal56WULSoIY+Vv/NZRwNlQwBVy1ZpgF/zHF5iJhA/EwDDf1SL+rDw4fKa3+fGV7gDhSKNFOci0mZMvHUqQqku0p5JGRXonYTsctMKKFElTnB8XNajRp0eI1FkGTEAJAnG8lFIAClPRwKf9XJYv+CaZq51F70WcrrX21dZIbZszdX1yu/6xL09LUCq0xMD2YIvYegwUbIGJJ7fLnbCkbWAjCNRhwRAA7DQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [PATCH V5 1/3] xen/arm: Introduce gpaddr_bits field to struct
 xen_arch_domainconfig
To: Oleksandr Tyshchenko <olekstysh@gmail.com>
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>,
 Anthony PERARD <anthony.perard@citrix.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Juergen Gross
 <jgross@suse.com>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 xen-devel@lists.xenproject.org
References: <1633519346-3686-1-git-send-email-olekstysh@gmail.com>
 <1633519346-3686-2-git-send-email-olekstysh@gmail.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <68cb29bb-7d84-dc27-eead-4a079b9caf68@suse.com>
Date: Thu, 7 Oct 2021 09:42:59 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <1633519346-3686-2-git-send-email-olekstysh@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR04CA0036.eurprd04.prod.outlook.com
 (2603:10a6:20b:92::49) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: e09360a6-7eff-4b96-92ae-08d9896613e7
X-MS-TrafficTypeDiagnostic: VI1PR0402MB3775:
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS:
	<VI1PR0402MB37751A5D93C465D86D686EADB3B19@VI1PR0402MB3775.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	QPpE54wClA9JscD4ZH2xivoQohovzoBLG9wus3CcGcdhlmVF4Z4+k4F8EP4wdG5E9pR23mSVOEm5nj8sWtkNa8RNdEj2/ZdRWxC7bAxqZpHAq7V1BHbki28dsubK1j04UVZJ6SOdBlar5xR1KcO3Y6JTm3ezZjiuR7AfT27+79SF+rjkXK4pVWslSjfHtyPirQuGwf+xxwFFD6zklwoy953bJlbYZmOP2ju0f1z7/q8G4Ungm5iBS+DvOBFhQEaWh9sNrHQjBKaYFkCB7oxArTY7cJ+w8Z+qWLnKEKYAQWGHnZafEj25jJAGA9G00Fp6q6UKCQOQsWNrxtM89plMV31Nzk2UJQJ9tqZDVvYEV6uZSBRJUcnt6BGtP+z3zvGqP/sHjLjWN0c6cpOvoAEitjlBr+h7wZxC9tGegoMRte/VFZ/s0fjzNEavuIZRRANe0V5Ap4MbIfrbIqlP1oRPkSebOWh9o5jpuaZHEEsoeD6osHrxcwhWnEVGL5bTD0UoJX9EnSXiBNaEn0GBnYKb5BreO/DBDmLy7ylh8cyKDzrNQQ24t+1292b4YhXvqXCLogbIynU7j7Bj30qaHL3sq2P+AfWJELxfGhXLl4nIWKiI8wIIYyefyFWIlnEqHDgnhGMSpvsV+tExv63gCQ0RxS93ja+23s8hx+Vt/9+oScEsfg2l1/Wp/yrKRVIpY8OevmntKEgRriHU4vgI4olj8xvMlY8MYfBvczAPlmik4+z/r0KZucTleD+uaJACQgDH
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(53546011)(31686004)(2906002)(316002)(38100700002)(36756003)(16576012)(5660300002)(6916009)(66476007)(66946007)(8936002)(8676002)(31696002)(66556008)(186003)(6486002)(2616005)(26005)(54906003)(7416002)(83380400001)(956004)(508600001)(86362001)(4326008)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?ZjNOL0dHZis1Mjd2cTM2SUhBZ0ZTa1piM2ZVOHVzVlV1bnZqRHpVaWZ6eTNt?=
 =?utf-8?B?T0pXb0h4WkJvOXpJRmdVSUpleEsya0ZoMnZCbGZhT0NwMTdBbmJaQVpjRWhR?=
 =?utf-8?B?OThUZlg5eHluVjBacldkOU52a1FzRGI5bzVKaFdwV0Jad1NaWTdmVDJJc21m?=
 =?utf-8?B?TlBiOEwxY0wycnRBcFdWRmFQd2sxczFjU04zSVNFWWp4L0xMUXdnQ1R6YUZO?=
 =?utf-8?B?Tm5OeG8vN2RJaXVhQ0JERHhSaGE3eldWUERDL3l1SzU0WHlZKzdqRjFxSkJV?=
 =?utf-8?B?V1E3WGJPODRTTDdGTTZzcVpjbGwwNTJ4TC9KdVhhREZzZ2FwbDFPZVNTQVhC?=
 =?utf-8?B?emVnd0V4ZnhtU1hJUTBrd2tubGNNbEZYZ2RIRGI1cGczaTh2VFlYTWVQL3Jx?=
 =?utf-8?B?dXV0dmNoWXpxV0xtTDVSTW4xNE5SdkNsNktGZEFacDA0TjduWFVXUHZEbGxB?=
 =?utf-8?B?M2VLeENFd0lRY1hnRXJQN3NDUmI0S2J2eERaWUg5RXBvYUs4VkFKV3lzY09J?=
 =?utf-8?B?RGREdXZxQ3FPTVQ3ZFhxSHdpVG1zMXFGQXlpVEpEdS9MN1QvOVNzU0I5S1F5?=
 =?utf-8?B?NXp2UVVCUDVRdGZKTjM2elJUQXRYbDhKdGlDa3hkRUtCeFJLMVhxUEYzU1ZD?=
 =?utf-8?B?bm1Ec0dlVyswZytuSlgveUdIZWVaOHJRQm1RejREUlJXMis4dnVKclZjckVt?=
 =?utf-8?B?bUplK0llbWtxdFJZbnVVeEV6TklCdXBmdzBOazBsQWdZRlc2alNnV2lQVjkx?=
 =?utf-8?B?M1dLQ0RDNVdwaU9KcDNaUnU4THllbnM3OEYrUGYybVNkVmhzTGVMemVIUEpy?=
 =?utf-8?B?aTk2Q2ZBOTYrbG1mNy9Pd3o5YnFJNXhxMjFpdTkvRThvb2xwS1FleHpKRE5V?=
 =?utf-8?B?bVBPNlI5a2ppbFB0djZJbWsvU2hyOHh5NWVNb1Z5WFF5dWwzUTZnUXFyYTZi?=
 =?utf-8?B?LzRKeFB4bER6K1hieE1mYTFlWlV0ajF0aDBFNitzU0JDTnZuWE5FRWtwMHhH?=
 =?utf-8?B?Nnl2aWRPdG4zbytiY3NxQ3o0S05PbzM5OGxqYTNEMXpxOXkzend1SnlUcHY0?=
 =?utf-8?B?NUpuTVN4T25VdVNJM1M1V1VXbWFqdEFRK2pCVFkvWEdGVDVDWGRBTFVvbCs3?=
 =?utf-8?B?bzJ0bHlxQkdqaHpwZkhkRlBtWjUxL0lUbTJqdFhGL3dGT3Zlek9nbWxHaVFY?=
 =?utf-8?B?bmxUUzI1WUZlWmJqZWhtQjl4QkcrdXcwT1F6cG4wYlg4d2J0WFkrVVRHSDAv?=
 =?utf-8?B?WEt0bzUwRVRqQUVIdFFzbDhmbHAxcytYcm5FbTVJMFJtbmpkTTJkQmpXZVZV?=
 =?utf-8?B?R1hCeVVkZS9DWW8xMEdzM0NVSFZKOUpHUVE2bkJLQS9GTy8yUUdxU20vRUJN?=
 =?utf-8?B?dDNEL3MvYU14bElyZitqbnRLSGJUOTV5WWFwNXBMZGkzdnh6c0RHVU0yVy9h?=
 =?utf-8?B?NTFnQ0FxMUd6bHJ3aXg4QjhNcFhmMHAxK01ENENBUU84YTNUaDBDMXlWTEJo?=
 =?utf-8?B?TUxSMVBlV1lOMjQxRCtTYjVhTmJiZXMvWmUvNGJwUVlEeUt5b0JxcjF2M2RT?=
 =?utf-8?B?WTUzbUtuTEMwVGxzdzlNUS9oSkdRWWlaUUUzY2pkTDN5UDNWdG5acW5vTENJ?=
 =?utf-8?B?Q1lzQ1FxU1YvZmJFOEoraGdoVkFFa2xzc0tOUEo0eFk4R2NvaEtsbG50dm1B?=
 =?utf-8?B?S1FBRkJaV2IwVUNOMDZzc0s5U3c3SC9vTTBFWGVEcHRvc2hCOTd5VVJPYU1q?=
 =?utf-8?Q?2wfHaIXfbcED3cMOmL8YLn2zGVRVLKZZSrx3zfI?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e09360a6-7eff-4b96-92ae-08d9896613e7
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Oct 2021 07:42:56.4398
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0rlHrOlqVpHCDxQZOXkFx1ZkqvrIZShR44JSKUrtccws1OcdS4z5l7R8gxlnKUVJZk4fJAj10FNjn9liCAVxrw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3775

On 06.10.2021 13:22, Oleksandr Tyshchenko wrote:
> Changes V4 -> V5:
>    - update patch subject and description
>    - drop Michal's R-b
>    - pass gpaddr_bits via createdomain domctl
>      (struct xen_arch_domainconfig)

I'm afraid I can't bring this in line with ...

> --- a/xen/include/public/arch-arm.h
> +++ b/xen/include/public/arch-arm.h
> @@ -333,6 +333,11 @@ struct xen_arch_domainconfig {
>       *
>       */
>      uint32_t clock_frequency;
> +    /*
> +     * OUT
> +     * Guest physical address space size
> +     */
> +    uint8_t gpaddr_bits;

... this being an OUT field. Is this really what Andrew had asked for?
I would have expected the entire struct to be IN (and the comment at
the top of the containing struct in public/domctl.h also suggests so,
i.e. your new field renders that comment stale). gic_version being
IN/OUT is already somewhat in conflict ... One of the problems with
_any_ of the fields being OUT is that then it is unclear how the output
is intended to be propagated to consumers other than the entity
creating the domain.

Jan



From xen-devel-bounces@lists.xenproject.org Thu Oct 07 07:59:29 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Oct 2021 07:59:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.203343.358444 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYOJG-0002Mt-Gp; Thu, 07 Oct 2021 07:59:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 203343.358444; Thu, 07 Oct 2021 07:59:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYOJG-0002Mm-DF; Thu, 07 Oct 2021 07:59:22 +0000
Received: by outflank-mailman (input) for mailman id 203343;
 Thu, 07 Oct 2021 07:59:21 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=qfpx=O3=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mYOJF-0002Mg-AF
 for xen-devel@lists.xenproject.org; Thu, 07 Oct 2021 07:59:21 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 799b81c4-2744-11ec-bfc1-12813bfff9fa;
 Thu, 07 Oct 2021 07:59:20 +0000 (UTC)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2171.outbound.protection.outlook.com [104.47.17.171])
 (Using TLS) by relay.mimecast.com with ESMTP id
 de-mta-39-3QuNhm-rMiq-R7rs8-SyPw-2; Thu, 07 Oct 2021 09:59:18 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB5903.eurprd04.prod.outlook.com (2603:10a6:803:e0::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18; Thu, 7 Oct
 2021 07:59:14 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4587.020; Thu, 7 Oct 2021
 07:59:13 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM5PR0202CA0009.eurprd02.prod.outlook.com (2603:10a6:203:69::19) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18 via Frontend
 Transport; Thu, 7 Oct 2021 07:59:12 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 799b81c4-2744-11ec-bfc1-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1633593559;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=14jtNC+yODdnQcK/dhmt/nz3nPzJMnSeA4g3gldk2+o=;
	b=QGZ0eClbLf7+tKolXce4i2Qeyb7j7MYvf/9dy2QY/6P0MLbwrRujTWWZZuTKPTGeHoabwS
	M8IjAX3+JAeRICODn+51FJiwgR+4uCrEobbguosl4d0QzYfICIW30FfgO9ZeTOJOWMY0DP
	eSI7DbdFXNJMn6bhtjFLMp67MtONETw=
X-MC-Unique: 3QuNhm-rMiq-R7rs8-SyPw-2
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=h/5F9ZmvcWTg5NFiTJSns8T9NaWLRRT8cV0SuYPpL5HZcuooSoxTG8VpdGgLftNdhxSk9ZFQBJUWJTfZH5+C+Xpno+eLCXD7MjiPLXz/m4/NgboYR/FmFkEGbi2Zwc9smUjKD8UuKZqUXSkBJq+sRoltWx/toAzJti1og/NeC4z/iJ5h4B+bcF5iB2oXnJkqXcOaE+Lk8joR1nbh1tuspZq6Q76B/WPlYqBEYYtmifs3R6GV5beGXls0K/oaY9yVGQHJvJ9gcNGPXxhRWFAYp5sZF6TcxvZkbOyXygrYmCvX/FDpg5MziQccTzvarVmT3j4bVo+9KZ1duLVH32/0FA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=14jtNC+yODdnQcK/dhmt/nz3nPzJMnSeA4g3gldk2+o=;
 b=ZrzmrA8YNY20M7Tr/qAcHxu/LtJSDtySF4Ha7kyMg4Sg3s+hcHD5EQpDl0TD0NrsxB2FHFur5jbMqAhcTzNpwOQXSVc9eDedaQfc6kj3uDpD1QENG47AodNMbxz0QSaI6r8B9bS7ujFlHIW1VfKVqpfec5zJyv2mn7KW51dLvvP3WETK1vM1RwszmqgCAD+LKx6g6pG1/94jJKua8CE501G5oAOO+7k5+aB6kkN1nqmALMcCjAD8ilK8AZ+KWUUZCYIDTjkvJYkZLBCl+5r64LD6ka7ERh4Xb3cRwsNaGtkgWPxZ5jQ1baSNFvzu6//M4kP2j8dWiSNoyNqkjn6/vw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [PATCH v2 1/3] xen+tools: Introduce XEN_SYSCTL_PHYSCAP_vpmu
To: Michal Orzel <michal.orzel@arm.com>
Cc: George Dunlap <george.dunlap@citrix.com>,
 Nick Rosbrook <rosbrookn@ainfosec.com>, Ian Jackson <iwj@xenproject.org>,
 Wei Liu <wl@xen.org>, Andrew Cooper <andrew.cooper3@citrix.com>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Anthony PERARD <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>,
 Christian Lindig <christian.lindig@citrix.com>, David Scott
 <dave@recoil.org>, bertrand.marquis@arm.com, xen-devel@lists.xenproject.org
References: <20211006105827.15217-1-michal.orzel@arm.com>
 <20211006105827.15217-2-michal.orzel@arm.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <6c97eefc-77a0-5e2d-92b1-6cb704a93e13@suse.com>
Date: Thu, 7 Oct 2021 09:59:04 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <20211006105827.15217-2-michal.orzel@arm.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM5PR0202CA0009.eurprd02.prod.outlook.com
 (2603:10a6:203:69::19) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 682e8a4e-c5ae-4373-1ab4-08d989685a78
X-MS-TrafficTypeDiagnostic: VI1PR04MB5903:
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB5903A036E88D28C01C1F670BB3B19@VI1PR04MB5903.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6430;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	fJs2gRkNNVDxAfAiJrafKo/NKGX9ws5a8TvCbXjnN8v86jeTEyCMjJ7Yj/T0OXuXpwDW2WrwL6HCnfDplb+tWXiMT/vt3ws1FGRVYOMmBdEy+Q0e+POtNiIfYUISin7HZFid8Dko56bP3Z9lQHGoSyZXDv6fkewJHmAYZvSHtULgTQxyeUdOWSrqJmx3lmBZG6uJWE+zU6YDrp3sCs6ml/Uy6FHwHVxhhXjNpGHnjB4y6lYB5KmdpV40T70s9z81BQ9dejZg9s67LR3nQ96hNU0Y2btTBKRSaBCNGEJxij1Z3kVM3tIHs4/JDEGg0pf3+pKeHtzs4V/oz5seRa4W0ND5giEWr7p65hvKniD65S7RFfq87ICutQJV5xbno75WZlsMtXweElZsAwJ0JxSHHfVWGf9nKnlKoh+chQe6ppe5xwpjsueAmG6D0eiOE6rpQbZCRWHqneuPck5GDOa0nc3pFo9bM/zIDt2m3LQ6E2JPo9LkOrrei+iD5RkwhY3FnMgoylQNjz1kcEBm/egmPK2TZx6ldpJZNFc1gfgzPD2wQ7kpWnS8pD/O7vhje1h7zsfzNpDyYdEKLrBxmsKUIel+VTzkbb8U8atXezN4MCwDA+NVqjqPC0mdcROkZqNLjUQUOjMoFMOMDKevX+detOlMKRNXZwEzxZKhJ7uOufP5nfNOfxmJGg4nBo0UEp25l2DpUQdsDdqhhKHo7r/l1p6mS1AKWi8IbR/TmhoOG/U=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(5660300002)(31696002)(31686004)(8676002)(38100700002)(16576012)(4326008)(4744005)(8936002)(316002)(6486002)(53546011)(66946007)(2616005)(86362001)(508600001)(956004)(66556008)(66476007)(6916009)(36756003)(186003)(54906003)(83380400001)(26005)(2906002)(7416002)(6666004)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?aEZkMVlJa205V0tkVzRBS2plbDR4YWJTRG9hU3UrT0hlZExTQXNCdWZSd09v?=
 =?utf-8?B?SkkrcVduVGpPeTVvMjR0dTdtV1BVRWxQa3RQTGI1NVRCcjFZN1BibkhaWXZO?=
 =?utf-8?B?eW41amJiUlZZSzlTRkR1R015eTJmWk5hMENwWHgrTFZudGoxcEx6dUEyMVYr?=
 =?utf-8?B?UkorM2tmdFlIL0FxckkveFFZcnFFcmppR0t1L2hhVUg4UjhUdHpRUXN5UTVU?=
 =?utf-8?B?Zll0TllWdWxydXVHSEdTUE1odGlKYkRiQ3gwTEdMRk9HWGluQmJUVC9xNlBB?=
 =?utf-8?B?UEhIb2dBc2czbE5abm5JclhHOTlLVzg5bXFMZHNYNkkvajg3Z2ZaN21Ydzdy?=
 =?utf-8?B?ZUVidkFUZ1YxV0dPQ1dkejY5YW9GSnZ1NmxrQ1c2Y2YvaGhqZXQ2UGRLa21r?=
 =?utf-8?B?TnU2TmZEUjdFYW8vaDFJckh4Qmw5ZXVhc1pLV0gzaUE0WWlMWDlUVGVVajJi?=
 =?utf-8?B?SExWcWdpNGh4c3ViMU1ZVFlWd1ZwemFBWHNGUmxQZ0pRanI2WXhtUW1CV1VX?=
 =?utf-8?B?VHB5WmJSM0pma2hJVzB5MmdpK3NUU0dENUZUeThaYzVBWlhHVEVaQ2o3N0c3?=
 =?utf-8?B?b0FESDZSTzFNVVNUVG5TWGNhNDJ5MUNPK0xXNVVhdnpVV2RQK0ZVK0ozTk42?=
 =?utf-8?B?UFFDZFVYMkQ3SXp5MGVLNkQ1Ym1MaTRRNHJBUGZnV3JuN3RNYWJobDYxMEwr?=
 =?utf-8?B?QnVGclQrTDNYY3VlL1FwdnhXM1NhL0VoZXpSY2FadEU5V1R6OHdieVArV01R?=
 =?utf-8?B?QUZoZFpBaTJ6d2lSTXVRT3FsRkQvanpLQ1d5MnI2TzN5WjhEdUZkcEJndEh1?=
 =?utf-8?B?ZFBiSkhUdnJmSGJhS1BvbXVHTjB5MEJ6TmxaMDR1TEoxUFdaWUFCdlhDTFRy?=
 =?utf-8?B?czdJSFJMbDFXQms4Rm0zdXFCR2VzeVRqT09RSjV6U0t4V2oxTnYzVWJPQi81?=
 =?utf-8?B?OW9McEVMUVJvMUtOb1F0bysvMGxlYnpPa3pLRk5TN2FpaFhnSUQ1c1dPN0RP?=
 =?utf-8?B?aFJ0bDBCcmFMSW85UFFmenlWTXo5NjJPYXRjSThUR3VYcFBLSUJjcjYyTXZI?=
 =?utf-8?B?Q1N2dXRVVlNDZ0NVbjQ4YWEyVUNQNGhaemI2RjNqT21ZUGdFQ0orWUhQQ1BF?=
 =?utf-8?B?WTE1QkpTdUdrYmxTa1hvUjAycTQwWkRiS2VxYmVPWXk5bCswSlpXcGZnMlZG?=
 =?utf-8?B?UXI0K1VCR0htTGVNRXc3dG9RcDZUdGlGUUdXMzFnMThsLytjV0U5dlNGbW9N?=
 =?utf-8?B?UjVVM3l3SUhSZU5rdXNOeXJaNkF5NjQ3cmtzM2toNjhMVVFCdy91dUlJb3JH?=
 =?utf-8?B?UjZZRitQVHcxK2Y2aks2QzluRVg3dU5MSVhOb1dONTdnWTU0STN0d0dvZXlH?=
 =?utf-8?B?MTFpZW5Kam5UYTQ2WWI0RlJrU0lpWnBDeXZERVVsemFUNmk5TlQyMUswTXRJ?=
 =?utf-8?B?eSsvUXhIa254cjVrcER2SGcvRklmQ0JkRjYyRGJXMnp6cDZzaXVVTFhyWTZR?=
 =?utf-8?B?Wkx5NFJ3SGZzVEpBZ0VLbHNYbElHU2w3SWlHNVovekRLb3hzcldCTnM1R1c2?=
 =?utf-8?B?ZDZuMWlORGR4ZE1DWG1IMUdjbkFmcWlYVmNocjdjbm5RU010dEVIMkJZT0RC?=
 =?utf-8?B?ZUxsSXVEaFJ5RW1mQktGTjZqVzR3YXBELzJwVnhaT3hLd2tjSFVuUlpldEpa?=
 =?utf-8?B?dW9USjBUTU51NFFlN1BUTGdKUnhXN2RURTNtN2ZTb01meU1ZalIvckVnYkxS?=
 =?utf-8?Q?NKBN7eS+HsIjfFqxPql7UJ6UltDF/t0nQYIXOTc?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 682e8a4e-c5ae-4373-1ab4-08d989685a78
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Oct 2021 07:59:13.8419
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: cDAFmU2cNMHq3fjoW2jd4aeGNiuhL82Vc2FQBLm6WrNKyxGRD2eAQlkO0BmjtSttg6ixaWcTMmfeTkcRBTUe9Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5903

On 06.10.2021 12:58, Michal Orzel wrote:
> Introduce flag XEN_SYSCTL_PHYSCAP_vpmu which
> indicates whether the platform supports vPMU
> functionality. Modify Xen and tools accordingly.
> 
> Take the opportunity and fix XEN_SYSCTL_PHYSCAP_vmtrace
> definition in sysctl.h which wrongly uses (1<<6)
> instead of (1u<<6) and does not follow the standard
> of using separate macro for a flag field.

While adding the u suffix is fine with me, iirc not introducing
_XEN_SYSCTL_PHYSCAP_vmtrace was a specific review request at the
time. I would similarly ask to avoid introduction of
_XEN_SYSCTL_PHYSCAP_vpmu here, for it not being consumed by
anything other than XEN_SYSCTL_PHYSCAP_vpmu's definition.

Jan



From xen-devel-bounces@lists.xenproject.org Thu Oct 07 08:03:05 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Oct 2021 08:03:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.203354.358455 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYOMr-0004Gt-7U; Thu, 07 Oct 2021 08:03:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 203354.358455; Thu, 07 Oct 2021 08:03:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYOMr-0004Gm-3G; Thu, 07 Oct 2021 08:03:05 +0000
Received: by outflank-mailman (input) for mailman id 203354;
 Thu, 07 Oct 2021 08:03:03 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Y1KR=O3=arm.com=michal.orzel@srs-us1.protection.inumbo.net>)
 id 1mYOMp-0004Gg-8N
 for xen-devel@lists.xenproject.org; Thu, 07 Oct 2021 08:03:03 +0000
Received: from foss.arm.com (unknown [217.140.110.172])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTP
 id fe60deb8-2744-11ec-bfc1-12813bfff9fa;
 Thu, 07 Oct 2021 08:03:02 +0000 (UTC)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C966E1FB;
 Thu,  7 Oct 2021 01:03:01 -0700 (PDT)
Received: from [10.57.18.238] (unknown [10.57.18.238])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 683D63F766;
 Thu,  7 Oct 2021 01:02:59 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fe60deb8-2744-11ec-bfc1-12813bfff9fa
Subject: Re: [PATCH v2 1/3] xen+tools: Introduce XEN_SYSCTL_PHYSCAP_vpmu
To: Jan Beulich <jbeulich@suse.com>
Cc: George Dunlap <george.dunlap@citrix.com>,
 Nick Rosbrook <rosbrookn@ainfosec.com>, Ian Jackson <iwj@xenproject.org>,
 Wei Liu <wl@xen.org>, Andrew Cooper <andrew.cooper3@citrix.com>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Anthony PERARD <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>,
 Christian Lindig <christian.lindig@citrix.com>, David Scott
 <dave@recoil.org>, bertrand.marquis@arm.com, xen-devel@lists.xenproject.org
References: <20211006105827.15217-1-michal.orzel@arm.com>
 <20211006105827.15217-2-michal.orzel@arm.com>
 <6c97eefc-77a0-5e2d-92b1-6cb704a93e13@suse.com>
From: Michal Orzel <michal.orzel@arm.com>
Message-ID: <19a4b434-3cfc-e9db-80a1-1afb42c57fd5@arm.com>
Date: Thu, 7 Oct 2021 10:02:48 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <6c97eefc-77a0-5e2d-92b1-6cb704a93e13@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

Hi,

On 07.10.2021 09:59, Jan Beulich wrote:
> On 06.10.2021 12:58, Michal Orzel wrote:
>> Introduce flag XEN_SYSCTL_PHYSCAP_vpmu which
>> indicates whether the platform supports vPMU
>> functionality. Modify Xen and tools accordingly.
>>
>> Take the opportunity and fix XEN_SYSCTL_PHYSCAP_vmtrace
>> definition in sysctl.h which wrongly uses (1<<6)
>> instead of (1u<<6) and does not follow the standard
>> of using separate macro for a flag field.
> 
> While adding the u suffix is fine with me, iirc not introducing
> _XEN_SYSCTL_PHYSCAP_vmtrace was a specific review request at the
> time. I would similarly ask to avoid introduction of
> _XEN_SYSCTL_PHYSCAP_vpmu here, for it not being consumed by
> anything other than XEN_SYSCTL_PHYSCAP_vpmu's definition.
> 
> Jan
> 
Ok I did not know that. I thought we should stick to the previous standard.
Is this something that can be fixed on commit or should I send
a v3 only for that?

Cheers,
Michal


From xen-devel-bounces@lists.xenproject.org Thu Oct 07 08:03:29 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Oct 2021 08:03:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.203359.358466 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYONF-0004nD-Fg; Thu, 07 Oct 2021 08:03:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 203359.358466; Thu, 07 Oct 2021 08:03:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYONF-0004n6-Bq; Thu, 07 Oct 2021 08:03:29 +0000
Received: by outflank-mailman (input) for mailman id 203359;
 Thu, 07 Oct 2021 08:03:28 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=qfpx=O3=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mYONE-0004mr-Mq
 for xen-devel@lists.xenproject.org; Thu, 07 Oct 2021 08:03:28 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 0d4d3d73-2745-11ec-bfc1-12813bfff9fa;
 Thu, 07 Oct 2021 08:03:27 +0000 (UTC)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2113.outbound.protection.outlook.com [104.47.17.113])
 (Using TLS) by relay.mimecast.com with ESMTP id
 de-mta-25-h54VKsxxPLKuKTOelJ79Jw-1; Thu, 07 Oct 2021 10:03:24 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB5743.eurprd04.prod.outlook.com (2603:10a6:803:e0::26)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.22; Thu, 7 Oct
 2021 08:03:20 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4587.020; Thu, 7 Oct 2021
 08:03:20 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS8P189CA0002.EURP189.PROD.OUTLOOK.COM (2603:10a6:20b:31f::21) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4566.15 via Frontend Transport; Thu, 7 Oct 2021 08:03:19 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0d4d3d73-2745-11ec-bfc1-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1633593806;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=PPvXMUt1yXPsruUB6mUTf5wWpPPb1iAQDcQabh6jiJ8=;
	b=EjViQzXCXB5Ya6165psSoaL1Vfju6tZ+z5ttrdc0fjs8LBMV1f3Yk20tU+YlPA7cHoLrdD
	u060CWA4HMoYb4ind50DCsmg6Bvvl/f1u1ExRmUj9QdQd8SQux8eZfD3aGEvjw+DOlLZoq
	TwtESwwBGDnIQM5Dk/sU3v4iz6lhCCg=
X-MC-Unique: h54VKsxxPLKuKTOelJ79Jw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=OFuJVeALfFFxIW4k3Jz0KiYgglgwwZ1x3ya8lcLINj9lVUACo4zeEeTOZLnqV6N+zXu1o+RieEqYdxWC+8wtHz1DXedGUdT43RM01ZF8lJjelBc5wnUfagv7ovLO+fniS5wQVr6umsWRvl1S/y1zIY7/FWbBunfLg0Y8l4x/YulNBDSTJDY/GmetJfbCmqB1EjZmkLlG34/rftTNEEsGZsMx3IEmY/ZlvD9NPuFzYDtTxHHnQgP3HskjJAR3ilyEDqprYdMlD/gbs6wLaxWvrnQAQa4v9sOTMz8XRh1fTiRwNTks/wLxMh1maTvxTnOQLe0RmnVgxrGz5qvach5cwg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=PPvXMUt1yXPsruUB6mUTf5wWpPPb1iAQDcQabh6jiJ8=;
 b=oHKe6IIq1eVNWtqUELfkSlQzjLwy9GyHKCNdhZRY+bQ4GjX7s+sVCxvlRLUdhmCwQW1qE/d9xuDcxkPtv560dac/g3819CzYWLk1VUUh02/oz+xzKb80ABJ3xTtyY7QIyofFHVmSgt6x/cjTZE1gEnmmnmQGt04Zx2wfPdNas8YRb4Q/Jcl1xhBxC4AA1Z3PdiKRqq4T/5Z6eBrlIW1llTFEUIPTQSDF0bOT/jqTYB4LQzFcF0ycBBxxUkwQ4EYvbNkmHcuSDjanz2IBYa9frAnjhIs1qIanz9QxFOq6SFfhvtJH2uq9nyU0o15KMQKBbEf96CIL/WZfnGiMu5Y7xg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [PATCH v2 3/3] xen: Expose the PMU to the guests
To: Michal Orzel <michal.orzel@arm.com>
Cc: Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Nick Rosbrook <rosbrookn@ainfosec.com>,
 Anthony PERARD <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>,
 Christian Lindig <christian.lindig@citrix.com>, David Scott
 <dave@recoil.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 bertrand.marquis@arm.com, xen-devel@lists.xenproject.org
References: <20211006105827.15217-1-michal.orzel@arm.com>
 <20211006105827.15217-4-michal.orzel@arm.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <45bcc00d-95f1-fe20-a68b-de2eb793dc5e@suse.com>
Date: Thu, 7 Oct 2021 10:03:23 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <20211006105827.15217-4-michal.orzel@arm.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8P189CA0002.EURP189.PROD.OUTLOOK.COM
 (2603:10a6:20b:31f::21) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 1005edb6-6ec0-4dfd-f718-08d98968ed92
X-MS-TrafficTypeDiagnostic: VI1PR04MB5743:
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB57432A681EA9DA47130DD2C0B3B19@VI1PR04MB5743.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	MaCt7T7xB1m+Ob2Q/xKbgqzQZenHFilp0fIC+auPsEnFm8pBJsuN3j6y/+A+V/Oc2aM26c1XO3oTmS0f6M8HeOEZlp8f2cpO0lqziXBNBb+vQmU4xGmXSY6cPcYp4Tx9YC7S58eU9uITBjNCPyMUscdvYXQC+Sl7+abl3yctysQtbQkdPvuY0PfKh0fAawUz9so/sXnWNh9WmeWnOQZVZXLjidMZEeu66SD4OHLrytXHMfZVjlY4b5+PmmR5jNGNlf8PWDozcwoyWU9FSNc4I3arGseNSDyHN+kELQiWK3QJXXsk8YZYuWbacpBhNOnVcvbZ8K7jCzZkCnjRxM59n3YAl1frqAuBus8XsduqkHBVQN+x+Oj6teAr5d5dfI6uOyhZ0ADpWqI/lq28QTbMferZETSYxJJ/CxbiylNXZElrYVHFwzYW+CmehLpXVtrBd1XnZdijERA5Hzhg1/xYOPgFkwlPVI+RlwAsASh/dOyrIpmEEmO2VEjbdMHk2+I6wb6G73M0pOczdAzwXdaaeec/kaLM6lOlxgSBXkGkKeYEsnPUcx/sTo2bN79c79KNnrp/bURfhc+/zC4YbTxeBe4Fj8HICZ091VkSerpc4cEqD2a2aAaGOya+D8vddpnRKW+c1Td96lppzs5EJx1SVFzWkLm9RldGn5pM2/WC08On5iVyq+rEwMX2726kmYZIp8loTv67gBdPGdGgKhVjoVP+0S5jWHw+cYwUZD8apUA=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(8936002)(36756003)(2906002)(4326008)(6666004)(8676002)(26005)(5660300002)(86362001)(316002)(66946007)(83380400001)(2616005)(508600001)(54906003)(956004)(31686004)(186003)(16576012)(6486002)(53546011)(6916009)(66556008)(38100700002)(7416002)(66476007)(31696002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?S2lad2g5TUR0dmFDdFJ2bjZBZEtDYkJKWUNTanVOeEw4a3h4aUYwSmxBMVd5?=
 =?utf-8?B?TW9tZEZEcXdjVStjSjAvd0UvSk1GL2U0NDVUOVFUYUsxQTc1RmE3dmMxdEVu?=
 =?utf-8?B?TGdLWEVFcDc2L3Q3K3VjYllPb2ZnbWhocDVwVnpmSGViT2lYbTZxdGZOMWVq?=
 =?utf-8?B?UXo5WnRtTnFFRml6RDNTVE8vVFRNTmdxa1ljTzlVTHB5bk16dWtRbUFSb2Qx?=
 =?utf-8?B?aWdIRXZwclZSTmZTbDJFQjkybVNjaUU5ejNORmIyOUU3Rmg2eUhzVU5RMFpU?=
 =?utf-8?B?VzhyeW1RM1lHS2x5UVVucmIzSHVOME1icUdDRVEvRzN4dzJDcUlUemxRZi9Z?=
 =?utf-8?B?VTVJdUFRcHlpTklRa0JudEpvMGY2RkZONExDQWdXcmt1dkxPVExXZXU3Rlpl?=
 =?utf-8?B?Z3lnSEpOTDhaTDhiUFhTbnpGelRIemRyOHFwbzJRc2hucjN2bW9USW5PWkd6?=
 =?utf-8?B?Z2lPU2VPZGRvNVpyR2hnMkQyN2tka3BNU3QxazBhTjN6RmxMMkJPamJnUnJC?=
 =?utf-8?B?QTdldlFMMS9GNmNrNXh2TFc0eHNVNVNIZ2xkOTR2RTFUM2kva21ZeUpObDlU?=
 =?utf-8?B?cHM5TytXTzZFQnJQT3pqTElwRm9YOFpSckpuOWpWRW4veW5uM091SWlGV3px?=
 =?utf-8?B?UjFBQ1N3K3IzMGVmMjNiOFZZYWozM3ZCcUUvS2RLczJFRStSazdBU3N3SmpD?=
 =?utf-8?B?TUh4Ynp3VkdBSlZKeEVmQ3cvVUpVRm10VXBkWTl5QUw3YzBNQktHZWI5OGtT?=
 =?utf-8?B?VFVwdzlQY2hOM1NXaVdQMU1kOHNEaFpVVjVJYVdPYkRyNVppTWRVOXNwbXFL?=
 =?utf-8?B?NnlvTmlkREJITW11NkdRTnplMlRrRjJkS0NPRnFSK0pSS2E3NTBJSjVSOFVn?=
 =?utf-8?B?eHRSNHpVN0NCVzBVNEcvRkpxYXlsZXArMHROU3EvdTFpWkx1eDNCd08wRHZ3?=
 =?utf-8?B?MW1LUGVHRFlYMHpXbHZzMS8yOGs2dEJsejN3MXhIcEVZaUEvUTlaejA3U2hi?=
 =?utf-8?B?N2xCbmZIVjlnRnFScXZMTGNnTGo5TE1UWmNoSFZwRzJsWVY2aTlRUWZmdUpH?=
 =?utf-8?B?dWt4dGRjclBiMTM5eVBRTFk2a3BKRXBSMmFFWlVld0s3alNQekphSkFidnRG?=
 =?utf-8?B?MmtaS1FnWnlPakpJM3U3Qm1ZMTg4OXp2TzJZRUY3MnF3TXZRWHI0WU5XQ3pP?=
 =?utf-8?B?MGRBMk00OWpsamFxZll6Q2VPbk5IMFNHM1FDQ0FmTWZTaVhCS25lSi95ekd6?=
 =?utf-8?B?REJORk9LY1I3clAvZHBrYy95eGhpNzNnRnZZN2cwMHVqeFFxRDFVak5NcTg1?=
 =?utf-8?B?V3U4VGEwRzZpOXJQYWpyZUQ0YU11czQ1Q1lOWWkrYStXZ1VOKzN4VmQvemc4?=
 =?utf-8?B?Lys2ZHVtVDRKbk8waENWMGpmbUp3Z0NXTGxJalFDQ2pZVWVOVDdGSFBnNWoy?=
 =?utf-8?B?cjgrYkJnM2tORnYrQUt3QjdPdlN2cE1KWWtFNXZydmpTT1pxQ0NRd3RRdTNV?=
 =?utf-8?B?OUZGNVdCVlBiZDRoWFRTNmdVU2NFYnJ6MkkycUxkQlNROXlwVDBvbzc0Sm5D?=
 =?utf-8?B?RENsV1F2MFZiRUlUei9TR2VaZW5Jc2ZZS2YrOVp2V0xOano1UmNrQlpnckpo?=
 =?utf-8?B?MFRRbkVXMWRmNjQwVVRKU1RHNi9xZXZURDlmTWhnMWVsd0h1QkpyZ2VuaVlp?=
 =?utf-8?B?Wm9lM3diUXdLd1Y2WDhVY2NzSWFwOXRQTzJ5RWRzZ3M0WXNheUZnVllQeEhi?=
 =?utf-8?Q?A8Ppf/m/UUe9oPLPHNlthbC+6boKbBbBi/5NJYV?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1005edb6-6ec0-4dfd-f718-08d98968ed92
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Oct 2021 08:03:20.6350
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: dGxHjWiVvoazI2YnXAvE4iNPrx/cjimFUO5OaQFAxvSXvzwI7kAEt3+YpZBCF+5jbsWqvXQe8tRk4najuBaEQA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5743

On 06.10.2021 12:58, Michal Orzel wrote:
> --- a/xen/arch/x86/domain.c
> +++ b/xen/arch/x86/domain.c
> @@ -692,6 +692,12 @@ int arch_sanitise_domain_config(struct xen_domctl_createdomain *config)
>          return -EINVAL;
>      }
>  
> +    if ( config->flags & XEN_DOMCTL_CDF_vpmu )
> +    {
> +        dprintk(XENLOG_INFO, "vpmu support not ready yet\n");
> +        return -EINVAL;
> +    }

I consider this message potentially misleading (as x86 does have vPMU
support, it merely doesn't get enabled this way). But isn't this redundant
with ...

> @@ -534,6 +535,12 @@ static int sanitise_domain_config(struct xen_domctl_createdomain *config)
>          return -EINVAL;
>      }
>  
> +    if ( vpmu && !vpmu_is_available )
> +    {
> +        dprintk(XENLOG_INFO, "vpmu requested but not available\n");
> +        return -EINVAL;
> +    }

... this? (This message is again potentially misleading.)

> --- a/xen/include/public/domctl.h
> +++ b/xen/include/public/domctl.h
> @@ -70,9 +70,12 @@ struct xen_domctl_createdomain {
>  #define XEN_DOMCTL_CDF_iommu          (1U<<_XEN_DOMCTL_CDF_iommu)
>  #define _XEN_DOMCTL_CDF_nested_virt   6
>  #define XEN_DOMCTL_CDF_nested_virt    (1U << _XEN_DOMCTL_CDF_nested_virt)
> +/* Should we expose the vPMU to the guest? */
> +#define _XEN_DOMCTL_CDF_vpmu           7
> +#define XEN_DOMCTL_CDF_vpmu            (1U << _XEN_DOMCTL_CDF_vpmu)

Like for the earlier patch, I think we should stop with the bad habit of
defining both the bit position and the mask separately.

Jan



From xen-devel-bounces@lists.xenproject.org Thu Oct 07 08:05:34 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Oct 2021 08:05:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.203375.358477 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYOPC-0005Zy-Vx; Thu, 07 Oct 2021 08:05:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 203375.358477; Thu, 07 Oct 2021 08:05:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYOPC-0005Zr-Ss; Thu, 07 Oct 2021 08:05:30 +0000
Received: by outflank-mailman (input) for mailman id 203375;
 Thu, 07 Oct 2021 08:05:29 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=qfpx=O3=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mYOPB-0005Zj-TM
 for xen-devel@lists.xenproject.org; Thu, 07 Oct 2021 08:05:29 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id e113a91e-520d-484d-8674-83083dcd4866;
 Thu, 07 Oct 2021 08:05:29 +0000 (UTC)
Received: from EUR03-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur03lp2059.outbound.protection.outlook.com [104.47.9.59]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-23-J90HtK3SNHSaVj0kxlrLaw-3; Thu, 07 Oct 2021 10:05:27 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB5743.eurprd04.prod.outlook.com (2603:10a6:803:e0::26)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.22; Thu, 7 Oct
 2021 08:05:25 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4587.020; Thu, 7 Oct 2021
 08:05:25 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6PR08CA0047.eurprd08.prod.outlook.com (2603:10a6:20b:c0::35) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4566.15 via Frontend Transport; Thu, 7 Oct 2021 08:05:24 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e113a91e-520d-484d-8674-83083dcd4866
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1633593928;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=IQildSs5R9Avr2U1TPosDlRvcDgGAd5+zSEEpLXIeks=;
	b=l18efNCgcwnzs1iT+qUkLetKT9UVlveea5ZgcE3RHp7iyTISphXMC5LL3DYjhJxmNyeCFJ
	XZzh3dwSOXPDlEcgoHO/cUmKbv/aSGC7NZoFgIUufRG/EAI3AJ4G+8lF/JRFFTrfyQ8FrZ
	ReD3OkjHOYD62XreCzIIZUzWe7Ew+Ow=
X-MC-Unique: J90HtK3SNHSaVj0kxlrLaw-3
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=P4+eusjb+iKn8zgxPn+MlpABP/YvcnlTKuQCdaFYx/bmqb4O8UGSopl2z8hEnJuefTwSqBDfqlqlGYcd1NMcvNOCnPE5nu5C/3WaWYsw6xwZNvvD0j/ZA9Cm1BEty5/0CBxebajDOEfbvz4mC4RzpWx/P4/WMmTqGutZTEg+ZVQo9n28r+gNAlatRVsy1ZhgXAZtaCleCcnnaJFn87OLBNx57T32HPqx76AfQNmXeJ7Ufyo9rplo+teE2niWQVPdRmSeZLnsrB8qMBC1l2buUB9OLdhCMHZ0H94Nud2J5VacPp3VgJNx6Q9iQBAPhayd85OhV8JhRPhbTEDOFM3ygg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=IQildSs5R9Avr2U1TPosDlRvcDgGAd5+zSEEpLXIeks=;
 b=Z1jPMDkj0ybPpBKB5vqE41UVqQhYR6R3r6Wjc8/XeATl+bbBw9EH1iTIf+HbXUZFFpYJ2FV/MdPuzdI64o4TJiJ/PnjFGzecDuAcjB2Ceo/FECvyCF4IdoUqwsdg5673jTFgA1HWJIBlFvLksZdUpFaWhuk9KoG/JLXbsZ1t/j8MVwUyZrAWcbiN6p/UbzdDR7uib2s2naPCX6FHPovXCwGawu6R/ZChgAIsTishSNXn5CQ9PoXKm7BYHK39Dgzk55x4dXwzp+SKQCFv09bwvTwu4+4VeMTIbhH76bKhaCK8daOq5RE7r495cTCQx8dsikorD8dzzJ0Tl3ie543HRw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [PATCH v2 1/3] xen+tools: Introduce XEN_SYSCTL_PHYSCAP_vpmu
To: Michal Orzel <michal.orzel@arm.com>
Cc: George Dunlap <george.dunlap@citrix.com>,
 Nick Rosbrook <rosbrookn@ainfosec.com>, Ian Jackson <iwj@xenproject.org>,
 Wei Liu <wl@xen.org>, Andrew Cooper <andrew.cooper3@citrix.com>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Anthony PERARD <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>,
 Christian Lindig <christian.lindig@citrix.com>, David Scott
 <dave@recoil.org>, bertrand.marquis@arm.com, xen-devel@lists.xenproject.org
References: <20211006105827.15217-1-michal.orzel@arm.com>
 <20211006105827.15217-2-michal.orzel@arm.com>
 <6c97eefc-77a0-5e2d-92b1-6cb704a93e13@suse.com>
 <19a4b434-3cfc-e9db-80a1-1afb42c57fd5@arm.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <9918ad74-e089-4df7-bd31-3440d1ffeca3@suse.com>
Date: Thu, 7 Oct 2021 10:05:28 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <19a4b434-3cfc-e9db-80a1-1afb42c57fd5@arm.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR08CA0047.eurprd08.prod.outlook.com
 (2603:10a6:20b:c0::35) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: cbd6cb8f-473a-4b7c-68ef-08d9896937e5
X-MS-TrafficTypeDiagnostic: VI1PR04MB5743:
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB5743B213244195FDB5DB8D57B3B19@VI1PR04MB5743.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8273;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	fxVpLRdbkaQfGYLFAjqWisex9HMWzqK6onW4DojMYayYK8cdJJQvuOlgPJlCFwPPlymmSgi9aSkmnVz9ESI3hhe9ilZ7sJ2Jffsv44zjvSRH9pxwvysGB5lrDW/Ta89+yW4kWmloZzu4ZOKt8vyMozRisa5XyoqQ1X7IZCrvFJSk4vzrHx69IZpqxrbUdNVJNDUjM4Etyw/wzK6fPNFHC/nWP7K31ldyfPOsdH0vA3Df2Hd6qWubwpilCQ7XBmdXvbJ4q25EnEsmGn+PW7ROedjSXG1NJ/5Jygz0AvLyyec9z+Ot0VZ8+XTwOGG4B3uF1lNBmt90Fozp7jihygMBSvsNL3MKR6ZctdysBfBgnUyksrgoM0nFT3vKPEvFxd4U8kAFleW1Y3b3qfFipRwx0zt88giyJBwcQ4DRDRQlXYpgB1ptLKWIG/blXrNYdHSaxcixcRhMQYROrLX0LwPYlBc1g1JbjmaB0ykdjBsWUZ5c5ukfo42KS01zYy/hIb7hY6HbbE5ksHunH0wCnAFjLIUiVgnXcwnbF0G6GMHsGuj3lpRQAjXNcx/tgyN4ACK+oUzsTRVSoNBxw/CbaE8VY/527Sc8YBOB5CU1njXrfJHECXMfk7wS1ydKg3mOTHeJzrADSjly1vbNfCAjQY08kwCz7ByH3OVKkoi8XUia+SvSaUGD5aHwqPvQtcPqw//6Xz1AhB8OZo555/ZJhcFmglkGQRCxFHHdfGKdzQ5kLew=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(956004)(31686004)(186003)(316002)(86362001)(508600001)(54906003)(66946007)(83380400001)(2616005)(7416002)(66556008)(38100700002)(66476007)(31696002)(16576012)(6916009)(6486002)(53546011)(2906002)(36756003)(8936002)(26005)(5660300002)(8676002)(4326008)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?RTBScUIwRWQ1WFdkbGNNQngzU3J4KzJ4V2p4blZzWGMrdXYyRWRYWWw1T0J2?=
 =?utf-8?B?SFpTK2Y4dEZEblVReTdrSitRLzNLNmIzejRSd3p1MGVLemM4OHdXTVU5TDdV?=
 =?utf-8?B?SXFxeG5IZXBVK01CVlhQZzczS2lXRk8vaFZJVnpzeXJiOWdvYnFSOVFsRGZk?=
 =?utf-8?B?Zm5jdUpucS9sdERWRnlMekJ4Q1ZXc0FGWUhuUE5jNVdMVUZvd1g0OWxMVGVw?=
 =?utf-8?B?VG5aRmoxM3lacmFoUHp2aGloS1pyUDJsVUd3a1ZobDdYb2R1Y1BtTHR5QUk4?=
 =?utf-8?B?WUtqUkx0MU5rR21ZWnppYmxqZ3N1dTZEbjA3citjR2RYWmJkVVplY1phT25T?=
 =?utf-8?B?ejBIUVlrYkRsYm04RCtRSDhadVcxOHovUy9pN0w1c01hdU12dzRaMTBjQlQx?=
 =?utf-8?B?Tm13TTYrNDVZSjF6SGExRG1XalJ6UXpTTEtNdjdjajk0eSsydUFwMVpEK0Qw?=
 =?utf-8?B?ZkM4b2hidnAyQWVHREpDdnNUZlVVb2wzWFFpMzFuRlpmVFdkVWVEU0pwSzJs?=
 =?utf-8?B?YUdUMHBZSzBubU1mWG5PczM1bHJpejFYODFEUTJxUzZqUWh2VGJyU3hKTERP?=
 =?utf-8?B?VkNYSkFhOGk3SHZPV1l3UDA5b1o2Q2FQQmJvQnRqNTNTT2JNbmtMSVVoendu?=
 =?utf-8?B?OG0rUFE1VXZLV0U3T1UzNHdwNVRzNVhrcjVIRlUxVnpKNXZIbnYrL2p6T2lj?=
 =?utf-8?B?SXUzcHJkakx1MU40SmxhZzIrTnAxQUhocTB6ZFJ5Vk5aR2c5QkltUXQzaWtX?=
 =?utf-8?B?K0RIVHNJV2EwaEptMnE5SEw1SlRzeGxNM21EVnpidnFZTndKS3BHRW1HNE9D?=
 =?utf-8?B?MkxXQWhsSkVoQTFmaWtxaWlFTXdIK1VFZjIxcXBXMEQ0b1Y0OGVBU2ovZGNh?=
 =?utf-8?B?N09jVjcyWmJvekxuUFljTFBESkNsNTl0QzhnTyt3c1JMT0ZtZDhFS044ZXIy?=
 =?utf-8?B?cjA2bnhGVmt4M2xpVWk2c1ZQZE9GdDNPZ284VUV0eGJQZTFWWElRWEo3c1Uw?=
 =?utf-8?B?UG5COU5VdVBmbTZlYmR1SjcwUTF0UTczc2NiRkI5RzNmeG56SXdMNmdOMFFy?=
 =?utf-8?B?TDRjTFlhOTJSVUZBU1BzcmdxOXBIOXhDOVREZHljK0x6Yy9HRFJWTkJPYTZI?=
 =?utf-8?B?WTErT3ZpMm5SYW5QMjBpaVNyeG5lUnJBMG1pZjV5a2VDR1EyU1A1S090V0dB?=
 =?utf-8?B?aFkrazAxSno2dHNvWG9rbiszcUNmdWIxdzJ0OGFEUytBNFVML1hKdEJ1dkFD?=
 =?utf-8?B?ZDA0R2d4SUVXZmlwY2drMEhPc0p1UTNRZzNFdm1jeXhPa3BRdCt0YklXVVJX?=
 =?utf-8?B?RktMKzhBcHRaOUd1VVZIRnBkVElEZDVPZDZPUkFuQkVUdlhxTCt2eFBxcHo0?=
 =?utf-8?B?SWlZd2pWUEpDTWw2SW9UUFVMaDBwRStCZFkzSVBJUkNkakl0TlZuS3RjcXdw?=
 =?utf-8?B?MHhubFh5cGhVbnFmSUorZGRGc0RiSkw1Qm05bVNZcUI1STJzU1pVYklDNG5v?=
 =?utf-8?B?VlJOLzRrMG5BR0l1cmo5MEp4bkRra0piMHROSlQyenFhWjg0d3UxWkxpb3pq?=
 =?utf-8?B?dkkyaTROWTBMN3FaOFJzdXRDdWJONzVxME5tQkw4dzhoaGRyRzB5ekMrd3Mx?=
 =?utf-8?B?R2t5T2JxbzEvUWx5dWNjeFpPamhncHhlZ2RaN2UwUE5qQjRzbHByQXFDU0Jx?=
 =?utf-8?B?OFhVTmZ0SGMrUnkyci9uc0tTemZFMjh2NTQrWGs0amQ1N0RkMzJRWXlvQmJ2?=
 =?utf-8?Q?wlMh4deLaRjwZTJe/sdDORQjLO6i4SkU7GQlSio?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cbd6cb8f-473a-4b7c-68ef-08d9896937e5
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Oct 2021 08:05:25.3477
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jj9P0YWd5P5OQM0Flu38sIir401M/G912bJKJ6auyYqWxI/V/iDaO7coufQOsXPO8O69qCJpZUvEJ5Oju3zokw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5743

On 07.10.2021 10:02, Michal Orzel wrote:
> On 07.10.2021 09:59, Jan Beulich wrote:
>> On 06.10.2021 12:58, Michal Orzel wrote:
>>> Introduce flag XEN_SYSCTL_PHYSCAP_vpmu which
>>> indicates whether the platform supports vPMU
>>> functionality. Modify Xen and tools accordingly.
>>>
>>> Take the opportunity and fix XEN_SYSCTL_PHYSCAP_vmtrace
>>> definition in sysctl.h which wrongly uses (1<<6)
>>> instead of (1u<<6) and does not follow the standard
>>> of using separate macro for a flag field.
>>
>> While adding the u suffix is fine with me, iirc not introducing
>> _XEN_SYSCTL_PHYSCAP_vmtrace was a specific review request at the
>> time. I would similarly ask to avoid introduction of
>> _XEN_SYSCTL_PHYSCAP_vpmu here, for it not being consumed by
>> anything other than XEN_SYSCTL_PHYSCAP_vpmu's definition.
>>
> Ok I did not know that. I thought we should stick to the previous standard.
> Is this something that can be fixed on commit or should I send
> a v3 only for that?

You may want to wait for further review feedback first, especially on
the tools side. Considering adjustments to subsequent patches I would
think re-sending will ultimately be better.

Jan



From xen-devel-bounces@lists.xenproject.org Thu Oct 07 08:09:34 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Oct 2021 08:09:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.203384.358487 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYOT6-0006Hj-GS; Thu, 07 Oct 2021 08:09:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 203384.358487; Thu, 07 Oct 2021 08:09:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYOT6-0006Hc-DZ; Thu, 07 Oct 2021 08:09:32 +0000
Received: by outflank-mailman (input) for mailman id 203384;
 Thu, 07 Oct 2021 08:09:31 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mYOT5-0006HS-0h; Thu, 07 Oct 2021 08:09:31 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mYOT4-0006dj-O9; Thu, 07 Oct 2021 08:09:30 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mYOT4-0001fE-9P; Thu, 07 Oct 2021 08:09:30 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mYOT4-0008BN-8v; Thu, 07 Oct 2021 08:09:30 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=PjlYuWrXwpb9iD30vSngi0YT710l8IRW7cnBas7sLTk=; b=DKVEZ1+IVUE+EznTVPtX7+ED1T
	/LCIq6qQSJUR8mQfryEKijzNaEvXrX9rp4Ob1WxMYtTHc9ve7QVdF+A5PCwERZB8ybN2ulnNC4p+6
	ZtQ+70lUZt7OXxluACLRDXiNmmO9fSoBn/Uc9PRMO+QeacK641iVZWQXjiPd7DRRvmU8=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165388-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 165388: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:guest-start/debian.repeat:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=d6bdad32cbb5dfbc68fac32078cc5882071c4f1d
X-Osstest-Versions-That:
    xen=b6fe410936e30b2089cc8c6d54d786e535efafa3
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 07 Oct 2021 08:09:30 +0000

flight 165388 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165388/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 165371
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 165371
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165371
 test-arm64-arm64-libvirt-raw 17 guest-start/debian.repeat    fail  like 165371
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165371
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 165371
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 165371
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 165371
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 165371
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 165371
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 165371
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165371
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 165371
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  d6bdad32cbb5dfbc68fac32078cc5882071c4f1d
baseline version:
 xen                  b6fe410936e30b2089cc8c6d54d786e535efafa3

Last test of basis   165371  2021-10-05 02:16:48 Z    2 days
Testing same since   165388  2021-10-05 19:07:00 Z    1 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Jan Beulich <jbeulich@suse.com>
  Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
  Rahul Singh <rahul.singh@arm.com>
  Stefano Stabellini <sstabellini@kernel.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 fail    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   b6fe410936..d6bdad32cb  d6bdad32cbb5dfbc68fac32078cc5882071c4f1d -> master


From xen-devel-bounces@lists.xenproject.org Thu Oct 07 08:21:53 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Oct 2021 08:21:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.203399.358517 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYOeg-0000K9-Um; Thu, 07 Oct 2021 08:21:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 203399.358517; Thu, 07 Oct 2021 08:21:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYOeg-0000K2-Rk; Thu, 07 Oct 2021 08:21:30 +0000
Received: by outflank-mailman (input) for mailman id 203399;
 Thu, 07 Oct 2021 08:21:29 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Y1KR=O3=arm.com=michal.orzel@srs-us1.protection.inumbo.net>)
 id 1mYOef-0000Jw-Kv
 for xen-devel@lists.xenproject.org; Thu, 07 Oct 2021 08:21:29 +0000
Received: from foss.arm.com (unknown [217.140.110.172])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTP
 id c4a58857-e691-442f-9f5f-acc310020ccf;
 Thu, 07 Oct 2021 08:21:27 +0000 (UTC)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0B9C01FB;
 Thu,  7 Oct 2021 01:21:27 -0700 (PDT)
Received: from [10.57.18.238] (unknown [10.57.18.238])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id AD2993F766;
 Thu,  7 Oct 2021 01:21:23 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c4a58857-e691-442f-9f5f-acc310020ccf
Subject: Re: [PATCH v2 3/3] xen: Expose the PMU to the guests
To: Jan Beulich <jbeulich@suse.com>
Cc: Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Nick Rosbrook <rosbrookn@ainfosec.com>,
 Anthony PERARD <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>,
 Christian Lindig <christian.lindig@citrix.com>, David Scott
 <dave@recoil.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 bertrand.marquis@arm.com, xen-devel@lists.xenproject.org
References: <20211006105827.15217-1-michal.orzel@arm.com>
 <20211006105827.15217-4-michal.orzel@arm.com>
 <45bcc00d-95f1-fe20-a68b-de2eb793dc5e@suse.com>
From: Michal Orzel <michal.orzel@arm.com>
Message-ID: <8682dadb-cb7d-8291-33eb-4988d0d2227f@arm.com>
Date: Thu, 7 Oct 2021 10:21:12 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <45bcc00d-95f1-fe20-a68b-de2eb793dc5e@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

Hi Jan,

On 07.10.2021 10:03, Jan Beulich wrote:
> On 06.10.2021 12:58, Michal Orzel wrote:
>> --- a/xen/arch/x86/domain.c
>> +++ b/xen/arch/x86/domain.c
>> @@ -692,6 +692,12 @@ int arch_sanitise_domain_config(struct xen_domctl_createdomain *config)
>>          return -EINVAL;
>>      }
>>  
>> +    if ( config->flags & XEN_DOMCTL_CDF_vpmu )
>> +    {
>> +        dprintk(XENLOG_INFO, "vpmu support not ready yet\n");
>> +        return -EINVAL;
>> +    }
> 
> I consider this message potentially misleading (as x86 does have vPMU
> support, it merely doesn't get enabled this way). But isn't this redundant
> with ...
> 
>> @@ -534,6 +535,12 @@ static int sanitise_domain_config(struct xen_domctl_createdomain *config)
>>          return -EINVAL;
>>      }
>>  
>> +    if ( vpmu && !vpmu_is_available )
>> +    {
>> +        dprintk(XENLOG_INFO, "vpmu requested but not available\n");
>> +        return -EINVAL;
>> +    }
> 
> ... this? (This message is again potentially misleading.)
> 
Ok. vpmu_is_available is false for x86 so the check in x86's arch_sanitise_domain_config is redundant.
I will fix it. When it comes to the message itself "vpmu requested but not available".
Does the following sound better for you?
"vpmu requested but the platform does not support it"
If not, can you please suggest a better message?
>> --- a/xen/include/public/domctl.h
>> +++ b/xen/include/public/domctl.h
>> @@ -70,9 +70,12 @@ struct xen_domctl_createdomain {
>>  #define XEN_DOMCTL_CDF_iommu          (1U<<_XEN_DOMCTL_CDF_iommu)
>>  #define _XEN_DOMCTL_CDF_nested_virt   6
>>  #define XEN_DOMCTL_CDF_nested_virt    (1U << _XEN_DOMCTL_CDF_nested_virt)
>> +/* Should we expose the vPMU to the guest? */
>> +#define _XEN_DOMCTL_CDF_vpmu           7
>> +#define XEN_DOMCTL_CDF_vpmu            (1U << _XEN_DOMCTL_CDF_vpmu)
> 
> Like for the earlier patch, I think we should stop with the bad habit of
> defining both the bit position and the mask separately.
> 
Ok. I can change it. However there are lots of other places in Xen (e.g. asm-x86/hvm/irq.h)
when such methodology is used. But I agree with you and I will change it.

> Jan
> 
Cheers,
Michal


From xen-devel-bounces@lists.xenproject.org Thu Oct 07 08:27:33 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Oct 2021 08:27:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.203409.358529 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYOkT-00012g-KG; Thu, 07 Oct 2021 08:27:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 203409.358529; Thu, 07 Oct 2021 08:27:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYOkT-00012Y-H7; Thu, 07 Oct 2021 08:27:29 +0000
Received: by outflank-mailman (input) for mailman id 203409;
 Thu, 07 Oct 2021 08:27:28 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=qfpx=O3=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mYOkS-00012S-OJ
 for xen-devel@lists.xenproject.org; Thu, 07 Oct 2021 08:27:28 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id f6119ade-18b5-43d2-ae7a-9722a00a2510;
 Thu, 07 Oct 2021 08:27:27 +0000 (UTC)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2053.outbound.protection.outlook.com [104.47.12.53]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-27-Vw3euRCPMSuFMC_1npTdDw-1; Thu, 07 Oct 2021 10:27:25 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB4846.eurprd04.prod.outlook.com (2603:10a6:803:5b::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.17; Thu, 7 Oct
 2021 08:27:22 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4587.020; Thu, 7 Oct 2021
 08:27:22 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6P194CA0037.EURP194.PROD.OUTLOOK.COM (2603:10a6:209:84::14) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4566.15 via Frontend Transport; Thu, 7 Oct 2021 08:27:21 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f6119ade-18b5-43d2-ae7a-9722a00a2510
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1633595246;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=nHQtsnoxVcPL8S1M5A3650zhCe4HCafrDqal0UWMqJo=;
	b=UZJz0s1XKTBDIiCr+bOpiKiJWwt1I9OQ+kTvXF5++NP9S6vlI4fuC3TipYD8T+/hCKzGwk
	ppUadOqRNHGvtNRSpbvwHTDQRVtCDIjMehPH/JcVwZPnfDPWbs8DQCGFFqsIT3DPFyzBNx
	oRAkNJYODsABaqFVNXOnFQ09/lSc5MY=
X-MC-Unique: Vw3euRCPMSuFMC_1npTdDw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=H+LCAXKds6UVit3xZV9vLRAMzasOkjNG+MLUu38OX7YjV7r8+BnUKVcAuDmiIFcAm2n8q5xDcz4JTC+9XwhN0FjvX0/LmE61rc6SY901bzytXf4iVMoGt1FP5xoEXtEeOm3gxzHADHdZz50IRzy570GLzhgpqOd43nYEKAVQMjW5uQtcpGI2zChdCh9RFn4M8BLRv0LfkHYqpRlzdjoKXtAucI91dXT1toK1U7ap5h/5I4QdzkgZ2cscaFNU5mivojj35ptEJrLb+sRPTz50zZS9x1Tuvt/kQMPkxP9qIj1evF0GTjkiUZxFVEPN+yOd3kRHQYKBU7ULqcW+p4ACgw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=nHQtsnoxVcPL8S1M5A3650zhCe4HCafrDqal0UWMqJo=;
 b=XPjzW3hQXEYmLCdjeKP1HT6QA+OF0UE1sAPJ7VR4KjXX8Cbh2aWLl2Wk1ev0qrvTaZup1yylU5VdBtpoKpCpq87epWganszDxDZXCXh9EKqk5Y2zGlVaNyFvSVTRsW8p0oK4HnvCHm8U+SlZs7scgfPHBn0kQKR5lSrrIUFI4yHNCtYoEMmOF6QDex7urx2e9UHEN2VIHNaEWm+SpZ10WxE2aAs2vtWKJR2QlrFSRXa0TtU1SCe9LD1ekTksU0AVo87rYmWGs23f2A/fsGGzzBr92dC2hAGPZZJh5hRX/GSCCUlzx1Fk4AQJiUG1Rz68gZGcl1Z6oWtY64IYdGq0Hg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [PATCH v5 03/11] xen/arm: Add cmdline boot option
 "pci-passthrough = <boolean>"
To: Rahul Singh <rahul.singh@arm.com>
Cc: bertrand.marquis@arm.com, Andre.Przywara@arm.com,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 xen-devel@lists.xenproject.org
References: <cover.1633540842.git.rahul.singh@arm.com>
 <e7d91ded71816d07f559b98027e5be1ff172dcab.1633540842.git.rahul.singh@arm.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <8c32a39c-e155-588f-775f-e040013166d8@suse.com>
Date: Thu, 7 Oct 2021 10:27:19 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <e7d91ded71816d07f559b98027e5be1ff172dcab.1633540842.git.rahul.singh@arm.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P194CA0037.EURP194.PROD.OUTLOOK.COM
 (2603:10a6:209:84::14) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: ab3723e8-ad0c-4d50-6325-08d9896c48cc
X-MS-TrafficTypeDiagnostic: VI1PR04MB4846:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB4846F84E145F5B82BADECCDEB3B19@VI1PR04MB4846.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:1284;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	XiqxE4Vc+rnCNmF631CR0NFvLT8NIw6d0BfcKBvaelsEpLEF9RMJIVh4vQHOMXKILdFNx1LmpOpkipiYDMux719v6fa8uPbC7vgOIKAmCJ5nRCtcadAxTkgP/FgXF8Hh6oqNlenEw7MR0gUYPktJZvYOHOo4FsA+KWb1eMFQmb5aumwx9OKsuCqae1OrnY5192lF2WmTQ+LPeBhZLHcLu8j7XIrO+OMBw17vnTDOX2IpaUW1Z1vX1dzJjq5Ix0pVGMpmuWtvlk6k+ZtWN+aqEar/8UxTsZEnUSAMz4QeNj4CQwdnrEY6Q0xAPoJ10BqW6pcGUdlcUVE51Gv0JFkiRxCYVxRKKtwu1FIOdrfrYWVwvPGwqm0kjRKGcMK2lMGUvXTQ8Rnz7SDezlU1I0DpyWitESA2WuLnAG0vLCcVEtiEQJpZJOTTvE0T+YLboNEGahmTGgTnKAlk3LPh26QRkOwQWJIrS9zx9/YUNA33ApzjtPCAIX1tQbvCsoMXIBkjGrlocxzhR6wlIEMCNlp9W4kX2hHwMYjdcWsjMRtHTv1AFcTQqoB6ZUXy0Jm6xOeRXFaegwEZIf8hYg2yTq6FgUzQ25DpFdFrRBBomPG/Tr9USFM5EldFRVPEW3pPUcgBnNM5nb6AVavLAdh4/XmWTo8IRQPmeQELEStWX4CObb4l+dKdF0r9YVR3kc5RpldHi/D3ToJkEZ9kwe3LAUwsZmidNL+zMnIanNFLBY3V/kE=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(4744005)(8936002)(186003)(16576012)(4326008)(6486002)(7416002)(508600001)(31696002)(8676002)(5660300002)(2906002)(26005)(54906003)(83380400001)(956004)(36756003)(2616005)(53546011)(31686004)(66476007)(66946007)(6916009)(66556008)(38100700002)(316002)(86362001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?ajRCTnNDNFdlWmgrb2dpNjVIWVhOcldHVytkODBNNlg3ZjlVVkQvTVQzYi82?=
 =?utf-8?B?cDZMTWQyVHFHaXRGZzJqRDZONHdQZEFiSWdPOW5lYW9JbGJxYS9PM09naTJG?=
 =?utf-8?B?eDdCWEJKUCtmTlpmM2tVS3lNVGdvZHQxWU9UZkpnMzVnSEFnelBFNUlUQThN?=
 =?utf-8?B?bXJuWk1tUGp0UzF0WEhGdUF3MHJsRE9vTUdGZjRKTXYrZUtPZmF6bzN5dm1q?=
 =?utf-8?B?Y1hia3hXalUwVytwKzZTUHZzUUR6bFdIV2dNeTJ5cXlmNWwzdVBkbFdxaksv?=
 =?utf-8?B?bFdYUkRIK2FZLzUxTVE0am9iTVQ0dGJSY2RzeHZVRjBGbTJEUWVtNHcvT0Ey?=
 =?utf-8?B?M2xDbFVKenJJWjZlaVdVdHk2MUZpQTd1T1luVHhHbXZSOWYvYkpCQkUwVXZi?=
 =?utf-8?B?NmpuUG1pOEoxMTZVLzdheE55TThLT2VOUUdvMnJHdXVBTm9mTGdrMkFhU0dp?=
 =?utf-8?B?TjJpVnptdkc2MFJjaUZsY04reHNlREFDVEZTRnlMTWxrSGt3VHI0WHZjRDZQ?=
 =?utf-8?B?VXdHYXdkcnVSOFpEZ3NlZkxmQ2dQTDIzUURweXNaR0h3OEhwWjh0OW5kQnBq?=
 =?utf-8?B?dUtIa1hjcko2cERVUGl0U0M0MEszanBWRWxIdHhQVVBpaXJMVWRmUHZta3F0?=
 =?utf-8?B?ZDBBQUVSaXBETG1jdmRpMy92bDJRTlplVjBYWHMyNkxlY0o1VHdkcE4vbWE3?=
 =?utf-8?B?ZHp6QjQyZDh6L2g3K202dEYrYTBUb3FtbGl1S3RoTzZIVHRVbGJ4TXpQWThE?=
 =?utf-8?B?L1NrV0RyajBrVG5ydzc0akhNVmY5RTVtMGtpa2F6anBRQmRjcXNEYWpOVmNG?=
 =?utf-8?B?WXZQQWdBc0tmdC9RYklnKzFnK1FBNHhxWVVzSytpcVI0N2ZuSjVYdmNmNS9h?=
 =?utf-8?B?UkFzdWxvUlg5eDRZVjhDeHhyemcxb2xYVWN2bmd4ZjRNYVhZTlEwU3FxRmNF?=
 =?utf-8?B?REFCYnc1UUc0WDlua3oyQlYvN0QwRjU3Z3d4T1N3Y3RBSDdxTENkbUl0cnBZ?=
 =?utf-8?B?YWpXZTJFajQ1UnM1Tk9SUndrUG8vRzdudXhPODNkSXl1cVp3OHpWOGM5UURt?=
 =?utf-8?B?LzdtSnZacmsycitHOGRXOFJSZzh0VGptNFhpUDAwQ2pxY1NSYmZBeDN3Z1Fo?=
 =?utf-8?B?RnVqLzVHdURDcUt4QXFYcEtyUVB5U0hKN25KSlNRMUp3YjVzY1BlU3ZsR1Ar?=
 =?utf-8?B?VW9kK3hmMHRMOTJKbjhWcHNVNDlvQUlpaXI2a1RNdTZhaTkreUhXNFM5TU1m?=
 =?utf-8?B?T0t1WnFuQkV6aUFVRFk1aU9SNkM3bkZQQ0doOURMUHdqY0JYUGwyK1krZXVR?=
 =?utf-8?B?Nk5nMDNZSFpad3c5cGRRWjBNWDJPdEZWakZFVkYrMU8yUUdraDhDMEdESFFt?=
 =?utf-8?B?eHV1eGJqN3htL3Z0MGRrT21hSTFQNXRmUkRpMnczYXdKNGFOV3kwVmE0Kzdw?=
 =?utf-8?B?VnhsK0ZpL2hmVU5HU3ZzYmQreHFYRVlpUGVmdTN6Smc2TWZjQkw4Qnkya2ZO?=
 =?utf-8?B?Szk1bTJFT3R3UncwQlgxS0llVHR2bDUxY1NaajlvTTNMa1QwckpoSXNpTFc4?=
 =?utf-8?B?VGlMV21RWFoxVjFmMWtEc3J1TmViRjdsckdtM2tINDlJRysyVmdKZ1pxckJI?=
 =?utf-8?B?a0ZkUU9mbXF1QWo0RC9wMGZna3dYaU1WemdOK0JFRE14MXNyZmlRNmYvMFkz?=
 =?utf-8?B?ZTQ0N043cWJjR3NwWFgxZXBFM2lSMXV3WDhnaVNINDk5RnJvVHBrTTI3OFFF?=
 =?utf-8?Q?VnBX2vLeQpWoKZz0Ios5CHc6QrQoSIFCJqr1wuL?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ab3723e8-ad0c-4d50-6325-08d9896c48cc
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Oct 2021 08:27:22.1242
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: RPRZY6ct6knHcnJ6vGpvjypd6pIUGsEjsxAIQ7VpuAZLbLcb4iHFCzFsf+B+i/d9Dom1HMJ4evg8Gjzpq0O9tw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4846

On 06.10.2021 19:40, Rahul Singh wrote:
> @@ -62,8 +63,19 @@ static int __init acpi_pci_init(void)
>  }
>  #endif
>  
> +/* By default pci passthrough is disabled. */
> +bool __read_mostly pci_passthrough_enabled;

You properly use "bool " here. Why ...

> --- a/xen/include/asm-arm/pci.h
> +++ b/xen/include/asm-arm/pci.h
> @@ -19,14 +19,25 @@
>  
>  #define pci_to_dev(pcidev) (&(pcidev)->arch.dev)
>  
> +extern bool_t pci_passthrough_enabled;

... the being phased out "bool_t" here?

Jan



From xen-devel-bounces@lists.xenproject.org Thu Oct 07 08:33:08 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Oct 2021 08:33:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.203417.358540 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYOps-0002QL-8t; Thu, 07 Oct 2021 08:33:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 203417.358540; Thu, 07 Oct 2021 08:33:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYOps-0002QE-4z; Thu, 07 Oct 2021 08:33:04 +0000
Received: by outflank-mailman (input) for mailman id 203417;
 Thu, 07 Oct 2021 08:33:02 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=9/ki=O3=arm.com=Rahul.Singh@srs-us1.protection.inumbo.net>)
 id 1mYOpq-0002Q8-LY
 for xen-devel@lists.xenproject.org; Thu, 07 Oct 2021 08:33:02 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com (unknown
 [40.107.8.82]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 2dc07246-2749-11ec-bfc3-12813bfff9fa;
 Thu, 07 Oct 2021 08:33:00 +0000 (UTC)
Received: from DU2PR04CA0064.eurprd04.prod.outlook.com (2603:10a6:10:232::9)
 by PAXPR08MB7074.eurprd08.prod.outlook.com (2603:10a6:102:200::20) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.22; Thu, 7 Oct
 2021 08:32:57 +0000
Received: from DB5EUR03FT033.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:10:232:cafe::da) by DU2PR04CA0064.outlook.office365.com
 (2603:10a6:10:232::9) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.14 via Frontend
 Transport; Thu, 7 Oct 2021 08:32:57 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT033.mail.protection.outlook.com (10.152.20.76) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4587.18 via Frontend Transport; Thu, 7 Oct 2021 08:32:57 +0000
Received: ("Tessian outbound 2e7020cc8961:v103");
 Thu, 07 Oct 2021 08:32:57 +0000
Received: from 06997e9668a9.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 2D5A1E8B-5A99-4F0B-B6C4-F7855344E5E0.1; 
 Thu, 07 Oct 2021 08:32:46 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 06997e9668a9.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Thu, 07 Oct 2021 08:32:46 +0000
Received: from AS8PR08MB6919.eurprd08.prod.outlook.com (2603:10a6:20b:39e::10)
 by AM6PR08MB3973.eurprd08.prod.outlook.com (2603:10a6:20b:ab::24)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.22; Thu, 7 Oct
 2021 08:32:45 +0000
Received: from AS8PR08MB6919.eurprd08.prod.outlook.com
 ([fe80::51ee:e7de:6c0a:bcf9]) by AS8PR08MB6919.eurprd08.prod.outlook.com
 ([fe80::51ee:e7de:6c0a:bcf9%7]) with mapi id 15.20.4566.023; Thu, 7 Oct 2021
 08:32:45 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2dc07246-2749-11ec-bfc3-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=NY7T2DMdrP8QbJjXTPcEhoExl6C7BaRglfaB2gl/xI8=;
 b=X1OahMsSUizO1pQSzJ6pH4/+c0dOJ6iC7VOLzpPHWP7DbgXqSUw411M0iiiqcujBP49Up18bGvMmL1udkQuvWmoCzE4s/SOoqlBpGAWFPfQYypWknGcrfV0DZX359IgBkTumFnwTE/ATLPevcJCpzNcXLYQ23zw/Tl2co2LTuC4=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 875dacfc5ad2fd7e
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=grgd9oRAlxgdt02lXCWTz+R9p2jHT4QM5gDQlfJSJPORk3tl4GzTIpoj41La4qZdxxEEKLHodqWSSDDy8Z1sPoRES1vOI49urAWD0rYSRIvB03sLPMsgzvLSisIPGK4QjYc1RVL4NXTBNwRHcLaCI81AWNKWl+9I2zeoBcVsqUIp7jTiBl/g74dvBkDv9/SaeDdHPCYXI/pzyXSlUunayXN8E5NJoSsmIy29GuAwNvn2CAyUwGIGe/N0oyhrElvO5xD7Y8rTb7Qr5IklPXJSbuEOkhrcCKd8wccOP7OALlubaCBB2oTuMqqYhgUUNLyMbqdXMP1BoLosL27qOPlo2w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=NY7T2DMdrP8QbJjXTPcEhoExl6C7BaRglfaB2gl/xI8=;
 b=aE4JqPNqstETmeGecq8QLX/yhGDNXlnoAn4vX7gnChCYMsGQX58MD0SCg3YCJW8otoTUXlqE9YOpEAB2sUR56HfwL8t2ZmiUC1/fGzJP0ymmGDUYVSYl3ukBwoKP/DzpqcEt4Cv5+mfkM2L/5gi6K02nsr/7b2l6BA60B7CCLfzViXx0ifCChW08y8CiNeaRzym+jpEjuBKr4VVKKO/qkChUUKpeZ9+qG1u5Amft+5MvdKaPuCJsF7U0s/MVC0PVbFqxjzbhd7hM3pYgG/cXzFYAoU+MJ4ighjs1HHLzCgHpemKlIDuYPkBvyo1f05NIYcYzC9VlOl1syyRRSpP9ZQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=NY7T2DMdrP8QbJjXTPcEhoExl6C7BaRglfaB2gl/xI8=;
 b=X1OahMsSUizO1pQSzJ6pH4/+c0dOJ6iC7VOLzpPHWP7DbgXqSUw411M0iiiqcujBP49Up18bGvMmL1udkQuvWmoCzE4s/SOoqlBpGAWFPfQYypWknGcrfV0DZX359IgBkTumFnwTE/ATLPevcJCpzNcXLYQ23zw/Tl2co2LTuC4=
From: Rahul Singh <Rahul.Singh@arm.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Bertrand Marquis <Bertrand.Marquis@arm.com>, Andre Przywara
	<Andre.Przywara@arm.com>, Andrew Cooper <andrew.cooper3@citrix.com>, George
 Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>, Julien
 Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>, Wei Liu
	<wl@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	=?iso-8859-1?Q?Roger_Pau_Monn=E9?= <roger.pau@citrix.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v5 03/11] xen/arm: Add cmdline boot option
 "pci-passthrough = <boolean>"
Thread-Topic: [PATCH v5 03/11] xen/arm: Add cmdline boot option
 "pci-passthrough = <boolean>"
Thread-Index: AQHXutl8uDaCKdGiUEea3YjyaYprAqvHNJaAgAABgwA=
Date: Thu, 7 Oct 2021 08:32:44 +0000
Message-ID: <6BE3AA48-115A-44CF-A108-44AE124EEE77@arm.com>
References: <cover.1633540842.git.rahul.singh@arm.com>
 <e7d91ded71816d07f559b98027e5be1ff172dcab.1633540842.git.rahul.singh@arm.com>
 <8c32a39c-e155-588f-775f-e040013166d8@suse.com>
In-Reply-To: <8c32a39c-e155-588f-775f-e040013166d8@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
Authentication-Results-Original: suse.com; dkim=none (message not signed)
 header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: fea83b65-5574-4ea3-651a-08d9896d10ce
x-ms-traffictypediagnostic: AM6PR08MB3973:|PAXPR08MB7074:
x-ms-exchange-transport-forked: True
X-Microsoft-Antispam-PRVS:
	<PAXPR08MB7074767CBDAB9F480760A447FCB19@PAXPR08MB7074.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:2512;OLM:2512;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 dGSINaK/K0kwZY8l8Me/22/AKrNWXFfIkNbCfkDbBCYG5wWXQ44kdcIvCrIuVLPlmMUFGeBrIP55b4+YYvzsK8sSNlQWTKyUoXsL8bFKyjJ6tQtsFSvuo46YhL6nmnQpF55qMZ4gYAVW33v0iaC1AYqnH0aoGSp6rJRzJXv7UrDCdS8I0KRJRMmjfdVvK5Hhb7N5wBX18PzWutZwrbNaEVNcHHIKRvsPkS/drtJlw3QDCBG9XLNi9FXZ261lfejLLpXoUCM5s6DwglncfQb08IU3yUIvvX4/ETTsoq1K+3BRJgnTqTfGuOK/ELZMGPBMBZl8OZV4lNpKSDL8X6jsJlnNYPt1u1+uOcwtcAKseSHv9JwPekFZjgrI3WN9RPG8SUMLVyHBttL5et0SQp9r2cGLwaTlsZmFEZ6+esmquD2COAJNdQLPcHesILQQ0cs+DpFp+QtSWhTyMxjeAclsfl1yOhHzKHJC/BNwAyn7YeJcz8+7ZMcLFvf1mXiIDDUOYj5gNdtnVEzmL1d+DDSg4G3WZ+G/9M7WC70nEx1SCKiqg86QsrT1xtw/Io3yW4B66IdYM682fYT+pjhZ792v/X+iNPvce540OA9f+i7qnQtHyzGvfJzGEhQ7qzRwuXvjFFB6gKYIW9FNiDD1GghM+8l/C3imF0vhju5YWjo5aFLu+/FCtf+T1NpmfyA9cUbgatOtQj2bbYwOg1XPP3tqIlwg6bu7BCWeE/92oGBhvt35PCjWc6s/79AviGUyUAY5
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6919.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(53546011)(508600001)(6916009)(86362001)(66446008)(76116006)(66556008)(66946007)(26005)(91956017)(66476007)(6512007)(8676002)(7416002)(64756008)(6506007)(8936002)(38100700002)(71200400001)(316002)(36756003)(2906002)(54906003)(6486002)(186003)(2616005)(38070700005)(33656002)(5660300002)(4326008)(122000001)(4744005)(83380400001)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="iso-8859-1"
Content-ID: <6D6569831BDA734B9BB314E49F3B5DC9@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3973
Original-Authentication-Results: suse.com; dkim=none (message not signed)
 header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT033.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	905ea8d6-d1cf-4bc2-133b-08d9896d095b
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	q/16YjehDgJHd4J6aK+Yt/Bb8N5lXNnZ9dAcNptMEM7LeGrUKFWRI+Na+vkevEBFeC58uELN4458bBfI/4en7QjkeL5+UAu8W/QwUQCPECAfoQaC50w2YdzCFT/rOlXunavvxH9ProvY6S+LtDTS7IcVhy8ZcLecgBar27I6A7KXjKMpFETSrgkSQMpWBnryxKevQBvYM+2WBv5lP+aLwzKIX4KHlQOhn906WXiHqA04XurQnrrThPpGK530M54pL06E3eZY5LBSSDrearvZaEuYPVVYpVrG2Ep2oAs+GO0FOhfDIUcwScH6UqTJWSIrfnkQTt9yN+CJqGvp9I1tw/1DgxlzYOQVIrSDU2gtIhVWi+HwkryG43wJbXeqDe019ItXyw1eGQuIDkDsvO+iwRNMegET0yqipGhuZa9aOYunpiBfIsMjmCRtMYC4q4e5Yv9fpbtkkaD/38WVuBFsUvGTE3xqsyv5hWk/7uuTHfJMuA34xLINiLP9IJv640InlYI+/DAUhcTc2U4m3EzTSd1P7S/r/x3B4dHS+2nRub0uVSHkIAJAP6PXQbt1zyGGW+8HqvNphjSv4oQtOF+Fj0Yo9qcEVhdVUVILLFqSi2wZ7+D8qOKmbccGJMV010JtII9YKHis+HpJvPUL8h0YAmfdqurxYTjre9GJrdeybsUPZNRjyBYuc9xZB6qHW54PdkLKtjciFGmvkasa6wUcag==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(5660300002)(8936002)(36756003)(356005)(336012)(26005)(2906002)(508600001)(316002)(36860700001)(81166007)(82310400003)(54906003)(8676002)(6862004)(2616005)(47076005)(53546011)(6506007)(6486002)(70586007)(186003)(86362001)(83380400001)(70206006)(4744005)(4326008)(33656002)(6512007);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Oct 2021 08:32:57.5963
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: fea83b65-5574-4ea3-651a-08d9896d10ce
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT033.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB7074

Hi Jan,

> On 7 Oct 2021, at 9:27 am, Jan Beulich <jbeulich@suse.com> wrote:
>=20
> On 06.10.2021 19:40, Rahul Singh wrote:
>> @@ -62,8 +63,19 @@ static int __init acpi_pci_init(void)
>> }
>> #endif
>>=20
>> +/* By default pci passthrough is disabled. */
>> +bool __read_mostly pci_passthrough_enabled;
>=20
> You properly use "bool " here. Why ...
>=20
>> --- a/xen/include/asm-arm/pci.h
>> +++ b/xen/include/asm-arm/pci.h
>> @@ -19,14 +19,25 @@
>>=20
>> #define pci_to_dev(pcidev) (&(pcidev)->arch.dev)
>>=20
>> +extern bool_t pci_passthrough_enabled;
>=20
> ... the being phased out "bool_t" here?

I missed that I will fix this.

Regards,
Rahul
>=20
> Jan
>=20



From xen-devel-bounces@lists.xenproject.org Thu Oct 07 08:34:34 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Oct 2021 08:34:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.203424.358551 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYOrJ-00032a-L5; Thu, 07 Oct 2021 08:34:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 203424.358551; Thu, 07 Oct 2021 08:34:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYOrJ-00032T-H4; Thu, 07 Oct 2021 08:34:33 +0000
Received: by outflank-mailman (input) for mailman id 203424;
 Thu, 07 Oct 2021 08:34:31 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=qfpx=O3=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mYOrH-00032N-OA
 for xen-devel@lists.xenproject.org; Thu, 07 Oct 2021 08:34:31 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 9bbdf677-40fc-4431-9fec-cc96791c08e6;
 Thu, 07 Oct 2021 08:34:30 +0000 (UTC)
Received: from EUR02-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur02lp2054.outbound.protection.outlook.com [104.47.5.54]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-40-GtOQHS4jO0OQr-5ZjCOrmQ-1; Thu, 07 Oct 2021 10:34:28 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0402MB3392.eurprd04.prod.outlook.com (2603:10a6:803:7::26)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.22; Thu, 7 Oct
 2021 08:34:26 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4587.020; Thu, 7 Oct 2021
 08:34:26 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM5PR1001CA0042.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:206:15::19) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.14 via Frontend
 Transport; Thu, 7 Oct 2021 08:34:25 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9bbdf677-40fc-4431-9fec-cc96791c08e6
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1633595669;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=EzAwO/q8NGF/QYkQvZ2mKhY4CNs6AwIi9h56az5ci7A=;
	b=dXbFgr07MJtst7L/hNikZW+w6q20QuJDj0ipPT50+AepQ+RfCvwmIHesZprJ9lWQjS8nhn
	4rofVMbc4V1L9ZcapRNn92XviUIocyyTi2br/tTmaOdSS/V54xSefkvRsZ3dkOk1lK768J
	xYJ9cjxdKcX7GVksxVTIDC+GvfG/gn0=
X-MC-Unique: GtOQHS4jO0OQr-5ZjCOrmQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=heKOglbsjamSSuVueQkCtVWhFBXuAIUzuxZHbC2Vb2RE5J0ZCPRCdH8S9k98Tr1HD/6ziY4AcAw1uHXOju3nMj2gZtX7BOHh9eZeDgovPE7O3r4DSawvmL8QCn+SuBfjVgRjaIkDmvI93zXFhnytWqb+2YtYVHARTdc0JA+y+/ZNM6uOsHjbCFXSUfj1o9WJvkRFbMjQf0hOofo21prk62cy2GD/vg6IK9T+GCXXVlknvtxv7oLWl+jeK6vgb87++LIkq/669I4U7RGwP2y92Xn6tIvNj/0D5PfpVW7RFQ35//a7OmvlmBSxB+3ifkoIb2bOhYnNAmMjFCByy/AzgA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=EzAwO/q8NGF/QYkQvZ2mKhY4CNs6AwIi9h56az5ci7A=;
 b=a9Mh1U2B7bjmv1Ef8h1oj6VaPcpmuRudI4O4O8yM0LC+0z4OrR41IwvbqUYct0CTarLfMJgxg+rq/m6hqI61MgSQS/BqV9EtBru1qV7f4706URn/YmqMr8h2HcbO1ptgOk5FWb0eSxHwgO6y2aUqPUmQh3nOAjAcBRf+IUhDrvHHsqYZwFbWo7/R5htCKu936hPhf975WInISd8p8+FWNPYdzZHWzbzKXQ2lX1EfUyqAmCaaeQ6Hnh75mi1YyN95huUXfODR+ACZ33egDmZz7NSri+JExHpbORaNkV1qe81ntZHACBVnPUyby4+uCbifHZDlcUWJB1OizH56QSpVyg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [PATCH v2 3/3] xen: Expose the PMU to the guests
To: Michal Orzel <michal.orzel@arm.com>
Cc: Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Nick Rosbrook <rosbrookn@ainfosec.com>,
 Anthony PERARD <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>,
 Christian Lindig <christian.lindig@citrix.com>, David Scott
 <dave@recoil.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 bertrand.marquis@arm.com, xen-devel@lists.xenproject.org
References: <20211006105827.15217-1-michal.orzel@arm.com>
 <20211006105827.15217-4-michal.orzel@arm.com>
 <45bcc00d-95f1-fe20-a68b-de2eb793dc5e@suse.com>
 <8682dadb-cb7d-8291-33eb-4988d0d2227f@arm.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <2fbf6e5d-2802-6a3e-93d5-a3dec051fddc@suse.com>
Date: Thu, 7 Oct 2021 10:34:23 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <8682dadb-cb7d-8291-33eb-4988d0d2227f@arm.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM5PR1001CA0042.EURPRD10.PROD.OUTLOOK.COM
 (2603:10a6:206:15::19) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 5220fdcf-4623-4c8e-7efa-08d9896d4588
X-MS-TrafficTypeDiagnostic: VI1PR0402MB3392:
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS:
	<VI1PR0402MB3392FECEF58E788D6A6B130DB3B19@VI1PR0402MB3392.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	PWRHJB3Or8duiyPgmjRMFx9DBCrdiYsWEj1F1xwABAklFp1EXfBALD78nxKLruCjOubJLUqacred/ka666jwoaBvVP/jzOLCHzcaWVASadV1gDFjPFwT1ZQlG6YHJJBbgVyQgbD56cJpe0Rm6ACg9MlAvGlOfmEs3p3nTn0rQngpg+OTK/pJWSRImWoLieXUMvRGokSUMNLg+fV2HhtOHil+6MTecvHdvKDDNucFuo3DW9xENoyw3coiRyFa5zwicxlcBpOJsa++XkHWYe2VNCpomvP2Gw70FgJDnxx9k2tT+Qs6RR5qz1UlRZ9Nmk3X/T4aFzzofi3M6KwFpB4vqZWkZ4LLhiN4O+3rvRMiYtU7F7Sjowgkap7tncE9D7wsc0w1gaY3FqwZ3EarJmvZm0yqBkVN1WjH9Zw5VHCA+dTinH2Ec3p1Mrj/TgnZdCl0kCeNguzdiY5M7/r3qsJ64/eVGW1V1Hlu2VYk2rIAdeHq7ndlFIYGH/vD6SEJAqqVQ+Dg0YbxMLpsOxyHUdVS0Z33uHWrE44xlWLxljBPtwtqwxB0WDGLQdol/Chi8XR7y6hULTHgS8MCCsIaxq+WHs13hD5sYg8Yqzaj4rLsLxOrN8YM2uK+yeHOmEHaW8tUwcspZA8FZ1H/Gr9GvAHOPgJI9fKkl01Iqgs237UtWJK3DODpyeOt93bLvDLg6S60db5aXpwLPiQLUuxnjABgD8wOzsSAdQ4/xXVlA0mrmCE=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(186003)(31686004)(6916009)(83380400001)(7416002)(66476007)(66556008)(6486002)(53546011)(66946007)(8936002)(4326008)(5660300002)(36756003)(38100700002)(31696002)(508600001)(26005)(316002)(2616005)(956004)(8676002)(2906002)(54906003)(16576012)(86362001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?bHNwQXp1QW5SNXYwT1BNL1JmM0RPcDBTbGhXTDdnbHZIRHdUQ1N5ak5USG4z?=
 =?utf-8?B?VGwxalpPeDN6SVMxYzRYU0lIY2wvOERZWTVXY05nVEs2NEdVVTkzdXVLUzln?=
 =?utf-8?B?ay9zbnN2RGpjcWJCNHVyNTYvZEFaMGdSU0hHZDAwVDBRcDVmUWlncksxQU1Y?=
 =?utf-8?B?MlhpYXc3V0w1bUxVSmxvdVhjU0xDT0VlakJpdHN2OVhkNlhEUUg0ZlRhbnlj?=
 =?utf-8?B?S0RNTVQ5MzdSYmYzQi96OVZPUDRveDBzaDYxTzg4R2NVc2hEVnNKR0hYUDlx?=
 =?utf-8?B?cHVxWDlDQlRhM3o3VjAxTkpWQUJvWS8vUDcvRVpJUFVmMjNJTkRzWWRib3pp?=
 =?utf-8?B?N2RRUnZFak1JeVZSdGZOWHJrMk9PWmtMeHkyRnA3TXpJTm0vMjd0L0ZibytZ?=
 =?utf-8?B?Ti9TaHlmVGlDZ2xTdHREOCs4VzBVOE5lTXcrZURiWDdDenRsY0xFQlFYeUtK?=
 =?utf-8?B?MWd6Qjl2azMvVWhOV2lhelJld2N6SmZZOXRiYjEzdVFwTHNUMHpWdWhrbDFP?=
 =?utf-8?B?TmlHcjV6L29hRHZ0Q3hnekpadDhiS0U5bEhGbWhxT1pqdEp5cHUwVXhOaDMx?=
 =?utf-8?B?aVRML2VLOXF4TllEbU5ZZFdnb3NVR09UanowVTFXellQOExzbjM2Z2NjVHdF?=
 =?utf-8?B?T2ZXOXhUNkh0N2FGUFJGNFVBczg2dkI5WnU5SFRpNXZJTFJkcjgxQ095NTEz?=
 =?utf-8?B?NElmQlVMTDl5ZEFQZm1jZnlnWm56OFA1WmFWTXg1S0RFTFNsb3M3eUVvMjlX?=
 =?utf-8?B?bEhrcDdXRnZvSkNoekxPeDdEOXdJOVQzeUgwS3ZBYjB3ZHhLQ29vUmNrcXV2?=
 =?utf-8?B?OEFKTUdmRVVLeHV0NjdHL1pnd0JCWlJSYjRUbHppbzBQSFd4ZEMvSlF0Y1pt?=
 =?utf-8?B?RmJhaldybkNDdzd4d0trUlpRb0o0NU9DTDd4UGV4MjhHN25TaDNXN0tZVzd2?=
 =?utf-8?B?djlEOUVIVzhXbUFSYVMzcThlQ21XRElrdUlXZmloUGRKUFNaTGxEVVYwYnJW?=
 =?utf-8?B?RjBwVEtyemtSLzdOd0tRdGNjbllJaFBpeDVrWWoxWXRBRlIwM3JSZWtsQVlG?=
 =?utf-8?B?Si9qcTlXa05uNE1EdVBxVnpiU0N4VVJHaE5oakt3Q05nNFJ0VlRGZUVYUW4r?=
 =?utf-8?B?NnY5bzQvSzBETWpadTlZTy9GSUUzWUZ6MWZ5L3ZBaExTcVRLMnRncnFNcU5p?=
 =?utf-8?B?WlRPQkUzcG50cW0ybFZGWlp5U0FwcDc2MVFlbTNublN3akZWaWJGa0c0S0xt?=
 =?utf-8?B?OVRmTlhOOVIvSk5OY0JqQ3JpYWgzTEt5TmVvWHZieWJtNkRnbGl6eEM4S2Fn?=
 =?utf-8?B?Sk5qZzhneFBmRTlHZ3VCY05tc3VBQ2ZoYmJXZmRhWnVxemJneDEwQTRweDgz?=
 =?utf-8?B?S0JieXFRbm5scDFYZzQ2TXhxQ0w1SFlvNTc5YkFxWlVxTmRRNmRabGNVM1Rj?=
 =?utf-8?B?dExzL3NTSjBWWEpxRWZGVG9vR3l3RjNFZlNTTU5hOTgrVkMwOEJ6UzhqQVdW?=
 =?utf-8?B?NTVnMDVuT0p1dlFBaDRCRXJ5c3Z3NzJkeGdDWXcvQ0pwVzlFNnNaSE93Mkhz?=
 =?utf-8?B?Vmo2YjVkUStpRFpvb1NQWFF2WGFMU3IvYlFYMEVOWTVSVFdORDZOV2Y0Z0Jx?=
 =?utf-8?B?cTdrSkZqZ0dhTnEyK2FOYVllWEdRRmE5bU9ROCtZU3cyOFR1UVZ4QnBnbFZZ?=
 =?utf-8?B?NmJhNm9pRUZxeCtkOG1pdktqM2xuY2djQ1pvMGtTZ3BBTnVtNkdKUzhpMHBF?=
 =?utf-8?Q?X30vj9E5NwiEV3nzzhD8qH6kqtz6lo0tAFL4tAE?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5220fdcf-4623-4c8e-7efa-08d9896d4588
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Oct 2021 08:34:26.1489
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6AQe9fIaJ5SkCQgfwl2G3HVtp3I5rhluT+WVaiN1nlSz/AWfP/4RXsg/Yb+owHQ+G2T+yu24l4NO3kxTxY5+Xw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3392

On 07.10.2021 10:21, Michal Orzel wrote:
> Hi Jan,
> 
> On 07.10.2021 10:03, Jan Beulich wrote:
>> On 06.10.2021 12:58, Michal Orzel wrote:
>>> --- a/xen/arch/x86/domain.c
>>> +++ b/xen/arch/x86/domain.c
>>> @@ -692,6 +692,12 @@ int arch_sanitise_domain_config(struct xen_domctl_createdomain *config)
>>>          return -EINVAL;
>>>      }
>>>  
>>> +    if ( config->flags & XEN_DOMCTL_CDF_vpmu )
>>> +    {
>>> +        dprintk(XENLOG_INFO, "vpmu support not ready yet\n");
>>> +        return -EINVAL;
>>> +    }
>>
>> I consider this message potentially misleading (as x86 does have vPMU
>> support, it merely doesn't get enabled this way). But isn't this redundant
>> with ...
>>
>>> @@ -534,6 +535,12 @@ static int sanitise_domain_config(struct xen_domctl_createdomain *config)
>>>          return -EINVAL;
>>>      }
>>>  
>>> +    if ( vpmu && !vpmu_is_available )
>>> +    {
>>> +        dprintk(XENLOG_INFO, "vpmu requested but not available\n");
>>> +        return -EINVAL;
>>> +    }
>>
>> ... this? (This message is again potentially misleading.)
>>
> Ok. vpmu_is_available is false for x86 so the check in x86's arch_sanitise_domain_config is redundant.
> I will fix it. When it comes to the message itself "vpmu requested but not available".
> Does the following sound better for you?
> "vpmu requested but the platform does not support it"
> If not, can you please suggest a better message?

While it gets a little long then, appending "at domain creation time" would
disambiguate the text. Or maybe "vPMU cannot be enabled this way"? It's a
debug-only message after all, so its wording can quite well be developer-
focused imo.

Jan



From xen-devel-bounces@lists.xenproject.org Thu Oct 07 08:37:20 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Oct 2021 08:37:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.203436.358562 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYOtz-0003o7-7C; Thu, 07 Oct 2021 08:37:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 203436.358562; Thu, 07 Oct 2021 08:37:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYOtz-0003o0-3w; Thu, 07 Oct 2021 08:37:19 +0000
Received: by outflank-mailman (input) for mailman id 203436;
 Thu, 07 Oct 2021 08:37:18 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=qfpx=O3=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mYOty-0003nu-FR
 for xen-devel@lists.xenproject.org; Thu, 07 Oct 2021 08:37:18 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id b5e06727-cd31-49e7-8600-f244c58dd08d;
 Thu, 07 Oct 2021 08:37:17 +0000 (UTC)
Received: from EUR02-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur02lp2057.outbound.protection.outlook.com [104.47.4.57]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-36-79fw_mc-MKqoMamdCM8Jxw-1; Thu, 07 Oct 2021 10:37:15 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB7150.eurprd04.prod.outlook.com (2603:10a6:800:12a::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.19; Thu, 7 Oct
 2021 08:37:15 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4587.020; Thu, 7 Oct 2021
 08:37:15 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM5PR0301CA0008.eurprd03.prod.outlook.com (2603:10a6:206:14::21) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.15 via Frontend
 Transport; Thu, 7 Oct 2021 08:37:14 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b5e06727-cd31-49e7-8600-f244c58dd08d
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1633595836;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=+PkwmS7Zhv0I0rTaqPmtM6jc93w/HGVw2VW0J1GBWAY=;
	b=JAt2Ats9nuVNIEG76sDE2vI1Dz8wfjylZH7bQqq5Cv7Oz1xw5uedalCnGPZ49B1yKz6/6G
	RfmZmm4kMVe14f9AXeimN5xHH68Fjwk4cHxXq7FvWpYXVuRXVfDaV080qi9NmRDfBbL+LO
	eUGAfRxl0qNmC3g07w/K219y7vUiJAs=
X-MC-Unique: 79fw_mc-MKqoMamdCM8Jxw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=GR3AoUk5uJqp05+tUyYLpJpc+ZS1JEPRDcGIvVjYw3yeCJpGEzmjObxdz6uC0z1F8B0ObaT5bdxZSb7IzhG+ofSW2VG3A4DY2l/K/7sFrX1OqW/Sjo1m+lVAnC18fEffDNXKlrKvykxfZj/RE1r6zyChXzeBpa7iI80s9pykz7xl2Bam6f5dVjnmb4meXlAmPQCk2arrozcTqklyF9uetYOARKDI91wJsmoAi5X5rZU/Z41eWbqfYpdy1pnKbX9Mnl526uGc6m/5x/oL+ODt1raymtwVbyMhLZ9syaVuz6A/+XtcO+R5ooPza+YBWpGI3Uhsq9vDzIezKuox3GkFHA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=+PkwmS7Zhv0I0rTaqPmtM6jc93w/HGVw2VW0J1GBWAY=;
 b=Mp0kiBNjPGH2eGsqYoU57kt4Gb3HERBMTTkWYigMiQvUpfc0TT69VdvfF/Xqf2+64mSsRbvU2hZMvTOenVYLsh0nVC82ME+XN4NWXqo1+qGKw51latbgYyBsusEr9R2krTbXVvnOwwSbSkWCqsJIhcjYUpYcTJDsLujtUs+FOywuTW/+QuT0eZs+93Owm+3bjkKvl9lWh5ih+9mxZSxZigcGCYLuOFc+ijooeNBFPVwj0Eiq7Tn1n+HEVB3f+2FeneDNIc/GFPqGkfDrkv6Vyf4rtL3E/XqHETB/uowmCnDKLk4NP1YVayxIvEqBSJUduzTJM0+gzssORwbk1ADV+w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [PATCH] x86/spec-ctrl: Build with BRANCH_HARDEN lfences by
 default
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Xen-devel <xen-devel@lists.xenproject.org>
References: <20211005111146.3694-1-andrew.cooper3@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <5877bd75-b4f4-aabe-0a99-c5c29ad25e07@suse.com>
Date: Thu, 7 Oct 2021 10:37:12 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <20211005111146.3694-1-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM5PR0301CA0008.eurprd03.prod.outlook.com
 (2603:10a6:206:14::21) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: c980b031-5c62-44c5-ce76-08d9896daa17
X-MS-TrafficTypeDiagnostic: VI1PR04MB7150:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB7150CA486FBC34A502050DF6B3B19@VI1PR04MB7150.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8273;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	jLnZRJZS9KEpGrwyofOlcG/6XpBXey+tB9cfPpGyPzodlvjJ06Up4zmF4EHkLZKxGJX3H7QeSEQ0Crja6jABYKHEUDst/Tp/nzQq5dYSt46z2z724uzpujHgBSpRn9FfhBzx49l3ISphMBaZoFfXc89dfMqPgP+fhDlmT0PUWrXTHDGYt1pDfNvg6WGkLQJU/C4UNgcIr41LLeS8cYxjfMoH10t1/vQK6HMDXkXcCsMLP+gd1tEeOME3WVFWvqBMO1ZcaGzIJs+pCFiryztoEe58BgyxZh+quYWeGvT+23s8zCJdD+8J3ZoAv4W4AKmLdhJUQjwvc59c7nW2VbYeugKUrctRSVx9QAvLPgfQst9gqnnWRrakyX5H2yNjknjaBPXt/FMpDyNyaEOPCwazCdGYVSxWdkzkpLisMEBoDJtz9WCEa2JdOVxzNFLFHd5qEL0VhA/t1mIrujHSZLzniFT9dXBjn2R1TsgrZTvpz58fZTSWYY/mLSC5YZIF7eztqmdfOvQOeB3606Xj+QbIv35wWQxvyHAPJQVupH9V9kYlct86u7rJ22ioogJJl2Tp+38s9VtyHGfI+f+UQMySHYyT3EbC0gBOm+hsZ6rJ0F63OuPShYtJRB3mitQn+8juguMwhcRzXz3Y+PAxCBgXVqtYYWmX3xT8T88JXsTBBIIFcAeOBe18hCHjfJuN8w5BYGzKID3yL5GX8VuR8q7M0GWQr4TDgz66SRnMl482s6s=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(31696002)(26005)(508600001)(2616005)(6916009)(4326008)(86362001)(956004)(186003)(6486002)(36756003)(316002)(2906002)(38100700002)(16576012)(66476007)(66556008)(66946007)(8936002)(8676002)(31686004)(4744005)(53546011)(5660300002)(54906003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Zkl5YWtGeFBORk95dm0yRmpQN0RSMm5DQzRCWlNjUFFjNnRCYi9GNUVPVW5z?=
 =?utf-8?B?Tk80UDYzVC9iczZ5amVVbURjNXdwbkZ0SU8xUk14N2o0dEZwd2xJTk9BWlQ4?=
 =?utf-8?B?NDh1TU80S1A3TmZrUWpzUHd4b25MWGJFM3lBcW8zWUg0M0k0bytXbTFpNWJ4?=
 =?utf-8?B?NlJ3dUdKb2tpclpoRFZybmszMkJQSVcyWkFXOGZkVW40aWIvc0llYVVTOXBp?=
 =?utf-8?B?c0VRNkVwdkRuNHpKZEZxakhkMVZjb2luWnYyTGxQem5rUG9nMEJ1TFlneWNa?=
 =?utf-8?B?RnFVN0N4dEZGZ2JhRDQ1eUc5RWNLbmxXYXhWTURSNytXRCtsdm5wYVZoYnYx?=
 =?utf-8?B?bm5pTGx4bkpnKzNSaHM5KzR0ZEpaZkVVdVJBM20wZGdScjVaVHJUaWFCL2cr?=
 =?utf-8?B?ekV0a0JRSm9wcy8zcHMzRDlZTkRSZkM2M2JBUGFpUk1KVFUrRFZOZ0k2VlpV?=
 =?utf-8?B?SnlhNElSVFRuWTBSbk05ZWE5R0tnNXl3QVVJN1UrMDJ1cml0bEhpMzRpMFow?=
 =?utf-8?B?V0Q4MCtRNDd0ZVdPdk5jTGZGbFZRdytsS0pTb1NNUXJUOHZEekNiK1l1QWh2?=
 =?utf-8?B?MXpRWDFpNHhOcHp3SjQrZFBqYVlHdHlRai8xME9kb3hEVVM1Z1FVU05xUytz?=
 =?utf-8?B?YVY4MlBtZDdvQmNBUUdBa2ptSDhvNndsSThnb1Nqc1lMRWw5RXFiUHJXUGtT?=
 =?utf-8?B?NGRURkE2TGF4dHBOMFdjeHg3TmRZT3N5eERDWXRqekdjcE1lTTBjbWwzZDUy?=
 =?utf-8?B?Qi9hdmFNSVhNMlBqWWQ5WWNFWUNFczhvbTR2MUQxaWppK2RldnJEbkpjdkwx?=
 =?utf-8?B?T1BwSnRhcldKRHBIVDB6ZDU4TitSMVM1NHF6bFpMRHJKOE4zUUpaQjhuQXk5?=
 =?utf-8?B?bzVGLzBWMXhaUGF0Z2RrM2tTTjRTbFBBcTdmL0o5OU8wV2dzVGlSSjh5Z3Z2?=
 =?utf-8?B?T3M5VVh3M2MyZ2kxTGhYdXg5U241KzhRUkdQQUtLZEd2ZmJSM0tSa252WFFM?=
 =?utf-8?B?ZHJUVnVmTlRjYzc2RXNLbDdueFVkT2F0SGlzMlU0OWVid25GVzQ3UnFNRDcw?=
 =?utf-8?B?azJEbzVuZ1AydTNqT2pPWnV3Z0hERVNxamNhYlM0c05UaUFhMGlpa2NqQkdj?=
 =?utf-8?B?T1ZubHo1aVV4MnpBaU5XYWJoa1Joc1NiRDZtYzRRdzIxQ1JXVjdSOHI1akp2?=
 =?utf-8?B?empMQklTdFdteVZvN1NlOWMzUEdlZ041ZlZmSmFYMkIxcTROa1FpNkpHMjFU?=
 =?utf-8?B?TjJFMVJRLzJFczQwbzZiY0Z1WnFpZG1TRGpYdWhOQXEzOUE0eDJickc2RElK?=
 =?utf-8?B?c2hIVFM3UVJGVGFBKzNGdk5HeUtYY2FTZTlsR2d4UFdTdFdtWkhqV0MvY1Rm?=
 =?utf-8?B?QnExdHVraE8veU1RYnJQRVBXckdDakkyUUxyTUxwZ1ltWUJtcC9hM3VITWpO?=
 =?utf-8?B?YmsvUnRZN3NkV0ZhaFBMU3h6b1ZvZnR6RllOSG10OFlaMG0vRW5BQ2sxaUZ1?=
 =?utf-8?B?b05rV0VrVHI1YmNjbCtuLzE2NFY5SUNQSVUxajUwbGU5dGtmaUxOTGtpU2l3?=
 =?utf-8?B?R2lrcXZHc1RKdXYrV1owZi8wejZLTDAybXQ4cGFsUDZ3YlpDNXA2US9UZC9x?=
 =?utf-8?B?MVVGTVd4ZThCQmk2WnRIaWZUeXpneEU2WWpCUWYzTzFMU0RNQzRKU29XZkJj?=
 =?utf-8?B?S3lRa05mc0hwY2RFQVplTm5od25qVzFMS3dNZEFzMkZzTm82bVBXdUxFZnk0?=
 =?utf-8?Q?vmh0yj8HUeS+3IQk3EQO08z6Sq4LMzj3WurKSgK?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c980b031-5c62-44c5-ce76-08d9896daa17
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Oct 2021 08:37:14.8732
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 7e1eXppprHdEgCsXhJvyDxBqkA1bjylds4uxKCJG/HkuT6m+G3awhAe93tBFDhqANhhexE3wk7aVW2FIZ2lGCQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7150

On 05.10.2021 13:11, Andrew Cooper wrote:
> Branch Harden is enabled by default at compile and boot time.  Invert the code
> to compile with lfence by default and nop out in the non-default case.
> 
> This has several advantages.  It removes 3829 patch points (in the random
> build of Xen I have to hand) by default on boot, 70% (!) of the
> .altinstr_replacement section.  For builds of Xen with a non-nops capable tool
> chain, the code after `spec-ctrl=no-branch-harden` is better because Xen can
> write long nops.
> 
> Most importantly however, it means the disassembly actually matches what runs
> in the common case, with the ability to distinguish the lfences from other
> uses of nops.
> 
> Finally, make opt_branch_harden local to spec_ctrl.c and __initdata.  It has
> never been used externally, even at it's introduction in c/s 3860d5534df4
> "spec: add l1tf-barrier".
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Reviewed-by: Jan Beulich <jbeulich@suse.com>



From xen-devel-bounces@lists.xenproject.org Thu Oct 07 08:47:06 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Oct 2021 08:47:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.203445.358573 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYP3N-0005F5-5i; Thu, 07 Oct 2021 08:47:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 203445.358573; Thu, 07 Oct 2021 08:47:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYP3N-0005Ey-1r; Thu, 07 Oct 2021 08:47:01 +0000
Received: by outflank-mailman (input) for mailman id 203445;
 Thu, 07 Oct 2021 08:47:00 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=9/ki=O3=arm.com=Rahul.Singh@srs-us1.protection.inumbo.net>)
 id 1mYP3M-0005Eo-1t
 for xen-devel@lists.xenproject.org; Thu, 07 Oct 2021 08:47:00 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com (unknown
 [40.107.7.59]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 7c759247-6715-4eac-a10d-47f69fa3e820;
 Thu, 07 Oct 2021 08:46:57 +0000 (UTC)
Received: from AM6P192CA0070.EURP192.PROD.OUTLOOK.COM (2603:10a6:209:82::47)
 by AM0PR08MB3812.eurprd08.prod.outlook.com (2603:10a6:208:fd::15) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.19; Thu, 7 Oct
 2021 08:46:55 +0000
Received: from AM5EUR03FT042.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:209:82:cafe::e4) by AM6P192CA0070.outlook.office365.com
 (2603:10a6:209:82::47) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.14 via Frontend
 Transport; Thu, 7 Oct 2021 08:46:55 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM5EUR03FT042.mail.protection.outlook.com (10.152.17.168) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4587.18 via Frontend Transport; Thu, 7 Oct 2021 08:46:54 +0000
Received: ("Tessian outbound 16951d3c485e:v103");
 Thu, 07 Oct 2021 08:46:54 +0000
Received: from 32413ee495e1.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 B255A63D-BF80-4460-8435-A14CF2BC5EA5.1; 
 Thu, 07 Oct 2021 08:46:43 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 32413ee495e1.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Thu, 07 Oct 2021 08:46:43 +0000
Received: from AS8PR08MB6919.eurprd08.prod.outlook.com (2603:10a6:20b:39e::10)
 by AM6PR08MB4936.eurprd08.prod.outlook.com (2603:10a6:20b:eb::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.22; Thu, 7 Oct
 2021 08:46:40 +0000
Received: from AS8PR08MB6919.eurprd08.prod.outlook.com
 ([fe80::51ee:e7de:6c0a:bcf9]) by AS8PR08MB6919.eurprd08.prod.outlook.com
 ([fe80::51ee:e7de:6c0a:bcf9%7]) with mapi id 15.20.4566.023; Thu, 7 Oct 2021
 08:46:40 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7c759247-6715-4eac-a10d-47f69fa3e820
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=vzwrjXhO4vzIE2eN1xn7sIV5wV9FYbP9LVTo7KNN3K4=;
 b=qFLgEoU7U2Aj6GkCh2S6LCHxObAaBQxuYIfRWr2ob6w/jVl+WZxrfL0BjXMpOtJFt4QOtG83QVrSvxb1nQ3DYN2s8SnSj+7nyvKTrIWH/bWHsWb2Yon/qJl7409NvSd9EQ0L7nV5GfTzlUWUT+BjXeEiGtS1/HnVtkE8o/s+a0Q=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 1a62b60f4e97bbe6
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=H3OO78jcQH16R/aO/GYoRd8LpCbmg4adOxAZQWKoENVB5BhSr/BmOQuYyjIlSpGbAtOsNNaZ62jI9QmJoN+cDUEsUw+jNhpQ/jMxDaegZIRmZm6yNzoKHGhSMc7I0w+gW/SnEtCmiaBIHZu+Av/pzldbOUH8M/iBwiJbKJo6zgCJlHNPPUgCQ5/k8WHsmKZXoAa+jNp2g/uwedBQAMcQf2GW+UFxOkXpypmGEfnFFiFEi97TNcBIpX30f9rTaCGlgQBoQk2iSqExsHloBK8hi6STZ72TKWQMS9hlduMotWBBKxBlyd0ul0wTRVpWT8hrqXLfTOcjzr/wG0Jej3s2bg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=vzwrjXhO4vzIE2eN1xn7sIV5wV9FYbP9LVTo7KNN3K4=;
 b=QtdXxlUThlxY0oqNiIgEW9N1QRDXFkk6vKI0q/+WTCtIuve3U5S8obm/NL6H/HuaLXOofrZzAXbayCSv/SldlYw0uH4Oci/MivatQxKlwjm1aOau9pXxUdfgTf3G+JH+7SH21jr80GFgz846afWyUr9aLBXNCakjK+LHygKT2R8YE4lFVblsx9Oiz8iVFRgwiJNPq1kgZtz8Gf5/Owj5lpkhss7KDb5rYZEjyacl+zsZqCkSRv2dAFOSQuRG5UpBx4uPzZ5SxKMarT3R4T6ISKptmgqu2l7dR0XkGBzRx7VBXAAT5RNjTZ2s4RCwxWk1rp/bNgFS6rhkC3nzquU9YA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=vzwrjXhO4vzIE2eN1xn7sIV5wV9FYbP9LVTo7KNN3K4=;
 b=qFLgEoU7U2Aj6GkCh2S6LCHxObAaBQxuYIfRWr2ob6w/jVl+WZxrfL0BjXMpOtJFt4QOtG83QVrSvxb1nQ3DYN2s8SnSj+7nyvKTrIWH/bWHsWb2Yon/qJl7409NvSd9EQ0L7nV5GfTzlUWUT+BjXeEiGtS1/HnVtkE8o/s+a0Q=
From: Rahul Singh <Rahul.Singh@arm.com>
To: Julien Grall <julien@xen.org>
CC: Ian Jackson <iwj@xenproject.org>, Stefano Stabellini
	<sstabellini@kernel.org>, xen-devel <xen-devel@lists.xenproject.org>,
	Bertrand Marquis <Bertrand.Marquis@arm.com>, Andre Przywara
	<Andre.Przywara@arm.com>, Wei Liu <wl@xen.org>, Anthony PERARD
	<anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>, Volodymyr
 Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH v4 13/14] arm/libxl: Emulated PCI device tree node in
 libxl
Thread-Topic: [PATCH v4 13/14] arm/libxl: Emulated PCI device tree node in
 libxl
Thread-Index:
 AQHXuRciClWhjFX7R0aQhsW/aixhyqvDkJEAgACf3oCAAL5hgIAAzJaAgAAXDgCAAALtgIAABFYAgABk+ICAAAU6gIAA+ZkA
Date: Thu, 7 Oct 2021 08:46:40 +0000
Message-ID: <6B3C248F-21EB-40A1-A316-3B77C0203B8C@arm.com>
References: <cover.1633340795.git.rahul.singh@arm.com>
 <3ad42008f534671ae7f5b25da91253ce7cd4a3e9.1633340795.git.rahul.singh@arm.com>
 <alpine.DEB.2.21.2110041714410.3209@sstabellini-ThinkPad-T480s>
 <11F169C6-39A4-40F3-8E75-39B8C2CCF022@arm.com>
 <alpine.DEB.2.21.2110051421520.3209@sstabellini-ThinkPad-T480s>
 <8B848F95-977F-4DF4-B315-CFEA610BC1C3@arm.com>
 <24925.33634.554859.2131@mariner.uk.xensource.com>
 <BFC5AD62-3DA7-498F-8B6E-AB4C8CAA9731@arm.com>
 <24925.35194.369692.94259@mariner.uk.xensource.com>
 <5ADA6C46-A69D-459F-868C-DA579FEC36E2@arm.com>
 <f602b716-63b9-a3d2-237b-2048f8fabbcf@xen.org>
In-Reply-To: <f602b716-63b9-a3d2-237b-2048f8fabbcf@xen.org>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
Authentication-Results-Original: xen.org; dkim=none (message not signed)
 header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: 4994ad59-7b66-4944-ffad-08d9896f03ea
x-ms-traffictypediagnostic: AM6PR08MB4936:|AM0PR08MB3812:
x-ms-exchange-transport-forked: True
X-Microsoft-Antispam-PRVS:
	<AM0PR08MB38124A759CBEDE2F9ED43EECFCB19@AM0PR08MB3812.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:10000;OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 NjnknEpZap9ibXt5wiUN7GNB179oGnZ1vPOf8Se0QcvG2s6uUBWnSfwKqvt0+S6ECXxQu1Nxw9qcvXLYEq05ZlR9gFX9A7sPmW8Vnnw5PRMD4E0lIInEkVKGcJCBDBDwmmSYi7IMKpmecs65XFhzf6WYt3YHzyOMgQn3sDjYQc2chWXLlFxnDx/DWK5xqtbB4g57a/j87pOMpsYgwKKbTwBOURwuueWkAwrMKRNBM1rMZUCERJ7DFMufWMe/pym9zuilMiFhyfVGtG0XflD8MZJSTj2DlsaW/Wy4O4pxCTcwtFj4UP/a6QMRe0sqXE4eGkKOmUOeBDSUCWgPG6tKsYvJEZSGA4aVwDgbJeJCT2F8BonZFpDmGs13KRVCOrJwDJwDGpyFt2PDa8QlbGzOCvlcoyltxn9uscPSd/7tu/LFwriqHujVd4CkeK9u0w+rn3L3GuOLTvbSmpD/QqUfjH0RrfRU+XPI2teUt1Zn6HVzI3gD8cxuWg5U2Q5MrLltXsSy8QYeX8TdqCegrHU6T6lLhjhzBZSNCnvtwYA7g6AyNWCpHHxJ/7X4KhQ+5mdr388+b4f/1rMgwQ/I7ATUGAU9SwJwx4Xl6CMoFZ8d3O8AytWEVpbgji2SCA5pC79nvyz3f3poGWTlsqFaln/4YbR9m+xqFTVIOvmI2+GEgfudkedCBA42Kghph+tUt+vPo+MNvQ1EuyH5D1n17LRwbnJAFgw6ozzj20gSmxMC9pEwQriqiRo78ta+eSDDjRZB
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6919.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(6916009)(4326008)(8676002)(8936002)(316002)(83380400001)(2906002)(54906003)(86362001)(2616005)(186003)(36756003)(6512007)(64756008)(66556008)(91956017)(66446008)(76116006)(71200400001)(66476007)(6506007)(5660300002)(53546011)(26005)(508600001)(6486002)(66946007)(33656002)(38070700005)(122000001)(38100700002)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-ID: <2725A911B90646489177D488DF73881F@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB4936
Original-Authentication-Results: xen.org; dkim=none (message not signed)
 header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM5EUR03FT042.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	88785320-1d56-477d-02b7-08d9896efb6a
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	FEbL2loo6GMr0sNv3228S/xLqJ7iL65Qi4CYumZ+P412Rxo/wmjmOvE7nAl7IrpevV8vPCkJNk1l77dwJCuK3X4YUbTyC0ny/DX7SpZJPixibphsMcLkhM3bHWNsT1uoZruSH70794g2c4HPDYOkiMYKA+u4ngteTfcq1JEcnAfZ4PpauKQn0pNidqnawIGUMX6hF0h55e1khQLFxrRkjeeweeiBdZTv5nrVBXCZeJhKEQftY34SLkE3KZNuwhAwbylK4M1VWSG2J7JXBhTiW0zT40vZ5yFnnYZwW66e0UjMxHDHE167qhP0Oc0gsVzy1hPDeBLk16v2E7Ym8caDyhKu4B4F5bOaxhjh6lvpCfN6nhoCIgSRSdI6jrpjaKWlhPwrHTm11GVM4IUIjAUow3oVM1A1Hmsu8X6MNY1f0tNhDdV2owlcl1E3BEqikfaNoIW5L1vrnL59M/M+frFlGRHwrHPrTMDRMt083cxQnBbDM+BhUB6HQ8vMR2nF6/HvPQzLWNsF8Pw5dnRd5gyKgBe7x4GlpdpDC1wPvf43o4RL0RJeIADeo89wMk7OHrPQ61AzfgsZjjtVSV1jQHyRYlWNHsx3PQSh4uFL3cz8qzR9sAjh8JSSGpcmjAXNudEmiLHRHho29CK/6xtBfpBUFNwfu86ZyluQ4dOyc+l9D8jpJdETfBMbOrFgrkqmmp4V4bauZWG6LP0Or5pFsMit0Q==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(508600001)(47076005)(5660300002)(336012)(53546011)(8676002)(8936002)(6486002)(82310400003)(86362001)(54906003)(4326008)(356005)(6506007)(81166007)(83380400001)(186003)(36860700001)(2906002)(316002)(26005)(33656002)(2616005)(70586007)(107886003)(36756003)(6512007)(6862004)(70206006);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Oct 2021 08:46:54.8983
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 4994ad59-7b66-4944-ffad-08d9896f03ea
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM5EUR03FT042.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3812

SGkgSnVsaWVuLA0KDQo+IE9uIDYgT2N0IDIwMjEsIGF0IDY6NTMgcG0sIEp1bGllbiBHcmFsbCA8
anVsaWVuQHhlbi5vcmc+IHdyb3RlOg0KPiANCj4gSGkgUmFodWwsDQo+IA0KPiBPbiAwNi8xMC8y
MDIxIDE5OjM0LCBSYWh1bCBTaW5naCB3cm90ZToNCj4+PiBPbiA2IE9jdCAyMDIxLCBhdCAxMjoz
MyBwbSwgSWFuIEphY2tzb24gPGl3akB4ZW5wcm9qZWN0Lm9yZz4gd3JvdGU6DQo+Pj4gDQo+Pj4g
UmFodWwgU2luZ2ggd3JpdGVzICgiUmU6IFtQQVRDSCB2NCAxMy8xNF0gYXJtL2xpYnhsOiBFbXVs
YXRlZCBQQ0kgZGV2aWNlIHRyZWUgbm9kZSBpbiBsaWJ4bCIpOg0KPj4+PiBIaSBJYW4JDQo+Pj4+
PiBXaGF0IGlzIHdyb25nIHdpdGggcHV0dGluZyBpdCBpbg0KPj4+Pj4gbGlieGxfX2FyY2hfZG9t
YWluX2J1aWxkX2luZm9fc2V0ZGVmYXVsdA0KPj4+Pj4gd2hpY2ggSSB0aGluayBleGlzdHMgcHJl
Y2lzZWx5IGZvciB0aGlzIGtpbmQgb2YgdGhpbmcgPw0KPj4+PiANCj4+Pj4gQXMgd2UgaGF2ZSB0
byBzZXQgdGhlIGFyY2hfYXJtLnZwY2kgdG8gZmFsc2UgZm9yIHg4NiBhbmQgQVJNIEkNCj4+Pj4g
dGhvdWdodCBpdCBpcyByaWdodCB0byBtb3ZlIHRoZSBjb2RlIHRvIGNvbW1vbiBjb2RlIHRvIGF2
b2lkDQo+Pj4+IGR1cGxpY2F0aW9uLg0KPj4+PiANCj4+Pj4gQXJlIHlvdSBzdWdnZXN0aW5nIHRv
IHB1dCAiDQo+Pj4+IGxpYnhsX2RlZmJvb2xfc2V0ZGVmYXVsdCgmYl9pbmZvLT5hcmNoX2FybS52
cGNpLCBmYWxzZSnDr8W8xZNpbg0KPj4+PiBsaWJ4bF9fYXJjaF9kb21haW5fYnVpbGRfaW5mb19z
ZXRkZWZhdWx0KCkgZm9yIHg4NiBhbmQgQVJNDQo+Pj4+IGRpZmZlcmVudGx5Lg0KPj4+IA0KPj4+
IEkndmUgZ29uZSBiYWNrIGFuZCByZXJlYWQgdGhlIHdob2xlIHRocmVhZCwgd2hpY2ggSSBwcm9i
YWJseSBzaG91bGQNCj4+PiBoYXZlIGRvbmUgdG8gc3RhcnQgd2l0aC4uLi4NCj4+PiANCj4+PiBT
bzoNCj4+PiANCj4+Pj4+PiAjaWYgZGVmaW5lZChfX2FybV9fKSB8fCBkZWZpbmVkKF9fYWFyY2g2
NF9fKQ0KPj4+Pj4+ICAgLyoNCj4+Pj4+PiAgICAqIEVuYWJsZSBWUENJIHN1cHBvcnQgZm9yIEFS
TS4gVlBDSSBzdXBwb3J0IGZvciBET01VIGd1ZXN0cyBpcyBub3QNCj4+Pj4+PiAgICAqIHN1cHBv
cnRlZCBmb3IgeDg2Lg0KPj4+Pj4+ICAgICovDQo+Pj4+Pj4gICBpZiAoZF9jb25maWctPm51bV9w
Y2lkZXZzKQ0KPj4+Pj4+ICAgICBsaWJ4bF9kZWZib29sX3NldCgmYl9pbmZvLT5hcmNoX2FybS52
cGNpLCB0cnVlKTsNCj4+Pj4+PiAjZW5kaWYNCj4+PiANCj4+PiBJIHRoaW5rIHRoaXMgbG9naWMg
cHJvYmFibHkgb3VnaHQgdG8gYmUgaW4gbGlieGwsIG5vdCBpbiB4bC4NCj4+IEkgd2lsbCBtb3Zl
IHRoZSBjb2RlIHRvICJsaWJ4bF9hcm0uYyJ0byBhdm9pZCAjaWZkZWYgaW4gY29tbW9uIGNvZGUg
YW5kIGFsc28gIHRvIGF2b2lkIHNldHRpbmcgdGhlIHZwY2kgZm9yIHg4Ng0KPj4gZGlmZiAtLWdp
dCBhL3Rvb2xzL2xpYnMvbGlnaHQvbGlieGxfYXJtLmMgYi90b29scy9saWJzL2xpZ2h0L2xpYnhs
X2FybS5jDQo+PiBpbmRleCBlMzE0MGE2ZTAwLi4yYmUyMDhiOTliIDEwMDY0NA0KPj4gLS0tIGEv
dG9vbHMvbGlicy9saWdodC9saWJ4bF9hcm0uYw0KPj4gKysrIGIvdG9vbHMvbGlicy9saWdodC9s
aWJ4bF9hcm0uYw0KPj4gQEAgLTEwMSw2ICsxMDEsMTIgQEAgaW50IGxpYnhsX19hcmNoX2RvbWFp
bl9wcmVwYXJlX2NvbmZpZyhsaWJ4bF9fZ2MgKmdjLA0KPj4gICAgICAgICAgcmV0dXJuIEVSUk9S
X0ZBSUw7DQo+PiAgICAgIH0NCj4+ICArICAgIC8qIEVuYWJsZSBWUENJIHN1cHBvcnQuICovDQo+
PiArICAgIGlmIChkX2NvbmZpZy0+bnVtX3BjaWRldnMpIHsNCj4+ICsgICAgICAgIGNvbmZpZy0+
ZmxhZ3MgfD0gWEVOX0RPTUNUTF9DREZfdnBjaTsNCj4+ICsgICAgICAgIGxpYnhsX2RlZmJvb2xf
c2V0KCZkX2NvbmZpZy0+Yl9pbmZvLmFyY2hfYXJtLnZwY2ksIHRydWUpOw0KPj4gKyAgICB9DQo+
PiArDQo+PiAgICAgIHJldHVybiAwOw0KPj4gIH0NCj4+PiAgV2UgdHJ5DQo+Pj4gdG8gbWFrZSB0
aGUgbGlieGwgQVBJICJkbyB0aGUgcmlnaHQgdGhpbmciIGJ5IGRlZmF1bHQuICBJbiB0aGlzIGNh
c2UgSQ0KPj4+IHRoaW5rIHRoYXQgbWVhbnMgdG8gZW5hYmxlIFZQQ0kgKGkpIG9uIHBsYXRmb3Jt
cyB3aGVyZSBpdCdzIGF2YWlsYWJsZQ0KPj4+IChpaSkgaWYgdGhlIGd1ZXN0IGhhcyBQQ0kgcGFz
c3Rocm91Z2ggZGV2aWNlcy4gIElzIHRoYXQgcmlnaHQgPw0KPj4gWWVzIHlvdSBhcmUgcmlnaHQg
VlBDSSB3aWxsIGJlIGVuYWJsZWQgZm9yIGd1ZXN0IHdoZW4gZ3Vlc3QgaGFzIFBDSSBwYXNzdGhy
b3VnaCBkZXZpY2UNCj4+IGFzc2lnbmVkIGFuZCBWUENJIHN1cHBvcnQgaXMgYXZhaWxhYmxlLg0K
Pj4+IA0KPj4+IFNvcnJ5IHRvIGFzayB0aGVzZSBxdWVzdGlvbiBub3csIGFuZCBwbGVhc2UgZm9y
Z2l2ZSBteSBpZ25vcmFuY2U6DQo+Pj4gDQo+Pj4gSXMgVlBDSSBpbmhlcmVudGx5IGFuIEFSTS1z
cGVjaWZpYyBBQkkgb3IgcHJvdG9jb2wgPw0KPj4gQXMgb2Ygbm93IFZQQ0kgZm9yIERPTVUgZ3Vl
c3RzIGlzIG9ubHkgaW1wbGVtZW50ZWQgIGZvciBBUk0uDQo+IA0KPiBXZSBuZWVkIHRvIGRpZmZl
cmVudGlhdGUgYmV0d2VlbiB3aGF0IGl0IGlzIGN1cnJlbnRseSBpbXBsZW1lbnRlZCBhbmQgaG93
IGl0IGNhbiBiZSB1c2VkIGluIHRoZSBmdXR1cmUuDQo+IA0KPiBJbiBwYXJ0aWN1bGFyLCB0aGUg
bGF5b3V0IG9mIGJfaW5mbyBpcyBleHBvc2VkIHRvIGV4dGVybmFsIHRvb2xzdGFjayAoZS5nLiBs
aWJ2aXJ0KS4gU28gd2UgY2FuJ3QgZWFzaWx5IHJlbW92ZSBhbiBvcHRpb24uIEluIG90aGVyIHdv
cmQsIGlmIHdlIGVuZCB1cCB0byBuZWVkIGl0IGZvciBhbiBvdGhlciBhcmNoIHRoZW4gd2Ugd2ls
bCBoYXZlIHRvIGtlZXAgc29tZSBjb21wYXQgY29kZS4NCj4gDQo+IEluIHRoaXMgY2FzZSwgSSB0
aGluayB0aGlzIG9wdGlvbiBpcyBub3QgYXJtIHNwZWNpZmljLiBTbyB0aGUgZmllbGQgb3VnaHQg
dG8gYmUgb3V0c2lkZSBvZiBhcmNoX2FybS4NCg0KQXMgd2UgYXJlIGRpc2N1c3Npbmcgd2hldGhl
ciB3ZSBuZWVkIHRoaXMgZmllbGQgb3Igbm90IElmIHdlIHJlYWNoIHRvIHRoZSBjb25jbHVzaW9u
IHRoZSB3ZSBuZWVkIHRoaXMgZmllbGQgSSB3aWxsIG1vdmUgdGhpcyBvdXRzaWRlIG9mIGFyY2hf
YXJtLg0KPiANCj4+ICANCj4+PiAgV2hlbiBtaWdodCBhbg0KPj4+IGFkbWluIHdhbnQgdG8gdHVy
biBpdCBvbiBleHBsaWNpdGx5ID8NCj4+IEl0IHdpbGwgYmUgZW5hYmxlZCBkeW5hbWljYWxseSB3
aGVuIGFkbWluIGFzc2lnbiBhbnkgUENJIGRldmljZSB0byBndWVzdC4NCj4+PiANCj4+PiBIb3cg
ZG9lcyB0aGlzIGFsbCByZWxhdGUgdG8gdGhlIChub24tYXJjaC1zcGVjaWZpYykgInBhc3N0aHJv
dWdoIg0KPj4+IG9wdGlvbiA/DQo+PiBWUENJIHdpbGwgYmUgZW5hYmxlZCBvbmx5IHdoZW4gdGhl
cmUgaXMgYW55IFBDSSBkZXZpY2UgYXNzaWduZWQgdG8gZ3Vlc3QgdGhlcmVmb3JlIEkgdXNlZA0K
Pj4gImRfY29uZmlnLT5udW1fcGNpZGV2c+KAnSB0byBlbmFibGUgVlBDSS4NCj4gDQo+IE9rLiBT
byB3ZSBkb24ndCBleHBlY3QgJ3hsJyBvciBhbm90aGVyIHRvb2xzdGFjayB0byBlZmZlY3RpdmVs
eSB0b3VjaCB0aGUgZmllbGQgZm9yIHRoZSB0aW1lIGJlaW5nLiBJcyB0aGF0IGNvcnJlY3Q/DQoN
ClllcyBpdCBpcyBjb3JyZWN0LiBPbmx5IHVzZSBvZiB0aGlzIGZpZWxkIGlzIHVzZWQgdG8gY3Jl
YXRlIHRoZSBET01VIGVtdWxhdGVkIFBDSSBkZXZpY2UgdHJlZSBub2RlIHdoZW4gUENJIGRldmlj
ZSBpcyBhc3NpZ25lZCB0byBndWVzdCAoIGRfY29uZmlnLT5udW1fcGNpZGV2cyAhPSBOVUxMICkN
Cj4gDQo+IElmIHNvLCB0aGVuIEkgdGhpbmsgdGhpcyBvcHRpb24gc2hvdWxkIGJlIGhpZGRlbiBm
cm9tIGV4dGVybmFsIHRvb2xzdGFjayB1bnRpbCB3ZSBzZWUgYSB1c2UuDQoNClN0ZWZhbm8gc3Vn
Z2VzdGVkIGluIGFub3RoZXIgZW1haWwgaG93IHdlIGNhbiByZW1vdmUgdGhpcyBmaWVsZC4gSSB3
aWxsIHdvcmsgb24gdG8gcmVtb3ZlIHRoaXMgZmllbGQuDQoNClJlZ2FyZHMsDQpSYWh1bCANCj4g
DQo+IENoZWVycywNCj4gDQo+IC0tIA0KPiBKdWxpZW4gR3JhbGwNCg0K


From xen-devel-bounces@lists.xenproject.org Thu Oct 07 10:51:13 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Oct 2021 10:51:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.203456.358583 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYQzB-0000ak-7j; Thu, 07 Oct 2021 10:50:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 203456.358583; Thu, 07 Oct 2021 10:50:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYQzB-0000ad-4p; Thu, 07 Oct 2021 10:50:49 +0000
Received: by outflank-mailman (input) for mailman id 203456;
 Thu, 07 Oct 2021 10:50:47 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mYQz9-0000aX-Se
 for xen-devel@lists.xenproject.org; Thu, 07 Oct 2021 10:50:47 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mYQz9-00010g-QC
 for xen-devel@lists.xenproject.org; Thu, 07 Oct 2021 10:50:47 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mYQz9-0003Qj-Oz
 for xen-devel@lists.xenproject.org; Thu, 07 Oct 2021 10:50:47 +0000
Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89)
 (envelope-from <iwj@xenproject.org>)
 id 1mYQz4-00068u-Lc; Thu, 07 Oct 2021 11:50:42 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date
	:Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From;
	bh=tFXPgezor6tDmD5bxbcEDp//+SfGGKXicdAcPMZYa4Y=; b=OqhkEEVVImmzvC/vtReDaLZVt7
	CtnQHX/zNnL5xF39MSddpxLb+9o3ixYYHJbPnQiE6pLJ9PIlhwax4ElRn9Ii0DGYYcyIQ7xVzcbjQ
	XdjalAQ50rum+tW/I/EozQRM6WIARTDvrWKTpncT80kWe1N9ls6al4mECCjXLtpzd4zM=;
From: Ian Jackson <iwj@xenproject.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-16
Content-Transfer-Encoding: 8bit
Message-ID: <24926.53506.270924.8163@mariner.uk.xensource.com>
Date: Thu, 7 Oct 2021 11:50:42 +0100
To: Rahul Singh <Rahul.Singh@arm.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
    xen-devel <xen-devel@lists.xenproject.org>,
    Bertrand Marquis <Bertrand.Marquis@arm.com>,
    Andre Przywara <Andre.Przywara@arm.com>,
    Wei Liu <wl@xen.org>,
    Anthony PERARD <anthony.perard@citrix.com>,
    Juergen Gross <jgross@suse.com>,
    Julien Grall <julien@xen.org>,
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH v4 13/14] arm/libxl: Emulated PCI device tree node in
 libxl
In-Reply-To: <5ADA6C46-A69D-459F-868C-DA579FEC36E2@arm.com>
References: <cover.1633340795.git.rahul.singh@arm.com>
	<3ad42008f534671ae7f5b25da91253ce7cd4a3e9.1633340795.git.rahul.singh@arm.com>
	<alpine.DEB.2.21.2110041714410.3209@sstabellini-ThinkPad-T480s>
	<11F169C6-39A4-40F3-8E75-39B8C2CCF022@arm.com>
	<alpine.DEB.2.21.2110051421520.3209@sstabellini-ThinkPad-T480s>
	<8B848F95-977F-4DF4-B315-CFEA610BC1C3@arm.com>
	<24925.33634.554859.2131@mariner.uk.xensource.com>
	<BFC5AD62-3DA7-498F-8B6E-AB4C8CAA9731@arm.com>
	<24925.35194.369692.94259@mariner.uk.xensource.com>
	<5ADA6C46-A69D-459F-868C-DA579FEC36E2@arm.com>
X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu)

Rahul Singh writes ("Re: [PATCH v4 13/14] arm/libxl: Emulated PCI device tree node in libxl"):
> On 6 Oct 2021, at 12:33 pm, Ian Jackson <iwj@xenproject.org> wrote:
> >  We try
> > to make the libxl API "do the right thing" by default.  In this case I
> > think that means to enable VPCI (i) on platforms where it's available
> > (ii) if the guest has PCI passthrough devices.  Is that right ?
> 
> Yes you are right VPCI will be enabled for guest when guest has PCI passthrough device 
> assigned and VPCI support is available.  
> > 
> > Sorry to ask these question now, and please forgive my ignorance:
> > 
> > Is VPCI inherently an ARM-specific ABI or protocol ?
> 
> As of now VPCI for DOMU guests is only implemented  for ARM.

I'm sorry.  It appears that the thrust of my questions wasn't
sufficiently clear.  Your replies about details are fine but they
don't seem to address my underlying concerns.

"as of now ... only implemented for ARM" suggests to me that it is
VPCI *not* inherently ARM-specific.  Ie, it is a thing that x86 (or
riscv or whatever) might support in future.  Is that right ?

How does VPCI fit into the whole system architecture ?  Is it
*required* for PCI passthrough on ARM ?  If not, what happens if it is
not enabled ?

If VPCI *is* ARM-specific, how do x86 systems (say) achieve the goals
met on ARM by VPCI ?

On the other hand if VPCI is not inherently ARM-specific it should not
be in the ARM part of the libxl IDL.

> >  When might an
> > admin want to turn it on explicitly ?
> 
> It will be enabled dynamically when admin assign any PCI device to guest.

What about hotplug ?

> > How does this all relate to the (non-arch-specific) "passthrough"
> > option ?
> 
> VPCI will be enabled only when there is any PCI device assigned to
> guest therefore I used "d_config->num_pcidevs� to enable VPCI.

The purpose of the "passthrough" option is to allow the guest admin to
specify that a guest is expected to gain hotplugged PCI devices in
future.  That way, domain features that are required for PCI
passthrough are automatically enabled.

Perhaps this isn't explained clearly enough in the documentation,
which talks about iommu mappings.

Does PCI passthrugh work on ARM without VPCI ?

I think it likely that VPCI should be controlled (or at least, its
default set) from the "passthrough" option.  But I don't understand
enough of the relationship between the pieces.

Ian.


From xen-devel-bounces@lists.xenproject.org Thu Oct 07 10:53:53 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Oct 2021 10:53:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.203467.358595 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYR28-0001I6-RB; Thu, 07 Oct 2021 10:53:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 203467.358595; Thu, 07 Oct 2021 10:53:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYR28-0001Hz-OG; Thu, 07 Oct 2021 10:53:52 +0000
Received: by outflank-mailman (input) for mailman id 203467;
 Thu, 07 Oct 2021 10:53:51 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mYR27-0001Ht-Mf
 for xen-devel@lists.xenproject.org; Thu, 07 Oct 2021 10:53:51 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mYR27-000158-Lz
 for xen-devel@lists.xenproject.org; Thu, 07 Oct 2021 10:53:51 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mYR27-0003bW-Kz
 for xen-devel@lists.xenproject.org; Thu, 07 Oct 2021 10:53:51 +0000
Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89)
 (envelope-from <iwj@xenproject.org>)
 id 1mYR22-0006AI-Tw; Thu, 07 Oct 2021 11:53:46 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date
	:Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From;
	bh=5r18isox69HWOlErqX6kicas+rMNkHHt/kdttCLlODU=; b=zTA1T0J1SAS4bUTCgw3eKcLe/i
	DTAa0F6eBPSjFTB+DLX15mjMKJCVKNhMOgLYwFdRUpnf4WaVkJzUwvhuLfEs8ky701Y4SD3vQBYF0
	p7BtGloIGhSgRwtzMoDW/KI4gtNvmWD9IypEGRtSnBta13j4+51VNqmn26GQxsKaT9vs=;
From: Ian Jackson <iwj@xenproject.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <24926.53690.621007.507249@mariner.uk.xensource.com>
Date: Thu, 7 Oct 2021 11:53:46 +0100
To: Julien Grall <julien@xen.org>
Cc: Rahul Singh <rahul.singh@arm.com>,
    xen-devel@lists.xenproject.org,
    bertrand.marquis@arm.com,
    Andre.Przywara@arm.com,
    Wei Liu <wl@xen.org>,
    Anthony PERARD <anthony.perard@citrix.com>,
    Juergen Gross <jgross@suse.com>,
    Stefano Stabellini <sstabellini@kernel.org>,
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH v5 10/11] arm/libxl: Emulated PCI device tree node in
 libxl
In-Reply-To: <7bdac405-a889-15e1-be19-5876f7253855@xen.org>
References: <cover.1633540842.git.rahul.singh@arm.com>
	<b81b5dea800c8fe47071f3dbd20588b1e472fb99.1633540842.git.rahul.singh@arm.com>
	<7bdac405-a889-15e1-be19-5876f7253855@xen.org>
X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu)

Julien Grall writes ("Re: [PATCH v5 10/11] arm/libxl: Emulated PCI device tree node in libxl"):
> On 06/10/2021 19:40, Rahul Singh wrote:
> > diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_types.idl
> > index 3f9fff653a..78b1ddf0b8 100644
> > --- a/tools/libs/light/libxl_types.idl
> > +++ b/tools/libs/light/libxl_types.idl
> > @@ -644,6 +644,7 @@ libxl_domain_build_info = Struct("domain_build_info",[
> >   
> >       ("arch_arm", Struct(None, [("gic_version", libxl_gic_version),
> >                                  ("vuart", libxl_vuart_type),
> > +                               ("vpci", libxl_defbool),
> 
> I have posted some comments regarding the field in v4. To summarize, 
> AFAICT, this option is meant to be only set by libxl but you still let 
> the toolstack (e.g. xl, libvirt) to set it.
> 
> If you still want to expose to the toolstack, then I think the option 
> should be outside of arch_arm. Otherwise, this should be moved in an 
> internal structure (Ian, do you have any suggestion?).

If it should be in an internal structure, probably the libxl create
context.

But I'm not convinced yet.  In particular, if enabling VPCI is
necessary on ARM for hotplugged PCI devices[1], then there has to be
a way for the admin to say "while this domain may not have any PCI
devices right now, I may wish to hotplug some".  That's what the
"passthrough=" option is for.

See my other mail.

[1] I think this is all true even if PCI hotplug for ARM is not
currently implemented.

Ian.


From xen-devel-bounces@lists.xenproject.org Thu Oct 07 10:57:49 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Oct 2021 10:57:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.203476.358606 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYR5t-0001zD-Cj; Thu, 07 Oct 2021 10:57:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 203476.358606; Thu, 07 Oct 2021 10:57:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYR5t-0001z6-9l; Thu, 07 Oct 2021 10:57:45 +0000
Received: by outflank-mailman (input) for mailman id 203476;
 Thu, 07 Oct 2021 10:57:44 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mYR5s-0001z0-A0
 for xen-devel@lists.xenproject.org; Thu, 07 Oct 2021 10:57:44 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mYR5s-00018k-5s
 for xen-devel@lists.xenproject.org; Thu, 07 Oct 2021 10:57:44 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mYR5s-00041B-4s
 for xen-devel@lists.xenproject.org; Thu, 07 Oct 2021 10:57:44 +0000
Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89)
 (envelope-from <iwj@xenproject.org>)
 id 1mYR5m-0006CA-Vc; Thu, 07 Oct 2021 11:57:38 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date
	:Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From;
	bh=prGYN0ziHtbQ/xbBVY+4Jucrl7ufzTOwijogI2BxJ2E=; b=4iQv3PE4c9S2NUrKaUkDLFXQ7s
	SebsS3SSFMTHTs3dWTbOkum5DBvrG9Qh2c83mfILIVyqCjJVamW3H1TqDRLvcQzB41eek2Qn0bVys
	p+pRXQmXo+X52UokBbsHXRG7p/gCN/pL6TDEljtKX2L9KqpbKI20IHiqhtznV1sJ5r9k=;
From: Ian Jackson <iwj@xenproject.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <24926.53922.628049.481827@mariner.uk.xensource.com>
Date: Thu, 7 Oct 2021 11:57:38 +0100
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: Oleksandr <olekstysh@gmail.com>,
    xen-devel@lists.xenproject.org,
    Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
    Wei Liu <wl@xen.org>,
    Anthony PERARD <anthony.perard@citrix.com>,
    Juergen Gross <jgross@suse.com>,
    Julien Grall <julien@xen.org>,
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH V5 2/3] libxl/arm: Add handling of extended regions for
 DomU
In-Reply-To: <alpine.DEB.2.21.2110061658450.3209@sstabellini-ThinkPad-T480s>
References: <1633519346-3686-1-git-send-email-olekstysh@gmail.com>
	<1633519346-3686-3-git-send-email-olekstysh@gmail.com>
	<24925.35278.762786.539238@mariner.uk.xensource.com>
	<224ed316-aac0-3ad4-22a1-efc592e717e2@gmail.com>
	<alpine.DEB.2.21.2110061658450.3209@sstabellini-ThinkPad-T480s>
X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu)

Stefano Stabellini writes ("Re: [PATCH V5 2/3] libxl/arm: Add handling of extended regions for DomU"):
> On Wed, 6 Oct 2021, Oleksandr wrote:
> > On 06.10.21 14:34, Ian Jackson wrote:
> > > Oleksandr Tyshchenko writes ("[PATCH V5 2/3] libxl/arm: Add handling of
> > > extended regions for DomU"):
> > > > The extended region (safe range) is a region of guest physical
> > > > address space which is unused and could be safely used to create
> > > > grant/foreign mappings instead of wasting real RAM pages from
> > > > the domain memory for establishing these mappings.
> > > Please forgive me for asking this question now, but: why is this
> > > ARM-specific ?
> > 
> > 
> > Sorry, I can't say for sure which x86 mode also suffers from
> > that. I might be wrong, but as I understand that x86 in PVH (and
> > HVM?) mode uses unpopulated memory ranges (which are unused from
> > Linux PoV, actually everything not yet allocated or reserved from
> > "iomem_resource") to create foreign/grant mappings.  So the real
> > RAM pages are not ballooned out to get an physical address space
> > to create these mappings. The problem is that we cannot follow
> > Linux advise which memory ranges are unused on Arm for several
> > reasons, this is why this patch series makes the hypervisor to
> > start allocating and exposing these ranges.

So it sounds like you are saying this is an ARM-specific problem ?
The key being the "several reasons" which you mention.  Are they
ARM-specifc problems.

> Two more things about this being ARM-specific.
> 
> Even if x86 was affected exactly by the same problem, the code to expose
> the safe memory ranges to DomU is arch-specific (currently device tree.)
> 
> Also the code to calculate the safe memory ranges is arch-specific as it
> depends on the DomU memory layout which is arch-specific.

This demonstrates that the implementation is arch-specific.  But one
of libxl's functions is to abstract away implementation details and
provide an interface that can be used to "do the right thing".

Ian.


From xen-devel-bounces@lists.xenproject.org Thu Oct 07 11:04:35 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Oct 2021 11:04:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.203485.358617 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYRCQ-0003RX-3x; Thu, 07 Oct 2021 11:04:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 203485.358617; Thu, 07 Oct 2021 11:04:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYRCQ-0003RQ-0B; Thu, 07 Oct 2021 11:04:30 +0000
Received: by outflank-mailman (input) for mailman id 203485;
 Thu, 07 Oct 2021 11:04:28 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=A0uJ=O3=gmail.com=rm.skakun@srs-us1.protection.inumbo.net>)
 id 1mYRCO-0003RK-I1
 for xen-devel@lists.xenproject.org; Thu, 07 Oct 2021 11:04:28 +0000
Received: from mail-lf1-x12a.google.com (unknown [2a00:1450:4864:20::12a])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 53926e5f-8c01-459d-988a-ba31acdcb2e6;
 Thu, 07 Oct 2021 11:04:27 +0000 (UTC)
Received: by mail-lf1-x12a.google.com with SMTP id i24so22423242lfj.13
 for <xen-devel@lists.xenproject.org>; Thu, 07 Oct 2021 04:04:27 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 53926e5f-8c01-459d-988a-ba31acdcb2e6
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc:content-transfer-encoding;
        bh=9jP2d89X+kWjeTBhkUbJIM4PPIeDYyNUgkGwBJAUDM8=;
        b=IPie/laU4y6ly7aAN2xdcZRMcRQy7jw0K67z+wy7r0y2akbO16ZD2sOtSDsLXgfZHZ
         M5t81p5NpuvQILVoz0ElykirfeOvGHN6gsq/a8noRYpifGukcwAzO/AO5bVvgtxARpLZ
         jGeG3X6hTiDj4pTs9CqN1LBHp8jOlGpR9YeJ2Gec4pEPL0n0TQxgcXmVOAHVAf0ePE/J
         ecCFhewknjcYPV7ZlB1Yx+J4qdsbpUovjysE5piTcuNZcHGBNcEHFC0hh4OqNYb4t/Ra
         50M10S8CSNK7nWYqGKYFF8tJrBOd6twN89+H7XODkbi6wGRuLZday1CTe4OmzsoYHY89
         5/ig==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc:content-transfer-encoding;
        bh=9jP2d89X+kWjeTBhkUbJIM4PPIeDYyNUgkGwBJAUDM8=;
        b=UQwR97SD9G4rZ0W6FIHaWb3rSqi3cEZNgedijC09IuVwavHWP6sbRYpWUsy4+qMXip
         uJio201qywbBwXgx56V1vSP5Mvu5Ee/PDWl8uDV9cS21/Hp+TWk+5COUnaqtlYCqfOXs
         Tt8vA4rRopq44GSfKISQO0B0tE8rm+Nc91tb7ai7RT1oOR+o1ElUmPtMp5eGqN/8FMok
         J0ozUj+XXEKroudShqgdzHcDxd60gHw8GHXthJxyPz3N4XmMdIB1c/cIp4BPM01EiGZy
         mAm4PGTFq0DTNfkFu419E1Dx0gvhDwkvsFWh7nWF3ulnWGEE0MD+ieYpTl0fwuCrn+Ab
         eJXw==
X-Gm-Message-State: AOAM531cO8FqSDm0xWnKCMnJBKUTgl5d/HPhyU+g6MrhR373ETzG+GM1
	TNyA42rbFFPa0IjgjCIUuOk4DIdMEXgiGgQAlOw=
X-Google-Smtp-Source: ABdhPJyfdKE4PxIK04VLfT21c921fcozx1jw8d2B/K6W4nuoXnEehHYqlXC5AuB02Hy4pmMQtLKXvY3+TRtLdgw+cU4=
X-Received: by 2002:a2e:5c7:: with SMTP id 190mr3861902ljf.277.1633604664637;
 Thu, 07 Oct 2021 04:04:24 -0700 (PDT)
MIME-Version: 1.0
References: <cover.1633106362.git.roman_skakun@epam.com> <5b101e4e85668bbb18da83044520b0350344f408.1633106362.git.roman_skakun@epam.com>
 <292787a5-503f-72a5-3255-e583a1d014cb@gmail.com>
In-Reply-To: <292787a5-503f-72a5-3255-e583a1d014cb@gmail.com>
From: Roman Skakun <rm.skakun@gmail.com>
Date: Thu, 7 Oct 2021 14:04:13 +0300
Message-ID: <CADu_u-Pn6_+1_YFJCJpZff2LvJJz1ntn0vZ1JOuvSU0Yg=2VYw@mail.gmail.com>
Subject: Re: [RFC 1/1] xen/arm: set iommu property for IOMMU-protected devices
To: Oleksandr <olekstysh@gmail.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>, 
	xen-devel@lists.xenproject.org, Roman Skakun <roman_skakun@epam.com>, 
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, Andrii Anisov <andrii_anisov@epam.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Oleksandr,

>> From: Roman Skakun <roman_skakun@epam.com>
>>
>> Xen is not exposing any IOMMU properties to Dom0.
>> So Dom0 assumes that all it's devices are not protected by IOMMU.
>>
>> To make Dom0 aware of IOMMU-protected devices, we need to mark
>> them somehow. With this approach Dom0 Linux kernel will be able
>> to selectively disable swiotlb-xen fops for them which will remove
>> unnecessary buffer bounces.
>>
>> This patch adds mechanism to describe IOMMU-protected devices by
>> adding `xen,behind-iommu` property to relevant device nodes in
>> Dom0 device tree.
>
> I think that new property should be documented probably at
>
> docs/misc/arm/device-tree/...

Yes, make sense.
I will add a description for a new property in the next patch series.
Thanks!

Cheers,
Roman

=D1=81=D1=80, 6 =D0=BE=D0=BA=D1=82. 2021 =D0=B3. =D0=B2 15:45, Oleksandr <o=
lekstysh@gmail.com>:
>
>
> On 04.10.21 12:54, Roman Skakun wrote:
>
> Hi Roman
>
> > From: Roman Skakun <roman_skakun@epam.com>
> >
> > Xen is not exposing any IOMMU properties to Dom0.
> > So Dom0 assumes that all it's devices are not protected by IOMMU.
> >
> > To make Dom0 aware of IOMMU-protected devices, we need to mark
> > them somehow. With this approach Dom0 Linux kernel will be able
> > to selectively disable swiotlb-xen fops for them which will remove
> > unnecessary buffer bounces.
> >
> > This patch adds mechanism to describe IOMMU-protected devices by
> > adding `xen,behind-iommu` property to relevant device nodes in
> > Dom0 device tree.
>
> I think that new property should be documented probably at
>
> docs/misc/arm/device-tree/...
>
> >
> > Signed-off-by: Roman Skakun <roman_skakun@epam.com>
> > ---
> >   xen/arch/arm/domain_build.c | 7 +++++++
> >   1 file changed, 7 insertions(+)
> >
> > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
> > index 69fff7fc29..99e2c42b6c 100644
> > --- a/xen/arch/arm/domain_build.c
> > +++ b/xen/arch/arm/domain_build.c
> > @@ -580,6 +580,13 @@ static int __init write_properties(struct domain *=
d, struct kernel_info *kinfo,
> >               return res;
> >       }
> >
> > +    if ( iommu_node && is_iommu_enabled(d) && dt_device_is_protected(n=
ode) )
> > +    {
> > +        res =3D fdt_property(kinfo->fdt, "xen,behind-iommu", NULL, 0);
> > +        if ( res )
> > +            return res;
> > +    }
> > +
> >       /*
> >        * Override the property "status" to disable the device when it's
> >        * marked for passthrough.
>
> --
> Regards,
>
> Oleksandr Tyshchenko
>


--=20
Best Regards, Roman.


From xen-devel-bounces@lists.xenproject.org Thu Oct 07 11:30:51 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Oct 2021 11:30:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.203494.358628 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYRbn-0006gl-1K; Thu, 07 Oct 2021 11:30:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 203494.358628; Thu, 07 Oct 2021 11:30:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYRbm-0006ge-Te; Thu, 07 Oct 2021 11:30:42 +0000
Received: by outflank-mailman (input) for mailman id 203494;
 Thu, 07 Oct 2021 11:30:41 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mYRbl-0006gU-4F; Thu, 07 Oct 2021 11:30:41 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mYRbk-0001jK-TG; Thu, 07 Oct 2021 11:30:40 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mYRbk-0004Ia-I6; Thu, 07 Oct 2021 11:30:40 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mYRbk-0006LM-Fp; Thu, 07 Oct 2021 11:30:40 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=4cq0w28+7q7LMxZygDPWVxelCG3p76cY+QpdWmmtnx8=; b=G8UTUOdDo1Z5id02M6pj6kv4+V
	TW35FOD4K58QqxTeyL1URJe7pZrrRK8714dWck1Xj0WsIXzCaN/CJw/pvczjtSc7uQoYmCMjA0e9/
	2IcqZGBQItqSS6YUPtvSKOc0gbQNsDVde4wkdslXJNWho43VPs6sU4051Ode9yn/A4HY=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165390-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 165390: regressions - FAIL
X-Osstest-Failures:
    qemu-mainline:test-arm64-arm64-libvirt-raw:guest-start/debian.repeat:fail:regression
    qemu-mainline:test-arm64-arm64-xl-vhd:xen-boot:fail:heisenbug
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:windows-install:fail:heisenbug
    qemu-mainline:test-armhf-armhf-xl-rtds:guest-start:fail:heisenbug
    qemu-mainline:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable
    qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=9618c5badaa8eed25259cf095ff880efb939fbe7
X-Osstest-Versions-That:
    qemuu=99c44988d5ba1866a411450c877ed818b1b70081
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 07 Oct 2021 11:30:40 +0000

flight 165390 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165390/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-arm64-arm64-libvirt-raw 17 guest-start/debian.repeat fail REGR. vs. 164950

Tests which are failing intermittently (not blocking):
 test-arm64-arm64-xl-vhd       8 xen-boot         fail in 165374 pass in 165390
 test-amd64-i386-xl-qemuu-ws16-amd64 12 windows-install fail in 165374 pass in 165390
 test-armhf-armhf-xl-rtds     14 guest-start                fail pass in 165374

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail in 165374 REGR. vs. 164950

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-xl-rtds    15 migrate-support-check fail in 165374 never pass
 test-armhf-armhf-xl-rtds 16 saverestore-support-check fail in 165374 never pass
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 164950
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 164950
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 164950
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 164950
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 164950
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 164950
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 164950
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 164950
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass

version targeted for testing:
 qemuu                9618c5badaa8eed25259cf095ff880efb939fbe7
baseline version:
 qemuu                99c44988d5ba1866a411450c877ed818b1b70081

Last test of basis   164950  2021-09-11 18:57:22 Z   25 days
Failing since        164967  2021-09-13 13:06:52 Z   23 days   34 attempts
Testing same since   165374  2021-10-05 05:51:59 Z    2 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
  Alex Bennée <alex.bennee@linaro.org>
  Alex Chen <alex.chen@huawei.com>
  Alexander Graf <agraf@csgraf.de>
  Alexandra Clifford <aclifford@draper.com>
  AlexChen <alex.chen@huawei.com>
  Alistair Francis <alistair.francis@wdc.com>
  Amanda Strnad <astrnad@draper.com>
  Andrew Jeffery <andrew@aj.id.au>
  Anup Patel <anup.patel@wdc.com>
  BALATON Zoltan <balaton@eik.bme.hu>
  Bin Meng <bin.meng@windriver.com>
  Bin Meng <bmeng.cn@gmail.com>
  Cai Huoqing <caihuoqing@baidu.com>
  Chris Rauer <crauer@google.com>
  Cleber Rosa <crosa@redhat.com>
  Cornelia Huck <cohuck@redhat.com>
  Cédric Le Goater <clg@kaod.org>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniel P. Berrangé <berrange@redhat.com>
  David Gibson <david@gibson.dropbear.id.au>
  David Hildenbrand <david@redhat.com>
  Dongli Zhang <dongli.zhang@oracle.com>
  Dr. David Alan Gilbert <dgilbert@redhat.com>
  Edgar E. Iglesias <edgar.iglesias@xilinx.com>
  Eric Blake <eblake@redhat.com>
  Frank Chang <frank.chang@sifive.com>
  G S Niteesh Babu <niteesh.gs@gmail.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Green Wan <green.wan@sifive.com>
  Guenter Roeck <linux@roeck-us.net>
  Hanna Reitz <hreitz@redhat.com>
  Igor Mammedov <imammedo@redhat.com>
  Ilya Leoshkevich <iii@linux.ibm.com>
  Jason Wang <jasowang@redhat.com>
  Joel Stanley <joel@jms.id.au>
  John Arbuckle <programmingkidx@gmail.com>
  John Snow <jsnow@redhat.com>
  John Snow <jsnow@redhat.com> (Feel free to merge.)
  Jose R. Ziviani <jziviani@suse.de>
  Justin Restivo <jrestivo@draper.com>
  Kai Huang <kai.huang@intel.com>
  Kirill Tkhai <ktkhai@virtuozzo.com>
  Klaus Jensen <k.jensen@samsung.com>
  Lara Lazier <laramglazier@gmail.com>
  Laurent Vivier <laurent@vivier.eu>
  LIU Zhiwei <zhiwei_liu@c-sky.com>
  Luc Michel <lmichel@kalray.eu>
  Luis Pires <luis.pires@eldorado.org.br>
  Marc Zyngier <maz@kernel.org>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
  Markus Armbruster <armbru@redhat.com>
  Matheus Ferst <matheus.ferst@eldorado.org.br>
  Max Hsu <max.hsu@sifive.com>
  Max Reitz <mreitz@redhat.com>
  Michael S. Tsirkin <mst@redhat.com>
  Michael Tokarev <mjt@tls.msk.ru>
  Michal Privoznik <mprivozn@redhat.com>
  Naveen Nagar <naveen.n1@samsung.com>
  Neil Armstrong <narmstrong@baylibre.com>
  nia <nia@NetBSD.org>
  Nia Alarie <nia@NetBSD.org>
  Niek Linnenbank <nieklinnenbank@gmail.com>
  Nir Soffer <nirsof@gmail.com>
  Nir Soffer <nsoffer@redhat.com>
  Pankaj Gupta <pankaj.gupta.linux@gmail.com>
  Pankaj Raghav <p.raghav@samsung.com>
  Paolo Bonzini <pbonzini@redhat.com>
  Pavel Dovgalyuk <Pavel.Dovgaluk@ispras.ru>
  Pavel Dovgalyuk <Pavel.Dovgalyuk@ispras.ru>
  Peter Collingbourne <pcc@google.com>
  Peter Delevoryas <pdel@fb.com>
  Peter Maydell <peter.maydell@linaro.org>
  Peter Xu <peterx@redhat.com>
  Philippe Mathieu-Daudé <f4bug@amsat.org>
  Philippe Mathieu-Daudé <philmd@redhat.com>
  Reinoud Zandijk <Reinoud@NetBSD.org>
  Richard Henderson <richard.henderson@linaro.org>
  Richard W.M. Jones <rjones@redhat.com>
  Roman Bolshakov <r.bolshakov@yadro.com>
  Roman Bolshakov <r.bolshakov@yadro.com> (x86 only)
  Sai Pavan Boddu <sai.pavan.boddu@xilinx.com>
  Sean Christopherson <sean.j.christopherson@intel.com>
  Sergio Lopez <slp@redhat.com>
  Shashi Mallela <shashi.mallela@linaro.org>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Weil <sw@weilnetz.de>
  Stefano Garzarella <sgarzare@redhat.com>
  Thomas Huth <thuth@redhat.com>
  Tong Ho <tong.ho@xilinx.com>
  Viktor Prutyanov <viktor.prutyanov@phystech.edu>
  Vitaly Kuznetsov <vkuznets@redhat.com>
  Vivek Kasireddy <vivek.kasireddy@intel.com>
  Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
  Wainer dos Santos Moschetta <wainersm@redhat.com>
  Willian Rampazzo <willianr@redhat.com>
  Xuzhou Cheng <xuzhou.cheng@windriver.com>
  Yanan Wang <wangyanan55@huawei.com>
  Yang Zhong <yang.zhong@intel.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 fail    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 11682 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Oct 07 12:30:58 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Oct 2021 12:30:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.203528.358659 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYSXv-0005M3-7e; Thu, 07 Oct 2021 12:30:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 203528.358659; Thu, 07 Oct 2021 12:30:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYSXv-0005Lw-4X; Thu, 07 Oct 2021 12:30:47 +0000
Received: by outflank-mailman (input) for mailman id 203528;
 Thu, 07 Oct 2021 12:30:45 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=4W4d=O3=gmail.com=olekstysh@srs-us1.protection.inumbo.net>)
 id 1mYSXt-0005Lq-QE
 for xen-devel@lists.xenproject.org; Thu, 07 Oct 2021 12:30:45 +0000
Received: from mail-ed1-x532.google.com (unknown [2a00:1450:4864:20::532])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id ffbc5a0e-8e36-4965-a989-56207da03f0d;
 Thu, 07 Oct 2021 12:30:44 +0000 (UTC)
Received: by mail-ed1-x532.google.com with SMTP id l7so22729842edq.3
 for <xen-devel@lists.xenproject.org>; Thu, 07 Oct 2021 05:30:44 -0700 (PDT)
Received: from [192.168.1.7] ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id 19sm10039976ejw.31.2021.10.07.05.30.41
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Thu, 07 Oct 2021 05:30:42 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ffbc5a0e-8e36-4965-a989-56207da03f0d
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-transfer-encoding:content-language;
        bh=tdvL5IqU9ZE5cw9OHmnOpjbbyF1jxDGO10SRGnkq+oM=;
        b=hfCDvc7K1JIK1v2gjykIcMdqLhTXLcmhgWeJwMzMpZVhP2J9bMsjy087tOTQHJ08W4
         YlMosetJofqBIF/IjYT7WgkP6jExCVaC3FifgFfiRiRsI6KM5RFL+G/eqof1YES5jdag
         uBxFfXWxfxs0tFd7m4miA2NREwobezi49BvMZ/RbRa4WNUHYbWvbnLDDvfv4TZsF9C5K
         qFeamXRnNnR2+qJzfYj9DJQu/SEgTep5dSSMTUg5n1QhcnV/CCl05RVYYVC8eEF9xtyg
         v1uwvQOBUIn5XFP+6wxK3TpQWcSqVdb869UH0/wnraFOgMcRBg5aY7D3/W2qjnDOTs0T
         cXaA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding
         :content-language;
        bh=tdvL5IqU9ZE5cw9OHmnOpjbbyF1jxDGO10SRGnkq+oM=;
        b=LmoMTy2ijf/uMFMGk6y6QvMeVrsiN73qax+l920ArsT11X3D5o+vlUH49VODwKizpO
         0UyHckRzaPxGMLyEqLla6j1WhFc7Ud3+MwFztPxizpnWIm140xXquYE5TnovbzRxFS3T
         +d+vDjfJvdBhFLxTje/R6+ySb3KCDdjMF4Qfp+4S4POxEBApZzvsHfCxZ44EbfPmKsiz
         GbplCJj2tJohyqechcc+FTwRxRrRuEK+jlgKzIZK9kWy9Ymz8tk9Ro0iBHGKYZBIRFtE
         yKaq4h3em0JhsCACe38qbfz5Xk8b4lHFUm2Sr7D15tdOApNG1RnQTtuHiuxO2oLMUfXT
         vI3Q==
X-Gm-Message-State: AOAM532o2ygl2pOWD4urh77V/WHL8hHZ7fdO0iKs7FlkQsGIVPzXVmwY
	YjdGj1Po7WQlWPLAgYBcgF4liPT6MWI=
X-Google-Smtp-Source: ABdhPJy/bHQgC4bVJYYzw48mAQnbsi4nTyQQ2SDBZffhHpm7WO+ncgd/+qE2RCYbxWTEk+HNjOFAew==
X-Received: by 2002:a05:6402:40d0:: with SMTP id z16mr6149438edb.220.1633609842909;
        Thu, 07 Oct 2021 05:30:42 -0700 (PDT)
Subject: Re: [PATCH V5 1/3] xen/arm: Introduce gpaddr_bits field to struct
 xen_arch_domainconfig
To: Jan Beulich <jbeulich@suse.com>
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>,
 Anthony PERARD <anthony.perard@citrix.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Juergen Gross
 <jgross@suse.com>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 xen-devel@lists.xenproject.org
References: <1633519346-3686-1-git-send-email-olekstysh@gmail.com>
 <1633519346-3686-2-git-send-email-olekstysh@gmail.com>
 <68cb29bb-7d84-dc27-eead-4a079b9caf68@suse.com>
From: Oleksandr <olekstysh@gmail.com>
Message-ID: <e77eea6f-163d-0920-2e90-fb9f3a602743@gmail.com>
Date: Thu, 7 Oct 2021 15:30:41 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <68cb29bb-7d84-dc27-eead-4a079b9caf68@suse.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US


On 07.10.21 10:42, Jan Beulich wrote:

Hi Jan.

> On 06.10.2021 13:22, Oleksandr Tyshchenko wrote:
>> Changes V4 -> V5:
>>     - update patch subject and description
>>     - drop Michal's R-b
>>     - pass gpaddr_bits via createdomain domctl
>>       (struct xen_arch_domainconfig)
> I'm afraid I can't bring this in line with ...
>
>> --- a/xen/include/public/arch-arm.h
>> +++ b/xen/include/public/arch-arm.h
>> @@ -333,6 +333,11 @@ struct xen_arch_domainconfig {
>>        *
>>        */
>>       uint32_t clock_frequency;
>> +    /*
>> +     * OUT
>> +     * Guest physical address space size
>> +     */
>> +    uint8_t gpaddr_bits;
> ... this being an OUT field. Is this really what Andrew had asked for?
> I would have expected the entire struct to be IN (and the comment at
> the top of the containing struct in public/domctl.h also suggests so,
> i.e. your new field renders that comment stale). gic_version being
> IN/OUT is already somewhat in conflict ...
I am sorry but I'm totally confused now, we want the Xen to provide 
gpaddr_bits to the toolstack, but not the other way around.
As I understand the main ask was to switch to domctl for which I wanted 
to get some clarification on how it would look like... Well, this patch 
switches to use
domctl, and I think exactly as it was suggested at [1] in case if a 
common one is a difficult to achieve. I have to admit, I felt it was 
indeed difficult to achieve.


I thought that a comment for struct xen_domctl_createdomain in 
public/domctl.h was rather related to the struct fields described in the 
public header than to the arch sub-struct internals described elsewhere. 
But if my assumption is incorrect, then yes the comment got stale and 
probably not by changes in current patch, but after adding 
clock_frequency field (OUT). If so we can add a comment on top of arch 
field clarifying that internal fields *might* be OUT.


> One of the problems with
> _any_ of the fields being OUT is that then it is unclear how the output
> is intended to be propagated to consumers other than the entity
> creating the domain.
If I *properly* understood your concern, we could hide that field in 
struct libxl__domain_build_state and not expose it to struct 
libxl_domain_build_info. Shall I?
[1] 
https://lore.kernel.org/xen-devel/093bc1d5-bf6a-da0a-78b5-7a8dd471a063@gmail.com/


-- 
Regards,

Oleksandr Tyshchenko



From xen-devel-bounces@lists.xenproject.org Thu Oct 07 12:43:24 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Oct 2021 12:43:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.203538.358671 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYSk3-0006rV-Cu; Thu, 07 Oct 2021 12:43:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 203538.358671; Thu, 07 Oct 2021 12:43:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYSk3-0006rO-9F; Thu, 07 Oct 2021 12:43:19 +0000
Received: by outflank-mailman (input) for mailman id 203538;
 Thu, 07 Oct 2021 12:43:18 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=qfpx=O3=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mYSk2-0006rI-4G
 for xen-devel@lists.xenproject.org; Thu, 07 Oct 2021 12:43:18 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id f840d157-8c08-49ae-9a12-acac68b9cd35;
 Thu, 07 Oct 2021 12:43:17 +0000 (UTC)
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur01lp2050.outbound.protection.outlook.com [104.47.2.50]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-23-g012MywgMj2eNly-IK6uWg-1; Thu, 07 Oct 2021 14:43:14 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB5166.eurprd04.prod.outlook.com (2603:10a6:803:53::33)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.22; Thu, 7 Oct
 2021 12:43:10 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4587.020; Thu, 7 Oct 2021
 12:43:10 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS8PR04CA0020.eurprd04.prod.outlook.com (2603:10a6:20b:310::25) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18 via Frontend
 Transport; Thu, 7 Oct 2021 12:43:09 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f840d157-8c08-49ae-9a12-acac68b9cd35
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1633610595;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=ads2pLpEmPIshtguItxijndEtuL6sIznRl/P3HMXu0M=;
	b=Eja6GmXw8bXJhnpxfywpQVULB8j2u5hhnFN99dECDRCzlgDB4ge4q6rIx2qgb8eYW9oexn
	cIO+/8fL1YZO8/cywkDXIWc2j9fPwdtwU2rW1yX1SSwsjgQkeMlQQHLvtZwnIpaEUbJtoB
	ppOWtnMxbixbbWMV41wweLum3K7Zq+k=
X-MC-Unique: g012MywgMj2eNly-IK6uWg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=cJdq3aTAqJQDaCp9ng1KJifpJEVPf7V//AdWapPYiyDN03vXKrrgjw66riDnh5sxfvg1TKNxKiozmZBTZrsHOLPXMp9N4wx7fby+waKby92YQdizDarLNfzU8EkT0Ap4ZoU8QypVC8liA+KRFbHohwS29ur4lGXrKfZhuhGWxEOSG999+P2rNQwT4bRsYNnaKxKnihtLaTtwz2KVcuNF9wU3bq8KdZY35FzW1DtVygnZNfLvWLDYnoqRc9zgirspGG53B1ROzPWYnXT5pqxQM0+jor5lEZlU064L+gZmAyZyucHjWWZCBNIGcIujucJLMAiLKzhpboWRZ98e/ik+OA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ads2pLpEmPIshtguItxijndEtuL6sIznRl/P3HMXu0M=;
 b=XZJcWXppwLFtO/s/EL5uv7O+R5IL8HG1UThFhKuw/TppuP5Lg84POT+VzNDpNmSdDXSVCAuGCana6HcZNzjJBH+3EFNpzEI2SwFWPyoLUiEy5v2dkA1VGGTZJT4hW8y4cveD6jOEn8IdBirA11TyUNclraG5HezL9rO/luT5NoRjF/dALdC+oTNhaArLtRlTYu4R9OIB6cpLdgxUXC/eIeHYNUT8uQYgKZtsobTvfoeJ2V0dHBi5lBOQoxYRdg02nOFq05WhpP7IRbQuXin4OTm6GOpcXvfAodxhFuFpMUz0MxA7/D7SG787QyGjJzTlEBLMS0Oz4H9VyOv9vCaw2A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [PATCH V5 1/3] xen/arm: Introduce gpaddr_bits field to struct
 xen_arch_domainconfig
To: Oleksandr <olekstysh@gmail.com>
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>,
 Anthony PERARD <anthony.perard@citrix.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Juergen Gross
 <jgross@suse.com>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 xen-devel@lists.xenproject.org
References: <1633519346-3686-1-git-send-email-olekstysh@gmail.com>
 <1633519346-3686-2-git-send-email-olekstysh@gmail.com>
 <68cb29bb-7d84-dc27-eead-4a079b9caf68@suse.com>
 <e77eea6f-163d-0920-2e90-fb9f3a602743@gmail.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <ffb40f3b-2394-7747-2c06-955e2aa87cfc@suse.com>
Date: Thu, 7 Oct 2021 14:43:08 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <e77eea6f-163d-0920-2e90-fb9f3a602743@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8PR04CA0020.eurprd04.prod.outlook.com
 (2603:10a6:20b:310::25) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 48c018b5-0ff9-4e09-02d7-08d98990053e
X-MS-TrafficTypeDiagnostic: VI1PR04MB5166:
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB5166B32ECEB2F644985BD014B3B19@VI1PR04MB5166.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	eJbik7Uj2nxGCtbHA+WQUQakjZMhJfn2Dtw/eMcRvL7QBIwcW+VFGzfsTk89jb10NHD7IeW+YvgbqavVLCqFMWgNaeaT9LIP8oCaYnYYEJ9pdgQ1nPzUGo1oefIRbbpjQ8Z9PFVgEe7DUaJi50Txkab7rT28rjc7D5bLTDG+qwMwJ2j/tl86acqvFBitlxziDyI+wFE5IdcaxawV7HYbr4A9ItaQy2HoyrSFCTakrcePNyZrUZwWB4euqxJ+4NOjEu+QzyJz+n39N/YiJhEHYCh1yibOIH+ci7rgdEfgsA5C+9RV79rat1qTDxQMqpiwk/nXVHtPHY4/KhDH+T91NdUlMlA4h1xDWUOLbeNuz5G7RmF21k+Z7Cluclb3R3SjuCWW8ZJSIJOK93VRqiWYBbBFeCQK1ZYFdzmp+ZHNzPyi37xIyuqzlyEyqpQFW0V55dsl0TL/5lx22sPWgk+d3VgdE7whOJxfmVNNyRcGmq94fvgkNVD+MLXpELcewbdRgrp2t1z8VTsVhwxeiP7+IdCCoOP0jGxOt/VHc6z/JN3qSM8JrdmVOidOtZVz9bkZ+9XJE8saRkt4rHyj7TtyBXfCfSQtDJwSD7VOU93zHx2u6HN6ZnYExp6mPmxn/BjFh+g3/rwVDruf09whcoEUx+nBM5evjOD3GU95MrUmWBjYg8YZ1OSPqDjFa5p4KXdvYoePrG4smeC2yqhOYUa+7jqzQatjHHGRWRIzhe1Fnni5E3lDTT+1aAFn0Eyqnu7v0j/h6lV6On6LRkB6E0Dq+tjx8kOyMMmvQtVOaMMIpMIgiTrcD8AfVPKd7A/C2aiPZI6R045AlQiR0RXqnwC+cQ==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(956004)(31686004)(2616005)(316002)(16576012)(966005)(8936002)(66946007)(31696002)(2906002)(5660300002)(6916009)(86362001)(508600001)(54906003)(38100700002)(26005)(186003)(83380400001)(36756003)(53546011)(6486002)(66476007)(8676002)(66556008)(4326008)(7416002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?TUdrZTMybk5qb09obHl4Q3NUZjEvY1Z4MmlpWTh5eXZUTDlRZjRwZFJzZU0z?=
 =?utf-8?B?N3RaczBXeCs4VWMwQ2djcVh5a2tLZUtHZmFGelZ2R0w2eTRUK1Zmak13d212?=
 =?utf-8?B?dU1yRHNIa0JOWk9vTTF2MzVUNHdrOERpa29OUnpSY3pwWmFoakhFWHlTenpp?=
 =?utf-8?B?NldEdnh2Y0w3T25hZmI5dkUxZXlJdnFYSnlvajhFVnhVblRBemJPZE5uckQ2?=
 =?utf-8?B?Q29uVTIrOUpTS28vdkVGZmZXUnlOZVZxVGJJdFg2d3pwZFh3S2gxcHZFZEVB?=
 =?utf-8?B?czZhTDZZTVVPaVVhT3E4czV1ZW9udG1UZkt2OEtGVjJTTHhmSlZzbWMrMS8w?=
 =?utf-8?B?V2dwcTlNS1NGRGJRckZqMGt2dVpVZStCNzNSRUFtVEF5SUNhQi80dEthT2pY?=
 =?utf-8?B?bGs2SmViL0h0QStWdjJnekp6ejY4azRQLys3cEpWUjNnZkpOcUZQT3RnTVBM?=
 =?utf-8?B?Vjd5OVBER1IzYWIyeWFTdzBPeTV6b0p4S2dYV2NET20yWFJKbUtvWjNseU40?=
 =?utf-8?B?RS9TSkY4U3N4NVNTYmJqSmw1ZkxhU3BDMHR4aGRLcXM4TDNKL3dKdDJBU05K?=
 =?utf-8?B?U0NWUGtUL2o3N0h4U25nd2FLL0UzSGJIb21zZjRyMEVlSmtuTGFGN3N2NnEx?=
 =?utf-8?B?V3l3MXVtMnlMV2JkQVJ3QVhjNjAzaWVqNnJwbFRNWnkvOFBrQ2huelhsdmhm?=
 =?utf-8?B?VlRiTHg4NEhIYTViQzRkNXVYelRENit4YU1mVzdRSDRxcDR2Z001d0FtSlh3?=
 =?utf-8?B?WEJCZlhXN3dQTnZWNk9YUDhLN005WHNuUU5tSVZJZXh4VmoxSjlPVDJPTkpB?=
 =?utf-8?B?bFJlYUZJQVBISkhPMzhKV3NEbmtrWVFORU5ab3Z3QWVFbTdyVHYxeXRpWmds?=
 =?utf-8?B?M0pTMGcyMGRuSE9qM3pkU0grL21IZ01hRWRVU25EMSthczFxWWlFaTZxVUJZ?=
 =?utf-8?B?R3MxdVh3QXRBMmJhWURaZ0xmSFB6c1JicXMvY3FHaGR0RzdLK1BnR0hsWmZV?=
 =?utf-8?B?bUdSZHZobDBpbzhEV3JlR2ZzL2lqczI3VVZXQTF4bU1mTXRtVUVzODlYc1o2?=
 =?utf-8?B?YWpRc2x4NnR5dmxxemNQVHlBbjRQOVhCVlZDaEJZb2swTzlLbVB1U3N0M0xB?=
 =?utf-8?B?VHB4c2N6UnBGa09SbkdvOWJXbzhRdDREdkJCaWI3eDJwZ29uMnlrdmc3TmRs?=
 =?utf-8?B?SFpNRlZhRm1BY3pYSGxJb2IwKzN6WDVEUU5wb0NEanpaRllLZVFDK2hRbjlz?=
 =?utf-8?B?WHl6QTVBR3hOOUllS2pKUEpUeHJrYVc3TjRJdk5WRE5uMUZGaDdjL2NLT2lK?=
 =?utf-8?B?c0tweDhXcm1TNzBhaTUrZVM4MHZxUVlzNW9UZDJlaFpuN1cwVlZ6R0RzR2l0?=
 =?utf-8?B?WDdkUTRqd2hqMnZZV1QwVVVKNGl4cXFjb1hNdGtTSkNUR1hZR0JHYmZxVjdU?=
 =?utf-8?B?cHVhT1NETUQyZlJPcmF4bFVFUWgvaTA3NVM0cGtKZzZxSTVEV2VWTTl1SE8w?=
 =?utf-8?B?QUdwNEtUQ1o5Q0EwTEk5ajJGS1dGaUV5SDFvVFZ5YjVLL01RN2JiWi9JUG1s?=
 =?utf-8?B?VldkTFRkWWRkLy91MFNOUU9LUThrWTZDbzNYNGFCbFRSdXlJRlNFMmJuYnpl?=
 =?utf-8?B?dXJ5c25ubm5MTFBXbkE1Ymh5MTJWWGtMa0pTa3RIdFR0REppZjlYclA3dy9q?=
 =?utf-8?B?bCthZTNyaUNwcTJNVW5aQThRQUdXVHE3SjJaZVhiYmRRanBmY0RYL1VnajJz?=
 =?utf-8?Q?vYTrbBDxfFgXjCXZClGgC0IaEL77KQX7HfRSGhm?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 48c018b5-0ff9-4e09-02d7-08d98990053e
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Oct 2021 12:43:10.7900
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ifnR+VQ2gVtJ2lHCaXs+QGjoCSul+kadCgUhs8FNz4ULTTow38J+6rq+rRdbxbqqk/TarRdTXzXvotT9fTkkYQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5166

On 07.10.2021 14:30, Oleksandr wrote:
> On 07.10.21 10:42, Jan Beulich wrote:
>> On 06.10.2021 13:22, Oleksandr Tyshchenko wrote:
>>> Changes V4 -> V5:
>>>     - update patch subject and description
>>>     - drop Michal's R-b
>>>     - pass gpaddr_bits via createdomain domctl
>>>       (struct xen_arch_domainconfig)
>> I'm afraid I can't bring this in line with ...
>>
>>> --- a/xen/include/public/arch-arm.h
>>> +++ b/xen/include/public/arch-arm.h
>>> @@ -333,6 +333,11 @@ struct xen_arch_domainconfig {
>>>        *
>>>        */
>>>       uint32_t clock_frequency;
>>> +    /*
>>> +     * OUT
>>> +     * Guest physical address space size
>>> +     */
>>> +    uint8_t gpaddr_bits;
>> ... this being an OUT field. Is this really what Andrew had asked for?
>> I would have expected the entire struct to be IN (and the comment at
>> the top of the containing struct in public/domctl.h also suggests so,
>> i.e. your new field renders that comment stale). gic_version being
>> IN/OUT is already somewhat in conflict ...
> I am sorry but I'm totally confused now, we want the Xen to provide 
> gpaddr_bits to the toolstack, but not the other way around.
> As I understand the main ask was to switch to domctl for which I wanted 
> to get some clarification on how it would look like... Well, this patch 
> switches to use
> domctl, and I think exactly as it was suggested at [1] in case if a 
> common one is a difficult to achieve. I have to admit, I felt it was 
> indeed difficult to achieve.

Sadly the mail you reference isn't the one I was referring to. It's not
even from Andrew. Unfortunately I also can't seem to be able to locate
this, i.e. I'm now wondering whether this was under a different subject.
Julien, in any event, confirmed in a recent reply on this thread that
there was such a mail (otherwise I would have started wondering whether
the request was made on irc). In any case it is _that_ mail that would
need going through again.

> I thought that a comment for struct xen_domctl_createdomain in 
> public/domctl.h was rather related to the struct fields described in the 
> public header than to the arch sub-struct internals described elsewhere. 
> But if my assumption is incorrect, then yes the comment got stale and 
> probably not by changes in current patch, but after adding 
> clock_frequency field (OUT). If so we can add a comment on top of arch 
> field clarifying that internal fields *might* be OUT.
> 
> 
>> One of the problems with
>> _any_ of the fields being OUT is that then it is unclear how the output
>> is intended to be propagated to consumers other than the entity
>> creating the domain.
> If I *properly* understood your concern, we could hide that field in 
> struct libxl__domain_build_state and not expose it to struct 
> libxl_domain_build_info. Shall I?

I'm afraid I'm lost: I didn't talk about the tool stack at all. While
"consumer" generally means the tool stack, the remark was of more
abstract nature.

Jan

> [1] 
> https://lore.kernel.org/xen-devel/093bc1d5-bf6a-da0a-78b5-7a8dd471a063@gmail.com/
> 
> 



From xen-devel-bounces@lists.xenproject.org Thu Oct 07 12:58:32 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Oct 2021 12:58:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.203547.358682 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYSyg-000085-Na; Thu, 07 Oct 2021 12:58:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 203547.358682; Thu, 07 Oct 2021 12:58:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYSyg-00007y-JX; Thu, 07 Oct 2021 12:58:26 +0000
Received: by outflank-mailman (input) for mailman id 203547;
 Thu, 07 Oct 2021 12:58:25 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=qfpx=O3=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mYSyf-00007q-2T
 for xen-devel@lists.xenproject.org; Thu, 07 Oct 2021 12:58:25 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 40fc2e20-276e-11ec-bfd1-12813bfff9fa;
 Thu, 07 Oct 2021 12:58:23 +0000 (UTC)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2174.outbound.protection.outlook.com [104.47.17.174])
 (Using TLS) by relay.mimecast.com with ESMTP id
 de-mta-29-2GqadKHVP06ZjfzmzFUTVw-1; Thu, 07 Oct 2021 14:58:21 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB3119.eurprd04.prod.outlook.com (2603:10a6:802:10::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18; Thu, 7 Oct
 2021 12:58:20 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4587.020; Thu, 7 Oct 2021
 12:58:20 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6P194CA0019.EURP194.PROD.OUTLOOK.COM (2603:10a6:209:90::32) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4566.14 via Frontend Transport; Thu, 7 Oct 2021 12:58:19 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 40fc2e20-276e-11ec-bfd1-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1633611503;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=wjpHCtqK0Ax0GEWu4x1GsK7W7ug1H1ZupZ6k1MECHEs=;
	b=luGMypkShjiO5zPrpvx+LimxCM+k9JQvnN5J24Ftru8WGBcIhZ35Mf4knDNpiOiTtDJ0RB
	wo9jmRNxhMRgCBWkn7tlTR9xNwHmlMbA1HJ4jV+bjW8ajDyo/yzSvSmWo6mu9dRQXvAsWY
	z7xAxmk+4VHaJzhrFKUXQividZDAJtg=
X-MC-Unique: 2GqadKHVP06ZjfzmzFUTVw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=XicJMTtCNMW8aUTDuyl2jss266HdGu1JLdxo5LcRjLEEZLxov67DGgNkZSEdfn/XG74yzPz5cBbQe0P+PO7h0ys5yCreHR3KiIU4SRrTKEAcB+01NOIEtvWwyJoNw/wmb6dMvomScEHwAsdXHC+SrfWUXFSyeZoQ+UYiaiOgKbrXByJ1DvHOz0ydyk28U8AV2Sl1y9iETLQGxlh9KUNWOEfiG1Z5rvN5Q6AGHu7l2XI30wsqb/UdComL47NfzKPq8gpNfF8656VUoKi4BnC46zO59H2ib6eBgyPjYNL8BgfCJc/zXurbxRgw/ou8LBR4OKTRXq+qkWH4HAC1QaE2zQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=wjpHCtqK0Ax0GEWu4x1GsK7W7ug1H1ZupZ6k1MECHEs=;
 b=QYMoV/FpaPUVXugdxGvewVCDcAnsFTGxUuRSq8omTjUDxXnuYCyj585Mmo46OJUgWcAMk86FimWNtbsXY/zXJ7aq3Dw6vzmVN/70XtWSVxKR8N0dTU839KLa/SL6gxe4ERENO6aY+EBex0uaYXLQ9ZzCcw1KunknXr9jaQeD2ZQvejtPQ3/b2VU5prN6M5OLbJSkHQakTZItPMBzfmQWH33BRFZwcfhB4/grdi7mmX8n9uX/iIYHXJ5mbYiHH0QQHZ76FNcve+Ys+Z0BnuE/mj7bWqnP5LSBJdbTxTkjh6LU5QaZWGAtet3zgFHrON832UJ19dgLWIRS3iVASh2wwA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: citrix.com; dkim=none (message not signed)
 header.d=none;citrix.com; dmarc=none action=none header.from=suse.com;
Subject: Re: [PATCH v5 02/11] xen/arm: Add PHYSDEVOP_pci_device_(*add/remove)
 support for ARM
To: Stefano Stabellini <sstabellini@kernel.org>,
 Rahul Singh <rahul.singh@arm.com>
Cc: xen-devel@lists.xenproject.org, bertrand.marquis@arm.com,
 Andre.Przywara@arm.com, Julien Grall <julien@xen.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Wei Liu <wl@xen.org>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <cover.1633540842.git.rahul.singh@arm.com>
 <0dc4423b2e20c1eb40c961b211b18ed041f707b7.1633540842.git.rahul.singh@arm.com>
 <alpine.DEB.2.21.2110061704280.3209@sstabellini-ThinkPad-T480s>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <0cc5a3a1-e31d-a6e4-9bc7-3f2db5144b4e@suse.com>
Date: Thu, 7 Oct 2021 14:58:17 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <alpine.DEB.2.21.2110061704280.3209@sstabellini-ThinkPad-T480s>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P194CA0019.EURP194.PROD.OUTLOOK.COM
 (2603:10a6:209:90::32) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 21b7d3d4-1419-45f3-53d7-08d989922341
X-MS-TrafficTypeDiagnostic: VI1PR04MB3119:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB3119509720CD06531F24DA7DB3B19@VI1PR04MB3119.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6108;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	cAjS6Q6gZOgAoRYT12oGjrORf1h62yMm2ox+m1SbCyihicPXpwNdHHxZiHojYzWDk8kazXsAG+2M4C8Cq3ujh8tsVgMDUe3o2VsGPQoq2H7z8SFjKS/CKmUdz0Yy70ps8/d6FH+xvFVjjIm1jfkVQG1wMRGLkO4Xt+JNg4yBK7+FEEFVRwojz+jQW2m8YyT+PdpJ4qHjH0r6JCIuXmTh5JHBJ3xW0rnHc+YyG0gmpf1YJ5chkXpVqjneJ347EKOHJtQn+3coJvtyVc8hLGW0HMTFMR3pZq8QJrqZAMDqFGYz+um+bkTF+6bfCFPkw170rzdYisLulclYLK9ZELtmzqoVXraggP/aViNn0d/ymYAI17TudFgRqVarXMnvZQRU5HsmgdJMP12Qq4o/R3/tqM2zE/daVnkRCzGHJrQOt2d0LY24tmzrwFPCKmXfPZP+BQ5qJOF5KS/feJx6eyizwe8l4dMIiGCo+hOF9YjFgS2XesWqzcjnalw3Af4bhVYeJ+Z6evhzZGvU3kNHwpYNhIfe669Pj1pZ2GlcfHTfu9UVLZtX/5B6aL4eHVszzSc/O2qZS+ivE/EX37sEKhnT5y4artTyhQf/QWZZcyfA9WDBl1uDMxhj77IwoG8aO0tV0+Qtwk1SPDtEkpcf5AgZttFFD4Jp48DyM5TEjh4shTybT1vB97qV3oHt3TrNY/9bbKfRwhKgOojOD4EuuAkxaKy6ypLs4pvfXvX2csPO6hg+Ie2h7LXmJh5xn6ocXOwR
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(508600001)(4326008)(31696002)(2906002)(26005)(54906003)(5660300002)(186003)(4744005)(110136005)(86362001)(8676002)(16576012)(8936002)(316002)(53546011)(66476007)(36756003)(956004)(38100700002)(6486002)(7416002)(31686004)(66946007)(66556008)(2616005)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?SWZSODhFMzVKZ2p4amNFUSthQVFhRDNpeTZXd2h4TmpiUXQwY0VSMG9IdFNR?=
 =?utf-8?B?aGRISmloVVM4c0doVkI2SHdQUWxyeWRJS1hkVktsd2tCUXZLTEVmOWZkZStT?=
 =?utf-8?B?YTBnc0RnZlljUHZUQ2p1dDd2RFlPcTlsMi9LWTBzQjZ0cFBMdzR3dzdZRStY?=
 =?utf-8?B?dmtKNnh0MlFBOE1XOGJQZ0Y3WFlaWDZyZGttTk9iaEZ4T21mR3BxeGN4d2FV?=
 =?utf-8?B?Nk1tcFlOVkh0dnA3akI3ZzkzQTFUdVVIVDJtZjdMSGJtRm5BME03UFoxNXEr?=
 =?utf-8?B?MWtzZVFwa0Z4MTdoMzBTV0QwNGRSMTc5RWp6bG5yTVpIWnY0TlhjU1lNK1hF?=
 =?utf-8?B?WnI0eEpVMXpwZ1k0a0JEVjkyRWJnenJ4V1lpci9sOFI4SDNpWHVlRHV3Wkd5?=
 =?utf-8?B?V3hjRHRhOHgwSGxDbWRFdnNjbjJUM25JNmRiY2NiTUdKNCtyK2Y1dW1vMHZ5?=
 =?utf-8?B?NEhWRDJDeVFpWGhkeG9YM0hLM1QzdFdNQW9UdXVjeEErbTJ2M2U0UHRXR2pG?=
 =?utf-8?B?UGM1bGxzcFVFM3V6dHhvL0VQbWdVNTF3ZS9UaFpDRk84K3pJbUVJVXZvaUxB?=
 =?utf-8?B?dlJKTGdpTkEvM0YwdHE3U1JiZTJ4MlJuMEdHRlRkVGdSRzA5Zkxvd2NnY2NY?=
 =?utf-8?B?aTNRUEVpQXVnbDZza1puc3NWemRkdldrN3VHQ0ZKWXcwclFUS1BuTUdNTDhr?=
 =?utf-8?B?SXYyd1lKZDdWVDVLR1QzNHNYNFE2OFgxbGgrbm45S2lUV0N3dHdiY3lLenRQ?=
 =?utf-8?B?c0F2ZWdadFZyTG96MExEbDBZZy9oMzkrNnBGVHo0Z1o2NHpnekZpYnRldGU4?=
 =?utf-8?B?TDIzVEpRQkN1RXNvaStLcDNPUXB4T2U1ak44T0hESkoyUkxpK0g5NmpPcW84?=
 =?utf-8?B?YS9jY1d4Y20zbk5tYlpHVlpjTi9hdFpqYVBzTDcvMytpeFZVZ0MrZVdNMUhs?=
 =?utf-8?B?NWQvaXh0cTBqQUhUTVNETXQ4MWduNmFUQkliT2ZkZ01JZWQ3Y1VndlZwZmtV?=
 =?utf-8?B?OSt4aEJRM3kwV0ZOL05nb0orQmk4TmdaVWNZU2JTckwzcHcwdU5WOStNU1dH?=
 =?utf-8?B?Sjl2SnJrVHNsZmEvazMyRTgzeWhPOHhvU0tIZkh2UE9sWnNBNlpRMTZVWGxW?=
 =?utf-8?B?WnIzeFJKZWpHMEZZcUo0Sm5PZFRURVNlTEpmcXFYa2ZpdGltT09GM0FHUW9G?=
 =?utf-8?B?RGJ5K1FuUkIzZkYzbDY2L0swY3Z1b1Y0aHVqODRVaGpWZHNSdDIzR3lTZVcv?=
 =?utf-8?B?eWgvYXlFSE5Hbk5kMENBMUJScVhtQWdZaG1SMEliVFJPMGV1cUVWVGlDeHhQ?=
 =?utf-8?B?bVFKOXlucEh1U205WDEwYU1ta3MrdldtMExzNkM4OVR3QlkzUzJ0TDU5WUd1?=
 =?utf-8?B?ek5WUWVBeERsd0QrSWdsSUJLQndCSHJOUzdIV1VuVU9rcnY5aTR3ZDExbmsx?=
 =?utf-8?B?eXFsV1kwQlFwQUVSVC8vNzJ4Qzl0ZXdVUU92ZjRKcjJDZmcyclZpL3F0cThs?=
 =?utf-8?B?M3BudXBOYWVLWmNKcFNRL1BmV2tqVkhzYitmeE9YUk53OC9WNHAzMUx4ei9w?=
 =?utf-8?B?QnAyZ2U0bERIbnA3OERzaXVCMG5NSzNicXhWQW04eVZhRlNUZnV5YUNQWHNy?=
 =?utf-8?B?czdpM3ZzUEcyWUZENFZzNHlZTWJjUlRmV3FVYVg3bnlZUldJTWwrOTViRWht?=
 =?utf-8?B?VHpad3AvbkgzSEJLWWs3L1dXRWxvK3VSa0ovUTBsOG9ESEs3OG5uSkRJYms3?=
 =?utf-8?Q?tj1eh1vE9QiKwhuTTdXAkQIOhsPDOaXYNzjjHGo?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 21b7d3d4-1419-45f3-53d7-08d989922341
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Oct 2021 12:58:20.0389
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: mPy57LY5DMmLoJxh8HkYGOz0MqogEndZvzHP+vaCPbol0HippuzBUyT1v/PgRViTt/jYt2zEf6LLWLBYMiZFKA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB3119

On 07.10.2021 02:05, Stefano Stabellini wrote:
> On Wed, 6 Oct 2021, Rahul Singh wrote:
>> Hardware domain is in charge of doing the PCI enumeration and will
>> discover the PCI devices and then will communicate to XEN via hyper
>> call PHYSDEVOP_pci_device_add(..) to add the PCI devices in XEN.
>>
>> Also implement PHYSDEVOP_pci_device_remove(..) to remove the PCI device.
>>
>> As most of the code for PHYSDEVOP_pci_device_* is the same between x86
>> and ARM, move the code to a common file to avoid duplication.
>>
>> There are other PHYSDEVOP_pci_device_* operations to add PCI devices.
>> Currently implemented PHYSDEVOP_pci_device_remove(..) and
>> PHYSDEVOP_pci_device_add(..) only as those are minimum required to
>> support PCI passthrough on ARM.
>>
>> Signed-off-by: Rahul Singh <rahul.singh@arm.com>
> 
> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>

Acked-by: Jan Beulich <jbeulich@suse.com>



From xen-devel-bounces@lists.xenproject.org Thu Oct 07 12:59:45 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Oct 2021 12:59:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.203556.358693 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYSzx-0000p6-5J; Thu, 07 Oct 2021 12:59:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 203556.358693; Thu, 07 Oct 2021 12:59:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYSzx-0000oz-24; Thu, 07 Oct 2021 12:59:45 +0000
Received: by outflank-mailman (input) for mailman id 203556;
 Thu, 07 Oct 2021 12:59:44 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=qfpx=O3=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mYSzw-0000oq-5S
 for xen-devel@lists.xenproject.org; Thu, 07 Oct 2021 12:59:44 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id dfef1abe-aac7-4ba0-9fa2-898daffdc08c;
 Thu, 07 Oct 2021 12:59:43 +0000 (UTC)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2171.outbound.protection.outlook.com [104.47.17.171])
 (Using TLS) by relay.mimecast.com with ESMTP id
 de-mta-37-sBjaWvp8NbCiarQhRNOtHA-1; Thu, 07 Oct 2021 14:59:34 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB3119.eurprd04.prod.outlook.com (2603:10a6:802:10::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18; Thu, 7 Oct
 2021 12:59:32 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4587.020; Thu, 7 Oct 2021
 12:59:32 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS8PR04CA0152.eurprd04.prod.outlook.com (2603:10a6:20b:331::7) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4566.19 via Frontend Transport; Thu, 7 Oct 2021 12:59:31 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: dfef1abe-aac7-4ba0-9fa2-898daffdc08c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1633611582;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=5BK+/dEZF47hh6M6yP/qjvxQtUd3lmj2uaxkYYAvL1A=;
	b=E03DV2QkLgKRjMNmNLjBkRrNdflMf7GfppGmDw16e3yjRSkRdM52xvHs6Pa7zVN6EDO/II
	hPRpZJqfyE5NihB0VhWRimzO4ADieDVoJeKmoiJEa31CKgbaW/3IetIM8oacaXa/tqRUBM
	Jj1MBkWcpSgYqw3FE8P8Bhsa64PToqQ=
X-MC-Unique: sBjaWvp8NbCiarQhRNOtHA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=BPwvgFF6oSEnMelVaQs1HyiTo7ecwLTbRWT5LXLL9RjzaHoOo6j51KMgidTzUMU0v/PKzZRywUBky2ltO9qiMzmRvPwCF9yVeA0xA9zB/u2/4BjhEwdYo5DBLXxTdff796JQZQub1noJKsdZVXgoTLF45fPEPs/a4MWqMlHI4XRd5ENLTkp2+d/MTnnJsW67ye/uM0HvstYKcZ4CzWMRUbY4x+c8PPBURNHDLOBypQGV+270Kzit4dE8uBFdbvcQVaDbZad87fcFWPCIYjyUXO4i5nTwGMOqOihzGXM6ce5B1NT+md/qHdeqmokVybbFn2kGM4wkBZTrSaRKf09ozg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=5BK+/dEZF47hh6M6yP/qjvxQtUd3lmj2uaxkYYAvL1A=;
 b=UfyzYyQw92CC2drMgQQ6/qWBnvo8l7GiOTmm/ioi3er2fWR7PGrxrp/ttWVmhiC52G5kEa6Ck7RMp79pYTnn8dRHD9Yqoq8RXxJvSlXqyH2ZHJZtICEdANW16RasVr0ILDZm4sE5HtlKcHOnoJNblnuiCXiPpxWEdoMHVwX8MxCoyTtCLuWH4jvwq6eNzEwLJlGMSAn6zCvCc5eeGgOa3h4xQ4KIv9fPHfztKC+n8tamv65dVtfXCMNtZb4OWaA81bkD5p8W3lFtmunAjViAz2FBD3QW4iJIiXx7yEPrHKYJO7VHCAocgejKhtTY3ErZ2jPMIaE8JhbHecfL4NDouw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [PATCH v5 03/11] xen/arm: Add cmdline boot option
 "pci-passthrough = <boolean>"
To: Rahul Singh <rahul.singh@arm.com>
Cc: bertrand.marquis@arm.com, Andre.Przywara@arm.com,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 xen-devel@lists.xenproject.org
References: <cover.1633540842.git.rahul.singh@arm.com>
 <e7d91ded71816d07f559b98027e5be1ff172dcab.1633540842.git.rahul.singh@arm.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <08e3b378-2c18-6103-477f-18eb5a096c6e@suse.com>
Date: Thu, 7 Oct 2021 14:59:30 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <e7d91ded71816d07f559b98027e5be1ff172dcab.1633540842.git.rahul.singh@arm.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8PR04CA0152.eurprd04.prod.outlook.com
 (2603:10a6:20b:331::7) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 25d2b190-558d-4377-d043-08d989924e90
X-MS-TrafficTypeDiagnostic: VI1PR04MB3119:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB31195D1AF74F0C33A8F745DDB3B19@VI1PR04MB3119.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:1079;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	rG286zt3IRLqb/YU3/hDxH4A56OCsOLrI1k1RaHHjb2mBCL6MVT8cblRX3yfGz+cxXCtpFvxiH9jHvo6t1CmFEwkuuuG4KIHzW44zeED3JKpNYnm7Vgjug6nFYIeuZ1YYDOQmYBkiUiodMxOLDQJABAt8Yl/NzpAdfX9B/CjjjruhwlAkXmKHvAH2VXJtFuXo0zshnb71mFhRCzzxJc7lT+/gZ2LAhdxMJWPX3GohJGa0ga8LLGhkYbjG9DwPIKzreXYTZR2PFGvw4LIyVD2e0RZjDCAxrhLu11ZUQGv7F6PPwopwZN5Ai32zeuWZ8bCiglIuDpfr+1a5+JFnehFRjm/naOQV66V3hgwEm/nbubKzwAyVJZ5LOcXq5YTJ6rwmzm67pvFA24/TjhafHodV/9ytOPIS4xjiHQu/ln5UwoFaT0POjjhcwHxt+e8uOce8pW35kK+NQzpwKklD16FzjurmJWQ8lV+WRENefAgVUXMELYZEhGaR2pxiQqUBGK4JyjTpL5Id5OANykv/c2ofALYV9N2gyXmnErhMIz84te83Lpng3EDEcVDmfnDxBbxr8Wd3hcPu51z89sRZEvR6XuvRXgANrDTQ6MtVUcr1+09m9CbATNl0Ll5zpdrHE310EmtYbEBP5G2nLeN5SpG0RIU3hK0eSL4WksP89Ww/BK3RajMTym0I1r/631h11OrgtGG4tdbHuEuBKZKjpBtM25jJUpvHlUWXFeWgif8ysVUdThMzQsF/vAVk1HKyHGg
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(508600001)(4326008)(31696002)(2906002)(26005)(54906003)(5660300002)(186003)(4744005)(86362001)(8676002)(16576012)(8936002)(316002)(53546011)(66476007)(36756003)(956004)(38100700002)(6486002)(7416002)(31686004)(66946007)(6916009)(66556008)(2616005)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?RG8zdE1oL0xhUkZTZDRtR1ZHYml0NTE5WW1aVEZ5UVh6aDYrQmZWcXJKRmNo?=
 =?utf-8?B?TXB0TFhSelNjSVdZMTE5OVVUZ1ArbHQvSmhkQmlQV0JTdFpJZXVaQmFreTRD?=
 =?utf-8?B?SXdBY1F5R3d6RXg1SklZcmdpaDNySFZSR09oUml6QUNUZ1ZWSzRDTTFRTjU3?=
 =?utf-8?B?V1Y1NVFPRDU5U0p0YlFxUTZ0WXNmMFRFRm9iNXR2ZTlZaStKUFZhNHZ5Y3FY?=
 =?utf-8?B?MHlOb21GeUtFdjNJdGJPcElLbVJ2V2luTk9LVTRVZVdjYjJ1R2wwNHd2VjNW?=
 =?utf-8?B?QWwwa0RXQ1Y1T0Z2RmpFNVNobmNzWEMwbzNjZlFMQWg4UGRzUU4rS1F0dEdy?=
 =?utf-8?B?OW5UWFFzcXdTZGZBRktRcG5hRVZ6V3R1a1JvZnVFcEJ4c2RwNWU3ZG5ycTdS?=
 =?utf-8?B?c1ZXVHp5V05Kdm1DV1g1c2dnRGl0ZXFmdVNOU0JxZ0tsbG9PckhITDNVTTZl?=
 =?utf-8?B?bVFLREUrWWlJWW9GalprL1JlOUk2VjIrRWZ6OXQrME1hZmhsclhWM1A3WVk0?=
 =?utf-8?B?VzNyQ2hsdGtIemF0VFNlbWpPWXpFOVZyWHIzenJlaXpZQjBnLy81cUhKVGRv?=
 =?utf-8?B?SEp5QUg0RC9TN3hrWnkwQytVN3FJaVdRS1g2bTRlOXZNb2l0Qmw2bVZuUGFw?=
 =?utf-8?B?c0xqRWNBdVF6eWYvQkJoalJaYUptOWx4QUpiVlR2SWRKbFJFeTFiNlgwczBF?=
 =?utf-8?B?MHVhQjYyNk5Xc1hVUUtMb3VZa3RjdUhUdW5IdENuMjU1dm91VUtVTVhZbGxO?=
 =?utf-8?B?WWU1bW81QnM2OWNpWTgrSDAyNG8xK3lzNXpNSU9BVDFYTi8xNGY4TUh5UFJW?=
 =?utf-8?B?RCtidFFuRW5mS1hyTi9NbEtKd2FuRmU1cmFCbTNkd1NnRS9WVEJxS0FNbkxv?=
 =?utf-8?B?Qzc2TlZZUWtFYm5uNnZ0MytVWW51REpDWlBLYXBQbGJzWU9UVmRlbjFwU3k5?=
 =?utf-8?B?czFqOVhKNVZVV21nV2M0RGVDMkNoSzNiVGFKQ3JOcUgvS01ENjFwUkVibWFk?=
 =?utf-8?B?c2lpMDZxZEI4U2JScnRxdmV0bWNnTTBIUGk1OFJudFBOQ3E3b3NKbDF0NFI1?=
 =?utf-8?B?OWhSY1BtbDJOVFB4OFlnRGs0NFJzOVliNUZKeVBHckdVM1Y0ZnZodXpteWhp?=
 =?utf-8?B?ZmJMdnlSQ1hRK1FjNC8reWNBWXBPQ3ZtckdhQlNFUEhnUW5vbldDNkxMUXNW?=
 =?utf-8?B?d1ZMOEgrVThMdWJjUGdPRHlvUWFtK1NERHR4bFY2dXBTQmFSVUNxSC8wZzMx?=
 =?utf-8?B?ZDhKMS9aZWxITHRJZ1B0TnpXSXh1MUlYK0wrdGNmTDJwMnhjbjdleHJtbUxo?=
 =?utf-8?B?eHc2QlprMFFRb0JqOHFyTGFZTzZVeTJ6UVhMYlI1ZTV5S3VZY1N2b3BmdEFz?=
 =?utf-8?B?V3hDOS80a1B5cVYwdDhpZFBEZ2t3cTgrbkVPb0U1NjlidFR4TEU3M3FveWJ2?=
 =?utf-8?B?NzR3Q1JNYzk0NGhEVnphSG4zUEhUbHp4SHR5bkJNWXNOcFIxa3ZuYVYvcDQ2?=
 =?utf-8?B?L293bUFacXIzRGE4cUdNbGpWS2dBZUNEQm54ZHpCNndzdzY5STA4c3ZhcWtN?=
 =?utf-8?B?dHNNV2E1ekVyOExFY0hkQXhnVXBZS0JnUWlmbmdUQzlabDUrOHhpTTJudS82?=
 =?utf-8?B?MjVtdFhJZjRJWlZMWnhld3FLS2txRGRSeENYTEtwT2dKYVRZellrZTdad2l2?=
 =?utf-8?B?am5sRTllV2VVTE9QSms3SjFEdnhjS0I5UFFIV0ZKVkxaYlNKdTRJWFk3bGNx?=
 =?utf-8?Q?zk0a6yRYJBEw5EL6UW2Ba90Njm1low8omGZi9JL?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 25d2b190-558d-4377-d043-08d989924e90
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Oct 2021 12:59:32.7059
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: OZxFTCbCBT6+/8iLEg8H4fD7etbZ6aaeO8PxDN6VVZ06LXVj8VpDYC2oxnenrWEIjh1GWv07uprAiXSdOTECHw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB3119

On 06.10.2021 19:40, Rahul Singh wrote:
> Add cmdline boot option "pci-passthrough = = <boolean>" to enable or
> disable the PCI passthrough support on ARM.
> 
> Signed-off-by: Rahul Singh <rahul.singh@arm.com>
> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
> Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>

Acked-by: Jan Beulich <jbeulich@suse.com>



From xen-devel-bounces@lists.xenproject.org Thu Oct 07 13:08:35 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Oct 2021 13:08:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.203567.358704 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYT8P-0002Or-W1; Thu, 07 Oct 2021 13:08:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 203567.358704; Thu, 07 Oct 2021 13:08:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYT8P-0002Ok-Sy; Thu, 07 Oct 2021 13:08:29 +0000
Received: by outflank-mailman (input) for mailman id 203567;
 Thu, 07 Oct 2021 13:08:28 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=qfpx=O3=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mYT8O-0002Oe-9n
 for xen-devel@lists.xenproject.org; Thu, 07 Oct 2021 13:08:28 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 447bd0ac-3819-4b60-99bd-28a692c75522;
 Thu, 07 Oct 2021 13:08:27 +0000 (UTC)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2173.outbound.protection.outlook.com [104.47.17.173])
 (Using TLS) by relay.mimecast.com with ESMTP id
 de-mta-5-EKiRYr14PsqfOw6SDEgekw-1; Thu, 07 Oct 2021 15:08:25 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VE1PR04MB6479.eurprd04.prod.outlook.com (2603:10a6:803:11c::33)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.22; Thu, 7 Oct
 2021 13:08:23 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4587.020; Thu, 7 Oct 2021
 13:08:23 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS9PR06CA0351.eurprd06.prod.outlook.com (2603:10a6:20b:466::17) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.14 via Frontend
 Transport; Thu, 7 Oct 2021 13:08:22 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 447bd0ac-3819-4b60-99bd-28a692c75522
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1633612106;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=4cGeZN4m4w5ILM164lNqYQPwXRnKOQN03gFaf3Hb4wo=;
	b=ARHlIpL4PFu1rlsiO2dSL15GvDrN0w69bOzhLVqgh7aRSueEEwn82MXFT9vfYzt2evi21e
	XDLfZzpXY7VPaXHPMpfxhQxecfzuglWY8viLlENsaw8DJk2Wybd8rzTQl+h/1hjquMwy4S
	CdwK6CnGHZaXhui5mUCC9i7cr4pWrbY=
X-MC-Unique: EKiRYr14PsqfOw6SDEgekw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Yb/gwZYPWqAG8IEMDD5kkWI/Lk51VCW3njjXfit08phzJWwkMkeu2m423x3413KdVG+jzNFq4BeyoDDeOp/Lc2XbwNaLaUDHLRyj+uSgY6CxCOtCErae8gCKUPh9YFiSr90D2sEDou+zio+XUlWFSiVZ4OlxfduSxSbxmpxpfjZf7IuHptn9AGNIfokUmOpnzSMn9ySl/sC489qv9qsmEWl6L/OOgolKXsH6YZejZwBCP4kgu1SUslrsQyno1SDKQoKGHrDiaux+3mLljuePB8rsUislR/A8unNNGqAVGtgORhESOcLkuqbO8bKtW19VJ+rG82GIp0ZyW3mYhMpCVQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=4cGeZN4m4w5ILM164lNqYQPwXRnKOQN03gFaf3Hb4wo=;
 b=jWre/a1lFaPFEU1/VGHVHR2rsT13X5kmit1YGwVUUBbhNr2tdepJTvYxl8nGuFA94dj8S5TRtdszXEfzks1I7wQX6bHnZstjEmErA2mXE6EcREGYQEwXRqhlFqB4t+XtRpE6adQs7ak2wzmPbHw2QVDmx5uxn0OpsHgdjOmR8qk21NCd/hpBZnue21U6xT3Hr39cPqADV+CUKLL1grOJWX6ecNy7OM3BiUW8znzRkunxvvJhhcSmrnckQ6IWIqg/mcG+VqwJMplsMq2v8SOUAnkNcrTGPeLKfnrDuvwqcbQv3/mx2hpV06WqNSUmoo55HsHw/Oy+8tj4nVxgOzFu3g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [PATCH v5 07/11] xen/domctl: Introduce XEN_DOMCTL_CDF_vpci flag
To: Rahul Singh <rahul.singh@arm.com>
Cc: bertrand.marquis@arm.com, Andre.Przywara@arm.com,
 Christian Lindig <christian.lindig@citrix.com>, David Scott
 <dave@recoil.org>, Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 xen-devel@lists.xenproject.org
References: <cover.1633540842.git.rahul.singh@arm.com>
 <20d5b9d6a0d01a7b90711d28cbefb5701a88b438.1633540842.git.rahul.singh@arm.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <27489306-058e-aecf-a766-919c9569adce@suse.com>
Date: Thu, 7 Oct 2021 15:08:21 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <20d5b9d6a0d01a7b90711d28cbefb5701a88b438.1633540842.git.rahul.singh@arm.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0351.eurprd06.prod.outlook.com
 (2603:10a6:20b:466::17) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: ad86d77c-a75c-48d4-be5c-08d989938b19
X-MS-TrafficTypeDiagnostic: VE1PR04MB6479:
X-Microsoft-Antispam-PRVS:
	<VE1PR04MB6479CCDEBC89F2EACAAD5EC6B3B19@VE1PR04MB6479.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:4714;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	1OnO7WF0fwFQUXuB6pO6+cHJvri4mCWhNb6UBjIup929Y0R53MhTx0Mi4iOXP/J9mrYLQs3ds28plPGrb98XVFO/BccAkL5Us81Si4KfqThSDCyBmKRSkTUvjyTE+GjwQKgcrwIpHN3e+/JoF5/3wqVWS7/bDoCT4lLtx6ktaXr5JCL3vWJQpMqcceKx/sWgNLy6R9HZUcL3nz4x83bTmdOXx4RUxgb4ZTSdT+PjGCLWUGhQzrLFJDrVe7ldLDbRLUZ4rlNl0AVMPqKk/VrLz3MfV3ayOCE2Phtfa1QxqV9aZMwPEJiZLiT9h/SxwtAAZZ8BtqsEykdDmnAXEV4oQQ8rjp89qyZa0uzqZI/iXNieSEg9g+/1fGlKntd7p5fKFmGAVzh+YqgxlsEl9gfrtvLC9oM4cN4efJfmYT7jySluDWwW//t3iSjkWEcIB3oY+jZY8laOvdQyGyRQyARuvCHpoV97rGpYvVpnSNFPecvZs7m2KvYvuP0w69ZpNhxMcnX3ReaKoK0G9nE4XXKrmwo59wxy6x3l7ANCIyWsjppyn7fSVil9I5T65A6Mmix3uZ/0VzPOsBqk2ICgCToN6PnBPkJ94wK4ja/sCJH8H92/r+In3WH3bNT+zu/McKBJxr+asKhUNCncfcWzorhZVwTUfGCry58WSYoLFh3iZspUcE0V9OxdvO/bq73Lvq4AVaB5mV8fvltq4tx+t1uaxgdjARmmZmR/2tYJVndgh6a3Pg7NwI9wZbh8EfwgyYayGaD5foNSxstjQ9jcB6GsXf9qY+1ogglnFohZFvOR4MCHcFcobdIxpwyew+ysVYUe
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(66476007)(508600001)(5660300002)(66946007)(66556008)(36756003)(38100700002)(7416002)(8676002)(966005)(2616005)(31696002)(186003)(26005)(31686004)(316002)(6916009)(16576012)(54906003)(8936002)(53546011)(4744005)(2906002)(4326008)(956004)(86362001)(6486002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?S0ZQdkJabXBuWTNvSXRyRUdadm8yUDdNZlE5Y09jWTJ2aGNLNlI0OE1vWmI0?=
 =?utf-8?B?cXBONUlYSzAyRk5Vc0lLOXFGTDNzQ04xbFlZQnVsV1JNSHZrTFJmU3V5VDBS?=
 =?utf-8?B?Q2tlUlpjTUhFK201U3dKWG9ETHFEWFZMUHZSenhYdGZqNHRPbFF0aE92WTNE?=
 =?utf-8?B?NUtNeUNGcWxoR3g5Q0FWWHJaTm4yZ00xR2ZIVms0ZDIvVmhrd2g1NUJXSGFI?=
 =?utf-8?B?K0tiZVkyWnRSUmhCUkJvSVBhVkR5UGVFc0JkK3h0SjVFUHl1WmRPRno1N25v?=
 =?utf-8?B?YkREbHMyOS9tOE15WXQxZlJYd0RtSkpOdlQwSWlnUUluc3FxcnFLQVVteXZq?=
 =?utf-8?B?RU9vZUx2eGpGQURIRTRzZ25rN1lLVDJNOTRzRnpyQ2pBNUdhd3RsYzdoTDdV?=
 =?utf-8?B?ZVFva3p3WlZkZGxHVm92VFVxN1dQZGNXWjFwTjVFMExURE9LWXRMd1krK0pX?=
 =?utf-8?B?M1FZYUdDK2xYWmZIeHRuL1lNcVQ4NkthRzQyR1R5MW5sQ0l2NUVEMkRKZENq?=
 =?utf-8?B?K2E5bkNoSmdBam9EL1VNTVc5RXg2dlhIOUJrR1FHVCtlUUV6NDZWSFZHMXpN?=
 =?utf-8?B?S0JRS1ZhdXJoZzdRUW5UeDh4YjZRelNxVytsOExiVzE5OVZubFdiS2J4OGVW?=
 =?utf-8?B?T0daaHJ3UG9SdUVsYVl4SjFGSzRObDI4SzF0SnZJa2w1OU1VK0lLdFdQeDBq?=
 =?utf-8?B?eWxnUksydjFZbFVqTENwOU5vcmFpaTVudnovYUtjSWhIM2NBZTFIc09hejZJ?=
 =?utf-8?B?ZUtjMTJZM05xUEpTSHNnUFNQaW5TcTFiWjlPTkZMVGw2N2NTMXFtVHRLUGxI?=
 =?utf-8?B?c21kQ1pYaUt1YVpEa3pxbmx3V3FLUkVRYXdFNndUK0xuZitpL3dqV25XNW9k?=
 =?utf-8?B?VGtpcXZ4T1JURHFLQmhZNEhEcUVBOTBhekRBZEljSHRQVXJZalp4R1ZKNUF5?=
 =?utf-8?B?ZEhxa3lDNmhOc1VXOGNuTlU5UWRVL1NlTTVlRFJIMUkyRGplTDFnZDVGaXlG?=
 =?utf-8?B?eTgvUUw5ak9jMXBRTlg5dFpvN1R6SUdrQlhjZ3BGVVlHRDEzeDllNmEwVHp5?=
 =?utf-8?B?b3dTelJnK2dXRzhvVmY4cm9nRGE3cUVqVGROU0M4UGdvb3A5bUJvSEZVcmp0?=
 =?utf-8?B?cWNrQlk3R0pQQmI1N1IrUGJMcHFEaEFBcE1GWWJpaE55cE5aelM3TnAwNTdL?=
 =?utf-8?B?NUFQRFdDM1Y2eG84TGVwczZtMm5EdnNaZ1Nkay9IY1JaSU5BMFhvcmU0ak1x?=
 =?utf-8?B?MGd2UjlRL1MzNFl5YmhlYVV3ZEFqZWkrd0QydEdPTU5QT29YL2NER2N4eEQ5?=
 =?utf-8?B?c3diUHlxL2VOcXVNUXlLWS9hN2g2d080ZjhHNnZoK1pDNFh6TXBpcm41Z2dB?=
 =?utf-8?B?dEtqQjBiYThselNibVExZk1FMmlHUE9sR3ROVUdQK0MzdndqTG01Sm55R3Rl?=
 =?utf-8?B?YVlRMDVIZkNwODIxbC8zTmRUQzJsME1uUUJnb0M1dy9lb0FrNGt4cnFpUHhm?=
 =?utf-8?B?dXM0UFpKbGxPR0ZPL1hjQzZrVmQrK2xhNUJRSkJWNjFjSXQvaU91U1Z3YXBr?=
 =?utf-8?B?aFZDQzNhbE03OWk4cnlnbUNCVmpNNmFMWmREajk3RklnZ3ZnWnB1K2dPbXlw?=
 =?utf-8?B?V1hKTkVjc1Z3aitBSUF4ZVhZdlVkaHQyQjluZXM2dFdKank1T3lTYi9EeFVZ?=
 =?utf-8?B?bmQwWStOZ1J0a0RVNmN6YWhreU1OOW5Ic2xjM1B3L0o4L052UlNMUG4wODF3?=
 =?utf-8?Q?sIrG3bgcnFHGjwPEnMr4lcl//bSfmzXon2fcHWT?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ad86d77c-a75c-48d4-be5c-08d989938b19
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Oct 2021 13:08:23.7983
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: WusMsMNpdqotQ2VDQOKmCi22YszPtzFs0os7rHJxf0Ryg4QYE5y8kf1MRDKBbN5KyGSKPSAKaTcY3dsI1L4fRQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6479

On 06.10.2021 19:40, Rahul Singh wrote:
> --- a/xen/include/public/domctl.h
> +++ b/xen/include/public/domctl.h
> @@ -70,9 +70,11 @@ struct xen_domctl_createdomain {
>  #define XEN_DOMCTL_CDF_iommu          (1U<<_XEN_DOMCTL_CDF_iommu)
>  #define _XEN_DOMCTL_CDF_nested_virt   6
>  #define XEN_DOMCTL_CDF_nested_virt    (1U << _XEN_DOMCTL_CDF_nested_virt)
> +#define _XEN_DOMCTL_CDF_vpci          7
> +#define XEN_DOMCTL_CDF_vpci           (1U << _XEN_DOMCTL_CDF_vpci)

Like said in [1] here I similarly don't see the need for two constants.
Preferably with the former of the two dropped
Acked-by: Jan Beulich <jbeulich@suse.com>

Jan

[1] https://lists.xen.org/archives/html/xen-devel/2021-10/msg00266.html



From xen-devel-bounces@lists.xenproject.org Thu Oct 07 13:12:39 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Oct 2021 13:12:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.203576.358715 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYTCH-0003mc-H7; Thu, 07 Oct 2021 13:12:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 203576.358715; Thu, 07 Oct 2021 13:12:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYTCH-0003mV-EA; Thu, 07 Oct 2021 13:12:29 +0000
Received: by outflank-mailman (input) for mailman id 203576;
 Thu, 07 Oct 2021 13:12:27 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=4W4d=O3=gmail.com=olekstysh@srs-us1.protection.inumbo.net>)
 id 1mYTCF-0003mP-Hg
 for xen-devel@lists.xenproject.org; Thu, 07 Oct 2021 13:12:27 +0000
Received: from mail-ed1-x535.google.com (unknown [2a00:1450:4864:20::535])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id b2c6fe1c-9027-4008-ad81-94b36ebc5dcd;
 Thu, 07 Oct 2021 13:12:26 +0000 (UTC)
Received: by mail-ed1-x535.google.com with SMTP id z20so22827854edc.13
 for <xen-devel@lists.xenproject.org>; Thu, 07 Oct 2021 06:12:26 -0700 (PDT)
Received: from [192.168.1.7] ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id rv25sm7337064ejb.21.2021.10.07.06.12.20
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Thu, 07 Oct 2021 06:12:20 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b2c6fe1c-9027-4008-ad81-94b36ebc5dcd
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-transfer-encoding:content-language;
        bh=7lwzSOCbz2WcgE9NMs6IB7xW1wTKSVbMRQ1hnSd/qCM=;
        b=g2gAhL0fnFj8beommIiTbogswBYgxvTSy0ehvdZC+POUfiO+xeFYs6ab2TOCxVcrCu
         DqB+J+JJtFaakv7IsWDkg+EAdGTX9O0PniQqD/MNaictADlZo66UhFwx2pLmFx91i1+d
         ypVyRmsd6iNMf2+/q2+sAYpU1urpFPl9g/HOuU3vZzpSuEmbQluhsnkQqFNwhT3Uqnrw
         yVVNxIZzsL0O5l56lrGS+N14avnW3RkRgqFeWyyiEfRghqJOu1lzLr2KejH8/efZe5XJ
         3ayZ5Kha6w/kLoOVEyBgZIPkvASEUxKoJ1G0NMsvIABZ2ikg4ndowzKDuxDB9XLpKvWo
         /Pdw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding
         :content-language;
        bh=7lwzSOCbz2WcgE9NMs6IB7xW1wTKSVbMRQ1hnSd/qCM=;
        b=erqqEY+rmYTc4z+snqjIssbQbcPEeYYzzu6Efn9P+gNfyY/K9nPMPLnWiqR0fV1Sqx
         4ZfBsJyenTWbWrRINt4NKrhZ9D5p/vLtX8vKxqx+15Pokn6tD/bwZJVHa4Vk0X0qlRxH
         fgI+i5lwuP3/2/9/mUQjoMiA+6Rj7r3iJas0NM+HxtlSNXwuYK+rS6OH2iDXT2AJJd/o
         Uihh15VraiqwruVzUhexmd+Zkf5mHyKRyMbrxy6+2O5WvW1Xh3EyQbnfJKOSPqIEyG1T
         kMKUmS7A2KXzWN+FxbHVOcFKhPLkcg66h2CdOC57QhkcpsNKeshX1UnbK/NSs7Aeq5Nn
         VldA==
X-Gm-Message-State: AOAM532AAPS90hxLn5qQgfFlrgPGZA4r+FegAUtZi0dxpsBm/vnhw4lu
	N+8Gml0rMmGwvfftyYtxwYCcxRd4aUI=
X-Google-Smtp-Source: ABdhPJxU+HWQeT9unXP/ti1F9VkKE6OUqwxbeNtt/hMdY1Wfq60GyuIQcVPa7Iw2QY1qcVwQGwib/w==
X-Received: by 2002:a17:906:2e85:: with SMTP id o5mr5416897eji.543.1633612341231;
        Thu, 07 Oct 2021 06:12:21 -0700 (PDT)
Subject: Re: [PATCH V5 1/3] xen/arm: Introduce gpaddr_bits field to struct
 xen_arch_domainconfig
To: Jan Beulich <jbeulich@suse.com>
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>,
 Anthony PERARD <anthony.perard@citrix.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Juergen Gross
 <jgross@suse.com>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 xen-devel@lists.xenproject.org
References: <1633519346-3686-1-git-send-email-olekstysh@gmail.com>
 <1633519346-3686-2-git-send-email-olekstysh@gmail.com>
 <68cb29bb-7d84-dc27-eead-4a079b9caf68@suse.com>
 <e77eea6f-163d-0920-2e90-fb9f3a602743@gmail.com>
 <ffb40f3b-2394-7747-2c06-955e2aa87cfc@suse.com>
From: Oleksandr <olekstysh@gmail.com>
Message-ID: <387608b9-c7b2-e814-7fa5-a262acc0c73d@gmail.com>
Date: Thu, 7 Oct 2021 16:12:20 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <ffb40f3b-2394-7747-2c06-955e2aa87cfc@suse.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US


On 07.10.21 15:43, Jan Beulich wrote:

Hi Jan.

> On 07.10.2021 14:30, Oleksandr wrote:
>> On 07.10.21 10:42, Jan Beulich wrote:
>>> On 06.10.2021 13:22, Oleksandr Tyshchenko wrote:
>>>> Changes V4 -> V5:
>>>>      - update patch subject and description
>>>>      - drop Michal's R-b
>>>>      - pass gpaddr_bits via createdomain domctl
>>>>        (struct xen_arch_domainconfig)
>>> I'm afraid I can't bring this in line with ...
>>>
>>>> --- a/xen/include/public/arch-arm.h
>>>> +++ b/xen/include/public/arch-arm.h
>>>> @@ -333,6 +333,11 @@ struct xen_arch_domainconfig {
>>>>         *
>>>>         */
>>>>        uint32_t clock_frequency;
>>>> +    /*
>>>> +     * OUT
>>>> +     * Guest physical address space size
>>>> +     */
>>>> +    uint8_t gpaddr_bits;
>>> ... this being an OUT field. Is this really what Andrew had asked for?
>>> I would have expected the entire struct to be IN (and the comment at
>>> the top of the containing struct in public/domctl.h also suggests so,
>>> i.e. your new field renders that comment stale). gic_version being
>>> IN/OUT is already somewhat in conflict ...
>> I am sorry but I'm totally confused now, we want the Xen to provide
>> gpaddr_bits to the toolstack, but not the other way around.
>> As I understand the main ask was to switch to domctl for which I wanted
>> to get some clarification on how it would look like... Well, this patch
>> switches to use
>> domctl, and I think exactly as it was suggested at [1] in case if a
>> common one is a difficult to achieve. I have to admit, I felt it was
>> indeed difficult to achieve.
> Sadly the mail you reference isn't the one I was referring to. It's not
> even from Andrew. Unfortunately I also can't seem to be able to locate
> this, i.e. I'm now wondering whether this was under a different subject.
> Julien, in any event, confirmed in a recent reply on this thread that
> there was such a mail (otherwise I would have started wondering whether
> the request was made on irc). In any case it is _that_ mail that would
> need going through again.

I think, this is the email [1] you are referring to. The subject was changed
to reflect changes in the particular version. This is the third 
proposition of this patch
(the first two were with arch and common field in sysctl).


>> I thought that a comment for struct xen_domctl_createdomain in
>> public/domctl.h was rather related to the struct fields described in the
>> public header than to the arch sub-struct internals described elsewhere.
>> But if my assumption is incorrect, then yes the comment got stale and
>> probably not by changes in current patch, but after adding
>> clock_frequency field (OUT). If so we can add a comment on top of arch
>> field clarifying that internal fields *might* be OUT.
>>
>>
>>> One of the problems with
>>> _any_ of the fields being OUT is that then it is unclear how the output
>>> is intended to be propagated to consumers other than the entity
>>> creating the domain.
>> If I *properly* understood your concern, we could hide that field in
>> struct libxl__domain_build_state and not expose it to struct
>> libxl_domain_build_info. Shall I?
> I'm afraid I'm lost: I didn't talk about the tool stack at all. While
> "consumer" generally means the tool stack, the remark was of more
> abstract nature.
>
> Jan
>
>> [1]
>> https://lore.kernel.org/xen-devel/093bc1d5-bf6a-da0a-78b5-7a8dd471a063@gmail.com/
>>
>>
[1] 
https://lore.kernel.org/xen-devel/6a2a183d-c9d8-df2a-41aa-b25283fab197@gmail.com/


-- 
Regards,

Oleksandr Tyshchenko



From xen-devel-bounces@lists.xenproject.org Thu Oct 07 13:37:25 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Oct 2021 13:37:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.203585.358726 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYTaH-0006DP-LO; Thu, 07 Oct 2021 13:37:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 203585.358726; Thu, 07 Oct 2021 13:37:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYTaH-0006DI-Gb; Thu, 07 Oct 2021 13:37:17 +0000
Received: by outflank-mailman (input) for mailman id 203585;
 Thu, 07 Oct 2021 13:37:16 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=9/ki=O3=arm.com=Rahul.Singh@srs-us1.protection.inumbo.net>)
 id 1mYTaF-0006DC-Po
 for xen-devel@lists.xenproject.org; Thu, 07 Oct 2021 13:37:15 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com (unknown
 [2a01:111:f400:7d00::61b])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 95b5de90-5c93-4ed2-8d06-c90607edbf70;
 Thu, 07 Oct 2021 13:37:12 +0000 (UTC)
Received: from DB9PR06CA0013.eurprd06.prod.outlook.com (2603:10a6:10:1db::18)
 by DB6PR0801MB1653.eurprd08.prod.outlook.com (2603:10a6:4:3b::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.21; Thu, 7 Oct
 2021 13:37:02 +0000
Received: from DB5EUR03FT062.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:10:1db:cafe::38) by DB9PR06CA0013.outlook.office365.com
 (2603:10a6:10:1db::18) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.14 via Frontend
 Transport; Thu, 7 Oct 2021 13:37:02 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT062.mail.protection.outlook.com (10.152.20.197) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4587.18 via Frontend Transport; Thu, 7 Oct 2021 13:37:02 +0000
Received: ("Tessian outbound 16951d3c485e:v103");
 Thu, 07 Oct 2021 13:37:02 +0000
Received: from a3d534c14fd9.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 4F5E297D-8064-41BE-AEA4-C5E6440F2AB1.1; 
 Thu, 07 Oct 2021 13:36:50 +0000
Received: from EUR02-HE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id a3d534c14fd9.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Thu, 07 Oct 2021 13:36:50 +0000
Received: from AS8PR08MB6919.eurprd08.prod.outlook.com (2603:10a6:20b:39e::10)
 by AS8PR08MB6743.eurprd08.prod.outlook.com (2603:10a6:20b:399::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.19; Thu, 7 Oct
 2021 13:36:48 +0000
Received: from AS8PR08MB6919.eurprd08.prod.outlook.com
 ([fe80::51ee:e7de:6c0a:bcf9]) by AS8PR08MB6919.eurprd08.prod.outlook.com
 ([fe80::51ee:e7de:6c0a:bcf9%7]) with mapi id 15.20.4566.023; Thu, 7 Oct 2021
 13:36:48 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 95b5de90-5c93-4ed2-8d06-c90607edbf70
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=+/6ht/emBIaV6NbUrkr7jRGEytZYuESeWz0oaJ8IphE=;
 b=PzEqL7lgDplV7Rm1bRMXT5uGxpeKFZinxWQgXtAFlljodAMHBMQSWiSvRgAP3DCVhci4eQyJuuJNM6Q+4kcWLwixe5spE3bHZMhSkLT0/S1EJvYl/GkwMI1LNU404lUMby4tYNT/J0+dpJUrodmXKeOTGzV3gk3vr2myCI2xLU4=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: c3c3e5a8b5f83d82
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=PasIG+BxqX3KP0QDeBpNKZkqk59iuFpQVPOF/FX4MaxABtWxZ2khPXkTz2bIkFz2yQH1XDm1kAAhj4hBBEchZeVMSGf+DZSpQDtrIX2LlYVgeRSRM4ldsZQuFgcI0dPLkcP6a59Q6qOVFLlsiORp4qyC9KyjUTimkkZYqsPiPCW+mqv4rJnzU/fELOZ5zSZ9W2FAyOwUZfzWFHZn8jPZ4FGqcsH05kZ4gVkSXWWJgkdSO/mkoL94TG5scKCqfC12xxNhOGcidipihzrqn+0J020xqGZ5ZwZmCen75ixZ4QuUuOw7UhzV9zOgJJzFoD+IW0t6/k/Ww8jMKZ7x63u9YA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=+/6ht/emBIaV6NbUrkr7jRGEytZYuESeWz0oaJ8IphE=;
 b=iyLqXD4f3esYdImuMYW8FRslv3PmwJgLoV/hsWLp1mDeSafql+ZAPyCI+knXuDYKf1yrT50WMrIVSGuZaeTeexqBCHhKwH4l6sheVPuBLuG6PNh7w7GRT35qxQFY116BvKsvCOHtOxF6+zx7Ewpp6YMzeXKLdaZfzjTN2FfQ8DH/D/O/9LsjzE+KoXtnR+glRWsvsiuF4RCPAtPBqWAeFzviM+GdpWxnB87h4RI0rbt6tW4q3mnuF18H3JG8FxPM7pNDcjRtfvfdbGvQv8vFHA2X5Qj5QD4w12Nhlmwe6FUFcokSEp7JegqpTN+EqZA3H3gMaAH51tAG3WuJOySgmw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=+/6ht/emBIaV6NbUrkr7jRGEytZYuESeWz0oaJ8IphE=;
 b=PzEqL7lgDplV7Rm1bRMXT5uGxpeKFZinxWQgXtAFlljodAMHBMQSWiSvRgAP3DCVhci4eQyJuuJNM6Q+4kcWLwixe5spE3bHZMhSkLT0/S1EJvYl/GkwMI1LNU404lUMby4tYNT/J0+dpJUrodmXKeOTGzV3gk3vr2myCI2xLU4=
From: Rahul Singh <Rahul.Singh@arm.com>
To: Ian Jackson <iwj@xenproject.org>
CC: Stefano Stabellini <sstabellini@kernel.org>, xen-devel
	<xen-devel@lists.xenproject.org>, Bertrand Marquis
	<Bertrand.Marquis@arm.com>, Andre Przywara <Andre.Przywara@arm.com>, Wei Liu
	<wl@xen.org>, Anthony PERARD <anthony.perard@citrix.com>, Juergen Gross
	<jgross@suse.com>, Julien Grall <julien@xen.org>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH v4 13/14] arm/libxl: Emulated PCI device tree node in
 libxl
Thread-Topic: [PATCH v4 13/14] arm/libxl: Emulated PCI device tree node in
 libxl
Thread-Index:
 AQHXuRciClWhjFX7R0aQhsW/aixhyqvDkJEAgACf3oCAAL5hgIAAzJaAgAAXDgCAAALtgIAABFYAgABk+ICAASF7AIAALmeA
Date: Thu, 7 Oct 2021 13:36:48 +0000
Message-ID: <13345692-69BF-4CAD-9880-FB5FB8076AB3@arm.com>
References: <cover.1633340795.git.rahul.singh@arm.com>
 <3ad42008f534671ae7f5b25da91253ce7cd4a3e9.1633340795.git.rahul.singh@arm.com>
 <alpine.DEB.2.21.2110041714410.3209@sstabellini-ThinkPad-T480s>
 <11F169C6-39A4-40F3-8E75-39B8C2CCF022@arm.com>
 <alpine.DEB.2.21.2110051421520.3209@sstabellini-ThinkPad-T480s>
 <8B848F95-977F-4DF4-B315-CFEA610BC1C3@arm.com>
 <24925.33634.554859.2131@mariner.uk.xensource.com>
 <BFC5AD62-3DA7-498F-8B6E-AB4C8CAA9731@arm.com>
 <24925.35194.369692.94259@mariner.uk.xensource.com>
 <5ADA6C46-A69D-459F-868C-DA579FEC36E2@arm.com>
 <24926.53506.270924.8163@mariner.uk.xensource.com>
In-Reply-To: <24926.53506.270924.8163@mariner.uk.xensource.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
Authentication-Results-Original: xenproject.org; dkim=none (message not
 signed) header.d=none;xenproject.org; dmarc=none action=none
 header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: f3d7b068-bb5b-4696-1ddd-08d989978b9b
x-ms-traffictypediagnostic: AS8PR08MB6743:|DB6PR0801MB1653:
x-ms-exchange-transport-forked: True
X-Microsoft-Antispam-PRVS:
	<DB6PR0801MB1653033AD01D7C03863DC7F1FCB19@DB6PR0801MB1653.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:10000;OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 gf/UawF3RJL3IEM3evYnT0mt3UWTr+v7UQZQbkl/BI3PRizNdHYVQBSpD1BDXJhV74SThOrVDuXOW6ZF81FbtPxTGXzBP/s8yoIrzUdpAPp5VamUktInA3QzhzPphjweTlz1PK0AZsKRa/+7ZdzXYEPGxExl7ZOSrnHHOhF3+O/C2/xftsbzq10O4Qx/t9Z7yhHiOcCsRQRKYJdO1dZVGRVmwLaAeTZrg3eFWQOo7/fJtUfiOA/rICr39ByXp6K077i0DsjhqszsBAk7ee80sGYF+3Vkp+LH9TdvSiGPxpET7Wawo1ZlUbZqrXGaWxLSqJ/HDYOwy7Ssz2UPi89iPWADBsz1Vi6f4cYXTtzfCvoswbBX6rx4XcNycRC4LRlZmrfYA5uOvwetjEM3eDse2nWa5ntPRwVC78iaRBowEhZG7/JR2XaQCaBt+0vhNpIVyxtF3P6g6K9P70Mec87VpLVtKwSg6NFZEThETCgP0Xe0nuk3hjFNd61b1CIX+Dq7LTYuhr7oLwMIqhZsmOF5U6insbS9V9lIB8ItjKpWFIGFGMwk1PsJQXw9a3yPVJIWrFJ6Xk5IYa4yE/QRHD5SxKOJyj4NCQFJ8t9o1007ypvJqyL/xysLf38y773sXL+tXdlFYu1FlkK4ghozazk1tybPQlOMPceai0XRqpMyfs7Kft1RfC6Zl4zJ20QnWgAfLBdkonzK58XMQtJn6W4iuRhhhiuHdpTc/ur6XJ1HHEh51SnRR5OgJn0GLdBvviLV
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6919.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(2906002)(186003)(83380400001)(66556008)(64756008)(26005)(6506007)(71200400001)(66946007)(91956017)(76116006)(66476007)(66446008)(2616005)(122000001)(6916009)(316002)(6486002)(508600001)(54906003)(4326008)(38100700002)(86362001)(33656002)(38070700005)(8676002)(5660300002)(8936002)(36756003)(6512007)(53546011)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-ID: <2DEA7F7886F90B4CAE750EC9E7303677@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6743
Original-Authentication-Results: xenproject.org; dkim=none (message not signed)
 header.d=none;xenproject.org; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT062.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	cd5b5789-8fa8-4edb-cab9-08d98997832e
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	n+kX2iZX8kcnaAdMY8STQlDdZc3OCYIKjFDelEMDd+a18mLePRqttSL8391RlMrvsey8yvD7/IrYvPTOtES0abhYPN0r1prXA77mLHzh3lL4/O3VH6dKKUERlRZXX2u9N5HklS4YXC9JZFR0sdLJNUkgfRVkGlOLjUJqUUuDjnDAJ9G9g67hma5oHIyhiU+ERVc4jvMPiXKBZ3O47SwnxYuyHmiP9AeMWmatuY/3JB0xNmslr0/I1I9gmNZSaS714zPaOlar8Rfp1aqdq4g9JoK8emFoXhD2X16nu9Md09lX6AhBmUiY8WfrekefjWeod1hTbSZjUdz+sAceL9tblFaIf1oKcKDolRkShaWZngqpoaNC7tWawrnYt7fkXgsIeeJJjXhOc4pVd7og2K1wIFEqe2wtrranki1ceNjOx1niai9dyTrGt/6QzcBZx36Jy9/jaEySoSs5uD2Iyw0B0IL7KKqENBPwPC0O7LFlcDj8N8wljgHKTvIJwMzxHBZYM2ME2H5bzYVcIoA46rLGp1668alNtDF5XvNEkMgrAo1jFxHv04k9bKxb5mVbKzZ4KWx0GfcuSX+Qa9EImpjN0Nt7GVPz64H1QYUvWD7p4nWNmQfW/+Qww69Iyt1HiUceBHQ7rTq2H6uDqXeuwA/mj4wFZ3yKllcqnvJDox6qJzpwDL/4idcpxFDbau107d0N3nGyXMEvPml65dn/vih+vw==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(82310400003)(36860700001)(6486002)(356005)(186003)(8936002)(53546011)(5660300002)(107886003)(83380400001)(26005)(86362001)(6506007)(54906003)(2616005)(47076005)(33656002)(81166007)(70206006)(336012)(6862004)(4326008)(2906002)(6512007)(36756003)(70586007)(8676002)(316002)(508600001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Oct 2021 13:37:02.4831
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: f3d7b068-bb5b-4696-1ddd-08d989978b9b
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT062.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0801MB1653

SGkgSWFuDQoNCj4gT24gNyBPY3QgMjAyMSwgYXQgMTE6NTAgYW0sIElhbiBKYWNrc29uIDxpd2pA
eGVucHJvamVjdC5vcmc+IHdyb3RlOg0KPiANCj4gUmFodWwgU2luZ2ggd3JpdGVzICgiUmU6IFtQ
QVRDSCB2NCAxMy8xNF0gYXJtL2xpYnhsOiBFbXVsYXRlZCBQQ0kgZGV2aWNlIHRyZWUgbm9kZSBp
biBsaWJ4bCIpOg0KPj4gT24gNiBPY3QgMjAyMSwgYXQgMTI6MzMgcG0sIElhbiBKYWNrc29uIDxp
d2pAeGVucHJvamVjdC5vcmc+IHdyb3RlOg0KPj4+IFdlIHRyeQ0KPj4+IHRvIG1ha2UgdGhlIGxp
YnhsIEFQSSAiZG8gdGhlIHJpZ2h0IHRoaW5nIiBieSBkZWZhdWx0LiAgSW4gdGhpcyBjYXNlIEkN
Cj4+PiB0aGluayB0aGF0IG1lYW5zIHRvIGVuYWJsZSBWUENJIChpKSBvbiBwbGF0Zm9ybXMgd2hl
cmUgaXQncyBhdmFpbGFibGUNCj4+PiAoaWkpIGlmIHRoZSBndWVzdCBoYXMgUENJIHBhc3N0aHJv
dWdoIGRldmljZXMuICBJcyB0aGF0IHJpZ2h0ID8NCj4+IA0KPj4gWWVzIHlvdSBhcmUgcmlnaHQg
VlBDSSB3aWxsIGJlIGVuYWJsZWQgZm9yIGd1ZXN0IHdoZW4gZ3Vlc3QgaGFzIFBDSSBwYXNzdGhy
b3VnaCBkZXZpY2UgDQo+PiBhc3NpZ25lZCBhbmQgVlBDSSBzdXBwb3J0IGlzIGF2YWlsYWJsZS4g
IA0KPj4+IA0KPj4+IFNvcnJ5IHRvIGFzayB0aGVzZSBxdWVzdGlvbiBub3csIGFuZCBwbGVhc2Ug
Zm9yZ2l2ZSBteSBpZ25vcmFuY2U6DQo+Pj4gDQo+Pj4gSXMgVlBDSSBpbmhlcmVudGx5IGFuIEFS
TS1zcGVjaWZpYyBBQkkgb3IgcHJvdG9jb2wgPw0KPj4gDQo+PiBBcyBvZiBub3cgVlBDSSBmb3Ig
RE9NVSBndWVzdHMgaXMgb25seSBpbXBsZW1lbnRlZCAgZm9yIEFSTS4NCj4gDQo+IEknbSBzb3Jy
eS4gIEl0IGFwcGVhcnMgdGhhdCB0aGUgdGhydXN0IG9mIG15IHF1ZXN0aW9ucyB3YXNuJ3QNCj4g
c3VmZmljaWVudGx5IGNsZWFyLiAgWW91ciByZXBsaWVzIGFib3V0IGRldGFpbHMgYXJlIGZpbmUg
YnV0IHRoZXkNCj4gZG9uJ3Qgc2VlbSB0byBhZGRyZXNzIG15IHVuZGVybHlpbmcgY29uY2VybnMu
DQo+IA0KPiAiYXMgb2Ygbm93IC4uLiBvbmx5IGltcGxlbWVudGVkIGZvciBBUk0iIHN1Z2dlc3Rz
IHRvIG1lIHRoYXQgaXQgaXMNCj4gVlBDSSAqbm90KiBpbmhlcmVudGx5IEFSTS1zcGVjaWZpYy4g
IEllLCBpdCBpcyBhIHRoaW5nIHRoYXQgeDg2IChvcg0KPiByaXNjdiBvciB3aGF0ZXZlcikgbWln
aHQgc3VwcG9ydCBpbiBmdXR1cmUuICBJcyB0aGF0IHJpZ2h0ID8NCg0KU29ycnkgZm9yIHRoZSBj
b25mdXNpb24gVlBDSSBpcyBub3QgQVJNIGluaGVyZW50bHkgc3BlY2lmaWMuIHg4NiBvciBSSVND
IG1pZ2h0IHN1cHBvcnQgDQpWUENJIGluIHRoZSBmdXR1cmUgZm9yIERPTVUgZ3Vlc3RzLg0KDQo+
IA0KPiBIb3cgZG9lcyBWUENJIGZpdCBpbnRvIHRoZSB3aG9sZSBzeXN0ZW0gYXJjaGl0ZWN0dXJl
ID8gIElzIGl0DQo+ICpyZXF1aXJlZCogZm9yIFBDSSBwYXNzdGhyb3VnaCBvbiBBUk0gPyAgSWYg
bm90LCB3aGF0IGhhcHBlbnMgaWYgaXQgaXMNCj4gbm90IGVuYWJsZWQgPw0KDQpWUENJIGltcGxl
bWVudHMgdGhlIHZpcnR1YWwgUENJIGJ1cyB0b3BvbG9neSB0aHJvdWdoIElPIGVtdWxhdGlvbiBp
biBYRU4uIEVtdWxhdGVkIGRldmljZSB0cmVlIA0Kbm9kZSB3aWxsIGJlIGNyZWF0ZWQgZm9yIHRo
ZSBET01VIGd1ZXN0cyBhbmQgYWxsIHRoZSBhY2Nlc3MgdG8gdGhlIGNvbmZpZyBzcGFjZSB3aWxs
IGJlIGEgdHJhcCB0byANClhFTi5JL08gbWVtb3J5IHJlZ2lvbnMgZm9yIHRoZSBkZXZpY2Ugd2ls
bCBiZSBtYXBwZWQgdG8gdGhlIGd1ZXN0IGFuZCBNU0kvTVNJWCBpbnRlcnJ1cHRzIHdpbGwgDQpi
ZSByZWRpcmVjdGVkIHRvIHRoZSBndWVzdC4NCiANClllcyBWUENJIGlzIG1hbmRhdG9yeSBmb3Ig
UENJIHBhc3N0aHJvdWdoIG9uIEFSTS4gSWYgaXQgaXMgbm90IGVuYWJsZWQgd2Ugd2lsbCBub3Qg
YmUNCiBhYmxlIHRvIHBhc3MgdGhyb3VnaCBhbnkgUENJIGRldmljZSB0byB0aGUgZ3Vlc3QuDQoN
Cj4gDQo+IElmIFZQQ0kgKmlzKiBBUk0tc3BlY2lmaWMsIGhvdyBkbyB4ODYgc3lzdGVtcyAoc2F5
KSBhY2hpZXZlIHRoZSBnb2Fscw0KPiBtZXQgb24gQVJNIGJ5IFZQQ0kgPw0KDQpPbiB0aGUgeDg2
IHN5c3RlbSwgUUVNVSBlbXVsYXRlcyB0aGUgUENJIGJ1cyB0b3BvbG9neSBhbmQgUFYgZHJpdmVy
cyB1c2VkIGZvciBjb21tdW5pY2F0aW9uLg0KPiANCj4gT24gdGhlIG90aGVyIGhhbmQgaWYgVlBD
SSBpcyBub3QgaW5oZXJlbnRseSBBUk0tc3BlY2lmaWMgaXQgc2hvdWxkIG5vdA0KPiBiZSBpbiB0
aGUgQVJNIHBhcnQgb2YgdGhlIGxpYnhsIElETC4NCj4gDQo+Pj4gV2hlbiBtaWdodCBhbg0KPj4+
IGFkbWluIHdhbnQgdG8gdHVybiBpdCBvbiBleHBsaWNpdGx5ID8NCj4+IA0KPj4gSXQgd2lsbCBi
ZSBlbmFibGVkIGR5bmFtaWNhbGx5IHdoZW4gYWRtaW4gYXNzaWduIGFueSBQQ0kgZGV2aWNlIHRv
IGd1ZXN0Lg0KPiANCj4gV2hhdCBhYm91dCBob3RwbHVnID8NCg0KQXMgb2Ygbm93IGhvdHBsdWcg
aXMgbm90IGltcGxlbWVudGVkIGFuZCB0ZXN0ZWQuIFdlIG1pZ2h0IGltcGxlbWVudCANCnRoZSBo
b3RwbHVnIGluIGZ1dHVyZS4uDQoNCj4gDQo+Pj4gSG93IGRvZXMgdGhpcyBhbGwgcmVsYXRlIHRv
IHRoZSAobm9uLWFyY2gtc3BlY2lmaWMpICJwYXNzdGhyb3VnaCINCj4+PiBvcHRpb24gPw0KPj4g
DQo+PiBWUENJIHdpbGwgYmUgZW5hYmxlZCBvbmx5IHdoZW4gdGhlcmUgaXMgYW55IFBDSSBkZXZp
Y2UgYXNzaWduZWQgdG8NCj4+IGd1ZXN0IHRoZXJlZm9yZSBJIHVzZWQgImRfY29uZmlnLT5udW1f
cGNpZGV2c8OvxbzFkyB0byBlbmFibGUgVlBDSS4NCj4gDQo+IFRoZSBwdXJwb3NlIG9mIHRoZSAi
cGFzc3Rocm91Z2giIG9wdGlvbiBpcyB0byBhbGxvdyB0aGUgZ3Vlc3QgYWRtaW4gdG8NCj4gc3Bl
Y2lmeSB0aGF0IGEgZ3Vlc3QgaXMgZXhwZWN0ZWQgdG8gZ2FpbiBob3RwbHVnZ2VkIFBDSSBkZXZp
Y2VzIGluDQo+IGZ1dHVyZS4gIFRoYXQgd2F5LCBkb21haW4gZmVhdHVyZXMgdGhhdCBhcmUgcmVx
dWlyZWQgZm9yIFBDSQ0KPiBwYXNzdGhyb3VnaCBhcmUgYXV0b21hdGljYWxseSBlbmFibGVkLg0K
DQpPbmNlIHdlIGltcGxlbWVudCB0aGUgaG90cGx1ZyBmZWF0dXJlIHdlIHdpbGwgdXNlIHRoZSAi
cGFzc3Rocm91Z2g94oCcIG9wdGlvbnMuDQo+IA0KPiBQZXJoYXBzIHRoaXMgaXNuJ3QgZXhwbGFp
bmVkIGNsZWFybHkgZW5vdWdoIGluIHRoZSBkb2N1bWVudGF0aW9uLA0KPiB3aGljaCB0YWxrcyBh
Ym91dCBpb21tdSBtYXBwaW5ncy4NCj4gDQo+IERvZXMgUENJIHBhc3N0aHJ1Z2ggd29yayBvbiBB
Uk0gd2l0aG91dCBWUENJID8NCg0KVlBDSSBpcyByZXF1aXJlZCBvbiBBUk0gZm9yIFBDSSBwYXNz
dGhyb3VnaC4NCg0KUmVnYXJkcywNClJhaHVsDQo+IA0KPiBJIHRoaW5rIGl0IGxpa2VseSB0aGF0
IFZQQ0kgc2hvdWxkIGJlIGNvbnRyb2xsZWQgKG9yIGF0IGxlYXN0LCBpdHMNCj4gZGVmYXVsdCBz
ZXQpIGZyb20gdGhlICJwYXNzdGhyb3VnaCIgb3B0aW9uLiAgQnV0IEkgZG9uJ3QgdW5kZXJzdGFu
ZA0KPiBlbm91Z2ggb2YgdGhlIHJlbGF0aW9uc2hpcCBiZXR3ZWVuIHRoZSBwaWVjZXMuDQo+IA0K
PiBJYW4uDQoNCg==


From xen-devel-bounces@lists.xenproject.org Thu Oct 07 13:43:55 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Oct 2021 13:43:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.203596.358736 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYTgd-0007kC-Gk; Thu, 07 Oct 2021 13:43:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 203596.358736; Thu, 07 Oct 2021 13:43:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYTgd-0007k5-Db; Thu, 07 Oct 2021 13:43:51 +0000
Received: by outflank-mailman (input) for mailman id 203596;
 Thu, 07 Oct 2021 13:43:50 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=qfpx=O3=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mYTgc-0007jz-1V
 for xen-devel@lists.xenproject.org; Thu, 07 Oct 2021 13:43:50 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 98db9870-2774-11ec-bfd1-12813bfff9fa;
 Thu, 07 Oct 2021 13:43:48 +0000 (UTC)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2107.outbound.protection.outlook.com [104.47.18.107])
 (Using TLS) by relay.mimecast.com with ESMTP id
 de-mta-30-uSlgDG5EPXSl5NtP96TxTw-1; Thu, 07 Oct 2021 15:43:46 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0402MB3935.eurprd04.prod.outlook.com (2603:10a6:803:1f::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.19; Thu, 7 Oct
 2021 13:43:44 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4587.020; Thu, 7 Oct 2021
 13:43:44 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM5PR0101CA0001.eurprd01.prod.exchangelabs.com (2603:10a6:206:16::14) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.14 via Frontend
 Transport; Thu, 7 Oct 2021 13:43:43 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 98db9870-2774-11ec-bfd1-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1633614227;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=q5s0h5hS1J85jx+FyEr8gZjKVjTaTfQ2r300p16zpDM=;
	b=EGwNkyrfyHiWE5fLxFYmumfq7wKZfxS3Gi9NyRDwUIej0zexpoWEWxpmeWeKUnQGR1FGY+
	KWwJ0S/1YJel0Qyt+D085G5diGHKFn5lN5VwO0U1p9GQnIEHaLVhZn6NB6R8OpkVsdDTdT
	Qt08xtJiz1DQe0PBnA/XrAaDG8ZjbFE=
X-MC-Unique: uSlgDG5EPXSl5NtP96TxTw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=KAn/PArdvur86T+mdR+8dQmYh+6WiRY7niTEi0kgmTFwdH+q6UksslPwmJpEhwVwPxaNXIYtjLv5cdEYjAZGtp6gW6nmIGx0+34YXaqmkn04KObiorbVyBFJvjL2CT7kcSIngHCFi9kmGeDsY0Ht/nNDxXOlf7/VNYtHtk1/KysVw0G7FcQECJu0WTWEXKfyenE7O0Ak8bU2lZ+c/5LzJtjNNv/lUr21KwJUTkzRV5okF+GMju4sqG9EoWJB7h4X+IIxwrnBbVQhhHHVtbSW2zVfBc2D8exivPUi+ecZEbLL8lq+xYOAmvaCICqvyI8VV4pve6jvYqR5HTK1SRpyBQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=q5s0h5hS1J85jx+FyEr8gZjKVjTaTfQ2r300p16zpDM=;
 b=N8OSANLrr2PJDOrb954psfjXvFrhV8LjTswIldniNzSuma7Y+Y/YwsGWQRAf+4hwRE2WRR8A+zaM45akYzIisay2DS4TlaXQbvqz9Z0voTGOtEyN2rQY6dhLyW6FwmV3N3qMia3RzAVZ9zFgNaspAUdtERIEBGVoFqPkl2zsK8p6TwZN10SIyBgrwoqcPfMdYvMdRWm6kfZzjIiJSBZy4HnHLFdpG/jDL839cS4rLW7yJ9q915jcAGgK+EsbB4xK/wrQYbeTW5M5Iq8MDGfsr75cQ7QktvJZXQa8J3anbrvTO/VLAzmaa6ieztt7wmUz0r+ai7nbZWPH9W6j53gJPQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [PATCH v5 08/11] xen/arm: Enable the existing x86 virtual PCI
 support for ARM.
To: Rahul Singh <rahul.singh@arm.com>
Cc: bertrand.marquis@arm.com, Andre.Przywara@arm.com,
 Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Wei Liu <wl@xen.org>, Paul Durrant <paul@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 xen-devel@lists.xenproject.org
References: <cover.1633540842.git.rahul.singh@arm.com>
 <9bdca2cda5d2e83f94dc2423e55714273539760a.1633540842.git.rahul.singh@arm.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <6752f2d3-171b-37f5-c809-82995a8f3f36@suse.com>
Date: Thu, 7 Oct 2021 15:43:41 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <9bdca2cda5d2e83f94dc2423e55714273539760a.1633540842.git.rahul.singh@arm.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM5PR0101CA0001.eurprd01.prod.exchangelabs.com
 (2603:10a6:206:16::14) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: e0b7a4fe-95fc-45b2-52da-08d989987afa
X-MS-TrafficTypeDiagnostic: VI1PR0402MB3935:
X-Microsoft-Antispam-PRVS:
	<VI1PR0402MB393591C0CCF7E2486795B6CDB3B19@VI1PR0402MB3935.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	SjisXo/NXpczKRsTuD++vpHqe6iauz4DCNj5fuBzsSY0Am26H59aSmP2TS+OCy2/aSYEU66zfOLmQg3PsIM+DFT7GYy7lh9LNKMmb2Ui6PQGDzESgi5KhDSTUG72x2g0PnaAtfRkEaQMHUahqBWEPOjQYgP2W6u1dnUiwiT40T4WNQiUxHgY6Ans18FA9uPuFVBhTX0JXpLEbCw0pwczJjcXvYCBq9smFaGBHmChK0nHbjQ5CUkH2D4U7EN+19yZ76Jct43U40/rCdEM/u8cUM3ocQ3ihAKk7AHVN/BXLNMaNa38MjWtjcSLuvV8hUzxHXNfUGwu/deGTOLx6LxgKCh+T8jFidI54qV3QIImv0wv7xqINAfCgV7GjGqHVG3qRUK1tuXoVw+79/uHxf56iFi36huCFr6sJTse1VC5zjZR/Icyl8mZridu7HN0uismcjqi3ZLZdNVSDYWl3oefIFaZSSZF8lmy7x/ktn9Dgq4WFyd37+X3zSKd8Be1lUlnTUrU478KrAErOI8+F112iERfuyAVMQwqUwGiefIYdTsDDUvhgYsuL+H7hpkFLkcAmYFqhbu/LLgZ48wzr7yncyrwh8jM9+XPuB3fkQF7h6OZDFFawZTGwiqeCAWFoW8W/E/GoUB13SduYpKurgWl6R2b0HWM6N9S59RF5f8867hlN/anNN92hkE4BmaNvRzLdpTk8ztZhMBsk5MxXLjG4DwxP4vVFleggtunLavomHs=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(186003)(16576012)(2906002)(83380400001)(6486002)(6916009)(54906003)(316002)(31686004)(36756003)(7416002)(31696002)(26005)(66556008)(66476007)(956004)(66946007)(508600001)(2616005)(4326008)(86362001)(8676002)(38100700002)(53546011)(5660300002)(8936002)(2004002)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?UDBldlU3c2N4RFFTU3pjNysvbnZlZ0JjZFFQcXVtNUZXNER5WDNCVXM4SWE2?=
 =?utf-8?B?Rko3SFMvNEtZelBGck9lcEUyM2NUMW1FQUFqYmJpUktUZDF3VXovUEZzd0Jp?=
 =?utf-8?B?aVJqVWovaE9UeHEzcFg2THh3V0pDQVZBaU5uMXVkNjBob0s4Y3ZaTlVDdGph?=
 =?utf-8?B?N2VSRG0vZ3kyYkFsd2FmYjRZNW9KNG9SdmZTb0dKdlNKTkpQZDVZRURJQzhC?=
 =?utf-8?B?TElFZVNyTGNZa3dXK0Jhem15Z2RPM2g4cHBSaEYvSkZOZ05TekNjYXZ3cmcr?=
 =?utf-8?B?eGFPMlFvak5sOFcwYkk2WTh0b2l4MUV0dnJ5aHd0d1NCaUVlWld2S3laa0xG?=
 =?utf-8?B?OXJQNjJrby9DbVFpMnFuYTZZN0ppK1I5V0Z2SnVtbC9qeVB6MWV5TmVuT2xt?=
 =?utf-8?B?dlh6Zi8rZjBmbUxUc3lSSnF1azJ0UGNHcVBkM3hZTjlNMTI2azZza1I2UUNV?=
 =?utf-8?B?RUpnV2ttTVBhRnhtYTZaV0VrNC9vcWRvd1dYOVdGUVBTOERxejQwTnFhOXZ6?=
 =?utf-8?B?TldOOXE1dVF5QkxvVzNQTVYwdk8rclhZdW1ETWJLZU9rUGFMRlY0M0I3UVJY?=
 =?utf-8?B?dUkxalQ0dUpnbERnelR0Z2RYYjVMQWxtSG1uNkNDSEJSdWZnMFpnWS9NRU44?=
 =?utf-8?B?eERZaWY1bkdyWEVZVlFNZXR1eDJEaHFkVGozMGwwRXFtaGxkNW83SzJKdmdu?=
 =?utf-8?B?ZDJxaDBTcUlKSkU3TDNLQm9qM0RlenF1aWpxWENsaXUwR2F6ZTV4S2VEWVd3?=
 =?utf-8?B?c0NDR1hhSjJ6c3FKMDI4WUovdXZZT3dCbXZFSzczMEovSFNCRHU4dFFKbCsw?=
 =?utf-8?B?YlQxSG1Vc0FBdWk1NmgvYVNiczVyakthKzhpU2crdHpoYnFrb0VkOVJSV2xH?=
 =?utf-8?B?eXBPanRTVWw2ZGJMRStESG54Q0kyUjVMNEVyRjFZa3BRaWNscUhBSkJNL2FX?=
 =?utf-8?B?QU5DcTR1dW1qUHIrcGsrSVdXWU9ldUY4R3Jjb2NQdTFhYTFWd3kwSUVYY00w?=
 =?utf-8?B?TUFaTUNDVm9jRERQSXljeXZPMS9uUDNMZW5hQ2RYZHpaOWhaWWJvZGtIR3V5?=
 =?utf-8?B?OGp3b284NUhLMGFkWWg1VXB1bXpVUWVKMk9sbW9hUXJxVUd5WE0zeHptaGlJ?=
 =?utf-8?B?Z3I3SUlmRkNDNEwyMWlTUFJiTjJ3L0Q5eHNCcFdLRUY0UVNaQUN3cCt0Slkx?=
 =?utf-8?B?SzZkS1RnSU50RlV3WUJ1Q1l6Wnl6Y2w4WDhQMkZYZktyYjgrcFVXTXZxUnRG?=
 =?utf-8?B?V0ZTR0FPcGZYWEdWR0xqZjVDRXA4L2FMKzd1a1FJckMrM2VBQjIwWHNPRU1O?=
 =?utf-8?B?OEU5VklSYWhtbEVYSTRvVlB0L0JqcXJ5MjExOGFjU2w1VmdZWXgwVnc1VGRw?=
 =?utf-8?B?WFpQcHR6SVRIKzNiWWVneXMwdGg3ZDFhd0t4RWhYRm1xeUlWbXFnUWVRR2xu?=
 =?utf-8?B?MDk0NytQZXVkZS92UTBTVHJpRGxuSjk1cjVNUHBXUWUzaE5wMVBVQi9nQ3NR?=
 =?utf-8?B?ODI0QklJVEltaFQwY3pMTGNyY2ZhZGpoTGxIU3JkTkdDQ0FWTWRjNGNneTdJ?=
 =?utf-8?B?NTMwR2diWW9DVENYQmsrdGIyOVBGMUI3bEp1U3A0REFEVndQcjNMV0gyZ0xP?=
 =?utf-8?B?VVBQdEZOVksyUllOZ1ZUWllrbWFBMVdEYUQrWThCaEhOcUFiOWpMNlg3dTdr?=
 =?utf-8?B?WHpZZDRwMUlYSkthejAzVjk3T2YxUFlFZUxoWms4NVdZdjR0cE96cjNpQ1oz?=
 =?utf-8?Q?/j8FjCs/trb0x/chQJONqb3gUGgvosrV1mw8jjx?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e0b7a4fe-95fc-45b2-52da-08d989987afa
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Oct 2021 13:43:44.2145
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: krQRFlfXlI+XH1BYyfn6vkIcC3LZkBCz+mshjC6PhDQa7OebAE862KXWG1WFUTBKYrDdZ1+xaZK406cAJy9lxg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3935

On 06.10.2021 19:40, Rahul Singh wrote:
> --- /dev/null
> +++ b/xen/arch/arm/vpci.c
> @@ -0,0 +1,102 @@
> +/*
> + * xen/arch/arm/vpci.c
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; either version 2 of the License, or
> + * (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + */
> +#include <xen/sched.h>
> +
> +#include <asm/mmio.h>
> +
> +#define REGISTER_OFFSET(addr)  ( (addr) & 0x00000fff)

Nit: Stray blank (like you had in an earlier version for MMCFG_BDF()).
Also isn't this effectively part of the public interface (along with
MMCFG_BDF()), alongside GUEST_VPCI_ECAM_{BASE,SIZE}?

> +/* Do some sanity checks. */
> +static bool vpci_mmio_access_allowed(unsigned int reg, unsigned int len)
> +{
> +    /* Check access size. */
> +    if ( len > 8 )
> +        return false;

struct hsr_dabt's size field doesn't allow len to be above 8. I could
see that you may want to sanity check things, but that's not helpful
if done incompletely. Elsewhere you assume the value to be non-zero,
and ...

> +    /* Check that access is size aligned. */
> +    if ( (reg & (len - 1)) )

... right here you assume the value to be a power of 2. While I'm not
a maintainer, I'd still like to suggest consistency: Do all pertinent
checks or none of them (relying on the caller).

Independent of this - is bare metal Arm enforcing this same
alignment restriction (unconditionally)? Iirc on x86 we felt we'd
better synthesize misaligned accesses.

> +static int vpci_mmio_read(struct vcpu *v, mmio_info_t *info,
> +                          register_t *r, void *p)
> +{
> +    unsigned int reg;
> +    pci_sbdf_t sbdf;
> +    unsigned long data = ~0UL;

What use is this initializer? The error path further down doesn't
forward the value into *r, and subsequently the value gets fully
overwritten.

> +    unsigned int size = 1U << info->dabt.size;
> +
> +    sbdf.sbdf = MMCFG_BDF(info->gpa);

This implies segment to be zero. While probably fine for now, I
wonder if this wouldn't warrant a comment.

> +    reg = REGISTER_OFFSET(info->gpa);
> +
> +    if ( !vpci_mmio_access_allowed(reg, size) )
> +        return 0;
> +
> +    data = vpci_read(sbdf, reg, min(4u, size));
> +    if ( size == 8 )
> +        data |= (uint64_t)vpci_read(sbdf, reg + 4, 4) << 32;

Throughout this series I haven't been able to spot where the HAS_VPCI
Kconfig symbol would get selected. Hence I cannot tell whether all of
this is Arm64-specific. Otherwise I wonder whether size 8 actually
can occur on Arm32.

> +static int vpci_mmio_write(struct vcpu *v, mmio_info_t *info,
> +                           register_t r, void *p)
> +{
> +    unsigned int reg;
> +    pci_sbdf_t sbdf;
> +    unsigned long data = r;

A little like in the read function - what use is this local variable?
Can't you use r directly?

> --- a/xen/drivers/passthrough/pci.c
> +++ b/xen/drivers/passthrough/pci.c
> @@ -766,6 +766,24 @@ int pci_add_device(u16 seg, u8 bus, u8 devfn,
>      else
>          iommu_enable_device(pdev);

Please note the context above; ...

> +#ifdef CONFIG_ARM
> +    /*
> +     * On ARM PCI devices discovery will be done by Dom0. Add vpci handler when
> +     * Dom0 inform XEN to add the PCI devices in XEN.
> +     */
> +    ret = vpci_add_handlers(pdev);
> +    if ( ret )
> +    {
> +        printk(XENLOG_ERR "setup of vPCI failed: %d\n", ret);
> +        pci_cleanup_msi(pdev);
> +        ret = iommu_remove_device(pdev);
> +        if ( pdev->domain )
> +            list_del(&pdev->domain_list);
> +        free_pdev(pseg, pdev);

... you unconditionally undo the if() part of the earlier conditional;
is there any guarantee that the other path can't ever be taken, now
and forever? If it can't be taken now (which I think is the case as
long as Dom0 wouldn't report the same device twice), then at least some
precaution wants taking. Maybe moving your addition into that if()
could be an option.

Furthermore I continue to wonder whether this ordering is indeed
preferable over doing software setup before hardware arrangements. This
would address the above issue as well as long as vpci_add_handlers() is
idempotent. And it would likely simplify error cleanup.

Jan



From xen-devel-bounces@lists.xenproject.org Thu Oct 07 13:50:53 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Oct 2021 13:50:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.203605.358748 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYTnN-0000lG-9r; Thu, 07 Oct 2021 13:50:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 203605.358748; Thu, 07 Oct 2021 13:50:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYTnN-0000l9-63; Thu, 07 Oct 2021 13:50:49 +0000
Received: by outflank-mailman (input) for mailman id 203605;
 Thu, 07 Oct 2021 13:50:48 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=qfpx=O3=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mYTnM-0000l3-9t
 for xen-devel@lists.xenproject.org; Thu, 07 Oct 2021 13:50:48 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 98bfccc9-e505-40a4-a5d5-29cb1b68f799;
 Thu, 07 Oct 2021 13:50:46 +0000 (UTC)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2054.outbound.protection.outlook.com [104.47.12.54]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-19-Jsb7GDOkP0eZ6HgK53IF4w-2; Thu, 07 Oct 2021 15:50:45 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB6173.eurprd04.prod.outlook.com (2603:10a6:803:ff::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.22; Thu, 7 Oct
 2021 13:50:40 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4587.020; Thu, 7 Oct 2021
 13:50:40 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6P193CA0116.EURP193.PROD.OUTLOOK.COM (2603:10a6:209:85::21) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4566.15 via Frontend Transport; Thu, 7 Oct 2021 13:50:39 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 98bfccc9-e505-40a4-a5d5-29cb1b68f799
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1633614646;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=bAj9h/7jwI6hBIU7y69gxIxdvhNRgd5qK3UkOxnrjQo=;
	b=S+UL6RAEkvmmiJ8p/mg2KG+dFIcbjPfn/qim6k/mQTk1DlqNgONnO+ZMhssWaPZmwLZZlz
	61YhBUj7T1XvLP78qTtmBNjRVK3kHOPRclUAIhyBm7L7gUoTHLmTFEyfn7fFonWG7xTOuS
	TKY+7adWU0QZf1keEwc+IjKS4dlThwk=
X-MC-Unique: Jsb7GDOkP0eZ6HgK53IF4w-2
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ipczeTryj0bexzB5rlXrOEHb2MvjxhEuGiPleSnFi24JnTUFT9nlpQ8x/MbXmBFxSq1XHtXL5/w5rppozHeo5ANVMutNbwP9jCNHkqNFxLBejV9ivOHc5qU4AInqbrajaLaflW0aF3INeJD32UyBHoIRdUcP303dMyukxTjF3L0IOXMrSCZzmkLYHFr0RKcZ8XSkAoHtbBgeSlHExneABAIpk5HiTj5SMVBLuKAzNUHjl4kXULFGYhWiim+C18kXQ8NH/wzbuheoKdN83/wzxmSaqJS9E1lix9TPBTvp5oySQ5o2r3t4YVEHtoIlZgi4X2BnaeaXjAeJy5BwT2myjQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=bAj9h/7jwI6hBIU7y69gxIxdvhNRgd5qK3UkOxnrjQo=;
 b=kCbfWhu6901OHbXSjyPJm4PBctC9JJ+tGoOoJBULWy3hXILNxo8dtRs0h12kite1W5siH2Sog1ss4Rxl732iZ5IG7yNYKxCHlDJtMcyl3YKpF/3TJHy39y7tC2WyomIa5Yz0c4y3pjf+n6K66tsCbQfGW4KIuhL62dty6LKQVwgoH/j+3ox0J5c3kg/AUGlVnwvhU2BlF+YxwdUQCSu/aAG+7vwisedW7oQIhgW2Bg+gtVVQuJPTSMBtFhz2dFaaR3NZxdIVrBWTs8/wgYhoX6kUwlGTN/+qIaPHg61BAOQUrsJktPpwykkfRl0K+EYVmZ4OdX6QxRKOmyK7xp7tow==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [PATCH V5 1/3] xen/arm: Introduce gpaddr_bits field to struct
 xen_arch_domainconfig
To: Oleksandr <olekstysh@gmail.com>
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>,
 Anthony PERARD <anthony.perard@citrix.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Juergen Gross
 <jgross@suse.com>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 xen-devel@lists.xenproject.org
References: <1633519346-3686-1-git-send-email-olekstysh@gmail.com>
 <1633519346-3686-2-git-send-email-olekstysh@gmail.com>
 <68cb29bb-7d84-dc27-eead-4a079b9caf68@suse.com>
 <e77eea6f-163d-0920-2e90-fb9f3a602743@gmail.com>
 <ffb40f3b-2394-7747-2c06-955e2aa87cfc@suse.com>
 <387608b9-c7b2-e814-7fa5-a262acc0c73d@gmail.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <ae852345-66ff-7bcf-f68e-2161e23933a1@suse.com>
Date: Thu, 7 Oct 2021 15:50:38 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <387608b9-c7b2-e814-7fa5-a262acc0c73d@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P193CA0116.EURP193.PROD.OUTLOOK.COM
 (2603:10a6:209:85::21) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: b3a7d8e3-3c44-4c5d-92a0-08d989997322
X-MS-TrafficTypeDiagnostic: VI1PR04MB6173:
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB6173D56B035153177FC1B7ABB3B19@VI1PR04MB6173.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	IZST2X2hOu3f8iRGkGVzLfK+NZkExjhOiaa5u7CnMcaDx5MirXLbomXFKm68AHLFTdxAHOdxtdf4F5irE51w8WKxNFIZ95bTznbqk6PLGm5zVPfapPiAiicGBz5QyafPH3hF5rXHReV1IoI/p2bjuDxDSOHUNNjt15BQ2/Rihhm3upRLJ6uJ5x2Tc/vrwscZqvQTV9bx2pta0bA5rt/5I9KUdjTlqI6xz+Vn8nmI/gVcDzlnGhN2DFTOxjq8avPsYkkqGK6Srhzp4tvKL9zaui0F5C5ByO32Blk+PLyrk+pH+PuIEm/ysyI5RD3fcm7SMd+afRloAC5/UK4iBk+pvcthIszrfOIz1RHkIJEP55jsg+OLUUBDoV2CZBI79uBml070+WTt0z6n7Tb6a34FCPPYhj2TbwuH98Kv8zdifvOV4q7/zSfnrQj8aETIc6svt5lFVWIxLdR8IrSEvuv/4/VE+lBQaHQT4GM4qxWIE8/kmwyigBSiC5+WB8AEmPXnlmVPTTkLeaqUzFIdIsb50ywky7ItGbDfUeiebVgA7f/MW54IHtb4h/9wfKN7u4fz1rNCb3M3HoN9nlnVpBw+ecNG0XdivgnAjVz1Ze1w2zMCZy+xkyVrwu3tN2sF6QKXg6rOAggg50AmeM0fHaY1oBBTrgLQ6s63LbTvq4JYY/iPzvKdtV+sXBWiksvpNqVDFz3qYk/AvvCCVcfI4aqhc3rwJek8FFMGkErjHl+HzUE=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(5660300002)(31686004)(6486002)(8936002)(4326008)(2906002)(186003)(31696002)(8676002)(86362001)(316002)(16576012)(54906003)(508600001)(2616005)(7416002)(53546011)(956004)(38100700002)(36756003)(26005)(66946007)(66476007)(66556008)(83380400001)(6916009)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?WUZFOFJTNWc2NjVTTFNBMGVqZjdMaGQzQk1uMXFVa0JFVW0welY0eUE3L0hw?=
 =?utf-8?B?ZXI0NlF5QU1oVGdwSW4wUFl0MTZma2Z0NE5mSWdHZFRvZmdnMTVSS1RZRy80?=
 =?utf-8?B?aHd2dVlnd3UxZHBCYjRBN0lWOVBaUlVIVjJ2ZUFuZDlXQnl5blRCSExUVC9F?=
 =?utf-8?B?NzNmUmxIM3dUQXBpdU1teDhMTFlFZEhhQjRCTFB0Sng3R0pCV2RaNm5uNy9N?=
 =?utf-8?B?bFplM3RaWVNjZUZ6Z1BNTzFmZXRCakN3OHNINWVEY2YrYnRJWHVDT2FpbVMw?=
 =?utf-8?B?dXFTY2Jhdk9mRGtIdkFDb3hUU2MzKy9WalQ2RmZGdTBac2FGM0FMRzRvdmpx?=
 =?utf-8?B?WkFwNHRzZW04YkxocnNDaTllWG9DTjFIU0M3OWhPQ1lqQVVMS2xlVmFZZThV?=
 =?utf-8?B?dVhNNmdtaXBVR3JkQ2tBM3d4eWhCZmhFSWxDRWZobHl2YzRyRjZIUGVDbkpQ?=
 =?utf-8?B?MmU5T25UaGlDSTFmSWVlcFdNSkdUNUluc1lZaVBmT01iYnY5cXlFbXFQWHdt?=
 =?utf-8?B?Vm5xdExVaU4rNENjZnlsR0YwU3czNXQ2RThTSGdVa2w3dnIveitzRkRVTGVn?=
 =?utf-8?B?VmtjL1NEK1lmRDFIQnd0Nzd3RWRpbDJDRjZMRWNnUDFJSndTaCtHdnY1NHNp?=
 =?utf-8?B?U2ptWlFQSWZQVFE3SFFBNFNtSXg3ZldjanRncUJpeEFIY0Mrckh4QXpRK0w1?=
 =?utf-8?B?ck41WWRYRmgyWG5ONVp5OEVaelBNcUtlajZOZUxnL3J0d1llVFhDYW1SY2dk?=
 =?utf-8?B?eXBOSGtQZnZxd1JXTE5CS3J6anBEWm1jRG92ZFpDckVmM2NUS29XdjlnZWs3?=
 =?utf-8?B?VGZic0V4L0lGMkJxOVZ1SVJFekJsLzkvOVVRWE5NWE1OZ3JGd291VFJhTUJR?=
 =?utf-8?B?eUZoMFNtd0FmdUgwYlpTRGo0d0JzeVc3K0xuYmtOdkx3NFY0cFNOcGNxWTVG?=
 =?utf-8?B?VEJGNVR0R1FaV0dTbWlyTXI3OVR6VlgrZHdrRHJnMTh1dVBnemJpaWxsTmZy?=
 =?utf-8?B?Ny8zWVpuQ2N5VE41aWo0b0s0YlhKTEU4SW5FenM5dzQ0b2w5bEJjckJaWjFm?=
 =?utf-8?B?L3UyTURBSlhlaHBaSUhGc1Vic0VMUGh2TDUrRE5lR05yV1VYWUw2UktJYVQy?=
 =?utf-8?B?dlV6NWoyQlF6VVhaNUFsbTUzT0tiU2p5bnRIRVNVZnlWVExEYnZxajRmVHFH?=
 =?utf-8?B?R2xRbTdmdTFaay92UHdxandYVGtEUUdrd0ZIOExDekJONzB2UFR0dEkyWE1j?=
 =?utf-8?B?VDI3czdNNHluRkR6NXZzWnRpc0VZM3Z6b0tJTEpOeERtQUxPL2tKaGpObGhP?=
 =?utf-8?B?YWhRWXJrc0RtcTYxTzFzUkFzSCtnSlRDeEg3Rk1kUUlsV01OTkFhVE1aUU9J?=
 =?utf-8?B?aXRibWhaRUkzcTgxcEZyTWFsSEw1NXJPWXUrYlFNeHRqakZUcmgrSG83V3U0?=
 =?utf-8?B?a3c5ZFpyV1hXOW5BWkExaHcwS3FqOW9nYzhTWWNHdlFnQXFlRzM1TDJXSFlH?=
 =?utf-8?B?TG1oS0RHZTJLd08vNjgwUkJJdU9qQ3BoeWZ4cU9qM1BJT0IvenA5aHdzcDU1?=
 =?utf-8?B?VmFyWDBPbDhhMjhKaFZFTVl0NEo4dVJtM2xmdlFPYUNlT1cwSHliNndQV3NP?=
 =?utf-8?B?bWlaNDhwTEN0aENMcFNHQml0SVRsR21ubGF0RG41MzBoMTJLU1oxNk53eGhh?=
 =?utf-8?B?WmtkY1pvd0paUGFuRk50MkNJVjlzMWZEOWtlTUpNTHBnZnRaR1ZtZW80d0dS?=
 =?utf-8?Q?dJw2eCUESRKk8AJLLcdu/Mm2J1ulfZYzS9ZuoWI?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b3a7d8e3-3c44-4c5d-92a0-08d989997322
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Oct 2021 13:50:40.5512
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6WnQ8nvT9CZ8teOYncyxevvBZsNJ8xduw458DdJtewCf3XDjT0efun0L8UfbtAnlZvc+je2j2ZZl1dC5/kBN4w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6173

On 07.10.2021 15:12, Oleksandr wrote:
> 
> On 07.10.21 15:43, Jan Beulich wrote:
> 
> Hi Jan.
> 
>> On 07.10.2021 14:30, Oleksandr wrote:
>>> On 07.10.21 10:42, Jan Beulich wrote:
>>>> On 06.10.2021 13:22, Oleksandr Tyshchenko wrote:
>>>>> Changes V4 -> V5:
>>>>>      - update patch subject and description
>>>>>      - drop Michal's R-b
>>>>>      - pass gpaddr_bits via createdomain domctl
>>>>>        (struct xen_arch_domainconfig)
>>>> I'm afraid I can't bring this in line with ...
>>>>
>>>>> --- a/xen/include/public/arch-arm.h
>>>>> +++ b/xen/include/public/arch-arm.h
>>>>> @@ -333,6 +333,11 @@ struct xen_arch_domainconfig {
>>>>>         *
>>>>>         */
>>>>>        uint32_t clock_frequency;
>>>>> +    /*
>>>>> +     * OUT
>>>>> +     * Guest physical address space size
>>>>> +     */
>>>>> +    uint8_t gpaddr_bits;
>>>> ... this being an OUT field. Is this really what Andrew had asked for?
>>>> I would have expected the entire struct to be IN (and the comment at
>>>> the top of the containing struct in public/domctl.h also suggests so,
>>>> i.e. your new field renders that comment stale). gic_version being
>>>> IN/OUT is already somewhat in conflict ...
>>> I am sorry but I'm totally confused now, we want the Xen to provide
>>> gpaddr_bits to the toolstack, but not the other way around.
>>> As I understand the main ask was to switch to domctl for which I wanted
>>> to get some clarification on how it would look like... Well, this patch
>>> switches to use
>>> domctl, and I think exactly as it was suggested at [1] in case if a
>>> common one is a difficult to achieve. I have to admit, I felt it was
>>> indeed difficult to achieve.
>> Sadly the mail you reference isn't the one I was referring to. It's not
>> even from Andrew. Unfortunately I also can't seem to be able to locate
>> this, i.e. I'm now wondering whether this was under a different subject.
>> Julien, in any event, confirmed in a recent reply on this thread that
>> there was such a mail (otherwise I would have started wondering whether
>> the request was made on irc). In any case it is _that_ mail that would
>> need going through again.
> 
> I think, this is the email [1] you are referring to.

Well, that's still a mail you sent, not Andrew's. And while I have yours
in my mailbox, I don't have Andrew's for whatever reason.

Nevertheless there's enough context to be halfway certain that this
wasn't meant as an extension to the create domctl, but rather a separate
new one (merely replacing what you had originally as a sysctl to become
per-domain, to allow returning varying [between domains] values down the
road). I continue to think that if such a field was added to "create",
it would be an input (only).

Jan



From xen-devel-bounces@lists.xenproject.org Thu Oct 07 13:55:34 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Oct 2021 13:55:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.203614.358759 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYTrw-0001QA-Rx; Thu, 07 Oct 2021 13:55:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 203614.358759; Thu, 07 Oct 2021 13:55:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYTrw-0001Q3-Of; Thu, 07 Oct 2021 13:55:32 +0000
Received: by outflank-mailman (input) for mailman id 203614;
 Thu, 07 Oct 2021 13:55:31 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=qfpx=O3=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mYTrv-0001Px-8H
 for xen-devel@lists.xenproject.org; Thu, 07 Oct 2021 13:55:31 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 3b299264-2776-11ec-bfd3-12813bfff9fa;
 Thu, 07 Oct 2021 13:55:30 +0000 (UTC)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2057.outbound.protection.outlook.com [104.47.13.57]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-38-FpFaHU-mNdS7FEReOOdc7g-1; Thu, 07 Oct 2021 15:55:28 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0401MB2335.eurprd04.prod.outlook.com (2603:10a6:800:2e::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.22; Thu, 7 Oct
 2021 13:55:25 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4587.020; Thu, 7 Oct 2021
 13:55:25 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS8P251CA0017.EURP251.PROD.OUTLOOK.COM (2603:10a6:20b:2f2::30) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4566.16 via Frontend Transport; Thu, 7 Oct 2021 13:55:24 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3b299264-2776-11ec-bfd3-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1633614929;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=CxjmdxmbnrQDxbOkItSr5gx3PX5yYxKewKipBY8RKaE=;
	b=Vz8sWQFM9N6GddEFMBj/ElPqjbj5W6fbaJDbLRk/lZQrkvv8LunkE1jK9XVc9BKYWxJ4eo
	1abKWdFyNmj61eoBodVKYe9OdtQ/qv2xOLXfZXLzzV6uTPb2+3NITugh4Mwdb+DDoUrvyz
	19J3afj/0lO1naNRe1S4xx8Sc3wKNkk=
X-MC-Unique: FpFaHU-mNdS7FEReOOdc7g-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=jrf/Z66JGgGZPCLa3pJ+6lbTYBocG41QxgfBR9mYnFFn6/dgGlkcaWEkINyTEUk8I5wWFoSbztuG5NZf95luBBi8Kfq85CbNCF/uLQD6rV4wNLQYUPK5d9+QvQiY7B1qBLUQogIzqw89wYOL+RKxcG6Qc+5QF8cIZzb4DK82F+nWRYOdl4NvzEFN/7G72DwKPuk2wy/4/lo8l358towaOKVZ9l/MAImkoufpQQGWGq9/+ssAvOQB9FjOQfZEWApJmS+//gaSYTkAKxpocW9INzibP1qFaUiQcFJGAJbanDgIHBAE23DDP0bv9rXNaN3hXCv+i2L5TkxOm9xITmkb6w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=CxjmdxmbnrQDxbOkItSr5gx3PX5yYxKewKipBY8RKaE=;
 b=IwNHhpFpxY7/l7eNh/zQQLAPMq7gKXHiHR9Mj9zd3nSByLMCu7eC3wwJXWOJnbB3YdmZ7uWg8rfMjNwsHdEE31JhuxnRbK1vFnqkNvcxc+n4t9cetPVRA7praPMcmJZKgtwqBKR9kRO4NfFTHEUGDWKMqQlphriIi9AcDfFkPwBHFeMaTKHJ1KR9fxT0O1cXl4cmlVeiHaEVd7GOAw/Jsc3RU2WieP9bdbQ5BEv+HDnyqXWdx/4k3DPwmdSeU5sFBeWDIff+PTWMR+oZENDD+D1k6pCE2lUA3vLPoVyz4LsdaoMyu4zWhAD/zz5TJQRC2cYbh82Kjw+CqM/xmmtunQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [XEN PATCH v7 13/51] build: convert binfile use to if_changed
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>, Daniel De Graaf <dgdegra@tycho.nsa.gov>,
 "Daniel P. Smith" <dpsmith@apertussolutions.com>,
 xen-devel@lists.xenproject.org
References: <20210824105038.1257926-1-anthony.perard@citrix.com>
 <20210824105038.1257926-14-anthony.perard@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <24583a2a-7fe8-14cd-7705-89e031433932@suse.com>
Date: Thu, 7 Oct 2021 15:55:23 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <20210824105038.1257926-14-anthony.perard@citrix.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8P251CA0017.EURP251.PROD.OUTLOOK.COM
 (2603:10a6:20b:2f2::30) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 7a7e11f0-f7d4-477e-30c0-08d9899a1d0f
X-MS-TrafficTypeDiagnostic: VI1PR0401MB2335:
X-Microsoft-Antispam-PRVS:
	<VI1PR0401MB2335462E2E57970234430EABB3B19@VI1PR0401MB2335.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:3826;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	0qTpnqtAIRzFbqgfrurcpRJRKHe2Crl9ilIoWqkJhx58Z1B8TOE+nj2qqoocld13UvB59MA/sOncOgO8G+dQOeGP7Rj6KqFBqrv7QNfDEcIRDvkYGlrek+5iXRmIQv9Uczy/zUZOhqvyNfRbG9jp3XPhqFwoP/Cv89lwwNGP7KgQIij/jamSoEsgb8TLbU3RhtSdLFW9G8W0xQ/fJfUHl37j7jpT+cjRQtvHJEjG1qy+fClhyR6cS9wSFbdJtoHppCKGCqESJQWyppNBySq+qQANQQqC++F9i+ceRwJuFktSA9ONpPhJRwx/31F8KrZs8tv4NJG2lRZ8oV6uh3Snj/uiw3mf7tlUCOxclGr1MikBp1qaxBHWdzUuBX5hMePhj+0ibP0uf8ASYU1Abjb81Uen9xM3zLVYMdrmMBeEajujB+BmEVIS1ccNrtUe/DqMe8u/1UkFibt5B9Py1aNtaKdpdOYXd5M+q8Y/C/BlVFCKtCKpha5OpjqaGUpjZqscEuhQY0286GcbaoxXeuZ8FocLKz01Cv7QHlVy5f4JRYtdtGRiNBBjOLxSKbxTBh3TuocyY7bMJoA3YgEMZRIERhwOZD16EZbQpikWQHoRnYYiNluuFCJkPsIQzf1jx5/RCWeXuJgThg01fBKuixz65YyRVxxdzrEFgvV+voK4MbcH5koCYgJR4f5Vesuu/cqxQsq9TlFTkj3czZVDy+8Q8/DbPM4lxsnvbYhfEwFX2bQ=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(2616005)(956004)(508600001)(5660300002)(6486002)(36756003)(6916009)(53546011)(16576012)(54906003)(316002)(8936002)(8676002)(2906002)(558084003)(31696002)(83380400001)(4326008)(186003)(66476007)(86362001)(7416002)(26005)(66556008)(66946007)(31686004)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?WHdmZVNUd2VGM0FMSjNFOG9BZVUrRHg4SjMwNENrSkhpU1UwREh6MXlHanVO?=
 =?utf-8?B?aHVYS0U4OWlxWHJSajlEY0p0aHh5aFA5T05VeG9aNVUxaENNVTlNZ2FuYVl6?=
 =?utf-8?B?Q042UjVpTmJiMlk3cUVkNFptYW1xaExBdGNuUVg3NDFIT2tXWVJtWG5sVnNG?=
 =?utf-8?B?Y0JYSGdWZ1BvTzQ1aTR3SWROWUI3M1FtaFZuQWgwcHpGaS9oNFZaMVlERlVJ?=
 =?utf-8?B?a2JmdlBmeGNiV0tKUjdnZStCWi9zK0N2cDkwem5yNUl4UDRmbHM1d2phVzA0?=
 =?utf-8?B?ODM2UUZOaUNxc1N6VGVRbGJ1QW1JbXF3b0ZRWUNjamFPWFRXSy9nL1ZqNUtU?=
 =?utf-8?B?SlB5TmtBMllLQVJzSE1jN2VZclNUTitLTzJaRVk2MFFYZnZRUjhTTXdrK0w4?=
 =?utf-8?B?ZExoc3BhNU9hTzdkdXhuMFl3dllFRmZFTnBmc3I2VFIvc3ZqWDdHWVpBMFR0?=
 =?utf-8?B?UXZMbEYxcEswb0FpT1N0aitzY1V0TEtDUEVDQ3VsL3dOYnBvV21QOU9jN3pU?=
 =?utf-8?B?SWZMM2NRcGRHV3FqNGNMZ1dtT2hWdzI0V2ZNSmlVUjNycjUrZVZ1V3FjWXZp?=
 =?utf-8?B?Y3ErRzRzeVM5MHlUMzZGdW45QUMxTVdxcmN5Rlg3NzdiTkswY29SaFYvUnht?=
 =?utf-8?B?Z21INmVCQ3EvZlA1bVBxSHYwSDcxckQ2SXJZZExYdzR3cEZQNldab29pZlN4?=
 =?utf-8?B?WTRPNitPQ2tJaE9RTVJWWmYxRmJ5d2dNbk13aGRpK3dSZ2pMQzMzcDJwalBy?=
 =?utf-8?B?V2lYcEh1ZmxMdEZ6SWhGcVFYK2lpMmN2TGJsVzdRamtGQVloQ0dTRFRMTU5C?=
 =?utf-8?B?d25JeXFKV0t0Z1ZkdGJEMmlvQTBZMitudnAvSXhTVmVRdWZaQThGaHJpVDVJ?=
 =?utf-8?B?V2tkRlU1RDBkam9OU2pWZHIxdjZFbVk1ZStpQlcvTEFId0lhNGhTblIrK0FI?=
 =?utf-8?B?bHJyVUk3cysySS91TmhNR3B0UEpBMEpmYkZ4aDZ0b2xYN3FjN3BGTXJWTVZn?=
 =?utf-8?B?Ymp6SjQ5RnhXaGtCWEN3cDYrNnlUYzRQOWU4bGduUHBpNGVRRXRCZys3VHVk?=
 =?utf-8?B?VDV5WWJOeGpVN3dDZnFRK1ZiLzYzNXpxWlMrKzFGRUFwbmQ4c0dWVW9RdVc4?=
 =?utf-8?B?WCtEZFZRNEpqVEZHalJMTVNiVDZ2N0J6cjYvMU9ROWo4YkpRWkF6WGU1MHAw?=
 =?utf-8?B?SkZ1U2pEL21ncHBSWWhVZnYxNnh5djhQS3pyRTk3UWQ4aU9QZ0s3RWFXdXZV?=
 =?utf-8?B?NmI5ekVERHJVa3VqNzZMM2xjalBPTVVsYzFyVXZOTmQ2aUVmZkxpd0N1RTdF?=
 =?utf-8?B?NWRqWE84RFNlcWhOLzVYUU41QUZadDBPdUtyb25nVS9Cbys1Zy83UTJZTS9v?=
 =?utf-8?B?RlJKSUhZL0RjY0xRZUFsclA3Z1dyUitWeGNBOTNUZEJLU3lrejdmVXp6RjNz?=
 =?utf-8?B?QjloU1VXNVRlM3hPQUc1VVZWTUN3b2o2dTlEcG1kMnhlcHV5cHZPVVdhU0F4?=
 =?utf-8?B?d1Vva1ZmSmx6K0Qrc29hQ2RVaitmdHRuSjVGdWxPMzJsVXlpSVcvODF6WGVF?=
 =?utf-8?B?YVJzYWpwTjZYdWJsQjJTblhhWTdmekxLdkxkTnIyWXIvMFhhM0ltSDhKZHZs?=
 =?utf-8?B?N2VXSHpncW5mTzdWNjNVZ0k4Y2dmcWlPckN5ekpzcGJoU24wdWJkMEd3VzBZ?=
 =?utf-8?B?WlFnOC9kMFl1dzdhSFpoNW5UbTNqSGRPOExHYVh0UzJFT04zRzEzb0lWUE93?=
 =?utf-8?Q?Iti6jB+qQkrBNQxNa7rhvYKWHPhYa/EtTHpS0Jg?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7a7e11f0-f7d4-477e-30c0-08d9899a1d0f
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Oct 2021 13:55:25.6198
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: pG2UK/TX2t5Zs9p1+SDaYd7AGODPUY5TYaqdR9v+ZSDjYuJemcpUDuRFRiGIZIvEoXMVFr8htytpag/fCDlJxw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2335

On 24.08.2021 12:50, Anthony PERARD wrote:
> This will allow to detect command line changes and allow to regenerate
> the file in that case.
> 
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>

Acked-by: Jan Beulich <jbeulich@suse.com>



From xen-devel-bounces@lists.xenproject.org Thu Oct 07 14:00:09 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Oct 2021 14:00:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.203625.358770 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYTwK-0002lL-JZ; Thu, 07 Oct 2021 14:00:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 203625.358770; Thu, 07 Oct 2021 14:00:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYTwK-0002ks-EZ; Thu, 07 Oct 2021 14:00:04 +0000
Received: by outflank-mailman (input) for mailman id 203625;
 Thu, 07 Oct 2021 14:00:04 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mYTwJ-0002f3-UP; Thu, 07 Oct 2021 14:00:03 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mYTwJ-0004PQ-NH; Thu, 07 Oct 2021 14:00:03 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mYTwJ-0003dx-F1; Thu, 07 Oct 2021 14:00:03 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mYTwJ-0000IX-ET; Thu, 07 Oct 2021 14:00:03 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=Nv4XsbRn5TfG65aadNO3o7SOK1P4ocecm8jKR8IqzYI=; b=yk/1ZzgXphcux5p36l6PyWoAQM
	OsR/WfADzKAGd5yaXfrafrV/YuEsIpjAxxaR246SEZb+ElbTtD9oVeOc86klLqK0AdsdY+br7srWt
	kYOSWovOdPanxrjE9BhmbuOjLvjtGL+vbdZuq3Z/JwF2kFJhYt9/jzVw6u/qJgYLQcig=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165395-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 165395: regressions - FAIL
X-Osstest-Failures:
    libvirt:build-amd64-libvirt:libvirt-build:fail:regression
    libvirt:build-armhf-libvirt:libvirt-build:fail:regression
    libvirt:build-arm64-libvirt:libvirt-build:fail:regression
    libvirt:build-i386-libvirt:libvirt-build:fail:regression
    libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    libvirt=f60bc4f6208696efbe87fab22ccca8345381a6e1
X-Osstest-Versions-That:
    libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 07 Oct 2021 14:00:03 +0000

flight 165395 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165395/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-armhf-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-arm64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-i386-libvirt            6 libvirt-build            fail REGR. vs. 151777

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-libvirt-vhd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a

version targeted for testing:
 libvirt              f60bc4f6208696efbe87fab22ccca8345381a6e1
baseline version:
 libvirt              2c846fa6bcc11929c9fb857a22430fb9945654ad

Last test of basis   151777  2020-07-10 04:19:19 Z  454 days
Failing since        151818  2020-07-11 04:18:52 Z  453 days  438 attempts
Testing same since   165395  2021-10-06 04:21:02 Z    1 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
    Adolfo Jayme Barrientos <fitoschido@gmail.com>
  Aleksandr Alekseev <alexander.alekseev@virtuozzo.com>
  Aleksei Zakharov <zaharov@selectel.ru>
  Andika Triwidada <andika@gmail.com>
  Andrea Bolognani <abologna@redhat.com>
  Ani Sinha <ani@anisinha.ca>
  Balázs Meskó <meskobalazs@mailbox.org>
  Barrett Schonefeld <bschoney@utexas.edu>
  Bastian Germann <bastiangermann@fishpost.de>
  Bastien Orivel <bastien.orivel@diateam.net>
  BiaoXiang Ye <yebiaoxiang@huawei.com>
  Bihong Yu <yubihong@huawei.com>
  Binfeng Wu <wubinfeng@huawei.com>
  Bjoern Walk <bwalk@linux.ibm.com>
  Boris Fiuczynski <fiuczy@linux.ibm.com>
  Brian Turek <brian.turek@gmail.com>
  Bruno Haible <bruno@clisp.org>
  Chris Mayo <aklhfex@gmail.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Ehrhardt <christian.ehrhardt@canonical.com>
  Christian Kirbach <christian.kirbach@gmail.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Cole Robinson <crobinso@redhat.com>
  Collin Walling <walling@linux.ibm.com>
  Cornelia Huck <cohuck@redhat.com>
  Cédric Bosdonnat <cbosdonnat@suse.com>
  Côme Borsoi <fedora@borsoi.fr>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniel Letai <dani@letai.org.il>
  Daniel P. Berrange <berrange@redhat.com>
  Daniel P. Berrangé <berrange@redhat.com>
  Didik Supriadi <didiksupriadi41@gmail.com>
  dinglimin <dinglimin@cmss.chinamobile.com>
  Dmytro Linkin <dlinkin@nvidia.com>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Eric Farman <farman@linux.ibm.com>
  Erik Skultety <eskultet@redhat.com>
  Fabian Affolter <mail@fabian-affolter.ch>
  Fabian Freyer <fabian.freyer@physik.tu-berlin.de>
  Fabiano Fidêncio <fabiano@fidencio.org>
  Fangge Jin <fjin@redhat.com>
  Farhan Ali <alifm@linux.ibm.com>
  Fedora Weblate Translation <i18n@lists.fedoraproject.org>
  gongwei <gongwei@smartx.com>
  Guoyi Tu<tu.guoyi@h3c.com>
  Göran Uddeborg <goeran@uddeborg.se>
  Halil Pasic <pasic@linux.ibm.com>
  Han Han <hhan@redhat.com>
  Hao Wang <wanghao232@huawei.com>
  Hela Basa <r45xveza@pm.me>
  Helmut Grohne <helmut@subdivi.de>
  Hiroki Narukawa <hnarukaw@yahoo-corp.jp>
  Ian Wienand <iwienand@redhat.com>
  Jakob Meng <jakobmeng@web.de>
  Jamie Strandboge <jamie@canonical.com>
  Jamie Strandboge <jamie@ubuntu.com>
  Jan Kuparinen <copper_fin@hotmail.com>
  jason lee <ppark5237@gmail.com>
  Jean-Baptiste Holcroft <jean-baptiste@holcroft.fr>
  Jia Zhou <zhou.jia2@zte.com.cn>
  Jianan Gao <jgao@redhat.com>
  Jim Fehlig <jfehlig@suse.com>
  Jin Yan <jinyan12@huawei.com>
  Jinsheng Zhang <zhangjl02@inspur.com>
  Jiri Denemark <jdenemar@redhat.com>
  John Ferlan <jferlan@redhat.com>
  Jonathan Watt <jwatt@jwatt.org>
  Jonathon Jongsma <jjongsma@redhat.com>
  Julio Faracco <jcfaracco@gmail.com>
  Justin Gatzen <justin.gatzen@gmail.com>
  Ján Tomko <jtomko@redhat.com>
  Kashyap Chamarthy <kchamart@redhat.com>
  Kevin Locke <kevin@kevinlocke.name>
  Kristina Hanicova <khanicov@redhat.com>
  Laine Stump <laine@redhat.com>
  Laszlo Ersek <lersek@redhat.com>
  Lee Yarwood <lyarwood@redhat.com>
  Lei Yang <yanglei209@huawei.com>
  Liao Pingfang <liao.pingfang@zte.com.cn>
  Lin Ma <lma@suse.com>
  Lin Ma <lma@suse.de>
  Lin Ma <morecache@gmail.com>
  Liu Yiding <liuyd.fnst@fujitsu.com>
  Luke Yue <lukedyue@gmail.com>
  Luyao Zhong <luyao.zhong@intel.com>
  Marc Hartmayer <mhartmay@linux.ibm.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Markus Schade <markus.schade@hetzner.com>
  Martin Kletzander <mkletzan@redhat.com>
  Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
  Matej Cepl <mcepl@cepl.eu>
  Matt Coleman <matt@datto.com>
  Matt Coleman <mcoleman@datto.com>
  Mauro Matteo Cascella <mcascell@redhat.com>
  Meina Li <meili@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Michał Smyk <fedora@smyk.it>
  Milo Casagrande <milo@milo.name>
  Moshe Levi <moshele@nvidia.com>
  Muha Aliss <muhaaliss@gmail.com>
  Nathan <nathan95@live.it>
  Neal Gompa <ngompa13@gmail.com>
  Nick Chevsky <nchevsky@gmail.com>
  Nick Shyrokovskiy <nshyrokovskiy@gmail.com>
  Nickys Music Group <nickys.music.group@gmail.com>
  Nico Pache <npache@redhat.com>
  Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
  Olaf Hering <olaf@aepfle.de>
  Olesya Gerasimenko <gammaray@basealt.ru>
  Orion Poplawski <orion@nwra.com>
  Pany <geekpany@gmail.com>
  Patrick Magauran <patmagauran.j@gmail.com>
  Paulo de Rezende Pinatti <ppinatti@linux.ibm.com>
  Pavel Hrdina <phrdina@redhat.com>
  Peng Liang <liangpeng10@huawei.com>
  Peter Krempa <pkrempa@redhat.com>
  Pino Toscano <ptoscano@redhat.com>
  Pino Toscano <toscano.pino@tiscali.it>
  Piotr Drąg <piotrdrag@gmail.com>
  Prathamesh Chavan <pc44800@gmail.com>
  Richard W.M. Jones <rjones@redhat.com>
  Ricky Tigg <ricky.tigg@gmail.com>
  Robin Lee <cheeselee@fedoraproject.org>
  Roman Bogorodskiy <bogorodskiy@gmail.com>
  Roman Bolshakov <r.bolshakov@yadro.com>
  Ryan Gahagan <rgahagan@cs.utexas.edu>
  Ryan Schmidt <git@ryandesign.com>
  Sam Hartman <hartmans@debian.org>
  Scott Shambarger <scott-libvirt@shambarger.net>
  Sebastian Mitterle <smitterl@redhat.com>
  SeongHyun Jo <caelus9536@gmail.com>
  Shalini Chellathurai Saroja <shalini@linux.ibm.com>
  Shaojun Yang <yangshaojun@phytium.com.cn>
  Shi Lei <shi_lei@massclouds.com>
  simmon <simmon@nplob.com>
  Simon Chopin <chopin.simon@gmail.com>
  Simon Gaiser <simon@invisiblethingslab.com>
  Simon Rowe <simon.rowe@nutanix.com>
  Stefan Bader <stefan.bader@canonical.com>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Berger <stefanb@linux.vnet.ibm.com>
  Stefan Hajnoczi <stefanha@gmail.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Szymon Scholz <szymonscholz@gmail.com>
  Thomas Huth <thuth@redhat.com>
  Tim Wiederhake <twiederh@redhat.com>
  Tomáš Golembiovský <tgolembi@redhat.com>
  Tomáš Janoušek <tomi@nomi.cz>
  Tuguoyi <tu.guoyi@h3c.com>
  Victor Toso <victortoso@redhat.com>
  Ville Skyttä <ville.skytta@iki.fi>
  Vinayak Kale <vkale@nvidia.com>
  Wang Xin <wangxinxin.wang@huawei.com>
  WangJian <wangjian161@huawei.com>
  Weblate <noreply@weblate.org>
  Wei Liu <liuwe@microsoft.com>
  Wei Liu <wei.liu@kernel.org>
  William Douglas <william.douglas@intel.com>
  Yalei Li <274268859@qq.com>
  Yalei Li <liyl43@chinatelecom.cn>
  Yang Fei <yangfei85@huawei.com>
  Yang Hang <yanghang44@huawei.com>
  Yanqiu Zhang <yanqzhan@redhat.com>
  Yaroslav Kargin <ykargin@virtuozzo.com>
  Yi Li <yili@winhong.com>
  Yi Wang <wang.yi59@zte.com.cn>
  Yuri Chornoivan <yurchor@ukr.net>
  Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
  zhangjl02 <zhangjl02@inspur.com>
  Zheng Chuan <zhengchuan@huawei.com>
  zhenwei pi <pizhenwei@bytedance.com>
  Zhenyu Ye <yezhenyu2@huawei.com>
  Zhenyu Zheng <zheng.zhenyu@outlook.com>
  Zhenzhong Duan <zhenzhong.duan@intel.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          fail    
 build-arm64-libvirt                                          fail    
 build-armhf-libvirt                                          fail    
 build-i386-libvirt                                           fail    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           blocked 
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-libvirt-xsm                                 blocked 
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-libvirt                                     blocked 
 test-arm64-arm64-libvirt                                     blocked 
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-libvirt-pair                                blocked 
 test-amd64-i386-libvirt-pair                                 blocked 
 test-arm64-arm64-libvirt-qcow2                               blocked 
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-libvirt-vhd                                 blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 76926 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Oct 07 14:17:50 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Oct 2021 14:17:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.203635.358783 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYUDJ-0004dg-2R; Thu, 07 Oct 2021 14:17:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 203635.358783; Thu, 07 Oct 2021 14:17:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYUDI-0004dZ-VP; Thu, 07 Oct 2021 14:17:36 +0000
Received: by outflank-mailman (input) for mailman id 203635;
 Thu, 07 Oct 2021 14:17:36 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=qfpx=O3=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mYUDI-0004dT-3u
 for xen-devel@lists.xenproject.org; Thu, 07 Oct 2021 14:17:36 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 0e03e6f4-d44d-4d61-b349-f007d8383b0a;
 Thu, 07 Oct 2021 14:17:35 +0000 (UTC)
Received: from EUR03-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur03lp2051.outbound.protection.outlook.com [104.47.9.51]) (Using
 TLS) by relay.mimecast.com with ESMTP id de-mta-1-2STr7CtWO4CP8P1Dz0huKg-1;
 Thu, 07 Oct 2021 16:17:33 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB3296.eurprd04.prod.outlook.com (2603:10a6:802:7::19) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.15; Thu, 7 Oct
 2021 14:17:31 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4587.020; Thu, 7 Oct 2021
 14:17:31 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6PR05CA0032.eurprd05.prod.outlook.com (2603:10a6:20b:2e::45) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4587.18 via Frontend Transport; Thu, 7 Oct 2021 14:17:29 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0e03e6f4-d44d-4d61-b349-f007d8383b0a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1633616254;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=xm3uB+uhp1nHeBTNBvh/sipFoncXa52J8/s1SQ6dXLs=;
	b=LJJMspOxLYDoSKBThQ3EWkRuhv5QpR2h3nmDKaqBZHOL/j1v7jxgJn/YALa3yMxJbbT4Rc
	wII34Bc1ybyv/q5AWz9EbEPyeRDmP1NHZXFB5zaDVXWrQ2ggu5Bs1aGG4IwvUnKk8po0at
	Gpit3kJqCXyg5XhSwA8SVmye+fu3wW8=
X-MC-Unique: 2STr7CtWO4CP8P1Dz0huKg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Qd1wuRhdkQimvh9m/GYzZZ2XIb5oBuj0AUQmdNaGuDXGfpaGOSr5bR8rug6hxgeUWU1LTtZhKT1SuvMd/kGviI8DbFBfVLI/D/8s/WD3cGA4LxO3z/1RRP5QCINdvHTzOhc1WMuOYRF2FIPJC9z4QxCgDaCxFOVrKZItPm+Hj2oxhrVichNVykLtDV7f/UmFvDXTAd4bL0l1GMktezyY8Kk4fvXtTwHoeEPMN4t23JLPzKRMJtWG3n3u2ZE8v1y6MpPuCLkbGPuDT6BXhbUVk9RQsUovWjBWRKtkIo+01aHdp7s6CPmsyWiMBkxMZwB4CP+XrIZR65kJXz8XM+7Z0A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=xm3uB+uhp1nHeBTNBvh/sipFoncXa52J8/s1SQ6dXLs=;
 b=fG+Jiz5/78jmXNY57D87cPtCPn0ct1Ckkdo2gIv+5iQy6l75O0ICol8nmtEF3UrE5w4zjLnzcPqcmmZF8Jb2vqs7mA8N1NhHOKXORrCdjveflQjT6iVM/C+HlIk1yfKc9zAjtiFGOS0RP744Nwcdrv8kmcqc1R5hBr0Ps2caz8joaX4Dxh8ybQqNaV6RhfRGBqI4d+FhdzJK9ex/7lRs/33rNzZTCaBm2F46k7M+JhDY/ccLim04ThVxnfhcRGNf6Zt+Y46Ia/fBoYkk/2RhKGlxok5Nk0Kzeb9ZMKkpKynBtA8cajKgALB7/kmsaAcfMXLiGg73NjBa/Gwqzpkblw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [XEN PATCH v7 14/51] xen: move include/asm-* to
 arch/*/include/asm
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: Paul Durrant <paul@xen.org>, Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>, Tamas K Lengyel <tamas@tklengyel.com>,
 Alexandru Isaila <aisaila@bitdefender.com>,
 Petre Pircalabu <ppircalabu@bitdefender.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
 Ross Lagerwall <ross.lagerwall@citrix.com>,
 Bob Eshleman <bobbyeshleman@gmail.com>,
 Alistair Francis <alistair.francis@wdc.com>,
 Connor Davis <connojdavis@gmail.com>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>, Jun Nakajima <jun.nakajima@intel.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Lukasz Hawrylko <lukasz.hawrylko@linux.intel.com>,
 xen-devel@lists.xenproject.org
References: <20210824105038.1257926-1-anthony.perard@citrix.com>
 <20210824105038.1257926-15-anthony.perard@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <320e5dde-2017-2420-8323-cbe4c2f0914f@suse.com>
Date: Thu, 7 Oct 2021 16:17:28 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <20210824105038.1257926-15-anthony.perard@citrix.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR05CA0032.eurprd05.prod.outlook.com
 (2603:10a6:20b:2e::45) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: dfb78ac7-69f3-4066-a92f-08d9899d334d
X-MS-TrafficTypeDiagnostic: VI1PR04MB3296:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB32963A3C3E7F1B14D4255F6FB3B19@VI1PR04MB3296.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:1824;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	1xqKugtQsTLgRsslICb5CUa4zyqGMYzMEoAf4hRrx+p2uegThFR658K5kDJfAXJ0zlQ/R/XgMp6opwjR59vM3nJxy7o16WdsI309YTTlPaVjJyIT0ZsrhIvmTBeHgNYcws2NtLpJHU3/XvC0XF2VdCP9lV6yraD2w6Z+By6nsAV3DuhvkJbz3DE3nhFmbL1KHxqnLdsw6+Lp4phOnGtzXKq9wNbucwCmh3UOZEykYirTYXz+oiG24xXzcR+LAddH+W+ak0bIeFQhJ9yZCovm78Iq1wdsaTiHTuCOdszT0S4ahWAYgTkbRN6QAeVx+oQb2jXLlk63/tpFUj5VOqO5ID+ApTp2cWAusCtB/doaZjtwwrkRJ7fKMYS3yD02UnvxU/rn0fF/a2TTwbWDxLEi1dKmfub0S7zNENIu5oRgNzHvrNZaxKNloZqIbCxb39YgLDyz+WQ+3WzFcYVdDFzjGLRDTtEDAd8kx0kdxxlT9brZpRWG3x7oLn9RfdJAs/3DfOaHInyqTnkQai/sEWdY6yUoqAPng9/j69hhGH8PwFf2t7iR4dq7q/yhFbcpKFhgrHkfvzu3po350EvVbasZP322mElo6bnqHX16MJi1RGdWwLBbPzRh5mN5p3Mfh0qc49tthH9OeUF26dD3dUCLMDftAf6J0cdUtbhSiXq2YBRIiv/1t73cUqdUmLCuAQWbXCtndY+i1SwLRCVDRvd3S5q1JZY4blS1B/3JoRMtseBDRB+pV5vU9SUvgX5x8j62
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(316002)(2906002)(16576012)(66946007)(956004)(8936002)(31696002)(66476007)(66556008)(4326008)(2616005)(508600001)(6486002)(54906003)(7416002)(86362001)(6916009)(26005)(38100700002)(31686004)(8676002)(5660300002)(186003)(53546011)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?UHFxVng3TFJxUWhlZlRRMVhVMTNMU2tReXlIZjlBSmZycE95V2ROWStyWXp4?=
 =?utf-8?B?cDZSY0JsdmxpcUJoWUxFNUhBOStLNklJTkdEMm9od2d0ZDRuN0lKN0tsWldv?=
 =?utf-8?B?VWJaSFdrV3JRUFNRaENGeEhkd1ovdUFmTHZ4cVFEMHRoSWJwVkZXQkhURXpy?=
 =?utf-8?B?cGpZUUNsemV1VktTczN3ZUp5MkRjSUlXM1ZXRkZ5b25wNlkxc1NheTNBYlhV?=
 =?utf-8?B?ZFR1eWhMRjhCQ2JEd3lJZ1l1ai9GM3dnWFR3Q1J4WTZadkVDa3JUTDhELzEx?=
 =?utf-8?B?VkxmYmErbVBGREhWSW1CQU5IKzBYajd1bzV2UzZ1SitlL1JFRW50bCtSWHd0?=
 =?utf-8?B?U2ZJUGM1TG9FU3JVWTFFWTdQNER0cmRiYjdlWitBZi9HVFFBTkhlNVErWlZh?=
 =?utf-8?B?bmFLb0NTK0NJOXljMEh3Q3VOem0wQjI5WEFvdU9Wa0lvVmdJRDJ0a3NYNXFa?=
 =?utf-8?B?NUh3SDg4MDJKODcrMUV6Y2R3K2FqdThrSUNhL2NxZ2xaa1JhaWszdXJtK2dm?=
 =?utf-8?B?Wkt3UWlrY29mZ3YyK0p0ZDlqaEYya3VZWUJWK2NHVzNTVFdaVjQ4ZDZZbTJK?=
 =?utf-8?B?L1BHWm1XY0N5TTkxQm03Ty9malc2dXN1dmNMc1J6bm5KaDRrWHdteUF0bkZ3?=
 =?utf-8?B?SS9BbjQzYlBqZnFDOHUxTmJjUGh3dkljWThGRWZhUEhxZFpDMXczRmkwc0pa?=
 =?utf-8?B?Yml2SmpWNERRcnA2OVFuRjVOcXBvakNtNm01cXQ0NVlzQTQxdVRrMXlyZDhG?=
 =?utf-8?B?T1Z0ZEtkRTVmaFd3NlJJelRRMWYvZHlNQm5nNzV0SVhFeU93eThJYzE3T0J4?=
 =?utf-8?B?N25rbWtGaFFNQ0VLUDJNQy8zdmhYUjVDYW5KYkVTMlRqSWRTSDl6cDZYU0xr?=
 =?utf-8?B?Ry9oNHVRaHJpS3J5WnpIci9uay9LdFpxZlZiTGRnb0tBVTNRWUxSRU9zMTE2?=
 =?utf-8?B?aldUalJBMExoZ2FOZExxRHdJNkQ3RmdRNWpUUGJjZy9ueG9xTlZwdDJia0hT?=
 =?utf-8?B?RHVBMnl6M3pneSttWmp4NE4weGF1aEZCalFSTWVTZ0JiUnZwMW44N3FQNjI1?=
 =?utf-8?B?Qm5pVHgzSUd2VnR0T2xHNkNFSmJMOFlGWlB5SWV1bm9Mdm9ETUZkWWRGbEl3?=
 =?utf-8?B?UlNrRGhqTU95bjVCc3RGYXppQzdhRFIzbnh3azFOaThwNTBtYU03U3k5N1lE?=
 =?utf-8?B?Ujl4ZEFJenRWbzVXeHUzV2lTcUJoZkcyTi9OTkNsYzBTV3F2ay9jclFKYUJG?=
 =?utf-8?B?a3cwZnBYOVpWb3RpWjNHNmdQUWJ3bm9QbmR6a0dtNjIzYldESTN0WVp1cUtX?=
 =?utf-8?B?WWJaTDVJcE5TeGsyOWZJOHU4L21YcGpWRWFaemhldHdZbEFGRUlnMHRJS1Vp?=
 =?utf-8?B?RzQyMzc2VStlRi9ya25KQkkvQTNycGZ6RFZiMWNuSDJCSGFmZjVCRXpZdDBt?=
 =?utf-8?B?TVQwbkpPa0p6UEt4RjJqQnZ0RjVjRWdDZmR4SEpjNFJMWk50MmFBQnRUYWlp?=
 =?utf-8?B?djBRRGRrajFNUUdVVUxvSVBVdUY4N0tnaCtTdVNpbFFZOWdxd0pVT1hQNVN0?=
 =?utf-8?B?aXFHTXdvakdObU1OVDhTdkNuVkt1b0xUdEpDaHFPdy83dXBaZmdHZzY1blNW?=
 =?utf-8?B?UlpsL3F2MEZtb1RZWWIxUDhIOCsyWk5tVEZ0d0thMEQxSUN6cldjcGJCM3E3?=
 =?utf-8?B?OTJyaXJjTVdMd0VUcTl0dW9MMytOcmRFME8rT1g0S1hoaHBUT0gwZnh0ZEUv?=
 =?utf-8?Q?/gc+1Hgg+Eha1c+QDNyAok3SE4MjRsV2BUc2sC7?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: dfb78ac7-69f3-4066-a92f-08d9899d334d
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Oct 2021 14:17:31.5402
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: upmepLbmFRUjD6TdwW4LUVv/ZPxcf+x+xNQ+RNeIe+rSZHhaZLq344VfqhQ2W0UpeMslmMsbT61qYwBg/O4urg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB3296

On 24.08.2021 12:50, Anthony PERARD wrote:
> This avoid the need to create the symbolic link "include/asm".
> 
> Whenever a comment refer to an "asm" headers, this patch avoid
> spelling the arch when not needed to avoid some code churn.
> 
> One unrelated change is to sort entries in MAINTAINERS for "INTEL(R)
> VT FOR X86 (VT-X)"

Actually that misplaced entry isn't really that much VT-x related and
hence would imo better be dropped from there. But I can see that such
dropping would be less suitable of a change here.

> --- a/tools/include/Makefile
> +++ b/tools/include/Makefile
> @@ -30,7 +30,7 @@ xen-dir:
>  	ln -s $(XEN_ROOT)/xen/include/acpi/platform acpi/
>  	ln -s $(XEN_ROOT)/xen/include/acpi/ac*.h acpi/
>  ifeq ($(CONFIG_X86),y)
> -	ln -s $(XEN_ROOT)/xen/include/asm-x86 xen/asm
> +	ln -s $(XEN_ROOT)/xen/arch/x86/include/asm xen/asm

I think this would now better be

	ln -s $(XEN_ROOT)/xen/arch/x86/include/asm xen/

matching what is visible in context.

> --- a/xen/arch/riscv/arch.mk
> +++ b/xen/arch/riscv/arch.mk
> @@ -12,3 +12,4 @@ riscv-march-$(CONFIG_RISCV_ISA_C)       := $(riscv-march-y)c
>  
>  CFLAGS += -march=$(riscv-march-y) -mstrict-align -mcmodel=medany
>  CFLAGS += -I$(BASEDIR)/include
> +CFLAGS += -I$(BASEDIR)/arch/$(TARGET_ARCH)/include

I find it odd that this needed repeating in every arch.mk. Can't
this be done once for all arches?

> --- a/xen/common/page_alloc.c
> +++ b/xen/common/page_alloc.c
> @@ -241,7 +241,7 @@ PAGE_LIST_HEAD(page_broken_list);
>  
>  /*
>   * first_valid_mfn is exported because it is use in ARM specific NUMA
> - * helpers. See comment in asm-arm/numa.h.
> + * helpers. See comment in asm/numa.h.
>   */
>  mfn_t first_valid_mfn = INVALID_MFN_INITIALIZER;

I'm afraid that in this case it is relevant that it's Arm's header,
like ...

> --- a/xen/include/xen/acpi.h
> +++ b/xen/include/xen/acpi.h
> @@ -40,8 +40,9 @@
>  #define ACPI_MADT_GET_TRIGGER(inti)	ACPI_MADT_GET_(TRIGGER, inti)
>  
>  /*
> - * Fixmap pages to reserve for ACPI boot-time tables (see asm-x86/fixmap.h or
> - * asm-arm/config.h, 64 pages(256KB) is large enough for most cases.)
> + * Fixmap pages to reserve for ACPI boot-time tables (see
> + * arch/x86/include/asm/fixmap.h or arch/arm/include/asm/config.h,
> + * 64 pages(256KB) is large enough for most cases.)

... you arrange for here.

Jan



From xen-devel-bounces@lists.xenproject.org Thu Oct 07 14:25:58 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Oct 2021 14:25:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.203644.358795 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYULK-00063l-TP; Thu, 07 Oct 2021 14:25:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 203644.358795; Thu, 07 Oct 2021 14:25:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYULK-00063e-QI; Thu, 07 Oct 2021 14:25:54 +0000
Received: by outflank-mailman (input) for mailman id 203644;
 Thu, 07 Oct 2021 14:25:53 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=s+Rh=O3=arm.com=Luca.Fancellu@srs-us1.protection.inumbo.net>)
 id 1mYULJ-00063Y-9u
 for xen-devel@lists.xenproject.org; Thu, 07 Oct 2021 14:25:53 +0000
Received: from EUR01-VE1-obe.outbound.protection.outlook.com (unknown
 [40.107.14.55]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 947c14de-b4e7-4cad-89f3-4d33ec377b18;
 Thu, 07 Oct 2021 14:25:51 +0000 (UTC)
Received: from AM5PR0701CA0006.eurprd07.prod.outlook.com
 (2603:10a6:203:51::16) by VI1PR0802MB2463.eurprd08.prod.outlook.com
 (2603:10a6:800:bb::18) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18; Thu, 7 Oct
 2021 14:25:35 +0000
Received: from AM5EUR03FT032.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:203:51:cafe::c4) by AM5PR0701CA0006.outlook.office365.com
 (2603:10a6:203:51::16) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.4 via Frontend
 Transport; Thu, 7 Oct 2021 14:25:35 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM5EUR03FT032.mail.protection.outlook.com (10.152.16.84) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4587.18 via Frontend Transport; Thu, 7 Oct 2021 14:25:34 +0000
Received: ("Tessian outbound b9598e0ead92:v103");
 Thu, 07 Oct 2021 14:25:34 +0000
Received: from b804b1263025.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 5266E4F1-1A05-442B-86F0-5C19D30A3D43.1; 
 Thu, 07 Oct 2021 14:25:22 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id b804b1263025.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Thu, 07 Oct 2021 14:25:22 +0000
Received: from PAXPR08MB6816.eurprd08.prod.outlook.com (2603:10a6:102:130::10)
 by PR2PR08MB4700.eurprd08.prod.outlook.com (2603:10a6:101:1b::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18; Thu, 7 Oct
 2021 14:25:20 +0000
Received: from PAXPR08MB6816.eurprd08.prod.outlook.com
 ([fe80::c1b4:db1c:376f:b697]) by PAXPR08MB6816.eurprd08.prod.outlook.com
 ([fe80::c1b4:db1c:376f:b697%8]) with mapi id 15.20.4587.019; Thu, 7 Oct 2021
 14:25:20 +0000
Received: from smtpclient.apple (217.140.106.53) by
 LO4P123CA0429.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18b::20) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4566.17 via Frontend Transport; Thu, 7 Oct 2021 14:25:19 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 947c14de-b4e7-4cad-89f3-4d33ec377b18
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=yMZbH25P77qIWqPH6yWdyJ7CHw/ASTedsNDOwMk6rU8=;
 b=5pOizQptNCZkBDHSY0CEyJj6YhWf/KiK4IV3KRlgoKxBld0SnPImng9n6Qb/5NXEWkjwwkiq1MJHMPutf8X40LE/2gOjqfovmqJM7oxAAeFXvTq/3ybvp4G5Zmu+Wv2YC/sLLz0U9V4Ur/pk1w/v0KBzMMw+KJmxBkfLakND99M=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 277379b04ef87cb5
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=J70RM+dsNAyIskjqitVvp6YLgGihFoXQR16Du7HLtlH5MSZu9XLAbZ6Zu78vJa6sNQFgTnTH/02JmbgQHE7MNr0wlwEoxLLBslyJj8NklLtAzd30UlQYgzGESP+xUBUj4KMgU52C8JrG5oSNseo28Q04pHK+CjGXilhT4sBgQEVGDVlRNOVNUzOLmr4b+VpR+rqlT3Cvp/uUW69TgIwilcV4dZZqiT8YnWDaYt8A9x3yHvPY1P5ZepACSc2A4BDD7vHG4yKEEFtVT5dy37QGKeRtvJxUf/Q0/ZEmUBd6GkHc/gifiQxP8lJ8Q9KY/DYtQ0vxV1KsNFZ30zGJs8aujg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=yMZbH25P77qIWqPH6yWdyJ7CHw/ASTedsNDOwMk6rU8=;
 b=KTLG/aEzMlyAcDZuhwgmu2pFMmhSUIefPSMszKTYy9CTSGwQYgE0mFz/LxfWQmfFlpUSMc4i/IbBautxqQzabP/yvyFoHOeOOamPyTewDwi8p83/yuSDmMgY0yuvg7xseyr60GiCl2nt/4x6yck843Wag25353fxIWcyfs8/T5AEM69rFSvUJ852OvGnq5hxFQNR6WVeL9Nr1+e+Cwl36BTi6c47g6viXCxQ1zHSF24q+oxO8i9P2tC8wRAK2K8H9pLaYUDOTuCTLHgMuAcolF2ZSvA9AvcEHZIoK5S5I+Bb7KUx8dElDOLvIRT8CpQn+F/d8mgvhvDcPgCd9aQU2w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=yMZbH25P77qIWqPH6yWdyJ7CHw/ASTedsNDOwMk6rU8=;
 b=5pOizQptNCZkBDHSY0CEyJj6YhWf/KiK4IV3KRlgoKxBld0SnPImng9n6Qb/5NXEWkjwwkiq1MJHMPutf8X40LE/2gOjqfovmqJM7oxAAeFXvTq/3ybvp4G5Zmu+Wv2YC/sLLz0U9V4Ur/pk1w/v0KBzMMw+KJmxBkfLakND99M=
Authentication-Results-Original: xen.org; dkim=none (message not signed)
 header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
Content-Type: text/plain;
	charset=utf-8
Subject: Re: [PATCH v4 1/3] arm/efi: Introduce xen,uefi-cfg-load DT property
From: Luca Fancellu <luca.fancellu@arm.com>
In-Reply-To: <8691f762-e4ca-b099-8b4e-87b63b16abe0@xen.org>
Date: Thu, 7 Oct 2021 15:25:16 +0100
Cc: xen-devel@lists.xenproject.org,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 wei.chen@arm.com,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Ian Jackson <iwj@xenproject.org>,
 Jan Beulich <jbeulich@suse.com>,
 Wei Liu <wl@xen.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <42808BCC-A1EC-4EAD-87CE-1AFBA0CC6D46@arm.com>
References: <20210930142846.13348-1-luca.fancellu@arm.com>
 <20210930142846.13348-2-luca.fancellu@arm.com>
 <8691f762-e4ca-b099-8b4e-87b63b16abe0@xen.org>
To: Julien Grall <julien@xen.org>
X-Mailer: Apple Mail (2.3654.120.0.1.13)
X-ClientProxiedBy: LO4P123CA0429.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:18b::20) To PAXPR08MB6816.eurprd08.prod.outlook.com
 (2603:10a6:102:130::10)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 91d7478a-1212-45d8-3ae8-08d9899e5382
X-MS-TrafficTypeDiagnostic: PR2PR08MB4700:|VI1PR0802MB2463:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS:
	<VI1PR0802MB246344B3F9E1E201F2826E4DE4B19@VI1PR0802MB2463.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 AQs9ZyBoXkCDqfNacu+yXLqVOxosPxqQQgVmufO3zkMIP/hTHrBIfbShgGjJB8sqWk0fmkGwBcL7wN90QtWmkNiLsbEyZPG+AulHwWCuGGZyABPKs2EfabTKsH+Pj8N9+lNyTSD+BUTQf6IhVKlI2CIcDAxbBugerJkQxs54BIgyp31dxC7lWeEVbyfEugnRKUvtlLcHFj9CG+YwVtFGUlNi82B7tMvtYQU/Bzt276SZV7Bu4LxoAPfvCWUtoHy2UT10q7+yV2g+BMOLQqVstl/0cP+FCz3pI3UmmNdX9V2XycLQXhgRRV9P6dMmSjwjf3CU0NCZO9ZR5DbeUh+fH5mctZUPvN4UdYx+4DFno2wnW6sj6Llo9V0OFBm2V3NA0ftJhqdI9b1NimU/Btg4rYQH8Sm/dY3ZuGFSaCOAT3rJh/cYIU4IHi8yfS7acqeC79Tu9LH5AWq3pDftVBwEZXngzOv0j4iqdtsOs/if+Kiu/qnU9OLLwDHVnMGh5qwQzOd7OGSGE/zehn9I+HdJEOP1C7TRARHSLkqdE9qlZJqb23ODWPCgIcnzDu1LqEWj8cI8liYV3WyrrJcC7qQQo6uIjqrpwyONFAW+JMKCEhWbv5TojDj6CS7X/DjlyY6hJvsrVoU2qnKf4mTimf8clGpDmfe7lKsoBop1XVr5dIBAckIsiEpmHvt2Nz5n5yEuoEmPx2jSJtn7BRRRTzt+WuyobdY5jov0Qpjc2D16sRE=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB6816.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(66946007)(53546011)(36756003)(316002)(6486002)(6666004)(66476007)(66556008)(8676002)(38350700002)(6506007)(5660300002)(6916009)(6512007)(186003)(4326008)(44832011)(54906003)(86362001)(26005)(38100700002)(33656002)(8936002)(2906002)(956004)(52116002)(83380400001)(2616005)(508600001)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR2PR08MB4700
Original-Authentication-Results: xen.org; dkim=none (message not signed)
 header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM5EUR03FT032.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	0b7bd5fa-f91b-4090-4843-08d9899e4a8d
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	atd9HtJvdukBRi2F+mHSllFH6k91NlJY+HatwnaNJybjCRjRc7s/WDmiZoUSrCYu9AYUj/VS8QmUj6CFM9hOnQYPJkL+NLScAIeoSR+Ipl0pyNPs1zRyJFXy7Paf6b5absCxBzXI1mCd+nK61LP702WXkC5+kCYSCS9OTjcAcm6379oB9AqUbkDO1S8VVY2lXwz/JqqwXJLnWaP0gb/tRcq8AWTDqYRplfTri6oYVx6Ym3YzsZTCbrMqYeBwcWLoMqXU68BIU4AW0PDzaCnzGqZGhR0ldbS9fnN3tVpgEZ4Enuf/dWWQrUbmPpdIRG41BKlZENUokXOkVgotIzmLZ3RYuzhs02S0hoNFUauD6zNZKk283q+Ycar1sPooHADrWwnocCIkFUKQJopPppAXOud7ahTGCyIWPdk1dkGfJXGkbEHuBLcn5rjjrKUAPDx1UXgjnXS6sb/+95qSKmKBvR0f160k8vteN0VdrQYBzK5lV6wAHMv/C/dw/2FuSllNSMd41mGgwPkiItq6EDOtGnwHpYm4B3r2aTpLgaKhqoSUH/46UtGBKHu4Am+yTJKyVVLsJjMLgEt+jH6rA9tIHozCqFCTXc1r0BMg5zRJwgiue17aLjN4WuSS1yGyPmuQz4LEY5lkHuHxCQkH5aU6K8S+OM7pIYUOT5cjC4b7l4QqAcBHoDgxNs7rGdPAruzi+6BybWHTAnpHkmyDRqGvUg==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(36756003)(6506007)(70206006)(5660300002)(8936002)(8676002)(47076005)(86362001)(70586007)(6486002)(6512007)(53546011)(33656002)(82310400003)(508600001)(186003)(54906003)(356005)(4326008)(2616005)(316002)(6862004)(956004)(83380400001)(2906002)(36860700001)(26005)(336012)(44832011)(6666004)(81166007);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Oct 2021 14:25:34.7967
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 91d7478a-1212-45d8-3ae8-08d9899e5382
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM5EUR03FT032.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0802MB2463



> On 6 Oct 2021, at 19:32, Julien Grall <julien@xen.org> wrote:
>=20
> Hi Luca,
>=20
> Sorry for jumping late in the conversation. While skimming through what h=
as been committed, I noticed one potential issue in this patch and have als=
o a question.
>=20
> On 30/09/2021 16:28, Luca Fancellu wrote:
>> Introduce the xen,uefi-cfg-load DT property of /chosen
>> node for ARM whose presence decide whether to force
>> the load of the UEFI Xen configuration file.
>> The logic is that if any multiboot,module is found in
>> the DT, then the xen,uefi-cfg-load property is used to see
>> if the UEFI Xen configuration file is needed.
>> Modify a comment in efi_arch_use_config_file, removing
>> the part that states "dom0 required" because it's not
>> true anymore with this commit.
>> Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>
>> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
>> ---
>> v4 changes:
>> - modify property name to xen,uefi-cfg-load
>> v3 changes:
>> - add documentation to misc/arm/device-tree/booting.txt
>> - Modified variable name and logic from skip_cfg_file to
>> load_cfg_file
>> - Add in the commit message that I'm modifying a comment.
>> v2 changes:
>> - Introduced uefi,cfg-load property
>> - Add documentation about the property
>> ---
>>  docs/misc/arm/device-tree/booting.txt |  8 ++++++++
>>  docs/misc/efi.pandoc                  |  2 ++
>>  xen/arch/arm/efi/efi-boot.h           | 28 ++++++++++++++++++++++-----
>>  3 files changed, 33 insertions(+), 5 deletions(-)
>> diff --git a/docs/misc/arm/device-tree/booting.txt b/docs/misc/arm/devic=
e-tree/booting.txt
>> index 44cd9e1a9a..352b0ec43a 100644
>> --- a/docs/misc/arm/device-tree/booting.txt
>> +++ b/docs/misc/arm/device-tree/booting.txt
>> @@ -121,6 +121,14 @@ A Xen-aware bootloader would set xen,xen-bootargs f=
or Xen, xen,dom0-bootargs
>>  for Dom0 and bootargs for native Linux.
>>    +UEFI boot and DT
>> +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
>> +
>> +When Xen is booted using UEFI, it doesn't read the configuration file i=
f any
>> +multiboot module is specified. To force Xen to load the configuration f=
ile, the
>> +boolean property xen,uefi-cfg-load must be declared in the /chosen node=
.
>> +
>> +
>>  Creating Multiple Domains directly from Xen
>>  =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
>>  diff --git a/docs/misc/efi.pandoc b/docs/misc/efi.pandoc
>> index ac3cd58cae..ed85351541 100644
>> --- a/docs/misc/efi.pandoc
>> +++ b/docs/misc/efi.pandoc
>> @@ -14,6 +14,8 @@ loaded the modules and describes them in the device tr=
ee provided to Xen.  If a
>>  bootloader provides a device tree containing modules then any configura=
tion
>>  files are ignored, and the bootloader is responsible for populating all
>>  relevant device tree nodes.
>> +The property "xen,uefi-cfg-load" can be specified in the /chosen node t=
o force
>> +Xen to load the configuration file even if multiboot modules are found.
>=20

Hi Julien,

> I think this wants to be clarified. Lets imagine both the Device-Tree and=
 the cfg provides a kernel. Which one will get used?

Yes this is will lead to a device tree where there will be two multiboot mo=
dule for the dom0 kernel, I guess the one really loaded
will be the first multiboot kernel node processed and appended to the boot =
modules.

I see this is a possible issue and this is handled in the third patch of th=
e serie.


>=20
>=20
>>    Once built, `make install-xen` will place the resulting binary direct=
ly into
>>  the EFI boot partition, provided `EFI_VENDOR` is set in the environment=
 (and
>> diff --git a/xen/arch/arm/efi/efi-boot.h b/xen/arch/arm/efi/efi-boot.h
>> index cf9c37153f..a3e46453d4 100644
>> --- a/xen/arch/arm/efi/efi-boot.h
>> +++ b/xen/arch/arm/efi/efi-boot.h
>> @@ -581,22 +581,40 @@ static void __init efi_arch_load_addr_check(EFI_LO=
ADED_IMAGE *loaded_image)
>>    static bool __init efi_arch_use_config_file(EFI_SYSTEM_TABLE *SystemT=
able)
>>  {
>> +    bool load_cfg_file =3D true;
>>      /*
>>       * For arm, we may get a device tree from GRUB (or other bootloader=
)
>>       * that contains modules that have already been loaded into memory.=
  In
>> -     * this case, we do not use a configuration file, and rely on the
>> -     * bootloader to have loaded all required modules and appropriate
>> -     * options.
>> +     * this case, we search for the property xen,uefi-cfg-load in the /=
chosen
>> +     * node to decide whether to skip the UEFI Xen configuration file o=
r not.
>>       */
>>        fdt =3D lookup_fdt_config_table(SystemTable);
>>      dtbfile.ptr =3D fdt;
>>      dtbfile.need_to_free =3D false; /* Config table memory can't be fre=
ed. */
>> -    if ( !fdt || fdt_node_offset_by_compatible(fdt, 0, "multiboot,modul=
e") < 0 )
>> +
>> +    if ( fdt_node_offset_by_compatible(fdt, 0, "multiboot,module") > 0 =
)
>=20
> AFAICT, fdt_node_offset_by_compatible expects 'fdt' to be non-NULL. Howev=
er, lookup_fdt_config_table() may return NULL on platform with no Device-Tr=
ee (server tends to be ACPI only). So wouldn't this result to dereference N=
ULL and crash?

Thanks for spotting that, I will push a patch to fix it, something like thi=
s should be ok:

+    if ( fdt && (fdt_node_offset_by_compatible(fdt, 0, "multiboot,module")=
 > 0) )

Sorry I didn=E2=80=99t spotted earlier.

Cheers,
Luca

>=20
>> +    {
>> +        /* Locate chosen node */
>> +        int node =3D fdt_subnode_offset(fdt, 0, "chosen");
>> +        const void *cfg_load_prop;
>> +        int cfg_load_len;
>> +
>> +        if ( node > 0 )
>> +        {
>> +            /* Check if xen,uefi-cfg-load property exists */
>> +            cfg_load_prop =3D fdt_getprop(fdt, node, "xen,uefi-cfg-load=
",
>> +                                        &cfg_load_len);
>> +            if ( !cfg_load_prop )
>> +                load_cfg_file =3D false;
>> +        }
>> +    }
>> +
>> +    if ( !fdt || load_cfg_file )
>>      {
>>          /*
>>           * We either have no FDT, or one without modules, so we must ha=
ve a
>> -         * Xen EFI configuration file to specify modules.  (dom0 requir=
ed)
>> +         * Xen EFI configuration file to specify modules.
>>           */
>>          return true;
>>      }
>=20
> Cheers,
>=20
> --=20
> Julien Grall



From xen-devel-bounces@lists.xenproject.org Thu Oct 07 14:28:41 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Oct 2021 14:28:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.203655.358806 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYUNz-0006oy-E9; Thu, 07 Oct 2021 14:28:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 203655.358806; Thu, 07 Oct 2021 14:28:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYUNz-0006or-Ap; Thu, 07 Oct 2021 14:28:39 +0000
Received: by outflank-mailman (input) for mailman id 203655;
 Thu, 07 Oct 2021 14:28:38 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mYUNy-0006oh-4D; Thu, 07 Oct 2021 14:28:38 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mYUNx-00053n-Un; Thu, 07 Oct 2021 14:28:38 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mYUNx-0004kc-MO; Thu, 07 Oct 2021 14:28:37 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mYUNx-0008PS-Ls; Thu, 07 Oct 2021 14:28:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=T17Rdf9M4kAXAKvPHwSXBdwN2DO+5zb2/rCg0c3iVVE=; b=54FPRGhwyTAfjUF6FfT3ENv58A
	OAw2B6EhJPQyqLHQ168gClBIylta4jD0Ax3tT5B9UMkpETcsGhHvH4/HgS9cTrJZSH//0TzwzSsJk
	iGZ4WaTV188zGZe6jVc/ul7sO1fyrJZxqySLbkT5MZWQQuqJ8SbTExYmkjkKlV4s9WfE=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165392-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-5.4 test] 165392: regressions - FAIL
X-Osstest-Failures:
    linux-5.4:test-armhf-armhf-xl-credit1:guest-start:fail:regression
    linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:heisenbug
    linux-5.4:test-amd64-i386-libvirt-pair:xen-boot/src_host:fail:heisenbug
    linux-5.4:test-arm64-arm64-libvirt-xsm:guest-start/debian.repeat:fail:heisenbug
    linux-5.4:test-armhf-armhf-xl-rtds:guest-start.2:fail:allowable
    linux-5.4:test-arm64-arm64-libvirt-raw:guest-start/debian.repeat:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=3a7dc5b4cfbdfd8da37cb0e54f439d84cf5a5123
X-Osstest-Versions-That:
    linux=e74e2950a0d6f800858e54860d7124c86e494f62
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 07 Oct 2021 14:28:37 +0000

flight 165392 linux-5.4 real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165392/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-armhf-armhf-xl-credit1  14 guest-start              fail REGR. vs. 165206

Tests which are failing intermittently (not blocking):
 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail in 165378 pass in 165392
 test-amd64-i386-libvirt-pair 12 xen-boot/src_host          fail pass in 165378
 test-arm64-arm64-libvirt-xsm 18 guest-start/debian.repeat  fail pass in 165378

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds     19 guest-start.2            fail REGR. vs. 165206

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-libvirt-raw 17 guest-start/debian.repeat fail in 165378 like 165206
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165206
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 165206
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 165206
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 165206
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165206
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165206
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 165206
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 165206
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 165206
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 165206
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 165206
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 165206
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 linux                3a7dc5b4cfbdfd8da37cb0e54f439d84cf5a5123
baseline version:
 linux                e74e2950a0d6f800858e54860d7124c86e494f62

Last test of basis   165206  2021-09-26 12:42:13 Z   11 days
Testing same since   165346  2021-10-04 12:42:32 Z    3 days    3 attempts

------------------------------------------------------------
People who touched revisions under test:
  Alan Stern <stern@rowland.harvard.edu>
  Alexei Starovoitov <ast@kernel.org>
  Andreas Larsson <andreas@gaisler.com>
  Andrew Morton <akpm@linux-foundation.org>
  Andy Shevchenko <andriy.shevchenko@linux.intel.com>
  Antoine Tenart <atenart@kernel.org>
  Anton Eidelman <anton.eidelman@gmail.com>
  Anton Eidelman <anton@lightbitslabs.com>
  Ariel Elior <aelior@marvell.com>
  Arnd Bergmann <arnd@arndb.de>
  Aya Levin <ayal@nvidia.com>
  Baokun Li <libaokun1@huawei.com>
  Bartosz Golaszewski <brgl@bgdev.pl>
  Bixuan Cui <cuibixuan@huawei.com>
  Borislav Petkov <bp@suse.de>
  Carlo Lobrano <c.lobrano@gmail.com>
  Catalin Marinas <catalin.marinas@arm.com>
  Chris Chiu <chris.chiu@canonical.com>
  Christian Brauner <christian.brauner@ubuntu.com>
  Christoph Hellwig <hch@lst.de>
  Claudiu Manoil <claudiu.manoil@nxp.com>
  Dan Carpenter <dan.carpenter@oracle.com>
  Dan Li <ashimida@linux.alibaba.com>
  Daniel Lezcano <daniel.lezcano@linaro.org>
  David Howells <dhowells@redhat.com>
  David S. Miller <davem@davemloft.net>
  David Sterba <dsterba@suse.com>
  Dmitry Bogdanov <d.bogdanov@yadro.com>
  Felipe Balbi <balbi@kernel.org>
  Florian Fainelli <f.fainelli@gmail.com>
  Gao Xiang <hsiangkao@linux.alibaba.com>
  Geert Uytterhoeven <geert@linux-m68k.org>
  Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  Gregory CLEMENT <gregory.clement@bootlin.com>
  Guenter Roeck <linux@roeck-us.net>
  Hans de Goede <hdegoede@redhat.com>
  Helge Deller <deller@gmx.de>
  Hulk Robot <hulkrobot@huawei.com>
  Jan Beulich <jbeulich@suse.com>
  Jens Axboe <axboe@kernel.dk>
  Jesper Nilsson <jesper.nilsson@axis.com>
  Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
  Jiri Slaby <jslaby@suse.cz>
  Johan Hovold <johan@kernel.org>
  Johannes Thumshirn <jth@kernel.org>
  Jon Hunter <jonathanh@nvidia.com>
  Juergen Gross <jgross@suse.com>
  Julian Sikorski <belegdol+github@gmail.com>
  Julian Sikorski <belegdol@gmail.com>
  Kaige Fu <kaige.fu@linux.alibaba.com>
  Karsten Graul <kgraul@linux.ibm.com>
  Kishon Vijay Abraham I <kishon@ti.com>
  Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
  Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
  Li Jinlin <lijinlin3@huawei.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Linux Kernel Functional Testing <lkft@linaro.org>
  Marc Zyngier <maz@kernel.org>
  Mark Rutland <mark.rutland@arm.com>
  Markus Suvanto <markus.suvanto@gmail.com>
  Martin K. Petersen <martin.petersen@oracle.com>
  Michael Chan <michael.chan@broadcom.com>
  Michael Chan <michael.chan@broadocm.com>
  Michal Kalderon <mkalderon@marvell.com>
  Minas Harutyunyan <Minas.Harutyunyan@synopsys.com>
  Moritz Fischer <mdf@kernel.org>
  Nicolas Ferre <nicolas.ferre@microchip.com>
  Oliver Neukum <oneukum@suse.com>
  Ondrej Zary <linux@zary.sk>
  Pali Rohár <pali@kernel.org>
  Qu Wenruo <wqu@suse.com>
  Randy Dunlap <rdunlap@infradead.org>
  Ronnie Sahlberg <lsahlber@redhat.com>
  Sai Krishna Potthuri <lakshmi.sai.krishna.potthuri@xilinx.com>
  Sasha Levin <sashal@kernel.org>
  Shai Malin <smalin@marvell.com>
  Shuah Khan <skhan@linuxfoundation.org>
  Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
  Slark Xiao <slark_xiao@163.com>
  Song Liu <songliubraving@fb.com>
  Srinivas Pandruvada <srinivas.pI andruvada@linux.intel.com>
  Steve French <stfrench@microsoft.com>
  Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
  syzbot+fadc0aaf497e6a493b9f@syzkaller.appspotmail.com
  Tariq Toukan <tariqt@nvidia.com>
  Tejun Heo <tj@kernel.org>
  Todd Kjos <tkjos@google.com>
  Tom Rix <trix@redhat.com>
  Tong Zhang <ztong0001@gmail.com>
  Uwe Brandt <uwe.brandt@gmail.com>
  Wengang Wang <wen.gang.wang@oracle.com>
  Yonghong Song <yhs@fb.com>
  zhang kai <zhangkaiheb@126.com>
  Zhihao Cheng <chengzhihao1@huawei.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 fail    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 fail    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 1974 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Oct 07 14:41:33 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Oct 2021 14:41:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.203669.358822 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYUaO-0000f0-Mh; Thu, 07 Oct 2021 14:41:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 203669.358822; Thu, 07 Oct 2021 14:41:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYUaO-0000et-Jf; Thu, 07 Oct 2021 14:41:28 +0000
Received: by outflank-mailman (input) for mailman id 203669;
 Thu, 07 Oct 2021 14:41:28 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=VtJa=O3=xenbits.xen.org=iwj@srs-us1.protection.inumbo.net>)
 id 1mYUaO-0000cy-3M
 for xen-devel@lists.xen.org; Thu, 07 Oct 2021 14:41:28 +0000
Received: from mail.xenproject.org (unknown [104.130.215.37])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 36d9d717-bda9-4a44-b076-c8fef00a78af;
 Thu, 07 Oct 2021 14:41:22 +0000 (UTC)
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenbits.xen.org>)
 id 1mYUaC-0005Iu-Sc; Thu, 07 Oct 2021 14:41:16 +0000
Received: from iwj by xenbits.xenproject.org with local (Exim 4.92)
 (envelope-from <iwj@xenbits.xen.org>)
 id 1mYUaC-0002lK-RC; Thu, 07 Oct 2021 14:41:16 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 36d9d717-bda9-4a44-b076-c8fef00a78af
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Date:Message-Id:Subject:CC:From:To:MIME-Version:
	Content-Transfer-Encoding:Content-Type;
	bh=whX0VbxgcafzIANGuqkJSRmkjVp04j5bkRzqO6Z/bEI=; b=TnQ+sCxxRcx1nR69qkFJvT3iSH
	nnyNIW/s7JSg2DfEuJbun9xRYUR2O9fYNs7YA/I1o1BmaZ9L31bQyjZw8tp2D6ktjCQbRuUGjFh0/
	EGCNe8fEObnFUk71flf2iPoOMfwCDO197fqYJxEMS//yLWP4GwLMjykxPB4BH1L2ZGKQ=;
Content-Type: multipart/mixed; boundary="=separator"; charset="utf-8"
Content-Transfer-Encoding: binary
MIME-Version: 1.0
X-Mailer: MIME-tools 5.509 (Entity 5.509)
To: xen-announce@lists.xen.org, xen-devel@lists.xen.org,
 xen-users@lists.xen.org, oss-security@lists.openwall.com
From: Xen.org security team <security@xen.org>
CC: Xen.org security team <security-team-members@xen.org>
Subject: Xen Security Advisory 386 v2 (CVE-2021-28702) - PCI devices with
 RMRRs not deassigned correctly
Message-Id: <E1mYUaC-0002lK-RC@xenbits.xenproject.org>
Date: Thu, 07 Oct 2021 14:41:16 +0000

--=separator
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

            Xen Security Advisory CVE-2021-28702 / XSA-386
                               version 2

            PCI devices with RMRRs not deassigned correctly

UPDATES IN VERSION 2
====================

Updated/corrected information about vulnerable versions.
Upstream Xen 4.12 is not affected.

There is no harm from applying the patch to an unaffected version.

ISSUE DESCRIPTION
=================

Certain PCI devices in a system might be assigned Reserved Memory
Regions (specified via Reserved Memory Region Reporting, "RMRR").
These are typically used for platform tasks such as legacy USB
emulation.

If such a device is passed through to a guest, then on guest shutdown
the device is not properly deassigned.  The IOMMU configuration for
these devices which are not properly deassigned ends up pointing to a
freed data structure, including the IO Pagetables.

Subsequent DMA or interrupts from the device will have unpredictable
behaviour, ranging from IOMMU faults to memory corruption.

This bug has existed since at least Xen 4.4 But it was previously
masked by a tangentially-related misbehaviour; that misbehaviour was
corrected in f591755823a7
 IOMMU/PCI: don't let domain cleanup continue when device de-assignment failed
which was backported to supported stable branches.

IMPACT
======

Administrators of guests which have been assigned RMRR-using PCI
devices can cause denial of service and other problems, possibly
including escalation of privilege.

VULNERABLE SYSTEMS
==================

For stable Xen releases: 4.13.4, 4.14.3 and 4.15.1 are vulnerable.
Other versions of Xen released by the Xen Project are not affected.

For Xen git branches: the HEADs of 4.13 and later (including
xen-unstable) were vulnerable, up until 2021-10-05 (when the patch in
this advisory was committed).  4.12 and earlier are not affected.

In detail: code that has the following patch applied, is vulnerable:
 IOMMU/PCI: don't let domain cleanup continue when device de-assignment failed
That patch is currently in upstream stable branches 4.13 onwards and
was included in the most recent stable point releases of each Xen version.
Other downstream Xen builds may be affected if that patch was backported.

Only Intel x86 systems are affected.  AMD x86 systems, and Arm
systems, are all unaffected.

Only systems using PCI passthrough are affected.  (And then, only if
the assigned devices have RMRRs, but whether a device advertises RMRRs
is not easy to discern.)

MITIGATION
==========

There is no mitigation (other than not passing through PCI devices
with RMRRs to guests).

RESOLUTION
==========

Applying the appropriate attached patch resolves this issue.

Note that patches for released versions are generally prepared to
apply to the stable branches, and may not apply cleanly to the most
recent release tarball.  Downstreams are encouraged to update to the
tip of the stable branch before applying these patches.

xsa386.patch           xen-unstable - Xen 4.13.x

$ sha256sum xsa386*
f2f83c825e249bba9454437b48bbd8307fe7a224f56484388a67af124dfd279b  xsa386.patch
$

NOTE CONCERNING LACK OF EMBARGO
===============================

This issue was reported and debugged in public before the security nature
became apparent.
-----BEGIN PGP SIGNATURE-----

iQFABAEBCAAqFiEEI+MiLBRfRHX6gGCng/4UyVfoK9kFAmFfBvkMHHBncEB4ZW4u
b3JnAAoJEIP+FMlX6CvZY20H/jWe2XVSU6R+cOv4GbhWL5sWBv4skLZ07yq77p8i
JB9nJXdVkyHJPSkENzggGGiygiHMJFSD5cLvczJp1IbAlQKQlZt/oVG9oTWHHeqO
joabwgZ9UyNW8/beCigRo1PYdiWI7tMsLp3D/LAjE8+ZhBRjD0NKLyWK26Uw0R8A
Su5tApmlBGx0BJzQm4BUWiyog86fPoNcBkP1hRJfj1BfXRjVYB5MsaPCtMhsqBlG
CFjDJ51Wn4Esxkg22e/429MbbExIAJUZoxuOWDk/D7nQShQNBTfqci4pfcaf5E+f
Mxi32bIr/XY5LLgf0Opu5Sl2JP3s7Ik3IDlSa+wYoGIZWB4=
=Ti35
-----END PGP SIGNATURE-----

--=separator
Content-Type: application/octet-stream; name="xsa386.patch"
Content-Disposition: attachment; filename="xsa386.patch"
Content-Transfer-Encoding: base64

RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0
OiBWVC1kOiBmaXggZGVhc3NpZ24gb2YgZGV2aWNlIHdpdGggUk1SUgpEYXRl
OiBGcmksIDEgT2N0IDIwMjEgMTU6MDU6NDIgKzAyMDAKCklnbm9yaW5nIGEg
c3BlY2lmaWMgZXJyb3IgY29kZSBoZXJlIHdhcyBub3QgbWVhbnQgdG8gc2hv
cnQgY2lyY3VpdApkZWFzc2lnbiB0byBfanVzdF8gdGhlIHVubWFwcGluZyBv
ZiBSTVJScy4gVGhpcyBidWcgd2FzIHByZXZpb3VzbHkKaGlkZGVuIGJ5IHRo
ZSBib2d1cyAocG90ZW50aWFsbHkgaW5kZWZpbml0ZSkgbG9vcGluZyBpbgpw
Y2lfcmVsZWFzZV9kZXZpY2VzKCksIHVudGlsIGY1OTE3NTU4MjNhNyAoIklP
TU1VL1BDSTogZG9uJ3QgbGV0IGRvbWFpbgpjbGVhbnVwIGNvbnRpbnVlIHdo
ZW4gZGV2aWNlIGRlLWFzc2lnbm1lbnQgZmFpbGVkIikgZml4ZWQgdGhhdCBs
b29wLgoKVGhpcyBpcyBDVkUtMjAyMS0yODcwMiAvIFhTQS0zODYuCgpGaXhl
czogOGI5OWY0NDAwYjY5ICgiVlQtZDogZml4IFJNUlIgcmVsYXRlZCBlcnJv
ciBoYW5kbGluZyIpClJlcG9ydGVkLWJ5OiBJdmFuIEthcmR5a292IDxrYXJk
eWtvdkB0YWJpdC5wcm8+ClNpZ25lZC1vZmYtYnk6IEphbiBCZXVsaWNoIDxq
YmV1bGljaEBzdXNlLmNvbT4KVGVzdGVkLWJ5OiBJdmFuIEthcmR5a292IDxr
YXJkeWtvdkB0YWJpdC5wcm8+CgotLS0gYS94ZW4vZHJpdmVycy9wYXNzdGhy
b3VnaC92dGQvaW9tbXUuYworKysgYi94ZW4vZHJpdmVycy9wYXNzdGhyb3Vn
aC92dGQvaW9tbXUuYwpAQCAtMjQwOSw3ICsyNDA5LDcgQEAgc3RhdGljIGlu
dCByZWFzc2lnbl9kZXZpY2Vfb3duZXJzaGlwKAogICAgICAgICAgICAgICAg
IHJldCA9IGlvbW11X2lkZW50aXR5X21hcHBpbmcoc291cmNlLCBwMm1fYWNj
ZXNzX3gsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICBybXJyLT5iYXNlX2FkZHJlc3MsCiAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBybXJyLT5lbmRfYWRkcmVz
cywgMCk7Ci0gICAgICAgICAgICAgICAgaWYgKCByZXQgIT0gLUVOT0VOVCAp
CisgICAgICAgICAgICAgICAgaWYgKCByZXQgJiYgcmV0ICE9IC1FTk9FTlQg
KQogICAgICAgICAgICAgICAgICAgICByZXR1cm4gcmV0OwogICAgICAgICAg
ICAgfQogICAgIH0KCg==

--=separator--


From xen-devel-bounces@lists.xenproject.org Thu Oct 07 14:42:18 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Oct 2021 14:42:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.203687.358866 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYUb4-0002QO-VP; Thu, 07 Oct 2021 14:42:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 203687.358866; Thu, 07 Oct 2021 14:42:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYUb4-0002QD-Rn; Thu, 07 Oct 2021 14:42:10 +0000
Received: by outflank-mailman (input) for mailman id 203687;
 Thu, 07 Oct 2021 14:42:09 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=4W4d=O3=gmail.com=olekstysh@srs-us1.protection.inumbo.net>)
 id 1mYUb3-0002P9-8F
 for xen-devel@lists.xenproject.org; Thu, 07 Oct 2021 14:42:09 +0000
Received: from mail-ed1-x52e.google.com (unknown [2a00:1450:4864:20::52e])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id b22f1b91-adc2-4e16-bc39-026891452f59;
 Thu, 07 Oct 2021 14:42:08 +0000 (UTC)
Received: by mail-ed1-x52e.google.com with SMTP id d9so45302edh.5
 for <xen-devel@lists.xenproject.org>; Thu, 07 Oct 2021 07:42:08 -0700 (PDT)
Received: from [192.168.1.7] ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id k22sm10036374eje.89.2021.10.07.07.42.06
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Thu, 07 Oct 2021 07:42:07 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b22f1b91-adc2-4e16-bc39-026891452f59
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-transfer-encoding:content-language;
        bh=4K0lcUrqBzAbVC/KiHkUa0EpMDN7BjwOltB1b+F8d6w=;
        b=mFdC/xQMjGBGONZ6fMGqmQ/9ps6VfpbL+Z9fX4l7AMH1hx1mdFpMbGO1ARILOi74ul
         jCfOJkj9iO1mfh42WjLRIzLNIR0yNCQdW2W9hSIAWp43SelBIpDjmpwGWZN8bYqyu4kV
         k3Ld01Wwqqv4U3FVS1FSN+aoFcpcyfYeS+MiU4ImK0jzmMTDQrjAJIzaevCB0K4K/CDW
         IbZIlVJtyUQ2JP9zOyGeV2guCH73O9w6vjf/OTacIGBu6Z89p6LMywpa/fWX1IMDZqLc
         gGOX8wqicu2UAelxh1goLudbQfp6VFciqPrk+jARs7WYJq/pNvihDi+EIA9pfsKU5uby
         rlSw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding
         :content-language;
        bh=4K0lcUrqBzAbVC/KiHkUa0EpMDN7BjwOltB1b+F8d6w=;
        b=DuNs+a/0ax7YsKoFXDCGmq+FJ3m3Z4c2fqcixnWVCu0UsAyrJG4Vpy0auvSULps2MH
         bGLvAShhF7HidMzWPoYHe1oG0TZNlSgvOWuQkKOgmy9RWcOBgz5gknZQjyBfV24OGe6w
         Tl2Y11xMpeA1AFkjeiAdz0hWxtAzbOIGyko9vo36dmqxqLTXIijhs8DQTH2oYZ9uvsn/
         RR7/Wne63A+kr+fj3MkzuRwTWB5oIJ0YOG4yWDypKAhzE7zeJu9Og9O8Qz24W3RGbe/P
         RT/o3t+39ErOLivhKzJh8GyDtu9jcYnSS3jeWg3ETQJQxmrZy9FMYsh7uUVuxcNSsjSX
         NxTA==
X-Gm-Message-State: AOAM532hAJzpBDoPFV2vSWUUi6xQoE9PVAZ9a+Ule4wshCEGFExv6RW/
	WbH7dBRZJA05E6tdIN1gyPs=
X-Google-Smtp-Source: ABdhPJyQIs5Wca63Iysy5mgBc9oNRHg+mkM2KUzycaDukhzAKODvs0VHlupvc9n3hpEi2QgzhjQYpg==
X-Received: by 2002:a05:6402:19b5:: with SMTP id o21mr6928114edz.214.1633617727427;
        Thu, 07 Oct 2021 07:42:07 -0700 (PDT)
Subject: Re: [PATCH V5 2/3] libxl/arm: Add handling of extended regions for
 DomU
To: Ian Jackson <iwj@xenproject.org>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 xen-devel@lists.xenproject.org,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, Wei Liu <wl@xen.org>,
 Anthony PERARD <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>,
 Julien Grall <julien@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <1633519346-3686-1-git-send-email-olekstysh@gmail.com>
 <1633519346-3686-3-git-send-email-olekstysh@gmail.com>
 <24925.35278.762786.539238@mariner.uk.xensource.com>
 <224ed316-aac0-3ad4-22a1-efc592e717e2@gmail.com>
 <alpine.DEB.2.21.2110061658450.3209@sstabellini-ThinkPad-T480s>
 <24926.53922.628049.481827@mariner.uk.xensource.com>
From: Oleksandr <olekstysh@gmail.com>
Message-ID: <0450c601-656a-4e10-1802-433d2e5c44d8@gmail.com>
Date: Thu, 7 Oct 2021 17:42:06 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <24926.53922.628049.481827@mariner.uk.xensource.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US


On 07.10.21 13:57, Ian Jackson wrote:

Hi Ian.

> Stefano Stabellini writes ("Re: [PATCH V5 2/3] libxl/arm: Add handling of extended regions for DomU"):
>> On Wed, 6 Oct 2021, Oleksandr wrote:
>>> On 06.10.21 14:34, Ian Jackson wrote:
>>>> Oleksandr Tyshchenko writes ("[PATCH V5 2/3] libxl/arm: Add handling of
>>>> extended regions for DomU"):
>>>>> The extended region (safe range) is a region of guest physical
>>>>> address space which is unused and could be safely used to create
>>>>> grant/foreign mappings instead of wasting real RAM pages from
>>>>> the domain memory for establishing these mappings.
>>>> Please forgive me for asking this question now, but: why is this
>>>> ARM-specific ?
>>>
>>> Sorry, I can't say for sure which x86 mode also suffers from
>>> that. I might be wrong, but as I understand that x86 in PVH (and
>>> HVM?) mode uses unpopulated memory ranges (which are unused from
>>> Linux PoV, actually everything not yet allocated or reserved from
>>> "iomem_resource") to create foreign/grant mappings.  So the real
>>> RAM pages are not ballooned out to get an physical address space
>>> to create these mappings. The problem is that we cannot follow
>>> Linux advise which memory ranges are unused on Arm for several
>>> reasons, this is why this patch series makes the hypervisor to
>>> start allocating and exposing these ranges.
> So it sounds like you are saying this is an ARM-specific problem ?
> The key being the "several reasons" which you mention.  Are they
> ARM-specifc problems.

Yes, you could say that. Below are reasons why we need the hypervisor to 
provide these ranges on Arm from my understanding.

[leaving aside hotplug case]

1. [Related to Dom0]  Dom0 is mapped 1:1 on Arm, but there might be some 
guest mapping, mapped identically in P2M (GFN == MFN) for PV drivers to 
work. So Xen has everything in hand to be able to choose extended 
regions (which won't clash with other resources).
2. [Related to every domain]  Not all device I/O regions might be known 
(registered) by the time the guest starts creating grant/foreign 
mappings, so guest cannot guess by itself what is really unused, but the 
entity which creates the domain (Xen, toolstack) knows these details in 
advance to be able to choose extended regions (which won't clash with 
other resources).


>
>> Two more things about this being ARM-specific.
>>
>> Even if x86 was affected exactly by the same problem, the code to expose
>> the safe memory ranges to DomU is arch-specific (currently device tree.)
>>
>> Also the code to calculate the safe memory ranges is arch-specific as it
>> depends on the DomU memory layout which is arch-specific.
> This demonstrates that the implementation is arch-specific.  But one
> of libxl's functions is to abstract away implementation details and
> provide an interface that can be used to "do the right thing".
>
> Ian.

-- 
Regards,

Oleksandr Tyshchenko



From xen-devel-bounces@lists.xenproject.org Thu Oct 07 14:55:16 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Oct 2021 14:55:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.203753.358895 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYUne-0005sg-IT; Thu, 07 Oct 2021 14:55:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 203753.358895; Thu, 07 Oct 2021 14:55:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYUne-0005sZ-F8; Thu, 07 Oct 2021 14:55:10 +0000
Received: by outflank-mailman (input) for mailman id 203753;
 Thu, 07 Oct 2021 14:55:08 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=qfpx=O3=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mYUnc-0005sT-S7
 for xen-devel@lists.xenproject.org; Thu, 07 Oct 2021 14:55:08 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id bc3e49d3-689b-444d-a328-efe0e9238bbf;
 Thu, 07 Oct 2021 14:55:07 +0000 (UTC)
Received: from EUR03-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur03lp2059.outbound.protection.outlook.com [104.47.9.59]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-27-COH2gcDFPWW9x_uq-I4kwA-1; Thu, 07 Oct 2021 16:55:05 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB2957.eurprd04.prod.outlook.com (2603:10a6:802:4::28) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.22; Thu, 7 Oct
 2021 14:55:03 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4587.020; Thu, 7 Oct 2021
 14:55:03 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS9PR06CA0110.eurprd06.prod.outlook.com (2603:10a6:20b:465::29) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18 via Frontend
 Transport; Thu, 7 Oct 2021 14:55:02 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: bc3e49d3-689b-444d-a328-efe0e9238bbf
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1633618506;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=8qABAAvH1Bi4IVa+09q/nwNE1yzSoaRudcTcKA+srxQ=;
	b=Ov1EEIUa/K2EP9xgA0SQd1b+Slt21FbaQ+rJEyU8hAZbD8KzrnffhvKETMtuKpdeadeaZv
	oIcem5iVtVLybmUQAtCXKPL8zEICMzKy4z4KTBkvElpYmVlUVgV156t3Oa+4Hovwd/vIdY
	s7vsl3u1lE9yZdlSP1ZqLDgh880egrQ=
X-MC-Unique: COH2gcDFPWW9x_uq-I4kwA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=j61IafpnuOU1Zw1i3w5e9Mp+OkU26AeNfQy2e6MQCilqhPscW+ZmTaBvO3NjZiju1EFAeZDcb0XbUIe5uE7R6RdNeSnaQdynf9mmXoQ9k13S5RqqHR0cVKotNzORqQHPyjECUGeO8TelXkZwX/4sD9ZM+6l1VycCyxKmZQ4I4YjLeMe8YORgNrssU8ME56bq3+QhBbrFK0MRJD5iZEKBGzOug/NJk/+nclnczzRPEwztL2XH7fdOiNFbKEGe9MrnDZIOi4IGTar3z9Z8wzLmnbeW7Hi0PUkSECRAerTUZvOkdRed3mFJ9S8G9Bpx/e6fwzrKQcs4h2lMjxpLdUvmBw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=8qABAAvH1Bi4IVa+09q/nwNE1yzSoaRudcTcKA+srxQ=;
 b=bx00YxHIJ0aGs30h40/KHsJPDQP1EqhXZWVgevQvS/oD03JtsWqFlLReeXwBtx1LxEuEZhEARI+oGAvDms7wjC+N4th1E32S/yN+FV/s2MNQFo6d100y98l2rsv9+AAWc3qNVascrsWnieWG0aSctVM8wJYG9ZMz3THlvwtpJh2/A7AsCpdt5Bc4/6lZ3zVT8QEv6q30RwpXZ4gBW3dxE1eqlj5AnaklFXeFhKQgvYrWU9gwrZk0hEkdYASpGVgi07ANZiVajKxHwa/4K1eZvrvXAnZsBVw2bB7M4VtAYkDkhmz5PlNhtZXh+YXLgAxJN53ssG1KVToOI3dc0JWWVg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [XEN PATCH v7 16/51] build: generate "include/xen/compile.h" with
 if_changed
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>, xen-devel@lists.xenproject.org
References: <20210824105038.1257926-1-anthony.perard@citrix.com>
 <20210824105038.1257926-17-anthony.perard@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <e895337f-e640-f7ea-2737-036797fc939a@suse.com>
Date: Thu, 7 Oct 2021 16:55:01 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <20210824105038.1257926-17-anthony.perard@citrix.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0110.eurprd06.prod.outlook.com
 (2603:10a6:20b:465::29) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: c3f94c67-2d44-47ff-cacf-08d989a271ca
X-MS-TrafficTypeDiagnostic: VI1PR04MB2957:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB2957A2E01A2E436E9AE5BAABB3B19@VI1PR04MB2957.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:2958;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	aS6QCcZQTyh+4Ggpi6ouDFl0/WJFQD6IH5vAerOSlwc/ZEtGrUvQph4u75mM04U8bPU7ZScpSHaAl+KICHQR/F0I0jqVbqspUvXiB8PaDq1fTueDRwMd+KoTu3RAPKgdtUuyYxexn/iwU1VQscTMjiT8pLnwvhYFlyJvKB+A9oAHxpxGmig5r0Kxm/XMW98s6TL4F70iQpYh2460RhOT2SwT1TkmC3zIQ/jIfS+HnW3keOR6eKioDqNRGciyjpc2/34tElG8580C4gnwS3vMUm5KIvKxm1xn9mnUVNLLhgmDh1azl2wGJ0107U7Z1YMaDFJjCpmTtsqjfq4D9zgO/5YDDQ6bGh+uBLZ4H6h6h0UKNIRs5DdRHDw/slGxkWvxReLF8z38N0xR7TEGD3Q0EGJdcxNmlS2GrBF2MzqyURhghc9cU/kCDdw6q/DsLrF6QiyUs1UfYScD/DrOeaTh57WoWu4rrIrnRr1KmIhLOifwFG2296MzZ22ThP38vkuH/Q5faUa7dRIubOPxpJzu4MpiiE8OesW5B9lveFMccumAsX9M+pvf1dMyU2R1qOZ1CoQeZ4tItXqZeYzTIq4LOVvKsubVQFE7DAz2KGvvtqDq+90HO2ZTVVypFP4I0s+tOVJmyGCn2S8dDUQ3FWNNgO0lLGX9h0bgp4xGlGz8uBaEiVwKOL251BBjGRItbvimUXr7sdp+lAm7XD7IRXURZbVbxNwun6PYoRm5VSJDHOYjGyZ7JTvXT6I11IYb8RFJ
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(66556008)(8936002)(16576012)(66946007)(316002)(66476007)(5660300002)(6486002)(2906002)(26005)(31686004)(6916009)(31696002)(38100700002)(83380400001)(54906003)(8676002)(36756003)(2616005)(86362001)(4326008)(956004)(508600001)(186003)(53546011)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?T2l1ZTRaYUMvVTZ6bW1rWDlqU01mVWlrQnRXbE85a0Z0U1pDa0IwZ3B0Z3Ew?=
 =?utf-8?B?alpPZlpEYS9zT0QwYmFPTHYxUnRpc3FLdGhFQkw2SjJLOGNsamJlT0FaR1Ji?=
 =?utf-8?B?UDlEQkVsM044ekRJUUJMVHVoWW1EY2ZFT3N2UEZYc3pQTUNUWnp3UlJnZ2Js?=
 =?utf-8?B?cnhkU3pJRzFqc3MwOGN1RUNmTXppNlhONzFSVnFPa0xqa29OOGJ0RVhuemlD?=
 =?utf-8?B?WCsybUh1NlpFSW1RTTZmMXBkaWROelJPMWdxWTZrdTJPTHBzbUw4N1pYOEo3?=
 =?utf-8?B?N1pGSk1SSU41Y0JKRjZYK2ltVCtGbU8wUGYzMWh2a1BJTlZET2JhckdWVVZi?=
 =?utf-8?B?MXZuVHNaQ2JDTWthTnRMc2pvZnNzTTkxekR0QjBWTXNqNkt0bGpMN0NCT0pK?=
 =?utf-8?B?eXFLTlMrdjdERE9Xa2RvcWc5U1lQaFRwUWF2aVNUUlowMTM3anNGMmJqL3cv?=
 =?utf-8?B?QjJ2bDRkSDRuRWF0SzB3NUdUMTdBRnVlcElRSTJyaDE1eXFWTWFoTjFRb1pP?=
 =?utf-8?B?QnZUMXFzOXBkdzF1ZW52QXJNeE8waWRtYXpSQ1ZXY1pmZFI3VUZsVGxNdlhi?=
 =?utf-8?B?dGxxRHFhSXpXeUkwWmtaVVUzTjBNbnRiNE1UN2Vtclk3THJUVU1NeE5zek1J?=
 =?utf-8?B?RVQwUUtxNzc1UTl5bkxhUGxKaTRRTWpYOFhOdnFFcFJOMEJOcVNqaCtvMUxD?=
 =?utf-8?B?LzZ4M1lIS2kzZ0JYOGVmYk0rUm9LcjljMTFFS0oxZWE2Qy91WkN2cFBZMmZT?=
 =?utf-8?B?QzZaQ2JpUlRlOVVnUU9sZmtOWGl4M0M3RlFyLzlpRjNNMnBLWFk3QUN1T29V?=
 =?utf-8?B?NVlmVjczY3ZxTmc3eVpaV1AyNTV1U3ZpWS85RVJjSmQ1akJWczc3RzZHaGl3?=
 =?utf-8?B?S2w0SWlaTnBROUtQTXVkMmZrLzU2K0h4S0pPRG9YaTM4ZTFHSFN2UWVwMDhW?=
 =?utf-8?B?blRZcDgveTVadkU3RUQyNE00bHJQUVhPVHZ3TFp5MXVrSHBSSDJtbm9wdG51?=
 =?utf-8?B?aVgxYVdIeTZMN3p2UW9LTkk2TjJpNld4QUZEZ1IwMWsyV0hFbk5ZVnRnY2pD?=
 =?utf-8?B?KzNSM0RJREZsaDdWTnNFb3ZyUVpoNHlwd1QyamdhMklWTHdoeWlXcjhZVU56?=
 =?utf-8?B?dUVlZVlob0ZWT01BYU1SeGRSOXp2SFNoQmJTVnJqS1BGQVFCaE9tL2Z6emJr?=
 =?utf-8?B?eExvQ1ZITU8xTEJ2M25JL0doQTZSdVA0QVRGWHk4U2JRZFNpR1Z3TXRZbmN2?=
 =?utf-8?B?OEtuLzZIWnJmMUNVVnkvNEsyeWMvaXV0T2F6OVJXSXVhaDBzR1BVOVhTRVd5?=
 =?utf-8?B?dDhjcjZsbDByQ1ZTUUx4bGxHRmd1V1M5REpVUzQyYUIwWU80bkFZeklUZDIx?=
 =?utf-8?B?eitYMTJJK250Ui9wT1hkcnJhNitXNFM3S3FLeEZCSG5hUkVMK2hVU2VFcDRi?=
 =?utf-8?B?YncwbitoZ05qZk9KblMwcGlZYjhwQVVzOGxvRGFDRGxjcDUvQVBWczI2NGVL?=
 =?utf-8?B?cGZZb084bmFnRmJCS2MrOG80cllNQngxOTZKLzRuWmpyL081YnBPMHdsNlhC?=
 =?utf-8?B?ZzlNSk5CU2VteDNZVGtDSldDMHhCQUFiWnRxRnhycFk3VGtlcnlRR3ZIQmJn?=
 =?utf-8?B?UlNzS3NpekxhMDRxVmRhUzhDeHZId0dZR01xRFhESzZ3Q2VZL0dveEYvTDNy?=
 =?utf-8?B?NnFOS3IvblhRUkthNjFLbDhWVjVuL0NxYktaa1UremhnWmdjWDRjajk3OWV1?=
 =?utf-8?Q?ebIcseTcvoa57VvN38JejwMWL1FffdhSkoXGYyE?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c3f94c67-2d44-47ff-cacf-08d989a271ca
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Oct 2021 14:55:03.7787
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: EiIm1KZpFwXvwaiwVlQBRYSdH3nhdX45Tw0jwbL+bRtK699QHprPSjX7wkDGLbDnG/EvOX0ur5LST6gj8RZChg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB2957

On 24.08.2021 12:50, Anthony PERARD wrote:
> --- a/.gitignore
> +++ b/.gitignore
> @@ -332,7 +332,6 @@ xen/include/compat/*
>  xen/include/config/
>  xen/include/generated/
>  xen/include/public/public
> -xen/include/xen/*.new

While this indeed looks to only have been here for compile.h, I'm
not convinced it is a good idea to delete the entry here. Does it
cause any harm if left in place?

> --- a/xen/Makefile
> +++ b/xen/Makefile
> @@ -351,7 +351,7 @@ _debug:
>  	$(OBJDUMP) -D -S $(TARGET)-syms > $(TARGET).s
>  
>  .PHONY: _clean
> -_clean: delete-unfresh-files
> +_clean:
>  	$(MAKE) -C tools clean
>  	$(MAKE) $(clean) include
>  	$(MAKE) $(clean) common
> @@ -368,7 +368,7 @@ _clean: delete-unfresh-files
>  		-o -name "*.gcno" -o -name ".*.cmd" -o -name "lib.a" \) -exec rm -f {} \;
>  	rm -f include/asm $(TARGET) $(TARGET).gz $(TARGET).efi $(TARGET).efi.map $(TARGET)-syms $(TARGET)-syms.map *~ core
>  	rm -f asm-offsets.s arch/*/include/asm/asm-offsets.h
> -	rm -f .banner
> +	rm -f .banner include/xen/compile.h

Isn't this redundant with ...

> @@ -425,10 +419,16 @@ include/xen/compile.h: include/xen/compile.h.in .banner
>  	    -e 's/@@subversion@@/$(XEN_SUBVERSION)/g' \
>  	    -e 's/@@extraversion@@/$(XEN_EXTRAVERSION)/g' \
>  	    -e 's!@@changeset@@!$(shell tools/scmversion $(XEN_ROOT) || echo "unavailable")!g' \
> -	    < include/xen/compile.h.in > $@.new
> +	    < $< > $(dot-target).tmp; \
> +	sed -rf tools/process-banner.sed < .banner >> $(dot-target).tmp; \
> +	mv -f $(dot-target).tmp $@; \
> +    fi
> +endef
> +
> +include/xen/compile.h: include/xen/compile.h.in .banner FORCE
>  	@cat .banner
> -	@sed -rf tools/process-banner.sed < .banner >> $@.new
> -	@mv -f $@.new $@
> +	$(call if_changed,compile.h)
> +targets += include/xen/compile.h

... this? I would have hoped that $(targets) is included in the
generic cleaning logic ...

Jan



From xen-devel-bounces@lists.xenproject.org Thu Oct 07 15:11:30 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Oct 2021 15:11:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.203766.358905 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYV3D-0008H9-Vg; Thu, 07 Oct 2021 15:11:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 203766.358905; Thu, 07 Oct 2021 15:11:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYV3D-0008H1-Sc; Thu, 07 Oct 2021 15:11:15 +0000
Received: by outflank-mailman (input) for mailman id 203766;
 Thu, 07 Oct 2021 15:11:15 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=J5vh=O3=gmail.com=charles.fg@srs-us1.protection.inumbo.net>)
 id 1mYV3C-0008Gv-T5
 for xen-devel@lists.xen.org; Thu, 07 Oct 2021 15:11:14 +0000
Received: from mail-wr1-x435.google.com (unknown [2a00:1450:4864:20::435])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id e95d9915-1883-45f8-a578-7758b8477c49;
 Thu, 07 Oct 2021 15:11:14 +0000 (UTC)
Received: by mail-wr1-x435.google.com with SMTP id s15so20171624wrv.11
 for <xen-devel@lists.xen.org>; Thu, 07 Oct 2021 08:11:14 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e95d9915-1883-45f8-a578-7758b8477c49
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=mime-version:from:date:message-id:subject:to
         :content-transfer-encoding;
        bh=/p8VgXlEZzMe5nz8rRAzEOyKQbLSVqLZnUlACqpxKM4=;
        b=d1oaFCPRKw/shezxWLPXRYnFh6NMMVJ9LVaQcMBWLmQIhIZsIjltEgHAh7dGdGY/kI
         r2Y5Gi496IkM37DXJINFTx/vov1NCBG5P0GQmiXiWEea78o//UhKzdWfeD/ubVbh7Q5L
         44f4WOSF3NvjS56SPBSxwHCzrq2g8KDHjay+ymCplcGhA+t1Q2n7ayVC6rwlQ4yUZFLh
         4WpmQcLIGA+v10XJyBDR2brAUJxi4ze1Gg/0MxhnzCgoFU+0THRPVWL+VDvTgED8QmdT
         52mSARLYmP3yhQ7rz8XfLuhgUCfTG3VMMR6tbTemPKRxngDlwUFbiNab7SnnuCO2fOBo
         +WHQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:from:date:message-id:subject:to
         :content-transfer-encoding;
        bh=/p8VgXlEZzMe5nz8rRAzEOyKQbLSVqLZnUlACqpxKM4=;
        b=xPIt0xGZ8myiCKli0DlftEdcm9UrOurk4XMDk5k1vcyGLFiYlDYRoUgPD2Hdhlah+x
         9KuxoirLc2lJtDtuqneY7msLDhjAuwB08c/x6WydgsKIDmmp02MppnQfdvNYt5XbVAiI
         7tki/mDMWAXMLn4T3djYMiYz59g77faHUWurDH2OscR4CuaZulIjcffZPlI7zkV3oSBq
         nbTQ+lG9W+oMZzrhAGFa6RnSsl1L1womkSWI3kbUHrGDVUhNoUpnmXbsT21j6E2OVOLr
         kUqHsbUcIb+OHXjfNj5IXkzlJJP2TvpTK/LAIhuO/HTsVfTse96a6/H373fk0yc/0vy9
         EZVQ==
X-Gm-Message-State: AOAM53362PX3L84bydcL3uXYlJTvcPew/5JA2kV5KTek0N+NLOu22J7o
	LB2wlVf6n37bh40KCh5VOYaQCbAoaDQb+o8mMsenVQaqxEg87w==
X-Google-Smtp-Source: ABdhPJy5hMEIdP1aWv/bh6uICLcHPG+KEzPRzvWehxvz4x+nVSVllAQuJJq8jqgE4X5BiPMtL5yOBhUh3+vdHkGdTY0=
X-Received: by 2002:a5d:5250:: with SMTP id k16mr6312064wrc.82.1633619471840;
 Thu, 07 Oct 2021 08:11:11 -0700 (PDT)
MIME-Version: 1.0
From: =?UTF-8?Q?Charles_Gon=C3=A7alves?= <charles.fg@gmail.com>
Date: Thu, 7 Oct 2021 16:10:35 +0100
Message-ID: <CAAQRGoBQZ4mMWy2ibectwbN85oWvgcwus2rwO23u7BA7JWbf+A@mail.gmail.com>
Subject: PV - different behavior of pgd_offset in xen 4.6 and 4.13 for GUEST
 ACCESSIBLE memory area
To: xen-devel@lists.xen.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hello Guys,

During some experiments in my PhD I've tried to reused a code from
Jann Horn (https://bugs.chromium.org/p/project-zero/issues/detail?id=3D1184
) that used the mapping in

```
0xffff804000000000 - 0xffff807fffffffff [256GB, 2^38 bytes, PML4:256]
Reserved for future shared info with the guest OS (GUEST ACCESSIBLE)
```
to map some temporary page table data to be able to attack the system.

This used to work on Xen 4.6:

```
#define MY_SECOND_AREA 0xffff804000000000ULL
printk("PML4 entry: 0x%lx\n", (unsigned
long)pgd_val(*pgd_offset(current->mm, MY_SECOND_AREA)));
```

In xen 4.6 :

`[ 3632.620105] PML4 entry: 0x183d125067 `
Returns a valid PGD ( pgd_present(*pdg) =3D=3D true )

but has different behavior in Xen 4.13 (despite no change in the
asm-x86/config.h .

In xen 4.13:

`[70386.796119] PML4 entry: 0x800000021a445025`
Return a bad PGD ( pgd_bad(*pdg) =3D=3D true )

I could not find any reference on the branch RELEASE-4.13.0 of why
this happens this way.
Any hint of what is happening here?
Has Xen changed the way it handles memory from regions in range
0xffff804000000000 - 0xffff807fffffffff  across those versions?

I'm running on intel x64, on paravirtualization mode, the only
difference in the system is the xen version.


Atenciosamente,
Charles Ferreira Gon=C3=A7alves


From xen-devel-bounces@lists.xenproject.org Thu Oct 07 15:30:08 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Oct 2021 15:30:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.203795.358935 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYVLS-0003Q4-Tj; Thu, 07 Oct 2021 15:30:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 203795.358935; Thu, 07 Oct 2021 15:30:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYVLS-0003Px-QA; Thu, 07 Oct 2021 15:30:06 +0000
Received: by outflank-mailman (input) for mailman id 203795;
 Thu, 07 Oct 2021 15:30:05 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=9/ki=O3=arm.com=Rahul.Singh@srs-us1.protection.inumbo.net>)
 id 1mYVLR-0003Oy-Ij
 for xen-devel@lists.xenproject.org; Thu, 07 Oct 2021 15:30:05 +0000
Received: from EUR01-HE1-obe.outbound.protection.outlook.com (unknown
 [40.107.13.57]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id e3813c03-719e-4888-887b-4fa886017438;
 Thu, 07 Oct 2021 15:30:02 +0000 (UTC)
Received: from FR0P281CA0074.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1e::20)
 by AM0PR08MB4034.eurprd08.prod.outlook.com (2603:10a6:208:12e::11) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.15; Thu, 7 Oct
 2021 15:30:00 +0000
Received: from VE1EUR03FT046.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:d10:1e:cafe::2d) by FR0P281CA0074.outlook.office365.com
 (2603:10a6:d10:1e::20) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.4 via Frontend
 Transport; Thu, 7 Oct 2021 15:30:00 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT046.mail.protection.outlook.com (10.152.19.226) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4587.18 via Frontend Transport; Thu, 7 Oct 2021 15:30:00 +0000
Received: ("Tessian outbound 8e26f7114b75:v103");
 Thu, 07 Oct 2021 15:29:59 +0000
Received: from 70a12718b8b5.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 C88D5D7F-7CDF-48F9-9603-0493581D19DA.1; 
 Thu, 07 Oct 2021 15:29:49 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 70a12718b8b5.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Thu, 07 Oct 2021 15:29:49 +0000
Received: from AS8PR08MB6919.eurprd08.prod.outlook.com (2603:10a6:20b:39e::10)
 by AS8PR08MB6471.eurprd08.prod.outlook.com (2603:10a6:20b:338::8)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.22; Thu, 7 Oct
 2021 15:29:47 +0000
Received: from AS8PR08MB6919.eurprd08.prod.outlook.com
 ([fe80::51ee:e7de:6c0a:bcf9]) by AS8PR08MB6919.eurprd08.prod.outlook.com
 ([fe80::51ee:e7de:6c0a:bcf9%7]) with mapi id 15.20.4566.023; Thu, 7 Oct 2021
 15:29:47 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e3813c03-719e-4888-887b-4fa886017438
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=xMbvtsafk8HUbGV2INpIWlkzHN5DRDADVvr+1fMg1pM=;
 b=9sLPrO9Q0v77BhVLSNnUHNrjEtNFOYKxTymkDlLCaWgrYC6tNRU8hHgzOtA4UV7CWYiGyANrzeIhHvacYtbQ7uVK57xskl9YTZ3jgVbSq/VxDZT6oeOG5c75lc47WQJWIjZnH9/nPYggSD70ermjhZKH45ynXIGgRtEmdUaWZ/k=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 5e4891f7055c739b
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=P/rm0oIVXBPe8qB+Oghf+1kSiSCt+7CrQM4KzUR4WrqUKAkJuUOdWOP4VLbgeAaRrEyf20Mm4TqeQQyDL0un/f3lLmGfZpEg3ti89+WBRXGaFdvWQCzLL1SITNv+sabsD1CE8JYDUcPzTsvza4v1xHQnpySd5Sw4rOfggwjA8UqvXuN7P1xeGMwGH1SHIQr3To38LXK3ZqkTQhMKL4bUX7HIoq6KWrwNOJhwshPGR+7ZtOiTUwCI7wLbQ0DS7V6iJsXiUVNGE+G52RDUBB0Mv5RxliT40VcUrGv4HibKwTKfWbA5YaOgDPCm0AUi86tjEM4iwx1czId8EJ8/3wJi0A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=xMbvtsafk8HUbGV2INpIWlkzHN5DRDADVvr+1fMg1pM=;
 b=JfPyKIY8y7eIcBXlDo4YaIIAhTjjQo9evfAQZwk6jNWek9OqZqRM72QB/fTW3vTd1M3rZJaqnzoh1IJsUoIMhg9jsMm8BV6BN8htL7UEOpR6lycqhZSiU8ERmUY5j76wH3K1iozAnlWPItBlZq1PY1l4fSZ4fnxl4jUbpeILl406KIvQkx1FUi3JXnwlHmxhLfnLXZ1Gp6LiLtX7ZQnHDMhGzDAa3TGzMROzKupfwv5sz4oin6+RlTuBVLIUvdUfwRryPB8ub/6hD4AnOnM48Z67NPPNSulh3cSlDMOp+IBpPGpZUV7YuFae+nrGRVQXQiZ5D5qiLaInC9HL/My79A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=xMbvtsafk8HUbGV2INpIWlkzHN5DRDADVvr+1fMg1pM=;
 b=9sLPrO9Q0v77BhVLSNnUHNrjEtNFOYKxTymkDlLCaWgrYC6tNRU8hHgzOtA4UV7CWYiGyANrzeIhHvacYtbQ7uVK57xskl9YTZ3jgVbSq/VxDZT6oeOG5c75lc47WQJWIjZnH9/nPYggSD70ermjhZKH45ynXIGgRtEmdUaWZ/k=
From: Rahul Singh <Rahul.Singh@arm.com>
To: Ian Jackson <iwj@xenproject.org>
CC: Julien Grall <julien@xen.org>, xen-devel <xen-devel@lists.xenproject.org>,
	Bertrand Marquis <Bertrand.Marquis@arm.com>, Andre Przywara
	<Andre.Przywara@arm.com>, Wei Liu <wl@xen.org>, Anthony PERARD
	<anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>, Stefano
 Stabellini <sstabellini@kernel.org>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH v5 10/11] arm/libxl: Emulated PCI device tree node in
 libxl
Thread-Topic: [PATCH v5 10/11] arm/libxl: Emulated PCI device tree node in
 libxl
Thread-Index: AQHXutl6z4iIfi6+uESKx+Wr4ZB/gavGQpyAgAEa5QCAAE0egA==
Date: Thu, 7 Oct 2021 15:29:47 +0000
Message-ID: <294BE20A-7E45-405C-BC19-C292295E85E3@arm.com>
References: <cover.1633540842.git.rahul.singh@arm.com>
 <b81b5dea800c8fe47071f3dbd20588b1e472fb99.1633540842.git.rahul.singh@arm.com>
 <7bdac405-a889-15e1-be19-5876f7253855@xen.org>
 <24926.53690.621007.507249@mariner.uk.xensource.com>
In-Reply-To: <24926.53690.621007.507249@mariner.uk.xensource.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
Authentication-Results-Original: xenproject.org; dkim=none (message not
 signed) header.d=none;xenproject.org; dmarc=none action=none
 header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: 4eb702a6-a3a3-40c7-657b-08d989a75390
x-ms-traffictypediagnostic: AS8PR08MB6471:|AM0PR08MB4034:
x-ms-exchange-transport-forked: True
X-Microsoft-Antispam-PRVS:
	<AM0PR08MB40343ECD8E2B2714EDF62252FCB19@AM0PR08MB4034.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:10000;OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 8okzO+UjStjIfyPb0Ufayoc+VNkscfUt1WpJ92qQmJnxe8haQXynDoY9ui087u9vrDxh6oxKFX0h33DXgGlz4Z7UV+qYbLPfncs2cWUDadG4eHiMRgUrgDiQXgghL9+jVp5N+hq9Qcf1bUnwmAChldw7BNcEnESMXXoENNYTP5kOhO22U7hMb5QIULWyBZDBG8YnuEnmyQ3qhkFNxj4Tj7wZ1R0VqyizJfJvDg6Zlvz3ftVg6nLBLb/fyh/61idzI15Jq5H4/A6HdUxMan1dorAjIT+V29WEB/ou862KwtM+keHzgwibHHdOC6PYEa3BuLa281M/EP3aWfb/z44kyrucb5SA0BKZC9ogmgBeImel8xHJiw8Co95ettdGOujvUDMdlaqxHgDX6+e/hVXSbdOPU/1DZBoKzytt1+xqtQhU0OwcHfabw30v9d2Z1MlsvCXxwh5jBHZ8ssNZgEbIgXW8lLV7Xnk0Tq3O0DZHI83t3/71mp2IzSRktqgon6SN0GiDqoe+w+ysx5RYipu6vAyfE+ffTw9QUngj//tvYJC5YTXgs6kVvXiFcMC2erA9baCpS7Bonsn6gA0bkiKOiA5pev5SymAUxCccGmqH8GMNBDTUAZOAUsFfXGWQRJCBxbsyiWMjxuAcyAQhwoanXsi1gInfJ1cljwuf+HM18LSDvxDyMhbx4d8cJbUepUgm3azka+YTzmjglG0VE80vDOeyEoQnhth8gVfpuXMFe3URuy5SVfUKuSnQNa9MyqRc
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6919.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(66476007)(4326008)(64756008)(36756003)(38100700002)(66556008)(8676002)(508600001)(2906002)(5660300002)(76116006)(66446008)(186003)(71200400001)(26005)(2616005)(66946007)(83380400001)(316002)(53546011)(6486002)(122000001)(6512007)(6506007)(38070700005)(33656002)(86362001)(54906003)(8936002)(6916009)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="us-ascii"
Content-ID: <9637212E0FBFC944BBEB934E53E2BF1B@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6471
Original-Authentication-Results: xenproject.org; dkim=none (message not signed)
 header.d=none;xenproject.org; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT046.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	7f749df1-d233-4aaf-4994-08d989a74bdb
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	pLqTbdlCenlnWSNh25RUJpyerPLN3ZVPVi7CiGiI2PErqn6TjI49DZP70FS/zA5qM5ZxiHoVMDsADs270WGvr04HqmU+UCgiDAI2kwNoPnyuBDKMM2+h7eP2BHvmLlAblAeTdrW6zeDXB6LElFo7YlEvHUQR0G1YpfSZtkvmKifMyBxrLYuN/subJfy19X6VOA9MXtJZpzl8GF2t6qBYkM9ARRQCRz288F1STloEUxER2Hbd8Sml9sU+PPT72kKubLBoSHr/SpbBlmYelEfhycA4pQweaKLr+jnv+HGF7f5lLQsI0PHLyDSMSTjJtgdBCuffLZoEgI40DMkvJdsXc8Uq75aEndlQadovCB8cVNio33dh5c3Ch7qg8Yqerv7+YtwemDYSFh04aQBdIIqHQ5X3CHuAiQuUBhPR4A3CJpsOBbTtM3PiQVL6TbQNabaf3P8Jsh6cC9GQ3ljjjmURXYz2GMQLqaeSYTOe9onD6xoLrf3wkny2e2e92+7SgeewxaiQexUT1uLSfwCKf52QVFRjFdeIgJlPYw9bYQcOsk3WZKiMqLMWUzGCmgv0FXxWvCbwee/DrmDd2mrKQqKlgusXs5bcttZhzl+iEBsycICIpPXn6gTY0wnhFr/9nNcRfiffQeo8q/Fy4w5rZUsN/qfnFEJvtE311gLe9CswyQgFKCDkwCCnMmu4D/DpQvvYymWdTBaGAT+RPBurBmA3uQ==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(53546011)(508600001)(186003)(6486002)(6862004)(6506007)(33656002)(26005)(336012)(36860700001)(47076005)(2616005)(4326008)(36756003)(2906002)(8676002)(70206006)(83380400001)(356005)(70586007)(82310400003)(81166007)(54906003)(6512007)(8936002)(107886003)(86362001)(316002)(5660300002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Oct 2021 15:30:00.3142
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 4eb702a6-a3a3-40c7-657b-08d989a75390
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT046.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB4034

Hi Ian,

> On 7 Oct 2021, at 11:53 am, Ian Jackson <iwj@xenproject.org> wrote:
>=20
> Julien Grall writes ("Re: [PATCH v5 10/11] arm/libxl: Emulated PCI device=
 tree node in libxl"):
>> On 06/10/2021 19:40, Rahul Singh wrote:
>>> diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_=
types.idl
>>> index 3f9fff653a..78b1ddf0b8 100644
>>> --- a/tools/libs/light/libxl_types.idl
>>> +++ b/tools/libs/light/libxl_types.idl
>>> @@ -644,6 +644,7 @@ libxl_domain_build_info =3D Struct("domain_build_in=
fo",[
>>>=20
>>>      ("arch_arm", Struct(None, [("gic_version", libxl_gic_version),
>>>                                 ("vuart", libxl_vuart_type),
>>> +                               ("vpci", libxl_defbool),
>>=20
>> I have posted some comments regarding the field in v4. To summarize,=20
>> AFAICT, this option is meant to be only set by libxl but you still let=20
>> the toolstack (e.g. xl, libvirt) to set it.
>>=20
>> If you still want to expose to the toolstack, then I think the option=20
>> should be outside of arch_arm. Otherwise, this should be moved in an=20
>> internal structure (Ian, do you have any suggestion?).
>=20
> If it should be in an internal structure, probably the libxl create
> context.

As Stefano suggested in another email that we can remove the vpci option, i=
f we=20
reach to conclusion that we need vpci option I will move it to internal str=
ucture.
=20
> =20
> But I'm not convinced yet.  In particular, if enabling VPCI is
> necessary on ARM for hotplugged PCI devices[1], then there has to be
> a way for the admin to say "while this domain may not have any PCI
> devices right now, I may wish to hotplug some".  That's what the
> "passthrough=3D" option is for.

Yes I agree with you VPCI is necessary for hot plugged PCI device and once =
we=20
implement the hotplug in future we will use the passthrough=3D option to en=
able VPCI.

Regards,
Rahul =20

>=20
> See my other mail.
>=20
> [1] I think this is all true even if PCI hotplug for ARM is not
> currently implemented.
>=20
> Ian.



From xen-devel-bounces@lists.xenproject.org Thu Oct 07 15:31:48 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Oct 2021 15:31:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.203806.358946 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYVN2-00045W-DW; Thu, 07 Oct 2021 15:31:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 203806.358946; Thu, 07 Oct 2021 15:31:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYVN2-00045P-9e; Thu, 07 Oct 2021 15:31:44 +0000
Received: by outflank-mailman (input) for mailman id 203806;
 Thu, 07 Oct 2021 15:31:43 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=9/ki=O3=arm.com=Rahul.Singh@srs-us1.protection.inumbo.net>)
 id 1mYVN1-000455-82
 for xen-devel@lists.xenproject.org; Thu, 07 Oct 2021 15:31:43 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com (unknown
 [40.107.20.87]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id b636325f-36b0-40af-943a-f6ad56de7d4f;
 Thu, 07 Oct 2021 15:31:35 +0000 (UTC)
Received: from AM6PR0502CA0058.eurprd05.prod.outlook.com
 (2603:10a6:20b:56::35) by HE1PR0801MB1836.eurprd08.prod.outlook.com
 (2603:10a6:3:89::16) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.22; Thu, 7 Oct
 2021 15:31:33 +0000
Received: from AM5EUR03FT035.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:56:cafe::e6) by AM6PR0502CA0058.outlook.office365.com
 (2603:10a6:20b:56::35) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.14 via Frontend
 Transport; Thu, 7 Oct 2021 15:31:32 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM5EUR03FT035.mail.protection.outlook.com (10.152.16.119) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4587.18 via Frontend Transport; Thu, 7 Oct 2021 15:31:32 +0000
Received: ("Tessian outbound d5def7722ff7:v103");
 Thu, 07 Oct 2021 15:31:32 +0000
Received: from 80b2d477551c.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 A974E6C4-D6B2-4C41-98B6-973A895E193A.1; 
 Thu, 07 Oct 2021 15:31:25 +0000
Received: from EUR01-HE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 80b2d477551c.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Thu, 07 Oct 2021 15:31:25 +0000
Received: from AS8PR08MB6919.eurprd08.prod.outlook.com (2603:10a6:20b:39e::10)
 by AM6PR08MB4866.eurprd08.prod.outlook.com (2603:10a6:20b:c8::15)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.21; Thu, 7 Oct
 2021 15:31:22 +0000
Received: from AS8PR08MB6919.eurprd08.prod.outlook.com
 ([fe80::51ee:e7de:6c0a:bcf9]) by AS8PR08MB6919.eurprd08.prod.outlook.com
 ([fe80::51ee:e7de:6c0a:bcf9%7]) with mapi id 15.20.4566.023; Thu, 7 Oct 2021
 15:31:22 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b636325f-36b0-40af-943a-f6ad56de7d4f
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Z3vr1TjeNbdwYM/J82wk/tF5Zbaky28uluXA1Eqz5Tg=;
 b=ikJRrZVDByMoUO+i5YpjkIami8XcHnPPy5V9MPtz1qhpLU9/BmghcdiYein7uPyTgDknZjZzAp6u5n1FUzI2Ks6zwn5W3vly/w9uuKEhKfe+lWm5rQ4a+5c16p+aFoLEd2a170IZreCMAoqmfi8xyQdVwxaTcs5qRjDB6zOJPj0=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 5e8800bc44272869
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=g2T7CjoXziitnV6ssDCzy3h5LrqSD/PiWaXbNQHCjqGccYjWWZgh3ia5Qx79JqF0Wxcme6OdQtN6g2lHPGaUZKCR2/OW16N8ZzienaMYXPKUVRprw1GU7oiGyFarnlo+OeU3Syo6xFYRNdmYRhDh898YCH4fZ98CRLYua0M/iToqMmnnNnNokKQp4C9fonNJaz6p/nZcE+nsLc2/mjj1vw9GFhwTxlBOH+W5OJfTj02nozhVvCoCxtDYSIbVOqJnttts/gHN6MRQPWDL65AL5tRbyChVf5RTq7YAF87fFzmUsUB8RRf0tpGUPpEsZkhZQJCXxQICKTtJgRgnDpxOLg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Z3vr1TjeNbdwYM/J82wk/tF5Zbaky28uluXA1Eqz5Tg=;
 b=DsTayZkB1nky5W74DzkKPT/YVCE77Df0dvyr6Agf8vDb2z0BTh6iDoosKBz6bCYHHUOjfWKgcUmy3JtGPWsWFBOt2yqquuntoywcHQALYK1sIGwpra1RlO7f+k64VZ6Vt9gL8jbbrfXtmy/i+NxEa4matLB6qM8jXm1ySNqwByVeQN+gP7FKSFHe4CtYTOIhDJ16pCojcyctj6RU0oztmr0Aaa/aYEqprtJGvFzzFXhHVzVooQhLvIMuF0HxYuErJSQEz+msk4G1BmmFd3QNTUv8ylVhI/82LlMl+PLprwzJAgWK4JFrsj6xe9V+HHShYCrzyLEkotdzjs5vN+v4rQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Z3vr1TjeNbdwYM/J82wk/tF5Zbaky28uluXA1Eqz5Tg=;
 b=ikJRrZVDByMoUO+i5YpjkIami8XcHnPPy5V9MPtz1qhpLU9/BmghcdiYein7uPyTgDknZjZzAp6u5n1FUzI2Ks6zwn5W3vly/w9uuKEhKfe+lWm5rQ4a+5c16p+aFoLEd2a170IZreCMAoqmfi8xyQdVwxaTcs5qRjDB6zOJPj0=
From: Rahul Singh <Rahul.Singh@arm.com>
To: Stefano Stabellini <sstabellini@kernel.org>
CC: Julien Grall <julien@xen.org>, Ian Jackson <iwj@xenproject.org>, xen-devel
	<xen-devel@lists.xenproject.org>, Bertrand Marquis
	<Bertrand.Marquis@arm.com>, Andre Przywara <Andre.Przywara@arm.com>, Wei Liu
	<wl@xen.org>, Anthony PERARD <anthony.perard@citrix.com>, Juergen Gross
	<jgross@suse.com>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH v5 10/11] arm/libxl: Emulated PCI device tree node in
 libxl
Thread-Topic: [PATCH v5 10/11] arm/libxl: Emulated PCI device tree node in
 libxl
Thread-Index: AQHXutl6z4iIfi6+uESKx+Wr4ZB/gavGQpyAgABrjQCAAPznAA==
Date: Thu, 7 Oct 2021 15:31:22 +0000
Message-ID: <CE10B2F3-2427-4C64-9912-0FE207569628@arm.com>
References: <cover.1633540842.git.rahul.singh@arm.com>
 <b81b5dea800c8fe47071f3dbd20588b1e472fb99.1633540842.git.rahul.singh@arm.com>
 <7bdac405-a889-15e1-be19-5876f7253855@xen.org>
 <alpine.DEB.2.21.2110061708500.3209@sstabellini-ThinkPad-T480s>
In-Reply-To: <alpine.DEB.2.21.2110061708500.3209@sstabellini-ThinkPad-T480s>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
Authentication-Results-Original: kernel.org; dkim=none (message not signed)
 header.d=none;kernel.org; dmarc=none action=none header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: 64a583f1-6840-4d4d-54b7-08d989a78aa0
x-ms-traffictypediagnostic: AM6PR08MB4866:|HE1PR0801MB1836:
x-ms-exchange-transport-forked: True
X-Microsoft-Antispam-PRVS:
	<HE1PR0801MB1836397107788C7595E9DB42FCB19@HE1PR0801MB1836.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:10000;OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 DljM6XBj8WVcI+QO/UsggCvE0Qm49zHv/h7lJvHtt/9eUTVoRPpxaYIaMRt9bDOZAIfCkVkt8oLGE8Sh4QHltZeBUEUAxnLvmOJwy0Wu/Ly56BXgPAC12N24ghyyK3dUgNtAL5eiOGZ8masv3g51NW4Tmyb44XyhS32iRJnW7jtGOVwVvOflcyDHUX+/uwMQT4RMSiphllcKZ/DkXbg6M/xM6M6g8SrKyvuEkpVX0pXiT/VPIzc8KY0vfemNPXp+ZBW1nrPSQMGoItwyn+mSrwcHWZq0H+1YdggGwRfTLZLG5vZ0MheNj8+mWdUdnUqjSX+F0bOoO/8CqoYgZ4/FV4NTaSqKG2gAddcy3dke0gpyQGe82m0c73O/5+NUu7erxe4QdU7Ys/LD20q8kouEsC8JwpfXlZnJrm3XBQMih+kXkFpuv5nf7VrMHw2KETtD7VM+VWR2R/xSLywYcTmXUpHPjpghranovty99lSGaKLn8mFIJV4P73UYw/XmpZx+uLHm5LCwlm5brmfX573XrfiLKDJ2nkk0VAIZsULDcCvT4sLGAlD/J5eEtklLxBM6F44owZDY6/3OgZvFcduDOsSzNMbM0ZSTjGEPvaaD1KfkK/B1gsIJJSblfzgFs/Yv6hwJ9W1jC5LzG5OigDobKj7pnHK29WZZknLUPG+B7A6a6NdXg619qWS32NstOqBY871vzGpTs2znTqcdKScmGAmd4nFckCGnpDh//DrSxBHtrKR0OOeVCkhcZqGlAAFy
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6919.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(83380400001)(4326008)(66476007)(2616005)(6916009)(8936002)(5660300002)(26005)(36756003)(6512007)(38100700002)(8676002)(2906002)(186003)(6486002)(66946007)(66556008)(64756008)(76116006)(33656002)(316002)(6506007)(53546011)(66446008)(71200400001)(86362001)(91956017)(38070700005)(54906003)(122000001)(508600001)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-ID: <3C9440F40245254985C1D32948BE824E@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB4866
Original-Authentication-Results: kernel.org; dkim=none (message not signed)
 header.d=none;kernel.org; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM5EUR03FT035.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	5d9486be-56dd-49ff-473e-08d989a784c2
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	uTZ4cJSHHAtF5wl5GM6+/B3A9xRvaUFlovOLOhaRRgLxwQYeKoFfOWNOcdHDuXLkInESMVK+XiSH0EtRZF7wdWlibuUOLErP8WNACXqKRDvHyEeml+NTgq06cKflStt3u5PcMP5HjvSnyh1URqC2sPNfqiwZIUpYASJUCoO3oynw2U2X9l70CQS9EQQ6IqlifU9km/hbKpBR1QnB+UXlt/WO1WEeNPOSBi38cwVnmblc5IPizZVoeGE1y7Fqxxrf+wwBpqGTz/xsgbfH+bqpD20eeywmWJCjRn82Y6cjfqMiZzfS/6dSS4WT4GCEk4ySnszYpgiZ11KdzwmMV7qJd75gHCtPE2K2GD27oWq3kP3nW5tBDu9uz1jJX5s4vmOEykw0knGPm/GxDhs+DeL6t4wxciGADurNSEEMH0lwSYdhOBLzmZ/R+7Nn2JUY3ffQHoLe9GDBCHnJadgtkk5NBVkMbcy82KBD4efMqQWSWFSMZC92SroS+u9y5gt7d1vS5TcXejffsE8gLvk6dGv/wMORAVl0ti4iGGxvgAAiXwinvxXkkBdoC38m/HxlOJn686f7zOtTl45a7r10IHyWj1IGoXv3/pLuONExanBsKZwyPlboIvSVgUaDySzBSrJjFzH81pc7SdteJ1+FoH3qPn0MqoB7j4N3XPUE/4gKXgvmvDZUW062d5nn3DvlfQkDeBx06I4YLpAUe2aqk0w2jg==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(6512007)(33656002)(36756003)(336012)(8936002)(70206006)(26005)(508600001)(86362001)(5660300002)(2906002)(6486002)(36860700001)(2616005)(8676002)(70586007)(6506007)(186003)(316002)(82310400003)(81166007)(4326008)(83380400001)(6862004)(107886003)(53546011)(54906003)(356005)(47076005);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Oct 2021 15:31:32.7133
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 64a583f1-6840-4d4d-54b7-08d989a78aa0
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM5EUR03FT035.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0801MB1836

SGkgU3RlZmFubywNCg0KPiBPbiA3IE9jdCAyMDIxLCBhdCAxOjI2IGFtLCBTdGVmYW5vIFN0YWJl
bGxpbmkgPHNzdGFiZWxsaW5pQGtlcm5lbC5vcmc+IHdyb3RlOg0KPiANCj4gT24gV2VkLCA2IE9j
dCAyMDIxLCBKdWxpZW4gR3JhbGwgd3JvdGU6DQo+PiBIaSBSYWh1bCwNCj4+IA0KPj4gT24gMDYv
MTAvMjAyMSAxOTo0MCwgUmFodWwgU2luZ2ggd3JvdGU6DQo+Pj4gZGlmZiAtLWdpdCBhL3Rvb2xz
L2xpYnMvbGlnaHQvbGlieGxfdHlwZXMuaWRsDQo+Pj4gYi90b29scy9saWJzL2xpZ2h0L2xpYnhs
X3R5cGVzLmlkbA0KPj4+IGluZGV4IDNmOWZmZjY1M2EuLjc4YjFkZGYwYjggMTAwNjQ0DQo+Pj4g
LS0tIGEvdG9vbHMvbGlicy9saWdodC9saWJ4bF90eXBlcy5pZGwNCj4+PiArKysgYi90b29scy9s
aWJzL2xpZ2h0L2xpYnhsX3R5cGVzLmlkbA0KPj4+IEBAIC02NDQsNiArNjQ0LDcgQEAgbGlieGxf
ZG9tYWluX2J1aWxkX2luZm8gPSBTdHJ1Y3QoImRvbWFpbl9idWlsZF9pbmZvIixbDQo+Pj4gICAg
ICAgICgiYXJjaF9hcm0iLCBTdHJ1Y3QoTm9uZSwgWygiZ2ljX3ZlcnNpb24iLCBsaWJ4bF9naWNf
dmVyc2lvbiksDQo+Pj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoInZ1YXJ0Iiwg
bGlieGxfdnVhcnRfdHlwZSksDQo+Pj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAo
InZwY2kiLCBsaWJ4bF9kZWZib29sKSwNCj4+IA0KPj4gSSBoYXZlIHBvc3RlZCBzb21lIGNvbW1l
bnRzIHJlZ2FyZGluZyB0aGUgZmllbGQgaW4gdjQuIFRvIHN1bW1hcml6ZSwgQUZBSUNULA0KPj4g
dGhpcyBvcHRpb24gaXMgbWVhbnQgdG8gYmUgb25seSBzZXQgYnkgbGlieGwgYnV0IHlvdSBzdGls
bCBsZXQgdGhlIHRvb2xzdGFjaw0KPj4gKGUuZy4geGwsIGxpYnZpcnQpIHRvIHNldCBpdC4NCj4+
IA0KPj4gSWYgeW91IHN0aWxsIHdhbnQgdG8gZXhwb3NlIHRvIHRoZSB0b29sc3RhY2ssIHRoZW4g
SSB0aGluayB0aGUgb3B0aW9uIHNob3VsZA0KPj4gYmUgb3V0c2lkZSBvZiBhcmNoX2FybS4gT3Ro
ZXJ3aXNlLCB0aGlzIHNob3VsZCBiZSBtb3ZlZCBpbiBhbiBpbnRlcm5hbA0KPj4gc3RydWN0dXJl
IChJYW4sIGRvIHlvdSBoYXZlIGFueSBzdWdnZXN0aW9uPykuDQo+IA0KPiANCj4gRmlyc3QgbGV0
IG1lIHByZW1pc2UgdGhhdCB0aGUgcGF0Y2ggaXMgbXVjaCBiZXR0ZXIgYWxyZWFkeSBhbmQgUmFo
dWwNCj4gYWRkZXNzZWQgbXkgcmVxdWVzdCB3ZWxsLiBIb3dldmVyLCBKdWxpZW4ncyBwb2ludCBh
Ym91dCBub3Qgd2FudGluZyB0bw0KPiBtYWtlIGEgcG90ZW50aWFsbHkgYnJlYWtpbmcgQUJJIGNo
YW5nZSBpbiBsaWJ4bCBpcyBhIGdvb2Qgb25lLiBGWUkgd2UNCj4gaGFkIGEgZmV3IGxpYnZpcnQg
YnJlYWthZ2VzIGR1ZSB0byB0aGlzIGtpbmQgb2YgY2hhbmdlcyBpbiB0aGUgcGFzdCBhbmQNCj4g
SSB3b3VsZCBjZXJ0YWlubHkgYmUgaGFwcGllciBpZiB3ZSBkaWRuJ3QgY2F1c2UgYW5vdGhlciBv
bmUuIEFuZCBpbg0KPiBnZW5lcmFsLCBpdCBpcyBiZXR0ZXIgdG8gYXZvaWQgY2hhbmdlcyB0byB0
aGUgbGlieGwgQUJJIGlmIHdlIGNhbi4NCj4gDQo+IEkgdGhpbmsgaW4gdGhpcyBjYXNlIHdlIGNh
bjogSSBsb29rZWQgYXQgdGhlIHBhdGNoIGFuZA0KPiBiX2luZm8uYXJjaF9hcm0udnBjaSBpcyBv
bmx5IHVzZWQgd2l0aGluIHRvb2xzL2xpYnMvbGlnaHQvbGlieGxfYXJtLmMuDQo+IEFsc28sIHdl
IGRvbid0IG5lZWQgYl9pbmZvLmFyY2hfYXJtLnZwY2kgaWYgd2UgY2FuIGFjY2Vzcw0KPiBkX2Nv
bmZpZy0+bnVtX3BjaWRldnMgZ2l2ZW4gdGhhdCB0aGUgY2hlY2sgaXMganVzdCBiYXNlZCBvbg0K
PiBkX2NvbmZpZy0+bnVtX3BjaWRldnMuDQo+IA0KPiBTbyB0aGUgb25seSBpc3N1ZSBpcyBob3cg
dG8gY2hlY2sgb24gZF9jb25maWctPm51bV9wY2lkZXZzIGluDQo+IGxpYnhsX19wcmVwYXJlX2R0
Yi4gbGlieGxfX3ByZXBhcmVfZHRiIHRha2VzIGxpYnhsX2RvbWFpbl9idWlsZF9pbmZvIGFzDQo+
IHBhcmFtZXRlciBidXQgd2l0aCBjb250YWluZXJfb2Ygd2UgY2FuIHJldHJpZXZlIGxpYnhsX2Rv
bWFpbl9jb25maWcgYW5kDQo+IGZyb20gdGhlcmUgY2hlY2sgb24gbnVtX3BjaWRldnMuDQo+IA0K
PiBTb21ldGhpbmcgbGlrZSB0aGUgYXBwZW5kZWQgKHVudGVzdGVkKS4gSXQgZG9lc24ndCBuZWVk
IGFueSBsaWJ4bCBzdHJ1Y3QNCj4gY2hhbmdlcyBidXQgaXQgcmVxdWlyZXMgdGhlIGludHJvZHVj
dGlvbiBvZiBjb250YWluZXJfb2YgKHdoaWNoIGlzIGENCj4gc2ltcGxlIG1hY3JvKS4gQWx0ZXJu
YXRpdmVseSwgaXQgd291bGQgYmUganVzdCBhcyBzaW1wbGUgdG8gY2hhbmdlDQo+IGxpYnhsX19h
cmNoX2RvbWFpbl9pbml0X2h3X2Rlc2NyaXB0aW9uIGFuZCBsaWJ4bF9fcHJlcGFyZV9kdGIgdG8g
dGFrZSBhDQo+IGxpYnhsX2RvbWFpbl9jb25maWcgKmRfY29uZmlnIHBhcmFtZXRlciBpbnN0ZWFk
IG9mIGENCj4gbGlieGxfZG9tYWluX2J1aWxkX2luZm8gKmluZm8gcGFyYW1ldGVyLg0KDQpUaGFu
a3MgZm9yIHNoYXJpbmcgdGhlIGlkZWFzIHRvIHJlbW92ZSB0aGUgYXJjaF9hcm0udnBjaSBmaWVs
ZC4gDQpJIGFtIG9rIHdpdGggYW55IG9wdGlvbnMsIGJ1dCBJIGZlZWwgc2Vjb25kIG9wdGlvbiBp
cyBzaW1wbGUgYW5kIGJldHRlciB0byBhdm9pZCAgDQppbnRyb2R1Y3Rpb24gb2YgY29udGFpbmVy
X29mKCkuIEkgdGVzdGVkIHRoZSBzZWNvbmQgb3B0aW9uIGFuZCBpcyB3b3JraW5nIGZpbmUuDQpJ
ZiBldmVyeW9uZSBhZ3JlZSB0aGF0IHdlIGRvbuKAmXQgbmVlZCB2cGNpIG9wdGlvbiBJIHdpbGwg
c2VuZCB0aGUgcGF0Y2ggZm9yIHJldmlldw0KSW4gbmV4dCB2ZXJzaW9uLg0KDQpSZWdhcmRzLA0K
UmFodWwNCj4gDQo+IElhbiwgYW55IHRob3VnaHRzPw0KPiANCj4gDQo+IGRpZmYgLS1naXQgYS90
b29scy9saWJzL2xpZ2h0L2xpYnhsX2FybS5jIGIvdG9vbHMvbGlicy9saWdodC9saWJ4bF9hcm0u
Yw0KPiBpbmRleCAyYmUyMDhiOTliLi5lZTExNzY1MTljIDEwMDY0NA0KPiAtLS0gYS90b29scy9s
aWJzL2xpZ2h0L2xpYnhsX2FybS5jDQo+ICsrKyBiL3Rvb2xzL2xpYnMvbGlnaHQvbGlieGxfYXJt
LmMNCj4gQEAgLTEwMiwxMCArMTAyLDggQEAgaW50IGxpYnhsX19hcmNoX2RvbWFpbl9wcmVwYXJl
X2NvbmZpZyhsaWJ4bF9fZ2MgKmdjLA0KPiAgICAgfQ0KPiANCj4gICAgIC8qIEVuYWJsZSBWUENJ
IHN1cHBvcnQuICovDQo+IC0gICAgaWYgKGRfY29uZmlnLT5udW1fcGNpZGV2cykgew0KPiArICAg
IGlmIChkX2NvbmZpZy0+bnVtX3BjaWRldnMpDQo+ICAgICAgICAgY29uZmlnLT5mbGFncyB8PSBY
RU5fRE9NQ1RMX0NERl92cGNpOw0KPiAtICAgICAgICBsaWJ4bF9kZWZib29sX3NldCgmZF9jb25m
aWctPmJfaW5mby5hcmNoX2FybS52cGNpLCB0cnVlKTsNCj4gLSAgICB9DQo+IA0KPiAgICAgcmV0
dXJuIDA7DQo+IH0NCj4gQEAgLTk3Niw2ICs5NzQsNyBAQCBzdGF0aWMgaW50IGxpYnhsX19wcmVw
YXJlX2R0YihsaWJ4bF9fZ2MgKmdjLCBsaWJ4bF9kb21haW5fYnVpbGRfaW5mbyAqaW5mbywNCj4g
DQo+ICAgICBjb25zdCBsaWJ4bF92ZXJzaW9uX2luZm8gKnZlcnM7DQo+ICAgICBjb25zdCBzdHJ1
Y3QgYXJjaF9pbmZvICphaW5mbzsNCj4gKyAgICBsaWJ4bF9kb21haW5fY29uZmlnICpkX2NvbmZp
ZyA9IGNvbnRhaW5lcl9vZihpbmZvLCBsaWJ4bF9kb21haW5fY29uZmlnLCBiX2luZm8pOw0KPiAN
Cj4gICAgIHZlcnMgPSBsaWJ4bF9nZXRfdmVyc2lvbl9pbmZvKENUWCk7DQo+ICAgICBpZiAodmVy
cyA9PSBOVUxMKSByZXR1cm4gRVJST1JfRkFJTDsNCj4gQEAgLTEwNzYsNyArMTA3NSw3IEBAIG5l
eHRfcmVzaXplOg0KPiAgICAgICAgIGlmIChpbmZvLT50ZWUgPT0gTElCWExfVEVFX1RZUEVfT1BU
RUUpDQo+ICAgICAgICAgICAgIEZEVCggbWFrZV9vcHRlZV9ub2RlKGdjLCBmZHQpICk7DQo+IA0K
PiAtICAgICAgICBpZiAobGlieGxfZGVmYm9vbF92YWwoaW5mby0+YXJjaF9hcm0udnBjaSkpDQo+
ICsgICAgICAgIGlmIChkX2NvbmZpZy0+bnVtX3BjaWRldnMpDQo+ICAgICAgICAgICAgIEZEVCgg
bWFrZV92cGNpX25vZGUoZ2MsIGZkdCwgYWluZm8sIGRvbSkgKTsNCj4gDQo+ICAgICAgICAgaWYg
KHBmZHQpDQoNCg==


From xen-devel-bounces@lists.xenproject.org Thu Oct 07 16:12:03 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Oct 2021 16:12:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.203838.358982 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYVzw-0001cB-2y; Thu, 07 Oct 2021 16:11:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 203838.358982; Thu, 07 Oct 2021 16:11:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYVzv-0001c4-Vn; Thu, 07 Oct 2021 16:11:55 +0000
Received: by outflank-mailman (input) for mailman id 203838;
 Thu, 07 Oct 2021 16:11:54 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mYVzu-0001by-HE
 for xen-devel@lists.xenproject.org; Thu, 07 Oct 2021 16:11:54 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mYVzu-0007hB-5u
 for xen-devel@lists.xenproject.org; Thu, 07 Oct 2021 16:11:54 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mYVzu-0002YI-59
 for xen-devel@lists.xenproject.org; Thu, 07 Oct 2021 16:11:54 +0000
Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89)
 (envelope-from <iwj@xenproject.org>)
 id 1mYVzn-0006tj-W3; Thu, 07 Oct 2021 17:11:48 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date
	:Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From;
	bh=bNKObHLvuYHl9RRVVlwnULETAyQzOqANMlh/V3j4NUM=; b=x2K4LBapGsb4ob13njGRroJD4o
	EwY1uEcRVMTfnhUgl4LPrZc3j5Rz4mdfjI09U+QklBMAyc6GqBcjw4Jpo3uuf33Tr6zDi/3Rvgdv8
	/YPFge6YmpCZnFI7ngx7WYoaBoH28JGIFA9FPABvsIKNQyVtZKUD84OyiRbzshZ/EFYA=;
From: Ian Jackson <iwj@xenproject.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <24927.7235.736221.270358@mariner.uk.xensource.com>
Date: Thu, 7 Oct 2021 17:11:47 +0100
To: Rahul Singh <Rahul.Singh@arm.com>
Cc: Ian Jackson <iwj@xenproject.org>,
    Julien Grall <julien@xen.org>,
    xen-devel <xen-devel@lists.xenproject.org>,
    Bertrand Marquis <Bertrand.Marquis@arm.com>,
    Andre Przywara <Andre.Przywara@arm.com>,
    Wei Liu <wl@xen.org>,
    Anthony PERARD <anthony.perard@citrix.com>,
    Juergen Gross <jgross@suse.com>,
    Stefano  Stabellini <sstabellini@kernel.org>,
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH v5 10/11] arm/libxl: Emulated PCI device tree node in
 libxl
In-Reply-To: <294BE20A-7E45-405C-BC19-C292295E85E3@arm.com>
References: <cover.1633540842.git.rahul.singh@arm.com>
	<b81b5dea800c8fe47071f3dbd20588b1e472fb99.1633540842.git.rahul.singh@arm.com>
	<7bdac405-a889-15e1-be19-5876f7253855@xen.org>
	<24926.53690.621007.507249@mariner.uk.xensource.com>
	<294BE20A-7E45-405C-BC19-C292295E85E3@arm.com>
X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu)

Rahul Singh writes ("Re: [PATCH v5 10/11] arm/libxl: Emulated PCI device tree node in libxl"):
> As Stefano suggested in another email that we can remove the vpci
> option, if we reach to conclusion that we need vpci option I will
> move it to internal structure.
...
> Yes I agree with you VPCI is necessary for hot plugged PCI device
> and once we implement the hotplug in future we will use the
> passthrough= option to enable VPCI.

So, to summarise, I think the situation is:

 * VCPI is necessry for passthrough on ARM, whether coldplug or
   hotplug.  It's part of the way that PCI-PT works on ARM.

 * Hotplug is not yet implemented.

 * VPCI is not necessary on x86 (evidently, since we don't have it
   there but we do have passthrough).

So when hotplug is added, vpci will need to be turned on when
passthrough=yes is selected.  I don't fully understand the other
possible values for passthrough= but maybe we can defer the question
of whether they apply to ARM ?

I think that means that yes, this should be an internal variable.
Probably in libxl__domain_create_state.  We don't currently arrange to
elide arch-specific state in there, so perhaps it's fine just to
invent a member called `arm_vpci`.

Maybe you could leave a comment somewhere so that if and when PCI PT
hotplug is implemented for ARM, the implementor remembers to wire this
up.

Ian.


From xen-devel-bounces@lists.xenproject.org Thu Oct 07 16:14:44 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Oct 2021 16:14:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.203845.358994 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYW2d-0002Eg-G7; Thu, 07 Oct 2021 16:14:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 203845.358994; Thu, 07 Oct 2021 16:14:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYW2d-0002EZ-D6; Thu, 07 Oct 2021 16:14:43 +0000
Received: by outflank-mailman (input) for mailman id 203845;
 Thu, 07 Oct 2021 16:14:41 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=qfpx=O3=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mYW2b-0002ET-Ex
 for xen-devel@lists.xenproject.org; Thu, 07 Oct 2021 16:14:41 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 03c103e1-1a9c-4b3d-b324-a526a5124157;
 Thu, 07 Oct 2021 16:14:40 +0000 (UTC)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2174.outbound.protection.outlook.com [104.47.17.174])
 (Using TLS) by relay.mimecast.com with ESMTP id
 de-mta-14-sK2VNVWmMSGNTM64N_yjIg-1; Thu, 07 Oct 2021 18:14:38 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB2959.eurprd04.prod.outlook.com (2603:10a6:802:8::25) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.22; Thu, 7 Oct
 2021 16:14:36 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4587.020; Thu, 7 Oct 2021
 16:14:36 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6PR0202CA0042.eurprd02.prod.outlook.com (2603:10a6:20b:3a::19) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.14 via Frontend
 Transport; Thu, 7 Oct 2021 16:14:35 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 03c103e1-1a9c-4b3d-b324-a526a5124157
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1633623279;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=OZobpDgjbqKs/ag7N0PLA129nreT/lrWiUeQXCQvB9M=;
	b=AZQ2cLu1HWk0IFxz7A6NN94/zGAGNn7jP2I+Ln4eH8QK/OqNZJSthTb2DWGcnsI9lOsibH
	4+/AHPbHYWk0cgjOW9qW1BaetExZivlAQwqxS1n1Ro5n0t9fi1KuU/qa4767bC1SCu+udc
	ze4s8LHCN9RBU5gNDVMAtYtx8MvNnkw=
X-MC-Unique: sK2VNVWmMSGNTM64N_yjIg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=St+QzvNYa4ZpT19QhYrmmv+DzC+0krA7yZ6f50quLAmKtEeBU+MizanGJYjcdpxI6SkFiCQrntsHScFkzriXCjw3XKHY0zPYgj97GYQghuPY2EczrrYUMFrax5n0c0qZTHd/X4EkRdgOtRP9BrXFV6u8PNJtqxtqbbg9DKav+imTdLLbZIdOBGUZS5hBZttvg7wxoAXoYUtYD9CluqMiITaJnS89p1yviJkyWgzGrFegysOPgl6rlDGNNe/O9MoukPHMkSkFsckPv52zFhzfEwzxl1/0qPqphVX44aJ01GIRbjFGpNcQPEAX+Rspwo2TXOUceU/D47EC9HNw764J3w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=OZobpDgjbqKs/ag7N0PLA129nreT/lrWiUeQXCQvB9M=;
 b=ACSfQWuklKwznI1F91vKRttue6fqa3xEkNmOpm57hb1RWnvxvehl+boOthyrrOGbnz6wvHuJO5fXAbdz47ssLHTfrDFoBWYGba/G07xshKcbEHDsZzhQDLIIaWteh8wjcCjpUeF8A6syFUVPtkDdm3/GokfSFqPVvtp99xQUHI4Uzn7ctxdoCgMZfU8+vM0qLi0Dh6dQoLrV+MY32DJkECL4ck9l6XZmvLz9xKb3zBDu+YPc88WWYSZ2vga6a3tu9huIxjK6CSx2I4RHfah42+W+UfuJ8zoCN4IdHeA239o5jNhABxtm8oGzMMlC4FPUdzDa7AI/D5CFozw1A2mLpw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [XEN PATCH v7 17/51] build: set XEN_BUILD_EFI earlier
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>, Wei Liu
 <wl@xen.org>, xen-devel@lists.xenproject.org
References: <20210824105038.1257926-1-anthony.perard@citrix.com>
 <20210824105038.1257926-18-anthony.perard@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <6d2f9787-d156-0b06-0548-97198af644f9@suse.com>
Date: Thu, 7 Oct 2021 18:14:33 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <20210824105038.1257926-18-anthony.perard@citrix.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR0202CA0042.eurprd02.prod.outlook.com
 (2603:10a6:20b:3a::19) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: d77addfc-6f1b-4431-f945-08d989ad8e7f
X-MS-TrafficTypeDiagnostic: VI1PR04MB2959:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB295944FCF85F61245D41099AB3B19@VI1PR04MB2959.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	tuCNFXy7WGrpXKrxNx+9ooc1qmlXeP8SxAgQhSY/vBEVNM+o48daYX6EUnCu/w7nGzv24b9uBzWyXtfOmiW0NzDPMevBoZ9HvK1aooIGdg4BFk39abXvHnvJqeo93JrA16ZGjJku7XP8dfKDGbgLaa4G3KoPM2KuWRGH6Hwyy1xku3aL6SLsAPmqIoSEU0SRkRimqhWJ30xbZjM/FaxXjU5Zbde8yvKN8TH7vL9NJycG9z1heM0uXIgcITCjLXnAeUZ5l171kWCkYgvxEcHf7G3rvBNLLcsLZJRemwo6BtPgpiNASCRS0W4ivL6nwssyH1Z65IVLfoD8K6vWGhzw1LaYCS7fur/9Rvs+exPTN4TjgcB+ri/j6LjKh5BPUmJbEcFLMc6ygT49F1orJQfGc3rqW18xXTc2IUIyH8x/FoycBiDDm9t6ufIMzBN6QQhDdKQwUxZl+sy8D81HHmEmRvV8v/GdV5VMLCreFlv9aukXPhpkK8m5DQLKRfREcOlgbwO/DY4uLC7PfqikzwXrh7AhNrEiFVKn+KN6Lm8qOFHJseEJ60Ye2rxHnKpmKI68hMvboWKQgbQfu68Zw1IKPro2P2AuEXUH8wln5VphBCP9cwuDs1pCoNWfzEGH21/ZC0Z32AFUfPhQdFItkzbKHDBjw8N8G5suWbv8uAngWimVnrgPJR2N+XJDxci4RaRWHqpK8kDEpAr1OgYH18iRygl8hnh1cCNg37Ta97ASp9I=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(8676002)(6486002)(316002)(16576012)(956004)(38100700002)(4326008)(8936002)(66946007)(5660300002)(2616005)(36756003)(6916009)(31696002)(83380400001)(26005)(66476007)(2906002)(508600001)(54906003)(66556008)(53546011)(86362001)(31686004)(186003)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?MGFBb2lOVXlIaU9Ic3ljaEJDcU0yRW5GUFNUUEtRb053ZTJETFJVdTNZVWZ0?=
 =?utf-8?B?ZmFQUStpQ2RCeG1NdzFaK3Jqb1p5eFhUZFQvYjNHbnpuQkJuUlM4cDlLU21O?=
 =?utf-8?B?THIwTmdyb2Z0b3lyQlpYTFl2Yk9Tc3JCaFp3NkdZaC9GWHhkMlJHeGdPeEw1?=
 =?utf-8?B?TlpsVnNrRm5sZWlLWU9LcGkrSXNWNmwxcHJFcGZZUVFBQUJ2RlhjWU1xOENr?=
 =?utf-8?B?aFVzdXJOYWVrYWxudjVEeDNEZDhSaisvenlkeUY4U3MrSzBBVUpCRlBSTk4w?=
 =?utf-8?B?T29KbHQvdHNFNG9aVVBTSUJDdEdocHVYcG5mYjFrUXQ1MG9wV0NOcWRlYW51?=
 =?utf-8?B?bzVYbHBIR2VBV2Y4TTZ2VzJQMWcrL3BkYVIxaFE2RStWMUx0UVl6M0VUSUxk?=
 =?utf-8?B?THRqRys2cUNiL21BSUZMeStNeW5jRkFQZXp6Qk8yMld3cEs3MFUzajBGTjd4?=
 =?utf-8?B?UlNCdnZ6UitERXJNZU5IOVFBMHY0S0pjTVlOOTBXL3R2UXliT2N6RUpoZmxp?=
 =?utf-8?B?RFZwejQvMXNWM1Bab1lzOFBuMEZDbE11NEw5QTViUGxvOHIrVTdsYWZ4V3JM?=
 =?utf-8?B?UDlpbHBraWdFVU1xYzRXTUFOT0FGazd0a0hIUllySmdZVDh2VDRES1cxaGV5?=
 =?utf-8?B?QTdlcWdqVEJVZ3hyQU9NY3pJOFg0eFVUK3IybzdPaTRGTGthcU8yREF5NTE4?=
 =?utf-8?B?OVVhSUZ6dlpuMTE1VjFielZRcFNTVnBKN29DVUwxUGh3ZDBaTHk2MVlYSG1W?=
 =?utf-8?B?bENYcUdYenk2QkZSa1hSOGpuLzhOalhobUVvdVlqc1lNb3pmczdiUEFRK3N3?=
 =?utf-8?B?eEU5eFVJdS9EaXZSVjRhN21td1IxM1p2YjI2Y013UWQxREpxTUxLc1FacUpx?=
 =?utf-8?B?VHlZN2tuY0R5YWZUeW1jVWczN1RYNWFvTjZzMEN4cEk4V0JudTdZSEw2T2Zk?=
 =?utf-8?B?b0RFTngrMGswTTJqU1ovb3ZVUUhQNFNqejN2YzgzTGl3NTBZcVowOEdnVWc0?=
 =?utf-8?B?QXI1RTZsZWxCeHdDeEhaTVg4T0g1Z3ZqRlF0cC9rcW5ObkNxK3VENWtVQ0dv?=
 =?utf-8?B?SHc1MkNjV3k4STdlaEdwdmNkQXN0eW1uenExb2pMRkUxR2NXaFlNRU5IRVhl?=
 =?utf-8?B?MmJtazd1ZjdXOHJibzZRNnRXRUxzZGJmcm1VWmo4Y1pJTG9PNTN1Z3hEZVBt?=
 =?utf-8?B?bWtXK3luOGl1TFlCQ2xML1ZHNVp3R0FzYnJ3amZTeFBNUVZ1ZzVjNWtjNlBO?=
 =?utf-8?B?VGpTNzdDSm5hcTh0enB5Z1diUVRLanhueGk5K211b0ROR2JIajhCdmFCMElO?=
 =?utf-8?B?MDFERGZMM2lPc1dvRjR0Qlg1eHNmNSsxT0Rtd2sxdVVaaW1sVlpNSDFwWUNU?=
 =?utf-8?B?amlFSHFlMko5cEVjanN1VzRGZ1FCRHNNL3k0R1lSR0l3RjcrMHBsVmQ2eXRx?=
 =?utf-8?B?VG9VWkFKSEZWR1dJMWNzanF6Uk9CTUVPUFp0c3lBZGllelFIQkZpS0F1ZGZS?=
 =?utf-8?B?UGFkK3lPbVNKbWNYTHBxODA0Ui8xc0ZzT3Z5eUxkL1RRTU56OWlMZnczbnVh?=
 =?utf-8?B?dUMyMTZMbzhDVGYvSzd3dWxXcHRSYjNydHFGdjdid241Q0R3V2pKT1Q4azNW?=
 =?utf-8?B?eVRXYUlSM3Y0d1dZZFdUNFkxaEtZSlVHOSt4UWNKbVk4SWdjcDc5TkVHOExW?=
 =?utf-8?B?eisxRHdraStmMTNuTGZuaDJGZDAxSEZvc3ZGVEw3c2Z4bE1WRlFGSWJRNzhM?=
 =?utf-8?Q?Ds917jkRW3HF7zlIRI9BBvLoDgrb1hMy5fUlSIc?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d77addfc-6f1b-4431-f945-08d989ad8e7f
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Oct 2021 16:14:36.3944
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: W/qkojn3omXVUCTA+mKZFjr8I28vrGk+zlew3IwipygHUbU4fiH1prrEHIKVTg2MKnIIdENP9lwqhKC/nVtB5Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB2959

A general remark first: If I understand things correctly, a side effect
of this change is to also address the issue that I'm trying to take
care of in "x86/build: suppress EFI-related tool chain checks upon local
$(MAKE) recursion". However, while that one's a reasonable backporting
candidate, I don't think the one here is. Therefore I'd prefer my patch
to go in ahead of this change of yours. Hence I wonder whether in return
I couldn't ask you to review that one.

On 24.08.2021 12:50, Anthony PERARD wrote:
> We are going to need the variable XEN_BUILD_EFI earlier.
> 
> But a side effect of calculating the value of $(XEN_BUILD_EFI) is to
> also to generate "efi/check.o" which is used for further checks.
> Thus the whole chain that check for EFI support is moved to
> "arch.mk".
> 
> Some other changes are made to avoid too much duplication:
>     - $(efi-check-o): Used to avoid repeating "efi/check.*". We don't
>       set it to the path to the source as it would be wrong as soon
>       as we support out-of-tree build.
>     - $(LD_PE_check_cmd): As it is called twice, with an updated
>       $(EFI_LDFLAGS).
> 
> $(nr-fixups) is renamed to $(efi-check-relocs) as the former might be
> a bit too generic.

While I don't mind the prefix addition, may I please ask that the rest
of the name remain as is, i.e. $(efi-nr-fixups)? "nr" because that's
what the variable holds, and "fixups" to distinguish from full-fledged
relocations as well as to match commentary there.

> --- a/xen/arch/x86/Makefile
> +++ b/xen/arch/x86/Makefile
> @@ -123,41 +123,7 @@ $(TARGET): $(TARGET)-syms $(efi-y) boot/mkelf32
>  	mv $(TMP) $(TARGET)
>  
>  ifneq ($(efi-y),)
> -
> -# Check if the compiler supports the MS ABI.
> -export XEN_BUILD_EFI := $(shell $(CC) $(XEN_CFLAGS) -c efi/check.c -o efi/check.o 2>/dev/null && echo y)
>  CFLAGS-$(XEN_BUILD_EFI) += -DXEN_BUILD_EFI
> -
> -# Check if the linker supports PE.
> -EFI_LDFLAGS = $(patsubst -m%,-mi386pep,$(XEN_LDFLAGS)) --subsystem=10
> -XEN_BUILD_PE := $(if $(XEN_BUILD_EFI),$(call ld-option,$(EFI_LDFLAGS) --image-base=0x100000000 -o efi/check.efi efi/check.o))
> -# If the above failed, it may be merely because of the linker not dealing well
> -# with debug info. Try again with stripping it.
> -ifeq ($(CONFIG_DEBUG_INFO)-$(XEN_BUILD_PE),y-n)
> -EFI_LDFLAGS += --strip-debug
> -XEN_BUILD_PE := $(call ld-option,$(EFI_LDFLAGS) --image-base=0x100000000 -o efi/check.efi efi/check.o)
> -endif
> -
> -ifeq ($(XEN_BUILD_PE),y)
> -
> -# Check if the linker produces fixups in PE by default
> -nr-fixups := $(shell $(OBJDUMP) -p efi/check.efi | grep '^[[:blank:]]*reloc[[:blank:]]*[0-9][[:blank:]].*DIR64$$' | wc -l)
> -ifeq ($(nr-fixups),2)
> -MKRELOC := :
> -relocs-dummy :=
> -else
> -MKRELOC := efi/mkreloc
> -relocs-dummy := efi/relocs-dummy.o
> -# If the linker produced fixups but not precisely two of them, we need to
> -# disable it doing so.  But if it didn't produce any fixups, it also wouldn't
> -# recognize the option.
> -ifneq ($(nr-fixups),0)
> -EFI_LDFLAGS += --disable-reloc-section
> -endif
> -endif
> -
> -endif # $(XEN_BUILD_PE)
> -
>  endif # $(efi-y)

Is the remaining if(,) block still warranted? I.e. can't the single line

CFLAGS-$(XEN_BUILD_EFI) += -DXEN_BUILD_EFI

live without the surrounding conditional?

> --- a/xen/arch/x86/arch.mk
> +++ b/xen/arch/x86/arch.mk
> @@ -60,5 +60,47 @@ ifeq ($(CONFIG_UBSAN),y)
>  $(call cc-option-add,CFLAGS_UBSAN,CC,-fno-sanitize=alignment)
>  endif
>  
> +ifneq ($(CONFIG_PV_SHIM_EXCLUSIVE),y)
> +
> +efi-check-o = arch/x86/efi/check.o

Nit: Unless there's a reason not to, please prefer := here (and in
general).

Jan



From xen-devel-bounces@lists.xenproject.org Thu Oct 07 16:55:38 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Oct 2021 16:55:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.203858.359004 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYWfz-0006Zo-MR; Thu, 07 Oct 2021 16:55:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 203858.359004; Thu, 07 Oct 2021 16:55:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYWfz-0006Zh-J9; Thu, 07 Oct 2021 16:55:23 +0000
Received: by outflank-mailman (input) for mailman id 203858;
 Thu, 07 Oct 2021 16:55:22 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mYWfy-0006ZX-MB; Thu, 07 Oct 2021 16:55:22 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mYWfy-0008Re-F2; Thu, 07 Oct 2021 16:55:22 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mYWfy-00036W-58; Thu, 07 Oct 2021 16:55:22 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mYWfy-0002TB-4Q; Thu, 07 Oct 2021 16:55:22 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=9S3I9/ewR9eIAb32qMtdknwCSCnMTPK5quQX2JMQ89g=; b=T4ULcYGykaRUSnni7rIsH2+TED
	RVaYm1QwWxhIfNsL2+ONqqA8qlV/pWrjfjq+PEYOsgOHT4AIt1KQ59Bm42vt2dr9gX5w9Waw2+oZW
	gc2wI8gf3XfR8pYsV4Gmx+RD/1wnPJA8zGV/YDf+0O22xBJNPrPIz0jZNDuZohpXF+8Y=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165398-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 165398: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=b4da6c29f1d36031e04212f53277ce0dcba309f1
X-Osstest-Versions-That:
    ovmf=942c9bd357d87cc6eed7c8250c213eff218d674e
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 07 Oct 2021 16:55:22 +0000

flight 165398 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165398/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 b4da6c29f1d36031e04212f53277ce0dcba309f1
baseline version:
 ovmf                 942c9bd357d87cc6eed7c8250c213eff218d674e

Last test of basis   165382  2021-10-05 18:11:18 Z    1 days
Testing same since   165398  2021-10-06 11:41:16 Z    1 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Chris Jones <christopher.jones@arm.com>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   942c9bd357..b4da6c29f1  b4da6c29f1d36031e04212f53277ce0dcba309f1 -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Thu Oct 07 16:57:11 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Oct 2021 16:57:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.203867.359018 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYWhj-0007FA-2R; Thu, 07 Oct 2021 16:57:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 203867.359018; Thu, 07 Oct 2021 16:57:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYWhi-0007F3-VV; Thu, 07 Oct 2021 16:57:10 +0000
Received: by outflank-mailman (input) for mailman id 203867;
 Thu, 07 Oct 2021 16:57:09 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=4W4d=O3=gmail.com=olekstysh@srs-us1.protection.inumbo.net>)
 id 1mYWhh-0007Ex-9E
 for xen-devel@lists.xenproject.org; Thu, 07 Oct 2021 16:57:09 +0000
Received: from mail-ed1-x52c.google.com (unknown [2a00:1450:4864:20::52c])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id f83e7105-8820-41c2-913d-2f539e27b611;
 Thu, 07 Oct 2021 16:57:07 +0000 (UTC)
Received: by mail-ed1-x52c.google.com with SMTP id z20so25231925edc.13
 for <xen-devel@lists.xenproject.org>; Thu, 07 Oct 2021 09:57:07 -0700 (PDT)
Received: from [192.168.1.7] ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id y8sm54664ejm.104.2021.10.07.09.57.06
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Thu, 07 Oct 2021 09:57:06 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f83e7105-8820-41c2-913d-2f539e27b611
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-transfer-encoding:content-language;
        bh=B3UgCCALqs9hgNIwGMJtFQOuaq80rmp71wOVGW9frv0=;
        b=YdS8vBSPgBrBJi1CwggRPfVc8yLPYGk/tvtyqEKt1tO2mCqJ7gR4TQyEDjnDW3GcfO
         9y5CcW61wWiK1oBnU4NvyHMFJseEM1LEnX3HdKn5FLRi1D/7VmTKBT/lPzwHN5jWnswH
         yfit2pHB+R19JBFipD2B0ZGU0ijuC0ya21KPyJINdwJ+RICsgtVOmNzesY4JZngQBDCo
         ASG99LwLbAW0Jv6j8QtO6pEYnXGYl/QMZVk/N44sA5Z+qdNCQkw1JEqMdA1sA9/ZDLdC
         aCY3qS6whOVziKX7btAmqhTh8JO7m4ijZpNq+poxe5KL0Rodm0hsGX8vhvtcvR2twArB
         e4Kg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding
         :content-language;
        bh=B3UgCCALqs9hgNIwGMJtFQOuaq80rmp71wOVGW9frv0=;
        b=wupvo8RSEJTPacis7tAZSeN9MtzGPZmfq1KUTXCX5IIYeo2VctuGTQaFYap8GueSvm
         a7yJAlTK7zxFYUm/q/mGuxHhXX9snNP1xGA7FAbA6fhnEoyI7O0IJnuYm0FkRwb3h3io
         pOgvzGyz1xHTY5rxFj8PwV/fgMkAyiSCKp1RmtH+evEeiQl7nFPMyCZwRlv9CFiTvYIJ
         BkWm2bfMHFQu+pr+XX6Pf2qJrRtYOqn7ZJBg8XUjF1yTLhUioaNYiV7Ut9KJ1YXxK2j1
         GZPU33BpV06dLGlvJbV5T5DkisEKL0SrUj2K6k2gNst7oSskm6NrOkXiJvJiR/DffhBd
         doxg==
X-Gm-Message-State: AOAM531CkCXSF+b6RvOt8Qb3vPuqejPuDyvjuoD8OF3Yk7vDZnwHoaDe
	WKxSoeDkMjXlMADOxXfG8Vc=
X-Google-Smtp-Source: ABdhPJxR7Jf9toX9SzBw+AIoZ06cHm0e7ENN8DRDbcPiDNS49vbK6XlwYeveDX9GSU3e5TKQl76iMg==
X-Received: by 2002:a17:906:af49:: with SMTP id ly9mr6924947ejb.479.1633625826920;
        Thu, 07 Oct 2021 09:57:06 -0700 (PDT)
Subject: Re: [PATCH V5 2/3] libxl/arm: Add handling of extended regions for
 DomU
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: xen-devel@lists.xenproject.org,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>,
 Anthony PERARD <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>,
 Julien Grall <julien@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <1633519346-3686-1-git-send-email-olekstysh@gmail.com>
 <1633519346-3686-3-git-send-email-olekstysh@gmail.com>
 <alpine.DEB.2.21.2110061808570.3209@sstabellini-ThinkPad-T480s>
From: Oleksandr <olekstysh@gmail.com>
Message-ID: <9a4fb8be-e893-bd7f-fe77-7274457e2b04@gmail.com>
Date: Thu, 7 Oct 2021 19:57:05 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.21.2110061808570.3209@sstabellini-ThinkPad-T480s>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US


On 07.10.21 04:29, Stefano Stabellini wrote:

Hi Stefano

> On Wed, 6 Oct 2021, Oleksandr Tyshchenko wrote:
>> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>>
>> The extended region (safe range) is a region of guest physical
>> address space which is unused and could be safely used to create
>> grant/foreign mappings instead of wasting real RAM pages from
>> the domain memory for establishing these mappings.
>>
>> The extended regions are chosen at the domain creation time and
>> advertised to it via "reg" property under hypervisor node in
>> the guest device-tree. As region 0 is reserved for grant table
>> space (always present), the indexes for extended regions are 1...N.
>> If extended regions could not be allocated for some reason,
>> Xen doesn't fail and behaves as usual, so only inserts region 0.
>>
>> Please note the following limitations:
>> - The extended region feature is only supported for 64-bit domain
>>    currently.
>> - The ACPI case is not covered.
>>
>> ***
>>
>> The algorithm to choose extended regions for non-direct mapped
>> DomU is simpler in comparison with the algorithm for direct mapped
>> Dom0. We usually have a lot of unused space above 4GB, and might
>> have some unused space below 4GB (depends on guest memory size).
>> Try to allocate separate 2MB-aligned extended regions from the first
>> (below 4GB) and second (above 4GB) RAM banks taking into the account
>> the maximum supported guest physical address space size and the amount
>> of memory assigned to the guest. The minimum size of extended region
>> the same as for Dom0 (64MB).
>>
>> Suggested-by: Julien Grall <jgrall@amazon.com>
>> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>> ---
>> ! Stefano, Ian, Michal I dropped your A-b/R-b. I decided to change patch
>> to make it more functional !
>>
>> Changes RFC -> V2:
>>     - update patch description
>>     - drop uneeded "extended-region" DT property
>>     - clear reg array in finalise_ext_region() and add a TODO
>>
>> Changes V2 -> V3:
>>     - update patch description, comments in code
>>     - only pick up regions with size >= 64MB
>>     - move the region calculation to make_hypervisor_node() and drop
>>       finalise_ext_region()
>>     - extend the list of arguments for make_hypervisor_node()
>>     - do not show warning for 32-bit domain
>>     - change the region alignment from 1GB to 2MB
>>     - move EXT_REGION_SIZE to public/arch-arm.h
>>
>> Changes V3 -> V4:
>>     - add R-b, A-b and T-b
>>
>> Changes V4 -> V5:
>>     - update patch description and comments in code
>>     - reflect changes done in previous patch to pass gpaddr_bits
>>       via createdomain domctl (struct xen_arch_domainconfig)
>>     - drop R-b, A-b and T-b
>>     - drop limit for maximum extended region size (128GB)
>>     - try to also allocate region below 4GB, optimize code
>>       for calculating extended regions
>> ---
>>   tools/libs/light/libxl_arm.c  | 80 ++++++++++++++++++++++++++++++++++++++++---
>>   xen/include/public/arch-arm.h |  2 ++
>>   2 files changed, 77 insertions(+), 5 deletions(-)
>>
>> diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c
>> index 45e0386..cd743f7 100644
>> --- a/tools/libs/light/libxl_arm.c
>> +++ b/tools/libs/light/libxl_arm.c
>> @@ -600,9 +600,21 @@ static int make_timer_node(libxl__gc *gc, void *fdt,
>>       return 0;
>>   }
>>   
>> +#define ALIGN_UP_TO_2MB(x)   (((x) + MB(2) - 1) & (~(MB(2) - 1)))
>> +
>>   static int make_hypervisor_node(libxl__gc *gc, void *fdt,
>> -                                const libxl_version_info *vers)
>> +                                const libxl_version_info *vers,
>> +                                const libxl_domain_build_info *b_info,
>> +                                const struct xc_dom_image *dom)
>>   {
>> +    uint64_t region_size[GUEST_RAM_BANKS] = {0}, region_base[GUEST_RAM_BANKS],
>> +        banksize[GUEST_RAM_BANKS], bankend[GUEST_RAM_BANKS], ramsize;
>> +    uint32_t regs[(GUEST_ROOT_ADDRESS_CELLS + GUEST_ROOT_SIZE_CELLS) *
>> +                  (GUEST_RAM_BANKS + 1)];
>> +    be32 *cells = &regs[0];
>> +    const uint64_t bankbase[] = GUEST_RAM_BANK_BASES;
>> +    unsigned int i, len, nr_regions = 0;
>> +    uint8_t gpaddr_bits;
>>       int res;
>>       gic_interrupt intr;
>>   
>> @@ -617,9 +629,67 @@ static int make_hypervisor_node(libxl__gc *gc, void *fdt,
>>                                 "xen,xen");
>>       if (res) return res;
>>   
>> -    /* reg 0 is grant table space */
>> -    res = fdt_property_regs(gc, fdt, GUEST_ROOT_ADDRESS_CELLS, GUEST_ROOT_SIZE_CELLS,
>> -                            1,GUEST_GNTTAB_BASE, GUEST_GNTTAB_SIZE);
>> +    if (strcmp(dom->guest_type, "xen-3.0-aarch64")) {
>> +        LOG(WARN, "The extended regions are only supported for 64-bit guest currently");
>> +        goto out;
>> +    }
>> +
>> +    gpaddr_bits = b_info->arch_arm.gpaddr_bits;
>> +    assert(gpaddr_bits >= 32 && gpaddr_bits <= 48);
>> +
>> +    /*
>> +     * Try to allocate separate 2MB-aligned extended regions from the first
>> +     * (below 4GB) and second (above 4GB) RAM banks taking into the account
>> +     * the maximum supported guest physical address space size and the amount
>> +     * of memory assigned to the guest.
>> +     * As the guest memory layout is not populated yet we cannot rely on
>> +     * dom->rambank_size[], so calculate the actual size of both banks using
>> +     * "max_memkb" value.
>> +     */
>> +    ramsize = b_info->max_memkb * 1024;
>> +    if (ramsize <= GUEST_RAM0_SIZE) {
>> +        banksize[0] = ramsize;
>> +        banksize[1] = 0;
>> +    } else {
>> +        banksize[0] = GUEST_RAM0_SIZE;
>> +        banksize[1] = ramsize - GUEST_RAM0_SIZE;
>> +    }
>> +
>> +    bankend[0] = GUEST_RAM0_BASE + GUEST_RAM0_SIZE;
>> +    bankend[1] = min(1ULL << gpaddr_bits, GUEST_RAM1_BASE + GUEST_RAM1_SIZE);
>> +
>> +    for (i = 0; i < GUEST_RAM_BANKS; i++) {
>> +        region_base[i] = bankbase[i] + ALIGN_UP_TO_2MB(banksize[i]);
>> +        if (bankend[i] > region_base[i])
>> +            region_size[i] = bankend[i] - region_base[i];
>> +    }
> This seems correct but it looks a bit overkill. I would have written
> like this:
>
>      if (ramsize <= GUEST_RAM0_SIZE) {
>          region_base[0] = GUEST_RAM0_BASE + ALIGN_UP_TO_2MB(ramsize);
>          region_size[0] = GUEST_RAM0_SIZE - ALIGN_UP_TO_2MB(ramsize);
>          region_base[1] = GUEST_RAM1_BASE;
>          region_size[1] = min(1ULL << gpaddr_bits, GUEST_RAM1_BASE + GUEST_RAM1_SIZE) -
>                           region_base[0];
Why  "- region_base[0]" in last expression? I think it should be "- 
region_base[1]", the same as for "else" case (so it can be moved out of 
if-else construct). Also we need to check

that min(1ULL << gpaddr_bits, GUEST_RAM1_BASE + GUEST_RAM1_SIZE) is 
greater than region_base[1] before the subtraction. If gpaddr_bits = 32 
(on Arm64) we will get incorrect result.


>      } else {
>          region_size[0] = 0;
>          region_base[1] = GUEST_RAM1_BASE + ALIGN_UP_TO_2MB(ramsize - GUEST_RAM0_SIZE);
>          region_size[1] = min(1ULL << gpaddr_bits, GUEST_RAM1_BASE + GUEST_RAM1_SIZE) -
>                           region_base[1];
>      }
>
> Which removes the needs for banksize, bankend, bankbase. What do you
> think? Your version works too, so I am OK anyway.
Thank you for looking into this.

I think, you version will also work with adjustments. I am OK either 
way. Your version reduces the number of locals, so probably better.  
Although "min(1ULL << gpaddr_bits, GUEST_RAM1_BASE + GUEST_RAM1_SIZE)" 
construction probably wants latching in local bank1end.


Below the updated version:


     if (ramsize <= GUEST_RAM0_SIZE) {
         region_base[0] = GUEST_RAM0_BASE + ALIGN_UP_TO_2MB(ramsize);
         region_size[0] = GUEST_RAM0_SIZE - ALIGN_UP_TO_2MB(ramsize);
         region_base[1] = GUEST_RAM1_BASE;
     } else
         region_base[1] = GUEST_RAM1_BASE + ALIGN_UP_TO_2MB(ramsize - 
GUEST_RAM0_SIZE);

     bank1end = min(1ULL << gpaddr_bits, GUEST_RAM1_BASE + GUEST_RAM1_SIZE);
     if (bank1end > region_base[1])
         region_size[1] = bank1end - region_base[1];




>
>
>
>> +out:
>> +    /*
>> +     * The region 0 for grant table space must be always present. If we managed
>> +     * to allocate the extended regions then insert them as regions 1...N.
>> +     */
>> +    set_range(&cells, GUEST_ROOT_ADDRESS_CELLS, GUEST_ROOT_SIZE_CELLS,
>> +              GUEST_GNTTAB_BASE, GUEST_GNTTAB_SIZE);
>> +
>> +    for (i = 0; i < GUEST_RAM_BANKS; i++) {
>> +        if (region_size[i] < GUEST_EXT_REGION_MIN_SIZE)
>> +            continue;
>> +
>> +        LOG(DEBUG, "Extended region %u: %#"PRIx64"->%#"PRIx64"\n",
>> +            nr_regions, region_base[i], region_base[i] + region_size[i]);
>> +
>> +        set_range(&cells, GUEST_ROOT_ADDRESS_CELLS, GUEST_ROOT_SIZE_CELLS,
>> +                  region_base[i], region_size[i]);
>> +        nr_regions ++;
>                       ^ code style

ok


>
>
>> +    }
>> +
>> +    if (!nr_regions)
>> +        LOG(WARN, "The extended regions cannot be allocated, not enough space");
>> +
>> +    len = sizeof(regs[0]) * (GUEST_ROOT_ADDRESS_CELLS + GUEST_ROOT_SIZE_CELLS) *
>> +        (nr_regions + 1);
>> +    res = fdt_property(fdt, "reg", regs, len);
>>       if (res) return res;
>>   
>>       /*
>> @@ -965,7 +1035,7 @@ next_resize:
>>           }
>>   
>>           FDT( make_timer_node(gc, fdt, ainfo, state->clock_frequency) );
>> -        FDT( make_hypervisor_node(gc, fdt, vers) );
>> +        FDT( make_hypervisor_node(gc, fdt, vers, info, dom) );
>>   
>>           if (info->arch_arm.vuart == LIBXL_VUART_TYPE_SBSA_UART)
>>               FDT( make_vpl011_uart_node(gc, fdt, ainfo, dom) );
>> diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h
>> index 4a01f8b..f74cc0b 100644
>> --- a/xen/include/public/arch-arm.h
>> +++ b/xen/include/public/arch-arm.h
>> @@ -454,6 +454,8 @@ typedef uint64_t xen_callback_t;
>>   #define GUEST_RAM_BANK_BASES   { GUEST_RAM0_BASE, GUEST_RAM1_BASE }
>>   #define GUEST_RAM_BANK_SIZES   { GUEST_RAM0_SIZE, GUEST_RAM1_SIZE }
>>   
>> +#define GUEST_EXT_REGION_MIN_SIZE   xen_mk_ullong(0x0004000000) /* 64MB */
>> +
>>   /* Current supported guest VCPUs */
>>   #define GUEST_MAX_VCPUS 128
>>   
>> -- 
>> 2.7.4
>>
-- 
Regards,

Oleksandr Tyshchenko



From xen-devel-bounces@lists.xenproject.org Thu Oct 07 17:11:25 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Oct 2021 17:11:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.203877.359030 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYWvQ-00019b-BK; Thu, 07 Oct 2021 17:11:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 203877.359030; Thu, 07 Oct 2021 17:11:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYWvQ-00019U-7S; Thu, 07 Oct 2021 17:11:20 +0000
Received: by outflank-mailman (input) for mailman id 203877;
 Thu, 07 Oct 2021 17:11:18 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=4W4d=O3=gmail.com=olekstysh@srs-us1.protection.inumbo.net>)
 id 1mYWvO-00019O-Gx
 for xen-devel@lists.xenproject.org; Thu, 07 Oct 2021 17:11:18 +0000
Received: from mail-ed1-x534.google.com (unknown [2a00:1450:4864:20::534])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 619ddad6-9e46-4ea6-a959-c82112f23beb;
 Thu, 07 Oct 2021 17:11:16 +0000 (UTC)
Received: by mail-ed1-x534.google.com with SMTP id a25so9984039edx.8
 for <xen-devel@lists.xenproject.org>; Thu, 07 Oct 2021 10:11:16 -0700 (PDT)
Received: from [192.168.1.7] ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id u16sm7650edy.55.2021.10.07.10.11.14
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Thu, 07 Oct 2021 10:11:15 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 619ddad6-9e46-4ea6-a959-c82112f23beb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-transfer-encoding:content-language;
        bh=gsCIBGpk6Y6BC6fZwGevI0r9FjPMa7p9BeRC5JmWKHU=;
        b=qbm25oIa48k2Z6qT75n3qfxqyTS0l6M1AWfcXXo+WutVmUHcd3hPBtbQi3P6f1Bw9+
         UF20oJ5ymWc6oI0X0l0c1oY0JCV7lN452SgMssCTlhuTxC+Jvs987umbZZK/e8jxnyv2
         u4BzORbAa6r+T9EQU+0RXz5UQfOIRoaS4nHMgj5zx+ttjVoNSWWaAy4kdrUHjU/Jxbdl
         u/WEag3t7WoxBxN7WQyc86q1gLJ6AO3m5nonpVcAZaHDuuEGJ/3y7M7GYpx+x7NE6wP9
         wmNW2WSDOSvr+sL0KCAdWQU4qN874z4B8WFEznnVobDWHn7cS/5nGIIqovA/bKmYIIlr
         gWpg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding
         :content-language;
        bh=gsCIBGpk6Y6BC6fZwGevI0r9FjPMa7p9BeRC5JmWKHU=;
        b=bx8/uk83+mJ1Y7DqVnpuqOsfHdIjEjDH3XKTWGYoNX5zLFQrLQjT/mspIPZfPyw0Zt
         zzvQqkzREdSpgQI9N2iQ/35SMql5zzRfgr06B4rSCUY9yF+BdKSLpdSW9RjZ8D9bJKxL
         bAE+sBze2Rb+zCQDD4yyJX4LAbwMLnJ9VQOQJGMrnaNpEmvMRTtqHMvidz97pzpp4Npq
         iNQCm7df2+NSLTixbiUcoVWg3ggOBN854BiPgvCmpFrEULPuDS4DD82+PUNm2peNnfiC
         54L0y1zaQ7zA5jCGmisXBfp095dETcQX32zqh5EnYxwzztQ7L8lMCxe/IwhEQ0t0LN3b
         8LOQ==
X-Gm-Message-State: AOAM531OQX3weZgR2ji5f7euuKV+K8hBmrIisCR4gNKLzzkmVCoYQbK2
	x1+nCIgwWWVUByoW40EhWWI=
X-Google-Smtp-Source: ABdhPJxo24C2jHjHAFg+ZqdfmV5IrOtuCE27s2TYHOLSUj+1CvYwZArAY+co6aOghhq1sGalOb/bCw==
X-Received: by 2002:a17:906:1848:: with SMTP id w8mr7076520eje.485.1633626675557;
        Thu, 07 Oct 2021 10:11:15 -0700 (PDT)
Subject: Re: [PATCH V5 3/3] xen/arm: Updates for extended regions support
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: xen-devel@lists.xenproject.org,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Julien Grall <julien@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <1633519346-3686-1-git-send-email-olekstysh@gmail.com>
 <1633519346-3686-4-git-send-email-olekstysh@gmail.com>
 <alpine.DEB.2.21.2110061843360.3209@sstabellini-ThinkPad-T480s>
From: Oleksandr <olekstysh@gmail.com>
Message-ID: <a5a81348-4b18-6be6-ba85-4c31172459dc@gmail.com>
Date: Thu, 7 Oct 2021 20:11:14 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.21.2110061843360.3209@sstabellini-ThinkPad-T480s>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US


On 07.10.21 04:50, Stefano Stabellini wrote:

Hi Stefano

> On Wed, 6 Oct 2021, Oleksandr Tyshchenko wrote:
>> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>>
>> This is a follow-up of
>> "b6fe410 xen/arm: Add handling of extended regions for Dom0"
>>
>> Add various in-code comments, update Xen hypervisor device tree
>> bindings text, change the log level for some prints and clarify
>> format specifier, reuse dt_for_each_range() to avoid open-coding
>> in find_memory_holes().
>>
>> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> Thanks for the patch, it looks like you addressed all Julien's comments
> well.

I believe so)


>   A couple of minor issues below.
>
>
>> ---
>>     New patch
>> ---
>>   docs/misc/arm/device-tree/guest.txt |  12 ++--
>>   xen/arch/arm/domain_build.c         | 108 ++++++++++++++++++++++--------------
>>   2 files changed, 73 insertions(+), 47 deletions(-)
>>
>> diff --git a/docs/misc/arm/device-tree/guest.txt b/docs/misc/arm/device-tree/guest.txt
>> index 418f1e9..c115751 100644
>> --- a/docs/misc/arm/device-tree/guest.txt
>> +++ b/docs/misc/arm/device-tree/guest.txt
>> @@ -7,10 +7,14 @@ the following properties:
>>   	compatible = "xen,xen-<version>", "xen,xen";
>>     where <version> is the version of the Xen ABI of the platform.
>>   
>> -- reg: specifies the base physical address and size of a region in
>> -  memory where the grant table should be mapped to, using an
>> -  HYPERVISOR_memory_op hypercall. The memory region is large enough to map
>> -  the whole grant table (it is larger or equal to gnttab_max_grant_frames()).
>> +- reg: specifies the base physical address and size of the regions in memory
>> +  where the special resources should be mapped to, using an HYPERVISOR_memory_op
>> +  hypercall.
>> +  Region 0 is reserved for mapping grant table, it must be always present.
>> +  The memory region is large enough to map the whole grant table (it is larger
>> +  or equal to gnttab_max_grant_frames()).
>> +  Regions 1...N are extended regions (unused address space) for mapping foreign
>> +  GFNs and grants, they might be absent if there is nothing to expose.
>>     This property is unnecessary when booting Dom0 using ACPI.
>>   
>>   - interrupts: the interrupt used by Xen to inject event notifications.
>> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
>> index c5afbe2..d9f40d4 100644
>> --- a/xen/arch/arm/domain_build.c
>> +++ b/xen/arch/arm/domain_build.c
>> @@ -898,7 +898,10 @@ static int __init add_ext_regions(unsigned long s, unsigned long e, void *data)
>>       if ( ext_regions->nr_banks >= ARRAY_SIZE(ext_regions->bank) )
>>           return 0;
>>   
>> -    /* Both start and size of the extended region should be 2MB aligned */
>> +    /*
>> +     * Both start and size of the extended region should be 2MB aligned to
>> +     * potentially allow superpage mapping.
>> +     */
>>       start = (s + SZ_2M - 1) & ~(SZ_2M - 1);
>>       if ( start > e )
>>           return 0;
>> @@ -909,6 +912,12 @@ static int __init add_ext_regions(unsigned long s, unsigned long e, void *data)
>>        */
>>       e += 1;
>>       size = (e - start) & ~(SZ_2M - 1);
>> +
>> +    /*
>> +     * Reasonable size. Not too little to pick up small ranges which are
>> +     * not quite useful itself but increase bookkeeping and not too much
>                             ^ remove itself                             ^ large

ok


>
>> +     * to skip a large proportion of unused address space.
>> +     */
>>       if ( size < MB(64) )
>>           return 0;
>>   
>> @@ -919,6 +928,14 @@ static int __init add_ext_regions(unsigned long s, unsigned long e, void *data)
>>       return 0;
>>   }
>>   
>> +/*
>> + * Find unused regions of Host address space which can be exposed to Dom0
>> + * as extended regions for the special memory mappings. In order to calculate
>> + * regions we exclude every assigned to Dom0 region from the Host RAM:
>                                ^ region assigned  ^ remove

ok


>
>
>> + * - domain RAM
>> + * - reserved-memory
>> + * - grant table space
>> + */
>>   static int __init find_unallocated_memory(const struct kernel_info *kinfo,
>>                                             struct meminfo *ext_regions)
>>   {
>> @@ -942,7 +959,7 @@ static int __init find_unallocated_memory(const struct kernel_info *kinfo,
>>           res = rangeset_add_range(unalloc_mem, start, end - 1);
>>           if ( res )
>>           {
>> -            printk(XENLOG_ERR "Failed to add: %#"PRIx64"->%#"PRIx64"\n",
>> +            printk(XENLOG_ERR "Failed to add: %#"PRIpaddr"->%#"PRIpaddr"\n",
>>                      start, end);
>>               goto out;
>>           }
>> @@ -956,7 +973,7 @@ static int __init find_unallocated_memory(const struct kernel_info *kinfo,
>>           res = rangeset_remove_range(unalloc_mem, start, end - 1);
>>           if ( res )
>>           {
>> -            printk(XENLOG_ERR "Failed to remove: %#"PRIx64"->%#"PRIx64"\n",
>> +            printk(XENLOG_ERR "Failed to remove: %#"PRIpaddr"->%#"PRIpaddr"\n",
>>                      start, end);
>>               goto out;
>>           }
>> @@ -971,7 +988,7 @@ static int __init find_unallocated_memory(const struct kernel_info *kinfo,
>>           res = rangeset_remove_range(unalloc_mem, start, end - 1);
>>           if ( res )
>>           {
>> -            printk(XENLOG_ERR "Failed to remove: %#"PRIx64"->%#"PRIx64"\n",
>> +            printk(XENLOG_ERR "Failed to remove: %#"PRIpaddr"->%#"PRIpaddr"\n",
>>                      start, end);
>>               goto out;
>>           }
>> @@ -983,7 +1000,7 @@ static int __init find_unallocated_memory(const struct kernel_info *kinfo,
>>       res = rangeset_remove_range(unalloc_mem, start, end - 1);
>>       if ( res )
>>       {
>> -        printk(XENLOG_ERR "Failed to remove: %#"PRIx64"->%#"PRIx64"\n",
>> +        printk(XENLOG_ERR "Failed to remove: %#"PRIpaddr"->%#"PRIpaddr"\n",
>>                  start, end);
>>           goto out;
>>       }
>> @@ -1003,6 +1020,35 @@ out:
>>       return res;
>>   }
>>   
>> +static int __init handle_pci_range(const struct dt_device_node *dev,
>> +                                   u64 addr, u64 len, void *data)
>> +{
>> +    struct rangeset *mem_holes = data;
>> +    paddr_t start, end;
>> +    int res;
>> +
>> +    start = addr & PAGE_MASK;
>> +    end = PAGE_ALIGN(addr + len);
>> +    res = rangeset_remove_range(mem_holes, start, end - 1);
>> +    if ( res )
>> +    {
>> +        printk(XENLOG_ERR "Failed to remove: %#"PRIpaddr"->%#"PRIpaddr"\n",
>> +               start, end);
>> +        return res;
>> +    }
>> +
>> +    return 0;
>> +}
>> +
>> +/*
>> + * Find the holes in the Host DT which can be exposed to Dom0 as extended
>> + * regions for the special memory mappings. In order to calculate regions
>> + * we exclude every addressable memory region described by "reg" and "ranges"
>> + * properties from the maximum possible addressable physical memory range:
>> + * - MMIO
>> + * - Host RAM
>> + * - PCI bar
>          ^ PCI aperture

ok


>
>
>> + */
>>   static int __init find_memory_holes(const struct kernel_info *kinfo,
>>                                       struct meminfo *ext_regions)
>>   {
>> @@ -1024,7 +1070,7 @@ static int __init find_memory_holes(const struct kernel_info *kinfo,
>>       res = rangeset_add_range(mem_holes, start, end);
>>       if ( res )
>>       {
>> -        printk(XENLOG_ERR "Failed to add: %#"PRIx64"->%#"PRIx64"\n",
>> +        printk(XENLOG_ERR "Failed to add: %#"PRIpaddr"->%#"PRIpaddr"\n",
>>                  start, end);
>>           goto out;
>>       }
>> @@ -1055,49 +1101,25 @@ static int __init find_memory_holes(const struct kernel_info *kinfo,
>>               res = rangeset_remove_range(mem_holes, start, end - 1);
>>               if ( res )
>>               {
>> -                printk(XENLOG_ERR "Failed to remove: %#"PRIx64"->%#"PRIx64"\n",
>> +                printk(XENLOG_ERR "Failed to remove: %#"PRIpaddr"->%#"PRIpaddr"\n",
>>                          start, end);
>>                   goto out;
>>               }
>>           }
>>   
>> -        if ( dt_device_type_is_equal(np, "pci" ) )
>> +        if ( dt_device_type_is_equal(np, "pci") )
>>           {
>> -            unsigned int range_size, nr_ranges;
>> -            int na, ns, pna;
>> -            const __be32 *ranges;
>> -            u32 len;
>> -
>>               /*
>> -             * Looking for non-empty ranges property which in this context
>> -             * describes the PCI host bridge aperture.
>> +             * The ranges property in this context describes the PCI host
>> +             * bridge aperture. It shall be absent if no addresses are mapped
>> +             * through the bridge.
>>                */
>> -            ranges = dt_get_property(np, "ranges", &len);
>> -            if ( !ranges || !len )
>> +            if ( !dt_get_property(np, "ranges", NULL) )
>>                   continue;
>>   
>> -            pna = dt_n_addr_cells(np);
>> -            na = dt_child_n_addr_cells(np);
>> -            ns = dt_child_n_size_cells(np);
>> -            range_size = pna + na + ns;
>> -            nr_ranges = len / sizeof(__be32) / range_size;
>> -
>> -            for ( i = 0; i < nr_ranges; i++, ranges += range_size )
>> -            {
>> -                /* Skip the child address and get the parent (CPU) address */
>> -                addr = dt_read_number(ranges + na, pna);
>> -                size = dt_read_number(ranges + na + pna, ns);
>> -
>> -                start = addr & PAGE_MASK;
>> -                end = PAGE_ALIGN(addr + size);
>> -                res = rangeset_remove_range(mem_holes, start, end - 1);
>> -                if ( res )
>> -                {
>> -                    printk(XENLOG_ERR "Failed to remove: %#"PRIx64"->%#"PRIx64"\n",
>> -                           start, end);
>> -                    goto out;
>> -                }
>> -            }
>> +            res = dt_for_each_range(np, &handle_pci_range, mem_holes);
>> +            if ( res )
>> +                goto out;
>>           }
>>       }
>>   
>> @@ -1152,12 +1174,12 @@ static int __init make_hypervisor_node(struct domain *d,
>>   
>>       if ( !opt_ext_regions )
>>       {
>> -        printk(XENLOG_DEBUG "The extended regions support is disabled\n");
>> +        printk(XENLOG_INFO "The extended regions support is disabled\n");
>>           nr_ext_regions = 0;
>>       }
>>       else if ( is_32bit_domain(d) )
>>       {
>> -        printk(XENLOG_DEBUG "The extended regions are only supported for 64-bit guest currently\n");
>> +        printk(XENLOG_WARNING "The extended regions are only supported for 64-bit guest currently\n");
>>           nr_ext_regions = 0;
>>       }
>>       else
>> @@ -1193,8 +1215,8 @@ static int __init make_hypervisor_node(struct domain *d,
>>           u64 start = ext_regions->bank[i].start;
>>           u64 size = ext_regions->bank[i].size;
>>   
>> -        dt_dprintk("Extended region %d: %#"PRIx64"->%#"PRIx64"\n",
>> -                   i, start, start + size);
>> +        printk("Extended region %d: %#"PRIx64"->%#"PRIx64"\n",
>> +               i, start, start + size);
> Also should be PRIpaddr

I thought I needed to change specifier only for variables of type 
"paddr_t", but here "u64".


-- 
Regards,

Oleksandr Tyshchenko



From xen-devel-bounces@lists.xenproject.org Thu Oct 07 17:57:25 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Oct 2021 17:57:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.203910.359070 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYXdw-0006u2-M4; Thu, 07 Oct 2021 17:57:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 203910.359070; Thu, 07 Oct 2021 17:57:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYXdw-0006tt-J2; Thu, 07 Oct 2021 17:57:20 +0000
Received: by outflank-mailman (input) for mailman id 203910;
 Thu, 07 Oct 2021 17:57:18 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=7uL+=O3=epam.com=prvs=0914b18df8=volodymyr_babchuk@srs-us1.protection.inumbo.net>)
 id 1mYXdu-0006dD-8h
 for xen-devel@lists.xenproject.org; Thu, 07 Oct 2021 17:57:18 +0000
Received: from mx0a-0039f301.pphosted.com (unknown [148.163.133.242])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id ad78c608-140f-43ba-97fc-ad72cff4fd89;
 Thu, 07 Oct 2021 17:57:14 +0000 (UTC)
Received: from pps.filterd (m0174679.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 197H3uCX022957; 
 Thu, 7 Oct 2021 17:57:11 GMT
Received: from eur05-db8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2106.outbound.protection.outlook.com [104.47.17.106])
 by mx0a-0039f301.pphosted.com with ESMTP id 3bj3am0jf4-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Thu, 07 Oct 2021 17:57:10 +0000
Received: from PAXPR03MB7594.eurprd03.prod.outlook.com (2603:10a6:102:201::14)
 by PAXPR03MB7779.eurprd03.prod.outlook.com (2603:10a6:102:20a::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18; Thu, 7 Oct
 2021 17:57:08 +0000
Received: from PAXPR03MB7594.eurprd03.prod.outlook.com
 ([fe80::24db:d530:e190:518b]) by PAXPR03MB7594.eurprd03.prod.outlook.com
 ([fe80::24db:d530:e190:518b%6]) with mapi id 15.20.4587.019; Thu, 7 Oct 2021
 17:57:08 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ad78c608-140f-43ba-97fc-ad72cff4fd89
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=KC35jQqNx3a4SgOKr89I5KUtiMvvNBWzyhGfcXipsighzB7j+yKZ2+Fv5jOAWXLjbOCAFMKvOperX/hJSae6lXmhWhwAtyqsRm5XPB8AVaiIxJfzuGSzTQ+yj7T9Y4vTgQEaP3krj+jPuduRlExwsDuSUE9yn3h/gxi3UAZaB2savJ5zsMP3AEo/Epz5ANeHHCfS0gZAvsUeAXIB4u/V6OSnJmXGmA6ecR6v84gLm8pMs5SbXN7bmn6jFySgapP1YtUdmgF3Mzu/HisJjeMSLaDG0/8iHEBAbykGFx1SxOgJ+Q8pZE3tOLCfucftCUBSkzYWUnhtjraJQ6lBRmrdLQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=K8EISo5WwoNX9rPB/VLTqw0ZVyskXDLqo42UTwgybnk=;
 b=CIpApnB0pVwVwm71P69E2KSdvMjnpAeo4zDU3XhDHrJUM+Ds55fotKOtPVSoEz5RWBwp89uFdYj/Cr3pprpKoUdPzsA8iU4nwRrxwZalBBCQWVAIWkivy9OCwEN8e74LGPcr+TlxopJmyTXBY/486HrqrbJVcKGKNaH70zMQXZM3lfEbHh1W0R546RiunXiOdorCRWl/5t5Lqldf+KNI4V8iSJ9Q5IugDOk4A4hp1uw4oNoXTa5OwpOpGFgQOEDcs3R3vtdI0m/nk75BDYWeueF4GZpb+mTz3x6mSg/ljkPDoFmDm7LcapvKvCz71g9enyJfhwVZq2QR6zj8CeMPjA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=K8EISo5WwoNX9rPB/VLTqw0ZVyskXDLqo42UTwgybnk=;
 b=T/UQilBI8dPt/2UUW8+AnArw3moK1a1+7ac094Lv2hM9XXZ38C5eM6/N147ZvWR2XIGbPKRTg4VtoNjB8cu5SQeGwoGgU3yf4g2Ll23XTWw3paCidGz1T6mTn0r/oancwkgl4XgRHLa+EsHF7YNsTTqazzW6RqudYvtTdwhyFzMQlnNdF4DsqWo3FRce3DerirqGUo7yRzSeAkQgbvPP2AAgLTNid62FOL1p/wFYuagcg47akU1pbEmsWBeRm0DZnAWD/Fmy+4gtwGps5KSquCRI+53SnZg4hdxt/B5Mz5sHng25N5HQm352nAfH2HCpZtNm/4u5up5YOIa7tnOLUA==
From: Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
To: Stefano Stabellini <sstabellini@kernel.org>
CC: Oleksandr <olekstysh@gmail.com>,
        "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Julien Grall <julien@xen.org>, Julien Grall
	<jgrall@amazon.com>
Subject: Re: [PING] Re: [PATCH] xen/arm: optee: Allocate anonymous domheap
 pages
Thread-Topic: [PING] Re: [PATCH] xen/arm: optee: Allocate anonymous domheap
 pages
Thread-Index: AQHXoyUNSkY32SPluU6N5DMbFmm656uyJ0MAgAAJFoCAE/PzgIAAsCsAgAESVAA=
Date: Thu, 7 Oct 2021 17:57:08 +0000
Message-ID: <87r1cwra4t.fsf@epam.com>
References: <1630935741-17088-1-git-send-email-olekstysh@gmail.com>
 <alpine.DEB.2.21.2109231308200.17979@sstabellini-ThinkPad-T480s>
 <87bl4jrovq.fsf@epam.com> <81f7699b-69c1-da52-a1a7-5000343bf872@gmail.com>
 <alpine.DEB.2.21.2110061639050.3209@sstabellini-ThinkPad-T480s>
In-Reply-To: <alpine.DEB.2.21.2110061639050.3209@sstabellini-ThinkPad-T480s>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
user-agent: mu4e 1.6.5; emacs 27.2
authentication-results: kernel.org; dkim=none (message not signed)
 header.d=none;kernel.org; dmarc=none action=none header.from=epam.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: e53d690d-96be-416b-4be7-08d989bbe14a
x-ms-traffictypediagnostic: PAXPR03MB7779:
x-ms-exchange-transport-forked: True
x-microsoft-antispam-prvs: 
 <PAXPR03MB77795E57E854ADEA15DBA6C6E6B19@PAXPR03MB7779.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:8882;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 u2cDA+9fj146BLWSQqR29fpD03ZU3/bsuqOjHOErPT1x1JnpKT1pGJCkrclcgPsOBTCT4rTxj+fR42SInZFgyOnyA9Q6JcfNxrEy5eh7vpmIHEt+E9aF2Py2bydsGn/QUJKfP4n2Sdb6pJrx7kT+oCbrkgvgS6ukV/wrVXiwXrPpASqce9ulWDvg5UBPvUGUnCyBlLsnSKFRfMRG4N2rS3fetDHOwDbyP7VheJrCTWVKH8qCpQMu2mZXRn2deh/BpiousXvFfwguwa9nAK+YFAh8Dh4SMZIzANdDrAU5UvZSLVJ5g/nxChtYu2KQGmAN5DTosUFPmePIdcAe4z1eEeLJJPAG6BbJlBmJfAX7Xxu0vD08hspn0CJfw3NYOu/En47UY72XEVKGYd+ulKtDJIHizBBfnBOz/nq1HhXIExBnTJaj8iMTZytbQv8znGXcDBEsby0T+2Xa8mh5jYwxpD6e9eztdJI/6xnMtanp2J1WmHGT864r7TV4i/Az32eJfvnh10QKE6ucU+3rcyZCqPYDGUn1MjhwZqVyEC9lKgJsVMdRguRmWyEZTJ2Wx81giBxv3DjKR0xXVOg/GxsXmnyNVGHt0gX+DhcIPIBndbGq2TWCG0u/XmGJ221278ozcBelheGQcgM4K5p0aJcTbw75jTpeoHY1+7K4rRJec28OBVkg1hUXiz7ffjBt5lQRswCLE5iIoWfVLyj2LoEsNw==
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR03MB7594.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(4326008)(26005)(6486002)(38100700002)(122000001)(2906002)(83380400001)(8676002)(8936002)(508600001)(54906003)(6506007)(91956017)(6512007)(66556008)(55236004)(53546011)(66476007)(36756003)(66446008)(71200400001)(64756008)(5660300002)(66946007)(76116006)(86362001)(38070700005)(186003)(2616005)(316002)(6916009);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?iso-8859-1?Q?vdaiwgr1OC8rG37Oym4RjmHjSEdUJYrahR/qnPeyNIyENifJnkxBwAMLcN?=
 =?iso-8859-1?Q?2670e/QVzs63DDltHzZKYMp51q1uTXgB6xPb5rNxgtcF9zxkYK+PdFbTtW?=
 =?iso-8859-1?Q?Evkue75cMu6okjjLzNYIZG+qFRRkugzMOWwXrFmXNz/ZGcg/1Egr1gGBIK?=
 =?iso-8859-1?Q?SSNJVHgftljTbRRmkd3z1a35M9ooTn/m6Czy0tjAWheyregD206xz/RybM?=
 =?iso-8859-1?Q?aDXfDYhEBUpjhNhBvx3/MTXbWjiLhPWg3dFMqq4S4zwX2Cic/rzchRhElh?=
 =?iso-8859-1?Q?FTkRk7FGqrGSggZncF5pSmrVyRNvn1g4earmsRLkD1f1wbDrc/eqt1iQ1C?=
 =?iso-8859-1?Q?6CDyfIki/PkbWKYhpUTT/BmWlmZiozu4syGfhhwvY+abgTJnT57nZeXgRx?=
 =?iso-8859-1?Q?xr2F7lMifbkoAQ5Z+15kX4SJNZ+u4zZ7jqxctP1nPQBuH4xUJAgxwmi8DE?=
 =?iso-8859-1?Q?pZqh9uDy+OAa4t2b4beGYFNfc6PS3nRkhT73BABZ86rRna9IgMKKKnl5fQ?=
 =?iso-8859-1?Q?s0fuzYXTtHt88O9g8QsY2wnITT3CqnKW3XsO/N2v6Wyxh15MWabxH5cnw+?=
 =?iso-8859-1?Q?ySOjD/CQG3O444wBo2LQy09wyJegMXPDOx/iUAjihIT0gnkexko6Hi2b6/?=
 =?iso-8859-1?Q?wizoHyujrSWWYgk9h546EZ8ahYgKhRu1OluIWgDzQLvX6+dyKUDX8kZoxI?=
 =?iso-8859-1?Q?9Ks0ftSKTcXI1rUR3HqC/BqN7/ytId888G65bBuLgsb8LupNs2X42kQ9CI?=
 =?iso-8859-1?Q?zAh4FIxLvRpyznZBXJlnbYwJ7wVBReUdLEXElRLky4sFWbdbRAL5cbYUpz?=
 =?iso-8859-1?Q?nEpwIIrOlFPB/baS5UqnPY8F3TzXyLJ9fDK7nCRdBV4g+g3gxdDT0M3yJ8?=
 =?iso-8859-1?Q?s3Ydpj1m3UCaWxg/LbFqROJA550GTgzmbz5PXydnbsOHujnkF0Mjaht+HX?=
 =?iso-8859-1?Q?hqujEXKO1rx/LoM2G1jpfHLyUy1pviH3Rgpc0YKsb16s9QuEw7J9cD7IIl?=
 =?iso-8859-1?Q?vZ5tWesp1D0wBDewhWXHI4r+o779LXdFWRH15LPSS9RyzzMJqdZ6PfysPK?=
 =?iso-8859-1?Q?8fX9xs6MtYyp2yS9J9PcERe6pFTWDNCMHIktGdys6NsZ2FOBuYk3lEFNDH?=
 =?iso-8859-1?Q?FCnhy7uXIzBqgMEEw00+bBl8jgaCEjiU36gMB2ISplzuHnq0zcdq+R5z0a?=
 =?iso-8859-1?Q?KcycpEYbphglNVvbV7nharv7bC8T4JxkS2/F2R06Uuw3fyc7tPSMSlhIul?=
 =?iso-8859-1?Q?UFBMYVF6i4MAWPvFfd9uqqir6ueSCvfm0l7JbY6AlWZQ4cA85czR2zMu4J?=
 =?iso-8859-1?Q?Z+F4MZ3iUfo3WmN6bqt3T0PFhoGgBdYhSu/177ZLPeiHDzwF3TGbrBDatB?=
 =?iso-8859-1?Q?tzB5yucvzC?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PAXPR03MB7594.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e53d690d-96be-416b-4be7-08d989bbe14a
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Oct 2021 17:57:08.0322
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: b4/aV9QTJPdc43K79b5AXXGc8otWfC8MPlqV/eDRnqABLvMwC6eJBav1zX/z9ooPClLxT1Ta9RdRzidhScQYs7Q672f1lEUtiBkk8qDh7Hs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR03MB7779
X-Proofpoint-ORIG-GUID: KWyNnFnHEoYzZJrs1mgf8Ua9XtYPWB7_
X-Proofpoint-GUID: KWyNnFnHEoYzZJrs1mgf8Ua9XtYPWB7_
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.391,FMLib:17.0.607.475
 definitions=2021-10-07_03,2021-10-07_02,2020-04-07_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 adultscore=0
 mlxlogscore=999 suspectscore=0 impostorscore=0 spamscore=0
 lowpriorityscore=0 phishscore=0 priorityscore=1501 clxscore=1015
 bulkscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2109230001 definitions=main-2110070116


Hi Stefano,

Stefano Stabellini <sstabellini@kernel.org> writes:

> On Wed, 6 Oct 2021, Oleksandr wrote:
>> Hello all
>>=20
>> Gentle reminder.
> =20
> Many thanks for the ping, this patch fell off my radar.
>
>
> =20
>> On 23.09.21 23:57, Volodymyr Babchuk wrote:
>> > Hi Stefano,
>> >=20
>> > Stefano Stabellini <sstabellini@kernel.org> writes:
>> >=20
>> > > On Mon, 6 Sep 2021, Oleksandr Tyshchenko wrote:
>> > > > From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>> > > >=20
>> > > > Allocate anonymous domheap pages as there is no strict need to
>> > > > account them to a particular domain.
>> > > >=20
>> > > > Since XSA-383 "xen/arm: Restrict the amount of memory that dom0les=
s
>> > > > domU and dom0 can allocate" the dom0 cannot allocate memory outsid=
e
>> > > > of the pre-allocated region. This means if we try to allocate
>> > > > non-anonymous page to be accounted to dom0 we will get an
>> > > > over-allocation issue when assigning that page to the domain.
>> > > > The anonymous page, in turn, is not assigned to any domain.
>> > > >=20
>> > > > CC: Julien Grall <jgrall@amazon.com>
>> > > > Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com=
>
>> > > > Acked-by: Volodymyr Babchuk <volodymyr_babchuk@epam.com>
>> > > Only one question, which is more architectural: given that these pag=
es
>> > > are "unlimited", could the guest exploit the interface somehow to fo=
rce
>> > > Xen to allocate an very high number of anonymous pages?
>> > >=20
>> > > E.g. could a domain call OPTEE_SMC_RPC_FUNC_ALLOC in a loop to force=
 Xen
>> > > to exaust all memory pages?
>> > Generally, OP-TEE mediator tracks all resources allocated and imposes
>> > limits on them.
>> >=20
>> > OPTEE_SMC_RPC_FUNC_ALLOC case is a bit different, because it is issued
>> > not by domain, but by OP-TEE itself. As OP-TEE is more trusted piece o=
f
>> > system we allow it to request as many buffers as it wants. Also, we kn=
ow
>> > that OP-TEE asks only for one such buffer per every standard call. And
>> > number of simultaneous calls is limited by number of OP-TEE threads,
>> > which is quite low: typically only two.
>
> So let me repeat it differently to see if I understood correctly:
>
> - OPTEE_SMC_RPC_FUNC_ALLOC is only called by OP-TEE, not by the domain
> - OPTEE is trusted and only call it twice anyway

Correct.

> I am OK with this argument, but do we have a check to make sure a domU
> cannot issue OPTEE_SMC_RPC_FUNC_ALLOC?

domU can't issue any RPC, because all RPCs are issued from OP-TEE
side. This is the nature of RPC - OP-TEE requests Normal World for some
service. But of course, Normal World can perform certain actions that
will make OP-TEE to issue a RPC. I discuss this in depth below.

>
> Looking at the patch, there are other two places, in addition to
> OPTEE_SMC_RPC_FUNC_ALLOC, where the anonymous memory pages can be
> allocated:
>
> 1) copy_std_request
> 2) translate_noncontig
>
> We need to prove that neither 1) or 2) can result in a domU exausting
> Xen memory.
>
> In the case of 1), it looks like the memory is freed before returning to
> the DomU, right? If so, it should be no problem?

Yes, mediator makes shadow copy of every request buffer to hide
translated addresses from the guest. Number of requests is limited by
number of OP-TEE threads.

> In the case of 2), it looks like the memory could outlive the call where
> it is allocated. Is there any kind of protection against issuing
> something like OPTEE_MSG_ATTR_TYPE_TMEM_INOUT in a loop? Is it OP-TEE
> itself that would refuse the attempt? Thus, the idea is that
> do_call_with_arg will return error and we'll just free the memory there?

Well, translate_noncontig() calls allocate_optee_shm_buf() which counts
all allocated buffers. So you can't call it more than
MAX_SHM_BUFFER_COUNT times, without de-allocating previous memory. But,
thanks to your question, I have found a bug there: memory is not freed
if allocate_optee_shm_buf() fails. I'll prepare patch later today.

> I cannot see a check for errors returned by do_call_with_arg and memory
> freeing done because of that. Sorry I am not super familiar with the
> code, I am just trying to make sure we are not offering to DomUs an easy
> way to crash the system.

I tried to eliminate all possibilities for a guest to crash the
system. Of course, this does not mean that there are none of them.

And yes, code is a bit hard to understand, because calls to OP-TEE are
stateful and you need to account for that state. From NW and SW this
looks quite fine, because state is handled naturally. But mediator sits
in a middle, so it's implementation is a bit messy.

I'll try to explain what is going on, so you it will be easier to
understand logic in the mediator.

There are two types of OP-TEE calls: fast calls and standard calls. Fast
call is simple: call SMC and get result. It does not allocate thread
context in OP-TEE and is non-preemptive. So yes, it should be fast. It
is used for simple things like "get OP-TEE version" or "exchange
capabilities". It is easy to handle them in mediator: just forward
the call, check result, return it back to a guest.

Standard calls are stateful. OP-TEE allocates thread for each call. This
call can be preempted either by IRQ or by RPC. For consistency IRQ
return is also considered as special type of RPC. So, in general one
standard call can consist of series of SMCs:

--> SMC with request
<-- RPC return (like IRQ)
--> SMC "resume call"
<-- RPC return (like "read disk")
--> SMC "resume call"
<-- RPC return (like "send network packet")
--> SMC "resume call"
...
<-- Final return

There are many types of RPCs: "handle IRQ", additional shared buffer
allocation/de-allocation, RPMB access, disks access, network access,
synchronization primitives (when OP-TEE thread is gets blocked on a
mutex), etc.

Two more things that makes all this worse: Normal World can register
shared buffer with OP-TEE. Such buffer can live indefinitely
long. Also, Normal World decides when to resume call. For example,
calling process can be preempted and then resumed seconds
later. Misbehaving guest can decide to not resume call at all.

As I said, I tried to take all this things into account. There are
basically 3 types of objects that can lead to memory allocation on Xen
side:

1. Standard call context. Besides memory space for struct optee_std_call
itself it allocates page for a shadow buffer, where argument addresses
are translated by Xen. Number of this objects is limited by number of
OP-TEE threads:

    count =3D atomic_add_unless(&ctx->call_count, 1, max_optee_threads);
    if ( count =3D=3D max_optee_threads )
        return ERR_PTR(-ENOSPC);

2. Shared buffer. This is a buffer shared by guest with OP-TEE. It can
be either temporary buffer which is shared for one standard call
duration, or registered shared buffer, which is remains active until it
is de-registered. This is where translate_noncontig() comes into play.
Number of this buffers is limited in allocate_optee_shm_buf():

    count =3D atomic_add_unless(&ctx->optee_shm_buf_count, 1,
                              MAX_SHM_BUFFER_COUNT);
    if ( count =3D=3D MAX_SHM_BUFFER_COUNT )
        return ERR_PTR(-ENOMEM);

3. Shared RPC buffer. This is very special kind of buffer. Basically,
OP-TEE needs some shared memory to provide RPC call parameters. So it
requests buffer from Normal World. There is no hard limit on this from
mediator side, because, as I told earlier, OP-TEE itself limits number
of this buffers. There is no cases when more that one buffer will be
allocated per OP-TEE thread. This type of buffer is used only to process
RPC requests themselves. OP-TEE can request more buffers via RPC, but
they will fall to p.2: NW uses separate request to register buffer and
then returns its handle in the preempted call.


Apart from those two limits, there is a limit on total number of pages
which is shared between guest and OP-TEE: MAX_TOTAL_SMH_BUF_PG. This
limit is for a case when guest tries to allocate few really BIG buffers.


> It looks like they could be called from one of the OPTEE operations that
> a domU could request? Is there a limit for them?

Yes, there are limits, as I described above.

Also, bear in mind that resources available to OP-TEE are also quite
limited. So, in case of some breach in mediator, OP-TEE will give up
first. This of course is not an excuse to have bugs in the mediator...

--=20
Volodymyr Babchuk at EPAM=


From xen-devel-bounces@lists.xenproject.org Thu Oct 07 17:57:28 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Oct 2021 17:57:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.203909.359058 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYXdr-0006dQ-Cw; Thu, 07 Oct 2021 17:57:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 203909.359058; Thu, 07 Oct 2021 17:57:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYXdr-0006dJ-A2; Thu, 07 Oct 2021 17:57:15 +0000
Received: by outflank-mailman (input) for mailman id 203909;
 Thu, 07 Oct 2021 17:57:13 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=4W4d=O3=gmail.com=olekstysh@srs-us1.protection.inumbo.net>)
 id 1mYXdp-0006dD-DD
 for xen-devel@lists.xenproject.org; Thu, 07 Oct 2021 17:57:13 +0000
Received: from mail-ed1-x52b.google.com (unknown [2a00:1450:4864:20::52b])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 8d4650e9-ca79-4c1b-bdc8-9b7313dfe0e1;
 Thu, 07 Oct 2021 17:57:12 +0000 (UTC)
Received: by mail-ed1-x52b.google.com with SMTP id y12so12944568eda.4
 for <xen-devel@lists.xenproject.org>; Thu, 07 Oct 2021 10:57:12 -0700 (PDT)
Received: from [192.168.1.7] ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id r3sm47502edo.59.2021.10.07.10.57.10
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Thu, 07 Oct 2021 10:57:11 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8d4650e9-ca79-4c1b-bdc8-9b7313dfe0e1
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-transfer-encoding:content-language;
        bh=g/dLkRjoDMfXYeQubimdoTjxmnGAx8Yx9fUp1f0SmjI=;
        b=bDWMVi6RjeNrzLV6Fav9tlhdqIgvBXk3Xtu6AkzzUDd+GjmrH75STljzrMBmesMrIQ
         t/DOJeypfJ+xPPjfLHI6U/iEKbT26eott7/ZA3Q3LpioGAoLmp8+MYCx6K5nwPDzBkgW
         0jJxUcUB+BU84rqZLaFpXRmC2+ILPoXnYBjJDCFQeJrA6bE0EgJmzbtsHGOCXCIOf2/I
         B61EAVFc1VEig7Vi866+9VY80Hpx4tnctpbzI9b3Poaf1amCzjUTi/oqmCP1nahAkAlm
         llj5V5OHqS7u297QJEPW53xdwAjtMCaoyijs2gQaet9VqCFxofwewivbipr4E9Xz9Qt/
         /pOQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding
         :content-language;
        bh=g/dLkRjoDMfXYeQubimdoTjxmnGAx8Yx9fUp1f0SmjI=;
        b=NnKGnu3VcX68Qxql+EbbNrodhEOJmeRp4JWFn7mnFih6ltIhunvD609d+hivdDYqDU
         wVLcaftF6+Vtwr06wnSAjKHqlY2MYj7PBQOs0d1CqGlNMAMfsGZ57zyBGtGidqIberZc
         XvpEm6WY1Vf7qHdqGITdOtKx2n35lXevESk+1IWdfSn7QTrJVn4cdPi1zs05kzFiutOi
         jDVMUlWe1e6z1/He3AVIXODdCSFr8YXjfYR8XKUGh9Jei4IqJSgYAx7bGupfK2u0dJGj
         BaK16021cNFgyOD8MvrP9oE/E26u19Ei0F5LsgnZiwag3YoIKP2EySKHhCMwW3/h1pwP
         ezuw==
X-Gm-Message-State: AOAM531lzuQelCVnEtYjf5bzCaqCd1WrEvl8YwAVZulXnufwrF0z8Fei
	SwDB3cESCdfUkvuYUfVyqbY=
X-Google-Smtp-Source: ABdhPJwwfOMxbdiOfF9vnzvOEVC+j7eeB2qOA4J85UXZV6tv0ZER+xYam8lvPZBrXmbPFD8EPR6UtQ==
X-Received: by 2002:aa7:cb8a:: with SMTP id r10mr8058582edt.237.1633629431382;
        Thu, 07 Oct 2021 10:57:11 -0700 (PDT)
Subject: Re: [PATCH] xen/arm: optee: Fix arm_smccc_smc's a0 for
 OPTEE_SMC_DISABLE_SHM_CACHE
To: Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>
Cc: xen-devel@lists.xenproject.org,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Volodymyr Babchuk <volodymyr_babchuk@epam.com>, tee-dev@lists.linaro.org
References: <1632750850-28600-1-git-send-email-olekstysh@gmail.com>
 <alpine.DEB.2.21.2109272151260.5022@sstabellini-ThinkPad-T480s>
 <e612c225-cda6-2c41-bf20-73314ebceb02@xen.org>
 <alpine.DEB.2.21.2110061537310.3209@sstabellini-ThinkPad-T480s>
From: Oleksandr <olekstysh@gmail.com>
Message-ID: <29e1696a-5664-25f4-b679-1f73020ecf97@gmail.com>
Date: Thu, 7 Oct 2021 20:57:10 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.21.2110061537310.3209@sstabellini-ThinkPad-T480s>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US


On 07.10.21 01:42, Stefano Stabellini wrote:

Hi Stefano, Julien.

> On Wed, 6 Oct 2021, Julien Grall wrote:
>> Hi Stefano,
>>
>> On 28/09/2021 06:52, Stefano Stabellini wrote:
>>> On Mon, 27 Sep 2021, Oleksandr Tyshchenko wrote:
>>>> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>>>>
>>>> Fix a possible copy-paste error in arm_smccc_smc's first argument (a0)
>>>> for OPTEE_SMC_DISABLE_SHM_CACHE case.
>>>>
>>>> This error causes Linux > v5.14-rc5
>>>> (b5c10dd04b7418793517e3286cde5c04759a86de
>>>> optee: Clear stale cache entries during initialization) to stuck
>>>> repeatedly issuing OPTEE_SMC_DISABLE_SHM_CACHE call and waiting for
>>>> the result to be OPTEE_SMC_RETURN_ENOTAVAIL which will never happen.
>>>>
>>>> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>>> Acked-by: Stefano Stabellini <sstabellini@kernel.org>
>>>
>>> I added Fixes: and Backport: tags to the commit
>> Per SUPPORT.MD, OP-TEE is still a technical preview. So I would argue that we
>> should not do any backport because the feature itself is not officially
>> considered supported.
> Good point!
>
>
>> That said, what's missing to make the feature officially supported?
> If Oleksandr is also happy to make OP-TEE support in Xen "Supported" in
> SUPPORT.md I'd be happy with that too. Specifically I suggest to change
> it to:
>
> Status: Supported, not security supported
>
> Security Support is a bit of a heavy process and I am thinking that
> "Supported, not security supported" would be an excellent next step.

I would be happy, and can send a formal patch. But I am not an expert in 
this code.

As a user I can say that OP-TEE mediator works perfectly fine, but let's 
wait for the input from Volodymyr,

(looks like there are some TODO left in the code and I have no idea what 
are the implications)


-- 
Regards,

Oleksandr Tyshchenko



From xen-devel-bounces@lists.xenproject.org Thu Oct 07 19:23:31 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Oct 2021 19:23:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.203927.359081 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYYz7-0007ZO-0O; Thu, 07 Oct 2021 19:23:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 203927.359081; Thu, 07 Oct 2021 19:23:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYYz6-0007ZH-Ti; Thu, 07 Oct 2021 19:23:16 +0000
Received: by outflank-mailman (input) for mailman id 203927;
 Thu, 07 Oct 2021 19:23:16 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mYYz6-0007Z7-DV; Thu, 07 Oct 2021 19:23:16 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mYYz6-0002YV-6X; Thu, 07 Oct 2021 19:23:16 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mYYz5-0005kq-UZ; Thu, 07 Oct 2021 19:23:15 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mYYz5-0008Se-U7; Thu, 07 Oct 2021 19:23:15 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=xoBn+yc9jkjy9D9AKclGvmXfEQ7U3Drr4YhC49nSpQU=; b=iG+E1qjoci8L9HQz6ElEVE4yO3
	LWDvK2OppA5mXhvZdIw9OF+JIep8APwCK18EB7jw07Xq1MhPgcoXga+LZMpy+JUgBnncAkPDJv9bY
	kMzBEYjjvg2etg6bT8Y4ML//kWbSHjooW49bhcdv3W/aQzrPsEbDU1AIj30xbqdI4nvg=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165417-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 165417: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=2a04f396a34c5a43b9a09d72e8c4f49c64066cce
X-Osstest-Versions-That:
    xen=192aaf7e146c0b41dbdd35ccdb13eb33ced13633
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 07 Oct 2021 19:23:15 +0000

flight 165417 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165417/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  2a04f396a34c5a43b9a09d72e8c4f49c64066cce
baseline version:
 xen                  192aaf7e146c0b41dbdd35ccdb13eb33ced13633

Last test of basis   165383  2021-10-05 19:01:46 Z    2 days
Testing same since   165417  2021-10-07 16:02:53 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Anthony PERARD <anthony.perard@citrix.com>
  Bob Eshleman <bobbyeshleman@gmail.com>
  Connor Davis <connojdavis@gmail.com>
  Jan Beulich <jbeulich@suse.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   192aaf7e14..2a04f396a3  2a04f396a34c5a43b9a09d72e8c4f49c64066cce -> smoke


From xen-devel-bounces@lists.xenproject.org Thu Oct 07 19:55:11 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Oct 2021 19:55:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.203939.359095 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYZTt-0002Z8-HX; Thu, 07 Oct 2021 19:55:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 203939.359095; Thu, 07 Oct 2021 19:55:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYZTt-0002Z1-Dk; Thu, 07 Oct 2021 19:55:05 +0000
Received: by outflank-mailman (input) for mailman id 203939;
 Thu, 07 Oct 2021 19:55:04 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Ti8Z=O3=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1mYZTs-0002Yp-1g
 for xen-devel@lists.xenproject.org; Thu, 07 Oct 2021 19:55:04 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 1a2ba353-26fe-4286-8704-bcaaf39f6f0f;
 Thu, 07 Oct 2021 19:55:02 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id 6323F60F6E;
 Thu,  7 Oct 2021 19:55:01 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1a2ba353-26fe-4286-8704-bcaaf39f6f0f
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1633636502;
	bh=PeomhYfkpEV6kG1rxMyasyBdCL+wFtjPQzws4Etuy+8=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=BitDmeMYE/PpAAVNnxhbHBMamEVL3dKe+YiXbnFDQvYSHrg3weVCeaMvvf2EIXSBr
	 4VeC6QZj73mvemfM0PKGOnI+9NtdELXmLjDGaFkBAREJlSOM8AQR2sb/5SqoNEY0mf
	 IlfxSRtZr90rDg0Kc/WSFKcHibplIIi9CBuHnLbturyvTORc6EmDaddkTQO6R2WU3p
	 cJb49jLw8XaZy6c5KgLGB0dhoWb866I2tSC1RjBcbB3CWtb7qWsxahXUOHK99p8tHr
	 YqaCOqigr5DoyOqrbqtO8zMrqolMilYQcdY9XvnvCGcgPX2gFx+8b8r7QTah2h1qgD
	 r8ey0mpk9Kq6Q==
Date: Thu, 7 Oct 2021 12:54:53 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Rahul Singh <rahul.singh@arm.com>
cc: xen-devel@lists.xenproject.org, bertrand.marquis@arm.com, 
    Andre.Przywara@arm.com, Ian Jackson <iwj@xenproject.org>, 
    Wei Liu <wl@xen.org>, Juergen Gross <jgross@suse.com>, 
    Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, 
    Andrew Cooper <andrew.cooper3@citrix.com>, 
    George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>, 
    =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= <roger.pau@citrix.com>, 
    Christian Lindig <christian.lindig@citrix.com>, 
    David Scott <dave@recoil.org>, Paul Durrant <paul@xen.org>, 
    Anthony PERARD <anthony.perard@citrix.com>
Subject: Re: [PATCH v5 00/11] PCI devices passthrough on Arm
In-Reply-To: <cover.1633540842.git.rahul.singh@arm.com>
Message-ID: <alpine.DEB.2.21.2110071251530.414@sstabellini-ThinkPad-T480s>
References: <cover.1633540842.git.rahul.singh@arm.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

I committed patches 2-7.

I made two small adjustments on commit:
- patch #3: bool_t/bool
- patch #7: drop _XEN_DOMCTL_CDF_vpci

Cheers,

Stefano


On Wed, 6 Oct 2021, Rahul Singh wrote:
> Hello All,
> 
> The purpose of this patch series is to add PCI passthrough support to Xen on
> Arm. PCI passthrough support on ARM is the collaboration work between EPAM and
> ARM. ARM submitted the partial RFC [1][2] last year to get early feedback. We
> tried to fix all the comments and added more features to this patch series.
> 
> Working POC with all the features can be found at [3]. Working POC is tested
> on x86 so that there will be no regression on x86. Design presentation can be
> found at [4]
> 
> PCI passthrough support is divided into different patches. This patch series
> includes following features: 
> 
> Preparatory work to implement the PCI passthrough support for the ARM:
> - Refactor MSI code.
> - Fixed compilation error when HAS_PCI enabled for ARM.
> 
> Discovering PCI Host Bridge in XEN:
> - PCI init to initialize the PCI driver.
> - PCI host bridge discovery in XEN and map the PCI ECAM configuration space to
>   the XEN memory.
> - PCI access functions.
> 
> Discovering PCI devices:
> - To support the PCI passthrough, XEN should be aware of the PCI
>   devices.
> - Hardware domain is in charge of doing the PCI enumeration and will discover
>   the PCI devices and then communicate to the XEN via a hypercall to add the
>   PCI devices in XEN.
> 
> Enable the existing x86 virtual PCI support for ARM:
> - Add VPCI trap handler for each of the PCI device added for config space
>   access.
> - Register the trap handler in XEN for each of the host bridge PCI ECAM config
>   space access.
> 
> Emulated PCI device tree node in libxl:
> - Create a virtual PCI device tree node in libxl to enable the guest OS to
>   discover the virtual PCI during guest boot.
> 
> This patch series does not inlcude the following features. Following features
> will be send for review in the next version of the patch series once initial
> patch series merged.
> 
> - VPCI support for DOMU guests (Non-identity mappings guest view of the BARs)
> - Virtual bus topology implementation
> - IOMMU related changes (generic, SMMUv2, SMMUv3)
> - MSI support for DOMU guests.
> - Virual ITS support for DOMU guests
> 
> [1] https://lists.xenproject.org/archives/html/xen-devel/2020-07/msg01184.html
> [2] https://lists.xenproject.org/archives/html/xen-devel/2020-07/threads.html#01184
> [3] https://gitlab.com/rahsingh/xen-integration/-/tree/arm_pci_v4_integrate
> [4] https://static.sched.com/hosted_files/xen2021/e4/PCI_Device_Passthrough_On_Arm.pdf
> 
> Oleksandr Andrushchenko (1):
>   xen/arm: Add support for Xilinx ZynqMP PCI host controller
> 
> Rahul Singh (10):
>   xen/arm: xc_domain_ioport_permission(..) not supported on ARM.
>   xen/arm: Add PHYSDEVOP_pci_device_(*add/remove) support for ARM
>   xen/arm: Add cmdline boot option "pci-passthrough = <boolean>"
>   xen/arm: PCI host bridge discovery within XEN on ARM
>   xen/arm: Implement pci access functions
>   xen/domctl: Introduce XEN_DOMCTL_CDF_vpci flag
>   xen/arm: Enable the existing x86 virtual PCI support for ARM.
>   xen/arm: Transitional change to build HAS_VPCI on ARM.
>   arm/libxl: Emulated PCI device tree node in libxl
>   xen/arm: Add linux,pci-domain property for hwdom if not available.
> 
>  docs/misc/xen-command-line.pandoc   |   7 +
>  tools/include/libxl.h               |   6 +
>  tools/libs/ctrl/xc_domain.c         |   9 +
>  tools/libs/light/libxl_arm.c        | 111 +++++++++++
>  tools/libs/light/libxl_types.idl    |   1 +
>  tools/ocaml/libs/xc/xenctrl.ml      |   1 +
>  tools/ocaml/libs/xc/xenctrl.mli     |   1 +
>  xen/arch/arm/Makefile               |   1 +
>  xen/arch/arm/domain.c               |   8 +-
>  xen/arch/arm/domain_build.c         |  19 ++
>  xen/arch/arm/pci/Makefile           |   5 +
>  xen/arch/arm/pci/ecam.c             |  61 ++++++
>  xen/arch/arm/pci/pci-access.c       | 140 ++++++++++++++
>  xen/arch/arm/pci/pci-host-common.c  | 287 ++++++++++++++++++++++++++++
>  xen/arch/arm/pci/pci-host-generic.c |  48 +++++
>  xen/arch/arm/pci/pci-host-zynqmp.c  |  65 +++++++
>  xen/arch/arm/pci/pci.c              |  12 ++
>  xen/arch/arm/physdev.c              |   6 +-
>  xen/arch/arm/vpci.c                 | 102 ++++++++++
>  xen/arch/arm/vpci.h                 |  36 ++++
>  xen/arch/x86/domain.c               |   6 +
>  xen/arch/x86/physdev.c              |  52 +----
>  xen/arch/x86/x86_64/physdev.c       |   2 +-
>  xen/common/domain.c                 |   2 +-
>  xen/drivers/passthrough/pci.c       |  18 ++
>  xen/drivers/pci/Makefile            |   1 +
>  xen/drivers/pci/physdev.c           |  86 +++++++++
>  xen/drivers/vpci/Makefile           |   3 +-
>  xen/drivers/vpci/header.c           |   2 +
>  xen/include/asm-arm/domain.h        |   7 +-
>  xen/include/asm-arm/pci.h           |  85 ++++++++
>  xen/include/asm-x86/pci.h           |   8 +-
>  xen/include/public/arch-arm.h       |  21 +-
>  xen/include/public/domctl.h         |   4 +-
>  xen/include/xen/hypercall.h         |   4 +
>  xen/include/xen/pci.h               |   2 +
>  36 files changed, 1168 insertions(+), 61 deletions(-)
>  create mode 100644 xen/arch/arm/pci/ecam.c
>  create mode 100644 xen/arch/arm/pci/pci-access.c
>  create mode 100644 xen/arch/arm/pci/pci-host-common.c
>  create mode 100644 xen/arch/arm/pci/pci-host-generic.c
>  create mode 100644 xen/arch/arm/pci/pci-host-zynqmp.c
>  create mode 100644 xen/arch/arm/vpci.c
>  create mode 100644 xen/arch/arm/vpci.h
>  create mode 100644 xen/drivers/pci/physdev.c
> 
> -- 
> 2.25.1
> 


From xen-devel-bounces@lists.xenproject.org Thu Oct 07 20:06:55 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Oct 2021 20:06:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.203955.359130 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYZfH-0004W5-3s; Thu, 07 Oct 2021 20:06:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 203955.359130; Thu, 07 Oct 2021 20:06:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYZfH-0004Vy-0K; Thu, 07 Oct 2021 20:06:51 +0000
Received: by outflank-mailman (input) for mailman id 203955;
 Thu, 07 Oct 2021 20:06:49 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Ti8Z=O3=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1mYZfF-0004Vs-9X
 for xen-devel@lists.xenproject.org; Thu, 07 Oct 2021 20:06:49 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 1986add6-27aa-11ec-bffc-12813bfff9fa;
 Thu, 07 Oct 2021 20:06:48 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id 4B0266105A;
 Thu,  7 Oct 2021 20:06:47 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1986add6-27aa-11ec-bffc-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1633637207;
	bh=l50GX8BRMPz7QLa9GLuAlpb90I7ccL1kjSWrfU1T7J8=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=NVh+aAvFqpmLs1vCXT8fMYPIxzKkaxc4HONxMOczxznzm67y6mprZR7eKR3YRBRdw
	 vU0pyJPI59qSWTyQ7AqJnxKtVGhmTbGYP8tuhlf843Nz6wBGvEqFb6rlFfLmNpjJhq
	 rx8GTcbTLJs0ITwBs2uwSkmxyQE7sg/G+BGFl74dGKypX0wBDPjIGKAb3+jKcpW+e7
	 NkYwcG6nFxzTLjaMjFf/9IHMymvFDAcj7kVo85EYJfd5I1VVTmFVmcoCsHwgXCzaXm
	 oYFAs4HDR+mMSR0AervP6q+X6Og6X7XPfIJLaoGtds6qpZBh6JLzlnMN/S1gWvEClK
	 ECZrCuGdolrKw==
Date: Thu, 7 Oct 2021 13:06:46 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Oleksandr <olekstysh@gmail.com>
cc: Stefano Stabellini <sstabellini@kernel.org>, 
    xen-devel@lists.xenproject.org, 
    Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, 
    Julien Grall <julien@xen.org>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH V5 3/3] xen/arm: Updates for extended regions support
In-Reply-To: <a5a81348-4b18-6be6-ba85-4c31172459dc@gmail.com>
Message-ID: <alpine.DEB.2.21.2110071300380.414@sstabellini-ThinkPad-T480s>
References: <1633519346-3686-1-git-send-email-olekstysh@gmail.com> <1633519346-3686-4-git-send-email-olekstysh@gmail.com> <alpine.DEB.2.21.2110061843360.3209@sstabellini-ThinkPad-T480s> <a5a81348-4b18-6be6-ba85-4c31172459dc@gmail.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Thu, 7 Oct 2021, Oleksandr wrote:
> On 07.10.21 04:50, Stefano Stabellini wrote:
> 
> Hi Stefano
> 
> > On Wed, 6 Oct 2021, Oleksandr Tyshchenko wrote:
> > > From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> > > 
> > > This is a follow-up of
> > > "b6fe410 xen/arm: Add handling of extended regions for Dom0"
> > > 
> > > Add various in-code comments, update Xen hypervisor device tree
> > > bindings text, change the log level for some prints and clarify
> > > format specifier, reuse dt_for_each_range() to avoid open-coding
> > > in find_memory_holes().
> > > 
> > > Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> > Thanks for the patch, it looks like you addressed all Julien's comments
> > well.
> 
> I believe so)


[...]

> > > @@ -1193,8 +1215,8 @@ static int __init make_hypervisor_node(struct domain
> > > *d,
> > >           u64 start = ext_regions->bank[i].start;
> > >           u64 size = ext_regions->bank[i].size;
> > >   -        dt_dprintk("Extended region %d: %#"PRIx64"->%#"PRIx64"\n",
> > > -                   i, start, start + size);
> > > +        printk("Extended region %d: %#"PRIx64"->%#"PRIx64"\n",
> > > +               i, start, start + size);
> > Also should be PRIpaddr
> 
> I thought I needed to change specifier only for variables of type "paddr_t",
> but here "u64".

Sorry, you are right.

I added my reviewed-by and made the small typo changes on commit.


From xen-devel-bounces@lists.xenproject.org Thu Oct 07 20:20:10 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Oct 2021 20:20:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.203965.359145 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYZs4-0006kj-Fh; Thu, 07 Oct 2021 20:20:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 203965.359145; Thu, 07 Oct 2021 20:20:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYZs4-0006k9-Aw; Thu, 07 Oct 2021 20:20:04 +0000
Received: by outflank-mailman (input) for mailman id 203965;
 Thu, 07 Oct 2021 20:20:03 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=4W4d=O3=gmail.com=olekstysh@srs-us1.protection.inumbo.net>)
 id 1mYZs2-0006SE-Ua
 for xen-devel@lists.xenproject.org; Thu, 07 Oct 2021 20:20:03 +0000
Received: from mail-ed1-x530.google.com (unknown [2a00:1450:4864:20::530])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 7ce3e596-fdb0-4b96-810f-5106e3c532f7;
 Thu, 07 Oct 2021 20:20:01 +0000 (UTC)
Received: by mail-ed1-x530.google.com with SMTP id p13so28185188edw.0
 for <xen-devel@lists.xenproject.org>; Thu, 07 Oct 2021 13:20:01 -0700 (PDT)
Received: from [192.168.1.7] ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id w2sm182203edj.44.2021.10.07.13.19.59
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Thu, 07 Oct 2021 13:20:00 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7ce3e596-fdb0-4b96-810f-5106e3c532f7
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-transfer-encoding:content-language;
        bh=x2ugqiSsbh4NHZ4hAN2CzfLqUHMfH4oPfpea4xYsiwQ=;
        b=RAglGAyPEgEXPF4oYNY26Ur9R/TaeQ0HE0MXX7GZOhYgcVLsi2uE+rzhnOTCc1MOja
         +hYyd8n88lVOsRIGdKZcB0iPDlroietW8/zOzCVA+td2OPLn/GiPlO7DQG6cyn0v7uxP
         fRQ8fZhailjDvPRnCtpv75qgaIHYg2aze6CCx2Svp8Pqb+V+M+bhdh9BrOcKy9QcwkXv
         sz6YF7TS/pFB6PsM0lCKbV/8DYO5y99c1ljWDnVrCZQfWsQ3Z4G+JbRkDvHoHmGtazg/
         7qkeTFOsYS9S4KTWpHJqyECcGrW3njY2u0wBlUPXcki+czan/6M8WLTtjNVDR5lXG9C3
         drKQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding
         :content-language;
        bh=x2ugqiSsbh4NHZ4hAN2CzfLqUHMfH4oPfpea4xYsiwQ=;
        b=sHs97XpW/UUYmIPLtAVNH2elfKlpIXxlxM/F9+hYN8lBqtFmzdTr7h0Q4GpbeB4H92
         cybMjh2QFKbyU2ozZ6LsIZlN5ggalWz3Cl8tXxRCIx8Q2Xhz+tDHN4+Z5Hot33d5EhwC
         H9isTuOegDPaztQiGgHJSQaTyMidVv41R1y5RT36MKw0gAVyTavYCh/cRuxP3vW/ELZ7
         u4gvGWoS5FBmehWwCS+gl9/Vrtjg4AghPB59h6YctZFXnBuQzGvnShl5ZGbiWi4vh7U6
         MtoQSCd3pyWpV4rtLoI3EAXppzA0E5QafvqSwkpTWb2lercn9QyoBhGwuMSb6iM/dNLK
         K/Uw==
X-Gm-Message-State: AOAM530Uqm05WbGxvr6DV+WuqSFbuhxYErwYCO0r18sQ6wL1nLnfCBdb
	gOGK+8pzLYzWNpWYcg5G+6E=
X-Google-Smtp-Source: ABdhPJxnj2qOw3jF2XFSJLwGFp+PP7nHbvOTPMggNgyv65kNQIAxavd/EdeVikhVxIIMUS8fKvhq/w==
X-Received: by 2002:a50:da49:: with SMTP id a9mr9212057edk.281.1633638000676;
        Thu, 07 Oct 2021 13:20:00 -0700 (PDT)
Subject: Re: [PATCH V5 1/3] xen/arm: Introduce gpaddr_bits field to struct
 xen_arch_domainconfig
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: xen-devel@lists.xenproject.org,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>,
 Anthony PERARD <anthony.perard@citrix.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Julien Grall <julien@xen.org>, Juergen Gross <jgross@suse.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <1633519346-3686-1-git-send-email-olekstysh@gmail.com>
 <1633519346-3686-2-git-send-email-olekstysh@gmail.com>
 <alpine.DEB.2.21.2110061743300.3209@sstabellini-ThinkPad-T480s>
From: Oleksandr <olekstysh@gmail.com>
Message-ID: <080c8438-e24e-a557-5cbb-362e41029c4b@gmail.com>
Date: Thu, 7 Oct 2021 23:19:59 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.21.2110061743300.3209@sstabellini-ThinkPad-T480s>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US


On 07.10.21 03:49, Stefano Stabellini wrote:


Hi Stefano

> On Wed, 6 Oct 2021, Oleksandr Tyshchenko wrote:
>> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>>
>> We need to pass info about maximum supported guest physical
>> address space size to the toolstack on Arm in order to properly
>> calculate the base and size of the extended region (safe range)
>> for the guest. The extended region is unused address space which
>> could be safely used by domain for foreign/grant mappings on Arm.
>> The extended region itself will be handled by the subsequent
>> patch.
>>
>> Currently the same guest physical address space size is used
>> for all guests.
>>
>> As we add new field to the structure bump the interface version.
>>
>> Suggested-by: Julien Grall <jgrall@amazon.com>
>> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>> ---
>> Changes RFC -> V2:
>>     - update patch subject/description
>>     - replace arch-specific sub-struct with common gpaddr_bits
>>       field and update code to reflect that
>>
>> Changes V2 -> V3:
>>     - make the field uint8_t and add uint8_t pad[7] after
>>     - remove leading blanks in libxl.h
>>
>> Changes V3 -> V4:
>>     - also print gpaddr_bits from output_physinfo()
>>     - add Michal's R-b
>>
>> Changes V4 -> V5:
>>     - update patch subject and description
>>     - drop Michal's R-b
>>     - pass gpaddr_bits via createdomain domctl
>>       (struct xen_arch_domainconfig)
>> ---
>>   tools/include/libxl.h            | 5 +++++
>>   tools/libs/light/libxl_arm.c     | 2 ++
>>   tools/libs/light/libxl_types.idl | 1 +
>>   xen/arch/arm/domain.c            | 6 ++++++
>>   xen/include/public/arch-arm.h    | 5 +++++
>>   xen/include/public/domctl.h      | 2 +-
>>   6 files changed, 20 insertions(+), 1 deletion(-)
>>
>> diff --git a/tools/include/libxl.h b/tools/include/libxl.h
>> index b9ba16d..33b4bfb 100644
>> --- a/tools/include/libxl.h
>> +++ b/tools/include/libxl.h
>> @@ -279,6 +279,11 @@
>>   #define LIBXL_HAVE_BUILDINFO_ARCH_ARM_TEE 1
>>   
>>   /*
>> + * libxl_domain_build_info has the gpaddr_bits field.
>> + */
>> +#define LIBXL_HAVE_BUILDINFO_ARCH_ARM_GPADDR_BITS 1
>> +
>> +/*
>>    * LIBXL_HAVE_SOFT_RESET indicates that libxl supports performing
>>    * 'soft reset' for domains and there is 'soft_reset' shutdown reason
>>    * in enum libxl_shutdown_reason.
>> diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c
>> index e3140a6..45e0386 100644
>> --- a/tools/libs/light/libxl_arm.c
>> +++ b/tools/libs/light/libxl_arm.c
>> @@ -123,6 +123,8 @@ int libxl__arch_domain_save_config(libxl__gc *gc,
>>   
>>       state->clock_frequency = config->arch.clock_frequency;
>>   
>> +    d_config->b_info.arch_arm.gpaddr_bits = config->arch.gpaddr_bits;
>> +
>>       return 0;
>>   }
>>   
>> diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_types.idl
>> index 3f9fff6..39482db 100644
>> --- a/tools/libs/light/libxl_types.idl
>> +++ b/tools/libs/light/libxl_types.idl
>> @@ -644,6 +644,7 @@ libxl_domain_build_info = Struct("domain_build_info",[
>>   
>>       ("arch_arm", Struct(None, [("gic_version", libxl_gic_version),
>>                                  ("vuart", libxl_vuart_type),
>> +                               ("gpaddr_bits", uint8),
>>                                 ])),
>>       ("arch_x86", Struct(None, [("msr_relaxed", libxl_defbool),
>>                                 ])),
>> diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
>> index 19c756a..dfecc45 100644
>> --- a/xen/arch/arm/domain.c
>> +++ b/xen/arch/arm/domain.c
>> @@ -767,6 +767,12 @@ int arch_domain_create(struct domain *d,
>>       if ( is_hardware_domain(d) && (rc = domain_vuart_init(d)) )
>>           goto fail;
>>   
>> +    /*
>> +     * Pass maximum IPA bits to the toolstack, currently the same guest
>> +     * physical address space size is used for all guests.
>> +     */
>> +    config->arch.gpaddr_bits = p2m_ipa_bits;
> This could also be set in arch_sanitise_domain_config together with
> config->arch.gic_version. I prefer if it was done in
> arch_sanitise_domain_config but also here is OK I think.

I don't mind, being honest I had an idea to place this in 
arch_sanitise_domain_config(), but couldn't convince myself.


>
> Given that everything else looks fine:
>
> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>

Thanks!

Sadly, according to the recent discussion most likely this version is 
also no-go.


[snip]

-- 
Regards,

Oleksandr Tyshchenko



From xen-devel-bounces@lists.xenproject.org Thu Oct 07 20:23:20 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Oct 2021 20:23:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.203974.359155 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYZvC-0007X1-Tt; Thu, 07 Oct 2021 20:23:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 203974.359155; Thu, 07 Oct 2021 20:23:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYZvC-0007Wu-Qq; Thu, 07 Oct 2021 20:23:18 +0000
Received: by outflank-mailman (input) for mailman id 203974;
 Thu, 07 Oct 2021 20:23:17 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Ti8Z=O3=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1mYZvB-0007Wo-Ev
 for xen-devel@lists.xenproject.org; Thu, 07 Oct 2021 20:23:17 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 261f79be-5a4f-4d0e-b4c4-f5e8bf412e03;
 Thu, 07 Oct 2021 20:23:16 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id 7291B61139;
 Thu,  7 Oct 2021 20:23:15 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 261f79be-5a4f-4d0e-b4c4-f5e8bf412e03
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1633638195;
	bh=yEbglYJfK296Rd8sT2VsV+ykYKTi1uTQM5GSQU3qe4M=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=cVb/5nro2W8qtK79H6TKK1Dr3609r5XKlvd87yZiC2TV3LMIs+y6rmsqClyXmMb7q
	 hk5F3DShm7IxRDzRcbHDjUTlMKqlEc4HFfhmO9ozw32UbLAfzJiREDAKfxBkhQOnOg
	 k5s6mwem1eLGgy+1n4q8Bvy9mVlTogN87DtX3M9g5tjOjcmomchiFzA/sIgdg803ZQ
	 gTPY+l0O7UqWks+Yecq3CcOq4orDbl2Y+XsJ4Hrpfnndu7XMI2MFcqa+zcXPIK9zZv
	 7Hfrqip66BixB2k/QbEqj6E/szDc+FL9gstVMwgFBeQJcv081zgsNo6zp9qPJIVltb
	 tHc0JrJhrinpg==
Date: Thu, 7 Oct 2021 13:23:13 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Jan Beulich <jbeulich@suse.com>
cc: Oleksandr <olekstysh@gmail.com>, 
    Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, 
    Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>, 
    Anthony PERARD <anthony.perard@citrix.com>, 
    Andrew Cooper <andrew.cooper3@citrix.com>, 
    George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>, 
    Stefano Stabellini <sstabellini@kernel.org>, 
    Juergen Gross <jgross@suse.com>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, 
    xen-devel@lists.xenproject.org
Subject: Re: [PATCH V5 1/3] xen/arm: Introduce gpaddr_bits field to struct
 xen_arch_domainconfig
In-Reply-To: <ae852345-66ff-7bcf-f68e-2161e23933a1@suse.com>
Message-ID: <alpine.DEB.2.21.2110071311450.414@sstabellini-ThinkPad-T480s>
References: <1633519346-3686-1-git-send-email-olekstysh@gmail.com> <1633519346-3686-2-git-send-email-olekstysh@gmail.com> <68cb29bb-7d84-dc27-eead-4a079b9caf68@suse.com> <e77eea6f-163d-0920-2e90-fb9f3a602743@gmail.com> <ffb40f3b-2394-7747-2c06-955e2aa87cfc@suse.com>
 <387608b9-c7b2-e814-7fa5-a262acc0c73d@gmail.com> <ae852345-66ff-7bcf-f68e-2161e23933a1@suse.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Thu, 7 Oct 2021, Jan Beulich wrote:
> On 07.10.2021 15:12, Oleksandr wrote:
> > 
> > On 07.10.21 15:43, Jan Beulich wrote:
> > 
> > Hi Jan.
> > 
> >> On 07.10.2021 14:30, Oleksandr wrote:
> >>> On 07.10.21 10:42, Jan Beulich wrote:
> >>>> On 06.10.2021 13:22, Oleksandr Tyshchenko wrote:
> >>>>> Changes V4 -> V5:
> >>>>>      - update patch subject and description
> >>>>>      - drop Michal's R-b
> >>>>>      - pass gpaddr_bits via createdomain domctl
> >>>>>        (struct xen_arch_domainconfig)
> >>>> I'm afraid I can't bring this in line with ...
> >>>>
> >>>>> --- a/xen/include/public/arch-arm.h
> >>>>> +++ b/xen/include/public/arch-arm.h
> >>>>> @@ -333,6 +333,11 @@ struct xen_arch_domainconfig {
> >>>>>         *
> >>>>>         */
> >>>>>        uint32_t clock_frequency;
> >>>>> +    /*
> >>>>> +     * OUT
> >>>>> +     * Guest physical address space size
> >>>>> +     */
> >>>>> +    uint8_t gpaddr_bits;
> >>>> ... this being an OUT field. Is this really what Andrew had asked for?
> >>>> I would have expected the entire struct to be IN (and the comment at
> >>>> the top of the containing struct in public/domctl.h also suggests so,
> >>>> i.e. your new field renders that comment stale). gic_version being
> >>>> IN/OUT is already somewhat in conflict ...
> >>> I am sorry but I'm totally confused now, we want the Xen to provide
> >>> gpaddr_bits to the toolstack, but not the other way around.
> >>> As I understand the main ask was to switch to domctl for which I wanted
> >>> to get some clarification on how it would look like... Well, this patch
> >>> switches to use
> >>> domctl, and I think exactly as it was suggested at [1] in case if a
> >>> common one is a difficult to achieve. I have to admit, I felt it was
> >>> indeed difficult to achieve.
> >> Sadly the mail you reference isn't the one I was referring to. It's not
> >> even from Andrew. Unfortunately I also can't seem to be able to locate
> >> this, i.e. I'm now wondering whether this was under a different subject.
> >> Julien, in any event, confirmed in a recent reply on this thread that
> >> there was such a mail (otherwise I would have started wondering whether
> >> the request was made on irc). In any case it is _that_ mail that would
> >> need going through again.
> > 
> > I think, this is the email [1] you are referring to.
> 
> Well, that's still a mail you sent, not Andrew's. And while I have yours
> in my mailbox, I don't have Andrew's for whatever reason.
> 
> Nevertheless there's enough context to be halfway certain that this
> wasn't meant as an extension to the create domctl, but rather a separate
> new one (merely replacing what you had originally as a sysctl to become
> per-domain, to allow returning varying [between domains] values down the
> road). I continue to think that if such a field was added to "create",
> it would be an input (only).

During the Xen Community Call on Tuesday, we briefly spoke about this.
Andrew confirmed that what he meant with his original email is to use a
domctl. We didn't discuss which domctl specifically.

This patch now follows the same pattern of clock_frequency and
gic_version (see xen/include/public/arch-arm.h:struct xen_arch_domainconfig).
Note that gic_version is an IN/OUT parameter, showing that if in the
future we want the ability to set gpaddr_bits (in addition to get
gpaddr_bits), it will be possible.

Also it is good to keep in mind that although nobody likes to change
hypercall interfaces, especially for minor reasons, domctl are not
stable so we can be a little bit more relaxed compared to something like
grant_table_op.


From xen-devel-bounces@lists.xenproject.org Thu Oct 07 20:29:22 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Oct 2021 20:29:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.203983.359167 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYa0q-0008Hy-Ij; Thu, 07 Oct 2021 20:29:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 203983.359167; Thu, 07 Oct 2021 20:29:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYa0q-0008Hr-Fi; Thu, 07 Oct 2021 20:29:08 +0000
Received: by outflank-mailman (input) for mailman id 203983;
 Thu, 07 Oct 2021 20:29:06 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=4W4d=O3=gmail.com=olekstysh@srs-us1.protection.inumbo.net>)
 id 1mYa0o-0008Hl-NV
 for xen-devel@lists.xenproject.org; Thu, 07 Oct 2021 20:29:06 +0000
Received: from mail-ed1-x530.google.com (unknown [2a00:1450:4864:20::530])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 3b0ee69c-3f37-4269-8764-ff5088f10fca;
 Thu, 07 Oct 2021 20:29:05 +0000 (UTC)
Received: by mail-ed1-x530.google.com with SMTP id d3so377548edp.3
 for <xen-devel@lists.xenproject.org>; Thu, 07 Oct 2021 13:29:05 -0700 (PDT)
Received: from [192.168.1.7] ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id o3sm152710ejg.52.2021.10.07.13.29.04
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Thu, 07 Oct 2021 13:29:04 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3b0ee69c-3f37-4269-8764-ff5088f10fca
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-transfer-encoding:content-language;
        bh=VPtIgk2ssf+ZyoZcz++Pw78Q15/HMzgN9246Wli/t84=;
        b=YRrxeZW624MuXI+0UCaz8/VFf1nb/dR2avls1WwRrVUPbqyonZVo+bYsvX582feqDr
         1mMYyXNnSVrxa0ii9qIu0jMNzuPRI79LEYdZZZi7+E+Pi+QVDHMw/6nFjAvXp6lVWk7c
         cGNtvzRoHaRaiDWhm4PW/+/WKXkGg1QvrIkwL6NMrHMgA0K9XpO3ESwADhytMu+/v/E5
         3DF6m5pSWK6TOQ8gRd+UJUZjFVNER38HTsnqdkd/uPUIPKSFszku3rxrMzyQLG2+jHgs
         4fQeLOenmWsjsuseurC9SSFI2EJCHQ3PysL3BWlw1Cq+2sAMU/riFGX9iXpBH71lB8Q+
         h8RA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding
         :content-language;
        bh=VPtIgk2ssf+ZyoZcz++Pw78Q15/HMzgN9246Wli/t84=;
        b=iqQNZaCtK806wZ4e6qjOzYZq4QFrTlFwfi2Kv6Q46dOh7H3Ye6fGbXKyDUVuIGDP0f
         t9IGM4Of6r9qw+H8QdtZeOv6SqSjTkQICvNLGwUlbA6tCkgkZwZmlEv90W26EWg72D89
         QDP1blyxbYdjJn9SgUlRbWB91M56xvvogRCoZ0HI4YQ65GGpv2wN9ucf8mEd+jPqRHy/
         VJGRH0dLx2jvfDoY9i/cwfsCRunIDEGBNoW2P/KuATJephU7wz8QTt+HmfW2Im30Mvaz
         WpIB1BVsYH8Wis+z8Git43oW3mUZJ3GaKRGQeQTwEApuICBImwzItrWd1Z8pOVkD68ec
         lrZQ==
X-Gm-Message-State: AOAM532i+5+sglVBNFb7IR37YIvnDm4ddlKcOkcU7fj0dlsV2CY7F6PY
	rDmUJRM67qL+LGIPgSg/ZaE=
X-Google-Smtp-Source: ABdhPJymTylFPY1AoUZvRK0ug5RXMqwRN1QgAZ40EsU5jjSIs7/6cAW0xEuoJLYGPHholpqUl0zSXQ==
X-Received: by 2002:a17:906:bc43:: with SMTP id s3mr8291119ejv.46.1633638544869;
        Thu, 07 Oct 2021 13:29:04 -0700 (PDT)
Subject: Re: [PATCH V5 3/3] xen/arm: Updates for extended regions support
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: xen-devel@lists.xenproject.org,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Julien Grall <julien@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <1633519346-3686-1-git-send-email-olekstysh@gmail.com>
 <1633519346-3686-4-git-send-email-olekstysh@gmail.com>
 <alpine.DEB.2.21.2110061843360.3209@sstabellini-ThinkPad-T480s>
 <a5a81348-4b18-6be6-ba85-4c31172459dc@gmail.com>
 <alpine.DEB.2.21.2110071300380.414@sstabellini-ThinkPad-T480s>
From: Oleksandr <olekstysh@gmail.com>
Message-ID: <ff6800b3-74f0-3203-6465-1547644924e2@gmail.com>
Date: Thu, 7 Oct 2021 23:29:03 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.21.2110071300380.414@sstabellini-ThinkPad-T480s>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US


On 07.10.21 23:06, Stefano Stabellini wrote:

Hi Stefano

> On Thu, 7 Oct 2021, Oleksandr wrote:
>> On 07.10.21 04:50, Stefano Stabellini wrote:
>>
>> Hi Stefano
>>
>>> On Wed, 6 Oct 2021, Oleksandr Tyshchenko wrote:
>>>> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>>>>
>>>> This is a follow-up of
>>>> "b6fe410 xen/arm: Add handling of extended regions for Dom0"
>>>>
>>>> Add various in-code comments, update Xen hypervisor device tree
>>>> bindings text, change the log level for some prints and clarify
>>>> format specifier, reuse dt_for_each_range() to avoid open-coding
>>>> in find_memory_holes().
>>>>
>>>> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>>> Thanks for the patch, it looks like you addressed all Julien's comments
>>> well.
>> I believe so)
>
> [...]
>
>>>> @@ -1193,8 +1215,8 @@ static int __init make_hypervisor_node(struct domain
>>>> *d,
>>>>            u64 start = ext_regions->bank[i].start;
>>>>            u64 size = ext_regions->bank[i].size;
>>>>    -        dt_dprintk("Extended region %d: %#"PRIx64"->%#"PRIx64"\n",
>>>> -                   i, start, start + size);
>>>> +        printk("Extended region %d: %#"PRIx64"->%#"PRIx64"\n",
>>>> +               i, start, start + size);
>>> Also should be PRIpaddr
>> I thought I needed to change specifier only for variables of type "paddr_t",
>> but here "u64".
> Sorry, you are right.
>
> I added my reviewed-by and made the small typo changes on commit.

Thanks! In case if you haven't committed the patch yet, let's please 
wait for Julien (who asked for this follow-up) to review it.

In any case, I will be able to do another follow-up if needed.


-- 
Regards,

Oleksandr Tyshchenko



From xen-devel-bounces@lists.xenproject.org Thu Oct 07 20:29:33 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Oct 2021 20:29:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.203987.359178 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYa1F-0000Kd-RP; Thu, 07 Oct 2021 20:29:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 203987.359178; Thu, 07 Oct 2021 20:29:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYa1F-0000KW-ON; Thu, 07 Oct 2021 20:29:33 +0000
Received: by outflank-mailman (input) for mailman id 203987;
 Thu, 07 Oct 2021 20:29:32 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Ti8Z=O3=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1mYa1E-0000KG-4O
 for xen-devel@lists.xenproject.org; Thu, 07 Oct 2021 20:29:32 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 4642fe60-27ad-11ec-bffe-12813bfff9fa;
 Thu, 07 Oct 2021 20:29:30 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id 9451D60E9B;
 Thu,  7 Oct 2021 20:29:29 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4642fe60-27ad-11ec-bffe-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1633638570;
	bh=SP/aVU7N1bYm0SQFPaqlpEYaMMfb/rN8YYdpgwRRJH8=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=pw1N26NxqdyBuyr4Lh6rqQagN2DnE6Amuz0YBtSDazjB8EjYURBmcuN59IpO+cbGd
	 SsXE1pbvzqf18QRdrFGzaEhYqabcjwbWIe9XqESDb+VUyRtso1o/+8KRcN5VJTZRbx
	 OHCDhdR/ClkEWDEVogauu0gu6zGlL79c6ajmVPXDiVBb0SoGPSw/ar9jbxEGUY1c9c
	 dtukUYz/RUD9ZWfMNg36MI/je/m6rGh2HZ3BDEStvRSnFqS3d8VCGudNFq2UnGfMzI
	 1xIR/LrdsMw2IuxDEG7HsH/Ke/oLllJjfR5jrSV9u1UtgdFpbH26MfHr+evITnEPJn
	 7HIkT+qTd9Ycw==
Date: Thu, 7 Oct 2021 13:29:28 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Oleksandr <olekstysh@gmail.com>
cc: Stefano Stabellini <sstabellini@kernel.org>, 
    xen-devel@lists.xenproject.org, 
    Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, 
    Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>, 
    Anthony PERARD <anthony.perard@citrix.com>, 
    Juergen Gross <jgross@suse.com>, Julien Grall <julien@xen.org>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH V5 2/3] libxl/arm: Add handling of extended regions for
 DomU
In-Reply-To: <9a4fb8be-e893-bd7f-fe77-7274457e2b04@gmail.com>
Message-ID: <alpine.DEB.2.21.2110071327520.414@sstabellini-ThinkPad-T480s>
References: <1633519346-3686-1-git-send-email-olekstysh@gmail.com> <1633519346-3686-3-git-send-email-olekstysh@gmail.com> <alpine.DEB.2.21.2110061808570.3209@sstabellini-ThinkPad-T480s> <9a4fb8be-e893-bd7f-fe77-7274457e2b04@gmail.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="8323329-942583794-1633638569=:414"

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-942583794-1633638569=:414
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT

On Thu, 7 Oct 2021, Oleksandr wrote:
> On 07.10.21 04:29, Stefano Stabellini wrote:
> 
> Hi Stefano
> 
> > On Wed, 6 Oct 2021, Oleksandr Tyshchenko wrote:
> > > From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> > > 
> > > The extended region (safe range) is a region of guest physical
> > > address space which is unused and could be safely used to create
> > > grant/foreign mappings instead of wasting real RAM pages from
> > > the domain memory for establishing these mappings.
> > > 
> > > The extended regions are chosen at the domain creation time and
> > > advertised to it via "reg" property under hypervisor node in
> > > the guest device-tree. As region 0 is reserved for grant table
> > > space (always present), the indexes for extended regions are 1...N.
> > > If extended regions could not be allocated for some reason,
> > > Xen doesn't fail and behaves as usual, so only inserts region 0.
> > > 
> > > Please note the following limitations:
> > > - The extended region feature is only supported for 64-bit domain
> > >    currently.
> > > - The ACPI case is not covered.
> > > 
> > > ***
> > > 
> > > The algorithm to choose extended regions for non-direct mapped
> > > DomU is simpler in comparison with the algorithm for direct mapped
> > > Dom0. We usually have a lot of unused space above 4GB, and might
> > > have some unused space below 4GB (depends on guest memory size).
> > > Try to allocate separate 2MB-aligned extended regions from the first
> > > (below 4GB) and second (above 4GB) RAM banks taking into the account
> > > the maximum supported guest physical address space size and the amount
> > > of memory assigned to the guest. The minimum size of extended region
> > > the same as for Dom0 (64MB).
> > > 
> > > Suggested-by: Julien Grall <jgrall@amazon.com>
> > > Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> > > ---
> > > ! Stefano, Ian, Michal I dropped your A-b/R-b. I decided to change patch
> > > to make it more functional !
> > > 
> > > Changes RFC -> V2:
> > >     - update patch description
> > >     - drop uneeded "extended-region" DT property
> > >     - clear reg array in finalise_ext_region() and add a TODO
> > > 
> > > Changes V2 -> V3:
> > >     - update patch description, comments in code
> > >     - only pick up regions with size >= 64MB
> > >     - move the region calculation to make_hypervisor_node() and drop
> > >       finalise_ext_region()
> > >     - extend the list of arguments for make_hypervisor_node()
> > >     - do not show warning for 32-bit domain
> > >     - change the region alignment from 1GB to 2MB
> > >     - move EXT_REGION_SIZE to public/arch-arm.h
> > > 
> > > Changes V3 -> V4:
> > >     - add R-b, A-b and T-b
> > > 
> > > Changes V4 -> V5:
> > >     - update patch description and comments in code
> > >     - reflect changes done in previous patch to pass gpaddr_bits
> > >       via createdomain domctl (struct xen_arch_domainconfig)
> > >     - drop R-b, A-b and T-b
> > >     - drop limit for maximum extended region size (128GB)
> > >     - try to also allocate region below 4GB, optimize code
> > >       for calculating extended regions
> > > ---
> > >   tools/libs/light/libxl_arm.c  | 80
> > > ++++++++++++++++++++++++++++++++++++++++---
> > >   xen/include/public/arch-arm.h |  2 ++
> > >   2 files changed, 77 insertions(+), 5 deletions(-)
> > > 
> > > diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c
> > > index 45e0386..cd743f7 100644
> > > --- a/tools/libs/light/libxl_arm.c
> > > +++ b/tools/libs/light/libxl_arm.c
> > > @@ -600,9 +600,21 @@ static int make_timer_node(libxl__gc *gc, void *fdt,
> > >       return 0;
> > >   }
> > >   +#define ALIGN_UP_TO_2MB(x)   (((x) + MB(2) - 1) & (~(MB(2) - 1)))
> > > +
> > >   static int make_hypervisor_node(libxl__gc *gc, void *fdt,
> > > -                                const libxl_version_info *vers)
> > > +                                const libxl_version_info *vers,
> > > +                                const libxl_domain_build_info *b_info,
> > > +                                const struct xc_dom_image *dom)
> > >   {
> > > +    uint64_t region_size[GUEST_RAM_BANKS] = {0},
> > > region_base[GUEST_RAM_BANKS],
> > > +        banksize[GUEST_RAM_BANKS], bankend[GUEST_RAM_BANKS], ramsize;
> > > +    uint32_t regs[(GUEST_ROOT_ADDRESS_CELLS + GUEST_ROOT_SIZE_CELLS) *
> > > +                  (GUEST_RAM_BANKS + 1)];
> > > +    be32 *cells = &regs[0];
> > > +    const uint64_t bankbase[] = GUEST_RAM_BANK_BASES;
> > > +    unsigned int i, len, nr_regions = 0;
> > > +    uint8_t gpaddr_bits;
> > >       int res;
> > >       gic_interrupt intr;
> > >   @@ -617,9 +629,67 @@ static int make_hypervisor_node(libxl__gc *gc, void
> > > *fdt,
> > >                                 "xen,xen");
> > >       if (res) return res;
> > >   -    /* reg 0 is grant table space */
> > > -    res = fdt_property_regs(gc, fdt, GUEST_ROOT_ADDRESS_CELLS,
> > > GUEST_ROOT_SIZE_CELLS,
> > > -                            1,GUEST_GNTTAB_BASE, GUEST_GNTTAB_SIZE);
> > > +    if (strcmp(dom->guest_type, "xen-3.0-aarch64")) {
> > > +        LOG(WARN, "The extended regions are only supported for 64-bit
> > > guest currently");
> > > +        goto out;
> > > +    }
> > > +
> > > +    gpaddr_bits = b_info->arch_arm.gpaddr_bits;
> > > +    assert(gpaddr_bits >= 32 && gpaddr_bits <= 48);
> > > +
> > > +    /*
> > > +     * Try to allocate separate 2MB-aligned extended regions from the
> > > first
> > > +     * (below 4GB) and second (above 4GB) RAM banks taking into the
> > > account
> > > +     * the maximum supported guest physical address space size and the
> > > amount
> > > +     * of memory assigned to the guest.
> > > +     * As the guest memory layout is not populated yet we cannot rely on
> > > +     * dom->rambank_size[], so calculate the actual size of both banks
> > > using
> > > +     * "max_memkb" value.
> > > +     */
> > > +    ramsize = b_info->max_memkb * 1024;
> > > +    if (ramsize <= GUEST_RAM0_SIZE) {
> > > +        banksize[0] = ramsize;
> > > +        banksize[1] = 0;
> > > +    } else {
> > > +        banksize[0] = GUEST_RAM0_SIZE;
> > > +        banksize[1] = ramsize - GUEST_RAM0_SIZE;
> > > +    }
> > > +
> > > +    bankend[0] = GUEST_RAM0_BASE + GUEST_RAM0_SIZE;
> > > +    bankend[1] = min(1ULL << gpaddr_bits, GUEST_RAM1_BASE +
> > > GUEST_RAM1_SIZE);
> > > +
> > > +    for (i = 0; i < GUEST_RAM_BANKS; i++) {
> > > +        region_base[i] = bankbase[i] + ALIGN_UP_TO_2MB(banksize[i]);
> > > +        if (bankend[i] > region_base[i])
> > > +            region_size[i] = bankend[i] - region_base[i];
> > > +    }
> > This seems correct but it looks a bit overkill. I would have written
> > like this:
> > 
> >      if (ramsize <= GUEST_RAM0_SIZE) {
> >          region_base[0] = GUEST_RAM0_BASE + ALIGN_UP_TO_2MB(ramsize);
> >          region_size[0] = GUEST_RAM0_SIZE - ALIGN_UP_TO_2MB(ramsize);
> >          region_base[1] = GUEST_RAM1_BASE;
> >          region_size[1] = min(1ULL << gpaddr_bits, GUEST_RAM1_BASE +
> > GUEST_RAM1_SIZE) -
> >                           region_base[0];
> Why  "- region_base[0]" in last expression? I think it should be "-
> region_base[1]", the same as for "else" case (so it can be moved out of
> if-else construct). Also we need to check
> 
> that min(1ULL << gpaddr_bits, GUEST_RAM1_BASE + GUEST_RAM1_SIZE) is greater
> than region_base[1] before the subtraction. If gpaddr_bits = 32 (on Arm64) we
> will get incorrect result.
> 
> 
> >      } else {
> >          region_size[0] = 0;
> >          region_base[1] = GUEST_RAM1_BASE + ALIGN_UP_TO_2MB(ramsize -
> > GUEST_RAM0_SIZE);
> >          region_size[1] = min(1ULL << gpaddr_bits, GUEST_RAM1_BASE +
> > GUEST_RAM1_SIZE) -
> >                           region_base[1];
> >      }
> > 
> > Which removes the needs for banksize, bankend, bankbase. What do you
> > think? Your version works too, so I am OK anyway.
> Thank you for looking into this.
> 
> I think, you version will also work with adjustments. I am OK either way. Your
> version reduces the number of locals, so probably better.  Although "min(1ULL
> << gpaddr_bits, GUEST_RAM1_BASE + GUEST_RAM1_SIZE)" construction probably
> wants latching in local bank1end.
> 
> 
> Below the updated version:
> 
>     if (ramsize <= GUEST_RAM0_SIZE) {
>         region_base[0] = GUEST_RAM0_BASE + ALIGN_UP_TO_2MB(ramsize);
>         region_size[0] = GUEST_RAM0_SIZE - ALIGN_UP_TO_2MB(ramsize);
>         region_base[1] = GUEST_RAM1_BASE;
>     } else
>         region_base[1] = GUEST_RAM1_BASE + ALIGN_UP_TO_2MB(ramsize - GUEST_RAM0_SIZE);
> 
>     bank1end = min(1ULL << gpaddr_bits, GUEST_RAM1_BASE + GUEST_RAM1_SIZE);
>     if (bank1end > region_base[1])
>         region_size[1] = bank1end - region_base[1];


Yeah I like this. I'd be happy to go with it.
--8323329-942583794-1633638569=:414--


From xen-devel-bounces@lists.xenproject.org Thu Oct 07 20:37:57 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Oct 2021 20:37:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.204000.359189 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYa9F-000205-R3; Thu, 07 Oct 2021 20:37:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 204000.359189; Thu, 07 Oct 2021 20:37:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYa9F-0001zy-Nq; Thu, 07 Oct 2021 20:37:49 +0000
Received: by outflank-mailman (input) for mailman id 204000;
 Thu, 07 Oct 2021 20:37:48 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Ti8Z=O3=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1mYa9E-0001zs-Gg
 for xen-devel@lists.xenproject.org; Thu, 07 Oct 2021 20:37:48 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 1a90b1bd-0add-4bb7-8393-b59f181f01cd;
 Thu, 07 Oct 2021 20:37:47 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id 975386101A;
 Thu,  7 Oct 2021 20:37:46 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1a90b1bd-0add-4bb7-8393-b59f181f01cd
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1633639066;
	bh=EzxjQmub+Cy2Zb/325VconhPfMxBJBKClTF6dAA5Xe4=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=NcmZCYGrI9pOb29SWhQEQ5CnL854rD59vX3erffRoJqkIaB81HDrwd8f9kjx/g2Qe
	 QvY6LzMcH9XcMq0LGn8jZsoAVKJn597W3VaM2VjnWpJcXTcHcBudUi/9apYlJTT1t7
	 SA/MEuQViuntpIuSy51jaAshRyOpMmCuC4qG5NQDGUJBqT6FN4kAvWLx3VfhoQnrrK
	 UbSHx8jXiOOUhbwUDJCwpGngBWnXIo3u/dMGM38Eu/0rvydEsBtcmcH0KWCgaIWmVR
	 V9iSVj3OP6KQ+orJ/F5Zu/xW/QdmmU2kyESfNLk1RZGyift/MBlbD4Cl90q6lBumeg
	 LnQCqZ0sjJBUA==
Date: Thu, 7 Oct 2021 13:37:44 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Ian Jackson <iwj@xenproject.org>
cc: Stefano Stabellini <sstabellini@kernel.org>, 
    Oleksandr <olekstysh@gmail.com>, xen-devel@lists.xenproject.org, 
    Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, Wei Liu <wl@xen.org>, 
    Anthony PERARD <anthony.perard@citrix.com>, 
    Juergen Gross <jgross@suse.com>, Julien Grall <julien@xen.org>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH V5 2/3] libxl/arm: Add handling of extended regions for
 DomU
In-Reply-To: <24926.53922.628049.481827@mariner.uk.xensource.com>
Message-ID: <alpine.DEB.2.21.2110071329380.414@sstabellini-ThinkPad-T480s>
References: <1633519346-3686-1-git-send-email-olekstysh@gmail.com> <1633519346-3686-3-git-send-email-olekstysh@gmail.com> <24925.35278.762786.539238@mariner.uk.xensource.com> <224ed316-aac0-3ad4-22a1-efc592e717e2@gmail.com> <alpine.DEB.2.21.2110061658450.3209@sstabellini-ThinkPad-T480s>
 <24926.53922.628049.481827@mariner.uk.xensource.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Thu, 7 Oct 2021, Ian Jackson wrote:
> Stefano Stabellini writes ("Re: [PATCH V5 2/3] libxl/arm: Add handling of extended regions for DomU"):
> > On Wed, 6 Oct 2021, Oleksandr wrote:
> > > On 06.10.21 14:34, Ian Jackson wrote:
> > > > Oleksandr Tyshchenko writes ("[PATCH V5 2/3] libxl/arm: Add handling of
> > > > extended regions for DomU"):
> > > > > The extended region (safe range) is a region of guest physical
> > > > > address space which is unused and could be safely used to create
> > > > > grant/foreign mappings instead of wasting real RAM pages from
> > > > > the domain memory for establishing these mappings.
> > > > Please forgive me for asking this question now, but: why is this
> > > > ARM-specific ?
> > > 
> > > 
> > > Sorry, I can't say for sure which x86 mode also suffers from
> > > that. I might be wrong, but as I understand that x86 in PVH (and
> > > HVM?) mode uses unpopulated memory ranges (which are unused from
> > > Linux PoV, actually everything not yet allocated or reserved from
> > > "iomem_resource") to create foreign/grant mappings.  So the real
> > > RAM pages are not ballooned out to get an physical address space
> > > to create these mappings. The problem is that we cannot follow
> > > Linux advise which memory ranges are unused on Arm for several
> > > reasons, this is why this patch series makes the hypervisor to
> > > start allocating and exposing these ranges.
> 
> So it sounds like you are saying this is an ARM-specific problem ?
> The key being the "several reasons" which you mention.  Are they
> ARM-specifc problems.
> 
> > Two more things about this being ARM-specific.
> > 
> > Even if x86 was affected exactly by the same problem, the code to expose
> > the safe memory ranges to DomU is arch-specific (currently device tree.)
> > 
> > Also the code to calculate the safe memory ranges is arch-specific as it
> > depends on the DomU memory layout which is arch-specific.
> 
> This demonstrates that the implementation is arch-specific.  But one
> of libxl's functions is to abstract away implementation details and
> provide an interface that can be used to "do the right thing".

That's fair enough, I understand your question a bit better now.

I am not certain whether x86 has the same issue. But if it does, I am
pretty sure both the strategy to address the problem and the code would
be very different. At the moment, I cannot imagine how we could share
anything in this patch with x86, especially given the difference in
firmware interfaces (ACPI vs DT).

But I could see a theoretical third architecture (RISC-V?) with device
tree support potentially making use of make_hypervisor_node. But then at
the libxl API I don't imagine the API would look different or would need
to change.


From xen-devel-bounces@lists.xenproject.org Thu Oct 07 20:42:22 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Oct 2021 20:42:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.204007.359199 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYaDd-0003Np-Bn; Thu, 07 Oct 2021 20:42:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 204007.359199; Thu, 07 Oct 2021 20:42:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYaDd-0003Ni-8z; Thu, 07 Oct 2021 20:42:21 +0000
Received: by outflank-mailman (input) for mailman id 204007;
 Thu, 07 Oct 2021 20:42:20 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Ti8Z=O3=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1mYaDb-0003Nb-UA
 for xen-devel@lists.xenproject.org; Thu, 07 Oct 2021 20:42:19 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 10254746-27af-11ec-8000-12813bfff9fa;
 Thu, 07 Oct 2021 20:42:18 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id 072D76101E;
 Thu,  7 Oct 2021 20:42:17 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 10254746-27af-11ec-8000-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1633639338;
	bh=Aoksu8Zz7vmyFYlMhas1DZZ+gfNcIDpqgf688zBV9D8=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=FJvggSgKn90XoZcVrExOh38ztE6IDydDopvfHtHM7I3n364rIjKS/0/8859McIgLB
	 +nNg4D/IWcL8ni5i4QqcIM3NpAlU2gEph8fFCqzk575CbIy3d8halCk9hQGGl3uxZw
	 buYOvUSaEUsolRLPs+EK5+T6Omr5TZx+HY4dn8fbucthZkBk7kuyBNCLuLIBG1wU56
	 KA4pmjk94r7BT0aP0M0dGdeexsKe+TNVjL233+/LfnObp/YzHM2m2B6zv5uBHVhbsw
	 5ble2whfVtEYcbM1J2JAlo5FoK3j72Cx3BXYnH1hza5fSNh758qKcc3uDk9cPBaHN7
	 oxqu7QFP+U31Q==
Date: Thu, 7 Oct 2021 13:42:16 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Oleksandr <olekstysh@gmail.com>
cc: Stefano Stabellini <sstabellini@kernel.org>, 
    xen-devel@lists.xenproject.org, 
    Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, 
    Julien Grall <julien@xen.org>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH V5 3/3] xen/arm: Updates for extended regions support
In-Reply-To: <ff6800b3-74f0-3203-6465-1547644924e2@gmail.com>
Message-ID: <alpine.DEB.2.21.2110071337550.414@sstabellini-ThinkPad-T480s>
References: <1633519346-3686-1-git-send-email-olekstysh@gmail.com> <1633519346-3686-4-git-send-email-olekstysh@gmail.com> <alpine.DEB.2.21.2110061843360.3209@sstabellini-ThinkPad-T480s> <a5a81348-4b18-6be6-ba85-4c31172459dc@gmail.com>
 <alpine.DEB.2.21.2110071300380.414@sstabellini-ThinkPad-T480s> <ff6800b3-74f0-3203-6465-1547644924e2@gmail.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Thu, 7 Oct 2021, Oleksandr wrote:
> On 07.10.21 23:06, Stefano Stabellini wrote:
> > On Thu, 7 Oct 2021, Oleksandr wrote:
> > > On 07.10.21 04:50, Stefano Stabellini wrote:
> > > 
> > > Hi Stefano
> > > 
> > > > On Wed, 6 Oct 2021, Oleksandr Tyshchenko wrote:
> > > > > From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> > > > > 
> > > > > This is a follow-up of
> > > > > "b6fe410 xen/arm: Add handling of extended regions for Dom0"
> > > > > 
> > > > > Add various in-code comments, update Xen hypervisor device tree
> > > > > bindings text, change the log level for some prints and clarify
> > > > > format specifier, reuse dt_for_each_range() to avoid open-coding
> > > > > in find_memory_holes().
> > > > > 
> > > > > Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> > > > Thanks for the patch, it looks like you addressed all Julien's comments
> > > > well.
> > > I believe so)
> > 
> > [...]
> > 
> > > > > @@ -1193,8 +1215,8 @@ static int __init make_hypervisor_node(struct
> > > > > domain
> > > > > *d,
> > > > >            u64 start = ext_regions->bank[i].start;
> > > > >            u64 size = ext_regions->bank[i].size;
> > > > >    -        dt_dprintk("Extended region %d: %#"PRIx64"->%#"PRIx64"\n",
> > > > > -                   i, start, start + size);
> > > > > +        printk("Extended region %d: %#"PRIx64"->%#"PRIx64"\n",
> > > > > +               i, start, start + size);
> > > > Also should be PRIpaddr
> > > I thought I needed to change specifier only for variables of type
> > > "paddr_t",
> > > but here "u64".
> > Sorry, you are right.
> > 
> > I added my reviewed-by and made the small typo changes on commit.
> 
> Thanks! In case if you haven't committed the patch yet, let's please wait for
> Julien (who asked for this follow-up) to review it.
> 
> In any case, I will be able to do another follow-up if needed.
 
I committed it as I would like to squeeze as many runs out of OSSTest
and Gitlab-CI as possible as we are getting closer and closer to the
release. I am trying to avoid the last minute rush to commit 150 patches
one day before code freeze :-)

The more intermediate runs we get, the easier is to pinpoint (and fix)
regressions.

But also, this patch doesn't affect external interfances, it is just
internal and mostly comments, so it is super-easy to do follow-ups.


From xen-devel-bounces@lists.xenproject.org Thu Oct 07 20:55:33 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Oct 2021 20:55:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.204014.359211 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYaQJ-0004vs-IL; Thu, 07 Oct 2021 20:55:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 204014.359211; Thu, 07 Oct 2021 20:55:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYaQJ-0004vl-FI; Thu, 07 Oct 2021 20:55:27 +0000
Received: by outflank-mailman (input) for mailman id 204014;
 Thu, 07 Oct 2021 20:55:26 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=4W4d=O3=gmail.com=olekstysh@srs-us1.protection.inumbo.net>)
 id 1mYaQI-0004vM-93
 for xen-devel@lists.xenproject.org; Thu, 07 Oct 2021 20:55:26 +0000
Received: from mail-ed1-x52d.google.com (unknown [2a00:1450:4864:20::52d])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id a416a85e-feb3-4abe-b490-554e7114e3b1;
 Thu, 07 Oct 2021 20:55:24 +0000 (UTC)
Received: by mail-ed1-x52d.google.com with SMTP id a25so12223303edx.8
 for <xen-devel@lists.xenproject.org>; Thu, 07 Oct 2021 13:55:24 -0700 (PDT)
Received: from [192.168.1.7] ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id f25sm171986ejb.34.2021.10.07.13.55.21
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Thu, 07 Oct 2021 13:55:22 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a416a85e-feb3-4abe-b490-554e7114e3b1
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-transfer-encoding:content-language;
        bh=nA4xCXkfVXNEXjfpLRR7owsHwcLnqWVVz9rx9223EFQ=;
        b=GOie1uJ/ijfJ3Us4qjIYZ+DEaE6/aH1gQ4de023dR0oldF4UNoEHRDb2mf07vqQcRW
         DvWIvKu9m2NP2dFipgR1jB0j01xbgIFsVvowu8pleJJNrYu3Dr9Hn3zMCqLFplmy7Lh7
         XoTHvFax156p2wGq2V4tQrV2W1cWCaVAi/kITIYhGtHLC7MbkmvT5Arb1AQeS1Yt3tE2
         8W6PRWXQuB50aB1QZzpPEPYg+A/UoSOhR+cyXlQ3+5UBvGUMvkBikkwCEX5ZuRPPJeko
         iqn3+M5SoU7gSYJvSInXNlQ0udP3QfntvLs+5OaMJcVd3DavhzKuAtFdLNPYg8MbMESa
         73rQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding
         :content-language;
        bh=nA4xCXkfVXNEXjfpLRR7owsHwcLnqWVVz9rx9223EFQ=;
        b=rOO3IDRuj6CLeD/cP+HTbC0bck9C1w2vlk5ebV3HvHIxi3rNOC4z5h2qrCkQcyUnHB
         5leWtbqD2oKIj8XZr/zjr8+vd3SvgvHzS37OlFSgZ3pukRHRRBkvkt+kQ3dgXRQp7+cQ
         Eb76f4U2SW6A4dZdo9h5P3FdOuwbfp7VxJzy5CMtyMSe2tUZ89kFrooULA+VI+p6EtVF
         fx/jg6Tf8oBw5EFaw0HloZlXGQaGpIIqChWQI/byEnlXh5YswiSibJO/FdZnRUGF7Tyi
         uyA0TSlPsK3r92JkxkW87jSBMZXQ+CQ9Vo0ECvNdyV1whfAySPUAyixivmeMyPcLf7Zu
         VEFQ==
X-Gm-Message-State: AOAM531J0+2QZVpBLeAyYz7mXlWEpMU3jsN7+rbRxYTSIJOIUHRm32Hm
	0EQke8nEmBFSqbiXcmG5x/A=
X-Google-Smtp-Source: ABdhPJyE3bxpkpQM6c6Tl7+8Jies2bPcxaT8FIkpSJwJyqMhNycOdIm+Aq+TaI4Jvra0aJpKLryIpw==
X-Received: by 2002:a05:6402:358c:: with SMTP id y12mr9022061edc.159.1633640122958;
        Thu, 07 Oct 2021 13:55:22 -0700 (PDT)
Subject: Re: [PATCH V5 2/3] libxl/arm: Add handling of extended regions for
 DomU
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: xen-devel@lists.xenproject.org,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>,
 Anthony PERARD <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>,
 Julien Grall <julien@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <1633519346-3686-1-git-send-email-olekstysh@gmail.com>
 <1633519346-3686-3-git-send-email-olekstysh@gmail.com>
 <alpine.DEB.2.21.2110061808570.3209@sstabellini-ThinkPad-T480s>
 <9a4fb8be-e893-bd7f-fe77-7274457e2b04@gmail.com>
 <alpine.DEB.2.21.2110071327520.414@sstabellini-ThinkPad-T480s>
From: Oleksandr <olekstysh@gmail.com>
Message-ID: <9ee3760e-fcb3-c783-3a96-5079c167450c@gmail.com>
Date: Thu, 7 Oct 2021 23:55:21 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.21.2110071327520.414@sstabellini-ThinkPad-T480s>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US


On 07.10.21 23:29, Stefano Stabellini wrote:

Hi Stefano

> On Thu, 7 Oct 2021, Oleksandr wrote:
>> On 07.10.21 04:29, Stefano Stabellini wrote:
>>
>> Hi Stefano
>>
>>> On Wed, 6 Oct 2021, Oleksandr Tyshchenko wrote:
>>>> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>>>>
>>>> The extended region (safe range) is a region of guest physical
>>>> address space which is unused and could be safely used to create
>>>> grant/foreign mappings instead of wasting real RAM pages from
>>>> the domain memory for establishing these mappings.
>>>>
>>>> The extended regions are chosen at the domain creation time and
>>>> advertised to it via "reg" property under hypervisor node in
>>>> the guest device-tree. As region 0 is reserved for grant table
>>>> space (always present), the indexes for extended regions are 1...N.
>>>> If extended regions could not be allocated for some reason,
>>>> Xen doesn't fail and behaves as usual, so only inserts region 0.
>>>>
>>>> Please note the following limitations:
>>>> - The extended region feature is only supported for 64-bit domain
>>>>     currently.
>>>> - The ACPI case is not covered.
>>>>
>>>> ***
>>>>
>>>> The algorithm to choose extended regions for non-direct mapped
>>>> DomU is simpler in comparison with the algorithm for direct mapped
>>>> Dom0. We usually have a lot of unused space above 4GB, and might
>>>> have some unused space below 4GB (depends on guest memory size).
>>>> Try to allocate separate 2MB-aligned extended regions from the first
>>>> (below 4GB) and second (above 4GB) RAM banks taking into the account
>>>> the maximum supported guest physical address space size and the amount
>>>> of memory assigned to the guest. The minimum size of extended region
>>>> the same as for Dom0 (64MB).
>>>>
>>>> Suggested-by: Julien Grall <jgrall@amazon.com>
>>>> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>>>> ---
>>>> ! Stefano, Ian, Michal I dropped your A-b/R-b. I decided to change patch
>>>> to make it more functional !
>>>>
>>>> Changes RFC -> V2:
>>>>      - update patch description
>>>>      - drop uneeded "extended-region" DT property
>>>>      - clear reg array in finalise_ext_region() and add a TODO
>>>>
>>>> Changes V2 -> V3:
>>>>      - update patch description, comments in code
>>>>      - only pick up regions with size >= 64MB
>>>>      - move the region calculation to make_hypervisor_node() and drop
>>>>        finalise_ext_region()
>>>>      - extend the list of arguments for make_hypervisor_node()
>>>>      - do not show warning for 32-bit domain
>>>>      - change the region alignment from 1GB to 2MB
>>>>      - move EXT_REGION_SIZE to public/arch-arm.h
>>>>
>>>> Changes V3 -> V4:
>>>>      - add R-b, A-b and T-b
>>>>
>>>> Changes V4 -> V5:
>>>>      - update patch description and comments in code
>>>>      - reflect changes done in previous patch to pass gpaddr_bits
>>>>        via createdomain domctl (struct xen_arch_domainconfig)
>>>>      - drop R-b, A-b and T-b
>>>>      - drop limit for maximum extended region size (128GB)
>>>>      - try to also allocate region below 4GB, optimize code
>>>>        for calculating extended regions
>>>> ---
>>>>    tools/libs/light/libxl_arm.c  | 80
>>>> ++++++++++++++++++++++++++++++++++++++++---
>>>>    xen/include/public/arch-arm.h |  2 ++
>>>>    2 files changed, 77 insertions(+), 5 deletions(-)
>>>>
>>>> diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c
>>>> index 45e0386..cd743f7 100644
>>>> --- a/tools/libs/light/libxl_arm.c
>>>> +++ b/tools/libs/light/libxl_arm.c
>>>> @@ -600,9 +600,21 @@ static int make_timer_node(libxl__gc *gc, void *fdt,
>>>>        return 0;
>>>>    }
>>>>    +#define ALIGN_UP_TO_2MB(x)   (((x) + MB(2) - 1) & (~(MB(2) - 1)))
>>>> +
>>>>    static int make_hypervisor_node(libxl__gc *gc, void *fdt,
>>>> -                                const libxl_version_info *vers)
>>>> +                                const libxl_version_info *vers,
>>>> +                                const libxl_domain_build_info *b_info,
>>>> +                                const struct xc_dom_image *dom)
>>>>    {
>>>> +    uint64_t region_size[GUEST_RAM_BANKS] = {0},
>>>> region_base[GUEST_RAM_BANKS],
>>>> +        banksize[GUEST_RAM_BANKS], bankend[GUEST_RAM_BANKS], ramsize;
>>>> +    uint32_t regs[(GUEST_ROOT_ADDRESS_CELLS + GUEST_ROOT_SIZE_CELLS) *
>>>> +                  (GUEST_RAM_BANKS + 1)];
>>>> +    be32 *cells = &regs[0];
>>>> +    const uint64_t bankbase[] = GUEST_RAM_BANK_BASES;
>>>> +    unsigned int i, len, nr_regions = 0;
>>>> +    uint8_t gpaddr_bits;
>>>>        int res;
>>>>        gic_interrupt intr;
>>>>    @@ -617,9 +629,67 @@ static int make_hypervisor_node(libxl__gc *gc, void
>>>> *fdt,
>>>>                                  "xen,xen");
>>>>        if (res) return res;
>>>>    -    /* reg 0 is grant table space */
>>>> -    res = fdt_property_regs(gc, fdt, GUEST_ROOT_ADDRESS_CELLS,
>>>> GUEST_ROOT_SIZE_CELLS,
>>>> -                            1,GUEST_GNTTAB_BASE, GUEST_GNTTAB_SIZE);
>>>> +    if (strcmp(dom->guest_type, "xen-3.0-aarch64")) {
>>>> +        LOG(WARN, "The extended regions are only supported for 64-bit
>>>> guest currently");
>>>> +        goto out;
>>>> +    }
>>>> +
>>>> +    gpaddr_bits = b_info->arch_arm.gpaddr_bits;
>>>> +    assert(gpaddr_bits >= 32 && gpaddr_bits <= 48);
>>>> +
>>>> +    /*
>>>> +     * Try to allocate separate 2MB-aligned extended regions from the
>>>> first
>>>> +     * (below 4GB) and second (above 4GB) RAM banks taking into the
>>>> account
>>>> +     * the maximum supported guest physical address space size and the
>>>> amount
>>>> +     * of memory assigned to the guest.
>>>> +     * As the guest memory layout is not populated yet we cannot rely on
>>>> +     * dom->rambank_size[], so calculate the actual size of both banks
>>>> using
>>>> +     * "max_memkb" value.
>>>> +     */
>>>> +    ramsize = b_info->max_memkb * 1024;
>>>> +    if (ramsize <= GUEST_RAM0_SIZE) {
>>>> +        banksize[0] = ramsize;
>>>> +        banksize[1] = 0;
>>>> +    } else {
>>>> +        banksize[0] = GUEST_RAM0_SIZE;
>>>> +        banksize[1] = ramsize - GUEST_RAM0_SIZE;
>>>> +    }
>>>> +
>>>> +    bankend[0] = GUEST_RAM0_BASE + GUEST_RAM0_SIZE;
>>>> +    bankend[1] = min(1ULL << gpaddr_bits, GUEST_RAM1_BASE +
>>>> GUEST_RAM1_SIZE);
>>>> +
>>>> +    for (i = 0; i < GUEST_RAM_BANKS; i++) {
>>>> +        region_base[i] = bankbase[i] + ALIGN_UP_TO_2MB(banksize[i]);
>>>> +        if (bankend[i] > region_base[i])
>>>> +            region_size[i] = bankend[i] - region_base[i];
>>>> +    }
>>> This seems correct but it looks a bit overkill. I would have written
>>> like this:
>>>
>>>       if (ramsize <= GUEST_RAM0_SIZE) {
>>>           region_base[0] = GUEST_RAM0_BASE + ALIGN_UP_TO_2MB(ramsize);
>>>           region_size[0] = GUEST_RAM0_SIZE - ALIGN_UP_TO_2MB(ramsize);
>>>           region_base[1] = GUEST_RAM1_BASE;
>>>           region_size[1] = min(1ULL << gpaddr_bits, GUEST_RAM1_BASE +
>>> GUEST_RAM1_SIZE) -
>>>                            region_base[0];
>> Why  "- region_base[0]" in last expression? I think it should be "-
>> region_base[1]", the same as for "else" case (so it can be moved out of
>> if-else construct). Also we need to check
>>
>> that min(1ULL << gpaddr_bits, GUEST_RAM1_BASE + GUEST_RAM1_SIZE) is greater
>> than region_base[1] before the subtraction. If gpaddr_bits = 32 (on Arm64) we
>> will get incorrect result.
>>
>>
>>>       } else {
>>>           region_size[0] = 0;
>>>           region_base[1] = GUEST_RAM1_BASE + ALIGN_UP_TO_2MB(ramsize -
>>> GUEST_RAM0_SIZE);
>>>           region_size[1] = min(1ULL << gpaddr_bits, GUEST_RAM1_BASE +
>>> GUEST_RAM1_SIZE) -
>>>                            region_base[1];
>>>       }
>>>
>>> Which removes the needs for banksize, bankend, bankbase. What do you
>>> think? Your version works too, so I am OK anyway.
>> Thank you for looking into this.
>>
>> I think, you version will also work with adjustments. I am OK either way. Your
>> version reduces the number of locals, so probably better.  Although "min(1ULL
>> << gpaddr_bits, GUEST_RAM1_BASE + GUEST_RAM1_SIZE)" construction probably
>> wants latching in local bank1end.
>>
>>
>> Below the updated version:
>>
>>      if (ramsize <= GUEST_RAM0_SIZE) {
>>          region_base[0] = GUEST_RAM0_BASE + ALIGN_UP_TO_2MB(ramsize);
>>          region_size[0] = GUEST_RAM0_SIZE - ALIGN_UP_TO_2MB(ramsize);
>>          region_base[1] = GUEST_RAM1_BASE;
>>      } else
>>          region_base[1] = GUEST_RAM1_BASE + ALIGN_UP_TO_2MB(ramsize - GUEST_RAM0_SIZE);
>>
>>      bank1end = min(1ULL << gpaddr_bits, GUEST_RAM1_BASE + GUEST_RAM1_SIZE);
>>      if (bank1end > region_base[1])
>>          region_size[1] = bank1end - region_base[1];
>
> Yeah I like this. I'd be happy to go with it.

Great, thank you, will update.


-- 
Regards,

Oleksandr Tyshchenko



From xen-devel-bounces@lists.xenproject.org Thu Oct 07 21:14:53 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Oct 2021 21:14:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.204025.359222 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYaiz-0007Mo-7g; Thu, 07 Oct 2021 21:14:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 204025.359222; Thu, 07 Oct 2021 21:14:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYaiz-0007Mh-4U; Thu, 07 Oct 2021 21:14:45 +0000
Received: by outflank-mailman (input) for mailman id 204025;
 Thu, 07 Oct 2021 21:14:43 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Ti8Z=O3=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1mYaix-0007Mb-31
 for xen-devel@lists.xenproject.org; Thu, 07 Oct 2021 21:14:43 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id c8a2b3a3-81de-4217-a7f8-8f01ef913191;
 Thu, 07 Oct 2021 21:14:41 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id 638E261058;
 Thu,  7 Oct 2021 21:14:40 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c8a2b3a3-81de-4217-a7f8-8f01ef913191
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1633641280;
	bh=yT20tuwE1nPRXehqM/Dw9IBvRDDRBsfeVOweJ9/NGVY=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=oP+LhXteWG7q8ZKzJAdPPzdGSuJEhM5t8xTqMct8cFwKuq3h4kgj026CF2Pix87zs
	 nUY6zLyZ05dlGyDXesvHXF8O6U15N188di77gCWauHoNMheJzQv1jtIW/iwbPODiP/
	 TuPa/fMtadDbXx+PUOfu3CQ1RVMc2hrS7EXUgdS6HPagZE0m1qcD+PPM5zZKK8i+zE
	 Asz4Uv3GPX7XBtoQtH3+WoYutZBn+aUwxcSzSvvJPQ+3qLeuX6qrPd1jXRDpsIX6iE
	 CXnjSD9deQctQDW34USVADBvbl/srE7ojgqHzZ+5Q3JzLoxpJhTDffSmSio6TlZce+
	 febfa026HBeaw==
Date: Thu, 7 Oct 2021 14:14:39 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
cc: Stefano Stabellini <sstabellini@kernel.org>, 
    Oleksandr <olekstysh@gmail.com>, 
    "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, 
    Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>, 
    Julien Grall <julien@xen.org>, Julien Grall <jgrall@amazon.com>
Subject: Re: [PING] Re: [PATCH] xen/arm: optee: Allocate anonymous domheap
 pages
In-Reply-To: <87r1cwra4t.fsf@epam.com>
Message-ID: <alpine.DEB.2.21.2110071357160.414@sstabellini-ThinkPad-T480s>
References: <1630935741-17088-1-git-send-email-olekstysh@gmail.com> <alpine.DEB.2.21.2109231308200.17979@sstabellini-ThinkPad-T480s> <87bl4jrovq.fsf@epam.com> <81f7699b-69c1-da52-a1a7-5000343bf872@gmail.com> <alpine.DEB.2.21.2110061639050.3209@sstabellini-ThinkPad-T480s>
 <87r1cwra4t.fsf@epam.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Thu, 7 Oct 2021, Volodymyr Babchuk wrote:
> Hi Stefano,
> 
> Stefano Stabellini <sstabellini@kernel.org> writes:
> 
> > On Wed, 6 Oct 2021, Oleksandr wrote:
> >> Hello all
> >> 
> >> Gentle reminder.
> >  
> > Many thanks for the ping, this patch fell off my radar.
> >
> >
> >  
> >> On 23.09.21 23:57, Volodymyr Babchuk wrote:
> >> > Hi Stefano,
> >> > 
> >> > Stefano Stabellini <sstabellini@kernel.org> writes:
> >> > 
> >> > > On Mon, 6 Sep 2021, Oleksandr Tyshchenko wrote:
> >> > > > From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> >> > > > 
> >> > > > Allocate anonymous domheap pages as there is no strict need to
> >> > > > account them to a particular domain.
> >> > > > 
> >> > > > Since XSA-383 "xen/arm: Restrict the amount of memory that dom0less
> >> > > > domU and dom0 can allocate" the dom0 cannot allocate memory outside
> >> > > > of the pre-allocated region. This means if we try to allocate
> >> > > > non-anonymous page to be accounted to dom0 we will get an
> >> > > > over-allocation issue when assigning that page to the domain.
> >> > > > The anonymous page, in turn, is not assigned to any domain.
> >> > > > 
> >> > > > CC: Julien Grall <jgrall@amazon.com>
> >> > > > Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> >> > > > Acked-by: Volodymyr Babchuk <volodymyr_babchuk@epam.com>
> >> > > Only one question, which is more architectural: given that these pages
> >> > > are "unlimited", could the guest exploit the interface somehow to force
> >> > > Xen to allocate an very high number of anonymous pages?
> >> > > 
> >> > > E.g. could a domain call OPTEE_SMC_RPC_FUNC_ALLOC in a loop to force Xen
> >> > > to exaust all memory pages?
> >> > Generally, OP-TEE mediator tracks all resources allocated and imposes
> >> > limits on them.
> >> > 
> >> > OPTEE_SMC_RPC_FUNC_ALLOC case is a bit different, because it is issued
> >> > not by domain, but by OP-TEE itself. As OP-TEE is more trusted piece of
> >> > system we allow it to request as many buffers as it wants. Also, we know
> >> > that OP-TEE asks only for one such buffer per every standard call. And
> >> > number of simultaneous calls is limited by number of OP-TEE threads,
> >> > which is quite low: typically only two.
> >
> > So let me repeat it differently to see if I understood correctly:
> >
> > - OPTEE_SMC_RPC_FUNC_ALLOC is only called by OP-TEE, not by the domain
> > - OPTEE is trusted and only call it twice anyway
> 
> Correct.
> 
> > I am OK with this argument, but do we have a check to make sure a domU
> > cannot issue OPTEE_SMC_RPC_FUNC_ALLOC?
> 
> domU can't issue any RPC, because all RPCs are issued from OP-TEE
> side. This is the nature of RPC - OP-TEE requests Normal World for some
> service. But of course, Normal World can perform certain actions that
> will make OP-TEE to issue a RPC. I discuss this in depth below.
> 
> >
> > Looking at the patch, there are other two places, in addition to
> > OPTEE_SMC_RPC_FUNC_ALLOC, where the anonymous memory pages can be
> > allocated:
> >
> > 1) copy_std_request
> > 2) translate_noncontig
> >
> > We need to prove that neither 1) or 2) can result in a domU exausting
> > Xen memory.
> >
> > In the case of 1), it looks like the memory is freed before returning to
> > the DomU, right? If so, it should be no problem?
> 
> Yes, mediator makes shadow copy of every request buffer to hide
> translated addresses from the guest. Number of requests is limited by
> number of OP-TEE threads.
> 
> > In the case of 2), it looks like the memory could outlive the call where
> > it is allocated. Is there any kind of protection against issuing
> > something like OPTEE_MSG_ATTR_TYPE_TMEM_INOUT in a loop? Is it OP-TEE
> > itself that would refuse the attempt? Thus, the idea is that
> > do_call_with_arg will return error and we'll just free the memory there?
> 
> Well, translate_noncontig() calls allocate_optee_shm_buf() which counts
> all allocated buffers. So you can't call it more than
> MAX_SHM_BUFFER_COUNT times, without de-allocating previous memory. But,
> thanks to your question, I have found a bug there: memory is not freed
> if allocate_optee_shm_buf() fails. I'll prepare patch later today.
> 
> > I cannot see a check for errors returned by do_call_with_arg and memory
> > freeing done because of that. Sorry I am not super familiar with the
> > code, I am just trying to make sure we are not offering to DomUs an easy
> > way to crash the system.
> 
> I tried to eliminate all possibilities for a guest to crash the
> system. Of course, this does not mean that there are none of them.
> 
> And yes, code is a bit hard to understand, because calls to OP-TEE are
> stateful and you need to account for that state. From NW and SW this
> looks quite fine, because state is handled naturally. But mediator sits
> in a middle, so it's implementation is a bit messy.
> 
> I'll try to explain what is going on, so you it will be easier to
> understand logic in the mediator.
> 
> There are two types of OP-TEE calls: fast calls and standard calls. Fast
> call is simple: call SMC and get result. It does not allocate thread
> context in OP-TEE and is non-preemptive. So yes, it should be fast. It
> is used for simple things like "get OP-TEE version" or "exchange
> capabilities". It is easy to handle them in mediator: just forward
> the call, check result, return it back to a guest.
> 
> Standard calls are stateful. OP-TEE allocates thread for each call. This
> call can be preempted either by IRQ or by RPC. For consistency IRQ
> return is also considered as special type of RPC. So, in general one
> standard call can consist of series of SMCs:
> 
> --> SMC with request
> <-- RPC return (like IRQ)
> --> SMC "resume call"
> <-- RPC return (like "read disk")
> --> SMC "resume call"
> <-- RPC return (like "send network packet")
> --> SMC "resume call"
> ...
> <-- Final return
> 
> There are many types of RPCs: "handle IRQ", additional shared buffer
> allocation/de-allocation, RPMB access, disks access, network access,
> synchronization primitives (when OP-TEE thread is gets blocked on a
> mutex), etc.
> 
> Two more things that makes all this worse: Normal World can register
> shared buffer with OP-TEE. Such buffer can live indefinitely
> long. Also, Normal World decides when to resume call. For example,
> calling process can be preempted and then resumed seconds
> later. Misbehaving guest can decide to not resume call at all.
> 
> As I said, I tried to take all this things into account. There are
> basically 3 types of objects that can lead to memory allocation on Xen
> side:
> 
> 1. Standard call context. Besides memory space for struct optee_std_call
> itself it allocates page for a shadow buffer, where argument addresses
> are translated by Xen. Number of this objects is limited by number of
> OP-TEE threads:
> 
>     count = atomic_add_unless(&ctx->call_count, 1, max_optee_threads);
>     if ( count == max_optee_threads )
>         return ERR_PTR(-ENOSPC);
> 
> 2. Shared buffer. This is a buffer shared by guest with OP-TEE. It can
> be either temporary buffer which is shared for one standard call
> duration, or registered shared buffer, which is remains active until it
> is de-registered. This is where translate_noncontig() comes into play.
> Number of this buffers is limited in allocate_optee_shm_buf():
> 
>     count = atomic_add_unless(&ctx->optee_shm_buf_count, 1,
>                               MAX_SHM_BUFFER_COUNT);
>     if ( count == MAX_SHM_BUFFER_COUNT )
>         return ERR_PTR(-ENOMEM);
> 
> 3. Shared RPC buffer. This is very special kind of buffer. Basically,
> OP-TEE needs some shared memory to provide RPC call parameters. So it
> requests buffer from Normal World. There is no hard limit on this from
> mediator side, because, as I told earlier, OP-TEE itself limits number
> of this buffers. There is no cases when more that one buffer will be
> allocated per OP-TEE thread. This type of buffer is used only to process
> RPC requests themselves. OP-TEE can request more buffers via RPC, but
> they will fall to p.2: NW uses separate request to register buffer and
> then returns its handle in the preempted call.
> 
> 
> Apart from those two limits, there is a limit on total number of pages
> which is shared between guest and OP-TEE: MAX_TOTAL_SMH_BUF_PG. This
> limit is for a case when guest tries to allocate few really BIG buffers.
> 
> 
> > It looks like they could be called from one of the OPTEE operations that
> > a domU could request? Is there a limit for them?
> 
> Yes, there are limits, as I described above.
> 
> Also, bear in mind that resources available to OP-TEE are also quite
> limited. So, in case of some breach in mediator, OP-TEE will give up
> first. This of course is not an excuse to have bugs in the mediator...

OK, thanks for the explanation. The reasons for my questions is that if
the allocations are using the memory of DomU, then at worst DomU can run
out of memory. But if the allocations are using anonymous memory, then
the whole platform might run out of memory. We have issued XSAs for
things like that in the past.

This is why I am worried about this patch: if we apply it we really
become reliant on these limits being implemented correctly. A bug can
have much more severe consequences.

As you are the maintainer for this code, and this code is not security
supported, I'll leave it up to you (also see the other email about
moving optee to "supported, not security supported").

However, maybe a different solution would be to increase max_pages for a
domain when optee is enabled? Maybe just by a few pages (as many as
needed by the optee mediator)? Because if we did that, we wouldn't risk
exposing DOS attack vectors for every bug in the mediator limits checks.

The below adds a 10 pages slack.


diff --git a/xen/arch/arm/tee/tee.c b/xen/arch/arm/tee/tee.c
index 3964a8a5cd..a3105f1a9a 100644
--- a/xen/arch/arm/tee/tee.c
+++ b/xen/arch/arm/tee/tee.c
@@ -38,8 +38,11 @@ bool tee_handle_call(struct cpu_user_regs *regs)
     return cur_mediator->ops->handle_call(regs);
 }
 
+#define TEE_SLACK (10)
 int tee_domain_init(struct domain *d, uint16_t tee_type)
 {
+    int ret;
+
     if ( tee_type == XEN_DOMCTL_CONFIG_TEE_NONE )
         return 0;
 
@@ -49,7 +52,15 @@ int tee_domain_init(struct domain *d, uint16_t tee_type)
     if ( cur_mediator->tee_type != tee_type )
         return -EINVAL;
 
-    return cur_mediator->ops->domain_init(d);
+    ret = cur_mediator->ops->domain_init(d);
+    if ( ret < 0 )
+        return ret;
+
+    /* 
+     * Increase maxmem for domains with TEE, the extra pages are used by
+     * the mediator
+     */
+    d->max_pages += TEE_SLACK;
 }
 
 int tee_relinquish_resources(struct domain *d)


From xen-devel-bounces@lists.xenproject.org Thu Oct 07 21:19:29 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Oct 2021 21:19:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.204036.359232 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYanY-0008A9-Ts; Thu, 07 Oct 2021 21:19:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 204036.359232; Thu, 07 Oct 2021 21:19:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYanY-0008A2-Qz; Thu, 07 Oct 2021 21:19:28 +0000
Received: by outflank-mailman (input) for mailman id 204036;
 Thu, 07 Oct 2021 21:19:27 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=4W4d=O3=gmail.com=olekstysh@srs-us1.protection.inumbo.net>)
 id 1mYanX-00089Y-Ir
 for xen-devel@lists.xenproject.org; Thu, 07 Oct 2021 21:19:27 +0000
Received: from mail-ed1-x529.google.com (unknown [2a00:1450:4864:20::529])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id d8fef562-bb3e-4295-b308-b0a52a44b1cc;
 Thu, 07 Oct 2021 21:19:26 +0000 (UTC)
Received: by mail-ed1-x529.google.com with SMTP id r18so28253450edv.12
 for <xen-devel@lists.xenproject.org>; Thu, 07 Oct 2021 14:19:26 -0700 (PDT)
Received: from [192.168.1.7] ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id o5sm230384eds.26.2021.10.07.14.19.25
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Thu, 07 Oct 2021 14:19:25 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d8fef562-bb3e-4295-b308-b0a52a44b1cc
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-transfer-encoding:content-language;
        bh=LukkjeGvSI0BY1W+mXe0HSJdY78EUYNMhAIPp3JeJPA=;
        b=n8NV+1m2KOfLSVOINnmtS4LmJSf79mjK7Z/o1XfFDZwswDnIH8G9kWvsyLETg2B7mo
         +u8oiRH7IAQJWMU8R5s0IvCrs5EXoYtLKnOcOO6tBkURiJdNxs099+VLoMyG2UVgMoti
         mbL3KRMtCbjRTm3xJZ/hdIxKuhevD+8t2n7/cs4t0bhlZ1bcuk0xciID8MJIMe5xzW/f
         fAoElJ9pyF1rBUXihIFNIxVKTDLvjMYOi76gBQyqnDh5Bzn4cn0GNCpiXX7lwO8YbD14
         Sii99VKHfpEadrEB/hWA70biQukb+VIhDwyrI/J7H5wwxSCgTSrqamgMgRhdCxPdHrwa
         EN7g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding
         :content-language;
        bh=LukkjeGvSI0BY1W+mXe0HSJdY78EUYNMhAIPp3JeJPA=;
        b=FZNjlNbsIAqM2u9Z0SxgB9VH9XCKGNoyRenehKKmio2Soj94mZS+GqSLbxQbUKuqlg
         cQELLd8a4Hv5lytRF5rWZW8D9AAtlBwfcz4rQf3Gx8xqlBDfeqeD0okfjQ7Vw3iScEn+
         sg9pk7CvA7RIU0WjBQBgn6cpKHX5ALR5Q68sD0tHzd/Wuk+bMwt3DLCsiSISM8S5BtTG
         sTXHe3I60LsF5TbPlfbDplivCGlA4Gj7oYiQWO0f6omGB0VvTtKb0tqX96L1Ay03vFZ7
         Mu30srH+UbRkPQPie2yguZ+9Lv/VuKe5R7IHXLsFOdRlxsmCzJFMvZYYtcQmGpbtDXns
         pY9Q==
X-Gm-Message-State: AOAM533kPJEyiv0obKhQwhY4n/b2nDJVauMGMWKvk1oaX9RCakuuXuWu
	JqOlMqIAbRxUMj0MgtFF1bQ=
X-Google-Smtp-Source: ABdhPJx/buooncs7SbNYFsuLDN9rPZbfccw8RSBVoZCzxV0dqr3NMdf7mk2TrSBVPR0klTbUsuFsMw==
X-Received: by 2002:a05:6402:3483:: with SMTP id v3mr7321340edc.296.1633641565720;
        Thu, 07 Oct 2021 14:19:25 -0700 (PDT)
Subject: Re: [PATCH V5 3/3] xen/arm: Updates for extended regions support
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: xen-devel@lists.xenproject.org,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Julien Grall <julien@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <1633519346-3686-1-git-send-email-olekstysh@gmail.com>
 <1633519346-3686-4-git-send-email-olekstysh@gmail.com>
 <alpine.DEB.2.21.2110061843360.3209@sstabellini-ThinkPad-T480s>
 <a5a81348-4b18-6be6-ba85-4c31172459dc@gmail.com>
 <alpine.DEB.2.21.2110071300380.414@sstabellini-ThinkPad-T480s>
 <ff6800b3-74f0-3203-6465-1547644924e2@gmail.com>
 <alpine.DEB.2.21.2110071337550.414@sstabellini-ThinkPad-T480s>
From: Oleksandr <olekstysh@gmail.com>
Message-ID: <fe6ed0ec-597a-9548-db68-465633892ca9@gmail.com>
Date: Fri, 8 Oct 2021 00:19:24 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.21.2110071337550.414@sstabellini-ThinkPad-T480s>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US


On 07.10.21 23:42, Stefano Stabellini wrote:

Hi Stefano

> On Thu, 7 Oct 2021, Oleksandr wrote:
>> On 07.10.21 23:06, Stefano Stabellini wrote:
>>> On Thu, 7 Oct 2021, Oleksandr wrote:
>>>> On 07.10.21 04:50, Stefano Stabellini wrote:
>>>>
>>>> Hi Stefano
>>>>
>>>>> On Wed, 6 Oct 2021, Oleksandr Tyshchenko wrote:
>>>>>> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>>>>>>
>>>>>> This is a follow-up of
>>>>>> "b6fe410 xen/arm: Add handling of extended regions for Dom0"
>>>>>>
>>>>>> Add various in-code comments, update Xen hypervisor device tree
>>>>>> bindings text, change the log level for some prints and clarify
>>>>>> format specifier, reuse dt_for_each_range() to avoid open-coding
>>>>>> in find_memory_holes().
>>>>>>
>>>>>> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>>>>> Thanks for the patch, it looks like you addressed all Julien's comments
>>>>> well.
>>>> I believe so)
>>> [...]
>>>
>>>>>> @@ -1193,8 +1215,8 @@ static int __init make_hypervisor_node(struct
>>>>>> domain
>>>>>> *d,
>>>>>>             u64 start = ext_regions->bank[i].start;
>>>>>>             u64 size = ext_regions->bank[i].size;
>>>>>>     -        dt_dprintk("Extended region %d: %#"PRIx64"->%#"PRIx64"\n",
>>>>>> -                   i, start, start + size);
>>>>>> +        printk("Extended region %d: %#"PRIx64"->%#"PRIx64"\n",
>>>>>> +               i, start, start + size);
>>>>> Also should be PRIpaddr
>>>> I thought I needed to change specifier only for variables of type
>>>> "paddr_t",
>>>> but here "u64".
>>> Sorry, you are right.
>>>
>>> I added my reviewed-by and made the small typo changes on commit.
>> Thanks! In case if you haven't committed the patch yet, let's please wait for
>> Julien (who asked for this follow-up) to review it.
>>
>> In any case, I will be able to do another follow-up if needed.
>   
> I committed it as I would like to squeeze as many runs out of OSSTest
> and Gitlab-CI as possible as we are getting closer and closer to the
> release. I am trying to avoid the last minute rush to commit 150 patches
> one day before code freeze :-)
>
> The more intermediate runs we get, the easier is to pinpoint (and fix)
> regressions.

I got it, thank you for the explanation.


>
> But also, this patch doesn't affect external interfances, it is just
> internal and mostly comments, so it is super-easy to do follow-ups.

Yes, agree.


-- 
Regards,

Oleksandr Tyshchenko



From xen-devel-bounces@lists.xenproject.org Thu Oct 07 21:30:14 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Oct 2021 21:30:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.204044.359244 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYaxl-0001Mi-TV; Thu, 07 Oct 2021 21:30:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 204044.359244; Thu, 07 Oct 2021 21:30:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYaxl-0001Lv-PH; Thu, 07 Oct 2021 21:30:01 +0000
Received: by outflank-mailman (input) for mailman id 204044;
 Thu, 07 Oct 2021 21:30:00 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=9/ki=O3=arm.com=Rahul.Singh@srs-us1.protection.inumbo.net>)
 id 1mYaxk-0001Ee-Hu
 for xen-devel@lists.xenproject.org; Thu, 07 Oct 2021 21:30:00 +0000
Received: from EUR01-VE1-obe.outbound.protection.outlook.com (unknown
 [2a01:111:f400:fe1f::616])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 2dc09697-4e54-42f9-8c9d-1ea43bce6f23;
 Thu, 07 Oct 2021 21:29:57 +0000 (UTC)
Received: from AM6P191CA0077.EURP191.PROD.OUTLOOK.COM (2603:10a6:209:8a::18)
 by AM6PR08MB3048.eurprd08.prod.outlook.com (2603:10a6:209:46::23) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.22; Thu, 7 Oct
 2021 21:29:53 +0000
Received: from AM5EUR03FT009.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:209:8a:cafe::d3) by AM6P191CA0077.outlook.office365.com
 (2603:10a6:209:8a::18) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18 via Frontend
 Transport; Thu, 7 Oct 2021 21:29:53 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM5EUR03FT009.mail.protection.outlook.com (10.152.16.110) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4587.18 via Frontend Transport; Thu, 7 Oct 2021 21:29:53 +0000
Received: ("Tessian outbound 8e26f7114b75:v103");
 Thu, 07 Oct 2021 21:29:52 +0000
Received: from 4ecda216ea39.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 25994354-538F-4BEA-93F2-FB8BB6EE5402.1; 
 Thu, 07 Oct 2021 21:29:46 +0000
Received: from EUR02-AM5-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 4ecda216ea39.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Thu, 07 Oct 2021 21:29:46 +0000
Received: from AS8PR08MB6919.eurprd08.prod.outlook.com (2603:10a6:20b:39e::10)
 by AM6PR08MB3046.eurprd08.prod.outlook.com (2603:10a6:209:48::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.13; Thu, 7 Oct
 2021 21:29:44 +0000
Received: from AS8PR08MB6919.eurprd08.prod.outlook.com
 ([fe80::51ee:e7de:6c0a:bcf9]) by AS8PR08MB6919.eurprd08.prod.outlook.com
 ([fe80::51ee:e7de:6c0a:bcf9%7]) with mapi id 15.20.4566.023; Thu, 7 Oct 2021
 21:29:44 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2dc09697-4e54-42f9-8c9d-1ea43bce6f23
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=JURL/W6EG3nj3WleGQmL6icSqqBC7/0f1R47fa07m3U=;
 b=cIppaf6hu8iMbCjAuXvnMUFRZQshxIihhF4YW3bJUzBU9oiYxz0GV3rCAEiw3RQ48y/+E8s5Yl9aKQUJpH/QFxUjI2+y42GD7B+x0PyNiC43lJxupx3NfkMMrAjnA9SZLxa3YBt/rPgxsaFkC8d7urZHii3rGYGjQY3x83ZEfU0=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 709cdd73aa103954
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=XhM8LYIfmLcbWmoXlXP/M1juBnxkYQsxuChtivlToGVuI/1xP6fx7xs2ECFABAEyYq8GhekXOVdgjOJcPn0ET3rsSi3MAuy2X1fPMCXtB4YNmDIavwsEmATof9bNKMHs3moqZ4A6kDzKbSjD6RC2njNvtq29bd4BWF8LxrzuKYbPix4ILLPwbxXy9gIkdimICJ0MIZdUFnKs9+ajESsn6PIHyiK2Chhq095iRXnvtdXCLjNb21IIzCuAZfjKi0zCSWiZRT+8ep03DoSGco4Rwa4eA5Rmx8ysdiauKiR5OwPRTW4kBQpUhdzZWEqt1uMNjklVyZvc2rj/KrNUur55ZA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=JURL/W6EG3nj3WleGQmL6icSqqBC7/0f1R47fa07m3U=;
 b=CUdp1D6sHUWEwzrY7/scJilobtjzqArd39XwQkNtdxzjVhgwj/JuV/IWG3BNSXbQgLMMw+7MPdd6hJRxm1vpqumYOaXv19FyJ7U5Ja6jr7t3ji+iKtGtM00v1bBqnh3MknXltRapJYFqkGfGg3suiN+BkNRuwM7Q7zUTsM6SY/FlUYUk6wr7rF4WL7ksc5nwD49mQIR8l3lgfVl9+lLvD07792VO7CfnKtp0o9LiQR7JmlMLUka0TNBMGj+geAMGcB8o2O1Q15ZEpV++bwAzyw+/we7nVfTSUktrOVNpzPidu3lf6A6Rr45G3urI9d0B7z6KB+1j+whxuLkkvzHV+Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=JURL/W6EG3nj3WleGQmL6icSqqBC7/0f1R47fa07m3U=;
 b=cIppaf6hu8iMbCjAuXvnMUFRZQshxIihhF4YW3bJUzBU9oiYxz0GV3rCAEiw3RQ48y/+E8s5Yl9aKQUJpH/QFxUjI2+y42GD7B+x0PyNiC43lJxupx3NfkMMrAjnA9SZLxa3YBt/rPgxsaFkC8d7urZHii3rGYGjQY3x83ZEfU0=
From: Rahul Singh <Rahul.Singh@arm.com>
To: Stefano Stabellini <sstabellini@kernel.org>
CC: xen-devel <xen-devel@lists.xenproject.org>, Bertrand Marquis
	<Bertrand.Marquis@arm.com>, Andre Przywara <Andre.Przywara@arm.com>, Ian
 Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>, Juergen Gross
	<jgross@suse.com>, Julien Grall <julien@xen.org>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
	=?iso-8859-1?Q?Roger_Pau_Monn=E9?= <roger.pau@citrix.com>, Christian Lindig
	<christian.lindig@citrix.com>, David Scott <dave@recoil.org>, Paul Durrant
	<paul@xen.org>, Anthony PERARD <anthony.perard@citrix.com>
Subject: Re: [PATCH v5 00/11] PCI devices passthrough on Arm
Thread-Topic: [PATCH v5 00/11] PCI devices passthrough on Arm
Thread-Index: AQHXutlceeUNYF1AYk+Z54KWyB0oI6vH9LCAgAAafgA=
Date: Thu, 7 Oct 2021 21:29:42 +0000
Message-ID: <8052B229-D572-476F-BCF3-C8F44EA38129@arm.com>
References: <cover.1633540842.git.rahul.singh@arm.com>
 <alpine.DEB.2.21.2110071251530.414@sstabellini-ThinkPad-T480s>
In-Reply-To: <alpine.DEB.2.21.2110071251530.414@sstabellini-ThinkPad-T480s>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
Authentication-Results-Original: kernel.org; dkim=none (message not signed)
 header.d=none;kernel.org; dmarc=none action=none header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: a10850d6-81c5-4d8d-632f-08d989d999e8
x-ms-traffictypediagnostic: AM6PR08MB3046:|AM6PR08MB3048:
x-ms-exchange-transport-forked: True
X-Microsoft-Antispam-PRVS:
	<AM6PR08MB30486E9EB1D266936A8F0BF9FCB19@AM6PR08MB3048.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:6790;OLM:6790;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 WAnH6Iu7BNufBOLdCQG1akvff6aTdVEKbBgAOCrgZApjAr77cniqd8AuSHMLEqa7YkMHBbGOdDz+s9wdIH6e4ytrVpfFiO7+I81YXe+K0K5xZ1CSq7ZUpHNL3m5+5o/YKBVCtHND4s6EhJaQ2m+7dsXSyRAU74eeUumLKzwPm+/b1So+6rZuu4j7Z/IuC7AmbAxruiI84xYoUHDYVpi4lcH6vaw+Eh1mTLZ1rk03y9SIeq6pvJOiB4cq2xBp/qKGNVFWa5BqX4HR2G5FbLqYBRG3GVxCi0DxmTHDeEZ8AmYWByIazLliJ0P3vobGd0ialXBRKaz+2T7b7XKx2iwfPzeUVLzWFNhQULDIjcwNzy94YLHCv+KR3Gefeorz9u3+ga92Rz2QH+FlzWAk86h2fHlGYhnlp2pkiGha0aHeL809Sdprlbp7M56o/+EBEoxrYzdh7W0sNM2C5PqGC4yTyJy73yBFwC+Pi9U/1c+QK0+tSlwHFGdrlMyxNK0M/dlmRjTJ6IJajThUfIJ1/9SsClfVW9DCBVs6DEo7wpLkaAhrWC+Re+Qq4uGHhLirUch2GCJNkYOhZv2I/b9a4/IAm0QpEkB5gkdXt8eehMVojv0WbbATxI6RU8z97nacx9RqA3n0VJ0iEcteZyxelmPqH96iHY4TPX+0n0sOAcpdX+qbA9DKu7bT+v8VTMGZO/7pm/HzblUM6ebTWIDbE1GOrcKNXpcqmnz72Dn+eISddfzNCf30s3PyC5lx9kV0Bt28Vrof/XYJ51HJX6CBKM+vu22KC4fjl0yJyGXsCAG40Ssr4TViwq/DjXiKUhUMgfuyZp81Hf6UW/W2K++MPZgZB+da1yLXjUMCsg0KL/cRPcI=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6919.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(186003)(66446008)(54906003)(33656002)(64756008)(86362001)(53546011)(6486002)(38100700002)(122000001)(26005)(2906002)(966005)(316002)(4326008)(6512007)(508600001)(2616005)(71200400001)(83380400001)(8676002)(5660300002)(8936002)(6506007)(7416002)(66476007)(66556008)(91956017)(76116006)(66946007)(36756003)(38070700005)(6916009)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="iso-8859-1"
Content-ID: <5138C444C653D143868C6320084D02A8@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3046
Original-Authentication-Results: kernel.org; dkim=none (message not signed)
 header.d=none;kernel.org; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM5EUR03FT009.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	adf60360-32e3-451a-e979-08d989d99465
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	shkc8oqQNetKU2FnEEsM5DQ9Jy7Jng16+RILjYYKPU8cT1v1Ykpf3J1d5eIiBO6jAKAbK5VlKZLzUSk/KqFfe8dnLhsLilsjIAXdFqqLkG+QoBlYbSTPtAhJvT6VJA1SfKNJasIpK/A/uuqGqqKgTBqf1+h3BVtRzoJ0n3NtIcj9XVVNYYRraPzZewAx253FDwo10pcw0TNQdilyCuLxkYc8WM8eNxu5kyi0Pu0NC3A2x8sVmNDnhu7SoPNg+B0o91ZZnuxo2Y2crh+c2RhZ0VR/c+Pnyh/0eanmcZOMVvkLxSVq7FofwDysA4lYv5dt2/oGb1rBelVLesiBRT3i5m7aaJijKUEwObTKyKLYhYUd2urUviKr+HpwzM4RQyr2iAeo+uYru1mM7R89ZMOIhFb0RMRsoLahcJCCqbzFNUou9efbuX1wlhhmnlmzQ9rWPmaNpLM05p3D7UBpRlLTOHBx6y1YuU6313J6WH6/RB3psV6BJl0rXzkYYb62ZyYPU+Y5nJSARZbrooUoWG3+P23hLBjuMVPtDa3z2gBsVT38GDzvB6+9My9pkB/CiLnVwLYEWof/Y5x06ihP7zbuyCz/1KVsiCcO2x/hIA+tABiwWnEKU3X0rXmsN445MEXHiS+Z1NCVlgDFk9iMwYYS9q3FyldrZKRcrjx11caVlpJGJbYZ5INZ5KqmKOoGv0rTYCaXR++NpXSypArlTDEavsQXcM/oBhDjPzWtLiaRRNXnpt8w7oBd6qwxPWhsrYkVDCFFK168h4f5UXWK08k2ZF4IKuQH52s0P6eXsynobMOkFzxMH5eogzUwbxb9WBpw
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(70586007)(8936002)(6486002)(336012)(81166007)(33656002)(8676002)(966005)(186003)(6512007)(316002)(508600001)(107886003)(47076005)(54906003)(83380400001)(4326008)(6862004)(26005)(36860700001)(5660300002)(36756003)(2906002)(82310400003)(6506007)(86362001)(2616005)(356005)(70206006)(53546011);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Oct 2021 21:29:53.1948
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: a10850d6-81c5-4d8d-632f-08d989d999e8
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM5EUR03FT009.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3048

Hi Stefano,

> On 7 Oct 2021, at 8:54 pm, Stefano Stabellini <sstabellini@kernel.org> wr=
ote:
>=20
> I committed patches 2-7.
>=20
> I made two small adjustments on commit:
> - patch #3: bool_t/bool
> - patch #7: drop _XEN_DOMCTL_CDF_vpci

Thank you very much. I will be on leave from tomorrow. Someone from my=20
team will take care of the rest of the patch and reply to the comments.

Regards,
Rahul
>=20
> Cheers,
>=20
> Stefano
>=20
>=20
> On Wed, 6 Oct 2021, Rahul Singh wrote:
>> Hello All,
>>=20
>> The purpose of this patch series is to add PCI passthrough support to Xe=
n on
>> Arm. PCI passthrough support on ARM is the collaboration work between EP=
AM and
>> ARM. ARM submitted the partial RFC [1][2] last year to get early feedbac=
k. We
>> tried to fix all the comments and added more features to this patch seri=
es.
>>=20
>> Working POC with all the features can be found at [3]. Working POC is te=
sted
>> on x86 so that there will be no regression on x86. Design presentation c=
an be
>> found at [4]
>>=20
>> PCI passthrough support is divided into different patches. This patch se=
ries
>> includes following features:=20
>>=20
>> Preparatory work to implement the PCI passthrough support for the ARM:
>> - Refactor MSI code.
>> - Fixed compilation error when HAS_PCI enabled for ARM.
>>=20
>> Discovering PCI Host Bridge in XEN:
>> - PCI init to initialize the PCI driver.
>> - PCI host bridge discovery in XEN and map the PCI ECAM configuration sp=
ace to
>>  the XEN memory.
>> - PCI access functions.
>>=20
>> Discovering PCI devices:
>> - To support the PCI passthrough, XEN should be aware of the PCI
>>  devices.
>> - Hardware domain is in charge of doing the PCI enumeration and will dis=
cover
>>  the PCI devices and then communicate to the XEN via a hypercall to add =
the
>>  PCI devices in XEN.
>>=20
>> Enable the existing x86 virtual PCI support for ARM:
>> - Add VPCI trap handler for each of the PCI device added for config spac=
e
>>  access.
>> - Register the trap handler in XEN for each of the host bridge PCI ECAM =
config
>>  space access.
>>=20
>> Emulated PCI device tree node in libxl:
>> - Create a virtual PCI device tree node in libxl to enable the guest OS =
to
>>  discover the virtual PCI during guest boot.
>>=20
>> This patch series does not inlcude the following features. Following fea=
tures
>> will be send for review in the next version of the patch series once ini=
tial
>> patch series merged.
>>=20
>> - VPCI support for DOMU guests (Non-identity mappings guest view of the =
BARs)
>> - Virtual bus topology implementation
>> - IOMMU related changes (generic, SMMUv2, SMMUv3)
>> - MSI support for DOMU guests.
>> - Virual ITS support for DOMU guests
>>=20
>> [1] https://lists.xenproject.org/archives/html/xen-devel/2020-07/msg0118=
4.html
>> [2] https://lists.xenproject.org/archives/html/xen-devel/2020-07/threads=
.html#01184
>> [3] https://gitlab.com/rahsingh/xen-integration/-/tree/arm_pci_v4_integr=
ate
>> [4] https://static.sched.com/hosted_files/xen2021/e4/PCI_Device_Passthro=
ugh_On_Arm.pdf
>>=20
>> Oleksandr Andrushchenko (1):
>>  xen/arm: Add support for Xilinx ZynqMP PCI host controller
>>=20
>> Rahul Singh (10):
>>  xen/arm: xc_domain_ioport_permission(..) not supported on ARM.
>>  xen/arm: Add PHYSDEVOP_pci_device_(*add/remove) support for ARM
>>  xen/arm: Add cmdline boot option "pci-passthrough =3D <boolean>"
>>  xen/arm: PCI host bridge discovery within XEN on ARM
>>  xen/arm: Implement pci access functions
>>  xen/domctl: Introduce XEN_DOMCTL_CDF_vpci flag
>>  xen/arm: Enable the existing x86 virtual PCI support for ARM.
>>  xen/arm: Transitional change to build HAS_VPCI on ARM.
>>  arm/libxl: Emulated PCI device tree node in libxl
>>  xen/arm: Add linux,pci-domain property for hwdom if not available.
>>=20
>> docs/misc/xen-command-line.pandoc   |   7 +
>> tools/include/libxl.h               |   6 +
>> tools/libs/ctrl/xc_domain.c         |   9 +
>> tools/libs/light/libxl_arm.c        | 111 +++++++++++
>> tools/libs/light/libxl_types.idl    |   1 +
>> tools/ocaml/libs/xc/xenctrl.ml      |   1 +
>> tools/ocaml/libs/xc/xenctrl.mli     |   1 +
>> xen/arch/arm/Makefile               |   1 +
>> xen/arch/arm/domain.c               |   8 +-
>> xen/arch/arm/domain_build.c         |  19 ++
>> xen/arch/arm/pci/Makefile           |   5 +
>> xen/arch/arm/pci/ecam.c             |  61 ++++++
>> xen/arch/arm/pci/pci-access.c       | 140 ++++++++++++++
>> xen/arch/arm/pci/pci-host-common.c  | 287 ++++++++++++++++++++++++++++
>> xen/arch/arm/pci/pci-host-generic.c |  48 +++++
>> xen/arch/arm/pci/pci-host-zynqmp.c  |  65 +++++++
>> xen/arch/arm/pci/pci.c              |  12 ++
>> xen/arch/arm/physdev.c              |   6 +-
>> xen/arch/arm/vpci.c                 | 102 ++++++++++
>> xen/arch/arm/vpci.h                 |  36 ++++
>> xen/arch/x86/domain.c               |   6 +
>> xen/arch/x86/physdev.c              |  52 +----
>> xen/arch/x86/x86_64/physdev.c       |   2 +-
>> xen/common/domain.c                 |   2 +-
>> xen/drivers/passthrough/pci.c       |  18 ++
>> xen/drivers/pci/Makefile            |   1 +
>> xen/drivers/pci/physdev.c           |  86 +++++++++
>> xen/drivers/vpci/Makefile           |   3 +-
>> xen/drivers/vpci/header.c           |   2 +
>> xen/include/asm-arm/domain.h        |   7 +-
>> xen/include/asm-arm/pci.h           |  85 ++++++++
>> xen/include/asm-x86/pci.h           |   8 +-
>> xen/include/public/arch-arm.h       |  21 +-
>> xen/include/public/domctl.h         |   4 +-
>> xen/include/xen/hypercall.h         |   4 +
>> xen/include/xen/pci.h               |   2 +
>> 36 files changed, 1168 insertions(+), 61 deletions(-)
>> create mode 100644 xen/arch/arm/pci/ecam.c
>> create mode 100644 xen/arch/arm/pci/pci-access.c
>> create mode 100644 xen/arch/arm/pci/pci-host-common.c
>> create mode 100644 xen/arch/arm/pci/pci-host-generic.c
>> create mode 100644 xen/arch/arm/pci/pci-host-zynqmp.c
>> create mode 100644 xen/arch/arm/vpci.c
>> create mode 100644 xen/arch/arm/vpci.h
>> create mode 100644 xen/drivers/pci/physdev.c
>>=20
>> --=20
>> 2.25.1
>>=20



From xen-devel-bounces@lists.xenproject.org Thu Oct 07 22:07:29 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Oct 2021 22:07:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.204072.359273 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYbXu-0006Ve-4h; Thu, 07 Oct 2021 22:07:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 204072.359273; Thu, 07 Oct 2021 22:07:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYbXu-0006VX-1H; Thu, 07 Oct 2021 22:07:22 +0000
Received: by outflank-mailman (input) for mailman id 204072;
 Thu, 07 Oct 2021 22:07:19 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mYbXr-0006VN-RO; Thu, 07 Oct 2021 22:07:19 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mYbXr-0005PQ-Jg; Thu, 07 Oct 2021 22:07:19 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mYbXr-0000BU-AV; Thu, 07 Oct 2021 22:07:19 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mYbXr-0000Qw-A0; Thu, 07 Oct 2021 22:07:19 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=ROpYNXVHwPKQxlIn0Us9vtGKwR+DiUFKzL/CXBOExxM=; b=jYZiDcNcN/bTPqAjDs112k58ZH
	uQmFps3FU2CWphX5Mjias+nOKoC1q6btI6lQR8KMhfmk6I2pyO+8Yrlvwfx0P8OeQOu6NtGfeSaHA
	70BdRsd1+8S1zGGJAjLTZunSx31myiUFiVUgacryVYeBAebWSb78g4FIrIHs0d0lrQfE=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165394-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 165394: regressions - FAIL
X-Osstest-Failures:
    linux-linus:test-armhf-armhf-xl-credit1:guest-start/debian.repeat:fail:regression
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=60a9483534ed0d99090a2ee1d4bb0b8179195f51
X-Osstest-Versions-That:
    linux=deacdb3e3979979016fcd0ffd518c320a62ad166
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 07 Oct 2021 22:07:19 +0000

flight 165394 linux-linus real [real]
flight 165421 linux-linus real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/165394/
http://logs.test-lab.xenproject.org/osstest/logs/165421/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-armhf-armhf-xl-credit1 18 guest-start/debian.repeat fail REGR. vs. 152332

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail baseline untested
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 152332
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 152332
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 152332
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 152332
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 152332
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152332
 test-armhf-armhf-xl-rtds     18 guest-start/debian.repeat    fail  like 152332
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 152332
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 linux                60a9483534ed0d99090a2ee1d4bb0b8179195f51
baseline version:
 linux                deacdb3e3979979016fcd0ffd518c320a62ad166

Last test of basis   152332  2020-07-31 19:41:23 Z  433 days
Failing since        152366  2020-08-01 20:49:34 Z  432 days  744 attempts
Testing same since   165394  2021-10-06 03:21:09 Z    1 days    1 attempts

------------------------------------------------------------
7366 people touched revisions under test,
not listing them all

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 2281602 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Oct 07 23:01:02 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Oct 2021 23:01:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.204124.359323 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYcNc-0006E2-WB; Thu, 07 Oct 2021 23:00:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 204124.359323; Thu, 07 Oct 2021 23:00:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYcNc-0006Dv-TG; Thu, 07 Oct 2021 23:00:48 +0000
Received: by outflank-mailman (input) for mailman id 204124;
 Thu, 07 Oct 2021 23:00:48 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=7uL+=O3=epam.com=prvs=0914b18df8=volodymyr_babchuk@srs-us1.protection.inumbo.net>)
 id 1mYcNc-0006Dp-8J
 for xen-devel@lists.xenproject.org; Thu, 07 Oct 2021 23:00:48 +0000
Received: from mx0b-0039f301.pphosted.com (unknown [148.163.137.242])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 4fe35676-4b7a-42a9-acc7-03f7d5a373bf;
 Thu, 07 Oct 2021 23:00:45 +0000 (UTC)
Received: from pps.filterd (m0174683.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.0.43) with SMTP id 197L8x4h023298;
 Thu, 7 Oct 2021 23:00:42 GMT
Received: from eur03-ve1-obe.outbound.protection.outlook.com
 (mail-ve1eur03lp2052.outbound.protection.outlook.com [104.47.9.52])
 by mx0b-0039f301.pphosted.com with ESMTP id 3bj8j3r7an-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Thu, 07 Oct 2021 23:00:42 +0000
Received: from PAXPR03MB7594.eurprd03.prod.outlook.com (2603:10a6:102:201::14)
 by PAXPR03MB8099.eurprd03.prod.outlook.com (2603:10a6:102:220::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.19; Thu, 7 Oct
 2021 23:00:39 +0000
Received: from PAXPR03MB7594.eurprd03.prod.outlook.com
 ([fe80::24db:d530:e190:518b]) by PAXPR03MB7594.eurprd03.prod.outlook.com
 ([fe80::24db:d530:e190:518b%6]) with mapi id 15.20.4587.019; Thu, 7 Oct 2021
 23:00:39 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4fe35676-4b7a-42a9-acc7-03f7d5a373bf
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ZXbrgDwmQauuYRGADdgMTUOntIYUZlm2Bgl/7YiIL2PG+6HJ0Zt86ptUq36sDWG2ULO5vJn+IbkfhZdk3KM8NKgNzsHL+YQmG7j4b7EgFawY9xwDDe7SVs76KY7jf0kB4rssgpsqATU5BK5cVQIjTjD9ObZYq8RIuwYuNY3pbTg/c9ZjGce20EsC+HSuJEufhkP/OR2P07NL4K+i6gW6qsUKz20lBhn08wDz5Ttku30BVCXACBkJnJQvFwXVLkXLTgvfRuw/bDl6nfvaJDRHB9hlTV54P+igHUe3EyAshRbh2d+A9VISBFNZd4qIpR9efZWK2GB45JhHhz3Qh+RSCg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=B14tgna0rLjL4hdMexFC2pYaUgMZvoJ93f2pZ3K1k4Y=;
 b=bzAOkTVPNVNuqixnse28qbc2L++znSpUokFJE8yDJTkPXVdEjfXI5K05moB4yHPpqTC8euhOocLstS7BK25QY/Trn/NntbLY++VlmvULVxng2/KNQUTlX85wbQCdFN1HwZ6FJHo3P7dyNj7bZh7AlwYPpHwNQRBicaXd/nG9hNoYg77GREQtClFPTSAeEKEdAvn7SPdMExCwDZy1hJRC1ewf+z2nsZO8YnQv3OB8XpV8+nnnseMo3tvFls81g3slk67TvfAVrLVE7YmvzXwq+SxKsDf8fh8da2NEQydoGmxXxAuZQ/CQ2BMtOQpwbY2yQeJuIpUNunNnQbOsdsDHxw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=B14tgna0rLjL4hdMexFC2pYaUgMZvoJ93f2pZ3K1k4Y=;
 b=ER/0iIRozUrjrtTYwHQg3vB/UMWPXvu8sSv3Z3YKF7fQEMEJMC+zp9SaUP5jG1ixfkrE4SUUB5wxklW2Wy9jVUnyJNTDIDljsFHpBsAX3MLtZbatVu+2EN2W9BZeidMdQ3s5+qYQSu7THal+UsHr08wbK/0eJWvHs4yf2t/mnz6C0wG0D2pCDLQjI3iQhx4eth1iGgd6dbkjehJiJF0Q0xcTPqoibeeotN+md3FOqnNx+jqQ8HCeGc508bY5fFoc797k6XyO5EjC+iea5BBXPKYr7pIjnJiqmmDyBFtmbS94SQeqq0xv/cOodiMJAJUZmuRT3psA94TYIIMkB1Oouw==
From: Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
To: Stefano Stabellini <sstabellini@kernel.org>
CC: Oleksandr <olekstysh@gmail.com>,
        "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Julien Grall <julien@xen.org>, Julien Grall
	<jgrall@amazon.com>
Subject: Re: [PING] Re: [PATCH] xen/arm: optee: Allocate anonymous domheap
 pages
Thread-Topic: [PING] Re: [PATCH] xen/arm: optee: Allocate anonymous domheap
 pages
Thread-Index: 
 AQHXoyUNSkY32SPluU6N5DMbFmm656uyJ0MAgAAJFoCAE/PzgIAAsCsAgAESVACAAFOXgIAAGYYA
Date: Thu, 7 Oct 2021 23:00:39 +0000
Message-ID: <87k0ioqw2x.fsf@epam.com>
References: <1630935741-17088-1-git-send-email-olekstysh@gmail.com>
 <alpine.DEB.2.21.2109231308200.17979@sstabellini-ThinkPad-T480s>
 <87bl4jrovq.fsf@epam.com> <81f7699b-69c1-da52-a1a7-5000343bf872@gmail.com>
 <alpine.DEB.2.21.2110061639050.3209@sstabellini-ThinkPad-T480s>
 <87r1cwra4t.fsf@epam.com>
 <alpine.DEB.2.21.2110071357160.414@sstabellini-ThinkPad-T480s>
In-Reply-To: <alpine.DEB.2.21.2110071357160.414@sstabellini-ThinkPad-T480s>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
user-agent: mu4e 1.6.5; emacs 27.2
authentication-results: kernel.org; dkim=none (message not signed)
 header.d=none;kernel.org; dmarc=none action=none header.from=epam.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 806015fe-817c-4ec7-49ca-08d989e6485d
x-ms-traffictypediagnostic: PAXPR03MB8099:
x-ms-exchange-transport-forked: True
x-microsoft-antispam-prvs: 
 <PAXPR03MB8099E16E20885FC49983CEEBE6B19@PAXPR03MB8099.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:8882;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 8aIBi7eaqR9JAJFfM1MYVCyogW893+tDMMb1wbFjB4Vwp9bfc857/SIMIY0bisQI1/9weAxf+QPYD++B6WEeodwZG6BVx1IrZ3BOiOlaLorFenxRRzNgYZyvwdd9+Ij20jl0xSPun1YBpJmNlO6i+1kmLbTOskJsl3CL7gL4LLkdJKGmGsy5KDtegMh7dhiP94AMJl5v29DSo3+INt8uVyJ2zsQqJzFgTSFlAlZTJLD1Kxjt6PRxrZ2l1N0MMB/61TrWjYtZQW45xToI+5UlF0O1NrcwvoKp1np0fT/5hS/aZFaoE74Die/cCpGLNwD/yrUc18xTvVXuwgwpCO98vWswxGKi8Rm1ZefkfWvulFMG6yyxXn5HjpayIJXNslXWXfeTzjpVBSY+35deCTnml1YIzlVSHf5maHWizSFNG1tm6aN5BWV3NoHFG/1gJC/9wymH9r4EYEHiA0gXKy8dyQ4Oi2u+EhynOQRFEuFtLr9JQCCY3UrIPokD7Mn0lZo1JkJuHa+x+7pG0Dzp5g+0h1o1VY9bqfEGZYjJC1qdN+aOSrcMqVorKSgTFTpvr43xuek0+UDzoYoasPeJx3ISr+QLxqFfggVeGL0+olQsZLtPhvZNH6VkehKCwM5ke7ICdpioQNtszDEDgjQe7CIHtquuxMeECVF/ntSQqvARbfeDgS2VxFA4CM1nHtOTdhTRXO11/GLRtUppIr+XTlexDg==
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR03MB7594.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(36756003)(30864003)(316002)(2906002)(66476007)(66556008)(91956017)(186003)(86362001)(76116006)(53546011)(83380400001)(6506007)(71200400001)(508600001)(55236004)(66946007)(64756008)(66446008)(6512007)(8936002)(54906003)(8676002)(4326008)(26005)(122000001)(6916009)(2616005)(38070700005)(5660300002)(38100700002)(6486002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?iso-8859-1?Q?3ZykZNawuB0Bi5HkIc9jSxLN2SoXKa8fXpT1ZsVNOgoRQwz058z5f83aIU?=
 =?iso-8859-1?Q?Ns6xvjXijsqwqYIrPKHFMHq0wysZcB2WRqrtSDGYeJ9a575u1RP0ultDCj?=
 =?iso-8859-1?Q?gZTuP82usRwjYorbdYyRoWHf1Clxm6icBGtzx2wjezpRdKq2oxDiJtM9Sq?=
 =?iso-8859-1?Q?S3QLU3dRbuF6VKNhpHn98ZjWl5yULDGtaow7qY3yoOcMY5dAKvRJ5kYsPi?=
 =?iso-8859-1?Q?z5RknshfXi0S2PFnkeVXd4E1axo7zmyT7xiq+Nv+TPyW8NG8ne1HSalzuE?=
 =?iso-8859-1?Q?wHFYC4nOCdAfADDMJFal9JfkReB1JoDfzl1odXQ/As9NixTJsvEa0zCT1A?=
 =?iso-8859-1?Q?y3bnLLlEgmNA1HUft+Z7GUj7GJtxR3GjOkjgYXsjbdy+C5xd0eaGDAEo1N?=
 =?iso-8859-1?Q?bLs86gVwT90D4l7y/oKaVsHpO57OVbQoc/VzcQzVXQ4KGIKnRtMfoStpTc?=
 =?iso-8859-1?Q?PewCn8Z7YmTDxaI8J9lZARljEL7tNjqWw73MZ92uKVnKQsYqM8Rb+GiW8T?=
 =?iso-8859-1?Q?DP4CCKTYFei642njrFO8sw+OL/HRlgWYIJERXKyITUsuzji9TifPTARgur?=
 =?iso-8859-1?Q?zl8NuOPnXeGuUe4bMazBFbhGjcwAVf+luNeSh/DFEXOcKr+VhImeWSXiWm?=
 =?iso-8859-1?Q?uh0UAQ/JCRubJNRqPKfAsNRA1aIVnrk+GsAxtTXCSDn1AYZz8Ryh7bFUdi?=
 =?iso-8859-1?Q?7nEUMN7dkiPqCif6C9IeU/XckFYMjExUsZulY8CX/IzdhhvokoeOcEFqoU?=
 =?iso-8859-1?Q?i27KW/sIVvGcJyojr8vzGfQHnm4qbBaPoIuOHlL8YV6ngwMy4yrqLjl9Tu?=
 =?iso-8859-1?Q?3ek2yjGN88H54geeg4LcC0nPNnuOylEcFrsI9VhbJAINOhlEjx5BrIZzzb?=
 =?iso-8859-1?Q?L1vvH46uy1GjDayoHHIdhzTp5XjaC4LsZXOfQo2XcaWyOiibFUur81V8Cz?=
 =?iso-8859-1?Q?cBx6Z89gJ+gUs5/OG2ebQ75iYxn2QOHo5+wWlwUVTpks3kcLY+Kc5TWFAI?=
 =?iso-8859-1?Q?+DH5tDhjpWDntNZtHBEIsaJxTAICMcffgQs9+3xqmQ1pY+6dq4YNA2YBwT?=
 =?iso-8859-1?Q?NAlPWnRvruUSo9RsLMTaER1xW8BEq+QE+SVf5jqeDXA+r2dH1jzs0ZP3+V?=
 =?iso-8859-1?Q?KIoTTmMdow9VLGHpSm6FFDHv2EPTudZXzVFujbakuFva7svED5kxM2gnQe?=
 =?iso-8859-1?Q?iShAPPYP+7JUNjbHvEfwU64u1dwaVDWzZdM1kmAHoIcOo7JzkoU4ezS0VO?=
 =?iso-8859-1?Q?Ee5MwP+cc9kpJJ3VJ7x+FDmmjec4I+B88M1u/x6g5edzg1ARunGVcFHkLi?=
 =?iso-8859-1?Q?SR7dAlS4dy8PtGAO0+2kitQGeEYnjfIHXs6Ss2844C+i6/aQesuNialsme?=
 =?iso-8859-1?Q?q1k7ex+ckl?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PAXPR03MB7594.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 806015fe-817c-4ec7-49ca-08d989e6485d
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Oct 2021 23:00:39.7709
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: TjuVPSaKH9uIC7I9ZJyU91HmhYCaZCIYOYmVOKNCuwev8G75Go//DzmwygJ7Cc+d7SSYz7QDhpLE1wtL4zUdGwhqzR6QGp5R2XYtF0+/xSY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR03MB8099
X-Proofpoint-GUID: -mRsoy8e48sLZyNPCQeVvLStfjzvFfFN
X-Proofpoint-ORIG-GUID: -mRsoy8e48sLZyNPCQeVvLStfjzvFfFN
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.391,FMLib:17.0.607.475
 definitions=2021-10-07_05,2021-10-07_02,2020-04-07_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0
 spamscore=0 bulkscore=0 mlxscore=0 suspectscore=0 clxscore=1015
 phishscore=0 adultscore=0 impostorscore=0 priorityscore=1501
 malwarescore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx
 scancount=1 engine=8.12.0-2109230001 definitions=main-2110070144


Hi,

Stefano Stabellini <sstabellini@kernel.org> writes:

> On Thu, 7 Oct 2021, Volodymyr Babchuk wrote:
>> Hi Stefano,
>>=20
>> Stefano Stabellini <sstabellini@kernel.org> writes:
>>=20
>> > On Wed, 6 Oct 2021, Oleksandr wrote:
>> >> Hello all
>> >>=20
>> >> Gentle reminder.
>> > =20
>> > Many thanks for the ping, this patch fell off my radar.
>> >
>> >
>> > =20
>> >> On 23.09.21 23:57, Volodymyr Babchuk wrote:
>> >> > Hi Stefano,
>> >> >=20
>> >> > Stefano Stabellini <sstabellini@kernel.org> writes:
>> >> >=20
>> >> > > On Mon, 6 Sep 2021, Oleksandr Tyshchenko wrote:
>> >> > > > From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>> >> > > >=20
>> >> > > > Allocate anonymous domheap pages as there is no strict need to
>> >> > > > account them to a particular domain.
>> >> > > >=20
>> >> > > > Since XSA-383 "xen/arm: Restrict the amount of memory that dom0=
less
>> >> > > > domU and dom0 can allocate" the dom0 cannot allocate memory out=
side
>> >> > > > of the pre-allocated region. This means if we try to allocate
>> >> > > > non-anonymous page to be accounted to dom0 we will get an
>> >> > > > over-allocation issue when assigning that page to the domain.
>> >> > > > The anonymous page, in turn, is not assigned to any domain.
>> >> > > >=20
>> >> > > > CC: Julien Grall <jgrall@amazon.com>
>> >> > > > Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.=
com>
>> >> > > > Acked-by: Volodymyr Babchuk <volodymyr_babchuk@epam.com>
>> >> > > Only one question, which is more architectural: given that these =
pages
>> >> > > are "unlimited", could the guest exploit the interface somehow to=
 force
>> >> > > Xen to allocate an very high number of anonymous pages?
>> >> > >=20
>> >> > > E.g. could a domain call OPTEE_SMC_RPC_FUNC_ALLOC in a loop to fo=
rce Xen
>> >> > > to exaust all memory pages?
>> >> > Generally, OP-TEE mediator tracks all resources allocated and impos=
es
>> >> > limits on them.
>> >> >=20
>> >> > OPTEE_SMC_RPC_FUNC_ALLOC case is a bit different, because it is iss=
ued
>> >> > not by domain, but by OP-TEE itself. As OP-TEE is more trusted piec=
e of
>> >> > system we allow it to request as many buffers as it wants. Also, we=
 know
>> >> > that OP-TEE asks only for one such buffer per every standard call. =
And
>> >> > number of simultaneous calls is limited by number of OP-TEE threads=
,
>> >> > which is quite low: typically only two.
>> >
>> > So let me repeat it differently to see if I understood correctly:
>> >
>> > - OPTEE_SMC_RPC_FUNC_ALLOC is only called by OP-TEE, not by the domain
>> > - OPTEE is trusted and only call it twice anyway
>>=20
>> Correct.
>>=20
>> > I am OK with this argument, but do we have a check to make sure a domU
>> > cannot issue OPTEE_SMC_RPC_FUNC_ALLOC?
>>=20
>> domU can't issue any RPC, because all RPCs are issued from OP-TEE
>> side. This is the nature of RPC - OP-TEE requests Normal World for some
>> service. But of course, Normal World can perform certain actions that
>> will make OP-TEE to issue a RPC. I discuss this in depth below.
>>=20
>> >
>> > Looking at the patch, there are other two places, in addition to
>> > OPTEE_SMC_RPC_FUNC_ALLOC, where the anonymous memory pages can be
>> > allocated:
>> >
>> > 1) copy_std_request
>> > 2) translate_noncontig
>> >
>> > We need to prove that neither 1) or 2) can result in a domU exausting
>> > Xen memory.
>> >
>> > In the case of 1), it looks like the memory is freed before returning =
to
>> > the DomU, right? If so, it should be no problem?
>>=20
>> Yes, mediator makes shadow copy of every request buffer to hide
>> translated addresses from the guest. Number of requests is limited by
>> number of OP-TEE threads.
>>=20
>> > In the case of 2), it looks like the memory could outlive the call whe=
re
>> > it is allocated. Is there any kind of protection against issuing
>> > something like OPTEE_MSG_ATTR_TYPE_TMEM_INOUT in a loop? Is it OP-TEE
>> > itself that would refuse the attempt? Thus, the idea is that
>> > do_call_with_arg will return error and we'll just free the memory ther=
e?
>>=20
>> Well, translate_noncontig() calls allocate_optee_shm_buf() which counts
>> all allocated buffers. So you can't call it more than
>> MAX_SHM_BUFFER_COUNT times, without de-allocating previous memory. But,
>> thanks to your question, I have found a bug there: memory is not freed
>> if allocate_optee_shm_buf() fails. I'll prepare patch later today.
>>=20
>> > I cannot see a check for errors returned by do_call_with_arg and memor=
y
>> > freeing done because of that. Sorry I am not super familiar with the
>> > code, I am just trying to make sure we are not offering to DomUs an ea=
sy
>> > way to crash the system.
>>=20
>> I tried to eliminate all possibilities for a guest to crash the
>> system. Of course, this does not mean that there are none of them.
>>=20
>> And yes, code is a bit hard to understand, because calls to OP-TEE are
>> stateful and you need to account for that state. From NW and SW this
>> looks quite fine, because state is handled naturally. But mediator sits
>> in a middle, so it's implementation is a bit messy.
>>=20
>> I'll try to explain what is going on, so you it will be easier to
>> understand logic in the mediator.
>>=20
>> There are two types of OP-TEE calls: fast calls and standard calls. Fast
>> call is simple: call SMC and get result. It does not allocate thread
>> context in OP-TEE and is non-preemptive. So yes, it should be fast. It
>> is used for simple things like "get OP-TEE version" or "exchange
>> capabilities". It is easy to handle them in mediator: just forward
>> the call, check result, return it back to a guest.
>>=20
>> Standard calls are stateful. OP-TEE allocates thread for each call. This
>> call can be preempted either by IRQ or by RPC. For consistency IRQ
>> return is also considered as special type of RPC. So, in general one
>> standard call can consist of series of SMCs:
>>=20
>> --> SMC with request
>> <-- RPC return (like IRQ)
>> --> SMC "resume call"
>> <-- RPC return (like "read disk")
>> --> SMC "resume call"
>> <-- RPC return (like "send network packet")
>> --> SMC "resume call"
>> ...
>> <-- Final return
>>=20
>> There are many types of RPCs: "handle IRQ", additional shared buffer
>> allocation/de-allocation, RPMB access, disks access, network access,
>> synchronization primitives (when OP-TEE thread is gets blocked on a
>> mutex), etc.
>>=20
>> Two more things that makes all this worse: Normal World can register
>> shared buffer with OP-TEE. Such buffer can live indefinitely
>> long. Also, Normal World decides when to resume call. For example,
>> calling process can be preempted and then resumed seconds
>> later. Misbehaving guest can decide to not resume call at all.
>>=20
>> As I said, I tried to take all this things into account. There are
>> basically 3 types of objects that can lead to memory allocation on Xen
>> side:
>>=20
>> 1. Standard call context. Besides memory space for struct optee_std_call
>> itself it allocates page for a shadow buffer, where argument addresses
>> are translated by Xen. Number of this objects is limited by number of
>> OP-TEE threads:
>>=20
>>     count =3D atomic_add_unless(&ctx->call_count, 1, max_optee_threads);
>>     if ( count =3D=3D max_optee_threads )
>>         return ERR_PTR(-ENOSPC);
>>=20
>> 2. Shared buffer. This is a buffer shared by guest with OP-TEE. It can
>> be either temporary buffer which is shared for one standard call
>> duration, or registered shared buffer, which is remains active until it
>> is de-registered. This is where translate_noncontig() comes into play.
>> Number of this buffers is limited in allocate_optee_shm_buf():
>>=20
>>     count =3D atomic_add_unless(&ctx->optee_shm_buf_count, 1,
>>                               MAX_SHM_BUFFER_COUNT);
>>     if ( count =3D=3D MAX_SHM_BUFFER_COUNT )
>>         return ERR_PTR(-ENOMEM);
>>=20
>> 3. Shared RPC buffer. This is very special kind of buffer. Basically,
>> OP-TEE needs some shared memory to provide RPC call parameters. So it
>> requests buffer from Normal World. There is no hard limit on this from
>> mediator side, because, as I told earlier, OP-TEE itself limits number
>> of this buffers. There is no cases when more that one buffer will be
>> allocated per OP-TEE thread. This type of buffer is used only to process
>> RPC requests themselves. OP-TEE can request more buffers via RPC, but
>> they will fall to p.2: NW uses separate request to register buffer and
>> then returns its handle in the preempted call.
>>=20
>>=20
>> Apart from those two limits, there is a limit on total number of pages
>> which is shared between guest and OP-TEE: MAX_TOTAL_SMH_BUF_PG. This
>> limit is for a case when guest tries to allocate few really BIG buffers.
>>=20
>>=20
>> > It looks like they could be called from one of the OPTEE operations th=
at
>> > a domU could request? Is there a limit for them?
>>=20
>> Yes, there are limits, as I described above.
>>=20
>> Also, bear in mind that resources available to OP-TEE are also quite
>> limited. So, in case of some breach in mediator, OP-TEE will give up
>> first. This of course is not an excuse to have bugs in the mediator...
>
> OK, thanks for the explanation. The reasons for my questions is that if
> the allocations are using the memory of DomU, then at worst DomU can run
> out of memory. But if the allocations are using anonymous memory, then
> the whole platform might run out of memory. We have issued XSAs for
> things like that in the past.
>
> This is why I am worried about this patch: if we apply it we really
> become reliant on these limits being implemented correctly. A bug can
> have much more severe consequences.

Agree.

> As you are the maintainer for this code, and this code is not security
> supported, I'll leave it up to you (also see the other email about
> moving optee to "supported, not security supported").

Yes, I've seen this email. Just didn't had time to write followup.

> However, maybe a different solution would be to increase max_pages for a
> domain when optee is enabled? Maybe just by a few pages (as many as
> needed by the optee mediator)? Because if we did that, we wouldn't risk
> exposing DOS attack vectors for every bug in the mediator limits checks.
>
> The below adds a 10 pages slack.

Well, I didn't know that such option is available. If this is a valid
approach and there are no objections from other maintainers, I'd rather
use it.

Only one comment there is about number of pages. Maximal number of
domheap pages used per request is 6: one for request itself, one for RPC
buffer, 4 at most for request arguments. I checked OP-TEE configuration,
looks like some platforms allow up to 16 threads. This yields 6 * 16 =3D 96
pages in total. If this is acceptable I'd set TEE_SLACK to 96.

>
> diff --git a/xen/arch/arm/tee/tee.c b/xen/arch/arm/tee/tee.c
> index 3964a8a5cd..a3105f1a9a 100644
> --- a/xen/arch/arm/tee/tee.c
> +++ b/xen/arch/arm/tee/tee.c
> @@ -38,8 +38,11 @@ bool tee_handle_call(struct cpu_user_regs *regs)
>      return cur_mediator->ops->handle_call(regs);
>  }
> =20
> +#define TEE_SLACK (10)
>  int tee_domain_init(struct domain *d, uint16_t tee_type)
>  {
> +    int ret;
> +
>      if ( tee_type =3D=3D XEN_DOMCTL_CONFIG_TEE_NONE )
>          return 0;
> =20
> @@ -49,7 +52,15 @@ int tee_domain_init(struct domain *d, uint16_t tee_typ=
e)
>      if ( cur_mediator->tee_type !=3D tee_type )
>          return -EINVAL;
> =20
> -    return cur_mediator->ops->domain_init(d);
> +    ret =3D cur_mediator->ops->domain_init(d);
> +    if ( ret < 0 )
> +        return ret;
> +
> +    /*=20
> +     * Increase maxmem for domains with TEE, the extra pages are used by
> +     * the mediator
> +     */
> +    d->max_pages +=3D TEE_SLACK;
>  }
> =20
>  int tee_relinquish_resources(struct domain *d)


--=20
Volodymyr Babchuk at EPAM=


From xen-devel-bounces@lists.xenproject.org Thu Oct 07 23:09:49 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Oct 2021 23:09:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.204133.359333 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYcWH-000715-SZ; Thu, 07 Oct 2021 23:09:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 204133.359333; Thu, 07 Oct 2021 23:09:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYcWH-00070y-PR; Thu, 07 Oct 2021 23:09:45 +0000
Received: by outflank-mailman (input) for mailman id 204133;
 Thu, 07 Oct 2021 23:09:45 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mYcWG-00070o-Uk; Thu, 07 Oct 2021 23:09:44 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mYcWG-0006RE-Mj; Thu, 07 Oct 2021 23:09:44 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mYcWG-00041y-CI; Thu, 07 Oct 2021 23:09:44 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mYcWG-0007Fr-Bi; Thu, 07 Oct 2021 23:09:44 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=PnEFyLQ60MZZzrK3z92aEAskrczkuJFSXdWmhvfUxWs=; b=GVJy1pgTo9/tPNDuobD2foPeVb
	v7IYa1FR22fIkqQB5RRKc4JZixZkNtAR+xmfoLQ7XunYNeesSU55xgOgmyCf0PIlJNrp7JnQmgv2Y
	SQoiDYybHMreSK3A/WH9B70MFvAMbuxwC0NBexyrhp3Woo1x2biufZmBe6y+kgsD2fI8=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165420-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 165420: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=2075b410ee8087662c880213c3aca196fb7ade22
X-Osstest-Versions-That:
    xen=2a04f396a34c5a43b9a09d72e8c4f49c64066cce
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 07 Oct 2021 23:09:44 +0000

flight 165420 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165420/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  2075b410ee8087662c880213c3aca196fb7ade22
baseline version:
 xen                  2a04f396a34c5a43b9a09d72e8c4f49c64066cce

Last test of basis   165417  2021-10-07 16:02:53 Z    0 days
Testing same since   165420  2021-10-07 20:02:52 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Christian Lindig <christian.lindig@citrix.com>
  Jan Beulich <jbeulich@suse.com>
  Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
  Rahul Singh <rahul.singh@arm.com>
  Stefano Stabellini <stefano.stabellini@xilinx.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   2a04f396a3..2075b410ee  2075b410ee8087662c880213c3aca196fb7ade22 -> smoke


From xen-devel-bounces@lists.xenproject.org Thu Oct 07 23:25:14 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Oct 2021 23:25:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.204142.359348 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYclB-0000t2-9v; Thu, 07 Oct 2021 23:25:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 204142.359348; Thu, 07 Oct 2021 23:25:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYclB-0000sv-6T; Thu, 07 Oct 2021 23:25:09 +0000
Received: by outflank-mailman (input) for mailman id 204142;
 Thu, 07 Oct 2021 23:25:08 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=7uL+=O3=epam.com=prvs=0914b18df8=volodymyr_babchuk@srs-us1.protection.inumbo.net>)
 id 1mYclA-0000so-7v
 for xen-devel@lists.xenproject.org; Thu, 07 Oct 2021 23:25:08 +0000
Received: from mx0b-0039f301.pphosted.com (unknown [148.163.137.242])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id ceaf344a-27c5-11ec-800e-12813bfff9fa;
 Thu, 07 Oct 2021 23:25:07 +0000 (UTC)
Received: from pps.filterd (m0174683.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.0.43) with SMTP id 197L9H3Q023528;
 Thu, 7 Oct 2021 23:25:05 GMT
Received: from eur03-db5-obe.outbound.protection.outlook.com
 (mail-db5eur03lp2057.outbound.protection.outlook.com [104.47.10.57])
 by mx0b-0039f301.pphosted.com with ESMTP id 3bj8j3r8mt-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Thu, 07 Oct 2021 23:25:05 +0000
Received: from PAXPR03MB7594.eurprd03.prod.outlook.com (2603:10a6:102:201::14)
 by PAXPR03MB7578.eurprd03.prod.outlook.com (2603:10a6:102:1de::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18; Thu, 7 Oct
 2021 23:25:02 +0000
Received: from PAXPR03MB7594.eurprd03.prod.outlook.com
 ([fe80::24db:d530:e190:518b]) by PAXPR03MB7594.eurprd03.prod.outlook.com
 ([fe80::24db:d530:e190:518b%6]) with mapi id 15.20.4587.019; Thu, 7 Oct 2021
 23:25:02 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ceaf344a-27c5-11ec-800e-12813bfff9fa
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=kWACLVBep/EjGcDRWdem+cWhO6hib95j1FOykwWkA9NT0ZTy0PvqROtnWx2JzEm7JpB3CrdH+g8e382tmPRTijQyzfQ03jLW/KAFWDpqAE9PVDFFZheQ3melk2saaSc1Giog9094vC9l25I8N9HFF1h9+dnxp8L7u1IEnDyPr95D8azemaZ2tVdEQ+nimcDCUaEDCGuYPIXkEqVv/B13obboRJE4VJTBIsJsB4NFG6guP/vefKFabKr6Y0Bf9lDc/ANHktkGNlopncSHXRE0xWrsmmhca+EMTT7uC9WORNRzXUeUiP14Mb+2eCXs8hK3g7R0qvXYevH2D6uz9QMAUw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=fuZI90lAAIKpFQMzV5avlUK1NGDhGgySXt1h3s9njuo=;
 b=l+7l6Jj6Gmtqq1X+Zxke+ueA88IIt66o/0VroMMjJ1GIVdPuOTQYGuyTW3R7rw51Orb8CDFNNZjsik45cwEBt23FfRV3YRfOGOtM47HZTc1xQHoa7xcOwDUxTuHowndY6huPrPgyfJWDojXOdyyBaYFpVPz0H01q0BkoHOLEb/PyrQlu6JhnX8Vb37GwUpwzeM0Ya8Y5vCbQGrO6dFo42S8blhyL7doUJMHKbCaVl1BDGbp6qIiMoqPlTsoId5vnXlprYAN1oxnnwDgK3HGD4deqm1ORsd8JHeHPHJqUsD4aeUlBG5Ox0evxN7otTWMKi09jxBv3n8tv5asnqAhInA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=fuZI90lAAIKpFQMzV5avlUK1NGDhGgySXt1h3s9njuo=;
 b=PrLuqKfUgB/l0qNOGfo0gCRwgAW+krvv7wUH0cO874khYght3yUPbJ3AiuH+Pgp5vPYCxS/3paTkVuEjFIH9BmvW9pJCULx62MPlNHl0TVCQcTDUd+5RBUhH8NY/mWlFbVoexIX7VFpVFeqs3dlPJUzV/FeYfNEix7JniJn4hirLdP9aU2S/4tCLqlIEn6xAkCKWQDTQajvIuHBboXtAmxb1KzsSKafmlVWKoTSR0YRqmR1CojCNhBpiVcA4qStEMOQTemXbEwSCU7/YLRtBb+UCG62C9lb0U9u2ZfAQ7G7/H23fc58KKlaB5BDZ/HlVbNrafRBvlj7AfpQWDkWFHA==
From: Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
CC: "tee-dev@lists.linaro.org" <tee-dev@lists.linaro.org>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Stefano Stabellini <sstabellini@kernel.org>,
        Julien Grall <julien@xen.org>
Subject: [PATCH] xen/arm: optee: fix possible memory leaks
Thread-Topic: [PATCH] xen/arm: optee: fix possible memory leaks
Thread-Index: AQHXu9KNK+VfP9tRZUeeM3jP6MNf8A==
Date: Thu, 7 Oct 2021 23:25:02 +0000
Message-ID: <20211007232450.2036087-1-volodymyr_babchuk@epam.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-mailer: git-send-email 2.31.1
authentication-results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=epam.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 75f8227a-e4e4-45e3-6624-08d989e9b041
x-ms-traffictypediagnostic: PAXPR03MB7578:
x-ms-exchange-transport-forked: True
x-microsoft-antispam-prvs: 
 <PAXPR03MB7578C325A9835AE92CAF78AEE6B19@PAXPR03MB7578.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:4502;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 UPQ4mRQqzsK6uL2gy6jFIkMIhVYfpgzJ95kfMp8wclxz+M7SVrq6ssIl9szB0QPc6sbnPV8XTSzZX3CTnOjuvHGCPCh9ssItMKzkviKvrRyobTgHsToKySdQ1TlrqQjsYVloUJTwZURhT7wbg8OwS0hi5+e0iSmcmILlIIvib+6OyJE6ZWPlLtyJvb6gX7BMPADmwr8LqZEuysZDPAOiMFurRMBkGpNiFx/DgQPxnD7iupwKZCyPZFVRV1emNUYOxphq5oqUkwapyjxQiV0MypRpto8ePxd1rWHUyCvLECdWUg/GaZyHtEI0OHMRsZisPtqakuKjijgtpD13J8RPvoOrFWOqkpg4nJxYsW9/BfPOhVHKVQ+BKVDBB2MGxCmGAtpd3c1JKy8F75s6bxo/MltN3/Y/SVtpl6/OugxHFL1Cnh6pGFVr7EfBvXpzWjVQGKjyEVoBs9ra0uhyoEXnimFcA9JPxEzqDL0tpxOd9o0oI4BVDxl0xWw3YSr9kqWKaZ8uiu904Vi5CKxZG9iBrBnXBkVrqaLUMBcLpTkN7nY6CSmQDRXFKVBTJ2B31UZQU01DARW09/RPrQ4GkeRayIXJ0Z+1TNlaz/drDTz9k9N4EeS+DZ7AE5K1E8PrMGweEVSOqmjReJERtPpm9r0WIAJun7d354bWcnmt5gLBpMtSB+rdvRm7OpTb9FvS1uP1dS8PZOtyHw2kzE2nI17REw==
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR03MB7594.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(8676002)(66946007)(5660300002)(1076003)(6506007)(316002)(38070700005)(122000001)(6512007)(38100700002)(83380400001)(6486002)(66446008)(4326008)(91956017)(66556008)(76116006)(2616005)(26005)(8936002)(36756003)(6916009)(66476007)(71200400001)(2906002)(508600001)(86362001)(186003)(55236004)(64756008)(54906003);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?iso-8859-1?Q?MAZea0NHvgI8s+FYbR8E6X71MMEiomGS2cM0IWUO+tjFkoY0n4So3sF/82?=
 =?iso-8859-1?Q?ANJ0J4rtOT025Q02IWkVBvwtbLSJzHlAt5eXRUBOkenu7Wf2OLoHyL7beq?=
 =?iso-8859-1?Q?0hWB+vU4Lel/9ayBww6EZispkB2Kfz/twt0PWnegNg+VsamGkiWGl0RuvB?=
 =?iso-8859-1?Q?qZ/PT32PgIxgDZNV+mdeqcIBjmd7dvZu19cDhfAP1n9o9vWhUpdC2METQr?=
 =?iso-8859-1?Q?szwDvKkg2be2MeG3PSYPQ8Ue6BIdc3gNyRIkz0I9/jNxGq86hWgN2guahD?=
 =?iso-8859-1?Q?750lOscYuw1MPH5qfbRS/g4bxDvWjV3mUEvzhozo11CimpzSkPpK4fxHr6?=
 =?iso-8859-1?Q?rmQrOM7veO4Tog41xIO42J48twR1zvQsroZ08rLLwKLvnFdVGlDT07y0mx?=
 =?iso-8859-1?Q?1MFvCXI9lhx/puu4EdPIDQ8TqNCBgB/im1JGgIld5yTyr4JWuzORSHABw+?=
 =?iso-8859-1?Q?t0HmCZ/BVLXDPlkDrA3YoYD9DFiu+3vTwUmVjdW7Cq0uFY9DkCSa92Omm3?=
 =?iso-8859-1?Q?quarjPUsLfbcHjNA4Pu8fSAVfZRG5VLPgpbKzFGgQbsz28utYqxqQ5kyHr?=
 =?iso-8859-1?Q?VH10/zL97eqN4kIspVfjPZuukNngAanbABcCp+Z6sqmWTDANk9Qatmom9o?=
 =?iso-8859-1?Q?I8XTYHayQxMwqM63nE/phzoBT45NfRUi1L47hc3uUV3GyLRjYLbAgGwJ5H?=
 =?iso-8859-1?Q?e2Dyvu0lZrwnTXt68pr+6BFxc8fm7G20Ed1k4xWetgjvUnL7kUDq4Fg8ST?=
 =?iso-8859-1?Q?O9xQUDb5t3Ux2ZM06TI5WlGjDhYWMZWUd765TsQOSaf3Z4CJKp5ETsDSth?=
 =?iso-8859-1?Q?lG++4OnqkKvtIezrpWLCRhA19UiKulalUB3IZYZRyzBwnQb6ifyn01kqr+?=
 =?iso-8859-1?Q?72RVKUCpP9lcjRnslRdWtXb7S9yV5ZnSHF+YSDv21K0cz1nXZ+TlvXbNEU?=
 =?iso-8859-1?Q?mOZH1Kt5wnrNym3LfUoercqxUoa3XyCXhFonOIfLi0zgu0teMUI6GtEJBQ?=
 =?iso-8859-1?Q?nPz8YwB1OdM4CQtA5qFMX1xGy4ZPAO4Tp+R+fyLqnmC61BWBURmmeqkdZI?=
 =?iso-8859-1?Q?BguTlJbczK7Rj9vmZjTKWat+dt5ukeMqk18tC9nAsCwgNSIeerM/JdcRa2?=
 =?iso-8859-1?Q?nKKK9AIrp86yWv9MFqAGSNMZRwA2uoUKpSy6U7rx32m8wq+EiVwMumqA4G?=
 =?iso-8859-1?Q?poCvASJCcp3q9sd7Q7badgzYbttdgwGgvaNqanP5CMP5bF00dk+P8xm3QF?=
 =?iso-8859-1?Q?6CxOlb5W20M7IR5JOBrIhsFm5rKdEV5XP1JRWoIIx4SVqg4zwtxMpDNjF4?=
 =?iso-8859-1?Q?S+ogf5LxrXureALxuj1MT/jVq70TGOHnbX8dsGBgGswH4+1E/M4i9y6nAC?=
 =?iso-8859-1?Q?gxFo0nBndK?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PAXPR03MB7594.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 75f8227a-e4e4-45e3-6624-08d989e9b041
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Oct 2021 23:25:02.5942
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: HU2pi4R2hdWm5SnmMNrT0DH5afT3UB7ynNnK9F1XtwUu9fbsVc3dSlpLnN441ak+3OzOkYAAgV1WNOsQf8auqyKG4Y+NIzLiHtfAS9a8UBc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR03MB7578
X-Proofpoint-GUID: 7XLnpndXR_5HGvYjywyrb979z6_CFdM1
X-Proofpoint-ORIG-GUID: 7XLnpndXR_5HGvYjywyrb979z6_CFdM1
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.391,FMLib:17.0.607.475
 definitions=2021-10-07_05,2021-10-07_02,2020-04-07_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0
 spamscore=0 bulkscore=0 mlxscore=0 suspectscore=0 clxscore=1015
 phishscore=0 adultscore=0 impostorscore=0 priorityscore=1501
 malwarescore=0 mlxlogscore=992 classifier=spam adjust=0 reason=mlx
 scancount=1 engine=8.12.0-2109230001 definitions=main-2110070146

translate_noncontig() allocates domheap page for translated list
before calling to allocate_optee_shm_buf(), which can fail for number
of reason. Anyways, after fail we need to free the allocated page(s).

Another leak is possible if the same translate_noncontig() function
fails to get domain page. In this case it should free allocated
optee_shm_buf prior exit. This will also free allocated domheap page.

Signed-off-by: Volodymyr Babchuk <volodymyr_babchuk@epam.com>
---
 xen/arch/arm/tee/optee.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/xen/arch/arm/tee/optee.c b/xen/arch/arm/tee/optee.c
index 6df0d44eb9..131d2f9a8a 100644
--- a/xen/arch/arm/tee/optee.c
+++ b/xen/arch/arm/tee/optee.c
@@ -781,7 +781,10 @@ static int translate_noncontig(struct optee_domain *ct=
x,
     optee_shm_buf =3D allocate_optee_shm_buf(ctx, param->u.tmem.shm_ref,
                                            pg_count, xen_pgs, order);
     if ( IS_ERR(optee_shm_buf) )
+    {
+        free_domheap_pages(xen_pgs, order);
         return PTR_ERR(optee_shm_buf);
+    }
=20
     gfn =3D gaddr_to_gfn(param->u.tmem.buf_ptr &
                        ~(OPTEE_MSG_NONCONTIG_PAGE_SIZE - 1));
@@ -807,7 +810,7 @@ static int translate_noncontig(struct optee_domain *ctx=
,
         {
             guest_pg =3D get_domain_ram_page(gfn);
             if ( !guest_pg )
-                return -EINVAL;
+                goto free_shm_buf;
=20
             guest_data =3D __map_domain_page(guest_pg);
             xen_data =3D __map_domain_page(xen_pgs);
@@ -854,6 +857,7 @@ err_unmap:
     unmap_domain_page(guest_data);
     unmap_domain_page(xen_data);
     put_page(guest_pg);
+free_shm_buf:
     free_optee_shm_buf(ctx, optee_shm_buf->cookie);
=20
     return -EINVAL;
--=20
2.33.0


From xen-devel-bounces@lists.xenproject.org Thu Oct 07 23:32:54 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Oct 2021 23:32:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.204152.359359 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYcsb-0002Qp-3l; Thu, 07 Oct 2021 23:32:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 204152.359359; Thu, 07 Oct 2021 23:32:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYcsb-0002Qi-0g; Thu, 07 Oct 2021 23:32:49 +0000
Received: by outflank-mailman (input) for mailman id 204152;
 Thu, 07 Oct 2021 23:32:47 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=7uL+=O3=epam.com=prvs=0914b18df8=volodymyr_babchuk@srs-us1.protection.inumbo.net>)
 id 1mYcsZ-0002Qc-4T
 for xen-devel@lists.xenproject.org; Thu, 07 Oct 2021 23:32:47 +0000
Received: from mx0b-0039f301.pphosted.com (unknown [148.163.137.242])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id e009102a-27c6-11ec-8010-12813bfff9fa;
 Thu, 07 Oct 2021 23:32:45 +0000 (UTC)
Received: from pps.filterd (m0174681.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 197N4en8021891; 
 Thu, 7 Oct 2021 23:32:43 GMT
Received: from eur02-he1-obe.outbound.protection.outlook.com
 (mail-he1eur02lp2052.outbound.protection.outlook.com [104.47.5.52])
 by mx0b-0039f301.pphosted.com with ESMTP id 3bja7y01jb-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Thu, 07 Oct 2021 23:32:43 +0000
Received: from PAXPR03MB7594.eurprd03.prod.outlook.com (2603:10a6:102:201::14)
 by PAXPR03MB7561.eurprd03.prod.outlook.com (2603:10a6:102:1dc::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.21; Thu, 7 Oct
 2021 23:32:41 +0000
Received: from PAXPR03MB7594.eurprd03.prod.outlook.com
 ([fe80::24db:d530:e190:518b]) by PAXPR03MB7594.eurprd03.prod.outlook.com
 ([fe80::24db:d530:e190:518b%6]) with mapi id 15.20.4587.019; Thu, 7 Oct 2021
 23:32:41 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e009102a-27c6-11ec-8010-12813bfff9fa
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=EaQ1+CBKtHusJvTn1dWFHPeS9kaIy30Vy/v6j/lCexmIyfo5XIoamocpqU3X6ZE6xfMpny3k0TDiwx+OIBfVopjD/rAL+QzxwGOwON77LI7cdXYKtUohmSsNkqJMuIhD4VD1bP7K2FEhcS8FUvSMfVZZqYgM2lYc7VByWWR0f04N7wwNlGQSama3FH0N7kLsns6luBNV/bhK+amn8PigMX3l4qoSA/XXNN7xgcnS2OVIn/vfSEpQq1rlXwE6TEW5h4MGKjgFFnCStiZ0i/pCjrZ01Y0MJ9IiDvXSTtd2J3ozRpLcQvDbXG2PUTHOJnviwdVczLSXQmsX/Cb4npRuBA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=6l8artcHo1hOL5v26iTr6RvV93yEMXXxdFgbI0hHPjk=;
 b=MN4HCVXz7YRhNbObFKe0sB/L58yxaRb9I5U7YH1e3nav+mB8u0wVBIjUcmmVwHF5JnQVbj0+uJ+IqyijJrdPE4/qRjWta8dikDpBi6RFKocZb2AN9fmxxsHaXU8a8qy7KEAQDI2p2BCfgB+m9jXTOSaHQ3nblp1Y5cWN7NTU6A3KdY9JG3mrSxk1Hmryys4HLu5RgmP1IMS5hMifUqdaP6m8+K8cKdVSbnRX6o2AXwNqM+HIQv+aUxnxpvAUhNnh/eYto8kT56wEc7FPZbIo0l6XfKmtyi4nEAoCpA1bpQYd7KTAFkcQ3u4np0MfR1Ihk0Xw96OavjY7rm9lXxfp0w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=6l8artcHo1hOL5v26iTr6RvV93yEMXXxdFgbI0hHPjk=;
 b=JQ/2q3ZNVHW9j9Rn6XBbUWgPYoZeh7o59mYBp0TraBArxlr9d85wd6Ad9rZtxOi5F5w0mSWnhOlQaODuNoziBIoe9/NL8aSNX2Uh2YqacS3qtnGf7R3b3xZ/n2NLTJG5g5efal0FLQQNa0k65AD6hwC/tyVRJSst5oNQ//E6n5yieluhTYVCmbjk6nhi2sJ7BbWW3yk5iS6wYEi4FPGeS0+Y69Z+G0ZdIO/0bXSJ2I/+vF+F3GK1Bi7BTaqTm5nJO403DMziffrnw3WbCMXgfjgEqXn342vYZKtXETSYuP/jthO0N8s3FpUpfGZct8eZNfBOu7ckJj79+XC3vU1y0w==
From: Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
To: Oleksandr <olekstysh@gmail.com>
CC: Stefano Stabellini <sstabellini@kernel.org>,
        Julien Grall
	<julien@xen.org>,
        "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        "tee-dev@lists.linaro.org"
	<tee-dev@lists.linaro.org>
Subject: Re: [PATCH] xen/arm: optee: Fix arm_smccc_smc's a0 for
 OPTEE_SMC_DISABLE_SHM_CACHE
Thread-Topic: [PATCH] xen/arm: optee: Fix arm_smccc_smc's a0 for
 OPTEE_SMC_DISABLE_SHM_CACHE
Thread-Index: AQHXs6cvn7zQUNndCEOzhQWRkGM4Xqu44f8AgA17pgCAAEHdAIABQq8AgABb1YA=
Date: Thu, 7 Oct 2021 23:32:40 +0000
Message-ID: <87czogqulj.fsf@epam.com>
References: <1632750850-28600-1-git-send-email-olekstysh@gmail.com>
 <alpine.DEB.2.21.2109272151260.5022@sstabellini-ThinkPad-T480s>
 <e612c225-cda6-2c41-bf20-73314ebceb02@xen.org>
 <alpine.DEB.2.21.2110061537310.3209@sstabellini-ThinkPad-T480s>
 <29e1696a-5664-25f4-b679-1f73020ecf97@gmail.com>
In-Reply-To: <29e1696a-5664-25f4-b679-1f73020ecf97@gmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
user-agent: mu4e 1.6.5; emacs 27.2
authentication-results: gmail.com; dkim=none (message not signed)
 header.d=none;gmail.com; dmarc=none action=none header.from=epam.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 52ddf15b-c077-493d-3ccd-08d989eac171
x-ms-traffictypediagnostic: PAXPR03MB7561:
x-ms-exchange-transport-forked: True
x-microsoft-antispam-prvs: 
 <PAXPR03MB7561049F49240379A9D5C85BE6B19@PAXPR03MB7561.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:9508;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 Sb9p0kSmPFTwMmhCPfqzOl0G1rr0kmH4pU0RfrVAjwgPr2VnpKAxEZIlU+xb6j/xzWrcsiE+vWZ61RgXtR4NukILYRwBtKGAdDc8aZh31BlCOSiwogwO8MN/GuwXExBVbah0WqofGjfNf0YUI8JbyFyh3o6+B9zJZfEn1HedqWDCDgU5ekntkTroJXsD2lR8bRZXvY5CU43YmUKZpACYvymdY024YGaJtND6sdZAGKdDCYLxIJjLt5+2XAA+2NxStzuZ+79LVaech1Z5bmFriSb7+Zd4s1/jEP4o8Lrtl+m11tBnBDKEcanwpsrCW2cfkPJ4ian0M+OmO05Oi/HeyMbwdWXCJ6Ha+91qUNwFAyS1X0l74XVZ2UMby1sAVFqm6JAis1cZBIPz+TwoC7RHbj7+uw1/rpptZi9obZeMm6xu5UezVvRhjDT/zE63GBjET+aYfuuCEYNsrdrzxMzq0wZZQrzezSoRNJ7ymnfriy+ARca6Zz1QW3N7C7RUb1jRd0aHH9WaiPnjhZ/o5GKJ92JLRT4yQdoVZ8KnVdG549gkPsPqJbLsMQ9wjCJOb3/yhflZmKmXdollAiWz79EE/8woTmnaW7CuvLKiQtuQiWOvS3dzYBxpJIR9PTLd74oehSWA4ITHGV+1peWdFhDWRjcdCZ1FxRFqksAvtvHRbyTaCd20PlHThQ5uFvbfDZ1VSBrl0ALPbl9DjhM+dmj97Q==
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR03MB7594.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(508600001)(83380400001)(6486002)(71200400001)(2616005)(86362001)(8676002)(8936002)(6512007)(38100700002)(5660300002)(6916009)(53546011)(122000001)(36756003)(6506007)(66556008)(76116006)(91956017)(4326008)(66446008)(66476007)(64756008)(66946007)(26005)(316002)(38070700005)(186003)(2906002)(55236004)(54906003);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?iso-8859-1?Q?srrYthoinTXkJINvOYdew5f52S6q89ZLUjLcE8MpztNgdOFhkepm0wwMyl?=
 =?iso-8859-1?Q?otO7PSwCFnXktbW5kh+j5trnK4DEaKx/f6J6j6Q68qRWrZri242uXe62Oc?=
 =?iso-8859-1?Q?gPD1YeZVsm3pQ5lELqieD2motiIPxYfsvVAPiljkORBLhn64eAGMinYsQl?=
 =?iso-8859-1?Q?xqaGOJGccIA1NiFvm9i+eqZxoWeqiB+ei/P5g2TYnOJA8FHg+sm0WYbm8y?=
 =?iso-8859-1?Q?YECw+p3dCC9ycXnNO29LvxrP4/atUDJADJuxy2m0+qfTr+NoJjmUZZV3BW?=
 =?iso-8859-1?Q?WZKLPRiBTL/YclAmCUhU6fggFRWGOXxCjSGX0guIJRWoznyiLnv0iLvL3V?=
 =?iso-8859-1?Q?i6eSZrndQ/FXWm1Y1ytivxIDgYL73ixloN0ukaYPVNvoSuGhKDrmlalFgW?=
 =?iso-8859-1?Q?5ggT6W03ArWNC8kv8LeWS+VPrE/nEv79rgnryyaX5H4ve071RMSkjFEXwh?=
 =?iso-8859-1?Q?1LKiI9FVLWEjYNvuqTj5x6PVP7bFQ0AtpI17mDUX2RFKUcGjbWVWGGMRDh?=
 =?iso-8859-1?Q?YujSQJlYiihTuJ0g4VTCWpFXe7ciGh+HEf3Yqdcb/aoeZHD+l8plFbf3Ar?=
 =?iso-8859-1?Q?Yi1/bO7q6F5GVDMp0JuTsToxzeyubbyc1WOjLRavxE6BcOEJiP5HjL0241?=
 =?iso-8859-1?Q?GFh82BboSwsRpIdK0byrOrM31Mbz/hyl1sRBTB9O/dKfHEQTz4+38JtADy?=
 =?iso-8859-1?Q?7HZ1lmKisMqBc2A9oSokGb4EQHt1LGbKfRup5uK+p7hMjWCPkKVF1cilRs?=
 =?iso-8859-1?Q?gPR6igP3PvHmmWpeopH8Uggry8mLkNOC2rRAioyXsUoBnFSXRlMmUldS/i?=
 =?iso-8859-1?Q?TwuHWGGsYL9UmkBwx//NanD8j7GGp0fVsjaejq4SlWo7VID4bG+ealcVf3?=
 =?iso-8859-1?Q?UjSIw7R6/8QZWrS8qcQ3wltpWkEdzCsuZBHm20SvhXwMwfDS4GUQjCPWFs?=
 =?iso-8859-1?Q?54vm2w4hLmvKIOdGDSAVikFl24AF88pDi5JuZTRKapygzDojpFCRVpqZaG?=
 =?iso-8859-1?Q?y2rFzzJhKG+nETR0P4azNWjuJzjWVhg7+7r8iryh/rR3NTQQFnWeSx0wBU?=
 =?iso-8859-1?Q?LccNm77BbBakkMv36kjNdAGX9DMYx3j7aAlaTTRZ6HHwvj7e2RD6B9gWnx?=
 =?iso-8859-1?Q?tLHqQiBBnMs9nBOiVGw6VJ4X4F1u9ZqFGD5t6rtlqxscwa+jzZ0lvb7sdI?=
 =?iso-8859-1?Q?lTwW63HCTBYKjo1z1HIpVFGf+S33AtIUZU8gks145dNKpMSdYsqJBEY8RC?=
 =?iso-8859-1?Q?Hkg0HG0j5OGo2+VotE+DxtwfMJ8wB0D4mDaFQexRpNSW2jPx6XG+B7uddj?=
 =?iso-8859-1?Q?lY36nZ2oPkRc/zmkBvTvInacPCL06qO3jgi7p0nQlIQ6yC941iTbPzag5t?=
 =?iso-8859-1?Q?GS6bSBG0wg?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PAXPR03MB7594.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 52ddf15b-c077-493d-3ccd-08d989eac171
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Oct 2021 23:32:40.9755
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 7CsnvIZwjn+1AaahMj9AtdPvhagfeD50Q8uMzpsVQnpWto48j3EHx/Y5q/efNf40x3rh5NfUEkT+CvFpQjHMOLwUOGs+KyOvzJtXcQL+Prk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR03MB7561
X-Proofpoint-GUID: fMkCNCbMvVKhxFzaTL77KvlvYLi05x3p
X-Proofpoint-ORIG-GUID: fMkCNCbMvVKhxFzaTL77KvlvYLi05x3p
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.391,FMLib:17.0.607.475
 definitions=2021-10-07_05,2021-10-07_02,2020-04-07_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 mlxlogscore=999
 spamscore=0 bulkscore=0 phishscore=0 lowpriorityscore=0 malwarescore=0
 adultscore=0 clxscore=1015 suspectscore=0 impostorscore=0
 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2109230001 definitions=main-2110070147


Hi Oleksandr, Stefano,

Oleksandr <olekstysh@gmail.com> writes:

> On 07.10.21 01:42, Stefano Stabellini wrote:
>
> Hi Stefano, Julien.
>
>> On Wed, 6 Oct 2021, Julien Grall wrote:
>>> Hi Stefano,
>>>
>>> On 28/09/2021 06:52, Stefano Stabellini wrote:
>>>> On Mon, 27 Sep 2021, Oleksandr Tyshchenko wrote:
>>>>> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>>>>>
>>>>> Fix a possible copy-paste error in arm_smccc_smc's first argument (a0=
)
>>>>> for OPTEE_SMC_DISABLE_SHM_CACHE case.
>>>>>
>>>>> This error causes Linux > v5.14-rc5
>>>>> (b5c10dd04b7418793517e3286cde5c04759a86de
>>>>> optee: Clear stale cache entries during initialization) to stuck
>>>>> repeatedly issuing OPTEE_SMC_DISABLE_SHM_CACHE call and waiting for
>>>>> the result to be OPTEE_SMC_RETURN_ENOTAVAIL which will never happen.
>>>>>
>>>>> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>>>> Acked-by: Stefano Stabellini <sstabellini@kernel.org>
>>>>
>>>> I added Fixes: and Backport: tags to the commit
>>> Per SUPPORT.MD, OP-TEE is still a technical preview. So I would argue t=
hat we
>>> should not do any backport because the feature itself is not officially
>>> considered supported.
>> Good point!
>>
>>
>>> That said, what's missing to make the feature officially supported?
>> If Oleksandr is also happy to make OP-TEE support in Xen "Supported" in
>> SUPPORT.md I'd be happy with that too. Specifically I suggest to change
>> it to:
>>
>> Status: Supported, not security supported
>>
>> Security Support is a bit of a heavy process and I am thinking that
>> "Supported, not security supported" would be an excellent next step.
>
> I would be happy, and can send a formal patch. But I am not an expert
> in this code.

I'm will be happy with this too. We are using this mediator in our
projects and I know that OP-TEE community adopted tests for
virtualization in theirs CI stack. So this is kind of official now.

Also, I helped other people to bring up virtualization on theirs
platforms, so there are other users for this feature besides EPAM and
Linaro.

> (looks like there are some TODO left in the code and I have no idea
> what are the implications)

Well, there were a lot of TODOs when I submitted initial
implementation. At that time it indeed wasn't ready for production. But
I eventually fixed almost all of them. Only one left now. It is about
very unlikely situation when one of guest pages in mapped at PA=3D0. I'm
not sure that is even possible at all.

--=20
Volodymyr Babchuk at EPAM=


From xen-devel-bounces@lists.xenproject.org Thu Oct 07 23:40:16 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Oct 2021 23:40:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.204161.359370 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYczh-0003wQ-SC; Thu, 07 Oct 2021 23:40:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 204161.359370; Thu, 07 Oct 2021 23:40:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYczh-0003wJ-P9; Thu, 07 Oct 2021 23:40:09 +0000
Received: by outflank-mailman (input) for mailman id 204161;
 Thu, 07 Oct 2021 23:40:08 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Ti8Z=O3=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1mYczg-0003wD-IP
 for xen-devel@lists.xenproject.org; Thu, 07 Oct 2021 23:40:08 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 9cb55147-7b3c-46f1-bc32-1f1a85dcf84e;
 Thu, 07 Oct 2021 23:40:06 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id D300161076;
 Thu,  7 Oct 2021 23:40:05 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9cb55147-7b3c-46f1-bc32-1f1a85dcf84e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1633650006;
	bh=lX+mCK6TAP/MNcaYYeGq9eC6WVSt1vFUACtjtvGn88Y=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=SzJeTN+5y/iXfiZt0eTENCJdpD4O+TCgyKtctOa72yBFY1cmZK8nmKyIs4eQGgq7e
	 fHO8SJtFM0PGXzshvqPREH+B9gtl4NdqbLm76p9Wg6bgg+LqLW6rPo6wCSjLkpcVVP
	 XLcNk6nUE90MC98ggbMcEHXrzls4CSBm+4GRtqdHJ1ewWK5kuMUXjXbglhvR4ZPcpD
	 gvd7vbHXNxYqGOV6l5Vv6W/jfXyB4/n2cXfP9CUaTr6Z3ifVIBl/a2OSCzJwFD440r
	 yI5OEx+I5zsPOVIL9RagxHR2VOWUsZB8XCvRz8shxINMs1yXLxq4Deb+oTeJ9Hs17Y
	 QKlmAzw7M05zg==
Date: Thu, 7 Oct 2021 16:40:05 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
cc: Stefano Stabellini <sstabellini@kernel.org>, 
    Oleksandr <olekstysh@gmail.com>, 
    "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, 
    Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>, 
    Julien Grall <julien@xen.org>, Julien Grall <jgrall@amazon.com>
Subject: Re: [PING] Re: [PATCH] xen/arm: optee: Allocate anonymous domheap
 pages
In-Reply-To: <87k0ioqw2x.fsf@epam.com>
Message-ID: <alpine.DEB.2.21.2110071637560.414@sstabellini-ThinkPad-T480s>
References: <1630935741-17088-1-git-send-email-olekstysh@gmail.com> <alpine.DEB.2.21.2109231308200.17979@sstabellini-ThinkPad-T480s> <87bl4jrovq.fsf@epam.com> <81f7699b-69c1-da52-a1a7-5000343bf872@gmail.com> <alpine.DEB.2.21.2110061639050.3209@sstabellini-ThinkPad-T480s>
 <87r1cwra4t.fsf@epam.com> <alpine.DEB.2.21.2110071357160.414@sstabellini-ThinkPad-T480s> <87k0ioqw2x.fsf@epam.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Thu, 7 Oct 2021, Volodymyr Babchuk wrote:
> > On Thu, 7 Oct 2021, Volodymyr Babchuk wrote:
> >> Hi Stefano,
> >> 
> >> Stefano Stabellini <sstabellini@kernel.org> writes:
> >> 
> >> > On Wed, 6 Oct 2021, Oleksandr wrote:
> >> >> Hello all
> >> >> 
> >> >> Gentle reminder.
> >> >  
> >> > Many thanks for the ping, this patch fell off my radar.
> >> >
> >> >
> >> >  
> >> >> On 23.09.21 23:57, Volodymyr Babchuk wrote:
> >> >> > Hi Stefano,
> >> >> > 
> >> >> > Stefano Stabellini <sstabellini@kernel.org> writes:
> >> >> > 
> >> >> > > On Mon, 6 Sep 2021, Oleksandr Tyshchenko wrote:
> >> >> > > > From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> >> >> > > > 
> >> >> > > > Allocate anonymous domheap pages as there is no strict need to
> >> >> > > > account them to a particular domain.
> >> >> > > > 
> >> >> > > > Since XSA-383 "xen/arm: Restrict the amount of memory that dom0less
> >> >> > > > domU and dom0 can allocate" the dom0 cannot allocate memory outside
> >> >> > > > of the pre-allocated region. This means if we try to allocate
> >> >> > > > non-anonymous page to be accounted to dom0 we will get an
> >> >> > > > over-allocation issue when assigning that page to the domain.
> >> >> > > > The anonymous page, in turn, is not assigned to any domain.
> >> >> > > > 
> >> >> > > > CC: Julien Grall <jgrall@amazon.com>
> >> >> > > > Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> >> >> > > > Acked-by: Volodymyr Babchuk <volodymyr_babchuk@epam.com>
> >> >> > > Only one question, which is more architectural: given that these pages
> >> >> > > are "unlimited", could the guest exploit the interface somehow to force
> >> >> > > Xen to allocate an very high number of anonymous pages?
> >> >> > > 
> >> >> > > E.g. could a domain call OPTEE_SMC_RPC_FUNC_ALLOC in a loop to force Xen
> >> >> > > to exaust all memory pages?
> >> >> > Generally, OP-TEE mediator tracks all resources allocated and imposes
> >> >> > limits on them.
> >> >> > 
> >> >> > OPTEE_SMC_RPC_FUNC_ALLOC case is a bit different, because it is issued
> >> >> > not by domain, but by OP-TEE itself. As OP-TEE is more trusted piece of
> >> >> > system we allow it to request as many buffers as it wants. Also, we know
> >> >> > that OP-TEE asks only for one such buffer per every standard call. And
> >> >> > number of simultaneous calls is limited by number of OP-TEE threads,
> >> >> > which is quite low: typically only two.
> >> >
> >> > So let me repeat it differently to see if I understood correctly:
> >> >
> >> > - OPTEE_SMC_RPC_FUNC_ALLOC is only called by OP-TEE, not by the domain
> >> > - OPTEE is trusted and only call it twice anyway
> >> 
> >> Correct.
> >> 
> >> > I am OK with this argument, but do we have a check to make sure a domU
> >> > cannot issue OPTEE_SMC_RPC_FUNC_ALLOC?
> >> 
> >> domU can't issue any RPC, because all RPCs are issued from OP-TEE
> >> side. This is the nature of RPC - OP-TEE requests Normal World for some
> >> service. But of course, Normal World can perform certain actions that
> >> will make OP-TEE to issue a RPC. I discuss this in depth below.
> >> 
> >> >
> >> > Looking at the patch, there are other two places, in addition to
> >> > OPTEE_SMC_RPC_FUNC_ALLOC, where the anonymous memory pages can be
> >> > allocated:
> >> >
> >> > 1) copy_std_request
> >> > 2) translate_noncontig
> >> >
> >> > We need to prove that neither 1) or 2) can result in a domU exausting
> >> > Xen memory.
> >> >
> >> > In the case of 1), it looks like the memory is freed before returning to
> >> > the DomU, right? If so, it should be no problem?
> >> 
> >> Yes, mediator makes shadow copy of every request buffer to hide
> >> translated addresses from the guest. Number of requests is limited by
> >> number of OP-TEE threads.
> >> 
> >> > In the case of 2), it looks like the memory could outlive the call where
> >> > it is allocated. Is there any kind of protection against issuing
> >> > something like OPTEE_MSG_ATTR_TYPE_TMEM_INOUT in a loop? Is it OP-TEE
> >> > itself that would refuse the attempt? Thus, the idea is that
> >> > do_call_with_arg will return error and we'll just free the memory there?
> >> 
> >> Well, translate_noncontig() calls allocate_optee_shm_buf() which counts
> >> all allocated buffers. So you can't call it more than
> >> MAX_SHM_BUFFER_COUNT times, without de-allocating previous memory. But,
> >> thanks to your question, I have found a bug there: memory is not freed
> >> if allocate_optee_shm_buf() fails. I'll prepare patch later today.
> >> 
> >> > I cannot see a check for errors returned by do_call_with_arg and memory
> >> > freeing done because of that. Sorry I am not super familiar with the
> >> > code, I am just trying to make sure we are not offering to DomUs an easy
> >> > way to crash the system.
> >> 
> >> I tried to eliminate all possibilities for a guest to crash the
> >> system. Of course, this does not mean that there are none of them.
> >> 
> >> And yes, code is a bit hard to understand, because calls to OP-TEE are
> >> stateful and you need to account for that state. From NW and SW this
> >> looks quite fine, because state is handled naturally. But mediator sits
> >> in a middle, so it's implementation is a bit messy.
> >> 
> >> I'll try to explain what is going on, so you it will be easier to
> >> understand logic in the mediator.
> >> 
> >> There are two types of OP-TEE calls: fast calls and standard calls. Fast
> >> call is simple: call SMC and get result. It does not allocate thread
> >> context in OP-TEE and is non-preemptive. So yes, it should be fast. It
> >> is used for simple things like "get OP-TEE version" or "exchange
> >> capabilities". It is easy to handle them in mediator: just forward
> >> the call, check result, return it back to a guest.
> >> 
> >> Standard calls are stateful. OP-TEE allocates thread for each call. This
> >> call can be preempted either by IRQ or by RPC. For consistency IRQ
> >> return is also considered as special type of RPC. So, in general one
> >> standard call can consist of series of SMCs:
> >> 
> >> --> SMC with request
> >> <-- RPC return (like IRQ)
> >> --> SMC "resume call"
> >> <-- RPC return (like "read disk")
> >> --> SMC "resume call"
> >> <-- RPC return (like "send network packet")
> >> --> SMC "resume call"
> >> ...
> >> <-- Final return
> >> 
> >> There are many types of RPCs: "handle IRQ", additional shared buffer
> >> allocation/de-allocation, RPMB access, disks access, network access,
> >> synchronization primitives (when OP-TEE thread is gets blocked on a
> >> mutex), etc.
> >> 
> >> Two more things that makes all this worse: Normal World can register
> >> shared buffer with OP-TEE. Such buffer can live indefinitely
> >> long. Also, Normal World decides when to resume call. For example,
> >> calling process can be preempted and then resumed seconds
> >> later. Misbehaving guest can decide to not resume call at all.
> >> 
> >> As I said, I tried to take all this things into account. There are
> >> basically 3 types of objects that can lead to memory allocation on Xen
> >> side:
> >> 
> >> 1. Standard call context. Besides memory space for struct optee_std_call
> >> itself it allocates page for a shadow buffer, where argument addresses
> >> are translated by Xen. Number of this objects is limited by number of
> >> OP-TEE threads:
> >> 
> >>     count = atomic_add_unless(&ctx->call_count, 1, max_optee_threads);
> >>     if ( count == max_optee_threads )
> >>         return ERR_PTR(-ENOSPC);
> >> 
> >> 2. Shared buffer. This is a buffer shared by guest with OP-TEE. It can
> >> be either temporary buffer which is shared for one standard call
> >> duration, or registered shared buffer, which is remains active until it
> >> is de-registered. This is where translate_noncontig() comes into play.
> >> Number of this buffers is limited in allocate_optee_shm_buf():
> >> 
> >>     count = atomic_add_unless(&ctx->optee_shm_buf_count, 1,
> >>                               MAX_SHM_BUFFER_COUNT);
> >>     if ( count == MAX_SHM_BUFFER_COUNT )
> >>         return ERR_PTR(-ENOMEM);
> >> 
> >> 3. Shared RPC buffer. This is very special kind of buffer. Basically,
> >> OP-TEE needs some shared memory to provide RPC call parameters. So it
> >> requests buffer from Normal World. There is no hard limit on this from
> >> mediator side, because, as I told earlier, OP-TEE itself limits number
> >> of this buffers. There is no cases when more that one buffer will be
> >> allocated per OP-TEE thread. This type of buffer is used only to process
> >> RPC requests themselves. OP-TEE can request more buffers via RPC, but
> >> they will fall to p.2: NW uses separate request to register buffer and
> >> then returns its handle in the preempted call.
> >> 
> >> 
> >> Apart from those two limits, there is a limit on total number of pages
> >> which is shared between guest and OP-TEE: MAX_TOTAL_SMH_BUF_PG. This
> >> limit is for a case when guest tries to allocate few really BIG buffers.
> >> 
> >> 
> >> > It looks like they could be called from one of the OPTEE operations that
> >> > a domU could request? Is there a limit for them?
> >> 
> >> Yes, there are limits, as I described above.
> >> 
> >> Also, bear in mind that resources available to OP-TEE are also quite
> >> limited. So, in case of some breach in mediator, OP-TEE will give up
> >> first. This of course is not an excuse to have bugs in the mediator...
> >
> > OK, thanks for the explanation. The reasons for my questions is that if
> > the allocations are using the memory of DomU, then at worst DomU can run
> > out of memory. But if the allocations are using anonymous memory, then
> > the whole platform might run out of memory. We have issued XSAs for
> > things like that in the past.
> >
> > This is why I am worried about this patch: if we apply it we really
> > become reliant on these limits being implemented correctly. A bug can
> > have much more severe consequences.
> 
> Agree.
> 
> > As you are the maintainer for this code, and this code is not security
> > supported, I'll leave it up to you (also see the other email about
> > moving optee to "supported, not security supported").
> 
> Yes, I've seen this email. Just didn't had time to write followup.
> 
> > However, maybe a different solution would be to increase max_pages for a
> > domain when optee is enabled? Maybe just by a few pages (as many as
> > needed by the optee mediator)? Because if we did that, we wouldn't risk
> > exposing DOS attack vectors for every bug in the mediator limits checks.
> >
> > The below adds a 10 pages slack.
> 
> Well, I didn't know that such option is available. If this is a valid
> approach and there are no objections from other maintainers, I'd rather
> use it.

I think it is a valid approach, and it is "more secure" than the other
patch. I suggest that you send a patch for it so that if people can
voice their objections if any.


> Only one comment there is about number of pages. Maximal number of
> domheap pages used per request is 6: one for request itself, one for RPC
> buffer, 4 at most for request arguments. I checked OP-TEE configuration,
> looks like some platforms allow up to 16 threads. This yields 6 * 16 = 96
> pages in total. If this is acceptable I'd set TEE_SLACK to 96.

OK. Please add a good in-code comment explaining how you got to 96.


> > diff --git a/xen/arch/arm/tee/tee.c b/xen/arch/arm/tee/tee.c
> > index 3964a8a5cd..a3105f1a9a 100644
> > --- a/xen/arch/arm/tee/tee.c
> > +++ b/xen/arch/arm/tee/tee.c
> > @@ -38,8 +38,11 @@ bool tee_handle_call(struct cpu_user_regs *regs)
> >      return cur_mediator->ops->handle_call(regs);
> >  }
> >  
> > +#define TEE_SLACK (10)
> >  int tee_domain_init(struct domain *d, uint16_t tee_type)
> >  {
> > +    int ret;
> > +
> >      if ( tee_type == XEN_DOMCTL_CONFIG_TEE_NONE )
> >          return 0;
> >  
> > @@ -49,7 +52,15 @@ int tee_domain_init(struct domain *d, uint16_t tee_type)
> >      if ( cur_mediator->tee_type != tee_type )
> >          return -EINVAL;
> >  
> > -    return cur_mediator->ops->domain_init(d);
> > +    ret = cur_mediator->ops->domain_init(d);
> > +    if ( ret < 0 )
> > +        return ret;
> > +
> > +    /* 
> > +     * Increase maxmem for domains with TEE, the extra pages are used by
> > +     * the mediator
> > +     */
> > +    d->max_pages += TEE_SLACK;
> >  }
> >  
> >  int tee_relinquish_resources(struct domain *d)



From xen-devel-bounces@lists.xenproject.org Thu Oct 07 23:53:51 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 07 Oct 2021 23:53:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.204168.359381 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYdCr-0005Zg-4p; Thu, 07 Oct 2021 23:53:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 204168.359381; Thu, 07 Oct 2021 23:53:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYdCr-0005ZZ-1N; Thu, 07 Oct 2021 23:53:45 +0000
Received: by outflank-mailman (input) for mailman id 204168;
 Thu, 07 Oct 2021 23:53:43 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Ti8Z=O3=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1mYdCp-0005ZT-K9
 for xen-devel@lists.xenproject.org; Thu, 07 Oct 2021 23:53:43 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 86304f95-ea39-440d-8e0e-46578c12b461;
 Thu, 07 Oct 2021 23:53:42 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id 085CC60F46;
 Thu,  7 Oct 2021 23:53:42 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 86304f95-ea39-440d-8e0e-46578c12b461
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1633650822;
	bh=nYBQUQOE91WGq5wkUx0Lx3qC0i42nHv7E3xGNbYTdN0=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=u4CM3i7Op2FaRnZwd7a7cILdaIkGJfl6tWO+OTimIKgtYEZtWTlyYlAueX10MFZY5
	 vLSUe4ABwyP4EBxwaif8vs6ZHf2zeAN3aNexVAkt/cw04aX07yV6I0oD/o+TSJEJiE
	 1fuQCyVzxlhVRMQzK9nv7Qlz6biwdzuLRge+h00bljhVGa4QXTSpXFx4ejBN2xIJQZ
	 2krZ8Gwaz5xbLcrH9JVouMCoF85l5+9owcgzcxI0dbbLiGLATsKYy+2ZYBe8rBO8Y/
	 Qx3HlY0FOoTKHi1KrNIwXAi/ElhG1A+b34cmYgA7dNrr7uPQte4bRMc/eezeNljTI7
	 Gf1XdTrD0VpKQ==
Date: Thu, 7 Oct 2021 16:53:40 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, 
    "tee-dev@lists.linaro.org" <tee-dev@lists.linaro.org>, 
    Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>
Subject: Re: [PATCH] xen/arm: optee: fix possible memory leaks
In-Reply-To: <20211007232450.2036087-1-volodymyr_babchuk@epam.com>
Message-ID: <alpine.DEB.2.21.2110071653300.414@sstabellini-ThinkPad-T480s>
References: <20211007232450.2036087-1-volodymyr_babchuk@epam.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Thu, 7 Oct 2021, Volodymyr Babchuk wrote:
> translate_noncontig() allocates domheap page for translated list
> before calling to allocate_optee_shm_buf(), which can fail for number
> of reason. Anyways, after fail we need to free the allocated page(s).
> 
> Another leak is possible if the same translate_noncontig() function
> fails to get domain page. In this case it should free allocated
> optee_shm_buf prior exit. This will also free allocated domheap page.
> 
> Signed-off-by: Volodymyr Babchuk <volodymyr_babchuk@epam.com>

Acked-by: Stefano Stabellini <sstabellini@kernel.org>


> ---
>  xen/arch/arm/tee/optee.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/xen/arch/arm/tee/optee.c b/xen/arch/arm/tee/optee.c
> index 6df0d44eb9..131d2f9a8a 100644
> --- a/xen/arch/arm/tee/optee.c
> +++ b/xen/arch/arm/tee/optee.c
> @@ -781,7 +781,10 @@ static int translate_noncontig(struct optee_domain *ctx,
>      optee_shm_buf = allocate_optee_shm_buf(ctx, param->u.tmem.shm_ref,
>                                             pg_count, xen_pgs, order);
>      if ( IS_ERR(optee_shm_buf) )
> +    {
> +        free_domheap_pages(xen_pgs, order);
>          return PTR_ERR(optee_shm_buf);
> +    }
>  
>      gfn = gaddr_to_gfn(param->u.tmem.buf_ptr &
>                         ~(OPTEE_MSG_NONCONTIG_PAGE_SIZE - 1));
> @@ -807,7 +810,7 @@ static int translate_noncontig(struct optee_domain *ctx,
>          {
>              guest_pg = get_domain_ram_page(gfn);
>              if ( !guest_pg )
> -                return -EINVAL;
> +                goto free_shm_buf;
>  
>              guest_data = __map_domain_page(guest_pg);
>              xen_data = __map_domain_page(xen_pgs);
> @@ -854,6 +857,7 @@ err_unmap:
>      unmap_domain_page(guest_data);
>      unmap_domain_page(xen_data);
>      put_page(guest_pg);
> +free_shm_buf:
>      free_optee_shm_buf(ctx, optee_shm_buf->cookie);
>  
>      return -EINVAL;
> -- 
> 2.33.0
> 


From xen-devel-bounces@lists.xenproject.org Fri Oct 08 00:27:54 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Oct 2021 00:27:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.204226.359392 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYdjh-0001LA-HI; Fri, 08 Oct 2021 00:27:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 204226.359392; Fri, 08 Oct 2021 00:27:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYdjh-0001L3-EJ; Fri, 08 Oct 2021 00:27:41 +0000
Received: by outflank-mailman (input) for mailman id 204226;
 Fri, 08 Oct 2021 00:27:40 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mYdjg-0001Kt-6y; Fri, 08 Oct 2021 00:27:40 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mYdjf-0008KC-WC; Fri, 08 Oct 2021 00:27:40 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mYdjf-0007nE-N2; Fri, 08 Oct 2021 00:27:39 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mYdjf-00052w-Kj; Fri, 08 Oct 2021 00:27:39 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=dsJI3ZoD8o090hLSgSiFr78J4VbBwio2yxMu8MbFhME=; b=6qtjc+a0b+VHtPZBsxR1bYZIZc
	HxOTZO3Af27RiF3JLrw6zq26A4lBGmRYrf9RKB5MGP/1jvLdLumEOax7xxjg2PU/eMkdvDEAZVTD1
	uoIqnBSEJ+djibHaYfKmsYfpYU37Jc4x89cetco/1t+dlvB9XqAGj29qkYlHPwCYTRfQ=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165401-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.13-testing test] 165401: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-4.13-testing:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=b4bb02d5999a56c93f0733b589b717e7cece9c09
X-Osstest-Versions-That:
    xen=6e2fc128eb1a7d8ff8c36123a0a03e4e60a4a44c
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 08 Oct 2021 00:27:39 +0000

flight 165401 xen-4.13-testing real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165401/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail baseline untested
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 164939
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 164939
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 164939
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 164939
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 164939
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 164939
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 164939
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 164939
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 164939
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 164939
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 164939
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  b4bb02d5999a56c93f0733b589b717e7cece9c09
baseline version:
 xen                  6e2fc128eb1a7d8ff8c36123a0a03e4e60a4a44c

Last test of basis   164939  2021-09-10 07:37:18 Z   27 days
Testing same since   165385  2021-10-05 19:06:15 Z    2 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
  Ivan Kardykov <kardykov@tabit.pro>
  Jan Beulich <jbeulich@suse.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   6e2fc128eb..b4bb02d599  b4bb02d5999a56c93f0733b589b717e7cece9c09 -> stable-4.13


From xen-devel-bounces@lists.xenproject.org Fri Oct 08 02:19:36 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Oct 2021 02:19:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.204286.359410 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYfTm-00023s-U1; Fri, 08 Oct 2021 02:19:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 204286.359410; Fri, 08 Oct 2021 02:19:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYfTm-00023l-Pj; Fri, 08 Oct 2021 02:19:22 +0000
Received: by outflank-mailman (input) for mailman id 204286;
 Fri, 08 Oct 2021 02:19:21 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=tTRi=O4=arm.com=Penny.Zheng@srs-us1.protection.inumbo.net>)
 id 1mYfTl-00023d-MD
 for xen-devel@lists.xenproject.org; Fri, 08 Oct 2021 02:19:21 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com (unknown
 [40.107.8.78]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 24382378-27de-11ec-8014-12813bfff9fa;
 Fri, 08 Oct 2021 02:19:19 +0000 (UTC)
Received: from DBBPR09CA0006.eurprd09.prod.outlook.com (2603:10a6:10:c0::18)
 by AS8PR08MB6279.eurprd08.prod.outlook.com (2603:10a6:20b:294::14) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.22; Fri, 8 Oct
 2021 02:19:17 +0000
Received: from DB5EUR03FT005.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:10:c0:cafe::33) by DBBPR09CA0006.outlook.office365.com
 (2603:10a6:10:c0::18) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.21 via Frontend
 Transport; Fri, 8 Oct 2021 02:19:17 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT005.mail.protection.outlook.com (10.152.20.122) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4587.18 via Frontend Transport; Fri, 8 Oct 2021 02:19:17 +0000
Received: ("Tessian outbound a8bfe25d7364:v103");
 Fri, 08 Oct 2021 02:19:17 +0000
Received: from 5ecef73a395d.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 4279A9D3-331D-4D99-9F2B-D27A577F56C4.1; 
 Fri, 08 Oct 2021 02:19:06 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 5ecef73a395d.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 08 Oct 2021 02:19:06 +0000
Received: from VE1PR08MB5215.eurprd08.prod.outlook.com (2603:10a6:803:10a::33)
 by VI1PR0801MB2095.eurprd08.prod.outlook.com (2603:10a6:800:8c::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18; Fri, 8 Oct
 2021 02:19:02 +0000
Received: from VE1PR08MB5215.eurprd08.prod.outlook.com
 ([fe80::41d6:b115:3b22:2cd]) by VE1PR08MB5215.eurprd08.prod.outlook.com
 ([fe80::41d6:b115:3b22:2cd%2]) with mapi id 15.20.4566.023; Fri, 8 Oct 2021
 02:19:02 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 24382378-27de-11ec-8014-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=M84BNpLvvqSTIhm9xKxMMBdjvbLCpOFDVB8q9SnlKNM=;
 b=o4PY9f0ApF/X9ZVruI8nd94a6qhaJDx64VaIq2uyz5zGVoziNU4QZnNXYVkl9ho/IUibCYuKkCcX7O1JM3S4lkEO8XqzOFpjKRe5Fhube786lVq34kFeuaH+8af/HuQIvcU6RVE/EH8dBxThV4eux854uWjBb+N8OtumjR4zzHo=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=haUv2/5siU7qDR7bL78FznDHv06nIvhensv3ELcpC46gAnTVnqokX1EsfSn3fvVuVXkHy/MT8e2GRYFR+/M3BivPUYiZRDlfIIaQbMzh5NX+z31DTnNeaq/g3F9Gw2UXGGlluUtZPbiA/Lfh43mn4G/dn28oDrCA/P2xEoQtDos8q9gafN+sxUD1f0wILN4y+aJlHib8lEw6hpB2pLw7m7aDZoSA2H1dxfDQNKGCddbpWrDsn8LUmqnBD2yi3FG9yvxBvZnc4JYtAQm+XXdiTNE0h+vSwCDjls3CBScsmIky9ZrHnPTJZRARTyh09bvhoDBXw70b+egpbTO+lUPNKQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=M84BNpLvvqSTIhm9xKxMMBdjvbLCpOFDVB8q9SnlKNM=;
 b=nBWfeOo18igl9Ev126S72HtpqkQ0A5KP4I+6RRVq2RLNRzxmCSBHR21/xFXRqwk6Sy5RtFlzM67Xfaz53SofzOVFtTSY05RbbX9mqEiJqkWLnaqou6FTCEMu571ycScJCl6SKjfXQxICmharb+jni0xwMGOz3iHXOKcTZWIPnd0H4gd1ASihttaO9NZWCZ701cqR0uWjsSM37XtHUExjOJhQ5jolR6o9y3zbs11hIV1KsODBFw80uhFNhIhDABdXtKpvaIDAWGGmoWAWwgGHvpXduP9lUZydT3MBOw2dxlUPfGejsmsiyB8IcAsEfgemOWoN1m+ErHuDA9n1E4iG3Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=M84BNpLvvqSTIhm9xKxMMBdjvbLCpOFDVB8q9SnlKNM=;
 b=o4PY9f0ApF/X9ZVruI8nd94a6qhaJDx64VaIq2uyz5zGVoziNU4QZnNXYVkl9ho/IUibCYuKkCcX7O1JM3S4lkEO8XqzOFpjKRe5Fhube786lVq34kFeuaH+8af/HuQIvcU6RVE/EH8dBxThV4eux854uWjBb+N8OtumjR4zzHo=
From: Penny Zheng <Penny.Zheng@arm.com>
To: Julien Grall <julien@xen.org>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, "sstabellini@kernel.org"
	<sstabellini@kernel.org>
CC: Bertrand Marquis <Bertrand.Marquis@arm.com>, Wei Chen <Wei.Chen@arm.com>
Subject: RE: [PATCH 03/11] xen/arm: introduce 1:1 direct-map for domUs
Thread-Topic: [PATCH 03/11] xen/arm: introduce 1:1 direct-map for domUs
Thread-Index: AQHXsCi50aJGE+wBhkmFwBtQSxTgD6uxbUoAgBcFE3A=
Date: Fri, 8 Oct 2021 02:19:02 +0000
Message-ID:
 <VE1PR08MB521521B8DA771C9227FB9AE5F7B29@VE1PR08MB5215.eurprd08.prod.outlook.com>
References: <20210923031115.1429719-1-penny.zheng@arm.com>
 <20210923031115.1429719-4-penny.zheng@arm.com>
 <27b7e2c9-168e-68ef-e372-0571b81676fc@xen.org>
In-Reply-To: <27b7e2c9-168e-68ef-e372-0571b81676fc@xen.org>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: C0B5DD6948E05341A371FD52261ED8E7.0
x-checkrecipientchecked: true
Authentication-Results-Original: xen.org; dkim=none (message not signed)
 header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: 4049eb44-da16-4527-a1a5-08d98a02078f
x-ms-traffictypediagnostic: VI1PR0801MB2095:|AS8PR08MB6279:
x-ms-exchange-transport-forked: True
X-Microsoft-Antispam-PRVS:
	<AS8PR08MB62792D0F5391A46FDE5BB0BAF7B29@AS8PR08MB6279.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:8882;OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 iH/jDs1tcuD2jbPNvKDZVJJti412of3nRDTWwY/n842OfudisJZFdhBDZgKL7oUFB9gYrzovSMF4dE4EAxJSZczza6Jy26CsJoSJ2+y42XpnDDf9HqKkpDMHvvkYj19fiO7JV8O4l/z1m9WJFyjPQesHRkVaMn+5dYQJnS/b6QSGdlHhbMAqIT/j7UVbHe3pSZ//xXP81lY1SVoKDSqtbpbIkyqldPBspDlfs5CRcLnKCH2z+3rIvAKY+UR1YnVOWn339yQzU2f2vJtjKJNNlJgHjBbiCfwVam4Exb9uDixbN1cmaSflp7uuVOfWTUEo7Lmt/csvGI69FbTN55nnKjmnCLm5va1UXCLYwaYpuLUC7hO8zXSFMJDPojChCpKdt7JMe2q4A+3Nna5/9fgyrZdFQoM00gWDVbLU1PAa3N4WTXpHhPq3ncAgh4xsZptdJnScR7FLZAdno1MchYDCPT/mcs8tQ4raMkmeT7pmLGobpoSNk1lLvqXQef3SvuzZ1ElcFLIW77eUx8DZXxKTPh2K3gQV2ktptxxELIkJPFgc5d9r1YqE1yh1DuH5QmmSMSSGt/h+4DhqNS2s/HXrf2cjTKKQJC2qp3TONFngDmPdjh6mLhsPaTMMOnJo5dEFCnMZdQoxZYjyttQoIsknsut8x6/HjO+R0d+8tAWsUVrXrc6YkXffTqaxQtthbRImoMshQy0pzjO5Y29w7/Lf0Q==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR08MB5215.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(30864003)(8676002)(110136005)(6506007)(66946007)(54906003)(76116006)(316002)(4326008)(508600001)(8936002)(122000001)(9686003)(7696005)(38100700002)(186003)(52536014)(71200400001)(26005)(86362001)(5660300002)(2906002)(55016002)(38070700005)(83380400001)(53546011)(33656002)(64756008)(66446008)(66556008)(66476007);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0801MB2095
Original-Authentication-Results: xen.org; dkim=none (message not signed)
 header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT005.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	6e0362cf-07fa-4eca-5109-08d98a01ff01
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	YpGpxFEn6hJhsQfj6G45eQuFA0gXP5ja638ky+xOs52QFhnzggBz7LLdopOFGm2GLc9mSD1ehBQCuGrnVaTAs5IzbUcDF+kFpwrdwR5B9Av5WTUR51bXtlGvqp5Ae4wl8OqAtZ5rO5m8SIqHQ2FK/klSw9sOelHzPR5ferdO3pwn3Jdys9RvzWjTXHlr+PYQjkBul+M/moxn2427KImE+W4KcOAwAsOrSiyTnOk5bbJwi8W1W6Y9K9P+JNBWc6835AEsSPn0122LM82khd4KVDH6h29Ed3zkl4kEEJQlex9GqD7p1oJ54T86AOBSdOHhiMPymlp1gkLoyk3YRg7dqeKmPvcb43n2uPMLqoESxfGPRYPR2V4A0xPg1/azM6SjKjPabGw7d/jdjKP3ojIU/bFe2Q5qRpaH1HbJft7nyECx/OHDCbq+y4fnUKaNMzPdGCjVRoKz7IFDSLAhFq0bEODJcmclStuJk2s7yuKh8UEmIzzEnBDCAZKeCFhrG09YA0gFpgoRUOLuXC0SD/3Vr27DEMNpHW44KDUneXX8/YU/yoccRYEiD1x87HfdDCBqn49iymLLrzvtoC8k4gTwXsecSjJ8CAUIkimHmqQZNc2i7rBeZq3LwLLfz/EzvZQxjyU4fBz/fvekdSE0qpxpIUf0sKP6oguhNRgwGYRpSUM5Eor8Jv0LDL1st5V3NU4+BfFZnP/NWQGZiaPe5TfdSg==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(47076005)(70586007)(70206006)(26005)(2906002)(186003)(53546011)(6506007)(33656002)(7696005)(508600001)(8676002)(8936002)(356005)(81166007)(316002)(4326008)(36860700001)(110136005)(54906003)(55016002)(9686003)(52536014)(5660300002)(30864003)(83380400001)(336012)(82310400003)(86362001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Oct 2021 02:19:17.0977
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 4049eb44-da16-4527-a1a5-08d98a02078f
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT005.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6279

SGkgSnVsaWVuDQoNClNvIHNvcnJ5IGZvciB0YWtpbmcgc28gbG9uZyB0byByZXNwb25kLiBKdXN0
IGJlaW5nIGJhY2sgZnJvbSB0aGUgbG9uZyBOYXRpb25hbCBEYXkgaG9saWRheXMuIPCfmIkNCg0K
PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBKdWxpZW4gR3JhbGwgPGp1bGll
bkB4ZW4ub3JnPg0KPiBTZW50OiBUaHVyc2RheSwgU2VwdGVtYmVyIDIzLCAyMDIxIDY6MzYgUE0N
Cj4gVG86IFBlbm55IFpoZW5nIDxQZW5ueS5aaGVuZ0Bhcm0uY29tPjsgeGVuLWRldmVsQGxpc3Rz
LnhlbnByb2plY3Qub3JnOw0KPiBzc3RhYmVsbGluaUBrZXJuZWwub3JnDQo+IENjOiBCZXJ0cmFu
ZCBNYXJxdWlzIDxCZXJ0cmFuZC5NYXJxdWlzQGFybS5jb20+OyBXZWkgQ2hlbg0KPiA8V2VpLkNo
ZW5AYXJtLmNvbT4NCj4gU3ViamVjdDogUmU6IFtQQVRDSCAwMy8xMV0geGVuL2FybTogaW50cm9k
dWNlIDE6MSBkaXJlY3QtbWFwIGZvciBkb21Vcw0KPiANCj4gDQo+IA0KPiBPbiAyMy8wOS8yMDIx
IDA4OjExLCBQZW5ueSBaaGVuZyB3cm90ZToNCj4gPiBGcm9tOiBTdGVmYW5vIFN0YWJlbGxpbmkg
PHN0ZWZhbm8uc3RhYmVsbGluaUB4aWxpbnguY29tPg0KPiA+DQo+ID4gQ2FzZXMgd2hlcmUgZG9t
VSBuZWVkcyAxOjEgZGlyZWN0LW1hcCBtZW1vcnkgbWFwOg0KPiANCj4gIjE6MSIgYW5kICJkaXJl
Y3QtbWFwIiBtZWFucyBwcmV0dHkgbXVjaCB0aGUgc2FtZS4gR2l2ZW4gdGhhdCB0aGUgcHJvcGVy
dHkNCj4gaXMgbmFtZSAiZGlyZWN0LW1hcCIsIHRoZW4gSSB3b3VsZCBkcm9wICIxOjEiLg0KPiAN
Cj4gPiAgICAqIElPTU1VIG5vdCBwcmVzZW50IGluIHRoZSBzeXN0ZW0uDQo+ID4gICAgKiBJT01N
VSBkaXNhYmxlZCBpZiBpdCBkb2Vzbid0IGNvdmVyIGEgc3BlY2lmaWMgZGV2aWNlIGFuZCBhbGwg
dGhlDQo+ID4gZ3Vlc3RzIGFyZSB0cnVzdGVkLiBUaGlua2luZyBhIG1peGVkIHNjZW5hcmlvLCB3
aGVyZSBhIGZldyBkZXZpY2VzDQo+ID4gd2l0aCBJT01NVSBhbmQgYSBmZXcgd2l0aG91dCwgdGhl
biBndWVzdCBETUEgc2VjdXJpdHkgc3RpbGwgY291bGQgbm90IGJlDQo+IHRvdGFsbHkgZ3VhcmFu
dGVlZC4NCj4gPiBTbyB1c2VycyBtYXkgd2FudCB0byBkaXNhYmxlIHRoZSBJT01NVSwgdG8gYXQg
bGVhc3QgZ2FpbiBzb21lDQo+ID4gcGVyZm9ybWFuY2UgaW1wcm92ZW1lbnQgZnJvbSBJT01NVSBk
aXNhYmxlZC4NCj4gPiAgICAqIElPTU1VIGRpc2FibGVkIGFzIGEgd29ya2Fyb3VuZCB3aGVuIGl0
IGRvZXNuJ3QgaGF2ZSBlbm91Z2gNCj4gYmFuZHdpZHRoLg0KPiA+IFRvIGJlIHNwZWNpZmljLCBp
biBhIGZldyBleHRyZW1lIHNpdHVhdGlvbiwgd2hlbiBtdWx0aXBsZSBkZXZpY2VzIGRvDQo+ID4g
RE1BIGNvbmN1cnJlbnRseSwgdGhlc2UgcmVxdWVzdHMgbWF5IGV4Y2VlZCBJT01NVSdzIHRyYW5z
bWlzc2lvbg0KPiBjYXBhY2l0eS4NCj4gPiAgICAqIElPTU1VIGRpc2FibGVkIHdoZW4gaXQgYWRk
cyB0b28gbXVjaCBsYXRlbmN5IG9uIERNQS4gRm9yIGV4YW1wbGUsDQo+ID4gVExCIG1heSBiZSBt
aXNzaW5nIGluIHNvbWUgSU9NTVUgaGFyZHdhcmUsIHdoaWNoIG1heSBicmluZyBsYXRlbmN5IGlu
DQo+ID4gRE1BIHByb2dyZXNzLCBzbyB1c2VycyBtYXkgd2FudCB0byBkaXNhYmxlIGl0IGluIHNv
bWUgcmVhbHRpbWUgc2NlbmFyaW8uDQo+ID4NCj4gPiAqV0FSTklORzoNCj4gPiBVc2VycyBzaG91
bGQgYmUgYXdhcmUgdGhhdCBpdCBpcyBub3QgYWx3YXlzIHNlY3VyZSB0byBhc3NpZ24gYSBkZXZp
Y2UNCj4gPiB3aXRob3V0IElPTU1VIHByb3RlY3Rpb24uDQo+ID4gV2hlbiB0aGUgZGV2aWNlIGlz
IG5vdCBwcm90ZWN0ZWQgYnkgdGhlIElPTU1VLCB0aGUgYWRtaW5pc3RyYXRvcg0KPiA+IHNob3Vs
ZCBtYWtlIHN1cmUgdGhhdDoNCj4gPiAgIDEuIFRoZSBkZXZpY2UgaXMgYXNzaWduZWQgdG8gYSB0
cnVzdGVkIGd1ZXN0Lg0KPiA+ICAgMi4gVXNlcnMgaGF2ZSBhZGRpdGlvbmFsIHNlY3VyaXR5IG1l
Y2hhbmlzbSBvbiB0aGUgcGxhdGZvcm0uDQo+IA0KPiBUaGUgdHdvIHJlcXVpcmVtZW50cyBhcmUg
b25seSBuZWNlc3NhcnkgZm9yIGRldmljZSB0aGF0IGFyZSBETUEtY2FwYWJsZS4NCj4gRm9yIGRl
dmljZSB0aGF0IGNhbid0IGRvIERNQSwgaXQgd2lsbCBsaWtlbHkgYmUgZmluZSB0byBhc3NpZ24g
dG8gbm9uLXRydXN0ZWQNCj4gZ3Vlc3QuDQo+IA0KPiA+DQo+ID4gR2l2ZW4gdGhhdCB3aXRoIGRp
cmVjdC1tYXAsIHRoZSBJT01NVSBjb3VsZCBiZSB1c2VkIGJ1dCBpdCBpcyBub3QgcmVxdWlyZWQu
DQo+IA0KPiBJIGNhbid0IHBhcnNlIGl0Lg0KPiANCg0KTm93IHdoZW4gZG9pbmcgZGV2aWNlIGFz
c2lnbm1lbnRzLCBJT01NVSBpcyBmb3JjZWQgdG8gYmUgZW5hYmxlZC4gQW5kIHNpbmNlDQp3ZSBh
cmUgaW50cm9kdWNpbmcgZGlyZWN0LW1hcCBoZXJlLCBJIHRoaW5rIHRoYXQgbWF5YmUgZXZlbiBp
ZiBJT01NVSBpcyBtaXNzaW5nL2Rpc2FibGVkLA0KZGlyZWN0LW1hcCBvbiB0cnVzdCBndWVzdHMg
Y291bGQgYWxzbyBtYWtlIGl0IHdvcmsuDQoNCk1heWJlIEkgc2hvdWxkIHJlcGhyYXNlIGl0IHRv
DQoiDQpXaGVuIGRvaW5nIGRldmljZSBhc3NpZ25tZW50cyBhbmQgSU9NTVUgaXMgbWlzc2luZyBv
ciBkaXNhYmxlZCwgZGlyZWN0LW1hcA0Kc2hhbGwgYmUgdXNlZCBvbiB0cnVzdCBndWVzdHMuDQoi
DQoNCj4gPiBUaGlzIGNvbW1pdCBhdm9pZHMgc2V0dGluZyBYRU5fRE9NQ1RMX0NERl9pb21tdSB3
aGVuIHRoZSBJT01NVSBpcw0KPiA+IGRpc2FibGVkIGFuZCBkaXJlY3RfbWFwIGlzIHJlcXVlc3Rl
ZC4NCj4gPg0KPiA+IFNpbmNlLCBmb3Igbm93LCAxOjEgZGlyZWN0LW1hcCBpcyBvbmx5IHN1cHBv
cnRlZCB3aGVuIGRvbWFpbiBvbiBTdGF0aWMNCj4gDQo+IEkgdGhpbmsgIlNpbmNlIiBzZWVtcyB1
bm5lY2Vzc2FyeS4NCj4gDQo+ID4gQWxsb2NhdGlvbiwgdGhhdCBpcywgInhlbi5zdGF0aWMtbWVt
IiBpcyBkZWZpbmVkIGluIHRoZSBkb21haW4gY29uZmlndXJhdGlvbi4NCj4gPg0KPiA+IFRoaXMg
Y29tbWl0IGFsc28gcmUtaW1wbGVtZW50cyBhbGxvY2F0ZV9zdGF0aWNfbWVtb3J5IHRvIGFsbG9j
YXRlDQo+ID4gc3RhdGljIG1lbW9yeSBhcyBndWVzdCBSQU0gZm9yIDE6MSBkaXJlY3QtbWFwIGRv
bWFpbi4NCj4gPg0KPiA+IFNpZ25lZC1vZmYtYnk6IFN0ZWZhbm8gU3RhYmVsbGluaSA8c3RlZmFu
by5zdGFiZWxsaW5pQHhpbGlueC5jb20+DQo+ID4gU2lnbmVkLW9mZi1ieTogUGVubnkgWmhlbmcg
PHBlbm55LnpoZW5nQGFybS5jb20+DQo+ID4gLS0tDQo+ID4gICBkb2NzL21pc2MvYXJtL2Rldmlj
ZS10cmVlL2Jvb3RpbmcudHh0IHwgICA5ICsrDQo+ID4gICB4ZW4vYXJjaC9hcm0vZG9tYWluX2J1
aWxkLmMgICAgICAgICAgIHwgMTE3ICsrKysrKysrKysrKysrKysrLS0tLS0tLS0tDQo+ID4gICAy
IGZpbGVzIGNoYW5nZWQsIDg1IGluc2VydGlvbnMoKyksIDQxIGRlbGV0aW9ucygtKQ0KPiA+DQo+
ID4gZGlmZiAtLWdpdCBhL2RvY3MvbWlzYy9hcm0vZGV2aWNlLXRyZWUvYm9vdGluZy50eHQNCj4g
PiBiL2RvY3MvbWlzYy9hcm0vZGV2aWNlLXRyZWUvYm9vdGluZy50eHQNCj4gPiBpbmRleCA0NGNk
OWUxYTlhLi4zZDYzN2M3NDdlIDEwMDY0NA0KPiA+IC0tLSBhL2RvY3MvbWlzYy9hcm0vZGV2aWNl
LXRyZWUvYm9vdGluZy50eHQNCj4gPiArKysgYi9kb2NzL21pc2MvYXJtL2RldmljZS10cmVlL2Jv
b3RpbmcudHh0DQo+ID4gQEAgLTE2NCw2ICsxNjQsMTUgQEAgd2l0aCB0aGUgZm9sbG93aW5nIHBy
b3BlcnRpZXM6DQo+ID4gICAgICAgQm90aCAjYWRkcmVzcy1jZWxscyBhbmQgI3NpemUtY2VsbHMg
bmVlZCB0byBiZSBzcGVjaWZpZWQgYmVjYXVzZQ0KPiA+ICAgICAgIGJvdGggc3ViLW5vZGVzIChk
ZXNjcmliZWQgc2hvcnRseSkgaGF2ZSByZWcgcHJvcGVydGllcy4NCj4gPg0KPiA+ICstIGRpcmVj
dC1tYXANCj4gPiArDQo+ID4gKyAgICBPcHRpb25hbCBmb3IgRG9tYWluIG9uIFN0YXRpYyBBbGxv
Y2F0aW9uLg0KPiA+ICsgICAgQW4gZW1wdHkgcHJvcGVydHkgdG8gcmVxdWVzdCB0aGUgbWVtb3J5
IG9mIHRoZSBkb21haW4gdG8gYmUgMToxDQo+ID4gKyAgICBkaXJlY3QtbWFwKGd1ZXN0IHBoeXNp
Y2FsIGFkZHJlc3MgPT0gcGh5c2ljYWwgYWRkcmVzcykuDQo+ID4gKyAgICBXQVJOSU5HOiBVc2Vy
cyBtdXN0IGJlIGF3YXJlIG9mIHRoaXMgcmlzaywgdGhhdCBndWVzdHMgaGF2aW5nIGFjY2Vzcw0K
PiA+ICsgICAgdG8gaGFyZHdhcmUgd2l0aCBETUEgY2FwYWNpdHkgbXVzdCBiZSB0cnVzdGVkLCBv
ciBpdCBjb3VsZCB1c2UgdGhlDQo+ID4gKyAgICBETUEgZW5naW5lIHRvIGFjY2VzcyBhbnkgb3Ro
ZXIgbWVtb3J5IGFyZWEuDQo+IA0KPiBUaGUgV0FSTklORyBpcyBvbmx5IGFwcGxpY2FibGUgaWYg
dGhlIGRldmljZSBpcyBub3QgcHJvdGVjdGVkIGJ5IGFuIElPTU1VLg0KPiBTbyB0aGlzIHNob3Vs
ZCBiZSBjbGFyaWZpZWQgYmVjYXVzZSBvbmUgbWF5IHdhbnQgc3RpbGwgd2FudCB0byB1c2UgdGhl
IGRpcmVjdC0NCj4gbWFwIChlLmcuIGJlY2F1c2UgdGhlIE9TIHJlbGllcyBvbiB0aGUgaG9zdCBs
YXlvdXQpIGFuZCBoYXZlIElPTU1VIGVuYWJsZWQuDQo+IA0KPiA+ICsNCj4gPiAgIFVuZGVyIHRo
ZSAieGVuLGRvbWFpbiIgY29tcGF0aWJsZSBub2RlLCBvbmUgb3IgbW9yZSBzdWItbm9kZXMgYXJl
DQo+IHByZXNlbnQNCj4gPiAgIGZvciB0aGUgRG9tVSBrZXJuZWwgYW5kIHJhbWRpc2suDQo+ID4N
Cj4gPiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gvYXJtL2RvbWFpbl9idWlsZC5jIGIveGVuL2FyY2gv
YXJtL2RvbWFpbl9idWlsZC5jDQo+ID4gaW5kZXggMjFkOGE1NTlhZi4uMjEzYWQwMTdkYyAxMDA2
NDQNCj4gPiAtLS0gYS94ZW4vYXJjaC9hcm0vZG9tYWluX2J1aWxkLmMNCj4gPiArKysgYi94ZW4v
YXJjaC9hcm0vZG9tYWluX2J1aWxkLmMNCj4gPiBAQCAtNDg4LDggKzQ4OCwxNCBAQCBzdGF0aWMg
Ym9vbCBfX2luaXQNCj4gYXBwZW5kX3N0YXRpY19tZW1vcnlfdG9fYmFuayhzdHJ1Y3QgZG9tYWlu
ICpkLA0KPiA+ICAgew0KPiA+ICAgICAgIGludCByZXM7DQo+ID4gICAgICAgdW5zaWduZWQgaW50
IG5yX3BhZ2VzID0gUEZOX0RPV04oc2l6ZSk7DQo+ID4gLSAgICAvKiBJbmZlciBuZXh0IEdGTi4g
Ki8NCj4gPiAtICAgIGdmbl90IHNnZm4gPSBnYWRkcl90b19nZm4oYmFuay0+c3RhcnQgKyBiYW5r
LT5zaXplKTsNCj4gPiArICAgIGdmbl90IHNnZm47DQo+ID4gKw0KPiA+ICsgICAgaWYgKCAhaXNf
ZG9tYWluX2RpcmVjdF9tYXBwZWQoZCkgKQ0KPiA+ICsgICAgICAgIC8qIEluZmVyIG5leHQgR0ZO
IHdoZW4gR0ZOICE9IE1GTi4gKi8NCj4gPiArICAgICAgICBzZ2ZuID0gZ2FkZHJfdG9fZ2ZuKGJh
bmstPnN0YXJ0ICsgYmFuay0+c2l6ZSk7DQo+ID4gKyAgICBlbHNlDQo+ID4gKyAgICAgICAgc2dm
biA9IGdhZGRyX3RvX2dmbihtZm5fdG9fbWFkZHIoc21mbikpOw0KPiA+ICsNCj4gPg0KPiA+ICAg
ICAgIHJlcyA9IGd1ZXN0X3BoeXNtYXBfYWRkX3BhZ2VzKGQsIHNnZm4sIHNtZm4sIG5yX3BhZ2Vz
KTsNCj4gPiAgICAgICBpZiAoIHJlcyApDQo+ID4gQEAgLTUzNywxNCArNTQzLDE3IEBAIHN0YXRp
YyB2b2lkIF9faW5pdCBhbGxvY2F0ZV9zdGF0aWNfbWVtb3J5KHN0cnVjdA0KPiBkb21haW4gKmQs
DQo+ID4gICAgICAgfQ0KPiANCj4gVGhpcyBmdW5jdGlvbiB3YXMgYWxyZWFkeSBwcmV0dHkgZGlm
ZmljdWx0IHRvIHJlYWQuIFNvIEkgd291bGQgcmF0aGVyIG5vdCBhZGQNCj4gbW9yZSBjb21wbGV4
aXR5IGluIGl0LiBJbnN0ZWFkLCBJIHdvdWxkIGxvb2sgdG8gc3BsaXQgdGhlIGNvbW1vbiBjb2Rl
IGluIGENCj4gc2VwYXJhdGUgaGVscGVyIG9yIHBvc3NpYmx5IGR1cGxpY2F0ZSBpdC4NCj4gDQo+
ID4gICAgICAgcmVnX2NlbGxzID0gYWRkcl9jZWxscyArIHNpemVfY2VsbHM7DQo+ID4NCj4gPiAt
ICAgIC8qDQo+ID4gLSAgICAgKiBUaGUgc3RhdGljIG1lbW9yeSB3aWxsIGJlIG1hcHBlZCBpbiB0
aGUgZ3Vlc3QgYXQgdGhlIHVzdWFsIGd1ZXN0DQo+IG1lbW9yeQ0KPiA+IC0gICAgICogYWRkcmVz
c2VzIChHVUVTVF9SQU0wX0JBU0UsIEdVRVNUX1JBTTFfQkFTRSkgZGVmaW5lZCBieQ0KPiA+IC0g
ICAgICogeGVuL2luY2x1ZGUvcHVibGljL2FyY2gtYXJtLmguDQo+ID4gLSAgICAgKi8NCj4gPiAt
ICAgIGdiYW5rID0gMDsNCj4gPiAtICAgIGdzaXplID0gcmFtc2l6ZVtnYmFua107DQo+ID4gLSAg
ICBraW5mby0+bWVtLmJhbmtbZ2JhbmtdLnN0YXJ0ID0gcmFtYmFzZVtnYmFua107DQo+ID4gKyAg
ICBpZiAoICFpc19kb21haW5fZGlyZWN0X21hcHBlZChkKSApDQo+ID4gKyAgICB7DQo+ID4gKyAg
ICAgICAgLyoNCj4gPiArICAgICAgICAgKiBUaGUgc3RhdGljIG1lbW9yeSB3aWxsIGJlIG1hcHBl
ZCBpbiB0aGUgZ3Vlc3QgYXQgdGhlIHVzdWFsIGd1ZXN0DQo+ID4gKyAgICAgICAgICogbWVtb3J5
IGFkZHJlc3NlcyAoR1VFU1RfUkFNMF9CQVNFLCBHVUVTVF9SQU0xX0JBU0UpDQo+IGRlZmluZWQg
YnkNCj4gPiArICAgICAgICAgKiB4ZW4vaW5jbHVkZS9wdWJsaWMvYXJjaC1hcm0uaC4NCj4gPiAr
ICAgICAgICAgKi8NCj4gPiArICAgICAgICBnYmFuayA9IDA7DQo+ID4gKyAgICAgICAgZ3NpemUg
PSByYW1zaXplW2diYW5rXTsNCj4gPiArICAgICAgICBraW5mby0+bWVtLmJhbmtbZ2JhbmtdLnN0
YXJ0ID0gcmFtYmFzZVtnYmFua107DQo+ID4gKyAgICB9ID4NCj4gPiAgICAgICBjZWxsID0gKGNv
bnN0IF9fYmUzMiAqKXByb3AtPnZhbHVlOw0KPiA+ICAgICAgIG5yX2JhbmtzID0gKHByb3AtPmxl
bmd0aCkgLyAocmVnX2NlbGxzICogc2l6ZW9mICh1MzIpKTsgQEANCj4gPiAtNTcyLDQyICs1ODEs
NTggQEAgc3RhdGljIHZvaWQgX19pbml0IGFsbG9jYXRlX3N0YXRpY19tZW1vcnkoc3RydWN0DQo+
IGRvbWFpbiAqZCwNCj4gPiAgICAgICAgICAgcHJpbnRrKFhFTkxPR19JTkZPICIlcGQ6IFNUQVRJ
QyBCQU5LWyV1XSAlIyJQUklwYWRkciItDQo+ICUjIlBSSXBhZGRyIlxuIiwNCj4gPiAgICAgICAg
ICAgICAgICAgIGQsIGJhbmssIHBiYXNlLCBwYmFzZSArIHBzaXplKTsNCj4gPg0KPiA+IC0gICAg
ICAgIHdoaWxlICggMSApDQo+ID4gKyAgICAgICAgaWYgKCAhaXNfZG9tYWluX2RpcmVjdF9tYXBw
ZWQoZCkgKQ0KPiA+ICAgICAgICAgICB7DQo+ID4gLSAgICAgICAgICAgIC8qIE1hcCBhcyBtdWNo
IGFzIHBvc3NpYmxlIHRoZSBzdGF0aWMgcmFuZ2UgdG8gdGhlIGd1ZXN0IGJhbmsgKi8NCj4gPiAt
ICAgICAgICAgICAgaWYgKCAhYXBwZW5kX3N0YXRpY19tZW1vcnlfdG9fYmFuayhkLCAma2luZm8t
Pm1lbS5iYW5rW2diYW5rXSwNCj4gc21mbiwNCj4gPiAtICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICBtaW4ocHNpemUsIGdzaXplKSkgKQ0KPiA+IC0gICAgICAg
ICAgICAgICAgZ290byBmYWlsOw0KPiA+IC0NCj4gPiAtICAgICAgICAgICAgLyoNCj4gPiAtICAg
ICAgICAgICAgICogVGhlIGN1cnJlbnQgcGh5c2ljYWwgYmFuayBpcyBmdWxseSBtYXBwZWQuDQo+
ID4gLSAgICAgICAgICAgICAqIEhhbmRsZSB0aGUgbmV4dCBwaHlzaWNhbCBiYW5rLg0KPiA+IC0g
ICAgICAgICAgICAgKi8NCj4gPiAtICAgICAgICAgICAgaWYgKCBnc2l6ZSA+PSBwc2l6ZSApDQo+
ID4gKyAgICAgICAgICAgIHdoaWxlICggMSApDQo+ID4gICAgICAgICAgICAgICB7DQo+ID4gLSAg
ICAgICAgICAgICAgICBnc2l6ZSA9IGdzaXplIC0gcHNpemU7DQo+ID4gLSAgICAgICAgICAgICAg
ICBicmVhazsNCj4gPiArICAgICAgICAgICAgICAgIC8qIE1hcCBhcyBtdWNoIGFzIHBvc3NpYmxl
IHRoZSBzdGF0aWMgcmFuZ2UgdG8gdGhlIGd1ZXN0IGJhbmsgKi8NCj4gPiArICAgICAgICAgICAg
ICAgIGlmICggIWFwcGVuZF9zdGF0aWNfbWVtb3J5X3RvX2JhbmsoZCwgJmtpbmZvLT5tZW0uYmFu
a1tnYmFua10sDQo+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgIHNtZm4sIG1pbihwc2l6ZSwgZ3NpemUpKSApDQo+ID4gKyAgICAgICAgICAgICAg
ICAgICAgZ290byBmYWlsOw0KPiA+ICsNCj4gPiArICAgICAgICAgICAgICAgIC8qDQo+ID4gKyAg
ICAgICAgICAgICAgICAgKiBUaGUgY3VycmVudCBwaHlzaWNhbCBiYW5rIGlzIGZ1bGx5IG1hcHBl
ZC4NCj4gPiArICAgICAgICAgICAgICAgICAqIEhhbmRsZSB0aGUgbmV4dCBwaHlzaWNhbCBiYW5r
Lg0KPiA+ICsgICAgICAgICAgICAgICAgICovDQo+ID4gKyAgICAgICAgICAgICAgICBpZiAoIGdz
aXplID49IHBzaXplICkNCj4gPiArICAgICAgICAgICAgICAgIHsNCj4gPiArICAgICAgICAgICAg
ICAgICAgICBnc2l6ZSA9IGdzaXplIC0gcHNpemU7DQo+ID4gKyAgICAgICAgICAgICAgICAgICAg
YnJlYWs7DQo+ID4gKyAgICAgICAgICAgICAgICB9DQo+ID4gKyAgICAgICAgICAgICAgICAvKg0K
PiA+ICsgICAgICAgICAgICAgICAgICogV2hlbiBjdXJyZW50IGd1ZXN0IGJhbmsgaXMgbm90IGVu
b3VnaCB0byBtYXAsIGV4aGF1c3QNCj4gPiArICAgICAgICAgICAgICAgICAqIHRoZSBjdXJyZW50
IG9uZSBhbmQgc2VlayB0byB0aGUgbmV4dC4NCj4gPiArICAgICAgICAgICAgICAgICAqIEJlZm9y
ZSBzZWVraW5nIHRvIHRoZSBuZXh0LCBjaGVjayBpZiB3ZSBzdGlsbCBoYXZlIGF2YWlsYWJsZQ0K
PiA+ICsgICAgICAgICAgICAgICAgICogZ3Vlc3QgYmFuay4NCj4gPiArICAgICAgICAgICAgICAg
ICAqLw0KPiA+ICsgICAgICAgICAgICAgICAgZWxzZSBpZiAoIChnYmFuayArIDEpID49IEdVRVNU
X1JBTV9CQU5LUyApDQo+ID4gKyAgICAgICAgICAgICAgICB7DQo+ID4gKyAgICAgICAgICAgICAg
ICAgICAgcHJpbnRrKFhFTkxPR19FUlIgIkV4aGF1c3RlZCBhbGwgcG9zc2libGUgZ3Vlc3QgYmFu
a3MuXG4iKTsNCj4gPiArICAgICAgICAgICAgICAgICAgICBnb3RvIGZhaWw7DQo+ID4gKyAgICAg
ICAgICAgICAgICB9DQo+ID4gKyAgICAgICAgICAgICAgICBlbHNlDQo+ID4gKyAgICAgICAgICAg
ICAgICB7DQo+ID4gKyAgICAgICAgICAgICAgICAgICAgcHNpemUgPSBwc2l6ZSAtIGdzaXplOw0K
PiA+ICsgICAgICAgICAgICAgICAgICAgIHNtZm4gPSBtZm5fYWRkKHNtZm4sIGdzaXplID4+IFBB
R0VfU0hJRlQpOw0KPiA+ICsgICAgICAgICAgICAgICAgICAgIC8qIFVwZGF0ZSB0byB0aGUgbmV4
dCBndWVzdCBiYW5rLiAqLw0KPiA+ICsgICAgICAgICAgICAgICAgICAgIGdiYW5rKys7DQo+ID4g
KyAgICAgICAgICAgICAgICAgICAgZ3NpemUgPSByYW1zaXplW2diYW5rXTsNCj4gPiArICAgICAg
ICAgICAgICAgICAgICBraW5mby0+bWVtLmJhbmtbZ2JhbmtdLnN0YXJ0ID0gcmFtYmFzZVtnYmFu
a107DQo+ID4gKyAgICAgICAgICAgICAgICB9DQo+ID4gICAgICAgICAgICAgICB9DQo+ID4gKyAg
ICAgICAgfQ0KPiA+ICsgICAgICAgIGVsc2UgLyogMToxIGRpcmVjdC1tYXAuICovDQo+ID4gKyAg
ICAgICAgew0KPiA+ICAgICAgICAgICAgICAgLyoNCj4gPiAtICAgICAgICAgICAgICogV2hlbiBj
dXJyZW50IGd1ZXN0IGJhbmsgaXMgbm90IGVub3VnaCB0byBtYXAsIGV4aGF1c3QNCj4gPiAtICAg
ICAgICAgICAgICogdGhlIGN1cnJlbnQgb25lIGFuZCBzZWVrIHRvIHRoZSBuZXh0Lg0KPiA+IC0g
ICAgICAgICAgICAgKiBCZWZvcmUgc2Vla2luZyB0byB0aGUgbmV4dCwgY2hlY2sgaWYgd2Ugc3Rp
bGwgaGF2ZSBhdmFpbGFibGUNCj4gPiAtICAgICAgICAgICAgICogZ3Vlc3QgYmFuay4NCj4gPiAr
ICAgICAgICAgICAgICogT25lIGd1ZXN0IG1lbW9yeSBiYW5rIGlzIG1hdGNoZWQgd2l0aCBvbmUg
cGh5c2ljYWwNCj4gPiArICAgICAgICAgICAgICogbWVtb3J5IGJhbmsuDQo+ID4gICAgICAgICAg
ICAgICAgKi8NCj4gPiAtICAgICAgICAgICAgZWxzZSBpZiAoIChnYmFuayArIDEpID49IEdVRVNU
X1JBTV9CQU5LUyApDQo+ID4gLSAgICAgICAgICAgIHsNCj4gPiAtICAgICAgICAgICAgICAgIHBy
aW50ayhYRU5MT0dfRVJSICJFeGhhdXN0ZWQgYWxsIHBvc3NpYmxlIGd1ZXN0IGJhbmtzLlxuIik7
DQo+ID4gKyAgICAgICAgICAgIGdiYW5rID0gYmFuazsNCj4gPiArICAgICAgICAgICAga2luZm8t
Pm1lbS5iYW5rW2diYW5rXS5zdGFydCA9IHBiYXNlOw0KPiA+ICsNCj4gPiArICAgICAgICAgICAg
aWYgKCAhYXBwZW5kX3N0YXRpY19tZW1vcnlfdG9fYmFuayhkLCAma2luZm8tPm1lbS5iYW5rW2di
YW5rXSwNCj4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICBzbWZuLCBwc2l6ZSkgKQ0KPiA+ICAgICAgICAgICAgICAgICAgIGdvdG8gZmFpbDsNCj4gPiAt
ICAgICAgICAgICAgfQ0KPiA+IC0gICAgICAgICAgICBlbHNlDQo+ID4gLSAgICAgICAgICAgIHsN
Cj4gPiAtICAgICAgICAgICAgICAgIHBzaXplID0gcHNpemUgLSBnc2l6ZTsNCj4gPiAtICAgICAg
ICAgICAgICAgIHNtZm4gPSBtZm5fYWRkKHNtZm4sIGdzaXplID4+IFBBR0VfU0hJRlQpOw0KPiA+
IC0gICAgICAgICAgICAgICAgLyogVXBkYXRlIHRvIHRoZSBuZXh0IGd1ZXN0IGJhbmsuICovDQo+
ID4gLSAgICAgICAgICAgICAgICBnYmFuaysrOw0KPiA+IC0gICAgICAgICAgICAgICAgZ3NpemUg
PSByYW1zaXplW2diYW5rXTsNCj4gPiAtICAgICAgICAgICAgICAgIGtpbmZvLT5tZW0uYmFua1tn
YmFua10uc3RhcnQgPSByYW1iYXNlW2diYW5rXTsNCj4gPiAtICAgICAgICAgICAgfQ0KPiA+ICAg
ICAgICAgICB9DQo+ID4NCj4gPiAgICAgICAgICAgdG90X3NpemUgKz0gcHNpemU7DQo+ID4gQEAg
LTI2MzgsNiArMjY2Myw3IEBAIHZvaWQgX19pbml0IGNyZWF0ZV9kb21Vcyh2b2lkKQ0KPiA+ICAg
ew0KPiA+ICAgICAgIHN0cnVjdCBkdF9kZXZpY2Vfbm9kZSAqbm9kZTsNCj4gPiAgICAgICBjb25z
dCBzdHJ1Y3QgZHRfZGV2aWNlX25vZGUgKmNob3NlbiA9DQo+ID4gZHRfZmluZF9ub2RlX2J5X3Bh
dGgoIi9jaG9zZW4iKTsNCj4gPiArICAgIGJvb2wgZGlyZWN0X21hcCA9IGZhbHNlOw0KPiANCj4g
VGhpcyBpcyBhIGJpdCByZWR1bmRhbnQgZm9yIGp1c3QgYSBjb3VwbGUgb2YgdXNlLiBJbnN0ZWFk
LCB5b3UgY291bGQgZGlyZWN0bHkgdXNlDQo+IGRfY2ZnLmZsYWdzICYgWEVOX0RPTUNUTF9JTlRF
Uk5BTF9kaXJlY3RtYXAuDQo+IA0KPiA+DQo+ID4gICAgICAgQlVHX09OKGNob3NlbiA9PSBOVUxM
KTsNCj4gPiAgICAgICBkdF9mb3JfZWFjaF9jaGlsZF9ub2RlKGNob3Nlbiwgbm9kZSkgQEAgLTI2
NTgsOCArMjY4NCwxNyBAQCB2b2lkDQo+ID4gX19pbml0IGNyZWF0ZV9kb21Vcyh2b2lkKQ0KPiA+
ICAgICAgICAgICAgICAgcGFuaWMoIk1pc3NpbmcgcHJvcGVydHkgJ2NwdXMnIGZvciBkb21haW4g
JXNcbiIsDQo+ID4gICAgICAgICAgICAgICAgICAgICBkdF9ub2RlX25hbWUobm9kZSkpOw0KPiA+
DQo+ID4gKyAgICAgICAgZGlyZWN0X21hcCA9IGR0X3Byb3BlcnR5X3JlYWRfYm9vbChub2RlLCAi
ZGlyZWN0LW1hcCIpOw0KPiA+ICsgICAgICAgIGRfY2ZnLmZsYWdzIHw9IGRpcmVjdF9tYXAgPyBY
RU5fRE9NQ1RMX0lOVEVSTkFMX2RpcmVjdG1hcCA6DQo+ID4gKyAwOw0KPiA+ICAgICAgICAgICBp
ZiAoIGR0X2ZpbmRfY29tcGF0aWJsZV9ub2RlKG5vZGUsIE5VTEwsICJtdWx0aWJvb3QsZGV2aWNl
LXRyZWUiKSApDQo+ID4gLSAgICAgICAgICAgIGRfY2ZnLmZsYWdzIHw9IFhFTl9ET01DVExfQ0RG
X2lvbW11Ow0KPiA+ICsgICAgICAgIHsNCj4gPiArICAgICAgICAgICAgaWYgKCBpb21tdV9lbmFi
bGVkICkNCj4gPiArICAgICAgICAgICAgICAgIGRfY2ZnLmZsYWdzIHw9IFhFTl9ET01DVExfQ0RG
X2lvbW11Ow0KPiA+ICsgICAgICAgICAgICBlbHNlIGlmICggIWRpcmVjdF9tYXAgKQ0KPiA+ICsg
ICAgICAgICAgICAgICAgcGFuaWMoIkFzc2lnbiBhIGRldmljZSBidXQgSU9NTVUgYW5kIGRpcmVj
dC1tYXAgYXJlIGFsbA0KPiBkaXNhYmxlZFxuIik7DQo+ID4gKyAgICAgICAgICAgIGVsc2UNCj4g
PiArICAgICAgICAgICAgICAgIHdhcm5pbmdfYWRkKCJQbGVhc2UgYmUgc3VyZSBvZiBoYXZpbmcg
dHJ1c3RlZCBndWVzdHMsIHdoZW4gZG9pbmcNCj4gZGV2aWNlIGFzc2lnbm1lbnQgd2l0aG91dCBJ
T01NVSBwcm90ZWN0aW9uXG4iKTsNCj4gPiArICAgICAgICB9DQo+ID4NCj4gPiAgICAgICAgICAg
aWYgKCAhZHRfcHJvcGVydHlfcmVhZF91MzIobm9kZSwgIm5yX3NwaXMiLCAmZF9jZmcuYXJjaC5u
cl9zcGlzKSApDQo+ID4gICAgICAgICAgIHsNCj4gPg0KPiANCj4gQ2hlZXJzLA0KPiANCj4gLS0N
Cj4gSnVsaWVuIEdyYWxsDQoNCkNoZWVycywNCg0KLS0NClBlbm55IFpoZW5nDQo=


From xen-devel-bounces@lists.xenproject.org Fri Oct 08 03:18:23 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Oct 2021 03:18:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.204299.359420 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYgOm-00083b-G8; Fri, 08 Oct 2021 03:18:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 204299.359420; Fri, 08 Oct 2021 03:18:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYgOm-00083U-DA; Fri, 08 Oct 2021 03:18:16 +0000
Received: by outflank-mailman (input) for mailman id 204299;
 Fri, 08 Oct 2021 03:18:14 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mYgOk-00083K-JW; Fri, 08 Oct 2021 03:18:14 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mYgOk-00011s-AU; Fri, 08 Oct 2021 03:18:14 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mYgOk-0000fw-0t; Fri, 08 Oct 2021 03:18:14 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mYgOj-0005Hd-W5; Fri, 08 Oct 2021 03:18:14 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=8hzE72HH6xoRBa0gG4pwQseN7h9R+dfZxOTTZhCt3r8=; b=O3FNh7aSrngBjYUIHESImlv+Qd
	Z6U/KBJ0oXLUV9k26PAPlSBY/UKJPXDUJNl3svPB3nw35xCzbANQm6y9X21AwfDaMQlD94E1Z9Fee
	xbOpDirm+qWMgTzpbdewbs19ATH/xI5oY4GbQ+uYumtzpvJoMW1hcziqRNE31Njb2XX0=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165423-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 165423: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=1d345539c0e3654025fc00187bf633fda6ea9a43
X-Osstest-Versions-That:
    xen=2075b410ee8087662c880213c3aca196fb7ade22
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 08 Oct 2021 03:18:14 +0000

flight 165423 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165423/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  1d345539c0e3654025fc00187bf633fda6ea9a43
baseline version:
 xen                  2075b410ee8087662c880213c3aca196fb7ade22

Last test of basis   165420  2021-10-07 20:02:52 Z    0 days
Testing same since   165423  2021-10-08 00:01:40 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
  Stefano Stabellini <stefano.stabellini@xilinx.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   2075b410ee..1d345539c0  1d345539c0e3654025fc00187bf633fda6ea9a43 -> smoke


From xen-devel-bounces@lists.xenproject.org Fri Oct 08 03:26:58 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Oct 2021 03:26:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.204309.359435 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYgX3-00013y-Cs; Fri, 08 Oct 2021 03:26:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 204309.359435; Fri, 08 Oct 2021 03:26:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYgX3-00013r-9m; Fri, 08 Oct 2021 03:26:49 +0000
Received: by outflank-mailman (input) for mailman id 204309;
 Fri, 08 Oct 2021 03:26:48 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mYgX2-00013h-GU; Fri, 08 Oct 2021 03:26:48 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mYgX2-00019L-6t; Fri, 08 Oct 2021 03:26:48 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mYgX1-0001F1-VF; Fri, 08 Oct 2021 03:26:48 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mYgX1-0003i2-Uj; Fri, 08 Oct 2021 03:26:47 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=YU1wx3xZfDn0A3rtvD67xy3vM3Qt8kPEjBZRyrKUVe4=; b=28WewgzpxryFeD8S1/xvq+Z+1k
	OS80rZa4YXhSjL9pSb+B0leEvqjT+q/RfIolc8N6QVKc22QQT+4ZRtlvsLK8nw2sahRKrSXMF1H+4
	kQIf0MJb2U3MmJ4bHtjYNPa0AAVVy1Saf0/IJkxCgnO+IuezyDlsRKaw7gIruCLuywC4=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165412-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 165412: regressions - FAIL
X-Osstest-Failures:
    libvirt:build-amd64-libvirt:libvirt-build:fail:regression
    libvirt:build-armhf-libvirt:libvirt-build:fail:regression
    libvirt:build-arm64-libvirt:libvirt-build:fail:regression
    libvirt:build-i386-libvirt:libvirt-build:fail:regression
    libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    libvirt=3f9c1a4bb8416dafdaa89358498233aa6684377c
X-Osstest-Versions-That:
    libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 08 Oct 2021 03:26:47 +0000

flight 165412 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165412/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-armhf-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-arm64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-i386-libvirt            6 libvirt-build            fail REGR. vs. 151777

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-libvirt-vhd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a

version targeted for testing:
 libvirt              3f9c1a4bb8416dafdaa89358498233aa6684377c
baseline version:
 libvirt              2c846fa6bcc11929c9fb857a22430fb9945654ad

Last test of basis   151777  2020-07-10 04:19:19 Z  454 days
Failing since        151818  2020-07-11 04:18:52 Z  453 days  439 attempts
Testing same since   165412  2021-10-07 14:03:06 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
    Adolfo Jayme Barrientos <fitoschido@gmail.com>
  Aleksandr Alekseev <alexander.alekseev@virtuozzo.com>
  Aleksei Zakharov <zaharov@selectel.ru>
  Andika Triwidada <andika@gmail.com>
  Andrea Bolognani <abologna@redhat.com>
  Ani Sinha <ani@anisinha.ca>
  Balázs Meskó <meskobalazs@mailbox.org>
  Barrett Schonefeld <bschoney@utexas.edu>
  Bastian Germann <bastiangermann@fishpost.de>
  Bastien Orivel <bastien.orivel@diateam.net>
  BiaoXiang Ye <yebiaoxiang@huawei.com>
  Bihong Yu <yubihong@huawei.com>
  Binfeng Wu <wubinfeng@huawei.com>
  Bjoern Walk <bwalk@linux.ibm.com>
  Boris Fiuczynski <fiuczy@linux.ibm.com>
  Brian Turek <brian.turek@gmail.com>
  Bruno Haible <bruno@clisp.org>
  Chris Mayo <aklhfex@gmail.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Ehrhardt <christian.ehrhardt@canonical.com>
  Christian Kirbach <christian.kirbach@gmail.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Cole Robinson <crobinso@redhat.com>
  Collin Walling <walling@linux.ibm.com>
  Cornelia Huck <cohuck@redhat.com>
  Cédric Bosdonnat <cbosdonnat@suse.com>
  Côme Borsoi <fedora@borsoi.fr>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniel Letai <dani@letai.org.il>
  Daniel P. Berrange <berrange@redhat.com>
  Daniel P. Berrangé <berrange@redhat.com>
  Didik Supriadi <didiksupriadi41@gmail.com>
  dinglimin <dinglimin@cmss.chinamobile.com>
  Dmytro Linkin <dlinkin@nvidia.com>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Eric Farman <farman@linux.ibm.com>
  Erik Skultety <eskultet@redhat.com>
  Fabian Affolter <mail@fabian-affolter.ch>
  Fabian Freyer <fabian.freyer@physik.tu-berlin.de>
  Fabiano Fidêncio <fabiano@fidencio.org>
  Fangge Jin <fjin@redhat.com>
  Farhan Ali <alifm@linux.ibm.com>
  Fedora Weblate Translation <i18n@lists.fedoraproject.org>
  gongwei <gongwei@smartx.com>
  Guoyi Tu<tu.guoyi@h3c.com>
  Göran Uddeborg <goeran@uddeborg.se>
  Halil Pasic <pasic@linux.ibm.com>
  Han Han <hhan@redhat.com>
  Hao Wang <wanghao232@huawei.com>
  Hela Basa <r45xveza@pm.me>
  Helmut Grohne <helmut@subdivi.de>
  Hiroki Narukawa <hnarukaw@yahoo-corp.jp>
  Ian Wienand <iwienand@redhat.com>
  Jakob Meng <jakobmeng@web.de>
  Jamie Strandboge <jamie@canonical.com>
  Jamie Strandboge <jamie@ubuntu.com>
  Jan Kuparinen <copper_fin@hotmail.com>
  jason lee <ppark5237@gmail.com>
  Jean-Baptiste Holcroft <jean-baptiste@holcroft.fr>
  Jia Zhou <zhou.jia2@zte.com.cn>
  Jianan Gao <jgao@redhat.com>
  Jim Fehlig <jfehlig@suse.com>
  Jin Yan <jinyan12@huawei.com>
  Jinsheng Zhang <zhangjl02@inspur.com>
  Jiri Denemark <jdenemar@redhat.com>
  John Ferlan <jferlan@redhat.com>
  Jonathan Watt <jwatt@jwatt.org>
  Jonathon Jongsma <jjongsma@redhat.com>
  Julio Faracco <jcfaracco@gmail.com>
  Justin Gatzen <justin.gatzen@gmail.com>
  Ján Tomko <jtomko@redhat.com>
  Kashyap Chamarthy <kchamart@redhat.com>
  Kevin Locke <kevin@kevinlocke.name>
  Kristina Hanicova <khanicov@redhat.com>
  Laine Stump <laine@redhat.com>
  Laszlo Ersek <lersek@redhat.com>
  Lee Yarwood <lyarwood@redhat.com>
  Lei Yang <yanglei209@huawei.com>
  Liao Pingfang <liao.pingfang@zte.com.cn>
  Lin Ma <lma@suse.com>
  Lin Ma <lma@suse.de>
  Lin Ma <morecache@gmail.com>
  Liu Yiding <liuyd.fnst@fujitsu.com>
  Luke Yue <lukedyue@gmail.com>
  Luyao Zhong <luyao.zhong@intel.com>
  Marc Hartmayer <mhartmay@linux.ibm.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Markus Schade <markus.schade@hetzner.com>
  Martin Kletzander <mkletzan@redhat.com>
  Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
  Matej Cepl <mcepl@cepl.eu>
  Matt Coleman <matt@datto.com>
  Matt Coleman <mcoleman@datto.com>
  Mauro Matteo Cascella <mcascell@redhat.com>
  Meina Li <meili@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Michał Smyk <fedora@smyk.it>
  Milo Casagrande <milo@milo.name>
  Moshe Levi <moshele@nvidia.com>
  Muha Aliss <muhaaliss@gmail.com>
  Nathan <nathan95@live.it>
  Neal Gompa <ngompa13@gmail.com>
  Nick Chevsky <nchevsky@gmail.com>
  Nick Shyrokovskiy <nshyrokovskiy@gmail.com>
  Nickys Music Group <nickys.music.group@gmail.com>
  Nico Pache <npache@redhat.com>
  Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
  Olaf Hering <olaf@aepfle.de>
  Olesya Gerasimenko <gammaray@basealt.ru>
  Orion Poplawski <orion@nwra.com>
  Pany <geekpany@gmail.com>
  Patrick Magauran <patmagauran.j@gmail.com>
  Paulo de Rezende Pinatti <ppinatti@linux.ibm.com>
  Pavel Hrdina <phrdina@redhat.com>
  Peng Liang <liangpeng10@huawei.com>
  Peter Krempa <pkrempa@redhat.com>
  Pino Toscano <ptoscano@redhat.com>
  Pino Toscano <toscano.pino@tiscali.it>
  Piotr Drąg <piotrdrag@gmail.com>
  Prathamesh Chavan <pc44800@gmail.com>
  Richard W.M. Jones <rjones@redhat.com>
  Ricky Tigg <ricky.tigg@gmail.com>
  Robin Lee <cheeselee@fedoraproject.org>
  Roman Bogorodskiy <bogorodskiy@gmail.com>
  Roman Bolshakov <r.bolshakov@yadro.com>
  Ryan Gahagan <rgahagan@cs.utexas.edu>
  Ryan Schmidt <git@ryandesign.com>
  Sam Hartman <hartmans@debian.org>
  Scott Shambarger <scott-libvirt@shambarger.net>
  Sebastian Mitterle <smitterl@redhat.com>
  SeongHyun Jo <caelus9536@gmail.com>
  Shalini Chellathurai Saroja <shalini@linux.ibm.com>
  Shaojun Yang <yangshaojun@phytium.com.cn>
  Shi Lei <shi_lei@massclouds.com>
  simmon <simmon@nplob.com>
  Simon Chopin <chopin.simon@gmail.com>
  Simon Gaiser <simon@invisiblethingslab.com>
  Simon Rowe <simon.rowe@nutanix.com>
  Stefan Bader <stefan.bader@canonical.com>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Berger <stefanb@linux.vnet.ibm.com>
  Stefan Hajnoczi <stefanha@gmail.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Szymon Scholz <szymonscholz@gmail.com>
  Thomas Huth <thuth@redhat.com>
  Tim Wiederhake <twiederh@redhat.com>
  Tomáš Golembiovský <tgolembi@redhat.com>
  Tomáš Janoušek <tomi@nomi.cz>
  Tuguoyi <tu.guoyi@h3c.com>
  Victor Toso <victortoso@redhat.com>
  Ville Skyttä <ville.skytta@iki.fi>
  Vinayak Kale <vkale@nvidia.com>
  Wang Xin <wangxinxin.wang@huawei.com>
  WangJian <wangjian161@huawei.com>
  Weblate <noreply@weblate.org>
  Wei Liu <liuwe@microsoft.com>
  Wei Liu <wei.liu@kernel.org>
  William Douglas <william.douglas@intel.com>
  Yalei Li <274268859@qq.com>
  Yalei Li <liyl43@chinatelecom.cn>
  Yang Fei <yangfei85@huawei.com>
  Yang Hang <yanghang44@huawei.com>
  Yanqiu Zhang <yanqzhan@redhat.com>
  Yaroslav Kargin <ykargin@virtuozzo.com>
  Yi Li <yili@winhong.com>
  Yi Wang <wang.yi59@zte.com.cn>
  Yuri Chornoivan <yurchor@ukr.net>
  Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
  zhangjl02 <zhangjl02@inspur.com>
  Zheng Chuan <zhengchuan@huawei.com>
  zhenwei pi <pizhenwei@bytedance.com>
  Zhenyu Ye <yezhenyu2@huawei.com>
  Zhenyu Zheng <zheng.zhenyu@outlook.com>
  Zhenzhong Duan <zhenzhong.duan@intel.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          fail    
 build-arm64-libvirt                                          fail    
 build-armhf-libvirt                                          fail    
 build-i386-libvirt                                           fail    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           blocked 
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-libvirt-xsm                                 blocked 
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-libvirt                                     blocked 
 test-arm64-arm64-libvirt                                     blocked 
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-libvirt-pair                                blocked 
 test-amd64-i386-libvirt-pair                                 blocked 
 test-arm64-arm64-libvirt-qcow2                               blocked 
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-libvirt-vhd                                 blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 77188 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Oct 08 04:13:13 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Oct 2021 04:13:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.204319.359449 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYhFs-00066E-TN; Fri, 08 Oct 2021 04:13:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 204319.359449; Fri, 08 Oct 2021 04:13:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYhFs-000667-Om; Fri, 08 Oct 2021 04:13:08 +0000
Received: by outflank-mailman (input) for mailman id 204319;
 Fri, 08 Oct 2021 04:13:07 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=aW5g=O4=gmail.com=christopher.w.clark@srs-us1.protection.inumbo.net>)
 id 1mYhFr-000661-Jc
 for xen-devel@lists.xenproject.org; Fri, 08 Oct 2021 04:13:07 +0000
Received: from mail-qk1-x729.google.com (unknown [2607:f8b0:4864:20::729])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 93aba899-0bd5-4b70-8847-6d0490c11ff3;
 Fri, 08 Oct 2021 04:13:06 +0000 (UTC)
Received: by mail-qk1-x729.google.com with SMTP id z40so6855093qko.7
 for <xen-devel@lists.xenproject.org>; Thu, 07 Oct 2021 21:13:06 -0700 (PDT)
Received: from walnut.ice.pyrology.org (mobile-166-176-184-109.mycingular.net.
 [166.176.184.109])
 by smtp.gmail.com with ESMTPSA id c76sm1167189qke.83.2021.10.07.21.13.02
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Thu, 07 Oct 2021 21:13:05 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 93aba899-0bd5-4b70-8847-6d0490c11ff3
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:mime-version
         :content-transfer-encoding;
        bh=LtUo9sTo1YMnKekRV5cR43FFb2t/tyjbt+ypinT/AEg=;
        b=pfZXH4bGNQmJMUVBq+gFkS1ggD0yliL4hK6qLPNL/3OgUH8KcEyqzyjVRn39ZNctKv
         fTOwOJTcYN177yn7/+5Jecxs/0hhsEOjjNTIgWoBk/CIIBSOXk1Ax27Hf3GsWra7K0Up
         xDR5a1xwVFxl4o2crdVvimIfz/a89cEwgvm0KO7GFjJOjAtUGnE3g74kAYABkZGVTKcU
         H7NWGfKwxmTz6x8LUbT5FsgH5QYmIButVwYAS4wEL8PWy/qtiuX9uBqHMDf7QPt+glqP
         C4VpIHasRfaNPL1WHWzwhgGvtoe7tADFatyr2Z6SV+/fU6LoqUJnd968As8wIWGrS9RM
         /WvA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version
         :content-transfer-encoding;
        bh=LtUo9sTo1YMnKekRV5cR43FFb2t/tyjbt+ypinT/AEg=;
        b=tAwwkFdKJEs9w/q3l9a/vUmPG545JRmIElYeThZfnSDxotSHtBQwWsOU/aQX7QDx56
         oxMtiESgw5aSoPj4LcnpTSo+l45AriGubrM8h6MnNl6zhUN0XFaKsSHUEW2vkqTMXLVV
         Ingh/TSERjFNGD+lh3gtpTzptWpIEwPRU3JRPen4tou9wcs4qYB1+7vP4iCBdlmI6AGK
         xmqgqKhzhyPnrgu6pJi4PoPzw+o4K4d5QtvjTGc7K6aXocowMFrrV4s+T9PnvTJMHE+H
         cGD4NevAXNNCgcGj2liHwdL+NZ5Gziy6xTz56fYN/OIllbBvsg3VmEETk1uLjLwyCST3
         fMtA==
X-Gm-Message-State: AOAM533KMXWBfwwn9PubWo7QVs9M7zTSflIxr9FtGuQGZ7TtVf3rhQ4K
	FIKjQDnGoIkSZbL6nh+GTlGiAyLS50TQug==
X-Google-Smtp-Source: ABdhPJxOjATEY73JNlODHT98Df7cljPMZBUgJLILAvKA6BUO2HQRsSay1RcC/xRP+WIxGM6r+d5b6w==
X-Received: by 2002:a37:45c8:: with SMTP id s191mr1038033qka.355.1633666386158;
        Thu, 07 Oct 2021 21:13:06 -0700 (PDT)
From: Christopher Clark <christopher.w.clark@gmail.com>
To: xen-devel@lists.xenproject.org
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Ian Jackson <iwj@xenproject.org>,
	Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wl@xen.org>,
	Rich Persaud <persaur@gmail.com>,
	Daniel Smith <dpsmith@apertussolutions.com>,
	Jason Andryuk <jandryuk@gmail.com>,
	Eric Chanudet <chanudeter@gmail.com>,
	openxt@googlegroups.com
Subject: [PATCH] docs: add references to Argo Linux driver sources and information
Date: Thu,  7 Oct 2021 21:12:41 -0700
Message-Id: <20211008041241.227823-1-christopher.w.clark@gmail.com>
X-Mailer: git-send-email 2.25.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Add a section to the Argo design document to supply guidance on how to
enable Argo in Xen and where to obtain source code and documentation
for Argo device drivers for guest OSes, primarily from OpenXT.

Signed-off-by: Christopher Clark <christopher.w.clark@gmail.com>
---
 docs/designs/argo.pandoc | 45 ++++++++++++++++++++++++++++++++++++++++
 1 file changed, 45 insertions(+)

diff --git a/docs/designs/argo.pandoc b/docs/designs/argo.pandoc
index 2ce253b654..74c8ae4ac7 100644
--- a/docs/designs/argo.pandoc
+++ b/docs/designs/argo.pandoc
@@ -439,6 +439,51 @@ that teardown of any domain will not interfere with any Argo hypercall
 operation. It enables introducing granular locking without complex or
 error-prone lock acquisition logic.
 
+# Related Material
+
+## Enabling Argo in Xen
+
+To enable Argo in a build of the Xen hypervisor, please ensure that
+CONFIG_ARGO is enabled in the Xen hypervisor build configuration file.
+
+To make Argo available for use at runtime on a Xen system, please see the
+Argo settings in the Xen command line document.
+
+## Linux Argo drivers
+
+A Linux kernel device driver for Argo and corresponding Linux userspace
+software, libargo, that utilizes it for interdomain communication between
+application level software is available and maintained by the OpenXT Project,
+at:
+
+https://github.com/OpenXT/linux-xen-argo
+
+The repository contains the primary Linux kernel Argo driver, which is derived
+from the original XenClient v4v driver. The document at the following link
+describes planning and design notes from OpenXT community discussion for
+improvements to the driver:
+
+https://openxt.atlassian.net/wiki/spaces/DC/pages/775389197/New+Linux+Driver+for+Argo
+
+An alternative Linux Argo driver is in also available in the same repository,
+implemented to explore a different approach for Linux to use the Argo
+primitives under the Vsock address family to allow socket communication between
+Xen domains.
+
+## v4v drivers
+
+A Windows driver for v4v has previously been used in XenClient and OpenXT
+which could be ported to Argo. It may require update for compatibility with
+recent versions of Windows software.
+
+https://github.com/OpenXT/xc-windows/tree/master/xenv4v
+
+The Linux, Windows and OSX guest tools for the Open Source HP uxen hypervisor
+contain drivers for v4v which are relevant as code bases of interest for
+porting or developing new guest OS drivers for Argo.
+
+https://github.com/uxen-virt/uxen/tree/ascara/vm-support
+
 # Future Work
 
 - Performance measurement and optimization
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Fri Oct 08 05:55:53 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Oct 2021 05:55:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.204330.359482 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYirH-0008Ca-JH; Fri, 08 Oct 2021 05:55:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 204330.359482; Fri, 08 Oct 2021 05:55:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYirH-0008CN-Fz; Fri, 08 Oct 2021 05:55:51 +0000
Received: by outflank-mailman (input) for mailman id 204330;
 Fri, 08 Oct 2021 05:55:50 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ipo1=O4=gmail.com=andr2000@srs-us1.protection.inumbo.net>)
 id 1mYirG-0007cA-Jm
 for xen-devel@lists.xenproject.org; Fri, 08 Oct 2021 05:55:50 +0000
Received: from mail-lf1-x12f.google.com (unknown [2a00:1450:4864:20::12f])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id ed7e8cc1-4239-4f45-8045-5b34d893a9a8;
 Fri, 08 Oct 2021 05:55:41 +0000 (UTC)
Received: by mail-lf1-x12f.google.com with SMTP id y26so34944528lfa.11
 for <xen-devel@lists.xenproject.org>; Thu, 07 Oct 2021 22:55:41 -0700 (PDT)
Received: from localhost.localdomain (host-176-36-245-220.b024.la.net.ua.
 [176.36.245.220])
 by smtp.gmail.com with ESMTPSA id f8sm151147lfq.168.2021.10.07.22.55.39
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Thu, 07 Oct 2021 22:55:40 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ed7e8cc1-4239-4f45-8045-5b34d893a9a8
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=EUxyn0W/J9FSEJt/oYDsZ4o/QnKV7HT+djJUv5IJGRI=;
        b=FOHeQrPpZjYnooNZoJwcDT+3DsxC7jSXr0W62SmV6caWCd9lQwvAm+woeZ84HrSy8C
         wcj5F9sgXkqc2rQqDAxnc0LAj5WNybYKIIJxPsCffDMF0/UqdzXIxbyNLU9Us5OnhOE/
         F38tNM5+VU7HjSAxwtMytOdTgqLiTfRoDuUS8ORW5yjmm13zkM2bHWAMBVznfRVfkjl3
         rpJBF+8o18GItAHoAmDNdWYYxvthFdd9ZGPJCTGqhR5J3j6UExtc06qbyKnFfoSQkgZL
         71JFOK4QDeIQy/KkM4FiO48iayIr0i4m2VYfLp1HJyu108kte47sfl+1vs2rloZD/2tN
         Uh7w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=EUxyn0W/J9FSEJt/oYDsZ4o/QnKV7HT+djJUv5IJGRI=;
        b=WcPvAzEwT5u3Pz/Q424gWlNqlFSglK7ReC0sGZmEE/ObbGFEmTm6k47iWjOI8UOdC2
         X49jTVDc2buAuvkzAadUuDm9qKTAZZcAHyhYc/+p6eJ3eyUOR37zcxzooA2B47ibIk6U
         cEXIEDwUwNySkl95z6QaohyozizNqaOA2SDAL4uj9RPoK4t3+v1K8vbclEfLTxHc6QLM
         Ec71BP6XkJBekf0uL+ghlMOUp1+ooX3YeN3hatx0yPqpdhUIsNwG6+DFoJNBx7+3Gnlq
         wbvr9dGdPTacRNPPQCQd4m3mLDYVYlW3UPHqCU+1P/6+J8llWuphatDDUh+f+PLTTWll
         oqGA==
X-Gm-Message-State: AOAM530H8xeW39bUdrssGL66EcpmbEiFJAbUBXmkd8V02/yH28ePM3pK
	sE2m3qvNK6V0j/eyTEZTfPcCwRWkpIU=
X-Google-Smtp-Source: ABdhPJzpgP/E37Fhmrcnp+lC6oW8HAGf4BnPXjfohPryrmrhNQPYI3/Cf15FFhtcGNbKCrjKVfxDgg==
X-Received: by 2002:a05:6512:3502:: with SMTP id h2mr8706956lfs.415.1633672540556;
        Thu, 07 Oct 2021 22:55:40 -0700 (PDT)
From: Oleksandr Andrushchenko <andr2000@gmail.com>
To: xen-devel@lists.xenproject.org
Cc: julien@xen.org,
	sstabellini@kernel.org,
	oleksandr_tyshchenko@epam.com,
	volodymyr_babchuk@epam.com,
	Artem_Mygaiev@epam.com,
	roger.pau@citrix.com,
	jbeulich@suse.com,
	andrew.cooper3@citrix.com,
	george.dunlap@citrix.com,
	paul@xen.org,
	bertrand.marquis@arm.com,
	rahul.singh@arm.com,
	Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Subject: [PATCH v5 02/10] xen/arm: Introduce pci_find_host_bridge_node helper
Date: Fri,  8 Oct 2021 08:55:27 +0300
Message-Id: <20211008055535.337436-3-andr2000@gmail.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20211008055535.337436-1-andr2000@gmail.com>
References: <20211008055535.337436-1-andr2000@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>

Get host bridge node given a PCI device attached to it.

This helper will be re-used for adding PCI devices by the subsequent
patches.

Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
Reviewed-by: Rahul Singh <rahul.singh@arm.com>
Tested-by: Rahul Singh <rahul.singh@arm.com>
---
Since v2:
 - !! dropped Stefano's r-b because of the changes
 - s/PRI_pci/%pp after rebase onto Arm series
---
 xen/arch/arm/pci/pci-host-common.c | 16 ++++++++++++++++
 xen/include/asm-arm/pci.h          |  1 +
 2 files changed, 17 insertions(+)

diff --git a/xen/arch/arm/pci/pci-host-common.c b/xen/arch/arm/pci/pci-host-common.c
index 593beeb48ce4..592c01aae5bb 100644
--- a/xen/arch/arm/pci/pci-host-common.c
+++ b/xen/arch/arm/pci/pci-host-common.c
@@ -276,6 +276,22 @@ int pci_get_host_bridge_segment(const struct dt_device_node *node,
     return -EINVAL;
 }
 
+/*
+ * Get host bridge node given a device attached to it.
+ */
+struct dt_device_node *pci_find_host_bridge_node(struct device *dev)
+{
+    struct pci_host_bridge *bridge;
+    struct pci_dev *pdev = dev_to_pci(dev);
+
+    bridge = pci_find_host_bridge(pdev->seg, pdev->bus);
+    if ( unlikely(!bridge) )
+    {
+        printk(XENLOG_ERR "Unable to find PCI bridge for %pp\n", &pdev->sbdf);
+        return NULL;
+    }
+    return bridge->dt_node;
+}
 /*
  * Local variables:
  * mode: C
diff --git a/xen/include/asm-arm/pci.h b/xen/include/asm-arm/pci.h
index 7a91ebbdaf0c..9aa8eca53175 100644
--- a/xen/include/asm-arm/pci.h
+++ b/xen/include/asm-arm/pci.h
@@ -99,6 +99,7 @@ void __iomem *pci_ecam_map_bus(struct pci_host_bridge *bridge,
 struct pci_host_bridge *pci_find_host_bridge(uint16_t segment, uint8_t bus);
 int pci_get_host_bridge_segment(const struct dt_device_node *node,
                                 uint16_t *segment);
+struct dt_device_node *pci_find_host_bridge_node(struct device *dev);
 
 static always_inline bool is_pci_passthrough_enabled(void)
 {
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Fri Oct 08 05:55:53 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Oct 2021 05:55:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.204328.359460 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYir8-0007cN-0I; Fri, 08 Oct 2021 05:55:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 204328.359460; Fri, 08 Oct 2021 05:55:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYir7-0007cG-T8; Fri, 08 Oct 2021 05:55:41 +0000
Received: by outflank-mailman (input) for mailman id 204328;
 Fri, 08 Oct 2021 05:55:41 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ipo1=O4=gmail.com=andr2000@srs-us1.protection.inumbo.net>)
 id 1mYir6-0007cA-SH
 for xen-devel@lists.xenproject.org; Fri, 08 Oct 2021 05:55:40 +0000
Received: from mail-lf1-x12b.google.com (unknown [2a00:1450:4864:20::12b])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 9101059a-f8f1-44a8-a5f6-33a06cc19648;
 Fri, 08 Oct 2021 05:55:39 +0000 (UTC)
Received: by mail-lf1-x12b.google.com with SMTP id t9so33576715lfd.1
 for <xen-devel@lists.xenproject.org>; Thu, 07 Oct 2021 22:55:39 -0700 (PDT)
Received: from localhost.localdomain (host-176-36-245-220.b024.la.net.ua.
 [176.36.245.220])
 by smtp.gmail.com with ESMTPSA id f8sm151147lfq.168.2021.10.07.22.55.36
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Thu, 07 Oct 2021 22:55:37 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9101059a-f8f1-44a8-a5f6-33a06cc19648
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:mime-version
         :content-transfer-encoding;
        bh=VysqxQApJGno/WIkIxWmmKVDKvdviGneK1iv6SsMayM=;
        b=acvElKnNqP0avJnh0bgC/ZPIGwkgWeQx644wQ+xYjVcIThzM7/7GmFBqVIUMpCEptO
         742IWZZrnFwdGrC+twKQ3ppZwDJKBlcd3JxdSThM1CheELOpZIrH3fF9R3nWHqj6z791
         P928bPebowEIeyFLRNKZrHT716VY+Ng36CroilYUfEvxJYsemC3gRMQCpwhf8jWxElWz
         JUkJe1+9/DHINfhmxOPtEjZVfhMO82USwqw9SkQj2K+4b3jmlYQpVkq1Ruoh4+cvBu6g
         PRTfKVQUkF765S1Rtspj92BmzqMulElaGWZYtJMW3jV9pH5NU4FYaWAxhBq4VDwqus1N
         Fc5A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version
         :content-transfer-encoding;
        bh=VysqxQApJGno/WIkIxWmmKVDKvdviGneK1iv6SsMayM=;
        b=4OOML4qdr9W/lHzj4R9ZrlCv4E7bQ3N1zxHYcIwwF0cN7jo2UHrveMr1ibQRrHJTHL
         FbPT4Iy7JSnFudk+KlM7j+8rqOOlk65iHE5MHVModx7ODynmSNbUZCMIkrNZQOay1c8K
         aWDX27LPD1J0sWaMsDi6tqFagsQoPr2UtNQzXLJRzzykFmV8py3qRcIxAVv4iE2qFEg7
         /lIUMpdlDazF4mxAsKkkP32CqRc6JCyslQ8fbqEAmbeF5K8QBK3KI9IJ06ckgrEgJ1lG
         hJ5Q7Ba9/o+sS8MU0EUkel2u1cexzRjDq5TS8uOPapSx5nVeHapbFrzO8QZFFBMD2/MX
         qfww==
X-Gm-Message-State: AOAM5320JLjM3Zc48NNbNy0MPV3a8CnkZ2761uPH8FlbkE6h7OWi4kdJ
	lnFP4FsYMQ82mQBEqDA3YztXRmT2Qps=
X-Google-Smtp-Source: ABdhPJw5JgZNGwFi7iN743DxVBkkChQmgar0GiVWcT4Du15n0QJT+jgbrKZnuNV5RdjqReji186gDQ==
X-Received: by 2002:a05:6512:3f18:: with SMTP id y24mr8780631lfa.263.1633672538234;
        Thu, 07 Oct 2021 22:55:38 -0700 (PDT)
From: Oleksandr Andrushchenko <andr2000@gmail.com>
To: xen-devel@lists.xenproject.org
Cc: julien@xen.org,
	sstabellini@kernel.org,
	oleksandr_tyshchenko@epam.com,
	volodymyr_babchuk@epam.com,
	Artem_Mygaiev@epam.com,
	roger.pau@citrix.com,
	jbeulich@suse.com,
	andrew.cooper3@citrix.com,
	george.dunlap@citrix.com,
	paul@xen.org,
	bertrand.marquis@arm.com,
	rahul.singh@arm.com,
	Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Subject: [PATCH v5 00/10] PCI devices passthrough on Arm, part 2
Date: Fri,  8 Oct 2021 08:55:25 +0300
Message-Id: <20211008055535.337436-1-andr2000@gmail.com>
X-Mailer: git-send-email 2.25.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>

Hi, all!

This is an assorted series of patches which aim is to make some further
basis for PCI passthrough on Arm support. The series continues the work
published earlier by Arm [1] and adds new helpers and clears the way for
vPCI changes which will follow.

RFC is at [2], [3]. Design presentation can be found at [4].

Thank you,
Oleksandr

[1] https://patchwork.kernel.org/project/xen-devel/list/?series=558681
[2] https://lists.xenproject.org/archives/html/xen-devel/2020-07/msg01184.html
[3] https://lists.xenproject.org/archives/html/xen-devel/2020-07/threads.html#01184
[4] https://static.sched.com/hosted_files/xen2021/e4/PCI_Device_Passthrough_On_Arm.pdf

Oleksandr Andrushchenko (9):
  xen/arm: Add new device type for PCI
  xen/arm: Introduce pci_find_host_bridge_node helper
  xen/device-tree: Make dt_find_node_by_phandle global
  xen/arm: Mark device as PCI while creating one
  libxl: Allow removing PCI devices for all types of domains
  libxl: Only map legacy PCI IRQs if they are supported
  xen/arm: Setup MMIO range trap handlers for hardware domain
  xen/arm: Do not map PCI ECAM and MMIO space to Domain-0's p2m
  xen/arm: Process pending vPCI map/unmap operations

Oleksandr Tyshchenko (1):
  xen/domain: Call pci_release_devices() when releasing domain resources

 tools/libs/light/Makefile          |  4 ++
 tools/libs/light/libxl_pci.c       | 15 ++++-
 xen/arch/arm/domain.c              | 11 +++-
 xen/arch/arm/domain_build.c        | 57 ++++++++++--------
 xen/arch/arm/pci/ecam.c            | 14 +++++
 xen/arch/arm/pci/pci-host-common.c | 93 ++++++++++++++++++++++++++++++
 xen/arch/arm/pci/pci-host-zynqmp.c |  1 +
 xen/arch/arm/pci/pci.c             | 12 ++++
 xen/arch/arm/traps.c               | 13 +++++
 xen/arch/arm/vpci.c                | 34 +++++++++++
 xen/arch/arm/vpci.h                |  6 ++
 xen/arch/x86/hvm/hvm.c             |  6 ++
 xen/common/device_tree.c           |  2 +-
 xen/common/ioreq.c                 |  9 ---
 xen/drivers/passthrough/pci.c      |  2 +
 xen/include/asm-arm/device.h       |  4 +-
 xen/include/asm-arm/pci.h          | 30 ++++++++++
 xen/include/asm-arm/setup.h        | 13 +++++
 xen/include/asm-x86/pci.h          |  2 +
 xen/include/xen/device_tree.h      |  2 +
 20 files changed, 292 insertions(+), 38 deletions(-)

-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Fri Oct 08 05:55:53 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Oct 2021 05:55:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.204329.359471 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYirD-0007tX-Ca; Fri, 08 Oct 2021 05:55:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 204329.359471; Fri, 08 Oct 2021 05:55:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYirD-0007tQ-7g; Fri, 08 Oct 2021 05:55:47 +0000
Received: by outflank-mailman (input) for mailman id 204329;
 Fri, 08 Oct 2021 05:55:45 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ipo1=O4=gmail.com=andr2000@srs-us1.protection.inumbo.net>)
 id 1mYirB-0007cA-JT
 for xen-devel@lists.xenproject.org; Fri, 08 Oct 2021 05:55:45 +0000
Received: from mail-lf1-x12b.google.com (unknown [2a00:1450:4864:20::12b])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 9c5fd5ab-ae37-4376-a47b-316c2d53de2d;
 Fri, 08 Oct 2021 05:55:40 +0000 (UTC)
Received: by mail-lf1-x12b.google.com with SMTP id n8so32760045lfk.6
 for <xen-devel@lists.xenproject.org>; Thu, 07 Oct 2021 22:55:40 -0700 (PDT)
Received: from localhost.localdomain (host-176-36-245-220.b024.la.net.ua.
 [176.36.245.220])
 by smtp.gmail.com with ESMTPSA id f8sm151147lfq.168.2021.10.07.22.55.38
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Thu, 07 Oct 2021 22:55:38 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9c5fd5ab-ae37-4376-a47b-316c2d53de2d
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=iLqP26L1DNQh23hvf3ZfjEuWpTgHuOxZ20uNYqB0XcE=;
        b=MpsgDz2EDklsRLAuSDOWbiLR2VcxNJfHrA1tPUE77ucY8NSWsdjwS232cIqwIv9ApH
         xByv1hatc1R5qgBJZl8k9Z7m4YO6/hx03bEQg5Mzyg2IWneJ7zKAKkaoPw0gk9EV4R+q
         /UKQPKvhR7JEbLk02CtVl4XfOET53qbP9M0y8btSG54wkOVeVNCb/4KRq4Ow5tQxzh9z
         qUbmPk1m1pURzrSiuqqv72QUl2bW8qtjFMOJ20wkGKiu2361pFFX8CG82Hw/MNjwEGjD
         +guf5faGJ7o0QuFI9xcKSGufriKNqDGGW7Xy4pGcIUEQZ9fBdJ6S5WB791/w8PoJYuC3
         EuyA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=iLqP26L1DNQh23hvf3ZfjEuWpTgHuOxZ20uNYqB0XcE=;
        b=Re0aZr4QJhRlEiOpkfRXpMHIDKOmsM7ykM80g/EpWS0XTlrgUVy/L/CVsSHuGgrCIO
         O+M1s77r5NuZwUkcorkepYYljm8iCjjmjwXJraCPB4ZSsVCKUvdit2IAYTbNq4vYnzfQ
         LKguPl87z2bXge0NPowLWeufDtaJQORriIdyC+8cmR4OFA5D4oT+fkCqQUelGGUsSVza
         4RtE7sA9omNVr97WEiwhC+xPumLlRck5ZHPYV6fxpwwb35aAL+5JqyxqBhEQ/rMwHnTW
         akvyAGrxBHWSoHpD5qs78VaplEU17IaR1NK6VY01h8QKmnjcM6vQQsiZW4uKS1Zo3zEc
         GuBA==
X-Gm-Message-State: AOAM533cfEGcuc1zd6QipzFiknZd4uigyvJKgQquq7zmJuFneLHDRbqm
	5O/+RHego0ubgDi9Lv1993l1pXgfGIU=
X-Google-Smtp-Source: ABdhPJwShR3k/lP8Rgo+01PGGhT/UN3c9l9R0/Ub8JvsYOoalRg2/nRh9l9MlQ/Q6g7h9FgEiPO9kA==
X-Received: by 2002:a05:6512:20b:: with SMTP id a11mr8675587lfo.179.1633672539392;
        Thu, 07 Oct 2021 22:55:39 -0700 (PDT)
From: Oleksandr Andrushchenko <andr2000@gmail.com>
To: xen-devel@lists.xenproject.org
Cc: julien@xen.org,
	sstabellini@kernel.org,
	oleksandr_tyshchenko@epam.com,
	volodymyr_babchuk@epam.com,
	Artem_Mygaiev@epam.com,
	roger.pau@citrix.com,
	jbeulich@suse.com,
	andrew.cooper3@citrix.com,
	george.dunlap@citrix.com,
	paul@xen.org,
	bertrand.marquis@arm.com,
	rahul.singh@arm.com,
	Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Subject: [PATCH v5 01/10] xen/arm: Add new device type for PCI
Date: Fri,  8 Oct 2021 08:55:26 +0300
Message-Id: <20211008055535.337436-2-andr2000@gmail.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20211008055535.337436-1-andr2000@gmail.com>
References: <20211008055535.337436-1-andr2000@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>

Add new device type (DEV_PCI) to distinguish PCI devices from platform
DT devices, so some drivers, like IOMMU, can handle PCI devices
differently.

Also add a helper which is when given a struct device returns the
corresponding struct pci_dev which this device is a part of.

Because of the header cross-dependencies, e.g. we need both
struct pci_dev and struct arch_pci_dev at the same time, this cannot be
done with an inline.

Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
Reviewed-by: Rahul Singh <rahul.singh@arm.com>
Tested-by: Rahul Singh <rahul.singh@arm.com>
---
Since v2:
 - !! dropped Stefano's r-b because of the changes
 - simplified dev_to_pci to use a single
   container_of(dev, struct pci_dev, arch.dev) (Jan)
Since v1:
 - Folded new device type (DEV_PCI) into this patch.
---
 xen/arch/arm/pci/pci.c       | 7 +++++++
 xen/include/asm-arm/device.h | 4 ++--
 xen/include/asm-arm/pci.h    | 7 +++++++
 3 files changed, 16 insertions(+), 2 deletions(-)

diff --git a/xen/arch/arm/pci/pci.c b/xen/arch/arm/pci/pci.c
index 73540045d187..138da19284ab 100644
--- a/xen/arch/arm/pci/pci.c
+++ b/xen/arch/arm/pci/pci.c
@@ -27,6 +27,13 @@ int arch_pci_clean_pirqs(struct domain *d)
     return 0;
 }
 
+struct pci_dev *dev_to_pci(struct device *dev)
+{
+    ASSERT(dev->type == DEV_PCI);
+
+    return container_of(dev, struct pci_dev, arch.dev);
+}
+
 static int __init dt_pci_init(void)
 {
     struct dt_device_node *np;
diff --git a/xen/include/asm-arm/device.h b/xen/include/asm-arm/device.h
index ebe84ea853cd..7bf040560363 100644
--- a/xen/include/asm-arm/device.h
+++ b/xen/include/asm-arm/device.h
@@ -4,6 +4,7 @@
 enum device_type
 {
     DEV_DT,
+    DEV_PCI,
 };
 
 struct dev_archdata {
@@ -25,8 +26,7 @@ typedef struct device device_t;
 
 #include <xen/device_tree.h>
 
-/* TODO: Correctly implement dev_is_pci when PCI is supported on ARM */
-#define dev_is_pci(dev) ((void)(dev), 0)
+#define dev_is_pci(dev) ((dev)->type == DEV_PCI)
 #define dev_is_dt(dev)  ((dev)->type == DEV_DT)
 
 enum device_class
diff --git a/xen/include/asm-arm/pci.h b/xen/include/asm-arm/pci.h
index f99356af1eba..7a91ebbdaf0c 100644
--- a/xen/include/asm-arm/pci.h
+++ b/xen/include/asm-arm/pci.h
@@ -26,6 +26,13 @@ struct arch_pci_dev {
     struct device dev;
 };
 
+/*
+ * Because of the header cross-dependencies, e.g. we need both
+ * struct pci_dev and struct arch_pci_dev at the same time, this cannot be
+ * done with an inline here. Macro can be implemented, but looks scary.
+ */
+struct pci_dev *dev_to_pci(struct device *dev);
+
 /* Arch-specific MSI data for vPCI. */
 struct vpci_arch_msi {
 };
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Fri Oct 08 05:55:57 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Oct 2021 05:55:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.204331.359493 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYirM-00009G-UX; Fri, 08 Oct 2021 05:55:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 204331.359493; Fri, 08 Oct 2021 05:55:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYirM-00008v-PS; Fri, 08 Oct 2021 05:55:56 +0000
Received: by outflank-mailman (input) for mailman id 204331;
 Fri, 08 Oct 2021 05:55:55 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ipo1=O4=gmail.com=andr2000@srs-us1.protection.inumbo.net>)
 id 1mYirL-0007cA-K2
 for xen-devel@lists.xenproject.org; Fri, 08 Oct 2021 05:55:55 +0000
Received: from mail-lf1-x133.google.com (unknown [2a00:1450:4864:20::133])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 90c4cf70-19b2-48f6-9e40-8cadf5208682;
 Fri, 08 Oct 2021 05:55:42 +0000 (UTC)
Received: by mail-lf1-x133.google.com with SMTP id y26so34944657lfa.11
 for <xen-devel@lists.xenproject.org>; Thu, 07 Oct 2021 22:55:42 -0700 (PDT)
Received: from localhost.localdomain (host-176-36-245-220.b024.la.net.ua.
 [176.36.245.220])
 by smtp.gmail.com with ESMTPSA id f8sm151147lfq.168.2021.10.07.22.55.40
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Thu, 07 Oct 2021 22:55:41 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 90c4cf70-19b2-48f6-9e40-8cadf5208682
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=i+5xYEIb/HFPwhli6DC0XzWGZZlF9uvm17LAFke7DVg=;
        b=hpYqLI7plP5qH91EWtG+D9aX04Y6LRpU3DZFsjpYQgeYsKI2j/2su1CTssUSk8KGWN
         OvGcyCem5ovg1JTYQ1CqUITJam7LGBNj1MGUU6cW5nE6OIoLvs/gpmrUv4vOq7RycgiF
         zTRrz7JwqH3Geb/HOlgFjhjwR6JW7b7WZqYQrVaJagGJJ0I0plKNljDSL+jXhPECbGxU
         /KRWvy8upzo0c4BUA5+cx19afGxQf/qX9mW9pw5MhFswdfv4AdC3gSLYcB+99BcxHp8f
         46Z+ekb67TK3FZ4/QMXeH0DmpTwrOInfee0lESXwnVM1UJRl629tyvKMaPvBam4R09Fo
         kHvg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=i+5xYEIb/HFPwhli6DC0XzWGZZlF9uvm17LAFke7DVg=;
        b=Dud2ikU6soUYs1rOdQAiOgzjmJyE2C+j7VgfsQy8SPhFWEBbe04KFiTTo3dZAkvk/E
         o9o60u4uW9zWRu1fDBWN52ZheCCaHw02xvsj/Z++3kM9wfiN1UU1NfMqY1hyulNVBjox
         Pdf48KBqg5QIg6+jJO8HkzTI1FCcDaEsmFiYKjmkffUJVYux+V5DRPO8Tg/yK8GJYRv+
         j7tyfdWc/bVb3j+yZTWyF8Rj3r42kQM1fQJ5eToI1vvZY2zfHDW469wro8e6pPMFoRd3
         ziB6e3WUJGj+7QHju404zxr3erudrNU9WzaeYMX+thwfvFWstXur0AmttJKZHWGzcWwT
         XM+g==
X-Gm-Message-State: AOAM530W9Kgg4WBbXxFUNp8CMnUyTXImJyVe5KEVpD8W3VR72gfzJ0vU
	6oCCvnTWPY4NvjObgITScGnf3IsPC2Y=
X-Google-Smtp-Source: ABdhPJzot14ubwqEzFWSPCYc/moe+/KXUuMlro56Giypeef3N7rKA3JUcaJ3ZqVpmF8VHsmY/HRH9A==
X-Received: by 2002:a05:651c:169c:: with SMTP id bd28mr1466459ljb.476.1633672541674;
        Thu, 07 Oct 2021 22:55:41 -0700 (PDT)
From: Oleksandr Andrushchenko <andr2000@gmail.com>
To: xen-devel@lists.xenproject.org
Cc: julien@xen.org,
	sstabellini@kernel.org,
	oleksandr_tyshchenko@epam.com,
	volodymyr_babchuk@epam.com,
	Artem_Mygaiev@epam.com,
	roger.pau@citrix.com,
	jbeulich@suse.com,
	andrew.cooper3@citrix.com,
	george.dunlap@citrix.com,
	paul@xen.org,
	bertrand.marquis@arm.com,
	rahul.singh@arm.com,
	Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Subject: [PATCH v5 03/10] xen/device-tree: Make dt_find_node_by_phandle global
Date: Fri,  8 Oct 2021 08:55:28 +0300
Message-Id: <20211008055535.337436-4-andr2000@gmail.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20211008055535.337436-1-andr2000@gmail.com>
References: <20211008055535.337436-1-andr2000@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>

Make dt_find_node_by_phandle globally visible, so it can be re-used by
other frameworks.

Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
Reviewed-by: Rahul Singh <rahul.singh@arm.com>
Tested-by: Rahul Singh <rahul.singh@arm.com>
---
 xen/common/device_tree.c      | 2 +-
 xen/include/xen/device_tree.h | 2 ++
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/xen/common/device_tree.c b/xen/common/device_tree.c
index ea93da1725f6..4aae281e89bf 100644
--- a/xen/common/device_tree.c
+++ b/xen/common/device_tree.c
@@ -1047,7 +1047,7 @@ int dt_for_each_range(const struct dt_device_node *dev,
  *
  * Returns a node pointer.
  */
-static struct dt_device_node *dt_find_node_by_phandle(dt_phandle handle)
+struct dt_device_node *dt_find_node_by_phandle(dt_phandle handle)
 {
     struct dt_device_node *np;
 
diff --git a/xen/include/xen/device_tree.h b/xen/include/xen/device_tree.h
index 2297c59ce66d..fd6cd00b433a 100644
--- a/xen/include/xen/device_tree.h
+++ b/xen/include/xen/device_tree.h
@@ -849,6 +849,8 @@ int dt_count_phandle_with_args(const struct dt_device_node *np,
  */
 int dt_get_pci_domain_nr(struct dt_device_node *node);
 
+struct dt_device_node *dt_find_node_by_phandle(dt_phandle handle);
+
 #ifdef CONFIG_DEVICE_TREE_DEBUG
 #define dt_dprintk(fmt, args...)  \
     printk(XENLOG_DEBUG fmt, ## args)
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Fri Oct 08 05:56:02 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Oct 2021 05:56:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.204332.359504 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYirS-0000ig-7Q; Fri, 08 Oct 2021 05:56:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 204332.359504; Fri, 08 Oct 2021 05:56:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYirS-0000i0-3j; Fri, 08 Oct 2021 05:56:02 +0000
Received: by outflank-mailman (input) for mailman id 204332;
 Fri, 08 Oct 2021 05:56:00 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ipo1=O4=gmail.com=andr2000@srs-us1.protection.inumbo.net>)
 id 1mYirQ-0007cA-KE
 for xen-devel@lists.xenproject.org; Fri, 08 Oct 2021 05:56:00 +0000
Received: from mail-lf1-x12f.google.com (unknown [2a00:1450:4864:20::12f])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id b9308316-49c6-416a-9af9-45f1a05d2721;
 Fri, 08 Oct 2021 05:55:44 +0000 (UTC)
Received: by mail-lf1-x12f.google.com with SMTP id t9so33577352lfd.1
 for <xen-devel@lists.xenproject.org>; Thu, 07 Oct 2021 22:55:43 -0700 (PDT)
Received: from localhost.localdomain (host-176-36-245-220.b024.la.net.ua.
 [176.36.245.220])
 by smtp.gmail.com with ESMTPSA id f8sm151147lfq.168.2021.10.07.22.55.41
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Thu, 07 Oct 2021 22:55:42 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b9308316-49c6-416a-9af9-45f1a05d2721
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=kBaCDB1jQf5kZrJ+C9TzIUopo/UW+RufCsCBCZcFZhQ=;
        b=AdHvna/o6jg3eodxk+IR/WwNFV5s5aQlphltA0H3ObfsdkpSqDi/xT+d6K2H5owUYO
         Vyg7zHOfG+cmfBXt9AMqqLWUuGNBcl62D1oXFsli1B9xmkOweMH4SS5wNXsY1VINoDer
         IbtJwYG45/Gdih9ianuT1GZuuBI9n1kJPZvMFTg4ZDam12jk9AFgO7SeduxOms33jr+M
         J4boOrt+EK1Ug5oScVE/+VLbgidaq7PcnOoiC/q/j/4ZdzKWHQt7wjof57Vlm766/Vv5
         JNv771Bo+9kCND0z5UCRap0WykZeQZ4rZVeGb1AhdomIG5FXwhKFOzTERXoOtsx6Yjq1
         XHMA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=kBaCDB1jQf5kZrJ+C9TzIUopo/UW+RufCsCBCZcFZhQ=;
        b=6SOz4HKY7qtLwmz6/tNHYt9TNjaAQutxJ/5q5Qh1HnLQGG9Rk6frb/iJJY8lAO/Jp3
         TB6rQlypR6qvWKdmU5uOYwcd5r6UBSccNpB4NMCq3iPY+fFhuyFLag5Xj1tSLbQ2vC/q
         2Lo3AABF4ZoEYbg+Nl9fnTQ3WFtJYLnKbPSQjI5nJ7wUkVu57Rrqhq/HH4ZU7JZ3uHn2
         UV7KkYKRsuntJ907pHokG0klmEETBlR14uc6NmEBwEsSdNJgWkLbLFt0SQNFYK14ARww
         Oq5nTX8QUF+aZW+Y2nhDy+Z1F2eoEp2lrrW7l3FYLw7elyA3WGfnPxqNLwspryWRtKHY
         FGyg==
X-Gm-Message-State: AOAM533ztV8vICMYYgu6Mhdo/gPHr6Rq7vAuVM/BzEORI57azROvUZVp
	KEgYR9eoz0iVhinuGHaldTIhUUc3Mnc=
X-Google-Smtp-Source: ABdhPJxh8orDP66nDG63AjGag7W745tT+yg4DFTW8P7aAuYsgvYGCDXxaCJQV2aL2G7HiK0kq3rzLg==
X-Received: by 2002:a05:6512:2393:: with SMTP id c19mr8840366lfv.518.1633672542822;
        Thu, 07 Oct 2021 22:55:42 -0700 (PDT)
From: Oleksandr Andrushchenko <andr2000@gmail.com>
To: xen-devel@lists.xenproject.org
Cc: julien@xen.org,
	sstabellini@kernel.org,
	oleksandr_tyshchenko@epam.com,
	volodymyr_babchuk@epam.com,
	Artem_Mygaiev@epam.com,
	roger.pau@citrix.com,
	jbeulich@suse.com,
	andrew.cooper3@citrix.com,
	george.dunlap@citrix.com,
	paul@xen.org,
	bertrand.marquis@arm.com,
	rahul.singh@arm.com,
	Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Subject: [PATCH v5 04/10] xen/arm: Mark device as PCI while creating one
Date: Fri,  8 Oct 2021 08:55:29 +0300
Message-Id: <20211008055535.337436-5-andr2000@gmail.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20211008055535.337436-1-andr2000@gmail.com>
References: <20211008055535.337436-1-andr2000@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>

While adding a PCI device mark it as such, so other frameworks
can distinguish it from DT devices.
For that introduce an architecture defined helper which may perform
additional initialization of the newly created PCI device.

Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
[applicable parts]
Acked-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Rahul Singh <rahul.singh@arm.com>
Tested-by: Rahul Singh <rahul.singh@arm.com>
---
Cc: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Paul Durrant <paul@xen.org>

Since v3:
- fixed Arm build without CONFIG_HAS_PCI
Since v2:
 - !! dropped Stefano's r-b because of the changes
 - introduced arch_pci_init_pdev (Jan)
Since v1:
 - moved the assignment from iommu_add_device to alloc_pdev
---
 xen/arch/arm/pci/pci.c        | 5 +++++
 xen/drivers/passthrough/pci.c | 2 ++
 xen/include/asm-arm/pci.h     | 7 +++++++
 xen/include/asm-x86/pci.h     | 2 ++
 4 files changed, 16 insertions(+)

diff --git a/xen/arch/arm/pci/pci.c b/xen/arch/arm/pci/pci.c
index 138da19284ab..082c14e127a8 100644
--- a/xen/arch/arm/pci/pci.c
+++ b/xen/arch/arm/pci/pci.c
@@ -34,6 +34,11 @@ struct pci_dev *dev_to_pci(struct device *dev)
     return container_of(dev, struct pci_dev, arch.dev);
 }
 
+void arch_pci_init_pdev(struct pci_dev *pdev)
+{
+    pci_to_dev(pdev)->type = DEV_PCI;
+}
+
 static int __init dt_pci_init(void)
 {
     struct dt_device_node *np;
diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci.c
index b36d5a481162..9e6246afeef5 100644
--- a/xen/drivers/passthrough/pci.c
+++ b/xen/drivers/passthrough/pci.c
@@ -329,6 +329,8 @@ static struct pci_dev *alloc_pdev(struct pci_seg *pseg, u8 bus, u8 devfn)
     *((u8*) &pdev->devfn) = devfn;
     pdev->domain = NULL;
 
+    arch_pci_init_pdev(pdev);
+
     rc = pdev_msi_init(pdev);
     if ( rc )
     {
diff --git a/xen/include/asm-arm/pci.h b/xen/include/asm-arm/pci.h
index 9aa8eca53175..98cb22d39ef1 100644
--- a/xen/include/asm-arm/pci.h
+++ b/xen/include/asm-arm/pci.h
@@ -105,6 +105,9 @@ static always_inline bool is_pci_passthrough_enabled(void)
 {
     return pci_passthrough_enabled;
 }
+
+void arch_pci_init_pdev(struct pci_dev *pdev);
+
 #else   /*!CONFIG_HAS_PCI*/
 
 struct arch_pci_dev { };
@@ -121,5 +124,9 @@ static inline int pci_get_host_bridge_segment(const struct dt_device_node *node,
     return -EINVAL;
 }
 
+struct pci_dev;
+
+static inline void arch_pci_init_pdev(struct pci_dev *pdev) {}
+
 #endif  /*!CONFIG_HAS_PCI*/
 #endif /* __ARM_PCI_H__ */
diff --git a/xen/include/asm-x86/pci.h b/xen/include/asm-x86/pci.h
index c4a4fdcbc239..443f25347d08 100644
--- a/xen/include/asm-x86/pci.h
+++ b/xen/include/asm-x86/pci.h
@@ -36,4 +36,6 @@ static always_inline bool is_pci_passthrough_enabled(void)
     return true;
 }
 
+static inline void arch_pci_init_pdev(struct pci_dev *pdev) {}
+
 #endif /* __X86_PCI_H__ */
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Fri Oct 08 05:56:07 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Oct 2021 05:56:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.204337.359515 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYirX-0001Gi-LP; Fri, 08 Oct 2021 05:56:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 204337.359515; Fri, 08 Oct 2021 05:56:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYirX-0001GV-Fp; Fri, 08 Oct 2021 05:56:07 +0000
Received: by outflank-mailman (input) for mailman id 204337;
 Fri, 08 Oct 2021 05:56:05 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ipo1=O4=gmail.com=andr2000@srs-us1.protection.inumbo.net>)
 id 1mYirV-0007cA-KS
 for xen-devel@lists.xenproject.org; Fri, 08 Oct 2021 05:56:05 +0000
Received: from mail-lf1-x130.google.com (unknown [2a00:1450:4864:20::130])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id c27177f6-bd7e-4306-9d47-72ef149989c9;
 Fri, 08 Oct 2021 05:55:45 +0000 (UTC)
Received: by mail-lf1-x130.google.com with SMTP id b20so35071654lfv.3
 for <xen-devel@lists.xenproject.org>; Thu, 07 Oct 2021 22:55:45 -0700 (PDT)
Received: from localhost.localdomain (host-176-36-245-220.b024.la.net.ua.
 [176.36.245.220])
 by smtp.gmail.com with ESMTPSA id f8sm151147lfq.168.2021.10.07.22.55.42
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Thu, 07 Oct 2021 22:55:43 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c27177f6-bd7e-4306-9d47-72ef149989c9
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=ZCJvktk62euiFf93z8Os38uZoCLuGeAveKltg5+4Wtc=;
        b=egTWtj0yY2eScJ0OlKXABb4G+bmYSWosMoQG8sskJ0bDLAxynVAbBUO8ze901KLgN0
         4gqvEwhbUTVm208gisrRZccw+DN3KtwxHFLyd8flxas7Ycqm/3zEiyS8Dx9szsY1EcGi
         ZWHuONWzcP7cVazxts2zgCR9c7Q1iNo66m4ToAgHhR2czvdLDM10zJhvEN27t/GNccFB
         2DlhzvXQQ7SW8x4QxwVeSKdnvDGhOG4QWoiXidYssrdLd3vP5rzZFZvDKeCckMDcvjrN
         dSziPh6BixoMhXDrhzHEUAKwoIPF+4fIEt77zMy+CwhChFtedX4g3nMk7dRAfpC/ij5w
         DWkw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=ZCJvktk62euiFf93z8Os38uZoCLuGeAveKltg5+4Wtc=;
        b=2FXGFiXo91/qts9DiPO7VRuwE8PH/7EsoGP7xdCJTlV+Y2CwZrmt7GI8FOw1jQsWzX
         +hti109Weu5TDnTsGPaR2eqgHPl4lJda/SGRHTb+FTabDh68WldbxDWBB0JWC5EN5E+u
         bo/mmYToWWAXOditBmzlLG/Dm+7jnuPvB6vqdaoPU9jA/P7igYttLZHNgB95KTCrp1/O
         iI0vvFyxClCaITjJfOuZwYx9sBbA9SJEnf0ZpxQhq8d1k2l8l98RZMarGtMR/JBNMGqq
         q4a10wLJdVTbUN4yvq/XR7KRkdywgyuYkLweIrfMw1Iz5TTOTeXTeCinhznK+fPt3WVS
         C/Ag==
X-Gm-Message-State: AOAM53221HWOBaM5sQzSvERpE9qcN6f9Lsz3gdl5Mj9WF+hk407zJzjb
	geRqmg3JYpmsxq9RC2WxUtTMsp4tgwA=
X-Google-Smtp-Source: ABdhPJw3iseSMLF5rjaGBAlP//RiQcLo4485Bz93gG+h/Km/Hsavi6PicqSrSmsmdebz/ACX9Ate4g==
X-Received: by 2002:a05:6512:3b94:: with SMTP id g20mr8678129lfv.119.1633672543928;
        Thu, 07 Oct 2021 22:55:43 -0700 (PDT)
From: Oleksandr Andrushchenko <andr2000@gmail.com>
To: xen-devel@lists.xenproject.org
Cc: julien@xen.org,
	sstabellini@kernel.org,
	oleksandr_tyshchenko@epam.com,
	volodymyr_babchuk@epam.com,
	Artem_Mygaiev@epam.com,
	roger.pau@citrix.com,
	jbeulich@suse.com,
	andrew.cooper3@citrix.com,
	george.dunlap@citrix.com,
	paul@xen.org,
	bertrand.marquis@arm.com,
	rahul.singh@arm.com,
	Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Subject: [PATCH v5 05/10] xen/domain: Call pci_release_devices() when releasing domain resources
Date: Fri,  8 Oct 2021 08:55:30 +0300
Message-Id: <20211008055535.337436-6-andr2000@gmail.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20211008055535.337436-1-andr2000@gmail.com>
References: <20211008055535.337436-1-andr2000@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>

This is the very same that we already do for DT devices. Moreover, x86
already calls pci_release_devices().

Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
Reviewed-by: Rahul Singh <rahul.singh@arm.com>
Tested-by: Rahul Singh <rahul.singh@arm.com>
---
Since v1:
 - re-wording in the commit message
---
 xen/arch/arm/domain.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
index fbb52f78f1a6..79012bf77757 100644
--- a/xen/arch/arm/domain.c
+++ b/xen/arch/arm/domain.c
@@ -985,7 +985,8 @@ static int relinquish_memory(struct domain *d, struct page_list_head *list)
  * function which may return -ERESTART.
  */
 enum {
-    PROG_tee = 1,
+    PROG_pci = 1,
+    PROG_tee,
     PROG_xen,
     PROG_page,
     PROG_mapping,
@@ -1022,6 +1023,12 @@ int domain_relinquish_resources(struct domain *d)
 #ifdef CONFIG_IOREQ_SERVER
         ioreq_server_destroy_all(d);
 #endif
+#ifdef CONFIG_HAS_PCI
+    PROGRESS(pci):
+        ret = pci_release_devices(d);
+        if ( ret )
+            return ret;
+#endif
 
     PROGRESS(tee):
         ret = tee_relinquish_resources(d);
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Fri Oct 08 05:56:12 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Oct 2021 05:56:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.204341.359526 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYirc-0001pC-5a; Fri, 08 Oct 2021 05:56:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 204341.359526; Fri, 08 Oct 2021 05:56:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYirc-0001ok-11; Fri, 08 Oct 2021 05:56:12 +0000
Received: by outflank-mailman (input) for mailman id 204341;
 Fri, 08 Oct 2021 05:56:10 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ipo1=O4=gmail.com=andr2000@srs-us1.protection.inumbo.net>)
 id 1mYira-0007cA-Kd
 for xen-devel@lists.xenproject.org; Fri, 08 Oct 2021 05:56:10 +0000
Received: from mail-lf1-x12e.google.com (unknown [2a00:1450:4864:20::12e])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 1aee4013-3614-4fc5-b8e1-57dc7b49f9fe;
 Fri, 08 Oct 2021 05:55:46 +0000 (UTC)
Received: by mail-lf1-x12e.google.com with SMTP id x27so34677426lfu.5
 for <xen-devel@lists.xenproject.org>; Thu, 07 Oct 2021 22:55:46 -0700 (PDT)
Received: from localhost.localdomain (host-176-36-245-220.b024.la.net.ua.
 [176.36.245.220])
 by smtp.gmail.com with ESMTPSA id f8sm151147lfq.168.2021.10.07.22.55.44
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Thu, 07 Oct 2021 22:55:44 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1aee4013-3614-4fc5-b8e1-57dc7b49f9fe
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=Gze8iYmqiF2cMvijBG4Ld8cLztnOhc60UjeRzFilfH0=;
        b=S5cKZo3IYyM/uvuPtHNfJ0qEZUbg4C2bKsgzSnRxa5gX2KNUsUPpivR/rpdGo5P022
         LSH383eq4HAUrIrekVaRgj7JZ0jT3drDXxPyVVWrF08ePLpdS4TnUQlq1/3vFO9DUFjq
         CFhDu7XaIAsGmjjL93CtYXUaop8JJ3qR/ns6hdlYgmvJlBG8Qe9Ul6ZodP8uKhMVDhvG
         d9UcWLsRhuvSkMNwcPLXbLvIv/ndFgTHGkzV7QMGENGQ3Ix03r+JKLFQx38dEaFTGD57
         /Bdon7kFwOJT5/lZrdk21Bg+R+y8p4PFOzbfm2aI3In0PhHdbDqIPKd97X3MnZRzVBO+
         t6LQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=Gze8iYmqiF2cMvijBG4Ld8cLztnOhc60UjeRzFilfH0=;
        b=Ty0G4ML6IOTCw8QBqIxsvzC98/9sqHX0Sf2evOJF3N5d/kLheQMMYAx+Zf2t3zjv8j
         eRslQytOUa2hf96xtU722UGfsDHHU68CuMku7qeUyTB5Ux2MCjW4LiADG25DsnTzOrjw
         yFmHRXDaJTGFBUBtJJ8knrpFSySNwPFlPJ/ccvOvy4tKr0PSq4FALlzpfPuGaaAxd4S1
         NnuJvaVc1VvuWFCLS4wcw48T/VbxAWF4hxMWabCkPerjWTiYTyeP1gYx43LD2t9o38ZW
         u2BcVLnUC8OzmZ5Ty8aw4epKwgPKUI/aB0rUe+GBEAiKtokUw7OEfM2UuazgJvZmN+gI
         6cVg==
X-Gm-Message-State: AOAM530p00wNumqjPPmcRQF3kubYVfKGQXsOnMWg/cZKWt446RzntbJi
	maeAxNrd4MswFCRjcq4eyGW9YDlOQDA=
X-Google-Smtp-Source: ABdhPJwmcEvN71rOOpBhumTj6iAvUbtG04zcFvN4XV0h/MXlqBNJpABcP9VxDYwCcBTXd7RmlCpWlQ==
X-Received: by 2002:a05:6512:398c:: with SMTP id j12mr8483974lfu.631.1633672545224;
        Thu, 07 Oct 2021 22:55:45 -0700 (PDT)
From: Oleksandr Andrushchenko <andr2000@gmail.com>
To: xen-devel@lists.xenproject.org
Cc: julien@xen.org,
	sstabellini@kernel.org,
	oleksandr_tyshchenko@epam.com,
	volodymyr_babchuk@epam.com,
	Artem_Mygaiev@epam.com,
	roger.pau@citrix.com,
	jbeulich@suse.com,
	andrew.cooper3@citrix.com,
	george.dunlap@citrix.com,
	paul@xen.org,
	bertrand.marquis@arm.com,
	rahul.singh@arm.com,
	Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>,
	Ian Jackson <iwj@xenproject.org>,
	Juergen Gross <jgross@suse.com>
Subject: [PATCH v5 06/10] libxl: Allow removing PCI devices for all types of domains
Date: Fri,  8 Oct 2021 08:55:31 +0300
Message-Id: <20211008055535.337436-7-andr2000@gmail.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20211008055535.337436-1-andr2000@gmail.com>
References: <20211008055535.337436-1-andr2000@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>

The PCI device remove path may now be used by PVH on ARM, so the
assert is no longer valid.

Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Acked-by: Stefano Stabellini <sstabellini@kernel.org>
Reviewed-by: Rahul Singh <rahul.singh@arm.com>
Tested-by: Rahul Singh <rahul.singh@arm.com>
---
Cc: Ian Jackson <iwj@xenproject.org>
Cc: Juergen Gross <jgross@suse.com>
---
 tools/libs/light/libxl_pci.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/tools/libs/light/libxl_pci.c b/tools/libs/light/libxl_pci.c
index 1a1c2630803b..59f3686fc85e 100644
--- a/tools/libs/light/libxl_pci.c
+++ b/tools/libs/light/libxl_pci.c
@@ -1947,8 +1947,6 @@ static void do_pci_remove(libxl__egc *egc, pci_remove_state *prs)
             goto out_fail;
         }
     } else {
-        assert(type == LIBXL_DOMAIN_TYPE_PV);
-
         char *sysfs_path = GCSPRINTF(SYSFS_PCI_DEV"/"PCI_BDF"/resource", pci->domain,
                                      pci->bus, pci->dev, pci->func);
         FILE *f = fopen(sysfs_path, "r");
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Fri Oct 08 05:56:17 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Oct 2021 05:56:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.204345.359537 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYirh-0002PS-Df; Fri, 08 Oct 2021 05:56:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 204345.359537; Fri, 08 Oct 2021 05:56:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYirh-0002PD-9A; Fri, 08 Oct 2021 05:56:17 +0000
Received: by outflank-mailman (input) for mailman id 204345;
 Fri, 08 Oct 2021 05:56:15 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ipo1=O4=gmail.com=andr2000@srs-us1.protection.inumbo.net>)
 id 1mYirf-0007cA-Kt
 for xen-devel@lists.xenproject.org; Fri, 08 Oct 2021 05:56:15 +0000
Received: from mail-lf1-x12e.google.com (unknown [2a00:1450:4864:20::12e])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 7695a0a1-c5b1-4e65-894c-89d7bfc211df;
 Fri, 08 Oct 2021 05:55:47 +0000 (UTC)
Received: by mail-lf1-x12e.google.com with SMTP id y15so34649433lfk.7
 for <xen-devel@lists.xenproject.org>; Thu, 07 Oct 2021 22:55:47 -0700 (PDT)
Received: from localhost.localdomain (host-176-36-245-220.b024.la.net.ua.
 [176.36.245.220])
 by smtp.gmail.com with ESMTPSA id f8sm151147lfq.168.2021.10.07.22.55.45
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Thu, 07 Oct 2021 22:55:46 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7695a0a1-c5b1-4e65-894c-89d7bfc211df
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=goBcPmRp2ohWna+/gXXwyGZm/zW9wdOzUquFDTCwT10=;
        b=cX19K/TYDn8vW4HwKU48r0qTiY6u4hpHnfe75SOv2g6lg/739OtMcTs1VfZi56IOFb
         3Sb2UyHnVpDICH/QwOqqye9oXXlZI8ZHwPpd7qi1QaS5PgGhgCZ7nVokYO5eQrU908se
         z2IgC4WDRpO9ynOqGMyb4llqr8LSzbgz83sb/QjiT+/yCrx8ZibjSSuMLHGcNTdo7Ap2
         NL3In+YVGcZjcJd2JXTVjB1ji5V9UdsoWNFxJlJQk10i86BwrJnExqD0gwgG+JZ+caI4
         LlA+aqvTcHVtPAEjICb/D/piDO/0Secv8r2Lxw2yNGhZCZQyeMVmUadsEVpVgY/jb1lp
         6lqg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=goBcPmRp2ohWna+/gXXwyGZm/zW9wdOzUquFDTCwT10=;
        b=NZZxQYoZLxsd7+tU8tlhRUfDYj1rABt6q+TnTDDxqoZcGW5auX8xqc3cyt83U+IQ/v
         /X1GMmjb31jlsype/oQTyT1Js6FzozxG+QxEABcs2iCtZ2iOxSuRu6Z5hR3dGiztLggk
         K9rWe1A8NWEMvMlK3kPE6WPly44fufKFodPk8KDHxunabE2ftxVYqulLDTiYPkFQeNlP
         VIVTPIepwWf+aCRHxpfehuUyU/JVF01N0mOOptx8EtAEnn+Ipni454qsRBmDAhFNFhps
         IzRzZ/iScAqqj06MvWGcJS2THralEvU+N/O9nLRLg4uR3iEGKA+UigK3ukBnF/S5flYR
         rXrg==
X-Gm-Message-State: AOAM533RrB7OzlzhiLoPlHtg5E4KEh2sFqwq429roAt7FOM+gqoO9Ou1
	AFlxL1Zb0wii9nwpIBYfrXtneyYXDgA=
X-Google-Smtp-Source: ABdhPJwlTn/wOzkXL/qlTPFqV3Ub7ABbU4xc8mOsh6FwPIjRr3AZzSK+WsDY1a4okJWcWyHdVrYwYQ==
X-Received: by 2002:a05:6512:31e:: with SMTP id t30mr8361782lfp.82.1633672546470;
        Thu, 07 Oct 2021 22:55:46 -0700 (PDT)
From: Oleksandr Andrushchenko <andr2000@gmail.com>
To: xen-devel@lists.xenproject.org
Cc: julien@xen.org,
	sstabellini@kernel.org,
	oleksandr_tyshchenko@epam.com,
	volodymyr_babchuk@epam.com,
	Artem_Mygaiev@epam.com,
	roger.pau@citrix.com,
	jbeulich@suse.com,
	andrew.cooper3@citrix.com,
	george.dunlap@citrix.com,
	paul@xen.org,
	bertrand.marquis@arm.com,
	rahul.singh@arm.com,
	Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>,
	Ian Jackson <iwj@xenproject.org>,
	Juergen Gross <jgross@suse.com>
Subject: [PATCH v5 07/10] libxl: Only map legacy PCI IRQs if they are supported
Date: Fri,  8 Oct 2021 08:55:32 +0300
Message-Id: <20211008055535.337436-8-andr2000@gmail.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20211008055535.337436-1-andr2000@gmail.com>
References: <20211008055535.337436-1-andr2000@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>

Arm's PCI passthrough implementation doesn't support legacy interrupts,
but MSI/MSI-X. This can be the case for other platforms too.
For that reason introduce a new CONFIG_PCI_SUPP_LEGACY_IRQ and add
it to the CFLAGS and compile the relevant code in the toolstack only if
applicable.

Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
Reviewed-by: Rahul Singh <rahul.singh@arm.com>
Tested-by: Rahul Singh <rahul.singh@arm.com>
---
Cc: Ian Jackson <iwj@xenproject.org>
Cc: Juergen Gross <jgross@suse.com>

Since v1:
 - Minimized #idefery by introducing pci_supp_legacy_irq function
   for relevant checks
---
 tools/libs/light/Makefile    |  4 ++++
 tools/libs/light/libxl_pci.c | 13 +++++++++++++
 2 files changed, 17 insertions(+)

diff --git a/tools/libs/light/Makefile b/tools/libs/light/Makefile
index 7d8c51d49242..bd3f6be2a183 100644
--- a/tools/libs/light/Makefile
+++ b/tools/libs/light/Makefile
@@ -46,6 +46,10 @@ CFLAGS += -Wno-format-zero-length -Wmissing-declarations \
 	-Wno-declaration-after-statement -Wformat-nonliteral
 CFLAGS += -I.
 
+ifeq ($(CONFIG_X86),y)
+CFLAGS += -DCONFIG_PCI_SUPP_LEGACY_IRQ
+endif
+
 SRCS-$(CONFIG_X86) += libxl_cpuid.c
 SRCS-$(CONFIG_X86) += libxl_x86.c
 SRCS-$(CONFIG_X86) += libxl_psr.c
diff --git a/tools/libs/light/libxl_pci.c b/tools/libs/light/libxl_pci.c
index 59f3686fc85e..4c2d7aeefbb2 100644
--- a/tools/libs/light/libxl_pci.c
+++ b/tools/libs/light/libxl_pci.c
@@ -1364,6 +1364,15 @@ static void pci_add_timeout(libxl__egc *egc, libxl__ev_time *ev,
     pci_add_dm_done(egc, pas, rc);
 }
 
+static bool pci_supp_legacy_irq(void)
+{
+#ifdef CONFIG_PCI_SUPP_LEGACY_IRQ
+    return true;
+#else
+    return false;
+#endif
+}
+
 static void pci_add_dm_done(libxl__egc *egc,
                             pci_add_state *pas,
                             int rc)
@@ -1434,6 +1443,8 @@ static void pci_add_dm_done(libxl__egc *egc,
         }
     }
     fclose(f);
+    if (!pci_supp_legacy_irq())
+        goto out_no_irq;
     sysfs_path = GCSPRINTF(SYSFS_PCI_DEV"/"PCI_BDF"/irq", pci->domain,
                                 pci->bus, pci->dev, pci->func);
     f = fopen(sysfs_path, "r");
@@ -1983,6 +1994,8 @@ static void do_pci_remove(libxl__egc *egc, pci_remove_state *prs)
         }
         fclose(f);
 skip1:
+        if (!pci_supp_legacy_irq())
+            goto skip_irq;
         sysfs_path = GCSPRINTF(SYSFS_PCI_DEV"/"PCI_BDF"/irq", pci->domain,
                                pci->bus, pci->dev, pci->func);
         f = fopen(sysfs_path, "r");
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Fri Oct 08 05:56:22 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Oct 2021 05:56:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.204348.359548 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYirm-00031R-Me; Fri, 08 Oct 2021 05:56:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 204348.359548; Fri, 08 Oct 2021 05:56:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYirm-00031D-Ja; Fri, 08 Oct 2021 05:56:22 +0000
Received: by outflank-mailman (input) for mailman id 204348;
 Fri, 08 Oct 2021 05:56:20 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ipo1=O4=gmail.com=andr2000@srs-us1.protection.inumbo.net>)
 id 1mYirk-0007cA-L0
 for xen-devel@lists.xenproject.org; Fri, 08 Oct 2021 05:56:20 +0000
Received: from mail-lf1-x129.google.com (unknown [2a00:1450:4864:20::129])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id f5954495-a0ca-4fe0-b2cd-34b6d81c89a3;
 Fri, 08 Oct 2021 05:55:48 +0000 (UTC)
Received: by mail-lf1-x129.google.com with SMTP id m3so34761580lfu.2
 for <xen-devel@lists.xenproject.org>; Thu, 07 Oct 2021 22:55:48 -0700 (PDT)
Received: from localhost.localdomain (host-176-36-245-220.b024.la.net.ua.
 [176.36.245.220])
 by smtp.gmail.com with ESMTPSA id f8sm151147lfq.168.2021.10.07.22.55.46
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Thu, 07 Oct 2021 22:55:47 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f5954495-a0ca-4fe0-b2cd-34b6d81c89a3
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=vUC5D9zEKV/jAgD73pTREAGOQdOnzNJSZwkzfwspuNk=;
        b=btx7oai46Hsj7sP/cha3qJ3x9r8kcGUjfyCmfdEk44+qTEZcYDyycvw5eL6MD8MAh0
         St6VY3ebKsjwyliy4IxBKxtEIq5d1jHrf8CtR67T+DClevPS93sGP0qOyUygQy7voKb2
         xVTFNr4oKHDQz/RX0AbTPPiUgWUvMDmWuEHApGcpEvVK0ZxOVF/10e/bNxg8O85DbC1P
         ww0VF2qCkncREg1UR9IyQOjDjGcYA8oiLA6wot4kgDQJyx8/1nX8QRyGGO4I0M5bSLNI
         Akpu47x7THgh9GCLEpZOPMHhoj8TeMYEOknD3CCVfOsabt55irOSWYSkUbVxTJn1t+S9
         GjLw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=vUC5D9zEKV/jAgD73pTREAGOQdOnzNJSZwkzfwspuNk=;
        b=dI4ZFDkIJs08PBdw9H3OgKKAk301yZGYrutVD7xjC3ZrXnuamdw1HlRku1bKhswSWr
         MKhfLNf/6yNclqldN5cmd8wwetl/jHhuEMNgliwlxj+Eo49FK3M9A66wagEYtDnWcz3q
         x5cVG15w2/VO8Wud4b3wrsdvub9O2QxsaJUcGXY/Lnp4IePY+aR6+NEMcWor+OVBsFQF
         LnB9IWt5GF/BoHD2TOoAvKchQ26Ej97jVse/FEzcRQ0jTqoHy4O3uEzcAeuAsSv+CUdt
         liaz9J7X7oJLZGegBVez0/HUAxq29evFT8uJS6Q0uLWJ+5URCZnFv5EtS6eAReSSGKaf
         DPFA==
X-Gm-Message-State: AOAM533k3F/bHLmpc5+TWb55Lv6sEN6LAUx/0YshgbSk4SR9MhwBRNsu
	BiqJJJ1RuluKMLB3/hQJJKmtY3djPbY=
X-Google-Smtp-Source: ABdhPJyuSbpU0STi1lKVUx508Xiu5O+z312hu9KPeQtMDgnailV2dI8p2Obn72TAS3BJAyZFr7SHXw==
X-Received: by 2002:a05:6512:2396:: with SMTP id c22mr8686787lfv.55.1633672547618;
        Thu, 07 Oct 2021 22:55:47 -0700 (PDT)
From: Oleksandr Andrushchenko <andr2000@gmail.com>
To: xen-devel@lists.xenproject.org
Cc: julien@xen.org,
	sstabellini@kernel.org,
	oleksandr_tyshchenko@epam.com,
	volodymyr_babchuk@epam.com,
	Artem_Mygaiev@epam.com,
	roger.pau@citrix.com,
	jbeulich@suse.com,
	andrew.cooper3@citrix.com,
	george.dunlap@citrix.com,
	paul@xen.org,
	bertrand.marquis@arm.com,
	rahul.singh@arm.com,
	Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Subject: [PATCH v5 08/10] xen/arm: Setup MMIO range trap handlers for hardware domain
Date: Fri,  8 Oct 2021 08:55:33 +0300
Message-Id: <20211008055535.337436-9-andr2000@gmail.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20211008055535.337436-1-andr2000@gmail.com>
References: <20211008055535.337436-1-andr2000@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>

In order for vPCI to work it needs to maintain guest and hardware
domain's views of the configuration space. For example, BARs and
COMMAND registers require emulation for guests and the guest view
of the registers needs to be in sync with the real contents of the
relevant registers. For that ECAM address space needs to also be
trapped for the hardware domain, so we need to implement PCI host
bridge specific callbacks to properly setup MMIO handlers for those
ranges depending on particular host bridge implementation.

Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
Reviewed-by: Rahul Singh <rahul.singh@arm.com>
Tested-by: Rahul Singh <rahul.singh@arm.com>
---
Since v3:
- fixed comment formatting
Since v2:
- removed unneeded assignment (count = 0)
- removed unneeded header inclusion
- update commit message
Since v1:
 - Dynamically calculate the number of MMIO handlers required for vPCI
   and update the total number accordingly
 - s/clb/cb
 - Do not introduce a new callback for MMIO handler setup
---
 xen/arch/arm/domain.c              |  2 ++
 xen/arch/arm/pci/pci-host-common.c | 28 ++++++++++++++++++++++++
 xen/arch/arm/vpci.c                | 34 ++++++++++++++++++++++++++++++
 xen/arch/arm/vpci.h                |  6 ++++++
 xen/include/asm-arm/pci.h          |  5 +++++
 5 files changed, 75 insertions(+)

diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
index 79012bf77757..fa6fcc5e467c 100644
--- a/xen/arch/arm/domain.c
+++ b/xen/arch/arm/domain.c
@@ -733,6 +733,8 @@ int arch_domain_create(struct domain *d,
     if ( (rc = domain_vgic_register(d, &count)) != 0 )
         goto fail;
 
+    count += domain_vpci_get_num_mmio_handlers(d);
+
     if ( (rc = domain_io_init(d, count + MAX_IO_HANDLER)) != 0 )
         goto fail;
 
diff --git a/xen/arch/arm/pci/pci-host-common.c b/xen/arch/arm/pci/pci-host-common.c
index 592c01aae5bb..1eb4daa87365 100644
--- a/xen/arch/arm/pci/pci-host-common.c
+++ b/xen/arch/arm/pci/pci-host-common.c
@@ -292,6 +292,34 @@ struct dt_device_node *pci_find_host_bridge_node(struct device *dev)
     }
     return bridge->dt_node;
 }
+
+int pci_host_iterate_bridges(struct domain *d,
+                             int (*cb)(struct domain *d,
+                                       struct pci_host_bridge *bridge))
+{
+    struct pci_host_bridge *bridge;
+    int err;
+
+    list_for_each_entry( bridge, &pci_host_bridges, node )
+    {
+        err = cb(d, bridge);
+        if ( err )
+            return err;
+    }
+    return 0;
+}
+
+int pci_host_get_num_bridges(void)
+{
+    struct pci_host_bridge *bridge;
+    int count = 0;
+
+    list_for_each_entry( bridge, &pci_host_bridges, node )
+        count++;
+
+    return count;
+}
+
 /*
  * Local variables:
  * mode: C
diff --git a/xen/arch/arm/vpci.c b/xen/arch/arm/vpci.c
index 76c12b92814f..6e179cd3010b 100644
--- a/xen/arch/arm/vpci.c
+++ b/xen/arch/arm/vpci.c
@@ -80,17 +80,51 @@ static const struct mmio_handler_ops vpci_mmio_handler = {
     .write = vpci_mmio_write,
 };
 
+static int vpci_setup_mmio_handler(struct domain *d,
+                                   struct pci_host_bridge *bridge)
+{
+    struct pci_config_window *cfg = bridge->cfg;
+
+    register_mmio_handler(d, &vpci_mmio_handler,
+                          cfg->phys_addr, cfg->size, NULL);
+    return 0;
+}
+
 int domain_vpci_init(struct domain *d)
 {
     if ( !has_vpci(d) )
         return 0;
 
+    if ( is_hardware_domain(d) )
+        return pci_host_iterate_bridges(d, vpci_setup_mmio_handler);
+
+    /* Guest domains use what is programmed in their device tree. */
     register_mmio_handler(d, &vpci_mmio_handler,
                           GUEST_VPCI_ECAM_BASE, GUEST_VPCI_ECAM_SIZE, NULL);
 
     return 0;
 }
 
+int domain_vpci_get_num_mmio_handlers(struct domain *d)
+{
+    int count;
+
+    if ( is_hardware_domain(d) )
+        /* For each PCI host bridge's configuration space. */
+        count = pci_host_get_num_bridges();
+    else
+        /*
+         * VPCI_MSIX_MEM_NUM handlers for MSI-X tables per each PCI device
+         * being passed through. Maximum number of supported devices
+         * is 32 as virtual bus topology emulates the devices as embedded
+         * endpoints.
+         * +1 for a single emulated host bridge's configuration space.
+         */
+        count = VPCI_MSIX_MEM_NUM * 32 + 1;
+
+    return count;
+}
+
 /*
  * Local variables:
  * mode: C
diff --git a/xen/arch/arm/vpci.h b/xen/arch/arm/vpci.h
index d8a7b0e3e802..27a2b069abd2 100644
--- a/xen/arch/arm/vpci.h
+++ b/xen/arch/arm/vpci.h
@@ -17,11 +17,17 @@
 
 #ifdef CONFIG_HAS_VPCI
 int domain_vpci_init(struct domain *d);
+int domain_vpci_get_num_mmio_handlers(struct domain *d);
 #else
 static inline int domain_vpci_init(struct domain *d)
 {
     return 0;
 }
+
+static inline int domain_vpci_get_num_mmio_handlers(struct domain *d)
+{
+    return 0;
+}
 #endif
 
 #endif /* __ARCH_ARM_VPCI_H__ */
diff --git a/xen/include/asm-arm/pci.h b/xen/include/asm-arm/pci.h
index 98cb22d39ef1..a71b0eea8cb9 100644
--- a/xen/include/asm-arm/pci.h
+++ b/xen/include/asm-arm/pci.h
@@ -108,6 +108,11 @@ static always_inline bool is_pci_passthrough_enabled(void)
 
 void arch_pci_init_pdev(struct pci_dev *pdev);
 
+int pci_host_iterate_bridges(struct domain *d,
+                             int (*clb)(struct domain *d,
+                                        struct pci_host_bridge *bridge));
+int pci_host_get_num_bridges(void);
+
 #else   /*!CONFIG_HAS_PCI*/
 
 struct arch_pci_dev { };
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Fri Oct 08 05:56:27 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Oct 2021 05:56:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.204353.359559 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYirr-0003Vp-0r; Fri, 08 Oct 2021 05:56:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 204353.359559; Fri, 08 Oct 2021 05:56:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYirq-0003Vb-TU; Fri, 08 Oct 2021 05:56:26 +0000
Received: by outflank-mailman (input) for mailman id 204353;
 Fri, 08 Oct 2021 05:56:25 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ipo1=O4=gmail.com=andr2000@srs-us1.protection.inumbo.net>)
 id 1mYirp-0007cA-LA
 for xen-devel@lists.xenproject.org; Fri, 08 Oct 2021 05:56:25 +0000
Received: from mail-lf1-x130.google.com (unknown [2a00:1450:4864:20::130])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 3fb278fd-d89a-42b3-b97b-c7b4138f0516;
 Fri, 08 Oct 2021 05:55:50 +0000 (UTC)
Received: by mail-lf1-x130.google.com with SMTP id i24so33118840lfj.13
 for <xen-devel@lists.xenproject.org>; Thu, 07 Oct 2021 22:55:50 -0700 (PDT)
Received: from localhost.localdomain (host-176-36-245-220.b024.la.net.ua.
 [176.36.245.220])
 by smtp.gmail.com with ESMTPSA id f8sm151147lfq.168.2021.10.07.22.55.47
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Thu, 07 Oct 2021 22:55:48 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3fb278fd-d89a-42b3-b97b-c7b4138f0516
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=IBIe+xmJSKoC5wk/f52I/okgcUqP7yS1O1mJBjhKVo4=;
        b=M7AbQomva+/0jN7STkOUTyvIZLHd0drEcCIKbE1mwmCYgQUcKKPgQbaBPfmzBr6Yp2
         YktsOVRFi/4v2E8OerHhRzCeVzkys8aWH5k+sh9C6dt9PWBAtK2sz3fYE8R3tRpFGDL+
         sT8t/GW/v2/sSyw7fWTl6rO9JNja4wivMGxROpb5rVjO0RJHKyE+YLxkdAIt2KVM1cmd
         aJnXHecU2fWzRh7WbJU57jpsI1urk81Z0MULXXugVUVvOPbD0YGJZ2aAPig3I9LsHpz4
         gwuGXyqm960fkMQzzfO6MeWC9SeWavYTZ3hYLUSZJJSK2Y5JRy4RPuT5+nnxsYZlH+ba
         U0fA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=IBIe+xmJSKoC5wk/f52I/okgcUqP7yS1O1mJBjhKVo4=;
        b=Oii9W7sFT/1UsTw23IvePDHUVeqWbGjkZ9Mzeg1jsCy79JTI3i6Kc0654mpPcs2Vj/
         jh/uRDyQVBj3Ue72EvhgkvIt3qfYlQdwcEGs/dVq/yjANl/pwW7+erSmMhW/CQAZFiFo
         SM3hrokbAIVn9eWE3SwDqdzwn/KYF34zoqKyBfzaBgq6fJ0VXYhvorZy3QBf2JXg/feu
         sSpvA9Gn1MbNUQps4QxxwhLiGTOATTlVm8wfvbjuBgKFo2ze2an2yLy1fFtAp4Ots49C
         q1Oc/PPiS1KueHzBBPi9jL8v5MTeiAkVpWB0qDJ9Z9/EqzAQzlK5Vxczw+PKL119ZWfE
         I5dw==
X-Gm-Message-State: AOAM531l+WQRpXmANH0cJuY/LHjqdULMGcV2Eb0Ke5iHHmAfrgjJ3ATF
	IBTkRaUDG/hh6yvDANSe1cv3iK4TBLs=
X-Google-Smtp-Source: ABdhPJx1phls3JyqynXlWEBWaMOXDx/I3DFcPeZGPq8G5xcWbLKDFuGC629QB7VYjvZ3zW/2TJ5yEA==
X-Received: by 2002:a05:6512:39ca:: with SMTP id k10mr8335145lfu.571.1633672548758;
        Thu, 07 Oct 2021 22:55:48 -0700 (PDT)
From: Oleksandr Andrushchenko <andr2000@gmail.com>
To: xen-devel@lists.xenproject.org
Cc: julien@xen.org,
	sstabellini@kernel.org,
	oleksandr_tyshchenko@epam.com,
	volodymyr_babchuk@epam.com,
	Artem_Mygaiev@epam.com,
	roger.pau@citrix.com,
	jbeulich@suse.com,
	andrew.cooper3@citrix.com,
	george.dunlap@citrix.com,
	paul@xen.org,
	bertrand.marquis@arm.com,
	rahul.singh@arm.com,
	Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Subject: [PATCH v5 09/10] xen/arm: Do not map PCI ECAM and MMIO space to Domain-0's p2m
Date: Fri,  8 Oct 2021 08:55:34 +0300
Message-Id: <20211008055535.337436-10-andr2000@gmail.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20211008055535.337436-1-andr2000@gmail.com>
References: <20211008055535.337436-1-andr2000@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>

PCI host bridges are special devices in terms of implementing PCI
passthrough. According to [1] the current implementation depends on
Domain-0 to perform the initialization of the relevant PCI host
bridge hardware and perform PCI device enumeration. In order to
achieve that one of the required changes is to not map all the memory
ranges in map_range_to_domain as we traverse the device tree on startup
and perform some additional checks if the range needs to be mapped to
Domain-0.

The generic PCI host controller device tree binding says [2]:
- ranges: As described in IEEE Std 1275-1994, but must provide
          at least a definition of non-prefetchable memory. One
          or both of prefetchable Memory and IO Space may also
          be provided.

- reg   : The Configuration Space base address and size, as accessed
          from the parent bus.  The base address corresponds to
          the first bus in the "bus-range" property.  If no
          "bus-range" is specified, this will be bus 0 (the default).

>From the above none of the memory ranges from the "ranges" property
needs to be mapped to Domain-0 at startup as MMIO mapping is going to
be handled dynamically by vPCI as we assign PCI devices, e.g. each
device assigned to Domain-0/guest will have its MMIOs mapped/unmapped
as needed by Xen.

The "reg" property covers not only ECAM space, but may also have other
then the configuration memory ranges described, for example [3]:
- reg: Should contain rc_dbi, config registers location and length.
- reg-names: Must include the following entries:
   "rc_dbi": controller configuration registers;
   "config": PCIe configuration space registers.

This patch makes it possible to not map all the ranges from the
"ranges" property and also ECAM from the "reg". All the rest from the
"reg" property still needs to be mapped to Domain-0, so the PCI
host bridge remains functional in Domain-0.

[1] https://lists.xenproject.org/archives/html/xen-devel/2020-07/msg00777.html
[2] https://www.kernel.org/doc/Documentation/devicetree/bindings/pci/host-generic-pci.txt
[3] https://www.kernel.org/doc/Documentation/devicetree/bindings/pci/hisilicon-pcie.txt

Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
---
Since v4:
- update skip_mapping comment
- add comment why we need to map interrupts to Dom0
Since v3:
 - pass struct map_range_data to map_dt_irq_to_domain
 - remove redundant check from map_range_to_domain
 - fix handle_device's .skip_mapping
Since v2:
 - removed check in map_range_to_domain for PCI_DEV
   and moved it to handle_device, so the code is
   simpler
 - s/map_pci_bridge/skip_mapping
 - extended comment in pci_host_bridge_mappings
 - minor code restructure in construct_dom0
 - s/.need_p2m_mapping/.need_p2m_hwdom_mapping and related
   callbacks
 - unsigned int i; in pci_host_bridge_mappings
Since v1:
 - Added better description of why and what needs to be mapped into
   Domain-0's p2m and what doesn't
 - Do not do any mappings for PCI devices while traversing the DT
 - Walk all the bridges and make required mappings in one go
---
 xen/arch/arm/domain_build.c        | 57 ++++++++++++++++++------------
 xen/arch/arm/pci/ecam.c            | 14 ++++++++
 xen/arch/arm/pci/pci-host-common.c | 49 +++++++++++++++++++++++++
 xen/arch/arm/pci/pci-host-zynqmp.c |  1 +
 xen/include/asm-arm/pci.h          | 10 ++++++
 xen/include/asm-arm/setup.h        | 13 +++++++
 6 files changed, 121 insertions(+), 23 deletions(-)

diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
index b51176b31bef..0d673b06a2f3 100644
--- a/xen/arch/arm/domain_build.c
+++ b/xen/arch/arm/domain_build.c
@@ -10,7 +10,6 @@
 #include <asm/regs.h>
 #include <xen/errno.h>
 #include <xen/err.h>
-#include <xen/device_tree.h>
 #include <xen/libfdt/libfdt.h>
 #include <xen/guest_access.h>
 #include <xen/iocap.h>
@@ -51,12 +50,6 @@ static int __init parse_dom0_mem(const char *s)
 }
 custom_param("dom0_mem", parse_dom0_mem);
 
-struct map_range_data
-{
-    struct domain *d;
-    p2m_type_t p2mt;
-};
-
 /* Override macros from asm/page.h to make them work with mfn_t */
 #undef virt_to_mfn
 #define virt_to_mfn(va) _mfn(__virt_to_mfn(va))
@@ -1663,10 +1656,11 @@ static int __init map_dt_irq_to_domain(const struct dt_device_node *dev,
                                        const struct dt_irq *dt_irq,
                                        void *data)
 {
-    struct domain *d = data;
+    struct map_range_data *mr_data = data;
+    struct domain *d = mr_data->d;
     unsigned int irq = dt_irq->irq;
     int res;
-    bool need_mapping = !dt_device_for_passthrough(dev);
+    bool need_mapping = !mr_data->skip_mapping;
 
     if ( irq < NR_LOCAL_IRQS )
     {
@@ -1690,13 +1684,12 @@ static int __init map_dt_irq_to_domain(const struct dt_device_node *dev,
     return 0;
 }
 
-static int __init map_range_to_domain(const struct dt_device_node *dev,
-                                      u64 addr, u64 len,
-                                      void *data)
+int __init map_range_to_domain(const struct dt_device_node *dev,
+                               u64 addr, u64 len, void *data)
 {
     struct map_range_data *mr_data = data;
     struct domain *d = mr_data->d;
-    bool need_mapping = !dt_device_for_passthrough(dev);
+    bool need_mapping = !mr_data->skip_mapping;
     int res;
 
     /*
@@ -1748,23 +1741,21 @@ static int __init map_range_to_domain(const struct dt_device_node *dev,
  * then we may need to perform additional mappings in order to make
  * the child resources available to domain 0.
  */
-static int __init map_device_children(struct domain *d,
-                                      const struct dt_device_node *dev,
-                                      p2m_type_t p2mt)
+static int __init map_device_children(const struct dt_device_node *dev,
+                                      struct map_range_data *mr_data)
 {
-    struct map_range_data mr_data = { .d = d, .p2mt = p2mt };
-    int ret;
-
     if ( dt_device_type_is_equal(dev, "pci") )
     {
+        int ret;
+
         dt_dprintk("Mapping children of %s to guest\n",
                    dt_node_full_name(dev));
 
-        ret = dt_for_each_irq_map(dev, &map_dt_irq_to_domain, d);
+        ret = dt_for_each_irq_map(dev, &map_dt_irq_to_domain, mr_data);
         if ( ret < 0 )
             return ret;
 
-        ret = dt_for_each_range(dev, &map_range_to_domain, &mr_data);
+        ret = dt_for_each_range(dev, &map_range_to_domain, mr_data);
         if ( ret < 0 )
             return ret;
     }
@@ -1845,6 +1836,20 @@ static int __init handle_device(struct domain *d, struct dt_device_node *dev,
     int res;
     u64 addr, size;
     bool need_mapping = !dt_device_for_passthrough(dev);
+    /*
+     * For PCI passthrough we only need to remap to Dom0 the interrupts
+     * and memory ranges from "reg" property which cover controller's
+     * configuration registers and such. PCIe configuration space registers
+     * of the PCIe Root Complex and PCIe aperture should not be mapped
+     * automatically to Dom0.
+     */
+    struct map_range_data mr_data = {
+        .d = d,
+        .p2mt = p2mt,
+        .skip_mapping = !need_mapping ||
+                        (is_pci_passthrough_enabled() &&
+                         (device_get_class(dev) == DEVICE_PCI))
+    };
 
     naddr = dt_number_of_address(dev);
 
@@ -1884,7 +1889,6 @@ static int __init handle_device(struct domain *d, struct dt_device_node *dev,
     /* Give permission and map MMIOs */
     for ( i = 0; i < naddr; i++ )
     {
-        struct map_range_data mr_data = { .d = d, .p2mt = p2mt };
         res = dt_device_get_address(dev, i, &addr, &size);
         if ( res )
         {
@@ -1898,7 +1902,7 @@ static int __init handle_device(struct domain *d, struct dt_device_node *dev,
             return res;
     }
 
-    res = map_device_children(d, dev, p2mt);
+    res = map_device_children(dev, &mr_data);
     if ( res )
         return res;
 
@@ -3056,7 +3060,14 @@ static int __init construct_dom0(struct domain *d)
         return rc;
 
     if ( acpi_disabled )
+    {
         rc = prepare_dtb_hwdom(d, &kinfo);
+        if ( rc < 0 )
+            return rc;
+#ifdef CONFIG_HAS_PCI
+        rc = pci_host_bridge_mappings(d, p2m_mmio_direct_c);
+#endif
+    }
     else
         rc = prepare_acpi(d, &kinfo);
 
diff --git a/xen/arch/arm/pci/ecam.c b/xen/arch/arm/pci/ecam.c
index 602d00799c8d..b81620074a91 100644
--- a/xen/arch/arm/pci/ecam.c
+++ b/xen/arch/arm/pci/ecam.c
@@ -40,6 +40,19 @@ void __iomem *pci_ecam_map_bus(struct pci_host_bridge *bridge,
     return base + (PCI_DEVFN2(sbdf.bdf) << devfn_shift) + where;
 }
 
+bool pci_ecam_need_p2m_hwdom_mapping(struct domain *d,
+                                     struct pci_host_bridge *bridge,
+                                     uint64_t addr)
+{
+    struct pci_config_window *cfg = bridge->cfg;
+
+    /*
+     * We do not want ECAM address space to be mapped in Domain-0's p2m,
+     * so we can trap access to it.
+     */
+    return cfg->phys_addr != addr;
+}
+
 /* ECAM ops */
 const struct pci_ecam_ops pci_generic_ecam_ops = {
     .bus_shift  = 20,
@@ -47,6 +60,7 @@ const struct pci_ecam_ops pci_generic_ecam_ops = {
         .map_bus                = pci_ecam_map_bus,
         .read                   = pci_generic_config_read,
         .write                  = pci_generic_config_write,
+        .need_p2m_hwdom_mapping = pci_ecam_need_p2m_hwdom_mapping,
     }
 };
 
diff --git a/xen/arch/arm/pci/pci-host-common.c b/xen/arch/arm/pci/pci-host-common.c
index 1eb4daa87365..085f08e23e0c 100644
--- a/xen/arch/arm/pci/pci-host-common.c
+++ b/xen/arch/arm/pci/pci-host-common.c
@@ -18,6 +18,7 @@
 
 #include <xen/init.h>
 #include <xen/pci.h>
+#include <asm/setup.h>
 #include <xen/rwlock.h>
 #include <xen/sched.h>
 #include <xen/vmap.h>
@@ -320,6 +321,54 @@ int pci_host_get_num_bridges(void)
     return count;
 }
 
+int __init pci_host_bridge_mappings(struct domain *d, p2m_type_t p2mt)
+{
+    struct pci_host_bridge *bridge;
+    struct map_range_data mr_data = {
+        .d = d,
+        .p2mt = p2mt,
+        .skip_mapping = false
+    };
+
+    /*
+     * For each PCI host bridge we need to only map those ranges
+     * which are used by Domain-0 to properly initialize the bridge,
+     * e.g. we do not want to map ECAM configuration space which lives in
+     * "reg" or "assigned-addresses" device tree property, but we want to
+     * map other regions of the host bridge. The PCI aperture defined by
+     * the "ranges" device tree property should also be skipped.
+     */
+    list_for_each_entry( bridge, &pci_host_bridges, node )
+    {
+        const struct dt_device_node *dev = bridge->dt_node;
+        unsigned int i;
+
+        for ( i = 0; i < dt_number_of_address(dev); i++ )
+        {
+            uint64_t addr, size;
+            int err;
+
+            err = dt_device_get_address(dev, i, &addr, &size);
+            if ( err )
+            {
+                printk(XENLOG_ERR
+                       "Unable to retrieve address range index=%u for %s\n",
+                       i, dt_node_full_name(dev));
+                return err;
+            }
+
+            if ( bridge->ops->need_p2m_hwdom_mapping(d, bridge, addr) )
+            {
+                err = map_range_to_domain(dev, addr, size, &mr_data);
+                if ( err )
+                    return err;
+            }
+        }
+    }
+
+    return 0;
+}
+
 /*
  * Local variables:
  * mode: C
diff --git a/xen/arch/arm/pci/pci-host-zynqmp.c b/xen/arch/arm/pci/pci-host-zynqmp.c
index 61a9807d3d58..6ad2b31e810d 100644
--- a/xen/arch/arm/pci/pci-host-zynqmp.c
+++ b/xen/arch/arm/pci/pci-host-zynqmp.c
@@ -34,6 +34,7 @@ const struct pci_ecam_ops nwl_pcie_ops = {
         .map_bus                = pci_ecam_map_bus,
         .read                   = pci_generic_config_read,
         .write                  = pci_generic_config_write,
+        .need_p2m_hwdom_mapping = pci_ecam_need_p2m_hwdom_mapping,
     }
 };
 
diff --git a/xen/include/asm-arm/pci.h b/xen/include/asm-arm/pci.h
index a71b0eea8cb9..b5b85ccd0937 100644
--- a/xen/include/asm-arm/pci.h
+++ b/xen/include/asm-arm/pci.h
@@ -17,6 +17,8 @@
 
 #ifdef CONFIG_HAS_PCI
 
+#include <asm/p2m.h>
+
 #define pci_to_dev(pcidev) (&(pcidev)->arch.dev)
 
 extern bool pci_passthrough_enabled;
@@ -73,6 +75,9 @@ struct pci_ops {
                 uint32_t reg, uint32_t len, uint32_t *value);
     int (*write)(struct pci_host_bridge *bridge, pci_sbdf_t sbdf,
                  uint32_t reg, uint32_t len, uint32_t value);
+    bool (*need_p2m_hwdom_mapping)(struct domain *d,
+                                   struct pci_host_bridge *bridge,
+                                   uint64_t addr);
 };
 
 /*
@@ -96,6 +101,9 @@ int pci_generic_config_write(struct pci_host_bridge *bridge, pci_sbdf_t sbdf,
                              uint32_t reg, uint32_t len, uint32_t value);
 void __iomem *pci_ecam_map_bus(struct pci_host_bridge *bridge,
                                pci_sbdf_t sbdf, uint32_t where);
+bool pci_ecam_need_p2m_hwdom_mapping(struct domain *d,
+                                     struct pci_host_bridge *bridge,
+                                     uint64_t addr);
 struct pci_host_bridge *pci_find_host_bridge(uint16_t segment, uint8_t bus);
 int pci_get_host_bridge_segment(const struct dt_device_node *node,
                                 uint16_t *segment);
@@ -113,6 +121,8 @@ int pci_host_iterate_bridges(struct domain *d,
                                         struct pci_host_bridge *bridge));
 int pci_host_get_num_bridges(void);
 
+int pci_host_bridge_mappings(struct domain *d, p2m_type_t p2mt);
+
 #else   /*!CONFIG_HAS_PCI*/
 
 struct arch_pci_dev { };
diff --git a/xen/include/asm-arm/setup.h b/xen/include/asm-arm/setup.h
index 95da0b7ab9cd..88d9673db817 100644
--- a/xen/include/asm-arm/setup.h
+++ b/xen/include/asm-arm/setup.h
@@ -2,6 +2,8 @@
 #define __ARM_SETUP_H_
 
 #include <public/version.h>
+#include <asm/p2m.h>
+#include <xen/device_tree.h>
 
 #define MIN_FDT_ALIGN 8
 #define MAX_FDT_SIZE SZ_2M
@@ -77,6 +79,14 @@ struct bootinfo {
 #endif
 };
 
+struct map_range_data
+{
+    struct domain *d;
+    p2m_type_t p2mt;
+    /* Set if mapping of the memory ranges must be skipped. */
+    bool skip_mapping;
+};
+
 extern struct bootinfo bootinfo;
 
 extern domid_t max_init_domid;
@@ -124,6 +134,9 @@ void device_tree_get_reg(const __be32 **cell, u32 address_cells,
 u32 device_tree_get_u32(const void *fdt, int node,
                         const char *prop_name, u32 dflt);
 
+int map_range_to_domain(const struct dt_device_node *dev,
+                        u64 addr, u64 len, void *data);
+
 #endif
 /*
  * Local variables:
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Fri Oct 08 05:57:34 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Oct 2021 05:57:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.204382.359569 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYisv-0005A9-JS; Fri, 08 Oct 2021 05:57:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 204382.359569; Fri, 08 Oct 2021 05:57:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYisv-0005A2-GU; Fri, 08 Oct 2021 05:57:33 +0000
Received: by outflank-mailman (input) for mailman id 204382;
 Fri, 08 Oct 2021 05:57:32 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ipo1=O4=gmail.com=andr2000@srs-us1.protection.inumbo.net>)
 id 1mYirz-0007cA-LU
 for xen-devel@lists.xenproject.org; Fri, 08 Oct 2021 05:56:35 +0000
Received: from mail-lf1-x129.google.com (unknown [2a00:1450:4864:20::129])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id e1a5985e-d9d4-4899-ba40-1f09609fc514;
 Fri, 08 Oct 2021 05:55:51 +0000 (UTC)
Received: by mail-lf1-x129.google.com with SMTP id x27so34444531lfa.9
 for <xen-devel@lists.xenproject.org>; Thu, 07 Oct 2021 22:55:51 -0700 (PDT)
Received: from localhost.localdomain (host-176-36-245-220.b024.la.net.ua.
 [176.36.245.220])
 by smtp.gmail.com with ESMTPSA id f8sm151147lfq.168.2021.10.07.22.55.48
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Thu, 07 Oct 2021 22:55:49 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e1a5985e-d9d4-4899-ba40-1f09609fc514
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=QzbdatLhIl735gEkyVNBitnIXpDdRUzSTDD+uCEX6MU=;
        b=delfA489Q6cYlsvzBgsyUqfs6iLyZQojMZXOZNSwi//ru9d8tTsLGXpsmknxxB7Jsf
         ZUbfObRS5KNvOd0qpW50+0TYPDWbbXEkauxVwusgL44a1sXP3EZlokGC61Psf69fHkxI
         39zJKW1KlmMq4vHyErctSXOFuIlT7QNFKk+R5UEd9UvzB3L98tGOi6BcpGi2kORktaV7
         y0Mx8B7/9qD8/kkLtxr2O1PoKrhMHPt7xRghBTTQKocHOX/cNsQfaVD/mfz029w3OJLM
         ZjvEU0ieFo+XXapzq2iTxW9nOs1E3nddcNmGPs0TERFn/Ile/6ay43Rc+JAGrIo3jNG/
         XqSQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=QzbdatLhIl735gEkyVNBitnIXpDdRUzSTDD+uCEX6MU=;
        b=wFLPl5hpKafF3mI+jT7U61Lvn+2Wnt4tEnEZbJrHdn+XgBgZ5XSzd/N7o/4NuD6/4Z
         cMONh+NJJpsw1PPf8rhN/FjXJhMi4IETC8mYUPNvpGA0gILPNMDNFn1S5tAMBtYMroLh
         CLwqZ/Nurl8yD+3i52mJvo9fr5MD5hxBozrIano8cboZjsm1O4Oo6aU156IITclu7zJR
         rALpPPnZQLRI26VozeUB2S5XxFSppIxKY+BxY34z0AOM89pCeuFy2s6NUDx5DALehnyy
         MkXbKkFuCXgW0R2aVpTNvsBHluFXKRlhGDxTmU68WQ02VKP5yxlrvFe5g5v7YDlpPExf
         41+Q==
X-Gm-Message-State: AOAM530arnUNA4HC2NVQTEJwlPtFg7sLOOe8Hl54rDX0Tj8HbhtdWVTy
	WYkyOx30ITbwvCVKgyQUz9cOR9V5UYc=
X-Google-Smtp-Source: ABdhPJywjRTSBxfY5U+W2M3mS/L+w/EHBGcH55u4Oms0eFyTgaDV5BEqEg7Hc9R8uhCncZW9thfM2w==
X-Received: by 2002:ac2:5506:: with SMTP id j6mr8519664lfk.91.1633672549926;
        Thu, 07 Oct 2021 22:55:49 -0700 (PDT)
From: Oleksandr Andrushchenko <andr2000@gmail.com>
To: xen-devel@lists.xenproject.org
Cc: julien@xen.org,
	sstabellini@kernel.org,
	oleksandr_tyshchenko@epam.com,
	volodymyr_babchuk@epam.com,
	Artem_Mygaiev@epam.com,
	roger.pau@citrix.com,
	jbeulich@suse.com,
	andrew.cooper3@citrix.com,
	george.dunlap@citrix.com,
	paul@xen.org,
	bertrand.marquis@arm.com,
	rahul.singh@arm.com,
	Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Subject: [PATCH v5 10/10] xen/arm: Process pending vPCI map/unmap operations
Date: Fri,  8 Oct 2021 08:55:35 +0300
Message-Id: <20211008055535.337436-11-andr2000@gmail.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20211008055535.337436-1-andr2000@gmail.com>
References: <20211008055535.337436-1-andr2000@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>

vPCI may map and unmap PCI device memory (BARs) being passed through which
may take a lot of time. For this those operations may be deferred to be
performed later, so that they can be safely preempted.

Currently this deferred processing is happening in common IOREQ code
which doesn't seem to be the right place for x86 and is even more
doubtful because IOREQ may not be enabled for Arm at all.
So, for Arm the pending vPCI work may have no chance to be executed
if the processing is left as is in the common IOREQ code only.
For that reason make vPCI processing happen in arch specific code.

Please be aware that there are a few outstanding TODOs affecting this
code path, see xen/drivers/vpci/header.c:map_range and
xen/drivers/vpci/header.c:vpci_process_pending.

Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
[x86 changes]
Acked-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
Reviewed-by: Rahul Singh <rahul.singh@arm.com>
Tested-by: Rahul Singh <rahul.singh@arm.com>
---
Cc: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Paul Durrant <paul@xen.org>

Since v2:
 - update commit message with more insight on x86, IOREQ and Arm
 - restored order of invocation for IOREQ and vPCI processing (Jan)
Since v1:
 - Moved the check for pending vpci work from the common IOREQ code
   to hvm_do_resume on x86
 - Re-worked the code for Arm to ensure we don't miss pending vPCI work
---
 xen/arch/arm/traps.c   | 13 +++++++++++++
 xen/arch/x86/hvm/hvm.c |  6 ++++++
 xen/common/ioreq.c     |  9 ---------
 3 files changed, 19 insertions(+), 9 deletions(-)

diff --git a/xen/arch/arm/traps.c b/xen/arch/arm/traps.c
index 219ab3c3fbde..b246f51086e3 100644
--- a/xen/arch/arm/traps.c
+++ b/xen/arch/arm/traps.c
@@ -34,6 +34,7 @@
 #include <xen/symbols.h>
 #include <xen/version.h>
 #include <xen/virtual_region.h>
+#include <xen/vpci.h>
 
 #include <public/sched.h>
 #include <public/xen.h>
@@ -2304,6 +2305,18 @@ static bool check_for_vcpu_work(void)
     }
 #endif
 
+    if ( has_vpci(v->domain) )
+    {
+        bool pending;
+
+        local_irq_enable();
+        pending = vpci_process_pending(v);
+        local_irq_disable();
+
+        if ( pending )
+            return true;
+    }
+
     if ( likely(!v->arch.need_flush_to_ram) )
         return false;
 
diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c
index aa418a3ca1b7..c491242e4b8b 100644
--- a/xen/arch/x86/hvm/hvm.c
+++ b/xen/arch/x86/hvm/hvm.c
@@ -546,6 +546,12 @@ void hvm_do_resume(struct vcpu *v)
 
     pt_restore_timer(v);
 
+    if ( has_vpci(v->domain) && vpci_process_pending(v) )
+    {
+        raise_softirq(SCHEDULE_SOFTIRQ);
+        return;
+    }
+
     if ( !vcpu_ioreq_handle_completion(v) )
         return;
 
diff --git a/xen/common/ioreq.c b/xen/common/ioreq.c
index d732dc045df9..689d256544c8 100644
--- a/xen/common/ioreq.c
+++ b/xen/common/ioreq.c
@@ -25,9 +25,7 @@
 #include <xen/lib.h>
 #include <xen/paging.h>
 #include <xen/sched.h>
-#include <xen/softirq.h>
 #include <xen/trace.h>
-#include <xen/vpci.h>
 
 #include <asm/guest_atomics.h>
 #include <asm/ioreq.h>
@@ -212,19 +210,12 @@ static bool wait_for_io(struct ioreq_vcpu *sv, ioreq_t *p)
 
 bool vcpu_ioreq_handle_completion(struct vcpu *v)
 {
-    struct domain *d = v->domain;
     struct vcpu_io *vio = &v->io;
     struct ioreq_server *s;
     struct ioreq_vcpu *sv;
     enum vio_completion completion;
     bool res = true;
 
-    if ( has_vpci(d) && vpci_process_pending(v) )
-    {
-        raise_softirq(SCHEDULE_SOFTIRQ);
-        return false;
-    }
-
     while ( (sv = get_pending_vcpu(v, &s)) != NULL )
         if ( !wait_for_io(sv, get_ioreq(s, v)) )
             return false;
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Fri Oct 08 07:30:36 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Oct 2021 07:30:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.204442.359599 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYkKt-0007cD-Qe; Fri, 08 Oct 2021 07:30:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 204442.359599; Fri, 08 Oct 2021 07:30:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYkKt-0007c6-NM; Fri, 08 Oct 2021 07:30:31 +0000
Received: by outflank-mailman (input) for mailman id 204442;
 Fri, 08 Oct 2021 07:30:30 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mYkKs-0007c0-D7
 for xen-devel@lists.xenproject.org; Fri, 08 Oct 2021 07:30:30 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mYkKr-0005oh-Ka; Fri, 08 Oct 2021 07:30:29 +0000
Received: from [92.174.63.74] (helo=[192.168.1.232])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mYkKr-0001lD-5X; Fri, 08 Oct 2021 07:30:29 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=vEIys9Vh77UpxxvT8UC3WhfUTMWVco+WVb6ZcieKSDw=; b=wmzcWXKDN6scuZk0bmrz1kxtjX
	q5rf/19WIqZsofq73Q13/OPKDI88yOiFvkJhVZFMACLHplVh/jnT5h970lPWEON86uHnfzT9NqXai
	A311ddILdLcoK2Pa8BCQNPCQCRfovNBA1Xpg62JNwKSzMUDW7ZAl2UDWqoo4cTT4hDjE=;
Message-ID: <b9443cac-36ff-79b0-89d5-b96e8fc11d11@xen.org>
Date: Fri, 8 Oct 2021 09:30:25 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.1.2
Subject: Re: [PING] Re: [PATCH] xen/arm: optee: Allocate anonymous domheap
 pages
To: Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Cc: Oleksandr <olekstysh@gmail.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>,
 Julien Grall <jgrall@amazon.com>
References: <1630935741-17088-1-git-send-email-olekstysh@gmail.com>
 <alpine.DEB.2.21.2109231308200.17979@sstabellini-ThinkPad-T480s>
 <87bl4jrovq.fsf@epam.com> <81f7699b-69c1-da52-a1a7-5000343bf872@gmail.com>
 <alpine.DEB.2.21.2110061639050.3209@sstabellini-ThinkPad-T480s>
 <87r1cwra4t.fsf@epam.com>
 <alpine.DEB.2.21.2110071357160.414@sstabellini-ThinkPad-T480s>
From: Julien Grall <julien@xen.org>
In-Reply-To: <alpine.DEB.2.21.2110071357160.414@sstabellini-ThinkPad-T480s>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Stefano,

On 07/10/2021 23:14, Stefano Stabellini wrote:
> On Thu, 7 Oct 2021, Volodymyr Babchuk wrote:
>> Hi Stefano,
>>
>> Stefano Stabellini <sstabellini@kernel.org> writes:
>>
>>> On Wed, 6 Oct 2021, Oleksandr wrote:
>>>> Hello all
>>>>
>>>> Gentle reminder.
>>>   
>>> Many thanks for the ping, this patch fell off my radar.
>>>
>>>
>>>   
>>>> On 23.09.21 23:57, Volodymyr Babchuk wrote:
>>>>> Hi Stefano,
>>>>>
>>>>> Stefano Stabellini <sstabellini@kernel.org> writes:
>>>>>
>>>>>> On Mon, 6 Sep 2021, Oleksandr Tyshchenko wrote:
>>>>>>> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>>>>>>>
>>>>>>> Allocate anonymous domheap pages as there is no strict need to
>>>>>>> account them to a particular domain.
>>>>>>>
>>>>>>> Since XSA-383 "xen/arm: Restrict the amount of memory that dom0less
>>>>>>> domU and dom0 can allocate" the dom0 cannot allocate memory outside
>>>>>>> of the pre-allocated region. This means if we try to allocate
>>>>>>> non-anonymous page to be accounted to dom0 we will get an
>>>>>>> over-allocation issue when assigning that page to the domain.
>>>>>>> The anonymous page, in turn, is not assigned to any domain.
>>>>>>>
>>>>>>> CC: Julien Grall <jgrall@amazon.com>
>>>>>>> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>>>>>>> Acked-by: Volodymyr Babchuk <volodymyr_babchuk@epam.com>
>>>>>> Only one question, which is more architectural: given that these pages
>>>>>> are "unlimited", could the guest exploit the interface somehow to force
>>>>>> Xen to allocate an very high number of anonymous pages?
>>>>>>
>>>>>> E.g. could a domain call OPTEE_SMC_RPC_FUNC_ALLOC in a loop to force Xen
>>>>>> to exaust all memory pages?
>>>>> Generally, OP-TEE mediator tracks all resources allocated and imposes
>>>>> limits on them.
>>>>>
>>>>> OPTEE_SMC_RPC_FUNC_ALLOC case is a bit different, because it is issued
>>>>> not by domain, but by OP-TEE itself. As OP-TEE is more trusted piece of
>>>>> system we allow it to request as many buffers as it wants. Also, we know
>>>>> that OP-TEE asks only for one such buffer per every standard call. And
>>>>> number of simultaneous calls is limited by number of OP-TEE threads,
>>>>> which is quite low: typically only two.
>>>
>>> So let me repeat it differently to see if I understood correctly:
>>>
>>> - OPTEE_SMC_RPC_FUNC_ALLOC is only called by OP-TEE, not by the domain
>>> - OPTEE is trusted and only call it twice anyway
>>
>> Correct.
>>
>>> I am OK with this argument, but do we have a check to make sure a domU
>>> cannot issue OPTEE_SMC_RPC_FUNC_ALLOC?
>>
>> domU can't issue any RPC, because all RPCs are issued from OP-TEE
>> side. This is the nature of RPC - OP-TEE requests Normal World for some
>> service. But of course, Normal World can perform certain actions that
>> will make OP-TEE to issue a RPC. I discuss this in depth below.
>>
>>>
>>> Looking at the patch, there are other two places, in addition to
>>> OPTEE_SMC_RPC_FUNC_ALLOC, where the anonymous memory pages can be
>>> allocated:
>>>
>>> 1) copy_std_request
>>> 2) translate_noncontig
>>>
>>> We need to prove that neither 1) or 2) can result in a domU exausting
>>> Xen memory.
>>>
>>> In the case of 1), it looks like the memory is freed before returning to
>>> the DomU, right? If so, it should be no problem?
>>
>> Yes, mediator makes shadow copy of every request buffer to hide
>> translated addresses from the guest. Number of requests is limited by
>> number of OP-TEE threads.
>>
>>> In the case of 2), it looks like the memory could outlive the call where
>>> it is allocated. Is there any kind of protection against issuing
>>> something like OPTEE_MSG_ATTR_TYPE_TMEM_INOUT in a loop? Is it OP-TEE
>>> itself that would refuse the attempt? Thus, the idea is that
>>> do_call_with_arg will return error and we'll just free the memory there?
>>
>> Well, translate_noncontig() calls allocate_optee_shm_buf() which counts
>> all allocated buffers. So you can't call it more than
>> MAX_SHM_BUFFER_COUNT times, without de-allocating previous memory. But,
>> thanks to your question, I have found a bug there: memory is not freed
>> if allocate_optee_shm_buf() fails. I'll prepare patch later today.
>>
>>> I cannot see a check for errors returned by do_call_with_arg and memory
>>> freeing done because of that. Sorry I am not super familiar with the
>>> code, I am just trying to make sure we are not offering to DomUs an easy
>>> way to crash the system.
>>
>> I tried to eliminate all possibilities for a guest to crash the
>> system. Of course, this does not mean that there are none of them.
>>
>> And yes, code is a bit hard to understand, because calls to OP-TEE are
>> stateful and you need to account for that state. From NW and SW this
>> looks quite fine, because state is handled naturally. But mediator sits
>> in a middle, so it's implementation is a bit messy.
>>
>> I'll try to explain what is going on, so you it will be easier to
>> understand logic in the mediator.
>>
>> There are two types of OP-TEE calls: fast calls and standard calls. Fast
>> call is simple: call SMC and get result. It does not allocate thread
>> context in OP-TEE and is non-preemptive. So yes, it should be fast. It
>> is used for simple things like "get OP-TEE version" or "exchange
>> capabilities". It is easy to handle them in mediator: just forward
>> the call, check result, return it back to a guest.
>>
>> Standard calls are stateful. OP-TEE allocates thread for each call. This
>> call can be preempted either by IRQ or by RPC. For consistency IRQ
>> return is also considered as special type of RPC. So, in general one
>> standard call can consist of series of SMCs:
>>
>> --> SMC with request
>> <-- RPC return (like IRQ)
>> --> SMC "resume call"
>> <-- RPC return (like "read disk")
>> --> SMC "resume call"
>> <-- RPC return (like "send network packet")
>> --> SMC "resume call"
>> ...
>> <-- Final return
>>
>> There are many types of RPCs: "handle IRQ", additional shared buffer
>> allocation/de-allocation, RPMB access, disks access, network access,
>> synchronization primitives (when OP-TEE thread is gets blocked on a
>> mutex), etc.
>>
>> Two more things that makes all this worse: Normal World can register
>> shared buffer with OP-TEE. Such buffer can live indefinitely
>> long. Also, Normal World decides when to resume call. For example,
>> calling process can be preempted and then resumed seconds
>> later. Misbehaving guest can decide to not resume call at all.
>>
>> As I said, I tried to take all this things into account. There are
>> basically 3 types of objects that can lead to memory allocation on Xen
>> side:
>>
>> 1. Standard call context. Besides memory space for struct optee_std_call
>> itself it allocates page for a shadow buffer, where argument addresses
>> are translated by Xen. Number of this objects is limited by number of
>> OP-TEE threads:
>>
>>      count = atomic_add_unless(&ctx->call_count, 1, max_optee_threads);
>>      if ( count == max_optee_threads )
>>          return ERR_PTR(-ENOSPC);
>>
>> 2. Shared buffer. This is a buffer shared by guest with OP-TEE. It can
>> be either temporary buffer which is shared for one standard call
>> duration, or registered shared buffer, which is remains active until it
>> is de-registered. This is where translate_noncontig() comes into play.
>> Number of this buffers is limited in allocate_optee_shm_buf():
>>
>>      count = atomic_add_unless(&ctx->optee_shm_buf_count, 1,
>>                                MAX_SHM_BUFFER_COUNT);
>>      if ( count == MAX_SHM_BUFFER_COUNT )
>>          return ERR_PTR(-ENOMEM);
>>
>> 3. Shared RPC buffer. This is very special kind of buffer. Basically,
>> OP-TEE needs some shared memory to provide RPC call parameters. So it
>> requests buffer from Normal World. There is no hard limit on this from
>> mediator side, because, as I told earlier, OP-TEE itself limits number
>> of this buffers. There is no cases when more that one buffer will be
>> allocated per OP-TEE thread. This type of buffer is used only to process
>> RPC requests themselves. OP-TEE can request more buffers via RPC, but
>> they will fall to p.2: NW uses separate request to register buffer and
>> then returns its handle in the preempted call.
>>
>>
>> Apart from those two limits, there is a limit on total number of pages
>> which is shared between guest and OP-TEE: MAX_TOTAL_SMH_BUF_PG. This
>> limit is for a case when guest tries to allocate few really BIG buffers.
>>
>>
>>> It looks like they could be called from one of the OPTEE operations that
>>> a domU could request? Is there a limit for them?
>>
>> Yes, there are limits, as I described above.
>>
>> Also, bear in mind that resources available to OP-TEE are also quite
>> limited. So, in case of some breach in mediator, OP-TEE will give up
>> first. This of course is not an excuse to have bugs in the mediator...
> 
> OK, thanks for the explanation. The reasons for my questions is that if
> the allocations are using the memory of DomU, then at worst DomU can run
> out of memory. 

Not really. The worst outcome is still a DoS of the host because we 
don't pre-allocate memory or even check that the total allocation will 
not exhaust the memory.

The only difference is I would argue this would be a misconfiguration of 
the system.

> But if the allocations are using anonymous memory, then
> the whole platform might run out of memory. We have issued XSAs for
> things like that in the past.
> 
> This is why I am worried about this patch: if we apply it we really
> become reliant on these limits being implemented correctly. A bug can
> have much more severe consequences.

This is not a problem specific to OP-TEE. Any anymous allocation 
(xmalloc,...) done in Xen on behalf of the guest has, in theory, the 
same problem (see more below).

> 
> As you are the maintainer for this code, and this code is not security
> supported, I'll leave it up to you (also see the other email about
> moving optee to "supported, not security supported").
> 
> However, maybe a different solution would be to increase max_pages for a
> domain when optee is enabled? Maybe just by a few pages (as many as
> needed by the optee mediator)? Because if we did that, we wouldn't risk
> exposing DOS attack vectors for every bug in the mediator limits checks.
I think we need to differentiate two sorts of allocation:
   1) Memory used by Xen on behalf of the guest
   2) Memory used by the guest itself

d->max_pages is only meant to refer to the latter (in fact, a guest can 
balloon memory up to d->max_pages). In this case, we are discussing 
about the latter and therefore I think the should be accounted 
differently as the memory is not exposed to the guest.

Today, Xen doesn't have this facility. I know this has been discussed a 
few times in the past, but AFAIK, a patch series never materialized for it.

However, to me, this sounds more an hardening work for the whole Xen 
rather than OP-TEE itself. So I think the patch provided by Oleksandr is 
probably the best way to go for this release.

>
> The below adds a 10 pages slack.
> 
> 
> diff --git a/xen/arch/arm/tee/tee.c b/xen/arch/arm/tee/tee.c
> index 3964a8a5cd..a3105f1a9a 100644
> --- a/xen/arch/arm/tee/tee.c
> +++ b/xen/arch/arm/tee/tee.c
> @@ -38,8 +38,11 @@ bool tee_handle_call(struct cpu_user_regs *regs)
>       return cur_mediator->ops->handle_call(regs);
>   }
>   
> +#define TEE_SLACK (10)
>   int tee_domain_init(struct domain *d, uint16_t tee_type)
>   {
> +    int ret;
> +
>       if ( tee_type == XEN_DOMCTL_CONFIG_TEE_NONE )
>           return 0;
>   
> @@ -49,7 +52,15 @@ int tee_domain_init(struct domain *d, uint16_t tee_type)
>       if ( cur_mediator->tee_type != tee_type )
>           return -EINVAL;
>   
> -    return cur_mediator->ops->domain_init(d);
> +    ret = cur_mediator->ops->domain_init(d);
> +    if ( ret < 0 )
> +        return ret;
> +
> +    /*
> +     * Increase maxmem for domains with TEE, the extra pages are used by
> +     * the mediator
> +     */
> +    d->max_pages += TEE_SLACK;

Regardless what I wrote above, this change would be incorrect because 
TEE is initialized the when domain is created. However, d->max_pages is 
set afterwards via DOMCTL_max_mem, so the value will get overridden.

However, I don't think OP-TEE code should modify d->max_pages. Instead, 
this should be accounted by the toolstack (or domain_build for dom0/domU 
created by Xen).

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Oct 08 07:45:42 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Oct 2021 07:45:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.204464.359610 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYkZU-00016Q-53; Fri, 08 Oct 2021 07:45:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 204464.359610; Fri, 08 Oct 2021 07:45:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYkZU-00016J-1i; Fri, 08 Oct 2021 07:45:36 +0000
Received: by outflank-mailman (input) for mailman id 204464;
 Fri, 08 Oct 2021 07:45:34 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=JgHw=O4=huawei.com=yuehaibing@srs-us1.protection.inumbo.net>)
 id 1mYkZS-00015s-5Q
 for xen-devel@lists.xenproject.org; Fri, 08 Oct 2021 07:45:34 +0000
Received: from szxga02-in.huawei.com (unknown [45.249.212.188])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id b66476de-280b-11ec-8024-12813bfff9fa;
 Fri, 08 Oct 2021 07:45:32 +0000 (UTC)
Received: from dggemv703-chm.china.huawei.com (unknown [172.30.72.56])
 by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4HQg8n2vzdz909M;
 Fri,  8 Oct 2021 15:40:41 +0800 (CST)
Received: from dggema769-chm.china.huawei.com (10.1.198.211) by
 dggemv703-chm.china.huawei.com (10.3.19.46) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id
 15.1.2308.8; Fri, 8 Oct 2021 15:45:23 +0800
Received: from localhost (10.174.179.215) by dggema769-chm.china.huawei.com
 (10.1.198.211) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.8; Fri, 8 Oct
 2021 15:45:23 +0800
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b66476de-280b-11ec-8024-12813bfff9fa
From: YueHaibing <yuehaibing@huawei.com>
To: <boris.ostrovsky@oracle.com>, <jgross@suse.com>, <sstabellini@kernel.org>
CC: <xen-devel@lists.xenproject.org>, <linux-kernel@vger.kernel.org>,
	YueHaibing <yuehaibing@huawei.com>
Subject: [PATCH -next] xen-pciback: Fix return in pm_ctrl_init()
Date: Fri, 8 Oct 2021 15:44:17 +0800
Message-ID: <20211008074417.8260-1-yuehaibing@huawei.com>
X-Mailer: git-send-email 2.10.2.windows.1
MIME-Version: 1.0
Content-Type: text/plain
X-Originating-IP: [10.174.179.215]
X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To
 dggema769-chm.china.huawei.com (10.1.198.211)
X-CFilter-Loop: Reflected

Return NULL instead of passing to ERR_PTR while err is zero,
this fix smatch warnings:
drivers/xen/xen-pciback/conf_space_capability.c:163
 pm_ctrl_init() warn: passing zero to 'ERR_PTR'

Fixes: a92336a1176b ("xen/pciback: Drop two backends, squash and cleanup some code.")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 drivers/xen/xen-pciback/conf_space_capability.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/xen/xen-pciback/conf_space_capability.c b/drivers/xen/xen-pciback/conf_space_capability.c
index 22f13abbe913..5e53b4817f16 100644
--- a/drivers/xen/xen-pciback/conf_space_capability.c
+++ b/drivers/xen/xen-pciback/conf_space_capability.c
@@ -160,7 +160,7 @@ static void *pm_ctrl_init(struct pci_dev *dev, int offset)
 	}
 
 out:
-	return ERR_PTR(err);
+	return err ? ERR_PTR(err) : NULL;
 }
 
 static const struct config_field caplist_pm[] = {
-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Fri Oct 08 07:56:38 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Oct 2021 07:56:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.204473.359620 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYkk4-0002au-4e; Fri, 08 Oct 2021 07:56:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 204473.359620; Fri, 08 Oct 2021 07:56:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYkk4-0002an-1f; Fri, 08 Oct 2021 07:56:32 +0000
Received: by outflank-mailman (input) for mailman id 204473;
 Fri, 08 Oct 2021 07:56:30 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=aYfl=O4=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mYkk2-0002ah-LN
 for xen-devel@lists.xenproject.org; Fri, 08 Oct 2021 07:56:30 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 3e2ab582-280d-11ec-8024-12813bfff9fa;
 Fri, 08 Oct 2021 07:56:29 +0000 (UTC)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2056.outbound.protection.outlook.com [104.47.12.56]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-17-8i-8duU-NzWwPn1iZ99gjg-1; Fri, 08 Oct 2021 09:56:27 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB2960.eurprd04.prod.outlook.com (2603:10a6:802:9::11) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.20; Fri, 8 Oct
 2021 07:56:25 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4587.022; Fri, 8 Oct 2021
 07:56:25 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6PR0202CA0038.eurprd02.prod.outlook.com (2603:10a6:20b:3a::15) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18 via Frontend
 Transport; Fri, 8 Oct 2021 07:56:23 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3e2ab582-280d-11ec-8024-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1633679788;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=2vAW8SDWXbN3ekL7gqDpKyQSL3EP0k1DGBqTl/ILtoc=;
	b=kKJAtQ27rdno6zcsIA6LKxVsMH4HSPbs7sk5uewcfRx6Lnpth39+rlMHJf33ypw3A8ubyQ
	a+uxgc4X+gscfTw97CVEpmwmhDtBGb8lqzGjas4yvFBwvrqari4BGUtH4+FyFolooz61OE
	Ps8mKx6VOQ4dbOF5/VFY9v4BmKiRON0=
X-MC-Unique: 8i-8duU-NzWwPn1iZ99gjg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=aV7uRgV5hUYAymGwX/GOmcyuCofOB0fclrHpgPE4iUfMxuBDtsw4AN+osXfRV9M8cYLdUQ0aTQEYP1/EOLYeRMoKm+h0XFXNU9rdoHmvmRLZBLoUBJkFkTSRuBjzNuYBol6OZrtRuqD5LMYCA1tenltQUAcUM68GaX8QPr7UEry3oA1qZ+uay2lZn7EODsvNJVly+n7YB/eOMPQBYAK1ld9eSOBYP4hmutmPkqGFp8ehoYUcmTV8hpgQBciSLess0y0Oj7gGGI5qY4DfMFou7npGJIofe1MRlJowwCFfFMkID3+iExBaoIus85epERQi5LETmNxNIkpkEIjgeRIEAQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=2vAW8SDWXbN3ekL7gqDpKyQSL3EP0k1DGBqTl/ILtoc=;
 b=SeBbwHLlHpWgxHnM40WeFG2gVwdA9ZwqutzdCRmqKNRSwdwISm9f0ZGnkOZ7R4HOAE0nSdH2Eo3uQeo8PNMR/ISCl4aQW4B2Y0A7lXRwmWxMBhGRpoVJy/nwSqQeLehlDlxlt07ofmfRWLQz104XKzQk1r7jgrwtMhyNQ6+WAe0pfJSItmRQWDPZhXABo6TRsJ0aNN6cfoSNlyBB5j47K15RxTbQO/n+yz0FC0VrApdM3ZJqDhQbPwuH8g3ZnhAOKWnqNy1hciJP/S2epARCUfMphB3AgiS54BLuxX0hK3XhggfrpwXRt2t/do+ofH5S/oMmdz9m5GpfhSK7qLU9QA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [PATCH] docs: add references to Argo Linux driver sources and
 information
To: Christopher Clark <christopher.w.clark@gmail.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>, Rich Persaud <persaur@gmail.com>,
 Daniel Smith <dpsmith@apertussolutions.com>,
 Jason Andryuk <jandryuk@gmail.com>, Eric Chanudet <chanudeter@gmail.com>,
 openxt@googlegroups.com, xen-devel@lists.xenproject.org
References: <20211008041241.227823-1-christopher.w.clark@gmail.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <000f9cc2-898c-5d6e-b6fe-d5dc776710ae@suse.com>
Date: Fri, 8 Oct 2021 09:56:22 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <20211008041241.227823-1-christopher.w.clark@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR0202CA0038.eurprd02.prod.outlook.com
 (2603:10a6:20b:3a::15) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 1dbf4eb5-6b9e-4cd6-0207-08d98a312038
X-MS-TrafficTypeDiagnostic: VI1PR04MB2960:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB2960BA4B6763E0C98FAC5B74B3B29@VI1PR04MB2960.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	7o41/KS/PezFgcPVkAxUu4JVUj87Umebpxk00zZR7tqxkNlTrjBZ3pHUeQWQvjesbVNExRCs2Km1vLZMedifKKCsKMM+yjLydGetjcVxygVW6nfMconROkHHNU5PHkzSukb0ANUUxuInGLopwcaMS992DqQag+Wq8ixj5a3kBe47hl2eJ6f5I/mb59467erFyncKqNujvI2FqOnXAoWYGr3n4LvE/RUPSwlYCZJD+UvAGNVv4TnTfbFcnxjZ++AV8IFcOuRn1OSRqPsWAz0j5vBJNhpbsRXV2P8DgQUOi0EErqp4KCw662oVBmC5Q9VPbqP5/w0PLu0+yth0GXaF16jBUVDiXceizXwXNSVus14tNd+/cT8xXg8mcMna8AtEBUGqNuWElPgnVwLBybWunb+9Jz2RnHQO15LcCa/g0UxxsboQZf905loh3X+8EmXPXsYPWM2UjA4xYnY6VNK9/fUmDB5I5pYPfmvzoXejKq55v1qB2SOnkFoZ9kErg4vtjvfmie861MPrkTvo6KVVjLd3Me87J1lfzekFKYQ4+UcRKbXu8liw3MXyHYNDlDDmPe6PmezxhgJjNZGTMCQs0WrAeRslqHcDSpZ/+ZDNRmuJahKst7MY0OJcj1RCHreL4XDE9YNkOr0dQVxEvbh8vdMwmTRgqET4Eyk3zaBtMNIetfuxOhjGd9IbI/VFuEl4585YqbFWO6cEpoCE0+Zkp4C0PaoeDdNRMO4FIA4N1oLZr9EQwhTsXAmXL8pbjtkzIATM1ODdXizDy56iL9ZbF/TgmqcuiYY8C+2J+wxZ4q0qH8rT1TiOrcNlAY0ghS/W7q26VCmqaRKG6peRM+9zje52zLnU3OU7O6i3pQ4ftyQ=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(16576012)(2616005)(6486002)(186003)(38100700002)(956004)(83380400001)(36756003)(2906002)(4326008)(66556008)(66476007)(31686004)(26005)(66946007)(54906003)(86362001)(8936002)(508600001)(53546011)(5660300002)(8676002)(7416002)(316002)(31696002)(6916009)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?bzR6b3NHOFovTnB2S0lUTHdtMGU0TmFtd2t0eU9wUUVGdGVieHkzbFpuNHor?=
 =?utf-8?B?YlBzWGRFb2J4cGh5S3B0eW55NTJZT2JiNWdWQUFWSUZGUElwVEYrMWZPdzlX?=
 =?utf-8?B?bk1PTnNLVmdleFcrM2U3SHVTUlVzTlFXRTJDeTlQYU9KaXpreHBMK2I2V3dG?=
 =?utf-8?B?QVFTdkxraUIrM0FCRHRTMkpJWVZqQUpRTllxa1JCYTdSQ2w1emk1OXp5L3d5?=
 =?utf-8?B?N0JRYXhuaENzZElWZGI2WW5Wc293SGl3cGxzRk5jT0hsSHE3cXoxMWpmcFlO?=
 =?utf-8?B?UHV1WFpGT29aTElBQWtCSk9ZbEUrRUNVZEZBakdaTUs5TGlGK2ZVRFdBazRE?=
 =?utf-8?B?eDV5MVIyVTN5YVVZcmp2YURvb2NqUERJUG9WSHkzWUhtMGRodHhOczhaVVFu?=
 =?utf-8?B?aFRodUZraWV0b0J2elJCSlRhU0ZzdVIvOERTcUZQN2NrNU9mZDRZK0ZBMGJt?=
 =?utf-8?B?L0FOTXh3NkdBdGsrT0xKYWZvT25UcnZ1RzU2S2wvSTd0SkhxdVljZStqZEcw?=
 =?utf-8?B?S3Z6eXV0RU14cEJTQUppcDR5b2FaYnRISjRzNjc5bjBXeXppWlRSb1NtWTht?=
 =?utf-8?B?Qnd4NWVjSzRKbkRPNm9ZSnBETldvVGJlZ3czY2F6UGNYOWZZZ1B2WnU4NFpZ?=
 =?utf-8?B?YmlLa09sNCs5SG9YdUpKWC90djYvRkpHdTZ3aWgvZUVCRnFwU1dNcHE1M0ht?=
 =?utf-8?B?LzBlaDhwMVEwYjVldk1UcSt5MVg3TFFhTDVsaHFSNm5SSFE3MDYxU0JXU05u?=
 =?utf-8?B?N1M2cnl1M0cwKzBRcWd5Z2ttemxlZjk0TytueVMvU0pKL3lXY0x2R2pkc0k0?=
 =?utf-8?B?QkZ6a1FoWTUxV3dUV25YQkV5cHZEVFZ4OW5zNEFJZ3hyWnZmM2VuY0RTRWZE?=
 =?utf-8?B?b1pEU25XQXplTGp1QWFRdENoTlZFY090bUsrRmFweDBKV2RQRHFKTEE1ZW05?=
 =?utf-8?B?T1dzSEF3YnFWdHIrczR0WmE0djRpY1BnYWpaVGxjeXhpN3dFcVBESVZXSWZW?=
 =?utf-8?B?UFZ0WmFja2IvREM4ZHJ2UkFzQllyRFdQWHExcDdTaTRWM0VQa2RucUkvU21J?=
 =?utf-8?B?MzM0WHlQRXR2NTlHWWJOeFNqc0Y2OTMyVWxZLzlBUlJvTlpIQW1NbHJHcUN2?=
 =?utf-8?B?dU9ZNDYyTGNLWUdZc0ZTWXE1Q2llR0pHT1ZvNkdDekFTNDBWK2gvSmNPZVRK?=
 =?utf-8?B?RDRkaGhEZDFMbHBaeElCUys1V09BcTJtWkdwandHeHdsSlQ5UjJiV1Q2VFNM?=
 =?utf-8?B?dEgvZkU2NG00bnhkNFJ3UU10b0VrZ0tOaG5GTkJyOWgyeXhTNkNndUJ4ak5w?=
 =?utf-8?B?bnpVNTNQMnB6bDhYVEFxZ0hwbnVMc2RWTndkNitIMVFGekxEcHAvWGFQS1ZF?=
 =?utf-8?B?SXh6TjlRaUJwd0dOZ1h4SW9qYUZQTEtGYlQ5Y3dkTUlUYkE0NHlRemRtRnQ0?=
 =?utf-8?B?eFBOMkpiRWc0Nnp1cTJVaC83TEZINGpRa0FHeXQzR2tVKzIzYU9FdkJKUkVi?=
 =?utf-8?B?VW9nV2Rnc0dDaDNiVkUvMnVJZmd5LzZJTzJBTVFLRTRHcGR4ZGFvVGQrb0FJ?=
 =?utf-8?B?eThZSzZGejlZMWVzN1hQUGtJUGphejJ4cXQrMTh6TTJGUW9nYUU4Wk8rcllI?=
 =?utf-8?B?Tm5KRUZqbTdUT0lIQkxUT2duOXhqZ2FLbFYrWXowMHRCNUVWN0RSZ0crMlJJ?=
 =?utf-8?B?czdqWkRxSnFCQnZMVTVGZWtQdGZ2eFNEZXFuRFJqMlpXaGtPSFIxVWVlWCsw?=
 =?utf-8?Q?uEV9i9RxPzKG41j4O6dpbEIE7oknGCy1oKeJPub?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1dbf4eb5-6b9e-4cd6-0207-08d98a312038
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Oct 2021 07:56:25.0356
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: eyFyiQN/FHbZ9XHkhEvZ0WhratsbVleW5yV6Ar69TpHusm4ylRxsKdSi3AUDy//I/O+lQalqGdxfQz6U1MsyNA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB2960

On 08.10.2021 06:12, Christopher Clark wrote:
> Add a section to the Argo design document to supply guidance on how to
> enable Argo in Xen and where to obtain source code and documentation
> for Argo device drivers for guest OSes, primarily from OpenXT.
> 
> Signed-off-by: Christopher Clark <christopher.w.clark@gmail.com>

Just a nit:

> --- a/docs/designs/argo.pandoc
> +++ b/docs/designs/argo.pandoc
> @@ -439,6 +439,51 @@ that teardown of any domain will not interfere with any Argo hypercall
>  operation. It enables introducing granular locking without complex or
>  error-prone lock acquisition logic.
>  
> +# Related Material
> +
> +## Enabling Argo in Xen
> +
> +To enable Argo in a build of the Xen hypervisor, please ensure that
> +CONFIG_ARGO is enabled in the Xen hypervisor build configuration file.
> +
> +To make Argo available for use at runtime on a Xen system, please see the
> +Argo settings in the Xen command line document.
> +
> +## Linux Argo drivers
> +
> +A Linux kernel device driver for Argo and corresponding Linux userspace
> +software, libargo, that utilizes it for interdomain communication between
> +application level software is available and maintained by the OpenXT Project,
> +at:
> +
> +https://github.com/OpenXT/linux-xen-argo
> +
> +The repository contains the primary Linux kernel Argo driver, which is derived
> +from the original XenClient v4v driver. The document at the following link
> +describes planning and design notes from OpenXT community discussion for
> +improvements to the driver:
> +
> +https://openxt.atlassian.net/wiki/spaces/DC/pages/775389197/New+Linux+Driver+for+Argo
> +
> +An alternative Linux Argo driver is in also available in the same repository,

One "in" too many? Probably fine to adjust whole committing, if no other
comments arise.

Jan

> +implemented to explore a different approach for Linux to use the Argo
> +primitives under the Vsock address family to allow socket communication between
> +Xen domains.
> +
> +## v4v drivers
> +
> +A Windows driver for v4v has previously been used in XenClient and OpenXT
> +which could be ported to Argo. It may require update for compatibility with
> +recent versions of Windows software.
> +
> +https://github.com/OpenXT/xc-windows/tree/master/xenv4v
> +
> +The Linux, Windows and OSX guest tools for the Open Source HP uxen hypervisor
> +contain drivers for v4v which are relevant as code bases of interest for
> +porting or developing new guest OS drivers for Argo.
> +
> +https://github.com/uxen-virt/uxen/tree/ascara/vm-support
> +
>  # Future Work
>  
>  - Performance measurement and optimization
> 



From xen-devel-bounces@lists.xenproject.org Fri Oct 08 08:01:10 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Oct 2021 08:01:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.204488.359632 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYkoV-0004dl-49; Fri, 08 Oct 2021 08:01:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 204488.359632; Fri, 08 Oct 2021 08:01:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYkoV-0004de-0K; Fri, 08 Oct 2021 08:01:07 +0000
Received: by outflank-mailman (input) for mailman id 204488;
 Fri, 08 Oct 2021 08:01:06 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=/CyP=O4=arm.com=Bertrand.Marquis@srs-us1.protection.inumbo.net>)
 id 1mYkoT-0004dY-Um
 for xen-devel@lists.xenproject.org; Fri, 08 Oct 2021 08:01:06 +0000
Received: from EUR01-HE1-obe.outbound.protection.outlook.com (unknown
 [40.107.13.81]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id e2af2e3a-280d-11ec-8024-12813bfff9fa;
 Fri, 08 Oct 2021 08:01:05 +0000 (UTC)
Received: from DU2PR04CA0312.eurprd04.prod.outlook.com (2603:10a6:10:2b5::17)
 by DBBPR08MB5948.eurprd08.prod.outlook.com (2603:10a6:10:202::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18; Fri, 8 Oct
 2021 08:00:59 +0000
Received: from DB5EUR03FT055.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:10:2b5:cafe::93) by DU2PR04CA0312.outlook.office365.com
 (2603:10a6:10:2b5::17) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.19 via Frontend
 Transport; Fri, 8 Oct 2021 08:00:59 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT055.mail.protection.outlook.com (10.152.21.30) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4587.18 via Frontend Transport; Fri, 8 Oct 2021 08:00:59 +0000
Received: ("Tessian outbound e27daf245730:v103");
 Fri, 08 Oct 2021 08:00:51 +0000
Received: from fa14c3acbc5e.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 90EDF76D-FC61-4703-81D1-AA156BBFAF13.1; 
 Fri, 08 Oct 2021 08:00:44 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id fa14c3acbc5e.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 08 Oct 2021 08:00:44 +0000
Received: from AM5PR0801MB2019.eurprd08.prod.outlook.com
 (2603:10a6:203:4b::22) by AS8PR08MB6183.eurprd08.prod.outlook.com
 (2603:10a6:20b:29e::6) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.21; Fri, 8 Oct
 2021 08:00:43 +0000
Received: from AM5PR0801MB2019.eurprd08.prod.outlook.com
 ([fe80::80a2:ff50:fde5:5215]) by AM5PR0801MB2019.eurprd08.prod.outlook.com
 ([fe80::80a2:ff50:fde5:5215%3]) with mapi id 15.20.4587.020; Fri, 8 Oct 2021
 08:00:43 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e2af2e3a-280d-11ec-8024-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=QR/RcfSshFxSKIMvdnlA11f7GtWbkZptQZKqf0t4mps=;
 b=ndBiI7mQtRNFj6hTV04kuHsjP7Ywa0Xk/85X2oflohIBKpQO2P52KOMEl3vTfs21MKVDcJRN4lyfrmN9yM3XaFgPv42i5jPzv1VQN1oS1pCB34PJ1j4ZYF/4Kr0IVRdpzRlXOvic7kv4xzKxdr3QX0KRsoomwKIBkfFf9398rOQ=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: fba830e8a5ac65e9
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=gQETDXNa+XEnYxbvVICFXO8oxihhIUQyjDVgoH3HhCt7lzfvL8SuYcTrr+pZrGf5I72D+wepnb1pYEvcJXJc5RFkZ1KC+vlHry6+YbpYG8sv2PL2v/vJKj8qOXNdvc2aDX07STmQxnEs8fgj+hK9AqtIEjR5MrLFFaYzTZ7KI3KoMw7r07ajNfjgf/7aJ8xiF49bCbI3Sm2kJy17r4j4fHedvooo/3NtqU+29OO7W0uM4Hdem3Die0okbeXbezsqMBPU3ropwzDIZmVxQ/MdXHsFd/AdxaAFMqlMez9TZZV78XcgoRWbXTKFQYBdb4v4W6Ixjm73d0T9mbt4LtOarA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=QR/RcfSshFxSKIMvdnlA11f7GtWbkZptQZKqf0t4mps=;
 b=I8TgOCRuHO3kygzbqRF2o0QF4ruuI3swQY9jyla43wthZ6FeKDivPsOHIetepWQrk9EaPnpiXPibd2R6k/0qcbx2mK02iIPCOsgIZPUFVAezLhQGQCVQPBqjvFvc/94L7LhYrDHaRXC/96nFlPuzNoz9Lg3H7OaU3jGrtcN0sQM7dZbHEW0FUovuuvBBFVjjPu5tHN9YCZGfL5ccLPx6/BhJmF7N4P6yhR1wD4WLpm1no5W2Y1XGc4ALzeAEW02SIqbI8K/ZyJArrjcosl8XzdzelCThG4ABZP3cUypfQvgp2MkxEyDbJbQeg6fr0icZvJPW2QOWOQkRHu9cR0NEog==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=QR/RcfSshFxSKIMvdnlA11f7GtWbkZptQZKqf0t4mps=;
 b=ndBiI7mQtRNFj6hTV04kuHsjP7Ywa0Xk/85X2oflohIBKpQO2P52KOMEl3vTfs21MKVDcJRN4lyfrmN9yM3XaFgPv42i5jPzv1VQN1oS1pCB34PJ1j4ZYF/4Kr0IVRdpzRlXOvic7kv4xzKxdr3QX0KRsoomwKIBkfFf9398rOQ=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Christopher Clark <christopher.w.clark@gmail.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>, Andrew Cooper
	<andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>, Ian
 Jackson <iwj@xenproject.org>, Jan Beulich <jbeulich@suse.com>, Julien Grall
	<julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>, Wei Liu
	<wl@xen.org>, Rich Persaud <persaur@gmail.com>, Daniel Smith
	<dpsmith@apertussolutions.com>, Jason Andryuk <jandryuk@gmail.com>, Eric
 Chanudet <chanudeter@gmail.com>, "openxt@googlegroups.com"
	<openxt@googlegroups.com>
Subject: Re: [PATCH] docs: add references to Argo Linux driver sources and
 information
Thread-Topic: [PATCH] docs: add references to Argo Linux driver sources and
 information
Thread-Index: AQHXu/rzKybFoOgLIEWlKhrre2e4IavIvTgA
Date: Fri, 8 Oct 2021 08:00:43 +0000
Message-ID: <69AF5051-8F44-447D-A0D3-269D8E3A4CE3@arm.com>
References: <20211008041241.227823-1-christopher.w.clark@gmail.com>
In-Reply-To: <20211008041241.227823-1-christopher.w.clark@gmail.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3654.120.0.1.13)
Authentication-Results-Original: gmail.com; dkim=none (message not signed)
 header.d=none;gmail.com; dmarc=none action=none header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: 207189c7-a11f-4546-d8ef-08d98a31c3dc
x-ms-traffictypediagnostic: AS8PR08MB6183:|DBBPR08MB5948:
X-Microsoft-Antispam-PRVS:
	<DBBPR08MB5948DCBE9B49BB34495527029DB29@DBBPR08MB5948.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:9508;OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 yvLtBCp7Uj2gA/juRk0vMkGSxAQ8FrFcEWnPSeo6V5iuwTOnZZiermiAgbLAuoQtdc3fuX6zzG9+4Yfhhkj0Ml0UNuCRCbJimLAyvxq2xotRs79z4OCSazKFYaOqAOdUGE2qDAfwOjMeWL1Vv4IPCjB9YIlEuSjXrwPoQ2Xc4Xg6e2q7pi8XQ+1zvbXWfroPEg9AEJ0zPjBhvQ5WgbCLckVXiK0ju46NF5SSVL2G3QO4dCeWjlSJgE6vMAGZkU1osI6kWNC3I8yPE1UhCGJ5MIoeQIigDgxyjarqqaHvyJuBZKaacPi0i/OQyNHnYJf2Z5Bg8zJ98OHWPRLuyxOp/qG2R7Ta8V7dxfFzFAJ/TvBSkzXnXHEkoE7a6aw0Wi+vsqbpwPN63yXsXK9NNOkrFiewEW+ehpFRgRnaLtRWIe0nB+kWdIZpC9alp7Vog+Y7HHGqcVL5AT4w2XGWLuSRB0QJLrEbWnCuWjUcw/dLsRYCEcLyJqCwaPk7YCzYcM3PAmj6UrLrdTXbJ/wxUyDoitBh9pb7X8eDAMIMKe9IvecwQ+2fNHcwnjuT6wHVZATRmwn6n4kuW1Ecmc0qzgqN2IP1F1w0l07to2Ci8UFD9iCONZLvGGMZsUDSrsb1ILKh+xi0te9p5IlpiC/oeV/Mg+/VAy+57uG7nQqTZLVTphbi4VlHeZQRPRVjUSUYRAF+F2vLPT8115T5z06eFnIfdZFqTk/dOw1zX72GeKwOrIQBeo61ROcV4kmHS8CYNOVAttOMWaTMXK79y0S8n3RqkFHDK7n9ogIzVuaOiG2XwRZTCv20IwP6KzV4Bm6Vpj8PSLuhn7f+CS52F8FiobeF5FVJfPnoUOaTFe9Q+QYdBg83WZ/h2AQYOmhfFCHBPWCi
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM5PR0801MB2019.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(508600001)(83380400001)(6486002)(6512007)(71200400001)(33656002)(2616005)(86362001)(8936002)(8676002)(6916009)(122000001)(36756003)(6506007)(53546011)(76116006)(91956017)(4326008)(66476007)(64756008)(66446008)(66556008)(38100700002)(5660300002)(7416002)(66946007)(316002)(26005)(2906002)(186003)(38070700005)(54906003)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="us-ascii"
Content-ID: <778B7491D333DE4FB31B4852345ABA24@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6183
Original-Authentication-Results: gmail.com; dkim=none (message not signed)
 header.d=none;gmail.com; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT055.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	7c8218cc-f295-4330-1e37-08d98a31ba57
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	YWrQDh9Gezdrh9pf9qq3bWcV/XH0IXQeEbZ9BTaWfHU04qRXSEDART6wMPZ0uywbIogeEnhkwCX+8BLjeuYOQuQB6hxtorzJFKLs62x2b0uIta+SDWUGTk0EYD9kTlsDirEYDhNqmNgt3g5ZdUqC01R6QlzisV/yvY9L/HaqsZcyC9deIQUJgNhtSq4dDJqDk3WFFehuaSelhdXt3RFOdxOjnBcdQ7CHcFUSpE+wV2igTb3/+Ru87DZoHRx/om2VbK3Q1dF2/YFn1NipwK94fL9D3tnzVfi62auSpU3hqHMHY29nPW0XqdVGG8Z5vzJ/1sRJHq3zp3rDt+hyIjDHDvN+P9OBPBuG3Ersus4Pt6b/GSRxHudqWFG6Ep5PuM/pdPPPeVMACk7rcl4U4teN8DSyhrfE+EZkvl22lXGiVfz/ZBYbabA/wIcY5M6zXQN81ceZlcOCt0l9pLjX+qaZF7qR8bXqP8+Xz1RZLnIUfhHhFF5ZovXlDmn20Vj8mAabbcuA/P+EG5EPFz3vr7W4dnFVrg+lgVh/ljrQdoFElSj1i7/uHyq/5/Cm7hNPFXr5EHh+yg1Hq1U9OFet11hi65qIW2730e4QlZiifR+9heAXecOowe7z+5HxTJlWZ6CXQwYxJrmHCvkjuAbFS6D3SzQMiHfL1GGs/HikFdAGdGbA5A1BLo1pNQIf2SZfA9IjJLuH/sDRXv+zr9a6p9oghMFPlHDt19UAUffj88Qh/qacIJYtKiWtek1nt8t9iM0VJ869Mk1uVTG5xfoskNr5HBJkHiz/4GAA7G1ESgiH3HeeIVRZhfKF23R56lPXoXIoUnA1VrwsivPIhfdIG5TobA==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(8676002)(107886003)(54906003)(336012)(8936002)(70206006)(316002)(2906002)(82310400003)(356005)(81166007)(36756003)(53546011)(70586007)(6506007)(6486002)(6512007)(508600001)(33656002)(186003)(36860700001)(4326008)(6862004)(5660300002)(83380400001)(86362001)(26005)(47076005)(2616005);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Oct 2021 08:00:59.3617
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 207189c7-a11f-4546-d8ef-08d98a31c3dc
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT055.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB5948

Hi Christopher,

Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>

Just one small NIT that could be fixed during commit.

> On 8 Oct 2021, at 05:12, Christopher Clark <christopher.w.clark@gmail.com=
> wrote:
>=20
> Add a section to the Argo design document to supply guidance on how to
> enable Argo in Xen and where to obtain source code and documentation
> for Argo device drivers for guest OSes, primarily from OpenXT.
>=20
> Signed-off-by: Christopher Clark <christopher.w.clark@gmail.com>
> ---
> docs/designs/argo.pandoc | 45 ++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 45 insertions(+)
>=20
> diff --git a/docs/designs/argo.pandoc b/docs/designs/argo.pandoc
> index 2ce253b654..74c8ae4ac7 100644
> --- a/docs/designs/argo.pandoc
> +++ b/docs/designs/argo.pandoc
> @@ -439,6 +439,51 @@ that teardown of any domain will not interfere with =
any Argo hypercall
> operation. It enables introducing granular locking without complex or
> error-prone lock acquisition logic.
>=20
> +# Related Material
> +
> +## Enabling Argo in Xen
> +
> +To enable Argo in a build of the Xen hypervisor, please ensure that
> +CONFIG_ARGO is enabled in the Xen hypervisor build configuration file.
> +
> +To make Argo available for use at runtime on a Xen system, please see th=
e
> +Argo settings in the Xen command line document.

NIT: s/document/documentation/

Cheers
Bertrand

> +
> +## Linux Argo drivers
> +
> +A Linux kernel device driver for Argo and corresponding Linux userspace
> +software, libargo, that utilizes it for interdomain communication betwee=
n
> +application level software is available and maintained by the OpenXT Pro=
ject,
> +at:
> +
> +https://github.com/OpenXT/linux-xen-argo
> +
> +The repository contains the primary Linux kernel Argo driver, which is d=
erived
> +from the original XenClient v4v driver. The document at the following li=
nk
> +describes planning and design notes from OpenXT community discussion for
> +improvements to the driver:
> +
> +https://openxt.atlassian.net/wiki/spaces/DC/pages/775389197/New+Linux+Dr=
iver+for+Argo
> +
> +An alternative Linux Argo driver is in also available in the same reposi=
tory,
> +implemented to explore a different approach for Linux to use the Argo
> +primitives under the Vsock address family to allow socket communication =
between
> +Xen domains.
> +
> +## v4v drivers
> +
> +A Windows driver for v4v has previously been used in XenClient and OpenX=
T
> +which could be ported to Argo. It may require update for compatibility w=
ith
> +recent versions of Windows software.
> +
> +https://github.com/OpenXT/xc-windows/tree/master/xenv4v
> +
> +The Linux, Windows and OSX guest tools for the Open Source HP uxen hyper=
visor
> +contain drivers for v4v which are relevant as code bases of interest for
> +porting or developing new guest OS drivers for Argo.
> +
> +https://github.com/uxen-virt/uxen/tree/ascara/vm-support
> +
> # Future Work
>=20
> - Performance measurement and optimization
> --=20
> 2.25.1
>=20
>=20



From xen-devel-bounces@lists.xenproject.org Fri Oct 08 08:13:54 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Oct 2021 08:13:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.204499.359643 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYl0n-0006Aj-BX; Fri, 08 Oct 2021 08:13:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 204499.359643; Fri, 08 Oct 2021 08:13:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYl0n-0006Ac-85; Fri, 08 Oct 2021 08:13:49 +0000
Received: by outflank-mailman (input) for mailman id 204499;
 Fri, 08 Oct 2021 08:13:47 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=aYfl=O4=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mYl0l-0006AW-Pw
 for xen-devel@lists.xenproject.org; Fri, 08 Oct 2021 08:13:47 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id a824ca16-280f-11ec-8024-12813bfff9fa;
 Fri, 08 Oct 2021 08:13:46 +0000 (UTC)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2106.outbound.protection.outlook.com [104.47.17.106])
 (Using TLS) by relay.mimecast.com with ESMTP id
 de-mta-28-dpBFHXTtPAudUpyRV-Q30Q-1; Fri, 08 Oct 2021 10:13:43 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0401MB2333.eurprd04.prod.outlook.com (2603:10a6:800:28::24)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.22; Fri, 8 Oct
 2021 08:13:41 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4587.022; Fri, 8 Oct 2021
 08:13:41 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM5PR0202CA0011.eurprd02.prod.outlook.com (2603:10a6:203:69::21) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18 via Frontend
 Transport; Fri, 8 Oct 2021 08:13:40 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a824ca16-280f-11ec-8024-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1633680825;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=hqWELZeks3LgEfaO4qPvZ2j58FW9M+MeMqcPnZFGtx8=;
	b=Lu4vGo2vzL11BIwiRfIZVAx6tziExL5cSs1ElQP/DDLbpDN4LprxAGs7DAOP6IcifQYf/I
	w3XJrj2hS5c73MG967GtZx26QxOQDbd5/EwWOsUxGlZ57LPnAxgaxQZ3oYjXoCAIrwWSg9
	GyfJpyzEogCUSU9Kh2jpAXlzeif0l8o=
X-MC-Unique: dpBFHXTtPAudUpyRV-Q30Q-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=n0V5SYWDl72Rw44OHGDELfhqDBvXb9uo1br+l/K0WEXsOxlvmrCwupM4sq3fotWbXOs8IjOYlc2aIYb9BSis4tc4Rn87i9DRPs7uywBKCQkt1f+x1gXr21CvDRQYUotM9XX9kuNdVz2UQitNMrOoV7V+7aGLIG3hB8otl2vWWLQryskgrBbZMmoMx7QjB/JACl2FOuO6d49skIvbIt3XyEJXizDkAjwpk7Uvpvcp4bv21ndir74qWwj963N+usUG/0DFhJZBPGBXlSupf2zEvGJIZGIyS95IzaVk59GJ6fwDxISCDYHk5SuOtB8Fkg+yOUVuTaTzMwCNQDkK7eIZGQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=hqWELZeks3LgEfaO4qPvZ2j58FW9M+MeMqcPnZFGtx8=;
 b=JYX79DsDtL/eeOOw27PDfnwOj7nIle613lTQTxsW6cVImLoFyvrIwAFHnnMMxMW4k1J1i6pvC3ZRI60STujEeRKNRv5T6TTXK4xzSiW+u40pI2L10ieGbA0hak1R9EhllkqfyK9+RSgFk2QFCqCW6a4rddW/+H8gfMClLFXhMtz00Hqa8PEgFyMIzwjE7zSnZEFHbEhK9WOMN4bKL0ixbwdDxwGrKaYmGLUR/Rz+iiKWjkaZFJBxjhHsZFvJOwEkfDqjmJRvatUmM9rY+uQukWs4wal/ARrw3lkJu//dWla0crINW0vq7mLn03jps0PCgmIt2LUxwUqJXB6eiDiYjA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [PATCH V5 1/3] xen/arm: Introduce gpaddr_bits field to struct
 xen_arch_domainconfig
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: Oleksandr <olekstysh@gmail.com>,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>,
 Anthony PERARD <anthony.perard@citrix.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Juergen Gross <jgross@suse.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 xen-devel@lists.xenproject.org
References: <1633519346-3686-1-git-send-email-olekstysh@gmail.com>
 <1633519346-3686-2-git-send-email-olekstysh@gmail.com>
 <68cb29bb-7d84-dc27-eead-4a079b9caf68@suse.com>
 <e77eea6f-163d-0920-2e90-fb9f3a602743@gmail.com>
 <ffb40f3b-2394-7747-2c06-955e2aa87cfc@suse.com>
 <387608b9-c7b2-e814-7fa5-a262acc0c73d@gmail.com>
 <ae852345-66ff-7bcf-f68e-2161e23933a1@suse.com>
 <alpine.DEB.2.21.2110071311450.414@sstabellini-ThinkPad-T480s>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <b8e868a2-9af3-de6c-0683-4bb2ff7821f3@suse.com>
Date: Fri, 8 Oct 2021 10:13:38 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <alpine.DEB.2.21.2110071311450.414@sstabellini-ThinkPad-T480s>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM5PR0202CA0011.eurprd02.prod.outlook.com
 (2603:10a6:203:69::21) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: f8758e5e-e333-4e65-62b3-08d98a3389dd
X-MS-TrafficTypeDiagnostic: VI1PR0401MB2333:
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS:
	<VI1PR0401MB233347F829043D142B5EB156B3B29@VI1PR0401MB2333.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	r55kVbK9T3hJD3Sdv4cSkzQb5fL8CCnRDi+hYyzvSRqyyEYJF+JFu6jlQ+H3sbl4RpVcAVeX5RWgWIs49GP3eVTB2ktmP/icPtMS6iA07bxV35p28F/+Tu+eOLOCwmJ01/U9sOxvFRpMUjcmbaOX1iogzQvoa6h3wtKU8RjUSnG1hUo/Pd1Vx10ZTqXbbMHOVzAnRMsxqaembdvQZjO61hM0cnFOtes47kHSOaDuLsJQkicfbZHqFAGMN/nimuzfQSCobirIf73c+Jse+HYRrxZ0LUQ0QXLusked04RxHAfWkkRMmJuO6v5GaUyoJsCtr1ke4sp30E2zAHb6jLzRXup6wMgwgtwhGhHYMICZqRecTRKN5HmVezxtgm59Q8Y5r+mXt8hVG5Cc0Medvlr3WXM4luCpCJYFfuvOGBG/e1351wolGTD+2mNC1KwKNUstQtyR05QTMzlCIoPa9UkYsNoKLBoNG2KGBYq7hIeuIdP7kld7FNNw7dRPZuehU1ixphzFzJTpj4EKw1OjPM8W4yxbseEa9WyW78E773lsIU3E+bou3AOYcfCaUe/WceIjJz48jm2dPYXI3tdmLvQZYIm1IGSz4DJu+KhMEnLdcnGBJyw6GXUcr8AjlUkvAZMWYiv8rnLOs9DxB5Mtfr99/V/SHjc+GfBkcbMyofzKZPQJYBKdhq9fbl77gqOBtISlhpsJDtXqNAbGJLu2V8fTykNoSdE1o5NzPtkLoPzgcLLkIkDXxHTTWzm8Zg7TLAGr
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(186003)(6916009)(86362001)(508600001)(7416002)(36756003)(16576012)(316002)(8936002)(54906003)(6486002)(2616005)(26005)(2906002)(5660300002)(66946007)(4326008)(53546011)(66476007)(31686004)(8676002)(38100700002)(31696002)(66556008)(83380400001)(956004)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?bGs3VEZIeEZ5ajVxSU0wSlJQQ1UrdE1BcmJuTEdxMzBjWlhWRHZ2d3U2eGhD?=
 =?utf-8?B?TGJaVjRFTVJzck8rMWFjN3J5WWtiOW5qREhHQWtCUlgwVERkWWl6RmpvUUkv?=
 =?utf-8?B?cGIyYi90d0tkUGVHcGVUdlExd2piS1EyaVlaUzlIVzEvdlVONlpXR0JwWm04?=
 =?utf-8?B?Z0N3RFlleFppL0pTUDFaTUs1Q3pSS2hveVF3ZldPdGpZN3c0Ym1KQ0Q2R2ZK?=
 =?utf-8?B?UFdBbUdsUzc4RWJjU3ZSRHpqR0RsZW9nRmVRT0l2VTV3MEd0SVJzSWMwWFdy?=
 =?utf-8?B?OHJoS0dMRlpvTUFmalRlZitSTTIzSHd3NmQ2aTBXaHRCRE9QK2U3VzVHbzhZ?=
 =?utf-8?B?dDRJNTBVcmwvY1FaVmdRckFFL0VRdjJsMnVVdFZJdnJFUlJVdU5NMGhBU0FR?=
 =?utf-8?B?YmxpdHRHMXphQXFjeWlnUDdXc2w5ZVJPcmVCWFB5dFQ0blJTWUFHbmlMTUZE?=
 =?utf-8?B?L05CTVNscDZFSHJ0emdrOVJucmxwYnI2ZFEzVjBpajFKb1dCWWR4OUZCUGJJ?=
 =?utf-8?B?VTJFU0EzbGNCSmx2OFlSYTMvVTAxanVTMVFMSEs5MFFhckpBWHRBNVdJd3Fo?=
 =?utf-8?B?NlBieWNReDZLTVI4Szh4SzFqYU94SFVWeUhCbWg0ZUY0NzBKT2xpZjJHTlk0?=
 =?utf-8?B?dVBLM1lsWk9wZlBqeXJVSS93RnlzWW9YZ252V0VBNnNvT1U4cjFwdFNIbE1o?=
 =?utf-8?B?M0k2Yys5MDhGQ1BBbDM5d3hlOTFhVzIrL0ZPR21DY0JEN1hSVmtqNkZKZS82?=
 =?utf-8?B?ZFF6UWxBRThZdEpzY29yV2R0MTlTczFmb0FoUlFjUFc2QVF2dzZ3VGhUU1p2?=
 =?utf-8?B?OFhJR1BKYWlzZ1FqR2ViS2hnbGZnNGtjNG1sRmhmSjJnclpGRHAyMWhZbWky?=
 =?utf-8?B?TzdkV3dEcDhweDlKM0ZucEQzQ2o1V1RPZmZYdTJkekRic0NUWlh6L0kwaUtY?=
 =?utf-8?B?Sy9ZNE9UYXhaUi9MOU9HZVNJTkc1Q0RLVDlGRDdualVGaUh2Q2NTQ0J1MDRm?=
 =?utf-8?B?RzZUZ3N4NUtyOTFYbEN3YVc0UFozNjA3U0NSbnlscjYvM0pGcVRJZDJwb2VV?=
 =?utf-8?B?SnBoRlZwOU1PZnRQb1VEQUNXTHNUbHFKcjRhenRXaTNYMk5tcGR0Y1hSUDlD?=
 =?utf-8?B?TVBlaGZNaEdIbU5SdXQ0UkhBSHdkQnhmZU9CbWJyM0p4OVBmZEloQ0Y0emsx?=
 =?utf-8?B?OGFuK2ljSkxRWGN5VldGVktqZEpoUmp3UHVURkc4cHFWaG0zUnFjejN1Vkdz?=
 =?utf-8?B?T0ZBM2Q2NkFzNEtwUXk1ZWUzSHg2c0cxOEpJaThOTjlUWnI0UmV0UHpzWGpx?=
 =?utf-8?B?SGxDSDh4SmdhaXFDVjBneS9VVmlLcTRqZEgvNFpCVWRJZVlKU3dQTVR5S1Nq?=
 =?utf-8?B?TlRpTmVaUlRQY1pXN0NlcXpSUjFyNTh3eFE4alZ3Mk5kMG5yQlJyeVBlTXFp?=
 =?utf-8?B?MnNDa1BtWW4yRnF0Q3UwUnZTbGR1TUxOVGlsMTdJVmhwTmlXRk9IcDRlRVJz?=
 =?utf-8?B?T21XK0RDWEgyMGNML2NXLzFxOGpTMG4xZndORVZ3MithdnRJOWZBallsM3VQ?=
 =?utf-8?B?ZnNoeThPeFJpWXlsVTRoMFVyejhiYkdlK0VDY1BOK2NTcUtVcW5jNElUam4v?=
 =?utf-8?B?d3RzV2FUUWxER3NjS1dJbnMzMFVDdmt0WmROekJkZElLL3JpdmlFK1NPRHFV?=
 =?utf-8?B?MnliVkppSFRXSEVwZ0pxY3kxSFNvZUdVZUNyamljWDFlV0pJU3FZU2ZGUlo3?=
 =?utf-8?Q?DioIMaTeYyoE4bAwcgGHLJVPNFecwfWgJ50TpQ+?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f8758e5e-e333-4e65-62b3-08d98a3389dd
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Oct 2021 08:13:41.3286
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0irD3Vr79aSpX8AQOuGznV8iP8vFXc+6dYV2+AKLYgDKtELUhyghB04c1QDPfTQ8qIPtzHvhqwAgfhKKUzHbsg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2333

On 07.10.2021 22:23, Stefano Stabellini wrote:
> On Thu, 7 Oct 2021, Jan Beulich wrote:
>> On 07.10.2021 15:12, Oleksandr wrote:
>>>
>>> On 07.10.21 15:43, Jan Beulich wrote:
>>>
>>> Hi Jan.
>>>
>>>> On 07.10.2021 14:30, Oleksandr wrote:
>>>>> On 07.10.21 10:42, Jan Beulich wrote:
>>>>>> On 06.10.2021 13:22, Oleksandr Tyshchenko wrote:
>>>>>>> Changes V4 -> V5:
>>>>>>>      - update patch subject and description
>>>>>>>      - drop Michal's R-b
>>>>>>>      - pass gpaddr_bits via createdomain domctl
>>>>>>>        (struct xen_arch_domainconfig)
>>>>>> I'm afraid I can't bring this in line with ...
>>>>>>
>>>>>>> --- a/xen/include/public/arch-arm.h
>>>>>>> +++ b/xen/include/public/arch-arm.h
>>>>>>> @@ -333,6 +333,11 @@ struct xen_arch_domainconfig {
>>>>>>>         *
>>>>>>>         */
>>>>>>>        uint32_t clock_frequency;
>>>>>>> +    /*
>>>>>>> +     * OUT
>>>>>>> +     * Guest physical address space size
>>>>>>> +     */
>>>>>>> +    uint8_t gpaddr_bits;
>>>>>> ... this being an OUT field. Is this really what Andrew had asked for?
>>>>>> I would have expected the entire struct to be IN (and the comment at
>>>>>> the top of the containing struct in public/domctl.h also suggests so,
>>>>>> i.e. your new field renders that comment stale). gic_version being
>>>>>> IN/OUT is already somewhat in conflict ...
>>>>> I am sorry but I'm totally confused now, we want the Xen to provide
>>>>> gpaddr_bits to the toolstack, but not the other way around.
>>>>> As I understand the main ask was to switch to domctl for which I wanted
>>>>> to get some clarification on how it would look like... Well, this patch
>>>>> switches to use
>>>>> domctl, and I think exactly as it was suggested at [1] in case if a
>>>>> common one is a difficult to achieve. I have to admit, I felt it was
>>>>> indeed difficult to achieve.
>>>> Sadly the mail you reference isn't the one I was referring to. It's not
>>>> even from Andrew. Unfortunately I also can't seem to be able to locate
>>>> this, i.e. I'm now wondering whether this was under a different subject.
>>>> Julien, in any event, confirmed in a recent reply on this thread that
>>>> there was such a mail (otherwise I would have started wondering whether
>>>> the request was made on irc). In any case it is _that_ mail that would
>>>> need going through again.
>>>
>>> I think, this is the email [1] you are referring to.
>>
>> Well, that's still a mail you sent, not Andrew's. And while I have yours
>> in my mailbox, I don't have Andrew's for whatever reason.
>>
>> Nevertheless there's enough context to be halfway certain that this
>> wasn't meant as an extension to the create domctl, but rather a separate
>> new one (merely replacing what you had originally as a sysctl to become
>> per-domain, to allow returning varying [between domains] values down the
>> road). I continue to think that if such a field was added to "create",
>> it would be an input (only).
> 
> During the Xen Community Call on Tuesday, we briefly spoke about this.
> Andrew confirmed that what he meant with his original email is to use a
> domctl. We didn't discuss which domctl specifically.
> 
> This patch now follows the same pattern of clock_frequency and
> gic_version (see xen/include/public/arch-arm.h:struct xen_arch_domainconfig).
> Note that gic_version is an IN/OUT parameter, showing that if in the
> future we want the ability to set gpaddr_bits (in addition to get
> gpaddr_bits), it will be possible.

Well, as said before - I'm not convinced gic_version being IN/OUT is
appropriate. At the very least a 2nd way to merely retrieve the value
would seem to be necessary, so that it's not only the party creating
the guest which would be able to know.

Since here's we're solely after retrieving the value, I don't see
the point in altering "create". As you say, domctl can be changed,
and hence at the point this needs to become an input to "create", it
could easily be added there.

Jan



From xen-devel-bounces@lists.xenproject.org Fri Oct 08 08:19:57 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Oct 2021 08:19:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.204507.359654 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYl6e-0006t7-20; Fri, 08 Oct 2021 08:19:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 204507.359654; Fri, 08 Oct 2021 08:19:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYl6d-0006t0-Ug; Fri, 08 Oct 2021 08:19:51 +0000
Received: by outflank-mailman (input) for mailman id 204507;
 Fri, 08 Oct 2021 08:19:50 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HhL2=O4=arm.com=michal.orzel@srs-us1.protection.inumbo.net>)
 id 1mYl6c-0006su-O6
 for xen-devel@lists.xenproject.org; Fri, 08 Oct 2021 08:19:50 +0000
Received: from foss.arm.com (unknown [217.140.110.172])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTP
 id a3e88728-6dc4-417a-84de-b9cbf4dccaac;
 Fri, 08 Oct 2021 08:19:48 +0000 (UTC)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 582846D;
 Fri,  8 Oct 2021 01:19:48 -0700 (PDT)
Received: from e123311-lin.arm.com (unknown [10.57.24.215])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id AB6A43F70D;
 Fri,  8 Oct 2021 01:19:44 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a3e88728-6dc4-417a-84de-b9cbf4dccaac
From: Michal Orzel <michal.orzel@arm.com>
To: xen-devel@lists.xenproject.org
Cc: George Dunlap <george.dunlap@citrix.com>,
	Nick Rosbrook <rosbrookn@ainfosec.com>,
	Ian Jackson <iwj@xenproject.org>,
	Wei Liu <wl@xen.org>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Anthony PERARD <anthony.perard@citrix.com>,
	Juergen Gross <jgross@suse.com>,
	Christian Lindig <christian.lindig@citrix.com>,
	David Scott <dave@recoil.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: [PATCH v3 0/3] Expose PMU to the guests
Date: Fri,  8 Oct 2021 10:19:30 +0200
Message-Id: <20211008081933.18546-1-michal.orzel@arm.com>
X-Mailer: git-send-email 2.29.0
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

This patch series is a rework of an already pushed patch
exposing PMU to the guests. Since the second version the vpmu
parameter is common and prework in the form of reporting
availability of vPMU on the hardware is added.

The third version of the patch series removes the redundant check
from x86 code and modifies the way to define the flags XEN_DOMCTL_CDF and
XEN_SYSCTL_PHYSCAP, meaning not to define bit position and mask separately.

The current status is that the PMU registers are not virtualized
and the physical registers are directly accessible when "vpmu"
parameter is enabled in the guest config file. There is no interrupt
support and Xen will not save/restore the register values on context
switches. This is to be done in the future.

Michal Orzel (3):
  xen+tools: Introduce XEN_SYSCTL_PHYSCAP_vpmu
  xen/arm: Check for PMU platform support
  xen: Expose the PMU to the guests

 docs/man/xl.cfg.5.pod.in             | 17 ++++++++++
 tools/golang/xenlight/helpers.gen.go |  8 +++++
 tools/golang/xenlight/types.gen.go   |  2 ++
 tools/include/libxl.h                | 12 +++++++
 tools/libs/light/libxl.c             |  1 +
 tools/libs/light/libxl_create.c      |  4 +++
 tools/libs/light/libxl_types.idl     |  3 ++
 tools/ocaml/libs/xc/xenctrl.ml       |  2 ++
 tools/ocaml/libs/xc/xenctrl.mli      |  2 ++
 tools/xl/xl_info.c                   |  5 +--
 tools/xl/xl_parse.c                  |  2 ++
 xen/arch/arm/domain.c                | 10 ++++--
 xen/arch/arm/setup.c                 |  1 +
 xen/common/domain.c                  | 11 ++++++-
 xen/common/sysctl.c                  |  3 ++
 xen/include/asm-arm/cpufeature.h     | 49 ++++++++++++++++++++++++++--
 xen/include/asm-arm/domain.h         |  1 +
 xen/include/public/domctl.h          |  4 ++-
 xen/include/public/sysctl.h          |  6 ++--
 xen/include/xen/domain.h             |  2 ++
 20 files changed, 135 insertions(+), 10 deletions(-)

-- 
2.29.0



From xen-devel-bounces@lists.xenproject.org Fri Oct 08 08:19:57 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Oct 2021 08:19:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.204508.359665 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYl6i-0007Av-Cq; Fri, 08 Oct 2021 08:19:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 204508.359665; Fri, 08 Oct 2021 08:19:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYl6i-0007Ao-9n; Fri, 08 Oct 2021 08:19:56 +0000
Received: by outflank-mailman (input) for mailman id 204508;
 Fri, 08 Oct 2021 08:19:55 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HhL2=O4=arm.com=michal.orzel@srs-us1.protection.inumbo.net>)
 id 1mYl6h-0006su-Kt
 for xen-devel@lists.xenproject.org; Fri, 08 Oct 2021 08:19:55 +0000
Received: from foss.arm.com (unknown [217.140.110.172])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTP
 id 1ca1e0ce-e9ab-47e6-9dd7-6898e8a98a88;
 Fri, 08 Oct 2021 08:19:52 +0000 (UTC)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6CCB2ED1;
 Fri,  8 Oct 2021 01:19:52 -0700 (PDT)
Received: from e123311-lin.arm.com (unknown [10.57.24.215])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C06733F70D;
 Fri,  8 Oct 2021 01:19:48 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1ca1e0ce-e9ab-47e6-9dd7-6898e8a98a88
From: Michal Orzel <michal.orzel@arm.com>
To: xen-devel@lists.xenproject.org
Cc: George Dunlap <george.dunlap@citrix.com>,
	Nick Rosbrook <rosbrookn@ainfosec.com>,
	Ian Jackson <iwj@xenproject.org>,
	Wei Liu <wl@xen.org>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Anthony PERARD <anthony.perard@citrix.com>,
	Juergen Gross <jgross@suse.com>,
	Christian Lindig <christian.lindig@citrix.com>,
	David Scott <dave@recoil.org>
Subject: [PATCH v3 1/3] xen+tools: Introduce XEN_SYSCTL_PHYSCAP_vpmu
Date: Fri,  8 Oct 2021 10:19:31 +0200
Message-Id: <20211008081933.18546-2-michal.orzel@arm.com>
X-Mailer: git-send-email 2.29.0
In-Reply-To: <20211008081933.18546-1-michal.orzel@arm.com>
References: <20211008081933.18546-1-michal.orzel@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Introduce flag XEN_SYSCTL_PHYSCAP_vpmu which
indicates whether the platform supports vPMU
functionality. Modify Xen and tools accordingly.

Take the opportunity and fix XEN_SYSCTL_PHYSCAP_vmtrace
definition in sysctl.h which wrongly use (1<<6)
instead of (1u<<6).

Signed-off-by: Michal Orzel <michal.orzel@arm.com>
---
Changes since v2:
-do not define bit position and mask separately
Changes since v1:
-new in v2
---
 tools/golang/xenlight/helpers.gen.go | 2 ++
 tools/golang/xenlight/types.gen.go   | 1 +
 tools/include/libxl.h                | 6 ++++++
 tools/libs/light/libxl.c             | 1 +
 tools/libs/light/libxl_types.idl     | 1 +
 tools/ocaml/libs/xc/xenctrl.ml       | 1 +
 tools/ocaml/libs/xc/xenctrl.mli      | 1 +
 tools/xl/xl_info.c                   | 5 +++--
 xen/common/domain.c                  | 2 ++
 xen/common/sysctl.c                  | 3 +++
 xen/include/public/sysctl.h          | 6 ++++--
 xen/include/xen/domain.h             | 2 ++
 12 files changed, 27 insertions(+), 4 deletions(-)

diff --git a/tools/golang/xenlight/helpers.gen.go b/tools/golang/xenlight/helpers.gen.go
index bfc1e7f312..c8669837d8 100644
--- a/tools/golang/xenlight/helpers.gen.go
+++ b/tools/golang/xenlight/helpers.gen.go
@@ -3360,6 +3360,7 @@ x.CapHap = bool(xc.cap_hap)
 x.CapShadow = bool(xc.cap_shadow)
 x.CapIommuHapPtShare = bool(xc.cap_iommu_hap_pt_share)
 x.CapVmtrace = bool(xc.cap_vmtrace)
+x.CapVpmu = bool(xc.cap_vpmu)
 
  return nil}
 
@@ -3391,6 +3392,7 @@ xc.cap_hap = C.bool(x.CapHap)
 xc.cap_shadow = C.bool(x.CapShadow)
 xc.cap_iommu_hap_pt_share = C.bool(x.CapIommuHapPtShare)
 xc.cap_vmtrace = C.bool(x.CapVmtrace)
+xc.cap_vpmu = C.bool(x.CapVpmu)
 
  return nil
  }
diff --git a/tools/golang/xenlight/types.gen.go b/tools/golang/xenlight/types.gen.go
index 09a3bb67e2..45f2cba3d2 100644
--- a/tools/golang/xenlight/types.gen.go
+++ b/tools/golang/xenlight/types.gen.go
@@ -1008,6 +1008,7 @@ CapHap bool
 CapShadow bool
 CapIommuHapPtShare bool
 CapVmtrace bool
+CapVpmu bool
 }
 
 type Connectorinfo struct {
diff --git a/tools/include/libxl.h b/tools/include/libxl.h
index b9ba16d698..ec5e3badae 100644
--- a/tools/include/libxl.h
+++ b/tools/include/libxl.h
@@ -502,6 +502,12 @@
  */
 #define LIBXL_HAVE_X86_MSR_RELAXED 1
 
+/*
+ * LIBXL_HAVE_PHYSINFO_CAP_VPMU indicates that libxl_physinfo has a cap_vpmu
+ * field, which indicates the availability of vPMU functionality.
+ */
+#define LIBXL_HAVE_PHYSINFO_CAP_VPMU 1
+
 /*
  * libxl ABI compatibility
  *
diff --git a/tools/libs/light/libxl.c b/tools/libs/light/libxl.c
index 204eb0be2d..a032723fde 100644
--- a/tools/libs/light/libxl.c
+++ b/tools/libs/light/libxl.c
@@ -404,6 +404,7 @@ int libxl_get_physinfo(libxl_ctx *ctx, libxl_physinfo *physinfo)
         !!(xcphysinfo.capabilities & XEN_SYSCTL_PHYSCAP_iommu_hap_pt_share);
     physinfo->cap_vmtrace =
         !!(xcphysinfo.capabilities & XEN_SYSCTL_PHYSCAP_vmtrace);
+    physinfo->cap_vpmu = !!(xcphysinfo.capabilities & XEN_SYSCTL_PHYSCAP_vpmu);
 
     GC_FREE;
     return 0;
diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_types.idl
index 3f9fff653a..993e83acca 100644
--- a/tools/libs/light/libxl_types.idl
+++ b/tools/libs/light/libxl_types.idl
@@ -1061,6 +1061,7 @@ libxl_physinfo = Struct("physinfo", [
     ("cap_shadow", bool),
     ("cap_iommu_hap_pt_share", bool),
     ("cap_vmtrace", bool),
+    ("cap_vpmu", bool),
     ], dir=DIR_OUT)
 
 libxl_connectorinfo = Struct("connectorinfo", [
diff --git a/tools/ocaml/libs/xc/xenctrl.ml b/tools/ocaml/libs/xc/xenctrl.ml
index a5588c643f..6da3ed3c6f 100644
--- a/tools/ocaml/libs/xc/xenctrl.ml
+++ b/tools/ocaml/libs/xc/xenctrl.ml
@@ -121,6 +121,7 @@ type physinfo_cap_flag =
 	| CAP_Shadow
 	| CAP_IOMMU_HAP_PT_SHARE
 	| CAP_Vmtrace
+	| CAP_Vpmu
 
 type physinfo =
 {
diff --git a/tools/ocaml/libs/xc/xenctrl.mli b/tools/ocaml/libs/xc/xenctrl.mli
index 6e94940a8a..b8faff6721 100644
--- a/tools/ocaml/libs/xc/xenctrl.mli
+++ b/tools/ocaml/libs/xc/xenctrl.mli
@@ -106,6 +106,7 @@ type physinfo_cap_flag =
   | CAP_Shadow
   | CAP_IOMMU_HAP_PT_SHARE
   | CAP_Vmtrace
+  | CAP_Vpmu
 
 type physinfo = {
   threads_per_core : int;
diff --git a/tools/xl/xl_info.c b/tools/xl/xl_info.c
index 8383e4a6df..2c86b317b7 100644
--- a/tools/xl/xl_info.c
+++ b/tools/xl/xl_info.c
@@ -210,7 +210,7 @@ static void output_physinfo(void)
          info.hw_cap[4], info.hw_cap[5], info.hw_cap[6], info.hw_cap[7]
         );
 
-    maybe_printf("virt_caps              :%s%s%s%s%s%s%s%s\n",
+    maybe_printf("virt_caps              :%s%s%s%s%s%s%s%s%s\n",
          info.cap_pv ? " pv" : "",
          info.cap_hvm ? " hvm" : "",
          info.cap_hvm && info.cap_hvm_directio ? " hvm_directio" : "",
@@ -218,7 +218,8 @@ static void output_physinfo(void)
          info.cap_hap ? " hap" : "",
          info.cap_shadow ? " shadow" : "",
          info.cap_iommu_hap_pt_share ? " iommu_hap_pt_share" : "",
-         info.cap_vmtrace ? " vmtrace" : ""
+         info.cap_vmtrace ? " vmtrace" : "",
+         info.cap_vpmu ? " vpmu" : ""
         );
 
     vinfo = libxl_get_version_info(ctx);
diff --git a/xen/common/domain.c b/xen/common/domain.c
index 6ee5d033b0..4d0e909eec 100644
--- a/xen/common/domain.c
+++ b/xen/common/domain.c
@@ -84,6 +84,8 @@ vcpu_info_t dummy_vcpu_info;
 
 bool __read_mostly vmtrace_available;
 
+bool __read_mostly vpmu_is_available;
+
 static void __domain_finalise_shutdown(struct domain *d)
 {
     struct vcpu *v;
diff --git a/xen/common/sysctl.c b/xen/common/sysctl.c
index 3558641cd9..6e7189bb3c 100644
--- a/xen/common/sysctl.c
+++ b/xen/common/sysctl.c
@@ -280,6 +280,9 @@ long do_sysctl(XEN_GUEST_HANDLE_PARAM(xen_sysctl_t) u_sysctl)
         if ( vmtrace_available )
             pi->capabilities |= XEN_SYSCTL_PHYSCAP_vmtrace;
 
+        if ( vpmu_is_available )
+            pi->capabilities |= XEN_SYSCTL_PHYSCAP_vpmu;
+
         if ( copy_to_guest(u_sysctl, op, 1) )
             ret = -EFAULT;
     }
diff --git a/xen/include/public/sysctl.h b/xen/include/public/sysctl.h
index 039ccf885c..b794c9d351 100644
--- a/xen/include/public/sysctl.h
+++ b/xen/include/public/sysctl.h
@@ -100,10 +100,12 @@ struct xen_sysctl_tbuf_op {
 #define _XEN_SYSCTL_PHYSCAP_iommu_hap_pt_share 5
 #define XEN_SYSCTL_PHYSCAP_iommu_hap_pt_share  \
     (1u << _XEN_SYSCTL_PHYSCAP_iommu_hap_pt_share)
-#define XEN_SYSCTL_PHYSCAP_vmtrace       (1 << 6)
+#define XEN_SYSCTL_PHYSCAP_vmtrace       (1u<<6)
+/* The platform supports vPMU. */
+#define XEN_SYSCTL_PHYSCAP_vpmu          (1u<<7)
 
 /* Max XEN_SYSCTL_PHYSCAP_* constant.  Used for ABI checking. */
-#define XEN_SYSCTL_PHYSCAP_MAX XEN_SYSCTL_PHYSCAP_vmtrace
+#define XEN_SYSCTL_PHYSCAP_MAX XEN_SYSCTL_PHYSCAP_vpmu
 
 struct xen_sysctl_physinfo {
     uint32_t threads_per_core;
diff --git a/xen/include/xen/domain.h b/xen/include/xen/domain.h
index 1708c36964..160c8dbdab 100644
--- a/xen/include/xen/domain.h
+++ b/xen/include/xen/domain.h
@@ -133,4 +133,6 @@ static inline void vnuma_destroy(struct vnuma_info *vnuma) { ASSERT(!vnuma); }
 
 extern bool vmtrace_available;
 
+extern bool vpmu_is_available;
+
 #endif /* __XEN_DOMAIN_H__ */
-- 
2.29.0



From xen-devel-bounces@lists.xenproject.org Fri Oct 08 08:20:01 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Oct 2021 08:20:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.204509.359676 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYl6n-0007bJ-OB; Fri, 08 Oct 2021 08:20:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 204509.359676; Fri, 08 Oct 2021 08:20:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYl6n-0007aW-KM; Fri, 08 Oct 2021 08:20:01 +0000
Received: by outflank-mailman (input) for mailman id 204509;
 Fri, 08 Oct 2021 08:20:00 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HhL2=O4=arm.com=michal.orzel@srs-us1.protection.inumbo.net>)
 id 1mYl6m-0006su-LD
 for xen-devel@lists.xenproject.org; Fri, 08 Oct 2021 08:20:00 +0000
Received: from foss.arm.com (unknown [217.140.110.172])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTP
 id eb246d81-236a-4825-9a3f-e0cbb6e0f851;
 Fri, 08 Oct 2021 08:19:54 +0000 (UTC)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 472FC1063;
 Fri,  8 Oct 2021 01:19:54 -0700 (PDT)
Received: from e123311-lin.arm.com (unknown [10.57.24.215])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id DC5543F70D;
 Fri,  8 Oct 2021 01:19:52 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: eb246d81-236a-4825-9a3f-e0cbb6e0f851
From: Michal Orzel <michal.orzel@arm.com>
To: xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: [PATCH v3 2/3] xen/arm: Check for PMU platform support
Date: Fri,  8 Oct 2021 10:19:32 +0200
Message-Id: <20211008081933.18546-3-michal.orzel@arm.com>
X-Mailer: git-send-email 2.29.0
In-Reply-To: <20211008081933.18546-1-michal.orzel@arm.com>
References: <20211008081933.18546-1-michal.orzel@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

ID_AA64DFR0_EL1/ID_DFR0_EL1 registers provide
information about PMU support. Replace structure
dbg64/dbg32 with a union and fill in all the
register fields according to document:
ARM Architecture Registers(DDI 0595, 2021-06).

Add macros boot_dbg_feature64/boot_dbg_feature32
to check for a debug feature. Add macro
cpu_has_pmu to check for PMU support.

Signed-off-by: Michal Orzel <michal.orzel@arm.com>
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
---
Changes since v2:
-none
Changes since v1:
-new in v2
---
 xen/include/asm-arm/cpufeature.h | 49 ++++++++++++++++++++++++++++++--
 1 file changed, 47 insertions(+), 2 deletions(-)

diff --git a/xen/include/asm-arm/cpufeature.h b/xen/include/asm-arm/cpufeature.h
index 5ca09b0bff..4fce23844d 100644
--- a/xen/include/asm-arm/cpufeature.h
+++ b/xen/include/asm-arm/cpufeature.h
@@ -4,6 +4,7 @@
 #ifdef CONFIG_ARM_64
 #define cpu_feature64(c, feat)         ((c)->pfr64.feat)
 #define boot_cpu_feature64(feat)       (system_cpuinfo.pfr64.feat)
+#define boot_dbg_feature64(feat)       (system_cpuinfo.dbg64.feat)
 
 #define cpu_feature64_has_el0_32(c)    (cpu_feature64(c, el0) == 2)
 
@@ -22,6 +23,7 @@
 
 #define cpu_feature32(c, feat)         ((c)->pfr32.feat)
 #define boot_cpu_feature32(feat)       (system_cpuinfo.pfr32.feat)
+#define boot_dbg_feature32(feat)       (system_cpuinfo.dbg32.feat)
 
 #define cpu_has_arm       (boot_cpu_feature32(arm) == 1)
 #define cpu_has_thumb     (boot_cpu_feature32(thumb) >= 1)
@@ -32,8 +34,10 @@
 
 #ifdef CONFIG_ARM_32
 #define cpu_has_gentimer  (boot_cpu_feature32(gentimer) == 1)
+#define cpu_has_pmu       (boot_dbg_feature32(perfmon) >= 1)
 #else
 #define cpu_has_gentimer  (1)
+#define cpu_has_pmu       (boot_dbg_feature64(pmu_ver) >= 1)
 #endif
 #define cpu_has_security  (boot_cpu_feature32(security) > 0)
 
@@ -181,8 +185,28 @@ struct cpuinfo_arm {
         };
     } pfr64;
 
-    struct {
+    union {
         register_t bits[2];
+        struct {
+            /* DFR0 */
+            unsigned long debug_ver:4;
+            unsigned long trace_ver:4;
+            unsigned long pmu_ver:4;
+            unsigned long brps:4;
+            unsigned long __res0:4;
+            unsigned long wrps:4;
+            unsigned long __res1:4;
+            unsigned long ctx_cmps:4;
+            unsigned long pms_ver:4;
+            unsigned long double_lock:4;
+            unsigned long trace_filt:4;
+            unsigned long __res2:4;
+            unsigned long mtpmu:4;
+            unsigned long __res3:12;
+
+            /* DFR1 */
+            unsigned long __res4:64;
+        };
     } dbg64;
 
     struct {
@@ -321,8 +345,29 @@ struct cpuinfo_arm {
         };
     } pfr32;
 
-    struct {
+    union {
         register_t bits[2];
+        struct {
+            /* DFR0 */
+            unsigned long copdbg:4;
+            unsigned long copsdbg:4;
+            unsigned long mmapdbg:4;
+            unsigned long coptrc:4;
+            unsigned long mmaptrc:4;
+            unsigned long mprofdbg:4;
+            unsigned long perfmon:4;
+            unsigned long tracefilt:4;
+#ifdef CONFIG_ARM_64
+            unsigned long __res0:32;
+#endif
+
+            /* DFR1 */
+            unsigned long mtpmu:4;
+            unsigned long __res1:28;
+#ifdef CONFIG_ARM_64
+            unsigned long __res2:32;
+#endif
+        };
     } dbg32;
 
     struct {
-- 
2.29.0



From xen-devel-bounces@lists.xenproject.org Fri Oct 08 08:20:12 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Oct 2021 08:20:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.204511.359687 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYl6y-0000TM-31; Fri, 08 Oct 2021 08:20:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 204511.359687; Fri, 08 Oct 2021 08:20:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYl6x-0000T7-VT; Fri, 08 Oct 2021 08:20:11 +0000
Received: by outflank-mailman (input) for mailman id 204511;
 Fri, 08 Oct 2021 08:20:10 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HhL2=O4=arm.com=michal.orzel@srs-us1.protection.inumbo.net>)
 id 1mYl6w-0006su-LP
 for xen-devel@lists.xenproject.org; Fri, 08 Oct 2021 08:20:10 +0000
Received: from foss.arm.com (unknown [217.140.110.172])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTP
 id ef730332-fd00-4b2b-b64e-09455753b812;
 Fri, 08 Oct 2021 08:19:59 +0000 (UTC)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E8613ED1;
 Fri,  8 Oct 2021 01:19:58 -0700 (PDT)
Received: from e123311-lin.arm.com (unknown [10.57.24.215])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B91753F70D;
 Fri,  8 Oct 2021 01:19:54 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ef730332-fd00-4b2b-b64e-09455753b812
From: Michal Orzel <michal.orzel@arm.com>
To: xen-devel@lists.xenproject.org
Cc: Ian Jackson <iwj@xenproject.org>,
	Wei Liu <wl@xen.org>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Nick Rosbrook <rosbrookn@ainfosec.com>,
	Anthony PERARD <anthony.perard@citrix.com>,
	Juergen Gross <jgross@suse.com>,
	Christian Lindig <christian.lindig@citrix.com>,
	David Scott <dave@recoil.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: [PATCH v3 3/3] xen: Expose the PMU to the guests
Date: Fri,  8 Oct 2021 10:19:33 +0200
Message-Id: <20211008081933.18546-4-michal.orzel@arm.com>
X-Mailer: git-send-email 2.29.0
In-Reply-To: <20211008081933.18546-1-michal.orzel@arm.com>
References: <20211008081933.18546-1-michal.orzel@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Add parameter vpmu to xl domain configuration syntax
to enable the access to PMU registers by disabling
the PMU traps(currently only for ARM).

The current status is that the PMU registers are not
virtualized and the physical registers are directly
accessible when this parameter is enabled. There is no
interrupt support and Xen will not save/restore the
register values on context switches.

Please note that this feature is experimental.

Signed-off-by: Michal Orzel <michal.orzel@arm.com>
Signed-off-by: Julien Grall <julien@xen.org>
---
Changes since v2:
-remove redundant check from x86 code
-do not define bit position and mask separately
Changes since v1:
-modify vpmu parameter to be common rather than arch specific
---
 docs/man/xl.cfg.5.pod.in             | 17 +++++++++++++++++
 tools/golang/xenlight/helpers.gen.go |  6 ++++++
 tools/golang/xenlight/types.gen.go   |  1 +
 tools/include/libxl.h                |  6 ++++++
 tools/libs/light/libxl_create.c      |  4 ++++
 tools/libs/light/libxl_types.idl     |  2 ++
 tools/ocaml/libs/xc/xenctrl.ml       |  1 +
 tools/ocaml/libs/xc/xenctrl.mli      |  1 +
 tools/xl/xl_parse.c                  |  2 ++
 xen/arch/arm/domain.c                | 10 ++++++++--
 xen/arch/arm/setup.c                 |  1 +
 xen/common/domain.c                  |  9 ++++++++-
 xen/include/asm-arm/domain.h         |  1 +
 xen/include/public/domctl.h          |  4 +++-
 14 files changed, 61 insertions(+), 4 deletions(-)

diff --git a/docs/man/xl.cfg.5.pod.in b/docs/man/xl.cfg.5.pod.in
index 4b1e3028d2..55c4881205 100644
--- a/docs/man/xl.cfg.5.pod.in
+++ b/docs/man/xl.cfg.5.pod.in
@@ -690,6 +690,23 @@ default.
 B<NOTE>: Acceptable values are platform specific.  For Intel Processor
 Trace, this value must be a power of 2 between 4k and 16M.
 
+=item B<vpmu=BOOLEAN>
+
+Currently ARM only.
+
+Specifies whether to enable the access to PMU registers by disabling
+the PMU traps.
+
+The PMU registers are not virtualized and the physical registers are directly
+accessible when this parameter is enabled. There is no interrupt support and
+Xen will not save/restore the register values on context switches.
+
+vPMU, by design and purpose, exposes system level performance
+information to the guest. Only to be used by sufficiently privileged
+domains. This feature is currently in experimental state.
+
+If this option is not specified then it will default to B<false>.
+
 =back
 
 =head2 Devices
diff --git a/tools/golang/xenlight/helpers.gen.go b/tools/golang/xenlight/helpers.gen.go
index c8669837d8..2449580bad 100644
--- a/tools/golang/xenlight/helpers.gen.go
+++ b/tools/golang/xenlight/helpers.gen.go
@@ -1119,6 +1119,9 @@ return fmt.Errorf("converting field ArchX86.MsrRelaxed: %v", err)
 }
 x.Altp2M = Altp2MMode(xc.altp2m)
 x.VmtraceBufKb = int(xc.vmtrace_buf_kb)
+if err := x.Vpmu.fromC(&xc.vpmu);err != nil {
+return fmt.Errorf("converting field Vpmu: %v", err)
+}
 
  return nil}
 
@@ -1600,6 +1603,9 @@ return fmt.Errorf("converting field ArchX86.MsrRelaxed: %v", err)
 }
 xc.altp2m = C.libxl_altp2m_mode(x.Altp2M)
 xc.vmtrace_buf_kb = C.int(x.VmtraceBufKb)
+if err := x.Vpmu.toC(&xc.vpmu); err != nil {
+return fmt.Errorf("converting field Vpmu: %v", err)
+}
 
  return nil
  }
diff --git a/tools/golang/xenlight/types.gen.go b/tools/golang/xenlight/types.gen.go
index 45f2cba3d2..b2e8bd1a85 100644
--- a/tools/golang/xenlight/types.gen.go
+++ b/tools/golang/xenlight/types.gen.go
@@ -521,6 +521,7 @@ MsrRelaxed Defbool
 }
 Altp2M Altp2MMode
 VmtraceBufKb int
+Vpmu Defbool
 }
 
 type DomainBuildInfoTypeUnion interface {
diff --git a/tools/include/libxl.h b/tools/include/libxl.h
index ec5e3badae..ee73eb06f1 100644
--- a/tools/include/libxl.h
+++ b/tools/include/libxl.h
@@ -508,6 +508,12 @@
  */
 #define LIBXL_HAVE_PHYSINFO_CAP_VPMU 1
 
+/*
+ * LIBXL_HAVE_VPMU indicates that libxl_domain_build_info has a vpmu parameter,
+ * which allows to enable the access to PMU registers.
+ */
+#define LIBXL_HAVE_VPMU 1
+
 /*
  * libxl ABI compatibility
  *
diff --git a/tools/libs/light/libxl_create.c b/tools/libs/light/libxl_create.c
index e356b2106d..d123c2f703 100644
--- a/tools/libs/light/libxl_create.c
+++ b/tools/libs/light/libxl_create.c
@@ -91,6 +91,7 @@ int libxl__domain_build_info_setdefault(libxl__gc *gc,
     }
 
     libxl_defbool_setdefault(&b_info->device_model_stubdomain, false);
+    libxl_defbool_setdefault(&b_info->vpmu, false);
 
     if (libxl_defbool_val(b_info->device_model_stubdomain) &&
         !b_info->device_model_ssidref)
@@ -622,6 +623,9 @@ int libxl__domain_make(libxl__gc *gc, libxl_domain_config *d_config,
                 create.flags |= XEN_DOMCTL_CDF_nested_virt;
         }
 
+        if ( libxl_defbool_val(b_info->vpmu) )
+            create.flags |= XEN_DOMCTL_CDF_vpmu;
+
         assert(info->passthrough != LIBXL_PASSTHROUGH_DEFAULT);
         LOG(DETAIL, "passthrough: %s",
             libxl_passthrough_to_string(info->passthrough));
diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_types.idl
index 993e83acca..b96fb5c47e 100644
--- a/tools/libs/light/libxl_types.idl
+++ b/tools/libs/light/libxl_types.idl
@@ -655,6 +655,8 @@ libxl_domain_build_info = Struct("domain_build_info",[
     # Use zero value to disable this feature.
     ("vmtrace_buf_kb", integer),
 
+    ("vpmu", libxl_defbool),
+
     ], dir=DIR_IN,
        copy_deprecated_fn="libxl__domain_build_info_copy_deprecated",
 )
diff --git a/tools/ocaml/libs/xc/xenctrl.ml b/tools/ocaml/libs/xc/xenctrl.ml
index 6da3ed3c6f..addcf4cc59 100644
--- a/tools/ocaml/libs/xc/xenctrl.ml
+++ b/tools/ocaml/libs/xc/xenctrl.ml
@@ -69,6 +69,7 @@ type domain_create_flag =
 	| CDF_XS_DOMAIN
 	| CDF_IOMMU
 	| CDF_NESTED_VIRT
+	| CDF_VPMU
 
 type domain_create_iommu_opts =
 	| IOMMU_NO_SHAREPT
diff --git a/tools/ocaml/libs/xc/xenctrl.mli b/tools/ocaml/libs/xc/xenctrl.mli
index b8faff6721..0a5ce529e9 100644
--- a/tools/ocaml/libs/xc/xenctrl.mli
+++ b/tools/ocaml/libs/xc/xenctrl.mli
@@ -62,6 +62,7 @@ type domain_create_flag =
   | CDF_XS_DOMAIN
   | CDF_IOMMU
   | CDF_NESTED_VIRT
+  | CDF_VPMU
 
 type domain_create_iommu_opts =
   | IOMMU_NO_SHAREPT
diff --git a/tools/xl/xl_parse.c b/tools/xl/xl_parse.c
index 17dddb4cd5..c503b9be00 100644
--- a/tools/xl/xl_parse.c
+++ b/tools/xl/xl_parse.c
@@ -2750,6 +2750,8 @@ skip_usbdev:
                     "If it fixes an issue you are having please report to "
                     "xen-devel@lists.xenproject.org.\n");
 
+    xlu_cfg_get_defbool(config, "vpmu", &b_info->vpmu, 0);
+
     xlu_cfg_destroy(config);
 }
 
diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
index 19c756ac3d..2dd474da09 100644
--- a/xen/arch/arm/domain.c
+++ b/xen/arch/arm/domain.c
@@ -276,6 +276,8 @@ static void ctxt_switch_to(struct vcpu *n)
      * timer. The interrupt needs to be injected into the guest. */
     WRITE_SYSREG(n->arch.cntkctl, CNTKCTL_EL1);
     virt_timer_restore(n);
+
+    WRITE_SYSREG(n->arch.mdcr_el2, MDCR_EL2);
 }
 
 /* Update per-VCPU guest runstate shared memory area (if registered). */
@@ -586,6 +588,10 @@ int arch_vcpu_create(struct vcpu *v)
 
     v->arch.hcr_el2 = get_default_hcr_flags();
 
+    v->arch.mdcr_el2 = HDCR_TDRA | HDCR_TDOSA | HDCR_TDA;
+    if ( !(v->domain->options & XEN_DOMCTL_CDF_vpmu) )
+        v->arch.mdcr_el2 |= HDCR_TPM | HDCR_TPMCR;
+
     if ( (rc = vcpu_vgic_init(v)) != 0 )
         goto fail;
 
@@ -622,8 +628,8 @@ int arch_sanitise_domain_config(struct xen_domctl_createdomain *config)
 {
     unsigned int max_vcpus;
 
-    /* HVM and HAP must be set. IOMMU may or may not be */
-    if ( (config->flags & ~XEN_DOMCTL_CDF_iommu) !=
+    /* HVM and HAP must be set. IOMMU and PMU may or may not be */
+    if ( (config->flags & ~(XEN_DOMCTL_CDF_iommu | XEN_DOMCTL_CDF_vpmu)) !=
          (XEN_DOMCTL_CDF_hvm | XEN_DOMCTL_CDF_hap) )
     {
         dprintk(XENLOG_INFO, "Unsupported configuration %#x\n",
diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c
index 49dc90d198..85386a765a 100644
--- a/xen/arch/arm/setup.c
+++ b/xen/arch/arm/setup.c
@@ -108,6 +108,7 @@ static void __init processor_id(void)
 
     identify_cpu(c);
     current_cpu_data = *c;
+    vpmu_is_available = cpu_has_pmu;
 
     if ( c->midr.implementer < ARRAY_SIZE(processor_implementers) &&
          processor_implementers[c->midr.implementer] )
diff --git a/xen/common/domain.c b/xen/common/domain.c
index 4d0e909eec..8b53c49d1e 100644
--- a/xen/common/domain.c
+++ b/xen/common/domain.c
@@ -480,12 +480,13 @@ static int sanitise_domain_config(struct xen_domctl_createdomain *config)
     bool hvm = config->flags & XEN_DOMCTL_CDF_hvm;
     bool hap = config->flags & XEN_DOMCTL_CDF_hap;
     bool iommu = config->flags & XEN_DOMCTL_CDF_iommu;
+    bool vpmu = config->flags & XEN_DOMCTL_CDF_vpmu;
 
     if ( config->flags &
          ~(XEN_DOMCTL_CDF_hvm | XEN_DOMCTL_CDF_hap |
            XEN_DOMCTL_CDF_s3_integrity | XEN_DOMCTL_CDF_oos_off |
            XEN_DOMCTL_CDF_xs_domain | XEN_DOMCTL_CDF_iommu |
-           XEN_DOMCTL_CDF_nested_virt) )
+           XEN_DOMCTL_CDF_nested_virt | XEN_DOMCTL_CDF_vpmu) )
     {
         dprintk(XENLOG_INFO, "Unknown CDF flags %#x\n", config->flags);
         return -EINVAL;
@@ -534,6 +535,12 @@ static int sanitise_domain_config(struct xen_domctl_createdomain *config)
         return -EINVAL;
     }
 
+    if ( vpmu && !vpmu_is_available )
+    {
+        dprintk(XENLOG_INFO, "vpmu requested but cannot be enabled this way\n");
+        return -EINVAL;
+    }
+
     return arch_sanitise_domain_config(config);
 }
 
diff --git a/xen/include/asm-arm/domain.h b/xen/include/asm-arm/domain.h
index c9277b5c6d..14e575288f 100644
--- a/xen/include/asm-arm/domain.h
+++ b/xen/include/asm-arm/domain.h
@@ -166,6 +166,7 @@ struct arch_vcpu
 
     /* HYP configuration */
     register_t hcr_el2;
+    register_t mdcr_el2;
 
     uint32_t teecr, teehbr; /* ThumbEE, 32-bit guests only */
 #ifdef CONFIG_ARM_32
diff --git a/xen/include/public/domctl.h b/xen/include/public/domctl.h
index 96696e3842..238384b5ae 100644
--- a/xen/include/public/domctl.h
+++ b/xen/include/public/domctl.h
@@ -70,9 +70,11 @@ struct xen_domctl_createdomain {
 #define XEN_DOMCTL_CDF_iommu          (1U<<_XEN_DOMCTL_CDF_iommu)
 #define _XEN_DOMCTL_CDF_nested_virt   6
 #define XEN_DOMCTL_CDF_nested_virt    (1U << _XEN_DOMCTL_CDF_nested_virt)
+/* Should we expose the vPMU to the guest? */
+#define XEN_DOMCTL_CDF_vpmu           (1U << 7)
 
 /* Max XEN_DOMCTL_CDF_* constant.  Used for ABI checking. */
-#define XEN_DOMCTL_CDF_MAX XEN_DOMCTL_CDF_nested_virt
+#define XEN_DOMCTL_CDF_MAX XEN_DOMCTL_CDF_vpmu
 
     uint32_t flags;
 
-- 
2.29.0



From xen-devel-bounces@lists.xenproject.org Fri Oct 08 08:32:01 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Oct 2021 08:32:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.204545.359698 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYlID-0002Yr-47; Fri, 08 Oct 2021 08:31:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 204545.359698; Fri, 08 Oct 2021 08:31:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYlID-0002Yk-0C; Fri, 08 Oct 2021 08:31:49 +0000
Received: by outflank-mailman (input) for mailman id 204545;
 Fri, 08 Oct 2021 08:31:47 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=/CyP=O4=arm.com=Bertrand.Marquis@srs-us1.protection.inumbo.net>)
 id 1mYlIB-0002Ye-C1
 for xen-devel@lists.xenproject.org; Fri, 08 Oct 2021 08:31:47 +0000
Received: from EUR01-DB5-obe.outbound.protection.outlook.com (unknown
 [2a01:111:f400:fe02::62f])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id e1777f4f-c01d-47d1-89b2-a5a67113e706;
 Fri, 08 Oct 2021 08:31:45 +0000 (UTC)
Received: from AM5PR0602CA0002.eurprd06.prod.outlook.com
 (2603:10a6:203:a3::12) by PAXPR08MB6863.eurprd08.prod.outlook.com
 (2603:10a6:102:134::9) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.20; Fri, 8 Oct
 2021 08:31:43 +0000
Received: from AM5EUR03FT029.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:203:a3:cafe::d) by AM5PR0602CA0002.outlook.office365.com
 (2603:10a6:203:a3::12) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.21 via Frontend
 Transport; Fri, 8 Oct 2021 08:31:43 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM5EUR03FT029.mail.protection.outlook.com (10.152.16.150) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4587.18 via Frontend Transport; Fri, 8 Oct 2021 08:31:42 +0000
Received: ("Tessian outbound 16951d3c485e:v103");
 Fri, 08 Oct 2021 08:31:42 +0000
Received: from 36151b71aa15.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 0828CDED-3011-41AC-AFCA-72CCE53ED90F.1; 
 Fri, 08 Oct 2021 08:31:32 +0000
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 36151b71aa15.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 08 Oct 2021 08:31:32 +0000
Received: from AM5PR0801MB2019.eurprd08.prod.outlook.com
 (2603:10a6:203:4b::22) by AM6PR08MB3271.eurprd08.prod.outlook.com
 (2603:10a6:209:47::24) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18; Fri, 8 Oct
 2021 08:31:27 +0000
Received: from AM5PR0801MB2019.eurprd08.prod.outlook.com
 ([fe80::80a2:ff50:fde5:5215]) by AM5PR0801MB2019.eurprd08.prod.outlook.com
 ([fe80::80a2:ff50:fde5:5215%3]) with mapi id 15.20.4587.020; Fri, 8 Oct 2021
 08:31:27 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e1777f4f-c01d-47d1-89b2-a5a67113e706
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=PJGRQYFxVNhZI6sPgYj+GIwVGfedcWSu1Iu0VKlioNM=;
 b=s9B6+JVcJgNgLq/l8WEw2/nCCR2jl1dlMtGyAb6UhscJTbyyAtnp7PPbWAkrYFPG3j80nBkg3RfYIPu9xj/Hwa+DWJCFolxeqSfrm0OGt7qxCeJt6N5QhMKEUh7OPhwOawtJF+DvIAsYCsvwN/w/ukbh/TcPxt/reFFa+mNb6Jk=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 436b9ea060441231
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=W43bGnxY3hn0ANyunZz580wDgCrGvLtU7yd4ltJGZSrw5bpmooqdhUjVVnynVfu4c9nonSwDktPT9jkk0qqM5A1PBFBnXT1Sp2KxX6E7+bmGqW+fJC8YfCFTBxrX8Gu3uk4RMLZhCEjPCmkRPUFIaQeLLfHNQ5X4gnlOmddRb0iSJyaWBvtH8LMEVBY1jpC4opy/xfYgA2k9z+qOva7wAA8N8HQtO24l7CuKkDnbZQ0Cdko+uU6GTzlBTPovUPPbXnkIYSDJGaHBe0emXuFQfSNZyeLzVc27y5R0jsqKj7tHozF3tx+W6Yp7rM7zXDyG59gDofSx4Hgg21gQ3yrJgw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=PJGRQYFxVNhZI6sPgYj+GIwVGfedcWSu1Iu0VKlioNM=;
 b=VXhR/3h10F80WBTgqZs5yHTKL+/5pnjkDW8O3gpudLUrYEs3aG1CizzEHdPPsiEsldfZ9CAkMGTWZ7EFIOsAXMCDQkGxMM4BdJvIu+iNqJ62yX6zFIb5c4rMF3Q1IziFyLvciBw1t2VYqx3vPZLFPihSHEVV2LMSQGh7GhXkWNUecNWfSb+Rk48nVa3c/iq+Xqnnm3evSCnX6wUoeNZqyazS4xe8ma2dabUdDccUuO2fo0bTbVypiUIQygVeyAThPyWhA0y3yZFX4+jKpvD+7PHEShWOqUKy9EMOrBPg+bH91ksCGfPA6kziBS2hqdfwilDNVEv7is3Z5zjCyJn0vw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=PJGRQYFxVNhZI6sPgYj+GIwVGfedcWSu1Iu0VKlioNM=;
 b=s9B6+JVcJgNgLq/l8WEw2/nCCR2jl1dlMtGyAb6UhscJTbyyAtnp7PPbWAkrYFPG3j80nBkg3RfYIPu9xj/Hwa+DWJCFolxeqSfrm0OGt7qxCeJt6N5QhMKEUh7OPhwOawtJF+DvIAsYCsvwN/w/ukbh/TcPxt/reFFa+mNb6Jk=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Michal Orzel <Michal.Orzel@arm.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>, George Dunlap
	<george.dunlap@citrix.com>, Nick Rosbrook <rosbrookn@ainfosec.com>, Ian
 Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>, Andrew Cooper
	<andrew.cooper3@citrix.com>, Jan Beulich <jbeulich@suse.com>, Julien Grall
	<julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>, Anthony PERARD
	<anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>, Christian
 Lindig <christian.lindig@citrix.com>, David Scott <dave@recoil.org>
Subject: Re: [PATCH v3 1/3] xen+tools: Introduce XEN_SYSCTL_PHYSCAP_vpmu
Thread-Topic: [PATCH v3 1/3] xen+tools: Introduce XEN_SYSCTL_PHYSCAP_vpmu
Thread-Index: AQHXvB1PoezuefnKkUm8ItiBScrwd6vIxYqA
Date: Fri, 8 Oct 2021 08:31:27 +0000
Message-ID: <1230C29B-62DE-430D-BB50-3AC9A8BF9D93@arm.com>
References: <20211008081933.18546-1-michal.orzel@arm.com>
 <20211008081933.18546-2-michal.orzel@arm.com>
In-Reply-To: <20211008081933.18546-2-michal.orzel@arm.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3654.120.0.1.13)
Authentication-Results-Original: arm.com; dkim=none (message not signed)
 header.d=none;arm.com; dmarc=none action=none header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: e5eeff79-8224-472a-e95d-08d98a360e97
x-ms-traffictypediagnostic: AM6PR08MB3271:|PAXPR08MB6863:
x-ms-exchange-transport-forked: True
X-Microsoft-Antispam-PRVS:
	<PAXPR08MB68634200B9B8B698617C14719DB29@PAXPR08MB6863.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:204;OLM:204;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 PZun7ZbGYWhS4+Gtu3ab6PQaKFvDkbqnsDOQp9jkNlEeiEXpMRBbIBnHF6/dlQKwnOgtstQ5RhqwyMc0s3efxfQHllwz1RuSJeh8+dDPLglAthigTGSyPYtR48BLkohoGjWmaEWqwqV1zyjuaY43juEeCHciL+biie1aulgfnR20gzT7LiMqzR2OKZsTsL+JTo9NUenlZ/jAn9L4J/s8c5BaiLwv6L4sdYfk2B4aX7DOlbITgPve3A9gD4xiL8hUwh0BYLvhuqKJOy0OFeCbJwqYV544ArCUlUP52nwVPoaFFebjHOvcYj3/PewndU0uf5S5rHEdjoIIvn0hUyqWhuwEHSTNZKZs9RNtNYXRMic1KJDttBvn5flCAoqJzUdzv0BvMtHDbou5UCk7o0+sapRSDAjTEvK1dwnt3+WPCJOlW7jhsQzCVkPbajMfT5fWSHn0W90tKdalTnfFiX/ZlrB5DO1SASAhF9r2267PyKRTSXsQSk9vpAnRvuBvNMTEN10ognH4jSlWrkFtVq0BElsY/x6JyltKHDvBZGgnevQa9fM4bXvJTOKEkb1D2E+Jqi4ZJ3kEIm0E1ByMAVNX5uIfNrT5LD3aiD8ST2pxtHQCuGvACmMN17uNZxf4+wb7Dm5Y0HvtN/Jk9fl5CEJ1EknIn7pvYKr8aDA1eYjwTNaONPuqmHpbUsgYW5cLjdUHTTquM8L2bRkLYyHTozp4TRuPrADflWZ9fCaEBebq2rNhisqsKjFnivN3qKxAwULq
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM5PR0801MB2019.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(86362001)(54906003)(26005)(53546011)(6506007)(7416002)(33656002)(2616005)(83380400001)(66556008)(6486002)(91956017)(66446008)(66476007)(64756008)(76116006)(6862004)(508600001)(66946007)(8936002)(2906002)(37006003)(6636002)(6512007)(5660300002)(38070700005)(186003)(71200400001)(38100700002)(122000001)(4326008)(36756003)(316002)(8676002)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="us-ascii"
Content-ID: <6C23D492A3007041A492090A3869FA97@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3271
Original-Authentication-Results: arm.com; dkim=none (message not signed)
 header.d=none;arm.com; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM5EUR03FT029.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	4bcc05af-b364-4f48-6019-08d98a360583
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	3xGTIw8xReed1tWR26W3VFmZ6LfEz3wtUK026pX428616cmFqO1YDn+vlb/quHvL0mIeZm85Q1+S3UgIbOxwBEAF5ta+r1NkLsyza9iJ9TrJILi8exRzkfdduAtj/wgGihntHXBmszA2mZ6tg6d2/yyfCzkpsX51UVBL9BYjNSg+Wuc5E/5so/Z7XGuIVkDEqBY3QGl+spChWXTjaBFjn5X+UvMFP2vqwibMN6r3rRa9WcoxAoMaWbe0ZmZSxhrdpwRoyPTu4M9+qfmXn/xGw/oTLncolfPSTSbv7byXt6uht2JiU+KHmzTAEELwN4ZXk7iOwcojjsXZNdiDaC/ejkDqOlAEAcpkHACM3QM5qvwHXeJ3HgPR0UeZiBpOUkdSTWV5HCbXAnVfc1zN0uH+U3S56xjaAJeRmDpBA1/zA7j06E3jM/ix/MDAjxt842tgYH0lcez6kQHi5HnWFZLmFWbcSPOb1ppopM1NiKUjwnvu3QxZRzguLM5t6SkEVUEjPOZQ1TNhCHvQH1g4mbsRdncl+xTzM7q+U94g2BPlnxUzhSeFuhqIGVFMVRboj6qXequbgwXYdkba9ULH+VDX6cjWsuI8+jYHnX/B6GAxqi8/n3sbZOtpuHNs6VNI2WwNvShRVF2efENsgroYxdhsqfYT6XFLMJprgYfYSi3/WOQ+Uk+8Dew5cmnCing7j4zVWdaqPsoTCHNDbijBtv3Yig==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(83380400001)(336012)(2616005)(6506007)(36860700001)(54906003)(36756003)(82310400003)(47076005)(6512007)(53546011)(33656002)(6636002)(8676002)(5660300002)(2906002)(4326008)(508600001)(6862004)(70586007)(81166007)(37006003)(86362001)(8936002)(316002)(70206006)(26005)(356005)(107886003)(6486002)(186003);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Oct 2021 08:31:42.6575
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: e5eeff79-8224-472a-e95d-08d98a360e97
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM5EUR03FT029.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6863

Hi Michal

> On 8 Oct 2021, at 09:19, Michal Orzel <Michal.Orzel@arm.com> wrote:
>=20
> Introduce flag XEN_SYSCTL_PHYSCAP_vpmu which
> indicates whether the platform supports vPMU
> functionality. Modify Xen and tools accordingly.
>=20
> Take the opportunity and fix XEN_SYSCTL_PHYSCAP_vmtrace
> definition in sysctl.h which wrongly use (1<<6)
> instead of (1u<<6).
>=20
> Signed-off-by: Michal Orzel <michal.orzel@arm.com>
Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>

Cheers
Bertrand

> ---
> Changes since v2:
> -do not define bit position and mask separately
> Changes since v1:
> -new in v2
> ---
> tools/golang/xenlight/helpers.gen.go | 2 ++
> tools/golang/xenlight/types.gen.go   | 1 +
> tools/include/libxl.h                | 6 ++++++
> tools/libs/light/libxl.c             | 1 +
> tools/libs/light/libxl_types.idl     | 1 +
> tools/ocaml/libs/xc/xenctrl.ml       | 1 +
> tools/ocaml/libs/xc/xenctrl.mli      | 1 +
> tools/xl/xl_info.c                   | 5 +++--
> xen/common/domain.c                  | 2 ++
> xen/common/sysctl.c                  | 3 +++
> xen/include/public/sysctl.h          | 6 ++++--
> xen/include/xen/domain.h             | 2 ++
> 12 files changed, 27 insertions(+), 4 deletions(-)
>=20
> diff --git a/tools/golang/xenlight/helpers.gen.go b/tools/golang/xenlight=
/helpers.gen.go
> index bfc1e7f312..c8669837d8 100644
> --- a/tools/golang/xenlight/helpers.gen.go
> +++ b/tools/golang/xenlight/helpers.gen.go
> @@ -3360,6 +3360,7 @@ x.CapHap =3D bool(xc.cap_hap)
> x.CapShadow =3D bool(xc.cap_shadow)
> x.CapIommuHapPtShare =3D bool(xc.cap_iommu_hap_pt_share)
> x.CapVmtrace =3D bool(xc.cap_vmtrace)
> +x.CapVpmu =3D bool(xc.cap_vpmu)
>=20
>  return nil}
>=20
> @@ -3391,6 +3392,7 @@ xc.cap_hap =3D C.bool(x.CapHap)
> xc.cap_shadow =3D C.bool(x.CapShadow)
> xc.cap_iommu_hap_pt_share =3D C.bool(x.CapIommuHapPtShare)
> xc.cap_vmtrace =3D C.bool(x.CapVmtrace)
> +xc.cap_vpmu =3D C.bool(x.CapVpmu)
>=20
>  return nil
>  }
> diff --git a/tools/golang/xenlight/types.gen.go b/tools/golang/xenlight/t=
ypes.gen.go
> index 09a3bb67e2..45f2cba3d2 100644
> --- a/tools/golang/xenlight/types.gen.go
> +++ b/tools/golang/xenlight/types.gen.go
> @@ -1008,6 +1008,7 @@ CapHap bool
> CapShadow bool
> CapIommuHapPtShare bool
> CapVmtrace bool
> +CapVpmu bool
> }
>=20
> type Connectorinfo struct {
> diff --git a/tools/include/libxl.h b/tools/include/libxl.h
> index b9ba16d698..ec5e3badae 100644
> --- a/tools/include/libxl.h
> +++ b/tools/include/libxl.h
> @@ -502,6 +502,12 @@
>  */
> #define LIBXL_HAVE_X86_MSR_RELAXED 1
>=20
> +/*
> + * LIBXL_HAVE_PHYSINFO_CAP_VPMU indicates that libxl_physinfo has a cap_=
vpmu
> + * field, which indicates the availability of vPMU functionality.
> + */
> +#define LIBXL_HAVE_PHYSINFO_CAP_VPMU 1
> +
> /*
>  * libxl ABI compatibility
>  *
> diff --git a/tools/libs/light/libxl.c b/tools/libs/light/libxl.c
> index 204eb0be2d..a032723fde 100644
> --- a/tools/libs/light/libxl.c
> +++ b/tools/libs/light/libxl.c
> @@ -404,6 +404,7 @@ int libxl_get_physinfo(libxl_ctx *ctx, libxl_physinfo=
 *physinfo)
>         !!(xcphysinfo.capabilities & XEN_SYSCTL_PHYSCAP_iommu_hap_pt_shar=
e);
>     physinfo->cap_vmtrace =3D
>         !!(xcphysinfo.capabilities & XEN_SYSCTL_PHYSCAP_vmtrace);
> +    physinfo->cap_vpmu =3D !!(xcphysinfo.capabilities & XEN_SYSCTL_PHYSC=
AP_vpmu);
>=20
>     GC_FREE;
>     return 0;
> diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_ty=
pes.idl
> index 3f9fff653a..993e83acca 100644
> --- a/tools/libs/light/libxl_types.idl
> +++ b/tools/libs/light/libxl_types.idl
> @@ -1061,6 +1061,7 @@ libxl_physinfo =3D Struct("physinfo", [
>     ("cap_shadow", bool),
>     ("cap_iommu_hap_pt_share", bool),
>     ("cap_vmtrace", bool),
> +    ("cap_vpmu", bool),
>     ], dir=3DDIR_OUT)
>=20
> libxl_connectorinfo =3D Struct("connectorinfo", [
> diff --git a/tools/ocaml/libs/xc/xenctrl.ml b/tools/ocaml/libs/xc/xenctrl=
.ml
> index a5588c643f..6da3ed3c6f 100644
> --- a/tools/ocaml/libs/xc/xenctrl.ml
> +++ b/tools/ocaml/libs/xc/xenctrl.ml
> @@ -121,6 +121,7 @@ type physinfo_cap_flag =3D
> 	| CAP_Shadow
> 	| CAP_IOMMU_HAP_PT_SHARE
> 	| CAP_Vmtrace
> +	| CAP_Vpmu
>=20
> type physinfo =3D
> {
> diff --git a/tools/ocaml/libs/xc/xenctrl.mli b/tools/ocaml/libs/xc/xenctr=
l.mli
> index 6e94940a8a..b8faff6721 100644
> --- a/tools/ocaml/libs/xc/xenctrl.mli
> +++ b/tools/ocaml/libs/xc/xenctrl.mli
> @@ -106,6 +106,7 @@ type physinfo_cap_flag =3D
>   | CAP_Shadow
>   | CAP_IOMMU_HAP_PT_SHARE
>   | CAP_Vmtrace
> +  | CAP_Vpmu
>=20
> type physinfo =3D {
>   threads_per_core : int;
> diff --git a/tools/xl/xl_info.c b/tools/xl/xl_info.c
> index 8383e4a6df..2c86b317b7 100644
> --- a/tools/xl/xl_info.c
> +++ b/tools/xl/xl_info.c
> @@ -210,7 +210,7 @@ static void output_physinfo(void)
>          info.hw_cap[4], info.hw_cap[5], info.hw_cap[6], info.hw_cap[7]
>         );
>=20
> -    maybe_printf("virt_caps              :%s%s%s%s%s%s%s%s\n",
> +    maybe_printf("virt_caps              :%s%s%s%s%s%s%s%s%s\n",
>          info.cap_pv ? " pv" : "",
>          info.cap_hvm ? " hvm" : "",
>          info.cap_hvm && info.cap_hvm_directio ? " hvm_directio" : "",
> @@ -218,7 +218,8 @@ static void output_physinfo(void)
>          info.cap_hap ? " hap" : "",
>          info.cap_shadow ? " shadow" : "",
>          info.cap_iommu_hap_pt_share ? " iommu_hap_pt_share" : "",
> -         info.cap_vmtrace ? " vmtrace" : ""
> +         info.cap_vmtrace ? " vmtrace" : "",
> +         info.cap_vpmu ? " vpmu" : ""
>         );
>=20
>     vinfo =3D libxl_get_version_info(ctx);
> diff --git a/xen/common/domain.c b/xen/common/domain.c
> index 6ee5d033b0..4d0e909eec 100644
> --- a/xen/common/domain.c
> +++ b/xen/common/domain.c
> @@ -84,6 +84,8 @@ vcpu_info_t dummy_vcpu_info;
>=20
> bool __read_mostly vmtrace_available;
>=20
> +bool __read_mostly vpmu_is_available;
> +
> static void __domain_finalise_shutdown(struct domain *d)
> {
>     struct vcpu *v;
> diff --git a/xen/common/sysctl.c b/xen/common/sysctl.c
> index 3558641cd9..6e7189bb3c 100644
> --- a/xen/common/sysctl.c
> +++ b/xen/common/sysctl.c
> @@ -280,6 +280,9 @@ long do_sysctl(XEN_GUEST_HANDLE_PARAM(xen_sysctl_t) u=
_sysctl)
>         if ( vmtrace_available )
>             pi->capabilities |=3D XEN_SYSCTL_PHYSCAP_vmtrace;
>=20
> +        if ( vpmu_is_available )
> +            pi->capabilities |=3D XEN_SYSCTL_PHYSCAP_vpmu;
> +
>         if ( copy_to_guest(u_sysctl, op, 1) )
>             ret =3D -EFAULT;
>     }
> diff --git a/xen/include/public/sysctl.h b/xen/include/public/sysctl.h
> index 039ccf885c..b794c9d351 100644
> --- a/xen/include/public/sysctl.h
> +++ b/xen/include/public/sysctl.h
> @@ -100,10 +100,12 @@ struct xen_sysctl_tbuf_op {
> #define _XEN_SYSCTL_PHYSCAP_iommu_hap_pt_share 5
> #define XEN_SYSCTL_PHYSCAP_iommu_hap_pt_share  \
>     (1u << _XEN_SYSCTL_PHYSCAP_iommu_hap_pt_share)
> -#define XEN_SYSCTL_PHYSCAP_vmtrace       (1 << 6)
> +#define XEN_SYSCTL_PHYSCAP_vmtrace       (1u<<6)
> +/* The platform supports vPMU. */
> +#define XEN_SYSCTL_PHYSCAP_vpmu          (1u<<7)
>=20
> /* Max XEN_SYSCTL_PHYSCAP_* constant.  Used for ABI checking. */
> -#define XEN_SYSCTL_PHYSCAP_MAX XEN_SYSCTL_PHYSCAP_vmtrace
> +#define XEN_SYSCTL_PHYSCAP_MAX XEN_SYSCTL_PHYSCAP_vpmu
>=20
> struct xen_sysctl_physinfo {
>     uint32_t threads_per_core;
> diff --git a/xen/include/xen/domain.h b/xen/include/xen/domain.h
> index 1708c36964..160c8dbdab 100644
> --- a/xen/include/xen/domain.h
> +++ b/xen/include/xen/domain.h
> @@ -133,4 +133,6 @@ static inline void vnuma_destroy(struct vnuma_info *v=
numa) { ASSERT(!vnuma); }
>=20
> extern bool vmtrace_available;
>=20
> +extern bool vpmu_is_available;
> +
> #endif /* __XEN_DOMAIN_H__ */
> --=20
> 2.29.0
>=20
>=20



From xen-devel-bounces@lists.xenproject.org Fri Oct 08 08:32:02 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Oct 2021 08:32:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.204547.359709 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYlIQ-0002ua-Id; Fri, 08 Oct 2021 08:32:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 204547.359709; Fri, 08 Oct 2021 08:32:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYlIQ-0002uR-Ek; Fri, 08 Oct 2021 08:32:02 +0000
Received: by outflank-mailman (input) for mailman id 204547;
 Fri, 08 Oct 2021 08:32:01 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=/CyP=O4=arm.com=Bertrand.Marquis@srs-us1.protection.inumbo.net>)
 id 1mYlIP-0002sr-29
 for xen-devel@lists.xenproject.org; Fri, 08 Oct 2021 08:32:01 +0000
Received: from EUR01-HE1-obe.outbound.protection.outlook.com (unknown
 [40.107.13.83]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id eff413a4-2354-4f8b-978b-0c770ddb7b52;
 Fri, 08 Oct 2021 08:31:59 +0000 (UTC)
Received: from DB6PR0201CA0007.eurprd02.prod.outlook.com (2603:10a6:4:3f::17)
 by AM6PR08MB4599.eurprd08.prod.outlook.com (2603:10a6:20b:8f::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.22; Fri, 8 Oct
 2021 08:31:57 +0000
Received: from DB5EUR03FT029.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:4:3f:cafe::b3) by DB6PR0201CA0007.outlook.office365.com
 (2603:10a6:4:3f::17) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.22 via Frontend
 Transport; Fri, 8 Oct 2021 08:31:57 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT029.mail.protection.outlook.com (10.152.20.131) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4587.18 via Frontend Transport; Fri, 8 Oct 2021 08:31:56 +0000
Received: ("Tessian outbound e27daf245730:v103");
 Fri, 08 Oct 2021 08:31:56 +0000
Received: from 0d743de79010.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 0333BCFD-5479-4F3F-B83F-B0E79F9A7AB2.1; 
 Fri, 08 Oct 2021 08:31:46 +0000
Received: from EUR02-VE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 0d743de79010.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 08 Oct 2021 08:31:46 +0000
Received: from AM5PR0801MB2019.eurprd08.prod.outlook.com
 (2603:10a6:203:4b::22) by AM5PR0801MB1889.eurprd08.prod.outlook.com
 (2603:10a6:203:49::22) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18; Fri, 8 Oct
 2021 08:31:44 +0000
Received: from AM5PR0801MB2019.eurprd08.prod.outlook.com
 ([fe80::80a2:ff50:fde5:5215]) by AM5PR0801MB2019.eurprd08.prod.outlook.com
 ([fe80::80a2:ff50:fde5:5215%3]) with mapi id 15.20.4587.020; Fri, 8 Oct 2021
 08:31:44 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: eff413a4-2354-4f8b-978b-0c770ddb7b52
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=dpWulWwwnr2zmixwpIZOKIoxsGUD2NJ+ijLqHHq3QbE=;
 b=dhlU6ln6A7bW2EwY5KJ0r2QFxhvVkFtfOhM94snmCcINwBqb0/PIIv7AmWZ7dTN1ptpGSXMlByflbfNVBUpheWkbnfUeX024Xpvngh6fch4EigyA4PngkJWvk+ANyZStvqvu9rzXLKlFTHuHGOrqedbTS/zQHatjsc2Xkd2ue2s=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: fd218c5383b6121d
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=NBlxecIgbKl7pBlD9U/QoZqF7lzCBevTvL/Kfol+SH2QAL9Vag355uGS3XcuEXeeFXEe+fN0nU3E1W0cmKnl7ZagoeHCtZSEnbQE+YCMkoqxYr2JY5T0YGn6AOLBpjQTL+PNkCkDAfKvpvWkInB5ZCcohB4NEmKt5B7Yph0fi2ig2ySNvCN6sxR4EXBzC503ZLnKRkrtYXJzONk+Wp+D15yeZiZEy9ldEIUOeJe7qntdmAO9nQ65ABJm1136xzO/f79LKPzk5v1HJpPmmalZiiV70LdP8a+prY1v9lhkAP/9NxJBLey4MhXOuq8uMVDUGfoQE3XE9iveKUWAO5Xm2w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=dpWulWwwnr2zmixwpIZOKIoxsGUD2NJ+ijLqHHq3QbE=;
 b=VkPEI6NPHWYR0dsP4H5lLmNoNCXwGT2ukvs49+ghEiVD1chRWR8KYh05X5gPZnWBXW70ERuN229194XjsUkbKL28YLAhJIC2h1orykxavRQVpyUfyg6MTAW/JnLNhQGg3Ov05eSGQyXAj1oaqqzwZkqhk/urGr833U+5tOTkT06xzCcrfvFbDnC2yus6ilru7vSnzqku1+4n+90cqO9eEKugDMTwpYBjhayol8iHVdkyDD7/BTu6GFpY+CWxJ4le6nWf/D5s9O0wX7p6pE2ryAPAOyCP2uaepruxZPufLS9oEoH+TfrDbpHHdXVHrhZlyt1Y6Llffjp3uR/U3BvAmA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=dpWulWwwnr2zmixwpIZOKIoxsGUD2NJ+ijLqHHq3QbE=;
 b=dhlU6ln6A7bW2EwY5KJ0r2QFxhvVkFtfOhM94snmCcINwBqb0/PIIv7AmWZ7dTN1ptpGSXMlByflbfNVBUpheWkbnfUeX024Xpvngh6fch4EigyA4PngkJWvk+ANyZStvqvu9rzXLKlFTHuHGOrqedbTS/zQHatjsc2Xkd2ue2s=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Michal Orzel <Michal.Orzel@arm.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Stefano
 Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>, Volodymyr
 Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH v3 2/3] xen/arm: Check for PMU platform support
Thread-Topic: [PATCH v3 2/3] xen/arm: Check for PMU platform support
Thread-Index: AQHXvB1V0VFSwEt/Q0SfrOAbW/sfCavIxZ2A
Date: Fri, 8 Oct 2021 08:31:44 +0000
Message-ID: <0448EAA4-57BA-4146-8FF3-E02CBBAC2E85@arm.com>
References: <20211008081933.18546-1-michal.orzel@arm.com>
 <20211008081933.18546-3-michal.orzel@arm.com>
In-Reply-To: <20211008081933.18546-3-michal.orzel@arm.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3654.120.0.1.13)
Authentication-Results-Original: arm.com; dkim=none (message not signed)
 header.d=none;arm.com; dmarc=none action=none header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: ca3d216b-f1cb-4b64-42e0-08d98a361704
x-ms-traffictypediagnostic: AM5PR0801MB1889:|AM6PR08MB4599:
x-ms-exchange-transport-forked: True
X-Microsoft-Antispam-PRVS:
	<AM6PR08MB4599087459C4720D404D7AB69DB29@AM6PR08MB4599.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:5797;OLM:5797;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 H2ulycANC6FCdWjXVYAKj1u79Iqw0pg8R2p5qU2//iWnJ4ufe/NR+BpqR75S8PVqYPYFyvTEN1+TM3uncVeTvJuVSnGFNdrdkSc0i1XL20iP9fU+hd+MzK5ataJDStXkBVgc/ekd+eWR2+lEUM0daEEoXLJCAoEUfcZyV3oEQQk8duUmpR0ylifOXt3A1Xa0hm/HvUYV31h/nxGaXmPQXhUpxO1KS3zlOrof5Z0n4d/Qtv7L5WsMubEWnYD/P7mKa38+76mXKzUSAE4Dn9IFC0l8wmb04jd6dHYxhearHBz3mcjlEud/PD6ToL+UqyCFI1sv9a9suZOdUc/IDWNzcLn4lxbS6XXZW7y10mgizYqyLS5m+wqJl+mqEEqnN5z6jg5ZcwwyKWKLymvW+S6G9mrYVIZynVQyLHRryauLDX9lJBSCCA6kknO4/Yd4Z/Czdto9Gnzw80x0YwJ2Zjnbv+ZLLBk7NGdcsp//mlMqirygZFq+5sKEXh1Eake9u4/EUiKgwZWhuXhMIctcf8mrtmERR6xg2azqNlgq/nB20587+f+6EJHPfCqP8TvGzGBusBL23mej3qBUgCu+PsKCHhuYU8eiywTfWI4QltzPJz0YGa7h+fLbk+ERcM20CeU09uwmBNO2do2vjn3nZH7oDAyozIcFa85Ray6Hz45XRln72zxV/zMZHmW5qt/Qv+GWwatWarhjsIlv/4IipxST/TVanzvhy4IGcqVknRpWI+cJiSXLqaog/y6R06H8q/xg
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM5PR0801MB2019.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(33656002)(2616005)(316002)(38070700005)(26005)(37006003)(6636002)(8936002)(6512007)(4326008)(6862004)(6506007)(53546011)(91956017)(5660300002)(6486002)(76116006)(2906002)(36756003)(66946007)(8676002)(66476007)(122000001)(66556008)(508600001)(83380400001)(186003)(66446008)(64756008)(86362001)(54906003)(38100700002)(71200400001)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1D4845FE39A4E546BDB5700B75CA89D4@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0801MB1889
Original-Authentication-Results: arm.com; dkim=none (message not signed)
 header.d=none;arm.com; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT029.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	782e08f6-f2b7-4702-36cb-08d98a360f8b
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	QLuoi9fbT5D9pc9luHO8krCCz5U1rjsdv2GisYCLhyAwrPaz9+AQrROtg3OwgqKn48Pw86mtMJdIATYPziODxE+MnF605WFFcXdhuSiFeB+hnHg7OHNT2tbL3NilavjSaw5y/5XPK/r+JyRI0CkfdJCkO9Co7P3rc7e7CIMcf1EHmS6fGJrPamVl7CwR8ucUABmnuKqE8sCNjrweKlW2r907st+nqKcbXagjBGiPQEBVkkXR/QJJNKJY4jlZ3LUjpF1URS32uJqGiaSaos/FOPD+F8D0nLEvn628EVxaH81kYC3cYDFGB0AO354JzDyq4rt3T7B2CeGbO/uy5vU9gaeglMHz+tKVq94gRfq+TE0VprSTnYCeNeC+hoWHDjtH9b7FybogGckco81mJU2y15x0wh45LsD6l40XlpAwYT8WuiwFb1F7xIYBsXaKRrGM84zpR1gAoTdFBgmq587y9fEfvs846SoLqD5d2vTwfE+xF6FSGnk21S84ak/M8szO58SToVbYolEMUkR4ubzXmJUrC+qmuhcHaCKzhYlwLm1lM6g+Qn87aAiWxCEhD8unoqI7ocVYnBcom+Kxy6MKgyv8abpwiGoHuH2t4wP8yD90QTwRlhyQybAlFHdUsWn24duJkjBztGubuhwTuHmpzb5cyxYlCN1+xS0J+I2bJpBpPMqrAiCkoxPGwpu8/e1Y1ZX5f991zaNLwMTj96BN4g==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(82310400003)(70586007)(5660300002)(2906002)(4326008)(70206006)(33656002)(26005)(6636002)(6862004)(186003)(86362001)(36756003)(8936002)(81166007)(2616005)(83380400001)(47076005)(336012)(356005)(107886003)(54906003)(37006003)(316002)(6506007)(53546011)(6512007)(508600001)(8676002)(6486002)(36860700001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Oct 2021 08:31:56.8578
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: ca3d216b-f1cb-4b64-42e0-08d98a361704
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT029.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB4599

Hi Michal,

> On 8 Oct 2021, at 09:19, Michal Orzel <Michal.Orzel@arm.com> wrote:
>=20
> ID_AA64DFR0_EL1/ID_DFR0_EL1 registers provide
> information about PMU support. Replace structure
> dbg64/dbg32 with a union and fill in all the
> register fields according to document:
> ARM Architecture Registers(DDI 0595, 2021-06).
>=20
> Add macros boot_dbg_feature64/boot_dbg_feature32
> to check for a debug feature. Add macro
> cpu_has_pmu to check for PMU support.
>=20
> Signed-off-by: Michal Orzel <michal.orzel@arm.com>
> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>

Cheers
Bertrand

> ---
> Changes since v2:
> -none
> Changes since v1:
> -new in v2
> ---
> xen/include/asm-arm/cpufeature.h | 49 ++++++++++++++++++++++++++++++--
> 1 file changed, 47 insertions(+), 2 deletions(-)
>=20
> diff --git a/xen/include/asm-arm/cpufeature.h b/xen/include/asm-arm/cpufe=
ature.h
> index 5ca09b0bff..4fce23844d 100644
> --- a/xen/include/asm-arm/cpufeature.h
> +++ b/xen/include/asm-arm/cpufeature.h
> @@ -4,6 +4,7 @@
> #ifdef CONFIG_ARM_64
> #define cpu_feature64(c, feat)         ((c)->pfr64.feat)
> #define boot_cpu_feature64(feat)       (system_cpuinfo.pfr64.feat)
> +#define boot_dbg_feature64(feat)       (system_cpuinfo.dbg64.feat)
>=20
> #define cpu_feature64_has_el0_32(c)    (cpu_feature64(c, el0) =3D=3D 2)
>=20
> @@ -22,6 +23,7 @@
>=20
> #define cpu_feature32(c, feat)         ((c)->pfr32.feat)
> #define boot_cpu_feature32(feat)       (system_cpuinfo.pfr32.feat)
> +#define boot_dbg_feature32(feat)       (system_cpuinfo.dbg32.feat)
>=20
> #define cpu_has_arm       (boot_cpu_feature32(arm) =3D=3D 1)
> #define cpu_has_thumb     (boot_cpu_feature32(thumb) >=3D 1)
> @@ -32,8 +34,10 @@
>=20
> #ifdef CONFIG_ARM_32
> #define cpu_has_gentimer  (boot_cpu_feature32(gentimer) =3D=3D 1)
> +#define cpu_has_pmu       (boot_dbg_feature32(perfmon) >=3D 1)
> #else
> #define cpu_has_gentimer  (1)
> +#define cpu_has_pmu       (boot_dbg_feature64(pmu_ver) >=3D 1)
> #endif
> #define cpu_has_security  (boot_cpu_feature32(security) > 0)
>=20
> @@ -181,8 +185,28 @@ struct cpuinfo_arm {
>         };
>     } pfr64;
>=20
> -    struct {
> +    union {
>         register_t bits[2];
> +        struct {
> +            /* DFR0 */
> +            unsigned long debug_ver:4;
> +            unsigned long trace_ver:4;
> +            unsigned long pmu_ver:4;
> +            unsigned long brps:4;
> +            unsigned long __res0:4;
> +            unsigned long wrps:4;
> +            unsigned long __res1:4;
> +            unsigned long ctx_cmps:4;
> +            unsigned long pms_ver:4;
> +            unsigned long double_lock:4;
> +            unsigned long trace_filt:4;
> +            unsigned long __res2:4;
> +            unsigned long mtpmu:4;
> +            unsigned long __res3:12;
> +
> +            /* DFR1 */
> +            unsigned long __res4:64;
> +        };
>     } dbg64;
>=20
>     struct {
> @@ -321,8 +345,29 @@ struct cpuinfo_arm {
>         };
>     } pfr32;
>=20
> -    struct {
> +    union {
>         register_t bits[2];
> +        struct {
> +            /* DFR0 */
> +            unsigned long copdbg:4;
> +            unsigned long copsdbg:4;
> +            unsigned long mmapdbg:4;
> +            unsigned long coptrc:4;
> +            unsigned long mmaptrc:4;
> +            unsigned long mprofdbg:4;
> +            unsigned long perfmon:4;
> +            unsigned long tracefilt:4;
> +#ifdef CONFIG_ARM_64
> +            unsigned long __res0:32;
> +#endif
> +
> +            /* DFR1 */
> +            unsigned long mtpmu:4;
> +            unsigned long __res1:28;
> +#ifdef CONFIG_ARM_64
> +            unsigned long __res2:32;
> +#endif
> +        };
>     } dbg32;
>=20
>     struct {
> --=20
> 2.29.0
>=20
>=20



From xen-devel-bounces@lists.xenproject.org Fri Oct 08 08:32:21 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Oct 2021 08:32:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.204556.359720 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYlIi-0003Yx-Ru; Fri, 08 Oct 2021 08:32:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 204556.359720; Fri, 08 Oct 2021 08:32:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYlIi-0003Yq-OE; Fri, 08 Oct 2021 08:32:20 +0000
Received: by outflank-mailman (input) for mailman id 204556;
 Fri, 08 Oct 2021 08:32:19 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=/CyP=O4=arm.com=Bertrand.Marquis@srs-us1.protection.inumbo.net>)
 id 1mYlIh-0002sr-O0
 for xen-devel@lists.xenproject.org; Fri, 08 Oct 2021 08:32:19 +0000
Received: from EUR02-VE1-obe.outbound.protection.outlook.com (unknown
 [40.107.2.57]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 8b3b7abf-74e8-4f5f-ae31-b8aca971b1ca;
 Fri, 08 Oct 2021 08:32:15 +0000 (UTC)
Received: from DU2PR04CA0284.eurprd04.prod.outlook.com (2603:10a6:10:28c::19)
 by AM6PR08MB5285.eurprd08.prod.outlook.com (2603:10a6:20b:a3::33)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.20; Fri, 8 Oct
 2021 08:32:11 +0000
Received: from DB5EUR03FT044.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:10:28c:cafe::b2) by DU2PR04CA0284.outlook.office365.com
 (2603:10a6:10:28c::19) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.15 via Frontend
 Transport; Fri, 8 Oct 2021 08:32:11 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT044.mail.protection.outlook.com (10.152.21.167) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4587.18 via Frontend Transport; Fri, 8 Oct 2021 08:32:11 +0000
Received: ("Tessian outbound 8e26f7114b75:v103");
 Fri, 08 Oct 2021 08:32:11 +0000
Received: from f2a09072c1e1.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 C2A549CE-667A-4314-82B8-450B442A75A8.1; 
 Fri, 08 Oct 2021 08:32:01 +0000
Received: from EUR02-VE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id f2a09072c1e1.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 08 Oct 2021 08:32:01 +0000
Received: from AM5PR0801MB2019.eurprd08.prod.outlook.com
 (2603:10a6:203:4b::22) by AM5PR0801MB1889.eurprd08.prod.outlook.com
 (2603:10a6:203:49::22) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18; Fri, 8 Oct
 2021 08:31:59 +0000
Received: from AM5PR0801MB2019.eurprd08.prod.outlook.com
 ([fe80::80a2:ff50:fde5:5215]) by AM5PR0801MB2019.eurprd08.prod.outlook.com
 ([fe80::80a2:ff50:fde5:5215%3]) with mapi id 15.20.4587.020; Fri, 8 Oct 2021
 08:31:59 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8b3b7abf-74e8-4f5f-ae31-b8aca971b1ca
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=NiEyCQ28PKE1UMrJOHszKV2ibe+bdEzBvjqml7eydOI=;
 b=9hEU8ck2cN828TrE9Q+q4PprzICuygDbvqahPtQo3mZfPKuK0YoB3wBei1TU+2jN8KcxPO/oUBhSrlmnpv/gIlnzP20/zQIRDDPnj+5TRQVltoIvfsQrocXC8hC9XEHm6wlzJDUIF2/kjbPAfyfYVopQy2ros9FpfqDQue0HdG4=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 7eef6f75264bcfe5
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=OQ7SMx3T/y8OvmZWznGBL+8MVoth6Yjf7jfQ2jPtieCCCsxnMoZJ//P39upEe+o2ORZIU5SbJTWkM17xsi75Lv5CZRh6UrQeUpvMrazqLKm6XsI4keSn/IQlXpFO1L4qXOBFZzVwyZLw6Rzj/27btw1ft7tSrC1N1JZnjSOva6a9hxy5Ih0IdmF4yvm11oRa2gFKvm9LXZBHpduW/K8pEk3P5tacmUxvnvF5Lffx3zS7Lf27C+sTeqmlWJUovk4ERdBzK0W0VC6NvrVTLBf+le4bA3o9zLSRQBso6eOpr/bfL3XdlyDKrPnUfRB14j7TA5Y2s8lkAPfXN6gnk5Uy8w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=NiEyCQ28PKE1UMrJOHszKV2ibe+bdEzBvjqml7eydOI=;
 b=cVO8QiwB1K4SYrCb/kxN5EXbzBozYQKJ5dOKS778IFyxRPC1AcEqEABP4ChVEdsl8fZS6JXvFzrYF1WzRLgmzz2c5/7/t8bc7mkABDjNe+m56Jrdmga/WqUXhV6BRuHDFXgebzLjDs9tqgpCSS1vF7rZhAm5LEOPIwYwjaamvFHNthr50rvHQTT+Eo+vTr++3vaNnPcYEzEhSPwchmDgQesFDzdLFaEtM2lEI2pTheKGrynxvA9gJv5bRhK76F4Lvukfc7wy0gPcghoY6QYvPbjFKCeiXR1UzNXl6RlJbghcK7A22dHBn8XQdA0aKazhfsRZvforW8pjCVepcZaasQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=NiEyCQ28PKE1UMrJOHszKV2ibe+bdEzBvjqml7eydOI=;
 b=9hEU8ck2cN828TrE9Q+q4PprzICuygDbvqahPtQo3mZfPKuK0YoB3wBei1TU+2jN8KcxPO/oUBhSrlmnpv/gIlnzP20/zQIRDDPnj+5TRQVltoIvfsQrocXC8hC9XEHm6wlzJDUIF2/kjbPAfyfYVopQy2ros9FpfqDQue0HdG4=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Michal Orzel <Michal.Orzel@arm.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>, Ian Jackson
	<iwj@xenproject.org>, Wei Liu <wl@xen.org>, Andrew Cooper
	<andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>, Jan
 Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>, Stefano
 Stabellini <sstabellini@kernel.org>, Nick Rosbrook <rosbrookn@ainfosec.com>,
	Anthony PERARD <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>,
	Christian Lindig <christian.lindig@citrix.com>, David Scott
	<dave@recoil.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH v3 3/3] xen: Expose the PMU to the guests
Thread-Topic: [PATCH v3 3/3] xen: Expose the PMU to the guests
Thread-Index: AQHXvB1myIFT9ovQyEqzTMJuggo2W6vIxa8A
Date: Fri, 8 Oct 2021 08:31:59 +0000
Message-ID: <E0B6B33F-C1C0-436A-8EEE-74AB852742DE@arm.com>
References: <20211008081933.18546-1-michal.orzel@arm.com>
 <20211008081933.18546-4-michal.orzel@arm.com>
In-Reply-To: <20211008081933.18546-4-michal.orzel@arm.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3654.120.0.1.13)
Authentication-Results-Original: arm.com; dkim=none (message not signed)
 header.d=none;arm.com; dmarc=none action=none header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: a425509c-b6d1-4c21-eca9-08d98a361fef
x-ms-traffictypediagnostic: AM5PR0801MB1889:|AM6PR08MB5285:
x-ms-exchange-transport-forked: True
X-Microsoft-Antispam-PRVS:
	<AM6PR08MB5285B530099791E6EC9752C39DB29@AM6PR08MB5285.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:10000;OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 RQ0vmDmUOLzbV1yVYbqmZC7CS/vCbTf36iieyHoMblWd6MI1HfpEg7WHmeaMrIxf0I4DAGQWXMmvSwJSlwpYX+ETypqGEneldqn6szNGJq/z9S1fVg/yM9RjScyjkliCaXeMTFnqKznwuAniUrC//20dvXaHiJq1oALs5dI1CSS5bwyCJL3Y0JTi1bTbSUu6yMT8SoipZsyI/uN6KG5mVBVOpvvzMU6+Tt32OSadEyK1C6w12E+en3v0oLpAThXTKCsZdeJWz6JDjXaNjfje8R4czWorod1aV7knEFRRdk1fU4/8RaD3OpR7b0QlJqvV14dMHmejGmxoCgZHzYIyp5si1SYdmsEsQw0IXpjp8S1iXkL85Fg5DZP/ygRRmZ3Y25fWKgnjBxINJbpsifBTwrmSPoQ4EesaxeyyBshOhB3jhpO3qK6uRGtUQ4vjlicD7SekThhmpaR1oCtAqLxhzj4LLQI1IQLMSzrYvYrv7fUFAgoRrQM5RXhx/OPzMnDyQ5X7Hy24z4/7A8HtxKuu2wStQxjiMZGoSZvzDn0KcYYqpQyKOahJehnN4g1sniAhBBLBBuCe1ImePXFz4CJ6C7VQgvXYffsrCtV1PzYTf9adCgE5qX627G4NqK93S13QWDCJ6OqyGalmdmBBsQ7VeiHSNnWLt7rGcMPT8xokbkSBsXbrAYrZlBHOLORCrcSFCNJ/Bxb+KTTBl0COCThAxn21IfmOn6xhMk/CHuQGHEaWGR+ny7a3is0zYBEon+6u
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM5PR0801MB2019.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(33656002)(2616005)(316002)(38070700005)(26005)(37006003)(6636002)(8936002)(6512007)(4326008)(6862004)(6506007)(30864003)(53546011)(91956017)(5660300002)(7416002)(6486002)(76116006)(2906002)(36756003)(66946007)(8676002)(66476007)(122000001)(66556008)(508600001)(83380400001)(186003)(66446008)(64756008)(86362001)(54906003)(38100700002)(71200400001)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="us-ascii"
Content-ID: <BB6C412BDDFF58469F12B680287D12FE@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0801MB1889
Original-Authentication-Results: arm.com; dkim=none (message not signed)
 header.d=none;arm.com; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT044.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	cdffe335-8d45-4985-9131-08d98a36187a
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Djp8UPpSlfEaJVRuDXF148ERyMe58Fenly9gjUWMZihU2oH9r9SakkJ8MaooJ+UwtYvxWwK0xqmBRnI7/E//stJyyH7RA6IbUZ3mMAzPjh19+n98thvexE6kSdiFye4wA38WT+spzEr1zIhnJnVQnjWkCwqjIpiMlW6RJx0C9AMIwtktGwO1HFVAnAGEeC8mKLHiiBlbBOYgrxqKWEs4Mne/j3K+RjFMLr+WxFvFIeUojDz9lKSu6w8t+VYjbEizFTVVp6um0Uw2Eaw3I6TBYu/p2dJBh549Hk5cmqzEbNlC4cbXvLcJ1kgSOgJS3dQBhwUpnplAAyzC05C+sP/4O/Gs42aE5dxN9EfpDjfQF88l9CB6pdthXAlU918gyT9OlgTIT3JkEW4+MUPmZQrPGqDQEH0sZg+YeX/12EJQsbODdUldFEo70YLz/MdNzNTIHgFG2Yk7agu3KFWVdCbPgLF3QGmUsvJRPaqEHoLk9iNO0vTr8uitmxf20e5ZiMtSNptVsUCV3E9n0ZYG2xXKdU+a/ZpE/Fd3WXgBJhczcGR4fC5Xc4HshTq6Z+BmLaWrc3L0oMobmqqCwS1I8p6p78Rfvm1QlQ1OIaaUSSn5537dj64L2XwaSAIPp1vuREYYnw3iTCbmDb4J9f28+xA7X7d8+/XngmzW/g6idDGkJGhh3iULjktN5S99SupRTbSbE1DvUbZBdBI/FnRtuDaX5Q==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(82310400003)(316002)(8676002)(33656002)(336012)(6636002)(54906003)(30864003)(37006003)(70586007)(107886003)(2906002)(186003)(36860700001)(83380400001)(47076005)(81166007)(8936002)(36756003)(5660300002)(6862004)(6486002)(26005)(53546011)(6506007)(70206006)(356005)(2616005)(86362001)(6512007)(4326008)(508600001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Oct 2021 08:32:11.8240
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: a425509c-b6d1-4c21-eca9-08d98a361fef
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT044.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB5285

Hi Michal,

> On 8 Oct 2021, at 09:19, Michal Orzel <Michal.Orzel@arm.com> wrote:
>=20
> Add parameter vpmu to xl domain configuration syntax
> to enable the access to PMU registers by disabling
> the PMU traps(currently only for ARM).
>=20
> The current status is that the PMU registers are not
> virtualized and the physical registers are directly
> accessible when this parameter is enabled. There is no
> interrupt support and Xen will not save/restore the
> register values on context switches.
>=20
> Please note that this feature is experimental.
>=20
> Signed-off-by: Michal Orzel <michal.orzel@arm.com>
> Signed-off-by: Julien Grall <julien@xen.org>
Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>

Cheers
Bertrand

> ---
> Changes since v2:
> -remove redundant check from x86 code
> -do not define bit position and mask separately
> Changes since v1:
> -modify vpmu parameter to be common rather than arch specific
> ---
> docs/man/xl.cfg.5.pod.in             | 17 +++++++++++++++++
> tools/golang/xenlight/helpers.gen.go |  6 ++++++
> tools/golang/xenlight/types.gen.go   |  1 +
> tools/include/libxl.h                |  6 ++++++
> tools/libs/light/libxl_create.c      |  4 ++++
> tools/libs/light/libxl_types.idl     |  2 ++
> tools/ocaml/libs/xc/xenctrl.ml       |  1 +
> tools/ocaml/libs/xc/xenctrl.mli      |  1 +
> tools/xl/xl_parse.c                  |  2 ++
> xen/arch/arm/domain.c                | 10 ++++++++--
> xen/arch/arm/setup.c                 |  1 +
> xen/common/domain.c                  |  9 ++++++++-
> xen/include/asm-arm/domain.h         |  1 +
> xen/include/public/domctl.h          |  4 +++-
> 14 files changed, 61 insertions(+), 4 deletions(-)
>=20
> diff --git a/docs/man/xl.cfg.5.pod.in b/docs/man/xl.cfg.5.pod.in
> index 4b1e3028d2..55c4881205 100644
> --- a/docs/man/xl.cfg.5.pod.in
> +++ b/docs/man/xl.cfg.5.pod.in
> @@ -690,6 +690,23 @@ default.
> B<NOTE>: Acceptable values are platform specific.  For Intel Processor
> Trace, this value must be a power of 2 between 4k and 16M.
>=20
> +=3Ditem B<vpmu=3DBOOLEAN>
> +
> +Currently ARM only.
> +
> +Specifies whether to enable the access to PMU registers by disabling
> +the PMU traps.
> +
> +The PMU registers are not virtualized and the physical registers are dir=
ectly
> +accessible when this parameter is enabled. There is no interrupt support=
 and
> +Xen will not save/restore the register values on context switches.
> +
> +vPMU, by design and purpose, exposes system level performance
> +information to the guest. Only to be used by sufficiently privileged
> +domains. This feature is currently in experimental state.
> +
> +If this option is not specified then it will default to B<false>.
> +
> =3Dback
>=20
> =3Dhead2 Devices
> diff --git a/tools/golang/xenlight/helpers.gen.go b/tools/golang/xenlight=
/helpers.gen.go
> index c8669837d8..2449580bad 100644
> --- a/tools/golang/xenlight/helpers.gen.go
> +++ b/tools/golang/xenlight/helpers.gen.go
> @@ -1119,6 +1119,9 @@ return fmt.Errorf("converting field ArchX86.MsrRela=
xed: %v", err)
> }
> x.Altp2M =3D Altp2MMode(xc.altp2m)
> x.VmtraceBufKb =3D int(xc.vmtrace_buf_kb)
> +if err :=3D x.Vpmu.fromC(&xc.vpmu);err !=3D nil {
> +return fmt.Errorf("converting field Vpmu: %v", err)
> +}
>=20
>  return nil}
>=20
> @@ -1600,6 +1603,9 @@ return fmt.Errorf("converting field ArchX86.MsrRela=
xed: %v", err)
> }
> xc.altp2m =3D C.libxl_altp2m_mode(x.Altp2M)
> xc.vmtrace_buf_kb =3D C.int(x.VmtraceBufKb)
> +if err :=3D x.Vpmu.toC(&xc.vpmu); err !=3D nil {
> +return fmt.Errorf("converting field Vpmu: %v", err)
> +}
>=20
>  return nil
>  }
> diff --git a/tools/golang/xenlight/types.gen.go b/tools/golang/xenlight/t=
ypes.gen.go
> index 45f2cba3d2..b2e8bd1a85 100644
> --- a/tools/golang/xenlight/types.gen.go
> +++ b/tools/golang/xenlight/types.gen.go
> @@ -521,6 +521,7 @@ MsrRelaxed Defbool
> }
> Altp2M Altp2MMode
> VmtraceBufKb int
> +Vpmu Defbool
> }
>=20
> type DomainBuildInfoTypeUnion interface {
> diff --git a/tools/include/libxl.h b/tools/include/libxl.h
> index ec5e3badae..ee73eb06f1 100644
> --- a/tools/include/libxl.h
> +++ b/tools/include/libxl.h
> @@ -508,6 +508,12 @@
>  */
> #define LIBXL_HAVE_PHYSINFO_CAP_VPMU 1
>=20
> +/*
> + * LIBXL_HAVE_VPMU indicates that libxl_domain_build_info has a vpmu par=
ameter,
> + * which allows to enable the access to PMU registers.
> + */
> +#define LIBXL_HAVE_VPMU 1
> +
> /*
>  * libxl ABI compatibility
>  *
> diff --git a/tools/libs/light/libxl_create.c b/tools/libs/light/libxl_cre=
ate.c
> index e356b2106d..d123c2f703 100644
> --- a/tools/libs/light/libxl_create.c
> +++ b/tools/libs/light/libxl_create.c
> @@ -91,6 +91,7 @@ int libxl__domain_build_info_setdefault(libxl__gc *gc,
>     }
>=20
>     libxl_defbool_setdefault(&b_info->device_model_stubdomain, false);
> +    libxl_defbool_setdefault(&b_info->vpmu, false);
>=20
>     if (libxl_defbool_val(b_info->device_model_stubdomain) &&
>         !b_info->device_model_ssidref)
> @@ -622,6 +623,9 @@ int libxl__domain_make(libxl__gc *gc, libxl_domain_co=
nfig *d_config,
>                 create.flags |=3D XEN_DOMCTL_CDF_nested_virt;
>         }
>=20
> +        if ( libxl_defbool_val(b_info->vpmu) )
> +            create.flags |=3D XEN_DOMCTL_CDF_vpmu;
> +
>         assert(info->passthrough !=3D LIBXL_PASSTHROUGH_DEFAULT);
>         LOG(DETAIL, "passthrough: %s",
>             libxl_passthrough_to_string(info->passthrough));
> diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_ty=
pes.idl
> index 993e83acca..b96fb5c47e 100644
> --- a/tools/libs/light/libxl_types.idl
> +++ b/tools/libs/light/libxl_types.idl
> @@ -655,6 +655,8 @@ libxl_domain_build_info =3D Struct("domain_build_info=
",[
>     # Use zero value to disable this feature.
>     ("vmtrace_buf_kb", integer),
>=20
> +    ("vpmu", libxl_defbool),
> +
>     ], dir=3DDIR_IN,
>        copy_deprecated_fn=3D"libxl__domain_build_info_copy_deprecated",
> )
> diff --git a/tools/ocaml/libs/xc/xenctrl.ml b/tools/ocaml/libs/xc/xenctrl=
.ml
> index 6da3ed3c6f..addcf4cc59 100644
> --- a/tools/ocaml/libs/xc/xenctrl.ml
> +++ b/tools/ocaml/libs/xc/xenctrl.ml
> @@ -69,6 +69,7 @@ type domain_create_flag =3D
> 	| CDF_XS_DOMAIN
> 	| CDF_IOMMU
> 	| CDF_NESTED_VIRT
> +	| CDF_VPMU
>=20
> type domain_create_iommu_opts =3D
> 	| IOMMU_NO_SHAREPT
> diff --git a/tools/ocaml/libs/xc/xenctrl.mli b/tools/ocaml/libs/xc/xenctr=
l.mli
> index b8faff6721..0a5ce529e9 100644
> --- a/tools/ocaml/libs/xc/xenctrl.mli
> +++ b/tools/ocaml/libs/xc/xenctrl.mli
> @@ -62,6 +62,7 @@ type domain_create_flag =3D
>   | CDF_XS_DOMAIN
>   | CDF_IOMMU
>   | CDF_NESTED_VIRT
> +  | CDF_VPMU
>=20
> type domain_create_iommu_opts =3D
>   | IOMMU_NO_SHAREPT
> diff --git a/tools/xl/xl_parse.c b/tools/xl/xl_parse.c
> index 17dddb4cd5..c503b9be00 100644
> --- a/tools/xl/xl_parse.c
> +++ b/tools/xl/xl_parse.c
> @@ -2750,6 +2750,8 @@ skip_usbdev:
>                     "If it fixes an issue you are having please report to=
 "
>                     "xen-devel@lists.xenproject.org.\n");
>=20
> +    xlu_cfg_get_defbool(config, "vpmu", &b_info->vpmu, 0);
> +
>     xlu_cfg_destroy(config);
> }
>=20
> diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
> index 19c756ac3d..2dd474da09 100644
> --- a/xen/arch/arm/domain.c
> +++ b/xen/arch/arm/domain.c
> @@ -276,6 +276,8 @@ static void ctxt_switch_to(struct vcpu *n)
>      * timer. The interrupt needs to be injected into the guest. */
>     WRITE_SYSREG(n->arch.cntkctl, CNTKCTL_EL1);
>     virt_timer_restore(n);
> +
> +    WRITE_SYSREG(n->arch.mdcr_el2, MDCR_EL2);
> }
>=20
> /* Update per-VCPU guest runstate shared memory area (if registered). */
> @@ -586,6 +588,10 @@ int arch_vcpu_create(struct vcpu *v)
>=20
>     v->arch.hcr_el2 =3D get_default_hcr_flags();
>=20
> +    v->arch.mdcr_el2 =3D HDCR_TDRA | HDCR_TDOSA | HDCR_TDA;
> +    if ( !(v->domain->options & XEN_DOMCTL_CDF_vpmu) )
> +        v->arch.mdcr_el2 |=3D HDCR_TPM | HDCR_TPMCR;
> +
>     if ( (rc =3D vcpu_vgic_init(v)) !=3D 0 )
>         goto fail;
>=20
> @@ -622,8 +628,8 @@ int arch_sanitise_domain_config(struct xen_domctl_cre=
atedomain *config)
> {
>     unsigned int max_vcpus;
>=20
> -    /* HVM and HAP must be set. IOMMU may or may not be */
> -    if ( (config->flags & ~XEN_DOMCTL_CDF_iommu) !=3D
> +    /* HVM and HAP must be set. IOMMU and PMU may or may not be */
> +    if ( (config->flags & ~(XEN_DOMCTL_CDF_iommu | XEN_DOMCTL_CDF_vpmu))=
 !=3D
>          (XEN_DOMCTL_CDF_hvm | XEN_DOMCTL_CDF_hap) )
>     {
>         dprintk(XENLOG_INFO, "Unsupported configuration %#x\n",
> diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c
> index 49dc90d198..85386a765a 100644
> --- a/xen/arch/arm/setup.c
> +++ b/xen/arch/arm/setup.c
> @@ -108,6 +108,7 @@ static void __init processor_id(void)
>=20
>     identify_cpu(c);
>     current_cpu_data =3D *c;
> +    vpmu_is_available =3D cpu_has_pmu;
>=20
>     if ( c->midr.implementer < ARRAY_SIZE(processor_implementers) &&
>          processor_implementers[c->midr.implementer] )
> diff --git a/xen/common/domain.c b/xen/common/domain.c
> index 4d0e909eec..8b53c49d1e 100644
> --- a/xen/common/domain.c
> +++ b/xen/common/domain.c
> @@ -480,12 +480,13 @@ static int sanitise_domain_config(struct xen_domctl=
_createdomain *config)
>     bool hvm =3D config->flags & XEN_DOMCTL_CDF_hvm;
>     bool hap =3D config->flags & XEN_DOMCTL_CDF_hap;
>     bool iommu =3D config->flags & XEN_DOMCTL_CDF_iommu;
> +    bool vpmu =3D config->flags & XEN_DOMCTL_CDF_vpmu;
>=20
>     if ( config->flags &
>          ~(XEN_DOMCTL_CDF_hvm | XEN_DOMCTL_CDF_hap |
>            XEN_DOMCTL_CDF_s3_integrity | XEN_DOMCTL_CDF_oos_off |
>            XEN_DOMCTL_CDF_xs_domain | XEN_DOMCTL_CDF_iommu |
> -           XEN_DOMCTL_CDF_nested_virt) )
> +           XEN_DOMCTL_CDF_nested_virt | XEN_DOMCTL_CDF_vpmu) )
>     {
>         dprintk(XENLOG_INFO, "Unknown CDF flags %#x\n", config->flags);
>         return -EINVAL;
> @@ -534,6 +535,12 @@ static int sanitise_domain_config(struct xen_domctl_=
createdomain *config)
>         return -EINVAL;
>     }
>=20
> +    if ( vpmu && !vpmu_is_available )
> +    {
> +        dprintk(XENLOG_INFO, "vpmu requested but cannot be enabled this =
way\n");
> +        return -EINVAL;
> +    }
> +
>     return arch_sanitise_domain_config(config);
> }
>=20
> diff --git a/xen/include/asm-arm/domain.h b/xen/include/asm-arm/domain.h
> index c9277b5c6d..14e575288f 100644
> --- a/xen/include/asm-arm/domain.h
> +++ b/xen/include/asm-arm/domain.h
> @@ -166,6 +166,7 @@ struct arch_vcpu
>=20
>     /* HYP configuration */
>     register_t hcr_el2;
> +    register_t mdcr_el2;
>=20
>     uint32_t teecr, teehbr; /* ThumbEE, 32-bit guests only */
> #ifdef CONFIG_ARM_32
> diff --git a/xen/include/public/domctl.h b/xen/include/public/domctl.h
> index 96696e3842..238384b5ae 100644
> --- a/xen/include/public/domctl.h
> +++ b/xen/include/public/domctl.h
> @@ -70,9 +70,11 @@ struct xen_domctl_createdomain {
> #define XEN_DOMCTL_CDF_iommu          (1U<<_XEN_DOMCTL_CDF_iommu)
> #define _XEN_DOMCTL_CDF_nested_virt   6
> #define XEN_DOMCTL_CDF_nested_virt    (1U << _XEN_DOMCTL_CDF_nested_virt)
> +/* Should we expose the vPMU to the guest? */
> +#define XEN_DOMCTL_CDF_vpmu           (1U << 7)
>=20
> /* Max XEN_DOMCTL_CDF_* constant.  Used for ABI checking. */
> -#define XEN_DOMCTL_CDF_MAX XEN_DOMCTL_CDF_nested_virt
> +#define XEN_DOMCTL_CDF_MAX XEN_DOMCTL_CDF_vpmu
>=20
>     uint32_t flags;
>=20
> --=20
> 2.29.0
>=20
>=20



From xen-devel-bounces@lists.xenproject.org Fri Oct 08 08:33:49 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Oct 2021 08:33:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.204571.359731 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYlK8-0004T5-B1; Fri, 08 Oct 2021 08:33:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 204571.359731; Fri, 08 Oct 2021 08:33:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYlK8-0004Sy-78; Fri, 08 Oct 2021 08:33:48 +0000
Received: by outflank-mailman (input) for mailman id 204571;
 Fri, 08 Oct 2021 08:33:46 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=aYfl=O4=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mYlK6-0004Sp-C9
 for xen-devel@lists.xenproject.org; Fri, 08 Oct 2021 08:33:46 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 73259c34-2812-11ec-8025-12813bfff9fa;
 Fri, 08 Oct 2021 08:33:45 +0000 (UTC)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2104.outbound.protection.outlook.com [104.47.17.104])
 (Using TLS) by relay.mimecast.com with ESMTP id
 de-mta-3-SAnrG23LOCiUJQZQfxzFzQ-2; Fri, 08 Oct 2021 10:33:43 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB4605.eurprd04.prod.outlook.com (2603:10a6:803:65::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.18; Fri, 8 Oct
 2021 08:33:39 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4587.022; Fri, 8 Oct 2021
 08:33:39 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6PR0202CA0042.eurprd02.prod.outlook.com (2603:10a6:20b:3a::19) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.14 via Frontend
 Transport; Fri, 8 Oct 2021 08:33:38 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 73259c34-2812-11ec-8025-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1633682024;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=6aCodjr1taws3K6Jb047WlFcwqBmnnBnKcuBfc1FYIU=;
	b=d1XGOnV1JAoshatyjHcJeQ1hbQMeC9pmycvIGFlb1g0sfznwIxnW/LqnLwyLICVtRku4Uf
	lJ+OE3GMiI+2+XqCgJ09TnV2PH9eIoM9v0NJe5jVLL1Vr53kiKnBx5Ku8gcmhB3bgrgh5d
	r5G0sE6m8eR0XGJP+Rp0DDdc1g/eHT0=
X-MC-Unique: SAnrG23LOCiUJQZQfxzFzQ-2
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=MZ7e3qOf/L8oKKUnGmVKTv/5njco9B5o9N+Km1qF/+0rkScDJDoGnr4IHgW9Xb0DfC+VGm/K4gQPUSmAvZE+79V/aK5nlaS3k4QwvYVwgJzFG89E8VtRN9dgTGGJ4LuDETNRLXwPYif2HNKgUOeGRg1Q30bbfn38CRZZh/qOyB5xtyXqkDGeb1JPlZnvwGmw6jKzbCQvXFzzay1xWH35Ln+0dN3Wv1lQmq2sh2JLmMTgdFPIt6xPelJPhVkD4V1F47bdGs+p1JpbdxhpQ2SZtwkOIVdxzQnx05wZgcHUnBdnk3g7t0f81wAnPWXzehoY+5D4AUOJrvQ7ZPr8+GKZvQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=6aCodjr1taws3K6Jb047WlFcwqBmnnBnKcuBfc1FYIU=;
 b=FLW1Mynvr5AJLqKjXgIv8rWnCH/JII83ZC6kDDZO2RQc37qVDrGMvA+bKyO3V9hD1WX/93lLh0vKHQDtrPaa19AEbQGNXaf0XxPNWuZWxhCt0t4EqfVPbhT5drLkz7nHo7wAO9iCpQN0JpmTDbKbP4s++/yPzf75FzrQnL+PApIPju9uBElJNL+QydgbSoYeS6wWioIYAodfXj1L8iSjAasXvkn6ELKNtAVYnJSigvRKWIxc/BmQJUlxKM3bAqHvkC3ypHRxG4mV1UJfPoRDzup/C9677zpB3d6nn2wSSUXDXPNcCjDNVBDyZIGMR9OfwtVfx+mNr2daWZicmD10ZQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [PATCH v3 1/3] xen+tools: Introduce XEN_SYSCTL_PHYSCAP_vpmu
To: Michal Orzel <michal.orzel@arm.com>
Cc: George Dunlap <george.dunlap@citrix.com>,
 Nick Rosbrook <rosbrookn@ainfosec.com>, Ian Jackson <iwj@xenproject.org>,
 Wei Liu <wl@xen.org>, Andrew Cooper <andrew.cooper3@citrix.com>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Anthony PERARD <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>,
 Christian Lindig <christian.lindig@citrix.com>, David Scott
 <dave@recoil.org>, xen-devel@lists.xenproject.org
References: <20211008081933.18546-1-michal.orzel@arm.com>
 <20211008081933.18546-2-michal.orzel@arm.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <dce7709d-a68b-a8f0-a752-6eaeb2e0ce2e@suse.com>
Date: Fri, 8 Oct 2021 10:33:36 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <20211008081933.18546-2-michal.orzel@arm.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR0202CA0042.eurprd02.prod.outlook.com
 (2603:10a6:20b:3a::19) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 6c7ce8d4-dd5b-4114-8faa-08d98a36542a
X-MS-TrafficTypeDiagnostic: VI1PR04MB4605:
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB4605FCEB6B80C6E8AF1FF166B3B29@VI1PR04MB4605.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	M0bbFjt+gAlzkFs3NVxLQpo1MXWp0+Y9ncuyEmZ/3gRjSWEEcybr5URs+G8/cCZgfS+R4Cj8Fo17eHLk/fZz9UpvUnxWBZx3EIYF5Ds6Qb1bf8b1qJSBvkV4AGYyxViRF1u9W+XdgMPhVGwgpGE493Plz/jRN0BouzrKTS5KnWSJHLRqYl2x+UveFh/+JlweJg5nPZu3YoGP4Ugb/onOb9f+tx2NNPMq5stz9jdGtOmMtSCsZmswKdT4Hf5zGCKSjy6vScLCFVOoqh1X21JOQsIVn719J9cdt+IYOtZvEct+4sB2br3/Zg36JMRFd2eHWwaTyaqV3EaY3DkNu+DLaxuLbHkU/of2/uggIyZJXUhjXllP9WS/BD8v0KC7uKsGlYnRWmFLSbaMfBgUT6lw5mlf7qykfjsqjcFx/ckFpsTz2IalBcHnn2r7i8w4JcKqNhF8Ym2Vm9K0uHXnVwVdSOsA8Iww7vQS1Kgt3BjC7xxDne/47WajrYGr4hNimvspSWQQ3JLk8eINJW0xmo6CjjbMbSsPUkgdmMTQ6wtp7569UhY4r+cLU8Td166xDb/cWKww7oG8FVbUMFTxYtmoz4jcwT85TmVUsbQkt4tGztAPHl9hEwHGn2jFqfcQXUseT73yzqBLg3ciWJ3TwTD30nkP8BKQ/KQB5w46O+gqFWU9R/GUYlDtab+A9qaXaSLbw0Tblsso3ZIckq0OKE+oF+2f9xCMzMECrvsqKF/ySIx9Kh9aD1vYBCXaxQ329BQa
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(86362001)(5660300002)(4744005)(66476007)(2906002)(16576012)(316002)(36756003)(4326008)(956004)(2616005)(53546011)(186003)(54906003)(6916009)(31686004)(38100700002)(7416002)(6486002)(26005)(31696002)(66946007)(66556008)(8936002)(8676002)(508600001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?RDdnNEhzb0s0NjdjWklSSkp5MVBjNWdJWGF3SmtzbHBJRkdOZE0zN2FlNlZw?=
 =?utf-8?B?WGcxSUx6NDNteTh1b1BGWktjekN0c0lHdEhOOW0rNUoySUJ4YTU5KzNES21N?=
 =?utf-8?B?U01zQk9ZdDhibHFtUUZudTkzZk5SMzR3WS9FMXl6aGtNa21manYzRU50UWZE?=
 =?utf-8?B?aVZCS1E3Nzl4RHpzeHMzZTlhN25Oa3grMUxPNzliRDhPV1RSYVpjTkhBN1lG?=
 =?utf-8?B?MEQyS0k4S21PajV4aEsvZDlrN3UxMGMzQ0Jia2Y1NUFRaTlDTEhGcXNUTHc3?=
 =?utf-8?B?U3lEbU9qSmxsRWQwRGdjb0J0OEl0eU8wU2xFVXhWMGJQTFhhcHVPbzh3cWsr?=
 =?utf-8?B?czJ4eDZjQzY2ay9ySlBTK1k3T2hEemJJZ0V6bkh2RUJOUThiWTBMU2NoNHVS?=
 =?utf-8?B?QTNkUlNqaFVTa3VaaWxTV09iNlE0QU9YUWlXWUoxeWt2dmQyS1RCMS9IYmdm?=
 =?utf-8?B?Z2FsMVUvcFdPK3hxR3F0LzI4YVhXSVhEK2NTOGN2QW5qemhLWmlXZjNRYmZy?=
 =?utf-8?B?MDU0R0Fsb0dRVzlnSCtNUHU4Qmx4ZWcyRjMycmxhMExXM0FBcldWdXFIdmVy?=
 =?utf-8?B?RVhTWkVOWkIzdHg1WHpzZVAvRlpDRk9qdDJwWUhueHVsMkl3N1dsZS9iOEd4?=
 =?utf-8?B?UGgxSmZhbGdUUmJwSDlkeVNFU0V2Z2pNZFZLWUZ2cUtCRWE0SUZQQ0ZxUFlN?=
 =?utf-8?B?eUsyVnhvNHRwek9oQk00RzU2SUlXU0FBZ0NjaCs2S2c5ZHJDakZrVkxTTUpJ?=
 =?utf-8?B?dTA5QzJKWmk0eGlOTmZIZ1dndlpwdVpSd0xVNU1YV3RRSzQ2d3RYN0lVV1pR?=
 =?utf-8?B?RU5DbkVjZjhvUGFqczdXT3ZpZUplQVRkWHczZWw5clJ6d2VrSzlSSnlQZEV3?=
 =?utf-8?B?VkhIckJVaHJUUXhXclVYK1VtUjZjRU1aTEQvRUpVS1VLUGpTM2JhT1dKNksy?=
 =?utf-8?B?RTdmVjNzK1lHRWlzN2hRdmYxUEptL1pQcU5HSEw2eVljME5CbkEvRGN4blFH?=
 =?utf-8?B?UjRiMTkyd0FuVFpUcUlzQ1BIVnZiSStCT3ArN3lSNGZ4NFJISHQ2Y3h1NGxw?=
 =?utf-8?B?eFcycWdtcEl1RnVFRWZmWGdRaGRSOWxWR3RDZC9wbkUvL1ZuWkRYL2kyVldW?=
 =?utf-8?B?UFFQaEw2ZmNVZUpBeldnbzNBWEpzQ2I0blJrYnl4bUFPY1BPdnF6MXAwdjAx?=
 =?utf-8?B?eUNSczhDTUtNS3prcDF1V2xKM0dzdXRVSDEwcy9ZNHpXdTNlUjU5d1lHVnd3?=
 =?utf-8?B?VkdCekZESFVDN0haczF2V21iRldRd1ZmOFNVdXdwLzVNQWZVYmZjaGJKa2x4?=
 =?utf-8?B?SlNzRHRZVjZvNmIvUmdwRDg0Zi81SkhNVG9WRjZYUFhmMUdzVk9sWU9jblAz?=
 =?utf-8?B?MmtFTmMvL3FNT0xQNjgvYmJTWFhjYkVpcGpxWk1FeVBuRURncjlrczFORFdG?=
 =?utf-8?B?ejZBaTFNa1J5TjdBdyt1d3kvY29JSjVXS1M5ZVJ4bkQ0bnlpUlppZUxselln?=
 =?utf-8?B?d2tub2VheXIzc0QyRjhOOVhER1ZsMnFQcFp5YVlySTVvMWZpdHd5R1MzNStL?=
 =?utf-8?B?L3dqbkozTHI1b2ZwMTNCSExjNXRoQUJrNEtrN25mbThLc0N1bTE1bG5xSzhv?=
 =?utf-8?B?Y1hoVjh0OWdhNWVsdGJLektyelZPYUNhRmI0LzZDY3J4SkZqS09EN1VueGdu?=
 =?utf-8?B?VDRSZENsZkVCcHpZM04vMzdQUm8zUmhGSGRHN3EzMk1QcTJkUjhVSCtCUmlu?=
 =?utf-8?Q?1eYgxTzDhluNUGRGtoMq1EgnXrFUT46vpHP2kq5?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6c7ce8d4-dd5b-4114-8faa-08d98a36542a
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Oct 2021 08:33:39.5497
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2VJEoX35jIwpQrmo4wUaN9pNjuKVRDXsUqHO00UHt18d930zP34Tl13xdhsnQX1bVotF5AWGzzeJ53kydIecMQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4605

On 08.10.2021 10:19, Michal Orzel wrote:
> --- a/xen/include/public/sysctl.h
> +++ b/xen/include/public/sysctl.h
> @@ -100,10 +100,12 @@ struct xen_sysctl_tbuf_op {
>  #define _XEN_SYSCTL_PHYSCAP_iommu_hap_pt_share 5
>  #define XEN_SYSCTL_PHYSCAP_iommu_hap_pt_share  \
>      (1u << _XEN_SYSCTL_PHYSCAP_iommu_hap_pt_share)
> -#define XEN_SYSCTL_PHYSCAP_vmtrace       (1 << 6)
> +#define XEN_SYSCTL_PHYSCAP_vmtrace       (1u<<6)
> +/* The platform supports vPMU. */
> +#define XEN_SYSCTL_PHYSCAP_vpmu          (1u<<7)

While purely cosmetic and easily fixable while committing, I still
fail to understand why you did drop the blanks from the expression
you adjust and why you didn't add blanks to the new expression.
./CODING_STYLE is quite clear in this respect, and even the code
in context does not suggest any alternative style. (While code just
outside of visible context does, it should not be used as excuse
to introduce further style violations.)

Jan



From xen-devel-bounces@lists.xenproject.org Fri Oct 08 08:41:24 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Oct 2021 08:41:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.204579.359742 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYlRQ-0005xD-4U; Fri, 08 Oct 2021 08:41:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 204579.359742; Fri, 08 Oct 2021 08:41:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYlRQ-0005x6-0q; Fri, 08 Oct 2021 08:41:20 +0000
Received: by outflank-mailman (input) for mailman id 204579;
 Fri, 08 Oct 2021 08:41:18 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HhL2=O4=arm.com=michal.orzel@srs-us1.protection.inumbo.net>)
 id 1mYlRO-0005x0-PR
 for xen-devel@lists.xenproject.org; Fri, 08 Oct 2021 08:41:18 +0000
Received: from foss.arm.com (unknown [217.140.110.172])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTP
 id 80fbcabc-2813-11ec-8025-12813bfff9fa;
 Fri, 08 Oct 2021 08:41:17 +0000 (UTC)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3E20A6D;
 Fri,  8 Oct 2021 01:41:17 -0700 (PDT)
Received: from [10.57.24.215] (unknown [10.57.24.215])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 9100B3F70D;
 Fri,  8 Oct 2021 01:41:13 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 80fbcabc-2813-11ec-8025-12813bfff9fa
Subject: Re: [PATCH v3 1/3] xen+tools: Introduce XEN_SYSCTL_PHYSCAP_vpmu
To: Jan Beulich <jbeulich@suse.com>
Cc: George Dunlap <george.dunlap@citrix.com>,
 Nick Rosbrook <rosbrookn@ainfosec.com>, Ian Jackson <iwj@xenproject.org>,
 Wei Liu <wl@xen.org>, Andrew Cooper <andrew.cooper3@citrix.com>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Anthony PERARD <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>,
 Christian Lindig <christian.lindig@citrix.com>, David Scott
 <dave@recoil.org>, xen-devel@lists.xenproject.org
References: <20211008081933.18546-1-michal.orzel@arm.com>
 <20211008081933.18546-2-michal.orzel@arm.com>
 <dce7709d-a68b-a8f0-a752-6eaeb2e0ce2e@suse.com>
From: Michal Orzel <michal.orzel@arm.com>
Message-ID: <48b0728b-fbdf-7f56-336d-c9623406f5ea@arm.com>
Date: Fri, 8 Oct 2021 10:41:02 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <dce7709d-a68b-a8f0-a752-6eaeb2e0ce2e@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit


Hi Jan,

On 08.10.2021 10:33, Jan Beulich wrote:
> On 08.10.2021 10:19, Michal Orzel wrote:
>> --- a/xen/include/public/sysctl.h
>> +++ b/xen/include/public/sysctl.h
>> @@ -100,10 +100,12 @@ struct xen_sysctl_tbuf_op {
>>  #define _XEN_SYSCTL_PHYSCAP_iommu_hap_pt_share 5
>>  #define XEN_SYSCTL_PHYSCAP_iommu_hap_pt_share  \
>>      (1u << _XEN_SYSCTL_PHYSCAP_iommu_hap_pt_share)
>> -#define XEN_SYSCTL_PHYSCAP_vmtrace       (1 << 6)
>> +#define XEN_SYSCTL_PHYSCAP_vmtrace       (1u<<6)
>> +/* The platform supports vPMU. */
>> +#define XEN_SYSCTL_PHYSCAP_vpmu          (1u<<7)
> 
> While purely cosmetic and easily fixable while committing, I still
> fail to understand why you did drop the blanks from the expression
> you adjust and why you didn't add blanks to the new expression.
> ./CODING_STYLE is quite clear in this respect, and even the code
> in context does not suggest any alternative style. (While code just
> outside of visible context does, it should not be used as excuse
> to introduce further style violations.)
> 
I was just biased by the previous entries.
Previous entries were not added at once but commit after commit.
No one did any remarks on that so I decided to stick to the "section standard".
>From now one I will be looking only at the coding style even though the section
is doing something else. If it is possible, please fix it while commiting.

> Jan
> 

Cheers,
Michal


From xen-devel-bounces@lists.xenproject.org Fri Oct 08 09:30:40 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Oct 2021 09:30:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.204595.359752 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYmD3-0002Zu-QD; Fri, 08 Oct 2021 09:30:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 204595.359752; Fri, 08 Oct 2021 09:30:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYmD3-0002Zn-NB; Fri, 08 Oct 2021 09:30:33 +0000
Received: by outflank-mailman (input) for mailman id 204595;
 Fri, 08 Oct 2021 09:30:32 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=aYfl=O4=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mYmD2-0002Zh-Dt
 for xen-devel@lists.xen.org; Fri, 08 Oct 2021 09:30:32 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 60e77d78-281a-11ec-8026-12813bfff9fa;
 Fri, 08 Oct 2021 09:30:31 +0000 (UTC)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2107.outbound.protection.outlook.com [104.47.18.107])
 (Using TLS) by relay.mimecast.com with ESMTP id
 de-mta-7-MCxniIA_N028e5Bxj2QIfA-1; Fri, 08 Oct 2021 11:30:28 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB5328.eurprd04.prod.outlook.com (2603:10a6:803:59::25)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18; Fri, 8 Oct
 2021 09:30:27 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4587.022; Fri, 8 Oct 2021
 09:30:27 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 FR0P281CA0001.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:15::6) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.4 via Frontend Transport; Fri, 8 Oct 2021 09:30:26 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 60e77d78-281a-11ec-8026-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1633685430;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=4/vZb0aEvXjjfzt7OVIjwfSk5dIoU42hFDYAS/bExUQ=;
	b=Y54tzfz0xXdEJMRBvcDBwn0V5l6jmFfteBv3g7qFtRIKaMlfwAgpvH/YZ0/SUSsR95nAI1
	TMoAsGvpVRR4rhAuvy7Y53+cbMq4JMw11lMgvTBYEPXz9xOekCvZ/8n0vjNoaH4VaU8O1+
	iJb9CoKfinyVWXfFdzBMLzWeTitlQ24=
X-MC-Unique: MCxniIA_N028e5Bxj2QIfA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=bfZlYRtP+ksecha/x1nAORubKtbYu8H2MpdnOmD53o2i4D7PHXsI2cWV77YsaPYxJVNTTjXbhWX47XrQkbNpIRKuPKn0WAkI6NNlzq2OUSbespqG38bj/fgYcgUykzLgncjAkV8zZHr1fqx+TSemLKVNdMMFShlVUOxcu3rAVOhPXC8cuOzuJCxBwxkpajPeAGZNNLO5uXiqk2jwEbfb/xsFNKuQfC/PFg2Arqg7t86Au17kIDsLIkc3smtqUWN/T7mHLLqPiPkUuuKsvXn8im1jkOFO/y3CUsFyhx50GsnBxEpZ+0QJh9/d8aLnlTOWAjrt2KFM6kh1NDcAgcmYSg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=NAows11ib9/2DBlqxbzf3C0a75Pd5fKIXtdRIXUTJAk=;
 b=bdjKizALnoq1rodGxZYXliKDky0z0xoH4Ownw/yFuK1KdmgkLlgVHjrwRE9jSUNdz6Glfr0u4ICfKFJnxYqu84AgqMZYKJRl7PlAWHhzWQvRaWnqFsNK+fb9AdogPz3SKDEPOt0zC/pDxBsXZPcdjj3POYP7i6m0hxrBvTKxdUFwCcbWOqqAp0syHrmc1XWACsBr7B6X3p2PMm5hPcsYeljE0r3Y4cFRDUnLUrnsCnEjbmRGGmKuDDMrSvjS33WOul3nTjhxdm82qP2BCZSywdO20W7sgDtbxt7LlQYijfqvWN4DhZhYd4Y1Ka07iOX+thWoIwQtrFkyXs+eN0a1yQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xen.org; dkim=none (message not signed)
 header.d=none;lists.xen.org; dmarc=none action=none header.from=suse.com;
Subject: Re: PV - different behavior of pgd_offset in xen 4.6 and 4.13 for
 GUEST ACCESSIBLE memory area
To: =?UTF-8?Q?Charles_Gon=c3=a7alves?= <charles.fg@gmail.com>
References: <CAAQRGoBQZ4mMWy2ibectwbN85oWvgcwus2rwO23u7BA7JWbf+A@mail.gmail.com>
CC: xen-devel@lists.xen.org
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <4c622d73-6907-35aa-2701-4aea73fdb160@suse.com>
Date: Fri, 8 Oct 2021 11:30:24 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <CAAQRGoBQZ4mMWy2ibectwbN85oWvgcwus2rwO23u7BA7JWbf+A@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: FR0P281CA0001.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:15::6) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 43d97590-a756-4185-a342-08d98a3e4323
X-MS-TrafficTypeDiagnostic: VI1PR04MB5328:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB53283EA7E037B189CACFC278B3B29@VI1PR04MB5328.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	FB8HTxsp3yw2qtz/JhJc2OcMOZ3d2YChqsN9pcr67y7C6kj8/P9tEhkz48j3GoNXcQtuOtJBxqtFmOY3d12oZr1+BMX+eA+AwDjc6e7r9T/VYYfMgi9UDQWgi3J/chG5l01RO6IlkoEvB2KajP20FcA211lpxBHfB6TAdjU8bm+RVzWndyowHfR2mgZVN+WEnQm3NTLBDHEyBagPYUEdmwQznzkrDlrM87IJcYsNwWTFcQqqFbEVukw1byVJ2TzItpGpzo0nnaDfGnwmus/C59j171ScfAFpEICT4UTZjdk1ng7WfAVzF0ImAmASy/OWIbTvtlPxm0/M7nzbjO54WIkQoQa4s03ThPHzRS+r+V0/ZIQYuMX3hLKUx1gHWc0hNnXf9ggJ7vz2YnPexdbjetJglO+dBwVm62PeycRfMbz2Js8h+36l8WVATEEnlt7jOX452KTshqfoOtUm7q67hiq1pTlm9NQwVKgKkkAdvgoT/skgyIxaZL4HbcE+u7rJe+MTqdiBJXn4jQuTKGqv+fsNe2RH3AKN1huEgqsyq7zuIGHNOGwPTOGRWtSE+UfjsE1E7pXq2oBIyiANc5tTZB6L6F8ulIIq5EEBCFU6QVw1o3lJo693JvXUxwoExHDh5/UbQ7e1CeQt7ic4y6Rhv6b9S7ocTlUTVjV1dQMimVEnPBa6j91GyyTWxYFd/YHhk4TV2+BpgkOevI0ftuwERQvkIwE04hpUCUCH8AEkr3+EHHS+FDsZLntBFg9uJOre/XzvRZQkbJmIlNBAyxEcxejQWRMHWw19b6KDYLOPZj9CnazNSIs8gs8XsVAwyJrCq+GvLzrnAzy6EMAoRRoTZw==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(31686004)(66556008)(36756003)(8676002)(86362001)(66476007)(5660300002)(66574015)(53546011)(6486002)(8936002)(66946007)(38100700002)(31696002)(2616005)(186003)(956004)(4326008)(316002)(83380400001)(6916009)(16576012)(2906002)(26005)(508600001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?NrYlrCRGB3POCibaDa4PUFQ8WR4Qnj+GiZJLU3gpaLOjMvxJNQ2c15Yu8M1T?=
 =?us-ascii?Q?fObeSE9lAFxLxWq2oeKYwaMVquq6w9vvEb4KPktlSh6CvcXNGO2yKC7Oyq2j?=
 =?us-ascii?Q?5055BmMnd6lzuweUSPSbAlW0WlPSu1+FZnQM6Ji5TbXA9t0XOLjdlID3ZwUZ?=
 =?us-ascii?Q?iHjqPXBLqr7HIsbix8nRYFWn1H95hogZq7zEBLAOuF9JZllVTuICguvlsQZs?=
 =?us-ascii?Q?7Ud0Vf6O2ryYdvKmC+WNQ/QVtP9vgJSewPrJTbPNTGsYUZixl0109txGHRCO?=
 =?us-ascii?Q?K/vG6zOQvcf1ihsDhxSM2Lt3EhQq2hyCo23L1MXzcdC4K/OmztkY4R14aDMV?=
 =?us-ascii?Q?XBilSNJm4DohEz28unkCTbo6LARt1ZiZ5bfknmw1hlvog+UIHrJqt0+88UIL?=
 =?us-ascii?Q?LVEAmRrEz/RM6z64vTdkhKguTEqjcCh1fwgVX8ishxIfhMOrJBPEQ9LroggW?=
 =?us-ascii?Q?rr9dWJokc6kwOUklyRzii7EnK8u8jU8pygtj1AYD6IJ3PY8s17a7m58dchSQ?=
 =?us-ascii?Q?ovBB43KCBqmkFPXfBsUdJ21l4WG9lstHxRiMPXaxc1RiWtfhhrKbb9I8uc7v?=
 =?us-ascii?Q?HYxZHqcXuQihzcq3XW4lP/RUP0KnlLqQetwdG1KrIVFgrfBZTFB4Pw13pNu5?=
 =?us-ascii?Q?9mECau+l05NLE7hqIeuvYQCn4MuEnaqGOFUKXLbFKEw9u56VP8Mb8lbtcGO+?=
 =?us-ascii?Q?SvZknDX9PK0PZyNXrliJEa7cQ9HBL29KblmAC0eCwETGVNUNKkGyfROg9rhx?=
 =?us-ascii?Q?un35DISgH45VbsEyGWQ0alw1eWm4k5v1SMbajxb+dRJIiUvdJM6Bfx2Vbd7x?=
 =?us-ascii?Q?BpsU0wllfe2x1sQ/2zbSgbnig7A6mD44/4rSUa7UJCsZZlm1zQhzR4FXBiSF?=
 =?us-ascii?Q?aNA9ztxI7kg0RU/CW3v9ddU2ANigW/E+VgtZK07v3YeIRw0ydEAL/3aqjAMw?=
 =?us-ascii?Q?8h9wcPsQdYMJVEID1W0FKqFE1ErzA8DW07N2MVuywagohLHvzBVSxZRydpUi?=
 =?us-ascii?Q?1AxWQEO5CAALEkxDE6mYgwor0UeO4c3zZotrUIFTffL6K91y5jhfP2H0nrfU?=
 =?us-ascii?Q?rVqNckwkK7/l+Wc8zKrgqUrkSnJQgCfOBLpExZNbhurg0RELi0HEKUjyDMrR?=
 =?us-ascii?Q?eBjcZj7tRSsat9/IkvBWys2CmKid8tgpydBhmjT7N+qvdrAVkWY5n64iuvHC?=
 =?us-ascii?Q?IvO4AsHIv6BD/NXEOeoQ71g0XhV2Dg9MfLJbuuq7rDXIiChfOSgr7nUGAW6w?=
 =?us-ascii?Q?aIfK3BF9nzVJwUsgORFGe6vCUOgX/h/0LUsiJ3u8YkSnEVdIDUOfw8UiWrWU?=
 =?us-ascii?Q?lS6yavgJoAAupAe/0nImTl5x?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 43d97590-a756-4185-a342-08d98a3e4323
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Oct 2021 09:30:27.0479
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: w8Koxes2GUCVb67KomW363SQw8jpRXAZuTcS/hrtbYIRPAtJXDdSqrtd5N5RVC7gTW+Hx2MpQqu+kXxZvvey7Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5328

On 07.10.2021 17:10, Charles Gon=C3=A7alves wrote:
> During some experiments in my PhD I've tried to reused a code from
> Jann Horn (https://bugs.chromium.org/p/project-zero/issues/detail?id=3D11=
84
> ) that used the mapping in
>=20
> ```
> 0xffff804000000000 - 0xffff807fffffffff [256GB, 2^38 bytes, PML4:256]
> Reserved for future shared info with the guest OS (GUEST ACCESSIBLE)
> ```
> to map some temporary page table data to be able to attack the system.
>=20
> This used to work on Xen 4.6:
>=20
> ```
> #define MY_SECOND_AREA 0xffff804000000000ULL
> printk("PML4 entry: 0x%lx\n", (unsigned
> long)pgd_val(*pgd_offset(current->mm, MY_SECOND_AREA)));
> ```
>=20
> In xen 4.6 :
>=20
> `[ 3632.620105] PML4 entry: 0x183d125067 `
> Returns a valid PGD ( pgd_present(*pdg) =3D=3D true )
>=20
> but has different behavior in Xen 4.13 (despite no change in the
> asm-x86/config.h .
>=20
> In xen 4.13:
>=20
> `[70386.796119] PML4 entry: 0x800000021a445025`
> Return a bad PGD ( pgd_bad(*pdg) =3D=3D true )

There's nothing really bad in this entry afaics. The entry is r/o
and nx, yes, but that ought to be fine (i.e. I think pgd_bad() is
too rigid here, but may not be valid to be used on hypervisor
controlled entries in the first place).

> I could not find any reference on the branch RELEASE-4.13.0 of why
> this happens this way.
> Any hint of what is happening here?
> Has Xen changed the way it handles memory from regions in range
> 0xffff804000000000 - 0xffff807fffffffff  across those versions?

Yes - see a5a5d1ee949d ("x86/mm: Further restrict permissions on some
virtual mappings"). The page table arrangement underlying this VA
range isn't part of the ABI, i.e. we're free to change it at any time.

Jan



From xen-devel-bounces@lists.xenproject.org Fri Oct 08 09:36:30 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Oct 2021 09:36:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.204604.359767 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYmIh-0003Hh-G5; Fri, 08 Oct 2021 09:36:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 204604.359767; Fri, 08 Oct 2021 09:36:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYmIh-0003Ha-DA; Fri, 08 Oct 2021 09:36:23 +0000
Received: by outflank-mailman (input) for mailman id 204604;
 Fri, 08 Oct 2021 09:36:22 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=TEpG=O4=gmail.com=charles.fg@srs-us1.protection.inumbo.net>)
 id 1mYmIf-0003HU-UJ
 for xen-devel@lists.xen.org; Fri, 08 Oct 2021 09:36:22 +0000
Received: from mail-wr1-x432.google.com (unknown [2a00:1450:4864:20::432])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 8529afbc-ec75-4218-8564-d45b04a77cdb;
 Fri, 08 Oct 2021 09:36:20 +0000 (UTC)
Received: by mail-wr1-x432.google.com with SMTP id t8so27987919wri.1
 for <xen-devel@lists.xen.org>; Fri, 08 Oct 2021 02:36:20 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8529afbc-ec75-4218-8564-d45b04a77cdb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=KxPsuHHXR6kXB0FZjugaOY84qeJ3/5bFJ2P6FDCd7uI=;
        b=TYIoQhw61puQKy2Hl7+NwM0SNpSzqb94AR5vpaa5XPNnhMrvonRyhLnFbm8k0xtsj6
         VrNmgHox1+L3TyMrXDG0iGBF/spg15EyDdL60Zp655iWTAGIVsHVqFu3FdFUj5y+hGmB
         A2TfmxcpLGrJD5ZLOH4MXsKv6O3uTdw6MnE2IaGOXw02F7SwEz6e0BQaAKMyXTNWXUe0
         1Hz44e0Mlx+ZqckFR+xju8hIv50fyabVZfPvvMb8DNUkt1CCyw1xqaB7WjYnlAa/zJ+1
         JaGaV4sRmYjKu+kc1hVEgiiZD5Sm2PopXKKiNlcaraT7SOAZ0m6vTadu3+qyB1XdSOFr
         Uyvw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=KxPsuHHXR6kXB0FZjugaOY84qeJ3/5bFJ2P6FDCd7uI=;
        b=eQ/W+h0Eyz9sAG3E5L9xnw+i1FmmCgyDJp1zELOLZZkJihePZMORfud4ynBq8QigPI
         8oB9ZqaTlV7ApyHW2C4p21KxbHssG6nrNp87fIq0rP3sNdoEj2TaOTQgPv2hp7tKL6Oc
         F9zRcdwa2A89PHx2mCfYhO0vqqITXdDLMYFFAO9hk7onPVTgPMS0lUNiU/N94NJRMu1d
         e1loPdJ8K9ooO1U2twC4Hq6n9kJcss4DRxcgzJVyp5v5N4W41ND/RgkJ58MaKnc+RkJf
         gTGWntUTiZnWckQz9kucKzhqNKodgK7z7YpIo1A8CbPdoW0iR4DXfamUUpqmg84kja6P
         qgEg==
X-Gm-Message-State: AOAM530VbKWFSmO+VpuY9I+lKCZoiicPL931c58UPU1ihugIA8KCVj6M
	6xlF2JsZcf35XqgwXAbzRDZ4+byi2zLAKvZDpC8=
X-Google-Smtp-Source: ABdhPJxuecr+96oNujE7WfqtdF2LMH6GrPBJUQ90NJYnX81mMQMDrv7BDMaYFk7qqOTiHqr2vdYZt7Ze+QCEVEspflU=
X-Received: by 2002:a1c:ed0a:: with SMTP id l10mr2371693wmh.140.1633685779643;
 Fri, 08 Oct 2021 02:36:19 -0700 (PDT)
MIME-Version: 1.0
References: <CAAQRGoBQZ4mMWy2ibectwbN85oWvgcwus2rwO23u7BA7JWbf+A@mail.gmail.com>
 <4c622d73-6907-35aa-2701-4aea73fdb160@suse.com>
In-Reply-To: <4c622d73-6907-35aa-2701-4aea73fdb160@suse.com>
From: =?UTF-8?Q?Charles_Gon=C3=A7alves?= <charles.fg@gmail.com>
Date: Fri, 8 Oct 2021 10:36:07 +0100
Message-ID: <CAAQRGoA5MnfSfYdNeA=DKCGo+wMb0OZAtdqDJkEen00Uz3GnAQ@mail.gmail.com>
Subject: Re: PV - different behavior of pgd_offset in xen 4.6 and 4.13 for
 GUEST ACCESSIBLE memory area
To: Jan Beulich <jbeulich@suse.com>
Cc: xen-devel@lists.xen.org
Content-Type: multipart/alternative; boundary="0000000000009201e605cdd41c7d"

--0000000000009201e605cdd41c7d
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Thanks for pointing this fix Jan. It helped me a lot.
Best!

On Fri, Oct 8, 2021, 10:30 Jan Beulich <jbeulich@suse.com> wrote:

> On 07.10.2021 17:10, Charles Gon=C3=A7alves wrote:
> > During some experiments in my PhD I've tried to reused a code from
> > Jann Horn (
> https://bugs.chromium.org/p/project-zero/issues/detail?id=3D1184
> > ) that used the mapping in
> >
> > ```
> > 0xffff804000000000 - 0xffff807fffffffff [256GB, 2^38 bytes, PML4:256]
> > Reserved for future shared info with the guest OS (GUEST ACCESSIBLE)
> > ```
> > to map some temporary page table data to be able to attack the system.
> >
> > This used to work on Xen 4.6:
> >
> > ```
> > #define MY_SECOND_AREA 0xffff804000000000ULL
> > printk("PML4 entry: 0x%lx\n", (unsigned
> > long)pgd_val(*pgd_offset(current->mm, MY_SECOND_AREA)));
> > ```
> >
> > In xen 4.6 :
> >
> > `[ 3632.620105] PML4 entry: 0x183d125067 `
> > Returns a valid PGD ( pgd_present(*pdg) =3D=3D true )
> >
> > but has different behavior in Xen 4.13 (despite no change in the
> > asm-x86/config.h .
> >
> > In xen 4.13:
> >
> > `[70386.796119] PML4 entry: 0x800000021a445025`
> > Return a bad PGD ( pgd_bad(*pdg) =3D=3D true )
>
> There's nothing really bad in this entry afaics. The entry is r/o
> and nx, yes, but that ought to be fine (i.e. I think pgd_bad() is
> too rigid here, but may not be valid to be used on hypervisor
> controlled entries in the first place).
>
> > I could not find any reference on the branch RELEASE-4.13.0 of why
> > this happens this way.
> > Any hint of what is happening here?
> > Has Xen changed the way it handles memory from regions in range
> > 0xffff804000000000 - 0xffff807fffffffff  across those versions?
>
> Yes - see a5a5d1ee949d ("x86/mm: Further restrict permissions on some
> virtual mappings"). The page table arrangement underlying this VA
> range isn't part of the ABI, i.e. we're free to change it at any time.
>
> Jan
>
>

--0000000000009201e605cdd41c7d
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"auto">Thanks for pointing this fix Jan. It helped me a lot.<div=
 dir=3D"auto">Best!</div></div><br><div class=3D"gmail_quote"><div dir=3D"l=
tr" class=3D"gmail_attr">On Fri, Oct 8, 2021, 10:30 Jan Beulich &lt;<a href=
=3D"mailto:jbeulich@suse.com">jbeulich@suse.com</a>&gt; wrote:<br></div><bl=
ockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #=
ccc solid;padding-left:1ex">On 07.10.2021 17:10, Charles Gon=C3=A7alves wro=
te:<br>
&gt; During some experiments in my PhD I&#39;ve tried to reused a code from=
<br>
&gt; Jann Horn (<a href=3D"https://bugs.chromium.org/p/project-zero/issues/=
detail?id=3D1184" rel=3D"noreferrer noreferrer" target=3D"_blank">https://b=
ugs.chromium.org/p/project-zero/issues/detail?id=3D1184</a><br>
&gt; ) that used the mapping in<br>
&gt; <br>
&gt; ```<br>
&gt; 0xffff804000000000 - 0xffff807fffffffff [256GB, 2^38 bytes, PML4:256]<=
br>
&gt; Reserved for future shared info with the guest OS (GUEST ACCESSIBLE)<b=
r>
&gt; ```<br>
&gt; to map some temporary page table data to be able to attack the system.=
<br>
&gt; <br>
&gt; This used to work on Xen 4.6:<br>
&gt; <br>
&gt; ```<br>
&gt; #define MY_SECOND_AREA 0xffff804000000000ULL<br>
&gt; printk(&quot;PML4 entry: 0x%lx\n&quot;, (unsigned<br>
&gt; long)pgd_val(*pgd_offset(current-&gt;mm, MY_SECOND_AREA)));<br>
&gt; ```<br>
&gt; <br>
&gt; In xen 4.6 :<br>
&gt; <br>
&gt; `[ 3632.620105] PML4 entry: 0x183d125067 `<br>
&gt; Returns a valid PGD ( pgd_present(*pdg) =3D=3D true )<br>
&gt; <br>
&gt; but has different behavior in Xen 4.13 (despite no change in the<br>
&gt; asm-x86/config.h .<br>
&gt; <br>
&gt; In xen 4.13:<br>
&gt; <br>
&gt; `[70386.796119] PML4 entry: 0x800000021a445025`<br>
&gt; Return a bad PGD ( pgd_bad(*pdg) =3D=3D true )<br>
<br>
There&#39;s nothing really bad in this entry afaics. The entry is r/o<br>
and nx, yes, but that ought to be fine (i.e. I think pgd_bad() is<br>
too rigid here, but may not be valid to be used on hypervisor<br>
controlled entries in the first place).<br>
<br>
&gt; I could not find any reference on the branch RELEASE-4.13.0 of why<br>
&gt; this happens this way.<br>
&gt; Any hint of what is happening here?<br>
&gt; Has Xen changed the way it handles memory from regions in range<br>
&gt; 0xffff804000000000 - 0xffff807fffffffff=C2=A0 across those versions?<b=
r>
<br>
Yes - see a5a5d1ee949d (&quot;x86/mm: Further restrict permissions on some<=
br>
virtual mappings&quot;). The page table arrangement underlying this VA<br>
range isn&#39;t part of the ABI, i.e. we&#39;re free to change it at any ti=
me.<br>
<br>
Jan<br>
<br>
</blockquote></div>

--0000000000009201e605cdd41c7d--


From xen-devel-bounces@lists.xenproject.org Fri Oct 08 09:36:30 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Oct 2021 09:36:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.204605.359779 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYmIj-0003Y9-S2; Fri, 08 Oct 2021 09:36:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 204605.359779; Fri, 08 Oct 2021 09:36:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYmIj-0003Y0-O5; Fri, 08 Oct 2021 09:36:25 +0000
Received: by outflank-mailman (input) for mailman id 204605;
 Fri, 08 Oct 2021 09:36:24 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mYmIi-0003TN-4L; Fri, 08 Oct 2021 09:36:24 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mYmIh-0008Tc-Re; Fri, 08 Oct 2021 09:36:23 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mYmIh-0003Ra-Jn; Fri, 08 Oct 2021 09:36:23 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mYmIh-0006or-J3; Fri, 08 Oct 2021 09:36:23 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=DnlRwm/IKPWwaaI4YuNoPJ4WQLtRPEpNu+8VsLLwCAY=; b=gaXrnG+aAwmLju89HcC0sPggnt
	3bHvKzTuIFN6ynJf3L5yZjx3EPXadStq+GjV0vQ5cqYCZmp+3wdFkbjwvg3W54JjdYvVMntztCTQU
	oLEuQUrDnGzIvT5Agmb1HHpI/3tlwaMwfUmneaJ/FqyLJd45dZub3q3+P8ghHXC3r6rs=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165408-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 165408: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-unstable:test-amd64-amd64-examine:memdisk-try-append:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=192aaf7e146c0b41dbdd35ccdb13eb33ced13633
X-Osstest-Versions-That:
    xen=d6bdad32cbb5dfbc68fac32078cc5882071c4f1d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 08 Oct 2021 09:36:23 +0000

flight 165408 xen-unstable real [real]
flight 165427 xen-unstable real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/165408/
http://logs.test-lab.xenproject.org/osstest/logs/165427/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-examine      4 memdisk-try-append  fail pass in 165427-retest
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 165427-retest

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 165388
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 165388
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165388
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165388
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 165388
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 165388
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 165388
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 165388
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 165388
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 165388
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165388
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 165388
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  192aaf7e146c0b41dbdd35ccdb13eb33ced13633
baseline version:
 xen                  d6bdad32cbb5dfbc68fac32078cc5882071c4f1d

Last test of basis   165388  2021-10-05 19:07:00 Z    2 days
Testing same since   165408  2021-10-07 08:12:48 Z    1 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Ivan Kardykov <kardykov@tabit.pro>
  Jan Beulich <jbeulich@suse.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 fail    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   d6bdad32cb..192aaf7e14  192aaf7e146c0b41dbdd35ccdb13eb33ced13633 -> master


From xen-devel-bounces@lists.xenproject.org Fri Oct 08 10:26:07 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Oct 2021 10:26:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.204626.359792 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYn4h-0000cQ-Js; Fri, 08 Oct 2021 10:25:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 204626.359792; Fri, 08 Oct 2021 10:25:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYn4h-0000cJ-Gi; Fri, 08 Oct 2021 10:25:59 +0000
Received: by outflank-mailman (input) for mailman id 204626;
 Fri, 08 Oct 2021 10:25:58 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ioNN=O4=gmail.com=olekstysh@srs-us1.protection.inumbo.net>)
 id 1mYn4g-0000cD-Fa
 for xen-devel@lists.xenproject.org; Fri, 08 Oct 2021 10:25:58 +0000
Received: from mail-ed1-x530.google.com (unknown [2a00:1450:4864:20::530])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id ac96b09d-82ab-4d44-920a-9a7adf7de018;
 Fri, 08 Oct 2021 10:25:57 +0000 (UTC)
Received: by mail-ed1-x530.google.com with SMTP id b8so34472643edk.2
 for <xen-devel@lists.xenproject.org>; Fri, 08 Oct 2021 03:25:56 -0700 (PDT)
Received: from [192.168.1.7] ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id q14sm752528eji.63.2021.10.08.03.25.54
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Fri, 08 Oct 2021 03:25:55 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ac96b09d-82ab-4d44-920a-9a7adf7de018
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-transfer-encoding:content-language;
        bh=Ic7vekBz5aT8agS7JiQ12kPI052ZpnrnGj83kdhfE3M=;
        b=LTCm+HZROR+zElMlres5bXZ/5RZAIz/AontDMbiub2SVLa5F1TwIUKIxm0lGfkeOMR
         v1XKiDND10sU5kBJ+zQyuompNTLJSGpUuAPmtlnvOavNvI5pmmzzG6xM4bxrZn+5oCz0
         92YDy+w+X9VH5/bf2ZugixGcqCfloKp1GAWjznwNDBns65rcwJgBTqu61WjT8jdxrN+9
         p/EYW65XX0UBYsiU7uI05TJkFnmRdVk2n1/v4hbO9F83Ts55kOtDNfsPoyh//FqU257P
         Y4rWXOg4e3Ghu9hYW0HCLOIfNbgNpf2TLXLL7kGaaNS8Qfg7fBQvtAhNNFAOGNvKVX4I
         G8TA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding
         :content-language;
        bh=Ic7vekBz5aT8agS7JiQ12kPI052ZpnrnGj83kdhfE3M=;
        b=D9tDT7PCnP2BU/cW7/tHCr0cKPPYDxPJIlPCWMo0XtadlZQ//sBxdCPlrVZ17cNxWd
         y8L0icxVja077LUOg3aTIZQzkyHTcNBL96ullfx73JufN3y+SIQPM2E/ME3keOU/czEg
         MBEVeKla8p15OZFxgUkeE5W02Wg1VAaG5b++qTp1Mu1ypfY0t4sarzkPLyZeRokk/TGs
         QRrLAkFLSKrFtFvbnM+w6mg9QrrHoTBAtbXMtZknkndkarbEBl9qUc07sYikAqRlM4x7
         mU87b70DUpn8CMrEo5nnCyWvuyCtzqbSiZNPk1e0KyY/vvWdPXK7sGqTfw9LC4m6L6zF
         crdA==
X-Gm-Message-State: AOAM532iMj4CeRh7VzsYaOQfuPkqZsUFU9+9KFUo4wF45Ihq6OE8bQNH
	m3LfGyzr8w6AG2Xq1s+4uzK4gFKMU2U=
X-Google-Smtp-Source: ABdhPJxqXYdK5ELNh0qJ8A7237U87sT02rnCqLr4Kg8oQ0LpepU1JkcLwaMtEWpEvzTZsz3zlfFo0w==
X-Received: by 2002:a05:6402:50cc:: with SMTP id h12mr14200085edb.112.1633688755691;
        Fri, 08 Oct 2021 03:25:55 -0700 (PDT)
Subject: Re: [PATCH V5 1/3] xen/arm: Introduce gpaddr_bits field to struct
 xen_arch_domainconfig
To: Jan Beulich <jbeulich@suse.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>,
 Anthony PERARD <anthony.perard@citrix.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Juergen Gross <jgross@suse.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 xen-devel@lists.xenproject.org
References: <1633519346-3686-1-git-send-email-olekstysh@gmail.com>
 <1633519346-3686-2-git-send-email-olekstysh@gmail.com>
 <68cb29bb-7d84-dc27-eead-4a079b9caf68@suse.com>
 <e77eea6f-163d-0920-2e90-fb9f3a602743@gmail.com>
 <ffb40f3b-2394-7747-2c06-955e2aa87cfc@suse.com>
 <387608b9-c7b2-e814-7fa5-a262acc0c73d@gmail.com>
 <ae852345-66ff-7bcf-f68e-2161e23933a1@suse.com>
 <alpine.DEB.2.21.2110071311450.414@sstabellini-ThinkPad-T480s>
 <b8e868a2-9af3-de6c-0683-4bb2ff7821f3@suse.com>
From: Oleksandr <olekstysh@gmail.com>
Message-ID: <b36e5fb7-6ed0-dc7d-5ed3-c3c9c9ae70b5@gmail.com>
Date: Fri, 8 Oct 2021 13:25:54 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <b8e868a2-9af3-de6c-0683-4bb2ff7821f3@suse.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US


On 08.10.21 11:13, Jan Beulich wrote:

Hi Jan

> On 07.10.2021 22:23, Stefano Stabellini wrote:
>> On Thu, 7 Oct 2021, Jan Beulich wrote:
>>> On 07.10.2021 15:12, Oleksandr wrote:
>>>> On 07.10.21 15:43, Jan Beulich wrote:
>>>>
>>>> Hi Jan.
>>>>
>>>>> On 07.10.2021 14:30, Oleksandr wrote:
>>>>>> On 07.10.21 10:42, Jan Beulich wrote:
>>>>>>> On 06.10.2021 13:22, Oleksandr Tyshchenko wrote:
>>>>>>>> Changes V4 -> V5:
>>>>>>>>       - update patch subject and description
>>>>>>>>       - drop Michal's R-b
>>>>>>>>       - pass gpaddr_bits via createdomain domctl
>>>>>>>>         (struct xen_arch_domainconfig)
>>>>>>> I'm afraid I can't bring this in line with ...
>>>>>>>
>>>>>>>> --- a/xen/include/public/arch-arm.h
>>>>>>>> +++ b/xen/include/public/arch-arm.h
>>>>>>>> @@ -333,6 +333,11 @@ struct xen_arch_domainconfig {
>>>>>>>>          *
>>>>>>>>          */
>>>>>>>>         uint32_t clock_frequency;
>>>>>>>> +    /*
>>>>>>>> +     * OUT
>>>>>>>> +     * Guest physical address space size
>>>>>>>> +     */
>>>>>>>> +    uint8_t gpaddr_bits;
>>>>>>> ... this being an OUT field. Is this really what Andrew had asked for?
>>>>>>> I would have expected the entire struct to be IN (and the comment at
>>>>>>> the top of the containing struct in public/domctl.h also suggests so,
>>>>>>> i.e. your new field renders that comment stale). gic_version being
>>>>>>> IN/OUT is already somewhat in conflict ...
>>>>>> I am sorry but I'm totally confused now, we want the Xen to provide
>>>>>> gpaddr_bits to the toolstack, but not the other way around.
>>>>>> As I understand the main ask was to switch to domctl for which I wanted
>>>>>> to get some clarification on how it would look like... Well, this patch
>>>>>> switches to use
>>>>>> domctl, and I think exactly as it was suggested at [1] in case if a
>>>>>> common one is a difficult to achieve. I have to admit, I felt it was
>>>>>> indeed difficult to achieve.
>>>>> Sadly the mail you reference isn't the one I was referring to. It's not
>>>>> even from Andrew. Unfortunately I also can't seem to be able to locate
>>>>> this, i.e. I'm now wondering whether this was under a different subject.
>>>>> Julien, in any event, confirmed in a recent reply on this thread that
>>>>> there was such a mail (otherwise I would have started wondering whether
>>>>> the request was made on irc). In any case it is _that_ mail that would
>>>>> need going through again.
>>>> I think, this is the email [1] you are referring to.
>>> Well, that's still a mail you sent, not Andrew's. And while I have yours
>>> in my mailbox, I don't have Andrew's for whatever reason.
>>>
>>> Nevertheless there's enough context to be halfway certain that this
>>> wasn't meant as an extension to the create domctl, but rather a separate
>>> new one (merely replacing what you had originally as a sysctl to become
>>> per-domain, to allow returning varying [between domains] values down the
>>> road). I continue to think that if such a field was added to "create",
>>> it would be an input (only).
>> During the Xen Community Call on Tuesday, we briefly spoke about this.
>> Andrew confirmed that what he meant with his original email is to use a
>> domctl. We didn't discuss which domctl specifically.
>>
>> This patch now follows the same pattern of clock_frequency and
>> gic_version (see xen/include/public/arch-arm.h:struct xen_arch_domainconfig).
>> Note that gic_version is an IN/OUT parameter, showing that if in the
>> future we want the ability to set gpaddr_bits (in addition to get
>> gpaddr_bits), it will be possible.
> Well, as said before - I'm not convinced gic_version being IN/OUT is
> appropriate. At the very least a 2nd way to merely retrieve the value
> would seem to be necessary, so that it's not only the party creating
> the guest which would be able to know.
>
> Since here's we're solely after retrieving the value, I don't see
> the point in altering "create". As you say, domctl can be changed,
> and hence at the point this needs to become an input to "create", it
> could easily be added there.
>
> Jan

Just a quick question. What do you think can XEN_DOMCTL_getdomaininfo be 
reused to retrieve gpaddr_bits? I don't see why not at the moment, but 
maybe there are some implications/concerns which are invisible to me.

I see that arch_get_domain_info() is present, so the field will be 
common, and each arch will write a value it considers
appropriate. This could be a good compromise to not add an extra domctl 
and to not alter domain_create.


-- 
Regards,

Oleksandr Tyshchenko



From xen-devel-bounces@lists.xenproject.org Fri Oct 08 10:48:04 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Oct 2021 10:48:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.204639.359803 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYnPq-0003An-JN; Fri, 08 Oct 2021 10:47:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 204639.359803; Fri, 08 Oct 2021 10:47:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYnPq-0003Ag-GF; Fri, 08 Oct 2021 10:47:50 +0000
Received: by outflank-mailman (input) for mailman id 204639;
 Fri, 08 Oct 2021 10:47:49 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=aYfl=O4=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mYnPo-0003Aa-VF
 for xen-devel@lists.xenproject.org; Fri, 08 Oct 2021 10:47:48 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 41a1fc1f-246f-4a3b-be44-cfe745078ab3;
 Fri, 08 Oct 2021 10:47:48 +0000 (UTC)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2175.outbound.protection.outlook.com [104.47.17.175])
 (Using TLS) by relay.mimecast.com with ESMTP id
 de-mta-26-ugdX56OXNgSe4B5hJIwZJg-1; Fri, 08 Oct 2021 12:47:46 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB4189.eurprd04.prod.outlook.com (2603:10a6:803:3d::26)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.20; Fri, 8 Oct
 2021 10:47:45 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4587.022; Fri, 8 Oct 2021
 10:47:45 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS8PR04CA0203.eurprd04.prod.outlook.com (2603:10a6:20b:2f3::28) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.19 via Frontend
 Transport; Fri, 8 Oct 2021 10:47:44 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 41a1fc1f-246f-4a3b-be44-cfe745078ab3
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1633690067;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding;
	bh=9s2IautVYl4D5pfVLFGkSQ1cWlKhosK88UYdKSUX130=;
	b=EdHN/uMcQV1ikcEEu9DQRokxadvU6Bgtpe0YAtWhHUxn2c78mT4358cz9BGtHOAdRo/zdK
	Fo+gHwb+JZMEHT+bhjLdLw0Q4d7BGEWIZP7W/1C3py2zDi6I2qgEjGec+YKHPnbSWhu0tc
	m1pdtXny0XQobWsyss6/K4TFWSTzJYc=
X-MC-Unique: ugdX56OXNgSe4B5hJIwZJg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ZHgJNgdklqD9gAmLSAOWS7OfRmyb8oIA6zZBeYRRBmhIsun23f/5xuf3Ot8BkInAY47OJjddXRFiziyTlpP+yokls1Z8BJq0zSO+IZsmEmS2RdJv0OeETkQd9XA256+XBLHOHiF6RWxaBnZymH2zBZAlqbkpP3JjPQqeQ5r9ZdLbsl49QenysRIqTNRKY7cGA/C+2mWDuUmNFPn1d1Vfq8ErUc8Qk3eUhYa1FhIAFBKTpT9ZLpYPZ669JCtMjQjh49DpA+LLSWAqsPcpmpXAauKHbZkg5QipTOeK8py88CI2bIV6cl1KNR+TMPUWXOtpDkqs8S84WWEFEpB0Q6gL/w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=9s2IautVYl4D5pfVLFGkSQ1cWlKhosK88UYdKSUX130=;
 b=N3CxdDc13o5Ba7V8J48cIQq/EXaO8ZB/m7Y0pzorXwSkgkVmNvuATNEE4LPRHL2oHMYD0n8vWnc72lOS4QahlA7mwSowJOHy1iXYBDdkH8Bw1VEwEDgVv18sPtjvTd3xZQFI52hrzX+9qCAxvNVb/cCgg5DFsQ20fg32LZBOI4Ym5ek5waP5hq3G3jGKYx510pUx+ie6ex08gvejeuNFDh7kZOlipFp0tHzveAoVTmrdI8Q8OpAHjIXkiRcRAwWGxVzLO+M6WQm3thwzBURBJ7/EWOFar49ORhmkJRW3MWt/MEghjfQeOLgnanLTXS4OSJYg/S2Ry6dZrO5BT1s/PQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: citrix.com; dkim=none (message not signed)
 header.d=none;citrix.com; dmarc=none action=none header.from=suse.com;
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
Subject: [PATCH] x86/PV32: fix physdev_op_compat handling
Message-ID: <e8d21433-2f4f-f662-dd45-1543da8f4caf@suse.com>
Date: Fri, 8 Oct 2021 12:47:41 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8PR04CA0203.eurprd04.prod.outlook.com
 (2603:10a6:20b:2f3::28) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 5fce2384-6c95-44fc-daf3-08d98a490fbc
X-MS-TrafficTypeDiagnostic: VI1PR04MB4189:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB4189181759339B28DA7B6CA2B3B29@VI1PR04MB4189.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8273;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	b6eUIsqSevdIxG2gqHxMmMNr8IAtqyqwJnEOW3Eni9XsWsGj8iM2WdDm9lqpZsd5X/1L1eT0IaLglH2B+JhKvliRHvwtACkV0uXVbVeX5H3JBvzIFl/LU7q1eGAosCg4OyeIgRgU/P+1G7qRfCizy/8XTxsjH5cGVM7cjsDkep1QwF2Fj0iyN6zyklrIa/IjcTL82YL7sy1Ea/2npWb5ouour76l24OBpGL8cF5PQUU81v2i57JIaHbqurK4cCCeQ82kkyXzN+GTnDRu/hYq8ICJbR68axof3VeJYYBaxlYXWW1xQ2DIO+8QPFmZsKMfhgry2vvInMxBXr5fMDArlYGll4Q73OgJ1C9MmJ3LueUqMCb69SDDEdBaWcQCUT3+fBCcDA0u0Kv/dss2E3N3CYbvmYKV5E4glSkOQuOb8mKddQAouORzgMk2U/WeQ1qg0HGKwjeMfga4MIjY3eXdapigfdBQs3gHacJqQUiR40C/cmw+U4POAkBgx6d5rFTdBpvtUi+ZbG2sEmOA1q/fadjJJcU0xd23s0rsu5bD5dPZevGapVnA9UkoJ1eT6tUT0kkl+wUvEH/QUBzmcGkCHZ/rxSEFC5Ul7cSY5E0UjKnPxzSKqDzyaQSogPsUmHdKarZvc6uneM8Yc8/x7jpElG/Xn9QuBKoTIVdAU45ifByh3yOcJ/Hmo4R2Cp4ArR5D2z//s5fssm20mwEiz8hiwp4z6IAgy7+YrXE4euHuAe2JXW81RKNWHWwn7KfnkK/I
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(508600001)(8936002)(66946007)(31686004)(54906003)(86362001)(8676002)(26005)(316002)(31696002)(5660300002)(6916009)(6666004)(38100700002)(956004)(16576012)(2616005)(6486002)(2906002)(4326008)(36756003)(66556008)(66476007)(186003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?dCtXdmtBRFBpOVN6YUlvdjJTc1I5ZTBkZXdnM21HcUUxTTczNTVtK2RCQVc3?=
 =?utf-8?B?UWNtWG13K3BoWnBGbFpPUnZXQkE1bDdKZFl1cmZxT2J5RStHd0FLK3k3N2FZ?=
 =?utf-8?B?bUJmTTdKcEVOQnhtUFU1WExvUWZKdStzbjljVVNOV2VSeXRnRlhsM0Q3bE9h?=
 =?utf-8?B?UWMxMjFqYy9XSzZoZjR0RmVrYnJhc09jU3IwZDR0RkNVSFkzT2Y0SFNxMElw?=
 =?utf-8?B?TTNzYjFFcllGZW5vd2JtOWJCeVAyTUh4RDkrSGkrRVlBek5QSmNhOUpWZ0Fp?=
 =?utf-8?B?YWVaT1NIcm4rYTlTLzR0QzhSQXo3WVJtS2phbUhRYVFpMWkrK0ZIMDVvS1l6?=
 =?utf-8?B?NUwvVGNUUS9yVlVWcm5UaS9DVzNOd0Jid0pvS0k2Y016YmlPTzZSVUVtV3dv?=
 =?utf-8?B?RGJpNUJFaEVwbHdFWmoraFhKS3M4S21LRTk0ZkhQZml1RkJCeGdlbVg0M1R0?=
 =?utf-8?B?SU9ZMEpXd1EvMk9YMDF5MDNNcmxjc3pVR29kZXNXQllrdFYzN2JXTXFuVUdN?=
 =?utf-8?B?SU9JR0pCYjlHb3ZZODhTRnRYL2NXdThLVGlRNFFYb1NqeHFDekJ5ai9ZbU5Y?=
 =?utf-8?B?QUgzOXgxMlFoSnRlNzZhUWxxVklod2dUb2VOYWhwZTNOYldIMUZjLzY2TXVo?=
 =?utf-8?B?UHZaRGFxL2dMYUlpQXRQampYZHJneFNMWmlnV2RGMzgrK0NHUDRpb0UvMUpF?=
 =?utf-8?B?UmFJemVqWHFySEJKUFk5eVN4b2tBSnN5Vm5lUm51TGQwUVZXVDhYdStSQjRr?=
 =?utf-8?B?ZU9hQ2cwTnBtMVczaU03MmUvMWxabmZOR2o2Y08xRDFuRDBidkdmMnFjbk1k?=
 =?utf-8?B?S0RMTDd4dlo4ZSt4YkcwRllmWDF5c3lDWXBjK3IzWkZ6WnhGYU9ZQXFlQWFD?=
 =?utf-8?B?dW5aZXJxNVFRdFJaVnNqcnhsVTNld0RteisyUTdNbVdzV0UwRk5FakR1Tngw?=
 =?utf-8?B?YUxod0N4eGJNMWpFNkxIU3dlQkRMSGs2MXZwUU9BOGRKY0F6VEk5ZDZIYVNq?=
 =?utf-8?B?QUs4MDhxeWd6SjBPb2tUalFrVUxaNUdFSHhMMmQwanlzZmRvNVhNaXgvSWpD?=
 =?utf-8?B?dHQ4YkhkemF2dUxWSTBXK1RLNE5FOUNTc3BNU1A3MzFhUFZXeUc2dEpHOXpl?=
 =?utf-8?B?Y3NkditIMVJJWkFjQ1VkYk5Ub1dONmlYMCtQWkdoTGVFWDYvNVhEcCtPQk9m?=
 =?utf-8?B?WTUwWnQ0WTdmZXZ0Zlpxcm1Gc2JLSjY1YXhQYU0vN0RBWWdPalBZQnBoQjRS?=
 =?utf-8?B?dUpBTmdLYnoyVXFWdXpkN1VHWlRkeTBrOE9BczNDSk9KWGNDU1JLVVlJMmhs?=
 =?utf-8?B?U1IvNUc4bTI2ejkrYzh5Nm1HSkI3SXFCV0VkYWdtcmJpeVhTcVZrQmEwR3BB?=
 =?utf-8?B?VzRzODFWVmkvTytPRDBHYVNuU1pYMkdEM0dOcFJBclc2dDFST1M0N2paaFZE?=
 =?utf-8?B?blhLSWk0bGVVekhxTnBrcEtaWml3djg2K0ZUQ2FoaGtXbm8yaHdYSjEvSS9u?=
 =?utf-8?B?cjRZYnVTTFhOMk1kY0Y1VmpsRS9kYVlOdnRDUzFnOXhDUHlYeVhDWm1LQmtt?=
 =?utf-8?B?TlFBSnBBRzgxdFAxQlF4TkRnMTJsMmFqWDZFQXpWM1l2UnVpbTZlOVkxR2M1?=
 =?utf-8?B?SzJzRkp3RjBlS0ZqQU81cWRMck8xSXpTd3BkUEkvVThvcmtCL21JTE1RYnl6?=
 =?utf-8?B?Z2ZQSlNXV2kvSVJLbm1IMXF0MkhxYW5qWnlIQ1BGUHF0SGRuMlFsVDVnOWVV?=
 =?utf-8?Q?2VLws5di60BN/ufYHzFcI04aeEGUf/oGnwlwgXb?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5fce2384-6c95-44fc-daf3-08d98a490fbc
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Oct 2021 10:47:45.2075
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: e8dsrn1vbJbqUjyaRuogihCRo8KFUM4nsdeNUZmIjjtgUf0SlThKygCI7oZAhmf0Nl068MOBlnf3FuEAHBfXBQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4189

The conversion of the original code failed to recognize that the 32-bit
compat variant of this (sorry, two different meanings of "compat" here)
needs to continue to invoke the compat handler, not the native one.
Arrange for this and also remove the one #define that hasn't been
necessary anymore as of that change.

Affected functions (having existed prior to the introduction of the new
hypercall) are PHYSDEVOP_set_iobitmap and PHYSDEVOP_apic_{read,write}.
For all others the operand struct layout doesn't differ.

Fixes: 1252e2823117 ("x86/pv: Export pv_hypercall_table[] rather than working around it in several ways")
Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
Additionally the XSA-344 fix causes guest register corruption afaict,
when EVTCHNOP_reset gets called through the compat function and needs a
continuation. While guests shouldn't invoke that function this way, I
think we would better have forced all pre-3.2-unavailable functions into
an error path, rather than forwarding them to the actual handler. I'm
not sure though how relevant we consider it to fix this (one way or
another).

--- a/xen/arch/x86/x86_64/compat.c
+++ b/xen/arch/x86/x86_64/compat.c
@@ -10,8 +10,8 @@ EMIT_FILE;
 
 #define physdev_op                    compat_physdev_op
 #define physdev_op_t                  physdev_op_compat_t
-#define do_physdev_op                 compat_physdev_op
 #define do_physdev_op_compat(x)       compat_physdev_op_compat(_##x)
+#define native                        compat
 
 #define COMPAT
 #define _XEN_GUEST_HANDLE(t) XEN_GUEST_HANDLE(t)



From xen-devel-bounces@lists.xenproject.org Fri Oct 08 11:09:36 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Oct 2021 11:09:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.204648.359815 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYnkn-0005ax-D7; Fri, 08 Oct 2021 11:09:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 204648.359815; Fri, 08 Oct 2021 11:09:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYnkn-0005aq-9g; Fri, 08 Oct 2021 11:09:29 +0000
Received: by outflank-mailman (input) for mailman id 204648;
 Fri, 08 Oct 2021 11:09:27 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=mH1P=O4=citrix.com=anthony.perard@srs-us1.protection.inumbo.net>)
 id 1mYnkl-0005af-GN
 for xen-devel@lists.xenproject.org; Fri, 08 Oct 2021 11:09:27 +0000
Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 2be48f66-4f30-4d0d-9a86-d9865452f646;
 Fri, 08 Oct 2021 11:09:25 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2be48f66-4f30-4d0d-9a86-d9865452f646
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1633691365;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=YxY0sOwpETLYOWHp0bcqce/rwco8K0eGG+glITyZYFY=;
  b=KlCwO4PfAXZdTcpqDbRF0Zi7KINwmjZkjUgS3evYWHyEynKKdS2Ae9+w
   NemlAOPT5x0C6JLkRcC4PvYAIUc0uueF1Y3beQfcIsWGuSjoQeOFTEu+m
   iBNp7lJ9rZf+G+DmEHdyTul4cFOwpMCn0VtM+58B09nqjniBKgUUUSZ80
   c=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: b/f97Aaf5KdqUGi86QjyvAo4ziU8Bm2NDERMri8xD50iAzl37v+lKFsunxwUBAaqr4HC3lQkry
 Ys3jrMJ0HzkdM0KMpZhCjGyLW2Eco4Z5tTz5EcWiJy8LaWdiKxPINs+6i86BDOeu2CwZzSIAXa
 UZdBRoa0PUGFz+jtA37pcX/2QvutTE/HeRNT0q0gw0KZTYXppxHLwo/sqN2DdjGfE5HDGmYb9p
 MMAk6DIeslc1oDlYSfFLw6k7Bxp92nl56GPdt2dE7yrEEx5FVMDNSl7iapAyXbf8HSwNdDODCW
 Af15SUW9xan6mqxYsFYcH723
X-SBRS: 5.1
X-MesageID: 54689815
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:LggiqKMo7wf7SDjvrR1rkMFynXyQoLVcMsEvi/4bfWQNrUoi1DMBz
 2YdC2GDMviDajf0e9wlbo/g9kkGvJHWmtNiHQto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdpJYz/uUGuCJQUNUjMlkfZKhTr6ZUsxNbVU8En540Uozw7dRbrNA2rBVPSvc4
 bsenOWHULOV82Yc3rU8sv/rRLtH5ZweiRtA1rAMTakjUGz2zhH5OKk3N6CpR0YUd6EPdgKMq
 0Qv+5nilo/R109F5tpICd8XeGVSKlLZFVDmZna7x8FOK/WNz8A/+v9TCRYSVatYowyPksAt2
 fNsjt+9Rx4kb4OTmfY4TjANRkmSPYUekFPGCX22sMjVxEzaaXr8hf5pCSnaP6VBpLwxWzsXs
 6VFdnZdNXhvhMrvqF6/YuBqmsQkKtitJI4Fs2ts5TrYEewnUdbIRKCiCdpwgWtu1pEeRKu2i
 8wxQztsZQjYPkd1MGwuLKhvpsqxhnDWWmgNwL6SjfVuuDWCpOBr65DyNPLFd9rMQt9a9m6Iq
 2SD82nnDxUyMN2E1SHD4n+qnvXIny7wRMQVDrLQ3vxgjUCXx2cTIAYLTlb9qv684nNSQPoGd
 RZSoHB36/Fvqgr7FbERQiFUvla9uBMMB8t2MtZ55Q+Ux/v6vAeLI3UtG2sphMMdiOc6Qjkj1
 1msltzvBCByvLD9dU9x5ot4vhvoZ3FKfDZqiTssCFtduoa/8OnfmzqVFr5e/LiJYsoZ8N0a6
 x6NtjR2o7wOgcMR26y/8DgraBr3/cORH2bZCujNN19JDz+Vhqb5OeRECnCBtJ6sybp1qHHa5
 xDofODEvIgz4WmlznDlfQn0NOjBCwy5GDPdm0VzOJIq6i6g/XWuFagJvmolehwzaZ5UIGezC
 KM2he+3zMQIVJdNRfUnC79d9uxwlfSwfTgbfqq8giVyjmhZK1bcoXAGib+41GHxikk8+ZzTy
 r/AGftA+U0yUPw9pBLvHr91+eZymkgWmDOCLbimnk/P+efPOxaopUItbQLmghYRt/jf/m04M
 r93aqO39vmoeLSmOHeIqtRPcQliwLpSLcmelvG7v9WremJOcFzNwdeKqV/4U4A6zalTiMnS+
 XSxBh1RxFbl3CWVIgSWcHFzLrjoWM8n/348OCUtO3eu2mQiPtnzvPtOKcNvcOl17vFnwN51U
 +IBJ5eKDMNQR2mV4D8ad5T88tBvLUz5mQKUMiO5SzEjZJo8FRfR89rpc1K3pikDBya6r+Ukp
 Lik2l+JSJYPXV06Xs3XdOiu3xW6un1EwLB+WE7BI99yfkTw8dc1d3yt36Fve8xVcEfN3DqX0
 QqSECw0n+iVrt9n6sTNiICFs5ytT7l0EH1FEjSJ9r2xLyTboDaumNcSTOaScDnBf2ro46H+N
 /5NxvTxPfBbzlZHt41wT+Riwa4kvoa9orZbykJvHWnRbkTtAbRleyHU0c5Kv6xL57lYpQrpB
 R7fpogEYe2EaJH/DVocBAs5deDSh/gblw7b4ekxPEintjR8+6CKUBkKMhSB4MCHwGCZ7G/xL
 T8dhfMr
IronPort-HdrOrdr: A9a23:I52lGKvqreJ49r1yY+wLPSDL7skDSdV00zEX/kB9WHVpm5Sj5q
 WTdYcgpHvJYVcqKQgdcL+7WZVoLUm3yXcx2/hyAV7AZnifhILLFuFfBOLZqlWKJ8S9zJ8/6U
 4KScRD4ajLY2SS+vyU3ODXKbsdKZK8gceVbK/lvhFQcT0=
X-IronPort-AV: E=Sophos;i="5.85,357,1624334400"; 
   d="scan'208";a="54689815"
Date: Fri, 8 Oct 2021 12:09:03 +0100
From: Anthony PERARD <anthony.perard@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, "Andrew
 Cooper" <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>, Roger Pau
 =?iso-8859-1?Q?Monn=E9?= <roger.pau@citrix.com>
Subject: Re: [PATCH] x86/build: suppress EFI-related tool chain checks upon
 local $(MAKE) recursion
Message-ID: <YWAmz5+5cufR1lKi@perard>
References: <8457d422-4db9-59b9-d0c9-663430dad955@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <8457d422-4db9-59b9-d0c9-663430dad955@suse.com>

On Tue, Sep 21, 2021 at 05:43:38PM +0200, Jan Beulich wrote:
> The xen-syms and xen.efi linking steps are serialized only when the
> intermediate note.o file is necessary. Otherwise both may run in
> parallel. This in turn means that the compiler / linker invocations to
> create efi/check.o / efi/check.efi may also happen twice in parallel.
> Obviously it's a bad idea to have multiple producers of the same output
> race with one another - every once in a while one may e.g. observe
> 
> objdump: efi/check.efi: file format not recognized
> 
> We don't need this EFI related checking to occur when producing the
> intermediate symbol and relocation table objects, and we have an easy
> way of suppressing it: Simply pass in "efi-y=", overriding the
> assignments done in the Makefile and thus forcing the tool chain checks
> to be bypassed.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: Anthony PERARD <anthony.perard@citrix.com>

> ---
> Obviously the real (but more involved) solution would be to do away with
> the recursive $(MAKE) invocations, by breaking up the long linking
> rules. Representing them instead through multiple smaller rules with
> suitable dependencies is certainly possible (and might even reduce
> redundancy).

There is an alternative to that. Linux have a script which does the kind
of step we do. So maybe doing the same and move the recipe into a script
would work too? This would allow to share the recipe between x86 and Arm
as the link phase of xen-syms is nearly identical. But to avoid calling
make from the script we would have to duplicate the recipe of %.o:%.S.
The xen.efi rules is still x86 only and I don't know whether we could
use the same script as for xen-syms.

I don't know which option would be better those two and the current
state.

Cheers,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Fri Oct 08 11:38:13 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Oct 2021 11:38:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.204661.359826 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYoCT-0000OV-Mw; Fri, 08 Oct 2021 11:38:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 204661.359826; Fri, 08 Oct 2021 11:38:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYoCT-0000OO-Iv; Fri, 08 Oct 2021 11:38:05 +0000
Received: by outflank-mailman (input) for mailman id 204661;
 Fri, 08 Oct 2021 11:38:04 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mYoCS-0000OE-Os; Fri, 08 Oct 2021 11:38:04 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mYoCS-0002Dg-IZ; Fri, 08 Oct 2021 11:38:04 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mYoCS-0001iN-7r; Fri, 08 Oct 2021 11:38:04 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mYoCS-0005pf-4v; Fri, 08 Oct 2021 11:38:04 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=i7KWmkEF+tak8BxgxwcrMa6OKkLy79Wl/DI/fm9jNGQ=; b=Tf6YwxfGS9JMh41N0pPWgfMNDQ
	CvC0G6BY6CwuO2CtUljG0q3ZXpP87crTRbqfOTXedoya8ZW4+YsFPAQ6Rz8r0AWMrfLacbXC0yf5c
	ePiOgMvmNA/MqMQNDn3NSAAwZY5sv/AE8bKfRPK1CzXIdX9sbOjmujNpC3IrFyvVxx7M=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165409-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 165409: tolerable FAIL - PUSHED
X-Osstest-Failures:
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=ca61fa4b803e5d0abaf6f1ceb690f23bb78a4def
X-Osstest-Versions-That:
    qemuu=99c44988d5ba1866a411450c877ed818b1b70081
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 08 Oct 2021 11:38:04 +0000

flight 165409 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165409/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 164950
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 164950
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 164950
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 164950
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 164950
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 164950
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 164950
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 164950
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass

version targeted for testing:
 qemuu                ca61fa4b803e5d0abaf6f1ceb690f23bb78a4def
baseline version:
 qemuu                99c44988d5ba1866a411450c877ed818b1b70081

Last test of basis   164950  2021-09-11 18:57:22 Z   26 days
Failing since        164967  2021-09-13 13:06:52 Z   24 days   35 attempts
Testing same since   165409  2021-10-07 11:33:46 Z    1 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Alex Bennée <alex.bennee@linaro.org>
  Alex Chen <alex.chen@huawei.com>
  Alexander Graf <agraf@csgraf.de>
  Alexandra Clifford <aclifford@draper.com>
  AlexChen <alex.chen@huawei.com>
  Alistair Francis <alistair.francis@wdc.com>
  Amanda Strnad <astrnad@draper.com>
  Andrew Jeffery <andrew@aj.id.au>
  Ani Sinha <ani@anisinha.ca>
  Anup Patel <anup.patel@wdc.com>
  BALATON Zoltan <balaton@eik.bme.hu>
  Bin Meng <bin.meng@windriver.com>
  Bin Meng <bmeng.cn@gmail.com>
  Cai Huoqing <caihuoqing@baidu.com>
  Chris Rauer <crauer@google.com>
  Cleber Rosa <crosa@redhat.com>
  Cornelia Huck <cohuck@redhat.com>
  Cédric Le Goater <clg@kaod.org>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniel P. Berrangé <berrange@redhat.com>
  David Gibson <david@gibson.dropbear.id.au>
  David Hildenbrand <david@redhat.com>
  Dongli Zhang <dongli.zhang@oracle.com>
  Dov Murik <dovmurik@linux.ibm.com>
  Dr. David Alan Gilbert <dgilbert@redhat.com>
  Edgar E. Iglesias <edgar.iglesias@xilinx.com>
  Emanuele Giuseppe Esposito <eesposit@redhat.com>
  Eric Auger <eric.auger@redhat.com>
  Eric Blake <eblake@redhat.com>
  Frank Chang <frank.chang@sifive.com>
  G S Niteesh Babu <niteesh.gs@gmail.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Green Wan <green.wan@sifive.com>
  Guenter Roeck <linux@roeck-us.net>
  Hanna Reitz <hreitz@redhat.com>
  Igor Mammedov <imammedo@redhat.com>
  Ilya Leoshkevich <iii@linux.ibm.com>
  James Bottomley <jejb@linux.ibm.com>
  Jason Wang <jasowang@redhat.com>
  Joel Stanley <joel@jms.id.au>
  John Arbuckle <programmingkidx@gmail.com>
  John Snow <jsnow@redhat.com>
  John Snow <jsnow@redhat.com> (Feel free to merge.)
  Jose R. Ziviani <jziviani@suse.de>
  Justin Restivo <jrestivo@draper.com>
  Kai Huang <kai.huang@intel.com>
  Kevin Wolf <kwolf@redhat.com>
  Kirill Tkhai <ktkhai@virtuozzo.com>
  Klaus Jensen <k.jensen@samsung.com>
  Lara Lazier <laramglazier@gmail.com>
  Laurent Vivier <laurent@vivier.eu>
  Li Zhijian <lizhijian@cn.fujitsu.com>
  LIU Zhiwei <zhiwei_liu@c-sky.com>
  Luc Michel <lmichel@kalray.eu>
  Luis Pires <luis.pires@eldorado.org.br>
  Marc Zyngier <maz@kernel.org>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
  Markus Armbruster <armbru@redhat.com>
  Matheus Ferst <matheus.ferst@eldorado.org.br>
  Max Hsu <max.hsu@sifive.com>
  Max Reitz <mreitz@redhat.com>
  Michael S. Tsirkin <mst@redhat.com>
  Michael Tokarev <mjt@tls.msk.ru>
  Michal Privoznik <mprivozn@redhat.com>
  Naveen Nagar <naveen.n1@samsung.com>
  Neil Armstrong <narmstrong@baylibre.com>
  nia <nia@NetBSD.org>
  Nia Alarie <nia@NetBSD.org>
  Niek Linnenbank <nieklinnenbank@gmail.com>
  Nir Soffer <nirsof@gmail.com>
  Nir Soffer <nsoffer@redhat.com>
  Pankaj Gupta <pankaj.gupta.linux@gmail.com>
  Pankaj Raghav <p.raghav@samsung.com>
  Paolo Bonzini <pbonzini@redhat.com>
  Pavel Dovgalyuk <Pavel.Dovgaluk@ispras.ru>
  Pavel Dovgalyuk <Pavel.Dovgalyuk@ispras.ru>
  Pedro Tôrres <t0rr3sp3dr0@gmail.com>
  Peter Collingbourne <pcc@google.com>
  Peter Delevoryas <pdel@fb.com>
  Peter Maydell <peter.maydell@linaro.org>
  Peter Xu <peterx@redhat.com>
  Philipp Tomsich <philipp.tomsich@vrull.eu>
  Philippe Mathieu-Daudé <f4bug@amsat.org>
  Philippe Mathieu-Daudé <philmd@redhat.com>
  Reinoud Zandijk <Reinoud@NetBSD.org>
  Richard Henderson <richard.henderson@linaro.org>
  Richard W.M. Jones <rjones@redhat.com>
  Roman Bolshakov <r.bolshakov@yadro.com>
  Roman Bolshakov <r.bolshakov@yadro.com> (x86 only)
  Sai Pavan Boddu <sai.pavan.boddu@xilinx.com>
  Sean Christopherson <sean.j.christopherson@intel.com>
  Sergio Lopez <slp@redhat.com>
  Shashi Mallela <shashi.mallela@linaro.org>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Weil <sw@weilnetz.de>
  Stefano Garzarella <sgarzare@redhat.com>
  Taylor Simpson <tsimpson@quicinc.com>
  Thomas Huth <thuth@redhat.com>
  Tong Ho <tong.ho@xilinx.com>
  Viktor Prutyanov <viktor.prutyanov@phystech.edu>
  Vitaly Kuznetsov <vkuznets@redhat.com>
  Vivek Kasireddy <vivek.kasireddy@intel.com>
  Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
  Wainer dos Santos Moschetta <wainersm@redhat.com>
  Willian Rampazzo <willianr@redhat.com>
  Xuzhou Cheng <xuzhou.cheng@windriver.com>
  Yanan Wang <wangyanan55@huawei.com>
  Yang Zhong <yang.zhong@intel.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/qemu-xen.git
   99c44988d5..ca61fa4b80  ca61fa4b803e5d0abaf6f1ceb690f23bb78a4def -> upstream-tested


From xen-devel-bounces@lists.xenproject.org Fri Oct 08 12:35:10 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Oct 2021 12:35:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.204700.359857 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYp5V-0007Y8-Rc; Fri, 08 Oct 2021 12:34:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 204700.359857; Fri, 08 Oct 2021 12:34:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYp5V-0007Y1-OJ; Fri, 08 Oct 2021 12:34:57 +0000
Received: by outflank-mailman (input) for mailman id 204700;
 Fri, 08 Oct 2021 12:34:56 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=aYfl=O4=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mYp5U-0007Xs-2w
 for xen-devel@lists.xenproject.org; Fri, 08 Oct 2021 12:34:56 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 2c52b9eb-b1c3-4484-953b-8bf1ea7abecb;
 Fri, 08 Oct 2021 12:34:52 +0000 (UTC)
Received: from EUR01-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur01lp2052.outbound.protection.outlook.com [104.47.1.52]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-13-xu8jvV-TPeqrdm4yTVSPCw-1; Fri, 08 Oct 2021 14:34:50 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB5901.eurprd04.prod.outlook.com (2603:10a6:803:e9::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.19; Fri, 8 Oct
 2021 12:34:48 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4587.022; Fri, 8 Oct 2021
 12:34:48 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6PR08CA0030.eurprd08.prod.outlook.com (2603:10a6:20b:c0::18) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4587.18 via Frontend Transport; Fri, 8 Oct 2021 12:34:48 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2c52b9eb-b1c3-4484-953b-8bf1ea7abecb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1633696491;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=OFn0lOiiW0WLh6vRi6H380V5FrGFAIi+h1wxCPTCcas=;
	b=Cis/ZqtXrVhMbP01EBre8wH0cdTXfKIQ/pOW+eY38PmRlJ3wLmgOWBH31tEIzVoWe67wNk
	CTTLxXX/O+3owyAboMcmyQPXFf1S4/9ETblz78bD6TcUbubSKBtvYq6/NDoog158t2TxEx
	MTYZcFVuuA5tRJhpdXDNHA0OriUXc3M=
X-MC-Unique: xu8jvV-TPeqrdm4yTVSPCw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=HTXuPNoy3ahBt25PNv6fNU90owJp4Bebb81mGGuXzFcJ5kWptgzJr0sigWhy/8l85DRt9i/CZXW/BmzFm6RWn3EjVsAAIYGtji6hAskQS7ALLl2R84VDcM0Q2Fb4EUp3BkkEeLCuYEcVFZZOAzomfyoSiL/zoV8LFJ3OhO+vYQEc2avQaF7hkILSXSU9ahGzUXOIu5f5fOKkNV6e93Z/zEPNFK1s08z0yjrsdIZRWE9ui02DhTmF8dr7/tt+MBpn5Rh6W0tYjEQcOkA69haRMTV2uBXj5p1GnVniD+UZoQryEzMqwu6hQ1f/CEeN7RDuEMtUsaRZZazDIiRJ8XRkfA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=OFn0lOiiW0WLh6vRi6H380V5FrGFAIi+h1wxCPTCcas=;
 b=VKkw/qDmSqmCmv7tiE3xmkQHN4Mm5GzToSNR5cU6M3REBFYNXO85gr9dReWNst/xhMcOrLbf64qual59w6ceH3bUNaDpe34GKvlGRZsFzgDYd9g89aQzmhR7s1XmIIhwB5UeRZsK3f25MUTL2b5wVShRAzxIyf5OnXJCHMeI7I90EwlKdS3PNE/f+8/DKVgmVAddEmKRgyMWovXtjggnLw4vAH33IHiJq1mseiqg+TLXy8kPKCdH7Ax1MxpepJQBGtwwSWQk7mgz8G4xKCxiiNEqo7czXCWvTzGYw4Ct/Gt+0toD63xcsWCV/ANvC1F5jx4u+QFBbRta/0d8J/fUTQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: citrix.com; dkim=none (message not signed)
 header.d=none;citrix.com; dmarc=none action=none header.from=suse.com;
Subject: Re: [PATCH] x86/build: suppress EFI-related tool chain checks upon
 local $(MAKE) recursion
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <8457d422-4db9-59b9-d0c9-663430dad955@suse.com>
 <YWAmz5+5cufR1lKi@perard>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <32d36905-4e43-440e-765a-6637a9955afb@suse.com>
Date: Fri, 8 Oct 2021 14:34:46 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <YWAmz5+5cufR1lKi@perard>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR08CA0030.eurprd08.prod.outlook.com
 (2603:10a6:20b:c0::18) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 5f52bacb-0219-4b1a-1af6-08d98a58046e
X-MS-TrafficTypeDiagnostic: VI1PR04MB5901:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB59018AB60328956AF606C224B3B29@VI1PR04MB5901.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	4Xs7bP34LzlymhvHseVEs1O3GqBHmDfUwGvR+E4/rSO0ghE3UtQ9ztBdjDM80dtNPFDxgGgGQOnOgB24Ca623va6HVNIuOgc6/kxPIVAwTlj1JSNTrBWk+6BQI5zHZAyEmX4q98H8gSfBvmO1VSoYVj0H5dPoFobHoqi9L0fx4uUmdXhcy9iigc6npJmuC03Rv5huwWulLYdP+saG04QiUFppdOzN+19L/6QZK4UCXy/7ZCxJTJHKFSpRwrvRR49ciTOJhDfwNfLmpuFAU2UeoZR4fEC6+6Qq6gqdb2iC730zPrpaVorqxJyFCODuKpg8v45gFOIfpfHaOfkaHx/slGZiFazUV5v2IeuvpyZEpxTH9iN1XhdWXotdTl4yqkbdBOgjobhkxyAelQlp2wHnCa5dYzsCj08cc6n/12TWisC/fyeZp0QS68ZWGW0dogPDvG6abOaZZOTq2/awXxLlpi+mCzha9GPpjJyCSBBVapZfPsARruMBzFOCr/tZXu/tKdewRFaL7l1yx1Scy75LCQiLAzTmd7l5OPwAPlZBHfgl4o1pcfW/Jjc3m2s8rM6UG1Z1V6h8md/+rQWeTWEqUr90ERuU+DXjRM+QC7yjKiIlSwhrDvCxtKbJh/ruRbOz0V9L8IKa/uDZd9hYp8qI+XgpggpSsiFN2CIGb3CrG9W+y1AR1riF6gH8K7OzADvQrRlUaMUJ2cRwF/QXlHD80SeveTcfxcBMUcDSiXENAYOcXo2Zaa0ma38oBkBEmcX
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(86362001)(31686004)(31696002)(38100700002)(36756003)(8936002)(53546011)(5660300002)(956004)(8676002)(186003)(26005)(66476007)(2616005)(2906002)(54906003)(316002)(16576012)(6486002)(508600001)(66556008)(6916009)(4326008)(66946007)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?TDRvM1kxNEtobmpwL0dYci9QTWhEWFNwdmZQSVVGS3grUkloUm5ObW9mR3Jq?=
 =?utf-8?B?dDZwZUtHL2kwNVFsTXZBVFhjdi9scE51c0pQbjM5MUU0VHcxc0g4YkIreEFR?=
 =?utf-8?B?UDRpVHp5MmM2M0l5aXV5V1VLcGlCL0FJTitEY2VRbWNISmIzbHZmYWpiV1RE?=
 =?utf-8?B?dG5sZkVkY3IrTGFpUEg5elltNGV5Z1VrdmhXOHFwZS9MWE1NYUU5U1hEcHNm?=
 =?utf-8?B?U1lEMVpMTDB1OEpBdVJySnc5SFcwcHV2YThhdEdMckx5NEZFbk8yU3ZJZEt1?=
 =?utf-8?B?YkxvVGhidC9YbHd2aWdXQzNQQWhEMzNzakV4MTRiSk1aQ1NzUDdTQm5sbGI3?=
 =?utf-8?B?dnp0UjRzUXZEVWJjaVRNN0FqOWpGQ3F3VkNpdzk0aEorMW5OYzArbEZzL0FK?=
 =?utf-8?B?Qk5KTVRVMXZEZUZEZENlOHgxU1VJKzZVTCtvZzVaVnhzQzNxL080dExDZVBo?=
 =?utf-8?B?aDd4SmFZTG1YL2trL1kzWm13bWYrcmhJM2c1eFA2T2NwTlJ0WFJhcjZFZEhw?=
 =?utf-8?B?bElWNTQvT3F4RE40aWJUb1h5N2YwS0hEYVJFZjNEMVRsKzE0cHo4V3Q4OW1C?=
 =?utf-8?B?L2Zickc4TzNMcHF5NlZVeFE3U01YZmdBYWM0ZE5LZ0ZXamtTUDY1emJkQ0Ns?=
 =?utf-8?B?aytSZ3pucW4vQko3NTljSHFFRC9YTXp2Q09BSmtUVGtSandQZjhyWGpZa2Ry?=
 =?utf-8?B?ZWJMOHkvU3NPRDZoUzYvUERERFJhZ0xTeXQzdWlIZ3lMc1NuQmltdzNmTW5P?=
 =?utf-8?B?bWRrd013aTRnaEhqQkV3dWZXSUpGSmR5NUhPcDR3VmRmT2cvaDQzSnB1eDd3?=
 =?utf-8?B?aXpER1NaemZVNDNMWFZlVSt2TFc0dSsycXhvWTV6czFiL1VKcUh0ZnFyeTJi?=
 =?utf-8?B?Qkp5Yml0MWdFQS96U2Q5YkVGbGVpeUcvb1BXblhPMThEa0J0WE5kQUx3N3Ja?=
 =?utf-8?B?bkpWRzV6NWl2UkxtcFpQTmZjNUNoTUh5RFdMajFWSEdMUjNOa1pDTFo0cGhN?=
 =?utf-8?B?V0pXYXFBdytPYy9HdzBtZXhlUUhlMDBYS0wzaHlGWDdjazBscFRxVWZaS3kz?=
 =?utf-8?B?OU82d1dyWTB2SmZpZlYwdHBHQm5CRGlRYkdkN0xEeWdDK1E2R1puSGVKajJY?=
 =?utf-8?B?ajdYa3lUdGZHeU5WTkM5Y2pCaDBWQWZsOXZBdVJlclhKbkg0d09ROERTNHo2?=
 =?utf-8?B?QVd1MnNSWWNKNGV0K095OHhsL0lmL0xyN01wdTRpVkkzTVdRNlF0QkpSbC9B?=
 =?utf-8?B?eUczOTAyWnFEaFh3T2FRdWpkV3JndEt3VnZaYWh6Mm84Q0JCU1BFWFFWU2F0?=
 =?utf-8?B?Y0VkVEdQbGw0Nm9ZbDVPditGMkhaekNhcXVERCtJZ09mOHdxaEl5NzFwV2Q5?=
 =?utf-8?B?aDQvWGRiZm1NMURmZlFlbENwZ0dFdGJiek9rd2dselQ0OEVjT1VjZ2U1T2dn?=
 =?utf-8?B?MmluZitPUFR0LzFBTGtYUmlRdUwxNFNjYmNsaTRkRUpncmJXVFhkdlJuNVZk?=
 =?utf-8?B?VEE2SGVRbmViVjB2OXpBRGZUb0VzTzNMejg0U05hTzA0UldDUElPUGNvTURj?=
 =?utf-8?B?VThvdlZFZGJhZk1BMkpzdHl6S2g1cVMyandsTW16eExybk4yNjlwYWM1ZWd5?=
 =?utf-8?B?NDlkM29zcFRvd2J5VTJzKysvbnV3eVVNZUdZdGVpeFh3K2J1eWRLdHc1NmtJ?=
 =?utf-8?B?RXg3QlhTVDRUU2dGRGsxVUMrVUg4NllVQ0xKS0xqOEUxY3VNOCtUQXZPNGNW?=
 =?utf-8?Q?/aIGch+7EL3XkMYPApLj6f/TdxGU1kCfnzBxZlX?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5f52bacb-0219-4b1a-1af6-08d98a58046e
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Oct 2021 12:34:48.7224
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: X0FzgPi+3LuQ73Ooz8hJxbgYqCMcvy/8v5GBGtrdjG/TR3r6J2QIUTuVLdTXmzsjy7py4QHn1x/HTN8FQkEw8A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5901

On 08.10.2021 13:09, Anthony PERARD wrote:
> On Tue, Sep 21, 2021 at 05:43:38PM +0200, Jan Beulich wrote:
>> The xen-syms and xen.efi linking steps are serialized only when the
>> intermediate note.o file is necessary. Otherwise both may run in
>> parallel. This in turn means that the compiler / linker invocations to
>> create efi/check.o / efi/check.efi may also happen twice in parallel.
>> Obviously it's a bad idea to have multiple producers of the same output
>> race with one another - every once in a while one may e.g. observe
>>
>> objdump: efi/check.efi: file format not recognized
>>
>> We don't need this EFI related checking to occur when producing the
>> intermediate symbol and relocation table objects, and we have an easy
>> way of suppressing it: Simply pass in "efi-y=", overriding the
>> assignments done in the Makefile and thus forcing the tool chain checks
>> to be bypassed.
>>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> 
> Reviewed-by: Anthony PERARD <anthony.perard@citrix.com>

Thanks.

>> ---
>> Obviously the real (but more involved) solution would be to do away with
>> the recursive $(MAKE) invocations, by breaking up the long linking
>> rules. Representing them instead through multiple smaller rules with
>> suitable dependencies is certainly possible (and might even reduce
>> redundancy).
> 
> There is an alternative to that. Linux have a script which does the kind
> of step we do. So maybe doing the same and move the recipe into a script
> would work too? This would allow to share the recipe between x86 and Arm
> as the link phase of xen-syms is nearly identical. But to avoid calling
> make from the script we would have to duplicate the recipe of %.o:%.S.
> The xen.efi rules is still x86 only and I don't know whether we could
> use the same script as for xen-syms.

Hmm, maybe. The main aspect I'm not sure about is that, as you say, we
have two linking targets while Linux has just one. If there are no
interdependencies regardless of build mode, doing what you suggest may
be fine. If there were interdependencies, your approach may lead to
serialization of both rules, while breaking up may allow large parts to
get carried out in parallel.

Also, not exactly fitting the pattern above, lines like

	$(MAKE) -f $(BASEDIR)/Rules.mk efi-y= $(@D)/.$(@F).0r.o $(@D)/.$(@F).0s.o

when split up allow both objects to (continue to) be built in parallel;
arranging for this from a script may be more involved (albeit my knowledge
of how make works is lacking here - maybe an instance invoked from a shell
script can use the parent make's job server just as well as one invoked
from a Makefile). As you may imply, I don't think we should be duplicating
the %.o:%.S rule, but indeed have make deal with this.

Jan



From xen-devel-bounces@lists.xenproject.org Fri Oct 08 12:37:00 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Oct 2021 12:37:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.204708.359868 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYp7U-00088u-7Q; Fri, 08 Oct 2021 12:37:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 204708.359868; Fri, 08 Oct 2021 12:37:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYp7U-00088n-4W; Fri, 08 Oct 2021 12:37:00 +0000
Received: by outflank-mailman (input) for mailman id 204708;
 Fri, 08 Oct 2021 12:36:58 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=aYfl=O4=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mYp7S-00088c-Nw
 for xen-devel@lists.xenproject.org; Fri, 08 Oct 2021 12:36:58 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 167717dd-3fa8-47ba-b5b7-ff344e15a229;
 Fri, 08 Oct 2021 12:36:58 +0000 (UTC)
Received: from EUR01-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur01lp2052.outbound.protection.outlook.com [104.47.0.52]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-32-9cABBLOWOsGjGZoNYm-CzA-1; Fri, 08 Oct 2021 14:36:55 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB5901.eurprd04.prod.outlook.com (2603:10a6:803:e9::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.19; Fri, 8 Oct
 2021 12:36:53 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4587.022; Fri, 8 Oct 2021
 12:36:53 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6P193CA0095.EURP193.PROD.OUTLOOK.COM (2603:10a6:209:88::36) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4587.18 via Frontend Transport; Fri, 8 Oct 2021 12:36:52 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 167717dd-3fa8-47ba-b5b7-ff344e15a229
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1633696617;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=VfxpZeqp5AUa9f4Fkfs+nFb4Aff3huHPoYuFV/AnIBE=;
	b=ap0l6NEtan509hzwUVX5hAA7RqZL5yNymARbpnQNG0Q1g4i5NYQDtbGSCDDOgwB3Wd6Z94
	1fXK39026CYYhVmAiK/cW/2PNHLjk6/7F/QLXQf1P72QXxmIuXaDJ4T24leZFC3gIZSkn1
	I2aSqD2pUN2/XOp3wC5TdfCe+c9IX+Y=
X-MC-Unique: 9cABBLOWOsGjGZoNYm-CzA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=X+KA7bbTcs8CRoah83UZCcTh+YGXB5xUDPKjlxbEXxVpV6W9yxVZrmm2+tc64KJOMTmg4MS7uZ/mE9UTyC5icjij0snIb/Loarq+oNSE4BEG4wdhHWC4Fxd4Red3TISlmsvVbX7ph+L6LVCZwlnBC1SRQYy0+YE0VWLwwKNfBRXv7gZrnkwHd6IFOOex0Zl910NUjl3jtteCa/SwbFi1RwWLKPW6xZ9izosSy9XQBC6Z2D82aszbyLdtBEtDm4NKiXP6EjQl0VjZ1EQg/0Uz1vyJEGV9Yz3ZeexzyeVvuURgkXwgS5ddtJSXoYwy+l9MrTbl+rX8THfg+lMT+PqlPQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=VfxpZeqp5AUa9f4Fkfs+nFb4Aff3huHPoYuFV/AnIBE=;
 b=ki5jyW8grS6T/0OO65KnQ/YrlgPW+9tGpD2Ybpo7l9jkIEPb/U8P03Acnsk5E7aEIk+I/JzDX+mUJzmsUsKXAXguYd2/Rf7jUFCtilhkIhNS0SxZWIetGqPd26RPVDOkh2qcKzcO2jNyeRpDmU/GBZS2kZ7gwnkdMp/nhsy57gsMZaSHOrxKt0WVAyxeFoH8BdVRVt5Vo40uRJhw1CZ0ZVtGdVshW2cQ2mkwBNv0SZ2Ndi6JGXJC/q9x+TDXle3Ea/PCJhZbNYz2he2FXQO9U2hIxvmRKUqwnw3BzCbz9jgOK/0JeCYjGdhoSW8KNv9BNu7s46Y1XEyorvJRvFJPpg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [PATCH V5 1/3] xen/arm: Introduce gpaddr_bits field to struct
 xen_arch_domainconfig
To: Oleksandr <olekstysh@gmail.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>,
 Anthony PERARD <anthony.perard@citrix.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Juergen Gross <jgross@suse.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 xen-devel@lists.xenproject.org
References: <1633519346-3686-1-git-send-email-olekstysh@gmail.com>
 <1633519346-3686-2-git-send-email-olekstysh@gmail.com>
 <68cb29bb-7d84-dc27-eead-4a079b9caf68@suse.com>
 <e77eea6f-163d-0920-2e90-fb9f3a602743@gmail.com>
 <ffb40f3b-2394-7747-2c06-955e2aa87cfc@suse.com>
 <387608b9-c7b2-e814-7fa5-a262acc0c73d@gmail.com>
 <ae852345-66ff-7bcf-f68e-2161e23933a1@suse.com>
 <alpine.DEB.2.21.2110071311450.414@sstabellini-ThinkPad-T480s>
 <b8e868a2-9af3-de6c-0683-4bb2ff7821f3@suse.com>
 <b36e5fb7-6ed0-dc7d-5ed3-c3c9c9ae70b5@gmail.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <ff760c65-1041-aac6-40ed-981f0b900678@suse.com>
Date: Fri, 8 Oct 2021 14:36:51 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <b36e5fb7-6ed0-dc7d-5ed3-c3c9c9ae70b5@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P193CA0095.EURP193.PROD.OUTLOOK.COM
 (2603:10a6:209:88::36) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 0ef715b3-46f0-450a-3d08-08d98a584ec5
X-MS-TrafficTypeDiagnostic: VI1PR04MB5901:
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB590123BE7D58901643C1D121B3B29@VI1PR04MB5901.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7219;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	45mWF8ttt+ydkrVtIANsC7caQk2YkLccwyeY7R6JjR7X7fWRtmgFJYhiwUfkRRDbw36kX1zMpdlv25kayuc8+r3epzvtLlIpbBzM1ygo+bQ4Td6SpZhPN1rE4htmtKy8wZnD5+f9i/8OhS2e/ZvZWDdAk//BSF0TLaK9PeF6p7NJEKgbHzrIplZMorRN6bvuAAOts7scWrGzXquCzrrX9WCgM90AGZSJg3FAIbrYkAdMftMGZFSRrDE7GsIUTTVkIO19t8FVynnDudO9b6/zkAIPap+tjmLeTgdZGUg4YSOpMp354E30FdaBfCdrcE23x961x7s9juFdz0yQqPn2s3I7jsXl9PLx4vkC45W+IPnsTAml3jl23PIHNXvVCu7qXVa1zzS9PjVfMUIOtuPN+ULuAnxBt3DMSAarZSd/dgJ5T+eZa+mmqlRzSq0rCALTvyFPsf8rpMyiqQWqJp8EWc8Sjkhvz8BPYIYMBvnudijlfEV0MNFs4sTXOfWpVREdhdjkC4u5ygVWY3f18ex3fet/M1YttHLRLGP2l3aKR/6lG4zYSAisHx2BkeoftQX+qAP8MEna4zvi+nYn3iXyRGZvMcxilgeeUnzwQSpQFvwHp7a4T6+Ja3FzvO6WiFFOEGAbkqp2DPopP5GkyF2mG+XHUoeBKYZrYLED5He+XyC0m4FOHW+Zn5f5ybll2zQIKm5Qn9ClsRWK+UJ0qB+wVA+NFMbXmIWUcgqpVa7DVAF3YnftPUT5C4frjOHUP6gn
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(86362001)(31686004)(31696002)(38100700002)(36756003)(8936002)(53546011)(5660300002)(956004)(8676002)(4744005)(186003)(26005)(66476007)(2616005)(2906002)(54906003)(316002)(16576012)(6486002)(508600001)(66556008)(7416002)(6916009)(4326008)(66946007)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?VVFibmVQNVRLOHZjWFV0a2RJeW5velVCcWMreVNGbHJqNEtBdlE4N3FISVk0?=
 =?utf-8?B?MFdkOTkvK2xUcG5LU2trc2FpY2NCUkF5MjgzcHNzRVgyc29tekY1YUgrMDBy?=
 =?utf-8?B?WWpFcFBuL3BFa2UzSU0zTGF4VzBiQTE0TnFNeU1VMk5LR0FOK0d0QitaTkd3?=
 =?utf-8?B?THFhcVBnSVMyZjlCM0JJNmR2aXVlS083dkZvL1lTQlRwRVpRS0UvN1V4TU1F?=
 =?utf-8?B?Vy91NFF6SzQ1VUhIOHRaOG95Y2xPUVI5enA4VjFGMnZLWE5RQnZQczdhTzg2?=
 =?utf-8?B?bURFcS9VTG9rRms3OWZTUGgwTDhSdjFDRGF0ejRybkxSOXdVekFTVzYxOUVF?=
 =?utf-8?B?cmtYVEFRbCtiWU9EaE11YkhoK0VIUXRQU2dpYVhQTFdGZG1wQ0RRU2Y5elFI?=
 =?utf-8?B?VWVpRGw1MTFkSTU5K2wyVXFrM2RZdStsUzZ4SStncUpwckZmWjdIbzZIaWt0?=
 =?utf-8?B?VTNTeVZOWFl0WTRIa1kySFdiaUZ2L2RmU2FZUXNsd1J3QWhXalVVWlhvb1E5?=
 =?utf-8?B?VkVNS3JsWWlwcjIvZmVVWVBVUWsyYWNLbkV3TXNYVTZjb2UxTXlVYXlBSisx?=
 =?utf-8?B?Q3loQkc1ZFZ5anRSN000QysrZVE1ZDA5WXNUaUxCRmdBM2xmQ2Vmb0lSMFFu?=
 =?utf-8?B?ajhLaCtkdU8zMVErS2x0TmNlZHlxZStyVTZObUJET2JFcVRHd2NpTXErQ2VB?=
 =?utf-8?B?WTArOWdlMHRwQmhDTE80YjA1alIvZTJJZkE4eWkwNU8xQTBCaldHemM5cmFk?=
 =?utf-8?B?cGQ1SW1yZzVxTnlqbWp4d2d6bHZpblZGREJhRUZKNENaSXR0VmJpQzBlL2Nn?=
 =?utf-8?B?WmZJTllTUVJVcXUxVkVhbFhwMnVLcDFCWWtMMHhqY0EzVWIwVEJJZ2x6cTJO?=
 =?utf-8?B?T2lwd3MwY2Z1S2R3U2pPTm15RkFobUlPU2Z6all4RXlRNng4OEViVjVnYTlw?=
 =?utf-8?B?VXV2UldtUkkvNC9URUpTaUpUR1RRSFZsc2FvdnBWR2k4RnJPdTgwdnF1Nms3?=
 =?utf-8?B?Tkt6aVp4cVZGaGtIN0dqcFVDZTV6anMzakVDYUtVZUdLQkxwTU9NV0ZFS01i?=
 =?utf-8?B?TFJ0c3p0bDFIa0JQT3pDcVM4ejhxOENDT3pqNk5yZ3J3MWxwM3I1L0hwekpK?=
 =?utf-8?B?QVM2R3ZSNXVLZGJSZ1ZkMzdRaHlOaTVFaVEyQ0Nadlo3TUdJeEgxRWZFNWYy?=
 =?utf-8?B?amlhWXJFS2VaQkQ5L2hIWVJvREhraHRrWUdNVFVZQUdXWTFiWlhVWTJYYjVJ?=
 =?utf-8?B?RGxuYVpXRmtreGhvRzRJenp5UzdrYmtPMGozcUJhSHBzNjF4YTEydUZkSW5j?=
 =?utf-8?B?UFNIWWRZSXZxUnprcWh5V21yeEduRHFkNHpNY2ZMQVFsLzdZczZ4NElPS0Z2?=
 =?utf-8?B?a0lQb0RXOTkyOG1YaVVRa1ErbkxJUXpyMitnLzBPUzEvMEhXSGN1VVdrOFN0?=
 =?utf-8?B?RW5KZEhQbnZUaE9CVVV5VFpyL3NNZHRHaEw2RGt5UytFOENCNTdzMFNJZUU2?=
 =?utf-8?B?SFBZaXhBaXIySU52eG9lV0dxOW9DZzFpaElzZlJPUGM3a3hoelB2L3VVVm50?=
 =?utf-8?B?TUhSNXA1b2xaT0huWTdWTUZVM0NhWXNUN0tXODNDYzRwOVFtVDMyd2s1WC9s?=
 =?utf-8?B?UVg2YWV0a1lFQWVRZy9FdlhSYUxaSmdkZEt2QSs2eUZWYlliTmRmMFJhd0hI?=
 =?utf-8?B?NlZ4R0MzMHpLWHNCUVkrSnNlc0VlamFsNTlpa0F5SFpKZEF5ckQ0RVpPNG5o?=
 =?utf-8?Q?oztOZkeSjZ8kqKnT2eRvTc3S70qNTvPDLskP+JA?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0ef715b3-46f0-450a-3d08-08d98a584ec5
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Oct 2021 12:36:53.3909
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ckloyyuMdVo66Tu4DZMQqsDSS5Ld0Td8D8pJLamWW6fPkknM0ToUSReGqf7djaD26fCdKyOnrsdbi6Yvvf9kgQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5901

On 08.10.2021 12:25, Oleksandr wrote:
> Just a quick question. What do you think can XEN_DOMCTL_getdomaininfo be 
> reused to retrieve gpaddr_bits? I don't see why not at the moment, but 
> maybe there are some implications/concerns which are invisible to me.
> 
> I see that arch_get_domain_info() is present, so the field will be 
> common, and each arch will write a value it considers
> appropriate. This could be a good compromise to not add an extra domctl 
> and to not alter domain_create.

Technically I think it could be reused. What I'm less certain of is
whether the specific piece of information is a good fit there.

Jan



From xen-devel-bounces@lists.xenproject.org Fri Oct 08 13:07:01 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Oct 2021 13:07:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.204718.359880 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYpaG-00032V-MJ; Fri, 08 Oct 2021 13:06:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 204718.359880; Fri, 08 Oct 2021 13:06:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYpaG-00032O-He; Fri, 08 Oct 2021 13:06:44 +0000
Received: by outflank-mailman (input) for mailman id 204718;
 Fri, 08 Oct 2021 13:06:42 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=aYfl=O4=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mYpaE-00032I-Ke
 for xen-devel@lists.xenproject.org; Fri, 08 Oct 2021 13:06:42 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 93beff6e-2838-11ec-803a-12813bfff9fa;
 Fri, 08 Oct 2021 13:06:41 +0000 (UTC)
Received: from EUR03-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur03lp2051.outbound.protection.outlook.com [104.47.8.51]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-29-z8LzDxaiOLOl28PDnbtlPg-1; Fri, 08 Oct 2021 15:06:38 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB4191.eurprd04.prod.outlook.com (2603:10a6:803:45::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.20; Fri, 8 Oct
 2021 13:06:37 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4587.022; Fri, 8 Oct 2021
 13:06:37 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6PR08CA0034.eurprd08.prod.outlook.com (2603:10a6:20b:c0::22) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4587.18 via Frontend Transport; Fri, 8 Oct 2021 13:06:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 93beff6e-2838-11ec-803a-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1633698400;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding;
	bh=SRBgPmR53QC8PIMULg83d3+h6Qo/+vNFPFVxXxba2Ho=;
	b=WzjJrBLhxrjvUCF4zbLa8xFQnS1VKZyHiQ6TUOoS0/+1jhBNkt6n1ObYSGDhc/fCGZpuI4
	8UAqbiuSSoWCILPHB41WKRQtYiuTDX5EIks9ugm7hwUlShObVi434GKiZ8IUeQREizQze1
	ElJbD9kisdXRhvx5JEGmT6GZRzEB+wY=
X-MC-Unique: z8LzDxaiOLOl28PDnbtlPg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Os2A73Zlqobme7XNMBs+JMGeiu/USRJ04qypcHig71hyJ/pla/quL8V4kC3MnGtVoM3hJEOVd4QD74CsC//c1vSqpFdFpcHAly5qUcGDbtnV6NoruSSJk7xb72BjJM3Y8jA1VCiurhFDXu73E25002l05VsLEaj/NctWPqvjKBPEw584jzdtQPJGGmuKCnaFD9+FVALVTDpE/teHui2a8rhPwRVmJZKSxKrp0b9X5jtOmIz7HlaNqMa2nVeQ4yCobaQE2I2EXMLIUHXOdE7rQ4OIIcFFajxOjec9kQt+X2Al8EPkk86QDJPwkq7uiV9UucuS4wdcv/+RlNKEpo+rdQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=SRBgPmR53QC8PIMULg83d3+h6Qo/+vNFPFVxXxba2Ho=;
 b=hrP4gX5daPmUnQD4SlySXmc596iOh9qyvRhK7jji4u0Zr0kQnhcRmUfZbWNmXQ/66LBZZRk2KjEcC4rHnZH2kjS2r1tU/AIVD2WADBffnZ55lahPhnVpgSlu3YtBP3ri5rPST3roqcyj6OpnSkNx/Ay7AleN3ImwXnnpbhyBjkowVPKYfM/327GBaOU1cM0uBORBGeEs1SEGggw27P6GLoAe8Um2Z4X7u82W89lRoSVB2HreRPKaXd6Kb2xTlZjCtJ8PQubzvgHScOIwTakztbNAiZrjJ8M4TMkVQHlwTy61xGg2oe6JXmYUoS2We8z4c6+VI3itUdfFTrZ5YHe3sQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: citrix.com; dkim=none (message not signed)
 header.d=none;citrix.com; dmarc=none action=none header.from=suse.com;
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
Subject: [PATCH] x86/HVM: fix xsm_op for 32-bit guests
Message-ID: <cb3fc8b0-cd60-edc4-7064-0bea87a6c8b6@suse.com>
Date: Fri, 8 Oct 2021 15:06:35 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR08CA0034.eurprd08.prod.outlook.com
 (2603:10a6:20b:c0::22) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 348b9875-df4b-4233-6f9b-08d98a5c7653
X-MS-TrafficTypeDiagnostic: VI1PR04MB4191:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB41916A32763DC0D42CF12092B3B29@VI1PR04MB4191.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:4303;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	1CTi7WoXYkif7Z2/YkMFPUWzgAzxf894pymmFiRM6KzZwHzS8kH4hy2GWIsa8dtYGcbZtLRkExZ0AJjPh2o4LLYGNxyCThjKy4X0QuzHQp7dJrg7sdHWS09Y/fqHnN9aw63pz66ayYo+hlSUZuWYlfHCRqWnwXUU81cjs84bFVlbL2PFqrAEmaXh7X171nYOy3BVe6cVdet3ACQbUb5LA4Xd+sEtfXLTcQvMgWxj5wzkPXyl5J8ZgAOSTPGImzn0xpDs12BdHekN0cl66CiFR3i5kzcxm/9zSYUMdB58Vh/5zALH/OIjvl1ou6m7gnJnHDvFKzSIT0vfwsi7DITQqMJmNRRqKci7XeJwkgdls+7EZ3ed5/1Aj4F7PXk+ppPRDAoM0sIBPdNDLl3AxC7hW+sTgWwFOQZewjcr+klIPRuZxZBEm/rnv/B11tI1ag1X/Hh0SoXwgOiDkHBUS/k+UMtaKRKIiGFFlAFXZ0MrrHp4pNvoArWEI2p8t6MsBrGpOzBi4NLBXcMy5hPBmFSeiTG7n6tBFeeQFoPkJAgB9WOPKX+pZx++ArZcrz1vcfM2/FesFpgMog6K04fomPA0a51Uqg/mnYbCCII4VH+XHKuVv9QkLX7sqP0dgNod2JjMzX7egr49g0f9rFMEwDtFjo7Kaiy9pMUs7WLzKETgJ9xPerprkO/y9nBmFbgnbPoRq+9iFRHJSFtO6Ee6KjB07UdjP+T0iwTmhn3qZtQnJK5Hq8VWnc+IBjXfmItcEzo0
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(316002)(8676002)(86362001)(16576012)(54906003)(38100700002)(8936002)(2906002)(6916009)(31696002)(31686004)(36756003)(5660300002)(6486002)(508600001)(66946007)(2616005)(956004)(4326008)(186003)(4744005)(66476007)(66556008)(26005)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?c2gvQi8weEd2Q1VERklsejlJNW9SNFViQXhLb09NVzNIL0txYXF5RlJiZHZY?=
 =?utf-8?B?MXViMHl6VGx5U3EyRHNPSjRLK2doTno4ZU5YYnlZVURLMzMvZWphaW5NVzZJ?=
 =?utf-8?B?Sk80V0NkUnJIcUVlZHpLVVdLc0pRWitPNVN6aE1qUlFHSll2R3RKM2lvNFV0?=
 =?utf-8?B?UEhCTlVnekF0TzRmWktRbE5JOTh6Z2NNNDg5a3V3VVZFRm1OMkNTWjhGQkln?=
 =?utf-8?B?bVBiT1Q3MGNpNnE3cHY2WDdUS3BUeHJYSU1ibDVoYWwrYWxGTVBNcktUZXN5?=
 =?utf-8?B?a3NpV2g5MlBmSjFROTVtalphaVpyWVJ1K25JZGlMV1R5Q3U5SEtaZjR4Z0tv?=
 =?utf-8?B?dmdKcnFqU2FJSjFubTYzVEN2SjJEclUxdE5JR2FBUDFtMFFtWnZLVWtsQWl6?=
 =?utf-8?B?K3JWZ1hheURvNkl2UVBRTHpwWWgwVWVweXYyUVErU3hKUStVSVI5ajFXZVFQ?=
 =?utf-8?B?cXJveXlsTVZYNjJGVTZGdnExL05laTYyL3E2eGxLdTcyRWs5bDJ0VnNlQlli?=
 =?utf-8?B?SGdlanVFQ0Q0QXpqSzNJd1JTZUZJQnBJcDVXWGlqRnc5Z0tlMWxKQ1NobUQ1?=
 =?utf-8?B?dUZJTG41TG95ZzRoTXNsN1ZqNTdCcEVjd2pubEl5RzVCWWxscVE1bDZ4OVpC?=
 =?utf-8?B?TjUzQ0k0Y1NrbjZKTll4cjZ3eU1aOEhjVnZ5YU1jcVlTMXdialNlNmZ5QWhl?=
 =?utf-8?B?cE5lbmxCNWxCR0pFc3hDVFJSVWF4T3BOUloxUlE4cXFuR055L25GK29uTjBO?=
 =?utf-8?B?bTNOY3cwYnptM00zMEV1RjRleXFQL2NnNFYzMFhPdTFoa2pjNEtQNFVzZXJR?=
 =?utf-8?B?MGZGNUtkamhnWkNIU1crdEZYSmNRMklaaE8rZERFTGpoWktMM3ZOVWc5N2Zy?=
 =?utf-8?B?RlZYazFrUkdBSk5qYTE2dUNTNFhXNm1LdS9LV0dTS3FDN2NsUkNzN0pkNjYv?=
 =?utf-8?B?UGVLQnhsblk3alU4WlJweU5ML2FsZ1ZBZEJtRnl4QVFzbEE5ZkIxOGlSZW4r?=
 =?utf-8?B?ek5QRlpWMDdJSjA5VHZkeFhZbkFYOEtQaTFINTRub2Q1bnI2Z0pJeHdTTlBU?=
 =?utf-8?B?cG9ZdUZmdTlqcG9QdjhnbFRtWkdESVEwWHZKdFZCM2dwbGxCeTJTZlZnSkNN?=
 =?utf-8?B?eDM3MmJTQTB6eWxQTjRJQnhsMmQxMFp3a0hJc2tZVFdVa0orSUdBV1A5amxs?=
 =?utf-8?B?VE9lN2thUjdMY2EyUEVJMkpURERXWXg2L3Y3NFFmL2JhTFlPcU53akFDY2Q0?=
 =?utf-8?B?Yi9XZktOZ01RZG1hSWlHYU1kamUwVDEyOVF6NlNzT0E0Nk9aTE54Si9uYVBV?=
 =?utf-8?B?SG1pOWZQbDFiTHR6alcwdlhJS2lzMStQSlA1SUR2WjBVV0twQ3N0WTQxQlhp?=
 =?utf-8?B?TzJYUnpZZk5wR1J0ZVg4c2NzWGdzcmNEaVg0amRYK2tWZHh1NXZ0dUZxSWVk?=
 =?utf-8?B?cU0yQ1pKZEoyZlFjblBPenJ4RERLS243aXNFbndWK3hkb3YvYWRZbTU5WXUv?=
 =?utf-8?B?V2xpVzc5MHhrbHp4d0l6ZEFRZzJnVDdBcnR3MlZBdVdvMGZKOFBtNXNiZ2Uw?=
 =?utf-8?B?bXpkek9wL2tsd0svRXRZTjdYK2YvcEgva3plU3Z4cEo4VXBxZFFVSWpTUlIw?=
 =?utf-8?B?YVpmVkxmL3NoSTlMZWVEUWFtQmp1UFVDOHE5RWFrN0E5ZERuU2x4bFdsTFlZ?=
 =?utf-8?B?RTArcjg2NmtuaEFyWGdnRXJQamVWblNyd2dFOWh0VkdQNmtqWGUvSG1ZZ2VW?=
 =?utf-8?Q?kXfBY1gQIYyU62JeOwDtsc016vEAhBswCqw0XSY?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 348b9875-df4b-4233-6f9b-08d98a5c7653
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Oct 2021 13:06:37.7319
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: umpzNmLPtEooYLHCzhwVZLOa4TDYiMlJghtM/43Q4fsg2oPDFAg9c3/rrv43rwNKdpAP1AglUaw/x4IrDvGowQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4191

Like for PV, 32-bit guests need to invoke the compat handler, not the
native one.

Fixes: db984809d61b ("hvm: wire up domctl and xsm hypercalls")
Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/arch/x86/hvm/hypercall.c
+++ b/xen/arch/x86/hvm/hypercall.c
@@ -138,7 +138,7 @@ static const struct {
     HYPERCALL(event_channel_op),
     COMPAT_CALL(sched_op),
     COMPAT_CALL(set_timer_op),
-    HYPERCALL(xsm_op),
+    COMPAT_CALL(xsm_op),
     HYPERCALL(hvm_op),
     HYPERCALL(sysctl),
     HYPERCALL(domctl),



From xen-devel-bounces@lists.xenproject.org Fri Oct 08 13:21:12 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Oct 2021 13:21:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.204729.359890 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYpoC-0005Q7-1S; Fri, 08 Oct 2021 13:21:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 204729.359890; Fri, 08 Oct 2021 13:21:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYpoB-0005Q0-Uk; Fri, 08 Oct 2021 13:21:07 +0000
Received: by outflank-mailman (input) for mailman id 204729;
 Fri, 08 Oct 2021 13:21:06 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ioNN=O4=gmail.com=olekstysh@srs-us1.protection.inumbo.net>)
 id 1mYpoA-0005Pu-ED
 for xen-devel@lists.xenproject.org; Fri, 08 Oct 2021 13:21:06 +0000
Received: from mail-ed1-x530.google.com (unknown [2a00:1450:4864:20::530])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 1ede6adc-a05f-4dfb-8d7a-faa6058767f3;
 Fri, 08 Oct 2021 13:21:05 +0000 (UTC)
Received: by mail-ed1-x530.google.com with SMTP id g8so36419759edt.7
 for <xen-devel@lists.xenproject.org>; Fri, 08 Oct 2021 06:21:05 -0700 (PDT)
Received: from [192.168.1.7] ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id q18sm915408ejc.84.2021.10.08.06.21.01
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Fri, 08 Oct 2021 06:21:02 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1ede6adc-a05f-4dfb-8d7a-faa6058767f3
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-transfer-encoding:content-language;
        bh=HImk4itwCVYEvOpDrBtzEhuEI4WM1KqqfELDSsaj/wo=;
        b=qCS6yeQq9ZLr9ZcvR0Zt0XrotUFqvo0/HafLmgCbIZbozJR9kU/kQtc7GxXWCFf38q
         7wImhooSbNFa5fs8r6DXwjikAdCNbPw7mb+zKZnjVT6RCULevvMHXib/P1tIy/No6rBx
         KesLyf0G8nMkdrq09lFHcRoz73O8VvoNnJXmSe7F5tDTL0FeKVurhPcKJSRHRbKzr43V
         KmjyLYrqJC0qG5ZREdeom9G3pr06b+lJKExu06O4Q26wQD3zzgZwhd/KJzskyC9RdKbA
         STrFiCAsMXCj/KxYt00C2mtlgLGr6S4DHeqWt6J1g4NRlSYmMHA7ZGa7OxlmHuy7dVpl
         Jn3A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding
         :content-language;
        bh=HImk4itwCVYEvOpDrBtzEhuEI4WM1KqqfELDSsaj/wo=;
        b=CVPkuyQ3yWlJzuS3SzkZnacSyD0kE4tIqwHROvndPLzxIQqC+HMqyr7aPsMSacABmF
         gplsGI2R02N8jgBUYdd1WLumh2ujvGa86vuteYDdPm3gCZzHTcwhgSLwwBV2EiBZzH5n
         T17Zj3RawdbO/EhjSV59oDTwOuB0TZZsd3gqDNWsXrirrppVbeOKyt0/9/lOivXneYtA
         /T3A0gbd7783JrnuCU7l37nM5KUrOOCLsLu8axk4ZpjpvILNsgaaqzmhWrKl1ytq/DKy
         hXM7QSrmQfAdw6K129psU9H3EALs3N4QcqCZLi4dnhkkqz6IZ30Z7Qxj5Fzm92mm2pnB
         AhFg==
X-Gm-Message-State: AOAM531u9XfoGayDd42rCLDWZsA0Fm6bJ4Jkl9CETcdVaBfEzuxXKPWK
	KlP88ahfq5D6beQ9TVfSX1VkQtH1UwQ=
X-Google-Smtp-Source: ABdhPJwX1hbPNKvfOyvD46mgN2jkFlJNEsrdzVhEYv66HWz/6C3+q6M+uuI6SgPknHWywyAKCa8Kjg==
X-Received: by 2002:a17:906:2f16:: with SMTP id v22mr4038222eji.126.1633699262706;
        Fri, 08 Oct 2021 06:21:02 -0700 (PDT)
Subject: Re: [PATCH V5 1/3] xen/arm: Introduce gpaddr_bits field to struct
 xen_arch_domainconfig
To: Jan Beulich <jbeulich@suse.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>,
 Anthony PERARD <anthony.perard@citrix.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Juergen Gross <jgross@suse.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 xen-devel@lists.xenproject.org
References: <1633519346-3686-1-git-send-email-olekstysh@gmail.com>
 <1633519346-3686-2-git-send-email-olekstysh@gmail.com>
 <68cb29bb-7d84-dc27-eead-4a079b9caf68@suse.com>
 <e77eea6f-163d-0920-2e90-fb9f3a602743@gmail.com>
 <ffb40f3b-2394-7747-2c06-955e2aa87cfc@suse.com>
 <387608b9-c7b2-e814-7fa5-a262acc0c73d@gmail.com>
 <ae852345-66ff-7bcf-f68e-2161e23933a1@suse.com>
 <alpine.DEB.2.21.2110071311450.414@sstabellini-ThinkPad-T480s>
 <b8e868a2-9af3-de6c-0683-4bb2ff7821f3@suse.com>
 <b36e5fb7-6ed0-dc7d-5ed3-c3c9c9ae70b5@gmail.com>
 <ff760c65-1041-aac6-40ed-981f0b900678@suse.com>
From: Oleksandr <olekstysh@gmail.com>
Message-ID: <2fcb101c-28b0-67c5-0f4d-e3d75b9f4d33@gmail.com>
Date: Fri, 8 Oct 2021 16:21:01 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <ff760c65-1041-aac6-40ed-981f0b900678@suse.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US


On 08.10.21 15:36, Jan Beulich wrote:

Hi Jan

> On 08.10.2021 12:25, Oleksandr wrote:
>> Just a quick question. What do you think can XEN_DOMCTL_getdomaininfo be
>> reused to retrieve gpaddr_bits? I don't see why not at the moment, but
>> maybe there are some implications/concerns which are invisible to me.
>>
>> I see that arch_get_domain_info() is present, so the field will be
>> common, and each arch will write a value it considers
>> appropriate. This could be a good compromise to not add an extra domctl
>> and to not alter domain_create.
> Technically I think it could be reused. What I'm less certain of is
> whether the specific piece of information is a good fit there.

ok, thank you for your answer.

I am also not 100% sure whether it is a *good* fit there, but I cannot 
say it is not fit at all for being there. I might mistake, but it is 
almost the same piece of information describing the whole domain as 
other existing fields in that structure.



>
> Jan
>
-- 
Regards,

Oleksandr Tyshchenko



From xen-devel-bounces@lists.xenproject.org Fri Oct 08 13:38:31 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Oct 2021 13:38:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.204742.359906 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYq4v-00076Q-Gf; Fri, 08 Oct 2021 13:38:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 204742.359906; Fri, 08 Oct 2021 13:38:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYq4v-00076J-DL; Fri, 08 Oct 2021 13:38:25 +0000
Received: by outflank-mailman (input) for mailman id 204742;
 Fri, 08 Oct 2021 13:38:24 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=z9mS=O4=arm.com=Luca.Fancellu@srs-us1.protection.inumbo.net>)
 id 1mYq4u-00076D-2V
 for xen-devel@lists.xenproject.org; Fri, 08 Oct 2021 13:38:24 +0000
Received: from EUR01-VE1-obe.outbound.protection.outlook.com (unknown
 [40.107.14.85]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 00f19da4-283d-11ec-803f-12813bfff9fa;
 Fri, 08 Oct 2021 13:38:22 +0000 (UTC)
Received: from DU2PR04CA0177.eurprd04.prod.outlook.com (2603:10a6:10:2b0::32)
 by AM6PR08MB5079.eurprd08.prod.outlook.com (2603:10a6:20b:e8::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.19; Fri, 8 Oct
 2021 13:38:19 +0000
Received: from DB5EUR03FT026.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:10:2b0:cafe::32) by DU2PR04CA0177.outlook.office365.com
 (2603:10a6:10:2b0::32) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.16 via Frontend
 Transport; Fri, 8 Oct 2021 13:38:19 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT026.mail.protection.outlook.com (10.152.20.159) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4587.18 via Frontend Transport; Fri, 8 Oct 2021 13:38:19 +0000
Received: ("Tessian outbound 8e26f7114b75:v103");
 Fri, 08 Oct 2021 13:38:19 +0000
Received: from 56fb6f9cdbf3.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 91A8C578-14E5-4037-BD6A-092DA4480A70.1; 
 Fri, 08 Oct 2021 13:38:13 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 56fb6f9cdbf3.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 08 Oct 2021 13:38:13 +0000
Received: from PAXPR08MB6816.eurprd08.prod.outlook.com (2603:10a6:102:130::10)
 by PAXPR08MB6847.eurprd08.prod.outlook.com (2603:10a6:102:13d::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18; Fri, 8 Oct
 2021 13:38:12 +0000
Received: from PAXPR08MB6816.eurprd08.prod.outlook.com
 ([fe80::c1b4:db1c:376f:b697]) by PAXPR08MB6816.eurprd08.prod.outlook.com
 ([fe80::c1b4:db1c:376f:b697%8]) with mapi id 15.20.4587.022; Fri, 8 Oct 2021
 13:38:12 +0000
Received: from smtpclient.apple (82.8.129.65) by
 LO2P123CA0021.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:a6::33) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4587.18 via Frontend Transport; Fri, 8 Oct 2021 13:38:11 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 00f19da4-283d-11ec-803f-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Sv2ml6lyyNW+SNI4IoANswTuv0imJQXHfHwkQibWpDU=;
 b=cKySTScKqwOJXsKG6TWrwQ+LD/4+J94gv6Dd+KoJ4qpdSjdcVcetie0OtiRD3AaXWlGhh6YR604DQ4I/ssl7kY4lgx2gFkst1nEpDOai8Vkdou3PXhU+oprC7C69+Ly3e8SliUiTVCOccSMgcEko8Q3gSLGz3Gmfxvezfw34I1M=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 99a8b8938184e80f
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=JN8x+5uepIMKiUci7EW0JeFdBIVGfX0VMzq7sIa9HXUp4vk2fBwPhunvzqTAttNOfKa0UdsFq7PvCIkoywLt4D9zYZL7NEcs1e5IseyZUK4fPytxXTkgkhHloCp1Jp0u4nSUgy5yVefKKIFA+m9wxNeszx2dE1qqD/MdFAWljW13kNLe9nGx7HO4mbO3GpAEIaEBY4SZIkI4dcmzFwLPo1e13NslmOjj5Ym7n+sBie6QIMypyiALK70PNPItEjUr7o35A6KrIWYZ3fr88vtIp1XUap4pDvIptzP4PCFKnYUHiZJ2mJax4sY7SK5AUYpA0AWmQ6Pwzmai6bjlcTUczA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Sv2ml6lyyNW+SNI4IoANswTuv0imJQXHfHwkQibWpDU=;
 b=E04vHmkFYR72N67u+wAdYqDOPvrLnMFrby+736oMQcWHr2IIqkPrSqgr1Me48VFzNuDdSE7r91C1uh4fRRMk1LM2iOqQ+8WEfmBv87Uz6dAn8rFL0oFhTzA2Clo/VlSJ5PByN/XwplfcLxGuCvWWal3OkWD+MnFZpe4OvF0F69JrR8m74IYdXkVBt0nLT3TEWFHH9at9Xb5LkY6iZpupu6SK2SJCVFYB32HwFDrj9go48CZKCVNmgWs8MCj5VKN4egCLXmeyKagGxYlN0wZihwPNGA4nncABHqzKSDZzaa85xGXeXgkd28LlHVCFCc6Q2PhYb8kHHiIvgxVwrtNl/w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Sv2ml6lyyNW+SNI4IoANswTuv0imJQXHfHwkQibWpDU=;
 b=cKySTScKqwOJXsKG6TWrwQ+LD/4+J94gv6Dd+KoJ4qpdSjdcVcetie0OtiRD3AaXWlGhh6YR604DQ4I/ssl7kY4lgx2gFkst1nEpDOai8Vkdou3PXhU+oprC7C69+Ly3e8SliUiTVCOccSMgcEko8Q3gSLGz3Gmfxvezfw34I1M=
Authentication-Results-Original: suse.com; dkim=none (message not signed)
 header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
Content-Type: text/plain;
	charset=utf-8
Subject: Re: [PATCH v4 2/3] arm/efi: Use dom0less configuration when using EFI
 boot
From: Luca Fancellu <luca.fancellu@arm.com>
In-Reply-To: <00328991-2c85-fed8-40d6-c33ecac7e1e8@suse.com>
Date: Fri, 8 Oct 2021 14:38:03 +0100
Cc: Bertrand Marquis <bertrand.marquis@arm.com>,
 wei.chen@arm.com,
 Stefano Stabellini <sstabellini@kernel.org>,
 Julien Grall <julien@xen.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Ian Jackson <iwj@xenproject.org>,
 Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <EA18C41E-43FD-4C21-B11B-E776DC260974@arm.com>
References: <20210930142846.13348-1-luca.fancellu@arm.com>
 <20210930142846.13348-3-luca.fancellu@arm.com>
 <2fa4be34-9c69-21cb-632f-f566caf622ca@suse.com>
 <6DFF05BA-8250-4C6C-86DF-67997F8DAD46@arm.com>
 <ce8e7fda-4d74-4bce-78bd-387f9b7a395f@suse.com>
 <55D6C05A-C0B4-4503-A7F8-D0BA11E0779B@arm.com>
 <00328991-2c85-fed8-40d6-c33ecac7e1e8@suse.com>
To: Jan Beulich <jbeulich@suse.com>
X-Mailer: Apple Mail (2.3654.120.0.1.13)
X-ClientProxiedBy: LO2P123CA0021.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:a6::33) To PAXPR08MB6816.eurprd08.prod.outlook.com
 (2603:10a6:102:130::10)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 19e721a5-2a80-44dc-8071-08d98a60e3ee
X-MS-TrafficTypeDiagnostic: PAXPR08MB6847:|AM6PR08MB5079:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS:
	<AM6PR08MB507977BFC3F9AF8E4EE1D772E4B29@AM6PR08MB5079.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Oob-TLC-OOBClassifiers: OLM:5516;OLM:5516;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 ufEpF3MhaEg/az4qfiM+nxSL2m8YEjLrbM8mlsVS+ONY4TaFNlTvzZeoHu6W8bQCgU8Svg5UWOQn1ORC0RjxYSVX0eSFsnFOKChes69wpYoEwsiH+qPa2nRMLF7zZb75jLJp3mmfyzj2UGQi7jqeG/beeCsj2bqRao8b2AFfUgDziZWq/bmvApNbsl8u7mG6I5JpJ6tdcGMIZbx9lNugn9w52blr9anv5L9uHs1f/aYxMdqaGgovJeiIVFuDz5wFYvvi1DSkldyPa9imJXknJLG8ps1V1lGgG46hVbLJoMSwK3G/iXHTn98OPwLTYF2LxGO+TX9CoT0cxcyj16H1KhHuDoK22z0UWqhp3Xdmng8hT01VyUVVbHTEgAVJUlNPUoxVhOxY4GfidGwNg7YYmzuLfh8P8+UzwJo8hxEYSh7/1c96sCLPdjF9rAboSdshGWUNhkRBQPotTlYhI09l1M2+TEK7qpt0mK25cykcYKkT42UpDRZBr2poCHbLHzGFdVmz+M8TZzE5noD90SA7BxFu9qSRb0oPs0lEnoGOxl7a5Nh5r6pc2cwIIEZxBozfn0KL0HYGVPxk2h+9/IQCnIowWvxTVme9vmgw17i131V3QqrAa66t9qdYCamsT8mKHZdxYI4horzZB5vfchIVUz0U9ZG0j7fOp2wW0gfTTPlq9lcmGNhD4se3NthDX/OKm5eutr1cm6YPubxr6T6UG6+SxNfJQIcv+1x47frHni5Wm6ID/yjWFBUkFm0W0D5Y
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB6816.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(66476007)(5660300002)(66556008)(316002)(66946007)(53546011)(6512007)(6506007)(8936002)(36756003)(6486002)(52116002)(8676002)(38350700002)(38100700002)(83380400001)(54906003)(44832011)(2906002)(6666004)(33656002)(4326008)(2616005)(6916009)(26005)(86362001)(508600001)(956004)(186003)(32563001)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6847
Original-Authentication-Results: suse.com; dkim=none (message not signed)
 header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT026.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	b28d624d-d4cd-4554-e1f7-08d98a60df70
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	pDI7HByheMn9I5PElPPXVLXDH1UbThhyQAZ94/ZU/FpDxO/jLYeV0nxARtiWEtSzCFhCtt6/MOZ7t7ry1Zjefdo79uXET4qtYZBv/R9pgjcX9/NMJGpvwJRgIbflz+RRoVwsBH58bb/Jst7OLpBrA8/gfV+uFQH9ZqiCGaBgbL3Vf0rGcxQdaHZ21c3iTHiSH2VvPmQbA8r6cQPAbYM5ev9Srjuswi7siXvLYYbc54WXT59HHL+BojhzRyC3tidKP6VjemkOej1Y6LRCn4gzZDN8/Z1vnjujR/wc4d7M37Tt0+p8pFzvCc/F4oG0heqmyr0lMks6l82lji9ZFBHGpy01P61PEyiIWDtpVcuO9/3SA0NZesv0eOK8qaOlX1gIQ7alAn1oAEV/ZMYIvAUBUeV41cMod3bN9AvfeCNGunUVYH8brSYEvI01Rxgn4BxHoEN8rLpxyQPR+iQxRfhDt3QRY9O+zOl35KKgizTFItOCZq3EEHewsfmoIMPrO0M2hmBPQfLFBTEBpXzluzJUx31oVpIelQ8E6BKtb8Ah//xwzIagq1EjeSuLCyO+f+VgWOgr9Xt2zd8BTD1JYBnZATksXWRGTJTf6FTPo0zRQXsJ60CRjyeZ6dfiXBirY4swz3HzJ+w428M+L+IJxPlWNTs/qR0AWz5PkRCQXH+OykR7LAgDwmDk5o2uznv5bA9huxHH9tMVCr/U5ua/GGafjTBQX14qtDqMc8feWxiWeDU=
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(81166007)(6862004)(6486002)(2906002)(26005)(36756003)(82310400003)(356005)(508600001)(33656002)(6666004)(4326008)(5660300002)(53546011)(316002)(86362001)(8936002)(6512007)(70586007)(47076005)(54906003)(336012)(36860700001)(2616005)(8676002)(6506007)(186003)(44832011)(83380400001)(956004)(70206006)(32563001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Oct 2021 13:38:19.5117
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 19e721a5-2a80-44dc-8071-08d98a60e3ee
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT026.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB5079



> On 7 Oct 2021, at 08:15, Jan Beulich <jbeulich@suse.com> wrote:
>=20
> On 01.10.2021 17:13, Luca Fancellu wrote:
>>=20
>>=20
>>> On 1 Oct 2021, at 15:22, Jan Beulich <jbeulich@suse.com> wrote:
>>>=20
>>> On 01.10.2021 15:55, Luca Fancellu wrote:
>>>>> On 1 Oct 2021, at 12:02, Jan Beulich <jbeulich@suse.com> wrote:
>>>>> On 30.09.2021 16:28, Luca Fancellu wrote:
>>>>>> @@ -1361,12 +1361,30 @@ efi_start(EFI_HANDLE ImageHandle, EFI_SYSTEM=
_TABLE *SystemTable)
>>>>>>       efi_bs->FreePages(cfg.addr, PFN_UP(cfg.size));
>>>>>>       cfg.addr =3D 0;
>>>>>>=20
>>>>>> -        dir_handle->Close(dir_handle);
>>>>>> -
>>>>>>       if ( gop && !base_video )
>>>>>>           gop_mode =3D efi_find_gop_mode(gop, cols, rows, depth);
>>>>>>   }
>>>>>>=20
>>>>>> +#ifdef CONFIG_HAS_DEVICE_TREE
>>>>>> +    /* Get the number of boot modules specified on the DT or an err=
or (<0) */
>>>>>> +    dt_modules_found =3D efi_arch_check_dt_boot(dir_handle);
>>>>>> +#endif
>>>>>=20
>>>>> So I had asked to add a stub enclosed in such an #ifdef, to avoid the
>>>>> #ifdef here. I may be willing to let you keep things as you have them
>>>>> now, but I'd like to understand why you've picked that different
>>>>> approach despite the prior discussion.
>>>>=20
>>>> There must be a misunderstanding, your message in the v3 was:
>>>>=20
>>>> "Every time I see this addition I'm getting puzzled. As a result I'm
>>>> afraid I now need to finally ask you to do something about this (and
>>>> I'm sorry for doing so only now). There would better be no notion of
>>>> DT in x86 code, and there would better also not be a need for
>>>> architectures not supporting DT to each supply such a stub. Instead
>>>> I think you want to put this stub in xen/common/efi/boot.c, inside a
>>>> suitable #ifdef.=E2=80=9D
>>>>=20
>>>> So I thought you wanted me to remove the stub in x86 (since it doesn=
=E2=80=99t support DT)
>>>> and put this call under #ifdef so it won=E2=80=99t be compiled for arc=
h not supporting DT.
>>>=20
>>> So FTAOD I'll repeat the crucial part: "I think you want to put this
>>> stub in xen/common/efi/boot.c". There was nothing about removing the
>>> stub altogether.
>>=20
>> Oh ok, now I see, so in your opinion this is a better idea:
>>=20
>> #ifndef CONFIG_HAS_DEVICE_TREE
>> static inline int __init efi_arch_check_dt_boot(EFI_FILE_HANDLE dir_hand=
le)
>> {
>>    return 0;
>> }
>> #endif
>>=20
>> But I would like to understand the advantage respect of my approach, cou=
ld you
>> explain me?
>=20
> Well, to a degree it's a matter of taste. Your approach may lead to a lon=
g
> series of various #ifdef sections in a single function, harming readabili=
ty.
> Having stubs instead (usually placed in headers, albeit not in this case)
> allows the main bodies of code to remain more tidy.

Yes right, in this case I did in another way because declaring the stub in =
the .c file
was (in my opinion) not the right thing to do, since also the name (efi_arc=
h_*) recalls
something arch oriented and so not to be put in the common code.

In this way any future architecture supporting DT, can just provide the fun=
ction (or a=20
stub) and we don=E2=80=99t have stubs in architectures that won=E2=80=99t e=
ver support DT.

In your opinion that solution could be acceptable?

Cheers,
Luca

>=20
> Jan



From xen-devel-bounces@lists.xenproject.org Fri Oct 08 14:15:04 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Oct 2021 14:15:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.204755.359916 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYqeE-0002vk-Cl; Fri, 08 Oct 2021 14:14:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 204755.359916; Fri, 08 Oct 2021 14:14:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYqeE-0002vd-9e; Fri, 08 Oct 2021 14:14:54 +0000
Received: by outflank-mailman (input) for mailman id 204755;
 Fri, 08 Oct 2021 14:14:52 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=aYfl=O4=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mYqeC-0002vX-Rz
 for xen-devel@lists.xenproject.org; Fri, 08 Oct 2021 14:14:52 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 6b84eefe-8420-4641-9eea-92f06ea89abf;
 Fri, 08 Oct 2021 14:14:51 +0000 (UTC)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2052.outbound.protection.outlook.com [104.47.13.52]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-27-19Achb4rP0-6blozhCCc3Q-1; Fri, 08 Oct 2021 16:14:49 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0401MB2336.eurprd04.prod.outlook.com (2603:10a6:800:27::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.19; Fri, 8 Oct
 2021 14:14:45 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4587.022; Fri, 8 Oct 2021
 14:14:45 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6P191CA0071.EURP191.PROD.OUTLOOK.COM (2603:10a6:209:7f::48) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4587.21 via Frontend Transport; Fri, 8 Oct 2021 14:14:44 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6b84eefe-8420-4641-9eea-92f06ea89abf
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1633702490;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=LMEqGFS5y5vLOLSi0f8sG/F5xvIv5BI8oOWW4fXAJMc=;
	b=P7Zcba1ByuHT2+Y8mvQJiZutvTW39fUjkGHmJzcsRxsQz517BL81C8VjU3wZrgtWbCt2jg
	qFgEyK4zhcW63EOseqrgxVm7xS/ndMGpKng/5bUw4Kf3eF6vSAAXCzz9Ob+IRrCG212rTl
	mF3JLb2vRDghhDaWJ5tKLKSCQwPFeEM=
X-MC-Unique: 19Achb4rP0-6blozhCCc3Q-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=GUYQN6gTACL1wpowQg9tnuPeMCkMMTpJOJP3wZ7SDFcUb6yZgshCR+neA7do7rllP1X1+vmpyLUZaeSCeRcEV1G4rYhMQZLmoJvxU8XRsn84xMHSsydLE6+NYxOxqDcA987jxmJxwOfSWlqH5ndgvkQZvYQC/5aOo/BZzB6F8nvuvnhiE+V5ri95tWL4V1/x3kKcZXli6yO9vegN4eM4Pi3zRJ76Ix+MpG+iCutUAFhgYAAn4lN1KJ2jYBXTUs04KYCXQNQcRQ9TwNdchUQm1JdhmlDj1VwFsy+URHEE/zkw6P+PHuyQSyMfIKp0jfNS/Sw5lEr5cu7001YGbwyjJg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=aXv1ERi9cd99hYeUcIgKcsjZuWenVVS8l730ZkjOxsQ=;
 b=GZkIEnlZoyKv+1VAm1/LMgl01K3SKtL1sKOTVc2kcXgnBHTkqSABf9RnOgBU5v/mozGD59Su4g0OrUHBr9isHpyyJbwzOpDGALAidiWWLegYw1YCgnSVmGqhwxoOR+rTWoFDy/laq8nRPhD96A8zDm6XTy9O4TCe6lGGqUoLtDjhPMynyJwawBCsmmhqsICcrko9wyZMPQu+1Mb7O+jFGfzh9zCpF0oCWdYfRhwlvL9fIXfZ45mrCCHrOZev4yxk0ouYGVdWVvKPBj9fU5NqX2h6CH1UzhK/bzfGPYubFKPk+YnIdc+Erfy7bNEr7ssM8eHjdf5c/w2JGzRWJGbsxQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [PATCH v4 2/3] arm/efi: Use dom0less configuration when using EFI
 boot
To: Luca Fancellu <luca.fancellu@arm.com>
CC: Bertrand Marquis <bertrand.marquis@arm.com>, wei.chen@arm.com,
 Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Wei Liu <wl@xen.org>, xen-devel@lists.xenproject.org
References: <20210930142846.13348-1-luca.fancellu@arm.com>
 <20210930142846.13348-3-luca.fancellu@arm.com>
 <2fa4be34-9c69-21cb-632f-f566caf622ca@suse.com>
 <6DFF05BA-8250-4C6C-86DF-67997F8DAD46@arm.com>
 <ce8e7fda-4d74-4bce-78bd-387f9b7a395f@suse.com>
 <55D6C05A-C0B4-4503-A7F8-D0BA11E0779B@arm.com>
 <00328991-2c85-fed8-40d6-c33ecac7e1e8@suse.com>
 <EA18C41E-43FD-4C21-B11B-E776DC260974@arm.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <bbeb5e61-665c-0c3d-cab0-a79b04af80bc@suse.com>
Date: Fri, 8 Oct 2021 16:14:42 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <EA18C41E-43FD-4C21-B11B-E776DC260974@arm.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6P191CA0071.EURP191.PROD.OUTLOOK.COM
 (2603:10a6:209:7f::48) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: a65a845b-a289-4045-9325-08d98a65fa78
X-MS-TrafficTypeDiagnostic: VI1PR0401MB2336:
X-Microsoft-Antispam-PRVS:
	<VI1PR0401MB23368AC8A9DAA2D3FBF17627B3B29@VI1PR0401MB2336.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6108;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	dP4hzswDVlqF9Sq5B+/CWBWmKH8ulV/Jyk+7Hg+zMiuP9JwqcLfMSC8PURg7GkDjC/gTImZ3MdXYFi1LXq98dgE7qETBELefQqu3hElINhUH7Fb3FH7vbDsM0CpNjK8nkMA1kvLPbhIui3AKllyYcFp6L/Ip6Dj6ohAaU9Pw1FtWDbP4ugdtV8EmgV/LPVszEtY8VEJFPCUXQD7j/xcwEiaBDLXCUXszjrdgLbxzF0vpnqrbtfhaeGPabcRp6+qIKqGYzNPZQgOtjxTu70OrgbfhyX2GTcFKgoOvRtrN0R0ZDMCLpCq6gOkBuusaLw2ZE0IiH0FbKY3YMqMMXVjwsqklovIHSsn00OnJUR+O2Lz0QW0NKexyI5Pfbl321YCYmHYmhV15N7GJmLJYLKoKliO4LfXSG7/sMRz5ZIyp9tvrMHXVb6ubyWgftPK8nDOgMSITH9AsFw4KHOF3QlQ6qKhTNIJl8WO9QIVSEI+XHcMZWVpsR1wUc6AAF/sdtDz5us6S+E0VZOWmpMpY6ILXe7Vr6YHL3VW2j8rLjzmUN18GX0c7dyxcD3kucTzY5t0uEnCBEsXgIXSM02udmYWzbMA/YOuuQKIk9YZIzTK5qyZuYyag6mo70y9mNNCULH4DpczEsoVkxzQMf/dTIMZUk6rKaUqxIymH1KlVq4YQmir8svkZxXqVf/XF959hp354zX31zxh4g2a/w2IW1Pd7mtuocT0hue7DEduBrPC72158mMFSkr1ZKtVacHcqBWHOlN8FiFmtIn3bxGGBnFrCww==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(2906002)(2616005)(66556008)(86362001)(36756003)(31686004)(26005)(6916009)(16576012)(956004)(54906003)(186003)(8936002)(4326008)(6486002)(316002)(38100700002)(83380400001)(66476007)(7416002)(5660300002)(66946007)(53546011)(508600001)(31696002)(8676002)(32563001)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?oofi9wTOfm5CsKA+HAYiQpkzWCuOHPDbkwJYQ11wPcY3PSlYcPM1OMKhD6oV?=
 =?us-ascii?Q?dtPW6B+ZOF4NRSZHfae6k/NO+NxvCopzcbHugmtwawALLTPOHt+wN3baEXNI?=
 =?us-ascii?Q?ugGIOKpVx6Nnq+VWpIvGKFlEPc1cISYWUnSid8Ijm6v794sAa21X6kODn6KV?=
 =?us-ascii?Q?6O9iwGK4D1KnPAP+C/f01Udpt9I1UAxoOZ0mEFDTdKMzY7T2GglXbLAM5lKZ?=
 =?us-ascii?Q?oOn6r4tPo8eUj2TGt9sExARNMk6mgSYt2cfXZrJcaBYHkiuSEQsxIMLvNQgo?=
 =?us-ascii?Q?cIpYFI54eV6OZAcFPHX/bT7Sh2kgujTw/DPoMm1MIeUqYthI2lfIbKxft0E/?=
 =?us-ascii?Q?GJWtCfJ1Fq0sdHAhSZkhjAZQ8AHxpZB6BCSXs6E6OkQuFxmmPlA3YUldqhju?=
 =?us-ascii?Q?iVdj57VLRwEavkBsxLv9aZBvMgRoWo7GpClzCvgNLoe5vCw/CfZMt7HHirit?=
 =?us-ascii?Q?gY2RnXKJrnNzlyESS8exx6drUnal3/NfFkZiuWobtd64bYusIbenSA7SftME?=
 =?us-ascii?Q?OtkN2W1P2NfJITAMvLuVZZfwP/+8X2/yvroeIMjG6KrrloQUL7/jmcYAfX8U?=
 =?us-ascii?Q?RmD4JPDO750qxO50NM4wzf5wJEHotLkW88iKGOYmMVsU42fsCcMZfZdRnt7t?=
 =?us-ascii?Q?qX5vcwQSczbJQfP2nKMbfdsklf0xIOk02D+4L2YvUfc9ZANyk4BWotMnMbmq?=
 =?us-ascii?Q?IvrC9NWXzHPtHoJDtnHqYzd9smi13+XaO/LEz8klCOIIxInwl3863fG7Lus5?=
 =?us-ascii?Q?SNS0uouhNmhXYzto6nlpFsJXLjsQvYpHwY3jWyDnvRYrNHLnn7y0Z5+O8XI3?=
 =?us-ascii?Q?Bl0bwpEguHp+wVZGb1Nn4+I/1nDRbhLAJI48J+g28K9+/99m3G0UNMrSSL6f?=
 =?us-ascii?Q?MU/HL/+MPopCnI7ans7KhI4PuGCEwowa0PnC4zQvLwhkjWDXQ1odPn8jl/TY?=
 =?us-ascii?Q?JpmDYZffIXIw0vEyvYMSNjeSKHy1kQJVQuXztZ/fV0sBSyqGLLHwTN4gpAQ9?=
 =?us-ascii?Q?dnPmJkTbCY5RX1HlTP6fqxEM0kucjrcL3zPAVyI4Vss5wscDE0j+YBs20T9q?=
 =?us-ascii?Q?c85P/slKeWZK82r7ms7IkaibV2C20dTw05eZ2+V5OdlHxNBexyBG1CEF74CU?=
 =?us-ascii?Q?DXtOKsKiKJFv9QRf5afWDXIZm5uurc9TGGG2SzqUvJV2+2PK/rSJn/Yu2rjr?=
 =?us-ascii?Q?wko688eSSI7SjqS9vkp2mBNUnO6bZ981nLg5AA3kBI/jOqaXGb4VQDzz8PxV?=
 =?us-ascii?Q?VUu79BPoxCq55H8JSmluuM9FOOScGeuw4Z5ttP6rgY7GU1VGCr5bX4AmtVam?=
 =?us-ascii?Q?UKTBhwaqNe1GehSL9nY86Gkh?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a65a845b-a289-4045-9325-08d98a65fa78
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Oct 2021 14:14:44.9521
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Tz5XuOtbDc5I3WHfzUEl8WS4OnjKcToMQgbza2IHJjuujl4IAcZmnHFf4++NhiLDyhZdnhlfodeFeYZ/sC0ZHA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2336

On 08.10.2021 15:38, Luca Fancellu wrote:
>> On 7 Oct 2021, at 08:15, Jan Beulich <jbeulich@suse.com> wrote:
>> On 01.10.2021 17:13, Luca Fancellu wrote:
>>>> On 1 Oct 2021, at 15:22, Jan Beulich <jbeulich@suse.com> wrote:
>>>> On 01.10.2021 15:55, Luca Fancellu wrote:
>>>>>> On 1 Oct 2021, at 12:02, Jan Beulich <jbeulich@suse.com> wrote:
>>>>>> On 30.09.2021 16:28, Luca Fancellu wrote:
>>>>>>> @@ -1361,12 +1361,30 @@ efi_start(EFI_HANDLE ImageHandle, EFI_SYSTE=
M_TABLE *SystemTable)
>>>>>>>       efi_bs->FreePages(cfg.addr, PFN_UP(cfg.size));
>>>>>>>       cfg.addr =3D 0;
>>>>>>>
>>>>>>> -        dir_handle->Close(dir_handle);
>>>>>>> -
>>>>>>>       if ( gop && !base_video )
>>>>>>>           gop_mode =3D efi_find_gop_mode(gop, cols, rows, depth);
>>>>>>>   }
>>>>>>>
>>>>>>> +#ifdef CONFIG_HAS_DEVICE_TREE
>>>>>>> +    /* Get the number of boot modules specified on the DT or an er=
ror (<0) */
>>>>>>> +    dt_modules_found =3D efi_arch_check_dt_boot(dir_handle);
>>>>>>> +#endif
>>>>>>
>>>>>> So I had asked to add a stub enclosed in such an #ifdef, to avoid th=
e
>>>>>> #ifdef here. I may be willing to let you keep things as you have the=
m
>>>>>> now, but I'd like to understand why you've picked that different
>>>>>> approach despite the prior discussion.
>>>>>
>>>>> There must be a misunderstanding, your message in the v3 was:
>>>>>
>>>>> "Every time I see this addition I'm getting puzzled. As a result I'm
>>>>> afraid I now need to finally ask you to do something about this (and
>>>>> I'm sorry for doing so only now). There would better be no notion of
>>>>> DT in x86 code, and there would better also not be a need for
>>>>> architectures not supporting DT to each supply such a stub. Instead
>>>>> I think you want to put this stub in xen/common/efi/boot.c, inside a
>>>>> suitable #ifdef.=E2=80=9D
>>>>>
>>>>> So I thought you wanted me to remove the stub in x86 (since it doesn=
=E2=80=99t support DT)
>>>>> and put this call under #ifdef so it won=E2=80=99t be compiled for ar=
ch not supporting DT.
>>>>
>>>> So FTAOD I'll repeat the crucial part: "I think you want to put this
>>>> stub in xen/common/efi/boot.c". There was nothing about removing the
>>>> stub altogether.
>>>
>>> Oh ok, now I see, so in your opinion this is a better idea:
>>>
>>> #ifndef CONFIG_HAS_DEVICE_TREE
>>> static inline int __init efi_arch_check_dt_boot(EFI_FILE_HANDLE dir_han=
dle)
>>> {
>>>    return 0;
>>> }
>>> #endif
>>>
>>> But I would like to understand the advantage respect of my approach, co=
uld you
>>> explain me?
>>
>> Well, to a degree it's a matter of taste. Your approach may lead to a lo=
ng
>> series of various #ifdef sections in a single function, harming readabil=
ity.
>> Having stubs instead (usually placed in headers, albeit not in this case=
)
>> allows the main bodies of code to remain more tidy.
>=20
> Yes right, in this case I did in another way because declaring the stub i=
n the .c file
> was (in my opinion) not the right thing to do, since also the name (efi_a=
rch_*) recalls
> something arch oriented and so not to be put in the common code.

Feel free to drop "arch" from the hook name.

> In this way any future architecture supporting DT, can just provide the f=
unction (or a=20
> stub) and we don=E2=80=99t have stubs in architectures that won=E2=80=99t=
 ever support DT.
>=20
> In your opinion that solution could be acceptable?

Yes, but not preferable.

Jan



From xen-devel-bounces@lists.xenproject.org Fri Oct 08 14:19:15 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Oct 2021 14:19:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.204766.359928 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYqiR-0003gq-1y; Fri, 08 Oct 2021 14:19:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 204766.359928; Fri, 08 Oct 2021 14:19:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYqiQ-0003gj-V5; Fri, 08 Oct 2021 14:19:14 +0000
Received: by outflank-mailman (input) for mailman id 204766;
 Fri, 08 Oct 2021 14:19:14 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=O4Zs=O4=suse.com=jgross@srs-us1.protection.inumbo.net>)
 id 1mYqiP-0003gb-Uq
 for xen-devel@lists.xenproject.org; Fri, 08 Oct 2021 14:19:13 +0000
Received: from smtp-out2.suse.de (unknown [195.135.220.29])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 5789f9e5-bd82-420f-a96d-b6d34959d368;
 Fri, 08 Oct 2021 14:19:13 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 5914D20140;
 Fri,  8 Oct 2021 14:19:12 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 3330B13F32;
 Fri,  8 Oct 2021 14:19:12 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id bMY5C2BTYGFYAwAAMHmgww
 (envelope-from <jgross@suse.com>); Fri, 08 Oct 2021 14:19:12 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5789f9e5-bd82-420f-a96d-b6d34959d368
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1633702752; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:  content-transfer-encoding:content-transfer-encoding;
	bh=pNRxqDzRd//O+QxPugznEJ//I+bfjQ3sudVxpkNPHwc=;
	b=au5vd2FzDudAbuVRHoP5Rw1v3z854jAMXJKhfBYq0t/8y4dO2+eN0hzwzX7RPRMCwnN8P4
	NW49dv2ufXw16oMepaw/D6USyweuzCpRvhIMQj9tyR0SWJ4JjPpGpKhLQvtSuRhiK2hXnI
	W69xoCTDIjCNs/3XGtwyArG97YCHhAc=
From: Juergen Gross <jgross@suse.com>
To: torvalds@linux-foundation.org
Cc: linux-kernel@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	boris.ostrovsky@oracle.com
Subject: [GIT PULL] xen: branch for v5.15-rc5
Date: Fri,  8 Oct 2021 16:19:11 +0200
Message-Id: <20211008141911.25271-1-jgross@suse.com>
X-Mailer: git-send-email 2.26.2
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Linus,

Please git pull the following tag:

 git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git for-linus-5.15b-rc5-tag

xen: branch for v5.15-rc5

It contains the following patches:

- a small series to fix two minor issues in the Xen privcmd driver plus
  a cleanup patch for that driver

- a series fixing multiple issues related to running as PVH guest and
  some related earlyprintk fixes for other Xen guest types

- another fix of an issue introduced in 5.15 the Xen balloon driver

Thanks.

Juergen

 Documentation/admin-guide/kernel-parameters.txt |  2 +-
 arch/x86/include/asm/xen/pci.h                  | 11 +++--
 arch/x86/pci/xen.c                              | 15 ++++---
 arch/x86/platform/pvh/enlighten.c               | 12 +++---
 arch/x86/xen/Kconfig                            | 19 +++++----
 arch/x86/xen/Makefile                           |  2 +-
 arch/x86/xen/enlighten.c                        | 54 ++++++++++++++++++++++---
 arch/x86/xen/enlighten_pv.c                     | 35 +---------------
 arch/x86/xen/enlighten_pvh.c                    | 10 ++++-
 arch/x86/xen/mmu_pv.c                           |  2 +-
 arch/x86/xen/xen-ops.h                          |  5 ++-
 drivers/tty/hvc/hvc_xen.c                       | 13 +++---
 drivers/xen/Kconfig                             |  4 +-
 drivers/xen/balloon.c                           | 21 +++++++---
 drivers/xen/privcmd.c                           | 18 ++++-----
 include/xen/xen-ops.h                           | 15 +++----
 16 files changed, 135 insertions(+), 103 deletions(-)

Jan Beulich (12):
      xen/privcmd: replace kcalloc() by kvcalloc() when allocating empty pages
      xen/privcmd: fix error handling in mmap-resource processing
      xen/privcmd: drop "pages" parameter from xen_remap_pfn()
      xen/x86: prevent PVH type from getting clobbered
      xen/x86: allow PVH Dom0 without XEN_PV=y
      xen/x86: make "earlyprintk=xen" work better for PVH Dom0
      xen/x86: allow "earlyprintk=xen" to work for PV Dom0
      xen/x86: make "earlyprintk=xen" work for HVM/PVH DomU
      xen/x86: generalize preferred console model from PV to PVH Dom0
      xen/x86: hook up xen_banner() also for PVH
      x86/PVH: adjust function/data placement
      xen/x86: adjust data placement

Juergen Gross (1):
      xen/balloon: fix cancelled balloon action


From xen-devel-bounces@lists.xenproject.org Fri Oct 08 14:39:57 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Oct 2021 14:39:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.204775.359938 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYr2N-00064N-QF; Fri, 08 Oct 2021 14:39:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 204775.359938; Fri, 08 Oct 2021 14:39:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYr2N-00064G-NH; Fri, 08 Oct 2021 14:39:51 +0000
Received: by outflank-mailman (input) for mailman id 204775;
 Fri, 08 Oct 2021 14:39:49 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mYr2L-000646-Ss; Fri, 08 Oct 2021 14:39:49 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mYr2L-0005VJ-Iz; Fri, 08 Oct 2021 14:39:49 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mYr2L-0002zJ-5D; Fri, 08 Oct 2021 14:39:49 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mYr2L-0007VB-4g; Fri, 08 Oct 2021 14:39:49 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=cJ/79tVMKYiawk/Ax9fRWWsI6TPMZGrEQsKPob+plLU=; b=KDBrhLhqEkqbm1V3pJRj1No5Fe
	Fayegy47rvycvpa+1gKmw6CfjmeNMVfYkBa3a5rTKF4uINPVoz7WbRocgLq3c08ea6q8gBYr7bZp2
	xoflJbVRShWXufOW5s7Gi2FSzwhtR9WhwaYMtfoan7wvskdVPItDDOcQzHzuMma1qeCQ=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165424-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 165424: regressions - FAIL
X-Osstest-Failures:
    libvirt:build-amd64-libvirt:libvirt-build:fail:regression
    libvirt:build-armhf-libvirt:libvirt-build:fail:regression
    libvirt:build-arm64-libvirt:libvirt-build:fail:regression
    libvirt:build-i386-libvirt:libvirt-build:fail:regression
    libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    libvirt=3f9c1a4bb8416dafdaa89358498233aa6684377c
X-Osstest-Versions-That:
    libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 08 Oct 2021 14:39:49 +0000

flight 165424 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165424/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-armhf-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-arm64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-i386-libvirt            6 libvirt-build            fail REGR. vs. 151777

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-libvirt-vhd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a

version targeted for testing:
 libvirt              3f9c1a4bb8416dafdaa89358498233aa6684377c
baseline version:
 libvirt              2c846fa6bcc11929c9fb857a22430fb9945654ad

Last test of basis   151777  2020-07-10 04:19:19 Z  455 days
Failing since        151818  2020-07-11 04:18:52 Z  454 days  440 attempts
Testing same since   165412  2021-10-07 14:03:06 Z    1 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
    Adolfo Jayme Barrientos <fitoschido@gmail.com>
  Aleksandr Alekseev <alexander.alekseev@virtuozzo.com>
  Aleksei Zakharov <zaharov@selectel.ru>
  Andika Triwidada <andika@gmail.com>
  Andrea Bolognani <abologna@redhat.com>
  Ani Sinha <ani@anisinha.ca>
  Balázs Meskó <meskobalazs@mailbox.org>
  Barrett Schonefeld <bschoney@utexas.edu>
  Bastian Germann <bastiangermann@fishpost.de>
  Bastien Orivel <bastien.orivel@diateam.net>
  BiaoXiang Ye <yebiaoxiang@huawei.com>
  Bihong Yu <yubihong@huawei.com>
  Binfeng Wu <wubinfeng@huawei.com>
  Bjoern Walk <bwalk@linux.ibm.com>
  Boris Fiuczynski <fiuczy@linux.ibm.com>
  Brian Turek <brian.turek@gmail.com>
  Bruno Haible <bruno@clisp.org>
  Chris Mayo <aklhfex@gmail.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Ehrhardt <christian.ehrhardt@canonical.com>
  Christian Kirbach <christian.kirbach@gmail.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Cole Robinson <crobinso@redhat.com>
  Collin Walling <walling@linux.ibm.com>
  Cornelia Huck <cohuck@redhat.com>
  Cédric Bosdonnat <cbosdonnat@suse.com>
  Côme Borsoi <fedora@borsoi.fr>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniel Letai <dani@letai.org.il>
  Daniel P. Berrange <berrange@redhat.com>
  Daniel P. Berrangé <berrange@redhat.com>
  Didik Supriadi <didiksupriadi41@gmail.com>
  dinglimin <dinglimin@cmss.chinamobile.com>
  Dmytro Linkin <dlinkin@nvidia.com>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Eric Farman <farman@linux.ibm.com>
  Erik Skultety <eskultet@redhat.com>
  Fabian Affolter <mail@fabian-affolter.ch>
  Fabian Freyer <fabian.freyer@physik.tu-berlin.de>
  Fabiano Fidêncio <fabiano@fidencio.org>
  Fangge Jin <fjin@redhat.com>
  Farhan Ali <alifm@linux.ibm.com>
  Fedora Weblate Translation <i18n@lists.fedoraproject.org>
  gongwei <gongwei@smartx.com>
  Guoyi Tu<tu.guoyi@h3c.com>
  Göran Uddeborg <goeran@uddeborg.se>
  Halil Pasic <pasic@linux.ibm.com>
  Han Han <hhan@redhat.com>
  Hao Wang <wanghao232@huawei.com>
  Hela Basa <r45xveza@pm.me>
  Helmut Grohne <helmut@subdivi.de>
  Hiroki Narukawa <hnarukaw@yahoo-corp.jp>
  Ian Wienand <iwienand@redhat.com>
  Jakob Meng <jakobmeng@web.de>
  Jamie Strandboge <jamie@canonical.com>
  Jamie Strandboge <jamie@ubuntu.com>
  Jan Kuparinen <copper_fin@hotmail.com>
  jason lee <ppark5237@gmail.com>
  Jean-Baptiste Holcroft <jean-baptiste@holcroft.fr>
  Jia Zhou <zhou.jia2@zte.com.cn>
  Jianan Gao <jgao@redhat.com>
  Jim Fehlig <jfehlig@suse.com>
  Jin Yan <jinyan12@huawei.com>
  Jinsheng Zhang <zhangjl02@inspur.com>
  Jiri Denemark <jdenemar@redhat.com>
  John Ferlan <jferlan@redhat.com>
  Jonathan Watt <jwatt@jwatt.org>
  Jonathon Jongsma <jjongsma@redhat.com>
  Julio Faracco <jcfaracco@gmail.com>
  Justin Gatzen <justin.gatzen@gmail.com>
  Ján Tomko <jtomko@redhat.com>
  Kashyap Chamarthy <kchamart@redhat.com>
  Kevin Locke <kevin@kevinlocke.name>
  Kristina Hanicova <khanicov@redhat.com>
  Laine Stump <laine@redhat.com>
  Laszlo Ersek <lersek@redhat.com>
  Lee Yarwood <lyarwood@redhat.com>
  Lei Yang <yanglei209@huawei.com>
  Liao Pingfang <liao.pingfang@zte.com.cn>
  Lin Ma <lma@suse.com>
  Lin Ma <lma@suse.de>
  Lin Ma <morecache@gmail.com>
  Liu Yiding <liuyd.fnst@fujitsu.com>
  Luke Yue <lukedyue@gmail.com>
  Luyao Zhong <luyao.zhong@intel.com>
  Marc Hartmayer <mhartmay@linux.ibm.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Markus Schade <markus.schade@hetzner.com>
  Martin Kletzander <mkletzan@redhat.com>
  Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
  Matej Cepl <mcepl@cepl.eu>
  Matt Coleman <matt@datto.com>
  Matt Coleman <mcoleman@datto.com>
  Mauro Matteo Cascella <mcascell@redhat.com>
  Meina Li <meili@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Michał Smyk <fedora@smyk.it>
  Milo Casagrande <milo@milo.name>
  Moshe Levi <moshele@nvidia.com>
  Muha Aliss <muhaaliss@gmail.com>
  Nathan <nathan95@live.it>
  Neal Gompa <ngompa13@gmail.com>
  Nick Chevsky <nchevsky@gmail.com>
  Nick Shyrokovskiy <nshyrokovskiy@gmail.com>
  Nickys Music Group <nickys.music.group@gmail.com>
  Nico Pache <npache@redhat.com>
  Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
  Olaf Hering <olaf@aepfle.de>
  Olesya Gerasimenko <gammaray@basealt.ru>
  Orion Poplawski <orion@nwra.com>
  Pany <geekpany@gmail.com>
  Patrick Magauran <patmagauran.j@gmail.com>
  Paulo de Rezende Pinatti <ppinatti@linux.ibm.com>
  Pavel Hrdina <phrdina@redhat.com>
  Peng Liang <liangpeng10@huawei.com>
  Peter Krempa <pkrempa@redhat.com>
  Pino Toscano <ptoscano@redhat.com>
  Pino Toscano <toscano.pino@tiscali.it>
  Piotr Drąg <piotrdrag@gmail.com>
  Prathamesh Chavan <pc44800@gmail.com>
  Richard W.M. Jones <rjones@redhat.com>
  Ricky Tigg <ricky.tigg@gmail.com>
  Robin Lee <cheeselee@fedoraproject.org>
  Roman Bogorodskiy <bogorodskiy@gmail.com>
  Roman Bolshakov <r.bolshakov@yadro.com>
  Ryan Gahagan <rgahagan@cs.utexas.edu>
  Ryan Schmidt <git@ryandesign.com>
  Sam Hartman <hartmans@debian.org>
  Scott Shambarger <scott-libvirt@shambarger.net>
  Sebastian Mitterle <smitterl@redhat.com>
  SeongHyun Jo <caelus9536@gmail.com>
  Shalini Chellathurai Saroja <shalini@linux.ibm.com>
  Shaojun Yang <yangshaojun@phytium.com.cn>
  Shi Lei <shi_lei@massclouds.com>
  simmon <simmon@nplob.com>
  Simon Chopin <chopin.simon@gmail.com>
  Simon Gaiser <simon@invisiblethingslab.com>
  Simon Rowe <simon.rowe@nutanix.com>
  Stefan Bader <stefan.bader@canonical.com>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Berger <stefanb@linux.vnet.ibm.com>
  Stefan Hajnoczi <stefanha@gmail.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Szymon Scholz <szymonscholz@gmail.com>
  Thomas Huth <thuth@redhat.com>
  Tim Wiederhake <twiederh@redhat.com>
  Tomáš Golembiovský <tgolembi@redhat.com>
  Tomáš Janoušek <tomi@nomi.cz>
  Tuguoyi <tu.guoyi@h3c.com>
  Victor Toso <victortoso@redhat.com>
  Ville Skyttä <ville.skytta@iki.fi>
  Vinayak Kale <vkale@nvidia.com>
  Wang Xin <wangxinxin.wang@huawei.com>
  WangJian <wangjian161@huawei.com>
  Weblate <noreply@weblate.org>
  Wei Liu <liuwe@microsoft.com>
  Wei Liu <wei.liu@kernel.org>
  William Douglas <william.douglas@intel.com>
  Yalei Li <274268859@qq.com>
  Yalei Li <liyl43@chinatelecom.cn>
  Yang Fei <yangfei85@huawei.com>
  Yang Hang <yanghang44@huawei.com>
  Yanqiu Zhang <yanqzhan@redhat.com>
  Yaroslav Kargin <ykargin@virtuozzo.com>
  Yi Li <yili@winhong.com>
  Yi Wang <wang.yi59@zte.com.cn>
  Yuri Chornoivan <yurchor@ukr.net>
  Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
  zhangjl02 <zhangjl02@inspur.com>
  Zheng Chuan <zhengchuan@huawei.com>
  zhenwei pi <pizhenwei@bytedance.com>
  Zhenyu Ye <yezhenyu2@huawei.com>
  Zhenyu Zheng <zheng.zhenyu@outlook.com>
  Zhenzhong Duan <zhenzhong.duan@intel.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          fail    
 build-arm64-libvirt                                          fail    
 build-armhf-libvirt                                          fail    
 build-i386-libvirt                                           fail    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           blocked 
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-libvirt-xsm                                 blocked 
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-libvirt                                     blocked 
 test-arm64-arm64-libvirt                                     blocked 
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-libvirt-pair                                blocked 
 test-amd64-i386-libvirt-pair                                 blocked 
 test-arm64-arm64-libvirt-qcow2                               blocked 
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-libvirt-vhd                                 blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 77188 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Oct 08 15:01:22 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Oct 2021 15:01:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.204785.359953 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYrN2-0000sH-Kr; Fri, 08 Oct 2021 15:01:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 204785.359953; Fri, 08 Oct 2021 15:01:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYrN2-0000sA-HS; Fri, 08 Oct 2021 15:01:12 +0000
Received: by outflank-mailman (input) for mailman id 204785;
 Fri, 08 Oct 2021 15:01:10 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=O4Zs=O4=suse.com=jgross@srs-us1.protection.inumbo.net>)
 id 1mYrN0-0000s3-GD
 for xen-devel@lists.xenproject.org; Fri, 08 Oct 2021 15:01:10 +0000
Received: from smtp-out2.suse.de (unknown [195.135.220.29])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 2142acf2-d65d-4de4-98c8-d9af8b541705;
 Fri, 08 Oct 2021 15:01:09 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id A9D5F2013C;
 Fri,  8 Oct 2021 15:01:08 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 7709E13F34;
 Fri,  8 Oct 2021 15:01:08 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id UpzAGzRdYGEmFAAAMHmgww
 (envelope-from <jgross@suse.com>); Fri, 08 Oct 2021 15:01:08 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2142acf2-d65d-4de4-98c8-d9af8b541705
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1633705268; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=OTmJjwWYpgJRxKxqh+A0XL1gjrL3z4c9tzCY8gjWfVM=;
	b=PTWeldhvb48+0aWv5/SWZ7qPZd2WAdTM32s+LF/t2Sny8p8kycBf0uC7EZbCgkyl2QmwL6
	wXoD1HH//dBXFRO3i1aOx0+5QE6Y9JWNawfpoWzGMhVLjvJsiCYcFSSzTERc3Ms56BEBFv
	YdqWuOCo932rJuvonoMbl8Mkq1awwb4=
Subject: Re: [PATCH -next] xen-pciback: Fix return in pm_ctrl_init()
To: YueHaibing <yuehaibing@huawei.com>, boris.ostrovsky@oracle.com,
 sstabellini@kernel.org
Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org
References: <20211008074417.8260-1-yuehaibing@huawei.com>
From: Juergen Gross <jgross@suse.com>
Message-ID: <6644d095-92da-261e-87aa-284dcfcde19a@suse.com>
Date: Fri, 8 Oct 2021 17:01:07 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <20211008074417.8260-1-yuehaibing@huawei.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="74fWohrbqa2rr9qo8uGOPDLhy3Qyw7dN0"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--74fWohrbqa2rr9qo8uGOPDLhy3Qyw7dN0
Content-Type: multipart/mixed; boundary="fLFGg4UaNIXRVnMEKAwtYSZl8DOEctpv5";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: YueHaibing <yuehaibing@huawei.com>, boris.ostrovsky@oracle.com,
 sstabellini@kernel.org
Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org
Message-ID: <6644d095-92da-261e-87aa-284dcfcde19a@suse.com>
Subject: Re: [PATCH -next] xen-pciback: Fix return in pm_ctrl_init()
References: <20211008074417.8260-1-yuehaibing@huawei.com>
In-Reply-To: <20211008074417.8260-1-yuehaibing@huawei.com>

--fLFGg4UaNIXRVnMEKAwtYSZl8DOEctpv5
Content-Type: multipart/mixed;
 boundary="------------078EAB46C6BDE2629852734D"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------078EAB46C6BDE2629852734D
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 08.10.21 09:44, YueHaibing wrote:
> Return NULL instead of passing to ERR_PTR while err is zero,
> this fix smatch warnings:
> drivers/xen/xen-pciback/conf_space_capability.c:163
>   pm_ctrl_init() warn: passing zero to 'ERR_PTR'
>=20
> Fixes: a92336a1176b ("xen/pciback: Drop two backends, squash and cleanu=
p some code.")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>

Reviewed-by: Juergen Gross <jgross@suse.com>


Juergen

--------------078EAB46C6BDE2629852734D
Content-Type: application/pgp-keys;
 name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Transfer-Encoding: quoted-printable
Content-Description: OpenPGP public key
Content-Disposition: attachment;
 filename="OpenPGP_0xB0DE9DD628BF132F.asc"

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy=
cWx
w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O=
f8Z
d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y=
9bf
IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq=
G7/
377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR=
3Jv
c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA=
QIe
AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT=
hpw
dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0=
MbD
1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv=
oPH
Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v=
5QL
+qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ=
2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC=
QoL
BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr=
Wf0
teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC=
/nu
AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh=
ITT
d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm=
XBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz=
80h
SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC=
AcD
AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn=
FOX
gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1=
jnD
kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0=
N51
N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l=
otu
fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1=
tqS
EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA=
hsD
BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3=
g3O
ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5=
dM7
wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5=
D+j
LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm=
V2x
AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N=
Eaw
QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW=
nHI
s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR=
wgn
BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV=
bVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk=
pEd
IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA=
QAB
wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw=
Tbe
8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1=
vJz
Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8=
VGi
wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW=
svi
uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX=
zXs
ZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------078EAB46C6BDE2629852734D--

--fLFGg4UaNIXRVnMEKAwtYSZl8DOEctpv5--

--74fWohrbqa2rr9qo8uGOPDLhy3Qyw7dN0
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmFgXTMFAwAAAAAACgkQsN6d1ii/Ey+v
2Af/Z/DOLq7EJ1rP9+8Y405lDW25db2lneFBlTO/v9OfAHJ4AwCB8NSv8cVrlHlwRO3a9ogNi0Al
IFclN+L8UndG0k/xX7iFcZwom6nHTO6NioqwR2jEj++QBSfBKY+KWM5vYMSZOQwPTfIQP3HGJd6d
ipqMHbcBHiteYNh+WYBBnhrBCnWhOCQKZzIN1NSGIBX9/Fv6JptWHDhjdlZF1d7eVVlMfcl151F3
7EQMORqsCkUOK1mfk+L6w++pBhJtqX+72AjlLni08kkL7WobCaiYNGqZBZmyLO1K/U1WwOXx9BFd
L0UpVPrp1cQCdtWOj4bz9fgi/oG1JB8AAVDKiVJAow==
=45gc
-----END PGP SIGNATURE-----

--74fWohrbqa2rr9qo8uGOPDLhy3Qyw7dN0--


From xen-devel-bounces@lists.xenproject.org Fri Oct 08 15:32:39 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Oct 2021 15:32:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.204794.359964 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYrr2-0004Em-2z; Fri, 08 Oct 2021 15:32:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 204794.359964; Fri, 08 Oct 2021 15:32:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYrr1-0004Ef-W0; Fri, 08 Oct 2021 15:32:11 +0000
Received: by outflank-mailman (input) for mailman id 204794;
 Fri, 08 Oct 2021 15:32:10 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mYrr0-0004EV-LK; Fri, 08 Oct 2021 15:32:10 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mYrr0-0006Mz-Fj; Fri, 08 Oct 2021 15:32:10 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mYrr0-0005GM-4i; Fri, 08 Oct 2021 15:32:10 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mYrr0-0002bA-4C; Fri, 08 Oct 2021 15:32:10 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=nf6t+jPkcXhlivKCHQCASQnFmI2d6EDySTE+pqcqtek=; b=xYHkyRINZVLFGaKi2/zwlLG9jf
	1TxT0I/E/QubrQ3gCR3l1gk8IU6G2BIURB2AsHe8BNx4mDeg8IsbbvghW6jJsTVE3fGapM4X82dzj
	NCXdthhntilxQ70HRpZ0MLbH6LA7LdalMcpsqdNespGg+v8er7pscxSNqLKAaLymgXac=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165414-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-5.4 test] 165414: regressions - FAIL
X-Osstest-Failures:
    linux-5.4:test-armhf-armhf-xl-credit1:guest-start:fail:regression
    linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable
    linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=31cdcb6d430f07760dd2f540a354b11e6bb6a4a4
X-Osstest-Versions-That:
    linux=e74e2950a0d6f800858e54860d7124c86e494f62
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 08 Oct 2021 15:32:10 +0000

flight 165414 linux-5.4 real [real]
flight 165430 linux-5.4 real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/165414/
http://logs.test-lab.xenproject.org/osstest/logs/165430/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-armhf-armhf-xl-credit1  14 guest-start              fail REGR. vs. 165206

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds    18 guest-start/debian.repeat fail REGR. vs. 165206

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165206
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 165206
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 165206
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 165206
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165206
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165206
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 165206
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 165206
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 165206
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 165206
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 165206
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 165206
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 linux                31cdcb6d430f07760dd2f540a354b11e6bb6a4a4
baseline version:
 linux                e74e2950a0d6f800858e54860d7124c86e494f62

Last test of basis   165206  2021-09-26 12:42:13 Z   12 days
Failing since        165346  2021-10-04 12:42:32 Z    4 days    4 attempts
Testing same since   165414  2021-10-07 14:32:19 Z    1 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Alan Stern <stern@rowland.harvard.edu>
  Alex Deucher <alexander.deucher@amd.com>
  Alexei Starovoitov <ast@kernel.org>
  Anders Roxell <anders.roxell@linaro.org>
  Andrea Claudi <aclaudi@redhat.com>
  Andreas Larsson <andreas@gaisler.com>
  Andrej Shadura <andrew.shadura@collabora.co.uk>
  Andrew Morton <akpm@linux-foundation.org>
  Andy Shevchenko <andriy.shevchenko@linux.intel.com>
  Anirudh Rayabharam <mail@anirudhrb.com>
  Anson Jacob <Anson.Jacob@amd.com>
  Antoine Tenart <atenart@kernel.org>
  Anton Eidelman <anton.eidelman@gmail.com>
  Anton Eidelman <anton@lightbitslabs.com>
  Ariel Elior <aelior@marvell.com>
  Arnd Bergmann <arnd@arndb.de>
  Aswath Govindraju <a-govindraju@ti.com>
  Aya Levin <ayal@nvidia.com>
  Baokun Li <libaokun1@huawei.com>
  Bartosz Golaszewski <brgl@bgdev.pl>
  Bixuan Cui <cuibixuan@huawei.com>
  Bjorn Helgaas <bhelgaas@google.com>
  Borislav Petkov <bp@suse.de>
  Carlo Lobrano <c.lobrano@gmail.com>
  Catalin Marinas <catalin.marinas@arm.com>
  Charlene Liu <Charlene.Liu@amd.com>
  Chen Jingwen <chenjingwen6@huawei.com>
  Chih-Kang Chang <gary.chang@realtek.com>
  Chris Chiu <chris.chiu@canonical.com>
  Christian Brauner <christian.brauner@ubuntu.com>
  Christoph Hellwig <hch@lst.de>
  Claudiu Manoil <claudiu.manoil@nxp.com>
  Cong Wang <cong.wang@bytedance.com>
  Dan Carpenter <dan.carpenter@oracle.com>
  Dan Li <ashimida@linux.alibaba.com>
  Dan Williams <dan.j.williams@intel.com>
  Daniel Borkmann <daniel@iogearbox.net>
  Daniel Lezcano <daniel.lezcano@linaro.org>
  Daniel Wheeler <daniel.wheeler@amd.com>
  David Howells <dhowells@redhat.com>
  David S. Miller <davem@davemloft.net>
  David Sterba <dsterba@suse.com>
  Dmitry Bogdanov <d.bogdanov@yadro.com>
  Dongliang Mu <mudongliangabcd@gmail.com>
  Eric Biggers <ebiggers@google.com>
  Eric Dumazet <edumazet@google.com>
  F.A. SULAIMAN <asha.16@itfac.mrt.ac.lk>
  F.A.Sulaiman <asha.16@itfac.mrt.ac.lk>
  Felipe Balbi <balbi@kernel.org>
  Florian Fainelli <f.fainelli@gmail.com>
  Gao Xiang <hsiangkao@linux.alibaba.com>
  Geert Uytterhoeven <geert@linux-m68k.org>
  Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  Gregory CLEMENT <gregory.clement@bootlin.com>
  Guangbin Huang <huangguangbin2@huawei.com>
  Guenter Roeck <linux@roeck-us.net>
  Hans de Goede <hdegoede@redhat.com>
  Helge Deller <deller@gmx.de>
  Herbert Xu <herbert@gondor.apana.org.au>
  Hulk Robot <hulkrobot@huawei.com>
  Igor Matheus Andrade Torrente <igormtorrente@gmail.com>
  Jacob Keller <jacob.e.keller@intel.com>
  James Morse <james.morse@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Jeffle Xu <jefflexu@linux.alibaba.com>
  Jens Axboe <axboe@kernel.dk>
  Jesper Nilsson <jesper.nilsson@axis.com>
  Jian Shen <shenjian15@huawei.com>
  Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
  Jiri Benc <jbenc@redhat.com>
  Jiri Kosina <jkosina@suse.cz>
  Jiri Slaby <jslaby@suse.cz>
  Johan Hovold <johan@kernel.org>
  Johannes Berg <johannes.berg@intel.com>
  Johannes Thumshirn <jth@kernel.org>
  John Allen <john.allen@amd.com>
  Jon Hunter <jonathanh@nvidia.com>
  Jonathan Hsu <jonathan.hsu@mediatek.com>
  Jozsef Kadlecsik <kadlec@netfilter.org>
  Juergen Gross <jgross@suse.com>
  Julian Anastasov <ja@ssi.bg>
  Julian Sikorski <belegdol+github@gmail.com>
  Julian Sikorski <belegdol@gmail.com>
  Kaige Fu <kaige.fu@linux.alibaba.com>
  Kan Liang <kan.liang@linux.intel.com>
  Karsten Graul <kgraul@linux.ibm.com>
  Kevin Hao <haokexin@gmail.com>
  Kishon Vijay Abraham I <kishon@ti.com>
  Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
  Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
  Leon Yu <leoyu@nvidia.com>
  Li Jinlin <lijinlin3@huawei.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Linux Kernel Functional Testing <lkft@linaro.org>
  Lorenzo Bianconi <lorenzo@kernel.org>
  Marc Zyngier <maz@kernel.org>
  Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
  Mark Rutland <mark.rutland@arm.com>
  Markus Suvanto <markus.suvanto@gmail.com>
  Martin K. Petersen <martin.petersen@oracle.com>
  Michael Chan <michael.chan@broadcom.com>
  Michael Chan <michael.chan@broadocm.com>
  Michal Kalderon <mkalderon@marvell.com>
  Minas Harutyunyan <Minas.Harutyunyan@synopsys.com>
  Moritz Fischer <mdf@kernel.org>
  Nadezda Lutovinova <lutovinova@ispras.ru>
  Nicolas Ferre <nicolas.ferre@microchip.com>
  Nirmoy Das <nirmoy.das@amd.com>
  Oliver Neukum <oneukum@suse.com>
  Ondrej Zary <linux@zary.sk>
  Ovidiu Panait <ovidiu.panait@windriver.com>
  Pablo Neira Ayuso <pablo@netfilter.org>
  Pali Rohár <pali@kernel.org>
  Paolo Bonzini <pbonzini@redhat.com>
  Paul Fertser <fercerpav@gmail.com>
  Pawel Laszczak <pawell@cadence.com>
  Peter Zijlstra (Intel) <peterz@infradead.org>
  Ping-Ke Shih <pkshih@realtek.com>
  Qu Wenruo <wqu@suse.com>
  Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
  Randy Dunlap <rdunlap@infradead.org>
  Ritesh Harjani <riteshh@linux.ibm.com>
  Rob Herring <robh@kernel.org>
  Ronnie Sahlberg <lsahlber@redhat.com>
  Sai Krishna Potthuri <lakshmi.sai.krishna.potthuri@xilinx.com>
  Samuel Iglesias Gonsalvez <siglesias@igalia.com>
  Sasha Levin <sashal@kernel.org>
  Shai Malin <smalin@marvell.com>
  Shuah Khan <skhan@linuxfoundation.org>
  Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
  Simon Horman <horms@verge.net.au>
  Slark Xiao <slark_xiao@163.com>
  Song Liu <songliubraving@fb.com>
  Srinivas Pandruvada <srinivas.pI andruvada@linux.intel.com>
  Steve French <stfrench@microsoft.com>
  Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
  sumiyawang <sumiyawang@tencent.com>
  syzbot+47b26cd837ececfc666d@syzkaller.appspotmail.com
  syzbot+fadc0aaf497e6a493b9f@syzkaller.appspotmail.com
  Tariq Toukan <tariqt@nvidia.com>
  Tejun Heo <tj@kernel.org>
  Theodore Ts'o <tytso@mit.edu>
  Todd Kjos <tkjos@google.com>
  Tom Rix <trix@redhat.com>
  Tong Zhang <ztong0001@gmail.com>
  Tony Nguyen <anthony.l.nguyen@intel.com>
  Tyler Hicks <tyhicks@linux.microsoft.com>
  Uwe Brandt <uwe.brandt@gmail.com>
  Vadim Pasternak <vadimp@nvidia.com>
  Viresh Kumar <viresh.kumar@linaro.org>
  Vlad Buslov <vladbu@nvidia.com>
  Wengang Wang <wen.gang.wang@oracle.com>
  Xiao Liang <shaw.leon@gmail.com>
  Xin Long <lucien.xin@gmail.com>
  yangerkun <yangerkun@huawei.com>
  Yonghong Song <yhs@fb.com>
  Zelin Deng <zelin.deng@linux.alibaba.com>
  zhang kai <zhangkaiheb@126.com>
  Zhihao Cheng <chengzhihao1@huawei.com>
  Zong-Zhe Yang <kevin_yang@realtek.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 3743 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Oct 08 15:54:10 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Oct 2021 15:54:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.204806.359978 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYsC2-0006m4-3k; Fri, 08 Oct 2021 15:53:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 204806.359978; Fri, 08 Oct 2021 15:53:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYsC1-0006lx-VB; Fri, 08 Oct 2021 15:53:53 +0000
Received: by outflank-mailman (input) for mailman id 204806;
 Fri, 08 Oct 2021 15:53:52 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mYsC0-0006lm-JR; Fri, 08 Oct 2021 15:53:52 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mYsC0-0006jy-9l; Fri, 08 Oct 2021 15:53:52 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mYsBz-0007Dr-Uy; Fri, 08 Oct 2021 15:53:52 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mYsBz-0005WY-UR; Fri, 08 Oct 2021 15:53:51 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=Mdx73NdlYfSrAlh5KGXEqPwLUENJSZsgFsy78HEjaIo=; b=EROUw9NSf3YI1OtAALgIjXI+0e
	U8u7Xs4JK1sBDbwqeuB3beOfwGqydEoyZfA9NICE2ElBqa8SNr9ii5ZChK2B7bc2eF5eDpO7XTK3S
	u7+yPhbDHgZszS82Iy6Zqaoe20eUiktGyga7+U/d8u5ujIENpvnSxQFHb2/HUBVuy/F0=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165425-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 165425: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=5ece2ad36caa7ddc62d4954559b2cdd0d8a40a14
X-Osstest-Versions-That:
    ovmf=b4da6c29f1d36031e04212f53277ce0dcba309f1
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 08 Oct 2021 15:53:51 +0000

flight 165425 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165425/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 5ece2ad36caa7ddc62d4954559b2cdd0d8a40a14
baseline version:
 ovmf                 b4da6c29f1d36031e04212f53277ce0dcba309f1

Last test of basis   165398  2021-10-06 11:41:16 Z    2 days
Testing same since   165425  2021-10-08 07:12:37 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Hua Ma <hua.ma@intel.com>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   b4da6c29f1..5ece2ad36c  5ece2ad36caa7ddc62d4954559b2cdd0d8a40a14 -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Fri Oct 08 16:20:06 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Oct 2021 16:20:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.204816.359992 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYsbH-0001Qy-5B; Fri, 08 Oct 2021 16:19:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 204816.359992; Fri, 08 Oct 2021 16:19:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYsbH-0001Qr-1x; Fri, 08 Oct 2021 16:19:59 +0000
Received: by outflank-mailman (input) for mailman id 204816;
 Fri, 08 Oct 2021 16:19:57 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=jPMe=O4=citrix.com=Andrew.Cooper3@srs-us1.protection.inumbo.net>)
 id 1mYsbE-0001Qk-Tt
 for xen-devel@lists.xenproject.org; Fri, 08 Oct 2021 16:19:57 +0000
Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 9718a53b-7f11-4e29-bdaa-52765dd0c509;
 Fri, 08 Oct 2021 16:19:55 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9718a53b-7f11-4e29-bdaa-52765dd0c509
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1633709995;
  h=subject:to:cc:references:from:message-id:date:
   in-reply-to:content-transfer-encoding:mime-version;
  bh=PkErItFDsINZO/cJiJNHKwbzD5uNFzbXNUQ+4Et5pR8=;
  b=HA5gYa9kEJstiSgJ1Dp3dWHa/guxheS/Le2NUjUhcC/a+qXbpXLzpbPU
   2SUXYLWZs6bxLuE2VB6G5QUCibQZ6+D7CoiZ6kWraqDS343jzW+ArWJdK
   8ld/zKKrnYgSWNklud2Wp8/4o65p+QJgBOoesRgRKTvcfC5QJN/QE9i1h
   M=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: jNHS0wzhz42g2v7cSgyXk5lOPXbAd1lJNqxHrpPfqMI1KEWaXNL/0yLXvCkTu/JIA6Jvkg7UHa
 5Y0twHofC+mWwfdFE/YiSsOOxhlivBnHGK5X72RPF19gOf94ePprKPpMHOKuunD1dRFPIjYCMb
 dCsjREHDA1GXvkUxBdN5D27pW6sSMPMu6OE89gkR/6pKGSXp6rMTZhZfrerKjMZ4K4kKB2ZsAF
 2KONuiYzKe6K185oyjuXnCQOK/oIrPIuJPyFzVRNcO6A7EXq3/FnCH7a0SIR4LdnpBW7Njbv/x
 dQCXVK3BmaX4vv2BRBV4XYAI
X-SBRS: 5.1
X-MesageID: 54767819
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:WnPIxqB3vD+fAhVW/87kw5YqxClBgxIJ4kV8jS/XYbTApG8r3zFWx
 mEeXGGOaK3YYGH1fd0gb42390JUv8WAm4IwQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA
 xA2M4GYRCwMo/u1Si6FatANl1ElvU2zbue6WLOs1hxZH1c+EX550UI7wYbVv6Yz6TSHK1LV0
 T/Ni5W31G+Ng1aY5UpNtspvADs21BjDkGtwUm4WPJinj3eH/5UhN7oNJLnZEpfNatI88thW5
 Qr05OrREmvxp3/BAz4++1rxWhVirrX6ZWBihpfKMkQLb9crSiEai84G2PQghUh/jQ+SwN1r2
 vV3v4WodyVxMJbJyLQvTEwNe81+FfUuFL7vJHG+tYqYzlHccmuqyPJrZK00FdRGoKAtWzgIr
 KFGbmBWBvyAr7veLLaTY+9gnMk8auLsO5sSoCpIxjDFF/c2B5vERs0m4PcFgGhu2ZAXTJ4yY
 eIQbD59dAbgPyZeAUYwL5I9gsnrpHngJmgwRFW9+vNsvjm7IBZK+LrnPcfRe9eKbd5IhUver
 WXDl0zpDxdfONGBxD6t9nO3mvSJjS79QJgVFrCz6rhtmlL77nMXIA0bUx28u/bRt6Klc4sBc
 QpOoHNo9PVsshzwJjXgY/GmiHi+pUERQchwKecj8D+vkqTv5lbJNHdRG1atd+canMMxQDUr0
 HqAkNXoGSFjvdWpdJ6NyluHhWnsYHdEdAfucQdBHVNcvIWzyG0mpkiXJuuPBpJZmTEc9dvY7
 TeQsGAajqgfgNQH3qG2lbwsq2n3/cCYJuLZCx++Y45E0u+bTNL7D2BLwQKChRqlEGp/ZgLa1
 JTjs5LOhN3i9bnXyESwrBwlRdlFHcqtPjzGmkJIFJI87Tmr8HPLVdkOu2ogfx0yapZdIWWBj
 KrvVeV5v8Q70JyCN/8fXm5MI55ykfiI+SrNDJg4keaikrAuLVTarUmClGab3nz3kVhErE3ME
 czzTCpYNl5DUf4P5GPvH481iOZ3rghjlTK7bc2qlHyPjOvBDEN5vJ9YaTNimMhit/jayOgUm
 v4CX/a3J+J3CbWkPHaMq9JPdDjn7xETXPjLliCeTcbaSiJOE2A9Ef7Bh7Qnfo1uhaNOkenUu
 Hq6XydlJJDX2BUr8C2GNSJubq3BR5F6oS5pNCAgJw/wiXMifZyu/OEUcJ5uJesr8+lqzPhVS
 fgZeprfXqQTG2qfozlNP4PgqIFCdQiwgV7cNSSSfzViLYVrQBbE+4G4c1K3pjUOFCe+qeA3v
 6akilHAWZMGSgk7VJTWZfujwkmfp38YnO4uDULELsMKIBfn8ZRwKjy3hfgyepleJRLGzzqc9
 gCXHRZH+rWd/95rqIHE3PnWoZ2oHu1yGlthM1PatbvmZzPH+meDwJNbVLradz7qS26pqr6pY
 v9Yzq+gPaRfzkpKqYd1D51i0bk6u4n0v7ZfwwlpQCfLYlCsBu8yK3WKx5AS5KhEx7sfsgqqQ
 EOfvNJdPOzRas/iFVcQIisjb/iCiq5IymWDs6xtLRWo/jJz8ZqGTV5WbkuFhyFqJbdoNJ8on
 LU6s8kM5g3j0hcnP75qVMyPG7hg+pDYb5gaiw==
IronPort-HdrOrdr: A9a23:jn1qqaN4YlaAfsBcT1b155DYdb4zR+YMi2TDiHofdfUFSKClfp
 6V8cjztSWUtN4QMEtQ/exoS5PwPk80kqQFnbX5XI3SITUO3VHHEGgM1/qb/9SNIVyZygcZ79
 YbT0EcMqyBMbEZt7eC3ODQKb9Jq7PmgcPY9ts2jU0dKj2CA5sQnjuRYTzrcHGeKjM2YKbRWK
 Dsnfau8FGbCAoqh4mAdzU4dtmGg+eOuIPtYBYACRJiwA6SjQmw4Lq/NxSDxB8RXx5G3L9nqA
 H+4kLEz5Tml8v+5g7X1mfV4ZgTsNz9yuFbDMjJrsQOMD3jhiuheYwkcbyfuzIepv2p9T8R4Z
 bxiiZlG/42x2Laf2mzrxeo8w780Aw243un8lOciWuLm72zeBsKT+56wa5JeBrQ7EQt+Ptm1r
 hQ4m6fv51LSTvdgSXU/bHzJlJXv3vxhUBnvf8YjnRZX4dbQqRWt5Yj8ERcF4pFND7m6bogDP
 JlAKjnlbZrmGuhHjXkV1RUsZiRtixZJGbAfqFCgL3V79FupgE686NCr/Zv2Evp9/oGOtF5Dq
 r/Q/1VfBwndL5gUUtHPpZ1fSKAMB2Fffv9ChPhHb3ZLtByB5vske+83Fxn3pDmRHQ3pKFC7q
 gpFmko7VIPRw==
X-IronPort-AV: E=Sophos;i="5.85,358,1624334400"; 
   d="scan'208";a="54767819"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=KLOVAdqsDHLiuGY1esBCN9gOnzCWa3unzYT69NvIj0pZ3uPALdxPwY0KdVEAvoTUHbToiWfE1o26XXr4gaMY7JYa/kIdUGwOqAXZGCIqSCKqoKMvda7JIFPHfTxGiUA2lbDdWpW6OLwNhiIZfVdnpAc2YLc01S/D5RDrPmKDGpfOdELZ/M5mnaCdaO+8pcWCwqGn1paDrAcRd9MwYHBncGEIa++Nt+ANM5DUjrKygmoVnTuxYJevMAkAvYrhf33v/4Dv0957Dxlvim0wBEjygkC5smTiAn4yKe1Magm9rL8yMMXDKWbKLXXw5FmcZ0ivTKrr94Es1bHc2Aj3iPPXBQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=PkErItFDsINZO/cJiJNHKwbzD5uNFzbXNUQ+4Et5pR8=;
 b=SJ51IkNdgxCY3wQiozDkhQ243One/cQEpuusCJeUYmZtNJWBZ1ma9JNSrDQeKdGA3//fCuI2ejJkEPqo/8cfG+il1om/tNpmRy1HZ5S8yVABXJR0VYM5mNRcOLV/QrJlhNHx55C9WL1uCSTcMR5gQyxDDGTnkT7NTPaCA3vPM8qTv2ziho9yUnNkubADnmiq54sBv+JTXEi+NhnVHN+6p6Yq/4bQ19Eq2vKOpD4P1lWzUjkz3K4Pyw1hnHY5f2bI8/n5zJrcwAsEDuQoHbwSY+wym9KutfpvA+cl1UHzD57gsETa3YNFc138bhhwaUyhPmU4x/910dCWqrp5HUWK2Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=PkErItFDsINZO/cJiJNHKwbzD5uNFzbXNUQ+4Et5pR8=;
 b=ZFR5FsD7qKC0mFVwCkzNkFilUAH8ZvtT4RKHLSWLp3ua7cOEWZXJ5r7CxkY8NjJ8TnXE4TLPsr2UjRxH2H0HMWW+gsXhK+B7ezGQYEQqewdBuXYlGTwupdQGUeKN+mADnV/tS1thDVTCGyp/jS8iRqVFJ4cGntrznTrXBoIWYaA=
Subject: Re: [PATCH] x86/HVM: fix xsm_op for 32-bit guests
To: Jan Beulich <jbeulich@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Wei Liu <wl@xen.org>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
	<roger.pau@citrix.com>
References: <cb3fc8b0-cd60-edc4-7064-0bea87a6c8b6@suse.com>
From: Andrew Cooper <andrew.cooper3@citrix.com>
Message-ID: <2eaa1faa-d1c3-80ec-9fb5-7afda131fadf@citrix.com>
Date: Fri, 8 Oct 2021 17:19:27 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <cb3fc8b0-cd60-edc4-7064-0bea87a6c8b6@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Content-Language: en-GB
X-ClientProxiedBy: LO4P265CA0010.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:2ad::21) To BYAPR03MB3623.namprd03.prod.outlook.com
 (2603:10b6:a02:aa::12)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 9bff6d63-3e54-41be-71ba-08d98a776980
X-MS-TrafficTypeDiagnostic: BYAPR03MB4357:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <BYAPR03MB43575BB49DE6A8D195961E3BBAB29@BYAPR03MB4357.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:4714;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: T6csT1wy+Mn7DKxIJ9jk0rDDb0FCmtcCiERMLe5ADb1pYHW+gUCUIYKKcY1FD8cUeUkMz7zdT6NHLS+yjC0Mfx5CeP/t/h+x+rqoUr+DHyaFf5yE7XNpepm6psZo7NqR4ORUrYacrRHindy4Rt8ORVRcli7JhyPHRkGubxC+E9WPAnDZOEOpLE1x7WAvmPd6dmjGkQXc6nHTgDM3BY/jia0RaSu+6p7NeSG/n+A1CZLlxLlnjEi57osIwQ4zVFVxAwkVrPBl5aLL8cnG0+A8/6eTzsNMHbuIGOFE0b5qPnucg8O9JjcFVjTiDsRS0hHLfAL1GLTpjhmlW9FdyUp2r75l3SNRVQh38/JjYeBaF60+3eYEHeXi1Bjhg+stgIFwcC46l3MfcFi1aYlAhJshGbVuzPEuz2ab1LFwL2Kq6wDk1/DMqWf8cuA1Jv78KO7Gg+hNo/Hh5jBdhPwddekYiyq8tgE/K0GSuf4KK5ixaxOjVgyzxAivzKXML+1Dt/EiWMFHiKVZhP9ddl28r+btF2sP7RPxfQjEjqHLP5ZoIZLJoJ4fCSinCfYWgjKj3klRZT6U9t5FjI6Y2oSYbZJivkwSS/D5BYTAbvR5dZoCfmYPlZkGgKjaRZZ3z4RO2hsINkJPKn7DqZeZv+qIwf9Q5bqVzj9qRHGwHU/nqE/TNsmLce5/7fy0GF3bQgUOxeNru0450phu3inamlUpRCJ9PlSjH0nUwLgXrInupbrQbjE5aB0VAySVioj9VCtl7HQu
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(6486002)(16576012)(86362001)(316002)(54906003)(31696002)(66556008)(110136005)(508600001)(53546011)(66476007)(66946007)(26005)(186003)(4326008)(6666004)(55236004)(2906002)(956004)(8676002)(2616005)(31686004)(107886003)(558084003)(36756003)(5660300002)(8936002)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SG1sUnNLRG1MLzRWZVFVTWFHalpVeFV3V3FKeUZldU9qazlMb3pYQXcxQWZH?=
 =?utf-8?B?NXg2dHRLVkJnNGpzK0pNSFNIS3MrMEFEU0tTaWkvUXhOclNwUlFBV2JHNVhG?=
 =?utf-8?B?NWpSczJzYUZOZFBLeW9TaFMyS0ZnLzF4QUtQSDJHRUhzcG5JM2Z6bk9CYjlX?=
 =?utf-8?B?RjRKVE1HcE9hQ3pORGVyTXNkNnBwS1hjVzl5d2laSGlKb3h3NDBBK2xlMjlI?=
 =?utf-8?B?SkRmalpEU2hJYXVSWXJhTFBtQy9ReDE5MTl0V2laUGpGUUlDWXhvcXZaWEFn?=
 =?utf-8?B?T1VROTlJdDBTZ0dBS2ROdTMyNHM1YXRqb0hGYXpFcWVIaTRCOStjVGlIYmx5?=
 =?utf-8?B?OTRyb0U2aCtac2ptU0NPMkZHendCMUdoekJpSHNXRCtkSS9OS282VWwyYUR0?=
 =?utf-8?B?cUVLaEF3MjhuSWdnUmtHdWVEWTNhMjBzaTNxS21kTVhDdnZvcTBXSTZuZW5D?=
 =?utf-8?B?NzNXcjBqb2VqTFpWQVFwa1NOZ2ZmYlQyWTM0Nk5MRXhqM1pKVm9pbDNuM243?=
 =?utf-8?B?ekdqM3hKYk5rMFI4MUVTRmplRlFhdzJUdHF4Yys3MTk4VklCU0dyRW1VbUt3?=
 =?utf-8?B?QWZuV2EzbHlrak83eU1zeCtvWlEwbEZOT2xFbmx2bmFrMEZOemtsV2tkVHZl?=
 =?utf-8?B?MityQldDNHE1MnNCcVI4UlIwTjNWVWlNUTNCNWx4eGNtenByOHo5NjdhUUxC?=
 =?utf-8?B?NUxybk1jMDd4RnVMdHhJeHpvN0tWZGFnaTBjNmhNcFBYWEU0bk55Y3I0aEdP?=
 =?utf-8?B?aDdEaUpuY29MR2dFaGRUOTlaUXdUUlFhTHR4OFpYYkxOSkNiYnVNZUI3b0NX?=
 =?utf-8?B?NjVLMW5iUEZleDl0eXpMZjhndDloZUtNMGRGNkU5N0F6S09ZM3NmSUlSK2tC?=
 =?utf-8?B?QmVoNWlUa1lJS1VFallScmVLcjhCdk9YSGVGVkNTUHRYRG9IY2ZyNFNrRm9J?=
 =?utf-8?B?eXBrczUwWTNYQ2lCM0daZWRKUUVTQUZDZUNHYjJ3bHRYL1ZNbUplTXFDbVhL?=
 =?utf-8?B?Y2pOZmRFNnZ6YWgzYW9wUzZjWmo3R2RZcC9WbTRlVEJCNnp4N0txdGx3WEZ3?=
 =?utf-8?B?YlVESGp3WmNZM0xCdzVUTUJDZFdBOUJjMjArSHVUc2l3RWV3MWZZWm5YY3Jo?=
 =?utf-8?B?dWFiYnJLK0VpMk16RHQ4N0cwYys4eTgycWkvaFZ5SVFLd0ZIN1BzajBNSDM0?=
 =?utf-8?B?dityMXgzZ1luOHRBR1gvVEN5SHlwYSt1TWdSYlZhenAxL2RLaTVmVzFQV042?=
 =?utf-8?B?MVlmTG8yaGhsUnZFeU1CNVdwSDdxWnB4OXlRRWNCSlhWRUJEaFdXUmRTeXBB?=
 =?utf-8?B?VTUyZVg1TGQ3N0tZSVZyOEFCK2F6T0x5bjZBd2hXai9rTWdGRmVicjFqb2JN?=
 =?utf-8?B?RHhpWXljdjZ4UkxkbXpzS1RVMUI4QzliQ2thOGkyUVhteFBOQ2w3VE9nZjAv?=
 =?utf-8?B?SWQ2cG41YjRRUVBSTGsxaC9scjlWMk5BU0NsclVjZVB6cmRXcFNUTzdQeGZI?=
 =?utf-8?B?SmRyRk9VeXFyLzd4a1FBM2xtWHo5dHNVSkRVTXM0ODIrVkNmYUVwU2V5MFdm?=
 =?utf-8?B?c3daZGNZWW5KRUIybzRzZTEvSSt6Z01ydis3MFJjb0lQNUZRbVcrQzhiNDdi?=
 =?utf-8?B?ZlZuVWhRRWhYYnVCV0xlRE51SFVsUEZEYVl1dFpyVmh0RjUzUGk3d3BhS2lQ?=
 =?utf-8?B?bWtrVmxZRkl1ZGRYRSszdU1ib0QxMjcxVlBxQVVhQlJFeVQ2M1ZOdmlDMnUz?=
 =?utf-8?Q?rv8aQKoS2LSFMtGxXCexpsg/wB8Sd2rbvriuWyH?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 9bff6d63-3e54-41be-71ba-08d98a776980
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Oct 2021 16:19:32.7291
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: xeyNVBg0onVDsAOOvYzo9Ulna1FzSXyOPMWIUuC+lrGPd6AyRGKQoo9Byl53Mc0kfuhye/t/76REsjLk3T2yF+7K4G8Y5X+qne2iwM8C9Kc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB4357
X-OriginatorOrg: citrix.com

On 08/10/2021 14:06, Jan Beulich wrote:
> Like for PV, 32-bit guests need to invoke the compat handler, not the
> native one.
>
> Fixes: db984809d61b ("hvm: wire up domctl and xsm hypercalls")
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>


From xen-devel-bounces@lists.xenproject.org Fri Oct 08 17:17:18 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Oct 2021 17:17:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.204825.360002 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYtUU-0007KN-EL; Fri, 08 Oct 2021 17:17:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 204825.360002; Fri, 08 Oct 2021 17:17:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYtUU-0007KG-BO; Fri, 08 Oct 2021 17:17:02 +0000
Received: by outflank-mailman (input) for mailman id 204825;
 Fri, 08 Oct 2021 17:17:01 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mYtUT-0007K6-Oh; Fri, 08 Oct 2021 17:17:01 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mYtUT-0000Bz-HX; Fri, 08 Oct 2021 17:17:01 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mYtUT-0002f7-4T; Fri, 08 Oct 2021 17:17:01 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mYtUT-0007EH-3w; Fri, 08 Oct 2021 17:17:01 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=iYRB73ZN6hDUnnDMW9K/H77NytUQOVph413IFfsm7eQ=; b=2bdYhwzDesdxIkofKGSylw/GWD
	0rnXCooLw68BX2dgnZTMNi7WYN/C0euVrnvMCMtm7wDhiTHhONChUx3KR0Uf5sk1tKdHEAqQtaJ/k
	37H3RSFEHycrjdkp6h2ixtog/rcGcK8oueNZeHSkd2pRw0iEXINlkUeoNB3lb79/0Jic=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165422-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 165422: regressions - FAIL
X-Osstest-Failures:
    linux-linus:test-armhf-armhf-xl-credit1:guest-start:fail:regression
    linux-linus:test-amd64-amd64-xl-rtds:guest-start.2:fail:allowable
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=1da38549dd64c7f5dd22427f12dfa8db3d8a722b
X-Osstest-Versions-That:
    linux=deacdb3e3979979016fcd0ffd518c320a62ad166
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 08 Oct 2021 17:17:01 +0000

flight 165422 linux-linus real [real]
flight 165432 linux-linus real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/165422/
http://logs.test-lab.xenproject.org/osstest/logs/165432/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-armhf-armhf-xl-credit1  14 guest-start              fail REGR. vs. 152332

Regressions which are regarded as allowable (not blocking):
 test-amd64-amd64-xl-rtds     23 guest-start.2            fail REGR. vs. 152332

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail baseline untested
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 152332
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 152332
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 152332
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 152332
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 152332
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152332
 test-armhf-armhf-xl-rtds     18 guest-start/debian.repeat    fail  like 152332
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 152332
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 linux                1da38549dd64c7f5dd22427f12dfa8db3d8a722b
baseline version:
 linux                deacdb3e3979979016fcd0ffd518c320a62ad166

Last test of basis   152332  2020-07-31 19:41:23 Z  433 days
Failing since        152366  2020-08-01 20:49:34 Z  432 days  745 attempts
Testing same since   165422  2021-10-07 22:10:59 Z    0 days    1 attempts

------------------------------------------------------------
7382 people touched revisions under test,
not listing them all

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     fail    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 2285685 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Oct 08 17:47:43 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Oct 2021 17:47:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.204837.360017 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYty4-0002Eh-2F; Fri, 08 Oct 2021 17:47:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 204837.360017; Fri, 08 Oct 2021 17:47:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYty3-0002Ea-UQ; Fri, 08 Oct 2021 17:47:35 +0000
Received: by outflank-mailman (input) for mailman id 204837;
 Fri, 08 Oct 2021 17:47:34 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=jPMe=O4=citrix.com=Andrew.Cooper3@srs-us1.protection.inumbo.net>)
 id 1mYty2-0002EU-62
 for xen-devel@lists.xenproject.org; Fri, 08 Oct 2021 17:47:34 +0000
Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 0bc2eb9e-e785-4108-ac6b-8fd08061e2d4;
 Fri, 08 Oct 2021 17:47:32 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0bc2eb9e-e785-4108-ac6b-8fd08061e2d4
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1633715252;
  h=to:cc:references:from:subject:message-id:date:
   in-reply-to:content-transfer-encoding:mime-version;
  bh=aMlesI0+7uJMZe7h2usGprOtuT8Wsboe91YJEkmWQ84=;
  b=KDPH/wEeiGzl+6y8k0JbxLQCVGlsklSPpCjChFsFjmwD1yoOh4vBSI16
   Ae7dpcIQVfXQma21iCIV7Iv7B5SK0gMjk+OpHMhn+NpMgVb3+SKzx4s7w
   FuEf1Dfjsiyckr5uhACokwh7A5kQtUlxKvLD1iSMlBSVWIXN5ThRJAc2+
   k=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: sn36cWkJVwc8Vatuu2bFiiC6Bk6FSbpxRdG90zom02Tr4vm/RYmffrRkAzq8+qnS+rTYXegfoM
 Pzlex8Xcm8bHK1qIDAuEwP5oojyon9lf7rMTANi40eGaW3Ddf72q2zx4hQSmxy7CgoTMA0s+z+
 MKxD9e+jW+rOst0sj2rZRAiXNsk+RZwYZzG0huwVT1azeZ3iL9vANlAbbBrk7vnXs+vQ4ktkuL
 c6qVsfcCV8aE8oM/laOXZNr4pBxCHkVEZsFbrvAadomklQ+JEK3/973W12bpektuCoONxXRp0c
 iFq2Iqif1rsKxG/fqD/DzYs3
X-SBRS: 5.1
X-MesageID: 54724177
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:VgmbX6+OcYD2bOUb+6rmDrUDZnmTJUtcMsCJ2f8bNWPcYEJGY0x3y
 WIcC2DUO6ncZWX2eNxwaI+z8hlXucfWyYAxTVc+/3w8E34SpcT7XtnIdU2Y0wF+jyHgoOCLy
 +1EN7Es+ehtFie0Si9AttENlFEkvU2ybuOU5NXsZ2YhGGeIdA970Ug6wrZh0tYy6TSEK1jlV
 e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH
 I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPhx2
 chUh7moGT42P5+ds8MAdwkJL3lhaPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us
 6ZCcXZUM07F17neLLGTE4GAguwKKsXxMZxZkXZn1TzDVt4tQIzZQrWM7thdtNs1rp0SQqyCP
 pVGAdZpRDiQakFxHG4zM4sjv8S6iCTebhlK8E3A8MLb5ECMlVcsgdABKuH9eNaHWMFUlUawv
 X/d8iLyBRRyHMySz3+J/2yhgsfLnDjnQ8QCGbug7PlojVaPgGsJB3U+Sl+TsfS/zEmkVLpix
 1c8o3R06/JorQryE4e7D0bQTGO4UgA0W8tNCt8f8FG01avmsi2+G0wUHwIZd4lz3CMpfgAC2
 liMltLvIDVgtryJVH6QnoupQSOO1Ts9dzFbOn5dJecRy5yz+Nhs0kKnosNLSvbdszHjJd3nL
 9lmRgAQgK8PxeoCyqm251zOhz/ESnPhFVVuvlS/so5I9GpEiG+Zi26AtQazARVodt/xory9U
 J4swJP2AAcmV8HlqcB1aL9RdIxFHt7cWNEmvXZhHoM66xOm8GO5cIZb7VlWfRkyaZhfI2SxM
 BaL42u9AaO/2lPxNsebhKrrW6wXIVXIT4y5Bpg4kPIUCnSOSON31H43PhPBt4wcuEMtjbs+K
 f+mnTWEVh4n5VBc5GPuHY81iOZzrghnnD+7bc2rnnyPjOvFDFbIGOhtDbd7Rr1ghE9yiF6Oq
 Ig32grj40g3bdASlQGOqdRNcgtQcSRibX00wuQOHtO+zsNdMDhJI9fawK87epwjmKJQl+zS+
 Wq6VFMew1367UAr4y3TMhiPsZvjAsRyq2wVJyspMQr60nQve9/3vqwea4E2bf8s8+k6lax4S
 PwMesOhBPVTS2uYp2RBPMel9IEyJg62gQ+uPja+ZGRtdZBXWAGUqMTveRHi9XdSA3Pv59c+u
 bCpyijSXYEHG1Z5FM/TZf/2lwGxsHERlfhcRUzNJtUPKkzg/JIzc376j+MtItFKIhLGn2PI2
 wGTCBYehO/Mv45qr4WZ2fHa99+kSrIsEFBbEm/X6aeNGRPbpmfzk5VdVOuofCzGUD+m8quVe
 ugIner3N+cKnQgWvtMkQapr1683+/Dmu6ReklZ/BHzOYlmmVuFgL32B0ZUdv6FB3OYE6w6/W
 0bJ8dhGI7SZfsjiFQdJdgYia+2C09ASmyXTsqtpcBmruncv8erVS1hWMjmNlDdZfel8P44Sy
 Os8vNIbtl6kgR0wP9fa1i1Z+gxg9JDbv3nLYn3CPLLWtw==
IronPort-HdrOrdr: A9a23:3M8m16A3AZuIpMvlHeglsceALOsnbusQ8zAXPh9KJyC9I/b2qy
 nxppgmPH/P6Ar4WBkb6LS90dq7MA3hHPlOkPYs1NaZLXXbUQ6TTb2KgrGSuAEIdxeOkNK1kJ
 0QDpSWa+eAfmSS7/yKmDVQeuxIqLLsndHK9IWuvUuFDzsaDJ2Ihz0JejpzeXcGPTWua6BJca
 Z0qvA33QZJLh8sH7WG7zQ+Lqf+juyOsKijTQ8NBhYh5gXLpTS06ITiGxzd+hsFSTtAzZor7G
 CAymXCl+SemsD+7iWZ+37Y7pxQltek4txfBPaUgsxQDjn3kA6naKloRrXHljEop+OE7kosjb
 D30lkdFvU2z0mUUnC+oBPr1QWl+DEy60X6wVvdunfnqdyRfkNxN+NxwaZiNjfJ4Uspu99xlI
 hR2XiCipZRBRTc2Azg+tnhTXhR5wiJiEtntdRWo21UUIMYZrMUh5cY5llpHJAJGz+/wJw7Ed
 NpENrX6J9tABCnhkjizy1SKeGXLzMO9k/seDlFhiXV6UkXoJlB9Tpc+CRF9U1wra7USPF/lq
 /52+pT5elzpmJ/V9MKOA47e7rCNoX6e2OFDIujGyWTKEg5AQO7l3fW2sR52Aj4Qu1F8HMN8K
 6xGW+w81RCIH7TNQ==
X-IronPort-AV: E=Sophos;i="5.85,358,1624334400"; 
   d="scan'208";a="54724177"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=L0xe2+8FZB/IHamOkW0wfb4U1E5cHOpU1NOqwMs6kyP6B/z6dR+CPYjj3rBoi+E3kVSDe0qAQiAKr1xqbwtbOU1uDSK899bcGo/YMepoIXMAt7cefGH7d+5rn/Yya1VriM18sytOyPLhB3NXSvp+77RTUlfR7zrK0m3dMJTJ5NbOjEzM2ncZjvz7mftMmCUmDfQ8i49H0T3Ucq5NBGuaYMg0HFiOCAMjl3ggCD4GyYDi1KxZZSMZmFtj45MlQ0eTFJMDee4pGLA9shGnIbbsD13svD8Z21+qn4p2lz3lFLuPOS/i3CUk3MUrD8vO+XZBt82lwCoUgaBbMVfo2WexVg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=t0KdzliHc2dA5QvYlsgTDGIQ7D6YE/u6JPG8M3eblIo=;
 b=lUMvxcEzHWdrBndbVfTjWtIkcPS6RoKPJ07S7GynmQR4SQ2j21ZsDYePCWWJ9Z9dr5/7EkdTB4x/e+r+dLv2fMipugxK+NBjveCx5QtnAue6pjjPP2oFZcAyf4V9mabALo7SyK9xbaeS1Fegw001cWzlZhIVK2wyncnvF2+MPL49/QzdUsa1VljoTu1eQMXQ7ksIqA2ZdSb5J1etc3WyHjLr6b6y3LMyhFDgsIstj8MKSTLlznZpMUruI04yZ0iyLB/y6qmUjPAJ2iIHG/YedCGr2DB0dt7FZkW7yCNIYDtwU3SdqA/R2Kuy86dMCTDsp324FkxZ15UBybCkKzP0nw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=t0KdzliHc2dA5QvYlsgTDGIQ7D6YE/u6JPG8M3eblIo=;
 b=O0ag8yaGEhBm207isCaJPXF/1pXmgokdJoMzxjevx2+EEbF00hQrk2wJReWnFOwwp03U4jbSJUUL1j+BCJ6WW75fCLO3z9X0rJoWfOe0euaIU2UV7IupvGrkLDn9Tho8Cxw6tQdSPRTYmaM3+bCTQJhOP34dcLdbNOdBDId2iPE=
To: Jan Beulich <jbeulich@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Wei Liu <wl@xen.org>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
	<roger.pau@citrix.com>
References: <e8d21433-2f4f-f662-dd45-1543da8f4caf@suse.com>
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH] x86/PV32: fix physdev_op_compat handling
Message-ID: <24595827-df68-816b-9356-935c3fb80746@citrix.com>
Date: Fri, 8 Oct 2021 18:47:09 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <e8d21433-2f4f-f662-dd45-1543da8f4caf@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Content-Language: en-GB
X-ClientProxiedBy: LO4P123CA0078.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:190::11) To BN7PR03MB3618.namprd03.prod.outlook.com
 (2603:10b6:406:c3::27)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 3a829ff1-1832-4140-e1c2-08d98a83aa0b
X-MS-TrafficTypeDiagnostic: BN3PR03MB2132:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <BN3PR03MB213205DFC62B841BCFE76991BAB29@BN3PR03MB2132.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: W3vHBYB99i9aJAy7pokUnSshhBfiUU5hGmwGgCJ1/alh1QsGtZOKURWGlrdYs/9uUKlgIAS0zUepPPjYj0a5gYYsromEOquttM/FsgdGIETv0M4hpqN7eJvCsR2B1D6s0h7FxT18JbkiG54cXqfByWHLvocQP4g5U3jQPuXWbohY3xcnnonfWT62E6flqQLy5TcjeE3yhFz5j1rwP1Vrpo1zcIw5bn7XDO6ZPHgyAEPU6u8KNGk2VmCCpnLR5F3JnK/8ALUj13UUmlCcAkgnSJiiodRogbvidTCymfVTgsDwemZ6h4uZ/fdab0h3XuKnX/FMkR/y3iF+oUybXU0zbYAY3GhOJ4qc1+B21sdX4jQzJpsAPQepMenlUlyF71Y1RssAeohPHhIWI1SG2hKp5gAX+KZqsV59i2ftG/tjJ51lnBcQUoyV1qLXU+S1Hp1xVu8yeX4pOcJwa3IxO/3OupCL7jmZ1PJz8egEFV9pgmbONGTNDVg0/7Cn5AqmA8X9OAw2UwbQLE2INxs8wRSbAOfL1pwPSpzukkIlwk5j2ds7R1r/igs7ZAspDCmU30SrSXOQFxp5rmSJJUz+rrhXvj0rcxucHk0nnV4ewWFxyOkIW6EI3EVETfm7gXvBBL3vH8p9S1SfvItLGpdjh8RRsKrRUqWky7m416t4gW1v9VbK3Wa0SAAGZQg/4QViDKYF/NFh2rZLYqw1a2OUCypJOMDhinuqxm79Kj0uFRqPbisZ7qlqxrwaJvAwujFdVx0r
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN7PR03MB3618.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(54906003)(110136005)(2616005)(6486002)(186003)(16576012)(316002)(8676002)(26005)(4326008)(8936002)(956004)(2906002)(38100700002)(86362001)(53546011)(31696002)(508600001)(5660300002)(66556008)(66476007)(6666004)(66946007)(83380400001)(107886003)(55236004)(31686004)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?b2U3NG94UXpCb3gvMVpodXVWcytmcTM0WC9RNWVLUDJCaTNJVWlXZHNQOVpj?=
 =?utf-8?B?VVBaMGFUMEI2cndGUVoxS0RrZ3ZvdHh4Um51ODl5bmwyLzR6MmJzVUw0NEhW?=
 =?utf-8?B?KzZDcGY4bi9UN0t5TStQNHEwSGtNazIvSGxXekYwOVMyZm92emtGNHF1WXZl?=
 =?utf-8?B?ZEpPVDlXOGpuNEsyandhRHZjcy9QTENQUFB6SUZKY1c2Z0NBZ09VWjhDVHpG?=
 =?utf-8?B?bHpRcEMwVkpHQ3dCSEFwQVFLK0tJMU9zYXFRUXgxOW9JY2VMdnpHaG05RUFk?=
 =?utf-8?B?M3FsY09NWnJXd3NBVG9zUGZleEc1YjlBMnJmbXZiTEkySkZrWG56UGpWSk5t?=
 =?utf-8?B?TFdLNDE4MDFqQUErd2ZBN2FUTGxPdUZpbXlFTlhzd0Y0NHJic2pOQy83K3g1?=
 =?utf-8?B?dFBtNXgwZTUvK04zdmpSVFdQZjFUaHRCRzUray9aYVNDdWJ4M005akVUMUEy?=
 =?utf-8?B?amJLc0pSUVhSenlya01QV2o5K2hYalI2dWRKWkZBRkFySWs1RWxEUXFuWHN4?=
 =?utf-8?B?SGplQjgxYzB5dzJudzBRaFdKOFAyRDFTZ0ZvVW9VVjRZcU5BV3ZWdWNWaEkx?=
 =?utf-8?B?MVNrUWx5cW85MWM5VE51MXgzSnlFOXQ1THNUWXhhSkVZc2N4RzNDWVVwaGI5?=
 =?utf-8?B?TGFOQ213dUd5NDBCbGhIRHFSbmZ4bTBSTGtVeVp1QW45NmZsZXBEdithUWRF?=
 =?utf-8?B?OWpxZXROTndkaDh4eCtad0lONVA4c3dqRDBMdldFaWdWS3VhMlhwQXoxcTFq?=
 =?utf-8?B?Q0o0bGZSN2tOQ3Zia3pSbFlXRXRwSWx1c0JSajBZUy9DV2lZY09jRHR1TS80?=
 =?utf-8?B?a3ovTkIzR21EMDQ2RllrSGpzWHlhVjlDQ0lvQlhvbGZRRW94V3k5ZUQvbUVZ?=
 =?utf-8?B?ZVNCL1F3Wll6cis0ekY4NG1IODE1UVNndjdxbjM3MEdpK3h4Vk4zeUpuVHRK?=
 =?utf-8?B?Zm5RZzkxbkszbGMwbmFheTk3MW96VFl5MGRvUTdlck5QK2NoUGdhTFhiWDR5?=
 =?utf-8?B?V21Sc2tjKzgyai9kbzF1ZmxzK2ZwMGk1empjNDhuVndIYldZSnoxbklQSlZW?=
 =?utf-8?B?enB5QXh0eHlYeG4vOFpmS1VaN2w5YUVEZ2xCb0gzUTlJSWZiUWFjRmp4aEVk?=
 =?utf-8?B?R1FQMEFJSGlPVWlkallZZVBBYWw2emtGOElrVjk1VjNSbEtKMjZYM2NDTGti?=
 =?utf-8?B?ODFOa1BPaDdEYnFQQldyKzkrQjFRbkN5RG5Ycmo2eis3TmxuaHBOZm0rL1hu?=
 =?utf-8?B?WkN4R2VWdGo3dHpXQmhPWFIveUF5alZYcHhwTU5TSG9iWnUzRzNZbmk2WTF2?=
 =?utf-8?B?R3VBUU0wcGFpQkdub3hnV2RyWTN6WlJNWkQvR1ZVRCtWcjBoNzFLbWU5MjN3?=
 =?utf-8?B?Smg3ZUgvSE4yVlZmbHRsTFpQTGdBbnJZd044WUdiZ2h3MlN5U2lrWkFPcHZ5?=
 =?utf-8?B?aU4rQWxsdjYwMzZBekVWbEdJU3Z2alVTUmtxdkNrWVJ2REd2Nkd1T1NkcDFE?=
 =?utf-8?B?R3dpZDhkRDBMV2lBSGNpczk5NDNxSmYxejRDSlZBamM5OURWMXlKQVlKdVRC?=
 =?utf-8?B?bnRDNVppQ2JVVTlLamJOdWJSQVRXQytQSGhZb0kzTEhTUHUzUFNMQktncUZp?=
 =?utf-8?B?cER0ZEp6ZitQcVNnMUgvb0cwZVhIZldFOFdNN2oySWhGYWhTN0xRR3k0SDNG?=
 =?utf-8?B?VWIvY2psMElZdXVoWnhRUER1SGQ1YUNJTWJRbVpodEwyWVZmSWZmSkIrTDBv?=
 =?utf-8?Q?y52cqCa3KFyXDym5McVGzJganb4CRdQicDK9rc3?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 3a829ff1-1832-4140-e1c2-08d98a83aa0b
X-MS-Exchange-CrossTenant-AuthSource: BN7PR03MB3618.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Oct 2021 17:47:15.2157
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: wi5yiy7HEEieNVs+c2vJueOnA1CSwI7qPJLm31YSG9cmI+Ug8uxHX7B4BnVBfjNRjDXPQQxSJwmrToZlloMN7oMlpsk/Z+IepBW5sEEP3PU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR03MB2132
X-OriginatorOrg: citrix.com

On 08/10/2021 11:47, Jan Beulich wrote:
> The conversion of the original code failed to recognize that the 32-bit
> compat variant of this (sorry, two different meanings of "compat" here)
> needs to continue to invoke the compat handler, not the native one.
> Arrange for this and also remove the one #define that hasn't been
> necessary anymore as of that change.
>
> Affected functions (having existed prior to the introduction of the new
> hypercall) are PHYSDEVOP_set_iobitmap and PHYSDEVOP_apic_{read,write}.
> For all others the operand struct layout doesn't differ.

:-/

Neither of those ABI breakages would be subtle.=C2=A0 But why didn't XTF
notice?=C2=A0 Edit: It appears as if my PHYSDEVOP_set_iobitmap tests never
got completed.

>
> Fixes: 1252e2823117 ("x86/pv: Export pv_hypercall_table[] rather than wor=
king around it in several ways")
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> ---
> Additionally the XSA-344 fix causes guest register corruption afaict,
> when EVTCHNOP_reset gets called through the compat function and needs a
> continuation. While guests shouldn't invoke that function this way, I
> think we would better have forced all pre-3.2-unavailable functions into
> an error path, rather than forwarding them to the actual handler. I'm
> not sure though how relevant we consider it to fix this (one way or
> another).

EVTCHNOP_reset{,_cont} are -ENOSYS'd in do_event_channel_op_compat()
without being forwarded.=C2=A0 I can't see a problem.

But yes - we'd have problems if any pre-3.2-available functions needed
to become continuable.

We ought to consider dropping compatibility for guests that obsolete...

>
> --- a/xen/arch/x86/x86_64/compat.c
> +++ b/xen/arch/x86/x86_64/compat.c
> @@ -10,8 +10,8 @@ EMIT_FILE;
> =20
>  #define physdev_op                    compat_physdev_op
>  #define physdev_op_t                  physdev_op_compat_t
> -#define do_physdev_op                 compat_physdev_op

This is still needed, technically.=C2=A0 It impacts the typeof() expression=
:

typeof(do_physdev_op) *fn =3D
=C2=A0=C2=A0=C2=A0 (void *)pv_hypercall_table[__HYPERVISOR_physdev_op].nati=
ve;

and the reason why everything compiles is because
{do,compat}_physdev_op() have identical types.

~Andrew

>  #define do_physdev_op_compat(x)       compat_physdev_op_compat(_##x)
> +#define native                        compat
> =20
>  #define COMPAT
>  #define _XEN_GUEST_HANDLE(t) XEN_GUEST_HANDLE(t)
>




From xen-devel-bounces@lists.xenproject.org Fri Oct 08 18:07:34 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Oct 2021 18:07:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.204847.360031 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYuHI-0004iZ-Na; Fri, 08 Oct 2021 18:07:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 204847.360031; Fri, 08 Oct 2021 18:07:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYuHI-0004iS-KX; Fri, 08 Oct 2021 18:07:28 +0000
Received: by outflank-mailman (input) for mailman id 204847;
 Fri, 08 Oct 2021 18:07:27 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=jPMe=O4=citrix.com=Andrew.Cooper3@srs-us1.protection.inumbo.net>)
 id 1mYuHG-0004iM-Uw
 for xen-devel@lists.xenproject.org; Fri, 08 Oct 2021 18:07:26 +0000
Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 54c58e04-bc4e-4833-ae30-0d0c512608ec;
 Fri, 08 Oct 2021 18:07:25 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 54c58e04-bc4e-4833-ae30-0d0c512608ec
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1633716445;
  h=to:cc:references:from:subject:message-id:date:
   in-reply-to:content-transfer-encoding:mime-version;
  bh=rQhlx4wtZb7Wi4rVykfIpQlZmIumaYt5vzYfpm3VwZU=;
  b=gOCZ5X7HwwBSL+E/p/lxJy2kRXinh57dQareUUJi1CArhSwyagSALMsW
   eC1mtVGCzH+Gd7VvlaTfD8wjs7rVDW8z056L7UmKYbZyon50xIty7do/s
   KgUOSQh5snz10gxzjk0KDbegilLrgVUt3HKrXaESFP+/syV0U6A/QQx/8
   I=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: /aKyFA+IsRvFbZCdxq5uXCkhx174BsK31SvQszqZD6oYSAcpuGRPaUqsp4Q11JulC61/S/lmzr
 3X5/J+k8L453g8nmF43x8Az5dtfDkHPVOERmDRVgXqiOHh0SCKA0ee5UwwNwlx+a6tB+LNHLX8
 KmgPbYXv8oJmd4jEyLn4QvmFBs/i4Ez9rQ36y6K++IXnBd5VLKjb3JLNyEYXzMGxS77FwFyavf
 Ch1As9CGuTNtU9D0Z62QebaS7mZk3ukx/k5v7SwKYCy+wiwbXOCF2agadcIOWlfPZmFuyOEp6A
 RA0t7CCIVVClw8m6mIqh5ixs
X-SBRS: 5.1
X-MesageID: 55150512
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:8FoH2q1+ak3QcpmHBPbD5cR3kn2cJEfYwER7XKvMYLTBsI5bpzUHy
 mMZCmCBPfnZYmGmf9x1a9/k8R4D7cLRz9FgTVZvpC1hF35El5HIVI+TRqvS04J+DSFhoGZPt
 Zh2hgzodZhsJpPkS5PE3oHJ9RGQ74nRLlbHILOCan0ZqTNMEn970Es7w75h2OaEvPDia++zk
 YKqyyHgEAfNNw5cagr4PIra9XuDFNyr0N8plgRWicJj5TcypFFMZH4rHomjLmOQf2VhNrXSq
 9Avbl2O1jixEx8FUrtJm1tgG6EAaua60QOm0hK6V0U+6/TrS+NbPqsTbZIhhUlrZzqhh8x7y
 PtLlseKZSx5H5Xzl8MtbAcCHHQrVUFG0OevzXmXtMWSywvNcmf2wuUoB0YzVWEa0r8pWycUr
 6VecW1TKEDY7w616OvTpu1Er8IvNsT0eqgYvWlt12rxBvc6W5HTBa7N4Le02R9t25kTRauHP
 aL1bxJAMBjSYiwSE2sQFawEls2hwSb+eh1x/Qf9Sa0fvDGIkV0ZPKLWGPPTdsaHA/1PjFeHr
 3jP123jB1cRM9n34TaM7H+EnOLEmiL/HoUIG9WQ/PNwnEeawGBVDRQMTEa6utGwkEv4UNVaQ
 2QO8yozqe4p9UqkTvH0RRj+q3mB1jYMVtwVH+Ak5QWlzqvP/x3fFmUCViRGatEtqIkxXzNC/
 l6Wnfv5CDp3qrqXRHmBsLCOoluaIjMJJGUPYSsFSwot4NT5pow3yBXVQb5LLqmxidHkHCDq9
 BqDpiM+mrY7gNYC0uOw+lWvqzCxopnESCYl6wORWXiqhitmYKa1aoru7kLUhd5CJouESliKv
 FAfhtOTqusJCPmweDelGbtXWuvzvrDcbWOa0QUH84QdGyqF42Kpfa5Ww2pECGw5E/47dhjZX
 1GJtlYEjHNMB0eCYahyaoO3Ls0ly6n8CNjoPszpgspyjotZLlHeo3A3DaKE9yW9yBFzzfFX1
 YKzK57EMJoMNUhwINNarc8z1qU3jgQ32G/eX5zyyxnPPVG2PyXOEeZt3LdjdIkEAEK4TOf9r
 4g32yiikUw3vAjCjs//qtV7wbcidyhTOHwOg5YLHtNv2yI/cI3bN9ffwKk6Z6tulLlPm+HD8
 xmVAxEDkwSk3yafeVzSMBiPjY8Du74k9hrX2gR2bT6VN4ULO97zvM/zibNtFVXYyACT5aEtF
 KRUEylxKv9OVi7G61wggWrV9+RfmOCQrVvWZUKNOWFnF7Y5HlCh0oK0L2PHqXhVZgLq5JRWn
 lFV/l6CKXb1b185V5i+hTPG5w7ZgEXxb8orBxGWfYIJJBm1mGWoQgSo5sIKzwg3AUyr7hOR1
 hqMAAdeou/IooQv98LOi7zCpICse9aS1GIDd4UCxbrpZyTc4ES5xopMDLSBcTzHDTum86S+f
 +RFifr7NaRfzlpNtoN9FZdtzL4/uISz9+MLkFw8ESWZdUmvB5NhPmKCgZtFuJpSy+ILogCxQ
 E+OpIVXYO3bJMP/HVcNDwM5deDfh+oMkzzf4K1tckX37SN65pSdVkBWM0XegSBRNuItYogk3
 f0gqIgd7Anm0kgmNdOPjyZ18WWQLyNfD/V7589CWIKy01gl0FBPZ5DYGxTa2pDXZoUeKFQuL
 x+VmLHG2+ZWyH3dfidhDnPKx+dc28gD4UgY0F8YKl2VsdPZnftrjgZJ+DE6QwkJnBVK1+V/Z
 jpiO0FvfPjc+j5pgI5IXny2GhEHDxqcoxSjx1wMnWzfbk+pSm2SczFtZbfTpBgUozBGYzxW3
 LCE02K0Az/lcfb40jY2RUM4+efoSsZ891Galc2qdyhf80LWvdYxbneSWFc1
IronPort-HdrOrdr: A9a23:VGLZHKst0n1+E2wou8xji46K7skC4YMji2hC6mlwRA09TyXGra
 +TdaUguSMc1gx9ZJhBo7G90KnpewK4yXcH2/hvAV7EZnibhILIFvAe0WKG+VPd8kLFh5ZgPM
 tbAs9D4ZjLfCJHZKXBkXmF+rQbsaC6GcmT7I+0pRcdLnAYV0gj1XYcNu/yKDwGeOAsP+teKH
 Pz3Lskm9PtQwVtUiztbUN1IdQr6ue72K7OUFojPVoK+QOOhTSn5PrTFAWZ5A4XV3dqza05+W
 bIvgTl7uH72svLhCP05iv21dB7idHhwtxMCIiljdUUECzljkKNaJ56U7OPkTgpqKWE6Uoskv
 PLvxA8Vv4DpE/5TyWQm1/AygPg2DEh5zvLzkKZu2LqpYjDSDczG6N69MlkWyqcz3BlkMB30a
 pN0W7cnYFQFwn8kCP04MWNfw12l2KvyEBS0tI7vjh6a88zebVRpYsQ8Ad+C5EbBh/374ghDa
 1HENzc3vBLalmXBkqp/lWH+ObcG0jbIy32BnTr4qeuon9rdTFCvgolLfUk7zU9HMlXcegD2w
 zGWp4Y3I2mAPVmNJ6UqY86MLyK41f2MGfx2VSpUB3a/ZE8SgDwQqHMkcEIDcGRCdY1JcgJ6d
 n8uG0xjx9FR6upM7zX4KF2
X-IronPort-AV: E=Sophos;i="5.85,358,1624334400"; 
   d="scan'208";a="55150512"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=FUcV5oWzRcjqrSFXxjKYaNz6e9SYez2feHJT+S+lyD9t9K3D1bfJc6Ctw/ikaJVuV/Fi0vInlE//GVzsPOP4nd8cbO+37j/JPWIFZ77NnDdYnIjgFSHd8iNc8pFMj2IMOZafyXgTH2racJiVkINBd664vSUKc1VXhtbD1uUDqICBXReMWL7yu6aIOQO1sFpug85ONDpm8e9ek3pw3ZkZM01fS3nLE7Y4OEY54axE/zMrTtICs06QTTbs3boczSY2UhQ3ppygEcMAukje+cktMLar8gBYvO/5/eK+aJ2rW3rYISsui3p6ffQ7YU+meEFfqRblBFYmeiK6RNzYVYtpSg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=rQhlx4wtZb7Wi4rVykfIpQlZmIumaYt5vzYfpm3VwZU=;
 b=Ss2bn8Kvnz9T+gxM0psSiqCvxj7aucopoUBRtLRLVi1m+hnIeeej8hgxez5Z+TAgKqj4GHwSzDosUGxKIbdcXEuWsqJQUYdVKS7Y9uQ5iCgRMnhD3kPnNP4EExCVT9pW8dTG7NiK6y8Egxf1I2MwB79tK97kAI/1Z2zQnCl5X4hF+EKG3nAj8oSK3Rlzk1h4tSAtpsDyrVYSe1X7YJPq/ySN0HGca00o+o22ILRLALA/l99qXc9Qs2jIk7HkdRQl2MuNieBQJEcSJsbBerCq5fa3DNNHkr24YzuiUspVsJAwtkuD1s0gPDPmTH19KmteBv50HNBAprMTuJqc0jwOfA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=rQhlx4wtZb7Wi4rVykfIpQlZmIumaYt5vzYfpm3VwZU=;
 b=JwnW92pP24nHOy2pSVNWTWSu0f6E37aZFq34nB70a/4W7PYLdfOcLg1qlov9BUaAbl2lbrxks/uziU9UC3KZMS4VEN9kUZuNQuRy5VZ0mo8N3OzGDj511UbiKscZRroRJpPvC2dBOntYGR34VyBeKdvKB5bnNWjZYszvqiB8Y+Y=
To: Rahul Singh <rahul.singh@arm.com>, <xen-devel@lists.xenproject.org>
CC: <bertrand.marquis@arm.com>, <Andre.Przywara@arm.com>, Christian Lindig
	<christian.lindig@citrix.com>, David Scott <dave@recoil.org>, Ian Jackson
	<iwj@xenproject.org>, Wei Liu <wl@xen.org>, George Dunlap
	<george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>, Julien Grall
	<julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>, Volodymyr
 Babchuk <Volodymyr_Babchuk@epam.com>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
	<roger.pau@citrix.com>
References: <cover.1633540842.git.rahul.singh@arm.com>
 <20d5b9d6a0d01a7b90711d28cbefb5701a88b438.1633540842.git.rahul.singh@arm.com>
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH v5 07/11] xen/domctl: Introduce XEN_DOMCTL_CDF_vpci flag
Message-ID: <548fa153-b2e3-7f91-c7c9-a569e13b5809@citrix.com>
Date: Fri, 8 Oct 2021 19:06:26 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <20d5b9d6a0d01a7b90711d28cbefb5701a88b438.1633540842.git.rahul.singh@arm.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Content-Language: en-GB
X-ClientProxiedBy: LO2P123CA0051.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:1::15) To BN7PR03MB3618.namprd03.prod.outlook.com
 (2603:10b6:406:c3::27)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 1c7671bc-0864-4a16-cdc0-08d98a865be3
X-MS-TrafficTypeDiagnostic: BN8PR03MB4802:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <BN8PR03MB4802689219EAC3B475ECC6C6BAB29@BN8PR03MB4802.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7691;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: F3uHnAVDHECoWnTrD4ruGk/xAfvMXozydaxXiDGw3rPOvs2NZKWnBKW8Ld2zK68NZq+/i+GVMLh5F8ZeZgvH/30L+TLmxXjcmZ3ELI1eNFyww7E/u27cp1bI/iGZA0bharjzTE8y+NZAPpG7qfXqjoTu+A9lKEE9UwCGG6wx254ZKpP+lNLvQ4fRXyP4Os7HbPOnuJQpwBspDRnmzc9RKkwRbBIJzlEi+OUjOKUjGHnRHzn9WjAfvUyDAPcNNt/VleZgPSVsJybrh4OuIyMX538WsuRhN+9Z6dINklwvngMZDzM/d4wRS5Ccf1RTtTcweUllU7FSO042TulKTV2Y7lMi6INo2DEnZRbAUHcJxIw4q5gRoM7fgFYUgcZeZXqVDSY731zToMuCr8vuvanh05DgyV4hKDprytHQkuuDVEfeY4rROBoGhKkEmCIphR/eDWKH/zuSh8CCFTDZYoHLBC7xM/gej+E8ThwzK8BnsCGtYoDbsnLOv6qUfHxSP5weXjlSxGr8N1hmPxeQzDqlQ4TbXIgcIow64EIBfNiDdQ+02XRLwJ2OIX/Bp3zz8Fw5iK1zcKfwHLvHWbxWOgbWhwcKLs+dHKZ3D1TKL785za2LWK00nDpf1RsDKyXAssWZCElxwonFJKR4AGm5wA+lZ2B6NteQM6kkNL6GWv2Wc7FI3rsxt0f/3b+ZhHss+gze/EpzKrfFuUiSRLPyO1LpwY09ZEDfb4Lhi00TGdgctt5cLsFUGVKAtt2vMNqE9TFG
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN7PR03MB3618.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(55236004)(31696002)(66946007)(7416002)(53546011)(316002)(16576012)(5660300002)(36756003)(86362001)(26005)(2906002)(6486002)(2616005)(31686004)(107886003)(38100700002)(956004)(8676002)(186003)(8936002)(508600001)(66476007)(54906003)(66556008)(4744005)(4326008)(6666004)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TERPUmI4K3ZhWlNqdGYxVm9DczRodkhmMitJc00wZWtHQUdkMEljQ1FtR1RP?=
 =?utf-8?B?WnpaS3VCemFOLzR5SDNjaGlsR3BqN0pRSDZpdS9JSkdHUi90cmZocmV2Q0pl?=
 =?utf-8?B?SzNuaGpIb2l1Qm1IM3FUYlp0eHZiK1ptK1V3RC8zdy82aHZaUFRRL2VHd1Fy?=
 =?utf-8?B?MGJueitlb3h0S2FCa3JCNjRQMHEvUDdSRm1WTXN0YnJvcE1WaGExZUd3dXk3?=
 =?utf-8?B?ak9pR3FMdEF6MEIyYjVJZlBoZEYxNUtua0xkY25BdE93NzZVUlBEblp6NzNP?=
 =?utf-8?B?UFhhN0tUSHNOakpjZHJBL28xUjcwdDBjb2JKWkRUNUFLSFhkU2RpUDF1ZG1D?=
 =?utf-8?B?S0dabHJVZEZwcHVQU0szYkZ1L3NSSTdqQnUwNS9aa1ArMTJtaHo1ZlJKUWtX?=
 =?utf-8?B?T0VlZVdwWmtXZDBsUjNFYjNDNjFkOG1LenpaRHRZZG01QXBJOUxSUFR6a3pt?=
 =?utf-8?B?RFRsSTFlOW5UMy9SZW9MUERzYndWdDFnUHRERXRCbmpRUG9USHlQdHV1ZkRX?=
 =?utf-8?B?b0l6Zm4wU1NLOFlqVkVWdDc3TzlzS3NkNXhRcXJXMVNpRyttODBBSGNWb2F5?=
 =?utf-8?B?clBIK013NUlFak9uUnBQeHZMZE9lQmtTUzJ6OEtrdWNPb0Y3RjN6OWxhd1Mv?=
 =?utf-8?B?QTEvWWZXUkFpMGw5U1hpMHlMaWtVaWJHYkRUd3EvdGJ0RFhva1pwMTIwQitD?=
 =?utf-8?B?NjMwb25oMW51aDFyTTZaYVMrNFVjNm5FM3JZNWJLVkUrdEVpd0NQTnp5aDN2?=
 =?utf-8?B?VjlicW5aVW4yOWpGS0E5dkR5SVpma3hkU0NodnVTdk5HYUZyV0hUTTB4cGh1?=
 =?utf-8?B?eFhaWmRmL1pzQWlTTTcvMFphMFEzb1cram9qUTl1QmpIYm52bXMvcGZXMmQz?=
 =?utf-8?B?Q1EyYVpQampjeWdabEtFd2dvM3lDZDNtaGFWTi9EMVY2UUtqd0xDU1BnWkts?=
 =?utf-8?B?c0c2U3RXRGpoaUFsalF0QkdsV3hoSkd4TjBqYzd0YUZ4Q05NN3BsbG5UR2xo?=
 =?utf-8?B?MGp4cnpadDNKdExYaE1EbVN5NEF4NEIxRDhUL2JuTWk4ZkFOZUNDVHVnNGRL?=
 =?utf-8?B?aTNuSG1zK25EL1RqRnQrMHh2UDZMV1JVV0lwTUpDTmJOWDJtOHdIT213dzBN?=
 =?utf-8?B?R3ZWSmw5UkpxZllYbU1OU0tEMTY3UHB5RlE2VFAzRVpzcEx0ZFVkOEpkMUVJ?=
 =?utf-8?B?TDlUdm83TnRCQUhVL01UT1Vib2R1VDlqWnVhMWVaVnVpcjRqd0RQc3Yzdzcz?=
 =?utf-8?B?R0daU3RPNlZBZ3VLOUtqNHVkcUlVUDBIemlDcVkramxTeWQyZjQ5YTlMSXo1?=
 =?utf-8?B?d0FBelJQNWg0K29uakswTk10VTNSakRmSWc4SFZqS1doZTh4UDhMN3d1Uzgv?=
 =?utf-8?B?bGl2U1ZUcEQvYnlzVE50M2kzYlVZVVFSVGw3QXJVZGJWNjRadUV6bEo1enc5?=
 =?utf-8?B?RlpxN3pHMzZ2L2JrWWtxVjgwelB4NWJtSi92T1lUaCtxdkUxQmxrVGtFY0ll?=
 =?utf-8?B?bkxDWFJGeDBoMVpPemY5Q0g0WC9LZ1VrN0FQcHBYYU0vbkhNeXlTTjFYV2Zm?=
 =?utf-8?B?b1RRLzJzNjd0UkVGbEhzaXVkejNKdDlFeHErNGZVMytvMGxGZXdXQUo2UG9B?=
 =?utf-8?B?SmJ6Ri9GeUowN0gyUi91R3UyNUdxb1NvSDdNRU5SZVA5dHpkTkdHcEo5M0pj?=
 =?utf-8?B?eEhLQ29ValNNdXhTYUduZGMzWk5wQ0NvOTYxdEcrbURyYUNQTDlUVmZycUd6?=
 =?utf-8?Q?w0A5I7z8u51jJwBxE0DAWDWdLfsb8BAe10SOmiO?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 1c7671bc-0864-4a16-cdc0-08d98a865be3
X-MS-Exchange-CrossTenant-AuthSource: BN7PR03MB3618.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Oct 2021 18:06:32.4780
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: CCVkO27xMdIuotuppJUbtaIVL4C4BPB26uvSvNCroU5pwk7Afd5y2/oXrdJ7BkMdS3XukxyFs+Z22nagPNUNjJDopxZDg0l0LbBMibXhTS0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR03MB4802
X-OriginatorOrg: citrix.com

On 06/10/2021 18:40, Rahul Singh wrote:
> Introduce XEN_DOMCTL_CDF_vpci flag to enable VPCI support in XEN.
> Reject the use of this new flag for x86 as VPCI is not supported for
> DOMU guests for x86.
>
> Signed-off-by: Rahul Singh <rahul.singh@arm.com>
> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
> Acked-by: Christian Lindig <christian.lindig@citrix.com>

I'm afraid this logic is broken.

There's no matching feature to indicate to the toolstack whether
XEN_DOMCTL_CDF_vpci will be accepted or not.=C2=A0 The usual way of doing
this is with a physinfo_cap field.

This flag needs using in Patch 10 to reject attempts to create a VM with
devices when passthrough support is unavailable.

Ian, for the 4.16 release, this series either needs completing with the
additional flag implemented, or this patch needs reverting to avoid us
shipping a broken interface.

~Andrew



From xen-devel-bounces@lists.xenproject.org Fri Oct 08 20:26:37 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Oct 2021 20:26:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.204859.360043 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYwRi-0000uf-Nj; Fri, 08 Oct 2021 20:26:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 204859.360043; Fri, 08 Oct 2021 20:26:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYwRi-0000uY-KE; Fri, 08 Oct 2021 20:26:22 +0000
Received: by outflank-mailman (input) for mailman id 204859;
 Fri, 08 Oct 2021 20:26:21 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=N7pG=O4=kernel.org=pr-tracker-bot@srs-us1.protection.inumbo.net>)
 id 1mYwRh-0000uS-Bq
 for xen-devel@lists.xenproject.org; Fri, 08 Oct 2021 20:26:21 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id ea281b29-3ba2-48f0-9772-d9bcdd205d9e;
 Fri, 08 Oct 2021 20:26:20 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPS id E1550610E7;
 Fri,  8 Oct 2021 20:26:19 +0000 (UTC)
Received: from pdx-korg-docbuild-2.ci.codeaurora.org (localhost.localdomain
 [127.0.0.1])
 by pdx-korg-docbuild-2.ci.codeaurora.org (Postfix) with ESMTP id D1F5960985;
 Fri,  8 Oct 2021 20:26:19 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ea281b29-3ba2-48f0-9772-d9bcdd205d9e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1633724779;
	bh=vT5acUdijVlmgJ73PQ7CevuSDxlM5VYf0E2NOdYsC4Y=;
	h=Subject:From:In-Reply-To:References:Date:To:Cc:From;
	b=dXgWir2THYdjizavZQrBr72bREyVMCL0fFpYMn29dzmeShRaLJd5jlE2Wi1pe80o8
	 Tr8el6+5cD8eDSz6bQcfw9gBJayKunkq0UJNfU7+amqCrr0Hvr9T30S53209U5zCHF
	 bYBg3NK6a4O2typZRFPlx+RXGHZRsCiojNtPAF2Iq+2+Ng/uWhK+HuU28Dfwwz/2Xa
	 aO+ejv/wdSMY8oktyzs3Gnp67uoC6xCLnNG3OX8euEDWTq/Ps58jiI8zpRq/V5ERDu
	 EwoTDbGw3wnOhbwECJomsf5vb3fFiHHWRsYo/6zdwXOa5Su350qDCu3beeTEv/cjmy
	 z5QK57SMRmVvQ==
Subject: Re: [GIT PULL] xen: branch for v5.15-rc5
From: pr-tracker-bot@kernel.org
In-Reply-To: <20211008141911.25271-1-jgross@suse.com>
References: <20211008141911.25271-1-jgross@suse.com>
X-PR-Tracked-List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
X-PR-Tracked-Message-Id: <20211008141911.25271-1-jgross@suse.com>
X-PR-Tracked-Remote: git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git for-linus-5.15b-rc5-tag
X-PR-Tracked-Commit-Id: 319933a80fd4f07122466a77f93e5019d71be74c
X-PR-Merge-Tree: torvalds/linux.git
X-PR-Merge-Refname: refs/heads/master
X-PR-Merge-Commit-Id: 3946b46cab8b4714a9274af91772b9ad17a10e12
Message-Id: <163372477980.4543.4165045948379929086.pr-tracker-bot@kernel.org>
Date: Fri, 08 Oct 2021 20:26:19 +0000
To: Juergen Gross <jgross@suse.com>
Cc: torvalds@linux-foundation.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, boris.ostrovsky@oracle.com

The pull request you sent on Fri,  8 Oct 2021 16:19:11 +0200:

> git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git for-linus-5.15b-rc5-tag

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/3946b46cab8b4714a9274af91772b9ad17a10e12

Thank you!

-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html


From xen-devel-bounces@lists.xenproject.org Fri Oct 08 21:12:56 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Oct 2021 21:12:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.204870.360054 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYxAf-00060X-Et; Fri, 08 Oct 2021 21:12:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 204870.360054; Fri, 08 Oct 2021 21:12:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYxAf-00060Q-Ax; Fri, 08 Oct 2021 21:12:49 +0000
Received: by outflank-mailman (input) for mailman id 204870;
 Fri, 08 Oct 2021 21:12:47 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=stSb=O4=gmail.com=julien.grall.oss@srs-us1.protection.inumbo.net>)
 id 1mYxAd-00060K-HV
 for xen-devel@lists.xenproject.org; Fri, 08 Oct 2021 21:12:47 +0000
Received: from mail-ed1-x52f.google.com (unknown [2a00:1450:4864:20::52f])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 7e291b7e-baef-4c2f-9b26-31db77b2e074;
 Fri, 08 Oct 2021 21:12:46 +0000 (UTC)
Received: by mail-ed1-x52f.google.com with SMTP id y12so27968972eda.4
 for <xen-devel@lists.xenproject.org>; Fri, 08 Oct 2021 14:12:45 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7e291b7e-baef-4c2f-9b26-31db77b2e074
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=cTYNtFHdXJVhmhKUk/jw25iIHy9fcbY70CNpzjFaV7c=;
        b=UaGFMcGjxhStFn+jCjRUjtwz3U1TW7/gpM1u+gaZdtkdhNMUPAlL3YJIWcwprsKTjV
         cxJjJa5HHB/YY2aqxsnxqmm0kjypgd4M50/WLv6qjaPteELHDNx123fYef1b/2INCUqJ
         qPB8UyIwvrhX7CvAzWPpfV6pucBXGnig7eRXQs0w5ZIWq+bABovHnNKESm7Sg0Dl8pZo
         RqRHDdUT6wXxN/u+j3e5QUbL+YQeDxaUVRhAgYn45T7CAgS+DD5c9Tr00zg76fpQelVJ
         sp4N7TO8qeYngJ0KyWXW3k8OaSayb5ai2R2pojY65F2sEdwEOogpwlzC1cMw6vPTyg/W
         gYVw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=cTYNtFHdXJVhmhKUk/jw25iIHy9fcbY70CNpzjFaV7c=;
        b=YgIEXYqrKQ1v+Uu27ocVLVWVIOSmngMyXVPWN0kise1lwKhDYARvhd/xVon0a9XrSh
         TsItWO4oXueEHDqs+/2crt/oxRzzmIdmDtn5+nQOySd9+ZGFyhuak3EV//mfLahIG7Dt
         Uz5IQvUSvKvY8nsNXrAccn79I6+i/ysfgA8yjnfuZZ9XgAM7aJt3+gpHXlfD/nJ0vv/j
         2+27PQjkH/G7lHe6J7sqEuNl+bsQNZlp+hXAk8H0hkfDI07X539xAMD/5S/fC2dXREaT
         ZGPDYhLqENc4elhfh9GxoT7/r6c3LfVKRLzooC9T0c4bd37+ns2M/r948WI//J+cF6NP
         7nmw==
X-Gm-Message-State: AOAM531Mxbf1TNp+lsb/MwnCNAl5uDjRFxRj3iMsTZlfYRJPGEmIV8Hg
	LWeltksI0sYl7TWTuJWMFdnj3lvHuhwgpCnn+Oo=
X-Google-Smtp-Source: ABdhPJz9Gv+TZ61UBcOFlEYcDMEyEVb2VkXRVFiqlSLnJnYoREkFQFqpAExBtfs/czyco2TTURem1tO+B5/M6ByiiHE=
X-Received: by 2002:a17:906:2cc9:: with SMTP id r9mr7333075ejr.138.1633727565101;
 Fri, 08 Oct 2021 14:12:45 -0700 (PDT)
MIME-Version: 1.0
References: <cover.1633540842.git.rahul.singh@arm.com> <20d5b9d6a0d01a7b90711d28cbefb5701a88b438.1633540842.git.rahul.singh@arm.com>
 <548fa153-b2e3-7f91-c7c9-a569e13b5809@citrix.com>
In-Reply-To: <548fa153-b2e3-7f91-c7c9-a569e13b5809@citrix.com>
From: Julien Grall <julien.grall.oss@gmail.com>
Date: Fri, 8 Oct 2021 23:12:34 +0200
Message-ID: <CAJ=z9a2kYdYB9fSXX8NhLk90px03z8+D-YE5AQKW9uABx9kvrQ@mail.gmail.com>
Subject: Re: [PATCH v5 07/11] xen/domctl: Introduce XEN_DOMCTL_CDF_vpci flag
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Rahul Singh <rahul.singh@arm.com>, xen-devel <xen-devel@lists.xenproject.org>, 
	Bertrand Marquis <bertrand.marquis@arm.com>, Andre Przywara <Andre.Przywara@arm.com>, 
	Christian Lindig <christian.lindig@citrix.com>, David Scott <dave@recoil.org>, 
	Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>, 
	George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>, 
	Stefano Stabellini <sstabellini@kernel.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, 
	=?UTF-8?Q?Roger_Pau_Monn=C3=A9?= <roger.pau@citrix.com>
Content-Type: multipart/alternative; boundary="0000000000002d7dc405cdddd707"

--0000000000002d7dc405cdddd707
Content-Type: text/plain; charset="UTF-8"

Hi Andrew,

On Fri, 8 Oct 2021, 20:07 Andrew Cooper, <andrew.cooper3@citrix.com> wrote:

> On 06/10/2021 18:40, Rahul Singh wrote:
> > Introduce XEN_DOMCTL_CDF_vpci flag to enable VPCI support in XEN.
> > Reject the use of this new flag for x86 as VPCI is not supported for
> > DOMU guests for x86.
> >
> > Signed-off-by: Rahul Singh <rahul.singh@arm.com>
> > Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
> > Acked-by: Christian Lindig <christian.lindig@citrix.com>
>
> I'm afraid this logic is broken.
>
> There's no matching feature to indicate to the toolstack whether
> XEN_DOMCTL_CDF_vpci will be accepted or not.  The usual way of doing
> this is with a physinfo_cap field.
>

I am slightly puzzled by this. I am assuming you are referring to
XENVER_get_features which AFAICT is a stable interface. So why should we
use it to describe the presence of an unstable interface?


> This flag needs using in Patch 10 to reject attempts to create a VM with
> devices when passthrough support is unavailable.
>

May I ask why we can't rely on the hypervisor to reject the flag when
suitable?


> Ian, for the 4.16 release, this series either needs completing with the
> additional flag implemented, or this patch needs reverting to avoid us
> shipping a broken interface.


I fail to see how the interface would be broken... Would you mind to
describe a bit more what could go wrong with this interface?

Cheers,


> ~Andrew
>
>

--0000000000002d7dc405cdddd707
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"auto"><div>Hi Andrew,<br><br><div class=3D"gmail_quote"><div di=
r=3D"ltr" class=3D"gmail_attr">On Fri, 8 Oct 2021, 20:07 Andrew Cooper, &lt=
;<a href=3D"mailto:andrew.cooper3@citrix.com" target=3D"_blank" rel=3D"nore=
ferrer">andrew.cooper3@citrix.com</a>&gt; wrote:<br></div><blockquote class=
=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padd=
ing-left:1ex">On 06/10/2021 18:40, Rahul Singh wrote:<br>
&gt; Introduce XEN_DOMCTL_CDF_vpci flag to enable VPCI support in XEN.<br>
&gt; Reject the use of this new flag for x86 as VPCI is not supported for<b=
r>
&gt; DOMU guests for x86.<br>
&gt;<br>
&gt; Signed-off-by: Rahul Singh &lt;<a href=3D"mailto:rahul.singh@arm.com" =
rel=3D"noreferrer noreferrer" target=3D"_blank">rahul.singh@arm.com</a>&gt;=
<br>
&gt; Reviewed-by: Stefano Stabellini &lt;<a href=3D"mailto:sstabellini@kern=
el.org" rel=3D"noreferrer noreferrer" target=3D"_blank">sstabellini@kernel.=
org</a>&gt;<br>
&gt; Acked-by: Christian Lindig &lt;<a href=3D"mailto:christian.lindig@citr=
ix.com" rel=3D"noreferrer noreferrer" target=3D"_blank">christian.lindig@ci=
trix.com</a>&gt;<br>
<br>
I&#39;m afraid this logic is broken.<br>
<br>
There&#39;s no matching feature to indicate to the toolstack whether<br>
XEN_DOMCTL_CDF_vpci will be accepted or not.=C2=A0 The usual way of doing<b=
r>
this is with a physinfo_cap field.<br></blockquote></div></div><div dir=3D"=
auto"><br></div><div dir=3D"auto">I am slightly puzzled by this. I am assum=
ing you are referring to XENVER_get_features which AFAICT is a stable inter=
face. So why should we use it to describe the presence of an unstable inter=
face?</div><div dir=3D"auto"><br></div><div dir=3D"auto"><div class=3D"gmai=
l_quote"><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;borde=
r-left:1px #ccc solid;padding-left:1ex">
<br>
This flag needs using in Patch 10 to reject attempts to create a VM with<br=
>
devices when passthrough support is unavailable.<br></blockquote></div></di=
v><div dir=3D"auto"><br></div><div dir=3D"auto">May I ask why we can&#39;t =
rely on the hypervisor to reject the flag when suitable?</div><div dir=3D"a=
uto"><br></div><div dir=3D"auto"><div class=3D"gmail_quote"><blockquote cla=
ss=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;pa=
dding-left:1ex">
<br>
Ian, for the 4.16 release, this series either needs completing with the<br>
additional flag implemented, or this patch needs reverting to avoid us<br>
shipping a broken interface.</blockquote></div></div><div dir=3D"auto"><br>=
</div><div dir=3D"auto">I fail to see how the interface would be broken... =
Would you mind to describe a bit more what could go wrong with this interfa=
ce?</div><div dir=3D"auto"><br></div><div dir=3D"auto">Cheers,</div><div di=
r=3D"auto"></div><div dir=3D"auto"><br></div><div dir=3D"auto"></div><div d=
ir=3D"auto"></div><div dir=3D"auto"></div><div dir=3D"auto"><div class=3D"g=
mail_quote"><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;bo=
rder-left:1px #ccc solid;padding-left:1ex">
<br>
~Andrew<br>
<br>
</blockquote></div></div></div>

--0000000000002d7dc405cdddd707--


From xen-devel-bounces@lists.xenproject.org Fri Oct 08 21:43:13 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Oct 2021 21:43:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.204879.360065 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYxdo-0000pp-QH; Fri, 08 Oct 2021 21:42:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 204879.360065; Fri, 08 Oct 2021 21:42:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYxdo-0000pi-Mz; Fri, 08 Oct 2021 21:42:56 +0000
Received: by outflank-mailman (input) for mailman id 204879;
 Fri, 08 Oct 2021 21:42:56 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mYxdo-0000pY-8l; Fri, 08 Oct 2021 21:42:56 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mYxdo-0004kv-5Q; Fri, 08 Oct 2021 21:42:56 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mYxdn-0007Nb-TF; Fri, 08 Oct 2021 21:42:55 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mYxdn-0004Yj-Sm; Fri, 08 Oct 2021 21:42:55 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=lYoUcg+g0/k6LtR6IWe3OOyP6z24cJ2Fa5rV3fHBfeI=; b=6zElJnbwz+fGqOTZhI9LEqt4Yg
	rb+Nwo7Z9UVTapUYpenrSJd0J2O37UDL0cE0ly/ZPF+EIWzgoTyeH4XAa4VXr9lNZONoFSJOIoVRV
	XDYIimmNxayyRsdZLUQ84BPJgeXeAdUuBOy9e0YZ5/NI8PYzIOKwwvFO3cfT/la4I9vg=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165436-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 165436: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=b11380f6cd58ce40422473262b2b4c2b210447a1
X-Osstest-Versions-That:
    xen=1d345539c0e3654025fc00187bf633fda6ea9a43
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 08 Oct 2021 21:42:55 +0000

flight 165436 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165436/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  b11380f6cd58ce40422473262b2b4c2b210447a1
baseline version:
 xen                  1d345539c0e3654025fc00187bf633fda6ea9a43

Last test of basis   165423  2021-10-08 00:01:40 Z    0 days
Testing same since   165436  2021-10-08 18:01:40 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   1d345539c0..b11380f6cd  b11380f6cd58ce40422473262b2b4c2b210447a1 -> smoke


From xen-devel-bounces@lists.xenproject.org Fri Oct 08 21:46:23 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Oct 2021 21:46:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.204889.360079 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYxh9-0001UK-BG; Fri, 08 Oct 2021 21:46:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 204889.360079; Fri, 08 Oct 2021 21:46:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYxh9-0001UD-88; Fri, 08 Oct 2021 21:46:23 +0000
Received: by outflank-mailman (input) for mailman id 204889;
 Fri, 08 Oct 2021 21:46:22 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=79mX=O4=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1mYxh8-0001U7-7q
 for xen-devel@lists.xenproject.org; Fri, 08 Oct 2021 21:46:22 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id ba2c7331-fc69-4a0f-82cb-31e9bdb17cf1;
 Fri, 08 Oct 2021 21:46:21 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id 507B260FE3;
 Fri,  8 Oct 2021 21:46:20 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ba2c7331-fc69-4a0f-82cb-31e9bdb17cf1
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1633729580;
	bh=GdXDD10ZUr070vfQaw5xvKCe/blUKcPOEf3h8T0oBuo=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=eOCq8letN40zgYkImhSytRrgqcsyHkYv9bgjWahmQ1Ph6E+mqRATbcts06OfLo/z/
	 5iIOTDZkMOpI1LfHoBirlCtqWdfFyEHdAZ1cyFjYJWIF0YFIW3/imq8epOvKn78dnH
	 /6vC5fCphvNX/Sb+MBVbXudaJaqdHsu8F7OJbtalFim9YwtEkhzdwnwSIBtB0X6wec
	 B6HZl4Zz0y3VBytZ8se/J7XoqtNhcxHVsv0CgVVl/zdbjHCnRgUp2AdClMhzdY48Aj
	 SZ+I7uHq9ncd9hragPPSgxYbeHv0vKufQYhQLFlJr2kjeMe5NEvx3Le8Aa80gcvizi
	 dC0MyaSYffQdQ==
Date: Fri, 8 Oct 2021 14:46:14 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Julien Grall <julien.grall.oss@gmail.com>
cc: Andrew Cooper <andrew.cooper3@citrix.com>, 
    Rahul Singh <rahul.singh@arm.com>, 
    xen-devel <xen-devel@lists.xenproject.org>, 
    Bertrand Marquis <bertrand.marquis@arm.com>, 
    Andre Przywara <Andre.Przywara@arm.com>, 
    Christian Lindig <christian.lindig@citrix.com>, 
    David Scott <dave@recoil.org>, Ian Jackson <iwj@xenproject.org>, 
    Wei Liu <wl@xen.org>, George Dunlap <george.dunlap@citrix.com>, 
    Jan Beulich <jbeulich@suse.com>, 
    Stefano Stabellini <sstabellini@kernel.org>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, 
    =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= <roger.pau@citrix.com>
Subject: Re: [PATCH v5 07/11] xen/domctl: Introduce XEN_DOMCTL_CDF_vpci
 flag
In-Reply-To: <CAJ=z9a2kYdYB9fSXX8NhLk90px03z8+D-YE5AQKW9uABx9kvrQ@mail.gmail.com>
Message-ID: <alpine.DEB.2.21.2110081433110.25528@sstabellini-ThinkPad-T480s>
References: <cover.1633540842.git.rahul.singh@arm.com> <20d5b9d6a0d01a7b90711d28cbefb5701a88b438.1633540842.git.rahul.singh@arm.com> <548fa153-b2e3-7f91-c7c9-a569e13b5809@citrix.com> <CAJ=z9a2kYdYB9fSXX8NhLk90px03z8+D-YE5AQKW9uABx9kvrQ@mail.gmail.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: multipart/mixed; BOUNDARY="8323329-2142132412-1633729349=:25528"
Content-ID: <alpine.DEB.2.21.2110081443090.25528@sstabellini-ThinkPad-T480s>

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-2142132412-1633729349=:25528
Content-Type: text/plain; CHARSET=UTF-8
Content-Transfer-Encoding: 8BIT
Content-ID: <alpine.DEB.2.21.2110081443091.25528@sstabellini-ThinkPad-T480s>

On Fri, 8 Oct 2021, Julien Grall wrote:
> Hi Andrew,
> 
> On Fri, 8 Oct 2021, 20:07 Andrew Cooper, <andrew.cooper3@citrix.com> wrote:
>       On 06/10/2021 18:40, Rahul Singh wrote:
>       > Introduce XEN_DOMCTL_CDF_vpci flag to enable VPCI support in XEN.
>       > Reject the use of this new flag for x86 as VPCI is not supported for
>       > DOMU guests for x86.
>       >
>       > Signed-off-by: Rahul Singh <rahul.singh@arm.com>
>       > Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
>       > Acked-by: Christian Lindig <christian.lindig@citrix.com>
> 
>       I'm afraid this logic is broken.
> 
>       There's no matching feature to indicate to the toolstack whether
>       XEN_DOMCTL_CDF_vpci will be accepted or not.  The usual way of doing
>       this is with a physinfo_cap field.
> 
> 
> I am slightly puzzled by this. I am assuming you are referring to XENVER_get_features which AFAICT is a stable interface. So why should we
> use it to describe the presence of an unstable interface?
> 
> 
>       This flag needs using in Patch 10 to reject attempts to create a VM with
>       devices when passthrough support is unavailable.
> 
> 
> May I ask why we can't rely on the hypervisor to reject the flag when suitable?
> 
> 
>       Ian, for the 4.16 release, this series either needs completing with the
>       additional flag implemented, or this patch needs reverting to avoid us
>       shipping a broken interface.
> 
> 
> I fail to see how the interface would be broken... Would you mind to describe a bit more what could go wrong with this interface?


After chatting with Andrew on IRC, this is my understanding.

Today if pci=[] is specified in the VM config file then
XEN_DOMCTL_CDF_vpci is added. If Xen doesn't support it, Xen returns
an error but libxl/xl won't be able to tell exactly why it fails. So xl
will end up printing a generic VM creation failure. Andrew would like to
see something like the following in libxl:

if ( PCI_devices && !cap.vcpi )
    error("Sorry - PCI not supported")

So that the user gets a clear informative error back rather than a
generic VM creation failure. Also, this is a requirement for the stable
hypercall interface.


I think that's fine and we can implement this request easily by adding
XEN_SYSCTL_PHYSCAP_vpci. Rahul or Bertrand, are you guys happy with
doing that? Otherwise I could take it on.


As a side note, given that PCI passthrough support is actually not yet
complete on ARM, we could even just do the following in xl/libxl:

if ( PCI_devices )
    error("Sorry - PCI not supported")

or temporarily remove XEN_DOMCTL_CDF_vpci until PCI passthrough gets
finalized.
--8323329-2142132412-1633729349=:25528--


From xen-devel-bounces@lists.xenproject.org Fri Oct 08 21:49:44 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Oct 2021 21:49:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.204898.360090 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYxkK-0002Bv-Qx; Fri, 08 Oct 2021 21:49:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 204898.360090; Fri, 08 Oct 2021 21:49:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYxkK-0002Bo-Nq; Fri, 08 Oct 2021 21:49:40 +0000
Received: by outflank-mailman (input) for mailman id 204898;
 Fri, 08 Oct 2021 21:49:39 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=79mX=O4=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1mYxkJ-0002Bi-67
 for xen-devel@lists.xenproject.org; Fri, 08 Oct 2021 21:49:39 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id a1ac0881-2881-11ec-806e-12813bfff9fa;
 Fri, 08 Oct 2021 21:49:37 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id 671C060F5A;
 Fri,  8 Oct 2021 21:49:36 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a1ac0881-2881-11ec-806e-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1633729776;
	bh=zYgc2KySU574VK2+sIC0E7Zbc9+Awrwmox/8SIxPsD4=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=pj0hNFB5G4GaVj80XqGC0yU/eUpeeHi07TkPgsJDEWn/JmDQvyEbso8tz/p+xxICx
	 lcgH+Mqkaygsg32spH5n4cq2LdF9ipfrSNMPvuw0S3jUwG06q93rXClUsjmzcnPEZ2
	 fwYMOREUgjypNTKuovYjUoi1l1f3zkBRQrwI3tKsKzMpfqWphpHSrhVvJTm1IJYdlo
	 jR1H8OrN5dep6vdIs7jsDG23BNDO/dPYIIKDlxeiSFo3/RLmZo8PXuAAeADGad7LZ2
	 w4/arza3cHnk39PsK1rwxARAyMmBhtVXs+SRXYhFpDlBW0kQmKskksDOmdh0BfaoTt
	 54ifLODgjS79g==
Date: Fri, 8 Oct 2021 14:49:35 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Julien Grall <julien@xen.org>
cc: Stefano Stabellini <sstabellini@kernel.org>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, 
    Oleksandr <olekstysh@gmail.com>, 
    "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, 
    Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>, 
    Julien Grall <jgrall@amazon.com>
Subject: Re: [PING] Re: [PATCH] xen/arm: optee: Allocate anonymous domheap
 pages
In-Reply-To: <b9443cac-36ff-79b0-89d5-b96e8fc11d11@xen.org>
Message-ID: <alpine.DEB.2.21.2110081236580.414@sstabellini-ThinkPad-T480s>
References: <1630935741-17088-1-git-send-email-olekstysh@gmail.com> <alpine.DEB.2.21.2109231308200.17979@sstabellini-ThinkPad-T480s> <87bl4jrovq.fsf@epam.com> <81f7699b-69c1-da52-a1a7-5000343bf872@gmail.com> <alpine.DEB.2.21.2110061639050.3209@sstabellini-ThinkPad-T480s>
 <87r1cwra4t.fsf@epam.com> <alpine.DEB.2.21.2110071357160.414@sstabellini-ThinkPad-T480s> <b9443cac-36ff-79b0-89d5-b96e8fc11d11@xen.org>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Fri, 8 Oct 2021, Julien Grall wrote:
> On 07/10/2021 23:14, Stefano Stabellini wrote:
> > On Thu, 7 Oct 2021, Volodymyr Babchuk wrote:
> > > Hi Stefano,
> > > 
> > > Stefano Stabellini <sstabellini@kernel.org> writes:
> > > 
> > > > On Wed, 6 Oct 2021, Oleksandr wrote:
> > > > > Hello all
> > > > > 
> > > > > Gentle reminder.
> > > >   Many thanks for the ping, this patch fell off my radar.
> > > > 
> > > > 
> > > >   
> > > > > On 23.09.21 23:57, Volodymyr Babchuk wrote:
> > > > > > Hi Stefano,
> > > > > > 
> > > > > > Stefano Stabellini <sstabellini@kernel.org> writes:
> > > > > > 
> > > > > > > On Mon, 6 Sep 2021, Oleksandr Tyshchenko wrote:
> > > > > > > > From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> > > > > > > > 
> > > > > > > > Allocate anonymous domheap pages as there is no strict need to
> > > > > > > > account them to a particular domain.
> > > > > > > > 
> > > > > > > > Since XSA-383 "xen/arm: Restrict the amount of memory that
> > > > > > > > dom0less
> > > > > > > > domU and dom0 can allocate" the dom0 cannot allocate memory
> > > > > > > > outside
> > > > > > > > of the pre-allocated region. This means if we try to allocate
> > > > > > > > non-anonymous page to be accounted to dom0 we will get an
> > > > > > > > over-allocation issue when assigning that page to the domain.
> > > > > > > > The anonymous page, in turn, is not assigned to any domain.
> > > > > > > > 
> > > > > > > > CC: Julien Grall <jgrall@amazon.com>
> > > > > > > > Signed-off-by: Oleksandr Tyshchenko
> > > > > > > > <oleksandr_tyshchenko@epam.com>
> > > > > > > > Acked-by: Volodymyr Babchuk <volodymyr_babchuk@epam.com>
> > > > > > > Only one question, which is more architectural: given that these
> > > > > > > pages
> > > > > > > are "unlimited", could the guest exploit the interface somehow to
> > > > > > > force
> > > > > > > Xen to allocate an very high number of anonymous pages?
> > > > > > > 
> > > > > > > E.g. could a domain call OPTEE_SMC_RPC_FUNC_ALLOC in a loop to
> > > > > > > force Xen
> > > > > > > to exaust all memory pages?
> > > > > > Generally, OP-TEE mediator tracks all resources allocated and
> > > > > > imposes
> > > > > > limits on them.
> > > > > > 
> > > > > > OPTEE_SMC_RPC_FUNC_ALLOC case is a bit different, because it is
> > > > > > issued
> > > > > > not by domain, but by OP-TEE itself. As OP-TEE is more trusted piece
> > > > > > of
> > > > > > system we allow it to request as many buffers as it wants. Also, we
> > > > > > know
> > > > > > that OP-TEE asks only for one such buffer per every standard call.
> > > > > > And
> > > > > > number of simultaneous calls is limited by number of OP-TEE threads,
> > > > > > which is quite low: typically only two.
> > > > 
> > > > So let me repeat it differently to see if I understood correctly:
> > > > 
> > > > - OPTEE_SMC_RPC_FUNC_ALLOC is only called by OP-TEE, not by the domain
> > > > - OPTEE is trusted and only call it twice anyway
> > > 
> > > Correct.
> > > 
> > > > I am OK with this argument, but do we have a check to make sure a domU
> > > > cannot issue OPTEE_SMC_RPC_FUNC_ALLOC?
> > > 
> > > domU can't issue any RPC, because all RPCs are issued from OP-TEE
> > > side. This is the nature of RPC - OP-TEE requests Normal World for some
> > > service. But of course, Normal World can perform certain actions that
> > > will make OP-TEE to issue a RPC. I discuss this in depth below.
> > > 
> > > > 
> > > > Looking at the patch, there are other two places, in addition to
> > > > OPTEE_SMC_RPC_FUNC_ALLOC, where the anonymous memory pages can be
> > > > allocated:
> > > > 
> > > > 1) copy_std_request
> > > > 2) translate_noncontig
> > > > 
> > > > We need to prove that neither 1) or 2) can result in a domU exausting
> > > > Xen memory.
> > > > 
> > > > In the case of 1), it looks like the memory is freed before returning to
> > > > the DomU, right? If so, it should be no problem?
> > > 
> > > Yes, mediator makes shadow copy of every request buffer to hide
> > > translated addresses from the guest. Number of requests is limited by
> > > number of OP-TEE threads.
> > > 
> > > > In the case of 2), it looks like the memory could outlive the call where
> > > > it is allocated. Is there any kind of protection against issuing
> > > > something like OPTEE_MSG_ATTR_TYPE_TMEM_INOUT in a loop? Is it OP-TEE
> > > > itself that would refuse the attempt? Thus, the idea is that
> > > > do_call_with_arg will return error and we'll just free the memory there?
> > > 
> > > Well, translate_noncontig() calls allocate_optee_shm_buf() which counts
> > > all allocated buffers. So you can't call it more than
> > > MAX_SHM_BUFFER_COUNT times, without de-allocating previous memory. But,
> > > thanks to your question, I have found a bug there: memory is not freed
> > > if allocate_optee_shm_buf() fails. I'll prepare patch later today.
> > > 
> > > > I cannot see a check for errors returned by do_call_with_arg and memory
> > > > freeing done because of that. Sorry I am not super familiar with the
> > > > code, I am just trying to make sure we are not offering to DomUs an easy
> > > > way to crash the system.
> > > 
> > > I tried to eliminate all possibilities for a guest to crash the
> > > system. Of course, this does not mean that there are none of them.
> > > 
> > > And yes, code is a bit hard to understand, because calls to OP-TEE are
> > > stateful and you need to account for that state. From NW and SW this
> > > looks quite fine, because state is handled naturally. But mediator sits
> > > in a middle, so it's implementation is a bit messy.
> > > 
> > > I'll try to explain what is going on, so you it will be easier to
> > > understand logic in the mediator.
> > > 
> > > There are two types of OP-TEE calls: fast calls and standard calls. Fast
> > > call is simple: call SMC and get result. It does not allocate thread
> > > context in OP-TEE and is non-preemptive. So yes, it should be fast. It
> > > is used for simple things like "get OP-TEE version" or "exchange
> > > capabilities". It is easy to handle them in mediator: just forward
> > > the call, check result, return it back to a guest.
> > > 
> > > Standard calls are stateful. OP-TEE allocates thread for each call. This
> > > call can be preempted either by IRQ or by RPC. For consistency IRQ
> > > return is also considered as special type of RPC. So, in general one
> > > standard call can consist of series of SMCs:
> > > 
> > > --> SMC with request
> > > <-- RPC return (like IRQ)
> > > --> SMC "resume call"
> > > <-- RPC return (like "read disk")
> > > --> SMC "resume call"
> > > <-- RPC return (like "send network packet")
> > > --> SMC "resume call"
> > > ...
> > > <-- Final return
> > > 
> > > There are many types of RPCs: "handle IRQ", additional shared buffer
> > > allocation/de-allocation, RPMB access, disks access, network access,
> > > synchronization primitives (when OP-TEE thread is gets blocked on a
> > > mutex), etc.
> > > 
> > > Two more things that makes all this worse: Normal World can register
> > > shared buffer with OP-TEE. Such buffer can live indefinitely
> > > long. Also, Normal World decides when to resume call. For example,
> > > calling process can be preempted and then resumed seconds
> > > later. Misbehaving guest can decide to not resume call at all.
> > > 
> > > As I said, I tried to take all this things into account. There are
> > > basically 3 types of objects that can lead to memory allocation on Xen
> > > side:
> > > 
> > > 1. Standard call context. Besides memory space for struct optee_std_call
> > > itself it allocates page for a shadow buffer, where argument addresses
> > > are translated by Xen. Number of this objects is limited by number of
> > > OP-TEE threads:
> > > 
> > >      count = atomic_add_unless(&ctx->call_count, 1, max_optee_threads);
> > >      if ( count == max_optee_threads )
> > >          return ERR_PTR(-ENOSPC);
> > > 
> > > 2. Shared buffer. This is a buffer shared by guest with OP-TEE. It can
> > > be either temporary buffer which is shared for one standard call
> > > duration, or registered shared buffer, which is remains active until it
> > > is de-registered. This is where translate_noncontig() comes into play.
> > > Number of this buffers is limited in allocate_optee_shm_buf():
> > > 
> > >      count = atomic_add_unless(&ctx->optee_shm_buf_count, 1,
> > >                                MAX_SHM_BUFFER_COUNT);
> > >      if ( count == MAX_SHM_BUFFER_COUNT )
> > >          return ERR_PTR(-ENOMEM);
> > > 
> > > 3. Shared RPC buffer. This is very special kind of buffer. Basically,
> > > OP-TEE needs some shared memory to provide RPC call parameters. So it
> > > requests buffer from Normal World. There is no hard limit on this from
> > > mediator side, because, as I told earlier, OP-TEE itself limits number
> > > of this buffers. There is no cases when more that one buffer will be
> > > allocated per OP-TEE thread. This type of buffer is used only to process
> > > RPC requests themselves. OP-TEE can request more buffers via RPC, but
> > > they will fall to p.2: NW uses separate request to register buffer and
> > > then returns its handle in the preempted call.
> > > 
> > > 
> > > Apart from those two limits, there is a limit on total number of pages
> > > which is shared between guest and OP-TEE: MAX_TOTAL_SMH_BUF_PG. This
> > > limit is for a case when guest tries to allocate few really BIG buffers.
> > > 
> > > 
> > > > It looks like they could be called from one of the OPTEE operations that
> > > > a domU could request? Is there a limit for them?
> > > 
> > > Yes, there are limits, as I described above.
> > > 
> > > Also, bear in mind that resources available to OP-TEE are also quite
> > > limited. So, in case of some breach in mediator, OP-TEE will give up
> > > first. This of course is not an excuse to have bugs in the mediator...
> > 
> > OK, thanks for the explanation. The reasons for my questions is that if
> > the allocations are using the memory of DomU, then at worst DomU can run
> > out of memory. 
> 
> Not really. The worst outcome is still a DoS of the host because we don't
> pre-allocate memory or even check that the total allocation will not exhaust
> the memory.
> 
> The only difference is I would argue this would be a misconfiguration of the
> system.
> 
> > But if the allocations are using anonymous memory, then
> > the whole platform might run out of memory. We have issued XSAs for
> > things like that in the past.
> > 
> > This is why I am worried about this patch: if we apply it we really
> > become reliant on these limits being implemented correctly. A bug can
> > have much more severe consequences.
> 
> This is not a problem specific to OP-TEE. Any anymous allocation (xmalloc,...)
> done in Xen on behalf of the guest has, in theory, the same problem (see more
> below).
> 
> > 
> > As you are the maintainer for this code, and this code is not security
> > supported, I'll leave it up to you (also see the other email about
> > moving optee to "supported, not security supported").
> > 
> > However, maybe a different solution would be to increase max_pages for a
> > domain when optee is enabled? Maybe just by a few pages (as many as
> > needed by the optee mediator)? Because if we did that, we wouldn't risk
> > exposing DOS attack vectors for every bug in the mediator limits checks.
> I think we need to differentiate two sorts of allocation:
>   1) Memory used by Xen on behalf of the guest
>   2) Memory used by the guest itself
> 
> d->max_pages is only meant to refer to the latter (in fact, a guest can
> balloon memory up to d->max_pages). In this case, we are discussing about the
> latter and therefore I think the should be accounted differently as the memory
> is not exposed to the guest.

Yeah, I was thinking the same thing yesterday but I didn't suggest it
because we don't have a way to specify it today. I thought that rather
than using anonymous memory it would still be preferable from a security
standpoint to use d->max_pages, although I was aware of issues such as
the guest able to balloon up to d->max_pages.

BTW do you know on top of your head of other things that can cause
anonymous xmalloc (that lives longer than a single trap or hypercall) in
Xen on ARM today? I'll try to keep an eye on them.


> Today, Xen doesn't have this facility. I know this has been discussed a few
> times in the past, but AFAIK, a patch series never materialized for it.
>
>
> However, to me, this sounds more an hardening work for the whole Xen rather
> than OP-TEE itself. So I think the patch provided by Oleksandr is probably the
> best way to go for this release.

I am OK with that especially as OP-TEE is not security supported (I
recently suggested to upgrade its support status to "supported, not
security supported".)

I wrote a summary of the options at the boottom of the email.


> > The below adds a 10 pages slack.
> > 
> > 
> > diff --git a/xen/arch/arm/tee/tee.c b/xen/arch/arm/tee/tee.c
> > index 3964a8a5cd..a3105f1a9a 100644
> > --- a/xen/arch/arm/tee/tee.c
> > +++ b/xen/arch/arm/tee/tee.c
> > @@ -38,8 +38,11 @@ bool tee_handle_call(struct cpu_user_regs *regs)
> >       return cur_mediator->ops->handle_call(regs);
> >   }
> >   +#define TEE_SLACK (10)
> >   int tee_domain_init(struct domain *d, uint16_t tee_type)
> >   {
> > +    int ret;
> > +
> >       if ( tee_type == XEN_DOMCTL_CONFIG_TEE_NONE )
> >           return 0;
> >   @@ -49,7 +52,15 @@ int tee_domain_init(struct domain *d, uint16_t
> > tee_type)
> >       if ( cur_mediator->tee_type != tee_type )
> >           return -EINVAL;
> >   -    return cur_mediator->ops->domain_init(d);
> > +    ret = cur_mediator->ops->domain_init(d);
> > +    if ( ret < 0 )
> > +        return ret;
> > +
> > +    /*
> > +     * Increase maxmem for domains with TEE, the extra pages are used by
> > +     * the mediator
> > +     */
> > +    d->max_pages += TEE_SLACK;
> 
> Regardless what I wrote above, this change would be incorrect because TEE is
> initialized the when domain is created. However, d->max_pages is set
> afterwards via DOMCTL_max_mem, so the value will get overridden.
> 
> However, I don't think OP-TEE code should modify d->max_pages. Instead, this
> should be accounted by the toolstack (or domain_build for dom0/domU created by
> Xen).

Good point, and I can see that libxl has already a slack_memkb concept
for PV x86 used to increase the memmap limit.


The best solution would be to introduce a generic framework for
accounting memory that Xen allocates on behalf of the guest. But of
course we don't want to ask Oleksandr to do that now 1 week from the
release and in response to a simple 3 lines patch.

With the best option not being available, we have to pick one of the
following:

1) current patch that uses anonymous memory
2) slack but done right (the toolstack and domain_build apply the slack
   to d->max_pages)

My preference is 2) for security reasons but it is a bit more work.
Taking into account that Julien, Volodymyr, and Bertrand all think that
1) is acceptable as is, then I will not insist. Option 1) is OK.


From xen-devel-bounces@lists.xenproject.org Fri Oct 08 22:15:09 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Oct 2021 22:15:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.204909.360101 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYy8s-0005QY-Vx; Fri, 08 Oct 2021 22:15:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 204909.360101; Fri, 08 Oct 2021 22:15:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYy8s-0005QR-RU; Fri, 08 Oct 2021 22:15:02 +0000
Received: by outflank-mailman (input) for mailman id 204909;
 Fri, 08 Oct 2021 22:15:01 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=79mX=O4=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1mYy8r-0005QL-EG
 for xen-devel@lists.xenproject.org; Fri, 08 Oct 2021 22:15:01 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id f75e5403-6a11-4ba4-b2a3-706855645a70;
 Fri, 08 Oct 2021 22:15:00 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id 34A5261027;
 Fri,  8 Oct 2021 22:14:59 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f75e5403-6a11-4ba4-b2a3-706855645a70
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1633731299;
	bh=/sLiL2d0PiSIFZQ+nBDeXSn4pPoVNJHB7od1VoM6hn0=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=ajVoae3L6wVwtMZPl+PjAiRE2IwrgKHZ1+WZnv/oEjzHOcsNN9OtdV5nhXD1FOW4i
	 jQGXLuPwiwy8PyH2yojjIzgo3OoTLQNkQldlCuDGfJ+njy89d9kn4Ar3pS5PMnLOgI
	 uc1Du06bHbjKE37Y5rmHBrvdQAEUwm6YY+QWBxxftiQK/xpEN2uY3+IPfXhR8IT8zm
	 I8bVX505POjsL2sfjsv0OCIzH/FEb71y83RB/yoW/ctaaybBSk2SmCuYt0ZZlOY5a6
	 ffLX31WbQr0+m1qGYqbRSAuGGwyBq2LJ2z+fzWDcuA3+HcZLP+EfxsR6RHvEW9gncd
	 JZ8VDqwrGkWbw==
Date: Fri, 8 Oct 2021 15:14:58 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Oleksandr <olekstysh@gmail.com>
cc: Jan Beulich <jbeulich@suse.com>, 
    Stefano Stabellini <sstabellini@kernel.org>, 
    Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, 
    Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>, 
    Anthony PERARD <anthony.perard@citrix.com>, 
    Andrew Cooper <andrew.cooper3@citrix.com>, 
    George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>, 
    Juergen Gross <jgross@suse.com>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, 
    xen-devel@lists.xenproject.org
Subject: Re: [PATCH V5 1/3] xen/arm: Introduce gpaddr_bits field to struct
 xen_arch_domainconfig
In-Reply-To: <2fcb101c-28b0-67c5-0f4d-e3d75b9f4d33@gmail.com>
Message-ID: <alpine.DEB.2.21.2110081458120.25528@sstabellini-ThinkPad-T480s>
References: <1633519346-3686-1-git-send-email-olekstysh@gmail.com> <1633519346-3686-2-git-send-email-olekstysh@gmail.com> <68cb29bb-7d84-dc27-eead-4a079b9caf68@suse.com> <e77eea6f-163d-0920-2e90-fb9f3a602743@gmail.com> <ffb40f3b-2394-7747-2c06-955e2aa87cfc@suse.com>
 <387608b9-c7b2-e814-7fa5-a262acc0c73d@gmail.com> <ae852345-66ff-7bcf-f68e-2161e23933a1@suse.com> <alpine.DEB.2.21.2110071311450.414@sstabellini-ThinkPad-T480s> <b8e868a2-9af3-de6c-0683-4bb2ff7821f3@suse.com> <b36e5fb7-6ed0-dc7d-5ed3-c3c9c9ae70b5@gmail.com>
 <ff760c65-1041-aac6-40ed-981f0b900678@suse.com> <2fcb101c-28b0-67c5-0f4d-e3d75b9f4d33@gmail.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Fri, 8 Oct 2021, Oleksandr wrote:
> On 08.10.21 15:36, Jan Beulich wrote:
> > On 08.10.2021 12:25, Oleksandr wrote:
> > > Just a quick question. What do you think can XEN_DOMCTL_getdomaininfo be
> > > reused to retrieve gpaddr_bits? I don't see why not at the moment, but
> > > maybe there are some implications/concerns which are invisible to me.
> > > 
> > > I see that arch_get_domain_info() is present, so the field will be
> > > common, and each arch will write a value it considers
> > > appropriate. This could be a good compromise to not add an extra domctl
> > > and to not alter domain_create.
> > Technically I think it could be reused. What I'm less certain of is
> > whether the specific piece of information is a good fit there.
> 
> ok, thank you for your answer.
> 
> I am also not 100% sure whether it is a *good* fit there, but I cannot say it
> is not fit at all for being there. I might mistake, but it is almost the same
> piece of information describing the whole domain as other existing fields in
> that structure.

>From a domctl point of view, it looks like XEN_DOMCTL_getdomaininfo
could be a decent fit. Looking at the data structure, the arch specific
member of struct xen_domctl_getdomaininfo is:

  struct xen_arch_domainconfig arch_config;

which is actually the very same struct used in struct
xen_domctl_createdomain for XEN_DOMCTL_createdomain, but somehow it
doesn't get populated by neither the x86 nor the ARM version of
arch_get_domain_info?


In any case, I think we could make use of XEN_DOMCTL_getdomaininfo for
this. In that case, I would add a new common field to struct
xen_domctl_getdomaininfo after cpupool and above arch_config.

Then we can set the field from arch_get_domain_info.


From xen-devel-bounces@lists.xenproject.org Fri Oct 08 22:55:07 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Oct 2021 22:55:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.204918.360112 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYylP-00018M-Vt; Fri, 08 Oct 2021 22:54:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 204918.360112; Fri, 08 Oct 2021 22:54:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYylP-00018F-Rt; Fri, 08 Oct 2021 22:54:51 +0000
Received: by outflank-mailman (input) for mailman id 204918;
 Fri, 08 Oct 2021 22:54:50 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=79mX=O4=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1mYylO-000189-Jd
 for xen-devel@lists.xenproject.org; Fri, 08 Oct 2021 22:54:50 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id bd392fca-288a-11ec-8071-12813bfff9fa;
 Fri, 08 Oct 2021 22:54:49 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id B172860E9C;
 Fri,  8 Oct 2021 22:54:47 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: bd392fca-288a-11ec-8071-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1633733688;
	bh=m4RYABVMi6DigLkgfT42Ult+XqB/etQQpxM9McuUbP4=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=ThPUyYjFNepqPOlaJIshHOl43cg8RvqcgmYl29UeTlXo6QHdJd37x0gwgK0oReg0j
	 G53eCJz4xPBBV6Ln/wh20zZcm1SHaQZP0UNK816yyWSjHO0YXRuWgxXWQJ1TYTzKWM
	 3XK+DB7AEXETYwO7u13Mz6ozdoSM+H9HxSKhyu4m5pqMljfyhCLj581pyy55rp9lUE
	 YligXv9EhJYUZzjEYV3j6s73ZvoOeMUZDXxRYjQ9Dbi/qWxdKG1A/CljVEf+x2GCF/
	 V4OiMAquyXdhtlfq8rRGr34PfO27VS7hAntIH0bW7lDJIFZbQfBAskwIOOODXS83Yo
	 kGSttjBxnFOFQ==
Date: Fri, 8 Oct 2021 15:54:46 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Oleksandr Andrushchenko <andr2000@gmail.com>
cc: xen-devel@lists.xenproject.org, julien@xen.org, sstabellini@kernel.org, 
    oleksandr_tyshchenko@epam.com, volodymyr_babchuk@epam.com, 
    Artem_Mygaiev@epam.com, roger.pau@citrix.com, jbeulich@suse.com, 
    andrew.cooper3@citrix.com, george.dunlap@citrix.com, paul@xen.org, 
    bertrand.marquis@arm.com, rahul.singh@arm.com, 
    Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Subject: Re: [PATCH v5 00/10] PCI devices passthrough on Arm, part 2
In-Reply-To: <20211008055535.337436-1-andr2000@gmail.com>
Message-ID: <alpine.DEB.2.21.2110081554210.25528@sstabellini-ThinkPad-T480s>
References: <20211008055535.337436-1-andr2000@gmail.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

Hi Oleksandr,

I committed patches #1-#5


On Fri, 8 Oct 2021, Oleksandr Andrushchenko wrote:
> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> 
> Hi, all!
> 
> This is an assorted series of patches which aim is to make some further
> basis for PCI passthrough on Arm support. The series continues the work
> published earlier by Arm [1] and adds new helpers and clears the way for
> vPCI changes which will follow.
> 
> RFC is at [2], [3]. Design presentation can be found at [4].
> 
> Thank you,
> Oleksandr
> 
> [1] https://patchwork.kernel.org/project/xen-devel/list/?series=558681
> [2] https://lists.xenproject.org/archives/html/xen-devel/2020-07/msg01184.html
> [3] https://lists.xenproject.org/archives/html/xen-devel/2020-07/threads.html#01184
> [4] https://static.sched.com/hosted_files/xen2021/e4/PCI_Device_Passthrough_On_Arm.pdf
> 
> Oleksandr Andrushchenko (9):
>   xen/arm: Add new device type for PCI
>   xen/arm: Introduce pci_find_host_bridge_node helper
>   xen/device-tree: Make dt_find_node_by_phandle global
>   xen/arm: Mark device as PCI while creating one
>   libxl: Allow removing PCI devices for all types of domains
>   libxl: Only map legacy PCI IRQs if they are supported
>   xen/arm: Setup MMIO range trap handlers for hardware domain
>   xen/arm: Do not map PCI ECAM and MMIO space to Domain-0's p2m
>   xen/arm: Process pending vPCI map/unmap operations
> 
> Oleksandr Tyshchenko (1):
>   xen/domain: Call pci_release_devices() when releasing domain resources
> 
>  tools/libs/light/Makefile          |  4 ++
>  tools/libs/light/libxl_pci.c       | 15 ++++-
>  xen/arch/arm/domain.c              | 11 +++-
>  xen/arch/arm/domain_build.c        | 57 ++++++++++--------
>  xen/arch/arm/pci/ecam.c            | 14 +++++
>  xen/arch/arm/pci/pci-host-common.c | 93 ++++++++++++++++++++++++++++++
>  xen/arch/arm/pci/pci-host-zynqmp.c |  1 +
>  xen/arch/arm/pci/pci.c             | 12 ++++
>  xen/arch/arm/traps.c               | 13 +++++
>  xen/arch/arm/vpci.c                | 34 +++++++++++
>  xen/arch/arm/vpci.h                |  6 ++
>  xen/arch/x86/hvm/hvm.c             |  6 ++
>  xen/common/device_tree.c           |  2 +-
>  xen/common/ioreq.c                 |  9 ---
>  xen/drivers/passthrough/pci.c      |  2 +
>  xen/include/asm-arm/device.h       |  4 +-
>  xen/include/asm-arm/pci.h          | 30 ++++++++++
>  xen/include/asm-arm/setup.h        | 13 +++++
>  xen/include/asm-x86/pci.h          |  2 +
>  xen/include/xen/device_tree.h      |  2 +
>  20 files changed, 292 insertions(+), 38 deletions(-)
> 
> -- 
> 2.25.1
> 


From xen-devel-bounces@lists.xenproject.org Fri Oct 08 23:00:19 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Oct 2021 23:00:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.204928.360126 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYyqd-0002cU-JT; Fri, 08 Oct 2021 23:00:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 204928.360126; Fri, 08 Oct 2021 23:00:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYyqd-0002cN-G3; Fri, 08 Oct 2021 23:00:15 +0000
Received: by outflank-mailman (input) for mailman id 204928;
 Fri, 08 Oct 2021 23:00:14 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=79mX=O4=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1mYyqc-0002c3-6e
 for xen-devel@lists.xenproject.org; Fri, 08 Oct 2021 23:00:14 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 86a0750e-cf51-4649-8f48-1fa31b9450fb;
 Fri, 08 Oct 2021 23:00:12 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id E59B660FE8;
 Fri,  8 Oct 2021 23:00:10 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 86a0750e-cf51-4649-8f48-1fa31b9450fb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1633734011;
	bh=DUJFVo1rNNser7l8ubib0RbllgDLd5vi7TvWyvaSR7M=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=K3U//eadkozYVkDwGPU7HFvfp3gqqU2UKPIwnw+x1sizbyZcwzuL6yrD9WZfdQGkX
	 FM87DrpXT1kdD4/MUR6H/4xd1u+lnpKytJrEH4IgB36+ivwXDtQ6St4wMrdV3o8dv8
	 a7GwpjR6U6jhgnJlWO79wzTcR4Tji3SGo/+3glPE1xMwKunKrCWiO/knFBB3GgeIg+
	 6OqoglTZo7BtBwP3uI8uXGgyUp99oMt3yKy27tjqsjcGJtwT19TznF2DaC5tO5rUPZ
	 wNH6tUTRGIYtBwrk/Wf6GStSCarc861F+SbVPYq74NWgU6dZXV8i/7XZW+geHtLwWW
	 dczPKAqHYO7Ng==
Date: Fri, 8 Oct 2021 16:00:09 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Oleksandr Andrushchenko <andr2000@gmail.com>
cc: xen-devel@lists.xenproject.org, julien@xen.org, sstabellini@kernel.org, 
    oleksandr_tyshchenko@epam.com, volodymyr_babchuk@epam.com, 
    Artem_Mygaiev@epam.com, roger.pau@citrix.com, jbeulich@suse.com, 
    andrew.cooper3@citrix.com, george.dunlap@citrix.com, paul@xen.org, 
    bertrand.marquis@arm.com, rahul.singh@arm.com, 
    Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Subject: Re: [PATCH v5 09/10] xen/arm: Do not map PCI ECAM and MMIO space to
 Domain-0's p2m
In-Reply-To: <20211008055535.337436-10-andr2000@gmail.com>
Message-ID: <alpine.DEB.2.21.2110081600010.25528@sstabellini-ThinkPad-T480s>
References: <20211008055535.337436-1-andr2000@gmail.com> <20211008055535.337436-10-andr2000@gmail.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Fri, 8 Oct 2021, Oleksandr Andrushchenko wrote:
> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> 
> PCI host bridges are special devices in terms of implementing PCI
> passthrough. According to [1] the current implementation depends on
> Domain-0 to perform the initialization of the relevant PCI host
> bridge hardware and perform PCI device enumeration. In order to
> achieve that one of the required changes is to not map all the memory
> ranges in map_range_to_domain as we traverse the device tree on startup
> and perform some additional checks if the range needs to be mapped to
> Domain-0.
> 
> The generic PCI host controller device tree binding says [2]:
> - ranges: As described in IEEE Std 1275-1994, but must provide
>           at least a definition of non-prefetchable memory. One
>           or both of prefetchable Memory and IO Space may also
>           be provided.
> 
> - reg   : The Configuration Space base address and size, as accessed
>           from the parent bus.  The base address corresponds to
>           the first bus in the "bus-range" property.  If no
>           "bus-range" is specified, this will be bus 0 (the default).
> 
> >From the above none of the memory ranges from the "ranges" property
> needs to be mapped to Domain-0 at startup as MMIO mapping is going to
> be handled dynamically by vPCI as we assign PCI devices, e.g. each
> device assigned to Domain-0/guest will have its MMIOs mapped/unmapped
> as needed by Xen.
> 
> The "reg" property covers not only ECAM space, but may also have other
> then the configuration memory ranges described, for example [3]:
> - reg: Should contain rc_dbi, config registers location and length.
> - reg-names: Must include the following entries:
>    "rc_dbi": controller configuration registers;
>    "config": PCIe configuration space registers.
> 
> This patch makes it possible to not map all the ranges from the
> "ranges" property and also ECAM from the "reg". All the rest from the
> "reg" property still needs to be mapped to Domain-0, so the PCI
> host bridge remains functional in Domain-0.
> 
> [1] https://lists.xenproject.org/archives/html/xen-devel/2020-07/msg00777.html
> [2] https://www.kernel.org/doc/Documentation/devicetree/bindings/pci/host-generic-pci.txt
> [3] https://www.kernel.org/doc/Documentation/devicetree/bindings/pci/hisilicon-pcie.txt
> 
> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>

Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>


> ---
> Since v4:
> - update skip_mapping comment
> - add comment why we need to map interrupts to Dom0
> Since v3:
>  - pass struct map_range_data to map_dt_irq_to_domain
>  - remove redundant check from map_range_to_domain
>  - fix handle_device's .skip_mapping
> Since v2:
>  - removed check in map_range_to_domain for PCI_DEV
>    and moved it to handle_device, so the code is
>    simpler
>  - s/map_pci_bridge/skip_mapping
>  - extended comment in pci_host_bridge_mappings
>  - minor code restructure in construct_dom0
>  - s/.need_p2m_mapping/.need_p2m_hwdom_mapping and related
>    callbacks
>  - unsigned int i; in pci_host_bridge_mappings
> Since v1:
>  - Added better description of why and what needs to be mapped into
>    Domain-0's p2m and what doesn't
>  - Do not do any mappings for PCI devices while traversing the DT
>  - Walk all the bridges and make required mappings in one go
> ---
>  xen/arch/arm/domain_build.c        | 57 ++++++++++++++++++------------
>  xen/arch/arm/pci/ecam.c            | 14 ++++++++
>  xen/arch/arm/pci/pci-host-common.c | 49 +++++++++++++++++++++++++
>  xen/arch/arm/pci/pci-host-zynqmp.c |  1 +
>  xen/include/asm-arm/pci.h          | 10 ++++++
>  xen/include/asm-arm/setup.h        | 13 +++++++
>  6 files changed, 121 insertions(+), 23 deletions(-)
> 
> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
> index b51176b31bef..0d673b06a2f3 100644
> --- a/xen/arch/arm/domain_build.c
> +++ b/xen/arch/arm/domain_build.c
> @@ -10,7 +10,6 @@
>  #include <asm/regs.h>
>  #include <xen/errno.h>
>  #include <xen/err.h>
> -#include <xen/device_tree.h>
>  #include <xen/libfdt/libfdt.h>
>  #include <xen/guest_access.h>
>  #include <xen/iocap.h>
> @@ -51,12 +50,6 @@ static int __init parse_dom0_mem(const char *s)
>  }
>  custom_param("dom0_mem", parse_dom0_mem);
>  
> -struct map_range_data
> -{
> -    struct domain *d;
> -    p2m_type_t p2mt;
> -};
> -
>  /* Override macros from asm/page.h to make them work with mfn_t */
>  #undef virt_to_mfn
>  #define virt_to_mfn(va) _mfn(__virt_to_mfn(va))
> @@ -1663,10 +1656,11 @@ static int __init map_dt_irq_to_domain(const struct dt_device_node *dev,
>                                         const struct dt_irq *dt_irq,
>                                         void *data)
>  {
> -    struct domain *d = data;
> +    struct map_range_data *mr_data = data;
> +    struct domain *d = mr_data->d;
>      unsigned int irq = dt_irq->irq;
>      int res;
> -    bool need_mapping = !dt_device_for_passthrough(dev);
> +    bool need_mapping = !mr_data->skip_mapping;
>  
>      if ( irq < NR_LOCAL_IRQS )
>      {
> @@ -1690,13 +1684,12 @@ static int __init map_dt_irq_to_domain(const struct dt_device_node *dev,
>      return 0;
>  }
>  
> -static int __init map_range_to_domain(const struct dt_device_node *dev,
> -                                      u64 addr, u64 len,
> -                                      void *data)
> +int __init map_range_to_domain(const struct dt_device_node *dev,
> +                               u64 addr, u64 len, void *data)
>  {
>      struct map_range_data *mr_data = data;
>      struct domain *d = mr_data->d;
> -    bool need_mapping = !dt_device_for_passthrough(dev);
> +    bool need_mapping = !mr_data->skip_mapping;
>      int res;
>  
>      /*
> @@ -1748,23 +1741,21 @@ static int __init map_range_to_domain(const struct dt_device_node *dev,
>   * then we may need to perform additional mappings in order to make
>   * the child resources available to domain 0.
>   */
> -static int __init map_device_children(struct domain *d,
> -                                      const struct dt_device_node *dev,
> -                                      p2m_type_t p2mt)
> +static int __init map_device_children(const struct dt_device_node *dev,
> +                                      struct map_range_data *mr_data)
>  {
> -    struct map_range_data mr_data = { .d = d, .p2mt = p2mt };
> -    int ret;
> -
>      if ( dt_device_type_is_equal(dev, "pci") )
>      {
> +        int ret;
> +
>          dt_dprintk("Mapping children of %s to guest\n",
>                     dt_node_full_name(dev));
>  
> -        ret = dt_for_each_irq_map(dev, &map_dt_irq_to_domain, d);
> +        ret = dt_for_each_irq_map(dev, &map_dt_irq_to_domain, mr_data);
>          if ( ret < 0 )
>              return ret;
>  
> -        ret = dt_for_each_range(dev, &map_range_to_domain, &mr_data);
> +        ret = dt_for_each_range(dev, &map_range_to_domain, mr_data);
>          if ( ret < 0 )
>              return ret;
>      }
> @@ -1845,6 +1836,20 @@ static int __init handle_device(struct domain *d, struct dt_device_node *dev,
>      int res;
>      u64 addr, size;
>      bool need_mapping = !dt_device_for_passthrough(dev);
> +    /*
> +     * For PCI passthrough we only need to remap to Dom0 the interrupts
> +     * and memory ranges from "reg" property which cover controller's
> +     * configuration registers and such. PCIe configuration space registers
> +     * of the PCIe Root Complex and PCIe aperture should not be mapped
> +     * automatically to Dom0.
> +     */
> +    struct map_range_data mr_data = {
> +        .d = d,
> +        .p2mt = p2mt,
> +        .skip_mapping = !need_mapping ||
> +                        (is_pci_passthrough_enabled() &&
> +                         (device_get_class(dev) == DEVICE_PCI))
> +    };
>  
>      naddr = dt_number_of_address(dev);
>  
> @@ -1884,7 +1889,6 @@ static int __init handle_device(struct domain *d, struct dt_device_node *dev,
>      /* Give permission and map MMIOs */
>      for ( i = 0; i < naddr; i++ )
>      {
> -        struct map_range_data mr_data = { .d = d, .p2mt = p2mt };
>          res = dt_device_get_address(dev, i, &addr, &size);
>          if ( res )
>          {
> @@ -1898,7 +1902,7 @@ static int __init handle_device(struct domain *d, struct dt_device_node *dev,
>              return res;
>      }
>  
> -    res = map_device_children(d, dev, p2mt);
> +    res = map_device_children(dev, &mr_data);
>      if ( res )
>          return res;
>  
> @@ -3056,7 +3060,14 @@ static int __init construct_dom0(struct domain *d)
>          return rc;
>  
>      if ( acpi_disabled )
> +    {
>          rc = prepare_dtb_hwdom(d, &kinfo);
> +        if ( rc < 0 )
> +            return rc;
> +#ifdef CONFIG_HAS_PCI
> +        rc = pci_host_bridge_mappings(d, p2m_mmio_direct_c);
> +#endif
> +    }
>      else
>          rc = prepare_acpi(d, &kinfo);
>  
> diff --git a/xen/arch/arm/pci/ecam.c b/xen/arch/arm/pci/ecam.c
> index 602d00799c8d..b81620074a91 100644
> --- a/xen/arch/arm/pci/ecam.c
> +++ b/xen/arch/arm/pci/ecam.c
> @@ -40,6 +40,19 @@ void __iomem *pci_ecam_map_bus(struct pci_host_bridge *bridge,
>      return base + (PCI_DEVFN2(sbdf.bdf) << devfn_shift) + where;
>  }
>  
> +bool pci_ecam_need_p2m_hwdom_mapping(struct domain *d,
> +                                     struct pci_host_bridge *bridge,
> +                                     uint64_t addr)
> +{
> +    struct pci_config_window *cfg = bridge->cfg;
> +
> +    /*
> +     * We do not want ECAM address space to be mapped in Domain-0's p2m,
> +     * so we can trap access to it.
> +     */
> +    return cfg->phys_addr != addr;
> +}
> +
>  /* ECAM ops */
>  const struct pci_ecam_ops pci_generic_ecam_ops = {
>      .bus_shift  = 20,
> @@ -47,6 +60,7 @@ const struct pci_ecam_ops pci_generic_ecam_ops = {
>          .map_bus                = pci_ecam_map_bus,
>          .read                   = pci_generic_config_read,
>          .write                  = pci_generic_config_write,
> +        .need_p2m_hwdom_mapping = pci_ecam_need_p2m_hwdom_mapping,
>      }
>  };
>  
> diff --git a/xen/arch/arm/pci/pci-host-common.c b/xen/arch/arm/pci/pci-host-common.c
> index 1eb4daa87365..085f08e23e0c 100644
> --- a/xen/arch/arm/pci/pci-host-common.c
> +++ b/xen/arch/arm/pci/pci-host-common.c
> @@ -18,6 +18,7 @@
>  
>  #include <xen/init.h>
>  #include <xen/pci.h>
> +#include <asm/setup.h>
>  #include <xen/rwlock.h>
>  #include <xen/sched.h>
>  #include <xen/vmap.h>
> @@ -320,6 +321,54 @@ int pci_host_get_num_bridges(void)
>      return count;
>  }
>  
> +int __init pci_host_bridge_mappings(struct domain *d, p2m_type_t p2mt)
> +{
> +    struct pci_host_bridge *bridge;
> +    struct map_range_data mr_data = {
> +        .d = d,
> +        .p2mt = p2mt,
> +        .skip_mapping = false
> +    };
> +
> +    /*
> +     * For each PCI host bridge we need to only map those ranges
> +     * which are used by Domain-0 to properly initialize the bridge,
> +     * e.g. we do not want to map ECAM configuration space which lives in
> +     * "reg" or "assigned-addresses" device tree property, but we want to
> +     * map other regions of the host bridge. The PCI aperture defined by
> +     * the "ranges" device tree property should also be skipped.
> +     */
> +    list_for_each_entry( bridge, &pci_host_bridges, node )
> +    {
> +        const struct dt_device_node *dev = bridge->dt_node;
> +        unsigned int i;
> +
> +        for ( i = 0; i < dt_number_of_address(dev); i++ )
> +        {
> +            uint64_t addr, size;
> +            int err;
> +
> +            err = dt_device_get_address(dev, i, &addr, &size);
> +            if ( err )
> +            {
> +                printk(XENLOG_ERR
> +                       "Unable to retrieve address range index=%u for %s\n",
> +                       i, dt_node_full_name(dev));
> +                return err;
> +            }
> +
> +            if ( bridge->ops->need_p2m_hwdom_mapping(d, bridge, addr) )
> +            {
> +                err = map_range_to_domain(dev, addr, size, &mr_data);
> +                if ( err )
> +                    return err;
> +            }
> +        }
> +    }
> +
> +    return 0;
> +}
> +
>  /*
>   * Local variables:
>   * mode: C
> diff --git a/xen/arch/arm/pci/pci-host-zynqmp.c b/xen/arch/arm/pci/pci-host-zynqmp.c
> index 61a9807d3d58..6ad2b31e810d 100644
> --- a/xen/arch/arm/pci/pci-host-zynqmp.c
> +++ b/xen/arch/arm/pci/pci-host-zynqmp.c
> @@ -34,6 +34,7 @@ const struct pci_ecam_ops nwl_pcie_ops = {
>          .map_bus                = pci_ecam_map_bus,
>          .read                   = pci_generic_config_read,
>          .write                  = pci_generic_config_write,
> +        .need_p2m_hwdom_mapping = pci_ecam_need_p2m_hwdom_mapping,
>      }
>  };
>  
> diff --git a/xen/include/asm-arm/pci.h b/xen/include/asm-arm/pci.h
> index a71b0eea8cb9..b5b85ccd0937 100644
> --- a/xen/include/asm-arm/pci.h
> +++ b/xen/include/asm-arm/pci.h
> @@ -17,6 +17,8 @@
>  
>  #ifdef CONFIG_HAS_PCI
>  
> +#include <asm/p2m.h>
> +
>  #define pci_to_dev(pcidev) (&(pcidev)->arch.dev)
>  
>  extern bool pci_passthrough_enabled;
> @@ -73,6 +75,9 @@ struct pci_ops {
>                  uint32_t reg, uint32_t len, uint32_t *value);
>      int (*write)(struct pci_host_bridge *bridge, pci_sbdf_t sbdf,
>                   uint32_t reg, uint32_t len, uint32_t value);
> +    bool (*need_p2m_hwdom_mapping)(struct domain *d,
> +                                   struct pci_host_bridge *bridge,
> +                                   uint64_t addr);
>  };
>  
>  /*
> @@ -96,6 +101,9 @@ int pci_generic_config_write(struct pci_host_bridge *bridge, pci_sbdf_t sbdf,
>                               uint32_t reg, uint32_t len, uint32_t value);
>  void __iomem *pci_ecam_map_bus(struct pci_host_bridge *bridge,
>                                 pci_sbdf_t sbdf, uint32_t where);
> +bool pci_ecam_need_p2m_hwdom_mapping(struct domain *d,
> +                                     struct pci_host_bridge *bridge,
> +                                     uint64_t addr);
>  struct pci_host_bridge *pci_find_host_bridge(uint16_t segment, uint8_t bus);
>  int pci_get_host_bridge_segment(const struct dt_device_node *node,
>                                  uint16_t *segment);
> @@ -113,6 +121,8 @@ int pci_host_iterate_bridges(struct domain *d,
>                                          struct pci_host_bridge *bridge));
>  int pci_host_get_num_bridges(void);
>  
> +int pci_host_bridge_mappings(struct domain *d, p2m_type_t p2mt);
> +
>  #else   /*!CONFIG_HAS_PCI*/
>  
>  struct arch_pci_dev { };
> diff --git a/xen/include/asm-arm/setup.h b/xen/include/asm-arm/setup.h
> index 95da0b7ab9cd..88d9673db817 100644
> --- a/xen/include/asm-arm/setup.h
> +++ b/xen/include/asm-arm/setup.h
> @@ -2,6 +2,8 @@
>  #define __ARM_SETUP_H_
>  
>  #include <public/version.h>
> +#include <asm/p2m.h>
> +#include <xen/device_tree.h>
>  
>  #define MIN_FDT_ALIGN 8
>  #define MAX_FDT_SIZE SZ_2M
> @@ -77,6 +79,14 @@ struct bootinfo {
>  #endif
>  };
>  
> +struct map_range_data
> +{
> +    struct domain *d;
> +    p2m_type_t p2mt;
> +    /* Set if mapping of the memory ranges must be skipped. */
> +    bool skip_mapping;
> +};
> +
>  extern struct bootinfo bootinfo;
>  
>  extern domid_t max_init_domid;
> @@ -124,6 +134,9 @@ void device_tree_get_reg(const __be32 **cell, u32 address_cells,
>  u32 device_tree_get_u32(const void *fdt, int node,
>                          const char *prop_name, u32 dflt);
>  
> +int map_range_to_domain(const struct dt_device_node *dev,
> +                        u64 addr, u64 len, void *data);
> +
>  #endif
>  /*
>   * Local variables:
> -- 
> 2.25.1
> 


From xen-devel-bounces@lists.xenproject.org Fri Oct 08 23:46:12 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 08 Oct 2021 23:46:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.204953.360194 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYzYz-0007Td-O3; Fri, 08 Oct 2021 23:46:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 204953.360194; Fri, 08 Oct 2021 23:46:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYzYz-0007TW-L0; Fri, 08 Oct 2021 23:46:05 +0000
Received: by outflank-mailman (input) for mailman id 204953;
 Fri, 08 Oct 2021 23:46:04 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mYzYy-0007TM-Om; Fri, 08 Oct 2021 23:46:04 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mYzYy-0006pF-FT; Fri, 08 Oct 2021 23:46:04 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mYzYy-0005LP-5a; Fri, 08 Oct 2021 23:46:04 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mYzYy-0007rS-4p; Fri, 08 Oct 2021 23:46:04 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=Z6H3iTS/j8cXy4MDDtXrb2KEXb1LOWm2+f81tJ7/lTY=; b=6bxmG/fsxaJx6FGgF8gTc+CIYk
	G7sn5vLoWKUCXIimG7DlYGAhPF0aQSHdfttobB7GE8TC1NmSYR9uoSQbozdkJjheQkMNuycyXxMG9
	337eVD4/wDr1hOgQ3fFY8Xa3ldfd90/XcXQx/VVDwN/E0IsAZwYA69kXKxfQzPVZj/z4=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165428-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 165428: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-examine:memdisk-try-append:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=1d345539c0e3654025fc00187bf633fda6ea9a43
X-Osstest-Versions-That:
    xen=192aaf7e146c0b41dbdd35ccdb13eb33ced13633
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 08 Oct 2021 23:46:04 +0000

flight 165428 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165428/

Failures :-/ but no regressions.

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds    18 guest-start/debian.repeat fail REGR. vs. 165408

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 165408
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 165408
 test-amd64-amd64-examine      4 memdisk-try-append           fail  like 165408
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165408
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165408
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 165408
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 165408
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 165408
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 165408
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 165408
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 165408
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165408
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 165408
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  1d345539c0e3654025fc00187bf633fda6ea9a43
baseline version:
 xen                  192aaf7e146c0b41dbdd35ccdb13eb33ced13633

Last test of basis   165408  2021-10-07 08:12:48 Z    1 days
Testing same since   165428  2021-10-08 09:39:52 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Anthony PERARD <anthony.perard@citrix.com>
  Bob Eshleman <bobbyeshleman@gmail.com>
  Christian Lindig <christian.lindig@citrix.com>
  Connor Davis <connojdavis@gmail.com>
  Jan Beulich <jbeulich@suse.com>
  Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
  Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
  Rahul Singh <rahul.singh@arm.com>
  Stefano Stabellini <stefano.stabellini@xilinx.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   192aaf7e14..1d345539c0  1d345539c0e3654025fc00187bf633fda6ea9a43 -> master


From xen-devel-bounces@lists.xenproject.org Sat Oct 09 00:03:27 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 09 Oct 2021 00:03:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.204965.360208 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYzpZ-000237-Km; Sat, 09 Oct 2021 00:03:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 204965.360208; Sat, 09 Oct 2021 00:03:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mYzpZ-000230-Hj; Sat, 09 Oct 2021 00:03:13 +0000
Received: by outflank-mailman (input) for mailman id 204965;
 Sat, 09 Oct 2021 00:03:11 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=NfYO=O5=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1mYzpX-00022u-Pt
 for xen-devel@lists.xenproject.org; Sat, 09 Oct 2021 00:03:11 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 8f56bd54-63c0-4b2e-809b-a8705587b6cb;
 Sat, 09 Oct 2021 00:03:10 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id CB27E60FC2;
 Sat,  9 Oct 2021 00:03:09 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8f56bd54-63c0-4b2e-809b-a8705587b6cb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1633737790;
	bh=0r7TxkdS9pZnNOTmdNrs3ItUAzcmcS6xCpClx0nYc9E=;
	h=Date:From:To:cc:Subject:From;
	b=uV+FpWwICafnXZ6aa7hUnbfSZGAK0hOGPORkZ72hnjusofAh+pvX5V15cWq4E6jmP
	 nDKd0HDCINDoTJpGHmLJJMkZdfh+jGV95CE9Hdixdh2+vjhMZnTDPfC4RkK0jB6Cg0
	 oxBxdxiyl2a8RxxoydEEjPJRZ46oDCGz5hrVOF/kpR0nP2lU6vhjsJ0PujxFFb3H4w
	 NpaVbGwuzkMbh65aAEUKg6tP3qTCpo1/H8VHtclf9uYZxgj8DqHz09Og0KmDRnVR/o
	 8BfI/VXcMoRkUuP2cA2WN9qFJ7aMWA3Y+/EuDXDpfAaTwUsrO/qtvNsGk7WsbDifP2
	 IM6mirdRUhKcg==
Date: Fri, 8 Oct 2021 17:03:08 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: wl@xen.org, jgross@suse.com, iwj@xenproject.org, anthony.perard@citrix.com
cc: sstabellini@kernel.org, Rahul.Singh@arm.com, Bertrand.Marquis@arm.com, 
    xen-devel@lists.xenproject.org, michal.orzel@arm.com, 
    Oleksandr Andrushchenko <andr2000@gmail.com>, roger.pau@citrix.com, 
    Oleksandr Tyshchenko <olekstysh@gmail.com>
Subject: ARM series with tools patches for 4.16
Message-ID: <alpine.DEB.2.21.2110081605340.25528@sstabellini-ThinkPad-T480s>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

Hi tools and libxl Maintainers,

I am writing this email as a summary of the outstanding ARM series
targeting 4.16 that we are aiming to complete by Oct 15.

There has been a lot of traffic on the mailing list and in a few
occasions there has been 1 or 2 tools patches embedded in larger ARM
series. Easy to miss. For your convenience and help with tracking I
thought it would be useful to list the tools and libxl patches from the
various series that currently need an ack.

Cheers,

Stefano
P.S.
There are more ARM series targeting 4.16 but without tools dependencies
so I didn't list them here (NUMA, Dom0less EFI, PCI Passthrough part 3
which needs vpci reviews.)


- PCI devices passthrough on Arm by Rahul
  https://marc.info/?l=xen-devel&m=163354201102377
  Status:
      - patch #1   missing a tools ack
      - patch #10  missing a libxl ack
      - patch #9   missing a vpci (Roger) ack
      - other patches no action needed from tools (either already
        committed, acked, or almost there)

- PCI devices passthrough on Arm, part 2 by OleksandrA
  https://marc.info/?l=xen-devel&m=163367250003118
  Status:
      - patch #6, #7  missing a libxl ack
      - other patches no action needed from tools (either already
        committed, acked, or almost there)

- Add handling of extended regions (safe ranges) on Arm by OleksandrT
  https://marc.info/?l=xen-devel&m=163351932517019
  Status:
      - patch #1  missing a libxl ack (but also xen side not finished)
      - patch #2  missing a libxl ack (Ian is aware)
      - patch #3  no action needed from tools (committed)

- Expose PMU to the guests by Michal
  https://marc.info/?l=xen-devel&m=163368116008406
  Status:
      - patch #1, #3  missing a tools and libxl ack
      - patch #2      no action needed from tools (acked)


From xen-devel-bounces@lists.xenproject.org Sat Oct 09 00:16:23 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 09 Oct 2021 00:16:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.204976.360219 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZ02E-0003aQ-T5; Sat, 09 Oct 2021 00:16:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 204976.360219; Sat, 09 Oct 2021 00:16:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZ02E-0003aJ-QF; Sat, 09 Oct 2021 00:16:18 +0000
Received: by outflank-mailman (input) for mailman id 204976;
 Sat, 09 Oct 2021 00:16:17 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=VUea=O5=gmail.com=rosbrookn@srs-us1.protection.inumbo.net>)
 id 1mZ02D-0003aD-KW
 for xen-devel@lists.xenproject.org; Sat, 09 Oct 2021 00:16:17 +0000
Received: from mail-qt1-x82c.google.com (unknown [2607:f8b0:4864:20::82c])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 35faf5f8-ffe1-4d34-87ed-7e88d1e9d591;
 Sat, 09 Oct 2021 00:16:16 +0000 (UTC)
Received: by mail-qt1-x82c.google.com with SMTP id d8so11160596qtd.5
 for <xen-devel@lists.xenproject.org>; Fri, 08 Oct 2021 17:16:16 -0700 (PDT)
Received: from six (c-73-89-138-5.hsd1.vt.comcast.net. [73.89.138.5])
 by smtp.gmail.com with ESMTPSA id x9sm616585qtw.84.2021.10.08.17.16.14
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Fri, 08 Oct 2021 17:16:15 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 35faf5f8-ffe1-4d34-87ed-7e88d1e9d591
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=date:from:to:cc:subject:message-id:references:mime-version
         :content-disposition:in-reply-to;
        bh=TB0XrSz76GmDWduFUHCz3rCT4aQ7mpDasapPcaUx0FI=;
        b=OCqy4W5bfczTToz4MdzD2Uq3k+KQSw64mk+8vTverDVEYIjCP9y+4XC+LJcUi6sNXy
         KlGNlVpoYg+lmnRdTRDzy2dWA1UMC1IATqGJj/4c4p6MkUxJfm3+O5cPHrcGX8YMw67I
         tHWsLZZUyMq3vIPKm02uWD0sqkvZzXEbS21bi60qspv7TL6Hm7wOMmlC3aDDiKATvg7x
         yg3TjbKaVUP3wRKJholoPNoMn09qLWVYYy/e0ArdIXW3DuZh1A7CAcr1qo1E0sruTsd9
         qKNU3ord0jqPeRabFdKGxhFUhZTk00LQ4ATkl4Jad4anBIqk9+mJm0LrjBtS2TgAuGLK
         sLaQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:date:from:to:cc:subject:message-id:references
         :mime-version:content-disposition:in-reply-to;
        bh=TB0XrSz76GmDWduFUHCz3rCT4aQ7mpDasapPcaUx0FI=;
        b=FcsP1T7SQfIspktRghva/vpST3b/b3P8J+ALMxTEwWoOPUL9kEL1eUwfLR7ZMK8A46
         134IH9r1O2WQ3By2gIbNdBBTF0YVG4R1tAiCL/x/HyI46KmmYolAlrdjg2LsgFWsuoE1
         CSOYLXau8P1brdMAjniAB7mzd3VdU4fhkVemAXI8SXBXwyQfCeEx0lKxUgwxgUCi2mYX
         pfeXfUgioqpy3suPlPTBJnoVQii9TiUrM8T8wW5z6vCIw8HiZi3+22hSnwPzlq4ebpUK
         xrhmGXCG4GY0IeX2+TNHfxQa1wwAx10lXw8F+Es+29TbHuYkldN6edT9PZrqYm+gpS98
         MKOw==
X-Gm-Message-State: AOAM533ceEvOTxtwkKm1iDxN8ybW86LymAiPfCNwSb9YacN1UgvLoRLi
	U+v60XcRWPzsa6GE1QU2jVo=
X-Google-Smtp-Source: ABdhPJz6oBta4l6qb4nYeWa7ZDpw78/JU6AweBYPgpKkcDUZY1blikCJ5TW7ZOGjBtM6f232JA/usA==
X-Received: by 2002:ac8:570e:: with SMTP id 14mr1446616qtw.65.1633738575845;
        Fri, 08 Oct 2021 17:16:15 -0700 (PDT)
Date: Fri, 8 Oct 2021 20:16:12 -0400
From: Nick Rosbrook <rosbrookn@gmail.com>
To: Michal Orzel <michal.orzel@arm.com>
Cc: xen-devel@lists.xenproject.org,
	George Dunlap <george.dunlap@citrix.com>,
	Nick Rosbrook <rosbrookn@ainfosec.com>,
	Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Jan Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Anthony PERARD <anthony.perard@citrix.com>,
	Juergen Gross <jgross@suse.com>,
	Christian Lindig <christian.lindig@citrix.com>,
	David Scott <dave@recoil.org>
Subject: Re: [PATCH v3 1/3] xen+tools: Introduce XEN_SYSCTL_PHYSCAP_vpmu
Message-ID: <20211009001612.GA241019@six>
References: <20211008081933.18546-1-michal.orzel@arm.com>
 <20211008081933.18546-2-michal.orzel@arm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211008081933.18546-2-michal.orzel@arm.com>

On Fri, Oct 08, 2021 at 10:19:31AM +0200, Michal Orzel wrote:
> Introduce flag XEN_SYSCTL_PHYSCAP_vpmu which
> indicates whether the platform supports vPMU
> functionality. Modify Xen and tools accordingly.
> 
> Take the opportunity and fix XEN_SYSCTL_PHYSCAP_vmtrace
> definition in sysctl.h which wrongly use (1<<6)
> instead of (1u<<6).
> 
> Signed-off-by: Michal Orzel <michal.orzel@arm.com>
> ---
> Changes since v2:
> -do not define bit position and mask separately
> Changes since v1:
> -new in v2
> ---
>  tools/golang/xenlight/helpers.gen.go | 2 ++
>  tools/golang/xenlight/types.gen.go   | 1 +
>  tools/include/libxl.h                | 6 ++++++
>  tools/libs/light/libxl.c             | 1 +
>  tools/libs/light/libxl_types.idl     | 1 +
>  tools/ocaml/libs/xc/xenctrl.ml       | 1 +
>  tools/ocaml/libs/xc/xenctrl.mli      | 1 +
>  tools/xl/xl_info.c                   | 5 +++--
>  xen/common/domain.c                  | 2 ++
>  xen/common/sysctl.c                  | 3 +++
>  xen/include/public/sysctl.h          | 6 ++++--
>  xen/include/xen/domain.h             | 2 ++
>  12 files changed, 27 insertions(+), 4 deletions(-)
> 
> diff --git a/tools/golang/xenlight/helpers.gen.go b/tools/golang/xenlight/helpers.gen.go
> index bfc1e7f312..c8669837d8 100644
> --- a/tools/golang/xenlight/helpers.gen.go
> +++ b/tools/golang/xenlight/helpers.gen.go
> @@ -3360,6 +3360,7 @@ x.CapHap = bool(xc.cap_hap)
>  x.CapShadow = bool(xc.cap_shadow)
>  x.CapIommuHapPtShare = bool(xc.cap_iommu_hap_pt_share)
>  x.CapVmtrace = bool(xc.cap_vmtrace)
> +x.CapVpmu = bool(xc.cap_vpmu)
>  
>   return nil}
>  
> @@ -3391,6 +3392,7 @@ xc.cap_hap = C.bool(x.CapHap)
>  xc.cap_shadow = C.bool(x.CapShadow)
>  xc.cap_iommu_hap_pt_share = C.bool(x.CapIommuHapPtShare)
>  xc.cap_vmtrace = C.bool(x.CapVmtrace)
> +xc.cap_vpmu = C.bool(x.CapVpmu)
>  
>   return nil
>   }
> diff --git a/tools/golang/xenlight/types.gen.go b/tools/golang/xenlight/types.gen.go
> index 09a3bb67e2..45f2cba3d2 100644
> --- a/tools/golang/xenlight/types.gen.go
> +++ b/tools/golang/xenlight/types.gen.go
> @@ -1008,6 +1008,7 @@ CapHap bool
>  CapShadow bool
>  CapIommuHapPtShare bool
>  CapVmtrace bool
> +CapVpmu bool
>  }

For the golang re-gen,

Acked-by: Nick Rosbrook <rosbrookn@ainfosec.com>

Thanks,
NR


From xen-devel-bounces@lists.xenproject.org Sat Oct 09 00:18:01 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 09 Oct 2021 00:18:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.204984.360230 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZ03t-0004Dp-9G; Sat, 09 Oct 2021 00:18:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 204984.360230; Sat, 09 Oct 2021 00:18:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZ03t-0004Di-4w; Sat, 09 Oct 2021 00:18:01 +0000
Received: by outflank-mailman (input) for mailman id 204984;
 Sat, 09 Oct 2021 00:18:00 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=VUea=O5=gmail.com=rosbrookn@srs-us1.protection.inumbo.net>)
 id 1mZ03s-0004Da-Dg
 for xen-devel@lists.xenproject.org; Sat, 09 Oct 2021 00:18:00 +0000
Received: from mail-qk1-x732.google.com (unknown [2607:f8b0:4864:20::732])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id ea5095e5-1fe0-46d6-9361-b3bc96a81ea2;
 Sat, 09 Oct 2021 00:17:59 +0000 (UTC)
Received: by mail-qk1-x732.google.com with SMTP id g21so11166535qki.11
 for <xen-devel@lists.xenproject.org>; Fri, 08 Oct 2021 17:17:59 -0700 (PDT)
Received: from six (c-73-89-138-5.hsd1.vt.comcast.net. [73.89.138.5])
 by smtp.gmail.com with ESMTPSA id w1sm590078qtv.71.2021.10.08.17.17.58
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Fri, 08 Oct 2021 17:17:58 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ea5095e5-1fe0-46d6-9361-b3bc96a81ea2
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=date:from:to:cc:subject:message-id:references:mime-version
         :content-disposition:in-reply-to;
        bh=/SbXNvitl5VQKOS6dtzeYuzLMwtRWMHw1EBaq4nNZhA=;
        b=qOTLNvQFQuemwRFMboCTjZN7am5fKGiBcPLCwH0k/ET+ghb7c0xtiJKOkddNqGoYdB
         n9n4TWEA+c+LiVeFhfU6J3TGJCiMXoXEQio5LCg0NCVLnBm+uZxpYih1rPWnzAGrKYY5
         rrBztR0cjgJXIXlhAt9zJHS08ZcAjZ8zf1UxyIK2tkqyBzJKgUY55z7Bc2or9jITjpAn
         l6EdXaHao9OFG6DoJYqhftovWZrPxMcxbTjPlp2V0PjB00kJhqoe3KZsfl8ylDd9RAr6
         3qmdrpZ99gGcLeQ7PS3IwFnxbFhm7NIh7hxRyLnEY1XUfdrFjyvhb302ilbhyvSuap0a
         LwNA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:date:from:to:cc:subject:message-id:references
         :mime-version:content-disposition:in-reply-to;
        bh=/SbXNvitl5VQKOS6dtzeYuzLMwtRWMHw1EBaq4nNZhA=;
        b=cXA26IuxhDR4h6OZ2TZTcoJ7sp8sn8K5Btmy65xZt7J3Qdesm9t/bVPUtn/DAycT5y
         0nKrTxNJtop+ZW7ViN3ZFo1BS264Kxih9+BN3plLYHAaekXQtZEs0RdEqXYJhuWxbi7N
         RK5oi1NITeKkzJweapjI77WYzEkqGHT+Onny+teeSJ3/oF0K995flRb6Z5qQe/Poy86E
         auGDiLC8er6ZWOIAX++3K58fmj/WBeYoMbkXOSPnSyuzOaFFVThQ6da4acl944//1AkQ
         XwRjfebJQ3bW7o5WlsTCkB7yAwqVQWGTCTeez4c8d9fb6Q222EJzit7KEfYq2f2llAWe
         Y32A==
X-Gm-Message-State: AOAM531gniD0cpwZfK0R8fcSliFyPBW7SGeyGaGXB84pYgXRG0Y7R1vC
	xX1pauS6L+sv4KrMTa/X1Ok=
X-Google-Smtp-Source: ABdhPJxQfVwLSxd4kwKx4o1go8fhDAAguM4KkaJEAPb6/w497lHWkGPqcmF7RcbJks0tyEQ7gbqzBA==
X-Received: by 2002:a37:8a82:: with SMTP id m124mr5542650qkd.406.1633738679271;
        Fri, 08 Oct 2021 17:17:59 -0700 (PDT)
Date: Fri, 8 Oct 2021 20:17:56 -0400
From: Nick Rosbrook <rosbrookn@gmail.com>
To: Michal Orzel <michal.orzel@arm.com>
Cc: xen-devel@lists.xenproject.org, Ian Jackson <iwj@xenproject.org>,
	Wei Liu <wl@xen.org>, Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Nick Rosbrook <rosbrookn@ainfosec.com>,
	Anthony PERARD <anthony.perard@citrix.com>,
	Juergen Gross <jgross@suse.com>,
	Christian Lindig <christian.lindig@citrix.com>,
	David Scott <dave@recoil.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH v3 3/3] xen: Expose the PMU to the guests
Message-ID: <20211009001756.GB241019@six>
References: <20211008081933.18546-1-michal.orzel@arm.com>
 <20211008081933.18546-4-michal.orzel@arm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211008081933.18546-4-michal.orzel@arm.com>

On Fri, Oct 08, 2021 at 10:19:33AM +0200, Michal Orzel wrote:
> Add parameter vpmu to xl domain configuration syntax
> to enable the access to PMU registers by disabling
> the PMU traps(currently only for ARM).
> 
> The current status is that the PMU registers are not
> virtualized and the physical registers are directly
> accessible when this parameter is enabled. There is no
> interrupt support and Xen will not save/restore the
> register values on context switches.
> 
> Please note that this feature is experimental.
> 
> Signed-off-by: Michal Orzel <michal.orzel@arm.com>
> Signed-off-by: Julien Grall <julien@xen.org>
> ---
> Changes since v2:
> -remove redundant check from x86 code
> -do not define bit position and mask separately
> Changes since v1:
> -modify vpmu parameter to be common rather than arch specific
> ---
>  docs/man/xl.cfg.5.pod.in             | 17 +++++++++++++++++
>  tools/golang/xenlight/helpers.gen.go |  6 ++++++
>  tools/golang/xenlight/types.gen.go   |  1 +
>  tools/include/libxl.h                |  6 ++++++
>  tools/libs/light/libxl_create.c      |  4 ++++
>  tools/libs/light/libxl_types.idl     |  2 ++
>  tools/ocaml/libs/xc/xenctrl.ml       |  1 +
>  tools/ocaml/libs/xc/xenctrl.mli      |  1 +
>  tools/xl/xl_parse.c                  |  2 ++
>  xen/arch/arm/domain.c                | 10 ++++++++--
>  xen/arch/arm/setup.c                 |  1 +
>  xen/common/domain.c                  |  9 ++++++++-
>  xen/include/asm-arm/domain.h         |  1 +
>  xen/include/public/domctl.h          |  4 +++-
>  14 files changed, 61 insertions(+), 4 deletions(-)
> 
> diff --git a/docs/man/xl.cfg.5.pod.in b/docs/man/xl.cfg.5.pod.in
> index 4b1e3028d2..55c4881205 100644
> --- a/docs/man/xl.cfg.5.pod.in
> +++ b/docs/man/xl.cfg.5.pod.in
> @@ -690,6 +690,23 @@ default.
>  B<NOTE>: Acceptable values are platform specific.  For Intel Processor
>  Trace, this value must be a power of 2 between 4k and 16M.
>  
> +=item B<vpmu=BOOLEAN>
> +
> +Currently ARM only.
> +
> +Specifies whether to enable the access to PMU registers by disabling
> +the PMU traps.
> +
> +The PMU registers are not virtualized and the physical registers are directly
> +accessible when this parameter is enabled. There is no interrupt support and
> +Xen will not save/restore the register values on context switches.
> +
> +vPMU, by design and purpose, exposes system level performance
> +information to the guest. Only to be used by sufficiently privileged
> +domains. This feature is currently in experimental state.
> +
> +If this option is not specified then it will default to B<false>.
> +
>  =back
>  
>  =head2 Devices
> diff --git a/tools/golang/xenlight/helpers.gen.go b/tools/golang/xenlight/helpers.gen.go
> index c8669837d8..2449580bad 100644
> --- a/tools/golang/xenlight/helpers.gen.go
> +++ b/tools/golang/xenlight/helpers.gen.go
> @@ -1119,6 +1119,9 @@ return fmt.Errorf("converting field ArchX86.MsrRelaxed: %v", err)
>  }
>  x.Altp2M = Altp2MMode(xc.altp2m)
>  x.VmtraceBufKb = int(xc.vmtrace_buf_kb)
> +if err := x.Vpmu.fromC(&xc.vpmu);err != nil {
> +return fmt.Errorf("converting field Vpmu: %v", err)
> +}
>  
>   return nil}
>  
> @@ -1600,6 +1603,9 @@ return fmt.Errorf("converting field ArchX86.MsrRelaxed: %v", err)
>  }
>  xc.altp2m = C.libxl_altp2m_mode(x.Altp2M)
>  xc.vmtrace_buf_kb = C.int(x.VmtraceBufKb)
> +if err := x.Vpmu.toC(&xc.vpmu); err != nil {
> +return fmt.Errorf("converting field Vpmu: %v", err)
> +}
>  
>   return nil
>   }
> diff --git a/tools/golang/xenlight/types.gen.go b/tools/golang/xenlight/types.gen.go
> index 45f2cba3d2..b2e8bd1a85 100644
> --- a/tools/golang/xenlight/types.gen.go
> +++ b/tools/golang/xenlight/types.gen.go
> @@ -521,6 +521,7 @@ MsrRelaxed Defbool
>  }
>  Altp2M Altp2MMode
>  VmtraceBufKb int
> +Vpmu Defbool
>  }
>  
>  type DomainBuildInfoTypeUnion interface {

For the golang re-gen,

Acked-by: Nick Rosbrook <rosbrookn@ainfosec.com>

Thanks,
NR


From xen-devel-bounces@lists.xenproject.org Sat Oct 09 00:37:39 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 09 Oct 2021 00:37:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.204995.360252 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZ0Mo-0006u4-8I; Sat, 09 Oct 2021 00:37:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 204995.360252; Sat, 09 Oct 2021 00:37:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZ0Mo-0006ts-5I; Sat, 09 Oct 2021 00:37:34 +0000
Received: by outflank-mailman (input) for mailman id 204995;
 Sat, 09 Oct 2021 00:37:33 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=NfYO=O5=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1mZ0Mn-0006ta-Ax
 for xen-devel@lists.xenproject.org; Sat, 09 Oct 2021 00:37:33 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 6a9c8d8e-a434-43fc-8bd4-0f5ffacd81e7;
 Sat, 09 Oct 2021 00:37:32 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id 33A9A60C4B;
 Sat,  9 Oct 2021 00:37:31 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6a9c8d8e-a434-43fc-8bd4-0f5ffacd81e7
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1633739851;
	bh=HQLf1cKJnHQZqhOjtkFphnS/bj1Ya5U31p3mtLc2WA8=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=GV5bQtCVGM003TzyGC42l4rSj1vA4FVhcec3JwnVPIqd0IDTfb6/YSTswZe1M3f3i
	 gqpL6xK4Fhw2iONoWEzNUlkqNW9lBcuOzXsUZbKJHKqmN4eXoT2IRHvRXtDfvmuwDu
	 2IzzEQ2IigZGyfLBke7g2hs54Z11+jJf2R9SA5y1sesqjp/7gyNHKFLo15nT9Zs3gY
	 L/U9FpZkjEeFr88f507IYACaz5VwKvJYylk0v4D5imc4HpR1ovbVo7JVIfh5bWFMQG
	 ZF4h0jlkGb+omL+1FqdzNgoW4nCOiOO5YEfpbK7oObwV61cKXN2JjHR0HGDvYowtz1
	 R5yQVCS0nukgQ==
Date: Fri, 8 Oct 2021 17:37:30 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Michal Orzel <michal.orzel@arm.com>
cc: xen-devel@lists.xenproject.org, George Dunlap <george.dunlap@citrix.com>, 
    Nick Rosbrook <rosbrookn@ainfosec.com>, Ian Jackson <iwj@xenproject.org>, 
    Wei Liu <wl@xen.org>, Andrew Cooper <andrew.cooper3@citrix.com>, 
    Jan Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>, 
    Stefano Stabellini <sstabellini@kernel.org>, 
    Anthony PERARD <anthony.perard@citrix.com>, 
    Juergen Gross <jgross@suse.com>, 
    Christian Lindig <christian.lindig@citrix.com>, 
    David Scott <dave@recoil.org>
Subject: Re: [PATCH v3 1/3] xen+tools: Introduce XEN_SYSCTL_PHYSCAP_vpmu
In-Reply-To: <20211008081933.18546-2-michal.orzel@arm.com>
Message-ID: <alpine.DEB.2.21.2110081724400.25528@sstabellini-ThinkPad-T480s>
References: <20211008081933.18546-1-michal.orzel@arm.com> <20211008081933.18546-2-michal.orzel@arm.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Fri, 8 Oct 2021, Michal Orzel wrote:
> Introduce flag XEN_SYSCTL_PHYSCAP_vpmu which
> indicates whether the platform supports vPMU
> functionality. Modify Xen and tools accordingly.
> 
> Take the opportunity and fix XEN_SYSCTL_PHYSCAP_vmtrace
> definition in sysctl.h which wrongly use (1<<6)
> instead of (1u<<6).
> 
> Signed-off-by: Michal Orzel <michal.orzel@arm.com>

Aside from the minor style issue Jan pointed out:

Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>


> ---
> Changes since v2:
> -do not define bit position and mask separately
> Changes since v1:
> -new in v2
> ---
>  tools/golang/xenlight/helpers.gen.go | 2 ++
>  tools/golang/xenlight/types.gen.go   | 1 +
>  tools/include/libxl.h                | 6 ++++++
>  tools/libs/light/libxl.c             | 1 +
>  tools/libs/light/libxl_types.idl     | 1 +
>  tools/ocaml/libs/xc/xenctrl.ml       | 1 +
>  tools/ocaml/libs/xc/xenctrl.mli      | 1 +
>  tools/xl/xl_info.c                   | 5 +++--
>  xen/common/domain.c                  | 2 ++
>  xen/common/sysctl.c                  | 3 +++
>  xen/include/public/sysctl.h          | 6 ++++--
>  xen/include/xen/domain.h             | 2 ++
>  12 files changed, 27 insertions(+), 4 deletions(-)
> 
> diff --git a/tools/golang/xenlight/helpers.gen.go b/tools/golang/xenlight/helpers.gen.go
> index bfc1e7f312..c8669837d8 100644
> --- a/tools/golang/xenlight/helpers.gen.go
> +++ b/tools/golang/xenlight/helpers.gen.go
> @@ -3360,6 +3360,7 @@ x.CapHap = bool(xc.cap_hap)
>  x.CapShadow = bool(xc.cap_shadow)
>  x.CapIommuHapPtShare = bool(xc.cap_iommu_hap_pt_share)
>  x.CapVmtrace = bool(xc.cap_vmtrace)
> +x.CapVpmu = bool(xc.cap_vpmu)
>  
>   return nil}
>  
> @@ -3391,6 +3392,7 @@ xc.cap_hap = C.bool(x.CapHap)
>  xc.cap_shadow = C.bool(x.CapShadow)
>  xc.cap_iommu_hap_pt_share = C.bool(x.CapIommuHapPtShare)
>  xc.cap_vmtrace = C.bool(x.CapVmtrace)
> +xc.cap_vpmu = C.bool(x.CapVpmu)
>  
>   return nil
>   }
> diff --git a/tools/golang/xenlight/types.gen.go b/tools/golang/xenlight/types.gen.go
> index 09a3bb67e2..45f2cba3d2 100644
> --- a/tools/golang/xenlight/types.gen.go
> +++ b/tools/golang/xenlight/types.gen.go
> @@ -1008,6 +1008,7 @@ CapHap bool
>  CapShadow bool
>  CapIommuHapPtShare bool
>  CapVmtrace bool
> +CapVpmu bool
>  }
>  
>  type Connectorinfo struct {
> diff --git a/tools/include/libxl.h b/tools/include/libxl.h
> index b9ba16d698..ec5e3badae 100644
> --- a/tools/include/libxl.h
> +++ b/tools/include/libxl.h
> @@ -502,6 +502,12 @@
>   */
>  #define LIBXL_HAVE_X86_MSR_RELAXED 1
>  
> +/*
> + * LIBXL_HAVE_PHYSINFO_CAP_VPMU indicates that libxl_physinfo has a cap_vpmu
> + * field, which indicates the availability of vPMU functionality.
> + */
> +#define LIBXL_HAVE_PHYSINFO_CAP_VPMU 1
> +
>  /*
>   * libxl ABI compatibility
>   *
> diff --git a/tools/libs/light/libxl.c b/tools/libs/light/libxl.c
> index 204eb0be2d..a032723fde 100644
> --- a/tools/libs/light/libxl.c
> +++ b/tools/libs/light/libxl.c
> @@ -404,6 +404,7 @@ int libxl_get_physinfo(libxl_ctx *ctx, libxl_physinfo *physinfo)
>          !!(xcphysinfo.capabilities & XEN_SYSCTL_PHYSCAP_iommu_hap_pt_share);
>      physinfo->cap_vmtrace =
>          !!(xcphysinfo.capabilities & XEN_SYSCTL_PHYSCAP_vmtrace);
> +    physinfo->cap_vpmu = !!(xcphysinfo.capabilities & XEN_SYSCTL_PHYSCAP_vpmu);
>  
>      GC_FREE;
>      return 0;
> diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_types.idl
> index 3f9fff653a..993e83acca 100644
> --- a/tools/libs/light/libxl_types.idl
> +++ b/tools/libs/light/libxl_types.idl
> @@ -1061,6 +1061,7 @@ libxl_physinfo = Struct("physinfo", [
>      ("cap_shadow", bool),
>      ("cap_iommu_hap_pt_share", bool),
>      ("cap_vmtrace", bool),
> +    ("cap_vpmu", bool),
>      ], dir=DIR_OUT)
>  
>  libxl_connectorinfo = Struct("connectorinfo", [
> diff --git a/tools/ocaml/libs/xc/xenctrl.ml b/tools/ocaml/libs/xc/xenctrl.ml
> index a5588c643f..6da3ed3c6f 100644
> --- a/tools/ocaml/libs/xc/xenctrl.ml
> +++ b/tools/ocaml/libs/xc/xenctrl.ml
> @@ -121,6 +121,7 @@ type physinfo_cap_flag =
>  	| CAP_Shadow
>  	| CAP_IOMMU_HAP_PT_SHARE
>  	| CAP_Vmtrace
> +	| CAP_Vpmu
>  
>  type physinfo =
>  {
> diff --git a/tools/ocaml/libs/xc/xenctrl.mli b/tools/ocaml/libs/xc/xenctrl.mli
> index 6e94940a8a..b8faff6721 100644
> --- a/tools/ocaml/libs/xc/xenctrl.mli
> +++ b/tools/ocaml/libs/xc/xenctrl.mli
> @@ -106,6 +106,7 @@ type physinfo_cap_flag =
>    | CAP_Shadow
>    | CAP_IOMMU_HAP_PT_SHARE
>    | CAP_Vmtrace
> +  | CAP_Vpmu
>  
>  type physinfo = {
>    threads_per_core : int;
> diff --git a/tools/xl/xl_info.c b/tools/xl/xl_info.c
> index 8383e4a6df..2c86b317b7 100644
> --- a/tools/xl/xl_info.c
> +++ b/tools/xl/xl_info.c
> @@ -210,7 +210,7 @@ static void output_physinfo(void)
>           info.hw_cap[4], info.hw_cap[5], info.hw_cap[6], info.hw_cap[7]
>          );
>  
> -    maybe_printf("virt_caps              :%s%s%s%s%s%s%s%s\n",
> +    maybe_printf("virt_caps              :%s%s%s%s%s%s%s%s%s\n",
>           info.cap_pv ? " pv" : "",
>           info.cap_hvm ? " hvm" : "",
>           info.cap_hvm && info.cap_hvm_directio ? " hvm_directio" : "",
> @@ -218,7 +218,8 @@ static void output_physinfo(void)
>           info.cap_hap ? " hap" : "",
>           info.cap_shadow ? " shadow" : "",
>           info.cap_iommu_hap_pt_share ? " iommu_hap_pt_share" : "",
> -         info.cap_vmtrace ? " vmtrace" : ""
> +         info.cap_vmtrace ? " vmtrace" : "",
> +         info.cap_vpmu ? " vpmu" : ""
>          );
>  
>      vinfo = libxl_get_version_info(ctx);
> diff --git a/xen/common/domain.c b/xen/common/domain.c
> index 6ee5d033b0..4d0e909eec 100644
> --- a/xen/common/domain.c
> +++ b/xen/common/domain.c
> @@ -84,6 +84,8 @@ vcpu_info_t dummy_vcpu_info;
>  
>  bool __read_mostly vmtrace_available;
>  
> +bool __read_mostly vpmu_is_available;
> +
>  static void __domain_finalise_shutdown(struct domain *d)
>  {
>      struct vcpu *v;
> diff --git a/xen/common/sysctl.c b/xen/common/sysctl.c
> index 3558641cd9..6e7189bb3c 100644
> --- a/xen/common/sysctl.c
> +++ b/xen/common/sysctl.c
> @@ -280,6 +280,9 @@ long do_sysctl(XEN_GUEST_HANDLE_PARAM(xen_sysctl_t) u_sysctl)
>          if ( vmtrace_available )
>              pi->capabilities |= XEN_SYSCTL_PHYSCAP_vmtrace;
>  
> +        if ( vpmu_is_available )
> +            pi->capabilities |= XEN_SYSCTL_PHYSCAP_vpmu;
> +
>          if ( copy_to_guest(u_sysctl, op, 1) )
>              ret = -EFAULT;
>      }
> diff --git a/xen/include/public/sysctl.h b/xen/include/public/sysctl.h
> index 039ccf885c..b794c9d351 100644
> --- a/xen/include/public/sysctl.h
> +++ b/xen/include/public/sysctl.h
> @@ -100,10 +100,12 @@ struct xen_sysctl_tbuf_op {
>  #define _XEN_SYSCTL_PHYSCAP_iommu_hap_pt_share 5
>  #define XEN_SYSCTL_PHYSCAP_iommu_hap_pt_share  \
>      (1u << _XEN_SYSCTL_PHYSCAP_iommu_hap_pt_share)
> -#define XEN_SYSCTL_PHYSCAP_vmtrace       (1 << 6)
> +#define XEN_SYSCTL_PHYSCAP_vmtrace       (1u<<6)
> +/* The platform supports vPMU. */
> +#define XEN_SYSCTL_PHYSCAP_vpmu          (1u<<7)
>  
>  /* Max XEN_SYSCTL_PHYSCAP_* constant.  Used for ABI checking. */
> -#define XEN_SYSCTL_PHYSCAP_MAX XEN_SYSCTL_PHYSCAP_vmtrace
> +#define XEN_SYSCTL_PHYSCAP_MAX XEN_SYSCTL_PHYSCAP_vpmu
>  
>  struct xen_sysctl_physinfo {
>      uint32_t threads_per_core;
> diff --git a/xen/include/xen/domain.h b/xen/include/xen/domain.h
> index 1708c36964..160c8dbdab 100644
> --- a/xen/include/xen/domain.h
> +++ b/xen/include/xen/domain.h
> @@ -133,4 +133,6 @@ static inline void vnuma_destroy(struct vnuma_info *vnuma) { ASSERT(!vnuma); }
>  
>  extern bool vmtrace_available;
>  
> +extern bool vpmu_is_available;
> +
>  #endif /* __XEN_DOMAIN_H__ */
> -- 
> 2.29.0
> 


From xen-devel-bounces@lists.xenproject.org Sat Oct 09 00:37:39 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 09 Oct 2021 00:37:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.204994.360241 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZ0Mh-0006cN-UI; Sat, 09 Oct 2021 00:37:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 204994.360241; Sat, 09 Oct 2021 00:37:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZ0Mh-0006cG-QB; Sat, 09 Oct 2021 00:37:27 +0000
Received: by outflank-mailman (input) for mailman id 204994;
 Sat, 09 Oct 2021 00:37:26 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=NfYO=O5=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1mZ0Mg-0006cA-3t
 for xen-devel@lists.xenproject.org; Sat, 09 Oct 2021 00:37:26 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id c493cccf-a3d4-4f06-b696-e5f478628dd7;
 Sat, 09 Oct 2021 00:37:24 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id 3EF3B60F6F;
 Sat,  9 Oct 2021 00:37:23 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c493cccf-a3d4-4f06-b696-e5f478628dd7
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1633739843;
	bh=dfC4Vb0G9MF2ZFADLY6LBFXb4ZyLpGFqaXMghqVmisI=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=Nn0HtiqK/ryN/kGsIBbP9ga0oxd6GdL+KWTfhKHNC6zvE+cGrD5ntxkVur7QxYLWl
	 jpkHtUB8gJeNob77cbgjmN2EMTn/5kHUp9f2oHOXqo1dwTWZg+ZIFrVXvhN2WfN5o9
	 nKqVJlrIiRBDD2LwWbf8OZfp+qGhUEpxYVPoiLqNBdjCrfdHGWg8kCYQzPqnHE50mr
	 /f1gciNgpsN6Iafx43hl+G5JBrGCxtLlfl09qUtd2irB1rryrP1dF38zPD5FUemnyA
	 SuxE48EIoIlkRIS3oCMKjm5nIFswqe8TcUadlRfIp0Nanz3HNCnSGdCdUYvP+6qtWS
	 UiOgeU7Co6b4w==
Date: Fri, 8 Oct 2021 17:37:22 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Michal Orzel <michal.orzel@arm.com>
cc: xen-devel@lists.xenproject.org, Ian Jackson <iwj@xenproject.org>, 
    Wei Liu <wl@xen.org>, Andrew Cooper <andrew.cooper3@citrix.com>, 
    George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>, 
    Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>, 
    Nick Rosbrook <rosbrookn@ainfosec.com>, 
    Anthony PERARD <anthony.perard@citrix.com>, 
    Juergen Gross <jgross@suse.com>, 
    Christian Lindig <christian.lindig@citrix.com>, 
    David Scott <dave@recoil.org>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH v3 3/3] xen: Expose the PMU to the guests
In-Reply-To: <20211008081933.18546-4-michal.orzel@arm.com>
Message-ID: <alpine.DEB.2.21.2110081729550.25528@sstabellini-ThinkPad-T480s>
References: <20211008081933.18546-1-michal.orzel@arm.com> <20211008081933.18546-4-michal.orzel@arm.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Fri, 8 Oct 2021, Michal Orzel wrote:
> Add parameter vpmu to xl domain configuration syntax
> to enable the access to PMU registers by disabling
> the PMU traps(currently only for ARM).
> 
> The current status is that the PMU registers are not
> virtualized and the physical registers are directly
> accessible when this parameter is enabled. There is no
> interrupt support and Xen will not save/restore the
> register values on context switches.
> 
> Please note that this feature is experimental.
> 
> Signed-off-by: Michal Orzel <michal.orzel@arm.com>
> Signed-off-by: Julien Grall <julien@xen.org>

The patch needs rebasing


> ---
> Changes since v2:
> -remove redundant check from x86 code
> -do not define bit position and mask separately
> Changes since v1:
> -modify vpmu parameter to be common rather than arch specific
> ---
>  docs/man/xl.cfg.5.pod.in             | 17 +++++++++++++++++
>  tools/golang/xenlight/helpers.gen.go |  6 ++++++
>  tools/golang/xenlight/types.gen.go   |  1 +
>  tools/include/libxl.h                |  6 ++++++
>  tools/libs/light/libxl_create.c      |  4 ++++
>  tools/libs/light/libxl_types.idl     |  2 ++
>  tools/ocaml/libs/xc/xenctrl.ml       |  1 +
>  tools/ocaml/libs/xc/xenctrl.mli      |  1 +
>  tools/xl/xl_parse.c                  |  2 ++
>  xen/arch/arm/domain.c                | 10 ++++++++--
>  xen/arch/arm/setup.c                 |  1 +
>  xen/common/domain.c                  |  9 ++++++++-
>  xen/include/asm-arm/domain.h         |  1 +
>  xen/include/public/domctl.h          |  4 +++-
>  14 files changed, 61 insertions(+), 4 deletions(-)
> 
> diff --git a/docs/man/xl.cfg.5.pod.in b/docs/man/xl.cfg.5.pod.in
> index 4b1e3028d2..55c4881205 100644
> --- a/docs/man/xl.cfg.5.pod.in
> +++ b/docs/man/xl.cfg.5.pod.in
> @@ -690,6 +690,23 @@ default.
>  B<NOTE>: Acceptable values are platform specific.  For Intel Processor
>  Trace, this value must be a power of 2 between 4k and 16M.
>  
> +=item B<vpmu=BOOLEAN>
> +
> +Currently ARM only.
> +
> +Specifies whether to enable the access to PMU registers by disabling
> +the PMU traps.
> +
> +The PMU registers are not virtualized and the physical registers are directly
> +accessible when this parameter is enabled. There is no interrupt support and
> +Xen will not save/restore the register values on context switches.
> +
> +vPMU, by design and purpose, exposes system level performance
> +information to the guest. Only to be used by sufficiently privileged
> +domains. This feature is currently in experimental state.
> +
> +If this option is not specified then it will default to B<false>.
> +
>  =back
>  
>  =head2 Devices
> diff --git a/tools/golang/xenlight/helpers.gen.go b/tools/golang/xenlight/helpers.gen.go
> index c8669837d8..2449580bad 100644
> --- a/tools/golang/xenlight/helpers.gen.go
> +++ b/tools/golang/xenlight/helpers.gen.go
> @@ -1119,6 +1119,9 @@ return fmt.Errorf("converting field ArchX86.MsrRelaxed: %v", err)
>  }
>  x.Altp2M = Altp2MMode(xc.altp2m)
>  x.VmtraceBufKb = int(xc.vmtrace_buf_kb)
> +if err := x.Vpmu.fromC(&xc.vpmu);err != nil {
> +return fmt.Errorf("converting field Vpmu: %v", err)
> +}
>  
>   return nil}
>  
> @@ -1600,6 +1603,9 @@ return fmt.Errorf("converting field ArchX86.MsrRelaxed: %v", err)
>  }
>  xc.altp2m = C.libxl_altp2m_mode(x.Altp2M)
>  xc.vmtrace_buf_kb = C.int(x.VmtraceBufKb)
> +if err := x.Vpmu.toC(&xc.vpmu); err != nil {
> +return fmt.Errorf("converting field Vpmu: %v", err)
> +}
>  
>   return nil
>   }
> diff --git a/tools/golang/xenlight/types.gen.go b/tools/golang/xenlight/types.gen.go
> index 45f2cba3d2..b2e8bd1a85 100644
> --- a/tools/golang/xenlight/types.gen.go
> +++ b/tools/golang/xenlight/types.gen.go
> @@ -521,6 +521,7 @@ MsrRelaxed Defbool
>  }
>  Altp2M Altp2MMode
>  VmtraceBufKb int
> +Vpmu Defbool
>  }
>  
>  type DomainBuildInfoTypeUnion interface {
> diff --git a/tools/include/libxl.h b/tools/include/libxl.h
> index ec5e3badae..ee73eb06f1 100644
> --- a/tools/include/libxl.h
> +++ b/tools/include/libxl.h
> @@ -508,6 +508,12 @@
>   */
>  #define LIBXL_HAVE_PHYSINFO_CAP_VPMU 1
>  
> +/*
> + * LIBXL_HAVE_VPMU indicates that libxl_domain_build_info has a vpmu parameter,
> + * which allows to enable the access to PMU registers.
> + */
> +#define LIBXL_HAVE_VPMU 1
> +
>  /*
>   * libxl ABI compatibility
>   *
> diff --git a/tools/libs/light/libxl_create.c b/tools/libs/light/libxl_create.c
> index e356b2106d..d123c2f703 100644
> --- a/tools/libs/light/libxl_create.c
> +++ b/tools/libs/light/libxl_create.c
> @@ -91,6 +91,7 @@ int libxl__domain_build_info_setdefault(libxl__gc *gc,
>      }
>  
>      libxl_defbool_setdefault(&b_info->device_model_stubdomain, false);
> +    libxl_defbool_setdefault(&b_info->vpmu, false);
>  
>      if (libxl_defbool_val(b_info->device_model_stubdomain) &&
>          !b_info->device_model_ssidref)
> @@ -622,6 +623,9 @@ int libxl__domain_make(libxl__gc *gc, libxl_domain_config *d_config,
>                  create.flags |= XEN_DOMCTL_CDF_nested_virt;
>          }
>  
> +        if ( libxl_defbool_val(b_info->vpmu) )
> +            create.flags |= XEN_DOMCTL_CDF_vpmu;

As Andrew recently pointed out in another thread
(https://marc.info/?l=xen-devel&m=163372953907637), it would be good to
check that vpmu is actually available from Xen before setting
XEN_DOMCTL_CDF_vpmu. You have already added XEN_SYSCTL_PHYSCAP_vpmu in
patch #1, so it should be only a matter of checking for it.

So that we can fail explicitly if vpmu is set in the config file but
XEN_SYSCTL_PHYSCAP_vpmu is not available.

Everything else looks fine to me.



>          assert(info->passthrough != LIBXL_PASSTHROUGH_DEFAULT);
>          LOG(DETAIL, "passthrough: %s",
>              libxl_passthrough_to_string(info->passthrough));
> diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_types.idl
> index 993e83acca..b96fb5c47e 100644
> --- a/tools/libs/light/libxl_types.idl
> +++ b/tools/libs/light/libxl_types.idl
> @@ -655,6 +655,8 @@ libxl_domain_build_info = Struct("domain_build_info",[
>      # Use zero value to disable this feature.
>      ("vmtrace_buf_kb", integer),
>  
> +    ("vpmu", libxl_defbool),
> +
>      ], dir=DIR_IN,
>         copy_deprecated_fn="libxl__domain_build_info_copy_deprecated",
>  )
> diff --git a/tools/ocaml/libs/xc/xenctrl.ml b/tools/ocaml/libs/xc/xenctrl.ml
> index 6da3ed3c6f..addcf4cc59 100644
> --- a/tools/ocaml/libs/xc/xenctrl.ml
> +++ b/tools/ocaml/libs/xc/xenctrl.ml
> @@ -69,6 +69,7 @@ type domain_create_flag =
>  	| CDF_XS_DOMAIN
>  	| CDF_IOMMU
>  	| CDF_NESTED_VIRT
> +	| CDF_VPMU
>  
>  type domain_create_iommu_opts =
>  	| IOMMU_NO_SHAREPT
> diff --git a/tools/ocaml/libs/xc/xenctrl.mli b/tools/ocaml/libs/xc/xenctrl.mli
> index b8faff6721..0a5ce529e9 100644
> --- a/tools/ocaml/libs/xc/xenctrl.mli
> +++ b/tools/ocaml/libs/xc/xenctrl.mli
> @@ -62,6 +62,7 @@ type domain_create_flag =
>    | CDF_XS_DOMAIN
>    | CDF_IOMMU
>    | CDF_NESTED_VIRT
> +  | CDF_VPMU
>  
>  type domain_create_iommu_opts =
>    | IOMMU_NO_SHAREPT
> diff --git a/tools/xl/xl_parse.c b/tools/xl/xl_parse.c
> index 17dddb4cd5..c503b9be00 100644
> --- a/tools/xl/xl_parse.c
> +++ b/tools/xl/xl_parse.c
> @@ -2750,6 +2750,8 @@ skip_usbdev:
>                      "If it fixes an issue you are having please report to "
>                      "xen-devel@lists.xenproject.org.\n");
>  
> +    xlu_cfg_get_defbool(config, "vpmu", &b_info->vpmu, 0);
> +
>      xlu_cfg_destroy(config);
>  }
>  
> diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
> index 19c756ac3d..2dd474da09 100644
> --- a/xen/arch/arm/domain.c
> +++ b/xen/arch/arm/domain.c
> @@ -276,6 +276,8 @@ static void ctxt_switch_to(struct vcpu *n)
>       * timer. The interrupt needs to be injected into the guest. */
>      WRITE_SYSREG(n->arch.cntkctl, CNTKCTL_EL1);
>      virt_timer_restore(n);
> +
> +    WRITE_SYSREG(n->arch.mdcr_el2, MDCR_EL2);
>  }
>  
>  /* Update per-VCPU guest runstate shared memory area (if registered). */
> @@ -586,6 +588,10 @@ int arch_vcpu_create(struct vcpu *v)
>  
>      v->arch.hcr_el2 = get_default_hcr_flags();
>  
> +    v->arch.mdcr_el2 = HDCR_TDRA | HDCR_TDOSA | HDCR_TDA;
> +    if ( !(v->domain->options & XEN_DOMCTL_CDF_vpmu) )
> +        v->arch.mdcr_el2 |= HDCR_TPM | HDCR_TPMCR;
> +
>      if ( (rc = vcpu_vgic_init(v)) != 0 )
>          goto fail;
>  
> @@ -622,8 +628,8 @@ int arch_sanitise_domain_config(struct xen_domctl_createdomain *config)
>  {
>      unsigned int max_vcpus;
>  
> -    /* HVM and HAP must be set. IOMMU may or may not be */
> -    if ( (config->flags & ~XEN_DOMCTL_CDF_iommu) !=
> +    /* HVM and HAP must be set. IOMMU and PMU may or may not be */
> +    if ( (config->flags & ~(XEN_DOMCTL_CDF_iommu | XEN_DOMCTL_CDF_vpmu)) !=
>           (XEN_DOMCTL_CDF_hvm | XEN_DOMCTL_CDF_hap) )
>      {
>          dprintk(XENLOG_INFO, "Unsupported configuration %#x\n",
> diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c
> index 49dc90d198..85386a765a 100644
> --- a/xen/arch/arm/setup.c
> +++ b/xen/arch/arm/setup.c
> @@ -108,6 +108,7 @@ static void __init processor_id(void)
>  
>      identify_cpu(c);
>      current_cpu_data = *c;
> +    vpmu_is_available = cpu_has_pmu;
>  
>      if ( c->midr.implementer < ARRAY_SIZE(processor_implementers) &&
>           processor_implementers[c->midr.implementer] )
> diff --git a/xen/common/domain.c b/xen/common/domain.c
> index 4d0e909eec..8b53c49d1e 100644
> --- a/xen/common/domain.c
> +++ b/xen/common/domain.c
> @@ -480,12 +480,13 @@ static int sanitise_domain_config(struct xen_domctl_createdomain *config)
>      bool hvm = config->flags & XEN_DOMCTL_CDF_hvm;
>      bool hap = config->flags & XEN_DOMCTL_CDF_hap;
>      bool iommu = config->flags & XEN_DOMCTL_CDF_iommu;
> +    bool vpmu = config->flags & XEN_DOMCTL_CDF_vpmu;
>  
>      if ( config->flags &
>           ~(XEN_DOMCTL_CDF_hvm | XEN_DOMCTL_CDF_hap |
>             XEN_DOMCTL_CDF_s3_integrity | XEN_DOMCTL_CDF_oos_off |
>             XEN_DOMCTL_CDF_xs_domain | XEN_DOMCTL_CDF_iommu |
> -           XEN_DOMCTL_CDF_nested_virt) )
> +           XEN_DOMCTL_CDF_nested_virt | XEN_DOMCTL_CDF_vpmu) )
>      {
>          dprintk(XENLOG_INFO, "Unknown CDF flags %#x\n", config->flags);
>          return -EINVAL;
> @@ -534,6 +535,12 @@ static int sanitise_domain_config(struct xen_domctl_createdomain *config)
>          return -EINVAL;
>      }
>  
> +    if ( vpmu && !vpmu_is_available )
> +    {
> +        dprintk(XENLOG_INFO, "vpmu requested but cannot be enabled this way\n");
> +        return -EINVAL;
> +    }
> +
>      return arch_sanitise_domain_config(config);
>  }
>  
> diff --git a/xen/include/asm-arm/domain.h b/xen/include/asm-arm/domain.h
> index c9277b5c6d..14e575288f 100644
> --- a/xen/include/asm-arm/domain.h
> +++ b/xen/include/asm-arm/domain.h
> @@ -166,6 +166,7 @@ struct arch_vcpu
>  
>      /* HYP configuration */
>      register_t hcr_el2;
> +    register_t mdcr_el2;
>  
>      uint32_t teecr, teehbr; /* ThumbEE, 32-bit guests only */
>  #ifdef CONFIG_ARM_32
> diff --git a/xen/include/public/domctl.h b/xen/include/public/domctl.h
> index 96696e3842..238384b5ae 100644
> --- a/xen/include/public/domctl.h
> +++ b/xen/include/public/domctl.h
> @@ -70,9 +70,11 @@ struct xen_domctl_createdomain {
>  #define XEN_DOMCTL_CDF_iommu          (1U<<_XEN_DOMCTL_CDF_iommu)
>  #define _XEN_DOMCTL_CDF_nested_virt   6
>  #define XEN_DOMCTL_CDF_nested_virt    (1U << _XEN_DOMCTL_CDF_nested_virt)
> +/* Should we expose the vPMU to the guest? */
> +#define XEN_DOMCTL_CDF_vpmu           (1U << 7)
>  
>  /* Max XEN_DOMCTL_CDF_* constant.  Used for ABI checking. */
> -#define XEN_DOMCTL_CDF_MAX XEN_DOMCTL_CDF_nested_virt
> +#define XEN_DOMCTL_CDF_MAX XEN_DOMCTL_CDF_vpmu
>  
>      uint32_t flags;
>  
> -- 
> 2.29.0
> 


From xen-devel-bounces@lists.xenproject.org Sat Oct 09 02:07:30 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 09 Oct 2021 02:07:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.205023.360263 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZ1lV-00064Q-1q; Sat, 09 Oct 2021 02:07:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 205023.360263; Sat, 09 Oct 2021 02:07:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZ1lU-00064I-TM; Sat, 09 Oct 2021 02:07:08 +0000
Received: by outflank-mailman (input) for mailman id 205023;
 Sat, 09 Oct 2021 02:07:07 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mZ1lT-000648-2p; Sat, 09 Oct 2021 02:07:07 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mZ1lS-00086h-S4; Sat, 09 Oct 2021 02:07:06 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mZ1lS-0004jh-Ix; Sat, 09 Oct 2021 02:07:06 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mZ1lS-0000Dm-IS; Sat, 09 Oct 2021 02:07:06 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=M1aP5mSddOEltarLWmp+LujWXpPUboWQlt3FKyQG8jE=; b=oP2ofDvh7YrSJUzVXfeVCKkpPq
	Ubuv4s42BmxXJ4Ok06mGAAEVtWE2QRGBHY44F6L4jyJlkR5f9cP4PlrM5zeD02OOHaYwR5YjnA86d
	apl9nAdB3phk0mBL/DI/LQiKMwr4PxjUMeXsg75vkLjT2B6vhXHp0d4T94mg+GdxF8DI=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165437-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 165437: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=d4c9845e52cbb3cd62172809f62ee51dbb3ca7de
X-Osstest-Versions-That:
    xen=b11380f6cd58ce40422473262b2b4c2b210447a1
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 09 Oct 2021 02:07:06 +0000

flight 165437 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165437/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  d4c9845e52cbb3cd62172809f62ee51dbb3ca7de
baseline version:
 xen                  b11380f6cd58ce40422473262b2b4c2b210447a1

Last test of basis   165436  2021-10-08 18:01:40 Z    0 days
Testing same since   165437  2021-10-08 23:02:55 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Jan Beulich <jbeulich@suse.com>
  Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
  Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
  Rahul Singh <rahul.singh@arm.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   b11380f6cd..d4c9845e52  d4c9845e52cbb3cd62172809f62ee51dbb3ca7de -> smoke


From xen-devel-bounces@lists.xenproject.org Sat Oct 09 04:51:41 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 09 Oct 2021 04:51:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.205036.360277 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZ4KT-0004g5-KQ; Sat, 09 Oct 2021 04:51:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 205036.360277; Sat, 09 Oct 2021 04:51:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZ4KT-0004fy-F6; Sat, 09 Oct 2021 04:51:25 +0000
Received: by outflank-mailman (input) for mailman id 205036;
 Sat, 09 Oct 2021 04:51:24 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mZ4KS-0004fo-0l; Sat, 09 Oct 2021 04:51:24 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mZ4KR-0002Q1-SA; Sat, 09 Oct 2021 04:51:23 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mZ4KR-0005n0-IL; Sat, 09 Oct 2021 04:51:23 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mZ4KR-0007Js-Hm; Sat, 09 Oct 2021 04:51:23 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=3Q9YNp2iJu7Ca7df5wY3OUpSn7d+bE08PfT5Grn3M1M=; b=PE4siOt/WnNH5ShpZk+D/jBeL9
	4vdB84N8lm1jjsP5BuwGDkqCw3GwCNvAKKWn/iYlUt1N9fOFUGzFzWHBCQavSfAWY+0d9IFePhDOc
	4hko4No6Gzj7//Ej5hTuqqn085w8xbDbiGpSMmLbddUzY9tnDisPAyCDhem0RKZmZtrA=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165429-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 165429: tolerable FAIL - PUSHED
X-Osstest-Failures:
    qemu-mainline:test-amd64-i386-xl-qemuu-ovmf-amd64:guest-localmigrate/x10:fail:heisenbug
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=14f12119aa675e9e28207a48b0728a2daa5b88d6
X-Osstest-Versions-That:
    qemuu=ca61fa4b803e5d0abaf6f1ceb690f23bb78a4def
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 09 Oct 2021 04:51:23 +0000

flight 165429 qemu-mainline real [real]
flight 165440 qemu-mainline real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/165429/
http://logs.test-lab.xenproject.org/osstest/logs/165440/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-i386-xl-qemuu-ovmf-amd64 18 guest-localmigrate/x10 fail pass in 165440-retest

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165409
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165409
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 165409
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 165409
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 165409
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 165409
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 165409
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165409
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass

version targeted for testing:
 qemuu                14f12119aa675e9e28207a48b0728a2daa5b88d6
baseline version:
 qemuu                ca61fa4b803e5d0abaf6f1ceb690f23bb78a4def

Last test of basis   165409  2021-10-07 11:33:46 Z    1 days
Testing same since   165429  2021-10-08 11:40:26 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Alistair Francis <alistair.francis@wdc.com>
  Bin Meng <bin.meng@windriver.com>
  Bin Meng <bmeng.cn@gmail.com>
  Frank Chang <frank.chang@sifive.com>
  Hanna Reitz <hreitz@redhat.com>
  Philipp Tomsich <philipp.tomsich@vrull.eu>
  Philippe Mathieu-Daudé <f4bug@amsat.org>
  Richard Henderson <richard.henderson@linaro.org>
  Stefano Garzarella <sgarzare@redhat.com>
  Vincent Chen <vincent.chen@sifive.com>
  Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/qemu-xen.git
   ca61fa4b80..14f12119aa  14f12119aa675e9e28207a48b0728a2daa5b88d6 -> upstream-tested


From xen-devel-bounces@lists.xenproject.org Sat Oct 09 05:52:57 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 09 Oct 2021 05:52:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.205047.360291 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZ5Hn-0002x6-A0; Sat, 09 Oct 2021 05:52:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 205047.360291; Sat, 09 Oct 2021 05:52:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZ5Hn-0002wz-73; Sat, 09 Oct 2021 05:52:43 +0000
Received: by outflank-mailman (input) for mailman id 205047;
 Sat, 09 Oct 2021 05:52:42 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mZ5Hm-0002wp-26; Sat, 09 Oct 2021 05:52:42 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mZ5Hl-00046K-U1; Sat, 09 Oct 2021 05:52:41 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mZ5Hl-0000ot-H6; Sat, 09 Oct 2021 05:52:41 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mZ5Hl-0002SH-Gb; Sat, 09 Oct 2021 05:52:41 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=tw4bwoTLoFb3gZA/aaQoxIERwsxrTzXAnV3fXVtKGAI=; b=2DwZzo1bx5PHyX2KHCI6zyJUWS
	GcWkdY5jE9QPPM7xFDmDLUht+ElgS4OT7yVSLqAjycGzgV1Nv9aH0RDj6/aghIpQAp+7xvZTB+uJy
	BWQHu+wAy/CaWUHwQn7qEAp73kOrn3iSxnRTZHm4qessainHI4sG9hIDPFo8tjLh+i3I=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165439-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 165439: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=664cc3c3d381e4f9a61dcb68cbd7a6a00070370e
X-Osstest-Versions-That:
    xen=d4c9845e52cbb3cd62172809f62ee51dbb3ca7de
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 09 Oct 2021 05:52:41 +0000

flight 165439 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165439/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  664cc3c3d381e4f9a61dcb68cbd7a6a00070370e
baseline version:
 xen                  d4c9845e52cbb3cd62172809f62ee51dbb3ca7de

Last test of basis   165437  2021-10-08 23:02:55 Z    0 days
Testing same since   165439  2021-10-09 03:01:40 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Stefano Stabellini <sstabellini@kernel.org>
  Volodymyr Babchuk <volodymyr_babchuk@epam.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   d4c9845e52..664cc3c3d3  664cc3c3d381e4f9a61dcb68cbd7a6a00070370e -> smoke


From xen-devel-bounces@lists.xenproject.org Sat Oct 09 06:45:19 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 09 Oct 2021 06:45:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.205057.360305 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZ66a-000847-F4; Sat, 09 Oct 2021 06:45:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 205057.360305; Sat, 09 Oct 2021 06:45:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZ66a-000840-Aa; Sat, 09 Oct 2021 06:45:12 +0000
Received: by outflank-mailman (input) for mailman id 205057;
 Sat, 09 Oct 2021 06:45:10 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mZ66Y-00083q-Rp; Sat, 09 Oct 2021 06:45:10 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mZ66Y-000548-Mx; Sat, 09 Oct 2021 06:45:10 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mZ66Y-0003B7-CN; Sat, 09 Oct 2021 06:45:10 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mZ66Y-0005di-Bs; Sat, 09 Oct 2021 06:45:10 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=qoIoagmB+z17fgz/uNf4vUCy6mOMhohkyPb964789Pc=; b=aMiXbxAv9qwxB3SVe1nVhsSPYr
	Pj+D2Gv41wPmVV7qaZWbGW/cnIPtV953Ti419VJtQOToLBN03r59l5XvD5UyHdlQ1WWIp/jGRpSKY
	7o7ikV0ZdHgrhAZbB3BBz2dhjUN4lqpmlft78TnmBQ29BrCrpWq1DXmWdsmekwdPqZ5A=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165433-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 165433: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=769e63999ff5c786d5aac1fd6dbfa4748fbccbc7
X-Osstest-Versions-That:
    ovmf=5ece2ad36caa7ddc62d4954559b2cdd0d8a40a14
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 09 Oct 2021 06:45:10 +0000

flight 165433 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165433/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 769e63999ff5c786d5aac1fd6dbfa4748fbccbc7
baseline version:
 ovmf                 5ece2ad36caa7ddc62d4954559b2cdd0d8a40a14

Last test of basis   165425  2021-10-08 07:12:37 Z    0 days
Testing same since   165433  2021-10-08 16:10:05 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Chris Jones <christopher.jones@arm.com>
  Pierre Gondois <Pierre.Gondois@arm.com>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   5ece2ad36c..769e63999f  769e63999ff5c786d5aac1fd6dbfa4748fbccbc7 -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Sat Oct 09 06:56:12 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 09 Oct 2021 06:56:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.205066.360319 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZ6H3-00017K-G1; Sat, 09 Oct 2021 06:56:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 205066.360319; Sat, 09 Oct 2021 06:56:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZ6H3-00017D-Cy; Sat, 09 Oct 2021 06:56:01 +0000
Received: by outflank-mailman (input) for mailman id 205066;
 Sat, 09 Oct 2021 06:56:00 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mZ6H2-000173-C9; Sat, 09 Oct 2021 06:56:00 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mZ6H2-0005Dy-7K; Sat, 09 Oct 2021 06:56:00 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mZ6H1-0003bS-Uq; Sat, 09 Oct 2021 06:56:00 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mZ6H1-00042h-UK; Sat, 09 Oct 2021 06:55:59 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=B2R24QAQpSLRJdgzUmthykHJsbgu8kDdBeQrzxzSLko=; b=uBroaXoR/shWKqH1MCMVJcalp9
	12naU8Nk4cDVcpCS8jjstr3ZAZYgYsv1peLxsCT6iwAejwZWr/03WeHQ2XDOO+tzUpvU5jBuEaibX
	Y/e9zF8yP+ScqfE6EVsfjWuROteFdCB391HiiIin0jhsSxApbmsNRjXW8sZZpXM4w0Bk=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165431-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-5.4 test] 165431: regressions - FAIL
X-Osstest-Failures:
    linux-5.4:test-armhf-armhf-xl-credit1:guest-start:fail:regression
    linux-5.4:test-arm64-arm64-libvirt-xsm:guest-start/debian.repeat:fail:heisenbug
    linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable
    linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=31cdcb6d430f07760dd2f540a354b11e6bb6a4a4
X-Osstest-Versions-That:
    linux=e74e2950a0d6f800858e54860d7124c86e494f62
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 09 Oct 2021 06:55:59 +0000

flight 165431 linux-5.4 real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165431/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-armhf-armhf-xl-credit1  14 guest-start              fail REGR. vs. 165206

Tests which are failing intermittently (not blocking):
 test-arm64-arm64-libvirt-xsm 18 guest-start/debian.repeat  fail pass in 165414

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds    18 guest-start/debian.repeat fail REGR. vs. 165206

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165206
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 165206
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 165206
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 165206
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165206
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165206
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 165206
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 165206
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 165206
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 165206
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 165206
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 165206
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 linux                31cdcb6d430f07760dd2f540a354b11e6bb6a4a4
baseline version:
 linux                e74e2950a0d6f800858e54860d7124c86e494f62

Last test of basis   165206  2021-09-26 12:42:13 Z   12 days
Failing since        165346  2021-10-04 12:42:32 Z    4 days    5 attempts
Testing same since   165414  2021-10-07 14:32:19 Z    1 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
  Alan Stern <stern@rowland.harvard.edu>
  Alex Deucher <alexander.deucher@amd.com>
  Alexei Starovoitov <ast@kernel.org>
  Anders Roxell <anders.roxell@linaro.org>
  Andrea Claudi <aclaudi@redhat.com>
  Andreas Larsson <andreas@gaisler.com>
  Andrej Shadura <andrew.shadura@collabora.co.uk>
  Andrew Morton <akpm@linux-foundation.org>
  Andy Shevchenko <andriy.shevchenko@linux.intel.com>
  Anirudh Rayabharam <mail@anirudhrb.com>
  Anson Jacob <Anson.Jacob@amd.com>
  Antoine Tenart <atenart@kernel.org>
  Anton Eidelman <anton.eidelman@gmail.com>
  Anton Eidelman <anton@lightbitslabs.com>
  Ariel Elior <aelior@marvell.com>
  Arnd Bergmann <arnd@arndb.de>
  Aswath Govindraju <a-govindraju@ti.com>
  Aya Levin <ayal@nvidia.com>
  Baokun Li <libaokun1@huawei.com>
  Bartosz Golaszewski <brgl@bgdev.pl>
  Bixuan Cui <cuibixuan@huawei.com>
  Bjorn Helgaas <bhelgaas@google.com>
  Borislav Petkov <bp@suse.de>
  Carlo Lobrano <c.lobrano@gmail.com>
  Catalin Marinas <catalin.marinas@arm.com>
  Charlene Liu <Charlene.Liu@amd.com>
  Chen Jingwen <chenjingwen6@huawei.com>
  Chih-Kang Chang <gary.chang@realtek.com>
  Chris Chiu <chris.chiu@canonical.com>
  Christian Brauner <christian.brauner@ubuntu.com>
  Christoph Hellwig <hch@lst.de>
  Claudiu Manoil <claudiu.manoil@nxp.com>
  Cong Wang <cong.wang@bytedance.com>
  Dan Carpenter <dan.carpenter@oracle.com>
  Dan Li <ashimida@linux.alibaba.com>
  Dan Williams <dan.j.williams@intel.com>
  Daniel Borkmann <daniel@iogearbox.net>
  Daniel Lezcano <daniel.lezcano@linaro.org>
  Daniel Wheeler <daniel.wheeler@amd.com>
  David Howells <dhowells@redhat.com>
  David S. Miller <davem@davemloft.net>
  David Sterba <dsterba@suse.com>
  Dmitry Bogdanov <d.bogdanov@yadro.com>
  Dongliang Mu <mudongliangabcd@gmail.com>
  Eric Biggers <ebiggers@google.com>
  Eric Dumazet <edumazet@google.com>
  F.A. SULAIMAN <asha.16@itfac.mrt.ac.lk>
  F.A.Sulaiman <asha.16@itfac.mrt.ac.lk>
  Felipe Balbi <balbi@kernel.org>
  Florian Fainelli <f.fainelli@gmail.com>
  Gao Xiang <hsiangkao@linux.alibaba.com>
  Geert Uytterhoeven <geert@linux-m68k.org>
  Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  Gregory CLEMENT <gregory.clement@bootlin.com>
  Guangbin Huang <huangguangbin2@huawei.com>
  Guenter Roeck <linux@roeck-us.net>
  Hans de Goede <hdegoede@redhat.com>
  Helge Deller <deller@gmx.de>
  Herbert Xu <herbert@gondor.apana.org.au>
  Hulk Robot <hulkrobot@huawei.com>
  Igor Matheus Andrade Torrente <igormtorrente@gmail.com>
  Jacob Keller <jacob.e.keller@intel.com>
  James Morse <james.morse@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Jeffle Xu <jefflexu@linux.alibaba.com>
  Jens Axboe <axboe@kernel.dk>
  Jesper Nilsson <jesper.nilsson@axis.com>
  Jian Shen <shenjian15@huawei.com>
  Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
  Jiri Benc <jbenc@redhat.com>
  Jiri Kosina <jkosina@suse.cz>
  Jiri Slaby <jslaby@suse.cz>
  Johan Hovold <johan@kernel.org>
  Johannes Berg <johannes.berg@intel.com>
  Johannes Thumshirn <jth@kernel.org>
  John Allen <john.allen@amd.com>
  Jon Hunter <jonathanh@nvidia.com>
  Jonathan Hsu <jonathan.hsu@mediatek.com>
  Jozsef Kadlecsik <kadlec@netfilter.org>
  Juergen Gross <jgross@suse.com>
  Julian Anastasov <ja@ssi.bg>
  Julian Sikorski <belegdol+github@gmail.com>
  Julian Sikorski <belegdol@gmail.com>
  Kaige Fu <kaige.fu@linux.alibaba.com>
  Kan Liang <kan.liang@linux.intel.com>
  Karsten Graul <kgraul@linux.ibm.com>
  Kevin Hao <haokexin@gmail.com>
  Kishon Vijay Abraham I <kishon@ti.com>
  Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
  Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
  Leon Yu <leoyu@nvidia.com>
  Li Jinlin <lijinlin3@huawei.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Linux Kernel Functional Testing <lkft@linaro.org>
  Lorenzo Bianconi <lorenzo@kernel.org>
  Marc Zyngier <maz@kernel.org>
  Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
  Mark Rutland <mark.rutland@arm.com>
  Markus Suvanto <markus.suvanto@gmail.com>
  Martin K. Petersen <martin.petersen@oracle.com>
  Michael Chan <michael.chan@broadcom.com>
  Michael Chan <michael.chan@broadocm.com>
  Michal Kalderon <mkalderon@marvell.com>
  Minas Harutyunyan <Minas.Harutyunyan@synopsys.com>
  Moritz Fischer <mdf@kernel.org>
  Nadezda Lutovinova <lutovinova@ispras.ru>
  Nicolas Ferre <nicolas.ferre@microchip.com>
  Nirmoy Das <nirmoy.das@amd.com>
  Oliver Neukum <oneukum@suse.com>
  Ondrej Zary <linux@zary.sk>
  Ovidiu Panait <ovidiu.panait@windriver.com>
  Pablo Neira Ayuso <pablo@netfilter.org>
  Pali Rohár <pali@kernel.org>
  Paolo Bonzini <pbonzini@redhat.com>
  Paul Fertser <fercerpav@gmail.com>
  Pawel Laszczak <pawell@cadence.com>
  Peter Zijlstra (Intel) <peterz@infradead.org>
  Ping-Ke Shih <pkshih@realtek.com>
  Qu Wenruo <wqu@suse.com>
  Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
  Randy Dunlap <rdunlap@infradead.org>
  Ritesh Harjani <riteshh@linux.ibm.com>
  Rob Herring <robh@kernel.org>
  Ronnie Sahlberg <lsahlber@redhat.com>
  Sai Krishna Potthuri <lakshmi.sai.krishna.potthuri@xilinx.com>
  Samuel Iglesias Gonsalvez <siglesias@igalia.com>
  Sasha Levin <sashal@kernel.org>
  Shai Malin <smalin@marvell.com>
  Shuah Khan <skhan@linuxfoundation.org>
  Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
  Simon Horman <horms@verge.net.au>
  Slark Xiao <slark_xiao@163.com>
  Song Liu <songliubraving@fb.com>
  Srinivas Pandruvada <srinivas.pI andruvada@linux.intel.com>
  Steve French <stfrench@microsoft.com>
  Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
  sumiyawang <sumiyawang@tencent.com>
  syzbot+47b26cd837ececfc666d@syzkaller.appspotmail.com
  syzbot+fadc0aaf497e6a493b9f@syzkaller.appspotmail.com
  Tariq Toukan <tariqt@nvidia.com>
  Tejun Heo <tj@kernel.org>
  Theodore Ts'o <tytso@mit.edu>
  Todd Kjos <tkjos@google.com>
  Tom Rix <trix@redhat.com>
  Tong Zhang <ztong0001@gmail.com>
  Tony Nguyen <anthony.l.nguyen@intel.com>
  Tyler Hicks <tyhicks@linux.microsoft.com>
  Uwe Brandt <uwe.brandt@gmail.com>
  Vadim Pasternak <vadimp@nvidia.com>
  Viresh Kumar <viresh.kumar@linaro.org>
  Vlad Buslov <vladbu@nvidia.com>
  Wengang Wang <wen.gang.wang@oracle.com>
  Xiao Liang <shaw.leon@gmail.com>
  Xin Long <lucien.xin@gmail.com>
  yangerkun <yangerkun@huawei.com>
  Yonghong Song <yhs@fb.com>
  Zelin Deng <zelin.deng@linux.alibaba.com>
  zhang kai <zhangkaiheb@126.com>
  Zhihao Cheng <chengzhihao1@huawei.com>
  Zong-Zhe Yang <kevin_yang@realtek.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 fail    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 3743 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Oct 09 08:48:31 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 09 Oct 2021 08:48:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.205081.360333 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZ81h-0003nY-5u; Sat, 09 Oct 2021 08:48:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 205081.360333; Sat, 09 Oct 2021 08:48:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZ81h-0003nR-2p; Sat, 09 Oct 2021 08:48:17 +0000
Received: by outflank-mailman (input) for mailman id 205081;
 Sat, 09 Oct 2021 08:48:16 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ysgi=O5=arm.com=Penny.Zheng@srs-us1.protection.inumbo.net>)
 id 1mZ81g-0003nL-5v
 for xen-devel@lists.xenproject.org; Sat, 09 Oct 2021 08:48:16 +0000
Received: from EUR03-VE1-obe.outbound.protection.outlook.com (unknown
 [40.107.5.66]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id a2dfe04e-28dd-11ec-8087-12813bfff9fa;
 Sat, 09 Oct 2021 08:48:13 +0000 (UTC)
Received: from AM6P191CA0092.EURP191.PROD.OUTLOOK.COM (2603:10a6:209:8a::33)
 by AM9PR08MB6017.eurprd08.prod.outlook.com (2603:10a6:20b:2dc::14) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18; Sat, 9 Oct
 2021 08:48:10 +0000
Received: from VE1EUR03FT031.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:209:8a:cafe::b7) by AM6P191CA0092.outlook.office365.com
 (2603:10a6:209:8a::33) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18 via Frontend
 Transport; Sat, 9 Oct 2021 08:48:10 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT031.mail.protection.outlook.com (10.152.18.69) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4587.18 via Frontend Transport; Sat, 9 Oct 2021 08:48:09 +0000
Received: ("Tessian outbound b9598e0ead92:v103");
 Sat, 09 Oct 2021 08:48:09 +0000
Received: from d2609b8471ed.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 09DC1559-95AC-4171-B2F8-C274DA356610.1; 
 Sat, 09 Oct 2021 08:47:58 +0000
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id d2609b8471ed.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Sat, 09 Oct 2021 08:47:58 +0000
Received: from VE1PR08MB5215.eurprd08.prod.outlook.com (2603:10a6:803:10a::33)
 by VI1PR08MB5439.eurprd08.prod.outlook.com (2603:10a6:803:13b::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.19; Sat, 9 Oct
 2021 08:47:47 +0000
Received: from VE1PR08MB5215.eurprd08.prod.outlook.com
 ([fe80::41d6:b115:3b22:2cd]) by VE1PR08MB5215.eurprd08.prod.outlook.com
 ([fe80::41d6:b115:3b22:2cd%2]) with mapi id 15.20.4587.024; Sat, 9 Oct 2021
 08:47:47 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a2dfe04e-28dd-11ec-8087-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Y5xYXgMml7JzSRR7DiL4SgbSc/e4f4pPjqrdX2mn3FM=;
 b=RzS/DnVW9P4S04TqsEmFs3S4VU6RKsS6ZNNr206s4qoFoEvKkyaYUpuWxTu7Xm5A9zXEtxGKdiMjSWiB6PWWIEKe1u8+DsjfZf+koRkjv/RB0+xvajnVZR9QbSuwxpJZqcBtQC37pzJEhot224jyoYTbVw7GmKqnTXgvjmguDhg=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=gHQFGrofcEZqJYT2rh5MyDen94kgBWLVUYw3/SnCzl6o6ck1SduuF0CukD6bdF69+bVbSUJ/EycjTjo0jGxfTZefSCJd4kp9Arv4WLUrEVV9Vr2JiUv7F/vIVbPTSPUN2JcSXVxbkpSw8dd5lOyFjA1j4ysFNcL6DbNyUekBeNrnXx/7WkVjzk9ngPHZ1tjpoSJmtIqk9tZaqhZ/asyLkiKdSdWyiDWnDUf0Xj4QGJVvJaZYISW9MyJrwY/g59j9eA0ldhgf7Zer2cOUA6QTNZ+jxF1nNqYgur3m7a0xKFT++wW0wD3Y+/+38CZ8FUKLNrNn0NBIA1OCCl1v/MDprA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Y5xYXgMml7JzSRR7DiL4SgbSc/e4f4pPjqrdX2mn3FM=;
 b=oWtbalr8RiCZBZfa8kmiwMnBa10y6RIA+WOszGQAt0+/QeGstiQhGXls0ZwdtYcL7l/sWso63MhHj3fN5tb0Fjs62WDvZXsHmdntVxbvaSWyVN5m9I62XPhsCpKKUa+a4mRenlvN8RfGkIO5QG+5XVNlJEXVCxkbdv1LcQOixsg9H4mTmp1uzUK/VKOyb+O4t8xuNgWkAseUnQC3Kp29b+tnWn3+DMcVA4rlqDnKNXvkzOxsMaRsCHogCqZwB3ot1v2kt0sAVEX+IXf9GqVUqiOdYe0QQpflEYKHejJ2GFUrfImj416/ZV328BoaEQe7Xqjar5NGcnW9ZgwbLEoTEQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Y5xYXgMml7JzSRR7DiL4SgbSc/e4f4pPjqrdX2mn3FM=;
 b=RzS/DnVW9P4S04TqsEmFs3S4VU6RKsS6ZNNr206s4qoFoEvKkyaYUpuWxTu7Xm5A9zXEtxGKdiMjSWiB6PWWIEKe1u8+DsjfZf+koRkjv/RB0+xvajnVZR9QbSuwxpJZqcBtQC37pzJEhot224jyoYTbVw7GmKqnTXgvjmguDhg=
From: Penny Zheng <Penny.Zheng@arm.com>
To: Julien Grall <julien@xen.org>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, "sstabellini@kernel.org"
	<sstabellini@kernel.org>
CC: Bertrand Marquis <Bertrand.Marquis@arm.com>, Wei Chen <Wei.Chen@arm.com>
Subject: RE: [PATCH 09/11] xen/arm: if 1:1 direct-map domain use native UART
 address and IRQ number for vPL011
Thread-Topic: [PATCH 09/11] xen/arm: if 1:1 direct-map domain use native UART
 address and IRQ number for vPL011
Thread-Index: AQHXsCjCE2lhlSGmBkKIt8npCa4pm6uxd+8AgBj2EFA=
Date: Sat, 9 Oct 2021 08:47:46 +0000
Message-ID:
 <VE1PR08MB5215F07156273D0822515E92F7B39@VE1PR08MB5215.eurprd08.prod.outlook.com>
References: <20210923031115.1429719-1-penny.zheng@arm.com>
 <20210923031115.1429719-10-penny.zheng@arm.com>
 <db752d34-fc23-04b3-3c84-12d4de6859e0@xen.org>
In-Reply-To: <db752d34-fc23-04b3-3c84-12d4de6859e0@xen.org>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: 1B9E24456E12764080C74CD1E0ABDD14.0
x-checkrecipientchecked: true
Authentication-Results-Original: xen.org; dkim=none (message not signed)
 header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: 7081610e-c5c8-4241-5f53-08d98b018572
x-ms-traffictypediagnostic: VI1PR08MB5439:|AM9PR08MB6017:
x-ms-exchange-transport-forked: True
X-Microsoft-Antispam-PRVS:
	<AM9PR08MB6017198F73597EB6736FD4D2F7B39@AM9PR08MB6017.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:9508;OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 YN9oPIDjIoj1AicN4RPmYW4X8w9FqtE4d3Fw47dT5DIcaJEbhMcubRaiNqSZtBreAefKpZTBhr8FPbxjGWTMmQyp+u+evBqckY+3+ajee9UNnEyrrBf9N7ew6IYR5GLTKfqGdKcRw3SGMwSqa4VgpMCIEqyCKmFplHwvkNRuheQjUsCW+9GWvIs9cr2dtAKRhaNlwceJQNR9NsFE5UH/HadzUDs+3uczLIhJFqw0Z8kFQ2zCcX08vdG2HwIeCXZ0BwtNF1TtqwQggRwug38S4J/y74Y4yOL1NVsHbG19s0ZIpz6+i819/r6yLwRgZuxmR8h9DcLrkDc7Pz86dEI5Tt9a/IrhASTkDMVWySLriWi2vrFzPOosEiOeBGPcfJqBNhglbq5uzD9jFmMZVVdd73wnAv3+n/CYOQ3H1UUtdjM0X7UoYZ5PyuHricwKAO+mf1XAoxdMumPu5pdC6X4wMBdRLZvtptoMF1/RJXOBpO0D12MOFV6q1dQ68bLEuAd8xUwH7YDCjaIkWmgaIVZY5eMgu559Ntum5Mo7uySS2hlvtK6Kpnhj0qiXgmuWlip0Gu4riGct7w2Yi7EI3dQySsxYdSZu3loRcDvXkpdgpM4Z0xItrYk1fFAHqpbovkjYMPYnKFN27xB2bcL7QBEsPgGLOcW+OmZYQbi99bfy8W0Mp1jWaFOr89twY96fQt3BQamnAFlEK/yLV9vWOzQccQ==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR08MB5215.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(38070700005)(186003)(33656002)(83380400001)(52536014)(26005)(64756008)(66556008)(7696005)(53546011)(6506007)(66446008)(66476007)(66946007)(8936002)(316002)(76116006)(2906002)(110136005)(54906003)(71200400001)(8676002)(9686003)(38100700002)(122000001)(4326008)(5660300002)(55016002)(86362001)(508600001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB5439
Original-Authentication-Results: xen.org; dkim=none (message not signed)
 header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT031.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	6871be29-1006-4282-994d-08d98b0177d2
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Q7+/5/v7M7yAqTNl30ba7rHraMW5mKZL2r3/vnpia/fh+BC19+Au6fdKrGjsVkotP0KWkR2xt/cswXcsfefebH3aEH5hudOB3fHtFrJFxMJgBC4quOPM9xS/W9LaewvcnomkVnAnEYNmpEVfzqIJidMoQg36cBYN2zBjWP07PZd1dVVoZuLQpfzggSu4RM1YD6X4AJa4vufGf4vWr+l4B3rcQW6rRjqNCCSuagi1HvQRsRMI5m/3k4p0C3BIQdK0t8DR5bIKwP6mVrRRhUtD0gKluXwRrPHfdUeq1uUKQ3/lLLncdYfxu3IUCAT06XUWOLQ2DgPQwGzWR3taFUWvavHbydp2NhEVExcKm39/yNrKBjj+MiesUONSsg5IrD+M7h11rSwqYkicxdgqDF35tKs5m+i1LtMAO6PanWabQIsf4eiJFVi/xNZSrbsdU5yni8TO7GbcmqtmmzX1Hbb1qlsZ4GPrFhmUOEDWNTMt/n/0YyF4K28jJC0BJf+cFk0KTP9ACaSZKVw1Zd48uR53THUKm9wn3SZy11+Q9CVUgNv0uBTzopWjmxxtV8poJjGckpypTwZKBL95UloIhVRQHcnL8RfTojuY3cpDsuZCzqrWuTeCFUlDzcyoewsY0hRXOzFBLFJkbFIy5eTXKs0yBh52+qYJQHV6dz+56U5m1HImSrvhRDBVJfH1JFoJIO4oVQBJkOeIB4gwDeb76DeINg==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(4326008)(8676002)(5660300002)(36860700001)(70206006)(70586007)(508600001)(81166007)(86362001)(356005)(8936002)(55016002)(336012)(316002)(7696005)(53546011)(6506007)(186003)(52536014)(54906003)(110136005)(83380400001)(33656002)(2906002)(82310400003)(47076005)(26005)(9686003);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Oct 2021 08:48:09.8289
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 7081610e-c5c8-4241-5f53-08d98b018572
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT031.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB6017

SGkgSnVsaWVuDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogSnVsaWVu
IEdyYWxsIDxqdWxpZW5AeGVuLm9yZz4NCj4gU2VudDogVGh1cnNkYXksIFNlcHRlbWJlciAyMywg
MjAyMSA3OjE0IFBNDQo+IFRvOiBQZW5ueSBaaGVuZyA8UGVubnkuWmhlbmdAYXJtLmNvbT47IHhl
bi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZzsNCj4gc3N0YWJlbGxpbmlAa2VybmVsLm9yZw0K
PiBDYzogQmVydHJhbmQgTWFycXVpcyA8QmVydHJhbmQuTWFycXVpc0Bhcm0uY29tPjsgV2VpIENo
ZW4NCj4gPFdlaS5DaGVuQGFybS5jb20+DQo+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggMDkvMTFdIHhl
bi9hcm06IGlmIDE6MSBkaXJlY3QtbWFwIGRvbWFpbiB1c2UgbmF0aXZlDQo+IFVBUlQgYWRkcmVz
cyBhbmQgSVJRIG51bWJlciBmb3IgdlBMMDExDQo+IA0KPiANCj4gDQo+IE9uIDIzLzA5LzIwMjEg
MDg6MTEsIFBlbm55IFpoZW5nIHdyb3RlOg0KPiA+IEZyb206IFN0ZWZhbm8gU3RhYmVsbGluaSA8
c3RlZmFuby5zdGFiZWxsaW5pQHhpbGlueC5jb20+DQo+ID4NCj4gPiBXZSBhbHdheXMgdXNlIGEg
Zml4IGFkZHJlc3MgdG8gbWFwIHRoZSB2UEwwMTEgdG8gZG9tYWlucy4gVGhlIGFkZHJlc3MNCj4g
PiBjb3VsZCBiZSBhIHByb2JsZW0gZm9yIGRvbWFpbnMgdGhhdCBhcmUgZGlyZWN0bHkgbWFwcGVk
Lg0KPiA+DQo+ID4gU28sIGZvciBkb21haW5zIHRoYXQgYXJlIGRpcmVjdGx5IG1hcHBlZCwgcmV1
c2UgdGhlIGFkZHJlc3Mgb2YgdGhlDQo+ID4gcGh5c2ljYWwgVUFSVCBvbiB0aGUgcGxhdGZvcm0g
dG8gYXZvaWQgcG90ZW50aWFsIGNsYXNoZXMuDQo+ID4NCj4gPiBEbyB0aGUgc2FtZSBmb3IgdGhl
IHZpcnR1YWwgSVJRIG51bWJlcjogaW5zdGVhZCBvZiBhbHdheXMgdXNpbmcNCj4gPiBHVUVTVF9W
UEwwMTFfU1BJLCB0cnkgdG8gcmV1c2UgdGhlIHBoeXNpY2FsIFNQSSBudW1iZXIgaWYgcG9zc2li
bGUuDQo+ID4NCj4gPiBTaWduZWQtb2ZmLWJ5OiBTdGVmYW5vIFN0YWJlbGxpbmkgPHN0ZWZhbm8u
c3RhYmVsbGluaUB4aWxpbnguY29tPg0KPiA+IFNpZ25lZC1vZmYtYnk6IFBlbm55IFpoZW5nIDxw
ZW5ueS56aGVuZ0Bhcm0uY29tPg0KPiA+IC0tLQ0KPiA+ICAgeGVuL2FyY2gvYXJtL2RvbWFpbl9i
dWlsZC5jICB8IDM0ICsrKysrKysrKysrKysrKysrKysrKysrKysrKy0tLS0tLS0NCj4gPiAgIHhl
bi9hcmNoL2FybS92cGwwMTEuYyAgICAgICAgfCAzNCArKysrKysrKysrKysrKysrKysrKysrKysr
KystLS0tLS0tDQo+ID4gICB4ZW4vaW5jbHVkZS9hc20tYXJtL3ZwbDAxMS5oIHwgIDIgKysNCj4g
PiAgIDMgZmlsZXMgY2hhbmdlZCwgNTYgaW5zZXJ0aW9ucygrKSwgMTQgZGVsZXRpb25zKC0pDQo+
ID4NCj4gPiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gvYXJtL2RvbWFpbl9idWlsZC5jIGIveGVuL2Fy
Y2gvYXJtL2RvbWFpbl9idWlsZC5jDQo+ID4gaW5kZXggMTIwZjFhZTU3NS4uYzkyZTUxMGFlNyAx
MDA2NDQNCj4gPiAtLS0gYS94ZW4vYXJjaC9hcm0vZG9tYWluX2J1aWxkLmMNCj4gPiArKysgYi94
ZW4vYXJjaC9hcm0vZG9tYWluX2J1aWxkLmMNCj4gPiBAQCAtMzAsNiArMzAsNyBAQA0KPiA+DQo+
ID4gICAjaW5jbHVkZSA8eGVuL2lycS5oPg0KPiA+ICAgI2luY2x1ZGUgPHhlbi9ncmFudF90YWJs
ZS5oPg0KPiA+ICsjaW5jbHVkZSA8eGVuL3NlcmlhbC5oPg0KPiA+DQo+ID4gICBzdGF0aWMgdW5z
aWduZWQgaW50IF9faW5pdGRhdGEgb3B0X2RvbTBfbWF4X3ZjcHVzOw0KPiA+ICAgaW50ZWdlcl9w
YXJhbSgiZG9tMF9tYXhfdmNwdXMiLCBvcHRfZG9tMF9tYXhfdmNwdXMpOyBAQCAtMTk0Miw4DQo+
ID4gKzE5NDMsMTEgQEAgc3RhdGljIGludCBfX2luaXQgbWFrZV92cGwwMTFfdWFydF9ub2RlKHN0
cnVjdCBrZXJuZWxfaW5mbw0KPiAqa2luZm8pDQo+ID4gICAgICAgZ2ljX2ludGVycnVwdF90IGlu
dHI7DQo+ID4gICAgICAgX19iZTMyIHJlZ1tHVUVTVF9ST09UX0FERFJFU1NfQ0VMTFMgKyBHVUVT
VF9ST09UX1NJWkVfQ0VMTFNdOw0KPiA+ICAgICAgIF9fYmUzMiAqY2VsbHM7DQo+ID4gKyAgICBz
dHJ1Y3QgZG9tYWluICpkID0ga2luZm8tPmQ7DQo+ID4gKyAgICBjaGFyIGJ1ZlsyN107DQo+ID4N
Cj4gPiAtICAgIHJlcyA9IGZkdF9iZWdpbl9ub2RlKGZkdCwgInNic2EtdWFydEAiX19zdHJpbmdp
ZnkoR1VFU1RfUEwwMTFfQkFTRSkpOw0KPiA+ICsgICAgc25wcmludGYoYnVmLCBzaXplb2YoYnVm
KSwgInNic2EtdWFydEAlIlBSSXg2NCwgZC0NCj4gPmFyY2gudnBsMDExLmJhc2VfYWRkcik7DQo+
ID4gKyAgICByZXMgPSBmZHRfYmVnaW5fbm9kZShmZHQsIGJ1Zik7DQo+ID4gICAgICAgaWYgKCBy
ZXMgKQ0KPiA+ICAgICAgICAgICByZXR1cm4gcmVzOw0KPiA+DQo+ID4gQEAgLTE5NTMsMTQgKzE5
NTcsMTQgQEAgc3RhdGljIGludCBfX2luaXQgbWFrZV92cGwwMTFfdWFydF9ub2RlKHN0cnVjdA0K
PiA+IGtlcm5lbF9pbmZvICpraW5mbykNCj4gPg0KPiA+ICAgICAgIGNlbGxzID0gJnJlZ1swXTsN
Cj4gPiAgICAgICBkdF9jaGlsZF9zZXRfcmFuZ2UoJmNlbGxzLCBHVUVTVF9ST09UX0FERFJFU1Nf
Q0VMTFMsDQo+ID4gLSAgICAgICAgICAgICAgICAgICAgICAgR1VFU1RfUk9PVF9TSVpFX0NFTExT
LCBHVUVTVF9QTDAxMV9CQVNFLA0KPiA+ICsgICAgICAgICAgICAgICAgICAgICAgIEdVRVNUX1JP
T1RfU0laRV9DRUxMUywNCj4gPiArIGQtPmFyY2gudnBsMDExLmJhc2VfYWRkciwNCj4gPiAgICAg
ICAgICAgICAgICAgICAgICAgICAgR1VFU1RfUEwwMTFfU0laRSk7DQo+ID4NCj4gPiAgICAgICBy
ZXMgPSBmZHRfcHJvcGVydHkoZmR0LCAicmVnIiwgcmVnLCBzaXplb2YocmVnKSk7DQo+ID4gICAg
ICAgaWYgKCByZXMgKQ0KPiA+ICAgICAgICAgICByZXR1cm4gcmVzOw0KPiA+DQo+ID4gLSAgICBz
ZXRfaW50ZXJydXB0KGludHIsIEdVRVNUX1ZQTDAxMV9TUEksIDB4ZiwgRFRfSVJRX1RZUEVfTEVW
RUxfSElHSCk7DQo+ID4gKyAgICBzZXRfaW50ZXJydXB0KGludHIsIGQtPmFyY2gudnBsMDExLnZp
cnEsIDB4ZiwNCj4gPiArIERUX0lSUV9UWVBFX0xFVkVMX0hJR0gpOw0KPiA+DQo+ID4gICAgICAg
cmVzID0gZmR0X3Byb3BlcnR5KGZkdCwgImludGVycnVwdHMiLCBpbnRyLCBzaXplb2YgKGludHIp
KTsNCj4gPiAgICAgICBpZiAoIHJlcyApDQo+ID4gQEAgLTI2NzAsNiArMjY3NCwxMyBAQCBzdGF0
aWMgaW50IF9faW5pdCBjb25zdHJ1Y3RfZG9tVShzdHJ1Y3QgZG9tYWluDQo+ICpkLA0KPiA+ICAg
ICAgIGVsc2UNCj4gPiAgICAgICAgICAgYWxsb2NhdGVfc3RhdGljX21lbW9yeShkLCAma2luZm8s
IG5vZGUpOw0KPiA+DQo+ID4gKyAgICAvKg0KPiA+ICsgICAgICogSW5pdGlhbGl6YXRpb24gYmVm
b3JlIGNyZWF0aW5nIGl0cyBkZXZpY2UNCj4gPiArICAgICAqIHRyZWUgbm9kZSBpbiBwcmVwYXJl
X2R0Yl9kb21VLg0KPiA+ICsgICAgICovDQo+IA0KPiBJIHRoaW5rIGl0IHdvdWxkIGJlIGJldHRl
ciB0byBleHBsYWluICp3aHkqIHRoaXMgbmVlZHMgdG8gYmUgZG9uZSBiZWZvcmUuDQo+IA0KPiA+
ICsgICAgaWYgKCBraW5mby52cGwwMTEgKQ0KPiA+ICsgICAgICAgIHJjID0gZG9tYWluX3ZwbDAx
MV9pbml0KGQsIE5VTEwpOw0KPiA+ICsNCj4gPiAgICAgICByYyA9IHByZXBhcmVfZHRiX2RvbVUo
ZCwgJmtpbmZvKTsNCj4gPiAgICAgICBpZiAoIHJjIDwgMCApDQo+ID4gICAgICAgICAgIHJldHVy
biByYzsNCj4gPiBAQCAtMjY3OCw5ICsyNjg5LDYgQEAgc3RhdGljIGludCBfX2luaXQgY29uc3Ry
dWN0X2RvbVUoc3RydWN0IGRvbWFpbg0KPiAqZCwNCj4gPiAgICAgICBpZiAoIHJjIDwgMCApDQo+
ID4gICAgICAgICAgIHJldHVybiByYzsNCj4gPg0KPiA+IC0gICAgaWYgKCBraW5mby52cGwwMTEg
KQ0KPiA+IC0gICAgICAgIHJjID0gZG9tYWluX3ZwbDAxMV9pbml0KGQsIE5VTEwpOw0KPiA+IC0N
Cj4gPiAgICAgICByZXR1cm4gcmM7DQo+ID4gICB9DQo+ID4NCj4gPiBAQCAtMjcyMywxNSArMjcz
MSwyNyBAQCB2b2lkIF9faW5pdCBjcmVhdGVfZG9tVXModm9pZCkNCj4gPg0KPiA+ICAgICAgICAg
ICBpZiAoICFkdF9wcm9wZXJ0eV9yZWFkX3UzMihub2RlLCAibnJfc3BpcyIsICZkX2NmZy5hcmNo
Lm5yX3NwaXMpICkNCj4gPiAgICAgICAgICAgew0KPiA+ICsgICAgICAgICAgICB1bnNpZ25lZCBp
bnQgdnBsMDExX3ZpcnEgPSBHVUVTVF9WUEwwMTFfU1BJOw0KPiANCj4gQ29kaW5nIHN0eWxlOiBB
ZGQgYSBuZXdsaW5lIGhlcmUuDQo+IA0KPiA+ICAgICAgICAgICAgICAgZF9jZmcuYXJjaC5ucl9z
cGlzID0gZ2ljX251bWJlcl9saW5lcygpIC0gMzI7DQo+ID4NCj4gPiArICAgICAgICAgICAgLyoN
Cj4gPiArICAgICAgICAgICAgICogVGhlIFZQTDAxMSB2aXJxIGlzIEdVRVNUX1ZQTDAxMV9TUEks
IHVubGVzcyBkaXJlY3QtbWFwIGluDQo+ID4gKyAgICAgICAgICAgICAqIHNldCwgaW4gd2hpY2gg
Y2FzZSB3ZSdsbCB0cnkgdG8gbWF0Y2ggdGhlIGhhcmR3YXJlLg0KPiA+ICsgICAgICAgICAgICAg
Kg0KPiA+ICsgICAgICAgICAgICAgKiBUeXBpY2FsbHksIGQtPmFyY2gudnBsMDExLnZpcnEgaGFz
IHRoZSB2cGwwMTEgaXJxIG51bWJlcg0KPiA+ICsgICAgICAgICAgICAgKiBidXQgYXQgdGhpcyBw
b2ludCBvZiB0aGUgYm9vdCBzZXF1ZW5jZSBpdCBpcyBub3QNCj4gPiArICAgICAgICAgICAgICog
aW5pdGlhbGl6ZWQgeWV0Lg0KPiA+ICsgICAgICAgICAgICAgKi8NCj4gPiArICAgICAgICAgICAg
aWYgKCBkaXJlY3RfbWFwICYmIHNlcmlhbF9pcnEoU0VSSE5EX0RUVUFSVCkgPiAwICkNCj4gPiAr
ICAgICAgICAgICAgICAgIHZwbDAxMV92aXJxID0gc2VyaWFsX2lycShTRVJITkRfRFRVQVJUKTsN
Cj4gDQo+IEkgdGhpbmsgd2Ugc2hvdWxkIG5vdCBjb250aW51ZSBpZiB0aGUgZG9tYWluIGlzIGRp
cmVjdC1tYXBwZWQgKmFuZCogdGhlIElSUQ0KPiBpcyBub3QgZm91bmQuIE90aGVyd2lzZSwgdGhp
cyB3aWxsIG1heSBqdXN0IHJlc3VsdCB0byBwb3RlbnRpYWwgYnJlYWthZ2UgaWYNCj4gR1VFU1Rf
VlBMMDExX1NQSSBoYXBwZW5zIHRvIGJlIHVzZWQgZm9yIGFuIEhXIGRldmljZS4NCj4gDQo+ID4g
Kw0KPiA+ICAgICAgICAgICAgICAgLyoNCj4gPiAgICAgICAgICAgICAgICAqIHZwbDAxMSB1c2Vz
IG9uZSBlbXVsYXRlZCBTUEkuIElmIHZwbDAxMSBpcyByZXF1ZXN0ZWQsIG1ha2UNCj4gPiAgICAg
ICAgICAgICAgICAqIHN1cmUgdGhhdCB3ZSBhbGxvY2F0ZSBlbm91Z2ggU1BJcyBmb3IgaXQuDQo+
ID4gICAgICAgICAgICAgICAgKi8NCj4gPiAgICAgICAgICAgICAgIGlmICggZHRfcHJvcGVydHlf
cmVhZF9ib29sKG5vZGUsICJ2cGwwMTEiKSApDQo+ID4gICAgICAgICAgICAgICAgICAgZF9jZmcu
YXJjaC5ucl9zcGlzID0gTUFYKGRfY2ZnLmFyY2gubnJfc3BpcywNCj4gPiAtICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBHVUVTVF9WUEwwMTFfU1BJIC0gMzIgKyAxKTsN
Cj4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB2cGwwMTFfdmly
cSAtIDMyICsgMSk7DQo+ID4gICAgICAgICAgIH0NCj4gPg0KPiA+ICAgICAgICAgICAvKg0KPiA+
IGRpZmYgLS1naXQgYS94ZW4vYXJjaC9hcm0vdnBsMDExLmMgYi94ZW4vYXJjaC9hcm0vdnBsMDEx
LmMgaW5kZXgNCj4gPiA4OTVmNDM2Y2M0Li4xMGRmMjVmMDk4IDEwMDY0NA0KPiA+IC0tLSBhL3hl
bi9hcmNoL2FybS92cGwwMTEuYw0KPiA+ICsrKyBiL3hlbi9hcmNoL2FybS92cGwwMTEuYw0KPiA+
IEBAIC0yOSw2ICsyOSw3IEBADQo+ID4gICAjaW5jbHVkZSA8eGVuL21tLmg+DQo+ID4gICAjaW5j
bHVkZSA8eGVuL3NjaGVkLmg+DQo+ID4gICAjaW5jbHVkZSA8eGVuL2NvbnNvbGUuaD4NCj4gPiAr
I2luY2x1ZGUgPHhlbi9zZXJpYWwuaD4NCj4gPiAgICNpbmNsdWRlIDxwdWJsaWMvZG9tY3RsLmg+
DQo+ID4gICAjaW5jbHVkZSA8cHVibGljL2lvL2NvbnNvbGUuaD4NCj4gPiAgICNpbmNsdWRlIDxh
c20vcGwwMTEtdWFydC5oPg0KPiA+IEBAIC03MSwxMSArNzIsMTEgQEAgc3RhdGljIHZvaWQgdnBs
MDExX3VwZGF0ZV9pbnRlcnJ1cHRfc3RhdHVzKHN0cnVjdA0KPiBkb21haW4gKmQpDQo+ID4gICAg
ICAgICogc3RhdHVzIGJpdCBoYXMgYmVlbiBzZXQgc2luY2UgdGhlIGxhc3QgdGltZS4NCj4gPiAg
ICAgICAgKi8NCj4gPiAgICAgICBpZiAoIHVhcnRtaXMgJiB+dnBsMDExLT5zaGFkb3dfdWFydG1p
cyApDQo+ID4gLSAgICAgICAgdmdpY19pbmplY3RfaXJxKGQsIE5VTEwsIEdVRVNUX1ZQTDAxMV9T
UEksIHRydWUpOw0KPiA+ICsgICAgICAgIHZnaWNfaW5qZWN0X2lycShkLCBOVUxMLCB2cGwwMTEt
PnZpcnEsIHRydWUpOw0KPiA+DQo+ID4gICAgICAgdnBsMDExLT5zaGFkb3dfdWFydG1pcyA9IHVh
cnRtaXM7DQo+ID4gICAjZWxzZQ0KPiA+IC0gICAgdmdpY19pbmplY3RfaXJxKGQsIE5VTEwsIEdV
RVNUX1ZQTDAxMV9TUEksIHVhcnRtaXMpOw0KPiA+ICsgICAgdmdpY19pbmplY3RfaXJxKGQsIE5V
TEwsIHZwbDAxMS0+dmlycSwgdWFydG1pcyk7DQo+ID4gICAjZW5kaWYNCj4gPiAgIH0NCj4gPg0K
PiA+IEBAIC0zNDcsNyArMzQ4LDggQEAgc3RhdGljIGludCB2cGwwMTFfbW1pb19yZWFkKHN0cnVj
dCB2Y3B1ICp2LA0KPiA+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHZvaWQgKnByaXYp
DQo+ID4gICB7DQo+ID4gICAgICAgc3RydWN0IGhzcl9kYWJ0IGRhYnQgPSBpbmZvLT5kYWJ0Ow0K
PiA+IC0gICAgdWludDMyX3QgdnBsMDExX3JlZyA9ICh1aW50MzJfdCkoaW5mby0+Z3BhIC0gR1VF
U1RfUEwwMTFfQkFTRSk7DQo+ID4gKyAgICB1aW50MzJfdCB2cGwwMTFfcmVnID0gKHVpbnQzMl90
KShpbmZvLT5ncGEgLQ0KPiA+ICsNCj4gPiArIHYtPmRvbWFpbi0+YXJjaC52cGwwMTEuYmFzZV9h
ZGRyKTsNCj4gPiAgICAgICBzdHJ1Y3QgdnBsMDExICp2cGwwMTEgPSAmdi0+ZG9tYWluLT5hcmNo
LnZwbDAxMTsNCj4gPiAgICAgICBzdHJ1Y3QgZG9tYWluICpkID0gdi0+ZG9tYWluOw0KPiA+ICAg
ICAgIHVuc2lnbmVkIGxvbmcgZmxhZ3M7DQo+ID4gQEAgLTQzMCw3ICs0MzIsOCBAQCBzdGF0aWMg
aW50IHZwbDAxMV9tbWlvX3dyaXRlKHN0cnVjdCB2Y3B1ICp2LA0KPiA+ICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICB2b2lkICpwcml2KQ0KPiA+ICAgew0KPiA+ICAgICAgIHN0cnVjdCBo
c3JfZGFidCBkYWJ0ID0gaW5mby0+ZGFidDsNCj4gPiAtICAgIHVpbnQzMl90IHZwbDAxMV9yZWcg
PSAodWludDMyX3QpKGluZm8tPmdwYSAtIEdVRVNUX1BMMDExX0JBU0UpOw0KPiA+ICsgICAgdWlu
dDMyX3QgdnBsMDExX3JlZyA9ICh1aW50MzJfdCkoaW5mby0+Z3BhIC0NCj4gPiArDQo+ID4gKyB2
LT5kb21haW4tPmFyY2gudnBsMDExLmJhc2VfYWRkcik7DQo+ID4gICAgICAgc3RydWN0IHZwbDAx
MSAqdnBsMDExID0gJnYtPmRvbWFpbi0+YXJjaC52cGwwMTE7DQo+ID4gICAgICAgc3RydWN0IGRv
bWFpbiAqZCA9IHYtPmRvbWFpbjsNCj4gPiAgICAgICB1bnNpZ25lZCBsb25nIGZsYWdzOw0KPiA+
IEBAIC02MjIsMTAgKzYyNSwyNyBAQCBpbnQgZG9tYWluX3ZwbDAxMV9pbml0KHN0cnVjdCBkb21h
aW4gKmQsIHN0cnVjdA0KPiB2cGwwMTFfaW5pdF9pbmZvICppbmZvKQ0KPiA+ICAgew0KPiA+ICAg
ICAgIGludCByYzsNCj4gPiAgICAgICBzdHJ1Y3QgdnBsMDExICp2cGwwMTEgPSAmZC0+YXJjaC52
cGwwMTE7DQo+ID4gKyAgICBjb25zdCBzdHJ1Y3QgdnVhcnRfaW5mbyAqdWFydCA9IHNlcmlhbF92
dWFydF9pbmZvKFNFUkhORF9EVFVBUlQpOw0KPiA+DQo+ID4gICAgICAgaWYgKCB2cGwwMTEtPmJh
Y2tlbmQuZG9tLnJpbmdfYnVmICkNCj4gPiAgICAgICAgICAgcmV0dXJuIC1FSU5WQUw7DQo+ID4N
Cj4gPiArICAgIHZwbDAxMS0+YmFzZV9hZGRyID0gR1VFU1RfUEwwMTFfQkFTRTsNCj4gPiArICAg
IHZwbDAxMS0+dmlycSA9IEdVRVNUX1ZQTDAxMV9TUEk7DQo+ID4gKyAgICBpZiAoIGlzX2RvbWFp
bl9kaXJlY3RfbWFwcGVkKGQpICkNCj4gPiArICAgIHsNCj4gPiArICAgICAgICBpZiAoIHVhcnQg
IT0gTlVMTCAmJiBzZXJpYWxfaXJxKFNFUkhORF9EVFVBUlQpID4gMCApDQo+ID4gKyAgICAgICAg
ew0KPiA+ICsgICAgICAgICAgICB2cGwwMTEtPmJhc2VfYWRkciA9IHVhcnQtPmJhc2VfYWRkcjsN
Cj4gPiArICAgICAgICAgICAgdnBsMDExLT52aXJxID0gc2VyaWFsX2lycShTRVJITkRfRFRVQVJU
KTsNCj4gDQo+IFRoaXMgc2VlbXMgYSBiaXQgcG9pbnRsZXNzIHRvIGNhbGwgc2VyaWFsX2lycSgp
IHR3aWNlLiBIb3cgYWJvdXQgYWRkIGEgZmllbGQgaW4NCj4gdnVhcnRfaW5mbyB0byByZXR1cm4g
dGhlIGludGVycnVwdCBudW1iZXI/DQo+IA0KPiA+ICsgICAgICAgIH0NCj4gPiArICAgICAgICBl
bHNlDQo+ID4gKyAgICAgICAgICAgIHByaW50ayhYRU5MT0dfRVJSDQo+ID4gKyAgICAgICAgICAg
ICAgICAgICAiVW5hYmxlIHRvIHJldXNlIHBoeXNpY2FsIFVBUlQgYWRkcmVzcyBhbmQgaXJxIGZv
ciB2UEwwMTEuXG4iDQo+ID4gKyAgICAgICAgICAgICAgICAgICAiRGVmYXVsdGluZyB0byBhZGRy
ICUjIlBSSXBhZGRyIiBhbmQgSVJRICV1XG4iLA0KPiA+ICsgICAgICAgICAgICAgICAgICAgdnBs
MDExLT5iYXNlX2FkZHIsIHZwbDAxMS0+dmlycSk7DQo+ID4gKyAgICB9DQo+ID4gKw0KPiA+ICAg
ICAgIC8qDQo+ID4gICAgICAgICogaW5mbyBpcyBOVUxMIHdoZW4gdGhlIGJhY2tlbmQgaXMgaW4g
WGVuLg0KPiA+ICAgICAgICAqIGluZm8gaXMgIT0gTlVMTCB3aGVuIHRoZSBiYWNrZW5kIGlzIGlu
IGEgZG9tYWluLg0KPiA+IEBAIC02NjEsNyArNjgxLDcgQEAgaW50IGRvbWFpbl92cGwwMTFfaW5p
dChzdHJ1Y3QgZG9tYWluICpkLCBzdHJ1Y3QNCj4gdnBsMDExX2luaXRfaW5mbyAqaW5mbykNCj4g
PiAgICAgICAgICAgfQ0KPiA+ICAgICAgIH0NCj4gPg0KPiA+IC0gICAgcmMgPSB2Z2ljX3Jlc2Vy
dmVfdmlycShkLCBHVUVTVF9WUEwwMTFfU1BJKTsNCj4gPiArICAgIHJjID0gdmdpY19yZXNlcnZl
X3ZpcnEoZCwgdnBsMDExLT52aXJxKTsNCj4gPiAgICAgICBpZiAoICFyYyApDQo+ID4gICAgICAg
ew0KPiA+ICAgICAgICAgICByYyA9IC1FSU5WQUw7DQo+ID4gQEAgLTY3MywxMiArNjkzLDEyIEBA
IGludCBkb21haW5fdnBsMDExX2luaXQoc3RydWN0IGRvbWFpbiAqZCwgc3RydWN0DQo+IHZwbDAx
MV9pbml0X2luZm8gKmluZm8pDQo+ID4gICAgICAgc3Bpbl9sb2NrX2luaXQoJnZwbDAxMS0+bG9j
ayk7DQo+ID4NCj4gPiAgICAgICByZWdpc3Rlcl9tbWlvX2hhbmRsZXIoZCwgJnZwbDAxMV9tbWlv
X2hhbmRsZXIsDQo+ID4gLSAgICAgICAgICAgICAgICAgICAgICAgICAgR1VFU1RfUEwwMTFfQkFT
RSwgR1VFU1RfUEwwMTFfU0laRSwgTlVMTCk7DQo+ID4gKyAgICAgICAgICAgICAgICAgICAgICAg
ICAgdnBsMDExLT5iYXNlX2FkZHIsIEdVRVNUX1BMMDExX1NJWkUsIE5VTEwpOw0KPiANCj4gU28g
eW91IGFyZSBtYWtpbmcgdGhlIGFzc3VtcHB0aW9uIHRoYXQgdGhlIFVBUlQgcmVnaW9uIHdpbGwg
YmUgZXF1YWwgdG8gKG9yDQo+IGJpZ2dlcikgdGhhbiBHVUVTVF9QTDAxMV9TSVpFLiBUaGVyZSBh
cmUgZGVmaW5pdGVseSBVQVJUIG91dCB3aGVyZSB0aGUNCj4gTU1JTyByZWdpb24gaXMgc21hbGxl
ciB0aGFuIDRLLg0KPiANCg0KU29ycnkuIEkgZ290IGEgZmV3IGNvbmZ1c2VkIGhlcmUsIHNpbmNl
IEkgYW0gbm90IHZlcnkgZmFtaWxpYXIgd2l0aCBwbDAxMS9VQVJUIGtub3dsZWRnZS4NCg0KUHJv
YmxlbXMgd2lsbCBvY2N1ciB3aGVuIFVBUlQgcmVnaW9uIGlzIGJpZ2dlciB0aGFuIEdVRVNUX1BM
MDExX1NJWkUsIHNpbmNlIHdlDQphcmUgb25seSBjb25zaWRlcmluZyBNTUlPIHJlZ2lvbiBvZiBb
dnBsMDExLT5iYXNlX2FkZHIsIHZwbDAxMS0+YmFzZV9hZGRyICsgR1VFU1RfUEwwMTFfU0laRV0s
IHJpZ2h0Pw0KDQpTbyBJIHNoYWxsIGFkZCB0aGUganVzdGlmaWNhdGlvbiBsaWtlDQpBU1NFUlQo
dWFydC0+c2l6ZSA8PSBHVUVTVF9QTDAxMV9TSVpFKTsNCg0KPiBBbHRob3VnaCwgSSBkb24ndCBl
eHBlY3QgdGhlbSB0byBiZSBwYXNzdGhyb3VnaCB0b2RheS4gU28gdGhpcyBpcyBwcm9iYWJseQ0K
PiBmaW5lIHRvIGFzc3VtZSB0aGF0IHRoZSBuZXh0IDRLIGlzIGZyZWUuIENhbiB5b3UgYWRkIHNv
bWUganVzdGlmaWNhdGlvbiBpbi0NCj4gY29kZSBhbmQgaW4gdGhlIGNvbW1pdCBtZXNzYWdlPw0K
PiANCj4gPg0KPiA+ICAgICAgIHJldHVybiAwOw0KPiA+DQo+ID4gICBvdXQyOg0KPiA+IC0gICAg
dmdpY19mcmVlX3ZpcnEoZCwgR1VFU1RfVlBMMDExX1NQSSk7DQo+ID4gKyAgICB2Z2ljX2ZyZWVf
dmlycShkLCB2cGwwMTEtPnZpcnEpOw0KPiA+DQo+ID4gICBvdXQxOg0KPiA+ICAgICAgIGlmICgg
dnBsMDExLT5iYWNrZW5kX2luX2RvbWFpbiApIGRpZmYgLS1naXQNCj4gPiBhL3hlbi9pbmNsdWRl
L2FzbS1hcm0vdnBsMDExLmggYi94ZW4vaW5jbHVkZS9hc20tYXJtL3ZwbDAxMS5oIGluZGV4DQo+
ID4gZTZjN2FiNzM4MS4uYzA5YWJjZDdhOSAxMDA2NDQNCj4gPiAtLS0gYS94ZW4vaW5jbHVkZS9h
c20tYXJtL3ZwbDAxMS5oDQo+ID4gKysrIGIveGVuL2luY2x1ZGUvYXNtLWFybS92cGwwMTEuaA0K
PiA+IEBAIC01Myw2ICs1Myw4IEBAIHN0cnVjdCB2cGwwMTEgew0KPiA+ICAgICAgIHVpbnQzMl90
ICAgIHVhcnRpY3I7ICAgICAgICAvKiBJbnRlcnJ1cHQgY2xlYXIgcmVnaXN0ZXIgKi8NCj4gPiAg
ICAgICB1aW50MzJfdCAgICB1YXJ0cmlzOyAgICAgICAgLyogUmF3IGludGVycnVwdCBzdGF0dXMg
cmVnaXN0ZXIgKi8NCj4gPiAgICAgICB1aW50MzJfdCAgICBzaGFkb3dfdWFydG1pczsgLyogc2hh
ZG93IG1hc2tlZCBpbnRlcnJ1cHQgcmVnaXN0ZXIgKi8NCj4gPiArICAgIHBhZGRyX3QgICAgIGJh
c2VfYWRkcjsNCj4gPiArICAgIHVuc2lnbmVkIGludCB2aXJxOw0KPiA+ICAgICAgIHNwaW5sb2Nr
X3QgIGxvY2s7DQo+ID4gICAgICAgZXZ0Y2huX3BvcnRfdCBldnRjaG47DQo+ID4gICB9Ow0KPiA+
DQo+IA0KPiBDaGVlcnMsDQo+IA0KPiAtLQ0KPiBKdWxpZW4gR3JhbGwNCg==


From xen-devel-bounces@lists.xenproject.org Sat Oct 09 09:41:09 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 09 Oct 2021 09:41:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.205090.360344 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZ8qj-00017k-SJ; Sat, 09 Oct 2021 09:41:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 205090.360344; Sat, 09 Oct 2021 09:41:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZ8qj-00017d-PB; Sat, 09 Oct 2021 09:41:01 +0000
Received: by outflank-mailman (input) for mailman id 205090;
 Sat, 09 Oct 2021 09:41:01 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ysgi=O5=arm.com=Penny.Zheng@srs-us1.protection.inumbo.net>)
 id 1mZ8qj-00017X-Cc
 for xen-devel@lists.xenproject.org; Sat, 09 Oct 2021 09:41:01 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com (unknown
 [40.107.7.41]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 0ecdfa06-00f8-4c44-8784-84243e11fde7;
 Sat, 09 Oct 2021 09:40:57 +0000 (UTC)
Received: from DB6P193CA0016.EURP193.PROD.OUTLOOK.COM (2603:10a6:6:29::26) by
 VI1PR0802MB2416.eurprd08.prod.outlook.com (2603:10a6:800:bb::7) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.19; Sat, 9 Oct
 2021 09:40:54 +0000
Received: from DB5EUR03FT006.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:6:29:cafe::93) by DB6P193CA0016.outlook.office365.com
 (2603:10a6:6:29::26) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.24 via Frontend
 Transport; Sat, 9 Oct 2021 09:40:54 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT006.mail.protection.outlook.com (10.152.20.106) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4587.18 via Frontend Transport; Sat, 9 Oct 2021 09:40:54 +0000
Received: ("Tessian outbound 8e26f7114b75:v103");
 Sat, 09 Oct 2021 09:40:54 +0000
Received: from a6033bcd3b57.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 1032F2A4-FF04-4183-AF7A-9BCFB0736FDF.1; 
 Sat, 09 Oct 2021 09:40:48 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id a6033bcd3b57.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Sat, 09 Oct 2021 09:40:48 +0000
Received: from VE1PR08MB5215.eurprd08.prod.outlook.com (2603:10a6:803:10a::33)
 by VI1PR0801MB1920.eurprd08.prod.outlook.com (2603:10a6:800:8f::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.19; Sat, 9 Oct
 2021 09:40:47 +0000
Received: from VE1PR08MB5215.eurprd08.prod.outlook.com
 ([fe80::41d6:b115:3b22:2cd]) by VE1PR08MB5215.eurprd08.prod.outlook.com
 ([fe80::41d6:b115:3b22:2cd%2]) with mapi id 15.20.4587.024; Sat, 9 Oct 2021
 09:40:46 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0ecdfa06-00f8-4c44-8784-84243e11fde7
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=nxCN7YUiHa2aOxcQyZRnG4XEruW3sn6G6+e8TIJaOKU=;
 b=67Pw0k8Qr1m33ZKp+1xzmH3I9ZbrXv1mfi9PHkboMz2i9ENF1KxigJL+Lqfwdqy56ENCfPZE1yUBefEtDBtnbZET/ydouuPjOrrWPbY67ycvj6Cz2ckN6+Zan2ozIbfZKQ5xt+p1YHBa3Opiuy0RQkpFVaImo44/lovsHIUg2j8=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Byq2Jt7SleFq6/Z/SeFLbb/k7Gd1HVuFLN8FNvs+s2i8FReyw3s9zuTNmEMD0FbaCVIS/GUVXVx2tWtxSsqv+lvB7Jd4um07CsBi8TydNOHrvgqD3p7iQVqOlQMpoP+OkgYjtZ61o1a6OAhDA/tvof6RQBtnF40GHuq6UYoQtuz0vnOrBZtBJ+418LoWHkrRaJhmCrhfzsK3rm5GniopMfUqJTzPSg+J+/PCn1kWhbzpsMS2Yhnz4ZN0COqFLVGVOEFs8knzK3bsD8orZ1WmngM6PzKVLnGUsUESjBDOT93abvCMxa2pBUd57h1FWx1pDlGA03AmubeWxirCd+uyKA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=nxCN7YUiHa2aOxcQyZRnG4XEruW3sn6G6+e8TIJaOKU=;
 b=NREAm9FwMNtaION5V+6rrFWu4X71lEywatvo4w0FWln95cMZUzFg+P8hFvevl4ez5o0F9CMegTipD+CREaerXoIRl0FsCpUxVAbpC6JXLobvwAdSZbpqGTn5MuIuQ6kZte4I/EOG0W8dexB7wJjJnPdb2JtG0gK2+IGJ19r/T36jp/Zk4PKpvGevXD8Vwwf8PJpfWw6eBw4I1CuSx4p18DSM9j4tM7LcBJzcEuhkg/AlVp/ZJgAPupCWlpcj7zDvf0WkOuO9JhvFhnJio6Y/nVvvlkgwSIAuZopSqOz2AZ/0LG7HtzVrZID9e1a39srSGD80U3MYnSNqWc5P2EZtTw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=nxCN7YUiHa2aOxcQyZRnG4XEruW3sn6G6+e8TIJaOKU=;
 b=67Pw0k8Qr1m33ZKp+1xzmH3I9ZbrXv1mfi9PHkboMz2i9ENF1KxigJL+Lqfwdqy56ENCfPZE1yUBefEtDBtnbZET/ydouuPjOrrWPbY67ycvj6Cz2ckN6+Zan2ozIbfZKQ5xt+p1YHBa3Opiuy0RQkpFVaImo44/lovsHIUg2j8=
From: Penny Zheng <Penny.Zheng@arm.com>
To: Julien Grall <julien@xen.org>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, "sstabellini@kernel.org"
	<sstabellini@kernel.org>
CC: Bertrand Marquis <Bertrand.Marquis@arm.com>, Wei Chen <Wei.Chen@arm.com>
Subject: RE: [PATCH 10/11] xen/arm: device assignment on 1:1 direct-map domain
Thread-Topic: [PATCH 10/11] xen/arm: device assignment on 1:1 direct-map
 domain
Thread-Index: AQHXsCjEx0HGlBpA+Em1L92CXDXaB6uxe3AAgBj87fA=
Date: Sat, 9 Oct 2021 09:40:46 +0000
Message-ID:
 <VE1PR08MB5215A1D5695F388F17C367D4F7B39@VE1PR08MB5215.eurprd08.prod.outlook.com>
References: <20210923031115.1429719-1-penny.zheng@arm.com>
 <20210923031115.1429719-11-penny.zheng@arm.com>
 <c6730ec5-53c7-9bf2-4620-eefbc7c7c4a3@xen.org>
In-Reply-To: <c6730ec5-53c7-9bf2-4620-eefbc7c7c4a3@xen.org>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: F3A293D88EA6F3478F74228BB23FCC65.0
x-checkrecipientchecked: true
Authentication-Results-Original: xen.org; dkim=none (message not signed)
 header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: 4bb6bfb0-bb61-4729-ddcf-08d98b08e3ac
x-ms-traffictypediagnostic: VI1PR0801MB1920:|VI1PR0802MB2416:
x-ms-exchange-transport-forked: True
X-Microsoft-Antispam-PRVS:
	<VI1PR0802MB2416BCB62146C3B950040650F7B39@VI1PR0802MB2416.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:8882;OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 HmYxuEzF838lJwMOSDyT3ljCC2cve8H8Cx0CaGNvUEmfJUHXQz77vfeKziutUMsw3KTzzsbNzllELX/yhbYuXUW8+Ewfh4k49oow0aL7kcstXlpsq0o+Cle7toMJmmMZn1B1PVVUDcrXqZ7/3ozo3MsMGI6rO90BKAFcUhCOUQF3cKDokHZ2Uff8Sc3vBPuLqm74vWVTP0HVOpuC7K/h6HQvg5usVv20O7iyk3W3nhxGVx6//q5Mc2ZiwXBxs7yfAHgpx/OP/HjXjHVNCEMzBWb7ccF8od5pe+6vvgBFWKxAxD7noywQ15AoF5s5LJTkN1ESt80XgA4MVl4ZUpkFjJReaIpHJk4DHfW+fOGz/bw//yPQZ03l4x+grAUEjipANyEXp2jS4CaR+8RBr1ULYKHSl3byyKrQn7Z/QcnsNJHOlq6O6UmJrH8JN/eUVd7d/oX8SZKAQUe+B68i8lg0kR6QU254OZroEsouV/7vY1S00jN21EV/DX6onUZ0O6TeMdDtZzfUNMOXWdSFekKeA4fAqR8kGcwXMZ8nclIA2cehrYuBws7jVgicC7SZyaksv698Yvd+02sGEPcOGjMwMaQlqt7UzM4pBZnv1YiJ3cNnU5Cblthlj7v/m1mEiHKdQbXgjByOVZus5jMXZMx8a0HFhNPqn5QfHpRuJO6n1Rr63Lr1Ohnmjq7PQG2kCVUYJr0UjfOrneMCgzpTQ2P/jg==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR08MB5215.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(66946007)(122000001)(66446008)(66476007)(64756008)(53546011)(66556008)(76116006)(9686003)(55016002)(52536014)(2906002)(7696005)(86362001)(83380400001)(6506007)(33656002)(110136005)(508600001)(316002)(4326008)(38100700002)(8676002)(5660300002)(38070700005)(54906003)(8936002)(186003)(71200400001)(26005);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0801MB1920
Original-Authentication-Results: xen.org; dkim=none (message not signed)
 header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT006.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	ed65b07a-fde1-4df4-562c-08d98b08df2b
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Ae0W4pzU47NCe7n1WSOZll235WnOFSBjQ8BteaMC0O/Tw9v2Il4AOYD9RybsofBxGLJu/h3IM0H0JhH97WPzBa4QA8bptnR1TKR62tGDmqwosS/gzNtAV90qg6NFCFqYyvXZ5cwQKCqQc7H5DKZ96nY1VPem/N694iHv+Lpry5vhDOeb0tvuT6Qi+kLOgdhLjp8x12ky8dKO5xmFyinbs08WcreTcKBEFRTIVQdD8+Dbjx8ICFtjoHOHh6jBMw8YlayaLozEP8W0FFqUDARnl/rE6pS44S5jNOXaiUTpS66NEnr3eVFtsa6wxCyzs41+2c67wc46V31hOeCQA9rBk/bLfz4aRtq/4IEkbuW2H8Vd4SFhr8t6h8OHlBKh3QIEr9ZQQlFox1cnAW/gKg9jmAOH+4rMYeGCv7IYX5zSjuobUiUkHutLPbV4e6rA3qpett1llTIxfNc1Uqr0hNkF0tbniyzy/4/aHjn7W8TCt43KHdMSghXnYdaR2xICS0ogvRu2lrdb+uYVTN5r3v8h/Z7HE044dO53VE2XNwNULST0Qy0b8DUOIpJZW3Oi4VPDIOAAtxlybl6RG5ASeSNnB7/6Nra/ueTDyDv3QoSwOriJV5B/57wGqV62UStMop4cX5Jqugy+NmBYVNVmYf/2tfLBCqrpdR6jyDQ+zTP0UPGET06nXMenBSh+PBbhyu0V+ibsp0A5k10/mGs+WuJdwQ==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(83380400001)(82310400003)(6506007)(336012)(26005)(186003)(4326008)(55016002)(9686003)(54906003)(316002)(86362001)(110136005)(7696005)(5660300002)(52536014)(47076005)(508600001)(53546011)(2906002)(8676002)(8936002)(33656002)(81166007)(356005)(70586007)(70206006)(36860700001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Oct 2021 09:40:54.5322
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 4bb6bfb0-bb61-4729-ddcf-08d98b08e3ac
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT006.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0802MB2416

SGkgSnVsaWVuDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogSnVsaWVu
IEdyYWxsIDxqdWxpZW5AeGVuLm9yZz4NCj4gU2VudDogVGh1cnNkYXksIFNlcHRlbWJlciAyMywg
MjAyMSA3OjI3IFBNDQo+IFRvOiBQZW5ueSBaaGVuZyA8UGVubnkuWmhlbmdAYXJtLmNvbT47IHhl
bi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZzsNCj4gc3N0YWJlbGxpbmlAa2VybmVsLm9yZw0K
PiBDYzogQmVydHJhbmQgTWFycXVpcyA8QmVydHJhbmQuTWFycXVpc0Bhcm0uY29tPjsgV2VpIENo
ZW4NCj4gPFdlaS5DaGVuQGFybS5jb20+DQo+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggMTAvMTFdIHhl
bi9hcm06IGRldmljZSBhc3NpZ25tZW50IG9uIDE6MSBkaXJlY3QtbWFwDQo+IGRvbWFpbg0KPiAN
Cj4gSGksDQo+IA0KPiBPbiAyMy8wOS8yMDIxIDA4OjExLCBQZW5ueSBaaGVuZyB3cm90ZToNCj4g
PiBVc2VyIGNvdWxkIGRvIGRldmljZSBwYXNzdGhyb3VnaCwgd2l0aA0KPiA+ICJ4ZW4sZm9yY2Ut
YXNzaWduLXdpdGhvdXQtaW9tbXUiIGluIHRoZSBkZXZpY2UgdHJlZSBzbmlwcGV0LCBvbg0KPiA+
IHRydXN0ZWQgZ3Vlc3QgdGhyb3VnaCAxOjEgZGlyZWN0LW1hcCwgaWYgSU9NTVUgYWJzZW50IG9y
IGRpc2FibGVkIG9uDQo+IGhhcmR3YXJlLg0KPiANCj4gQXQgdGhlIG1vbWVudCwgaXQgd291bGQg
YmUgcG9zc2libGUgdG8gcGFzc3Rocm91Z2ggYSBub24tRE1BIGNhcGFibGUNCj4gZGV2aWNlIHdp
dGggZGlyZWN0LW1hcHBpbmcuIEFmdGVyIHRoaXMgcGF0Y2gsIHRoaXMgaXMgZ29pbmcgdG8gYmUg
Zm9yYmlkZGVuLg0KPiANCj4gPg0KPiA+IEluIG9yZGVyIHRvIGFjaGlldmUgdGhhdCwgdGhpcyBw
YXRjaCBhZGRzIDE6MSBkaXJlY3QtbWFwIGNoZWNrIGFuZA0KPiA+IGRpc2FibGVzIGlvbW11LXJl
bGF0ZWQgYWN0aW9uLg0KPiA+DQo+ID4gU2lnbmVkLW9mZi1ieTogUGVubnkgWmhlbmcgPHBlbm55
LnpoZW5nQGFybS5jb20+DQo+ID4gLS0tDQo+ID4gICB4ZW4vYXJjaC9hcm0vZG9tYWluX2J1aWxk
LmMgfCAxMiArKysrKysrKy0tLS0NCj4gPiAgIDEgZmlsZSBjaGFuZ2VkLCA4IGluc2VydGlvbnMo
KyksIDQgZGVsZXRpb25zKC0pDQo+ID4NCj4gPiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gvYXJtL2Rv
bWFpbl9idWlsZC5jIGIveGVuL2FyY2gvYXJtL2RvbWFpbl9idWlsZC5jDQo+ID4gaW5kZXggYzky
ZTUxMGFlNy4uOWE5ZDI1MjJiNyAxMDA2NDQNCj4gPiAtLS0gYS94ZW4vYXJjaC9hcm0vZG9tYWlu
X2J1aWxkLmMNCj4gPiArKysgYi94ZW4vYXJjaC9hcm0vZG9tYWluX2J1aWxkLmMNCj4gPiBAQCAt
MjA3MCwxNCArMjA3MCwxOCBAQCBzdGF0aWMgaW50IF9faW5pdA0KPiBoYW5kbGVfcGFzc3Rocm91
Z2hfcHJvcChzdHJ1Y3Qga2VybmVsX2luZm8gKmtpbmZvLA0KPiA+ICAgICAgIGlmICggcmVzIDwg
MCApDQo+ID4gICAgICAgICAgIHJldHVybiByZXM7DQo+ID4NCj4gPiArICAgIC8qDQo+ID4gKyAg
ICAgKiBJZiB4ZW5fZm9yY2UsIHdlIGFsbG93IGFzc2lnbm1lbnQgb2YgZGV2aWNlcyB3aXRob3V0
IElPTU1VDQo+IHByb3RlY3Rpb24uDQo+ID4gKyAgICAgKiBBbmQgaWYgSU9NTVUgaXMgZGlzYWJs
ZWQgb3IgYWJzZW50LCAxOjEgZGlyZWN0LW1hcCBpcyBuZWNlc3NhcnkgPiArDQo+ICovDQo+ID4g
KyAgICBpZiAoIHhlbl9mb3JjZSAmJiBpc19kb21haW5fZGlyZWN0X21hcHBlZChraW5mby0+ZCkg
JiYNCj4gPiArICAgICAgICAgIWR0X2RldmljZV9pc19wcm90ZWN0ZWQobm9kZSkgKQ0KPiANCj4g
ZHRfZGV2aWNlX2lzX3Byb3RlY3RlZCgpIHdpbGwgYmUgYWx3YXlzIGZhbHNlIHVubGVzcyB0aGUg
ZGV2aWNlIGlzIHByb3RlY3RlZA0KPiBiZWhpbmcgYW4gU01NVSB1c2luZyB0aGUgbGVnYWN5IGJp
bmRpbmcuIFNvIEkgZG9uJ3QgdGhpbmsgdGhpcyBpcyBjb3JyZWN0IHRvDQo+IG1vdmUgdGhpcyBj
aGVjayBhaGVhZC4gSW4gZmFjdC4uDQo+IA0KPiA+ICsgICAgICAgIHJldHVybiAwOw0KPiA+ICsN
Cj4gPiAgICAgICByZXMgPSBpb21tdV9hZGRfZHRfZGV2aWNlKG5vZGUpOw0KPiANCj4gLi4uIHRo
ZSBjYWxsIHNob3VsZCBhbHJlYWR5IGJlIGEgTk9QIHdoZW4gdGhlIElPTU1VIGlzIGRpc2FibGVk
IG9yIHRoZQ0KPiBkZXZpY2UgaXMgbm90IGJlaGluZCBhbiBJT01NVS4gU28gY2FuIHlvdSBleHBs
YWluIHdoYXQgeW91IGFyZSB0cnlpbmcgdG8NCj4gcHJldmVudCBoZXJlPw0KPiANCg0KSWYgdGhl
IElPTU1VIGlzIGRpc2FibGVkLCBpb21tdV9hZGRfZHRfZGV2aWNlIHdpbGwgcmV0dXJuIDEgYXMg
ZXJybm8uIA0KU28gd2UgY291bGQgbm90IG1ha2UgaXQgdG8gdGhlIHhlbl9mb3JjZSBjaGVjay4u
Lg0KDQpTbyBJIHRyaWVkIHRvIG1vdmUgYWxsIElPTU1VIGFjdGlvbiBiZWhpbmQgeGVuX2ZvcmNl
IGNoZWNrLg0KDQpOb3csIGRldmljZSBhc3NpZ25tZW50IHdpdGhvdXQgSU9NTVUgcHJvdGVjdGlv
biBpcyBvbmx5DQphcHBsaWNhYmxlIG9uIGRpcmVjdC1tYXAgZG9tYWlucywgc28gdGhpcyBjb21t
aXQgYWxzbyBhZGRzDQppc19kb21haW5fZGlyZWN0X21hcHBlZCBjaGVjayB0b2dldGhlciB3aXRo
IHhlbl9mb3JjZSBjaGVjay4NCg0KPiA+ICAgICAgIGlmICggcmVzIDwgMCApDQo+ID4gICAgICAg
ICAgIHJldHVybiByZXM7DQo+ID4NCj4gPiAtICAgIC8qIElmIHhlbl9mb3JjZSwgd2UgYWxsb3cg
YXNzaWdubWVudCBvZiBkZXZpY2VzIHdpdGhvdXQgSU9NTVUNCj4gcHJvdGVjdGlvbi4gKi8NCj4g
PiAtICAgIGlmICggeGVuX2ZvcmNlICYmICFkdF9kZXZpY2VfaXNfcHJvdGVjdGVkKG5vZGUpICkN
Cj4gPiAtICAgICAgICByZXR1cm4gMDsNCj4gPiAtDQo+ID4gICAgICAgcmV0dXJuIGlvbW11X2Fz
c2lnbl9kdF9kZXZpY2Uoa2luZm8tPmQsIG5vZGUpOw0KPiA+ICAgfQ0KPiA+DQo+ID4NCj4gDQo+
IENoZWVycywNCj4gDQo+IC0tDQo+IEp1bGllbiBHcmFsbA0K


From xen-devel-bounces@lists.xenproject.org Sat Oct 09 10:11:03 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 09 Oct 2021 10:11:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.205100.360355 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZ9JV-0004Sf-A6; Sat, 09 Oct 2021 10:10:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 205100.360355; Sat, 09 Oct 2021 10:10:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZ9JV-0004SY-6p; Sat, 09 Oct 2021 10:10:45 +0000
Received: by outflank-mailman (input) for mailman id 205100;
 Sat, 09 Oct 2021 10:10:43 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mZ9JT-0004SO-LA; Sat, 09 Oct 2021 10:10:43 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mZ9JT-0000ix-E8; Sat, 09 Oct 2021 10:10:43 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mZ9JT-0005Ox-2E; Sat, 09 Oct 2021 10:10:43 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mZ9JT-0005yi-1F; Sat, 09 Oct 2021 10:10:43 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=6L7BN8BQZzlXtlHwDTAbirMv9pxvLz8eAZUDsi1xXFw=; b=LTo7uM6nCIac+E2JNWCnrgA3gj
	6jD3MDrh4H32CArBkKYbTiABvjtRXhIY0xv820YlLDSyZZ706Xi+/qsgw+lF/VTMBra/7UsM/aSzH
	c8u9bssOPtCimbtgTzq6asy+UHq358CAGx88qnVxNbDsDw4Zdrv8mHjU6gC/wsizh1cY=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165435-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 165435: regressions - FAIL
X-Osstest-Failures:
    linux-linus:test-armhf-armhf-xl-credit1:guest-start.2:fail:regression
    linux-linus:test-amd64-amd64-freebsd11-amd64:guest-localmigrate/x10:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=1da38549dd64c7f5dd22427f12dfa8db3d8a722b
X-Osstest-Versions-That:
    linux=deacdb3e3979979016fcd0ffd518c320a62ad166
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 09 Oct 2021 10:10:43 +0000

flight 165435 linux-linus real [real]
flight 165444 linux-linus real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/165435/
http://logs.test-lab.xenproject.org/osstest/logs/165444/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-armhf-armhf-xl-credit1  19 guest-start.2            fail REGR. vs. 152332

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-freebsd11-amd64 19 guest-localmigrate/x10 fail baseline untested
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail baseline untested
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 152332
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 152332
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 152332
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 152332
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 152332
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152332
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 152332
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 linux                1da38549dd64c7f5dd22427f12dfa8db3d8a722b
baseline version:
 linux                deacdb3e3979979016fcd0ffd518c320a62ad166

Last test of basis   152332  2020-07-31 19:41:23 Z  434 days
Failing since        152366  2020-08-01 20:49:34 Z  433 days  746 attempts
Testing same since   165422  2021-10-07 22:10:59 Z    1 days    2 attempts

------------------------------------------------------------
7382 people touched revisions under test,
not listing them all

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             fail    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 2285685 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Oct 09 13:46:39 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 09 Oct 2021 13:46:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.205117.360368 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZCg9-0006l8-28; Sat, 09 Oct 2021 13:46:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 205117.360368; Sat, 09 Oct 2021 13:46:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZCg8-0006l1-VL; Sat, 09 Oct 2021 13:46:20 +0000
Received: by outflank-mailman (input) for mailman id 205117;
 Sat, 09 Oct 2021 13:46:20 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mZCg8-0006kr-44; Sat, 09 Oct 2021 13:46:20 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mZCg7-0004BJ-Q0; Sat, 09 Oct 2021 13:46:19 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mZCg7-0007ba-E5; Sat, 09 Oct 2021 13:46:19 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mZCg7-00027P-Da; Sat, 09 Oct 2021 13:46:19 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=AOSrxj6L6cCi79ioptjJq631SQAe1qN+EY2kb2sxP/I=; b=dlnYzL/ZCCraq6pOZ+qrNhQtE6
	KxNu/XVrsVXTEDXEbRIfd6gKbpbIQMXXCeWUOO/eT6gz/9v0Dkh8BWHqgl5D0H6L7dcpDDJPk7l5q
	lHK2j01yovSRbH+Aj+aSaJDP87hs6M8vaopzg0NHAYuhT/686z1qBM9Sr4e5t2Og8iFA=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165441-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 165441: regressions - FAIL
X-Osstest-Failures:
    libvirt:build-amd64-libvirt:libvirt-build:fail:regression
    libvirt:build-armhf-libvirt:libvirt-build:fail:regression
    libvirt:build-arm64-libvirt:libvirt-build:fail:regression
    libvirt:build-i386-libvirt:libvirt-build:fail:regression
    libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    libvirt=1b9ce05ce241a581d4e80228c92ceb0266f21f94
X-Osstest-Versions-That:
    libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 09 Oct 2021 13:46:19 +0000

flight 165441 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165441/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-armhf-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-arm64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-i386-libvirt            6 libvirt-build            fail REGR. vs. 151777

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-libvirt-vhd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a

version targeted for testing:
 libvirt              1b9ce05ce241a581d4e80228c92ceb0266f21f94
baseline version:
 libvirt              2c846fa6bcc11929c9fb857a22430fb9945654ad

Last test of basis   151777  2020-07-10 04:19:19 Z  456 days
Failing since        151818  2020-07-11 04:18:52 Z  455 days  441 attempts
Testing same since   165441  2021-10-09 04:18:51 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
    Adolfo Jayme Barrientos <fitoschido@gmail.com>
  Aleksandr Alekseev <alexander.alekseev@virtuozzo.com>
  Aleksei Zakharov <zaharov@selectel.ru>
  Andika Triwidada <andika@gmail.com>
  Andrea Bolognani <abologna@redhat.com>
  Ani Sinha <ani@anisinha.ca>
  Balázs Meskó <meskobalazs@mailbox.org>
  Barrett Schonefeld <bschoney@utexas.edu>
  Bastian Germann <bastiangermann@fishpost.de>
  Bastien Orivel <bastien.orivel@diateam.net>
  BiaoXiang Ye <yebiaoxiang@huawei.com>
  Bihong Yu <yubihong@huawei.com>
  Binfeng Wu <wubinfeng@huawei.com>
  Bjoern Walk <bwalk@linux.ibm.com>
  Boris Fiuczynski <fiuczy@linux.ibm.com>
  Brian Turek <brian.turek@gmail.com>
  Bruno Haible <bruno@clisp.org>
  Chris Mayo <aklhfex@gmail.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Ehrhardt <christian.ehrhardt@canonical.com>
  Christian Kirbach <christian.kirbach@gmail.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Cole Robinson <crobinso@redhat.com>
  Collin Walling <walling@linux.ibm.com>
  Cornelia Huck <cohuck@redhat.com>
  Cédric Bosdonnat <cbosdonnat@suse.com>
  Côme Borsoi <fedora@borsoi.fr>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniel Letai <dani@letai.org.il>
  Daniel P. Berrange <berrange@redhat.com>
  Daniel P. Berrangé <berrange@redhat.com>
  Didik Supriadi <didiksupriadi41@gmail.com>
  dinglimin <dinglimin@cmss.chinamobile.com>
  Dmytro Linkin <dlinkin@nvidia.com>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Eric Farman <farman@linux.ibm.com>
  Erik Skultety <eskultet@redhat.com>
  Fabian Affolter <mail@fabian-affolter.ch>
  Fabian Freyer <fabian.freyer@physik.tu-berlin.de>
  Fabiano Fidêncio <fabiano@fidencio.org>
  Fangge Jin <fjin@redhat.com>
  Farhan Ali <alifm@linux.ibm.com>
  Fedora Weblate Translation <i18n@lists.fedoraproject.org>
  gongwei <gongwei@smartx.com>
  Guoyi Tu<tu.guoyi@h3c.com>
  Göran Uddeborg <goeran@uddeborg.se>
  Halil Pasic <pasic@linux.ibm.com>
  Han Han <hhan@redhat.com>
  Hao Wang <wanghao232@huawei.com>
  Hela Basa <r45xveza@pm.me>
  Helmut Grohne <helmut@subdivi.de>
  Hiroki Narukawa <hnarukaw@yahoo-corp.jp>
  Ian Wienand <iwienand@redhat.com>
  Jakob Meng <jakobmeng@web.de>
  Jamie Strandboge <jamie@canonical.com>
  Jamie Strandboge <jamie@ubuntu.com>
  Jan Kuparinen <copper_fin@hotmail.com>
  jason lee <ppark5237@gmail.com>
  Jean-Baptiste Holcroft <jean-baptiste@holcroft.fr>
  Jia Zhou <zhou.jia2@zte.com.cn>
  Jianan Gao <jgao@redhat.com>
  Jim Fehlig <jfehlig@suse.com>
  Jin Yan <jinyan12@huawei.com>
  Jinsheng Zhang <zhangjl02@inspur.com>
  Jiri Denemark <jdenemar@redhat.com>
  John Ferlan <jferlan@redhat.com>
  Jonathan Watt <jwatt@jwatt.org>
  Jonathon Jongsma <jjongsma@redhat.com>
  Julio Faracco <jcfaracco@gmail.com>
  Justin Gatzen <justin.gatzen@gmail.com>
  Ján Tomko <jtomko@redhat.com>
  Kashyap Chamarthy <kchamart@redhat.com>
  Kevin Locke <kevin@kevinlocke.name>
  Kristina Hanicova <khanicov@redhat.com>
  Laine Stump <laine@redhat.com>
  Laszlo Ersek <lersek@redhat.com>
  Lee Yarwood <lyarwood@redhat.com>
  Lei Yang <yanglei209@huawei.com>
  Liao Pingfang <liao.pingfang@zte.com.cn>
  Lin Ma <lma@suse.com>
  Lin Ma <lma@suse.de>
  Lin Ma <morecache@gmail.com>
  Liu Yiding <liuyd.fnst@fujitsu.com>
  Luke Yue <lukedyue@gmail.com>
  Luyao Zhong <luyao.zhong@intel.com>
  Marc Hartmayer <mhartmay@linux.ibm.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Markus Schade <markus.schade@hetzner.com>
  Martin Kletzander <mkletzan@redhat.com>
  Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
  Matej Cepl <mcepl@cepl.eu>
  Matt Coleman <matt@datto.com>
  Matt Coleman <mcoleman@datto.com>
  Mauro Matteo Cascella <mcascell@redhat.com>
  Meina Li <meili@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Michał Smyk <fedora@smyk.it>
  Milo Casagrande <milo@milo.name>
  Moshe Levi <moshele@nvidia.com>
  Muha Aliss <muhaaliss@gmail.com>
  Nathan <nathan95@live.it>
  Neal Gompa <ngompa13@gmail.com>
  Nick Chevsky <nchevsky@gmail.com>
  Nick Shyrokovskiy <nshyrokovskiy@gmail.com>
  Nickys Music Group <nickys.music.group@gmail.com>
  Nico Pache <npache@redhat.com>
  Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
  Olaf Hering <olaf@aepfle.de>
  Olesya Gerasimenko <gammaray@basealt.ru>
  Orion Poplawski <orion@nwra.com>
  Pany <geekpany@gmail.com>
  Patrick Magauran <patmagauran.j@gmail.com>
  Paulo de Rezende Pinatti <ppinatti@linux.ibm.com>
  Pavel Hrdina <phrdina@redhat.com>
  Peng Liang <liangpeng10@huawei.com>
  Peter Krempa <pkrempa@redhat.com>
  Pino Toscano <ptoscano@redhat.com>
  Pino Toscano <toscano.pino@tiscali.it>
  Piotr Drąg <piotrdrag@gmail.com>
  Prathamesh Chavan <pc44800@gmail.com>
  Richard W.M. Jones <rjones@redhat.com>
  Ricky Tigg <ricky.tigg@gmail.com>
  Robin Lee <cheeselee@fedoraproject.org>
  Roman Bogorodskiy <bogorodskiy@gmail.com>
  Roman Bolshakov <r.bolshakov@yadro.com>
  Ryan Gahagan <rgahagan@cs.utexas.edu>
  Ryan Schmidt <git@ryandesign.com>
  Sam Hartman <hartmans@debian.org>
  Scott Shambarger <scott-libvirt@shambarger.net>
  Sebastian Mitterle <smitterl@redhat.com>
  SeongHyun Jo <caelus9536@gmail.com>
  Shalini Chellathurai Saroja <shalini@linux.ibm.com>
  Shaojun Yang <yangshaojun@phytium.com.cn>
  Shi Lei <shi_lei@massclouds.com>
  simmon <simmon@nplob.com>
  Simon Chopin <chopin.simon@gmail.com>
  Simon Gaiser <simon@invisiblethingslab.com>
  Simon Rowe <simon.rowe@nutanix.com>
  Stefan Bader <stefan.bader@canonical.com>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Berger <stefanb@linux.vnet.ibm.com>
  Stefan Hajnoczi <stefanha@gmail.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Szymon Scholz <szymonscholz@gmail.com>
  Thomas Huth <thuth@redhat.com>
  Tim Wiederhake <twiederh@redhat.com>
  Tomáš Golembiovský <tgolembi@redhat.com>
  Tomáš Janoušek <tomi@nomi.cz>
  Tuguoyi <tu.guoyi@h3c.com>
  Victor Toso <victortoso@redhat.com>
  Ville Skyttä <ville.skytta@iki.fi>
  Vinayak Kale <vkale@nvidia.com>
  Wang Xin <wangxinxin.wang@huawei.com>
  WangJian <wangjian161@huawei.com>
  Weblate <noreply@weblate.org>
  Wei Liu <liuwe@microsoft.com>
  Wei Liu <wei.liu@kernel.org>
  William Douglas <william.douglas@intel.com>
  Yalei Li <274268859@qq.com>
  Yalei Li <liyl43@chinatelecom.cn>
  Yang Fei <yangfei85@huawei.com>
  Yang Hang <yanghang44@huawei.com>
  Yanqiu Zhang <yanqzhan@redhat.com>
  Yaroslav Kargin <ykargin@virtuozzo.com>
  Yi Li <yili@winhong.com>
  Yi Wang <wang.yi59@zte.com.cn>
  Yuri Chornoivan <yurchor@ukr.net>
  Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
  zhangjl02 <zhangjl02@inspur.com>
  Zheng Chuan <zhengchuan@huawei.com>
  zhenwei pi <pizhenwei@bytedance.com>
  Zhenyu Ye <yezhenyu2@huawei.com>
  Zhenyu Zheng <zheng.zhenyu@outlook.com>
  Zhenzhong Duan <zhenzhong.duan@intel.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          fail    
 build-arm64-libvirt                                          fail    
 build-armhf-libvirt                                          fail    
 build-i386-libvirt                                           fail    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           blocked 
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-libvirt-xsm                                 blocked 
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-libvirt                                     blocked 
 test-arm64-arm64-libvirt                                     blocked 
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-libvirt-pair                                blocked 
 test-amd64-i386-libvirt-pair                                 blocked 
 test-arm64-arm64-libvirt-qcow2                               blocked 
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-libvirt-vhd                                 blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 77226 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Oct 09 15:39:12 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 09 Oct 2021 15:39:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.205176.360423 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZERD-0002Uu-Dk; Sat, 09 Oct 2021 15:39:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 205176.360423; Sat, 09 Oct 2021 15:39:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZERD-0002Un-9k; Sat, 09 Oct 2021 15:39:03 +0000
Received: by outflank-mailman (input) for mailman id 205176;
 Sat, 09 Oct 2021 15:39:02 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mZERC-0002Ud-7U; Sat, 09 Oct 2021 15:39:02 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mZERB-00063Y-W6; Sat, 09 Oct 2021 15:39:02 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mZERB-0003me-GB; Sat, 09 Oct 2021 15:39:01 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mZERB-00084s-Ff; Sat, 09 Oct 2021 15:39:01 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=ZWLPwY4TLLzhTWFJV3SKRV6rNx6L0ZnkVzL2hQYaZkg=; b=aLumyx7VI8tloSxYu51NzzzUIW
	A+eozWCwNKu6TwgMRal9cW5U62UgV/qcAGYDfQFI4bwPaineA0/SdnNvNk/8J7SJOk0TbkIOUzX86
	xTILk5/Uzj9uFDmFUuXKUlJD/IzuBhhjGbF5v6uvnJZcbWUey+xt2DAM1Ev5bjlieXrg=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165438-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 165438: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=b11380f6cd58ce40422473262b2b4c2b210447a1
X-Osstest-Versions-That:
    xen=1d345539c0e3654025fc00187bf633fda6ea9a43
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 09 Oct 2021 15:39:01 +0000

flight 165438 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165438/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 165428
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 165428
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165428
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165428
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 165428
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 165428
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 165428
 test-armhf-armhf-xl-rtds     18 guest-start/debian.repeat    fail  like 165428
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 165428
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 165428
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 165428
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165428
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 165428
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  b11380f6cd58ce40422473262b2b4c2b210447a1
baseline version:
 xen                  1d345539c0e3654025fc00187bf633fda6ea9a43

Last test of basis   165428  2021-10-08 09:39:52 Z    1 days
Testing same since   165438  2021-10-09 00:09:05 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   1d345539c0..b11380f6cd  b11380f6cd58ce40422473262b2b4c2b210447a1 -> master


From xen-devel-bounces@lists.xenproject.org Sat Oct 09 16:28:42 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 09 Oct 2021 16:28:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.205195.360445 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZFD1-0008Al-8J; Sat, 09 Oct 2021 16:28:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 205195.360445; Sat, 09 Oct 2021 16:28:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZFD1-0008Ae-54; Sat, 09 Oct 2021 16:28:27 +0000
Received: by outflank-mailman (input) for mailman id 205195;
 Sat, 09 Oct 2021 16:28:26 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=lS6U=O5=invisiblethingslab.com=marmarek@srs-us1.protection.inumbo.net>)
 id 1mZFCz-0008AY-S3
 for xen-devel@lists.xenproject.org; Sat, 09 Oct 2021 16:28:26 +0000
Received: from wout1-smtp.messagingengine.com (unknown [64.147.123.24])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 2e14671a-21b0-4c60-be5e-92e0cbca6375;
 Sat, 09 Oct 2021 16:28:24 +0000 (UTC)
Received: from compute6.internal (compute6.nyi.internal [10.202.2.46])
 by mailout.west.internal (Postfix) with ESMTP id 734873200D25;
 Sat,  9 Oct 2021 12:28:22 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
 by compute6.internal (MEProxy); Sat, 09 Oct 2021 12:28:22 -0400
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat,
 9 Oct 2021 12:28:20 -0400 (EDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2e14671a-21b0-4c60-be5e-92e0cbca6375
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:content-type:date:from:in-reply-to
	:message-id:mime-version:references:subject:to:x-me-proxy
	:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=sXgsw1
	ZBix/b27dL4J3iDmXmDXdXu7WyW9UsQOfvAk0=; b=jTgZ9FqVvl0KPKuzdyC3fU
	gv6TJMKqGZFqDhR6VdOvt9+ZlEpkmDkTiaMlFa5FYVagroqSfzCvAqV9ab4WT2Su
	aASDG5eQiB8mKYVehaEwjgH7XgqZtYNd/lyBrNlM5D5qqNCpoixtE3LPJtRZE9sH
	4kAHY9Wx2gf+4IZwSIis48Gi7opL1tAoF6Q5ouqvAiwnOcEk6F9k1gqw0F7exK3g
	MYGhgoYDxiXnXHdRbdfcEV2szgtmKsW+frDEYNogH96SYEVPhogBQNI7KAfqpKY+
	tPKCnt4wI9euiCD6BcQTNNo3I0rcYuC4reVIEijtWT5MQX2PmXXI1zZMJedswGhg
	==
X-ME-Sender: <xms:JcNhYUUVW57RJUZwfgss6dcjAUi8Gq8ovBtLOWP7IkFor4wgIdrxbg>
    <xme:JcNhYYkodvvx09Ao03-HLrBwo9KoRK0a_NAcdIiHCQRE3-UCERBIlHD2bcPgo8h74
    kwINIxXYnHmsg>
X-ME-Received: <xmr:JcNhYYawZl1fEcA6sV7oMqrLXpg-o2spNvx2l1pgc6Y1oUUNWDo_ViwrvfQknunELkyajofGurqs7gFmEdkWqPbvQpT8Be_O>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrvddtvddgleelucetufdoteggodetrfdotf
    fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
    uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
    cujfgurhepfffhvffukfhfgggtuggjsehgtderredttdejnecuhfhrohhmpeforghrvghk
    ucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesihhnvh
    hishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpeetveff
    iefghfekhffggeeffffhgeevieektedthfehveeiheeiiedtudegfeetffenucevlhhush
    htvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrghrmhgrrhgvkhes
    ihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm
X-ME-Proxy: <xmx:JcNhYTX5vDvovcXh95IvaGY0jwvrAhelCeZbIqBrCoVjEj_gZX6R1A>
    <xmx:JcNhYel9eyabDXLKpk44OMrEU75XwpMjubjWIdWRko4_ORa1eJ2xNg>
    <xmx:JcNhYYeOZvccBTtMcdUCNyHOibxjk7IxZljQ76k0Hi1_ZuTJRHmZ1w>
    <xmx:JsNhYQie6e4sdJtdcdIXjTSd11XagE28tIGArgTeazRlwZRioeHEsw>
Date: Sat, 9 Oct 2021 18:28:17 +0200
From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
To: =?utf-8?B?SsO8cmdlbiBHcm/Dnw==?= <jgross@suse.com>
Cc: Juergen Gross <jgross@suse.de>, Dario Faggioli <dfaggioli@suse.com>,
	Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [Xen-devel] Xen crash after S3 suspend - Xen 4.13 and newer
Message-ID: <YWHDIQC3K8J3LD8+@mail-itl>
References: <20200318141635.GW7869@mail-itl>
 <fa845540-fd8e-bc63-a3af-50673dede579@citrix.com>
 <20200318221006.GS18599@mail-itl>
 <413cac496e18bcb04b0691ef633d206f3a14a8e3.camel@suse.com>
 <20200323000946.GH18599@mail-itl>
 <20200929142730.GA25731@mail-itl>
 <d243c1b5-712d-a958-0b6c-b232eb4edc80@suse.com>
 <20200929151627.GE1482@mail-itl>
 <ea53b845-5edf-a61e-62ae-7ababc30b3e0@suse.com>
 <20210131021526.GB6354@mail-itl>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="YEs/gVaIoDI3Kf7q"
Content-Disposition: inline
In-Reply-To: <20210131021526.GB6354@mail-itl>


--YEs/gVaIoDI3Kf7q
Content-Type: text/plain; protected-headers=v1; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Date: Sat, 9 Oct 2021 18:28:17 +0200
From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
To: =?utf-8?B?SsO8cmdlbiBHcm/Dnw==?= <jgross@suse.com>
Cc: Juergen Gross <jgross@suse.de>, Dario Faggioli <dfaggioli@suse.com>,
	Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [Xen-devel] Xen crash after S3 suspend - Xen 4.13 and newer

On Sun, Jan 31, 2021 at 03:15:30AM +0100, Marek Marczykowski-G=C3=B3recki w=
rote:
> On Tue, Sep 29, 2020 at 05:27:48PM +0200, J=C3=BCrgen Gro=C3=9F wrote:
> > On 29.09.20 17:16, Marek Marczykowski-G=C3=B3recki wrote:
> > > On Tue, Sep 29, 2020 at 05:07:11PM +0200, J=C3=BCrgen Gro=C3=9F wrote:
> > > > On 29.09.20 16:27, Marek Marczykowski-G=C3=B3recki wrote:
> > > > > On Mon, Mar 23, 2020 at 01:09:49AM +0100, Marek Marczykowski-G=C3=
=B3recki wrote:
> > > > > > On Thu, Mar 19, 2020 at 01:28:10AM +0100, Dario Faggioli wrote:
> > > > > > > [Adding Juergen]
> > > > > > >=20
> > > > > > > On Wed, 2020-03-18 at 23:10 +0100, Marek Marczykowski-G=C3=B3=
recki wrote:
> > > > > > > > On Wed, Mar 18, 2020 at 02:50:52PM +0000, Andrew Cooper wro=
te:
> > > > > > > > > On 18/03/2020 14:16, Marek Marczykowski-G=C3=B3recki wrot=
e:
> > > > > > > > > > Hi,
> > > > > > > > > >=20
> > > > > > > > > > In my test setup (inside KVM with nested virt enabled),=
 I rather
> > > > > > > > > > frequently get Xen crash on resume from S3. Full messag=
e below.
> > > > > > > > > >=20
> > > > > > > > > > This is Xen 4.13.0, with some patches, including "sched=
: fix
> > > > > > > > > > resuming
> > > > > > > > > > from S3 with smt=3D0".
> > > > > > > > > >=20
> > > > > > > > > > Contrary to the previous issue, this one does not happe=
n always -
> > > > > > > > > > I
> > > > > > > > > > would say in about 40% cases on this setup, but very ra=
rely on
> > > > > > > > > > physical
> > > > > > > > > > setup.
> > > > > > > > > >=20
> > > > > > > > > > This is _without_ core scheduling enabled, and also wit=
h smt=3Doff.
> > > > > > > > > >=20
> > > > > > > > > > Do you think it would be any different on xen-unstable?=
 I cat
> > > > > > > > > > try, but
> > > > > > > > > > it isn't trivial in this setup, so I'd ask first.
> > > > > > > > > >=20
> > > > > > > Well, Juergen has fixed quite a few issues.
> > > > > > >=20
> > > > > > > Most of them where triggering with core-scheduling enabled, a=
nd I don't
> > > > > > > recall any of them which looked similar or related to this.
> > > > > > >=20
> > > > > > > Still, it's possible that the same issue causes different sym=
ptoms, and
> > > > > > > hence that maybe one of the patches would fix this too.
> > > > > >=20
> > > > > > I've tested on master (d094e95fb7c), and reproduced exactly the=
 same crash
> > > > > > (pasted below for the completeness).
> > > > > > But there is more: additionally, in most (all?) cases after res=
ume I've got
> > > > > > soft lockup in Linux dom0 in smp_call_function_single() - see b=
elow. It
> > > > > > didn't happened before and the only change was Xen 4.13 -> mast=
er.
> > > > > >=20
> > > > > > Xen crash:
> > > > > >=20
> > > > > > (XEN) Assertion 'c2rqd(sched_unit_master(unit)) =3D=3D svc->rqd=
' failed at credit2.c:2133
> > > > >=20
> > > > > Juergen, any idea about this one? This is also happening on the c=
urrent
> > > > > stable-4.14 (28855ebcdbfa).
> > > > >=20
> > > >=20
> > > > Oh, sorry I didn't come back to this issue.
> > > >=20
> > > > I suspect this is related to stop_machine_run() being called during
> > > > suspend(), as I'm seeing very sporadic issues when offlining and th=
en
> > > > onlining cpus with core scheduling being active (it seems as if the
> > > > dom0 vcpu doing the cpu online activity sometimes is using an old
> > > > vcpu state).
> > >=20
> > > Note this is default Xen 4.14 start, so core scheduling is _not_ acti=
ve:
> >=20
> > The similarity in the two failure cases is that multiple cpus are
> > affected by the operations during stop_machine_run().
> >=20
> > >=20
> > >      (XEN) Brought up 2 CPUs
> > >      (XEN) Scheduling granularity: cpu, 1 CPU per sched-resource
> > >      (XEN) Adding cpu 0 to runqueue 0
> > >      (XEN)  First cpu on runqueue, activating
> > >      (XEN) Adding cpu 1 to runqueue 1
> > >      (XEN)  First cpu on runqueue, activating
> > >=20
> > > > I wasn't able to catch the real problem despite of having tried lots
> > > > of approaches using debug patches.
> > > >=20
> > > > Recently I suspected the whole problem could be somehow related to
> > > > RCU handling, as stop_machine_run() is relying on tasklets which are
> > > > executing in idle context, and RCU handling is done in idle context,
> > > > too. So there might be some kind of use after free scenario in case
> > > > some memory is freed via RCU despite it still being used by a taskl=
et.
> > >=20
> > > That sounds plausible, even though I don't really know this area of X=
en.
> > >=20
> > > > I "just" need to find some time to verify this suspicion. Any help =
doing
> > > > this would be appreciated. :-)
> > >=20
> > > I do have a setup where I can easily-ish reproduce the issue. If there
> > > is some debug patch you'd like me to try, I can do that.
> >=20
> > Thanks. I might come back to that offer as you are seeing a crash which
> > will be much easier to analyze. Catching my error case is much harder as
> > it surfaces some time after the real problem in a non destructive way
> > (usually I'm seeing a failure to load a library in the program which
> > just did its job via exactly the library claiming not being loadable).
>=20
> Hi,
>=20
> I'm resurrecting this thread as it was recently mentioned elsewhere. I
> can still reproduce the issue on the recent staging branch (9dc687f155).
>=20
> It fails after the first resume (not always, but frequent enough to
> debug it). At least one guest needs to be running - with just (PV) dom0
> the crash doesn't happen (at least for the ~8 times in a row I tried).
> If the first resume works, the second (almost?) always will fail but
> with a different symptoms - dom0 kernel lockups (at least some of its
> vcpus). I haven't debugged this one yet at all.
>=20
> Any help will be appreciated, I can apply some debug patches, change
> configuration etc.

This still happens on 4.14.3. Maybe it is related to freeing percpu
areas, as it caused other issues with suspend too? Just a thought...

--=20
Best Regards,
Marek Marczykowski-G=C3=B3recki
Invisible Things Lab

--YEs/gVaIoDI3Kf7q
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmFhwyAACgkQ24/THMrX
1yxhhwf+Pi73t0/namk0olEyL9STk7DR4W2y/FCBhw9qQB4Ve92oAZvv4vpRFlaM
rjO0uCin+2SIoa/+/Kv2kz3NOPqqSydbzSNxi72iqW68IKn24cL6Ftpgbbhzv53i
BFRVr1EYrIjaRbbWGsfTkwnO+EjRHTsaaF0C8+i2e582zGbPm1AvWzrcC1FZAzqp
OqLFeHhcmGYo6nunBX87OMJlCXBrvIk8K8iCeF9lA0B7Jid4J3Xcw7OwuLPQo0Dn
Q+LWUJQy1X/5T1smrcTa/hoxOBHQTYgUxMVl1tJbXOuJED36Vx2Gp5/LFjk7+Rlc
nZ1Rntw4/yG6JYlrZefw7v3odYdiZQ==
=Ia3B
-----END PGP SIGNATURE-----

--YEs/gVaIoDI3Kf7q--


From xen-devel-bounces@lists.xenproject.org Sat Oct 09 19:49:52 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 09 Oct 2021 19:49:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.205211.360456 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZILi-00017R-Ev; Sat, 09 Oct 2021 19:49:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 205211.360456; Sat, 09 Oct 2021 19:49:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZILi-00017K-Bg; Sat, 09 Oct 2021 19:49:38 +0000
Received: by outflank-mailman (input) for mailman id 205211;
 Sat, 09 Oct 2021 19:49:37 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mZILh-00017A-DE; Sat, 09 Oct 2021 19:49:37 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mZILh-0002CX-3F; Sat, 09 Oct 2021 19:49:37 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mZILg-0001cw-Q4; Sat, 09 Oct 2021 19:49:36 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mZILg-0007PK-PZ; Sat, 09 Oct 2021 19:49:36 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=12c+yjp478bS+cIdTDtflrnLcZtdzqciSP2YKZ2Svqs=; b=XYDUFLAQqJDNWy8poNT3mB4o5/
	XFgCerL6lr1vWekxwn0OrhjPcA4DAAUy6VkINjNssFuBXmpBEeH0RwZ/jNlXTMOznigyHw4wW0XKi
	4Dl54b6ZRDFWhKv7Vl8U9UGu5xdgfVkR0WL7QM+DUXDYL1260o6PPD2PUWhi0awE7/m8=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165442-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 165442: tolerable FAIL - PUSHED
X-Osstest-Failures:
    qemu-mainline:test-amd64-i386-libvirt-xsm:guest-start/debian.repeat:fail:heisenbug
    qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=15a0578903dc0d612e63f542d159fe1f3fb8a17a
X-Osstest-Versions-That:
    qemuu=14f12119aa675e9e28207a48b0728a2daa5b88d6
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 09 Oct 2021 19:49:36 +0000

flight 165442 qemu-mainline real [real]
flight 165447 qemu-mainline real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/165442/
http://logs.test-lab.xenproject.org/osstest/logs/165447/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-i386-libvirt-xsm 20 guest-start/debian.repeat fail pass in 165447-retest
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 165447-retest

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165429
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165429
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 165429
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 165429
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 165429
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 165429
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 165429
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165429
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 qemuu                15a0578903dc0d612e63f542d159fe1f3fb8a17a
baseline version:
 qemuu                14f12119aa675e9e28207a48b0728a2daa5b88d6

Last test of basis   165429  2021-10-08 11:40:26 Z    1 days
Testing same since   165442  2021-10-09 04:54:47 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Laurent Vivier <laurent@vivier.eu>
  Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
  Richard Henderson <richard.henderson@linaro.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 fail    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  fail    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/qemu-xen.git
   14f12119aa..15a0578903  15a0578903dc0d612e63f542d159fe1f3fb8a17a -> upstream-tested


From xen-devel-bounces@lists.xenproject.org Sat Oct 09 22:53:25 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 09 Oct 2021 22:53:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.205224.360470 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZLDL-0001Y5-2x; Sat, 09 Oct 2021 22:53:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 205224.360470; Sat, 09 Oct 2021 22:53:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZLDK-0001Xy-VA; Sat, 09 Oct 2021 22:53:10 +0000
Received: by outflank-mailman (input) for mailman id 205224;
 Sat, 09 Oct 2021 22:53:09 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mZLDJ-0001Xo-QS; Sat, 09 Oct 2021 22:53:09 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mZLDJ-0005H5-LX; Sat, 09 Oct 2021 22:53:09 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mZLDJ-0002Gl-AW; Sat, 09 Oct 2021 22:53:09 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mZLDJ-00041L-A0; Sat, 09 Oct 2021 22:53:09 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=ZfgZjn+5UrjbdA3mED0AB/B1/AC9BWeeR7L0QqLI9Io=; b=ifdDA51LunZN+oj6ahd/PMfg30
	1OdyuOQPzjilY1XuFzVtA2FVUgOeb/1/69neixfAGVp+M00TwqtniALeGdzr25VgfV1qLt8s2+pXX
	kkhwtiLMOBwrgIkEUYBoqtklrhOntWp6IyckTaGZZDAyAHoVXwFRKsCS4vAaP+BylCGY=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165443-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-5.4 test] 165443: regressions - FAIL
X-Osstest-Failures:
    linux-5.4:test-armhf-armhf-xl-credit1:guest-start:fail:regression
    linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:guest-start/debian.repeat:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=31cdcb6d430f07760dd2f540a354b11e6bb6a4a4
X-Osstest-Versions-That:
    linux=e74e2950a0d6f800858e54860d7124c86e494f62
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 09 Oct 2021 22:53:09 +0000

flight 165443 linux-5.4 real [real]
flight 165448 linux-5.4 real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/165443/
http://logs.test-lab.xenproject.org/osstest/logs/165448/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-armhf-armhf-xl-credit1  14 guest-start              fail REGR. vs. 165206

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165206
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 165206
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 165206
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 165206
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165206
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165206
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 165206
 test-arm64-arm64-libvirt-raw 17 guest-start/debian.repeat    fail  like 165206
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 165206
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 165206
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 165206
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 165206
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 165206
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 linux                31cdcb6d430f07760dd2f540a354b11e6bb6a4a4
baseline version:
 linux                e74e2950a0d6f800858e54860d7124c86e494f62

Last test of basis   165206  2021-09-26 12:42:13 Z   13 days
Failing since        165346  2021-10-04 12:42:32 Z    5 days    6 attempts
Testing same since   165414  2021-10-07 14:32:19 Z    2 days    3 attempts

------------------------------------------------------------
People who touched revisions under test:
  Alan Stern <stern@rowland.harvard.edu>
  Alex Deucher <alexander.deucher@amd.com>
  Alexei Starovoitov <ast@kernel.org>
  Anders Roxell <anders.roxell@linaro.org>
  Andrea Claudi <aclaudi@redhat.com>
  Andreas Larsson <andreas@gaisler.com>
  Andrej Shadura <andrew.shadura@collabora.co.uk>
  Andrew Morton <akpm@linux-foundation.org>
  Andy Shevchenko <andriy.shevchenko@linux.intel.com>
  Anirudh Rayabharam <mail@anirudhrb.com>
  Anson Jacob <Anson.Jacob@amd.com>
  Antoine Tenart <atenart@kernel.org>
  Anton Eidelman <anton.eidelman@gmail.com>
  Anton Eidelman <anton@lightbitslabs.com>
  Ariel Elior <aelior@marvell.com>
  Arnd Bergmann <arnd@arndb.de>
  Aswath Govindraju <a-govindraju@ti.com>
  Aya Levin <ayal@nvidia.com>
  Baokun Li <libaokun1@huawei.com>
  Bartosz Golaszewski <brgl@bgdev.pl>
  Bixuan Cui <cuibixuan@huawei.com>
  Bjorn Helgaas <bhelgaas@google.com>
  Borislav Petkov <bp@suse.de>
  Carlo Lobrano <c.lobrano@gmail.com>
  Catalin Marinas <catalin.marinas@arm.com>
  Charlene Liu <Charlene.Liu@amd.com>
  Chen Jingwen <chenjingwen6@huawei.com>
  Chih-Kang Chang <gary.chang@realtek.com>
  Chris Chiu <chris.chiu@canonical.com>
  Christian Brauner <christian.brauner@ubuntu.com>
  Christoph Hellwig <hch@lst.de>
  Claudiu Manoil <claudiu.manoil@nxp.com>
  Cong Wang <cong.wang@bytedance.com>
  Dan Carpenter <dan.carpenter@oracle.com>
  Dan Li <ashimida@linux.alibaba.com>
  Dan Williams <dan.j.williams@intel.com>
  Daniel Borkmann <daniel@iogearbox.net>
  Daniel Lezcano <daniel.lezcano@linaro.org>
  Daniel Wheeler <daniel.wheeler@amd.com>
  David Howells <dhowells@redhat.com>
  David S. Miller <davem@davemloft.net>
  David Sterba <dsterba@suse.com>
  Dmitry Bogdanov <d.bogdanov@yadro.com>
  Dongliang Mu <mudongliangabcd@gmail.com>
  Eric Biggers <ebiggers@google.com>
  Eric Dumazet <edumazet@google.com>
  F.A. SULAIMAN <asha.16@itfac.mrt.ac.lk>
  F.A.Sulaiman <asha.16@itfac.mrt.ac.lk>
  Felipe Balbi <balbi@kernel.org>
  Florian Fainelli <f.fainelli@gmail.com>
  Gao Xiang <hsiangkao@linux.alibaba.com>
  Geert Uytterhoeven <geert@linux-m68k.org>
  Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  Gregory CLEMENT <gregory.clement@bootlin.com>
  Guangbin Huang <huangguangbin2@huawei.com>
  Guenter Roeck <linux@roeck-us.net>
  Hans de Goede <hdegoede@redhat.com>
  Helge Deller <deller@gmx.de>
  Herbert Xu <herbert@gondor.apana.org.au>
  Hulk Robot <hulkrobot@huawei.com>
  Igor Matheus Andrade Torrente <igormtorrente@gmail.com>
  Jacob Keller <jacob.e.keller@intel.com>
  James Morse <james.morse@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Jeffle Xu <jefflexu@linux.alibaba.com>
  Jens Axboe <axboe@kernel.dk>
  Jesper Nilsson <jesper.nilsson@axis.com>
  Jian Shen <shenjian15@huawei.com>
  Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
  Jiri Benc <jbenc@redhat.com>
  Jiri Kosina <jkosina@suse.cz>
  Jiri Slaby <jslaby@suse.cz>
  Johan Hovold <johan@kernel.org>
  Johannes Berg <johannes.berg@intel.com>
  Johannes Thumshirn <jth@kernel.org>
  John Allen <john.allen@amd.com>
  Jon Hunter <jonathanh@nvidia.com>
  Jonathan Hsu <jonathan.hsu@mediatek.com>
  Jozsef Kadlecsik <kadlec@netfilter.org>
  Juergen Gross <jgross@suse.com>
  Julian Anastasov <ja@ssi.bg>
  Julian Sikorski <belegdol+github@gmail.com>
  Julian Sikorski <belegdol@gmail.com>
  Kaige Fu <kaige.fu@linux.alibaba.com>
  Kan Liang <kan.liang@linux.intel.com>
  Karsten Graul <kgraul@linux.ibm.com>
  Kevin Hao <haokexin@gmail.com>
  Kishon Vijay Abraham I <kishon@ti.com>
  Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
  Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
  Leon Yu <leoyu@nvidia.com>
  Li Jinlin <lijinlin3@huawei.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Linux Kernel Functional Testing <lkft@linaro.org>
  Lorenzo Bianconi <lorenzo@kernel.org>
  Marc Zyngier <maz@kernel.org>
  Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
  Mark Rutland <mark.rutland@arm.com>
  Markus Suvanto <markus.suvanto@gmail.com>
  Martin K. Petersen <martin.petersen@oracle.com>
  Michael Chan <michael.chan@broadcom.com>
  Michael Chan <michael.chan@broadocm.com>
  Michal Kalderon <mkalderon@marvell.com>
  Minas Harutyunyan <Minas.Harutyunyan@synopsys.com>
  Moritz Fischer <mdf@kernel.org>
  Nadezda Lutovinova <lutovinova@ispras.ru>
  Nicolas Ferre <nicolas.ferre@microchip.com>
  Nirmoy Das <nirmoy.das@amd.com>
  Oliver Neukum <oneukum@suse.com>
  Ondrej Zary <linux@zary.sk>
  Ovidiu Panait <ovidiu.panait@windriver.com>
  Pablo Neira Ayuso <pablo@netfilter.org>
  Pali Rohár <pali@kernel.org>
  Paolo Bonzini <pbonzini@redhat.com>
  Paul Fertser <fercerpav@gmail.com>
  Pawel Laszczak <pawell@cadence.com>
  Peter Zijlstra (Intel) <peterz@infradead.org>
  Ping-Ke Shih <pkshih@realtek.com>
  Qu Wenruo <wqu@suse.com>
  Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
  Randy Dunlap <rdunlap@infradead.org>
  Ritesh Harjani <riteshh@linux.ibm.com>
  Rob Herring <robh@kernel.org>
  Ronnie Sahlberg <lsahlber@redhat.com>
  Sai Krishna Potthuri <lakshmi.sai.krishna.potthuri@xilinx.com>
  Samuel Iglesias Gonsalvez <siglesias@igalia.com>
  Sasha Levin <sashal@kernel.org>
  Shai Malin <smalin@marvell.com>
  Shuah Khan <skhan@linuxfoundation.org>
  Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
  Simon Horman <horms@verge.net.au>
  Slark Xiao <slark_xiao@163.com>
  Song Liu <songliubraving@fb.com>
  Srinivas Pandruvada <srinivas.pI andruvada@linux.intel.com>
  Steve French <stfrench@microsoft.com>
  Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
  sumiyawang <sumiyawang@tencent.com>
  syzbot+47b26cd837ececfc666d@syzkaller.appspotmail.com
  syzbot+fadc0aaf497e6a493b9f@syzkaller.appspotmail.com
  Tariq Toukan <tariqt@nvidia.com>
  Tejun Heo <tj@kernel.org>
  Theodore Ts'o <tytso@mit.edu>
  Todd Kjos <tkjos@google.com>
  Tom Rix <trix@redhat.com>
  Tong Zhang <ztong0001@gmail.com>
  Tony Nguyen <anthony.l.nguyen@intel.com>
  Tyler Hicks <tyhicks@linux.microsoft.com>
  Uwe Brandt <uwe.brandt@gmail.com>
  Vadim Pasternak <vadimp@nvidia.com>
  Viresh Kumar <viresh.kumar@linaro.org>
  Vlad Buslov <vladbu@nvidia.com>
  Wengang Wang <wen.gang.wang@oracle.com>
  Xiao Liang <shaw.leon@gmail.com>
  Xin Long <lucien.xin@gmail.com>
  yangerkun <yangerkun@huawei.com>
  Yonghong Song <yhs@fb.com>
  Zelin Deng <zelin.deng@linux.alibaba.com>
  zhang kai <zhangkaiheb@126.com>
  Zhihao Cheng <chengzhihao1@huawei.com>
  Zong-Zhe Yang <kevin_yang@realtek.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 fail    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 3743 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Oct 09 23:49:06 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 09 Oct 2021 23:49:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.205235.360484 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZM5M-0006eR-8o; Sat, 09 Oct 2021 23:49:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 205235.360484; Sat, 09 Oct 2021 23:49:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZM5M-0006eK-4g; Sat, 09 Oct 2021 23:49:00 +0000
Received: by outflank-mailman (input) for mailman id 205235;
 Sat, 09 Oct 2021 23:48:58 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mZM5K-0006eA-Ra; Sat, 09 Oct 2021 23:48:58 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mZM5K-0006Al-GF; Sat, 09 Oct 2021 23:48:58 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mZM5K-0004FL-1j; Sat, 09 Oct 2021 23:48:58 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mZM5K-0000iB-1C; Sat, 09 Oct 2021 23:48:58 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=36VrcWNBgNE3d8d+d7kmPEY02WWAWG7VR5A0AVGzJes=; b=3E86DfoO9UeUSE7luDCaGO59XP
	Yk/C0mbNvXNlZtQ1HoqOi+iucNdRgG87aaEARMmpa/u2gNQN9/Te3+P7apRbDN6X7ju+BASeo8UWW
	3Y/Fe9WUfGc+lnFu0mVOCla/xisKVUjAQGRvQWDVh8PYsLasvtDpRNjgahrd1R8vcwHg=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165445-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 165445: trouble: broken/fail/pass
X-Osstest-Failures:
    linux-linus:test-arm64-arm64-xl:<job status>:broken:regression
    linux-linus:test-arm64-arm64-xl:host-install(5):broken:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=5d6ab0bb408ffdaac585982faa9ec8c7d5cc349f
X-Osstest-Versions-That:
    linux=deacdb3e3979979016fcd0ffd518c320a62ad166
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 09 Oct 2021 23:48:58 +0000

flight 165445 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165445/

Failures and problems with tests :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-arm64-arm64-xl             <job status>                 broken

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-xl           5 host-install(5)       broken blocked in 152332
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail baseline untested
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 152332
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 152332
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 152332
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 152332
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 152332
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152332
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 152332
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 linux                5d6ab0bb408ffdaac585982faa9ec8c7d5cc349f
baseline version:
 linux                deacdb3e3979979016fcd0ffd518c320a62ad166

Last test of basis   152332  2020-07-31 19:41:23 Z  435 days
Failing since        152366  2020-08-01 20:49:34 Z  434 days  747 attempts
Testing same since   165445  2021-10-09 10:14:38 Z    0 days    1 attempts

------------------------------------------------------------
7386 people touched revisions under test,
not listing them all

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          broken  
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary

broken-job test-arm64-arm64-xl broken
broken-step test-arm64-arm64-xl host-install(5)

Not pushing.

(No revision log; it would be 2287579 lines long.)


From xen-devel-bounces@lists.xenproject.org Sun Oct 10 06:47:03 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 10 Oct 2021 06:47:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.205255.360522 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZSbg-0003Jf-TP; Sun, 10 Oct 2021 06:46:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 205255.360522; Sun, 10 Oct 2021 06:46:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZSbg-0003JI-MP; Sun, 10 Oct 2021 06:46:48 +0000
Received: by outflank-mailman (input) for mailman id 205255;
 Sun, 10 Oct 2021 06:46:47 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mZSbe-0003J8-Vp; Sun, 10 Oct 2021 06:46:46 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mZSbe-0005Sf-Ow; Sun, 10 Oct 2021 06:46:46 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mZSbe-0001Q8-5I; Sun, 10 Oct 2021 06:46:46 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mZSbe-0000OH-4W; Sun, 10 Oct 2021 06:46:46 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=/AhGxU+puLEbxnAuFDILeKUqi3bK2SndyjyVVtYWmAw=; b=hZmTEuDYWuZNzKdzFpkIlbjHd6
	78REmiaFkje3e2gfF76T6GnLWXkQimUfgi7cqzCTG1LqLcrD7+njR7WFswXQ27lhTTh7Yfi6dr5/Z
	cBxKfJBfZigC9MacvwOZsYNSRL4uKkcDPe6snn6AX69Trp1WFlBFRwDD9mC5bLpyPOps=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165446-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 165446: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=664cc3c3d381e4f9a61dcb68cbd7a6a00070370e
X-Osstest-Versions-That:
    xen=b11380f6cd58ce40422473262b2b4c2b210447a1
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 10 Oct 2021 06:46:46 +0000

flight 165446 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165446/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 165438
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 165438
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165438
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165438
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 165438
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 165438
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 165438
 test-armhf-armhf-xl-rtds     18 guest-start/debian.repeat    fail  like 165438
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 165438
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 165438
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 165438
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165438
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 165438
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  664cc3c3d381e4f9a61dcb68cbd7a6a00070370e
baseline version:
 xen                  b11380f6cd58ce40422473262b2b4c2b210447a1

Last test of basis   165438  2021-10-09 00:09:05 Z    1 days
Testing same since   165446  2021-10-09 15:42:23 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Jan Beulich <jbeulich@suse.com>
  Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
  Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
  Rahul Singh <rahul.singh@arm.com>
  Stefano Stabellini <sstabellini@kernel.org>
  Volodymyr Babchuk <volodymyr_babchuk@epam.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   b11380f6cd..664cc3c3d3  664cc3c3d381e4f9a61dcb68cbd7a6a00070370e -> master


From xen-devel-bounces@lists.xenproject.org Sun Oct 10 09:52:29 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 10 Oct 2021 09:52:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.205287.360553 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZVVB-0005Jl-LH; Sun, 10 Oct 2021 09:52:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 205287.360553; Sun, 10 Oct 2021 09:52:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZVVB-0005Je-IM; Sun, 10 Oct 2021 09:52:17 +0000
Received: by outflank-mailman (input) for mailman id 205287;
 Sun, 10 Oct 2021 09:52:16 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mZVVA-0005JU-L0; Sun, 10 Oct 2021 09:52:16 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mZVVA-0000Xq-EV; Sun, 10 Oct 2021 09:52:16 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mZVVA-0002xQ-3N; Sun, 10 Oct 2021 09:52:16 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mZVVA-0005E9-2p; Sun, 10 Oct 2021 09:52:16 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=Rqo/Db6plo4XW98CxFnlS/I2emyv69PYnSR1yRTD3ik=; b=02q7tueNH9W+gi8qxfuYod2bOK
	gGZf87a5PBntaCEg/7UNpX6TGabSlq3QiAJP/PFAhfs0OJkmf45aRzcv61TPECMLOiUo0bf/QOU/m
	R2YgH2PHJ3sP8XeQ6skiAG0SFIiyrzJis6mYFeAOv1AjVPkdX7Vu1ZbbIbIUikAs5RhA=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165453-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-coverity test] 165453: all pass - PUSHED
X-Osstest-Versions-This:
    xen=664cc3c3d381e4f9a61dcb68cbd7a6a00070370e
X-Osstest-Versions-That:
    xen=192aaf7e146c0b41dbdd35ccdb13eb33ced13633
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 10 Oct 2021 09:52:16 +0000

flight 165453 xen-unstable-coverity real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165453/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 xen                  664cc3c3d381e4f9a61dcb68cbd7a6a00070370e
baseline version:
 xen                  192aaf7e146c0b41dbdd35ccdb13eb33ced13633

Last test of basis   165397  2021-10-06 09:21:13 Z    4 days
Testing same since   165453  2021-10-10 09:19:39 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Anthony PERARD <anthony.perard@citrix.com>
  Bob Eshleman <bobbyeshleman@gmail.com>
  Christian Lindig <christian.lindig@citrix.com>
  Connor Davis <connojdavis@gmail.com>
  Jan Beulich <jbeulich@suse.com>
  Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
  Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
  Rahul Singh <rahul.singh@arm.com>
  Stefano Stabellini <sstabellini@kernel.org>
  Stefano Stabellini <stefano.stabellini@xilinx.com>
  Volodymyr Babchuk <volodymyr_babchuk@epam.com>

jobs:
 coverity-amd64                                               pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   192aaf7e14..664cc3c3d3  664cc3c3d381e4f9a61dcb68cbd7a6a00070370e -> coverity-tested/smoke


From xen-devel-bounces@lists.xenproject.org Sun Oct 10 10:40:55 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 10 Oct 2021 10:40:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.205296.360568 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZWG2-0001uY-Dc; Sun, 10 Oct 2021 10:40:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 205296.360568; Sun, 10 Oct 2021 10:40:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZWG2-0001uR-Ai; Sun, 10 Oct 2021 10:40:42 +0000
Received: by outflank-mailman (input) for mailman id 205296;
 Sun, 10 Oct 2021 10:40:40 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mZWG0-0001uG-Pz; Sun, 10 Oct 2021 10:40:40 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mZWG0-0001Oq-HD; Sun, 10 Oct 2021 10:40:40 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mZWG0-0004fC-4x; Sun, 10 Oct 2021 10:40:40 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mZWG0-0002bz-4Q; Sun, 10 Oct 2021 10:40:40 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=0US1YVuVtvd7ywveCJSXpbdkjVxufnBRR7Aw3xsGaYA=; b=DqEt7lHciJkzvV5bzQa/9bIftU
	brfM49mq/qc5w7lVcpBkOboHs8GgSCW2JQNhzG6dyifh8fVzSszcqmsn88xl7IFUbDex5F4dKMuQ0
	oMbxtasXj5tFcheFtVaNnkyXnmFJXKddhlEeYxh7dCVhL0SC1S4VVTyCoMf5g93LmZ5E=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165449-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-5.4 test] 165449: regressions - FAIL
X-Osstest-Failures:
    linux-5.4:test-armhf-armhf-xl-credit1:guest-start:fail:regression
    linux-5.4:test-amd64-amd64-examine:memdisk-try-append:fail:heisenbug
    linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:guest-start/debian.repeat:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=faaca480fd5cd1976b6db743c43ac1f8d583de72
X-Osstest-Versions-That:
    linux=e74e2950a0d6f800858e54860d7124c86e494f62
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 10 Oct 2021 10:40:40 +0000

flight 165449 linux-5.4 real [real]
flight 165454 linux-5.4 real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/165449/
http://logs.test-lab.xenproject.org/osstest/logs/165454/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-armhf-armhf-xl-credit1  14 guest-start              fail REGR. vs. 165206

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-examine      4 memdisk-try-append  fail pass in 165454-retest

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165206
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 165206
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 165206
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 165206
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165206
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165206
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 165206
 test-arm64-arm64-libvirt-raw 17 guest-start/debian.repeat    fail  like 165206
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 165206
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 165206
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 165206
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 165206
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 165206
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 linux                faaca480fd5cd1976b6db743c43ac1f8d583de72
baseline version:
 linux                e74e2950a0d6f800858e54860d7124c86e494f62

Last test of basis   165206  2021-09-26 12:42:13 Z   13 days
Failing since        165346  2021-10-04 12:42:32 Z    5 days    7 attempts
Testing same since   165449  2021-10-09 23:12:14 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Alan Stern <stern@rowland.harvard.edu>
  Alex Deucher <alexander.deucher@amd.com>
  Alexei Starovoitov <ast@kernel.org>
  Anand K Mistry <amistry@google.com>
  Anders Roxell <anders.roxell@linaro.org>
  Andrea Claudi <aclaudi@redhat.com>
  Andreas Larsson <andreas@gaisler.com>
  Andrej Shadura <andrew.shadura@collabora.co.uk>
  Andrew Morton <akpm@linux-foundation.org>
  Andy Shevchenko <andriy.shevchenko@linux.intel.com>
  Anirudh Rayabharam <mail@anirudhrb.com>
  Anson Jacob <Anson.Jacob@amd.com>
  Antoine Tenart <atenart@kernel.org>
  Anton Eidelman <anton.eidelman@gmail.com>
  Anton Eidelman <anton@lightbitslabs.com>
  Ariel Elior <aelior@marvell.com>
  Arnd Bergmann <arnd@arndb.de>
  Aswath Govindraju <a-govindraju@ti.com>
  Aya Levin <ayal@nvidia.com>
  Baokun Li <libaokun1@huawei.com>
  Bartosz Golaszewski <brgl@bgdev.pl>
  Bixuan Cui <cuibixuan@huawei.com>
  Bjorn Helgaas <bhelgaas@google.com>
  Borislav Petkov <bp@suse.de>
  Carlo Lobrano <c.lobrano@gmail.com>
  Catalin Marinas <catalin.marinas@arm.com>
  Changbin Du <changbin.du@gmail.com>
  Charlene Liu <Charlene.Liu@amd.com>
  Chen Jingwen <chenjingwen6@huawei.com>
  Chih-Kang Chang <gary.chang@realtek.com>
  Chris Chiu <chris.chiu@canonical.com>
  Christian Brauner <christian.brauner@ubuntu.com>
  Christoph Hellwig <hch@lst.de>
  Claudiu Manoil <claudiu.manoil@nxp.com>
  Cong Wang <cong.wang@bytedance.com>
  Dan Carpenter <dan.carpenter@oracle.com>
  Dan Li <ashimida@linux.alibaba.com>
  Dan Williams <dan.j.williams@intel.com>
  Daniel Borkmann <daniel@iogearbox.net>
  Daniel Lezcano <daniel.lezcano@linaro.org>
  Daniel Wheeler <daniel.wheeler@amd.com>
  David Howells <dhowells@redhat.com>
  David S. Miller <davem@davemloft.net>
  David Sterba <dsterba@suse.com>
  Dmitry Bogdanov <d.bogdanov@yadro.com>
  Dongliang Mu <mudongliangabcd@gmail.com>
  Eric Biggers <ebiggers@google.com>
  Eric Dumazet <edumazet@google.com>
  F.A. SULAIMAN <asha.16@itfac.mrt.ac.lk>
  F.A.Sulaiman <asha.16@itfac.mrt.ac.lk>
  Faizel K B <faizel.kb@dicortech.com>
  Fares Mehanna <faresx@amazon.de>
  Felipe Balbi <balbi@kernel.org>
  Florian Fainelli <f.fainelli@gmail.com>
  Gao Xiang <hsiangkao@linux.alibaba.com>
  Geert Uytterhoeven <geert@linux-m68k.org>
  Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  Gregory CLEMENT <gregory.clement@bootlin.com>
  Guangbin Huang <huangguangbin2@huawei.com>
  Guenter Roeck <linux@roeck-us.net>
  Hans de Goede <hdegoede@redhat.com>
  Helge Deller <deller@gmx.de>
  Herbert Xu <herbert@gondor.apana.org.au>
  Hulk Robot <hulkrobot@huawei.com>
  Igor Matheus Andrade Torrente <igormtorrente@gmail.com>
  J. Bruce Fields <bfields@redhat.com>
  Jacob Keller <jacob.e.keller@intel.com>
  James Morse <james.morse@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Jan Kara <jack@suse.cz>
  Jeffle Xu <jefflexu@linux.alibaba.com>
  Jens Axboe <axboe@kernel.dk>
  Jesper Nilsson <jesper.nilsson@axis.com>
  Jian Shen <shenjian15@huawei.com>
  Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
  Jiri Benc <jbenc@redhat.com>
  Jiri Kosina <jkosina@suse.cz>
  Jiri Slaby <jslaby@suse.cz>
  Johan Hovold <johan@kernel.org>
  Johannes Berg <johannes.berg@intel.com>
  Johannes Thumshirn <jth@kernel.org>
  John Allen <john.allen@amd.com>
  Jon Hunter <jonathanh@nvidia.com>
  Jonathan Hsu <jonathan.hsu@mediatek.com>
  Jozsef Kadlecsik <kadlec@netfilter.org>
  Juergen Gross <jgross@suse.com>
  Julian Anastasov <ja@ssi.bg>
  Julian Sikorski <belegdol+github@gmail.com>
  Julian Sikorski <belegdol@gmail.com>
  Kaige Fu <kaige.fu@linux.alibaba.com>
  Kan Liang <kan.liang@linux.intel.com>
  Karsten Graul <kgraul@linux.ibm.com>
  Kate Hsuan <hpa@redhat.com>
  Kevin Hao <haokexin@gmail.com>
  Kishon Vijay Abraham I <kishon@ti.com>
  Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
  Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
  Leon Yu <leoyu@nvidia.com>
  Li Jinlin <lijinlin3@huawei.com>
  Li Zhijian <lizhijian@cn.fujitsu.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Linux Kernel Functional Testing <lkft@linaro.org>
  Lorenzo Bianconi <lorenzo@kernel.org>
  Marc Zyngier <maz@kernel.org>
  Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
  Mark Rutland <mark.rutland@arm.com>
  Markus Suvanto <markus.suvanto@gmail.com>
  Martin K. Petersen <martin.petersen@oracle.com>
  Michael Chan <michael.chan@broadcom.com>
  Michael Chan <michael.chan@broadocm.com>
  Michal Kalderon <mkalderon@marvell.com>
  Minas Harutyunyan <Minas.Harutyunyan@synopsys.com>
  Ming Lei <ming.lei@redhat.com>
  Moritz Fischer <mdf@kernel.org>
  Nadezda Lutovinova <lutovinova@ispras.ru>
  Nicolas Ferre <nicolas.ferre@microchip.com>
  Nirmoy Das <nirmoy.das@amd.com>
  Oliver Neukum <oneukum@suse.com>
  Ondrej Zary <linux@zary.sk>
  Ovidiu Panait <ovidiu.panait@windriver.com>
  Pablo Neira Ayuso <pablo@netfilter.org>
  Pali Rohár <pali@kernel.org>
  Paolo Bonzini <pbonzini@redhat.com>
  Paul Fertser <fercerpav@gmail.com>
  Pawel Laszczak <pawell@cadence.com>
  Peter Zijlstra (Intel) <peterz@infradead.org>
  Ping-Ke Shih <pkshih@realtek.com>
  Qu Wenruo <wqu@suse.com>
  Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
  Randy Dunlap <rdunlap@infradead.org>
  Rik van Riel <riel@surriel.com>
  Ritesh Harjani <riteshh@linux.ibm.com>
  Rob Herring <robh@kernel.org>
  Ronnie Sahlberg <lsahlber@redhat.com>
  Sai Krishna Potthuri <lakshmi.sai.krishna.potthuri@xilinx.com>
  Samuel Iglesias Gonsalvez <siglesias@igalia.com>
  Sasha Levin <sashal@kernel.org>
  Sergey Senozhatsky <senozhatsky@chromium.org>
  Shai Malin <smalin@marvell.com>
  Shuah Khan <skhan@linuxfoundation.org>
  Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
  Simon Horman <horms@verge.net.au>
  Slark Xiao <slark_xiao@163.com>
  Song Liu <songliubraving@fb.com>
  Srinivas Pandruvada <srinivas.pI andruvada@linux.intel.com>
  Steve French <stfrench@microsoft.com>
  Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
  sumiyawang <sumiyawang@tencent.com>
  syzbot+47b26cd837ececfc666d@syzkaller.appspotmail.com
  syzbot+fadc0aaf497e6a493b9f@syzkaller.appspotmail.com
  Tariq Toukan <tariqt@nvidia.com>
  Tejun Heo <tj@kernel.org>
  Theodore Ts'o <tytso@mit.edu>
  Todd Kjos <tkjos@google.com>
  Tom Rix <trix@redhat.com>
  Tong Zhang <ztong0001@gmail.com>
  Tony Nguyen <anthony.l.nguyen@intel.com>
  Tyler Hicks <tyhicks@linux.microsoft.com>
  Uwe Brandt <uwe.brandt@gmail.com>
  Vadim Pasternak <vadimp@nvidia.com>
  Viresh Kumar <viresh.kumar@linaro.org>
  Vlad Buslov <vladbu@nvidia.com>
  Vladimir Oltean <vladimir.oltean@nxp.com>
  Wen Xiong <wenxiong@linux.ibm.com>
  Wengang Wang <wen.gang.wang@oracle.com>
  Xiao Liang <shaw.leon@gmail.com>
  Xin Long <lucien.xin@gmail.com>
  Yang Yingliang <yangyingliang@huawei.com>
  yangerkun <yangerkun@huawei.com>
  Yonghong Song <yhs@fb.com>
  Zelin Deng <zelin.deng@linux.alibaba.com>
  zhang kai <zhangkaiheb@126.com>
  Zhihao Cheng <chengzhihao1@huawei.com>
  Zong-Zhe Yang <kevin_yang@realtek.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 fail    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 4201 lines long.)


From xen-devel-bounces@lists.xenproject.org Sun Oct 10 10:48:32 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 10 Oct 2021 10:48:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.205307.360583 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZWNY-0002h6-Gs; Sun, 10 Oct 2021 10:48:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 205307.360583; Sun, 10 Oct 2021 10:48:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZWNY-0002gz-Bb; Sun, 10 Oct 2021 10:48:28 +0000
Received: by outflank-mailman (input) for mailman id 205307;
 Sun, 10 Oct 2021 10:48:27 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mZWNW-0002gp-Vc; Sun, 10 Oct 2021 10:48:26 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mZWNW-0001XN-RW; Sun, 10 Oct 2021 10:48:26 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mZWNW-0004uN-Fd; Sun, 10 Oct 2021 10:48:26 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mZWNW-0006H1-FA; Sun, 10 Oct 2021 10:48:26 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=fQYnTLVNjXwjsmzTM04kqabKaA+uIJvWjf0De7nLGWg=; b=lcokfz77vJOXp67B5FNTuJ+i2c
	UIzrrBT9m3fV+l1hkU2o0TumWRlbXgBeQwdg9hiFiHa5/dKwOClX4XU1xt0FqTftie/3OY1SAS42a
	dtfIPqr7CtJI6y1zdPmvlzwt75QjNgP9eCRpj2f0bWFysIsatehnKlqa6pRJqFfN17tI=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165451-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 165451: regressions - FAIL
X-Osstest-Failures:
    libvirt:build-amd64-libvirt:libvirt-build:fail:regression
    libvirt:build-armhf-libvirt:libvirt-build:fail:regression
    libvirt:build-arm64-libvirt:libvirt-build:fail:regression
    libvirt:build-i386-libvirt:libvirt-build:fail:regression
    libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    libvirt=1b9ce05ce241a581d4e80228c92ceb0266f21f94
X-Osstest-Versions-That:
    libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 10 Oct 2021 10:48:26 +0000

flight 165451 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165451/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-armhf-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-arm64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-i386-libvirt            6 libvirt-build            fail REGR. vs. 151777

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-libvirt-vhd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a

version targeted for testing:
 libvirt              1b9ce05ce241a581d4e80228c92ceb0266f21f94
baseline version:
 libvirt              2c846fa6bcc11929c9fb857a22430fb9945654ad

Last test of basis   151777  2020-07-10 04:19:19 Z  457 days
Failing since        151818  2020-07-11 04:18:52 Z  456 days  442 attempts
Testing same since   165441  2021-10-09 04:18:51 Z    1 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
    Adolfo Jayme Barrientos <fitoschido@gmail.com>
  Aleksandr Alekseev <alexander.alekseev@virtuozzo.com>
  Aleksei Zakharov <zaharov@selectel.ru>
  Andika Triwidada <andika@gmail.com>
  Andrea Bolognani <abologna@redhat.com>
  Ani Sinha <ani@anisinha.ca>
  Balázs Meskó <meskobalazs@mailbox.org>
  Barrett Schonefeld <bschoney@utexas.edu>
  Bastian Germann <bastiangermann@fishpost.de>
  Bastien Orivel <bastien.orivel@diateam.net>
  BiaoXiang Ye <yebiaoxiang@huawei.com>
  Bihong Yu <yubihong@huawei.com>
  Binfeng Wu <wubinfeng@huawei.com>
  Bjoern Walk <bwalk@linux.ibm.com>
  Boris Fiuczynski <fiuczy@linux.ibm.com>
  Brian Turek <brian.turek@gmail.com>
  Bruno Haible <bruno@clisp.org>
  Chris Mayo <aklhfex@gmail.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Ehrhardt <christian.ehrhardt@canonical.com>
  Christian Kirbach <christian.kirbach@gmail.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Cole Robinson <crobinso@redhat.com>
  Collin Walling <walling@linux.ibm.com>
  Cornelia Huck <cohuck@redhat.com>
  Cédric Bosdonnat <cbosdonnat@suse.com>
  Côme Borsoi <fedora@borsoi.fr>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniel Letai <dani@letai.org.il>
  Daniel P. Berrange <berrange@redhat.com>
  Daniel P. Berrangé <berrange@redhat.com>
  Didik Supriadi <didiksupriadi41@gmail.com>
  dinglimin <dinglimin@cmss.chinamobile.com>
  Dmytro Linkin <dlinkin@nvidia.com>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Eric Farman <farman@linux.ibm.com>
  Erik Skultety <eskultet@redhat.com>
  Fabian Affolter <mail@fabian-affolter.ch>
  Fabian Freyer <fabian.freyer@physik.tu-berlin.de>
  Fabiano Fidêncio <fabiano@fidencio.org>
  Fangge Jin <fjin@redhat.com>
  Farhan Ali <alifm@linux.ibm.com>
  Fedora Weblate Translation <i18n@lists.fedoraproject.org>
  gongwei <gongwei@smartx.com>
  Guoyi Tu<tu.guoyi@h3c.com>
  Göran Uddeborg <goeran@uddeborg.se>
  Halil Pasic <pasic@linux.ibm.com>
  Han Han <hhan@redhat.com>
  Hao Wang <wanghao232@huawei.com>
  Hela Basa <r45xveza@pm.me>
  Helmut Grohne <helmut@subdivi.de>
  Hiroki Narukawa <hnarukaw@yahoo-corp.jp>
  Ian Wienand <iwienand@redhat.com>
  Jakob Meng <jakobmeng@web.de>
  Jamie Strandboge <jamie@canonical.com>
  Jamie Strandboge <jamie@ubuntu.com>
  Jan Kuparinen <copper_fin@hotmail.com>
  jason lee <ppark5237@gmail.com>
  Jean-Baptiste Holcroft <jean-baptiste@holcroft.fr>
  Jia Zhou <zhou.jia2@zte.com.cn>
  Jianan Gao <jgao@redhat.com>
  Jim Fehlig <jfehlig@suse.com>
  Jin Yan <jinyan12@huawei.com>
  Jinsheng Zhang <zhangjl02@inspur.com>
  Jiri Denemark <jdenemar@redhat.com>
  John Ferlan <jferlan@redhat.com>
  Jonathan Watt <jwatt@jwatt.org>
  Jonathon Jongsma <jjongsma@redhat.com>
  Julio Faracco <jcfaracco@gmail.com>
  Justin Gatzen <justin.gatzen@gmail.com>
  Ján Tomko <jtomko@redhat.com>
  Kashyap Chamarthy <kchamart@redhat.com>
  Kevin Locke <kevin@kevinlocke.name>
  Kristina Hanicova <khanicov@redhat.com>
  Laine Stump <laine@redhat.com>
  Laszlo Ersek <lersek@redhat.com>
  Lee Yarwood <lyarwood@redhat.com>
  Lei Yang <yanglei209@huawei.com>
  Liao Pingfang <liao.pingfang@zte.com.cn>
  Lin Ma <lma@suse.com>
  Lin Ma <lma@suse.de>
  Lin Ma <morecache@gmail.com>
  Liu Yiding <liuyd.fnst@fujitsu.com>
  Luke Yue <lukedyue@gmail.com>
  Luyao Zhong <luyao.zhong@intel.com>
  Marc Hartmayer <mhartmay@linux.ibm.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Markus Schade <markus.schade@hetzner.com>
  Martin Kletzander <mkletzan@redhat.com>
  Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
  Matej Cepl <mcepl@cepl.eu>
  Matt Coleman <matt@datto.com>
  Matt Coleman <mcoleman@datto.com>
  Mauro Matteo Cascella <mcascell@redhat.com>
  Meina Li <meili@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Michał Smyk <fedora@smyk.it>
  Milo Casagrande <milo@milo.name>
  Moshe Levi <moshele@nvidia.com>
  Muha Aliss <muhaaliss@gmail.com>
  Nathan <nathan95@live.it>
  Neal Gompa <ngompa13@gmail.com>
  Nick Chevsky <nchevsky@gmail.com>
  Nick Shyrokovskiy <nshyrokovskiy@gmail.com>
  Nickys Music Group <nickys.music.group@gmail.com>
  Nico Pache <npache@redhat.com>
  Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
  Olaf Hering <olaf@aepfle.de>
  Olesya Gerasimenko <gammaray@basealt.ru>
  Orion Poplawski <orion@nwra.com>
  Pany <geekpany@gmail.com>
  Patrick Magauran <patmagauran.j@gmail.com>
  Paulo de Rezende Pinatti <ppinatti@linux.ibm.com>
  Pavel Hrdina <phrdina@redhat.com>
  Peng Liang <liangpeng10@huawei.com>
  Peter Krempa <pkrempa@redhat.com>
  Pino Toscano <ptoscano@redhat.com>
  Pino Toscano <toscano.pino@tiscali.it>
  Piotr Drąg <piotrdrag@gmail.com>
  Prathamesh Chavan <pc44800@gmail.com>
  Richard W.M. Jones <rjones@redhat.com>
  Ricky Tigg <ricky.tigg@gmail.com>
  Robin Lee <cheeselee@fedoraproject.org>
  Roman Bogorodskiy <bogorodskiy@gmail.com>
  Roman Bolshakov <r.bolshakov@yadro.com>
  Ryan Gahagan <rgahagan@cs.utexas.edu>
  Ryan Schmidt <git@ryandesign.com>
  Sam Hartman <hartmans@debian.org>
  Scott Shambarger <scott-libvirt@shambarger.net>
  Sebastian Mitterle <smitterl@redhat.com>
  SeongHyun Jo <caelus9536@gmail.com>
  Shalini Chellathurai Saroja <shalini@linux.ibm.com>
  Shaojun Yang <yangshaojun@phytium.com.cn>
  Shi Lei <shi_lei@massclouds.com>
  simmon <simmon@nplob.com>
  Simon Chopin <chopin.simon@gmail.com>
  Simon Gaiser <simon@invisiblethingslab.com>
  Simon Rowe <simon.rowe@nutanix.com>
  Stefan Bader <stefan.bader@canonical.com>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Berger <stefanb@linux.vnet.ibm.com>
  Stefan Hajnoczi <stefanha@gmail.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Szymon Scholz <szymonscholz@gmail.com>
  Thomas Huth <thuth@redhat.com>
  Tim Wiederhake <twiederh@redhat.com>
  Tomáš Golembiovský <tgolembi@redhat.com>
  Tomáš Janoušek <tomi@nomi.cz>
  Tuguoyi <tu.guoyi@h3c.com>
  Victor Toso <victortoso@redhat.com>
  Ville Skyttä <ville.skytta@iki.fi>
  Vinayak Kale <vkale@nvidia.com>
  Wang Xin <wangxinxin.wang@huawei.com>
  WangJian <wangjian161@huawei.com>
  Weblate <noreply@weblate.org>
  Wei Liu <liuwe@microsoft.com>
  Wei Liu <wei.liu@kernel.org>
  William Douglas <william.douglas@intel.com>
  Yalei Li <274268859@qq.com>
  Yalei Li <liyl43@chinatelecom.cn>
  Yang Fei <yangfei85@huawei.com>
  Yang Hang <yanghang44@huawei.com>
  Yanqiu Zhang <yanqzhan@redhat.com>
  Yaroslav Kargin <ykargin@virtuozzo.com>
  Yi Li <yili@winhong.com>
  Yi Wang <wang.yi59@zte.com.cn>
  Yuri Chornoivan <yurchor@ukr.net>
  Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
  zhangjl02 <zhangjl02@inspur.com>
  Zheng Chuan <zhengchuan@huawei.com>
  zhenwei pi <pizhenwei@bytedance.com>
  Zhenyu Ye <yezhenyu2@huawei.com>
  Zhenyu Zheng <zheng.zhenyu@outlook.com>
  Zhenzhong Duan <zhenzhong.duan@intel.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          fail    
 build-arm64-libvirt                                          fail    
 build-armhf-libvirt                                          fail    
 build-i386-libvirt                                           fail    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           blocked 
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-libvirt-xsm                                 blocked 
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-libvirt                                     blocked 
 test-arm64-arm64-libvirt                                     blocked 
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-libvirt-pair                                blocked 
 test-amd64-i386-libvirt-pair                                 blocked 
 test-arm64-arm64-libvirt-qcow2                               blocked 
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-libvirt-vhd                                 blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 77226 lines long.)


From xen-devel-bounces@lists.xenproject.org Sun Oct 10 13:14:25 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 10 Oct 2021 13:14:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.205331.360596 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZYeZ-0008AU-EU; Sun, 10 Oct 2021 13:14:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 205331.360596; Sun, 10 Oct 2021 13:14:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZYeZ-0008AN-B6; Sun, 10 Oct 2021 13:14:11 +0000
Received: by outflank-mailman (input) for mailman id 205331;
 Sun, 10 Oct 2021 13:14:09 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mZYeX-00089u-Ol; Sun, 10 Oct 2021 13:14:09 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mZYeX-0003ri-FQ; Sun, 10 Oct 2021 13:14:09 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mZYeX-0002Iw-43; Sun, 10 Oct 2021 13:14:09 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mZYeX-0003jH-3a; Sun, 10 Oct 2021 13:14:09 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=pLTPA6LAOVMRrp8coCfpyY58wHgt3KazisIosdlGQFY=; b=eyXYDTS9mdln3Su6Pv0i2jH0L1
	LLD9ei3GlVhT8meMZbDxHOjbSK/RzO0iNPtcuueN4dBSrwTFjtIoc+/AWee8LmvYr2LoyUZNuZKrW
	F0MMgW2wwHxo04xFIYIiFZaQCILXJtL+bnzcj/ebA9wV2yJk246AUT+0b7PAtwgUwGcs=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165450-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 165450: regressions - FAIL
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-examine:memdisk-try-append:fail:regression
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=7fd2bf83d59a2d32e0d596c5d3e623b9a0e7e2d5
X-Osstest-Versions-That:
    linux=deacdb3e3979979016fcd0ffd518c320a62ad166
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 10 Oct 2021 13:14:09 +0000

flight 165450 linux-linus real [real]
flight 165456 linux-linus real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/165450/
http://logs.test-lab.xenproject.org/osstest/logs/165456/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-amd64-amd64-examine      4 memdisk-try-append       fail REGR. vs. 152332

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail baseline untested
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 152332
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 152332
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 152332
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 152332
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 152332
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152332
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 152332
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 linux                7fd2bf83d59a2d32e0d596c5d3e623b9a0e7e2d5
baseline version:
 linux                deacdb3e3979979016fcd0ffd518c320a62ad166

Last test of basis   152332  2020-07-31 19:41:23 Z  435 days
Failing since        152366  2020-08-01 20:49:34 Z  434 days  748 attempts
Testing same since   165450  2021-10-10 00:10:43 Z    0 days    1 attempts

------------------------------------------------------------
7388 people touched revisions under test,
not listing them all

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 2288249 lines long.)


From xen-devel-bounces@lists.xenproject.org Sun Oct 10 18:18:08 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 10 Oct 2021 18:18:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.205343.360610 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZdOP-0001xD-WF; Sun, 10 Oct 2021 18:17:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 205343.360610; Sun, 10 Oct 2021 18:17:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZdOP-0001x6-T9; Sun, 10 Oct 2021 18:17:49 +0000
Received: by outflank-mailman (input) for mailman id 205343;
 Sun, 10 Oct 2021 18:17:48 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=bVSO=O6=gmail.com=christopher.w.clark@srs-us1.protection.inumbo.net>)
 id 1mZdOO-0001x0-O8
 for xen-devel@lists.xenproject.org; Sun, 10 Oct 2021 18:17:48 +0000
Received: from mail-qv1-xf34.google.com (unknown [2607:f8b0:4864:20::f34])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 81855371-7551-479d-a8ef-29d5c1246ae8;
 Sun, 10 Oct 2021 18:17:47 +0000 (UTC)
Received: by mail-qv1-xf34.google.com with SMTP id z3so9667004qvl.9
 for <xen-devel@lists.xenproject.org>; Sun, 10 Oct 2021 11:17:47 -0700 (PDT)
Received: from walnut.ice.pyrology.org (mobile-166-176-186-91.mycingular.net.
 [166.176.186.91])
 by smtp.gmail.com with ESMTPSA id r16sm692286qtt.22.2021.10.10.11.17.43
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sun, 10 Oct 2021 11:17:46 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 81855371-7551-479d-a8ef-29d5c1246ae8
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:mime-version
         :content-transfer-encoding;
        bh=OmZr8tAhhlb5VfxHgLq6UvIYtYcKLerkW54Z59ojch0=;
        b=Ju7vt6ah2CfOUUYohH87jQs5MAN7RG87UenCPFV43wUac+dv1eRvSd51ulNvvvS6ZD
         ogkOcPRXGtHXZoMyPfBHHvdC8rqsXe5xtyqv9V6kG3nEM7tbQxXHHcckvF1zMO6kGYhq
         ky4H4w2uhzpkIne/GfMHwEHJZgRAlU1MCPUAYVBweWJTUe38Qjr4uUS+vVpyiI38KA/8
         d2/ifC0KmSGX30/JYn0CeQKugFQALvdMGa0kAMuh7gW9PV35NdzETfB2hAG7ZrAy1/9E
         RsjUeKQr0NgtO/DhEzIZ7IqdA6HQ1V1AcLYHKmLvw0ufxv7PK8HbfnyqQQb8yGgeW0T+
         e90g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version
         :content-transfer-encoding;
        bh=OmZr8tAhhlb5VfxHgLq6UvIYtYcKLerkW54Z59ojch0=;
        b=ZX6QZLmhfejkB4u9unKqaS/DRaYiBzY7UQy+lAoue7aEnmO2tiUEwIDfo6SJ+vq5ck
         8I4A/7mo/11ePqlus83ndh6WMLFvWl3ykO/1YVvhRS6vxJXo2VsTAw8bsQwHhO+9XnEp
         Jm8JWN6R7KsHuVwAwIrebbhDhK52EXAvM9UM1qg5cJUyLC6w51qyvKU6PYWXJKCiIwMZ
         gMgBzskG7cMgfdpTQvU7YgFhVtbsL0qv2voRSsu+UM3ANXgiVqDiaoQMngpF/6QpVUKe
         DjUf5LsPEpRGOjxo7g8WGc0RqRsO3cTBDbjNHi0Qwp1cwOabqVBZT315ri0NbjwKLK7C
         aXpA==
X-Gm-Message-State: AOAM532bSP3LzIOs/v8MtniE9fd7CC5B0zGh1LUEA7E5LVb0E/VB1qbJ
	Hg+dXi2K4hsm738FbQEnVwgzKmumZaJ1WA==
X-Google-Smtp-Source: ABdhPJzamKDvnK5v3fBmA/vptcF7bH1lazP7LR7YTe9gZZwyr++VfkbJy1KsU2kFn9Qf4uLkz7MEJA==
X-Received: by 2002:ad4:4e0b:: with SMTP id dl11mr2009527qvb.23.1633889866844;
        Sun, 10 Oct 2021 11:17:46 -0700 (PDT)
From: Christopher Clark <christopher.w.clark@gmail.com>
To: xen-devel@lists.xenproject.org
Cc: Bertrand Marquis <bertrand.marquis@arm.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Ian Jackson <iwj@xenproject.org>,
	Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wl@xen.org>,
	Rich Persaud <persaur@gmail.com>,
	Daniel Smith <dpsmith@apertussolutions.com>,
	Jason Andryuk <jandryuk@gmail.com>,
	Eric Chanudet <chanudeter@gmail.com>,
	openxt@googlegroups.com
Subject: [PATCH v2] docs: add references to Argo Linux driver sources and information
Date: Sun, 10 Oct 2021 11:17:35 -0700
Message-Id: <20211010181735.406406-1-christopher.w.clark@gmail.com>
X-Mailer: git-send-email 2.25.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Add a section to the Argo design document to supply guidance on how to
enable Argo in Xen and where to obtain source code and documentation
for Argo device drivers for guest OSes, primarily from OpenXT.

Signed-off-by: Christopher Clark <christopher.w.clark@gmail.com>
Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>
---

Changes in v2: added R-by and fixed the two nits found in review:
 - removed an incorrect extra 'in'
 - refer to command line documentation rather than document

 docs/designs/argo.pandoc | 45 ++++++++++++++++++++++++++++++++++++++++
 1 file changed, 45 insertions(+)

diff --git a/docs/designs/argo.pandoc b/docs/designs/argo.pandoc
index 2ce253b654..e18aacea7c 100644
--- a/docs/designs/argo.pandoc
+++ b/docs/designs/argo.pandoc
@@ -439,6 +439,51 @@ that teardown of any domain will not interfere with any Argo hypercall
 operation. It enables introducing granular locking without complex or
 error-prone lock acquisition logic.
 
+# Related Material
+
+## Enabling Argo in Xen
+
+To enable Argo in a build of the Xen hypervisor, please ensure that
+CONFIG_ARGO is enabled in the Xen hypervisor build configuration file.
+
+To make Argo available for use at runtime on a Xen system, please see the
+Argo settings in the Xen command line documentation.
+
+## Linux Argo drivers
+
+A Linux kernel device driver for Argo and corresponding Linux userspace
+software, libargo, that utilizes it for interdomain communication between
+application level software is available and maintained by the OpenXT Project,
+at:
+
+https://github.com/OpenXT/linux-xen-argo
+
+The repository contains the primary Linux kernel Argo driver, which is derived
+from the original XenClient v4v driver. The document at the following link
+describes planning and design notes from OpenXT community discussion for
+improvements to the driver:
+
+https://openxt.atlassian.net/wiki/spaces/DC/pages/775389197/New+Linux+Driver+for+Argo
+
+An alternative Linux Argo driver is also available in the same repository,
+implemented to explore a different approach for Linux to use the Argo
+primitives under the Vsock address family to allow socket communication between
+Xen domains.
+
+## v4v drivers
+
+A Windows driver for v4v has previously been used in XenClient and OpenXT
+which could be ported to Argo. It may require update for compatibility with
+recent versions of Windows software.
+
+https://github.com/OpenXT/xc-windows/tree/master/xenv4v
+
+The Linux, Windows and OSX guest tools for the Open Source HP uxen hypervisor
+contain drivers for v4v which are relevant as code bases of interest for
+porting or developing new guest OS drivers for Argo.
+
+https://github.com/uxen-virt/uxen/tree/ascara/vm-support
+
 # Future Work
 
 - Performance measurement and optimization
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Sun Oct 10 19:54:11 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 10 Oct 2021 19:54:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.205351.360621 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZetO-0002n7-Qs; Sun, 10 Oct 2021 19:53:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 205351.360621; Sun, 10 Oct 2021 19:53:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZetO-0002n0-Mo; Sun, 10 Oct 2021 19:53:54 +0000
Received: by outflank-mailman (input) for mailman id 205351;
 Sun, 10 Oct 2021 19:53:53 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mZetN-0002mq-Ms; Sun, 10 Oct 2021 19:53:53 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mZetN-0002TZ-FF; Sun, 10 Oct 2021 19:53:53 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mZetN-0000kI-3z; Sun, 10 Oct 2021 19:53:53 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mZetN-0003qU-3L; Sun, 10 Oct 2021 19:53:53 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=wZljlRApHaDYbAh3y4yfFVx2DQOMUvFSpx2PyhJbOlc=; b=XAOXtCns72lm9ZWXjjwMMH3YfW
	uSRmRPf/qCU9gJrR9sd+4glkBCP2YBq+QmL+WRs0K2ltMDXzInmBsMrVkyIO5j6P6LCRG1/vUJwWO
	3jNXImoZN6AktzULADUfant3anTAQWvHQUUZMaybjdYZmV3RgQOq/kbw0RdSABc3IGZA=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165452-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 165452: tolerable FAIL
X-Osstest-Failures:
    xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=664cc3c3d381e4f9a61dcb68cbd7a6a00070370e
X-Osstest-Versions-That:
    xen=664cc3c3d381e4f9a61dcb68cbd7a6a00070370e
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 10 Oct 2021 19:53:53 +0000

flight 165452 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165452/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail in 165446 pass in 165452
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 165446

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 165446
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 165446
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165446
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165446
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 165446
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 165446
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 165446
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 165446
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 165446
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 165446
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165446
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 165446
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  664cc3c3d381e4f9a61dcb68cbd7a6a00070370e
baseline version:
 xen                  664cc3c3d381e4f9a61dcb68cbd7a6a00070370e

Last test of basis   165452  2021-10-10 06:49:57 Z    0 days
Testing same since                          (not found)         0 attempts

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 fail    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Published tested tree is already up to date.



From xen-devel-bounces@lists.xenproject.org Sun Oct 10 22:23:57 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 10 Oct 2021 22:23:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.205362.360636 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZhEN-000878-RW; Sun, 10 Oct 2021 22:23:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 205362.360636; Sun, 10 Oct 2021 22:23:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZhEN-000871-LG; Sun, 10 Oct 2021 22:23:43 +0000
Received: by outflank-mailman (input) for mailman id 205362;
 Sun, 10 Oct 2021 22:23:42 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mZhEM-00086r-Fs; Sun, 10 Oct 2021 22:23:42 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mZhEL-0004xw-Pj; Sun, 10 Oct 2021 22:23:41 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mZhEL-0005pf-EB; Sun, 10 Oct 2021 22:23:41 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mZhEL-000497-Dd; Sun, 10 Oct 2021 22:23:41 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=uDXkPf0j9bcIhfXSOgOkJa6FUhVR6PPnZsNxFO33OKw=; b=vpywXWEmjUWbGNFCD/Ze5nJnqz
	UwdltXAqQteqPNaPvKoKBpyJl0TagtGLj41/bxTeCYWcGFf25ElYu3Sv9i2BisYPOsDQIM+kkBMuE
	kPhDeOlsntt/iPczNgwALSFR1CXyKlg0u2YIIvmUlX/aFn78mVXJmWdj0IvNCFLkg/8s=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165455-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-5.4 test] 165455: regressions - FAIL
X-Osstest-Failures:
    linux-5.4:test-armhf-armhf-xl-credit1:guest-start:fail:regression
    linux-5.4:test-amd64-amd64-examine:memdisk-try-append:fail:heisenbug
    linux-5.4:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:heisenbug
    linux-5.4:test-arm64-arm64-libvirt-xsm:guest-start/debian.repeat:fail:heisenbug
    linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:heisenbug
    linux-5.4:test-arm64-arm64-libvirt-raw:guest-start/debian.repeat:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=faaca480fd5cd1976b6db743c43ac1f8d583de72
X-Osstest-Versions-That:
    linux=e74e2950a0d6f800858e54860d7124c86e494f62
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 10 Oct 2021 22:23:41 +0000

flight 165455 linux-5.4 real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165455/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-armhf-armhf-xl-credit1  14 guest-start              fail REGR. vs. 165206

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-examine    4 memdisk-try-append fail in 165449 pass in 165455
 test-amd64-amd64-xl-rtds     20 guest-localmigrate/x10     fail pass in 165449
 test-arm64-arm64-libvirt-xsm 18 guest-start/debian.repeat  fail pass in 165449
 test-armhf-armhf-xl-rtds     18 guest-start/debian.repeat  fail pass in 165449

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-libvirt-raw 17 guest-start/debian.repeat fail in 165449 like 165206
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165206
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 165206
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 165206
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 165206
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165206
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165206
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 165206
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 165206
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 165206
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 165206
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 165206
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 165206
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 linux                faaca480fd5cd1976b6db743c43ac1f8d583de72
baseline version:
 linux                e74e2950a0d6f800858e54860d7124c86e494f62

Last test of basis   165206  2021-09-26 12:42:13 Z   14 days
Failing since        165346  2021-10-04 12:42:32 Z    6 days    8 attempts
Testing same since   165449  2021-10-09 23:12:14 Z    0 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
  Alan Stern <stern@rowland.harvard.edu>
  Alex Deucher <alexander.deucher@amd.com>
  Alexei Starovoitov <ast@kernel.org>
  Anand K Mistry <amistry@google.com>
  Anders Roxell <anders.roxell@linaro.org>
  Andrea Claudi <aclaudi@redhat.com>
  Andreas Larsson <andreas@gaisler.com>
  Andrej Shadura <andrew.shadura@collabora.co.uk>
  Andrew Morton <akpm@linux-foundation.org>
  Andy Shevchenko <andriy.shevchenko@linux.intel.com>
  Anirudh Rayabharam <mail@anirudhrb.com>
  Anson Jacob <Anson.Jacob@amd.com>
  Antoine Tenart <atenart@kernel.org>
  Anton Eidelman <anton.eidelman@gmail.com>
  Anton Eidelman <anton@lightbitslabs.com>
  Ariel Elior <aelior@marvell.com>
  Arnd Bergmann <arnd@arndb.de>
  Aswath Govindraju <a-govindraju@ti.com>
  Aya Levin <ayal@nvidia.com>
  Baokun Li <libaokun1@huawei.com>
  Bartosz Golaszewski <brgl@bgdev.pl>
  Bixuan Cui <cuibixuan@huawei.com>
  Bjorn Helgaas <bhelgaas@google.com>
  Borislav Petkov <bp@suse.de>
  Carlo Lobrano <c.lobrano@gmail.com>
  Catalin Marinas <catalin.marinas@arm.com>
  Changbin Du <changbin.du@gmail.com>
  Charlene Liu <Charlene.Liu@amd.com>
  Chen Jingwen <chenjingwen6@huawei.com>
  Chih-Kang Chang <gary.chang@realtek.com>
  Chris Chiu <chris.chiu@canonical.com>
  Christian Brauner <christian.brauner@ubuntu.com>
  Christoph Hellwig <hch@lst.de>
  Claudiu Manoil <claudiu.manoil@nxp.com>
  Cong Wang <cong.wang@bytedance.com>
  Dan Carpenter <dan.carpenter@oracle.com>
  Dan Li <ashimida@linux.alibaba.com>
  Dan Williams <dan.j.williams@intel.com>
  Daniel Borkmann <daniel@iogearbox.net>
  Daniel Lezcano <daniel.lezcano@linaro.org>
  Daniel Wheeler <daniel.wheeler@amd.com>
  David Howells <dhowells@redhat.com>
  David S. Miller <davem@davemloft.net>
  David Sterba <dsterba@suse.com>
  Dmitry Bogdanov <d.bogdanov@yadro.com>
  Dongliang Mu <mudongliangabcd@gmail.com>
  Eric Biggers <ebiggers@google.com>
  Eric Dumazet <edumazet@google.com>
  F.A. SULAIMAN <asha.16@itfac.mrt.ac.lk>
  F.A.Sulaiman <asha.16@itfac.mrt.ac.lk>
  Faizel K B <faizel.kb@dicortech.com>
  Fares Mehanna <faresx@amazon.de>
  Felipe Balbi <balbi@kernel.org>
  Florian Fainelli <f.fainelli@gmail.com>
  Gao Xiang <hsiangkao@linux.alibaba.com>
  Geert Uytterhoeven <geert@linux-m68k.org>
  Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  Gregory CLEMENT <gregory.clement@bootlin.com>
  Guangbin Huang <huangguangbin2@huawei.com>
  Guenter Roeck <linux@roeck-us.net>
  Hans de Goede <hdegoede@redhat.com>
  Helge Deller <deller@gmx.de>
  Herbert Xu <herbert@gondor.apana.org.au>
  Hulk Robot <hulkrobot@huawei.com>
  Igor Matheus Andrade Torrente <igormtorrente@gmail.com>
  J. Bruce Fields <bfields@redhat.com>
  Jacob Keller <jacob.e.keller@intel.com>
  James Morse <james.morse@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Jan Kara <jack@suse.cz>
  Jeffle Xu <jefflexu@linux.alibaba.com>
  Jens Axboe <axboe@kernel.dk>
  Jesper Nilsson <jesper.nilsson@axis.com>
  Jian Shen <shenjian15@huawei.com>
  Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
  Jiri Benc <jbenc@redhat.com>
  Jiri Kosina <jkosina@suse.cz>
  Jiri Slaby <jslaby@suse.cz>
  Johan Hovold <johan@kernel.org>
  Johannes Berg <johannes.berg@intel.com>
  Johannes Thumshirn <jth@kernel.org>
  John Allen <john.allen@amd.com>
  Jon Hunter <jonathanh@nvidia.com>
  Jonathan Hsu <jonathan.hsu@mediatek.com>
  Jozsef Kadlecsik <kadlec@netfilter.org>
  Juergen Gross <jgross@suse.com>
  Julian Anastasov <ja@ssi.bg>
  Julian Sikorski <belegdol+github@gmail.com>
  Julian Sikorski <belegdol@gmail.com>
  Kaige Fu <kaige.fu@linux.alibaba.com>
  Kan Liang <kan.liang@linux.intel.com>
  Karsten Graul <kgraul@linux.ibm.com>
  Kate Hsuan <hpa@redhat.com>
  Kevin Hao <haokexin@gmail.com>
  Kishon Vijay Abraham I <kishon@ti.com>
  Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
  Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
  Leon Yu <leoyu@nvidia.com>
  Li Jinlin <lijinlin3@huawei.com>
  Li Zhijian <lizhijian@cn.fujitsu.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Linux Kernel Functional Testing <lkft@linaro.org>
  Lorenzo Bianconi <lorenzo@kernel.org>
  Marc Zyngier <maz@kernel.org>
  Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
  Mark Rutland <mark.rutland@arm.com>
  Markus Suvanto <markus.suvanto@gmail.com>
  Martin K. Petersen <martin.petersen@oracle.com>
  Michael Chan <michael.chan@broadcom.com>
  Michael Chan <michael.chan@broadocm.com>
  Michal Kalderon <mkalderon@marvell.com>
  Minas Harutyunyan <Minas.Harutyunyan@synopsys.com>
  Ming Lei <ming.lei@redhat.com>
  Moritz Fischer <mdf@kernel.org>
  Nadezda Lutovinova <lutovinova@ispras.ru>
  Nicolas Ferre <nicolas.ferre@microchip.com>
  Nirmoy Das <nirmoy.das@amd.com>
  Oliver Neukum <oneukum@suse.com>
  Ondrej Zary <linux@zary.sk>
  Ovidiu Panait <ovidiu.panait@windriver.com>
  Pablo Neira Ayuso <pablo@netfilter.org>
  Pali Rohár <pali@kernel.org>
  Paolo Bonzini <pbonzini@redhat.com>
  Paul Fertser <fercerpav@gmail.com>
  Pawel Laszczak <pawell@cadence.com>
  Peter Zijlstra (Intel) <peterz@infradead.org>
  Ping-Ke Shih <pkshih@realtek.com>
  Qu Wenruo <wqu@suse.com>
  Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
  Randy Dunlap <rdunlap@infradead.org>
  Rik van Riel <riel@surriel.com>
  Ritesh Harjani <riteshh@linux.ibm.com>
  Rob Herring <robh@kernel.org>
  Ronnie Sahlberg <lsahlber@redhat.com>
  Sai Krishna Potthuri <lakshmi.sai.krishna.potthuri@xilinx.com>
  Samuel Iglesias Gonsalvez <siglesias@igalia.com>
  Sasha Levin <sashal@kernel.org>
  Sergey Senozhatsky <senozhatsky@chromium.org>
  Shai Malin <smalin@marvell.com>
  Shuah Khan <skhan@linuxfoundation.org>
  Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
  Simon Horman <horms@verge.net.au>
  Slark Xiao <slark_xiao@163.com>
  Song Liu <songliubraving@fb.com>
  Srinivas Pandruvada <srinivas.pI andruvada@linux.intel.com>
  Steve French <stfrench@microsoft.com>
  Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
  sumiyawang <sumiyawang@tencent.com>
  syzbot+47b26cd837ececfc666d@syzkaller.appspotmail.com
  syzbot+fadc0aaf497e6a493b9f@syzkaller.appspotmail.com
  Tariq Toukan <tariqt@nvidia.com>
  Tejun Heo <tj@kernel.org>
  Theodore Ts'o <tytso@mit.edu>
  Todd Kjos <tkjos@google.com>
  Tom Rix <trix@redhat.com>
  Tong Zhang <ztong0001@gmail.com>
  Tony Nguyen <anthony.l.nguyen@intel.com>
  Tyler Hicks <tyhicks@linux.microsoft.com>
  Uwe Brandt <uwe.brandt@gmail.com>
  Vadim Pasternak <vadimp@nvidia.com>
  Viresh Kumar <viresh.kumar@linaro.org>
  Vlad Buslov <vladbu@nvidia.com>
  Vladimir Oltean <vladimir.oltean@nxp.com>
  Wen Xiong <wenxiong@linux.ibm.com>
  Wengang Wang <wen.gang.wang@oracle.com>
  Xiao Liang <shaw.leon@gmail.com>
  Xin Long <lucien.xin@gmail.com>
  Yang Yingliang <yangyingliang@huawei.com>
  yangerkun <yangerkun@huawei.com>
  Yonghong Song <yhs@fb.com>
  Zelin Deng <zelin.deng@linux.alibaba.com>
  zhang kai <zhangkaiheb@126.com>
  Zhihao Cheng <chengzhihao1@huawei.com>
  Zong-Zhe Yang <kevin_yang@realtek.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 fail    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     fail    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 4201 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Oct 11 00:50:22 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 00:50:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.205371.360649 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZjW3-0005So-7R; Mon, 11 Oct 2021 00:50:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 205371.360649; Mon, 11 Oct 2021 00:50:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZjW3-0005Sh-3V; Mon, 11 Oct 2021 00:50:07 +0000
Received: by outflank-mailman (input) for mailman id 205371;
 Mon, 11 Oct 2021 00:50:05 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mZjW1-0005IO-2B; Mon, 11 Oct 2021 00:50:05 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mZjW0-0007wE-Qy; Mon, 11 Oct 2021 00:50:04 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mZjW0-0003a0-Fk; Mon, 11 Oct 2021 00:50:04 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mZjW0-00030r-Et; Mon, 11 Oct 2021 00:50:04 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=u9rOp5WJWBeTb1C67qaTpwYTT4HkHbsCrVkAmShd0ck=; b=bz8TcEiivV9AaRm2aDZKMZLeyh
	kfgF5ZmsoT68reuX50kOC/LtbDC/1QwkcEee/pSvuCtLey1n2aEXeRWD4Xn4mIjmJyG8/ozwhYIMu
	f6KtrR2hhHVaridpGcOxa8COdgQR0VQ5WnmbUS70WxoGrTWQ3zF0/elGwAwgJnS10Vs4=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165457-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 165457: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=7fd2bf83d59a2d32e0d596c5d3e623b9a0e7e2d5
X-Osstest-Versions-That:
    linux=deacdb3e3979979016fcd0ffd518c320a62ad166
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 11 Oct 2021 00:50:04 +0000

flight 165457 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165457/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail baseline untested
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 152332
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 152332
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 152332
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 152332
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 152332
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152332
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 152332
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 linux                7fd2bf83d59a2d32e0d596c5d3e623b9a0e7e2d5
baseline version:
 linux                deacdb3e3979979016fcd0ffd518c320a62ad166

Last test of basis   152332  2020-07-31 19:41:23 Z  436 days
Failing since        152366  2020-08-01 20:49:34 Z  435 days  749 attempts
Testing same since   165450  2021-10-10 00:10:43 Z    1 days    2 attempts

------------------------------------------------------------
7388 people touched revisions under test,
not listing them all

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   deacdb3e39799..7fd2bf83d59a2  7fd2bf83d59a2d32e0d596c5d3e623b9a0e7e2d5 -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Mon Oct 11 06:15:02 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 06:15:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.205382.360663 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZoaF-0003jI-3D; Mon, 11 Oct 2021 06:14:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 205382.360663; Mon, 11 Oct 2021 06:14:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZoaE-0003j9-Sq; Mon, 11 Oct 2021 06:14:46 +0000
Received: by outflank-mailman (input) for mailman id 205382;
 Mon, 11 Oct 2021 06:14:45 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mZoaD-0003iz-Fg; Mon, 11 Oct 2021 06:14:45 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mZoaD-0007mR-5h; Mon, 11 Oct 2021 06:14:45 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mZoaC-0002cg-Ne; Mon, 11 Oct 2021 06:14:44 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mZoaC-00087M-MV; Mon, 11 Oct 2021 06:14:44 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=2S/hZBvB8nJAtiKZi9RGSxgVfzeBSv/PAez+jZC0H7E=; b=y3ZvDHIPzvsGUMsXTzb/OiWbz1
	IXF/+i3YkG/po3OmkjzB1We2TBVwuFi/x6/IVFzO81W/beTKWk/Tun8Dhp/4HQTvuT8+U+A8bzZeQ
	KB3EcMBmdOMK0wc3mK5X61HP75yaCy1ACTWoauELyDhDPJ9aoZm4C+b28gU2KzmxVKoQ=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165458-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-5.4 test] 165458: regressions - FAIL
X-Osstest-Failures:
    linux-5.4:test-armhf-armhf-xl-credit1:guest-start:fail:regression
    linux-5.4:test-amd64-amd64-examine:memdisk-try-append:fail:heisenbug
    linux-5.4:test-arm64-arm64-libvirt-xsm:guest-start/debian.repeat:fail:heisenbug
    linux-5.4:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:heisenbug
    linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:heisenbug
    linux-5.4:test-arm64-arm64-libvirt-raw:debian-di-install:fail:heisenbug
    linux-5.4:test-arm64-arm64-libvirt-raw:guest-start/debian.repeat:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=faaca480fd5cd1976b6db743c43ac1f8d583de72
X-Osstest-Versions-That:
    linux=e74e2950a0d6f800858e54860d7124c86e494f62
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 11 Oct 2021 06:14:44 +0000

flight 165458 linux-5.4 real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165458/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-armhf-armhf-xl-credit1  14 guest-start              fail REGR. vs. 165206

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-examine    4 memdisk-try-append fail in 165449 pass in 165458
 test-arm64-arm64-libvirt-xsm 18 guest-start/debian.repeat fail in 165455 pass in 165458
 test-amd64-amd64-xl-rtds     20 guest-localmigrate/x10     fail pass in 165449
 test-armhf-armhf-xl-rtds     18 guest-start/debian.repeat  fail pass in 165449
 test-arm64-arm64-libvirt-raw 12 debian-di-install          fail pass in 165455

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-libvirt-raw 17 guest-start/debian.repeat fail in 165449 like 165206
 test-arm64-arm64-libvirt-raw 14 migrate-support-check fail in 165449 never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail in 165449 never pass
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165206
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 165206
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 165206
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 165206
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165206
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165206
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 165206
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 165206
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 165206
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 165206
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 165206
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 165206
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 linux                faaca480fd5cd1976b6db743c43ac1f8d583de72
baseline version:
 linux                e74e2950a0d6f800858e54860d7124c86e494f62

Last test of basis   165206  2021-09-26 12:42:13 Z   14 days
Failing since        165346  2021-10-04 12:42:32 Z    6 days    9 attempts
Testing same since   165449  2021-10-09 23:12:14 Z    1 days    3 attempts

------------------------------------------------------------
People who touched revisions under test:
  Alan Stern <stern@rowland.harvard.edu>
  Alex Deucher <alexander.deucher@amd.com>
  Alexei Starovoitov <ast@kernel.org>
  Anand K Mistry <amistry@google.com>
  Anders Roxell <anders.roxell@linaro.org>
  Andrea Claudi <aclaudi@redhat.com>
  Andreas Larsson <andreas@gaisler.com>
  Andrej Shadura <andrew.shadura@collabora.co.uk>
  Andrew Morton <akpm@linux-foundation.org>
  Andy Shevchenko <andriy.shevchenko@linux.intel.com>
  Anirudh Rayabharam <mail@anirudhrb.com>
  Anson Jacob <Anson.Jacob@amd.com>
  Antoine Tenart <atenart@kernel.org>
  Anton Eidelman <anton.eidelman@gmail.com>
  Anton Eidelman <anton@lightbitslabs.com>
  Ariel Elior <aelior@marvell.com>
  Arnd Bergmann <arnd@arndb.de>
  Aswath Govindraju <a-govindraju@ti.com>
  Aya Levin <ayal@nvidia.com>
  Baokun Li <libaokun1@huawei.com>
  Bartosz Golaszewski <brgl@bgdev.pl>
  Bixuan Cui <cuibixuan@huawei.com>
  Bjorn Helgaas <bhelgaas@google.com>
  Borislav Petkov <bp@suse.de>
  Carlo Lobrano <c.lobrano@gmail.com>
  Catalin Marinas <catalin.marinas@arm.com>
  Changbin Du <changbin.du@gmail.com>
  Charlene Liu <Charlene.Liu@amd.com>
  Chen Jingwen <chenjingwen6@huawei.com>
  Chih-Kang Chang <gary.chang@realtek.com>
  Chris Chiu <chris.chiu@canonical.com>
  Christian Brauner <christian.brauner@ubuntu.com>
  Christoph Hellwig <hch@lst.de>
  Claudiu Manoil <claudiu.manoil@nxp.com>
  Cong Wang <cong.wang@bytedance.com>
  Dan Carpenter <dan.carpenter@oracle.com>
  Dan Li <ashimida@linux.alibaba.com>
  Dan Williams <dan.j.williams@intel.com>
  Daniel Borkmann <daniel@iogearbox.net>
  Daniel Lezcano <daniel.lezcano@linaro.org>
  Daniel Wheeler <daniel.wheeler@amd.com>
  David Howells <dhowells@redhat.com>
  David S. Miller <davem@davemloft.net>
  David Sterba <dsterba@suse.com>
  Dmitry Bogdanov <d.bogdanov@yadro.com>
  Dongliang Mu <mudongliangabcd@gmail.com>
  Eric Biggers <ebiggers@google.com>
  Eric Dumazet <edumazet@google.com>
  F.A. SULAIMAN <asha.16@itfac.mrt.ac.lk>
  F.A.Sulaiman <asha.16@itfac.mrt.ac.lk>
  Faizel K B <faizel.kb@dicortech.com>
  Fares Mehanna <faresx@amazon.de>
  Felipe Balbi <balbi@kernel.org>
  Florian Fainelli <f.fainelli@gmail.com>
  Gao Xiang <hsiangkao@linux.alibaba.com>
  Geert Uytterhoeven <geert@linux-m68k.org>
  Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  Gregory CLEMENT <gregory.clement@bootlin.com>
  Guangbin Huang <huangguangbin2@huawei.com>
  Guenter Roeck <linux@roeck-us.net>
  Hans de Goede <hdegoede@redhat.com>
  Helge Deller <deller@gmx.de>
  Herbert Xu <herbert@gondor.apana.org.au>
  Hulk Robot <hulkrobot@huawei.com>
  Igor Matheus Andrade Torrente <igormtorrente@gmail.com>
  J. Bruce Fields <bfields@redhat.com>
  Jacob Keller <jacob.e.keller@intel.com>
  James Morse <james.morse@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Jan Kara <jack@suse.cz>
  Jeffle Xu <jefflexu@linux.alibaba.com>
  Jens Axboe <axboe@kernel.dk>
  Jesper Nilsson <jesper.nilsson@axis.com>
  Jian Shen <shenjian15@huawei.com>
  Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
  Jiri Benc <jbenc@redhat.com>
  Jiri Kosina <jkosina@suse.cz>
  Jiri Slaby <jslaby@suse.cz>
  Johan Hovold <johan@kernel.org>
  Johannes Berg <johannes.berg@intel.com>
  Johannes Thumshirn <jth@kernel.org>
  John Allen <john.allen@amd.com>
  Jon Hunter <jonathanh@nvidia.com>
  Jonathan Hsu <jonathan.hsu@mediatek.com>
  Jozsef Kadlecsik <kadlec@netfilter.org>
  Juergen Gross <jgross@suse.com>
  Julian Anastasov <ja@ssi.bg>
  Julian Sikorski <belegdol+github@gmail.com>
  Julian Sikorski <belegdol@gmail.com>
  Kaige Fu <kaige.fu@linux.alibaba.com>
  Kan Liang <kan.liang@linux.intel.com>
  Karsten Graul <kgraul@linux.ibm.com>
  Kate Hsuan <hpa@redhat.com>
  Kevin Hao <haokexin@gmail.com>
  Kishon Vijay Abraham I <kishon@ti.com>
  Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
  Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
  Leon Yu <leoyu@nvidia.com>
  Li Jinlin <lijinlin3@huawei.com>
  Li Zhijian <lizhijian@cn.fujitsu.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Linux Kernel Functional Testing <lkft@linaro.org>
  Lorenzo Bianconi <lorenzo@kernel.org>
  Marc Zyngier <maz@kernel.org>
  Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
  Mark Rutland <mark.rutland@arm.com>
  Markus Suvanto <markus.suvanto@gmail.com>
  Martin K. Petersen <martin.petersen@oracle.com>
  Michael Chan <michael.chan@broadcom.com>
  Michael Chan <michael.chan@broadocm.com>
  Michal Kalderon <mkalderon@marvell.com>
  Minas Harutyunyan <Minas.Harutyunyan@synopsys.com>
  Ming Lei <ming.lei@redhat.com>
  Moritz Fischer <mdf@kernel.org>
  Nadezda Lutovinova <lutovinova@ispras.ru>
  Nicolas Ferre <nicolas.ferre@microchip.com>
  Nirmoy Das <nirmoy.das@amd.com>
  Oliver Neukum <oneukum@suse.com>
  Ondrej Zary <linux@zary.sk>
  Ovidiu Panait <ovidiu.panait@windriver.com>
  Pablo Neira Ayuso <pablo@netfilter.org>
  Pali Rohár <pali@kernel.org>
  Paolo Bonzini <pbonzini@redhat.com>
  Paul Fertser <fercerpav@gmail.com>
  Pawel Laszczak <pawell@cadence.com>
  Peter Zijlstra (Intel) <peterz@infradead.org>
  Ping-Ke Shih <pkshih@realtek.com>
  Qu Wenruo <wqu@suse.com>
  Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
  Randy Dunlap <rdunlap@infradead.org>
  Rik van Riel <riel@surriel.com>
  Ritesh Harjani <riteshh@linux.ibm.com>
  Rob Herring <robh@kernel.org>
  Ronnie Sahlberg <lsahlber@redhat.com>
  Sai Krishna Potthuri <lakshmi.sai.krishna.potthuri@xilinx.com>
  Samuel Iglesias Gonsalvez <siglesias@igalia.com>
  Sasha Levin <sashal@kernel.org>
  Sergey Senozhatsky <senozhatsky@chromium.org>
  Shai Malin <smalin@marvell.com>
  Shuah Khan <skhan@linuxfoundation.org>
  Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
  Simon Horman <horms@verge.net.au>
  Slark Xiao <slark_xiao@163.com>
  Song Liu <songliubraving@fb.com>
  Srinivas Pandruvada <srinivas.pI andruvada@linux.intel.com>
  Steve French <stfrench@microsoft.com>
  Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
  sumiyawang <sumiyawang@tencent.com>
  syzbot+47b26cd837ececfc666d@syzkaller.appspotmail.com
  syzbot+fadc0aaf497e6a493b9f@syzkaller.appspotmail.com
  Tariq Toukan <tariqt@nvidia.com>
  Tejun Heo <tj@kernel.org>
  Theodore Ts'o <tytso@mit.edu>
  Todd Kjos <tkjos@google.com>
  Tom Rix <trix@redhat.com>
  Tong Zhang <ztong0001@gmail.com>
  Tony Nguyen <anthony.l.nguyen@intel.com>
  Tyler Hicks <tyhicks@linux.microsoft.com>
  Uwe Brandt <uwe.brandt@gmail.com>
  Vadim Pasternak <vadimp@nvidia.com>
  Viresh Kumar <viresh.kumar@linaro.org>
  Vlad Buslov <vladbu@nvidia.com>
  Vladimir Oltean <vladimir.oltean@nxp.com>
  Wen Xiong <wenxiong@linux.ibm.com>
  Wengang Wang <wen.gang.wang@oracle.com>
  Xiao Liang <shaw.leon@gmail.com>
  Xin Long <lucien.xin@gmail.com>
  Yang Yingliang <yangyingliang@huawei.com>
  yangerkun <yangerkun@huawei.com>
  Yonghong Song <yhs@fb.com>
  Zelin Deng <zelin.deng@linux.alibaba.com>
  zhang kai <zhangkaiheb@126.com>
  Zhihao Cheng <chengzhihao1@huawei.com>
  Zong-Zhe Yang <kevin_yang@realtek.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 fail    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     fail    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 4201 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Oct 11 06:22:27 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 06:22:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.205391.360677 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZohb-00059u-RY; Mon, 11 Oct 2021 06:22:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 205391.360677; Mon, 11 Oct 2021 06:22:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZohb-00059n-NL; Mon, 11 Oct 2021 06:22:23 +0000
Received: by outflank-mailman (input) for mailman id 205391;
 Mon, 11 Oct 2021 06:22:23 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=9TNE=O7=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mZohb-00059h-2a
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 06:22:23 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 3227b8c8-2173-44f6-b802-f1ca7d9e0e0b;
 Mon, 11 Oct 2021 06:22:21 +0000 (UTC)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2168.outbound.protection.outlook.com [104.47.17.168])
 (Using TLS) by relay.mimecast.com with ESMTP id
 de-mta-34-IOp8gOFuOWGx5ACyO_erHg-1; Mon, 11 Oct 2021 08:22:19 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0402MB3392.eurprd04.prod.outlook.com (2603:10a6:803:7::26)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.25; Mon, 11 Oct
 2021 06:22:17 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4587.026; Mon, 11 Oct 2021
 06:22:17 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS9PR06CA0041.eurprd06.prod.outlook.com (2603:10a6:20b:463::16) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.25 via Frontend
 Transport; Mon, 11 Oct 2021 06:22:16 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3227b8c8-2173-44f6-b802-f1ca7d9e0e0b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1633933340;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=HCAH6vjRwTJkukXYXXbe5vn/S9xW0yV0Esn+bHehBQ4=;
	b=fZSnQcZMQAJ5SKsMvjxXRwTckxQkcoemY9q6BHBTp3WYGokLOqiZ75NmO8o5Ynzbs08pJA
	r0I3plJ17TwtYfrmBLGvI6o3kXDb9FR4KehYH4xXfRtzP5uJBf8ncK9Nhf2OUbGSflB6W6
	CEC2fqzqNUyE9+AeIwAT1V30+ZegkCg=
X-MC-Unique: IOp8gOFuOWGx5ACyO_erHg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=evgmQLC37Uo8GefsZn/HC0EDj4kiWJyACd9Kts0etg0+VSDKjFKGIawVOOi9O/Gks4HnJIV0JUHp5QHayiMkmILajbP1lOlOlxBpqN+DJkztL5Eo8UHSoUMWAqi1jHKABpSNwubC4Jh7NUYSUzOKRn+tqUhrpS9sSCbbdVhFaHlbRI6EprSYWyQDkTwRh10yGUHv/Bk+M8jHXjf8YDgKu+rs6c6u4jMbEk0b9DnLc9gx/S5GeI1HeSlOgCpC3n9xxDVitqd9W89Qy8FIkILEoErVExJ9dIxvZrZc/sqylbSD2a1patobxuGloUAPasp09OlSt4quBxA/ofp7XH5tmQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=3cfSuhUjCR2LRhze5ASoTxf+xtQqvwf8VHRb+u3awzE=;
 b=Zhzr3kP3JJ0jdk4QDEYvaVzDujS03HBLiywOQYbOFWD4Nvt9OuyH9AdQG3869Um4Kh4JujCoWWRFyR59RYHuWI7WJqThGEG5i8CeL55OVxcg3PB71RQ1SR5tU1barcg56RNs18aj+iKrcryHDq+QWEUlFTEUx/uBxqvO/6IwQsfvMMcVOaNKLb/ww4c9IH5m/63oDZy11sfrOp6Mr4FlZ2TTAD0KGWSbNrEc7dnER382tbFvNuvmADDnN1HHVnj8ZWFZdIatHAEnbdUh3JWgG+kB+f+3m9sFBBW4UnfcHEpqMk11NfvFXkaMCUM8v9/h5ERqF9evOnqOaQ3JtVJ94A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [PATCH] x86/PV32: fix physdev_op_compat handling
To: Andrew Cooper <andrew.cooper3@citrix.com>
CC: Wei Liu <wl@xen.org>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <e8d21433-2f4f-f662-dd45-1543da8f4caf@suse.com>
 <24595827-df68-816b-9356-935c3fb80746@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <ca849b62-042e-0e8e-c895-5d8a26241c92@suse.com>
Date: Mon, 11 Oct 2021 08:22:18 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <24595827-df68-816b-9356-935c3fb80746@citrix.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS9PR06CA0041.eurprd06.prod.outlook.com
 (2603:10a6:20b:463::16) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: d0645383-553f-4b38-079c-08d98c7f7912
X-MS-TrafficTypeDiagnostic: VI1PR0402MB3392:
X-Microsoft-Antispam-PRVS:
	<VI1PR0402MB33926EAD1BA467CC0A1A4016B3B59@VI1PR0402MB3392.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8273;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Ai7uAEY9wE3g6bUVG5QkXNkGy3YfXZD8zXz3sDMzP+a78y3CklgL4GqVJY1ae+gxEpWq3FvKlgW/Cu2rgbr9lh7CMxIK7obe/Xm8E6dN8/YSPcnu5YYARhtpOSGz+/DJJghtXKHLuy/ExaJKndM5Ozord2FGKLZ8LtoEGJCWlRe5Qmnj6yNVMXJ0h722FuvTynEfkHkVMt2tfhrrA11CnHWbwLCrCrXmZ7oAU1BqK33IrKvJD5ISuocoS9DGuFoL5rWQYFBKbcq85xOtrUcrMo8E9iMtRAdV9AjDVpaVxhv98kWSNbRZseAUXO6n5kZ+xDOBfxZz7SGTjUNfoT3/ESTrqhhANXtV3pY9QgqQuFfrWM0CiXxHjYpCDMWThjqUfhvy4tKHuFoa0oo34WIqhvNSwagORXr70PsEus71zF0JzSilYCeNMRlqhhSkb0snadKKMwx2cvy7/HqzPTqs+8JKsy5p8KSk156/7F0NspHNJb0ETQ1accBDl6IroIR5cntBLFulu4skeWVZmXMoBAmDVYA6a8U839l8AHBaX0xaVBcyoLUcsEwmsMFIE13GGhWwjujRJwVtGbksk2tjZGB/Ejm4HwlbOJP3H8nEHjuSQelalZKCGNk2gK9WD2oa1qMdSg6UDDGIrrnS3po2kj8UzGBAK9rdta7rBUvh1n5f2CxSHW2kq1M2O68SH0onYVIn4P0HRJCvDwQDw1hkMTimoAb1DV+PYuzEBWzfm9E=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(31686004)(38100700002)(66946007)(53546011)(8936002)(186003)(508600001)(31696002)(16576012)(66476007)(86362001)(66556008)(316002)(2906002)(4326008)(6916009)(956004)(36756003)(6486002)(26005)(8676002)(83380400001)(5660300002)(2616005)(54906003)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?gtWL1Qw0hKJXUd47MitguJtdtPSSMbMdYmaMPFuweXL0/xoO6oMe8hOzNpjl?=
 =?us-ascii?Q?iyZcjBtXWqYARX5FieZgwKBZ7BUmIOb7xroLfk9rscN0uD1Y8+wSG9kZbRxB?=
 =?us-ascii?Q?grCrn/MgHe/chk5tOZAwzLyItOAaVpqMZ0WO29MC1QdMhWFBUspcufVLGczE?=
 =?us-ascii?Q?wGMqX5e3LRSJrHFWm+LJ37gAKUFNwaJhd5r7nZGuYoInSbSL+rAP9dbkT5hh?=
 =?us-ascii?Q?esZ0xf6cgDaB0/mjPkjxkAVZ9HmXSoXLWLjfU+TXSbbt1UKvd9IR4QZBBRXe?=
 =?us-ascii?Q?fRbdIe4ao4TdRlxi8105H82OEmtcgj0/voP4wgi+xXSToRMKCVC3rALgN84C?=
 =?us-ascii?Q?ENAu5PRO59UXnZaUZ0Ip62k8hE7EnaUHpaAv4uVItjioCrHR6i+l/VSRDJV0?=
 =?us-ascii?Q?qLIULZzmIdb95bs3OsQOKAyNkrXeIFvUwmLS8Q9e61Th69KiQfiqq+xekPH8?=
 =?us-ascii?Q?00MtgyALW1YWwTVnauUr52reQkxgp/EGN1ACPeucYfacL9BPqSdfXBgoLZNc?=
 =?us-ascii?Q?2DyFQqeoq5MGgtU5ecOWTX6NU+NKHQE12GFubXeXH551wNQiTXTznx9wxrMJ?=
 =?us-ascii?Q?J7tK4hs4ZQTHyAjCYgPaFCv0KJbgkjL+mHsIU9tKF1SwcUO4kD8aw9D4r0Jx?=
 =?us-ascii?Q?Q40p5t7kQn51ZoAqzh42DFQXapHso9DOhoET1XnZ8H6C6ehXt1K7jM7XKN7x?=
 =?us-ascii?Q?R5hGqE4bPuMkXcu8DsCo6kcvpoxitLN8Py9khb17sUAzFUZ2hQWs1gsrdrhr?=
 =?us-ascii?Q?g474pWsT3k5OsVJbGgpi5NK3/N2W7oVS71Uas3YcmcA7i08mZAR94eaTfNRI?=
 =?us-ascii?Q?3cNGh4LBsUTStbJjA6pjOZZft3R0GFKjE5iCxWxVuufnTlNAm7BCec/6BdpE?=
 =?us-ascii?Q?TsLRizhupZgws5qG5HdLOqSJN6hlNrjD7ViUGmrfGg5pI1v6Rbquz4aU9ttH?=
 =?us-ascii?Q?dt6Q6CSGwvzMPuzDfRtu0ho9yZNoPPdgXV0OZAIJtxxhuMhjHiw/wS3rpbb8?=
 =?us-ascii?Q?iyzBt/dOB5IrpprA+L2SCLNZe1FZIrJxlr2EBV/8mcl2ZvD5+vl7pR3cnpZf?=
 =?us-ascii?Q?EuhbMxptqBGO/gm4q2DIZqumn/XFaLHiFpENBeXUZK57vXZogp/i+WE2VtBt?=
 =?us-ascii?Q?jfxSomcHkXH7UebfM7bO6igs1IrVH0M06ElZQTh1eEMXmxoy0Xn9diHayjWy?=
 =?us-ascii?Q?HpJrppCC7a48mdEFAIacytbioXdHDfkO7n4Vb6xtiG17dO8sid1e0GXf3+dw?=
 =?us-ascii?Q?e4+cpDoSESBPhKHize+iM5Sbo+V/YNNimWjZ2deKBaz5lOC6wefeNfKqazSR?=
 =?us-ascii?Q?nX1A4Ebf6s1wxsEZxDT1qGwN?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d0645383-553f-4b38-079c-08d98c7f7912
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2021 06:22:17.0795
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4gBb2YqQqqpIsd2RnKP2GR9Y5wMLAVghQQW4qkwxQiQK3BU2BVqtXJiw9n3c0baKR/g1tMzjuDPKootTV9so/A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3392

On 08.10.2021 19:47, Andrew Cooper wrote:
> On 08/10/2021 11:47, Jan Beulich wrote:
>> The conversion of the original code failed to recognize that the 32-bit
>> compat variant of this (sorry, two different meanings of "compat" here)
>> needs to continue to invoke the compat handler, not the native one.
>> Arrange for this and also remove the one #define that hasn't been
>> necessary anymore as of that change.
>>
>> Affected functions (having existed prior to the introduction of the new
>> hypercall) are PHYSDEVOP_set_iobitmap and PHYSDEVOP_apic_{read,write}.
>> For all others the operand struct layout doesn't differ.
>=20
> :-/
>=20
> Neither of those ABI breakages would be subtle.=C2=A0 But why didn't XTF
> notice?=C2=A0 Edit: It appears as if my PHYSDEVOP_set_iobitmap tests neve=
r
> got completed.

But the XTF would have used the modern hypercall, wouldn't it? At
least the pv-iopl test does.

>> Additionally the XSA-344 fix causes guest register corruption afaict,
>> when EVTCHNOP_reset gets called through the compat function and needs a
>> continuation. While guests shouldn't invoke that function this way, I
>> think we would better have forced all pre-3.2-unavailable functions into
>> an error path, rather than forwarding them to the actual handler. I'm
>> not sure though how relevant we consider it to fix this (one way or
>> another).
>=20
> EVTCHNOP_reset{,_cont} are -ENOSYS'd in do_event_channel_op_compat()
> without being forwarded.=C2=A0 I can't see a problem.

You're right - I think I did look at do_physdev_op_compat() deriving
evtchn-compat behavior from there as well.

>> --- a/xen/arch/x86/x86_64/compat.c
>> +++ b/xen/arch/x86/x86_64/compat.c
>> @@ -10,8 +10,8 @@ EMIT_FILE;
>> =20
>>  #define physdev_op                    compat_physdev_op
>>  #define physdev_op_t                  physdev_op_compat_t
>> -#define do_physdev_op                 compat_physdev_op
>=20
> This is still needed, technically.=C2=A0 It impacts the typeof() expressi=
on:
>=20
> typeof(do_physdev_op) *fn =3D
> =C2=A0=C2=A0=C2=A0 (void *)pv_hypercall_table[__HYPERVISOR_physdev_op].na=
tive;
>=20
> and the reason why everything compiles is because
> {do,compat}_physdev_op() have identical types.

Oh, indeed - thanks for pointing out.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Oct 11 07:57:11 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 07:57:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.205403.360688 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZqB6-0005Kn-Pr; Mon, 11 Oct 2021 07:56:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 205403.360688; Mon, 11 Oct 2021 07:56:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZqB6-0005Kg-Mn; Mon, 11 Oct 2021 07:56:56 +0000
Received: by outflank-mailman (input) for mailman id 205403;
 Mon, 11 Oct 2021 07:56:55 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=RBe3=O7=arm.com=luca.fancellu@srs-us1.protection.inumbo.net>)
 id 1mZqB5-0005Ka-U3
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 07:56:55 +0000
Received: from foss.arm.com (unknown [217.140.110.172])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTP
 id 2ba7b099-05a4-4b44-94d8-7f3478b3bc17;
 Mon, 11 Oct 2021 07:56:53 +0000 (UTC)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 473EE1063;
 Mon, 11 Oct 2021 00:56:53 -0700 (PDT)
Received: from e125770.cambridge.arm.com (e125770.cambridge.arm.com
 [10.1.195.16])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4A81A3F66F;
 Mon, 11 Oct 2021 00:56:52 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2ba7b099-05a4-4b44-94d8-7f3478b3bc17
From: Luca Fancellu <luca.fancellu@arm.com>
To: xen-devel@lists.xenproject.org
Cc: bertrand.marquis@arm.com,
	wei.chen@arm.com,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: [PATCH] arm/efi: Fix null pointer dereference
Date: Mon, 11 Oct 2021 08:56:38 +0100
Message-Id: <20211011075638.23785-1-luca.fancellu@arm.com>
X-Mailer: git-send-email 2.17.1

Fix for commit 60649d443dc395243e74d2b3e05594ac0c43cfe3
that introduces a null pointer dereference when the
fdt_node_offset_by_compatible is called with "fdt"
argument null.

Reported-by: Julien Grall <julien@xen.org>
Fixes: 60649d443d ("arm/efi: Introduce xen,uefi-cfg-load DT property")
Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>
---
 xen/arch/arm/efi/efi-boot.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/xen/arch/arm/efi/efi-boot.h b/xen/arch/arm/efi/efi-boot.h
index a3e46453d4..e63dafac26 100644
--- a/xen/arch/arm/efi/efi-boot.h
+++ b/xen/arch/arm/efi/efi-boot.h
@@ -593,7 +593,8 @@ static bool __init efi_arch_use_config_file(EFI_SYSTEM_TABLE *SystemTable)
     dtbfile.ptr = fdt;
     dtbfile.need_to_free = false; /* Config table memory can't be freed. */
 
-    if ( fdt_node_offset_by_compatible(fdt, 0, "multiboot,module") > 0 )
+    if ( fdt &&
+         (fdt_node_offset_by_compatible(fdt, 0, "multiboot,module") > 0) )
     {
         /* Locate chosen node */
         int node = fdt_subnode_offset(fdt, 0, "chosen");
-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Mon Oct 11 08:03:18 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 08:03:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.205414.360699 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZqHC-0007Jc-M4; Mon, 11 Oct 2021 08:03:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 205414.360699; Mon, 11 Oct 2021 08:03:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZqHC-0007JV-Iu; Mon, 11 Oct 2021 08:03:14 +0000
Received: by outflank-mailman (input) for mailman id 205414;
 Mon, 11 Oct 2021 08:03:13 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=RBe3=O7=arm.com=luca.fancellu@srs-us1.protection.inumbo.net>)
 id 1mZqHB-0007JM-Hi
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 08:03:13 +0000
Received: from foss.arm.com (unknown [217.140.110.172])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTP
 id ae0da91e-2a69-11ec-80d0-12813bfff9fa;
 Mon, 11 Oct 2021 08:03:12 +0000 (UTC)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0307D1063;
 Mon, 11 Oct 2021 01:03:12 -0700 (PDT)
Received: from e125770.cambridge.arm.com (e125770.cambridge.arm.com
 [10.1.195.16])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 8A1243F66F;
 Mon, 11 Oct 2021 01:03:10 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ae0da91e-2a69-11ec-80d0-12813bfff9fa
From: Luca Fancellu <luca.fancellu@arm.com>
To: xen-devel@lists.xenproject.org
Cc: bertrand.marquis@arm.com,
	wei.chen@arm.com,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Ian Jackson <iwj@xenproject.org>,
	Jan Beulich <jbeulich@suse.com>,
	Wei Liu <wl@xen.org>
Subject: [PATCH v5 0/2] arm/efi: Add dom0less support to UEFI boot
Date: Mon, 11 Oct 2021 09:03:00 +0100
Message-Id: <20211011080302.24203-1-luca.fancellu@arm.com>
X-Mailer: git-send-email 2.17.1

This serie introduces a way to start a dom0less setup when Xen is booting as EFI
application.
Using the device tree it's now possible to fetch from the disk and load in
memory all the modules needed to start any domU defined in the DT.
Dom0less for now is supported only by the arm architecture.

This serie was originally formed by 3 patch, the first one was merged.

Luca Fancellu (2):
  arm/efi: Use dom0less configuration when using EFI boot
  arm/efi: load dom0 modules from DT using UEFI

 docs/misc/arm/device-tree/booting.txt |  29 +++
 docs/misc/efi.pandoc                  | 261 +++++++++++++++++++
 xen/arch/arm/efi/efi-boot.h           | 344 +++++++++++++++++++++++++-
 xen/common/efi/boot.c                 |  55 ++--
 4 files changed, 672 insertions(+), 17 deletions(-)

-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Mon Oct 11 08:03:19 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 08:03:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.205415.360709 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZqHG-0007az-UR; Mon, 11 Oct 2021 08:03:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 205415.360709; Mon, 11 Oct 2021 08:03:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZqHG-0007as-RT; Mon, 11 Oct 2021 08:03:18 +0000
Received: by outflank-mailman (input) for mailman id 205415;
 Mon, 11 Oct 2021 08:03:17 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=RBe3=O7=arm.com=luca.fancellu@srs-us1.protection.inumbo.net>)
 id 1mZqHF-0007Zo-2A
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 08:03:17 +0000
Received: from foss.arm.com (unknown [217.140.110.172])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTP
 id eb55e371-b339-45e3-a53b-531ce92b187f;
 Mon, 11 Oct 2021 08:03:14 +0000 (UTC)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D619C11FB;
 Mon, 11 Oct 2021 01:03:13 -0700 (PDT)
Received: from e125770.cambridge.arm.com (e125770.cambridge.arm.com
 [10.1.195.16])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 366E43F66F;
 Mon, 11 Oct 2021 01:03:12 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: eb55e371-b339-45e3-a53b-531ce92b187f
From: Luca Fancellu <luca.fancellu@arm.com>
To: xen-devel@lists.xenproject.org
Cc: bertrand.marquis@arm.com,
	wei.chen@arm.com,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Ian Jackson <iwj@xenproject.org>,
	Jan Beulich <jbeulich@suse.com>,
	Wei Liu <wl@xen.org>
Subject: [PATCH v5 1/2] arm/efi: Use dom0less configuration when using EFI boot
Date: Mon, 11 Oct 2021 09:03:01 +0100
Message-Id: <20211011080302.24203-2-luca.fancellu@arm.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20211011080302.24203-1-luca.fancellu@arm.com>
References: <20211011080302.24203-1-luca.fancellu@arm.com>

This patch introduces the support for dom0less configuration
when using UEFI boot on ARM, it permits the EFI boot to
continue if no dom0 kernel is specified but at least one domU
is found.

Introduce the new property "xen,uefi-binary" for device tree boot
module nodes that are subnode of "xen,domain" compatible nodes.
The property holds a string containing the file name of the
binary that shall be loaded by the uefi loader from the filesystem.

Introduce a new call efi_check_dt_boot(...) called during EFI boot
that checks for module to be loaded using device tree.
Architectures that don't support device tree don't have to
provide this function.

Update efi documentation about how to start a dom0less
setup using UEFI

Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>
Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
---
Changes in v5:
- Removed unneeded variable initialization
- Fixed comment
- Fixed error message for the absence of an initial domain kernel
- changed efi_arch_check_dt_boot to efi_check_dt_boot and add
a stub if CONFIG_HAS_DEVICE_TREE is not declared, updated commit
message about the call introduction in the EFI boot flow.
Changes in v4:
- update uefi,cfg-load to xen,uefi-cfg-load in documentation
- fixed comments and code style
- changed variable name from dt_module_found to dt_modules_found
in boot.c
- removed stub efi_arch_check_dt_boot from x86 code because the
architecture does not support DT, protected call with #ifdef
in the common code.
- add comment to explain the result from efi_arch_check_dt_boot
just looking the common code
- Add space before comment in boot.c
- renamed uefi,binary property to xen,uefi-binary
Changes in v3:
- fixed documentation
- fixed name len in strlcpy
- fixed some style issues
- closed filesystem handle before calling blexit
- passed runtime errors up to the stack instead
of calling blexit
- renamed names and function to make them more
general in prevision to load also Dom0 kernel
and ramdisk from DT
Changes in v2:
- remove array of struct file
- fixed some int types
- Made the code use filesystem even when configuration
file is skipped.
- add documentation of uefi,binary in booting.txt
- add documentation on how to boot all configuration
for Xen using UEFI in efi.pandoc
---
 docs/misc/arm/device-tree/booting.txt |  21 ++
 docs/misc/efi.pandoc                  | 203 +++++++++++++++++
 xen/arch/arm/efi/efi-boot.h           | 305 +++++++++++++++++++++++++-
 xen/common/efi/boot.c                 |  39 +++-
 4 files changed, 556 insertions(+), 12 deletions(-)

diff --git a/docs/misc/arm/device-tree/booting.txt b/docs/misc/arm/device-tree/booting.txt
index 352b0ec43a..7258e7e1ec 100644
--- a/docs/misc/arm/device-tree/booting.txt
+++ b/docs/misc/arm/device-tree/booting.txt
@@ -190,6 +190,13 @@ The kernel sub-node has the following properties:
 
     Command line parameters for the guest kernel.
 
+- xen,uefi-binary (UEFI boot only)
+
+    String property that specifies the file name to be loaded by the UEFI boot
+    for this module. If this is specified, there is no need to specify the reg
+    property because it will be created by the UEFI stub on boot.
+    This option is needed only when UEFI boot is used.
+
 The ramdisk sub-node has the following properties:
 
 - compatible
@@ -201,6 +208,13 @@ The ramdisk sub-node has the following properties:
     Specifies the physical address of the ramdisk in RAM and its
     length.
 
+- xen,uefi-binary (UEFI boot only)
+
+    String property that specifies the file name to be loaded by the UEFI boot
+    for this module. If this is specified, there is no need to specify the reg
+    property because it will be created by the UEFI stub on boot.
+    This option is needed only when UEFI boot is used.
+
 
 Example
 =======
@@ -265,6 +279,13 @@ The dtb sub-node should have the following properties:
     Specifies the physical address of the device tree binary fragment
     RAM and its length.
 
+- xen,uefi-binary (UEFI boot only)
+
+    String property that specifies the file name to be loaded by the UEFI boot
+    for this module. If this is specified, there is no need to specify the reg
+    property because it will be created by the UEFI stub on boot.
+    This option is needed only when UEFI boot is used.
+
 As an example:
 
         module@0xc000000 {
diff --git a/docs/misc/efi.pandoc b/docs/misc/efi.pandoc
index ed85351541..876cd55005 100644
--- a/docs/misc/efi.pandoc
+++ b/docs/misc/efi.pandoc
@@ -167,3 +167,206 @@ sbsign \
 	--output xen.signed.efi \
 	xen.unified.efi
 ```
+
+## UEFI boot and dom0less on ARM
+
+Dom0less feature is supported by ARM and it is possible to use it when Xen is
+started as an EFI application.
+The way to specify the domU domains is by Device Tree as specified in the
+[dom0less](dom0less.html) documentation page under the "Device Tree
+configuration" section, but instead of declaring the reg property in the boot
+module, the user must specify the "xen,uefi-binary" property containing the name
+of the binary file that has to be loaded in memory.
+The UEFI stub will load the binary in memory and it will add the reg property
+accordingly.
+
+An example here:
+
+domU1 {
+	#address-cells = <1>;
+	#size-cells = <1>;
+	compatible = "xen,domain";
+	memory = <0 0x20000>;
+	cpus = <1>;
+	vpl011;
+
+	module@1 {
+		compatible = "multiboot,kernel", "multiboot,module";
+		xen,uefi-binary = "vmlinuz-3.0.31-0.4-xen";
+		bootargs = "console=ttyAMA0";
+	};
+	module@2 {
+		compatible = "multiboot,ramdisk", "multiboot,module";
+		xen,uefi-binary = "initrd-3.0.31-0.4-xen";
+	};
+	module@3 {
+		compatible = "multiboot,ramdisk", "multiboot,module";
+		xen,uefi-binary = "passthrough.dtb";
+	};
+};
+
+## How to boot different Xen setup using UEFI
+
+These are the different ways to boot a Xen system from UEFI:
+
+ - Boot Xen and Dom0 (minimum required)
+ - Boot Xen and DomU(s) (true dom0less, only on ARM)
+ - Boot Xen, Dom0 and DomU(s) (only on ARM)
+
+### Boot Xen and Dom0
+
+This configuration can be started using the Xen configuration file in the
+example above.
+
+### Boot Xen and DomU(s)
+
+This configuration needs the domU domain(s) specified in the /chosen node,
+examples of how to do that are provided by the documentation about dom0less
+and the example above shows how to use the "xen,uefi-binary" property to use the
+UEFI stub for module loading.
+When adding DomU modules to device tree, also add the property
+xen,uefi-cfg-load under chosen for Xen to load the Xen config file.
+Otherwise, Xen will skip the config file and rely on device tree alone.
+
+Example 1 of how to boot a true dom0less configuration:
+
+Xen configuration file: skipped.
+
+Device tree:
+
+```
+chosen {
+	#size-cells = <0x1>;
+	#address-cells = <0x1>;
+	xen,xen-bootargs = "<Xen command line>"
+
+	domU1 {
+		#size-cells = <0x1>;
+		#address-cells = <0x1>;
+		compatible = "xen,domain";
+		cpus = <0x1>;
+		memory = <0x0 0xc0000>;
+		vpl011;
+
+		module@1 {
+			compatible = "multiboot,kernel", "multiboot,module";
+			xen,uefi-binary = "Image-domu1.bin";
+			bootargs = "console=ttyAMA0 root=/dev/ram0 rw";
+		};
+	};
+	domU2 {
+		#size-cells = <0x1>;
+		#address-cells = <0x1>;
+		compatible = "xen,domain";
+		cpus = <0x1>;
+		memory = <0x0 0x100000>;
+		vpl011;
+
+		module@2 {
+			compatible = "multiboot,kernel", "multiboot,module";
+			xen,uefi-binary = "Image-domu2.bin";
+			bootargs = "console=ttyAMA0 root=/dev/ram0 rw";
+		};
+	};
+};
+```
+
+Example 2 of how to boot a true dom0less configuration:
+
+Xen configuration file:
+
+```
+[global]
+default=xen
+
+[xen]
+options=<Xen command line>
+dtb=<optional DTB>
+```
+
+Device tree:
+
+```
+chosen {
+	#size-cells = <0x1>;
+	#address-cells = <0x1>;
+	xen,uefi-cfg-load;
+
+	domU1 {
+		#size-cells = <0x1>;
+		#address-cells = <0x1>;
+		compatible = "xen,domain";
+		cpus = <0x1>;
+		memory = <0x0 0xc0000>;
+		vpl011;
+
+		module@1 {
+			compatible = "multiboot,kernel", "multiboot,module";
+			xen,uefi-binary = "Image-domu1.bin";
+			bootargs = "console=ttyAMA0 root=/dev/ram0 rw";
+		};
+	};
+	domU2 {
+		#size-cells = <0x1>;
+		#address-cells = <0x1>;
+		compatible = "xen,domain";
+		cpus = <0x1>;
+		memory = <0x0 0x100000>;
+		vpl011;
+
+		module@2 {
+			compatible = "multiboot,kernel", "multiboot,module";
+			xen,uefi-binary = "Image-domu2.bin";
+			bootargs = "console=ttyAMA0 root=/dev/ram0 rw";
+		};
+	};
+};
+```
+
+### Boot Xen, Dom0 and DomU(s)
+
+This configuration is a mix of the two configuration above, to boot this one
+the configuration file must be processed so the /chosen node must have the
+"xen,uefi-cfg-load" property.
+
+Here an example:
+
+Xen configuration file:
+
+```
+[global]
+default=xen
+
+[xen]
+options=<Xen command line>
+kernel=vmlinuz-3.0.31-0.4-xen [domain 0 command line options]
+ramdisk=initrd-3.0.31-0.4-xen
+dtb=<optional DTB>
+```
+
+Device tree:
+
+```
+chosen {
+	#size-cells = <0x1>;
+	#address-cells = <0x1>;
+	xen,uefi-cfg-load;
+
+	domU1 {
+		#size-cells = <0x1>;
+		#address-cells = <0x1>;
+		compatible = "xen,domain";
+		cpus = <0x1>;
+		memory = <0x0 0xc0000>;
+		vpl011;
+
+		module@1 {
+			compatible = "multiboot,kernel", "multiboot,module";
+			xen,uefi-binary = "Image-domu1.bin";
+			bootargs = "console=ttyAMA0 root=/dev/ram0 rw";
+		};
+	};
+};
+```
+
+
diff --git a/xen/arch/arm/efi/efi-boot.h b/xen/arch/arm/efi/efi-boot.h
index a3e46453d4..9c1d400fa6 100644
--- a/xen/arch/arm/efi/efi-boot.h
+++ b/xen/arch/arm/efi/efi-boot.h
@@ -8,9 +8,49 @@
 #include <asm/setup.h>
 #include <asm/smp.h>
 
+typedef struct {
+    char *name;
+    unsigned int name_len;
+    EFI_PHYSICAL_ADDRESS addr;
+    UINTN size;
+} module_name;
+
+/*
+ * Binaries will be translated into bootmodules, the maximum number for them is
+ * MAX_MODULES where we should remove a unit for Xen and one for Xen DTB
+ */
+#define MAX_UEFI_MODULES (MAX_MODULES - 2)
+static struct file __initdata module_binary;
+static module_name __initdata modules[MAX_UEFI_MODULES];
+static unsigned int __initdata modules_available = MAX_UEFI_MODULES;
+static unsigned int __initdata modules_idx;
+
+#define ERROR_BINARY_FILE_NOT_FOUND (-1)
+#define ERROR_ALLOC_MODULE_NO_SPACE (-1)
+#define ERROR_ALLOC_MODULE_NAME     (-2)
+#define ERROR_MISSING_DT_PROPERTY   (-3)
+#define ERROR_RENAME_MODULE_NAME    (-4)
+#define ERROR_SET_REG_PROPERTY      (-5)
+#define ERROR_DT_MODULE_DOMU        (-1)
+#define ERROR_DT_CHOSEN_NODE        (-2)
+
 void noreturn efi_xen_start(void *fdt_ptr, uint32_t fdt_size);
 void __flush_dcache_area(const void *vaddr, unsigned long size);
 
+static int get_module_file_index(const char *name, unsigned int name_len);
+static void PrintMessage(const CHAR16 *s);
+static int allocate_module_file(EFI_FILE_HANDLE dir_handle,
+                                const char *name,
+                                unsigned int name_len);
+static int handle_module_node(EFI_FILE_HANDLE dir_handle,
+                              int module_node_offset,
+                              int reg_addr_cells,
+                              int reg_size_cells);
+static bool is_boot_module(int dt_module_offset);
+static int handle_dom0less_domain_node(EFI_FILE_HANDLE dir_handle,
+                                       int domain_node);
+static int efi_check_dt_boot(EFI_FILE_HANDLE dir_handle);
+
 #define DEVICE_TREE_GUID \
 {0xb1b621d5, 0xf19c, 0x41a5, {0x83, 0x0b, 0xd9, 0x15, 0x2c, 0x69, 0xaa, 0xe0}}
 
@@ -552,8 +592,260 @@ static void __init efi_arch_handle_module(const struct file *file,
                          kernel.size) < 0 )
             blexit(L"Unable to set reg property.");
     }
-    else
+    else if ( file != &module_binary )
+        /*
+         * If file is not a dom0 module file and it's not a domU module,
+         * stop here.
+         */
         blexit(L"Unknown module type");
+
+    /*
+     * modules_available is decremented here because for each dom0 file added
+     * from the configuration file, there will be an additional bootmodule,
+     * so the number of available slots will be decremented because there is a
+     * maximum amount of bootmodules that can be loaded.
+     */
+    modules_available--;
+}
+
+/*
+ * This function checks for a binary previously loaded with a give name, it
+ * returns the index of the file in the modules array or a negative number if no
+ * file with that name is found.
+ */
+static int __init get_module_file_index(const char *name,
+                                        unsigned int name_len)
+{
+    unsigned int i;
+    int ret = ERROR_BINARY_FILE_NOT_FOUND;
+
+    for ( i = 0; i < modules_idx; i++ )
+    {
+        module_name *mod = &modules[i];
+        if ( (mod->name_len == name_len) &&
+             (strncmp(mod->name, name, name_len) == 0) )
+        {
+            ret = i;
+            break;
+        }
+    }
+    return ret;
+}
+
+static void __init PrintMessage(const CHAR16 *s)
+{
+    PrintStr(s);
+    PrintStr(newline);
+}
+
+/*
+ * This function allocates a binary and keeps track of its name, it returns the
+ * index of the file in the modules array or a negative number on error.
+ */
+static int __init allocate_module_file(EFI_FILE_HANDLE dir_handle,
+                                       const char *name,
+                                       unsigned int name_len)
+{
+    module_name *file_name;
+    union string module_name;
+    int ret;
+
+    /*
+     * Check if there is any space left for a module, the variable
+     * modules_available is updated each time we use read_file(...)
+     * successfully.
+     */
+    if ( !modules_available )
+    {
+        PrintMessage(L"No space left for modules");
+        return ERROR_ALLOC_MODULE_NO_SPACE;
+    }
+
+    module_name.cs = name;
+    ret = modules_idx;
+
+    /* Save at this index the name of this binary */
+    file_name = &modules[ret];
+
+    if ( efi_bs->AllocatePool(EfiLoaderData, (name_len + 1) * sizeof(char),
+                              (void**)&file_name->name) != EFI_SUCCESS )
+    {
+        PrintMessage(L"Error allocating memory for module binary name");
+        return ERROR_ALLOC_MODULE_NAME;
+    }
+
+    /* Save name and length of the binary in the data structure */
+    strlcpy(file_name->name, name, name_len + 1);
+    file_name->name_len = name_len;
+
+    /* Load the binary in memory */
+    read_file(dir_handle, s2w(&module_name), &module_binary, NULL);
+
+    /* Save address and size */
+    file_name->addr = module_binary.addr;
+    file_name->size = module_binary.size;
+
+    /* s2w(...) allocates some memory, free it */
+    efi_bs->FreePool(module_name.w);
+
+    modules_idx++;
+
+    return ret;
+}
+
+/*
+ * This function checks for the presence of the xen,uefi-binary property in the
+ * module, if found it loads the binary as module and sets the right address
+ * for the reg property into the module DT node.
+ */
+static int __init handle_module_node(EFI_FILE_HANDLE dir_handle,
+                                     int module_node_offset,
+                                     int reg_addr_cells,
+                                     int reg_size_cells)
+{
+    const void *uefi_name_prop;
+    char mod_string[24]; /* Placeholder for module@ + a 64-bit number + \0 */
+    int uefi_name_len, file_idx;
+    module_name *file;
+
+    /* Read xen,uefi-binary property to get the file name. */
+    uefi_name_prop = fdt_getprop(fdt, module_node_offset, "xen,uefi-binary",
+                                 &uefi_name_len);
+
+    if ( !uefi_name_prop )
+        /* Property not found */
+        return 0;
+
+    file_idx = get_module_file_index(uefi_name_prop, uefi_name_len);
+    if ( file_idx < 0 )
+    {
+        file_idx = allocate_module_file(dir_handle, uefi_name_prop,
+                                        uefi_name_len);
+        if ( file_idx < 0 )
+            return file_idx;
+    }
+
+    file = &modules[file_idx];
+
+    snprintf(mod_string, sizeof(mod_string), "module@%"PRIx64, file->addr);
+
+    /* Rename the module to be module@{address} */
+    if ( fdt_set_name(fdt, module_node_offset, mod_string) < 0 )
+    {
+        PrintMessage(L"Unable to modify module node name.");
+        return ERROR_RENAME_MODULE_NAME;
+    }
+
+    if ( fdt_set_reg(fdt, module_node_offset, reg_addr_cells, reg_size_cells,
+                     file->addr, file->size) < 0 )
+    {
+        PrintMessage(L"Unable to set module reg property.");
+        return ERROR_SET_REG_PROPERTY;
+    }
+
+    return 0;
+}
+
+static bool __init is_boot_module(int dt_module_offset)
+{
+    if ( (fdt_node_check_compatible(fdt, dt_module_offset,
+                                    "multiboot,kernel") == 0) ||
+         (fdt_node_check_compatible(fdt, dt_module_offset,
+                                    "multiboot,ramdisk") == 0) ||
+         (fdt_node_check_compatible(fdt, dt_module_offset,
+                                    "multiboot,device-tree") == 0) )
+        return true;
+
+    return false;
+}
+
+/*
+ * This function checks for boot modules under the domU guest domain node
+ * in the DT.
+ * Returns 0 on success, negative number on error.
+ */
+static int __init handle_dom0less_domain_node(EFI_FILE_HANDLE dir_handle,
+                                              int domain_node)
+{
+    int module_node, addr_cells, size_cells, len;
+    const struct fdt_property *prop;
+
+    /* Get #address-cells and #size-cells from domain node */
+    prop = fdt_get_property(fdt, domain_node, "#address-cells", &len);
+    if ( !prop )
+    {
+        PrintMessage(L"#address-cells not found in domain node.");
+        return ERROR_MISSING_DT_PROPERTY;
+    }
+
+    addr_cells = fdt32_to_cpu(*((uint32_t *)prop->data));
+
+    prop = fdt_get_property(fdt, domain_node, "#size-cells", &len);
+    if ( !prop )
+    {
+        PrintMessage(L"#size-cells not found in domain node.");
+        return ERROR_MISSING_DT_PROPERTY;
+    }
+
+    size_cells = fdt32_to_cpu(*((uint32_t *)prop->data));
+
+    /*
+     * Check for nodes compatible with multiboot,{kernel,ramdisk,device-tree}
+     * inside this node
+     */
+    for ( module_node = fdt_first_subnode(fdt, domain_node);
+          module_node > 0;
+          module_node = fdt_next_subnode(fdt, module_node) )
+        if ( is_boot_module(module_node) )
+        {
+            int ret = handle_module_node(dir_handle, module_node, addr_cells,
+                                         size_cells);
+            if ( ret < 0 )
+                return ret;
+        }
+
+    return 0;
+}
+
+/*
+ * This function checks for xen domain nodes under the /chosen node for possible
+ * domU guests to be loaded.
+ * Returns the number of modules loaded or a negative number for error.
+ */
+static int __init efi_check_dt_boot(EFI_FILE_HANDLE dir_handle)
+{
+    int chosen, node, addr_len, size_len;
+    unsigned int i = 0;
+
+    /* Check for the chosen node in the current DTB */
+    chosen = setup_chosen_node(fdt, &addr_len, &size_len);
+    if ( chosen < 0 )
+    {
+        PrintMessage(L"Unable to setup chosen node");
+        return ERROR_DT_CHOSEN_NODE;
+    }
+
+    /* Check for nodes compatible with xen,domain under the chosen node */
+    for ( node = fdt_first_subnode(fdt, chosen);
+          node > 0;
+          node = fdt_next_subnode(fdt, node) )
+    {
+        if ( !fdt_node_check_compatible(fdt, node, "xen,domain") )
+        {
+            /* Found a node with compatible xen,domain; handle this node. */
+            if ( handle_dom0less_domain_node(dir_handle, node) < 0 )
+                return ERROR_DT_MODULE_DOMU;
+        }
+    }
+
+    /* Free boot modules file names if any */
+    for ( ; i < modules_idx; i++ )
+    {
+        /* Free boot modules binary names */
+        efi_bs->FreePool(modules[i].name);
+    }
+
+    return modules_idx;
 }
 
 static void __init efi_arch_cpu(void)
@@ -562,8 +854,19 @@ static void __init efi_arch_cpu(void)
 
 static void __init efi_arch_blexit(void)
 {
+    unsigned int i = 0;
+
     if ( dtbfile.need_to_free )
         efi_bs->FreePages(dtbfile.addr, PFN_UP(dtbfile.size));
+    /* Free boot modules file names if any */
+    for ( ; i < modules_idx; i++ )
+    {
+        /* Free boot modules binary names */
+        efi_bs->FreePool(modules[i].name);
+        /* Free modules binaries */
+        efi_bs->FreePages(modules[i].addr,
+                          PFN_UP(modules[i].size));
+    }
     if ( memmap )
         efi_bs->FreePool(memmap);
 }
diff --git a/xen/common/efi/boot.c b/xen/common/efi/boot.c
index 758f9d74d2..7879b93f93 100644
--- a/xen/common/efi/boot.c
+++ b/xen/common/efi/boot.c
@@ -166,6 +166,13 @@ static void __init PrintErr(const CHAR16 *s)
     StdErr->OutputString(StdErr, (CHAR16 *)s );
 }
 
+#ifndef CONFIG_HAS_DEVICE_TREE
+static inline int __init efi_check_dt_boot(EFI_FILE_HANDLE dir_handle)
+{
+    return 0;
+}
+#endif
+
 /*
  * Include architecture specific implementation here, which references the
  * static globals defined above.
@@ -1136,6 +1143,8 @@ efi_start(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE *SystemTable)
     bool base_video = false;
     const char *option_str;
     bool use_cfg_file;
+    int dt_modules_found;
+    EFI_FILE_HANDLE dir_handle;
 
     __set_bit(EFI_BOOT, &efi_flags);
     __set_bit(EFI_LOADER, &efi_flags);
@@ -1216,9 +1225,11 @@ efi_start(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE *SystemTable)
 
     efi_arch_relocate_image(0);
 
+    /* Get the file system interface. */
+    dir_handle = get_parent_handle(loaded_image, &file_name);
+
     if ( use_cfg_file )
     {
-        EFI_FILE_HANDLE dir_handle;
         UINTN depth, cols, rows, size;
 
         size = cols = rows = depth = 0;
@@ -1229,9 +1240,6 @@ efi_start(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE *SystemTable)
 
         gop = efi_get_gop();
 
-        /* Get the file system interface. */
-        dir_handle = get_parent_handle(loaded_image, &file_name);
-
         /* Read and parse the config file. */
         if ( read_section(loaded_image, L"config", &cfg, NULL) )
             PrintStr(L"Using builtin config file\r\n");
@@ -1285,14 +1293,12 @@ efi_start(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE *SystemTable)
             efi_bs->FreePool(name.w);
         }
 
-        if ( !name.s )
-            blexit(L"No Dom0 kernel image specified.");
-
         efi_arch_cfg_file_early(loaded_image, dir_handle, section.s);
 
-        option_str = split_string(name.s);
+        option_str = name.s ? split_string(name.s) : NULL;
 
-        if ( !read_section(loaded_image, L"kernel", &kernel, option_str) )
+        if ( !read_section(loaded_image, L"kernel", &kernel, option_str) &&
+             name.s )
         {
             read_file(dir_handle, s2w(&name), &kernel, option_str);
             efi_bs->FreePool(name.w);
@@ -1361,12 +1367,23 @@ efi_start(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE *SystemTable)
         efi_bs->FreePages(cfg.addr, PFN_UP(cfg.size));
         cfg.addr = 0;
 
-        dir_handle->Close(dir_handle);
-
         if ( gop && !base_video )
             gop_mode = efi_find_gop_mode(gop, cols, rows, depth);
     }
 
+    /* Get the number of boot modules specified on the DT or an error (<0) */
+    dt_modules_found = efi_check_dt_boot(dir_handle);
+
+    dir_handle->Close(dir_handle);
+
+    if ( dt_modules_found < 0 )
+        /* efi_check_dt_boot throws some error */
+        blexit(L"Error processing boot modules on DT.");
+
+    /* Check if at least one of Dom0 or DomU(s) is specified */
+    if ( !dt_modules_found && !kernel.ptr )
+        blexit(L"No initial domain kernel specified.");
+
     efi_arch_edd();
 
     /* XXX Collect EDID info. */
-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Mon Oct 11 08:03:22 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 08:03:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.205416.360720 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZqHK-0007uB-CF; Mon, 11 Oct 2021 08:03:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 205416.360720; Mon, 11 Oct 2021 08:03:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZqHK-0007u0-8w; Mon, 11 Oct 2021 08:03:22 +0000
Received: by outflank-mailman (input) for mailman id 205416;
 Mon, 11 Oct 2021 08:03:21 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=RBe3=O7=arm.com=luca.fancellu@srs-us1.protection.inumbo.net>)
 id 1mZqHJ-0007Zo-SI
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 08:03:21 +0000
Received: from foss.arm.com (unknown [217.140.110.172])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTP
 id 3a2a370b-2c00-4929-ba18-6ff6cb0478ce;
 Mon, 11 Oct 2021 08:03:15 +0000 (UTC)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8279C1396;
 Mon, 11 Oct 2021 01:03:15 -0700 (PDT)
Received: from e125770.cambridge.arm.com (e125770.cambridge.arm.com
 [10.1.195.16])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1715A3F66F;
 Mon, 11 Oct 2021 01:03:13 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3a2a370b-2c00-4929-ba18-6ff6cb0478ce
From: Luca Fancellu <luca.fancellu@arm.com>
To: xen-devel@lists.xenproject.org
Cc: bertrand.marquis@arm.com,
	wei.chen@arm.com,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Ian Jackson <iwj@xenproject.org>,
	Jan Beulich <jbeulich@suse.com>,
	Wei Liu <wl@xen.org>
Subject: [PATCH v5 2/2] arm/efi: load dom0 modules from DT using UEFI
Date: Mon, 11 Oct 2021 09:03:02 +0100
Message-Id: <20211011080302.24203-3-luca.fancellu@arm.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20211011080302.24203-1-luca.fancellu@arm.com>
References: <20211011080302.24203-1-luca.fancellu@arm.com>

Add support to load Dom0 boot modules from
the device tree using the xen,uefi-binary property.

Update documentation about that.

Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>
Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
Acked-by: Jan Beulich <jbeulich@suse.com>
---
Changes in v5:
- renamed missing uefi,binary string
- used kernel.ptr instead of kernel.addr to be consistent
to the surrounding code
- Changed a comment referring to efi_arch_check_dt_boot
that now is efi_check_dt_boot
Changes in v4:
- Add check to avoid double definition of Dom0 ramdisk
from cfg file and DT
- Fix if conditions indentation in boot.c
- Moved Dom0 kernel verification code after check for
presence for Dom0 or DomU(s)
- Changed uefi,binary property to xen,uefi-binary
Changes in v3:
- new patch
---
 docs/misc/arm/device-tree/booting.txt |  8 ++++
 docs/misc/efi.pandoc                  | 64 +++++++++++++++++++++++++--
 xen/arch/arm/efi/efi-boot.h           | 47 ++++++++++++++++++--
 xen/common/efi/boot.c                 | 16 ++++---
 4 files changed, 123 insertions(+), 12 deletions(-)

diff --git a/docs/misc/arm/device-tree/booting.txt b/docs/misc/arm/device-tree/booting.txt
index 7258e7e1ec..c6a775f4e8 100644
--- a/docs/misc/arm/device-tree/booting.txt
+++ b/docs/misc/arm/device-tree/booting.txt
@@ -70,6 +70,14 @@ Each node contains the following properties:
 	priority of this field vs. other mechanisms of specifying the
 	bootargs for the kernel.
 
+- xen,uefi-binary (UEFI boot only)
+
+	String property that specifies the file name to be loaded by the UEFI
+	boot for this module. If this is specified, there is no need to specify
+	the reg property because it will be created by the UEFI stub on boot.
+	This option is needed only when UEFI boot is used, the node needs to be
+	compatible with multiboot,kernel or multiboot,ramdisk.
+
 Examples
 ========
 
diff --git a/docs/misc/efi.pandoc b/docs/misc/efi.pandoc
index 876cd55005..4abbb5bb82 100644
--- a/docs/misc/efi.pandoc
+++ b/docs/misc/efi.pandoc
@@ -167,6 +167,28 @@ sbsign \
 	--output xen.signed.efi \
 	xen.unified.efi
 ```
+## UEFI boot and Dom0 modules on ARM
+
+When booting using UEFI on ARM, it is possible to specify the Dom0 modules
+directly from the device tree without using the Xen configuration file, here an
+example:
+
+chosen {
+	#size-cells = <0x1>;
+	#address-cells = <0x1>;
+	xen,xen-bootargs = "[Xen boot arguments]"
+
+	module@1 {
+		compatible = "multiboot,kernel", "multiboot,module";
+		xen,uefi-binary = "vmlinuz-3.0.31-0.4-xen";
+		bootargs = "[domain 0 command line options]";
+	};
+
+	module@2 {
+		compatible = "multiboot,ramdisk", "multiboot,module";
+		xen,uefi-binary = "initrd-3.0.31-0.4-xen";
+	};
+}
 
 ## UEFI boot and dom0less on ARM
 
@@ -326,10 +348,10 @@ chosen {
 ### Boot Xen, Dom0 and DomU(s)
 
 This configuration is a mix of the two configuration above, to boot this one
-the configuration file must be processed so the /chosen node must have the
-"xen,uefi-cfg-load" property.
+the configuration file can be processed or the Dom0 modules can be read from
+the device tree.
 
-Here an example:
+Here the first example:
 
 Xen configuration file:
 
@@ -369,4 +391,40 @@ chosen {
 };
 ```
 
+Here the second example:
+
+Device tree:
+
+```
+chosen {
+	#size-cells = <0x1>;
+	#address-cells = <0x1>;
+	xen,xen-bootargs = "[Xen boot arguments]"
+
+	module@1 {
+		compatible = "multiboot,kernel", "multiboot,module";
+		xen,uefi-binary = "vmlinuz-3.0.31-0.4-xen";
+		bootargs = "[domain 0 command line options]";
+	};
+
+	module@2 {
+		compatible = "multiboot,ramdisk", "multiboot,module";
+		xen,uefi-binary = "initrd-3.0.31-0.4-xen";
+	};
+
+	domU1 {
+		#size-cells = <0x1>;
+		#address-cells = <0x1>;
+		compatible = "xen,domain";
+		cpus = <0x1>;
+		memory = <0x0 0xc0000>;
+		vpl011;
 
+		module@1 {
+			compatible = "multiboot,kernel", "multiboot,module";
+			xen,uefi-binary = "Image-domu1.bin";
+			bootargs = "console=ttyAMA0 root=/dev/ram0 rw";
+		};
+	};
+};
+```
diff --git a/xen/arch/arm/efi/efi-boot.h b/xen/arch/arm/efi/efi-boot.h
index 9c1d400fa6..7a4ebd4128 100644
--- a/xen/arch/arm/efi/efi-boot.h
+++ b/xen/arch/arm/efi/efi-boot.h
@@ -31,8 +31,11 @@ static unsigned int __initdata modules_idx;
 #define ERROR_MISSING_DT_PROPERTY   (-3)
 #define ERROR_RENAME_MODULE_NAME    (-4)
 #define ERROR_SET_REG_PROPERTY      (-5)
+#define ERROR_DOM0_ALREADY_FOUND    (-6)
+#define ERROR_DOM0_RAMDISK_FOUND    (-7)
 #define ERROR_DT_MODULE_DOMU        (-1)
 #define ERROR_DT_CHOSEN_NODE        (-2)
+#define ERROR_DT_MODULE_DOM0        (-3)
 
 void noreturn efi_xen_start(void *fdt_ptr, uint32_t fdt_size);
 void __flush_dcache_area(const void *vaddr, unsigned long size);
@@ -45,7 +48,8 @@ static int allocate_module_file(EFI_FILE_HANDLE dir_handle,
 static int handle_module_node(EFI_FILE_HANDLE dir_handle,
                               int module_node_offset,
                               int reg_addr_cells,
-                              int reg_size_cells);
+                              int reg_size_cells,
+                              bool is_domu_module);
 static bool is_boot_module(int dt_module_offset);
 static int handle_dom0less_domain_node(EFI_FILE_HANDLE dir_handle,
                                        int domain_node);
@@ -701,7 +705,8 @@ static int __init allocate_module_file(EFI_FILE_HANDLE dir_handle,
 static int __init handle_module_node(EFI_FILE_HANDLE dir_handle,
                                      int module_node_offset,
                                      int reg_addr_cells,
-                                     int reg_size_cells)
+                                     int reg_size_cells,
+                                     bool is_domu_module)
 {
     const void *uefi_name_prop;
     char mod_string[24]; /* Placeholder for module@ + a 64-bit number + \0 */
@@ -743,6 +748,34 @@ static int __init handle_module_node(EFI_FILE_HANDLE dir_handle,
         return ERROR_SET_REG_PROPERTY;
     }
 
+    if ( !is_domu_module )
+    {
+        if ( (fdt_node_check_compatible(fdt, module_node_offset,
+                                    "multiboot,kernel") == 0) )
+        {
+            /*
+            * This is the Dom0 kernel, wire it to the kernel variable because it
+            * will be verified by the shim lock protocol later in the common
+            * code.
+            */
+            if ( kernel.addr )
+            {
+                PrintMessage(L"Dom0 kernel already found in cfg file.");
+                return ERROR_DOM0_ALREADY_FOUND;
+            }
+            kernel.need_to_free = false; /* Freed using the module array */
+            kernel.addr = file->addr;
+            kernel.size = file->size;
+        }
+        else if ( ramdisk.addr &&
+                  (fdt_node_check_compatible(fdt, module_node_offset,
+                                             "multiboot,ramdisk") == 0) )
+        {
+            PrintMessage(L"Dom0 ramdisk already found in cfg file.");
+            return ERROR_DOM0_RAMDISK_FOUND;
+        }
+    }
+
     return 0;
 }
 
@@ -799,7 +832,7 @@ static int __init handle_dom0less_domain_node(EFI_FILE_HANDLE dir_handle,
         if ( is_boot_module(module_node) )
         {
             int ret = handle_module_node(dir_handle, module_node, addr_cells,
-                                         size_cells);
+                                         size_cells, true);
             if ( ret < 0 )
                 return ret;
         }
@@ -809,7 +842,7 @@ static int __init handle_dom0less_domain_node(EFI_FILE_HANDLE dir_handle,
 
 /*
  * This function checks for xen domain nodes under the /chosen node for possible
- * domU guests to be loaded.
+ * dom0 and domU guests to be loaded.
  * Returns the number of modules loaded or a negative number for error.
  */
 static int __init efi_check_dt_boot(EFI_FILE_HANDLE dir_handle)
@@ -836,6 +869,12 @@ static int __init efi_check_dt_boot(EFI_FILE_HANDLE dir_handle)
             if ( handle_dom0less_domain_node(dir_handle, node) < 0 )
                 return ERROR_DT_MODULE_DOMU;
         }
+        else if ( is_boot_module(node) )
+        {
+            if ( handle_module_node(dir_handle, node, addr_len, size_len,
+                                    false) < 0 )
+                return ERROR_DT_MODULE_DOM0;
+        }
     }
 
     /* Free boot modules file names if any */
diff --git a/xen/common/efi/boot.c b/xen/common/efi/boot.c
index 7879b93f93..531975326f 100644
--- a/xen/common/efi/boot.c
+++ b/xen/common/efi/boot.c
@@ -1302,11 +1302,6 @@ efi_start(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE *SystemTable)
         {
             read_file(dir_handle, s2w(&name), &kernel, option_str);
             efi_bs->FreePool(name.w);
-
-            if ( !EFI_ERROR(efi_bs->LocateProtocol(&shim_lock_guid, NULL,
-                            (void **)&shim_lock)) &&
-                 (status = shim_lock->Verify(kernel.ptr, kernel.size)) != EFI_SUCCESS )
-                PrintErrMesg(L"Dom0 kernel image could not be verified", status);
         }
 
         if ( !read_section(loaded_image, L"ramdisk", &ramdisk, NULL) )
@@ -1384,6 +1379,17 @@ efi_start(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE *SystemTable)
     if ( !dt_modules_found && !kernel.ptr )
         blexit(L"No initial domain kernel specified.");
 
+    /*
+     * The Dom0 kernel can be loaded from the configuration file or by the
+     * device tree through the efi_check_dt_boot function, in this stage
+     * verify it.
+     */
+    if ( kernel.ptr &&
+         !EFI_ERROR(efi_bs->LocateProtocol(&shim_lock_guid, NULL,
+                                           (void **)&shim_lock)) &&
+         (status = shim_lock->Verify(kernel.ptr, kernel.size)) != EFI_SUCCESS )
+        PrintErrMesg(L"Dom0 kernel image could not be verified", status);
+
     efi_arch_edd();
 
     /* XXX Collect EDID info. */
-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Mon Oct 11 08:04:41 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 08:04:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.205435.360732 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZqIa-0000iO-Oq; Mon, 11 Oct 2021 08:04:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 205435.360732; Mon, 11 Oct 2021 08:04:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZqIa-0000iH-Kq; Mon, 11 Oct 2021 08:04:40 +0000
Received: by outflank-mailman (input) for mailman id 205435;
 Mon, 11 Oct 2021 08:04:40 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=9TNE=O7=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mZqIa-0000he-4M
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 08:04:40 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id dfab9224-2a69-11ec-80d0-12813bfff9fa;
 Mon, 11 Oct 2021 08:04:36 +0000 (UTC)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2104.outbound.protection.outlook.com [104.47.17.104])
 (Using TLS) by relay.mimecast.com with ESMTP id
 de-mta-39-pbvUUYAtN2yums_EJqQsRg-1; Mon, 11 Oct 2021 10:04:34 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB7152.eurprd04.prod.outlook.com (2603:10a6:800:12b::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.19; Mon, 11 Oct
 2021 08:04:32 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4587.026; Mon, 11 Oct 2021
 08:04:32 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS9PR05CA0058.eurprd05.prod.outlook.com (2603:10a6:20b:489::32) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.21 via Frontend
 Transport; Mon, 11 Oct 2021 08:04:31 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: dfab9224-2a69-11ec-80d0-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1633939475;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=X/4ljXLmYk1pUbKedYutRMFE70u9r2ifwdFCmcnSvbM=;
	b=JBIjZTd+/gelyhO2ZZxUAX96q9hzrnM880GqVHY8dlbV436B8OHOohnekoJU0YENdMfgh7
	qT/TuST70kL7oh+oH4U8eWtYjf9PLBQFmiU+nkysh6mOgcX0pbAukYA/1WUmxsau44ruln
	5AXYbZU8iRxOi7SjGJ0xKL+z+zygoF0=
X-MC-Unique: pbvUUYAtN2yums_EJqQsRg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=hZ7EOIWMicIp5PfltbhSvFOjt0Ltsj6Gd5pqM3mQdKzmsjojXzW4ORtd3GwJ/cxdzO1Qt3Jd8EWLYjAckyQJ3KJ3lLl6wzYxc1+V5XycSWTETbG5AnzcR7DIPWivWgOR2+Egyj2ljpQa69pptTbH9f7BbOtNmgV8Ni0NGPK/JqQfxGo5I5O3oECUKNnfvES0inpqmGYiRxUTfjYWgrXap0AIFETKYle+UrlzOhsfhhl9AtwfIrf0SaFCI/snqMXMJchS6e4hxaz+MM6DApbDwTq8rM1vqMGo6hRtxGDdZ5X9dRh6dlnryw2c8YftIzsCaYgPHFrtjTKDKGr6Y03Uvg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=X/4ljXLmYk1pUbKedYutRMFE70u9r2ifwdFCmcnSvbM=;
 b=ZqDUHZd/PX6oJtEUnagu1oKRu6qZsipYPDZJbRHOpI2+orLrW8GdJsTN3gMvRmWiELvl25jKQQQj6jNTtzDS1Yhm37CkNnToq87IiNPATUKK9nJVlNt5Dm1Dbsse4CG1dAucRgn7iviNGrNxEReSA4HQlmRh+OHvu9GWx3ousR8dch8Wfne3ukwMPOvY2CP1UrPmoU1ABCIiWVefgK+yDyq92Mv6K1jiHgPm4m+FelOfjtfdrYxSXAJjqjK9HEvWON/7uEXEh7IdfoOCLvJiyHqOvTnUriNvjBk1fdKI+V+TUcH5uDKqQP2yHmWjJODgWyTY7WWGlS2tSRyXQ6/ItQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Ping: [PATCH v2 3/3] AMD/IOMMU: consider hidden devices when flushing
 device I/O TLBs
From: Jan Beulich <jbeulich@suse.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Paul Durrant <paul@xen.org>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <c0a460c0-9d7e-c015-37cf-4775bdef33a8@suse.com>
 <09b6d94d-0116-c8ee-5daf-ddcc19d37029@suse.com>
Message-ID: <2b6cdf04-ab6b-bbbd-6df1-d90fc22752f8@suse.com>
Date: Mon, 11 Oct 2021 10:04:33 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <09b6d94d-0116-c8ee-5daf-ddcc19d37029@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR05CA0058.eurprd05.prod.outlook.com
 (2603:10a6:20b:489::32) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 57f96514-5019-42ae-b9ff-08d98c8dc1bf
X-MS-TrafficTypeDiagnostic: VI1PR04MB7152:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB7152621F3EC51437B9C2FBE8B3B59@VI1PR04MB7152.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	mqTelGUD//fL82rEyEhATNlDM0mxqEQFPLA+vzOSg+RrckIi3yU0s160zMlTesGXPffXzaHWKbIorQtO6HbLsVhjbTJTX048bHvPr7uH0nFMKXHHT14ZaNwmughDEKs4XOqwPG6GcgTkRPp9S593YJQtEqSlqR7rvyq9uJL6QBjSq55gEWzIj/RhwRI3bhfRdeBMt3kwqMaToCv0amsiLVE1uUhwJs/wtMBH0FtPNMpF7aorNEwKQKAWQW73S4IF0YR7eOcknkzlJ2TQF+DtQxNzpwHkR2H1CcO+gq1tBrmws5uPs6yVEFsGeaPzhFZKcLYVMpPF7Hp3A0YZdNE8k/IauxdlMwFpWZfa5xHJDh1dG4pK/tWUAoIL9QNmsbfpET3adN6I2BLD/AFLEvDfxAr0RCDSjYvLt1PaRsiFx2i+taizSP4QOLXlJDAzYxnTp1aVQN1Xv/mdGsg/yr0pyIMJBLYgBU/cbauhsONnnuB5R9K2BxWaj0bvm7eNWAORdHbfDAFDp1/gkCGMTWK/AdIkk6lBtz/hyCEzA5yK2bve/gxW1imQfq+IEz9pUPEcGYkIUblVoKdXsgd4BsdOEYjn1eIdp0Q6LH5P6Ug5CB9jgza8VIQvxCKBMkqjdxsfboCuGWGCE7uph4iAXsnNb+xEA+fi/KW40I7nllmIk7tfQv9hYk4AbCKrBlN/GQTxc6NNEGXdwiGgxoMRp7ZSEANejwL99SlHLtUOF4s5Aas=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(6916009)(16576012)(66946007)(5660300002)(66556008)(66476007)(2616005)(38100700002)(6486002)(186003)(86362001)(316002)(956004)(54906003)(31696002)(36756003)(53546011)(508600001)(83380400001)(8936002)(2906002)(8676002)(31686004)(26005)(4326008)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?YytjSjhJbDBQQXZsVWZybkVwY0lFSC9KVnpLcVpZZDJZaFFDWkpNbHIrdWIz?=
 =?utf-8?B?anlHOU9zdlgranhTRTdIWExRYUhXTmx6MGdqWHIrdjRGWTVISHhmR3NKZnNS?=
 =?utf-8?B?MmJVSVZ4QWlJTWNEWWtBZGFLN2RQR1U3ZzJubzNJdWpjQ09Nb0c2N2ZmYTZq?=
 =?utf-8?B?aThqZVNqQmphOTY1RnRvbVVETWRNb2tPZTVlRTNKYWh2TGsrMmRQZ0VSeXRQ?=
 =?utf-8?B?VDdhOFU2TFcxbjlndjdCN2hSK3c5U0tSbXdNSnhPcCt4VFdhWEVmN21WZGdY?=
 =?utf-8?B?b3pxbzZ3SWlFbEk2VCtVUEpzRGM2V1o5bXgvQnhoV05rWWhMamxUK2RleEJr?=
 =?utf-8?B?MTg3bnZqODdHbFVDbmdTWko3RmxKb214Q1A1UExEdXptd0hEL1lTNFFjd0Ur?=
 =?utf-8?B?MlNsU3ZOVXo3N1hsblpiaXFrSVpockxHMk05Z3VnWjdLNXJQUmxoOE1iUnlp?=
 =?utf-8?B?Q3drdzk5M2NySVVRZHovQ21iMW9ISytxLzc2dUYrYlBRLzFGNlNjczNaTTN3?=
 =?utf-8?B?aVl3azhGeEV3R0hkQlE2QzZBdVk5S3lnRmVwN1VEY1QrNy92M202WDdpdkp5?=
 =?utf-8?B?K24wWWl3SWJ2MyszOFRuQm1ueWpxaGVlcThjSjg3RTZDL214alVlQU04TDNp?=
 =?utf-8?B?N0JGeWh0VXEzSjFNVG9KeFJkTWtJNlYySlp4REdqMHlhNW4yRlRJZ0E0ckhq?=
 =?utf-8?B?a1BlNEMwdmYxVjdCOHVmK1EvOEtva1prTUMrWjVtanJNYXA4Q05tQzBoYkt5?=
 =?utf-8?B?VTRjdGlaVUtzNEtvc1pCcU5BQkQ1ZXpHcjZXLzBtdmpQck9PVlhFdlhoS0hV?=
 =?utf-8?B?LzJGQ2p1dXZLK3dJUnpZY21lQ094aVoyUkRGNjQ4OTBZbWJyUDJtVlF6TlZJ?=
 =?utf-8?B?NE9jUXJ1NUI2Mlh0Y2QvK25wZnhZMHEvOGowalpPMDN4U1l2aUpWNjVNZ0xX?=
 =?utf-8?B?OVVGOXE0VjFkQWlkSnA1R0czaFFnVWJlb2tIUkExcmE3a1hzQXVZYzFVeFJ5?=
 =?utf-8?B?TFlhS1R6OGNFd1h3SU8wdTd4SXp5R2FwcmZXWnArZXZ6cFV6RUViU0xqdW9L?=
 =?utf-8?B?Myt5WHBqNVVWb0dTbWNnRGlwQ0NFRnl3K05wSGFiNHNOSHN6allzOGk0YjRR?=
 =?utf-8?B?RzdQRmhyemVzM0N5dU1ldkcyZitIYmRCRHRiNVRGZnNaMHl4WmxseWV4MkFo?=
 =?utf-8?B?Q1FCelhHVXV4dTVwMTdkdDFSQUlaekdqT0FuMXFxbnlZdldGWnMzdCtjQzkv?=
 =?utf-8?B?enZDY0FxQ0lSdE16Q05sdDZPOXBxdHRtdlZQSGJiUGhTc0FvVlZ3WnB1QkVp?=
 =?utf-8?B?TkJVZkRvV1RabGJwYTNpc0c3ZmJIaVVtelZDMVdBc1N1cVc3YUthZjA3TnBT?=
 =?utf-8?B?TVhwOHBqZWJHajdUR2s5Zk1mVkcvYitiVXBMZVRFOEROdFEwc3RqSVlzVVBt?=
 =?utf-8?B?cFo3cHBIQVRFSVJrYUJBQXlIU2lvVlNVUXl2aWlwN0JLdnIzOWR6V2JOUy9Z?=
 =?utf-8?B?QVFZOEYrQ254Rkx3Z3BCcHZBSjJyN0I5U3B1QnV6dHdVa0I4TW1yYk9zdU9y?=
 =?utf-8?B?UzViaHd0TURVanRTQ1ZxSml1MVIxdXQySWJpMDcyZlFFUVlBZ1RoOEt0bkVM?=
 =?utf-8?B?bjNlK28xNm1TNjBnZCtKVDJJMkJKN3dnOTY3TVlPeFM0akdpN0xBRExNUmpD?=
 =?utf-8?B?dmFNYjJlY2dBcWpWZld2Wk9nblRrZGRjZ2lJbC9NbTVXN2RMMnl4bE14QmlT?=
 =?utf-8?Q?8qtjyUVeRlzzqqnqHA04zqUGgV269S+p0+FHPK+?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 57f96514-5019-42ae-b9ff-08d98c8dc1bf
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2021 08:04:31.9560
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: hqLoS0aB6zE9lzAzs1B79ovxMZAoCS2w7Vri56bat/liXwlF/p8ZuRPzyOxX0u+9BobFVjyURIM6nt+XMXlkJg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7152

On 17.09.2021 13:00, Jan Beulich wrote:
> Hidden devices are associated with DomXEN but usable by the
> hardware domain. Hence they need flushing as well when all devices are
> to have flushes invoked.
> 
> While there drop a redundant ATS-enabled check and constify the first
> parameter of the involved function.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

The VT-d side equivalent having gone in a while ago, I think it would
be good to have the AMD side on par.

Jan

> --- a/xen/drivers/passthrough/amd/iommu_cmd.c
> +++ b/xen/drivers/passthrough/amd/iommu_cmd.c
> @@ -308,14 +308,11 @@ void amd_iommu_flush_iotlb(u8 devfn, con
>      flush_command_buffer(iommu, iommu_dev_iotlb_timeout);
>  }
>  
> -static void amd_iommu_flush_all_iotlbs(struct domain *d, daddr_t daddr,
> +static void amd_iommu_flush_all_iotlbs(const struct domain *d, daddr_t daddr,
>                                         unsigned int order)
>  {
>      struct pci_dev *pdev;
>  
> -    if ( !ats_enabled )
> -        return;
> -
>      for_each_pdev( d, pdev )
>      {
>          u8 devfn = pdev->devfn;
> @@ -343,7 +340,16 @@ static void _amd_iommu_flush_pages(struc
>      }
>  
>      if ( ats_enabled )
> +    {
>          amd_iommu_flush_all_iotlbs(d, daddr, order);
> +
> +        /*
> +         * Hidden devices are associated with DomXEN but usable by the
> +         * hardware domain. Hence they need dealing with here as well.
> +         */
> +        if ( is_hardware_domain(d) )
> +            amd_iommu_flush_all_iotlbs(dom_xen, daddr, order);
> +    }
>  }
>  
>  void amd_iommu_flush_all_pages(struct domain *d)
> 
> 



From xen-devel-bounces@lists.xenproject.org Mon Oct 11 08:11:54 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 08:11:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.205447.360743 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZqPB-00016f-ET; Mon, 11 Oct 2021 08:11:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 205447.360743; Mon, 11 Oct 2021 08:11:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZqPB-00016D-7L; Mon, 11 Oct 2021 08:11:29 +0000
Received: by outflank-mailman (input) for mailman id 205447;
 Mon, 11 Oct 2021 08:11:28 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=9TNE=O7=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mZqPA-000167-Dy
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 08:11:28 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id d4247c4e-2a6a-11ec-80d0-12813bfff9fa;
 Mon, 11 Oct 2021 08:11:26 +0000 (UTC)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2108.outbound.protection.outlook.com [104.47.17.108])
 (Using TLS) by relay.mimecast.com with ESMTP id
 de-mta-31-fzQJtpmpNMKef9kbV6xTYw-1; Mon, 11 Oct 2021 10:11:24 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB6863.eurprd04.prod.outlook.com (2603:10a6:803:12f::9)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.22; Mon, 11 Oct
 2021 08:11:22 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4587.026; Mon, 11 Oct 2021
 08:11:22 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6P191CA0036.EURP191.PROD.OUTLOOK.COM (2603:10a6:209:8b::49) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4587.24 via Frontend Transport; Mon, 11 Oct 2021 08:11:21 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d4247c4e-2a6a-11ec-80d0-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1633939885;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=hj7UsMq9SrEe2FV3McSS9jWXqS6uB0dcy2UGnm64cuI=;
	b=DyTPeh1vYxal8Y7l5NN9y5VbJKsKEgLcx6+FQLo4Fyiomai1yheuTzjRvw6l+g2gS2UZA1
	Xxf8QMQ6NcbJvH2xI260w96YXSZkS07DThLyL2aZnvCLPtPuD6/2s8npgCfMqWMxXa8H+e
	+Ff4DjGFxp0MX9+95EbQmsHlf5hjSpM=
X-MC-Unique: fzQJtpmpNMKef9kbV6xTYw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=g2yjGgvmYJnxbtwdVg+1DKS72yRO8qci97VjTz4V80O9wVXboVWDYdFeUZdCp1gjt1ScbD5JOelwArWhVDLTlgKZRJu6SGjOS30x0IU3soRV5blFn2e0X97b60ezTVcBYzOTda0l26BFzAD9/YMwRN8Qa77aDcP9ktyrvEGJ8DPrKYxfMKBZWC2NpqHDfGViZqoget5QtA2tNhGR3XUf6IcMFAEe7gq4OEupoJbD1XSPGQknXfxv3rhV4o/PxvPPmWuyi67rVJ3HGXQdp02x4382ZJaFqzE47r/pfmiJP941lcTbHPumUWiNX+V6JIbN+SycOs277BGqpznsiun99A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=hj7UsMq9SrEe2FV3McSS9jWXqS6uB0dcy2UGnm64cuI=;
 b=O4sbrZjGOqKUwNRY4DYhOfFVOqKpRo4wqG86zr3daFIlnUAdgh6jGCDE/Gfvdl55ghvmIl/Ump1wY8ZgxuJ2NxprimNRhiyTTgxXHs1YU7Phzfo7rkYtPr5V35uN273DNMONPuvFevOHAFz+PWXLr1Ikbw3xjlJ8pFItkRbsuXonbtLwdbaeYWGbImn0bLDrjYTaZTkunVr2CxHuWL+7TowiafnlUW1l6dQ3JprW2KvvpFi1dy8HC+J8jMm4HB/LOY4T+Sk5pOnlHA9d3VCnx50TllVGa532bWRfHtXJ7AsGgT/G9aZz+t01Jl7t0tIBvGLYKy2z7CjyRDzylCUb6g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [PATCH v5 1/2] arm/efi: Use dom0less configuration when using EFI
 boot
To: Luca Fancellu <luca.fancellu@arm.com>
Cc: bertrand.marquis@arm.com, wei.chen@arm.com,
 Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Wei Liu <wl@xen.org>, xen-devel@lists.xenproject.org
References: <20211011080302.24203-1-luca.fancellu@arm.com>
 <20211011080302.24203-2-luca.fancellu@arm.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <d7acbd79-fca0-f388-5304-9f85dba304fc@suse.com>
Date: Mon, 11 Oct 2021 10:11:22 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <20211011080302.24203-2-luca.fancellu@arm.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P191CA0036.EURP191.PROD.OUTLOOK.COM
 (2603:10a6:209:8b::49) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: cf2992cd-43ee-4633-30c1-08d98c8eb627
X-MS-TrafficTypeDiagnostic: VI1PR04MB6863:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB68631948D2A2A30451329E48B3B59@VI1PR04MB6863.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:295;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	nPxe+gS8HYCGEPt1A1SH1EcrQniauynsW3hxl6sFbhXw3UA0gt4M3raM5YaUnuJLa/xhbplibUwf5M2G3+BxQo8jHM5a4VMZdEOBmscQSzwhVdTILy5ss8Hq8UfBzlhL7sMYWufbH/3okmcVnsd3OgHCocfrmm7g5KGBljKkD57MooQrGwdxOQRJ+9tl3VRc5DYYclU38g9o95Ke4+r4/LG4xlDzzd5/edxrqP7NKB7CeT7bZZw8dDtWiSOSyUtXpO+GX/Ds5GvgMM1UeP3Y06IMN6IJf2YkPLuegjyStAj0X61d22EDZHj5wzCPiMXgkCGCI+DHnNSA2plEfGXTquWD0hVCiAdMsVhDXXeYCXcZQxsRl6o6LIeNK2awNxNXZHQOwyEM5bb0x9pdEoi8h+Kcs0VcPp2u1Jd9ndbJ08PyKXRUaIkwOsFXoiEoMzSZFJEEozcspBqNvPZaXqK7GD6KBD6rCL1h+7YQYVuaX501FGuyQp+5/iYwLw9l2fdbLjP+j0d1EHM17z+bUhQZaGxiFDxrxV6cvnnyH8jrUgEmwvprVciJIkXtibYWAD8XU73a9bsK8m29Mujbyv3v7Mhk+3f7idK+cDC9E2J/BXy2njoKlrzft0K2qdAf/7AeFukhJsKDhOYQNM5ztY82Gc/G1ODMObuUd8OZzcL2UU/T1Ab8uWnSHo/uE3PtlvKRuoO3lXWObI1LyEY07Q2b2W1/iE27+5SoL1wBE0sl2TpL+x9o0HUbyuZCIbQlTSMyg00QCfTbqSvfpuf2G5EEjA==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(53546011)(2906002)(54906003)(8936002)(6486002)(16576012)(83380400001)(6916009)(316002)(8676002)(26005)(38100700002)(7416002)(36756003)(2616005)(86362001)(508600001)(31686004)(5660300002)(66556008)(186003)(66946007)(956004)(4326008)(31696002)(66476007)(32563001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?UUUwY2tJTU1TNUhaUkpycGd6S1I3ejlHdEJrbm1KbU40emM3d3didmdTd0xz?=
 =?utf-8?B?dXc0bExjc0YxQ2tOYVZVZjcyRzdvU3VBT3p0UnNQM0plUXd2VWdUM2h6Vndh?=
 =?utf-8?B?aE94bWRNcnBJM25BNU5aYkZ2d3dhRjAyVGhDdlhwVXNBb3UwNXpzVi84WS9u?=
 =?utf-8?B?dXVOcGFqbmZpSEl0RUhnMEdROUlkZ1RySW52N2tlZGpwWUpiTzB1Q041dHpp?=
 =?utf-8?B?YmFLZ1UwbEF3YThjcjk0Ui9mR0hUNy81blF2UGtKRExTV3Q5RDdOY3ZVTlly?=
 =?utf-8?B?WjNCR2RkR3orMEEzamt5N1ovMjZRRlRhZWMrWUdUck1FUUV2UmhIQisxMUNZ?=
 =?utf-8?B?VGdscEwwNlhLcE1ib1ZCbDVqWVQwdDV3WlVKbVArRFh5VTZtQ0dXdDM4cGEx?=
 =?utf-8?B?WDNmNzFtbGFqaFQvSlB1aWRZcVFSWi9VK3hHa3dtdFJIYi81T0Y4d1hCTHJX?=
 =?utf-8?B?NVdxSXdqSUZCNjBxQ2Z1NUFhZWRvNm5QQy95VDBFUXNGSkJKU25UZjM1d2dF?=
 =?utf-8?B?U2VMZStKMnZtVlRWMzJLVFZaTExIMXBFY0pyQ3NvSlhCSldCMGNjYTlvdmQ3?=
 =?utf-8?B?bnRzZkFtbmNYOCt1WjZ1N3NQcU96ZzhGSDQ1TEVraUwwYzJkMkw0TDRZQTVh?=
 =?utf-8?B?L1dkVmJtNkUwWCtwYW5GM0hHbUNIQTk3aXVXQWViVm5oRTVCRG04elJLaXMz?=
 =?utf-8?B?WkJ3YkR5Mzk0blpLbWN6MkZ1NXhQQmptNzZEbERZUDNyUENkaUlYSS9aM0VZ?=
 =?utf-8?B?aGpqRHcyM1JiZEtKVEJDWEZ6K0FUZitmd2ZxQ0pnSUt1MlcyeGNKbGd1UG5p?=
 =?utf-8?B?NHE4SzFCV3kyRzN0UmV5RFY4NmRRYjF6bnpid2VSYlZwRjZhUXFPUHBFNkNy?=
 =?utf-8?B?Q0dsTm5hVnZZUVJDRjRtUEVJdlVEL2FOVExBalBpTmRLVzRVRENaNERXd3V6?=
 =?utf-8?B?NmpMWW1QeDBXTjJYY0R4MFhYQUtNM25Ea0ZHTVNodk9yaFU4N0dVbjV1azV6?=
 =?utf-8?B?dGZrbW9uOFB6ay9Db0NLd1RabmNPbW1SdDY0ajFwTm1Ua0pJZFJJMklFeXly?=
 =?utf-8?B?MExxZkJidjhDNXBMTnhzbWtaU1l6MDU2cVk0eDlGbGEveWRFQnZQbXNpaHEy?=
 =?utf-8?B?eVUxQmovdk9RRFJCQ2piN3FZKzZOVjN1M1dHaitoTXZodFV5REdmNk9Hc0hp?=
 =?utf-8?B?bXM0dnFHUzZpbjdhejhtcWxJRlRQc0grOUM5YUZoUUpPVUx6QWpiMVhqdU5L?=
 =?utf-8?B?N2hZZmV1QjRwajVZc2tBd1dUOWV3MlA5dkx2cDBmbCtKOTdhdlo3VkVKaHJr?=
 =?utf-8?B?U1pTTWNPRkpobUxKSTIxZGUrR1hmcjFzSDlCSk5ibkFPamdYWjNkbHhCdTFM?=
 =?utf-8?B?TWw5dkdQdTdDcEM4ZWh3L3dUVzI4eElWU1A2dmlScmN4NFVXSGo5R3BzR3Jj?=
 =?utf-8?B?RVk5RDdvOVd0WXN4ZFV6OHR5anByWUpsZ1dsQUdXcDZ3aHZlZFhERUQzQWxG?=
 =?utf-8?B?bk8yUUxIK0JWR0xwL29PdHROdWRzSEUxc1hhYXM0cldzZ2ZXUjBhelNCL0dm?=
 =?utf-8?B?eUhkR3ZMRFI4YVZCNk14d3A3bVNxb0F4Q3NieFdPQ2tzcUJPMTVCc3NVOWJE?=
 =?utf-8?B?Wjc5RFRzWWlPbmxsUVJJbmlqMys4dVVKVk8yWHVKTnBXMFZjZTdlVUNOUGdW?=
 =?utf-8?B?bEZnRVBqYzlYVFJ2Vm1FWkcrakV5djBPSFh0UHN0YWF5aTBMRDJiZ1dxVThD?=
 =?utf-8?Q?9/kOwrm9BvyzabIuTYDQf7VsDy1akRXYt4KLnhE?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cf2992cd-43ee-4633-30c1-08d98c8eb627
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2021 08:11:21.9851
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: oOCOuFhZFKoKOAjg6WwHhB98cavi7oyRW+v5YrxDn3THwGhC6PUK2YOP2vcHVnua9utoz/mWN45uSkHo1BnNQQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6863

On 11.10.2021 10:03, Luca Fancellu wrote:
> This patch introduces the support for dom0less configuration
> when using UEFI boot on ARM, it permits the EFI boot to
> continue if no dom0 kernel is specified but at least one domU
> is found.
> 
> Introduce the new property "xen,uefi-binary" for device tree boot
> module nodes that are subnode of "xen,domain" compatible nodes.
> The property holds a string containing the file name of the
> binary that shall be loaded by the uefi loader from the filesystem.
> 
> Introduce a new call efi_check_dt_boot(...) called during EFI boot
> that checks for module to be loaded using device tree.
> Architectures that don't support device tree don't have to
> provide this function.
> 
> Update efi documentation about how to start a dom0less
> setup using UEFI
> 
> Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>
> Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>
> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>

Did you get indication that these are fine to retain with ...

> ---
> Changes in v5:
> - Removed unneeded variable initialization
> - Fixed comment
> - Fixed error message for the absence of an initial domain kernel
> - changed efi_arch_check_dt_boot to efi_check_dt_boot and add
> a stub if CONFIG_HAS_DEVICE_TREE is not declared, updated commit
> message about the call introduction in the EFI boot flow.

... all of these changes? Every individual change may be minor enough,
but their sum makes me wonder. If so (or if at least one of the two
gets re-offered)
Acked-by: Jan Beulich <jbeulich@suse.com>
albeit preferably with ...

> --- a/xen/common/efi/boot.c
> +++ b/xen/common/efi/boot.c
> @@ -166,6 +166,13 @@ static void __init PrintErr(const CHAR16 *s)
>      StdErr->OutputString(StdErr, (CHAR16 *)s );
>  }
>  
> +#ifndef CONFIG_HAS_DEVICE_TREE
> +static inline int __init efi_check_dt_boot(EFI_FILE_HANDLE dir_handle)

... the "inline" here dropped. We don't normally add this outside of
headers, leaving it to the compiler to decide. In headers it's wanted
to avoid "defined by never used" style warnings.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Oct 11 08:17:24 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 08:17:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.205456.360754 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZqUq-0001pG-2y; Mon, 11 Oct 2021 08:17:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 205456.360754; Mon, 11 Oct 2021 08:17:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZqUp-0001p9-WB; Mon, 11 Oct 2021 08:17:19 +0000
Received: by outflank-mailman (input) for mailman id 205456;
 Mon, 11 Oct 2021 08:17:19 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=9TNE=O7=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mZqUp-0001p3-BG
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 08:17:19 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 671325fb-1786-4ed3-966e-f7f52a0c2140;
 Mon, 11 Oct 2021 08:17:18 +0000 (UTC)
Received: from EUR03-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur03lp2052.outbound.protection.outlook.com [104.47.8.52]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-23-hC1tHEK1MMKu2X_HYlsy0A-1; Mon, 11 Oct 2021 10:17:16 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB3294.eurprd04.prod.outlook.com (2603:10a6:802:3::19) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.18; Mon, 11 Oct
 2021 08:17:07 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4587.026; Mon, 11 Oct 2021
 08:17:07 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6PR10CA0043.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:209:80::20) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4587.25 via Frontend Transport; Mon, 11 Oct 2021 08:17:07 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 671325fb-1786-4ed3-966e-f7f52a0c2140
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1633940237;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding;
	bh=bbzjxS4qY50/XnkwKGtENFSe+EZtCGIvL27KlVUOC14=;
	b=bXyRNL/G48JEMnnZCnJlKVcR0AG1K5TP4aAEKTWfaJHu9DpbGKhJezoNglxh359maPGJ8d
	2mRSktLbR/+C84Ch/qTIPpoIg3L8Mk/J/sWp6VBfWPkO1a/Nw7/XqL7MLZ7xfPaPKQYhtO
	xxhVyo4toPwTZIgU0tHYggj33vbhNHs=
X-MC-Unique: hC1tHEK1MMKu2X_HYlsy0A-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=hb2UiGnWRMRdHZFdlZb4ofb+A+PJPHzeYBtU3r5DdqjVbgQRNE98gtboG7Hp3az486UVg+W0Wco7ierQCBrHdH8i4nroBcApWni4oNcIUcHQxaxP41Mi/HG3zX49oeI8dXnnquvC3HuBQ9K5bpvwZgCBKRN4nVCsDJkGvAlFgQbzb09pobl/woojd2+LyokNCPncL2MY/dx6oEJa/78NgZ/WiY41ZE7ODpg8iMseR+jk4faiofYJFC6AxI+aXWEq4/zXhZ9fRfnvcDbxbeJbxqhEF08NNHOyaO9NnhWKjyGVsfpHBraKDKliIVBbxOyrKByxzZigru4UqBturUB8TA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=bbzjxS4qY50/XnkwKGtENFSe+EZtCGIvL27KlVUOC14=;
 b=kya5usjX21BqFNYotaISEVvUF0isU77K+Off3pT3dc+jTfSuZBGHDx3P0HSGFdeq8ZDo0iHYK6zcqXhIb9HV5lZJYO5rwQTxtH7/xjt6Ul/NxlaURS94BuAGguKGYTXQT6MZjwrr7unUAknhGyN5MuFPnk1ZP1rtHWCny/5B4V84ZyXfoK+coySLRDZWbkO+IwCD2XGXGtcAZIfsfmIZx6hDj9mSOzpdXJA9v0c2iKbdY9ULJKGIrgR0F7L6ayRfg+fkGjI+Mt2YiV7eHrYc/bszSk/aOtJDaWVpQxKHMajfcr6bq79NtrczZmTLKRmz+niugItv+rM8vwjAVlh+jA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: citrix.com; dkim=none (message not signed)
 header.d=none;citrix.com; dmarc=none action=none header.from=suse.com;
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
Subject: [PATCH] x86/PoD: defer nested P2M flushes
Message-ID: <e47d51c6-1b4b-2f72-6e12-070df66c30e2@suse.com>
Date: Mon, 11 Oct 2021 10:17:08 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR10CA0043.EURPRD10.PROD.OUTLOOK.COM
 (2603:10a6:209:80::20) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: feb38551-ab79-4cca-170b-08d98c8f844e
X-MS-TrafficTypeDiagnostic: VI1PR04MB3294:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB32943512D6E9B7B3FF5FD2EAB3B59@VI1PR04MB3294.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	x/HLLbZh1Q5L9qG00GcL5AqmOaJ775KjecVxJjC8gGa7p/8LGGsGw9nnZ5p7npVxccsZmca/nEBqBTSjcFrlJY/2z7Yhem4wa9QXYQhluzl/qGzBPg5Jmx/NZ0sNohqFS3V5hazaZ9Swll01CHTea/xA0uK3Kk5XwmfF6fKTdauVSUwTfM1bhhco0Y/SFWF1fGjJ3NEzt8mohlYVpxEHUKUQEWikXo3nrr9qh05gb5UVY4rjfw9kkOR6GVQ0yvPJmSDlFAX7Tu9KFywTqwGPnz5O1ZJOYDFBsa0xfBopBj2ei6T81ycPIGoehLfywFOmuZ0kCRqfDiJ8LOLKcdT/Hygk0ZePxQYruU9Phure2z29YMSjwIQD9B/zaEt4atsa6aOLy0uvEz+lKcZpHJGUndttnLPdGqY6R4KrVHIuiEQ0bL/M5+qucy4uIm3W2yQNumaTyGIIrmIE3/acm2jz4GJgJjWVqe9CkuVE8OQ2BzHJfmX6n9vYLgL6XS6E4xHQVZJ9bF0WknGrWrWUR1pFt3Wp8i0CD9d+JmWaJ5rToJHBiK4jGF0+ycl5dRH89jAMs5WpJp8ztTH37bn+dfI/OF94B/O2L3x3RAORh9o8qjzZP5H4gV/MjJpyQ6OzD37p5uFQPBv+2U/laJgvuFSeHvgwldalJaUJHuey4lhVbVsBM52Uj05IH6R/Lymi14sC07u75tFusXCSUouVq77/Shc9g/ybZJvHbb5j/CC/lXVEWZ6Q87xdE0VmJa0tQniB
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(16576012)(66476007)(66946007)(31696002)(956004)(2616005)(5660300002)(54906003)(26005)(8676002)(6916009)(186003)(4326008)(8936002)(316002)(66556008)(508600001)(38100700002)(86362001)(6486002)(36756003)(2906002)(83380400001)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?c28zZGFQM0dtbnB0VjFlS1ZMdXZiOSs5VzBZdEpzQS9kNzQxMDI5bDZMdlkv?=
 =?utf-8?B?RTdNYWloNkFYYTJwWmE4YTJRaGIxM25TWUdFNjRlZ0l1TkhlMXNCZFN1UXVW?=
 =?utf-8?B?Y0tOMytNUmJ2S1hiNkJ3Z1p6ek9wcWpQcWJicTRDbE1CY2xDamJOTUxIbW14?=
 =?utf-8?B?ZGhtYjViTHVrU0FMSHphbVRSdjE4OHZ3RG9FbDNxTlprSXBXN3RXd0dzRmV4?=
 =?utf-8?B?clNxM0NzSXlWVGtjejQydDhZbndDSVpmdytaV1dodzd2OEp0Tk8ySmNyZS8y?=
 =?utf-8?B?SWQ3bE1VV1huY1FDb3ZJVUpJVWhwOHNqUTFaVDQ2SjZwTDR1clVWUWlneVJ0?=
 =?utf-8?B?ODFDTS9waStoTmc3SCtFSVNxT01namRCcXVFNEJXd21melFnQWVlMm1HL0p4?=
 =?utf-8?B?OEJ1QS9QUjFidzZObkxkNmZKenRMYXMrbnpSbVVtWUNLcEJwNUFtNWx2R0wz?=
 =?utf-8?B?Q1BxWUNoVmQvaDRTeU8wd0pwaVR4Zjd3c0plSTk5T0FlRk10bnlkTDQ3c3hS?=
 =?utf-8?B?VW1SS0l0dWpONHhkSHlvTzRZbFZOaTBSLzRVQXV0R2QxZFRvTmpCWGlEd3dz?=
 =?utf-8?B?VjFjWCs5b0lZUkk0NStUeWpXUDZvc2cweHlWNTlrMmdFTTZxdFBJOTJaSXcr?=
 =?utf-8?B?b2xtcjJGczhMV052OGVjS3ArTjZoVi8yRW1PbnozRDZwb3VxN3VONHloaHB6?=
 =?utf-8?B?MUY4ZGFYTTJMN0pFME9saldPYUJHQVpScnY2K0Zxa3RYN2E5bjQzUFQxakRz?=
 =?utf-8?B?M0lFQ1lQTlJ0ajlyNDVLYTVKdWRxUGdUd1c3SzFUKzNVMGRJcTJ5U1JoR2FY?=
 =?utf-8?B?MjhDVXpXTS8vQUdJY0xsbnJNcmRrTG8xNmk5emxuZ2UyRlYwbUNUamV1cFUv?=
 =?utf-8?B?cDBJY1VCWDliK1V4VE9uRUdvYkcwVVFCMkZvS3Z0eXVKZ25VTXBZL3RZd01M?=
 =?utf-8?B?aVFQV1I2UEx2MThiQ3Z5V2ZLU2FkRGJQZVlFSERxMWRwQ2dXTkZPS0doQlJS?=
 =?utf-8?B?V3NrbElqWXhkZmhuZjFxclJTeFZjUHNPbmtaUXhRUHZleFU3dlBRZXVCMHdi?=
 =?utf-8?B?TlhoZm00RDBUQ25sS3pYK3dOWGZudUdpYmFmNUcxcDR1TW1BdEU0ZUZuNC80?=
 =?utf-8?B?dTZTMjZFaGpsZkFVOHNGOTlTVCtvVWJ4UzNqcFd6VXcwNzRpOWM5MDdSYXdQ?=
 =?utf-8?B?RHY1QjM0TFlCOEdYbUpSS2hwb1dyUVBoODExUEtNK2tmUUdVQ1E1emFOWWlR?=
 =?utf-8?B?UXloU2tqZU9FcTdyL1pIcHVMVEpyRzNDZVdXRTRGYnB1bTF0WmFoL0U3eEcx?=
 =?utf-8?B?Rmd0UlJtR2xTemNxUG1YNk1TM2FXYkRmWU9PQnJPd2xhcnVaWms4SlhTMUlF?=
 =?utf-8?B?dDhWM0pDdlg2d3FjTWpGbU5UTmpLa2ZQajA4USt5bVJIZThua2RtNUQ4TTgx?=
 =?utf-8?B?bU9GdnFnam5rdHduNDVScmRyVHprUmhvd3VwVzEyT1JER05vUVRKTUdUeHVD?=
 =?utf-8?B?cG1NRTk2MGdFNStiblBMVnhpcmxwQmsrL29aMFVnM252blVlTy9QU2ZWb21v?=
 =?utf-8?B?SU94L0xhQVlBQmlDNXk4SlMrTWpEclB1bS8wSGVVeTRwZkFUNTVWNkdFckZJ?=
 =?utf-8?B?SXNLV1R0RG1IWDY1R0pTazR4M0xwWXd1bVJoTVlWVEwzRTVmUTBNUW92MXRC?=
 =?utf-8?B?cGwwNnlJTGdUbnVDMmcvYk9XRXBoSkJSOUdyNnBTbVFXZm1KK3poUEpiLzBo?=
 =?utf-8?Q?oMfMrDQF63wmMO/E/P08/2pmjcbvvplEKsHOC1/?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: feb38551-ab79-4cca-170b-08d98c8f844e
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2021 08:17:07.8167
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5A7nzKvorqqPYhwovpPkRuPigSvPN8cJANwLTZGbTzpe5nEH/PROIfH1av4xsiSjh4VqH2lUCKIvhIE/uIJclw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB3294

With NPT or shadow in use, the p2m_set_entry() -> p2m_pt_set_entry() ->
write_p2m_entry() -> p2m_flush_nestedp2m() call sequence triggers a lock
order violation when the PoD lock is held around it. Hence such flushing
needs to be deferred. Steal the approach from p2m_change_type_range().

Similarly for EPT I think ept_set_entry() -> ept_sync_domain() ->
ept_sync_domain_prepare() -> p2m_flush_nestedp2m() is affected.

Reported-by: Elliott Mitchell <ehem+xen@m5p.com>
Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/arch/x86/mm/p2m-pod.c
+++ b/xen/arch/x86/mm/p2m-pod.c
@@ -24,6 +24,7 @@
 #include <xen/mm.h>
 #include <xen/sched.h>
 #include <xen/trace.h>
+#include <asm/hvm/nestedhvm.h>
 #include <asm/page.h>
 #include <asm/paging.h>
 #include <asm/p2m.h>
@@ -494,6 +495,13 @@ p2m_pod_offline_or_broken_replace(struct
 static int
 p2m_pod_zero_check_superpage(struct p2m_domain *p2m, gfn_t gfn);
 
+static void pod_unlock_and_flush(struct p2m_domain *p2m)
+{
+    pod_unlock(p2m);
+    p2m->defer_nested_flush = false;
+    if ( nestedhvm_enabled(p2m->domain) )
+        p2m_flush_nestedp2m(p2m->domain);
+}
 
 /*
  * This function is needed for two reasons:
@@ -514,6 +522,7 @@ p2m_pod_decrease_reservation(struct doma
 
     gfn_lock(p2m, gfn, order);
     pod_lock(p2m);
+    p2m->defer_nested_flush = true;
 
     /*
      * If we don't have any outstanding PoD entries, let things take their
@@ -665,7 +674,7 @@ out_entry_check:
     }
 
 out_unlock:
-    pod_unlock(p2m);
+    pod_unlock_and_flush(p2m);
     gfn_unlock(p2m, gfn, order);
     return ret;
 }
@@ -1144,8 +1153,10 @@ p2m_pod_demand_populate(struct p2m_domai
      * won't start until we're done.
      */
     if ( unlikely(d->is_dying) )
-        goto out_fail;
-
+    {
+        pod_unlock(p2m);
+        return false;
+    }
 
     /*
      * Because PoD does not have cache list for 1GB pages, it has to remap
@@ -1167,6 +1178,8 @@ p2m_pod_demand_populate(struct p2m_domai
                               p2m_populate_on_demand, p2m->default_access);
     }
 
+    p2m->defer_nested_flush = true;
+
     /* Only reclaim if we're in actual need of more cache. */
     if ( p2m->pod.entry_count > p2m->pod.count )
         pod_eager_reclaim(p2m);
@@ -1229,8 +1242,9 @@ p2m_pod_demand_populate(struct p2m_domai
         __trace_var(TRC_MEM_POD_POPULATE, 0, sizeof(t), &t);
     }
 
-    pod_unlock(p2m);
+    pod_unlock_and_flush(p2m);
     return true;
+
 out_of_memory:
     pod_unlock(p2m);
 
@@ -1239,12 +1253,14 @@ out_of_memory:
            p2m->pod.entry_count, current->domain->domain_id);
     domain_crash(d);
     return false;
+
 out_fail:
-    pod_unlock(p2m);
+    pod_unlock_and_flush(p2m);
     return false;
+
 remap_and_retry:
     BUG_ON(order != PAGE_ORDER_2M);
-    pod_unlock(p2m);
+    pod_unlock_and_flush(p2m);
 
     /*
      * Remap this 2-meg region in singleton chunks. See the comment on the



From xen-devel-bounces@lists.xenproject.org Mon Oct 11 08:20:46 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 08:20:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.205464.360764 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZqY9-0003E7-Jn; Mon, 11 Oct 2021 08:20:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 205464.360764; Mon, 11 Oct 2021 08:20:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZqY9-0003E0-GH; Mon, 11 Oct 2021 08:20:45 +0000
Received: by outflank-mailman (input) for mailman id 205464;
 Mon, 11 Oct 2021 08:20:44 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=9TNE=O7=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mZqY8-0003Du-K4
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 08:20:44 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 3c6cfd9a-4838-4b8f-ab38-ad3d01fe769a;
 Mon, 11 Oct 2021 08:20:43 +0000 (UTC)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2105.outbound.protection.outlook.com [104.47.18.105])
 (Using TLS) by relay.mimecast.com with ESMTP id
 de-mta-18-ksDHdLA3MdmXh1jah7hCqw-1; Mon, 11 Oct 2021 10:20:41 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB5326.eurprd04.prod.outlook.com (2603:10a6:803:57::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.19; Mon, 11 Oct
 2021 08:20:40 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4587.026; Mon, 11 Oct 2021
 08:20:40 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS9PR06CA0223.eurprd06.prod.outlook.com (2603:10a6:20b:45e::11) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.25 via Frontend
 Transport; Mon, 11 Oct 2021 08:20:39 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3c6cfd9a-4838-4b8f-ab38-ad3d01fe769a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1633940442;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding;
	bh=wXp4WejUo1gQalHqC0ptBAcKhLpjEL68Gg6QYPuu8qo=;
	b=femKHVVUswm5AO29DyCkUrQL9cDvbEQ+LCIHjeksBr+/H42nAKXsJ5ZjFiDJ21X5ncstbE
	EJBX2Mn/gdO6zLocnQr62YljUTzKZzGc4qjXdYalnbHhltlxuxK3AXeuqb6KOVyTjXTujK
	oNN81BSyAJDJew8BpGYXKYuHS5YLlkY=
X-MC-Unique: ksDHdLA3MdmXh1jah7hCqw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=SWMh82GmDCqvVbBzXJAzDF5g4jX2sE2r7V+LALWO+eLEYmBGp926wMJkYDIgTKw65pAI3+IQOx901LZRnfmq5OvAaFbYWgHfVdE6omuBhrcPzZIN8uC6/CyEXlk59f6nKvBs3IexX26fv8IXYb0+PbrN16r3p6oe+MG3BYDqVvRLf6AU0yXamn8097g+kwRWSnqbTicdrlLcrmeIz0WnicGj6udtt/Hxfj+ppzqU/c4po3eaFeD96L9/vvb/F+N6oy3NLUR4HczWDz9Y1SS2yNQDhI4lN2LKFKmZWwbkmR3nG28VoTzV2iTFlCWCM1Kxle0bCYGlE99uq3e1XZ697Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=wXp4WejUo1gQalHqC0ptBAcKhLpjEL68Gg6QYPuu8qo=;
 b=CXP/iNDsef0hYg95S8WChVX6tzUEJWgNiBvl5lrq10ZZt6TUrHBIYymd2XYGTxSajJbTrSc6HEry/28H/ZOHETPVMXOPHz1K9aTjGIVcs4hx2K2nKgyiaMkBClWRIf/iPtv/92pBA0izkfnU17gnQ9Ym01ouPAHKp2eYyGYpLoj3u4bfossveWCzJmUM36VMDOMpWVRfakBisFGKa9BtnwHYpc6zno0SdrWF7Eq5t88TBfUpLeZdXfYR26dUMVASfNAE7OtYk2x2I6RRMichwdsaC5m1NFZZ/GNO1kanpi8aEjuYgvwWqUs5tEzuhKGjF/4QgmWUxFrEjau7yJOHDg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: citrix.com; dkim=none (message not signed)
 header.d=none;citrix.com; dmarc=none action=none header.from=suse.com;
From: Jan Beulich <jbeulich@suse.com>
Subject: [PATCH v2] x86/PV32: fix physdev_op_compat handling
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
Message-ID: <af2f934a-49d8-a15d-3b66-94abc0d39081@suse.com>
Date: Mon, 11 Oct 2021 10:20:41 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0223.eurprd06.prod.outlook.com
 (2603:10a6:20b:45e::11) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 9be5a194-8d6d-4e3f-8efb-08d98c9002eb
X-MS-TrafficTypeDiagnostic: VI1PR04MB5326:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB5326827D6AD5DBD8E8ED5375B3B59@VI1PR04MB5326.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:4125;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Q7+9rD2NyVN24nUx6QDhJr46Cro/zQL/6qNZhaB8VK0tKMO9u3ny02WSTvmoMBerNZp4nnQ7exZ9b/P5ApAWrJUWAnubPM4smyyEDNXjicx3qT741eBvAgXRYZJ6mUO8gv1KMv/zcibm5vq2luqNHqClkHsvu5Tpb9Jf0dwZtH/2meRLoNWRiBJIosgLelRUNaufhH2ig+QBJjfjUBlN91T6RQYTvNE/w+n/n0lAxfEkAPBhVawEzi6gI0ThCkqaDiVaT7JrWY1ZQ3m6/JwYRl9mAz6GdFIYDYIeR1YV1IFOEIpR/0iDp7hu8etxiyDUpVKlujp1M4kwxByMk6eua3LOklFbc86SkbPfr0pTcI5TKU3YletIRn/87tVw3yGwtYps8EQy08KsGBgPqcC122U3Mz5pm/9zcI/4mMZ8vcA/piuvKk1h+LX1wTFHOlEZfIRz+/+MJluV1pERmFYx4G8kZn+sBdJlC7OK0Lqv35tu2VQOp3/SIV1Sib71Q6cL9GzdlBKgniWB7R2f8eCABPiAHGWXQp11+iKJy5VWg2fwNrBkF244pF+O1n8MdBoOHMUg9Y3mVJMAtMrDknehQIPY9+i2diL8Bq54PL75bzka8TBrP2eL1CWfNdUuN7oPZ0O7/4dpp3bes7m1Afl0AvhPyjF65BphD+AuJiui5xOUCKeajhXgkBSXcm/TNlH5oQElGINHoLAX4o5DPqnsUi6ZPvdLUIdiTDfBIDQX6f48KInVSX0OlKE5hSqJQro/
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(186003)(8676002)(31696002)(2616005)(6666004)(8936002)(38100700002)(26005)(956004)(31686004)(36756003)(86362001)(4744005)(66476007)(66556008)(5660300002)(66946007)(6486002)(54906003)(316002)(16576012)(4326008)(6916009)(508600001)(2906002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?dzdTY05WcUgwLzZaWWlkbjJNeHE4Zm4rWmJ1QzJkbTdtUjJuNmpXVnVzUVI4?=
 =?utf-8?B?T1crS0J5MVRaUFBtbGpNTmhzVTZDNng1Wk9GUnNRa2RKV2pLVFh6aUZzL0Uv?=
 =?utf-8?B?RFB6UGJ6K1Q0WnMyblVSdmtjelNBRktBclFvS05nY3pTUHdjZGRobVJtWU9T?=
 =?utf-8?B?WUVnTHU5cVkva2dzUHhoUHNBNmsrYkZnWHpBUGJKOTBkRjBpQ3FCaE4xTnFM?=
 =?utf-8?B?SkNuVUtmWG9SYnNzMWhqZWdxcnQ3R0NRczZNc3RnSnNDcFN5aG5ybWE4V0Zo?=
 =?utf-8?B?ak1FMlBoT2Q3ZGQ0V2YxRzN1aUo1bDUvYklSQXR3N2J6NjNSYVBjSnhDOGFr?=
 =?utf-8?B?TkVNYUZxRnBzNm4vNE4wTkR0cWszL1piRHNndmNIQjFpUnQrd1kxVFBUelJp?=
 =?utf-8?B?N1lxS21RalNNaS8rVjZVcE0zSHVwZmN2R1hSZnRncXA5ajBYZGdvZFc5dlRL?=
 =?utf-8?B?TFcycmRGZ3g0djRFdzN6VjV4RVZQZVc0OFl5N0d2TWkxZ3JGUmF4UWV6Ujkv?=
 =?utf-8?B?ZjViTFdmRHBHNDlSR09Sazk3Y1ZFZUJncUt5VUE1K0ZQU2cwL1hwOHRMcUlr?=
 =?utf-8?B?QjNBOHlMdmcwSi9ob0x5bFpWczg3M0ZOTDdDMWo2dWcxWjFsamFnam1TcTcr?=
 =?utf-8?B?ZWl4bXQ5UmVtZm5ZT2c2UDRyRkd0dG9aSjNrNy8vTjM3R3d2ajYxZVdSSXBC?=
 =?utf-8?B?VXFQMlV2b3BCTTUvc3VaVWhBbXlCK2duQVRHZXVOOUVkOEpHbkF3cDdFYUlC?=
 =?utf-8?B?VUhld1didE44R2piekdkQVBaZy9waFpyNFdRMnRRUkV3NzZpSzhHZWg1eGgx?=
 =?utf-8?B?WThYYTVOMEZ5RXNrTE4yRzFIZk9xQzdxMktMVlZsaGg2VWJaK0h1aUg4ZEpu?=
 =?utf-8?B?RldRa1RNOEQ4OHZZcEh1RGpwelhoUXRtWllvL1l2QlM1QUtocWxzWkZEaUZw?=
 =?utf-8?B?eEtqMkhPeWs2N0lMeUZtZlZsdVhpbUFJc1Z6TEFjVTRRYzBYRnR1bWlzL2E4?=
 =?utf-8?B?aFRBV1o3Uzh4ZE9Gbi9RUW8zVERrMVVSMEtjM1dyTnVSeDRuWTJrKzBVRVFG?=
 =?utf-8?B?ZnA3SGkrQ0RxT1QrNnNJYXRuYXBzZzRnK2hnNnUvQlRtN05BcFJSTmdQUzZY?=
 =?utf-8?B?VmllckpZYm9neUpqTUIwUGNyVThyV01GZ0xaK21OcTkxQWY4anRTY1FiZlMz?=
 =?utf-8?B?b3VqTGpRdTJ5MHJRdkovRzB5enhTVUUxcW41aklNQmN3emF1YnJ5VWdTZ3N6?=
 =?utf-8?B?OFZFN0VhbXI0NG9QejlXZDV5WHNxUTZLaSs0RlVZV3YwMVFTcXFQdUI0aG5D?=
 =?utf-8?B?c2ZXcWI2Rk5mQnVFcG1tTnlORXUzdzVSQ015aWRDNUdyRTg4THhBNk5JbHlG?=
 =?utf-8?B?WkJwZ05RZDJ6QkxVZ0pUOWVWZ1NEQ0xGYmtLR2hVam5ZZ0FlN21FazBNVGNJ?=
 =?utf-8?B?WGtBaXVzOTUxaG5DWEZWUVU0b1c1YmtjRDArb0QwcnhoZHNZZW5Hb1lUMlpQ?=
 =?utf-8?B?Qk5BRUNNaGRwSVVLY0t4UEMyT0paeTRJeDdRRmVIcHR5YzhJZEN0amJMV3M5?=
 =?utf-8?B?TEFKZXlYMzU0a0pZT2ptWWFjTkI1VGNMRnE2N29zdlNxc2RHejJvemtZWUJN?=
 =?utf-8?B?Tjk0dDhudGxWMlhMdmNPNjUvOG5uaGlVbUVFMTRFTksyZDFHNnZVb0ZRekpo?=
 =?utf-8?B?NlZVekllUjRvcVZGczU3UW1MRzlkbFViSDJPMSttODRmVTloeVFYZEVpN1g0?=
 =?utf-8?Q?KbfIarVqhXjDjcfj9ugjpRG/jFqAMNdPB/7v8Oo?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9be5a194-8d6d-4e3f-8efb-08d98c9002eb
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2021 08:20:40.2556
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: sBHciJsQRS8afeK5+v6lQu21SITZs3eOnNS1sUt3EjE6OYwZkvy+Lonn870dhufriNy3a7ACYQyyIYGC4+VIDg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5326

The conversion of the original code failed to recognize that the 32-bit
compat variant of this (sorry, two different meanings of "compat" here)
needs to continue to invoke the compat handler, not the native one.
Arrange for this by adding yet another #define.

Affected functions (having existed prior to the introduction of the new
hypercall) are PHYSDEVOP_set_iobitmap and PHYSDEVOP_apic_{read,write}.
For all others the operand struct layout doesn't differ.

Fixes: 1252e2823117 ("x86/pv: Export pv_hypercall_table[] rather than working around it in several ways")
Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
v2: Don't remove do_physdev_op override.

--- a/xen/arch/x86/x86_64/compat.c
+++ b/xen/arch/x86/x86_64/compat.c
@@ -12,6 +12,7 @@ EMIT_FILE;
 #define physdev_op_t                  physdev_op_compat_t
 #define do_physdev_op                 compat_physdev_op
 #define do_physdev_op_compat(x)       compat_physdev_op_compat(_##x)
+#define native                        compat
 
 #define COMPAT
 #define _XEN_GUEST_HANDLE(t) XEN_GUEST_HANDLE(t)



From xen-devel-bounces@lists.xenproject.org Mon Oct 11 08:48:43 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 08:48:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.205474.360775 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZqz6-0005h3-RC; Mon, 11 Oct 2021 08:48:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 205474.360775; Mon, 11 Oct 2021 08:48:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZqz6-0005gw-O1; Mon, 11 Oct 2021 08:48:36 +0000
Received: by outflank-mailman (input) for mailman id 205474;
 Mon, 11 Oct 2021 08:48:35 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=9TNE=O7=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mZqz5-0005gq-9u
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 08:48:35 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 041e8ee4-2a70-11ec-80d1-12813bfff9fa;
 Mon, 11 Oct 2021 08:48:34 +0000 (UTC)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2106.outbound.protection.outlook.com [104.47.17.106])
 (Using TLS) by relay.mimecast.com with ESMTP id
 de-mta-29-Nvly-ZQePSCTwNZddTJu0g-1; Mon, 11 Oct 2021 10:48:32 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB7150.eurprd04.prod.outlook.com (2603:10a6:800:12a::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.19; Mon, 11 Oct
 2021 08:48:30 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4587.026; Mon, 11 Oct 2021
 08:48:30 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 FR2P281CA0011.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a::21) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.4 via Frontend Transport; Mon, 11 Oct 2021 08:48:30 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 041e8ee4-2a70-11ec-80d1-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1633942113;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding;
	bh=obiM2HjdzT3HorsYf+EzFdPbdqP3jaTwHzTN8YaWOjI=;
	b=NAeN7+jiIugRd3m/OsnXmBGXtyJlehWo0ajAJT/soeC4n0GyP/8Cv8E2qWrEPhgTS90ODh
	S2wJJMxj8/H9jtVvAA+FBJ1kz1gjn+25IHWR3Drk7C8ARapk2Gh3R5ifQmMBY/Ljg1eE61
	dUm+JiRPy9/ZpRITYWwhU7UH0OWcj+8=
X-MC-Unique: Nvly-ZQePSCTwNZddTJu0g-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=KoNHRtJkoiAxJNu9gJYTFxpqLxwUKmJEG1QYzONFEvkd29btg3yBCysBRGiOd6I8YOiubTLftblEsYAzWt35GPBVAqE5043N2Mk4PXD72N1szL5RQv58s+FfcFt+xmHIZvdxn5ga1bSrywDjZXWVvJKs0p8yvhMQ/Hu0dODaqho/V7Qp94um/Oot9KPubontITu2fQ+IVG58oEH+AImww/UB9bSs6jmfXnfE8k8BRG9O7UTrTB/HnfBG2HlCBm2Sk+nNJNsJLixdPboRhFXKOH7x3Ru4m0kWuEMWynTJr7tACup53KJ5h58c7pQsRGfAf+wrzuBsq6HVvcqGL7A9dg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=obiM2HjdzT3HorsYf+EzFdPbdqP3jaTwHzTN8YaWOjI=;
 b=jJ7NO3bPjKTCXCuFykSZCX/0N3EZVOrcCE8vxMG4kS/Fyt88U+1qMkOsOuuiY0zDUVXBBzEtXsW9adsvbEN+sYtnEf/IimsbW1QKDAlOKZvr91O3FQk9VgiAjVyxzfIUV89iPXsg29oZFGIqRF5QhlOh9gGEZttGb/9H13msbv4AuXMr9ePTvRBkzmKiaClI69brLnV/VGAKibvJrp2T/XjcHpOj1/TaaRIftUoP0el8KbBGxc/rtPhw9QXiBS0XDn8TCw1YcuiFkrqYp8xlzcxukG8Nlb/8uskLluqq/S6GbXbt7lDCxn5151LuZ7WvDMU0nQUUJHCd/tAa8R6qgw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: xenproject.org; dkim=none (message not signed)
 header.d=none;xenproject.org; dmarc=none action=none header.from=suse.com;
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Kevin Tian <kevin.tian@intel.com>, Ian Jackson <iwj@xenproject.org>
From: Jan Beulich <jbeulich@suse.com>
Subject: [PATCH 0/2] VT-d: correct / extend workaround(s) leaving an IOMMU
 disabled
Message-ID: <ced41449-6aa2-3b20-77cd-78dafcad4bc7@suse.com>
Date: Mon, 11 Oct 2021 10:48:28 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR2P281CA0011.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:a::21) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 397b18f1-de98-4724-6ce0-08d98c93e663
X-MS-TrafficTypeDiagnostic: VI1PR04MB7150:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB7150F30B672520CD71438E53B3B59@VI1PR04MB7150.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:4303;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	wSluUst639k7E6O7SOthDxoUIb876QY7UOaWjJjDMrFptQ9SbFgoRj3zBYKFimUMUAPul2skpXa1Rt9h3pLy+i+e1RAa0RvzW5SkGBoyhrvQh52lj79zWj/trFMeetYSFah5u2Axa4CDnsf8deJR/bmMGHzLJQHj/ypfy77Wa3EHN5c496OUWIhAi0jxZEdPkUX+LbAfA78ewh0iRS6YL5SmwBA4G3sVz5ypHZFflJtAT6tcQUr1ZecIXrdyA6E+cdmzyZFDdt6SxEear/NhOIBXSWt06m3btjLRD14rvEXCqseurjMyYRBg5VcER05gtQmFDHZhyUAlw6y0E5M5vYNBqGGOiBulkhIgNl8VJI2jD1amtkBViEkPUKR1NlPfj9D21wX48Beg1vw+85JzmYgo3k9RCvfDC+IMWeRd/W2ZEXUrHpP2+1vyqbv8OOKarVpwblp5rRLal5+xllLx5JZq/8wAKjnx30GSzQNd9ThvSOe78HsTS+q3fr2k4SW3Ts4zreYY0ILQ59i56ZWp2RI6AWHr3BV/h/926KGaMP4vWvHgMeUrrpLlfSKixWGMIXP9TAf/T6t5SJ+mb5SU2KqdQOnQCzbtvdypcqtbM69SBRPC0V9uDZHjtPVFTCPM6rW7AK6f/9ZM/3mFn6kD7l/k7Hx4xvetZhr1nDYgtzJFZTasu/lTAT+heUEZLRzMOJQ+9eYLrzVB3no2RjIMiwsQ2wo4sfY5DughwcLUXN0=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(38100700002)(31696002)(66946007)(316002)(16576012)(6916009)(54906003)(956004)(2616005)(66556008)(66476007)(4744005)(8936002)(26005)(2906002)(508600001)(186003)(6486002)(4326008)(83380400001)(31686004)(36756003)(8676002)(86362001)(5660300002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?OG1EQkRwL09RK2plTEcwRXBsZWJlS1QrTkFKNWVaYU9LK2p4OUVrN1VERXEx?=
 =?utf-8?B?dDVSS1pMK3Z5T01hb0xxanlVeVNxMDJ6SnM5YnhCL1FwNXR6NmEzbGo4T2pP?=
 =?utf-8?B?ZkxpaUF6YTQwVmliVm9OV3NZMFhWYW9Uek1IMXcvOTR6YnJ5Ykc0ZnZnZDJm?=
 =?utf-8?B?MTh4cWVjZUZIY01nNURzL1lMaDVFejNheHQ1b0VDY0xZU21sNDl0OG40MGhX?=
 =?utf-8?B?NnljaHlmZmtPOG9wdEU1anMraThkT1pFREdIbDNGZmw3ZzZNV1dvQWtXQmlt?=
 =?utf-8?B?RWdUY1VwUGV5dmJCdFJpTVRYWTJYZ3VHOFdMRlZZRHdNdnBGTE9FQk9kL2ZY?=
 =?utf-8?B?b2JjVTVCSndSUWR6aCswMDdoNzh6RmZEZDZ6Y2lFTENweU5EYzYwb2VNN1da?=
 =?utf-8?B?ZytoMlFWNGcvcXpaYTg1aE1aQ1d2RnZndWplTWttQWl4TnpNNzdJUTZLSHNi?=
 =?utf-8?B?WE8rV0ZOZEM5UER0Vkl3RjhKVkxNMzdIVCthTGxpUFF6eU5nWndENVRva0dJ?=
 =?utf-8?B?RFZVMDRtUDlmUUNSZXR5RXBjcy9ZVUMvbmVMckNtMGx1aFBOdFcrZy8vWWRZ?=
 =?utf-8?B?NmM3NmJWRE5mSVlCTXNVRURDenpoN2VwdUF5VzZsWU5leStaRFJaSWxIaERz?=
 =?utf-8?B?djVNUzBUS0MvZE02dTFqVkxiR2svU2JQRmNOS1BhSUtqbElVenRCZ1VCQ1N2?=
 =?utf-8?B?c0pqUm9EcThTbDZDZFZUSitoNjQwUmx3S3VXTUJmZGJjOHZYY2ZEejl2NEYr?=
 =?utf-8?B?dlhuQVV5VmFBRms2MkdzYzAwWTh4TzBRRnFKdmpLWTQwTTFuNUJMUDFRZ09p?=
 =?utf-8?B?MmVpemJ4UndjNjFsU1R0RnRiS2lBNEtXY1NjWHFPR2N1TjIycU5FSG44WHB4?=
 =?utf-8?B?SmVrZW5uQjFRbVAzbGRBaTdvUGNuMUF5SkVWQ2VyR0ZoYm1jb3pCTGVJbDZM?=
 =?utf-8?B?MFNOVzZaOUhGdzJMRzJNWW52aHFSZ05aM3lYeTFiLy9JbVB2R3hiam0zQXBn?=
 =?utf-8?B?UHBHOE5adjBwWElWdGZ4NExCT0ZUekxPQ2o5cVBnVHhJN3RyVTlpV1Rqc05w?=
 =?utf-8?B?V1JWVlpIUUNKU3F6Vnlkait0Tys3cVZTcG9vU0s1MzFCcSsxQUYwSEx5Wndi?=
 =?utf-8?B?K2ZDNjU1c0hCQ1lpV28yUHdWbGVEWXVlcmdjVXpwNDBvVlVYV0RPdmcvbU9E?=
 =?utf-8?B?bmp1alJwc1EvdXE5bWRyZUxCM3I0VklPTkM4dEpMbEpUc1pMYnU5MG9aSHZq?=
 =?utf-8?B?aW1FMmIrbTgvZ3VVcWh3cVZEL2dEZ1NERUFwVWtRQXNjc25jMXh4UGdMbjJO?=
 =?utf-8?B?ZmdhT1BEUW9ZS05kNGVmL05oYkpPczhZQ0RnQ0FLZjlEYUdsa0pLOHF4NUNs?=
 =?utf-8?B?eWlzL0JQRXRDSlBzM3FWVExzU0phN3AwakMwbmJsb3JNTitYUktkYjdWNGs4?=
 =?utf-8?B?TFB5cUdHNFhoMzhpa3U4M05FKzJXdlVVSkdKdndJMEx1L2FGelRUa2Y5VnFt?=
 =?utf-8?B?UDZBZEVOK091NkNuTzd1NVl5aW0xTDhxWHk3VmkzNnBabFBOam5rZlNVcSt5?=
 =?utf-8?B?VHRWZzdySm1jSkdsdTV4WWFXVm5TdXptb2FxT2thVUZsOFpEb0pwelVSSEhJ?=
 =?utf-8?B?ZFpVb2w0NHo0V2ZPNjlDREM4anJFd05NMlB6bEk1VDdaM2R5WThVTUVHaUxB?=
 =?utf-8?B?L1hYUzdSWUoyU3hGbkN5MFNlTXh1T1AwUjZxS25tbklCTjhzZUlvREU2bXpQ?=
 =?utf-8?Q?HHtqYGSASLD8kWECQsVBv2NCo/xcVJyvSVFbt1P?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 397b18f1-de98-4724-6ce0-08d98c93e663
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2021 08:48:30.4121
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: eh2zwBJZEufVqV3zyvIg1a4SGsT6GVfEFvl0yvofCGDYO9kmfn6POakhT64tJLzZ4ZtfPu2J+4r+Xuja2qg8JQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7150

This gets us closer to what Linux does, which hopefully improves
the experience for people running Xen on affected hardware.

Ian - I'm also Cc-ing you since this feels like being on the edge
between a new feature and a bug fix.

1: generalize and correct "iommu=no-igfx" handling
2: Tylersburg isoch DMAR unit with no TLB space

Jan



From xen-devel-bounces@lists.xenproject.org Mon Oct 11 08:49:28 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 08:49:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.205482.360787 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZqzw-0006JE-96; Mon, 11 Oct 2021 08:49:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 205482.360787; Mon, 11 Oct 2021 08:49:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZqzw-0006J7-5R; Mon, 11 Oct 2021 08:49:28 +0000
Received: by outflank-mailman (input) for mailman id 205482;
 Mon, 11 Oct 2021 08:49:26 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=9TNE=O7=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mZqzu-0006Iv-QR
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 08:49:26 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 36fbc9d1-8bc8-4235-98ca-399788137746;
 Mon, 11 Oct 2021 08:49:25 +0000 (UTC)
Received: from EUR02-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur02lp2056.outbound.protection.outlook.com [104.47.5.56]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-36-MHBVtFnzPyWzDM7LWSOuFA-1; Mon, 11 Oct 2021 10:49:23 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VE1PR04MB6384.eurprd04.prod.outlook.com (2603:10a6:803:126::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.22; Mon, 11 Oct
 2021 08:49:22 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4587.026; Mon, 11 Oct 2021
 08:49:22 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 FR2P281CA0006.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a::16) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.4 via Frontend Transport; Mon, 11 Oct 2021 08:49:22 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 36fbc9d1-8bc8-4235-98ca-399788137746
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1633942164;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=vNrRYdc+maNGDxk3iToGndB3rT0CzIV0Hu920Zv7nlI=;
	b=SEvb9/LeNHb8UaEbf9s/p/T/uF9zTT3drgC0zB2DJjWciTN/zgIRJJuL/4GoRpSQOZvdM2
	ouqxjFJyqFureigPQVxH0z5QbUT4VYv7i6VzojhwkZW/PXFaqzdbS01dUlM5y0bOHjvzoJ
	p/CPPOIr1QmvQEpLXHm4XhQXLgiMfCs=
X-MC-Unique: MHBVtFnzPyWzDM7LWSOuFA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=StFg5nrlBoxL+VC2GVLwzv+Z4bCtrdEJ1yOmx2JasMDbivfJKPOF+O9E7RkJbw1YDuht1pHNVO9lsn8vDsGCZIviVn73e6V/42gsyWaIleJksiawuG5Vshi0oQcACjDkLyFLFTtILDac7+Im2b/bQw83jE6AI2wGrnN63htB/YV35e1CkmCbdNkyrARJQZOOb1O8OkN8ELeqls7dDMwqteoHgucVD1jwDWdld7vDdFkmEfIxj5JayIvnL4JakIQCidbN9zwuAujgt0B6fJBXT9Cj0IvC6fkNPkotmS5nyYQScU914oeAKat5TlRArT1GmXP1opQ/bS0hnQZ9EV6tVg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=vNrRYdc+maNGDxk3iToGndB3rT0CzIV0Hu920Zv7nlI=;
 b=C2vv5ejybbVyxsZ72Vmj3oh3UHKNdwivp7MTN68YDLwUeq3Xce9I9F5MFpYAhT6E/c3hpM1Oj20IoqDvp5KMcOJ41+KgEudq3vLBjwmiI7P9qZ8QwYFzdWJsNNC4sEWpwk54WghBgOG5LxxsJRxwcaC5imGj+I+bgnU3IwxTHpBDHRShDcm+QOxbv/lOpotAph7uSUetBChkn1kYEj0e3DgNqCi50PLfUe0A1SUug2lzRAVTr806FNEJPbR4e8Nbi2s14yWalzxx4mQ7NeHfumxo0oA0YqUyVPcpVv1AV/LTbPUzpflE9lXcFdZn883iFaqF2ULvHXVOQQVHzoQFHQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: xenproject.org; dkim=none (message not signed)
 header.d=none;xenproject.org; dmarc=none action=none header.from=suse.com;
Subject: [PATCH 1/2] VT-d: generalize and correct "iommu=no-igfx" handling
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Kevin Tian <kevin.tian@intel.com>, Ian Jackson <iwj@xenproject.org>
References: <ced41449-6aa2-3b20-77cd-78dafcad4bc7@suse.com>
Message-ID: <388b8562-e76f-e07c-a13d-f325bbc731c9@suse.com>
Date: Mon, 11 Oct 2021 10:49:21 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <ced41449-6aa2-3b20-77cd-78dafcad4bc7@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR2P281CA0006.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:a::16) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 69c5bf46-5c11-46de-1e72-08d98c940579
X-MS-TrafficTypeDiagnostic: VE1PR04MB6384:
X-Microsoft-Antispam-PRVS:
	<VE1PR04MB6384FFCED7261207EDC187DFB3B59@VE1PR04MB6384.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	wck8LBDeyUZCB0/db1559QZWuv2+UYla01REYO0w3JSNvN8Rx/uyVh2VTiJsCkrBjQW/jcj7AYQoc5LU062uiLy7JAiQ2lLcSz7cfRwgQnONJSyrl07dibYi9yxVPuKXpK376rQug3MvKAiAUefb0Yl87HFWNLrm1QA1QZuLsjWmoXiSYLtO77SXA6I4HBWtrPfLNkAGMKpOYe7Od40s4oTS8YF6iEhPizHgz1R+p2uUhclyKGHupRZB9/ihG161JNiYbdaj9AJQw5VfJq9X+bCindiI6D6P636C33TRCrRqIgjRqXSBIYri75PT9/0u1oM9sxwvUTu1dVeZVG42AIq/SBov6XekYwpTh07PlHKOJNww8UeY5g6LZxGInRqeyhUCbxOOaOOx6gU2eitdPYpkEtgxikBo1Dg/HHDyKj9H6wh820KwwP8q/J96lauL3EVphFe8YNyyt1XMxa41u3Viz1hRA6VRjWXbjWQfJnJJo4/fOXq7r+NV6qWMoR+mKdSMUaw5u0UJ9olj83AoIifq1EfR67/QbY+WvQL3K3KvOOGS45TD+jZvgLKEhwgyiOl4iGTTOxbSRW2Ugz58zEwE3vpdUgUtkJhuvxXnLEntUD/UUIDVeluJK4ZLAQiVBbqbDFR4jYit03iftoXMO8BhDMy4jRxYXka/paqLxIqhdHpB28qbIiM1xvwDo7jK3tm7ZIlbBxG1bQgc7gP9GtEz8aX9M/aFMmR92uPmmIi1MFoCQ2tUySdm0unX0b0T
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(2906002)(4326008)(31696002)(38100700002)(8936002)(31686004)(5660300002)(956004)(6916009)(36756003)(508600001)(2616005)(86362001)(83380400001)(66946007)(186003)(8676002)(26005)(316002)(54906003)(16576012)(6486002)(66556008)(66476007)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?b2FCNUtRbTNpU1p2THRJNTFCVnJUY3MrNUpVVVY2c2R6MGpiaWpiSytrRXBN?=
 =?utf-8?B?VHhhU3dWU29ML2N4aEFSSGpsL0NtLzR6NHhkRXc0ekhLdW1ZSFJkeUR0NDdr?=
 =?utf-8?B?UDNkWEtwb0ZRWVZJWE82dTZ0Tks2R3BIczNBRHJaYUwzdmplZFlBZWJBWVpp?=
 =?utf-8?B?Q3pPTmhVTUd0VG1uUnpMeTVSN2MyY3Z1QXExQWpucHZudytSWHpUZ1h6amRY?=
 =?utf-8?B?T0RqL3BuT01hYUMrQUpOR0dnd2ZaSkk5QlFtVENDOUtzdVd4SkNtZ3BxWkdO?=
 =?utf-8?B?UU9XWkhaaWlHbFg0RXRUaW85czBwN3V5MG1QNGUwRHJqeTFyZXJ6SnZMeU9Y?=
 =?utf-8?B?YkxTaVRiRGtEUkREejJtTHBqWWZ0VGxSc0FocnlmS2lhdi9qNHl6SUhac1U2?=
 =?utf-8?B?SVRzdDVPTWhYZnpiRTk1OUNFZkVYVitwOHhaQUt4VDNxZDgzbS9VNk1DZTlW?=
 =?utf-8?B?a1IxM2dJSEtqUjVjUXcyK0hpbng2WVRDZzIrR0FzOUtqWTYyWnAxNWR3UjJH?=
 =?utf-8?B?Y0QvTEtLVUFUaFp2Z1lZMDZ3akt0UlkzVGNqVldIekppRkNubnBUb25ENW5q?=
 =?utf-8?B?RFpsZ3FsWjRhbTFtRmRzY1RqTytTaGJPd1VLTitZVjZDWCtlWVE0bjFJbmww?=
 =?utf-8?B?UFpSNXNUSXVFeHRQNHMwNGxGM2VvNitrUTFYb2xRYysrVTNCTVBwNlRUQXBv?=
 =?utf-8?B?K1V3Sjd1cUlTKzN2V2pvNVNFV2c0ZmlZWjFXTm9TQ3VlQzNlUTlueWNmSko0?=
 =?utf-8?B?NzFkUEZrenUrVmQvdjZtejVMY1JpOUJKQmNyRVRhclo4b3gvQ091YkJiQ3lw?=
 =?utf-8?B?WTBCU0d0ZWNkTkY4eDVXSFpsR3o4T1dNWFlEWElZU1FXaTBTVVRTMGtDUDdV?=
 =?utf-8?B?ZGJrS0dpcjV3cHlpT1pTSmN3REI0Q0hIQUtXTk5jTTN0cExFVHd4TDA4WUtT?=
 =?utf-8?B?OFRLeEZnT3dkTDVWSXVRTmd4TWxxT2NSZU9KbFV3OC9ONml5bHdhdXI0UlFI?=
 =?utf-8?B?bHc4ZUlhblNRRXpNdVJSZDl6WHh5Wmd4Z3VPUlYvVVZZUndERkxybDBzMjFu?=
 =?utf-8?B?dFEwODFlNit5WjQzTzBEc0Y5SlhtOWIxanZ6NGhjT0ppb1VOTWlINnRCMFM2?=
 =?utf-8?B?dXdIRGVBd2ErNnE3a2NNOSt5S1FYUzRYdjduVysxVGxEbVZ3SmFOMXdmNDVP?=
 =?utf-8?B?UnRBZmMvZjNDUzc3TUN1S3BNYWdMUUZ5V0ZpUFdhNERiQXI3T3Mvc21Hb3lp?=
 =?utf-8?B?T2IzSng0NXFoSnE1SXNXUXNkSnRuNXNuNWVrYWhDYXdEbDBXaklYMXR3clhm?=
 =?utf-8?B?emd4QU9LS25LQUJzY01va0NXaXZJR2RmK3VzcHg4aURKZzRtSkVyOWRFQ3FX?=
 =?utf-8?B?a3NiZHBuQkh4QlR1cGg4S3lsRnQ4dlBXRmFEUE5YM1FjRG5zL0U4VWlKeHc5?=
 =?utf-8?B?dzRUbm83M3hEUWRHOG5aK1plR01zc0hPTHN6Q0JOcEx1UHU5VU0xZjNYMXox?=
 =?utf-8?B?aUdxTWpvQlljWWo0cHlqWGJ4anliTXFXYmhpQld4WUlCaWJVNTdXSlpVQ1Iw?=
 =?utf-8?B?VU93dUVnYUVVRW5jd0R5b041UjFCRWVUL0hKSGFPWktITGoyYW9GZmQ3SktZ?=
 =?utf-8?B?MHRXK09KQ3RnN2p3S29ySTZ3Q2o3bWdSMG1jTzlSSHJwYTNCNmhUc2lxTXhp?=
 =?utf-8?B?a3F0dHBMRlJaODByeWVUSzVkTHlxME00RFFuSjBlWkI1YmpFdkp4R1l1TXla?=
 =?utf-8?Q?PBcqpKYojQIeMiK74Ja4WwZ8uHEVFd4oa+S53mI?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 69c5bf46-5c11-46de-1e72-08d98c940579
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2021 08:49:22.5337
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: OiOKKVVvVaQd1KUinLC8er65/LAl5mMman9SA4HNkHm2p4N8BHw4iWytHaY9ADAgvJyiz77rS1Vlpr/uio8Ctg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6384

Linux'es supposedly equivalent "intel_iommu=igfx_off" deals with any
graphics devices (not just Intel ones) while at the same time limiting
the effect to IOMMUs covering only graphics devices. Keying the decision
to leave translation disabled for an IOMMU to merely a magic SBDF tuple
was wrong in the first place - systems may very well have non-graphics
devices at 0000:00:02.0 (ordinary root ports commonly live there, for
example). Any use of igd_drhd_address (and hence is_igd_drhd()) needs
further qualification.

Introduce a new "graphics only" field in struct acpi_drhd_unit and set
it according to device scope parsing outcome. Replace the bad use of
is_igd_drhd() in iommu_enable_translation() by use of this new field.

While adding the new field also convert the adjacent include_all one to
"bool".

Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
I assume an implication is that these devices then may not be passed
through to guests, yet I don't see us enforcing this anywhere.

--- a/docs/misc/xen-command-line.pandoc
+++ b/docs/misc/xen-command-line.pandoc
@@ -1494,8 +1494,8 @@ The following options are specific to In
     version 6 and greater as Registered-Based Invalidation isn't supported
     by them.
 
-*   The `igfx` boolean is active by default, and controls whether the IOMMU in
-    front of an Intel Graphics Device is enabled or not.
+*   The `igfx` boolean is active by default, and controls whether IOMMUs in
+    front of solely graphics devices get enabled or not.
 
     It is intended as a debugging mechanism for graphics issues, and to be
     similar to Linux's `intel_iommu=igfx_off` option.  If specifying `no-igfx`
--- a/xen/drivers/passthrough/vtd/dmar.c
+++ b/xen/drivers/passthrough/vtd/dmar.c
@@ -315,6 +315,7 @@ static int __init acpi_parse_dev_scope(
     struct acpi_drhd_unit *drhd = type == DMAR_TYPE ?
         container_of(scope, struct acpi_drhd_unit, scope) : NULL;
     int depth, cnt, didx = 0, ret;
+    bool gfx_only = false;
 
     if ( (cnt = scope_device_count(start, end)) < 0 )
         return cnt;
@@ -324,6 +325,8 @@ static int __init acpi_parse_dev_scope(
         scope->devices = xzalloc_array(u16, cnt);
         if ( !scope->devices )
             return -ENOMEM;
+
+        gfx_only = drhd && !drhd->include_all;
     }
     scope->devices_cnt = cnt;
 
@@ -354,6 +357,7 @@ static int __init acpi_parse_dev_scope(
                        acpi_scope->bus, sec_bus, sub_bus);
 
             dmar_scope_add_buses(scope, sec_bus, sub_bus);
+            gfx_only = false;
             break;
 
         case ACPI_DMAR_SCOPE_TYPE_HPET:
@@ -374,6 +378,8 @@ static int __init acpi_parse_dev_scope(
                 acpi_hpet_unit->dev = path->dev;
                 acpi_hpet_unit->func = path->fn;
                 list_add(&acpi_hpet_unit->list, &drhd->hpet_list);
+
+                gfx_only = false;
             }
 
             break;
@@ -388,6 +394,12 @@ static int __init acpi_parse_dev_scope(
                 if ( (seg == 0) && (bus == 0) && (path->dev == 2) &&
                      (path->fn == 0) )
                     igd_drhd_address = drhd->address;
+
+                if ( gfx_only &&
+                     pci_conf_read8(PCI_SBDF(seg, bus, path->dev, path->fn),
+                                    PCI_CLASS_DEVICE + 1) != 0x03
+                                    /* PCI_BASE_CLASS_DISPLAY */ )
+                    gfx_only = false;
             }
 
             break;
@@ -408,6 +420,8 @@ static int __init acpi_parse_dev_scope(
                 acpi_ioapic_unit->ioapic.bdf.dev = path->dev;
                 acpi_ioapic_unit->ioapic.bdf.func = path->fn;
                 list_add(&acpi_ioapic_unit->list, &drhd->ioapic_list);
+
+                gfx_only = false;
             }
 
             break;
@@ -417,11 +431,15 @@ static int __init acpi_parse_dev_scope(
                 printk(XENLOG_WARNING VTDPREFIX "Unknown scope type %#x\n",
                        acpi_scope->entry_type);
             start += acpi_scope->length;
+            gfx_only = false;
             continue;
         }
         scope->devices[didx++] = PCI_BDF(bus, path->dev, path->fn);
         start += acpi_scope->length;
-   }
+    }
+
+    if ( drhd && gfx_only )
+        drhd->gfx_only = true;
 
     ret = 0;
 
--- a/xen/drivers/passthrough/vtd/dmar.h
+++ b/xen/drivers/passthrough/vtd/dmar.h
@@ -62,7 +62,8 @@ struct acpi_drhd_unit {
     struct list_head list;
     u64    address;                     /* register base address of the unit */
     u16    segment;
-    u8     include_all:1;
+    bool   include_all:1;
+    bool   gfx_only:1;
     struct vtd_iommu *iommu;
     struct list_head ioapic_list;
     struct list_head hpet_list;
--- a/xen/drivers/passthrough/vtd/iommu.c
+++ b/xen/drivers/passthrough/vtd/iommu.c
@@ -751,7 +751,7 @@ static void iommu_enable_translation(str
     unsigned long flags;
     struct vtd_iommu *iommu = drhd->iommu;
 
-    if ( is_igd_drhd(drhd) )
+    if ( drhd->gfx_only )
     {
         if ( !iommu_igfx )
         {



From xen-devel-bounces@lists.xenproject.org Mon Oct 11 08:49:52 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 08:49:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.205487.360798 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZr0J-0006qL-I4; Mon, 11 Oct 2021 08:49:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 205487.360798; Mon, 11 Oct 2021 08:49:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZr0J-0006qE-EL; Mon, 11 Oct 2021 08:49:51 +0000
Received: by outflank-mailman (input) for mailman id 205487;
 Mon, 11 Oct 2021 08:49:50 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=9TNE=O7=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mZr0I-0006pw-84
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 08:49:50 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 3075f3d8-2a70-11ec-80d2-12813bfff9fa;
 Mon, 11 Oct 2021 08:49:48 +0000 (UTC)
Received: from EUR02-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur02lp2059.outbound.protection.outlook.com [104.47.5.59]) (Using
 TLS) by relay.mimecast.com with ESMTP id de-mta-5-FyuLNzFeNZ6BZPNH5BzT0Q-1;
 Mon, 11 Oct 2021 10:49:46 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VE1PR04MB6384.eurprd04.prod.outlook.com (2603:10a6:803:126::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.22; Mon, 11 Oct
 2021 08:49:45 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4587.026; Mon, 11 Oct 2021
 08:49:45 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS8PR04CA0005.eurprd04.prod.outlook.com (2603:10a6:20b:310::10) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.25 via Frontend
 Transport; Mon, 11 Oct 2021 08:49:45 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3075f3d8-2a70-11ec-80d2-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1633942187;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=L2QQlvL5PGwpU8KLyKuBWoy9AUUcpl/UuUJ2cFH1HIk=;
	b=UrQBXoGnDMvn3iR1pXY1pmuh2CSfyvIhf6nGtNAkydfEz3vupgnyIb89m2f3z5Her6cXhr
	4GlUUg9osht7l/K/vzj48OvyOl4PfG0HQNkCAw8zW5xi7D4kw1SVYy5QpB2EWfyCWN4R1/
	cibA3/o3RtpaajogXk/K8DDdp/Vvm6E=
X-MC-Unique: FyuLNzFeNZ6BZPNH5BzT0Q-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=fjJ/l2crAUgDMqcr73hGOqVBtpP9mRWrkx5e0wq929I0zWkoQB+kXsi3oUz1NFv8wX4T+kY6FlpRmKARlja+8TFBCMCYQKZL51WKK/hyH/k4Rzpro6wLzkHOlwAWL8Oudb+TxMwp5o9rJLoWiTUrYjqe5emvbiLBD/NqGdlNKDFv++Y/+beTin0Tyi9To4GZ3t5xk2K8zarH+AiiFkWoC499T4wCPp4vv8SoWelEryVvwgPR5DHnuL0LHLu27sMgZ+6N1XCvo5HkuBcFre631iljH8mci8jVlwy5MWbs5jIqEZLrkGneragPZXh48wV5AOWEaKonqWKGAGs96nI0jw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=L2QQlvL5PGwpU8KLyKuBWoy9AUUcpl/UuUJ2cFH1HIk=;
 b=KpdpO/82nmpXnsqOmeKmyS94sFgmQ3jr7RlI9f3R5cA1ofEP/E8PL25ezbkAnoNkHamuLnjqI4TKHy0mOo+84raguWAUl2MfVgfGr8n47fULK9JxmLJlWLXlLd/HdV8QMAogKiYLVSk7AnU/R87+1B90a7h7+Cg/mVkYkctVt/CH9Sqz5ysC4a4C7qRECQ+BzlCFUrz9PZ0ta+mAWGxO5aqSlCFFXdgGFz7JogO1iuE5PiNZ2ea+PjvvBtkfIUY+1AnLbgCF7fk7BY9Fh4IWTM15dK+W+DhqG+qfU6S+KRy2DFqFHoGv+wx2csAXqtwLpBV8Y9dUP5fk5EFqDOdYuA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: xenproject.org; dkim=none (message not signed)
 header.d=none;xenproject.org; dmarc=none action=none header.from=suse.com;
Subject: [PATCH 2/2] VT-d: Tylersburg isoch DMAR unit with no TLB space
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Kevin Tian <kevin.tian@intel.com>, Ian Jackson <iwj@xenproject.org>
References: <ced41449-6aa2-3b20-77cd-78dafcad4bc7@suse.com>
Message-ID: <a385938d-243e-1790-da1f-be7c4f5f2c3f@suse.com>
Date: Mon, 11 Oct 2021 10:49:44 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <ced41449-6aa2-3b20-77cd-78dafcad4bc7@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8PR04CA0005.eurprd04.prod.outlook.com
 (2603:10a6:20b:310::10) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 335e824e-5846-4617-d425-08d98c94132a
X-MS-TrafficTypeDiagnostic: VE1PR04MB6384:
X-Microsoft-Antispam-PRVS:
	<VE1PR04MB638456DCD5B54C9D63FD3302B3B59@VE1PR04MB6384.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7219;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Ty6kfInFNpenGpUNziOXObqWe104GeyuUm+jvWTZ0xQUcJw6iw00SPqDrgvAvxOgwJ0UVbHdxfcxoza4DAzdK3cwY+aXYQeHVi1SSvGDYr8NCwyr0DXecwx5D5J2i5CYLSbDDkenN3Let2oPVZSN+RX2LxK570CNuWPK7lPhqOFT0nic2EUXc5++qJo+5LzkRvpjbc6aPOJKgAyGn+0UQIGe37yrrfmvuiKoFYlfjuvPgBYzJVthxiOvK7bII2X21x3whHkfFRQDkL41dRMOsr5L3PlYzGvyiGaVzPQ2eSJ3n6mGEfvNBWlbDqeF6wTfRUxDWksq59yDchJh9vc205kSZq5AjPESxrtk8KJm495nQy41LkOcmPMz6ffrmz/wOj94jb18hIDkhyl4p7U0VDUiclwy3UJJucYxFkB39L9TytumYDtdczcNrTuR0Xozl8wFCa+KADRhpHyOwafmtjwb0plUnhBXGrBERU69JBI1xgJLp3/Xd0rRnYjAm+fIO5Ki9CK40pnLZlNRXmRhwWldcNDAg9SV/2ryokQC1cdfuHUBJxo9QVtMJYEtWVSZfOBxuCFJovf5NyZoxB8Yn2ub5MO6uFMXIrMaFQqNF9UPm1eVqWOjUBlZNFUVnlozJP5oZLQsxPI+d5ikfrqx+tO4n0kuz3lWk/M4PSeFwZ47ykt6QOmdrIVycjfRyMc6MWYczvllh15yoRiPf+jMlCbS73EYP+n9j6xXlcNjrCEmGb/scwQsSrNvIcEEE78x
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(2906002)(4326008)(31696002)(38100700002)(8936002)(31686004)(5660300002)(956004)(6916009)(36756003)(508600001)(2616005)(86362001)(83380400001)(66946007)(186003)(8676002)(26005)(316002)(54906003)(16576012)(6486002)(66556008)(66476007)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?RWdsTGN2WjgyYytLME5yYXkyMm1CeHJRcHpMV0pDOHFYcU5YaDRsTG4wT0hz?=
 =?utf-8?B?ZW1Eb2tZR3F0RDdNb2JUZHJQUE02MWtmREZQUDBmTC9JUVFMdHJBalk4cjJ4?=
 =?utf-8?B?THlINjhONGNnbGNxZGFONGpUVXFsQzVMSDVoemlpMXM5eXZLQjdOOHZxR2Uz?=
 =?utf-8?B?VnRmbzMrTmkvT01mVEFqRld0UDdoTjdMbVJ6V08yRlVwVGNQMU5NT2lneUNl?=
 =?utf-8?B?L2YwZnlNQlFIUnd4MDRlSWpkemRLcDJKQnVNRDl3SWR2R0xUUTAzQmIrNEhj?=
 =?utf-8?B?UXl0VkptL3BMdVdKWlI4c3RiSDZXblZVeTBzWGVLUTI3cllUdE9JSmE2VURw?=
 =?utf-8?B?WmFoSVp3OW5uK203VXFwSFdFRDJZeDR1MklETjdPb2FyTG5xWGJRekNSZEVX?=
 =?utf-8?B?TWt6NjkvT3BWaW92alYxbm10Ujlza3VwZTh6eWlKMjRzY2pMbUtXUEVzNTZs?=
 =?utf-8?B?WHQrSmNOY0pDVk84c2l2bk5VVFhRbThFb2NuL3NteDlWdmpqVHlvRUhzRkxU?=
 =?utf-8?B?SkZqZ041eURWcVE0alFVRnR5MnVBZ3hIWU93dHVudGtzbmEzektEK0JOSWZj?=
 =?utf-8?B?djJKdkJleDh5MHl2T3RyakV3MkpEUUR4TEFqeHhsUVZhWnJzclNCNVVuS0ND?=
 =?utf-8?B?UFkrOUpoZCtmeDhaUjhHZlU4YXVqZ3o5dlRQaFhDb2dKbkw0NXRINm5LM1ZW?=
 =?utf-8?B?aUIyK0ZTQnBudWVxbVVxMGtVa3ZTbXZyb1c5UG5adUhUeU9mdjIyTGZWQ1o3?=
 =?utf-8?B?ZTJJMjRDNHJiYXFJbkRXeEpNdjdPbjk3UmEydnZWRGZQTDVaQ0pVbTIxd05C?=
 =?utf-8?B?c2NXUWZhT05uSFk0czVpakl1bFBsWFk0blBQNkZid0M0SkJkWklaOU1Ha29a?=
 =?utf-8?B?VUVSeWZVNHhKY0QrVzY3R1NoM2JJV3FTNDg1LzVldWhaNm8ydE1wY3JiYjZH?=
 =?utf-8?B?MGUvUlR3MHJLSllHY0xnT2xwNjdxK2JvdjlydDRmT0JkRVZ2bVdQUXp0ZUdY?=
 =?utf-8?B?LzRpTE1UbG1kNVFMWXBsbHBTSDlDSW0vNThYVWk4dkVPSmNGOWhlVjZ3Qy91?=
 =?utf-8?B?SGVmSHJveXBzVitDR20vRk1iamFKRzNndXR1WnorbkYvSkdwTVVvUmx0R1Mr?=
 =?utf-8?B?YTBORXM3dGUyTEhiN05hY2RINGRPTEVzT0x4VzBxY0hNU0dsS0F1dUdSNi9v?=
 =?utf-8?B?YTlGMUViVkw5NkNCSysza2Zyand0T2FTNHFoQmoranZMU1pUVWVSVXdlcCt6?=
 =?utf-8?B?L0J2aTBEWWo5OWc0MkhsTDhoWkZVMmVudzhEWEhoTjN6cmhyTHpIbTJiUTVz?=
 =?utf-8?B?a2ducktsNUt4WlZXNS9zQ1RaeEM0OHV2cW1BQ2N6VWlFUHRuVzB6YTl3TjNt?=
 =?utf-8?B?QnFMUG1vYkQ0VFJHUVFxWk92TUllbElBUlZzQlIwM3E2V0xQV1d5SHZoekN3?=
 =?utf-8?B?Rkd4cCsySVlKaThKOW8xdy9oWFpkWWF4c0l1bStsbzJRNHZJdCtsSTRDZTho?=
 =?utf-8?B?ZVlBZ3dLa1M4U3MvREZRKy9OTGl3K1V6VmdHSkFsakJMcFR2L2RGL3dRMUhN?=
 =?utf-8?B?ZmE2bmhYbHNmakdpdElMenFJOWVobXQrUzJoT2tSUU5GSG9oVVRLMXF1V2RN?=
 =?utf-8?B?NlpyQTRSZDdiaXpJZTY5OXBCZ0hwN0VmVVZQTEpQcE5CVklqVkFSZ3lXc1gy?=
 =?utf-8?B?ZkF2Z09md0xJa2I1SUFMZWVwSlN1U2h4UkxTTGEvSXI0MXd4MW1IbGVjWmt6?=
 =?utf-8?Q?IodNKQPncbSxpsmxqHku6WNukG2elj+gtx2oC3C?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 335e824e-5846-4617-d425-08d98c94132a
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2021 08:49:45.4987
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: txe1SUxs5SygWkHpaPcFAQ7GPdqHj4HB8NHVHrH1vHfbcgYHDgyc15ZrrippiOYJHXi6qf7p2BYRPo9k5l0vDQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6384

BIOSes, when enabling the dedicated DMAR unit for the sound device,
need to also set a non-zero number of TLB entries in a respective
system management register (VTISOCHCTRL). At least one BIOS is known
to fail to do so, causing the VT-d engine to deadlock when used.

Vaguely based on Linux'es e0fc7e0b4b5e ("intel-iommu: Yet another BIOS
workaround: Isoch DMAR unit with no TLB space").

To limit message string redundancy, fold parts with the IGD quirk logic.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
RFC: This requires MMCFG availability before Dom0 starts up, which is
     not generally given. We may want/need to e.g. (ab)use the
     .enable_device() hook to actually disable translation if MMCFG
     accesses become available only in the course of Dom0 booting.
RFC: While following Linux in this regard, I'm not convinced of issuing
     the warning about the number of TLB entries when firmware set more
     than 16 (I can observe 20 on the on matching system I have access
     to.)

I assume an implication is that the device in this case then may not be
passed through to guests, but I don't see us enforcing the same anywhere
for graphics devices when "no-igfx" is in use. Yet here I would want to
follow whatever pre-existing model ...

--- a/xen/drivers/passthrough/vtd/extern.h
+++ b/xen/drivers/passthrough/vtd/extern.h
@@ -100,6 +100,7 @@ int msi_msg_write_remap_rte(struct msi_d
 int intel_setup_hpet_msi(struct msi_desc *);
 
 int is_igd_vt_enabled_quirk(void);
+bool is_azalia_tlb_enabled(const struct acpi_drhd_unit *);
 void platform_quirks_init(void);
 void vtd_ops_preamble_quirk(struct vtd_iommu *iommu);
 void vtd_ops_postamble_quirk(struct vtd_iommu *iommu);
--- a/xen/drivers/passthrough/vtd/iommu.c
+++ b/xen/drivers/passthrough/vtd/iommu.c
@@ -750,27 +750,43 @@ static void iommu_enable_translation(str
     u32 sts;
     unsigned long flags;
     struct vtd_iommu *iommu = drhd->iommu;
+    static const char crash_fmt[] = "%s; crash Xen for security purpose\n";
 
     if ( drhd->gfx_only )
     {
+        static const char disable_fmt[] = XENLOG_WARNING VTDPREFIX
+                                          " %s; disabling IGD VT-d engine\n";
+
         if ( !iommu_igfx )
         {
-            printk(XENLOG_INFO VTDPREFIX
-                   "Passed iommu=no-igfx option.  Disabling IGD VT-d engine.\n");
+            printk(disable_fmt, "passed iommu=no-igfx option");
             return;
         }
 
         if ( !is_igd_vt_enabled_quirk() )
         {
+            static const char msg[] = "firmware did not enable IGD for VT properly";
+
             if ( force_iommu )
-                panic("BIOS did not enable IGD for VT properly, crash Xen for security purpose\n");
+                panic(crash_fmt, msg);
 
-            printk(XENLOG_WARNING VTDPREFIX
-                   "BIOS did not enable IGD for VT properly.  Disabling IGD VT-d engine.\n");
+            printk(disable_fmt, msg);
             return;
         }
     }
 
+    if ( !is_azalia_tlb_enabled(drhd) )
+    {
+        static const char msg[] = "firmware did not enable TLB for sound device";
+
+        if ( force_iommu )
+            panic(crash_fmt, msg);
+
+        printk(XENLOG_WARNING VTDPREFIX " %s; disabling ISOCH VT-d engine\n",
+               msg);
+        return;
+    }
+
     /* apply platform specific errata workarounds */
     vtd_ops_preamble_quirk(iommu);
 
--- a/xen/drivers/passthrough/vtd/quirks.c
+++ b/xen/drivers/passthrough/vtd/quirks.c
@@ -100,6 +100,69 @@ static void __init cantiga_b3_errata_ini
         is_cantiga_b3 = 1;
 }
 
+/*
+ * QUIRK to work around certain BIOSes enabling the ISOCH DMAR unit for the
+ * Azalia sound device, but not giving it any TLB entries, causing it to
+ * deadlock.
+ */
+bool is_azalia_tlb_enabled(const struct acpi_drhd_unit *drhd)
+{
+    pci_sbdf_t sbdf;
+    unsigned int vtisochctrl;
+
+    /* Only dedicated units are of interest. */
+    if ( drhd->include_all || drhd->scope.devices_cnt != 1 )
+        return true;
+
+    /* Check for the specific device. */
+    sbdf = PCI_SBDF2(drhd->segment, drhd->scope.devices[0]);
+    if ( pci_conf_read16(sbdf, PCI_VENDOR_ID) != PCI_VENDOR_ID_INTEL ||
+         pci_conf_read16(sbdf, PCI_DEVICE_ID) != 0x3a3e )
+        return true;
+
+    /* Check for the corresponding System Management Registers device. */
+    sbdf = PCI_SBDF(drhd->segment, 0, 0x14, 0);
+    if ( pci_conf_read16(sbdf, PCI_VENDOR_ID) != PCI_VENDOR_ID_INTEL ||
+         pci_conf_read16(sbdf, PCI_DEVICE_ID) != 0x342e )
+        return true;
+
+    vtisochctrl = pci_conf_read32(sbdf, 0x188);
+    if ( vtisochctrl == 0xffffffff )
+    {
+        printk(XENLOG_WARNING VTDPREFIX
+               " Cannot access VTISOCHCTRL at this time\n");
+        return true;
+    }
+
+    /*
+     * If Azalia DMA is routed to the non-isoch DMAR unit, that's fine in
+     * principle, but not consistent with the ACPI tables.
+     */
+    if ( vtisochctrl & 1 )
+    {
+        printk(XENLOG_WARNING VTDPREFIX
+               " Inconsistency between chipset registers and ACPI tables\n");
+        return true;
+    }
+
+    /* Drop all bits other than the number of TLB entries. */
+    vtisochctrl &= 0x1c;
+
+    /* If we have the recommended number of TLB entries, fine. */
+    if ( vtisochctrl == 16 )
+        return true;
+
+    /* Zero TLB entries? */
+    if ( !vtisochctrl )
+        return false;
+
+    printk(XENLOG_WARNING VTDPREFIX
+           " Recommended TLB entries for ISOCH unit is 16; firmware set %u\n",
+           vtisochctrl);
+
+    return true;
+}
+
 /* check for Sandybridge IGD device ID's */
 static void __init snb_errata_init(void)
 {



From xen-devel-bounces@lists.xenproject.org Mon Oct 11 08:51:02 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 08:51:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.205499.360809 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZr1R-0008Eu-SH; Mon, 11 Oct 2021 08:51:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 205499.360809; Mon, 11 Oct 2021 08:51:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZr1R-0008En-Ou; Mon, 11 Oct 2021 08:51:01 +0000
Received: by outflank-mailman (input) for mailman id 205499;
 Mon, 11 Oct 2021 08:51:00 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=RBe3=O7=arm.com=Luca.Fancellu@srs-us1.protection.inumbo.net>)
 id 1mZr1P-0008ED-Ob
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 08:51:00 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com (unknown
 [40.107.6.62]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 64b8e85d-1ddd-4da8-a113-8a6d3d4ea5f0;
 Mon, 11 Oct 2021 08:50:55 +0000 (UTC)
Received: from DB6PR0301CA0101.eurprd03.prod.outlook.com (2603:10a6:6:30::48)
 by HE1PR08MB2699.eurprd08.prod.outlook.com (2603:10a6:7:2b::30) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.24; Mon, 11 Oct
 2021 08:50:52 +0000
Received: from DB5EUR03FT045.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:6:30:cafe::cf) by DB6PR0301CA0101.outlook.office365.com
 (2603:10a6:6:30::48) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.24 via Frontend
 Transport; Mon, 11 Oct 2021 08:50:52 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT045.mail.protection.outlook.com (10.152.21.164) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4587.18 via Frontend Transport; Mon, 11 Oct 2021 08:50:52 +0000
Received: ("Tessian outbound 16951d3c485e:v103");
 Mon, 11 Oct 2021 08:50:51 +0000
Received: from e2be65802ed0.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 AAA79341-688D-4524-B57D-D1B83F628C0D.1; 
 Mon, 11 Oct 2021 08:50:43 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id e2be65802ed0.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Mon, 11 Oct 2021 08:50:43 +0000
Received: from PAXPR08MB6816.eurprd08.prod.outlook.com (2603:10a6:102:130::10)
 by PR2PR08MB4714.eurprd08.prod.outlook.com (2603:10a6:101:1c::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.22; Mon, 11 Oct
 2021 08:50:38 +0000
Received: from PAXPR08MB6816.eurprd08.prod.outlook.com
 ([fe80::c1b4:db1c:376f:b697]) by PAXPR08MB6816.eurprd08.prod.outlook.com
 ([fe80::c1b4:db1c:376f:b697%8]) with mapi id 15.20.4587.026; Mon, 11 Oct 2021
 08:50:38 +0000
Received: from smtpclient.apple (82.8.129.65) by
 LO4P123CA0299.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:196::16) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4587.21 via Frontend Transport; Mon, 11 Oct 2021 08:50:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 64b8e85d-1ddd-4da8-a113-8a6d3d4ea5f0
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=C0uTVE8hQkWtE8VbaH78xqD6v1MTWkKS3ijmGd5/q0o=;
 b=bg4tRIpYTqqpVqaguh5DQMxyUpR4mBQhff8zqfPeI0ekDOGfq1z1WCK8HLVWt1X7pBocheD2DnTemAmJQ3wqtUrdORwfpoQV+zcqXKV6/w++seth1Jd+CvCItx7+dgPnr4Yt7QfWpX0O3EFuh0UqUnhrMyMra6wnW+iKppxnF4I=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 87776f74f76e384b
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=HeTuEQopruXBB6eMAz9RQ9C1HPFvuoSqWfpwMSrFfByfA0b1ipoh0hP/N3sBQfDBnOVRqrqJ9Y54bI1D743+3Vx/uFN9HcvNKQx97iYg0IM8FGVSmNov4cymaplJfFPgqvzEeOzpPyrWFtwMb9DdQo7H3Ys6tnf5EGC4WG0bk2nHbe5MNffGUGrVcJTB9cMt1X9NYdMEhVOm9pGFABleTJJsOd3qTBwLMB+lRJzxan/GT9hcaWo94o/iz8uQBMYlJszHwh+yxv+pdYymFNCSr6UPQmeCcvL4HiUBrKGzxvKryTa2mBrOBE+Mx+xW/qrpMdgAniyKTd7M5sybKm69WA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=C0uTVE8hQkWtE8VbaH78xqD6v1MTWkKS3ijmGd5/q0o=;
 b=TyWkrVGR5aNYoUPa+FNGnwSpGD6WM5Uug1fzo98cxMrW6M4ircVBiASoade6xPbWoE9ryFlp34c2EL3FpqussXyWYGmQmiN0thNu+mgdwLgELaN8MtGICLqMdvu16W048Sue7Jhbir3TIpfuUE9OWI8CiF1nXDCK3a9ej8KqjpOxWiPsECIOHWg2qp2oFDmMZw7/OSsX16RxX0bfhUu4lh9Cc1bbdPHNLQcWCg1fxMUJBd1bOrs2n3/1EnFvNCvY/rb7sOOlTJ435k4VbyOpPaFo9cJxQtkEIuB1q0adXB420lXD/4H68bB4C0zWXdD2spu0zdHM1hC5KNcTdw0Amw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=C0uTVE8hQkWtE8VbaH78xqD6v1MTWkKS3ijmGd5/q0o=;
 b=bg4tRIpYTqqpVqaguh5DQMxyUpR4mBQhff8zqfPeI0ekDOGfq1z1WCK8HLVWt1X7pBocheD2DnTemAmJQ3wqtUrdORwfpoQV+zcqXKV6/w++seth1Jd+CvCItx7+dgPnr4Yt7QfWpX0O3EFuh0UqUnhrMyMra6wnW+iKppxnF4I=
Authentication-Results-Original: suse.com; dkim=none (message not signed)
 header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
Content-Type: text/plain;
	charset=us-ascii
Subject: Re: [PATCH v5 1/2] arm/efi: Use dom0less configuration when using EFI
 boot
From: Luca Fancellu <luca.fancellu@arm.com>
In-Reply-To: <d7acbd79-fca0-f388-5304-9f85dba304fc@suse.com>
Date: Mon, 11 Oct 2021 09:50:31 +0100
Cc: Bertrand Marquis <bertrand.marquis@arm.com>,
 wei.chen@arm.com,
 Stefano Stabellini <sstabellini@kernel.org>,
 Julien Grall <julien@xen.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Ian Jackson <iwj@xenproject.org>,
 Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
Content-Transfer-Encoding: 7bit
Message-Id: <9D5D9F7A-F399-4C8C-80A6-C3B8452729D0@arm.com>
References: <20211011080302.24203-1-luca.fancellu@arm.com>
 <20211011080302.24203-2-luca.fancellu@arm.com>
 <d7acbd79-fca0-f388-5304-9f85dba304fc@suse.com>
To: Jan Beulich <jbeulich@suse.com>
X-Mailer: Apple Mail (2.3654.120.0.1.13)
X-ClientProxiedBy: LO4P123CA0299.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:196::16) To PAXPR08MB6816.eurprd08.prod.outlook.com
 (2603:10a6:102:130::10)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 388c7982-ead0-4241-b36d-08d98c943ae3
X-MS-TrafficTypeDiagnostic: PR2PR08MB4714:|HE1PR08MB2699:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS:
	<HE1PR08MB269944D3A02782F9D25886B8E4B59@HE1PR08MB2699.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Oob-TLC-OOBClassifiers: OLM:378;OLM:378;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 yCR7m6xFXHbcQVbocNzP04VRitgXUKNX9KBlhNmi7Rs3NQemnVIvZvRPBIr2MCm1eGqvG6kwiwoF0hJYG48Qa2d8VYcrzSHU1oXa+94A31VHgmsgg98xdaJuICwwE2qvIujcZ3pTyS+LYK09Obu9qKnJx6UlZZ0sDG3E9hrvbD2j04zlgDjcBiR2yqU8E5zP9UUz+V/bGqgOHLGrVya+hYoqP8qlvqCtG9RDWuWzJgOJrKdEug/LV2qPD8++a3A7lt0Pkms9j6Ct1Is2wobAdtiyk6bmEi4mNna0X1nbs9Lp2yyQl86irdaGcC5IHm01Fh801jhAigIanCivQbsivUAQKZAoZQm8F5I5T4rcAkP+IfMtfB/zabkCklpIo3w0EQ48X+iSPYp2xT+DGo+XNbnBKU/p3laEKZivgcW4/tDkfUPatkJtEfL28T6rfmLQBtwbw817yig/hcHSprfmlSlpq2unFX3MgSiqBHVeueVRMFFrOUeDpgV7VWiGXJFNhuNZAlXSiYmy6832JNjow539TaOiCep8Z35RzMRLiUie2nic2mv85OTqZ7UJdpKrDvZO/ke+Qy7JSLy99o7iiQKiRvWnPj6fDPKIiFwjZ3IZtY1oItcO9ezxXUY7v38tskhnKSU60dJK75tcBnCiD//+SgjWm7iG7XGIaLjJqsy97zlaJO6SWm5klgI8Vo5SLkRG3vclqt7NYJPyNZcfyw9ZY5QA62igHe0pFucfvVZEdEuM8MxMTTmWl9AUp96X
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB6816.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(86362001)(6666004)(26005)(8676002)(8936002)(2616005)(33656002)(956004)(186003)(6916009)(5660300002)(38100700002)(38350700002)(2906002)(44832011)(4326008)(66946007)(6486002)(66556008)(66476007)(6506007)(53546011)(52116002)(54906003)(316002)(6512007)(508600001)(83380400001)(36756003)(32563001)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR2PR08MB4714
Original-Authentication-Results: suse.com; dkim=none (message not signed)
 header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT045.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	d1756fe4-e273-425e-e377-08d98c94324c
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Z15lYrVZlIYIKYHpQhZZqGoror3r+FaDrvLKpYdSZiig1uYhluvm2HT1d+K7SfYU8qAWx3vEtoMRkrtXDDJJeT4bNG4RlZgBpE1bMk7lm/KM1oUqkfbNQMyZAxuwS5vxgboPD4idpIKCjyXTsYErWPEfAV0l13bhVbRnLzmQwL8CVsqNLkJWL9GRGzChy7mqcMdZy5Z4YqXLnCfYMG04yIpwyu6cMDSxmpD4VGDI2A3+6CDJiS+Qcy1/xBCTbcr58qJyLLZxqcxezGc0PqcbKe9Nz4yA3Kq85RoBRsb6jnLncQhpUO4BnTGhjOxFBa09lQn36F5to84AdEPz3m82+pU4aHg9sX/BaTUQ/iBSkhjxCKMWEj/LEu7gaMFyS2KcyAS8/asXADKrczfUsMc76WUESFE28p4AqCo0X3IEmxv/f0Ve9ZChRmGrLO1K1mkXb6VzEQLuv9hAH4MaEen71TnpTXjWYYSAcYvCdY2INGZwBB/t4OiUjSfpuqP+Em7d8iy82sgE6yQk0hgWj+Dm6NvE8p+kIQYPCVvaRnINCFNfPNr+qXGpB1Zl/Dz7meNcp8Kw4xizVZ2y8acK85r3qTmOr3pY/QFmT1PUec23x0ASu96hyjLor2v3Wgw0cWjM9hH5BAxcjoivBm15fSG6X6DPdfuTs0Gs1BnlsJIKVzdRfyRsRS3VXMpZK+kXF6/E+0xft62BDXJc8VMH1nxud4JEnTEb+hVszOsHqs3d8So=
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(2906002)(36860700001)(8936002)(6512007)(4326008)(47076005)(6862004)(6666004)(82310400003)(26005)(6506007)(36756003)(33656002)(186003)(53546011)(81166007)(70206006)(356005)(2616005)(336012)(83380400001)(8676002)(508600001)(70586007)(316002)(6486002)(956004)(86362001)(44832011)(5660300002)(54906003)(32563001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2021 08:50:52.0595
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 388c7982-ead0-4241-b36d-08d98c943ae3
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT045.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR08MB2699



> On 11 Oct 2021, at 09:11, Jan Beulich <jbeulich@suse.com> wrote:
> 
> On 11.10.2021 10:03, Luca Fancellu wrote:
>> This patch introduces the support for dom0less configuration
>> when using UEFI boot on ARM, it permits the EFI boot to
>> continue if no dom0 kernel is specified but at least one domU
>> is found.
>> 
>> Introduce the new property "xen,uefi-binary" for device tree boot
>> module nodes that are subnode of "xen,domain" compatible nodes.
>> The property holds a string containing the file name of the
>> binary that shall be loaded by the uefi loader from the filesystem.
>> 
>> Introduce a new call efi_check_dt_boot(...) called during EFI boot
>> that checks for module to be loaded using device tree.
>> Architectures that don't support device tree don't have to
>> provide this function.
>> 
>> Update efi documentation about how to start a dom0less
>> setup using UEFI
>> 
>> Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>
>> Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>
>> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
> 
> Did you get indication that these are fine to retain with ...
> 
>> ---
>> Changes in v5:
>> - Removed unneeded variable initialization
>> - Fixed comment
>> - Fixed error message for the absence of an initial domain kernel
>> - changed efi_arch_check_dt_boot to efi_check_dt_boot and add
>> a stub if CONFIG_HAS_DEVICE_TREE is not declared, updated commit
>> message about the call introduction in the EFI boot flow.
> 
> ... all of these changes? Every individual change may be minor enough,
> but their sum makes me wonder. If so (or if at least one of the two
> gets re-offered)
> Acked-by: Jan Beulich <jbeulich@suse.com>
> albeit preferably with ...
> 
>> --- a/xen/common/efi/boot.c
>> +++ b/xen/common/efi/boot.c
>> @@ -166,6 +166,13 @@ static void __init PrintErr(const CHAR16 *s)
>>     StdErr->OutputString(StdErr, (CHAR16 *)s );
>> }
>> 
>> +#ifndef CONFIG_HAS_DEVICE_TREE
>> +static inline int __init efi_check_dt_boot(EFI_FILE_HANDLE dir_handle)
> 
> ... the "inline" here dropped. We don't normally add this outside of
> headers, leaving it to the compiler to decide. In headers it's wanted
> to avoid "defined by never used" style warnings.

Hi Jan,

Ok I can drop it in a next serie and retain your Ack, or is it something that
can be done on commit? 

Cheers,
Luca

> 
> Jan



From xen-devel-bounces@lists.xenproject.org Mon Oct 11 08:52:16 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 08:52:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.205508.360819 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZr2e-0000Xc-9f; Mon, 11 Oct 2021 08:52:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 205508.360819; Mon, 11 Oct 2021 08:52:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZr2e-0000XV-6g; Mon, 11 Oct 2021 08:52:16 +0000
Received: by outflank-mailman (input) for mailman id 205508;
 Mon, 11 Oct 2021 08:52:15 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=9TNE=O7=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mZr2c-0000XJ-UL
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 08:52:14 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id ddc318d1-ac02-45cc-8c34-73490eefc624;
 Mon, 11 Oct 2021 08:52:14 +0000 (UTC)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2057.outbound.protection.outlook.com [104.47.14.57]) (Using
 TLS) by relay.mimecast.com with ESMTP id de-mta-4-sZI4k-bJMPC-czKH1S6e_w-1;
 Mon, 11 Oct 2021 10:52:11 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0401MB2448.eurprd04.prod.outlook.com (2603:10a6:800:52::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18; Mon, 11 Oct
 2021 08:52:10 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4587.026; Mon, 11 Oct 2021
 08:52:10 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 FR3P281CA0002.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1d::12) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.10 via Frontend Transport; Mon, 11 Oct 2021 08:52:09 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ddc318d1-ac02-45cc-8c34-73490eefc624
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1633942333;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=RZ7xgFW5MTP2F5/lY2w8Tbkjk3TQIxmeXUytyre37D4=;
	b=c+vlFx05W5JrMewJ2us4qpMJvKsSx2rzggGYB7aJdKzO9cuqfeLgAdbkmiZOBV0eGNHHMy
	i7Nw2P42IrGkPG32VJQtpvvnwEYBR8wSfWbGG/jAA2omSPPVB5XFQoT96NmQxq8DKDHHYh
	qnvXPWEwFtBXK20EjzgyosecjE1UsaY=
X-MC-Unique: sZI4k-bJMPC-czKH1S6e_w-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Vj1Whg3hnyECi/5HrFUnswn0B6N5/vzK/fXqNPiNxkdi7J7sXqt3TyVMIhGTUYtF8CNTwRTOxO9l71KCN+Qe0LKBiwT99kKsMsCOcJ6cKgARpduUg1El6fvMofUYLQoG0Ys26HOTBZ0MsNXIbsEtFE+fsY/EE5bbxvWrTtN6d0xwPnJ3eZG2IXbSfD8yi/IAq224uAmveLvhIKqpZE87VfbFemvXwb+hdDpGXLW4L9fy+sgjj+BJWl4sl6GCLDcP5vietBcw0LehPKJvPqRMUHwqjhhouIyE4fpIxn52hz1krQ/kkb+2T2WXaC10JsYMnXKkozLeO810Ua9M9DyUNg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=RZ7xgFW5MTP2F5/lY2w8Tbkjk3TQIxmeXUytyre37D4=;
 b=HPcyzEiEheKaUg1A4AaTo/xUemR/e8tbSNgy6bkAzds3sY8m64tDLg0LRgbbILr+OvI2lG3uYyV1wAA0U1YBCXSy0KX2h4LJvWCbJwzeJ9/LbRWV2adt0fcpGxsA4Eauo87O83ZQs8E0cXxRUw1M7BIjGQAHAfGMrWYLSdsiWIk/I/gcgN72Pnx45gU0TzBDntWLNkgpeSHgPah742nqVvRmRGrSrGihX/WXbgRAiAQ7BaFlBJP9nmiM1GYb5rW5uNEGk3mw65xeO69t52fs96SDROYuXJ2JhvaS4Gz+H7TBQ9BRqyUb01hzRGp7Ob4tLnVVG6IE8P1lkllYBJZNIw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [PATCH v5 1/2] arm/efi: Use dom0less configuration when using EFI
 boot
To: Luca Fancellu <luca.fancellu@arm.com>
Cc: Bertrand Marquis <bertrand.marquis@arm.com>, wei.chen@arm.com,
 Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Wei Liu <wl@xen.org>, xen-devel@lists.xenproject.org
References: <20211011080302.24203-1-luca.fancellu@arm.com>
 <20211011080302.24203-2-luca.fancellu@arm.com>
 <d7acbd79-fca0-f388-5304-9f85dba304fc@suse.com>
 <9D5D9F7A-F399-4C8C-80A6-C3B8452729D0@arm.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <b235bb9b-d9c5-5e70-fbe7-9683e5979075@suse.com>
Date: Mon, 11 Oct 2021 10:52:08 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <9D5D9F7A-F399-4C8C-80A6-C3B8452729D0@arm.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR3P281CA0002.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:1d::12) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: e34859bf-0edf-4765-29a4-08d98c946963
X-MS-TrafficTypeDiagnostic: VI1PR0401MB2448:
X-Microsoft-Antispam-PRVS:
	<VI1PR0401MB2448F973472E2974C16BE1BBB3B59@VI1PR0401MB2448.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:378;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	lkLrxt26X/QPLDMIIJto9n0+J/cpbmEZrUHZ2t/NJ4Za+gmLomTsTiAxR51CfBW/gADFwLampstzetEjhDuAYf23YBwnR0KgN6cYQgCuCFx1c0gHukt6l9obLTjSwSidwMndPwyrKjKfV3VrRFX/ChYaELNC10pDMGLx4/4TtLHlDNNH2Dqeon36075DY5sHxvaBg4SxQmjH+xzvWDtym7wMpkFek1q9NgqQuXYksG8a9r5sKkcxJ/hziPav+lXmV1YfvNGi+jZRGOzOj7flsWqH0UA/Es6qXctdg5sqnm0bP2taqzln/wsWPxpapZywkAbBg4XG4fM5uYuITKBENr7GY6DU0OFHsaHnixwKxaimQzrggGM1m3JSRdhuyUOoLBFPwEQsuG0rtF6At12Doc0tMnXpuwBtUY0jgcEhGT+TUWyLmcGZnHw2xI3FxRTkyP7w7dKlmagg6Y/VxBGDFC171FZsloIMARt9FiGqzDcnqjP/a4ug6MZZvx6QEahQyTkQM480v3/Mxu0VimyWbQz9dE77NqP5wyr/UxvRru4kwJpjfBYAuW1aH+9zCVhe8xT5BtmjgwimEl9uVdwauV65o8j4RSwncSkIMSsUaCmcc7IzyEeFL4ioIymh/Zg8ptnecwW5h5jdioskinQH6WL8rAYkq5lylNTMBRlxAZOg6edM6RWujfEtjrm+pCiz8CLaIRd7WRsKjbtGvMfCNhQdF2ACaGYDbUGbYV2JLyqGIopjLQDw5uNozmcOxNhvDUykr4m5pFaCzQg6mz+3+g==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(31696002)(66476007)(2906002)(16576012)(316002)(66556008)(6916009)(4326008)(508600001)(2616005)(956004)(31686004)(54906003)(38100700002)(36756003)(26005)(186003)(66946007)(7416002)(8936002)(53546011)(6486002)(8676002)(83380400001)(5660300002)(86362001)(32563001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?T1k1UmsxaWl2UXpHaFFnQlZLMDFVaTVIUzZkbTJiQXNGczAveEtISGxGQ2hl?=
 =?utf-8?B?bjBGS2ZndTF0NVF5SytJVndyTEZoenMxOUJvQitkVjEyOGMyT0lBRWlvaDlx?=
 =?utf-8?B?OHJyakx4dTI0NWFVOWtuZ2J4U0RYMXM1RzZuMXZDdUFnMmEzd3I0azA3SVNp?=
 =?utf-8?B?bVArUjdqUDJ4Yy9zTWNUMktqSldwNDBIMmxCYnFOVUppcXlmT2ttSFJDUmRT?=
 =?utf-8?B?aEE2SDBZb2hvcmdNc20yU3dMZ2dhcjZublo3T09NWUxsbDhxcWl4Wnp3MUZ4?=
 =?utf-8?B?ZDgvSzJacHBBUTJaT0lPbkhIWkRjak95WDd4eHRka1dmTzVoVzZvTkdnSUVk?=
 =?utf-8?B?MlFadGxJU0lYM1RmdTZTb2twVkVtMXpUSC9WOXBPMzNlRExBY3UxYkVNa051?=
 =?utf-8?B?WW1UWVlIbFhxRUs0WjV5czlkd2tHRjBiT3FMejF3TlNSRUtiR2hsZDlmUlcx?=
 =?utf-8?B?eTEydWFBU2ZrS3JhTjcraXNreWI4V3p6cWQwaEJRaExCbldYVGh2b0R0THVL?=
 =?utf-8?B?OHpqOE1FQ3pXQkpMUEVXbUxJWUxNUFMzNXovL2JUbTRDc1Z6bFRWWTV0YTJZ?=
 =?utf-8?B?dXZUNmlKZGYxeTdqM051R2drQTU5YWhRdHNNKzRUeWFML1h5T1dsTXAvZkNQ?=
 =?utf-8?B?bVlHUjgybVNOMk4xMm1YNUs4SURvT2J5ZTk2UVRJa09MaDhNQ0dMTkNrbHY3?=
 =?utf-8?B?YUhrVjVvalRrdzdyYmpIQjFuMHVwaE5zZ0JNNEhDQ2ZBSFE1V1NqajRXNW9T?=
 =?utf-8?B?VWZTUzU0ZXpDRGVTSmFDUVMwVVhLbmNWNkw0YkV5QUthK1RNK1Bxa3FOeGFP?=
 =?utf-8?B?VWdjQVI4QS9aZ3REM3E2MlVRMVd0VlJZN3B0OFc2Zi9zMVd0cnFvbDZKYVFV?=
 =?utf-8?B?S1V4WkNQZ0ZzZnpweUJ0Tlh0TjJxejhZVFBxRlR3bVFwbEN2VE5UclY0UjhL?=
 =?utf-8?B?aitOSlhhb3NNQ2hDUmdSUTlUeDlNVmRKOTVFQnc0S3hLWktyemxScmtob3No?=
 =?utf-8?B?TTBhY1Uzc1lxQnFpSEVjdDFPNGk5bmlLWlR6R2ZDbm9QdmVEaDNtaEgvM3pP?=
 =?utf-8?B?UzZwS1VQdzNGakh2eFJodDhoNzcyLzZWS3BvSndZMDZYWlZPK00vV3puL0lq?=
 =?utf-8?B?ZTYybk5uUmVrQytJNCtKYklQMTZsVmxwK1E1a21xNkhvRHh2WlRWbTh2bHJD?=
 =?utf-8?B?U1dkNyt1c1ZNRlVDVlFYT0RCSkxqZTZmbnNSOUErSGRXdC9IaE45N3RXNmZy?=
 =?utf-8?B?aFVIUFZTRWFVMDFPRHNWYXFnNmM5OWQzMkxMUUFBZ2ZlbHFsdFNaVnFsRE9L?=
 =?utf-8?B?RlRLV3VpYm9PQ2FSVzZDYUtsTWg4TEJhV1NoLy9GbTFwakFpZ1hLZlJPL083?=
 =?utf-8?B?ZGM1QlZGOTFwS2dXNmNwQzNqaEtRZHhSVWxibldVRnZOZ25ObFduUmo5NEV6?=
 =?utf-8?B?cVM0VzhzY3B4YXdqUDRvdkNDQTlOSU1tOFE0R080UzNvQ01TcWx1TFhaUm1t?=
 =?utf-8?B?dnkrdExUV1IxUllzbzIxM25Dd01ReGZFNUVoMldLZXJnMWJ2Z091cERTYTNE?=
 =?utf-8?B?bmtXOTVhOTRxbTUrSUxrZWdtM0M5SGxjTFREU2x4QmZoalBIYlNuTnlOb0pY?=
 =?utf-8?B?RGpZTjFPK3B4eXY3elovRGpzRW9IMVlnbUFsRzg4bWE3Z3VNa0RTYTNGUWhC?=
 =?utf-8?B?cmg0UWQxZXpTbUlnVTVreFFydmpjMEpYVVdqVjlQeEVlZnA2WE5tcWFRRVc0?=
 =?utf-8?Q?8EnzJK2iTaot3Whut9JBD9LuNCgmxw+YTfzp+mg?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e34859bf-0edf-4765-29a4-08d98c946963
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2021 08:52:10.1590
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: tXkBV3MLe0ekofmorXI7CSse9fwsg7DGy3H5zJpvvYuOyktJm6ldwiwetLea7MxVtVqIX/l8iy9NWVNrv5tmvA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2448

On 11.10.2021 10:50, Luca Fancellu wrote:
>> On 11 Oct 2021, at 09:11, Jan Beulich <jbeulich@suse.com> wrote:
>> On 11.10.2021 10:03, Luca Fancellu wrote:
>>> This patch introduces the support for dom0less configuration
>>> when using UEFI boot on ARM, it permits the EFI boot to
>>> continue if no dom0 kernel is specified but at least one domU
>>> is found.
>>>
>>> Introduce the new property "xen,uefi-binary" for device tree boot
>>> module nodes that are subnode of "xen,domain" compatible nodes.
>>> The property holds a string containing the file name of the
>>> binary that shall be loaded by the uefi loader from the filesystem.
>>>
>>> Introduce a new call efi_check_dt_boot(...) called during EFI boot
>>> that checks for module to be loaded using device tree.
>>> Architectures that don't support device tree don't have to
>>> provide this function.
>>>
>>> Update efi documentation about how to start a dom0less
>>> setup using UEFI
>>>
>>> Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>
>>> Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>
>>> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
>>
>> Did you get indication that these are fine to retain with ...
>>
>>> ---
>>> Changes in v5:
>>> - Removed unneeded variable initialization
>>> - Fixed comment
>>> - Fixed error message for the absence of an initial domain kernel
>>> - changed efi_arch_check_dt_boot to efi_check_dt_boot and add
>>> a stub if CONFIG_HAS_DEVICE_TREE is not declared, updated commit
>>> message about the call introduction in the EFI boot flow.
>>
>> ... all of these changes? Every individual change may be minor enough,
>> but their sum makes me wonder. If so (or if at least one of the two
>> gets re-offered)
>> Acked-by: Jan Beulich <jbeulich@suse.com>
>> albeit preferably with ...
>>
>>> --- a/xen/common/efi/boot.c
>>> +++ b/xen/common/efi/boot.c
>>> @@ -166,6 +166,13 @@ static void __init PrintErr(const CHAR16 *s)
>>>     StdErr->OutputString(StdErr, (CHAR16 *)s );
>>> }
>>>
>>> +#ifndef CONFIG_HAS_DEVICE_TREE
>>> +static inline int __init efi_check_dt_boot(EFI_FILE_HANDLE dir_handle)
>>
>> ... the "inline" here dropped. We don't normally add this outside of
>> headers, leaving it to the compiler to decide. In headers it's wanted
>> to avoid "defined by never used" style warnings.
> 
> Ok I can drop it in a next serie and retain your Ack, or is it something that
> can be done on commit? 

I guess that's easy enough to do while committing. Provided of course
the two R-b get confirmed.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Oct 11 08:56:37 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 08:56:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.205516.360831 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZr6m-0001Cf-RT; Mon, 11 Oct 2021 08:56:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 205516.360831; Mon, 11 Oct 2021 08:56:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZr6m-0001CY-OD; Mon, 11 Oct 2021 08:56:32 +0000
Received: by outflank-mailman (input) for mailman id 205516;
 Mon, 11 Oct 2021 08:56:32 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=LfEM=O7=arm.com=Bertrand.Marquis@srs-us1.protection.inumbo.net>)
 id 1mZr6m-0001CS-5Y
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 08:56:32 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com (unknown
 [40.107.21.45]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 20073809-2a71-11ec-80d2-12813bfff9fa;
 Mon, 11 Oct 2021 08:56:31 +0000 (UTC)
Received: from AM5PR04CA0036.eurprd04.prod.outlook.com (2603:10a6:206:1::49)
 by DB8PR08MB5371.eurprd08.prod.outlook.com (2603:10a6:10:114::7) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.19; Mon, 11 Oct
 2021 08:56:27 +0000
Received: from VE1EUR03FT045.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:206:1:cafe::67) by AM5PR04CA0036.outlook.office365.com
 (2603:10a6:206:1::49) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.21 via Frontend
 Transport; Mon, 11 Oct 2021 08:56:27 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT045.mail.protection.outlook.com (10.152.19.51) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4587.18 via Frontend Transport; Mon, 11 Oct 2021 08:56:27 +0000
Received: ("Tessian outbound f1898412aff1:v103");
 Mon, 11 Oct 2021 08:56:27 +0000
Received: from 74725e10d297.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 8136C1F1-7295-4A24-826B-853AA1D88374.1; 
 Mon, 11 Oct 2021 08:56:16 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 74725e10d297.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Mon, 11 Oct 2021 08:56:16 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com (2603:10a6:4:74::9)
 by DB9PR08MB6779.eurprd08.prod.outlook.com (2603:10a6:10:2a1::21) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18; Mon, 11 Oct
 2021 08:56:13 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955]) by DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955%4]) with mapi id 15.20.4587.026; Mon, 11 Oct 2021
 08:56:13 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 20073809-2a71-11ec-80d2-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=28ZnLR4xsQYS1yU5qFJD7IznQZsEhijGabxw2q5ZwMM=;
 b=fOO7c6bpZs0YdKGKwZJfB+iyBDBQP0J9EIpUXQi+BPCaBeAd1nhkui2YuCEjRXQBW4Jyn3jucgPriU+8497ZBDrk0FvnkHy+/8N7pegfEn6Ye3SvdkxxoNDbYNk18HlpJcmLK8hHpYQRlhnOElsgkvA+By0etA+Gavw9cioCJCY=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 262b2fa8db554f09
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=AmL3mD3jkuAEUXAf0tbmYVUFrrhKwlPBbWABBDk0xiqP34Te7Sj93qpkto3t/6hPk/4uizt6ULiyX4LqYW4zUtslu+fl6tEtyhjEMgunbkMLrKLctO6oDU6KlZynSrZ+Cz/j+btSzGY4HnfLEaOYsc4opJGXMKblkZCIBrxRnn4nQ9V/iqls3OJk2sBUlC5cfQQ8/rBW/jFONmbuMPIJUyiFXueOHZu0McWugFZ9O5NMrCvGZwg+E87nsk7d4kwVfUC2ajDutQHMk414EC8phKw2GoqxQ1nNdjqnonKuQKc5QTu2fJfczAxrCgqqXaWCYYSZ3NZ7pVdsdNURFupYEQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=28ZnLR4xsQYS1yU5qFJD7IznQZsEhijGabxw2q5ZwMM=;
 b=NUcsROvyvF2rw6fPYMWpZriIukikXsBbbqE4qm5luLiCvTvZ36jj6t2PwPEYB13zZhFoiVTZU3xISbcc9r3f/zPVlOmVerhVbrVTlfrvaSyIgonG+hQ9L4lYQtqwGVrlrke9RuaXep/pGRu7Y5ZCmZWNASyCQmF2MYN9MShMXTVWTnN5V4D481EHBGL8lr6giidW8ks0de6cKYvjKDu5SCZfUtXlNk1puMM43ENurd6zkYhrMI6N2PcahT5GRqu5EOGGjbz4MuZjvcLadkqhlP7yQ915Q8E0G1mxVY4jdVDiAx1VDtIiIFxMJjPHAom2pz2rPbgoxrsBvvt7HRS3Vw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=28ZnLR4xsQYS1yU5qFJD7IznQZsEhijGabxw2q5ZwMM=;
 b=fOO7c6bpZs0YdKGKwZJfB+iyBDBQP0J9EIpUXQi+BPCaBeAd1nhkui2YuCEjRXQBW4Jyn3jucgPriU+8497ZBDrk0FvnkHy+/8N7pegfEn6Ye3SvdkxxoNDbYNk18HlpJcmLK8hHpYQRlhnOElsgkvA+By0etA+Gavw9cioCJCY=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Luca Fancellu <Luca.Fancellu@arm.com>, Wei Chen <Wei.Chen@arm.com>,
	Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, Andrew Cooper
	<andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>, Ian
 Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v5 1/2] arm/efi: Use dom0less configuration when using EFI
 boot
Thread-Topic: [PATCH v5 1/2] arm/efi: Use dom0less configuration when using
 EFI boot
Thread-Index: AQHXvnZ+rYVQ3wonZUSICyS3GbtBZKvNcjoAgAAK8ICAAAB0AIAAASSA
Date: Mon, 11 Oct 2021 08:56:13 +0000
Message-ID: <C1176381-C6D5-46BD-A13D-7F3E7528B655@arm.com>
References: <20211011080302.24203-1-luca.fancellu@arm.com>
 <20211011080302.24203-2-luca.fancellu@arm.com>
 <d7acbd79-fca0-f388-5304-9f85dba304fc@suse.com>
 <9D5D9F7A-F399-4C8C-80A6-C3B8452729D0@arm.com>
 <b235bb9b-d9c5-5e70-fbe7-9683e5979075@suse.com>
In-Reply-To: <b235bb9b-d9c5-5e70-fbe7-9683e5979075@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3654.120.0.1.13)
Authentication-Results-Original: suse.com; dkim=none (message not signed)
 header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: 8a52c180-264a-4ace-9f77-08d98c9502f1
x-ms-traffictypediagnostic: DB9PR08MB6779:|DB8PR08MB5371:
x-ms-exchange-transport-forked: True
X-Microsoft-Antispam-PRVS:
	<DB8PR08MB5371F2A6BB5CB28E5917FCF29DB59@DB8PR08MB5371.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:378;OLM:378;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 vQiA4gneYhf86L/6p7v7SLF3k+JJ1OfAG69PlNm2R2RH/uKcpgAA4+m7S57cfbGpj2VKIYVedKujZ79d9mukxNJECTLrp4dA2QqZVceGuY8DPF/LdILLAM0S0HP8DHzY/2l2lWm9ipx7CsjdO2kKsYKQMuF9hLgMPM+ok6pgshBOD/SUStpkU8/GwKa4pF1eYlN2GRJmuwdug24B/iBu5niizl0mcOx691p/KNMVSXoNAjbT8spG6eQTGN9Hrz1AL74owPTZT4M5AeG5sKXmrQXNWuP9+QagQLGdMMU7XwpMFnVEy9sjONw4vbAVbmspagPn8U3DtyxTcTeLIPzfYwUBIp9MH4kM8Vj3ZV8Vc7gto/9N5GbAJhmRqJqv9eJ7kLiF+R7Ib7dlpNXXFKB5wB9s+msdFb1ws1pR3HpYT95vsOT+nClnwKS7r4AUMHK3if36NPiDOoUUh0CVuP+EtIHlclxHmW9cbA9Fz3A6AyPSvVP+0zka3wa+tLKryssmPgqKuqG0EgFRnD070u2XnTVCttDUU1oNOtetg0Er7gpebGpAQKCW9ofN7jtRMf1lak5U5q2fvi1NVa4GlNRkHw1NtLHl2Zq1R2fBSr/PyCuGrcKjx46whdt7gip+/qU7bArWHtblioDnBveZUJT15MVZbEhFvX4NeIAJbN5Ld13cu1SUzd1YBkin9yjudsOBVifiXHeZAIrIgwDY8x2esHmiZpVINe2QsO39KniuKq8kE1shYEdqGYIrtyWjhd21aNXr33a8CxjuqNTeMr/Uew==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB6PR0801MB2024.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(2906002)(66476007)(316002)(66556008)(6512007)(66446008)(33656002)(6916009)(64756008)(4326008)(508600001)(2616005)(71200400001)(54906003)(5660300002)(36756003)(91956017)(6506007)(38100700002)(38070700005)(26005)(186003)(66946007)(76116006)(8936002)(53546011)(6486002)(8676002)(122000001)(83380400001)(86362001)(32563001)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="us-ascii"
Content-ID: <F9FECB07F977824DBD5D5709CB12C9E0@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB6779
Original-Authentication-Results: suse.com; dkim=none (message not signed)
 header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT045.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	4f2baf93-73a2-4c89-b947-08d98c94fab1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	H5WJXgDAGhcKb0tS1mv6J5/WNd//o6cL1Q8O77h1hIwFp/kMJBKxL2qUig7tTh7hQ7ARSdiWQEq1zKaV7jKFvnout6slHJtZp1LJpehyjGQWBEMB/z9TymDATBlvghicgpr7pode6dJO7awOvlzD1vAJXXjRL2O4J0mgngrWa2KiUafooWSnW9x4sqEkpYQeC/KqkwX4gQJPQ2Dnn/3JMD66Ct6BUqPBjeDP+8hWcVMFjRsug7bFMXH2oFKDSN2TBVAEPojGC4lnhTNKD46RHvXr2TPsxhoYwElDcR7+LOD8UkF7OVK+yEKgcwsaKq5MydLf8SBl9KIMFB0+jn6WBXpgQF4/tA5q8sv3l8tHEWDmEUHtsfbEhaTRWS6yVBfQdbPiOHCCjILHkdrhvIuvZyOmaNFMMPo+IbSJZvNtcBHYluaHIX3XtUKPsZm5vmJs8CjzjQmWV6fGD5r1ZnhoCEMaiVCtvptaDtAYdOYzsgDtQqwYdKYI/F08CxONn+WTOX7T45k208p3L3qVou9eSriNsVnDerSGWxW6Eyd3FXfZVsOa/gt4O6DvmLpvocZUXerTpFEqNTAH2m3NV33HHKjTCZyq23X5cREgrIqSpSKSTW69psqxcz+b9Mk34FAk4KtnsCIZ53pPJ5P1bdjEH741zjg3rSw9ePJXMVGZupk/4WTt09YUZoxL+V00ByRiHW/K8SDxOlFoCLDQKXUiJKd2y0K/slFvSasw+wlUvJs=
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(186003)(82310400003)(6862004)(26005)(356005)(81166007)(8936002)(2906002)(508600001)(8676002)(86362001)(36756003)(53546011)(6506007)(5660300002)(6486002)(4326008)(83380400001)(6512007)(316002)(47076005)(54906003)(2616005)(70206006)(33656002)(70586007)(336012)(36860700001)(32563001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2021 08:56:27.5941
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 8a52c180-264a-4ace-9f77-08d98c9502f1
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT045.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB5371

Hi Jan,

> On 11 Oct 2021, at 09:52, Jan Beulich <jbeulich@suse.com> wrote:
>=20
> On 11.10.2021 10:50, Luca Fancellu wrote:
>>> On 11 Oct 2021, at 09:11, Jan Beulich <jbeulich@suse.com> wrote:
>>> On 11.10.2021 10:03, Luca Fancellu wrote:
>>>> This patch introduces the support for dom0less configuration
>>>> when using UEFI boot on ARM, it permits the EFI boot to
>>>> continue if no dom0 kernel is specified but at least one domU
>>>> is found.
>>>>=20
>>>> Introduce the new property "xen,uefi-binary" for device tree boot
>>>> module nodes that are subnode of "xen,domain" compatible nodes.
>>>> The property holds a string containing the file name of the
>>>> binary that shall be loaded by the uefi loader from the filesystem.
>>>>=20
>>>> Introduce a new call efi_check_dt_boot(...) called during EFI boot
>>>> that checks for module to be loaded using device tree.
>>>> Architectures that don't support device tree don't have to
>>>> provide this function.
>>>>=20
>>>> Update efi documentation about how to start a dom0less
>>>> setup using UEFI
>>>>=20
>>>> Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>
>>>> Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>
>>>> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
>>>=20
>>> Did you get indication that these are fine to retain with ...
>>>=20
>>>> ---
>>>> Changes in v5:
>>>> - Removed unneeded variable initialization
>>>> - Fixed comment
>>>> - Fixed error message for the absence of an initial domain kernel
>>>> - changed efi_arch_check_dt_boot to efi_check_dt_boot and add
>>>> a stub if CONFIG_HAS_DEVICE_TREE is not declared, updated commit
>>>> message about the call introduction in the EFI boot flow.
>>>=20
>>> ... all of these changes? Every individual change may be minor enough,
>>> but their sum makes me wonder. If so (or if at least one of the two
>>> gets re-offered)
>>> Acked-by: Jan Beulich <jbeulich@suse.com>
>>> albeit preferably with ...
>>>=20
>>>> --- a/xen/common/efi/boot.c
>>>> +++ b/xen/common/efi/boot.c
>>>> @@ -166,6 +166,13 @@ static void __init PrintErr(const CHAR16 *s)
>>>>    StdErr->OutputString(StdErr, (CHAR16 *)s );
>>>> }
>>>>=20
>>>> +#ifndef CONFIG_HAS_DEVICE_TREE
>>>> +static inline int __init efi_check_dt_boot(EFI_FILE_HANDLE dir_handle=
)
>>>=20
>>> ... the "inline" here dropped. We don't normally add this outside of
>>> headers, leaving it to the compiler to decide. In headers it's wanted
>>> to avoid "defined by never used" style warnings.
>>=20
>> Ok I can drop it in a next serie and retain your Ack, or is it something=
 that
>> can be done on commit?=20
>=20
> I guess that's easy enough to do while committing. Provided of course
> the two R-b get confirmed.

I confirm my R-b.

Cheers
Bertrand

>=20
> Jan



From xen-devel-bounces@lists.xenproject.org Mon Oct 11 09:01:06 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 09:01:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.205524.360841 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZrBA-0002dQ-Cg; Mon, 11 Oct 2021 09:01:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 205524.360841; Mon, 11 Oct 2021 09:01:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZrBA-0002dJ-9q; Mon, 11 Oct 2021 09:01:04 +0000
Received: by outflank-mailman (input) for mailman id 205524;
 Mon, 11 Oct 2021 09:01:03 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Tf9x=O7=arm.com=michal.orzel@srs-us1.protection.inumbo.net>)
 id 1mZrB9-0002dD-D0
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 09:01:03 +0000
Received: from foss.arm.com (unknown [217.140.110.172])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTP
 id 494c8b0d-5351-4794-8348-34b080d3b138;
 Mon, 11 Oct 2021 09:01:02 +0000 (UTC)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9D7981FB;
 Mon, 11 Oct 2021 02:01:01 -0700 (PDT)
Received: from e123311-lin.arm.com (unknown [10.57.19.78])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0C1143F66F;
 Mon, 11 Oct 2021 02:00:58 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 494c8b0d-5351-4794-8348-34b080d3b138
From: Michal Orzel <michal.orzel@arm.com>
To: xen-devel@lists.xenproject.org
Cc: George Dunlap <george.dunlap@citrix.com>,
	Nick Rosbrook <rosbrookn@ainfosec.com>,
	Ian Jackson <iwj@xenproject.org>,
	Wei Liu <wl@xen.org>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Anthony PERARD <anthony.perard@citrix.com>,
	Juergen Gross <jgross@suse.com>,
	Christian Lindig <christian.lindig@citrix.com>,
	David Scott <dave@recoil.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	bertrand.marquis@arm.com
Subject: [PATCH v4 0/3] Expose PMU to the guests
Date: Mon, 11 Oct 2021 11:00:44 +0200
Message-Id: <20211011090047.8878-1-michal.orzel@arm.com>
X-Mailer: git-send-email 2.29.0
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

This patch series is a rework of an already pushed patch
exposing PMU to the guests. Since the second version the vpmu
parameter is common and prework in the form of reporting
availability of vPMU on the hardware is added.

The third version of the patch series removes the redundant check
from x86 code and modifies the way to define the flags XEN_DOMCTL_CDF and
XEN_SYSCTL_PHYSCAP, meaning not to define bit position and mask separately.

In the fourth version, the additional check is added so that we fail
if vpmu is set in the config file but XEN_SYSCTL_PHYSCAP_vpmu is not available.

The current status is that the PMU registers are not virtualized
and the physical registers are directly accessible when "vpmu"
parameter is enabled in the guest config file. There is no interrupt
support and Xen will not save/restore the register values on context
switches. This is to be done in the future.

Michal Orzel (3):
  xen+tools: Introduce XEN_SYSCTL_PHYSCAP_vpmu
  xen/arm: Check for PMU platform support
  xen: Expose the PMU to the guests

 docs/man/xl.cfg.5.pod.in             | 17 ++++++++++
 tools/golang/xenlight/helpers.gen.go |  8 +++++
 tools/golang/xenlight/types.gen.go   |  2 ++
 tools/include/libxl.h                | 12 +++++++
 tools/libs/light/libxl.c             |  1 +
 tools/libs/light/libxl_create.c      | 10 ++++++
 tools/libs/light/libxl_types.idl     |  3 ++
 tools/ocaml/libs/xc/xenctrl.ml       |  2 ++
 tools/ocaml/libs/xc/xenctrl.mli      |  2 ++
 tools/xl/xl_info.c                   |  5 +--
 tools/xl/xl_parse.c                  |  2 ++
 xen/arch/arm/domain.c                | 12 +++++--
 xen/arch/arm/setup.c                 |  1 +
 xen/common/domain.c                  | 12 ++++++-
 xen/common/sysctl.c                  |  3 ++
 xen/include/asm-arm/cpufeature.h     | 49 ++++++++++++++++++++++++++--
 xen/include/asm-arm/domain.h         |  1 +
 xen/include/public/domctl.h          |  4 ++-
 xen/include/public/sysctl.h          |  6 ++--
 xen/include/xen/domain.h             |  2 ++
 20 files changed, 143 insertions(+), 11 deletions(-)

-- 
2.29.0



From xen-devel-bounces@lists.xenproject.org Mon Oct 11 09:01:07 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 09:01:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.205525.360853 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZrBD-0002uw-P1; Mon, 11 Oct 2021 09:01:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 205525.360853; Mon, 11 Oct 2021 09:01:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZrBD-0002un-LY; Mon, 11 Oct 2021 09:01:07 +0000
Received: by outflank-mailman (input) for mailman id 205525;
 Mon, 11 Oct 2021 09:01:06 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Tf9x=O7=arm.com=michal.orzel@srs-us1.protection.inumbo.net>)
 id 1mZrBC-0002uG-Kk
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 09:01:06 +0000
Received: from foss.arm.com (unknown [217.140.110.172])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTP
 id c3e86d3e-2a71-11ec-80d2-12813bfff9fa;
 Mon, 11 Oct 2021 09:01:04 +0000 (UTC)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 801CE1FB;
 Mon, 11 Oct 2021 02:01:04 -0700 (PDT)
Received: from e123311-lin.arm.com (unknown [10.57.19.78])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E4D293F66F;
 Mon, 11 Oct 2021 02:01:01 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c3e86d3e-2a71-11ec-80d2-12813bfff9fa
From: Michal Orzel <michal.orzel@arm.com>
To: xen-devel@lists.xenproject.org
Cc: George Dunlap <george.dunlap@citrix.com>,
	Nick Rosbrook <rosbrookn@ainfosec.com>,
	Ian Jackson <iwj@xenproject.org>,
	Wei Liu <wl@xen.org>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Anthony PERARD <anthony.perard@citrix.com>,
	Juergen Gross <jgross@suse.com>,
	Christian Lindig <christian.lindig@citrix.com>,
	David Scott <dave@recoil.org>,
	bertrand.marquis@arm.com
Subject: [PATCH v4 1/3] xen+tools: Introduce XEN_SYSCTL_PHYSCAP_vpmu
Date: Mon, 11 Oct 2021 11:00:45 +0200
Message-Id: <20211011090047.8878-2-michal.orzel@arm.com>
X-Mailer: git-send-email 2.29.0
In-Reply-To: <20211011090047.8878-1-michal.orzel@arm.com>
References: <20211011090047.8878-1-michal.orzel@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Introduce flag XEN_SYSCTL_PHYSCAP_vpmu which
indicates whether the platform supports vPMU
functionality. Modify Xen and tools accordingly.

Take the opportunity and fix XEN_SYSCTL_PHYSCAP_vmtrace
definition in sysctl.h which wrongly use (1 << 6)
instead of (1u << 6).

Signed-off-by: Michal Orzel <michal.orzel@arm.com>
Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>
Acked-by: Nick Rosbrook <rosbrookn@ainfosec.com>
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
---
Changes since v3:
-add spaces between brackets and keyword
Changes since v2:
-do not define bit position and mask separately
Changes since v1:
-new in v2
---
 tools/golang/xenlight/helpers.gen.go | 2 ++
 tools/golang/xenlight/types.gen.go   | 1 +
 tools/include/libxl.h                | 6 ++++++
 tools/libs/light/libxl.c             | 1 +
 tools/libs/light/libxl_types.idl     | 1 +
 tools/ocaml/libs/xc/xenctrl.ml       | 1 +
 tools/ocaml/libs/xc/xenctrl.mli      | 1 +
 tools/xl/xl_info.c                   | 5 +++--
 xen/common/domain.c                  | 2 ++
 xen/common/sysctl.c                  | 3 +++
 xen/include/public/sysctl.h          | 6 ++++--
 xen/include/xen/domain.h             | 2 ++
 12 files changed, 27 insertions(+), 4 deletions(-)

diff --git a/tools/golang/xenlight/helpers.gen.go b/tools/golang/xenlight/helpers.gen.go
index bfc1e7f312..c8669837d8 100644
--- a/tools/golang/xenlight/helpers.gen.go
+++ b/tools/golang/xenlight/helpers.gen.go
@@ -3360,6 +3360,7 @@ x.CapHap = bool(xc.cap_hap)
 x.CapShadow = bool(xc.cap_shadow)
 x.CapIommuHapPtShare = bool(xc.cap_iommu_hap_pt_share)
 x.CapVmtrace = bool(xc.cap_vmtrace)
+x.CapVpmu = bool(xc.cap_vpmu)
 
  return nil}
 
@@ -3391,6 +3392,7 @@ xc.cap_hap = C.bool(x.CapHap)
 xc.cap_shadow = C.bool(x.CapShadow)
 xc.cap_iommu_hap_pt_share = C.bool(x.CapIommuHapPtShare)
 xc.cap_vmtrace = C.bool(x.CapVmtrace)
+xc.cap_vpmu = C.bool(x.CapVpmu)
 
  return nil
  }
diff --git a/tools/golang/xenlight/types.gen.go b/tools/golang/xenlight/types.gen.go
index 09a3bb67e2..45f2cba3d2 100644
--- a/tools/golang/xenlight/types.gen.go
+++ b/tools/golang/xenlight/types.gen.go
@@ -1008,6 +1008,7 @@ CapHap bool
 CapShadow bool
 CapIommuHapPtShare bool
 CapVmtrace bool
+CapVpmu bool
 }
 
 type Connectorinfo struct {
diff --git a/tools/include/libxl.h b/tools/include/libxl.h
index b9ba16d698..ec5e3badae 100644
--- a/tools/include/libxl.h
+++ b/tools/include/libxl.h
@@ -502,6 +502,12 @@
  */
 #define LIBXL_HAVE_X86_MSR_RELAXED 1
 
+/*
+ * LIBXL_HAVE_PHYSINFO_CAP_VPMU indicates that libxl_physinfo has a cap_vpmu
+ * field, which indicates the availability of vPMU functionality.
+ */
+#define LIBXL_HAVE_PHYSINFO_CAP_VPMU 1
+
 /*
  * libxl ABI compatibility
  *
diff --git a/tools/libs/light/libxl.c b/tools/libs/light/libxl.c
index 204eb0be2d..a032723fde 100644
--- a/tools/libs/light/libxl.c
+++ b/tools/libs/light/libxl.c
@@ -404,6 +404,7 @@ int libxl_get_physinfo(libxl_ctx *ctx, libxl_physinfo *physinfo)
         !!(xcphysinfo.capabilities & XEN_SYSCTL_PHYSCAP_iommu_hap_pt_share);
     physinfo->cap_vmtrace =
         !!(xcphysinfo.capabilities & XEN_SYSCTL_PHYSCAP_vmtrace);
+    physinfo->cap_vpmu = !!(xcphysinfo.capabilities & XEN_SYSCTL_PHYSCAP_vpmu);
 
     GC_FREE;
     return 0;
diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_types.idl
index 3f9fff653a..993e83acca 100644
--- a/tools/libs/light/libxl_types.idl
+++ b/tools/libs/light/libxl_types.idl
@@ -1061,6 +1061,7 @@ libxl_physinfo = Struct("physinfo", [
     ("cap_shadow", bool),
     ("cap_iommu_hap_pt_share", bool),
     ("cap_vmtrace", bool),
+    ("cap_vpmu", bool),
     ], dir=DIR_OUT)
 
 libxl_connectorinfo = Struct("connectorinfo", [
diff --git a/tools/ocaml/libs/xc/xenctrl.ml b/tools/ocaml/libs/xc/xenctrl.ml
index 7ed1c00e47..7a4030a192 100644
--- a/tools/ocaml/libs/xc/xenctrl.ml
+++ b/tools/ocaml/libs/xc/xenctrl.ml
@@ -122,6 +122,7 @@ type physinfo_cap_flag =
 	| CAP_Shadow
 	| CAP_IOMMU_HAP_PT_SHARE
 	| CAP_Vmtrace
+	| CAP_Vpmu
 
 type physinfo =
 {
diff --git a/tools/ocaml/libs/xc/xenctrl.mli b/tools/ocaml/libs/xc/xenctrl.mli
index 391d4abdf8..6900513e7f 100644
--- a/tools/ocaml/libs/xc/xenctrl.mli
+++ b/tools/ocaml/libs/xc/xenctrl.mli
@@ -107,6 +107,7 @@ type physinfo_cap_flag =
   | CAP_Shadow
   | CAP_IOMMU_HAP_PT_SHARE
   | CAP_Vmtrace
+  | CAP_Vpmu
 
 type physinfo = {
   threads_per_core : int;
diff --git a/tools/xl/xl_info.c b/tools/xl/xl_info.c
index 8383e4a6df..2c86b317b7 100644
--- a/tools/xl/xl_info.c
+++ b/tools/xl/xl_info.c
@@ -210,7 +210,7 @@ static void output_physinfo(void)
          info.hw_cap[4], info.hw_cap[5], info.hw_cap[6], info.hw_cap[7]
         );
 
-    maybe_printf("virt_caps              :%s%s%s%s%s%s%s%s\n",
+    maybe_printf("virt_caps              :%s%s%s%s%s%s%s%s%s\n",
          info.cap_pv ? " pv" : "",
          info.cap_hvm ? " hvm" : "",
          info.cap_hvm && info.cap_hvm_directio ? " hvm_directio" : "",
@@ -218,7 +218,8 @@ static void output_physinfo(void)
          info.cap_hap ? " hap" : "",
          info.cap_shadow ? " shadow" : "",
          info.cap_iommu_hap_pt_share ? " iommu_hap_pt_share" : "",
-         info.cap_vmtrace ? " vmtrace" : ""
+         info.cap_vmtrace ? " vmtrace" : "",
+         info.cap_vpmu ? " vpmu" : ""
         );
 
     vinfo = libxl_get_version_info(ctx);
diff --git a/xen/common/domain.c b/xen/common/domain.c
index 40d67ec342..262b6c0c3c 100644
--- a/xen/common/domain.c
+++ b/xen/common/domain.c
@@ -84,6 +84,8 @@ vcpu_info_t dummy_vcpu_info;
 
 bool __read_mostly vmtrace_available;
 
+bool __read_mostly vpmu_is_available;
+
 static void __domain_finalise_shutdown(struct domain *d)
 {
     struct vcpu *v;
diff --git a/xen/common/sysctl.c b/xen/common/sysctl.c
index 3558641cd9..6e7189bb3c 100644
--- a/xen/common/sysctl.c
+++ b/xen/common/sysctl.c
@@ -280,6 +280,9 @@ long do_sysctl(XEN_GUEST_HANDLE_PARAM(xen_sysctl_t) u_sysctl)
         if ( vmtrace_available )
             pi->capabilities |= XEN_SYSCTL_PHYSCAP_vmtrace;
 
+        if ( vpmu_is_available )
+            pi->capabilities |= XEN_SYSCTL_PHYSCAP_vpmu;
+
         if ( copy_to_guest(u_sysctl, op, 1) )
             ret = -EFAULT;
     }
diff --git a/xen/include/public/sysctl.h b/xen/include/public/sysctl.h
index 039ccf885c..fead0e5b53 100644
--- a/xen/include/public/sysctl.h
+++ b/xen/include/public/sysctl.h
@@ -100,10 +100,12 @@ struct xen_sysctl_tbuf_op {
 #define _XEN_SYSCTL_PHYSCAP_iommu_hap_pt_share 5
 #define XEN_SYSCTL_PHYSCAP_iommu_hap_pt_share  \
     (1u << _XEN_SYSCTL_PHYSCAP_iommu_hap_pt_share)
-#define XEN_SYSCTL_PHYSCAP_vmtrace       (1 << 6)
+#define XEN_SYSCTL_PHYSCAP_vmtrace       (1u << 6)
+/* The platform supports vPMU. */
+#define XEN_SYSCTL_PHYSCAP_vpmu          (1u << 7)
 
 /* Max XEN_SYSCTL_PHYSCAP_* constant.  Used for ABI checking. */
-#define XEN_SYSCTL_PHYSCAP_MAX XEN_SYSCTL_PHYSCAP_vmtrace
+#define XEN_SYSCTL_PHYSCAP_MAX XEN_SYSCTL_PHYSCAP_vpmu
 
 struct xen_sysctl_physinfo {
     uint32_t threads_per_core;
diff --git a/xen/include/xen/domain.h b/xen/include/xen/domain.h
index 1708c36964..160c8dbdab 100644
--- a/xen/include/xen/domain.h
+++ b/xen/include/xen/domain.h
@@ -133,4 +133,6 @@ static inline void vnuma_destroy(struct vnuma_info *vnuma) { ASSERT(!vnuma); }
 
 extern bool vmtrace_available;
 
+extern bool vpmu_is_available;
+
 #endif /* __XEN_DOMAIN_H__ */
-- 
2.29.0



From xen-devel-bounces@lists.xenproject.org Mon Oct 11 09:01:10 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 09:01:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.205526.360863 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZrBG-0003D4-0k; Mon, 11 Oct 2021 09:01:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 205526.360863; Mon, 11 Oct 2021 09:01:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZrBF-0003Ct-Tu; Mon, 11 Oct 2021 09:01:09 +0000
Received: by outflank-mailman (input) for mailman id 205526;
 Mon, 11 Oct 2021 09:01:08 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Tf9x=O7=arm.com=michal.orzel@srs-us1.protection.inumbo.net>)
 id 1mZrBE-0002dD-CB
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 09:01:08 +0000
Received: from foss.arm.com (unknown [217.140.110.172])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTP
 id 673ef07a-bd79-459f-a938-92a355f24d98;
 Mon, 11 Oct 2021 09:01:06 +0000 (UTC)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id DAEBB11FB;
 Mon, 11 Oct 2021 02:01:05 -0700 (PDT)
Received: from e123311-lin.arm.com (unknown [10.57.19.78])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C94203F66F;
 Mon, 11 Oct 2021 02:01:04 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 673ef07a-bd79-459f-a938-92a355f24d98
From: Michal Orzel <michal.orzel@arm.com>
To: xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	bertrand.marquis@arm.com
Subject: [PATCH v4 2/3] xen/arm: Check for PMU platform support
Date: Mon, 11 Oct 2021 11:00:46 +0200
Message-Id: <20211011090047.8878-3-michal.orzel@arm.com>
X-Mailer: git-send-email 2.29.0
In-Reply-To: <20211011090047.8878-1-michal.orzel@arm.com>
References: <20211011090047.8878-1-michal.orzel@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

ID_AA64DFR0_EL1/ID_DFR0_EL1 registers provide
information about PMU support. Replace structure
dbg64/dbg32 with a union and fill in all the
register fields according to document:
ARM Architecture Registers(DDI 0595, 2021-06).

Add macros boot_dbg_feature64/boot_dbg_feature32
to check for a debug feature. Add macro
cpu_has_pmu to check for PMU support.

Signed-off-by: Michal Orzel <michal.orzel@arm.com>
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>
---
Changes since v3:
-none
Changes since v2:
-none
Changes since v1:
-new in v2
---
 xen/include/asm-arm/cpufeature.h | 49 ++++++++++++++++++++++++++++++--
 1 file changed, 47 insertions(+), 2 deletions(-)

diff --git a/xen/include/asm-arm/cpufeature.h b/xen/include/asm-arm/cpufeature.h
index 5ca09b0bff..4fce23844d 100644
--- a/xen/include/asm-arm/cpufeature.h
+++ b/xen/include/asm-arm/cpufeature.h
@@ -4,6 +4,7 @@
 #ifdef CONFIG_ARM_64
 #define cpu_feature64(c, feat)         ((c)->pfr64.feat)
 #define boot_cpu_feature64(feat)       (system_cpuinfo.pfr64.feat)
+#define boot_dbg_feature64(feat)       (system_cpuinfo.dbg64.feat)
 
 #define cpu_feature64_has_el0_32(c)    (cpu_feature64(c, el0) == 2)
 
@@ -22,6 +23,7 @@
 
 #define cpu_feature32(c, feat)         ((c)->pfr32.feat)
 #define boot_cpu_feature32(feat)       (system_cpuinfo.pfr32.feat)
+#define boot_dbg_feature32(feat)       (system_cpuinfo.dbg32.feat)
 
 #define cpu_has_arm       (boot_cpu_feature32(arm) == 1)
 #define cpu_has_thumb     (boot_cpu_feature32(thumb) >= 1)
@@ -32,8 +34,10 @@
 
 #ifdef CONFIG_ARM_32
 #define cpu_has_gentimer  (boot_cpu_feature32(gentimer) == 1)
+#define cpu_has_pmu       (boot_dbg_feature32(perfmon) >= 1)
 #else
 #define cpu_has_gentimer  (1)
+#define cpu_has_pmu       (boot_dbg_feature64(pmu_ver) >= 1)
 #endif
 #define cpu_has_security  (boot_cpu_feature32(security) > 0)
 
@@ -181,8 +185,28 @@ struct cpuinfo_arm {
         };
     } pfr64;
 
-    struct {
+    union {
         register_t bits[2];
+        struct {
+            /* DFR0 */
+            unsigned long debug_ver:4;
+            unsigned long trace_ver:4;
+            unsigned long pmu_ver:4;
+            unsigned long brps:4;
+            unsigned long __res0:4;
+            unsigned long wrps:4;
+            unsigned long __res1:4;
+            unsigned long ctx_cmps:4;
+            unsigned long pms_ver:4;
+            unsigned long double_lock:4;
+            unsigned long trace_filt:4;
+            unsigned long __res2:4;
+            unsigned long mtpmu:4;
+            unsigned long __res3:12;
+
+            /* DFR1 */
+            unsigned long __res4:64;
+        };
     } dbg64;
 
     struct {
@@ -321,8 +345,29 @@ struct cpuinfo_arm {
         };
     } pfr32;
 
-    struct {
+    union {
         register_t bits[2];
+        struct {
+            /* DFR0 */
+            unsigned long copdbg:4;
+            unsigned long copsdbg:4;
+            unsigned long mmapdbg:4;
+            unsigned long coptrc:4;
+            unsigned long mmaptrc:4;
+            unsigned long mprofdbg:4;
+            unsigned long perfmon:4;
+            unsigned long tracefilt:4;
+#ifdef CONFIG_ARM_64
+            unsigned long __res0:32;
+#endif
+
+            /* DFR1 */
+            unsigned long mtpmu:4;
+            unsigned long __res1:28;
+#ifdef CONFIG_ARM_64
+            unsigned long __res2:32;
+#endif
+        };
     } dbg32;
 
     struct {
-- 
2.29.0



From xen-devel-bounces@lists.xenproject.org Mon Oct 11 09:01:12 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 09:01:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.205527.360875 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZrBI-0003WL-BD; Mon, 11 Oct 2021 09:01:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 205527.360875; Mon, 11 Oct 2021 09:01:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZrBI-0003WA-6y; Mon, 11 Oct 2021 09:01:12 +0000
Received: by outflank-mailman (input) for mailman id 205527;
 Mon, 11 Oct 2021 09:01:11 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Tf9x=O7=arm.com=michal.orzel@srs-us1.protection.inumbo.net>)
 id 1mZrBH-0002uG-JT
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 09:01:11 +0000
Received: from foss.arm.com (unknown [217.140.110.172])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTP
 id c681921e-2a71-11ec-80d2-12813bfff9fa;
 Mon, 11 Oct 2021 09:01:09 +0000 (UTC)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E595F1FB;
 Mon, 11 Oct 2021 02:01:08 -0700 (PDT)
Received: from e123311-lin.arm.com (unknown [10.57.19.78])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 346643F66F;
 Mon, 11 Oct 2021 02:01:06 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c681921e-2a71-11ec-80d2-12813bfff9fa
From: Michal Orzel <michal.orzel@arm.com>
To: xen-devel@lists.xenproject.org
Cc: Ian Jackson <iwj@xenproject.org>,
	Wei Liu <wl@xen.org>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Nick Rosbrook <rosbrookn@ainfosec.com>,
	Anthony PERARD <anthony.perard@citrix.com>,
	Juergen Gross <jgross@suse.com>,
	Christian Lindig <christian.lindig@citrix.com>,
	David Scott <dave@recoil.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	bertrand.marquis@arm.com
Subject: [PATCH v4 3/3] xen: Expose the PMU to the guests
Date: Mon, 11 Oct 2021 11:00:47 +0200
Message-Id: <20211011090047.8878-4-michal.orzel@arm.com>
X-Mailer: git-send-email 2.29.0
In-Reply-To: <20211011090047.8878-1-michal.orzel@arm.com>
References: <20211011090047.8878-1-michal.orzel@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Add parameter vpmu to xl domain configuration syntax
to enable the access to PMU registers by disabling
the PMU traps(currently only for ARM).

The current status is that the PMU registers are not
virtualized and the physical registers are directly
accessible when this parameter is enabled. There is no
interrupt support and Xen will not save/restore the
register values on context switches.

Please note that this feature is experimental.

Signed-off-by: Michal Orzel <michal.orzel@arm.com>
Signed-off-by: Julien Grall <julien@xen.org>
Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>
---
Changes since v3:
-fail if vpmu is set but not supported
-rebase on top of latest staging
Changes since v2:
-remove redundant check from x86 code
-do not define bit position and mask separately
Changes since v1:
-modify vpmu parameter to be common rather than arch specific
---
 docs/man/xl.cfg.5.pod.in             | 17 +++++++++++++++++
 tools/golang/xenlight/helpers.gen.go |  6 ++++++
 tools/golang/xenlight/types.gen.go   |  1 +
 tools/include/libxl.h                |  6 ++++++
 tools/libs/light/libxl_create.c      | 10 ++++++++++
 tools/libs/light/libxl_types.idl     |  2 ++
 tools/ocaml/libs/xc/xenctrl.ml       |  1 +
 tools/ocaml/libs/xc/xenctrl.mli      |  1 +
 tools/xl/xl_parse.c                  |  2 ++
 xen/arch/arm/domain.c                | 12 +++++++++---
 xen/arch/arm/setup.c                 |  1 +
 xen/common/domain.c                  | 10 +++++++++-
 xen/include/asm-arm/domain.h         |  1 +
 xen/include/public/domctl.h          |  4 +++-
 14 files changed, 69 insertions(+), 5 deletions(-)

diff --git a/docs/man/xl.cfg.5.pod.in b/docs/man/xl.cfg.5.pod.in
index 4b1e3028d2..55c4881205 100644
--- a/docs/man/xl.cfg.5.pod.in
+++ b/docs/man/xl.cfg.5.pod.in
@@ -690,6 +690,23 @@ default.
 B<NOTE>: Acceptable values are platform specific.  For Intel Processor
 Trace, this value must be a power of 2 between 4k and 16M.
 
+=item B<vpmu=BOOLEAN>
+
+Currently ARM only.
+
+Specifies whether to enable the access to PMU registers by disabling
+the PMU traps.
+
+The PMU registers are not virtualized and the physical registers are directly
+accessible when this parameter is enabled. There is no interrupt support and
+Xen will not save/restore the register values on context switches.
+
+vPMU, by design and purpose, exposes system level performance
+information to the guest. Only to be used by sufficiently privileged
+domains. This feature is currently in experimental state.
+
+If this option is not specified then it will default to B<false>.
+
 =back
 
 =head2 Devices
diff --git a/tools/golang/xenlight/helpers.gen.go b/tools/golang/xenlight/helpers.gen.go
index c8669837d8..2449580bad 100644
--- a/tools/golang/xenlight/helpers.gen.go
+++ b/tools/golang/xenlight/helpers.gen.go
@@ -1119,6 +1119,9 @@ return fmt.Errorf("converting field ArchX86.MsrRelaxed: %v", err)
 }
 x.Altp2M = Altp2MMode(xc.altp2m)
 x.VmtraceBufKb = int(xc.vmtrace_buf_kb)
+if err := x.Vpmu.fromC(&xc.vpmu);err != nil {
+return fmt.Errorf("converting field Vpmu: %v", err)
+}
 
  return nil}
 
@@ -1600,6 +1603,9 @@ return fmt.Errorf("converting field ArchX86.MsrRelaxed: %v", err)
 }
 xc.altp2m = C.libxl_altp2m_mode(x.Altp2M)
 xc.vmtrace_buf_kb = C.int(x.VmtraceBufKb)
+if err := x.Vpmu.toC(&xc.vpmu); err != nil {
+return fmt.Errorf("converting field Vpmu: %v", err)
+}
 
  return nil
  }
diff --git a/tools/golang/xenlight/types.gen.go b/tools/golang/xenlight/types.gen.go
index 45f2cba3d2..b2e8bd1a85 100644
--- a/tools/golang/xenlight/types.gen.go
+++ b/tools/golang/xenlight/types.gen.go
@@ -521,6 +521,7 @@ MsrRelaxed Defbool
 }
 Altp2M Altp2MMode
 VmtraceBufKb int
+Vpmu Defbool
 }
 
 type DomainBuildInfoTypeUnion interface {
diff --git a/tools/include/libxl.h b/tools/include/libxl.h
index ec5e3badae..ee73eb06f1 100644
--- a/tools/include/libxl.h
+++ b/tools/include/libxl.h
@@ -508,6 +508,12 @@
  */
 #define LIBXL_HAVE_PHYSINFO_CAP_VPMU 1
 
+/*
+ * LIBXL_HAVE_VPMU indicates that libxl_domain_build_info has a vpmu parameter,
+ * which allows to enable the access to PMU registers.
+ */
+#define LIBXL_HAVE_VPMU 1
+
 /*
  * libxl ABI compatibility
  *
diff --git a/tools/libs/light/libxl_create.c b/tools/libs/light/libxl_create.c
index e356b2106d..2a0234ec16 100644
--- a/tools/libs/light/libxl_create.c
+++ b/tools/libs/light/libxl_create.c
@@ -91,6 +91,7 @@ int libxl__domain_build_info_setdefault(libxl__gc *gc,
     }
 
     libxl_defbool_setdefault(&b_info->device_model_stubdomain, false);
+    libxl_defbool_setdefault(&b_info->vpmu, false);
 
     if (libxl_defbool_val(b_info->device_model_stubdomain) &&
         !b_info->device_model_ssidref)
@@ -622,6 +623,9 @@ int libxl__domain_make(libxl__gc *gc, libxl_domain_config *d_config,
                 create.flags |= XEN_DOMCTL_CDF_nested_virt;
         }
 
+        if ( libxl_defbool_val(b_info->vpmu) )
+            create.flags |= XEN_DOMCTL_CDF_vpmu;
+
         assert(info->passthrough != LIBXL_PASSTHROUGH_DEFAULT);
         LOG(DETAIL, "passthrough: %s",
             libxl_passthrough_to_string(info->passthrough));
@@ -1199,6 +1203,12 @@ int libxl__domain_config_setdefault(libxl__gc *gc,
         goto error_out;
     }
 
+    if (libxl_defbool_val(d_config->b_info.vpmu) && !physinfo.cap_vpmu) {
+        ret = ERROR_INVAL;
+        LOGD(ERROR, domid, "vpmu not supported on this platform\n");
+        goto error_out;
+    }
+
     ret = 0;
  error_out:
     return ret;
diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_types.idl
index 993e83acca..b96fb5c47e 100644
--- a/tools/libs/light/libxl_types.idl
+++ b/tools/libs/light/libxl_types.idl
@@ -655,6 +655,8 @@ libxl_domain_build_info = Struct("domain_build_info",[
     # Use zero value to disable this feature.
     ("vmtrace_buf_kb", integer),
 
+    ("vpmu", libxl_defbool),
+
     ], dir=DIR_IN,
        copy_deprecated_fn="libxl__domain_build_info_copy_deprecated",
 )
diff --git a/tools/ocaml/libs/xc/xenctrl.ml b/tools/ocaml/libs/xc/xenctrl.ml
index 7a4030a192..86758babb3 100644
--- a/tools/ocaml/libs/xc/xenctrl.ml
+++ b/tools/ocaml/libs/xc/xenctrl.ml
@@ -70,6 +70,7 @@ type domain_create_flag =
 	| CDF_IOMMU
 	| CDF_NESTED_VIRT
 	| CDF_VPCI
+	| CDF_VPMU
 
 type domain_create_iommu_opts =
 	| IOMMU_NO_SHAREPT
diff --git a/tools/ocaml/libs/xc/xenctrl.mli b/tools/ocaml/libs/xc/xenctrl.mli
index 6900513e7f..0fdb0cc169 100644
--- a/tools/ocaml/libs/xc/xenctrl.mli
+++ b/tools/ocaml/libs/xc/xenctrl.mli
@@ -63,6 +63,7 @@ type domain_create_flag =
   | CDF_IOMMU
   | CDF_NESTED_VIRT
   | CDF_VPCI
+  | CDF_VPMU
 
 type domain_create_iommu_opts =
   | IOMMU_NO_SHAREPT
diff --git a/tools/xl/xl_parse.c b/tools/xl/xl_parse.c
index 17dddb4cd5..c503b9be00 100644
--- a/tools/xl/xl_parse.c
+++ b/tools/xl/xl_parse.c
@@ -2750,6 +2750,8 @@ skip_usbdev:
                     "If it fixes an issue you are having please report to "
                     "xen-devel@lists.xenproject.org.\n");
 
+    xlu_cfg_get_defbool(config, "vpmu", &b_info->vpmu, 0);
+
     xlu_cfg_destroy(config);
 }
 
diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
index aae4472479..2f988c790e 100644
--- a/xen/arch/arm/domain.c
+++ b/xen/arch/arm/domain.c
@@ -276,6 +276,8 @@ static void ctxt_switch_to(struct vcpu *n)
      * timer. The interrupt needs to be injected into the guest. */
     WRITE_SYSREG(n->arch.cntkctl, CNTKCTL_EL1);
     virt_timer_restore(n);
+
+    WRITE_SYSREG(n->arch.mdcr_el2, MDCR_EL2);
 }
 
 /* Update per-VCPU guest runstate shared memory area (if registered). */
@@ -586,6 +588,10 @@ int arch_vcpu_create(struct vcpu *v)
 
     v->arch.hcr_el2 = get_default_hcr_flags();
 
+    v->arch.mdcr_el2 = HDCR_TDRA | HDCR_TDOSA | HDCR_TDA;
+    if ( !(v->domain->options & XEN_DOMCTL_CDF_vpmu) )
+        v->arch.mdcr_el2 |= HDCR_TPM | HDCR_TPMCR;
+
     if ( (rc = vcpu_vgic_init(v)) != 0 )
         goto fail;
 
@@ -622,9 +628,9 @@ int arch_sanitise_domain_config(struct xen_domctl_createdomain *config)
 {
     unsigned int max_vcpus;
 
-    /* HVM and HAP must be set. IOMMU and VPCI may or may not be */
-    if ( (config->flags & ~XEN_DOMCTL_CDF_iommu & ~XEN_DOMCTL_CDF_vpci) !=
-         (XEN_DOMCTL_CDF_hvm | XEN_DOMCTL_CDF_hap) )
+    /* HVM and HAP must be set. IOMMU, VPCI and VPMU may or may not be */
+    if ( (config->flags & ~(XEN_DOMCTL_CDF_iommu | XEN_DOMCTL_CDF_vpci |
+          XEN_DOMCTL_CDF_vpmu)) != (XEN_DOMCTL_CDF_hvm | XEN_DOMCTL_CDF_hap) )
     {
         dprintk(XENLOG_INFO, "Unsupported configuration %#x\n",
                 config->flags);
diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c
index 49dc90d198..85386a765a 100644
--- a/xen/arch/arm/setup.c
+++ b/xen/arch/arm/setup.c
@@ -108,6 +108,7 @@ static void __init processor_id(void)
 
     identify_cpu(c);
     current_cpu_data = *c;
+    vpmu_is_available = cpu_has_pmu;
 
     if ( c->midr.implementer < ARRAY_SIZE(processor_implementers) &&
          processor_implementers[c->midr.implementer] )
diff --git a/xen/common/domain.c b/xen/common/domain.c
index 262b6c0c3c..8543fb54fd 100644
--- a/xen/common/domain.c
+++ b/xen/common/domain.c
@@ -480,12 +480,14 @@ static int sanitise_domain_config(struct xen_domctl_createdomain *config)
     bool hvm = config->flags & XEN_DOMCTL_CDF_hvm;
     bool hap = config->flags & XEN_DOMCTL_CDF_hap;
     bool iommu = config->flags & XEN_DOMCTL_CDF_iommu;
+    bool vpmu = config->flags & XEN_DOMCTL_CDF_vpmu;
 
     if ( config->flags &
          ~(XEN_DOMCTL_CDF_hvm | XEN_DOMCTL_CDF_hap |
            XEN_DOMCTL_CDF_s3_integrity | XEN_DOMCTL_CDF_oos_off |
            XEN_DOMCTL_CDF_xs_domain | XEN_DOMCTL_CDF_iommu |
-           XEN_DOMCTL_CDF_nested_virt | XEN_DOMCTL_CDF_vpci) )
+           XEN_DOMCTL_CDF_nested_virt | XEN_DOMCTL_CDF_vpci |
+           XEN_DOMCTL_CDF_vpmu) )
     {
         dprintk(XENLOG_INFO, "Unknown CDF flags %#x\n", config->flags);
         return -EINVAL;
@@ -534,6 +536,12 @@ static int sanitise_domain_config(struct xen_domctl_createdomain *config)
         return -EINVAL;
     }
 
+    if ( vpmu && !vpmu_is_available )
+    {
+        dprintk(XENLOG_INFO, "vpmu requested but cannot be enabled this way\n");
+        return -EINVAL;
+    }
+
     return arch_sanitise_domain_config(config);
 }
 
diff --git a/xen/include/asm-arm/domain.h b/xen/include/asm-arm/domain.h
index c9277b5c6d..14e575288f 100644
--- a/xen/include/asm-arm/domain.h
+++ b/xen/include/asm-arm/domain.h
@@ -166,6 +166,7 @@ struct arch_vcpu
 
     /* HYP configuration */
     register_t hcr_el2;
+    register_t mdcr_el2;
 
     uint32_t teecr, teehbr; /* ThumbEE, 32-bit guests only */
 #ifdef CONFIG_ARM_32
diff --git a/xen/include/public/domctl.h b/xen/include/public/domctl.h
index 4cb3f662c2..a53cbd16f4 100644
--- a/xen/include/public/domctl.h
+++ b/xen/include/public/domctl.h
@@ -71,9 +71,11 @@ struct xen_domctl_createdomain {
 #define _XEN_DOMCTL_CDF_nested_virt   6
 #define XEN_DOMCTL_CDF_nested_virt    (1U << _XEN_DOMCTL_CDF_nested_virt)
 #define XEN_DOMCTL_CDF_vpci           (1U << 7)
+/* Should we expose the vPMU to the guest? */
+#define XEN_DOMCTL_CDF_vpmu           (1U << 8)
 
 /* Max XEN_DOMCTL_CDF_* constant.  Used for ABI checking. */
-#define XEN_DOMCTL_CDF_MAX XEN_DOMCTL_CDF_vpci
+#define XEN_DOMCTL_CDF_MAX XEN_DOMCTL_CDF_vpmu
 
     uint32_t flags;
 
-- 
2.29.0



From xen-devel-bounces@lists.xenproject.org Mon Oct 11 09:06:24 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 09:06:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.205553.360885 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZrGG-00058W-VI; Mon, 11 Oct 2021 09:06:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 205553.360885; Mon, 11 Oct 2021 09:06:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZrGG-00058P-SQ; Mon, 11 Oct 2021 09:06:20 +0000
Received: by outflank-mailman (input) for mailman id 205553;
 Mon, 11 Oct 2021 09:06:20 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mZrGG-00058F-4a; Mon, 11 Oct 2021 09:06:20 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mZrGF-0001Ha-Lj; Mon, 11 Oct 2021 09:06:19 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mZrGF-0001l0-6I; Mon, 11 Oct 2021 09:06:19 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mZrGF-0005yD-5q; Mon, 11 Oct 2021 09:06:19 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=wn1sWZx5ZP5v+OlleWDa0B86cRPUrCNBvmbJ7O9bESU=; b=PnFxxDMNW8DMrb8Bs9Pg153esW
	zLWkfwrIe7v2oEEGawqVaRtQ1+/d6C5S4n88hyjuITp7AHj5+nsrDF23+rWuTfjGUmTvEe3VvmOjO
	SmZtzxmlEPc+LrZIR61Uq6l7Ugvv4aaEBu/++K2fz5plDr7WAo/1QJCmIGS/cLMyhVqI=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165459-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 165459: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable
    linux-linus:test-amd64-amd64-examine:memdisk-try-append:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=64570fbc14f8d7cb3fe3995f20e26bc25ce4b2cc
X-Osstest-Versions-That:
    linux=7fd2bf83d59a2d32e0d596c5d3e623b9a0e7e2d5
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 11 Oct 2021 09:06:19 +0000

flight 165459 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165459/

Failures :-/ but no regressions.

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds    18 guest-start/debian.repeat fail REGR. vs. 165457

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-examine      4 memdisk-try-append           fail  like 165450
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 165457
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 165457
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165457
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165457
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 165457
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165457
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 165457
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 165457
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 linux                64570fbc14f8d7cb3fe3995f20e26bc25ce4b2cc
baseline version:
 linux                7fd2bf83d59a2d32e0d596c5d3e623b9a0e7e2d5

Last test of basis   165457  2021-10-10 13:17:03 Z    0 days
Testing same since   165459  2021-10-11 01:11:38 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Alexey Kardashevskiy <aik@ozlabs.ru>
  Borislav Petkov <bp@suse.de>
  Christophe Leroy <christophe.leroy@csgroup.eu>
  Cédric Le Goater <clg@kaod.org>
  Jakub Kicinski <kuba@kernel.org>
  James Morse <james.morse@arm.com>
  Joe Lawrence <joe.lawrence@redhat.com>
  Johan Almbladh <johan.almbladh@anyfinetworks.com>
  Josh Poimboeuf <jpoimboe@redhat.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Lukas Bulwahn <lukas.bulwahn@gmail.com>
  Mahesh Salgaonkar <mahesh@linux.ibm.com>
  Michael Ellerman <mpe@ellerman.id.au>
  Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com>
  Nicholas Piggin <npiggin@gmail.com>
  Reinette Chatre <reinette.chatre@intel.com>
  Ser Olmy <ser.olmy@protonmail.com>
  Song Liu <songliubraving@fb.com>
  Thomas Gleixner <tglx@linutronix.de>
  Tom Lendacky <thomas.lendacky@amd.com>
  Vegard Nossum <vegard.nossum@oracle.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   7fd2bf83d59a2..64570fbc14f8d  64570fbc14f8d7cb3fe3995f20e26bc25ce4b2cc -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Mon Oct 11 09:25:07 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 09:25:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.205569.360912 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZrYC-0007fi-Ri; Mon, 11 Oct 2021 09:24:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 205569.360912; Mon, 11 Oct 2021 09:24:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZrYC-0007fb-N0; Mon, 11 Oct 2021 09:24:52 +0000
Received: by outflank-mailman (input) for mailman id 205569;
 Mon, 11 Oct 2021 09:24:51 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mZrYB-0007fV-OL
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 09:24:51 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mZrY9-0001bU-2x; Mon, 11 Oct 2021 09:24:49 +0000
Received: from 54-240-197-238.amazon.com ([54.240.197.238]
 helo=[192.168.17.141]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mZrY8-0006vh-SA; Mon, 11 Oct 2021 09:24:49 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=tiD73+zFhx9HEa6ct08nchW05Eha72SmOGHTNdR7MzI=; b=Wjo7gii/Ku3QLODHOf3LhJCIJZ
	cNu+RuYKsnlFFcRX4S0iJE/8rf8pXtTqDCzRghxZQyHGGZm227cDUxQ+mV9Jdp64BDIUDhEADaWcN
	15gu6nRL/nkZ4/BMNERJOTc/TctusUbZKUz6jz/fO/bMXq4HKpnLIFJIZX7DShgt6I6Q=;
Message-ID: <d3794451-63c6-cba0-fcbf-d76b124aca29@xen.org>
Date: Mon, 11 Oct 2021 10:24:44 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.2.0
Subject: Re: [PATCH v5 07/11] xen/domctl: Introduce XEN_DOMCTL_CDF_vpci flag
To: Stefano Stabellini <sstabellini@kernel.org>,
 Julien Grall <julien.grall.oss@gmail.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 Rahul Singh <rahul.singh@arm.com>, xen-devel
 <xen-devel@lists.xenproject.org>, Bertrand Marquis
 <bertrand.marquis@arm.com>, Andre Przywara <Andre.Przywara@arm.com>,
 Christian Lindig <christian.lindig@citrix.com>, David Scott
 <dave@recoil.org>, Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <cover.1633540842.git.rahul.singh@arm.com>
 <20d5b9d6a0d01a7b90711d28cbefb5701a88b438.1633540842.git.rahul.singh@arm.com>
 <548fa153-b2e3-7f91-c7c9-a569e13b5809@citrix.com>
 <CAJ=z9a2kYdYB9fSXX8NhLk90px03z8+D-YE5AQKW9uABx9kvrQ@mail.gmail.com>
 <alpine.DEB.2.21.2110081433110.25528@sstabellini-ThinkPad-T480s>
From: Julien Grall <julien@xen.org>
In-Reply-To: <alpine.DEB.2.21.2110081433110.25528@sstabellini-ThinkPad-T480s>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi Stefano,

On 08/10/2021 22:46, Stefano Stabellini wrote:
> On Fri, 8 Oct 2021, Julien Grall wrote:
>> Hi Andrew,
>>
>> On Fri, 8 Oct 2021, 20:07 Andrew Cooper, <andrew.cooper3@citrix.com> wrote:
>>        On 06/10/2021 18:40, Rahul Singh wrote:
>>        > Introduce XEN_DOMCTL_CDF_vpci flag to enable VPCI support in XEN.
>>        > Reject the use of this new flag for x86 as VPCI is not supported for
>>        > DOMU guests for x86.
>>        >
>>        > Signed-off-by: Rahul Singh <rahul.singh@arm.com>
>>        > Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
>>        > Acked-by: Christian Lindig <christian.lindig@citrix.com>
>>
>>        I'm afraid this logic is broken.
>>
>>        There's no matching feature to indicate to the toolstack whether
>>        XEN_DOMCTL_CDF_vpci will be accepted or not.  The usual way of doing
>>        this is with a physinfo_cap field.
>>
>>
>> I am slightly puzzled by this. I am assuming you are referring to XENVER_get_features which AFAICT is a stable interface. So why should we
>> use it to describe the presence of an unstable interface?
>>
>>
>>        This flag needs using in Patch 10 to reject attempts to create a VM with
>>        devices when passthrough support is unavailable.
>>
>>
>> May I ask why we can't rely on the hypervisor to reject the flag when suitable?
>>
>>
>>        Ian, for the 4.16 release, this series either needs completing with the
>>        additional flag implemented, or this patch needs reverting to avoid us
>>        shipping a broken interface.
>>
>>
>> I fail to see how the interface would be broken... Would you mind to describe a bit more what could go wrong with this interface?
> 
> 
> After chatting with Andrew on IRC, this is my understanding.
> 
> Today if pci=[] is specified in the VM config file then
> XEN_DOMCTL_CDF_vpci is added. If Xen doesn't support it, Xen returns
> an error but libxl/xl won't be able to tell exactly why it fails. So xl
> will end up printing a generic VM creation failure. Andrew would like to
> see something like the following in libxl:
> 
> if ( PCI_devices && !cap.vcpi )
>      error("Sorry - PCI not supported")
> 
> So that the user gets a clear informative error back rather than a
> generic VM creation failure. 

I can understand this request. However...

Also, this is a requirement for the stable
> hypercall interface.

... leaving aside the fact that domctl is clearly not stable today, the 
flag would be rejected on hypervisor not supporting vPCI. So I don't 
really see how this is a requirement for the stable hypercall interface.

Would you mind providing more details?

> 
> 
> I think that's fine and we can implement this request easily by adding
> XEN_SYSCTL_PHYSCAP_vpci. Rahul or Bertrand, are you guys happy with
> doing that? Otherwise I could take it on.
> 
> 
> As a side note, given that PCI passthrough support is actually not yet
> complete on ARM, we could even just do the following in xl/libxl:
> 
> if ( PCI_devices )
>      error("Sorry - PCI not supported")
> 
> or temporarily remove XEN_DOMCTL_CDF_vpci until PCI passthrough gets
> finalized.

Cheers,


> 

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Mon Oct 11 09:27:58 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 09:27:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.205577.360922 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZrbC-0008K0-8K; Mon, 11 Oct 2021 09:27:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 205577.360922; Mon, 11 Oct 2021 09:27:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZrbC-0008Jt-5H; Mon, 11 Oct 2021 09:27:58 +0000
Received: by outflank-mailman (input) for mailman id 205577;
 Mon, 11 Oct 2021 09:27:56 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=pkLr=O7=citrix.com=roger.pau@srs-us1.protection.inumbo.net>)
 id 1mZrbA-0008Jn-NF
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 09:27:56 +0000
Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 83a50788-2a75-11ec-80d2-12813bfff9fa;
 Mon, 11 Oct 2021 09:27:55 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 83a50788-2a75-11ec-80d2-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1633944475;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=Nhj/9AQhuHyYoJKw232vgX+Cae7CgjeZ5eEe36J1kyI=;
  b=e/kWqiURck0DxhX3d90Q0Ii/iM10bxkDGuKXn/j/THpcFGl8bfhKvwNW
   w12CVKrJypDohxI8fWKHrOegwIS3Q/mnhSqCKFR5zI9QPqV5POKWi9UIK
   xhMeZ5stTVbjGwTX3LHwmQgRuBav6Kw2TexKCzXYbykqm1PHl0ggm1YdY
   I=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: mXnozezTyWv+DfILVbzqTgn1sy9O41k5aOxcWI+eadU8oM1m13WW1NR2HPtZlCNBzhpatpBZjY
 UvsUZpq9KiXEIpQiqGqho0nxD4OeE6dUrDuV6RUB4MzaNpP8mPLcVJAy4rnbSK+U2Vmm/5P7b+
 RXNjBZCCjn7XNAFrmUIsZwPf9tK+32x15xt8D1raVGWdvdFYre8tLhM44uPDTZZL0sMtXvAZ/Z
 8LhrGKzuVuz6e5tZA14tw1zop7Bg9AM7fVfojFEdKTiT3NWZ6rvnwL1rt94qPnVvjEKhPADTwz
 fguc8MsywMV2+k7T+8KZi9lC
X-SBRS: 5.1
X-MesageID: 54891922
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:cz786KkqmOTe8uL3xgQqKmLo5gyKIERdPkR7XQ2eYbSJt1+Wr1Gzt
 xIeUTrXPqnYYmShKNknOdm28EoP757dm9c3HAI4q30zRSMWpZLJC+rCIxarNUt+DCFioGGLT
 Sk6QoOdRCzhZiaE/n9BClVlxJVF/fngqoDUUYYoAQgsA185IMsdoUg7wbdg2tcx2YHR7z6l4
 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc
 s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4
 MUUio7oTS4VArbFpPoAEAFyOH5QOKITrdcrIVDn2SCS50jPcn+qyPRyFkAme4Yf/46bA0kXq
 6ZecmpUKEne2aTmm9pXScE17ignBNPsM44F/Glp0BnSDOo8QICFSKLPjTNd9Gps1pEXTKyED
 yYfQQJjfiWdXTlNAwxUA74Rs+3zxVnYfCIN/Tp5ooJoujOOnWSdyoPFMtDYZ9iLTsV9hVuDq
 yTN+GGRKg4eHMySz3yC6H3Eru3SmSL2XqoCGbv+8eRl6HWtwWgUBAwTREGMi/CzgU6jWPpSM
 0URvCEpqMAa71e3R9PwWxm5pn+svRMGXddUVeog52mly7XWyxaUAHAeSTxMY8Bgs9U5LRQ62
 1nMk973CDhHtLyOVWnb5rqStSm1OyUeMSkFfyBsZREM48Tn5poyiB3PZt95Fei+ididMTv92
 SyQpS4ywbAal9cW1r6T9ErCxTmro/DhQgcr6y3NU2mi7wc/Y5SqD6SB71TB4LB4NpSIUVCbt
 VANgc3Y5+cLZaxhjwTUHr9LRuvwoa/YbnuM2jaDAqXN6Ry9okGxJYR53A1lLXt3L4UcUxS2T
 krc7FY5CIBoAFOmaqp+YoSUAssszLT9GdmNas04fuaicbAqK1fZpHAGiVq4mjm3yhB1wP5X1
 YKzKJ70VR4n5bJbIC1argv3+YQgwTwi3ivtTJT/wgXPPVG2NSPNF+lt3LdjaIkEAEK4TOf9r
 4Y32yiikUw3vAjCjs//q9N7wbcidylTOHwOg5YLHtNv2yI/cI3bN9ffwKk6Z6tulLlPm+HD8
 xmVAxEDkwqu3SKecFnUMRiPjY8Du74k9xrX2gR2bD6VN4ULO97zvM/zibNmFVXYyACT5aEtF
 KRUEylxKv9OVi7G61wggWrV9+RfmOCQrVvWZUKNOWFnF7Y5HlCh0oK0L2PHqXhVZgLq5JRWn
 lFV/l6CKXb1b185V5i+hTPG5w7ZgEXxb8orBxGWfYIJJBm1mGWoQgSo5sIKzwg3AUyr7hOR1
 hqMAAdeou/IooQv98LOi7zCpICse9aS1GIDd4UCxbrpZyTc4ES5xopMDLSBcTzHDTum86S+f
 +RFifr7NaRfzlpNtoN9FZdtzL4/uISz9+MLkFw8ESWZdUmvB5NhPmKCgZtFuJpSy+ILogCxQ
 E+OpIVXYO3bJMP/HVcNDwM5deDfh+oMkzzf4K1tckX37SN65pSdVkBWM0XegSBRNuItYogk3
 f0gqIgd7Anm0kgmNdOPjyZ18WWQLyNfD/V7589CWIKy01gl0FBPZ5DYGxTa2pDXZoUeKFQuL
 x+VmLHG2+ZWyH3dfidhDnPKx+dc28gD4UgY0F8YKl2VsdPZnftrjgZJ+DE6QwkJnBVK1+V/Z
 jpiO0FvfPjc+j5pgI5IXny2GhEHDxqcoxSjx1wMnWzfbk+pSm2SczFtZbfTpBgUozBGYzxW3
 LCE02K0Az/lcfb40jY2RUM4+efoSsZ891Galc2qdyhf80LWvdYxbneSWFc1
IronPort-HdrOrdr: A9a23:TwT7n6AoyQ4zDyjlHeg3sceALOsnbusQ8zAXPh9KJiC9I/b1qy
 nxppkmPH/P6Qr4WBkb6Le90Y27MAnhHP9OkPIs1NKZMjUO11HYTr2KgbGSpgEIXheOi9K1tp
 0QDZSWaueAdGSS5PySiGLTc6dCsai6GeKT9J/jJh9WPH5XgspbnmFE42igYylLrF4sP+tEKH
 PQ3LsMmxOQPVAsKuirDHgMWObO4/XNiZLdeBYDQzoq8hOHgz+E4KPzV0Hw5GZTbxp/hZMZtU
 TVmQ3w4auu99m91x/nzmfWq7BbgsHoxNdvDNGFzuIVNjLvoAC1Y5kJYczOgBkF5MWUrHo6mt
 jFpBkte+x19nPqZ2mw5SDg3gHxuQxeokPK+Bu9uz/OsMb5TDU1B45qnoRCaCbU7EImoZVVzL
 9L93jxjesXMTrw2ADGo/TYXRBjkUS55VA4l/QIsnBZWYwCLJdMsI0k+l9PGptoJlO11GkeKp
 gsMCjg3ocVTbvDBEqp+1WHgebcEUjbJy32AnTr4aeuonxrdHMQ9Tpv+CVQpAZGyHqRI6M0kt
 gsCZ4Y542mePVmGp6VNN1xMfdfNVa9My4kEFjiaWgPR5t3cE4klfbMkcEIDaeRCdo18Kc=
X-IronPort-AV: E=Sophos;i="5.85,364,1624334400"; 
   d="scan'208";a="54891922"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Ct/Ri8oX2ouVMKcOo+dGyhQO8m6CQbOHszG+fBs5Bl126SEOcQn2/8bgdKAB6NE2rqeCYv7Mz9l6oP0Uils/I2vVo8De5N47ChRkZTncUvi1WmorSbXxM8ibsc1ouOsi7d8F8yvP2BWcHJlWVf6akYnQDXD/t1GoX58JV8WBd7fC7SsMrsjuBGFtwlJfPRbX9aQslhl5qi08PbQCmsAbo2r07RXhD9qrc+r6QyIFIl9S1IL+nL/WPdC3hIbL0O0V4xgxGuqabxLcOy5jRleIqDX/FokDtH1S4icU4BkkTCZkUhezplQbLPKHbMZqe6/Smy3PXofZ+AKc2phZ5px3ug==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Nhj/9AQhuHyYoJKw232vgX+Cae7CgjeZ5eEe36J1kyI=;
 b=Gr1F/dOvB5ma6UTPNWlADO9cHK3bWWUHA4wCOcMS4s0s60F/3P59G0wyXLCmdav+7SRJ1jRXRzVuvT+4nWlA6QcJhzeElLQ4dpvIfx/Zf9vxkv2AkDzuAk+ykrN6JOaGHWQ/LMXQw9comQTplE8EWOGEZn0ZKAWotL2rDxUOWyiNq4Vt7AIT33D8oUM9atm0bYCQxPdHBVwYwMm5yRO1z+Gha4nWFIz62Tgj0weinHvDwlJdPsJdEQ2qzmKhv7RTuBDHHcsm8HEKnlLJGCZw3QgUMcY826LxquWpFxSi4mBGKbQglMDRzuETkUchtWFWr9Zed08cpDFJxzHJao4RDQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Nhj/9AQhuHyYoJKw232vgX+Cae7CgjeZ5eEe36J1kyI=;
 b=YZDjQWKP62zWdpc1i2th2F7vN117yAZjq4x6sK5Vch/TUAp03UmF0DwAOlHnKrpjLJvDXZcW1wZL+EfD3ZjI68/dFRQfhQY83m43hoIY5r4pfaCbD0WzlP/LmkD/vdgN735BpFlYKN8l2RJd34FoLhQWmj2766cEA3bcY+MpmtI=
Date: Mon, 11 Oct 2021 11:27:30 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Rahul Singh <rahul.singh@arm.com>
CC: <xen-devel@lists.xenproject.org>, <bertrand.marquis@arm.com>,
	<Andre.Przywara@arm.com>, Christian Lindig <christian.lindig@citrix.com>,
	David Scott <dave@recoil.org>, Ian Jackson <iwj@xenproject.org>, Wei Liu
	<wl@xen.org>, Andrew Cooper <andrew.cooper3@citrix.com>, George Dunlap
	<george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>, Julien Grall
	<julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>, Volodymyr
 Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH v5 07/11] xen/domctl: Introduce XEN_DOMCTL_CDF_vpci flag
Message-ID: <YWQDguvmf/O4rDIs@MacBook-Air-de-Roger.local>
References: <cover.1633540842.git.rahul.singh@arm.com>
 <20d5b9d6a0d01a7b90711d28cbefb5701a88b438.1633540842.git.rahul.singh@arm.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20d5b9d6a0d01a7b90711d28cbefb5701a88b438.1633540842.git.rahul.singh@arm.com>
X-ClientProxiedBy: LO4P123CA0491.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:1ab::10) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 6b362b2d-d6c7-42c4-cd2e-08d98c995c2f
X-MS-TrafficTypeDiagnostic: DM5PR03MB2635:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <DM5PR03MB26351E99E085AD5FC77346E38FB59@DM5PR03MB2635.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: jOHsX8gowVjFeErjg37i5ORKgryZXzJzXhqPwuPj4act0p2j6XR6aHh6qwpiONhcopVIoFQuV+paEFyYVZ4R45MXAytb7IKj44fkrpKaBci3or9bbTDJhX6owP6veupKUSuGB74W1JRW5FfoX1nERUbvhxOoOv7l3RQrK/ALiCHawVCLS0o7TX11uP1Pf6VrvZYlpkGC7OB+hZW3wMjKK9/DyxPAaRn7uGJKYpLvZ08hLAYG5SnlTuMG3jkotVh73zA3mkvbrugY9XYX/nls7DmqGvniGjbm4HVFQzaIqEoBzOIISo1fWpA879qxpCZS+h31s8kAlObJ1ZlIlbsCvjsbTnybyg58BkxoGlunbSJ8OvTu4YSvIl+sfoQHQFdMXZmIAJ1NC923A87GytVTcJPo0S6lDzT/kKWkYWZgapycyIy14miEQxIRiHQzq2jmg96I5Lr7Gap8DKNlBVge8LTH+/qH8gO5Qg/6foaYdz8ewFNP4641IS1yymt59j8BgWjifrkpVpYtePQzajuPIlJWDIJxbw4VSrWs5hQNsvQnN/GUFTYjhqmA6Cdu4Vr6LCqlVol/O546mZWRVY3R2UhmdLsB10vtcO5bkaI+DocsF482bmdvnYNtec92mq4FbJ0o17JoVwsI/9eDlyoKwA==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(8676002)(6666004)(956004)(38100700002)(4326008)(5660300002)(316002)(9686003)(508600001)(54906003)(26005)(6486002)(4744005)(85182001)(7416002)(6916009)(2906002)(186003)(66476007)(6496006)(66556008)(8936002)(66946007)(86362001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TDBsK3d1dUhuNFZTMEswODBTNW9zTHdvNGc5cUxiQ0VETTJYc3R1ZS9Wejlj?=
 =?utf-8?B?NEF1UEliY3VzUmE0TjhNOW9ZOFkwaElSaVczbEVUakhVVGRrWFFTVis4NHRF?=
 =?utf-8?B?cWtQa3A0NkM4SEhvVXN1aFNjbEdxL3NKVEFWVlhYZTA3bzBIS2VuTjNPL3dn?=
 =?utf-8?B?cVdkaWtpVENJc2NEa3c0dEdVVXA4NTVZR3pWY241elZHN1M5WEpsVnkyOXhi?=
 =?utf-8?B?TnlMa0EyREhidjl0eGVVaTFYVzBQYjJFN0NPNGxtR3RvcVVZUW5HV3RaTjZT?=
 =?utf-8?B?b01aYjZEV3AzU05NSVVjVWk1dk1YUHpkazZlNmZRUE55VTBJTk5oU3YzSkZp?=
 =?utf-8?B?QTBBb3J2dUlMTzg2aThMR0xvY1EvUnkvZnl4ZWI5d1M0OVY3UnF5MjdUUVJj?=
 =?utf-8?B?bVM1ZmdYekZLWTJqZFl1R3pqU1ZmWkF3Mk84eGZyalp3Y2RQWjlIclVKTEx4?=
 =?utf-8?B?MWVqUEVrSHdWZkVMNWc5cmxDUFA2SitoTVRKdG1RbGo4WHhHMFVXbUFWMFRm?=
 =?utf-8?B?bXRWeEk3YkVVY1BhRHo3ei9JTEQ4VkQ2ajBWdmFEVzNBT1ExVDk3ZG8yb3Ru?=
 =?utf-8?B?NmhXczEza2lqYzVGeWdyTWlxM0V0T0lUV05LOTVHdFF0WFF0Q1lWNFJlbzRW?=
 =?utf-8?B?RXVoYXI4OE1sblkvV0dCcG45eUxzT1plVldreUFmZzJBVWJ5bER6K24xVzg2?=
 =?utf-8?B?eVc1Q1dZL0NjU1FwSGNOSTJoYmIrYnJFRG5HNEVlellNUVB5YkZydkFGQVFC?=
 =?utf-8?B?UEdMYzdtcnZPTk1tck9wKzd0ZTh0TGQrYVloQlJlM2p6QVdyKy8xYzl5aTRG?=
 =?utf-8?B?aERrYlV2ZHNsbXZIN3JMOVZTclpRUUJpYUpJdTZiZWZwRTNrZ2lOaUVqV0lH?=
 =?utf-8?B?VTkxa3RSeTBJS3UxbXlWSUNqejFDRjd1ZUpRQlA1bFZWK2MzQXR5OEhyY0k3?=
 =?utf-8?B?UWptdTU3Y2VlTjNxY2R6MjVjMzRoYzN3OEZhTmx0ZGtaSXNlc2k1UlQwUnVR?=
 =?utf-8?B?czlJYUdqVDlOM2NzTTlOSStjd1BaUmtLdmppTDRVUjdKaTVLUUFidmpCV3Bu?=
 =?utf-8?B?TFBOeDdUMkx3YUVZWGF6alZlL0hYTUMyc2RxdmpJMFo1WTI4cGJsZjQxTVZm?=
 =?utf-8?B?ZDBJVGxpSytJTXZTR20xOWhKbFRGc1JYbm1KTXpFZ1A3R1k4S3E0eGpyYmlE?=
 =?utf-8?B?RTdEZEJuQWFjWlJLWUJYYVp2WEFjMHZIRUxBVTBnZUw5NVlLa3ZYVGlFdFBX?=
 =?utf-8?B?eWJiUDBBamFzNUJnUVpicGF5OGh2Z1EzdlByR1hKZmhuZ0tQTGxQbnRjdmRN?=
 =?utf-8?B?aE9TcmhlVnY0dEZ1dkVydCtpb1lyV1NKUmhMTjltUTMxcTV6K0tZY3ViOU9u?=
 =?utf-8?B?S1o4a2ZKckt2UWpJazB5Q3ZOaEF3dlREZHpxblFKVGtYUC9peHUvdGVLNzRy?=
 =?utf-8?B?RVlaWWs1ZitWMUdNdE5STTNiMml5czZPd1hsNWFZbHMrcEFkcFpvcE41bXdX?=
 =?utf-8?B?Ulkxc0o0ZWpyNExyTEFrUWlKekZiQmx2SGhxQkFnU2JZeHJlV0w3S0VYNXZS?=
 =?utf-8?B?T0VEb1FSV2ZRNlRRbVdZVllCZlcvekNMNHNSMXZrVUhGd09vWU9Ib3dsZ0tR?=
 =?utf-8?B?UkVhMFpZSVFwTjlEdy9ET0NNdU1rcGI3bVFkRWVYZ0ZKbTdHbXg3SkR2d0Mz?=
 =?utf-8?B?ZCtCTEo2a3BhYVRaOFh2ck41elB0Yzh1bmxIa2E1YjcrNitSTUJwYlZuS2Ex?=
 =?utf-8?Q?ABMbli8qNCOPGVFxUljI/yGbWHucCsCI8iK+huk?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 6b362b2d-d6c7-42c4-cd2e-08d98c995c2f
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2021 09:27:35.6158
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: BdrTsL/9qNQkI9f+f1WxOm0Ogik9TYpQskGNMwZicERhgf3GT9aPUZBDdFx6OGtw9Rg1lTeThAHDqHF9qthKlQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB2635
X-OriginatorOrg: citrix.com

On Wed, Oct 06, 2021 at 06:40:33PM +0100, Rahul Singh wrote:
> Introduce XEN_DOMCTL_CDF_vpci flag to enable VPCI support in XEN.
> Reject the use of this new flag for x86 as VPCI is not supported for
> DOMU guests for x86.

I don't like this approach, XEN_DOMCTL_CDF_vpci should be set for x86
PVH dom0, like we do for any other CDF flags when Xen builds dom0.

Things like PVH vs PV get translated into CDF flags by create_dom0,
and processed normally by the sanitise_domain_config logic, vPCI
should be handled that way.

Do you think you could see about fixing this?

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Mon Oct 11 09:31:39 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 09:31:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.205585.360934 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZreh-0001K1-OR; Mon, 11 Oct 2021 09:31:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 205585.360934; Mon, 11 Oct 2021 09:31:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZreh-0001Ju-LS; Mon, 11 Oct 2021 09:31:35 +0000
Received: by outflank-mailman (input) for mailman id 205585;
 Mon, 11 Oct 2021 09:31:34 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mZreg-0001Jo-H8
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 09:31:34 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mZreg-0001kF-EH
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 09:31:34 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mZreg-0007Qq-DD
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 09:31:34 +0000
Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89)
 (envelope-from <iwj@xenproject.org>)
 id 1mZrec-0000bi-Kx; Mon, 11 Oct 2021 10:31:30 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date
	:Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From;
	bh=LCEE4Kq9JCbxBO61BV8+TG13UiFDXQBp/HiMEDmUvZw=; b=smYtYZxawfwkDTxtO+y4sAwhiW
	UZzEMAJhy6Xg4fljWAUFudVk/9js3Qr4lHfnxNwlyMdU/n27kuyKs67yFxq/luyC4aJYxg3qEkSEP
	qXSLXADOWzaugEwz4B7KJJbfePUIkOvu0ltfEbFjrfXV3CCMolWGQNeEOXp2CdECN1o8=;
From: Ian Jackson <iwj@xenproject.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <24932.1138.187067.478819@mariner.uk.xensource.com>
Date: Mon, 11 Oct 2021 10:31:30 +0100
To: Juergen Gross <jgross@suse.com>
Cc: xen-devel@lists.xenproject.org,
    Wei Liu <wl@xen.org>
Subject: Re: [PATCH v5 2/2] tools/xenstore: set open file descriptor limit for
 xenstored
In-Reply-To: <3c9bfe5d-c471-c771-d6a7-a15cca466cb6@suse.com>
References: <20210928091517.9761-1-jgross@suse.com>
	<20210928091517.9761-3-jgross@suse.com>
	<24915.1121.8356.288414@mariner.uk.xensource.com>
	<0bd81ff3-a7ac-4000-4c0c-d7127b1c1985@suse.com>
	<24915.13356.139165.259646@mariner.uk.xensource.com>
	<3c9bfe5d-c471-c771-d6a7-a15cca466cb6@suse.com>
X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu)

Juergen Gross writes ("Re: [PATCH v5 2/2] tools/xenstore: set open file descriptor limit for xenstored"):
> On 28.09.21 17:26, Ian Jackson wrote:
> > Juergen Gross writes ("Re: [PATCH v5 2/2] tools/xenstore: set open file descriptor limit for xenstored"):
> >> Hmm, maybe I should just use:
> >>
> >> prlimit --nofile=$XENSTORED_MAX_OPEN_FDS \
> >>      $XENSTORED --pid-file @XEN_RUN_DIR@/xenstored.pid $XENSTORED_ARGS
> > 
> > I guess that would probably work (although it involves another
> > exec) but I don't understand what's wrong with ulimit, which is a
> > shell builtin.
> 
> My main concern with ulimit is that this would set the open file limit
> for _all_ children of the script. I don't think right now this is a real
> problem, but it feels wrong to me (systemd-notify ought to be fine, but
> you never know ...).

Oh, I see.  Yes, that is a good point.

So, I think your suggest (quoted above) is good.

Thanks,
Ian.


From xen-devel-bounces@lists.xenproject.org Mon Oct 11 09:35:56 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 09:35:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.205594.360945 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZris-0001xR-9X; Mon, 11 Oct 2021 09:35:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 205594.360945; Mon, 11 Oct 2021 09:35:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZris-0001xK-6Y; Mon, 11 Oct 2021 09:35:54 +0000
Received: by outflank-mailman (input) for mailman id 205594;
 Mon, 11 Oct 2021 09:35:53 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=wT4x=O7=kernel.org=maz@srs-us1.protection.inumbo.net>)
 id 1mZrir-0001xE-6n
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 09:35:53 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 8ae48876-bea5-4a1a-87d3-da769682f03e;
 Mon, 11 Oct 2021 09:35:52 +0000 (UTC)
Received: from disco-boy.misterjones.org (disco-boy.misterjones.org
 [51.254.78.96])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by mail.kernel.org (Postfix) with ESMTPSA id 7730860E8B;
 Mon, 11 Oct 2021 09:35:51 +0000 (UTC)
Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org)
 by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2)
 (envelope-from <maz@kernel.org>)
 id 1mZrin-00FyQD-Cg; Mon, 11 Oct 2021 10:35:49 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8ae48876-bea5-4a1a-87d3-da769682f03e
Date: Mon, 11 Oct 2021 10:35:48 +0100
Message-ID: <87wnmjq4y3.wl-maz@kernel.org>
From: Marc Zyngier <maz@kernel.org>
To: Sean Christopherson <seanjc@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Will Deacon <will@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Guo Ren <guoren@kernel.org>,
	Nick Hu <nickhu@andestech.com>,
	Greentime Hu <green.hu@gmail.com>,
	Vincent Chen <deanbo422@gmail.com>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@redhat.com>,
	Namhyung Kim <namhyung@kernel.org>,
	James Morse <james.morse@arm.com>,
	Alexandru Elisei <alexandru.elisei@arm.com>,
	Suzuki K Poulose <suzuki.poulose@arm.com>,
	Vitaly Kuznetsov <vkuznets@redhat.com>,
	Wanpeng Li <wanpengli@tencent.com>,
	Jim Mattson <jmattson@google.com>,
	Joerg Roedel <joro@8bytes.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-perf-users@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	kvmarm@lists.cs.columbia.edu,
	linux-csky@vger.kernel.org,
	linux-riscv@lists.infradead.org,
	kvm@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	Artem Kashkanov <artem.kashkanov@intel.com>,
	Like Xu <like.xu.linux@gmail.com>,
	Zhu Lingshan <lingshan.zhu@intel.com>
Subject: Re: [PATCH v3 12/16] KVM: Move x86's perf guest info callbacks to generic KVM
In-Reply-To: <20210922000533.713300-13-seanjc@google.com>
References: <20210922000533.713300-1-seanjc@google.com>
	<20210922000533.713300-13-seanjc@google.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue)
 FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1
 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
X-SA-Exim-Connect-IP: 185.219.108.64
X-SA-Exim-Rcpt-To: seanjc@google.com, peterz@infradead.org, mingo@redhat.com, acme@kernel.org, will@kernel.org, mark.rutland@arm.com, guoren@kernel.org, nickhu@andestech.com, green.hu@gmail.com, deanbo422@gmail.com, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, pbonzini@redhat.com, boris.ostrovsky@oracle.com, jgross@suse.com, alexander.shishkin@linux.intel.com, jolsa@redhat.com, namhyung@kernel.org, james.morse@arm.com, alexandru.elisei@arm.com, suzuki.poulose@arm.com, vkuznets@redhat.com, wanpengli@tencent.com, jmattson@google.com, joro@8bytes.org, sstabellini@kernel.org, linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, kvmarm@lists.cs.columbia.edu, linux-csky@vger.kernel.org, linux-riscv@lists.infradead.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, artem.kashkanov@intel.com, like.xu.linux@gmail.com, lingshan.zhu@intel.com
X-SA-Exim-Mail-From: maz@kernel.org
X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false

On Wed, 22 Sep 2021 01:05:29 +0100,
Sean Christopherson <seanjc@google.com> wrote:
> 
> Move x86's perf guest callbacks into common KVM, as they are semantically
> identical to arm64's callbacks (the only other such KVM callbacks).
> arm64 will convert to the common versions in a future patch.
> 
> Implement the necessary arm64 arch hooks now to avoid having to provide
> stubs or a temporary #define (from x86) to avoid arm64 compilation errors
> when CONFIG_GUEST_PERF_EVENTS=y.
> 
> Signed-off-by: Sean Christopherson <seanjc@google.com>
> ---
>  arch/arm64/include/asm/kvm_host.h |  8 +++++
>  arch/arm64/kvm/arm.c              |  5 +++
>  arch/x86/include/asm/kvm_host.h   |  3 ++
>  arch/x86/kvm/x86.c                | 53 +++++++------------------------
>  include/linux/kvm_host.h          | 10 ++++++
>  virt/kvm/kvm_main.c               | 44 +++++++++++++++++++++++++
>  6 files changed, 81 insertions(+), 42 deletions(-)
> 
> diff --git a/arch/arm64/include/asm/kvm_host.h b/arch/arm64/include/asm/kvm_host.h
> index ed940aec89e0..828b6eaa2c56 100644
> --- a/arch/arm64/include/asm/kvm_host.h
> +++ b/arch/arm64/include/asm/kvm_host.h
> @@ -673,6 +673,14 @@ int io_mem_abort(struct kvm_vcpu *vcpu, phys_addr_t fault_ipa);
>  void kvm_perf_init(void);
>  void kvm_perf_teardown(void);
>  
> +#ifdef CONFIG_GUEST_PERF_EVENTS
> +static inline bool kvm_arch_pmi_in_guest(struct kvm_vcpu *vcpu)

Pardon my x86 ignorance, what is PMI? PMU Interrupt?

> +{
> +	/* Any callback while a vCPU is loaded is considered to be in guest. */
> +	return !!vcpu;
> +}
> +#endif

Do you really need this #ifdef?

> +
>  long kvm_hypercall_pv_features(struct kvm_vcpu *vcpu);
>  gpa_t kvm_init_stolen_time(struct kvm_vcpu *vcpu);
>  void kvm_update_stolen_time(struct kvm_vcpu *vcpu);
> diff --git a/arch/arm64/kvm/arm.c b/arch/arm64/kvm/arm.c
> index e9a2b8f27792..2b542fdc237e 100644
> --- a/arch/arm64/kvm/arm.c
> +++ b/arch/arm64/kvm/arm.c
> @@ -500,6 +500,11 @@ bool kvm_arch_vcpu_in_kernel(struct kvm_vcpu *vcpu)
>  	return vcpu_mode_priv(vcpu);
>  }
>  
> +unsigned long kvm_arch_vcpu_get_ip(struct kvm_vcpu *vcpu)
> +{
> +	return *vcpu_pc(vcpu);
> +}
> +
>  /* Just ensure a guest exit from a particular CPU */
>  static void exit_vm_noop(void *info)
>  {

The above nits notwithstanding,

Acked-by: Marc Zyngier <maz@kernel.org>

	M.

-- 
Without deviation from the norm, progress is not possible.


From xen-devel-bounces@lists.xenproject.org Mon Oct 11 09:36:43 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 09:36:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.205599.360955 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZrjc-0002Xh-JM; Mon, 11 Oct 2021 09:36:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 205599.360955; Mon, 11 Oct 2021 09:36:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZrjc-0002Xa-G1; Mon, 11 Oct 2021 09:36:40 +0000
Received: by outflank-mailman (input) for mailman id 205599;
 Mon, 11 Oct 2021 09:36:39 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=pkLr=O7=citrix.com=roger.pau@srs-us1.protection.inumbo.net>)
 id 1mZrjb-0002XM-Af
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 09:36:39 +0000
Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id bb36f369-2a76-11ec-80d2-12813bfff9fa;
 Mon, 11 Oct 2021 09:36:38 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: bb36f369-2a76-11ec-80d2-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1633944998;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=8oYnSQASnE692X/4zab7SEyteYJXwkCKrqzyWv9SmVc=;
  b=L+ykvX+VgGnUwTbzUgGyXkfExQkHGHJqdYX8uJqs4+ZjcHFCOizTQ50I
   Zk2Q6re8gsX0aYdauveIH3DitpH10MdPDjwLxUnwMILz1BsKu893Pv7Fn
   bGkzzN+N9bvCW6VNT6G3nCrq/bRu7z6QXH0yNVMc9OhhSIGORg+Rj7m6q
   o=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: rYCD38Q+h/qYXvJp8YeMfRp4yaVAzHAsNU8i8ZKBezsLcrowyxyicontAu9rJMoWab4WsBdHZB
 srMEdRfZhSmGwDjD+UGXj7VrhxE4T69G83jSnoWUAN4aioYLcEB7IfINiaCqSgPo+64J4ZmxxJ
 ZZvy30ysePmLb3LlZ7vJtSw8+xkV6TGl4hIg4QWgssFtneGZPn8vux/BbsdmCuBsU8PTI78ukl
 q8B4KzD9Dpq12wujtueRiNHebE3ZwPJC9Vmcb7JXwcTiDbmRSfKmrDfQx/5FBwK41uH/fdFEgR
 nYHTs4/HWBS3aoBzEKFKHcI1
X-SBRS: 5.1
X-MesageID: 54892491
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:P4KL86qPtk2P+spdIQEF6dkp1cJeBmJFYxIvgKrLsJaIsI4StFCzt
 garIBmBaPaPZWH1ft1zaNm38RwDuceGxtBhTgc9qSgxFyMR9ZuZCYyVIHmrMnLJJKUvbq7GA
 +byyDXkBJppJpMJjk71atANlZT4vE2xbuKU5NTsY0idfic5Dnd84f5fs7Rh2Ncx2YHgW1rlV
 e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL
 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9
 DlCncXgFSQofZHDo6M6aDVbKgxRGY5Iw6CSdBBTseTLp6HHW37lwvEoB0AqJ4wIvO1wBAmi9
 9RBdmpLNErawbvrnvTrEYGAhex6RCXvFJkYtXx6iynQEN4tQIzZQrWM7thdtNs1rp0STaeEO
 5tAAdZpRCbxPToUA2dONJIVubuIuHagTBdShk3A8MLb5ECMlVcsgdABKuH9eNOQQt5Otl2Fv
 W+A9GP8ajkBL8CWwzeB9nOqh8fMkDn9VYZUE6e3ntZUh1mUyn0WGQchf1KxqvmkiWazQ9tab
 UcT/0IGoaEs+WSxQ9L6Xhn+p2SL1jYeRt5RHusS+AyLjK3O7G6xB3cGZi5MbsQ8s807TiBs0
 UWG9/v5CDoqvLCLRHa18raPsSj0KSUTNXUFZyIPUU0C+daLiIM5gw/LT91jOLWoldCzEjb1q
 xiVqAAuirNVitQEv5hX5nie3Wjq/MKQCFdouEOHBQpJ8z+Veqb8N9CL6Bvn4s0HC721TWCsk
 1wnlfOBubVm4Y62qASBR+AEHbeM7vmDMSHBjVMHI6TN5whB6Fb4ItgOuGAWyFNBd59eI2ewM
 RC7VRZ5vccLZBOXgblLj5Vd4ijA5ZPrEsj5TbjqZ95Kb4kZmOSvrXw2OxD4M4wAliERfUAD1
 XWzLZbE4ZUyU/0PIN+KqwE1i+JDKscWnzK7eHwD5077uYdynVbMIVv/DHOAb/oi8ISPqxjP/
 tBUOqOikksEC72vOnaOqNJNdjjmyETX47it8aS7kcbZc2Jb9JwJUaeNkdvNhaQ090iqqgs41
 i7kARIJoLYOrXbGNR+LehhehEDHBv5CQYYAFXV0Zz6AgiF7Ca72tft3X8ZnLNEPqb04pdYpH
 qZtRil1KqkWItgx029GNseVQU0LXEnDuD9iyAL8OGJhIMU6G1CQkjImFyO2nBQz4uOMnZJWi
 5Wr1x/BQIpFQAJnDc3Mb+mowU/3tn8Y8N+elWOXSjWKUEmzooVsNQLrifo7f5MFJRnZn2PI3
 AeKGxYI4+LKptZtotXOgKmFqaavEvd/QRUGTzWKs+7uOHmI5HenzK9BTP2MIWLXWlTr9fjwf
 u5S1fz9bqEKxQ4Yr4pmHr935qsi/N+z9aRCxwFpESyTPVSmA79tOFec2sxLuvEfz7NVo1LuC
 EmO5sNbKfOCP8a8SAwdIw8sb+Ki0/AIm2aNsaRpcRuivCIupeiJS0RfORWImRdxFrotPdN32
 /olte4X9xe71kggPOGZg30G7G+LNHEBDfkq78lIHI/xhwM34VheepiAWDTu6ZSCZtgQYEknJ
 jiY2PjLi7hGnxeQdnMyET7G3PZHhIRIsxdPlQdQK1OMk9vDp/k2wBwOrmhnElULlk1Kg7BpJ
 2xmF0xpPqHfrT5nif9KU32oBwwcVgaS/Vb8ygdRmWDUJ6Vyurch8IHp1T6xwX0k
IronPort-HdrOrdr: A9a23:NBXfmqo2pBq6plvsnUaNk5caV5uwL9V00zEX/kB9WHVpm5Oj+P
 xGzc526farslsssREb+OxpOMG7MBThHLpOkPMs1NaZLXLbUQ6TQr2KgrGSoQEIdxeOk9K1kJ
 0QDpSWa+eAc2SS7/yKmTVQeuxIqLLskNHK9JbjJjVWPHlXgslbnnhE422gYytLrWd9dP4E/M
 323Ls6m9PsQwVcUu2LQl0+G8TTrdzCk5zrJTYAGh4c8QGLyRel8qTzHRS01goXF2on+8ZvzU
 H11yjCoomzufCyzRHRk0fV8pRtgdPkjv9OHtaFhMQ5IijlziyoeINicbufuy1dmpDj1H8a1P
 335zswNcV67H3cOkmzvBvWwgHllA0j7nfzoGXoyEfLkIjcfnYXGsBBjYVWfl/y8Ew7puxx16
 pNwiawq4dXJQmoplW92/H4EzVR0makq3srluAey1ZFV5EFVbNXpYsDuGtIDZY7Gj7g4oxPKp
 ghMCjl3ocUTbqmVQGagoE2q+bcG0jbXy32DXTqg/blkwS/xxtCvg8lLM92pAZ3yHtycegC2w
 xoWp4Y4Y2mdfVmHp6VMt1xNvdfOla9MS4kD1jiU2gPNJt3c04l+KSHq4nc2omRCeg1Jd0J6d
 L8bG8=
X-IronPort-AV: E=Sophos;i="5.85,364,1624334400"; 
   d="scan'208";a="54892491"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=IbWSV7XKBzXf6Idm3hG8ucN3ic5Mq/rcRRYVcikJVNVPrmDMzEZZtL94N30e1SLLRGSDWNppr//8jtcVkAzBjEqugdLOGO5iSjO9PiVxDR66uV2b+cn0Tzo1SPj05gKy+GvwyYx3JIQORA4necOb3b0md17D1RSgQqYvGlftxV6mVPec3Tcay3YDE4F9wawVqAPnBRR07Nm2YID6J5rcmFea0fktMuuMQwwU0c45otluS378MmGm8L3NyzsYOE5hj4PI5ZRae8eBkk9kQd8IIipUINysp1GEd5vzuxOgLf0z4D/+yJyk7vLNsRdzmpwmp1qF2TaYNykoEXSk3GOFaw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=CLTaF30ZkxvE+d+CBtqBT0O7KfyZLu145KDxRJ+XJkM=;
 b=JdJsHjYXvbFidH+T/oH4m+aijH/XhImsL5pt1Z0lmtetI4DbyAnrQXOr8ovzr/l9zHFSTi2CtXogbQlozjNm1mdA/ca/uqpH9r7EGjmEQDyxT/EFn8IcQZaGeWkrKpsKKPcMBNI2vxh9+Xs+tQ86rV3yVqKTqxD1OXLVa7CBtv6xC8IKSk0GglUapEmz+4H/9dICDoDtAe6TSur1nhjukDild4eRLvUByCwudrj1sciVtGkYKffJZxWvaFySeOd/J6NJgJSoJVzSB3j/habQQ1otoNK+GmYmfNbxrLR2mXdaixUsH44voEBS+19lZEwuUYt5V4jdUrHE9KJ+S/dvVw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=CLTaF30ZkxvE+d+CBtqBT0O7KfyZLu145KDxRJ+XJkM=;
 b=eFDkX+jyUGhPLlVO8sY0ap1XcPIqy2v1qrAFrFLzIfyIXr0DqYiK97hfQWoMt9JhfJVr4kdBrlruA+uvljH2GjlV1i3E1tJCEZOtGwQyqn0oqYTcS51VoI0Ah8HxXMtgsGUA5YnICSCHmMZAk0uFb+DobEL9FZud6E7LmqeffOw=
Date: Mon, 11 Oct 2021 11:36:15 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>, Andrew Cooper
	<andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>, Jan
 Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>, Stefano
 Stabellini <sstabellini@kernel.org>, Anthony PERARD
	<anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>, Christian
 Lindig <christian.lindig@citrix.com>, David Scott <dave@recoil.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH v2 0/6] gnttab: add per-domain controls
Message-ID: <YWQFj70MRWHEeOd8@MacBook-Air-de-Roger.local>
References: <20210922082123.54374-1-roger.pau@citrix.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20210922082123.54374-1-roger.pau@citrix.com>
X-ClientProxiedBy: LO3P265CA0014.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:bb::19) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 1672a772-477d-42ad-0124-08d98c9a951b
X-MS-TrafficTypeDiagnostic: DM6PR03MB3481:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <DM6PR03MB3481586151AB069E9113E2338FB59@DM6PR03MB3481.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: doSvl5BN1iFB48DRYPpl6uldCzFx0JtSU2Ue8k41SkL+bDHUK7yuAl0wa5d7Q4ydIBN3x/w6O5bWaEFmso9c6QbBkSIjl2NPJ736HEslahp9lKj4abuxoqTTwzVGyMHN7aexo0SH5RlQtQgjZci5hyLp407ArSHdJ9FMVUVzhp+TkTMw/cqIo/KzuVgD0g7RsxYe6l5Mat/TaZMY2ulbN2uJuTRdvp186rPlzWNrzDBd3ThqsJyP+e5Aam6WTOHt558FMFn/BDTeT033PXd3hoZi3/UUCoiqlC0X1s2DRRmO5vFL0ukyuLUfUNFp/VmahvUwcgOe7eKS8iHq07v5GBuewU4aztmFa9obo31Vmy0M3yCEvCCRR5lGAb+1kmY1X38yYUNTmxLOBl1e9jlRbsDK/4MU+S1V3yi/zkHy+VGy/GwotrIwX9sjMfjat6My2cXClKUyznt+HMvyacAKAkeiIQWQghgLLGVmJBU9KxynBFdRtZ24jEA4HGCj4mVer4NHBI7DZ+UkhofJz3P3TtpCobpRskVbMuSL6J28Z6bh0tlRlDs1SeH8yFAahAawLudvaB6zP3fmtG8w16TBlIayLfOhsvUXCFl/gTpKiouPqs70uWgUkgM6v2S7LrMGiUnu1GExRyQSoKXVPz1ZEw==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(8676002)(186003)(38100700002)(85182001)(9686003)(26005)(54906003)(86362001)(6496006)(6916009)(956004)(83380400001)(316002)(508600001)(6666004)(6486002)(4326008)(66556008)(66476007)(5660300002)(66946007)(8936002)(2906002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?b0FmVC9LTXBUQ0w4NVVIY1hXbFpZMGZ6VnpDL20rZlFRWWp3RkRXbHM1TVpN?=
 =?utf-8?B?S2VNc1NUNzlDdjU3Mm1UQ0RuUGdZYm9xL0FERE9vTUMyN3BUMWZBbFM4QTJI?=
 =?utf-8?B?eTNxMFdYUXJHMk5UTzhUQk9FcXdITXdQYXcxRnROZVlXZ2hvMlBPdUU0MXlo?=
 =?utf-8?B?bmIvZlE0R0tQYTlqUW56RWVZTUFXY1ZGTkYyU0tseC85VkhPbkxpVWxyQ1FH?=
 =?utf-8?B?aTFlZFRZZlU2aXdtZXVKc085S3NCUnZjTktGci81ZDlHV1d2elVkOVZCakZp?=
 =?utf-8?B?OFNZKzV0ZVZnSCsrMDB5ZXVEMVlSWlc5SDFIMlZaU3poQkJzZUpRazdzeUNN?=
 =?utf-8?B?QzBUSFJSeG9sL2lSRXAwTVdzQWN3Ni9BRkJKTVJ1b1lkTnEwOXFSL3RzUndq?=
 =?utf-8?B?NGEvaC85RklTcVRtRHFnODR4SHRSdCtocWRMY0pCaXhidkpmSTVTWFZHc1dt?=
 =?utf-8?B?MU5WWUlyaXAzZlNzVTNyd1VjSWt1WUtiQmZSSC84UWUrbDRpWXpNa0xRcDcv?=
 =?utf-8?B?aStSaXNDaVM1MXZxRWMraEJTMmw2RGJHRkNEYnBXMUtoblMxNE01bC9iVDNq?=
 =?utf-8?B?UkJxZVFzN1ZucnRPMGp4UHpqaG1icE1ZTDF3cUZFNDFiWm1pUVVEOHlLSnhH?=
 =?utf-8?B?MDJrRHFzaTRkZE93cXgraksyOE9TM3I1c2I5akFzYVk5c1dlblBUUTc3SURJ?=
 =?utf-8?B?RTN4eERsaVhYeUo4RFZIQjBJNzJqeXh3dkwzbHF0dTcyc3R2WlJQOFczSS9u?=
 =?utf-8?B?UkJhY1ZvUlE4MTJiZzlHTUdrTmEwYm85M1lRN3g1K2M3Qk9TaXZXSERZRWJw?=
 =?utf-8?B?U0MwbjA3WUJEZ1BOdW4xM3V5MDM5VEcxOHdMcmovZEVMK1ZkTUVxRjBaY3Z0?=
 =?utf-8?B?WDZ1UVJjbng0aXZ2Z1Vqc2xoNUFNMzJjWkFta0F5YmxWaEJJWVJPeHYvUjZH?=
 =?utf-8?B?RCtRWUNVaWZ1U2czb0o4VU45Y1BKUW01cjZzVDRxWFdtUWNYK1VjcS9DaTFY?=
 =?utf-8?B?VDJxQ0VINmNTSTdLekI1QllybTZabjNHUjluY0ZMKzZISzlaR2FIMzhNQlV6?=
 =?utf-8?B?RVdJbjJFU1BUT3NVRnlGK1FMbjVpY0hycTJqdloyWHI0bm5vUm1GQWY0aVZq?=
 =?utf-8?B?R2t0b0h6bWUrMTBGSm90TGNOL1hxVlZxY0huWGlqZmdWSDdWVzBmSld2ZXBV?=
 =?utf-8?B?M2FuWkIvRDZGVzdqZTE5RldvcEUyWUVodkdsQTJGS0g0Nm5GSHRWZ2RBeWlH?=
 =?utf-8?B?YTQ1d2dZOUh1UmVWL2dFMWpPRHRQZ1UyZDh4KzRIa2ZFMW9CY2gxOW9jV0RG?=
 =?utf-8?B?RDZtY2NCM2NPY2R1MVNTMHVoN0REeTFmcHJUVzNteVdvdWpaM09lSXVkcHhD?=
 =?utf-8?B?eG5mQ2tiV0tWS29TYXZPeDJXL0JNcDZhVWNraWJELytPVkZGMlNwTkFSd1pP?=
 =?utf-8?B?ZW5ya1NHNnIwS0tuS1F4eDBwMDQ3bEU0c252VVFWOEhEWTRacXJGMHJYcHVN?=
 =?utf-8?B?NWVkQjBCanN5Q0YzQW4zY0lkZEtMbVFBdFBzdnFEUzdINEYxcGVCL1N0Y3A5?=
 =?utf-8?B?eERTb2ttWTZpa1hoR3FmNGJINzNoVTJ3MWhnbDV0dC9hN1U0dldTeEwvQmxI?=
 =?utf-8?B?Y29TcHI3elhTajF4NlMxaWpGR2NBeDBLSTMwSEZNVzQyNVJDekUwVkZPeGYx?=
 =?utf-8?B?aEw4akNPUkhXdmxXR0dpZ3l5UnFLVk1WbEVpOUhYaW5LZ05GNHpnYks3WTJp?=
 =?utf-8?Q?tUMOBd/lmyWNEWH+bszQLjMOJVBHqKzkCTpkP6Y?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 1672a772-477d-42ad-0124-08d98c9a951b
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2021 09:36:20.6472
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: HMGmDvHWwfqBFJowZWWEMmVVwNFXQpDJXRssww9n1IkXzMdCKVnQQ4o4eGXz9MpTI2I/9kjGvLYnu0ny8r0u0g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB3481
X-OriginatorOrg: citrix.com

On Wed, Sep 22, 2021 at 10:21:17AM +0200, Roger Pau Monne wrote:
> Hello,
> 
> First patch on the series is a trivial change to xenconsoled in order to
> use xenforeignmemory stable library in order to map the shared console
> ring instead of the unstable libxc interface. It's reviewed and ready to
> go in.
> 
> Patches 2 and 3 allow setting the host wide command line `gnttab` option
> on a per domain basis. That means selecting the max allowed grant table
> version and whether transitive grants are allowed.
> 
> The last 3 patches attempt to implement support for creating guests
> without a grant table. This requires some changes to xenstored in order
> to partially support guests without a valid ring interface, as the lack
> of grant table will prevent C xenstored from mapping the shared ring.
> Note this is not an issue for Ocaml xenstored, as it still uses the
> foreign memory interface to map the shared ring, and thus won't notice
> the lack of grant table support on the domain.
> 
> Thanks, Roger.
> 
> Roger Pau Monne (6):
>   tools/console: use xenforeigmemory to map console ring
>   gnttab: allow setting max version per-domain
>   gnttab: allow per-domain control over transitive grants

Ping? The two patches above didn't get any review in either v1 or v2.

Patch #1 should be ready to go in AFAICT.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Mon Oct 11 09:38:00 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 09:38:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.205609.360966 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZrku-0003II-2M; Mon, 11 Oct 2021 09:38:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 205609.360966; Mon, 11 Oct 2021 09:38:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZrkt-0003IB-Vh; Mon, 11 Oct 2021 09:37:59 +0000
Received: by outflank-mailman (input) for mailman id 205609;
 Mon, 11 Oct 2021 09:37:57 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=LfEM=O7=arm.com=Bertrand.Marquis@srs-us1.protection.inumbo.net>)
 id 1mZrkr-0003I0-Ti
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 09:37:57 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com (unknown
 [40.107.7.79]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id e9f0f834-2a76-11ec-80d2-12813bfff9fa;
 Mon, 11 Oct 2021 09:37:56 +0000 (UTC)
Received: from DB6PR0501CA0033.eurprd05.prod.outlook.com (2603:10a6:4:67::19)
 by AM9PR08MB7118.eurprd08.prod.outlook.com (2603:10a6:20b:41e::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18; Mon, 11 Oct
 2021 09:37:55 +0000
Received: from DB5EUR03FT013.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:4:67:cafe::5e) by DB6PR0501CA0033.outlook.office365.com
 (2603:10a6:4:67::19) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.26 via Frontend
 Transport; Mon, 11 Oct 2021 09:37:54 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT013.mail.protection.outlook.com (10.152.20.105) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4587.18 via Frontend Transport; Mon, 11 Oct 2021 09:37:54 +0000
Received: ("Tessian outbound d5def7722ff7:v103");
 Mon, 11 Oct 2021 09:37:54 +0000
Received: from 2c61be027c83.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 650C7615-DBF3-45B8-B3B1-45BDA6967CCC.1; 
 Mon, 11 Oct 2021 09:37:48 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 2c61be027c83.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Mon, 11 Oct 2021 09:37:48 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com (2603:10a6:4:74::9)
 by DB6PR0802MB2311.eurprd08.prod.outlook.com (2603:10a6:4:87::22) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.20; Mon, 11 Oct
 2021 09:37:44 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955]) by DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955%4]) with mapi id 15.20.4587.026; Mon, 11 Oct 2021
 09:37:44 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e9f0f834-2a76-11ec-80d2-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=6ElrMXzpdlSNruvcRylv8x2LgXKxe7aDYpMZgWR9LEo=;
 b=UY3jEbfA8U+rp/vd4lGLDryBUHIB1HFHycl+0IgvomKZrlKX2xLxGs1PbwCQLqq8FMULeJhuRxwKd8VWTJ8Xk+8AVWGvetRsV5ubIwLcia/3B1xWyo2phBMHbgB036tJ4YK35gckTt7TEWJvAeoDSXGonVayQj1/PfyQZkHG84I=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: a6aad0bebcd9fb76
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=IIdgeYkYQo5v2RlbB0VvUP/cT3r/OkXlrufIzxP8kxZNJsozw6Snbhn2zW14nRYt2OIzFYs5kx+p7SpjyN3nwINImry3GyWhWAxIqXhIg9nIdtqOfnYy77mtcIxlp4Uh0I2Fic1IUdG6SM1ceZIkMO0wV4+cd17irfbhzFq2Jp5XrF05C0+VFEpwCCroU3NtamPvsry2XN8/LY7LeZ65jDlRnXvccUXaJzVZY/ZEgXcfbXxEn9dYC5x4p+Edxw37KH3zcbg8P2lBkqv/5zKxglFK+RbEnlJtUIQZP7haoaffE7XK8rYbof3diNU7hYvtkA+yqXXXlM1tOeO2LPMm6A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=6ElrMXzpdlSNruvcRylv8x2LgXKxe7aDYpMZgWR9LEo=;
 b=Az2OdAqoD5I8wAaGDNJqvxDfyoh6MkUBgf/3EH1pJlVrPVdwnofnBZm/5ZrXyRhfaLQY59tGlATgRhocb3gc+zwKF2m+TZKoLaUkBUs0aWQV4EQEk0ev3P4FJYNS0yD/0kIlU4FPE+XDdXHdS083IO4mM/7rqUG9YqF3lFKmgk9VGqfcj69wD9pLLrbJDkPeP4A/wG/feIFZkhLDLNO4uRF8E0zpASQbTntKUAMKrrs23zcy94U9Topr4s15K0UHSNJ8ahlBAYW4qq5i4O8AQjbJeRNOmg1uhBA96xJcUephWM3vO9WTiPTllZeivkzuntVogtrPMDzf7sT/6cjHGw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=6ElrMXzpdlSNruvcRylv8x2LgXKxe7aDYpMZgWR9LEo=;
 b=UY3jEbfA8U+rp/vd4lGLDryBUHIB1HFHycl+0IgvomKZrlKX2xLxGs1PbwCQLqq8FMULeJhuRxwKd8VWTJ8Xk+8AVWGvetRsV5ubIwLcia/3B1xWyo2phBMHbgB036tJ4YK35gckTt7TEWJvAeoDSXGonVayQj1/PfyQZkHG84I=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Luca Fancellu <Luca.Fancellu@arm.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Wei
 Chen <Wei.Chen@arm.com>, Stefano Stabellini <sstabellini@kernel.org>, Julien
 Grall <julien@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH] arm/efi: Fix null pointer dereference
Thread-Topic: [PATCH] arm/efi: Fix null pointer dereference
Thread-Index: AQHXvnWYcaBPG2QbfEGAFop12nzuY6vNilyA
Date: Mon, 11 Oct 2021 09:37:44 +0000
Message-ID: <3608432D-0D55-4373-B262-328A096C1388@arm.com>
References: <20211011075638.23785-1-luca.fancellu@arm.com>
In-Reply-To: <20211011075638.23785-1-luca.fancellu@arm.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3654.120.0.1.13)
Authentication-Results-Original: arm.com; dkim=none (message not signed)
 header.d=none;arm.com; dmarc=none action=none header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: 4b1768be-d0ee-403e-55c3-08d98c9acd56
x-ms-traffictypediagnostic: DB6PR0802MB2311:|AM9PR08MB7118:
x-ms-exchange-transport-forked: True
X-Microsoft-Antispam-PRVS:
	<AM9PR08MB7118C2581779412EDF152B4D9DB59@AM9PR08MB7118.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:514;OLM:514;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 cZq90CvRQZkaue0dhWicriE9Kku7dyGaY0W8RPTVxXlUpEow3XsDyWDo/OBPDqwKm11tvINupQwNSZ6EeWyQ+wBbYjHGYpgUFWbM1LuI6tsUTGu0rzeTATYZAMrUcQpgIAGWeqjyb94eAmhPKd1jCJA/alit0qqmTn5KG86xmSJxAc6dDwpV1oPs5txFLYGHKpDU55iUf5sKrrOjLx0v7cZyGcxvdx+mgu6hdDO1eWmVnVct3JLpUniUupyvNUmeL8Yk5y6Jh30s1Waps1L997F3Fv2fwnh1pgeH+q39WPe3ci/5M7Ap2MFXi3S2xi3oZbPdDlDF0QxCu0DPZ5xVgdtQNxgtrKO5pLOiggwuCwwdjZZEGGNVxq80WZIJLcNGo/c2GLgnwBS70jp+e97MTyI8pssuSu/q6+jFo7NGI+b7mw412NF9KPksrLd0YJhVsROWus1CurTJCeBMdC/7nvZ/2/MNLDtJM44+HxbL6oxQP/6ls9EksqOraZ7e4UTnrBrmzsBj4FWG9yftlWsEKAkvRC0uengkwwcATZkP0zATC5KAhAK7EYTTw5voInBaIKQRkdWh4mFkfeFZisPcAKX8w50LLVuD88t6qRD4klpqp4xGxy5VIMUN1BpxELLIfavNlZdGe7mRG6iOuUJbMoDV2vs+0RTIWEgOp9bcmBbQtq4nKteuqdCOcsQtF6lQkrLgkOXTGmm3wyMUN9EGdRzCsN/2F/qbsPNwDot6B35Ks+Y/d5v4irDBVQGk4TES
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB6PR0801MB2024.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(66946007)(8676002)(76116006)(186003)(54906003)(6636002)(66556008)(66446008)(38070700005)(6512007)(83380400001)(86362001)(37006003)(36756003)(91956017)(316002)(66476007)(508600001)(64756008)(26005)(4326008)(6506007)(38100700002)(5660300002)(122000001)(8936002)(6862004)(33656002)(53546011)(2906002)(2616005)(6486002)(71200400001)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="us-ascii"
Content-ID: <BDAE621BD4F087428C6E06E9215539E6@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0802MB2311
Original-Authentication-Results: arm.com; dkim=none (message not signed)
 header.d=none;arm.com; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT013.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	2520fc94-96ce-4478-a86e-08d98c9ac754
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	hx151nY22pK5CeqShQBtvRhapA1VrlVBll95RHkqCpNNSTcxwojck1O/ZM+5oX3tOlsBNot+GzCKHQKuNsi08I5FXoeKUtJ+XJ4qpqE5iwN7ofL0UNyUgl7Uh0ECkCQX8Sh7JW3gxeZkNC2tJqZBlB5O3lPknYYCUlKR+L83t0oEmGDvn3+HHxtzUqJqQScp191COF6q303Wl5D1kV8tJw7TAF//iaRdcCGk4CbtS/0SZVf2e71TquTPCvVNXhn6Ghs2xFoTYkU1QCA9njNdWGr4U3vONxnGvSGtCz2KTnf3Tyhe6qwY+aHts3jpUGUb0S7/vhUda+7K65H3ag3LMINMkzeMK/mi9unmrGOz2w1xEl4S5ax0WDpwCv0B4GbXPBODhhpIPDR366kCIc9kP9SIsOuE9RMHGhCLWvWBxfKDqcoygMs1T47TguxrEXpdn8WYVLH/sTJoymnMMMggZ8pCat4FkFJRfUHe2pyWUX6KEAgjQLIXFSgPWBneVo/Cm/+Cop2eFD68K/ZdOmaDY09k+wVOBtlpCuXmgCd2ufwHExFoMo7xzwkX+UylR5SapQP2EpU5RhoEy0wX9alc2XzLBG4u1a/TpOkhlkz6VfFg7GE3cdhwJgO4yIYg0qOha4rJvW7aQHVA92slr34u6Pa91fGtr4tWf+om1CIpjvObmSrTjxtHf1jT89mL6T+95Pm25a9ru/AlrR8lW8Hq5Q==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(107886003)(2616005)(356005)(5660300002)(8676002)(83380400001)(70586007)(6486002)(508600001)(36860700001)(186003)(37006003)(6636002)(26005)(70206006)(6862004)(2906002)(81166007)(47076005)(8936002)(4326008)(6506007)(36756003)(316002)(336012)(33656002)(86362001)(53546011)(54906003)(82310400003)(6512007);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2021 09:37:54.7405
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 4b1768be-d0ee-403e-55c3-08d98c9acd56
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT013.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB7118

Hi Luca,

> On 11 Oct 2021, at 08:56, Luca Fancellu <Luca.Fancellu@arm.com> wrote:
>=20
> Fix for commit 60649d443dc395243e74d2b3e05594ac0c43cfe3
> that introduces a null pointer dereference when the
> fdt_node_offset_by_compatible is called with "fdt"
> argument null.
>=20
> Reported-by: Julien Grall <julien@xen.org>
> Fixes: 60649d443d ("arm/efi: Introduce xen,uefi-cfg-load DT property")
> Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>
Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>

Cheers
Bertrand


> ---
> xen/arch/arm/efi/efi-boot.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>=20
> diff --git a/xen/arch/arm/efi/efi-boot.h b/xen/arch/arm/efi/efi-boot.h
> index a3e46453d4..e63dafac26 100644
> --- a/xen/arch/arm/efi/efi-boot.h
> +++ b/xen/arch/arm/efi/efi-boot.h
> @@ -593,7 +593,8 @@ static bool __init efi_arch_use_config_file(EFI_SYSTE=
M_TABLE *SystemTable)
>     dtbfile.ptr =3D fdt;
>     dtbfile.need_to_free =3D false; /* Config table memory can't be freed=
. */
>=20
> -    if ( fdt_node_offset_by_compatible(fdt, 0, "multiboot,module") > 0 )
> +    if ( fdt &&
> +         (fdt_node_offset_by_compatible(fdt, 0, "multiboot,module") > 0)=
 )
>     {
>         /* Locate chosen node */
>         int node =3D fdt_subnode_offset(fdt, 0, "chosen");
> --=20
> 2.17.1
>=20



From xen-devel-bounces@lists.xenproject.org Mon Oct 11 09:38:54 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 09:38:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.205617.360978 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZrlm-0003t9-Dk; Mon, 11 Oct 2021 09:38:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 205617.360978; Mon, 11 Oct 2021 09:38:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZrlm-0003t2-A2; Mon, 11 Oct 2021 09:38:54 +0000
Received: by outflank-mailman (input) for mailman id 205617;
 Mon, 11 Oct 2021 09:38:53 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=wT4x=O7=kernel.org=maz@srs-us1.protection.inumbo.net>)
 id 1mZrll-0003su-Sx
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 09:38:53 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 0b800f62-2a77-11ec-80d2-12813bfff9fa;
 Mon, 11 Oct 2021 09:38:52 +0000 (UTC)
Received: from disco-boy.misterjones.org (disco-boy.misterjones.org
 [51.254.78.96])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by mail.kernel.org (Postfix) with ESMTPSA id 29D5660231;
 Mon, 11 Oct 2021 09:38:52 +0000 (UTC)
Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org)
 by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2)
 (envelope-from <maz@kernel.org>)
 id 1mZrli-00FySl-62; Mon, 11 Oct 2021 10:38:50 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0b800f62-2a77-11ec-80d2-12813bfff9fa
Date: Mon, 11 Oct 2021 10:38:49 +0100
Message-ID: <87v923q4t2.wl-maz@kernel.org>
From: Marc Zyngier <maz@kernel.org>
To: Sean Christopherson <seanjc@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Will Deacon <will@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Guo Ren <guoren@kernel.org>,
	Nick Hu <nickhu@andestech.com>,
	Greentime Hu <green.hu@gmail.com>,
	Vincent Chen <deanbo422@gmail.com>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@redhat.com>,
	Namhyung Kim <namhyung@kernel.org>,
	James Morse <james.morse@arm.com>,
	Alexandru Elisei <alexandru.elisei@arm.com>,
	Suzuki K Poulose <suzuki.poulose@arm.com>,
	Vitaly Kuznetsov <vkuznets@redhat.com>,
	Wanpeng Li <wanpengli@tencent.com>,
	Jim Mattson <jmattson@google.com>,
	Joerg Roedel <joro@8bytes.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-perf-users@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	kvmarm@lists.cs.columbia.edu,
	linux-csky@vger.kernel.org,
	linux-riscv@lists.infradead.org,
	kvm@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	Artem Kashkanov <artem.kashkanov@intel.com>,
	Like Xu <like.xu.linux@gmail.com>,
	Zhu Lingshan <lingshan.zhu@intel.com>
Subject: Re: [PATCH v3 14/16] KVM: arm64: Convert to the generic perf callbacks
In-Reply-To: <20210922000533.713300-15-seanjc@google.com>
References: <20210922000533.713300-1-seanjc@google.com>
	<20210922000533.713300-15-seanjc@google.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue)
 FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1
 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
X-SA-Exim-Connect-IP: 185.219.108.64
X-SA-Exim-Rcpt-To: seanjc@google.com, peterz@infradead.org, mingo@redhat.com, acme@kernel.org, will@kernel.org, mark.rutland@arm.com, guoren@kernel.org, nickhu@andestech.com, green.hu@gmail.com, deanbo422@gmail.com, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, pbonzini@redhat.com, boris.ostrovsky@oracle.com, jgross@suse.com, alexander.shishkin@linux.intel.com, jolsa@redhat.com, namhyung@kernel.org, james.morse@arm.com, alexandru.elisei@arm.com, suzuki.poulose@arm.com, vkuznets@redhat.com, wanpengli@tencent.com, jmattson@google.com, joro@8bytes.org, sstabellini@kernel.org, linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, kvmarm@lists.cs.columbia.edu, linux-csky@vger.kernel.org, linux-riscv@lists.infradead.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, artem.kashkanov@intel.com, like.xu.linux@gmail.com, lingshan.zhu@intel.com
X-SA-Exim-Mail-From: maz@kernel.org
X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false

On Wed, 22 Sep 2021 01:05:31 +0100,
Sean Christopherson <seanjc@google.com> wrote:
> 
> Drop arm64's version of the callbacks in favor of the callbacks provided
> by generic KVM, which are semantically identical.
> 
> Signed-off-by: Sean Christopherson <seanjc@google.com>
> ---
>  arch/arm64/kvm/perf.c | 34 ++--------------------------------
>  1 file changed, 2 insertions(+), 32 deletions(-)
> 
> diff --git a/arch/arm64/kvm/perf.c b/arch/arm64/kvm/perf.c
> index 3e99ac4ab2d6..0b902e0d5b5d 100644
> --- a/arch/arm64/kvm/perf.c
> +++ b/arch/arm64/kvm/perf.c
> @@ -13,45 +13,15 @@
>  
>  DEFINE_STATIC_KEY_FALSE(kvm_arm_pmu_available);
>  
> -static unsigned int kvm_guest_state(void)
> -{
> -	struct kvm_vcpu *vcpu = kvm_get_running_vcpu();
> -	unsigned int state;
> -
> -	if (!vcpu)
> -		return 0;
> -
> -	state = PERF_GUEST_ACTIVE;
> -	if (!vcpu_mode_priv(vcpu))
> -		state |= PERF_GUEST_USER;
> -
> -	return state;
> -}
> -
> -static unsigned long kvm_get_guest_ip(void)
> -{
> -	struct kvm_vcpu *vcpu = kvm_get_running_vcpu();
> -
> -	if (WARN_ON_ONCE(!vcpu))
> -		return 0;
> -
> -	return *vcpu_pc(vcpu);
> -}
> -
> -static struct perf_guest_info_callbacks kvm_guest_cbs = {
> -	.state		= kvm_guest_state,
> -	.get_ip		= kvm_get_guest_ip,
> -};
> -
>  void kvm_perf_init(void)
>  {
>  	if (kvm_pmu_probe_pmuver() != 0xf && !is_protected_kvm_enabled())
>  		static_branch_enable(&kvm_arm_pmu_available);
>  
> -	perf_register_guest_info_callbacks(&kvm_guest_cbs);
> +	kvm_register_perf_callbacks(NULL);
>  }
>  
>  void kvm_perf_teardown(void)
>  {
> -	perf_unregister_guest_info_callbacks(&kvm_guest_cbs);
> +	kvm_unregister_perf_callbacks();
>  }

Reviewed-by: Marc Zyngier <maz@kernel.org>

	M.

-- 
Without deviation from the norm, progress is not possible.


From xen-devel-bounces@lists.xenproject.org Mon Oct 11 09:39:48 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 09:39:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.205625.360989 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZrmd-0004Uq-NU; Mon, 11 Oct 2021 09:39:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 205625.360989; Mon, 11 Oct 2021 09:39:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZrmd-0004Uj-Jj; Mon, 11 Oct 2021 09:39:47 +0000
Received: by outflank-mailman (input) for mailman id 205625;
 Mon, 11 Oct 2021 09:39:46 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mZrmc-0004UV-Dz
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 09:39:46 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mZrmb-0001t2-8E; Mon, 11 Oct 2021 09:39:45 +0000
Received: from 54-240-197-238.amazon.com ([54.240.197.238]
 helo=[192.168.17.141]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mZrmb-0008UG-1I; Mon, 11 Oct 2021 09:39:45 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=P6/v7bMHbWz7BZRy2DTeakiMKeOw1KnnvCxgamDRNxA=; b=zArkEVObdJbIg2311OlcoTjcCR
	SaKdy8mh15dE5V3oatgfbBD4VHnnxwawJ8KmMxsdGtTRuaTRb9dOlktWarw5zrjXn4vyUuBVSl+lp
	8coSnRzmASJB8SdOKwKxuOlGbFGXE1f7c99fcWidwo+COqCFnJ/WZab8YUUFWs1/hbRU=;
Message-ID: <81e30575-d823-830b-6f80-4e7a7fb4f9ff@xen.org>
Date: Mon, 11 Oct 2021 10:39:41 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.2.0
Subject: Re: [PATCH v5 1/2] arm/efi: Use dom0less configuration when using EFI
 boot
To: Luca Fancellu <luca.fancellu@arm.com>, xen-devel@lists.xenproject.org
Cc: bertrand.marquis@arm.com, wei.chen@arm.com,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Jan Beulich <jbeulich@suse.com>, Wei Liu <wl@xen.org>
References: <20211011080302.24203-1-luca.fancellu@arm.com>
 <20211011080302.24203-2-luca.fancellu@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20211011080302.24203-2-luca.fancellu@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Luca,

On 11/10/2021 09:03, Luca Fancellu wrote:
> +static bool __init is_boot_module(int dt_module_offset)
> +{
> +    if ( (fdt_node_check_compatible(fdt, dt_module_offset,
> +                                    "multiboot,kernel") == 0) ||
> +         (fdt_node_check_compatible(fdt, dt_module_offset,
> +                                    "multiboot,ramdisk") == 0) ||
> +         (fdt_node_check_compatible(fdt, dt_module_offset,
> +                                    "multiboot,device-tree") == 0) )
> +        return true;

A boot module *must* have the compatible "multiboot,module". I would 
prefer if we simply check that "multiboot,module" is present.

This will also make easier to add new boot module in the future.

> +
> +    return false;
> +}
> +
Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Mon Oct 11 09:45:10 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 09:45:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.205636.361000 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZrrl-0005ua-8c; Mon, 11 Oct 2021 09:45:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 205636.361000; Mon, 11 Oct 2021 09:45:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZrrl-0005uT-5T; Mon, 11 Oct 2021 09:45:05 +0000
Received: by outflank-mailman (input) for mailman id 205636;
 Mon, 11 Oct 2021 09:45:03 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=wT4x=O7=kernel.org=maz@srs-us1.protection.inumbo.net>)
 id 1mZrrj-0005uN-II
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 09:45:03 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 1dcc8dcf-0242-4153-ab87-90a079a1db79;
 Mon, 11 Oct 2021 09:45:02 +0000 (UTC)
Received: from disco-boy.misterjones.org (disco-boy.misterjones.org
 [51.254.78.96])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by mail.kernel.org (Postfix) with ESMTPSA id F3FEA60F43;
 Mon, 11 Oct 2021 09:45:00 +0000 (UTC)
Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org)
 by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2)
 (envelope-from <maz@kernel.org>)
 id 1mZrrf-00FyZ3-2U; Mon, 11 Oct 2021 10:44:59 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1dcc8dcf-0242-4153-ab87-90a079a1db79
Date: Mon, 11 Oct 2021 10:44:58 +0100
Message-ID: <87tuhnq4it.wl-maz@kernel.org>
From: Marc Zyngier <maz@kernel.org>
To: Sean Christopherson <seanjc@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Will Deacon <will@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Guo Ren <guoren@kernel.org>,
	Nick Hu <nickhu@andestech.com>,
	Greentime Hu <green.hu@gmail.com>,
	Vincent Chen <deanbo422@gmail.com>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@redhat.com>,
	Namhyung Kim <namhyung@kernel.org>,
	James Morse <james.morse@arm.com>,
	Alexandru Elisei <alexandru.elisei@arm.com>,
	Suzuki K Poulose <suzuki.poulose@arm.com>,
	Vitaly Kuznetsov <vkuznets@redhat.com>,
	Wanpeng Li <wanpengli@tencent.com>,
	Jim Mattson <jmattson@google.com>,
	Joerg Roedel <joro@8bytes.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-perf-users@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	kvmarm@lists.cs.columbia.edu,
	linux-csky@vger.kernel.org,
	linux-riscv@lists.infradead.org,
	kvm@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	Artem Kashkanov <artem.kashkanov@intel.com>,
	Like Xu <like.xu.linux@gmail.com>,
	Zhu Lingshan <lingshan.zhu@intel.com>
Subject: Re: [PATCH v3 15/16] KVM: arm64: Drop perf.c and fold its tiny bits of code into arm.c / pmu.c
In-Reply-To: <20210922000533.713300-16-seanjc@google.com>
References: <20210922000533.713300-1-seanjc@google.com>
	<20210922000533.713300-16-seanjc@google.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue)
 FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1
 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
X-SA-Exim-Connect-IP: 185.219.108.64
X-SA-Exim-Rcpt-To: seanjc@google.com, peterz@infradead.org, mingo@redhat.com, acme@kernel.org, will@kernel.org, mark.rutland@arm.com, guoren@kernel.org, nickhu@andestech.com, green.hu@gmail.com, deanbo422@gmail.com, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, pbonzini@redhat.com, boris.ostrovsky@oracle.com, jgross@suse.com, alexander.shishkin@linux.intel.com, jolsa@redhat.com, namhyung@kernel.org, james.morse@arm.com, alexandru.elisei@arm.com, suzuki.poulose@arm.com, vkuznets@redhat.com, wanpengli@tencent.com, jmattson@google.com, joro@8bytes.org, sstabellini@kernel.org, linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, kvmarm@lists.cs.columbia.edu, linux-csky@vger.kernel.org, linux-riscv@lists.infradead.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, artem.kashkanov@intel.com, like.xu.linux@gmail.com, lingshan.zhu@intel.com
X-SA-Exim-Mail-From: maz@kernel.org
X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false

On Wed, 22 Sep 2021 01:05:32 +0100,
Sean Christopherson <seanjc@google.com> wrote:
> 
> Call KVM's (un)register perf callbacks helpers directly from arm.c, and
> move the PMU bits into pmu.c and rename the related helper accordingly.
> 
> Signed-off-by: Sean Christopherson <seanjc@google.com>
> ---
>  arch/arm64/include/asm/kvm_host.h |  3 ---
>  arch/arm64/kvm/Makefile           |  2 +-
>  arch/arm64/kvm/arm.c              |  6 ++++--
>  arch/arm64/kvm/perf.c             | 27 ---------------------------
>  arch/arm64/kvm/pmu.c              |  8 ++++++++
>  include/kvm/arm_pmu.h             |  1 +
>  6 files changed, 14 insertions(+), 33 deletions(-)
>  delete mode 100644 arch/arm64/kvm/perf.c
> 
> diff --git a/arch/arm64/include/asm/kvm_host.h b/arch/arm64/include/asm/kvm_host.h
> index 828b6eaa2c56..f141ac65f4f1 100644
> --- a/arch/arm64/include/asm/kvm_host.h
> +++ b/arch/arm64/include/asm/kvm_host.h
> @@ -670,9 +670,6 @@ unsigned long kvm_mmio_read_buf(const void *buf, unsigned int len);
>  int kvm_handle_mmio_return(struct kvm_vcpu *vcpu);
>  int io_mem_abort(struct kvm_vcpu *vcpu, phys_addr_t fault_ipa);
>  
> -void kvm_perf_init(void);
> -void kvm_perf_teardown(void);
> -
>  #ifdef CONFIG_GUEST_PERF_EVENTS
>  static inline bool kvm_arch_pmi_in_guest(struct kvm_vcpu *vcpu)
>  {
> diff --git a/arch/arm64/kvm/Makefile b/arch/arm64/kvm/Makefile
> index 989bb5dad2c8..0bcc378b7961 100644
> --- a/arch/arm64/kvm/Makefile
> +++ b/arch/arm64/kvm/Makefile
> @@ -12,7 +12,7 @@ obj-$(CONFIG_KVM) += hyp/
>  
>  kvm-y := $(KVM)/kvm_main.o $(KVM)/coalesced_mmio.o $(KVM)/eventfd.o \
>  	 $(KVM)/vfio.o $(KVM)/irqchip.o $(KVM)/binary_stats.o \
> -	 arm.o mmu.o mmio.o psci.o perf.o hypercalls.o pvtime.o \
> +	 arm.o mmu.o mmio.o psci.o hypercalls.o pvtime.o \
>  	 inject_fault.o va_layout.o handle_exit.o \
>  	 guest.o debug.o reset.o sys_regs.o \
>  	 vgic-sys-reg-v3.o fpsimd.o pmu.o \
> diff --git a/arch/arm64/kvm/arm.c b/arch/arm64/kvm/arm.c
> index 2b542fdc237e..48f89d80f464 100644
> --- a/arch/arm64/kvm/arm.c
> +++ b/arch/arm64/kvm/arm.c
> @@ -1744,7 +1744,9 @@ static int init_subsystems(void)
>  	if (err)
>  		goto out;
>  
> -	kvm_perf_init();
> +	kvm_pmu_init();
> +	kvm_register_perf_callbacks(NULL);
> +
>  	kvm_sys_reg_table_init();
>  
>  out:
> @@ -2160,7 +2162,7 @@ int kvm_arch_init(void *opaque)
>  /* NOP: Compiling as a module not supported */
>  void kvm_arch_exit(void)
>  {
> -	kvm_perf_teardown();
> +	kvm_unregister_perf_callbacks();
>  }
>  
>  static int __init early_kvm_mode_cfg(char *arg)
> diff --git a/arch/arm64/kvm/perf.c b/arch/arm64/kvm/perf.c
> deleted file mode 100644
> index 0b902e0d5b5d..000000000000
> --- a/arch/arm64/kvm/perf.c
> +++ /dev/null
> @@ -1,27 +0,0 @@
> -// SPDX-License-Identifier: GPL-2.0-only
> -/*
> - * Based on the x86 implementation.
> - *
> - * Copyright (C) 2012 ARM Ltd.
> - * Author: Marc Zyngier <marc.zyngier@arm.com>
> - */
> -
> -#include <linux/perf_event.h>
> -#include <linux/kvm_host.h>
> -
> -#include <asm/kvm_emulate.h>
> -
> -DEFINE_STATIC_KEY_FALSE(kvm_arm_pmu_available);
> -
> -void kvm_perf_init(void)
> -{
> -	if (kvm_pmu_probe_pmuver() != 0xf && !is_protected_kvm_enabled())
> -		static_branch_enable(&kvm_arm_pmu_available);
> -
> -	kvm_register_perf_callbacks(NULL);
> -}
> -
> -void kvm_perf_teardown(void)
> -{
> -	kvm_unregister_perf_callbacks();
> -}
> diff --git a/arch/arm64/kvm/pmu.c b/arch/arm64/kvm/pmu.c
> index 03a6c1f4a09a..d98b57a17043 100644
> --- a/arch/arm64/kvm/pmu.c
> +++ b/arch/arm64/kvm/pmu.c
> @@ -7,6 +7,14 @@
>  #include <linux/perf_event.h>
>  #include <asm/kvm_hyp.h>
>  
> +DEFINE_STATIC_KEY_FALSE(kvm_arm_pmu_available);
> +
> +void kvm_pmu_init(void)
> +{
> +	if (kvm_pmu_probe_pmuver() != 0xf && !is_protected_kvm_enabled())
> +		static_branch_enable(&kvm_arm_pmu_available);
> +}
> +
>  /*
>   * Given the perf event attributes and system type, determine
>   * if we are going to need to switch counters at guest entry/exit.
> diff --git a/include/kvm/arm_pmu.h b/include/kvm/arm_pmu.h
> index 864b9997efb2..42270676498d 100644
> --- a/include/kvm/arm_pmu.h
> +++ b/include/kvm/arm_pmu.h
> @@ -14,6 +14,7 @@
>  #define ARMV8_PMU_MAX_COUNTER_PAIRS	((ARMV8_PMU_MAX_COUNTERS + 1) >> 1)
>  
>  DECLARE_STATIC_KEY_FALSE(kvm_arm_pmu_available);
> +void kvm_pmu_init(void);
>  
>  static __always_inline bool kvm_arm_support_pmu_v3(void)
>  {

Note that this patch is now conflicting with e840f42a4992 ("KVM:
arm64: Fix PMU probe ordering"), which was merged in -rc4. Moving the
static key definition to arch/arm64/kvm/pmu-emul.c and getting rid of
kvm_pmu_init() altogether should be enough to resolve it.

With that,

Reviewed-by: Marc Zyngier <maz@kernel.org>

	M.

-- 
Without deviation from the norm, progress is not possible.


From xen-devel-bounces@lists.xenproject.org Mon Oct 11 09:45:59 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 09:45:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.205644.361011 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZrsc-0006XM-PN; Mon, 11 Oct 2021 09:45:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 205644.361011; Mon, 11 Oct 2021 09:45:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZrsc-0006XF-LC; Mon, 11 Oct 2021 09:45:58 +0000
Received: by outflank-mailman (input) for mailman id 205644;
 Mon, 11 Oct 2021 09:45:56 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=wUPg=O7=gmail.com=xadimgnik@srs-us1.protection.inumbo.net>)
 id 1mZrsa-0006X3-K9
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 09:45:56 +0000
Received: from mail-wr1-x42c.google.com (unknown [2a00:1450:4864:20::42c])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id e237623a-6e39-4211-b51d-17c707c08a53;
 Mon, 11 Oct 2021 09:45:55 +0000 (UTC)
Received: by mail-wr1-x42c.google.com with SMTP id k7so54027622wrd.13
 for <xen-devel@lists.xenproject.org>; Mon, 11 Oct 2021 02:45:55 -0700 (PDT)
Received: from [192.168.1.186]
 (host86-143-223-59.range86-143.btcentralplus.com. [86.143.223.59])
 by smtp.gmail.com with ESMTPSA id r9sm7078320wru.2.2021.10.11.02.45.54
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Mon, 11 Oct 2021 02:45:54 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e237623a-6e39-4211-b51d-17c707c08a53
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=message-id:date:mime-version:user-agent:reply-to:subject
         :content-language:to:cc:references:from:in-reply-to
         :content-transfer-encoding;
        bh=l3nZLNB1OcHU4tOQHGyeKXwe/p3/bnTeaQVChfxc8lE=;
        b=pFlo3N/QG+Cq28NeW8/JBBud3J55ARyYeYICkekKPHuYyeNcRXtVceBMiEvNHySxis
         Ul15oRbKT7Jm3m4HwOndT0ySSTpHHKRiqwcFFkUKyqmcEZePe7vlQg8no0ZCORGjAg+y
         jLQL1U4oSTaQ5PxrDJ1AcArBt4PnOVyq/VZDS2yc77LIPjjNYYxl0Yu+gd6PKoWK9fq3
         HJBC+UoXmXGSJcgc2ZkzmRIb8H4dKjJv43CG09mRgH0fpQioFgYLQ95cdTTssHFEDKp5
         BGdDGluXCPCUBwj2MakVv8Vu/KxgHJhvNxamdaV7SyR59ZGWs1MxEYYrogYam7swu0pj
         iBYQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:message-id:date:mime-version:user-agent:reply-to
         :subject:content-language:to:cc:references:from:in-reply-to
         :content-transfer-encoding;
        bh=l3nZLNB1OcHU4tOQHGyeKXwe/p3/bnTeaQVChfxc8lE=;
        b=pTvQy7N3Rpe3qt24GP8ZVCAyU0VZDX5mBT/1+RD0b4y2f2Y6MZvZH5LkXhFERY5R1Q
         ylKRqKYguM/5EVTWvWRqwKHdzkPIxha8sqg196ROzhFLgNgJCN6lOqOtt7WZA0qnKETY
         4nF0L+M8CAcGKxDt6pzwTomggC/IN26UfwsQBOVRziLhOKTc9QBzkK22zidp0DO26/oK
         UaPIjnPN2kuy9bj+vyIjBWGO8czCUh2pxl1BMXpVNN7na+zkA/5bWsGOrZrjiTB+Hyte
         C2TjGB+nRKSCevZRVTnL5ZNr+kCu6LmaervWXKqxkQBX2Rgy5KNaG8f6PIgHXKOHC0A6
         ZYew==
X-Gm-Message-State: AOAM533pmyAalpELHRA6Kj8lCFWKDkpqprmkG0HRD8dJ/Qnoj5fTQ2Ho
	fvSSr5i7nOjh8XbJAIVc+qU=
X-Google-Smtp-Source: ABdhPJxXNLAv8dpZiH5e4OGhmz6llEJUKMMM8vE1HqtNd1vjArAisPa4+i8qcbt3apn6Pt9RH4Jh6Q==
X-Received: by 2002:a5d:6b46:: with SMTP id x6mr23276648wrw.192.1633945554825;
        Mon, 11 Oct 2021 02:45:54 -0700 (PDT)
Message-ID: <b2d4ec6f-3cfb-0dd7-e499-112437e132ae@gmail.com>
Date: Mon, 11 Oct 2021 10:45:53 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.1.2
Reply-To: paul@xen.org
Subject: Re: Ping: [PATCH v2 3/3] AMD/IOMMU: consider hidden devices when
 flushing device I/O TLBs
Content-Language: en-US
To: Jan Beulich <jbeulich@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Paul Durrant <paul@xen.org>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <c0a460c0-9d7e-c015-37cf-4775bdef33a8@suse.com>
 <09b6d94d-0116-c8ee-5daf-ddcc19d37029@suse.com>
 <2b6cdf04-ab6b-bbbd-6df1-d90fc22752f8@suse.com>
From: "Durrant, Paul" <xadimgnik@gmail.com>
In-Reply-To: <2b6cdf04-ab6b-bbbd-6df1-d90fc22752f8@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 11/10/2021 09:04, Jan Beulich wrote:
> On 17.09.2021 13:00, Jan Beulich wrote:
>> Hidden devices are associated with DomXEN but usable by the
>> hardware domain. Hence they need flushing as well when all devices are
>> to have flushes invoked.
>>
>> While there drop a redundant ATS-enabled check and constify the first
>> parameter of the involved function.
>>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> 
> The VT-d side equivalent having gone in a while ago, I think it would
> be good to have the AMD side on par.
> 

Agreed.

Reviewed-by: Paul Durrant <paul@xen.org>


From xen-devel-bounces@lists.xenproject.org Mon Oct 11 09:48:37 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 09:48:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.205653.361021 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZrvB-0007FR-5D; Mon, 11 Oct 2021 09:48:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 205653.361021; Mon, 11 Oct 2021 09:48:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZrvB-0007FK-2R; Mon, 11 Oct 2021 09:48:37 +0000
Received: by outflank-mailman (input) for mailman id 205653;
 Mon, 11 Oct 2021 09:48:36 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mZrvA-0007F7-4X
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 09:48:36 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mZrvA-00023T-1a
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 09:48:36 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mZrvA-0001GX-0V
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 09:48:36 +0000
Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89)
 (envelope-from <iwj@xenproject.org>)
 id 1mZrv6-0000eQ-7m; Mon, 11 Oct 2021 10:48:32 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date
	:Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From;
	bh=Ng3hqqfwgfFQ/6WKuuXxllUNR+zKFeMHWw3MTOYoe8E=; b=RTbfTOrSUmN81cWzAXtyOuYezf
	VlfwaoTaQ7Rh5EUYJWN4nnRuCT25ypyq0P3Ej6x93D+eLPymXcOxvvSLTctOgzJHLLG4dvlfqkMjS
	lUlkKmumRH3q2hGbsG+Sj0F2cfyIRWiar+Ue2Q7zDzTcjfp5RyuGbp04vgpDFQJd9WE0=;
From: Ian Jackson <iwj@xenproject.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <24932.2159.627949.196364@mariner.uk.xensource.com>
Date: Mon, 11 Oct 2021 10:48:31 +0100
To: Rahul Singh <rahul.singh@arm.com>
Cc: <xen-devel@lists.xenproject.org>,
    Andrew Cooper <andrew.cooper3@citrix.com>,
    <bertrand.marquis@arm.com>,
    <Andre.Przywara@arm.com>,
    Christian Lindig <christian.lindig@citrix.com>,
    David Scott <dave@recoil.org>,
    Ian Jackson <iwj@xenproject.org>,
    Wei Liu <wl@xen.org>,
    George Dunlap <george.dunlap@citrix.com>,
    Jan Beulich <jbeulich@suse.com>,
    Julien Grall <julien@xen.org>,
    Stefano Stabellini <sstabellini@kernel.org>,
    Volodymyr  Babchuk <Volodymyr_Babchuk@epam.com>,
    Roger Pau =?iso-8859-1?Q?Monn=E9?= <roger.pau@citrix.com>
Subject: Re: [PATCH v5 07/11] xen/domctl: Introduce XEN_DOMCTL_CDF_vpci flag
In-Reply-To: <548fa153-b2e3-7f91-c7c9-a569e13b5809@citrix.com>
References: <cover.1633540842.git.rahul.singh@arm.com>
	<20d5b9d6a0d01a7b90711d28cbefb5701a88b438.1633540842.git.rahul.singh@arm.com>
	<548fa153-b2e3-7f91-c7c9-a569e13b5809@citrix.com>
X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu)

Andrew Cooper writes ("Re: [PATCH v5 07/11] xen/domctl: Introduce XEN_DOMCTL_CDF_vpci flag"):
> Ian, for the 4.16 release, this series either needs completing with the
> additional flag implemented, or this patch needs reverting to avoid us
> shipping a broken interface.

I have caught up on this thread.  I think (hope?) it's converging.
If not please let me know and maybe I can help.

Can I ask to please be CC'd on the whole series for the patch(es) to
sort this out.  Please also make sure that those who commented are
CC'd.  I want the fixes that ultimately get committed to be the final
fixes (probably that means they should have consensus).

FTAOD, from a formal release management point of view: I regard those
putative fixes as bugfixes so they can go in after the feature freeze
(which is this Friday).  But if suitable fixes don't make it in within
the first few weeks of the freeze (and, as I expect, the maintainers
or I still regard this as an RC bug) then a revert of the new feature
will be the only option.

Ian.


From xen-devel-bounces@lists.xenproject.org Mon Oct 11 09:52:16 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 09:52:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.205662.361033 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZrye-0000B2-LV; Mon, 11 Oct 2021 09:52:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 205662.361033; Mon, 11 Oct 2021 09:52:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZrye-0000At-Hr; Mon, 11 Oct 2021 09:52:12 +0000
Received: by outflank-mailman (input) for mailman id 205662;
 Mon, 11 Oct 2021 09:52:11 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=daVx=O7=citrix.com=christian.lindig@srs-us1.protection.inumbo.net>)
 id 1mZryd-0000Ai-E1
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 09:52:11 +0000
Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id e6d827c4-2a78-11ec-80d2-12813bfff9fa;
 Mon, 11 Oct 2021 09:52:10 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e6d827c4-2a78-11ec-80d2-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1633945930;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:mime-version;
  bh=VnGgR3oOIvC5gp5hPXpguM1vSR+tYhTlkNRa+OHhe9s=;
  b=C6hKY7OpoCDsyxZ3eo0ctyo8sM4Qrh1iAcwd8T8rI6MjOofpPQJeqqYR
   mFUy5N1uZjClnltFHRwyqg8aiXwEz79FGv2Alxo5mm228fYnkvCrXvC5R
   jh6kaPMVBivTy0HMxVxJKFMWNdtpoK0mWftfP2OE5WgVGskCwB6T3JzEk
   8=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: 3za1ygkV0K2CqIDTHiHyg08WplwaIjiTh0MeuTvNn2ejRC2XStFphJRFYtAA41MZiheFiMoX+M
 PXEFC/3H00UrT05UTdsky+SkYbr3gIsEFnxwo3WTAz9nNHkN+ZZujzADqjPufNN4S5lDonbthK
 6iYYST1UpyFzWPZwKxq/5KwZqxBXXDAObrpY1JFwf/QVJd8AyHINKEaH4yBIva1KprwYKno4Vh
 SojzjuoBGvhdsrn8R1CChtUk65OSJDoiHCItRNVlfF0/ka4CBhQBFMnvxZeBcbSupX9GTD0fKg
 CSF5AUxO8uWAo6Go0b1Hn3mj
X-SBRS: 5.1
X-MesageID: 54838789
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:oCCm0a4tdP92u93O+7sF+AxRtGLBchMFZxGqfqrLsTDasY5as4F+v
 jYZUWuOb//fNjejeY8kbovnoBkAu8XUzN5gTVBr/HhhHi5G8cbLO4+Ufxz6V8+wwmwvb67FA
 +E2MISowBUcFyeEzvuV3zyIQUBUjclkfJKlYAL/En03FVIMpBsJ00o5wrdh29cw2LBVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Z+
 tYOuJyTdA4SHqDFxd8PSAMEMAxHMvgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALJ8nxPZgDu3hmizXYC/onTrjIQrnQ5M8e1zA17ixLNauCN
 5FJNmo+BPjGSzt9YVdQOJcspuDyjFnZMB0JgWOLrKVitgA/yyQuieOwYbI5YOeiR8pPmV2Dj
 nnb5Gm/CRYfXPSE0iaM+H+ogu7JnAv4VZgUGbn+8eRl6HWtwWgUBAwTREGMi/CzgU6jWPpSM
 0URvCEpqMAa+EW1Q/HnUha/oXrCuQQTM/JSDuk75Qel2qfSpQGDCQAsTyFDQMwrstcsQj4n3
 UPPmMnmbRR/vbvQRX+D+7O8qTKpJTNTPWIEfTUDTwYO/5/kuo5bphDFQ8tnEaW1psboAjy2y
 DePxAAhg50DgMhN0L+0lW0rmBr1+MKPFFRsoFyKACT1tWuVebJJeaSa6hvW7dV9Jb25Q1Dch
 2ofgZS9wdkBWMTleDO2fM0BG7Sg5vCgOTLagEJyE5RJywlB60JPbqgLv2kgfBYB3tIsPGazO
 heK6Fw5CIp7ZSPyNcdKj5SN59PGJEQKPe/uUezIdZJwa5x1eR7vEMpGNBPIgT6FfKTBl8gC1
 XannSSEUSZy5UdPlmPeqwIhPVkDnH1WKYT7H8GT8vhf+eDCDEN5sJ9cWLd0Usg37bmfvCLe+
 MtFOs2Bxn13CbOlOXmGqdFKdAxUdhDX4KwaTeQMLIZvxSI8SQkc5wL5m+t9K+SJYYwE/gs3w
 p1NchABkweu7ZE2AQ6LdmpieNvSsWVX9hoG0dgXFQ/wgRALON/3hI9GLsdfVeR3pYRLkK8vJ
 9FYKproPxi6Ymmek9jrRcKm99IKmdXCrV/mAhdJlxBmJ8Q+GFeTpoO9FuYtnQFXZheKWQIFi
 +TI/ivQQIYZRhQkC8DTafm1yEi2s2Rbk+V3N3Yk6PEPEKk12IQ1eSH3kNEtJMQAdUfKyjeAj
 l7EChYEv+jd5YQy9YCR16yDqo6oFcp4H1ZbQDaHverna3GC8zrx25JEXcaJYSvZCDH+9pK9a
 LgH1Pr7KvAGwgpH6tIuD7ZxwKsizNLzvLsGnB98FXDGYg3zWLNtK3WLx+dVsahJyuMLsAe6Q
 BvXqNJbJa+IKIXuF1tIfFgpaeGK1Pc1nDjO7KtqfBWmtXEvpLfeCBdcJRiBjiBZPYBZCoJ9z
 LdzotMS5iy+lgEuboSMgBdL+jneNXcHSagm6M0XWde5lgoxx1heSpXAESuqsoqXYtBBP0R2c
 D+ZgK3O2+ZVykbYKidhEHHM2axWhIgUuQAMx1gHfgzblt3Aj/4x/RtQ7TVoEVgFkkQZi7p+a
 jpxKkl4BaSS5DM51sFMUlelFxxFGBDEqFf6zEEElTGBQkSlPoAXwLbR5QpZEJglzl9h
IronPort-HdrOrdr: A9a23:ge+Rga3l3Ex90MFOm8ZdHAqjBLYkLtp133Aq2lEZdPUzSL3+qy
 nOpoV+6faQsl0ssR4b9exoVJPufZq+z/5ICOsqU4tKNTOO0AHEEGgI1+rf6gylNyri9vNMkY
 dMGpIObeEY1GIK7voSNjPIceod/A==
X-IronPort-AV: E=Sophos;i="5.85,364,1624334400"; 
   d="scan'208,217";a="54838789"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=NykfsiKDrVSJvIPilH0XQHe+/j74U+IbXPVBuKrJSe5rM+m0lZT9R9Ve8iH/pUICP6W7XBhRZJ819sh+6LUTX5afzaloS7eH1d4kgEHbIdx/0Ud0glK93G47VzINy1bctgrMZMouOcw2FZvSFqe/YlicljdhXzI36GIv6rFP1Td/VciWDQ1CQOlBP/snWsfXmZeAid4frrpLEPyER5pk62b0RT/ei5vb7xDR4weKA0WRJF0KKvWL+ydInNxHs4r7SvUbijskAmyBm1RTI6t0aFyUcVcgypQSHad2uum5yOYdmj8a+MSKtWjL+TJZ3LzVNCzIsynFHve1udJsR276KQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=VnGgR3oOIvC5gp5hPXpguM1vSR+tYhTlkNRa+OHhe9s=;
 b=Z6ZydOjzrVUJ5OyiR2T3wq85h4V3603nmVVzMP8/RP2Y9Mof3T/uayC+sXoqu9WT3Gg5ctoAqHaQo+YENd0HCwP1dMaMgzG0Uawhyqyjf5ZtNDqvvGhEtR+dM3f2DBjeMvpgt136XpCcbIJvEbVWn0eVPeY19nI3Q6bNP/E9F3K00/4D+lNhDlZPkLz5vAQv9VolZalb5uEPIfJ04RU2WUJ6lKkPIq7V8rLoINwyX+C3o1IulCSkCROH0VyMiJ/RgTZI46YNgvAA00dBzIRZ263jKlGZAqJJewZP/PsLYw2YZMosAduvosz6wu3j4DzW2OQeXBz/D2V8Yq6E20ul1g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=VnGgR3oOIvC5gp5hPXpguM1vSR+tYhTlkNRa+OHhe9s=;
 b=Y58Rie1mZkCh3hV1ywQcyWU/ck4rDxgITGGLTMcDKlmNOeS8O/1tCC0TSZNULdIOANsPky41AToVwFrnzZjOmZiAELbHRDIO/ktLkHck0ySpYb0qpjRdgt3o6VxgKg0NoV40BTbB5pMVv7mYuvfzdJwiFeDzAS9RfZaEf55ytaA=
From: Christian Lindig <christian.lindig@citrix.com>
To: Roger Pau Monne <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, "Ian
 Jackson" <iwj@xenproject.org>, Wei Liu <wl@xen.org>, Andrew Cooper
	<Andrew.Cooper3@citrix.com>, George Dunlap <George.Dunlap@citrix.com>, "Jan
 Beulich" <jbeulich@suse.com>, Julien Grall <julien@xen.org>, "Stefano
 Stabellini" <sstabellini@kernel.org>, Anthony Perard
	<anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>, David Scott
	<dave@recoil.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH v2 0/6] gnttab: add per-domain controls
Thread-Topic: [PATCH v2 0/6] gnttab: add per-domain controls
Thread-Index: AQHXr4rhj2WUWOIByUen+NK40c9U7KvNp8mAgAAEaAA=
Date: Mon, 11 Oct 2021 09:52:04 +0000
Message-ID: <89FFE3A3-0819-4357-BA9C-E7823CC7765F@citrix.com>
References: <20210922082123.54374-1-roger.pau@citrix.com>
 <YWQFj70MRWHEeOd8@MacBook-Air-de-Roger.local>
In-Reply-To: <YWQFj70MRWHEeOd8@MacBook-Air-de-Roger.local>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3608.120.23.2.4)
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 538044f2-0ace-4d7e-299c-08d98c9cc7b7
x-ms-traffictypediagnostic: CO6PR03MB6257:
x-ms-exchange-transport-forked: True
x-microsoft-antispam-prvs: <CO6PR03MB625770FE6E31743C5A97E587F6B59@CO6PR03MB6257.namprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:5797;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: s+x0ixLtkmYOT2XZe9Hdcy+r+pF8aPhyATEVfkkxBz6aLU1R0IqY+QZXPJnqe1TabtidLhjcFY+x09xLx7E7gPrn2q51k+AAQsv2zNYYlh5R4HqjnCTLNY5NNOWAne7CQ6F5/vM8T7WxZZ2FyitXJdYP92p/zQopB1smY4VLe/s3ISU2hhRNV4fgTQLxsal/18NP5qhocw1Voa0ZH0pmXSwnMinqhacIVsrp08JHAWjdpxFY/FbLmjymjutGtAI14dDsEbO36GJgRQ1D869GzfOgJAacSP1Ezd9K+Udp/3Ix5z4YUHVK5c9QXGvsqDsS5GJRzgqtX1KDOZ09i8G0kD5acXAagfRr7wP5OUkPLUcfIC7qM+w70+IFHQHvtX8V3CJGh9vzhKINE60NJUxRu6lQR0zjKsbcDe1lUtkG7qVjde2NibqZHMs5XTvvnlTLHVThdGr/xNTtDOF6INcLCiOOeJGc5oKaNU/ZPSEpcb402obsDIgpWsmRg8lmzAt7xw4G2RYXiExJz5lgeNhu8PKJCRkYqcR8gd/R2R/ybbUO/Q5KfAjoSAIsRUDCBTUHNLwVVCaGV2Gt4EzBAsosrXttBaVVt8JNFOcf7O5cWTy6cdF9T7VYvMWXtDkUxVzs9qg4GUo8Xttji0MKCP+pPwQHImIpONhHUVel4lVWXcjw+Ujv2Ln2cfCTMhORrhfsaNLqnkse3Rfs/bAveyxgnHzprg5HAMDi96qD6yKEgDI1/kEwOSKiOynegm1eJi7g
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR03MB6380.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(2906002)(6862004)(6636002)(6506007)(55236004)(558084003)(26005)(186003)(66556008)(38100700002)(53546011)(54906003)(66446008)(64756008)(37006003)(122000001)(316002)(8676002)(44832011)(38070700005)(6512007)(86362001)(66476007)(36756003)(91956017)(5660300002)(4326008)(2616005)(508600001)(33656002)(8936002)(66946007)(6486002)(76116006)(71200400001)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?rRYgmZFOR+Iwt+qpS4SI4CrGXNG0SdJ/ITQTN12ifcZNPEPXLEH2f6vSfK86?=
 =?us-ascii?Q?YZmjfFtSm9aJWuRsiTF8XwjVVPQKTJSCMQnHoKq0+FIACQjzJvT1NxiTcvsl?=
 =?us-ascii?Q?26fFw9XXZk9tGUGEDcS5bomVdSr8ZbUQvtVt/vSX+oPYKCyk2qJdz94cbQWg?=
 =?us-ascii?Q?QPcTIs82RJ3I1kJKltbz/uoNalI0QIFf+Ezxg7Bt9IVsGCfIe5VPPoZpQWhY?=
 =?us-ascii?Q?2VT7mIQymys5R9extsaOBReHpIIdP0E8LH6LSTd8jaF9K5jeAWRbR0ju4chs?=
 =?us-ascii?Q?a3mfDcgKm79sqSqqpl67hjocnVfvAT1jHj3jLg1jOJtkjpNnXBHPudNkfoLF?=
 =?us-ascii?Q?4mfllEd2hYBVpL0HFXu1fcpXnPsXiKSWGartmI0cTL7Q1De8U4lfLK6EbE+5?=
 =?us-ascii?Q?IS/il+7xVnhAKMcmn2fx02zY+n46V0mt22w4XRzZkPj+Gqb3KuHgbC0lYHFV?=
 =?us-ascii?Q?JHwNIr+z9bHPW7bV15WnDQraiYg1dnuYG7m5DG1OjILmaWkqiW8C3YhxG0Rt?=
 =?us-ascii?Q?T3THTz5IqDGfloZNDjqUXc2uso5aOBVL9+YsB0PMU3GAoLDASkle6sW6gNYx?=
 =?us-ascii?Q?jZXFt9zHOjBWghZL+ESlIh86bXnEPNg8V32XUOIjr514pVbL7W7q+XQD/FWR?=
 =?us-ascii?Q?O0AHTDQvrgVsjamxSSsqbhRleSETCq+0jBre87OnPis79hDjHhUIPiqhla+7?=
 =?us-ascii?Q?B3/RqQONNo7phI8zrSE5+3dae8QDPh1bRI+dHwPZcUqOwLnrwZmGYGlocYEf?=
 =?us-ascii?Q?rJdETHZD+1AtQ8OPV85lLKwZNRYe30GrDHIFb3blzHY7qndkJg4agnow21ax?=
 =?us-ascii?Q?Z06yRCX5qIb2b6G7153B7ERLY7vUwkmBE2VgjZaiYhIGqtoMYpmv83RMHCVT?=
 =?us-ascii?Q?BimUX0mLToe4ToyFw2ZS2KZbgkX7uAl/0dxjIMfAORckcfMz4nfgPgoMxQGP?=
 =?us-ascii?Q?d7MvWhSgn77WnbSg8hJtO9AxwYNGO6bYhbkmN18d4U/ue5VpyLNvc1gfCAh+?=
 =?us-ascii?Q?btf/kgNfkGGZf3NvTL6UCrAzEpNxiltUl5gydBnuDtepv7o/pnJ+01flxGgT?=
 =?us-ascii?Q?YFCoix6fe3yPBPrFkh4HvLFGiMzxuehmiBcOfYgrOK2ah9PVli1iuffdLdLL?=
 =?us-ascii?Q?zZRq940/gfv1Evpj+X/sIBlndVZrrN6wude3j8wnCJiGyxDgb0GGBk91y2Sh?=
 =?us-ascii?Q?t3sD/KDNxAKI4vlehHHgL2lo3JMe2k5xCP5tF0ICkFea0pIuzo0M2VIrF5jp?=
 =?us-ascii?Q?Gg46vufYv1iSyXaB/c3A3vsvtSrIjT3L7RI9D78ZUm0x5H/fMx1JWG0/qXxo?=
 =?us-ascii?Q?PonpiFvV4WHqznAyFiPCdALiAeW4qg6mf9k+q1F21pGi0g=3D=3D?=
Content-Type: multipart/alternative;
	boundary="_000_89FFE3A308194357BA9CE7823CC7765Fcitrixcom_"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MW4PR03MB6380.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 538044f2-0ace-4d7e-299c-08d98c9cc7b7
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Oct 2021 09:52:04.1409
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: zahJyMYiXE3rX88pM2RPdPfjTvqDEBVcCGvZF4exZn0yEp0e/qwO87ISPurSszVYzxFckVxLKAgLnBG+lhKj+DxWrEWMpkws60RphfLzISI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR03MB6257
X-OriginatorOrg: citrix.com

--_000_89FFE3A308194357BA9CE7823CC7765Fcitrixcom_
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable



On 11 Oct 2021, at 10:36, Roger Pau Monne <roger.pau@citrix.com<mailto:roge=
r.pau@citrix.com>> wrote:

Ping? The two patches above didn't get any review in either v1 or v2.

Patch #1 should be ready to go in AFAICT.

Acked-by: Christian Lindig <christian.lindig@citrix.com<mailto:christian.li=
ndig@citrix.com>>

--_000_89FFE3A308194357BA9CE7823CC7765Fcitrixcom_
Content-Type: text/html; charset="us-ascii"
Content-ID: <70176F864BE74F4793B43BDAC8B79BA6@namprd03.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable

<html>
<head>
<meta http-equiv=3D"Content-Type" content=3D"text/html; charset=3Dus-ascii"=
>
</head>
<body style=3D"word-wrap: break-word; -webkit-nbsp-mode: space; line-break:=
 after-white-space;" class=3D"">
<br class=3D"">
<div><br class=3D"">
<blockquote type=3D"cite" class=3D"">
<div class=3D"">On 11 Oct 2021, at 10:36, Roger Pau Monne &lt;<a href=3D"ma=
ilto:roger.pau@citrix.com" class=3D"">roger.pau@citrix.com</a>&gt; wrote:</=
div>
<br class=3D"Apple-interchange-newline">
<div class=3D""><span style=3D"caret-color: rgb(0, 0, 0); font-family: Helv=
etica; font-size: 12px; font-style: normal; font-variant-caps: normal; font=
-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0p=
x; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-te=
xt-stroke-width: 0px; text-decoration: none; float: none; display: inline !=
important;" class=3D"">Ping?
 The two patches above didn't get any review in either v1 or v2.</span><br =
style=3D"caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px=
; font-style: normal; font-variant-caps: normal; font-weight: normal; lette=
r-spacing: normal; text-align: start; text-indent: 0px; text-transform: non=
e; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; =
text-decoration: none;" class=3D"">
<br style=3D"caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: =
12px; font-style: normal; font-variant-caps: normal; font-weight: normal; l=
etter-spacing: normal; text-align: start; text-indent: 0px; text-transform:=
 none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0=
px; text-decoration: none;" class=3D"">
<span style=3D"caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size=
: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal;=
 letter-spacing: normal; text-align: start; text-indent: 0px; text-transfor=
m: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width:=
 0px; text-decoration: none; float: none; display: inline !important;" clas=
s=3D"">Patch
 #1 should be ready to go in AFAICT.</span></div>
</blockquote>
</div>
<span class=3D"" style=3D"font-family: Menlo; font-size: 14px;">
<div class=3D""><span class=3D"" style=3D"font-family: Menlo; font-size: 14=
px;"><br class=3D"">
</span></div>
Acked-by: Christian Lindig &lt;</span><a href=3D"mailto:christian.lindig@ci=
trix.com" class=3D"" style=3D"font-family: Menlo; font-size: 14px;">christi=
an.lindig@citrix.com</a><span class=3D"" style=3D"font-family: Menlo; font-=
size: 14px;">&gt;</span>
</body>
</html>

--_000_89FFE3A308194357BA9CE7823CC7765Fcitrixcom_--


From xen-devel-bounces@lists.xenproject.org Mon Oct 11 09:55:10 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 09:55:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.205674.361044 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZs1U-0000pC-4E; Mon, 11 Oct 2021 09:55:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 205674.361044; Mon, 11 Oct 2021 09:55:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZs1U-0000p5-0C; Mon, 11 Oct 2021 09:55:08 +0000
Received: by outflank-mailman (input) for mailman id 205674;
 Mon, 11 Oct 2021 09:55:07 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mZs1T-0000ov-5k; Mon, 11 Oct 2021 09:55:07 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mZs1S-0002AS-TE; Mon, 11 Oct 2021 09:55:06 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mZs1S-0005AD-JD; Mon, 11 Oct 2021 09:55:06 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mZs1S-00083s-Ih; Mon, 11 Oct 2021 09:55:06 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=kiOz0eHUBmHQmJUJPaxAUPKvGFOV4qU9Q/o2rXzUNXk=; b=Zkp2PY0jykbxFRWXqU+9gTAKiO
	P0yXd5I0FVh2mHvRv+ZSQTkrif2+e2vxhcH1EJHbCiAWwoO4yNW/ct2NvwbxCKAZpuoM0rWg4hCR6
	Xi5kqd5kxRB8/SCwx1/pMrorFEST03X2/6um8YjtK4bGbliE6M5ypcrlRm18gWh+ojDo=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165461-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 165461: regressions - FAIL
X-Osstest-Failures:
    libvirt:build-armhf-libvirt:libvirt-build:fail:regression
    libvirt:build-amd64-libvirt:libvirt-build:fail:regression
    libvirt:build-arm64-libvirt:libvirt-build:fail:regression
    libvirt:build-i386-libvirt:libvirt-build:fail:regression
    libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    libvirt=5ee4f3e1d4f173f7e1b64b745ab9ef5dc8c8f393
X-Osstest-Versions-That:
    libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 11 Oct 2021 09:55:06 +0000

flight 165461 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165461/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-armhf-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-amd64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-arm64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-i386-libvirt            6 libvirt-build            fail REGR. vs. 151777

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-libvirt-vhd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a

version targeted for testing:
 libvirt              5ee4f3e1d4f173f7e1b64b745ab9ef5dc8c8f393
baseline version:
 libvirt              2c846fa6bcc11929c9fb857a22430fb9945654ad

Last test of basis   151777  2020-07-10 04:19:19 Z  458 days
Failing since        151818  2020-07-11 04:18:52 Z  457 days  443 attempts
Testing same since   165461  2021-10-11 04:20:09 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
    Adolfo Jayme Barrientos <fitoschido@gmail.com>
  Aleksandr Alekseev <alexander.alekseev@virtuozzo.com>
  Aleksei Zakharov <zaharov@selectel.ru>
  Andika Triwidada <andika@gmail.com>
  Andrea Bolognani <abologna@redhat.com>
  Ani Sinha <ani@anisinha.ca>
  Balázs Meskó <meskobalazs@mailbox.org>
  Barrett Schonefeld <bschoney@utexas.edu>
  Bastian Germann <bastiangermann@fishpost.de>
  Bastien Orivel <bastien.orivel@diateam.net>
  BiaoXiang Ye <yebiaoxiang@huawei.com>
  Bihong Yu <yubihong@huawei.com>
  Binfeng Wu <wubinfeng@huawei.com>
  Bjoern Walk <bwalk@linux.ibm.com>
  Boris Fiuczynski <fiuczy@linux.ibm.com>
  Brian Turek <brian.turek@gmail.com>
  Bruno Haible <bruno@clisp.org>
  Chris Mayo <aklhfex@gmail.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Ehrhardt <christian.ehrhardt@canonical.com>
  Christian Kirbach <christian.kirbach@gmail.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Cole Robinson <crobinso@redhat.com>
  Collin Walling <walling@linux.ibm.com>
  Cornelia Huck <cohuck@redhat.com>
  Cédric Bosdonnat <cbosdonnat@suse.com>
  Côme Borsoi <fedora@borsoi.fr>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniel Letai <dani@letai.org.il>
  Daniel P. Berrange <berrange@redhat.com>
  Daniel P. Berrangé <berrange@redhat.com>
  Didik Supriadi <didiksupriadi41@gmail.com>
  dinglimin <dinglimin@cmss.chinamobile.com>
  Dmytro Linkin <dlinkin@nvidia.com>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Eric Farman <farman@linux.ibm.com>
  Erik Skultety <eskultet@redhat.com>
  Fabian Affolter <mail@fabian-affolter.ch>
  Fabian Freyer <fabian.freyer@physik.tu-berlin.de>
  Fabiano Fidêncio <fabiano@fidencio.org>
  Fangge Jin <fjin@redhat.com>
  Farhan Ali <alifm@linux.ibm.com>
  Fedora Weblate Translation <i18n@lists.fedoraproject.org>
  gongwei <gongwei@smartx.com>
  Guoyi Tu<tu.guoyi@h3c.com>
  Göran Uddeborg <goeran@uddeborg.se>
  Halil Pasic <pasic@linux.ibm.com>
  Han Han <hhan@redhat.com>
  Hao Wang <wanghao232@huawei.com>
  Hela Basa <r45xveza@pm.me>
  Helmut Grohne <helmut@subdivi.de>
  Hiroki Narukawa <hnarukaw@yahoo-corp.jp>
  Ian Wienand <iwienand@redhat.com>
  Jakob Meng <jakobmeng@web.de>
  Jamie Strandboge <jamie@canonical.com>
  Jamie Strandboge <jamie@ubuntu.com>
  Jan Kuparinen <copper_fin@hotmail.com>
  jason lee <ppark5237@gmail.com>
  Jean-Baptiste Holcroft <jean-baptiste@holcroft.fr>
  Jia Zhou <zhou.jia2@zte.com.cn>
  Jianan Gao <jgao@redhat.com>
  Jim Fehlig <jfehlig@suse.com>
  Jin Yan <jinyan12@huawei.com>
  Jinsheng Zhang <zhangjl02@inspur.com>
  Jiri Denemark <jdenemar@redhat.com>
  John Ferlan <jferlan@redhat.com>
  Jonathan Watt <jwatt@jwatt.org>
  Jonathon Jongsma <jjongsma@redhat.com>
  Julio Faracco <jcfaracco@gmail.com>
  Justin Gatzen <justin.gatzen@gmail.com>
  Ján Tomko <jtomko@redhat.com>
  Kashyap Chamarthy <kchamart@redhat.com>
  Kevin Locke <kevin@kevinlocke.name>
  Kristina Hanicova <khanicov@redhat.com>
  Laine Stump <laine@redhat.com>
  Laszlo Ersek <lersek@redhat.com>
  Lee Yarwood <lyarwood@redhat.com>
  Lei Yang <yanglei209@huawei.com>
  Liao Pingfang <liao.pingfang@zte.com.cn>
  Lin Ma <lma@suse.com>
  Lin Ma <lma@suse.de>
  Lin Ma <morecache@gmail.com>
  Liu Yiding <liuyd.fnst@fujitsu.com>
  Luke Yue <lukedyue@gmail.com>
  Luyao Zhong <luyao.zhong@intel.com>
  Marc Hartmayer <mhartmay@linux.ibm.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Markus Schade <markus.schade@hetzner.com>
  Martin Kletzander <mkletzan@redhat.com>
  Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
  Matej Cepl <mcepl@cepl.eu>
  Matt Coleman <matt@datto.com>
  Matt Coleman <mcoleman@datto.com>
  Mauro Matteo Cascella <mcascell@redhat.com>
  Meina Li <meili@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Michał Smyk <fedora@smyk.it>
  Milo Casagrande <milo@milo.name>
  Moshe Levi <moshele@nvidia.com>
  Muha Aliss <muhaaliss@gmail.com>
  Nathan <nathan95@live.it>
  Neal Gompa <ngompa13@gmail.com>
  Nick Chevsky <nchevsky@gmail.com>
  Nick Shyrokovskiy <nshyrokovskiy@gmail.com>
  Nickys Music Group <nickys.music.group@gmail.com>
  Nico Pache <npache@redhat.com>
  Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
  Olaf Hering <olaf@aepfle.de>
  Olesya Gerasimenko <gammaray@basealt.ru>
  Orion Poplawski <orion@nwra.com>
  Pany <geekpany@gmail.com>
  Patrick Magauran <patmagauran.j@gmail.com>
  Paulo de Rezende Pinatti <ppinatti@linux.ibm.com>
  Pavel Hrdina <phrdina@redhat.com>
  Peng Liang <liangpeng10@huawei.com>
  Peter Krempa <pkrempa@redhat.com>
  Pino Toscano <ptoscano@redhat.com>
  Pino Toscano <toscano.pino@tiscali.it>
  Piotr Drąg <piotrdrag@gmail.com>
  Prathamesh Chavan <pc44800@gmail.com>
  Richard W.M. Jones <rjones@redhat.com>
  Ricky Tigg <ricky.tigg@gmail.com>
  Robin Lee <cheeselee@fedoraproject.org>
  Roman Bogorodskiy <bogorodskiy@gmail.com>
  Roman Bolshakov <r.bolshakov@yadro.com>
  Ryan Gahagan <rgahagan@cs.utexas.edu>
  Ryan Schmidt <git@ryandesign.com>
  Sam Hartman <hartmans@debian.org>
  Scott Shambarger <scott-libvirt@shambarger.net>
  Sebastian Mitterle <smitterl@redhat.com>
  SeongHyun Jo <caelus9536@gmail.com>
  Shalini Chellathurai Saroja <shalini@linux.ibm.com>
  Shaojun Yang <yangshaojun@phytium.com.cn>
  Shi Lei <shi_lei@massclouds.com>
  simmon <simmon@nplob.com>
  Simon Chopin <chopin.simon@gmail.com>
  Simon Gaiser <simon@invisiblethingslab.com>
  Simon Rowe <simon.rowe@nutanix.com>
  Stefan Bader <stefan.bader@canonical.com>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Berger <stefanb@linux.vnet.ibm.com>
  Stefan Hajnoczi <stefanha@gmail.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Szymon Scholz <szymonscholz@gmail.com>
  Thomas Huth <thuth@redhat.com>
  Tim Wiederhake <twiederh@redhat.com>
  Tomáš Golembiovský <tgolembi@redhat.com>
  Tomáš Janoušek <tomi@nomi.cz>
  Tuguoyi <tu.guoyi@h3c.com>
  Victor Toso <victortoso@redhat.com>
  Ville Skyttä <ville.skytta@iki.fi>
  Vinayak Kale <vkale@nvidia.com>
  Wang Xin <wangxinxin.wang@huawei.com>
  WangJian <wangjian161@huawei.com>
  Weblate <noreply@weblate.org>
  Wei Liu <liuwe@microsoft.com>
  Wei Liu <wei.liu@kernel.org>
  William Douglas <william.douglas@intel.com>
  Yalei Li <274268859@qq.com>
  Yalei Li <liyl43@chinatelecom.cn>
  Yang Fei <yangfei85@huawei.com>
  Yang Hang <yanghang44@huawei.com>
  Yanqiu Zhang <yanqzhan@redhat.com>
  Yaroslav Kargin <ykargin@virtuozzo.com>
  Yi Li <yili@winhong.com>
  Yi Wang <wang.yi59@zte.com.cn>
  Yuri Chornoivan <yurchor@ukr.net>
  Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
  zhangjl02 <zhangjl02@inspur.com>
  Zheng Chuan <zhengchuan@huawei.com>
  zhenwei pi <pizhenwei@bytedance.com>
  Zhenyu Ye <yezhenyu2@huawei.com>
  Zhenyu Zheng <zheng.zhenyu@outlook.com>
  Zhenzhong Duan <zhenzhong.duan@intel.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          fail    
 build-arm64-libvirt                                          fail    
 build-armhf-libvirt                                          fail    
 build-i386-libvirt                                           fail    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           blocked 
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-libvirt-xsm                                 blocked 
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-libvirt                                     blocked 
 test-arm64-arm64-libvirt                                     blocked 
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-libvirt-pair                                blocked 
 test-amd64-i386-libvirt-pair                                 blocked 
 test-arm64-arm64-libvirt-qcow2                               blocked 
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-libvirt-vhd                                 blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 77435 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Oct 11 10:07:38 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 10:07:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.205685.361058 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZsDV-0002Tv-Ag; Mon, 11 Oct 2021 10:07:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 205685.361058; Mon, 11 Oct 2021 10:07:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZsDV-0002To-7d; Mon, 11 Oct 2021 10:07:33 +0000
Received: by outflank-mailman (input) for mailman id 205685;
 Mon, 11 Oct 2021 10:07:32 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=pkLr=O7=citrix.com=roger.pau@srs-us1.protection.inumbo.net>)
 id 1mZsDU-0002Ti-7t
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 10:07:32 +0000
Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 1fe4eb6e-a156-4bd1-aed9-c2dd43c37291;
 Mon, 11 Oct 2021 10:07:30 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1fe4eb6e-a156-4bd1-aed9-c2dd43c37291
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1633946850;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=Uksw2cLmbfnOMpMH3BE4/qSLccmWZZpoQ5O7LJuX270=;
  b=a/1kVnBCmteqIFKw5FB99fM7dFMy4ZRxElFGJdKB6HN9C4SlYpx8/eIQ
   jkh02zvWIfg31gp4438PGBshnjFIW8XPz7lrRrdCfvWJcJcclr6jU8jNS
   7R/Kdu+IFOdVsL1MsUwuQfjO3K4dCNLkxdvv7MPtNpzHkRIE5WSbqXDUH
   Q=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: ytzq53HyMLTHd9wGv515HdPcRtv02HE5vmJcwOs7k4TNYto/VkXzhzWI/sbWSpQ5h3Ph1w8slB
 5JbUomL7DhEhF2AINlc3cjbH0sNmDICeeYotf715+hd91MPTabKqfO3kmmCRmxKO84yOHYhpyY
 1VkLGYnWMwWvU3IRjsHHZuU1ezEsvoHu1enQlq5JD3LXU3GeDwSGM26hjzOE1TnYBtjc5ABN+f
 SfPIb35wWQ79/mtWDKhpRaBZyBnzSkEKLa7W8QDQGg2RIUWSDbq6X44Rb0XZ5A0ONSK0w+h9Z3
 rK0ypo1U6HO4+CrmQ8D2tqBP
X-SBRS: 5.1
X-MesageID: 54437084
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:UT1ybK8CPKarkUt4qE7kDrUDW3mTJUtcMsCJ2f8bNWPcYEJGY0x3z
 TMfXmuEaPiIa2bycop/OYmz8xsHuZTUyNFkGVA4qnw8E34SpcT7XtnIdU2Y0wF+jyHgoOCLy
 +1EN7Es+ehtFie0Si9AttENlFEkvU2ybuOU5NXsZ2YhGGeIdA970Ug6wrZg29Yx6TSEK1jlV
 e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH
 I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPgux
 u8SmKXpEzw1fYfSlNs3CxtfGg5HaPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us
 6ZCcXZUM07F17neLLGTE4GAguw5K8bmJsUHs2xIxjDFF/c2B5vERs0m4PcFgGtr2ZgeQZ4yY
 eIoTgVmMBT5ZyYVPw0NDKojvc3v3nfWJmgwRFW9+vNsvjm7IBZK+KfpGMrYfJqNX8o9tlaVo
 CfK8nr0BjkeNceD0nyV/3S0nOjNkCjnHoUIG9WQ9PRnnVmSzWw7EwANWB2wpvzRt6Klc4sBc
 QpOoHNo9PVsshzwJjXgY/GmiCGKhEExYoMKKPF5wh+B9YCM4QGQKVFRG1atd+canMMxQDUr0
 HqAkNXoGSFjvdWpdJ6NyluHhWjtYXZNfAfucQdBFFFfu4Cy/+nfmzqWFo47eJNZmOEZDt0ZL
 9qilyM5m6kIxfAC06G27DgraBr9+8CXEGbZCujRN19JDz+Vhqb5N+RECnCBtJ6sybp1qHHb4
 RDofODEvYgz4WmlznDlfQn0NOjBCwy5GDPdm0VzOJIq6i6g/XWuFagJvmoldBYxbZ9dJWGyC
 KM2he+3zMQJVJdNRfUmC79d9uxwlfSwfTgbfqG8giVyjmhZK1bcoXAGib+41GHxikk8+ZzTy
 r/AGftA+U0yUPw9pBLvHr91+eZymkgWmDOCLbimnk/P+efPOxaopUItbQLmghYRt/jf/m04M
 r93aqO39vmoeLSmOHeIqtRPcQliwLpSLcmelvG7v9Wre2JOMGogF+XQ0fUmfYlklL5SjeDG4
 je2XUow9bY1rSyvxdyiZi8xZbXxc4x4qH5nbyUgMUzxgyooYJq17bdZfJwyJOF1+OtmxP9yb
 v8EZ8TfXagfFmWZo2wQPcvnsYhvVBW3ngbSbSCrVycyIsx7TAvT9966Iga2rHsSDjC6vNcVq
 qG70l+JWoIKQglvVZ6EaP+mw16rk2IaneZ+AxnBLtVJIR2++4l2MS3hyPQwJphUexnEwzKb0
 SeQAAsZ+raR89NkroGRiPnd/YmzEuZ4Ek5LJEXh7O67ZXvA426u4Y5cS+LULzrTY3z5pfe5b
 uJPwvCibPBexARWs5BxGqpAxL4l44e9vKdTywlpESmZb1mvDb88cHCK0dMW6/9Iz75d/wC3R
 liO6p9RPrDQYJHpF1sYJQwEaOWf1K5LxmmOvKpteEiqtjVq+LenUFlJO0jegSNQG7J5LYc5z
 Lpzo8UR8QG+1kInP9vuYvq4LIhQwqjsi5kai6w=
IronPort-HdrOrdr: A9a23:QbmanK0TeG5cmSgpRd/BtgqjBSFyeYIsimQD101hICG9Lfb3qy
 n+ppsmPEHP5Ar5OEtBpTiBUJPwJ0800aQFnLX5Wo3SIDUO2VHYVr2KiLGC/9SOIVyaygcw79
 YFT0E6MqyOMbEYt7eL3ODbKadZ/DDvysnB7o2yvhQdL3AYV0gj1XYDNu/yKDwGeOAsP+tBKH
 Pz3Lshm9L2Ek5nEPhTS0N1E9TrlpnurtbLcBQGDxko5E2nii6p0qfzF1y90g0FWz1C7L8++S
 yd+jaJqJmLgrWe8FvxxmXT55NZlJ/IzcZCPtWFjowwJi/3ggilSYx9U/mpvSwzosuo9FE2+e
 O87CsIDoBW0Tf8b2u1qRzi103J1ysv0WbrzRuijX7qsaXCNXkHIvsEobgcXgrS6kImst05+r
 lMxXilu51eCg6FtDjh5vDTPisa1XackD4Hq6o+nnZfWYwRZPt6tooE5n5YF58GAWbT9J0nKu
 9zF8vRjcwmMW9yV0qp+1WH/ebcGkjaRny9Mw8/U42uonlrdUlCvgklLJd1pAZHyHo/I6M0r9
 gsfJ4YzY2n46ctHNVA7dw6ML6K41r2MFvx2VKpUCba/Z48SgbwQr7Mkf8IDbKRCdE1JKVbou
 W2bLofjx9rR37T
X-IronPort-AV: E=Sophos;i="5.85,364,1624334400"; 
   d="scan'208";a="54437084"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=bbkdnhENPo+0McbGVa+u+XuzxShfU9+csd/+c4AKM9UT8i+eonbQFhv6c24uIdFMdjCggm9GPwZ3YTbJDGBhMwuKIEwj8biqIhzXO0quLSC4weTUlFRdkS78+/30bHToL8N8KkVs0Ltpzf8XtBExbadnpohmFDolLEsWL0N+hEjjAPgCi0D/mHG7abm/6dJv6Qy89hUkyUPH+c/AznAi/6L/LeVBSBuCLs7JHiI4b/+NDumRzYDMT07bPA9mMfHkf/taMZJHDTPB8TlNUk54k9x5lW48HNsQPZPGeRk9iGsPgSOOwXt16ZfZ2n5lczwJrMPpYv4ElG1L6FN1+DHqGA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=8D2APnASnPIx2KKHfB9HVWACRoM0oq7S+IKo1fir02c=;
 b=TF7OJk96LuukVejr+hLnpUcGly5gQV95cbuLF297lBwjqCh/4B3BWNu9Cvrj5O2WZOlZTQ66mlqqH0xMdIMZec3JeF7Kqzv96KT0WdN53RM6jVmifA61GpjLqvPTXO9SjadgIszjx4SDrK0IG7ZenYYHtXC8OJ78VJe6ps6mCR94WIneyc/L1E915zQkVpEH9cZ5kZ6KkTBk14/xDA6A1IaZ3QLzt2K2W1a2SK1zngOJbC1RQ4wX7uAQMDkbzp4EdOTAUWV3hH3hVMAoy0P3WckEwE0Npax26GvwNL5miXva/IDjQI72maf8neu5TekEi9bhoVg89z9tz1eRPJZwKA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=8D2APnASnPIx2KKHfB9HVWACRoM0oq7S+IKo1fir02c=;
 b=mklM/JqyU376ERYtTqvn4PljlIM4qnzkcWtOZ7l08CbOGBXXR2SJDeyDwuSPZK+S1BMoIyRxqlOOJ1viqnKn83qD/R30pmhIsPKREbdI+DzuJAyxI0XZAagKy+LPOz182eNxS7NABm1m1hxPWeehwIisZzQXniaCTMcWtdnV+zg=
Date: Mon, 11 Oct 2021 12:06:34 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, "Andrew
 Cooper" <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH v2] x86/PV32: fix physdev_op_compat handling
Message-ID: <YWQMqq2Z9BNro9IL@MacBook-Air-de-Roger.local>
References: <af2f934a-49d8-a15d-3b66-94abc0d39081@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <af2f934a-49d8-a15d-3b66-94abc0d39081@suse.com>
X-ClientProxiedBy: LO2P123CA0057.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:1::21) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 7689d92c-0771-4319-c27f-08d98c9ed128
X-MS-TrafficTypeDiagnostic: DM5PR03MB3068:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <DM5PR03MB3068E878288E196AA90D7E688FB59@DM5PR03MB3068.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:4502;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: IGSu9zgYiZh2WXAGTV16jV/XR2IGUxpMxJXbw/3uYrsytOQa2baJaS597oaHZA7572SDsMKniKFLdBx2U23tbYQTNXKaP9zC6b4O8TRMDIiBT+qxzk1vNATT9+95h0Y9lAW+GQ6bNCA6ipedcae6Mp3qQK7hMECxBPvq/M38/O1i3f+mz7vug50rcMezyFuS3vYcogJhv6oHw+3j6Dia9VYUpjlSdVkECOYGJxdGgXvhtaFBZcSuT9pGL5GiRV1ZDJ5wLru4Scjt4EnMkFHa74LWM7t344IOfzXRSIUU/P7Pq7t1JxJL4wRMrfUvqnqL2s8q/DJTOpnl7iLIGk15DdJSA4630KhN3DZ3w55Ot+PrPDzhWEp2pF0tDmg8yRx879H0GnzfjfqBX+SKGbglz3VY1Mx66KazC/pXOH8BsT5w6PQM75ROHsmIz3/qKJ6WIZFR90YjdDJKdRZcM8I+Gz5yPrwVFJTUykoVW6KuptBDqHCqMYTaLbhc8UIisDtMDdIRA69K1i6qpHXwaMPKEoRzdHfSHOs1ETbqNyZ0mZQY4Oeseym0LXzi64jLVzcmsJ9LaVDhOm6q2Dbfg8odKatzB+jQnq4F0nnye/OHFJLt3Zj8WLKDi4r6XTU6Xduocd0rCLxTL+TIUrn13V82PA==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(85182001)(4326008)(26005)(6496006)(38100700002)(8676002)(956004)(6666004)(9686003)(54906003)(66946007)(5660300002)(86362001)(186003)(508600001)(6916009)(66556008)(8936002)(316002)(6486002)(2906002)(66476007)(4744005);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bndlV2tZbUJsMWlDTDljeTlXN01wQVRxM3VidEFaUFpFS1lWUThTSWNqdEMr?=
 =?utf-8?B?NkxzS2xpQmtLeGxORnkxWFVrbGFNd25WM01PNDZ0WlhPSnJkTmJ0QXB0dWVB?=
 =?utf-8?B?RE10b0tsOTQvRHk2Wm9JTnhKaTJXRldNZTFYSFJjMmF4UlB1OGNOYWRNa1Zh?=
 =?utf-8?B?K1liRUlCVCtsNGZDYVViZm0yVS9FZ3FWckhRUDFFeUthUmNDZHNUZGU0emlD?=
 =?utf-8?B?Z2o3YU1ENnFHOHdDN0ZCMWpLRE9IWWNkZ0tmM3BzWFdSUzJLd2I5YUNaNG5Z?=
 =?utf-8?B?SXpBODN1WFkwSGVZaVI0Zk83RzVEbkN0RU4vQ3JtZjBrMlIrVlRZVXczZXlJ?=
 =?utf-8?B?QWYrTzBNREM4Q0sxa3Brd25oaTN5TjJOL3FZako3N2tHdkFRdU43VjhGRHli?=
 =?utf-8?B?ZGtWUHpVR3RPY1M4YVBSVk12Y0ZQeFRBdHJVOUl5K1phdHVpVlAzQWVoK1p3?=
 =?utf-8?B?Wk9xcXpSRFdjdmtPMEs3OWRRY1NoYUlrUERVeUU3TlhqRWFqY21UNzRtczk2?=
 =?utf-8?B?TVJOTTNKbkYrTFZpN1Z1bUFvdGh6cUJIbzNYK2RTSGxocVhUUTUybGJ2WWF0?=
 =?utf-8?B?dERCYk1YbzU3bDJ3MGZ1RkR2cTR2NWVpVzk5NDlhS2liTXNPTVFWRXp2UGFN?=
 =?utf-8?B?bVZPc3JDZ1V1dXdOKzJpSnJlbzlPMUFnVC8vN1MrYXZFWXNPRkNQd1ZESGF5?=
 =?utf-8?B?ZzNzU1AwSWpOMzVGUlVFTkdMMDc3STJGRjFTV2lpNHRnQ0s1WXFqbDBsdExH?=
 =?utf-8?B?OEFWdk5PSUZsb1BPQk1OYjhLbUNVOVl3OTdXdjMzWFJJTUE5V1NHbm5UVjh3?=
 =?utf-8?B?OUNJQlpnek51VHRCZkZzU2lYSTY1RlVackVhempWRnpuNmJKSlZBNjFRekk3?=
 =?utf-8?B?cGNTUGsydU9WUFEzdkVKWTRlRlBkd0x6TS9iUVJqQkpEa2ZybGN5TmJTM3RJ?=
 =?utf-8?B?c3NZSUt3V3NLQkxGZDV2NitnOHNBd1FCbnA2WkxENlVXZ0s1Zk1vUmlacTNo?=
 =?utf-8?B?QTBMemlmTThjNWEwQ083c1EzZXpUQUNMWEtoVHdOcTFMODFxQUNNNlduT2R1?=
 =?utf-8?B?ZVlJQnVoMnVFR2lsa1dOdjVKRW1DSlJjWEYxamozdVZPNXBUMDVMUTBjeXRv?=
 =?utf-8?B?ZVIvRWRaZVRsOVBnMXN5OER1dzZnYlpNRXE4dERnM00rU2JCZVp3SW5mMzlC?=
 =?utf-8?B?bkNJUTJMQVZXTklXNjdPRVhOU2lBcmowaEcwZEFJS2lySVBhbVg1QUxvTGxy?=
 =?utf-8?B?QXdUMmpJdUFYOGRSZUJmY3Q2QmZMV3VnUHBic05lbHVDS0U3QThESUlOVWFB?=
 =?utf-8?B?ODFURDB1WG0wVVNNanBxMU9ueW1rbVB2bS95UXA5eTgyc2FqL2lzeTU4Yk9j?=
 =?utf-8?B?NFdIckgwRHNidHZ6TFRWWHNQUTVETVpUODJXakZLNDVHSUxXY0NMcElqRHkr?=
 =?utf-8?B?ZGZ3RXcvamdZbStnQWlYTFJyUkhwY3VmVEVteWZZU25DTS8rY0VSbllUNSt4?=
 =?utf-8?B?WGpVUVVNL0JHZkk4Y1lDODdhSzNpQzdhbitpVDJBNWsxZmpRZ2RPMy90NGEv?=
 =?utf-8?B?RTAxRkRCM2JiSDI1eDFIOGhNWTRxWUhLbEV3WFVoL2pEZXVVRkgxQTZaVzZY?=
 =?utf-8?B?ZGhNSVhrRFBTa0cxOExxTEw5M3VmV0IyZjA0Q3BmVkNXOW9hTS9PeWZwWDdj?=
 =?utf-8?B?Y2VSL3dNT0ozc3dUVGdNMFJzaHRxcEpoSFFxL2U5SXRNREVkbmlMcG1Sek9H?=
 =?utf-8?Q?ez3aZ1R67sbaS9U/JBXhR6DfgZgmGdWeg3BdD6K?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 7689d92c-0771-4319-c27f-08d98c9ed128
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2021 10:06:39.2502
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: xMNwRf0u9326I63eJUS6sHuIFbIUJgWTOBhL4LI0A4yVM6/zKhADpNRykL8u+ZNFljGmApoRMyfE+/o8rPdbqg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB3068
X-OriginatorOrg: citrix.com

On Mon, Oct 11, 2021 at 10:20:41AM +0200, Jan Beulich wrote:
> The conversion of the original code failed to recognize that the 32-bit
> compat variant of this (sorry, two different meanings of "compat" here)
> needs to continue to invoke the compat handler, not the native one.
> Arrange for this by adding yet another #define.
> 
> Affected functions (having existed prior to the introduction of the new
> hypercall) are PHYSDEVOP_set_iobitmap and PHYSDEVOP_apic_{read,write}.
> For all others the operand struct layout doesn't differ.
> 
> Fixes: 1252e2823117 ("x86/pv: Export pv_hypercall_table[] rather than working around it in several ways")
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Mon Oct 11 10:17:15 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 10:17:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.205693.361068 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZsMq-0003wi-8Q; Mon, 11 Oct 2021 10:17:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 205693.361068; Mon, 11 Oct 2021 10:17:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZsMq-0003wb-5d; Mon, 11 Oct 2021 10:17:12 +0000
Received: by outflank-mailman (input) for mailman id 205693;
 Mon, 11 Oct 2021 10:17:11 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mZsMo-0003wV-Vd
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 10:17:10 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mZsMo-0002dc-O2; Mon, 11 Oct 2021 10:17:10 +0000
Received: from 54-240-197-238.amazon.com ([54.240.197.238]
 helo=[192.168.17.141]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mZsMo-0004eR-IP; Mon, 11 Oct 2021 10:17:10 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=svzXPsIctWQElQvRlPKgRJGpbwIk95MNcTAuYMFlzYw=; b=Q64D6FLbtM8K7mh1EArSn4jDtR
	FiGhBeFFv1j2tMoVArF8DOTxd25prZaMds0/AjsMueBBFqZrYYD75TKuHcaar2qdGn9wQh60iGme8
	nytU+rUh21VDnIZm2f4RW+Ntem6QTlOucipc3y3sneqNQh+lAa9U6GYEtxAOeFUrdNB4=;
Message-ID: <1a8a16f6-9887-60ec-3c2d-1df906fd90c4@xen.org>
Date: Mon, 11 Oct 2021 11:17:08 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.2.0
Subject: Re: [PATCH v4 2/3] xen/arm: Check for PMU platform support
To: Michal Orzel <michal.orzel@arm.com>, xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, bertrand.marquis@arm.com
References: <20211011090047.8878-1-michal.orzel@arm.com>
 <20211011090047.8878-3-michal.orzel@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20211011090047.8878-3-michal.orzel@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Michal,

On 11/10/2021 10:00, Michal Orzel wrote:
> ID_AA64DFR0_EL1/ID_DFR0_EL1 registers provide
> information about PMU support. Replace structure
> dbg64/dbg32 with a union and fill in all the
> register fields according to document:
> ARM Architecture Registers(DDI 0595, 2021-06).
> 
> Add macros boot_dbg_feature64/boot_dbg_feature32
> to check for a debug feature. Add macro
> cpu_has_pmu to check for PMU support.
> 
> Signed-off-by: Michal Orzel <michal.orzel@arm.com>
> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
> Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>
> ---
> Changes since v3:
> -none
> Changes since v2:
> -none
> Changes since v1:
> -new in v2
> ---
>   xen/include/asm-arm/cpufeature.h | 49 ++++++++++++++++++++++++++++++--
>   1 file changed, 47 insertions(+), 2 deletions(-)
> 
> diff --git a/xen/include/asm-arm/cpufeature.h b/xen/include/asm-arm/cpufeature.h
> index 5ca09b0bff..4fce23844d 100644
> --- a/xen/include/asm-arm/cpufeature.h
> +++ b/xen/include/asm-arm/cpufeature.h
> @@ -4,6 +4,7 @@
>   #ifdef CONFIG_ARM_64
>   #define cpu_feature64(c, feat)         ((c)->pfr64.feat)
>   #define boot_cpu_feature64(feat)       (system_cpuinfo.pfr64.feat)
> +#define boot_dbg_feature64(feat)       (system_cpuinfo.dbg64.feat)
>   
>   #define cpu_feature64_has_el0_32(c)    (cpu_feature64(c, el0) == 2)
>   
> @@ -22,6 +23,7 @@
>   
>   #define cpu_feature32(c, feat)         ((c)->pfr32.feat)
>   #define boot_cpu_feature32(feat)       (system_cpuinfo.pfr32.feat)
> +#define boot_dbg_feature32(feat)       (system_cpuinfo.dbg32.feat)
>   
>   #define cpu_has_arm       (boot_cpu_feature32(arm) == 1)
>   #define cpu_has_thumb     (boot_cpu_feature32(thumb) >= 1)
> @@ -32,8 +34,10 @@
>   
>   #ifdef CONFIG_ARM_32
>   #define cpu_has_gentimer  (boot_cpu_feature32(gentimer) == 1)
> +#define cpu_has_pmu       (boot_dbg_feature32(perfmon) >= 1)

 From my understanding, on Armv7, perfmon == 0 only means PMUv2 is not 
present. IOW, it doesn't say whether PMUv1 is supported.

I think it is OK to treat as the PMU is not supported (ARMv8 treat it 
like that too), but I would like a comment in the code so it is clear 
this is a deliberate choice.

>   #else
>   #define cpu_has_gentimer  (1)
> +#define cpu_has_pmu       (boot_dbg_feature64(pmu_ver) >= 1)
>   #endif
>   #define cpu_has_security  (boot_cpu_feature32(security) > 0)
>   
> @@ -181,8 +185,28 @@ struct cpuinfo_arm {
>           };
>       } pfr64;
>   
> -    struct {
> +    union {
>           register_t bits[2];
> +        struct {
> +            /* DFR0 */
> +            unsigned long debug_ver:4;
> +            unsigned long trace_ver:4;
> +            unsigned long pmu_ver:4;
> +            unsigned long brps:4;
> +            unsigned long __res0:4;
> +            unsigned long wrps:4;
> +            unsigned long __res1:4;
> +            unsigned long ctx_cmps:4;
> +            unsigned long pms_ver:4;
> +            unsigned long double_lock:4;
> +            unsigned long trace_filt:4;
> +            unsigned long __res2:4;
> +            unsigned long mtpmu:4;
> +            unsigned long __res3:12;
> +
> +            /* DFR1 */
> +            unsigned long __res4:64;
> +        };
>       } dbg64;
>   
>       struct {
> @@ -321,8 +345,29 @@ struct cpuinfo_arm {
>           };
>       } pfr32;
>   
> -    struct {
> +    union {
>           register_t bits[2];
> +        struct {
> +            /* DFR0 */
> +            unsigned long copdbg:4;
> +            unsigned long copsdbg:4;
> +            unsigned long mmapdbg:4;
> +            unsigned long coptrc:4;
> +            unsigned long mmaptrc:4;
> +            unsigned long mprofdbg:4;
> +            unsigned long perfmon:4;
> +            unsigned long tracefilt:4;
> +#ifdef CONFIG_ARM_64
> +            unsigned long __res0:32;
> +#endif
> +
> +            /* DFR1 */
> +            unsigned long mtpmu:4;
> +            unsigned long __res1:28;
> +#ifdef CONFIG_ARM_64
> +            unsigned long __res2:32;
> +#endif
> +        };
>       } dbg32;
>   
>       struct {
> 

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Mon Oct 11 10:21:16 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 10:21:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.205701.361080 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZsQk-0005LG-PG; Mon, 11 Oct 2021 10:21:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 205701.361080; Mon, 11 Oct 2021 10:21:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZsQk-0005L9-MG; Mon, 11 Oct 2021 10:21:14 +0000
Received: by outflank-mailman (input) for mailman id 205701;
 Mon, 11 Oct 2021 10:21:13 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mZsQj-0005L3-Jk
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 10:21:13 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mZsQi-0002i0-A6; Mon, 11 Oct 2021 10:21:12 +0000
Received: from 54-240-197-230.amazon.com ([54.240.197.230]
 helo=[192.168.17.141]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mZsQh-00057F-Vx; Mon, 11 Oct 2021 10:21:12 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=jQ+J47ZBtfEUJVKNc8yjSwvOSv8AXyEiJiTZyF0JpyY=; b=t6v0mEijFeIK7nRnm1xFW0xcxw
	e/O1nTHQ8zvTvyVWaElKK2eqvm1VLzlrs444yUVup/T6y+CbQ62zTBIeBzU41DLtCEu4Z9ShWSo/m
	8Z7kkimiYIjLG4NnmzPV+UVqWCGPJMv6JCyrW2wHxecNJSKrdb8L0mbpCYdjzzt0gAQ0=;
Message-ID: <a91ddbf4-d1bc-40b5-b971-35dbcdc4d8a3@xen.org>
Date: Mon, 11 Oct 2021 11:21:09 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.2.0
Subject: Re: [PATCH v4 3/3] xen: Expose the PMU to the guests
To: Michal Orzel <michal.orzel@arm.com>, xen-devel@lists.xenproject.org
Cc: Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Nick Rosbrook <rosbrookn@ainfosec.com>,
 Anthony PERARD <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>,
 Christian Lindig <christian.lindig@citrix.com>, David Scott
 <dave@recoil.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 bertrand.marquis@arm.com
References: <20211011090047.8878-1-michal.orzel@arm.com>
 <20211011090047.8878-4-michal.orzel@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20211011090047.8878-4-michal.orzel@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Michal,

On 11/10/2021 10:00, Michal Orzel wrote:
> Add parameter vpmu to xl domain configuration syntax
> to enable the access to PMU registers by disabling
> the PMU traps(currently only for ARM).
> 
> The current status is that the PMU registers are not
> virtualized and the physical registers are directly
> accessible when this parameter is enabled. There is no
> interrupt support and Xen will not save/restore the
> register values on context switches.
> 
> Please note that this feature is experimental.
> 
> Signed-off-by: Michal Orzel <michal.orzel@arm.com>
> Signed-off-by: Julien Grall <julien@xen.org>
> Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>
> ---
> Changes since v3:
> -fail if vpmu is set but not supported
> -rebase on top of latest staging
> Changes since v2:
> -remove redundant check from x86 code
> -do not define bit position and mask separately
> Changes since v1:
> -modify vpmu parameter to be common rather than arch specific
> ---
>   docs/man/xl.cfg.5.pod.in             | 17 +++++++++++++++++
>   tools/golang/xenlight/helpers.gen.go |  6 ++++++
>   tools/golang/xenlight/types.gen.go   |  1 +
>   tools/include/libxl.h                |  6 ++++++
>   tools/libs/light/libxl_create.c      | 10 ++++++++++
>   tools/libs/light/libxl_types.idl     |  2 ++
>   tools/ocaml/libs/xc/xenctrl.ml       |  1 +
>   tools/ocaml/libs/xc/xenctrl.mli      |  1 +
>   tools/xl/xl_parse.c                  |  2 ++
>   xen/arch/arm/domain.c                | 12 +++++++++---
>   xen/arch/arm/setup.c                 |  1 +
>   xen/common/domain.c                  | 10 +++++++++-
>   xen/include/asm-arm/domain.h         |  1 +
>   xen/include/public/domctl.h          |  4 +++-
>   14 files changed, 69 insertions(+), 5 deletions(-)
> 
> diff --git a/docs/man/xl.cfg.5.pod.in b/docs/man/xl.cfg.5.pod.in
> index 4b1e3028d2..55c4881205 100644
> --- a/docs/man/xl.cfg.5.pod.in
> +++ b/docs/man/xl.cfg.5.pod.in
> @@ -690,6 +690,23 @@ default.
>   B<NOTE>: Acceptable values are platform specific.  For Intel Processor
>   Trace, this value must be a power of 2 between 4k and 16M.
>   
> +=item B<vpmu=BOOLEAN>
> +
> +Currently ARM only.
> +
> +Specifies whether to enable the access to PMU registers by disabling
> +the PMU traps.
> +
> +The PMU registers are not virtualized and the physical registers are directly
> +accessible when this parameter is enabled. There is no interrupt support and
> +Xen will not save/restore the register values on context switches.
> +
> +vPMU, by design and purpose, exposes system level performance
> +information to the guest. Only to be used by sufficiently privileged
> +domains. This feature is currently in experimental state.

Please update SUPPORT.MD to mention the support of this feature.

> +
> +If this option is not specified then it will default to B<false>.
> +
>   =back
>   
>   =head2 Devices
> diff --git a/tools/golang/xenlight/helpers.gen.go b/tools/golang/xenlight/helpers.gen.go
> index c8669837d8..2449580bad 100644
> --- a/tools/golang/xenlight/helpers.gen.go
> +++ b/tools/golang/xenlight/helpers.gen.go
> @@ -1119,6 +1119,9 @@ return fmt.Errorf("converting field ArchX86.MsrRelaxed: %v", err)
>   }
>   x.Altp2M = Altp2MMode(xc.altp2m)
>   x.VmtraceBufKb = int(xc.vmtrace_buf_kb)
> +if err := x.Vpmu.fromC(&xc.vpmu);err != nil {
> +return fmt.Errorf("converting field Vpmu: %v", err)
> +}
>   
>    return nil}
>   
> @@ -1600,6 +1603,9 @@ return fmt.Errorf("converting field ArchX86.MsrRelaxed: %v", err)
>   }
>   xc.altp2m = C.libxl_altp2m_mode(x.Altp2M)
>   xc.vmtrace_buf_kb = C.int(x.VmtraceBufKb)
> +if err := x.Vpmu.toC(&xc.vpmu); err != nil {
> +return fmt.Errorf("converting field Vpmu: %v", err)
> +}
>   
>    return nil
>    }
> diff --git a/tools/golang/xenlight/types.gen.go b/tools/golang/xenlight/types.gen.go
> index 45f2cba3d2..b2e8bd1a85 100644
> --- a/tools/golang/xenlight/types.gen.go
> +++ b/tools/golang/xenlight/types.gen.go
> @@ -521,6 +521,7 @@ MsrRelaxed Defbool
>   }
>   Altp2M Altp2MMode
>   VmtraceBufKb int
> +Vpmu Defbool
>   }
>   
>   type DomainBuildInfoTypeUnion interface {
> diff --git a/tools/include/libxl.h b/tools/include/libxl.h
> index ec5e3badae..ee73eb06f1 100644
> --- a/tools/include/libxl.h
> +++ b/tools/include/libxl.h
> @@ -508,6 +508,12 @@
>    */
>   #define LIBXL_HAVE_PHYSINFO_CAP_VPMU 1
>   
> +/*
> + * LIBXL_HAVE_VPMU indicates that libxl_domain_build_info has a vpmu parameter,
> + * which allows to enable the access to PMU registers.
> + */
> +#define LIBXL_HAVE_VPMU 1
> +
>   /*
>    * libxl ABI compatibility
>    *
> diff --git a/tools/libs/light/libxl_create.c b/tools/libs/light/libxl_create.c
> index e356b2106d..2a0234ec16 100644
> --- a/tools/libs/light/libxl_create.c
> +++ b/tools/libs/light/libxl_create.c
> @@ -91,6 +91,7 @@ int libxl__domain_build_info_setdefault(libxl__gc *gc,
>       }
>   
>       libxl_defbool_setdefault(&b_info->device_model_stubdomain, false);
> +    libxl_defbool_setdefault(&b_info->vpmu, false);
>   
>       if (libxl_defbool_val(b_info->device_model_stubdomain) &&
>           !b_info->device_model_ssidref)
> @@ -622,6 +623,9 @@ int libxl__domain_make(libxl__gc *gc, libxl_domain_config *d_config,
>                   create.flags |= XEN_DOMCTL_CDF_nested_virt;
>           }
>   
> +        if ( libxl_defbool_val(b_info->vpmu) )
> +            create.flags |= XEN_DOMCTL_CDF_vpmu;
> +
>           assert(info->passthrough != LIBXL_PASSTHROUGH_DEFAULT);
>           LOG(DETAIL, "passthrough: %s",
>               libxl_passthrough_to_string(info->passthrough));
> @@ -1199,6 +1203,12 @@ int libxl__domain_config_setdefault(libxl__gc *gc,
>           goto error_out;
>       }
>   
> +    if (libxl_defbool_val(d_config->b_info.vpmu) && !physinfo.cap_vpmu) {
> +        ret = ERROR_INVAL;
> +        LOGD(ERROR, domid, "vpmu not supported on this platform\n");
> +        goto error_out;
> +    }
> +
>       ret = 0;
>    error_out:
>       return ret;
> diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_types.idl
> index 993e83acca..b96fb5c47e 100644
> --- a/tools/libs/light/libxl_types.idl
> +++ b/tools/libs/light/libxl_types.idl
> @@ -655,6 +655,8 @@ libxl_domain_build_info = Struct("domain_build_info",[
>       # Use zero value to disable this feature.
>       ("vmtrace_buf_kb", integer),
>   
> +    ("vpmu", libxl_defbool),
> +
>       ], dir=DIR_IN,
>          copy_deprecated_fn="libxl__domain_build_info_copy_deprecated",
>   )
> diff --git a/tools/ocaml/libs/xc/xenctrl.ml b/tools/ocaml/libs/xc/xenctrl.ml
> index 7a4030a192..86758babb3 100644
> --- a/tools/ocaml/libs/xc/xenctrl.ml
> +++ b/tools/ocaml/libs/xc/xenctrl.ml
> @@ -70,6 +70,7 @@ type domain_create_flag =
>   	| CDF_IOMMU
>   	| CDF_NESTED_VIRT
>   	| CDF_VPCI
> +	| CDF_VPMU
>   
>   type domain_create_iommu_opts =
>   	| IOMMU_NO_SHAREPT
> diff --git a/tools/ocaml/libs/xc/xenctrl.mli b/tools/ocaml/libs/xc/xenctrl.mli
> index 6900513e7f..0fdb0cc169 100644
> --- a/tools/ocaml/libs/xc/xenctrl.mli
> +++ b/tools/ocaml/libs/xc/xenctrl.mli
> @@ -63,6 +63,7 @@ type domain_create_flag =
>     | CDF_IOMMU
>     | CDF_NESTED_VIRT
>     | CDF_VPCI
> +  | CDF_VPMU
>   
>   type domain_create_iommu_opts =
>     | IOMMU_NO_SHAREPT
> diff --git a/tools/xl/xl_parse.c b/tools/xl/xl_parse.c
> index 17dddb4cd5..c503b9be00 100644
> --- a/tools/xl/xl_parse.c
> +++ b/tools/xl/xl_parse.c
> @@ -2750,6 +2750,8 @@ skip_usbdev:
>                       "If it fixes an issue you are having please report to "
>                       "xen-devel@lists.xenproject.org.\n");
>   
> +    xlu_cfg_get_defbool(config, "vpmu", &b_info->vpmu, 0);
> +
>       xlu_cfg_destroy(config);
>   }
>   
> diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
> index aae4472479..2f988c790e 100644
> --- a/xen/arch/arm/domain.c
> +++ b/xen/arch/arm/domain.c
> @@ -276,6 +276,8 @@ static void ctxt_switch_to(struct vcpu *n)
>        * timer. The interrupt needs to be injected into the guest. */
>       WRITE_SYSREG(n->arch.cntkctl, CNTKCTL_EL1);
>       virt_timer_restore(n);
> +
> +    WRITE_SYSREG(n->arch.mdcr_el2, MDCR_EL2);
>   }
>   
>   /* Update per-VCPU guest runstate shared memory area (if registered). */
> @@ -586,6 +588,10 @@ int arch_vcpu_create(struct vcpu *v)
>   
>       v->arch.hcr_el2 = get_default_hcr_flags();
>   
> +    v->arch.mdcr_el2 = HDCR_TDRA | HDCR_TDOSA | HDCR_TDA;
> +    if ( !(v->domain->options & XEN_DOMCTL_CDF_vpmu) )
> +        v->arch.mdcr_el2 |= HDCR_TPM | HDCR_TPMCR;
> +
>       if ( (rc = vcpu_vgic_init(v)) != 0 )
>           goto fail;
>   
> @@ -622,9 +628,9 @@ int arch_sanitise_domain_config(struct xen_domctl_createdomain *config)
>   {
>       unsigned int max_vcpus;
>   
> -    /* HVM and HAP must be set. IOMMU and VPCI may or may not be */
> -    if ( (config->flags & ~XEN_DOMCTL_CDF_iommu & ~XEN_DOMCTL_CDF_vpci) !=
> -         (XEN_DOMCTL_CDF_hvm | XEN_DOMCTL_CDF_hap) )
> +    /* HVM and HAP must be set. IOMMU, VPCI and VPMU may or may not be */
> +    if ( (config->flags & ~(XEN_DOMCTL_CDF_iommu | XEN_DOMCTL_CDF_vpci |
> +          XEN_DOMCTL_CDF_vpmu)) != (XEN_DOMCTL_CDF_hvm | XEN_DOMCTL_CDF_hap) )

The split here is not easy to read. Can you introduce two masks (one for 
the flags that must be set and the other optional) so we don't need to 
split the optional options over two lines.

>       {
>           dprintk(XENLOG_INFO, "Unsupported configuration %#x\n",
>                   config->flags);
> diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c
> index 49dc90d198..85386a765a 100644
> --- a/xen/arch/arm/setup.c
> +++ b/xen/arch/arm/setup.c
> @@ -108,6 +108,7 @@ static void __init processor_id(void)
>   
>       identify_cpu(c);
>       current_cpu_data = *c;
> +    vpmu_is_available = cpu_has_pmu;

This wants to be set after the ID registers are sanitized (i.e. after 
the secondary CPUs have been brought).

Also, on Armv8, the features supported by 64-bit and 32-bit exception 
level are separate. I couldn't find anything in the Arm that suggest 
that if the PMU is implemented by the former, then the latter must be. 
Do you have the page in hand?

>   
>       if ( c->midr.implementer < ARRAY_SIZE(processor_implementers) &&
>            processor_implementers[c->midr.implementer] )
> diff --git a/xen/common/domain.c b/xen/common/domain.c
> index 262b6c0c3c..8543fb54fd 100644
> --- a/xen/common/domain.c
> +++ b/xen/common/domain.c
> @@ -480,12 +480,14 @@ static int sanitise_domain_config(struct xen_domctl_createdomain *config)
>       bool hvm = config->flags & XEN_DOMCTL_CDF_hvm;
>       bool hap = config->flags & XEN_DOMCTL_CDF_hap;
>       bool iommu = config->flags & XEN_DOMCTL_CDF_iommu;
> +    bool vpmu = config->flags & XEN_DOMCTL_CDF_vpmu;
>   
>       if ( config->flags &
>            ~(XEN_DOMCTL_CDF_hvm | XEN_DOMCTL_CDF_hap |
>              XEN_DOMCTL_CDF_s3_integrity | XEN_DOMCTL_CDF_oos_off |
>              XEN_DOMCTL_CDF_xs_domain | XEN_DOMCTL_CDF_iommu |
> -           XEN_DOMCTL_CDF_nested_virt | XEN_DOMCTL_CDF_vpci) )
> +           XEN_DOMCTL_CDF_nested_virt | XEN_DOMCTL_CDF_vpci |
> +           XEN_DOMCTL_CDF_vpmu) )
>       {
>           dprintk(XENLOG_INFO, "Unknown CDF flags %#x\n", config->flags);
>           return -EINVAL;
> @@ -534,6 +536,12 @@ static int sanitise_domain_config(struct xen_domctl_createdomain *config)
>           return -EINVAL;
>       }
>   
> +    if ( vpmu && !vpmu_is_available )
> +    {
> +        dprintk(XENLOG_INFO, "vpmu requested but cannot be enabled this way\n");
> +        return -EINVAL;
> +    }
> +
>       return arch_sanitise_domain_config(config);
>   }
>   
> diff --git a/xen/include/asm-arm/domain.h b/xen/include/asm-arm/domain.h
> index c9277b5c6d..14e575288f 100644
> --- a/xen/include/asm-arm/domain.h
> +++ b/xen/include/asm-arm/domain.h
> @@ -166,6 +166,7 @@ struct arch_vcpu
>   
>       /* HYP configuration */
>       register_t hcr_el2;
> +    register_t mdcr_el2;
>   
>       uint32_t teecr, teehbr; /* ThumbEE, 32-bit guests only */
>   #ifdef CONFIG_ARM_32
> diff --git a/xen/include/public/domctl.h b/xen/include/public/domctl.h
> index 4cb3f662c2..a53cbd16f4 100644
> --- a/xen/include/public/domctl.h
> +++ b/xen/include/public/domctl.h
> @@ -71,9 +71,11 @@ struct xen_domctl_createdomain {
>   #define _XEN_DOMCTL_CDF_nested_virt   6
>   #define XEN_DOMCTL_CDF_nested_virt    (1U << _XEN_DOMCTL_CDF_nested_virt)
>   #define XEN_DOMCTL_CDF_vpci           (1U << 7)
> +/* Should we expose the vPMU to the guest? */
> +#define XEN_DOMCTL_CDF_vpmu           (1U << 8)
>   
>   /* Max XEN_DOMCTL_CDF_* constant.  Used for ABI checking. */
> -#define XEN_DOMCTL_CDF_MAX XEN_DOMCTL_CDF_vpci
> +#define XEN_DOMCTL_CDF_MAX XEN_DOMCTL_CDF_vpmu
>   
>       uint32_t flags;
>   
> 

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Mon Oct 11 10:38:15 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 10:38:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.205715.361090 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZsh0-0006yI-B9; Mon, 11 Oct 2021 10:38:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 205715.361090; Mon, 11 Oct 2021 10:38:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZsh0-0006yB-7g; Mon, 11 Oct 2021 10:38:02 +0000
Received: by outflank-mailman (input) for mailman id 205715;
 Mon, 11 Oct 2021 10:38:01 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=9TNE=O7=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mZsgz-0006y5-3O
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 10:38:01 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 564934b7-7671-4c4e-b8fa-115140013972;
 Mon, 11 Oct 2021 10:38:00 +0000 (UTC)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2111.outbound.protection.outlook.com [104.47.17.111])
 (Using TLS) by relay.mimecast.com with ESMTP id
 de-mta-5-esNhiVesP8i1qOe4r_RVjA-1; Mon, 11 Oct 2021 12:37:58 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0402MB3533.eurprd04.prod.outlook.com (2603:10a6:803:b::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.22; Mon, 11 Oct
 2021 10:37:57 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4587.026; Mon, 11 Oct 2021
 10:37:57 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 FR3P281CA0067.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4b::14) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.5 via Frontend Transport; Mon, 11 Oct 2021 10:37:56 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 564934b7-7671-4c4e-b8fa-115140013972
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1633948679;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=NRU5NP45ghwB2g9kg5C3+SBfvLmDbJnrJva+gkxj/q8=;
	b=ehxubGsyGluo6Kx3r/tsvyFULMUlowQA1JIEkKdlYAS8uo70Tv39VyR0sJvWX1jvkeQL/P
	DUDD2CpJV+LqOXsmZ9BeVzChi5WzqHb6sU+rRVV3yikYbBIpVDLY/ZucX2XFbPWkA70MZT
	M8ob3xtDGLIsb5Sv7bHawM0frnbfz9c=
X-MC-Unique: esNhiVesP8i1qOe4r_RVjA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=XegyAf1TPmLorPL7EMVKgJCBLCp9kPmLOENGi9nYBjSpWrwyqoYtB9VeJEny1oOpG2xqVPGKYl6HmICXJxzRisv+uQlQhyo9KjpzEKqnBu5eWjv4jsSVEsKMZzeMz/QXH1E2mdC4UZxA24rYGhEcuyhQ/kO9dkG7LsymtGjgK10+K2RWE1ph6v8Hs0M/DlhZv6VhGKyfYrermCgAtBbbX7LasemhcQ1Ndz0mRp8UwyPEb8L7vINe5iapzvkKw63g7LTRLTgS6SRbzdeqWrrZeycexWSkhukhumhJT5FNfrPN8etJBi3PiH4c52cCmJbHiFmY7Zdq9ve/sp0pzzZBCQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=NRU5NP45ghwB2g9kg5C3+SBfvLmDbJnrJva+gkxj/q8=;
 b=TNwXmVhdLgFw8rMVWNjYYyIQaMmp9Igmo/31lSPeZLN77VLt/qRDzj3ou5cTVqhMkP30OvprC2kLOsWPaJjtovnidf3y5ME6vC4SM5+O+ZGWdcFzcrltNPzErAZuM02PD39lNOHWh8GVl5XqudciGYBZONRO78oNtT7wJQrtoqgtPd3gQfAn0vS1arCZkRgh2JsPc5hYZd4g5VEzCMA/UCF/yAcSrCkcQ46vL3Km9bbYxESkdHYpcyP8B7cc/GP6STL+HT7FZY4CJ1gMxj/TgtBpJwl5sjVwdLCgFkd/dWDcBxthVFWXGwnxhwXDgxzRKaqdLlNdgb9ZFFAvlaVCNg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [XEN PATCH v7 18/51] build: fix $(TARGET).efi creation in
 arch/arm
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>, Julien Grall
 <julien@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 xen-devel@lists.xenproject.org
References: <20210824105038.1257926-1-anthony.perard@citrix.com>
 <20210824105038.1257926-19-anthony.perard@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <34b274ae-fb02-10df-85ed-8d5231d49750@suse.com>
Date: Mon, 11 Oct 2021 12:37:55 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <20210824105038.1257926-19-anthony.perard@citrix.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR3P281CA0067.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:4b::14) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 0c006da8-6f19-4612-d41a-08d98ca33041
X-MS-TrafficTypeDiagnostic: VI1PR0402MB3533:
X-Microsoft-Antispam-PRVS:
	<VI1PR0402MB3533F8243C1C029CD8689ECDB3B59@VI1PR0402MB3533.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:2582;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	+2wom/8iKYR3BdajQ95TwVjDA0pKvxZ3S8slR5Hq4ZSGoZ6KbIf/TO/D9AKdQe75FUVBauaolRLt4y89QB3vZN35tIXAKhnv/VDtQSht52YNSsW63rp1DoW6Q8iLGOM8XskdJMz+ongk2G0HofkwZCf8l5zk2UKMfHoeZtxxkMwE8ZAQMoldHqiu86yAoME3AcA/A6MNw11Gz9CIe0PmxNLq+KF5U1Gc8T/f5arGeE9dxoKDLFs/iirmPt5U2nOeMww9pZkW6QWRtXHlo0j6cd79/pfP4gZ986URt9PemlhXiEze/lbx75TNlgDYS9aNmWSmK3NLJu/Vi6fns9y+x0MIPYivz7MlQ03MJmFiUEH0qbxIASSBnu4fxEwZXgTS7kl8cNW3h2Bu619M7t4qXZebIyhRAGBMOXbkRuRAg9MLaMwW5HUIq/czNrzeLuTKvITARWd3tDBXWRcCl6V80OX2vRfAguVdlitKERGqmlcxJQQ4dI/VXknNBBAsA85fNTUoMag8FazZYGsvgERlgABL12e0+WOrz5tHIlCBdycBTN544cS8HPKUDN3zeMwtu2gTs93zTZ02UC0+S4/v2DJ3z5wcs+6ILUY2aqH5BdNux5+YTp4T+cQRlI9y+/zbvSfek17ex9s22RjrLo1zoyOI7u9X0EF246napSrRG28lEklNa6G/zI11NJa4lDs8grYRpfJ4iu91UMggv1AJkNYsLCIhFTruxG9wQHjqBg0=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(6916009)(2906002)(31686004)(53546011)(38100700002)(26005)(186003)(6486002)(54906003)(316002)(16576012)(4744005)(66556008)(86362001)(66476007)(66946007)(956004)(5660300002)(508600001)(36756003)(2616005)(31696002)(8936002)(8676002)(4326008)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?ZThEaG5XTS9xaUNQTkFoenJFb3JIMmRIaDlNU1ROeXB6S1pUcVc4eGtmN0Jm?=
 =?utf-8?B?K0FYbkp4Sk5ySEhiS1dSZ2lYS1k5RHorOU5FNlo0SFl2NG0vVHk2ODNDS2xP?=
 =?utf-8?B?cWlZU2d5MTBKV3oybzNCWENGbTJxZ2l2azFqKzY1NEtjVXNEaERQamI0bXNr?=
 =?utf-8?B?V3VaTWZaU21ybGdFSlFPNVhqL2dVdHczQkQxd3k0bkFlQnpDNi8rdG9rZUtw?=
 =?utf-8?B?QUUwVHZFaUJFR05nemVWc05Dc1M5M2Vkc0JEQmdiN21kRGg4Z21URXphaTNJ?=
 =?utf-8?B?UnFQR08wdVhocGZNRTJyYTVraXVxWDRiVkhrQU9sNWFuSHJsVmVncDhRNi96?=
 =?utf-8?B?Q21HeVdxbnBsaFQ0em0yaVhwcDdRdXd1MXJ0Sis2UHNYNzgyazZzVy9NbFJO?=
 =?utf-8?B?ZG81aHRjalJvMUp5NU41SEhRRFpWQUlrRnR4eUlnQzk0TVFKZkNwQjAwbUhh?=
 =?utf-8?B?aUl4N0RwaEtxb1BVSnRtenVyVTlxeHFOYWJDWHJ6WnJFNHhoSkhVMnNXQTJE?=
 =?utf-8?B?bm03aER1ME0xNWdNTDdoN1BNREZnQk4xTVd6Ykk2WisreWxJYkRWUGk5cEZx?=
 =?utf-8?B?ZklhMmhjdkVTT2VtNEpTQWJmMmtDV0toaVR0YzN1QVIzNW4zMWNFSkJia1ZM?=
 =?utf-8?B?US9UdjRZeHlNaDNyM1Z3V21ibnhlK3IxTFFrTUtGQ2s5RnpUL0JFOWRvUHNY?=
 =?utf-8?B?Wlc2RTRwOElHcDZLZURaUDg2Y3dVeUxpN2RGa0czM25kVHNoODhPa3JhWkFR?=
 =?utf-8?B?NmZuYlB0Q3kvZEN3dGpoTUhnOE5jT2xLbHlabUE1ZmRpTzh1TGNNTzlQU1lE?=
 =?utf-8?B?M1NrM1YxNWNMeXpOZ2ZDclFRMUFrSDRzREZ0c1IwWHlEN2NnbVBVZXBPSnZm?=
 =?utf-8?B?alBVeThjSS9oeG9Yb1hiVnpKMng1Y0E4QkVSK2Jic1d2TUkyQlF1Y2NKamdD?=
 =?utf-8?B?STFiSnNtczVScml1M0E1aElvQngyYnh3aUIyRWZYUmlhMlhsSXZVcUhEV2hH?=
 =?utf-8?B?dXVHZmZTRGhxeHQ3dEFDZHY0Z2QyMEZRZXViazhaZk8reXRuR1JTQ3J3S3Ry?=
 =?utf-8?B?SEJkVHNGU05GbVJXbjRFcjl5cFk2ZjlLK0xWeEljbnV4SUpyaitPVkRkL1Zu?=
 =?utf-8?B?b1I4b095SXB3VUFLWDNXSmd2SDkyZGV5dngycGU2eW5BZjdMQ0l0N21OTU05?=
 =?utf-8?B?VndkOU1XTEl3NDZTNUx4WVU2d1VZMG82RnVzdFA3dHljSWo3K001Q01EZ2FQ?=
 =?utf-8?B?cHRvYUxmNnhLWVZkcFpkU2tsbXVzYWxuU2FpeWJxRGVWdzJ3dUVtNWxRc2g2?=
 =?utf-8?B?NWpOdCszNjdFWFZSdzB3N3JXNm9SeEg3U1FTK3krVnl2eW1xNTlzK1o5SHc1?=
 =?utf-8?B?K0UzL0txeE54UEJCVUp5d2tjZ2VRK2FEMWltT3JjMEh0ZmpwbHZDTmowZjFa?=
 =?utf-8?B?OWZSMDdUcWQ1NitzWUhVRVFrOEthS1oxdmhpVW84c25XL0hYUlN2R0VpTGRi?=
 =?utf-8?B?aERVdldEek5yanlmakJHdWpSSmtSTzlWVnJFU1l3bGt3bWh2UTVwbENOdzdY?=
 =?utf-8?B?Wk1SR2lSN0NuUzBxLzlic3ltV21WRUI5VVJtNE5TNWZPby8vbHEvMHZuNTgw?=
 =?utf-8?B?Wk12NWRtODZjRGkyZjFUOURmdi9RRUZZaDJBbDlSMUx0OStiZHRhQS9hZEZJ?=
 =?utf-8?B?eU1wM2NZRVRnWElFSXgyN2I3RDRXUnJUQVlQNkRBYjlxR1M4NXIwcW13UFNy?=
 =?utf-8?Q?znU0ZlK67MrKEFXJ7+xRbnvfPZrFDqq0vcJJYZV?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0c006da8-6f19-4612-d41a-08d98ca33041
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2021 10:37:56.8683
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 86hCQMkWZpUtAC/xNt1N4yz09JziqaTCRJ+XDGW0zHpxexOZX4DV0ZVvE3JgSi9XkF+iYpdhfEeWMvK0+Mt/qA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3533

On 24.08.2021 12:50, Anthony PERARD wrote:
> There is no need to try to guess a relative path to the "xen.efi" file,
> we can simply use $@. Also, there's no need to use `notdir`, make
> already do that work via $(@F).
> 
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>

Reviewed-by: Jan Beulich <jbeulich@suse.com>

As to the subject, I don't think "fix" is appropriate. How about "adjust"
or "simplify" or some such?

Jan



From xen-devel-bounces@lists.xenproject.org Mon Oct 11 10:45:13 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 10:45:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.205723.361102 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZsnv-0008Ny-33; Mon, 11 Oct 2021 10:45:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 205723.361102; Mon, 11 Oct 2021 10:45:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZsnu-0008Nr-WE; Mon, 11 Oct 2021 10:45:11 +0000
Received: by outflank-mailman (input) for mailman id 205723;
 Mon, 11 Oct 2021 10:45:09 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mZsnt-0008Mz-Ri
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 10:45:09 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mZsnt-00034m-J3; Mon, 11 Oct 2021 10:45:09 +0000
Received: from 54-240-197-230.amazon.com ([54.240.197.230]
 helo=[192.168.17.141]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mZsnt-0008OM-D4; Mon, 11 Oct 2021 10:45:09 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=8YIzacVrE5Uig7lY7JSn0GNOezBiHX+Ld0uhxcwJQSA=; b=okIybMojrpPPm83YXatlwGQOur
	WjBHE5D5+MZeIN7t1+mESjenMaR4GXsLgleYUVMsLGy3Zi14ICsSU+vjy7QaJOypmQGyiINAxLf5X
	4eI+p/AaskvcMCAdkN5gcp/f8WwP6skYf3F6khS0kaW2n8HfDD5LASWjqaHXaenZvz8k=;
Message-ID: <975079d0-38d4-2a56-541d-b6d652ce87c3@xen.org>
Date: Mon, 11 Oct 2021 11:45:07 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.2.0
Subject: Re: [PATCH 01/11] xen: reserve flags for internal usage in
 xen_domctl_createdomain
To: Jan Beulich <jbeulich@suse.com>, Penny Zheng <penny.zheng@arm.com>,
 xen-devel@lists.xenproject.org, sstabellini@kernel.org
Cc: Bertrand.Marquis@arm.com, Wei.Chen@arm.com
References: <20210923031115.1429719-1-penny.zheng@arm.com>
 <20210923031115.1429719-2-penny.zheng@arm.com>
 <7da75d7c-5640-305d-d742-d64b8c219949@xen.org>
 <60d813f7-a756-172c-999d-44f81504e268@suse.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <60d813f7-a756-172c-999d-44f81504e268@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Jan,

On 28/09/2021 13:05, Jan Beulich wrote:
> On 23.09.2021 11:54, Julien Grall wrote:
>> On 23/09/2021 08:11, Penny Zheng wrote:
>>> From: Stefano Stabellini <stefano.stabellini@xilinx.com>
>>>
>>> We are passing an extra special boolean flag at domain creation to
>>> specify whether we want to the domain to be privileged (i.e. dom0) or
>>> not. Another flag will be introduced later in this series.
>>>
>>> Reserve bits 16-31 from the existing flags bitfield in struct
>>> xen_domctl_createdomain for internal Xen usage.
>>
>> I am a bit split with this approach. This feels a bit of a hack to
>> reserve bits for internal purpose in external headers. But at the same
>> time I can see how this is easier to deal with it over repurposing the
>> last argument of domain_create().
> 
> I actually have trouble seeing why that's easier. It is a common thing
> to widen a bool to "unsigned int flags" when more than one control is
> needed.

I was suggesting this is easier for the following two reasons:
   1) All the option flags (internal and external) are in a single place.
   2) Reduce the risk to make a mistake when widening the field. In 
particular in the context of backporting. Although, this looks unlikely 
here.

> Plus this makes things needlessly harder once (in the future)
> the low 16 bits are exhausted in the public interface.

That's why I suggested this sounds like a hack. At the same time the 
split between external vs internal option is a bit more a pain for the 
developper. So I didn't feel pushing for one vs the other. That said, I 
will not argue against if you want to push for repurposing the last 
argument.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Mon Oct 11 10:49:26 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 10:49:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.205731.361113 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZss0-0000cb-Jx; Mon, 11 Oct 2021 10:49:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 205731.361113; Mon, 11 Oct 2021 10:49:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZss0-0000cU-GJ; Mon, 11 Oct 2021 10:49:24 +0000
Received: by outflank-mailman (input) for mailman id 205731;
 Mon, 11 Oct 2021 10:49:22 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mZsry-0000cO-Bk
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 10:49:22 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mZsry-00039b-5o; Mon, 11 Oct 2021 10:49:22 +0000
Received: from 54-240-197-238.amazon.com ([54.240.197.238]
 helo=[192.168.17.141]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mZsrx-0000LG-Vw; Mon, 11 Oct 2021 10:49:22 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=jTmHjCnoTVDYQ0BD0P56aPmCyTGWXHuTzvImY1jXc9w=; b=ZSWg5N30TosRb3Jn7JN5fqIeLg
	0OEk68JRz7booeKh2RinDMi4N7zKfwPHb+LQ3xtjEgEEcrEh6K49wW7qoQaRrUhC0l/P/jKuECoiH
	ZWxXpSwwwdUV5qSg2G2FGZoGFE+czux1YaOM/qQ5KuGbKHoGXvPJ700qLijG04guOgWo=;
Message-ID: <45f31ced-f011-a8fd-5c80-822b9c731adb@xen.org>
Date: Mon, 11 Oct 2021 11:49:20 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.2.0
Subject: Re: [PATCH 09/11] xen/arm: if 1:1 direct-map domain use native UART
 address and IRQ number for vPL011
To: Penny Zheng <Penny.Zheng@arm.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 "sstabellini@kernel.org" <sstabellini@kernel.org>
Cc: Bertrand Marquis <Bertrand.Marquis@arm.com>, Wei Chen <Wei.Chen@arm.com>
References: <20210923031115.1429719-1-penny.zheng@arm.com>
 <20210923031115.1429719-10-penny.zheng@arm.com>
 <db752d34-fc23-04b3-3c84-12d4de6859e0@xen.org>
 <VE1PR08MB5215F07156273D0822515E92F7B39@VE1PR08MB5215.eurprd08.prod.outlook.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <VE1PR08MB5215F07156273D0822515E92F7B39@VE1PR08MB5215.eurprd08.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 09/10/2021 09:47, Penny Zheng wrote:
> Hi Julien

Hi Penny,

>> -----Original Message-----
>> From: Julien Grall <julien@xen.org>
>> Sent: Thursday, September 23, 2021 7:14 PM
>> To: Penny Zheng <Penny.Zheng@arm.com>; xen-devel@lists.xenproject.org;
>> sstabellini@kernel.org
>> Cc: Bertrand Marquis <Bertrand.Marquis@arm.com>; Wei Chen
>> <Wei.Chen@arm.com>
>> Subject: Re: [PATCH 09/11] xen/arm: if 1:1 direct-map domain use native
>> UART address and IRQ number for vPL011
>>
>>
>>
>> On 23/09/2021 08:11, Penny Zheng wrote:
>>> From: Stefano Stabellini <stefano.stabellini@xilinx.com>
>>>
>>> We always use a fix address to map the vPL011 to domains. The address
>>> could be a problem for domains that are directly mapped.
>>>
>>> So, for domains that are directly mapped, reuse the address of the
>>> physical UART on the platform to avoid potential clashes.
>>>
>>> Do the same for the virtual IRQ number: instead of always using
>>> GUEST_VPL011_SPI, try to reuse the physical SPI number if possible.
>>>
>>> Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>
>>> Signed-off-by: Penny Zheng <penny.zheng@arm.com>
>>> ---
>>>    xen/arch/arm/domain_build.c  | 34 +++++++++++++++++++++++++++-------
>>>    xen/arch/arm/vpl011.c        | 34 +++++++++++++++++++++++++++-------
>>>    xen/include/asm-arm/vpl011.h |  2 ++
>>>    3 files changed, 56 insertions(+), 14 deletions(-)
>>>
>>> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
>>> index 120f1ae575..c92e510ae7 100644
>>> --- a/xen/arch/arm/domain_build.c
>>> +++ b/xen/arch/arm/domain_build.c
>>> @@ -30,6 +30,7 @@
>>>
>>>    #include <xen/irq.h>
>>>    #include <xen/grant_table.h>
>>> +#include <xen/serial.h>
>>>
>>>    static unsigned int __initdata opt_dom0_max_vcpus;
>>>    integer_param("dom0_max_vcpus", opt_dom0_max_vcpus); @@ -1942,8
>>> +1943,11 @@ static int __init make_vpl011_uart_node(struct kernel_info
>> *kinfo)
>>>        gic_interrupt_t intr;
>>>        __be32 reg[GUEST_ROOT_ADDRESS_CELLS + GUEST_ROOT_SIZE_CELLS];
>>>        __be32 *cells;
>>> +    struct domain *d = kinfo->d;
>>> +    char buf[27];
>>>
>>> -    res = fdt_begin_node(fdt, "sbsa-uart@"__stringify(GUEST_PL011_BASE));
>>> +    snprintf(buf, sizeof(buf), "sbsa-uart@%"PRIx64, d-
>>> arch.vpl011.base_addr);
>>> +    res = fdt_begin_node(fdt, buf);
>>>        if ( res )
>>>            return res;
>>>
>>> @@ -1953,14 +1957,14 @@ static int __init make_vpl011_uart_node(struct
>>> kernel_info *kinfo)
>>>
>>>        cells = &reg[0];
>>>        dt_child_set_range(&cells, GUEST_ROOT_ADDRESS_CELLS,
>>> -                       GUEST_ROOT_SIZE_CELLS, GUEST_PL011_BASE,
>>> +                       GUEST_ROOT_SIZE_CELLS,
>>> + d->arch.vpl011.base_addr,
>>>                           GUEST_PL011_SIZE);
>>>
>>>        res = fdt_property(fdt, "reg", reg, sizeof(reg));
>>>        if ( res )
>>>            return res;
>>>
>>> -    set_interrupt(intr, GUEST_VPL011_SPI, 0xf, DT_IRQ_TYPE_LEVEL_HIGH);
>>> +    set_interrupt(intr, d->arch.vpl011.virq, 0xf,
>>> + DT_IRQ_TYPE_LEVEL_HIGH);
>>>
>>>        res = fdt_property(fdt, "interrupts", intr, sizeof (intr));
>>>        if ( res )
>>> @@ -2670,6 +2674,13 @@ static int __init construct_domU(struct domain
>> *d,
>>>        else
>>>            allocate_static_memory(d, &kinfo, node);
>>>
>>> +    /*
>>> +     * Initialization before creating its device
>>> +     * tree node in prepare_dtb_domU.
>>> +     */
>>
>> I think it would be better to explain *why* this needs to be done before.
>>
>>> +    if ( kinfo.vpl011 )
>>> +        rc = domain_vpl011_init(d, NULL);
>>> +
>>>        rc = prepare_dtb_domU(d, &kinfo);
>>>        if ( rc < 0 )
>>>            return rc;
>>> @@ -2678,9 +2689,6 @@ static int __init construct_domU(struct domain
>> *d,
>>>        if ( rc < 0 )
>>>            return rc;
>>>
>>> -    if ( kinfo.vpl011 )
>>> -        rc = domain_vpl011_init(d, NULL);
>>> -
>>>        return rc;
>>>    }
>>>
>>> @@ -2723,15 +2731,27 @@ void __init create_domUs(void)
>>>
>>>            if ( !dt_property_read_u32(node, "nr_spis", &d_cfg.arch.nr_spis) )
>>>            {
>>> +            unsigned int vpl011_virq = GUEST_VPL011_SPI;
>>
>> Coding style: Add a newline here.
>>
>>>                d_cfg.arch.nr_spis = gic_number_lines() - 32;
>>>
>>> +            /*
>>> +             * The VPL011 virq is GUEST_VPL011_SPI, unless direct-map in
>>> +             * set, in which case we'll try to match the hardware.
>>> +             *
>>> +             * Typically, d->arch.vpl011.virq has the vpl011 irq number
>>> +             * but at this point of the boot sequence it is not
>>> +             * initialized yet.
>>> +             */
>>> +            if ( direct_map && serial_irq(SERHND_DTUART) > 0 )
>>> +                vpl011_virq = serial_irq(SERHND_DTUART);
>>
>> I think we should not continue if the domain is direct-mapped *and* the IRQ
>> is not found. Otherwise, this will may just result to potential breakage if
>> GUEST_VPL011_SPI happens to be used for an HW device.
>>
>>> +
>>>                /*
>>>                 * vpl011 uses one emulated SPI. If vpl011 is requested, make
>>>                 * sure that we allocate enough SPIs for it.
>>>                 */
>>>                if ( dt_property_read_bool(node, "vpl011") )
>>>                    d_cfg.arch.nr_spis = MAX(d_cfg.arch.nr_spis,
>>> -                                         GUEST_VPL011_SPI - 32 + 1);
>>> +                                         vpl011_virq - 32 + 1);
>>>            }
>>>
>>>            /*
>>> diff --git a/xen/arch/arm/vpl011.c b/xen/arch/arm/vpl011.c index
>>> 895f436cc4..10df25f098 100644
>>> --- a/xen/arch/arm/vpl011.c
>>> +++ b/xen/arch/arm/vpl011.c
>>> @@ -29,6 +29,7 @@
>>>    #include <xen/mm.h>
>>>    #include <xen/sched.h>
>>>    #include <xen/console.h>
>>> +#include <xen/serial.h>
>>>    #include <public/domctl.h>
>>>    #include <public/io/console.h>
>>>    #include <asm/pl011-uart.h>
>>> @@ -71,11 +72,11 @@ static void vpl011_update_interrupt_status(struct
>> domain *d)
>>>         * status bit has been set since the last time.
>>>         */
>>>        if ( uartmis & ~vpl011->shadow_uartmis )
>>> -        vgic_inject_irq(d, NULL, GUEST_VPL011_SPI, true);
>>> +        vgic_inject_irq(d, NULL, vpl011->virq, true);
>>>
>>>        vpl011->shadow_uartmis = uartmis;
>>>    #else
>>> -    vgic_inject_irq(d, NULL, GUEST_VPL011_SPI, uartmis);
>>> +    vgic_inject_irq(d, NULL, vpl011->virq, uartmis);
>>>    #endif
>>>    }
>>>
>>> @@ -347,7 +348,8 @@ static int vpl011_mmio_read(struct vcpu *v,
>>>                                void *priv)
>>>    {
>>>        struct hsr_dabt dabt = info->dabt;
>>> -    uint32_t vpl011_reg = (uint32_t)(info->gpa - GUEST_PL011_BASE);
>>> +    uint32_t vpl011_reg = (uint32_t)(info->gpa -
>>> +
>>> + v->domain->arch.vpl011.base_addr);
>>>        struct vpl011 *vpl011 = &v->domain->arch.vpl011;
>>>        struct domain *d = v->domain;
>>>        unsigned long flags;
>>> @@ -430,7 +432,8 @@ static int vpl011_mmio_write(struct vcpu *v,
>>>                                 void *priv)
>>>    {
>>>        struct hsr_dabt dabt = info->dabt;
>>> -    uint32_t vpl011_reg = (uint32_t)(info->gpa - GUEST_PL011_BASE);
>>> +    uint32_t vpl011_reg = (uint32_t)(info->gpa -
>>> +
>>> + v->domain->arch.vpl011.base_addr);
>>>        struct vpl011 *vpl011 = &v->domain->arch.vpl011;
>>>        struct domain *d = v->domain;
>>>        unsigned long flags;
>>> @@ -622,10 +625,27 @@ int domain_vpl011_init(struct domain *d, struct
>> vpl011_init_info *info)
>>>    {
>>>        int rc;
>>>        struct vpl011 *vpl011 = &d->arch.vpl011;
>>> +    const struct vuart_info *uart = serial_vuart_info(SERHND_DTUART);
>>>
>>>        if ( vpl011->backend.dom.ring_buf )
>>>            return -EINVAL;
>>>
>>> +    vpl011->base_addr = GUEST_PL011_BASE;
>>> +    vpl011->virq = GUEST_VPL011_SPI;
>>> +    if ( is_domain_direct_mapped(d) )
>>> +    {
>>> +        if ( uart != NULL && serial_irq(SERHND_DTUART) > 0 )
>>> +        {
>>> +            vpl011->base_addr = uart->base_addr;
>>> +            vpl011->virq = serial_irq(SERHND_DTUART);
>>
>> This seems a bit pointless to call serial_irq() twice. How about add a field in
>> vuart_info to return the interrupt number?
>>
>>> +        }
>>> +        else
>>> +            printk(XENLOG_ERR
>>> +                   "Unable to reuse physical UART address and irq for vPL011.\n"
>>> +                   "Defaulting to addr %#"PRIpaddr" and IRQ %u\n",
>>> +                   vpl011->base_addr, vpl011->virq);
>>> +    }
>>> +
>>>        /*
>>>         * info is NULL when the backend is in Xen.
>>>         * info is != NULL when the backend is in a domain.
>>> @@ -661,7 +681,7 @@ int domain_vpl011_init(struct domain *d, struct
>> vpl011_init_info *info)
>>>            }
>>>        }
>>>
>>> -    rc = vgic_reserve_virq(d, GUEST_VPL011_SPI);
>>> +    rc = vgic_reserve_virq(d, vpl011->virq);
>>>        if ( !rc )
>>>        {
>>>            rc = -EINVAL;
>>> @@ -673,12 +693,12 @@ int domain_vpl011_init(struct domain *d, struct
>> vpl011_init_info *info)
>>>        spin_lock_init(&vpl011->lock);
>>>
>>>        register_mmio_handler(d, &vpl011_mmio_handler,
>>> -                          GUEST_PL011_BASE, GUEST_PL011_SIZE, NULL);
>>> +                          vpl011->base_addr, GUEST_PL011_SIZE, NULL);
>>
>> So you are making the assumpption that the UART region will be equal to (or
>> bigger) than GUEST_PL011_SIZE. There are definitely UART out where the
>> MMIO region is smaller than 4K.
>>
> 
> Sorry. I got a few confused here, since I am not very familiar with pl011/UART knowledge.
> 
> Problems will occur when UART region is bigger than GUEST_PL011_SIZE, since we
> are only considering MMIO region of [vpl011->base_addr, vpl011->base_addr + GUEST_PL011_SIZE], right?

It is in fact the other way around. The problem will appear if the host 
UART MMIO region is smaller than the one we will emulate for the guest 
PL011.

> 
> So I shall add the justification like
> ASSERT(uart->size <= GUEST_PL011_SIZE);

I think this would want to be a proper check so distro users would get 
an error if they are trying to use this feature on such platform.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Mon Oct 11 10:51:52 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 10:51:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.205739.361124 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZsuL-0001yr-0m; Mon, 11 Oct 2021 10:51:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 205739.361124; Mon, 11 Oct 2021 10:51:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZsuK-0001yk-U5; Mon, 11 Oct 2021 10:51:48 +0000
Received: by outflank-mailman (input) for mailman id 205739;
 Mon, 11 Oct 2021 10:51:48 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=pkLr=O7=citrix.com=roger.pau@srs-us1.protection.inumbo.net>)
 id 1mZsuJ-0001yc-Pi
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 10:51:48 +0000
Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 4f10142a-be32-44f5-9916-6b532c55ee6c;
 Mon, 11 Oct 2021 10:51:46 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4f10142a-be32-44f5-9916-6b532c55ee6c
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1633949506;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=yOc1FC3dq5is9drg++qboHvhgNwrvGJC92b65vHy0Pw=;
  b=K52Q656JeiFbRVdWBakUXeyxOVZt+YDAD7YsPCvQyLJtAaaiXAYRbqji
   VxCrglcdlMHxHksNgXsO3RwwfCbxG7ZB7SS/mlNJ2kzm9Ygtk8kAOAKmC
   NMhmND33ejdAddKsXGJPCEEAiP5T4s66FrVsLZorgDz6uRqVYI0nD2Md/
   o=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: eIFNPcpZUX1R1K7BQz28WmjUFiGAHPoFl30yGMQ0z4WHD5F3Hb+agy9WzSFL6gkL4+FcLMBFmY
 cyi5kqagnmtPCdt6vfD5QH8z0OtdqTZfZomkLRAB9muqjdrxXXbiDHiNiNxNZ7D8goXyVjxOO/
 ESDzUoiCheM8mvvxENnRYfLqzCStqK1NMjCun5Un0kYTjnA/AMRAqAFHE8xgpEinGKvrzY3OKQ
 kIqMM2QhRnKTIb4ScBRhpdXwdOdp6SEf7h2cZmgIuTy7SWTBYajdeNSw4RyV5ewWqoxRvx6sfj
 0QFG5PyMx3ZaN5P81F48Rgmq
X-SBRS: 5.1
X-MesageID: 54896848
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:4vMaG6mIwHNt218oBsiQf+Do5gyPIERdPkR7XQ2eYbSJt1+Wr1Gzt
 xIXUGyGPamPM2HyfNp2ad6yoEhT68WDzN4wSQFo/3pgEyMWpZLJC+rCIxarNUt+DCFioGGLT
 Sk6QoOdRCzhZiaE/n9BClVlxJVF/fngqoDUUYYoAQgsA185IMsdoUg7wbdg2tcx2YHR7z6l4
 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc
 s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4
 MVGi7PpFCMFBaH3peJMdhxmEyxnDIQTrdcrIVDn2SCS50jPcn+qyPRyFkAme4Yf/46bA0kXq
 6ZecmpUKEne2aTmm9pXScE17ignBNPsM44F/Glp0BnSDOo8QICFSKLPjTNd9Gps1pEQTaqOD
 yYfQRBjdE2baRhrAA8WIckbnvqH3nfZdwQN/Tp5ooJoujOOnWSdyoPFMcXXUsyHQ91PmUSVr
 X6A+H72ajkkM9iYxSuA42ibrObFliPmW6ofDLS9sPVthTW7xGYeFRkXXluTuuSihwi1XNc3A
 1Qd5y4GvaU0skuxQbHVQBmQsHOC+BkGVLJ4EfA+6QyL4rrZ5UCeHGdsZi5MbpkqudE7QRQu1
 0SVhJX5CDp3qrqXRHmBsLCOoluaIyEVMGtEfi4CQgst6sPm5oo0i3rnRNt5DLS8iNGzHDjq2
 i2LtwA3nbBVhskOv42g5kzOiT+oopnPTyY26x/RU2bj6Rl2DKaMYYCy5B7j9+RRM4+DR3GIp
 n1CkM+bhN3iFrnUynbLGr9UWuj0ubDVa1UwnGKDAbEx/AqCoiOHUbtc2wx4dWJsDMYJYA7AN
 Rq7VRxq2LdfO36jbKlSao23Ctg3waWIKekJRsw4ffIVPcAvLF7vEDVGIBfKhTi0wRdEfbQXY
 M/DKa6R4WAm5bOLJdZcb9wW1qM33WgAzGfXSIGTI/+PgOfGOiD9pVvoNjKzggEFAEGs/FW9H
 zV3bZLiJ/BjvAvWOHS/HWk7dwFiEJTDLcqqw/G7j8baSuacJEkvCuXK3ZQqcJF/kqJem4/gp
 y/mAR8JkAWm3CGZcm1mj0yPjpu0B/6TSlphbEQR0auAgSB/Me5DEo9OH3fIQVXX3LM6lqMlJ
 xX0U86BHu5OWlz6F8c1NvHAQHhZXE3z32qmZnP9CBBmJsIIb1GZq7fMI1q0nAFTX3XfiCfLi
 +D5vu8tacFYHFoK4Qe/QK/H8m5dSlBEwLgsABCSfoUKEKgumaAzQxHMYjYMC5hkAT3IxyeA1
 hbQBhEdpOLXpJQy/sWPjqeBx7pF2cMvdqaDN2WEv7uwKwfA+W+vnd1JXOqSJGiPX2Lo4qSyI
 +5SyqikYvEAmV9Ltat6Eqpqkv1it4e++ecCw1Q2BmjPYnSqFqhkfiuM0/5Qu/Af3bReowa3B
 B6Co4EIJbWTNcr5O1cNPw55PP+b3PQZl2CKv/Q4KUn3/gFt+7+DXRkANhWAknUFfrB0LJkk0
 aEqv8tPs16zjR8jM9CniCFI9jvTcixcAvt/7pxDWd3lkAsmzF1GcKfwMC6u7cHdcchIP2krP
 iSQ2PjIiYNDyxeQaHE0D3XMg7ZQ3MxcpBBQwVYeDF2Vgd6Z1OQv1Rhc/DlrHARYyhJLj7B6N
 mRxbhAnIKyP+3FjhdRZXnDqEAZEXUXL9kv0wloPtWvYU0j3CTCdcDxjYb6ArBID7mZRXjlH5
 7XJmm/qXAHjcNz1wiZvC1VurObuTIAp+wDP8Cx98x9pw3XujeLZv5KT
IronPort-HdrOrdr: A9a23:fqb7iqko5sqf1GRO/qw+cR12l0LpDfIo3DAbv31ZSRFFG/Fw8P
 re+8jztCWE7Ar5PUtKpTnuAsW9qB/nmqKdgrNwAV7BZmfbUQKTRekJgLcKqAeAJwTOssJbyK
 d8Y+xfJbTLfD1HZB/BkWqF+gAbsbu6zJw=
X-IronPort-AV: E=Sophos;i="5.85,364,1624334400"; 
   d="scan'208";a="54896848"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=cnjGZWzM1Zmne+By9GGXPlwpPJHZbRh+qDOlGFTlzVcvWSUvSfek7dBlZRPsyzZGzRn+K8JRVdBtgkjMr7ynUc8zWaV3w4VkjwvpBhEWk37ANy6TDnvPcRTWKaTcb+aX8fY4+1AcLK+jewPX4EQMeHDhkpH09lQMkbw8WmWfGVNut47MvArGVTBXvz32IJHGsShtm4S7aLtok92Z7UNdCTRpHg/Hhl9TdH9HNHTbBzFrhLLjxtUvDHcNya0fvrDkKeUdLEjS5TcyPSNI5+BNR+OT65O59vopKWN6YUReSyiM9758RAmvxyQgThqNpBiD2EmPITmths2eU5SIVQhF7w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=w475Y4obhiAZXFhuzgyXVss5IH9ghhVXUDZsncRBuFc=;
 b=adW0jx+5n0j9TREPhv8b0SbECEFYBBqEgTSujRgp5T/U30dAPI5vm7AFxrudaaUNgYAINST+sw3whb5JsZ5kfJgQsaxgNEzkc+heE65QgsA8IoacrDmotpLvQ884FvugfNO/oozmIUTFGL3d3eQ08NiSPz3Q3JZjzJw4lZa3E1GHYb7vgGb9lYJ5KQjjwlgayMBimrE7yRGs43PYEZNykUNVZO4mvCraUF2xyNtKBfV4bkKLex5XdP8NEHHqGDSCjdeZ86PIJbabbsDaXHh6hsaoN6rGBxSNApFtnRWv5X+32S+MWZ0xRBLA0RfDXiUfls6/S3KlYGKhrrjUCVV2tw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=w475Y4obhiAZXFhuzgyXVss5IH9ghhVXUDZsncRBuFc=;
 b=D3nOzdP9Lrcs6Z6pl7DsGzEHKNoBSvTw8o+aAH3DuVmcJmxfQY1yA+JWgyAAOD7nNTLF1A7C9g3OZ1KtEFgmyPJu2OWPVfORZz3eVG0tmwljg/Tx99iKR/plodWaf3+pll0WvlV6TtfCwsOxB2Bsly0A1+21bx5kPKO0eEp3a+4=
Date: Mon, 11 Oct 2021 12:51:03 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Rahul Singh <rahul.singh@arm.com>
CC: <xen-devel@lists.xenproject.org>, <bertrand.marquis@arm.com>,
	<Andre.Przywara@arm.com>, Stefano Stabellini <sstabellini@kernel.org>, Julien
 Grall <julien@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>, George Dunlap
	<george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>, Jan Beulich
	<jbeulich@suse.com>, Wei Liu <wl@xen.org>, Paul Durrant <paul@xen.org>
Subject: Re: [PATCH v5 08/11] xen/arm: Enable the existing x86 virtual PCI
 support for ARM.
Message-ID: <YWQXF2vDaWQvi+bT@MacBook-Air-de-Roger.local>
References: <cover.1633540842.git.rahul.singh@arm.com>
 <9bdca2cda5d2e83f94dc2423e55714273539760a.1633540842.git.rahul.singh@arm.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <9bdca2cda5d2e83f94dc2423e55714273539760a.1633540842.git.rahul.singh@arm.com>
X-ClientProxiedBy: LO2P265CA0305.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:a5::29) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 4e548546-0619-4175-d2b8-08d98ca507cd
X-MS-TrafficTypeDiagnostic: DM5PR03MB3146:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <DM5PR03MB3146A9186037F1968370B3428FB59@DM5PR03MB3146.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: +R2Gl6VGMjz7riNVSBrC3PXMetIBhgtdf82IwnC5PigqnygAxefMjKqRLQm2HODGMplcpVcfTMAwaUrmaEzknGLqFrYncGJHfoDZiFBRae6D419c3ORH8aZEveOHDR//ZYALsHHNp6U1drm+qjVLGG5n4jgoJUg/GWHV2qf0JUAEBR1OmNpkVv8E2gVAJKbk/jF4CrTC//nmNW6rfddSEeLSCn9pecOWRLk+QPozIezguqlxM2n+3zQoRUufEdHSMmm29AdtttX80HXckIHxTWc7LMKOR65Kn484EBMBFCPngQ1Y0ZPn7xmXiVvKqmXlwlP3e4+WXwSCxJ/xQfBlFwr9LxMc/68I8Ch33kwfEbleieANYe16iPiRu3CGfp1d+kwrF3E694C2K1q0/CkGfKRYG9/3VWYDxv3/2/mD0ko8XG/PleTeYVklHRybx4XHNPVT2F/V4KDFE/l0hl3yFi0aM1aTWTJP8FUEXol0XzkGDOC6wmuYOIpME8zENqd8WUcC4+Kp2FMazk2SleyESTdnnhMr4N3a5Jtn7gZJlTyLPtscjJLwDVsjHKBScg3TvdpJ/y8YPhqA0zkVnKsXoHz67lkswKFZc0K0TeU228h/xLE8dbAfqUar7++Worv/GSJhFKVCWSWPqHDGwxwTrRyo/pi1DLfWFA0cHEX5XtArdhBMRD7obY7rjvTMYUzEs9kS7NpZ5G/yMNUgl0ZRYhH7XXfkcNDyRq3JEgzE5Dg=
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(316002)(66556008)(66476007)(4326008)(6666004)(6486002)(54906003)(83380400001)(6916009)(5660300002)(9686003)(8936002)(956004)(86362001)(6496006)(186003)(7416002)(508600001)(38100700002)(2906002)(26005)(85182001)(8676002)(66946007)(2004002)(67856001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bEJWRHJ3ZndCd210Q2JsNWIyWG13NnpiNTBqMkxOK0JpcndicUQ2UzVqWFJk?=
 =?utf-8?B?MHpneFVBZlo1ZTc5QTZZa1ZjbmQ2dEwyNFFTR2VycXBiQS9jRWJjWjJuQWdX?=
 =?utf-8?B?NUpZVCsxVldwdG4rQnVWTDdKcStsYURlVVNkeXFXTmMvcEFxZEtZMk53MmJy?=
 =?utf-8?B?M0tqZ1p4UWtLTFNOV3V1VDEwWWZnRG9WTEM0S090M3NrVmZBMDJ0RTVHZGN2?=
 =?utf-8?B?TGVaRTFzcUlFNnp0a2lEalFhZXRXZHUvS2pyTkUwTDJGcFlVdEl3NXgzdldI?=
 =?utf-8?B?NUtEMUlZLzRBRTJVYXF5QUd3S2J4NWpBTGdVSXY0bEdFSWtBSm9OS2Jka1hr?=
 =?utf-8?B?WGppandMdHl3UWRpS2Z4Vk5ydFUzY2JZU1c4dXV5ZVhLc3k0bjZHVUN5VmRp?=
 =?utf-8?B?ZEJOVUU5SVAyNUxDZzFDRDNqdDdnWG92VnkxT2xMcmxUR3ZrTkUzdDdPZ2M4?=
 =?utf-8?B?cGdsclduL2dlV2M5dnJuNEFoWWZMMGJRWkRqdVBSdlljVU54UkRmYXJXSmNK?=
 =?utf-8?B?bFo4bjVVZVFUNlVicjVBOHpmTXE5QmR3SmRQRi9UY2RPeVg0TzlwQ2c0YVJD?=
 =?utf-8?B?blhIQ3VYM1VUUnp5cFdHM0xSM2p6Y29zR09qMDB2T2dWbnJxcU1pMUtCSk5x?=
 =?utf-8?B?MlBxVEIxaSszQi9FN2lBVjk1ZGt4V2k4NFgxMDZnVFdNOWs1Mjk1RmJiTWF6?=
 =?utf-8?B?YXNiM056VDdURjNEbVdwV1pKNUpiQnc2ZjU4TGE4V0VjdTI4eTdZejhFSkdW?=
 =?utf-8?B?ak9JWlppeng3QVlIVk9xVVBKZVpVdTBnSTAvK3FkSDhvSkY2U2NDdTNxbFdi?=
 =?utf-8?B?OXpSYXhuNTRCMGRCdlUybzErbUNnTXIwMjJ5S0JTQ2JkeXVYc0N2MnovUmVB?=
 =?utf-8?B?WVN2SjZDaDVZVEVjR0lYK3RZSTJvdFlEWkE3YXQ5aUhFRk84SzMxNHl1QjlF?=
 =?utf-8?B?QWZXdEt1YnVnQ2dmd2Y4UStTRjRuU1NPaHYyVjlTZmFTR1E5M3ZjbWpPNEky?=
 =?utf-8?B?ODRMZ2dXMnozaWRUVkcyTHJySUFGdDdLSlhBNm1PV0I2ME5wcG03dk5vMEFz?=
 =?utf-8?B?VVhDSDcyY3ZJSTJoUGNtQnVRU2c3bE5lbHBjZlhDbFc0ay9aRGxFeGVjS0Np?=
 =?utf-8?B?blJRcTVKcUU3TWpxS3hzT2lqUndvZ25OUm11L0lwQTMvTGNyQVNNSjF5bWdk?=
 =?utf-8?B?b01MclZEOWplY0p2aFdUVVI2WVd3WmRtM0VzRmI3c2tscGJnUnVvanZEcWkr?=
 =?utf-8?B?Q2xRbEhocjBuaW0wbng1MCtEOUJ6d0Z3VXNLeFphNjlpVUNLSy93THFXZjBR?=
 =?utf-8?B?VlM4NjQ1YkVKT011TEEwbVUzRlo2NEs5SGtEb2dWcWliejZXNndzYWpLN1p3?=
 =?utf-8?B?K2E2ZWppWFU4d0IxMDF6eHhMYjZ0YkFqa2hvZDZ3YXZQd0JiNysrZHFYR1Fv?=
 =?utf-8?B?ZTROSFZKL0JKdlhtaVhoWCtlakd4alJNS25DV0NmL2I2T2t5dVM1SEtIZHR6?=
 =?utf-8?B?SmxUTEN3bExIQlBTdXlmd3FNbTk0Tit4TnlXQXZKNTd3b2NnNXNMM2R5VHla?=
 =?utf-8?B?d2NockRxM3J6bE5pekxidVNuOWdpWHQrb2kvdlJrbTZPdUhLcmthVFc3Y2Yr?=
 =?utf-8?B?STdiMk9vd1lLYjVsTFFiUXFuYm15K2x4ZnY0bERkNEZCdy93RkZvaEVhdEhu?=
 =?utf-8?B?MHY0RU1waTF1VExnc3NWeEo4Nk1sanM1TjhXeFcwMTNweC9YR3hFNllHcHFE?=
 =?utf-8?Q?wWRBIWpBJwUMQz6MRyeN79Gl01cOsffVM8l8St4?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 4e548546-0619-4175-d2b8-08d98ca507cd
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2021 10:51:07.9441
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: M3GzIJB2fNb/p65pYOcGKB/+oaCwmVSwX2tPWlL5J2+IbUQ5KCzik1a/MHhi4gEteeHPENSmSt9lo/sOQ90hpw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB3146
X-OriginatorOrg: citrix.com

On Wed, Oct 06, 2021 at 06:40:34PM +0100, Rahul Singh wrote:
> The existing VPCI support available for X86 is adapted for Arm.
> When the device is added to XEN via the hyper call
> “PHYSDEVOP_pci_device_add”, VPCI handler for the config space
> access is added to the Xen to emulate the PCI devices config space.
> 
> A MMIO trap handler for the PCI ECAM space is registered in XEN
> so that when guest is trying to access the PCI config space,XEN
> will trap the access and emulate read/write using the VPCI and
> not the real PCI hardware.
> 
> For Dom0less systems scan_pci_devices() would be used to discover the
> PCI device in XEN and VPCI handler will be added during XEN boots.
> 
> Signed-off-by: Rahul Singh <rahul.singh@arm.com>
> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
> ---
> Change in v5:
> - Add pci_cleanup_msi(pdev) in cleanup part.
> - Added Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
> Change in v4:
> - Move addition of XEN_DOMCTL_CDF_vpci flag to separate patch
> Change in v3:
> - Use is_pci_passthrough_enabled() in place of pci_passthrough_enabled variable
> - Reject XEN_DOMCTL_CDF_vpci for x86 in arch_sanitise_domain_config()
> - Remove IS_ENABLED(CONFIG_HAS_VPCI) from has_vpci()
> Change in v2:
> - Add new XEN_DOMCTL_CDF_vpci flag
> - modify has_vpci() to include XEN_DOMCTL_CDF_vpci
> - enable vpci support when pci-passthough option is enabled.
> ---
> ---
>  xen/arch/arm/Makefile         |   1 +
>  xen/arch/arm/domain.c         |   4 ++
>  xen/arch/arm/domain_build.c   |   3 +
>  xen/arch/arm/vpci.c           | 102 ++++++++++++++++++++++++++++++++++
>  xen/arch/arm/vpci.h           |  36 ++++++++++++
>  xen/drivers/passthrough/pci.c |  18 ++++++
>  xen/include/asm-arm/domain.h  |   7 ++-
>  xen/include/asm-x86/pci.h     |   2 -
>  xen/include/public/arch-arm.h |   7 +++
>  xen/include/xen/pci.h         |   2 +
>  10 files changed, 179 insertions(+), 3 deletions(-)
>  create mode 100644 xen/arch/arm/vpci.c
>  create mode 100644 xen/arch/arm/vpci.h
> 
> diff --git a/xen/arch/arm/Makefile b/xen/arch/arm/Makefile
> index 44d7cc81fa..fb9c976ea2 100644
> --- a/xen/arch/arm/Makefile
> +++ b/xen/arch/arm/Makefile
> @@ -7,6 +7,7 @@ ifneq ($(CONFIG_NO_PLAT),y)
>  obj-y += platforms/
>  endif
>  obj-$(CONFIG_TEE) += tee/
> +obj-$(CONFIG_HAS_VPCI) += vpci.o
>  
>  obj-$(CONFIG_HAS_ALTERNATIVE) += alternative.o
>  obj-y += bootfdt.init.o
> diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
> index 36138c1b2e..fbb52f78f1 100644
> --- a/xen/arch/arm/domain.c
> +++ b/xen/arch/arm/domain.c
> @@ -39,6 +39,7 @@
>  #include <asm/vgic.h>
>  #include <asm/vtimer.h>
>  
> +#include "vpci.h"
>  #include "vuart.h"
>  
>  DEFINE_PER_CPU(struct vcpu *, curr_vcpu);
> @@ -767,6 +768,9 @@ int arch_domain_create(struct domain *d,
>      if ( is_hardware_domain(d) && (rc = domain_vuart_init(d)) )
>          goto fail;
>  
> +    if ( (rc = domain_vpci_init(d)) != 0 )
> +        goto fail;
> +
>      return 0;
>  
>  fail:
> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
> index c5afbe2e05..f4c89bde8c 100644
> --- a/xen/arch/arm/domain_build.c
> +++ b/xen/arch/arm/domain_build.c
> @@ -3053,6 +3053,9 @@ void __init create_dom0(void)
>      if ( iommu_enabled )
>          dom0_cfg.flags |= XEN_DOMCTL_CDF_iommu;
>  
> +    if ( is_pci_passthrough_enabled() )
> +        dom0_cfg.flags |= XEN_DOMCTL_CDF_vpci;

I think I'm confused with this. You seem to enable vPCI for dom0, but
then domain_vpci_init will setup traps for the guest virtual ECAM
layout, not the native one that dom0 will be using.

> +
>      dom0 = domain_create(0, &dom0_cfg, true);
>      if ( IS_ERR(dom0) || (alloc_dom0_vcpu0(dom0) == NULL) )
>          panic("Error creating domain 0\n");
> diff --git a/xen/arch/arm/vpci.c b/xen/arch/arm/vpci.c
> new file mode 100644
> index 0000000000..76c12b9281
> --- /dev/null
> +++ b/xen/arch/arm/vpci.c
> @@ -0,0 +1,102 @@
> +/*
> + * xen/arch/arm/vpci.c
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; either version 2 of the License, or
> + * (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + */
> +#include <xen/sched.h>
> +
> +#include <asm/mmio.h>
> +
> +#define REGISTER_OFFSET(addr)  ( (addr) & 0x00000fff)
> +
> +/* Do some sanity checks. */
> +static bool vpci_mmio_access_allowed(unsigned int reg, unsigned int len)
> +{
> +    /* Check access size. */
> +    if ( len > 8 )
> +        return false;
> +
> +    /* Check that access is size aligned. */
> +    if ( (reg & (len - 1)) )
> +        return false;
> +
> +    return true;
> +}

There's a vpci_access_allowed which I think you could generalize and
use here, there's no need to have this duplicated code.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Mon Oct 11 10:56:57 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 10:56:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.205752.361135 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZszE-0002hu-N9; Mon, 11 Oct 2021 10:56:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 205752.361135; Mon, 11 Oct 2021 10:56:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZszE-0002hn-K5; Mon, 11 Oct 2021 10:56:52 +0000
Received: by outflank-mailman (input) for mailman id 205752;
 Mon, 11 Oct 2021 10:56:51 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mZszD-0002hh-Pb
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 10:56:51 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mZszD-0003I6-LR
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 10:56:51 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mZszD-0001JD-KL
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 10:56:51 +0000
Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89)
 (envelope-from <iwj@xenproject.org>)
 id 1mZszA-0000pZ-2h; Mon, 11 Oct 2021 11:56:48 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date
	:Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From;
	bh=Gp7FEYIValsTd7qVjWMOFYbEzpSwJt1AHwUmFDj4Bo0=; b=dZaOR27H/53M6UAVpKiBDO1wWC
	A5Sd2ZqFGMXgMwVf0lYTOshUqJ/kWnaYoBHwFzuOrYr3UoTZXB82asRNhfYiuhwqj+PfOkNr9Eiv5
	TfRPd2tuKBsSK61mrkWJI1d5DbmBDItGiB5z1vBhLsWklEtAOkXJ+OLSw1JNz9aKqJnU=;
From: Ian Jackson <iwj@xenproject.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <24932.6255.815797.597475@mariner.uk.xensource.com>
Date: Mon, 11 Oct 2021 11:56:47 +0100
To: Jan Beulich <jbeulich@suse.com>
Cc: "xen-devel\@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
    Kevin Tian <kevin.tian@intel.com>
Subject: Re: [PATCH 0/2] VT-d: correct / extend workaround(s) leaving an IOMMU
 disabled [and 1 more messages]
In-Reply-To: <ced41449-6aa2-3b20-77cd-78dafcad4bc7@suse.com>,
	<a385938d-243e-1790-da1f-be7c4f5f2c3f@suse.com>
References: <ced41449-6aa2-3b20-77cd-78dafcad4bc7@suse.com>
	<a385938d-243e-1790-da1f-be7c4f5f2c3f@suse.com>
X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu)

Jan Beulich writes ("[PATCH 0/2] VT-d: correct / extend workaround(s) leaving an IOMMU disabled"):
> Ian - I'm also Cc-ing you since this feels like being on the edge
> between a new feature and a bug fix.

Thanks.

I think 2/ is a new quirk (or, new behaviour for an existing quirk).
I think I am happy to treat that as a bugfix, assuming we are
reasonably confident that most systems (including in particular all
systems without the quirk) will take unchanged codepaths.  Is that
right ?

I don't understand 1/.  It looks bugfixish to me but I am really not
qualified.  I am inclined to defer to your judgement, but it would
help me if you explicitly addressed the overall risks/benefits.

But when reading the patch I did notice one thing that struck me as
undesriable:

> --- a/xen/drivers/passthrough/vtd/iommu.c
> +++ b/xen/drivers/passthrough/vtd/iommu.c
> @@ -750,27 +750,43 @@ static void iommu_enable_translation(str
>              if ( force_iommu )
> -                panic("BIOS did not enable IGD for VT properly, crash Xen for security purpose\n");
> +                panic(crash_fmt, msg);
...
> +        if ( force_iommu )
> +            panic(crash_fmt, msg);

Does this really mean that every exit path from
iommu_enable_translation that doesn't enable the iommu has to have a
check for force_iommu ?

That seems like a recipe for missing one.  And I think a missed one
would be an XSA.  Could we not structure the code some way to avoid
this foreseeable human error ?

Ian.


From xen-devel-bounces@lists.xenproject.org Mon Oct 11 10:57:05 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 10:57:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.205753.361146 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZszQ-00032p-V2; Mon, 11 Oct 2021 10:57:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 205753.361146; Mon, 11 Oct 2021 10:57:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZszQ-00032i-S0; Mon, 11 Oct 2021 10:57:04 +0000
Received: by outflank-mailman (input) for mailman id 205753;
 Mon, 11 Oct 2021 10:57:03 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=9TNE=O7=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mZszP-00031j-9r
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 10:57:03 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id f5d79684-2a81-11ec-80d3-12813bfff9fa;
 Mon, 11 Oct 2021 10:57:01 +0000 (UTC)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2107.outbound.protection.outlook.com [104.47.18.107])
 (Using TLS) by relay.mimecast.com with ESMTP id
 de-mta-34-qHaUE0MVMGKDo-iZp6izJw-1; Mon, 11 Oct 2021 12:56:59 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0401MB2335.eurprd04.prod.outlook.com (2603:10a6:800:2e::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.25; Mon, 11 Oct
 2021 10:56:57 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4587.026; Mon, 11 Oct 2021
 10:56:57 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS9PR06CA0139.eurprd06.prod.outlook.com (2603:10a6:20b:467::30) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.21 via Frontend
 Transport; Mon, 11 Oct 2021 10:56:56 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f5d79684-2a81-11ec-80d3-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1633949820;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=DB7jtOgJUj8fwbhyYndlSR4Uu8vNNru+gEh8/XSgjHg=;
	b=d/7Ki5qSFVPoddQnIbEVLNoeH/cZuwBnBXnFRx7aWH9Diok3QXQIh8mZ1kusUgAnQItF/C
	+ptz/J3Yws/EVBxT03RjVTacxuJ27KECZ92VWMe17CHfqG5r4QAV9N/vICGKK9sbqcHaaO
	NaF+ntGcozh+jl0+1jdoGGnmcG9sfog=
X-MC-Unique: qHaUE0MVMGKDo-iZp6izJw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=F38LaftQBE9/+UsBVmbeMbKXeYy3cKw5sNjmmfiea/Ps1pql+Tax+VcjmpsFCOR6xlC4pCsYhb0KV856h6WhqIkSS49SJ69QXv11ljj+I4uagkpB7xwyakbPutCkPrtAmQ4z1MU0RhppLMR+qmxt4noQnFfF4WeTTIbzp2sTplRLjE5HoIDQWpdXQJsqv0qPXfatUomCbdij0VJpIZaZNigFFA3w8HkQI+/BC91Pa9jP+mqN+zp/zI7K3kcwE54GmA4o9SNnAWBSEDARdC1qKGPwDLCkO9Ii0j6BuwiD2JngF04RHu87fbP6W8arpZV63u3qMmklfuqaqgru8e5OBw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=DB7jtOgJUj8fwbhyYndlSR4Uu8vNNru+gEh8/XSgjHg=;
 b=VojSVT3TfPezxS9yWzrJz+7wwp0OyvCjWVi4KJI4VwUBfv2kt6plFPj0Gi4v1DsCtaL3/h0BxnyXpleFrhTsMxYLC8IL05kF0/iUFY2Gve6ZeaPnHyl+kfIKWi6WTf31nDkaZihYkkXhXkIkgmvJZhQR8yqNO1mWGXg4h6wXFCzWlyT/5tcj+yda/97vzYMF7EeoD3S7TRLZxWWzzRUF3Weaeb7d/0cWFvghijlLspBb56LqXQPEMe/agzvTAHZ2RyvuIyurX+AMnbRhOg1/cKGUF6o3uQ6L0fE440dff2zFhzs0svmqzgvtxZ4MBwCXyeqONxeUk+ekY0alHv66cQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [XEN PATCH v7 20/51] build: avoid re-executing the main Makefile
 by introducing build.mk
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>, xen-devel@lists.xenproject.org
References: <20210824105038.1257926-1-anthony.perard@citrix.com>
 <20210824105038.1257926-21-anthony.perard@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <87036d63-b5d4-55bf-0bb3-9b981a147f15@suse.com>
Date: Mon, 11 Oct 2021 12:56:54 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <20210824105038.1257926-21-anthony.perard@citrix.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0139.eurprd06.prod.outlook.com
 (2603:10a6:20b:467::30) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: b650eecc-648f-4801-b09f-08d98ca5d7fb
X-MS-TrafficTypeDiagnostic: VI1PR0401MB2335:
X-Microsoft-Antispam-PRVS:
	<VI1PR0401MB233508228FE7022618EA2D9CB3B59@VI1PR0401MB2335.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	ljz2GSF2QhZntGp4K/9jBgdQvpbe0tABmupC2nyZv6/YIneBC91TQF3gwnIUJWzF5vTsk5fcZRfr5fwDdbS/vMrxTwIjIbOT/d0dfTmooXxjoA6SctT2MkbwsZtS1BKr4LX3CL3UNkMNjLtVRUVZArMbQOO2Abq9V9Lbk96913sm5vxEMZT63MkOuxeMDJSxfseyTSuyDjfgVsuSH7w37LvacdmIheIo3L+Zm9ZQGrX8Dg9Lham8yvElsyPM/2bEVnmOeqhdB8r2vcBscHkDIiUlStaVp0GpBThmWx5x3TFPadVjYHU0G79JfJwJlYH4AsnLDUmebrOY7t9DCP5ZzOvD1wgv57ZTuhv5WXvfT3qSew5ukuU1CoF/VFqVzHbspOxeLFql7ZijXhn84UpRijr3DyBbdtLsriYp8wBlVDeCFBNaBS56Afwhq9sGDVBmTmWtOMd0GePjrLa64zmx2+45kpnTEBq5bPdWF/tvVGUMUETNlvfYWODAEGgHSu7y8tD2BC6/WXcPBN1b70TbLH1Ms++wvj7KFHrRIW5kewfCjWddnvMtFAyx6wWREEET3Ub9f+DLX8Mv8zKqz98oIsZk7rktVGJSt7XGp2xpnKMojeQ4XKlRbit9vyop/bLOY3CKluVv4k3lbRzxE9KmHsyU4TPQALeBNNDI1w4saewU/cujmExX29t0Vysx+EmFPRi+O7AEYqB89SdVY9wnDGiKspewjLLMQJTiTOue8vABs2FZJpB3zhJXvMESrCVi
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(16576012)(956004)(2616005)(53546011)(83380400001)(86362001)(6486002)(54906003)(316002)(4326008)(5660300002)(38100700002)(66476007)(66556008)(31696002)(508600001)(8936002)(8676002)(6916009)(36756003)(26005)(31686004)(2906002)(186003)(66946007)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?MW1jQjdsLzJVR2llTHRFK3pPT0FCak5jbnhLem1yRnJ1bFp6WVNCREhRY2dk?=
 =?utf-8?B?SXdBVlhyem9Qa1NtUDBYQ2hZc3J4VHlGWkl6cmhZZjh2NG91c3JtdkJhcTQ3?=
 =?utf-8?B?ZXJtVW81RFljcmVMdE81UU10aFVud2FLeDZwMzBZemhVMjc0QkNHRlJIZGFV?=
 =?utf-8?B?ZFI1RzhSUS9jdXEyKy9ENlZUcGlrLzE4bERXNW1uMnlXRFUzTGZKT2RzZEtO?=
 =?utf-8?B?SFBaRVRRczVBcVJaVVF5VHZQN3BkZi95YkJvcGFPdHM3L0xxVDVMdmZHSVFq?=
 =?utf-8?B?ZDluZm9rTzJMTUZMajNCZUZ2c1drcVIzdks2cWVobkcwWUJ1d2d0R3JMaDlq?=
 =?utf-8?B?b1JyeHRxdkxMalFuQUlJTHdpRkdyL2hNazV5TU1RUWkzdlhDZGZZZEZUWVZB?=
 =?utf-8?B?RHdrazRjbXg0bm9Xa2IyRDc2TzFLUmYrS2Z6QnJjVmh2dWVqYzl6dWlaV1VR?=
 =?utf-8?B?ZlV2cFNKSUE1enhnYnVpeVFQcmcyVUtkdnU0aFBZT2lZSjBGWFJyWTlFVW50?=
 =?utf-8?B?a3ZwQ0M0QVd1YmlmeXE5VWo2MTNqUWR2L2V5S245Y0w4ZmplaG1zR1hxcWhF?=
 =?utf-8?B?WjV3bU5HNUtpNTkwVnpiT2Q3UjZtRlVSdTZIN0wvYWMwOUQ0WUdOVnBkZDZz?=
 =?utf-8?B?endoMENHOGpoQ0E3cFB3ZnpidnZUS3pNU3RvSU54cHlncWV1RXE5cUtGeU9h?=
 =?utf-8?B?enNuZFN1REpibDFuWXpxN2VXVFkwL25Kek9GR2ROSkRKVHRsMHNzM0w2SVhJ?=
 =?utf-8?B?dlhFZnJOVVF5M2t2U2t6eGF5TXY4dnJZaHFhc1ZkUTA1MTBvMzZaclA0S1Q3?=
 =?utf-8?B?ODdTcCtXaS9Dd1ZSOWxTdmhOQUc4QVFEMHJEOEFHMXQzYUUxSTlVeVhNMW93?=
 =?utf-8?B?SGdMVzd3ZWZSNWJLTndaV290OG9oL1M4NGFLcWdwc1FpYm55Q1FlVTV3OXdQ?=
 =?utf-8?B?NzNZNkJJNkpqRzVkWWN3V1hXWmFrWWdyRGIrMHV6M3ZOSENHQk5UcVlWZHhY?=
 =?utf-8?B?emhzeXpPaWRtQ0pFcG5JbUpSRThPZkE3MWFXR2ZUZ0ZtYnZOU0kySkFGRFJ0?=
 =?utf-8?B?bnFBODFTN05hN1g3clZNb3N6U1JleUtsNEVVWGdrcGxXeGgxc0tWUGJCc3BW?=
 =?utf-8?B?MjZtUGFLUklacU5meVdYekxPVGxxU0ExYUlNWEpmNmd3Sk16dm9xTzRoSXZK?=
 =?utf-8?B?VWkxYjlvSHNQbGs0bVowQVFhL0ZXd0NDUi9LYkU2WXEvMUFaRXl5UkF5MklJ?=
 =?utf-8?B?WFcxSGxTdHZFZGxxZUp4eExvNCtKU3U4SEM3VGtZRFFCYmVKNExBSTFrczlH?=
 =?utf-8?B?OU9EeXA2SW96bFIzSzZ0cTBoUHhhd3dCM0t0a0RERHd3R2w1Q1pvMGhFZWZZ?=
 =?utf-8?B?Z094OXVMTGlYSTVRTFZ1Z1hHYm9idkpHdmdKenVIc2t0NGdPQUtjcjhJa1NY?=
 =?utf-8?B?WU12bUxJWWVRYWdZenNGdDRlTEF4VHhkWHB5dXNSVjAyazVBM1ZrcC9DV2tT?=
 =?utf-8?B?MFZLbDQ4YXdGamp4ODNWbmpHakV6UjgvTnZlVXZLTXcyZjlBLzhOd0ZkLzlh?=
 =?utf-8?B?ZHBkbjJBRy9JMWpzamU4MjlYRkVtbjdsYnpLL0FESFFsbVNYYlArUEhicSs2?=
 =?utf-8?B?b3YzdWVYekhmOXRVSFZ5MHppUEY5YzZIL2JUR3dMRTc1STJ0VWFldlFKaG82?=
 =?utf-8?B?bEFVOFVvY2FQb0pPbVlJcFUzWWdlNFBoYkZ5bXBYQXBUa0U2M0JlT0RSK3Qw?=
 =?utf-8?Q?a2KEtrrl/fq3Zc/pMh8EB1o7uVJucKdDcmqqfdg?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b650eecc-648f-4801-b09f-08d98ca5d7fb
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2021 10:56:57.1624
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: CjZJyLqPHK5oZNOPBDF6fUR6yeS5kv1gteVIPAP3d02r4pROHtd+WGVW1YMqYMiJjud66gFEqMxM/75bEuHg8Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2335

On 24.08.2021 12:50, Anthony PERARD wrote:
> Currently, the xen/Makefile is re-parsed several times: once to start
> the build process, and several more time with Rules.mk including it.
> This makes it difficult to reason with a Makefile used for several
> purpose, and it actually slow down the build process.

I'm struggling some with what you want to express here. What does
"to reason" refer to?

> So this patch introduce "build.mk" which Rules.mk will use when
> present instead of the "Makefile" of a directory. (Linux's Kbuild
> named that file "Kbuild".)
> 
> We have a few targets to move to "build.mk" identified by them been
> build via "make -f Rules.mk" without changing directory.
> 
> As for the main targets like "build", we can have them depends on
> there underscore-prefix targets like "_build" without having to use
> "Rules.mk" while still retaining the check for unsupported
> architecture. (Those main rules are changed to be single-colon as
> there should only be a single recipe for them.)
> 
> With nearly everything needed to move to "build.mk" moved, there is a
> single dependency left from "Rules.mk": $(TARGET), which is moved to
> the main Makefile.

I'm having trouble identifying what this describes. Searching for
$(TARGET) in the patch doesn't yield any obvious match. Thinking
about it, do you perhaps mean the setting of that variable? Is
moving that guaranteed to not leave the variable undefined? Or in
other words is there no scenario at all where xen/Makefile might
get bypassed? (Aiui building an individual .o, .i, or .s would
continue to be fine, but it feels like something along these lines
might get broken.)

> @@ -279,11 +281,13 @@ export CFLAGS_UBSAN
>  
>  endif # need-config
>  
> -.PHONY: build install uninstall clean distclean MAP
> -build install uninstall debug clean distclean MAP::
> +main-targets := build install uninstall clean distclean MAP
> +.PHONY: $(main-targets)
>  ifneq ($(XEN_TARGET_ARCH),x86_32)
> -	$(MAKE) -f Rules.mk _$@
> +$(main-targets): %: _%
> +	@:

Isn't the conventional way to express "no commands" via

$(main-targets): %: _% ;

?

> --- a/xen/Rules.mk
> +++ b/xen/Rules.mk
> @@ -9,8 +9,6 @@ include $(XEN_ROOT)/Config.mk
>  include $(BASEDIR)/scripts/Kbuild.include
>  
>  
> -TARGET := $(BASEDIR)/xen
> -
>  # Note that link order matters!

Could I talk you into removing yet another blank line at this occasion?

> @@ -36,7 +34,9 @@ SPECIAL_DATA_SECTIONS := rodata $(foreach a,1 2 4 8 16, \
>                                              rodata.cst$(a)) \
>                           $(foreach r,rel rel.ro,data.$(r).local)
>  
> -include Makefile
> +# The filename build.mk has precedence over Makefile
> +mk-dir := .

What's the goal of this variable? All I can spot for now it that ...

> +include $(if $(wildcard $(mk-dir)/build.mk),$(mk-dir)/build.mk,$(mk-dir)/Makefile)

... this is harder to read than

include $(if $(wildcard ./build.mk),./build.mk,./Makefile)

which could be further simplified to

include $(if $(wildcard build.mk),build.mk,Makefile)

and then maybe altered to

include $(firstword $(wildcard build.mk) Makefile)

> --- /dev/null
> +++ b/xen/build.mk
> @@ -0,0 +1,58 @@
> +quiet_cmd_banner = BANNER  $@
> +define cmd_banner
> +    if which figlet >/dev/null 2>&1 ; then \
> +	echo " Xen $(XEN_FULLVERSION)" | figlet -f $< > $@.tmp; \
> +    else \
> +	echo " Xen $(XEN_FULLVERSION)" > $@.tmp; \
> +    fi; \
> +    mv -f $@.tmp $@
> +endef
> +
> +.banner: tools/xen.flf FORCE
> +	$(call if_changed,banner)
> +targets += .banner

To make the end of the rule more easily recognizable, may I ask that
you either insert a blank line after the rule or that you move the +=
up immediately ahead of the construct?

Jan



From xen-devel-bounces@lists.xenproject.org Mon Oct 11 11:02:56 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 11:02:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.205769.361156 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZt51-0004kJ-KT; Mon, 11 Oct 2021 11:02:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 205769.361156; Mon, 11 Oct 2021 11:02:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZt51-0004kC-Hi; Mon, 11 Oct 2021 11:02:51 +0000
Received: by outflank-mailman (input) for mailman id 205769;
 Mon, 11 Oct 2021 11:02:49 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mZt4z-0004k6-D6
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 11:02:49 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mZt4z-0003QN-AO
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 11:02:49 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mZt4z-0002G0-9A
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 11:02:49 +0000
Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89)
 (envelope-from <iwj@xenproject.org>)
 id 1mZt4v-0000qU-Rw; Mon, 11 Oct 2021 12:02:45 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date
	:Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From;
	bh=2pqDyHmkr52dBjVlsWdmGy0jYD7lEi0k7mq0Ni2avYw=; b=JQFeX/g0tvYBD1NBhMJmM4xX0n
	/9UUinxtt4BknjgHwGOa54V7VResd3iy/popj9GBZbgWIijoU1crTvH8FiG+jq2Wt6hrdEqPUcfgs
	MQ/z9tSL4xtBi4aV6nz3zYPPIulAyWHrzUDkbVsmm5esKNUXn+6pd3vBYBQnk5pfPXtA=;
From: Ian Jackson <iwj@xenproject.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <24932.6613.466204.983513@mariner.uk.xensource.com>
Date: Mon, 11 Oct 2021 12:02:45 +0100
To: Michal Orzel <michal.orzel@arm.com>
Cc: xen-devel@lists.xenproject.org,
    George Dunlap <george.dunlap@citrix.com>,
    Nick Rosbrook <rosbrookn@ainfosec.com>,
    Wei Liu <wl@xen.org>,
    Andrew Cooper <andrew.cooper3@citrix.com>,
    Jan Beulich <jbeulich@suse.com>,
    Julien Grall <julien@xen.org>,
    Stefano Stabellini <sstabellini@kernel.org>,
    Anthony PERARD <anthony.perard@citrix.com>,
    Juergen Gross <jgross@suse.com>,
    Christian Lindig <christian.lindig@citrix.com>,
    David Scott <dave@recoil.org>,
    bertrand.marquis@arm.com
Subject: Re: [PATCH v4 1/3] xen+tools: Introduce XEN_SYSCTL_PHYSCAP_vpmu
In-Reply-To: <20211011090047.8878-2-michal.orzel@arm.com>
References: <20211011090047.8878-1-michal.orzel@arm.com>
	<20211011090047.8878-2-michal.orzel@arm.com>
X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu)

Michal Orzel writes ("[PATCH v4 1/3] xen+tools: Introduce XEN_SYSCTL_PHYSCAP_vpmu"):
> Introduce flag XEN_SYSCTL_PHYSCAP_vpmu which
> indicates whether the platform supports vPMU
> functionality. Modify Xen and tools accordingly.
> 
> Take the opportunity and fix XEN_SYSCTL_PHYSCAP_vmtrace
> definition in sysctl.h which wrongly use (1 << 6)
> instead of (1u << 6).
> 
> Signed-off-by: Michal Orzel <michal.orzel@arm.com>
> Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>
> Acked-by: Nick Rosbrook <rosbrookn@ainfosec.com>
> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>

Tools:

Acked-by: Ian Jackson <iwj@xenproject.org>


From xen-devel-bounces@lists.xenproject.org Mon Oct 11 11:09:49 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 11:09:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.205777.361168 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZtBh-0005Ro-CI; Mon, 11 Oct 2021 11:09:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 205777.361168; Mon, 11 Oct 2021 11:09:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZtBh-0005Rh-8j; Mon, 11 Oct 2021 11:09:45 +0000
Received: by outflank-mailman (input) for mailman id 205777;
 Mon, 11 Oct 2021 11:09:44 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=9TNE=O7=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mZtBg-0005Rb-I9
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 11:09:44 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 61347ed5-4338-48a9-840d-2e5505db6d42;
 Mon, 11 Oct 2021 11:09:43 +0000 (UTC)
Received: from EUR01-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur01lp2058.outbound.protection.outlook.com [104.47.0.58]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-36-Fngrbl7JM-yhlE_l-obbdA-1; Mon, 11 Oct 2021 13:09:41 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB5741.eurprd04.prod.outlook.com (2603:10a6:803:df::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.19; Mon, 11 Oct
 2021 11:09:40 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4587.026; Mon, 11 Oct 2021
 11:09:40 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS9PR04CA0036.eurprd04.prod.outlook.com (2603:10a6:20b:46a::29) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.25 via Frontend
 Transport; Mon, 11 Oct 2021 11:09:39 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 61347ed5-4338-48a9-840d-2e5505db6d42
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1633950582;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=cj2s4Ep6h3MsZ/i8kx3tvEoapr0vwNyWOGWcj7wJ3Xw=;
	b=QD7wwYe2YYpDcS+RctIiz9WWcOM5wUUI4O+HLWHw7g6I+U1RjV3n7r6O03G5xxYKVomgc0
	FlFfWzAoBqUWuaIAQC9Zh0iTEgtlB3VysGAaYrim6iJRHPFDen87qRDlF3cdMhKHgnNQGP
	DsS+KwCEUaqjOiQLpPJM4PSJ90bcZUs=
X-MC-Unique: Fngrbl7JM-yhlE_l-obbdA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=bOVec5BsMoydb4pc83shMElX6A8u608ZQN3Wy0RTds8Q5DJ+uniXXXeiMkjo39wkzNR/6lkbWwA1gMARHEOIlVDs2IxWQN5/bUHcVZPqE5SCTv3aikxQetMW+epuBRWG5MYC6R5wCnq6ZT19ek6UvAicpOcflXgw0XjcVHVv6qCC+oVky/LsM/uCjx87tUy1q4vm5lSlD9/8ytKuZmu6sjgetGzhXYoz8J76Y0amf5Oc/ajY36ZNBSGVUSsKbnFMUVFdcHtLxhbh77gPURqtRYj34+fiPJ6R27u2VesvaC1v2ieYgwMJ7QboLP6CbX9xlF97FyaYCJtSYDYadtOHkA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=cj2s4Ep6h3MsZ/i8kx3tvEoapr0vwNyWOGWcj7wJ3Xw=;
 b=SkMKOKRVSC5PMqZTe12+p2iRf3A2AYhJeNPx8UAQu1sKodTo8+CzUJQiwpxQKfBb2u0Wad2c7Xr6nVxqhIQS/RhhNdgcrdQqRlGsbt6OkWvMNFcxqMvqXkghIbeZRNWXo3UsRdGinEEhNXCzVTkqsPGLElapZ2EW3avbrHbZGHX0Rg88MIkgAQrw+weyWD73wiCnrwR0tQ4FCCyHX1jT3AA+p5i96MVq48FIVxRZqN7YfpcP8v1M3riw/tS3RDjs+buvnIu+EIsQUumbkp8jSCJs0WcH+bPgx9UWiJKUav80A/ezLE2z0xI+1j7AeZ2a7jHkU85q4C1RLjFwvlkAIw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: intel.com; dkim=none (message not signed)
 header.d=none;intel.com; dmarc=none action=none header.from=suse.com;
Subject: Re: [PATCH 0/2] VT-d: correct / extend workaround(s) leaving an IOMMU
 disabled [and 1 more messages]
To: Ian Jackson <iwj@xenproject.org>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Kevin Tian <kevin.tian@intel.com>
References: <ced41449-6aa2-3b20-77cd-78dafcad4bc7@suse.com>
 <a385938d-243e-1790-da1f-be7c4f5f2c3f@suse.com>
 <24932.6255.815797.597475@mariner.uk.xensource.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <ed7632b9-5426-b351-45af-7ad3bf31d3d9@suse.com>
Date: Mon, 11 Oct 2021 13:09:38 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <24932.6255.815797.597475@mariner.uk.xensource.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR04CA0036.eurprd04.prod.outlook.com
 (2603:10a6:20b:46a::29) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: a3d53497-6fe8-4b84-e34a-08d98ca79ebf
X-MS-TrafficTypeDiagnostic: VI1PR04MB5741:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB574183BB937A225C7D07DA94B3B59@VI1PR04MB5741.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	qb0Y+bLkbssbRCWKKbOVeLFqYASFekHgtLYOabWeTwYzBSvATGeSPue2ol4cpmvlgTKQALeTZUxioH68ATgPAijtl4jGKVXuBzJY1yPesCYc+ZowabV1FL3vmEHqM2K+w8qtFKV0jrFtAs1kdp9ukHPHJjOYJ5nj+Pbd2enUdTmKoSBu1aDk6FuXjWVzBLAMQw3SVhUxnYQZ+5EPuFD5oYv9YBpREtemYMBqWDH+DuzDfqIxMvNhshV3hgqFFa+woQPUMXAdvOEDqp3ONYPRaEzqaKUF3EoU6ANfxqXsowoY/yz/2DxuaWXC3fMk9j6trxmPicl5R/9q0ANbeTyS466oK81yvRTSsP4vPBZlEWCUjcWBg5C1O6HgUf7tzBpTRry4Bocsqbji0mJEjnJ5Z7Q7CBuKGL3O8BF+oN/iaE+iFLRiz4APbkpSjcgYPMpX8te+POhJJCyM2poMA0m0ScOggEcS0FIN3hRX8pL/Mhd02bJDBeykvkuDgFLf2vcp1B+S3dlTaN1Hkj/4qUM+mEBu4Ds/S2YTD9ZcgJU8XpzhWW9sxltV4do0GsLzwXfUbgWTkQT+iL67jeaBp2OBnuY4K/soDZ3VSR5cMV8NpTzy6k/asgOnrB8WCFxDcFmixEh0nHw+eyXZ9q3I0fy9AJXPV9k5bZr9FYWnptR2lCz8tMUjs4MqDOwESnEghgpdMGDQMP1LeuS8b9FvqGMosCo84fP9JTR3rR033qupL1E=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(66556008)(66946007)(66476007)(8936002)(83380400001)(31686004)(8676002)(956004)(2616005)(31696002)(2906002)(36756003)(186003)(38100700002)(4326008)(5660300002)(86362001)(316002)(16576012)(508600001)(54906003)(53546011)(6916009)(15650500001)(6486002)(26005)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?RHpsVnVHczdhdWFVajUvQ0NrRHZtTU1QT3JobWJkSi9PVGpNSGpBeUVpaWMv?=
 =?utf-8?B?eFovL1dVbHhzY3A1NjZndGpoL05ReUdkNnJJL0ZQWGNRaEFySFQrMEppUk9u?=
 =?utf-8?B?NC9sOU0rKzdwVkZxMEJmdFArdmgxOG1rV1pMVXhGZU5MZDIzNW1ZanptbFd4?=
 =?utf-8?B?eWJnYzZDZm5GZ3dBL3dmcWhCVXlySlBpc1E1VmIrT3B6QUc3RjJlRHpLdUFV?=
 =?utf-8?B?YXFGVXFTTnhpa1FveGZNRC80OCtKR3VEQ3llYXU3Z2d1cnBnNy94MnN4ZCs2?=
 =?utf-8?B?VDJ6ZForN0paRTlsc0FGZUVabDBCNWw0WDdiWWFhU1BKMStacWdIWGUwZ0RG?=
 =?utf-8?B?OXNvUERia2kvYlFLRXlWUmxRMWVWaEFuUnBhNVloMTBualFtSDhpZ01IZWo0?=
 =?utf-8?B?UFFPWldpNFVLZWszNyszOEJWVVVHYmJXWm0rQjNYNG43M1lBbkVVZUthTzBM?=
 =?utf-8?B?cFNyUEdUNXFMQVhCNktNRkpJRWRtQzRIMUh6YVp0RkRxcWxuOTlqcFZmUzBq?=
 =?utf-8?B?TXhCWi9Kb0wwSVZXeCs5MUh0N1RxMk1HZlo1NHZWUVdTMTRnajVUcFY2cHJZ?=
 =?utf-8?B?bGNXcVlJK1NtTUxuNUxjcU1GeUloZ2xUWnNSY2ZxNzRCYkZmZnNzcTA5QXRr?=
 =?utf-8?B?bUxlZDFHMkRadis1dHBWQm1wSXpIV2s0RVpEN2FySlVNWU1Da0VMR2RGMk4z?=
 =?utf-8?B?czdWbUxDUFZIQ003c3FvWlZxNlZhMjBLSE94NURaK2RZeGhFOVFJaERYbTgz?=
 =?utf-8?B?UFI2NHJqWlR3dUdnZFNTZDVIWWlJcnMzQzEwS2t2REJPMHFxSVEvT1Z0Q1NP?=
 =?utf-8?B?TzQrTExJUDFxeldZWDVXOWhMQ0tyOUkzcXUvaEU2Q2FkREdPQ2plaXIxeEpC?=
 =?utf-8?B?WHVtWlByRk9sczl5SEtvMWNlL0RYR0RWM3lCQVZ5VkdVZlk2T0R3a3R0ZlVJ?=
 =?utf-8?B?TDVFTHZ1SUZyN3dRaWpiQ21NbEFXMkJEQVczUExSZFRwY3B1RzVUZ3REMWht?=
 =?utf-8?B?QjR2dmpOWklyaDRyenRvUU42Qm9hTStGUnlVdE5DMTF4Q3Q5eld4RDhhY0RS?=
 =?utf-8?B?TEEyTkNxUksxd3J4NUwwTmFvNE1jdi8zN3JUb2cvN1pvWE1FV0dCWmJPWkdK?=
 =?utf-8?B?dWRPU1MrUnp0NHovVmRsL2RHNkxjVXFTZFlVWnNNMVRZckZCdDhmRDlCM2lw?=
 =?utf-8?B?eHBnbjVrT3dqcC9TemZ2eEpJVWR3UzZiMWo4bkhHSDRoNEltTSszZFIrc2xo?=
 =?utf-8?B?cENnSlp0TkFSMmIxcG5EUHFSTzlkQXhFR1hnalQzR3IxQnJ3MGFsVDJpSnVk?=
 =?utf-8?B?YnlCK2xtWTZGdEtMbnplcVRDYnVwZTVOb01SY2NURk9RUUFYNVF4ZU1mSnlp?=
 =?utf-8?B?SU93UTd0c1RQa3lrM3Jwa21xWTVCa0J2bmh1cEJ0SDNWQ2RaTzhOVWNnUGNB?=
 =?utf-8?B?djExUWZiTUVzOTR6cFNlOThuQVc4clc2bnFGUFdFWmw5MisxQ2RHcHBEdTdl?=
 =?utf-8?B?b2VOSjdxWGhJRWwzelJPbHRLMzlaTUdNRGsrMmphcFJIbk5MaEo1QVdMY0l6?=
 =?utf-8?B?c0VHT3BJVGV3UnpRUFFKQWs1ZUYvTm5RakFvSU40cnM0endKYzNqd0t3TG5v?=
 =?utf-8?B?Y0FwMDNnTUF5OWsvU0JpeTAycllsUTlHUFdFREhoMkZEKzlxRmhJNUdMN2di?=
 =?utf-8?B?WmVwV3JVanJhcmRwUGpPK29MMjVtQkJaRXVuWVpIUy9FSEFoSjI5eStFVlZP?=
 =?utf-8?Q?yMVk9WjGsHRLprbmvcFXR9bG7jugD4Qb5mfviRi?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a3d53497-6fe8-4b84-e34a-08d98ca79ebf
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2021 11:09:40.1567
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: fHP9KrZh85uXT028Y9TtkYMxEyM8Db8HGrfQREaDy959Q34k6xs96bAkCydBKJvvaDPMeL8O8i3kWwt9U4DOmQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5741

On 11.10.2021 12:56, Ian Jackson wrote:
> Jan Beulich writes ("[PATCH 0/2] VT-d: correct / extend workaround(s) leaving an IOMMU disabled"):
>> Ian - I'm also Cc-ing you since this feels like being on the edge
>> between a new feature and a bug fix.
> 
> Thanks.
> 
> I think 2/ is a new quirk (or, new behaviour for an existing quirk).
> I think I am happy to treat that as a bugfix, assuming we are
> reasonably confident that most systems (including in particular all
> systems without the quirk) will take unchanged codepaths.  Is that
> right ?

Yes. According to Linux there's exactly one BIOS flavor known to
exhibit the issue.

> I don't understand 1/.  It looks bugfixish to me but I am really not
> qualified.  I am inclined to defer to your judgement, but it would
> help me if you explicitly addressed the overall risks/benefits.

Right now our documentation claims similarity to a Linux workaround
without the similarity actually existing in the general case. A
common case (a single integrated graphics device) is handled, but the
perhaps yet more common case of a single add-in graphics devices is
not. Plus the criteria by which a device is determined to be a
graphics one was completely flawed. Hence people in need of the
workaround may find it non-functional. However, since our doc tells
people to report if they have a need to use the option engaging the
workaround, and since we didn't have any such reports in a number
of years, I guess both benefits and possible risks here are of
purely theoretical nature. Note that I've specifically said "possible"
because I can't really see any beyond me not having properly matched
Linux'es equivalent workaround - that workaround has been in place
unchanged for very many years.

> But when reading the patch I did notice one thing that struck me as
> undesriable:
> 
>> --- a/xen/drivers/passthrough/vtd/iommu.c
>> +++ b/xen/drivers/passthrough/vtd/iommu.c
>> @@ -750,27 +750,43 @@ static void iommu_enable_translation(str
>>              if ( force_iommu )
>> -                panic("BIOS did not enable IGD for VT properly, crash Xen for security purpose\n");
>> +                panic(crash_fmt, msg);
> ...
>> +        if ( force_iommu )
>> +            panic(crash_fmt, msg);
> 
> Does this really mean that every exit path from
> iommu_enable_translation that doesn't enable the iommu has to have a
> check for force_iommu ?
> 
> That seems like a recipe for missing one.  And I think a missed one
> would be an XSA.  Could we not structure the code some way to avoid
> this foreseeable human error ?

I'm afraid I don't see a good way to do so, as imo it's desirable to
have separate log messages. IOW something like

    if ( ... )
    {
        msg = "...";
        goto dead;
    }

doesn't look any better to me. Also leaving individual IOMMUs disabled
should really be the exception anyway.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Oct 11 11:13:13 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 11:13:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.205788.361183 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZtF1-0006vb-1K; Mon, 11 Oct 2021 11:13:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 205788.361183; Mon, 11 Oct 2021 11:13:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZtF0-0006vU-Ue; Mon, 11 Oct 2021 11:13:10 +0000
Received: by outflank-mailman (input) for mailman id 205788;
 Mon, 11 Oct 2021 11:13:09 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=9TNE=O7=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mZtEz-0006vO-BC
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 11:13:09 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 36474f96-2a84-11ec-80d4-12813bfff9fa;
 Mon, 11 Oct 2021 11:13:08 +0000 (UTC)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2104.outbound.protection.outlook.com [104.47.17.104])
 (Using TLS) by relay.mimecast.com with ESMTP id
 de-mta-9-S_kqxFFxPSWf4idVwV52jg-1; Mon, 11 Oct 2021 13:13:06 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0402MB3776.eurprd04.prod.outlook.com (2603:10a6:803:18::23)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.25; Mon, 11 Oct
 2021 11:13:04 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4587.026; Mon, 11 Oct 2021
 11:13:04 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6PR02CA0001.eurprd02.prod.outlook.com (2603:10a6:20b:6e::14) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4587.25 via Frontend Transport; Mon, 11 Oct 2021 11:13:04 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 36474f96-2a84-11ec-80d4-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1633950787;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=hQXq58kpHN9JB/4f2ub/bjpEwq412Za9mK4KLYwjdmY=;
	b=WogkLNiNKGVrSxsbab/3N/MirwhFBfq9UGJoQBJmHcyv/b5BbuoZ35sd9YfxLp1WxT4diZ
	w9TXNowz/T6R8ipKdtNX87ayGfq4fFrmDu/LdYaC7DZJJDc/Hyic/h1xuQgzzyVcpO4xBY
	ONAWgz4EomlA29CIO1ho7hhz2wXOT+c=
X-MC-Unique: S_kqxFFxPSWf4idVwV52jg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=UIa5sPcuNAlWJ2OhtkdcavgWZ+X1bNWh6b+5fEvW3JtZ4/T35yI2nc0fWoB1LwNjrSRDseHkClqdHWgQePec2jVKVZDPtnzsB6Jolrsw9pPsa8t8UFem+K6VKOV8TQVZtFsPbobZOemwuCjKG1vlXCe/NziQ5TMvY6poEOdOPyRpnQlYm5D5KU5DMNQziRwJvOZj6tYUAHaX6swkfhy0QdT1VIFGIQDtM67uqo2AUlB1928JVYX8K0MYzt0CKFcT+cJRHu7GzLn+sr6kPk9wK2N2qYJb6OgJUqTIR737ztf4PmcmatzJfk05j+iRXW76+oYs4e6yF+/OBgsOXCtxuw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=hQXq58kpHN9JB/4f2ub/bjpEwq412Za9mK4KLYwjdmY=;
 b=OJkpTp5tyIqiztd3QX85KXcngKBTERLPqZ5W5xEcnr2YpF714v6vSgVAO0xKTPtESsujBNPGEj3XG2zA04aKzIzEQrLpc0S8IiNMSQK/16fqhlwQ5STW8mbg+zo66VFc81PJekDSxnito1HlkMEqoBPLzpdwgs35jWGtFzgskws9RmupUPMXpJjJHiZnJBPhMmXnBpp1ZDsi1+izW9g5ioTYH772AyCjAIpj+drTb9vVsECBgEea4r8AVLp1O+4d+FZZ7W4A9uPrA2KoGbMlJrUyQDy76EAJf06/hdm3i68kWhxqZ1V1E8zYdAh48ev4TH/lsCfQppOFEj3PPlXYwA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: kernel.org; dkim=none (message not signed)
 header.d=none;kernel.org; dmarc=none action=none header.from=suse.com;
Subject: Re: [PATCH 01/11] xen: reserve flags for internal usage in
 xen_domctl_createdomain
To: Julien Grall <julien@xen.org>, Penny Zheng <penny.zheng@arm.com>
Cc: Bertrand.Marquis@arm.com, Wei.Chen@arm.com,
 xen-devel@lists.xenproject.org, sstabellini@kernel.org
References: <20210923031115.1429719-1-penny.zheng@arm.com>
 <20210923031115.1429719-2-penny.zheng@arm.com>
 <7da75d7c-5640-305d-d742-d64b8c219949@xen.org>
 <60d813f7-a756-172c-999d-44f81504e268@suse.com>
 <975079d0-38d4-2a56-541d-b6d652ce87c3@xen.org>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <32d35bc1-5d3b-87d7-c24f-4e067ccacc23@suse.com>
Date: Mon, 11 Oct 2021 13:13:02 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <975079d0-38d4-2a56-541d-b6d652ce87c3@xen.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR02CA0001.eurprd02.prod.outlook.com
 (2603:10a6:20b:6e::14) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: b53f7f91-67a9-4653-4152-08d98ca81888
X-MS-TrafficTypeDiagnostic: VI1PR0402MB3776:
X-Microsoft-Antispam-PRVS:
	<VI1PR0402MB3776FBC05C45D6C32AEDB8C7B3B59@VI1PR0402MB3776.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	MVudanh4ZDCTatmmv5cPQJ2TlsLJ9Czuz5lKdpWSf6B+2iP0Vg0bO+qgVf8ws1dy6IDDb3YwXIPiXKa2jG0c9cIYRyWcxt+tP6rRPrLdwKOIsnxmQ3uoZX4rFJC7I0j3UyZFUOJ7q5lUDbeM21BqcnbVdC6C5qlRMdC9P9ShMoC5WIvJF8KSDcpla2hT1AM3nGKGuJmiXnE6l8kaDJBL1marLeh+mxKrR0k9rbUXB57iSPRtGklMUCnGFFxts2cTERHRQQJDCHtxEL1Lynl4srneVbCdRtrR6+SfXjNi3Xy5+k+8Pf4E4CaafKAWZuIcltJSIZuC2akWjxmXWiAlrGGSc1X121cCZ3EUI5y3e2aYOLDrTSPGdHt/25BpkNETnAzo44Rs1MWyRriNEtwSwZayEnTVlJyx2qp/Ef+bgE73O1Uo/r0OcguEAkumvNjTk3DTEPfDxjRCINC0hBSqO1OrjdKbNuHKVEQZ891FeacdLwFaGW2Bf0V2kzNYsGNEdpq/PTu/4XDUSwADg72POug6sW1oo+dMuWUsHyziPedePgtS7mBLgQ7lRu3mjxhb/m71l6lCvvUkC9diefTZZMCiHuz5s8j0TBJoj/YBcXQUg27xNsKZzWGvlFVuHQtxaI4eWhUclrIj4KMjpov6/fP+UzIIu8myKvBQmcT3rq3A1WNA8Jq5+GtDrYM+OHtZpIYHM45jpW9KcEqgZsr1gap+e5Xf6EpReSdAgc7gnATttni8k6w+Srrx4lQnsvLx
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(31696002)(110136005)(53546011)(2906002)(31686004)(86362001)(83380400001)(316002)(6486002)(16576012)(5660300002)(186003)(36756003)(4326008)(8936002)(8676002)(66556008)(38100700002)(66946007)(508600001)(66476007)(2616005)(956004)(26005)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?WW05d3hVdG9BL3dIZHNNbENvWDFUZFZ1eFBrZ3Y5aS9TQStwbTNtR0d4WkY0?=
 =?utf-8?B?Z3NGL2g1ZUxTVURabi81VlVGOTZGdmNOS0c4SXVhVDlKYks0emltRFdVcW0y?=
 =?utf-8?B?aitFcjlyS1pKRW1mSENERjZZL1ZCdTRQV01jTDBwTi9HeTNnSG10UjFsQnNX?=
 =?utf-8?B?Sko4N1lubWdVaDdzdFQ2Ri9ER01SSW1zZmhSTXdwTWx2ek1GRHRoSXBvSVpz?=
 =?utf-8?B?QU9BM2s0OXRRUExuVWcvVHgwNk41L1I2SXhxUWVnWjIvZmo2MzBlUzBMdEor?=
 =?utf-8?B?a1JsR09BTkovYkpzQmtPNkhGY3JkKzZVcTUxQnBqVEl2RFVsMFJFNSsxa2hT?=
 =?utf-8?B?SEo5VGx0VjhaOFBFeTRIZ1ZsaEhsU1lsYWk4MGVsWDF6UVlkaWdiQkFNQjlM?=
 =?utf-8?B?YTF5eVRhU3ZuSlUwdFBuZ2VNWUhSNDZsZjlyOUpFZ1g4OHFIaEgyZFpnVUhG?=
 =?utf-8?B?RERrYy9qU3A5SVdqcmFrVHNIeEpVMEhWa3pyVWZkNWtIRnFhUFptOXBVbHo5?=
 =?utf-8?B?azhHVEV1SkFwRlZ1QldsQU5WcERSZU1jenVvTElNRXdnRisweFRiM2dIZVlE?=
 =?utf-8?B?UEhaaS84NERrb05PUHVJUEdCZXVtVE5zWTdqTFdEZTlnb0dkeTAvcG5DZ1ll?=
 =?utf-8?B?ZTQ5eGFRK2thcGFSMHRSbmh6NlNJS1VOak1tbHRCVW1ZZ2JQZVViVVJmZFFa?=
 =?utf-8?B?NkhCZVhsMFYwRzgzNXZoTURFZEwzQXpjTGxLMjR2NTZEUWp0Y2E3UFhMYis5?=
 =?utf-8?B?QWw3aUxOZm5kQ29oSkZ6TXNCL1pOaTd0b1BHQWlmM29OSGxPQVBZZkRjbi9G?=
 =?utf-8?B?RzYzWmtKRlZWVGFvNHlDQUwrZmxuV25uZ05EVjhiQVVsSWp6RGhqN1FvOGRB?=
 =?utf-8?B?NVI3QjA0OHB6aU9vdGM3cmZZblJDVEhYSDhENW1qam1YeEJtbTYyeWZuYUVQ?=
 =?utf-8?B?dGt3YzJCNEthQ2VxQUZFUkUyWENJaXRqOEF1MDJ1RWpzTlVCc2hxUHdpVmwz?=
 =?utf-8?B?M1phN0daWGk2N1ZTTHRDc0pxRjVPRzVrNXRPSWlraXNBdmhSSEpFbnpjQkhS?=
 =?utf-8?B?VkdJNVpxQlN2TWRaTSthaGRadllJZk5nTzcwdExRdFU1VDRQd25LTmlIZHp1?=
 =?utf-8?B?ZC83c2NENTdHLzByRjhZWWt4cXRvZjk3amJHQ05NMzlDVkpUSDFzN2VwT0pB?=
 =?utf-8?B?MnNlc054TFF1cmFqcFNnN2JJODcwanREb29mTkh3dFhRejBYdzREMWtvLzQ4?=
 =?utf-8?B?SXEwUFNBdHByd0U2SmZ2Y3B1bGhyY3luWFY4RHc1S0tFMmlpYlIwdjY4OU9o?=
 =?utf-8?B?WlZVQXM4NmMrem1RcmwzdFdHY09RUk9VdkdBOWRGUUtQR0ZrRnh5NkxpbEhX?=
 =?utf-8?B?OFRTWFpwSzh6V2dhYWVtZDJWc2F0cEw5VlEwWGZjdER6Nk44YnNVdVphTVQ5?=
 =?utf-8?B?c0hia2VVRWtyVmlsVW1XZnBUTnVQcmF6Zk53WWtaeXBhbGgwaW9zQXhMTW95?=
 =?utf-8?B?UzFieUU5UVg2WWZJQk1pcVpwYVdicUxCNUowQXFoYnRTa0JETnJRcXhSbVhF?=
 =?utf-8?B?d3QrdUVxQlZaYVVycUplc240UUl0SGl2YkMrdWdudngycExVbE5BM2UvbHly?=
 =?utf-8?B?cVQvOTkwMVRPSmgxcWRuSDVzWVVPZ2VGKzRoUGxidTA4WHU5NXhmb0dIOFJN?=
 =?utf-8?B?RWU4dmdqTldQNDdtcUVxenVNdlNZeWdEbG1NeTdTRUF0bVlrekx1eE03eGZp?=
 =?utf-8?Q?WDx0mVWHPeyNBwwjQoWVMs8CU9sA9DgZekrXz4I?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b53f7f91-67a9-4653-4152-08d98ca81888
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2021 11:13:04.4572
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Nk9LdyMXNq6jLNcdH0LRtbSiCi1s/rt/01VY2haPZ8uSnIb5OUDtAEEXii0UDGf7LH7tSOTDnkgpUKeZeeSndA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3776

On 11.10.2021 12:45, Julien Grall wrote:
> Hi Jan,
> 
> On 28/09/2021 13:05, Jan Beulich wrote:
>> On 23.09.2021 11:54, Julien Grall wrote:
>>> On 23/09/2021 08:11, Penny Zheng wrote:
>>>> From: Stefano Stabellini <stefano.stabellini@xilinx.com>
>>>>
>>>> We are passing an extra special boolean flag at domain creation to
>>>> specify whether we want to the domain to be privileged (i.e. dom0) or
>>>> not. Another flag will be introduced later in this series.
>>>>
>>>> Reserve bits 16-31 from the existing flags bitfield in struct
>>>> xen_domctl_createdomain for internal Xen usage.
>>>
>>> I am a bit split with this approach. This feels a bit of a hack to
>>> reserve bits for internal purpose in external headers. But at the same
>>> time I can see how this is easier to deal with it over repurposing the
>>> last argument of domain_create().
>>
>> I actually have trouble seeing why that's easier. It is a common thing
>> to widen a bool to "unsigned int flags" when more than one control is
>> needed.
> 
> I was suggesting this is easier for the following two reasons:
>    1) All the option flags (internal and external) are in a single place.
>    2) Reduce the risk to make a mistake when widening the field. In 
> particular in the context of backporting. Although, this looks unlikely 
> here.
> 
>> Plus this makes things needlessly harder once (in the future)
>> the low 16 bits are exhausted in the public interface.
> 
> That's why I suggested this sounds like a hack. At the same time the 
> split between external vs internal option is a bit more a pain for the 
> developper. So I didn't feel pushing for one vs the other. That said, I 
> will not argue against if you want to push for repurposing the last 
> argument.

In which case - Penny, would you please change the patch accordingly?

Jan



From xen-devel-bounces@lists.xenproject.org Mon Oct 11 11:14:28 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 11:14:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.205794.361194 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZtGG-0007VT-BP; Mon, 11 Oct 2021 11:14:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 205794.361194; Mon, 11 Oct 2021 11:14:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZtGG-0007VM-8K; Mon, 11 Oct 2021 11:14:28 +0000
Received: by outflank-mailman (input) for mailman id 205794;
 Mon, 11 Oct 2021 11:14:26 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mZtGE-0007V8-PR
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 11:14:26 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mZtGE-0003cv-MH; Mon, 11 Oct 2021 11:14:26 +0000
Received: from 54-240-197-230.amazon.com ([54.240.197.230]
 helo=[192.168.17.141]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mZtGE-0003vb-Gh; Mon, 11 Oct 2021 11:14:26 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=OqXQGJLgtkZ2tPxuoAUKLi6RuLuzPoXsGKNtrws2n6c=; b=Y0h4C1NLS8e0srjk5Nb4yCa2Dk
	l2fXcOeyyrDG+C7GmEtg+ttHZF08IG+5dhKa3GcdeWf4rx80pkvVcnwAGHatMr+BmNndAgEs62nG4
	tIs3ZlqJYHm8IXoVpHhlCULTTktav0GRqvTvGGxjzHx8ef8fwIlaUOOtK2aVupjadZsg=;
Message-ID: <9237c85c-87d0-14ac-07ce-244958add7d3@xen.org>
Date: Mon, 11 Oct 2021 12:14:24 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.2.0
Subject: Re: [PATCH 10/11] xen/arm: device assignment on 1:1 direct-map domain
To: Penny Zheng <Penny.Zheng@arm.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 "sstabellini@kernel.org" <sstabellini@kernel.org>
Cc: Bertrand Marquis <Bertrand.Marquis@arm.com>, Wei Chen <Wei.Chen@arm.com>
References: <20210923031115.1429719-1-penny.zheng@arm.com>
 <20210923031115.1429719-11-penny.zheng@arm.com>
 <c6730ec5-53c7-9bf2-4620-eefbc7c7c4a3@xen.org>
 <VE1PR08MB5215A1D5695F388F17C367D4F7B39@VE1PR08MB5215.eurprd08.prod.outlook.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <VE1PR08MB5215A1D5695F388F17C367D4F7B39@VE1PR08MB5215.eurprd08.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit



On 09/10/2021 10:40, Penny Zheng wrote:
> Hi Julien

Hi Penny,

> 
>> -----Original Message-----
>> From: Julien Grall <julien@xen.org>
>> Sent: Thursday, September 23, 2021 7:27 PM
>> To: Penny Zheng <Penny.Zheng@arm.com>; xen-devel@lists.xenproject.org;
>> sstabellini@kernel.org
>> Cc: Bertrand Marquis <Bertrand.Marquis@arm.com>; Wei Chen
>> <Wei.Chen@arm.com>
>> Subject: Re: [PATCH 10/11] xen/arm: device assignment on 1:1 direct-map
>> domain
>>
>> Hi,
>>
>> On 23/09/2021 08:11, Penny Zheng wrote:
>>> User could do device passthrough, with
>>> "xen,force-assign-without-iommu" in the device tree snippet, on
>>> trusted guest through 1:1 direct-map, if IOMMU absent or disabled on
>> hardware.
>>
>> At the moment, it would be possible to passthrough a non-DMA capable
>> device with direct-mapping. After this patch, this is going to be forbidden.
>>
>>>
>>> In order to achieve that, this patch adds 1:1 direct-map check and
>>> disables iommu-related action.
>>>
>>> Signed-off-by: Penny Zheng <penny.zheng@arm.com>
>>> ---
>>>    xen/arch/arm/domain_build.c | 12 ++++++++----
>>>    1 file changed, 8 insertions(+), 4 deletions(-)
>>>
>>> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
>>> index c92e510ae7..9a9d2522b7 100644
>>> --- a/xen/arch/arm/domain_build.c
>>> +++ b/xen/arch/arm/domain_build.c
>>> @@ -2070,14 +2070,18 @@ static int __init
>> handle_passthrough_prop(struct kernel_info *kinfo,
>>>        if ( res < 0 )
>>>            return res;
>>>
>>> +    /*
>>> +     * If xen_force, we allow assignment of devices without IOMMU
>> protection.
>>> +     * And if IOMMU is disabled or absent, 1:1 direct-map is necessary > +
>> */
>>> +    if ( xen_force && is_domain_direct_mapped(kinfo->d) &&
>>> +         !dt_device_is_protected(node) )
>>
>> dt_device_is_protected() will be always false unless the device is protected
>> behing an SMMU using the legacy binding. So I don't think this is correct to
>> move this check ahead. In fact..
>>
>>> +        return 0;
>>> +
>>>        res = iommu_add_dt_device(node);
>>
>> ... the call should already be a NOP when the IOMMU is disabled or the
>> device is not behind an IOMMU. So can you explain what you are trying to
>> prevent here?
>>
> 
> If the IOMMU is disabled, iommu_add_dt_device will return 1 as errno.
> So we could not make it to the xen_force check...

I disagree. The check is:

if ( res < 0 )
   return res;

Given that res is 1, we wouldn't return and move to check whether the 
assignment can be done.

> 
> So I tried to move all IOMMU action behind xen_force check.
> 
> Now, device assignment without IOMMU protection is only
> applicable on direct-map domains,

It is fine to assign a non-DMA capable device without direct-mapping. So 
why do you want to add this restriction?

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Mon Oct 11 11:23:39 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 11:23:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.205807.361205 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZtP4-0000Zw-8j; Mon, 11 Oct 2021 11:23:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 205807.361205; Mon, 11 Oct 2021 11:23:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZtP4-0000Zp-52; Mon, 11 Oct 2021 11:23:34 +0000
Received: by outflank-mailman (input) for mailman id 205807;
 Mon, 11 Oct 2021 11:23:33 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=RBe3=O7=arm.com=Luca.Fancellu@srs-us1.protection.inumbo.net>)
 id 1mZtP3-0000Zj-AL
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 11:23:33 +0000
Received: from EUR03-VE1-obe.outbound.protection.outlook.com (unknown
 [2a01:111:f400:fe09::62e])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id b916ca21-32fc-49e8-b5bb-e02556346704;
 Mon, 11 Oct 2021 11:23:31 +0000 (UTC)
Received: from AM6PR04CA0058.eurprd04.prod.outlook.com (2603:10a6:20b:f0::35)
 by AM8PR08MB5761.eurprd08.prod.outlook.com (2603:10a6:20b:1d0::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.24; Mon, 11 Oct
 2021 11:23:28 +0000
Received: from AM5EUR03FT046.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:f0:cafe::ef) by AM6PR04CA0058.outlook.office365.com
 (2603:10a6:20b:f0::35) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.26 via Frontend
 Transport; Mon, 11 Oct 2021 11:23:28 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM5EUR03FT046.mail.protection.outlook.com (10.152.16.164) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4587.18 via Frontend Transport; Mon, 11 Oct 2021 11:23:26 +0000
Received: ("Tessian outbound 2e7020cc8961:v103");
 Mon, 11 Oct 2021 11:23:26 +0000
Received: from d31eb5426ab2.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 5822FCD6-8780-43EA-B382-17714D9F3B18.1; 
 Mon, 11 Oct 2021 11:23:20 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id d31eb5426ab2.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Mon, 11 Oct 2021 11:23:20 +0000
Received: from PAXPR08MB6816.eurprd08.prod.outlook.com (2603:10a6:102:130::10)
 by PAXPR08MB6925.eurprd08.prod.outlook.com (2603:10a6:102:13a::24)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.25; Mon, 11 Oct
 2021 11:23:19 +0000
Received: from PAXPR08MB6816.eurprd08.prod.outlook.com
 ([fe80::c1b4:db1c:376f:b697]) by PAXPR08MB6816.eurprd08.prod.outlook.com
 ([fe80::c1b4:db1c:376f:b697%8]) with mapi id 15.20.4587.026; Mon, 11 Oct 2021
 11:23:19 +0000
Received: from smtpclient.apple (82.8.129.65) by
 LO4P123CA0188.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a4::13) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4587.18 via Frontend Transport; Mon, 11 Oct 2021 11:23:18 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b916ca21-32fc-49e8-b5bb-e02556346704
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=QSxEyE53U20d4hvbj9ZxTr2LRWp2djw+W1PTiXIolDQ=;
 b=CmJdEPXms61CQcaWB5DFT1dNvdxasYCgODcnvmQeM6y+xnEsSNtzo9RjtQNMCjr9HlowrcFUB6toVk6mnjWWcu4/PiwyX2m1ul3RZdJ/klRQjd8WG1lBzxCwWoJLPQ5LmdYQhhZN4SQ5qdW6QSx9R6YoLwzXdjoilQPctXa8Av4=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: da9b363cd250488d
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=BIEbvRYAvskhKamCrbiQlVAYeqXt1bc7vb/ocSAZZOKeIV0xvKbUffYvLPaKsHLi3E+fWW8LNXLWTCzHyd/qWR9WrKDVQXxWtia3JVqJPsVEFnXMMYO5jI/V6tUrmWjQ9W70FtAIO3e/kvwKd7fQmtVvmRHZ4vsSxd+MUZM4j23raGlmnT4L7porcOedl/c9busvfVMiNoXmc6iPYXPTyHH8zEetjy6slV29j60UxYjPuWLSNNkRZJxKwhJpE/rKEFmEV7nS8bPsk4lcm0fovfBZIbvibI4XRrbVRhg4FUmPjWvFEAY4h56pw7XpW3uScyJUz86U3fcF6+LqVouG+Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=QSxEyE53U20d4hvbj9ZxTr2LRWp2djw+W1PTiXIolDQ=;
 b=CD0QAWv9pnsyvgkjxBS9EKT1ANA1Biqs2RhqCq3ZJqWBTTEdOhK98d0XivR5QTTP8VsZP41BvtAt3dLIKJ8sqDQoAkpXBvs4+mHrhjyAhFCUF65oxFihRBmYKGorYjyiwlUGQ0gs6FpVOJ4CXjVV2xmAQ1SdqKVIVP5OkVvZWRMXwEm/glnFX58WjUmj3HAe3lcufuXPGYgn/AIsseZJOy1gqYyKvAupc3V3IyjoxUJie+z7uHjTqyTJJWVSta5RHHJfWC+RzGyy3KhrasUvwsSGyAedYPff/47YpPH7/vASs2tTo0fwdojK2RFpU+dlZhin5NDVWRtKYYv05Ut67A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=QSxEyE53U20d4hvbj9ZxTr2LRWp2djw+W1PTiXIolDQ=;
 b=CmJdEPXms61CQcaWB5DFT1dNvdxasYCgODcnvmQeM6y+xnEsSNtzo9RjtQNMCjr9HlowrcFUB6toVk6mnjWWcu4/PiwyX2m1ul3RZdJ/klRQjd8WG1lBzxCwWoJLPQ5LmdYQhhZN4SQ5qdW6QSx9R6YoLwzXdjoilQPctXa8Av4=
Authentication-Results-Original: xen.org; dkim=none (message not signed)
 header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
Content-Type: text/plain;
	charset=us-ascii
Subject: Re: [PATCH v5 1/2] arm/efi: Use dom0less configuration when using EFI
 boot
From: Luca Fancellu <luca.fancellu@arm.com>
In-Reply-To: <81e30575-d823-830b-6f80-4e7a7fb4f9ff@xen.org>
Date: Mon, 11 Oct 2021 12:23:11 +0100
Cc: xen-devel@lists.xenproject.org,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 wei.chen@arm.com,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Ian Jackson <iwj@xenproject.org>,
 Jan Beulich <jbeulich@suse.com>,
 Wei Liu <wl@xen.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <BC2506EC-8BCD-487C-AFF4-0C99A9020BDA@arm.com>
References: <20211011080302.24203-1-luca.fancellu@arm.com>
 <20211011080302.24203-2-luca.fancellu@arm.com>
 <81e30575-d823-830b-6f80-4e7a7fb4f9ff@xen.org>
To: Julien Grall <julien@xen.org>
X-Mailer: Apple Mail (2.3654.120.0.1.13)
X-ClientProxiedBy: LO4P123CA0188.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:1a4::13) To PAXPR08MB6816.eurprd08.prod.outlook.com
 (2603:10a6:102:130::10)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: a6c4a0fd-749f-4de2-7a73-08d98ca98b9c
X-MS-TrafficTypeDiagnostic: PAXPR08MB6925:|AM8PR08MB5761:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS:
	<AM8PR08MB57619569EE844198C87892AEE4B59@AM8PR08MB5761.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Oob-TLC-OOBClassifiers: OLM:7691;OLM:7691;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 M9dCU4D7v+tzMJuc84VWCHuQlphsdMvOWe0y+R41k+srT9QYhDaQca2+elE3rLDhwDHv90xtmYS6UviNWEe++mzMZO4GYgEL14A1tdT5yb+KLJHZrTeioHX0C0jFg+miLBL9XQ2GX1GX92ZRchTfW7KDwzSWnIDTRi7RqBqZbTwBT/aYp6upMBDD1eZIClrF9Mv8dCzyQG+WRoCMkYBqPIMVIHN741Xy1N2TA0BOn/gXXXPGfgcPrL1ftj3Be135NnP5lw/Qh3qkXAS5n36CkN6K3dpzvTSJZARVrMsVQzhb2l8isIGkCyessnQodNUj7CA8UVElf7GA66TpagNP/0Q8WYsdD2ga8F5ruBD1e5+rVgHjllkxr6eZ04mg3+xUMnJYYtlpl5UxLt8BHoRkRFUd+KWiQKmzTKp7+Njdq9ALRa5S/tbD/6LKHpyVEctqDMThnEs5cUlGWjMo9FtY4ZHQnJwq8M4j0OT4CPuFprS99BnpNs98r6TTVheE7ALJKJZAZFNPKaJYL77y44KEF6QPcno2nD3TlLWMW1ltR80eJdgnYlpJosv/O7kghTU7qaKebz7bnaB4aI/WSJmfvBRO/YhMepJdlMlPYw66jZxUd4Y44ZBCnDgSNDsjeiPAxH6L/q+FKWPxnG8o+ItuMdERTAsk37GoMzuFfFsm5zmYYcyT0Fctm/2uj9PVUdsScGsw1y6LIg33X+w6balHkqr1plu6OHKEOkBWsJOIkAFpmmuSxNCs0ePL8q5up8/UPwWTgXSJ2Xmo5Q2p6ZhFSQ==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB6816.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(66946007)(5660300002)(6666004)(4326008)(6512007)(956004)(26005)(2616005)(66556008)(66476007)(53546011)(6506007)(86362001)(44832011)(8936002)(36756003)(33656002)(508600001)(2906002)(52116002)(8676002)(6916009)(38350700002)(54906003)(6486002)(38100700002)(186003)(316002)(4744005)(32563001)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6925
Original-Authentication-Results: xen.org; dkim=none (message not signed)
 header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM5EUR03FT046.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	ec429fb2-fa1d-434b-da0d-08d98ca98722
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	9jkvq8mEShsoyV/SQUsh2Bm+r6AiULWTSr/tv5lVaxYARhCxOKPHePqSm6Y7rTrRJLIVsmoNsprUwhHcFgjjbt13Np0OJ2nWMu4tkpF6UXS2jleL9z9euxHttJbZCLMI0W/IPzha5fQbXmQdSWxcoreC7SoHznOQZd6vekWZnEncxjjFTm6CQTeBHvyNAsyPNtdsyIW+6UYefvjUkhEIby5nC1u2NBSeAuv4y6n5yPuYhB3FqFDVLCZ3lH75cS5srz5WEwE2ah3J1lyJH3rnOwgsPEG/x2YbCgavA+RW8NkdPv0z/oiPF1ye6VgsHR50zVqYezt4JH7E/osP1oPCIIlNfpAY/tf4ohCI8X7PZIWpjCvPAuY/7DmxvttjYy0ZfJC1JitEpLVtHkPEv46m5KfAM9ovpgR/QCFUBqLnSWPo66dL7sHuP080PHBrYLs3mC9V9D4lSMsxxM0h+GG4G/99nQKQr9EhMvbYlxFnpIwW9x25Mv0HtvE2nqByUY5t2UKrfM6wBdMCHzUiFUsOLYx6VDF3AsxFbnpFHJ3gMRJNFxlfDx3XcuxKCe/K6ynmDddwBzSnmekdxXJ++coDevFF14q3QDM7o9M4d/7ZK9WgNtbZNR11zLgVTWVUYybUHk0Um+8nIEdNkqklw1ynatPCgJZdFLE72kVn+Gs5rM6qPDl7ROylPqw0xGiWbDvrjiLPwhB+hiR3brkpLWOvHx1gaonOVjzmXEmgSzEPtnk=
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(81166007)(6666004)(356005)(8676002)(8936002)(5660300002)(70206006)(70586007)(4744005)(82310400003)(316002)(6506007)(2906002)(36756003)(44832011)(4326008)(336012)(54906003)(508600001)(6862004)(956004)(53546011)(186003)(6512007)(47076005)(33656002)(2616005)(36860700001)(6486002)(86362001)(26005)(32563001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2021 11:23:26.8495
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: a6c4a0fd-749f-4de2-7a73-08d98ca98b9c
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM5EUR03FT046.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB5761



> On 11 Oct 2021, at 10:39, Julien Grall <julien@xen.org> wrote:
>=20
> Hi Luca,
>=20

Hi Julien,

> On 11/10/2021 09:03, Luca Fancellu wrote:
>> +static bool __init is_boot_module(int dt_module_offset)
>> +{
>> +    if ( (fdt_node_check_compatible(fdt, dt_module_offset,
>> +                                    "multiboot,kernel") =3D=3D 0) ||
>> +         (fdt_node_check_compatible(fdt, dt_module_offset,
>> +                                    "multiboot,ramdisk") =3D=3D 0) ||
>> +         (fdt_node_check_compatible(fdt, dt_module_offset,
>> +                                    "multiboot,device-tree") =3D=3D 0) =
)
>> +        return true;
>=20
> A boot module *must* have the compatible "multiboot,module". I would pref=
er if we simply check that "multiboot,module" is present.
>=20
> This will also make easier to add new boot module in the future.

I thought that also the XSM policy was a multiboot,module so I checked expl=
icitly for kernel, ramdisk, device-tree that are supported
by domU.

Do you still think that I should check just for multiboot,module instead?

Cheers,
Luca


>=20
>> +
>> +    return false;
>> +}
>> +
> Cheers,
>=20
> --=20
> Julien Grall



From xen-devel-bounces@lists.xenproject.org Mon Oct 11 11:27:46 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 11:27:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.205815.361216 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZtT7-0001El-Q3; Mon, 11 Oct 2021 11:27:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 205815.361216; Mon, 11 Oct 2021 11:27:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZtT7-0001Ee-Md; Mon, 11 Oct 2021 11:27:45 +0000
Received: by outflank-mailman (input) for mailman id 205815;
 Mon, 11 Oct 2021 11:27:44 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mZtT6-0001EF-C5
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 11:27:44 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mZtT5-0003qj-JA; Mon, 11 Oct 2021 11:27:43 +0000
Received: from 54-240-197-238.amazon.com ([54.240.197.238]
 helo=[192.168.17.141]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mZtT5-0005T9-DL; Mon, 11 Oct 2021 11:27:43 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=wo43l+07A3vRW/dVAD6N8tTmkv+fJZSm8PxfC68V9vg=; b=ZHnwJK14ojE8fkr5484oLhdpK+
	DOEQuHRkZNC76TP6CJKlUiczeYO7ans1WJZ3iOT3AYaZ+NxSPtkEfLFX3yygsNWUMnC6/o6lxMSoi
	m/UV0ZxB6EGkP5x0SJNgkQgPBx0D+8s7hkXNw1UF7rhNCivRwYE465VN2dMQkItKKiSw=;
Message-ID: <9fe6cda4-698b-3c87-6d9b-405405a85bbb@xen.org>
Date: Mon, 11 Oct 2021 12:27:41 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.2.0
Subject: Re: [PATCH V5 3/3] xen/arm: Updates for extended regions support
To: Oleksandr <olekstysh@gmail.com>,
 Stefano Stabellini <sstabellini@kernel.org>
Cc: xen-devel@lists.xenproject.org,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <1633519346-3686-1-git-send-email-olekstysh@gmail.com>
 <1633519346-3686-4-git-send-email-olekstysh@gmail.com>
 <alpine.DEB.2.21.2110061843360.3209@sstabellini-ThinkPad-T480s>
 <a5a81348-4b18-6be6-ba85-4c31172459dc@gmail.com>
 <alpine.DEB.2.21.2110071300380.414@sstabellini-ThinkPad-T480s>
 <ff6800b3-74f0-3203-6465-1547644924e2@gmail.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <ff6800b3-74f0-3203-6465-1547644924e2@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi Oleksandr,

On 07/10/2021 21:29, Oleksandr wrote:
>>>>> @@ -1193,8 +1215,8 @@ static int __init make_hypervisor_node(struct 
>>>>> domain
>>>>> *d,
>>>>>            u64 start = ext_regions->bank[i].start;
>>>>>            u64 size = ext_regions->bank[i].size;
>>>>>    -        dt_dprintk("Extended region %d: %#"PRIx64"->%#"PRIx64"\n",
>>>>> -                   i, start, start + size);
>>>>> +        printk("Extended region %d: %#"PRIx64"->%#"PRIx64"\n",
>>>>> +               i, start, start + size);
>>>> Also should be PRIpaddr
>>> I thought I needed to change specifier only for variables of type 
>>> "paddr_t",
>>> but here "u64".
>> Sorry, you are right.
>>
>> I added my reviewed-by and made the small typo changes on commit.
> 
> Thanks! In case if you haven't committed the patch yet, let's please 
> wait for Julien (who asked for this follow-up) to review it.

I went through it. The change looks good to me. No need for...

> 
> In any case, I will be able to do another follow-up if needed.

... another follow-up. Thanks for sending a patch to handle my requests! :)

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Mon Oct 11 11:30:07 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 11:30:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.205825.361227 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZtVL-0002CE-Ba; Mon, 11 Oct 2021 11:30:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 205825.361227; Mon, 11 Oct 2021 11:30:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZtVL-0002Bv-8M; Mon, 11 Oct 2021 11:30:03 +0000
Received: by outflank-mailman (input) for mailman id 205825;
 Mon, 11 Oct 2021 11:30:01 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Tf9x=O7=arm.com=michal.orzel@srs-us1.protection.inumbo.net>)
 id 1mZtVJ-0001wn-GH
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 11:30:01 +0000
Received: from foss.arm.com (unknown [217.140.110.172])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTP
 id a8fb7d6f-80a9-4867-95c1-b152ec312d12;
 Mon, 11 Oct 2021 11:30:00 +0000 (UTC)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id F2A83ED1;
 Mon, 11 Oct 2021 04:29:59 -0700 (PDT)
Received: from [10.57.19.78] (unknown [10.57.19.78])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 85A823F66F;
 Mon, 11 Oct 2021 04:29:57 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a8fb7d6f-80a9-4867-95c1-b152ec312d12
Subject: Re: [PATCH v5 07/11] xen/domctl: Introduce XEN_DOMCTL_CDF_vpci flag
To: Stefano Stabellini <sstabellini@kernel.org>,
 Julien Grall <julien.grall.oss@gmail.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 Rahul Singh <rahul.singh@arm.com>, xen-devel
 <xen-devel@lists.xenproject.org>, Bertrand Marquis
 <bertrand.marquis@arm.com>, Andre Przywara <Andre.Przywara@arm.com>,
 Christian Lindig <christian.lindig@citrix.com>, David Scott
 <dave@recoil.org>, Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <cover.1633540842.git.rahul.singh@arm.com>
 <20d5b9d6a0d01a7b90711d28cbefb5701a88b438.1633540842.git.rahul.singh@arm.com>
 <548fa153-b2e3-7f91-c7c9-a569e13b5809@citrix.com>
 <CAJ=z9a2kYdYB9fSXX8NhLk90px03z8+D-YE5AQKW9uABx9kvrQ@mail.gmail.com>
 <alpine.DEB.2.21.2110081433110.25528@sstabellini-ThinkPad-T480s>
From: Michal Orzel <michal.orzel@arm.com>
Message-ID: <8a58a981-f474-cf6d-f16a-46805384a776@arm.com>
Date: Mon, 11 Oct 2021 13:29:46 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.21.2110081433110.25528@sstabellini-ThinkPad-T480s>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit

Hi Stefano,

On 08.10.2021 23:46, Stefano Stabellini wrote:
> On Fri, 8 Oct 2021, Julien Grall wrote:
>> Hi Andrew,
>>
>> On Fri, 8 Oct 2021, 20:07 Andrew Cooper, <andrew.cooper3@citrix.com> wrote:
>>       On 06/10/2021 18:40, Rahul Singh wrote:
>>       > Introduce XEN_DOMCTL_CDF_vpci flag to enable VPCI support in XEN.
>>       > Reject the use of this new flag for x86 as VPCI is not supported for
>>       > DOMU guests for x86.
>>       >
>>       > Signed-off-by: Rahul Singh <rahul.singh@arm.com>
>>       > Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
>>       > Acked-by: Christian Lindig <christian.lindig@citrix.com>
>>
>>       I'm afraid this logic is broken.
>>
>>       There's no matching feature to indicate to the toolstack whether
>>       XEN_DOMCTL_CDF_vpci will be accepted or not.  The usual way of doing
>>       this is with a physinfo_cap field.
>>
>>
>> I am slightly puzzled by this. I am assuming you are referring to XENVER_get_features which AFAICT is a stable interface. So why should we
>> use it to describe the presence of an unstable interface?
>>
>>
>>       This flag needs using in Patch 10 to reject attempts to create a VM with
>>       devices when passthrough support is unavailable.
>>
>>
>> May I ask why we can't rely on the hypervisor to reject the flag when suitable?
>>
>>
>>       Ian, for the 4.16 release, this series either needs completing with the
>>       additional flag implemented, or this patch needs reverting to avoid us
>>       shipping a broken interface.
>>
>>
>> I fail to see how the interface would be broken... Would you mind to describe a bit more what could go wrong with this interface?
> 
> 
> After chatting with Andrew on IRC, this is my understanding.
> 
> Today if pci=[] is specified in the VM config file then
> XEN_DOMCTL_CDF_vpci is added. If Xen doesn't support it, Xen returns
> an error but libxl/xl won't be able to tell exactly why it fails. So xl
> will end up printing a generic VM creation failure. Andrew would like to
> see something like the following in libxl:
> 
> if ( PCI_devices && !cap.vcpi )
>     error("Sorry - PCI not supported")
> 
> So that the user gets a clear informative error back rather than a
> generic VM creation failure. Also, this is a requirement for the stable
> hypercall interface.
> 
> 
> I think that's fine and we can implement this request easily by adding
> XEN_SYSCTL_PHYSCAP_vpci. Rahul or Bertrand, are you guys happy with
> doing that? Otherwise I could take it on.
> 
> 
> As a side note, given that PCI passthrough support is actually not yet
> complete on ARM, we could even just do the following in xl/libxl:
> 
> if ( PCI_devices )
>     error("Sorry - PCI not supported")
> 
> or temporarily remove XEN_DOMCTL_CDF_vpci until PCI passthrough gets
> finalized.
> 
As Rahul is on leave:
I'm ok to introduce XEN_SYSCTL_PHYSCAP_vpci. I did the same for vpmu so it's ok.
However the problem I have is about setting this cap.
On arm it is easy as we are not supporting vpci at the moment so the cap can be set to false.
But how to deal with this cap in x86 code? I'm not familiar with x86 so I'm asking for advice.

Cheers,
Michal


From xen-devel-bounces@lists.xenproject.org Mon Oct 11 11:32:07 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 11:32:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.205833.361238 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZtXK-0003Ii-OD; Mon, 11 Oct 2021 11:32:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 205833.361238; Mon, 11 Oct 2021 11:32:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZtXK-0003Ib-KQ; Mon, 11 Oct 2021 11:32:06 +0000
Received: by outflank-mailman (input) for mailman id 205833;
 Mon, 11 Oct 2021 11:32:05 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=9TNE=O7=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mZtXJ-0003IQ-Cs
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 11:32:05 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id db5606b0-2a86-11ec-80d4-12813bfff9fa;
 Mon, 11 Oct 2021 11:32:04 +0000 (UTC)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2055.outbound.protection.outlook.com [104.47.14.55]) (Using
 TLS) by relay.mimecast.com with ESMTP id de-mta-9-8pczssfdMXqlPZG0LOB65w-2;
 Mon, 11 Oct 2021 13:32:02 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB4190.eurprd04.prod.outlook.com (2603:10a6:803:4b::23)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18; Mon, 11 Oct
 2021 11:32:01 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4587.026; Mon, 11 Oct 2021
 11:32:01 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS8PR04CA0201.eurprd04.prod.outlook.com (2603:10a6:20b:2f3::26) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.21 via Frontend
 Transport; Mon, 11 Oct 2021 11:32:00 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: db5606b0-2a86-11ec-80d4-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1633951923;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=GYeOwNmNHEfe5DbtsDFiY6vhm/wM8AgtfL2GyOpfctc=;
	b=SllMLqqZpjpB2iDeuW3OgN++yIKbZTaYTKd+PAYdA8wBJbNSwgw3b6OVsmnmg1Oy0MPq5A
	pveEwS9FK/ZKdXeUa3YxJKNkQjPzcYx8uHT04b5bc2kcNMyiQUCvSEcTcgeT9oXMaZccqL
	IsoluhYLObHfM22RHv890by1l5FWcw8=
X-MC-Unique: 8pczssfdMXqlPZG0LOB65w-2
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=cJRvp7YCwLOhXhzTFeHES65wcLJAMVZcGtKzNeFzpFYkhU3w9n/nAVMUjRPVvEnAvOCHFHiboH9Cdbky42SCLiSER5y3Lx+J+HLUzuHOXmf1wDg3xJyTk0wsLSELBGjUGcFeU40AJZQTygsR/5lglLp030pu2mBNsDdNA05MCqMD49OZJVPW4mKXJcipcwVSGDUnNCqoTnbnBWsIvmZnChtazIYX29aRrIYem7DHQiJHXCfr5oJDrsQKMHJW3Hj+IByiNoP3IaWJ2Bt69wLvkx4IzNOOs4U+sBRqp8QGY6wzh1VWVA93Xb8ZrEGqCoRmc2RTIJX9tpUTencEI7hX6w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=GYeOwNmNHEfe5DbtsDFiY6vhm/wM8AgtfL2GyOpfctc=;
 b=kXfzn8BrEOC19OQAlDEPbrZ3JucW8ptdFlsQ73DOrhq0/e5ci3vJlIQjNrRPhmO8GTllLWnIp2uIYsc7FaWqGJXPjiDD8y3w+LOOOZINuUY87P+NARmoo4VZeuonFUIVKQaCtB4+4hzMDlxkFLubX3AXZHAkNwU2Yzwcf3j+W4PwSqu0YsvbLhxrwYz7QkN/Ikmb5CiWHg9TrJ7rTbw8Gn5EQktT5vU1HTrmxsZ4eIrgrsn5DkXSLs0YuYS+g/EwJi9UsxEwFE36s8ru6zlwANlrA2QZNu/kSO8n01pVpVtjmDPQHz1+K1ctX2u3ku43xR6rB4OsJK26FFBcUoRYcg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [XEN PATCH v7 21/51] build: set ALL_OBJS to main Makefile; move
 prelink.o to main Makefile
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 xen-devel@lists.xenproject.org
References: <20210824105038.1257926-1-anthony.perard@citrix.com>
 <20210824105038.1257926-22-anthony.perard@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <304c1ddc-7bbc-e942-4c5a-8395a750b13d@suse.com>
Date: Mon, 11 Oct 2021 13:31:59 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <20210824105038.1257926-22-anthony.perard@citrix.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8PR04CA0201.eurprd04.prod.outlook.com
 (2603:10a6:20b:2f3::26) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: b7c73327-6417-4d5e-5325-08d98caabdfc
X-MS-TrafficTypeDiagnostic: VI1PR04MB4190:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB41909259B66E98EF1037FE0EB3B59@VI1PR04MB4190.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:813;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	lXUyHUnUA8IBLLr9UHy/078qOuremVh2yUZ8lsql9xKIMDDhiHGNk0sNxTH7EVxYkNvQrSmkFv6pPPltcUcKd+HvDg7vFYgvr1F99OJYoRX4sovXOB3u6+pzyHFBhstN91iyjAm4g/P17l2oySeLpVPDB7BteH+43yLJPBF9zB3vQYqPSZGfQ7MKsElEiWCm/Nn3POvRx3bpIn+bN2JQTtQOQ2dwyZcC6kMsQ20LDEH5S/MFc3oeJ+WlFH3rs0D/ngGb6hB2mH3XloR6dkapQozRDeUbH56e/VTHYw8qoCr6OlBuADUrZvYCMbZoPt1JwScrWAFVx6nZd9mLfTkqbqXsPR30b1RsRYMk7mqgO9RxznfnPwaDtl543bb/K2EUe2Z2crmVny1X3YDeyyVLhI9dDwXF7hIUm3n8SVgjVUSwW1Ww/yNb7YObA9WlsYJR12dF0TC/FkMIwmibMUh0vW0ej1RXH4UfBQyOCVhc9pKX0YhEQxImjYEect4G2gRvv8FsM3uy6eA1sOTkt3R8MkqS1JMuM6ygaPCdP7VGmmYjH7WeB2DVtwlAAC56/I4hAWr3CNJOd6msS9Q+64afLjKQxlwvs2bUDRk1KFBBX9DsozAakBjfdzVIabdSkQqV2yWWPam8/Bnd1e40PQmQuczrV/nZPsxZOuG8GmZA7Nhwmo2QlTWFvVjc5mt2yu46J/Q7mvXTyVZRoEXccEYJxmqyeC4wKoh0VLaCJwT0Z850lP7tvDWHhQLy0jS61MmU
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(6916009)(8936002)(31696002)(54906003)(956004)(66946007)(86362001)(6486002)(2616005)(7416002)(4326008)(83380400001)(66556008)(66476007)(316002)(508600001)(5660300002)(36756003)(31686004)(16576012)(38100700002)(8676002)(26005)(186003)(53546011)(2906002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?ZWJ5MnBsdVlUYTNwdUVpZDZhNnRhNEJ4dUs1WDh3b0xZdU5wNjhFVUdVZU85?=
 =?utf-8?B?MlpqTTBxdW9EVTRtOFAyckRUSFhIYW1MdkUzYkxWdW5WWDlrc01aNTlZMnpP?=
 =?utf-8?B?M1lpcGVvUmljU0Z3YnZBckYrUFpxWHJOVXVEWDZGeUI2NTdTWXhnbkdYWklQ?=
 =?utf-8?B?Y0U1WkVESVBhcFJaOElicUUxSnFIZ20wZWw0RXJjNFM4cmFjWVFBSUxwSXpD?=
 =?utf-8?B?bzREcG9LY1AyU0hzRkpvTmUwYWRudm9EV3FySDRGUkxGVlNUc3owcG5DamNE?=
 =?utf-8?B?R3JsQS9GejhkME0vUm1zYjNPcEVjckpVanRnd3ZGamJoTmV6NmpiRm1TbWtk?=
 =?utf-8?B?TTRtTDZNdkdqVnpwcERxN3JsUnJUMitUVDExOHBFVFZxbWVxZnpCcm16SzJs?=
 =?utf-8?B?aWdRUjBiYkJLaXAzUEZOMk5NdFhIQ3M2bVlsdnBpbktmSUVHQ25uRmF6MkNF?=
 =?utf-8?B?NkFTZUdLQW1ubHBmbFMrVzY2VDFRd1dWS0Q1VFJBcDRRTllBRTBsK0xsNy9Q?=
 =?utf-8?B?QnFtL005WFRoamFKeDFqVG1iaElYbWZKd1EvZ1ZJUGtNWnpvSUp6Z2w5WnpL?=
 =?utf-8?B?UGRIcllxQkdDc1ZRdkN3V0JBcGFZVDdpam11R0hKam9LN3hiM01LaVdPekxo?=
 =?utf-8?B?cWF4ZGNrT1ZaVTV2bk5nRmVtaG1PQWFzYy9rdTdrVXlTcHJ1Q2F0aktZZC9E?=
 =?utf-8?B?T21XbDhYQlN1NHVLYmhmU0JGdVFrVW1SQ1AyWTBvcTYrL242VW05VlRsMmh3?=
 =?utf-8?B?OHAyQWE3Umh0S2xjemh2dk1XSHFOL0t5YnIvek8zM1dieGpuWFU2NVNGSkI0?=
 =?utf-8?B?WlhlSUdaK3VpR1cwakhRdkhGTkNyUHBFTXBTdyt1QnVUeGRuRGNuNmpJUVN4?=
 =?utf-8?B?UVJQVE16MW8zRlIyM3c2bUYwYWFrN1dnV0xWNnhVbC9EdjhrcjYwZjZxY3Fp?=
 =?utf-8?B?S245eHVJRmlkdkhLYUZJNDZrd3pQK2xlUStQQjc4WUY5WVcvRmJlN0tHMkw5?=
 =?utf-8?B?Y2tKZXV4c29rYzIvZTloejNwZ3hvb21JSytUdHpKNkRGSUdtcEFtV2JQQWFD?=
 =?utf-8?B?NEJ0dmJDMEljd01ZQmhqbkdiTTBFSFowQjZ3d0JZV3lJYzZIZzE5ckpxaGdJ?=
 =?utf-8?B?ZEJLZitSbFEyb0grSzJUdUFodXdoRkt2ZTlQWm5vYnI4MmozRkJpTTFJSTEw?=
 =?utf-8?B?ZTQ1Vm11NVM4V0hmL1VBNEVJQSsycHM2ZldjZkxLZXU5aHNiMDNoYzEzRXNE?=
 =?utf-8?B?RDI3a0xkMktOZzJxaEFvSTNEZHRLU2RKWG44aytBeVBidVVaZ05IcDE2WHBz?=
 =?utf-8?B?UnNQdUgySVI5eG1MUXdiWXVRQ2x1ZVAxVDhHQzFpbDIyb09wZnFHMXRXdXV6?=
 =?utf-8?B?NXpNeHlGVjBocHplNDd5d0FIUmNNNEsxTE1LbmYrUzROR0dCRlF0TFNRdkhK?=
 =?utf-8?B?aTEzRFM0YmVJWGNoQ0h4MTh5L2NFdVdBSjZTNmZLOUNYbVB0MkpYQU5GcVd0?=
 =?utf-8?B?bkZvVXV3UjZHTXRsOXRhUzZ2UGdHMjJUb2lRaGl6STBJejk5c1djUFROVTZ5?=
 =?utf-8?B?ZUJOeldLeElDSE5JZ3d5NGg2TVhiY2pNcmtIQTgyMzNuWFpjSHhJRmlOVUJ3?=
 =?utf-8?B?amUwaVhEN2pFUmRoWEpPaE0vT1VsREg4bXh3MDgvQnYxaU1WWnorR3J2Q0Fo?=
 =?utf-8?B?NlhiYThMU3FQSytZNXF0Rk5oWGpMN05qRU1zbnBUT3NkazZqVmdFMUNTZGty?=
 =?utf-8?Q?ROGNDtSrSLzc7OPR6sqKkXDuYqUZV+Jc4F/DrZI?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b7c73327-6417-4d5e-5325-08d98caabdfc
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2021 11:32:01.2653
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 07a0jjic8U3cooxlfDaQ8z6SCOY8mFP79ZZlxlFGGM1ibZXrGEkzeM9JFsyF6sD05TL3iEGlRUlZqqtSOU+COw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4190

On 24.08.2021 12:50, Anthony PERARD wrote:
> --- a/xen/Makefile
> +++ b/xen/Makefile
> @@ -271,8 +271,21 @@ CFLAGS += -flto
>  LDFLAGS-$(CONFIG_CC_IS_CLANG) += -plugin LLVMgold.so
>  endif
>  
> +# Note that link order matters!
> +ALL_OBJS-y                := common/built_in.o
> +ALL_OBJS-y                += drivers/built_in.o
> +ALL_OBJS-y                += lib/built_in.o
> +ALL_OBJS-y                += xsm/built_in.o
> +ALL_OBJS-y                += arch/$(TARGET_ARCH)/built_in.o
> +ALL_OBJS-$(CONFIG_CRYPTO) += crypto/built_in.o
> +
> +ALL_LIBS-y                := lib/lib.a
> +
>  include $(BASEDIR)/arch/$(TARGET_ARCH)/arch.mk
>  
> +export ALL_OBJS := $(ALL_OBJS-y)
> +export ALL_LIBS := $(ALL_LIBS-y)
> +
>  # define new variables to avoid the ones defined in Config.mk
>  export XEN_CFLAGS := $(CFLAGS)
>  export XEN_AFLAGS := $(AFLAGS)
> @@ -393,7 +406,7 @@ $(TARGET): FORCE
>  	$(MAKE) -f $(BASEDIR)/Rules.mk -C include
>  	$(MAKE) -f $(BASEDIR)/Rules.mk -C arch/$(TARGET_ARCH) include
>  	$(MAKE) -f $(BASEDIR)/Rules.mk arch/$(TARGET_ARCH)/include/asm/asm-offsets.h
> -	$(MAKE) -f $(BASEDIR)/Rules.mk -C arch/$(TARGET_ARCH) $@
> +	$(MAKE) -f $(BASEDIR)/Rules.mk $@

This merely results in what was previously invoked from here now getting
invoked from the very bottom of build.mk. I'm afraid I don't see why this
is a useful change to make.

> --- a/xen/build.mk
> +++ b/xen/build.mk
> @@ -56,3 +56,27 @@ arch/$(TARGET_ARCH)/include/asm/asm-offsets.h: asm-offsets.s
>  	  sed -rne "/^[^#].*==>/{s:.*==>(.*)<==.*:\1:; s: [\$$#]: :; p;}"; \
>  	  echo ""; \
>  	  echo "#endif") <$< >$@
> +
> +# head.o is built by descending into arch/arm/$(TARGET_SUBARCH), depends on the
> +# part of $(ALL_OBJS) that will eventually recurse into $(TARGET_SUBARCH)/ and
> +# build head.o
> +arch/arm/$(TARGET_SUBARCH)/head.o: arch/arm/built_in.o
> +arch/arm/$(TARGET_SUBARCH)/head.o: ;

This previously lived in an Arm-specific file. Moving this here in the
given, still Arm-specific form is imo a no-go when done alongside all
the other good changes you're making. Is there a reason this can't go
into xen/arch/arm/arch.mk?

Jan



From xen-devel-bounces@lists.xenproject.org Mon Oct 11 11:32:29 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 11:32:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.205837.361249 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZtXg-0003ne-Vs; Mon, 11 Oct 2021 11:32:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 205837.361249; Mon, 11 Oct 2021 11:32:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZtXg-0003nX-Sn; Mon, 11 Oct 2021 11:32:28 +0000
Received: by outflank-mailman (input) for mailman id 205837;
 Mon, 11 Oct 2021 11:32:27 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mZtXf-0003m6-L8
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 11:32:27 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mZtXe-0003wh-Kw; Mon, 11 Oct 2021 11:32:26 +0000
Received: from 54-240-197-230.amazon.com ([54.240.197.230]
 helo=[192.168.17.141]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mZtXe-00061m-Ee; Mon, 11 Oct 2021 11:32:26 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=7TsBDO2sFjHO2M/jmRz1Mme72nCGKt2uR+2SiyPmsik=; b=KJGi+kgSlIgRLy+LtnLmwYuMOp
	DfDbee9hsMlZktyI/jXiKvKzAQC+JKEysLqfA5bnFa98GxRZYysVZNnkrJDna8XPXdp1X4e97LOUH
	NbmbyL7hqqdxwauoipRddquGYJZhBTkOM8zmcszMm4wP+lFf2E+qvkXlJXmhDQn7cIE4=;
Message-ID: <bfe9cb38-7b06-2d99-2e4a-b5025f4c1ab0@xen.org>
Date: Mon, 11 Oct 2021 12:32:23 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.2.0
Subject: Re: [PATCH v5 1/2] arm/efi: Use dom0less configuration when using EFI
 boot
To: Luca Fancellu <luca.fancellu@arm.com>
Cc: xen-devel@lists.xenproject.org,
 Bertrand Marquis <bertrand.marquis@arm.com>, wei.chen@arm.com,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Jan Beulich <jbeulich@suse.com>, Wei Liu <wl@xen.org>
References: <20211011080302.24203-1-luca.fancellu@arm.com>
 <20211011080302.24203-2-luca.fancellu@arm.com>
 <81e30575-d823-830b-6f80-4e7a7fb4f9ff@xen.org>
 <BC2506EC-8BCD-487C-AFF4-0C99A9020BDA@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <BC2506EC-8BCD-487C-AFF4-0C99A9020BDA@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Luca,

On 11/10/2021 12:23, Luca Fancellu wrote:
> 
> 
>> On 11 Oct 2021, at 10:39, Julien Grall <julien@xen.org> wrote:
>>
>> Hi Luca,
>>
> 
> Hi Julien,
> 
>> On 11/10/2021 09:03, Luca Fancellu wrote:
>>> +static bool __init is_boot_module(int dt_module_offset)
>>> +{
>>> +    if ( (fdt_node_check_compatible(fdt, dt_module_offset,
>>> +                                    "multiboot,kernel") == 0) ||
>>> +         (fdt_node_check_compatible(fdt, dt_module_offset,
>>> +                                    "multiboot,ramdisk") == 0) ||
>>> +         (fdt_node_check_compatible(fdt, dt_module_offset,
>>> +                                    "multiboot,device-tree") == 0) )
>>> +        return true;
>>
>> A boot module *must* have the compatible "multiboot,module". I would prefer if we simply check that "multiboot,module" is present.
>>
>> This will also make easier to add new boot module in the future.
> 
> I thought that also the XSM policy was a multiboot,module so I checked explicitly for kernel, ramdisk, device-tree that are supported
> by domU.

The XSM policy is indeed a multiboot module and should not be used by 
the domU.

> 
> Do you still think that I should check just for multiboot,module instead?

Yes please. I think this is not the EFI stub job to check that the most 
specific compatible is correct.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Mon Oct 11 11:35:30 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 11:35:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.205850.361260 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZtaY-0004YC-Fh; Mon, 11 Oct 2021 11:35:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 205850.361260; Mon, 11 Oct 2021 11:35:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZtaY-0004Y5-CX; Mon, 11 Oct 2021 11:35:26 +0000
Received: by outflank-mailman (input) for mailman id 205850;
 Mon, 11 Oct 2021 11:35:25 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=9TNE=O7=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mZtaX-0004Xz-KQ
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 11:35:25 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 2b535b19-9ee4-4ec8-9b4b-9875c4bb7bc6;
 Mon, 11 Oct 2021 11:35:24 +0000 (UTC)
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur01lp2059.outbound.protection.outlook.com [104.47.2.59]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-13-U2IVKeUZOfSsx3grnKGhzQ-1; Mon, 11 Oct 2021 13:35:22 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB6303.eurprd04.prod.outlook.com (2603:10a6:803:f2::15)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.19; Mon, 11 Oct
 2021 11:35:20 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4587.026; Mon, 11 Oct 2021
 11:35:20 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS9PR06CA0315.eurprd06.prod.outlook.com (2603:10a6:20b:45b::26) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.21 via Frontend
 Transport; Mon, 11 Oct 2021 11:35:19 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2b535b19-9ee4-4ec8-9b4b-9875c4bb7bc6
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1633952123;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=M2Q/kNKt7Wg1wN6se+T+QoqpPsh2IyrVKNwyiWmatMM=;
	b=Rd9S93OEjLg+8Yvt5VF2uW4iTZBKI6ltr39DRusXEAimDU+HQ0DWgpWimmn0kZ1dAMwGtI
	jOW2OqLihauLK+/xKFy4mKbEiOX78jIMEd/h9rziSkEYOnoFOXGBLIGSjAWpGdFP33YOkE
	m4AC3GmOEQi3uRG8vxP4Ut4Lj+W+HOE=
X-MC-Unique: U2IVKeUZOfSsx3grnKGhzQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Mb7Ro0R2F28bcKFKq9g+CeWrqWJB2nd8GCIZQiqRmfU9Tf/89abxrVg2scL97wSJv6Ypmh1b8MiFpG5/YkTYv7v9rxmLmhFVi42tcg3WtRhB8wR4ibZjBI+DQtvADVqNNz788+tB1hnlvSTmWntnHLb7yaOhxMX87SRxSJIP9+3hz+I7oSsEOkNc8gF9o/ZZSXphq4Fb2qJGF7rf7xq6Bz9JKNvjC0pOcCSiKccsoWFsapP1ikksZF6todYcZRX4hx0lAhirPIBdL/LlZxHePvEae8ocCYoiX94xpyQAY+Dkyb8TuxyRKUuPw8i7kR365u8aZsQ0cZhA0DkeGqtt2w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=pCklJSUC56Ik8KCpGdECY9v5W0ppVbf9FfW0FeP/AQ4=;
 b=J8FquphSZg5L+ODVzJj1EFedUTIn5KS3bIUoZpUydan+bcGno0ZZlRtPgIVeXZm97yYSxLy8TQ5L0HKswBktZGrsIouelyAnZFrnrpQ4vIRzrHRpxuq59BgozBTNI7vQlYkkgHhOWWBgbd+bMrHha1nRp+wn9qajLPgZlMTec+6IlQMWB2+x1dRxw6rTJb3nX5socnLs61RH3emxVew4ol515ekcjLfzBtrV+HeGrkXJW9+iq//78OTo1O4tYhT7Aob9ZzRfrRRqWpjmjcSXJHfX0ELs3X2VAE429w1ohDfMnRrNa8bMqiamYbW8JHlrQ6b+2/XYBYdFyHh3aDkYEA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: kernel.org; dkim=none (message not signed)
 header.d=none;kernel.org; dmarc=none action=none header.from=suse.com;
Subject: Re: [PATCH v5 07/11] xen/domctl: Introduce XEN_DOMCTL_CDF_vpci flag
To: Michal Orzel <michal.orzel@arm.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: Andrew Cooper <andrew.cooper3@citrix.com>,
 Rahul Singh <rahul.singh@arm.com>, xen-devel
 <xen-devel@lists.xenproject.org>, Bertrand Marquis
 <bertrand.marquis@arm.com>, Andre Przywara <Andre.Przywara@arm.com>,
 Christian Lindig <christian.lindig@citrix.com>, David Scott
 <dave@recoil.org>, Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>,
 George Dunlap <george.dunlap@citrix.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Julien Grall <julien.grall.oss@gmail.com>,
 Stefano Stabellini <sstabellini@kernel.org>
References: <cover.1633540842.git.rahul.singh@arm.com>
 <20d5b9d6a0d01a7b90711d28cbefb5701a88b438.1633540842.git.rahul.singh@arm.com>
 <548fa153-b2e3-7f91-c7c9-a569e13b5809@citrix.com>
 <CAJ=z9a2kYdYB9fSXX8NhLk90px03z8+D-YE5AQKW9uABx9kvrQ@mail.gmail.com>
 <alpine.DEB.2.21.2110081433110.25528@sstabellini-ThinkPad-T480s>
 <8a58a981-f474-cf6d-f16a-46805384a776@arm.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <b084240e-cba5-4b20-5eef-f21915cfce2a@suse.com>
Date: Mon, 11 Oct 2021 13:35:18 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <8a58a981-f474-cf6d-f16a-46805384a776@arm.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS9PR06CA0315.eurprd06.prod.outlook.com
 (2603:10a6:20b:45b::26) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 82ad1dc0-2a19-4255-739b-08d98cab34d7
X-MS-TrafficTypeDiagnostic: VI1PR04MB6303:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB630325B639190BF7E8228AC1B3B59@VI1PR04MB6303.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	kjhNwCC5LF8PKI/uDRPRwoBk7h7wT8Rf7Yjlak9aORwafpoG/RO81bYvCkVpzPdBD72vm1uMuPCUs+tAhLOFAuy5Xv6zjQSIeBCfiZrtCx4TepJFE0eW0wYkiaFKd4O4YAqSCbGwlVC4Lc4813sR2Y/kyylJv6BOcioJmr8793tIYzuLZT18ILA9uUdgly+mtxcf2xDnEk5qYgnLiLAsVKADGJYz+jW9Xo91BeesSOoBy+na4qSqh3hWwOgfk0U0YSIKmry6mONV/QJGgrRTCSWyU6EJ9xt4KWBQgjJm4c567pfy2cjLg8L5gGu1kDd7sBYlFcUZGdNm1Br5sH6/bjrGl6OSWVspWCjeJQD53B7WfVHlXyqgh3oTDSTcQ9nle9aFNIrbdbj7/CQmFPGfCMGZSLOEBav8LziVE3qS2BEIJ/+CeMlpdOF2sbWDrlAQ2NAh7ySBrZvpeAtl+DFOGVTzftIJb3oGEaV6C9OLnaFLInNrP7auo+5XkHmxozyZS6OdI1bnoyWTmfKQ/ODSzgQTsjVvsesCwH7DoUXPtsP7V1eGuocsiJ1EEzANO5ivvBYTxTJYyMfAI2G5yO/QVzfI20Iygsx5C3pD0UjTPi+aoUH7wtFp74vfhNGJFPrbc2ndFe+zou7BawPbsVLWhWB74xHgM7XurhrZtJKGL0vnXrZ1oM0PFlYEunIxxUlkYHDcW7u+dB8a9T4w7EA9M0JkiSJSyHZy6J8mHm2PPDr3qDe2wer5fgpKQpNY45cH
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(38100700002)(7416002)(31696002)(83380400001)(2906002)(5660300002)(4326008)(36756003)(8676002)(16576012)(66946007)(86362001)(66556008)(508600001)(6486002)(8936002)(186003)(110136005)(66476007)(31686004)(54906003)(53546011)(316002)(956004)(2616005)(26005)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?r2rDP+j5InLsQjliadar+JbX0RKI44oGA6Awyl/mAe0XPmwPgBcAKtIJteNE?=
 =?us-ascii?Q?QXXw+NGkAY5FrvLj7yANRiObVb98dui1xIx3+IFVTq0nScFvX+3KkBOuxSnb?=
 =?us-ascii?Q?VgXgeM+JE6ZIABhyeImTaJimTuFx4IY7uLBrbdPynEir8eg0eOePJexpq63W?=
 =?us-ascii?Q?7jxk/jDDZMAMO6FIdE2I7kKbJZWzjzaCseLOH3fVEjo4gAelzsShKZyPuxdD?=
 =?us-ascii?Q?ZQAfyYMw0rGcFYMsWKs9CHf59WNLFIDPaZxlltqIALJr5ckbjz0v1ojzzIY6?=
 =?us-ascii?Q?Ji7C6OM/yiqaQfhRYHdw85aWLJ/5A+01WIqqZXbzUYyePiQ+xjJcaTXryZds?=
 =?us-ascii?Q?ICxLvi5x4zLvMmlQMC89/qZDIscI/Uh9fq7Ik28R+ODZ/3N67gYWBvkvuLEf?=
 =?us-ascii?Q?3VsNa7Q9rcym/2Rct1xMwC7dkWFS9klqztL68lxJtCN1V0mtcVT03WZFBj9k?=
 =?us-ascii?Q?I78hq+6BxmFjCP403wgWwyF09+UzPv7rhb3iH7Z1rMDBdKW746kQJ6DqjvUS?=
 =?us-ascii?Q?bRdRlwC3mYpO5q86TrdceHWRyUcISWRlq8FKpS5uhWcPTaQYN3vohyPRSgIM?=
 =?us-ascii?Q?MtPfIqTCHGlLwFNyQnkXMJQX3mAK45b5rfO3Q8GRQQrhuDqc4RffD0UPhnIo?=
 =?us-ascii?Q?8CLwqMN24ELCCa4GcN8Rr/ynP47hh4+Mf6ix1K+3oEeeDIIIH2TNw2yPcNT9?=
 =?us-ascii?Q?QF7SsXRE457PNnXn2nLc8C5EAhiOiwWspLRipHVqZKgJONdVp3mqDZkECM5F?=
 =?us-ascii?Q?D6AjhgG+dQF1JS1Pcze6HXG0s+U/32FisPoCA5zwyc6/emEhroqXeSsybHsk?=
 =?us-ascii?Q?HjkiD1cD6FDyJjX8T2Q70+cadZf/Ao2RQw+rvAVBU3JVj50yrOtMPFeAzxlH?=
 =?us-ascii?Q?eu6lLPrZhJy8FEarpbk+kJbqlL9xwL/feOtsRc5NbpBB8oQ/iQDR+hkb6nbA?=
 =?us-ascii?Q?Z7rEsRtq1q6JH0tUnvpc8gXvtlFCfyiG0s9KDEbVP2cQJ9AARd7zxuDQXg4/?=
 =?us-ascii?Q?49B2ddMsJ6//4qq1dvvsLPkiVT9XjX+Axe+XY+WMm2TfHH5KCDDDDB2badzY?=
 =?us-ascii?Q?xMOxDKOmwJcoX6aJMuCs4dTvbsZ+5CACZgLr4U9cBDvQpxE9ukVEcFsXGxiQ?=
 =?us-ascii?Q?wvoG7D57jzXpNQZ0YGOw3SXnFKLjjjI+LG6XiIIAgpBndli11/uSpsKq8r37?=
 =?us-ascii?Q?9SGsmJleaWzeGGm/P9hHRI7F7+VVZjFfRlcbNOTulak2Cm39wHuKA941xVeA?=
 =?us-ascii?Q?h8BNekGTZFywCQE1iOT2fGglgMNN4plqPmuG4VIzJti7I3fGIzwn9LFkaWR3?=
 =?us-ascii?Q?eoc+vBUm8TZsNKNVKaoYNrAG?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 82ad1dc0-2a19-4255-739b-08d98cab34d7
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2021 11:35:20.4656
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: MlZWim/G8vjLEjHz2hqqgflKzdeJ9m3KAH/6BflwMN0857Jd7GTJ1v32qDIQVTlLqXmwanndLlXTthq80yeLlQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6303

On 11.10.2021 13:29, Michal Orzel wrote:
> On 08.10.2021 23:46, Stefano Stabellini wrote:
>> On Fri, 8 Oct 2021, Julien Grall wrote:
>>> On Fri, 8 Oct 2021, 20:07 Andrew Cooper, <andrew.cooper3@citrix.com> wr=
ote:
>>>       On 06/10/2021 18:40, Rahul Singh wrote:
>>>       > Introduce XEN_DOMCTL_CDF_vpci flag to enable VPCI support in XE=
N.
>>>       > Reject the use of this new flag for x86 as VPCI is not supporte=
d for
>>>       > DOMU guests for x86.
>>>       >
>>>       > Signed-off-by: Rahul Singh <rahul.singh@arm.com>
>>>       > Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
>>>       > Acked-by: Christian Lindig <christian.lindig@citrix.com>
>>>
>>>       I'm afraid this logic is broken.
>>>
>>>       There's no matching feature to indicate to the toolstack whether
>>>       XEN_DOMCTL_CDF_vpci will be accepted or not.=C2=A0 The usual way =
of doing
>>>       this is with a physinfo_cap field.
>>>
>>>
>>> I am slightly puzzled by this. I am assuming you are referring to XENVE=
R_get_features which AFAICT is a stable interface. So why should we
>>> use it to describe the presence of an unstable interface?
>>>
>>>
>>>       This flag needs using in Patch 10 to reject attempts to create a =
VM with
>>>       devices when passthrough support is unavailable.
>>>
>>>
>>> May I ask why we can't rely on the hypervisor to reject the flag when s=
uitable?
>>>
>>>
>>>       Ian, for the 4.16 release, this series either needs completing wi=
th the
>>>       additional flag implemented, or this patch needs reverting to avo=
id us
>>>       shipping a broken interface.
>>>
>>>
>>> I fail to see how the interface would be broken... Would you mind to de=
scribe a bit more what could go wrong with this interface?
>>
>>
>> After chatting with Andrew on IRC, this is my understanding.
>>
>> Today if pci=3D[] is specified in the VM config file then
>> XEN_DOMCTL_CDF_vpci is added. If Xen doesn't support it, Xen returns
>> an error but libxl/xl won't be able to tell exactly why it fails. So xl
>> will end up printing a generic VM creation failure. Andrew would like to
>> see something like the following in libxl:
>>
>> if ( PCI_devices && !cap.vcpi )
>>     error("Sorry - PCI not supported")
>>
>> So that the user gets a clear informative error back rather than a
>> generic VM creation failure. Also, this is a requirement for the stable
>> hypercall interface.
>>
>>
>> I think that's fine and we can implement this request easily by adding
>> XEN_SYSCTL_PHYSCAP_vpci. Rahul or Bertrand, are you guys happy with
>> doing that? Otherwise I could take it on.
>>
>>
>> As a side note, given that PCI passthrough support is actually not yet
>> complete on ARM, we could even just do the following in xl/libxl:
>>
>> if ( PCI_devices )
>>     error("Sorry - PCI not supported")
>>
>> or temporarily remove XEN_DOMCTL_CDF_vpci until PCI passthrough gets
>> finalized.
>>
> As Rahul is on leave:
> I'm ok to introduce XEN_SYSCTL_PHYSCAP_vpci. I did the same for vpmu so i=
t's ok.
> However the problem I have is about setting this cap.
> On arm it is easy as we are not supporting vpci at the moment so the cap =
can be set to false.
> But how to deal with this cap in x86 code? I'm not familiar with x86 so I=
'm asking for advice.

As the sysctl is mainly from tool stacks to drive guests (DomU-s), I'd
set it to false for x86 as well. Roger - do you see any reason this
could be needed to express anything Dom0-related?

Jan



From xen-devel-bounces@lists.xenproject.org Mon Oct 11 11:41:35 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 11:41:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.205860.361271 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZtgK-00061w-9o; Mon, 11 Oct 2021 11:41:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 205860.361271; Mon, 11 Oct 2021 11:41:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZtgK-00061p-5x; Mon, 11 Oct 2021 11:41:24 +0000
Received: by outflank-mailman (input) for mailman id 205860;
 Mon, 11 Oct 2021 11:41:23 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=9TNE=O7=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mZtgJ-00061j-9w
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 11:41:23 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 27d4519e-2a88-11ec-80d5-12813bfff9fa;
 Mon, 11 Oct 2021 11:41:22 +0000 (UTC)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2104.outbound.protection.outlook.com [104.47.17.104])
 (Using TLS) by relay.mimecast.com with ESMTP id
 de-mta-14-fI-Mzn-kMCWtTKSI0L3KOA-1; Mon, 11 Oct 2021 13:41:20 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB4607.eurprd04.prod.outlook.com (2603:10a6:803:71::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.19; Mon, 11 Oct
 2021 11:41:18 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4587.026; Mon, 11 Oct 2021
 11:41:18 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6P192CA0047.EURP192.PROD.OUTLOOK.COM (2603:10a6:209:82::24) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4566.16 via Frontend Transport; Mon, 11 Oct 2021 11:41:17 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 27d4519e-2a88-11ec-80d5-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1633952481;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=xrGr5wVVaHopp7AoYHAPc1PIODhQq+mvSjO27YeVW4w=;
	b=A7tQ1ZuKg2YmCvrkQQipg0BQkTlTzW7SblxFFkNCSyTBU+h+ePxhDstan6puniIeOnQlRq
	ky/UaoiZgJkEEHVfjgZ1JRuL9JwO2IYEg/LHpmT6qkoqo8CknznT2jueBcSyWZdcq+ekOl
	iIsZW5aQTVme+YsN3eqUl4JSf4dqpSk=
X-MC-Unique: fI-Mzn-kMCWtTKSI0L3KOA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=oOCYe4s1aoq37XUOepo1tZKyiNuaDXCPgHRZGFA4ksRXF/3RCvw6a2RrrApzYguFVldroGGegLdC23ZiFc8EZ3QtBM+N4bB9TRS/dyzXBWPdsJRLGjVC31ALug+87dtei8Pbr6KGjuulLnJ9cAcRAmjAF+ab/tSakU4k7sd3MoH39qTbCp2Llk39cXhc6NRsUWMtyP/NP86eI8ZQcIwXFQGI+Qy5EEs5jmRUcn107NVen5vtLpc17mEYWCLpapTOz74kg1CpjsxgqWpnhTqbLs7T3Wc4XFpQjTjvH8wdoS8JuL5ZJWeMzsEomk93T5aWhr6bU9ingNS5xoWuKvrOVQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=xrGr5wVVaHopp7AoYHAPc1PIODhQq+mvSjO27YeVW4w=;
 b=oBZRSENxWDkjr6tJMQAUFOGx7bql7a/49qqZmnyqdW2cMlL5hxHwD7a/imnTQ3KP+WsL0vB0o/mmjD+ynwRudawRM3kYFBzJ7KX1YdwrqL8hN9odlerGYYoI/BiwC8Eo0Xg5RCet2gL8K9oFLDawbILZFQOHbCtZ7OcFZx0C81gXYhS99XEajOZ12nVX87ipg9sIguOB/nI9yvKjhc3KvC+Iwb2yxv/6kfhLnFkE7oEV9Zdoq7i/AmgIjaaGhmULQxrX/8oiRdJ3D3419ewOx3bhjvEICLANi4bh8aYS8bTsjafVHVyOCRcoaldeqvT0NXwg2ql0ikyCCMHmTp+Dvg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [XEN PATCH v7 22/51] build: clean common temporary files from
 root makefile
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>, xen-devel@lists.xenproject.org
References: <20210824105038.1257926-1-anthony.perard@citrix.com>
 <20210824105038.1257926-23-anthony.perard@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <dd760c79-e761-3547-726a-4d7ee092d10f@suse.com>
Date: Mon, 11 Oct 2021 13:41:16 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <20210824105038.1257926-23-anthony.perard@citrix.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P192CA0047.EURP192.PROD.OUTLOOK.COM
 (2603:10a6:209:82::24) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: f1e252a9-2370-4437-8d90-08d98cac0a35
X-MS-TrafficTypeDiagnostic: VI1PR04MB4607:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB4607DE5165669683ED69EFBCB3B59@VI1PR04MB4607.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:4941;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	SmkJDjJpHDk0VQo33HHTtb9HeA9Vo6KzDrBZs/aHf7hujYLycBWBkttTRnbe/CydS/V8nI9CvQy9SY+DFv41j9wDmr9LZai1BN+Zonnti14StBqye24cKDXN5qUJm/qUmS4EteRGGAcFAZDQRMznbQjIiXAty2Gb2Xe00B9rWSjPJv0V/+oIcv35m1xCEUUQgzreag7OS9ib8c3nnzehvxMlVDwUOiHJOa8P/+8ENubn1w30rPGX1//pKNhaQh/QV4QjlshwUiGw69UgEm1aKqw9tY7WlXGn4FCaMwKp8ybx3uHEKWu81JrJSnez/9pnW0QWt4TS7jEvNu6pRMsYFoW9Ae9SkfshQS3MgLG2r2H3gvjEOq6RRMbZscikMKBAbFqgJ7bCN0LcWgewpT7LKbKLhV3cfgFuwUMK3M21dEr3Rf4v5DszAbR98ClY7Vq1gHW7B9T3GNHuqz8yetrW9ZN8ErqGOGbmhXYKBomqxK4Mx29lVvXiKC85fdTQAa+g5DrTHcAYbkgsbwfMhrJpYKUi4d9MCUq0IVDiE7ihXq2Y2O89EtzpzLSL+w4dR0TSSHp67+5xGZ7lArfWcts8i2jXETLNupZuCfyzE9Kze8dhVFg3O1tfmqu3kOzwPg9P1gh5bHYrQ0GKMcvfiyUPuHL05wspTqEtp+gkB4QgtJyd6oyQ5eQqLWOzl8HXWN+OlBaSK9Gr0G8TEg5RDOOgGCnzA4UyFyhmeQ3Bi2LZNVyQtgV80vUriCXR2EbACCKy
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(186003)(8936002)(26005)(508600001)(2906002)(8676002)(86362001)(36756003)(53546011)(5660300002)(31686004)(6486002)(4326008)(83380400001)(6916009)(54906003)(66946007)(16576012)(956004)(38100700002)(31696002)(2616005)(316002)(66556008)(66476007)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?RHEvWDFXVTNvdzkvRjVpOE05eWFXYUdQU3oyWjZWWDQvV1JvdlBKZ0d4SG1a?=
 =?utf-8?B?QlNVK3Fqd3kyUnpoRzhQUW9DV2ZvRDdLcENaZzZIc1l4L1ZCZkY3MVgzakI1?=
 =?utf-8?B?UzVsWXBlemRsOEJFTDJKdmhENWdPTGZqYU02N0d0VmJNbHJTN2dUZ214MlFz?=
 =?utf-8?B?Y3FzUk1KRlFDM3ZVaGdoTU9hK2lrc1g3SDhKVU5RSGI1NzVpOGN1RTFCS1hB?=
 =?utf-8?B?Yk42SnJSMXJxbWRIdGg5bXczSm1UQzFCTnVLYUxpNGxwZHUrVnp6UEdRYjNX?=
 =?utf-8?B?K1R3VlcwNjFLVmFnT2ZvUzI0VFhTdlkxbGdFanMwNGsvdnBoRmdNMklsT0pi?=
 =?utf-8?B?aExGcDdhSFpzZ0FLNTlXdXBFVTNWVW40bkpreU9ZMnZUMXZKRjUvWjVhd0Y4?=
 =?utf-8?B?UlUyR1oyTENteXcvdlFYeDRibGRmTEhFall6OURyaG5OeUI4VHZ0OUhmc0Nq?=
 =?utf-8?B?bHpkVDVHZ2M3VUlJd2ZudEs5Q29zbXA4ekdsbUhSRzZBMDBzOHFwcThiZXNw?=
 =?utf-8?B?ZFJYV0hJTHFLYW9xOUJiT1JGYnplVTlVQUNMT2VyTXZvWldkK2FoWUpQMTJp?=
 =?utf-8?B?K3JiRFRaWkxrQXNYQU9ZOUZRQWZ6TnRRZlR2THpyZUM5dTIzbVJEVHJFa2t2?=
 =?utf-8?B?OEloOXRBblF5R2JtNlVac0hMdXFQYmZrckJ0TEZ6bFRTNG9hYTU0TDN1NXVn?=
 =?utf-8?B?L05uQ1RSUmVSS3JYVmZySzBYODF2TWh1cDlvTWs5ejVrcDNhaHdvWEFVek51?=
 =?utf-8?B?WXJTampCaUdZNm1lTllmRFJ6TFZYbXo2UGprdm9VWGx2UmI4UlBXbm5Ib015?=
 =?utf-8?B?OGd6ZnY1SzB5UnVMU3RxMGozQ0F4dnZyRnVpbEU0YW1ablhCS3lONW5jRWtB?=
 =?utf-8?B?c0k5dk03Rk8vUHhFRDhFOFZRMkI0QXZrb3IwT3RObDZ6aWkvdkZ5Undta0Ns?=
 =?utf-8?B?TVNJUUtvRElNTmdHd0xrSlBFYnkreHR1VTRHak1lNjZ6SzJIa1RQQ2FablhL?=
 =?utf-8?B?UzVOd0pSUm5ybXluT2NES3R5UURsUGJxSk44cFk1WDVlM3VGNUNscXVuRUlM?=
 =?utf-8?B?ZzZUUWtwTDRPRW8ybXpvRlBYNmQvcE9sOUU5SlFEY1VUUEpWNFVKUGxJMFRz?=
 =?utf-8?B?T3RldGNMMzcxU2M1Q2R6eG5oS0JjVDA4OUlaVVpOenhYWTlTbEx4STgwYzN0?=
 =?utf-8?B?SHV4T2toWjRkN2VBWmtZS1JmOGVlNi8rRTl1YnZySUx4dHd4RHllVGZBenh5?=
 =?utf-8?B?ZXZLNnhZc2JwVkVOQXJiV0RnWDdTaXRSY0dMSHZiV1cxNlFESEdDa2c2Mm4x?=
 =?utf-8?B?RXkwZmQ2cVZiYkxzbitzVHppcU90T1VPbU9xRGxKTGRXc2xkVER2NW5Mem9w?=
 =?utf-8?B?SVlhb1dLSDF2U2pYb1dlck83VUxBOWZhbWRpbGJnS0JDL0oyQjdGUzY3cEha?=
 =?utf-8?B?NU85RGFzcFQxYkxwZThQeElrMnI5ODZESTBIN2dHeTd6WmF4OEdKMEZLZWhP?=
 =?utf-8?B?WllXRlh2K2ZXcTV4K0lTbGdLVFY1a3lzeUNSVXBUdEdYNDBxdGRmWFVXbE9C?=
 =?utf-8?B?YkMyNVVzdlg3cmg0Z3RaUkdnM2hGZzFEUE16djJpTjA2UGV4WEdVVHU1MXhq?=
 =?utf-8?B?c3lRSnRKR1BOVHhHakpBVG91WlpYNG00R3MwMjBPcnEweFVnbDgrTjJtRy94?=
 =?utf-8?B?U1ZJNEZqV2htSjJOQ0JrZmU3bnJFbklMZW9CV0RVaW5HRHdGOXhGNGI2YlR1?=
 =?utf-8?Q?5kvPDRPizm6fl8CDozjZRcO70HmHApFzVkNZqiu?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f1e252a9-2370-4437-8d90-08d98cac0a35
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2021 11:41:18.4120
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: li5xQK8cXFRxNQFlFrlNAhbBE0A1Tb4BcRmhJino00Q2uFeGPJc33sBwZ94SFD7i6/SA5Ix+6UlJT9E8sXEWZQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4607

On 24.08.2021 12:50, Anthony PERARD wrote:
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>

Trying to synthesize a description:

> --- a/xen/Makefile
> +++ b/xen/Makefile
> @@ -382,6 +382,7 @@ _clean:
>  	$(MAKE) $(clean) test
>  	$(MAKE) $(kconfig) clean
>  	find . \( -name "*.o" -o -name ".*.d" -o -name ".*.d2" \

This was effectively redundant with ...

> +		-o -name ".*.o.tmp" -o -name "*~" -o -name "core" \
>  		-o -name "*.gcno" -o -name ".*.cmd" -o -name "lib.a" \) -exec rm -f {} \;
>  	rm -f include/asm $(TARGET) $(TARGET).gz $(TARGET).efi $(TARGET).efi.map $(TARGET)-syms $(TARGET)-syms.map *~ core
>  	rm -f asm-offsets.s arch/*/include/asm/asm-offsets.h
> diff --git a/xen/scripts/Makefile.clean b/xen/scripts/Makefile.clean
> index 027c200c0efc..b6df9e861e6e 100644
> --- a/xen/scripts/Makefile.clean
> +++ b/xen/scripts/Makefile.clean
> @@ -14,10 +14,8 @@ include Makefile
>  subdir-all := $(subdir-y) $(subdir-n) $(subdir-) \
>                $(patsubst %/,%, $(filter %/, $(obj-y) $(obj-n) $(obj-)))
>  
> -DEPS_RM = $(DEPS) $(DEPS_INCLUDE)

... this and its use below.

>  .PHONY: clean
>  clean:: $(subdir-all)
> -	rm -f *.o .*.o.tmp *~ core $(DEPS_RM)

With the command gone, I think the :: should also be converted (back) to
just : then. Then
Reviewed-by: Jan Beulich <jbeulich@suse.com>

Assuming the patch is independent of the earlier still uncommitted ones
(please confirm), I'd be happy to make the adjustment while committing
- as long as you agree, of course.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Oct 11 11:43:35 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 11:43:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.205867.361282 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZtiQ-0006cc-MO; Mon, 11 Oct 2021 11:43:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 205867.361282; Mon, 11 Oct 2021 11:43:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZtiQ-0006cV-IU; Mon, 11 Oct 2021 11:43:34 +0000
Received: by outflank-mailman (input) for mailman id 205867;
 Mon, 11 Oct 2021 11:43:33 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=pkLr=O7=citrix.com=roger.pau@srs-us1.protection.inumbo.net>)
 id 1mZtiP-0006cN-92
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 11:43:33 +0000
Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 75301d92-2a88-11ec-80d5-12813bfff9fa;
 Mon, 11 Oct 2021 11:43:32 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 75301d92-2a88-11ec-80d5-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1633952612;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=ksmLdh6X1qeS0oowY9h8h/tj4F+GPZUT5tLWBNa6yk8=;
  b=Os3IfI5zKrt2eMwhi8x5hmGUviOU7lresqoe8pXyQ9f33hQZXa0i0lmc
   KeAfiKWOKdZvwaVraUE4Dp1qzZArhRy9ZnWM5i811iuB2fk8pEC/0N/+u
   HPeeDUXzzo87tGJ1lE8fr3slGXOBC4hMgofDUk2p2DfhNfwqEzW4O+LTB
   Y=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: YA8DR4wDJqlK88M37de5vFrY2J5AWR01Qg6VxCNuieYR+7rizBd3wqGO9CXv19nTZ+RXqD4eOi
 AiYkQGbC3stkcw/xzPZklKJPNTfzHiFEjPs3pKcFpijiER/XAG3V0VZms7D4uuw4AvyETzpMEy
 0IQf37S9konCUGOLQwLJcd0JZ+BBm86IZjqRTMxtBn8DpKWSYpSZ3DKFYrLbt+AblpTnTAyys0
 t4DHqwfsZgVxb6isjOfX1THv+1OwgqfHslKqau6aFnY+c1iCMm/XLMr8+X3ryAA4KgVodCjACg
 vxdbZoQv34cwovKcP9tlrLZ+
X-SBRS: 5.1
X-MesageID: 54845201
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:jGSLGK/Cg9DVabScbzyRDrUDz3iTJUtcMsCJ2f8bNWPcYEJGY0x3n
 DQeW2vQb/fZYTD2KY8gaYyy8kgG7MXTx4BgGQA+qiE8E34SpcT7XtnIdU2Y0wF+jyHgoOCLy
 +1EN7Es+ehtFie0Si9AttENlFEkvU2ybuOU5NXsZ2YhGGeIdA970Ug6wrZg29Yx6TSEK1jlV
 e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH
 I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPhMz
 +drqr2ATz53FbPUgckwTBdzEHFhaPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us
 6ZCcXZUM07F17neLLGTE4GAguw5K8bmJsUHs2xIxjDFF/c2B5vERs0m4PcFgGds25oWRJ4yY
 eIHdGswYA79TyEXGVYXWcsOsMirqiLgJmgwRFW9+vNsvjm7IBZK+KP2LNPfd9iORMNUtkWVv
 GTL+yL+GB5yHN6CzTuI9Fq8i+mJmjn0MKosE7m/+u9vkUek7GUZAx0LVnO2ufC8zEW5Xrp3A
 koY4CdolbIg5VOiVNDVVge95nWDu3Y0QdNQDul88wCLxar86hycQGMDS1ZpeNEg8cM7WzEu/
 luIhM/yQyxitqWPTnCQ/avSqim9UQAfIHUefyYCQU0A6sP6vYAophvVS5BoF6vdszHuMWium
 XbQ9nF43uhNy55Qv0mmwbzZqw+rlL7Wbz4z31v8QHq8wy5maqWmN5P9vDA38s18BIqeS1CAu
 l0NlM6f8P0CAPmxqcCdfAkeNOr2v6jdYVUwlXYqRsN7r238pBZPaKgJuGkmTHqFJProbtMAj
 KX7gghW+INIdEWjaat6cupd4Ox7kPC+S7wJuh3SB+eig6SdlifbrEmChmbKhggBdXTAd4llZ
 P93lu72XB4n5VxPlmbeegvk+eZDKtoC7W3SX4vn6B+szKCTYnWYIZ9cbgDVPrFhs/rd/FuOm
 zq6Cyds404FOAEZSnOGmbP/0HhQdSRrbXwIg50/mhG/zvpORzh6Vq65LUIJcI15haVF/tokD
 VnmMnK0PGHX3CWdQS3TMygLQOq2Af5X8CJqVQRxbA3A8yVyPu6SAFI3KsJfkU8Pr7c4k5aZj
 pAtJq29Pxi4Ym2foWpCNsOh8NUKmdbCrVvmAhdJqQMXJvZIbwfI5sXlbk3o8iwPBTCwrswwv
 /ur0QazfHbJb1gK4B/+ZK39wlWvk2Iane4uDULELsMKIBfn8ZRwKjy3hfgyepleJRLGzzqc9
 gCXHRZH+rWd/95rqIHE1fKesoOkM+piBU4GTWPV2qm7aHvB9W25zI4eDOvRJWLBVHn58bmJb
 PlOy62uK+UOmVtH6tIuE7tiwa8kycHoortWklZtEHnRNgz5AbJ8OHiWm8JIs/QVlLNevAK3X
 GOJ+8VbZurVaJ+0TgZJKVN8POqZ1PwSlj3D1tgPIR33tH1t4b6KcUROJB3Q2iZTG6R4bdE+y
 uA7tc9ItwHm0kg2MsyLhzx//niXKiBSSL0us5wXDdO5igcvzV0eM5XQBjWvvcOKYtRIdEIrP
 iWVlOzJgLEFnhjOdH86FH7s2+tBhMtR5EAWnQFaf1nZyMDYgvIX3QFK9WVlRwtY+RxLzuZvN
 zU5LEZyP6iPo29licUrs7pAwO2d6Ml1InDM9mY=
IronPort-HdrOrdr: A9a23:+YxRFqBmvcgzlCDlHeg2sceALOsnbusQ8zAXPh9KJiC9I/b1qy
 nxppkmPH/P6Qr4WBkb6Le90Y27MAnhHPlOkPQs1NaZLXLbUQ6TQr2KgrGSoQEIdxeOk9K1kJ
 0QD5SWa+eAfGSS7/yKmTVQeuxIqLLskNHK9JfjJjVWPHlXgslbnnlE422gYytLrWd9dP4E/M
 323Ls5m9PsQwVcUu2LQl0+G8TTrdzCk5zrJTYAGh4c8QGLyRel8qTzHRS01goXF2on+8ZvzU
 H11yjCoomzufCyzRHRk0fV8pRtgdPkjv9OHtaFhMQ5IijlziyoeINicbufuy1dmpDj1H8a1P
 335zswNcV67H3cOkmzvBvWwgHllA0j7nfzoGXoyEfLkIjcfnYXGsBBjYVWfl/y8Ew7puxx16
 pNwiawq4dXJQmoplW92/H4EzVR0makq3srluAey1ZFV5EFVbNXpYsDuGtIDZY7Gj7g4oxPKp
 ghMCjl3ocUTbqmVQGagoE2q+bcG0jbXy32DXTqg/blkwS/xxtCvg8lLM92pAZ3yHtycegC2w
 3+CNUbqFh5dL5gUUtMPpZzfSKJMB25ffvtChPbHb21LtBNB5ryw6SHlIndotvaPqA18A==
X-IronPort-AV: E=Sophos;i="5.85,364,1624334400"; 
   d="scan'208";a="54845201"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=nDxBnxzTe1opMOfzUHJcKIAP3yhpbnZstyCMBKYlEAQCcKzLe08MmN6m/rw+b4DklfSfim8M4SjI7sB4HNjS6DvipL6OKVmWNSUWv32ecOB0aoYRfGS6JGDS3lI/lfW0LZfHyenxA/+u//9MLUYveL9YLod0Im8cGA7JTMyrJ1ui4z3wLuzfbREtJxqTh+qs3h7ipx1kvFkovgrefttgE7RtujeemAI7SqRmRimreAHIGSKV7ZHPWgDmHiHhY4QWti+Wn7grL3mYm0LotlNNCEsQMD3rCVNlPR/TAtODQo+FdOibwU+UfQu2dJnK2rSKT4c+tvNRYGClQhH0J8TZqw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=QiXvTFGTVaqb92zcizGZa4jU/TpikAjbs09bimXZZ6A=;
 b=UXjUhf3IJEO2CjyILq2Nbjr27EaAzcv5n6aRQdegt+bD+P62aTBmRH8EE/386ia+VL7RLYjQHj8H4MqcpDMcnC/mr2220lpkYnqV9fNSrIwCRShs2q5uFq5ifF/4gy6cThutxCT5zpL9ICSXg11tIbsyC1N1ZnZuq2exS/cDIa5fCcZa5iVT/PReDcsX+yWF3o3t6hDJswwdDFEVnx4iws0/OXdsIBF2906PQjZEarXeLpuliTBmytmFTpqtxG0lYpwTLuRBzQ2CEhFNb6JWVKpliHuy2aT1EsB9DNmq3q5i/N1LOMfh+odQdk/dFXAx5jxCOJeeKUxvJ9ZIgLbCyA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=QiXvTFGTVaqb92zcizGZa4jU/TpikAjbs09bimXZZ6A=;
 b=PReqeiAtfHOTB+v3Q6l7Ct8RKciu8tvIf8sRSEUz0AfFLBBixn/G8KBPVNwbmUqiT3ppTagSpA5N3j4LrDFlbr9a1AI0zACCwgxlIIN///STUQ6MckXYmGTNLstrrNioonMzu4QzByJpP2ocvW3CCvVtA2bNfq+Cz0o3qvvUaps=
Date: Mon, 11 Oct 2021 13:43:08 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Rahul Singh <rahul.singh@arm.com>
CC: <xen-devel@lists.xenproject.org>, <bertrand.marquis@arm.com>,
	<Andre.Przywara@arm.com>, Stefano Stabellini <sstabellini@kernel.org>, Julien
 Grall <julien@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH v5 09/11] xen/arm: Transitional change to build HAS_VPCI
 on ARM.
Message-ID: <YWQjTOypE96IqWmA@MacBook-Air-de-Roger.local>
References: <cover.1633540842.git.rahul.singh@arm.com>
 <b9653c6247060574cf68e1f780ef1db3dd0c20d3.1633540842.git.rahul.singh@arm.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <b9653c6247060574cf68e1f780ef1db3dd0c20d3.1633540842.git.rahul.singh@arm.com>
X-ClientProxiedBy: LO2P265CA0207.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:9e::27) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 44813c56-706a-45d0-e045-08d98cac4f42
X-MS-TrafficTypeDiagnostic: DM6PR03MB3484:
X-Microsoft-Antispam-PRVS: <DM6PR03MB34846BE5D4BF22281C6A285F8FB59@DM6PR03MB3484.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: GFwjTOYE6mIOWbhTkw5DdAWG4h4DAn3FDOdEfAI9/RqPozaNUh/DqJHUw3qJYt4OesijwuphW0TmL2Nl7Tw1NUJiDEKNmWaxXNyH5vZI1pSJaX8c5WDEPksr611z+VIqJbE0Ei+3guZlltHPo1ew2MOjW32J3foqg6Hh3N3Rvq7qglhzqXTBDE4OsC6dgrHVMGn2tniTYy0BpCkokjH6rVc6hEZE8KDkbF+ZUFkyodnUnp3XYFerOnpKui4Pjad1C3vzMEgMJqU3AZjxjEeqmxtxRpq6Z1AMKNj4x7HGv9MK5n6+JVv2cg9LjXM/DWNbJMe8I5eLlMcG/T3JSDKb8SGyRkmz0T6k/7QY0YCR9KTHqzH7b473lGVswYbBA/PKjVgY15QfSMjjpG5/KW2Y6yztQHMczYPiq6v8AqDBjp0SHcUYtnNy5NDWV5NW6kVhgISwJP73zuMb9EJ7n9owro6NnOhNk2pO6XiTf8IkvwFr8D/YmHAyJWh+4w958cyDylC2vKDHI87oeDHVaoTtnSs6kp0MqravGIbeE4AbAXEvFkkvzFJw+zMFv39NtcGiS7UcFfAAmzU8Byw2pSKyuZKB/tA//wp5Yh8LwF6BQvbAxP+fD2Pe1zGlsb6NWelpd2Gma2qOf3SVx2xuultEnQ==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(5660300002)(86362001)(956004)(6666004)(6486002)(6916009)(2906002)(6496006)(66476007)(66556008)(9686003)(8676002)(66946007)(38100700002)(4326008)(83380400001)(186003)(54906003)(508600001)(26005)(85182001)(8936002)(316002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dTRUUHZJOVRySXNKOHRQT2tWRzk4Y1F3RXFHdG45MmlRT2tYdDVFbW83Slgx?=
 =?utf-8?B?Y3I0NjBNTnlSc3FPSUpJblB1UDNaeXhTcFdjSnlPbkpXTFRnSGFyc0FGOWxy?=
 =?utf-8?B?YzN1RHFCK2lUaTZ5ZzlaWm1EdGxCRzUxM0Mva3pJTnRBRTc4dEpLNkR1aUNB?=
 =?utf-8?B?cUpZWDNUbmZJencvREpVM3dqdDVIRmF5TTJlbzFmSWZ6aG5mVHpzb3dFbkJ4?=
 =?utf-8?B?bnp3bk1GVVYwMW1KR3pmZm9QMGJMa0ZCc2FmTjl6WStOWHd0VFhOaEhKT0xI?=
 =?utf-8?B?Q2VhbTRrTkdQNXNOb2tpVkw2NnN3N3l0WXI2REhSanl3OGZEUWREWkl6dVp0?=
 =?utf-8?B?dUZCWENmOTgrYXN4M05uN2Fmc2JOK2lxdGxHRjJKSFFsUnQ0b0JzS0d1Vytp?=
 =?utf-8?B?QjMxZmt0Q1Y1K21na0dlWVVrT2xrV25TZllYcWtCQmpyaElrZ3pvM1ZKNDRs?=
 =?utf-8?B?eHQ3dHY4cGMwR1o5VE5VbENLQnBqU3g5VE5qTDhnckhWUHNHbzlxUEtyN0xC?=
 =?utf-8?B?a1Z1R1BmbjBFR0QrY0NGbSt6Tm9RUm5sbzNjeVcxbE0rYVQrM0RZWVNLNFhx?=
 =?utf-8?B?OHpIZ29mMUdGa2h6MVI3UE9oTlAyUUpjZWVBT2pzM3ZMMDR3eUFpQW5aUkQr?=
 =?utf-8?B?UWI0SFdXNGVMMzVFOGY1WThnVCtTY0pTVUF2QTlIc0RQcnZhUUk0VHBJUnhp?=
 =?utf-8?B?dFNGU2ZhUG1tSDVZSktpUEgyNTRkc2tuTjJDMUxoeXRnR0MvbTBEUEdlNDgx?=
 =?utf-8?B?UFRvVXI2U1JFKzdVM09rbFJmZy93allGSFRmaWpHTnk5OGtZMTRaVUpWL1Vo?=
 =?utf-8?B?VXd0cDhXdUJhSmhEL1VsTGN1Nm5rQVVEWXlmWFN2MEtVYXIxckVxQ1VDWmk5?=
 =?utf-8?B?YkxRYnNZM2ErZGl6TUVScmszWkVPeWNwR1hhK0MwWGtTdHdTNGdYbWd2eExk?=
 =?utf-8?B?UXR2a1Y1eDdxdFc2dmFNTCtTOU1hWWkrZUpiUndhMGtKeVlpQUtSOGVidnMr?=
 =?utf-8?B?dUFRT3ljaWVZZyt6YjhhaktZbEVIRE4xL2ZKWVZ3K0lSa3hjdnFpQkV1UzBV?=
 =?utf-8?B?WWsyNUdFU002MUtkRUQ1NlFRNGVGMjliMjRQZ2pzdjdYazhGMkF6aWJ2VTNx?=
 =?utf-8?B?L0NHM1daRzFTS2k5UE1lU3FCb3Buc2pCR3pFeFlEZUxHOTlDR2xKQit5dU1O?=
 =?utf-8?B?OTMwTEdCazFtT0tZMzRnQUhTL2QwZ1duSEVzdjJHWHRlcWx6cDZpaWp1bjBx?=
 =?utf-8?B?eENlM09xNUIwTWhVdU5YbENwM2pUSXprcGQxSk5nV2xOUlE3S2I2Qjg4aWNw?=
 =?utf-8?B?TFA0bEMzSmJDUEFVS2pGZXc4ZHRNQXFEMEh3Zy9FOXVRK0h6L0xPNG0yTUZu?=
 =?utf-8?B?b2U3bURUV1ZJQ3U1TEU2REdEZ0xENzVOU0xjQTE4SlA4cmNUMmdwd0xqblZh?=
 =?utf-8?B?eU9icGsvbnlESFFPcloyTE9BQ3VJeDZsOVorYzZJaVp0TWk0dGNLbHZ2K3ZW?=
 =?utf-8?B?aHRHakFpMlZURldlVkdWY0VMalhrMFJTVSsyNWFNTi9QU2RmZjZzZ1ovVWor?=
 =?utf-8?B?b0VRbVBybFNqSDNCYmdkaWFUTmM2K2tGNVhMMmlJNDJKMkRxOTc3QUJMUGNX?=
 =?utf-8?B?VlQ3ZVFLb0pBMWZFOFBTNUFrL1FsME1iUUQ5R0tWSE81Vm4wd0t4MDN4Y1JB?=
 =?utf-8?B?OHRnMHl3RDdNTzlYNSs4ZTlDNHordGJCZW4xTEg0bFJNaGRQU0lMcGkwZ05U?=
 =?utf-8?Q?twclk3DDjnODP0O9E4uX//jO6RqITsIliU28asf?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 44813c56-706a-45d0-e045-08d98cac4f42
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2021 11:43:14.3872
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: LWO8/b661WYvyYgsMFzaK/k5z18ne/8omsdwlbWdij/vRsUMdNw4rPH13kwnPNmnCNGg55QY3LUeU+NJM9FovQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB3484
X-OriginatorOrg: citrix.com

On Wed, Oct 06, 2021 at 06:40:35PM +0100, Rahul Singh wrote:
> This patch will be reverted once we add support for VPCI MSI/MSIX
> support on ARM.
> 
> Signed-off-by: Rahul Singh <rahul.singh@arm.com>
> Acked-by: Stefano Stabellini <sstabellini@kernel.org>
> Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>

Reviewed-by: Roger Pau Monné <rogewr.pau@citrix.com>

> ---
> Change in v5: none
> Change in v4:
> - Added Acked-by: Stefano Stabellini <sstabellini@kernel.org>
> - Added Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>
> Change in v3: none
> Change in v2: Patch introduced in v2
> ---
> ---
>  xen/drivers/vpci/Makefile | 3 ++-
>  xen/drivers/vpci/header.c | 2 ++
>  xen/include/asm-arm/pci.h | 8 ++++++++
>  3 files changed, 12 insertions(+), 1 deletion(-)
> 
> diff --git a/xen/drivers/vpci/Makefile b/xen/drivers/vpci/Makefile
> index 55d1bdfda0..1a1413b93e 100644
> --- a/xen/drivers/vpci/Makefile
> +++ b/xen/drivers/vpci/Makefile
> @@ -1 +1,2 @@
> -obj-y += vpci.o header.o msi.o msix.o
> +obj-y += vpci.o header.o
> +obj-$(CONFIG_HAS_PCI_MSI) += msi.o msix.o
> diff --git a/xen/drivers/vpci/header.c b/xen/drivers/vpci/header.c
> index ba9a036202..f8cd55e7c0 100644
> --- a/xen/drivers/vpci/header.c
> +++ b/xen/drivers/vpci/header.c
> @@ -96,8 +96,10 @@ static void modify_decoding(const struct pci_dev *pdev, uint16_t cmd,
>       * FIXME: punching holes after the p2m has been set up might be racy for
>       * DomU usage, needs to be revisited.
>       */
> +#ifdef CONFIG_HAS_PCI_MSI
>      if ( map && !rom_only && vpci_make_msix_hole(pdev) )
>          return;
> +#endif

FWIW, I would also be fine with providing a dummy inline function for
vpci_make_msix_hole when !CONFIG_HAS_PCI_MSI, but I assume this is a
temporary workaround until MSI is implemented for Arm.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Mon Oct 11 11:49:06 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 11:49:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.205876.361293 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZtng-0007Kn-9Q; Mon, 11 Oct 2021 11:49:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 205876.361293; Mon, 11 Oct 2021 11:49:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZtng-0007Kg-60; Mon, 11 Oct 2021 11:49:00 +0000
Received: by outflank-mailman (input) for mailman id 205876;
 Mon, 11 Oct 2021 11:48:58 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=pkLr=O7=citrix.com=roger.pau@srs-us1.protection.inumbo.net>)
 id 1mZtne-0007Ka-B6
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 11:48:58 +0000
Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 374fc03a-2a89-11ec-80d5-12813bfff9fa;
 Mon, 11 Oct 2021 11:48:57 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 374fc03a-2a89-11ec-80d5-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1633952937;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=UYeXidO8EF3rwVKC6m/mFqwzrz+ih/rfaq+LM8+JMtw=;
  b=UqPPk/k0b3TioHXvM0rrGVHNsOs+9IyH0wJqAiJmBn1gQm/LnRou5KdE
   3UQESFL58pQy9HJ4ky2gc+YztTMWeBAFOaFA3A+JckwbWWbJZUQP1jLl2
   7id0g6JxWZNIlpS4QEEhMa239skyJZfHH8D3dA5lbmJpNidcTbSVovXu1
   o=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: VHYKe+Js+BIl8+slH2mtqph754nPm1QhAtYLoQ0WS+BdAd3OuWAJcyFtqlVyfUrrGg3vgXeTlC
 Nake5yqAqbzDoInDy+AfOVkuorbNrn+nX7IfmxOxEg4oyjqRpTjasWK8svQ6X5TMVtobKj1QNR
 6BWnoZ5CcBShAAtlu9iyBAHcAM5RXsjZ/tmo3AC4K7dx83xUjh/7CnRRCs2Jo7zYzEdC9ZYuVL
 sL8ZDnSIpPjeIQncDIBO9V/dI4Q/RpoH3wySBzfToAE7ZhgpWR9nKoQodnJtLG/FNPssqLnx8r
 A/YhPOw2ifZORxQtlsiqnRmj
X-SBRS: 5.1
X-MesageID: 56737280
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:E3c1R6h8nRB4p+A6kfD2vSxAX161NRYKZh0ujC45NGQN5FlHY01je
 htvCD3TM6mNMWPxft5xaoW19kMGusSGydEwTANrpSoyQ34b9cadCdqndUqhZCn6wu8v7a5EA
 2fyTvGacajYm1eF/k/F3oAMKRCQ7InQLlbGILes1htZGEk0FU/NtTo5w7Rg29Yx2IDga++wk
 YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq
 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx
 /1/hN/zd1slBJTGu/ovdDMGHyRfZ/VJreqvzXiX6aR/zmXDenrohf5vEFs3LcsT/eMf7WNmr
 KJCbmpXN1ba2rzwkOnTpupE36zPKOHxO4wSoDd4xCzxBvc6W5HTBa7N4Le02R9t2J8VQqyOP
 6L1bxJyThbKcU19fWtJVpkQud+sg2fHfjtH/Qf9Sa0fvDGIkV0ZPKLWGMXRUsyHQ4NShEnwj
 mPZ/UzpDxcCLtudxDGZtHW2iYfnhjjnUYgfELm58P9Cg1CJwGEXThoMWjOTo/ajjVWlc8lCM
 EFS8S0rxYAi+UruQtTjUhmQpH+fogVaS9dWC/c96gyG1uzT+QnxLnINTiNFLscnssA2bTUw0
 xmCmNaBLRVpvKeYD0qH5KaLpCm7ESEPKCkJYipsZQEI+cX5qYc/yBfGVM9+EbWdh8fwXzr3x
 li3QDMW3utJy5RRjuPioA6B02nESoX1ohAd1DSUHVz54jlAbq27VauCt1TezKwYI9PMJrWeh
 0Qsl8+b5eEIKJiCki2RXekAdI2UC+a53C702gE3QcFwn9i50zv6J9oIuWAhTKt8Gp9cIWeBX
 aPFhe9GCHa/1lORZqhrf5n5Nc0uyaXxfTgOfqGJNoQQCnSdmQnuwc2PWaJy9zy9+KTPuftmU
 Xt+TSpKJSxHYUiA5GDnL9rxKZdxmkgDKZr7HPgXNSiP37uEf2KyQrwYKlaIZe1RxPra+16Fo
 o4AbpLWlU43vAjCjs//qtR7wbcidylTOHwLg5YPKr7rzvROSQnN9MM9MZt+Itc4zsy5Z8/D/
 22nW18w9bYMrSavFOl+UVg6MOmHdc8m9RoTZHVwVX71iylLSdv+t883KspoFYTLAcQ+lJaYu
 dFeIJ7eahmOIxyakwkggW7V9dQ4Kkvw317SZkJIolEXJvZdeuAAwfe9FiPH/ygSFCun88w4p
 ryrzATARpQfAQ9lCa7rhDiHlgrZUaE1lL0gUk3WDMNUfUmwooFmJzao1q08It0WKAWFzTyfj
 l7EDRAdrOjLgok07NiW2vzU89b3S7NzThhAAm3WzbeqLi2GrGCt9pBNDbSTdjfHWWKqpKj7P
 bdJz+vxOeEslUpRt9YuCK5iyK8zvoO9p7JTwgl+Mm/MalCnVuFpLnWchJEdvaxR3L5J/wCxX
 xvXqNVdPLyIPuLjEUIQe1V5PrjSi6lMl2CLv/ovIUj86Ctmx5a9UB1fb0uWlShQDLppK4d5k
 +0vj9Ebtl6kgR0wP9fY0i0NrzaQLmYNWrkMv40BBNO5kRIiz1xPbMCOCiLy553TOdxAPlNzf
 22RjavGwb9d2lDDYzw4En2UhbhRgpEHuRZryl4eJgvWxoqZ16FvhBABoy4qSgl1zwlc17MhM
 2dmAER5OKGS8mo6n8NERW2tR1lMCRDxFpYdELfVeLk1l3WVa1E=
IronPort-HdrOrdr: A9a23:D+xhe6hZTzi2kTLIZOr5Gk2TVHBQXzx13DAbv31ZSRFFG/FwyP
 rBoB1L73DJYWgqNE3I+erhBEGBKUmsk6KdxbNhQItKPTOWwldASbsC0WKM+UyEJ8STzJ846U
 4kSdkDNDSSNykKsS+Z2njBLz9I+rDum8rE9ISurQYccegpUdAa0+4QMHfkLqQcfng+OXNWLu
 v62iIRzADQBkj/I/7LTEUtbqzmnZnmhZjmaRkJC1oO7xSPtyqh7PrfHwKD1hkTfjtTyfN6mF
 K13zDR1+GGibWW2xXc32jc49B/n8bg8MJKAIiphtIOIjvhpw60bMBKWqGEvhoyvOazgWxa3e
 XkklMFBYBe+nnRdma6rV/E3BTh6i8n7zvYxVqRkRLY0IXEbQN/L/AEqZNScxPf5UZllsp7yr
 h302WQsIcSJQ/cnQzmjuK4Fi1Cpw6Rmz4PgOQTh3tQXc81c7lKt7ES+0tTDdMpAD/60oY6C+
 NjZfusqsq+SWnqLEwxg1MfguBFBh8Ib1K7qwk5y4OoOgFt7TBEJxBy/r1aop8CnKhNPaWsqd
 60dZiAr4s+PPP+W5gNc9vpcfHHeVAlfii8RV56AW6XXJ3vaEi94KIe3t0OlZWXkdozvd0PpK
 g=
X-IronPort-AV: E=Sophos;i="5.85,364,1624334400"; 
   d="scan'208";a="56737280"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Sxi+HveZMYOCT9jVpfGK8nYudFF/judnmLVYoL3o8l09CtdTmhTsapU/vUlOlpHkkH1wChndVSgAaGfdWr/06WiL2dcgZh9SWaM5SyhhymJBDKT1mfyksLKbc8tDi/loCxPIEbRxROL9MXX/PGgr9SYOYQMDG+F6v80vOh6lSIHfxYHWiwfUEuJDGTPT+YhSJqAmntI+M1DFV70jwWkEeSxSUe1ijJQYJGtIhchK4dB1t5kYvEgzKyLlzLNkPoSSuOKHiN8JMWVzdM/g+/q0ihnAzibyu3NLzTMCURwIKcgxSFO0XARdDwMK+v9V8kFPU9Lv2XzTvMzn+uLYqGUTMw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=UYeXidO8EF3rwVKC6m/mFqwzrz+ih/rfaq+LM8+JMtw=;
 b=Qv+uxFVH50PlT8iYsqpFXaTVRRW5N1fBPCfqfdfhUOpO69WWeZC5GpBlq6678uZNXPQ+0hQQBT3RDwdcif3cfYRc1YW623U9HTg1ju+kCCUzgExpUXKAyhmpPxwOYZ9jqmvvvulToyhWa55KE6wqy4X0vd5k3N63Ury9N5xpC39N1ZVVd9P+12yM9ly2r4dh+ykMKBRenRl0UraTktMAGgz1xpDhiNicQnJV+wF1xIYb8ufZbDFe2gsAp4g7+pbCNzrwaexgVguZyfS3SAG5nQXRUAE17s+2x4mgHDDf/Jt5H8c6LVmtpwUjeKFt/lZctb4kgwcpbsqO0JXI6GZVEA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=UYeXidO8EF3rwVKC6m/mFqwzrz+ih/rfaq+LM8+JMtw=;
 b=JyUWrj7t/RL53mV9u8nneaaup49hjzlqa9DfUswWI0oqdZQ4YMeMzNLPka6+JJqjYiWLauNdXw4ynwkCvs1sx1vN7g8MSEMXsnxarb82EKISk/e8swQuTHUEhzEu7sX+Lea/s6iKNpSxfuK1X0xgemOwBLdhZJd2WvmZGqLYoBM=
Date: Mon, 11 Oct 2021 13:47:58 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Rahul Singh <rahul.singh@arm.com>
CC: <xen-devel@lists.xenproject.org>, <bertrand.marquis@arm.com>,
	<Andre.Przywara@arm.com>, Ian Jackson <iwj@xenproject.org>, Wei Liu
	<wl@xen.org>, Juergen Gross <jgross@suse.com>, Stefano Stabellini
	<sstabellini@kernel.org>
Subject: Re: [PATCH v5 01/11] xen/arm: xc_domain_ioport_permission(..) not
 supported on ARM.
Message-ID: <YWQkblfNMYEs6jI9@MacBook-Air-de-Roger.local>
References: <cover.1633540842.git.rahul.singh@arm.com>
 <d292392268df2c74c4103a82ef917072643407a8.1633540842.git.rahul.singh@arm.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <d292392268df2c74c4103a82ef917072643407a8.1633540842.git.rahul.singh@arm.com>
X-ClientProxiedBy: LO4P123CA0298.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:196::15) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 9e50ad71-2e92-4bd9-79c4-08d98cacfb31
X-MS-TrafficTypeDiagnostic: DM5PR03MB3146:
X-Microsoft-Antispam-PRVS: <DM5PR03MB31463BCE90D9AB39E70483418FB59@DM5PR03MB3146.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: vN4skJ4oKmJ0bx+P6Pua6cOSR4C0nmWcuzdjLrvq3uVGsTKfVYBejX3VHOx2OfRPfrirfW44UC38EMi/+0H4hTe2C2ru/G/07nvpt8byH3Gc307wyIFVh8gP6twzQI782dpFc0JQERHPGnOQ8l0djyEDRGHWb9i7izcKWoruh9WFbAGZo3LRAPgDp/Im+oQCQbacKrok9hPdbUZlgPoKJsiqLIP0yk8MFKXtwEBLB70j9nC3O5e4++Stq3wp/LNQKzV3vsn0h5E2aqMyC7jFrOdtDJUmw6rfizBZszULLnbBaKdmhP1jjnrm8zu/plPX244fHDdxYrxw+Cz86MbmFe/TYqoQse5HtLLvopHo9uLVfnOhGyR4im/wEAUJZGIgyhu1qyyYAJRtX9pPmIv5qG8PUafa9QgY2K0AUsxcFP+5MFI6XCBxJVAqe20Qj2hyh7ilCfoj5T/+t4aeS4y2r6MdNKIs2Y7NzOtLZ85Jl6+vX6b0XzFjFJ1fn0aBwEPoi5outg5znqOImPGFe1Y8JQlEXaZ08ne5umAWl/wTKrRDDS+vppfF9+Q5Y3j2sQqmHNS7FyD1QqDQiLE2hj0Zfvy1YOZGUxj1P9XsiuXQODGmyFQ6JVXVS2MT/BxqnSEdULTGlCLKUkx73RLfWMJSOw==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(316002)(66556008)(66476007)(4326008)(6666004)(54906003)(6486002)(6916009)(5660300002)(4744005)(9686003)(956004)(8936002)(86362001)(6496006)(186003)(2906002)(508600001)(38100700002)(26005)(85182001)(8676002)(66946007);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TU5mUXQ3K0M3Vi9sUTZWNjFTbysrQUNpN2RzV1BJYk1jWXpPNkVBVnVGWGly?=
 =?utf-8?B?MWZ5Z1BUb2FjM1JxdFZlU2h4UldHMGtOVUxTNUNKazAvUytTSkhPbDNiTzZy?=
 =?utf-8?B?QnNGSjBaWmplZ2h4WGpCenhEckp3ZDg2cHNhT0pVWmtNWTdJQXUzUWpTcnQr?=
 =?utf-8?B?S3VnNlJ6QUorVUFQdURSUGJMM0djZUw1RnVSak9jdFNtRlQybXhWWVBVeGlC?=
 =?utf-8?B?cmlZQ2JkMWxzV2dnbUZpNVk0elJ6WnRZQWhTVjVHL0FnUy9wUCszZDZ1TTd6?=
 =?utf-8?B?RnlwTDdtUVdOdG9EWm94bzF5L2lPWHFVUnpqWHhMN1NMQ0hWM0xORHRJWkIv?=
 =?utf-8?B?L2F1c3FCSm5VVHJ4YjNTb0QrZ1Fkb0ZYMTdMUWQvbC8yVkFMbXNqNkZVNDM3?=
 =?utf-8?B?MmR2SUpQQUQyWTlCU2RMSWZLQ1lpUldBdlJjN3ovSklPcnlBbGlpVVVmSTF2?=
 =?utf-8?B?NnE0OWhwZU5sL0FtTHZQSUtzVHVZS0ZYRWVUM0tWS1hYYzZuTUl2ZklXdGQ4?=
 =?utf-8?B?VGF3K0VnZmIwSGdtcU9VdEJIQTRDNlJsTTVpKzN3aVRKVnVsUlZZQzhyRnIv?=
 =?utf-8?B?dXdrZkJsQkdzQnRVUUV2UTFyVWlqalJ0LzU4cVhVMlRpM0hNUSsreEU4VXpN?=
 =?utf-8?B?QlRaTkdKQmQ4QUZmbzZ3aUlRMURBeEhLNnVhMFJBWEdCa3NWaDc3VXJyaDB6?=
 =?utf-8?B?b1M4R0FRNVBLNjAvUjM1YUhVVUlsdGhLMVB5L1JOV1d3WFIzT1ZnbmJnVmU0?=
 =?utf-8?B?dXFsNzFXcXBhWW9LSGN5TTRoSlJEdHQyZFJjWFYxOEV5QjBWOTJxcTlkbnM0?=
 =?utf-8?B?NWtKeGorVHd1Vlk1UVNnblhHWHJxbW9kcGFyUVlJRlFxREtTL01GY1A1Qnds?=
 =?utf-8?B?SHZ2bGhHZ3p2OHlTU3BxRzZEWHowT1VOYnlRKys1UmFzMkRSNUQxbW9uNHcy?=
 =?utf-8?B?NTgzVG96ZUtMZFVpeFU1QzJ0UGQxWGFQMXVIRTBmRXNWa2lDMXU2bnI4RWpY?=
 =?utf-8?B?MzVLVk0zUVZaUzhrN0JjQ3BlV2piQno0MEtnbjB3U1pEaXZEV1FXd2x2WGtC?=
 =?utf-8?B?NktuWjkyNUJQSEQxOG5OdkNQbC9ISnA2a3A2cC81d0pOS1RkRElZZ3M3WkxM?=
 =?utf-8?B?U1JSdUdYM0duWENKSHp1YUFRN05OdGZKcTE5ZnpaYTJFREw1cVZoYkE3YlN6?=
 =?utf-8?B?TGozekJLeElhY0MvSEMzaHlsM1JYL3hZQmo1VHdTYVhVSkhZaFFLWWdxd0Qr?=
 =?utf-8?B?b3ZRa1B4WU9MVFIwNzVTMmhKUFliRjg1L2k1ZFM5VW4yZm5DTnRkazY0NEdO?=
 =?utf-8?B?cnhDMm9BUE1TMGw5YjFrSVdsZDhScURuMWI5Y1NmN1Z2SFBPYStiN2hFNkNC?=
 =?utf-8?B?S1FFOEIwekRHd2xSbVJEQVg0QTFIc3RIZmRxVk53cE42UHJUd0xpc0NLUlJB?=
 =?utf-8?B?eGNWU1pqdU9LQVlqNzRQajlNb1BpVjl0aXpBTjV0YWU0WHArU2d2d080UkhO?=
 =?utf-8?B?SmtDc2FlMU1lUWZDVS8xN3B0NndnRXVHb1BUNWYwUkFKbTFHU3hlTkRBQzFG?=
 =?utf-8?B?b2JCVEwyV29QZVlOckNXeGNNTTZhdXNORGtCRDhwR1Jzd3FnMlIvdzlrNFJO?=
 =?utf-8?B?dVRCWUgrVXlDOXhBTkdTRlF6YkN2bjJTdDNRWS9Ub25CQWh5YUEwTEh5RGYx?=
 =?utf-8?B?NUJ1bXdIRkttZVhQQk1mWFFJNXFuOU9FLzY4TVcrVHhjWGJDM01GR3Uzb1Bp?=
 =?utf-8?Q?Vi7xQbEg5GgXXM0aK8i7mDk1vGyoXesfCibHJua?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 9e50ad71-2e92-4bd9-79c4-08d98cacfb31
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2021 11:48:02.7139
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: xAM9nJyV7vLK8OCwcNP+eX4Rri51GCZgJLAmd1a7AgLHsz6wvCn2p37lTIShBhPYXGXHm5hlrwu41O82HhudkA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB3146
X-OriginatorOrg: citrix.com

On Wed, Oct 06, 2021 at 06:40:27PM +0100, Rahul Singh wrote:
> ARM architecture does not implement I/O ports. Ignore this call on ARM
> to avoid the overhead of making a hypercall just for Xen to return
> -ENOSYS.

What is the cal trace of this function actually on Arm?

AFAICT libxl will only call xc_domain_ioport_permission if there are
IO ports explicitly defined in the guest configuration, or if any of
the BARs of the PCI device is in the IO space, which is not possible
on Arm.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Mon Oct 11 11:49:29 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 11:49:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.205881.361304 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZto9-0007tn-MN; Mon, 11 Oct 2021 11:49:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 205881.361304; Mon, 11 Oct 2021 11:49:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZto9-0007tg-JC; Mon, 11 Oct 2021 11:49:29 +0000
Received: by outflank-mailman (input) for mailman id 205881;
 Mon, 11 Oct 2021 11:49:28 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=9TNE=O7=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mZto8-0007ql-Dw
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 11:49:28 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id c030cf38-7d89-4ce6-aa40-0b4007b27dfd;
 Mon, 11 Oct 2021 11:49:27 +0000 (UTC)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2051.outbound.protection.outlook.com [104.47.13.51]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-32-XfAc0SvnMhutDOWwpPUhWg-1; Mon, 11 Oct 2021 13:49:25 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0402MB3392.eurprd04.prod.outlook.com (2603:10a6:803:7::26)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.25; Mon, 11 Oct
 2021 11:49:23 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4587.026; Mon, 11 Oct 2021
 11:49:23 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM5PR1001CA0069.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:206:15::46) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18 via Frontend
 Transport; Mon, 11 Oct 2021 11:49:22 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c030cf38-7d89-4ce6-aa40-0b4007b27dfd
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1633952966;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=MUuL5kdJHijeji1xEY+oeq8hIM3yywBwiLNJhiNMlew=;
	b=ccOGVgYQFVDJ7w8GlK58EcQf5/RkMns//zVi2vUKoNHhyhJcJPhSfLKdfYoR4GXYhk6AWj
	1dhLicllQ+iWKsvS4O9ai7G05TZTpMHbFn9mgxdx5wPl4bnfOAwrlA39ifBRQ8Wu6ZXoQh
	5QKlTj74+fV9sjHHIAJKxCOgvKgWNDA=
X-MC-Unique: XfAc0SvnMhutDOWwpPUhWg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=VesjsPIWIy+805g4gzJRBB6wHLeBhMmou7fPOvQA6ZFKwWOYgUpwoyrIqwgNoP0+tNsH5B2smxfth6rbFkLAoGJ5dpELPkiV76GxttWwbANcXZT82TyhbjURypHtyTykO2SFh19ZRowShsunRH5xY6r3xKXIxlpu/39pBNwYevD8JK9OkBXCSPuTV+2Lnyyts/8at3MmyWFI5cw8JQn003CNs4feechz0lwXnuLrw0YeOSBuGqnkK8QMQupcuF2Qtu+GTDrGiHWryi/0VABtf9ABIlMdv+C5mulUWw854cnUqj8mZwW7raBGL4cgYEsks80UBqph5Ix6y1w5k3gKjw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=MUuL5kdJHijeji1xEY+oeq8hIM3yywBwiLNJhiNMlew=;
 b=Hzv0zxhohZQ/FpzTfLz7cT7aNrU72oEB/ZuWXwzMgUGAO63pwSdd8gng7ePS9aC30G2P+SKNz7dSZWT42w6LgpqcmL3RSCv3VSJhNeEz393gMVQLWDuKmGR/BgxMXkcnmSwEbwaVpmjMKi9v09SLx1w72ldcTE2GO4IVYR9SNT4z37DDJ0tFCcEZ8Xz5f15VHkv+6sMBFBpM0Q+bGNbXrlzXzwy9KaltWS+EAV9ABp3cB18eE7xlKlLwiXQzttoNz4oC8WO4EFuk3dV2tN38C08jX6XFPeJZ72s77yityVVeBuWt1LLHaJNsdyuZesXmTddzZZnOPoed1SVchJv5Fw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [XEN PATCH v7 23/51] build,include: remove arch-*/*.h public
 header listing from headers*.chk
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>, xen-devel@lists.xenproject.org
References: <20210824105038.1257926-1-anthony.perard@citrix.com>
 <20210824105038.1257926-24-anthony.perard@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <80ef158e-9502-8f97-8e3c-55717d1596dd@suse.com>
Date: Mon, 11 Oct 2021 13:49:21 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <20210824105038.1257926-24-anthony.perard@citrix.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM5PR1001CA0069.EURPRD10.PROD.OUTLOOK.COM
 (2603:10a6:206:15::46) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: fb907852-5008-46b7-de90-08d98cad2b37
X-MS-TrafficTypeDiagnostic: VI1PR0402MB3392:
X-Microsoft-Antispam-PRVS:
	<VI1PR0402MB3392CD77D9161CB2DAE47016B3B59@VI1PR0402MB3392.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	8OtOO5FM4lzRSUNLD6JwBbeKu2e7etZnNYIsJl7jB+DI0s6/R5BXGc/OOJdCczA1FoWTg8HO+zWU7TMJ8hwzWxyDEhTzTrlyCjfCMTsjhXL6Xrn3xH8NipygSwXifQy93RzKL3ugcISN3/6ZGNH3fPX7AGLXJXtAaNQpAWy4G9Q5smI+qNX+Uthfuc2zzgqs6DooghWwS+L0F0mGvv6kjDnD/wFfncXxuxXKL5jNEa2akgAOiB1rO9VF5s1OxE59BybnnqhK858WxuqgxzGEB6Ry6OQziG+RhPOBWV2UFHZjO+80Co8fSLfqEe33aSrhonp8GNqEpHEU3irxaG3SMEfuikyOFVlSPMMcmaPuBxVB7KiM0ToOW1eSVhFfut+RaX/CeWZbfTc5lsJrWocF5BF90nxWPf23BDSHVP5G2EjdOoJRiARvYlGenl9JPdsFz/yOYFReW0hcYMy8Hx4iqX53br3xAC9OIVG2BaWAUhxaTWr0t1agfvabYFnW/p2gPVsAVBqaVogWOC7QqMU3Chv5BOQ3LoOFP5g130CaLkxxndI9p8ncttq6DECU1WMftMOyhJPX+FYovKffItTlbepGYAxwf2B3rO9gqTl0g+7HFmABGOs8eXyiZ94Mi09n7r21+OuyXGNunTuXpoFO/D4scP8R3tHX3tO1fc7BT2b7c8W1q3+GRWqCMsCYXBet8gAqkKBkhlQnEaVTIjzo3UnE3UmlMAD+gEWrLwXIJzbtqwtWV+cjHb2Kf3vr5+FU
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(6916009)(956004)(26005)(6486002)(8676002)(36756003)(54906003)(2616005)(5660300002)(186003)(86362001)(8936002)(16576012)(508600001)(31696002)(38100700002)(66946007)(31686004)(53546011)(2906002)(66476007)(66556008)(316002)(4326008)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?QjlNcjk3UGFWYlRpY1dPSzR5clo5bG93bkxqRWJiRmVPK3lOMVE1dC9XNFRw?=
 =?utf-8?B?eVdCR0V2dEJna0NXZXJBbHl4UGxuV2U1U2Z6MWFBM2RtRk9FNGU2VVpZM2Er?=
 =?utf-8?B?MlZQL3ZYZ2pENzhtMjZIeEVvbHRqVGUzUjRwdnNwc2JxUHJ4c3FBdCt0QmVs?=
 =?utf-8?B?Z0JnQytOUWRURGRuN1NScUNFRzI5UTBOV2tSeGtKMjFGZjV3VXJhaHlXRGlP?=
 =?utf-8?B?M2d2N0thekZMYkRhUlZnOFFITzhjV2ljNzhYcWwwSTVNdms0bVovdFpFeEUz?=
 =?utf-8?B?bUJSWkFRWVpMeXdlUHU1K3BLK2JVbklFWmpwelZUaTVDa1kvNnpHbGZkaTJx?=
 =?utf-8?B?dDR3S0N5bXlZRWVGRmxhekNoc0pjTXEzS0Y0RzBnaWFIMzVVT0tORFhEZnlO?=
 =?utf-8?B?NzVZRmF0OGxmNXQrS3V2V0V1di9GU1dWSERsRjBNNE94UG5UOUNYWTl4alRy?=
 =?utf-8?B?K0pHN3JxU0NBVjFTcXozRC9FbHZscndnS0xYT1hjQlhQLzczNDN5ZE4wMThp?=
 =?utf-8?B?QVc4UGlWa2x3emo4Y3c3T05NVCs0VWg5b0h3SzE4SW11RC83RTJUV1h6SmVi?=
 =?utf-8?B?anlYd3VodkNsM2s2aGNVaXoyMHpSU1VJLzh2akQzSWM2Z2lRb2N3YUE1OHBl?=
 =?utf-8?B?ZllZc0IzbE9VRkkrOTNGZGRpOGxxdktnUU5Vb3RETFk4djRUblNMSVRScnpR?=
 =?utf-8?B?bmgrMmp0VGVCVzlCbkhnN044SnZESEpyWlU5V2FTSmxNMEVpeUxOSHZkSzVs?=
 =?utf-8?B?eXFWekxuTlpodWQwbXM4TkRpaUpTZUhvWHp5T1FpT3AxUWdrdzBTVHo5Q01y?=
 =?utf-8?B?a2JlWG1Od1pTaTNmbjBVd2RyV1p1K1Y3WTNOdG9aWFRmZCtDOUVxVnIzUXV2?=
 =?utf-8?B?bGJTT1h1bDhYbmdUQnpxc1JwWUZXYXErNmFQR3pIclNTMEh2RXlFT3ozcDhS?=
 =?utf-8?B?T04zbU9ORTdTM2tWN3BQWUpNREU1UFN0Q08wMm1JRkRSTnN3dEp6L0crM1Y1?=
 =?utf-8?B?dG1ndHJSUmp2blc4OVpVZmZqZ084d0RYaFR4Y3lXRU5TVytLdmkwdHRpQ3BR?=
 =?utf-8?B?cEMxdkhkU2JFcUlHSWJaR3NyWGIvY1pBUnhGc0tqeGp6RWpZM055WlVJbHFD?=
 =?utf-8?B?dzMzTnh5WVVQaDNHcHh5TU5oczFQend0eFFFSkF0TVZiOUJnYlZDUlQ5SSti?=
 =?utf-8?B?VGpuaklleDZYSWZ1b01jakpCMXBkSlFzcUNXL0t6dHVPM0d4NVE4Qit1Mlkv?=
 =?utf-8?B?UDJndmlNVUVCVFJRVHVCOVZWK2FZc2FZR2N3eWw4dStkTjMyYTFiWGFudUgw?=
 =?utf-8?B?ekJrTkJvdlBhNG1VWHJwcy92YkNmOSs2cWVQalA4SFN2MHl4TFVKeGJxaHV0?=
 =?utf-8?B?NnJ2Y04yUDV1RkhHWHNjMWpSR0diMjZWMHJvb3R6KzhrNGJ1OTZnU1VGS2cr?=
 =?utf-8?B?cnJadzlZb1dJSUhJRXBMV2pzL3oyUDZ1c1ZZYldPSklwRzdmWXpyUERlVmlo?=
 =?utf-8?B?VjkxS1ZFa1REaUxXQXhia1QwWXVFZzErb0VHL3o3OWxOSEtvN2piMm4xUHB1?=
 =?utf-8?B?T09JMWY2ZzhRcW5ZU3hpZEN2UWRoRXlZam42ZUVoQXZWY3B2QUppeEdwUjQ4?=
 =?utf-8?B?MGhuMkMyRW1uRkNwVFJLd0oxWjZIMzNJTkI5NDFMMmt4M3BSaHV4c2J3OUZJ?=
 =?utf-8?B?cTNWOXo3b3pKOVZuaWVBanlTaDJWZTB3bm5DbmhzaUU1RW1jYUhQdHkyNjNh?=
 =?utf-8?Q?VdbeBwSj2WhELDKymrB475P/Nc++tFhB+TliUGl?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fb907852-5008-46b7-de90-08d98cad2b37
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2021 11:49:23.3257
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: DOWQA0UCA55q6HESsk4V+POPm71uuGku9DK9oA/90TE9xHLHoiVxHJKXZL5/HbtyMs5jV0kmoR04J4U6SH2+iQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3392

On 24.08.2021 12:50, Anthony PERARD wrote:
> $(public-y) contains "public/arch-%" but when used by
> $(PUBLIC_HEADERS) $(public-y) is filtered-out by the pattern
> "public/arch-%". So $(public-y) content is never used.

It has been this way from its very introduction, and iirc $(public-y) was
meant to be an abstract construct to which other pieces could get added
in principle. I'm having a slight preference to keeping things as they
are, unless you tell me that this is getting in the way of anything. And
to be clear there as well - if there are no other reasons than pure
cleanup, and if somebody else approved of the removal, I wouldn't object.

Jan

> --- a/xen/include/Makefile
> +++ b/xen/include/Makefile
> @@ -39,9 +39,6 @@ cppflags-$(CONFIG_X86)    += -m32
>  
>  endif
>  
> -public-$(CONFIG_X86) := $(wildcard public/arch-x86/*.h public/arch-x86/*/*.h)
> -public-$(CONFIG_ARM) := $(wildcard public/arch-arm/*.h public/arch-arm/*/*.h)
> -
>  .PHONY: all
>  all: $(headers-y)
>  
> @@ -81,7 +78,7 @@ ifeq ($(XEN_TARGET_ARCH),$(XEN_COMPILE_ARCH))
>  
>  all: headers.chk headers99.chk headers++.chk
>  
> -PUBLIC_HEADERS := $(filter-out public/arch-% public/dom0_ops.h, $(wildcard public/*.h public/*/*.h) $(public-y))
> +PUBLIC_HEADERS := $(filter-out public/arch-% public/dom0_ops.h, $(wildcard public/*.h public/*/*.h))
>  
>  PUBLIC_C99_HEADERS := public/io/9pfs.h public/io/pvcalls.h
>  PUBLIC_ANSI_HEADERS := $(filter-out public/%ctl.h public/xsm/% public/%hvm/save.h $(PUBLIC_C99_HEADERS), $(PUBLIC_HEADERS))
> 



From xen-devel-bounces@lists.xenproject.org Mon Oct 11 12:06:50 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 12:06:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.205898.361315 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZu4q-0001z3-Bs; Mon, 11 Oct 2021 12:06:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 205898.361315; Mon, 11 Oct 2021 12:06:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZu4q-0001yw-85; Mon, 11 Oct 2021 12:06:44 +0000
Received: by outflank-mailman (input) for mailman id 205898;
 Mon, 11 Oct 2021 12:06:42 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Tf9x=O7=arm.com=michal.orzel@srs-us1.protection.inumbo.net>)
 id 1mZu4o-0001yq-I5
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 12:06:42 +0000
Received: from foss.arm.com (unknown [217.140.110.172])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTP
 id b1bc5052-2a8b-11ec-80d7-12813bfff9fa;
 Mon, 11 Oct 2021 12:06:41 +0000 (UTC)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id EFD741063;
 Mon, 11 Oct 2021 05:06:40 -0700 (PDT)
Received: from [10.57.19.78] (unknown [10.57.19.78])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C80D83F70D;
 Mon, 11 Oct 2021 05:06:39 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b1bc5052-2a8b-11ec-80d7-12813bfff9fa
Subject: Re: [PATCH v4 2/3] xen/arm: Check for PMU platform support
To: Julien Grall <julien@xen.org>, xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, bertrand.marquis@arm.com
References: <20211011090047.8878-1-michal.orzel@arm.com>
 <20211011090047.8878-3-michal.orzel@arm.com>
 <1a8a16f6-9887-60ec-3c2d-1df906fd90c4@xen.org>
From: Michal Orzel <michal.orzel@arm.com>
Message-ID: <1b267cfb-a389-14ae-6206-59285452024d@arm.com>
Date: Mon, 11 Oct 2021 14:06:31 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <1a8a16f6-9887-60ec-3c2d-1df906fd90c4@xen.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit

Hi Julien,

On 11.10.2021 12:17, Julien Grall wrote:
> Hi Michal,
> 
> On 11/10/2021 10:00, Michal Orzel wrote:
>> ID_AA64DFR0_EL1/ID_DFR0_EL1 registers provide
>> information about PMU support. Replace structure
>> dbg64/dbg32 with a union and fill in all the
>> register fields according to document:
>> ARM Architecture Registers(DDI 0595, 2021-06).
>>
>> Add macros boot_dbg_feature64/boot_dbg_feature32
>> to check for a debug feature. Add macro
>> cpu_has_pmu to check for PMU support.
>>
>> Signed-off-by: Michal Orzel <michal.orzel@arm.com>
>> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
>> Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>
>> ---
>> Changes since v3:
>> -none
>> Changes since v2:
>> -none
>> Changes since v1:
>> -new in v2
>> ---
>>   xen/include/asm-arm/cpufeature.h | 49 ++++++++++++++++++++++++++++++--
>>   1 file changed, 47 insertions(+), 2 deletions(-)
>>
>> diff --git a/xen/include/asm-arm/cpufeature.h b/xen/include/asm-arm/cpufeature.h
>> index 5ca09b0bff..4fce23844d 100644
>> --- a/xen/include/asm-arm/cpufeature.h
>> +++ b/xen/include/asm-arm/cpufeature.h
>> @@ -4,6 +4,7 @@
>>   #ifdef CONFIG_ARM_64
>>   #define cpu_feature64(c, feat)         ((c)->pfr64.feat)
>>   #define boot_cpu_feature64(feat)       (system_cpuinfo.pfr64.feat)
>> +#define boot_dbg_feature64(feat)       (system_cpuinfo.dbg64.feat)
>>     #define cpu_feature64_has_el0_32(c)    (cpu_feature64(c, el0) == 2)
>>   @@ -22,6 +23,7 @@
>>     #define cpu_feature32(c, feat)         ((c)->pfr32.feat)
>>   #define boot_cpu_feature32(feat)       (system_cpuinfo.pfr32.feat)
>> +#define boot_dbg_feature32(feat)       (system_cpuinfo.dbg32.feat)
>>     #define cpu_has_arm       (boot_cpu_feature32(arm) == 1)
>>   #define cpu_has_thumb     (boot_cpu_feature32(thumb) >= 1)
>> @@ -32,8 +34,10 @@
>>     #ifdef CONFIG_ARM_32
>>   #define cpu_has_gentimer  (boot_cpu_feature32(gentimer) == 1)
>> +#define cpu_has_pmu       (boot_dbg_feature32(perfmon) >= 1)
> 
> From my understanding, on Armv7, perfmon == 0 only means PMUv2 is not present. IOW, it doesn't say whether PMUv1 is supported.
> 
> I think it is OK to treat as the PMU is not supported (ARMv8 treat it like that too), but I would like a comment in the code so it is clear this is a deliberate choice.
> 
We are checking if any version of PMU is supported meaning perfmon is >=1.
On ARMv8 any value higher than 0 means that PMU is present. 0 means not supported.
On ARMv7 the above is not really true. Any value higher than 0 and lower than 15 means the PMU is supported.
So I think I should do:
#define cpu_has_pmu       ((boot_dbg_feature32(perfmon) >= 1) && \
                           (boot_dbg_feature32(perfmon) < 15))

Do you agree? 

>>   #else
>>   #define cpu_has_gentimer  (1)
>> +#define cpu_has_pmu       (boot_dbg_feature64(pmu_ver) >= 1)
>>   #endif
>>   #define cpu_has_security  (boot_cpu_feature32(security) > 0)
>>   @@ -181,8 +185,28 @@ struct cpuinfo_arm {
>>           };
>>       } pfr64;
>>   -    struct {
>> +    union {
>>           register_t bits[2];
>> +        struct {
>> +            /* DFR0 */
>> +            unsigned long debug_ver:4;
>> +            unsigned long trace_ver:4;
>> +            unsigned long pmu_ver:4;
>> +            unsigned long brps:4;
>> +            unsigned long __res0:4;
>> +            unsigned long wrps:4;
>> +            unsigned long __res1:4;
>> +            unsigned long ctx_cmps:4;
>> +            unsigned long pms_ver:4;
>> +            unsigned long double_lock:4;
>> +            unsigned long trace_filt:4;
>> +            unsigned long __res2:4;
>> +            unsigned long mtpmu:4;
>> +            unsigned long __res3:12;
>> +
>> +            /* DFR1 */
>> +            unsigned long __res4:64;
>> +        };
>>       } dbg64;
>>         struct {
>> @@ -321,8 +345,29 @@ struct cpuinfo_arm {
>>           };
>>       } pfr32;
>>   -    struct {
>> +    union {
>>           register_t bits[2];
>> +        struct {
>> +            /* DFR0 */
>> +            unsigned long copdbg:4;
>> +            unsigned long copsdbg:4;
>> +            unsigned long mmapdbg:4;
>> +            unsigned long coptrc:4;
>> +            unsigned long mmaptrc:4;
>> +            unsigned long mprofdbg:4;
>> +            unsigned long perfmon:4;
>> +            unsigned long tracefilt:4;
>> +#ifdef CONFIG_ARM_64
>> +            unsigned long __res0:32;
>> +#endif
>> +
>> +            /* DFR1 */
>> +            unsigned long mtpmu:4;
>> +            unsigned long __res1:28;
>> +#ifdef CONFIG_ARM_64
>> +            unsigned long __res2:32;
>> +#endif
>> +        };
>>       } dbg32;
>>         struct {
>>
> 
> Cheers,
> 

Cheers,
Michal


From xen-devel-bounces@lists.xenproject.org Mon Oct 11 12:06:56 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 12:06:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.205899.361326 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZu52-0002Ir-KW; Mon, 11 Oct 2021 12:06:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 205899.361326; Mon, 11 Oct 2021 12:06:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZu52-0002Ik-Fs; Mon, 11 Oct 2021 12:06:56 +0000
Received: by outflank-mailman (input) for mailman id 205899;
 Mon, 11 Oct 2021 12:06:54 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Tf9x=O7=arm.com=michal.orzel@srs-us1.protection.inumbo.net>)
 id 1mZu50-0002I0-Cf
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 12:06:54 +0000
Received: from foss.arm.com (unknown [217.140.110.172])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTP
 id b872abf9-2a8b-11ec-80d7-12813bfff9fa;
 Mon, 11 Oct 2021 12:06:53 +0000 (UTC)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 272951063;
 Mon, 11 Oct 2021 05:06:53 -0700 (PDT)
Received: from [10.57.19.78] (unknown [10.57.19.78])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 36D473F70D;
 Mon, 11 Oct 2021 05:06:50 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b872abf9-2a8b-11ec-80d7-12813bfff9fa
Subject: Re: [PATCH v5 07/11] xen/domctl: Introduce XEN_DOMCTL_CDF_vpci flag
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Rahul Singh <rahul.singh@arm.com>
Cc: xen-devel@lists.xenproject.org, bertrand.marquis@arm.com,
 Andre.Przywara@arm.com, Christian Lindig <christian.lindig@citrix.com>,
 David Scott <dave@recoil.org>, Ian Jackson <iwj@xenproject.org>,
 Wei Liu <wl@xen.org>, Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Ian Jackson <iwj@xenproject.org>
References: <cover.1633540842.git.rahul.singh@arm.com>
 <20d5b9d6a0d01a7b90711d28cbefb5701a88b438.1633540842.git.rahul.singh@arm.com>
 <YWQDguvmf/O4rDIs@MacBook-Air-de-Roger.local>
From: Michal Orzel <michal.orzel@arm.com>
Message-ID: <669869e3-3c99-49d1-26df-428334e0c68e@arm.com>
Date: Mon, 11 Oct 2021 14:06:42 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <YWQDguvmf/O4rDIs@MacBook-Air-de-Roger.local>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit

Hi Roger,

On 11.10.2021 11:27, Roger Pau Monné wrote:
> On Wed, Oct 06, 2021 at 06:40:33PM +0100, Rahul Singh wrote:
>> Introduce XEN_DOMCTL_CDF_vpci flag to enable VPCI support in XEN.
>> Reject the use of this new flag for x86 as VPCI is not supported for
>> DOMU guests for x86.
> 
> I don't like this approach, XEN_DOMCTL_CDF_vpci should be set for x86
> PVH dom0, like we do for any other CDF flags when Xen builds dom0.
> 
> Things like PVH vs PV get translated into CDF flags by create_dom0,
> and processed normally by the sanitise_domain_config logic, vPCI
> should be handled that way.
> 
> Do you think you could see about fixing this?
> 
> Thanks, Roger.
> 

As Rahul is on leave:
I agree with you. XEN_DOMCTL_CDF_vpci should be set in dom0_cfg.flags in create_dom0 for pvh.
We can do such fix in a new patch together with adding physcap for vpci.

Cheers,
Michal


From xen-devel-bounces@lists.xenproject.org Mon Oct 11 12:11:32 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 12:11:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.205912.361337 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZu9T-0003zJ-4g; Mon, 11 Oct 2021 12:11:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 205912.361337; Mon, 11 Oct 2021 12:11:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZu9T-0003zC-1C; Mon, 11 Oct 2021 12:11:31 +0000
Received: by outflank-mailman (input) for mailman id 205912;
 Mon, 11 Oct 2021 12:11:30 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=LfEM=O7=arm.com=Bertrand.Marquis@srs-us1.protection.inumbo.net>)
 id 1mZu9S-0003z6-Dy
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 12:11:30 +0000
Received: from EUR02-VE1-obe.outbound.protection.outlook.com (unknown
 [2a01:111:f400:fe06::61b])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 649fc7a0-32ad-47c5-a784-2935b9a5d7d2;
 Mon, 11 Oct 2021 12:11:28 +0000 (UTC)
Received: from AM4PR0902CA0009.eurprd09.prod.outlook.com
 (2603:10a6:200:9b::19) by VI1PR08MB3965.eurprd08.prod.outlook.com
 (2603:10a6:803:dd::33) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.19; Mon, 11 Oct
 2021 12:11:19 +0000
Received: from VE1EUR03FT062.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:200:9b:cafe::17) by AM4PR0902CA0009.outlook.office365.com
 (2603:10a6:200:9b::19) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18 via Frontend
 Transport; Mon, 11 Oct 2021 12:11:19 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT062.mail.protection.outlook.com (10.152.18.252) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4587.18 via Frontend Transport; Mon, 11 Oct 2021 12:11:19 +0000
Received: ("Tessian outbound 2e7020cc8961:v103");
 Mon, 11 Oct 2021 12:11:18 +0000
Received: from 01f5a5b59deb.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 8043191C-5374-43E4-A771-E74CBC484794.1; 
 Mon, 11 Oct 2021 12:11:08 +0000
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 01f5a5b59deb.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Mon, 11 Oct 2021 12:11:08 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com (2603:10a6:4:74::9)
 by DB6PR08MB2678.eurprd08.prod.outlook.com (2603:10a6:6:1b::27) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.24; Mon, 11 Oct
 2021 12:11:05 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955]) by DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955%4]) with mapi id 15.20.4587.026; Mon, 11 Oct 2021
 12:11:04 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 649fc7a0-32ad-47c5-a784-2935b9a5d7d2
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=os/eX9L6AOkcfX4liSeRkJtaGkcuWy6sOz4F7zelP78=;
 b=ribdkTZk2d1YBatRzGHiC6lk1gU/9J74vbS0bWRp9Sv8BuJfA7PMn3ZjmAMhwlOjnSttFRhuVGMhb4cdHSLzCsTz71uaoqoZOelvbRHGfnv7JYVE4mRclblAnXFzWlnUWkR+dDITUPj8cKFQ8exnXfTeOQ5cH2oDl5h3WifRmgk=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 4e4e86584cdc100a
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=btuzEr6nwtMC780Yk2UXT728YYdPSdiPN1Y1ESRqamDU9ptier4dO86y1hGQJ8Cc1fgWnvG6i2DN2LkM1gjtgN4eEFwZPimpU6l7VLNw01Oal3LXKdy017HbhfnZV1duy01aV5OI0vUy1uq0FcT8J1rK2ys1mv6BSZ7rUiMyUDrmAlcn3/Pi8sEAIZYVgcoV+9tJGs+JLZErPTnxQGnszwgek8hsn8rdbPYKbgi+OCS5EQswx7QFmoMw30sdt95d70b6bDhf0TICWOlcJxYlnYJHTR0WXFtujIRkAAXuSDrnneAaXdIGb6vqmaGZxpfu2NDIe3eYMvo/Ff8ELALYCg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=os/eX9L6AOkcfX4liSeRkJtaGkcuWy6sOz4F7zelP78=;
 b=UIwvXH+R/rwS+nC7/yhdpbxiLfOG0Mg6IREXfFXawUSAIRDC9mVzOCNQJj08eQjb90NeMGju8b0RdXj8C9a3jeXLTlbu415g+/QICQuZjNNSYWxJt8Uzeo5nDEU6p4EdaJsACaV9zseZhhUaGMA7q3fP1oZjFWq59TgIenVcManf11hauCieD1tklC5zmU1nRL8i3xemiqta0WakWLL6NGeeHSyuLddOLACaXY7N1vOprSPcHtCwkcFStsTl7j1f1EdzduDNcZiy01a0NQZz+h74cm6OJzEUxdMrvmz5V02+qvgF1NJ7qcsacGRdaQdUDfGTyn0OXRJ6T8NEPPIioQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=os/eX9L6AOkcfX4liSeRkJtaGkcuWy6sOz4F7zelP78=;
 b=ribdkTZk2d1YBatRzGHiC6lk1gU/9J74vbS0bWRp9Sv8BuJfA7PMn3ZjmAMhwlOjnSttFRhuVGMhb4cdHSLzCsTz71uaoqoZOelvbRHGfnv7JYVE4mRclblAnXFzWlnUWkR+dDITUPj8cKFQ8exnXfTeOQ5cH2oDl5h3WifRmgk=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>
CC: Rahul Singh <Rahul.Singh@arm.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, Andre Przywara <Andre.Przywara@arm.com>,
	Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>, Juergen Gross
	<jgross@suse.com>, Stefano Stabellini <sstabellini@kernel.org>
Subject: Re: [PATCH v5 01/11] xen/arm: xc_domain_ioport_permission(..) not
 supported on ARM.
Thread-Topic: [PATCH v5 01/11] xen/arm: xc_domain_ioport_permission(..) not
 supported on ARM.
Thread-Index: AQHXutl5d8zkP9bsD0GXT4+5QPGclKvNtfkAgAAGc4A=
Date: Mon, 11 Oct 2021 12:11:04 +0000
Message-ID: <77CF7FA5-C566-469E-B4A8-0400789890BB@arm.com>
References: <cover.1633540842.git.rahul.singh@arm.com>
 <d292392268df2c74c4103a82ef917072643407a8.1633540842.git.rahul.singh@arm.com>
 <YWQkblfNMYEs6jI9@MacBook-Air-de-Roger.local>
In-Reply-To: <YWQkblfNMYEs6jI9@MacBook-Air-de-Roger.local>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3654.120.0.1.13)
Authentication-Results-Original: citrix.com; dkim=none (message not signed)
 header.d=none;citrix.com; dmarc=none action=none header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: fed305a4-c33d-421d-5c69-08d98cb03bb3
x-ms-traffictypediagnostic: DB6PR08MB2678:|VI1PR08MB3965:
x-ms-exchange-transport-forked: True
X-Microsoft-Antispam-PRVS:
	<VI1PR08MB39655E31E4EE994AE260AAF09DB59@VI1PR08MB3965.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:10000;OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 rwm/4hMbNlTALI/9Fjfpr20UbHQyogFz/PNt/WKuFklfBij81CKTwgWoagTMzx1phwku2aYYr4xPUxK7CtXs/idqPu6/7s7/rS1nmlwDFyRUGGO/pCCD/quXIgiB1Nb4SMiYfcJOwl/5jBkk2yarL6D/z06/N2dwYm+1rZhY27W9/Oqp6bEYxINzPXpsOLZNsscf1njuWgJirzGjrUN9fLGnmUCN8AAfM5DIQ5SolBUHObLrcNppWAdWFP8I7UvCKpTOyydKyFQMGhPDqyjFDPQisGx5XupkxFjjOvXD4uO5e2RnUD/sMpAmPtt09NmQT3J1236jZqlPLlBzuaNB2t5K9z7ha8FhCxy2dN47FB9q3bcr3S47W96ZieA0k4mbqOQvjqCzQzk7DfDEo1fFT6TJYoJ/zbDK+l1esl2iVb3exGAAlqSd2iEKSDsuBojNrbBwGyq6hfHDPYOlreJ1H5j1AaicOwTRlBHXkTd7JgtLMCHi9VbHgqNllLNWl9mHi7Dtdq4Luww9r8GRdYyfaTizt5UOWJmi5K/MgzF9yolwZGJhc5f4mDKIZduniu/Wkmr3vBxk/Aoo0orR9skROPBYYRTGeoGnj0TU3P6bwTInVbPiRtl4mBL1to39TLZCGjeyIlJrf+kVR/i+MZfd20O95mNZ+XuqP4wW21uSqZGBRvoytCLPGGH/zhbUw6GIlhByj1/gpPvr0N2LSciPiDHh9TTfS7dSDqhRcr4C0Jlp0Job6fJY6m2KJCmJffQc
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB6PR0801MB2024.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(71200400001)(5660300002)(33656002)(26005)(4326008)(6916009)(38070700005)(6512007)(4744005)(316002)(83380400001)(86362001)(8936002)(36756003)(508600001)(38100700002)(91956017)(76116006)(64756008)(66556008)(2906002)(66476007)(53546011)(8676002)(66946007)(54906003)(186003)(2616005)(6486002)(6506007)(122000001)(66446008)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-ID: <CBA956A7909ADD49BBDD6821981145BB@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR08MB2678
Original-Authentication-Results: citrix.com; dkim=none (message not signed)
 header.d=none;citrix.com; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT062.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	b979b828-8637-431a-b2bb-08d98cb0331c
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	A77PJIUjc+aczOPjJx2Bxblitj7f8iRRZy8YXoKub4RuxKRj0tuCRJrfp/L8CuXrZHA8AqBLIyM6oP271uOgpjFIbgJQWk9GH/0lsZB/40obtYqG+qBzY7KTBYvRJ65yFCQUjLNwC4Unaqw5r5b740g9nGYlHqDORQqiZgD1aEa4iT8Lqt2wAMVe40SwQfSvc1G/pbORL6qtUjZKw6FiFbrVAjIIHrcL4WiW80vGSlXdMNYswXWTrC89QpaC+GHto2tPkgJvZstEVgtR7YV+q9avGaVeXTfLGCsxHbtCbtLYNP3pi2yLDyz5iR2iyNffH/XnFf4oOo295KPkVmTT02Vmray/ZddWxdsB/xcliaW1U2n24KtUJn87zNppbS8Cw1mXRbrdd3qTU6lZxmi1y7bdK2TVGPomMxkJknGg2a1+UFa7Den80siEg0xOQ0YV/TRbeY3NTfRQRsLj9yMLNsjI/Tx7KZWoq3Wr3wr7Yypc7RwxOZe2VeD5MjoIt0cSiEdYwbdUcLRIWcMGkit53J6NJnF/mzYI+FBir8i83ZsU2A/wY1eALS+On7n9xT1Pu8V6I5Ua4q+BbsUYJfIN6cuPNHmPfl2dwolqkSuGQOrakADQrbtsQerRCcyiOAOOBsulSbAJ9bZTVxUDYs5gDs9ShiWWWywmK+MVhst2b+UhgX7gVkZexte+L1X7RuM+BbdPUEyBWNeXi/oFRA/7ZA==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(8936002)(33656002)(316002)(86362001)(107886003)(4326008)(26005)(82310400003)(8676002)(70586007)(70206006)(6862004)(186003)(4744005)(53546011)(5660300002)(54906003)(6506007)(2906002)(356005)(336012)(6486002)(47076005)(83380400001)(2616005)(81166007)(6512007)(508600001)(36756003)(36860700001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2021 12:11:19.2289
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: fed305a4-c33d-421d-5c69-08d98cb03bb3
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT062.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3965

SGkgUm9nZXIsDQoNCj4gT24gMTEgT2N0IDIwMjEsIGF0IDEyOjQ3LCBSb2dlciBQYXUgTW9ubsOp
IDxyb2dlci5wYXVAY2l0cml4LmNvbT4gd3JvdGU6DQo+IA0KPiBPbiBXZWQsIE9jdCAwNiwgMjAy
MSBhdCAwNjo0MDoyN1BNICswMTAwLCBSYWh1bCBTaW5naCB3cm90ZToNCj4+IEFSTSBhcmNoaXRl
Y3R1cmUgZG9lcyBub3QgaW1wbGVtZW50IEkvTyBwb3J0cy4gSWdub3JlIHRoaXMgY2FsbCBvbiBB
Uk0NCj4+IHRvIGF2b2lkIHRoZSBvdmVyaGVhZCBvZiBtYWtpbmcgYSBoeXBlcmNhbGwganVzdCBm
b3IgWGVuIHRvIHJldHVybg0KPj4gLUVOT1NZUy4NCj4gDQo+IFdoYXQgaXMgdGhlIGNhbCB0cmFj
ZSBvZiB0aGlzIGZ1bmN0aW9uIGFjdHVhbGx5IG9uIEFybT8NCj4gDQo+IEFGQUlDVCBsaWJ4bCB3
aWxsIG9ubHkgY2FsbCB4Y19kb21haW5faW9wb3J0X3Blcm1pc3Npb24gaWYgdGhlcmUgYXJlDQo+
IElPIHBvcnRzIGV4cGxpY2l0bHkgZGVmaW5lZCBpbiB0aGUgZ3Vlc3QgY29uZmlndXJhdGlvbiwg
b3IgaWYgYW55IG9mDQo+IHRoZSBCQVJzIG9mIHRoZSBQQ0kgZGV2aWNlIGlzIGluIHRoZSBJTyBz
cGFjZSwgd2hpY2ggaXMgbm90IHBvc3NpYmxlDQo+IG9uIEFybS4NCg0KUENJIGRldmljZXMgQkFS
cyBjYW4gYmUgaW4gdGhlIElPIHNwYWNlIGFzIHRoZSBQQ0kgZGV2aWNlcyBhcmUgbm90DQpBcm0g
c3BlY2lmaWMuIFRoZXJlIGlzIG5vdCBpb3BvcnRzIG9uIGFybSBzbyB0byBiZSB1c2VkIHRob3Nl
IGNhbiBiZQ0KaW4gc29tZSBjYXNlcyByZW1hcHBlZCBhbmQgYWNjZXNzZWQgYXMgTU1JT3Mgb3Ig
YXJlIG5vdCBwb3NzaWJsZQ0KdG8gdXNlIGF0IGFsbC4NCg0KQnV0IHRoZSBJTyBzcGFjZSBkb2Vz
IGFwcGVhciB3aGVuIEJBUnMgYXJlIGxpc3RlZCBldmVuIG9uIEFybS4NCg0KUmVnYXJkcw0KQmVy
dHJhbmQNCg0KDQo+IA0KPiBUaGFua3MsIFJvZ2VyLg0KDQo=


From xen-devel-bounces@lists.xenproject.org Mon Oct 11 12:13:19 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 12:13:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.205919.361349 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZuB9-0004aS-J1; Mon, 11 Oct 2021 12:13:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 205919.361349; Mon, 11 Oct 2021 12:13:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZuB9-0004aL-DW; Mon, 11 Oct 2021 12:13:15 +0000
Received: by outflank-mailman (input) for mailman id 205919;
 Mon, 11 Oct 2021 12:13:14 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mZuB8-0004a9-3Q; Mon, 11 Oct 2021 12:13:14 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mZuB7-0004fO-VH; Mon, 11 Oct 2021 12:13:13 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mZuB7-0004Pj-LZ; Mon, 11 Oct 2021 12:13:13 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mZuB7-0008Dg-L6; Mon, 11 Oct 2021 12:13:13 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=IbySeZE6uY49338+b+n5XUwuLIuRGK8OffFlUWam3/E=; b=18ujh5dLz2bv6Imu3pKJCpOsZT
	ujAob8Ue2avEU11FOiomePIJuxki0gSOI4KiUB4j/h11Zqo6FzgtIGWg4RIshLOSnVM6x3VAe2eZl
	wGZgYSEM6SuWUL06scCe1/T5r5F4eKSJZxB01Vh2Y9NzLkzKmKTkxbDJKMU0/65WNOwI=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165462-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 165462: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=19ee56c4b33faa33078894a6c8495c81c660b8be
X-Osstest-Versions-That:
    ovmf=769e63999ff5c786d5aac1fd6dbfa4748fbccbc7
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 11 Oct 2021 12:13:13 +0000

flight 165462 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165462/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 19ee56c4b33faa33078894a6c8495c81c660b8be
baseline version:
 ovmf                 769e63999ff5c786d5aac1fd6dbfa4748fbccbc7

Last test of basis   165433  2021-10-08 16:10:05 Z    2 days
Testing same since   165462  2021-10-11 06:10:05 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Liu, Zhiguang <Zhiguang.Liu@intel.com>
  Zhiguang Liu <zhiguang.liu@intel.com>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   769e63999f..19ee56c4b3  19ee56c4b33faa33078894a6c8495c81c660b8be -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Mon Oct 11 12:15:32 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 12:15:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.205927.361362 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZuDL-0005Ej-V6; Mon, 11 Oct 2021 12:15:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 205927.361362; Mon, 11 Oct 2021 12:15:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZuDL-0005Ec-S5; Mon, 11 Oct 2021 12:15:31 +0000
Received: by outflank-mailman (input) for mailman id 205927;
 Mon, 11 Oct 2021 12:15:30 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=LfEM=O7=arm.com=Bertrand.Marquis@srs-us1.protection.inumbo.net>)
 id 1mZuDK-0005ER-2J
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 12:15:30 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com (unknown
 [2a01:111:f400:fe0e::603])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id b8297f47-e4bb-43c6-aed1-4e0be6ae1d0a;
 Mon, 11 Oct 2021 12:15:28 +0000 (UTC)
Received: from DB6PR0402CA0012.eurprd04.prod.outlook.com (2603:10a6:4:91::22)
 by VI1PR08MB3629.eurprd08.prod.outlook.com (2603:10a6:803:7f::25)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.21; Mon, 11 Oct
 2021 12:15:26 +0000
Received: from DB5EUR03FT043.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:4:91:cafe::2c) by DB6PR0402CA0012.outlook.office365.com
 (2603:10a6:4:91::22) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.21 via Frontend
 Transport; Mon, 11 Oct 2021 12:15:26 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT043.mail.protection.outlook.com (10.152.20.236) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4587.18 via Frontend Transport; Mon, 11 Oct 2021 12:15:26 +0000
Received: ("Tessian outbound 8e26f7114b75:v103");
 Mon, 11 Oct 2021 12:15:26 +0000
Received: from 0c3af9d56fa6.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 B0A37283-EE72-4C5F-AF44-DF3D623B8D32.1; 
 Mon, 11 Oct 2021 12:15:15 +0000
Received: from EUR02-AM5-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 0c3af9d56fa6.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Mon, 11 Oct 2021 12:15:15 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com (2603:10a6:4:74::9)
 by DB6PR08MB2678.eurprd08.prod.outlook.com (2603:10a6:6:1b::27) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.24; Mon, 11 Oct
 2021 12:15:12 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955]) by DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955%4]) with mapi id 15.20.4587.026; Mon, 11 Oct 2021
 12:15:12 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b8297f47-e4bb-43c6-aed1-4e0be6ae1d0a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=zEKwnfBc4cXiX2oHKPeKys6AniPzg4+TgZzBCWQxMO8=;
 b=JC6Am+xsdE2f67OomWgDATXOCYX8DFGxt9S1Jc5tL5d1IZANDsN0LcuI9Z3wSoZbbNZSkbH3yuB/yfxe23EMft8C+3LrPzELotkDGaymOdVWOKGn6iF0VIifXr0NMj3EBR+wuQlclOVWWAUvgfjneldM2IP4PU7ZsFFpKs6bIfk=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 9bd9bbad1814dd68
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ccqq3s63xEc6bXBMTd0EyncF8D5R3358UyfrDQgIJNSoxa0Bj5xvfmadbuovAqHjcOh8YOB7fSoRgICGWViztfn/nScpCd9jB1Ctd7iZ2AfCBwxADNYgFrTsijIEuBSlmbuXGJfpr2MuRiEExfFQzAg5dxW/JO41z6rDeejQfWlv1zkyV5FJOzoMnieZoRVJRD74HiSdmXkbsIRGvxi980tDwMSZwDx6TFwINLiIuQchQaDBuWjx0k3jXVfAFMQiJJSq0e6rdcgT6Okg8iKFgRB4PfaLJnu357c7j9pNRafDx0QNN2+l1FrvCjbq6RJoJcHeGQ95hsPahcaDJPDtBA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=zEKwnfBc4cXiX2oHKPeKys6AniPzg4+TgZzBCWQxMO8=;
 b=I7btnCCABF0J7vkwk6lrEZx2cZOYa3WlFeCDscKBDN0J7qQthEpsn43IvPp4pgtuRv21QAzcht90JEJ6LyCScZMdUorHpeLdDTCMc5rVEYyZ7HbWY6f/ME7HfuavEaKwDtEpsP8e9YtkOMMEG19AstLOHp0NjFrnue1LzjqQIMcFXpMVLaD1n8KJ+wW9VnOvJij9QUv+lLWGMaDBIn0aBvdU4xhqEsk+kQNo34bv/yGgBn8N160QH8Jy2ltf4p6CJJexseCPiHUb4MAD1paaMbqHvW7UFcealLkDrI7a7xcjntnmv44UriLHe88eUs+ObVpKOY1yRIw5f5dcijmr/g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=zEKwnfBc4cXiX2oHKPeKys6AniPzg4+TgZzBCWQxMO8=;
 b=JC6Am+xsdE2f67OomWgDATXOCYX8DFGxt9S1Jc5tL5d1IZANDsN0LcuI9Z3wSoZbbNZSkbH3yuB/yfxe23EMft8C+3LrPzELotkDGaymOdVWOKGn6iF0VIifXr0NMj3EBR+wuQlclOVWWAUvgfjneldM2IP4PU7ZsFFpKs6bIfk=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>
CC: Rahul Singh <Rahul.Singh@arm.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, Andre Przywara <Andre.Przywara@arm.com>,
	Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH v5 09/11] xen/arm: Transitional change to build HAS_VPCI
 on ARM.
Thread-Topic: [PATCH v5 09/11] xen/arm: Transitional change to build HAS_VPCI
 on ARM.
Thread-Index: AQHXutl6IKP3e9kgZEyzzoGYw0qm9avNtJ8AgAAI9IA=
Date: Mon, 11 Oct 2021 12:15:12 +0000
Message-ID: <647F47F9-E89B-43C3-8226-5F59286CA0C8@arm.com>
References: <cover.1633540842.git.rahul.singh@arm.com>
 <b9653c6247060574cf68e1f780ef1db3dd0c20d3.1633540842.git.rahul.singh@arm.com>
 <YWQjTOypE96IqWmA@MacBook-Air-de-Roger.local>
In-Reply-To: <YWQjTOypE96IqWmA@MacBook-Air-de-Roger.local>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3654.120.0.1.13)
Authentication-Results-Original: citrix.com; dkim=none (message not signed)
 header.d=none;citrix.com; dmarc=none action=none header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: 921354cb-6feb-4bd2-710d-08d98cb0cedd
x-ms-traffictypediagnostic: DB6PR08MB2678:|VI1PR08MB3629:
x-ms-exchange-transport-forked: True
X-Microsoft-Antispam-PRVS:
	<VI1PR08MB3629A84702E71EA36B23CEFD9DB59@VI1PR08MB3629.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:9508;OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 +l4qmzpHs/EqQbsUuQC8VGEwqifImNI7tJo0EEDIJYPrVmnBFFnI03BKQgP6T0Hf7PJKzPIMCEWKbQTa8Wyx0JtsbVNxh1TfdM5swWrtltEagrlYbJqAqE45/SM1kabj5Kd4l4X0yRyRXtnckWdXNR2z6NG4t8EIvd2hEaTnBIxeTE/4n0TFLOMVOhqrIBMH4FwOYYb3OKGqplPJAIhLGz3luypzVLCUc31tm/oNM1aY0lHVV3G2Tz0ZLJSazBN4CntqYaFZsYuI9MxNitZ0Loevmx76q3Cc+Qpvh1UIaeQgViNYQUmQidbEV4pBjDOjVByUSE3yrJWvH0yaU+HVEnFImI86EPtVdr9pz6G8mDQTGgW9V0paMNw+kT79r8z9NOFORm8eTAMCbt2VxU31cZ8kfyj3+6tgBGGjeBSzFeNq4wjU0NUz3/9XxXsXMmNvpL1TzqyG+jf0T2jY71eZU1BswzC9aiAVm35cFHeUEAMs7RRtmlstYHAXkZ3PYW05nLyGaYgqz5Cqa2If6QjBQQx2iGkmQ9eZ54eEcBBAuGoyHVhjjt/xvTxXTkwm628qI0amsitZb6Hthm23bGoD/E60tyVnwPM8xVUxxehDCE/VUMTByFnNTy1ZAWroCVqSXPucn/GNsV478RBMLzS+LRLApA+jW/dKcEFq45ldklNTZ/J8o+10FS0UcPsxGgn5S/1B60rQmkDkeOJYw6/3MffFNbViPQDc6n+wPU1NBZ2Lx+3FWnjEgVPdoq820trZ
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB6PR0801MB2024.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(66556008)(2906002)(66476007)(64756008)(8676002)(53546011)(38100700002)(91956017)(76116006)(122000001)(66446008)(186003)(54906003)(2616005)(66946007)(6486002)(6506007)(33656002)(4326008)(26005)(71200400001)(5660300002)(6916009)(508600001)(36756003)(6512007)(38070700005)(86362001)(8936002)(316002)(83380400001)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-ID: <6574D143AD181E4DBB6AF5535588C854@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR08MB2678
Original-Authentication-Results: citrix.com; dkim=none (message not signed)
 header.d=none;citrix.com; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT043.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	85655f27-0212-416a-5b7b-08d98cb0c6a3
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	f6UeQc9ULva2opj8u2WMFDRI6MCxXTalq+/mTKxXy0g2KNcx8UpEwBV6KUMLvghAmoBRIeij4u3krxvNSeSrIoftULBDWAeZWkUPBiZkYfl2yp4Yftv8FTb99tEHpMFSG3d57dV6Kj5usAIBLbTk2bzOVJKXMKf5qxjlCE+EebO38bHlaZkyMzEC5JWLIM7BAlVr0WLQcXE/qq9daxAem7teljwbxshptxFk9nvPk5oS05bnggfvhdGOxOmv5FzZnDfLggoD3kSzwsn/faxDhOIDCz655THYCXyKLPpqxPdFJ4aSRnrq4ON2kji+hdIv8zuY7QibTdGOL+ctpd1LKyf+WfnFpnF3m9yaTKT3MYoOcuY+wM9uYsrru+aUIMQq4Hq3pr4E6zqt450sj8ziYX1BpMxzj2FLflWDv13IMwaVu6Lih7z2FlWig1nRy/sk3xpzSMHee3d1pXWOyor5MQF+0UlLFq/2sUYpsmebiI4vMOirLxDHRDhq/nyFxXNWC1vPwiH9T85grHmfDibgi/KnbjRi1rvwUTU/XB8e+NYkr3RyIB5lQ9FJyYPrCxX4G0tsjFTBWiqZPWpHCijFdKEwXYMFaKy/52ptpjfob3pL+HSvgzLC7ACPYLvRvIO7BIjsQBRgDAotps5oPfH68jxLAjQcQRhSE+rAH1Xd0M3rj1/zDAaqjbQZ1U928Txy5yFww5g41IiQlY+wngL9bA==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(36756003)(86362001)(2616005)(508600001)(356005)(81166007)(47076005)(33656002)(70206006)(107886003)(6862004)(4326008)(70586007)(186003)(5660300002)(6512007)(6486002)(53546011)(36860700001)(82310400003)(8936002)(2906002)(6506007)(54906003)(26005)(83380400001)(8676002)(336012)(316002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2021 12:15:26.2307
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 921354cb-6feb-4bd2-710d-08d98cb0cedd
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT043.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3629

SGkgUm9nZXIsDQoNCj4gT24gMTEgT2N0IDIwMjEsIGF0IDEyOjQzLCBSb2dlciBQYXUgTW9ubsOp
IDxyb2dlci5wYXVAY2l0cml4LmNvbT4gd3JvdGU6DQo+IA0KPiBPbiBXZWQsIE9jdCAwNiwgMjAy
MSBhdCAwNjo0MDozNVBNICswMTAwLCBSYWh1bCBTaW5naCB3cm90ZToNCj4+IFRoaXMgcGF0Y2gg
d2lsbCBiZSByZXZlcnRlZCBvbmNlIHdlIGFkZCBzdXBwb3J0IGZvciBWUENJIE1TSS9NU0lYDQo+
PiBzdXBwb3J0IG9uIEFSTS4NCj4+IA0KPj4gU2lnbmVkLW9mZi1ieTogUmFodWwgU2luZ2ggPHJh
aHVsLnNpbmdoQGFybS5jb20+DQo+PiBBY2tlZC1ieTogU3RlZmFubyBTdGFiZWxsaW5pIDxzc3Rh
YmVsbGluaUBrZXJuZWwub3JnPg0KPj4gUmV2aWV3ZWQtYnk6IEJlcnRyYW5kIE1hcnF1aXMgPGJl
cnRyYW5kLm1hcnF1aXNAYXJtLmNvbT4NCj4gDQo+IFJldmlld2VkLWJ5OiBSb2dlciBQYXUgTW9u
bsOpIDxyb2dld3IucGF1QGNpdHJpeC5jb20+DQoNClRoYW5rcw0KDQo+IA0KPj4gLS0tDQo+PiBD
aGFuZ2UgaW4gdjU6IG5vbmUNCj4+IENoYW5nZSBpbiB2NDoNCj4+IC0gQWRkZWQgQWNrZWQtYnk6
IFN0ZWZhbm8gU3RhYmVsbGluaSA8c3N0YWJlbGxpbmlAa2VybmVsLm9yZz4NCj4+IC0gQWRkZWQg
UmV2aWV3ZWQtYnk6IEJlcnRyYW5kIE1hcnF1aXMgPGJlcnRyYW5kLm1hcnF1aXNAYXJtLmNvbT4N
Cj4+IENoYW5nZSBpbiB2Mzogbm9uZQ0KPj4gQ2hhbmdlIGluIHYyOiBQYXRjaCBpbnRyb2R1Y2Vk
IGluIHYyDQo+PiAtLS0NCj4+IC0tLQ0KPj4geGVuL2RyaXZlcnMvdnBjaS9NYWtlZmlsZSB8IDMg
KystDQo+PiB4ZW4vZHJpdmVycy92cGNpL2hlYWRlci5jIHwgMiArKw0KPj4geGVuL2luY2x1ZGUv
YXNtLWFybS9wY2kuaCB8IDggKysrKysrKysNCj4+IDMgZmlsZXMgY2hhbmdlZCwgMTIgaW5zZXJ0
aW9ucygrKSwgMSBkZWxldGlvbigtKQ0KPj4gDQo+PiBkaWZmIC0tZ2l0IGEveGVuL2RyaXZlcnMv
dnBjaS9NYWtlZmlsZSBiL3hlbi9kcml2ZXJzL3ZwY2kvTWFrZWZpbGUNCj4+IGluZGV4IDU1ZDFi
ZGZkYTAuLjFhMTQxM2I5M2UgMTAwNjQ0DQo+PiAtLS0gYS94ZW4vZHJpdmVycy92cGNpL01ha2Vm
aWxlDQo+PiArKysgYi94ZW4vZHJpdmVycy92cGNpL01ha2VmaWxlDQo+PiBAQCAtMSArMSwyIEBA
DQo+PiAtb2JqLXkgKz0gdnBjaS5vIGhlYWRlci5vIG1zaS5vIG1zaXgubw0KPj4gK29iai15ICs9
IHZwY2kubyBoZWFkZXIubw0KPj4gK29iai0kKENPTkZJR19IQVNfUENJX01TSSkgKz0gbXNpLm8g
bXNpeC5vDQo+PiBkaWZmIC0tZ2l0IGEveGVuL2RyaXZlcnMvdnBjaS9oZWFkZXIuYyBiL3hlbi9k
cml2ZXJzL3ZwY2kvaGVhZGVyLmMNCj4+IGluZGV4IGJhOWEwMzYyMDIuLmY4Y2Q1NWU3YzAgMTAw
NjQ0DQo+PiAtLS0gYS94ZW4vZHJpdmVycy92cGNpL2hlYWRlci5jDQo+PiArKysgYi94ZW4vZHJp
dmVycy92cGNpL2hlYWRlci5jDQo+PiBAQCAtOTYsOCArOTYsMTAgQEAgc3RhdGljIHZvaWQgbW9k
aWZ5X2RlY29kaW5nKGNvbnN0IHN0cnVjdCBwY2lfZGV2ICpwZGV2LCB1aW50MTZfdCBjbWQsDQo+
PiAgICAgICogRklYTUU6IHB1bmNoaW5nIGhvbGVzIGFmdGVyIHRoZSBwMm0gaGFzIGJlZW4gc2V0
IHVwIG1pZ2h0IGJlIHJhY3kgZm9yDQo+PiAgICAgICogRG9tVSB1c2FnZSwgbmVlZHMgdG8gYmUg
cmV2aXNpdGVkLg0KPj4gICAgICAqLw0KPj4gKyNpZmRlZiBDT05GSUdfSEFTX1BDSV9NU0kNCj4+
ICAgICBpZiAoIG1hcCAmJiAhcm9tX29ubHkgJiYgdnBjaV9tYWtlX21zaXhfaG9sZShwZGV2KSAp
DQo+PiAgICAgICAgIHJldHVybjsNCj4+ICsjZW5kaWYNCj4gDQo+IEZXSVcsIEkgd291bGQgYWxz
byBiZSBmaW5lIHdpdGggcHJvdmlkaW5nIGEgZHVtbXkgaW5saW5lIGZ1bmN0aW9uIGZvcg0KPiB2
cGNpX21ha2VfbXNpeF9ob2xlIHdoZW4gIUNPTkZJR19IQVNfUENJX01TSSwgYnV0IEkgYXNzdW1l
IHRoaXMgaXMgYQ0KPiB0ZW1wb3Jhcnkgd29ya2Fyb3VuZCB1bnRpbCBNU0kgaXMgaW1wbGVtZW50
ZWQgZm9yIEFybS4NCg0KWWVzIHRoaXMgaXMgdGVtcG9yYXJ5IGFuZCBNU0kgc3VwcG9ydCB3aWxs
IGJlIGFkZGVkIG9uIEFybS4NCg0KUmVnYXJkcw0KQmVydHJhbmQNCg0KPiANCj4gVGhhbmtzLCBS
b2dlci4NCg0K


From xen-devel-bounces@lists.xenproject.org Mon Oct 11 12:36:39 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 12:36:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.205942.361373 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZuXg-0007eB-Pn; Mon, 11 Oct 2021 12:36:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 205942.361373; Mon, 11 Oct 2021 12:36:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZuXg-0007e4-MP; Mon, 11 Oct 2021 12:36:32 +0000
Received: by outflank-mailman (input) for mailman id 205942;
 Mon, 11 Oct 2021 12:36:31 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=obo4=O7=gmail.com=olekstysh@srs-us1.protection.inumbo.net>)
 id 1mZuXf-0007dx-C3
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 12:36:31 +0000
Received: from mail-lf1-x12e.google.com (unknown [2a00:1450:4864:20::12e])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 5ba118ec-415d-456f-beab-1e62c217275d;
 Mon, 11 Oct 2021 12:36:30 +0000 (UTC)
Received: by mail-lf1-x12e.google.com with SMTP id r19so70945917lfe.10
 for <xen-devel@lists.xenproject.org>; Mon, 11 Oct 2021 05:36:30 -0700 (PDT)
Received: from [192.168.1.7] ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id w16sm721944lfq.272.2021.10.11.05.36.25
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Mon, 11 Oct 2021 05:36:25 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5ba118ec-415d-456f-beab-1e62c217275d
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-transfer-encoding:content-language;
        bh=fUGu/UwFqbU9uXC3nxwSHkYP0fxyfms+M5VnCYuMyUE=;
        b=Ff1vfBxJbp5Tk53te1JsxAzlw4ImXswyXr50Om0/eYuYkAEvY6Q6d7/vs4fB6Ig+QB
         xwbbG3eHJizq6hxx2VM7TjcmPJszMlV470QahuCF0VUujIWr3i1kSLunuoBHf7TH/YeH
         0zWjDpBciTWfU6jO+X7E0PUgxjRFEPilAACZKDDU5WLh2dbPBV92a1R3APv+diOzAp/9
         kDk2diYIHDYwVvUcNkkvozlqvdFrWUKxpkb5RSA2j1RxXG3/VUiAAzZ2y9TljxhXy1U5
         9CmbRIlTjMptsaBthWbAjAw++Z+WlM9Bs4bPrEi5KNpVAAO7F3q4kMBqbL/Gzs01lwkS
         goUQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding
         :content-language;
        bh=fUGu/UwFqbU9uXC3nxwSHkYP0fxyfms+M5VnCYuMyUE=;
        b=VANsNv4EaGcGzvOcbMFWD4LHeFfFUw5MX67c8S6fSRKim+lvg7uNFYjxmplWifJ7fp
         Mknb6Az0JZzlRpi87EjdtgiCkwymf6A4pP1WNSIO0tMqpKERTncCZ6T6SwbzccWAOnbf
         tvn6IvhXv7/NVCfGpJfVxvlTYrsbIJ3pHR1FrL6g46g+Er3Yj+6bnULPVdvDlRYMN4gc
         sgZ4nK+mR0Kp81g4R1NMxSmaQVkA5g4xJOljgRccPioXDQDsvIHxlydIXm7AFL5JhYR+
         XTbC+VlqVY2gKEC9aBgRXKxgR5z4+s2JBrDDgVBMzYVQ42qiCLkXutEF8/yrLa1R6U3P
         /c3w==
X-Gm-Message-State: AOAM531y+W8y6y83Kof5LSoKQetnMH9xwkar2ejwEoU0CgNEmyxADbKU
	8IUzdwXc0ZI4Rj9iRlaEteRR5MPC970=
X-Google-Smtp-Source: ABdhPJzZhcvYaJQTLm5SNWSK8YuHQlY2tA+oij0bJhA8o6Ff4aiwa9e6uhXUU7at6+j6+2tlX6DMvw==
X-Received: by 2002:a05:6512:2143:: with SMTP id s3mr3408387lfr.451.1633955786183;
        Mon, 11 Oct 2021 05:36:26 -0700 (PDT)
Subject: Re: [PATCH V5 1/3] xen/arm: Introduce gpaddr_bits field to struct
 xen_arch_domainconfig
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: Jan Beulich <jbeulich@suse.com>,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>,
 Anthony PERARD <anthony.perard@citrix.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Juergen Gross <jgross@suse.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 xen-devel@lists.xenproject.org
References: <1633519346-3686-1-git-send-email-olekstysh@gmail.com>
 <1633519346-3686-2-git-send-email-olekstysh@gmail.com>
 <68cb29bb-7d84-dc27-eead-4a079b9caf68@suse.com>
 <e77eea6f-163d-0920-2e90-fb9f3a602743@gmail.com>
 <ffb40f3b-2394-7747-2c06-955e2aa87cfc@suse.com>
 <387608b9-c7b2-e814-7fa5-a262acc0c73d@gmail.com>
 <ae852345-66ff-7bcf-f68e-2161e23933a1@suse.com>
 <alpine.DEB.2.21.2110071311450.414@sstabellini-ThinkPad-T480s>
 <b8e868a2-9af3-de6c-0683-4bb2ff7821f3@suse.com>
 <b36e5fb7-6ed0-dc7d-5ed3-c3c9c9ae70b5@gmail.com>
 <ff760c65-1041-aac6-40ed-981f0b900678@suse.com>
 <2fcb101c-28b0-67c5-0f4d-e3d75b9f4d33@gmail.com>
 <alpine.DEB.2.21.2110081458120.25528@sstabellini-ThinkPad-T480s>
From: Oleksandr <olekstysh@gmail.com>
Message-ID: <21e649ef-a081-14c3-b68e-ffdec03e0f28@gmail.com>
Date: Mon, 11 Oct 2021 15:36:24 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.21.2110081458120.25528@sstabellini-ThinkPad-T480s>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US


On 09.10.21 01:14, Stefano Stabellini wrote:

Hi Stefano

> On Fri, 8 Oct 2021, Oleksandr wrote:
>> On 08.10.21 15:36, Jan Beulich wrote:
>>> On 08.10.2021 12:25, Oleksandr wrote:
>>>> Just a quick question. What do you think can XEN_DOMCTL_getdomaininfo be
>>>> reused to retrieve gpaddr_bits? I don't see why not at the moment, but
>>>> maybe there are some implications/concerns which are invisible to me.
>>>>
>>>> I see that arch_get_domain_info() is present, so the field will be
>>>> common, and each arch will write a value it considers
>>>> appropriate. This could be a good compromise to not add an extra domctl
>>>> and to not alter domain_create.
>>> Technically I think it could be reused. What I'm less certain of is
>>> whether the specific piece of information is a good fit there.
>> ok, thank you for your answer.
>>
>> I am also not 100% sure whether it is a *good* fit there, but I cannot say it
>> is not fit at all for being there. I might mistake, but it is almost the same
>> piece of information describing the whole domain as other existing fields in
>> that structure.
>  From a domctl point of view, it looks like XEN_DOMCTL_getdomaininfo
> could be a decent fit. Looking at the data structure, the arch specific
> member of struct xen_domctl_getdomaininfo is:
>
>    struct xen_arch_domainconfig arch_config;
>
> which is actually the very same struct used in struct
> xen_domctl_createdomain for XEN_DOMCTL_createdomain, but somehow it
> doesn't get populated by neither the x86 nor the ARM version of
> arch_get_domain_info?
>
>
> In any case, I think we could make use of XEN_DOMCTL_getdomaininfo for
> this. In that case, I would add a new common field to struct
> xen_domctl_getdomaininfo after cpupool and above arch_config.
>
> Then we can set the field from arch_get_domain_info.

Yes, this is what I had in mind, thank you.


-- 
Regards,

Oleksandr Tyshchenko



From xen-devel-bounces@lists.xenproject.org Mon Oct 11 12:39:35 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 12:39:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.205949.361384 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZuad-0008HV-8p; Mon, 11 Oct 2021 12:39:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 205949.361384; Mon, 11 Oct 2021 12:39:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZuad-0008HO-4r; Mon, 11 Oct 2021 12:39:35 +0000
Received: by outflank-mailman (input) for mailman id 205949;
 Mon, 11 Oct 2021 12:39:34 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=9TNE=O7=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mZuab-0008HE-W8
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 12:39:34 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 485ef178-2a90-11ec-80d8-12813bfff9fa;
 Mon, 11 Oct 2021 12:39:32 +0000 (UTC)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2170.outbound.protection.outlook.com [104.47.17.170])
 (Using TLS) by relay.mimecast.com with ESMTP id
 de-mta-19-KpusYZ9MNa608_1NVqIxBw-1; Mon, 11 Oct 2021 14:39:30 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB7087.eurprd04.prod.outlook.com (2603:10a6:800:12a::15)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.19; Mon, 11 Oct
 2021 12:39:29 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4587.026; Mon, 11 Oct 2021
 12:39:29 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS9PR06CA0402.eurprd06.prod.outlook.com (2603:10a6:20b:461::20) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18 via Frontend
 Transport; Mon, 11 Oct 2021 12:39:28 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 485ef178-2a90-11ec-80d8-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1633955971;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=y1HE2dfvuc9CnkzlTDnzsaV1VIoHjmm/8odqNlvgVSA=;
	b=iVfidurT6SvHT+z32Sw8WS1tFB94ItTYWcSAuMlh1f92qKf673gSBeAWWBC2ECQUIRqAPr
	D0P1enbjybj2ifn8Hi3u1/3Hv6H05NREkx6bL+lusrvLodG7OOWwMt9F9Cob3CwfJdjoCS
	IaUIPkmUkIAnSEYe+T/nGENDvtj0k+c=
X-MC-Unique: KpusYZ9MNa608_1NVqIxBw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=edBC4DTLqXIkjam25ZFRKbElzIIVHmfJ9ltTRUcVWfXzKIpFWVUA9xnPUNbrcSTcFNLwf8OdbiO1PqvV/fduH57kg9X/Qov5G6bjSweYi+kIpfFWeHi0zFPMm24Oa7oUOKoBHijP5mY7dqsT+zGR8hapnfRz5ZT7OwZEBUMjzK8Cfl8MhKrXNVAcWrsOYr1G0tF9oLbiEpF/HSGSfBlFe70P0/u+ObtMYJzTgyIm8t29dsiSbnSv85D/E/xVmkHNWVXAnsyfofpLUoK9RIg+dCUu19JK/oztRKqv9Y4yD6xzcmJskeJS6JaSxBP84ANrXFGSpgnDcJj4PXxP3ipRHw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=y1HE2dfvuc9CnkzlTDnzsaV1VIoHjmm/8odqNlvgVSA=;
 b=A6503ZaQCsBYMF6+8zlcQVwoeJGOAWIrq4JFQtzkeuDNsxaBhxDwFGKvDLkgAPWfB8jfjcfLD/gERdN13BPub9kPplp+iKUNocwEdbuUeS+ab/pFcxrurzxLos7NJGO4a0Pj091qMqeekho8m/IlSVh07am7Nj+rFVHWbO7IxIvH+o/tans/zWwOhcodBGpFdOpgjI/BQI0BAuWjkls+ovUAVJYMulWNsm5rE5LV14KNZ2CponId4N7dxe+zZS/vIpC4D61SkLf2OTPrVicIrIa/jhWBgydW+buQ0G1LAvUqFVHn878EDg27Abk2F/J+dmbC31UADbPS+7yiGfiSrQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [XEN PATCH v7 24/51] build: prepare to always invoke $(MAKE) from
 xen/, use $(obj)
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Daniel De Graaf <dgdegra@tycho.nsa.gov>,
 "Daniel P. Smith" <dpsmith@apertussolutions.com>,
 xen-devel@lists.xenproject.org
References: <20210824105038.1257926-1-anthony.perard@citrix.com>
 <20210824105038.1257926-25-anthony.perard@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <430f6b64-e255-1250-1afb-a596a57ed1a9@suse.com>
Date: Mon, 11 Oct 2021 14:39:26 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <20210824105038.1257926-25-anthony.perard@citrix.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0402.eurprd06.prod.outlook.com
 (2603:10a6:20b:461::20) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: b3e3f039-cef3-421c-8c1e-08d98cb42ae4
X-MS-TrafficTypeDiagnostic: VI1PR04MB7087:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB7087940E5A36C646FC6701C4B3B59@VI1PR04MB7087.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:5236;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	D74YEXgGbRZ6/xHCQo2SFUEW8VoOeCIlbLyb3/b1A/9/KJBT1OlHnUmkbCpdpuO5CtxrU1bEaeJBZf68GPev1rLQDfDRPLDOd49ISgFcyb8ql5cgk/N7Dj5lEaqXBZftzwP2GAj2fJeai4jv3SQ9gv0JzofBAmHlRhQOTYWE/9axuMGgaGbd7EY8rGWhC/haKuP3+0SWVawAI2LsVOgJDA7ZfCUboBiopZBR6+CggHZqbgJt2bR3CRbK+Fa0dTkq7GGTT+oIkM1PAKcVgQ6V7mMEjq4ec5CzkLM7KRyIZSpTK36MVTGuLyVdAaQCdlCUtZQ9buu8yvLp7lNsmwdoFsDOSzpMRvBqArc4uznt5bp2O4s+L7USHvpA4DUjogvLu57w7cKZdkOCKqEczkR0rPSscuEudykkr2a/ArCGSwKYOnuajLbFXVA6KURHHU36RCtbYypck8oUaLi3t183ngMwpqB4vTHXru15UDFwjTp2VXS+5AgVT1sYx+KTrEFPf0pldYo6qbLsLPAyCiUbnikyXs2ORwYFG2Gzkp848q1F3XwcHuLPSJKn7Fzoju/2VjoXZyzvlvaZEkEnqLYoetGO7meeKUOW2IeK9tnNSYb162g/O3KItB2XpNVlgg/N3KF+sVIE0uluKM8JZil3jvPDNZGF42e3BfUzeDHnFIh/ae6d9ek1aliTZP8SvJ53bg8LEzSfh/yQMncWUph3Y7LecG1NMVyjJJvLGQMhmPAC8Eec9IgBZavM8UqCJvUK
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(8936002)(8676002)(53546011)(4326008)(5660300002)(31686004)(6486002)(36756003)(26005)(86362001)(186003)(316002)(16576012)(38100700002)(31696002)(7416002)(6916009)(66556008)(66476007)(956004)(2616005)(66946007)(54906003)(2906002)(508600001)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?VktSMVBHenJwTXdkU0dXdHdzU3RteVZnL21zbUYzdjNJbnQxckVwWFNSWUVH?=
 =?utf-8?B?K0QrNS9sdDZGeEZ4bW9wem5CalBUUzB0ZHlZdyt0NktMNFRmektpYXNSbkZt?=
 =?utf-8?B?amJMVXFsUXppT1BLZE9jVGFsWVh6c00vU0wydlAxTnZnZkdnZzFRS09Ka0F1?=
 =?utf-8?B?MGhNajlqeU5vczlISXI5Zld0NllaTmdJRDV0MFp2U2ZKVGNFU0U0ZndrV0t3?=
 =?utf-8?B?K3VFWTI1S3BHdko0TnIwcTUzMTd4eUloVitleWlaZVJwUS9UUktlT1BUZUc4?=
 =?utf-8?B?cDZReUE3MytiK3hqU0VxeFk2SW9jZW9vNXEwcWdTSk84RXowVE5xbmZzbXhs?=
 =?utf-8?B?YVZwSldsYVoxUVVrSjdXL0NNOWFENVd4ZVZNQ2tKTGJtcmdoRDdaSmNPZnRu?=
 =?utf-8?B?MW5YdWxRSFZDY0p1NzREK3ZhN3pBR0VEcEFTUkdSNTlEaWJzZkRaSDlUZGFN?=
 =?utf-8?B?aHZHVEd1YVVWbFJzQVBIUElsc3BYTVVRYnZEOFk2cTI1Umx1dUdWUGlYTEdV?=
 =?utf-8?B?U1hrcUpxSGkwZnBaMVgydjZYL1FjNityTmFRKzhBZEFrYkRjL2t5d2FtZEMv?=
 =?utf-8?B?VTN1djdHUm16VDdFR1A2UnhpcHhqSUMyRUwxbWtXZ2JnL05EWktMcEZ0ZVFp?=
 =?utf-8?B?dStEeGxlSEh2eGRwM25KcnV2b1FYMTQyOUlaVHB4UzZGYitYbzZtbUZseWRu?=
 =?utf-8?B?VktoNVc1cnQ5ODJsNGxBeUxpU0dmVUMwL284djgxaVFwUGZhY0F4TWk5dklU?=
 =?utf-8?B?U2FRM242UzhjdHpwa1ZuRXpodVIxa2xlMkRIZWU4T0VYeUF6K0lsTkhtak5i?=
 =?utf-8?B?NjdLN1NublZqQ2pIRlJDM2p5cVZvQ0p2N0lyOGg1L04wS0dpTkdoSUNpSEpp?=
 =?utf-8?B?bVRNVWdwcllSdThtVXhvNmdXSVc2Qkt4U1JER25CUzFjMER5N0NFZTlEMVNN?=
 =?utf-8?B?aytlU2JzelMyZkZxZXlxSUJ3L3RISnEyQXllb3lSNFNOb04xV0FEVUd1Ykdy?=
 =?utf-8?B?cUhmZ1A5WU1XcHZhQXBMMGE0K0sveXpCc1hGdTlyUzkwb3hpUHVBYms0ZEFo?=
 =?utf-8?B?SXdWRERWKzdIUXdHVEd4OE80Vlk3K2JHdExpdWJ0VWxHcnhZYzJCdFBTY2l4?=
 =?utf-8?B?SGhuNG5ORjF4cUMrOTdLT2hzRXRGRzhjSmhVbUk5ZjFKdHVNTEdBak9zMUZ2?=
 =?utf-8?B?VTRoTzJmakd0YU8rVkxvTnlSeCtGRGNiYi9hakIrcWRGYS9KUzk3QVdGSFV0?=
 =?utf-8?B?VndKSHJJR2tkNjlJc0tPUDJWWENYRWFUblN6WkdObXVMVFlJc3l3NTFhNXlC?=
 =?utf-8?B?QXF1SU5kZFNMQk1wTlhyd0pkNnpVV0toeDI1WlhJcVp5b2RiT3F5UzhtckpQ?=
 =?utf-8?B?WWhSS1hmbHFJQkp5Ulo0b3NmTW9IMFo1NnpCSy9xZlQ3dkpuSTJSeUJmS003?=
 =?utf-8?B?VnhMb0dlZm1NUkNxQlEwc1d3UlVjMWRsQTI5SmppYU90SUNwOFVUVWVLR0ZZ?=
 =?utf-8?B?NE5kblp4U1ZzWDVna2N0WThYbGxyY25acWorOThvMjlJOWZ4NktqVktsczVo?=
 =?utf-8?B?VGl1V2NMS1ZhVkR0R1ZqZnEwQXFYSUVuVzB1QWpMYXpNWHcwRkJBRlo1Qys4?=
 =?utf-8?B?eVNkSXJhYTZBQ0VvNkdVaWJ5MFJOSlFTUGFlNjdpVGJVRTBSdHExY0hJckFD?=
 =?utf-8?B?bnVaak5hZFcwZG9TNGVpLzZDaFlZU2pBSjc2bjBlc1hHUGR1NHJJcU1jU002?=
 =?utf-8?Q?eCQI+5mGQLtpaK7mfoTMO0ug7c6F/ragcYoVLsC?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b3e3f039-cef3-421c-8c1e-08d98cb42ae4
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2021 12:39:29.2668
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: pOrLABIs63/biHMQ0pLIl/S58Sq1nb41+Qw+1d+Ra8wFSgbyzRK8NVB+wnspx9j8mSxAOXj58pPHD3JeGLAerw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7087

On 24.08.2021 12:50, Anthony PERARD wrote:
> In a future patch, when building a subdirectory, we will set
> "obj=$subdir" rather than change directory.
> 
> Before that, we add "$(obj)" and "$(src)" in as many places as
> possible where we will need to know which subdirectory is been built.
> "$(obj)" is for files been generated during the build, and "$(src)" is
> for files present in the source tree.
> 
> For now, we set both to "." in Rules.mk and Makefile.clean.
> 
> A few places don't tolerate the addition of "./", this is because make
> remove the leading "./" in targets and dependencies in rules, so these
> will be change later.
> 
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>

Acked-by: Jan Beulich <jbeulich@suse.com>

Nevertheless a couple of remarks:

> --- a/xen/arch/x86/Makefile
> +++ b/xen/arch/x86/Makefile
>[...]
> @@ -192,25 +192,25 @@ note_file_option ?= $(note_file)
>  
>  ifeq ($(XEN_BUILD_PE),y)
>  extra-y += efi.lds

What about this? Does this for some reason also fall into the "cannot
be converted yet" group?

> @@ -222,14 +222,14 @@ $(TARGET).efi: FORCE
>  endif
>  
>  # These should already have been rebuilt when building the prerequisite of "prelink.o"
> -efi/buildid.o efi/relocs-dummy.o: ;
> +$(obj)/efi/buildid.o $(obj)/efi/relocs-dummy.o: ;
>  
>  .PHONY: include
>  include: $(BASEDIR)/arch/x86/include/asm/asm-macros.h
>  
> -asm-macros.i: CFLAGS-y += -D__ASSEMBLY__ -P
> +$(obj)/asm-macros.i: CFLAGS-y += -D__ASSEMBLY__ -P
>  
> -$(BASEDIR)/arch/x86/include/asm/asm-macros.h: asm-macros.i Makefile
> +$(BASEDIR)/arch/x86/include/asm/asm-macros.h: $(obj)/asm-macros.i $(src)/Makefile

Isn't this $(obj)/include/asm/asm-macros.h ? And in general doesn't
use of $(BASEDIR) need to go away then, e.g. ...

> --- a/xen/arch/x86/boot/Makefile
> +++ b/xen/arch/x86/boot/Makefile
> @@ -1,8 +1,8 @@
>  obj-bin-y += head.o
>  
> -DEFS_H_DEPS = defs.h $(BASEDIR)/include/xen/stdbool.h
> +DEFS_H_DEPS = $(src)/defs.h $(BASEDIR)/include/xen/stdbool.h

... here needing to become $(src)/../../../include/xen/stdbool.h ?

> --- a/xen/scripts/Makefile.clean
> +++ b/xen/scripts/Makefile.clean
> @@ -3,11 +3,14 @@
>  # Cleaning up
>  # ==========================================================================
>  
> +obj := .
> +src := $(obj)

This repeats what is also getting added to Rules.mk. To prevent
the two going out of sync, wouldn't they better live in a central
place (e.g. scripts/defs.mk)?

Jan



From xen-devel-bounces@lists.xenproject.org Mon Oct 11 12:42:03 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 12:42:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.205956.361395 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZucq-0001EM-LJ; Mon, 11 Oct 2021 12:41:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 205956.361395; Mon, 11 Oct 2021 12:41:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZucq-0001EF-II; Mon, 11 Oct 2021 12:41:52 +0000
Received: by outflank-mailman (input) for mailman id 205956;
 Mon, 11 Oct 2021 12:41:51 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=LfEM=O7=arm.com=Bertrand.Marquis@srs-us1.protection.inumbo.net>)
 id 1mZucp-0001E5-Do
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 12:41:51 +0000
Received: from EUR02-AM5-obe.outbound.protection.outlook.com (unknown
 [2a01:111:f400:fe07::602])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id d82b6682-108f-4515-8de6-3dda174a9594;
 Mon, 11 Oct 2021 12:41:48 +0000 (UTC)
Received: from AS8PR04CA0161.eurprd04.prod.outlook.com (2603:10a6:20b:331::16)
 by VI1PR0801MB1663.eurprd08.prod.outlook.com (2603:10a6:800:4f::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18; Mon, 11 Oct
 2021 12:41:45 +0000
Received: from AM5EUR03FT034.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:331:cafe::4b) by AS8PR04CA0161.outlook.office365.com
 (2603:10a6:20b:331::16) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18 via Frontend
 Transport; Mon, 11 Oct 2021 12:41:45 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM5EUR03FT034.mail.protection.outlook.com (10.152.16.81) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4587.18 via Frontend Transport; Mon, 11 Oct 2021 12:41:44 +0000
Received: ("Tessian outbound d5def7722ff7:v103");
 Mon, 11 Oct 2021 12:41:44 +0000
Received: from 8e8e42cdf8af.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 6E2B90D5-46DC-4EC3-B908-9D17522E5BC7.1; 
 Mon, 11 Oct 2021 12:41:33 +0000
Received: from EUR03-VE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 8e8e42cdf8af.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Mon, 11 Oct 2021 12:41:33 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com (2603:10a6:4:74::9)
 by DBAPR08MB5832.eurprd08.prod.outlook.com (2603:10a6:10:1a5::15) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.22; Mon, 11 Oct
 2021 12:41:30 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955]) by DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955%4]) with mapi id 15.20.4587.026; Mon, 11 Oct 2021
 12:41:30 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d82b6682-108f-4515-8de6-3dda174a9594
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Pas7wanzOWdLkJJRO2bX6dTrl+auxLuxjm9/mAWY2AI=;
 b=yqCc+gh+pGkhJSG0wrbJp9Ce8TzrM8FUYG4Nq4C5z8T/Axm97dBCems8n6Z/gwX2ouHnLVreVM5A39Ei5Q2CJom7t5LNCEnspDsXe2Ua4yRCSU/cqtLycO7/ntsRmYbxmSN2wvckGAeI9E7EmKohyj5vb1EVeMQvcWwHtLSwQRE=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: b3ac9554b71b5cb3
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=KHxNgy42B1TRja1J8CqhXOhXpBmtpf/x3AaFgxIqX0ASuP3rPSfl4gU4AbonuZ07hil0xMSxm6k5SLGMbKexLYnZjZJ7k1j1uNJA4JNk9aETmRjkSJQxrutbdJwYnwmP4pL+rlWAQMqUWHb4Ok+aXzNfTIto/hPgHlxi8GtJRcQkTtU0OoOBCE3Km1srvUUN/Jmo1iPM5pv6xgPP/C1L5UyEA1WOqDaJTtmpsS9ovzhJhXBRwXWb3+38O8hj3FX+MunQsz5oD/VTme9irLi+oiwBkywV3QKG+D9XnKD+U16J2gvxKx4V54CPzOLFzSEw+J6esoF5w4SbA0/moXmZUA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Pas7wanzOWdLkJJRO2bX6dTrl+auxLuxjm9/mAWY2AI=;
 b=ix39XUzENaU5HRTdOX6Rjcch+64ScgzvaxlcooGBUrT7Tf2bNLLb/FEUCvHg1jvJsDzSeR6IEFKi/Qu+2adZ7EaxTCwlzcaqxlV7BIEzN+/0AaecvoRoiJTFQSvy4I1Akpi5yXEOHoi95lVmqoiMzsHJ6Jo6s3s+x8ra0qtw5Q2abDeiMGuSfiVz46xkO7p4/elW6e4/Heta8o/suP4ihootU7jq9mKkbwZ7UPRqcSa8sCpSWpD4rdV81KqHh8H+Zbf+FztIzrD3zYlDsDfpWOJPWyk9EV12mE5OQ+JJ8lkg45VxcaGAhkHV3cgaLW41i6aVAPilUwnTRAswoVMJvA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Pas7wanzOWdLkJJRO2bX6dTrl+auxLuxjm9/mAWY2AI=;
 b=yqCc+gh+pGkhJSG0wrbJp9Ce8TzrM8FUYG4Nq4C5z8T/Axm97dBCems8n6Z/gwX2ouHnLVreVM5A39Ei5Q2CJom7t5LNCEnspDsXe2Ua4yRCSU/cqtLycO7/ntsRmYbxmSN2wvckGAeI9E7EmKohyj5vb1EVeMQvcWwHtLSwQRE=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Rahul Singh <Rahul.Singh@arm.com>, Andre Przywara
	<Andre.Przywara@arm.com>, Stefano Stabellini <sstabellini@kernel.org>, Julien
 Grall <julien@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>, George Dunlap
	<george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>, Wei Liu
	<wl@xen.org>, Paul Durrant <paul@xen.org>, =?iso-8859-1?Q?Roger_Pau_Monn=E9?=
	<roger.pau@citrix.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v5 08/11] xen/arm: Enable the existing x86 virtual PCI
 support for ARM.
Thread-Topic: [PATCH v5 08/11] xen/arm: Enable the existing x86 virtual PCI
 support for ARM.
Thread-Index: AQHXutl3YqS5dHXsYk6KpdKt4d14RavHjPqAgAY38oA=
Date: Mon, 11 Oct 2021 12:41:30 +0000
Message-ID: <CEF7FFB0-779A-4F46-8667-6BCD9BA5CB6C@arm.com>
References: <cover.1633540842.git.rahul.singh@arm.com>
 <9bdca2cda5d2e83f94dc2423e55714273539760a.1633540842.git.rahul.singh@arm.com>
 <6752f2d3-171b-37f5-c809-82995a8f3f36@suse.com>
In-Reply-To: <6752f2d3-171b-37f5-c809-82995a8f3f36@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3654.120.0.1.13)
Authentication-Results-Original: suse.com; dkim=none (message not signed)
 header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: 0ce31bb4-4051-4f92-c37b-08d98cb47ba2
x-ms-traffictypediagnostic: DBAPR08MB5832:|VI1PR0801MB1663:
x-ms-exchange-transport-forked: True
X-Microsoft-Antispam-PRVS:
	<VI1PR0801MB1663E3967D6BC8A85975DFE39DB59@VI1PR0801MB1663.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:10000;OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 3aYRDzxnAvBX5LK31VO2yTHR9OjvfXxqGsOXx8qc52Ujd7uVKjl/eR4HVbJ1OvtFI3tJg4CyU/vVZuwP0pWDp4FD4f71+h2DXHnAMHNqolAxopUp8nA+BvfSWb6eSDolrLDSqNHDB4Q5yGroK70gmJ4wmPzxCgTTORxIAMpw+biTx97CFUZ6cECtvkucX3jeHS/q+Cfus9Q81wOl7E4XmEa4sRXG3AVMJ7V5zOYX+1rGndnNEfW41pQ1mqr3XecilA5LlZ6jAYgsuvHi2/Oy3j4YBqTFJEEQ9YqlrhgrO4kysdPaiB1SxkSNtmcazJ21DL7cyh5kbjT+uTWu0ewUjlUiOFMMa9PsYTkoRWxzLIJ0D5W19h8DvwRGtJAlm4SanydK4ziEZ7g1weBnJptUbpuRtZeIjdv0v90ewFuP0StgEm8N2yV6cmkeXHBR4T6WlanffrEA79TDKA+9i19NwEkT0/QRfrG+wXzrA+lmMVn9OuV7ih3dtq7bC5dhrsUlOwylK5dbVoNJQMw/X3M/CNpxql2n08EBJPU9rZYN/jiPwkzDP1jiB8rmmzWbS6P7brp2DIh2YBPZfSv+Txjz6QHr2/RbImFjt8wo6UI44H9gpww/Xq3GyAltSq/T0GPZBXX6z60cAa021zDpMsso9RMjD7ZzYlfB5YKVf65Lu1hY9bpiSiFbItc7hMIH+9JWmuewIbq2S0NBpj7ezU9WYkRVpjMy6lyW3yfAP/FRZBYKXkmh2RqhQOCEXjzkjtGTbR+Xrp9SJzUaBgUZwiHWMQ==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB6PR0801MB2024.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(76116006)(66446008)(91956017)(64756008)(38100700002)(316002)(508600001)(4326008)(66556008)(66476007)(66946007)(122000001)(53546011)(6506007)(2906002)(186003)(7416002)(38070700005)(26005)(83380400001)(6916009)(5660300002)(36756003)(8936002)(71200400001)(2616005)(8676002)(86362001)(6486002)(6512007)(54906003)(33656002)(2004002)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="iso-8859-1"
Content-ID: <FD5E6E889E2A7548942C2A042BB89A9F@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR08MB5832
Original-Authentication-Results: suse.com; dkim=none (message not signed)
 header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM5EUR03FT034.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	fc49a065-6f41-4f76-b60f-08d98cb47343
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	WDDeGKjDaUv7oWxup+NEW+sYBSJSqtey1MCyvHRtcaJVasb3IuFGoixWyEOGGCikqAhvz+C6Iz6eTJe/kLe0fU+vFCu3SYAYyWF/7g7A1gWheq6GVZZz+YQEU55hzFHRmQeKeqdVjISOR5IvD6U3sxdYmc6jcF3gnPNXfkKY6txJJaFQpUj9KY2D3wkxodbJqr1yXgu7vAAet4o6t5NdZlDZyZoj+e/fo2NzvaWlUSQw+OspGmafIk1Y1ghsuRv8si7ekJlFWoFmzL5v0TRPUPhDE94/iM3F5mIScgv+mRhv8kITAn2J6NH4GpUuA/uTPkn0mArNiWnaCtNcZ21oAqlIVDw7KYMNsAi/pX5Qd/tczXSs4vRaOArXF9za+m1UyZgvvpA9qiEVpLuTRA3ALNKIVOA6uI7ubXJCGItZd5LD8FlQBsMxmUYxs9StAU16N8Fwg/IfEub91rSci6IfU5BymHvyWVxYmslY6L8NsadjISAjtF3F5wK9nV493z0AmzWex/VLdKx1mdiyHr6cOAC5uEHrMQTI3POD1+0Q4THGb9sPsOA2AqQ2AMbrtt1SOrJmOpfMR1k0QwGo96XkGpDMNPfSbR5wDvrzD5FL7+8MeCQoatkaGaaQarsOfdH/sYHbSKuNOZU0xmkuWA9dItAJiVuMrDHoXm+oI4SrKPe2uJCXQVdrWFjAuZTFN+QYdSqCfuWjtSa+Pj9AT52DuOh8pZAIiB0v5pcgAbjOH8M=
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(4326008)(8936002)(2906002)(47076005)(82310400003)(6512007)(33656002)(36756003)(316002)(6506007)(54906003)(86362001)(81166007)(336012)(53546011)(26005)(508600001)(6486002)(36860700001)(8676002)(5660300002)(2616005)(70586007)(83380400001)(356005)(70206006)(186003)(6862004)(2004002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2021 12:41:44.5203
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 0ce31bb4-4051-4f92-c37b-08d98cb47ba2
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM5EUR03FT034.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0801MB1663

Hi Jan,

As Rahul is on leave, I will answer you and make the changes needed.

> On 7 Oct 2021, at 14:43, Jan Beulich <jbeulich@suse.com> wrote:
>=20
> On 06.10.2021 19:40, Rahul Singh wrote:
>> --- /dev/null
>> +++ b/xen/arch/arm/vpci.c
>> @@ -0,0 +1,102 @@
>> +/*
>> + * xen/arch/arm/vpci.c
>> + *
>> + * This program is free software; you can redistribute it and/or modify
>> + * it under the terms of the GNU General Public License as published by
>> + * the Free Software Foundation; either version 2 of the License, or
>> + * (at your option) any later version.
>> + *
>> + * This program is distributed in the hope that it will be useful,
>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>> + * GNU General Public License for more details.
>> + */
>> +#include <xen/sched.h>
>> +
>> +#include <asm/mmio.h>
>> +
>> +#define REGISTER_OFFSET(addr)  ( (addr) & 0x00000fff)
>=20
> Nit: Stray blank (like you had in an earlier version for MMCFG_BDF()).
> Also isn't this effectively part of the public interface (along with
> MMCFG_BDF()), alongside GUEST_VPCI_ECAM_{BASE,SIZE}?

I will move that in the next version to xen/pci.h and rename it MMCFG_REG_O=
FFSET.
Would that be ok ?

>=20
>> +/* Do some sanity checks. */
>> +static bool vpci_mmio_access_allowed(unsigned int reg, unsigned int len=
)
>> +{
>> +    /* Check access size. */
>> +    if ( len > 8 )
>> +        return false;
>=20
> struct hsr_dabt's size field doesn't allow len to be above 8. I could
> see that you may want to sanity check things, but that's not helpful
> if done incompletely. Elsewhere you assume the value to be non-zero,
> and ...
>=20
>> +    /* Check that access is size aligned. */
>> +    if ( (reg & (len - 1)) )
>=20
> ... right here you assume the value to be a power of 2. While I'm not
> a maintainer, I'd still like to suggest consistency: Do all pertinent
> checks or none of them (relying on the caller).

I will remove the check for len > 8 as dabt.size cannot have a value
greater than 3.

But I will have to introduce a check for len > 4 on 32 bit systems (see aft=
er).

>=20
> Independent of this - is bare metal Arm enforcing this same
> alignment restriction (unconditionally)? Iirc on x86 we felt we'd
> better synthesize misaligned accesses.

Unaligned IO access could be synthesise also on arm to but I would
rather not make such a change now without testing it (and there is
also a question of it making sense).

So if it is ok with you I will keep that check and discuss it with Rahul
when he is back. I will add a comment in the code to make that clear.

>=20
>> +static int vpci_mmio_read(struct vcpu *v, mmio_info_t *info,
>> +                          register_t *r, void *p)
>> +{
>> +    unsigned int reg;
>> +    pci_sbdf_t sbdf;
>> +    unsigned long data =3D ~0UL;
>=20
> What use is this initializer? The error path further down doesn't
> forward the value into *r, and subsequently the value gets fully
> overwritten.

Right I will remove it.

>=20
>> +    unsigned int size =3D 1U << info->dabt.size;
>> +
>> +    sbdf.sbdf =3D MMCFG_BDF(info->gpa);
>=20
> This implies segment to be zero. While probably fine for now, I
> wonder if this wouldn't warrant a comment.

I will add the following comment just before:
/* We ignore segment part and always handle segment 0 */

>=20
>> +    reg =3D REGISTER_OFFSET(info->gpa);
>> +
>> +    if ( !vpci_mmio_access_allowed(reg, size) )
>> +        return 0;
>> +
>> +    data =3D vpci_read(sbdf, reg, min(4u, size));
>> +    if ( size =3D=3D 8 )
>> +        data |=3D (uint64_t)vpci_read(sbdf, reg + 4, 4) << 32;
>=20
> Throughout this series I haven't been able to spot where the HAS_VPCI
> Kconfig symbol would get selected. Hence I cannot tell whether all of
> this is Arm64-specific. Otherwise I wonder whether size 8 actually
> can occur on Arm32.

Dabt.size could be 3 even on ARM32 but we should not allow 64bit
access on mmio regions on arm32.

So I will surround this code with ifdef CONFIG_ARM_64 and add a test
for len > 4 to prevent this case on 32bit.

To be completely right we should disable this also for 32bit guests but
this change would be a bit more invasive.

>=20
>> +static int vpci_mmio_write(struct vcpu *v, mmio_info_t *info,
>> +                           register_t r, void *p)
>> +{
>> +    unsigned int reg;
>> +    pci_sbdf_t sbdf;
>> +    unsigned long data =3D r;
>=20
> A little like in the read function - what use is this local variable?
> Can't you use r directly?

We can and I will remove the data variable.

>=20
>> --- a/xen/drivers/passthrough/pci.c
>> +++ b/xen/drivers/passthrough/pci.c
>> @@ -766,6 +766,24 @@ int pci_add_device(u16 seg, u8 bus, u8 devfn,
>>     else
>>         iommu_enable_device(pdev);
>=20
> Please note the context above; ...
>=20
>> +#ifdef CONFIG_ARM
>> +    /*
>> +     * On ARM PCI devices discovery will be done by Dom0. Add vpci hand=
ler when
>> +     * Dom0 inform XEN to add the PCI devices in XEN.
>> +     */
>> +    ret =3D vpci_add_handlers(pdev);
>> +    if ( ret )
>> +    {
>> +        printk(XENLOG_ERR "setup of vPCI failed: %d\n", ret);
>> +        pci_cleanup_msi(pdev);
>> +        ret =3D iommu_remove_device(pdev);
>> +        if ( pdev->domain )
>> +            list_del(&pdev->domain_list);
>> +        free_pdev(pseg, pdev);
>=20
> ... you unconditionally undo the if() part of the earlier conditional;
> is there any guarantee that the other path can't ever be taken, now
> and forever? If it can't be taken now (which I think is the case as
> long as Dom0 wouldn't report the same device twice), then at least some
> precaution wants taking. Maybe moving your addition into that if()
> could be an option.
>=20
> Furthermore I continue to wonder whether this ordering is indeed
> preferable over doing software setup before hardware arrangements. This
> would address the above issue as well as long as vpci_add_handlers() is
> idempotent. And it would likely simplify error cleanup.

I agree with you so I will move this code block before iommu part.

But digging deeper into this, I would have 2 questions:

- msi_cleanup was done there after a request from Stefano, but is not
done in case or iommu error, is there an issue to solve here ?
Same could also go for the free_pdev ?

- cleanup code was exactly the same as pci_remove_device code.
Should the question about the path also be checked there ?

Regards
Bertrand


>=20
> Jan
>=20
>=20



From xen-devel-bounces@lists.xenproject.org Mon Oct 11 13:09:23 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 13:09:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.205969.361406 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZv3M-0003lS-Vj; Mon, 11 Oct 2021 13:09:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 205969.361406; Mon, 11 Oct 2021 13:09:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZv3M-0003lL-Qb; Mon, 11 Oct 2021 13:09:16 +0000
Received: by outflank-mailman (input) for mailman id 205969;
 Mon, 11 Oct 2021 13:09:15 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=9TNE=O7=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mZv3L-0003lF-IF
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 13:09:15 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 2cd2b8b5-b76d-47d6-bcd9-ce18d1ab05c6;
 Mon, 11 Oct 2021 13:09:14 +0000 (UTC)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2054.outbound.protection.outlook.com [104.47.12.54]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-24-b_DOIOJCPyK2x-N1vah8lg-1; Mon, 11 Oct 2021 15:09:12 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB4191.eurprd04.prod.outlook.com (2603:10a6:803:45::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.20; Mon, 11 Oct
 2021 13:09:10 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4587.026; Mon, 11 Oct 2021
 13:09:10 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM5PR0601CA0058.eurprd06.prod.outlook.com (2603:10a6:206::23) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4587.25 via Frontend Transport; Mon, 11 Oct 2021 13:09:09 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2cd2b8b5-b76d-47d6-bcd9-ce18d1ab05c6
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1633957753;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=Kwg6JW8ZFQFAQGuD8NHuC30RImUViY+JB18LDSX1Blk=;
	b=FttYGkzZL8jV9/d8C5UBvoASOSyJ1XFzBfgUaoxbJLPKU+yCvIf3atvmrjpHCZwoYrczXW
	h4YU+y1/QbpBaknYV0yshlYWSLaBjmLZ4JqLPRYoNVnqzMGoNi2oUdg89DSjY75WtpMMSM
	VH4JY24cy7taBGCEDJ43F3LWEK35H5s=
X-MC-Unique: b_DOIOJCPyK2x-N1vah8lg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=AQVyQ/5xlBZQ2rvxEqRNNzV5ARQNYxU1Lsalzn4RQiI+w91p6+t+nwyMwnvdySEm0NZBqHmYzmTj2s3vcsdfRYWT5wz5mImn6OZjzOXTl9/kT3I/tDg7mQiseDlWJ600FHupHTt1jjCyv8qglkhLuSymzfZAGV0BOTsHcUM1tbg2dIP9LAH80/zOCrydJ6sCSvarzH8WDryVOI74KIgYN0JZ/NVG4Fop6StofkzLi1OWjgd8MrL9XlYgO5udc7zXAnHMC4KPxeyRLLpAr45iVWPMwz5dMS+yEUKFNo7vLDkMpecOofCWPvw6CfAhvMYufz3CkI0DIgl6PNm36Mu9bg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Kwg6JW8ZFQFAQGuD8NHuC30RImUViY+JB18LDSX1Blk=;
 b=NvOsTdnPMEc6PQG233UKQ8s9thdJR6ki2T9dmGLyk/pdPVQQgYZfFgKZqdW0PnzwbMmO4hFXeRXMGQhUIyvpAbST4DCB+Q2/mFDCHLoFZvoLKELdG5MVrX/7j3hIE87EQYQ3vbLqdoLpFto8CYMt74H5D+emsOuqhM//ODfRHG5j365n5H8o3gOWlXNOhCtnis3Su7Dzjz6hYmXSqhaTztzr3GHCoyX5XxaHlILGNzscc9vcNjh4d5jQUxQXItdMIEvGSrkwdi3MGGz8QXdj2AS8rncGn8TREyCBVr/BzFkkh2utJcjPA3irNtnRevzgQnAMsRbikkD+8golgJTM3Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [PATCH v5 08/11] xen/arm: Enable the existing x86 virtual PCI
 support for ARM.
To: Bertrand Marquis <Bertrand.Marquis@arm.com>
Cc: Rahul Singh <Rahul.Singh@arm.com>, Andre Przywara
 <Andre.Przywara@arm.com>, Stefano Stabellini <sstabellini@kernel.org>,
 Julien Grall <julien@xen.org>, Volodymyr Babchuk
 <Volodymyr_Babchuk@epam.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Wei Liu <wl@xen.org>, Paul Durrant <paul@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <cover.1633540842.git.rahul.singh@arm.com>
 <9bdca2cda5d2e83f94dc2423e55714273539760a.1633540842.git.rahul.singh@arm.com>
 <6752f2d3-171b-37f5-c809-82995a8f3f36@suse.com>
 <CEF7FFB0-779A-4F46-8667-6BCD9BA5CB6C@arm.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <b735c2d3-1dbb-ce0a-c2fa-160d4c6938d3@suse.com>
Date: Mon, 11 Oct 2021 15:09:08 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <CEF7FFB0-779A-4F46-8667-6BCD9BA5CB6C@arm.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM5PR0601CA0058.eurprd06.prod.outlook.com
 (2603:10a6:206::23) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 6b279947-83e4-4fe5-eccb-08d98cb85066
X-MS-TrafficTypeDiagnostic: VI1PR04MB4191:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB4191AAD3C82D44B767F763E9B3B59@VI1PR04MB4191.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	9bmMW+zzRSCIrUe5GcE/ObwCKagCwuf2vGu4hXDl0B5YweV37unRp18m3+6cnK1X43esiukDKTi9F31xx38i6XkAcc1gnBynxzl6MipWNf4OvWyaWdtltrHw4rzPRtjNZ5cKrva9GJZMu/p7M8tamGTdcrXqxZ4NQvsfzl7xOTOdxuZ1/Mc73TXsqOmDD7fbm/kEc42u2PDBDrdDxBSg5EqHXVikmufLxbR4JDwaHKXWg2OzSP3FiYXacGmQKVCZzxtVr6nHPK1MZSHAIEy0Jb5Qm6iE6L3+fbksbaP5Kh4802qyY9VDQllBadj24AZuYDOQFFFXoitIX2IwZku6umOKXij3YGA8I+Me4QMWCi05HDuOG3d35jmRozLebosTDV2MKRcEZ8+C7azvhZ2u96f7tlZ4rcyDiJhFH6HVnn2fbTIINTgjKnS85ceOOVEZH5lLrxdsfho+Dc5AubdGj8JYXAa9Xywx3bQfcv0CiwvXcFQsan4BeojfCJG4C6rlJgBz0ihwcgQTRt4p5cUFT5QWxkZu/DKx2bL1LTftbqyHLg1HBcaj9QbN0P+MNgdOZuyMqBHw8QG97jwFdPPfPeiZbaOCjX9tmUu+UBW8CWjLFdaqFNNjUtRGSVuW69mI2QpkQPPCTCm6tfIvw376TRzh2jW3yBpeUDCkOUsLuVJsMRZrCZTTtxugyZBCOqBrOz3clCfP2WBjqBgboJEsoK3GPXyDvJSciyWuCM4tYjZLv+sXkJUX1vIsZGBghM0auEzYaNNZE/LXwwJo2EXQqg==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(2616005)(8936002)(66556008)(6486002)(956004)(26005)(66476007)(83380400001)(186003)(53546011)(7416002)(66946007)(36756003)(8676002)(31696002)(31686004)(54906003)(38100700002)(316002)(16576012)(4326008)(5660300002)(2906002)(508600001)(6916009)(86362001)(2004002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?UnFJRlN3UWtRTGNGdkYvak42L3c3dG1DZU1LVTBHZkp1WUVJUVhqSE5qTEd2?=
 =?utf-8?B?Tk83RFBEcTByNDhLU0NCUVpPbllIL2hOTGNxR3R5Yy9JYWVRbVltY0ZlZjRV?=
 =?utf-8?B?akZVYmVPYWJYNTQreC9QQmJVejA4MWx0SEtWZVdRV0tsb2EyMU9uc3Jzd0Iv?=
 =?utf-8?B?bHhLQTA0bEZ5aUdmcW0wc1cwOGJkelN4S2ZUbUt2NEZUM1FaQlN2N21UdVRP?=
 =?utf-8?B?eHZkeFFScDRRemZvNHhiYTYzakFOdm05YUJjVkY1dnpaVGtkT3FRK2RlWk1r?=
 =?utf-8?B?UEhCc0tWOStZd3R6ZlQyNC9qeWtoTjN0cytHY2Mrby8xQ3ZVSUh6eHdxQWxH?=
 =?utf-8?B?eXVpR2tVY1lEWUt0T3FKUjhVVGtnVnBmWjErMzZvdkFrbVFZS3JRZFlOdnUr?=
 =?utf-8?B?OXp5UkF4eHA2bmxyT2ZTU3JxQTBBNGlhbTRxYTJmaWZzS1Q3TzFwbjBVVGNK?=
 =?utf-8?B?d205d2FvTjh4Z0c5SDhhdHYzWnloWEFTTmJVaHIvdnNMUHg2SFVNZTlNYzRv?=
 =?utf-8?B?a3lSZEtOZW5Pbm42aXdaY2xJVUNYWVc1VjV5cWwzMW9HYzBkTjRIaC9TUTNR?=
 =?utf-8?B?aDhtWnFxNWFybzlPVnAwcVV5SUVFQnV5dFBsZzJJRWJTd2MvSlI5Z2I5RmFI?=
 =?utf-8?B?Nkcrc3ZoN1hPT0I1ZDNvMlR4eWN0SjVMMWVna3VEbWhqMDZ6MktHZ3BBbWl2?=
 =?utf-8?B?aEZmM2ZWRXFrZ2U3Um5sclBCVC9qQWlYWW16aGgzam9OdDdabzlIUElDU2Rp?=
 =?utf-8?B?ekhST2M1bUxGbWhUSzZ2SGVBS3BJeVByNjI2aG9kME9FQVFjVGF6UUljQ3JP?=
 =?utf-8?B?R0c3ODI3TDlEdlBCMmRvVXBnUUdZejM0NjFSMng5L0tJdUg0WHNFMlFqQklt?=
 =?utf-8?B?MEZnd1FEaTR0SVdvbjdkdFhjU0hSYXFYR0duS3lzTVdCcEJoQ0c3dXBxQnQv?=
 =?utf-8?B?YTJHdTFYcjJ4TWdJWGFSS0VBb1AzNVNWUEc1MktNKzh2ajd6RDV0NHhRdC9O?=
 =?utf-8?B?ZUNKQlU5VEFUZzFFVlNLVkFIeC9EVnhhYWVka293cXUxcjc4WGxpZytENEtQ?=
 =?utf-8?B?VHdpSnJBdVlPS2phNUtWUFV0cy9oQzV6djQ5dm52d2dpT0pPVGYvQVJtUkQw?=
 =?utf-8?B?d1AzUy8wbklPSHEvOGNzN1BHZ3FIbTUxMFNSNjN0RHBvd29LeUU3WDZvOW5v?=
 =?utf-8?B?TEo3NnlzY0xpTjBzKzRWWkh3UElFdHQ5Q2RyMUh5Z1VRZmN4NFZVODFobit6?=
 =?utf-8?B?VTNMVERuT3YybGpZWXY1YUdxRkMrZ2NlRW8wUGFHWU5ERldHSDQzcWgxOXBK?=
 =?utf-8?B?Y2hqMnU5WW5zdStmelorUndqMStjb0JSeVlaTzZjejFqQkJaWlJZM21EWFAw?=
 =?utf-8?B?MDNDSTgvZ0xkY09aK3FNTnVXVmwvODlnNlppWjcyalFuZmJEaDR0NjhjSnl4?=
 =?utf-8?B?Z3V5bmtoSlBTMHUvL1cwbHcyU29QOWtUU0NjZ1JxZExkZmJGRUNPMVJ5SXEr?=
 =?utf-8?B?b0RVMEdBazJ2VktMa1R6SFMvUjNldjMvMGs2QVI1OEUvZ1lmQkl0TU9jQ0pW?=
 =?utf-8?B?b3JleENLTXlvN0U3Zm1OdERlOTZkZDQ5Z2hscFpFcnhDUXVQSkVWM3pEb2pZ?=
 =?utf-8?B?WC84OUNkdmJNaUVmNXNYcitrSDR5RnZNSEtmZDR4Qmp3MGNnK3EzVzdvTFNn?=
 =?utf-8?B?Njg0SFF5WU00MkZST0x3L3ZuMytiK2VzWTNHcUEvY2I3V1FVTEFnT2U4MVV0?=
 =?utf-8?Q?i2uG24JsjGvyboJBPUG+6CGx8YnCPIFzwwik6v8?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6b279947-83e4-4fe5-eccb-08d98cb85066
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2021 13:09:10.1608
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: BEoowrqca829z8gUm8+uUmsH7oFRcuao9+e4YGWUvkYiAE7PsUU2mmsXEYFEDK+AUtfOZUtzOW/CQuBuizsaCA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4191

On 11.10.2021 14:41, Bertrand Marquis wrote:
>> On 7 Oct 2021, at 14:43, Jan Beulich <jbeulich@suse.com> wrote:
>> On 06.10.2021 19:40, Rahul Singh wrote:
>>> --- /dev/null
>>> +++ b/xen/arch/arm/vpci.c
>>> @@ -0,0 +1,102 @@
>>> +/*
>>> + * xen/arch/arm/vpci.c
>>> + *
>>> + * This program is free software; you can redistribute it and/or modify
>>> + * it under the terms of the GNU General Public License as published by
>>> + * the Free Software Foundation; either version 2 of the License, or
>>> + * (at your option) any later version.
>>> + *
>>> + * This program is distributed in the hope that it will be useful,
>>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
>>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>>> + * GNU General Public License for more details.
>>> + */
>>> +#include <xen/sched.h>
>>> +
>>> +#include <asm/mmio.h>
>>> +
>>> +#define REGISTER_OFFSET(addr)  ( (addr) & 0x00000fff)
>>
>> Nit: Stray blank (like you had in an earlier version for MMCFG_BDF()).
>> Also isn't this effectively part of the public interface (along with
>> MMCFG_BDF()), alongside GUEST_VPCI_ECAM_{BASE,SIZE}?
> 
> I will move that in the next version to xen/pci.h and rename it MMCFG_REG_OFFSET.
> Would that be ok ?

That would be okay and make sense when put next to MMCFG_BDF(), but
it would not address my comment: That still wouldn't be the public
interface. Otoh you only mimic hardware behavior, so perhaps the
splitting of the address isn't as relevant to put there as would be
GUEST_VPCI_ECAM_{BASE,SIZE}.

>>> --- a/xen/drivers/passthrough/pci.c
>>> +++ b/xen/drivers/passthrough/pci.c
>>> @@ -766,6 +766,24 @@ int pci_add_device(u16 seg, u8 bus, u8 devfn,
>>>     else
>>>         iommu_enable_device(pdev);
>>
>> Please note the context above; ...
>>
>>> +#ifdef CONFIG_ARM
>>> +    /*
>>> +     * On ARM PCI devices discovery will be done by Dom0. Add vpci handler when
>>> +     * Dom0 inform XEN to add the PCI devices in XEN.
>>> +     */
>>> +    ret = vpci_add_handlers(pdev);
>>> +    if ( ret )
>>> +    {
>>> +        printk(XENLOG_ERR "setup of vPCI failed: %d\n", ret);
>>> +        pci_cleanup_msi(pdev);
>>> +        ret = iommu_remove_device(pdev);
>>> +        if ( pdev->domain )
>>> +            list_del(&pdev->domain_list);
>>> +        free_pdev(pseg, pdev);
>>
>> ... you unconditionally undo the if() part of the earlier conditional;
>> is there any guarantee that the other path can't ever be taken, now
>> and forever? If it can't be taken now (which I think is the case as
>> long as Dom0 wouldn't report the same device twice), then at least some
>> precaution wants taking. Maybe moving your addition into that if()
>> could be an option.
>>
>> Furthermore I continue to wonder whether this ordering is indeed
>> preferable over doing software setup before hardware arrangements. This
>> would address the above issue as well as long as vpci_add_handlers() is
>> idempotent. And it would likely simplify error cleanup.
> 
> I agree with you so I will move this code block before iommu part.
> 
> But digging deeper into this, I would have 2 questions:
> 
> - msi_cleanup was done there after a request from Stefano, but is not
> done in case or iommu error, is there an issue to solve here ?

Maybe, but I'm not sure. This very much depends on what a domain
could in principle do with a partly set-up device. Plus let's
not forget that we're talking of only Dom0 here (for now at least,
i.e. not considering the dom0less case).

But I'd also like to further defer to Stefano.

> Same could also go for the free_pdev ?

I think it's wrong to free_pdev() here. We want to internally keep
record of the device, even if the device ends up unusable. The only
place where free_pdev() ought to be called is imo pci_remove_device().

> - cleanup code was exactly the same as pci_remove_device code.
> Should the question about the path also be checked there ?

I'm sorry, but I'm afraid I don't see what "the path" refers to
here. You can't mean the conditional in pci_add_device() selecting
between iommu_add_device() and iommu_enable_device(), as "remove"
can only mean "remove", never "disable".

Jan



From xen-devel-bounces@lists.xenproject.org Mon Oct 11 13:13:07 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 13:13:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.205975.361417 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZv74-000581-Ef; Mon, 11 Oct 2021 13:13:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 205975.361417; Mon, 11 Oct 2021 13:13:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZv74-00057u-Aq; Mon, 11 Oct 2021 13:13:06 +0000
Received: by outflank-mailman (input) for mailman id 205975;
 Mon, 11 Oct 2021 13:13:04 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mZv72-00057o-KT
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 13:13:04 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mZv72-0005j5-Ja
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 13:13:04 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mZv72-0008Jp-IN
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 13:13:04 +0000
Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89)
 (envelope-from <iwj@xenproject.org>)
 id 1mZv6z-00019w-08; Mon, 11 Oct 2021 14:13:01 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date
	:Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From;
	bh=dTMF7exkdx37Ym3T/GqUaJCGI9ifJqKuFtXwFnmmJ+o=; b=PrHyCKpkPnbO/sLeauJwjoW/Kb
	lui6lT2/cSb36oJhsgq2KAz3+6t5yopHQRxtnHk3VYADws3lXH4HhNTacDwjCqKMX9btn8SAe5Xhd
	VI8GEunw+HieevlGhIR7KOdvmic29r0/O5tw8bHuhFjG1k1OrL4ruRG0SNKV5xvU27j8=;
From: Ian Jackson <iwj@xenproject.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <24932.14428.657415.416663@mariner.uk.xensource.com>
Date: Mon, 11 Oct 2021 14:13:00 +0100
To: Jan Beulich <jbeulich@suse.com>
Cc: "xen-devel\@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
    Kevin Tian <kevin.tian@intel.com>
Subject: Re: [PATCH 0/2] VT-d: correct / extend workaround(s) leaving an IOMMU
 disabled [and 1 more messages]
In-Reply-To: <ed7632b9-5426-b351-45af-7ad3bf31d3d9@suse.com>
References: <ced41449-6aa2-3b20-77cd-78dafcad4bc7@suse.com>
	<a385938d-243e-1790-da1f-be7c4f5f2c3f@suse.com>
	<24932.6255.815797.597475@mariner.uk.xensource.com>
	<ed7632b9-5426-b351-45af-7ad3bf31d3d9@suse.com>
X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu)

Jan Beulich writes ("Re: [PATCH 0/2] VT-d: correct / extend workaround(s) leaving an IOMMU disabled [and 1 more messages]"):
> On 11.10.2021 12:56, Ian Jackson wrote:
> > I think 2/ is a new quirk (or, new behaviour for an existing quirk).
> > I think I am happy to treat that as a bugfix, assuming we are
> > reasonably confident that most systems (including in particular all
> > systems without the quirk) will take unchanged codepaths.  Is that
> > right ?
> 
> Yes. According to Linux there's exactly one BIOS flavor known to
> exhibit the issue.
> 
> > I don't understand 1/.  It looks bugfixish to me but I am really not
> > qualified.  I am inclined to defer to your judgement, but it would
> > help me if you explicitly addressed the overall risks/benefits.
> 
> Right now our documentation claims similarity to a Linux workaround
> without the similarity actually existing in the general case. A
> common case (a single integrated graphics device) is handled, but the
> perhaps yet more common case of a single add-in graphics devices is
> not. Plus the criteria by which a device is determined to be a
> graphics one was completely flawed. Hence people in need of the
> workaround may find it non-functional. However, since our doc tells
> people to report if they have a need to use the option engaging the
> workaround, and since we didn't have any such reports in a number
> of years, I guess both benefits and possible risks here are of
> purely theoretical nature. Note that I've specifically said "possible"
> because I can't really see any beyond me not having properly matched
> Linux'es equivalent workaround - that workaround has been in place
> unchanged for very many years.

OK, great.  Thanks for the explanation.  For the record,

Release-Acked-by: Ian Jackson <iwj@xenproject.org>

> > But when reading the patch I did notice one thing that struck me as
> > undesriable:
...
> > That seems like a recipe for missing one.  And I think a missed one
> > would be an XSA.  Could we not structure the code some way to avoid
> > this foreseeable human error ?
> 
> I'm afraid I don't see a good way to do so, as imo it's desirable to
> have separate log messages. IOW something like
> 
>     if ( ... )
>     {
>         msg = "...";
>         goto dead;
>     }
> 
> doesn't look any better to me. Also leaving individual IOMMUs disabled
> should really be the exception anyway.

C does not make this kind of thing easy.  I might be tempted to make
an inner function which returned a const char*, with NULL meaning "it
went OK".  Oh for a proper sum type...

Ian.


From xen-devel-bounces@lists.xenproject.org Mon Oct 11 13:17:34 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 13:17:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.205983.361427 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZvBL-0005mE-0b; Mon, 11 Oct 2021 13:17:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 205983.361427; Mon, 11 Oct 2021 13:17:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZvBK-0005m7-Tk; Mon, 11 Oct 2021 13:17:30 +0000
Received: by outflank-mailman (input) for mailman id 205983;
 Mon, 11 Oct 2021 13:17:30 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=pkLr=O7=citrix.com=roger.pau@srs-us1.protection.inumbo.net>)
 id 1mZvBJ-0005m1-SN
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 13:17:30 +0000
Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 9463722f-2a95-11ec-80d9-12813bfff9fa;
 Mon, 11 Oct 2021 13:17:28 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9463722f-2a95-11ec-80d9-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1633958248;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=h1PNIs28iq9z8+ycWKobWGlysNYsD7wmvQ07mwMGWik=;
  b=atN327X41eOG+3dK5OTxdg7o9BW/g5A1yGbzCKzoYGQClXnXE96DlWyJ
   mdZZoj+4eHv/il8raK95I8SoQQO3bOxZYiBOcD7HYN4IIOHONDUz1JWL8
   RfeuSiYpuLhzzN17XQO1HkNE6qJlxub6T490vbCJOtoEK/4uW2/1M5fvu
   A=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: QZViAazBXSKjy4f+DxiY6ZamcCNS4RiPB3sq5/3NejHpS6bQhDwxzQ7SuZJv6zF+RaXx/UC9ZG
 cLuvS/E/iCZPUX4jiAvpVpidTbwkx4GQjyL+U0Rn7rSsyjrhHInb14HvRK+D8l2ojPUqp5Wvni
 tvki9X5dgsfNd4I8rLO1cuksLzqY2Vt1y+yxgmwWPy3HWUJEcm4ZKBXbx4PuQuETu9gVz3bKNd
 OfrqcL9xPqFmCy777NYvHwPmS+WTYPk5wxmqL3ChDiQOEUMFj0ViYnTCFlcahgvo7bTzWrdSAj
 mlEVdgJKAp5QPdFRTGt/1ngl
X-SBRS: 5.1
X-MesageID: 56747344
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:BqK/Va9yVhiXEGoRmbXvDrUDtXiTJUtcMsCJ2f8bNWPcYEJGY0x3m
 GRLDz3TOv+JZzH9f9EgO9yyoUNS68fdzoUwHQRlrC88E34SpcT7XtnIdU2Y0wF+jyHgoOCLy
 +1EN7Es+ehtFie0Si9AttENlFEkvU2ybuOU5NXsZ2YhGGeIdA970Ug6wrZg29Yx6TSEK1jlV
 e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH
 I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPhx5
 4hSlN+rFj0nHf3UiuEFYwUAOAZhaPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us
 6ZCcXZUM07F17neLLGTE4GAguw5K8bmJsUHs2xIxjDFF/c2B5vERs0m4PcFgmhs2ZsSQZ4yY
 eIzNgpIXB/MZCZwI34FF5MivuvzlljGJmgwRFW9+vNsvjm7IBZK+KfpGMrYfJqNX8o9tkeHp
 ErW8mLhGBYYOdeDjz2f/RqEiubRkAvhVYkVFbn+8eRl6HWI3XAaAhASUVq9oNG6h1S4VtYZL
 FYbkgIssKwz+UrtQcP0Wxn+p2WflhEZUttUVeY97Wml9K3Q5AqIA3keeRRIYtcmqcweSCQj0
 xmCmNaBLSZmsKCRD2mc8LiUhTqoPG4eKmpqTSoFRgsM55/kupM+ijrGVNMlG6mw5vX3Ezztx
 zGBrAAlmq4ey8UM0s2T1FbLmT/qnoLbXxE8/Az/V3igqAh+YeaNbYGy9ULS6/oGKY+DV0SAp
 1ANgc3Y5+cLZbmdmSrITOgTEbWB4/eeLCaakVNpB4Mm9Tmm5zikZ4843d1lDB43aIBeI2avO
 RKN/1MKjHNOAJe0Ra9YPp2QSN9196bDRcz3U+jkcoJlRYckIWdr4xpSTUKX2mnslm0lnqc+J
 YqXfK6QMJoKNUh05GHpH7lFgNfH0gh7nDmJHcmqkHxLxJLHPCbNIYrpJmdieQzQAEmsmw7S7
 8pEf/WDzxFSQYUSiQGGrNZNczjmwZU9bK0aSvC7lMbfcmKK+0l7Upc9JI/NnaQ/wsy5cc+Sr
 xmAtrdwkgaXuJE+AVzihopfQL3uR41jinkwIDYhO12ls1B6P930vPZHKMJuIed8nACG8RKSZ
 6JfEylnKq4eIgkrBhxHNcWtxGCcXEXDaf2y09qNP2FkIs8Iq/3h8d74ZAr/nBTi/QLs3fbSV
 4aIj1uBKbJaHlwKJJ+PNJqHkgPg1VBAybkadxaZfbFulLDErdECx9rZ1aRsfanh6Hzrm1On6
 uphKU5A/7eS+NVprIChaGLth97BLtaS13FyRgHzxb23KTPb7iykx4pBW/yPZjfTSCX//6DKW
 Amf562U3CQvkAkYvoxiPaxsyK5itdLjq6UDllZvHWnRbkTtAbRleyHU0c5Kv6xL57lYpQrpB
 R7fpogEYe2EaJH/DVocBAs5deDfh/sarSbfsKYuK0Lg6S4poLfeCRdOPwOBgTB2JaduNN932
 v8ovcMbslTtihcjPtucoDpT8mCAci4JX6k978lIC473kAs7jFpFZMWEWCPx5ZiObfRKM1Urf
 WDI1PaT2ewEyxObIXQpFHXL0e5Mvrg0uUhHnA0YOlCEutvZnftrjhdfxis6E1ZOxRJd3uMtZ
 mUybx9pJb+D9itDjdRYWzz+ABlIARCU9xCjy1YNk2GFHUCkWnaUcT84MOeJuksY73hdbn5Q+
 7TBkDTpVjPjfcfQ2CouWBE696y/HIIprgCSytq6G8mlHoUhZWu3i6CjUmMEth/7DJ5jn0bAv
 +RroL59ZKCT2fT8eEHn5112DYgtdS0=
IronPort-HdrOrdr: A9a23:XodFUKpc1GrR5gPp7kD2rzoaV5oveYIsimQD101hICG9Ffbo8P
 xG/c5rsSMc7Qx7ZJhOo7y90cW7Lk80lqQU3WByB9mftWDd0QPDQb2KhrGC/xTQXwH46+5Bxe
 NBXsFFebjN5IFB/KXHCd+DYrQd/OU=
X-IronPort-AV: E=Sophos;i="5.85,364,1624334400"; 
   d="scan'208";a="56747344"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=mn6G1J8AJEi3ixvxxfzbXjlh6nS7O6OAvjeymku4YXS8celTJu+0i2CZkfnDHOuOUjLhfj/rPEC04g4BxcNzhX2xj1DVodsMsrYNMNNzDK+JDLxsF6Wyi+vl4TuWDg7r9DfJL++VbKsazMHaT/U0JMEO2o63r8kpSYosYlYM46QgbDRY53TL3RQ4taixqn2Iis27DZv+0uY5U6NvPzvbYPzNbOX+Soccrqit4fpEcxrOUgdve4w2sCpjgPlcqDu49PAdSASJw4JcFeGsb3CDOAuM37GgOnJmkXDQoP8hkSJYJybWETb9pSMn8U87TiXAHXjrDRxk3w0YglgyYSD+jg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=n4IVm4e8aLEZT8pfyEP1KCLbduIfA272QU6Jxh4+OZk=;
 b=Z6IKhor3lG3RWtZ6lwsXIoJjm0VxOQ6o7KnjAhxQEZZDQTFi4E5jJncjNeONCBXIHoHGemfIJLMcbMEWMuk3MEjy39SgZmRgY8Tk5PHCLiOQ2HoNNPE1lj7aqtEiRLXOyp45MnpYc6wXJIeic2XDwrTclwY3bPwEnN2mXZPxEODd+BwvWtYTuKY04an+mNxk/AZwe5syw43Xgj5WFdO8uN58wmZRqtL+8l9WzraGq9/ODrYlEfjhlwLKIcD1UEfxbfErOlNJ9lb1guFVOBTwEA4J52XahU0O4ep77PGB4/ZZZiI2QJvmQmJijXt5tDIcmp2Tps0eVAiY7SZjKOdPjg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=n4IVm4e8aLEZT8pfyEP1KCLbduIfA272QU6Jxh4+OZk=;
 b=qc8Wvklgk5la7K7+HZifQ/H3D65D0ujJ+y3J392A2c5PbVEg7WFjMzO3jImyUcKmpp8J17G9CNxQRYr++A0y8fnlu6OhBfFtPxluCRUd0zqcFa7hH+04IFYIImsTE+kGG45QVjQa7pw4AB9PC2V9cnGwrtaTQ/sSWYInY0F9i/0=
Date: Mon, 11 Oct 2021 15:17:09 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Michal Orzel <michal.orzel@arm.com>, Andrew Cooper
	<andrew.cooper3@citrix.com>, Rahul Singh <rahul.singh@arm.com>, xen-devel
	<xen-devel@lists.xenproject.org>, Bertrand Marquis
	<bertrand.marquis@arm.com>, Andre Przywara <Andre.Przywara@arm.com>,
	Christian Lindig <christian.lindig@citrix.com>, David Scott
	<dave@recoil.org>, Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>,
	George Dunlap <george.dunlap@citrix.com>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Julien Grall <julien.grall.oss@gmail.com>,
	Stefano Stabellini <sstabellini@kernel.org>
Subject: Re: [PATCH v5 07/11] xen/domctl: Introduce XEN_DOMCTL_CDF_vpci flag
Message-ID: <YWQ5Valvu374f0fn@MacBook-Air-de-Roger.local>
References: <cover.1633540842.git.rahul.singh@arm.com>
 <20d5b9d6a0d01a7b90711d28cbefb5701a88b438.1633540842.git.rahul.singh@arm.com>
 <548fa153-b2e3-7f91-c7c9-a569e13b5809@citrix.com>
 <CAJ=z9a2kYdYB9fSXX8NhLk90px03z8+D-YE5AQKW9uABx9kvrQ@mail.gmail.com>
 <alpine.DEB.2.21.2110081433110.25528@sstabellini-ThinkPad-T480s>
 <8a58a981-f474-cf6d-f16a-46805384a776@arm.com>
 <b084240e-cba5-4b20-5eef-f21915cfce2a@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <b084240e-cba5-4b20-5eef-f21915cfce2a@suse.com>
X-ClientProxiedBy: LO4P123CA0133.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:193::12) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: a1fbabfa-bf7f-4f7d-ea88-08d98cb9715c
X-MS-TrafficTypeDiagnostic: DM6PR03MB5081:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <DM6PR03MB508105CAF1D21EFE039FF9E28FB59@DM6PR03MB5081.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: FPa1QjUnZY/Vg2VYACFhm2yQMh4uQub1OwjDghtN9BlMSCnYlPrnfLHy4kMpTWfGkfqn3orhzzJWWztzEAGNxHnEHafowjHNFW4chS0k1ZxiW46ahP/gvaS6Isch0p3CW+Ic6snj25MXZ0+7tN4v77FTTdn2Qv+zB2fVeX3IK6JcZIoeSiDsZ1UMc17LBbSgHUxxvu+O33smv97d+eFEJY87dZF49NuEdU27MbWOnlOJF0vK0qGFhV+nzSMrhlGWFz9l34jrYgPcCbxNZ60RKgLthZyTRzKGttOiLv+G6M4k+tLKd3EXtoefo9MWLYJqNNMb5FuUled1q0QxWu9GJv3biBih7e0rqojEAU/5AwFbMZHj0nqB7AMWQRG1vUmqowyQTKWdLNJioYKEAIweAxY/oOnwjAYUQGQ87v2WmKJNgeeGtEfF/zArNIDHtU8dZP3/dWEKRfnhg5lRsFUUymSzqal7wYylyzd+DFOk/C41LK0x5WIU5/uB559XLYkVA6EXWV/60LuP8VxFDtqLVS4HiuRAI1CiunTvkl0a6eeD9RWCV1h1vC2ZQje7uq0aD4Hr2ygetSXBnTXKnCFYcovkirZnk1RAnpTEV8oYQhdskDJfLJoVdkejulDz8FeDiyv96MRco20jusqNq5ZT/A==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(5660300002)(508600001)(54906003)(2906002)(6916009)(6666004)(6496006)(66556008)(66476007)(6486002)(26005)(8936002)(66946007)(53546011)(8676002)(186003)(9686003)(83380400001)(86362001)(4326008)(316002)(7416002)(956004)(85182001)(38100700002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dWFIY0pvWmxpQjY2blhVWlJMMzF6MHU1cGk3MlJFLzVsU2lNdjFuM282d044?=
 =?utf-8?B?b1JxUG4wYlB2d0FrVjFKSGRBWmNRdSsvZXRsenlQeHZGSzNBRlN5Z2lWbGtR?=
 =?utf-8?B?Vm13RktFMjlLdUQ2WHlCRFpYb28vbkJOWVljVk1oT3g2bmQ5ei9vM2JNOUVx?=
 =?utf-8?B?ZmxEeFBCWHMvVUtKczBaZTl5VldLNENadTY1djIzVThsYkZBVXZZMmZvYkNw?=
 =?utf-8?B?VjVSbmh6cUVhV2Q2dENueUY2WnJHcGhBUVVTVm1yOVp2a2xNM2d5bVFuODh5?=
 =?utf-8?B?RmE3L3YreHVjb2tQVWpkb0pCUEVmeXorZ0JZdHFyYS9xdHdIdE1tT203ZnJ4?=
 =?utf-8?B?KzhSRkNkUDZZSEp1djZvNnVZMW5IcmdtMTE3dHBNTHpDZDU3RE9MR0o2bEhN?=
 =?utf-8?B?TDNMK1BtWFRzNytxcVpYalA0TWd6eEFrU3lKbUtPdWRBeVJGSWtybU9KbDdD?=
 =?utf-8?B?VGV5ZndtbnhNT3NwSHJwZDZSWU5YVHd1Tm5WaGdON3ZpSEFYR1ZIVnZ6WDQr?=
 =?utf-8?B?MFlIcmE4NDdPZjI0TktHa0xybjh6SFE2WlNDMm9YaGxvcm1qOUp6TENXMW9L?=
 =?utf-8?B?N1ozRUgrbWlQenErQ3FGZzVuMXRNc2lxU1FnL1k1ejRQMzBLQ2V0clN6NVA1?=
 =?utf-8?B?am9SbU51bFVrWmVLbWRoRHBVQW9qSE9TNWR0L1NWOWNLd3Bjc3FVRjB6UDFn?=
 =?utf-8?B?cVRmUVpQU0xQVG1seGZXR1ppRzRXR1p0U3h6WFA0eG84U3JFWklKdllCS1ls?=
 =?utf-8?B?M3R0clVHTExFMlBqTEhBOURSSnExbk1qbmlhSXU0K1BHbU52aE5MWGVCL1ZO?=
 =?utf-8?B?UjBzZlMwUHFWM3ExQmlFcFBFY2dMT2FEZWZDSnNLRHBhZFVrMk03M1o3T3Y3?=
 =?utf-8?B?SXRTSHUxU3FRZEZlMTdaMXdqcThvMFBFRnYrQUJtQjhrSmREbDBZQ09ybkZR?=
 =?utf-8?B?TEErbVFLaWtJVGExUCs2VjNBTEdsbDBmYURYTXZsa01rOGEwcmpOSHVWNDhL?=
 =?utf-8?B?MVFVRmdFTVpETDRkSkN2dUZLcFdPV3FNYmtVMHpuT2dTY1VLTnJnVm9TNjgw?=
 =?utf-8?B?RmVnQkZhK3BTSlN0dUhhNi95cnBmZzYzZnNQNWp4dU1hOEtBekJ0cmUyM2Jh?=
 =?utf-8?B?T3ZzRDlHUjc2K1ZFbU03R2JRdWtibW1Ra1krcTViTWE5bmJJSjlNYUNyNE1W?=
 =?utf-8?B?R1llajA3K1RKT2JWSURCeDRiem1iK1Q5bi82OXNiODVuTm5ncERQdG9NZjc2?=
 =?utf-8?B?RytyTlZSSDFtdVhqSTZxYmxrbUFrakx1TnhkYXk2QkhoQ0VoM0l5dU5uQWVk?=
 =?utf-8?B?NFNOcGxLTU55aVBuVUhiekFYMDZrQ0hQc0UxRllYQWVSQUpuV09WV043TEhU?=
 =?utf-8?B?MVVCSkVqVTJxZVpEekJlczlFNGIyK0NpTEJNOStQM0M5RWxaa3gxWEI2d3RO?=
 =?utf-8?B?WkJ0UlJSRmkzbVlYMHNWbEpMK1M3YVlPZ2VIWmJPd09MZGFpRFJyRjJHTDcv?=
 =?utf-8?B?ZnJXdU9GSDU1UE01ajZJWW9pTGpJZGlZNDlEb2IzMnlZN2p0dHNEN0xLTFRD?=
 =?utf-8?B?UExhZm5QdldpZzc0V0NKYVp3WnF2cE5kNm9LdkVlK3owMWdqT2t5cVp0NUk1?=
 =?utf-8?B?TGxod3l3N1ZNRHBhSnQyQUFTaHFEcE1IUnQ1ejkvczNvZXRUMlpzM0ZObzBG?=
 =?utf-8?B?SWdEVkxKcnVQY2dQUzRGQUpSMXArK1hidlk1UHduZ0tKK1FzNXlraWF0S1Ew?=
 =?utf-8?Q?1NNMp4qsnaKkVi/ww7R3MGIueUbHKxiNQthooEv?=
X-MS-Exchange-CrossTenant-Network-Message-Id: a1fbabfa-bf7f-4f7d-ea88-08d98cb9715c
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2021 13:17:15.0589
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: HyhbBVho25h/wzaXhi14Wf1tay6QJjUABqD00UXzWr2HVavUJ+QQntmG6RsunR5VUCaQ6KyK1WkDv91eEb/Dtg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB5081
X-OriginatorOrg: citrix.com

On Mon, Oct 11, 2021 at 01:35:18PM +0200, Jan Beulich wrote:
> On 11.10.2021 13:29, Michal Orzel wrote:
> > On 08.10.2021 23:46, Stefano Stabellini wrote:
> >> On Fri, 8 Oct 2021, Julien Grall wrote:
> >>> On Fri, 8 Oct 2021, 20:07 Andrew Cooper, <andrew.cooper3@citrix.com> wrote:
> >>>       On 06/10/2021 18:40, Rahul Singh wrote:
> >>>       > Introduce XEN_DOMCTL_CDF_vpci flag to enable VPCI support in XEN.
> >>>       > Reject the use of this new flag for x86 as VPCI is not supported for
> >>>       > DOMU guests for x86.
> >>>       >
> >>>       > Signed-off-by: Rahul Singh <rahul.singh@arm.com>
> >>>       > Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
> >>>       > Acked-by: Christian Lindig <christian.lindig@citrix.com>
> >>>
> >>>       I'm afraid this logic is broken.
> >>>
> >>>       There's no matching feature to indicate to the toolstack whether
> >>>       XEN_DOMCTL_CDF_vpci will be accepted or not.  The usual way of doing
> >>>       this is with a physinfo_cap field.
> >>>
> >>>
> >>> I am slightly puzzled by this. I am assuming you are referring to XENVER_get_features which AFAICT is a stable interface. So why should we
> >>> use it to describe the presence of an unstable interface?
> >>>
> >>>
> >>>       This flag needs using in Patch 10 to reject attempts to create a VM with
> >>>       devices when passthrough support is unavailable.
> >>>
> >>>
> >>> May I ask why we can't rely on the hypervisor to reject the flag when suitable?
> >>>
> >>>
> >>>       Ian, for the 4.16 release, this series either needs completing with the
> >>>       additional flag implemented, or this patch needs reverting to avoid us
> >>>       shipping a broken interface.
> >>>
> >>>
> >>> I fail to see how the interface would be broken... Would you mind to describe a bit more what could go wrong with this interface?
> >>
> >>
> >> After chatting with Andrew on IRC, this is my understanding.
> >>
> >> Today if pci=[] is specified in the VM config file then
> >> XEN_DOMCTL_CDF_vpci is added. If Xen doesn't support it, Xen returns
> >> an error but libxl/xl won't be able to tell exactly why it fails. So xl
> >> will end up printing a generic VM creation failure. Andrew would like to
> >> see something like the following in libxl:
> >>
> >> if ( PCI_devices && !cap.vcpi )
> >>     error("Sorry - PCI not supported")
> >>
> >> So that the user gets a clear informative error back rather than a
> >> generic VM creation failure. Also, this is a requirement for the stable
> >> hypercall interface.
> >>
> >>
> >> I think that's fine and we can implement this request easily by adding
> >> XEN_SYSCTL_PHYSCAP_vpci. Rahul or Bertrand, are you guys happy with
> >> doing that? Otherwise I could take it on.
> >>
> >>
> >> As a side note, given that PCI passthrough support is actually not yet
> >> complete on ARM, we could even just do the following in xl/libxl:
> >>
> >> if ( PCI_devices )
> >>     error("Sorry - PCI not supported")
> >>
> >> or temporarily remove XEN_DOMCTL_CDF_vpci until PCI passthrough gets
> >> finalized.
> >>
> > As Rahul is on leave:
> > I'm ok to introduce XEN_SYSCTL_PHYSCAP_vpci. I did the same for vpmu so it's ok.
> > However the problem I have is about setting this cap.
> > On arm it is easy as we are not supporting vpci at the moment so the cap can be set to false.
> > But how to deal with this cap in x86 code? I'm not familiar with x86 so I'm asking for advice.
> 
> As the sysctl is mainly from tool stacks to drive guests (DomU-s), I'd
> set it to false for x86 as well. Roger - do you see any reason this
> could be needed to express anything Dom0-related?

I agree, I don't think we should set it to true unless we also support
vPCI for domUs on x86, or else it's just going to confuse the
toolstack.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Mon Oct 11 13:21:45 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 13:21:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.205996.361439 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZvFP-0007FK-Kq; Mon, 11 Oct 2021 13:21:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 205996.361439; Mon, 11 Oct 2021 13:21:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZvFP-0007FD-Hg; Mon, 11 Oct 2021 13:21:43 +0000
Received: by outflank-mailman (input) for mailman id 205996;
 Mon, 11 Oct 2021 13:21:42 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=pkLr=O7=citrix.com=roger.pau@srs-us1.protection.inumbo.net>)
 id 1mZvFO-0007F7-7f
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 13:21:42 +0000
Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 2b8b8150-2a96-11ec-80d9-12813bfff9fa;
 Mon, 11 Oct 2021 13:21:41 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2b8b8150-2a96-11ec-80d9-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1633958501;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=hLTWWIFfBIixB+m4hOItyJlcjUoDYUNEkghcP+AfRk4=;
  b=GKWqU9ko/Vz1ifHVcPGXSawM4gXNfeNdBHH5TgxtIqKIjyufuO2PPJwO
   2jFQpizCiogHUOBGsxNoGnqTyy1UUREUbUJk0DHiKfdpPxenJLGI1QrZC
   nE8VuhBz9MDdXbuyvfTamoA8zYtbWdFQKqsHk4en0+nke5mEOenz+b2nX
   Q=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: DGYQh72bENi4XMeM7yrPXYSvypyxLVd0o+ygSMJVoEUq57KDaBiEpTbMo5qGfjhidA0BWe1lT2
 kzwmFYUWr9d925X64hkIWkXlmvQqcRICU+uQbdivvZIpQeL/639MZPXSXNuYzMPwABlOITURwl
 fij9AhPNkujR9vxtGeRkAxAJOGHIa9/1SdDtyrmCqXMX2JsYbvLWyNKClhjTApIKoY8T5KUMaQ
 2tYKfm4pgJ9PQoE2hXtAKKjxZn4+t3eJ/EF1QtCsw4WItY4HufVHdE9Rgv5pmEc1aA+9gZkot5
 OIV620q9Tx7Ocy6zdMdz8NfH
X-SBRS: 5.1
X-MesageID: 54875794
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:25TZZKO1jqtTjYXvrR3vkcFynXyQoLVcMsEvi/4bfWQNrUorgmZWz
 msXXWvVOq6Kazehc41ybo+y9UoHsJSHnYNhTAto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdpJYz/uUGuCJQUNUjMlkfZKhTr6ZUsxNbVU8En540Us6w7dRbrNA2rBVPSvc4
 bsenOWHULOV82Yc3rU8sv/rRLtH5ZweiRtA1rAMTakjUGz2zhH5OKk3N6CpR0YUd6EPdgKMq
 0Qv+5nilo/R109F5tpICd8XeGVSKlLZFVDmZna7x8FOK/WNz8A/+v9TCRYSVatYo3a2tI5h9
 +RAib+bClozBJzlnN0XTBYNRkmSPYUekFPGCX22sMjVxEzaaXr8hf5pCSnaP6VBpLwxWzsXs
 6VFdnZdNXhvhMrvqF6/YvNrick5atHiIasUu216zCGfBvEjKXzGa/iWtYAFg2Zs7ixINa/9a
 cUidT9FVhKeU0BkE2lNMqsnpfj90xETdBUH8QnI9MLb+VP70whZwLXrdt3PdbSiRNpXtlaVo
 Hrc+Gb0CQ1cM8aQoRKe6W6ljOLLmSL9WaoRGae++/osh0ecrkQRBwcRTkCTuuSihwi1XNc3A
 3Yd+jcq65Mz8kOrZtDnWluzp3vsljQRQcZKGus2riSE0LPJ4h2xD3IBCDVGbbQOnck6XzFs7
 kWbjszgHzVHuaeQD3ma89+8vT60fCQYM2IGTSsFVhcepcnuppkpiRDCRcolF7S65uAZAhmpn
 WrM9nJnwexO04hbjM1X4GwrnRrvmbOXXjEE6zn0dSH49DlITYqcbZOnvA2zAel7EK6VSVyIv
 X4hkseY7fwTAZzlqBFhUNnhD5nyuK7baGy0bUpHWsB7rWz0qiHLkZV4uWkmfC9U3tA4lSgFi
 aM5kTha44NPJzOUZKtzbpPZ5y8CnPW4S4qNuhw5aLNzjnlNmO2voHEGia24hTmFfK0QfUcXY
 8rznSGEVydyNEif5GDqL9rxKJdyrszE+UvdRIrg0zOs2qeEaXieRN8taQXVNbBotPzd+VmLq
 L6z0vdmLT0ECoUShQGNoOYuwa0idyBnVfgaVeQGHgJ8HuaWMD54UKKAqV/QU4dkg75Uho/1E
 oKVASdlJK7ErSSfc22iMyk7AJu2BMoXhS9rbEQEYAfzs1B+MNnH0UvqX8ZuFVXR3Lc4lqAco
 jhsU5joP8mjvRyeo25DMsKn8NA7HPlp7CrXVxeYjPEEV8cIbyTC+8P+fxup8y8LDyGtstA5r
 aHm3QTeKafvjSw4ZCoPQP7wnV63o1YHn+d+AxnBLtVJIR2++4l2MS3hyPQwJphUexnEwzKb0
 SeQAAsZ+raR89NkroGRiPDWtZqtHst/AlFeQzvR44GpOHSI5WGk24JBDrqFJGiPSGPu9ay+T
 uxJ1PWgYuYflVNHvtMkQbZmxK4z/fX1oLpewlg2FXnHdQ3zWLhhPmOHzY9EsagUnu1Vvg6/W
 0Su/NhGOOrWZJO5QQBJfAd8N7aNz/AZnDXW/M8ZGkSi6X8l5qeDXGVTIwKI1H5XIoxqPd532
 uwmosMXtVCy00J4LtacgylI3G2QNXhcAb4/v5QXDYK32AomzlZOPc7VBiPsuczdbtxNNg8hI
 yOOhbqEjLNZnxKQf302HHnL/OxcmZVR50wakA5cfwyEyojfm/s6/BxN6jBmHA1awyJO3/93J
 mU2ZVZ+Ir+D/mswicVON4x299qt2PFNFpTN9mY0
IronPort-HdrOrdr: A9a23:BAZrFKvYgHD7lT5FwiT5iYGC7skDctV00zEX/kB9WHVpm6uj5q
 eTdZUgpHvJYVMqM03I9urtBEDtexzhHP1OgbX5X43NYOCOggLBRuxfBODZogHIKmnT8fNcyL
 clU4UWMqyUMbGit7eY3OBvKadD/OW6
X-IronPort-AV: E=Sophos;i="5.85,364,1624334400"; 
   d="scan'208";a="54875794"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=O7vLOzsSWC4o2AGLa2/Ix40DnvS4ZhVMJzB5MVCBIiSzOPXmwkiD6efd/9k6oYHvtNXdLiqsPwsf+8lhuCpKiPZnVtXmMtT1SCJddjLJgctgjtz5Nwk2vqblcFjRlxdGPjru6qx+uq+QPBlLooWiWCmez4pSxoJpTZ4SI4EulLe8Q8z6WD9IvODcwE0MOR9ZG1ywB/WSgwEHNQLaVHYXgvJMxsngpJ5d+iFPhyDlJDwpkNSJ8xA7SAtHdYJdDtPBQX21WQMzjVo2oklCaaj4kBgUx9ofrn251XsJD7BY2tUeYqi1PPjzxyKN+5X4Jq1Gl+SlELcj9Yd3FVpHaVWd5w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=egF0V+tHtMeF59ZvOVaYN9PSfuOExJamhIvU720waeU=;
 b=oQDTXRqj4r5H3HpIbqAWwMbyma5yq2vX17vDWmSTSdSinXDzcxog/VAy2+8C6uq2C5+IHj7oRhzyrTanN1JgmlJjb55ThJlfltQxxEnNYMr1PhXjCAP/qA0DUxuIz3rNXHaF80KUUE2DEIfY0jk57aN0LBjgFYnu3Rwd89nLq2eqVrt/EpLcdIFO1acQHVNTwX13y7SFFiynZs936fOmH2bb12ueX3t4STN2dKR4Wfm+2RClvO1hfWmcY52RVxCmg1cmHyQNrt6xVG8ohBn6d1TJKnbtYsPzAPHaH2nA7hHYg7mswIqsy57av3UeR9Bz/laAY4gAtr9lAHVuiTyMAA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=egF0V+tHtMeF59ZvOVaYN9PSfuOExJamhIvU720waeU=;
 b=OGX+lOQ78NRS8v7oyRbX1yxvkJiJmlwPFVWsxWNdmCdgH2udwQsKxlal66ojvAZeBryMi+9R/gopJ09E3QY+qlgwO+35u7HRVesBDovO+faZYh2EEIM62duCGYBV3AsbEoSmbz6hneofBz8LhX3ZtofTpmtPzYq3wJfk/gtCXhU=
Date: Mon, 11 Oct 2021 15:20:54 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Bertrand Marquis <Bertrand.Marquis@arm.com>
CC: Rahul Singh <Rahul.Singh@arm.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, Andre Przywara <Andre.Przywara@arm.com>,
	Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>, Juergen Gross
	<jgross@suse.com>, Stefano Stabellini <sstabellini@kernel.org>
Subject: Re: [PATCH v5 01/11] xen/arm: xc_domain_ioport_permission(..) not
 supported on ARM.
Message-ID: <YWQ6Nk3Jk+BqgkwZ@MacBook-Air-de-Roger.local>
References: <cover.1633540842.git.rahul.singh@arm.com>
 <d292392268df2c74c4103a82ef917072643407a8.1633540842.git.rahul.singh@arm.com>
 <YWQkblfNMYEs6jI9@MacBook-Air-de-Roger.local>
 <77CF7FA5-C566-469E-B4A8-0400789890BB@arm.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <77CF7FA5-C566-469E-B4A8-0400789890BB@arm.com>
X-ClientProxiedBy: LO2P265CA0492.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:13a::17) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: c1bef990-110a-4420-7e90-08d98cb9f69a
X-MS-TrafficTypeDiagnostic: DM5PR03MB2924:
X-Microsoft-Antispam-PRVS: <DM5PR03MB292437729809B1D25A4DC3708FB59@DM5PR03MB2924.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 5wmPsgWi6xyRUOx/Hesf4kColqhWz1yVtR1KSdZobRYh9g7dXg/AeKEDEmbZrazsB2AjE1htFCxjhEij/wEblBKSjhh05RlLxZLbqdff8CoTlQOKoakED80I97KV1YTXeGJfvbmRdAGn8GFSGzk7+GnlMRvvugxAeQbVKClgjsU0bHp4/N5XJohVaov7+UASWt6uayRFon9rERnYzCiaLC4dVYIOqk94c6TWY1P5RjqoD0fQBSMSrGjyRbU812lRVv4sWoBCeBjkhjDID9H5FP026wCnVVhKt3kvPo1xkBEAnG7e2P1rSfuHloohxbBVpNroU27UoIWMYVZQlYDWBIxa6/zrhPl7U72YIR2UPq5OY3Dhfocn724CpEecbOQ5IkQPCJfHU9Ori7m/wrX5DMQMNpzwwd2ACFLDsSJ8C5d1DEp0Vnat0SoiniPx+AUc/bi+BdfeQj71qv9zZhQhP6iF1sU9XpuvWCQrHnEBTgpIR7VmE0gO6UK3/HZcE+B1oXqhvk+reWAmUvy8A95QRirExyyZeHqw4pC7bOEDAm9ctGum6IU9TYZ4RowBvmcD3XO0yqmOYaIWgD3mYC6U+36wt/Cc7JmYJ6JiCt4LpQi6gtzOFwqUPFKnAhEQi1qz5++3dfJIVA0LntLioIlMzEP6i61EEH2wX6MqsaNuzOPTh1ZV2O1QZWIHhztN1vGRWD0Vg0o6fpFiLl9WIuE9zQ==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(2906002)(26005)(8676002)(54906003)(6916009)(316002)(186003)(5660300002)(85182001)(38100700002)(6486002)(9686003)(86362001)(4326008)(8936002)(6496006)(83380400001)(66946007)(66556008)(956004)(508600001)(66476007)(53546011)(6666004)(67856001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K25wSmFlTCszU3dpRDNobm45UXVmaGFTajEwMWdyc0paU2ZxWGdXYVozcHZO?=
 =?utf-8?B?YTZ6SHY5NVJCV1F2SWVPcGltckw5OU9PRGNuSnNuc3d3RTcwWWE1V0h1UXdJ?=
 =?utf-8?B?WVNNS2NEYWtEY2xsV29EU2tNZmVEeW9sLzJmWjZVcnN1OWxiMW1EUjYvcTl3?=
 =?utf-8?B?Zks3cGQrK1NLd3g5M2sxV21yWCtlenlaSkQwejBvNDc3UTRiaVMyc0V2aE9H?=
 =?utf-8?B?aWpuNHpRKzNoUzQ5VnNvaEtIdGZ5SGJvRmtMVnlwNU1xT2pITndtQ05ad0RP?=
 =?utf-8?B?Yy94YlIwMjN4M2tVdTJPQnZqeldBVTFDRVY2b3ZwUmRTWUpzZE5YZHlXV0l1?=
 =?utf-8?B?aVpSbDRZZEtOSDc4SWpkc21MNnRUeFRQTEh1YnVaZ2xYMWVmTjYxTHAydGFj?=
 =?utf-8?B?TnJsUUZoeXBLZHVJQWxUSXJOYUxMVnErZXFUckl0YlBGQ05DVjBVK3drakVx?=
 =?utf-8?B?YzhUWGZPY012WFpGV1Q5d0ZRMUtFTmtoK1JucW1OalJ6aUI5c3pKcG9lU0tL?=
 =?utf-8?B?YnF5bDBMMWpQWENQanhWOGlFVDh0aURjV0dVTXNqeml5a29hSERHSUUxQTg0?=
 =?utf-8?B?REFFTjRSckF5c2EwZTg3bHdyMTlhUUtJOEttbTBkbW14RERDT1A1aExPZTN4?=
 =?utf-8?B?Rm9CSUlkcWRrS0hhd1pvQkRRaVB1WnhqY3NmdGptZDJhOFlhRGZBQ2xBbHhH?=
 =?utf-8?B?U3RhUTk0UWxUT1hOb3RLc0poWXFkRGdNdklMT3l6M3ZlQlU5UjBTWUxHYkZE?=
 =?utf-8?B?L1ZhU1psbHZ5Njd1RDRMVm14L0xmV0ZyeDRDVFE1Q2NrVC9Kbk1FVzNJdUEr?=
 =?utf-8?B?ZThvUlo2RHd5Q3B6TXR3ODErQ3RrOUdLOGNJZjlHQmZCUHplNVhoSndrQWR1?=
 =?utf-8?B?Uy9KV0FxZWFrVjRqblVQenNXV3JxSFpSbXR1VjMxUFozdGF4TVA1SVg4aHNQ?=
 =?utf-8?B?MXZ0ejRnSGFyNkczZGU1VVVRY0hCaERoQzd0QUlrOHhYQnk4S2JlTlpZWTFm?=
 =?utf-8?B?cU1YRFdZMVhrZTRKN044a3M2VER0RFZTMUtRZk1OUGROQjlSQ05HS1lRV252?=
 =?utf-8?B?Qk4relUwYno2bUY2TFBjckhybmcyTGtKNmtsN3NFb3Q2UWFqVFNhNGFZejF1?=
 =?utf-8?B?RjJScUdEdXIvRDhBQ0NoL1cyZkdjN212Y1JIQjNjQjJRYVQ5blFuc0lpZkx1?=
 =?utf-8?B?dlNxUEd0Zlh0QkIvc0NyK3ZSWkR0UFZMdTUwR0lEUDkweTdkOFhvMXNjRkI5?=
 =?utf-8?B?dWdWZWcydy9WVHRIWlRmL1RnTmlTeWNwZGZKeEZHVFIzbW00VjlhbUdpVHU2?=
 =?utf-8?B?VUhRRHdzcTNEeHp0WTNkY3RsRkJiNktjUFh3dUFJWFM1QmlJbU52a1NHWlRp?=
 =?utf-8?B?TUlwZGh5RHRlMTlKVTZISituYyt1RWs1L2RqUXhwTTdyWWttcm54amJXSHUy?=
 =?utf-8?B?M3NMdGF2ZmpzUXNQaGZyK002TENJK0RHeGUwQyt4YWtUYnA0YitEeTVSekN6?=
 =?utf-8?B?am1HT1cwSks0dXhOUWRncytPcnR4ek1HUUM5eFZLSjdRZjRFUEdEaUtrMWVt?=
 =?utf-8?B?VldBdWVmYk5tcklvTHo2UlVIRFlIUzlLSVpYVC9wd2QvdSt2Y2NKcUNoL2pS?=
 =?utf-8?B?SkVQWEJyMGZoUnA1UWxrN2RxaVVxUGsySGJMbVF1Ti9ZQXJvMmZpUnA5MjFC?=
 =?utf-8?B?Q2NDc2RXUDNEdDA1UTV3UktrbVMrU2RwYXhmekpMZzE5UWZSLzdHcHF4Q3ls?=
 =?utf-8?Q?LmsNOjxR3k2XjRWTbCZLSCHVP8Qn0gHdaKxt07B?=
X-MS-Exchange-CrossTenant-Network-Message-Id: c1bef990-110a-4420-7e90-08d98cb9f69a
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2021 13:20:58.6382
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: pYHROTUmWcFKqiNDxcFqPb1rEZopWBxqWYCRrWGBAzcaBJ9aJwxxYIxwum6DnY+klZYZXJnrGWf6aZUBRE3ZSw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB2924
X-OriginatorOrg: citrix.com

On Mon, Oct 11, 2021 at 12:11:04PM +0000, Bertrand Marquis wrote:
> Hi Roger,
> 
> > On 11 Oct 2021, at 12:47, Roger Pau Monné <roger.pau@citrix.com> wrote:
> > 
> > On Wed, Oct 06, 2021 at 06:40:27PM +0100, Rahul Singh wrote:
> >> ARM architecture does not implement I/O ports. Ignore this call on ARM
> >> to avoid the overhead of making a hypercall just for Xen to return
> >> -ENOSYS.
> > 
> > What is the cal trace of this function actually on Arm?
> > 
> > AFAICT libxl will only call xc_domain_ioport_permission if there are
> > IO ports explicitly defined in the guest configuration, or if any of
> > the BARs of the PCI device is in the IO space, which is not possible
> > on Arm.
> 
> PCI devices BARs can be in the IO space as the PCI devices are not
> Arm specific. There is not ioports on arm so to be used those can be
> in some cases remapped and accessed as MMIOs or are not possible
> to use at all.
> 
> But the IO space does appear when BARs are listed even on Arm.

Urg, I wonder whether those devices with IO BARs will work correctly
under Arm then.

How do you know whether the BAR has been remapped from IO space into
MMIO?

IMO instead of faking a successful return value from
xc_domain_ioport_permission we should avoid the call completely in the
first place, specially if we need to instead issue a call to
xc_domain_iomem_permission.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Mon Oct 11 13:28:42 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 13:28:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.206003.361450 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZvM3-0007wB-Dy; Mon, 11 Oct 2021 13:28:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 206003.361450; Mon, 11 Oct 2021 13:28:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZvM3-0007w4-AI; Mon, 11 Oct 2021 13:28:35 +0000
Received: by outflank-mailman (input) for mailman id 206003;
 Mon, 11 Oct 2021 13:28:34 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=9TNE=O7=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mZvM2-0007vy-32
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 13:28:34 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 2062be32-2a97-11ec-80da-12813bfff9fa;
 Mon, 11 Oct 2021 13:28:32 +0000 (UTC)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2104.outbound.protection.outlook.com [104.47.18.104])
 (Using TLS) by relay.mimecast.com with ESMTP id
 de-mta-20-mBfnUlkqO5m4JUtnHRJkCw-1; Mon, 11 Oct 2021 15:28:29 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB6862.eurprd04.prod.outlook.com (2603:10a6:803:130::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18; Mon, 11 Oct
 2021 13:28:28 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4587.026; Mon, 11 Oct 2021
 13:28:28 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM5PR0601CA0074.eurprd06.prod.outlook.com (2603:10a6:206::39) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4587.18 via Frontend Transport; Mon, 11 Oct 2021 13:28:27 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2062be32-2a97-11ec-80da-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1633958911;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=W9kzb4yBJ9OGJMK0JLjIkh6eFopaFEA/AGpXNmsx6zw=;
	b=WMuceT4k9gLt0VdYxoytNadobM8u4o9nuX83gy3bIjrd6lD9rDryEeoMaPqMu+T/mosVp6
	f00rPRCoiDDfeTJZsFKFh/dki8UOzmtTZaDdbSbrHr2RsH4SvRh+9fyeQiRiZgvN5wlDvt
	OKGBO+CwMhkgTdHqshfmx4fN81OgAow=
X-MC-Unique: mBfnUlkqO5m4JUtnHRJkCw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=G33pFvyomwleGXyV1O+MvVLvAZ1xvccCscBAlpB5e3eX5gYQD/z9cVaC5qlFviYzUSAfCs3SnCI5io+VhNPWbD/hYTJWx07MH3Ic4O7jLC80WAxa2Na9TkCJUAiLCpC8ukEJoD+b2m6E6vTtf48iYmj/YPjoMrVv5HTiqwsbS5r04C3aXbdeH+/7Et1x1U6bbv6weh3gACC0Kpfi5P48KzC8bFhBT3avp1ok5/DvJtPYK84TF45pDxH2F9toeotL56a92ot1bebe+b3ljpIR68uZJz6TpIt8JmN4R55TMUF+Wec+OmO5YcVj1FhUNDBRezPDj6WJ7MrhMmUaX0nsmw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=W9kzb4yBJ9OGJMK0JLjIkh6eFopaFEA/AGpXNmsx6zw=;
 b=VynkAk2uIjjHMp9BqD4hQkgxNSAvlxqOKkw9zOOoeoXSm5xB4vQJDpNY1L7VBfLsBKVRuEEK4xChZ/v3D78MKQGAkSnbIzpbYv4hZUrFX+PdNh7+YTlbZSFcpFe/d158HgpYvpOR1YvR2ioINCHsT0g3F4jbjKWJ67QCWaFYro3vNsQ5nanDmKB9ZzQYbDHOvo72aL8V8fXA1hTJ4K8qzzKi3jb1PL3hoyUFucvKnYXk5aJFIQPPRjnokzyLyJt8ZieBXOldPo0BO1uTTQV2kZ/p/2c6dZva7MdJaMIZ1VHEq7of4O7GKt5TXu2XHJ05NymeG+YB0Dw03YHa2PiDSQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [XEN PATCH v7 25/51] build: rework test/livepatch/Makefile
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
 Ross Lagerwall <ross.lagerwall@citrix.com>, xen-devel@lists.xenproject.org
References: <20210824105038.1257926-1-anthony.perard@citrix.com>
 <20210824105038.1257926-26-anthony.perard@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <bd4ffeef-b577-f360-060d-6df09d6f0219@suse.com>
Date: Mon, 11 Oct 2021 15:28:26 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <20210824105038.1257926-26-anthony.perard@citrix.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM5PR0601CA0074.eurprd06.prod.outlook.com
 (2603:10a6:206::39) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 3dc5d8cc-0d0e-4d49-3798-08d98cbb02d9
X-MS-TrafficTypeDiagnostic: VI1PR04MB6862:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB6862CB09A80B97E5F5F54F1DB3B59@VI1PR04MB6862.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:4502;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	/geUbh7MtuDWexjovJc7OPdNBMrJzkGsN8Vur6YapEUh6MSIOihKRYqP/xR9Af33KYu7G5jkiTg2JGGh2T+TyP3crxHF8Z+f+rhwX+VB3oBQjjjaDbTsQLRnKGPN6PHdmT8HPoDsPZzfR6T43vlauHysZpdvDmmuvXSwKJN7NxbebP2tYm9u5V4LZjFrfh8c8d3mPDyaAI3P5xWaKF1KWiH0rZQhdSoSjbTjo0nL4Fqt+qmg9GBnff7+towAH5Rd3y912/DPxua9+yQltEFPO+PdIxxbgxEq2ds4nHHToetaUr0H1H7CFsfGI32cZZsh6TAPPOYIHtzE0A4iAgAIbJeoszfhY6zP+jga9UsFSNK2WvJuxAKzVsXqd+AE7hel2B/DnH1p8iHSVnniPNzPlAPHC6CBrqI+QUNBzzT2rnQEFf7OcSgnAkEoxVw8ZWjAKlV61icYA4yo+2foECFYS5TcP6CAnR/jYuPWYJ2+XwAa2gfAjKRl3Ji2HqbjqDdWlh8jKlVAhhCaIx2KgVjCnpYelc/Uu6S9sBGhFpLQnJ/DEc0/7AZajPOvIemDUlT5sLjRtprz/fyYJnHqu25dKDwFe+YsVMNQkXzM8XL4lSabHKF+tDTaKc9zLKBOR5BOvOkfURNbCv4ts8FEG/icfuR/wSK6anc0d/4zciEyldJj+v+Zi/vQoUFiSziMSzW9bzjESKGFhb2ZylnBro3NUTXwDUL+WMDVYW4CYofEy1XNaJXpapnU8FyFnxcY4rgn
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(38100700002)(5660300002)(7416002)(54906003)(26005)(186003)(31686004)(53546011)(6486002)(4326008)(86362001)(8676002)(316002)(508600001)(16576012)(83380400001)(2616005)(31696002)(8936002)(956004)(66946007)(6916009)(66476007)(66556008)(2906002)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?dTR6RHBZbkQ2Qld4ZTlOeE1vQmZTU04yc3RtTWNEbFlQaS8vaGUyZWl1Mmcz?=
 =?utf-8?B?bXpGRTg3YWpJbytjZytOcER0T0JYbG1RZVBmSXhGc2R4MXNDanBtUjEycE5F?=
 =?utf-8?B?NU50SGhZUUFUYjBYbVlIYmZGWUU1RXZNV3N6RzE1aTBLM0RjUGJxQXRFSVVS?=
 =?utf-8?B?a1FBZFVVREswK1FKUWRyUitLVzRucklKbTYxcHlZR2QzVENDWDMyYm5BOVVy?=
 =?utf-8?B?dk90dUp2SUVNTUN5ekZPaXlEWUkrTFh5M242RDk0am9vRDV1aVV2dk9Qa2NR?=
 =?utf-8?B?K05uaEpiL05tSjNnTVI5c3RBTjQrWmV4Mk1oeVQvMmFNRWQweFpwcVBWYVFQ?=
 =?utf-8?B?dkk4Z0ovVThBdVZ0ckR0cXNiZHNOekJEZFZWaGx4QytQSnlvYTRVSm5xNEVG?=
 =?utf-8?B?RmRTTWZ6a2JISmI1a3hQRm1IakpSSHRGT0xNZkRlT1hhYm9TaHkrWlRWZHQz?=
 =?utf-8?B?U3NjdTVkVmw0dE9STzMwaHpUR2JsUGVwSmJDRmJxSk1lemJNb2NmbDhwZ0VJ?=
 =?utf-8?B?VHc3cWRFc25qSUZWR0d5VXR0SXZSS0lBZ2VLb0YxR2gwQUc3eUR3bnF5VFZZ?=
 =?utf-8?B?K0E3dTJZMEtzcFlZVE1NUmFBK1F1VmpBeDR4ZUFXa2wxOEFhZHVsRTJHS1B3?=
 =?utf-8?B?UXRVY2J6c3pOeG1tTnF2cmZDMHRDL0JaSDFMeG9iWktNRWdhTEIvNmg3eVMw?=
 =?utf-8?B?RGVubDVaL2gwZTNNMzNhMFRhbW9uRlVQYlNQb0tJa2ZKbkVLcFFnOENyM1dl?=
 =?utf-8?B?R2tsRUx4VHVnRkNsMHlQOUdxR1AvdHdCcXZhT2RLcUdTWnFyd1NleFBPanFy?=
 =?utf-8?B?eVRlTnM1QUdGWmpyOG9McVZDRFd4ZnBkWmtMQVowQ0VtVXV4MmxCaTN2TzJr?=
 =?utf-8?B?bjBRQVNNWlhBRm13SDhlY0JzVVE2SnVaRHhvSHBKQ2RpRnZ0SmtsU1JDb1Bi?=
 =?utf-8?B?eEVhOW9kMkk5UytVMlhRVUpzVEdjWGNrM0p2cWFYaE1OWmhRbFB6UHgrRml1?=
 =?utf-8?B?ck1XWGZoRFNwMjFScEJ4VWsrSno2L1hnK1oxK3Q1cFhISjc3SWY3ZE5PUGZI?=
 =?utf-8?B?QkM3eEw2dkk5UW5lQW9XN3ozRGY5QlQ2LzRnQURJVDhuSG84NnBhdkxId2JU?=
 =?utf-8?B?OTJiQ05tN0VPenI1WHkybmxzNlh2TnB6OUtSK0FDL1MwOTFQU1pmMEVCc1dI?=
 =?utf-8?B?ODMza3hpSWVoQUhKTlFObFI1KzRwcHVvbkh1L0lyZy81RDZ5RGc0a0drUWh6?=
 =?utf-8?B?VEp4dHB4REN4Wm5GcVl0VTR0eXNscGxHUmhiZXExSnJ2L2xJWThYRGxacVRo?=
 =?utf-8?B?NUUrNnFya0cxbE5xR1hLMXB2eWlZbXJHckRPT2xkVEV4VDhSMVRKMlNzemFW?=
 =?utf-8?B?NjBpdTV2U01acVorK21VbnUwbHUzay9jZ3ViSTZDQXBETGRiVUF2MHJ6MnE0?=
 =?utf-8?B?QWF3Q2NCYW85bVRGOHdHSmdzNHFYbjY0enM1dXhYeUpBZ3Y5VzQ0UFltd0Z1?=
 =?utf-8?B?SUJzZjlERkp6ZDgxejVINHNpSDdpa2tVUVVhbHQzMTBQMk9URzR4dHZ6ckI3?=
 =?utf-8?B?UmVDZDNUemZpS1Y4R2hudWs5Z0FuM3ZvWldSVmxHUDhsQ1psK0wrWEpVRm9i?=
 =?utf-8?B?SG4rRjdUUHA3OUlTL1YybjdNdGJQNTN4dEFmaThYdTRIckZGV3MxVWlETWcz?=
 =?utf-8?B?cGZkemdrVnVQV3Q1a1BzQUZIYWM4NGpndkh3K2hNTWk2Wk4xb09XbHVtZlgv?=
 =?utf-8?Q?UyzlI6vsLr7LkfJ44cqSGTnFPl3aY6oPF/9B8l5?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3dc5d8cc-0d0e-4d49-3798-08d98cbb02d9
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2021 13:28:28.5478
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: lOWvp22s+PIIKznr7LOBYQSx0/X+Za/AeV3Opcx3wSE7Y0hynRQ+2S+w4Ksn3ns6tmks6Zm397uKVf5oUjvgDg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6862

On 24.08.2021 12:50, Anthony PERARD wrote:
> This rework the livepatch/Makefile to make it less repetitive and make
> use of the facilities. All the targets to be built are now listed in
> $(extra-y) which will allow Rules.mk to build them without the need of
> a local target in a future patch.
> 
> There are some changes/fixes in this patch:
> - when "xen-syms" is used for a target, it is added to the dependency
>   list of the target, which allow to rebuild the target when xen-syms
>   changes. But if "xen-syms" is missing, make simply fails.
> - modinfo.o wasn't removing it's $@.bin file like the other targets,
>   this is now done.
> - The command to build *.livepatch targets as been fixed to use
>   $(XEN_LDFLAGS) rather than just $(LDFLAGS) which is a fallout from
>   2740d96efdd3 ("xen/build: have the root Makefile generates the
>   CFLAGS")
> 
> make will findout the dependencies of the *.livepatch files and thus
> what to built by "looking" at the objects listed in the *-objs
> variables. The actual dependencies is generated by the new
> "multi_depend" macro.
> 
> "$(targets)" needs to be updated with the objects listed in the
> different *-objs variables to allow make to load the .*.cmd dependency
> files.
> 
> This patch copies the macro "multi_depend" from Linux 5.12.
> 
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>

Just two and a half remarks; I'd really like the livepatch maintainers
to properly review this change.

> --- a/xen/scripts/Kbuild.include
> +++ b/xen/scripts/Kbuild.include
> @@ -151,3 +151,12 @@ why =                                                                        \
>  
>  echo-why = $(call escsq, $(strip $(why)))

Not the least seeing this in context, ...

>  endif
> +
> +# Useful for describing the dependency of composite objects
> +# Usage:
> +#   $(call multi_depend, multi_used_targets, suffix_to_remove, suffix_to_add)
> +define multi_depend

... I would wish we wouldn't introduce further names with underscores
in them when dashes are valid to be used.

> +$(foreach m, $(notdir $1), \
> +	$(eval $(obj)/$m: \
> +	$(addprefix $(obj)/, $(foreach s, $3, $($(m:%$(strip $2)=%$(s)))))))

I'd like to suggest to be consistent here: Either $(s) and then also
$(m) in both places, or $m and then also $s.

> --- a/xen/test/livepatch/Makefile
> +++ b/xen/test/livepatch/Makefile
>[...]
> +$(obj)/%.livepatch: FORCE
> +	$(call if_changed,livepatch)
> +
> +$(call multi_depend, $(filter %.livepatch,$(extra-y)), .livepatch, -objs)
> +targets += $(sort $(foreach m,$(basename $(notdir $(filter %.livepatch,$(extra-y)))), \
> +    $($(m)-objs)))

I think it would help readability if the 2nd line was properly indented to
reflect the pending open parentheses:

targets += $(sort $(foreach m,$(basename $(notdir $(filter %.livepatch,$(extra-y)))), \
                    $($(m)-objs)))

or (less desirable imo)

targets += $(sort \
             $(foreach m,$(basename $(notdir $(filter %.livepatch,$(extra-y)))), \
               $($(m)-objs)))

Jan



From xen-devel-bounces@lists.xenproject.org Mon Oct 11 13:35:07 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 13:35:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.206010.361461 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZvSI-0000ub-4H; Mon, 11 Oct 2021 13:35:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 206010.361461; Mon, 11 Oct 2021 13:35:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZvSI-0000uU-17; Mon, 11 Oct 2021 13:35:02 +0000
Received: by outflank-mailman (input) for mailman id 206010;
 Mon, 11 Oct 2021 13:35:00 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=LfEM=O7=arm.com=Bertrand.Marquis@srs-us1.protection.inumbo.net>)
 id 1mZvSG-0000uO-NS
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 13:35:00 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com (unknown
 [40.107.6.80]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 80b00963-55a7-474d-b32f-b0c6b24fd271;
 Mon, 11 Oct 2021 13:34:58 +0000 (UTC)
Received: from AM6PR05CA0033.eurprd05.prod.outlook.com (2603:10a6:20b:2e::46)
 by AS8PR08MB6838.eurprd08.prod.outlook.com (2603:10a6:20b:353::23)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.25; Mon, 11 Oct
 2021 13:34:56 +0000
Received: from AM5EUR03FT011.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:2e:cafe::1) by AM6PR05CA0033.outlook.office365.com
 (2603:10a6:20b:2e::46) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.27 via Frontend
 Transport; Mon, 11 Oct 2021 13:34:56 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM5EUR03FT011.mail.protection.outlook.com (10.152.16.152) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4587.18 via Frontend Transport; Mon, 11 Oct 2021 13:34:55 +0000
Received: ("Tessian outbound 16951d3c485e:v103");
 Mon, 11 Oct 2021 13:34:54 +0000
Received: from e2a40f08536e.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 617DE395-B2DD-446D-BDFF-DB8728061DCB.1; 
 Mon, 11 Oct 2021 13:34:43 +0000
Received: from EUR03-VE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id e2a40f08536e.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Mon, 11 Oct 2021 13:34:43 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com (2603:10a6:4:74::9)
 by DB7PR08MB3369.eurprd08.prod.outlook.com (2603:10a6:10:44::13) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.22; Mon, 11 Oct
 2021 13:34:41 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955]) by DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955%4]) with mapi id 15.20.4587.026; Mon, 11 Oct 2021
 13:34:41 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 80b00963-55a7-474d-b32f-b0c6b24fd271
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=H/5z6cFxpvEYcJSvVT0f09ajvwhHu3nE5OcRBCHhQD4=;
 b=wA2W3zOFL9fBQqM9ImOachNvjFFUqC/3eeliShi0vdynSbuS5a5ZAPl6PMbKf5eMP6MUY/WXSfaU3NobhNK9tjdWFqKZY5uZwB0yL1fJUsjDmSJqctSqfoeQLRjnQt3ESlb3g16+SCqbMRxUC4IWIeUnZ6S7qhPIZWwJcbXNnmY=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: fd589959859da261
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=MSORPbyFjmwcMuyLVX8nmU8jyC/v+uOewM15pdzZesHiRdzBjBGDfQMpiZUKHnBCK7eMdN5s1QcmcgAFnN1WP4EPeFw4u/EhG91FBurnIrJL2vk9GLc/mhygKkDDpRyCDauBGmG7rl+GQrxx3N/X1EFxN4u/W4CJXYcenuzGMXGIlEPhJxKwHfW6mwss5ZYJ6WlPyJqmSQrxCNTpThK2LxiJaQ8/lv6KPGgdFUWEDjefesHbMQZLWWVbTZRaqrokNVCpKEKC5MzZZA01HVP5I/puZC7eT2oS25bIi5bse6fC1KkmsPyYIjYgnn9Otk00+Yq2YRiRajTcFmoEXt0pCA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=H/5z6cFxpvEYcJSvVT0f09ajvwhHu3nE5OcRBCHhQD4=;
 b=Fkkok0oPYCETuU9ylV6YZ+OL5tNOI3XPpfBI/8zE03MC9TILaRbAmnOL5Jg21d+49g7ZAZ+FspJFd8AoslmyP5jItP0e4gezmh+yWyZwomdMKy/2pYGGUT7RHrHwNJ7KuMJcoAMalCYcBu62u0K5WjLOt/UQJnakh5LkPtLiDYJBEVX/47QwhCz795CaxkIG3C18gAXsr8dRw9FdY63eslU4kIwhHRfgvKDDo+9y5NIaDe8RFtfgPmSOWUo3ZAvYO4aAv1LzAs8KfTLo806h0zG/EaGDRlU5S4JZzdo/Fc6CoqXtKiYaNpPndNwhmWVSag2EvsHCbWvzSz6H/3Bkrw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=H/5z6cFxpvEYcJSvVT0f09ajvwhHu3nE5OcRBCHhQD4=;
 b=wA2W3zOFL9fBQqM9ImOachNvjFFUqC/3eeliShi0vdynSbuS5a5ZAPl6PMbKf5eMP6MUY/WXSfaU3NobhNK9tjdWFqKZY5uZwB0yL1fJUsjDmSJqctSqfoeQLRjnQt3ESlb3g16+SCqbMRxUC4IWIeUnZ6S7qhPIZWwJcbXNnmY=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Rahul Singh <Rahul.Singh@arm.com>, Andre Przywara
	<Andre.Przywara@arm.com>, Stefano Stabellini <sstabellini@kernel.org>, Julien
 Grall <julien@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>, George Dunlap
	<george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>, Wei Liu
	<wl@xen.org>, Paul Durrant <paul@xen.org>, =?iso-8859-1?Q?Roger_Pau_Monn=E9?=
	<roger.pau@citrix.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v5 08/11] xen/arm: Enable the existing x86 virtual PCI
 support for ARM.
Thread-Topic: [PATCH v5 08/11] xen/arm: Enable the existing x86 virtual PCI
 support for ARM.
Thread-Index: AQHXutl3YqS5dHXsYk6KpdKt4d14RavHjPqAgAY38oCAAAe6AIAAByIA
Date: Mon, 11 Oct 2021 13:34:41 +0000
Message-ID: <A8DEBD07-FB45-4E4E-A2C3-7AF8B393B032@arm.com>
References: <cover.1633540842.git.rahul.singh@arm.com>
 <9bdca2cda5d2e83f94dc2423e55714273539760a.1633540842.git.rahul.singh@arm.com>
 <6752f2d3-171b-37f5-c809-82995a8f3f36@suse.com>
 <CEF7FFB0-779A-4F46-8667-6BCD9BA5CB6C@arm.com>
 <b735c2d3-1dbb-ce0a-c2fa-160d4c6938d3@suse.com>
In-Reply-To: <b735c2d3-1dbb-ce0a-c2fa-160d4c6938d3@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3654.120.0.1.13)
Authentication-Results-Original: suse.com; dkim=none (message not signed)
 header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: b3e9df3d-a861-4ed9-0662-08d98cbbe999
x-ms-traffictypediagnostic: DB7PR08MB3369:|AS8PR08MB6838:
x-ms-exchange-transport-forked: True
X-Microsoft-Antispam-PRVS:
	<AS8PR08MB68381ACEC12DFA8EEDBB0E089DB59@AS8PR08MB6838.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:10000;OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 efvdKWMSH+/hHUNZ5y/Rn57ew3oR/dj6eHyUys8qMtQhK7MgpGxkXHiXdz2DnfHtveUAkpOEignqtKcenX+pHWyT0PuLhf7qNLvQl/WGpDCL3lXo5gH+NzDksMxqJc+BRvmSjsdx44+geqpxB1sElAsR+cr/jZqW1MnvwfaMcJXTwGlkcMr7WPAk7VyTXcz/dgpAw+TcyEyNhAETcc608NBpsUUb9vs1FFn5zxnk9dPl2OH6XjCYpgYuRNw2/9N3/0SMky+kwRUPtb1UPMZshBKR4ew2jaKrBrbaadTobcAbyQ/Qga19vbuiCr/n+y+161m6YufC27AVy3Yiwf/HfbsTNVI3kQC6ep2k33nrrfF34XgeGeABdikKMg41KU4rT6eO0+U8a1+d1PiRMuZOzkCk7BagFWZKY2OSx5jtjVMq8Hryvx5u96iFGDqo2DrHvSGykrnEnfzDhS+YJZF2OJi0XVrWfuy7cm1No9PZPdWR7Wc1D060LTI9DkpCKFgIcR1FvKUWE12aaL1O8knS5FFlvoiMXc1tpKOpq7PkitmLMY2BnxT9W9ehUOI0jumgurflqjTBy0r5OUm7ytFsO0WGWLCj736fi/S4kjE66Dvwg96zwO1wEqQe+yMNjsdaqJ45CMYXcrZ1Ahwei7pcJB8WKnn2aiuV4cTbt0MDTeh0HACiWt8//Ya6QmWT/lPW/dqfPI4bs8B8lfWsb22rH22m+hXKtGRq3v7jgD4CLxWzIrU+6WqXzk71H9PBMhpSzo/wCTyLQkls4JZHsjO0ow==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB6PR0801MB2024.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(186003)(8676002)(6486002)(26005)(71200400001)(4326008)(91956017)(2906002)(54906003)(36756003)(76116006)(6916009)(122000001)(66476007)(38100700002)(66946007)(508600001)(66446008)(66556008)(38070700005)(64756008)(2616005)(83380400001)(33656002)(7416002)(5660300002)(53546011)(6506007)(316002)(8936002)(86362001)(6512007)(2004002)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="iso-8859-1"
Content-ID: <354CC74C8456E7498DBED2F78AB31E1A@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3369
Original-Authentication-Results: suse.com; dkim=none (message not signed)
 header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM5EUR03FT011.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	26ba0c5b-ec5d-4cdd-186f-08d98cbbe10a
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	WYfym34iWdsFjza+aPiuLC+tUjiBpDRN2Gj+Qg3BJsLHeFE/KoKuj8nezp4cYFxeKKYQHS4XCECk+6FCk+swKo/Zt2X2uBHfVGoePFqx8LSwtbNiX5PBFW7khA4ZC5RTi0qjsmZ/pqc7SDUhCThX1relSNjcO1ENUqmxHptzMA30PolqsJw9YABKRU1acoY+pt2ofny2Z02nMsYRxBHDec3vWsWLOZL9e1OSMMcTEJs3AQlAHh9Ob/0EoG4ICXm27Bj9Fyp/TGI+XprzN9VQtW3zUKu7O3zPIsuuDrtCA4e4822gDnXfUAH4/i7TFPWZdzXhUSwUcoHYXDAAfGMfsqjMCSK1SRLUdZ2BilgeONpxNW6SJJ5pK7w7cQeiAuRQiVNA6KSswSb9lf8w35hL1cuYGfa+pNziBfACx5cwfBFoSYjstm0TWYYM3UA9KvJ2WBhsqcjJjN1efeGm0t232gwemEIZcjTS1jUDKbeI7h19jaK3rWkaUUSfExiLbAxjRA7cc7kD8/Badu3bR7q7s1M44ZIxgVVd7KAN64xjzILopfX6Duaf6Acex72FpnNvHyxjRKXejAkatlUQQhd7kCLPG5H/jutKztJBB7hoOiOv/Uc9Io9Da6vWFpaf98o4yEzOV/X/ouaReJPv085+ukYW27MQ4407QZY15wJ4Fp7R4zTJN3sew5JBdCbyrSlnjbqUrfhcrBx94NaW3HG07Asdmy0Pqcg9aF1U2TVifwI=
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(2906002)(316002)(36860700001)(356005)(81166007)(4326008)(6862004)(82310400003)(33656002)(70206006)(86362001)(2616005)(70586007)(6486002)(336012)(6506007)(47076005)(53546011)(54906003)(6512007)(8936002)(186003)(508600001)(26005)(5660300002)(83380400001)(8676002)(36756003)(2004002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2021 13:34:55.4709
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: b3e9df3d-a861-4ed9-0662-08d98cbbe999
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM5EUR03FT011.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6838

Hi Jan,

> On 11 Oct 2021, at 14:09, Jan Beulich <jbeulich@suse.com> wrote:
>=20
> On 11.10.2021 14:41, Bertrand Marquis wrote:
>>> On 7 Oct 2021, at 14:43, Jan Beulich <jbeulich@suse.com> wrote:
>>> On 06.10.2021 19:40, Rahul Singh wrote:
>>>> --- /dev/null
>>>> +++ b/xen/arch/arm/vpci.c
>>>> @@ -0,0 +1,102 @@
>>>> +/*
>>>> + * xen/arch/arm/vpci.c
>>>> + *
>>>> + * This program is free software; you can redistribute it and/or modi=
fy
>>>> + * it under the terms of the GNU General Public License as published =
by
>>>> + * the Free Software Foundation; either version 2 of the License, or
>>>> + * (at your option) any later version.
>>>> + *
>>>> + * This program is distributed in the hope that it will be useful,
>>>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
>>>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>>>> + * GNU General Public License for more details.
>>>> + */
>>>> +#include <xen/sched.h>
>>>> +
>>>> +#include <asm/mmio.h>
>>>> +
>>>> +#define REGISTER_OFFSET(addr)  ( (addr) & 0x00000fff)
>>>=20
>>> Nit: Stray blank (like you had in an earlier version for MMCFG_BDF()).
>>> Also isn't this effectively part of the public interface (along with
>>> MMCFG_BDF()), alongside GUEST_VPCI_ECAM_{BASE,SIZE}?
>>=20
>> I will move that in the next version to xen/pci.h and rename itMMCFG_REG=
_OFFSET.
>> Would that be ok ?
>=20
> That would be okay and make sense when put next to MMCFG_BDF(), but
> it would not address my comment: That still wouldn't be the public
> interface. Otoh you only mimic hardware behavior, so perhaps the
> splitting of the address isn't as relevant to put there as would be
> GUEST_VPCI_ECAM_{BASE,SIZE}.

Ok now I get what you wanted.

You would actually like both MMCFG_BDF and MMCFG_REG_OFFSET to
be moved to arch-arm.h.

Then I am not quite sure to follow why.
Those are not macros coming out of a way we have to define this but from
how it works in standard PCI.
The base and size are needed to know where the PCI bus will be.

So why should those be needed in public headers ?

>=20
>>>> --- a/xen/drivers/passthrough/pci.c
>>>> +++ b/xen/drivers/passthrough/pci.c
>>>> @@ -766,6 +766,24 @@ int pci_add_device(u16 seg, u8 bus, u8 devfn,
>>>>    else
>>>>        iommu_enable_device(pdev);
>>>=20
>>> Please note the context above; ...
>>>=20
>>>> +#ifdef CONFIG_ARM
>>>> +    /*
>>>> +     * On ARM PCI devices discovery will be done by Dom0. Add vpci ha=
ndler when
>>>> +     * Dom0 inform XEN to add the PCI devices in XEN.
>>>> +     */
>>>> +    ret =3D vpci_add_handlers(pdev);
>>>> +    if ( ret )
>>>> +    {
>>>> +        printk(XENLOG_ERR "setup of vPCI failed: %d\n", ret);
>>>> +        pci_cleanup_msi(pdev);
>>>> +        ret =3D iommu_remove_device(pdev);
>>>> +        if ( pdev->domain )
>>>> +            list_del(&pdev->domain_list);
>>>> +        free_pdev(pseg, pdev);
>>>=20
>>> ... you unconditionally undo the if() part of the earlier conditional;
>>> is there any guarantee that the other path can't ever be taken, now
>>> and forever? If it can't be taken now (which I think is the case as
>>> long as Dom0 wouldn't report the same device twice), then at least some
>>> precaution wants taking. Maybe moving your addition into that if()
>>> could be an option.
>>>=20
>>> Furthermore I continue to wonder whether this ordering is indeed
>>> preferable over doing software setup before hardware arrangements. This
>>> would address the above issue as well as long as vpci_add_handlers() is
>>> idempotent. And it would likely simplify error cleanup.
>>=20
>> I agree with you so I will move this code block before iommu part.
>>=20
>> But digging deeper into this, I would have 2 questions:
>>=20
>> - msi_cleanup was done there after a request from Stefano, but is not
>> done in case or iommu error, is there an issue to solve here ?
>=20
> Maybe, but I'm not sure. This very much depends on what a domain
> could in principle do with a partly set-up device. Plus let's
> not forget that we're talking of only Dom0 here (for now at least,
> i.e. not considering the dom0less case).
>=20
> But I'd also like to further defer to Stefano.

Ok, I must admit I do not really see at that stage why doing an MSI cleanup
could be needed so I will wait for Stefano to know if I need to keep this w=
hen
moving the block up (at the end it is theoretical right now as this is empt=
y).

>=20
>> Same could also go for the free_pdev ?
>=20
> I think it's wrong to free_pdev() here. We want to internally keep
> record of the device, even if the device ends up unusable. The only
> place where free_pdev() ought to be called is imo pci_remove_device().

Ok.

>=20
>> - cleanup code was exactly the same as pci_remove_device code.
>> Should the question about the path also be checked there ?
>=20
> I'm sorry, but I'm afraid I don't see what "the path" refers to
> here. You can't mean the conditional in pci_add_device() selecting
> between iommu_add_device() and iommu_enable_device(), as "remove"
> can only mean "remove", never "disable".

I will try to explain: when we just enable we do not add an entry in the li=
st but
we still remove an entry from the list every time (as the condition becomes
always true because pdev->domain is at the end always set)

Regards
Bertrand

>=20
> Jan
>=20



From xen-devel-bounces@lists.xenproject.org Mon Oct 11 13:40:49 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 13:40:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.206019.361472 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZvXp-0002P5-SA; Mon, 11 Oct 2021 13:40:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 206019.361472; Mon, 11 Oct 2021 13:40:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZvXp-0002Oy-PC; Mon, 11 Oct 2021 13:40:45 +0000
Received: by outflank-mailman (input) for mailman id 206019;
 Mon, 11 Oct 2021 13:40:45 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=LfEM=O7=arm.com=Bertrand.Marquis@srs-us1.protection.inumbo.net>)
 id 1mZvXo-0002Os-W1
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 13:40:45 +0000
Received: from EUR05-AM6-obe.outbound.protection.outlook.com (unknown
 [2a01:111:f400:7e1b::602])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 6531b5c7-ea99-4718-8889-4718465a87f8;
 Mon, 11 Oct 2021 13:40:43 +0000 (UTC)
Received: from AS9PR06CA0107.eurprd06.prod.outlook.com (2603:10a6:20b:465::31)
 by VI1PR0802MB2237.eurprd08.prod.outlook.com (2603:10a6:800:9c::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.24; Mon, 11 Oct
 2021 13:40:40 +0000
Received: from AM5EUR03FT051.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:465:cafe::73) by AS9PR06CA0107.outlook.office365.com
 (2603:10a6:20b:465::31) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.24 via Frontend
 Transport; Mon, 11 Oct 2021 13:40:40 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM5EUR03FT051.mail.protection.outlook.com (10.152.16.246) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4587.18 via Frontend Transport; Mon, 11 Oct 2021 13:40:40 +0000
Received: ("Tessian outbound f1898412aff1:v103");
 Mon, 11 Oct 2021 13:40:39 +0000
Received: from 917aac7338e1.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 3F83C889-A021-403F-971B-25FE28202BA1.1; 
 Mon, 11 Oct 2021 13:40:32 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 917aac7338e1.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Mon, 11 Oct 2021 13:40:32 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com (2603:10a6:4:74::9)
 by DB8PR08MB4185.eurprd08.prod.outlook.com (2603:10a6:10:aa::22) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18; Mon, 11 Oct
 2021 13:40:30 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955]) by DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955%4]) with mapi id 15.20.4587.026; Mon, 11 Oct 2021
 13:40:30 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6531b5c7-ea99-4718-8889-4718465a87f8
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=8AKBK0dK2e3t5MfB3yBVn+q6e2oQupJVaYfNAHmraag=;
 b=3/5mj07tNMjkZnFbfoRs51TnylxnFUSGFSNkvNWqFC3gzUS4FCVdBp0LEzi3lLTWgjV1nafRxUxkPe/cpCMafqir2XrC9zO8PkM9NE5VPBmh8HHQH/uyHHL2Gn17/LblU7BX9Q4+3LWv1lqEPvcYfHPAlmMkH26brChVT1/2fFY=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 389d13e3fc50dd80
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=nZRj5fxKEAxDiaYYLFkAn2AJCXMrOu5B4pGBfjH2HAeYJxQbw13WehEJqmqowtn6LMKZdX5X6eu5aZK0NuAKlFDBarFfioi0K+HoT/peuyFwf/6GxkJx4xLlbzMilZ3HbU2xsi9Zb93IterEGt0BJwl4vpK4VXKrtiHvyDsCw/S3piMfRH2otNYXinz1OTt4TsDLNxXdwuuDuC0n5crFn5sJBXGaQocQyPVnUcceBmulLUYd5E6EFr09RpKkx7rEXBZJvPcpBLQdKYMfr3N8eY7wfZCM0w6NoTFLMrK0FKvVaWJbCkp8if76TuRoV4K8lO04C2PZu2qe5HYAll+PqA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=8AKBK0dK2e3t5MfB3yBVn+q6e2oQupJVaYfNAHmraag=;
 b=nKQUhubbhGN8XOiP3IxbfJ/ongaZBDb+hnA/CNTwYxIBdrIn9sz2TTd60NBJujw1dIkaxWeCubaxlurfa2ClhCyQf6vsaowMm9x+3+WJBbZ4c01IP4a7R3slRzOlHYZHiEQToDnzW0tLck1WjBy/7a17DcYZ0mACTa5pP1hmO4uR8A9d9NlDRqYi4Pfm4D2TIsP/Siy8icmans7aR6jMgYCe/LsRr2GxN2n4uVER167ia4jRhSFwwEDwpYPsxcInkeFZCKW6szb4jp1Y6rc7PFzDgIl3vA2FVbJKErLGigSRAfN1YfmJiaTKUuY9cLa8Bljg+9j5jHsFEuueCTBVEA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=8AKBK0dK2e3t5MfB3yBVn+q6e2oQupJVaYfNAHmraag=;
 b=3/5mj07tNMjkZnFbfoRs51TnylxnFUSGFSNkvNWqFC3gzUS4FCVdBp0LEzi3lLTWgjV1nafRxUxkPe/cpCMafqir2XrC9zO8PkM9NE5VPBmh8HHQH/uyHHL2Gn17/LblU7BX9Q4+3LWv1lqEPvcYfHPAlmMkH26brChVT1/2fFY=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>, Oleksandr
 Andrushchenko <Oleksandr_Andrushchenko@epam.com>
CC: Rahul Singh <Rahul.Singh@arm.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, Andre Przywara <Andre.Przywara@arm.com>,
	Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>, Juergen Gross
	<jgross@suse.com>, Stefano Stabellini <sstabellini@kernel.org>
Subject: Re: [PATCH v5 01/11] xen/arm: xc_domain_ioport_permission(..) not
 supported on ARM.
Thread-Topic: [PATCH v5 01/11] xen/arm: xc_domain_ioport_permission(..) not
 supported on ARM.
Thread-Index: AQHXutl5d8zkP9bsD0GXT4+5QPGclKvNtfkAgAAGc4CAABOEAIAABXoA
Date: Mon, 11 Oct 2021 13:40:30 +0000
Message-ID: <53AE6E2A-01D7-41EC-9B2C-C0D596EB8D4D@arm.com>
References: <cover.1633540842.git.rahul.singh@arm.com>
 <d292392268df2c74c4103a82ef917072643407a8.1633540842.git.rahul.singh@arm.com>
 <YWQkblfNMYEs6jI9@MacBook-Air-de-Roger.local>
 <77CF7FA5-C566-469E-B4A8-0400789890BB@arm.com>
 <YWQ6Nk3Jk+BqgkwZ@MacBook-Air-de-Roger.local>
In-Reply-To: <YWQ6Nk3Jk+BqgkwZ@MacBook-Air-de-Roger.local>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3654.120.0.1.13)
Authentication-Results-Original: citrix.com; dkim=none (message not signed)
 header.d=none;citrix.com; dmarc=none action=none header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: e849bd45-7d49-46ed-03bc-08d98cbcb6f8
x-ms-traffictypediagnostic: DB8PR08MB4185:|VI1PR0802MB2237:
x-ms-exchange-transport-forked: True
X-Microsoft-Antispam-PRVS:
	<VI1PR0802MB2237AB2147A8950B272C6A649DB59@VI1PR0802MB2237.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:10000;OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 RmX6hL5Ul31NlUQJmBF6OXXsTiVtGBVe155WzxI94pGFueXm/GIIFUFdzlzx7GPkRoRhJ0r6h1jbgnVf48mqNMWnd5Ph4YbOPNThrulUuBRoSqSQItBsCg1ESQEgGgaPSFaDw2gG0jsP11Riu9vAQICzZinTh7zPh4LWhkKaYfYXYaErmcWcIuymabI4bzUz+EGGGHKlvTdzgAZ+Y2zcYjrQaXHW4VUcVB/O0eko7RbJf8IXlzdFRQebSKmtqFBPvlAMVaJdRIaisKJVCd6sdSAZGqOyT0BjUNti8Tn7SY48OgeYKw5hHPENjXFx0qpInCSW5QRgB+hGHYFX1bnvcUmGJB7Nt4dsJFjtMRnE0EyjvXYJta26exWxIdUz8cZxranyp/xVRlqcWKt5B1diNJSqxXjr7m6rcG6MonNUCY4N5tUMAhPPQzO1LP1NALapiqlVCqatM30mdC4dCiooMujYcyR/zh/GfIFh1GlkkQDO4hu5p0fO2hU5eY80BPxsoi3Lzl8UKPVxPJiRwO4H8zu4Sy6yHLvwEoX0MBPejPRNUMqo86Cieb+YXzb7JFiNTck97RjgSoWyo3Hr6N1GAAEIkkxUXgqtKXRKhxUt2d1eeRTr3xEdl74h9XmrF5TmXXN06v/XYoMDdmoGk1nUBg4Zgk0WiF7WkNjZhCtA1RdCoHUng7CMp07dwRUa2cXb660C/27Rtv0MfENAuxSSnA1RfJh4bkJMHmO5O0x46Hx9g1UVj0nqTP/l8yp6CfC2
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB6PR0801MB2024.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(84040400005)(71200400001)(316002)(26005)(38100700002)(5660300002)(2616005)(110136005)(54906003)(4326008)(6512007)(33656002)(2906002)(186003)(66946007)(6506007)(66446008)(64756008)(122000001)(66556008)(66476007)(38070700005)(8676002)(86362001)(8936002)(53546011)(6486002)(76116006)(508600001)(36756003)(83380400001)(91956017)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-ID: <98FB70549B11CC4EB4FD85805D15E0C8@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB4185
Original-Authentication-Results: citrix.com; dkim=none (message not signed)
 header.d=none;citrix.com; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM5EUR03FT051.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	922445c7-539e-4d43-d55d-08d98cbcb14b
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	hLCAd9nIGQPHp7C0kaoFmUzkQAPTdfakj/vqqqdjNa5k/uyveTr826l/jGmhvZ32VWhZ4eNMFao7WVFZ8nqt+ybh3ITed3qB8TNUyJllt7JB0aGmKmHksOUrzoyCQgMvYmv31mQWWkX5g2o9CnjyZ0EJy7Ls6X07NVuCXYjw5H0x53rZkqHf3TqHU3LD0B4hq7CnS73wnjEA0dgzqO+lEgbXSjZ/7RfLN3kB+s//inlwda5Ax3rjT56Vj1Q05Mjy14q96a+OCiUjlo3Z2GxCo6GZ0ia9ayumWM2ZI/Pzh6n/DRmcgyHohT/ZzlIZkBKJ3UYNIU07xEZjBmXTB6jaOHXFAyFBKJki9KvFYK27c+fpB7M+WumceOjyVh7G+A8vrC8xPhZiH9ISl2fQNlxsxzmy5hResRD6hV4zQo4UOoJFVS7N7vtTERrUdtzW8jtYwvCVQp76GpjExpIcunhVSDYdNTuzl/K9EPbH2rsFBO/nn2oEnPIRTAL4PtRwNAEy3igL0VTK3sSr2Zeb4X/9zucCZKgZtD2FLQHF9DBggdUZae8AyOoW08Yx68no3Cl1sTMV2Ui4f6Xais5edbFYHAA1SxsVUgeTujL6GKpnkDDcQ8yY7rlliQBV9b2kZ0EBN4w7VqMTeybyz/V6OOmAs3TAjh8rGyrl9IOUeay9xuQ3nzkfYAGzeMdhh/1GOwpPchWiZ+ZEvNE/xFyaAkMXrw==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(84040400005)(36840700001)(46966006)(8676002)(70586007)(356005)(6512007)(81166007)(186003)(26005)(110136005)(54906003)(86362001)(47076005)(336012)(83380400001)(6506007)(36756003)(2906002)(508600001)(2616005)(107886003)(316002)(82310400003)(6486002)(33656002)(36860700001)(70206006)(4326008)(5660300002)(53546011)(8936002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2021 13:40:40.0483
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: e849bd45-7d49-46ed-03bc-08d98cbcb6f8
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM5EUR03FT051.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0802MB2237

SGkgUm9nZXIsDQoNCisgT2xla3NhbmRyIHRvIGhhdmUgYSBiZXR0ZXIgUENJIGV4cGVydCB0aGVu
IG1lLg0KDQo+IE9uIDExIE9jdCAyMDIxLCBhdCAxNDoyMCwgUm9nZXIgUGF1IE1vbm7DqSA8cm9n
ZXIucGF1QGNpdHJpeC5jb20+IHdyb3RlOg0KPiANCj4gT24gTW9uLCBPY3QgMTEsIDIwMjEgYXQg
MTI6MTE6MDRQTSArMDAwMCwgQmVydHJhbmQgTWFycXVpcyB3cm90ZToNCj4+IEhpIFJvZ2VyLA0K
Pj4gDQo+Pj4gT24gMTEgT2N0IDIwMjEsIGF0IDEyOjQ3LCBSb2dlciBQYXUgTW9ubsOpIDxyb2dl
ci5wYXVAY2l0cml4LmNvbT4gd3JvdGU6DQo+Pj4gDQo+Pj4gT24gV2VkLCBPY3QgMDYsIDIwMjEg
YXQgMDY6NDA6MjdQTSArMDEwMCwgUmFodWwgU2luZ2ggd3JvdGU6DQo+Pj4+IEFSTSBhcmNoaXRl
Y3R1cmUgZG9lcyBub3QgaW1wbGVtZW50IEkvTyBwb3J0cy4gSWdub3JlIHRoaXMgY2FsbCBvbiBB
Uk0NCj4+Pj4gdG8gYXZvaWQgdGhlIG92ZXJoZWFkIG9mIG1ha2luZyBhIGh5cGVyY2FsbCBqdXN0
IGZvciBYZW4gdG8gcmV0dXJuDQo+Pj4+IC1FTk9TWVMuDQo+Pj4gDQo+Pj4gV2hhdCBpcyB0aGUg
Y2FsIHRyYWNlIG9mIHRoaXMgZnVuY3Rpb24gYWN0dWFsbHkgb24gQXJtPw0KPj4+IA0KPj4+IEFG
QUlDVCBsaWJ4bCB3aWxsIG9ubHkgY2FsbCB4Y19kb21haW5faW9wb3J0X3Blcm1pc3Npb24gaWYg
dGhlcmUgYXJlDQo+Pj4gSU8gcG9ydHMgZXhwbGljaXRseSBkZWZpbmVkIGluIHRoZSBndWVzdCBj
b25maWd1cmF0aW9uLCBvciBpZiBhbnkgb2YNCj4+PiB0aGUgQkFScyBvZiB0aGUgUENJIGRldmlj
ZSBpcyBpbiB0aGUgSU8gc3BhY2UsIHdoaWNoIGlzIG5vdCBwb3NzaWJsZQ0KPj4+IG9uIEFybS4N
Cj4+IA0KPj4gUENJIGRldmljZXMgQkFScyBjYW4gYmUgaW4gdGhlIElPIHNwYWNlIGFzIHRoZSBQ
Q0kgZGV2aWNlcyBhcmUgbm90DQo+PiBBcm0gc3BlY2lmaWMuIFRoZXJlIGlzIG5vdCBpb3BvcnRz
IG9uIGFybSBzbyB0byBiZSB1c2VkIHRob3NlIGNhbiBiZQ0KPj4gaW4gc29tZSBjYXNlcyByZW1h
cHBlZCBhbmQgYWNjZXNzZWQgYXMgTU1JT3Mgb3IgYXJlIG5vdCBwb3NzaWJsZQ0KPj4gdG8gdXNl
IGF0IGFsbC4NCj4+IA0KPj4gQnV0IHRoZSBJTyBzcGFjZSBkb2VzIGFwcGVhciB3aGVuIEJBUnMg
YXJlIGxpc3RlZCBldmVuIG9uIEFybS4NCj4gDQo+IFVyZywgSSB3b25kZXIgd2hldGhlciB0aG9z
ZSBkZXZpY2VzIHdpdGggSU8gQkFScyB3aWxsIHdvcmsgY29ycmVjdGx5DQo+IHVuZGVyIEFybSB0
aGVuLg0KPiANCj4gSG93IGRvIHlvdSBrbm93IHdoZXRoZXIgdGhlIEJBUiBoYXMgYmVlbiByZW1h
cHBlZCBmcm9tIElPIHNwYWNlIGludG8NCj4gTU1JTz8NCg0KV2UgY2Fubm90LCBJIHRoaW5rIHRo
ZSBwbGF0Zm9ybSB3aWxsIGRlZmluZSBpZiB0aGlzIGlzIHRoZSBjYXNlIGFuZCB3aGVyZS4NCkBv
bGVrc2FuZHI6IEkgcmVtZW1iZXIgdGhhdCB0aGlzIHdhcyBkaXNjdXNzZWQgZHVyaW5nIHNvbWUg
b2Ygb3VyDQptZWV0aW5ncyBidXQgSSBoYXZlIG5vIGlkZWEgb2YgdGhlIGRldGFpbHMgaGVyZSwg
Y2FuIHlvdSBoZWxwID8NCg0KPiANCj4gSU1PIGluc3RlYWQgb2YgZmFraW5nIGEgc3VjY2Vzc2Z1
bCByZXR1cm4gdmFsdWUgZnJvbQ0KPiB4Y19kb21haW5faW9wb3J0X3Blcm1pc3Npb24gd2Ugc2hv
dWxkIGF2b2lkIHRoZSBjYWxsIGNvbXBsZXRlbHkgaW4gdGhlDQo+IGZpcnN0IHBsYWNlLCBzcGVj
aWFsbHkgaWYgd2UgbmVlZCB0byBpbnN0ZWFkIGlzc3VlIGEgY2FsbCB0bw0KPiB4Y19kb21haW5f
aW9tZW1fcGVybWlzc2lvbi4NCg0KQXQgdGhlIGVuZCB3ZSB3aWxsIG5ldmVyIGhhdmUgdG8gaXNz
dWUgdGhpcyBiZWNhdXNlIHRoaXMgd2lsbCBuZXZlciBiZSBhIG1hdHRlcg0Kb2Yg4oCcaW9tZW3i
gJ0gcGVybWlzc2lvbiBhcyB0aGVyZSB3b3VsZCBub3QgYmUgYW55IHdheSB0byBjdXQgb24gc29t
ZXRoaW5nIHVuZGVyDQp0aGUgcGFnZS4gSWYgdGhpcyBpcyB0byBiZSBzdXBwb3J0ZWQgb25lIGRh
eSwgaXQgd2lsbCBwcm9iYWJseSBoYXZlIHRvIGJlIGZ1bGx5IGVtdWxhdGVkDQp0byBrZWVwIHRo
ZSBpc29sYXRpb24uDQoNClJpZ2h0IG5vdyBvbiBhcm0geW91IGNhbiBqdXN0IG1ha2UgdGhlIG1v
cmUgc2ltcGxlIGFzc3VtcHRpb24gdGhhdCBpb3BvcnRzIGFyZQ0KanVzdCBub3Qgc3VwcG9ydGVk
Lg0KDQpSZWdhcmRzDQpCZXJ0cmFuZA0KDQo+IA0KPiBUaGFua3MsIFJvZ2VyLg0KDQo=


From xen-devel-bounces@lists.xenproject.org Mon Oct 11 13:47:03 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 13:47:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.206026.361483 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZvdh-00034G-JX; Mon, 11 Oct 2021 13:46:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 206026.361483; Mon, 11 Oct 2021 13:46:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZvdh-000349-G6; Mon, 11 Oct 2021 13:46:49 +0000
Received: by outflank-mailman (input) for mailman id 206026;
 Mon, 11 Oct 2021 13:46:48 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=pkLr=O7=citrix.com=roger.pau@srs-us1.protection.inumbo.net>)
 id 1mZvdg-000343-H7
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 13:46:48 +0000
Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 686020e6-ae60-4548-9b4e-0c6d0f24a50f;
 Mon, 11 Oct 2021 13:46:46 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 686020e6-ae60-4548-9b4e-0c6d0f24a50f
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1633960006;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=B8t0ixYVPVkaVzVY2VdPfDaRDmCt7M63oL1S89UzT2Q=;
  b=Ll8iRcPDFr1Dz2OcoHZXvJ14DMhHfVFjN5/dPfYPoQjFtnSR991W2M+M
   2cAk2wFRZEKGjySazz6rAFXK/SKscNCS0uMEO5BQGdA9m6BX9KUNI7wvS
   ZPjGmEv8LvGwBYLpne2l/djKg+HeXXHp/0kpkSRXm1aMzMt9k102ebZNt
   s=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: KRA2EFjecg4zrBHmsTtBDpvNIviIdVnpGnzZJyWF+uSursHHoPp5jqcxdXYVplI3ZzXG26MjtY
 WDK4ltzaCRPB4SlQs4bavmm/n0flk14whtxJb6nahqAW/RMHnyPGaFPpee1ZSEP2uvztmEv/0t
 UjrsE/W9R1qkryeiy8SFKF4Jy1YqGuKDzNHAA5KBEiy8UG+bE6zL7M46rOZHq66RTTu86BbKtD
 ChYW6kVAbTqzyxrlNUX/OLQpAiA1yWZMR+gUfSxGAiH24lR4mhKzjiqzTkSRaZgk9AYra5ptqF
 4hVnOEtfR/ix2VvMRXM9OGAa
X-SBRS: 5.1
X-MesageID: 54859522
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:IZgBzaBtoujR8hVW/1flw5YqxClBgxIJ4kV8jS/XYbTApD0n1DUBn
 GVOCGmDPv6CazD8etogPNuw9kMGu5fcxoRrQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA
 xA2M4GYRCwMo/u1Si6FatANl1ElvU2zbue6WLOs1hxZH1c+EX550Es7wobVv6Yz6TSHK1LV0
 T/Ni5W31G+Ng1aY5UpNtspvADs21BjDkGtwUm4WPJinj3eH/5UhN7oNJLnZEpfNatI88thW5
 Qr05OrREmvxp3/BAz4++1rxWhVirrX6ZWBihpfKMkQLb9crSiEai84G2PQghUh/tBG5u/dYw
 e525cKxThwPZaLNmMYPXEwNe81+FfUuFL7vJHG+tYqYzlHccmuqyPJrZK00FdRGoKAtWzgIr
 KFGbmBWBvyAr7veLLaTUO5ji95lNMD2FIgepmth3XfSCvNOrZXrHvmauI4Fhm1YasZmLcz6P
 +g0VDFWYT+RSR4WBU06OMN5g7L97pX4W2IB8w/EzUYt2EDMyCRh3b6rN8DaEvSjQ8lPkwCgv
 HDX4G3jCzkTLtnZwj2AmlquifXIhjjTQ58JGfuz8fsCqGOUwmsfGRgHT2yRqPOyilO9c99HI
 klS8S0rxYAp71CiRNT5Wxy+oVaHswQaVt4WFPc1gCm3w6rJ50CiB24LThZIctlgv8gzLRQry
 V2hj97vHSZosrCeVTSa7Lj8hTGvPSkYK0cSaClCShEKi/HJrZsvlBvJQpBGGbSsk9zuMTjqx
 naBqy1Wr6Uei4sH2ru2+XjDgimwvd7ZQwgt/ALVU2m5qARja+aYi5eAsAaBq6wadcDAEwfH7
 CNsd9WiAP4mMrW9sAukSd42TO+o4O2jazLdgXx9EMx0n9iywEKLcYdV6TB4AU5mNMcYZDPkC
 HPuVRNtCIx7ZyTyM/cmC26lI4Fzl/K4TIW6PhzBRoMWOsAZSeORwM15iad8NUjWm08wjbp3B
 56fdcu9ZZrxIfU6lGToLwvxPLlC+8zf+Y8xbcyrp/hE+eDHDJJwdVvjGAHTBgzexPnVyDg5C
 /4Fa6O3J+x3CYUSmBX//48JNkwtJnMmH53woME/XrfdeVE2STl+UqaNn+hJl2lZc0J9zb2gE
 paVAB4w9bYCrSefdVXiho5LOdsDoqqTXVpkZHdxbD5EKlAoYJq17bd3SnfEVeJPyQCX9tYtF
 6NtU5zZWpxnE22bkxxAPciVhNEzL3yD2FPRVxdJlRBiJvaMsSSSoYS6FuYunQFTZheKWTwW+
 uX6iFyAG8ZfHmyPzq/+MZqS8r94hlBE8MpaVErUONhDPkLq9YlhMSvqifErZcoLLH3+KvGyi
 2562D8U+rvApZEb6t7MifzWpoulCbImTEFbA3Pa/fC9MiyDpjivxopJUeCpezHBVTyrpPX+N
 LsNl/ysYucamFtqspZnF+o5x6wJ+Nay9aRRyR5pHSuXYg3zWK9gOHSPweJGqrZJmu1CoQKzV
 0/WootaNLyFNdnLClkUIAZ5PO2P2etNwmvZ7OgvIVW87yhypeLVXUJXNhiKqSpcMLoqb991n
 bZ/4JYbslXthAArP9CKijFv216NdnFQAb86spw6AZPwjlZ5wF91fpGBWDT954uCaosQPxByc
 COUnqfLm59V2lHGLygoDXHI0OdQ2cYOtRRNwANQLliFgIOY1Po+3RkX+jUrVAVFiB5A1rsra
 GRsMkR0I4SI/itp25cfDzz9RVkZCU3L4FH1xnsIiHbdHhuhWWH6JWEgPfqAoRIC+GVGczkHp
 LyVxQ4Ji9oxkB0dCsfqZXNYlg==
IronPort-HdrOrdr: A9a23:gScBX6n722zTl3HxyMNouY/0jQzpDfO3imdD5ihNYBxZY6Wkfp
 +V88jzhCWZtN9OYhwdcLC7WZVpQRvnhPlICK0qTM2ftWjdyRCVxeRZg7cKrAeQeREWmtQtsJ
 uINpIOdeEYbmIK8/oSgjPIaurIqePvmMvD5Za8vgZQpENRGtldBm9Ce3mm+yZNNW977PQCZf
 6hDp0tnUvdRZ1bVLXwOlA1G8z44/HbnpPvZhALQzYh9Qm1lDutrJr3CQKR0BsyWy5Ghe5Kyx
 mIryXJooGY992rwB7V0GHeq7xQhdva09NGQOiBkNIcJDnAghuhIK5hR7qBljYop/zH0idmrP
 D85zMbe+hj4XLYeW+45TPrxgnbyT4rr0TvzFeJ6EGT6PDRdXYfMY5slIhZehzW5w4Lp9dnyp
 9G2Gqfqt5+EQ7AtD6V3amIazha0m6P5VYym+8aiHJSFaEEbqVKkIAZ9ERJVL8dASPB7pw9Gu
 UGNrCT2B9vSyLYU5nlhBgs/DT1NU5DWytuA3Jy9fB96gIm3EyQlCAjtYgidnRpzuNKd3AL3Z
 WCDkzE/Is+O/P+VpgNd9vpd/HHfVAlcSi8QF56Hm6XZp3vG0i946Ifs49Fr91DRvQzve8Pcd
 L6IRVliVI=
X-IronPort-AV: E=Sophos;i="5.85,364,1624334400"; 
   d="scan'208";a="54859522"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Wy0Q7qV0Lt08yPyZCzWD4yKAguiporv9nzckH0hzqVtS1PaiitDf8Qb1nzin/ntEwuQAtyuzJC0dtAN7jvnHSWbps0nTnBUBKvfeKgD8kdChiMl+3dGm39AfECRjkSAE0M3SXYCdG5MsvmHberdhNAobgidBvsemyAH9dgoMcmTYHvevUSEUyz0h3UcRopIBkoYZttTG0Z5/q6w+EAeQhtZllYTl9Ia4CqutciM9a87b3zAjoRfOTW9i+x8zAaUcXVpWeJJkYdsi3QFycMpU+8T6Sb5T/tkEGaUecvWdLr/3kwXD9+7tqN6ih81WnMOuZ3OMBYHiypsX+jnoRmLe0g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=HT7gJfsCPOMGqFHw1s6BZbpetYt+I7JHu1N0hi6eXdY=;
 b=hFk6mXGSCTvR4/qpaT4d3n0NpRaNcH7mymOAv0XIjiCmRWTNKqsnZutF3k5i8U8fwBB0vMQ2Ze1Siv5JUxFc+8RsfC+3afr4nSj4w3jiVS6LNgB2yoS+p+NetgjRFAB4P2ZW+wvJf1uqTR2Cf2aGQIYETRsht4PsSfOgGaFdqriX2GvffzXcY9K7pOITaIcc0GTgEZONT7VBl4SSHmkAhED3DDu9t7RzyMOS6RdbATCu56h0TmRgFRzhxNB/531RLsegHt+IUGGnBghnxIpsvwdvgoIXkK0Yy9UXZQkKtaI4oZ03uAZTzRJssaLjflbTlBYSy//F4GlX0xNAhODrMg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=HT7gJfsCPOMGqFHw1s6BZbpetYt+I7JHu1N0hi6eXdY=;
 b=ViZgAtKzhLpWk6pgyUPn6tc+jcG+OxFvDzJfsBAt0DVvhQ+bs3keozGMNJG9zgzu3KJFwXeAAESlL0FiPRBQtDHf/jXzzbAg13FCDpg57Rni94itNQv18HtFWC3mEkWnHflIQWHcaH8AiK2JIC8tatpk74Qmf3vZbOp04y/ztbc=
Date: Mon, 11 Oct 2021 15:46:21 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Ian Jackson <iwj@xenproject.org>
CC: Rahul Singh <Rahul.Singh@arm.com>, Julien Grall <julien@xen.org>,
	xen-devel <xen-devel@lists.xenproject.org>, Bertrand Marquis
	<Bertrand.Marquis@arm.com>, Andre Przywara <Andre.Przywara@arm.com>, Wei Liu
	<wl@xen.org>, Anthony PERARD <anthony.perard@citrix.com>, Juergen Gross
	<jgross@suse.com>, Stefano Stabellini <sstabellini@kernel.org>, Volodymyr
 Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH v5 10/11] arm/libxl: Emulated PCI device tree node in
 libxl
Message-ID: <YWRALXliogoE/JTA@MacBook-Air-de-Roger.local>
References: <cover.1633540842.git.rahul.singh@arm.com>
 <b81b5dea800c8fe47071f3dbd20588b1e472fb99.1633540842.git.rahul.singh@arm.com>
 <7bdac405-a889-15e1-be19-5876f7253855@xen.org>
 <24926.53690.621007.507249@mariner.uk.xensource.com>
 <294BE20A-7E45-405C-BC19-C292295E85E3@arm.com>
 <24927.7235.736221.270358@mariner.uk.xensource.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <24927.7235.736221.270358@mariner.uk.xensource.com>
X-ClientProxiedBy: LO4P123CA0096.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:191::11) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 0f2c92a2-17d4-41b0-5960-08d98cbd85ec
X-MS-TrafficTypeDiagnostic: DM6PR03MB4970:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <DM6PR03MB49705BA8AF3F881A35A13C3B8FB59@DM6PR03MB4970.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: xVwlIZfVIuJzfDUh93NKDwzhI/7cktNljz/BUSsIE9l81KndIri69urhiXR9xySblVc+dTcS4SjtJ4sLz+Zj3PBc40XMe7LlzZ8+PN0tDAXD4rF8t/nPuj5oLt9zRUBv1dls4dU0tmhwEfr/ya8MaZ4Yr/EKP2kA8yMFvlnDO6wjPDnL6FOWH+tO3ZGFJLw2FYwCvXamGPpQotgX42WOXC4qp15D7hL143M1mlzYCaaNDEyH32och5VnZ+PglKWDiyUS9p5qUUWIiiNOM+/1XalQfsQgCEqB8PoXp+iGHyboLXBbDUfY75Iu7PYl7s/c3/OYsSE9f0ZnBEET9iUIxnK+juBBhDjxdmrFByLxMPQ7ptTAtdVFErVxxd1LowBK2+WQ2shjqw4GlfC6roOPR6NlfBOUYpAWJhOnAsPOakX78H3uHVQPy3hFEVhtXursyU0AKNa6Xy7gvUj8y0jQi54M5dJI0V4c18X9YwHaIeLG1xEn3s79/h21SK27n8AaaQJkJUq7N4qyS3KC3txSTorb6YMlPQKgU+FtpqFSFweyYh0LuXQFDIaO/8Vp+UT75w7mT7RkeVRlBlGZN9hRjSkGuHRfYyAtCvg67mKG5MG0Z2Ve3quXf5mzOAYgVVG3BeIBtbMh4gaSh4xTnOFWAg==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(2906002)(6916009)(7416002)(86362001)(4326008)(26005)(66476007)(66556008)(9686003)(5660300002)(6486002)(66946007)(508600001)(38100700002)(6496006)(316002)(6666004)(85182001)(8676002)(186003)(54906003)(8936002)(956004);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QVU0c2pDT2lWZFhibThMU1NYeFZlUUVCaXFiaEpsWGJZcXRaNWFKdEVaN0p0?=
 =?utf-8?B?ZjE2RW04MnEzRlZHVURTVmo2RW1xclc2U2EramVLRG1mQ0QyQVFwUUNEcjFV?=
 =?utf-8?B?bllTdWJDWUFET2xJdUpNa1VNcEcrdXdhWDRnL1I2ekVJT1dtc0xSTW1tVFJr?=
 =?utf-8?B?U1gyRFpCSnF1bzZlVGJobVgrem41S09wQUcyZStOUTNKMlo5VElzeDArQlpu?=
 =?utf-8?B?WkdFMlY1YU5YRDhZa016R0lWOUNwNDZzVHhaQkZ1bDMzYXI5bmhnV01iR0NX?=
 =?utf-8?B?K2thVnFzWkVPaGU2TVdIdVdJZm9SME01Yk9lS2ZmUEpUakV5d29jVjlpZi9Q?=
 =?utf-8?B?LzRHZE5wY0VESTZEOWVXM2xtQ3lQZGJqaEZibnp6eGlaeVBPVXhNMzhlZFh6?=
 =?utf-8?B?bzNmTG4xWmZEa1RNYzFuK0F4dHFmKzdKWjJUczNXWkZyNHdhRmJINGRnZG1k?=
 =?utf-8?B?OWs4ck5rUVQyVHRQZjUyelUyS2l5blRpUXdZdDg2YnozQWQ5N3hOY3ZraHNK?=
 =?utf-8?B?ZXVEdVJwaHUrem5DVnJENXQ3eWNHdUVTMGhLOGduS1hNYmxDejYwQzJ2ajdi?=
 =?utf-8?B?VU1wS3lkV3VCYVhKei93Z2pabDRUd0ZON21YQXVBN20yRitDbHBOVzN4VXRQ?=
 =?utf-8?B?R0ZIVUJuL2xoTzJqajQzVzMxdEY3VFdHY1JvMGpmb0p5anBFQzNNdi9MTnNi?=
 =?utf-8?B?TXVQTlpHaUwrcXFuK0NRN0drbXZhWkZqUmhoc0JwaFNRMEhQYS9wUEpQVk01?=
 =?utf-8?B?SDhEejhhQkJERVIwclVZTktOY0RCNTB0S1l0d0dZY0xkZUYzcUtUcE1FWVRP?=
 =?utf-8?B?bDBkTTlCNFBSQmZRV3ZYMGtqV1d3SDJQdHB5VGkrc2ZkMUMvK2NmZUoySVQv?=
 =?utf-8?B?dUs5MjA4RndlYXA4SXJOUklYZlowbUMrcktOSGtsaktsZFpuNW9DUUVqY1dj?=
 =?utf-8?B?ZVZGWlRzanl5d0kreWRZWTE4SDV5RkdGRjFvRGpYNVR1WFlzWmx4dE1pVXV4?=
 =?utf-8?B?NDd4Z1N4dlZLSi92bHVjTU1FVFpHcG5jVTJQaXMxSEp1VGpsdUxnLzN0Njg4?=
 =?utf-8?B?dnFSU09JVGo0TU1YVGI3TlFMZklWdmtGNVJScHQwcTZselBaZDJyRkFhMHVJ?=
 =?utf-8?B?TjlZK1Z5QWRVRGhBdCtXbUhjcm5oZTRTZXYxZThSdW5JdHJ4UmxWMUE3VWVN?=
 =?utf-8?B?Q0FnS1FQR3dwTXkwOVdDWkRuZHZiZkt6SUtxVHpDSEpoMzlnWFNhL1BzdFVQ?=
 =?utf-8?B?dzhZVDRXSWNWaEQwZmplaHp6U0ZqakNkbXhQUjBCaFBZY1BYRkZMd3VlOWtE?=
 =?utf-8?B?bEp0MEVsMWt6YWxYejBFVmM4QnQvWUF2bmtNNW9mQUhxbDc1UU8vaGJPbjIw?=
 =?utf-8?B?YlZZZ3FETTFURGFweWtMUkN0YlhDcFc2WlVEWGxuZm1iWk1lQlpMWTQrZngr?=
 =?utf-8?B?OU1DeWhYQ1JRNkRVOUw1d3hWZHNrY2t6Zm5ZVlhpdnpTQWFQc3pkVTNDbGlF?=
 =?utf-8?B?Nk1mT2dxeXFGZmxFb29OenhwQ2VPNldnMkhPYjVvMVgwaWJnTnE0NE0xSmxX?=
 =?utf-8?B?dkpjbXExUzRUbmNmK2hpQTZqYlZuTUVic1M0Q3M2blZvK0c5bjFaZGJLNzY0?=
 =?utf-8?B?b0Nud2xjeERIL2ZDSGhRZ1pocVV6RDB5aGhITUJ5dTFJMVY2T3dZdlVwODlK?=
 =?utf-8?B?cmVTUFJZTkRMZXErSkZFRGRWZjFmWWVSS0xWRGY5K3BjeDVJdmlXRi9XV054?=
 =?utf-8?Q?Itbrfjh0CP3Vw8Dxw8w6VdavtHJYIPKMLP1Sl31?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 0f2c92a2-17d4-41b0-5960-08d98cbd85ec
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2021 13:46:27.5153
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: RFRhbVSU8K2+U1ozT+nba1+CQC0e/2Wjzccwj1vAX/lwN9m2DHTJktaT/VTMui2/FlYizpmnQDFxH10nNLmQeA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4970
X-OriginatorOrg: citrix.com

On Thu, Oct 07, 2021 at 05:11:47PM +0100, Ian Jackson wrote:
> Rahul Singh writes ("Re: [PATCH v5 10/11] arm/libxl: Emulated PCI device tree node in libxl"):
> > As Stefano suggested in another email that we can remove the vpci
> > option, if we reach to conclusion that we need vpci option I will
> > move it to internal structure.
> ...
> > Yes I agree with you VPCI is necessary for hot plugged PCI device
> > and once we implement the hotplug in future we will use the
> > passthrough= option to enable VPCI.
> 
> So, to summarise, I think the situation is:
> 
>  * VCPI is necessry for passthrough on ARM, whether coldplug or
>    hotplug.  It's part of the way that PCI-PT works on ARM.
> 
>  * Hotplug is not yet implemented.
> 
>  * VPCI is not necessary on x86 (evidently, since we don't have it
>    there but we do have passthrough).
> 
> So when hotplug is added, vpci will need to be turned on when
> passthrough=yes is selected.  I don't fully understand the other
> possible values for passthrough= but maybe we can defer the question
> of whether they apply to ARM ?
> 
> I think that means that yes, this should be an internal variable.
> Probably in libxl__domain_create_state.  We don't currently arrange to
> elide arch-specific state in there, so perhaps it's fine just to
> invent a member called `arm_vpci`.

Seeing as we might want to also use this on x86, I wonder whether we
should allow to specify a backend to use for each passthrough device,
ie:

pci = [ '36:00.0,backend=vpci',
        '36:01.0,backend=qemu',
	... ]

In principle we should support different backends on a per-device
basis, albeit if not currently possible.

Iff we have to introduce a new struct member for vPCI it should be
shared between all arches, as it's likely x86 will also want to at
least have the option to use vPCI for passthrough.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Mon Oct 11 13:57:39 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 13:57:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.206037.361494 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZvo7-0004Xz-Lg; Mon, 11 Oct 2021 13:57:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 206037.361494; Mon, 11 Oct 2021 13:57:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZvo7-0004Xs-GG; Mon, 11 Oct 2021 13:57:35 +0000
Received: by outflank-mailman (input) for mailman id 206037;
 Mon, 11 Oct 2021 13:57:33 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=rMo6=O7=citrix.com=anthony.perard@srs-us1.protection.inumbo.net>)
 id 1mZvo5-0004Xg-P7
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 13:57:33 +0000
Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 2dfaa331-2a9b-11ec-80dd-12813bfff9fa;
 Mon, 11 Oct 2021 13:57:32 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2dfaa331-2a9b-11ec-80dd-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1633960652;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=m4JmGSHnjUE9wVUM9KfqBA9lRy8EvSMhBMK2Cn3fR7c=;
  b=ISLnSEu4ID+x8u/wx//LYymEzAP00+9l8gzZoslQQQTB69Uz7REkMM2P
   ezD4aPXUPJdzvSmSZtCVrpv0zsDm4JEKlApZ7b69b85sRU3FSns0q9fxU
   lG8TVDchGMTMVjGF7lgBjsFxGqqY234mTlYR2ttr8hszWSRsbFNYla1ld
   w=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: 0FYsQRq4mrxEbaELJzw6eZQpr0MaYYITmMWY+gI02W7NXPBjtjKSBrdGj2gtuaGifN4xIrM5z3
 wv38rOBZDWupKmZpdYjctW0mLDdVkco67sd10DW9xW9/0fI0/Zg0ad/eRVeqichFgmxKg9VViS
 0GKnUs/2qcXVpGgPwBumDr2Y5tQ+EqEpFtwskQ2/7A4DKkfZt+pTmMcbtdrXdQ+aYkntyAt6MY
 f343qnCHqxX+2EuZCQtEnLrObslKz/VKfs6gXYFqwmIh3e320PxhwhsE2TuTi68sBIqxhk1tL7
 s/VHyPKshq7OI1N0t3snWudr
X-SBRS: 5.1
X-MesageID: 54880359
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:c2u4+axxT5gTBboNeIN6t+efwCrEfRIJ4+MujC+fZmUNrF6WrkUDn
 2scXWnXMqmPZ2Onfoh+bYiwpkpXvJDUyd4ySAc+qyAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx
 59DAjUVBJlsFhcwnvopW1TYhSEUOZugH9IQM8aZfHAsLeNYYH1500s6w7dg2tcAbeWRWGthh
 /uj+6UzB3f9s9JEGjp8B3Wr8U4HUFza4Vv0j3RmDRx5lAa2e0o9VfrzEZqZPXrgKrS4K8bhL
 wr1IBNVyUuCl/slIovNfr8W6STmSJaKVeSFoiI+t6RPHnGuD8H9u0o2HKN0VKtZt9mGt/0o+
 ethnpiTcERzYbPRgsgzXlpFLj4raMWq+JefSZS+mcmazkmAeHrw2fR+SkoxOOX0+M4uXzsIr
 6ZBbmlQMFbT3Ipaw5riIgVors0lMMnsOpJZonx6xCvVJf0nXYrCU+PB4towMDIY25weTa6FO
 ptxhTxHXhXMXzNsKnktJo8e2931hH78LjFlkQfAzUYwyzeKl1EguFT3C/LKfvSaSMMTmVyXz
 krd5HjwCBweMN2ZyBKG/2iqi+uJmjn0MKobFaax9/pjqFeS2mAeBhAQWVah5/K+jyaWR9taI
 lc85ikqoK495UGvCNL6WnWQomOAvxMac8pdFas98g7l4q7J4A+CFC4ERyFbedgls+cyRDo3x
 hmImc/kAXpkt7j9YWKQ8PKYoC2/PQARLHQefmkUQA0d+d7hrYovyBXVQb5LEbG3ps34Hynqx
 DKHpzR4gK8c5eYT3ri/1UDKhXSrvJehZgwo4EPRV2Gs7AJ8baakYZCl7R7Q6vMoBI2eSF+Gv
 nQNhcmFxO8LBJCJ0ieKRY0lHruk+vKEOz30mkN0Et8q8DHF032uY4FWpi1/LUFBM8AYdDuva
 0jW0StY4J5IIHKrd+l5eYu3AMUx5bfsHpLuUfW8RuRJZp99ZQqW5hZEbESb333uuEU0mKR5M
 pCeGe60FXcAAq1jxTCrb+0czbMmyC04yW7JA5v8ynyP272Ubm+YUrcBPV6HaMg26aqFpEPe9
 NM3H8iNzQ9WXKvhYy3U2YkJJFsOID4wApWeliBMXrfdeEw8QjhnUqKPh+N6E2B4o0hLvsqRz
 0+RcUt78Rml2mPaMymkZzN+Vay6CP6TskkHFSArOF+p3V0qboCu8LoTevMLQFU3yABw5aUrF
 6ddKq1sFtwKE26do21MMvERuaQ7LEzz7T9iKRZJd9TWk3RIfAfO5sP/NjXm8C0DH0JbXuNv/
 uX+iGs3rXcFLjmO7fo6itrznztdXlBHwYqeunckxPEJJS0AF6AwekTMYgcfeZ1kFPk67mLyO
 /yqKRkZv/LRhIQ+7cPEg6uJx6/wTbAlThsCQDCCsejtXcU/woZF6dQaOApvVWqMPF4YBY34P
 bkFpx0CGKxvcKl2X3pUTO8wkPNWCyrHrL5G1AV0dEgnnHzwYo6M1kKuhJEV3oUUn+cxkVLvB
 iqnp4kLUZ3UaZiNOANAe2IYghGriKh8ds/6tq9ufi0XJUZfodK6bKmlF0DU0nICd+EpbNpNL
 CVIkJd+1jFTQyECar6u5h24PUzXRpDZe6l45JwcHqHxjQ8nlgNLbZDGU3ek65CTcdRcdEItJ
 2bM1qbFgr1dwGvEcmYySieRjbYM28xWtUAY1kIGKnSIhsHB2q090ipO/GllVQ9S1BhGjb5+Y
 zA5K01vKKyS1D50n8wfDXu0EgRMCUTBqEz8wlcEjkPDSEysWjCfJWExI7/VrksY73hdbn5Q+
 7TBkDTpVjPjfcfQ2CouWBE696y/HIIprgCbwZKpBcWIGZU+cAHJuK72aDpasQbjDOMwmFbD+
 btg8tFvZPCpLiUXuaA6VdWXjOxCVBCeKWVeavh956dVT3rEcTS/1DXSeUC8fsRBe67D/UOiU
 pE8I8tOU1K11TqUryBdDqkJeucmkPks7dsEW7XqOW9Z7OfP8ms36MrdpnrkmWsmY9RyisJse
 IreegWLHnGUmXYJyXTGq9NJOzbgbNQJDOEmMDtZLAnd+0o/jdxR
IronPort-HdrOrdr: A9a23:DzMfjKhlNt9cuhrq/fhnisfsXnBQXtgji2hC6mlwRA09TySZ//
 rOoB0+726StN9xYgBFpTnuAsW9qB/nmqKdpLNhW4tKPzOW3VdATrsSjrcKqgeIc0aVm9K1l5
 0QEZSWYOeAdGSS5vyb3ODXKbgd/OU=
X-IronPort-AV: E=Sophos;i="5.85,364,1624334400"; 
   d="scan'208";a="54880359"
Date: Mon, 11 Oct 2021 14:57:14 +0100
From: Anthony PERARD <anthony.perard@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Paul Durrant <paul@xen.org>, Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
	Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wl@xen.org>, Tamas K Lengyel <tamas@tklengyel.com>, Alexandru Isaila
	<aisaila@bitdefender.com>, Petre Pircalabu <ppircalabu@bitdefender.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, Konrad Rzeszutek Wilk
	<konrad.wilk@oracle.com>, Ross Lagerwall <ross.lagerwall@citrix.com>, "Bob
 Eshleman" <bobbyeshleman@gmail.com>, Alistair Francis
	<alistair.francis@wdc.com>, Connor Davis <connojdavis@gmail.com>, Roger Pau
 =?iso-8859-1?Q?Monn=E9?= <roger.pau@citrix.com>, Jun Nakajima
	<jun.nakajima@intel.com>, Kevin Tian <kevin.tian@intel.com>, Lukasz Hawrylko
	<lukasz.hawrylko@linux.intel.com>, <xen-devel@lists.xenproject.org>
Subject: Re: [XEN PATCH v7 14/51] xen: move include/asm-* to
 arch/*/include/asm
Message-ID: <YWRCumOjPlYD1sE6@perard>
References: <20210824105038.1257926-1-anthony.perard@citrix.com>
 <20210824105038.1257926-15-anthony.perard@citrix.com>
 <320e5dde-2017-2420-8323-cbe4c2f0914f@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <320e5dde-2017-2420-8323-cbe4c2f0914f@suse.com>

On Thu, Oct 07, 2021 at 04:17:28PM +0200, Jan Beulich wrote:
> On 24.08.2021 12:50, Anthony PERARD wrote:
> > --- a/tools/include/Makefile
> > +++ b/tools/include/Makefile
> > @@ -30,7 +30,7 @@ xen-dir:
> >  	ln -s $(XEN_ROOT)/xen/include/acpi/platform acpi/
> >  	ln -s $(XEN_ROOT)/xen/include/acpi/ac*.h acpi/
> >  ifeq ($(CONFIG_X86),y)
> > -	ln -s $(XEN_ROOT)/xen/include/asm-x86 xen/asm
> > +	ln -s $(XEN_ROOT)/xen/arch/x86/include/asm xen/asm
> 
> I think this would now better be
> 
> 	ln -s $(XEN_ROOT)/xen/arch/x86/include/asm xen/
> 
> matching what is visible in context.

I'll change it.

> > --- a/xen/arch/riscv/arch.mk
> > +++ b/xen/arch/riscv/arch.mk
> > @@ -12,3 +12,4 @@ riscv-march-$(CONFIG_RISCV_ISA_C)       := $(riscv-march-y)c
> >  
> >  CFLAGS += -march=$(riscv-march-y) -mstrict-align -mcmodel=medany
> >  CFLAGS += -I$(BASEDIR)/include
> > +CFLAGS += -I$(BASEDIR)/arch/$(TARGET_ARCH)/include
> 
> I find it odd that this needed repeating in every arch.mk. Can't
> this be done once for all arches?

I actually do that much later in the series with patch "build: Add
headers path to CFLAGS once for all archs".

> > --- a/xen/common/page_alloc.c
> > +++ b/xen/common/page_alloc.c
> > @@ -241,7 +241,7 @@ PAGE_LIST_HEAD(page_broken_list);
> >  
> >  /*
> >   * first_valid_mfn is exported because it is use in ARM specific NUMA
> > - * helpers. See comment in asm-arm/numa.h.
> > + * helpers. See comment in asm/numa.h.
> >   */
> >  mfn_t first_valid_mfn = INVALID_MFN_INITIALIZER;
> 
> I'm afraid that in this case it is relevant that it's Arm's header,
> like ...

Will fix.

Thanks,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Mon Oct 11 13:57:39 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 13:57:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.206038.361498 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZvo7-0004bb-T7; Mon, 11 Oct 2021 13:57:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 206038.361498; Mon, 11 Oct 2021 13:57:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZvo7-0004a2-Oo; Mon, 11 Oct 2021 13:57:35 +0000
Received: by outflank-mailman (input) for mailman id 206038;
 Mon, 11 Oct 2021 13:57:34 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=pkLr=O7=citrix.com=roger.pau@srs-us1.protection.inumbo.net>)
 id 1mZvo6-0004Xm-4i
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 13:57:34 +0000
Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 28f87a94-f6c2-4bdc-ae05-aba2611f8aed;
 Mon, 11 Oct 2021 13:57:33 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 28f87a94-f6c2-4bdc-ae05-aba2611f8aed
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1633960653;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=9bjk6dE1Nz+mYAsLuuE9x4KnANKe1N2GxtK0dBcJxwY=;
  b=EbLm/rIdAIOX5QDl53AdxUFVMyweH0SOfgTMrUdMpuAwP76AI/pq9Cg5
   0wBN9eWGvQJz0XkramIWWbbaEG70HoT1LorREkqb/xBEUw9b4MTsYy7M/
   S+8QJdDgsb+OwvE1btq0u7vDBgPPZGKLDZjB67u37nwcKHnHhEPM90sEt
   g=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: pHlAMyrXCFajDoqAi5tU8v0JGit3yd3x6yASQvOQf3XKYfGEVnOwVma0u87SR1tl0qDtRVzbLw
 1/vFmtu3ebvDZ0R+dMyFgPFWJCdX8EZ8tHh2jJdipuTa5OTJ5u+H4Zp5krwes7lq5aT/xtp9Hp
 YMne8OcnIKQDf+htxBWOu/x6Kw3lYBz9Ic5agQ7lOLKu5wQQ5z+LwJjCLuzHpoAlmw6oHZp5b9
 84hrweBm/Fg8qkQGRo3OnPk7oDmgHpzRuv7Hr2KQwV5mTTBH+oW8SZPcxv0NbN9fR+TON+YDl5
 ik3c92yigyQ1oDILUHqn+2k6
X-SBRS: 5.1
X-MesageID: 54860451
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:R9sxg6nmjbBjzBr/e0/KQino5gz1IERdPkR7XQ2eYbSJt1+Wr1Gzt
 xJNXGuDM66LamTzLdAkaY7k9ElTu5GAnNBhHAA9ryBmFCMWpZLJC+rCIxarNUt+DCFioGGLT
 Sk6QoOdRCzhZiaE/n9BClVlxJVF/fngqoDUUYYoAQgsA185IMsdoUg7wbdg2tcx2YHR7z6l4
 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc
 s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4
 OtCtKC+VjsvAvDzocRBcBtyLGJRJ4QTrdcrIVDn2SCS50jPcn+qyPRyFkAme4Yf/46bA0kXq
 6ZecmpUKEne2aTmm9pXScE17ignBNPsM44F/Glp0BnSDOo8QICFSKLPjTNd9Gps1p4WQauHD
 yYfQQp+MBHNXQ9FBn0WD6M1xOW0xUakfgQN/Tp5ooJoujOOnWSdyoPFL979atGMA8JPkS6wp
 33E13T0BAkAM96SwibD9Wij7sfUhj/yUo8WELy+99ZpjUeVy2hVDwcZPXO5ruO+kVWWQM9EJ
 gof/S9GhYE0+FamCOHnTQynqWSNlhcGXpxbFOhSwCaJx6nP6gCVHF8tSDJbdccmv887Qz8t/
 lKRltavDjtq2JW/RGiB7L6SoXWXMDIMMG4ZTSYeSE0O5NyLiJE+iFfDQ8huFIaxj8bpAnfgz
 jaSti88ir4Py8kR2M2Tx1nHnjbqnZnPQQ4d7x/SGGmi62tEiJWNPtLyrwKBtLAZcdjfHgLpU
 GU4d9a20u8PMZ+SqCqxHdo0PO2K5dy6cxLGqAs6d3U+zAiF93mmdIFWxThxIkZ1L8oJEQPUj
 F/vVRB5v8ALYiP7BUNjS8foUZ5ylPm/fTjwfqmMNoImX3RnSOOQEMiCj2ar1GfxjFNkr6g7P
 ZqKGSpHJSdHUfo5pNZaquF07FPK+szc7T+DLXwY507+uVZ7WJJzYe1YWLdpRrpohJ5oWC2Pr
 75i2zKikn2zqtHWbCjN6pI0JlsXN3U9Dp2eg5UJLbXTc1I5QTh9VaS5LVYdl2pNxP49egDgp
 CDVZ6Ol4ACn2S2vxfuiOxiPl48Drb4g9ClmbETAzH6j2mQ5YJbH0UvsX8BfQFXTz8Q6laQcZ
 6BcI62oW60TIhyaq2V1RcSs9+RKKUX07T9iygL4OVDTibY7HFeXkjIlFyOynBQz4t2f7JNk/
 eL7jF+HGPLuhW1KVa7rVR5m9Hvo1VA1k+NuRUrYZN5VfUTn6o9xLCLtyPQwJqkxxd/rm1N2D
 i6aXkUVo/fjuYgw/IWbjKyItd7xQeB/AlBbDy/Q6rPvbXvW+W+qwIlhVueUfG+CCDOoqfv6P
 egFnevhNPAnnUpRt9YuGbhc0q9jtcDkoKVXz1o4ESyTPUirEL5pPlKPwdJL6v9W3rZctAbvA
 hCP99BWNK+nIsTgFFJNdgMpYv7ajaMfmyXI7ORzK0L/vXcl8L2CWERUHh+NlC0Cc+clbNJ7m
 b8s4ZdE5Ra+hxwmNse9ohpVr2ncfGYdV6gHt40BBNO5gAQc1VwfM4fXDTX74c/TZowUYFUqO
 DKdmIHLm69YmhjZa3M2GHXAgbhdiJAJtEwYxVMOPQ3UyN/Mh/tx1xxN6zUnCA9Sy0wfge50P
 2FqMWxzJLmPoGg01JQSATj0FlETHgCd92zw10ANxT/QQESfX2DQKHEwZLSW90cD/mMAJjVW8
 dl0Eoo+veoGqC0p4hYPZA==
IronPort-HdrOrdr: A9a23:TJpAW6tsOW2Hxk9JAmqRMeTJ7skDctV00zEX/kB9WHVpm6uj5q
 eTdZUgpHvJYVMqM03I9urtBEDtexzhHP1OgbX5X43NYOCOggLBRuxfBODZogHIKmnT8fNcyL
 clU4UWMqyUMbGit7eY3OBvKadD/OW6
X-IronPort-AV: E=Sophos;i="5.85,364,1624334400"; 
   d="scan'208";a="54860451"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=MLGhdy017rI6ywLKUKphu1CDx510SvChFO7XHfZGko/qX70bu0HdXy253Yz6r0PMEn68cnYhD/Sgz/W0R2AWJQjbJQgYNOP7XPyu0PKXD/w04lWYIJb1+MGA+SZ80hUkuebsCyUFSaq18SJidyukYM7htZ07N182amaG8NGeUxGl6rFQuHtXF2aXux6CQ6be+KH13HCrIQ70KwU7K/VnUeV1dKm4BnDeG5EcMuztvbmww8G9w68/A9UzWIIfJpkHv+cRhCd4wRwoH8nymQUnB9VxXE3VR4TtMe4hqH8qpFoUaLfFKp/x8J76CXTZ364K0PNoApOdHkq0u3584Re6YA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Gm9m+9orQmzua+6Wo8MR9/V5ClYmSSzecC45NNKeIFg=;
 b=XTQpDVXuKh8eVrkGLZIs13UsD5ZORp1YFgFjVIfgpHxDFme2V379u6EUw7oa5ldhpyoYFs5K+aA9Hjjy9wWdKJRVE3Bog/vPxcqDQWJAKxrP4/7ZAoYIi99nnR3VNacMK2dn53t5Kf+IeU4G0Gwf9F6FgZiO25sOh+JbIMnTsWW2LYUBWzMLiJ/Gk6GKkNTh7/y0e7TTWWlfo78kcxaaD7TaawZdeVJe7K7DLwUagOTHkh5x+xyjHWtGXWKfi+2SptKVoWDfICBjAWomeUT2ZtyA3PrHYDAvxAOgqYTLD3hS62v9haJZV9fAlDboXrUQqemSFXKcxBo206KKrhPRDA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Gm9m+9orQmzua+6Wo8MR9/V5ClYmSSzecC45NNKeIFg=;
 b=TqvoQpeovjnSzZ90VJt3BVIgIoNSFjcYYyOFfc1ruh1i097AHOcnWRCHI7ktNZIw9Wh6Dke2cN9vgZQNjXooJQal4meJ/Jg+iSuzsz6rNEr23v70qltQACa3O675vxAT1+S4JSStrwEnbur88ZJQuT0pjwm4UTZq3iQw3vGRMg0=
Date: Mon, 11 Oct 2021 15:57:25 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Bertrand Marquis <Bertrand.Marquis@arm.com>
CC: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>, Rahul Singh
	<Rahul.Singh@arm.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, Andre Przywara <Andre.Przywara@arm.com>,
	Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>, Juergen Gross
	<jgross@suse.com>, Stefano Stabellini <sstabellini@kernel.org>
Subject: Re: [PATCH v5 01/11] xen/arm: xc_domain_ioport_permission(..) not
 supported on ARM.
Message-ID: <YWRCxXGQIyTOAepC@MacBook-Air-de-Roger.local>
References: <cover.1633540842.git.rahul.singh@arm.com>
 <d292392268df2c74c4103a82ef917072643407a8.1633540842.git.rahul.singh@arm.com>
 <YWQkblfNMYEs6jI9@MacBook-Air-de-Roger.local>
 <77CF7FA5-C566-469E-B4A8-0400789890BB@arm.com>
 <YWQ6Nk3Jk+BqgkwZ@MacBook-Air-de-Roger.local>
 <53AE6E2A-01D7-41EC-9B2C-C0D596EB8D4D@arm.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <53AE6E2A-01D7-41EC-9B2C-C0D596EB8D4D@arm.com>
X-ClientProxiedBy: LO2P123CA0039.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600::27)
 To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: ca021c4c-12f3-4ab6-8249-08d98cbf10a8
X-MS-TrafficTypeDiagnostic: DM6PR03MB3673:
X-Microsoft-Antispam-PRVS: <DM6PR03MB3673FE5C1E77E4D64A29AB2A8FB59@DM6PR03MB3673.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: xjhy8Y7c/IY0Y9A2btu2zX0m4R5NQVfqo7vMXj3z6pizhs5Ve9AoPi5hCGDX+rt6YxOJ3Ww9keHSwnuEYXuDkWH9+rvsGFyBKZlKk7jzwtw663BHGyvsXL1d2tQ0C2XxqrfyzzexUtx0eUaFZN0ljJnEgX+qfE98NXXHt/Ldk+CTHoNHCtv5a3RmUY/MccHCRlDsQ11zOHgKyyg5q4JbDlCMzLF2URtUwmBz73fuslqQXJnH0C/1OMBZK1A1fTKHMQ/ugfaLXkyKEEuoOo35A/VMFrr2om4DBcad8i+FQleCqh56kEUQHX2Cb6DaJoI0JuNLhl+wJZuwf3SwMXx589dW3DgWCIRGXXVrbB1xxDXdp4ygM6SyVeHG4ayaoBo8KBUEa+XcdyAFJmmAvpKmZMiKkoIjpLIY007/mOSdewBmLT72fsHX2QriIb+Y2XHN4hAla3KR7h+uFct8djeV/lfSzoFTMvWkkvqQ6zX2+ma1wtmjnVS98YfgkUvJZMkUL+DLeZMnCXEkm6fhVhozBiJOSDIhRathqB+AKn9W/QyUhP292g9AxK3OTyiKjL4NPlQj13CV2K2f8rXohejWIBfbx+G6rzZXaW5xrZHOBlcrwawHTTWoLWJJ3QmVtkCDrfiPnjLGJAbQogTsRbdM2A==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(84040400005)(2906002)(8676002)(26005)(6666004)(38100700002)(8936002)(85182001)(83380400001)(6916009)(4326008)(956004)(9686003)(66556008)(66476007)(66946007)(6496006)(316002)(86362001)(508600001)(5660300002)(186003)(54906003)(6486002)(53546011);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?V3ZIcmg2UHhDdWlncHRsSEJ4U2ljNHA3eWZxZWwraXoxclJCM0NtWEpneXJG?=
 =?utf-8?B?T29NSlljQ2RkNEFhejd4OEFkTEcwVkFFRkF5TGJyanM4QndsWnU1Zmg5d2d2?=
 =?utf-8?B?bURpNkxKaGRkQTNmR3QvTTBxK1g3czNmdUNYSWFteVlYZitaZXZmSHpRbGpP?=
 =?utf-8?B?TFNGWncvcm4xeGRGeDF6Z1JlblNsZm5lL1Roa0U4YzRHR3pRaVlYS3RUYld6?=
 =?utf-8?B?WTdoTE54TWo0d2E4VmhiZm1HbWljSVRYR2pkNWNtaGpDdC92NWFpQ2doN3Ry?=
 =?utf-8?B?NEFqbFNNZ3lBcGN6bFVja0R3QTFycUg5L1pLeUp0VjBlMFVmdVhZcmhZNE1B?=
 =?utf-8?B?OE12QjZWenc4NkRkdDRWY1NEK09DZ0YrVDFESzNQcFZjTE5uNHY0NEdibWkw?=
 =?utf-8?B?a2RnNE92WGhRdy9aN2lmZGp4MEZNb292K0JwU2JJR1VUamkrM1YwWXYwV1pP?=
 =?utf-8?B?Z3YzSG9iRVZ0aWo0OTEwQ2VTYURwN0hYeEFtckR0MnFSc3doeUJVdGdaSXpt?=
 =?utf-8?B?MHhLNW5yOFBxbG5MakV2bmVuaER0bnJHWE1hVjNwV2tTSHN1VStNdDFTUHFT?=
 =?utf-8?B?MHJMVE41NVI4Zk9laG1IUUxvNzdHT0xaWUpNby9YeU5WVHZSTmhBVHVPbElK?=
 =?utf-8?B?T2tIbFpYYWtDYlEwYjduRGluU3Z1UUI1aFpTMUJmZHZQeUV0YjFpaUNNNno2?=
 =?utf-8?B?T0V4QVM0dTEzMDR1RE5oZkVJZ1JmUUVWQUZGUW1NQUkyc2daMWcvQXZjOXZy?=
 =?utf-8?B?Q0Q4NkZZdmtkNHd3N0NrT0NoU3dtc1hOc0ZtWkw1RmJjcjZuMXlySVVxOWtW?=
 =?utf-8?B?by9XYWtWMUM2MS9kMHVOVk9MMWVLRGFycGNPTzhBZEc3b2xkQ0ZQVlBtclpV?=
 =?utf-8?B?aFlxalhtV0tLNythZGd2VGZWSndMT3RCT2JLYlRHdTFiMWZ3cGJCSUJ1MkhC?=
 =?utf-8?B?dENsZ1RvUlRnVEFaRW9oZURaUWhtM0psRGY4ZUsyNkwrb2d5YlM4TGQ3eWpi?=
 =?utf-8?B?cSt6M0lYTXM2YWJGaTZPRUorcWFNdGJIeUtiSFZoS1JNdGlHZFhPMVFUS0I4?=
 =?utf-8?B?RmNUQm9BN1EwZ3pmWnVrbFRRanc2bEs3ZWx0cm0rTnJSSEpVb3czdzFqQkhK?=
 =?utf-8?B?K3ROejh0N3ljMlcyN3JqUE5mWTJrYy9FQ0lTYWh2RXIyd0pYUkNuSEJJZWZu?=
 =?utf-8?B?MmxqUVBhNFJIM1FRb09uRjhXQUx2ZWFSclZYZ2pWWmthaUlyL2MrajdiMGlq?=
 =?utf-8?B?VHFncEZ5bEMrcGV3Zmp6RUdYOHJJVXFkK1Q4dk45cUtWejNtcjRaTUdQcUxR?=
 =?utf-8?B?RDJza21QemdMRVJ4Z2cwSkRGRUlHMVpXSWpwRzNDTVJBOHRxRk9mUUhaY2lp?=
 =?utf-8?B?alBsUjdKeUJWaTJ0V3JydEdPZkJKSjhBYVN5QjhkRnlaYXRDRnIySTh2dG95?=
 =?utf-8?B?QkRLZHJRK3MzWThoMjU5S1VlTHo4Z0YyQlRFUGk1ampkaDkyMUpQdE13TVRU?=
 =?utf-8?B?WVMwb294MUhNSHdmZEUzWEVJRVhsV1lURFhyU1dRWmovUDZhdm82RzcxQjRF?=
 =?utf-8?B?dzQ1Wk95bWJsYTlmL04xT0ZkZC9nM1BOOU9PSWI1b3hXZ1FuUVFSYkk0OGZl?=
 =?utf-8?B?RS9Xbkh0K2JoWUJSTTlvZUJIblB1dk5CRXVscVdKSkdTQkxzamR5YkZ4R2N5?=
 =?utf-8?B?RHREYms5YlpiRjVzamlhZElQc1k0U1NQRGZ0WW9tVWJITUdFbEw4ZUxEOU5p?=
 =?utf-8?Q?H9pZHw2QXoa9a40Q/zq4imZYQuNc7meEmY0VdCm?=
X-MS-Exchange-CrossTenant-Network-Message-Id: ca021c4c-12f3-4ab6-8249-08d98cbf10a8
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2021 13:57:29.6812
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: YKBlZLzqZIciku8GaXf5YTOEruzQ0cm98QSUpY8Zw8iSPyvQyqwF13H7ZNyc78myEr+qEhWj7haMpjGJHbrPrg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB3673
X-OriginatorOrg: citrix.com

On Mon, Oct 11, 2021 at 01:40:30PM +0000, Bertrand Marquis wrote:
> Hi Roger,
> 
> + Oleksandr to have a better PCI expert then me.
> 
> > On 11 Oct 2021, at 14:20, Roger Pau Monné <roger.pau@citrix.com> wrote:
> > 
> > On Mon, Oct 11, 2021 at 12:11:04PM +0000, Bertrand Marquis wrote:
> >> Hi Roger,
> >> 
> >>> On 11 Oct 2021, at 12:47, Roger Pau Monné <roger.pau@citrix.com> wrote:
> >>> 
> >>> On Wed, Oct 06, 2021 at 06:40:27PM +0100, Rahul Singh wrote:
> >>>> ARM architecture does not implement I/O ports. Ignore this call on ARM
> >>>> to avoid the overhead of making a hypercall just for Xen to return
> >>>> -ENOSYS.
> >>> 
> >>> What is the cal trace of this function actually on Arm?
> >>> 
> >>> AFAICT libxl will only call xc_domain_ioport_permission if there are
> >>> IO ports explicitly defined in the guest configuration, or if any of
> >>> the BARs of the PCI device is in the IO space, which is not possible
> >>> on Arm.
> >> 
> >> PCI devices BARs can be in the IO space as the PCI devices are not
> >> Arm specific. There is not ioports on arm so to be used those can be
> >> in some cases remapped and accessed as MMIOs or are not possible
> >> to use at all.
> >> 
> >> But the IO space does appear when BARs are listed even on Arm.
> > 
> > Urg, I wonder whether those devices with IO BARs will work correctly
> > under Arm then.
> > 
> > How do you know whether the BAR has been remapped from IO space into
> > MMIO?
> 
> We cannot, I think the platform will define if this is the case and where.
> @oleksandr: I remember that this was discussed during some of our
> meetings but I have no idea of the details here, can you help ?
> 
> > 
> > IMO instead of faking a successful return value from
> > xc_domain_ioport_permission we should avoid the call completely in the
> > first place, specially if we need to instead issue a call to
> > xc_domain_iomem_permission.
> 
> At the end we will never have to issue this because this will never be a matter
> of “iomem” permission as there would not be any way to cut on something under
> the page. If this is to be supported one day, it will probably have to be fully emulated
> to keep the isolation.

So you have a set of memory pages that map accesses from
MMIO into IO space but it's not possible to isolate specific IO port
regions as they are all contiguous in the same page(s).

> Right now on arm you can just make the more simple assumption that ioports are
> just not supported.

Would it make sense in the future to provide a memory region to guests
in order to use for IO port accesses, and call
xc_domain_ioport_permission to set which ports would be allowed?

I think the commit message needs to at least be expanded in order to
contain the information provided here. It might also be helpful to
figure out whether we would have to handle IO port accesses in the
future on Arm, or if it's fine to just ignore them.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Mon Oct 11 14:02:34 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 14:02:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.206053.361515 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZvsu-0006h5-LI; Mon, 11 Oct 2021 14:02:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 206053.361515; Mon, 11 Oct 2021 14:02:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZvsu-0006gy-IH; Mon, 11 Oct 2021 14:02:32 +0000
Received: by outflank-mailman (input) for mailman id 206053;
 Mon, 11 Oct 2021 14:02:32 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=9TNE=O7=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mZvst-0006gs-VF
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 14:02:32 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id b24f3af0-7f15-4f41-8a70-efeb4bf8a786;
 Mon, 11 Oct 2021 14:02:30 +0000 (UTC)
Received: from EUR01-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur01lp2055.outbound.protection.outlook.com [104.47.1.55]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-23-1WmZarAUOJe4AhYIf4Sgog-1; Mon, 11 Oct 2021 16:02:27 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB3117.eurprd04.prod.outlook.com (2603:10a6:802:6::32) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.25; Mon, 11 Oct
 2021 14:02:25 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4587.026; Mon, 11 Oct 2021
 14:02:25 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM5PR0701CA0057.eurprd07.prod.outlook.com (2603:10a6:203:2::19) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.4 via Frontend
 Transport; Mon, 11 Oct 2021 14:02:24 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b24f3af0-7f15-4f41-8a70-efeb4bf8a786
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1633960949;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=xbjm/insLpSAtnftwykU3DoT0k9nscyGQ6ldLJaxOA0=;
	b=PwEP1u+vxs7oPY5VXuOtX46k9H43V32mzEo4u0Jreo0iq1k8cCbLfu4TSw+5m0bDvLnBPC
	tAgbOVRu0Tz2CiTPkI/MvzcRmtND4F3gM4+eulpb8mU4GH85TxQsKC5+rVsLOu0Kd7uuOv
	kHvdEUZUWPEds3lLj0OqQyjpCHjKhJ4=
X-MC-Unique: 1WmZarAUOJe4AhYIf4Sgog-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=RWYOlAYZPRYjlrqvhtsZ2GLlrP6FhbsUfVb4S9LwElgJB/vq9LbRkJNzCHDRH7zklyjkQ0CLRXcNfo4sI1BmKipBXcErrmnal4bigqgepZ7BPEZEY3HXCnA1PbCmln53lBrbhlBtvf0gMIcmUOp16+NHcp7G2BdlS7U2jo3QVZvfQXK09KWacoT0Z3M4jSKtqL2UejFGpVpFRHm9Xc6939oyySwpEZmkRQbrJ1Qzh+We5b8MpozE0fsdB7bv3IJXkPFwgXyWEzm5s4Y210k8hFBEjeCcYJMPxXXU6MyRW+YUGED70YmTft6L8jPaU1zIgYtzmQ/H7NGaOE9RfzH6hA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=xbjm/insLpSAtnftwykU3DoT0k9nscyGQ6ldLJaxOA0=;
 b=dJlpeqlmd13Qpc7v7ofpZDqzGvFV2bs0DDitRHDKhJSiWQHLCkrUn9O47ZWDsVQico1Mr+E77d0k1fDJpNxGF9OcyB2lOapBrd+SBOdBl0GKGD/Z0AXC38UHl1H6uFlNb0G2So6Ls0NFiauRr5qQNaBlC4xxaVGxBn0goOj9fmRUkw11DPiN/gzkFrI7DpI8iLRqnJcpPn2NNBXOH6r9P+g2og1YC/CyxGB2mV6+D9Sn2FziTF2uaosbdI/cCe3JZYfHXEgQOphqwShnTu5U25N6Gl7P9+HzjnVsS28korK/Dci3NcaRA85XpZC/ffSMgBeYw5dHed3Fz4boRoxXSQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [XEN PATCH v7 26/51] build: build everything from the root dir,
 use obj=$subdir
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: Bob Eshleman <bobbyeshleman@gmail.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Alistair Francis <alistair.francis@wdc.com>,
 Connor Davis <connojdavis@gmail.com>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
 Ross Lagerwall <ross.lagerwall@citrix.com>,
 Daniel De Graaf <dgdegra@tycho.nsa.gov>,
 "Daniel P. Smith" <dpsmith@apertussolutions.com>,
 xen-devel@lists.xenproject.org
References: <20210824105038.1257926-1-anthony.perard@citrix.com>
 <20210824105038.1257926-27-anthony.perard@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <eca3f533-9841-e4a8-dfde-840451ed8aef@suse.com>
Date: Mon, 11 Oct 2021 16:02:22 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <20210824105038.1257926-27-anthony.perard@citrix.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM5PR0701CA0057.eurprd07.prod.outlook.com
 (2603:10a6:203:2::19) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 4665c29d-1808-4574-3b0f-08d98cbfc0ef
X-MS-TrafficTypeDiagnostic: VI1PR04MB3117:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB31173D1FA58C430C487C1BCAB3B59@VI1PR04MB3117.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6108;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	/VacpLWM/mBIxv1igtBswNYpa6fTEdeuY3BTIwIJMn8BKfmwY79OYO5S6ldCm4Bb1IoAXRa+i+RzGAABxc3vl1Z2rD+BFY4dwjBtFZyOS8pyMojRgPwFwXHGGxABrCAlnv1EWzXVawsoRIXOabg7diRt6TVPO74jAPfu3VnNE1Z6R1CB1XjPRctzHQrFxfskpVWGnDCH4yanJAVUHAJxZwbIs7kXiN29KTLRD3NFblgO2n/+Za9f+jZ45bQoce1Blt2Oat78x4uUeomkaqeVpNnkzbJAUqNxeY9VSzbqNfLi1geS0bxEnVjMnaXVrRTIpJYyo0+TEOOsyntxoFUvOt/St66K704Jb3fZlTjVoIWiDRAknGM/qvyCx1LNK5sqZW0/eEFjUvkENl60NBU4oyuQmSpH5hbmkwmj3XQmXPKlRisbZWs2h6tKbGM0fKmClXXcUGq4xU9wlO6JTvMOtIV9MvmOG3jaVFp1TVNyMVvHNDzThk+/f+KaKbvTq2nvHdd/zSxsLWOG8RlHngOe7ZGkOuSla+xSfAnWodot6fUjrm/pieIle2Se4nGcyIfoU3YuW3K8DiNG1dczAwM/cuuVbR2mLFMqXniepQi5ai06VZU4nDjbAk6GAPqfE/lKeo9ZGp9dHfkcWyJdulFSHBeFZeSYVA3RgpJt7dJLAuOMHRBmLRli2RlTd5MJV36QKvMxUpU5ZjrXFe8KEU/9gCHp/mXqzx57yKyA6vPzVtq5LwPn60+rRkBf/8R7RC+NWVMo9agMiOkxml5jbYrZoA==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(7416002)(86362001)(31696002)(53546011)(186003)(4326008)(36756003)(316002)(8936002)(16576012)(5660300002)(26005)(956004)(2616005)(6916009)(508600001)(54906003)(31686004)(83380400001)(38100700002)(66556008)(66476007)(66946007)(6486002)(2906002)(8676002)(155303001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?NXhDRG1KdG01WnM3dEtmeGs4ZnJxRlNrYkRmZHprMUR3b2k1ZFVaNTNZMXpj?=
 =?utf-8?B?ZXFqc2xHR0N1WlZnUk5mSG8wWFkvU0F4NWdUR2pFWFg4K1NIUUoyNjBObzB1?=
 =?utf-8?B?czYxaVBoYTI5Nm1kV0UwVWN4ZjdNWDQ1dE80R0VPd3ZGVmdNdFpUQVh6bjkw?=
 =?utf-8?B?SjgzeW1BL3N6SlBzVHI5TW5qWGRiamJuMmtZejhxdFpvQTBBQ2RIRjNXZzFZ?=
 =?utf-8?B?UXRWMDB1aktaRTMrMVFXZUs1VDBSaGh0emxvM2FxejY4YzZBcUhuZzFQdE1j?=
 =?utf-8?B?U2szN29Pc1JoSUJFUk5YZ1hCMGo1b1lOZHdCU3BlVXZpb28xeHpObWhodXNL?=
 =?utf-8?B?d1NVSG1DSWxzT2RRWVBHNnI2am5GUFRZSWtQcG02dzJsRm1FbE4zaXhUU3Z3?=
 =?utf-8?B?dEV6cFFBMHp5WmpCRlNNSkdNMUZFaW9RSStUSm5rZnR6ZEprNEdEck4ycUdV?=
 =?utf-8?B?S0xvL2FUR1A1QjZLNWw1NFJXS3NuUnVLRVR4TlRLN2kyZUprQ2tYWmJKS05N?=
 =?utf-8?B?RWJ2NDU1aEpHZG5GVU4yKzR6S0Fiekl6QnNrTlIvRE9kRjhuZnlLcE9WTmd6?=
 =?utf-8?B?d29PN0ZXNE1Sa01zUFlpUUNic2dXaXJRK0ZUTTZNL3BkaFpJRllHVE1vdXA2?=
 =?utf-8?B?MGp0ZnFkMzVKc1FNME1kaFNDWHBFeG1JbUFjN2xyTWlJdHp2Wis1SHNrQ2Uy?=
 =?utf-8?B?b1RTcUpxL1pISDgxUjQ5anVxQi8ydWVlSExqUEdvL2U3UHVmdlR1K1pWanRi?=
 =?utf-8?B?K1BrV1g5V0NFQ3F2YmJrdUxKZlc4MFdkWGVLNUxwK1dUUGdEYVlIVW53cEF4?=
 =?utf-8?B?K0FJc1VpTm9pMnorMldZeFlYUlkrSEpsOFRRbmUvcVJUbmszQ1JvMlk3b0Vv?=
 =?utf-8?B?M2thMzBFa1FzaXZkWlpoYTUzL3VYSWYzT1E2d3c2dllubStHcTEvd2hCVTAw?=
 =?utf-8?B?NHZtelFQZHB1WitORnNrZVQwWW0vdHlFVlZMWkV0K213em5vSUtuc05hUHYv?=
 =?utf-8?B?a0F4ODZkQTJkaWFQcE9EMTdKSlFOZ1l4Wk93cmVOeStEQmJBVXpkQWE5SFVY?=
 =?utf-8?B?N05NM0lLNlRyUTdNZXVCZFV4MFBLaG9nQmJIL25PclVMSkJ1WFhBRE91dktn?=
 =?utf-8?B?bGxKTmxXbkZrSFJRUTlYaWQyUjV2SnR6dWlUMWNERmdRN1licHFYWTVOd1FP?=
 =?utf-8?B?TjhyVHNwclc5OG5xUnozMU9Jd3liNHhqYUJkell0TStZNjBoNUVja2ptWjQz?=
 =?utf-8?B?NStabEd0VkNyRkd4UlFLemkzM0VnendXZTNqclVidGVVWWtlaXV1dk5MeFNu?=
 =?utf-8?B?bkRTcTRBQVBLbTR1WkFVNVFKRHhFaGo5c1QzNE9tWHJuL0JYUmlUY09rb2Jt?=
 =?utf-8?B?RXhiZHZNdEZRQkVtNjBwRnpGMHdkUUVjUlBNYUdMT2xOS085ZGpnZHVKY05k?=
 =?utf-8?B?dUo0elhERVNicEQ2ZTRrV051MnhXQTVldG5vN2lDVzRaUk9aL2YrTXFCekdJ?=
 =?utf-8?B?YW5oNGRHMGJGT09xWHBMMnZ4RWlMZmlvd0JUelF4UzhTUUtDTGRyVmZaaExC?=
 =?utf-8?B?RGY1V3I0V3g0WUVrUkRtaE82Ykx5RnZyRnl1U25lRGN4WEhsZ2xmNlA2NjhQ?=
 =?utf-8?B?ZFhSbWh6ZnM3a08yTnM4aU1nN1lrUStJakl5bjBBb0MrY043bEFZSlVyZE5k?=
 =?utf-8?B?UVg4bmE4ZGlQbDlLcFZKSXp4TkF0OXc5QTNYME5vcHptMDBrblprQmkrQWI2?=
 =?utf-8?Q?5+v6ubNNUfn/CKYaPY77vfYgziK8TxpChz38wp7?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4665c29d-1808-4574-3b0f-08d98cbfc0ef
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2021 14:02:25.4890
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: NV/xcwibR8nlBSYAT3mVkWzryd/LuepJLuOjkaMXUGE3XkAxgnvmsHrskMQrOiqohlai5CgjzkpaDD/9ib5JUA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB3117

On 24.08.2021 12:50, Anthony PERARD wrote:
> A subdirectory is now built by setting "$(obj)" instead of changing
> directory. "$(obj)" should always be set when using "Rules.mk" and
> thus a shortcut "$(build)" is introduced and should be used.
> 
> A new variable "$(need-builtin)" is introduce. It is to be used
> whenever a "built_in.o" is wanted from a subdirectory. "built_in.o"
> isn't the main target anymore, and thus only needs to depends on the
> objects that should be part of "built_in.o".

How "good" are our chances that we hit a need-builtin variable from
the environment? Its uses are simply using "ifdef".

> --- a/xen/Rules.mk
> +++ b/xen/Rules.mk
> @@ -3,19 +3,29 @@
>  # Makefile and are consumed by Rules.mk
>  #
>  
> -obj := .
>  src := $(obj)
>  
> +PHONY := __build
> +__build:
> +
>  -include $(BASEDIR)/include/config/auto.conf
>  
>  include $(XEN_ROOT)/Config.mk
>  include $(BASEDIR)/scripts/Kbuild.include
>  
> +ifndef obj
> +$(warning kbuild: Rules.mk is included improperly)
> +endif

Is there a particular reason for this to come only here, rather than
before the include-s (e.g. right at where the assignment to the
variable lived)?

> @@ -51,27 +61,54 @@ cmd_objcopy = $(OBJCOPY) $(OBJCOPYFLAGS) $< $@
>  quiet_cmd_binfile = BINFILE $@
>  cmd_binfile = $(SHELL) $(BASEDIR)/tools/binfile $(BINFILE_FLAGS) $@ $(2)
>  
> -define gendep
> -    ifneq ($(1),$(subst /,:,$(1)))
> -        DEPS += $(dir $(1)).$(notdir $(1)).d
> -    endif
> -endef
> -$(foreach o,$(filter-out %/,$(obj-y) $(obj-bin-y) $(extra-y)),$(eval $(call gendep,$(o))))
> +# Figure out what we need to build from the various variables
> +# ===========================================================================
> +
> +# Libraries are always collected in one lib file.
> +# Filter out objects already built-in
> +lib-y := $(filter-out $(obj-y), $(sort $(lib-y)))
> +
> +# Subdirectories we need to descend into
> +subdir-y := $(subdir-y) $(patsubst %/,%,$(filter %/, $(obj-y)))

Deliberately or accidentally not += ?

> @@ -156,21 +192,13 @@ endif
>  PHONY += FORCE
>  FORCE:
>  
> -%/built_in.o %/lib.a: FORCE
> -	$(MAKE) -f $(BASEDIR)/Rules.mk -C $* built_in.o
> -
> -%/built_in_bin.o: FORCE
> -	$(MAKE) -f $(BASEDIR)/Rules.mk -C $* built_in_bin.o
> -
> -SRCPATH := $(patsubst $(BASEDIR)/%,%,$(CURDIR))
> -
>  quiet_cmd_cc_o_c = CC      $@
>  ifeq ($(CONFIG_ENFORCE_UNIQUE_SYMBOLS),y)
>      cmd_cc_o_c = $(CC) $(c_flags) -c $< -o $(dot-target).tmp -MQ $@
>      ifeq ($(CONFIG_CC_IS_CLANG),y)
> -        cmd_objcopy_fix_sym = $(OBJCOPY) --redefine-sym $<=$(SRCPATH)/$< $(dot-target).tmp $@
> +        cmd_objcopy_fix_sym = $(OBJCOPY) --redefine-sym $(<F)=$< $(dot-target).tmp $@

Are you sure about the $< => $(<F) transformation here? Previoiusly it
was present only ...

>      else
> -        cmd_objcopy_fix_sym = $(OBJCOPY) --redefine-sym $(<F)=$(SRCPATH)/$< $(dot-target).tmp $@
> +        cmd_objcopy_fix_sym = $(OBJCOPY) --redefine-sym $(<F)=$< $(dot-target).tmp $@

... here.

> @@ -251,6 +292,9 @@ existing-targets := $(wildcard $(sort $(targets)))
>  
>  -include $(foreach f,$(existing-targets),$(dir $(f)).$(notdir $(f)).cmd)
>  
> +DEPS:= $(foreach f,$(existing-targets),$(dir $(f)).$(notdir $(f)).d)

Nit: Preferably blanks on both sides of := or none at all, please.

> --- a/xen/arch/x86/Makefile
> +++ b/xen/arch/x86/Makefile
> @@ -81,6 +81,9 @@ endif
>  extra-y += asm-macros.i
>  extra-y += xen.lds
>  
> +# Allows usercopy.c to includes itself

Nit: include

> +$(obj)/usercopy.o: CFLAGS-y += -I.

This is ugly, but presumably unavoidable. Preferably I would see us
the more specific -iquote though, assuming clang also supports it.

> --- a/xen/arch/x86/boot/Makefile
> +++ b/xen/arch/x86/boot/Makefile
> @@ -1,8 +1,8 @@
>  obj-bin-y += head.o
>  
> -DEFS_H_DEPS = $(src)/defs.h $(BASEDIR)/include/xen/stdbool.h
> +DEFS_H_DEPS = $(BASEDIR)/$(src)/defs.h $(BASEDIR)/include/xen/stdbool.h
>  
> -CMDLINE_DEPS = $(DEFS_H_DEPS) $(src)/video.h
> +CMDLINE_DEPS = $(DEFS_H_DEPS) $(BASEDIR)/$(src)/video.h

Hmm, new uses of $(BASEDIR) (a few more further down). Why not
$(srctree)?

Jan



From xen-devel-bounces@lists.xenproject.org Mon Oct 11 14:06:47 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 14:06:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.206060.361527 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZvwx-0007LD-5C; Mon, 11 Oct 2021 14:06:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 206060.361527; Mon, 11 Oct 2021 14:06:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZvwx-0007L6-1R; Mon, 11 Oct 2021 14:06:43 +0000
Received: by outflank-mailman (input) for mailman id 206060;
 Mon, 11 Oct 2021 14:06:42 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=BpBC=O7=citrix.com=Andrew.Cooper3@srs-us1.protection.inumbo.net>)
 id 1mZvww-0007L0-9L
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 14:06:42 +0000
Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 7505ec16-2a9c-11ec-80dd-12813bfff9fa;
 Mon, 11 Oct 2021 14:06:41 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7505ec16-2a9c-11ec-80dd-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1633961201;
  h=subject:to:cc:references:from:message-id:date:
   in-reply-to:content-transfer-encoding:mime-version;
  bh=BXvcUP+XqHV5AjwM1QEKFi9EuiUym3Ks2KKWcaWUKaU=;
  b=MgCXs7+fGx8OC/hM3PtnXmn7XdZsG+aOOGazqK79hYoLSLU+20TIwoIm
   PRUmvwwKChht2WX5zFaxJbRB50hz3CLN/mcRxTVwmkitkQMOXZ+z/U7BC
   4JJucISmwUWMUShgxSi6tIVJkUFqE5xjdEWiOnURxgWRETmpP2F05QPlm
   I=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: 55DyMtZ9yJS6a6fqweJtQ9kQ85bbpRD43oKRayC5y6lPaIn4dSMwJ0mM7H9dfV8s9MEC3qbMbQ
 CJoYv+k37A+zLBcOpzng49LwRFcgNZhtk3e9KhOLdAfhL76SHvoouaEZ5/MYXXk39AmyLrS14U
 SWRZ0CnV05nwquZd/MzfDfGCcJ6F8nz3By/DWs5uWFocxcoE2aUt6U4p1BeKYr2W6JAnJlhJrC
 3JN1C2YV1ESAmaDqRHL9SKNKQMH8J8RwzBWv+qnMBG8jrYlmxVJMjO5iVpi4qSJcYUmbSoXZ81
 YxV2Af0pTuKW72ObdWwVfLA3
X-SBRS: 5.1
X-MesageID: 56754355
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:PJnCCKPYsqvdb47vrR1DkMFynXyQoLVcMsEvi/4bfWQNrUoi1TcFm
 2dOCD3SOPmKMTDyfI1wbozj/UkB68XQztNiTgto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdpJYz/uUGuCJQUNUjMlkfZKhTr6ZUsxNbVU8En540Us6w7dRbrNA2rBVPSvc4
 bsenOWHULOV82Yc3rU8sv/rRLtH5ZweiRtA1rAMTakjUGz2zhH5OKk3N6CpR0YUd6EPdgKMq
 0Qv+5nilo/R109F5tpICd8XeGVSKlLZFVDmZna7x8FOK/WNz8A/+v9TCRYSVatYo2yR3M1Xz
 /IOjrypER8KE4HswP0vTBYNRkmSPYUekFPGCX22sMjVxEzaaXr8hf5pCSnaP6VBpLwxWzsXs
 6VFdnZdNXhvhMrvqF6/YsBqit4uM4/AO4QHt2s75TrYEewnUdbIRKCiCdpwgWlv25wVQKu2i
 8wxeDhBSRGcUkN2Ng0FN58TxbaFmmO4bGgNwL6SjfVuuDWCpOBr65DvOtfIft2BRe1Og12V4
 GnB+gzREhwccdCS1zeB2natnfPU2zP2XpoIE7+1/eIsh0ecrkQMDDUGWF39puO24nNSQPoGd
 RZSoHB36/Fvqgr7FbERQiFUvlbdpl0Bfd13UNYa8VmV6Yf4w16ANHcLG2sphMMdiOc6Qjkj1
 1msltzvBCByvLD9dU9x5ot4vhvpZnBLdT5qiTssCFJfuYG68d5bYgfnF447SMaIYsvJ9SYcK
 txghBM1gKkPloY13qG/8EGvb9mE98WREFBdCuk6WAuYAuJFiGyNO9zABbvzt68owGOlor+p5
 iVsdy+2trFmMH11vHbRKNjh5Znwjxp/DBXSgER0A74q/Cm39niocOh4uW8lfxc4apldIGO3O
 yc/XD+9ArcIZhNGioctMuqM5zkCl/C8RbwJqNiFBjaxXnSBXFDep3w/DaJh92vsjFItgckC1
 WSzKq6R4YIhIf0/llKeHr5FuZdyn3xW7T6DFPjTkkX8uZLDNSH9dFvwGAbXBgzPxPjf+1u9H
 hc2H5bi9iizp8WnOnOJrtVJcQxTRZX5bLivw/Fqmie4ClMOMEkqCuPLwKNnfIpgnq9PkfzP8
 G37UUhdoGcTT1WZQelTQnw8Or7pQ7hlqnc3YX4lMVqygiBxaoez9qYPMZAweOB/puBkyPd1S
 dgDetmBXasTGmiWpWxFYMmvtpFmeTSqmRmKY3ivbg8gcsMyXAfO4NLlIFfirXFcEiqtuMIii
 LS8zQeHE4EbTgFvAZ+OOvKixl+8p1YHn+d2UxeaK9VfYhy0ooNrNzbwnrk8JMRVcUfPwT6T1
 gC3BxYEpLaS/99poYeR3a3d9tWnCepzGEZeDlL317fuOHmI5HenzK9BTP2MIWLXWlTr9fjwf
 u5S1fz9bqEKxQ4Yr4pmHr935qsi/N+z9aRCxwFpEXiXPVSmDrRsfiuP0cVV7/Afw7ZYvU29W
 16V+8kcMrKMYZu3HFkULQsjT+KCyfBLxWWCsaVreB33tH1t4b6KcUROJB3d2iVSIYx8PJ4h3
 ep86tUd7Bayi0ZyP9uL5syOG79g8pDUv30bi6wn
IronPort-HdrOrdr: A9a23:AJHNrahvEm5o/J5rGgxqOnjVyHBQXt4ji2hC6mlwRA09TyXPrb
 HLoB1773/JYVkqM03I9errBEDiexLhHPxOjrX5Zo3SOTUO0VHARL2Ki7GO/9SKIUPDH4BmuZ
 uJ3MJFebrN5fQRt7eY3OEYeexQouW6zA==
X-IronPort-AV: E=Sophos;i="5.85,364,1624334400"; 
   d="scan'208";a="56754355"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ed/yTviysB9o3KrO7odDu0jv2dOyiFUzJ/yCs8BFNLIAVuVa+TQZiCZaBKnpTp817RXSCNCFj0KQNYFb0K4JmG+pfvPxfkbqaQZnqL1HTyfoJab79kInpk9AP0yjZlXGQdexNJ5Q8XOOabDXvF6ZgjfOxVGaKpdYFpZ/8GYgZTCkChAI7K59CX6ggpfTq2/wb5pwfT5ndofnvIxKlqEo9bvq2v2fiutC+nfxXH4J+YOPUUKceLfdY5K4H7c5gAo6bf1I4I898a2p4xDrn+GKY2GtW7P/rOHfVW3HY3BTWhVVrhitaLb+TRrlTFqwQkHQ8p2fNhcgnjDEPtNKZfeb1w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=BXvcUP+XqHV5AjwM1QEKFi9EuiUym3Ks2KKWcaWUKaU=;
 b=HC944laBOhycFE2dE9q8JymMFbZu+hOJ07OnwKoqGXlFlZyPZp68IhNgZ0PMaz1mlrC7D66et+pO5NNod9Bp4oxx0OWNGp/sh+TvcStCjfK4Xy59r30RurwGVmpvwGKO/Tqi3bEHIGDRPcB2w2LFdkQ5vcuk7lJs1Xv1JFsfM3EiqprdSiyVi5e2I/gqdDN5o0zaL9zdmKKlGMpUyNFb5k1/B6ButsMTpzMz/4MKQQEXMWIGXSGhx/dq+/Mgso7y0+asXQ5cRwQtduFQ7zfVUXEGqCEeZWVVP9YHN2eVMEICAsLvYYId5mOoVYUgxX9efW+o9GEMLeeut7tXSU/QMg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=BXvcUP+XqHV5AjwM1QEKFi9EuiUym3Ks2KKWcaWUKaU=;
 b=kNgY3KqJJhjJi0Pkl0gO2rGrHKW2amRvJnE8ubktdl9mlU28vp2Pw9PXBo/sk77W6Q4+IkAQNJ+7TeKik73zXyu/6isPCOpuN8xY5fwjKWwDlMzdf1cG6hTo64dPrR3RceWUY/rhP7/M5bmyc6X7AAtP4V2wmlWVkPchjX4Snag=
Subject: Re: [PATCH v2] x86/PV32: fix physdev_op_compat handling
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>, Jan Beulich
	<jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Wei Liu
	<wl@xen.org>
References: <af2f934a-49d8-a15d-3b66-94abc0d39081@suse.com>
 <YWQMqq2Z9BNro9IL@MacBook-Air-de-Roger.local>
From: Andrew Cooper <andrew.cooper3@citrix.com>
Message-ID: <6b9172b0-4e98-5820-b340-b011c38edb30@citrix.com>
Date: Mon, 11 Oct 2021 15:06:10 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <YWQMqq2Z9BNro9IL@MacBook-Air-de-Roger.local>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Content-Language: en-GB
X-ClientProxiedBy: LO2P265CA0268.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:a1::16) To BYAPR03MB3623.namprd03.prod.outlook.com
 (2603:10b6:a02:aa::12)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 1866f379-65d8-43e9-d839-08d98cc04aba
X-MS-TrafficTypeDiagnostic: BYAPR03MB3942:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <BYAPR03MB3942A957AEF1E682A304A9B2BAB59@BYAPR03MB3942.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:3383;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: pVnT24/t87/t0dcBBYYdN/BZ7kUPpyjoMxZnQR8czqjXOhmmaP/MHJ4KsBV2mgsQCi5Fytv5ngOl8xKYJEFh1G/HKZ72UWk/JqrnZxd9UTZuqC8HO4LWt4arZ0QqYlB3uqQ7pB5PJCwzbkFDIqViX01p/FhCeKUgPlXr/XSbCsfjZjftnskP3FsiQEbiiX4GteGbEg0inDX6ZLKYMoyJl3lIN0D+p1/Egs08ExfKxpMs8iTYW89QsOO0mpQlsNE930SLXDhfqXxlVLLcDoP4EntigrZLKY/4mA2Ld5OX6bjj8WuPx5nWfrM9gM0eT7U7tq0fnGx6IlisbuhcASEQPr1J2Lf6CUxKMoGnkCmY2jEL+IdQehOsL6U+LKv213O/djwTWPvV/Pxfy2GPXSrg+FdM8KuTibsLV7bB+/VnY69/CI9l2EsH2TvE9U/GcZGAVb7goqPcsLSObCqGoIR3JdikJjeOE1t+zkNk5Qvc7DA41mq+HHBDRbfTTo50k7zjG4+t0Na1SpD5TGEeRWchzNbY515iyhsMN/u+RFBqNwUYpfqijaGFXKd41+5LjPMbxSHZAI2oPRNWE56mjSLbWdaK/e2WOPl+szivyv9uXdHVDNwVBctIMiVe3IRSI38p6ph97NnG4WynVSwjY128VrxTVNnXwW+t5Q95y0/d1UcDUawU6IyIoOgjd1QNNSSVZfxNEa7C7RXyM63Aq+s99eZl69oO6AtYP29Mu14ZK6qFi2yCoHED/mODspEyfpdV
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(26005)(316002)(8676002)(8936002)(186003)(2906002)(31686004)(38100700002)(6666004)(5660300002)(6486002)(31696002)(110136005)(508600001)(86362001)(66476007)(66556008)(16576012)(2616005)(4326008)(55236004)(4744005)(53546011)(36756003)(956004)(66946007)(54906003)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d3A1dnhCMnkxNEhjMGZFVTlWcCs1L25xNXpVYUh1WGpPZHlaVU10MXhQdDdH?=
 =?utf-8?B?RE4ySTFzL1Q3eEZLaUVDSWFKR0R6YWozei9UWEhJRnZHckk4S0dqazFkWkFa?=
 =?utf-8?B?eHhPUit3OXBwemUrRENSamE5MlVtM2ZsUkR6azB3bGVrOWxpd21OQUsrUktk?=
 =?utf-8?B?Qmk1akhuRnN4Tk02Q2ZKTUtZNndnbkVuWE93YVFKUjMzWTIvbWhGQktpaXhX?=
 =?utf-8?B?U01OSjlHWTRHc04zM0JXY3JrbXBzQ0YrUjJZalNoa3pNdW80eFBPZlp0cDlw?=
 =?utf-8?B?bU1xVXY5MFAxSDhMYU5Pc0JVNXhvQVQ2VnFmSUZONDhkWTlIKzRuYVZvYjZJ?=
 =?utf-8?B?NEw2Vzh4SlhkQXcrQVhsMVQvK3E5WHdnOXNPSGY1MGFOZzNjd2t0N08wS1pV?=
 =?utf-8?B?anRjUXRQeU00dGltRzFWNlA3dE0zaE9NTWZRcFB1Si9QcVpQNFVQK1ZUU254?=
 =?utf-8?B?NWJvdFVncjVrdTAwcEg1Y2RqRE9CVkhHNitUT3hZSmxNT0RFVmtwYVFtSW1H?=
 =?utf-8?B?UXB3TGZveGNDR3pvalllbmQwQzNYRzJ6bStmUzVETHhteXlOV2daQitJazZY?=
 =?utf-8?B?TkJUQUpqRTRmYkw0OWtJMERIY29Wb1JDMm5IeHpEWEwvSDY0TDdOTzN6ODRj?=
 =?utf-8?B?YSt2WlltckdaTlVhdjg5bVlnK0Nrb3Zsd0ova29WWGduUEFrYmRhbHo1UVEx?=
 =?utf-8?B?TWlIWk1KQVlUdXhObTVra0RNNkpvbXpiSEFoRDdkZjFCSUdpUVdLN1pVZCtq?=
 =?utf-8?B?SjNWYjV5NFQxSGZ4UTJRaFIwSlZMaE5STnlNZnZUTkxsY0l2R3MyUGUxVnho?=
 =?utf-8?B?RGtUUG1NbEwxYVJodkNJdlp4THZacWJGWDBCSFhjQjN4NFFWbXhNc1FyM1A5?=
 =?utf-8?B?VUlMMHZjdFJiRDdCRjVEOEdLbGNXN1M4SEZ0WGczNzhQWlJ3Wk15M2JSbnJ5?=
 =?utf-8?B?K1dUb01HVFVCVWhKRW9IUVRWbElrcGlqVktkK29Lay9MUUo2S21tckFES3Zv?=
 =?utf-8?B?TFZzQzNzdER0bk5BWHRJV2dyL1FKNGFsZ1pGMnZxd21HNk9lQ3dPTUxKSi81?=
 =?utf-8?B?cW9FR2xEejVubWl2MU9NcjdMYmgwb2diTzAzMHd2N1dvNVNobE5HVnVQQW9I?=
 =?utf-8?B?MHpKRkNPdEwzM1R3MWpaUVdyeHpyYUhYL3hFR2IvMU9JTW1XTUdPWmRpYzNr?=
 =?utf-8?B?VXNpZ1hFREp0SFNoQlUxdlFFY29tUkMzQmFqVE5oQ0RoVWJUQ2RwbUVwNFlT?=
 =?utf-8?B?azJEQ2FhT0xCOEVHajJ0Mndac3FnaTZyTU16c0VRYkk3VEoxMHFvVWk2amNj?=
 =?utf-8?B?RWpCbk1raE80ZXpLaFVITUNvQVpCcUNCemFKc2UvSXZuM2ZJWmRrTXYxTGhB?=
 =?utf-8?B?VGx0Q2lOTVNrQVdKRmlrZjE0WHIxdXZzMjh5R2Z6VFlmVkE2V1dXd0JwNmNU?=
 =?utf-8?B?RnBNZXAySFpHZEJjL0ozNHplcENiZjN3ZXlpYkhwald3ZitSbUNjajNFNDY5?=
 =?utf-8?B?TjBTWHhFT2IraVAzWUl0SGJ3bjlpR2lWQlMySTNsMXlicVZndDdqSll6MW83?=
 =?utf-8?B?SXNBVGtQamllbXdIYVFWa3NzR3lrYzZqelF5SXJkSDQrTjBLNUM1ZDNwTG9a?=
 =?utf-8?B?YStIYU40czZCSFpvR2JlYWY1Z3pnZUk2Z0dWSk84MUw4ZmFtemtyc25VUGV3?=
 =?utf-8?B?citFWFF4aDNPSnNUK25EeGp1dXBDWDhwcXk2dHh2MTArQWoxU3BEK1hhMzcw?=
 =?utf-8?Q?VDXluAyJOeR2oji/Bb4z8Uu/yqr+5nRsTnBZBr5?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 1866f379-65d8-43e9-d839-08d98cc04aba
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2021 14:06:16.6603
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: n82jN+xh33911bjKIHZdaDsdqpFWN2n0khq2ZEPwn1/RHs9+lCXSw17rGRdqMjo6uOHhUHdiQf4z+99fxaMwXXJq9PUzkMK68YyVxA6W/aE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB3942
X-OriginatorOrg: citrix.com

On 11/10/2021 11:06, Roger Pau Monné wrote:
> On Mon, Oct 11, 2021 at 10:20:41AM +0200, Jan Beulich wrote:
>> The conversion of the original code failed to recognize that the 32-bit
>> compat variant of this (sorry, two different meanings of "compat" here)
>> needs to continue to invoke the compat handler, not the native one.
>> Arrange for this by adding yet another #define.
>>
>> Affected functions (having existed prior to the introduction of the new
>> hypercall) are PHYSDEVOP_set_iobitmap and PHYSDEVOP_apic_{read,write}.
>> For all others the operand struct layout doesn't differ.
>>
>> Fixes: 1252e2823117 ("x86/pv: Export pv_hypercall_table[] rather than working around it in several ways")
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>

Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>


From xen-devel-bounces@lists.xenproject.org Mon Oct 11 14:10:40 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 14:10:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.206069.361538 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZw0k-0000OS-QI; Mon, 11 Oct 2021 14:10:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 206069.361538; Mon, 11 Oct 2021 14:10:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZw0k-0000OL-Mp; Mon, 11 Oct 2021 14:10:38 +0000
Received: by outflank-mailman (input) for mailman id 206069;
 Mon, 11 Oct 2021 14:10:37 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=9TNE=O7=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mZw0j-0000OF-JU
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 14:10:37 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 1f926520-0569-4a17-ac61-7a42d4446f2c;
 Mon, 11 Oct 2021 14:10:36 +0000 (UTC)
Received: from EUR03-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur03lp2050.outbound.protection.outlook.com [104.47.8.50]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-29-qolydffSNs274cFjWKww1g-1; Mon, 11 Oct 2021 16:10:34 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0401MB2448.eurprd04.prod.outlook.com (2603:10a6:800:52::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18; Mon, 11 Oct
 2021 14:10:32 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4587.026; Mon, 11 Oct 2021
 14:10:32 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS8PR04CA0201.eurprd04.prod.outlook.com (2603:10a6:20b:2f3::26) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.21 via Frontend
 Transport; Mon, 11 Oct 2021 14:10:31 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1f926520-0569-4a17-ac61-7a42d4446f2c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1633961435;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=Kw2Ceni+XQKt5NPbDV+odXhQltkoHaqKnhIsBoGwAhI=;
	b=HNVH5dtuOwbSU4UZtIcEd/8D9IemDVHK7/H1bdT9u24bBeUq1QsZG7+F0lBibO8NfPtpnX
	iFwsDH98+XvPFvb2OHis6cA5IEOLfClomiaL9K5V/nt0/rKi3gBMPeGJ9JLtK6ACR3xI1V
	b/21GeMoihkzT2KHkjTjCpmnFf2B3U8=
X-MC-Unique: qolydffSNs274cFjWKww1g-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=l5sfXKIUX0kB2mXa0M941WIFCj+U2Po/+B7/IANl9ZYauaAVp6zpDjFKBt4HQ8zm5MFUgnc0r0BQ9iJxWzy3cEyT+/4m1A82ma8QmZcZUrUCmAr+/HxnQfM5pp3Sh181i4k6zPMcCe7n7F8iQ6RCyCFrLeRJhTitf2s0WcVktmvby7fe0NEV2cBJjDvGBEbkINPzkp3a79/oaINL4VSYdY6Zh2P6u0vUQLjlB9mG4DD8ui+3yGqc4MwanTd2gJbmG+xXoux3bzZjntDymv+vcqffbU2ceifWlqCoF3V6gRYlXkBc9agiQZ3i8t3RADiYG006Ki164KVeSeJ349OoDQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Kw2Ceni+XQKt5NPbDV+odXhQltkoHaqKnhIsBoGwAhI=;
 b=iN4O637mQS+SMEVBiUdMc+uBIEt1ZmpLOz99jiBMQgDHFgJBz4RoAFf/UX+11q9UzaN+FyLi3+eZcUAWui4NdeAU0NUJMo/Z3IhMG2diTrunFJBs3EQrsZE0Vjf6KuzCjwWxaVHRNeVUZD1IcTDpiarJx8zAVV7N33+4EXiG2gdOhr+CJTxiRSCmouyJcGNWDT2OGGF5AukXz26bFUZnFdYclSoKR6YHhywTNwlRy5pHkXRNYuBg8p64wvQB2Xi2RC5yZ4WMd1F/G6B8rd6KYxQsJEZMAK0iCOsamr/SZ+jGbFGXqkoDJE5AOjNv6gu8hnZqsE7Kx6GqDqqrFjtsqA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [PATCH v5 08/11] xen/arm: Enable the existing x86 virtual PCI
 support for ARM.
To: Bertrand Marquis <Bertrand.Marquis@arm.com>
Cc: Rahul Singh <Rahul.Singh@arm.com>, Andre Przywara
 <Andre.Przywara@arm.com>, Stefano Stabellini <sstabellini@kernel.org>,
 Julien Grall <julien@xen.org>, Volodymyr Babchuk
 <Volodymyr_Babchuk@epam.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Wei Liu <wl@xen.org>, Paul Durrant <paul@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <cover.1633540842.git.rahul.singh@arm.com>
 <9bdca2cda5d2e83f94dc2423e55714273539760a.1633540842.git.rahul.singh@arm.com>
 <6752f2d3-171b-37f5-c809-82995a8f3f36@suse.com>
 <CEF7FFB0-779A-4F46-8667-6BCD9BA5CB6C@arm.com>
 <b735c2d3-1dbb-ce0a-c2fa-160d4c6938d3@suse.com>
 <A8DEBD07-FB45-4E4E-A2C3-7AF8B393B032@arm.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <59c9e102-c710-64d3-2a1a-cc8dcbcceead@suse.com>
Date: Mon, 11 Oct 2021 16:10:29 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <A8DEBD07-FB45-4E4E-A2C3-7AF8B393B032@arm.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8PR04CA0201.eurprd04.prod.outlook.com
 (2603:10a6:20b:2f3::26) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 2bbf2b29-072f-4367-1036-08d98cc0e2e9
X-MS-TrafficTypeDiagnostic: VI1PR0401MB2448:
X-Microsoft-Antispam-PRVS:
	<VI1PR0401MB2448767A3C3E45DDD7B7834FB3B59@VI1PR0401MB2448.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	/IBV0R7hY582V5lWg+ZWyjNmuvxfYDHD9KBKj5E6eQOGGLoGXUjMIsMmKEpHiXvXt+Cf7aJWOcm5D3mEt1ipJ1H3e6lIBEyLgc8cWvNAZNneStiRQhTbRAbXmc60j73XIzH8FKn3ZpjNkgXX35XIBViKc+qGJqYRyMQxCyxyUmDtw2vyShv/gcPKvV8zZrHDcKFWYrG0y9BzV/LotpQb5l0So7FzlB5eha7o/EHhixAGwquOdERsqAlkF+VW82XQaxUdht8Q0XLOOVhh3HGLjy1cWI+I8SqK4MqjfXdmDvaPiqNqYULIHESSEfzri2TwZW8sWoommTXZMlJX+NUIGOGKNwFMxq/kejAnfPwIevQxT2z9MWq3RUVCu/ySjLOS45tTGc1ZB4tvYcXoik/DLm+MpnK/lp+WAo0QflPRzriyUbNjPZ+Tjt+Cn3JGwV6Npw9D5eLBXg9ruMMQTguTMru+nqtW4TzO5ijHpnjU65PgGPVZwhr8s/iUkeorgPADBwG5TLVGcp3UGW6agTvyFEZR/s67KrmwGmJbaeMWeXO+lpoLVfaXdR8RzjBxTBxfb/TfzTlyQ003UtOXEt21E5krQD+eZdc7KsvSYiOiD8SyI8fowhCcpF1rOxs8dsJ1mv9OPIRjdFD9pmpnDRsiEMrQbxKzmioihwYpJQ8XcNK7Z0Gw9v5cjSxr4TabciDCD3H+GFscBbU52NTujhMoEE1SBROXEUtoOkdtoKpWMeDqqHXYxLDmA3VqMEcGkBd86w+ojfPSTD31P7Hf36N2sQ==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(66946007)(53546011)(7416002)(8936002)(36756003)(186003)(26005)(83380400001)(86362001)(5660300002)(6486002)(8676002)(38100700002)(6916009)(66556008)(16576012)(316002)(31696002)(66476007)(2906002)(2616005)(956004)(31686004)(54906003)(4326008)(508600001)(2004002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?d3JpZXZkaDcxdGVaZVlIeHVSZkIycytrZVpwdTVVY3JOUDdmOExET2V6WitO?=
 =?utf-8?B?bzFkbEFhVm9NRUh0YXlQRWRIRWNPOEpqVVdFaDdwL0E4eU85WWNFdVV4UWFx?=
 =?utf-8?B?NDR4b296RTJ6bjZYWnJhYW1JekFLVmRjbnJsYWp6TG1USm4yMitQYm91SWYy?=
 =?utf-8?B?NmViT1BuTUJYOVVaYWxxSWdvYWZKSnk5MWdnNHNXaVRTZEo0ZGJRdzZGeTdm?=
 =?utf-8?B?eWZWR055Ukg5cExUSHI1VjY1cXhtNGdBcTZLQXBSYkFhUStwa3VmQ1hkcm5J?=
 =?utf-8?B?QzY5L0I1MVBRNUVtQkZEOHJPZVNFQ2g1OWtOY3lETXl5d01RdVZNQUpGeVZw?=
 =?utf-8?B?K2JrWHlRb1NYWldEMW1UM0tBcWVSaS96UzhoSFhtVHpJd01HOVdHMmRQSng3?=
 =?utf-8?B?RXZKN2V3Q1pDVzFvL2dKeTl4c0d3ZWhhUGxLKzJKd2NUQ08vWjZUa2VZbXg5?=
 =?utf-8?B?TTRUSlhsNlVFanA5aEFtcjFXN0E0WjY4VzNRK09rNFhYdkZyRXIxWXJoazNo?=
 =?utf-8?B?QzQ3ZTJSQXY0WjZBMmdqQWZ5SE1YUmlMV1NkQXFUaGV1alZvMUFkR2JlOEtj?=
 =?utf-8?B?TVVGVHVTOTNGeHhWcVdOOVJFckRpM1daNGJ5czVIazNlRGxhOGRiRnQ4bWNH?=
 =?utf-8?B?RUxQNjdVV2FHNHZUdFlaRDlTL000ck92N2xJaDAvWEZOZ0R2VXdxT1UxMitw?=
 =?utf-8?B?dTR6dkhQRWc2NlByTHNIYWdyWXRpSHZrd1lHY3BYSnl5Tko4QjJZblZTUjlK?=
 =?utf-8?B?NzM3SFArU204RGNxZjBaZEtGNloyK1VKNFpsa1NTMkhBYTkybUg4QmU5QW1n?=
 =?utf-8?B?cnZSNERlb2wxQ2ZSREtQcTZLeWVvRkI0YzIrWVcwbVNoNWRsZ1BKQUdUOU01?=
 =?utf-8?B?ZFFPTzV6V1NReGhpV2t4bzRzaC9OUXJrY2pRTUd6cHE4NGZCSnJ0anpUK1Rw?=
 =?utf-8?B?SDJWZURROU42UTc0cGhVeFVoelpCTWFOVW5XbUUvby91eVpMcks2UDREMnRz?=
 =?utf-8?B?M0dZY2NnTFE3Z0RhbC9KWDE1NFFKZWtmaEsrMlB4cnpPd0hoVHdFNnF3b21l?=
 =?utf-8?B?M3FZdDZya09sSlpiMEhpMzJ3VDBJQmlIcXJDZHVjai9XNG02cFR4c0p4OFFI?=
 =?utf-8?B?UkFqUmtVVVF1YU5rUlpuUHUzTVdNQzRFV2xrV1RZSy9zSk16Y2dEbEcxRndp?=
 =?utf-8?B?VXhpZU1xbnJCSExaTHE5Vm5kdXJtZGY0eEJ3MnFTdkVUTi8yZm1CZkxsWDhS?=
 =?utf-8?B?NUx1V0NkZUl0MElXTG5lSTUveVRhZjFiQkZVOVlNdVFweDBVUk5aYkt5WFgy?=
 =?utf-8?B?ZG5jaHY5Wjc2MmZxSWwzS3ZEaDVqUTJFMkY4T1d0WmFoN0pleG9oOGZRb0xo?=
 =?utf-8?B?VzdzSE55Y2hSczdwTUt3V0JrZWdVWFRJSTBOaXhieVp5ZUViY1ZyMVhVSlVS?=
 =?utf-8?B?L3dadEdvcjgrYTBkb2FEeHFBbFZ4Q3k1NzByVGFBQ1E1L2RWT0NkQU1XbzlF?=
 =?utf-8?B?aXVSQlpHK0gzQnFxaHAxQTJMZmlWOUtDQlJBcUNoR1o5L28yNmVMZllWR1Rl?=
 =?utf-8?B?K09iQTgwWksrdHZCak9iVi9vdWx6K3o4Tm9PNnVaMmZET3lybGZXS0FEbWlt?=
 =?utf-8?B?aWIzbE9uMVYwRG15dDY2RFp3b3lNUWdrZkVFT2Q5Qmljak5FU0dvVlhqQ3N2?=
 =?utf-8?B?MFRWcWlwRlZWbmJTZE14NUU1L25Fd1dWdHVRZVh0c0laOEhYRkd6RjQ5Q2F5?=
 =?utf-8?Q?0LAdWfagb9jqs1WfMMJ/PVBNBnqMLDlPeNAaGAF?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2bbf2b29-072f-4367-1036-08d98cc0e2e9
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2021 14:10:31.9239
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: aaJrwGQFijOCBGTqQgOY4uuz7Wi4e1d1neDOkl6O5V2WQDIT7uFdKhJ45d1qRO3gTn/rzQL14ZZ12Rsv+oHylQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2448

On 11.10.2021 15:34, Bertrand Marquis wrote:
>> On 11 Oct 2021, at 14:09, Jan Beulich <jbeulich@suse.com> wrote:
>> On 11.10.2021 14:41, Bertrand Marquis wrote:
>>>> On 7 Oct 2021, at 14:43, Jan Beulich <jbeulich@suse.com> wrote:
>>>> On 06.10.2021 19:40, Rahul Singh wrote:
>>>>> --- /dev/null
>>>>> +++ b/xen/arch/arm/vpci.c
>>>>> @@ -0,0 +1,102 @@
>>>>> +/*
>>>>> + * xen/arch/arm/vpci.c
>>>>> + *
>>>>> + * This program is free software; you can redistribute it and/or modify
>>>>> + * it under the terms of the GNU General Public License as published by
>>>>> + * the Free Software Foundation; either version 2 of the License, or
>>>>> + * (at your option) any later version.
>>>>> + *
>>>>> + * This program is distributed in the hope that it will be useful,
>>>>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
>>>>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>>>>> + * GNU General Public License for more details.
>>>>> + */
>>>>> +#include <xen/sched.h>
>>>>> +
>>>>> +#include <asm/mmio.h>
>>>>> +
>>>>> +#define REGISTER_OFFSET(addr)  ( (addr) & 0x00000fff)
>>>>
>>>> Nit: Stray blank (like you had in an earlier version for MMCFG_BDF()).
>>>> Also isn't this effectively part of the public interface (along with
>>>> MMCFG_BDF()), alongside GUEST_VPCI_ECAM_{BASE,SIZE}?
>>>
>>> I will move that in the next version to xen/pci.h and rename itMMCFG_REG_OFFSET.
>>> Would that be ok ?
>>
>> That would be okay and make sense when put next to MMCFG_BDF(), but
>> it would not address my comment: That still wouldn't be the public
>> interface. Otoh you only mimic hardware behavior, so perhaps the
>> splitting of the address isn't as relevant to put there as would be
>> GUEST_VPCI_ECAM_{BASE,SIZE}.
> 
> Ok now I get what you wanted.
> 
> You would actually like both MMCFG_BDF and MMCFG_REG_OFFSET to
> be moved to arch-arm.h.
> 
> Then I am not quite sure to follow why.
> Those are not macros coming out of a way we have to define this but from
> how it works in standard PCI.
> The base and size are needed to know where the PCI bus will be.
> 
> So why should those be needed in public headers ?

Well, see my "Otoh ..." in the earlier reply. Keeping the two
address splitting macros out of there is okay.

>>>>> --- a/xen/drivers/passthrough/pci.c
>>>>> +++ b/xen/drivers/passthrough/pci.c
>>>>> @@ -766,6 +766,24 @@ int pci_add_device(u16 seg, u8 bus, u8 devfn,
>>>>>    else
>>>>>        iommu_enable_device(pdev);
>>>>
>>>> Please note the context above; ...
>>>>
>>>>> +#ifdef CONFIG_ARM
>>>>> +    /*
>>>>> +     * On ARM PCI devices discovery will be done by Dom0. Add vpci handler when
>>>>> +     * Dom0 inform XEN to add the PCI devices in XEN.
>>>>> +     */
>>>>> +    ret = vpci_add_handlers(pdev);
>>>>> +    if ( ret )
>>>>> +    {
>>>>> +        printk(XENLOG_ERR "setup of vPCI failed: %d\n", ret);
>>>>> +        pci_cleanup_msi(pdev);
>>>>> +        ret = iommu_remove_device(pdev);
>>>>> +        if ( pdev->domain )
>>>>> +            list_del(&pdev->domain_list);
>>>>> +        free_pdev(pseg, pdev);
>>>>
>>>> ... you unconditionally undo the if() part of the earlier conditional;
>>>> is there any guarantee that the other path can't ever be taken, now
>>>> and forever? If it can't be taken now (which I think is the case as
>>>> long as Dom0 wouldn't report the same device twice), then at least some
>>>> precaution wants taking. Maybe moving your addition into that if()
>>>> could be an option.
>>>>
>>>> Furthermore I continue to wonder whether this ordering is indeed
>>>> preferable over doing software setup before hardware arrangements. This
>>>> would address the above issue as well as long as vpci_add_handlers() is
>>>> idempotent. And it would likely simplify error cleanup.
>>>
>>> I agree with you so I will move this code block before iommu part.
>>>
>>> But digging deeper into this, I would have 2 questions:
>>>
>>> - msi_cleanup was done there after a request from Stefano, but is not
>>> done in case or iommu error, is there an issue to solve here ?
>>
>> Maybe, but I'm not sure. This very much depends on what a domain
>> could in principle do with a partly set-up device. Plus let's
>> not forget that we're talking of only Dom0 here (for now at least,
>> i.e. not considering the dom0less case).
>>
>> But I'd also like to further defer to Stefano.
> 
> Ok, I must admit I do not really see at that stage why doing an MSI cleanup
> could be needed so I will wait for Stefano to know if I need to keep this when
> moving the block up (at the end it is theoretical right now as this is empty).
> 
>>
>>> Same could also go for the free_pdev ?
>>
>> I think it's wrong to free_pdev() here. We want to internally keep
>> record of the device, even if the device ends up unusable. The only
>> place where free_pdev() ought to be called is imo pci_remove_device().
> 
> Ok.
> 
>>
>>> - cleanup code was exactly the same as pci_remove_device code.
>>> Should the question about the path also be checked there ?
>>
>> I'm sorry, but I'm afraid I don't see what "the path" refers to
>> here. You can't mean the conditional in pci_add_device() selecting
>> between iommu_add_device() and iommu_enable_device(), as "remove"
>> can only mean "remove", never "disable".
> 
> I will try to explain: when we just enable we do not add an entry in the list but
> we still remove an entry from the list every time (as the condition becomes
> always true because pdev->domain is at the end always set)

Well, that anomaly is what I did point out in my review remarks to
Rahul. We shouldn't remove an entry from the list if we didn't add
one. But quite likely, if we don't free the pdev, we shouldn't be
removing the list entry in either case.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Oct 11 14:12:10 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 14:12:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.206076.361549 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZw2B-0000ys-6h; Mon, 11 Oct 2021 14:12:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 206076.361549; Mon, 11 Oct 2021 14:12:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZw2B-0000yl-2z; Mon, 11 Oct 2021 14:12:07 +0000
Received: by outflank-mailman (input) for mailman id 206076;
 Mon, 11 Oct 2021 14:12:05 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=LfEM=O7=arm.com=Bertrand.Marquis@srs-us1.protection.inumbo.net>)
 id 1mZw29-0000yb-6F
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 14:12:05 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com (unknown
 [2a01:111:f400:7d00::60d])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 97eed629-da15-405c-8fa1-249a4e4a0faf;
 Mon, 11 Oct 2021 14:12:03 +0000 (UTC)
Received: from AM7PR03CA0002.eurprd03.prod.outlook.com (2603:10a6:20b:130::12)
 by DB6PR0802MB2421.eurprd08.prod.outlook.com (2603:10a6:4:a2::9) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.25; Mon, 11 Oct
 2021 14:11:47 +0000
Received: from VE1EUR03FT011.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:130:cafe::f0) by AM7PR03CA0002.outlook.office365.com
 (2603:10a6:20b:130::12) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.25 via Frontend
 Transport; Mon, 11 Oct 2021 14:11:47 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT011.mail.protection.outlook.com (10.152.18.134) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4587.18 via Frontend Transport; Mon, 11 Oct 2021 14:11:46 +0000
Received: ("Tessian outbound 16951d3c485e:v103");
 Mon, 11 Oct 2021 14:11:46 +0000
Received: from 5fa1bcd0f690.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 7483AFAE-BF36-48CA-8186-6061C648D1E5.1; 
 Mon, 11 Oct 2021 14:11:34 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 5fa1bcd0f690.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Mon, 11 Oct 2021 14:11:34 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com (2603:10a6:4:74::9)
 by DB8PR08MB5260.eurprd08.prod.outlook.com (2603:10a6:10:e6::31) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.24; Mon, 11 Oct
 2021 14:11:33 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955]) by DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955%4]) with mapi id 15.20.4587.026; Mon, 11 Oct 2021
 14:11:32 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 97eed629-da15-405c-8fa1-249a4e4a0faf
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=xxKC7lWVnPNp8WMxqbuowokiyEdbu/+JK4PNgbkbPoY=;
 b=EI9JQQWyVouV0L8zkhXoeJjTjHpq08q7LiLxqY49f+G6nGLh2Geg28Y3RBB+/+MehyJ6kVx0MYkTKVhClunwplGvJrtK21edf/o7i4qNSxEqE0I3+4jLcWY/rjMVvZ+s2LrCRSlw9eAzl9u72gxV2AFE726fxq4UA9/T4P6tM1E=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: b9c1d0c5fdc52903
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=FcHOPe+wq7A9FI3hiyANP4haKjxtXbEsDAb00v4AUaesWXsGPFte9Lz7RcrJN1Dcuw8vTNuvbDGOZ9b7ul8EMk7ilVhsntqoRckvDiGR2wtWcFtd72lW5/7AEjrPX1ulzjJ2rX0Tq6kH5+6RKGimE/cIxdfG+RueWOPy4MK6rr3c7u5549wRddDXZjDk+9HdnC08mIdXIULE1xDQ1rBKS0L2GGX4602FgPeArRGwwyqDyog0XEvgVSI2hSHr29QRW7NHYDNceZZfoehayT0Wxm5ilDd95HeRxSB+N65C5DpZINn4pUTlowKaNDU66ac6D0BbhigJdtZiL4UCSe8K5w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=xxKC7lWVnPNp8WMxqbuowokiyEdbu/+JK4PNgbkbPoY=;
 b=IdlDWcB/Z7Hag19v0CO9SNe2UIBnoAGx77ABk9uEtJB+DBQIvygqB+wM+BsPEsSVNkHsWgHiD0IFBV2IeFXOHIClZbjFGkxDTBmSVq70YOVbm/zBxlhKFn+wdy79b5RbEECFpb51HsU0iWAA2o3Po/xypjdCf0H8YsqOAK3hpW/ezyOdAcCMw1dhYPw4qJiKhkZQi5E3+Fht0+vQe9ojL2A93fULi+bfO49pcJgJOrQntNoETxw8x4dk139GOjXHTawOxN3x8iHsFDg16/0UUkvwxKdjVHQYOYN10XPeJVrjDmvyQ9jv+hJ+rrAKOwCrcMKLa7D/Eed6poWEf2WIqQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=xxKC7lWVnPNp8WMxqbuowokiyEdbu/+JK4PNgbkbPoY=;
 b=EI9JQQWyVouV0L8zkhXoeJjTjHpq08q7LiLxqY49f+G6nGLh2Geg28Y3RBB+/+MehyJ6kVx0MYkTKVhClunwplGvJrtK21edf/o7i4qNSxEqE0I3+4jLcWY/rjMVvZ+s2LrCRSlw9eAzl9u72gxV2AFE726fxq4UA9/T4P6tM1E=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Julien Grall <julien@xen.org>
CC: Michal Orzel <Michal.Orzel@arm.com>, Xen-devel
	<xen-devel@lists.xenproject.org>, Ian Jackson <iwj@xenproject.org>, Wei Liu
	<wl@xen.org>, Andrew Cooper <andrew.cooper3@citrix.com>, George Dunlap
	<george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>, Stefano
 Stabellini <sstabellini@kernel.org>, Nick Rosbrook <rosbrookn@ainfosec.com>,
	Anthony PERARD <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>,
	Christian Lindig <christian.lindig@citrix.com>, David Scott
	<dave@recoil.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH v4 3/3] xen: Expose the PMU to the guests
Thread-Topic: [PATCH v4 3/3] xen: Expose the PMU to the guests
Thread-Index: AQHXvn6Qu4OqYnEUu02nRnOP3J3zSKvNlm2AgABAXYA=
Date: Mon, 11 Oct 2021 14:11:32 +0000
Message-ID: <A79191BC-6B58-4438-9CF9-551A2A7F9FF7@arm.com>
References: <20211011090047.8878-1-michal.orzel@arm.com>
 <20211011090047.8878-4-michal.orzel@arm.com>
 <a91ddbf4-d1bc-40b5-b971-35dbcdc4d8a3@xen.org>
In-Reply-To: <a91ddbf4-d1bc-40b5-b971-35dbcdc4d8a3@xen.org>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3654.120.0.1.13)
Authentication-Results-Original: xen.org; dkim=none (message not signed)
 header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: 6e7b6cce-c0eb-4c92-bd47-08d98cc10fa9
x-ms-traffictypediagnostic: DB8PR08MB5260:|DB6PR0802MB2421:
x-ms-exchange-transport-forked: True
X-Microsoft-Antispam-PRVS:
	<DB6PR0802MB242191F9335E15550F9ADAB99DB59@DB6PR0802MB2421.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:10000;OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 MvY56hv4+igEqH1L/Qa7ItQicnk2SKUiYiMPMM9Z4jbFKqWDnM215F4u7hLJCjcZBiSDgAD8XxJs82um560lVT8is8+0QvxeYa6P9pKv1w4HAXnWt1iJORLmaXUhzuryloqnaMNitLDh2liT6Rj20yzZn3Zkcf32wHAtvnn0TQ+Y8J7BMJtVWALI4eWgDgdq4/hZtGayeBrka8IZDqM+sDKBSK0o57HY5d0NslsFny8Mtvm8GpcLJfPzKgAsGkQVIFe9t08w+glQQpdqry15Yj0DGNG4eTj8w+exwCMguOVLR3ojCsRjBzlNQWeTO8ygaaYvipSU0WaaI2FhOT4tIaQM+MoAhh4Uy9BhqwoYCmfDfDBQP0Z4HTT7aYC1Yxv8rxaBuCrdT1RW3/OTF14sljEdSdDQxxvKnL13Ki+wTRJQvTCSfYr9wrmVLtZxgTkINH5jDSN6Yb6qnEn0ipUQVb3ir03QxRCA7D/rfkD0f/MbkEXrpjoRzkzOeq2X89HRzwUjgWDHkZafyAqhAgUMGDQb+KL7Ap1hu4CW0QEO/W2aTv2I5ojLJUkfauVafW4XcSGdiDYcowRg8Vxe+iXKbf4TLs4Fp/HJ8GtpBDeCeoQXMJW6mxgVagXcu1SZRmzrLYUjInt653lnh2NOeiL8WPCv/0GwWrb+a4ZRTBGd3RGXu2+X64b8ApKTuMwkc1Hj1QZk9FYL5ceySWMiYOr2eKWf1nvmqFBe7Ql06rb/hRpZuIQ2VFG9UBnxKlfVis4+
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB6PR0801MB2024.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(8676002)(508600001)(36756003)(316002)(2906002)(91956017)(66446008)(66946007)(64756008)(76116006)(83380400001)(66556008)(66476007)(86362001)(33656002)(5660300002)(71200400001)(186003)(26005)(122000001)(7416002)(38100700002)(6486002)(8936002)(38070700005)(2616005)(54906003)(30864003)(6512007)(6916009)(53546011)(6506007)(4326008)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-ID: <71D2193E5860A245B91D490F9F841A38@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB5260
Original-Authentication-Results: xen.org; dkim=none (message not signed)
 header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT011.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	9d71087f-fc31-4baa-0b3f-08d98cc1074b
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	VoRA6MiBh7e8htHTxy4VCZmd5LnZGvxt6cQo2B1xd+iFG2WGtjVZG+0qXmwzQykyyGBXI/3ayjuPfRoc8kh40SPViYugV9vKnqQtjkFkmQB2hqmXKUmKN8Ttd8j3LwN5rsU9Enhku9wL9dQ4RJDFKQjMwifTmntFP+9QIzF0HGphGl1uttxDfBlkJMID16z3y+I5XJISvgtge8ZSdUjTw3DZVI+iUFVKZYAfMlUyBK6QIjbhw+YvYgjebfWdaop1hgQnhe0mOua8By/VO3g5vcSIdzXpfHGwmhy0372BGpzAJqnyBTMww2twRgL4ERWbiHCQjphEJytxmkFS0svcLbWuxDY3+LtqeTy+dfiG8P6zrQhm2pw/HR9W7vA9wl3MVRZrCdPf57zypTBxAHCe4uUXpfdFpbFwhj9WKzLHjbRnEo2RNUSeX56Iy8d30LlcnqVayPPFoPn3bxFt0cbLXNaaxUAvFfd8ay8Eck8+P0BTOeXjyB6z+BscrNk4WFs8zNo35Th8DqaLWlg5oNymwaJB4YTloqcCRaI+W7+bRoMmDqHcttyqYRzFih+iZLKp0rKPuCqQ0uKbOxxknlD4TDosi56zXJ9VF4BgabHU/DgIml+cATIJm6awstnIm7+QluF8zeBeuwohQqV7RFyPX2Ed/0HC3i9XNG9aN9K9gLKXBLCQYmDlT0wxL95IC3eqnW4afF9yvOhHvmOxZKIn+Q==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(81166007)(6486002)(53546011)(6506007)(36860700001)(186003)(82310400003)(26005)(33656002)(508600001)(356005)(316002)(86362001)(30864003)(83380400001)(2906002)(47076005)(70206006)(54906003)(8676002)(4326008)(36756003)(8936002)(336012)(6512007)(5660300002)(107886003)(2616005)(6862004)(70586007);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2021 14:11:46.7545
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 6e7b6cce-c0eb-4c92-bd47-08d98cc10fa9
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT011.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0802MB2421

SGkgSnVsaWVuLA0KDQo+IE9uIDExIE9jdCAyMDIxLCBhdCAxMToyMSwgSnVsaWVuIEdyYWxsIDxq
dWxpZW5AeGVuLm9yZz4gd3JvdGU6DQo+IA0KPiBIaSBNaWNoYWwsDQo+IA0KPiBPbiAxMS8xMC8y
MDIxIDEwOjAwLCBNaWNoYWwgT3J6ZWwgd3JvdGU6DQo+PiBBZGQgcGFyYW1ldGVyIHZwbXUgdG8g
eGwgZG9tYWluIGNvbmZpZ3VyYXRpb24gc3ludGF4DQo+PiB0byBlbmFibGUgdGhlIGFjY2VzcyB0
byBQTVUgcmVnaXN0ZXJzIGJ5IGRpc2FibGluZw0KPj4gdGhlIFBNVSB0cmFwcyhjdXJyZW50bHkg
b25seSBmb3IgQVJNKS4NCj4+IFRoZSBjdXJyZW50IHN0YXR1cyBpcyB0aGF0IHRoZSBQTVUgcmVn
aXN0ZXJzIGFyZSBub3QNCj4+IHZpcnR1YWxpemVkIGFuZCB0aGUgcGh5c2ljYWwgcmVnaXN0ZXJz
IGFyZSBkaXJlY3RseQ0KPj4gYWNjZXNzaWJsZSB3aGVuIHRoaXMgcGFyYW1ldGVyIGlzIGVuYWJs
ZWQuIFRoZXJlIGlzIG5vDQo+PiBpbnRlcnJ1cHQgc3VwcG9ydCBhbmQgWGVuIHdpbGwgbm90IHNh
dmUvcmVzdG9yZSB0aGUNCj4+IHJlZ2lzdGVyIHZhbHVlcyBvbiBjb250ZXh0IHN3aXRjaGVzLg0K
Pj4gUGxlYXNlIG5vdGUgdGhhdCB0aGlzIGZlYXR1cmUgaXMgZXhwZXJpbWVudGFsLg0KPj4gU2ln
bmVkLW9mZi1ieTogTWljaGFsIE9yemVsIDxtaWNoYWwub3J6ZWxAYXJtLmNvbT4NCj4+IFNpZ25l
ZC1vZmYtYnk6IEp1bGllbiBHcmFsbCA8anVsaWVuQHhlbi5vcmc+DQo+PiBSZXZpZXdlZC1ieTog
QmVydHJhbmQgTWFycXVpcyA8YmVydHJhbmQubWFycXVpc0Bhcm0uY29tPg0KPj4gLS0tDQo+PiBD
aGFuZ2VzIHNpbmNlIHYzOg0KPj4gLWZhaWwgaWYgdnBtdSBpcyBzZXQgYnV0IG5vdCBzdXBwb3J0
ZWQNCj4+IC1yZWJhc2Ugb24gdG9wIG9mIGxhdGVzdCBzdGFnaW5nDQo+PiBDaGFuZ2VzIHNpbmNl
IHYyOg0KPj4gLXJlbW92ZSByZWR1bmRhbnQgY2hlY2sgZnJvbSB4ODYgY29kZQ0KPj4gLWRvIG5v
dCBkZWZpbmUgYml0IHBvc2l0aW9uIGFuZCBtYXNrIHNlcGFyYXRlbHkNCj4+IENoYW5nZXMgc2lu
Y2UgdjE6DQo+PiAtbW9kaWZ5IHZwbXUgcGFyYW1ldGVyIHRvIGJlIGNvbW1vbiByYXRoZXIgdGhh
biBhcmNoIHNwZWNpZmljDQo+PiAtLS0NCj4+ICBkb2NzL21hbi94bC5jZmcuNS5wb2QuaW4gICAg
ICAgICAgICAgfCAxNyArKysrKysrKysrKysrKysrKw0KPj4gIHRvb2xzL2dvbGFuZy94ZW5saWdo
dC9oZWxwZXJzLmdlbi5nbyB8ICA2ICsrKysrKw0KPj4gIHRvb2xzL2dvbGFuZy94ZW5saWdodC90
eXBlcy5nZW4uZ28gICB8ICAxICsNCj4+ICB0b29scy9pbmNsdWRlL2xpYnhsLmggICAgICAgICAg
ICAgICAgfCAgNiArKysrKysNCj4+ICB0b29scy9saWJzL2xpZ2h0L2xpYnhsX2NyZWF0ZS5jICAg
ICAgfCAxMCArKysrKysrKysrDQo+PiAgdG9vbHMvbGlicy9saWdodC9saWJ4bF90eXBlcy5pZGwg
ICAgIHwgIDIgKysNCj4+ICB0b29scy9vY2FtbC9saWJzL3hjL3hlbmN0cmwubWwgICAgICAgfCAg
MSArDQo+PiAgdG9vbHMvb2NhbWwvbGlicy94Yy94ZW5jdHJsLm1saSAgICAgIHwgIDEgKw0KPj4g
IHRvb2xzL3hsL3hsX3BhcnNlLmMgICAgICAgICAgICAgICAgICB8ICAyICsrDQo+PiAgeGVuL2Fy
Y2gvYXJtL2RvbWFpbi5jICAgICAgICAgICAgICAgIHwgMTIgKysrKysrKysrLS0tDQo+PiAgeGVu
L2FyY2gvYXJtL3NldHVwLmMgICAgICAgICAgICAgICAgIHwgIDEgKw0KPj4gIHhlbi9jb21tb24v
ZG9tYWluLmMgICAgICAgICAgICAgICAgICB8IDEwICsrKysrKysrKy0NCj4+ICB4ZW4vaW5jbHVk
ZS9hc20tYXJtL2RvbWFpbi5oICAgICAgICAgfCAgMSArDQo+PiAgeGVuL2luY2x1ZGUvcHVibGlj
L2RvbWN0bC5oICAgICAgICAgIHwgIDQgKysrLQ0KPj4gIDE0IGZpbGVzIGNoYW5nZWQsIDY5IGlu
c2VydGlvbnMoKyksIDUgZGVsZXRpb25zKC0pDQo+PiBkaWZmIC0tZ2l0IGEvZG9jcy9tYW4veGwu
Y2ZnLjUucG9kLmluIGIvZG9jcy9tYW4veGwuY2ZnLjUucG9kLmluDQo+PiBpbmRleCA0YjFlMzAy
OGQyLi41NWM0ODgxMjA1IDEwMDY0NA0KPj4gLS0tIGEvZG9jcy9tYW4veGwuY2ZnLjUucG9kLmlu
DQo+PiArKysgYi9kb2NzL21hbi94bC5jZmcuNS5wb2QuaW4NCj4+IEBAIC02OTAsNiArNjkwLDIz
IEBAIGRlZmF1bHQuDQo+PiAgQjxOT1RFPjogQWNjZXB0YWJsZSB2YWx1ZXMgYXJlIHBsYXRmb3Jt
IHNwZWNpZmljLiAgRm9yIEludGVsIFByb2Nlc3Nvcg0KPj4gIFRyYWNlLCB0aGlzIHZhbHVlIG11
c3QgYmUgYSBwb3dlciBvZiAyIGJldHdlZW4gNGsgYW5kIDE2TS4NCj4+ICArPWl0ZW0gQjx2cG11
PUJPT0xFQU4+DQo+PiArDQo+PiArQ3VycmVudGx5IEFSTSBvbmx5Lg0KPj4gKw0KPj4gK1NwZWNp
ZmllcyB3aGV0aGVyIHRvIGVuYWJsZSB0aGUgYWNjZXNzIHRvIFBNVSByZWdpc3RlcnMgYnkgZGlz
YWJsaW5nDQo+PiArdGhlIFBNVSB0cmFwcy4NCj4+ICsNCj4+ICtUaGUgUE1VIHJlZ2lzdGVycyBh
cmUgbm90IHZpcnR1YWxpemVkIGFuZCB0aGUgcGh5c2ljYWwgcmVnaXN0ZXJzIGFyZSBkaXJlY3Rs
eQ0KPj4gK2FjY2Vzc2libGUgd2hlbiB0aGlzIHBhcmFtZXRlciBpcyBlbmFibGVkLiBUaGVyZSBp
cyBubyBpbnRlcnJ1cHQgc3VwcG9ydCBhbmQNCj4+ICtYZW4gd2lsbCBub3Qgc2F2ZS9yZXN0b3Jl
IHRoZSByZWdpc3RlciB2YWx1ZXMgb24gY29udGV4dCBzd2l0Y2hlcy4NCj4+ICsNCj4+ICt2UE1V
LCBieSBkZXNpZ24gYW5kIHB1cnBvc2UsIGV4cG9zZXMgc3lzdGVtIGxldmVsIHBlcmZvcm1hbmNl
DQo+PiAraW5mb3JtYXRpb24gdG8gdGhlIGd1ZXN0LiBPbmx5IHRvIGJlIHVzZWQgYnkgc3VmZmlj
aWVudGx5IHByaXZpbGVnZWQNCj4+ICtkb21haW5zLiBUaGlzIGZlYXR1cmUgaXMgY3VycmVudGx5
IGluIGV4cGVyaW1lbnRhbCBzdGF0ZS4NCj4gDQo+IFBsZWFzZSB1cGRhdGUgU1VQUE9SVC5NRCB0
byBtZW50aW9uIHRoZSBzdXBwb3J0IG9mIHRoaXMgZmVhdHVyZS4NCj4gDQo+PiArDQo+PiArSWYg
dGhpcyBvcHRpb24gaXMgbm90IHNwZWNpZmllZCB0aGVuIGl0IHdpbGwgZGVmYXVsdCB0byBCPGZh
bHNlPi4NCj4+ICsNCj4+ICA9YmFjaw0KPj4gICAgPWhlYWQyIERldmljZXMNCj4+IGRpZmYgLS1n
aXQgYS90b29scy9nb2xhbmcveGVubGlnaHQvaGVscGVycy5nZW4uZ28gYi90b29scy9nb2xhbmcv
eGVubGlnaHQvaGVscGVycy5nZW4uZ28NCj4+IGluZGV4IGM4NjY5ODM3ZDguLjI0NDk1ODBiYWQg
MTAwNjQ0DQo+PiAtLS0gYS90b29scy9nb2xhbmcveGVubGlnaHQvaGVscGVycy5nZW4uZ28NCj4+
ICsrKyBiL3Rvb2xzL2dvbGFuZy94ZW5saWdodC9oZWxwZXJzLmdlbi5nbw0KPj4gQEAgLTExMTks
NiArMTExOSw5IEBAIHJldHVybiBmbXQuRXJyb3JmKCJjb252ZXJ0aW5nIGZpZWxkIEFyY2hYODYu
TXNyUmVsYXhlZDogJXYiLCBlcnIpDQo+PiAgfQ0KPj4gIHguQWx0cDJNID0gQWx0cDJNTW9kZSh4
Yy5hbHRwMm0pDQo+PiAgeC5WbXRyYWNlQnVmS2IgPSBpbnQoeGMudm10cmFjZV9idWZfa2IpDQo+
PiAraWYgZXJyIDo9IHguVnBtdS5mcm9tQygmeGMudnBtdSk7ZXJyICE9IG5pbCB7DQo+PiArcmV0
dXJuIGZtdC5FcnJvcmYoImNvbnZlcnRpbmcgZmllbGQgVnBtdTogJXYiLCBlcnIpDQo+PiArfQ0K
Pj4gICAgIHJldHVybiBuaWx9DQo+PiAgQEAgLTE2MDAsNiArMTYwMyw5IEBAIHJldHVybiBmbXQu
RXJyb3JmKCJjb252ZXJ0aW5nIGZpZWxkIEFyY2hYODYuTXNyUmVsYXhlZDogJXYiLCBlcnIpDQo+
PiAgfQ0KPj4gIHhjLmFsdHAybSA9IEMubGlieGxfYWx0cDJtX21vZGUoeC5BbHRwMk0pDQo+PiAg
eGMudm10cmFjZV9idWZfa2IgPSBDLmludCh4LlZtdHJhY2VCdWZLYikNCj4+ICtpZiBlcnIgOj0g
eC5WcG11LnRvQygmeGMudnBtdSk7IGVyciAhPSBuaWwgew0KPj4gK3JldHVybiBmbXQuRXJyb3Jm
KCJjb252ZXJ0aW5nIGZpZWxkIFZwbXU6ICV2IiwgZXJyKQ0KPj4gK30NCj4+ICAgICByZXR1cm4g
bmlsDQo+PiAgIH0NCj4+IGRpZmYgLS1naXQgYS90b29scy9nb2xhbmcveGVubGlnaHQvdHlwZXMu
Z2VuLmdvIGIvdG9vbHMvZ29sYW5nL3hlbmxpZ2h0L3R5cGVzLmdlbi5nbw0KPj4gaW5kZXggNDVm
MmNiYTNkMi4uYjJlOGJkMWE4NSAxMDA2NDQNCj4+IC0tLSBhL3Rvb2xzL2dvbGFuZy94ZW5saWdo
dC90eXBlcy5nZW4uZ28NCj4+ICsrKyBiL3Rvb2xzL2dvbGFuZy94ZW5saWdodC90eXBlcy5nZW4u
Z28NCj4+IEBAIC01MjEsNiArNTIxLDcgQEAgTXNyUmVsYXhlZCBEZWZib29sDQo+PiAgfQ0KPj4g
IEFsdHAyTSBBbHRwMk1Nb2RlDQo+PiAgVm10cmFjZUJ1ZktiIGludA0KPj4gK1ZwbXUgRGVmYm9v
bA0KPj4gIH0NCj4+ICAgIHR5cGUgRG9tYWluQnVpbGRJbmZvVHlwZVVuaW9uIGludGVyZmFjZSB7
DQo+PiBkaWZmIC0tZ2l0IGEvdG9vbHMvaW5jbHVkZS9saWJ4bC5oIGIvdG9vbHMvaW5jbHVkZS9s
aWJ4bC5oDQo+PiBpbmRleCBlYzVlM2JhZGFlLi5lZTczZWIwNmYxIDEwMDY0NA0KPj4gLS0tIGEv
dG9vbHMvaW5jbHVkZS9saWJ4bC5oDQo+PiArKysgYi90b29scy9pbmNsdWRlL2xpYnhsLmgNCj4+
IEBAIC01MDgsNiArNTA4LDEyIEBADQo+PiAgICovDQo+PiAgI2RlZmluZSBMSUJYTF9IQVZFX1BI
WVNJTkZPX0NBUF9WUE1VIDENCj4+ICArLyoNCj4+ICsgKiBMSUJYTF9IQVZFX1ZQTVUgaW5kaWNh
dGVzIHRoYXQgbGlieGxfZG9tYWluX2J1aWxkX2luZm8gaGFzIGEgdnBtdSBwYXJhbWV0ZXIsDQo+
PiArICogd2hpY2ggYWxsb3dzIHRvIGVuYWJsZSB0aGUgYWNjZXNzIHRvIFBNVSByZWdpc3RlcnMu
DQo+PiArICovDQo+PiArI2RlZmluZSBMSUJYTF9IQVZFX1ZQTVUgMQ0KPj4gKw0KPj4gIC8qDQo+
PiAgICogbGlieGwgQUJJIGNvbXBhdGliaWxpdHkNCj4+ICAgKg0KPj4gZGlmZiAtLWdpdCBhL3Rv
b2xzL2xpYnMvbGlnaHQvbGlieGxfY3JlYXRlLmMgYi90b29scy9saWJzL2xpZ2h0L2xpYnhsX2Ny
ZWF0ZS5jDQo+PiBpbmRleCBlMzU2YjIxMDZkLi4yYTAyMzRlYzE2IDEwMDY0NA0KPj4gLS0tIGEv
dG9vbHMvbGlicy9saWdodC9saWJ4bF9jcmVhdGUuYw0KPj4gKysrIGIvdG9vbHMvbGlicy9saWdo
dC9saWJ4bF9jcmVhdGUuYw0KPj4gQEAgLTkxLDYgKzkxLDcgQEAgaW50IGxpYnhsX19kb21haW5f
YnVpbGRfaW5mb19zZXRkZWZhdWx0KGxpYnhsX19nYyAqZ2MsDQo+PiAgICAgIH0NCj4+ICAgICAg
ICBsaWJ4bF9kZWZib29sX3NldGRlZmF1bHQoJmJfaW5mby0+ZGV2aWNlX21vZGVsX3N0dWJkb21h
aW4sIGZhbHNlKTsNCj4+ICsgICAgbGlieGxfZGVmYm9vbF9zZXRkZWZhdWx0KCZiX2luZm8tPnZw
bXUsIGZhbHNlKTsNCj4+ICAgICAgICBpZiAobGlieGxfZGVmYm9vbF92YWwoYl9pbmZvLT5kZXZp
Y2VfbW9kZWxfc3R1YmRvbWFpbikgJiYNCj4+ICAgICAgICAgICFiX2luZm8tPmRldmljZV9tb2Rl
bF9zc2lkcmVmKQ0KPj4gQEAgLTYyMiw2ICs2MjMsOSBAQCBpbnQgbGlieGxfX2RvbWFpbl9tYWtl
KGxpYnhsX19nYyAqZ2MsIGxpYnhsX2RvbWFpbl9jb25maWcgKmRfY29uZmlnLA0KPj4gICAgICAg
ICAgICAgICAgICBjcmVhdGUuZmxhZ3MgfD0gWEVOX0RPTUNUTF9DREZfbmVzdGVkX3ZpcnQ7DQo+
PiAgICAgICAgICB9DQo+PiAgKyAgICAgICAgaWYgKCBsaWJ4bF9kZWZib29sX3ZhbChiX2luZm8t
PnZwbXUpICkNCj4+ICsgICAgICAgICAgICBjcmVhdGUuZmxhZ3MgfD0gWEVOX0RPTUNUTF9DREZf
dnBtdTsNCj4+ICsNCj4+ICAgICAgICAgIGFzc2VydChpbmZvLT5wYXNzdGhyb3VnaCAhPSBMSUJY
TF9QQVNTVEhST1VHSF9ERUZBVUxUKTsNCj4+ICAgICAgICAgIExPRyhERVRBSUwsICJwYXNzdGhy
b3VnaDogJXMiLA0KPj4gICAgICAgICAgICAgIGxpYnhsX3Bhc3N0aHJvdWdoX3RvX3N0cmluZyhp
bmZvLT5wYXNzdGhyb3VnaCkpOw0KPj4gQEAgLTExOTksNiArMTIwMywxMiBAQCBpbnQgbGlieGxf
X2RvbWFpbl9jb25maWdfc2V0ZGVmYXVsdChsaWJ4bF9fZ2MgKmdjLA0KPj4gICAgICAgICAgZ290
byBlcnJvcl9vdXQ7DQo+PiAgICAgIH0NCj4+ICArICAgIGlmIChsaWJ4bF9kZWZib29sX3ZhbChk
X2NvbmZpZy0+Yl9pbmZvLnZwbXUpICYmICFwaHlzaW5mby5jYXBfdnBtdSkgew0KPj4gKyAgICAg
ICAgcmV0ID0gRVJST1JfSU5WQUw7DQo+PiArICAgICAgICBMT0dEKEVSUk9SLCBkb21pZCwgInZw
bXUgbm90IHN1cHBvcnRlZCBvbiB0aGlzIHBsYXRmb3JtXG4iKTsNCj4+ICsgICAgICAgIGdvdG8g
ZXJyb3Jfb3V0Ow0KPj4gKyAgICB9DQo+PiArDQo+PiAgICAgIHJldCA9IDA7DQo+PiAgIGVycm9y
X291dDoNCj4+ICAgICAgcmV0dXJuIHJldDsNCj4+IGRpZmYgLS1naXQgYS90b29scy9saWJzL2xp
Z2h0L2xpYnhsX3R5cGVzLmlkbCBiL3Rvb2xzL2xpYnMvbGlnaHQvbGlieGxfdHlwZXMuaWRsDQo+
PiBpbmRleCA5OTNlODNhY2NhLi5iOTZmYjVjNDdlIDEwMDY0NA0KPj4gLS0tIGEvdG9vbHMvbGli
cy9saWdodC9saWJ4bF90eXBlcy5pZGwNCj4+ICsrKyBiL3Rvb2xzL2xpYnMvbGlnaHQvbGlieGxf
dHlwZXMuaWRsDQo+PiBAQCAtNjU1LDYgKzY1NSw4IEBAIGxpYnhsX2RvbWFpbl9idWlsZF9pbmZv
ID0gU3RydWN0KCJkb21haW5fYnVpbGRfaW5mbyIsWw0KPj4gICAgICAjIFVzZSB6ZXJvIHZhbHVl
IHRvIGRpc2FibGUgdGhpcyBmZWF0dXJlLg0KPj4gICAgICAoInZtdHJhY2VfYnVmX2tiIiwgaW50
ZWdlciksDQo+PiAgKyAgICAoInZwbXUiLCBsaWJ4bF9kZWZib29sKSwNCj4+ICsNCj4+ICAgICAg
XSwgZGlyPURJUl9JTiwNCj4+ICAgICAgICAgY29weV9kZXByZWNhdGVkX2ZuPSJsaWJ4bF9fZG9t
YWluX2J1aWxkX2luZm9fY29weV9kZXByZWNhdGVkIiwNCj4+ICApDQo+PiBkaWZmIC0tZ2l0IGEv
dG9vbHMvb2NhbWwvbGlicy94Yy94ZW5jdHJsLm1sIGIvdG9vbHMvb2NhbWwvbGlicy94Yy94ZW5j
dHJsLm1sDQo+PiBpbmRleCA3YTQwMzBhMTkyLi44Njc1OGJhYmIzIDEwMDY0NA0KPj4gLS0tIGEv
dG9vbHMvb2NhbWwvbGlicy94Yy94ZW5jdHJsLm1sDQo+PiArKysgYi90b29scy9vY2FtbC9saWJz
L3hjL3hlbmN0cmwubWwNCj4+IEBAIC03MCw2ICs3MCw3IEBAIHR5cGUgZG9tYWluX2NyZWF0ZV9m
bGFnID0NCj4+ICAJfCBDREZfSU9NTVUNCj4+ICAJfCBDREZfTkVTVEVEX1ZJUlQNCj4+ICAJfCBD
REZfVlBDSQ0KPj4gKwl8IENERl9WUE1VDQo+PiAgICB0eXBlIGRvbWFpbl9jcmVhdGVfaW9tbXVf
b3B0cyA9DQo+PiAgCXwgSU9NTVVfTk9fU0hBUkVQVA0KPj4gZGlmZiAtLWdpdCBhL3Rvb2xzL29j
YW1sL2xpYnMveGMveGVuY3RybC5tbGkgYi90b29scy9vY2FtbC9saWJzL3hjL3hlbmN0cmwubWxp
DQo+PiBpbmRleCA2OTAwNTEzZTdmLi4wZmRiMGNjMTY5IDEwMDY0NA0KPj4gLS0tIGEvdG9vbHMv
b2NhbWwvbGlicy94Yy94ZW5jdHJsLm1saQ0KPj4gKysrIGIvdG9vbHMvb2NhbWwvbGlicy94Yy94
ZW5jdHJsLm1saQ0KPj4gQEAgLTYzLDYgKzYzLDcgQEAgdHlwZSBkb21haW5fY3JlYXRlX2ZsYWcg
PQ0KPj4gICAgfCBDREZfSU9NTVUNCj4+ICAgIHwgQ0RGX05FU1RFRF9WSVJUDQo+PiAgICB8IENE
Rl9WUENJDQo+PiArICB8IENERl9WUE1VDQo+PiAgICB0eXBlIGRvbWFpbl9jcmVhdGVfaW9tbXVf
b3B0cyA9DQo+PiAgICB8IElPTU1VX05PX1NIQVJFUFQNCj4+IGRpZmYgLS1naXQgYS90b29scy94
bC94bF9wYXJzZS5jIGIvdG9vbHMveGwveGxfcGFyc2UuYw0KPj4gaW5kZXggMTdkZGRiNGNkNS4u
YzUwM2I5YmUwMCAxMDA2NDQNCj4+IC0tLSBhL3Rvb2xzL3hsL3hsX3BhcnNlLmMNCj4+ICsrKyBi
L3Rvb2xzL3hsL3hsX3BhcnNlLmMNCj4+IEBAIC0yNzUwLDYgKzI3NTAsOCBAQCBza2lwX3VzYmRl
djoNCj4+ICAgICAgICAgICAgICAgICAgICAgICJJZiBpdCBmaXhlcyBhbiBpc3N1ZSB5b3UgYXJl
IGhhdmluZyBwbGVhc2UgcmVwb3J0IHRvICINCj4+ICAgICAgICAgICAgICAgICAgICAgICJ4ZW4t
ZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcuXG4iKTsNCj4+ICArICAgIHhsdV9jZmdfZ2V0X2Rl
ZmJvb2woY29uZmlnLCAidnBtdSIsICZiX2luZm8tPnZwbXUsIDApOw0KPj4gKw0KPj4gICAgICB4
bHVfY2ZnX2Rlc3Ryb3koY29uZmlnKTsNCj4+ICB9DQo+PiAgZGlmZiAtLWdpdCBhL3hlbi9hcmNo
L2FybS9kb21haW4uYyBiL3hlbi9hcmNoL2FybS9kb21haW4uYw0KPj4gaW5kZXggYWFlNDQ3MjQ3
OS4uMmY5ODhjNzkwZSAxMDA2NDQNCj4+IC0tLSBhL3hlbi9hcmNoL2FybS9kb21haW4uYw0KPj4g
KysrIGIveGVuL2FyY2gvYXJtL2RvbWFpbi5jDQo+PiBAQCAtMjc2LDYgKzI3Niw4IEBAIHN0YXRp
YyB2b2lkIGN0eHRfc3dpdGNoX3RvKHN0cnVjdCB2Y3B1ICpuKQ0KPj4gICAgICAgKiB0aW1lci4g
VGhlIGludGVycnVwdCBuZWVkcyB0byBiZSBpbmplY3RlZCBpbnRvIHRoZSBndWVzdC4gKi8NCj4+
ICAgICAgV1JJVEVfU1lTUkVHKG4tPmFyY2guY250a2N0bCwgQ05US0NUTF9FTDEpOw0KPj4gICAg
ICB2aXJ0X3RpbWVyX3Jlc3RvcmUobik7DQo+PiArDQo+PiArICAgIFdSSVRFX1NZU1JFRyhuLT5h
cmNoLm1kY3JfZWwyLCBNRENSX0VMMik7DQo+PiAgfQ0KPj4gICAgLyogVXBkYXRlIHBlci1WQ1BV
IGd1ZXN0IHJ1bnN0YXRlIHNoYXJlZCBtZW1vcnkgYXJlYSAoaWYgcmVnaXN0ZXJlZCkuICovDQo+
PiBAQCAtNTg2LDYgKzU4OCwxMCBAQCBpbnQgYXJjaF92Y3B1X2NyZWF0ZShzdHJ1Y3QgdmNwdSAq
dikNCj4+ICAgICAgICB2LT5hcmNoLmhjcl9lbDIgPSBnZXRfZGVmYXVsdF9oY3JfZmxhZ3MoKTsN
Cj4+ICArICAgIHYtPmFyY2gubWRjcl9lbDIgPSBIRENSX1REUkEgfCBIRENSX1RET1NBIHwgSERD
Ul9UREE7DQo+PiArICAgIGlmICggISh2LT5kb21haW4tPm9wdGlvbnMgJiBYRU5fRE9NQ1RMX0NE
Rl92cG11KSApDQo+PiArICAgICAgICB2LT5hcmNoLm1kY3JfZWwyIHw9IEhEQ1JfVFBNIHwgSERD
Ul9UUE1DUjsNCj4+ICsNCj4+ICAgICAgaWYgKCAocmMgPSB2Y3B1X3ZnaWNfaW5pdCh2KSkgIT0g
MCApDQo+PiAgICAgICAgICBnb3RvIGZhaWw7DQo+PiAgQEAgLTYyMiw5ICs2MjgsOSBAQCBpbnQg
YXJjaF9zYW5pdGlzZV9kb21haW5fY29uZmlnKHN0cnVjdCB4ZW5fZG9tY3RsX2NyZWF0ZWRvbWFp
biAqY29uZmlnKQ0KPj4gIHsNCj4+ICAgICAgdW5zaWduZWQgaW50IG1heF92Y3B1czsNCj4+ICAt
ICAgIC8qIEhWTSBhbmQgSEFQIG11c3QgYmUgc2V0LiBJT01NVSBhbmQgVlBDSSBtYXkgb3IgbWF5
IG5vdCBiZSAqLw0KPj4gLSAgICBpZiAoIChjb25maWctPmZsYWdzICYgflhFTl9ET01DVExfQ0RG
X2lvbW11ICYgflhFTl9ET01DVExfQ0RGX3ZwY2kpICE9DQo+PiAtICAgICAgICAgKFhFTl9ET01D
VExfQ0RGX2h2bSB8IFhFTl9ET01DVExfQ0RGX2hhcCkgKQ0KPj4gKyAgICAvKiBIVk0gYW5kIEhB
UCBtdXN0IGJlIHNldC4gSU9NTVUsIFZQQ0kgYW5kIFZQTVUgbWF5IG9yIG1heSBub3QgYmUgKi8N
Cj4+ICsgICAgaWYgKCAoY29uZmlnLT5mbGFncyAmIH4oWEVOX0RPTUNUTF9DREZfaW9tbXUgfCBY
RU5fRE9NQ1RMX0NERl92cGNpIHwNCj4+ICsgICAgICAgICAgWEVOX0RPTUNUTF9DREZfdnBtdSkp
ICE9IChYRU5fRE9NQ1RMX0NERl9odm0gfCBYRU5fRE9NQ1RMX0NERl9oYXApICkNCj4gDQo+IFRo
ZSBzcGxpdCBoZXJlIGlzIG5vdCBlYXN5IHRvIHJlYWQuIENhbiB5b3UgaW50cm9kdWNlIHR3byBt
YXNrcyAob25lIGZvciB0aGUgZmxhZ3MgdGhhdCBtdXN0IGJlIHNldCBhbmQgdGhlIG90aGVyIG9w
dGlvbmFsKSBzbyB3ZSBkb24ndCBuZWVkIHRvIHNwbGl0IHRoZSBvcHRpb25hbCBvcHRpb25zIG92
ZXIgdHdvIGxpbmVzLg0KPiANCj4+ICAgICAgew0KPj4gICAgICAgICAgZHByaW50ayhYRU5MT0df
SU5GTywgIlVuc3VwcG9ydGVkIGNvbmZpZ3VyYXRpb24gJSN4XG4iLA0KPj4gICAgICAgICAgICAg
ICAgICBjb25maWctPmZsYWdzKTsNCj4+IGRpZmYgLS1naXQgYS94ZW4vYXJjaC9hcm0vc2V0dXAu
YyBiL3hlbi9hcmNoL2FybS9zZXR1cC5jDQo+PiBpbmRleCA0OWRjOTBkMTk4Li44NTM4NmE3NjVh
IDEwMDY0NA0KPj4gLS0tIGEveGVuL2FyY2gvYXJtL3NldHVwLmMNCj4+ICsrKyBiL3hlbi9hcmNo
L2FybS9zZXR1cC5jDQo+PiBAQCAtMTA4LDYgKzEwOCw3IEBAIHN0YXRpYyB2b2lkIF9faW5pdCBw
cm9jZXNzb3JfaWQodm9pZCkNCj4+ICAgICAgICBpZGVudGlmeV9jcHUoYyk7DQo+PiAgICAgIGN1
cnJlbnRfY3B1X2RhdGEgPSAqYzsNCj4+ICsgICAgdnBtdV9pc19hdmFpbGFibGUgPSBjcHVfaGFz
X3BtdTsNCj4gDQo+IFRoaXMgd2FudHMgdG8gYmUgc2V0IGFmdGVyIHRoZSBJRCByZWdpc3RlcnMg
YXJlIHNhbml0aXplZCAoaS5lLiBhZnRlciB0aGUgc2Vjb25kYXJ5IENQVXMgaGF2ZSBiZWVuIGJy
b3VnaHQpLg0KPiANCj4gQWxzbywgb24gQXJtdjgsIHRoZSBmZWF0dXJlcyBzdXBwb3J0ZWQgYnkg
NjQtYml0IGFuZCAzMi1iaXQgZXhjZXB0aW9uIGxldmVsIGFyZSBzZXBhcmF0ZS4gSSBjb3VsZG4n
dCBmaW5kIGFueXRoaW5nIGluIHRoZSBBcm0gdGhhdCBzdWdnZXN0IHRoYXQgaWYgdGhlIFBNVSBp
cyBpbXBsZW1lbnRlZCBieSB0aGUgZm9ybWVyLCB0aGVuIHRoZSBsYXR0ZXIgbXVzdCBiZS4gRG8g
eW91IGhhdmUgdGhlIHBhZ2UgaW4gaGFuZD8NCg0KQ2hhcHRlciBENy4xIGF0IHRoZSBlbmQgaXMg
c2F5aW5nIHRoaXM6DQoNCiJUaGUgUGVyZm9ybWFuY2UgTW9uaXRvcnMgRXh0ZW5zaW9uIGlzIGNv
bW1vbiB0byBBQXJjaDY0IG9wZXJhdGlvbiBhbmQgQUFyY2gzMiBvcGVyYXRpb24u4oCdDQoNCklz
IHRoaXMgdGhlIGp1c3RpZmljYXRpb24geW91IGFyZSBsb29raW5nIGZvciA/DQoNCkNoZWVycw0K
QmVydHJhbmQNCg0KPiANCj4+ICAgICAgICBpZiAoIGMtPm1pZHIuaW1wbGVtZW50ZXIgPCBBUlJB
WV9TSVpFKHByb2Nlc3Nvcl9pbXBsZW1lbnRlcnMpICYmDQo+PiAgICAgICAgICAgcHJvY2Vzc29y
X2ltcGxlbWVudGVyc1tjLT5taWRyLmltcGxlbWVudGVyXSApDQo+PiBkaWZmIC0tZ2l0IGEveGVu
L2NvbW1vbi9kb21haW4uYyBiL3hlbi9jb21tb24vZG9tYWluLmMNCj4+IGluZGV4IDI2MmI2YzBj
M2MuLjg1NDNmYjU0ZmQgMTAwNjQ0DQo+PiAtLS0gYS94ZW4vY29tbW9uL2RvbWFpbi5jDQo+PiAr
KysgYi94ZW4vY29tbW9uL2RvbWFpbi5jDQo+PiBAQCAtNDgwLDEyICs0ODAsMTQgQEAgc3RhdGlj
IGludCBzYW5pdGlzZV9kb21haW5fY29uZmlnKHN0cnVjdCB4ZW5fZG9tY3RsX2NyZWF0ZWRvbWFp
biAqY29uZmlnKQ0KPj4gICAgICBib29sIGh2bSA9IGNvbmZpZy0+ZmxhZ3MgJiBYRU5fRE9NQ1RM
X0NERl9odm07DQo+PiAgICAgIGJvb2wgaGFwID0gY29uZmlnLT5mbGFncyAmIFhFTl9ET01DVExf
Q0RGX2hhcDsNCj4+ICAgICAgYm9vbCBpb21tdSA9IGNvbmZpZy0+ZmxhZ3MgJiBYRU5fRE9NQ1RM
X0NERl9pb21tdTsNCj4+ICsgICAgYm9vbCB2cG11ID0gY29uZmlnLT5mbGFncyAmIFhFTl9ET01D
VExfQ0RGX3ZwbXU7DQo+PiAgICAgICAgaWYgKCBjb25maWctPmZsYWdzICYNCj4+ICAgICAgICAg
ICB+KFhFTl9ET01DVExfQ0RGX2h2bSB8IFhFTl9ET01DVExfQ0RGX2hhcCB8DQo+PiAgICAgICAg
ICAgICBYRU5fRE9NQ1RMX0NERl9zM19pbnRlZ3JpdHkgfCBYRU5fRE9NQ1RMX0NERl9vb3Nfb2Zm
IHwNCj4+ICAgICAgICAgICAgIFhFTl9ET01DVExfQ0RGX3hzX2RvbWFpbiB8IFhFTl9ET01DVExf
Q0RGX2lvbW11IHwNCj4+IC0gICAgICAgICAgIFhFTl9ET01DVExfQ0RGX25lc3RlZF92aXJ0IHwg
WEVOX0RPTUNUTF9DREZfdnBjaSkgKQ0KPj4gKyAgICAgICAgICAgWEVOX0RPTUNUTF9DREZfbmVz
dGVkX3ZpcnQgfCBYRU5fRE9NQ1RMX0NERl92cGNpIHwNCj4+ICsgICAgICAgICAgIFhFTl9ET01D
VExfQ0RGX3ZwbXUpICkNCj4+ICAgICAgew0KPj4gICAgICAgICAgZHByaW50ayhYRU5MT0dfSU5G
TywgIlVua25vd24gQ0RGIGZsYWdzICUjeFxuIiwgY29uZmlnLT5mbGFncyk7DQo+PiAgICAgICAg
ICByZXR1cm4gLUVJTlZBTDsNCj4+IEBAIC01MzQsNiArNTM2LDEyIEBAIHN0YXRpYyBpbnQgc2Fu
aXRpc2VfZG9tYWluX2NvbmZpZyhzdHJ1Y3QgeGVuX2RvbWN0bF9jcmVhdGVkb21haW4gKmNvbmZp
ZykNCj4+ICAgICAgICAgIHJldHVybiAtRUlOVkFMOw0KPj4gICAgICB9DQo+PiAgKyAgICBpZiAo
IHZwbXUgJiYgIXZwbXVfaXNfYXZhaWxhYmxlICkNCj4+ICsgICAgew0KPj4gKyAgICAgICAgZHBy
aW50ayhYRU5MT0dfSU5GTywgInZwbXUgcmVxdWVzdGVkIGJ1dCBjYW5ub3QgYmUgZW5hYmxlZCB0
aGlzIHdheVxuIik7DQo+PiArICAgICAgICByZXR1cm4gLUVJTlZBTDsNCj4+ICsgICAgfQ0KPj4g
Kw0KPj4gICAgICByZXR1cm4gYXJjaF9zYW5pdGlzZV9kb21haW5fY29uZmlnKGNvbmZpZyk7DQo+
PiAgfQ0KPj4gIGRpZmYgLS1naXQgYS94ZW4vaW5jbHVkZS9hc20tYXJtL2RvbWFpbi5oIGIveGVu
L2luY2x1ZGUvYXNtLWFybS9kb21haW4uaA0KPj4gaW5kZXggYzkyNzdiNWM2ZC4uMTRlNTc1Mjg4
ZiAxMDA2NDQNCj4+IC0tLSBhL3hlbi9pbmNsdWRlL2FzbS1hcm0vZG9tYWluLmgNCj4+ICsrKyBi
L3hlbi9pbmNsdWRlL2FzbS1hcm0vZG9tYWluLmgNCj4+IEBAIC0xNjYsNiArMTY2LDcgQEAgc3Ry
dWN0IGFyY2hfdmNwdQ0KPj4gICAgICAgIC8qIEhZUCBjb25maWd1cmF0aW9uICovDQo+PiAgICAg
IHJlZ2lzdGVyX3QgaGNyX2VsMjsNCj4+ICsgICAgcmVnaXN0ZXJfdCBtZGNyX2VsMjsNCj4+ICAg
ICAgICB1aW50MzJfdCB0ZWVjciwgdGVlaGJyOyAvKiBUaHVtYkVFLCAzMi1iaXQgZ3Vlc3RzIG9u
bHkgKi8NCj4+ICAjaWZkZWYgQ09ORklHX0FSTV8zMg0KPj4gZGlmZiAtLWdpdCBhL3hlbi9pbmNs
dWRlL3B1YmxpYy9kb21jdGwuaCBiL3hlbi9pbmNsdWRlL3B1YmxpYy9kb21jdGwuaA0KPj4gaW5k
ZXggNGNiM2Y2NjJjMi4uYTUzY2JkMTZmNCAxMDA2NDQNCj4+IC0tLSBhL3hlbi9pbmNsdWRlL3B1
YmxpYy9kb21jdGwuaA0KPj4gKysrIGIveGVuL2luY2x1ZGUvcHVibGljL2RvbWN0bC5oDQo+PiBA
QCAtNzEsOSArNzEsMTEgQEAgc3RydWN0IHhlbl9kb21jdGxfY3JlYXRlZG9tYWluIHsNCj4+ICAj
ZGVmaW5lIF9YRU5fRE9NQ1RMX0NERl9uZXN0ZWRfdmlydCAgIDYNCj4+ICAjZGVmaW5lIFhFTl9E
T01DVExfQ0RGX25lc3RlZF92aXJ0ICAgICgxVSA8PCBfWEVOX0RPTUNUTF9DREZfbmVzdGVkX3Zp
cnQpDQo+PiAgI2RlZmluZSBYRU5fRE9NQ1RMX0NERl92cGNpICAgICAgICAgICAoMVUgPDwgNykN
Cj4+ICsvKiBTaG91bGQgd2UgZXhwb3NlIHRoZSB2UE1VIHRvIHRoZSBndWVzdD8gKi8NCj4+ICsj
ZGVmaW5lIFhFTl9ET01DVExfQ0RGX3ZwbXUgICAgICAgICAgICgxVSA8PCA4KQ0KPj4gICAgLyog
TWF4IFhFTl9ET01DVExfQ0RGXyogY29uc3RhbnQuICBVc2VkIGZvciBBQkkgY2hlY2tpbmcuICov
DQo+PiAtI2RlZmluZSBYRU5fRE9NQ1RMX0NERl9NQVggWEVOX0RPTUNUTF9DREZfdnBjaQ0KPj4g
KyNkZWZpbmUgWEVOX0RPTUNUTF9DREZfTUFYIFhFTl9ET01DVExfQ0RGX3ZwbXUNCj4+ICAgICAg
ICB1aW50MzJfdCBmbGFnczsNCj4+ICANCj4gDQo+IENoZWVycywNCj4gDQo+IC0tIA0KPiBKdWxp
ZW4gR3JhbGwNCg0K


From xen-devel-bounces@lists.xenproject.org Mon Oct 11 14:12:37 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 14:12:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.206081.361559 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZw2f-0001Xh-JU; Mon, 11 Oct 2021 14:12:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 206081.361559; Mon, 11 Oct 2021 14:12:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZw2f-0001Xa-GQ; Mon, 11 Oct 2021 14:12:37 +0000
Received: by outflank-mailman (input) for mailman id 206081;
 Mon, 11 Oct 2021 14:12:36 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=rMo6=O7=citrix.com=anthony.perard@srs-us1.protection.inumbo.net>)
 id 1mZw2e-0001XO-6B
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 14:12:36 +0000
Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 46de8504-2a9d-11ec-80de-12813bfff9fa;
 Mon, 11 Oct 2021 14:12:35 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 46de8504-2a9d-11ec-80de-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1633961554;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=q9DDiOQc6nS711ZZkf1Afq/jYapjqNbh/eg5pS6gwtc=;
  b=gGqjt10C8Dzd8epz3/cerBxxcrIhVs6nf0YUYog81+FKZPQKquWlBKwe
   5PyCbQh/7ILLIA1tCer+mAZYGC+xspFgNdCDmSyA1yJ5qlvCjrB0xQ4/J
   T+dsHpq5WUZgrRrV/T00uz+1lKeAgWk3lys+5zizTMmSNMBVjPtvoUalf
   s=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: VgVycDkYrk7WxhHFemZzUDg/qA3DK4I+2CGrOLPR4k2k6PkLfHEmP0R3RpD0woCEN4G7xG01yr
 VQnujWJ7BXeevV+oKufdRbQ092PzxXbXSPT7qo2dDcJd72WElw8T4rRY8E/PSjTg9fiDCsCSyl
 Kd11U4UwnIMOJCyEqSCyTPf/pc29Pxrv+0lzj64hIWsOLo0jsiHOnXsIgG+SkxEZFUCukYK3N2
 KgoJmDKLku6xCJaXb/N/UdrndU+OSriWOJgbqiVYoLMz9fBCB1cZNQpAi5hOnEFNBw6m7acHlb
 pcWssJ6DoE7R8cwJWvi77gt1
X-SBRS: 5.1
X-MesageID: 55289248
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:Ukimn6xnM4ANKLtnDaJ6t+e6wSrEfRIJ4+MujC+fZmUNrF6WrkUGn
 DdOWm7TOanZZmXxLdh/YY+19EIF78Pdm9NlT1FpqiAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx
 59DAjUVBJlsFhcwnvopW1TYhSEUOZugH9IQM8aZfHAsLeNYYH1500s6w7dg2tcAbeWRWGthh
 /uj+6UzB3f9s9JEGjp8B3Wr8U4HUFza4Vv0j3RmDRx5lAa2e0o9VfrzEZqZPXrgKrS4K8bhL
 wr1IBNVyUuCl/slIovNfr8W6STmSJaKVeSFoiI+t6RPHnGuD8H9u0o2HKN0VKtZt9mGt81ay
 e9LpK2fc1kGBYriptVeXz0HIwgraMWq+JefSZS+mcmazkmAeHrw2fR+SkoxOOX0+M4uXzsIr
 6ZBbmlQMFbT3Ipaw5riIgVors0lMMnsOpJZonx6xCvVJf0nXYrCU+PB4towMDIY250UTaeEO
 5pxhTxHRgndTD1UK0guDtFkkKSZmGnkd2JRkQfAzUYwyzeKl1EguFT3C/LOYcCDT8hRmkeep
 0rF8n7/DxVcM8aQoRKa9lq8i+mJmjn0MKoCGbv9+vN0jVm7wm0IFAZQRVa9ueO+iEO1R5RYM
 UN80igkoLU29UerZsLgRBD+q3mB1jYdRNh4A+A88BuKyKff/0CeHGdsZjxcbN0rsucmSDps0
 UWG9+4FHhQ27ufTEyjEsO7J83XiYkD5MFPuewcZZgo/5cjSj7ttoSnoYOhSU6KR0e3cTGSYL
 y+xkAAygLAajMgu3qq9/Ezajz/EmqUlXjLZ9S2MATr7tlIRiJqNItXyswCCvKkowJOxFwHZ5
 BA5d96iAPfi5H1nvBeGR/kRB/mX7vKBPSy0bbVHTsR5qWrFF5JOe+ltDNBCyKVBbpZsldzBO
 ha7VeZtCHl7ZibCgUhfOdPZNijS5fK8fekJr9iNBja0XrB/dRWc4AZlblOK0mbmnSAEyP9kY
 sfKKZn1VCpEUsyLKQZaoc9Gi9fHIQhklAvuqW3TlUz7gdJymlbEIVv6DLd+Rr9gt/7VyOkk2
 91eK9GL231ivB7WOUHqHXooBQlSdxATXMmuw+QOL7LrClc2SQkJVq6KqZt8KtMNokigvrqRl
 p1LchQDkwSXaLyuAVjiV02Pn5u2Bcwh8ilhYXB1VbtqslB6CbuSAG4kX8NfVdEaGCZLl5aYl
 tEJJJeNBOphUDPC92hPZJXxttU6Jh+qmRiPL2yuZz1mJ8xsQAnA+9nFeArz9XZRUnrr5JVm+
 7DwhBnGRZcjRhh5CJqEYvyY0F7s72MWn/h/XhWUL4ALKlns6oVjNwf4kuQzf5MXMRzGyzbDj
 1SWDB4UqPPjuYgw9NWV16mIo53wS7l1H1ZAHnmd5rGzbHGI8m2myI5GceCJYTGCCz+kpPT8P
 b1YlqiuPucGkVBGt5tHP4xqla9utcHyo7J6zxh/GCmZZVqcFb49cGKN2tNCt/MRy+YB6xe2Q
 E+G5vJTJa6NZJH+CFcUKQcoMraD2PUTlmWA5Pg5Ohyntip+/b7BWkROJRiczidaKeItYo8ix
 O4gvu8Q6hC+1UV2YorX0HgM+jTeNGEEXoUmqooeUd3ihQccw11fZYDRV33t65aVZtQQakQnL
 1d4XkYZa2iwEqYaT0cOKA==
IronPort-HdrOrdr: A9a23:+GrCnqwZeaogAklgDeBcKrPwKL1zdoMgy1knxilNoEpuA6ilfq
 GV/MjzuiWetN98YhsdcLO7WZVoI0myyXcv2/h1AV7KZmCPhILPFuxfBODZrQEIdReTygbzv5
 0QFJSXpLfLfDtHZWeR2njbL+od
X-IronPort-AV: E=Sophos;i="5.85,364,1624334400"; 
   d="scan'208";a="55289248"
Date: Mon, 11 Oct 2021 15:11:59 +0100
From: Anthony PERARD <anthony.perard@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, George Dunlap
	<george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>, Julien Grall
	<julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>, Wei Liu
	<wl@xen.org>, <xen-devel@lists.xenproject.org>
Subject: Re: [XEN PATCH v7 16/51] build: generate "include/xen/compile.h"
 with if_changed
Message-ID: <YWRGL6DiSfxOl5iw@perard>
References: <20210824105038.1257926-1-anthony.perard@citrix.com>
 <20210824105038.1257926-17-anthony.perard@citrix.com>
 <e895337f-e640-f7ea-2737-036797fc939a@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <e895337f-e640-f7ea-2737-036797fc939a@suse.com>

On Thu, Oct 07, 2021 at 04:55:01PM +0200, Jan Beulich wrote:
> On 24.08.2021 12:50, Anthony PERARD wrote:
> > --- a/.gitignore
> > +++ b/.gitignore
> > @@ -332,7 +332,6 @@ xen/include/compat/*
> >  xen/include/config/
> >  xen/include/generated/
> >  xen/include/public/public
> > -xen/include/xen/*.new
> 
> While this indeed looks to only have been here for compile.h, I'm
> not convinced it is a good idea to delete the entry here. Does it
> cause any harm if left in place?

That's a complicated question. I would prefer to have in this file only
artefacts of the build system but other developer and maintainer
disagree. So it's fine I guess to leave the entry, it just hide any
*.new file from `git status` and make it harder to commit them.

> > --- a/xen/Makefile
> > +++ b/xen/Makefile
> > @@ -368,7 +368,7 @@ _clean: delete-unfresh-files
> >  		-o -name "*.gcno" -o -name ".*.cmd" -o -name "lib.a" \) -exec rm -f {} \;
> >  	rm -f include/asm $(TARGET) $(TARGET).gz $(TARGET).efi $(TARGET).efi.map $(TARGET)-syms $(TARGET)-syms.map *~ core
> >  	rm -f asm-offsets.s arch/*/include/asm/asm-offsets.h
> > -	rm -f .banner
> > +	rm -f .banner include/xen/compile.h
> 
> Isn't this redundant with ...
> 
> > @@ -425,10 +419,16 @@ include/xen/compile.h: include/xen/compile.h.in .banner
> > +
> > +include/xen/compile.h: include/xen/compile.h.in .banner FORCE
> >  	@cat .banner
> > -	@sed -rf tools/process-banner.sed < .banner >> $@.new
> > -	@mv -f $@.new $@
> > +	$(call if_changed,compile.h)
> > +targets += include/xen/compile.h
> 
> ... this? I would have hoped that $(targets) is included in the
> generic cleaning logic ...

Not yet. It's probably a good idea, I'll work on a patch.

Thanks,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Mon Oct 11 14:14:19 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 14:14:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.206091.361570 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZw4I-0002FV-Uf; Mon, 11 Oct 2021 14:14:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 206091.361570; Mon, 11 Oct 2021 14:14:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZw4I-0002FO-Rg; Mon, 11 Oct 2021 14:14:18 +0000
Received: by outflank-mailman (input) for mailman id 206091;
 Mon, 11 Oct 2021 14:14:17 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=BpBC=O7=citrix.com=Andrew.Cooper3@srs-us1.protection.inumbo.net>)
 id 1mZw4H-0002FE-Ce
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 14:14:17 +0000
Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id e1b09cbc-ec13-44f1-a06f-379951c8212b;
 Mon, 11 Oct 2021 14:14:16 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e1b09cbc-ec13-44f1-a06f-379951c8212b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1633961656;
  h=to:cc:references:from:subject:message-id:date:
   in-reply-to:content-transfer-encoding:mime-version;
  bh=p1wxXwFih3yoinGSgAomfdeN5BEfbooqJGbs01vdNCA=;
  b=gyAMq1BypzW0xJFLin5ys0zTChV6I4YMt91mRQ52N9zQeUR2Q347WU4S
   qBE/Zg1NA7ChpP4v5BRf9S0kdcd1iYeP/6ydciG1u4XFmCLactuk2h5S6
   hOY4e0GPaTO1Ihp9DW6/KkQnXJ+do9LsiA/ERk6TJFSRYFiFJURRaFrbP
   I=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: CZFDDOC9wUAecROURszuoYH7DSBd/5B599xP3OrFzWFk5sOTpKO7pqRVOEQPhOBcOgwSfMdYmG
 OYG5YM3WjNkgk8Vvo47wQKw5Op4uUKs39Pl5p6SJtZ7HDjYNxB1rqr17zLMzhFHCmlvdKRdHML
 83sao1qVSCz5XRmGlWvXed4eHdJKDDZFdX5XVKBdM1VODi+cMK1o1lrOFjwf0/MraPZdn/V8JU
 z9U/Zrz+fmDN87TPuEErVa9C0to/YFdF5+EbOws/sLvJZsFculi/BMpWHWY7HAHCCzXLpHlRUn
 CgrmC99yxbqfghFY2m0osq6n
X-SBRS: 5.1
X-MesageID: 56755400
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:uT+IvawmEAurpPQd9ph6t+efwSrEfRIJ4+MujC+fZmUNrF6WrkUGy
 msbUWzTOazfamX0eYh0Od62ox4AuZbWnN81TgRprSAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx
 59DAjUVBJlsFhcwnvopW1TYhSEUOZugH9IQM8aZfHAsLeNYYH1500s6w7dg2tcAbeWRWGthh
 /uj+6UzB3f9s9JEGjp8B3Wr8U4HUFza4Vv0j3RmDRx5lAa2e0o9VfrzEZqZPXrgKrS4K8bhL
 wr1IBNVyUuCl/slIovNfr8W6STmSJaKVeSFoiI+t6RPHnGuD8H9u0o2HKN0VKtZt9mGt91zk
 uRir53ucDhzGpTngccEfCd9VC4raMWq+JefSZS+mcmazkmAeHrw2fR+SkoxOOX0+M4uXzsIr
 6ZBbmlQMFbT3Ipaw5riIgVoru0lINPmI8U0vXZ4wCuCJf0nXYrCU+PB4towMDIY254RQKuCP
 5JxhTxHYRuHUixyYkgsBZMck7e5u3n4SyJzpwfAzUYwyzeKl1EguFT3C/LXZ9iLSMN9jkue4
 GXc8AzRABsXKdiewjqt6W+3i6nEmiaTcIMNFpWo+/hymlqRy2cPThoMWjOTuuKlg0SzX9ZeL
 U08+Sc0q6U2skuxQbHVTxC+5XKJoBMYc95RCPEhrhGAzLLO5ASUDXRCSSROAPQ6tcoeVTEsk
 FiTkLvBGjhHoLCTD3WH+d+pQSiaYHZPazVYPGldEFVDs4KLTJwPYgznQ9Q5IYGvj4PMJmvU+
 huTjzERuZBUgptev0mkxmzvjzWpr5nPawc64ATLQ26ohj9EiJ6Zi5+AsgeDs64RRGqNZhzY5
 iJcwpnBhAwbJcjVzHTlfQkbIF2+Cx9p2hXnillzA4JpyT2p/3OyFWy7yGAjfBk3WirolDmAX
 aMyhe+zzMMDVJdJRfUuC25UNyjM5fK9fTgCfqqFBueimrArKGe6ENhGPCZ8JVzFnkk2ir0YM
 pyGa8uqBntyIf05l2HmFr9CiOZ3mHtWKYbvqXbTlE7PPV22Pi/9dFv4GAHWMrBRAF2s8W05D
 Oqzx+PVkk4CAYUSkwHc8JIJLEBiEJTILcueliCjTcbaelAOMDh4U5f5mOp9E6Q4z/U9vrqZp
 RmVBx4HoGcTcFWacG1mnFg4M+ixNXu+xFpmVRER0aGAgiB5P9n0tvtDLvPav9APrYRe8BK9d
 NFcE+2oCfVTUDXXvTMbaJj2tot5cxq3wwmJOkKYjPIXJMcIq9Xh9oC2cw3x2jMJCybr58Iyr
 6f5jlHQQIYZRhQkB8HTMar9w1S0tHkbueRzQ0qXfYUDJBSyqNBne37rk/s6A8AQMhGflDGU4
 BmbXEUDru7Xro5rrNSQ3fKYr52kGvdVF1ZBGzWJ9q6/MCTXpzLxwYJJXOuSUyraUWf4pPera
 elPlqmuO/wbhlda9YF7Fu8zn6454tLuoZ5czxhlQyqXPwj6VOs4LyDfj8dVt6BLyrtIgieMW
 xqCqotAJLGEGML5C1pNdgArWfuOiKMPkT7I4PVrfEijvH1r/KCKWFl5NgWXjHAPN6N8NY4oz
 LtzuMMS7ADj2BMmPszf03JR/mWIaHcBT78mptcRB4qy0lgnzVRLYJr9DC7q4c7QN4UQYxdye
 jLE1rDfg7l8x1bZdythHHfA6uNRmJAStU0Y11QFPVmIxoLIi/JfMMe9KtjrotC5Fil67t8=
IronPort-HdrOrdr: A9a23:0ewzaanzN8hz/BwMtMx2zItjdNDpDfOiimdD5ihNYBxZY6Wkfp
 +V88jzhCWZtN9OYhwdcLC7WZVpQRvnhPtICPoqTMiftW7dyReVxeBZnPbfKljbdREWmdQtrZ
 uIH5IOb+EYSGIK9/oSgzPIY+rIouP3iZxA7N22pxwGLXAIGtJdBkVCe2Km+yVNNXh77PECZf
 yhD6R81lidkDgsH7+G7i5vZZm8mzSHruOoXfZAbCRXnzWmvHeN0vrXAhKY1hARX3dmxqojy3
 HMl0jc6r+4u/+25xfA3yuLhq4m2efJ+59mPoihm8IVIjLjhkKBY5lgYaSLuHQQrPu04Fgnvd
 HQq1MLPth16VnWYmapyCGdlTXI4XIL0TvP2FWYiXzsrYjQQy87MdNIgcZjfh7Q+yMbzZtB+Z
 MO+1jcm4tcDBvGkii4zcPPTQtWmk29pmdnufIPjlREOLFuKoN5nMg6xgd4AZ0AFCX15MQMC+
 91FvzR4/5QbBezc23ZhG9y29ahN05DXStuenJy/vB97gIm20yQlyAjtYoidzY7hdIAoqB/lq
 H52v8CrsAWcicUBZgNT9vpD/HHUlAk7Hr3QRSvyG/cZdQ60kT22tbKCYUOlZOXkaMzve8Pcb
 T6IR5lXD0JCg7T4fPn5uwDzvmKehTnYQjQ
X-IronPort-AV: E=Sophos;i="5.85,364,1624334400"; 
   d="scan'208";a="56755400"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=DnMjnj9slz6rfKsWNxUUPmE/5wB6x032ohGdXxceWVYxjzyRvMsBtcmoHDcisbc6ymrDl2uBalGDzcBRd/W0WIGg3UlltoHq+VgaCZ88paKdv5EzOS4HfvPX1WORgZ7toHrVOWwMcDzoAI6YDi9lh7S6WIzsni3HZueTJyO5TZx3waGFNwV+LmtfDyQOBIwiFY+Hk/65H/uzKNMecmtRvQeUHOtaVrK2L8oNTjnWxe05Q+1+cBTudTzpat8SdETC6q+VEqQJtib8lGv0jHuNp1UeETwvCA6zflJEAXvV35Iv6vLsfbwAJgYJSoq+Af+ImxfMK2njilPEbuHJnhLubA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=HUss51mAJhkh+vckdc2Bb1hlsinXJjqsUqnVrbtypkg=;
 b=gjMqTLUZBI0dt1rRt1CSFRIpZeL68dJr8ZI1TMJMkRT9SIN/rcF6InkGfMTwnhQNXnHn8++Qk3hkfWtMtgdzEgfmLXt4eDw3TA29Y7B2XBe9nxo1ShX+qc2HY3uVofNl+z5vSn6B8bwKyREaw828zM30yhew0thKZyt44unwcBYQTaCWBf1mTq50pzbh/MCGNMirrCDIVcZyQhbklwVTiEZvBJN4qgTrS1rSAZ4ucahI+N94Ujo7UX2+kVeM1Y1PE4qkLV3H6n7OI/3Y4idH5X4ObizYb4gpmaisAybpUL4Rg7joMZFkclcnNWGYMQTPLEyoLFuzMboEj/G5UCLxAg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=HUss51mAJhkh+vckdc2Bb1hlsinXJjqsUqnVrbtypkg=;
 b=SW7lU19jzpI39eM0XGPurfa6o6aNRy+05sBNBpGt2PjCGx3stko91HXLX7eIpEYLU/iBTvlpNoj/ChWkNR81pXkJRprxIGMgGSynFIgNe5CHX9tWnNGRmN0VP3Ham4qGUP1KUqiAPXPFYw7QKwmplKDjp643E9nQE1JNJ6x1Br4=
To: Ian Jackson <iwj@xenproject.org>, Anthony PERARD
	<anthony.perard@citrix.com>
CC: Jan Beulich <jbeulich@suse.com>, George Dunlap <george.dunlap@citrix.com>,
	Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wl@xen.org>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
	<roger.pau@citrix.com>, Tim Deegan <tim@xen.org>,
	<xen-devel@lists.xenproject.org>
References: <20210824105038.1257926-1-anthony.perard@citrix.com>
 <20210824105038.1257926-6-anthony.perard@citrix.com>
 <e633af0e-a34c-3c11-49ba-1e2c6f544613@suse.com> <YTibMaayiWlJwcZ/@perard>
 <24888.41483.762554.171248@mariner.uk.xensource.com>
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [XEN PATCH v7 05/51] x86/mm: avoid building multiple .o from a
 single .c file
Message-ID: <15ee51ba-c63e-461a-b771-6893444f5a84@citrix.com>
Date: Mon, 11 Oct 2021 15:13:41 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <24888.41483.762554.171248@mariner.uk.xensource.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Content-Language: en-GB
X-ClientProxiedBy: LO2P265CA0331.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:a4::31) To BYAPR03MB3623.namprd03.prod.outlook.com
 (2603:10b6:a02:aa::12)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 90b76ab1-991f-4485-9448-08d98cc15856
X-MS-TrafficTypeDiagnostic: BY5PR03MB5048:
X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <BY5PR03MB5048A05D4990068F6AB9D44EBAB59@BY5PR03MB5048.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 63lk6GWbDVCqUqY9rpVld3bz7ug4vhd1eFTmNH5IhDv9AGqu6RK134w1YybWxZTWhkAB6HFnd48YlYi8kIji6cUdKkyfjdchsY2jvg2HX2mWXU9hmw3/nHiFrzDt/vPNR1EIcE97ipVwWk04weLEI2NKYTHEKe5lJlmVCWjctGfpryz8BB3mh0pYNUJznAZBIM+OQWs5UbBvV5lphO9zqdIZQmMtO6Xe7QQrriNX7qDM2vEb83QO75khHmjZmr7i2yLgMwRSveJdI7b5vnGF6Ee+qwZUO/XPcUhDdf5Y2Hl9LbQmGH5fU8wRgIstWVKYb7NsateWerT4Hez4BWRsymlRTTivbUiVTDbHZEDW5WM2fWpRj8C3Tbv6LnQg4vO5jHOWoYlnXKlQMNEhUF0+tF4K6BsyOsYe+TuvpDEUbDZW2N0+L1YfoImTBHrBdggilfkZqjfe//hyNwPAITJdaV/l8ky6RplEfYPZsVz+qXpWIm6OTKksipnlNUpw7Srd1LVSDpJDCu8+gCpjim6kKHh3cVygJYwgBCMVwxyalC8fPIyU1ODsBj0XndEjpOi5L7M8yfpQACIWmfeBa66e6UPK09lqxeJZCDNE0WJUhaiHv/+NbFacGSbzoeUCjJ6XLwedUBhum8vExyrSIzHPkboxOtiC7O2V9gS7omt24C3bKJTYxHQC5TLX4LV975uJ4e6/DGYTV3AuEG/4sPmBCHc2WhD0NMx2mWhUSKP1vIm9L1rtTHBELj9I6I/vHtCLeNj4ExVoWf1pXFYaf3FYhg==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(16576012)(55236004)(86362001)(5660300002)(66556008)(66476007)(53546011)(6636002)(4326008)(110136005)(956004)(36756003)(2616005)(2906002)(8676002)(54906003)(31696002)(6486002)(83380400001)(8936002)(508600001)(316002)(66946007)(6666004)(31686004)(26005)(186003)(38100700002)(142923001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?a1J0bTExa2Q5Q2kxcWdYQkN1aFQ4SitkMTFJYk5WOGJmeTBsTFMvaHZ0cWU0?=
 =?utf-8?B?cFB3RlhDVkhMbmF1cFFkaHl4cXlzL0JKQ1NwVXhTZmVPMnBMRkFGY21CN0Y3?=
 =?utf-8?B?RFdXdU5Db0lVZXdDVVlCRmMwRUFmbWxVT1JBZlAxZHNIWmZMcjQ5K3ZYTktU?=
 =?utf-8?B?U0hTU2xad0I5TGtaWGtwWDZObm1KWFd3c1ZFL3pXem10VFB6MnJ5a0c4dVQw?=
 =?utf-8?B?NzVXMjd0N2prY3RVWGVGUWdxcU5NSXhwLzg2ZGRzLzA2S0JQU1crMUhLZ1dX?=
 =?utf-8?B?QS9NSUpCMjI1WkFFMGpSOENrcVArR2NrY002dmY2UkxlYUFUNlJNejJrVTR6?=
 =?utf-8?B?RXpSVzIvZVlwK0ZzbEZIbktYMS9QNTMvR1VOTFh0Q2RpS3A2bXd3ZmJDeW1l?=
 =?utf-8?B?WXhvbU40Tjl0WXFUYVR6VkVSbGc3aUdsRnZwR0MxVld0ZlpjTkQwNTVFQTBQ?=
 =?utf-8?B?Z09BZEgzcndkTnpsZUprSjRwdGkvWWVtcks4VHljemFtTlMyeTlBTDgyclZP?=
 =?utf-8?B?Zm41TlBlT2dORTB6N3BkZU9YajBWSkUxaGMyUUpHVGc1T1NWTnRNTUZiYVZy?=
 =?utf-8?B?cEtVSThXd0ZGbFcrS3ZnSmJnZGtLY3d1OW1oUzFhbHozd1J5VU9MVFB2eXlL?=
 =?utf-8?B?V2Z3ZEhTWjNTQ0pQbTBocVVDMXE4YVhLWmxzcmtUcHFPK0E5S3IzVVMxS0V0?=
 =?utf-8?B?TGcrMDVDQkw2N1R4SGpkZ05vOGFrcTgwZWlhWnpmVkJGUzB2OUtrSkpkMWhG?=
 =?utf-8?B?elVxQURyMDk1MldxODNiUjR0eVcvR2NHVTY0Q0t3NkJBcUxSRklmZUZzSXZl?=
 =?utf-8?B?dzFHbkNoQXJSWHNabUNRUTBrNXhQblB2UVJiYWJxUDUreEZGZm5TMGZqK245?=
 =?utf-8?B?NC8zTWk2bVptUUZ2TmFZVGswT0ZpOXA4MjFjV3QyTWRjUkE4MG9MRkkwSXBi?=
 =?utf-8?B?VmZ6WGJVeHhiUldWYnZMb3hLUUd0S0VCd1RBN2VIU25wUnh4TlRETWw4cGRp?=
 =?utf-8?B?bWp6RnRJWlA1RVA0SUhuOVJXTUZaQTBZbFpvNVplTndzYjUwSUo5dE9RT2Nz?=
 =?utf-8?B?TXZpZkZ4elc3cU9kR1l1SE1ieE5jZjdOL0tqTUFvZHJpYlN3Zm4yR0RKNlhB?=
 =?utf-8?B?NHdaTVVBY2l3R0tCNWpsWC8xcDY5NUFSOHNKZEJhdllyOVMvOHY1NUUwUFVx?=
 =?utf-8?B?WEYxRHFvVnE2RHZZUU9SU0J1MWxacFdCcTZsZm5TQjVWMmxuYTRZeldZSlk5?=
 =?utf-8?B?TCsvdWpycnN6STBtT2xDQ2dsOEF3dE1iL0k0aml3eGpyamN1SWpFTGNRVkUw?=
 =?utf-8?B?SUJYV2p2OWp6ZlhQZ1A0bjJQbUdqdTltUmNWbWdTbmsycUhyazQzUDU3Q1RP?=
 =?utf-8?B?S0pYZ28vYXBZbFdOTzJaNU1VZHVtSHgxVU41STc1YytCREZXV3V6akJrTUt1?=
 =?utf-8?B?Wkk5OVA5eWQvdmY1dmVTRStJUGFiSWprSnVsVnB5c003cTVaVE0yUEhDYzUr?=
 =?utf-8?B?UWNVblBBMVRVNTl3VTRTRFNuRWN1dWtWalpzVXE2bU0xNit0UXl5MmQ0dnh3?=
 =?utf-8?B?QTJoaGEzcnNFMldBYlB0YkVDMlVkTk5EeGlCMDE3eGYzN1hSVXV6ejdWcngx?=
 =?utf-8?B?ZWVKVEJNVVdYRG5VMTBmdmZqa2hIV2NNVDNNTndudTFxMjZQQ09NSm4rMVNP?=
 =?utf-8?B?enFuc1YvWHo3M1VLcUJqVFoyTDZhREtIeDlQblBLVmN5OFV0dkpzOXdYYmRF?=
 =?utf-8?Q?CLFZeaT0WRfOWwWn/iajVBTLT7WwjbcrLEPSGVi?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 90b76ab1-991f-4485-9448-08d98cc15856
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2021 14:13:49.1140
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: c5i5RxnbyJqBKhoGBhlwYw6mXaP8S81iyMbIkYL/9HcJBjuM7COuiXVxmV/3Hqn2e9ze5tapznIA9vH/UNNcD+6RxYW/yFbfXoBqGnZxN+4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR03MB5048
X-OriginatorOrg: citrix.com

On 08/09/2021 12:44, Ian Jackson wrote:
> Anthony PERARD writes ("Re: [XEN PATCH v7 05/51] x86/mm: avoid building m=
ultiple .o from a single .c file"):
>> On Tue, Sep 07, 2021 at 08:14:14AM +0200, Jan Beulich wrote:
>>> Hmm, when replying to 00/51 I didn't recall I gave an R-b for this one
>>> already. I'd like to restrict it some: It should be taken to stand for
>>> the technical correctness of the change. Nevertheless I'm not really
>>> happy with the introduction of the various tiny source files. I've
>>> meanwhile been wondering: Can't these be generated (in the build tree,
>>> as soon as that's possible to be separate) rather than getting put in
>>> the repo?
>> Do we really need to generated those never to be change tiny source
>> file? Do we really need to make the build system a lot more complicated?
> I'm not an x86 maintainer, but my 2p anyway:
>
> I think the handful of tiny source files is probably better than some
> contraption in the build system.  Much less risk of something funny
> and confusing going on.

I agree.=C2=A0 This patch is definitely an improvement on the status quo.

> We could reduce the number of copies of the same text by making the
> copies of guest_walk*.c in hap/ be symlinks to ../guest_walk*.c.

The two guest_walk's are totally different logic.=C2=A0 Adding a symlink
would be reintroducing "something funny and confusing".

>
>> Can't we commit this patch as is? What kind of issue is there with those
>> tiny source files? Should we add a warning in those tiny source files,
>> something like "No modification of this file allowed, it's part of the
>> build system." ?
> I don't think we need any such warning.  No-one is going to take that
> tiny file and try to edit it to put functionality in it, and if they
> do it will be spotted on review.

Agreed.

FTR, this patch is Reviewed-by: Andrew Cooper
<andrew.cooper3@citrix.com> and fit to be committed.



From xen-devel-bounces@lists.xenproject.org Mon Oct 11 14:16:23 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 14:16:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.206099.361582 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZw6I-0002tX-BQ; Mon, 11 Oct 2021 14:16:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 206099.361582; Mon, 11 Oct 2021 14:16:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZw6I-0002tQ-8L; Mon, 11 Oct 2021 14:16:22 +0000
Received: by outflank-mailman (input) for mailman id 206099;
 Mon, 11 Oct 2021 14:16:20 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=LRsb=O7=epam.com=prvs=0918241709=oleksandr_andrushchenko@srs-us1.protection.inumbo.net>)
 id 1mZw6G-0002tG-3w
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 14:16:20 +0000
Received: from mx0a-0039f301.pphosted.com (unknown [148.163.133.242])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id cd2efd46-2a9d-11ec-80e0-12813bfff9fa;
 Mon, 11 Oct 2021 14:16:18 +0000 (UTC)
Received: from pps.filterd (m0174677.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 19BAeEuf026636; 
 Mon, 11 Oct 2021 14:16:13 GMT
Received: from eur02-ve1-obe.outbound.protection.outlook.com
 (mail-ve1eur02lp2051.outbound.protection.outlook.com [104.47.6.51])
 by mx0a-0039f301.pphosted.com with ESMTP id 3bmkqj0wsg-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Mon, 11 Oct 2021 14:16:13 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by AM0PR03MB4148.eurprd03.prod.outlook.com (2603:10a6:208:c7::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.20; Mon, 11 Oct
 2021 14:16:10 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::b034:334a:abf5:223c]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::b034:334a:abf5:223c%7]) with mapi id 15.20.4587.026; Mon, 11 Oct 2021
 14:16:09 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: cd2efd46-2a9d-11ec-80e0-12813bfff9fa
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Vp9WgR9DmIC3ztMXIYJxbxsu3fTDPvJ0DI/eR2kYyDdL0nf8eY4z5/TN6DHBsvHeo/QTjbGQI5t78Y2on/8AF5kgGP6IcBXnIys1JsX6pWDtkhwGcwLHVmvNlqAGWC6TJhv5hkdnfp/BfZ2hSEFi0Qtd1lAd57mC/5uaQl7nr+KkPVlNWHRh+KzAJ4F6EMDGOxeVPEQDxtrl+D7RPZRZjwg3eApjDDnt5iJaXYOsuS9CsdxpHZox+7ZqoQ7xkRU+pVluIMknXNk5xUHiHIEF/Lk2dZmbsF9Tfq3jLsmgAc9ttybDTVxUud0/Hv5GTVSgse1jVnl4YcRgFqdaMVBing==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=IKAn6gmZryd0mu3ilOZoDA7iyashoEnQR+UZMgAdg0k=;
 b=G/Kn883SJTgs4ejKV8jh1iMun1dcuiuhoFQ4edE3yVoklSQdQ7CyLS+BjLPZ13DdMALBzPBv/I/T1bk2UNjd8idl8+kXQVdJmSQ0B/wrH4x/iabQ48NeUJOdSQKvZTtWkUtlSfOeRGqEMa/oIxQbm6rHToedroW2iIq4jVDWPRYMMOKcliTFurV5QaqawIEamlQIeBC4QW/uHXYIllO6Ia8D9DnZ+YVU5H+51siGSqHf1+7wl1s9qrZbpNqFkixA4ngeH9bYOFa+9e36RHC7DW8rjqs2e0a9hhOkrfGtOytS6kixvPgL5YxTbvBwD6i+xuKa6pEfYAukLQ9t61thSA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=IKAn6gmZryd0mu3ilOZoDA7iyashoEnQR+UZMgAdg0k=;
 b=uBm2L6JR3QhbjJQmZ9zl0Rnm1RHopuJoYRLUokDNfrttJaJSbv9yunHDNnjnpJIa9c+y1/M+tdKmhP2UmmrZGRN40oikJDxmcO26BmoT3dtyN2lCPBRcHwnt2qKnO5KIoxOkTNUZ/BzsDPZiiRtc7uslVdQXKZoNM60W2RiRkcYd6kme2I/lhyUdoxe3jLhydcQFObnUY160gLgPOc2aanpaCr/VvcrjceTRVvmuToOTJUg9raoKD5YiXYbmAaMz/VWE2pC98oLZs72/TQNlIbJxUj/mzKkG4CI71D+b9+cpR1smYoIbOiT+v/HXsJwlYQsJ6yGBvz2Wr22d+BfAUQ==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Bertrand Marquis <bertrand.marquis@arm.com>,
        =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>
CC: Rahul Singh <rahul.singh@arm.com>,
        "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>,
        Andre Przywara <Andre.Przywara@arm.com>,
        Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>,
        Juergen Gross
	<jgross@suse.com>,
        Stefano Stabellini <sstabellini@kernel.org>
Subject: Re: [PATCH v5 01/11] xen/arm: xc_domain_ioport_permission(..) not
 supported on ARM.
Thread-Topic: [PATCH v5 01/11] xen/arm: xc_domain_ioport_permission(..) not
 supported on ARM.
Thread-Index: AQHXutl5d8zkP9bsD0GXT4+5QPGclKvNtfkAgAAGc4CAABOEAIAABXoAgAAJ9YA=
Date: Mon, 11 Oct 2021 14:16:09 +0000
Message-ID: <49a3a42d-78b5-3a01-c0d3-ab30f6d625c6@epam.com>
References: <cover.1633540842.git.rahul.singh@arm.com>
 <d292392268df2c74c4103a82ef917072643407a8.1633540842.git.rahul.singh@arm.com>
 <YWQkblfNMYEs6jI9@MacBook-Air-de-Roger.local>
 <77CF7FA5-C566-469E-B4A8-0400789890BB@arm.com>
 <YWQ6Nk3Jk+BqgkwZ@MacBook-Air-de-Roger.local>
 <53AE6E2A-01D7-41EC-9B2C-C0D596EB8D4D@arm.com>
In-Reply-To: <53AE6E2A-01D7-41EC-9B2C-C0D596EB8D4D@arm.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
authentication-results: arm.com; dkim=none (message not signed)
 header.d=none;arm.com; dmarc=none action=none header.from=epam.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 2ffb6b9c-e510-459b-fa38-08d98cc1ac70
x-ms-traffictypediagnostic: AM0PR03MB4148:
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <AM0PR03MB4148027676B9557F113F647CE7B59@AM0PR03MB4148.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 SIosRc+jBNjBjbH3QX/LUE6Pe99ItjQG9VscgrK+1JEPXthMHa8wXWM++bc/sjzZXkByJEfhSQLYaYIxUXEzeESw2y5G4wxuoajnnwAHl9BOm2VzkygIE6rN5kcYL37isMWeeEBhoGQnmM/Nm8BMiSNCe6oGg8mqvHMTPL6bfColS4IxjUavqggocYF93slVfn0S5q3aCuCViEYS2g/a4ICZaPxS2NX0XWBWwHtlZCatnHo/REkcEjxMsdnrTl/3F3rINT8gZvvJj0MR1Al8oQOMc3cFhwDtnZaOKE4r3fkPFCco+iuNNnLorT2GbrmHnD7H9BbY4CpmGOxvMJgVeIkosClTM8/j8tQhOAvsGcYKSkswrn5hFWkC34GnejF/qxZvcstllol3J2UpAdoDMRYYLz8yojf5WV8QczLC3M5bFeG6NT0iyrRaj8febsebWY9WZxF3vk8Tbf4YWC2kU4t2nYtUG08anaPET0FJ+cL7+uzX2KUXedhT5Q1grlL/061MHt1pJ6Fm51rV/4q6xH6zQ5n4T1pbjCh3lXa5vz0K+Y2xkN8xcUnmd548T+MJKi2pFNQUrxqTA6L+cSQFi6ilSFeKRZBQdSb0lKk8qNpwwKk/GibMm1g4CHmMZJ0y96PoEn9T72DRm1Th35ZLq9NrxN+NT3DtHc+mbtRfIj5qGRWk7u9qrrkFOFdKk2JiIsOfawRuo5IzW2j325ye2DduhF4BPevGD40dnJBirWZ1yH0vrZ5WLMEZ+cVqkzMl
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(84040400005)(2616005)(8936002)(66446008)(66556008)(64756008)(6486002)(26005)(66476007)(83380400001)(6512007)(91956017)(76116006)(186003)(71200400001)(55236004)(66946007)(53546011)(6506007)(36756003)(31696002)(8676002)(38100700002)(31686004)(122000001)(54906003)(110136005)(316002)(38070700005)(4326008)(2906002)(5660300002)(508600001)(86362001)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?L2VYcSt6c0xBTGJBbVN0UTI1YnpRK3VWNGhZVjdaU2hYWDk0clBNZEZabVYx?=
 =?utf-8?B?U1FseE5rdnZjcW9Gc0xuYnlnajBwZjNDSmd4OG1MczRicmRYbElnbGloYThm?=
 =?utf-8?B?S044OEh3N0hyL0pQNWFuRnR0S1N4ZmdwaDFhSjBzMFlTRmt2UVJEY0p4b25C?=
 =?utf-8?B?Yk13TU9MVlhKU3liYUNyTUEwYTNhV0tKSm9jQ0JSUm5SaHdTMHJLVzc4OW1L?=
 =?utf-8?B?aUJJWEdldUZwRlJIZjZ4Qm5la2JRTkZpYXFhZk5nVlphc2hrWmZGT0IyM1Zm?=
 =?utf-8?B?bTlzcnpiaEM1cHA3ekpsdXNTQ1BJOWZ5T0pjay9WdjZCR0dQQ2NnUERIeDRT?=
 =?utf-8?B?aiswMDBCR2pPaS9sSmRCaFBNTVN1UEZ5ZHAzSHUvNjkxcU9yNG15ejdSTkpr?=
 =?utf-8?B?V295VTV3Mm11cER1ZUI3RC9qZEVMOTNYNHRPRENPK1haR2szWnk2UmhFeXND?=
 =?utf-8?B?UEV3MVd0Mk15OVdLQVlhdGpBdnF4VWZhVzlQVWRqQWpMN3VKVU12aDBtQkJN?=
 =?utf-8?B?aGxHeXh1R2YxQlVGdldMUDJpemp4YWNBcjY0M0M3MXBmRmpyKzRuVjdzdFRP?=
 =?utf-8?B?SWhZcWdKZUxDM1JrUytGMnBldjNhY3pYVVdMc2s1WFZCV1VzTGszNWcxakM4?=
 =?utf-8?B?WlBPMUNVazdaTkM4dDBqUWttSE1vekxCeGxCbWVRMGhMQlhoeGZ6eFp3RFo0?=
 =?utf-8?B?NnBQcGpqL1BVR0NBa0FtdFY3Wmo0NmtvU2RuRmJ0ZlZaanBkMWpLdHFBbkFE?=
 =?utf-8?B?cUVlWEpoQlZ6T3dxMnB2cllRWXFiajhhK1lDZzRSUWZHUFdCNVFFY3FuV1M4?=
 =?utf-8?B?WStxQzdvc1ZyL0g5c1g3TENxUmc2L1AyQWtoZmgwNTR6U3g3S1dLTDBubk83?=
 =?utf-8?B?bm4zdDMwRkRTV2txMWhQVEF0WlJRMGlUbEVTbFcwOTJWN2UzODZ0NnlhTkV5?=
 =?utf-8?B?SWROOGRKWUlxNVlBUHBWMTRPUmpVRUtreVU2MjFMY2RSVG9ieXhySC9jSlh5?=
 =?utf-8?B?ZWJqVW5oVjR6R0hHUHR5c1E0aWthZURGMlpiY0tXSVZxY3VBdmZ0bEViVWpI?=
 =?utf-8?B?cmFFSGl6a2NQRUJzcElvVUF0a21vdUpCVi9NY1NoZnZMMkM2TzY3Q1VnRjNw?=
 =?utf-8?B?RHFiNkZ3RjFFSm91ZDlvTUpaSG91NVVUQ0RxVzZmbWk2TWdTYi90ckJlbGZH?=
 =?utf-8?B?OXhYMzFZNU9JejBPZ0wrb2tjaU10MnVneDZBWi9IOXUyekNLWkRCNDNOWTMy?=
 =?utf-8?B?bHREMFVPV0dpbVBkM0FnbVUyeGVQb3pCam9TaWZjOSt0d2xhdzVtWjMvaElE?=
 =?utf-8?B?N0JHNlp6bnRjcFpSOXc5NytFMWxHbTA5aHQyelhIQXcwK2RXY01WNis5NkFk?=
 =?utf-8?B?cUZIYWk2ZUpycTJQTTJzQjdjcmdXTGp6UHQvZHhFVTBYbW80N1ZxdUdsSHZk?=
 =?utf-8?B?ci9WWGQwcUlZdWlYeXh5ZFZ4ZFprWEVrUXRUVEVpOWQxbUcyMUJldEp6S0tt?=
 =?utf-8?B?ZC8wbTAwSUxSamhkQXJ1NFhkVzVrcDBGN2FqN1JNR0xTeGpoQTIxZFIyeVpm?=
 =?utf-8?B?Q2VRZ1VQaTdRUTdtbWJJNjcrSGJZK0pXMzJ0OXRoT3VRQ0YvbEJhNEFRdzIv?=
 =?utf-8?B?UlB6eEJKZ3lKWUY5NjlpVFNvZXU2S1grWXlQRDFTV2YzSjhpQ25oT0NzeEh3?=
 =?utf-8?B?T2pUeFp0S25DeTFqREZBVFhUMGRmSTVSTmVUdU9WS2NOTVJueXoxWmNaSmpW?=
 =?utf-8?B?RHFsdmVZc1RnSlhZQTdVUHlwVlg2N3JtdUQrMVZNRmRvbE5ueHM4YkNxYndw?=
 =?utf-8?B?K3dISlYvb2NKS3JIdkpyQT09?=
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="utf-8"
Content-ID: <B1F3F65B085BC0438B3882F0EDCD4C6E@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2ffb6b9c-e510-459b-fa38-08d98cc1ac70
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Oct 2021 14:16:09.8123
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: xCplJC39LLPVz+q28f7FVXP7zzTFFybDU7nWE/x6bzEz977f7Z+TLPPRoHy7NBfFNIpkzBrkeVHjNeV4hSo802Q7F5E6yL1k3r0nVkQrEPaxzyGIAYqMUph+F1jg5Het
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR03MB4148
X-Proofpoint-ORIG-GUID: Wv7ZFCpZYl1QYZXMutm3pqcAgw837sCi
X-Proofpoint-GUID: Wv7ZFCpZYl1QYZXMutm3pqcAgw837sCi
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.391,FMLib:17.0.607.475
 definitions=2021-10-11_05,2021-10-07_02,2020-04-07_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1011 suspectscore=0
 lowpriorityscore=0 malwarescore=0 priorityscore=1501 impostorscore=0
 mlxlogscore=951 bulkscore=0 phishscore=0 mlxscore=0 spamscore=0
 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2109230001 definitions=main-2110110084

SGksIGFsbA0KDQpPbiAxMS4xMC4yMSAxNjo0MCwgQmVydHJhbmQgTWFycXVpcyB3cm90ZToNCj4g
SGkgUm9nZXIsDQo+DQo+ICsgT2xla3NhbmRyIHRvIGhhdmUgYSBiZXR0ZXIgUENJIGV4cGVydCB0
aGVuIG1lLg0KPg0KPj4gT24gMTEgT2N0IDIwMjEsIGF0IDE0OjIwLCBSb2dlciBQYXUgTW9ubsOp
IDxyb2dlci5wYXVAY2l0cml4LmNvbT4gd3JvdGU6DQo+Pg0KPj4gT24gTW9uLCBPY3QgMTEsIDIw
MjEgYXQgMTI6MTE6MDRQTSArMDAwMCwgQmVydHJhbmQgTWFycXVpcyB3cm90ZToNCj4+PiBIaSBS
b2dlciwNCj4+Pg0KPj4+PiBPbiAxMSBPY3QgMjAyMSwgYXQgMTI6NDcsIFJvZ2VyIFBhdSBNb25u
w6kgPHJvZ2VyLnBhdUBjaXRyaXguY29tPiB3cm90ZToNCj4+Pj4NCj4+Pj4gT24gV2VkLCBPY3Qg
MDYsIDIwMjEgYXQgMDY6NDA6MjdQTSArMDEwMCwgUmFodWwgU2luZ2ggd3JvdGU6DQo+Pj4+PiBB
Uk0gYXJjaGl0ZWN0dXJlIGRvZXMgbm90IGltcGxlbWVudCBJL08gcG9ydHMuIElnbm9yZSB0aGlz
IGNhbGwgb24gQVJNDQo+Pj4+PiB0byBhdm9pZCB0aGUgb3ZlcmhlYWQgb2YgbWFraW5nIGEgaHlw
ZXJjYWxsIGp1c3QgZm9yIFhlbiB0byByZXR1cm4NCj4+Pj4+IC1FTk9TWVMuDQo+Pj4+IFdoYXQg
aXMgdGhlIGNhbCB0cmFjZSBvZiB0aGlzIGZ1bmN0aW9uIGFjdHVhbGx5IG9uIEFybT8NCj4+Pj4N
Cj4+Pj4gQUZBSUNUIGxpYnhsIHdpbGwgb25seSBjYWxsIHhjX2RvbWFpbl9pb3BvcnRfcGVybWlz
c2lvbiBpZiB0aGVyZSBhcmUNCj4+Pj4gSU8gcG9ydHMgZXhwbGljaXRseSBkZWZpbmVkIGluIHRo
ZSBndWVzdCBjb25maWd1cmF0aW9uLCBvciBpZiBhbnkgb2YNCj4+Pj4gdGhlIEJBUnMgb2YgdGhl
IFBDSSBkZXZpY2UgaXMgaW4gdGhlIElPIHNwYWNlLCB3aGljaCBpcyBub3QgcG9zc2libGUNCj4+
Pj4gb24gQXJtLg0KPj4+IFBDSSBkZXZpY2VzIEJBUnMgY2FuIGJlIGluIHRoZSBJTyBzcGFjZSBh
cyB0aGUgUENJIGRldmljZXMgYXJlIG5vdA0KPj4+IEFybSBzcGVjaWZpYy4gVGhlcmUgaXMgbm90
IGlvcG9ydHMgb24gYXJtIHNvIHRvIGJlIHVzZWQgdGhvc2UgY2FuIGJlDQo+Pj4gaW4gc29tZSBj
YXNlcyByZW1hcHBlZCBhbmQgYWNjZXNzZWQgYXMgTU1JT3Mgb3IgYXJlIG5vdCBwb3NzaWJsZQ0K
Pj4+IHRvIHVzZSBhdCBhbGwuDQo+Pj4NCj4+PiBCdXQgdGhlIElPIHNwYWNlIGRvZXMgYXBwZWFy
IHdoZW4gQkFScyBhcmUgbGlzdGVkIGV2ZW4gb24gQXJtLg0KPj4gVXJnLCBJIHdvbmRlciB3aGV0
aGVyIHRob3NlIGRldmljZXMgd2l0aCBJTyBCQVJzIHdpbGwgd29yayBjb3JyZWN0bHkNCj4+IHVu
ZGVyIEFybSB0aGVuLg0KPj4NCj4+IEhvdyBkbyB5b3Uga25vdyB3aGV0aGVyIHRoZSBCQVIgaGFz
IGJlZW4gcmVtYXBwZWQgZnJvbSBJTyBzcGFjZSBpbnRvDQo+PiBNTUlPPw0KPiBXZSBjYW5ub3Qs
IEkgdGhpbmsgdGhlIHBsYXRmb3JtIHdpbGwgZGVmaW5lIGlmIHRoaXMgaXMgdGhlIGNhc2UgYW5k
IHdoZXJlLg0KPiBAb2xla3NhbmRyOiBJIHJlbWVtYmVyIHRoYXQgdGhpcyB3YXMgZGlzY3Vzc2Vk
IGR1cmluZyBzb21lIG9mIG91cg0KPiBtZWV0aW5ncyBidXQgSSBoYXZlIG5vIGlkZWEgb2YgdGhl
IGRldGFpbHMgaGVyZSwgY2FuIHlvdSBoZWxwID8NCj4NCkZvciB0aGUgZ3Vlc3QgZG9tYWlucyB3
ZSBlbXVsYXRlIGEgaG9zdCBicmlkZ2Ugd2l0aG91dCBJTywgc28gdGhlDQpndWVzdCB3b24ndCBi
ZSBhYmxlIHRvIGFzc2lnbiBhbnkgSU8gbWVtb3J5IGF0IGFsbC4=


From xen-devel-bounces@lists.xenproject.org Mon Oct 11 14:16:48 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 14:16:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.206104.361593 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZw6i-0003Ro-Pl; Mon, 11 Oct 2021 14:16:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 206104.361593; Mon, 11 Oct 2021 14:16:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZw6i-0003Rh-LA; Mon, 11 Oct 2021 14:16:48 +0000
Received: by outflank-mailman (input) for mailman id 206104;
 Mon, 11 Oct 2021 14:16:47 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=LfEM=O7=arm.com=Bertrand.Marquis@srs-us1.protection.inumbo.net>)
 id 1mZw6h-0003KN-KU
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 14:16:47 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com (unknown
 [40.107.7.54]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 22020e75-334f-4db3-98c1-721986b38b13;
 Mon, 11 Oct 2021 14:16:38 +0000 (UTC)
Received: from AS8PR04CA0043.eurprd04.prod.outlook.com (2603:10a6:20b:312::18)
 by PA4PR08MB5968.eurprd08.prod.outlook.com (2603:10a6:102:e9::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.19; Mon, 11 Oct
 2021 14:16:35 +0000
Received: from AM5EUR03FT013.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:312:cafe::fd) by AS8PR04CA0043.outlook.office365.com
 (2603:10a6:20b:312::18) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.24 via Frontend
 Transport; Mon, 11 Oct 2021 14:16:35 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM5EUR03FT013.mail.protection.outlook.com (10.152.16.140) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4587.18 via Frontend Transport; Mon, 11 Oct 2021 14:16:34 +0000
Received: ("Tessian outbound 16951d3c485e:v103");
 Mon, 11 Oct 2021 14:16:33 +0000
Received: from 8481dac253b9.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 6A978484-6AE3-49C1-A55A-AAAED631FC15.1; 
 Mon, 11 Oct 2021 14:16:22 +0000
Received: from EUR02-HE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 8481dac253b9.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Mon, 11 Oct 2021 14:16:22 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com (2603:10a6:4:74::9)
 by DB8PR08MB5260.eurprd08.prod.outlook.com (2603:10a6:10:e6::31) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.24; Mon, 11 Oct
 2021 14:16:19 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955]) by DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955%4]) with mapi id 15.20.4587.026; Mon, 11 Oct 2021
 14:16:19 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 22020e75-334f-4db3-98c1-721986b38b13
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=3VQ4oygj+f3p8TVhdwV7xQavFN/nXxhoMVYKuNGrM5U=;
 b=RK+85oSBDDcaYQWUMjyUB4Op3+yvD/IW3oAYrpEsu+ammDzZiPxM3a/MR6xtmUW6GQfe5h06rOs2rOBMToubTLvyEmivHorq8pkymH0JLltF2wwmpubHSm66QXuV6899SU27VnqJT3DsUbnlD8iiaw5we2N02mQuCzxPoaOtgA0=
X-MS-Exchange-Authentication-Results: spf=temperror (sender IP is
 63.35.35.123) smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass
 (signature was verified) header.d=armh.onmicrosoft.com;lists.xenproject.org;
 dmarc=temperror action=none header.from=arm.com;
Received-SPF: TempError (protection.outlook.com: error in processing during
 lookup of arm.com: DNS Timeout)
X-CheckRecipientChecked: true
X-CR-MTA-CID: 95836e4587cb99bb
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=k9s3nJSOoKth+Z0qcQeebXAihY3S7nW24Mwq0p/bHFeGdvaW5YmFbm+XCiOorB+ymTRZO+0GU/rVBZJO3syl0PG69Oa8i8e+q3AiCaw6oLA4CvnpW51UbSgt1+ViNizLJa0o4iuB47izyILAuuRpWNIb/WA7nU3TEPcsAxE0nIPow4RgG2TRAS2kPbs9MMI73HCaLS0KkLRn6BTNL9bwFR5w1sfTQCsXnj66D8ykHNRnUyrGkzzwHSAQyMJSLRKiM95MsOZpJVwQvOklNGE9HOvmxXkpk1Ik3OWMwvIk0JtmcvEhQTiyYaQ3GKlrFtZ+TzfxxhcI1ThsN308UfJ0NA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=3VQ4oygj+f3p8TVhdwV7xQavFN/nXxhoMVYKuNGrM5U=;
 b=QJxUSfvdz4s7K8XjVqZW/wl92Sw36/enwMdPokFR+aPoEnCCRwr8P7sYGZPjIVRurSbBa6vZKYa3qnHvr0DPPICh25tK5fjrplI3yiZlngc8aIAkuau3IBGBoGUE6olS2RhaccsmkU/bAK01e8Qi/yBxDykpa2zDVcUExoRp5ZwKsEv8dKI4RsfWf9Rl2BNPjNvYm0mTWXtJ3xOi6yVorNMIbD5xCDdZnF9ZSJWnA4NpkKQalNT3el2DuH5ryg5RXkhcMN4zGJ852mppaKH4gmvt+EK1PjqSwJZnRIxyvZp1HCiw7trzPivfruVTp8rtwGxPIxGdLLqAkjl/s+Q51Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=3VQ4oygj+f3p8TVhdwV7xQavFN/nXxhoMVYKuNGrM5U=;
 b=RK+85oSBDDcaYQWUMjyUB4Op3+yvD/IW3oAYrpEsu+ammDzZiPxM3a/MR6xtmUW6GQfe5h06rOs2rOBMToubTLvyEmivHorq8pkymH0JLltF2wwmpubHSm66QXuV6899SU27VnqJT3DsUbnlD8iiaw5we2N02mQuCzxPoaOtgA0=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>
CC: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>, Rahul Singh
	<Rahul.Singh@arm.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, Andre Przywara <Andre.Przywara@arm.com>,
	Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>, Juergen Gross
	<jgross@suse.com>, Stefano Stabellini <sstabellini@kernel.org>
Subject: Re: [PATCH v5 01/11] xen/arm: xc_domain_ioport_permission(..) not
 supported on ARM.
Thread-Topic: [PATCH v5 01/11] xen/arm: xc_domain_ioport_permission(..) not
 supported on ARM.
Thread-Index:
 AQHXutl5d8zkP9bsD0GXT4+5QPGclKvNtfkAgAAGc4CAABOEAIAABXoAgAAEuYCAAAVHAA==
Date: Mon, 11 Oct 2021 14:16:19 +0000
Message-ID: <FEF0B03A-5AC8-4F8D-B821-191AC2EF8295@arm.com>
References: <cover.1633540842.git.rahul.singh@arm.com>
 <d292392268df2c74c4103a82ef917072643407a8.1633540842.git.rahul.singh@arm.com>
 <YWQkblfNMYEs6jI9@MacBook-Air-de-Roger.local>
 <77CF7FA5-C566-469E-B4A8-0400789890BB@arm.com>
 <YWQ6Nk3Jk+BqgkwZ@MacBook-Air-de-Roger.local>
 <53AE6E2A-01D7-41EC-9B2C-C0D596EB8D4D@arm.com>
 <YWRCxXGQIyTOAepC@MacBook-Air-de-Roger.local>
In-Reply-To: <YWRCxXGQIyTOAepC@MacBook-Air-de-Roger.local>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3654.120.0.1.13)
Authentication-Results-Original: citrix.com; dkim=none (message not signed)
 header.d=none;citrix.com; dmarc=none action=none header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: d79f43d4-31f0-4ca2-7612-08d98cc1baef
x-ms-traffictypediagnostic: DB8PR08MB5260:|PA4PR08MB5968:
x-ms-exchange-transport-forked: True
X-Microsoft-Antispam-PRVS:
	<PA4PR08MB5968FF2D19DBAE9642D128A29DB59@PA4PR08MB5968.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:10000;OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 evu0MpMVlvA7E+sDDI07kyIkgsxyfTCVGtdAghcMa2LxOWrgZPDX8H8IWIfz7gbAkELja/+FHBg2/ic3gR9ftV9rGpXkrKXal0j7+iwgaLbYcIjdmIm0B6aJDISZjDjJ3U1lQ4fkYhqILI4MThhsXSYTZ1Eh0cr4olSGqK+VB/5LM3nn5Fk5GrWbsKw5bCVZLo422nZC1zrEOBHQt18mX96uQ8EyCCB3PVUj1C8N2T1mSmLY+/O43VXxANX6bf9A/pkJi9L3ak/wF551n7NiGxV6h+1GlMjgkqCx0jcI6G8Zp5TRJq8BE/vpWGSJokxyjzhP3FeKz73/u5VbR5jLLnVCeNGs+t2iXTvfJUrk8OboA5Lybg9hmXqkqjCiM0mHBU/6EiFB3WWvBtnj7bOFpHbn14y5bGsvg7tyAinZvLyaLdf7anY/6KOxOA6Zb2IeMOv3g+kU3sBk8PwXaEM32g7mzPZPubrqnssiyguZY5OfxDtLlmFMj7uaIZAa1pyyowFy+HPtH0l2ue5C72dfUGdZ0nt357/L5RIz9uhQMkqPK8FFNOsQRJs9WwZkvN922UlEvXPmX42XPT3qOzNPNCwuQVnpOXGAd1kYBQ0cP7Uy1iXAu2ReQovGtQMWjEAH8hXPLfN6cJImE8679gqlQSscE7BXkZH98IjgcsHZ4uzud0LjaPAuVljXameJc/ckwbjL0rzabAd9bsHFV1xysb/viJs7HA2m5+krCerMh2yiT5A0rS5JedGx2Wgpc4fU
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB6PR0801MB2024.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(84040400005)(122000001)(26005)(38100700002)(186003)(4326008)(6916009)(53546011)(6506007)(8936002)(38070700005)(6486002)(54906003)(6512007)(2616005)(316002)(71200400001)(2906002)(508600001)(8676002)(36756003)(33656002)(5660300002)(83380400001)(76116006)(91956017)(66446008)(66946007)(64756008)(86362001)(66476007)(66556008)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-ID: <DB3644808C119642B2ED8C83AF35EF3C@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB5260
Original-Authentication-Results: citrix.com; dkim=none (message not signed)
 header.d=none;citrix.com; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM5EUR03FT013.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	15fc7ee1-c117-4639-a564-08d98cc1b25d
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	9uGb8VbH2OLg1MIgn7S59G+lWcTQyPTqxGHxqvPKbiHV8ikwXLy8SoWl598v9sSe6oAw/aai+T3Ihzj1PVk0sVxhedXi/3pwD45qeEtaCquYJ2NK4QRt8L+N6Xi4oTB5IuPe6opg6uKykCB4XVDDly160TJUL0zqav6n1dD4MJqxM0PLK5MnRlP80r9ngRnAu50E+EvODEdgQ1Qb9fAhhB/wY5tVTRWAB77/yQQITY2rmQ436y1JNtv/2k5IS+w0K08Jn6KpOkzbmo3ED14p7gdNMBDyVAjvBM7ewARPtNwZDBHCCGAuXsiFkiRI7AHKx8QLTeahREdEzparHS+OnVW2tJG7XLLO1B/MPUamc5zqgp+ZFwL8pTB5taERXfvMvgAcfLu+LgzY1I+dDlzctSs5fqc8tTS0HapGrC/07jPffaGdctIdQH68bvY7s+3l9F5M52SbwSvN9o7T1SfgUYIhq6gLYrEP5I6shmam5pC60t21o28+n+rkjzdxIVpqujP7yJWBPflUnJLUASILCtMzX8IFEMP1tjHTcbpFSwsngH0JIe/hY+dOALgJV//+Loq8UNY1C/qefrhTDfJ7H2CP7CMeh9oAcuephZgdY53toTerhPB/2k9/DuTHHLZjdqMmbPsWBqH0ZJZJ/v+rJbPhBRVc7nvSfLnVYIY49MYBwvlOXbg87/KEN7N8E1VpBYuCR/nU2em7FkEtMWf5vO+cPVhq54zIqurwFZLtGoM=
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(84040400005)(46966006)(36840700001)(70206006)(4326008)(36756003)(47076005)(107886003)(8936002)(82310400003)(26005)(54906003)(33656002)(6486002)(5660300002)(186003)(6512007)(36860700001)(336012)(316002)(63370400001)(70586007)(8676002)(2616005)(6862004)(81166007)(356005)(2906002)(83380400001)(53546011)(86362001)(6506007)(508600001)(63350400001)(45980500001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2021 14:16:34.1844
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: d79f43d4-31f0-4ca2-7612-08d98cc1baef
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM5EUR03FT013.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB5968

SGkgUm9nZXIsDQoNCj4gT24gMTEgT2N0IDIwMjEsIGF0IDE0OjU3LCBSb2dlciBQYXUgTW9ubsOp
IDxyb2dlci5wYXVAY2l0cml4LmNvbT4gd3JvdGU6DQo+IA0KPiBPbiBNb24sIE9jdCAxMSwgMjAy
MSBhdCAwMTo0MDozMFBNICswMDAwLCBCZXJ0cmFuZCBNYXJxdWlzIHdyb3RlOg0KPj4gSGkgUm9n
ZXIsDQo+PiANCj4+ICsgT2xla3NhbmRyIHRvIGhhdmUgYSBiZXR0ZXIgUENJIGV4cGVydCB0aGVu
IG1lLg0KPj4gDQo+Pj4gT24gMTEgT2N0IDIwMjEsIGF0IDE0OjIwLCBSb2dlciBQYXUgTW9ubsOp
IDxyb2dlci5wYXVAY2l0cml4LmNvbT4gd3JvdGU6DQo+Pj4gDQo+Pj4gT24gTW9uLCBPY3QgMTEs
IDIwMjEgYXQgMTI6MTE6MDRQTSArMDAwMCwgQmVydHJhbmQgTWFycXVpcyB3cm90ZToNCj4+Pj4g
SGkgUm9nZXIsDQo+Pj4+IA0KPj4+Pj4gT24gMTEgT2N0IDIwMjEsIGF0IDEyOjQ3LCBSb2dlciBQ
YXUgTW9ubsOpIDxyb2dlci5wYXVAY2l0cml4LmNvbT4gd3JvdGU6DQo+Pj4+PiANCj4+Pj4+IE9u
IFdlZCwgT2N0IDA2LCAyMDIxIGF0IDA2OjQwOjI3UE0gKzAxMDAsIFJhaHVsIFNpbmdoIHdyb3Rl
Og0KPj4+Pj4+IEFSTSBhcmNoaXRlY3R1cmUgZG9lcyBub3QgaW1wbGVtZW50IEkvTyBwb3J0cy4g
SWdub3JlIHRoaXMgY2FsbCBvbiBBUk0NCj4+Pj4+PiB0byBhdm9pZCB0aGUgb3ZlcmhlYWQgb2Yg
bWFraW5nIGEgaHlwZXJjYWxsIGp1c3QgZm9yIFhlbiB0byByZXR1cm4NCj4+Pj4+PiAtRU5PU1lT
Lg0KPj4+Pj4gDQo+Pj4+PiBXaGF0IGlzIHRoZSBjYWwgdHJhY2Ugb2YgdGhpcyBmdW5jdGlvbiBh
Y3R1YWxseSBvbiBBcm0/DQo+Pj4+PiANCj4+Pj4+IEFGQUlDVCBsaWJ4bCB3aWxsIG9ubHkgY2Fs
bCB4Y19kb21haW5faW9wb3J0X3Blcm1pc3Npb24gaWYgdGhlcmUgYXJlDQo+Pj4+PiBJTyBwb3J0
cyBleHBsaWNpdGx5IGRlZmluZWQgaW4gdGhlIGd1ZXN0IGNvbmZpZ3VyYXRpb24sIG9yIGlmIGFu
eSBvZg0KPj4+Pj4gdGhlIEJBUnMgb2YgdGhlIFBDSSBkZXZpY2UgaXMgaW4gdGhlIElPIHNwYWNl
LCB3aGljaCBpcyBub3QgcG9zc2libGUNCj4+Pj4+IG9uIEFybS4NCj4+Pj4gDQo+Pj4+IFBDSSBk
ZXZpY2VzIEJBUnMgY2FuIGJlIGluIHRoZSBJTyBzcGFjZSBhcyB0aGUgUENJIGRldmljZXMgYXJl
IG5vdA0KPj4+PiBBcm0gc3BlY2lmaWMuIFRoZXJlIGlzIG5vdCBpb3BvcnRzIG9uIGFybSBzbyB0
byBiZSB1c2VkIHRob3NlIGNhbiBiZQ0KPj4+PiBpbiBzb21lIGNhc2VzIHJlbWFwcGVkIGFuZCBh
Y2Nlc3NlZCBhcyBNTUlPcyBvciBhcmUgbm90IHBvc3NpYmxlDQo+Pj4+IHRvIHVzZSBhdCBhbGwu
DQo+Pj4+IA0KPj4+PiBCdXQgdGhlIElPIHNwYWNlIGRvZXMgYXBwZWFyIHdoZW4gQkFScyBhcmUg
bGlzdGVkIGV2ZW4gb24gQXJtLg0KPj4+IA0KPj4+IFVyZywgSSB3b25kZXIgd2hldGhlciB0aG9z
ZSBkZXZpY2VzIHdpdGggSU8gQkFScyB3aWxsIHdvcmsgY29ycmVjdGx5DQo+Pj4gdW5kZXIgQXJt
IHRoZW4uDQo+Pj4gDQo+Pj4gSG93IGRvIHlvdSBrbm93IHdoZXRoZXIgdGhlIEJBUiBoYXMgYmVl
biByZW1hcHBlZCBmcm9tIElPIHNwYWNlIGludG8NCj4+PiBNTUlPPw0KPj4gDQo+PiBXZSBjYW5u
b3QsIEkgdGhpbmsgdGhlIHBsYXRmb3JtIHdpbGwgZGVmaW5lIGlmIHRoaXMgaXMgdGhlIGNhc2Ug
YW5kIHdoZXJlLg0KPj4gQG9sZWtzYW5kcjogSSByZW1lbWJlciB0aGF0IHRoaXMgd2FzIGRpc2N1
c3NlZCBkdXJpbmcgc29tZSBvZiBvdXINCj4+IG1lZXRpbmdzIGJ1dCBJIGhhdmUgbm8gaWRlYSBv
ZiB0aGUgZGV0YWlscyBoZXJlLCBjYW4geW91IGhlbHAgPw0KPj4gDQo+Pj4gDQo+Pj4gSU1PIGlu
c3RlYWQgb2YgZmFraW5nIGEgc3VjY2Vzc2Z1bCByZXR1cm4gdmFsdWUgZnJvbQ0KPj4+IHhjX2Rv
bWFpbl9pb3BvcnRfcGVybWlzc2lvbiB3ZSBzaG91bGQgYXZvaWQgdGhlIGNhbGwgY29tcGxldGVs
eSBpbiB0aGUNCj4+PiBmaXJzdCBwbGFjZSwgc3BlY2lhbGx5IGlmIHdlIG5lZWQgdG8gaW5zdGVh
ZCBpc3N1ZSBhIGNhbGwgdG8NCj4+PiB4Y19kb21haW5faW9tZW1fcGVybWlzc2lvbi4NCj4+IA0K
Pj4gQXQgdGhlIGVuZCB3ZSB3aWxsIG5ldmVyIGhhdmUgdG8gaXNzdWUgdGhpcyBiZWNhdXNlIHRo
aXMgd2lsbCBuZXZlciBiZSBhIG1hdHRlcg0KPj4gb2Yg4oCcaW9tZW3igJ0gcGVybWlzc2lvbiBh
cyB0aGVyZSB3b3VsZCBub3QgYmUgYW55IHdheSB0byBjdXQgb24gc29tZXRoaW5nIHVuZGVyDQo+
PiB0aGUgcGFnZS4gSWYgdGhpcyBpcyB0byBiZSBzdXBwb3J0ZWQgb25lIGRheSwgaXQgd2lsbCBw
cm9iYWJseSBoYXZlIHRvIGJlIGZ1bGx5IGVtdWxhdGVkDQo+PiB0byBrZWVwIHRoZSBpc29sYXRp
b24uDQo+IA0KPiBTbyB5b3UgaGF2ZSBhIHNldCBvZiBtZW1vcnkgcGFnZXMgdGhhdCBtYXAgYWNj
ZXNzZXMgZnJvbQ0KPiBNTUlPIGludG8gSU8gc3BhY2UgYnV0IGl0J3Mgbm90IHBvc3NpYmxlIHRv
IGlzb2xhdGUgc3BlY2lmaWMgSU8gcG9ydA0KPiByZWdpb25zIGFzIHRoZXkgYXJlIGFsbCBjb250
aWd1b3VzIGluIHRoZSBzYW1lIHBhZ2UocykuDQoNCkV4YWN0Lg0KDQo+IA0KPj4gUmlnaHQgbm93
IG9uIGFybSB5b3UgY2FuIGp1c3QgbWFrZSB0aGUgbW9yZSBzaW1wbGUgYXNzdW1wdGlvbiB0aGF0
IGlvcG9ydHMgYXJlDQo+PiBqdXN0IG5vdCBzdXBwb3J0ZWQuDQo+IA0KPiBXb3VsZCBpdCBtYWtl
IHNlbnNlIGluIHRoZSBmdXR1cmUgdG8gcHJvdmlkZSBhIG1lbW9yeSByZWdpb24gdG8gZ3Vlc3Rz
DQo+IGluIG9yZGVyIHRvIHVzZSBmb3IgSU8gcG9ydCBhY2Nlc3NlcywgYW5kIGNhbGwNCj4geGNf
ZG9tYWluX2lvcG9ydF9wZXJtaXNzaW9uIHRvIHNldCB3aGljaCBwb3J0cyB3b3VsZCBiZSBhbGxv
d2VkPw0KDQpSaWdodCBub3cgd2UgZG8gbm90IHBsYW4gdG8gc3VwcG9ydCB0aGlzIGF0IGFsbCBh
bmQgd2Ugd2lsbCBoYXZlIHRvDQpmaWd1cmUgdGhpcyBvdXQgaWYgd2UgZG8gdGhpcyBvbmUgZGF5
Lg0KDQo+IA0KPiBJIHRoaW5rIHRoZSBjb21taXQgbWVzc2FnZSBuZWVkcyB0byBhdCBsZWFzdCBi
ZSBleHBhbmRlZCBpbiBvcmRlciB0bw0KPiBjb250YWluIHRoZSBpbmZvcm1hdGlvbiBwcm92aWRl
ZCBoZXJlLiBJdCBtaWdodCBhbHNvIGJlIGhlbHBmdWwgdG8NCj4gZmlndXJlIG91dCB3aGV0aGVy
IHdlIHdvdWxkIGhhdmUgdG8gaGFuZGxlIElPIHBvcnQgYWNjZXNzZXMgaW4gdGhlDQo+IGZ1dHVy
ZSBvbiBBcm0sIG9yIGlmIGl0J3MgZmluZSB0byBqdXN0IGlnbm9yZSB0aGVtLg0KDQpBbGwgb3Vy
IGludmVzdGlnYXRpb25zIGFuZCB0ZXN0cyBoYXZlIGJlZW4gZG9uZSB3aXRob3V0IHN1cHBvcnRp
bmcgaXQNCndpdGhvdXQgYW55IGlzc3VlcyBzbyB0aGlzIGlzIG5vdCBhIGNyaXRpY2FsIGZlYXR1
cmUgKG1vc3QgZGV2aWNlcyBjYW4NCmJlIG9wZXJhdGVkIHdpdGhvdXQgdXNpbmcgdGhlIEkvTyBw
b3J0cykuDQoNCkkgY2FuIGFkZCB0aGUgZm9sbG93aW5nIHRvIHRoZSBjb21taXQgbWVzc2FnZToN
CkkvTyBwb3J0cyBhY2Nlc3NpYmxlIHRocm91Z2ggTU1JTyBhcmUgY3VycmVudGx5IG5vdCBzdXBw
b3J0ZWQgYnkgWGVuLg0KDQpSZWdhcmRzDQpCZXJ0cmFuZA0KDQo+IA0KPiBUaGFua3MsIFJvZ2Vy
Lg0KDQo=


From xen-devel-bounces@lists.xenproject.org Mon Oct 11 14:20:50 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 14:20:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.206115.361604 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZwAW-0004xv-9k; Mon, 11 Oct 2021 14:20:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 206115.361604; Mon, 11 Oct 2021 14:20:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZwAW-0004xo-5w; Mon, 11 Oct 2021 14:20:44 +0000
Received: by outflank-mailman (input) for mailman id 206115;
 Mon, 11 Oct 2021 14:20:42 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=9TNE=O7=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mZwAU-0004xi-Lk
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 14:20:42 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 69bfec4d-2a9e-11ec-80e0-12813bfff9fa;
 Mon, 11 Oct 2021 14:20:41 +0000 (UTC)
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur01lp2057.outbound.protection.outlook.com [104.47.2.57]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-21-MLB6n8_XMRez0U8rOU2S-Q-1; Mon, 11 Oct 2021 16:20:39 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB7037.eurprd04.prod.outlook.com (2603:10a6:800:125::7)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18; Mon, 11 Oct
 2021 14:20:38 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4587.026; Mon, 11 Oct 2021
 14:20:38 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6P191CA0039.EURP191.PROD.OUTLOOK.COM (2603:10a6:209:7f::16) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4587.21 via Frontend Transport; Mon, 11 Oct 2021 14:20:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 69bfec4d-2a9e-11ec-80e0-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1633962040;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=sKjsAzvkK3m98dcMYZdfJ+I4/nNBXGKaM3Yto11X+Hg=;
	b=Hm4OzTWfm9qus31Zoj8R38Wz9ROk/qXVIxWK20Fd9F4XU6wRgxx1fUZNY/oScXo+RIOsvi
	tAvInwbodczHsfP2hDkZsjNOX5f7tMW+pLY+PKQ8ukOO3StrICq3SF5li7rXRu0rIQtTAu
	TnOIrSqrBSGUnwPv1VOHXZbX1PvWuOI=
X-MC-Unique: MLB6n8_XMRez0U8rOU2S-Q-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=lMaXYitKugqM6uTU16il3hIE/Q6qiUbFnlPUGHMo7mwfOdCAFBno3vWksJbwTiitfMUtlGxv5HVNiF4hLRvoPFytHUtV3O9AJDxRmQUMcB+keljUoPYs/scYjQcjuAY/RgQ/zyaoGosWMRr848ki1Ob8nYBWhCe2uV87yjMvTEy37ZyUSRPh4LcfiAUKu+7Q+25PPsYh/uQQYuYhaqbnXK6Z9yMDsZyKntiZ6D33naJcWybEBmf3LqawTWq8AjWKtp/EhEYgA5rxqXNVsQPTH1YPm3+tvQFgPpZhZTKilZX4QE5cwX0zdZWW5JePRC7t+ayVtjf7GDBuOwXi7EvtNw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=sKjsAzvkK3m98dcMYZdfJ+I4/nNBXGKaM3Yto11X+Hg=;
 b=SuciyaoSMGlGIfot3WAA9tzgg6Qnqj4IW3HCWM3igecMIA5ww4W8slmyi8WVsONxZXtzOG0z3PlwccgJNHk861butY1Jm6coW3wvOFHN1JofY9WSvN8UUULQDhc053MYB/a0u80/SnH77ROgYFQX8oRue/RGlducOm2h0AOw29Yt23J0TdSNprL9B3I9qINEURmpXo1ti10Q60J3Rv9MOYFlJ7MmO2JIhqi2MJiXCIiEOi5TZo2WD9C6i3wU8y7mvEw/LxuAZzyUYlwB6p5m0REivFr3v2LYbPGgU0uzhBeJul3hpPyI65uEeFQXh5xdzB+v7QEs4rlgymPfcZLTmg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [XEN PATCH v7 27/51] build: introduce if_changed_deps
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>, xen-devel@lists.xenproject.org
References: <20210824105038.1257926-1-anthony.perard@citrix.com>
 <20210824105038.1257926-28-anthony.perard@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <4a1fc8b7-b915-2092-19bd-89a58cf3f232@suse.com>
Date: Mon, 11 Oct 2021 16:20:36 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <20210824105038.1257926-28-anthony.perard@citrix.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P191CA0039.EURP191.PROD.OUTLOOK.COM
 (2603:10a6:209:7f::16) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 54ce9c29-794b-4352-8907-08d98cc24c31
X-MS-TrafficTypeDiagnostic: VI1PR04MB7037:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB7037C145FBB1D10E976D8173B3B59@VI1PR04MB7037.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:2803;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	eKCvhyGPSOEv3Uvo8Yobvp9tbG7b81ti5j+DWU0LocT0rUwruL1HHEoUwPQ1G4bRA45wT3pX2v9UsR9G0AQPymKDFGQD75AddmWQ9hChUiZnYDlYBRlQteNbHfEa1hTjgu6L8gNqStBBpauNfg9ZSvZ9gByTPlTL3yxKhkGgnNJX74dt30VuPmONC0iX5EjKZ/ytMZu8mSZKOTqyMVqHUxOIAM0EmqMK3e00cUiel4Zt376jBm95A7NEkNVTggHbn57MXoNQXmEBKfYv6V1IG7lX+V+crx8C5TdAKooJNJQ/mQSs37y+JYuyZup+A+2YgSkCtDb+WsLKO5H7Dj8nIw2I1WMF6x2Bie6rmuSUGgNenm4H4fh9rJwupz+ZK/ZTzLQJNbPT+fZ2pkr+NJ/OiAnTKMuzsfNvrOypVRTRye73qr8FXyXglrHJ2NQPr2y5PtJkyHP5H98uTAknXnaY1Lz59asmofr1VThsskBqs91syJXcnwJw/V6GWhxvkmYimfDGwfd/2BjX09RXSiwDXRLSri+X/UgNkrMJ4abWq9gPRUHHeQi7XP7aq5BrUedghSzLTEerl3SzDZoJoD79RORbUJRlfWUKTLlT+v4dW12b9fmyUxPXv9joVbjBGgaDPyJEE1BKI2v5QYKgloEdJprmpsFTIUi0o1V12CotFnV5nR+Hml7vYcJa8o7gE0yGY9URNyqTjVHx7fmCwGZJkuwfJqUI8Rtgbc8A2FjwmJbOi4vV699ORXQ4BpqkCnKS
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(66946007)(53546011)(8936002)(36756003)(186003)(26005)(5660300002)(83380400001)(86362001)(8676002)(6486002)(38100700002)(6916009)(66556008)(16576012)(316002)(31696002)(66476007)(2906002)(2616005)(31686004)(956004)(54906003)(4326008)(508600001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?L0lHQ05SNmJwaGVqbjNyazhEdjZaVTU0dVRPLzBjRDM2UDJRV2tGLytJaVZH?=
 =?utf-8?B?ZWN4STFaeXIvNGx4eWVjTjZrajliN1MxRllSaGJaSnQrcVVNNmFJNEhERncw?=
 =?utf-8?B?c0t1d1BCaE9WcUN0SkZYTGJ4WGRoaFJ5bzhvNDJnTmFSRFRienFpZ1dqWHU3?=
 =?utf-8?B?bXgrZitBNnJoRW04WC9ha0dyamFxbjgwRWZxclVucE1mamRHbnRtaU9YS0dZ?=
 =?utf-8?B?RUtZNUhCcVppU3l3c3pTalJMTXVRWHk0TWxSQnFLZHkyRHBEY3p4UlUrQVA4?=
 =?utf-8?B?T1hhT1hwNHVvV1QxbU9pdU92TjRqUmVvT2FlUnlUUTgwRW01YWpZTTREdTJM?=
 =?utf-8?B?amYxVGI5OEtyZ0x3Y3dqRlFEcFFBSG5tZ1dQaFBiZVBNdXdlNllFTERuTXd5?=
 =?utf-8?B?ZHFnK2ZXbmZMNU1UMTBhZW9Ucm4rcnNnZUZXbmkrMXd6NjY5SVVPN2RxaDBV?=
 =?utf-8?B?eElvQ2s1bTc2ck45RUFPcWpKL0ZoL09NU2pjM2E1OW5mczEvMzczQXVkaXlJ?=
 =?utf-8?B?QmJxY2wrRmZFSFdvdVF2ZGJrbTZmbmlxeXBubkZIOVduOUNEWnpOdG1DR2Iy?=
 =?utf-8?B?azJicW5MUGpRRjNaVWRKRENRajJVb29CZGFHZVBMditnZXJuQ3dGZDEyc1M1?=
 =?utf-8?B?ZjVXQUtBVEh0NlFTWmF0NEtoMU4xZXFJS05BQUtGMDBYSjYzZWJBaUx0cUkx?=
 =?utf-8?B?bmczVkljR3ZyQTQzK2F3RXh0c3VIWHFqN25OdTBQeEJSZkkwTVpUaDZjME9B?=
 =?utf-8?B?aTdrYmRDUzlTTVJJaWZPUGNRc3ZnUUVObVdqVjRFVTROODV1dUZUU29vcXln?=
 =?utf-8?B?WEYvM2NFMUdPZmR5akZucmZORFM4cExpdXlldzBPTUp0OGNQMStBckF1OTVU?=
 =?utf-8?B?blVHdUl2NXpSa3dwYWt0eVhTT09SVmtYSDY1Z0llN04zU1B0dTlrcFRSQXlQ?=
 =?utf-8?B?K2lYRzBib3Y5WmxYMDVkWTRacHRiRDhqRWpKZXFCVjQyclZEbGJQc0VLM25S?=
 =?utf-8?B?MzIvbXczcmJINjZhU3ZFbkxjc3lETHZqbm5ES1JFUUlVVW4zSjZPeHZONWEy?=
 =?utf-8?B?RGlaUWxvakVFbjZrMzl6YzlQNWRnYXlZRFRQMTFUd09rQThzRVJTVHRCSFFC?=
 =?utf-8?B?UnAveVFua1RhM1A4ZnhEblFmTzV6N0dmajBJWjBYMFVvMDdvR3lyNkRNTk0z?=
 =?utf-8?B?cHEvWkNIVnA4Q2tTM0IyREdSM05ET1hmaTArNzluYUJmZTZEcXhBUHVwc0Vz?=
 =?utf-8?B?bUg5VlZhc0VwRDgyUVlJcWRJbDhEdWExWkNHWmUwU0NEb3c1TC9lWW1ZNlor?=
 =?utf-8?B?clFzakhEcUxKMy9FNW5qUW9jbmovMC9OdmtYQ1E5ZHlHcDlrWUs2MUpWbDZC?=
 =?utf-8?B?TUF2bkhtdlNhUlFhaUwvenRRbXNMRDlYODBqR0c1ZUpqR3F3NktjQW05YWQ1?=
 =?utf-8?B?TFJuL3JnMStiaDVUbDVqRktMUmRWSDBxbENKTy9BbjIzd2hxZmV1MXlCUWlS?=
 =?utf-8?B?amUwb2h2ZnRCZlhmUlord3N0aHR5NGpVM3o4YmZRc1BqUFNRZVdKODN3M1Zn?=
 =?utf-8?B?U1MrSFFtUVFxc3RpUE9BVTlwVE9WOW1JUllPMFhlRmpsenI4anFNRDdHTWJ2?=
 =?utf-8?B?UlcvMGMwaldjZGN1QWg0dmZWcGpBR0tpaWI2ZHduYXJlT29PSUpKNEl0Y2NM?=
 =?utf-8?B?TEdEaXplU25EUDNBMVovNWhKZkRacUNpLy94T0ZyOE5Qc0htTVFEeVpQV0FF?=
 =?utf-8?Q?/OyKifu4my1VssJ1Y8StXl1aRaQSCPt/c5LH0gL?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 54ce9c29-794b-4352-8907-08d98cc24c31
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2021 14:20:38.0454
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: NZv2ZQfT36a5wve3WXtSBFuCMm8NAvxQx5EhjPTfp3JE1QLBdYFHWJFejXShlVBuJrnQWcbBu7GAgzZM/cqGdA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7037

On 24.08.2021 12:50, Anthony PERARD wrote:
> This macro does compare command line like if_changed, but it also
> rewrite the dependencies generated by $(CC) in order to depend on a
> CONFIG_* as generated by kconfig instead of depending on autoconf.h.
> This allow to make a change in kconfig options and only rebuild the
> object that uses that CONFIG_* option.
> 
> cmd_and_record isn't needed anymore as it is replace by
> cmd_and_fixdep.
> 
> There's only one .*.d dependency file left which is explicitly
> included as a workound, all the other are been absorb into the .*.cmd
> dependency files via `fixdep`. So including .*.d can be removed from
> the makefile.
> 
> This imports fixdep.c and if_changed_deps macro from Linux v5.12.
> 
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>

Reviewed-by: Jan Beulich <jbeulich@suse.com>
with a question:

> --- a/xen/Makefile
> +++ b/xen/Makefile
> @@ -187,6 +187,13 @@ endif
>  export root-make-done := y
>  endif # root-make-done
>  
> +# ===========================================================================
> +# Rules shared between *config targets and build targets
> +
> +PHONY += tools_fixdep
> +tools_fixdep:
> +	$(MAKE) -C tools fixdep
> +
>  # Shorthand for kconfig
>  kconfig = -f $(BASEDIR)/tools/kconfig/Makefile.kconfig ARCH=$(ARCH) SRCARCH=$(SRCARCH) HOSTCC="$(HOSTCC)" HOSTCXX="$(HOSTCXX)"
>  
> @@ -400,7 +407,7 @@ $(TARGET).gz: $(TARGET)
>  	gzip -n -f -9 < $< > $@.new
>  	mv $@.new $@
>  
> -$(TARGET): FORCE
> +$(TARGET): tools_fixdep FORCE
>  	$(MAKE) -C tools

Shouldn't this include building fixdep, in which case the extra dependency
here is unnecessary? I can see that it's needed ...

> @@ -457,13 +464,13 @@ cscope:
>  _MAP:
>  	$(NM) -n $(TARGET)-syms | grep -v '\(compiled\)\|\(\.o$$\)\|\( [aUw] \)\|\(\.\.ng$$\)\|\(LASH[RL]DI\)' > System.map
>  
> -%.o %.i %.s: %.c FORCE
> +%.o %.i %.s: %.c tools_fixdep FORCE
>  	$(MAKE) $(build)=$(*D) $(*D)/$(@F)

... in cases like this one.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Oct 11 14:22:02 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 14:22:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.206121.361615 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZwBl-0005X4-Kn; Mon, 11 Oct 2021 14:22:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 206121.361615; Mon, 11 Oct 2021 14:22:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZwBl-0005Wx-HO; Mon, 11 Oct 2021 14:22:01 +0000
Received: by outflank-mailman (input) for mailman id 206121;
 Mon, 11 Oct 2021 14:22:00 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mZwBk-0005Wj-EX; Mon, 11 Oct 2021 14:22:00 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mZwBk-000719-8I; Mon, 11 Oct 2021 14:22:00 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mZwBj-0002D7-TA; Mon, 11 Oct 2021 14:21:59 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mZwBj-0004qx-Sg; Mon, 11 Oct 2021 14:21:59 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=decvBGyFfY7Y+OEUtF9YSjX7RUdWM8xQIngx83boUoY=; b=7P4ApRF2fY/dRzpwwSZtdzyHum
	NOXD/Ei92/kl1h12CUffHtm7jBCglet2G7tUnqatk7gM//yYd3hqMlw4Km3plCk2JlrCk+d80f67k
	tJqVrHtkw7z1QmC6vL6Df9umcdwhzeVA3eZdLT1WYO474PTk6aJnom+WfYC6uTyGwYwQ=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165465-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 165465: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=2fac4e3ea3bb301f87426e24b9dfd765c22c9cf9
X-Osstest-Versions-That:
    xen=664cc3c3d381e4f9a61dcb68cbd7a6a00070370e
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 11 Oct 2021 14:21:59 +0000

flight 165465 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165465/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  2fac4e3ea3bb301f87426e24b9dfd765c22c9cf9
baseline version:
 xen                  664cc3c3d381e4f9a61dcb68cbd7a6a00070370e

Last test of basis   165439  2021-10-09 03:01:40 Z    2 days
Testing same since   165465  2021-10-11 10:02:56 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Christopher Clark <christopher.w.clark@gmail.com>
  Jan Beulich <jbeulich@suse.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   664cc3c3d3..2fac4e3ea3  2fac4e3ea3bb301f87426e24b9dfd765c22c9cf9 -> smoke


From xen-devel-bounces@lists.xenproject.org Mon Oct 11 14:22:31 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 14:22:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.206130.361628 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZwCF-000697-3R; Mon, 11 Oct 2021 14:22:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 206130.361628; Mon, 11 Oct 2021 14:22:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZwCF-00068x-0I; Mon, 11 Oct 2021 14:22:31 +0000
Received: by outflank-mailman (input) for mailman id 206130;
 Mon, 11 Oct 2021 14:22:29 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=rMo6=O7=citrix.com=anthony.perard@srs-us1.protection.inumbo.net>)
 id 1mZwCD-00068g-LO
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 14:22:29 +0000
Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id a8d05c3c-2a9e-11ec-80e0-12813bfff9fa;
 Mon, 11 Oct 2021 14:22:28 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a8d05c3c-2a9e-11ec-80e0-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1633962148;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=4nRljQS8nVpVHJNzZV7SnqlN3ajyLFly2XyKieHbMzk=;
  b=E8MMMxTB5Av0Bh3E98ON5aBxb0VCXpcWIj5v+j3Y5a84bWBX7nmVEpNI
   8gRtLMgyg7TW/XPL/5+TraPnAZPGFFTpOORL3pxqqfa5mwDvUdRa8ECPz
   tMefCpw0YB6z9QHY2LMKxUj+a+x3FYCMuNe6AV3HggLSOdArtydgqVpBP
   I=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: iBhIL0yiUdV9ov6YDuEZgHbCVJ4VHg9iYvSwgUNHiS2i91Ep8RzLIWxt9B9MIGwwYtTCSYvExu
 NBW1rywKJH5x04g7vhf3KW+phxIqGeQZ293ANsBbx7EKMzIu7GCenA7t9bnmFuz9EnyKGaxY62
 QcmZ+NA9Fg5/cg876rli/8/1/LQiQ3xBq/sqyx7pOEkEtDrEZtYluVYF8DA+NJ3uFJFLfKkxLm
 H0LgScduu6gG2FgRwSCylLgFUCd8C0V2YPs0Dls1CBKiJurnFbtJTy2UjP1c8KWrqo4yfYAu4E
 bedmutbtEJhH44pY5eTDLmaA
X-SBRS: 5.1
X-MesageID: 54884379
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:IHucNKjvvNryy0h0qeoF7K/xX161qRcKZh0ujC45NGQN5FlHY01je
 htvWz/TPamDZ2Tzedtxa4zipBsP7MSHxoU2GQBl/iBmQ34b9cadCdqndUqhZCn6wu8v7a5EA
 2fyTvGacajYm1eF/k/F3oAMKRCQ7InQLlbGILes1htZGEk0FU/NtTo5w7Rg29Yx2IDga++wk
 YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq
 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx
 /12nI6UGSsEL5aRmbhFUQR6TRpfJ6dJreqvzXiX6aR/zmXDenrohf5vEFs3LcsT/eMf7WNmr
 KJCbmpXN1ba2rzwkOnTpupE36zPKOHiOp8fvXdxiynUF/88TbjIQrnQ5M8e1zA17ixLNauCN
 5pFMmU+BPjGSyBPOkoaEJEhoP6hg0jNNAZEhEu34qVitgA/yyQuieOwYbI5YOeiVchT20qVu
 G/C12D4GQ0BcsySzyKf9XChjfOJmjn0MKoNEJWo+/gsh0ecrkQRAhALUVqwodGil1WzHdlYL
 iQpFjEG9PZoshbxF5+kAkP+8CXsUgMgt8R4KMQozFGh57vvvgfFXmoZbGB6ScYsu5pjLdA17
 WOhk9TsDD1plbSaT3OB67uZxQ+P1TgpwXwqPnBcE1NUizX3iMRq1EiXF4c8eEKgpoStQWmY/
 tyckMQpa1z/Z+Yw3KKn4UuPvTuoopXYJuLezlSKBjz7hu+ViYjMWmBJ1bQ5xaoQRGp6ZgPY1
 JThpyR4xLpTZX1qvHbcKNjh5Jnzu5643MT02DaD5aUJ+TW34GKEdotN+jx4L0oBGp9aImS5M
 ReM4FoNusQ70J6WgUlfONjZ5yMCl/mIKDgYfqqMMoomjmZZJWdrAx2ClWbPhjuwwSDAYIk0O
 IuBcNbEMJrpIf8P8dZCfM9EieVD7nlnnQv7HMmnpzz6gev2TCPEEt8tbQrRBt3VGYvZ+W05B
 f4EbJDUo/ieOcWjChTqHXk7dAhQcydgX8yq8qS6tIere2JbJY3oMNeJqZtJRmCvt/g9ej7g8
 i7vV0lG5kD4gHGbewyGZmo6MOHkXIplrGJ9NispZA76138maIepzaEea5poIuV3qL09laZ5H
 6sfZsGNIvVTUTCbqT4TWobw8d55fxOxiAPQYyf8OGojf4RtThDi88P/ele97zEHCye67JNso
 7Cp2g7Bb4AEQgBuUJTfZP61lgvjtnkBguNiGUDPJ4ALKknr9YFrLQ33j+M2fJ5QeUmSmGPC2
 l/PUxkCpOTLr4sky/XzhPiJ/9WzDu9zPktGBG2Hv7y4AjbXozi4yohaXefWIT2EDDHo+L+vb
 Pl+xu3nNKFVh05DtodxHuo5za864Nez9bZWwh49QSfOZlWvTLhhPmOHzY9EsagUnu1Vvg6/W
 0Su/NhGOOrWZJO5QQBJfAd1PP6e0fw0myXJ6aVnKUr30yZ74b6bXBgAJBKLkiFccON4PY5NL
 T3NYyLKB9hTUiYXD+s=
IronPort-HdrOrdr: A9a23:qwa8nqNNUfP1FcBcTsOjsMiBIKoaSvp037Eqv3oRdfVwSL3+qy
 nOpoV+6faaslossR0b9uxofZPwJ080lqQFhLX5X43SPzUO0VHAROoJgLcKgQeQeREWntQtrJ
 uIGJIfNDSfNzZHsfo=
X-IronPort-AV: E=Sophos;i="5.85,364,1624334400"; 
   d="scan'208";a="54884379"
Date: Mon, 11 Oct 2021 15:21:48 +0100
From: Anthony PERARD <anthony.perard@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Roger Pau
 =?iso-8859-1?Q?Monn=E9?= <roger.pau@citrix.com>, Wei Liu <wl@xen.org>,
	<xen-devel@lists.xenproject.org>
Subject: Re: [XEN PATCH v7 17/51] build: set XEN_BUILD_EFI earlier
Message-ID: <YWRIfH+62TUsOqPA@perard>
References: <20210824105038.1257926-1-anthony.perard@citrix.com>
 <20210824105038.1257926-18-anthony.perard@citrix.com>
 <6d2f9787-d156-0b06-0548-97198af644f9@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <6d2f9787-d156-0b06-0548-97198af644f9@suse.com>

On Thu, Oct 07, 2021 at 06:14:33PM +0200, Jan Beulich wrote:
> On 24.08.2021 12:50, Anthony PERARD wrote:
> > $(nr-fixups) is renamed to $(efi-check-relocs) as the former might be
> > a bit too generic.
> 
> While I don't mind the prefix addition, may I please ask that the rest
> of the name remain as is, i.e. $(efi-nr-fixups)? "nr" because that's
> what the variable holds, and "fixups" to distinguish from full-fledged
> relocations as well as to match commentary there.

Will change.

> > --- a/xen/arch/x86/Makefile
> > +++ b/xen/arch/x86/Makefile
> > @@ -123,41 +123,7 @@ $(TARGET): $(TARGET)-syms $(efi-y) boot/mkelf32
> >  	mv $(TMP) $(TARGET)
> >  
> >  ifneq ($(efi-y),)
> > -
> > -# Check if the compiler supports the MS ABI.
> > -export XEN_BUILD_EFI := $(shell $(CC) $(XEN_CFLAGS) -c efi/check.c -o efi/check.o 2>/dev/null && echo y)
> >  CFLAGS-$(XEN_BUILD_EFI) += -DXEN_BUILD_EFI
> > -
> > -# Check if the linker supports PE.
> > -EFI_LDFLAGS = $(patsubst -m%,-mi386pep,$(XEN_LDFLAGS)) --subsystem=10
> > -XEN_BUILD_PE := $(if $(XEN_BUILD_EFI),$(call ld-option,$(EFI_LDFLAGS) --image-base=0x100000000 -o efi/check.efi efi/check.o))
> > -# If the above failed, it may be merely because of the linker not dealing well
> > -# with debug info. Try again with stripping it.
> > -ifeq ($(CONFIG_DEBUG_INFO)-$(XEN_BUILD_PE),y-n)
> > -EFI_LDFLAGS += --strip-debug
> > -XEN_BUILD_PE := $(call ld-option,$(EFI_LDFLAGS) --image-base=0x100000000 -o efi/check.efi efi/check.o)
> > -endif
> > -
> > -ifeq ($(XEN_BUILD_PE),y)
> > -
> > -# Check if the linker produces fixups in PE by default
> > -nr-fixups := $(shell $(OBJDUMP) -p efi/check.efi | grep '^[[:blank:]]*reloc[[:blank:]]*[0-9][[:blank:]].*DIR64$$' | wc -l)
> > -ifeq ($(nr-fixups),2)
> > -MKRELOC := :
> > -relocs-dummy :=
> > -else
> > -MKRELOC := efi/mkreloc
> > -relocs-dummy := efi/relocs-dummy.o
> > -# If the linker produced fixups but not precisely two of them, we need to
> > -# disable it doing so.  But if it didn't produce any fixups, it also wouldn't
> > -# recognize the option.
> > -ifneq ($(nr-fixups),0)
> > -EFI_LDFLAGS += --disable-reloc-section
> > -endif
> > -endif
> > -
> > -endif # $(XEN_BUILD_PE)
> > -
> >  endif # $(efi-y)
> 
> Is the remaining if(,) block still warranted? I.e. can't the single line
> 
> CFLAGS-$(XEN_BUILD_EFI) += -DXEN_BUILD_EFI
> 
> live without the surrounding conditional?

Let's see, $(efi-y) depends on CONFIG_PV_SHIM_EXCLUSIVE and `sudo make
install`, but XEN_BUILD_EFI also depends on CONFIG_PV_SHIM_EXCLUSIVE and
we don't want to build in `sudo make install` so CFLAGS shouldn't be
used. So the single line without the if() block seems enough. I remove
the surrounding conditional.

Thanks,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Mon Oct 11 14:22:51 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 14:22:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.206137.361640 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZwCZ-0006gr-Cp; Mon, 11 Oct 2021 14:22:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 206137.361640; Mon, 11 Oct 2021 14:22:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZwCZ-0006gk-8t; Mon, 11 Oct 2021 14:22:51 +0000
Received: by outflank-mailman (input) for mailman id 206137;
 Mon, 11 Oct 2021 14:22:50 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=rMo6=O7=citrix.com=anthony.perard@srs-us1.protection.inumbo.net>)
 id 1mZwCY-0006fJ-6l
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 14:22:50 +0000
Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id fe9722b9-b6af-4691-a7b4-c778a04fca80;
 Mon, 11 Oct 2021 14:22:49 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fe9722b9-b6af-4691-a7b4-c778a04fca80
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1633962169;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=tX5/QVzzkAiTeJF4H2vdtKAV07e/76s4GmbMS2DiTfM=;
  b=W5EM6Av5v1SGkUDNA/38VVKLO81HjYTFKwJHvV/wYnOj1J/aFJfBSIEf
   oaT53SNz7dindoUxiRWYixulkWy63PnqP2cGeyvO4d2GEK3hN6hYZyE+9
   Oyj4OL2GZRz82/NgrF4w6Pq6+PMITyVHBYvqrSYomsW9uoQHGU8gdQPVn
   I=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: tzQnUxYX9IZHPnkZJd88ADDJCBe4wRrW5O+LImm0KY8PwL2hliGb22kodHvC1A0lMbgo8rj8V1
 n763MZOoHB4NgMTSqn3o1EChqpFYnet6zvuDiVOGFwttDl/+0jQJPYT9yxkg+yJLBsuMf1EGuB
 gn8x2F7nhf+ZLXf+Q7p9ehxaUEHMDhnV5hZSsvnBljwsA3B1nZTCTBTdZuRY/A2Iayc0Negj0h
 gjSCOxKNWmnn5df/y0fGzQ2pwtvJPvNKGA0LysYQvHH8ukfEYAjtd2JzJ03u+WV0HwcWT2qdXA
 4TESsr8WIaOrIt4X8xEs7gdP
X-SBRS: 5.1
X-MesageID: 54919159
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:7FZlpaoYC7wEfO/s9HvyCIy30ANeBmKZYhIvgKrLsJaIsI4StFCzt
 garIBnQM/2JZDCmc98jbdni8ksHu8fdmoNiHVFlqS1nEytD95uZCYyVIHmrMnLJJKUvbq7GA
 +byyDXkBJppJpMJjk71atANlZT4vE2xbuKU5NTsY0idfic5Dnd84f5fs7Rh2Ncx2YHgW1rlV
 e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL
 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9
 DlCncKweyAGb5zdoe4ycyIJPj4hB6Bs3YaSdBBTseTLp6HHW37lwvEoB0AqJ4wIvO1wBAmi9
 9RBdmpLNErawbvrnvTrEYGAhex6RCXvFIoZpnFnyyCfFfs8SIrPa67L+cVZzHE7gcUm8fP2O
 pZIMGs2MUWojxtnEXlQN58RuOuUrSP4YRZypW+Vqqwv/D2GpOB2+Oe0a4eEEjCQfu1rmUKfq
 nPD7n7OKBgQP9yCyhKI6nupwOTImEvTSI8UUbG16PNuqFmS3XAITg0bU0Ohpvu0gVL4XMhQQ
 2QW5y4voK4a5EGtCN7nUHWQonSJoxodUNp4CPAh5UeGza+8yx2CGmEOQzpFadonnMw7Xzon0
 hmOhdyBONB0mOTLEzTHrO7S9G7sf3hORYMfWcMaZVUF0f7M8bAitxjgbu0yPbHqtNDfPAill
 lhmsxMCr7kUiMcK0YCy8lbGny+gq/D1c+Il2unEdjn6tl0hNeZJc6TtsAKBta8Rc+51W3HY5
 CBc8/Vy+tziGn1keMale+4KAK2yr8iMNDnRkDaD9LFwqmzzpRZPkW1WiQySxXuF0O5YKVcFg
 2eJ4Gu9AaO/2lPwMMebhKrrWqwXIVDIT4iNaxwtRoMmjmJNXAGG5jpyQkWbwnrglkMh+YlmZ
 8zAIZf0Ui9DVfo8pNZTewv7+eRxrszZ7TmCLa0XMjz9iebODJJrYeZt3KSyghARs/rf/VS9H
 yd3PMqW0RRPONASkQGMmbP/2WsidCBhbbiv8pQ/XrfafmJORTFwY9eMkOhJU9E0wMxoehLgo
 yjVtrlwkwGk2xUq6GyiNxheVV8Ydc8n9yxkZnZwYQ/ANrpKSd/H0ZrzvqAfJdEPnNGPB9YoJ
 xXcU8nfUPlJVBrd/DERMcv0oIB4LUz5jgOSJSu1JjM4esc4FQDO/9bleCrp9TUPUXXr5Zdv/
 eX421OJW4cHSiRjEN3SNKClwWSusCVPg+l1RUbJfIVeIR2+7IhwJiXtpfYrOMVQew7bzz6X2
 l/OUxcVrOXAuaEv99zNifzWpoulCbImTEFbA3Pa/fC9MiyDpjivxopJUeCpezHBVTyrpPX+N
 LsNl/ylaa8JhldHtYZ4Ao1H96Nm6ou9vaJewyRlAG7PMwahBIR/LyTUxsJIrKBMmONU4FPkR
 kKV99BGEryVI8e5QkUJLQ8oY+nfh/EZnj7esaY8LEngvXIl+bOGVQNZPgWWiTwbJ7xwadt3z
 eAksc8Qygq+lht1bYrW0nEKrzyBfi4aTqEqlpAGG4u62AMkx2ZLbYHYFiKrsoqEbM9BMxVyL
 zKZ7EYYa2+wGqYWn6IPKEXw
IronPort-HdrOrdr: A9a23:Y6BRD6Pm/6MnbcBcTsGjsMiBIKoaSvp037Eqv3oedfVwSL39qy
 nOpoV/6faaslsssR0b9exofZPwJk80lqQFg7X5X43DYOCOggLBR+tfBMnZsl7d8kXFh4hgPM
 xbEpSWZueeMWRH
X-IronPort-AV: E=Sophos;i="5.85,364,1624334400"; 
   d="scan'208";a="54919159"
Date: Mon, 11 Oct 2021 15:22:38 +0100
From: Anthony PERARD <anthony.perard@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Stefano Stabellini <sstabellini@kernel.org>, Julien Grall
	<julien@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	<xen-devel@lists.xenproject.org>
Subject: Re: [XEN PATCH v7 18/51] build: fix $(TARGET).efi creation in
 arch/arm
Message-ID: <YWRIrgSk2FbAUup5@perard>
References: <20210824105038.1257926-1-anthony.perard@citrix.com>
 <20210824105038.1257926-19-anthony.perard@citrix.com>
 <34b274ae-fb02-10df-85ed-8d5231d49750@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <34b274ae-fb02-10df-85ed-8d5231d49750@suse.com>

On Mon, Oct 11, 2021 at 12:37:55PM +0200, Jan Beulich wrote:
> On 24.08.2021 12:50, Anthony PERARD wrote:
> > There is no need to try to guess a relative path to the "xen.efi" file,
> > we can simply use $@. Also, there's no need to use `notdir`, make
> > already do that work via $(@F).
> > 
> > Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
> 
> Reviewed-by: Jan Beulich <jbeulich@suse.com>
> 
> As to the subject, I don't think "fix" is appropriate. How about "adjust"
> or "simplify" or some such?

"adjust" sound good, thanks.

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Mon Oct 11 14:23:38 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 14:23:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.206147.361651 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZwDJ-0007Mt-LY; Mon, 11 Oct 2021 14:23:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 206147.361651; Mon, 11 Oct 2021 14:23:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZwDJ-0007Mm-IR; Mon, 11 Oct 2021 14:23:37 +0000
Received: by outflank-mailman (input) for mailman id 206147;
 Mon, 11 Oct 2021 14:23:36 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=9TNE=O7=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mZwDI-0007Ma-Hu
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 14:23:36 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id d14ce0ae-2a9e-11ec-80e0-12813bfff9fa;
 Mon, 11 Oct 2021 14:23:35 +0000 (UTC)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2050.outbound.protection.outlook.com [104.47.12.50]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-24-E7ynR6-LPtaI1emo_W0W9g-1; Mon, 11 Oct 2021 16:23:33 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB3120.eurprd04.prod.outlook.com (2603:10a6:802:e::11) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18; Mon, 11 Oct
 2021 14:23:31 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4587.026; Mon, 11 Oct 2021
 14:23:31 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS8PR04CA0164.eurprd04.prod.outlook.com (2603:10a6:20b:331::19) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.25 via Frontend
 Transport; Mon, 11 Oct 2021 14:23:30 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d14ce0ae-2a9e-11ec-80e0-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1633962214;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=gSNbTDKMv47lVA9krP5gkH1LOV83sXdTcVj+/XfwVao=;
	b=CHIE+UkzZ/6hRYi+iHNfUqgrXRmDWn40jhLOijqDg3GZtT8k57bHjrbmFzfvI1xi5AyYrp
	5WIlx+U0Rlszs9JYTmMX3Cng/GuNUYsNwYhr7Q2UyCwnZuaixzVpJE8tZJ/Xacw14gGMlW
	OFeCtnDZ5v7M6AIdQHr06bTJ+GdGqsM=
X-MC-Unique: E7ynR6-LPtaI1emo_W0W9g-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=l36Zn+VebHkmS1gg4QQVSJpWnuIrlmA0xEMm9hS8KkTKX4mOm2qPfcroLPdS32/PFaJ2kc0+8XR4d2xTN5YfZ6FcvXuqBSNPe/ON/qP5PX539SNRkibkM1ezzgFBAw7JpYYfSbIoLva1oYH5PZdIblBL5s4fcdgPxdhWI8ByLBBP26yb/OA52QZD5q3yUgEwjLtv1MSpiToB37FeewDEcoKETc5G16uR2dXTNu9SUUONTtlG07J5mVWNzmiHvnNyA2nRjOQi+8XHRP4ZFuW3i9HPPU+p/3mZ+7GRkw6HxG6QytRb9vO18yt9bc7jhkUeAybxlF9XglmvwmnjyNUUBw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=gSNbTDKMv47lVA9krP5gkH1LOV83sXdTcVj+/XfwVao=;
 b=ZZR7Ng8YDw0zHlhVW5lkna/kCd9Ka0X66TfLzQXqsTbpt0cs/Zox9BqMXzED96GQqt7akJG+8UtZG1meI1RAvWNx7u23TC6Qy15a8HODffrAvct6vvpSeE6zys0MoHG5h62szhtqrXdM08Rjfp4wv9OuIb2HGF78oEInGA5zToQ+1lUvdtD2ZKqYDZvRXQKydkjYtnJX8bncYl1qQDE7ZGXAl0u+Pp9uHf58bad+LBUoFdhC7qW6NP9E3dRS7RE38Li/Xjmv3NIRKN2InCjlBUxT/B4PsmZw8aA2q+PyqQED8WAhhOADS19LBL5WD6mjKYxIMKmnuAwBl0ddy45riQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [XEN PATCH v7 28/51] build: rename __LINKER__ to LINKER_SCRIPT
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 xen-devel@lists.xenproject.org
References: <20210824105038.1257926-1-anthony.perard@citrix.com>
 <20210824105038.1257926-29-anthony.perard@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <4753df37-c187-5e78-c95d-38425161a528@suse.com>
Date: Mon, 11 Oct 2021 16:23:29 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <20210824105038.1257926-29-anthony.perard@citrix.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8PR04CA0164.eurprd04.prod.outlook.com
 (2603:10a6:20b:331::19) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 8b9ef293-42c8-493c-4a42-08d98cc2b378
X-MS-TrafficTypeDiagnostic: VI1PR04MB3120:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB312015E9B797B455DD501B3CB3B59@VI1PR04MB3120.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:1148;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	v/fhNVCrXR1SlVIDd+hLR/slY5HMHbwYph5a0DycOL4QWNaG9eHOz8KEvlx4JYT4BDAzF4dh3Q+n+gO8RA5A+E5QIwzr97RJNfhb5uHaKa2rJgV25LVsHlS8vc6ifvMTjgv3AKIZH5JVbfqo/MuDZOPIWhLidvzZ5LF2hsVEtdBqETl0r51qAayTfL3IUb19uKQTiBs285l9mr91oCAScPEdbJq6AhaWrn91Gp6Oga7kDNIrpEW4ZOS1BCI9GIz4dQ/NNncmgcHuwntwDoZO7uVCkCZ/Ki3IzBkUurtliphAhtvdo65v3XyZnoGX92VOdrNNiAWQ6uhbGW0IR2VkwMtKtJlUEAirlPRmWa8fTSJLUhgXUxAFR2bv/N0DkbHNQLnaL4c3pE3cNHn3VN9MiH/aMdAyZ3n2gAxPbiAOcIPx4gHBUNbGyayn/KHpDXBK0jBkqm4RIrTdb8nZNPlhaCs+W2WYiHnunUx4zZu2zbrbrynJiN2WSPIIHIVvAoTBuuxszcfI/oiwox5C0p+rBFXsftZbaUv5zbs1wftRF0WdjeMGmMdHqNzgLn2boGbuyUq7tzeJjWSkD5zCOH5tkcl8Jmk+8Ruzui+p2lCg5ht+3tbsJ4ysIytVeG/XPoF/5lO95ujShGJ0N9pKasA5o6RBoGQ0SmDyRS5Ltba/dy8q6XPL86aQXaT04s46NvAuUBFKQItgwtEqf1TIx8q1nAzOF0MKe6fGLGrIEtvLiu/XsPfHEgjYnAbw3BuBM36z
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(4744005)(4326008)(8936002)(31696002)(2906002)(38100700002)(53546011)(31686004)(86362001)(6916009)(316002)(36756003)(54906003)(26005)(16576012)(508600001)(6486002)(956004)(66556008)(5660300002)(8676002)(2616005)(66946007)(66476007)(186003)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?QzVSQ1VCWkZYb2ZaUjhGMTBJMDdmaHZQSyt0MitFR3BFZGFacVhwOURDS3Fl?=
 =?utf-8?B?S3ZlYSthTWQ1bXlERVZ3aDFWdVFvVFZ1NElEZXBOVUxKYndxUUlsUzZpaDg5?=
 =?utf-8?B?Ym1RcDNlTjN5ZzRTbjVhU0EvV3hZdUtTTWpvNVVxaGxNL3F1U01kRlpjNTRO?=
 =?utf-8?B?UFN2TTdxd0tGcnBHa2ovd0FNd1R3NUhGZ2NOZ2pKVjlXdEFjNHJQajZGUEtt?=
 =?utf-8?B?OG0yMml4ZVlza1lMNWJPeDloU1V3NGt3T2xMUXZmelpkK0ttMVgrdkN0Nk93?=
 =?utf-8?B?UWVyTDJNRjlOcFJ5ZFVvVmJ5VUMvcG9OMDc5R2VzS0tXN3hMMWc4dVlTWms5?=
 =?utf-8?B?QWNkNkw5d0xXa2NTUm8xQldwdldwZEN6R0ljR1hxdlBmOHJYQ2twRUtkNVJw?=
 =?utf-8?B?YVBwQVhTN0dITGFQVzNlaWhBcDhSdHcvWEJ5UEUyZ0hyT0NTVXZJd3ozRllH?=
 =?utf-8?B?UjRTY1N3NzJVUkFWd3duNGc3REd5bHJqcXRlVDRmNUczSDUyckowSlJ4MHRR?=
 =?utf-8?B?L253bGlFV3oyQWxnMm1wN21rQkhBV1pqL3J0NE5Leks1b0UxTE82UWlkbzB1?=
 =?utf-8?B?dTgzaThnc2l1NE1zbVpQTkZuNDlUUkdMR2sxeXY5cGZWaElMdndiTmNId3Zw?=
 =?utf-8?B?RkJzdTI5MG5xRk1vZy91WmhEZncxWUcxajR3TzhHRjgvcDVwWnd4andYayth?=
 =?utf-8?B?NGRHZ0NVczFrNDJWWktkV3FiVFpwSU5vWFowektJTy9wK2ZvTEVCL0lFZDZQ?=
 =?utf-8?B?MDVzQmRjUlhpNzNLeVJDZDRmTkhzVmxlcU1Mb2cvNWNlUFoyNnVNRlBaR1RL?=
 =?utf-8?B?WlhkSC9QdWJ5ZlZVMnBMR0tkakxEbXIyTE01NjBtZTdDelN0Z29HTVZDcmdM?=
 =?utf-8?B?NWVJK2dmdlpxL1A3S0s1TytLMEhMV2NLaG5qSW0yK0xSeXZGT010MmZyU1ZX?=
 =?utf-8?B?d1FMd2lBbXhJUndZa2NBODgzMEFpQWZRSzVCeVBDYkx5YU94dDBsTUdpQ3Br?=
 =?utf-8?B?TmNCNFNVMkFZNE5FVEV1YTNIWnhybjRMTjl0SUdXOE9INGdzbU40N3Z2cEh6?=
 =?utf-8?B?U1ZyRHFadzFaRUY5UVpITVduOUpkQkJoUUpQcXAyUWN4cmp2MFRUR0UvUE55?=
 =?utf-8?B?aWo2cnJCQ0k3OEZJSXIvRi9HeHFmRzk1RkJnVmx5WlIvcFpwbmZjSXVmWTFK?=
 =?utf-8?B?OEp1bXMwbUN1ZS9tNkFsRnAzV0RiaVZlYmZLZ05VYTFZeUNJT2tHbFNSemVU?=
 =?utf-8?B?aGM5WE0yUGhUVlZNY3hqZFNocjNaMGlpbVphTE1UY3pvdWF5QmtEWklYYlB6?=
 =?utf-8?B?NUhUZ0NKaGtqVjlpVytnRnM3RWtmTFN5bjBnSUxsZzZqVEFJRVFzWDZhLzBL?=
 =?utf-8?B?Y0F4Vlc2U2RGRitsMG11cXZUZWZQWnpxNlhBOXRObFVBY3pNNVUzSmVwL0N0?=
 =?utf-8?B?N05sV2NkRWJRbTJnd3FtMHNicSsxTEI2OUlDb05wdHE2QlpuZ044QnFOK2Ir?=
 =?utf-8?B?MXB1R1cyUzExRFZ5UGFNN3oreXV4bnQyMUxPemNUaHNKc3djdVJYTHVMS0hy?=
 =?utf-8?B?UTg2T0JOS2QvK1QvMGxtTGhvM1ZISWhjeVREbWhYREQrR3IvdFV0Z0lpL3c3?=
 =?utf-8?B?anA0cHg4RllSOXBtV2lXUmh5bVhQYUtIbEl0a1h3ZFRzSVRmN1lwT3k2YXd2?=
 =?utf-8?B?UzZ6ZmhIb2lGMWwyZ3I5Y2VUZU9meE1JY3pEWVQ5MXVSN3RyQkVOTnZueUky?=
 =?utf-8?Q?H7+6NyqeEca9DNxjcENIJElQ0RbkVKnuUASq+wj?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8b9ef293-42c8-493c-4a42-08d98cc2b378
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2021 14:23:31.3714
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +BJ9H6UcB8kYCOmZ38+9F+Wye38aLHiVcFxtS03Fpk702V8LtPkgd2Q9niSceZMVvMSD2zH2soA93jYCDoCEyQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB3120

On 24.08.2021 12:50, Anthony PERARD wrote:
> For two reasons: this macro is used to generate a "linker script" and
> is not by the linker, and name starting with an underscore '_' are
> supposed to be reserved, so better avoid them when not needed.
> 
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>

Reviewed-by: Jan Beulich <jbeulich@suse.com>



From xen-devel-bounces@lists.xenproject.org Mon Oct 11 14:29:49 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 14:29:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.206158.361662 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZwJG-00088d-C0; Mon, 11 Oct 2021 14:29:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 206158.361662; Mon, 11 Oct 2021 14:29:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZwJG-00088W-8h; Mon, 11 Oct 2021 14:29:46 +0000
Received: by outflank-mailman (input) for mailman id 206158;
 Mon, 11 Oct 2021 14:29:44 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=9TNE=O7=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mZwJE-00088Q-T6
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 14:29:44 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id ad0a7251-2a9f-11ec-80e0-12813bfff9fa;
 Mon, 11 Oct 2021 14:29:44 +0000 (UTC)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2111.outbound.protection.outlook.com [104.47.17.111])
 (Using TLS) by relay.mimecast.com with ESMTP id
 de-mta-39-a7zHLdrhO9qRKTFECurEhw-1; Mon, 11 Oct 2021 16:29:38 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0402MB3775.eurprd04.prod.outlook.com (2603:10a6:803:1a::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.24; Mon, 11 Oct
 2021 14:29:36 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4587.026; Mon, 11 Oct 2021
 14:29:36 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS8PR04CA0014.eurprd04.prod.outlook.com (2603:10a6:20b:310::19) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.24 via Frontend
 Transport; Mon, 11 Oct 2021 14:29:36 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ad0a7251-2a9f-11ec-80e0-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1633962583;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=Aow3dn6mw8Vmj0BQNW9QVxQHgMnGOTqgYe2KIeT4Q+0=;
	b=NYHO+awqF3O2iIVC5NQWtgk9P4yEF+uHsPqjNEjr++AP0xSKfWbQKZ9ibOX2vO/RuqrJi6
	959KYDZQNPxP4W5uMl8SKyyaju37EUrHY3CSf4UUxMbKIpgBkE6camCJdAgDbET7FUFrzP
	PzZkCHgfBLRSuB2W2V0GC8FESFJhSpY=
X-MC-Unique: a7zHLdrhO9qRKTFECurEhw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Yk7uGvpunrNADq/6482YCaigOabozE2l4nZ9SgAGx26eL5FirgTzWokT1/07Ioo07QqF2vqYVGrBFf0aVO93NJ3T/QNyX7CKSyf3flz/Zvf/HsAiFoVvXiCC3DrR/vFULzwZAW3VOMMGRQ0TI40jbanHrg6GQOqFmCut7AOStN7fcz4cP+nhJ2x4f016HVFxUQRycbLN4KQKWh5rfN0cdCe75YqgZbWKsc75LkXDn+s70C6OMQNsn/aphSZ87r9DofOF77+cFRTfvrhbMnWzqhx91G5AgAuvThPUYe7s2LNq/8VSRh4RhK0TPFa8U/1VF5yqfSCajQjrGApiSboqbA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Aow3dn6mw8Vmj0BQNW9QVxQHgMnGOTqgYe2KIeT4Q+0=;
 b=I6tevelpOmKxT8vshpIoL/fWqZMj8qGFPRQL6Vn4omzrM8DIDXgVufFoTHw6kWShW+TVQgb6d73kA8IKNOBYszmDd2yEKJZgVw7BlxeJ8A4OagUoCynFSxMs/VOCHn0PtOMhNJ5pdjI5PR5BDpjv1CCLUgcNUYsckLVgZX1KqNaFrDt7RhB5Oz74OzrdtX4PwO2TLD8IwebT6X064G/gbxZSnJgMs1sgkcvrbDltDHcDPPVSzQCsTpMP/l7XOlkXA6+5+SGiX6r726QlYYdjtAa9rCU0sOkxOIB71kBevH+6e9ZHwVTbCWXzy2JhEOz/QSXOarpie45kJTqFLXioPg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [XEN PATCH v7 29/51] build: add an other explicite rules to not
 build $(XEN_ROOT)/.config
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>, xen-devel@lists.xenproject.org
References: <20210824105038.1257926-1-anthony.perard@citrix.com>
 <20210824105038.1257926-30-anthony.perard@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <c9e7f5cb-3a0a-f28b-bfbd-f610043b3cf5@suse.com>
Date: Mon, 11 Oct 2021 16:29:34 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <20210824105038.1257926-30-anthony.perard@citrix.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8PR04CA0014.eurprd04.prod.outlook.com
 (2603:10a6:20b:310::19) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 416a3ddd-7fb7-496f-25df-08d98cc38d49
X-MS-TrafficTypeDiagnostic: VI1PR0402MB3775:
X-Microsoft-Antispam-PRVS:
	<VI1PR0402MB3775C0D84AD7FD5AAC96A025B3B59@VI1PR0402MB3775.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	H5RN8du3C5h+nQtzCSUdmKFmThH67ai2t9IVwbAlZwibfVdJCTD/8QJ2UCkIvyn2IXN4SzrmBNhb2NlUWSslbI2xeb/5AC0dK+fXgVpkdZbPSOPciSs2BVP9i3vHuKq7vkO8VsPCk4frfpdLfUGZU3pga8FZLFvs7DwhSihhBxlxMAHp3lcivepSf4iTzWoMnQaTinrZJwWCqMVazpP6okCugoDiGKlAprxOSP/tx5HIwwNSRPGFyj1ZHi5ADX0lZGqPbY/hpvGzEczLV7xX8sGufz/Ldm+xPjfGQFtFojvXprEzGHu4NU3BLCegnNdQQVFFK4w3PChH4/UAhDuoU4IpNoGGrRC9XXQgRMtIK80X4HiO1zx+gx6xOB8VJfv1NuBYykYyLTkA9gkQ5mwOV+g2MN54N/Db4ucMJPDg2MGOx2lH49Ehisw6qC0tY9UOiaNcGzzk+RKP7ztVP/o4atJ97C3deMdNUdasWaMknPho07/rXouOvC927YF17ZeTPWGg9+ICSpnBeS5B+aRwOj38jN+7gHVgi3HeaKMZsznzqUpB1QoQEO6+1g2kRDPbAlHT4n/1pPRygmnAxDIeEyS77xFrk/EadR2L2NKn/sAhZv4ZHiqJaqEslvBRCm9gP1kJU0uwWhFjA7KLfp3opYk9aV6sbWWuBsdMQNyMN5xj5dYePVWuce51ffzVTP4JIc4CRfG3OSGfb97+9z3PgxRjNa0XnY6raMyenLlYyU8=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(66946007)(26005)(5660300002)(66476007)(54906003)(4326008)(8676002)(186003)(86362001)(66556008)(316002)(31696002)(8936002)(53546011)(36756003)(31686004)(16576012)(38100700002)(956004)(2616005)(4744005)(6486002)(2906002)(508600001)(6916009)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?NnlkQXpPZXYvbnhNOWhuemZ3VCtkOStkeWhxUmlxT1FTKzdkcG9YeldKaCtU?=
 =?utf-8?B?ekZvRVd5WktqTjlzTFZXbzlNeDEyUDFkUHU0NjJVZERNSnpUMDgxN2lXT3JL?=
 =?utf-8?B?L2lxbnpzYkZXTTFZT1pNeXhOS25GTzFNdk92Q0kremwxOXBvNXIxRG4rais2?=
 =?utf-8?B?a0Rma0NFcVV3b1JqWVhvL0dHUzQ2cy8vdHZOOE05L0RFTjFadXVzOWpuS1FY?=
 =?utf-8?B?OHdPbkpnVGJNK25vNVlybjVpWjJ5d0tXdWZBbjlwTk1IWXg5NW5oTjJMMnk1?=
 =?utf-8?B?bnZqQXFxWHJrRjFrekZNQnZGZ3MwT0pOZHplRURvRk41V0ZFNmNYL3RCNFNW?=
 =?utf-8?B?SkZJSHZmdDlvcHdBRi9VbDBkeVhsVnI0dFRQSS93a3NocFpjTWduN3IrRk9r?=
 =?utf-8?B?akpTOG5wdmRKTGJzUnF2a3VLT25HR01ldDBvbjZnUTVySGNNaXpuenlBbmVu?=
 =?utf-8?B?bGFUaktzV25VK3pYRU5COW9SZGRHcWxWanhRNmtMcUJjVmdBZGgvb0tCOTNB?=
 =?utf-8?B?SjlXalRoZzhFRWxKbmtCZitpYmxlYkc1RUEvMFFyQjBEczZuSmJWM0ZWUmMr?=
 =?utf-8?B?bjh0OTJCRDd6NVVrOHBzMUV6a203Q1FOb1dmSHRIc203N1VKTnpLTC9wbDVM?=
 =?utf-8?B?U0FmK2VHSzlYdnhHdWNCT1JCZWlUQXpSTVlDUjFqTjFPek9aOUVoak9DU3VP?=
 =?utf-8?B?dEc2NE1MbE1COFFXcTNsSXlOdW5aUUNFeWdrdWRCakZuT1Z3YzQ0NnU0em0r?=
 =?utf-8?B?Y1QwdmtnRWZ3d2lqN2wwVHdSbFlaZnBzWFg2dWl3L0ROYThTSURNNVIrRFJw?=
 =?utf-8?B?d3dKL2lQTS9oejgzOERaYjRFb0hqZE52V0ExRXRpSXM3MmxOc25ObG51QXJX?=
 =?utf-8?B?WkR0dDl2aWpEL1F6RjZyeS94WmNuWVFXZ013VUpocWpBLysvR3F2dEV1YTg5?=
 =?utf-8?B?aDJ6R3ZrQlhIWW41QXgwdlVaN1BxMlFLdXdHdzkzT2FYZEhTaTEwTnFjU1VB?=
 =?utf-8?B?R3lDbWsvSDhtOHlHOFo4T2NDUE9ESy92LzV6RDhBYVJCQmFtSjBTRWtHendG?=
 =?utf-8?B?aE5pNU1FUm1KWXVub3BOcDZWeGRidzYyWS93M09YUE9lYVNjbk1Lbm5vaVhp?=
 =?utf-8?B?emRsTzNwY25rYm5uY2V3VUVYMkFpZ01YdGJ0RVlMTnFtYnlKeEhBY1NEalAr?=
 =?utf-8?B?enlMZ1p1dXYvdGRrTU0rc1lMa3phSW92a2dZcEZ4bzA0YWZ2SHNwdHI2eGxq?=
 =?utf-8?B?Y2dxMDVCd0dFdzNwdG9kL3R3eVRqUm5VZnRCeEdpM2pWYUlOV0xmWHE0UGF5?=
 =?utf-8?B?dnIwT29Jb0U2VlV4bmRvR0hGeVpRU0c5VWtaZlQ2Y00rUDZOS29JV0xFQlZD?=
 =?utf-8?B?c01IcjR6ODJMZU1xTFVzRWJseFBzVFlidFhpMUVlR04wV0MxTjRtNFcvQUdq?=
 =?utf-8?B?MmpkT29uVTI4WXJSc1E4MWUyeEgxYndESTFoLzZKVTF0OEhFSmlCL0ZTMTE4?=
 =?utf-8?B?SUttN1UvQWxiTzFJekJaam1kd05mRGhsdlRJRXVOOVhLbklXZVNWL1h4cExH?=
 =?utf-8?B?Z0owZnE1QWpjQlRnOHVRR3Z1VEcyWmMyV2xNUXlLeXd5Smd2WEI4eHlRaGVh?=
 =?utf-8?B?aUNNSDZNb2ZKcWpyd2l1UjQvU1lsdmtFTkMxNWVVZkJtNDVMRWZXUkR5Yi9h?=
 =?utf-8?B?cDZJdk1OeWUxWUNMbnpydC9MQ3NXMi9XK0VjTWtrMWxHMHFxSlM1akFQTmhP?=
 =?utf-8?Q?4nmr+EQ/5E2z1UW2YhMimJnePfdKgB33QStQUTh?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 416a3ddd-7fb7-496f-25df-08d98cc38d49
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2021 14:29:36.7537
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8NJEV2wcI3Uwp9uOyxXw7q1vEhqDzpJMAunrOLnLGLOPebsEgTlaoZBWcY3ogMY3MElMdlNZDhLuEOpZB/EXow==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3775

On 24.08.2021 12:50, Anthony PERARD wrote:
> GNU Make will try to rebuild every Makefile included with the
> "include" directive, so everytime Config.mk is used, make will try to
> build ".config". This would normally not be an issue, unless we happen
> to have a rules which match. This is the case with Kconfig in xen/.
> 
> While we had a workaround in "xen/Makefile", this ".config" files
> becomes an issue again in "xen/tools/kconfig/Makefile". It has a
> target "%.config".

"we had" sounds like we don't have such anymore, but I don't think I've
seen it go away. I'm also not convinced working around an isolated issue
in xen/tools/kconfig/Makefile is appropriate to be done by adding stuff
to Rules.mk.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Oct 11 14:46:41 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 14:46:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.206167.361672 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZwZW-000249-T0; Mon, 11 Oct 2021 14:46:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 206167.361672; Mon, 11 Oct 2021 14:46:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZwZW-000242-Q1; Mon, 11 Oct 2021 14:46:34 +0000
Received: by outflank-mailman (input) for mailman id 206167;
 Mon, 11 Oct 2021 14:46:33 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=dU1l=O7=google.com=seanjc@srs-us1.protection.inumbo.net>)
 id 1mZwZV-00023w-17
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 14:46:33 +0000
Received: from mail-pg1-x533.google.com (unknown [2607:f8b0:4864:20::533])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 29561fa5-a2ab-4b62-9457-b3a92549c0a1;
 Mon, 11 Oct 2021 14:46:32 +0000 (UTC)
Received: by mail-pg1-x533.google.com with SMTP id r2so11021463pgl.10
 for <xen-devel@lists.xenproject.org>; Mon, 11 Oct 2021 07:46:32 -0700 (PDT)
Received: from google.com (157.214.185.35.bc.googleusercontent.com.
 [35.185.214.157])
 by smtp.gmail.com with ESMTPSA id x129sm8062008pfc.140.2021.10.11.07.46.30
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Mon, 11 Oct 2021 07:46:30 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 29561fa5-a2ab-4b62-9457-b3a92549c0a1
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=google.com; s=20210112;
        h=date:from:to:cc:subject:message-id:references:mime-version
         :content-disposition:in-reply-to;
        bh=DBJ7ew0y4wvSmKi4WuGSAOH7oUWp7VGZaMnxUGUZnug=;
        b=WUgGM/f+tuPQ7vGNX0cNBBwPv0afu/Zf4dQxhALEj1CWce6SG/QX3MDYljf0Gbuor/
         sj1ONxiUie1VuDLeZqyzP3U8wgCb5jI5/lPjBFHrG3lQw2dxyh3W+h6mZVvyEvJz8G7y
         1nEPJR+H3CxD/4MNWxAGoi6oKI9swc9dOAfsAmuD9ToN3kvenxSiEM2lWlzMHV2o9VoH
         KyJiDN0gZI6nT02ZPzo0daWaK+RTn7Ob4pOSdy5AEMo6f68pgZs/vQbuhgd7TqLjMpzx
         27dHqDzBC8kH05vyX+/CHU4byC6ZoMfjoSir4u7rmWajgW3NJ9i2O+wJZUYyUoDZl7A9
         85aw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:date:from:to:cc:subject:message-id:references
         :mime-version:content-disposition:in-reply-to;
        bh=DBJ7ew0y4wvSmKi4WuGSAOH7oUWp7VGZaMnxUGUZnug=;
        b=oJzSeV4KEeFHm2CO6uSxotEo3JtHugqb5Ok5RP47MtEZazl3P7+9NXkRjBcxVl/Cl+
         VDn+IjJA16baOTpPbjwPO2V/8bS7Gm0fS3Ogp1d7IylbtQc8G5a8+W52ieAR7kU4EZwW
         aMHhnGobAYTKtVCOudNtw7tWxLzaIe+kUuLoSipapGAHY5BhFVDnPbMw2MnlMtNCfO1K
         pmGDKe8kBfaM2iK2Tim1QVbKtz3y7hB9NBJij96JLq0b8esskMx1x4CMgIaWW8GFgLKq
         CtV9/8ieygYZmL9fLks0dcJdrVyjkK4QpBn41wJ+CxCfd7DqFHocMLqYgVk0EMUpCHOT
         k13A==
X-Gm-Message-State: AOAM5328oeD/58zmU0PSeD5QathK2zsv/Gp7Jq8/7Dc8g1hyDNvTiLMd
	1izGqap9Aon+LRrgAl3rTc3dPg==
X-Google-Smtp-Source: ABdhPJy9JeaIFsaMhzjKrm4gRLnqTQlHrSTvgGmlHsrREml2i4T5hhC4ZlLxJitHkoHCOL8HD11SpQ==
X-Received: by 2002:a63:c:: with SMTP id 12mr18698297pga.477.1633963591022;
        Mon, 11 Oct 2021 07:46:31 -0700 (PDT)
Date: Mon, 11 Oct 2021 14:46:25 +0000
From: Sean Christopherson <seanjc@google.com>
To: Marc Zyngier <maz@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@redhat.com>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Will Deacon <will@kernel.org>, Mark Rutland <mark.rutland@arm.com>,
	Guo Ren <guoren@kernel.org>, Nick Hu <nickhu@andestech.com>,
	Greentime Hu <green.hu@gmail.com>,
	Vincent Chen <deanbo422@gmail.com>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
	James Morse <james.morse@arm.com>,
	Alexandru Elisei <alexandru.elisei@arm.com>,
	Suzuki K Poulose <suzuki.poulose@arm.com>,
	Vitaly Kuznetsov <vkuznets@redhat.com>,
	Wanpeng Li <wanpengli@tencent.com>,
	Jim Mattson <jmattson@google.com>, Joerg Roedel <joro@8bytes.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
	kvmarm@lists.cs.columbia.edu, linux-csky@vger.kernel.org,
	linux-riscv@lists.infradead.org, kvm@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	Artem Kashkanov <artem.kashkanov@intel.com>,
	Like Xu <like.xu.linux@gmail.com>,
	Zhu Lingshan <lingshan.zhu@intel.com>
Subject: Re: [PATCH v3 12/16] KVM: Move x86's perf guest info callbacks to
 generic KVM
Message-ID: <YWROQSGPuPf3wfC9@google.com>
References: <20210922000533.713300-1-seanjc@google.com>
 <20210922000533.713300-13-seanjc@google.com>
 <87wnmjq4y3.wl-maz@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87wnmjq4y3.wl-maz@kernel.org>

On Mon, Oct 11, 2021, Marc Zyngier wrote:
> On Wed, 22 Sep 2021 01:05:29 +0100, Sean Christopherson <seanjc@google.com> wrote:
> > diff --git a/arch/arm64/include/asm/kvm_host.h b/arch/arm64/include/asm/kvm_host.h
> > index ed940aec89e0..828b6eaa2c56 100644
> > --- a/arch/arm64/include/asm/kvm_host.h
> > +++ b/arch/arm64/include/asm/kvm_host.h
> > @@ -673,6 +673,14 @@ int io_mem_abort(struct kvm_vcpu *vcpu, phys_addr_t fault_ipa);
> >  void kvm_perf_init(void);
> >  void kvm_perf_teardown(void);
> >  
> > +#ifdef CONFIG_GUEST_PERF_EVENTS
> > +static inline bool kvm_arch_pmi_in_guest(struct kvm_vcpu *vcpu)
> 
> Pardon my x86 ignorance, what is PMI? PMU Interrupt?

Ya, Performance Monitoring Interrupt.  I didn't realize the term wasn't common
perf terminology.  Maybe kvm_arch_perf_events_in_guest() to be less x86-centric?

> > +{
> > +	/* Any callback while a vCPU is loaded is considered to be in guest. */
> > +	return !!vcpu;
> > +}
> > +#endif
> 
> Do you really need this #ifdef?

Nope, should compile fine without it, though simply dropping the #ifdef would make
make the semantics of the function wrong, even if nothing consumes it.  Tweak it
to use IS_ENABLED()?

	return IS_ENABLED(CONFIG_GUEST_PERF_EVENTS) && !!vcpu;


From xen-devel-bounces@lists.xenproject.org Mon Oct 11 14:53:22 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 14:53:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.206178.361684 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZwft-0003U0-Kc; Mon, 11 Oct 2021 14:53:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 206178.361684; Mon, 11 Oct 2021 14:53:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZwft-0003Tt-GT; Mon, 11 Oct 2021 14:53:09 +0000
Received: by outflank-mailman (input) for mailman id 206178;
 Mon, 11 Oct 2021 14:53:08 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=LfEM=O7=arm.com=Bertrand.Marquis@srs-us1.protection.inumbo.net>)
 id 1mZwfs-0003Tn-2P
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 14:53:08 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com (unknown
 [2a01:111:f400:fe0e::628])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 95d248dd-650a-4448-8fd3-1d7e6c480a12;
 Mon, 11 Oct 2021 14:53:06 +0000 (UTC)
Received: from DB6P18901CA0006.EURP189.PROD.OUTLOOK.COM (2603:10a6:4:16::16)
 by VI1PR08MB2655.eurprd08.prod.outlook.com (2603:10a6:802:19::17) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.19; Mon, 11 Oct
 2021 14:53:01 +0000
Received: from DB5EUR03FT020.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:4:16:cafe::b6) by DB6P18901CA0006.outlook.office365.com
 (2603:10a6:4:16::16) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.24 via Frontend
 Transport; Mon, 11 Oct 2021 14:53:01 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT020.mail.protection.outlook.com (10.152.20.134) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4587.18 via Frontend Transport; Mon, 11 Oct 2021 14:53:01 +0000
Received: ("Tessian outbound d5def7722ff7:v103");
 Mon, 11 Oct 2021 14:53:01 +0000
Received: from 7af65fd9def0.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 F34DA820-13D1-4DE6-A588-385B035A1005.1; 
 Mon, 11 Oct 2021 14:52:54 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 7af65fd9def0.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Mon, 11 Oct 2021 14:52:54 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com (2603:10a6:4:74::9)
 by DB9PR08MB6619.eurprd08.prod.outlook.com (2603:10a6:10:257::21) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.22; Mon, 11 Oct
 2021 14:52:43 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955]) by DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955%4]) with mapi id 15.20.4587.026; Mon, 11 Oct 2021
 14:52:43 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 95d248dd-650a-4448-8fd3-1d7e6c480a12
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Y74SquOHz/DWzW2xWtEThLFaMhM1aL7AMX89BqsoXA8=;
 b=o3/iyHWaI+zbSU4fyeOy5nAD0mzDHim8J71CZHtc5iCcOTrlwqhCFzTWejem/gB/5zw0qr7Mj08lPS/jaGKXWzW1lTFHCmBT569tNDP+ECvItJqM/+ZrvTnay0IEPzApMpsFKZTU04FQnKgPZabopbbnmtaPGe+dljIUQPkLsB4=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: dfeb16296a440d2f
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=nFxBTpx5bFVqnwnGVBOJC7vnWvIuMQW63OhZSWHf2SerISb5eX5U66x8jNjNTObVSlEr1pKcNPzV1ZpPns5TSew7zqLhFP9vCzXxsc07WKQLH9TsE9ru2AMyVTYFtgChtpptC8B0gE84GIaTRFPvUxElWYrYbDdWpH94ESHbpy3vS8PjeK/bueQOtCdioNC/dClPRyptK25DlCATXfwkcgWocuWvhrsTQQjMcWY+z34y5mpF3A4F5iz5/pTWKCnVjCeDhrAIwNKBqhQ6f1w/gvbGbDmSSBMrl6tDePrhq2STeOrrkxZPc9ghqPStTlV07/g27i07zpABpMSJqYaD7Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Y74SquOHz/DWzW2xWtEThLFaMhM1aL7AMX89BqsoXA8=;
 b=QgbeZ2xiZlpNGH+VQ+kUALvZU46WnPPO9CXnhxea/40pcSW6O/aoBAu9muObj8V4RV1neoQN8ez8r/K75T5DUzUgf476SLsPABCQbCJ9hW57RNrKlmz+scMfJ6VlP1zyjOpJ++3yhKdm3PuexeVzU1R/TXoeLzCSqFI5MWsxzsFpH39Hhkm0CcrSzgKCVzG8bA85o5PqTygetGawlPBMWr611Wix6UbiKi5pZDjDESlp8XLHGR9OQMhnBvTLBLAHEXTP1p8gW+OgfrDNXPMyXGQHxhhUfr4E7qoMiKrAA1IyyqYgaYCMXz3mHRq3eDa/KmwMWbtF/1C06iOLUJMh3A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Y74SquOHz/DWzW2xWtEThLFaMhM1aL7AMX89BqsoXA8=;
 b=o3/iyHWaI+zbSU4fyeOy5nAD0mzDHim8J71CZHtc5iCcOTrlwqhCFzTWejem/gB/5zw0qr7Mj08lPS/jaGKXWzW1lTFHCmBT569tNDP+ECvItJqM/+ZrvTnay0IEPzApMpsFKZTU04FQnKgPZabopbbnmtaPGe+dljIUQPkLsB4=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Rahul Singh <Rahul.Singh@arm.com>, Andre Przywara
	<Andre.Przywara@arm.com>, Stefano Stabellini <sstabellini@kernel.org>, Julien
 Grall <julien@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>, George Dunlap
	<george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>, Wei Liu
	<wl@xen.org>, Paul Durrant <paul@xen.org>, =?iso-8859-1?Q?Roger_Pau_Monn=E9?=
	<roger.pau@citrix.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v5 08/11] xen/arm: Enable the existing x86 virtual PCI
 support for ARM.
Thread-Topic: [PATCH v5 08/11] xen/arm: Enable the existing x86 virtual PCI
 support for ARM.
Thread-Index:
 AQHXutl3YqS5dHXsYk6KpdKt4d14RavHjPqAgAY38oCAAAe6AIAAByIAgAAKAoCAAAvMAA==
Date: Mon, 11 Oct 2021 14:52:43 +0000
Message-ID: <CC5D73DE-74EB-476A-965E-4467A0010439@arm.com>
References: <cover.1633540842.git.rahul.singh@arm.com>
 <9bdca2cda5d2e83f94dc2423e55714273539760a.1633540842.git.rahul.singh@arm.com>
 <6752f2d3-171b-37f5-c809-82995a8f3f36@suse.com>
 <CEF7FFB0-779A-4F46-8667-6BCD9BA5CB6C@arm.com>
 <b735c2d3-1dbb-ce0a-c2fa-160d4c6938d3@suse.com>
 <A8DEBD07-FB45-4E4E-A2C3-7AF8B393B032@arm.com>
 <59c9e102-c710-64d3-2a1a-cc8dcbcceead@suse.com>
In-Reply-To: <59c9e102-c710-64d3-2a1a-cc8dcbcceead@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3654.120.0.1.13)
Authentication-Results-Original: suse.com; dkim=none (message not signed)
 header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: b7e1d204-5a9a-489a-b715-08d98cc6d2b7
x-ms-traffictypediagnostic: DB9PR08MB6619:|VI1PR08MB2655:
x-ms-exchange-transport-forked: True
X-Microsoft-Antispam-PRVS:
	<VI1PR08MB2655254FA3B29D4113F0F7E09DB59@VI1PR08MB2655.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:10000;OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 OnTvuWZMxJGUdH3FiOV7b0NKFp+c2gCCoW0bOoQKVBQgsoW6Xq4DjChBcxtjEMPN41D/sejjDMAtHM8DzWPctCHlJPO7I9EPcjc/x1qqOwy6pDv6UNuJyUe0nvYpbKKEXnptJ7EppjOvjrntRj/Pg779XP8TMuftWdWdbWTLpzgf86f+05yMd4MX8fxCsNh6cO1+K0z3zcuwLS+yemerdJX2vj4AnzP/Hz3Ur4yvI5A2J9BDdDIdQeA1NdTQPg2o+jWn+ZC3fIDNb8R2nGFNmN+oRIpxSkPXLtGTX70iD9yrViBrN3jSHog9WefqnH/PMheDxxEXXcuTAAZmDRjct8CWnLKAyUDGnHy/m+UqrfCeu2pynGq/PkmrY8Xd7v3p05Pe9ZmVm0jFBYNLmb6FkRKigehs9rSRTKsER4tMIlgsKgrAampjjWOBdU0OJJ4AIRiptWRABBOtZoEBJuSLo04YQ9sTcyvkRhzjjWL6sBhr2csgNeXikezveyeOIMeS17cbVnIiJJA3XPbDmqWBTKiOCH72QILHwiBgAWZuXnjiZ7LyJOOIEg3EZbwULPNDnvvM746bizaHRgBYo1w3i4Eluxc3uY7Dud0rjgOszNKi+/CMIekPipYXDKoO/r4xKL0ARLqYpGrqt98ndqC0lVyaTwl7S0KsIN2FsEAHCFONRwYy1zC0lh+R7oc7Ml27vTgrGTtiPZWjmIKxjW4+mP3XbDtH+VCIDDMQYZFWD47v+YvKL5lkUIUhuayTcLH40zFlRY3ytMy/hX+FLTqeAA==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB6PR0801MB2024.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(6512007)(6506007)(8676002)(316002)(4326008)(53546011)(66556008)(26005)(83380400001)(36756003)(54906003)(6916009)(66476007)(8936002)(7416002)(38100700002)(186003)(122000001)(508600001)(5660300002)(6486002)(2616005)(2906002)(66446008)(33656002)(38070700005)(66946007)(64756008)(76116006)(71200400001)(91956017)(86362001)(2004002)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="iso-8859-1"
Content-ID: <E4070945BFD28448B4D481C62C31F0FC@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB6619
Original-Authentication-Results: suse.com; dkim=none (message not signed)
 header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT020.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	b0c81747-f01f-49ab-935e-08d98cc6c7b8
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	t7LhZ7nyesssSfqAibWx5mGemwa294bqLVuEjubl/+9U1YCeu8zSxdT70YXeuzqZ1U1JxS6b4KBNYO+hYudX9Z756gRvj9HhtY81QbRfrlyxK1IMuL2VlLz3pbyg3n4z9OKPAd1BY8XsCfPuOTe34dgaH2Il1QG846mDbpYUYugnR/0BJuxedpTDpkJdP6P8o9kX1YwTb7VSQ1o7e+SclbKmK0gpArJTxRXId+bVAKWZXI6GlFyWsD5js49UAI6SJQRxI8TWGVO8TqyHVmimU5HFJG73Zpix5WrZD6nGXZxgku6fCFmptMnIDZskIcs/25td6pvXvz1i8Jxwd+mepHOxHSdP67ytsQdn6dC5vHq3IUzcNasF7aer1vJxZtisVw9KvMKlcCB3t9/i34GP9oCVX+v/zIQu8NADlda8zh9712SbyAukm1HtTntsOz4zw2reMV6rQ6+iKBKguxK9KbwJF8tVoFBlp4EkzU8Ymv+N2kxNgB17oeZ/jrN99EW1QB1LzicfcYWwxTD4IvDHfBQV/JgUyikJjrDRBdOZXUhJhGlbzvPAz6U8VNwWuUa9etUTJoy3op2K3rlsu7sEU5wSg4iuxl0LhiHJBTufozViXvAkb7NJHoTjD7a4OktaXrgUH06q3s7sKpa1btk8un/NwkNriIP2UjxXrJ0K53vS2pK8hlJq00+MgPPY6Hv55l8G4i4QJwYv7yCuPTpkUvePpnepuFLj6Oi374iLRlI=
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(82310400003)(2906002)(26005)(8676002)(54906003)(47076005)(316002)(186003)(5660300002)(33656002)(356005)(6486002)(6862004)(6512007)(86362001)(36756003)(8936002)(4326008)(81166007)(83380400001)(36860700001)(70586007)(70206006)(6506007)(336012)(508600001)(2616005)(53546011)(2004002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2021 14:53:01.6164
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: b7e1d204-5a9a-489a-b715-08d98cc6d2b7
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT020.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB2655

Hi Jan,

> On 11 Oct 2021, at 15:10, Jan Beulich <jbeulich@suse.com> wrote:
>=20
> On 11.10.2021 15:34, Bertrand Marquis wrote:
>>> On 11 Oct 2021, at 14:09, Jan Beulich <jbeulich@suse.com> wrote:
>>> On 11.10.2021 14:41, Bertrand Marquis wrote:
>>>>> On 7 Oct 2021, at 14:43, Jan Beulich <jbeulich@suse.com> wrote:
>>>>> On 06.10.2021 19:40, Rahul Singh wrote:
>>>>>> --- /dev/null
>>>>>> +++ b/xen/arch/arm/vpci.c
>>>>>> @@ -0,0 +1,102 @@
>>>>>> +/*
>>>>>> + * xen/arch/arm/vpci.c
>>>>>> + *
>>>>>> + * This program is free software; you can redistribute it and/or mo=
dify
>>>>>> + * it under the terms of the GNU General Public License as publishe=
d by
>>>>>> + * the Free Software Foundation; either version 2 of the License, o=
r
>>>>>> + * (at your option) any later version.
>>>>>> + *
>>>>>> + * This program is distributed in the hope that it will be useful,
>>>>>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
>>>>>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>>>>>> + * GNU General Public License for more details.
>>>>>> + */
>>>>>> +#include <xen/sched.h>
>>>>>> +
>>>>>> +#include <asm/mmio.h>
>>>>>> +
>>>>>> +#define REGISTER_OFFSET(addr)  ( (addr) & 0x00000fff)
>>>>>=20
>>>>> Nit: Stray blank (like you had in an earlier version for MMCFG_BDF())=
.
>>>>> Also isn't this effectively part of the public interface (along with
>>>>> MMCFG_BDF()), alongside GUEST_VPCI_ECAM_{BASE,SIZE}?
>>>>=20
>>>> I will move that in the next version to xen/pci.h and rename itMMCFG_R=
EG_OFFSET.
>>>> Would that be ok ?
>>>=20
>>> That would be okay and make sense when put next to MMCFG_BDF(), but
>>> it would not address my comment: That still wouldn't be the public
>>> interface. Otoh you only mimic hardware behavior, so perhaps the
>>> splitting of the address isn't as relevant to put there as would be
>>> GUEST_VPCI_ECAM_{BASE,SIZE}.
>>=20
>> Ok now I get what you wanted.
>>=20
>> You would actually like both MMCFG_BDF and MMCFG_REG_OFFSET to
>> be moved to arch-arm.h.
>>=20
>> Then I am not quite sure to follow why.
>> Those are not macros coming out of a way we have to define this but from
>> how it works in standard PCI.
>> The base and size are needed to know where the PCI bus will be.
>>=20
>> So why should those be needed in public headers ?
>=20
> Well, see my "Otoh ..." in the earlier reply. Keeping the two
> address splitting macros out of there is okay.

Ok.

>=20
>>>>>> --- a/xen/drivers/passthrough/pci.c
>>>>>> +++ b/xen/drivers/passthrough/pci.c
>>>>>> @@ -766,6 +766,24 @@ int pci_add_device(u16 seg, u8 bus, u8 devfn,
>>>>>>   else
>>>>>>       iommu_enable_device(pdev);
>>>>>=20
>>>>> Please note the context above; ...
>>>>>=20
>>>>>> +#ifdef CONFIG_ARM
>>>>>> +    /*
>>>>>> +     * On ARM PCI devices discovery will be done by Dom0. Add vpci =
handler when
>>>>>> +     * Dom0 inform XEN to add the PCI devices in XEN.
>>>>>> +     */
>>>>>> +    ret =3D vpci_add_handlers(pdev);
>>>>>> +    if ( ret )
>>>>>> +    {
>>>>>> +        printk(XENLOG_ERR "setup of vPCI failed: %d\n", ret);
>>>>>> +        pci_cleanup_msi(pdev);
>>>>>> +        ret =3D iommu_remove_device(pdev);
>>>>>> +        if ( pdev->domain )
>>>>>> +            list_del(&pdev->domain_list);
>>>>>> +        free_pdev(pseg, pdev);
>>>>>=20
>>>>> ... you unconditionally undo the if() part of the earlier conditional=
;
>>>>> is there any guarantee that the other path can't ever be taken, now
>>>>> and forever? If it can't be taken now (which I think is the case as
>>>>> long as Dom0 wouldn't report the same device twice), then at least so=
me
>>>>> precaution wants taking. Maybe moving your addition into that if()
>>>>> could be an option.
>>>>>=20
>>>>> Furthermore I continue to wonder whether this ordering is indeed
>>>>> preferable over doing software setup before hardware arrangements. Th=
is
>>>>> would address the above issue as well as long as vpci_add_handlers() =
is
>>>>> idempotent. And it would likely simplify error cleanup.
>>>>=20
>>>> I agree with you so I will move this code block before iommu part.
>>>>=20
>>>> But digging deeper into this, I would have 2 questions:
>>>>=20
>>>> - msi_cleanup was done there after a request from Stefano, but is not
>>>> done in case or iommu error, is there an issue to solve here ?
>>>=20
>>> Maybe, but I'm not sure. This very much depends on what a domain
>>> could in principle do with a partly set-up device. Plus let's
>>> not forget that we're talking of only Dom0 here (for now at least,
>>> i.e. not considering the dom0less case).
>>>=20
>>> But I'd also like to further defer to Stefano.
>>=20
>> Ok, I must admit I do not really see at that stage why doing an MSI clea=
nup
>> could be needed so I will wait for Stefano to know if I need to keep thi=
s when
>> moving the block up (at the end it is theoretical right now as this is e=
mpty).
>>=20
>>>=20
>>>> Same could also go for the free_pdev ?
>>>=20
>>> I think it's wrong to free_pdev() here. We want to internally keep
>>> record of the device, even if the device ends up unusable. The only
>>> place where free_pdev() ought to be called is imo pci_remove_device().
>>=20
>> Ok.
>>=20
>>>=20
>>>> - cleanup code was exactly the same as pci_remove_device code.
>>>> Should the question about the path also be checked there ?
>>>=20
>>> I'm sorry, but I'm afraid I don't see what "the path" refers to
>>> here. You can't mean the conditional in pci_add_device() selecting
>>> between iommu_add_device() and iommu_enable_device(), as "remove"
>>> can only mean "remove", never "disable".
>>=20
>> I will try to explain: when we just enable we do not add an entry in the=
 list but
>> we still remove an entry from the list every time (as the condition beco=
mes
>> always true because pdev->domain is at the end always set)
>=20
> Well, that anomaly is what I did point out in my review remarks to
> Rahul. We shouldn't remove an entry from the list if we didn't add
> one. But quite likely, if we don't free the pdev, we shouldn't be
> removing the list entry in either case.

This problem will not exist anymore when I will move the code up but I will=
 add to adapt the error case in iommu to also remove the vpci handlers.
To be coherent I will do the same in the pci_remove_device code.

I will do all those in the v6 of the serie.

Thanks a lot for the answers.

Cheers
Bertrand

>=20
> Jan
>=20



From xen-devel-bounces@lists.xenproject.org Mon Oct 11 14:57:24 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 14:57:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.206187.361694 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZwjy-00048Z-4P; Mon, 11 Oct 2021 14:57:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 206187.361694; Mon, 11 Oct 2021 14:57:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZwjy-00048S-1X; Mon, 11 Oct 2021 14:57:22 +0000
Received: by outflank-mailman (input) for mailman id 206187;
 Mon, 11 Oct 2021 14:57:20 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mZwjw-00048G-GZ; Mon, 11 Oct 2021 14:57:20 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mZwjw-0007dz-7r; Mon, 11 Oct 2021 14:57:20 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mZwjv-0003TC-Ur; Mon, 11 Oct 2021 14:57:20 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mZwjv-0001BE-UM; Mon, 11 Oct 2021 14:57:19 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=O+m9IW6E1EOI+1eTBMuXqb5vZwxjmnymY2amVYL7qWo=; b=g+YlSPKLypqHTZK0q6jlMEjL2j
	BH4hbwq7TLyWLqhwOLcOO+LGH1lVCf1YNpG83iWz3UPlB0oJ74okDwHR1s+jBeaIwUnnZt+tEfr3i
	HZDfAVRnpFj7Ulu1DwyJWil/0DwRBYWJKanC4p6XbyFj0+5JWejpso4srs0mmmZ80SNU=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165460-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 165460: tolerable FAIL
X-Osstest-Failures:
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=664cc3c3d381e4f9a61dcb68cbd7a6a00070370e
X-Osstest-Versions-That:
    xen=664cc3c3d381e4f9a61dcb68cbd7a6a00070370e
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 11 Oct 2021 14:57:19 +0000

flight 165460 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165460/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 165452
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 165452
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165452
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165452
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 165452
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 165452
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 165452
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 165452
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 165452
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 165452
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165452
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 165452
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  664cc3c3d381e4f9a61dcb68cbd7a6a00070370e
baseline version:
 xen                  664cc3c3d381e4f9a61dcb68cbd7a6a00070370e

Last test of basis   165460  2021-10-11 01:52:59 Z    0 days
Testing same since                          (not found)         0 attempts

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Published tested tree is already up to date.



From xen-devel-bounces@lists.xenproject.org Mon Oct 11 14:58:56 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 14:58:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.206199.361708 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZwlQ-0004ps-Mz; Mon, 11 Oct 2021 14:58:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 206199.361708; Mon, 11 Oct 2021 14:58:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZwlQ-0004pl-Jz; Mon, 11 Oct 2021 14:58:52 +0000
Received: by outflank-mailman (input) for mailman id 206199;
 Mon, 11 Oct 2021 14:58:51 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=rMo6=O7=citrix.com=anthony.perard@srs-us1.protection.inumbo.net>)
 id 1mZwlO-0004ox-Tz
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 14:58:50 +0000
Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id bafec8bc-2aa3-11ec-80e1-12813bfff9fa;
 Mon, 11 Oct 2021 14:58:45 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: bafec8bc-2aa3-11ec-80e1-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1633964325;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=MQollfNzTTSHdcKy/jw699VDAbqrV85VhXA402BExX0=;
  b=b5XMA1cML8cDVAxVBZuzk451KryDQmOhqvYhV4kMAJzPNzIsORQci4Dy
   Qnwh1bX4mz1jKb7q2H/OTk28RSLOEcnU6sVew50PuhkrOPy0DBYiJDrP1
   Jh51++bBG83PzN+9mmMvAjvWIFidWPADWhzDfpxNHZaM+cgDx3zDtoxPC
   g=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: BJF62UZ8z41FPvb2N6f7A4uE33cHvcWhBmKJumoZUPek5AeWO65thEP1U7gWJp4mtAOc3iSZRI
 9/H0nOgRbvP8+7xU8wbxx/doYFEA4vcsc9TYDy4aomCNtqtZvMSoJSi8MKUNBQH4Mi3P7ZfLay
 SNTcceYFgkdd5hOQNszx5AKgIPNb2/xNtTHGLO8UHKp35NtMSUOl+wTdfe8JlB16qawUCG3hVX
 N65AeYOnKfnWVbKBnqHUC8XjoEkOFQn/g4wM8II1/JtWwbeSfWt+5DZh07x/qsNDH5vJsz8WWT
 oRfG1bxD4xXN5+oU73JS2HIU
X-SBRS: 5.1
X-MesageID: 54464306
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:paXQo6Dm8qXqoRVW/6Tkw5YqxClBgxIJ4kV8jS/XYbTApDhw0DxRn
 TROXjqEMv6NZGHzfopwbN/lpEoOsMODz4VgQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA
 xA2M4GYRCwMo/u1Si6FatANl1ElvU2zbue6WLOs1hxZH1c+EX550Es7wobVv6Yz6TSHK1LV0
 T/Ni5W31G+Ng1aY5UpNtspvADs21BjDkGtwUm4WPJinj3eH/5UhN7oNJLnZEpfNatI88thW5
 Qr05OrREmvxp3/BAz4++1rxWhVirrX6ZWBihpfKMkQLb9crSiEai84G2PQghUh/rx+igYkuk
 Pdxu4WCZl50N5+RurVETEwNe81+FfUuFL7vJHG+tYqYzlHccmuqyPJrZK00FdRGoKAtWzgIr
 KFGbmBWBvyAr7veLLaTQ+9whsMlPY/zMZkWoH1IxjDFF/c2B5vERs0m4PcFgGtu2psWQ54yY
 eI8dhlTfgjwICdNZHMIOrcGnKShpnfGJmgwRFW9+vNsvjm7IBZK+KP2LNPfd9iORMNUtkWVv
 GTL+yL+GB5yHMOb4SqI9DSrnOCntTP2XsceGaO18tZugUaP3SoDBRsOT1y5rPKlzEmkVLp3K
 UYZ5y4vpqga71GwQ5/2WBjQiH+bvDYMVtxICeo45QqRjK3O7G6xBHUATzNHQMwrsokxXzNC6
 7OSt4q3X3o16uTTEC/DsOfPxd+vBcQLBUsoTjFdElMn39f6kq5q0xv9E/QySbHg27UZBgrM6
 zyNqSE/gZAagsgKy7i38Dj7vt68mnTaZlVqvluPDwpJ+is8PdT/P9X5tjA3+N4ZdN7BJmRtq
 kTojCR3AAomNpqKiDCWCNsEGLWk9p5p2xWN3AYxQfHNG9mrkkNPnLy8AhkidC+F0e5eIFcFh
 XM/XysLufe/21PwPMdKj3qZUZhC8EQZPY2NugroRtRPeINtUwSM4TtjY0Wdt0i0zhN3wfBnZ
 s7CLZj3ZZr/NUiB5GHsLwv6+eV6rh3SOEuJHcyrp/hZ+ev2iIGppUctbwLVM7FRAFKsqwTJ6
 ddPX/ZmOD0EONASlhL/qNZJRXhTdCBTLcmv96R/K77SSiI7STpJI6KAntscl3lNwv09ehHgp
 SrmBCe1CTPX2BX6FOl9Qik7Mu2wBswj8StT0O5FFQ/A5kXPqL2HtM83H6bbt5F5nAC65fIrH
 fQDZeuaBfFDFmbO9zgHNMGvp41+bhW7wwmJOnP9MjQ4epdhQS3P+8PlIVSzpHVfUHLvuJtsu
 aCk2yPaXYEHG1ZoAvHJZa/91Fi2p3Ucxr5/BhOaPtlJdUzw24F2MCit3OQvKsQBJEyblDuX3
 gqbGzkCouzJr9Nn+dXFn/nc/YyoD/F/DgxRGGyCteS6MizT/2yCx45cUbnXIWCBBT2soKj7P
 Ldb1fDxNvEDjW1miYskHuY517866vvuu6ReklZuEkLUYgn5EbhnOHSHg5VC7/Uf2r9DtAKqc
 UuT4d0Ga66RMcboHVNNdgooauOPiaMdljXItKlnJUz74Gl8/aadUFUUNB6J0XQPILxwOYIj4
 OEgpM9JtFDv1kt0ao6L3nJO6mCBDn0cSKF25JgVDbjihhcv1lwfM4fXDTX74c3XZthBWqXwz
 uR4WEYWa2xg+3f/
IronPort-HdrOrdr: A9a23:uxhUQapppvRN3JUWWOwTFzEaV5oveYIsimQD101hICG9Ffbo8P
 xG/c5rsSMc7Qx7ZJhOo7y90cW7Lk80lqQU3WByB9mftWDd0QPDQb2KhrGC/xTQXwH46+5Bxe
 NBXsFFebjN5IFB/KXHCd+DYrQd/OU=
X-IronPort-AV: E=Sophos;i="5.85,364,1624334400"; 
   d="scan'208";a="54464306"
Date: Mon, 11 Oct 2021 15:58:31 +0100
From: Anthony PERARD <anthony.perard@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, George Dunlap
	<george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>, Julien Grall
	<julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>, Wei Liu
	<wl@xen.org>, <xen-devel@lists.xenproject.org>
Subject: Re: [XEN PATCH v7 20/51] build: avoid re-executing the main Makefile
 by introducing build.mk
Message-ID: <YWRRFxlvmDMu8nRZ@perard>
References: <20210824105038.1257926-1-anthony.perard@citrix.com>
 <20210824105038.1257926-21-anthony.perard@citrix.com>
 <87036d63-b5d4-55bf-0bb3-9b981a147f15@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <87036d63-b5d4-55bf-0bb3-9b981a147f15@suse.com>

On Mon, Oct 11, 2021 at 12:56:54PM +0200, Jan Beulich wrote:
> On 24.08.2021 12:50, Anthony PERARD wrote:
> > Currently, the xen/Makefile is re-parsed several times: once to start
> > the build process, and several more time with Rules.mk including it.
> > This makes it difficult to reason with a Makefile used for several
> > purpose, and it actually slow down the build process.
> 
> I'm struggling some with what you want to express here. What does
> "to reason" refer to?

I guess "to reason with something" isn't an expression. I mean that the
main Makefile is difficult to work with as it setup the build process
for the rest of the build. And it is difficult to understand what is
happening when it recursed into itself, and thus possibly re-executing
part of the build process setup.

> > So this patch introduce "build.mk" which Rules.mk will use when
> > present instead of the "Makefile" of a directory. (Linux's Kbuild
> > named that file "Kbuild".)
> > 
> > We have a few targets to move to "build.mk" identified by them been
> > build via "make -f Rules.mk" without changing directory.
> > 
> > As for the main targets like "build", we can have them depends on
> > there underscore-prefix targets like "_build" without having to use
> > "Rules.mk" while still retaining the check for unsupported
> > architecture. (Those main rules are changed to be single-colon as
> > there should only be a single recipe for them.)
> > 
> > With nearly everything needed to move to "build.mk" moved, there is a
> > single dependency left from "Rules.mk": $(TARGET), which is moved to
> > the main Makefile.
> 
> I'm having trouble identifying what this describes. Searching for
> $(TARGET) in the patch doesn't yield any obvious match. Thinking
> about it, do you perhaps mean the setting of that variable? Is
> moving that guaranteed to not leave the variable undefined? Or in
> other words is there no scenario at all where xen/Makefile might
> get bypassed? (Aiui building an individual .o, .i, or .s would
> continue to be fine, but it feels like something along these lines
> might get broken.)

I mean that "xen/Rules.mk" will never "include" "xen/Makefile" after
this patch, but the variable "TARGET" is only set in "xen/Rules.mk". But
"xen/Makefile" still needs "TARGET" to be set so I moved the assignment
of the variable from "xen/Rules.mk" into "xen/Makefile".

> > @@ -279,11 +281,13 @@ export CFLAGS_UBSAN
> >  
> >  endif # need-config
> >  
> > -.PHONY: build install uninstall clean distclean MAP
> > -build install uninstall debug clean distclean MAP::
> > +main-targets := build install uninstall clean distclean MAP
> > +.PHONY: $(main-targets)
> >  ifneq ($(XEN_TARGET_ARCH),x86_32)
> > -	$(MAKE) -f Rules.mk _$@
> > +$(main-targets): %: _%
> > +	@:
> 
> Isn't the conventional way to express "no commands" via
> 
> $(main-targets): %: _% ;
> 
> ?

I guess, I'll change it.

> > --- a/xen/Rules.mk
> > +++ b/xen/Rules.mk
> > @@ -9,8 +9,6 @@ include $(XEN_ROOT)/Config.mk
> >  include $(BASEDIR)/scripts/Kbuild.include
> >  
> >  
> > -TARGET := $(BASEDIR)/xen
> > -
> >  # Note that link order matters!
> 
> Could I talk you into removing yet another blank line at this occasion?

Will do.

> > @@ -36,7 +34,9 @@ SPECIAL_DATA_SECTIONS := rodata $(foreach a,1 2 4 8 16, \
> >                                              rodata.cst$(a)) \
> >                           $(foreach r,rel rel.ro,data.$(r).local)
> >  
> > -include Makefile
> > +# The filename build.mk has precedence over Makefile
> > +mk-dir := .
> 
> What's the goal of this variable? All I can spot for now it that ...

It's just me thinking ahead where a folling patch will just have to
write "$mk-dir := $(src)", instead of editing the following line.

> > +include $(if $(wildcard $(mk-dir)/build.mk),$(mk-dir)/build.mk,$(mk-dir)/Makefile)
> 
> ... this is harder to read than
> 
> include $(if $(wildcard ./build.mk),./build.mk,./Makefile)
> 
> which could be further simplified to
> 
> include $(if $(wildcard build.mk),build.mk,Makefile)
> 
> and then maybe altered to
> 
> include $(firstword $(wildcard build.mk) Makefile)

I can try with this last one, there is less repeating of "build.mk" so
that sound like a good thing to do.

> > --- /dev/null
> > +++ b/xen/build.mk
> > @@ -0,0 +1,58 @@
> > +quiet_cmd_banner = BANNER  $@
> > +define cmd_banner
> > +    if which figlet >/dev/null 2>&1 ; then \
> > +	echo " Xen $(XEN_FULLVERSION)" | figlet -f $< > $@.tmp; \
> > +    else \
> > +	echo " Xen $(XEN_FULLVERSION)" > $@.tmp; \
> > +    fi; \
> > +    mv -f $@.tmp $@
> > +endef
> > +
> > +.banner: tools/xen.flf FORCE
> > +	$(call if_changed,banner)
> > +targets += .banner
> 
> To make the end of the rule more easily recognizable, may I ask that
> you either insert a blank line after the rule or that you move the +=
> up immediately ahead of the construct?

Will do.

Thanks,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Mon Oct 11 15:31:22 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 15:31:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.206214.361720 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZxGl-0000Ro-8P; Mon, 11 Oct 2021 15:31:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 206214.361720; Mon, 11 Oct 2021 15:31:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZxGl-0000Rh-4t; Mon, 11 Oct 2021 15:31:15 +0000
Received: by outflank-mailman (input) for mailman id 206214;
 Mon, 11 Oct 2021 15:31:14 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=9TNE=O7=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mZxGk-0000Rb-A3
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 15:31:14 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 8bb5d66f-ea60-458f-b9e9-09d1a96bc2fa;
 Mon, 11 Oct 2021 15:31:13 +0000 (UTC)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2176.outbound.protection.outlook.com [104.47.17.176])
 (Using TLS) by relay.mimecast.com with ESMTP id
 de-mta-15-hjt-Cs9kPqCEHB5w-X5dDw-1; Mon, 11 Oct 2021 17:31:11 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB7150.eurprd04.prod.outlook.com (2603:10a6:800:12a::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.19; Mon, 11 Oct
 2021 15:31:10 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4587.026; Mon, 11 Oct 2021
 15:31:10 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS9PR06CA0010.eurprd06.prod.outlook.com (2603:10a6:20b:462::33) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18 via Frontend
 Transport; Mon, 11 Oct 2021 15:31:09 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8bb5d66f-ea60-458f-b9e9-09d1a96bc2fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1633966272;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=oaRNu7+69PTiO7gE10xosCtXQezRnKHdumziS0PclSA=;
	b=D139grD987Fkz81mCYtmMT8GsyYOzMJuDfmUiJjONdp+pvttXMmJw72JUSacCy35YDK3yo
	F9fNn029BtKjcS9gNRrUZ6wC5F5hKmPj185WhP8eoskQhipw6ynIb4RMzpxgkQNtO31+3f
	sqM3qpu56cnT6skvzOlC/GDnyvIDnZI=
X-MC-Unique: hjt-Cs9kPqCEHB5w-X5dDw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=NW/CJyHKlgH8VLii/eFgweSdxXx1Qcb+qwS7pWh6d8AMsVXB373XX6zSpZmbWzNvPqJAkzBiBhtrTcGB7IAu1QgSNZI1Fo0eHtEA/mdxlUsXks7g8RXUAWuYfEhsSPXs3XGKi42CbwxZDHw6gz4OAn5IcIUY0HenHPCcm4UHthURxefSKf/6ZyOqTkTW/UpmxkgF/Ifk8YQ68YnvqFST7B/y1u2yhBInrpXL7o2HTCJ2OEQeddG/gfGHsSdzBUZnsAVGMFBewtIw+TLe4FXALh7ZQIat368zlytv3L5omwHsoN8vbPQvnavnK+BHDYA+I9NE55RUQDuIWu28C+9grA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=oaRNu7+69PTiO7gE10xosCtXQezRnKHdumziS0PclSA=;
 b=QZdMjC5s3ZLZEIi1oJ+WGEzyVqoGNnO8UiM3LScfRAodLsLlgSPrv0cvUmUsmLiTdkoG6FzazqxzOBjIDiY6MYBGtTxcU2ArZLVYMjQetRdwDJ99iGLCt35FmlstI3tTfRd2FSsi0DpMlrHPNs69ystT3n9YmGyYS3W6HeDdpXYMI3/w0rWgHClIzdeYWVmhR9+NexAZFMd3WmFLWi9FVAm0MiPOsLWfdDj5t9lqh6FvvAjQAvVyI49zaxwyGxdIrHaJPOztOG/E4F31L+IqkE3KAoRlRZH1tKgd0e5sKaHSfqHqYr64qKFv1V5IoQsg224Pi84/4nH3NF4pfgabuA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [XEN PATCH v7 20/51] build: avoid re-executing the main Makefile
 by introducing build.mk
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>, xen-devel@lists.xenproject.org
References: <20210824105038.1257926-1-anthony.perard@citrix.com>
 <20210824105038.1257926-21-anthony.perard@citrix.com>
 <87036d63-b5d4-55bf-0bb3-9b981a147f15@suse.com> <YWRRFxlvmDMu8nRZ@perard>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <b30bff47-226c-6f82-5f59-81d17b191ab4@suse.com>
Date: Mon, 11 Oct 2021 17:31:08 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <YWRRFxlvmDMu8nRZ@perard>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0010.eurprd06.prod.outlook.com
 (2603:10a6:20b:462::33) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: faa08ebe-1618-4034-647a-08d98ccc26d1
X-MS-TrafficTypeDiagnostic: VI1PR04MB7150:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB7150637AAC08D8DECB7187A6B3B59@VI1PR04MB7150.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	x9sxCo8wGC+/fUxGPwV/RhqzghsXUSk3puUXuHtfD/D9OUSQMvhCKGs6hz1zUh13O/o3Pz0Y1H+L8AbPcvsFgeAATnlVwEYQcYiizBBIxf2ZZoc8RVpg6L2HDiYJldt9II45LVgbQm2x0xhWoY46R7D/GYAPMacznTddS9EpTrv7sA+u8omJTpheBzB6XSYDsaSHGYraf+4ElGc3er807OvafbU6s67krsXzsfswiBvcyerM/gaM5jjTehBDXWwpJL6a/pQZnv1f/RHWRiOj0GIVG1Z461LBLMK90K33oFCjyCVhkbqqSgDo6Sbb7q+QQ2QUkfRFgsA3QiIxg0P9w2lJi9oUDcVI5WdZrU7Od3UipDn8JBeLeaozp5Y/zexLkDQ4vU6hXz8XkjAx5cqeVVml51uQPHVHjJDQhEZbfkUePl9wPufb4EHVVq3nAaDRsuQZPZTHzGrM7JTpIwBDq1MlH5eGN3X9LjMbocFBwQeQi+62Ray+mvO4G/WRJhJ5iUdmSVzTCPsJE5/BWRCE7jVv5k/W7EEGOsR5Us2pqsguHVVDuxGZWOJOoEmWVGQTD1DESaby/dUheWQq8sbKIjSg3noO4Qr5aEqb4cqk5luyr8aeWmgQ8ok+l8jkyOdl8EMzRkn+7l0aXId8MyWK9e0k/LqA3g/fhKS2/v6TZbtHI0YPX7GObrGZWHE5aJCnm+uv9bamrTC3rmS2JqCmjdw6T5015f6UdJvWUxcRNq4=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(186003)(8936002)(26005)(508600001)(2906002)(36756003)(53546011)(8676002)(86362001)(5660300002)(31686004)(6486002)(4326008)(83380400001)(66946007)(54906003)(16576012)(6916009)(956004)(38100700002)(31696002)(2616005)(66556008)(66476007)(316002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?eUpKbmRKMWR4djVQS24yYktlcDlsa1RSYW9XQ3BIa2syVTdqL1BCNDEyZXYy?=
 =?utf-8?B?MS8wS20zWDBMVjRVelo0ejdzQUE2MkkxY2VrN0xZK25pZGJkTUZNZEhhTWQv?=
 =?utf-8?B?QzNsYnZYOXVYMll3NDFQRURBeTRST0ZNZVNyOWZmUFphRm9FMkV1SkZyNFp2?=
 =?utf-8?B?VUE5c09wcmVzNTBPOHY3KzNOcDF0SHQyWWliRzAxdEIvYTlLUUxuTkg1RVZE?=
 =?utf-8?B?MzE1K1B0VnliTnJxa2kxeVR3N3AxMzEyWng2WnFyU0h3UTFTOFhBRC9LY29Q?=
 =?utf-8?B?MFF3UDY5RVBWcmYwYVFtUnpidUM3SjNCM3FtMTRXM2pOdGtvejNXYWNvTkl5?=
 =?utf-8?B?T2hqbHF1ZDRSMVA4b2hMbGswalVVWk0wOFkrZlgzNUhRdWRGSGNJcVVnQy9q?=
 =?utf-8?B?eGt4eFJPTEdkT2duSy9iZlRhUnUxenh6Z0JkemhVME5xUDZQU2NQdlpYQUpL?=
 =?utf-8?B?YmxxWTlGcTBvWExERFBGM0hxRW8vSzBDSGVabkdBMXZyaGFxTG1oRWlybjNh?=
 =?utf-8?B?MU1sWVpBQTFldk9ncVFoWmtMMTYzMWNySTE2ZTJ5ZGVwcWNVUTMwVFJzOEIz?=
 =?utf-8?B?Z0tOdCsxd1dsL3ZQNDNFeW1HSy9VN3pKY0FZc1pwWTNqRG9pdjJZZGx5bjR3?=
 =?utf-8?B?RFhDRTZydmFzV29hTjl1dWRkYU4wYkcrYVZIdXBaTmZ2WXpjcldhU2NHdVFj?=
 =?utf-8?B?RUZzVU9HcmV1cjF5Qjh5S3hpY1pXQXErT052Q2JlUFJJYXRSVytDWFZpazBJ?=
 =?utf-8?B?Sm03eGg4YnVCSzFVWFBvVFZCSFdHZURDV0dOa3B3WWZ1NU1Ja05pY0E0elRJ?=
 =?utf-8?B?dTMrWndNVFhsaGpyWkYxejBaMXp0N3ZHN3NqWk5xSkVjM1BmV2tabm9PeDVi?=
 =?utf-8?B?aDNJa0tkV3VZdEVybzFVMXFTaEFVSVVKRlFFd1RhL3IvWFZGMzZYdWI1eXI0?=
 =?utf-8?B?YlkvbHJUNG9Vb0JBU0FwZ0JjSU41SnpMSGZTeWxObVBXOGNMdUw0b2lyRk1K?=
 =?utf-8?B?V25YS2RxbTVTU1hmdUppbVdpQ3JmVnY4S0Nrdmd3VXphNE5BWk9QeEdaQXVo?=
 =?utf-8?B?RFJWRWVxakNkbm5SYXlLZ1RRV2oxMG9mQ0dwaklFTzBzb2hnNVZkNGFLSUh2?=
 =?utf-8?B?dlNEMG05VFV0STNqTW43L1lKM2pXUDJWZCs1VWcxeTU5UHFRQXZkVDl1Z0h1?=
 =?utf-8?B?ZjVZUHVlNmw4MldyV3pLUzF1ZjJFWVBjc3NkOEhpcXZSeUwvTWZWNnR5Z2hm?=
 =?utf-8?B?R3RkVm9RNUJXb293emZJZ0xwejZTTWhMRGswWDVDdkZqcnVrSXRpSTAwNW1n?=
 =?utf-8?B?cXpwNkFydzlJYzY1SXN3bDB4L3ZBSVFLbU1wdXlqcEtLVUpuVTZIM2R0SVFh?=
 =?utf-8?B?K1d1bFFnUjFGUTVuOVpST1QzUWNaUVFROGI1OG1EVUdjaWwzT2lYc29IZ3Z1?=
 =?utf-8?B?MGZHZkVkWVVWd082aDRHZmQ3U0hmUnZ4ejFCdHdWS2JWcCtjTmhZejdNOUZs?=
 =?utf-8?B?RjdXd1FYbjlQOUpjVldxcXFxQW5hYlVSODdtRmtsMDhkWGpLL0ExWm9reGZG?=
 =?utf-8?B?ZlJQVC9rcjhRNitybHhxSnhJSkY4b2FJWkhaRG9mMFk1dkY1dGtWZ0JEbFRr?=
 =?utf-8?B?Qll3M3FQNTR4MGN6TWtKeUQ3ZGZ2T2VnK2d4Y3pnRUZIRjgxejBsaVhiYlJ0?=
 =?utf-8?B?WTdyWVR2ZFFVMVcyWFc3N2k1cHc4M0lGa2NHZEZ0VEFlM1ozTEl0TWU3S2JU?=
 =?utf-8?Q?0HLsDWeIIFeI6JnVac8LvMqes+E9RrY7YMYTf6g?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: faa08ebe-1618-4034-647a-08d98ccc26d1
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2021 15:31:10.3708
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: LtTMKq7i0aY6O5ujSttFJs7CKZqOa0t7gd1vD1hO2LoL8AqbMD+fFVg2UnJy2phxgHxd6UhcHbAPnglNtAJACg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7150

On 11.10.2021 16:58, Anthony PERARD wrote:
> On Mon, Oct 11, 2021 at 12:56:54PM +0200, Jan Beulich wrote:
>> On 24.08.2021 12:50, Anthony PERARD wrote:
>>> Currently, the xen/Makefile is re-parsed several times: once to start
>>> the build process, and several more time with Rules.mk including it.
>>> This makes it difficult to reason with a Makefile used for several
>>> purpose, and it actually slow down the build process.
>>
>> I'm struggling some with what you want to express here. What does
>> "to reason" refer to?
> 
> I guess "to reason with something" isn't an expression. I mean that the
> main Makefile is difficult to work with as it setup the build process
> for the rest of the build. And it is difficult to understand what is
> happening when it recursed into itself, and thus possibly re-executing
> part of the build process setup.
> 
>>> So this patch introduce "build.mk" which Rules.mk will use when
>>> present instead of the "Makefile" of a directory. (Linux's Kbuild
>>> named that file "Kbuild".)
>>>
>>> We have a few targets to move to "build.mk" identified by them been
>>> build via "make -f Rules.mk" without changing directory.
>>>
>>> As for the main targets like "build", we can have them depends on
>>> there underscore-prefix targets like "_build" without having to use
>>> "Rules.mk" while still retaining the check for unsupported
>>> architecture. (Those main rules are changed to be single-colon as
>>> there should only be a single recipe for them.)
>>>
>>> With nearly everything needed to move to "build.mk" moved, there is a
>>> single dependency left from "Rules.mk": $(TARGET), which is moved to
>>> the main Makefile.
>>
>> I'm having trouble identifying what this describes. Searching for
>> $(TARGET) in the patch doesn't yield any obvious match. Thinking
>> about it, do you perhaps mean the setting of that variable? Is
>> moving that guaranteed to not leave the variable undefined? Or in
>> other words is there no scenario at all where xen/Makefile might
>> get bypassed? (Aiui building an individual .o, .i, or .s would
>> continue to be fine, but it feels like something along these lines
>> might get broken.)
> 
> I mean that "xen/Rules.mk" will never "include" "xen/Makefile" after
> this patch, but the variable "TARGET" is only set in "xen/Rules.mk". But
> "xen/Makefile" still needs "TARGET" to be set so I moved the assignment
> of the variable from "xen/Rules.mk" into "xen/Makefile".

Okay, thanks, this confirms the understanding I had developed; maybe
you try to reword this some. What your reply doesn't address is my
question, though.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Oct 11 15:33:38 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 15:33:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.206221.361731 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZxJ3-00012v-Lg; Mon, 11 Oct 2021 15:33:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 206221.361731; Mon, 11 Oct 2021 15:33:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZxJ3-00012o-II; Mon, 11 Oct 2021 15:33:37 +0000
Received: by outflank-mailman (input) for mailman id 206221;
 Mon, 11 Oct 2021 15:33:36 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=wT4x=O7=kernel.org=maz@srs-us1.protection.inumbo.net>)
 id 1mZxJ2-00012g-O3
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 15:33:36 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 992ffbc0-2aa8-11ec-80e6-12813bfff9fa;
 Mon, 11 Oct 2021 15:33:35 +0000 (UTC)
Received: from disco-boy.misterjones.org (disco-boy.misterjones.org
 [51.254.78.96])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by mail.kernel.org (Postfix) with ESMTPSA id 3481760C49;
 Mon, 11 Oct 2021 15:33:35 +0000 (UTC)
Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org)
 by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2)
 (envelope-from <maz@kernel.org>)
 id 1mZxIy-00G3oP-Qe; Mon, 11 Oct 2021 16:33:33 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 992ffbc0-2aa8-11ec-80e6-12813bfff9fa
Date: Mon, 11 Oct 2021 16:33:31 +0100
Message-ID: <87lf2zpodw.wl-maz@kernel.org>
From: Marc Zyngier <maz@kernel.org>
To: Sean Christopherson <seanjc@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Will Deacon <will@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Guo Ren <guoren@kernel.org>,
	Nick Hu <nickhu@andestech.com>,
	Greentime Hu <green.hu@gmail.com>,
	Vincent Chen <deanbo422@gmail.com>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@redhat.com>,
	Namhyung Kim <namhyung@kernel.org>,
	James Morse <james.morse@arm.com>,
	Alexandru Elisei <alexandru.elisei@arm.com>,
	Suzuki K Poulose <suzuki.poulose@arm.com>,
	Vitaly Kuznetsov <vkuznets@redhat.com>,
	Wanpeng Li <wanpengli@tencent.com>,
	Jim Mattson <jmattson@google.com>,
	Joerg Roedel <joro@8bytes.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-perf-users@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	kvmarm@lists.cs.columbia.edu,
	linux-csky@vger.kernel.org,
	linux-riscv@lists.infradead.org,
	kvm@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	Artem Kashkanov <artem.kashkanov@intel.com>,
	Like Xu <like.xu.linux@gmail.com>,
	Zhu Lingshan <lingshan.zhu@intel.com>
Subject: Re: [PATCH v3 12/16] KVM: Move x86's perf guest info callbacks to generic KVM
In-Reply-To: <YWROQSGPuPf3wfC9@google.com>
References: <20210922000533.713300-1-seanjc@google.com>
	<20210922000533.713300-13-seanjc@google.com>
	<87wnmjq4y3.wl-maz@kernel.org>
	<YWROQSGPuPf3wfC9@google.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue)
 FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1
 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
X-SA-Exim-Connect-IP: 185.219.108.64
X-SA-Exim-Rcpt-To: seanjc@google.com, peterz@infradead.org, mingo@redhat.com, acme@kernel.org, will@kernel.org, mark.rutland@arm.com, guoren@kernel.org, nickhu@andestech.com, green.hu@gmail.com, deanbo422@gmail.com, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, pbonzini@redhat.com, boris.ostrovsky@oracle.com, jgross@suse.com, alexander.shishkin@linux.intel.com, jolsa@redhat.com, namhyung@kernel.org, james.morse@arm.com, alexandru.elisei@arm.com, suzuki.poulose@arm.com, vkuznets@redhat.com, wanpengli@tencent.com, jmattson@google.com, joro@8bytes.org, sstabellini@kernel.org, linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, kvmarm@lists.cs.columbia.edu, linux-csky@vger.kernel.org, linux-riscv@lists.infradead.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, artem.kashkanov@intel.com, like.xu.linux@gmail.com, lingshan.zhu@intel.com
X-SA-Exim-Mail-From: maz@kernel.org
X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false

On Mon, 11 Oct 2021 15:46:25 +0100,
Sean Christopherson <seanjc@google.com> wrote:
> 
> On Mon, Oct 11, 2021, Marc Zyngier wrote:
> > On Wed, 22 Sep 2021 01:05:29 +0100, Sean Christopherson <seanjc@google.com> wrote:
> > > diff --git a/arch/arm64/include/asm/kvm_host.h b/arch/arm64/include/asm/kvm_host.h
> > > index ed940aec89e0..828b6eaa2c56 100644
> > > --- a/arch/arm64/include/asm/kvm_host.h
> > > +++ b/arch/arm64/include/asm/kvm_host.h
> > > @@ -673,6 +673,14 @@ int io_mem_abort(struct kvm_vcpu *vcpu, phys_addr_t fault_ipa);
> > >  void kvm_perf_init(void);
> > >  void kvm_perf_teardown(void);
> > >  
> > > +#ifdef CONFIG_GUEST_PERF_EVENTS
> > > +static inline bool kvm_arch_pmi_in_guest(struct kvm_vcpu *vcpu)
> > 
> > Pardon my x86 ignorance, what is PMI? PMU Interrupt?
> 
> Ya, Performance Monitoring Interrupt.  I didn't realize the term wasn't
> common perf terminology.  Maybe kvm_arch_perf_events_in_guest() to be
> less x86-centric?

Up to you. I would be happy with just a comment.

> 
> > > +{
> > > +	/* Any callback while a vCPU is loaded is considered to be in guest. */
> > > +	return !!vcpu;
> > > +}
> > > +#endif
> > 
> > Do you really need this #ifdef?
> 
> Nope, should compile fine without it, though simply dropping the #ifdef
> would make make the semantics of the function wrong, even if nothing
> consumes it.  Tweak it to use IS_ENABLED()?
> 
> 	return IS_ENABLED(CONFIG_GUEST_PERF_EVENTS) && !!vcpu;

LGTM.

	M.

-- 
Without deviation from the norm, progress is not possible.


From xen-devel-bounces@lists.xenproject.org Mon Oct 11 15:38:59 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 15:38:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.206228.361741 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZxOB-0001kS-8n; Mon, 11 Oct 2021 15:38:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 206228.361741; Mon, 11 Oct 2021 15:38:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZxOB-0001kL-5U; Mon, 11 Oct 2021 15:38:55 +0000
Received: by outflank-mailman (input) for mailman id 206228;
 Mon, 11 Oct 2021 15:38:54 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=9TNE=O7=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mZxOA-0001kF-BT
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 15:38:54 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 56209bae-2aa9-11ec-80e6-12813bfff9fa;
 Mon, 11 Oct 2021 15:38:53 +0000 (UTC)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2050.outbound.protection.outlook.com [104.47.13.50]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-39-JM3_ItKtOlWTtNCRQeOzEQ-1; Mon, 11 Oct 2021 17:38:51 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB5472.eurprd04.prod.outlook.com (2603:10a6:803:d3::28)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18; Mon, 11 Oct
 2021 15:38:49 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4587.026; Mon, 11 Oct 2021
 15:38:49 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM5PR0701CA0001.eurprd07.prod.outlook.com (2603:10a6:203:51::11) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.4 via Frontend
 Transport; Mon, 11 Oct 2021 15:38:48 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 56209bae-2aa9-11ec-80e6-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1633966732;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=O/8VgskuAtOn+RajcLyK3w9vaJOVjYkOjh2PurgjvpE=;
	b=ho7jd3dnidtM4wx6QNM5GRqEUcklgqNKOrDsxH1y9nlw5i/G0CjvpQMaY3FOLSDFngLDVo
	FRZxmu+0JQFe365USeOxy1OdawfbJYOHm0PsXek5AJykAa37hOyeeSlMolXaqP5JPiBePm
	coBlhgZ8sS1JmvJ2SUiK6H7DyU+7WfY=
X-MC-Unique: JM3_ItKtOlWTtNCRQeOzEQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=bKdyVkJqEsRUCJugHW8U6TA5F6mNG9+w/w3vmfyRTZcEY1KYDCWMdN4uF7KAYSTBBNTq1x0GtGdmSGO9+QL3djDebMMsPYwyX8EhP22iKBIWXChqkgahrPHfVNQo6AMI2RszLOT5y79jMQk1USKWJj8fpZoJYAbm0IpQvzBv5lmBOCnE3el+oS6cTWBX6a4q21Pufk0911/rrU4RczJa5HkJcS0t1yMrQGHOfpWhGZ1Hql/EfJiMKmlQPi8MGVgu7vLtxKpK35kPSvSN+ni0V7XlkBU8TbS57nwBHaWtg4ZQJbZ1Q0i3agt/DGfcOtQ8SiPqbP5KN8U5Ve0uxW2P6w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=O/8VgskuAtOn+RajcLyK3w9vaJOVjYkOjh2PurgjvpE=;
 b=Xsyw+F0v62JQkqyhoRDxOIVyObCxpQO/97naT01C4a8kYF5cD0gk/GR6LA7QsqArgZj4zMB6mKtsk4iDYI7mi2YtniASfRgrRqSBm8w1sn0ZgBdIprkzuT4XwviXk9oHO2q9cYLbpRbVKKF17UR0ZEKqTpTyNTiPN5RGcFuxRBs44S/X+jQOMcgtSlCojqBWbLKjGTAlqQ4gPrMszlImNZKTMQzy3oW8SMAAtBBuiRZkCXSEf8nUmsX3Uqd7vXR3aRE4lcNhpfa+h6j1uxgE1Hj8baPTTOAJkmcIw6okSOnMYtQTOkoZQ+FkLILriDWDRheALSnKRLFhWnAwsKubnQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [XEN PATCH v7 30/51] build: hook kconfig into xen build system
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>, Doug Goldstein <cardoe@cardoe.com>,
 xen-devel@lists.xenproject.org
References: <20210824105038.1257926-1-anthony.perard@citrix.com>
 <20210824105038.1257926-31-anthony.perard@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <eb7accc1-f46f-51c3-6610-4c6afbc40507@suse.com>
Date: Mon, 11 Oct 2021 17:38:47 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <20210824105038.1257926-31-anthony.perard@citrix.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM5PR0701CA0001.eurprd07.prod.outlook.com
 (2603:10a6:203:51::11) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: dc72c951-744e-4d7f-c771-08d98ccd38b2
X-MS-TrafficTypeDiagnostic: VI1PR04MB5472:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB5472E41E1F1FFB2302168259B3B59@VI1PR04MB5472.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:813;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	YXz5xn4QR03tej+ryq3CAbZnBBwTNH00vCud52O/QSgBAPboOAAND0okTC7F/AuvJiX0WS46bQIcfkoqyEH5We7n234JlF4oyb1STabevMQYNMkRpKlxh7FRPOfi+SuqGknHnalMALpDuBo3tBfX2wMHWmJ+APAZjGWfR9egq/7dgbR1bFzXp+axlVf2F4Ybegn41XqR35IsmL/Iz3M2YBlYRlGGmEke6Hy+Nzet1QyFDaSHW1tLN4kbNKO+c7d7+nlj9IJbAekVXMhodHNOfEnKgKonXDZoYbL4EcTH9ffVzNee+84yXyABEVYGSGpdKO4AgPNjg/D38mdJEcU0FGrNDxkcHf6a+hLPQFhScBXrdarSreZk6Dlspyt267WSZkExUNuab6Bkiqj6uIZgDvZm8uNAie8gxIq8pY9sMZlWEGSU8AmoMO452UIIfjNg3aKXlVmyQLKWUIIJrKvumGzWjahk4sdDymJiIlEwrsc4K6gPjdrEWEPapGVj1I0qLu6+kBFRMJFiK2ADngU9E3/rslWqOEXO6lKXJjPdrkePwAOB8c/0i//xCftCgUkBOlTISbuwKJML+qUU16dSKDVsYNkXDqocOG6Ok/lgzsdeI6XViswllcyYfImuOgXy0LYF+PuUgvLP03CElctHQ9vPFidWmEFZLCqYVfkERnUV42lYNhegSpMW+AXrXxCtG3E86sB0Cr0ALBv7m95nV+QaWEbSuzM0RT0hVHOYBb9bEhXHxqQBniG+AHQoiEOO
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(38100700002)(4744005)(5660300002)(26005)(186003)(31686004)(53546011)(6486002)(4326008)(86362001)(8676002)(316002)(508600001)(16576012)(54906003)(66476007)(83380400001)(2616005)(31696002)(8936002)(956004)(66946007)(6916009)(66556008)(2906002)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?dVo4ZDczc2twRHZPUDI4UXI0dms3NjJUYmpOQyt5Qm95ajR2SDQ3Nk1lOXlG?=
 =?utf-8?B?enYrdHlMN3lCcktXTEt4RVhNRjkrdG93Q1VmVGVwenB5N0RFR1IzZFNOWVVG?=
 =?utf-8?B?amM3Y2M0YldzZ3dkNGEvenJUeHhsVHZLdXdqUlZXWHZVeEljYTNMQlpMUis5?=
 =?utf-8?B?Zkk0b2U1R0RVRDJ5Q0tsS1Z5NlZxczJrM3k2WTJteDB1UE5QWHhuY096bFVK?=
 =?utf-8?B?ZkIwQ2xreDJNV3poMk9nYWs5MVVGRVczb2REK0E5S2krblhGdXpBb1VkeHhu?=
 =?utf-8?B?bWpTNWtEWjZmL0JGUjgyVUhoWXVyWlJORGZGaTdNTng2dnBIWkIxSmRETWVE?=
 =?utf-8?B?djh1SXJiMjFOVzlDcUxmbmVaYmIzdWJyMk4rN0cxRXZ5eStGNTJXUnhQNnJN?=
 =?utf-8?B?K0ZJVkJXOXhIbU1VdDREYmxtbmlkbUhQTWNGTXlYdW9GVjFGZDgrNGcycmNi?=
 =?utf-8?B?dWhVMnRvN1ZSU2FaNVNXTEFYb2ZKWXpRSXQ2cFVYQlc3Q0M0MG5sOHFlZlBk?=
 =?utf-8?B?ZnROekx4R0oxdlZvZE9hMUx6MGlTSlJ4NUtxUThod0FwS3A5SUIyWXdyMUk4?=
 =?utf-8?B?S3dhS2grNFpLamxMcDhCTkgvaUJUK2trVTdiN1piM3BZYjFvRzFaQVFYR0dm?=
 =?utf-8?B?aExJWk5RNWFyYkFkNmgwUmgvUUwxYnhZUVhhaDB4ZUI2KzVDTWVHMG8vY0hm?=
 =?utf-8?B?cEpaQVRQcGV3VjdReXptSkluNnJKQ3ZCRVN5QmN6VHgrTDc0Y2JVZWRkT1l3?=
 =?utf-8?B?SWNMVk0wMDZzYmxGeTRJNmxsZm5HQ2dlVWExWHlqMVRiU0JtcklxSXhjMXh3?=
 =?utf-8?B?ZENCWmpaRFF1OWZsZ1lZMm5md0pQNi9MaDZkQjdyZEMzMkVVOVYzbU83bXMx?=
 =?utf-8?B?aVVHWkQzdlMzM1oyUElSSGFMNStueXhpbWdaZ25TY2ZkLzc5UUx4N2ZHOVV0?=
 =?utf-8?B?eTJIdmhOM05PZmhQL3BHZkdXMURhR0VvK0l3ZVM3Z3Vub1dVWmJkL2FMYUJu?=
 =?utf-8?B?dFdXU1UzaUdNb3hpZ0owUGJqSmt0d2JISG9FSWVzblU3OUxQTTVDQmdzYTl5?=
 =?utf-8?B?TUptTTJ2ZzRGTnVSUDFIalQ2MXFhL3JaYlBScUZ4bTVTdzVvd2ZOd1JxVm1k?=
 =?utf-8?B?UlpqdHBqeXBIZVNwZ0FvWExnZ1praWRERWhUN1F5MlJyVzNVaUxMRGlGcHRD?=
 =?utf-8?B?SDliRHU5b3IzTGJIWHhWaXRtQithbHVNTTBacVpZNHloQUVvWmFKZFhUSG1N?=
 =?utf-8?B?UjA4YlhaL2p5V09ZTWZWcHNWL29JTG9QSEI0cTVuV2M1SDBxdkNzbWM1TVQr?=
 =?utf-8?B?eStRSXhqa3ptVzFaQ2tWNzU3dmlmQkQ4eDcrVFVPTzBSOUllNUZrYmFiSEZ4?=
 =?utf-8?B?aVFWSldvQ0pCeXBlZmRHYnUyeUw5Nm5yWHR1RXNJN1lwVFZ3cjNCYWhlbEVx?=
 =?utf-8?B?czJuK09WWjhmUG9PS1pDOXdBd1NEZVZaSnJoVlRpVEdpMlhPZ09WNTNrYXVo?=
 =?utf-8?B?THpqY0dnbDFkS2JnWHd6Q01Va3FJdUlLam9ZNXdBSThvd2QrRlc2MVl2eGZP?=
 =?utf-8?B?MGtzcGgvMjFGa0gzdUZ6aExXQ2xWcFpTM0d1WkJwTVZ6NisxM0E5N2FPVUhJ?=
 =?utf-8?B?MUdJelIwWjAzSm0vZWRtMW94UmM1OWczQjdGMm45b3ozWHNWU2ozMXBPb2hE?=
 =?utf-8?B?b2pzTEtRVDJ4b2Q2alRscVJUVEpWcjhqbDlxUVByK0w4TGJydjhaUnd4YVdQ?=
 =?utf-8?Q?cWzpqOD5vboxBHGtyih6cgORhg8CByAfPHHqQMW?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: dc72c951-744e-4d7f-c771-08d98ccd38b2
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2021 15:38:49.8110
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: FlkPIralznHkoRTpZQhiS8yO+bAKtg89yfTorukTRYzFRymYZM0xcqDq9shNhXmjP6u1qyhLce6UNnBhb2Dp8Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5472

On 24.08.2021 12:50, Anthony PERARD wrote:
> Now that xen's build system is very close to Linux's ones, we can hook
> "Makefile.host" into Xen's build system, and we can build Kconfig with
> that.
> 
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>

Reviewed-by: Jan Beulich <jbeulich@suse.com>



From xen-devel-bounces@lists.xenproject.org Mon Oct 11 15:47:44 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 15:47:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.206237.361753 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZxWc-0003F2-5j; Mon, 11 Oct 2021 15:47:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 206237.361753; Mon, 11 Oct 2021 15:47:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZxWc-0003Ev-1k; Mon, 11 Oct 2021 15:47:38 +0000
Received: by outflank-mailman (input) for mailman id 206237;
 Mon, 11 Oct 2021 15:47:36 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=9TNE=O7=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mZxWa-0003Ep-8w
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 15:47:36 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 8ca0345e-2aaa-11ec-80e7-12813bfff9fa;
 Mon, 11 Oct 2021 15:47:34 +0000 (UTC)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2113.outbound.protection.outlook.com [104.47.18.113])
 (Using TLS) by relay.mimecast.com with ESMTP id
 de-mta-27-IfWy4grzPvqB5Se84UecUw-1; Mon, 11 Oct 2021 17:47:32 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VE1PR04MB7360.eurprd04.prod.outlook.com (2603:10a6:800:1a3::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.21; Mon, 11 Oct
 2021 15:47:31 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4587.026; Mon, 11 Oct 2021
 15:47:31 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS9PR0301CA0007.eurprd03.prod.outlook.com (2603:10a6:20b:468::27) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18 via Frontend
 Transport; Mon, 11 Oct 2021 15:47:30 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8ca0345e-2aaa-11ec-80e7-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1633967253;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=2saFgLUAekDxDtzzvDlCgfc9N1FlVHZpPDYHFPiu/oA=;
	b=bvnZZ5RZmp0b0YHXVSzc5t4a7AXKIT/ENAgrFSp9dBSHE7DNSmdytV2wPIMN8XFI3THQ26
	TNk4EBxcq4Xz8jc1vIxQOlrJn0pwmFho/Gon5WY6OwACfvcQ2oeVhBG2LW5PRC6E2CaeUJ
	M6JSnH16g3cQ70/K5N4BhMTHuXpwUBA=
X-MC-Unique: IfWy4grzPvqB5Se84UecUw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ZB7Qd7yaPheOrlB/OriW+ggL5/Ss1O75Tagu8jiGnvcdNcFDJdE3EsKwMKWtUasb5R+z0ayMr7uVkEekl9vqJMY4IbxSvMuJqdY29PCjxe19ieqw4AQDFIpGx9ZRYiORmvJF2XrKFig8G3HkuC8aayRFClNU48ND5MkGp5jzygQ0H2OpQwDuifOeXfoNQJ1leS9kOQ6RkmFDQ6e/fJW2DNAxKp6QbiqQe9fRQYyxLyw9FVTuxtJkn1WT6Vf7tmu/FGdFhlhU3otATOsgA+8rbAjNGF3posgU98M6lvsaSTP7VQKocs3SfeIiMA5Rjch4pqd2GtT9sY7yGBJ1iu4eUg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=2saFgLUAekDxDtzzvDlCgfc9N1FlVHZpPDYHFPiu/oA=;
 b=YFn8holIeStZbDQM7CnXolD1qu13BugYWfLG7uStnFaQfcQziijE+6v2oZynKfmSvG74yll9psAEXgFOvD+dXHxhblmKg/AMoRnKiZwKLePf5uOQQW+R3qK+AZ/S2pNTmU7c6GZhZiEKsWbWf5lsreH+89eB4RABGqIauPcsuQmJ0zsoQ2bM6/5JlbOqBkR3hgccXaPYY9Jf/9vJWSKQy6cZ7ANruFP02xCRUn4r7DkSjTTVkELOJsc2/Tlrf69FqhnCF70N3fLTNqbWATg3ohNSZgLmXZQkzItxCLKwKkTRmkPER42z7ow7qTHKhlEY0JME62gIVpvtgVhyE+itAg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [XEN PATCH v7 32/51] build: Remove KBUILD_ specific from
 Makefile.host
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>, xen-devel@lists.xenproject.org
References: <20210824105038.1257926-1-anthony.perard@citrix.com>
 <20210824105038.1257926-33-anthony.perard@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <d61fa6ad-6a05-6ad4-4ce0-711b55e0827c@suse.com>
Date: Mon, 11 Oct 2021 17:47:29 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <20210824105038.1257926-33-anthony.perard@citrix.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR0301CA0007.eurprd03.prod.outlook.com
 (2603:10a6:20b:468::27) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: ad4540ef-4de8-4c5b-bc90-08d98cce6f71
X-MS-TrafficTypeDiagnostic: VE1PR04MB7360:
X-Microsoft-Antispam-PRVS:
	<VE1PR04MB73605C0A70103FE86475219CB3B59@VE1PR04MB7360.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6790;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	8TS9uLbgrEUuAqJATA+Nnj5vLF9aalYQk05O2ViVN5uYCYiVh0ZVv8myyq4zhIecU87PG4qB5u5eXeuUt++o0HzagHhWRzU+9673SM5FeXjlOGNMAtxJ3Pma6BMj8rF2+mmmOnBFMo+BZtbLmf6oPOr1lt/LaqnX7Z/WVLyFWQHLI7irYEElwcKrY2VF7yieSojASgNHBvCGAPrFsD3riyTlqs3wwDUXJCKEixRxho7JlOdM8HuHrz3/NQ3GdR4YsOWU5K0rH9SSE15On5z60Qj0UXuUIRhXnF9eCC1g3EYlho95InGxZxGe+UDc9fGpTeMFj+rgwPs0aXRIGWUSQXc8oj3ISXgkamHJriG9xrEihLUhuilsfFR1UHoOltkCQyklljjdRQbOpsZnvvDP8LeTFD6FwV1DllIZm5UCnDfmo0Jiiv0IIZacTeGzIbK/O7fwqEm6vj/gq/3SF8tkQdT3J4dSBPHnjcw7JwKOVEVlwQukwA9+ubjMe0/W0zGVGtR3JHHfLGeQ5aortSxtvtLZI7F0FvTBLX8zBIJR9itYrae/6rt7fPBcal/EXQkSglrINZ3rdptzKoaO1it4qGfaLlOovXK9vuva8/vSzm+Ttk+hbrrX9ywTbwvSGQG8lsB6xJf0hjHeUvR/XfwSCTMznEzQV8T5fPJcu3TN/Yz+Xna0S3RGhfiinG3XMmG16E1XY15J2g8731XLIsQfIwG8phqPqE3LGk6ZWffAw2WbkaVOHlwwjpdCF+fLUYee
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(16576012)(316002)(8676002)(36756003)(31696002)(54906003)(38100700002)(31686004)(508600001)(86362001)(6916009)(5660300002)(4326008)(2906002)(956004)(26005)(6486002)(4744005)(66476007)(2616005)(66556008)(8936002)(66946007)(186003)(53546011)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?dHdtbGZFV3BxM0Rua0tTbVY0WjQzQVd5ODZpTk94L1pKNjlCV0lMTEJkaWJE?=
 =?utf-8?B?SUdXWmdqYUUxcDROaC9pRDVDb3NKVnR1UnB0VGlsbFV2Z3VkQzYxRnJtaXlx?=
 =?utf-8?B?N1JOVko5QktsdnJhWDNSdjNRK0xTTGJDanpwZVNPREo4cWNPdlpnTlVuaTBK?=
 =?utf-8?B?dUcrZm1McGVnTjNJck83VkF6ZEFSM0lVOWljZnpkdXhWd1RuSVp0OCtlNDJ2?=
 =?utf-8?B?NmFTQ2pYeGl3ZFdUdTJ2ZThBL05SSDZQdmNCRlkyN2ZrWUhhSW1sS0phRStX?=
 =?utf-8?B?bDdZRnI2b2ZEdVJOQVJtRTJBdUc3dkwzVFFNNzlKcFlyemcrWVdscVlmNEl6?=
 =?utf-8?B?VExmMFBBbXhkblBRejd5SHU2b2NZaGtyaEpmV040Y1RXSnlIbTRTamNYWUVU?=
 =?utf-8?B?Zk94OGM2R3cxaGhKSXdiWmUwbnBkaXYyS0dyOGFVSnQ1Tk9yT2VaOE9pVGMy?=
 =?utf-8?B?Nmk1N2hWN2k2U2Q5VXFTcXgrazhwaUhoeHdGRE1LaUhhQ2VPWW1vLzZvK3Yr?=
 =?utf-8?B?SzdrNTMyc2NZQ2lQLzBnaDVGL2pETjRSaS9sbWVSZnZ6aVBKV040V3VZN054?=
 =?utf-8?B?ZHZpeGVGWWtndmQ3aHFRcHBsc245SGFhbHlydGl6OC9sUXhXQ2N3b0ZKMFRa?=
 =?utf-8?B?dU9RdTNlU3lwRUNDOWE0OGxBL243dkVLQmd3TWhPVnZHeHZHR1hJd0V0dmxM?=
 =?utf-8?B?bTZNN29yMXp5cmY3b29FNlhtSG5SeUw3S3ZUWkQ3NG53dTJCblFJMEt4dUpC?=
 =?utf-8?B?MlYvallETFZBVmZqTmNXVmovQ2oxbi9qdmtuSHVWZG5DTnVuZG91VXpOb3NI?=
 =?utf-8?B?RVBHSzJCUmhxZitDd2FsQlhXa1piZ1gyOE1OY3ozSDlKS2ZRaVhHS0Vnb0wv?=
 =?utf-8?B?aFZyMXRqWXRQRXhDUXI3bDRHTStySEFsMXdpZDFMczFhcnZ6Z25GcUcxM3A3?=
 =?utf-8?B?ZjZOalU1d1BZY2gvSUs5ZW9tUDVjVU83VW9OVjNFRHdHZlEyMFlhMk5ZUGVt?=
 =?utf-8?B?UEk4am5UMXZQV1cxZEI4V01KVDBFbkhUbjh2a1pZYWtmV1plNE81Yk5HYXV5?=
 =?utf-8?B?aTR3aHdqbGpYdzVXUkdWT3ZDbXppZTRaUFh3akpaNGFHVzF0RnR0SDdkenV0?=
 =?utf-8?B?QjlBcTNSMy9EU1dDL25lc0lBemw3UHN4VjF6MFczZ3hVbjZxRWVaSjhHVnow?=
 =?utf-8?B?QkFZTkszaHFhWFNndTZIZ1NJRi9SK3I0R3ZUcUFlMHA1WUZWcUNTdFBJZVNC?=
 =?utf-8?B?YmROMWh2T2FkV2ZvbXJFQVBtdHRzellLbTVhWVM1WkNRTUo0aGEzUWZjd2x5?=
 =?utf-8?B?V0wzVjFOVndlT2JGMElOZC9jamRncS9jZ1JoRkozeWJhbXZsYWEzMmlVOGk2?=
 =?utf-8?B?N0p1NVVUdTV4TGorVEo3N0dyc2dtdm5mVHZTSEhKaXZFTzdDYmRlcE5RYTlG?=
 =?utf-8?B?NWZ6VW0xZ0sweTlsdTJqWklaTlRQZzJPSTNoM0gzNkttbWdKZE9NSEU0MjZU?=
 =?utf-8?B?cVNVS0N3Ym9wQ2FRaTFYZnpLWGs0WWlicmNaN0c1ejJyZEdKQVlKK1BrU1RR?=
 =?utf-8?B?NWJyR2s2dXdNL1d3ZzIzbmNQa1dpMFNkblFDMTlpSHJFVmgyQURORWpDaENF?=
 =?utf-8?B?R0pGS01pcVJweW5LRTZYZXdnZTBDU25nOHNFa3didDJEblc2eXZzckhCTGhK?=
 =?utf-8?B?cVRVYjJQa3R0c2FUdlpSdjBSSW9uSzcyR2czLzROM3p4R1hZM3lUUmxPMzMw?=
 =?utf-8?Q?oJPTWka2HXwhmEXWC7x4qSvTeuvCVR3bXJzUGa9?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ad4540ef-4de8-4c5b-bc90-08d98cce6f71
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2021 15:47:31.1381
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0/t4QeOH96bqofES0z195J0YCmC5pt56/0eNWJ2XZTQp8yQmpHUmT8nJcYWtJjZqfvoiKHq+KdwqmBGpflAKKw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB7360

On 24.08.2021 12:50, Anthony PERARD wrote:
> This will allow $(HOSTCFLAGS) to actually be used when building
> programmes for the build-host.
> 
> The other variable don't exist in our build system.
> 
> Also remove $(KBUILD_EXTMOD) since it should always be empty.
> 
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>

Acked-by: Jan Beulich <jbeulich@suse.com>

I wonder though whether their use of KBUILD_ prefixes doesn't match
our XEN_ ones (e.g. KBUILD_CFLAGS vs XEN_CFLAGS), in which case
replacing rather than stripping might be the way to go.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Oct 11 15:49:05 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 15:49:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.206245.361764 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZxY0-0003rB-GW; Mon, 11 Oct 2021 15:49:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 206245.361764; Mon, 11 Oct 2021 15:49:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZxY0-0003r4-DB; Mon, 11 Oct 2021 15:49:04 +0000
Received: by outflank-mailman (input) for mailman id 206245;
 Mon, 11 Oct 2021 15:49:03 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=9TNE=O7=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mZxXz-0003qw-8D
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 15:49:03 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 63ac62b5-7fc7-4a60-bce7-9c84e3849c56;
 Mon, 11 Oct 2021 15:49:02 +0000 (UTC)
Received: from EUR02-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur02lp2056.outbound.protection.outlook.com [104.47.6.56]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-36-tGPx20rgM5KvXCz0CcD0Rg-1; Mon, 11 Oct 2021 17:49:00 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VE1PR04MB7360.eurprd04.prod.outlook.com (2603:10a6:800:1a3::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.21; Mon, 11 Oct
 2021 15:48:59 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4587.026; Mon, 11 Oct 2021
 15:48:59 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS9PR06CA0254.eurprd06.prod.outlook.com (2603:10a6:20b:45f::29) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.24 via Frontend
 Transport; Mon, 11 Oct 2021 15:48:59 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 63ac62b5-7fc7-4a60-bce7-9c84e3849c56
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1633967341;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=qynyWOoeV7BF4FiJSCB4LZVp2zHWDDRejgnr0+MO0Fs=;
	b=fqqLa11sQ3OP+uSaD5L6T7jAafYsFh6rQgxEsxmPdfFJAPxFqSZPZfI720MyNxA1qkOpb5
	Mec3IKsmkoaTczgH4D2jK9uCO8D5pCPOCGnDaEKfW5uQoK3EcmPIACZ177/9uT7yD0N9EF
	fseDlFHw5ROkAd9zY0fR/7YmeyespUw=
X-MC-Unique: tGPx20rgM5KvXCz0CcD0Rg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=PY6Syny8TQI815DKc8f6FEu2oJfHCgiM4RPMWCAOCz6qX2a/7zGOFUS0qc0T+0LLeIol8T1O2pe1Yk7MVveEoCg1a0kyXMsytICbyBKz+1Zo6fFGDzjwmzAtv/NWYYY6IakJ+d8DsIuEnSLttHTRJwQcYpUjJQfPulYWNHHuxf6WacGAX/gFAyczzzrn7k7rR+7oJY38NgzXZXdzVHOY6m2rYhl8KQvn1dPjMUik4tLvIC4ch6CMnTTK1Ry7i/CzrQ5q3cOJF7GsBkfrbuaztBMFlGstUqlMOah6yIJprlSkf/fKfSTnMLMTxWAcvzjOz3S/FXnBY8I7uu/w17V7jg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=qynyWOoeV7BF4FiJSCB4LZVp2zHWDDRejgnr0+MO0Fs=;
 b=ZKQb1apLxURXWcHATPxWPHZZ7RLI4gVwgF7/oRWj9WjBnE7s+ERM64g0I8ynPJ4Jfs1VYu01KVStLmbZVYuZRXKGdiJxDRzIY1VCMtJKJeHCXVFZwWArlvlle2ceCow/2WTOTd8NlFZ2TnNMUbJZfGUw6jDiv2ZQAJ41keBvb9B9eC/0R6zciKUmSWHS+Uipy4ThkttthQi0u1ccQO1XsHSWLsv5Mr/5CWidai1O71W3kSloINj4vRmQm99FQoVvKV/glYrjF7Hvpne6oxAuIoghtHmRNdxWtAeQ6Zn65Y/lHQa+2qCfiy8FZa5Sxe1AcVVWPdmHyjGNxaQp0gs9qQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [XEN PATCH v7 33/51] build: handle always-y and
 hostprogs-always-y
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>, xen-devel@lists.xenproject.org
References: <20210824105038.1257926-1-anthony.perard@citrix.com>
 <20210824105038.1257926-34-anthony.perard@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <ad1fd010-2b47-a99a-4409-acc237fce0a2@suse.com>
Date: Mon, 11 Oct 2021 17:48:57 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <20210824105038.1257926-34-anthony.perard@citrix.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0254.eurprd06.prod.outlook.com
 (2603:10a6:20b:45f::29) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 22238854-8eaf-4533-f965-08d98ccea43b
X-MS-TrafficTypeDiagnostic: VE1PR04MB7360:
X-Microsoft-Antispam-PRVS:
	<VE1PR04MB7360CBAD8EEC11C51BDACEF4B3B59@VE1PR04MB7360.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:2201;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	9kmSJlI3du7oAXXRqbJY+gk0q8Yh/pcc+oI7y2sGKAHX3vlQd3M+8AV4DS9/ZbEHGlKrJlj8jZQLBli5v+WhwxPNEPZLiZQZ4MU2TQG8Gr2Vd8hs8r6Kba+R3Q1C7gvwa+kDMqm3glYRftNsV5Xb10sRjbfRtVmlvRcRO26QwmojRTDnyCaWMvjDqjbEZXCaFuenQX+qO0OUV+JY30yQfFhJnttebvW8lKo19GwPZ446i5hMQ5rNz7LafKB0cuuS6VPtG7p5hwugus5pahCKXWqTtunDbMJl1NY48UBSGhMal59TavNbQlo0POtJK5A2kJ52UiFQkyYxj151lIloFdDRQlllzbPp5tbpq/s2l6LM6FtHY6b7Mff8S9xQ7Nc5AUZoqt9KEzdvpydlt4/RJiBHorDHf1atGS3jEuN0+cPDS8OjEESNHUiAIcZziSMeUkAKdQiW5kHX4keq/ANoV+iuR4tcbhyNecEsW91IiWCuqkmpIjL53uEaOqlC5D8ibueF3rL9PmB/ybzlK/TCaUG1ZyuISYZHN6cJdO0PcEDEvw1cRsBysK3ka3YTPJSn5Iu6TUN0pPRfR0z1ycf9Kj7ukhFCY69P9sn1gWR0tzZZC7H2oqb2MmZVwEnUrWoHPbEwBYUvOvCT1egQBoHK2AUbEmm238JllxwrqGu0TqNT9MXzbVfw82eO2RbM3wFeV9+LFh/TenbHacox/HPRjgLZxP2CqxpoGOgB8quFiCo=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(16576012)(316002)(8676002)(36756003)(31696002)(54906003)(38100700002)(31686004)(508600001)(86362001)(6916009)(5660300002)(4326008)(2906002)(956004)(26005)(6486002)(558084003)(66476007)(2616005)(66556008)(8936002)(66946007)(186003)(53546011)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?RFh6dzRKQzdGTE9JeS9STjA2UXFadWU3Qy9ZeE1hb2Zycm5lcmpOK3dNdGJG?=
 =?utf-8?B?OVlzYjhJZFpqOWUrTENIejc2WFFpY05qVE5ETXRzTTNRK0VPS3MzUVEyclRJ?=
 =?utf-8?B?bGVZanVqQ3hBR0pHMEcwMDFMelBmeDI2OHdRN0lpbzR1aWFweFBwZ2kzckJr?=
 =?utf-8?B?aWlOc0dBYlJzdlhSUWs3N1VhZ2NCYVA5MU1iSGNYQ05Qd1dwRDhWOGdhVEk5?=
 =?utf-8?B?QUpsQWJUM2NWWGxpMnJrSUJXVUJhRDBGdHp5MUMzdmNraXVMbmZRQ2pVSGZi?=
 =?utf-8?B?ZHk1OEc4STc1K0RzZFpXR1FqZDVBQVNxTFNId2tSaS9WbkVJVmMxNXN6TEVF?=
 =?utf-8?B?U05nejNyZmRrQkJPTjdvczVKUEJlVDIwNmo4d2NDdTU5QjBzUkhpR3RYU1d3?=
 =?utf-8?B?eEcwSnU1UVFRT1pVT0dNb1RDR2ZNdVo2L2d0SVNPcUJuUHRxT01hMkxkQ2hx?=
 =?utf-8?B?dnNEYTNEd1VSNWZjN3RvcWIwOCtxM1IrT084Tnl6ZHlEMTJWdCtNTjhjUjNO?=
 =?utf-8?B?RUc5S1JMQjRDb0kySFV2OTQ5WjFnaXBJbVEzd0NsMEFneWc5MVNZcWh1RjV3?=
 =?utf-8?B?MWFBcTM3ZUxVSngvNnNEVzdvSFovVmZ4OXBMeVpOU3Zsb1FESkt2K1hFU1Ay?=
 =?utf-8?B?ZVRjaVVaZVFxV0Q1L3h2ak5NQWZ5aGk4czMva3JaalNwMmFYaGVxcGlRckZG?=
 =?utf-8?B?YXVwYUc4Z0ZQRDFnVmZEV3hTV25iRHBlODJSUmkwbklWbFdUZ0kyT2FMOE50?=
 =?utf-8?B?ZXVWQXlQc3ZxOVZlL1J3c2IxTXZRZEZaaWFIeDVLa2h5Mnp4NG9SUklsRE9H?=
 =?utf-8?B?bGRiNUphazdBYnFSQ29KTWdPWGg3eDkyVUVWSWhGSUJKbFJMbmFEdWM1TDZr?=
 =?utf-8?B?eTJiUmQ1czZPMm9MdFRHdko3d1l6SC9nTk9oS3pBVDNtdWhNakNTTjR6MVp0?=
 =?utf-8?B?Wms4TUN2NFRuWFIrZTVPdkdwd3lybVJOemN3TWxYVGtkL0lONWl4SGpQNnBj?=
 =?utf-8?B?QW9OR2JtcGs5L1RWeHpiU0V6aG9OVEFyb0lSMlRKR1VYYmsvaXdsVDhVRlZa?=
 =?utf-8?B?d0ZJSVFPbmMyY29hR1ZJMVlqM2ovL1BiU0ZwYWVOYW5mWkJaQUJpR1NiU0NX?=
 =?utf-8?B?ZnVmeGxzc3NFaWJLWkVRdHBPaVBidFhnazlrRjVDeTFBMXRZK0xuM21CT0d2?=
 =?utf-8?B?MXJVbGhzdm5rejM2ZHp1ZmRtTEpTZWpBNXh2aWdvUTJkbDVCMjcvOW1IZzlO?=
 =?utf-8?B?cWR6ZitnQm55WW92OHArbnR1ZGpDaFZtQmt6bkJjYTBqbGpac1RrcHZ0QjI5?=
 =?utf-8?B?bXYwK3V2aS9pVXBHWCtXemdoME1icjhnVXkvRUphNEh1QnFCRWVQRWdaeS9X?=
 =?utf-8?B?dGVzeTNSb2tIbXBJd1U4VGg1NDl3emI2S0t2OW1oMmE5cHZsbC9IMUMxSSs5?=
 =?utf-8?B?b2Z2WkVNWlBSeFVxQmdpcHhwN2MxMVNTcTRZeWtiRVZSL2RBQVhYWHl1dTB2?=
 =?utf-8?B?bVZvRzhHRFFEUUQ3TFpsY0dwNUF0OW43YXl3c3M4cUNWbVhRMW5jeTVNUGZp?=
 =?utf-8?B?S3dpRVhDcFdBaldjMnVyS3JaYy9uekExWTh1QTVTS2U4akY0c0JxdThOVW5H?=
 =?utf-8?B?YlpMNE8xRFY4Tncyb2ZDV2F2U0RDdlVGc1g0TDJRZ3NDb1F3OEhLajYzUDB0?=
 =?utf-8?B?ckxUcW5aRnFLOEorTkRQakNBRFcxVkpjeUxzNytOUTBSZjFNa0VxdVlhMjdm?=
 =?utf-8?Q?rM0wDZP2gwfgx6zFEzkGCfJvt/aNwHSfZJQ3WJf?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 22238854-8eaf-4533-f965-08d98ccea43b
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2021 15:48:59.6850
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 3IyS5WcebMU3kDOAfvZtuV+ojQh5f/92sqweCIaQy+A+20ywgdelyDPw4zC+IGGWWb7ziPahZrPQvMRUNWjhgw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB7360

On 24.08.2021 12:50, Anthony PERARD wrote:
> This will be used for xen/tools/.
> 
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>

Acked-by: Jan Beulich <jbeulich@suse.com>



From xen-devel-bounces@lists.xenproject.org Mon Oct 11 15:50:04 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 15:50:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.206251.361775 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZxYx-0004q1-QQ; Mon, 11 Oct 2021 15:50:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 206251.361775; Mon, 11 Oct 2021 15:50:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZxYx-0004pT-N8; Mon, 11 Oct 2021 15:50:03 +0000
Received: by outflank-mailman (input) for mailman id 206251;
 Mon, 11 Oct 2021 15:50:02 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=9TNE=O7=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mZxYw-0004eL-TD
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 15:50:02 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 7c7b68f8-b54e-444d-82d5-c664632bbe2e;
 Mon, 11 Oct 2021 15:50:02 +0000 (UTC)
Received: from EUR02-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur02lp2052.outbound.protection.outlook.com [104.47.6.52]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-20-9XvOW-zMOgSrrKI0mpECww-1; Mon, 11 Oct 2021 17:50:00 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VE1PR04MB7360.eurprd04.prod.outlook.com (2603:10a6:800:1a3::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.21; Mon, 11 Oct
 2021 15:49:59 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4587.026; Mon, 11 Oct 2021
 15:49:59 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS9PR06CA0268.eurprd06.prod.outlook.com (2603:10a6:20b:45f::19) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18 via Frontend
 Transport; Mon, 11 Oct 2021 15:49:58 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7c7b68f8-b54e-444d-82d5-c664632bbe2e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1633967401;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=A9/oEyYBCSGDGWRIM/aTw/o9H8erJ5NYHygtSAoLsik=;
	b=O0QSQYm6pAXN3JsYGOcrdnbTZKl34CDPMEfl32NQgzCD/5HYF8OYNOMgWOdsIgSK5IHfHa
	Uy0pjHN4TKVc16Z/sXh4JeqhZQRSM4xlehsprlTIcNakbfGvvmbwU7tCy4tRfX2SBfkdeo
	ZV2Zw5jmABk1aiunTHe7/mBXd5IBOCw=
X-MC-Unique: 9XvOW-zMOgSrrKI0mpECww-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=VRaOFybsDkmw+ELSzf9fZqu1VQtAkWfoxV5V6rP88XhMdv6kDEURzlZNPXSUg6F0ysT3qUVSgsBEr73INa3aa8mWG9ixQqdKE2x5Uz6mgnN0Xmkc4vN+miKkB4ikj22tVvLA3TtLHouFDY2crPIQHBYheg9BegaiV4oZZtxGebALHVFQh50rRTO1xf+oJmj7Fj1m5Vc/gt0XHddZECCuaQyewLqTjUhrkkv/IG8FDAcY6+PM4cPaaL1zLLgNUtJo5UlcF6X3jMrTyhLbM3bJob8IfY2u1kkqqNFbv3K375rM3IC8U5qogRhsMM4OG3Pbl3RV5jQIFS1UjvgrLp6sMw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=A9/oEyYBCSGDGWRIM/aTw/o9H8erJ5NYHygtSAoLsik=;
 b=eBQPqXrWEYW57fMqdx16pA6SSsqmAsMt5xXBnmUkXFDgsdsNSAnE2utsB3MU6fYhinDRs2x1mNqdL2BW6XMPTfJ5HwFyTnd3UKn5d33CmVn/HQEOewjMHGOflp+w9CSEeoCFjXf3nkQ5zOBx3ghdz36ztBq3A0vSqOXDbKCtImEFlWXsCTclFEo8UtYidc+ocjsag8uvka0h1ru6JZOeU7KbDsP2BTubsYX/2Qk62fjtAHZIjy0xizjL25opvFDK0PL+uJTD3JIVQ7LfvDLQaYs3zYhKHDgX7IR8gbL5rCcIOsHHwkEyDX/9115oAcj9nV+L/PW+o2kcZwy9HaRt6g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [XEN PATCH v7 34/51] build: start building the tools with the
 main makefiles
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>, xen-devel@lists.xenproject.org
References: <20210824105038.1257926-1-anthony.perard@citrix.com>
 <20210824105038.1257926-35-anthony.perard@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <31b68411-3b98-5714-9990-e19ae45fc485@suse.com>
Date: Mon, 11 Oct 2021 17:49:57 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <20210824105038.1257926-35-anthony.perard@citrix.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0268.eurprd06.prod.outlook.com
 (2603:10a6:20b:45f::19) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 5193c708-d52f-47ab-4ab7-08d98ccec7be
X-MS-TrafficTypeDiagnostic: VE1PR04MB7360:
X-Microsoft-Antispam-PRVS:
	<VE1PR04MB7360C28A0289F9CF6E33C20EB3B59@VE1PR04MB7360.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:439;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	tWJHj1oSpN9kk6qFxu1T8wJ8prEmGmrsPYd8iGhO3RZhm9GhvocHfgEoH03r/+hcFL6VGnwP2cqoIfay9c8i2E5xgytHVUtLuQG3Qqm4DQErbnPqkrOgSmXTuxALlsZL1y8GZU5rc0rPPD38tm8VNm7JC0RiHVAVFUiMb962IDVKeWPj5NhHFqznSXxoMGMHpaUIkKdIA+52IqSqfGdyoXq/lyoxFOtd65bOwfXTSLXEcC+Js/KXzJoQPtiEHcTffnzLappbwlJTZzHmkSGYQd8xpO2ae8jXikvPiPYJNIdTmc6wik5gxQJd1uNw4dIbiGvVnPgZ4bY9bEg0qWU2clgC5ba59FDgXzpcoisGXiDx/jrhmorBtTQzyzrdLA/RS7xCiynONupE25hiK37dUdZNEciWjMiyeHCkdpNtaYgvyi8yt+aF2CT9uBTtYQFFNoKIhUDaerzA7wha3gceD95z4Sbe0KSPqHfyHCetjOOoY7UajYZx37yIAxyUBbZCeKPJON+KvTEdBNld/vQiASEM3qrdm1YxvCQgJx7t4KOYqxwSPtaOupEeqwtxoWGl32UOp8xjz2o/LFdvSSSwQ0hJU+/ivRKJeMYDaseV7bLRt+Orlu0HkXWlLUcsnHTadXKuZjVhSklBkqrekplL6UTiHzhuMmJomut9ZLfhXKjHlyzY6iBHcocGvNvINwoTtm/npxSjce/FNigXyoIJ9IKAl0msmx3XPPcByWA2e+jdDPG+0dyAmeCaFDzExDS7
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(16576012)(316002)(8676002)(36756003)(31696002)(54906003)(38100700002)(31686004)(508600001)(86362001)(6916009)(5660300002)(4326008)(2906002)(956004)(26005)(6486002)(558084003)(66476007)(2616005)(66556008)(8936002)(66946007)(186003)(53546011)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?VEgvRVlOODRkdzFMQ0twQ1I1RXhUYnpNYTFzTHZSaTRIVGNFdTZienJKUEZz?=
 =?utf-8?B?MVRaVXJJUjVYTnNjQXZPemxNcXB2azVCQkorMkxwQTZYSDI2NTIvWjEzeEI3?=
 =?utf-8?B?T3QrRHhkWDlZUklIYXZiQlVSeEpLR2JtQmtqTWhxdi9JR0NNaFJUaHNNOUQv?=
 =?utf-8?B?U2hkb2gyVDBzYWFncEMvQ2FEeDcwZGFPdlc3N1p1bmtxT1RnQi9FVlU3Z3pu?=
 =?utf-8?B?bFFsTjdwUWdmY0hnMG5UaDJCMU8vT3p4V2cxSmUvd3B2QjVBR3c1c0MreWxX?=
 =?utf-8?B?YjVzMmxpdC9rRnJrdVJMMWFNOXo4aG9NYmN3YmhlMENqWHlSL3VQR0VBZGZO?=
 =?utf-8?B?a3FhUXJHcVpzT1ZvWXlKV0dCbjN5RndNdGRNM3Q4VElWdHZMNzdNeC9TVE4w?=
 =?utf-8?B?WFdtWVlYMmZmNnM3eGZKeTlXWkVVMURjN2NsMk84UUlVLzlGMTJmUDNua2s2?=
 =?utf-8?B?YUo2dUlGT0VPR2RjMXFhOC9KOTVNM0tEaTJyTXhsS0FhMDNJUisvSEJjUzhJ?=
 =?utf-8?B?TGozYzNHem15K3cyU3VVbVFvd214UXJlSFdLWXZ6WS96WjZDRlJrRGRtdWIy?=
 =?utf-8?B?d3FVQlRDU2xwQktaYzNCRzBRL2lBNDRNTmRWQWoxMXVmZU9FME1SWWh3MkZ1?=
 =?utf-8?B?TjYrL3p1VFg3cTFMMmxIZitXemNlazhMSjVoS0RkZE84dHRnT1BmamdOSThy?=
 =?utf-8?B?d3l2TEVmSDFmaTl3N0VXa29EalN1NDV4Nzk3TWlpYUpjNlYvMHZEUm84d2kv?=
 =?utf-8?B?RklTdjlpVVRTU3Bpc2kxNWhBbEJ3Y2x0NGM3dFl2c09ud3liSG1kQnhTMitp?=
 =?utf-8?B?Q2kvYTZPZFhQSFhkZzRrTVYvc1QyTzcvU1VydXg5bWdWRk5zbnhOcDYra2g4?=
 =?utf-8?B?bHJ3SXoxWHBYRUtrbzNSK3dTZXAyM3NETWdHclZvVzZFS0pVMGNqdWtoV0dV?=
 =?utf-8?B?K0xrQkk1OWZVbzJoTHFrMXBqNEQrVU5QZWhWWEwrMDVveG5YVSsvc3Q3bkZR?=
 =?utf-8?B?OVloVnl5R1U5SWVKQXJZeWd1dHo0VHorZTlEKyszeUJOVjhaQWFkWmM2Uk02?=
 =?utf-8?B?dzJqNzlGa0luYkRjUWh3M1p5RWZLaFl2dnFqQ1gyOVhDRmduZ3JPVGRmUmkv?=
 =?utf-8?B?cWpqcElUa2lROWJtVDRkaEtWdVVDTytuZ2RWYnJlVjRBK0VCRmVCVStYeXBC?=
 =?utf-8?B?OS9RcGhnaXJlUkk4cnc2bkZjdUtvVTVQOEcxMk5kYnN5L09RcGNVQmdra0dD?=
 =?utf-8?B?cDRpdGhtSXF1L1dFMUZ1c3BKd1o4UWxvNTJEbWl5Uk1vdnVpYTdQbUNEUTNK?=
 =?utf-8?B?eXN4ZEJhR29URnZUaDFvUEtjTDJXL2ZwR1FZZDBrdnNRWHdvUnVkZCtUOEhV?=
 =?utf-8?B?ZTRWZHV4Rmt2TjVzVXdZZEw1WDNwMlVHTkpQaVBSSXQzbW1salBLT2dSZmFJ?=
 =?utf-8?B?bUtGNW1YQTBad0syQWk5ZlZYUE9VMGVqZy9RUWcwcEdmdkpMc1A3emFwR0Zo?=
 =?utf-8?B?dVd6SlFKU0N6bnluWVJabHhGSTYwTWl6aExMQlRrR0VlMXhOK3pSZ0FvTFNL?=
 =?utf-8?B?VzFSTytCWTFPVU1ZRGQrbE1lY2RGS1g1NThmaG5NVFlHRWMrZHNyNEE4Q3VN?=
 =?utf-8?B?YmxWVmtrRmIzWVBPeXZDZHJvUjhzOU1WN3hNdXVWQ3ZYQ3RoWC9UVDVoUzdQ?=
 =?utf-8?B?QjRBaElnWUZzTTlzNkdlOG5vWDcrZDZacEIrYi9xZGExTXpReHRSd0NOcE1H?=
 =?utf-8?Q?mRo0SriZicC1gFbx4Zhqo76HJXL6X1gAEieW8K6?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5193c708-d52f-47ab-4ab7-08d98ccec7be
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2021 15:49:59.2614
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: POD2qdzcrNbLxrgiZzw2WYud3GF8YdeLc0ApkECjctOyKGB3AXc4wcb/TUiaQ19ZjjG0WJClaUjiACqxdTJgEA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB7360

On 24.08.2021 12:50, Anthony PERARD wrote:
> This will make out-of-tree build easier.
> 
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>

Acked-by: Jan Beulich <jbeulich@suse.com>



From xen-devel-bounces@lists.xenproject.org Mon Oct 11 15:51:11 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 15:51:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.206262.361786 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZxa3-0005sN-83; Mon, 11 Oct 2021 15:51:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 206262.361786; Mon, 11 Oct 2021 15:51:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZxa3-0005sG-54; Mon, 11 Oct 2021 15:51:11 +0000
Received: by outflank-mailman (input) for mailman id 206262;
 Mon, 11 Oct 2021 15:51:10 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=9TNE=O7=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mZxa1-0005rw-W6
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 15:51:10 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 0ca6cd70-2aab-11ec-80e8-12813bfff9fa;
 Mon, 11 Oct 2021 15:51:08 +0000 (UTC)
Received: from EUR02-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur02lp2056.outbound.protection.outlook.com [104.47.5.56]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-18-rlXCGxUJM_iH1GPNbzeAMQ-1; Mon, 11 Oct 2021 17:51:06 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0401MB2606.eurprd04.prod.outlook.com (2603:10a6:800:51::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.25; Mon, 11 Oct
 2021 15:51:05 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4587.026; Mon, 11 Oct 2021
 15:51:05 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6PR01CA0059.eurprd01.prod.exchangelabs.com (2603:10a6:20b:e0::36) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.21 via Frontend
 Transport; Mon, 11 Oct 2021 15:51:04 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0ca6cd70-2aab-11ec-80e8-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1633967468;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=6pY2P/nrLuMTsZOtDYHqZmV+d11uy+BDQ5PaYZ2xwlg=;
	b=KEnYXDaDBLInzMygpA8h6bzswMzSau0gcI+9ZegPIu/sGK4Rsn2+or6vpuU0NvJLzE3arp
	cMbUXnvb4G6dK9lY26pmFB+c896gmsTiYpqtZeeuthSVVKBevHfwI0OJXFCbVh2QEKfNYj
	YVhmQ4HeWBtjtfi3+kRFqxmb+rf7HU4=
X-MC-Unique: rlXCGxUJM_iH1GPNbzeAMQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=aSq/WzIb0w92IsRicVqnxIigdXNgRaWhbV5tHdvmd0vqQ9l9icvZDF3DrS8UjMxBCurAuGNNJX+Owy2e9+37zqnVXsw5hhFuMqAGNkJb1bMd6g5gcPqwtf/5Ar/RAs547ITUHLT7XarsC8yaaiuPaaXnHJO1NQ//0Do8HxTXYL0g6uUeKN6vks2WfngxhUuwgvJek3AsfW/yqBQbbakwH3DOPlMHEM+xn17qWIXJCCYZi0YTmSkEhhiIkeLVFRp1lboQAsz2+uKsLcv41/EXDxh2WhF6YbNLLXYdJJzIZU26J11SbDkrJh/CWSu0eSXCMbcCD8r7cWjRIeDBswWg2A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=6pY2P/nrLuMTsZOtDYHqZmV+d11uy+BDQ5PaYZ2xwlg=;
 b=OuI6LOrG23RFEqiYeO5epkQdrWWS5/WTaq+8WkXq2JyhmHfZfH3Ea28309D5aUneGN57J4e0AWcfdUh8mL1XsqlcBXOpSTYoaswh/Mgs7kN1n+KwE3/bgb8qJYDYfoXkZptXKnS3WeT7vgpmWlByXDgbKLQtEgn6rOStXVvuFInaVhBRenEJyhGzwKohMwi69ODtSB/5NIb8sQv8wM8iUpe5ktFIY56CMz/VFhLqJW5GMhavCAGjYrWQHLQ51hmv1twJRRO1AI6dXHsIOWik2KKy2Ckpk/5uWFp/pL/S2oa1RTiRJpERVS14/yMABnBEuTjXPgwIYEQlbxF40eNHkA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [XEN PATCH v7 35/51] build: Add headers path to CFLAGS once for
 all archs
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bob Eshleman <bobbyeshleman@gmail.com>,
 Alistair Francis <alistair.francis@wdc.com>,
 Connor Davis <connojdavis@gmail.com>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>, xen-devel@lists.xenproject.org
References: <20210824105038.1257926-1-anthony.perard@citrix.com>
 <20210824105038.1257926-36-anthony.perard@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <7504f352-1bd9-9912-4d62-923fbd161bf2@suse.com>
Date: Mon, 11 Oct 2021 17:51:03 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <20210824105038.1257926-36-anthony.perard@citrix.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR01CA0059.eurprd01.prod.exchangelabs.com
 (2603:10a6:20b:e0::36) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: e1db797b-3301-4b89-f837-08d98cceeee8
X-MS-TrafficTypeDiagnostic: VI1PR0401MB2606:
X-Microsoft-Antispam-PRVS:
	<VI1PR0401MB2606AC111E0D9FA130556B10B3B59@VI1PR0401MB2606.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:489;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	QvIk7bYJ44kThCFTQYDwJpGCSK9fmS424a1/w3MfFhLGQEdbsqq5OFZKcrGH3tkEBnzFW4rnP2bSdY5CO3fLUoE7GQYL+S6Ths0cowBJj8i+ZVjd/2Mcsll8JsG7IktkZ/naFieS80+VUenaAtaqsgnE4zAUxr7Xo0uI4ilGYqih0dGXQERC3zksYnwJRQCFllt/Q2BX6nb53EUbrMwLUl6J1+BVaUsS3HdAt5Lx6Nwi3EW3u3piZL1B5zXPFfhuWavgluRznZin7uAZNw8P6I3X42JPcgVxPShUsMAbfIMXsAOkLIqbZkH2AheukTtO7fmViTSV/exZ3UiS3yfSsiDzMIcpoMkuSO4U82LFT95P47XNC8oqXMUdjUlXb77EXEI0ARGYIwNb97Yu2nPcVlHYwdaIdHAaXGnDRBv4LBna7gvXTwzqPIvF1Q446p1T3BnmBVS0q9hPYMnLu8fs6EGrKOqE6wzzkNi/MeuYWPdZ5fsigYevH9O+I05oLLxRtqJ/uky425WLKa83L4I5qFy7xLt1X03/oSb61jkfiIejLy5H2IINw8TEh1bpOBOl+mBJKicC2rSQHvC6K3GPsWOtGo2FrE4NBFYViW/FuNFMLAXtpWoi07j7/VJkwsAvIoJvl6WPZZ3FLKJ8o5VAivPwNPh/w9DN2yq0pY3j5DMga/59TxxqmccZ4klaFM7cIIBfVg3Kz2qBVjcfyXkQOA==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(7416002)(558084003)(31696002)(86362001)(186003)(53546011)(4326008)(36756003)(316002)(16576012)(8936002)(5660300002)(508600001)(26005)(956004)(2616005)(6916009)(54906003)(31686004)(66556008)(66476007)(38100700002)(8676002)(66946007)(2906002)(6486002)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?ZkxuVmxqblFhaU9GRmdRZHJsVG40ZzdET25uT3Ixa2EyQVNzVkdsVi8rRXhm?=
 =?utf-8?B?K2lsKzNtbXZ3SUNvOU1LQitlRXBMMkY3WWY0SXE0akNuc2U3SDlMOE1vWHc2?=
 =?utf-8?B?OUJDME5IMTEwY0E3QzQ2MS9sWnhWOVNFUzFrREYwbUVYbDdyTkFlUU9KN2t2?=
 =?utf-8?B?Z2trRExtSHk1R2xQU0s0VERXb2JEOWdSdVd4NHM3TnhzL2RCSXhFUk1CczZL?=
 =?utf-8?B?aEpYZmVldDhZT2kxSk4wWlZEdnlISEVoV2FrbUhrem1PWjFwWTgvZEVFTFZw?=
 =?utf-8?B?OVVyeURlL3hSZmVHbm9Ha29LTTZ1cmdsMnlZV0J3Z0xrdjErcVVrTFZlQ25h?=
 =?utf-8?B?TFRkaTJQT1ErTVdMUHFSSXh2Tm8xcFRZUVEya0JIVlB0aWY3YnJDU0ZZWmVB?=
 =?utf-8?B?enJBT1VWQjlLMFgzVHJXY1VUNURZSEtqMFhxTXpLeW9jQ3htTWZOREJ3YWVC?=
 =?utf-8?B?QmNXcEJvMlFlTnpVV1dQb3lpaXFkaEd0dVpNY3RkVGhkZFBRQkFYWVViVTEz?=
 =?utf-8?B?VTA2bzlTeWZuMmdwZFc4dmRnei9xYVlXUVZVMnlIMG4xbHJnQXRCRU8rclpH?=
 =?utf-8?B?WU9YZldPOGMwUjVnV2p4Wm54YW1WZkdwZUNxZUw5dnovUExZcVJEQ2RoR1I3?=
 =?utf-8?B?NEQ5S2JiZmkyaTlqcFZHTUhtL0s1TUVvbXV3T3NUMktiZ01iRVBlQlhmMDFX?=
 =?utf-8?B?aWlvNGdUeTVYUE5weVVCZ011TnBWWDV1d2RkcmhzYUUyeksxNW9hOVpRdklj?=
 =?utf-8?B?a2NobjNVL0tKZ0puMVdkdXBMaVpFTHg1ekJwV2xydGY0SWh5aWpJbFUxTFdp?=
 =?utf-8?B?WE5SNThJWjhyZGtZZjdIcTRhR0NQblpPVEcvREwzT29BUlBXYUJRY05xSU5K?=
 =?utf-8?B?b1JuR25KOVJqVDNpeUNicWc3RkkzM1MwNFZLT1M4STZwRkthcWZWbms3dkZt?=
 =?utf-8?B?RXlsT2NaOFU5N2hmbTNLSVlVUEw4UVRIcjZ0N3lhWWpGdzZ6RFpOMlpra3o1?=
 =?utf-8?B?T283WkFNR0JxRXJsUzIyOVJtK1Flczc1cXdFSExaZncwMDFlQ003dVBWMTdC?=
 =?utf-8?B?Z3Z2dGhwV3NTbWt2b1VmS3UydWgzck5pRGF2VFVPNXIyelM3ei9SMEw4em93?=
 =?utf-8?B?YUd1MTdjZ2UwTUduTUNlT3JYeWcvcTA2SGdqS1JOalN4MmpYRW5tU1dqMUdy?=
 =?utf-8?B?T0JmcE1rQkNJc1dJUDUvUlVhK2FkQTArUHdpYzVTbTdOUDlSanU1L3RwRGhn?=
 =?utf-8?B?NUZSTGxqdlVBQVVWc2o4dGdob1lyeUJwaE5FWXlmN3J0QnhmSlBYdzNxOUFz?=
 =?utf-8?B?UXNOTkdTNWhQb0dFdUphNkJZVzRQT2lZYk43VitrSUtNRVJhZm9KNStVZGFP?=
 =?utf-8?B?UVlwZ0NDTldmNllZYm93Y2FLN2YxVE1SbmkrNXlOdEJIQ2pzOStiREJ6SkNE?=
 =?utf-8?B?VUtGbDhMamlqUVYvRVl3KzlWY2NyOGVhVkJaSjJpWE10bHNNQ2J0Zzl0K0Zr?=
 =?utf-8?B?cTIraWlkTEx5N2hTK3FUWEdyYkwwNk1zR0JqSzNiNGMwelg4ZUhZMXRHWnY5?=
 =?utf-8?B?Q2ZESlR1YThpMGx4S1lRcVJhSEZ3Um05aGFwejNqV25pbGhzdDUwWWs1ODJx?=
 =?utf-8?B?VzBlNEJxZ1ovbmFScWNIWTVSQTNNSzVIZlpRTXZlQlRPeTdtdUlvR1FRcktU?=
 =?utf-8?B?blh5TjlkVlJhN1dHbmY5NW1sakpnZzhpVDFpY3c0Yi94MUcyS1lOSmVGOHB4?=
 =?utf-8?Q?1rl+waiBK4tFQqCixwN/cR7q69SX5rRrlYVGpxR?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e1db797b-3301-4b89-f837-08d98cceeee8
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2021 15:51:05.0092
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: GA7f9r34HuCKvUkfaCxoAkcLQeOANdilf5qUXLNT3beYhFCW9GSCVYKGaWeh3LM5VS+l6OEPN8Uf/E0cHAbsyg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2606

On 24.08.2021 12:50, Anthony PERARD wrote:
> This just remove duplication.
> 
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>

Ah, here we go.

Reviewed-by: Jan Beulich <jbeulich@suse.com>



From xen-devel-bounces@lists.xenproject.org Mon Oct 11 15:53:02 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 15:53:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.206272.361797 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZxbm-0006V3-Jp; Mon, 11 Oct 2021 15:52:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 206272.361797; Mon, 11 Oct 2021 15:52:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZxbm-0006Uw-Gc; Mon, 11 Oct 2021 15:52:58 +0000
Received: by outflank-mailman (input) for mailman id 206272;
 Mon, 11 Oct 2021 15:52:57 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=9TNE=O7=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mZxbl-0006Uq-J9
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 15:52:57 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id fc976dc8-5fa2-4814-a06f-36254b4d9acf;
 Mon, 11 Oct 2021 15:52:56 +0000 (UTC)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2111.outbound.protection.outlook.com [104.47.17.111])
 (Using TLS) by relay.mimecast.com with ESMTP id
 de-mta-10-h9E_ol5xOWC0ISPcGEPNFg-1; Mon, 11 Oct 2021 17:52:55 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0401MB2606.eurprd04.prod.outlook.com (2603:10a6:800:51::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.25; Mon, 11 Oct
 2021 15:52:53 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4587.026; Mon, 11 Oct 2021
 15:52:53 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6PR05CA0035.eurprd05.prod.outlook.com (2603:10a6:20b:2e::48) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4544.27 via Frontend Transport; Mon, 11 Oct 2021 15:52:53 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fc976dc8-5fa2-4814-a06f-36254b4d9acf
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1633967575;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=PQ7aU546pp2swaBeI4HIFlTAidPrhKbOuXp0X3mWU3Q=;
	b=WuY+6ql+gXCCis8xB6tALb4CEhHKV8XMR2LrRmQAC3+MhmmO6RQXY96EMiyUbKNahrrjRg
	fnhrINWK0bJF6IYGSn7JpoAk0HpqlCYOU2E6weIVDLUUt4wCUDVGidiOKBAEgQ4xGcfW8n
	XeXtQppiYHnRaUkhfWIpgHu3jfxiHUI=
X-MC-Unique: h9E_ol5xOWC0ISPcGEPNFg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=oSBm6zTRtWYEU3kkZFaZDOKBN86EyKzK+xbW0xzxgQQVeOZB++iPN6tSC+qfAEtfgSv9rG65GrutzbuBi5uDw10r512mx72lwmG634OtnyTvQq6xWeTAA4pZlub78nwHIzqQUVkIhH8yybA0sF1aE58KruXl4ShxdeHURL9ApEBb29ZOzSmOrmHVZ3/DQdtG0HcNXWJB3PiSZZ3Px6EdvuohE8taAHGur5U+GmRlcadSX4uPDKkGevPB8eD4UjCJxZOUCPjP4sPRZcnEYgZMfsfWNEBHLDy33XZ/ZSA0eFJtZVG/viRoRbUDsmOIixLh8eqLWP0m9x6kDyVhdZH/wQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=PQ7aU546pp2swaBeI4HIFlTAidPrhKbOuXp0X3mWU3Q=;
 b=lGJt0L4i86b+ZTO/BUmS3hh7UNRJFc9nzUQcEeOUN9tYa67fLDwMz0u6Hxy835dPFek19ShMSnnsUJXQcQDnLu/CiCHFjMsqSMYb63i2+OcO7gP2ZOsXukWOByvapnYRJ5fIx5BsytRJ59O9A3lCrExlzBX48VcZpG5GW4kG8uZ+k8tYcQCuCl5zbY1vHiOcW5zb4S7Y3ZemyR8xYnCi70/G91FIcIACKu234UdkHDFKDWg/6Ld39FKrjSC48lAqR7IL/uSb+QaxhOLmnMpqz4DG2uGtECY/z4Mys6UBFhsWu1XCR4p+3Z0pu4mstqMWhFwaGGT9DTzYDJplczsSuQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [XEN PATCH v7 36/51] build: generate x86's asm-macros.h with
 filechk
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>, Wei Liu
 <wl@xen.org>, xen-devel@lists.xenproject.org
References: <20210824105038.1257926-1-anthony.perard@citrix.com>
 <20210824105038.1257926-37-anthony.perard@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <b435e13c-8915-5cb4-720f-1d8470c5fb70@suse.com>
Date: Mon, 11 Oct 2021 17:52:52 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <20210824105038.1257926-37-anthony.perard@citrix.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR05CA0035.eurprd05.prod.outlook.com
 (2603:10a6:20b:2e::48) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 30a25e6b-5ba6-4887-ecdf-08d98ccf2fc0
X-MS-TrafficTypeDiagnostic: VI1PR0401MB2606:
X-Microsoft-Antispam-PRVS:
	<VI1PR0401MB2606BD510DCD8891DE7D666EB3B59@VI1PR0401MB2606.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:5797;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	+s9xsMResTA32JzvWBmj2eYUSbjOt7pCbKgEVpUE1kInm8ARG1UucGSpWVoZgazv2BixRPTnRDDFePZv593cBKej6XNjo9pqvx5UrYWpxTirOmxdk5kDbpArn3lkxWy44AghbpbPZPH9jCzI7Ox7pqtedRROcpZODgtreixV756rl3MOkdNBKNAzuPw7KPvymjEca5Vllq4mUdhd0oQ9GKppR6esNGTL7RsQF9xN/3abaarfgirrqhb1kRAH0LrPSs5P9Pkx0kyuqnRvegKCNzERZ8uj2GwtR3pnUCyyR2BMDrWAW5bmeJWq0+Vep6boRw8H00cKKG462rk2h9lvFGmm02QeE4kmEr3arekcJCSzGoqF3IGX7hPRZBXD5Sg+Miu7kcbmCLuIAsrATG0uXmwSUm4ZGwgNxmNfmkoOKFrc+e5Mezd00NNWmmWM67tvUA+hfS1JWtTsCM9vZKebXiQyBsdRrp3puTWP5hbo3RN7J7J/J2WLnvEAhl/mktg2AnZqWAwKioRLTfY+6hucR/saLQe/PprXwkPBjHWSGVM7yQV6RJowjPz0xYLulZtaVaeM/D8VfaNZVsVv+ehILTgbd1XeoEpi/cNMh1WHxEa9hlFE3WTQs2JPRo1ukr8cQC5BMw6VOd/JyOUyZRMizpRBksd53Rg7PUyvy7U2KNeOz86TyjW5eenlUNMs1uu4RwNl0hBbb9Jj1wwejUZlBHXYnwKgLanh5TO5pU/RwSE=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(31696002)(86362001)(186003)(53546011)(4326008)(36756003)(316002)(16576012)(8936002)(5660300002)(508600001)(26005)(956004)(2616005)(6916009)(54906003)(31686004)(66556008)(66476007)(38100700002)(8676002)(66946007)(4744005)(2906002)(6486002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?NDBta1EzSU5ycHNpcUNqZitPNnc5TnJhUVBYK3FBVWx3cnFEWFlETk52Q0x4?=
 =?utf-8?B?SEtGcU5UYlRHOWFNdVhBYmtGM01vbjZXMTZtQldrMGFXbHFmdUVpRW15Um8z?=
 =?utf-8?B?QUR3TWF5VmF3MHROejJIZ1hDYXY0MHdmZWFBZE13RzhPYzBLSE9HcDhrckwr?=
 =?utf-8?B?WEhPS1NiNFl5VDZJRTd5UzV2QU1PZlJGdkZJOW9yVlZYRUcwblpQUmx1Y3lx?=
 =?utf-8?B?SWgzTktYd0dQWUh3V3htSzJxbnVRaDB2c0JxVTdzY2FCU0VKaDAxK01hYkc3?=
 =?utf-8?B?S1ZjeVl6c01lR3JWRWhRcVFKVE1CbUdVUk5rVDJHWUltUEVJZ3NNOEJxMlhZ?=
 =?utf-8?B?TFhYMHQzdys3enZsaVR3ZUJnSVdTbkIrRlBCanNWRmNQVzh3WW9Pd2RpcnA3?=
 =?utf-8?B?QWUrMjkvU1UzYjRBVTZLSG5pTHBjcXRXdDUwZVN3ZWtvcmF6OEdwRnp4ZFJ6?=
 =?utf-8?B?WVlodFhseFF6bHlqRjFNa3RUM2d3UDNHUUVWWXJUZExZcE84RmJhdWowcUJF?=
 =?utf-8?B?cExyejU2V1FXdDJXdmNIQ2NBeWZPc0czQUFMdzJodXZzT1J4aVR1VEI1bU1q?=
 =?utf-8?B?cU81RTZPS3NmRFBhQVF4MEtaRWxZUDk2Y2VmLzhWK0IxY045VUpCN21KU3da?=
 =?utf-8?B?WjVpSWNhckJBcnk5UW8xaGU1OW1sVDBoOUdoQy83dzZXbmpkZFRSb1J4Rngv?=
 =?utf-8?B?cnRMUXMwZkR4eks2bVB5WFNEZEJYS0grMXBRRUlsaENRVHFqekRVbURMM09t?=
 =?utf-8?B?UzNLbVdMYjJFV0h3K0hzR2U5K29YOGkydUdQR0gxeEQrUGg5Q1U5VWVPVEdB?=
 =?utf-8?B?Z09laXkxODJqQk54UHJFRkp1ZUM2ZXprcnhXRHBlM1Y5aEhmN1hUaVVwMk9V?=
 =?utf-8?B?YURZc3dPSkVMNGNCV3JGL0RqTTlEM0hmdWJUUExpVkdDOEMrbVFwVDU1UXhN?=
 =?utf-8?B?aytBMGhGcUt1RStCQmVBS0E0TllJMlBDb0tXR0E0NnM4eHYyWG1DbDRvMVEy?=
 =?utf-8?B?RnhrSng3T1ZqOE1Wak85WFY5MTlZYlR2cFBVTkVaMi9QazNZY1QxMDMzZDB0?=
 =?utf-8?B?bXdVNk4rU0tyT082TkdLL0YzNGhxc2RGcThpaEtoeHZkODhobFk3dnJEL1Q2?=
 =?utf-8?B?VC9qVWJOejYwMHZUYUVQSHI2Wk00cCtUUytWeTBUbnRBbmdURzkyMHdxUDR3?=
 =?utf-8?B?VnVNYlJnbHZNS040MWxrQmZsalcyWFhXak1OYUFqcm4yMG9CRzU3SktiNHpZ?=
 =?utf-8?B?Qms5WldRZ0cyY281R3BKQ09WZS9RbW5NRnowZFlPWERzZCtmRS9tekhGTXVn?=
 =?utf-8?B?MndXNm5IZWZDK09rY1MyZS9SR1U4RmEyaVZ3bVhFekFoSk5CTFgvdEdYZkto?=
 =?utf-8?B?Mm9ELy9XdHBibmIramlmSk01dERFWHN1NllHTVVqaDBBa3lyc3ZtMHdtVHRM?=
 =?utf-8?B?Y3UwaG5UOVBGNzRGOVQwenhJb01BZzJ0YnJRbHZrZHBPVy9pS1N4U29OVEVG?=
 =?utf-8?B?OXN1TFlXeSt3bXMrenREalJIeFlLTU5UNE96YXovNXRxUFFIQ0NLUTNSUTlH?=
 =?utf-8?B?OC9JVlNVRmllbnhSdDNnZ0dMRGNpRXQveG81dU1FcFVBbTdsNlJ6U3lWWWc5?=
 =?utf-8?B?Wi9xMkc3Z1V6Uy9xMGRzcit1TnRZMW14U1NiZjZua1AxczkxSzhhdEcxVW1k?=
 =?utf-8?B?K3FIdDBpdGg3cjFZc2lSNzRYSnpMS0R1Uy84MWgxS3ZmN1NwWHViMmkrQnp2?=
 =?utf-8?Q?PRvF5KVFpFMe4o+YTyTlk5jpaoyJGNGdQH8bE1P?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 30a25e6b-5ba6-4887-ecdf-08d98ccf2fc0
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2021 15:52:53.7816
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: j5JbNCsw+xExvwWGTnntpMmrSjDxGj4VpraNHiFhTe5VDglDMR4vxvSTLqovWiVIzCeETMYumtF0pNEhOz2/gA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2606

On 24.08.2021 12:50, Anthony PERARD wrote:
> When we will build out-of-tree, make is going to try to generate
> "asm-macros.h" before the directories "arch/x86/include/asm" exist,
> thus we would need to call `mkdir` explicitly. We will use "filechk"
> for that as it does everything that the current recipe does and does
> call `mkdir`.
> 
> Also, they are no more "*.new" files generated in this directory.
> 
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>

Acked-by: Jan Beulich <jbeulich@suse.com>



From xen-devel-bounces@lists.xenproject.org Mon Oct 11 15:54:18 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 15:54:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.206278.361808 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZxco-00074G-Ub; Mon, 11 Oct 2021 15:54:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 206278.361808; Mon, 11 Oct 2021 15:54:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZxco-000747-RB; Mon, 11 Oct 2021 15:54:02 +0000
Received: by outflank-mailman (input) for mailman id 206278;
 Mon, 11 Oct 2021 15:54:01 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=9TNE=O7=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mZxcn-00073w-7t
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 15:54:01 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 72bf8b38-2aab-11ec-80e8-12813bfff9fa;
 Mon, 11 Oct 2021 15:54:00 +0000 (UTC)
Received: from EUR02-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur02lp2052.outbound.protection.outlook.com [104.47.5.52]) (Using
 TLS) by relay.mimecast.com with ESMTP id de-mta-8-V3M5VOYpNrKGKbglODC7ww-1;
 Mon, 11 Oct 2021 17:53:58 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0401MB2606.eurprd04.prod.outlook.com (2603:10a6:800:51::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.25; Mon, 11 Oct
 2021 15:53:56 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4587.026; Mon, 11 Oct 2021
 15:53:56 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6P194CA0068.EURP194.PROD.OUTLOOK.COM (2603:10a6:209:84::45) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4587.21 via Frontend Transport; Mon, 11 Oct 2021 15:53:55 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 72bf8b38-2aab-11ec-80e8-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1633967639;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=v0JpXKNAMcxTaMcckcI86HQKTf6RhU4lxaGuECTbCZQ=;
	b=Pzhnl8nN1EdurYPKGE2tF4SRocxaxFb/rqmQsS+b76lub0Mn4oaiSSYJFNKu0dUSnV9AcW
	3khKZHWc3/FEhNDR3nzRr8G0ACLNI9PlOQARvd5ecupRei0BRzwTOEsEU/uI54OE8fyjEK
	+0hul4V0V+UE47cx/gDbpviVD/+Besc=
X-MC-Unique: V3M5VOYpNrKGKbglODC7ww-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=kv0LekyZOTFGcMo6n9g+2a7VrogwB2t9xa2u9NFpyHuAGN3cR9ZPsvEsHOdVjxOZ9zwhNaBIxRMujER73AnSdr/jx7JC4KNVcJKLuBXQhJChEtFsr29xukBDnxZXTHjj9/LfZiS3tTLX5vcOnG1iaY3WTJXn3j+2aVRz/QCJTTPubcwYM7VVgHcbnv/GIMs4ryTVDwHssnmA6XoLhj9KVcaJNdgf5FUYgf+bZmirLr51KUhKkurWesAs85gzGS9MfqfjohfCiuBFBfGWQnYQ0lFGJ1RVRkjP8xNzd3szEFT2LqUk00WU2GNsZy1Ahf6M9hMUXndvLvHAkgl47AzMAA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=v0JpXKNAMcxTaMcckcI86HQKTf6RhU4lxaGuECTbCZQ=;
 b=WVlvlfgcyMZufAcBN/jm1fcMdKw+Lc81lgKZBZcFoRXIskII2LOwWYFsxHVFufB/9TIh6g5Pkk2JH6Rayj4tou9aHF2ZbxybibRcKH0DMWapu8Ytn7qRlzpB58tDepTNTXcWKRzz4ppE8pWhan0cHIAIeIHYmK6mfpaqV1xrxEnhf3qhFnCbv/gvjCBj3rQpQpXWOTn0w0Mp3IKJ7akf4APpz9fqLG00mhcPB4sB6Q61/6Ym0iDKXAztp8/ysndZy2SQeVF6FmyJ1Qlzm3pIQF/KKFXa1mCf+ycNd2FuprSOR0ZPmxROj+ZKKoz8s3vkyx5tg6UjwteZe37SbtfVNg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [XEN PATCH v7 37/51] build: clean-up "clean" rules of duplication
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
 Ross Lagerwall <ross.lagerwall@citrix.com>,
 Daniel De Graaf <dgdegra@tycho.nsa.gov>,
 "Daniel P. Smith" <dpsmith@apertussolutions.com>,
 xen-devel@lists.xenproject.org
References: <20210824105038.1257926-1-anthony.perard@citrix.com>
 <20210824105038.1257926-38-anthony.perard@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <312a8a31-196f-a6a3-a337-37594fd6cc65@suse.com>
Date: Mon, 11 Oct 2021 17:53:53 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <20210824105038.1257926-38-anthony.perard@citrix.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P194CA0068.EURP194.PROD.OUTLOOK.COM
 (2603:10a6:209:84::45) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: bf02d854-f760-4569-25db-08d98ccf54d6
X-MS-TrafficTypeDiagnostic: VI1PR0401MB2606:
X-Microsoft-Antispam-PRVS:
	<VI1PR0401MB2606643B55099236C4F4F910B3B59@VI1PR0401MB2606.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:4714;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	BoPcR2gHRm5jfRBoluxeCQLsQLCiiGIuZmfZtwfNCBx6RtSCX7zWMbiM5MrMlc6NDcWd6L5XcrrfE07kWzk/rQ5DRdwo5AVZuHFeWB4W64za5BBWl3CT+TtBY2S4QHXn/soTR4tBdNRLuSx3CfSh0DTuKO6ZGWNcEZuZwD83UhV/A1DhR01vMn2EKXWCFam9EmTIAevZd9CUpkYNdlI/xXyk2s3KLtynN+Oc7BFHQlEvL/zDsWmzlLS7oE4WbulnOjAZiffbtHTG8DlyTSAG5iOj0jwL85Bk0zLy/2gFxjzH70THceoA2aE2b5EUXFfwVwByteOcWT/G5pGAUwSOQFRYGSH0OTkdhv8H9thy+F3mHYIQzv5pjsVrC3Q99PxzOAViA5CzJNEplAdgfwRF5ieL3SDI+pKNavmKQNVcDErw+WVbZtHDLuVD74Ts7+fjzdKx7wWCRrl1KUXpXrO9/E/x7CqOYVLK0OB2c4aLaBqZrCYWCXgzkVbtqw5i3wBLO6EXIX2WR1/H3EDd+G0Tz9rwJnrvbpn0nv81uL8pLgBeHmTfT0xcKOldqnLbhCFie9p7QiHQKWC/RzBDbENNRGcZ3ksxLQlHjwxKU2Hlmagp7hwvK9jgbwq3MHDRIUIULJ4CvakyPhF4Ij3JTX5smUcCXxMWCZKHuoKb5v5KCH9QkSIYeeKe9WGlSJD8cBmYCjCAv3UigGTMfXSYouLx6CQpghjEJ0+oSlaHzDtOMxU=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(7416002)(558084003)(31696002)(86362001)(186003)(53546011)(4326008)(36756003)(316002)(16576012)(8936002)(5660300002)(508600001)(26005)(956004)(2616005)(6916009)(54906003)(31686004)(66556008)(66476007)(38100700002)(8676002)(66946007)(2906002)(6486002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?bnBHQkkxbUFiYXJMamZzSzBMNkRoYjdiRjJmQUNrZGNtWHFNU1UvSEtvK002?=
 =?utf-8?B?U00vMnc3M2RYc1IyOFBXbzNXbkRNVSswYU9DZnU1MUlLNEZKZXNHZVdxaW10?=
 =?utf-8?B?aFJpcjRlNU1wQVZzUTJhTVUyTzc2ZVdvbWJaaWsyRGFjR1BNczA1TzRCb2Ev?=
 =?utf-8?B?UFZQMFFCbHRMNWQvOFl5Z09XbXhrNnRodTV6YTE0bmd5VHVmTHBXSWVqRlFZ?=
 =?utf-8?B?ak0yR042M2JkM1NSd1ZHYWl3UXN1K251b1g0WDVKdzN0c3Q5V2VHRldKZ2dR?=
 =?utf-8?B?MklKSzhteUtmTW00ZzdONXpMUGRubGhHbkdEajg4OCs1RjhHeWNvcStqMC8v?=
 =?utf-8?B?a0ExYnl3Z01GYW52bEhlL2ZJZ295a1ZITzJqQ0NIR2tnY0s3YVRxalU3MFA0?=
 =?utf-8?B?bjFLWENwMVczekN1ZmNrTGJNZHIrUnNzZW1tTVJxQUJiMElFMUQ0OGJHZDhs?=
 =?utf-8?B?eDh6dDR5c0h6M3NsS3NPZGNQV0RrUktCNVRPV3BLMnRCY2N6dGIyZHM0dGVR?=
 =?utf-8?B?WWE5NG9vS2RWU1c2R053QUwyU0wzSTQ5VVFvcEp4cUlZNkhIQm5KTVFNQmFo?=
 =?utf-8?B?WHNBV1ZHTW40Tm5UVGNGRVBONmhaMDlIbHMxZlhlT01UaHR2SnZBb0ptdm91?=
 =?utf-8?B?MVNzQ3JTS1hKci9jbHQ5Zlc2NUJaclR5RXNteHFQYWtDYXMwVXRzN2VOYjhJ?=
 =?utf-8?B?bDhValJDbjVPOEtPUm1SRjdCWW5XLzByT09wdlZvODVLZTBGbGlFM2YwWldn?=
 =?utf-8?B?QVNwWEhjQUhqYitzcHNUMTc1bWJ2T3BxM2VGM2FvaDMzdUFvSWxHZEh1eDBG?=
 =?utf-8?B?QWErTVVBYmRLclNWcE9udEZaNStYa0svOEg0K1BqSERHVUNZL20xeUNPMXRX?=
 =?utf-8?B?RlkrUXhYRDcrS3E4d1pxbVBoVGF5L0lSRVZjWUN1ZSs3M0pnMis1b1UxL1Ja?=
 =?utf-8?B?T0tyRC9pTGpzKzhFK0ZmL3B4c1gxWmVDeVZrdURaeUJSYWNaWVRiNkttMG84?=
 =?utf-8?B?b1FPT3VldFliWVBuMWJEeDI0VCtnelRzNDBzL3dzQ1B3MlNscTRsZWxESmxB?=
 =?utf-8?B?cXdEV01JVUcydTh0Z3crVzZ4MjBJc2MyMlV0SHFOay9HUG9KZkw1ZCs1bWtZ?=
 =?utf-8?B?NHpxbzlrcmdhdms4MmNsbmgyTVZEZzN0RFF6Wm9NRFNDWkdqeHQwd2FucFJS?=
 =?utf-8?B?SmkxSEdvTHdLekxXMmpZejJhUXpzNXVLL3hudWErV29XdDZEUlVJbC9pekh6?=
 =?utf-8?B?UVRGUENEQSs0U3lBOXpQaWNQV0FkczRxamdqSDBXUE1reWZlejhWQW1kK2Jm?=
 =?utf-8?B?NEREcmI1WkNRYmlPVUVnVVJBT1FYZmViY3RtbXBha0hnZ1R4YU13MHFuWWZG?=
 =?utf-8?B?U2dIWWIzMm9KSzNONWhlcXZXelVCN2xQb0hrZy93ZTJzbTB2cmpmc0Y0NTA3?=
 =?utf-8?B?MWk5cENZYTZ0WkVlUTlWWTJWdDZaYnA1amwvWFphcnp4Q0VSNXhQMnFrUFJi?=
 =?utf-8?B?eWdlZFdpeVpHWjhaRGpLL1FlZ0dmRWx6Z3ZRYjJRdlZoZ3NtaUlaOEJnWlhl?=
 =?utf-8?B?NmYrVnNvKzZtTzdnaXZpTmJxell4RTVmdC81bDlXNDJHZmVRb0hYS0V4THA4?=
 =?utf-8?B?QWZxMzJtblFveGpvV1R3RTJhWGpNemtJK21iaXlBRXlHekFJUS9TQ3h5SVUz?=
 =?utf-8?B?WHFOZ3lLZU9KOHppOHpvclJHRkdyS1pyd09sL2tsQnArY2FGaWw0VGFHb2FT?=
 =?utf-8?Q?KofLirj6UCxrOAjUOwi6Cqiqpayqq8yIsLv9KN8?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bf02d854-f760-4569-25db-08d98ccf54d6
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2021 15:53:56.0084
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Efas8nz/I0Cn1o3mbluf7S8KtF5uglpD4XlUg+7WMsgylkG/GxaSuk4fJQbAGKzekmT1HUqUr3pIH32wQDHDAw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2606

On 24.08.2021 12:50, Anthony PERARD wrote:
> All those files to be removed are already done in the main Makefile,
> either by the "find" command or directly (for $(TARGET).efi).
> 
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>

Acked-by: Jan Beulich <jbeulich@suse.com>



From xen-devel-bounces@lists.xenproject.org Mon Oct 11 15:55:35 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 15:55:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.206287.361819 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZxeI-0007mn-Ct; Mon, 11 Oct 2021 15:55:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 206287.361819; Mon, 11 Oct 2021 15:55:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZxeI-0007mg-9l; Mon, 11 Oct 2021 15:55:34 +0000
Received: by outflank-mailman (input) for mailman id 206287;
 Mon, 11 Oct 2021 15:55:33 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=RBe3=O7=arm.com=Luca.Fancellu@srs-us1.protection.inumbo.net>)
 id 1mZxeH-0007mY-Fg
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 15:55:33 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com (unknown
 [40.107.6.61]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 71581beb-edc9-4671-884b-0dd0b57d88db;
 Mon, 11 Oct 2021 15:55:30 +0000 (UTC)
Received: from DB6PR0301CA0069.eurprd03.prod.outlook.com (2603:10a6:6:30::16)
 by VI1PR08MB2942.eurprd08.prod.outlook.com (2603:10a6:802:20::31)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.15; Mon, 11 Oct
 2021 15:55:19 +0000
Received: from DB5EUR03FT031.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:6:30:cafe::f6) by DB6PR0301CA0069.outlook.office365.com
 (2603:10a6:6:30::16) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.21 via Frontend
 Transport; Mon, 11 Oct 2021 15:55:19 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT031.mail.protection.outlook.com (10.152.20.142) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4587.18 via Frontend Transport; Mon, 11 Oct 2021 15:55:19 +0000
Received: ("Tessian outbound 16951d3c485e:v103");
 Mon, 11 Oct 2021 15:55:19 +0000
Received: from 94ba99320258.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 3B1DA395-307E-4BA3-AA97-144A5D09E5FD.1; 
 Mon, 11 Oct 2021 15:55:09 +0000
Received: from EUR02-HE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 94ba99320258.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Mon, 11 Oct 2021 15:55:09 +0000
Received: from PAXPR08MB6816.eurprd08.prod.outlook.com (2603:10a6:102:130::10)
 by PAXPR08MB6941.eurprd08.prod.outlook.com (2603:10a6:102:135::9)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18; Mon, 11 Oct
 2021 15:55:07 +0000
Received: from PAXPR08MB6816.eurprd08.prod.outlook.com
 ([fe80::c1b4:db1c:376f:b697]) by PAXPR08MB6816.eurprd08.prod.outlook.com
 ([fe80::c1b4:db1c:376f:b697%8]) with mapi id 15.20.4587.026; Mon, 11 Oct 2021
 15:55:07 +0000
Received: from smtpclient.apple (82.8.129.65) by
 LO4P123CA0474.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a8::11) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4587.21 via Frontend Transport; Mon, 11 Oct 2021 15:55:06 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 71581beb-edc9-4671-884b-0dd0b57d88db
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=nrdISgWU1TXTXhiTb6iQpelua/sSvu1oNckl8E8JWC4=;
 b=G12ZE7GuZE72tNVd+/ivY0ayWhTCVpCDO2KikAyWq5cVGHR8vVANDU1XDMiYg9P1H68FcTniCqgbGKvgBR1wqa4PX4kXQr2rVCOOXfsWJDP7iZpb5bGRo2AM045QMM3Sk7rJawyUl0DkMm+ih7srMdV504oHIiZg04VLavuEwpA=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: fc9f24d5ce076af6
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=n1A8+yPdYaTMnCBS7UOnLBXKFJ5fOLfH1fJ4xwwoUw4CTF2te/pfVq1ozq4Jn2++FWR3oIZHFyGsyXG639eC8S++Mb/n7EfF3p6CthS0CBTmywAESpWjNq7YmVTR5p1GYh+fLtv4i/FmXo1Mesxf2/c/uxbwC5dwY6LLaalKBRxVj7RvytTMNlJnxbJ9dUuZhbosbQfyCBySR0Lad7XI7gjfMx1KCBPI5FqslaSP4MeH6NBZ5BECnpr6h8/YdugPVjKb0vHrRNzNrFNR84KvY8Of2nMtFwzpv4JjEoNpnaFmngWOzICY3iYRk3M3XHGw0KktLNRCc7L2OgF0uNuyjw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=nrdISgWU1TXTXhiTb6iQpelua/sSvu1oNckl8E8JWC4=;
 b=kKViQaT65/UgPWnZgT2Q48JB4MAft603iy4m+9hOO/kKRw16eyEM3S15ymxyaLWYPD9ZCdVvTZvHkmwHnIOjc/QMw+73xhJempobgqAe8wEXbRxZ/IkfUP5wj4GfH6eWgeJzMbqe8bgeC31fIv4KjuVCuQtYEZKL09LYK+jcmu/pLNaJu9uQdxs6AxPuHJU7Uz0OcyJSfD3zth200gtt/EcQGlZcN6kFAFNdWn2M07+GGWfVaR5H3nyp+CxTvfpoSu+cHqLOWCnvgR5HwZ6ONH5GBet4biHM/pCN+AaUN7lhzc8JOMRX5hueBE74Na/L+4rZgx5UNPmeUxFkiG+kag==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=nrdISgWU1TXTXhiTb6iQpelua/sSvu1oNckl8E8JWC4=;
 b=G12ZE7GuZE72tNVd+/ivY0ayWhTCVpCDO2KikAyWq5cVGHR8vVANDU1XDMiYg9P1H68FcTniCqgbGKvgBR1wqa4PX4kXQr2rVCOOXfsWJDP7iZpb5bGRo2AM045QMM3Sk7rJawyUl0DkMm+ih7srMdV504oHIiZg04VLavuEwpA=
Authentication-Results-Original: xen.org; dkim=none (message not signed)
 header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
Content-Type: text/plain;
	charset=us-ascii
Subject: Re: [PATCH v5 1/2] arm/efi: Use dom0less configuration when using EFI
 boot
From: Luca Fancellu <luca.fancellu@arm.com>
In-Reply-To: <bfe9cb38-7b06-2d99-2e4a-b5025f4c1ab0@xen.org>
Date: Mon, 11 Oct 2021 16:55:03 +0100
Cc: xen-devel@lists.xenproject.org,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 wei.chen@arm.com,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Ian Jackson <iwj@xenproject.org>,
 Jan Beulich <jbeulich@suse.com>,
 Wei Liu <wl@xen.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <BD1BB549-7146-4062-926D-BA633ADF0006@arm.com>
References: <20211011080302.24203-1-luca.fancellu@arm.com>
 <20211011080302.24203-2-luca.fancellu@arm.com>
 <81e30575-d823-830b-6f80-4e7a7fb4f9ff@xen.org>
 <BC2506EC-8BCD-487C-AFF4-0C99A9020BDA@arm.com>
 <bfe9cb38-7b06-2d99-2e4a-b5025f4c1ab0@xen.org>
To: Julien Grall <julien@xen.org>
X-Mailer: Apple Mail (2.3654.120.0.1.13)
X-ClientProxiedBy: LO4P123CA0474.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:1a8::11) To PAXPR08MB6816.eurprd08.prod.outlook.com
 (2603:10a6:102:130::10)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: e42acbc1-cf90-4841-d974-08d98ccf8673
X-MS-TrafficTypeDiagnostic: PAXPR08MB6941:|VI1PR08MB2942:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS:
	<VI1PR08MB29420469ABE48B633AE91319E4B59@VI1PR08MB2942.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 0fa1L3R5VhEdTUSrZvVm7BjV2BC87kVdFfDCUWhjAQoQPc5sjr6eL5Xvuef9V7lsv5deluFunPvITL4BRKnmNSzXDpRSUTNQAkrV6RZLMV8mn2X8EVS+V4FOGFubFopmlhfT1VIMU2iJcVjxmS4JqEMyeqsO5V6Lo/Us4Z9/fNf/qRpkoOhk/0KPwss3j+xDFohYXca/VlAmfoNZFgC+BgiijaWt+3Ir31dZIjHz3ibTgVCAMNUAoydnk8xPdK70PKs+mOwG1mtFfDvQBY121qfcQVt2KDJ+a36YEn8sFm9Nx1rbQzp6e57cIzqJEUuijsnNrCucg5nt9BgfjhAHS0WacsqPemgHfUP3Dx7QNbakDtVrBFJ1jHBdvCKXXjTBnYaypL2rBJ6+Obf2FAnNb5RUkwx1LEUUNuduX97pR+S2S13s4QQ9rTNl9kt7jWMlBFoCxgeIYRxsadLrSb4KlhZhw7u6fYKV5ODXHbknGiRk2rAAxIcv6tS+IbOnpGTDoHh7SRUZCzwto8gIaQqy4TxWmKEQBUH7GYMRkmU8INhh5tyqJ/5ylEV2eOfI6vU6CHueGPb67wYtbUw+W9ISJN7O5MHntI8dbNy9lyk8V5cO85qf0B7I1lXpIQ0yhteldyTFu5S8qXl51gTmAZRuVz1CjPVjw9CHkan5DU4F/ANxcuoNmvSMCKQBY6Jru3rMhvmtijBa3My0AWBgYNCFRRKe47AfLGmgAlXZYxlb39xFXU6T59mnLM5KYQm1keKR
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB6816.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(53546011)(44832011)(6486002)(6506007)(66556008)(66476007)(66946007)(8676002)(86362001)(8936002)(52116002)(36756003)(508600001)(6916009)(54906003)(26005)(6666004)(316002)(956004)(6512007)(33656002)(4326008)(2906002)(186003)(38350700002)(38100700002)(5660300002)(2616005)(32563001)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6941
Original-Authentication-Results: xen.org; dkim=none (message not signed)
 header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT031.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	75656bf3-7cc0-4482-c103-08d98ccf7f4a
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Eic8cJhvQu0toFcfuPXWpUs6QoYKLMUW6/ugnM2sCz607ziS4x+mIp6De9yIVzk+1funuDzvF9LEzRGJ9VGlMShUcYGA/3cEHPwJJO4KCk6k8nq+/Mrt3b42LFXkxuCYpL8G/ARjzFIOS0dnJ7axUzFpV8Pj6tG0/5bxigGxu7xVoMGhG0gkaAADWweK0yDnwmrD3AwgCfon0WbiQMwt3z3W54y8whdWCEvbewY5bq47sUGORHf464f9ePSy+gWAj7sz1LLf0SP3ETEFdG9svcVVwI+ZuTL94HSam6fv2n/kU1W3erfp0H5bniBAShWP3A1K4Q+Xm5OClH3NGsh/WdydrL042wXJ1QhPyRxmwzNin2vnfGfhLBXAZcZ4x9Oe6u1urznZfx/1xYUoh6bmL9lwJvhdRMvKMYNG+HtBpo6tgfu0GYIDqFdF/7t422eX8bf2aWtDte7W56CQ9S5UHJUI82c4rs5xDlYYgT8C/CM0WGLS2pUqFvu46oA2o0OI4MqoVXTsQ8th6p297BfOOgvYb02V9CKPsmpSmaKl5RmLCLzSAoOse0IBzPwDfDl/FmevQwR7npxdzUx06ZpMJ0Wzg4sCvXIqFnwEuJW5ht++GfyPeDvQcpAjxh5A6TEmJ/OqmI6unRarQT0AHz37FCXIBKHlsZveY+Odh4mjm0gL2tthgPV6AN51GEmBZTfb4WQm3/L7KghxctzVWOXuMepBB+gkYGDtuwYmecsWBeg=
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(36860700001)(82310400003)(4326008)(6486002)(6666004)(33656002)(508600001)(186003)(86362001)(44832011)(47076005)(2616005)(53546011)(956004)(70206006)(6862004)(5660300002)(70586007)(54906003)(356005)(36756003)(336012)(81166007)(6506007)(316002)(2906002)(26005)(8676002)(6512007)(8936002)(32563001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2021 15:55:19.1424
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: e42acbc1-cf90-4841-d974-08d98ccf8673
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT031.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB2942



> On 11 Oct 2021, at 12:32, Julien Grall <julien@xen.org> wrote:
>=20
> Hi Luca,
>=20
> On 11/10/2021 12:23, Luca Fancellu wrote:
>>> On 11 Oct 2021, at 10:39, Julien Grall <julien@xen.org> wrote:
>>>=20
>>> Hi Luca,
>>>=20
>> Hi Julien,
>>> On 11/10/2021 09:03, Luca Fancellu wrote:
>>>> +static bool __init is_boot_module(int dt_module_offset)
>>>> +{
>>>> +    if ( (fdt_node_check_compatible(fdt, dt_module_offset,
>>>> +                                    "multiboot,kernel") =3D=3D 0) ||
>>>> +         (fdt_node_check_compatible(fdt, dt_module_offset,
>>>> +                                    "multiboot,ramdisk") =3D=3D 0) ||
>>>> +         (fdt_node_check_compatible(fdt, dt_module_offset,
>>>> +                                    "multiboot,device-tree") =3D=3D 0=
) )
>>>> +        return true;
>>>=20
>>> A boot module *must* have the compatible "multiboot,module". I would pr=
efer if we simply check that "multiboot,module" is present.
>>>=20
>>> This will also make easier to add new boot module in the future.
>> I thought that also the XSM policy was a multiboot,module so I checked e=
xplicitly for kernel, ramdisk, device-tree that are supported
>> by domU.
>=20
> The XSM policy is indeed a multiboot module and should not be used by the=
 domU.
>=20
>> Do you still think that I should check just for multiboot,module instead=
?
>=20
> Yes please. I think this is not the EFI stub job to check that the most s=
pecific compatible is correct.

Ok, I will push the v6 with this change.

Cheers,
Luca

>=20
> Cheers,
>=20
> --=20
> Julien Grall



From xen-devel-bounces@lists.xenproject.org Mon Oct 11 15:56:12 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 15:56:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.206294.361830 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZxeu-0008Lq-Lo; Mon, 11 Oct 2021 15:56:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 206294.361830; Mon, 11 Oct 2021 15:56:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZxeu-0008Lj-Ik; Mon, 11 Oct 2021 15:56:12 +0000
Received: by outflank-mailman (input) for mailman id 206294;
 Mon, 11 Oct 2021 15:56:11 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=9TNE=O7=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mZxet-0008LY-TI
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 15:56:11 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 77967b8b-7c05-477b-8cbe-fdab0168d741;
 Mon, 11 Oct 2021 15:56:11 +0000 (UTC)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2056.outbound.protection.outlook.com [104.47.12.56]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-34-eR7Z0b3jNHOf181esA_YJg-1; Mon, 11 Oct 2021 17:56:09 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VE1PR04MB6480.eurprd04.prod.outlook.com (2603:10a6:803:11d::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18; Mon, 11 Oct
 2021 15:56:08 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4587.026; Mon, 11 Oct 2021
 15:56:08 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6PR0202CA0068.eurprd02.prod.outlook.com (2603:10a6:20b:3a::45) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.25 via Frontend
 Transport; Mon, 11 Oct 2021 15:56:07 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 77967b8b-7c05-477b-8cbe-fdab0168d741
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1633967770;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=P4fR32Mu8InmyzNkbrp6G63rGpGnTPpRY1tLxjSIr0M=;
	b=LnnNoMsS4bmQfOAujnI26z53IjJ92zyUygqywwRjGHaIl90DPZGhZZN9BG7Y6oc9m3mhGx
	h4zg2z+JL1hxqWatwE8vhREjjYLkhS6kss14zAsSd6UOfrMqVvAUh9Avt0cQVZQxRH6DkK
	dVwqZNj1Mt2aleMKcLLTcZePaUMyUoM=
X-MC-Unique: eR7Z0b3jNHOf181esA_YJg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Bt4kS3S+IkvbvEeHOZtD4vGpOglSXQQs3FBsW3sXtZn4O/EBs0m6rKITYJzU6kO7RXoNBHore0HvC1PuSu/O4XOHtoKS43HSsziv2P4A9Z6kaujX4e4+Z50zyos1u8B+YOSj5t8uG0jZd2S9LIBB49Bll+ABah/1ymWye0TWnFxheBkGlMc5oUN5RAGevTxJPCtGLt15Hcp9QTgJ7aQnKTgQk/hM2a76R8Da0jBf9Z9RH5oiHIwl97p9v3BFsFcRzLJ3fuH5/+H2yJ1R/FBa/Mgi0B8VUsiodhdSYLbOMLVeWRY2z2ph/lnAEBqbLowb8SNvaK+IfTgTW6enwf+SFA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=P4fR32Mu8InmyzNkbrp6G63rGpGnTPpRY1tLxjSIr0M=;
 b=MZzXfTlQm7RPT94sTXCltv83jlRp02aN1zoTDIAqTLVu8pYR89syGba7s8j8ITALhBgW9HKyvVQh976ng4bEFfiMae6InOcyHGzSGueyZXFuO22hItg/jVmhGpk3gZ5MP4eQO0tvBYXVIRY8eQ88xM0khQJIyPOdGBo+w3esSfHTYHIZf53/HYSmmy09LdLOgNGh/YXDuFMG3wD1Mu+2K3yxtiSDkIOIne5CVt+IS31o14G0+w3imWSV6gzlD4TH6SWxuBEKPWc23kwKuCqXJ2f9239oje/SXc7d68yjxxWPO4uKw82c/fXADHrnSuTacaVeoAdi72DQGopa1kITCw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [XEN PATCH v7 38/51] build: use main rune to build host binary
 x86's mkelf32 and mkreloc
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>, Wei Liu
 <wl@xen.org>, xen-devel@lists.xenproject.org
References: <20210824105038.1257926-1-anthony.perard@citrix.com>
 <20210824105038.1257926-39-anthony.perard@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <e2d9d545-4529-fe1d-652d-8f8828838452@suse.com>
Date: Mon, 11 Oct 2021 17:56:06 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <20210824105038.1257926-39-anthony.perard@citrix.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR0202CA0068.eurprd02.prod.outlook.com
 (2603:10a6:20b:3a::45) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 9ebf429c-14cc-4ec4-3543-08d98ccfa391
X-MS-TrafficTypeDiagnostic: VE1PR04MB6480:
X-Microsoft-Antispam-PRVS:
	<VE1PR04MB6480FAAE74F460F74E9968B4B3B59@VE1PR04MB6480.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:529;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	oWu/WAphhozD6+9A5pZhfcqUigaJlaOoao8QMAXrJadaAZOSAL2HoVc4L4mkcV6R/5FhsByqV61bcPwChuPyBbV7oBKMOpwrbapDohMeivrUGgVTT4qebvO9kx0RBCGXKo77b75Vw6f4rwXOG/6gX2aBGlAqi6V+YT9nD5FyXESnIiLrN5AZ6vm1/ZQdFVaS4KQSklTLJ7P+KpM8qsqKlRIv0xJXXui2X/uKr5qQYh8kbI1uB3Vdf2XSWrkiEhM1VIOa7GAnHXupV52wfz6tBAGUItV3Xw/9dLgovssmheHykErAqJm/WI144Hj03MNjQ81RPb4Ck3xzB2HkGUylI3LcgKtEZV1F5OHkFGjc2h1s0VNAXsJHVRF7wxF0/5pcchnmJMc12h9a5DcYPG2+riJbswLdXCfo8eJ9Nj3ETLTQt1ONEiPgb+nZEIDUpHGALeuhI0bSXusYHKj+V0B3gt7d0d/o09wKCgn6gxd/yHvTWOOLNFJYf9UD8dwrRqHPN1sN/pec4bzrXzwE9v48o5VKl4PqjtSiYeUCLIHX5+glLjFwMqQxBDDC52jphCM1gYASSE1yNNf2MG1Cj5rI6T3k7VYqlOvdVT0qdjOZ+F3jJj0d+fdj7QY/Bq4JqANPLHMK5xMI/KXn7a5CmzLseKwM1szzZlMA0N7ACifnkX7JKbiS2kPv2yKc2fJDYlDAhI+UYkq4xSm0L3qyc8qeUSZBqm06MIiFhyXrRZuNeqw=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(2906002)(36756003)(6916009)(53546011)(6486002)(186003)(508600001)(8936002)(26005)(38100700002)(8676002)(86362001)(31696002)(956004)(316002)(16576012)(2616005)(5660300002)(54906003)(4744005)(4326008)(66476007)(31686004)(66946007)(66556008)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?TUtIUmlmQklxQmpTNlQxZHpLLzFBc1pPeVFTdkFpK2RyTGlVWUhnMUhaQjJo?=
 =?utf-8?B?QUl2RFNLYllGYmpJMzdyOEw4T1JFQTN4c2NBcVlFY1RCeGlBam82Y0lIVkU4?=
 =?utf-8?B?M1NyeitXRW9Yd2o3RjJaQW84SnhML0l1UURybTNFZE1ORUZkUGlKUVd5UVN3?=
 =?utf-8?B?SVZvNjhiYnMwZG5sei9Sc0lUYndUZ1FVMG5SYmdwMThTSXk5bndVdVlIS2M4?=
 =?utf-8?B?ZkxZVm9vVzByTnV1VDgwd3ppdGFwN1ozZzdDUEI5cHAwUERaWVV6czlHanNR?=
 =?utf-8?B?Qm9vV2RwSlZQL1pRdWVGTHpmUEdvNlNLWm5EYXJ0cXB4MCtsdktDZXJJU0J4?=
 =?utf-8?B?QVFBbTBvU0R0OXpmYUlEQVdFNC9GTFpVR0J5TnNxbDllRkhwekVYV3ovc1R4?=
 =?utf-8?B?a3h4UXVjd3lvemgwdHMrZGc0TVJjaDBXY09LVWhvWUx2Sk1rUGNlMkUvYTBk?=
 =?utf-8?B?VlVkUC9QS1RMZUZCNmp4MU0xSEVmT2pYOUlqTjZlZHEwaVh6ckFSUW5BckQv?=
 =?utf-8?B?eXRrSVVJVUVGRG9uSlpyTC9Ienp5Y1J3Y2FrS05YU01xVy94RllYUjJRTHlH?=
 =?utf-8?B?QzlBV20vTjNCSk9sc1phRVJUc3k0YktUL0JnblBjYzR1QmxwMXEvaXlZNjcv?=
 =?utf-8?B?SU5hZnoxVGhFRHM2QU53SklaNVhEb3NLSW9RQXVhd3RCMjJOSVZGNWQzbERt?=
 =?utf-8?B?aVBuMi9US3ZmVnBWaSs2aG52Q2xNOXl2VmZ6QWg5amtRL1d6ak0zSytUZmQy?=
 =?utf-8?B?VFFRMFlhK3lUUVFhTzZHNU5GMU9mVHA2QzY2MmJsR2RWRFVWWXBNbmtKdnI2?=
 =?utf-8?B?N3U0TVZoNU1telo2MDBXUEJObC84emt2b2EyNUh2V0pGazV6dUNyV2JhVnQ1?=
 =?utf-8?B?QmE5MDZQMFBveVdzbFp4VDh1WXVUVGl5SXM3aGJsWlZPTm95a2FLTDJxbXRx?=
 =?utf-8?B?RGZPbFRySXZ6dWREd21FMVNweTZGb01qK1ZnNTdGUHBkTk10RmlXanJzRHRz?=
 =?utf-8?B?VnVNd2xyVWNUOE4weDRTZWl2cmRvSzVqU1luaHQ2VTdiajFJcEpxcUVrUCs2?=
 =?utf-8?B?dytTN3lIN0Q3aU93TUdNZnhpNVFZQStyVEdTTTlFZGczeWJZVmpCQ1BjYSs4?=
 =?utf-8?B?QUdyNnNDZXNFeEEydWUxVnZZbmdvbGlKejBQSXhVRjZITnVNYjFUNmorQjVa?=
 =?utf-8?B?WjVVQkRBTlN0TXJBdHRrT3VZZDNhbm5ENXgxTzdZWVFLZ1UxTndQdHlBYzkx?=
 =?utf-8?B?cDIrbEVkRjdBSDl4UkRINHU2TUhDQjZtS0pKN2ZCdzY4cFBBYkhqWnI1eS9D?=
 =?utf-8?B?OXdock9CeUFNUFRlS2l4aHhYeXY4QnVnYWozUTRyY0R4bzV1bHNPMVpITHVk?=
 =?utf-8?B?TkRpZ3IzWVdPbTY1SVRvbkVGMjdUeStqcTBDT1JNOG4xaVJPL2cvZytISkx6?=
 =?utf-8?B?ajQ1OU94VHQxeFFtcEYweEZUYVF5bjYxZnBJM0xGdVNBdTdleXFVdWpoN3pR?=
 =?utf-8?B?UWJSeEE4b0FJOCtVeFdSOWwxV0dFS3RXb3VrOGNMZCs3QWtBcEwzbjNJcFNE?=
 =?utf-8?B?a1RzYzhHaXFHUEhSSTY0MFdUdFpKTTcxelJxWFV3ZXdXSlFYempOYy9PMCtp?=
 =?utf-8?B?cTVUdG1MSkxnSzFIVDFhaHo5YW01ODBJd2xEREJHR0daQkFMc0ZrVWt2UDM5?=
 =?utf-8?B?MFVJNkZPbXU1NG9UTkxaSW13Wm9mTzR3VXA1N0xtY3Z4b2RDNWJRWWZnWTlU?=
 =?utf-8?Q?Az5ttqifBTWRaKB+zfKVqJH1cw8P3HCFWbUW4q5?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9ebf429c-14cc-4ec4-3543-08d98ccfa391
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2021 15:56:08.0586
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: mMiUQmIjc9AVIJ4/FgX1wxnZQNsyoUlM9/i4YJMl0O3TWULOLAj7IMVsbVADHjW7qbW2NiN57nkRIYfdQHyu+g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6480

On 24.08.2021 12:50, Anthony PERARD wrote:
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>

Acked-by: Jan Beulich <jbeulich@suse.com>

> --- a/xen/arch/x86/Makefile
> +++ b/xen/arch/x86/Makefile
> @@ -81,6 +81,10 @@ endif
>  extra-y += asm-macros.i
>  extra-y += xen.lds
>  
> +hostprogs-y += boot/mkelf32
> +HOSTCFLAGS_efi/mkreloc.o := -g

To be honest I don't think this extra option would have been necessary
to retain.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Oct 11 16:05:01 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 16:05:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.206303.361841 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZxnM-0001x6-Iw; Mon, 11 Oct 2021 16:04:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 206303.361841; Mon, 11 Oct 2021 16:04:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZxnM-0001wz-Ef; Mon, 11 Oct 2021 16:04:56 +0000
Received: by outflank-mailman (input) for mailman id 206303;
 Mon, 11 Oct 2021 16:04:55 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=9TNE=O7=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mZxnL-0001wp-KS
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 16:04:55 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id f8417b3a-2aac-11ec-80e9-12813bfff9fa;
 Mon, 11 Oct 2021 16:04:53 +0000 (UTC)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2110.outbound.protection.outlook.com [104.47.18.110])
 (Using TLS) by relay.mimecast.com with ESMTP id
 de-mta-5-cq54twrfOi2qzkfDcZsd4A-1; Mon, 11 Oct 2021 18:04:51 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VE1PR04MB6480.eurprd04.prod.outlook.com (2603:10a6:803:11d::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18; Mon, 11 Oct
 2021 16:04:50 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4587.026; Mon, 11 Oct 2021
 16:04:50 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6PR0202CA0060.eurprd02.prod.outlook.com (2603:10a6:20b:3a::37) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.24 via Frontend
 Transport; Mon, 11 Oct 2021 16:04:50 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f8417b3a-2aac-11ec-80e9-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1633968292;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=+PXozTFInzsIz15RU/C/L0HiOFmqLlUCFDy+c36U7X0=;
	b=fHbqhudgKequ+Kt52VOETxjoGpJiU++pbrW6ZaByUT5KsPIX2lh0QmS/6udA3D6NtEQRU1
	7wfm7yt68BzqjAXKR6735yPULD5dXDsR4jud24DAJBaQ+sf7T527eGYF5fJWaVJNAOdGAe
	g/rVvM12rmWNXjh889Quo//v5YUHL1Y=
X-MC-Unique: cq54twrfOi2qzkfDcZsd4A-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=bpUcyrI/qVOTx9++GQpw3fFzgq9F/W+JE/0fD4KzbVPfh4mSXf0x+lWbCX8ZQZRZRe8smcQadvlx+mEgY7BxYRHv0xK67YQZyAoZ5DtU5aZv5Glkx4m1LB6emk24h+7BXyfNOHhnDj5y1xD+GmYPm9Tjrfryz3IMHNbochR9Luvkz/VTGKPYGEmdaIzd2+3i4ei6XF6RmTkrEP2BjL8D628aVEHMIDrI3/mOtHXzXp3A/tGIFPbd44gWGBiBI5Jw8M1BtyYqtocRpqh9l1dzFbAPqiCeSm0jAnxclqnVS2ky+36J61UswVyStRr+KV95Hdj4ILF6Ek/iHnjqVuxrNA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=+PXozTFInzsIz15RU/C/L0HiOFmqLlUCFDy+c36U7X0=;
 b=ju2uEE9sGKARG2wuU/2MsqwxyvZHV+EiAYGNSCOMI8AZjzwRiUwKugYEYELW3HlT2rvphHeJKFxaAQOX1oNwZ8BINK6u7nHa8AvkjTJ4qwuZW5MF2ufhkZfe57fBuLns6jUaVxZd+IvpTIZ5Wt79CW8i2ZCzHUgKxdTWq/jC6/nMO+86593XoS9MI3npF0HLTSevFjgtiJoJKXedDCTNqAXcF425EDRq3h8mGdSpoiuEw8uvvcIcRj8nwMjdqXG3SUk5dXpAxy91jSrdrdLA2hNgzA+tE1kXYj2YwdWHpNqhdYjYI6Js2oDojEhkPx66R63BahUrIQcy+9oqWrTwuA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [XEN PATCH v7 39/51] build: rework coverage and ubsan CFLAGS
 handling
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>, xen-devel@lists.xenproject.org
References: <20210824105038.1257926-1-anthony.perard@citrix.com>
 <20210824105038.1257926-40-anthony.perard@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <ce84dfbb-aab2-2ca1-3521-22b640c99233@suse.com>
Date: Mon, 11 Oct 2021 18:04:48 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <20210824105038.1257926-40-anthony.perard@citrix.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR0202CA0060.eurprd02.prod.outlook.com
 (2603:10a6:20b:3a::37) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 64c3d82c-94cd-4c87-dfbb-08d98cd0db26
X-MS-TrafficTypeDiagnostic: VE1PR04MB6480:
X-Microsoft-Antispam-PRVS:
	<VE1PR04MB6480C52AF7F2299F163B2985B3B59@VE1PR04MB6480.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	jHNnsCfsvhf+TWi3miKl59G9WlRSGKYaN0W5oGTaUey+fGx++6NpmKWgTKqrkp+s7nxIrAQDs2il+I5kJj7mXYPKQkdwbeyRaI6tAySb0tZ9QdIK8BGl+joqXKEvn0i27xYPEB0XbHFBRXdz0qT0x/sJ+T5ZKJ2zBjLw6pKIxn0o1dBS0Kk34fI0rODTKwWZ6IAByiic4/Kf3mJc5tLI1Yp3sYtCadzxb+j74+YiR1kiaE5LhsmdPk2WAPiqJl/10cZcbgR8vyLJedBnhmsf2MUJ700Z/5lvfwLOGibSCurQvECXIr+KGUk38vIJ8KlSvkjdb5LvyXp4/cvsLmSI4pnKgL4U8ZuYv0pPDi1qkcENag/Pz9qgmIraZtTktyyMiYRa4tUrHg4FGJmgEibV46qHHYEWfKwyFyPpS6d0kgHE5wAfUyjjbQj8vblcPVOvmL/qXFcveymgeHFF+Zd4qvypc1lceI/QlLiw3D1Fq/DpNILIUW/mVWyEA/WWku7PytYObLpAg3YfOkT6g/XAS6abEQi3CqVOBnfNo674artfZkmZawLPQOryLAFPI4204rwH7YtIOsXoOeg69D+eCqbTOHiY7S21VuHa8KTNmUFCnD/1X/DYbYVCH7gl/Gm3geX1c3KQyhWV4Y32YiBSN6t23MNSYWD6T86wyx6c3brnRLP9uAtyxp4byZXobYjNeSaI6ki6DhXLB/ahvjKHhlYqNXmeTidueitTBQr055c=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(956004)(86362001)(31696002)(4326008)(54906003)(66476007)(66556008)(31686004)(66946007)(16576012)(316002)(2616005)(5660300002)(508600001)(6486002)(186003)(2906002)(53546011)(6916009)(36756003)(26005)(83380400001)(38100700002)(8676002)(8936002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?UkN4T1plbmFIK0l3TzQzVzhxQkZHSkpGUXBuWVJ3UnV3YnhJb0FBNjA0UXVm?=
 =?utf-8?B?RE5oWUhtclJiSkVWdm5zVFJsTXNzdmZzRE9FRFhCYXY4WkwzMGgzNEovSnhK?=
 =?utf-8?B?M3E5NE91U1pObThFQmdRNmlrZXRHQXFOREdscElBRXE3UWNQS3RiOXJXWEc4?=
 =?utf-8?B?WVRBQUVvMThIeXdRY0poRThsZ3QyeFhiQjgzNStLRE5YOU4waUhqcXpCNndG?=
 =?utf-8?B?Z25kSFVQZ3B0S2hzU2xVMjg3MVhUbTR2SFQrYVFhWmlPWUdoSEF4RDZzSXdx?=
 =?utf-8?B?djVwODJPeS9ZdFMwMVFxK05NU203TzNoR2xrVVErRUZpSFZ5YjRjblVJK1FB?=
 =?utf-8?B?L21kLzVVMGxNZ2tRZUFsQm1tRjU5VkNXdE9TN2h5L1ZKUU81aEYzNU9JQXZw?=
 =?utf-8?B?b0s4R2ZrSHRXWG96VGk4MG1kQjhPWlVHeHVLKzRyS2plM1JVMkFGUm1uTEdU?=
 =?utf-8?B?SHRURnAyVzljT29iYitURFBZaU9LK21BVWh3c3diQU9CMlBtbVZEbm1aYmIy?=
 =?utf-8?B?TytBdWFuODZsOVJKaml5UlQ2bk5vdXFWNkdrek5KZnlEMG8rQkZINWZDWlNu?=
 =?utf-8?B?MTMxM0hZOXA2UXVpTllRVEE2TXZ1bndUdnA3aU1SNEVUby9lY0hsYTd4djdE?=
 =?utf-8?B?Z01JZWVlUm9RcHNGclhFSUFFY2kwUnFIekxES3ZGelNWNEErbVIzS01VOGs5?=
 =?utf-8?B?QkZhS3hBa3RZamRYNnVwZHIyNlZmZkFVOVVHRXdwUnJLWW9Rd29nZkxSTUFk?=
 =?utf-8?B?aXE5b3QzV0Jtd09XSWNJcFdNcW9GSjVScm5kdkdSYmZNempNVVVuR3FTZUxT?=
 =?utf-8?B?d1BlQkpVR2pLTS9YYWlJbG9iQUcxSC9wanYzaTBFdkowVnpFYWQvdGxub2g5?=
 =?utf-8?B?RUFuT3Fsa25iK01mSjcrOFVQVDZEYWk2YVB3VmNtNzR2QnFKcEd6YlczTXB5?=
 =?utf-8?B?YjdQRmRzbklkVGlZT1NNak1GRkU3RHVzeTBTMWhUQ2ovTE1uMCtrZXVOTmI1?=
 =?utf-8?B?N3l3bUNiZ3ZoTm1CQUU5VE9xWWVnUzZwY0czaWRZdjF5RXMyakp4aWw4Wmhr?=
 =?utf-8?B?cndVN1ZJM0JPOVBlR2hCZk9WSnl4YStJcitnbi9neWN4VG5lcTlvdnZpT0h6?=
 =?utf-8?B?TXBSaWVKQTFEU3pYc0JRNXBlU2pVOXVoVjdwYXZpSDVKdVVmeXJMTlVteW1E?=
 =?utf-8?B?Qkszc29oV0pDeDBPTkRSRUtnTVF2NFhDR2JkK1pUMmFNUmYvZlJUNjFNZEpk?=
 =?utf-8?B?cVRZYmVOaWluUVc2T3RyZmRsWUFuWDFYdjFidDNjQlNJM2RBVVRhS2VVd01m?=
 =?utf-8?B?RHNBeFdXbFdwMFBnYk83NlIvOWlSM2pZSThKdFE4MFQrSllGSlU1cEZXRnZU?=
 =?utf-8?B?ZGZnN01qU2tYOVUzVlZFVmd5L1ArZjQ3U3lQbGdsMWowMTZiZXgyVkR6VE9l?=
 =?utf-8?B?bjFYSGhjcEh5dlRWQ1FYUDErWGp2V2tOak5pY2E0OEJlNThCRlduT1EzL28y?=
 =?utf-8?B?VDZpenByd016T1VQTDRPTkljY3RGbVJmdGN1WVJRWkFaOHhIcnNTZThzUE9E?=
 =?utf-8?B?Wm9rVi9SMkhKR2pyUmlGbTF3Y2lyQTVON293Sk5Xc2tGY1pab3AwK3ZJZmFC?=
 =?utf-8?B?K3owV21sMWJPWXl6WmtGVnYrT1MvVU1QWTJaWW50S29uZFBUT2diaUJmYmpp?=
 =?utf-8?B?Tk9za0pDMkRlQ3BYcnVzeERraUpOOUFGTjMvSkloTHJRdkUvMmhCT3hQNzhk?=
 =?utf-8?Q?blsu6saMttDbSSUfFxCcyA8H3Jc22jKcf7CZhkN?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 64c3d82c-94cd-4c87-dfbb-08d98cd0db26
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2021 16:04:50.8219
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0Ci0R+SzYxBWhXN0gLbH6nCYXrtmE+6BMOpg7G/4VCOohIdhtd9fm//UVplu/CcLThiF1PQP6olyWGWn01e4kw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6480

On 24.08.2021 12:50, Anthony PERARD wrote:
> When assigning a value a target-specific variable, that also affect
> prerequisite of the target. This is mostly fine, but there is one case
> where we will not want the COV_FLAGS added to the CFLAGS.
> 
> In arch/x86/boot, we have "head.o" with "cmdline.S" as prerequisite
> and ultimately "cmdline.o", we don't want COV_FLAGS to that last one.
> 
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>

I think I understand what's going on, so
Reviewed-by: Jan Beulich <jbeulich@suse.com>

It would seem to me though that ...

> --- a/xen/Rules.mk
> +++ b/xen/Rules.mk
> @@ -131,19 +131,31 @@ targets += $(targets-for-builtin)
>  
>  $(filter %.init.o,$(obj-y) $(obj-bin-y) $(extra-y)): CFLAGS-y += -DINIT_SECTIONS_ONLY
>  
> +non-init-objects = $(filter-out %.init.o, $(obj-y) $(obj-bin-y) $(extra-y))
> +
>  ifeq ($(CONFIG_COVERAGE),y)
>  ifeq ($(CONFIG_CC_IS_CLANG),y)
>      COV_FLAGS := -fprofile-instr-generate -fcoverage-mapping
>  else
>      COV_FLAGS := -fprofile-arcs -ftest-coverage
>  endif
> -$(filter-out %.init.o $(nocov-y),$(obj-y) $(obj-bin-y) $(extra-y)): CFLAGS-y += $(COV_FLAGS)
> +
> +$(non-init-objects): _c_flags += $(COV_FLAGS)
> +
> +# Reset COV_FLAGS in cases where an objects as another one as prerequisite
> +$(nocov-y) $(filter %.init.o, $(obj-y) $(obj-bin-y) $(extra-y)): \
> +    COV_FLAGS :=

... pulling this and ...

>  endif
>  
>  ifeq ($(CONFIG_UBSAN),y)
>  # Any -fno-sanitize= options need to come after any -fsanitize= options
> -$(filter-out %.init.o $(noubsan-y),$(obj-y) $(obj-bin-y) $(extra-y)): \
> -CFLAGS-y += $(filter-out -fno-%,$(CFLAGS_UBSAN)) $(filter -fno-%,$(CFLAGS_UBSAN))
> +UBSAN_FLAGS := $(filter-out -fno-%,$(CFLAGS_UBSAN)) $(filter -fno-%,$(CFLAGS_UBSAN))
> +
> +$(non-init-objects): _c_flags += $(UBSAN_FLAGS)
> +
> +# Reset UBSAN_FLAGS in cases where an objects as another one as prerequisite
> +$(noubsan-y) $(filter %.init.o, $(obj-y) $(obj-bin-y) $(extra-y)): \
> +    UBSAN_FLAGS :=

... this up ahead of their respective _c_flags assignments would be
easier to follow, for being more logical (produce, then consume).

Also, as a nit: In the comments do you mean "... where an object has ..."?

Jan



From xen-devel-bounces@lists.xenproject.org Mon Oct 11 16:12:01 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 16:12:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.206312.361852 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZxu7-0003Rw-Be; Mon, 11 Oct 2021 16:11:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 206312.361852; Mon, 11 Oct 2021 16:11:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZxu7-0003Rp-8h; Mon, 11 Oct 2021 16:11:55 +0000
Received: by outflank-mailman (input) for mailman id 206312;
 Mon, 11 Oct 2021 16:11:53 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=rMo6=O7=citrix.com=anthony.perard@srs-us1.protection.inumbo.net>)
 id 1mZxu5-0003Rj-R8
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 16:11:53 +0000
Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id f23bf278-2aad-11ec-80ea-12813bfff9fa;
 Mon, 11 Oct 2021 16:11:52 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f23bf278-2aad-11ec-80ea-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1633968712;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=kHnH15i0qivd7SFggkd8dQ2cplydQdin0DQ90iSslHw=;
  b=bzbEuQT8UszJ/yZaleeV/dGxEZcl48XKPE8VlvgWbjFLWNpBcaokcelb
   uPvDGKZxj/yqXLe0pHf/hIz70dpZ1d5k+1ebhybq2bTWYVi2oUHjWGGA4
   fJhrYM1pt6knKt/IT4S89+9GxI2UOJSA/9ks7NmUNIdO3bkb04WjyqHYV
   4=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: eCdfDTlIc5OpWFhg9EVx3rxgydQlRh8Hnjzdk/Z73LTRuiuCkgBgdHSlw3JSPWkKPcn6aiefCn
 4Vw/G4leb3I9E0sRN07OdxA11PXe3SBCdY3nNQPFzWf8G39W0YA1XtOW764cp7yYEZKvbb92pG
 GClmpo+TSBH23pfvpOe4xwXkhwW7MiImWy4jEokakU/GhntXea7lj76EO/nLgwyltgT+K45six
 we008kkqtn3cC3E9Xb+/mSM7HXoZ5xZ9xKZDCKSylqftcADQV0I14qPlYmzI/X3n/a9GmD3gNR
 7ubYyWxLmSGrii52AWLMOdrT
X-SBRS: 5.1
X-MesageID: 54472851
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:qTz9d6gVDqbXjAV3AGitbFpWX161thYKZh0ujC45NGQN5FlHY01je
 htvXWmEMvyPNzOhKNkgPYqw9E9SsMWBxtU3SQo9r3pjESMb9cadCdqndUqhZCn6wu8v7a5EA
 2fyTvGacajYm1eF/k/F3oAMKRCQ7InQLlbGILes1htZGEk0FU/NtTo5w7Rg29Yx2IDga++wk
 YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq
 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx
 /1wv7auaj4SHpHLibkacTJzPWZMN6lvreqvzXiX6aR/zmXDenrohf5vEFs3LcsT/eMf7WNmr
 KJCbmpXN1ba2rzwkOnTpupE36zPKOHiOp8fvXdxiynUF/88TbjIQrnQ5M8e1zA17ixLNauCO
 5VDOWc2BPjGSzFXK1UUD883pb+lgVbOKRNYhwyb9ZNitgA/yyQuieOwYbI5YOeiT8hPglyRo
 G6A+m3jGwwbL/SW0z/D+XWp7sfXlD7/cJIfEvu/7PECqF+Zy3EXCRYWfUCmuvT/gUm7M/pFI
 kwJ/mw1rK499GSiVNy7VBq9yFaGsQQbQMF4CPAh5UeGza+8yweGBEAUQzhZctskucQqAzsw2
 TehmNfkBidmtrGPfnub+q2JtjO5OSUTLmgqaDcNSE0O5NyLiIMuihPCSP5zHajzicf6cRngz
 jbPoCUgirE7ic8Qy7797V3BmyirpJXCUkgy/Aq/dmuj4hkjPNb9T4Ot4Fnfq/1HKe6xVUKdt
 XIJn8yf6uEmDpyXkiGJBuIXE9mBzuyZPTjrpE9gFpgs6Ryg43emO4tX5VlWOkBtNcoVfC7zV
 0XaswhR+Zx7MWOjaOl8ZIfZI8MuwKv7HNLpTMfIf8FOaZh8cgyA1Cx2bEvW1Gfo+HXAiolmZ
 83dK5z1Sy9HV+I3l1JaWtvxz5cWzAog5lroZaz83kmg85G1SjmnQ7MsZQ7mgv8C0IuIpwDc8
 tB6PsSMyglCXOCWXhQ74bL/PnhRciBlXcGeR9h/M7fZeFI/ST5J5+r5mOt5I+RYc7JpevAkF
 51XcnRTz0bjnjX5IAGOZ2ELhFjHDMsn8yxT0cDBOz+VN5kfjWSHsPd3m3gfJ+BPGAlfIRhcF
 aRtlyKoWKUnd9g/025BBaQRVaQ7HPhRuSqAPjC+fB80dIN6SgrC97fMJ1W0r3lfVnXu7Jdg+
 NVMMz83p7JYHWyO6+6MOZqSI66Z5yBByIqeoWOZSjWsRKkc2NczcHGg5hPGC8oNNQ/C1lOnO
 /W+Wn8lSR32i9ZtqrHh3Pncx6/wSrcWNhcKTgHzsOftXQGHrzXL/GO1eLvRFdwrfDivo/vKi
 CQ856yUDcDra34T69AiTO0xkf5njzYtzpcDpjlZ8LzwRwzDIttdzrOugKGjb4VBme1UvxWYQ
 EWK9oUIMLmFIpq9QlUQOBAkfqKI0vRNwmve6vE8IUPb4i5r/eXYDRUObkfU0CENfqFoNI4Fw
 Ps6vJJE4QKIlRd3YM2NiTpZ9jrQIyVYAbknrJwTHKTilhEvlgNZeZXZByKvuMOPZtxAP1MEO
 DiRgKae1b1QylCbKyg4FGTX3PobjpML4UgYwFgHLlWPu9zEmv5og0EBrWVpFlxYl0wV3fhyN
 25nM1xOCZ+Ppzo41tJeW22MGh1aAEHL8ELG1FZUxnbSSFOlVzKRITRla/qN5k0Q70lVYiNfo
 OOD0G/gXDvnIJPx0y81VRI3ovDvV4UspAjLmcThFMWZBZgqJzHih/b2N2YPrhLmB+I3hVHG+
 rY2rLohN/WjOH5CubA/Bqmbya8UGUKNK2F1SP18+L8EQDPHczao1DnSc028d6uh/RARHZNU3
 yC2Gv9yag==
IronPort-HdrOrdr: A9a23:HynqN62AmmFidJbj7iynYwqjBLYkLtp133Aq2lEZdPUzSL3+qy
 nOpoV+6faQsl0ssR4b9exoVJPufZq+z/5ICOsqU4tKNTOO0AHEEGgI1+rf6gylNyri9vNMkY
 dMGpIObeEY1GIK7voSNjPIceod/A==
X-IronPort-AV: E=Sophos;i="5.85,364,1624334400"; 
   d="scan'208";a="54472851"
Date: Mon, 11 Oct 2021 17:11:34 +0100
From: Anthony PERARD <anthony.perard@citrix.com>
To: Oleksandr Andrushchenko <andr2000@gmail.com>
CC: <xen-devel@lists.xenproject.org>, <julien@xen.org>,
	<sstabellini@kernel.org>, <oleksandr_tyshchenko@epam.com>,
	<volodymyr_babchuk@epam.com>, <Artem_Mygaiev@epam.com>,
	<roger.pau@citrix.com>, <jbeulich@suse.com>, <andrew.cooper3@citrix.com>,
	<george.dunlap@citrix.com>, <paul@xen.org>, <bertrand.marquis@arm.com>,
	<rahul.singh@arm.com>, Oleksandr Andrushchenko
	<oleksandr_andrushchenko@epam.com>, Ian Jackson <iwj@xenproject.org>,
	"Juergen Gross" <jgross@suse.com>
Subject: Re: [PATCH v5 06/10] libxl: Allow removing PCI devices for all types
 of domains
Message-ID: <YWRiNlygslYUEr7u@perard>
References: <20211008055535.337436-1-andr2000@gmail.com>
 <20211008055535.337436-7-andr2000@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20211008055535.337436-7-andr2000@gmail.com>

On Fri, Oct 08, 2021 at 08:55:31AM +0300, Oleksandr Andrushchenko wrote:
> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> 
> The PCI device remove path may now be used by PVH on ARM, so the
> assert is no longer valid.

Is there maybe a patch or a commit you could point to which say that
there can be PCI passthrough on PVH?

> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> Acked-by: Stefano Stabellini <sstabellini@kernel.org>
> Reviewed-by: Rahul Singh <rahul.singh@arm.com>
> Tested-by: Rahul Singh <rahul.singh@arm.com>

In any case,
Acked-by: Anthony PERARD <anthony.perard@citrix.com>

Thanks,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Mon Oct 11 16:13:04 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 16:13:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.206317.361863 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZxvD-00040p-NE; Mon, 11 Oct 2021 16:13:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 206317.361863; Mon, 11 Oct 2021 16:13:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZxvD-00040i-JN; Mon, 11 Oct 2021 16:13:03 +0000
Received: by outflank-mailman (input) for mailman id 206317;
 Mon, 11 Oct 2021 16:13:02 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=LfEM=O7=arm.com=Bertrand.Marquis@srs-us1.protection.inumbo.net>)
 id 1mZxvC-00040U-E9
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 16:13:02 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com (unknown
 [40.107.6.74]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id b3ee4ff4-3300-40d2-ad15-6cd39f2afa34;
 Mon, 11 Oct 2021 16:13:01 +0000 (UTC)
Received: from AM5PR04CA0005.eurprd04.prod.outlook.com (2603:10a6:206:1::18)
 by DBAPR08MB5702.eurprd08.prod.outlook.com (2603:10a6:10:1a3::14) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.24; Mon, 11 Oct
 2021 16:12:58 +0000
Received: from AM5EUR03FT039.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:206:1:cafe::38) by AM5PR04CA0005.outlook.office365.com
 (2603:10a6:206:1::18) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.26 via Frontend
 Transport; Mon, 11 Oct 2021 16:12:58 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM5EUR03FT039.mail.protection.outlook.com (10.152.17.185) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4587.18 via Frontend Transport; Mon, 11 Oct 2021 16:12:58 +0000
Received: ("Tessian outbound 2e7020cc8961:v103");
 Mon, 11 Oct 2021 16:12:57 +0000
Received: from e6baa6345c7a.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 CEAF04C5-0E8D-4B2F-B39B-5A26FC17E779.1; 
 Mon, 11 Oct 2021 16:12:50 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id e6baa6345c7a.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Mon, 11 Oct 2021 16:12:50 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com (2603:10a6:4:74::9)
 by DB8PR08MB4188.eurprd08.prod.outlook.com (2603:10a6:10:b0::18) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.25; Mon, 11 Oct
 2021 16:12:49 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955]) by DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955%4]) with mapi id 15.20.4587.026; Mon, 11 Oct 2021
 16:12:49 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b3ee4ff4-3300-40d2-ad15-6cd39f2afa34
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=zmsZcGbCpd1UA3j1GaBrLYFQDJN2ob9Lwxfs3j+OyVo=;
 b=Wd7qtZDnAVBqFsAIfVdyQ79ouFZ7s0A/hZZAFjwUtBY4PPNFN91eKtC66Qi/vu1J3pH0UWGM8aLWO1GeBQqXC+EFTRxKAOLGk51TUYAqHgOFLWREJ/vcbqYaQJ93w83WZkeJjvIV5Yk3saLid4/TV8SDXVICa86dBkFP0iFbIlY=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: b65b29f6758d7b32
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Nx5nRxYL7/p0FImECYgVavWIWMUi7DTKSswH5nh9P2OZs02qNk8UzJ4CkvDxdgLegyOin+aM2qzqLUo/VZLqxacRkKsEWRmsEEmnFgpP53+bO9ekmYwHtOg2L3zIaeUko8vJ8j36P9SiYGzfJImv3vQNxrt7Mi3kBwKzDmazsH1FGdBh3WoqJoJOwjRtBB7Zals1dHY0wkzO8LW54Ams0I54ox7wy8mScY79sM7ReqTdpbQQvRYWx+XcPy3iRC+GurJvptaza5QduDUaYBO+N5V7f9kSriL6WhSO7C430gagcHBvjGe09UXgVJcxGegGigSoZM91vLbg5FsFsxMr5g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=zmsZcGbCpd1UA3j1GaBrLYFQDJN2ob9Lwxfs3j+OyVo=;
 b=k1H3s9Efhu+T8Un8MncicnMXvyZO8c8W3zKkldRYqOvfKarxJSXn/0XO81HdH5hNmnG6J2knVdHUeiHit/VDznuVPW3zZwDsdm/00woOgNX60jUgH4Hha53/TCvHjmzcQxXSjEB40o4kX7hKZpYiU8glL2pj1gbWAtOq5pFg9nDujnX93uBuCOw36mcVvbjX1k8Yn4H/RFgcEsgg0T/Zivtc+nvv5rvUUtFOW7jZibT+gDggzANqNa8NLNh8GJWV7j+7Nwhd10YFsY6jhsuRjQxDlYRxdB1VmV3rYueHedRW3/e637u3RvCScQMEpERXsi9sg95PwNKcrtBN/ywBzA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=zmsZcGbCpd1UA3j1GaBrLYFQDJN2ob9Lwxfs3j+OyVo=;
 b=Wd7qtZDnAVBqFsAIfVdyQ79ouFZ7s0A/hZZAFjwUtBY4PPNFN91eKtC66Qi/vu1J3pH0UWGM8aLWO1GeBQqXC+EFTRxKAOLGk51TUYAqHgOFLWREJ/vcbqYaQJ93w83WZkeJjvIV5Yk3saLid4/TV8SDXVICa86dBkFP0iFbIlY=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>, Oleksandr
 Andrushchenko <Oleksandr_Andrushchenko@epam.com>
CC: Rahul Singh <Rahul.Singh@arm.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, Andre Przywara <Andre.Przywara@arm.com>,
	Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, Andrew Cooper
	<andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>, Ian
 Jackson <iwj@xenproject.org>, Jan Beulich <jbeulich@suse.com>, Wei Liu
	<wl@xen.org>, Paul Durrant <paul@xen.org>
Subject: Re: [PATCH v5 08/11] xen/arm: Enable the existing x86 virtual PCI
 support for ARM.
Thread-Topic: [PATCH v5 08/11] xen/arm: Enable the existing x86 virtual PCI
 support for ARM.
Thread-Index: AQHXutl3YqS5dHXsYk6KpdKt4d14RavNphKAgABZ5QA=
Date: Mon, 11 Oct 2021 16:12:48 +0000
Message-ID: <4F406854-4F90-48F6-8470-6CCB60A3CB77@arm.com>
References: <cover.1633540842.git.rahul.singh@arm.com>
 <9bdca2cda5d2e83f94dc2423e55714273539760a.1633540842.git.rahul.singh@arm.com>
 <YWQXF2vDaWQvi+bT@MacBook-Air-de-Roger.local>
In-Reply-To: <YWQXF2vDaWQvi+bT@MacBook-Air-de-Roger.local>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3654.120.0.1.13)
Authentication-Results-Original: citrix.com; dkim=none (message not signed)
 header.d=none;citrix.com; dmarc=none action=none header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: 9d897ac1-bd62-4d7a-0476-08d98cd1fdad
x-ms-traffictypediagnostic: DB8PR08MB4188:|DBAPR08MB5702:
x-ms-exchange-transport-forked: True
X-Microsoft-Antispam-PRVS:
	<DBAPR08MB5702CF6E589D0C83DA7008BB9DB59@DBAPR08MB5702.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:10000;OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 wza5m80Q79URnvv1p3w82uvRz/4V7lcGn7HAE4ei5+KrgRzUHTDxsHyONi7VwJpmIlxYcTJVY0sqV2jygWUrz98fmO6ouIOPPbbzNAB+vX0tUQSABL2R/yq42PW6wqBZBUfqkDaIrr8jfQOHoxLqCddd/o7+CWOUIrRRCsmcz9jFLrLPM0uTtfw8U6Uo7yzmJmo5CuPt3kTom1OTLJOZsTVte9gJnyPVUnWtdKD98xIitDTPTpIRMxayOvEW28bUKC3MpeSwt2/kwxNjYFplFE5qN64VClDlRnRuV0wllxAIgbtFxtUbQbwqzLmonSTMTToYeYqox83W7p5vSWqOTEtit6bs6sQOnr1FlmQJy1qxQWnRx9XedQRrS1jWUZ/3QsTM20SqEHc6+EoXdk91/MMqn3VAP8fx4FLqR98YYCadca4DK8Gq2sMupZaHO1i5z28SXOv2K+/CflUdhdkPJJUyGZaXCD6S7P48Z1sGSTZJSdXsG5c2DbhYEYMt8f6cvs+k1H9dHJX7N7buglOlQzFBvMVuxu+nzgiThv4DM0qVBEIytlXX1gCMKtcFksbiNff6BYPDIChO4Us3Dt3gbNFGZSKZinD9EvMB2NnG9VtB1GwmMal9AF03icrlZ/q68LEccVSHy8Yqz50MYAng2Iy4MqM3xSlpPFNiRSHoxCmwiH09SoQhpHXWBYb7Zyui7MZl0t4XFzfNLJEaPFG1wwOdI+9TAl236wR1QcupV/GP3JOi+ix5QxscvL1WRzd70DhzNdP+x2fXSFoN0m0GWg==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB6PR0801MB2024.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(186003)(71200400001)(91956017)(36756003)(2906002)(86362001)(66446008)(64756008)(76116006)(66476007)(53546011)(66556008)(6506007)(8936002)(66946007)(7416002)(6486002)(508600001)(6512007)(2616005)(8676002)(4326008)(316002)(38100700002)(5660300002)(122000001)(33656002)(54906003)(38070700005)(110136005)(26005)(83380400001)(2004002)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-ID: <0B10D9B95326914A83A728B94BB640F2@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB4188
Original-Authentication-Results: citrix.com; dkim=none (message not signed)
 header.d=none;citrix.com; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM5EUR03FT039.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	86173882-41f0-4784-2c3b-08d98cd1f84a
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	QxfLeZPlKdX47NeDdcVdIQ3XKMJWggoqfk4choSWZd7cpAQJ3nY5o1aRuIPbmCxeoVpDGjkwn+CQRIPB5u7V3TyIvsdW36+iXd3hoorOUzcEHhVaYfuJigxXWoAEp5flQLII3iZbgVHMRy2o+kLRY4nIx7Y+fTfbzBUqO13l6yYv4heMyd0gwpzqzuITqTYLAVrvwjBuNc81cCMKbDFfLyvTRu2FBgvEX06BtUpiCMxI/B543j7glO4Au6BcBypvjR4qi7/tx7Z/cNEOmcXxRmCrl3nogD9lcQjy1DINXy6scd1c7vQ9Ui1HuhVgPvK7ZTagjUUfWzzBApeB9NXOfLdTWDyk6MuTVHrdFeZILGgOkYCgBEJsfTGuKAHsCDY+8FiNwKYcyUhJVJRm18q5x/b4iaCTl3iOBo2vZ9wJVLrZvUveiMeshYi18aDG5bgNiXD/5BnAZxSxxkIvcXv1YfJbETxmXMti59s+Q9qsCGOoTUy51dEU5iyHUCx9TXmnWCAMZcbJhXSexkDdkAZEb9vOyCO5tqMa6SelCuqdMWHc1qFy2Tq+7E1NK2nV2TXMrPnrh95YnRzSaukceDmNm11JbM7jomKXAdxzs0+AY472KOBjsibfNhkjRO/y8ccXP117bz/p9/REbgrNJMfM66jATKf1Y/xZzVpItMhB6gkHuiBUVuWt+f7kYc26NDH1Qkv2UCx80eMomP8PmYBt31xtrs2H+99VUP2FDnu/Nr4=
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(86362001)(6512007)(33656002)(336012)(70206006)(54906003)(4326008)(110136005)(70586007)(316002)(81166007)(356005)(82310400003)(2616005)(5660300002)(8676002)(26005)(8936002)(53546011)(83380400001)(2906002)(36756003)(186003)(47076005)(36860700001)(508600001)(6486002)(6506007)(2004002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2021 16:12:58.0965
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 9d897ac1-bd62-4d7a-0476-08d98cd1fdad
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM5EUR03FT039.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR08MB5702

SGkgUm9nZXIsDQoNCj4gT24gMTEgT2N0IDIwMjEsIGF0IDExOjUxLCBSb2dlciBQYXUgTW9ubsOp
IDxyb2dlci5wYXVAY2l0cml4LmNvbT4gd3JvdGU6DQo+IA0KPiBPbiBXZWQsIE9jdCAwNiwgMjAy
MSBhdCAwNjo0MDozNFBNICswMTAwLCBSYWh1bCBTaW5naCB3cm90ZToNCj4+IFRoZSBleGlzdGlu
ZyBWUENJIHN1cHBvcnQgYXZhaWxhYmxlIGZvciBYODYgaXMgYWRhcHRlZCBmb3IgQXJtLg0KPj4g
V2hlbiB0aGUgZGV2aWNlIGlzIGFkZGVkIHRvIFhFTiB2aWEgdGhlIGh5cGVyIGNhbGwNCj4+IOKA
nFBIWVNERVZPUF9wY2lfZGV2aWNlX2FkZOKAnSwgVlBDSSBoYW5kbGVyIGZvciB0aGUgY29uZmln
IHNwYWNlDQo+PiBhY2Nlc3MgaXMgYWRkZWQgdG8gdGhlIFhlbiB0byBlbXVsYXRlIHRoZSBQQ0kg
ZGV2aWNlcyBjb25maWcgc3BhY2UuDQo+PiANCj4+IEEgTU1JTyB0cmFwIGhhbmRsZXIgZm9yIHRo
ZSBQQ0kgRUNBTSBzcGFjZSBpcyByZWdpc3RlcmVkIGluIFhFTg0KPj4gc28gdGhhdCB3aGVuIGd1
ZXN0IGlzIHRyeWluZyB0byBhY2Nlc3MgdGhlIFBDSSBjb25maWcgc3BhY2UsWEVODQo+PiB3aWxs
IHRyYXAgdGhlIGFjY2VzcyBhbmQgZW11bGF0ZSByZWFkL3dyaXRlIHVzaW5nIHRoZSBWUENJIGFu
ZA0KPj4gbm90IHRoZSByZWFsIFBDSSBoYXJkd2FyZS4NCj4+IA0KPj4gRm9yIERvbTBsZXNzIHN5
c3RlbXMgc2Nhbl9wY2lfZGV2aWNlcygpIHdvdWxkIGJlIHVzZWQgdG8gZGlzY292ZXIgdGhlDQo+
PiBQQ0kgZGV2aWNlIGluIFhFTiBhbmQgVlBDSSBoYW5kbGVyIHdpbGwgYmUgYWRkZWQgZHVyaW5n
IFhFTiBib290cy4NCj4+IA0KPj4gU2lnbmVkLW9mZi1ieTogUmFodWwgU2luZ2ggPHJhaHVsLnNp
bmdoQGFybS5jb20+DQo+PiBSZXZpZXdlZC1ieTogU3RlZmFubyBTdGFiZWxsaW5pIDxzc3RhYmVs
bGluaUBrZXJuZWwub3JnPg0KPj4gLS0tDQo+PiBDaGFuZ2UgaW4gdjU6DQo+PiAtIEFkZCBwY2lf
Y2xlYW51cF9tc2kocGRldikgaW4gY2xlYW51cCBwYXJ0Lg0KPj4gLSBBZGRlZCBSZXZpZXdlZC1i
eTogU3RlZmFubyBTdGFiZWxsaW5pIDxzc3RhYmVsbGluaUBrZXJuZWwub3JnPg0KPj4gQ2hhbmdl
IGluIHY0Og0KPj4gLSBNb3ZlIGFkZGl0aW9uIG9mIFhFTl9ET01DVExfQ0RGX3ZwY2kgZmxhZyB0
byBzZXBhcmF0ZSBwYXRjaA0KPj4gQ2hhbmdlIGluIHYzOg0KPj4gLSBVc2UgaXNfcGNpX3Bhc3N0
aHJvdWdoX2VuYWJsZWQoKSBpbiBwbGFjZSBvZiBwY2lfcGFzc3Rocm91Z2hfZW5hYmxlZCB2YXJp
YWJsZQ0KPj4gLSBSZWplY3QgWEVOX0RPTUNUTF9DREZfdnBjaSBmb3IgeDg2IGluIGFyY2hfc2Fu
aXRpc2VfZG9tYWluX2NvbmZpZygpDQo+PiAtIFJlbW92ZSBJU19FTkFCTEVEKENPTkZJR19IQVNf
VlBDSSkgZnJvbSBoYXNfdnBjaSgpDQo+PiBDaGFuZ2UgaW4gdjI6DQo+PiAtIEFkZCBuZXcgWEVO
X0RPTUNUTF9DREZfdnBjaSBmbGFnDQo+PiAtIG1vZGlmeSBoYXNfdnBjaSgpIHRvIGluY2x1ZGUg
WEVOX0RPTUNUTF9DREZfdnBjaQ0KPj4gLSBlbmFibGUgdnBjaSBzdXBwb3J0IHdoZW4gcGNpLXBh
c3N0aG91Z2ggb3B0aW9uIGlzIGVuYWJsZWQuDQo+PiAtLS0NCj4+IC0tLQ0KPj4geGVuL2FyY2gv
YXJtL01ha2VmaWxlICAgICAgICAgfCAgIDEgKw0KPj4geGVuL2FyY2gvYXJtL2RvbWFpbi5jICAg
ICAgICAgfCAgIDQgKysNCj4+IHhlbi9hcmNoL2FybS9kb21haW5fYnVpbGQuYyAgIHwgICAzICsN
Cj4+IHhlbi9hcmNoL2FybS92cGNpLmMgICAgICAgICAgIHwgMTAyICsrKysrKysrKysrKysrKysr
KysrKysrKysrKysrKysrKysNCj4+IHhlbi9hcmNoL2FybS92cGNpLmggICAgICAgICAgIHwgIDM2
ICsrKysrKysrKysrKw0KPj4geGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvcGNpLmMgfCAgMTggKysr
KysrDQo+PiB4ZW4vaW5jbHVkZS9hc20tYXJtL2RvbWFpbi5oICB8ICAgNyArKy0NCj4+IHhlbi9p
bmNsdWRlL2FzbS14ODYvcGNpLmggICAgIHwgICAyIC0NCj4+IHhlbi9pbmNsdWRlL3B1YmxpYy9h
cmNoLWFybS5oIHwgICA3ICsrKw0KPj4geGVuL2luY2x1ZGUveGVuL3BjaS5oICAgICAgICAgfCAg
IDIgKw0KPj4gMTAgZmlsZXMgY2hhbmdlZCwgMTc5IGluc2VydGlvbnMoKyksIDMgZGVsZXRpb25z
KC0pDQo+PiBjcmVhdGUgbW9kZSAxMDA2NDQgeGVuL2FyY2gvYXJtL3ZwY2kuYw0KPj4gY3JlYXRl
IG1vZGUgMTAwNjQ0IHhlbi9hcmNoL2FybS92cGNpLmgNCj4+IA0KPj4gZGlmZiAtLWdpdCBhL3hl
bi9hcmNoL2FybS9NYWtlZmlsZSBiL3hlbi9hcmNoL2FybS9NYWtlZmlsZQ0KPj4gaW5kZXggNDRk
N2NjODFmYS4uZmI5Yzk3NmVhMiAxMDA2NDQNCj4+IC0tLSBhL3hlbi9hcmNoL2FybS9NYWtlZmls
ZQ0KPj4gKysrIGIveGVuL2FyY2gvYXJtL01ha2VmaWxlDQo+PiBAQCAtNyw2ICs3LDcgQEAgaWZu
ZXEgKCQoQ09ORklHX05PX1BMQVQpLHkpDQo+PiBvYmoteSArPSBwbGF0Zm9ybXMvDQo+PiBlbmRp
Zg0KPj4gb2JqLSQoQ09ORklHX1RFRSkgKz0gdGVlLw0KPj4gK29iai0kKENPTkZJR19IQVNfVlBD
SSkgKz0gdnBjaS5vDQo+PiANCj4+IG9iai0kKENPTkZJR19IQVNfQUxURVJOQVRJVkUpICs9IGFs
dGVybmF0aXZlLm8NCj4+IG9iai15ICs9IGJvb3RmZHQuaW5pdC5vDQo+PiBkaWZmIC0tZ2l0IGEv
eGVuL2FyY2gvYXJtL2RvbWFpbi5jIGIveGVuL2FyY2gvYXJtL2RvbWFpbi5jDQo+PiBpbmRleCAz
NjEzOGMxYjJlLi5mYmI1MmY3OGYxIDEwMDY0NA0KPj4gLS0tIGEveGVuL2FyY2gvYXJtL2RvbWFp
bi5jDQo+PiArKysgYi94ZW4vYXJjaC9hcm0vZG9tYWluLmMNCj4+IEBAIC0zOSw2ICszOSw3IEBA
DQo+PiAjaW5jbHVkZSA8YXNtL3ZnaWMuaD4NCj4+ICNpbmNsdWRlIDxhc20vdnRpbWVyLmg+DQo+
PiANCj4+ICsjaW5jbHVkZSAidnBjaS5oIg0KPj4gI2luY2x1ZGUgInZ1YXJ0LmgiDQo+PiANCj4+
IERFRklORV9QRVJfQ1BVKHN0cnVjdCB2Y3B1ICosIGN1cnJfdmNwdSk7DQo+PiBAQCAtNzY3LDYg
Kzc2OCw5IEBAIGludCBhcmNoX2RvbWFpbl9jcmVhdGUoc3RydWN0IGRvbWFpbiAqZCwNCj4+ICAg
ICBpZiAoIGlzX2hhcmR3YXJlX2RvbWFpbihkKSAmJiAocmMgPSBkb21haW5fdnVhcnRfaW5pdChk
KSkgKQ0KPj4gICAgICAgICBnb3RvIGZhaWw7DQo+PiANCj4+ICsgICAgaWYgKCAocmMgPSBkb21h
aW5fdnBjaV9pbml0KGQpKSAhPSAwICkNCj4+ICsgICAgICAgIGdvdG8gZmFpbDsNCj4+ICsNCj4+
ICAgICByZXR1cm4gMDsNCj4+IA0KPj4gZmFpbDoNCj4+IGRpZmYgLS1naXQgYS94ZW4vYXJjaC9h
cm0vZG9tYWluX2J1aWxkLmMgYi94ZW4vYXJjaC9hcm0vZG9tYWluX2J1aWxkLmMNCj4+IGluZGV4
IGM1YWZiZTJlMDUuLmY0Yzg5YmRlOGMgMTAwNjQ0DQo+PiAtLS0gYS94ZW4vYXJjaC9hcm0vZG9t
YWluX2J1aWxkLmMNCj4+ICsrKyBiL3hlbi9hcmNoL2FybS9kb21haW5fYnVpbGQuYw0KPj4gQEAg
LTMwNTMsNiArMzA1Myw5IEBAIHZvaWQgX19pbml0IGNyZWF0ZV9kb20wKHZvaWQpDQo+PiAgICAg
aWYgKCBpb21tdV9lbmFibGVkICkNCj4+ICAgICAgICAgZG9tMF9jZmcuZmxhZ3MgfD0gWEVOX0RP
TUNUTF9DREZfaW9tbXU7DQo+PiANCj4+ICsgICAgaWYgKCBpc19wY2lfcGFzc3Rocm91Z2hfZW5h
YmxlZCgpICkNCj4+ICsgICAgICAgIGRvbTBfY2ZnLmZsYWdzIHw9IFhFTl9ET01DVExfQ0RGX3Zw
Y2k7DQo+IA0KPiBJIHRoaW5rIEknbSBjb25mdXNlZCB3aXRoIHRoaXMuIFlvdSBzZWVtIHRvIGVu
YWJsZSB2UENJIGZvciBkb20wLCBidXQNCj4gdGhlbiBkb21haW5fdnBjaV9pbml0IHdpbGwgc2V0
dXAgdHJhcHMgZm9yIHRoZSBndWVzdCB2aXJ0dWFsIEVDQU0NCj4gbGF5b3V0LCBub3QgdGhlIG5h
dGl2ZSBvbmUgdGhhdCBkb20wIHdpbGwgYmUgdXNpbmcuDQoNCkkgdGhpbmsgYWZ0ZXIgdGhlIGxh
c3QgZGlzY3Vzc2lvbnMsIGl0IHdhcyBkZWNpZGVkIHRvIGFsc28gaW5zdGFsbGVkIHRoZSB2cGNp
DQpoYW5kbGVyIGZvciBkb20wLiBJIHdpbGwgaGF2ZSB0byBsb29rIGludG8gdGhpcyBhbmQgY29t
ZSBiYWNrIHRvIHlvdS4NCkBPbGVrc2FuZHI6IENvdWxkIHlvdSBjb21tZW50IG9uIHRoaXMuDQoN
Cj4gDQo+PiArDQo+PiAgICAgZG9tMCA9IGRvbWFpbl9jcmVhdGUoMCwgJmRvbTBfY2ZnLCB0cnVl
KTsNCj4+ICAgICBpZiAoIElTX0VSUihkb20wKSB8fCAoYWxsb2NfZG9tMF92Y3B1MChkb20wKSA9
PSBOVUxMKSApDQo+PiAgICAgICAgIHBhbmljKCJFcnJvciBjcmVhdGluZyBkb21haW4gMFxuIik7
DQo+PiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gvYXJtL3ZwY2kuYyBiL3hlbi9hcmNoL2FybS92cGNp
LmMNCj4+IG5ldyBmaWxlIG1vZGUgMTAwNjQ0DQo+PiBpbmRleCAwMDAwMDAwMDAwLi43NmMxMmI5
MjgxDQo+PiAtLS0gL2Rldi9udWxsDQo+PiArKysgYi94ZW4vYXJjaC9hcm0vdnBjaS5jDQo+PiBA
QCAtMCwwICsxLDEwMiBAQA0KPj4gKy8qDQo+PiArICogeGVuL2FyY2gvYXJtL3ZwY2kuYw0KPj4g
KyAqDQo+PiArICogVGhpcyBwcm9ncmFtIGlzIGZyZWUgc29mdHdhcmU7IHlvdSBjYW4gcmVkaXN0
cmlidXRlIGl0IGFuZC9vciBtb2RpZnkNCj4+ICsgKiBpdCB1bmRlciB0aGUgdGVybXMgb2YgdGhl
IEdOVSBHZW5lcmFsIFB1YmxpYyBMaWNlbnNlIGFzIHB1Ymxpc2hlZCBieQ0KPj4gKyAqIHRoZSBG
cmVlIFNvZnR3YXJlIEZvdW5kYXRpb247IGVpdGhlciB2ZXJzaW9uIDIgb2YgdGhlIExpY2Vuc2Us
IG9yDQo+PiArICogKGF0IHlvdXIgb3B0aW9uKSBhbnkgbGF0ZXIgdmVyc2lvbi4NCj4+ICsgKg0K
Pj4gKyAqIFRoaXMgcHJvZ3JhbSBpcyBkaXN0cmlidXRlZCBpbiB0aGUgaG9wZSB0aGF0IGl0IHdp
bGwgYmUgdXNlZnVsLA0KPj4gKyAqIGJ1dCBXSVRIT1VUIEFOWSBXQVJSQU5UWTsgd2l0aG91dCBl
dmVuIHRoZSBpbXBsaWVkIHdhcnJhbnR5IG9mDQo+PiArICogTUVSQ0hBTlRBQklMSVRZIG9yIEZJ
VE5FU1MgRk9SIEEgUEFSVElDVUxBUiBQVVJQT1NFLiAgU2VlIHRoZQ0KPj4gKyAqIEdOVSBHZW5l
cmFsIFB1YmxpYyBMaWNlbnNlIGZvciBtb3JlIGRldGFpbHMuDQo+PiArICovDQo+PiArI2luY2x1
ZGUgPHhlbi9zY2hlZC5oPg0KPj4gKw0KPj4gKyNpbmNsdWRlIDxhc20vbW1pby5oPg0KPj4gKw0K
Pj4gKyNkZWZpbmUgUkVHSVNURVJfT0ZGU0VUKGFkZHIpICAoIChhZGRyKSAmIDB4MDAwMDBmZmYp
DQo+PiArDQo+PiArLyogRG8gc29tZSBzYW5pdHkgY2hlY2tzLiAqLw0KPj4gK3N0YXRpYyBib29s
IHZwY2lfbW1pb19hY2Nlc3NfYWxsb3dlZCh1bnNpZ25lZCBpbnQgcmVnLCB1bnNpZ25lZCBpbnQg
bGVuKQ0KPj4gK3sNCj4+ICsgICAgLyogQ2hlY2sgYWNjZXNzIHNpemUuICovDQo+PiArICAgIGlm
ICggbGVuID4gOCApDQo+PiArICAgICAgICByZXR1cm4gZmFsc2U7DQo+PiArDQo+PiArICAgIC8q
IENoZWNrIHRoYXQgYWNjZXNzIGlzIHNpemUgYWxpZ25lZC4gKi8NCj4+ICsgICAgaWYgKCAocmVn
ICYgKGxlbiAtIDEpKSApDQo+PiArICAgICAgICByZXR1cm4gZmFsc2U7DQo+PiArDQo+PiArICAg
IHJldHVybiB0cnVlOw0KPj4gK30NCj4gDQo+IFRoZXJlJ3MgYSB2cGNpX2FjY2Vzc19hbGxvd2Vk
IHdoaWNoIEkgdGhpbmsgeW91IGNvdWxkIGdlbmVyYWxpemUgYW5kDQo+IHVzZSBoZXJlLCB0aGVy
ZSdzIG5vIG5lZWQgdG8gaGF2ZSB0aGlzIGR1cGxpY2F0ZWQgY29kZS4NCg0KSXQgZGVmaW5pdGVs
eSBsb29rcyBleGFjdGx5IGxpa2Ugd2hhdCB3ZSB3YW50IHRvIGRvLg0KDQpJIHdvdWxkIG5lZWQg
dG8gdHVybiB0aGlzIGludG8gYSBzdGF0aWMgaW5saW5lIGFuZCBwdXQgaXQgaW4gc29tZSBnbG9i
YWwgaGVhZGVyLg0KSXQgaXMgY3VycmVudGx5IGluIGFyY2gveDg2L2h2bS9pby5jLCBhbnkgc3Vn
Z2VzdGlvbiBvbiB0aGUgaGVhZGVyIHRvIG1vdmUgaXQgdG8gPw0KDQpSZWdhcmRzDQpCZXJ0cmFu
ZA0KDQo+IA0KPiBUaGFua3MsIFJvZ2VyLg0KDQo=


From xen-devel-bounces@lists.xenproject.org Mon Oct 11 16:16:28 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 16:16:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.206325.361874 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZxyU-0004gu-5l; Mon, 11 Oct 2021 16:16:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 206325.361874; Mon, 11 Oct 2021 16:16:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZxyU-0004gn-2V; Mon, 11 Oct 2021 16:16:26 +0000
Received: by outflank-mailman (input) for mailman id 206325;
 Mon, 11 Oct 2021 16:16:25 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=LRsb=O7=epam.com=prvs=0918241709=oleksandr_andrushchenko@srs-us1.protection.inumbo.net>)
 id 1mZxyT-0004gh-1D
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 16:16:25 +0000
Received: from mx0a-0039f301.pphosted.com (unknown [148.163.133.242])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 93cd3c5a-2aae-11ec-80eb-12813bfff9fa;
 Mon, 11 Oct 2021 16:16:23 +0000 (UTC)
Received: from pps.filterd (m0174678.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 19BFEWfe009402; 
 Mon, 11 Oct 2021 16:16:21 GMT
Received: from eur01-he1-obe.outbound.protection.outlook.com
 (mail-he1eur01lp2052.outbound.protection.outlook.com [104.47.0.52])
 by mx0a-0039f301.pphosted.com with ESMTP id 3bmqr3096c-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Mon, 11 Oct 2021 16:16:20 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by AM9PR03MB6881.eurprd03.prod.outlook.com (2603:10a6:20b:286::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.25; Mon, 11 Oct
 2021 16:16:17 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::b034:334a:abf5:223c]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::b034:334a:abf5:223c%7]) with mapi id 15.20.4587.026; Mon, 11 Oct 2021
 16:16:17 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 93cd3c5a-2aae-11ec-80eb-12813bfff9fa
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=chtDU1NmVTmeZRjR6urNcfsvOl47MdCCvKj/+mG7MfJYU5yihrOHWUTtza7ipmeZHZSWtyMBOHTatNmzYVEjTkAz18z/4HOytnuWjVCZl6ZqE3z0OOjTrJXd3/nx62iIYxZOAT6/I+/PdlM7O2TsLj2dud6fHR+ET5kF2Fq6sWFpkAysXx9dnT4fFiNUAOqztRwVIU/XtxwPle7KiaQdk3cRle14xycOqAoiPOHeb8wTCZzPI9n2NT4HYbBNmguOewi5EhdYL/bBfPY0yv2Okz1mQsVoJDyBOCo2duW9lB9oQ76LZ07ac08eQIYCfS582y/37XphALRWICoOOsQAxw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=opmmnLgmNord4MESRcZ/0c2q1Ou/q6r/Dq9d/JpNBeQ=;
 b=SgAyH6OSmtArETsaSnILxLM4MKRmC+3uAN899MoDoLzBMvA+F6laNHu1yvhUUXejWfCcSPEDsJvmpOwmMe8FG0s9jg1gL8xOWyDnjDIvAAzuHJcEBim0YhK53T22YGzRopVWUbW4gCCEYIw6+h1OKP6jWcLxgoWrBLh3RvDyIaVasYKT2diTJSMhHuBo/9zRMPp2hdf6sSJtzVGpg4Ida6QoSB111aJPFz6G6RzOf+g30lhqaeBb/V0Pa0nLDSUFxTYXgQesO2kH9yF08w1lfZWUNHlMEzFEWnqBvyTj3Daq20HeVUmhPkGXqaL8x5shqzRgnunZFWluputrnVXNiQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=opmmnLgmNord4MESRcZ/0c2q1Ou/q6r/Dq9d/JpNBeQ=;
 b=19R6LheuD5DyeLO7ja7wQxbMkbpVlNas7+u4SstkImrbRaSS3TgDYYMXKtE/V+KjtS3DJv7J+fwwE8tYwA5JQjUSAAIqBEclDQy89/BW/TX4964EmRpEfHJEHWIiyuirVxnbgHUL0Uwh7Ts2ot9iKO7mTDiOlzFLqz2J+0goWWPc8S4v/80dhUQTAEUb8zv2WZUJd8Rw6RaP8MnKwBIiwi+HDsguAQF7lcpk2pm1rBbm+1Xn0M5qN5md99Xpb2+neQ/fUXCbpv40Y4yRpmQm4k5LVqgoRPGzIzUIAsiEpCcbxP/MHAu9cajCajlFIwBGbPOrur2vaL8zBaXf/l6+VA==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Anthony PERARD <anthony.perard@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org"
	<sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "roger.pau@citrix.com" <roger.pau@citrix.com>,
        "jbeulich@suse.com"
	<jbeulich@suse.com>,
        "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
        "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
        "paul@xen.org"
	<paul@xen.org>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Rahul Singh
	<rahul.singh@arm.com>, Ian Jackson <iwj@xenproject.org>,
        Juergen Gross
	<jgross@suse.com>,
        Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH v5 06/10] libxl: Allow removing PCI devices for all types
 of domains
Thread-Topic: [PATCH v5 06/10] libxl: Allow removing PCI devices for all types
 of domains
Thread-Index: AQHXvAknnKigXkenfkWfROoBKCqE16vN/T8AgAABUAA=
Date: Mon, 11 Oct 2021 16:16:17 +0000
Message-ID: <64d11e9e-2d33-ef97-ec90-f39b88ace727@epam.com>
References: <20211008055535.337436-1-andr2000@gmail.com>
 <20211008055535.337436-7-andr2000@gmail.com> <YWRiNlygslYUEr7u@perard>
In-Reply-To: <YWRiNlygslYUEr7u@perard>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
authentication-results: citrix.com; dkim=none (message not signed)
 header.d=none;citrix.com; dmarc=none action=none header.from=epam.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 0009c663-8e89-4fb0-a295-08d98cd27465
x-ms-traffictypediagnostic: AM9PR03MB6881:
x-ms-exchange-transport-forked: True
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <AM9PR03MB688145A6E8719AA7BEECF3E6E7B59@AM9PR03MB6881.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:2089;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 6seTlB/uL2w77vwBSq9g2/nc4gizCe5wPC+taZQcqpUWDHbaWdwC1UusUKEKBeO8vzuuR8avnR0sR7Z+JafYrHJ2rhp+E4enafKHon/WTyxsSZYC0JF+hBLzSsDt6ARFjx0866Xn9T7Rj0O/Q0h1PfoGd+2IQIG4HmaqgrNWbeYD2AFDYbjyWQObp4zGFw4u7gdbxK9p/3bwQBOXPlmdVe7dqIdysDhZ1FdB4usRuYsAxNNqIfuLrvPXNsZ9gqVOq4Ff0XWg3s9dv8Ccp5fLzBMxuyg4BaA7Iu6DLNoo6wanTFjHNuMQxYuhY6jF3rLfrIQhJvn1A+C7jC1Uo0Q1D+YuquDoqtYIEo4ryH/+BYu/WLi6nhuSffYoP5E5zXX96XBsxDD60SLlgvJ8DbADYeU/XftihcY0PNfbx7xFfOzYYGTlgQKAaZXXtiWB1TJGd7MlT3Zk1mhXVPPL9nXH9aCjn0t2thrniqA4ZCkoWgVeRJx2U1MbLZd6i+AzjRqQBUp754s1nuW+xtOvXToEY05VzPX9nfi31/zdUwMRjqq1P3RRQOzJcZsQLqsPLJ8IztHXM8dnKGtijzaWqM5E3gIwFwNiZndkoXhsaAiFQL1D2uUc8rpNKS45srutwKCzgbwEtiTsmkjAjHO43pI14iLWLQvHx6lJZnSXiEhes6QJChrQn1yeulLwQC3XEIvN80zZpO6BJExo8oWUUIzgCBqg6aoXoofYK3LYL/pufJf23j8fUOHAm8RscMJLl3Bj
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(6486002)(76116006)(91956017)(66946007)(55236004)(53546011)(6506007)(31686004)(31696002)(38070700005)(64756008)(66476007)(66556008)(66446008)(36756003)(107886003)(4744005)(6512007)(86362001)(54906003)(2616005)(5660300002)(26005)(186003)(2906002)(6916009)(71200400001)(508600001)(7416002)(4326008)(8676002)(122000001)(38100700002)(316002)(8936002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?Smh5MVpNK1V1Zm9iczdaSXlqWTRhNGt0Z0p6TGVYS3NrRExqa2pSV3dGRDlr?=
 =?utf-8?B?RTIxVEVKYTRPdXZtZmtiWE11Y3d6cU1XcW50TnRYZ0xMRk43NmY3K2tMOHRm?=
 =?utf-8?B?R2RuVGJJUEF6WDdGQ2dtTnFGMStSL1NMUmd2anRqQjZYQm1jaGRkQVBhT2Vp?=
 =?utf-8?B?Zy9MbHpLREpwVkFOaHp0eExRNFRIRmJXNXdtMzVVSGo1WWV0dE5MdUdOb29V?=
 =?utf-8?B?ZStSaFRKZmMyQVJwZWVvT1MzbjlzTFZreUNMbHU2dnNRUEVOdGV5UTdTUmFF?=
 =?utf-8?B?ZFVBY2JKMDBiN1RnUlh1QkREWGVuVmJaUXJ5dTJ3bURvaXBGenFUbTdXNnAx?=
 =?utf-8?B?UUVNUjlqREkxNHdxdHlFL1lkWFVKcjVxWE4vL0NaVFJDYmxQbC9JbEtML01L?=
 =?utf-8?B?dDF6UE50bU9NZkw5VWJYWUVwZ2hOU1RtelZOdytpdjZQSTdqM3ZJamQwZ2d0?=
 =?utf-8?B?VkRJMDZXR2dUcXNBYkJYVWVBb3hzWDJwdUpOTU92dnJSaTlCV2NpNzFGTmJj?=
 =?utf-8?B?TURYeW1oWW1MUnJXNldDdUQzWGhMRXZlSjA5S0dVcXYwRUo0M01URnF3c0Qw?=
 =?utf-8?B?TkprdWhsZndENDc3MzhWc0NuU1B1SzNkYlZObU9lblFCM2tVYUpBQW1QQnFo?=
 =?utf-8?B?VzJoaFVMNm9kV1JVQzYrd1Z1ZHdHd0dTT1B0T3NLRThSRjZNZUdXSU5rUXAx?=
 =?utf-8?B?NTVrMGNzaW0vVTZvWitqTk1rK1FIRFkxa1NOK1ZvYXBZaW56dnorekcvQjc0?=
 =?utf-8?B?b29qaXBPb3ZIMG1DUEVHWTZZdS95aGdRc3B3c0c1djJkbmtIblFBM3EwUW9s?=
 =?utf-8?B?cnVFeTE1VjRndmFBRGh2SW04SG5KZTJ1MFVDYUs1djI0Z29kOHN4UXJQamEr?=
 =?utf-8?B?eGFidjFuYnAzR21ybmxjZEIvVm1NSlBpbFpOWThFM3pHclpDWnQ1dnBubFB3?=
 =?utf-8?B?T1cyY1Iwd0hBSUtPOUswc29GVVQwSVFueVMxNWIvcTBubDBjQWlhS05USDNk?=
 =?utf-8?B?ajhZaVVhekR0STRWdG5GRmpFR0V4OW9qaDVnQXdnbTk1aDNEK05WaXF2WUht?=
 =?utf-8?B?Y2RCK0liaWtkd2FmTlJMVXNRb3FzUzFHMHBCakRrWU5jTll5RmZFdHZZdmFt?=
 =?utf-8?B?dzZUV3pHa0dZUzNlTVB1S2dTR0RpODJLY1BDeldJbXNERlpOOHBHZmlGNVIz?=
 =?utf-8?B?RlVucFlIb296VituQ1hwWHJOMWg5UGtMdHhkMzcyL3ROTzVVRCtvR3ZVMFRX?=
 =?utf-8?B?SlIxRHRYT0hDdWx6NGlzdko4cU11OG1JNXRzajdEa2lYU3IvcC9HcXhXZVkz?=
 =?utf-8?B?dEkxRlhiZ0pYUnMrTDd1aFJ2ZW15L0VEbyt5RmVQMkd2YTZja1orWUZWbHJG?=
 =?utf-8?B?aVc5aFc5MEVGM24vSnhXaHVPZVFUU2s4elkrRmdGNzlUN0lKdXh4WEdIM1l5?=
 =?utf-8?B?V3B2Y0ZSc0N5WnltT2x3VlJGSzl5d1VDdGRTRk9hQnB3cW1yNEtjbWhPZVFW?=
 =?utf-8?B?YWlhT2VYT0VRY1p3SFVQTUhueE5GUFhqTWU0YjVJQmd5OUhSOHJLdER0NENn?=
 =?utf-8?B?d1N5d1VzL3FKbGgyd2d1dzk0L2RCMmx3aDR4UmZHS0swaFdxWG1GOVVPR25X?=
 =?utf-8?B?UXNYR2ZqYkFNMmNuc2Fkd0N0RDV4QVZXbEc4SHZtYzQ1UTd4T0F3UjUrSUlx?=
 =?utf-8?B?SWdaMGlpekFobGUraWJ6SFdCb2M5Y1ZDanVPTGdYSmEyTnNvSmxNNkJkQmps?=
 =?utf-8?B?KytGWGE0MHJUUnlRUU9nSFFaRnEyUEFySFRWalhxcllCa1hjQ2xldDA2UUpp?=
 =?utf-8?B?T3lwMHhNQ3phUGFxWW10Zz09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <53597041E98CDB4C8627A2C7DB49ADE6@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0009c663-8e89-4fb0-a295-08d98cd27465
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Oct 2021 16:16:17.2190
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: apABaO7EENzQ/NklDXR4ahC16pXCX2ii5VmI7MuXqSQNjGbiBZB2HIrHxzuPO4AoOQ1HExf7b/RFnjoGTGnNkhY5UujSZfbdiB6Lor5/xdaF1rlVkb3Qh0odqV3wQT/F
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR03MB6881
X-Proofpoint-ORIG-GUID: 2igyoJ1BuCEjTW1kLkRWxipnt1v7ubIf
X-Proofpoint-GUID: 2igyoJ1BuCEjTW1kLkRWxipnt1v7ubIf
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475
 definitions=2021-10-11_05,2021-10-11_01,2020-04-07_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 suspectscore=0
 bulkscore=0 mlxscore=0 lowpriorityscore=0 adultscore=0 phishscore=0
 mlxlogscore=847 priorityscore=1501 impostorscore=0 clxscore=1011
 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2109230001 definitions=main-2110110096

SGksIEFudGhvbnkhDQoNCk9uIDExLjEwLjIxIDE5OjExLCBBbnRob255IFBFUkFSRCB3cm90ZToN
Cj4gT24gRnJpLCBPY3QgMDgsIDIwMjEgYXQgMDg6NTU6MzFBTSArMDMwMCwgT2xla3NhbmRyIEFu
ZHJ1c2hjaGVua28gd3JvdGU6DQo+PiBGcm9tOiBPbGVrc2FuZHIgQW5kcnVzaGNoZW5rbyA8b2xl
a3NhbmRyX2FuZHJ1c2hjaGVua29AZXBhbS5jb20+DQo+Pg0KPj4gVGhlIFBDSSBkZXZpY2UgcmVt
b3ZlIHBhdGggbWF5IG5vdyBiZSB1c2VkIGJ5IFBWSCBvbiBBUk0sIHNvIHRoZQ0KPj4gYXNzZXJ0
IGlzIG5vIGxvbmdlciB2YWxpZC4NCj4gSXMgdGhlcmUgbWF5YmUgYSBwYXRjaCBvciBhIGNvbW1p
dCB5b3UgY291bGQgcG9pbnQgdG8gd2hpY2ggc2F5IHRoYXQNCj4gdGhlcmUgY2FuIGJlIFBDSSBw
YXNzdGhyb3VnaCBvbiBQVkg/DQpVbmZvcnR1bmF0ZWx5IG5vLCB0aGlzIGlzIHdoYXQgYWxsIHRo
ZSBQQ0kgc2VyaWVzIG9uIEFybSBhcmUgZm9yDQo+DQo+PiBTaWduZWQtb2ZmLWJ5OiBPbGVrc2Fu
ZHIgQW5kcnVzaGNoZW5rbyA8b2xla3NhbmRyX2FuZHJ1c2hjaGVua29AZXBhbS5jb20+DQo+PiBB
Y2tlZC1ieTogU3RlZmFubyBTdGFiZWxsaW5pIDxzc3RhYmVsbGluaUBrZXJuZWwub3JnPg0KPj4g
UmV2aWV3ZWQtYnk6IFJhaHVsIFNpbmdoIDxyYWh1bC5zaW5naEBhcm0uY29tPg0KPj4gVGVzdGVk
LWJ5OiBSYWh1bCBTaW5naCA8cmFodWwuc2luZ2hAYXJtLmNvbT4NCj4gSW4gYW55IGNhc2UsDQo+
IEFja2VkLWJ5OiBBbnRob255IFBFUkFSRCA8YW50aG9ueS5wZXJhcmRAY2l0cml4LmNvbT4NClRo
YW5rIHlvdSwNCk9sZWtzYW5kcg0KPiBUaGFua3MsDQo+DQo=


From xen-devel-bounces@lists.xenproject.org Mon Oct 11 16:20:32 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 16:20:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.206337.361884 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZy2M-00069a-Pm; Mon, 11 Oct 2021 16:20:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 206337.361884; Mon, 11 Oct 2021 16:20:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZy2M-00069T-Mr; Mon, 11 Oct 2021 16:20:26 +0000
Received: by outflank-mailman (input) for mailman id 206337;
 Mon, 11 Oct 2021 16:20:25 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=LRsb=O7=epam.com=prvs=0918241709=oleksandr_andrushchenko@srs-us1.protection.inumbo.net>)
 id 1mZy2L-00069N-Bl
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 16:20:25 +0000
Received: from mx0b-0039f301.pphosted.com (unknown [148.163.137.242])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id a1689fb1-0d63-427e-a7cf-70c2a9b7af2b;
 Mon, 11 Oct 2021 16:20:23 +0000 (UTC)
Received: from pps.filterd (m0174683.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.0.43) with SMTP id 19BEhUJp025659;
 Mon, 11 Oct 2021 16:20:18 GMT
Received: from eur01-ve1-obe.outbound.protection.outlook.com
 (mail-ve1eur01lp2053.outbound.protection.outlook.com [104.47.1.53])
 by mx0b-0039f301.pphosted.com with ESMTP id 3bmpssgkf8-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Mon, 11 Oct 2021 16:20:17 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by AM9PR03MB6963.eurprd03.prod.outlook.com (2603:10a6:20b:2d5::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.21; Mon, 11 Oct
 2021 16:20:14 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::b034:334a:abf5:223c]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::b034:334a:abf5:223c%7]) with mapi id 15.20.4587.026; Mon, 11 Oct 2021
 16:20:14 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a1689fb1-0d63-427e-a7cf-70c2a9b7af2b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Cz1PnQTXBYSYHcanyL588c4QBMu1XDN3B/OcUVTFlHsZjENutNS/7p57qpFj0vE91NLtQVEwaO5xVHzal+RrJkB7CVSy8eAZ+ZoIhO3Zc92ouQeE+2renBfF9JwFdzrKMG/SR8A8Ly0BqccnkFF7rDcIEWzR1VrDCjgshwZcjGWQAodWIey9ygJO0untVNEiV/lSQm0iQPY7nmnUeSIHDwxIoCZYbUhHRBfUC2ZwZcJh2bv8UJi2x4a3DTvsULjLej/tfKbWpzqhr6VxMdGZwfRqgHuRcn0A4EVCWWYm4d5eTasIeneIDEGkxEFAEE4oSMCwO55vFuQgNacfpaITFQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=uyoOfCakYnnr3RrSHSR7TnLzSJcS8zCYW2lgzjlKma8=;
 b=T4T5fqcLg5VDFEVKrwkUOjxkkGHPnRqEjlREcQ7/B0oFACylZGrJSCP7707eGa0HvvRAn463BZJ9F/Nd1Kuveqi40LdJ6iPW1iNVm4DOwXap8coXKALwI1VmVuC4/OSB77Ai4GS5YouI1ep4JQanp46geHi2glcyOJwfJ1e41D06L0hx4YHCjJPZm2nAKXMzfn0DovnuSK6z0KJaXJlKFnPjNj0y5wBZ9A1gVWoGLldLPOPYM/7mcChotBIhZ1qaiOh1w3YvEGgbyjqeCax0fp29MPZcraU0z6N02yd7QewHYLoyCpOjE2qTXAsOWzAo7TIFRFLLecvjYUIr63AWNQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=uyoOfCakYnnr3RrSHSR7TnLzSJcS8zCYW2lgzjlKma8=;
 b=Mo0E0hzs5rwVUTbDH3Imfex1UT5hcMP51UHGqJQID6ADpAw62j07u857C64bBjN7R41zpEb+cN6de/TLLams3i7QVwkXP2mv7UFiC9bNajOfeQhPiCFaCAdlTVq+r272j06/HCLqY/7cL+1C5xHh848ciSNBEih1c86hMSaWHFPKmVeteS6SbHYgx629yMVyf2y0KqAsOYG1dGQr9WM6Pr4wzB4Dc9KHoCZR0+2CkH6kxEWt+VP7A2jojoMolA9o5d+tH00m7CVdJennJobQHsS/6CkWKXj3uRe9CWicnj/y/dkME1IvAbHD+lK+ZsiCH/AD10YazEiELJJVzfGUKg==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Bertrand Marquis <bertrand.marquis@arm.com>,
        =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>
CC: Rahul Singh <rahul.singh@arm.com>,
        "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>,
        Andre Przywara <Andre.Przywara@arm.com>,
        Stefano Stabellini <sstabellini@kernel.org>,
        Julien Grall <julien@xen.org>,
        Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
        Andrew Cooper
	<andrew.cooper3@citrix.com>,
        George Dunlap <george.dunlap@citrix.com>,
        Ian
 Jackson <iwj@xenproject.org>, Jan Beulich <jbeulich@suse.com>,
        Wei Liu
	<wl@xen.org>, Paul Durrant <paul@xen.org>,
        Oleksandr Andrushchenko
	<Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH v5 08/11] xen/arm: Enable the existing x86 virtual PCI
 support for ARM.
Thread-Topic: [PATCH v5 08/11] xen/arm: Enable the existing x86 virtual PCI
 support for ARM.
Thread-Index: AQHXutl3YqS5dHXsYk6KpdKt4d14RavNphKAgABZ5QCAAAISgA==
Date: Mon, 11 Oct 2021 16:20:14 +0000
Message-ID: <e199bfe2-0bcc-989f-fd4a-ecf44a3cd1ac@epam.com>
References: <cover.1633540842.git.rahul.singh@arm.com>
 <9bdca2cda5d2e83f94dc2423e55714273539760a.1633540842.git.rahul.singh@arm.com>
 <YWQXF2vDaWQvi+bT@MacBook-Air-de-Roger.local>
 <4F406854-4F90-48F6-8470-6CCB60A3CB77@arm.com>
In-Reply-To: <4F406854-4F90-48F6-8470-6CCB60A3CB77@arm.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
authentication-results: arm.com; dkim=none (message not signed)
 header.d=none;arm.com; dmarc=none action=none header.from=epam.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 0afdd56c-7212-4445-402a-08d98cd3019a
x-ms-traffictypediagnostic: AM9PR03MB6963:
x-ms-exchange-transport-forked: True
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <AM9PR03MB6963B7347E2D248FF3EF0B7BE7B59@AM9PR03MB6963.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 Bsh24lZ+ts66HcSDjggvSE8tCZNXDqiQWzUJu8db0pm81Y180WjsUWNOwhjO0M8ilZOW3nJ8G+Y1cEtMEb127wu0iVCBIQ9D2RebvRIjaqz2wYWpdyUMtwVeeElZklEacnyw4M5VtUi00aXe6NpvvhgsLAHf58jxZMbOaSOF8rWtMvj7u9oiqvpjodkYa2Uc9H28wzGV38C00SZOqS2HFVX3Qv9CNK7xXu2MCX7sLPT7q6JHZwUQex6iQ9xTMqNuUuE+TX7ShgiggvDhWcean3R8mg7Vv9zFExwyAc9kKpjEoh0F7Ax81XGMnxYSPwPIVC3qhXpsZyoaSsjsGxbQu0099Zz4+8YvatXVKGcYA2cJ04htnibqJLKLm2/+WFwa0gvHTV4QoHp3wjJ/LHiL2Y3P7SRaE4VTTsunFY4hnys+JOk5yLCF8p8bq6a927Loy4KX9cRXpXvd3l5Tnu4ODvOTsPTS91du69mC5vqcOVaYaWLuOxehSiG/vGHcbFA/bP/++WngQKalJvaAaOO/4x7yGCCTCOWdVTkIvpXY0J2WvhBGL2gZnzHfoZHrfMOgIGhwGNFI4sUOz+x/rnP3RGJsAjrm3HEaXRdtDE4UdAxe5vHqCKBwGYP3PmHVBRhIWT5WYjeR+nx57ewPu6IBwXho0xn/z4ynTt9M15so5WfznlEk/n3b9E2nojWm5vZiXBV/fXRcNznrCrMv28av/XW17x1zZM5bhNfhprcoXrEPxDXdMUo494bOu0ePMxjOVp3RzguWRtbbAerX+t2i52JJz3mSpUopL64E2DvkYdRDFUIe5HeHzmPqgGKj2R/5p/eyklWXSbuFXxHHPpK4CA==
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(66476007)(6512007)(4326008)(53546011)(55236004)(2906002)(36756003)(86362001)(38070700005)(64756008)(66446008)(66556008)(31686004)(76116006)(54906003)(186003)(91956017)(6486002)(110136005)(26005)(5660300002)(316002)(66946007)(6506007)(7416002)(31696002)(38100700002)(508600001)(2616005)(966005)(71200400001)(122000001)(8936002)(8676002)(107886003)(83380400001)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?c3VHZks2aGZuS0NlckNSanQxRGFrT0dUWjQ3b2Vod2ZJWUlTZEphTTFiM2No?=
 =?utf-8?B?Yk9MV1YvbUp5eEhTdGcwd1JNWTJYejhtQWVEOFBicXpkeUpiQ0hiSERMUTVt?=
 =?utf-8?B?U3VNZEozeEdRTkFzcmsrYzFvdWFuMUtYbkJjL2EzMXdQM2w3aVZSSTJ0RlpF?=
 =?utf-8?B?dlE1cnR1M2hPQnNTYlVLWnFmcnFhVDhWbXNNUkpmcEM0NStIUDVHQ2d3YXBj?=
 =?utf-8?B?eHBlYmRRZ3Q5V2w0Q2htUXpVQng1QThiZkxDRVpOL3VmQ0JZY1hhL3c4bVZD?=
 =?utf-8?B?dWNOL2lNTEEwaVBJNllEdzMyNlRHeVNmeEI0MjBEV1VoNnBSQ2QwZG1BRkNn?=
 =?utf-8?B?QnpYeXVJbHJBVW1DK2V2UjNwSDVCcGZaa0dFQ2swWW1SRjZGenZ0Z1FhZ2Zk?=
 =?utf-8?B?ejNRcmZIYzc5WFA4aGU2WTVqNVRldTdFM0NzVEpCUktKbmxRbEUyWWtmZFZU?=
 =?utf-8?B?VUt2aXozSzJydTU0cFE3UWVQUDJKeEJjaFdGSVgwSEhla0Q1eGdES2pKUkFl?=
 =?utf-8?B?TXFCOEhhZ0VMUkJDM0FrdlJ3bUM2SFZxSU81dFM4ZlVLSUFDUkxwcG5YVldu?=
 =?utf-8?B?b3BUVGpsQXBkeDJ0bTY5VmptN3pqdGdsNWpMYXVWZmdtQzA2QlNRZHhpQVVM?=
 =?utf-8?B?alhzZVJrTmVOVVlxMWhnT3NYZS9CdVNNUW1maVRYMjVGbVBrVjV5RlRHSTNP?=
 =?utf-8?B?cXVhbGRPeXFleSsxVXQ2Wnc1V0RremFTNytsME5KOU80NnI2UFh5MFFsVm5W?=
 =?utf-8?B?ODNNNU9SZ3BMY3pBSXlEOGdSRmpjMDYzYnp0bXJUaEx2VGx1a3VhNGxOeHUx?=
 =?utf-8?B?UTFrdW55QSs0RnhBc2lSdFJYTjMwT3NsbEMyaTdsa1dRbXdkSlJwdzRzZDVC?=
 =?utf-8?B?azNRQWNBZ3lLNmorb2prVGdYdk5LMFdENUFqT1lvclJZNHBzODZuck56ZzFK?=
 =?utf-8?B?U3dmV1pJRy9pdHFCaVVCZ29sdFgrNkwzb2RaRTRhaS9KVzVMaXJaWXJiQkxG?=
 =?utf-8?B?cSsxZXdZb3Z5QTRSY2RxeEZVRStmR2xFZXJyMFEyeTZ6ZDBOd2Z2UU9NNnB2?=
 =?utf-8?B?ZGYvN3ZaK0FBVjc3VG5LeHFkTFk5WVkwNXEvSWkyQlYybFpzSmlEaXNtV0Jm?=
 =?utf-8?B?bno1Qjh3YktmbnNFeFIyeWFpT0sybnE3U1JRN0JKdEIxZlgyWUpGaWhVR2Yr?=
 =?utf-8?B?OVkyRGRDdGRNWEtxRjhsVlVWL1NaVG96bTV0K3dqMWpyZnlQc3U4MHMwMGhx?=
 =?utf-8?B?NmtpRndJWEdBb1FYdnQrMXQzK3pDVzVxUGt2UHI1WVNoaS9RenIwbWRXN3F2?=
 =?utf-8?B?SUhaYldFVVFFU2dUbU9Kb2lxUjZzQVVwN3NoQ2F4V25SZEZ5QkxSWUdiQ2VB?=
 =?utf-8?B?cmlia0tZRC9GRjNJUmh6M0NzS2xTMGpyTnV3V2c4bXpwdGxUdERGd1NwVU5W?=
 =?utf-8?B?cjFydkhCQmpUYXlrTkk0NmtBV1RyYWhrYTR0QUUvMVo2dm5HQUgwbDhVdWNp?=
 =?utf-8?B?QnRwTSs3bHgvbUdMSTlsZEhncUVlbHVaUHpxRkR0bHU3a1ZkVUNmS0RvR1d1?=
 =?utf-8?B?S2s4amR4Zmhsb2g5VyttbFRGVVllNDEwZGo0U0JOaHh0Ym1rL0ZSeFRGQ0Rw?=
 =?utf-8?B?czZCUTNJcGVWcUxSb2VtOHVEcDJUVHc3WFpTSUNBMXpFcjRqaVVGWEg2aHJ0?=
 =?utf-8?B?SjZIOHduS0x5UkI4TFdNb0lnUFRwZHdSdElGL3JESnRoL1hackZMRW1zMity?=
 =?utf-8?B?RXp1NnJCWmw0WHdFSHYrQmRxRTFoOGt1YzZ2MEhJalJPL21rdkZ1elRuUytq?=
 =?utf-8?B?ejZUMG9FVUw2emMrZFNvQT09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <9CD29D13F693DB4995AF0EAED5085205@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0afdd56c-7212-4445-402a-08d98cd3019a
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Oct 2021 16:20:14.1982
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: z81k1n+PZ9oSEoUFNuPqKpkKvxTmKtQZOytQIL7cYfPjHeEmNiITR56GAHb9QeQXvcNf6OKo7Yi2LoSB/gEP4c7He5FfXv1BxImSk/4tGk9POVjLfFYQZa4G0RBOGnU6
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR03MB6963
X-Proofpoint-GUID: lDYFYIOewII55j5TQMIcWvRY2d2y0hFr
X-Proofpoint-ORIG-GUID: lDYFYIOewII55j5TQMIcWvRY2d2y0hFr
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475
 definitions=2021-10-11_05,2021-10-11_01,2020-04-07_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501
 malwarescore=0 spamscore=0 clxscore=1015 phishscore=0 mlxlogscore=999
 lowpriorityscore=0 mlxscore=0 impostorscore=0 bulkscore=0 suspectscore=0
 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2109230001 definitions=main-2110110096

DQoNCk9uIDExLjEwLjIxIDE5OjEyLCBCZXJ0cmFuZCBNYXJxdWlzIHdyb3RlOg0KPiBIaSBSb2dl
ciwNCj4NCj4+IE9uIDExIE9jdCAyMDIxLCBhdCAxMTo1MSwgUm9nZXIgUGF1IE1vbm7DqSA8cm9n
ZXIucGF1QGNpdHJpeC5jb20+IHdyb3RlOg0KPj4NCj4+IE9uIFdlZCwgT2N0IDA2LCAyMDIxIGF0
IDA2OjQwOjM0UE0gKzAxMDAsIFJhaHVsIFNpbmdoIHdyb3RlOg0KPj4+IFRoZSBleGlzdGluZyBW
UENJIHN1cHBvcnQgYXZhaWxhYmxlIGZvciBYODYgaXMgYWRhcHRlZCBmb3IgQXJtLg0KPj4+IFdo
ZW4gdGhlIGRldmljZSBpcyBhZGRlZCB0byBYRU4gdmlhIHRoZSBoeXBlciBjYWxsDQo+Pj4g4oCc
UEhZU0RFVk9QX3BjaV9kZXZpY2VfYWRk4oCdLCBWUENJIGhhbmRsZXIgZm9yIHRoZSBjb25maWcg
c3BhY2UNCj4+PiBhY2Nlc3MgaXMgYWRkZWQgdG8gdGhlIFhlbiB0byBlbXVsYXRlIHRoZSBQQ0kg
ZGV2aWNlcyBjb25maWcgc3BhY2UuDQo+Pj4NCj4+PiBBIE1NSU8gdHJhcCBoYW5kbGVyIGZvciB0
aGUgUENJIEVDQU0gc3BhY2UgaXMgcmVnaXN0ZXJlZCBpbiBYRU4NCj4+PiBzbyB0aGF0IHdoZW4g
Z3Vlc3QgaXMgdHJ5aW5nIHRvIGFjY2VzcyB0aGUgUENJIGNvbmZpZyBzcGFjZSxYRU4NCj4+PiB3
aWxsIHRyYXAgdGhlIGFjY2VzcyBhbmQgZW11bGF0ZSByZWFkL3dyaXRlIHVzaW5nIHRoZSBWUENJ
IGFuZA0KPj4+IG5vdCB0aGUgcmVhbCBQQ0kgaGFyZHdhcmUuDQo+Pj4NCj4+PiBGb3IgRG9tMGxl
c3Mgc3lzdGVtcyBzY2FuX3BjaV9kZXZpY2VzKCkgd291bGQgYmUgdXNlZCB0byBkaXNjb3ZlciB0
aGUNCj4+PiBQQ0kgZGV2aWNlIGluIFhFTiBhbmQgVlBDSSBoYW5kbGVyIHdpbGwgYmUgYWRkZWQg
ZHVyaW5nIFhFTiBib290cy4NCj4+Pg0KPj4+IFNpZ25lZC1vZmYtYnk6IFJhaHVsIFNpbmdoIDxy
YWh1bC5zaW5naEBhcm0uY29tPg0KPj4+IFJldmlld2VkLWJ5OiBTdGVmYW5vIFN0YWJlbGxpbmkg
PHNzdGFiZWxsaW5pQGtlcm5lbC5vcmc+DQo+Pj4gLS0tDQo+Pj4gQ2hhbmdlIGluIHY1Og0KPj4+
IC0gQWRkIHBjaV9jbGVhbnVwX21zaShwZGV2KSBpbiBjbGVhbnVwIHBhcnQuDQo+Pj4gLSBBZGRl
ZCBSZXZpZXdlZC1ieTogU3RlZmFubyBTdGFiZWxsaW5pIDxzc3RhYmVsbGluaUBrZXJuZWwub3Jn
Pg0KPj4+IENoYW5nZSBpbiB2NDoNCj4+PiAtIE1vdmUgYWRkaXRpb24gb2YgWEVOX0RPTUNUTF9D
REZfdnBjaSBmbGFnIHRvIHNlcGFyYXRlIHBhdGNoDQo+Pj4gQ2hhbmdlIGluIHYzOg0KPj4+IC0g
VXNlIGlzX3BjaV9wYXNzdGhyb3VnaF9lbmFibGVkKCkgaW4gcGxhY2Ugb2YgcGNpX3Bhc3N0aHJv
dWdoX2VuYWJsZWQgdmFyaWFibGUNCj4+PiAtIFJlamVjdCBYRU5fRE9NQ1RMX0NERl92cGNpIGZv
ciB4ODYgaW4gYXJjaF9zYW5pdGlzZV9kb21haW5fY29uZmlnKCkNCj4+PiAtIFJlbW92ZSBJU19F
TkFCTEVEKENPTkZJR19IQVNfVlBDSSkgZnJvbSBoYXNfdnBjaSgpDQo+Pj4gQ2hhbmdlIGluIHYy
Og0KPj4+IC0gQWRkIG5ldyBYRU5fRE9NQ1RMX0NERl92cGNpIGZsYWcNCj4+PiAtIG1vZGlmeSBo
YXNfdnBjaSgpIHRvIGluY2x1ZGUgWEVOX0RPTUNUTF9DREZfdnBjaQ0KPj4+IC0gZW5hYmxlIHZw
Y2kgc3VwcG9ydCB3aGVuIHBjaS1wYXNzdGhvdWdoIG9wdGlvbiBpcyBlbmFibGVkLg0KPj4+IC0t
LQ0KPj4+IC0tLQ0KPj4+IHhlbi9hcmNoL2FybS9NYWtlZmlsZSAgICAgICAgIHwgICAxICsNCj4+
PiB4ZW4vYXJjaC9hcm0vZG9tYWluLmMgICAgICAgICB8ICAgNCArKw0KPj4+IHhlbi9hcmNoL2Fy
bS9kb21haW5fYnVpbGQuYyAgIHwgICAzICsNCj4+PiB4ZW4vYXJjaC9hcm0vdnBjaS5jICAgICAg
ICAgICB8IDEwMiArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrDQo+Pj4geGVuL2Fy
Y2gvYXJtL3ZwY2kuaCAgICAgICAgICAgfCAgMzYgKysrKysrKysrKysrDQo+Pj4geGVuL2RyaXZl
cnMvcGFzc3Rocm91Z2gvcGNpLmMgfCAgMTggKysrKysrDQo+Pj4geGVuL2luY2x1ZGUvYXNtLWFy
bS9kb21haW4uaCAgfCAgIDcgKystDQo+Pj4geGVuL2luY2x1ZGUvYXNtLXg4Ni9wY2kuaCAgICAg
fCAgIDIgLQ0KPj4+IHhlbi9pbmNsdWRlL3B1YmxpYy9hcmNoLWFybS5oIHwgICA3ICsrKw0KPj4+
IHhlbi9pbmNsdWRlL3hlbi9wY2kuaCAgICAgICAgIHwgICAyICsNCj4+PiAxMCBmaWxlcyBjaGFu
Z2VkLCAxNzkgaW5zZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkNCj4+PiBjcmVhdGUgbW9kZSAx
MDA2NDQgeGVuL2FyY2gvYXJtL3ZwY2kuYw0KPj4+IGNyZWF0ZSBtb2RlIDEwMDY0NCB4ZW4vYXJj
aC9hcm0vdnBjaS5oDQo+Pj4NCj4+PiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gvYXJtL01ha2VmaWxl
IGIveGVuL2FyY2gvYXJtL01ha2VmaWxlDQo+Pj4gaW5kZXggNDRkN2NjODFmYS4uZmI5Yzk3NmVh
MiAxMDA2NDQNCj4+PiAtLS0gYS94ZW4vYXJjaC9hcm0vTWFrZWZpbGUNCj4+PiArKysgYi94ZW4v
YXJjaC9hcm0vTWFrZWZpbGUNCj4+PiBAQCAtNyw2ICs3LDcgQEAgaWZuZXEgKCQoQ09ORklHX05P
X1BMQVQpLHkpDQo+Pj4gb2JqLXkgKz0gcGxhdGZvcm1zLw0KPj4+IGVuZGlmDQo+Pj4gb2JqLSQo
Q09ORklHX1RFRSkgKz0gdGVlLw0KPj4+ICtvYmotJChDT05GSUdfSEFTX1ZQQ0kpICs9IHZwY2ku
bw0KPj4+DQo+Pj4gb2JqLSQoQ09ORklHX0hBU19BTFRFUk5BVElWRSkgKz0gYWx0ZXJuYXRpdmUu
bw0KPj4+IG9iai15ICs9IGJvb3RmZHQuaW5pdC5vDQo+Pj4gZGlmZiAtLWdpdCBhL3hlbi9hcmNo
L2FybS9kb21haW4uYyBiL3hlbi9hcmNoL2FybS9kb21haW4uYw0KPj4+IGluZGV4IDM2MTM4YzFi
MmUuLmZiYjUyZjc4ZjEgMTAwNjQ0DQo+Pj4gLS0tIGEveGVuL2FyY2gvYXJtL2RvbWFpbi5jDQo+
Pj4gKysrIGIveGVuL2FyY2gvYXJtL2RvbWFpbi5jDQo+Pj4gQEAgLTM5LDYgKzM5LDcgQEANCj4+
PiAjaW5jbHVkZSA8YXNtL3ZnaWMuaD4NCj4+PiAjaW5jbHVkZSA8YXNtL3Z0aW1lci5oPg0KPj4+
DQo+Pj4gKyNpbmNsdWRlICJ2cGNpLmgiDQo+Pj4gI2luY2x1ZGUgInZ1YXJ0LmgiDQo+Pj4NCj4+
PiBERUZJTkVfUEVSX0NQVShzdHJ1Y3QgdmNwdSAqLCBjdXJyX3ZjcHUpOw0KPj4+IEBAIC03Njcs
NiArNzY4LDkgQEAgaW50IGFyY2hfZG9tYWluX2NyZWF0ZShzdHJ1Y3QgZG9tYWluICpkLA0KPj4+
ICAgICAgaWYgKCBpc19oYXJkd2FyZV9kb21haW4oZCkgJiYgKHJjID0gZG9tYWluX3Z1YXJ0X2lu
aXQoZCkpICkNCj4+PiAgICAgICAgICBnb3RvIGZhaWw7DQo+Pj4NCj4+PiArICAgIGlmICggKHJj
ID0gZG9tYWluX3ZwY2lfaW5pdChkKSkgIT0gMCApDQo+Pj4gKyAgICAgICAgZ290byBmYWlsOw0K
Pj4+ICsNCj4+PiAgICAgIHJldHVybiAwOw0KPj4+DQo+Pj4gZmFpbDoNCj4+PiBkaWZmIC0tZ2l0
IGEveGVuL2FyY2gvYXJtL2RvbWFpbl9idWlsZC5jIGIveGVuL2FyY2gvYXJtL2RvbWFpbl9idWls
ZC5jDQo+Pj4gaW5kZXggYzVhZmJlMmUwNS4uZjRjODliZGU4YyAxMDA2NDQNCj4+PiAtLS0gYS94
ZW4vYXJjaC9hcm0vZG9tYWluX2J1aWxkLmMNCj4+PiArKysgYi94ZW4vYXJjaC9hcm0vZG9tYWlu
X2J1aWxkLmMNCj4+PiBAQCAtMzA1Myw2ICszMDUzLDkgQEAgdm9pZCBfX2luaXQgY3JlYXRlX2Rv
bTAodm9pZCkNCj4+PiAgICAgIGlmICggaW9tbXVfZW5hYmxlZCApDQo+Pj4gICAgICAgICAgZG9t
MF9jZmcuZmxhZ3MgfD0gWEVOX0RPTUNUTF9DREZfaW9tbXU7DQo+Pj4NCj4+PiArICAgIGlmICgg
aXNfcGNpX3Bhc3N0aHJvdWdoX2VuYWJsZWQoKSApDQo+Pj4gKyAgICAgICAgZG9tMF9jZmcuZmxh
Z3MgfD0gWEVOX0RPTUNUTF9DREZfdnBjaTsNCj4+IEkgdGhpbmsgSSdtIGNvbmZ1c2VkIHdpdGgg
dGhpcy4gWW91IHNlZW0gdG8gZW5hYmxlIHZQQ0kgZm9yIGRvbTAsIGJ1dA0KPj4gdGhlbiBkb21h
aW5fdnBjaV9pbml0IHdpbGwgc2V0dXAgdHJhcHMgZm9yIHRoZSBndWVzdCB2aXJ0dWFsIEVDQU0N
Cj4+IGxheW91dCwgbm90IHRoZSBuYXRpdmUgb25lIHRoYXQgZG9tMCB3aWxsIGJlIHVzaW5nLg0K
PiBJIHRoaW5rIGFmdGVyIHRoZSBsYXN0IGRpc2N1c3Npb25zLCBpdCB3YXMgZGVjaWRlZCB0byBh
bHNvIGluc3RhbGxlZCB0aGUgdnBjaQ0KPiBoYW5kbGVyIGZvciBkb20wLiBJIHdpbGwgaGF2ZSB0
byBsb29rIGludG8gdGhpcyBhbmQgY29tZSBiYWNrIHRvIHlvdS4NCj4gQE9sZWtzYW5kcjogQ291
bGQgeW91IGNvbW1lbnQgb24gdGhpcy4NClllcywgd2UgZG8gdHJhcCBEb20wIGFzIHdlbGwuIFRo
ZSBEb20wIHRyYXBzIGFyZSBub3QgaW4gdGhpcyBzZXJpZXMsIGJ1dA0KYXJlIGluIG1pbmUgYXMg
aXQgbmVlZHMgbW9yZSBwcmVwYXJhdG9yeSB3b3JrIGZvciB0aGF0LiBQbGVhc2Ugc2VlIFsxXQ0K
DQpUaGFuayB5b3UsDQpPbGVrc2FuZHINCg0KWzFdIGh0dHBzOi8vcGF0Y2h3b3JrLmtlcm5lbC5v
cmcvcHJvamVjdC94ZW4tZGV2ZWwvcGF0Y2gvMjAyMTEwMDgwNTU1MzUuMzM3NDM2LTktYW5kcjIw
MDBAZ21haWwuY29tLw==


From xen-devel-bounces@lists.xenproject.org Mon Oct 11 16:33:37 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 16:33:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.206348.361896 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZyF2-0007d4-VK; Mon, 11 Oct 2021 16:33:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 206348.361896; Mon, 11 Oct 2021 16:33:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZyF2-0007cx-SI; Mon, 11 Oct 2021 16:33:32 +0000
Received: by outflank-mailman (input) for mailman id 206348;
 Mon, 11 Oct 2021 16:33:31 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=pkLr=O7=citrix.com=roger.pau@srs-us1.protection.inumbo.net>)
 id 1mZyF1-0007cr-3D
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 16:33:31 +0000
Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id f6ccd630-2ab0-11ec-80ec-12813bfff9fa;
 Mon, 11 Oct 2021 16:33:29 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f6ccd630-2ab0-11ec-80ec-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1633970009;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=67t8BCuaqEIn0Y0PWn51JD53az/ZlCtuZwJ4rW9OTMM=;
  b=EQkXnnkC20CC3Q36pV+6oqGHVcg+7gzpux8OpmLKFHPsgSpdKuJVY0EZ
   MYJFvdMH1gUXcNUKdbGWpvpQjH3QmhLBEdSK7RSc7LAl0HlF0CSnhH60D
   V8n4wXoS7cK8bSCE3ugk5re+0M+uMTA2CscOiM/cjoUxJlHpdrJQ8itX2
   s=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: 5nbEISG4Wf0o/ZsQkbUpeb/1wQ5pjqoN1BHsvMVJ8GKpr0CxkK3dYV229kMvTEIGR9tuSlIVqA
 zSlX0q3kSO58ENphfXYIKbE+qNc49vBbo4E2ZbrSBr06dCcxg4tVxKiQH0TX2sf5HDZMz1gGO9
 ZcOgjLcxKlQOHos6Nbr0ugVtuDAGZMN7czSAiFe3qEabn23GZ5l23CbDRoXkI49TPOavRLs+B4
 08yGTF88JA0at9WrJ0GWruPzxfRvj/Q0oGs4BFF4ubV/CWPIoJbBCmlm8Lq213jvK/35PRSdM6
 wpa+bZhP6NlK7aIjXWjBmdRj
X-SBRS: 5.1
X-MesageID: 54932585
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:3wtHI6IE3yvIMQ/vFE+RpZMlxSXFcZb7ZxGr2PjKsXjdYENSg2AGn
 TMZWzqBbqyNY2D0L49zPd/kphkPsZLWnd82S1dlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s
 q3yv/GZdJhcokcxIn5BC5C5xZVG/fjgqoHUVaiUZ0ideSc+EH140Eo6wrZg6mJVqYPR7z2l6
 IuaT/L3YDdJ6xYsWo7Dw/vewP/HlK2aVAIw5jTSV9gS1LPtvyB94KYkDbOwNxPFrrx8RYZWc
 QphIIaRpQs19z91Yj+sfy2SnkciGtY+NiDW4pZatjTLbrGvaUXe345iXMfwZ3u7hB2ntM9Lj
 /Z/p6fochsYOoLWocFedUdHRnQW0a1uoNcrIFC6uM2XiUbHb2Ht07NlC0Re0Y8wo7gtRzsUr
 LpBdW5LPkvra+GemdpXTsF2gcsuNo/zNZ43sXB81zDJS/0hRPgvRo2XuY4Dhmpg26iiG97EZ
 sgELjkxSCjZZixwAXENEJQ/s/yn0yyXnzpw9wvO+PtfD3Lo5BN1+KjgNpzSYNPibcRKnG6Iq
 2Te5WP7DxoGctuFxlKt6Wmwj+XCmSf6XoM6F7Ci8PNuxlqJyQQ7ChIMUkCgieKkkUP4UNVaQ
 2Q9/CY0oO4K7l66UdDnVjWxunvCtRkZM/J3F+A58wiLxrDjygCVHHUfTjVBZdols+c7XTUvk
 FSOmrvBLzF1rKecT37b076OtC6zIgAcN2pEbigBJSMV7t+mrIwtgxbnStd4DLXzntDzASv3w
 T2BsG45nbp7pfQC17i/u2vGhT2sjpHTS0g+4QC/Y46+xlonPsj/PdXusAWFq6YbRGqEcrWfl
 FYvhPLZz9IcNsm2iB2Jb/80OfKPuenQZVUwnmVTN5Um8j2s/VuqcoZR/CxyKS9VDyoURdP6S
 BSM4V0Jtfe/KFPvNPUtO9vgVKzG2IC5TYy9Ps04eOaidXSYmOWvxyppeVKLl17klEwhgMnT0
 r/KLJ7yUx725UlhpQdaptvxM5d3lkjSJkuJHPgXKihLN5LEORZ5rp9fYTOzghgRtv/sneks2
 4832zG24xteSvbiRSLc7JQeK1sHRVBiW8ut+50PKbfaflQ9cI3ENxM36eh7E2CCt/4E/tokA
 1nnAhMIoLYBrSyvxfq2hoBLN+q0AMcXQYMTNi0wJ1e4s0XPkq70hJrzg6AfJOF9nMQ6lKYcZ
 6BcJ62oX6QeIhyaqm91RcSs8+RfmOGD2Fvm09yNO2NkIfaNhmXhp7fZQ+cY3HBWVHTo7pFi/
 +TIO8GyacNrejmOxf3+MZqH51iwoWIciKR1WU7JKcNUY0Li7M5hLCmZsxP9C5hkxczrymTI2
 gCILw0foOWR8YY5/MOQ3fKPrpuzEvs4FU1fRjGJ4bGzPCjc32yi3Y4fD7rYIWGDDDv5qPe4e
 OFY7/DgK/lbzlxEhJVxTuRwxqUk6tqx+7IDllZ4HG/GZkiAA697JiXUxtFGs6BAn+cLuQa/V
 k+V1MNdPLGFZJHsHFILfVJ3ZeWfz/AE3DLV6K1tckn94SZ2+puBUFlTYEbQ2HAMcuMtPdp8k
 +k7ucMQ5wiusTYQM46L3nJO6mCBDn0cSKF75JsUN5Dm11gwwVZYbJ2CViKvuMOTa89BO1UBK
 yOPgPaQnKxVw0fPfiZhFXXJ2uYB150CtAoTkQ0HLlWN3NHEmuU2zFta9jFuFlZZyRBO0uRSP
 Gl3NhIqefXSrmkw3MUTDXqxHwxhBQGC/h2jwlQEo2TVUk20WzGfN2Y6I+uMoBgU/m80kuK3J
 11EJLIJiQrXQfw=
IronPort-HdrOrdr: A9a23:yoo/7q62J/fesULCpQPXwVSBI+orL9Y04lQ7vn2ZFiY6TiXIra
 +TdaoguSMc6AxwZJkh8erwXpVoZUmsiKKdhrNhQYtKPTOWwldASbsC0WKM+UyEJ8STzJ846U
 4kSdkANDSSNykLsS+Z2njBLz9I+rDum8rE9ISurQYfcegpUdAa0+4QMHfrLqQcfng+OXNWLu
 v62iIRzADQB0j/I/7LS0UtbqzmnZnmhZjmaRkJC1oO7xSPtyqh7PrfHwKD1hkTfjtTyfN6mF
 K13DDR1+GGibWW2xXc32jc49B/n8bg8MJKAIiphtIOIjvhpw60bMBKWqGEvhoyvOazgWxa3O
 XkklMFBYBe+nnRdma6rV/E3BTh6i8n7zvYxVqRkRLY0ITEbQN/L/AEqZNScxPf5UZllsp7yr
 h302WQsIcSJQ/cnQzmjuK4Fy1Cpw6Rmz4PgOQTh3tQXc81c7lKt7ES+0tTDdMpAD/60oY6C+
 NjZfuspcq+SWnqLUwxg1MfheBFBh8Ib1O7qwk5y4KoOgFt7TNEJxBy/r1Zop8CnKhNAqWsqd
 60dJiAr4s+O/P+W5gNctvpcfHHeFAlfii8RF56AW6XX53vaEi94aIe3t0OlZaXkdozvcIPpK
 g=
X-IronPort-AV: E=Sophos;i="5.85,364,1624334400"; 
   d="scan'208";a="54932585"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=hC/tnu4PrTlhorH59ikoEsQCCKMTy1OBaCHGo8FC7FdsW41p6ekkk/yTOQj08FL2Q9q/6XvLBpC6TOjAm4+xsU3svMKZ8gXDL+cxRw9MHMnMC+kUibT6KJYk1VEkNMMWyd/XdA31UwCFMY5qXKPeY+U3P/RT3/kUsTQ9Lpg/fz0RNopD9bZ+GoIO0mv3y8cqKFTE++/qTCQ30lK+/aG5fWkcPvy66N/Ica/beac2sZxEpjzRafh1ukBCQgJrNwWzpvXzEQcJRkSFcyYxmJ57K3m7wpeXGWbK89ol3VP+DT5mHpcSDM5HTvXyAcZLLNh5GnGUT9mYuf7BgaYEAqZ43g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=JN2qooTMidmqi0poQK8uzNQTGb5Cuhe9Crr5BSVThh8=;
 b=eUWeZd1l8zz+ppp1AXUyTNRbFxH0F+GzH0zbhH+T5gWrkgh8ylY0CsE0w8qL8sn06NL2mERMBDt7/JsXo1qRXErJ3TIKMnwD5XAiz/MJ7sTleii6IWOwFp5A9xYR9VyIQ5NWdw9sbadUuIDO5v5hJ/Gmu1AH/da/UuBGyHiBcCJ7saJGpEpL0enQ2/SWe23mE+8AEhu/qLALEnKWSXjcgpRRyf3yt560YTtHSKPMqPSL5ylLrKEF2b2xNK8319ZbmQV22ftwXCCoTFGCn9O5ry6MZaG6YuEGDQk+3NG3UZlQiG9bvaMznJ/9pRYqw1RP8AZGcOroS6yogjzN/PNdpQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=JN2qooTMidmqi0poQK8uzNQTGb5Cuhe9Crr5BSVThh8=;
 b=cv4MBKsPoUaRafk5YISRCo/S62U4oEiRdKSm7EQkl2UNR6zV4f0UnEs4p9jb0EN0TBsp7rBhZzn+OyhkIPoMktYeP3oAXiCfsbFs9DcL/9FjSr5EHQgA/bYg3nOpCPhKcjREXak2JfJcBBMjhewu3z3dONdR6A9jD5ctGjqRixI=
Date: Mon, 11 Oct 2021 18:32:49 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Bertrand Marquis <Bertrand.Marquis@arm.com>
CC: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>, Rahul Singh
	<Rahul.Singh@arm.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, Andre Przywara <Andre.Przywara@arm.com>,
	Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>, Juergen Gross
	<jgross@suse.com>, Stefano Stabellini <sstabellini@kernel.org>
Subject: Re: [PATCH v5 01/11] xen/arm: xc_domain_ioport_permission(..) not
 supported on ARM.
Message-ID: <YWRnMfAi808TQ4Gt@MacBook-Air-de-Roger.local>
References: <cover.1633540842.git.rahul.singh@arm.com>
 <d292392268df2c74c4103a82ef917072643407a8.1633540842.git.rahul.singh@arm.com>
 <YWQkblfNMYEs6jI9@MacBook-Air-de-Roger.local>
 <77CF7FA5-C566-469E-B4A8-0400789890BB@arm.com>
 <YWQ6Nk3Jk+BqgkwZ@MacBook-Air-de-Roger.local>
 <53AE6E2A-01D7-41EC-9B2C-C0D596EB8D4D@arm.com>
 <YWRCxXGQIyTOAepC@MacBook-Air-de-Roger.local>
 <FEF0B03A-5AC8-4F8D-B821-191AC2EF8295@arm.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <FEF0B03A-5AC8-4F8D-B821-191AC2EF8295@arm.com>
X-ClientProxiedBy: LO4P123CA0382.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:18f::9) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: d3b0e143-b1bb-45c9-ff11-08d98cd4c6e7
X-MS-TrafficTypeDiagnostic: DM5PR03MB3369:
X-Microsoft-Antispam-PRVS: <DM5PR03MB3369F0719AC1160A8715A3888FB59@DM5PR03MB3369.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: kegMP6ZviFEEEMV+nf//1YijMPxPTByeeR0pslEoQRRInQ3U0+uj2Czpxfs3VyGCBSZtIAgc4+qoVqA8Utpq5i80GyyZGodUzSSvRMHEBdivP6VXxICbInZtq+jJ81BgBBc4soOlrE3Pd3q/4YtEe2yOHR8OLJk1mfIaaxVto+dfZvTgkXMjWlL7k8TsTUsCZYE3leoof+imUvT8vp9/TzUDiLKbbCrGL0wLkKFcMbMIbNmGq7Q1c3Yf1FdHuDee9dOB8dZPVlwBXKh7/jqL2Wn6M9Cmkpp74+Q0bekiaHezYYFwhyZEBOntne+7clK8kidpDtiYJVaYWtmAn54yB4irgVlFotVhtZj4r191Mn/UwRlLFmm1ZlBb6MJfbc2/SBXvsCnBIOkCUiuvs+koY7oNrbpQnME471ctdUrrt0xGUCaOl2Nqk9oHp1dWGy7R9adGfb0BezHMZMl7S2w/yAXxjPyCy4/UBAgBGCNkZDOdIyc8SPlizfgy6bWmDsN5b0vrV8qaUHyGBBqXameRfo3kKlLMYydAFPHjKPQaHIbuYZdcz5qSTUEf9oYK1H9J7O0MYMEH9qc3PpfA/UY+nPbKP3eOBMFQCzBCYTEv5LNrImZ+uF/q8FRJwiqa6rY0XdRcsTB0NqkZWf3gRpWPZw==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(84040400005)(26005)(53546011)(38100700002)(508600001)(2906002)(9686003)(6916009)(5660300002)(54906003)(8676002)(66476007)(66556008)(316002)(6666004)(186003)(6486002)(83380400001)(956004)(85182001)(6496006)(86362001)(66946007)(4326008)(8936002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WnNiQUExdGh6YUN6TThtZkgwZHU2UW9zYnJSK0VEWmZ2ZWFRMWVja0czREtt?=
 =?utf-8?B?VDRidlZvN3ZJSnNWTHdIa1RRK3V4SFlRYnZBT0UwNEZ3NXJJTlMxcUpKTXFp?=
 =?utf-8?B?VXg1T3Y1OVY0M3VWeUZIaUVWTHM1KzBQTm03SzJJbU04MXZ0bHhtbXQ1NVBS?=
 =?utf-8?B?NzNuZTloWjBXK2U2MXpNeVZZelZjOU5oU1FpRFR4enV2YXl5akFNWUNXNVRv?=
 =?utf-8?B?TzNFMURwdFNnVU5TQnE1L3NiUS9CSU5TYXdEMWtrcmxvaEZvTFBVZjBLV3Qv?=
 =?utf-8?B?Y0hzcnQrWHVhU2pjMk4rQzJtdlMwbERPRUpZZnV4QmVHR1lsSkhwTTdwbUhh?=
 =?utf-8?B?MzlWd0l2UFYxYWY1a1lrd0w2OFZjTjYrOUdTUEtLcmMvaktOZk90ZzQvN05Z?=
 =?utf-8?B?cDNtNXRQemRETVRZZGlZeFJPQ0lMd0M2NklhR2ppK3drektSZXEyTlNwNUx3?=
 =?utf-8?B?cGRTMmU3aFlnZVhiRU91c0plbkQ1NktaY0QvVGY5ZkVFSHZySnBjWGVzYllC?=
 =?utf-8?B?ZVNDazFORHdoM2JqazJ4UjBhQlFFZkNzTXZkc0RQYVIwNGJ6NDFxeW5uR0hj?=
 =?utf-8?B?TGRkSy94NVZSZnZYT0hlckRCaWE2Qy90cHlPVFRpUjh4b2tkMTNCUmQrOG4r?=
 =?utf-8?B?Q2liQllOenRVbks5Rkw5ZmlNM0JLQ3JWblluOGQxcmNWTXhncHZCMDB6ZUp6?=
 =?utf-8?B?c3cyLzVQQi94ZllnTkxnK2lVNlorRlZlVklIVERWM1YraklUaFQvdVh0b2ZG?=
 =?utf-8?B?MG1PTlphUlFlS25zcTl6bWlmeFltd1FkNDNrUmRacS9COEtTeDB3dzVYNTVo?=
 =?utf-8?B?WEduWHJIN0pPNllUa2E5RENSNEp2ZkJTK2dNaDB1aGIxQWVWZzFqNnl6K1h6?=
 =?utf-8?B?Smh0K3g1Qmw2Sm92SXQrRzg0amp5UVBEcURPdzZyRHhpSlBtTXpkL291SElG?=
 =?utf-8?B?elE0elVvUWt1VjJJNUdTaTFVd0hOYXpLOGlQYlZUY1YxTGo1Z2JMV0NjY1ZF?=
 =?utf-8?B?Z3g0cERSSkhZN3MzQjVuQW5ma1dLeHdkODJudXdEck5MWjJKRUtNMElYQ0hv?=
 =?utf-8?B?R29lbVNELys2SmZHRUIvNHo0NW9rOUxKbG1VL1BoTGxsMFZWQTBxVEZSMjFp?=
 =?utf-8?B?MmJ0bzVsYURkZ09lb3IzaUNBME5naytuSktkbTF1elRadUVJZjQreXd4NzRT?=
 =?utf-8?B?azFKWkloQmxrckhiN2x5dFYrM1BBRzA2TEM5QU9iUzByazlIS2RJeW1vRlpR?=
 =?utf-8?B?eThOWTY3bVc2azhTOEpxOGtjQ2FEL2pOMzVYUGg1YVJORmkwMTJFamRXaEY1?=
 =?utf-8?B?SFB6Tk4zQmJtVXNWTUdLR0QrNHdMK09zWEpZZFNFOS9uQU5GVWVSYnVreU1o?=
 =?utf-8?B?ZzM1NDlkZ2Vnamk0TUFtQmUySzlhdjY5VTBLWC9ZVy9uWkZpT1ErZjN2YlBr?=
 =?utf-8?B?eTZHVEdPeWhudWpIb21TTnY2d0s3UVNqYmJ2UGt1dWwvcGo4UVFXNThYU1dY?=
 =?utf-8?B?MDVDamM5c3FjZ1M5dHM3S2VQaTVxYUt0eEhEcW40TjE4UjY5VTNMSHN3MWZN?=
 =?utf-8?B?SldsSStBODVPbXVZZERuRmM4a1BXck83MnV0TlBPMkNFcVJ5UlQrdHFaMGIx?=
 =?utf-8?B?U0Rqb25WM3hZcUpaY1B3MkpOV3gxd0ZBRXhtRExHMUVXaXFiRkpueE1pUmR5?=
 =?utf-8?B?MmRDOGZRWnA1QmpGaCsyWFFwelNCdG5hVEJNTzJYQ2dUSitpYUxjWDBTbzFY?=
 =?utf-8?Q?iVeFc1oDxKw97q0AiMwP/GhmBNE0kZfT7vqta+v?=
X-MS-Exchange-CrossTenant-Network-Message-Id: d3b0e143-b1bb-45c9-ff11-08d98cd4c6e7
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2021 16:32:54.9068
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: I+Xjm/e69YVvJtCHNf0zyqtPAGrg6U9irVYg/gW63OeGlnRmPFD/DioDESyhldjbAZRdMk6iKWYHCl9hvqmtqg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB3369
X-OriginatorOrg: citrix.com

On Mon, Oct 11, 2021 at 02:16:19PM +0000, Bertrand Marquis wrote:
> Hi Roger,
> 
> > On 11 Oct 2021, at 14:57, Roger Pau Monné <roger.pau@citrix.com> wrote:
> > 
> > On Mon, Oct 11, 2021 at 01:40:30PM +0000, Bertrand Marquis wrote:
> >> Hi Roger,
> >> 
> >> + Oleksandr to have a better PCI expert then me.
> >> 
> >>> On 11 Oct 2021, at 14:20, Roger Pau Monné <roger.pau@citrix.com> wrote:
> >>> 
> >>> On Mon, Oct 11, 2021 at 12:11:04PM +0000, Bertrand Marquis wrote:
> >>>> Hi Roger,
> >>>> 
> >>>>> On 11 Oct 2021, at 12:47, Roger Pau Monné <roger.pau@citrix.com> wrote:
> >>>>> 
> >>>>> On Wed, Oct 06, 2021 at 06:40:27PM +0100, Rahul Singh wrote:
> >>>>>> ARM architecture does not implement I/O ports. Ignore this call on ARM
> >>>>>> to avoid the overhead of making a hypercall just for Xen to return
> >>>>>> -ENOSYS.
> >>>>> 
> >>>>> What is the cal trace of this function actually on Arm?
> >>>>> 
> >>>>> AFAICT libxl will only call xc_domain_ioport_permission if there are
> >>>>> IO ports explicitly defined in the guest configuration, or if any of
> >>>>> the BARs of the PCI device is in the IO space, which is not possible
> >>>>> on Arm.
> >>>> 
> >>>> PCI devices BARs can be in the IO space as the PCI devices are not
> >>>> Arm specific. There is not ioports on arm so to be used those can be
> >>>> in some cases remapped and accessed as MMIOs or are not possible
> >>>> to use at all.
> >>>> 
> >>>> But the IO space does appear when BARs are listed even on Arm.
> >>> 
> >>> Urg, I wonder whether those devices with IO BARs will work correctly
> >>> under Arm then.
> >>> 
> >>> How do you know whether the BAR has been remapped from IO space into
> >>> MMIO?
> >> 
> >> We cannot, I think the platform will define if this is the case and where.
> >> @oleksandr: I remember that this was discussed during some of our
> >> meetings but I have no idea of the details here, can you help ?
> >> 
> >>> 
> >>> IMO instead of faking a successful return value from
> >>> xc_domain_ioport_permission we should avoid the call completely in the
> >>> first place, specially if we need to instead issue a call to
> >>> xc_domain_iomem_permission.
> >> 
> >> At the end we will never have to issue this because this will never be a matter
> >> of “iomem” permission as there would not be any way to cut on something under
> >> the page. If this is to be supported one day, it will probably have to be fully emulated
> >> to keep the isolation.
> > 
> > So you have a set of memory pages that map accesses from
> > MMIO into IO space but it's not possible to isolate specific IO port
> > regions as they are all contiguous in the same page(s).
> 
> Exact.
> 
> > 
> >> Right now on arm you can just make the more simple assumption that ioports are
> >> just not supported.
> > 
> > Would it make sense in the future to provide a memory region to guests
> > in order to use for IO port accesses, and call
> > xc_domain_ioport_permission to set which ports would be allowed?
> 
> Right now we do not plan to support this at all and we will have to
> figure this out if we do this one day.
> 
> > 
> > I think the commit message needs to at least be expanded in order to
> > contain the information provided here. It might also be helpful to
> > figure out whether we would have to handle IO port accesses in the
> > future on Arm, or if it's fine to just ignore them.
> 
> All our investigations and tests have been done without supporting it
> without any issues so this is not a critical feature (most devices can
> be operated without using the I/O ports).

IMO we should let the users know they attempted to use a device with
BARs in the IO space, and that those BARs won't be accessible which
could make the device not function as expected.

Do you think it would be reasonable to attempt the hypercall on Arm
also, and in case of error (on Arm) just print a warning message and
continue operations as normal?

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Mon Oct 11 16:37:54 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 16:37:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.206357.361907 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZyJE-0008Mr-JP; Mon, 11 Oct 2021 16:37:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 206357.361907; Mon, 11 Oct 2021 16:37:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZyJE-0008Mk-GK; Mon, 11 Oct 2021 16:37:52 +0000
Received: by outflank-mailman (input) for mailman id 206357;
 Mon, 11 Oct 2021 16:37:52 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=rMo6=O7=citrix.com=anthony.perard@srs-us1.protection.inumbo.net>)
 id 1mZyJE-0008Me-4B
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 16:37:52 +0000
Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 92f3eeac-2ab1-11ec-80ec-12813bfff9fa;
 Mon, 11 Oct 2021 16:37:51 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 92f3eeac-2ab1-11ec-80ec-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1633970271;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=XlKJpIUE3UGy9C8tSy3dP5WgcSVqWoye1hTcfBmgpqQ=;
  b=SW6Ap15Q1totEzoYDuCTYHxbYJrXZJEJYqHYX+znvUK1i56U0FBOEZ8B
   uRDsvnsQmRHAibcVPOcQrmNH1aw5aOAlf9TFbwKCjyFcRsVdVjZDBB3Af
   ya5JLMdQupsZCKutktmBWDpOFv699lqdzvyqJD32UzAhFfgTOSL0oh77N
   s=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: PdyW0O+b5+D+IODLioCQtExeE2Esuo6XBB8pwYXXMPq4Ca3Ch2MNwxtly8FrYrrrPrUfwGy9W/
 DsLaJenWuvbahWtxHfejERttRc8y4vhtSBJeNSETiVw+xyGQpX30S+9LIEv1ZRnUtSGO7qxb6/
 hI+hB9ND/vZ5hg6+IufYf6KkqmqTODgoxbn29uv1FtG00NEWdmmhP0J9BX/bOBi99WSoSAaDcj
 SUWRU3KK4/bi9glaUmOiinp6eu5OMgoNNVPrOIlfxMyU1Wh3AhS+IsreFOSPq8vD6uIi6D/eC0
 FAj7kuMdMj/5mAOPkP09JDZX
X-SBRS: 5.1
X-MesageID: 56771204
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:uliClK+/biLTm9t3BLotDrUDVniTJUtcMsCJ2f8bNWPcYEJGY0x3n
 GcaWGyAPazfZGrwe99yPYu2oEoB7Z/TyoNmGQJp+X88E34SpcT7XtnIdU2Y0wF+jyHgoOCLy
 +1EN7Es+ehtFie0Si9AttENlFEkvU2ybuOU5NXsZ2YhGGeIdA970Ug6wrZg29Yx6TSEK1jlV
 e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH
 I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPhp9
 IhOrJK6cD15FaGQgc1aWD5ZEiVXaPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us
 6ZCcXZUM07F17neLLGTE4GAguwqKtXrO4UO/Glt1zjDAd4tQIzZQrWM7thdtNs1rp0QQqmHP
 ZJFAdZpRDbRTjhSOxAcNMsvkKT310jjVRNfhXvA8MLb5ECMlVcsgdABKuH9cNGQWd9cmEreo
 2vc5nn4GTkTLtnZwj2Amlq0j/LLtTP2XsQVDrLQ3vxgjUCXx2cTIAYLTlb9qv684makUtJCL
 woP+ywhrYA77kntRd74NzW6r2SDpQU0QMdLHqsx7wTl4qvL4S6JC24cVDlDZdc68sgsSlQC0
 VuEnMjgAzB1h7STRWiA7befrT60Oi89IHcLYGkPSg5ty9v+pIA+iDrfQ9AlF7S65vXlFDe1z
 z2UoSwWg7QIkdVNx6i95UrAgT+nut7OVAFdzgzRUnj/tlshTIGgbo2sr1Pc6J5oN52FR1OMu
 HwFncm27+0UC5yJ0iuXT40lNau16vOyFSzTiF9iAbEs7z2ovXWkeOh4/jZ6I0t4N9ceTjXga
 kTTpAB56YdaOT2haqofS4W1BscxxK7sD+P5R+vUZdpDZJt2XAKf9SQobkmVt10Bi2B1z/t5Y
 83CN5/xUzBKUsyL0QZaWc8F7eIo3y40/FmDbpyn1j3g2p2fZXq8HOJt3ES1Usg166aNoQPw+
 tlZNteXxxg3bNASchU74qZIcghUdSlT6YTe7pUNLLbac1UO9HQJUqeJmdscl5pZc7O5fwsi1
 kq2XVNE0xLBjHnDJBTihptLOe63A8gXQZ7WO0UR0beUN5oLPdbHAEQ3LcJfkVwbGApLl6Mco
 x4tIZToPxi3Ym6bkwnxlLGkxGCYSDylhBiVIw2uayUlcphrSmTho4G/JVu+rHZXV3bp7qPSR
 oFMMCuAG/LvoCw4Xa7rhA+HlQvt7RDxZsojN6c3HjWjUBq1q9U7Q8AApvQ2P9sNOX3+Ksiyj
 G6r7eMjjbCV+ecdqYCR7Yjd9tvBO7YuTyJyQjiAhZ7rZHayw4ZW6dIZOAp+VWuGDz2cFWTLT
 bg98swQx9VexAwU7NEmT+oypU/8jvO2z4JnIs1fNC2jRzyW5nlIeBFqBOFD6f9AwKF3owyzV
 h7d89VWI+zRasjkDEQQNEwuaeHajaMYnTzb7PIUJkTm5XAooOrbABsKZxTc2jZAKLZVMZ8+x
 btzssAh9AHi2AEhNcyLj34I+j3UfGAASaguqroTHJTv1lgw0lhHbJGFUn327ZiDZs9iKE4vJ
 jPI1qPOi64FnhjJcmYpFGiL1u1Y3MxctBdPxV4EBlKIhtua2aNngEwPqWw6F10HwA9G3uR/P
 nlQG3d0fajerS11gMVjXny3H10TDhOu5UGsmUACk3fUThf0WzWVfnE9I+uE4GsQ73lYImpA5
 LidxWvoDWTqccX20ndgUEJpsaW+H9l49wmEk8G7BcWVWZI9ZGO90KOpYGMJrTrhAN8w2xKb9
 bU7or4oZP2pLzMUro06F5KehOYZRx2zLWBfRe1sofESFmbGdTDugTWDJihdoC+WyyAmJaNgN
 /FTGw==
IronPort-HdrOrdr: A9a23:tZO7i6wt6NYWvSqA0MexKrPwLL1zdoMgy1knxilNoRw8SKKlfu
 SV7ZAmPH7P+VMssR4b9OxoVJPtfZqYz+8T3WBzB8bBYOCFgguVxehZhOOIqQEIWReOldK1vZ
 0QFZSWY+eQMbEVt6nH3DU=
X-IronPort-AV: E=Sophos;i="5.85,364,1624334400"; 
   d="scan'208";a="56771204"
Date: Mon, 11 Oct 2021 17:37:06 +0100
From: Anthony PERARD <anthony.perard@citrix.com>
To: Oleksandr Andrushchenko <andr2000@gmail.com>
CC: <xen-devel@lists.xenproject.org>, <julien@xen.org>,
	<sstabellini@kernel.org>, <oleksandr_tyshchenko@epam.com>,
	<volodymyr_babchuk@epam.com>, <Artem_Mygaiev@epam.com>,
	<roger.pau@citrix.com>, <jbeulich@suse.com>, <andrew.cooper3@citrix.com>,
	<george.dunlap@citrix.com>, <paul@xen.org>, <bertrand.marquis@arm.com>,
	<rahul.singh@arm.com>, Oleksandr Andrushchenko
	<oleksandr_andrushchenko@epam.com>, Ian Jackson <iwj@xenproject.org>,
	"Juergen Gross" <jgross@suse.com>
Subject: Re: [PATCH v5 07/10] libxl: Only map legacy PCI IRQs if they are
 supported
Message-ID: <YWRoMtLTd4G55koT@perard>
References: <20211008055535.337436-1-andr2000@gmail.com>
 <20211008055535.337436-8-andr2000@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20211008055535.337436-8-andr2000@gmail.com>

On Fri, Oct 08, 2021 at 08:55:32AM +0300, Oleksandr Andrushchenko wrote:
> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> 
> Arm's PCI passthrough implementation doesn't support legacy interrupts,
> but MSI/MSI-X. This can be the case for other platforms too.
> For that reason introduce a new CONFIG_PCI_SUPP_LEGACY_IRQ and add
> it to the CFLAGS and compile the relevant code in the toolstack only if
> applicable.

I don't think that's true anymore since v2 ;-). The compiler may
choose to avoid compiling code that wouldn't be executed, but I think
that would just be optimisation.

> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
> Reviewed-by: Rahul Singh <rahul.singh@arm.com>
> Tested-by: Rahul Singh <rahul.singh@arm.com>
> ---
> diff --git a/tools/libs/light/Makefile b/tools/libs/light/Makefile
> index 7d8c51d49242..bd3f6be2a183 100644
> --- a/tools/libs/light/Makefile
> +++ b/tools/libs/light/Makefile
> @@ -46,6 +46,10 @@ CFLAGS += -Wno-format-zero-length -Wmissing-declarations \
>  	-Wno-declaration-after-statement -Wformat-nonliteral
>  CFLAGS += -I.
>  
> +ifeq ($(CONFIG_X86),y)
> +CFLAGS += -DCONFIG_PCI_SUPP_LEGACY_IRQ
> +endif
> +

Could you write this instead:
  CFLAGS-$(CONFIG_X86) += -DCONFIG_PCI_SUPP_LEGACY_IRQ

In any case,
Acked-by: Anthony PERARD <anthony.perard@citrix.com>

Thanks,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Mon Oct 11 16:44:17 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 16:44:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.206364.361918 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZyPL-0001LB-AD; Mon, 11 Oct 2021 16:44:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 206364.361918; Mon, 11 Oct 2021 16:44:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZyPL-0001L4-68; Mon, 11 Oct 2021 16:44:11 +0000
Received: by outflank-mailman (input) for mailman id 206364;
 Mon, 11 Oct 2021 16:44:09 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=pkLr=O7=citrix.com=roger.pau@srs-us1.protection.inumbo.net>)
 id 1mZyPJ-0001Kx-Mw
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 16:44:09 +0000
Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 729d3b9e-2ab2-11ec-80ec-12813bfff9fa;
 Mon, 11 Oct 2021 16:44:07 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 729d3b9e-2ab2-11ec-80ec-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1633970648;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=S1rqXYZaV7pXDs7iPThz9xdfs2if+0NebwX/ly+B9RQ=;
  b=FaXdtduqcLszvM5fsflIbS/9mOr+7LOeBVKsB0AKE6XJCcz7nXqBn5fE
   4osM54Qt/GPmOj4vOfs1q7nPMRTrnvNpeOEFqNqMZGIGw04KPaqkwWkhl
   VsifOuu8OUk9esI/6nkSnXD9v9kNxqZLbVCCh1nCAHWZQbkiF0KRCnny7
   s=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: Uc0RzrxFljNSYCxXd3d5oHrvpqj0EXOlvvaAtICyxGWtcC5HiVpcgK7k/EluwhrkI0tgw2H1o/
 9J94r6D7wTMxC3w4y/Zn5OI9K6S4w2cozm7YKDTyAXUJmEuWQrQiXkE+3kyHJZOUmpZRqR2LtR
 XY8uKkQej6wnskHuXmKuhkQ21JyB28mnZQBi8BQ/MdnX+7dlYkpYbiaCnZJ5HguSOaIXLdX1gu
 T+JUZhhfU5ksCVI/5AjIPuGF3tRtZh17hsMlXA2QYiy0S5jFpmIgpLCw4/GJI6McUr9pb9eNIl
 vpJ342fBIMIoy8PXqhC0jeba
X-SBRS: 5.1
X-MesageID: 54475770
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:tF52N6xstDID7290f9Z6t+cfwCrEfRIJ4+MujC+fZmUNrF6WrkVTm
 GtLWTqCbKmCZ2Gne4t/bY+ypE9X75/SmoBjQApo+yAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx
 59DAjUVBJlsFhcwnvopW1TYhSEUOZugH9IQM8aZfHAsLeNYYH1500s6w7dg2tcAbeWRWGthh
 /uj+6UzB3f9s9JEGjp8B3Wr8U4HUFza4Vv0j3RmDRx5lAa2e0o9VfrzEZqZPXrgKrS4K8bhL
 wr1IBNVyUuCl/slIovNfr8W6STmSJaKVeSFoiI+t6RPHnGuD8H9u0o2HKN0VKtZt9mGt/xd0
 dlNkYezcxp3NKKcsr4ZeDVWEz4raMWq+JefSZS+mcmazkmAeHrw2fR+SkoxOOX0+M4uXzsIr
 6ZBbmlQMFbT3Ipaw5riIgVort4kI8TxepsWp1lrzC3DDOZgSpfGK0nPzYIEgGht2Z8WdRrYT
 8MERhpGUwzqWjdGEWkvUbYOzcSEhHaqJlW0r3rK/PFqsgA/1jdZ0afvGMrYfMSQQsdYlVreo
 XjJl0zHBRUdOM2a2CCy2Humje/Sngv2QIsXUra/85ZCgkCXx2EVIA0bUx28u/bRola3RtZ3O
 0ESvC00osAa60iDXtT7GRqirxasvBQRRt5RGO0S8xyWx+zf5APxLnINTiNFLscnssA2bTUw0
 xmCmNaBLTZiqqGPQHSRsLKdtyqvODM9JHUHIyQDSGMtxN3uo5o6iB7Vef9lHLSold3+GTz2w
 DeioTA3gvMYistj/76g4VnNjjaop57IZg04/APaWiSi9AwRTKeja5alr2DB/+dfJZyQZlCbu
 T4PnM32xPADC9SBmTKARM0JHaq1/LCVPTvEm1ltEpI9sTO39BaekZt4uW8kYh0za4BdJGGvM
 BS7VR5tCIF7EFezYa9TeIGLFpogwvjKT9DOev7UcY8bCnRuTzOv8CZrbE+W+mnilkkwjK0yU
 aumndaQ4WUyUvs/kmLnLwsJ+fpynHpmnDKMLXzu503/ieL2WZKDdVsS3LJihMgC56SYvB6dz
 d9bM8abo/m0eLyjOneJmWL/wFZjEJTaOXwUg5AHHgJgClA/cI3ENxM36el8E2CCt/4E/tokB
 lnnBidlJKPX3BUr0zmiZHF5c6/IVp1it389NiFEFQ/2gCNzMN7wtf5DKcBfkVwbGApLlqQco
 x4tIZToPxiyYm6fp2R1gWfV/eSOiyhHdSrRZnH4MVDTjrZrRhDT+8+MQ+cc3HJmM8ZDjuNn+
 +fI/lqCGfIrHl0+ZO6LOKPH5w7g5hA1xbMtN3Yk1/EOIS0ABqAxcHev5hL2SulRQSj+Ksyyj
 l7MX0hD/7WR+ufYMrDh3Mi5kmtgKMMndmJyFGjH97emcy7c+2uo24hbV+iUOzvaUQvJFG+KO
 Y25Ftnwb68KmkhkqY15H+o5xK4y/YK39bRb0h5lDDPAaFHyUuFsJXyP3M9usKxRx+AG5VvqC
 xzXotQKa6+UPM7FEUIKIFZ3ZOq0yvxJyCLZ6u44IRum6XYvrqaHS0hbIzKFlDdZcOluKIogz
 Op44JwW5gWzhwAEKNGDiiwIpW2AImZZC/cst40AAZ+tgQ0ukwkQbZvZAy7wwZeOd9QTbRV6f
 m7K3PLP3u0OyFDDfnw/EWn28dBc3Zle6gpXyFIiJkiSnoaXjPEAwxAMoy88SR5Yz0sb3rsra
 HRrLUB8OY6H4yxs2JpYR2mpFgxMWE+Z90j2xwdbnWHVVRD1BGnELWl7MueR5kEJtWlbe2EDr
 r2fzW/kVxfsfd3wgXRuCRI09aS7QIwj7BDGleCmA9+BTsszbjfSi6OzYXYF9kn8CsQriUyb/
 eRn8Y6cs0Eg2fL8d0HjN7Sn6A==
IronPort-HdrOrdr: A9a23:LGL4B6HOdvQyLhTNpLqFeZHXdLJyesId70hD6qkvc3Nom52j+/
 xGws536faVslcssHFJo6HmBEClewKnyXcT2/htAV7CZnichILMFu9fBOTZsl/d8kHFh4tgPO
 JbAtRD4b7LfClHZKTBkXCF+r8bqbHtmsDY5pav854ud3ATV0gJ1XYGNu/xKDwReOApP+tcKH
 LKjfA32AZINE5nI/iTNz0gZazuttfLnJXpbVovAAMm0hCHiXeN5KThGxaV8x8CW3cXqI1Svl
 Ttokjc3OGOovu7whjT2yv66IlXosLozp9mCNaXgsYYBz3wgkKDZZhnWZeFoDcpydvfpGoCoZ
 3pmVMNLs5z43TeciWcpgbs4RDp1HIU53rr2Taj8DPeiP28YAh/J9tKhIpffBecwVEnpstA3K
 VC2H/cn4ZLDDvb9R6Np+TgZlVPrA6ZsHAimekcgzh0So0FcoJcqoQZ4Qd8DIoAJiTn84oqed
 MeTf003MwmM29yUkqp+1WGmLeXLzAO91a9MwY/U/WuontrdCsT9Tpe+CQd9k1wva7VBaM0od
 gtn8xT5cVzp/QtHNBA7dE6ML2K41z2MGHx2V2pUCHa/YE8SjnwQs3Mkf8IDN/DQu1+8HJ1ou
 WZbG9l
X-IronPort-AV: E=Sophos;i="5.85,364,1624334400"; 
   d="scan'208";a="54475770"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Ux8R6Uei7JwkAhafTcpWgmp6w4ScKoCTT9EUn8N2z1AScJLO9oyaj/CbubasLc58HR5vGHLjUV85vJZsUgRK2Bl1E9Xdi9DAgh0H+MWWlrturFhMPqhyfYlB1q8VN7jXpPq6pAUFSOEmX1kDUuoBrcmW32kmnNVt2cDuHeYGlFLjKocb49B47Zy7O2Cqu3Pt8EeinU2uH0ruFqMSpDQyeTWzn1HS/dP2HC7QeXjVq9YMBTDk4UvU3nfkWwIJ2P769HsRw+Xc1i7O4cd2Jtn7ZsGgZzVSUAeU0LP8QNNsjOF+91eAE+BU3TyaayPpGFBJHy4hx8oQh2bvN3LAM4ox9g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=0deLUC8u2RvmRqtUeggx4LBst74D/t8DUDFCiI4AcCs=;
 b=N7fm8dSztivW0wunJntsWjqKJZWtAM2XxET048Lj3RL654zyy9iXmpO/s/rdnEpo7laX+/mBzN18IK+DcXMtmLHnfZx/Z4lGrmmSqpnb1P+SPo8XNIDhQvM/0BuP59ikyKffjtx77HfKMqtLZJikgup9YDQr2k95/RnxQz+TNSl1k1v5zhZR3wLy2Ljz1Zome3ouFJC3sKZW8vYPodbxTXT4RtgIYPaU42iSYPe8vPvfGb2FxAXp7kohaCHjemB7dKbHDtohJudiH0sJzhzBHenunVczci9bVn99flwC8bLJCVGQqfaL6+4IaRWq5qilxMV3lTjqFoOFZUxBelJ6/w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=0deLUC8u2RvmRqtUeggx4LBst74D/t8DUDFCiI4AcCs=;
 b=Y+Bv7FFPgwLYDrIGVYeTRs9YknEzf5cK8SSouQx6+V/5xKl1iDbQsg8sTAssPdgMw7NrmZIBg4Qk3jif8/CXW1gMaaVC/RlciFouJ2Cy715miXb/BFsNXZhCT98HS+BicUfCtj407Dx+BWueq5so1PS/BE6nmrQRZS9Z01OXkQk=
Date: Mon, 11 Oct 2021 18:43:37 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
CC: Bertrand Marquis <bertrand.marquis@arm.com>, Rahul Singh
	<rahul.singh@arm.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, Andre Przywara <Andre.Przywara@arm.com>,
	Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, Andrew Cooper
	<andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>, Ian
 Jackson <iwj@xenproject.org>, Jan Beulich <jbeulich@suse.com>, Wei Liu
	<wl@xen.org>, Paul Durrant <paul@xen.org>
Subject: Re: [PATCH v5 08/11] xen/arm: Enable the existing x86 virtual PCI
 support for ARM.
Message-ID: <YWRpuUtHkyA4RY5H@MacBook-Air-de-Roger.local>
References: <cover.1633540842.git.rahul.singh@arm.com>
 <9bdca2cda5d2e83f94dc2423e55714273539760a.1633540842.git.rahul.singh@arm.com>
 <YWQXF2vDaWQvi+bT@MacBook-Air-de-Roger.local>
 <4F406854-4F90-48F6-8470-6CCB60A3CB77@arm.com>
 <e199bfe2-0bcc-989f-fd4a-ecf44a3cd1ac@epam.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <e199bfe2-0bcc-989f-fd4a-ecf44a3cd1ac@epam.com>
X-ClientProxiedBy: LO2P265CA0242.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:8a::14) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 53d4dbd9-43d6-4338-ab94-08d98cd64902
X-MS-TrafficTypeDiagnostic: DM5PR03MB3212:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <DM5PR03MB32122C45B08030E6742F13368FB59@DM5PR03MB3212.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: xhRj3SqCXZf2YJ9MUZmm/q4IkUvd/psPHp4hKViSqRlpwihhF0R3nJytd5HlWHnjHdHnC4qZeML2ZdqnkKaeSN+ipmlT98krBBCD1Htt/6b0uwzKn+EM46ipEcL3XQ+52Pp844d0/Dp7TYuObuoqptF2BfWEjeWspyYUhzl4P97GMm+lXltg3ydOrvaxXK5Exs+X9l9U2cuvswpmFKORVI5bi9OX15KokURcPBPURja830mrfAPJcp0scbY0O0TvGnPoZ93281CJoL7du+yKhsmRp+9mbOhaEfz0jfrhhAgSuG0wAb4mTOoBXyLglHzgZAFYIG1V4ajV8hzZALyTt4d2E4+u4EjpchAXfhM9oNhHykJ1PrGkPsmoDw9zYGgrTB7rrwKVPzRSfCVE/CjGEQr4bx5/b0dM2EwbZdd8lgM7YWFq3C/AxZmCez43nM941a0sdRKEGKLhdJ1zjfdoKzLV/CHuBN0HusIwk04qoWyZDU1P1uBoQB8SZBIXIuxQzRDo/zavxQBXxbpEq9pBkWirfVD+Zy0DOr/0oQYii2i02IvFYlieYNtCvlKSm9FkaHCBZU1LSmBp65JbGUKDluq6Ie4xllSzYmvayno4KEfDrfSDKu641vynSo0MUWakwPiUFqXg1al53gUjYeTVag==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(6496006)(66556008)(66476007)(86362001)(53546011)(508600001)(5660300002)(8936002)(66946007)(8676002)(7416002)(4326008)(6916009)(2906002)(38100700002)(186003)(83380400001)(316002)(54906003)(6666004)(956004)(9686003)(6486002)(26005)(85182001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YkJxcGVNcml2SXdqcXVuVkc4QTBkM2daREUxOXdqWmxNWjdEblQvRFFrakFZ?=
 =?utf-8?B?VmpCMy9UcnFOMFlNWm15akxWcFlDNWxMK3ZZd3Y2MHlsMVJvT09pbzYrMnlI?=
 =?utf-8?B?N3RpYkdPemQ3RVJiRXcwY0xFRW0wSFJmeks4bmdvUE1FWEl6anhRRTB0UmVo?=
 =?utf-8?B?UHdCY3dIZHUzcmxBK0JUWjNWaUI2NEhKTzQzZHllV2NPMFNDK0gwbGhYWGFC?=
 =?utf-8?B?eTlLL21PQ0M1WFdVZFJzV2hRL3dhWjhLZktxam90b293dEMwUDBncy9qeE5x?=
 =?utf-8?B?VjByMUNGVVNEOWMvQXlPSHZ4cjlyVm9UV01PcWdLK1NsemtFa3A5M2tFRGtP?=
 =?utf-8?B?QU0zZUJFN1RHWTFuSi9YaVJmWnp3c0w0OXd4b1JnUmxRMXdHaTd0bjdDVGhq?=
 =?utf-8?B?S0NLS1A3Z3ZZbEo0eEdmQUcxdktZM1FPMU9wVHZEWFYyTlFEcWhmNnlEZHBO?=
 =?utf-8?B?bHRNSDVsU21TZlUxYllTQ1QvL3E4VXhtY0ppSWJtRkg3bnI2ZXUwamlTL3VW?=
 =?utf-8?B?U0NodGovWGxjajRyN3lPQ3gyKzdxZ1dQMEFpSEpPZHVNVVpZL1NZbXZ2QVhp?=
 =?utf-8?B?elJqYmJSQ0R2Z1VGVnNtL0RBNUNkTzJxNGR0VjQwTjZvc1YzQTVYclpMUzdo?=
 =?utf-8?B?bG5Sd1dUdHE5S1NJZ2xpN205MkpFdTB6WXNzMW55MEtFcEw4RXpWZDJjWW1m?=
 =?utf-8?B?T3dYUE9UME9ZN2lEUmNhQmV4UlFMRDdWRm45cnIxQTZ1dUZqSFlvZGJYdEh5?=
 =?utf-8?B?RW4wSDVERHV1TEpjWnRZZk1mU1VqMlBTV2RyMklIRmpPYStoM3BkNU9CSkpO?=
 =?utf-8?B?ZFJlc2VFNlhobFpJTFM1dktQandPdFI3cURobEMxZmJXOS9ibk1BNWl0Uyt2?=
 =?utf-8?B?VjlnQU5vdVROMmxrYTdtR1ovblg0dGVkL1FrbmtEdmgwVExRajhXOFo5TVVp?=
 =?utf-8?B?TThYclNWbnBiMHJZd3R1U1d0TGx6SUsyYnR5cVZRejQ2SDlaVjhiMmVrVG82?=
 =?utf-8?B?alBrZHE3M0Y0ZmxRQlJwcVZRQVNYN3M2cmJGS3Q4Z1k0b29GSEZlM0tzZWpp?=
 =?utf-8?B?bDBKS213YmtTdDJxVTUzUXB6aEpvVXo0dW1pTG5SUDdXcTR3cGlWOFlYSGlR?=
 =?utf-8?B?YjM3dGZSZG5mMTEveHBYY2hFMlVUbGppaHN6cGcxRTd4NFVJRFJxZzhYOGNo?=
 =?utf-8?B?aGxXbXlTSWtYMlE4WXdEWU91eVhLQ0U1QXFsb2gyWDhOMlh0VU1sYlhRblZT?=
 =?utf-8?B?VkFVYWFUSkZVWTdIN1dmZWVUQ1dkaHJ5akZVOHJ1WnJmWEcxZ01pdk9HTkFH?=
 =?utf-8?B?M0s4emR1STcxZnV6OUhkZS9PekdUR1ZxcURQbTNqQnVObGJTbjVxMzdSR2Y1?=
 =?utf-8?B?VEFOQjFwWmpqbjhtWDdNbmxkSm5vQWpvOERWVmZVZS9hUzBCNlBYaTRORnZ4?=
 =?utf-8?B?ZEhDeG95TGRNak50Skl3akdlRWovV3FXbUJ3TDc0cGliUEYwZlVuY3dJaUpy?=
 =?utf-8?B?em1lckN3UXNkYTJvblRoRGRoR01QWE84WUxkT1plMkE4YTJicmtob2VRRFVH?=
 =?utf-8?B?cU5FK3hHemxvZEYvMkJkNmd5Q09aWVo3eERtbTJvOGxsb3Y3NWhhL1NDT3Rn?=
 =?utf-8?B?OUdFYklDYkFYMjVXYTE2R0Vlb2JTamFBTXpYTDFCSXQ2STFlczMybFNUWEVh?=
 =?utf-8?B?aGVmN0l3TjJZTHQyWEVnSkN4R0h2ZW1xVHoxdkY5VHlvbGtMQ1diMWRyZm9C?=
 =?utf-8?Q?kIIAZu2J8zcSRzBbeLS3vaHXJgOzQ5umKJMouJc?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 53d4dbd9-43d6-4338-ab94-08d98cd64902
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2021 16:43:42.7309
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zdUH7G62Mx8xjyZ0rNFMZr7qjGCxC7CkfyKh2BGNmvmlj/lJO+bV2kGHhuhF23XlS5jgrQHy+eZDPtFU0dbJ1w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB3212
X-OriginatorOrg: citrix.com

On Mon, Oct 11, 2021 at 04:20:14PM +0000, Oleksandr Andrushchenko wrote:
> 
> 
> On 11.10.21 19:12, Bertrand Marquis wrote:
> > Hi Roger,
> >
> >> On 11 Oct 2021, at 11:51, Roger Pau Monné <roger.pau@citrix.com> wrote:
> >>
> >> On Wed, Oct 06, 2021 at 06:40:34PM +0100, Rahul Singh wrote:
> >>> The existing VPCI support available for X86 is adapted for Arm.
> >>> When the device is added to XEN via the hyper call
> >>> “PHYSDEVOP_pci_device_add”, VPCI handler for the config space
> >>> access is added to the Xen to emulate the PCI devices config space.
> >>>
> >>> A MMIO trap handler for the PCI ECAM space is registered in XEN
> >>> so that when guest is trying to access the PCI config space,XEN
> >>> will trap the access and emulate read/write using the VPCI and
> >>> not the real PCI hardware.
> >>>
> >>> For Dom0less systems scan_pci_devices() would be used to discover the
> >>> PCI device in XEN and VPCI handler will be added during XEN boots.
> >>>
> >>> Signed-off-by: Rahul Singh <rahul.singh@arm.com>
> >>> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
> >>> ---
> >>> Change in v5:
> >>> - Add pci_cleanup_msi(pdev) in cleanup part.
> >>> - Added Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
> >>> Change in v4:
> >>> - Move addition of XEN_DOMCTL_CDF_vpci flag to separate patch
> >>> Change in v3:
> >>> - Use is_pci_passthrough_enabled() in place of pci_passthrough_enabled variable
> >>> - Reject XEN_DOMCTL_CDF_vpci for x86 in arch_sanitise_domain_config()
> >>> - Remove IS_ENABLED(CONFIG_HAS_VPCI) from has_vpci()
> >>> Change in v2:
> >>> - Add new XEN_DOMCTL_CDF_vpci flag
> >>> - modify has_vpci() to include XEN_DOMCTL_CDF_vpci
> >>> - enable vpci support when pci-passthough option is enabled.
> >>> ---
> >>> ---
> >>> xen/arch/arm/Makefile         |   1 +
> >>> xen/arch/arm/domain.c         |   4 ++
> >>> xen/arch/arm/domain_build.c   |   3 +
> >>> xen/arch/arm/vpci.c           | 102 ++++++++++++++++++++++++++++++++++
> >>> xen/arch/arm/vpci.h           |  36 ++++++++++++
> >>> xen/drivers/passthrough/pci.c |  18 ++++++
> >>> xen/include/asm-arm/domain.h  |   7 ++-
> >>> xen/include/asm-x86/pci.h     |   2 -
> >>> xen/include/public/arch-arm.h |   7 +++
> >>> xen/include/xen/pci.h         |   2 +
> >>> 10 files changed, 179 insertions(+), 3 deletions(-)
> >>> create mode 100644 xen/arch/arm/vpci.c
> >>> create mode 100644 xen/arch/arm/vpci.h
> >>>
> >>> diff --git a/xen/arch/arm/Makefile b/xen/arch/arm/Makefile
> >>> index 44d7cc81fa..fb9c976ea2 100644
> >>> --- a/xen/arch/arm/Makefile
> >>> +++ b/xen/arch/arm/Makefile
> >>> @@ -7,6 +7,7 @@ ifneq ($(CONFIG_NO_PLAT),y)
> >>> obj-y += platforms/
> >>> endif
> >>> obj-$(CONFIG_TEE) += tee/
> >>> +obj-$(CONFIG_HAS_VPCI) += vpci.o
> >>>
> >>> obj-$(CONFIG_HAS_ALTERNATIVE) += alternative.o
> >>> obj-y += bootfdt.init.o
> >>> diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
> >>> index 36138c1b2e..fbb52f78f1 100644
> >>> --- a/xen/arch/arm/domain.c
> >>> +++ b/xen/arch/arm/domain.c
> >>> @@ -39,6 +39,7 @@
> >>> #include <asm/vgic.h>
> >>> #include <asm/vtimer.h>
> >>>
> >>> +#include "vpci.h"
> >>> #include "vuart.h"
> >>>
> >>> DEFINE_PER_CPU(struct vcpu *, curr_vcpu);
> >>> @@ -767,6 +768,9 @@ int arch_domain_create(struct domain *d,
> >>>      if ( is_hardware_domain(d) && (rc = domain_vuart_init(d)) )
> >>>          goto fail;
> >>>
> >>> +    if ( (rc = domain_vpci_init(d)) != 0 )
> >>> +        goto fail;
> >>> +
> >>>      return 0;
> >>>
> >>> fail:
> >>> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
> >>> index c5afbe2e05..f4c89bde8c 100644
> >>> --- a/xen/arch/arm/domain_build.c
> >>> +++ b/xen/arch/arm/domain_build.c
> >>> @@ -3053,6 +3053,9 @@ void __init create_dom0(void)
> >>>      if ( iommu_enabled )
> >>>          dom0_cfg.flags |= XEN_DOMCTL_CDF_iommu;
> >>>
> >>> +    if ( is_pci_passthrough_enabled() )
> >>> +        dom0_cfg.flags |= XEN_DOMCTL_CDF_vpci;
> >> I think I'm confused with this. You seem to enable vPCI for dom0, but
> >> then domain_vpci_init will setup traps for the guest virtual ECAM
> >> layout, not the native one that dom0 will be using.
> > I think after the last discussions, it was decided to also installed the vpci
> > handler for dom0. I will have to look into this and come back to you.
> > @Oleksandr: Could you comment on this.
> Yes, we do trap Dom0 as well. The Dom0 traps are not in this series, but
> are in mine as it needs more preparatory work for that. Please see [1]

Then I don't think we should set XEN_DOMCTL_CDF_vpci for dom0 here, it
should instead be done in the patch where dom0 support is introduced.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Mon Oct 11 17:08:03 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 17:08:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.206375.361929 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZym5-0003jM-4j; Mon, 11 Oct 2021 17:07:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 206375.361929; Mon, 11 Oct 2021 17:07:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZym4-0003jF-WA; Mon, 11 Oct 2021 17:07:40 +0000
Received: by outflank-mailman (input) for mailman id 206375;
 Mon, 11 Oct 2021 17:07:39 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=rMo6=O7=citrix.com=anthony.perard@srs-us1.protection.inumbo.net>)
 id 1mZym3-0003j9-Kk
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 17:07:39 +0000
Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id bc27bd68-2ab5-11ec-80ec-12813bfff9fa;
 Mon, 11 Oct 2021 17:07:38 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: bc27bd68-2ab5-11ec-80ec-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1633972057;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=3lAhJqR1yIwfdL2XvZ3KDYkeBWLCbMSCMnkof54KL68=;
  b=g+95RYCfuRp6z42rEvairY/NE/SI95DDD25gkRYG3TFzcfej17RR1VjX
   9fnMAgHYIkgaE0q4FlUWO30V/3JjMeevy5C1wCYjoqAs1WKLhSGZU6/Ob
   5f1w4byGVzGqGYdie3U3CwylxD9gkXcLeXk9ZRSHlIhw8vYLM+GopLmWN
   M=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: vuYowbn4SKJ/EzlYOZblaQwdvIzobTs9XGsOPmMognUvPkWkIlha/b9/5rCzHvA4wufHBIQcml
 HP4UHRY4LHb/j2eskCleynPvDwJ+UhxEF7s/zrOO14ZubhsNfN1RvkjH1x79mPL4gPUtsjTJtn
 TMG7SBjsLB9/gpoyl8vI3tFGCn/LC33k4srgDylDvhKxIsVHEW8dw5kg6h7sBuy5xG5cGoWgIM
 EMgbjFwahk7iSpVWhHm0GP7LgqhygZdOS+yL+AbveTY/zyklndyhoq8LxNHfXnV48ng8Kyqn8u
 LRgJ3vnXX9zlj4JrEiXXqxGY
X-SBRS: 5.1
X-MesageID: 54477913
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:EZDDK6qCOEcD4eqVOVbzTWGYToheBmKVYhIvgKrLsJaIsI4StFCzt
 garIBnXPqmPZGb1Ktt2bI3loBxV7JaBn9NjG1ZurytjFC8WoJuZCYyVIHmrMnLJJKUvbq7GA
 +byyDXkBJppJpMJjk71atANlZT4vE2xbuKU5NTsY0idfic5Dnd84f5fs7Rh2Ncx2YHgW1nlV
 e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL
 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9
 DlCncztZUA1M7HqorQ6biUBUHluJqxWwbCSdBBTseTLp6HHW37lwvEoB0AqJ4wIvO1wBAmi9
 9RBdmpLNErawbvrnvTrEYGAhex6RCXvFIoZpnFnyyCfFfs8SIrPa67L+cVZzHE7gcUm8fP2O
 pZFNmU+NU+ojxtnA2YnOsIiu+GSvUbQLzRkqgiL5pAl/D2GpOB2+Oe0a4eEEjCQfu1OhVqRr
 G/C+2X/AzkZOcaZxD7D9Wij7sfQmQvrVYRUE6e3ntZ6jVvWymENBRk+UVqgveL/mkO4Q8hYK
 UEf5mwpt6da3E6hQ8T5Xha4iGWZpRNaUN1Ve8U79wOl2qfS+xyeBGUPUnhGctNOnM0rQT0n0
 HeZktWvAiZg2IB5UlrEqO3S92nrf3FIcylSPkfoUDfp/fGz/a10kh/TaOwzN5OJ156tCSrx0
 wmF+X1Wa6ooseYH0KCy/Fbiij2qp4TUQgNd2jg7Tl5J/SsiO9b7P93ABUzzqK8adt7AHwbpU
 G0swpDGtIgz4YexeDthqQnnNIqi4OqZK3XiiFprEohJG9+FqiP7I944DN2TIi5U3ic4ld3BP
 B+7VeB5vsY70J6WgUlfOd/Z5yMCl/mIKDgdfqqIBueim7AoHON9wAlgZFSLw0fmm1U2nKc0N
 P+zKJj3ViZLUfs+lWboHI/xNIPHIAhlnws/orihnnyaPUe2PibJGd/pznPfBgzG0E90iFqMq
 IsOXyd74x5eTPf/ckHqHX07djg3wYwALcmu8aR/L7fbSiI/QT1JI6KBkNsJJt0+94wIx7igw
 51IchIBoLYJrSacclvih7EKQO6HYKuTWlpiZXZyYg3yhyR6CWtthY9GH6YKkXAc3LQL5ZZJo
 zMtJ61s29xDFWbK/Sozd574oNAwfRinn1vWbSGkfCI+b9hrQAmQoo3oeQ7m9S8vCCurtJRh/
 +38h12DGZdTFR5/CMv2ae60yw/jt3Yqh+8vDVDDJcNeeRuw/dEyeTDxlPI+P+oFNQ7HmmmBz
 w+TDBpB/bvNroY5/cPnn6eBq4v1QeJyElADRzvQ7KqsNDmc9W2mmNcSXOGNdDHbdWX15KT9O
 rkFk6CiaKUKxQ8YvZB9HrBnybMFy+Hu/7IKnB55GHjrbkiwDu8yKHexwsQS5LZGwaVUuFXqV
 xvXqMVaI7iAJOjsDEUVeFg+du2G2PwZxmvS4PAyLBmo7SN75uPaA0BbPh3Kgy1BNrpldogix
 L556sIR7gW+jDssM8qH0X8IpzjdcCRYXvV1rIweDa/qlhEvmwNLbpHrAyPr5I2CNodXOU4wL
 z7I3KfPitywHKYZn6bfwZQV4ddguA==
IronPort-HdrOrdr: A9a23:9ihxTq/v9VnXaLTg9khuk+DcI+orL9Y04lQ7vn2ZLiYlFfBw9v
 re+MjzsCWetN9/Yh0dcLy7V5VoIkm9yXcW2+cs1N6ZNWGN1VdAR7sC0aLShxHmBi3i5qp8+M
 5bAs1D4QTLfDtHZBDBkWuFL+o=
X-IronPort-AV: E=Sophos;i="5.85,365,1624334400"; 
   d="scan'208";a="54477913"
Date: Mon, 11 Oct 2021 18:07:18 +0100
From: Anthony PERARD <anthony.perard@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, George Dunlap
	<george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>, Julien Grall
	<julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>, Wei Liu
	<wl@xen.org>, <xen-devel@lists.xenproject.org>
Subject: Re: [XEN PATCH v7 20/51] build: avoid re-executing the main Makefile
 by introducing build.mk
Message-ID: <YWRvRlh5MlX1eMz+@perard>
References: <20210824105038.1257926-1-anthony.perard@citrix.com>
 <20210824105038.1257926-21-anthony.perard@citrix.com>
 <87036d63-b5d4-55bf-0bb3-9b981a147f15@suse.com>
 <YWRRFxlvmDMu8nRZ@perard>
 <b30bff47-226c-6f82-5f59-81d17b191ab4@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <b30bff47-226c-6f82-5f59-81d17b191ab4@suse.com>

On Mon, Oct 11, 2021 at 05:31:08PM +0200, Jan Beulich wrote:
> On 11.10.2021 16:58, Anthony PERARD wrote:
> > On Mon, Oct 11, 2021 at 12:56:54PM +0200, Jan Beulich wrote:
> >> On 24.08.2021 12:50, Anthony PERARD wrote:
> >>> With nearly everything needed to move to "build.mk" moved, there is a
> >>> single dependency left from "Rules.mk": $(TARGET), which is moved to
> >>> the main Makefile.
> >>
> >> I'm having trouble identifying what this describes. Searching for
> >> $(TARGET) in the patch doesn't yield any obvious match. Thinking
> >> about it, do you perhaps mean the setting of that variable? Is
> >> moving that guaranteed to not leave the variable undefined? Or in
> >> other words is there no scenario at all where xen/Makefile might
> >> get bypassed? (Aiui building an individual .o, .i, or .s would
> >> continue to be fine, but it feels like something along these lines
> >> might get broken.)
> > 
> > I mean that "xen/Rules.mk" will never "include" "xen/Makefile" after
> > this patch, but the variable "TARGET" is only set in "xen/Rules.mk". But
> > "xen/Makefile" still needs "TARGET" to be set so I moved the assignment
> > of the variable from "xen/Rules.mk" into "xen/Makefile".
> 
> Okay, thanks, this confirms the understanding I had developed; maybe
> you try to reword this some. What your reply doesn't address is my
> question, though.

Which question, there seems to be 3 of them :-). Is it about
xen/Makefile been bypassed?

Building anything in xen/ requires to first execute xen/Makefile as this
is where variables like CFLAGS or XEN_ROOT are defined, and this
includes single builds or building an individual .o.

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Mon Oct 11 17:13:26 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 17:13:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.206384.361939 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZyra-0005Cp-So; Mon, 11 Oct 2021 17:13:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 206384.361939; Mon, 11 Oct 2021 17:13:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZyra-0005Ci-Pr; Mon, 11 Oct 2021 17:13:22 +0000
Received: by outflank-mailman (input) for mailman id 206384;
 Mon, 11 Oct 2021 17:13:21 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=LfEM=O7=arm.com=Bertrand.Marquis@srs-us1.protection.inumbo.net>)
 id 1mZyrZ-0005Cc-76
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 17:13:21 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com (unknown
 [2a01:111:f400:7d00::629])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id a7c0e3ca-382a-4212-9509-260e9a9dd7e3;
 Mon, 11 Oct 2021 17:13:18 +0000 (UTC)
Received: from DB6PR0201CA0028.eurprd02.prod.outlook.com (2603:10a6:4:3f::38)
 by DB7PR08MB3227.eurprd08.prod.outlook.com (2603:10a6:5:1f::13) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.26; Mon, 11 Oct
 2021 17:13:15 +0000
Received: from DB5EUR03FT032.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:4:3f:cafe::f2) by DB6PR0201CA0028.outlook.office365.com
 (2603:10a6:4:3f::38) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18 via Frontend
 Transport; Mon, 11 Oct 2021 17:13:15 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT032.mail.protection.outlook.com (10.152.20.162) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4587.18 via Frontend Transport; Mon, 11 Oct 2021 17:13:15 +0000
Received: ("Tessian outbound d5def7722ff7:v103");
 Mon, 11 Oct 2021 17:13:15 +0000
Received: from dc32fd044ce2.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 EE801A2C-919B-4DB3-A775-D21EC95028E5.1; 
 Mon, 11 Oct 2021 17:11:34 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id dc32fd044ce2.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Mon, 11 Oct 2021 17:11:34 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com (2603:10a6:4:74::9)
 by DB7PR08MB3769.eurprd08.prod.outlook.com (2603:10a6:10:7b::26) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18; Mon, 11 Oct
 2021 17:11:31 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955]) by DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955%4]) with mapi id 15.20.4587.026; Mon, 11 Oct 2021
 17:11:31 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a7c0e3ca-382a-4212-9509-260e9a9dd7e3
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=3zgwV/V/LAzdrofH2bmODNKRUygFZoH0srIdTPBfcnk=;
 b=4apOnvKiJha6JT/YPl4PiAaqEvTUnIcsJAKS+TnnHedmcCkKPBYgqTWjvh43AV3f97XqmzYHPBwXs5fg//CfRL8dmgdbrYWVMUtWmWKZ48QHuP8NvROQrMJJ81oHK3B1GVvrkWi+UsMIIN7KxwkmYhIymShQ0YvZXOXRAVGARfQ=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: e5ef4273c5710aac
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=kmYUuxEwdUwXtJxP9kqUor9ROgU8d21Ptju2OK+03vR/6rgcAF6mafN96s32UcUpryePZ7Yf3TiaUB4FrAvqXQn2klPTKVcvE+ROSDejmgeyQqAkkBeaM5RCutWtxKLK82zFejq/oumf2cpnSfBS087DzTuspbOwy+q1JqLH8rDfpHC6LTzO3NLxMloAI8rfc7MFkkpwR6VmxadgDIc+FCB5CwPL2PWXDI1bb3DLpVL/7rjB7Y68JIwKGxa7zI1aYR6WvVqkqMfofVipQW/rqD5PqRw/sYsorZuBYR+LwZSzThnqf4dNMjqvWQyf+Up407NDUu/E2XOxPfw+G1iPKg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=3zgwV/V/LAzdrofH2bmODNKRUygFZoH0srIdTPBfcnk=;
 b=T+enonhqtT7uQpkZ3m8UncU/VfTph87KCvVnBvKPJbs/YfEN21x/6h9q9h8+JfpTWl8+JgyiCWrlnrjErjYJAufGJe0u6jywkqs6nYVvTqEdUDgMj8FW3wKmXxNDtdWoEx5lM/a/B/IQAznjyZGtNptfsXygXMY3f8D5NMyKT97BOI4jugfTfqJdAk2aCje4hUocD39aQgEenUrJTzZns4gF665OQuB0k4oX1nb22Y145cbwWKLEVlKdsEnh5fZqBXH3XQInf8Ax5HeGB7PHqR9l8lXQ5ZumwWoY36omHf2eRXLx5OE8RRl9wynbW4PwNza4y4qqV6Dd9Qfs3iafSg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=3zgwV/V/LAzdrofH2bmODNKRUygFZoH0srIdTPBfcnk=;
 b=4apOnvKiJha6JT/YPl4PiAaqEvTUnIcsJAKS+TnnHedmcCkKPBYgqTWjvh43AV3f97XqmzYHPBwXs5fg//CfRL8dmgdbrYWVMUtWmWKZ48QHuP8NvROQrMJJ81oHK3B1GVvrkWi+UsMIIN7KxwkmYhIymShQ0YvZXOXRAVGARfQ=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>
CC: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>, Rahul Singh
	<Rahul.Singh@arm.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, Andre Przywara <Andre.Przywara@arm.com>,
	Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>, Juergen Gross
	<jgross@suse.com>, Stefano Stabellini <sstabellini@kernel.org>
Subject: Re: [PATCH v5 01/11] xen/arm: xc_domain_ioport_permission(..) not
 supported on ARM.
Thread-Topic: [PATCH v5 01/11] xen/arm: xc_domain_ioport_permission(..) not
 supported on ARM.
Thread-Index:
 AQHXutl5d8zkP9bsD0GXT4+5QPGclKvNtfkAgAAGc4CAABOEAIAABXoAgAAEuYCAAAVHAIAAJiWAgAAK0IA=
Date: Mon, 11 Oct 2021 17:11:31 +0000
Message-ID: <EB1CB53B-9D5A-49C5-A687-841BF94A153F@arm.com>
References: <cover.1633540842.git.rahul.singh@arm.com>
 <d292392268df2c74c4103a82ef917072643407a8.1633540842.git.rahul.singh@arm.com>
 <YWQkblfNMYEs6jI9@MacBook-Air-de-Roger.local>
 <77CF7FA5-C566-469E-B4A8-0400789890BB@arm.com>
 <YWQ6Nk3Jk+BqgkwZ@MacBook-Air-de-Roger.local>
 <53AE6E2A-01D7-41EC-9B2C-C0D596EB8D4D@arm.com>
 <YWRCxXGQIyTOAepC@MacBook-Air-de-Roger.local>
 <FEF0B03A-5AC8-4F8D-B821-191AC2EF8295@arm.com>
 <YWRnMfAi808TQ4Gt@MacBook-Air-de-Roger.local>
In-Reply-To: <YWRnMfAi808TQ4Gt@MacBook-Air-de-Roger.local>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3654.120.0.1.13)
Authentication-Results-Original: citrix.com; dkim=none (message not signed)
 header.d=none;citrix.com; dmarc=none action=none header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: f217c926-9895-4050-1068-08d98cda69a9
x-ms-traffictypediagnostic: DB7PR08MB3769:|DB7PR08MB3227:
x-ms-exchange-transport-forked: True
X-Microsoft-Antispam-PRVS:
	<DB7PR08MB3227493B4A508A89EA64FB009DB59@DB7PR08MB3227.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:10000;OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 TVCPE2DRPQsJhTAHxihJcWmm/Zist3DTubGUkgpXRHbQ4N9ZPXWQ9iKGeJ3475uDd38nik+iYSjl1zSIquebMcoXI/2h6ui0h2sZns4zdLVBDIC6siqDcvc8/+lf0aayWLflibLa/Jr7Wz6xcAHlnpIRop7SFULAczVEMd9DE5Lx1Q5o4v6klNuWAdrOynEwno7gCx970ow61uGVPd/glk/PVlalwR1rUQKQG8NGa2a2JFDKW4pcE2Lt7jOLN5AfjP6YCPBMQGK8au78nahmUWSZChcQK/UE95CjEBahGwWcbhfxdFpaoRvS9eU4GbL/x883V0kh8Udduh2Li6fAeuuA/nNAR17ks3R/KN4jmunxUSLZlbMPJ6OdemokyDIR6fqXrBaqpxj1DXDMob26VwwhD0fC5Jjb09QYb4+hu791oVS/afD0uCzKKKluq/O5t397jgE8kL9sW2m9qravsRt88pH1TZyB7U0ZVN4bZvVbvk5FmIIXi8EmJasDpMbm0ibAHeHf1tGb12CyjgVTyQmmca0tbrsmVAYuObgUWxWK+Woov7wSKjSGsG+uKf6fM7MIFSia+udbJGrNgBZExAU0z899skpsaxvX2/G22c4S/b4Hke7QXHvXXfv3l9xuxDapv/8qdenTJnUpKPBRsdAbF90v6qpXiJhwNBg1nPm9hOGsSLeUlxDFE1cgYAX+sD0XTElmcsmKsugheWuy88Jzy53iv9AYKCNX11kNdBLNMrcpyYuzdcwnZlmB0WaZ
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB6PR0801MB2024.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(84040400005)(4326008)(8936002)(2906002)(38100700002)(6512007)(71200400001)(33656002)(53546011)(6916009)(316002)(6506007)(36756003)(54906003)(122000001)(86362001)(38070700005)(26005)(91956017)(508600001)(6486002)(2616005)(66556008)(5660300002)(8676002)(66446008)(83380400001)(66946007)(76116006)(64756008)(66476007)(186003)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-ID: <D7FE91F9E3B04B4BBD9B2BC62989200A@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3769
Original-Authentication-Results: citrix.com; dkim=none (message not signed)
 header.d=none;citrix.com; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT032.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	7de8ba3a-1cef-4b6e-256f-08d98cda2bee
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	o0VQOZTCUpfhkk2ZeXP999lIkwnXAYm8cL2houcCghhTSvch9PSpWlDgStaEOMmLE86FPfwp8QabtAbsgHOaDBNdEZlyPt7/ZNqljoQDlbB6KEcnZSeE3xlXgFkhpYLN7LLiKCWI+KIGHA3s5lSiSrAdSKKb4NWBhjLG+BjCChmTMq21tiO87QnYi3w5lWAcO12Dq0gm62GWsg9hF1wymJIK4ukHRDhQWx5nlyeT44yvWtOqqqyNClThPiPks7Kq/BSUDV2Mq/MxqR6kj6wUD9OL/pgNoiy5hR6uEvkI7pa4WV/BGGtwFJowTq8C2wEev0csgjv24LayVV5MsFaj6g6TsOwJ/WXjuITnXeGPCEEChW+OSWu6by7vTkSUdrSyZl6fcvZ3lTTttwfnoDc/stWMLpr+wlYkLpGa5yqwPV0qsGZh+FMs3OIhCYIibChlDhCPEYE/Qst65aPERk6hGxNzCWpmoGKasJdi/KNXJBx+iACVlULEOzjQrMwJapnEdKIv1Rfuol6OjVlBOX79Y3lesTspdFyTOkqHbRD7J1P4dK0fYLkefFUZ8KMmwHh8UxxaiU0t0Vx3P2GRzu0y2ZuNdV+ZDlwxUAku2RYdw8a7ZJzro3uYrIJAHsQgRENgUXa/QfVNrowt9P5ctZSSAUoEE/uD5r/c13l3YgRE2suaqzsAoWAaGw6WcAiKB9UJPe+sm8nJgpSpHtHSjZHYDg==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(84040400005)(36840700001)(46966006)(70206006)(5660300002)(107886003)(47076005)(53546011)(6506007)(186003)(26005)(2906002)(70586007)(54906003)(6512007)(83380400001)(81166007)(86362001)(2616005)(33656002)(356005)(8676002)(6862004)(4326008)(36756003)(336012)(316002)(6486002)(36860700001)(508600001)(8936002)(82310400003);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2021 17:13:15.3002
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: f217c926-9895-4050-1068-08d98cda69a9
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT032.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3227

SGkgUm9nZXIsDQoNCj4gT24gMTEgT2N0IDIwMjEsIGF0IDE3OjMyLCBSb2dlciBQYXUgTW9ubsOp
IDxyb2dlci5wYXVAY2l0cml4LmNvbT4gd3JvdGU6DQo+IA0KPiBPbiBNb24sIE9jdCAxMSwgMjAy
MSBhdCAwMjoxNjoxOVBNICswMDAwLCBCZXJ0cmFuZCBNYXJxdWlzIHdyb3RlOg0KPj4gSGkgUm9n
ZXIsDQo+PiANCj4+PiBPbiAxMSBPY3QgMjAyMSwgYXQgMTQ6NTcsIFJvZ2VyIFBhdSBNb25uw6kg
PHJvZ2VyLnBhdUBjaXRyaXguY29tPiB3cm90ZToNCj4+PiANCj4+PiBPbiBNb24sIE9jdCAxMSwg
MjAyMSBhdCAwMTo0MDozMFBNICswMDAwLCBCZXJ0cmFuZCBNYXJxdWlzIHdyb3RlOg0KPj4+PiBI
aSBSb2dlciwNCj4+Pj4gDQo+Pj4+ICsgT2xla3NhbmRyIHRvIGhhdmUgYSBiZXR0ZXIgUENJIGV4
cGVydCB0aGVuIG1lLg0KPj4+PiANCj4+Pj4+IE9uIDExIE9jdCAyMDIxLCBhdCAxNDoyMCwgUm9n
ZXIgUGF1IE1vbm7DqSA8cm9nZXIucGF1QGNpdHJpeC5jb20+IHdyb3RlOg0KPj4+Pj4gDQo+Pj4+
PiBPbiBNb24sIE9jdCAxMSwgMjAyMSBhdCAxMjoxMTowNFBNICswMDAwLCBCZXJ0cmFuZCBNYXJx
dWlzIHdyb3RlOg0KPj4+Pj4+IEhpIFJvZ2VyLA0KPj4+Pj4+IA0KPj4+Pj4+PiBPbiAxMSBPY3Qg
MjAyMSwgYXQgMTI6NDcsIFJvZ2VyIFBhdSBNb25uw6kgPHJvZ2VyLnBhdUBjaXRyaXguY29tPiB3
cm90ZToNCj4+Pj4+Pj4gDQo+Pj4+Pj4+IE9uIFdlZCwgT2N0IDA2LCAyMDIxIGF0IDA2OjQwOjI3
UE0gKzAxMDAsIFJhaHVsIFNpbmdoIHdyb3RlOg0KPj4+Pj4+Pj4gQVJNIGFyY2hpdGVjdHVyZSBk
b2VzIG5vdCBpbXBsZW1lbnQgSS9PIHBvcnRzLiBJZ25vcmUgdGhpcyBjYWxsIG9uIEFSTQ0KPj4+
Pj4+Pj4gdG8gYXZvaWQgdGhlIG92ZXJoZWFkIG9mIG1ha2luZyBhIGh5cGVyY2FsbCBqdXN0IGZv
ciBYZW4gdG8gcmV0dXJuDQo+Pj4+Pj4+PiAtRU5PU1lTLg0KPj4+Pj4+PiANCj4+Pj4+Pj4gV2hh
dCBpcyB0aGUgY2FsIHRyYWNlIG9mIHRoaXMgZnVuY3Rpb24gYWN0dWFsbHkgb24gQXJtPw0KPj4+
Pj4+PiANCj4+Pj4+Pj4gQUZBSUNUIGxpYnhsIHdpbGwgb25seSBjYWxsIHhjX2RvbWFpbl9pb3Bv
cnRfcGVybWlzc2lvbiBpZiB0aGVyZSBhcmUNCj4+Pj4+Pj4gSU8gcG9ydHMgZXhwbGljaXRseSBk
ZWZpbmVkIGluIHRoZSBndWVzdCBjb25maWd1cmF0aW9uLCBvciBpZiBhbnkgb2YNCj4+Pj4+Pj4g
dGhlIEJBUnMgb2YgdGhlIFBDSSBkZXZpY2UgaXMgaW4gdGhlIElPIHNwYWNlLCB3aGljaCBpcyBu
b3QgcG9zc2libGUNCj4+Pj4+Pj4gb24gQXJtLg0KPj4+Pj4+IA0KPj4+Pj4+IFBDSSBkZXZpY2Vz
IEJBUnMgY2FuIGJlIGluIHRoZSBJTyBzcGFjZSBhcyB0aGUgUENJIGRldmljZXMgYXJlIG5vdA0K
Pj4+Pj4+IEFybSBzcGVjaWZpYy4gVGhlcmUgaXMgbm90IGlvcG9ydHMgb24gYXJtIHNvIHRvIGJl
IHVzZWQgdGhvc2UgY2FuIGJlDQo+Pj4+Pj4gaW4gc29tZSBjYXNlcyByZW1hcHBlZCBhbmQgYWNj
ZXNzZWQgYXMgTU1JT3Mgb3IgYXJlIG5vdCBwb3NzaWJsZQ0KPj4+Pj4+IHRvIHVzZSBhdCBhbGwu
DQo+Pj4+Pj4gDQo+Pj4+Pj4gQnV0IHRoZSBJTyBzcGFjZSBkb2VzIGFwcGVhciB3aGVuIEJBUnMg
YXJlIGxpc3RlZCBldmVuIG9uIEFybS4NCj4+Pj4+IA0KPj4+Pj4gVXJnLCBJIHdvbmRlciB3aGV0
aGVyIHRob3NlIGRldmljZXMgd2l0aCBJTyBCQVJzIHdpbGwgd29yayBjb3JyZWN0bHkNCj4+Pj4+
IHVuZGVyIEFybSB0aGVuLg0KPj4+Pj4gDQo+Pj4+PiBIb3cgZG8geW91IGtub3cgd2hldGhlciB0
aGUgQkFSIGhhcyBiZWVuIHJlbWFwcGVkIGZyb20gSU8gc3BhY2UgaW50bw0KPj4+Pj4gTU1JTz8N
Cj4+Pj4gDQo+Pj4+IFdlIGNhbm5vdCwgSSB0aGluayB0aGUgcGxhdGZvcm0gd2lsbCBkZWZpbmUg
aWYgdGhpcyBpcyB0aGUgY2FzZSBhbmQgd2hlcmUuDQo+Pj4+IEBvbGVrc2FuZHI6IEkgcmVtZW1i
ZXIgdGhhdCB0aGlzIHdhcyBkaXNjdXNzZWQgZHVyaW5nIHNvbWUgb2Ygb3VyDQo+Pj4+IG1lZXRp
bmdzIGJ1dCBJIGhhdmUgbm8gaWRlYSBvZiB0aGUgZGV0YWlscyBoZXJlLCBjYW4geW91IGhlbHAg
Pw0KPj4+PiANCj4+Pj4+IA0KPj4+Pj4gSU1PIGluc3RlYWQgb2YgZmFraW5nIGEgc3VjY2Vzc2Z1
bCByZXR1cm4gdmFsdWUgZnJvbQ0KPj4+Pj4geGNfZG9tYWluX2lvcG9ydF9wZXJtaXNzaW9uIHdl
IHNob3VsZCBhdm9pZCB0aGUgY2FsbCBjb21wbGV0ZWx5IGluIHRoZQ0KPj4+Pj4gZmlyc3QgcGxh
Y2UsIHNwZWNpYWxseSBpZiB3ZSBuZWVkIHRvIGluc3RlYWQgaXNzdWUgYSBjYWxsIHRvDQo+Pj4+
PiB4Y19kb21haW5faW9tZW1fcGVybWlzc2lvbi4NCj4+Pj4gDQo+Pj4+IEF0IHRoZSBlbmQgd2Ug
d2lsbCBuZXZlciBoYXZlIHRvIGlzc3VlIHRoaXMgYmVjYXVzZSB0aGlzIHdpbGwgbmV2ZXIgYmUg
YSBtYXR0ZXINCj4+Pj4gb2Yg4oCcaW9tZW3igJ0gcGVybWlzc2lvbiBhcyB0aGVyZSB3b3VsZCBu
b3QgYmUgYW55IHdheSB0byBjdXQgb24gc29tZXRoaW5nIHVuZGVyDQo+Pj4+IHRoZSBwYWdlLiBJ
ZiB0aGlzIGlzIHRvIGJlIHN1cHBvcnRlZCBvbmUgZGF5LCBpdCB3aWxsIHByb2JhYmx5IGhhdmUg
dG8gYmUgZnVsbHkgZW11bGF0ZWQNCj4+Pj4gdG8ga2VlcCB0aGUgaXNvbGF0aW9uLg0KPj4+IA0K
Pj4+IFNvIHlvdSBoYXZlIGEgc2V0IG9mIG1lbW9yeSBwYWdlcyB0aGF0IG1hcCBhY2Nlc3NlcyBm
cm9tDQo+Pj4gTU1JTyBpbnRvIElPIHNwYWNlIGJ1dCBpdCdzIG5vdCBwb3NzaWJsZSB0byBpc29s
YXRlIHNwZWNpZmljIElPIHBvcnQNCj4+PiByZWdpb25zIGFzIHRoZXkgYXJlIGFsbCBjb250aWd1
b3VzIGluIHRoZSBzYW1lIHBhZ2UocykuDQo+PiANCj4+IEV4YWN0Lg0KPj4gDQo+Pj4gDQo+Pj4+
IFJpZ2h0IG5vdyBvbiBhcm0geW91IGNhbiBqdXN0IG1ha2UgdGhlIG1vcmUgc2ltcGxlIGFzc3Vt
cHRpb24gdGhhdCBpb3BvcnRzIGFyZQ0KPj4+PiBqdXN0IG5vdCBzdXBwb3J0ZWQuDQo+Pj4gDQo+
Pj4gV291bGQgaXQgbWFrZSBzZW5zZSBpbiB0aGUgZnV0dXJlIHRvIHByb3ZpZGUgYSBtZW1vcnkg
cmVnaW9uIHRvIGd1ZXN0cw0KPj4+IGluIG9yZGVyIHRvIHVzZSBmb3IgSU8gcG9ydCBhY2Nlc3Nl
cywgYW5kIGNhbGwNCj4+PiB4Y19kb21haW5faW9wb3J0X3Blcm1pc3Npb24gdG8gc2V0IHdoaWNo
IHBvcnRzIHdvdWxkIGJlIGFsbG93ZWQ/DQo+PiANCj4+IFJpZ2h0IG5vdyB3ZSBkbyBub3QgcGxh
biB0byBzdXBwb3J0IHRoaXMgYXQgYWxsIGFuZCB3ZSB3aWxsIGhhdmUgdG8NCj4+IGZpZ3VyZSB0
aGlzIG91dCBpZiB3ZSBkbyB0aGlzIG9uZSBkYXkuDQo+PiANCj4+PiANCj4+PiBJIHRoaW5rIHRo
ZSBjb21taXQgbWVzc2FnZSBuZWVkcyB0byBhdCBsZWFzdCBiZSBleHBhbmRlZCBpbiBvcmRlciB0
bw0KPj4+IGNvbnRhaW4gdGhlIGluZm9ybWF0aW9uIHByb3ZpZGVkIGhlcmUuIEl0IG1pZ2h0IGFs
c28gYmUgaGVscGZ1bCB0bw0KPj4+IGZpZ3VyZSBvdXQgd2hldGhlciB3ZSB3b3VsZCBoYXZlIHRv
IGhhbmRsZSBJTyBwb3J0IGFjY2Vzc2VzIGluIHRoZQ0KPj4+IGZ1dHVyZSBvbiBBcm0sIG9yIGlm
IGl0J3MgZmluZSB0byBqdXN0IGlnbm9yZSB0aGVtLg0KPj4gDQo+PiBBbGwgb3VyIGludmVzdGln
YXRpb25zIGFuZCB0ZXN0cyBoYXZlIGJlZW4gZG9uZSB3aXRob3V0IHN1cHBvcnRpbmcgaXQNCj4+
IHdpdGhvdXQgYW55IGlzc3VlcyBzbyB0aGlzIGlzIG5vdCBhIGNyaXRpY2FsIGZlYXR1cmUgKG1v
c3QgZGV2aWNlcyBjYW4NCj4+IGJlIG9wZXJhdGVkIHdpdGhvdXQgdXNpbmcgdGhlIEkvTyBwb3J0
cykuDQo+IA0KPiBJTU8gd2Ugc2hvdWxkIGxldCB0aGUgdXNlcnMga25vdyB0aGV5IGF0dGVtcHRl
ZCB0byB1c2UgYSBkZXZpY2Ugd2l0aA0KPiBCQVJzIGluIHRoZSBJTyBzcGFjZSwgYW5kIHRoYXQg
dGhvc2UgQkFScyB3b24ndCBiZSBhY2Nlc3NpYmxlIHdoaWNoDQo+IGNvdWxkIG1ha2UgdGhlIGRl
dmljZSBub3QgZnVuY3Rpb24gYXMgZXhwZWN0ZWQuDQo+IA0KPiBEbyB5b3UgdGhpbmsgaXQgd291
bGQgYmUgcmVhc29uYWJsZSB0byBhdHRlbXB0IHRoZSBoeXBlcmNhbGwgb24gQXJtDQo+IGFsc28s
IGFuZCBpbiBjYXNlIG9mIGVycm9yIChvbiBBcm0pIGp1c3QgcHJpbnQgYSB3YXJuaW5nIG1lc3Nh
Z2UgYW5kDQo+IGNvbnRpbnVlIG9wZXJhdGlvbnMgYXMgbm9ybWFsPw0KDQpJIHRoaW5rIHRoaXMg
d291bGQgbGVhZCB0byBhIHdhcm5pbmcgcHJpbnRlZCBvbiBsb3RzIG9mIGRldmljZXMgd2hlcmUg
aW4NCmZhY3QgdGhlcmUgd291bGQgYmUgbm8gaXNzdWVzLg0KDQpJZiB0aGlzIGlzIGFuIGlzc3Vl
IGZvciBhIGRldmljZSBkcml2ZXIgYmVjYXVzZSBpdCBjYW5ub3Qgb3BlcmF0ZSB3aXRob3V0DQpJ
L08gcG9ydHMsIHRoaXMgd2lsbCBiZSByYWlzZWQgYnkgdGhlIGRyaXZlciBpbnNpZGUgdGhlIGd1
ZXN0Lg0KDQpTbyBpbiB0aGUgY3VycmVudCBzdGF0ZSBJIHRoaW5rIHRoZSB3YXkgdG8gZG8gaXQg
aXMgcmlnaHQuDQoNClJlZ2FyZHMNCkJlcnRyYW5kDQoNCj4gDQo+IFRoYW5rcywgUm9nZXIuDQoN
Cg==


From xen-devel-bounces@lists.xenproject.org Mon Oct 11 17:16:20 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 17:16:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.206390.361951 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZyuR-0005qX-Cj; Mon, 11 Oct 2021 17:16:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 206390.361951; Mon, 11 Oct 2021 17:16:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZyuR-0005qQ-8n; Mon, 11 Oct 2021 17:16:19 +0000
Received: by outflank-mailman (input) for mailman id 206390;
 Mon, 11 Oct 2021 17:16:18 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=LfEM=O7=arm.com=Bertrand.Marquis@srs-us1.protection.inumbo.net>)
 id 1mZyuQ-0005qJ-2O
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 17:16:18 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com (unknown
 [40.107.20.78]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 464a91e4-de34-41e7-942e-03e53dbfcbe1;
 Mon, 11 Oct 2021 17:16:16 +0000 (UTC)
Received: from AS9PR06CA0278.eurprd06.prod.outlook.com (2603:10a6:20b:45a::18)
 by PA4PR08MB6224.eurprd08.prod.outlook.com (2603:10a6:102:e7::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.19; Mon, 11 Oct
 2021 17:16:04 +0000
Received: from AM5EUR03FT039.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:45a:cafe::2d) by AS9PR06CA0278.outlook.office365.com
 (2603:10a6:20b:45a::18) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.25 via Frontend
 Transport; Mon, 11 Oct 2021 17:16:04 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM5EUR03FT039.mail.protection.outlook.com (10.152.17.185) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4587.18 via Frontend Transport; Mon, 11 Oct 2021 17:16:03 +0000
Received: ("Tessian outbound d5def7722ff7:v103");
 Mon, 11 Oct 2021 17:16:03 +0000
Received: from 9a9064d71580.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 A4DBB567-8EC3-4ABF-883D-5BC41B1BB1B7.1; 
 Mon, 11 Oct 2021 17:15:56 +0000
Received: from EUR03-DB5-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 9a9064d71580.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Mon, 11 Oct 2021 17:15:56 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com (2603:10a6:4:74::9)
 by DB8PR08MB5162.eurprd08.prod.outlook.com (2603:10a6:10:ee::14) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.22; Mon, 11 Oct
 2021 17:15:55 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955]) by DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955%4]) with mapi id 15.20.4587.026; Mon, 11 Oct 2021
 17:15:55 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 464a91e4-de34-41e7-942e-03e53dbfcbe1
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=mM3MTGZH6O0S1A/We/x/P7r+HM/9ijRYcpIeZ3LYKCc=;
 b=nvSHF8dfFNkBGi1yQwJ1DEthvVLR/EhgZyiEFRPeqIK1gTs1IxJx2aYYxMZJNItz6VsWBjlPcZiU9gNradJi04jPYX5fhh1z3G8mXHriuMfK8emRgmX/cb0sGfue9n8urJtLm3AK9NQ2S9oGcXZzDZfRn3EXeDPCWC1CPC7nimM=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 7cd45d50211fa4e0
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=c6EfxPcw0gNC7JwPRNnWV/G6qQ4jNIiggVEOqOzN/k+n4sKel9OcRXDQSt5Rg4RjutK0GC+8djH0/vBmYaIKmsDkm4L/gmTwhq+HKBJbinGn0FFU/y/sR3gYwPp2Ak4wXzSXScsniOyW3SBjT9PhlMSwTdMX2XxaPdYJnD/Tu5JtkNhW2GP4wV+4Eca8+UpZH/6q547ZJOiogDtEVK6aHvNXXHgjN/do6MJ0uuNvS3OSQa3dIdpCH7IarVTmbVMuEvp1h4Z0cbh2WLI7HXsRhfikvN94kX7YLNOc41fq66U99P+QQmURiR5p5TW/ul0jfz0WR4jgW0ZkVhg1JXnbCw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=mM3MTGZH6O0S1A/We/x/P7r+HM/9ijRYcpIeZ3LYKCc=;
 b=ipVOGubJLnQG954UEKXEldqLm+Ya2znTFplEZDqSHBDlXY6ut6zHjrUgL2nCosoIfcKuAvUVi27NNMf1cvUpfEECcAgP2WuACCl0PHYjS3eEXuEQIx5kCgNFyfsJbayoC/HKRVN7fYWKJWbxjAhwctVuNcfJ+kD3+MQcpfP2Q7cclF0DwjtX8UQ/R+IL508ri7DLR0Fw0Xt7nBbsw8Jm2I1PTKiVwLGWawbAlneDnEkXb/Gdn0j4goJzeb8OopVn+ePG0JZqBv4ew3U4xXn9ShZCTyB9V4xcAkRS5IYmTX2M/6tjK9Zmo1R5a/Y0eV4gyWNDPHK03h+EPdz2eM+HnQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=mM3MTGZH6O0S1A/We/x/P7r+HM/9ijRYcpIeZ3LYKCc=;
 b=nvSHF8dfFNkBGi1yQwJ1DEthvVLR/EhgZyiEFRPeqIK1gTs1IxJx2aYYxMZJNItz6VsWBjlPcZiU9gNradJi04jPYX5fhh1z3G8mXHriuMfK8emRgmX/cb0sGfue9n8urJtLm3AK9NQ2S9oGcXZzDZfRn3EXeDPCWC1CPC7nimM=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>
CC: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>, Rahul Singh
	<Rahul.Singh@arm.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, Andre Przywara <Andre.Przywara@arm.com>,
	Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, Andrew Cooper
	<andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>, Ian
 Jackson <iwj@xenproject.org>, Jan Beulich <jbeulich@suse.com>, Wei Liu
	<wl@xen.org>, Paul Durrant <paul@xen.org>
Subject: Re: [PATCH v5 08/11] xen/arm: Enable the existing x86 virtual PCI
 support for ARM.
Thread-Topic: [PATCH v5 08/11] xen/arm: Enable the existing x86 virtual PCI
 support for ARM.
Thread-Index: AQHXutl3YqS5dHXsYk6KpdKt4d14RavNphKAgABZ5QCAAAISgIAABoqAgAAJBQA=
Date: Mon, 11 Oct 2021 17:15:55 +0000
Message-ID: <AF7AB609-3E79-4017-A296-CC7C87E1705F@arm.com>
References: <cover.1633540842.git.rahul.singh@arm.com>
 <9bdca2cda5d2e83f94dc2423e55714273539760a.1633540842.git.rahul.singh@arm.com>
 <YWQXF2vDaWQvi+bT@MacBook-Air-de-Roger.local>
 <4F406854-4F90-48F6-8470-6CCB60A3CB77@arm.com>
 <e199bfe2-0bcc-989f-fd4a-ecf44a3cd1ac@epam.com>
 <YWRpuUtHkyA4RY5H@MacBook-Air-de-Roger.local>
In-Reply-To: <YWRpuUtHkyA4RY5H@MacBook-Air-de-Roger.local>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3654.120.0.1.13)
Authentication-Results-Original: citrix.com; dkim=none (message not signed)
 header.d=none;citrix.com; dmarc=none action=none header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: 4a1d469c-e3cd-466b-c168-08d98cdace0a
x-ms-traffictypediagnostic: DB8PR08MB5162:|PA4PR08MB6224:
x-ms-exchange-transport-forked: True
X-Microsoft-Antispam-PRVS:
	<PA4PR08MB6224DC5E9D1BC2B9ADBB675C9DB59@PA4PR08MB6224.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:10000;OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 jnV4/Ld9N6T7M/7vvegwVMmaAvBIIhLEv6Hhwk0gX5KJbJQPEmywvSyNT++A1Zav6XtXER/rZeBea5mpqRMT12dxf/KCeMAvFKy58qTfq3asKmICR85qsEHJWos0JOB0PRBbBpCzO5cmJguFuELVFk6y3Kj4OJgy3jHqIed+64VibGiiEaF76k6YJjwFjITXzSnzSfeTDrZ3uBXeB903yNAlcq+n+vStRUhcf6wnHF1tta/bv+uBz8JG7Np9fij5w7+F5kDGIxgZQl0wD1jfLfthanU+1hhfVX+d4uLkuoqSorGTX0j+6BVygWWh4+P2SgdEQXPcH8DAbhoHuBlu/XDVZii7bDYPjDc1SAzSG+CHXQjfupxl81Ag3ew++CHnYbmfbtiHkUR0YTTcpRfPFjpGiIQ3CqQbjlP9i9ITWPaKOaP1PIvN9PI4aFawI3q8npBOtlHC9SFWbhp380jrYm2Svc3uJf8r1R5un1FFr/ugCxaYzbG/rOoBxb0sHWT5Soypmyi0T1UCUUN8SuNRDMH1/1zgw9Q6mo8MOqJhStLPtmaET4igBKOZrZmQrPiky9hLjp0f2xV0U6IG2znCGTym6sYE8rB5PTVCevw03yldJ4zyLD0Vh+hUYnX+sJwSpsx8dMLB0GzSTwxkrp/ZxG1uPFbdC2n4CqIcqpjGMpRo5U5XZNeehUkeg265J6TTrQbm1DDaBw+U4rMGb7F/UEhy/FeqHH3/UoSUDMpXWD4Z0qoyXBoJpHmclZ+EN3ID
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB6PR0801MB2024.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(186003)(91956017)(8676002)(6486002)(26005)(71200400001)(4326008)(2906002)(54906003)(6916009)(76116006)(36756003)(122000001)(66476007)(66946007)(508600001)(66446008)(38100700002)(66556008)(64756008)(38070700005)(33656002)(83380400001)(7416002)(5660300002)(2616005)(86362001)(53546011)(6506007)(316002)(8936002)(6512007)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-ID: <E939567DDAAC91449A07C26A37CF5256@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB5162
Original-Authentication-Results: citrix.com; dkim=none (message not signed)
 header.d=none;citrix.com; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM5EUR03FT039.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	4a2e87bc-e711-4b92-4c6f-08d98cdac906
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	RAn3YZbOTB+Nr/+OceW+avuT8cfWVzQ2nm8trHcqQ1lGcb1XaJGG9U8qRXQUYX5vv9WX5JsVsNQp3pyLOIhOUm5jNFRQYOY6tbpAxgMkSaXYO7BlqK3KauN6J9F1jbprqCUoq1erRHRzzGTTzxmQ8zwUNmkH7J4nhYLdWUl+Aj1MdSD0pLV02GKHi8Z7whzpQSwfzad75GqRd0sGXXrXN58aEGEOnU4e0AmV6yZL+DeS1l7wWS8Qh3dvXAAWDiOMlSqSzw7/eZorPbIIGkDycc8Zjk4Lx3MHdFglASJccOnxT4XOH6E47p0aHjvlHLwalwpSsjmSHx756hm0fNp1b/DbIW4a7OGixFojpyxzWgqo5XUW16T4jlipJYnwaU6dgcAiu85aaFulg3urnY3M6iPULaOn4RWXSdSVruHfCSd7IvwNUlo8oeDOIvE8zOE14L65yklGoTH0akN+h+s8FKYSAJU7An71HVHX8qno+am4pR7hqmE/iJ1KZ5S1ybtCjbO0b+C3qK+W4J5LJVouY6mxVBXyXKr1TF74fiJ38pVj3dnEdMzGsLzIgR4/l67EEO2sPnvIDLq2WUIgr3hNs4I3WC0CrbsAiswWYj45HhJhiccVNeUiBovuBlRlwRMD/XdP1sgXdlYJujpmwE3+UBeMc535S17aMG7pewurs21woXgY443uYlxVfSqfkf+FKA8cAj7KOGEAgiFq4VDEeA==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(70206006)(8676002)(6512007)(356005)(70586007)(2906002)(86362001)(33656002)(36860700001)(4326008)(81166007)(53546011)(36756003)(186003)(82310400003)(6486002)(6506007)(5660300002)(8936002)(336012)(508600001)(2616005)(26005)(6862004)(83380400001)(47076005)(316002)(54906003);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2021 17:16:03.6522
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 4a1d469c-e3cd-466b-c168-08d98cdace0a
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM5EUR03FT039.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB6224

SGkgUm9nZXIsDQoNCj4gT24gMTEgT2N0IDIwMjEsIGF0IDE3OjQzLCBSb2dlciBQYXUgTW9ubsOp
IDxyb2dlci5wYXVAY2l0cml4LmNvbT4gd3JvdGU6DQo+IA0KPiBPbiBNb24sIE9jdCAxMSwgMjAy
MSBhdCAwNDoyMDoxNFBNICswMDAwLCBPbGVrc2FuZHIgQW5kcnVzaGNoZW5rbyB3cm90ZToNCj4+
IA0KPj4gDQo+PiBPbiAxMS4xMC4yMSAxOToxMiwgQmVydHJhbmQgTWFycXVpcyB3cm90ZToNCj4+
PiBIaSBSb2dlciwNCj4+PiANCj4+Pj4gT24gMTEgT2N0IDIwMjEsIGF0IDExOjUxLCBSb2dlciBQ
YXUgTW9ubsOpIDxyb2dlci5wYXVAY2l0cml4LmNvbT4gd3JvdGU6DQo+Pj4+IA0KPj4+PiBPbiBX
ZWQsIE9jdCAwNiwgMjAyMSBhdCAwNjo0MDozNFBNICswMTAwLCBSYWh1bCBTaW5naCB3cm90ZToN
Cj4+Pj4+IFRoZSBleGlzdGluZyBWUENJIHN1cHBvcnQgYXZhaWxhYmxlIGZvciBYODYgaXMgYWRh
cHRlZCBmb3IgQXJtLg0KPj4+Pj4gV2hlbiB0aGUgZGV2aWNlIGlzIGFkZGVkIHRvIFhFTiB2aWEg
dGhlIGh5cGVyIGNhbGwNCj4+Pj4+IOKAnFBIWVNERVZPUF9wY2lfZGV2aWNlX2FkZOKAnSwgVlBD
SSBoYW5kbGVyIGZvciB0aGUgY29uZmlnIHNwYWNlDQo+Pj4+PiBhY2Nlc3MgaXMgYWRkZWQgdG8g
dGhlIFhlbiB0byBlbXVsYXRlIHRoZSBQQ0kgZGV2aWNlcyBjb25maWcgc3BhY2UuDQo+Pj4+PiAN
Cj4+Pj4+IEEgTU1JTyB0cmFwIGhhbmRsZXIgZm9yIHRoZSBQQ0kgRUNBTSBzcGFjZSBpcyByZWdp
c3RlcmVkIGluIFhFTg0KPj4+Pj4gc28gdGhhdCB3aGVuIGd1ZXN0IGlzIHRyeWluZyB0byBhY2Nl
c3MgdGhlIFBDSSBjb25maWcgc3BhY2UsWEVODQo+Pj4+PiB3aWxsIHRyYXAgdGhlIGFjY2VzcyBh
bmQgZW11bGF0ZSByZWFkL3dyaXRlIHVzaW5nIHRoZSBWUENJIGFuZA0KPj4+Pj4gbm90IHRoZSBy
ZWFsIFBDSSBoYXJkd2FyZS4NCj4+Pj4+IA0KPj4+Pj4gRm9yIERvbTBsZXNzIHN5c3RlbXMgc2Nh
bl9wY2lfZGV2aWNlcygpIHdvdWxkIGJlIHVzZWQgdG8gZGlzY292ZXIgdGhlDQo+Pj4+PiBQQ0kg
ZGV2aWNlIGluIFhFTiBhbmQgVlBDSSBoYW5kbGVyIHdpbGwgYmUgYWRkZWQgZHVyaW5nIFhFTiBi
b290cy4NCj4+Pj4+IA0KPj4+Pj4gU2lnbmVkLW9mZi1ieTogUmFodWwgU2luZ2ggPHJhaHVsLnNp
bmdoQGFybS5jb20+DQo+Pj4+PiBSZXZpZXdlZC1ieTogU3RlZmFubyBTdGFiZWxsaW5pIDxzc3Rh
YmVsbGluaUBrZXJuZWwub3JnPg0KPj4+Pj4gLS0tDQo+Pj4+PiBDaGFuZ2UgaW4gdjU6DQo+Pj4+
PiAtIEFkZCBwY2lfY2xlYW51cF9tc2kocGRldikgaW4gY2xlYW51cCBwYXJ0Lg0KPj4+Pj4gLSBB
ZGRlZCBSZXZpZXdlZC1ieTogU3RlZmFubyBTdGFiZWxsaW5pIDxzc3RhYmVsbGluaUBrZXJuZWwu
b3JnPg0KPj4+Pj4gQ2hhbmdlIGluIHY0Og0KPj4+Pj4gLSBNb3ZlIGFkZGl0aW9uIG9mIFhFTl9E
T01DVExfQ0RGX3ZwY2kgZmxhZyB0byBzZXBhcmF0ZSBwYXRjaA0KPj4+Pj4gQ2hhbmdlIGluIHYz
Og0KPj4+Pj4gLSBVc2UgaXNfcGNpX3Bhc3N0aHJvdWdoX2VuYWJsZWQoKSBpbiBwbGFjZSBvZiBw
Y2lfcGFzc3Rocm91Z2hfZW5hYmxlZCB2YXJpYWJsZQ0KPj4+Pj4gLSBSZWplY3QgWEVOX0RPTUNU
TF9DREZfdnBjaSBmb3IgeDg2IGluIGFyY2hfc2FuaXRpc2VfZG9tYWluX2NvbmZpZygpDQo+Pj4+
PiAtIFJlbW92ZSBJU19FTkFCTEVEKENPTkZJR19IQVNfVlBDSSkgZnJvbSBoYXNfdnBjaSgpDQo+
Pj4+PiBDaGFuZ2UgaW4gdjI6DQo+Pj4+PiAtIEFkZCBuZXcgWEVOX0RPTUNUTF9DREZfdnBjaSBm
bGFnDQo+Pj4+PiAtIG1vZGlmeSBoYXNfdnBjaSgpIHRvIGluY2x1ZGUgWEVOX0RPTUNUTF9DREZf
dnBjaQ0KPj4+Pj4gLSBlbmFibGUgdnBjaSBzdXBwb3J0IHdoZW4gcGNpLXBhc3N0aG91Z2ggb3B0
aW9uIGlzIGVuYWJsZWQuDQo+Pj4+PiAtLS0NCj4+Pj4+IC0tLQ0KPj4+Pj4geGVuL2FyY2gvYXJt
L01ha2VmaWxlICAgICAgICAgfCAgIDEgKw0KPj4+Pj4geGVuL2FyY2gvYXJtL2RvbWFpbi5jICAg
ICAgICAgfCAgIDQgKysNCj4+Pj4+IHhlbi9hcmNoL2FybS9kb21haW5fYnVpbGQuYyAgIHwgICAz
ICsNCj4+Pj4+IHhlbi9hcmNoL2FybS92cGNpLmMgICAgICAgICAgIHwgMTAyICsrKysrKysrKysr
KysrKysrKysrKysrKysrKysrKysrKysNCj4+Pj4+IHhlbi9hcmNoL2FybS92cGNpLmggICAgICAg
ICAgIHwgIDM2ICsrKysrKysrKysrKw0KPj4+Pj4geGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvcGNp
LmMgfCAgMTggKysrKysrDQo+Pj4+PiB4ZW4vaW5jbHVkZS9hc20tYXJtL2RvbWFpbi5oICB8ICAg
NyArKy0NCj4+Pj4+IHhlbi9pbmNsdWRlL2FzbS14ODYvcGNpLmggICAgIHwgICAyIC0NCj4+Pj4+
IHhlbi9pbmNsdWRlL3B1YmxpYy9hcmNoLWFybS5oIHwgICA3ICsrKw0KPj4+Pj4geGVuL2luY2x1
ZGUveGVuL3BjaS5oICAgICAgICAgfCAgIDIgKw0KPj4+Pj4gMTAgZmlsZXMgY2hhbmdlZCwgMTc5
IGluc2VydGlvbnMoKyksIDMgZGVsZXRpb25zKC0pDQo+Pj4+PiBjcmVhdGUgbW9kZSAxMDA2NDQg
eGVuL2FyY2gvYXJtL3ZwY2kuYw0KPj4+Pj4gY3JlYXRlIG1vZGUgMTAwNjQ0IHhlbi9hcmNoL2Fy
bS92cGNpLmgNCj4+Pj4+IA0KPj4+Pj4gZGlmZiAtLWdpdCBhL3hlbi9hcmNoL2FybS9NYWtlZmls
ZSBiL3hlbi9hcmNoL2FybS9NYWtlZmlsZQ0KPj4+Pj4gaW5kZXggNDRkN2NjODFmYS4uZmI5Yzk3
NmVhMiAxMDA2NDQNCj4+Pj4+IC0tLSBhL3hlbi9hcmNoL2FybS9NYWtlZmlsZQ0KPj4+Pj4gKysr
IGIveGVuL2FyY2gvYXJtL01ha2VmaWxlDQo+Pj4+PiBAQCAtNyw2ICs3LDcgQEAgaWZuZXEgKCQo
Q09ORklHX05PX1BMQVQpLHkpDQo+Pj4+PiBvYmoteSArPSBwbGF0Zm9ybXMvDQo+Pj4+PiBlbmRp
Zg0KPj4+Pj4gb2JqLSQoQ09ORklHX1RFRSkgKz0gdGVlLw0KPj4+Pj4gK29iai0kKENPTkZJR19I
QVNfVlBDSSkgKz0gdnBjaS5vDQo+Pj4+PiANCj4+Pj4+IG9iai0kKENPTkZJR19IQVNfQUxURVJO
QVRJVkUpICs9IGFsdGVybmF0aXZlLm8NCj4+Pj4+IG9iai15ICs9IGJvb3RmZHQuaW5pdC5vDQo+
Pj4+PiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gvYXJtL2RvbWFpbi5jIGIveGVuL2FyY2gvYXJtL2Rv
bWFpbi5jDQo+Pj4+PiBpbmRleCAzNjEzOGMxYjJlLi5mYmI1MmY3OGYxIDEwMDY0NA0KPj4+Pj4g
LS0tIGEveGVuL2FyY2gvYXJtL2RvbWFpbi5jDQo+Pj4+PiArKysgYi94ZW4vYXJjaC9hcm0vZG9t
YWluLmMNCj4+Pj4+IEBAIC0zOSw2ICszOSw3IEBADQo+Pj4+PiAjaW5jbHVkZSA8YXNtL3ZnaWMu
aD4NCj4+Pj4+ICNpbmNsdWRlIDxhc20vdnRpbWVyLmg+DQo+Pj4+PiANCj4+Pj4+ICsjaW5jbHVk
ZSAidnBjaS5oIg0KPj4+Pj4gI2luY2x1ZGUgInZ1YXJ0LmgiDQo+Pj4+PiANCj4+Pj4+IERFRklO
RV9QRVJfQ1BVKHN0cnVjdCB2Y3B1ICosIGN1cnJfdmNwdSk7DQo+Pj4+PiBAQCAtNzY3LDYgKzc2
OCw5IEBAIGludCBhcmNoX2RvbWFpbl9jcmVhdGUoc3RydWN0IGRvbWFpbiAqZCwNCj4+Pj4+ICAg
ICBpZiAoIGlzX2hhcmR3YXJlX2RvbWFpbihkKSAmJiAocmMgPSBkb21haW5fdnVhcnRfaW5pdChk
KSkgKQ0KPj4+Pj4gICAgICAgICBnb3RvIGZhaWw7DQo+Pj4+PiANCj4+Pj4+ICsgICAgaWYgKCAo
cmMgPSBkb21haW5fdnBjaV9pbml0KGQpKSAhPSAwICkNCj4+Pj4+ICsgICAgICAgIGdvdG8gZmFp
bDsNCj4+Pj4+ICsNCj4+Pj4+ICAgICByZXR1cm4gMDsNCj4+Pj4+IA0KPj4+Pj4gZmFpbDoNCj4+
Pj4+IGRpZmYgLS1naXQgYS94ZW4vYXJjaC9hcm0vZG9tYWluX2J1aWxkLmMgYi94ZW4vYXJjaC9h
cm0vZG9tYWluX2J1aWxkLmMNCj4+Pj4+IGluZGV4IGM1YWZiZTJlMDUuLmY0Yzg5YmRlOGMgMTAw
NjQ0DQo+Pj4+PiAtLS0gYS94ZW4vYXJjaC9hcm0vZG9tYWluX2J1aWxkLmMNCj4+Pj4+ICsrKyBi
L3hlbi9hcmNoL2FybS9kb21haW5fYnVpbGQuYw0KPj4+Pj4gQEAgLTMwNTMsNiArMzA1Myw5IEBA
IHZvaWQgX19pbml0IGNyZWF0ZV9kb20wKHZvaWQpDQo+Pj4+PiAgICAgaWYgKCBpb21tdV9lbmFi
bGVkICkNCj4+Pj4+ICAgICAgICAgZG9tMF9jZmcuZmxhZ3MgfD0gWEVOX0RPTUNUTF9DREZfaW9t
bXU7DQo+Pj4+PiANCj4+Pj4+ICsgICAgaWYgKCBpc19wY2lfcGFzc3Rocm91Z2hfZW5hYmxlZCgp
ICkNCj4+Pj4+ICsgICAgICAgIGRvbTBfY2ZnLmZsYWdzIHw9IFhFTl9ET01DVExfQ0RGX3ZwY2k7
DQo+Pj4+IEkgdGhpbmsgSSdtIGNvbmZ1c2VkIHdpdGggdGhpcy4gWW91IHNlZW0gdG8gZW5hYmxl
IHZQQ0kgZm9yIGRvbTAsIGJ1dA0KPj4+PiB0aGVuIGRvbWFpbl92cGNpX2luaXQgd2lsbCBzZXR1
cCB0cmFwcyBmb3IgdGhlIGd1ZXN0IHZpcnR1YWwgRUNBTQ0KPj4+PiBsYXlvdXQsIG5vdCB0aGUg
bmF0aXZlIG9uZSB0aGF0IGRvbTAgd2lsbCBiZSB1c2luZy4NCj4+PiBJIHRoaW5rIGFmdGVyIHRo
ZSBsYXN0IGRpc2N1c3Npb25zLCBpdCB3YXMgZGVjaWRlZCB0byBhbHNvIGluc3RhbGxlZCB0aGUg
dnBjaQ0KPj4+IGhhbmRsZXIgZm9yIGRvbTAuIEkgd2lsbCBoYXZlIHRvIGxvb2sgaW50byB0aGlz
IGFuZCBjb21lIGJhY2sgdG8geW91Lg0KPj4+IEBPbGVrc2FuZHI6IENvdWxkIHlvdSBjb21tZW50
IG9uIHRoaXMuDQo+PiBZZXMsIHdlIGRvIHRyYXAgRG9tMCBhcyB3ZWxsLiBUaGUgRG9tMCB0cmFw
cyBhcmUgbm90IGluIHRoaXMgc2VyaWVzLCBidXQNCj4+IGFyZSBpbiBtaW5lIGFzIGl0IG5lZWRz
IG1vcmUgcHJlcGFyYXRvcnkgd29yayBmb3IgdGhhdC4gUGxlYXNlIHNlZSBbMV0NCj4gDQo+IFRo
ZW4gSSBkb24ndCB0aGluayB3ZSBzaG91bGQgc2V0IFhFTl9ET01DVExfQ0RGX3ZwY2kgZm9yIGRv
bTAgaGVyZSwgaXQNCj4gc2hvdWxkIGluc3RlYWQgYmUgZG9uZSBpbiB0aGUgcGF0Y2ggd2hlcmUg
ZG9tMCBzdXBwb3J0IGlzIGludHJvZHVjZWQuDQoNCk9rIEkgd2lsbCBjaGVjayB0byByZW1vdmUg
dGhpcyBhbmQgaW5jbHVkZSB0aGUgY2hhbmdlIGluIHY2Lg0KDQpDaGVlcnMNCkJlcnRyYW5kDQoN
Cj4gDQo+IFRoYW5rcywgUm9nZXIuDQoNCg==


From xen-devel-bounces@lists.xenproject.org Mon Oct 11 17:28:50 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 17:28:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.206406.361962 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZz6T-0007Q8-IS; Mon, 11 Oct 2021 17:28:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 206406.361962; Mon, 11 Oct 2021 17:28:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZz6T-0007Q1-FG; Mon, 11 Oct 2021 17:28:45 +0000
Received: by outflank-mailman (input) for mailman id 206406;
 Mon, 11 Oct 2021 17:28:44 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=gQnf=O7=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1mZz6S-0007Ps-0h
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 17:28:44 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 735cb9ed-2ea4-48ac-990c-2295ab3066d4;
 Mon, 11 Oct 2021 17:28:42 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id CDF6560E74;
 Mon, 11 Oct 2021 17:28:41 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 735cb9ed-2ea4-48ac-990c-2295ab3066d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1633973322;
	bh=Cah+iOgRJ3+IJpmZPQz4AydeW78R31RwlS60HcfXfdA=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=AXzWmOVv28jzGY4LD3yeoz7nRzfxYiHB8xqi/QrgrT3G3EiCH7wcr4/cuF9828rMC
	 VEu1wYMaWB7YgjV55d1OMtqVjXZglrhD2+9vjM5YanFUdMZtDW46bGA4eHPrqrpnxE
	 4nrOPL7xZvdwaVjMnePxkeK0ZtW6dRFSXBKVZh6uy6GBAi+KOk+CDHIgcJOfrjHPvG
	 92L2MO02YYljVOOXQQRC4kLkNg5zBMxthzpybLvNZ0/awD+GqAbaByLM6kHQRi2YvE
	 5RBWMkZ+EaRTOwKxMcAUInkKj/Wmce4FfCXTa+pL4PLPPZiPpNxOYxj1WD+cRL2Fju
	 WtNFdytRSo2+g==
Date: Mon, 11 Oct 2021 10:28:41 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Bertrand Marquis <Bertrand.Marquis@arm.com>
cc: Jan Beulich <jbeulich@suse.com>, Luca Fancellu <Luca.Fancellu@arm.com>, 
    Wei Chen <Wei.Chen@arm.com>, Stefano Stabellini <sstabellini@kernel.org>, 
    Julien Grall <julien@xen.org>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, 
    Andrew Cooper <andrew.cooper3@citrix.com>, 
    George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>, 
    Wei Liu <wl@xen.org>, 
    "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v5 1/2] arm/efi: Use dom0less configuration when using
 EFI boot
In-Reply-To: <C1176381-C6D5-46BD-A13D-7F3E7528B655@arm.com>
Message-ID: <alpine.DEB.2.21.2110111022300.25528@sstabellini-ThinkPad-T480s>
References: <20211011080302.24203-1-luca.fancellu@arm.com> <20211011080302.24203-2-luca.fancellu@arm.com> <d7acbd79-fca0-f388-5304-9f85dba304fc@suse.com> <9D5D9F7A-F399-4C8C-80A6-C3B8452729D0@arm.com> <b235bb9b-d9c5-5e70-fbe7-9683e5979075@suse.com>
 <C1176381-C6D5-46BD-A13D-7F3E7528B655@arm.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Mon, 11 Oct 2021, Bertrand Marquis wrote:
> Hi Jan,
> 
> > On 11 Oct 2021, at 09:52, Jan Beulich <jbeulich@suse.com> wrote:
> > 
> > On 11.10.2021 10:50, Luca Fancellu wrote:
> >>> On 11 Oct 2021, at 09:11, Jan Beulich <jbeulich@suse.com> wrote:
> >>> On 11.10.2021 10:03, Luca Fancellu wrote:
> >>>> This patch introduces the support for dom0less configuration
> >>>> when using UEFI boot on ARM, it permits the EFI boot to
> >>>> continue if no dom0 kernel is specified but at least one domU
> >>>> is found.
> >>>> 
> >>>> Introduce the new property "xen,uefi-binary" for device tree boot
> >>>> module nodes that are subnode of "xen,domain" compatible nodes.
> >>>> The property holds a string containing the file name of the
> >>>> binary that shall be loaded by the uefi loader from the filesystem.
> >>>> 
> >>>> Introduce a new call efi_check_dt_boot(...) called during EFI boot
> >>>> that checks for module to be loaded using device tree.
> >>>> Architectures that don't support device tree don't have to
> >>>> provide this function.
> >>>> 
> >>>> Update efi documentation about how to start a dom0less
> >>>> setup using UEFI
> >>>> 
> >>>> Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>
> >>>> Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>
> >>>> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
> >>> 
> >>> Did you get indication that these are fine to retain with ...
> >>> 
> >>>> ---
> >>>> Changes in v5:
> >>>> - Removed unneeded variable initialization
> >>>> - Fixed comment
> >>>> - Fixed error message for the absence of an initial domain kernel
> >>>> - changed efi_arch_check_dt_boot to efi_check_dt_boot and add
> >>>> a stub if CONFIG_HAS_DEVICE_TREE is not declared, updated commit
> >>>> message about the call introduction in the EFI boot flow.
> >>> 
> >>> ... all of these changes? Every individual change may be minor enough,
> >>> but their sum makes me wonder. If so (or if at least one of the two
> >>> gets re-offered)
> >>> Acked-by: Jan Beulich <jbeulich@suse.com>
> >>> albeit preferably with ...
> >>> 
> >>>> --- a/xen/common/efi/boot.c
> >>>> +++ b/xen/common/efi/boot.c
> >>>> @@ -166,6 +166,13 @@ static void __init PrintErr(const CHAR16 *s)
> >>>>    StdErr->OutputString(StdErr, (CHAR16 *)s );
> >>>> }
> >>>> 
> >>>> +#ifndef CONFIG_HAS_DEVICE_TREE
> >>>> +static inline int __init efi_check_dt_boot(EFI_FILE_HANDLE dir_handle)
> >>> 
> >>> ... the "inline" here dropped. We don't normally add this outside of
> >>> headers, leaving it to the compiler to decide. In headers it's wanted
> >>> to avoid "defined by never used" style warnings.
> >> 
> >> Ok I can drop it in a next serie and retain your Ack, or is it something that
> >> can be done on commit? 
> > 
> > I guess that's easy enough to do while committing. Provided of course
> > the two R-b get confirmed.
> 
> I confirm my R-b.

I also confirm my reviewed-by. Also, I am aware of the change suggested
by Julien about using multiboot,module for the is_boot_module check and
I am fine with it too.


From xen-devel-bounces@lists.xenproject.org Mon Oct 11 17:33:47 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 17:33:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.206413.361973 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZzBK-0000O4-5s; Mon, 11 Oct 2021 17:33:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 206413.361973; Mon, 11 Oct 2021 17:33:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZzBK-0000Nx-1z; Mon, 11 Oct 2021 17:33:46 +0000
Received: by outflank-mailman (input) for mailman id 206413;
 Mon, 11 Oct 2021 17:33:44 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=gQnf=O7=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1mZzBI-0000Nr-QR
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 17:33:44 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 61793dde-2ab9-11ec-80ee-12813bfff9fa;
 Mon, 11 Oct 2021 17:33:43 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id DCF5260E78;
 Mon, 11 Oct 2021 17:33:42 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 61793dde-2ab9-11ec-80ee-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1633973623;
	bh=T3dE3duvaT7dDvFbb1WavfcABhCpP4MuROJ7Q1FBVT0=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=oUZOAwktmCaKkUBrdnU0Wv3tskdNazpgGuLWGugLkvV9gaSsX/C5dnE5K5PYvs2nN
	 y5JqgbG5iI4vIc1sFFZcnsQ+9Ey69fxJnjP1I3t8BLh0bnAI8pYDjxCa0SQKx58skT
	 XhTXWMvFHvm/6QV44xMUNE4P/YTcdl9fyicxe6NGbceDytZidiqQ1XlO43fJOdYuy7
	 yL/Jgq5NBhPakCRd/5CKmmkR4BrCH9PzGYNbrGpK+tNjUYzYf1UqZm8C2oNScIY1zS
	 EeDgogbPfzSa5KhsBljQ5RVRhfh/iVbpYYb33C2VM0r784+WSLNlIIDo0QdnNvVqke
	 Q7JMH/oao8wWw==
Date: Mon, 11 Oct 2021 10:33:42 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Bertrand Marquis <Bertrand.Marquis@arm.com>
cc: Luca Fancellu <Luca.Fancellu@arm.com>, 
    "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, 
    Wei Chen <Wei.Chen@arm.com>, Stefano Stabellini <sstabellini@kernel.org>, 
    Julien Grall <julien@xen.org>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH] arm/efi: Fix null pointer dereference
In-Reply-To: <3608432D-0D55-4373-B262-328A096C1388@arm.com>
Message-ID: <alpine.DEB.2.21.2110111033340.25528@sstabellini-ThinkPad-T480s>
References: <20211011075638.23785-1-luca.fancellu@arm.com> <3608432D-0D55-4373-B262-328A096C1388@arm.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Mon, 11 Oct 2021, Bertrand Marquis wrote:
> Hi Luca,
> 
> > On 11 Oct 2021, at 08:56, Luca Fancellu <Luca.Fancellu@arm.com> wrote:
> > 
> > Fix for commit 60649d443dc395243e74d2b3e05594ac0c43cfe3
> > that introduces a null pointer dereference when the
> > fdt_node_offset_by_compatible is called with "fdt"
> > argument null.
> > 
> > Reported-by: Julien Grall <julien@xen.org>
> > Fixes: 60649d443d ("arm/efi: Introduce xen,uefi-cfg-load DT property")
> > Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>
> Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>

Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>


> > ---
> > xen/arch/arm/efi/efi-boot.h | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/xen/arch/arm/efi/efi-boot.h b/xen/arch/arm/efi/efi-boot.h
> > index a3e46453d4..e63dafac26 100644
> > --- a/xen/arch/arm/efi/efi-boot.h
> > +++ b/xen/arch/arm/efi/efi-boot.h
> > @@ -593,7 +593,8 @@ static bool __init efi_arch_use_config_file(EFI_SYSTEM_TABLE *SystemTable)
> >     dtbfile.ptr = fdt;
> >     dtbfile.need_to_free = false; /* Config table memory can't be freed. */
> > 
> > -    if ( fdt_node_offset_by_compatible(fdt, 0, "multiboot,module") > 0 )
> > +    if ( fdt &&
> > +         (fdt_node_offset_by_compatible(fdt, 0, "multiboot,module") > 0) )
> >     {
> >         /* Locate chosen node */
> >         int node = fdt_subnode_offset(fdt, 0, "chosen");
> > -- 
> > 2.17.1
> > 
> 


From xen-devel-bounces@lists.xenproject.org Mon Oct 11 17:49:17 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 17:49:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.206420.361984 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZzQF-0001w2-G2; Mon, 11 Oct 2021 17:49:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 206420.361984; Mon, 11 Oct 2021 17:49:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZzQF-0001vv-Cn; Mon, 11 Oct 2021 17:49:11 +0000
Received: by outflank-mailman (input) for mailman id 206420;
 Mon, 11 Oct 2021 17:49:09 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=obo4=O7=gmail.com=olekstysh@srs-us1.protection.inumbo.net>)
 id 1mZzQD-0001vo-Il
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 17:49:09 +0000
Received: from mail-lf1-x12e.google.com (unknown [2a00:1450:4864:20::12e])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 7ec24e22-19c1-4933-9872-8733249f8a14;
 Mon, 11 Oct 2021 17:49:08 +0000 (UTC)
Received: by mail-lf1-x12e.google.com with SMTP id j21so59258943lfe.0
 for <xen-devel@lists.xenproject.org>; Mon, 11 Oct 2021 10:49:08 -0700 (PDT)
Received: from otyshchenko.router ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id h4sm789688lfk.193.2021.10.11.10.49.05
 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
 Mon, 11 Oct 2021 10:49:06 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7ec24e22-19c1-4933-9872-8733249f8a14
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id;
        bh=vPpPUAzXrj0gMt+2vHmt58Cm6+FwkIlfdfX8jY3NNww=;
        b=LDvb6TVm2oGo0oDIOIlTf9ImmXZjsxRa+XcTl+5twYV+wVzkJMXSc2Lj2Pdr2Esh2u
         VDPHoEJJ6YcdIyy0x0WsbouuBpLHxOeEctjKdRWXDFh13MGgHJO1HQ3XHAhOoEcJKeuO
         u8UmqZxNsYaVpeyPno37YGIw4ikNpysZuE7fGY9EH21Au3+IxubbjLNuku4lgrkAPN8M
         Frv+hZXq+YRzEjAVyjyIxT/fgunX1v9VkjhuXIKfoEN/+bfrzF/EXuPjHmYLxDAltnLa
         f/ISzAypajO7a44wp5rhp61mF8ckF2n26LQFe9GHtxvMeDyXUhq3O85aS5FLluEaTffK
         F1Pg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id;
        bh=vPpPUAzXrj0gMt+2vHmt58Cm6+FwkIlfdfX8jY3NNww=;
        b=Gr5NmBLfFFB4cJMYTVbv9vDLnbD8N8IfTqEYLUtugoXD6LaLGy7iZvA1PwAn2L1iq9
         gA30i3fKpdvAtNA2Ay/AMPeioNRdECYT8S4OozH/zc4hfIaFIyeFF+5dYDf5vX5vBUP2
         94cM8p/aZ+AMETSk/vhNHH6PYoQCJCIxIRpqejbHOd0QrSyplwU4vhzA/VhX34Q6dSZl
         YXZzCnQlLBojo2GCIelafl7iUS07ti/nOHmhNOhP5ORIcG/ANU3blAtvKuaQpV2PKt7a
         3a9n5WuS30SWDJM7MpxQODasR001rb1VcOHZbaT1dMqE1fvnG8Pplig93/B8i9khrb0I
         4Aug==
X-Gm-Message-State: AOAM531C+GO+0hqVQLhife9ql9it7Flncb51gi1OemxS1o5MenthR3nJ
	3+5HI3Koa28IGjoLTmveUDq7ekiLu88=
X-Google-Smtp-Source: ABdhPJyxk9Vuo0kJojQh0+DR87ja8CZUqZWGa2bfNjIQBAwdSjW6MRmEDs9E2bLClu3j6o+ewQk3Lg==
X-Received: by 2002:a2e:5c8:: with SMTP id 191mr25133179ljf.126.1633974546816;
        Mon, 11 Oct 2021 10:49:06 -0700 (PDT)
From: Oleksandr Tyshchenko <olekstysh@gmail.com>
To: xen-devel@lists.xenproject.org
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Ian Jackson <iwj@xenproject.org>,
	Wei Liu <wl@xen.org>,
	Anthony PERARD <anthony.perard@citrix.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Juergen Gross <jgross@suse.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	Henry Wang <Henry.Wang@arm.com>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Wei Chen <Wei.Chen@arm.com>
Subject: [PATCH V6 0/2] Add handling of extended regions (safe ranges) on Arm (Was "xen/memory: Introduce a hypercall to provide unallocated space")
Date: Mon, 11 Oct 2021 20:48:57 +0300
Message-Id: <1633974539-7380-1-git-send-email-olekstysh@gmail.com>
X-Mailer: git-send-email 2.7.4

From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>

You can find an initial discussion at [1]-[6].

The extended region (safe range) is a region of guest physical address space
which is unused and could be safely used to create grant/foreign mappings instead
of wasting real RAM pages from the domain memory for establishing these mappings.

The extended regions are chosen at the domain creation time and advertised
to it via "reg" property under hypervisor node in the guest device-tree
(the indexes for extended regions are 1...N).
No device tree bindings update is needed, guest infers the presense of extended
regions from the number of regions in "reg" property.
New compatible/property will be needed (but only after this patch [7] or alternative
goes in) to indicate that "region 0 is safe to use". Until this patch is merged it is
not safe to use extended regions for the grant table space.

The extended regions are calculated differently for direct mapped Dom0 (with and without
IOMMU) and non-direct mapped DomUs.

Please note the following limitations:
- The extended region feature is only supported for 64-bit domain currently.
- The ACPI case is not covered.

Please note that support for Dom0 was already committed, so these patches are remaining DomU bits.

Xen patch series is also available at [8]. The corresponding Linux patch series is at [9]
for now (last 4 patches).

Tested on Renesas Salvator-X board + H3 ES3.0 SoC (Arm64) with updated virtio-disk backend [10]
running in Dom0 (256MB RAM) and DomD (2GB RAM). In both cases the backend pre-maps DomU memory
which is 3GB. All foreign memory gets mapped into extended regions (so the amount of RAM in
the backend domain is not reduced). No issues were observed.

[1] https://lore.kernel.org/xen-devel/1627489110-25633-1-git-send-email-olekstysh@gmail.com/
[2] https://lore.kernel.org/xen-devel/1631034578-12598-1-git-send-email-olekstysh@gmail.com/
[3] https://lore.kernel.org/xen-devel/1631297924-8658-1-git-send-email-olekstysh@gmail.com/
[4] https://lore.kernel.org/xen-devel/1632437334-12015-1-git-send-email-olekstysh@gmail.com/
[5] https://lore.kernel.org/xen-devel/1632955927-27911-1-git-send-email-olekstysh@gmail.com/
[6] https://lore.kernel.org/xen-devel/1633519346-3686-1-git-send-email-olekstysh@gmail.com/
[7] https://lore.kernel.org/xen-devel/1632425551-18910-1-git-send-email-olekstysh@gmail.com/
[8] https://github.com/otyshchenko1/xen/commits/map_opt_ml7
[9] https://github.com/otyshchenko1/linux/commits/map_opt_ml4
[10] https://github.com/otyshchenko1/virtio-disk/commits/map_opt_next

Oleksandr Tyshchenko (2):
  xen/arm: Introduce gpaddr_bits field to struct
    xen_domctl_getdomaininfo
  libxl/arm: Add handling of extended regions for DomU

 tools/include/libxl.h            |  8 +++++
 tools/include/xenctrl.h          |  1 +
 tools/libs/ctrl/xc_domain.c      |  1 +
 tools/libs/light/libxl_arm.c     | 76 +++++++++++++++++++++++++++++++++++++---
 tools/libs/light/libxl_domain.c  |  1 +
 tools/libs/light/libxl_types.idl |  1 +
 xen/arch/arm/domctl.c            |  2 ++
 xen/arch/x86/domctl.c            |  1 +
 xen/include/public/arch-arm.h    |  2 ++
 xen/include/public/domctl.h      |  3 +-
 10 files changed, 90 insertions(+), 6 deletions(-)

-- 
2.7.4



From xen-devel-bounces@lists.xenproject.org Mon Oct 11 17:49:17 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 17:49:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.206421.361995 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZzQJ-0002Co-O5; Mon, 11 Oct 2021 17:49:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 206421.361995; Mon, 11 Oct 2021 17:49:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZzQJ-0002Ch-Kv; Mon, 11 Oct 2021 17:49:15 +0000
Received: by outflank-mailman (input) for mailman id 206421;
 Mon, 11 Oct 2021 17:49:14 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=obo4=O7=gmail.com=olekstysh@srs-us1.protection.inumbo.net>)
 id 1mZzQI-0001vo-Gw
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 17:49:14 +0000
Received: from mail-lf1-x129.google.com (unknown [2a00:1450:4864:20::129])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 4eb6c7fa-a285-46ca-b287-31a54aa77a6d;
 Mon, 11 Oct 2021 17:49:09 +0000 (UTC)
Received: by mail-lf1-x129.google.com with SMTP id j5so77000175lfg.8
 for <xen-devel@lists.xenproject.org>; Mon, 11 Oct 2021 10:49:08 -0700 (PDT)
Received: from otyshchenko.router ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id h4sm789688lfk.193.2021.10.11.10.49.06
 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
 Mon, 11 Oct 2021 10:49:07 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4eb6c7fa-a285-46ca-b287-31a54aa77a6d
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references;
        bh=L+Vz4g8mPdTUD6U0yWxfJ59oXSdq+i7jG1ZWATUEews=;
        b=Kikq9z9xIVPwRfqXxyfjVyqc7Z/XIn+fsI9o3ya2bgHJl+aduFHx8oj8ZIOXMtuq3z
         cI0tb0EN1WIR3eB+ppRpjsJWhLpIipX6k/EzYutfv2+bOVaebXnXFZvhKcubshAF5lNK
         7LFRf8Pa3l7lohNLmMR6vJQoKFkjCNHmBau2oKYQkuGx0KreHzxbbEg1MDp7xgnWa9eE
         DNAl9ALaMckrA5NRn0rgCk+cywQgBdkU2Q4NJsnN4RSt5vTILejnFunPYHvViOp9KAgH
         Ct91bk284aSWgqp8q1efwqwzKO8lna8+wF/NtZQ+xamu0D/U6ALk5r4NHdgi2LrI7tAj
         Vo5A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references;
        bh=L+Vz4g8mPdTUD6U0yWxfJ59oXSdq+i7jG1ZWATUEews=;
        b=GedLVwo0Q03iRk+gGQX0hutjDhQ02aHt34MSK+f7Zw6mbLhk02L+jag0sfdcpKb/nd
         zZfin2LG4WizmhNgwE7XZG/rF7BGxtd6KpuS5+FK9pya5mo61tutztj5+iKUVKCQUR7R
         Aiu3kE9bpVPqpGDyMqBe89hSZW/x9ViF3t2mMObJFSWhQIQ0hDDD2mbfysSa+yk5Sz0b
         pqMw+vfkHwvg/PeTMniDSU5oD7l15EZThze1PRh37aP+tNuSetWqjshTwU4nMjRXdCn+
         2Ggm48rdGJwhH3kJkemP0LwDwRQ9ngZiH0nj3oIsjxaFXObUJ7k13Vm/olcl9bVKruSW
         C3qg==
X-Gm-Message-State: AOAM530eWKmKC4ti+6zcjYkuGs0Jp4o6MJC0u2y1kT8h+nqYAWL3cr/z
	tzQoba3Dpoio2OnXFJ+i2WM4M3D58p0=
X-Google-Smtp-Source: ABdhPJwJtJrvRFK/aU40SBxwZDoY17MYen4S/0b4K+26XC1I82rmcqf7XK7YSqcAmQ/PvF2x4MYGRg==
X-Received: by 2002:a05:6512:22c2:: with SMTP id g2mr28212682lfu.577.1633974547815;
        Mon, 11 Oct 2021 10:49:07 -0700 (PDT)
From: Oleksandr Tyshchenko <olekstysh@gmail.com>
To: xen-devel@lists.xenproject.org
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Ian Jackson <iwj@xenproject.org>,
	Wei Liu <wl@xen.org>,
	Anthony PERARD <anthony.perard@citrix.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Juergen Gross <jgross@suse.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>
Subject: [PATCH V6 1/2] xen/arm: Introduce gpaddr_bits field to struct xen_domctl_getdomaininfo
Date: Mon, 11 Oct 2021 20:48:58 +0300
Message-Id: <1633974539-7380-2-git-send-email-olekstysh@gmail.com>
X-Mailer: git-send-email 2.7.4
In-Reply-To: <1633974539-7380-1-git-send-email-olekstysh@gmail.com>
References: <1633974539-7380-1-git-send-email-olekstysh@gmail.com>

From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>

We need to pass info about maximum supported guest physical
address space size to the toolstack on Arm in order to properly
calculate the base and size of the extended region (safe range)
for the guest. The extended region is unused address space which
could be safely used by domain for foreign/grant mappings on Arm.
The extended region itself will be handled by the subsequent
patch.

Currently the same guest physical address space size is used
for all guests (p2m_ipa_bits variable on Arm, the x86 equivalent
is hap_paddr_bits).

As we add new field to the structure bump the interface version.

Suggested-by: Julien Grall <jgrall@amazon.com>
Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
---
Changes RFC -> V2:
   - update patch subject/description
   - replace arch-specific sub-struct with common gpaddr_bits
     field and update code to reflect that

Changes V2 -> V3:
   - make the field uint8_t and add uint8_t pad[7] after
   - remove leading blanks in libxl.h

Changes V3 -> V4:
   - also print gpaddr_bits from output_physinfo()
   - add Michal's R-b

Changes V4 -> V5:
   - update patch subject and description
   - drop Michal's R-b
   - pass gpaddr_bits via createdomain domctl
     (struct xen_arch_domainconfig)

Changes V5 -> V6:
   - update patch subject and description
   - pass gpaddr_bits via getdomaininfo domctl
     (struct xen_domctl_getdomaininfo)
---
 tools/include/libxl.h            | 8 ++++++++
 tools/include/xenctrl.h          | 1 +
 tools/libs/ctrl/xc_domain.c      | 1 +
 tools/libs/light/libxl_domain.c  | 1 +
 tools/libs/light/libxl_types.idl | 1 +
 xen/arch/arm/domctl.c            | 2 ++
 xen/arch/x86/domctl.c            | 1 +
 xen/include/public/domctl.h      | 3 ++-
 8 files changed, 17 insertions(+), 1 deletion(-)

diff --git a/tools/include/libxl.h b/tools/include/libxl.h
index b9ba16d..deb5022 100644
--- a/tools/include/libxl.h
+++ b/tools/include/libxl.h
@@ -874,6 +874,14 @@ typedef struct libxl__ctx libxl_ctx;
 #define LIBXL_HAVE_DOMINFO_NEVER_STOP 1
 
 /*
+ * LIBXL_HAVE_DOMINFO_GPADDR_BITS
+ *
+ * If this is defined, libxl_dominfo will contain an uint8 field called
+ * gpaddr_bits, containing the guest physical address space size.
+ */
+#define LIBXL_HAVE_DOMINFO_GPADDR_BITS 1
+
+/*
  * LIBXL_HAVE_QXL
  *
  * If defined, then the libxl_vga_interface_type will contain another value:
diff --git a/tools/include/xenctrl.h b/tools/include/xenctrl.h
index a306399..07b96e6 100644
--- a/tools/include/xenctrl.h
+++ b/tools/include/xenctrl.h
@@ -462,6 +462,7 @@ typedef struct xc_dominfo {
     unsigned int  max_vcpu_id;
     xen_domain_handle_t handle;
     unsigned int  cpupool;
+    uint8_t       gpaddr_bits;
     struct xen_arch_domainconfig arch_config;
 } xc_dominfo_t;
 
diff --git a/tools/libs/ctrl/xc_domain.c b/tools/libs/ctrl/xc_domain.c
index 23322b7..b155d6a 100644
--- a/tools/libs/ctrl/xc_domain.c
+++ b/tools/libs/ctrl/xc_domain.c
@@ -396,6 +396,7 @@ int xc_domain_getinfo(xc_interface *xch,
         info->nr_online_vcpus = domctl.u.getdomaininfo.nr_online_vcpus;
         info->max_vcpu_id = domctl.u.getdomaininfo.max_vcpu_id;
         info->cpupool = domctl.u.getdomaininfo.cpupool;
+        info->gpaddr_bits = domctl.u.getdomaininfo.gpaddr_bits;
         info->arch_config = domctl.u.getdomaininfo.arch_config;
 
         memcpy(info->handle, domctl.u.getdomaininfo.handle,
diff --git a/tools/libs/light/libxl_domain.c b/tools/libs/light/libxl_domain.c
index 51a6127..544a9bf 100644
--- a/tools/libs/light/libxl_domain.c
+++ b/tools/libs/light/libxl_domain.c
@@ -306,6 +306,7 @@ void libxl__xcinfo2xlinfo(libxl_ctx *ctx,
     xlinfo->vcpu_max_id = xcinfo->max_vcpu_id;
     xlinfo->vcpu_online = xcinfo->nr_online_vcpus;
     xlinfo->cpupool = xcinfo->cpupool;
+    xlinfo->gpaddr_bits = xcinfo->gpaddr_bits;
     xlinfo->domain_type = (xcinfo->flags & XEN_DOMINF_hvm_guest) ?
         LIBXL_DOMAIN_TYPE_HVM : LIBXL_DOMAIN_TYPE_PV;
 }
diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_types.idl
index 3f9fff6..2df7258 100644
--- a/tools/libs/light/libxl_types.idl
+++ b/tools/libs/light/libxl_types.idl
@@ -357,6 +357,7 @@ libxl_dominfo = Struct("dominfo",[
     ("vcpu_max_id", uint32),
     ("vcpu_online", uint32),
     ("cpupool",     uint32),
+    ("gpaddr_bits", uint8),
     ("domain_type", libxl_domain_type),
     ], dir=DIR_OUT)
 
diff --git a/xen/arch/arm/domctl.c b/xen/arch/arm/domctl.c
index b7d27f3..6245af6 100644
--- a/xen/arch/arm/domctl.c
+++ b/xen/arch/arm/domctl.c
@@ -20,6 +20,8 @@ void arch_get_domain_info(const struct domain *d,
 {
     /* All ARM domains use hardware assisted paging. */
     info->flags |= XEN_DOMINF_hap;
+
+    info->gpaddr_bits = p2m_ipa_bits;
 }
 
 static int handle_vuart_init(struct domain *d, 
diff --git a/xen/arch/x86/domctl.c b/xen/arch/x86/domctl.c
index 26a76d2..7d102e0 100644
--- a/xen/arch/x86/domctl.c
+++ b/xen/arch/x86/domctl.c
@@ -151,6 +151,7 @@ void arch_get_domain_info(const struct domain *d,
         info->flags |= XEN_DOMINF_hap;
 
     info->arch_config.emulation_flags = d->arch.emulation_flags;
+    info->gpaddr_bits = hap_paddr_bits;
 }
 
 static int do_vmtrace_op(struct domain *d, struct xen_domctl_vmtrace_op *op,
diff --git a/xen/include/public/domctl.h b/xen/include/public/domctl.h
index 4cb3f66..b93f776 100644
--- a/xen/include/public/domctl.h
+++ b/xen/include/public/domctl.h
@@ -38,7 +38,7 @@
 #include "hvm/save.h"
 #include "memory.h"
 
-#define XEN_DOMCTL_INTERFACE_VERSION 0x00000014
+#define XEN_DOMCTL_INTERFACE_VERSION 0x00000015
 
 /*
  * NB. xen_domctl.domain is an IN/OUT parameter for this operation.
@@ -150,6 +150,7 @@ struct xen_domctl_getdomaininfo {
     uint32_t ssidref;
     xen_domain_handle_t handle;
     uint32_t cpupool;
+    uint8_t gpaddr_bits; /* Guest physical address space size. */
     struct xen_arch_domainconfig arch_config;
 };
 typedef struct xen_domctl_getdomaininfo xen_domctl_getdomaininfo_t;
-- 
2.7.4



From xen-devel-bounces@lists.xenproject.org Mon Oct 11 17:49:21 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 17:49:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.206422.362006 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZzQP-0002X4-3k; Mon, 11 Oct 2021 17:49:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 206422.362006; Mon, 11 Oct 2021 17:49:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZzQO-0002Wt-V4; Mon, 11 Oct 2021 17:49:20 +0000
Received: by outflank-mailman (input) for mailman id 206422;
 Mon, 11 Oct 2021 17:49:19 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=obo4=O7=gmail.com=olekstysh@srs-us1.protection.inumbo.net>)
 id 1mZzQN-0001vo-HC
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 17:49:19 +0000
Received: from mail-lf1-x12e.google.com (unknown [2a00:1450:4864:20::12e])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 01670e9f-3c57-4828-971e-693757756b4d;
 Mon, 11 Oct 2021 17:49:09 +0000 (UTC)
Received: by mail-lf1-x12e.google.com with SMTP id j5so77000296lfg.8
 for <xen-devel@lists.xenproject.org>; Mon, 11 Oct 2021 10:49:09 -0700 (PDT)
Received: from otyshchenko.router ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id h4sm789688lfk.193.2021.10.11.10.49.07
 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
 Mon, 11 Oct 2021 10:49:08 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 01670e9f-3c57-4828-971e-693757756b4d
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references;
        bh=wPDJEBVjrNdWVk2UD/ygEhxoYGrfSVfG9OQX/DRhwzc=;
        b=pHHlYvOZkJ0uIrrNuzHHPoUGuU4IdpYiw1zasAJOc1E5//KkqpCYk1wxHrtX90cd3I
         fW3bbb9Dj2+p65woTp9IMZVi6lPOgSXp42LMd5g1SK52SAOJOwzea135o57WGnQP52by
         t6dlFWpQXlNwDIKQqfEM3V8fVSHmYM4dWVGkAajEZZf/UcF+X6A0vJssxbJeb0o7EZA2
         IR1/EDstn00xSZUOGJTWOooPpd6CFiXJMfyFbsgPcSyBMZ+sM7TDEzyyx1AvawVqsEXH
         CA63l8CNpFaQ6bpYjBC3CP8uwdz2HJEUzPvXFT2Q8rWywdPxbQOY8kmPK+m1Y03WqG4x
         zNGQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references;
        bh=wPDJEBVjrNdWVk2UD/ygEhxoYGrfSVfG9OQX/DRhwzc=;
        b=6w60YELR5zLqk65Ab//kMW9noMeMw9HmkKbnrJB9Q8MD26fPdkWbqYt5nnSFiFs8Nf
         tA+JjCxJRNJHX6RlAgnmiQfq+Qk+S1e4nGxs445V1QoQNv7rpueOsZ1sVwAdHgyEaMQ/
         rMSvrJnKQhdJYIUHy+aEQLMHwdQ5q9zlTYCHTt5icv0dO2jHkxmWJOB2poix2MvAwXes
         /jl0h/M54yZSSpyWo9zD+eTLkUg7t/ahZSZyRUGcRsyqlxVhVaIEAywaHaTzVQ31JwB0
         L1i8W8kdL6buN59iRbv0bW5rlvJ1EOfLH12d+d1Dol7Ii3JOXjrn60QULu+9XD1OhuvT
         n04A==
X-Gm-Message-State: AOAM5329VrdmnftuislXAsqZzKTBaF2sR/g98fm3BNC6J7XmJ5ECeXRj
	6abWwbmzC0eovY+RUGmi+DhKkwNgEx8=
X-Google-Smtp-Source: ABdhPJxCU5LhyJgoC5HOhFrjkKgfAyX+hjJ+nlEL7yWGHE2IdVB9mtvQwiBNJyKMKCGIniL4w/rBug==
X-Received: by 2002:a2e:1301:: with SMTP id 1mr1748772ljt.479.1633974548611;
        Mon, 11 Oct 2021 10:49:08 -0700 (PDT)
From: Oleksandr Tyshchenko <olekstysh@gmail.com>
To: xen-devel@lists.xenproject.org
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Ian Jackson <iwj@xenproject.org>,
	Wei Liu <wl@xen.org>,
	Anthony PERARD <anthony.perard@citrix.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: [PATCH V6 2/2] libxl/arm: Add handling of extended regions for DomU
Date: Mon, 11 Oct 2021 20:48:59 +0300
Message-Id: <1633974539-7380-3-git-send-email-olekstysh@gmail.com>
X-Mailer: git-send-email 2.7.4
In-Reply-To: <1633974539-7380-1-git-send-email-olekstysh@gmail.com>
References: <1633974539-7380-1-git-send-email-olekstysh@gmail.com>

From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>

The extended region (safe range) is a region of guest physical
address space which is unused and could be safely used to create
grant/foreign mappings instead of wasting real RAM pages from
the domain memory for establishing these mappings.

The extended regions are chosen at the domain creation time and
advertised to it via "reg" property under hypervisor node in
the guest device-tree. As region 0 is reserved for grant table
space (always present), the indexes for extended regions are 1...N.
If extended regions could not be allocated for some reason,
Xen doesn't fail and behaves as usual, so only inserts region 0.

Please note the following limitations:
- The extended region feature is only supported for 64-bit domain
  currently.
- The ACPI case is not covered.

***

The algorithm to choose extended regions for non-direct mapped
DomU is simpler in comparison with the algorithm for direct mapped
Dom0. We usually have a lot of unused space above 4GB, and might
have some unused space below 4GB (depends on guest memory size).
Try to allocate separate 2MB-aligned extended regions from the first
(below 4GB) and second (above 4GB) RAM banks taking into the account
the maximum supported guest physical address space size and the amount
of memory assigned to the guest. The minimum size of extended region
the same as for Dom0 (64MB).

Suggested-by: Julien Grall <jgrall@amazon.com>
Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
---
Changes RFC -> V2:
   - update patch description
   - drop uneeded "extended-region" DT property
   - clear reg array in finalise_ext_region() and add a TODO

Changes V2 -> V3:
   - update patch description, comments in code
   - only pick up regions with size >= 64MB
   - move the region calculation to make_hypervisor_node() and drop
     finalise_ext_region()
   - extend the list of arguments for make_hypervisor_node()
   - do not show warning for 32-bit domain
   - change the region alignment from 1GB to 2MB
   - move EXT_REGION_SIZE to public/arch-arm.h

Changes V3 -> V4:
   - add R-b, A-b and T-b

Changes V4 -> V5:
   - update patch description and comments in code
   - reflect changes done in previous patch to pass gpaddr_bits
     via createdomain domctl (struct xen_arch_domainconfig)
   - drop R-b, A-b and T-b
   - drop limit for maximum extended region size (128GB)
   - try to also allocate region below 4GB, optimize code
     for calculating extended regions

Change V5 -> V6:
   - reflect changes done in previous patch to pass gpaddr_bits
     via getdomaininfo domctl (struct xen_domctl_getdomaininfo)
   - reduce the number of local variables, rework calculations
---
 tools/libs/light/libxl_arm.c  | 76 ++++++++++++++++++++++++++++++++++++++++---
 xen/include/public/arch-arm.h |  2 ++
 2 files changed, 73 insertions(+), 5 deletions(-)

diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c
index e3140a6..c0e8415 100644
--- a/tools/libs/light/libxl_arm.c
+++ b/tools/libs/light/libxl_arm.c
@@ -598,9 +598,20 @@ static int make_timer_node(libxl__gc *gc, void *fdt,
     return 0;
 }
 
+#define ALIGN_UP_TO_2MB(x)   (((x) + MB(2) - 1) & (~(MB(2) - 1)))
+
 static int make_hypervisor_node(libxl__gc *gc, void *fdt,
-                                const libxl_version_info *vers)
+                                const libxl_version_info *vers,
+                                const libxl_domain_build_info *b_info,
+                                const struct xc_dom_image *dom)
 {
+    uint64_t region_size[GUEST_RAM_BANKS] = {0}, region_base[GUEST_RAM_BANKS],
+        bank1end, ramsize;
+    uint32_t regs[(GUEST_ROOT_ADDRESS_CELLS + GUEST_ROOT_SIZE_CELLS) *
+                  (GUEST_RAM_BANKS + 1)];
+    be32 *cells = &regs[0];
+    unsigned int i, len, nr_regions = 0;
+    libxl_dominfo info;
     int res;
     gic_interrupt intr;
 
@@ -615,9 +626,64 @@ static int make_hypervisor_node(libxl__gc *gc, void *fdt,
                               "xen,xen");
     if (res) return res;
 
-    /* reg 0 is grant table space */
-    res = fdt_property_regs(gc, fdt, GUEST_ROOT_ADDRESS_CELLS, GUEST_ROOT_SIZE_CELLS,
-                            1,GUEST_GNTTAB_BASE, GUEST_GNTTAB_SIZE);
+    if (strcmp(dom->guest_type, "xen-3.0-aarch64")) {
+        LOG(WARN, "The extended regions are only supported for 64-bit guest currently");
+        goto out;
+    }
+
+    res = libxl_domain_info(CTX, &info, dom->guest_domid);
+    if (res) return res;
+
+    assert(info.gpaddr_bits >= 32 && info.gpaddr_bits <= 48);
+
+    /*
+     * Try to allocate separate 2MB-aligned extended regions from the first
+     * (below 4GB) and second (above 4GB) RAM banks taking into the account
+     * the maximum supported guest physical address space size and the amount
+     * of memory assigned to the guest.
+     * As the guest memory layout is not populated yet we cannot rely on
+     * dom->rambank_size[], so calculate the actual size of both banks using
+     * "max_memkb" value.
+     */
+    ramsize = b_info->max_memkb * 1024;
+    if (ramsize <= GUEST_RAM0_SIZE) {
+        region_base[0] = GUEST_RAM0_BASE + ALIGN_UP_TO_2MB(ramsize);
+        region_size[0] = GUEST_RAM0_SIZE - ALIGN_UP_TO_2MB(ramsize);
+        region_base[1] = GUEST_RAM1_BASE;
+    } else
+        region_base[1] = GUEST_RAM1_BASE +
+            ALIGN_UP_TO_2MB(ramsize - GUEST_RAM0_SIZE);
+
+    bank1end = min(1ULL << info.gpaddr_bits, GUEST_RAM1_BASE + GUEST_RAM1_SIZE);
+    if (bank1end > region_base[1])
+        region_size[1] = bank1end - region_base[1];
+
+out:
+    /*
+     * The region 0 for grant table space must be always present. If we managed
+     * to allocate the extended regions then insert them as regions 1...N.
+     */
+    set_range(&cells, GUEST_ROOT_ADDRESS_CELLS, GUEST_ROOT_SIZE_CELLS,
+              GUEST_GNTTAB_BASE, GUEST_GNTTAB_SIZE);
+
+    for (i = 0; i < GUEST_RAM_BANKS; i++) {
+        if (region_size[i] < GUEST_EXT_REGION_MIN_SIZE)
+            continue;
+
+        LOG(DEBUG, "Extended region %u: %#"PRIx64"->%#"PRIx64"\n",
+            nr_regions, region_base[i], region_base[i] + region_size[i]);
+
+        set_range(&cells, GUEST_ROOT_ADDRESS_CELLS, GUEST_ROOT_SIZE_CELLS,
+                  region_base[i], region_size[i]);
+        nr_regions++;
+    }
+
+    if (!nr_regions)
+        LOG(WARN, "The extended regions cannot be allocated, not enough space");
+
+    len = sizeof(regs[0]) * (GUEST_ROOT_ADDRESS_CELLS + GUEST_ROOT_SIZE_CELLS) *
+        (nr_regions + 1);
+    res = fdt_property(fdt, "reg", regs, len);
     if (res) return res;
 
     /*
@@ -963,7 +1029,7 @@ next_resize:
         }
 
         FDT( make_timer_node(gc, fdt, ainfo, state->clock_frequency) );
-        FDT( make_hypervisor_node(gc, fdt, vers) );
+        FDT( make_hypervisor_node(gc, fdt, vers, info, dom) );
 
         if (info->arch_arm.vuart == LIBXL_VUART_TYPE_SBSA_UART)
             FDT( make_vpl011_uart_node(gc, fdt, ainfo, dom) );
diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h
index d46c61f..19ca2b0 100644
--- a/xen/include/public/arch-arm.h
+++ b/xen/include/public/arch-arm.h
@@ -451,6 +451,8 @@ typedef uint64_t xen_callback_t;
 #define GUEST_RAM_BANK_BASES   { GUEST_RAM0_BASE, GUEST_RAM1_BASE }
 #define GUEST_RAM_BANK_SIZES   { GUEST_RAM0_SIZE, GUEST_RAM1_SIZE }
 
+#define GUEST_EXT_REGION_MIN_SIZE   xen_mk_ullong(0x0004000000) /* 64MB */
+
 /* Current supported guest VCPUs */
 #define GUEST_MAX_VCPUS 128
 
-- 
2.7.4



From xen-devel-bounces@lists.xenproject.org Mon Oct 11 18:06:16 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 18:06:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.206447.362016 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZzgg-0005XR-Ii; Mon, 11 Oct 2021 18:06:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 206447.362016; Mon, 11 Oct 2021 18:06:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZzgg-0005XK-Fq; Mon, 11 Oct 2021 18:06:10 +0000
Received: by outflank-mailman (input) for mailman id 206447;
 Mon, 11 Oct 2021 18:06:09 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=BpBC=O7=citrix.com=Andrew.Cooper3@srs-us1.protection.inumbo.net>)
 id 1mZzgf-0005XE-Eb
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 18:06:09 +0000
Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id e7c6baca-2abd-11ec-80ee-12813bfff9fa;
 Mon, 11 Oct 2021 18:06:07 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e7c6baca-2abd-11ec-80ee-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1633975567;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=lvswEG2MEMgg4mNzsuL0uRhvX1GUmpngDXemfCWI2+Y=;
  b=VAU48sNwEkxHhr543ia97cAAmOCuDR7Yj7rgRo5OieUtG3uguMKfCQun
   cw3yyXYIcA3XxvjUr4xFy5DReAsN76cohy2Og1axmLRGWFkhfu5lJy38V
   Zk4Fa1uQ9t89pTSW4xN7ADTA+cGgobx6ZiyI09FzWJzD3DQcpFtBS9VVi
   c=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: +E1KJLph8b3VPchHHtSA9U6zbm7shbOvPErQRtkWV2DS+DOgb6+K9Sxns+wAMqSJf+mKS7UR1T
 8WW2PNErKAHgXrqCd1XEyD0xl3iaWS32BAjds4MazBUwl1zwGQjkuR4zO7JbqYN0KG2r8suypv
 O21HwnNpOWxc8yMhyjHOCF4GOAZ0k1JCQFQdjac5UYRahSKca5oHzPy2Al+60WjG2vQ3VAEydZ
 +7V2U6Fze/gwyRt15xBIGLzNKaIBvdtzQKStOrtdrbH1uic7vwvFAGpaBqH6oV4mgZHiirZ+33
 iobJSDFmabgIxPXtbS8w14/t
X-SBRS: 5.1
X-MesageID: 54940701
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:aUht/6x8L+5ruiKBG4d6t+f+wSrEfRIJ4+MujC+fZmUNrF6WrkUAx
 jBOWTqAbK2JYmDwLYh/OomwpBsGsZDXzodjTQE5pCAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx
 59DAjUVBJlsFhcwnvopW1TYhSEUOZugH9IQM8aZfHAsLeNYYH1500s6w7dg2tQAbeWRWGthh
 /uj+6UzB3f9s9JEGjp8B3Wr8U4HUFza4Vv0j3RmDRx5lAa2e0o9VfrzEZqZPXrgKrS4K8bhL
 wr1IBNVyUuCl/slIovNfr8W6STmSJaKVeSFoiI+t6RPHnGuD8H9u0o2HKN0VKtZt9mGt9po4
 9RosoSNdR9zZIjCpORGXURbGhgraMWq+JefSZS+mcmazkmAeHrw2fR+SkoxOOX0+M4uXzsIr
 6ZBbmlQMFbT3Ipaw5riIgVoru0lINPmI8U0vXZ4wCuCJf0nXYrCU+PB4towMDIY25wfQa6BP
 5NxhTxHQi7dbhBxIQ0rFLkcreyxvWKuUBlqkQfAzUYwyzeKl1EguFT3C/LKfvSaSMMTmVyXz
 krk1WnkBhARNPSE1CGItHmrg4fnjS79HY4fCrC83vprm0GIgHweDgUMUlm2quX/jVSxM++zM
 GRNpHBo9/JrshX2EJ+tBHVUvUJooDYWQvFRNuoi1T2VkPDx7TqZXWZZTTd4PYlOWNANeRQm0
 VqAntXMDDNpsaGIRX/1yop4vQ9eKgBOcjdcPX5soR8tpoC5+tlq302nosNLSfbt1rXI9SfML
 ydmRcTUr44YitIXzO2F9FTDjiPESnPhH1NtuFu/so5I6GpEiG+Zi26AtQizARVodt/xory9U
 J4swZX2AAcmV8DlqcB1aL9RdIxFHt7cWNEmvXZhHoM66xOm8GO5cIZb7VlWfRkyaZZVIWCwO
 RON4mu9AaO/2lPxN8ebhKrrWqwXIVXIT4y5Bpg4kPIfCnSOSON31H43PhPBt4wcuEMtjbs+K
 f+mnTWEVh4n5VBc5GPuHY81iOZzrghnnD+7bc2rnnyPjOvFDFbIGOhtDbd7Rr1ghE9yiF6Oq
 Ig32grj40g3bdASlQGOqdRNcgtQcSRibX00wuQOHtO+zsNdMDlJI5fsLXkJIeSJRoxZybXF+
 G+TQEhdxAatjHHLM1zSOHtidKnuTdB0qndiZX4gOlOh2n4CZ4ez7fhAK8trLOd/rOEzn+RpS
 /QletmbBqgdQDrw5DlAP4L2q5ZvdUr3iFvWbTalejU2Y7VpWxfNpo3/ZgLq+SRXVni3uMIyr
 qeOzATeRZZfFQ1uANyPMKCkzk+rvGhbk+V3BhOaLt5WcUTq0Y5rNy2u0aNnf5BScU3On2LI2
 RyXDBEUofj2j7U0qNSZ17qZq4qJEvdlGhYIFWfs8rvrZzLR+XCuwNEcXb/QLyzdTm795I6re
 f5Rk6PnKPQCkVtH79h8HrJswf5s7tfjveYHnAFtHXGNZFW3ELJwZHKB2JAX5KFKw7ZYvyqwW
 16OpYYGaenYZpu9HQ5DPhchY8SCyeoQy2vb4vkCKUnn4DN6oeicWkJIMhjQ0CFQIdOZ6m/+L
 TvNbCLO1zGCtw==
IronPort-HdrOrdr: A9a23:TAX/260N9vacc/Xzfbq5SAqjBLYkLtp133Aq2lEZdPUzSL3+qy
 nOpoV+6faQsl0ssR4b9exoVJPufZq+z/5ICOsqU4tKNTOO0AHEEGgI1+rf6gylNyri9vNMkY
 dMGpIObeEY1GIK7voSNjPIceod/A==
X-IronPort-AV: E=Sophos;i="5.85,365,1624334400"; 
   d="scan'208";a="54940701"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Jan Beulich
	<JBeulich@suse.com>, =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?=
	<roger.pau@citrix.com>, Wei Liu <wl@xen.org>
Subject: [PATCH] x86/pv: Split pv_hypercall() in two
Date: Mon, 11 Oct 2021 19:05:41 +0100
Message-ID: <20211011180541.24501-2-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20211011180541.24501-1-andrew.cooper3@citrix.com>
References: <20211011180541.24501-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

The is_pv_32bit_vcpu() conditionals hide four lfences, with two taken on any
individual path through the function.  There is very little code common
between compat and native, and context-dependent conditionals predict very
badly for a period of time after context switch.

Move do_entry_int82() from pv/traps.c into pv/hypercall.c, allowing
_pv_hypercall() to be static and forced inline.  The delta is:

  add/remove: 0/0 grow/shrink: 1/1 up/down: 300/-282 (18)
  Function                                     old     new   delta
  do_entry_int82                                50     350    +300
  pv_hypercall                                 579     297    -282

which is tiny, but the perf implications are large:

  Guest | Naples | Milan  | SKX    | CFL-R  |
  ------+--------+--------+--------+--------+
  pv64  |  17.4% |  15.5% |   2.6% |   4.5% |
  pv32  |   1.9% |  10.9% |   1.4% |   2.5% |

These are percentage improvements in raw TSC detlas for a xen_version
hypercall, with obvious outliers excluded.  Therefore, it is an idealised best
case improvement.

The pv64 path uses `syscall`, while the pv32 path uses `int $0x82` so
necessarily has higher overhead.  Therefore, dropping the lfences is less over
an overall improvement.

I don't know why the Naples pv32 improvement is so small, but I've double
checked the numbers and they're correct.  There's something we're doing which
is a large overhead in the pipeline.

On the Intel side, both systems are writing to MSR_SPEC_CTRL on
entry/exit (SKX using the retrofitted microcode implementation, CFL-R using
the hardware implementation), while SKX is suffering further from XPTI for
Meltdown protection.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Roger Pau Monné <roger.pau@citrix.com>
CC: Wei Liu <wl@xen.org>
---
 xen/arch/x86/pv/hypercall.c | 24 +++++++++++++++++++-----
 xen/arch/x86/pv/traps.c     | 11 -----------
 2 files changed, 19 insertions(+), 16 deletions(-)

diff --git a/xen/arch/x86/pv/hypercall.c b/xen/arch/x86/pv/hypercall.c
index 9765e674cf60..3579ba905c1c 100644
--- a/xen/arch/x86/pv/hypercall.c
+++ b/xen/arch/x86/pv/hypercall.c
@@ -23,6 +23,7 @@
 #include <xen/hypercall.h>
 #include <xen/nospec.h>
 #include <xen/trace.h>
+#include <asm/apic.h>
 #include <asm/multicall.h>
 #include <irq_vectors.h>
 
@@ -109,15 +110,15 @@ const pv_hypercall_table_t pv_hypercall_table[] = {
 #undef COMPAT_CALL
 #undef HYPERCALL
 
-void pv_hypercall(struct cpu_user_regs *regs)
+/* Forced inline to cause 'compat' to be evaluated at compile time. */
+static void always_inline
+_pv_hypercall(struct cpu_user_regs *regs, bool compat)
 {
     struct vcpu *curr = current;
-    unsigned long eax;
+    unsigned long eax = compat ? regs->eax : regs->rax;
 
     ASSERT(guest_kernel_mode(curr, regs));
 
-    eax = is_pv_32bit_vcpu(curr) ? regs->eax : regs->rax;
-
     BUILD_BUG_ON(ARRAY_SIZE(pv_hypercall_table) >
                  ARRAY_SIZE(hypercall_args_table));
 
@@ -137,7 +138,7 @@ void pv_hypercall(struct cpu_user_regs *regs)
 
     curr->hcall_preempted = false;
 
-    if ( !is_pv_32bit_vcpu(curr) )
+    if ( !compat )
     {
         unsigned long rdi = regs->rdi;
         unsigned long rsi = regs->rsi;
@@ -348,8 +349,21 @@ void pv_ring1_init_hypercall_page(void *p)
         *(u8  *)(p+ 7) = 0xc3;    /* ret */
     }
 }
+
+void do_entry_int82(struct cpu_user_regs *regs)
+{
+    if ( unlikely(untrusted_msi) )
+        check_for_unexpected_msi((uint8_t)regs->entry_vector);
+
+    _pv_hypercall(regs, true /* compat */);
+}
 #endif
 
+void pv_hypercall(struct cpu_user_regs *regs)
+{
+    _pv_hypercall(regs, false /* native */);
+}
+
 /*
  * Local variables:
  * mode: C
diff --git a/xen/arch/x86/pv/traps.c b/xen/arch/x86/pv/traps.c
index 764773c02104..1e05a9f1cdad 100644
--- a/xen/arch/x86/pv/traps.c
+++ b/xen/arch/x86/pv/traps.c
@@ -24,22 +24,11 @@
 #include <xen/lib.h>
 #include <xen/softirq.h>
 
-#include <asm/apic.h>
 #include <asm/pv/trace.h>
 #include <asm/shared.h>
 #include <asm/traps.h>
 #include <irq_vectors.h>
 
-#ifdef CONFIG_PV32
-void do_entry_int82(struct cpu_user_regs *regs)
-{
-    if ( unlikely(untrusted_msi) )
-        check_for_unexpected_msi((uint8_t)regs->entry_vector);
-
-    pv_hypercall(regs);
-}
-#endif
-
 void pv_inject_event(const struct x86_event *event)
 {
     struct vcpu *curr = current;
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Mon Oct 11 18:06:29 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 18:06:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.206450.362028 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZzgy-0005t6-Rn; Mon, 11 Oct 2021 18:06:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 206450.362028; Mon, 11 Oct 2021 18:06:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZzgy-0005sz-OP; Mon, 11 Oct 2021 18:06:28 +0000
Received: by outflank-mailman (input) for mailman id 206450;
 Mon, 11 Oct 2021 18:06:27 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=BpBC=O7=citrix.com=Andrew.Cooper3@srs-us1.protection.inumbo.net>)
 id 1mZzgx-0005qd-Le
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 18:06:27 +0000
Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id f35f8330-2abd-11ec-80ee-12813bfff9fa;
 Mon, 11 Oct 2021 18:06:26 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f35f8330-2abd-11ec-80ee-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1633975586;
  h=from:to:cc:subject:date:message-id:mime-version;
  bh=6l4sucSPMUqJsOfp/047IHE/7+bYZodn28EqnpvUcYo=;
  b=PnSN8GrCF//ZXQW8AHFYrI6FTdT6VFBhLRXzG4FxZB8YtlSfgpYGmLxk
   hPAt1Ve8rYf0Hh4US3CHFe4zLPnNQ+UMUM9WbDBUdYfIyQgqNo3K7Wts2
   0iuoJ5L7NapDHJO4L72Z5spFsrqtDMIGgA8b3mOKbrsr4w9liKpmWR3LS
   Y=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: +ogEBk8GCsDXjYLs6PWZGIh+8G2yISCEm2dHnVn3ySIQ3uXhEAGv+JiEPyzXv924mf3EnoyQ8q
 Ero9A1bbJM/yhs9Ab5ffKj92Snmn3v+bEU38k2cJubItZo29cj6f0R2b2Ot8p0mKKrAn1dBGj6
 +X3WEz0QRsqxKs5dWTUAvwHdGR8SfZk4Etx5QX6ot83fRYs0DDTQ2oLAHUvvnadtracV3g0BhK
 3yBwqv4N5d/7B9ozw50h3WHRoXGUwqDRInOGrpemf+9qkLWQslxin6ug6GplNwLRpvYxZgCr03
 5Z2Qu7OVSZUkb11BKRPN9O/Z
X-SBRS: 5.1
X-MesageID: 55311564
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:v4/QG6Na1L5tGBzvrR2NkMFynXyQoLVcMsEvi/4bfWQNrUpz3z0Fn
 DEdCz3SOPvfMzTwLdgkYIjioB9QvsLUnIAyQAto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdpJYz/uUGuCJQUNUjMlkfZKhTr6ZUsxNbVU8En540Us6w7RRbrNA2rBVPSvc4
 bsenOWHULOV82Yc3rU8sv/rRLtH5ZweiRtA1rAMTakjUGz2zhH5OKk3N6CpR0YUd6EPdgKMq
 0Qv+5nilo/R109F5tpICd8XeGVSKlLZFVDmZna7x8FOK/WNz8A/+v9TCRYSVatYozmmkd8sk
 PR1iYW5ZCE1JI7np84seCANRkmSPYUekFPGCX22sMjVxEzaaXr8hf5pCSnaP6VBpLwxWzsXs
 6VFdnZdNXhvhMrvqF6/YsBqit4uM4/AO4QHt2s75TrYEewnUdbIRKCiCdpwgWpr35kTQ6q2i
 8wxMyZRLxvkWkRzKg1KUMsUxOWqv3jlbGgNwL6SjfVuuDWCpOBr65D9PdyQdtGUSMF9mkeDu
 nmA72n/GgsdNtGU1XyC6H3EuwPUtXqlAsRITuT+r6M0xg3IroAONPEIfVeUr/bk0m+GZ8tWB
 moI4AkFkoID33X+G7ERQCaEiHKDuxcdXf9ZHOs79ByBx8Lo3uqJOoQXZmUeMIJ+5afaURRvj
 wXTx4q4WlSDpZXMESrFnop4uw9eLsT8wYUqXiQDURceq+fqpIU+n3ojpf4yTfbr0LUZ9dz2q
 g1mTRTSZZ1P3abnNI3hpDgrZg5AQLCTE2bZAS2NDwqYAvtRPtLNWmBRwQGzAQx8BIiYVEKdm
 3MPhtKT6usDZbnUynfWELRVQ+jwu6jeWNE5vbKJN8J7n9hK0yTyFb28HRkkfBs5Wir6UW6Bj
 LDvVfN5u8YIYSrCgV5faIOtEcU6pZUM5vy+Ps04muFmO8ArHCfepXkGTRfJgwjFzRh9+Ylia
 MzzWZv9Uh4n5VFPkWPeqxE1iuRwmEjTBAr7GPjG8vhQ+ePGPiDKEu1ZbALmgyJQxPrsnTg5O
 u13b6OioyizmsWkCsUO2YJMf10MM1YhApX6955eeuKZe1I0E2A9Ef7Bh7gmftU9zahSk+7J+
 FC7W1NZlwWj1SGWd13SZyAxcq7rULZ+sWk/YX4mM2G31iVxeo2o9qoeKcc6JOF16Ox5wPdoZ
 PAZYMHcUO9XQzHK9m1FP5nwpYBvbjqxggeKM3b3aTQzZcc4FQfI5sXlbk3k8yxXVni7ss43o
 ruB0ALHQMVcG1Q+XZiOMP/2lgG/p3kQnu52TnDkGNgLdRW+6pVuJgzwkuQzf5MGJyLcy2bIz
 A2RGxoZ+7XA+tdn7NnTiKmYhI61CO8iTFFCFmzW4LvqZynX+m2vnd1JXOqSJG2PUWr1/OOpZ
 PlPzuG6O/oCxQ4Yv415Grdt7KQ/+9qw+OMKklU6RC3GPwaxF7dtAniaxs0e5KRCy4hQtRayR
 k/SqMJRPq+EOZ+9HVMcTOb/gj9vCR3AduHu0MkI
IronPort-HdrOrdr: A9a23:EToQC6EGnTFVO4TCpLqE7MeALOsnbusQ8zAXPidKOHtom62j5q
 STdZEgviMc5wx8ZJhNo7+90cq7IU80l6Qa3WB5B97LNmTbUQCTTb1K3M/PxCDhBj271sM179
 YET0GmMqySMbGtt7eZ3DWF
X-IronPort-AV: E=Sophos;i="5.85,365,1624334400"; 
   d="scan'208";a="55311564"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: [PATCH 0/1] x86/pv: Split pv_hypercall() in two
Date: Mon, 11 Oct 2021 19:05:40 +0100
Message-ID: <20211011180541.24501-1-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
MIME-Version: 1.0
Content-Type: text/plain

Full perf anlaysis.  Time is raw TSC cycles for a xen_version() hypercall,
compared across the change in patch 1, with obvious obvious outliers excluded.
i.e. Idealised best case improvement.

Some general notes.  pv64 is `syscall`, while pv32 is `int $0x82` and
therefore has more overhead to begin with.  Consequently, dropping two lfences
is less of an overall change in the path.

First, AMD Milan (Zen3):

  $ ministat -A milan-hcall-pv64-{before,after}
  x milan-hcall-pv64-before
  + milan-hcall-pv64-after
      N           Min           Max        Median           Avg        Stddev
  x  98           420           460           440     438.97959     6.6564899
  +  98           360           440           380     370.81633      12.57337
  Difference at 95.0% confidence
          -68.1633 +/- 2.81674
          -15.5277% +/- 0.641656%
          (Student's t, pooled s = 10.0598)

  $ ministat -A milan-hcall-pv32-{before,after}
  x milan-hcall-pv32-before
  + milan-hcall-pv32-after
      N           Min           Max        Median           Avg        Stddev
  x  98          1900          2100          1980     1984.2857     22.291416
  +  96          1740          1960          1760        1767.5     35.688713
  Difference at 95.0% confidence
          -216.786 +/- 8.35522
          -10.9251% +/- 0.421069%
          (Student's t, pooled s = 29.6859)

Second, AMD Naples (Zen1):

  $ ministat -A naples-hcall-pv64-{before,after}
  x naples-hcall-pv64-before
  + naples-hcall-pv64-after
      N           Min           Max        Median           Avg        Stddev
  x  97           294           336           315     311.75258     10.207259
  +  97           252           273           252     257.41237     9.2328135
  Difference at 95.0% confidence
          -54.3402 +/- 2.73904
          -17.4306% +/- 0.878593%
          (Student's t, pooled s = 9.73224)

  $ ministat -A naples-hcall-pv32-{before,after}
  x naples-hcall-pv32-before
  + naples-hcall-pv32-after
      N           Min           Max        Median           Avg        Stddev
  x  98          1260          1470          1260     1276.2857     42.913483
  +  95          1218          1470          1239     1250.9368     52.491298
  Difference at 95.0% confidence
          -25.3489 +/- 13.5082
          -1.98614% +/- 1.0584%
          (Student's t, pooled s = 47.8673)

Third, Intel Coffeelake-R:

  $ ministat -A cflr-hcall-pv64-{before,after}
  x cflr-hcall-pv64-before
  + cflr-hcall-pv64-after
      N           Min           Max        Median           Avg        Stddev
  x 100           774          1024           792        825.04     73.608563
  +  95           734           966           756     787.74737     70.580114
  Difference at 95.0% confidence
          -37.2926 +/- 20.2602
          -4.5201% +/- 2.45567%
          (Student's t, pooled s = 72.1494)

  $ ministat -A cflr-hcall-pv32-{before,after}
  x cflr-hcall-pv32-before
  + cflr-hcall-pv32-after
      N           Min           Max        Median           Avg        Stddev
  x 100          2176          3816          2198       2288.84     196.18218
  +  99          2180          2434          2198     2232.4646     75.867677
  Difference at 95.0% confidence
          -56.3754 +/- 41.4084
          -2.46305% +/- 1.80914%
          (Student's t, pooled s = 149.013)

Fourth, Intel Skylake Server:

  $ ministat -A skx-hcall-pv64-{before,after}
  x skx-hcall-pv64-before
  + skx-hcall-pv64-after
      N           Min           Max        Median           Avg        Stddev
  x  99          5642          5720          5686      5686.303     17.909896
  +  98          5520          5544          5540     5536.0816       8.20821
  Difference at 95.0% confidence
          -150.221 +/- 3.89729
          -2.64181% +/- 0.0685382%
          (Student's t, pooled s = 13.9542)

  $ ministat -A skx-hcall-pv32-{before,after}
  x skx-hcall-pv32-before
  + skx-hcall-pv32-after
      N           Min           Max        Median           Avg        Stddev
  x  99          9296          9500          9308     9309.3131     20.418402
  +  96          9110          9266          9180     9175.2292     27.860358
  Difference at 95.0% confidence
          -134.084 +/- 6.84111
          -1.44032% +/- 0.0734868%
          (Student's t, pooled s = 24.3673)


I'm honestly not sure why Naples PV32's improvement is so small, but I've
double checked the numbers.  Clearly there's something on the `int $0x82` path
which is radically higher overhead on Naples vs Milan.

For the Intel numbers, both setups are writing to MSR_SPEC_CTRL on entry/exit,
but for Skylake it is the microcode implementation whereas for CLF-R, it is
the hardware implemenation.  Skylake has XPTI adding further overhead to the
paths.

Andrew Cooper (1):
  x86/pv: Split pv_hypercall() in two

 xen/arch/x86/pv/hypercall.c | 24 +++++++++++++++++++-----
 xen/arch/x86/pv/traps.c     | 11 -----------
 2 files changed, 19 insertions(+), 16 deletions(-)

-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Mon Oct 11 18:07:24 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 18:07:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.206459.362039 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZzhs-0006fk-5D; Mon, 11 Oct 2021 18:07:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 206459.362039; Mon, 11 Oct 2021 18:07:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZzhs-0006fb-1d; Mon, 11 Oct 2021 18:07:24 +0000
Received: by outflank-mailman (input) for mailman id 206459;
 Mon, 11 Oct 2021 18:07:22 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mZzhq-0006fN-G0; Mon, 11 Oct 2021 18:07:22 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mZzhq-00038K-Br; Mon, 11 Oct 2021 18:07:22 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mZzhq-0003Hr-3n; Mon, 11 Oct 2021 18:07:22 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mZzhq-0001dv-3H; Mon, 11 Oct 2021 18:07:22 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=mCLocdHK7MK66A7pI7HbXuEWZBprJudM2W9doREv9ks=; b=ueiih2k4J+tKaY1hdp10/0OwWB
	6koxaEwrGH4WQLNfOe8T+nZU7fJqHTOlBdWQaCvfLQ7i7fWVdq1h6ClE22Q1HjtHtKh94YCc7tnye
	M1RbyV0T+RlS4sC8GCpen8KL6bb3xFW7X86FVffHkPlh8rhVqBnuYjV3FZ2TJ3rXx+OY=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165466-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 165466: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=e8b42a4e8810844ccffd2eab072921b1e4e2ed79
X-Osstest-Versions-That:
    xen=2fac4e3ea3bb301f87426e24b9dfd765c22c9cf9
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 11 Oct 2021 18:07:22 +0000

flight 165466 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165466/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  e8b42a4e8810844ccffd2eab072921b1e4e2ed79
baseline version:
 xen                  2fac4e3ea3bb301f87426e24b9dfd765c22c9cf9

Last test of basis   165465  2021-10-11 10:02:56 Z    0 days
Testing same since   165466  2021-10-11 15:02:49 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Roger Pau Monne <roger.pau@citrix.com>
  Roger Pau Monné <roger.pau@citrix.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   2fac4e3ea3..e8b42a4e88  e8b42a4e8810844ccffd2eab072921b1e4e2ed79 -> smoke


From xen-devel-bounces@lists.xenproject.org Mon Oct 11 18:15:49 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 18:15:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.206470.362074 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZzpy-0000KG-Mb; Mon, 11 Oct 2021 18:15:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 206470.362074; Mon, 11 Oct 2021 18:15:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZzpy-0000K7-Ir; Mon, 11 Oct 2021 18:15:46 +0000
Received: by outflank-mailman (input) for mailman id 206470;
 Mon, 11 Oct 2021 18:15:45 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=RBe3=O7=arm.com=luca.fancellu@srs-us1.protection.inumbo.net>)
 id 1mZzpx-0008BJ-6T
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 18:15:45 +0000
Received: from foss.arm.com (unknown [217.140.110.172])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTP
 id d15caa8b-c145-4134-a9bd-5f2ca6af6c10;
 Mon, 11 Oct 2021 18:15:40 +0000 (UTC)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C2CC81063;
 Mon, 11 Oct 2021 11:15:39 -0700 (PDT)
Received: from e125770.cambridge.arm.com (e125770.cambridge.arm.com
 [10.1.195.16])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 230713F66F;
 Mon, 11 Oct 2021 11:15:38 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d15caa8b-c145-4134-a9bd-5f2ca6af6c10
From: Luca Fancellu <luca.fancellu@arm.com>
To: xen-devel@lists.xenproject.org
Cc: bertrand.marquis@arm.com,
	wei.chen@arm.com,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Ian Jackson <iwj@xenproject.org>,
	Jan Beulich <jbeulich@suse.com>,
	Wei Liu <wl@xen.org>
Subject: [PATCH v6 1/2] arm/efi: Use dom0less configuration when using EFI boot
Date: Mon, 11 Oct 2021 19:15:27 +0100
Message-Id: <20211011181528.17367-2-luca.fancellu@arm.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20211011181528.17367-1-luca.fancellu@arm.com>
References: <20211011181528.17367-1-luca.fancellu@arm.com>

This patch introduces the support for dom0less configuration
when using UEFI boot on ARM, it permits the EFI boot to
continue if no dom0 kernel is specified but at least one domU
is found.

Introduce the new property "xen,uefi-binary" for device tree boot
module nodes that are subnode of "xen,domain" compatible nodes.
The property holds a string containing the file name of the
binary that shall be loaded by the uefi loader from the filesystem.

Introduce a new call efi_check_dt_boot(...) called during EFI boot
that checks for module to be loaded using device tree.
Architectures that don't support device tree don't have to
provide this function.

Update efi documentation about how to start a dom0less
setup using UEFI

Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>
---
Changes in v6:
- change is_boot_module() to check for every multiboot,module
instead of multiboot,{kernel,ramdisk,device-tree} (Julien), as
a result of that remove the function and put the check inside of
handle_module_node(...)
Changes in v5:
- Removed unneeded variable initialization
- Fixed comment
- Fixed error message for the absence of an initial domain kernel
- changed efi_arch_check_dt_boot to efi_check_dt_boot and add
a stub if CONFIG_HAS_DEVICE_TREE is not declared, updated commit
message about the call introduction in the EFI boot flow.
Changes in v4:
- update uefi,cfg-load to xen,uefi-cfg-load in documentation
- fixed comments and code style
- changed variable name from dt_module_found to dt_modules_found
in boot.c
- removed stub efi_arch_check_dt_boot from x86 code because the
architecture does not support DT, protected call with #ifdef
in the common code.
- add comment to explain the result from efi_arch_check_dt_boot
just looking the common code
- Add space before comment in boot.c
- renamed uefi,binary property to xen,uefi-binary
Changes in v3:
- fixed documentation
- fixed name len in strlcpy
- fixed some style issues
- closed filesystem handle before calling blexit
- passed runtime errors up to the stack instead
of calling blexit
- renamed names and function to make them more
general in prevision to load also Dom0 kernel
and ramdisk from DT
Changes in v2:
- remove array of struct file
- fixed some int types
- Made the code use filesystem even when configuration
file is skipped.
- add documentation of uefi,binary in booting.txt
- add documentation on how to boot all configuration
for Xen using UEFI in efi.pandoc
---
 docs/misc/arm/device-tree/booting.txt |  21 ++
 docs/misc/efi.pandoc                  | 203 +++++++++++++++++
 xen/arch/arm/efi/efi-boot.h           | 299 +++++++++++++++++++++++++-
 xen/common/efi/boot.c                 |  39 +++-
 4 files changed, 550 insertions(+), 12 deletions(-)

diff --git a/docs/misc/arm/device-tree/booting.txt b/docs/misc/arm/device-tree/booting.txt
index 352b0ec43a..7258e7e1ec 100644
--- a/docs/misc/arm/device-tree/booting.txt
+++ b/docs/misc/arm/device-tree/booting.txt
@@ -190,6 +190,13 @@ The kernel sub-node has the following properties:
 
     Command line parameters for the guest kernel.
 
+- xen,uefi-binary (UEFI boot only)
+
+    String property that specifies the file name to be loaded by the UEFI boot
+    for this module. If this is specified, there is no need to specify the reg
+    property because it will be created by the UEFI stub on boot.
+    This option is needed only when UEFI boot is used.
+
 The ramdisk sub-node has the following properties:
 
 - compatible
@@ -201,6 +208,13 @@ The ramdisk sub-node has the following properties:
     Specifies the physical address of the ramdisk in RAM and its
     length.
 
+- xen,uefi-binary (UEFI boot only)
+
+    String property that specifies the file name to be loaded by the UEFI boot
+    for this module. If this is specified, there is no need to specify the reg
+    property because it will be created by the UEFI stub on boot.
+    This option is needed only when UEFI boot is used.
+
 
 Example
 =======
@@ -265,6 +279,13 @@ The dtb sub-node should have the following properties:
     Specifies the physical address of the device tree binary fragment
     RAM and its length.
 
+- xen,uefi-binary (UEFI boot only)
+
+    String property that specifies the file name to be loaded by the UEFI boot
+    for this module. If this is specified, there is no need to specify the reg
+    property because it will be created by the UEFI stub on boot.
+    This option is needed only when UEFI boot is used.
+
 As an example:
 
         module@0xc000000 {
diff --git a/docs/misc/efi.pandoc b/docs/misc/efi.pandoc
index ed85351541..876cd55005 100644
--- a/docs/misc/efi.pandoc
+++ b/docs/misc/efi.pandoc
@@ -167,3 +167,206 @@ sbsign \
 	--output xen.signed.efi \
 	xen.unified.efi
 ```
+
+## UEFI boot and dom0less on ARM
+
+Dom0less feature is supported by ARM and it is possible to use it when Xen is
+started as an EFI application.
+The way to specify the domU domains is by Device Tree as specified in the
+[dom0less](dom0less.html) documentation page under the "Device Tree
+configuration" section, but instead of declaring the reg property in the boot
+module, the user must specify the "xen,uefi-binary" property containing the name
+of the binary file that has to be loaded in memory.
+The UEFI stub will load the binary in memory and it will add the reg property
+accordingly.
+
+An example here:
+
+domU1 {
+	#address-cells = <1>;
+	#size-cells = <1>;
+	compatible = "xen,domain";
+	memory = <0 0x20000>;
+	cpus = <1>;
+	vpl011;
+
+	module@1 {
+		compatible = "multiboot,kernel", "multiboot,module";
+		xen,uefi-binary = "vmlinuz-3.0.31-0.4-xen";
+		bootargs = "console=ttyAMA0";
+	};
+	module@2 {
+		compatible = "multiboot,ramdisk", "multiboot,module";
+		xen,uefi-binary = "initrd-3.0.31-0.4-xen";
+	};
+	module@3 {
+		compatible = "multiboot,ramdisk", "multiboot,module";
+		xen,uefi-binary = "passthrough.dtb";
+	};
+};
+
+## How to boot different Xen setup using UEFI
+
+These are the different ways to boot a Xen system from UEFI:
+
+ - Boot Xen and Dom0 (minimum required)
+ - Boot Xen and DomU(s) (true dom0less, only on ARM)
+ - Boot Xen, Dom0 and DomU(s) (only on ARM)
+
+### Boot Xen and Dom0
+
+This configuration can be started using the Xen configuration file in the
+example above.
+
+### Boot Xen and DomU(s)
+
+This configuration needs the domU domain(s) specified in the /chosen node,
+examples of how to do that are provided by the documentation about dom0less
+and the example above shows how to use the "xen,uefi-binary" property to use the
+UEFI stub for module loading.
+When adding DomU modules to device tree, also add the property
+xen,uefi-cfg-load under chosen for Xen to load the Xen config file.
+Otherwise, Xen will skip the config file and rely on device tree alone.
+
+Example 1 of how to boot a true dom0less configuration:
+
+Xen configuration file: skipped.
+
+Device tree:
+
+```
+chosen {
+	#size-cells = <0x1>;
+	#address-cells = <0x1>;
+	xen,xen-bootargs = "<Xen command line>"
+
+	domU1 {
+		#size-cells = <0x1>;
+		#address-cells = <0x1>;
+		compatible = "xen,domain";
+		cpus = <0x1>;
+		memory = <0x0 0xc0000>;
+		vpl011;
+
+		module@1 {
+			compatible = "multiboot,kernel", "multiboot,module";
+			xen,uefi-binary = "Image-domu1.bin";
+			bootargs = "console=ttyAMA0 root=/dev/ram0 rw";
+		};
+	};
+	domU2 {
+		#size-cells = <0x1>;
+		#address-cells = <0x1>;
+		compatible = "xen,domain";
+		cpus = <0x1>;
+		memory = <0x0 0x100000>;
+		vpl011;
+
+		module@2 {
+			compatible = "multiboot,kernel", "multiboot,module";
+			xen,uefi-binary = "Image-domu2.bin";
+			bootargs = "console=ttyAMA0 root=/dev/ram0 rw";
+		};
+	};
+};
+```
+
+Example 2 of how to boot a true dom0less configuration:
+
+Xen configuration file:
+
+```
+[global]
+default=xen
+
+[xen]
+options=<Xen command line>
+dtb=<optional DTB>
+```
+
+Device tree:
+
+```
+chosen {
+	#size-cells = <0x1>;
+	#address-cells = <0x1>;
+	xen,uefi-cfg-load;
+
+	domU1 {
+		#size-cells = <0x1>;
+		#address-cells = <0x1>;
+		compatible = "xen,domain";
+		cpus = <0x1>;
+		memory = <0x0 0xc0000>;
+		vpl011;
+
+		module@1 {
+			compatible = "multiboot,kernel", "multiboot,module";
+			xen,uefi-binary = "Image-domu1.bin";
+			bootargs = "console=ttyAMA0 root=/dev/ram0 rw";
+		};
+	};
+	domU2 {
+		#size-cells = <0x1>;
+		#address-cells = <0x1>;
+		compatible = "xen,domain";
+		cpus = <0x1>;
+		memory = <0x0 0x100000>;
+		vpl011;
+
+		module@2 {
+			compatible = "multiboot,kernel", "multiboot,module";
+			xen,uefi-binary = "Image-domu2.bin";
+			bootargs = "console=ttyAMA0 root=/dev/ram0 rw";
+		};
+	};
+};
+```
+
+### Boot Xen, Dom0 and DomU(s)
+
+This configuration is a mix of the two configuration above, to boot this one
+the configuration file must be processed so the /chosen node must have the
+"xen,uefi-cfg-load" property.
+
+Here an example:
+
+Xen configuration file:
+
+```
+[global]
+default=xen
+
+[xen]
+options=<Xen command line>
+kernel=vmlinuz-3.0.31-0.4-xen [domain 0 command line options]
+ramdisk=initrd-3.0.31-0.4-xen
+dtb=<optional DTB>
+```
+
+Device tree:
+
+```
+chosen {
+	#size-cells = <0x1>;
+	#address-cells = <0x1>;
+	xen,uefi-cfg-load;
+
+	domU1 {
+		#size-cells = <0x1>;
+		#address-cells = <0x1>;
+		compatible = "xen,domain";
+		cpus = <0x1>;
+		memory = <0x0 0xc0000>;
+		vpl011;
+
+		module@1 {
+			compatible = "multiboot,kernel", "multiboot,module";
+			xen,uefi-binary = "Image-domu1.bin";
+			bootargs = "console=ttyAMA0 root=/dev/ram0 rw";
+		};
+	};
+};
+```
+
+
diff --git a/xen/arch/arm/efi/efi-boot.h b/xen/arch/arm/efi/efi-boot.h
index a3e46453d4..f35e035b22 100644
--- a/xen/arch/arm/efi/efi-boot.h
+++ b/xen/arch/arm/efi/efi-boot.h
@@ -8,9 +8,49 @@
 #include <asm/setup.h>
 #include <asm/smp.h>
 
+typedef struct {
+    char *name;
+    unsigned int name_len;
+    EFI_PHYSICAL_ADDRESS addr;
+    UINTN size;
+} module_name;
+
+/*
+ * Binaries will be translated into bootmodules, the maximum number for them is
+ * MAX_MODULES where we should remove a unit for Xen and one for Xen DTB
+ */
+#define MAX_UEFI_MODULES (MAX_MODULES - 2)
+static struct file __initdata module_binary;
+static module_name __initdata modules[MAX_UEFI_MODULES];
+static unsigned int __initdata modules_available = MAX_UEFI_MODULES;
+static unsigned int __initdata modules_idx;
+
+#define ERROR_BINARY_FILE_NOT_FOUND (-1)
+#define ERROR_ALLOC_MODULE_NO_SPACE (-1)
+#define ERROR_ALLOC_MODULE_NAME     (-2)
+#define ERROR_MISSING_DT_PROPERTY   (-3)
+#define ERROR_RENAME_MODULE_NAME    (-4)
+#define ERROR_SET_REG_PROPERTY      (-5)
+#define ERROR_CHECK_MODULE_COMPAT   (-6)
+#define ERROR_DT_MODULE_DOMU        (-1)
+#define ERROR_DT_CHOSEN_NODE        (-2)
+
 void noreturn efi_xen_start(void *fdt_ptr, uint32_t fdt_size);
 void __flush_dcache_area(const void *vaddr, unsigned long size);
 
+static int get_module_file_index(const char *name, unsigned int name_len);
+static void PrintMessage(const CHAR16 *s);
+static int allocate_module_file(EFI_FILE_HANDLE dir_handle,
+                                const char *name,
+                                unsigned int name_len);
+static int handle_module_node(EFI_FILE_HANDLE dir_handle,
+                              int module_node_offset,
+                              int reg_addr_cells,
+                              int reg_size_cells);
+static int handle_dom0less_domain_node(EFI_FILE_HANDLE dir_handle,
+                                       int domain_node);
+static int efi_check_dt_boot(EFI_FILE_HANDLE dir_handle);
+
 #define DEVICE_TREE_GUID \
 {0xb1b621d5, 0xf19c, 0x41a5, {0x83, 0x0b, 0xd9, 0x15, 0x2c, 0x69, 0xaa, 0xe0}}
 
@@ -552,8 +592,254 @@ static void __init efi_arch_handle_module(const struct file *file,
                          kernel.size) < 0 )
             blexit(L"Unable to set reg property.");
     }
-    else
+    else if ( file != &module_binary )
+        /*
+         * If file is not a dom0 module file and it's not a domU module,
+         * stop here.
+         */
         blexit(L"Unknown module type");
+
+    /*
+     * modules_available is decremented here because for each dom0 file added
+     * from the configuration file, there will be an additional bootmodule,
+     * so the number of available slots will be decremented because there is a
+     * maximum amount of bootmodules that can be loaded.
+     */
+    modules_available--;
+}
+
+/*
+ * This function checks for a binary previously loaded with a give name, it
+ * returns the index of the file in the modules array or a negative number if no
+ * file with that name is found.
+ */
+static int __init get_module_file_index(const char *name,
+                                        unsigned int name_len)
+{
+    unsigned int i;
+    int ret = ERROR_BINARY_FILE_NOT_FOUND;
+
+    for ( i = 0; i < modules_idx; i++ )
+    {
+        module_name *mod = &modules[i];
+        if ( (mod->name_len == name_len) &&
+             (strncmp(mod->name, name, name_len) == 0) )
+        {
+            ret = i;
+            break;
+        }
+    }
+    return ret;
+}
+
+static void __init PrintMessage(const CHAR16 *s)
+{
+    PrintStr(s);
+    PrintStr(newline);
+}
+
+/*
+ * This function allocates a binary and keeps track of its name, it returns the
+ * index of the file in the modules array or a negative number on error.
+ */
+static int __init allocate_module_file(EFI_FILE_HANDLE dir_handle,
+                                       const char *name,
+                                       unsigned int name_len)
+{
+    module_name *file_name;
+    union string module_name;
+    int ret;
+
+    /*
+     * Check if there is any space left for a module, the variable
+     * modules_available is updated each time we use read_file(...)
+     * successfully.
+     */
+    if ( !modules_available )
+    {
+        PrintMessage(L"No space left for modules");
+        return ERROR_ALLOC_MODULE_NO_SPACE;
+    }
+
+    module_name.cs = name;
+    ret = modules_idx;
+
+    /* Save at this index the name of this binary */
+    file_name = &modules[ret];
+
+    if ( efi_bs->AllocatePool(EfiLoaderData, (name_len + 1) * sizeof(char),
+                              (void**)&file_name->name) != EFI_SUCCESS )
+    {
+        PrintMessage(L"Error allocating memory for module binary name");
+        return ERROR_ALLOC_MODULE_NAME;
+    }
+
+    /* Save name and length of the binary in the data structure */
+    strlcpy(file_name->name, name, name_len + 1);
+    file_name->name_len = name_len;
+
+    /* Load the binary in memory */
+    read_file(dir_handle, s2w(&module_name), &module_binary, NULL);
+
+    /* Save address and size */
+    file_name->addr = module_binary.addr;
+    file_name->size = module_binary.size;
+
+    /* s2w(...) allocates some memory, free it */
+    efi_bs->FreePool(module_name.w);
+
+    modules_idx++;
+
+    return ret;
+}
+
+/*
+ * This function checks for the presence of the xen,uefi-binary property in the
+ * module, if found it loads the binary as module and sets the right address
+ * for the reg property into the module DT node.
+ */
+static int __init handle_module_node(EFI_FILE_HANDLE dir_handle,
+                                     int module_node_offset,
+                                     int reg_addr_cells,
+                                     int reg_size_cells)
+{
+    const void *uefi_name_prop;
+    char mod_string[24]; /* Placeholder for module@ + a 64-bit number + \0 */
+    int uefi_name_len, file_idx, module_compat;
+    module_name *file;
+
+    /* Check if the node is a multiboot,module otherwise return */
+    module_compat = fdt_node_check_compatible(fdt, module_node_offset,
+                                              "multiboot,module");
+    if ( module_compat < 0 )
+        /* Error while checking the compatible string */
+        return ERROR_CHECK_MODULE_COMPAT;
+
+    if ( module_compat != 0 )
+        /* Module is not a multiboot,module */
+        return 0;
+
+    /* Read xen,uefi-binary property to get the file name. */
+    uefi_name_prop = fdt_getprop(fdt, module_node_offset, "xen,uefi-binary",
+                                 &uefi_name_len);
+
+    if ( !uefi_name_prop )
+        /* Property not found */
+        return 0;
+
+    file_idx = get_module_file_index(uefi_name_prop, uefi_name_len);
+    if ( file_idx < 0 )
+    {
+        file_idx = allocate_module_file(dir_handle, uefi_name_prop,
+                                        uefi_name_len);
+        if ( file_idx < 0 )
+            return file_idx;
+    }
+
+    file = &modules[file_idx];
+
+    snprintf(mod_string, sizeof(mod_string), "module@%"PRIx64, file->addr);
+
+    /* Rename the module to be module@{address} */
+    if ( fdt_set_name(fdt, module_node_offset, mod_string) < 0 )
+    {
+        PrintMessage(L"Unable to modify module node name.");
+        return ERROR_RENAME_MODULE_NAME;
+    }
+
+    if ( fdt_set_reg(fdt, module_node_offset, reg_addr_cells, reg_size_cells,
+                     file->addr, file->size) < 0 )
+    {
+        PrintMessage(L"Unable to set module reg property.");
+        return ERROR_SET_REG_PROPERTY;
+    }
+
+    return 0;
+}
+
+/*
+ * This function checks for boot modules under the domU guest domain node
+ * in the DT.
+ * Returns 0 on success, negative number on error.
+ */
+static int __init handle_dom0less_domain_node(EFI_FILE_HANDLE dir_handle,
+                                              int domain_node)
+{
+    int module_node, addr_cells, size_cells, len;
+    const struct fdt_property *prop;
+
+    /* Get #address-cells and #size-cells from domain node */
+    prop = fdt_get_property(fdt, domain_node, "#address-cells", &len);
+    if ( !prop )
+    {
+        PrintMessage(L"#address-cells not found in domain node.");
+        return ERROR_MISSING_DT_PROPERTY;
+    }
+
+    addr_cells = fdt32_to_cpu(*((uint32_t *)prop->data));
+
+    prop = fdt_get_property(fdt, domain_node, "#size-cells", &len);
+    if ( !prop )
+    {
+        PrintMessage(L"#size-cells not found in domain node.");
+        return ERROR_MISSING_DT_PROPERTY;
+    }
+
+    size_cells = fdt32_to_cpu(*((uint32_t *)prop->data));
+
+    /* Check for nodes compatible with multiboot,module inside this node */
+    for ( module_node = fdt_first_subnode(fdt, domain_node);
+          module_node > 0;
+          module_node = fdt_next_subnode(fdt, module_node) )
+    {
+        int ret = handle_module_node(dir_handle, module_node, addr_cells,
+                                        size_cells);
+        if ( ret < 0 )
+            return ret;
+    }
+
+    return 0;
+}
+
+/*
+ * This function checks for xen domain nodes under the /chosen node for possible
+ * domU guests to be loaded.
+ * Returns the number of modules loaded or a negative number for error.
+ */
+static int __init efi_check_dt_boot(EFI_FILE_HANDLE dir_handle)
+{
+    int chosen, node, addr_len, size_len;
+    unsigned int i = 0;
+
+    /* Check for the chosen node in the current DTB */
+    chosen = setup_chosen_node(fdt, &addr_len, &size_len);
+    if ( chosen < 0 )
+    {
+        PrintMessage(L"Unable to setup chosen node");
+        return ERROR_DT_CHOSEN_NODE;
+    }
+
+    /* Check for nodes compatible with xen,domain under the chosen node */
+    for ( node = fdt_first_subnode(fdt, chosen);
+          node > 0;
+          node = fdt_next_subnode(fdt, node) )
+    {
+        if ( !fdt_node_check_compatible(fdt, node, "xen,domain") )
+        {
+            /* Found a node with compatible xen,domain; handle this node. */
+            if ( handle_dom0less_domain_node(dir_handle, node) < 0 )
+                return ERROR_DT_MODULE_DOMU;
+        }
+    }
+
+    /* Free boot modules file names if any */
+    for ( ; i < modules_idx; i++ )
+    {
+        /* Free boot modules binary names */
+        efi_bs->FreePool(modules[i].name);
+    }
+
+    return modules_idx;
 }
 
 static void __init efi_arch_cpu(void)
@@ -562,8 +848,19 @@ static void __init efi_arch_cpu(void)
 
 static void __init efi_arch_blexit(void)
 {
+    unsigned int i = 0;
+
     if ( dtbfile.need_to_free )
         efi_bs->FreePages(dtbfile.addr, PFN_UP(dtbfile.size));
+    /* Free boot modules file names if any */
+    for ( ; i < modules_idx; i++ )
+    {
+        /* Free boot modules binary names */
+        efi_bs->FreePool(modules[i].name);
+        /* Free modules binaries */
+        efi_bs->FreePages(modules[i].addr,
+                          PFN_UP(modules[i].size));
+    }
     if ( memmap )
         efi_bs->FreePool(memmap);
 }
diff --git a/xen/common/efi/boot.c b/xen/common/efi/boot.c
index 758f9d74d2..7879b93f93 100644
--- a/xen/common/efi/boot.c
+++ b/xen/common/efi/boot.c
@@ -166,6 +166,13 @@ static void __init PrintErr(const CHAR16 *s)
     StdErr->OutputString(StdErr, (CHAR16 *)s );
 }
 
+#ifndef CONFIG_HAS_DEVICE_TREE
+static inline int __init efi_check_dt_boot(EFI_FILE_HANDLE dir_handle)
+{
+    return 0;
+}
+#endif
+
 /*
  * Include architecture specific implementation here, which references the
  * static globals defined above.
@@ -1136,6 +1143,8 @@ efi_start(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE *SystemTable)
     bool base_video = false;
     const char *option_str;
     bool use_cfg_file;
+    int dt_modules_found;
+    EFI_FILE_HANDLE dir_handle;
 
     __set_bit(EFI_BOOT, &efi_flags);
     __set_bit(EFI_LOADER, &efi_flags);
@@ -1216,9 +1225,11 @@ efi_start(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE *SystemTable)
 
     efi_arch_relocate_image(0);
 
+    /* Get the file system interface. */
+    dir_handle = get_parent_handle(loaded_image, &file_name);
+
     if ( use_cfg_file )
     {
-        EFI_FILE_HANDLE dir_handle;
         UINTN depth, cols, rows, size;
 
         size = cols = rows = depth = 0;
@@ -1229,9 +1240,6 @@ efi_start(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE *SystemTable)
 
         gop = efi_get_gop();
 
-        /* Get the file system interface. */
-        dir_handle = get_parent_handle(loaded_image, &file_name);
-
         /* Read and parse the config file. */
         if ( read_section(loaded_image, L"config", &cfg, NULL) )
             PrintStr(L"Using builtin config file\r\n");
@@ -1285,14 +1293,12 @@ efi_start(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE *SystemTable)
             efi_bs->FreePool(name.w);
         }
 
-        if ( !name.s )
-            blexit(L"No Dom0 kernel image specified.");
-
         efi_arch_cfg_file_early(loaded_image, dir_handle, section.s);
 
-        option_str = split_string(name.s);
+        option_str = name.s ? split_string(name.s) : NULL;
 
-        if ( !read_section(loaded_image, L"kernel", &kernel, option_str) )
+        if ( !read_section(loaded_image, L"kernel", &kernel, option_str) &&
+             name.s )
         {
             read_file(dir_handle, s2w(&name), &kernel, option_str);
             efi_bs->FreePool(name.w);
@@ -1361,12 +1367,23 @@ efi_start(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE *SystemTable)
         efi_bs->FreePages(cfg.addr, PFN_UP(cfg.size));
         cfg.addr = 0;
 
-        dir_handle->Close(dir_handle);
-
         if ( gop && !base_video )
             gop_mode = efi_find_gop_mode(gop, cols, rows, depth);
     }
 
+    /* Get the number of boot modules specified on the DT or an error (<0) */
+    dt_modules_found = efi_check_dt_boot(dir_handle);
+
+    dir_handle->Close(dir_handle);
+
+    if ( dt_modules_found < 0 )
+        /* efi_check_dt_boot throws some error */
+        blexit(L"Error processing boot modules on DT.");
+
+    /* Check if at least one of Dom0 or DomU(s) is specified */
+    if ( !dt_modules_found && !kernel.ptr )
+        blexit(L"No initial domain kernel specified.");
+
     efi_arch_edd();
 
     /* XXX Collect EDID info. */
-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Mon Oct 11 18:15:49 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 18:15:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.206468.362053 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZzpt-0008BW-1Q; Mon, 11 Oct 2021 18:15:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 206468.362053; Mon, 11 Oct 2021 18:15:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZzps-0008BP-U6; Mon, 11 Oct 2021 18:15:40 +0000
Received: by outflank-mailman (input) for mailman id 206468;
 Mon, 11 Oct 2021 18:15:40 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=RBe3=O7=arm.com=luca.fancellu@srs-us1.protection.inumbo.net>)
 id 1mZzps-0008BJ-7y
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 18:15:40 +0000
Received: from foss.arm.com (unknown [217.140.110.172])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTP
 id fe94f0e7-52bc-4c00-bc63-9840758c8537;
 Mon, 11 Oct 2021 18:15:38 +0000 (UTC)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E3AB8101E;
 Mon, 11 Oct 2021 11:15:37 -0700 (PDT)
Received: from e125770.cambridge.arm.com (e125770.cambridge.arm.com
 [10.1.195.16])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 759BE3F66F;
 Mon, 11 Oct 2021 11:15:36 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fe94f0e7-52bc-4c00-bc63-9840758c8537
From: Luca Fancellu <luca.fancellu@arm.com>
To: xen-devel@lists.xenproject.org
Cc: bertrand.marquis@arm.com,
	wei.chen@arm.com,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Ian Jackson <iwj@xenproject.org>,
	Jan Beulich <jbeulich@suse.com>,
	Wei Liu <wl@xen.org>
Subject: [PATCH v6 0/2] arm/efi: Add dom0less support to UEFI boot
Date: Mon, 11 Oct 2021 19:15:26 +0100
Message-Id: <20211011181528.17367-1-luca.fancellu@arm.com>
X-Mailer: git-send-email 2.17.1

This serie introduces a way to start a dom0less setup when Xen is booting as EFI
application.
Using the device tree it's now possible to fetch from the disk and load in
memory all the modules needed to start any domU defined in the DT.
Dom0less for now is supported only by the arm architecture.

This serie was originally formed by 3 patch, the first one was merged.

Luca Fancellu (2):
  arm/efi: Use dom0less configuration when using EFI boot
  arm/efi: load dom0 modules from DT using UEFI

 docs/misc/arm/device-tree/booting.txt |  29 +++
 docs/misc/efi.pandoc                  | 261 ++++++++++++++++++++
 xen/arch/arm/efi/efi-boot.h           | 343 +++++++++++++++++++++++++-
 xen/common/efi/boot.c                 |  55 +++--
 4 files changed, 671 insertions(+), 17 deletions(-)

-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Mon Oct 11 18:15:49 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 18:15:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.206469.362064 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZzpw-0008Rr-Aw; Mon, 11 Oct 2021 18:15:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 206469.362064; Mon, 11 Oct 2021 18:15:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZzpw-0008Rk-6H; Mon, 11 Oct 2021 18:15:44 +0000
Received: by outflank-mailman (input) for mailman id 206469;
 Mon, 11 Oct 2021 18:15:43 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=RBe3=O7=arm.com=luca.fancellu@srs-us1.protection.inumbo.net>)
 id 1mZzpv-0008RI-4e
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 18:15:43 +0000
Received: from foss.arm.com (unknown [217.140.110.172])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTP
 id 3d83d01f-2abf-11ec-80ee-12813bfff9fa;
 Mon, 11 Oct 2021 18:15:41 +0000 (UTC)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6C87F101E;
 Mon, 11 Oct 2021 11:15:41 -0700 (PDT)
Received: from e125770.cambridge.arm.com (e125770.cambridge.arm.com
 [10.1.195.16])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0298D3F66F;
 Mon, 11 Oct 2021 11:15:39 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3d83d01f-2abf-11ec-80ee-12813bfff9fa
From: Luca Fancellu <luca.fancellu@arm.com>
To: xen-devel@lists.xenproject.org
Cc: bertrand.marquis@arm.com,
	wei.chen@arm.com,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Ian Jackson <iwj@xenproject.org>,
	Jan Beulich <jbeulich@suse.com>,
	Wei Liu <wl@xen.org>
Subject: [PATCH v6 2/2] arm/efi: load dom0 modules from DT using UEFI
Date: Mon, 11 Oct 2021 19:15:28 +0100
Message-Id: <20211011181528.17367-3-luca.fancellu@arm.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20211011181528.17367-1-luca.fancellu@arm.com>
References: <20211011181528.17367-1-luca.fancellu@arm.com>

Add support to load Dom0 boot modules from
the device tree using the xen,uefi-binary property.

Update documentation about that.

Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>
---
Changes in v6:
- given the changes to is_boot_module() in previous patch,
a check to avoid declaration of xsm in DT and cfg file is
introduced and the call to is_boot_module is removed.
Changes in v5:
- renamed missing uefi,binary string
- used kernel.ptr instead of kernel.addr to be consistent
to the surrounding code
- Changed a comment referring to efi_arch_check_dt_boot
that now is efi_check_dt_boot
Changes in v4:
- Add check to avoid double definition of Dom0 ramdisk
from cfg file and DT
- Fix if conditions indentation in boot.c
- Moved Dom0 kernel verification code after check for
presence for Dom0 or DomU(s)
- Changed uefi,binary property to xen,uefi-binary
Changes in v3:
- new patch
---
 docs/misc/arm/device-tree/booting.txt |  8 ++++
 docs/misc/efi.pandoc                  | 64 +++++++++++++++++++++++++--
 xen/arch/arm/efi/efi-boot.h           | 52 ++++++++++++++++++++--
 xen/common/efi/boot.c                 | 16 ++++---
 4 files changed, 128 insertions(+), 12 deletions(-)

diff --git a/docs/misc/arm/device-tree/booting.txt b/docs/misc/arm/device-tree/booting.txt
index 7258e7e1ec..c6a775f4e8 100644
--- a/docs/misc/arm/device-tree/booting.txt
+++ b/docs/misc/arm/device-tree/booting.txt
@@ -70,6 +70,14 @@ Each node contains the following properties:
 	priority of this field vs. other mechanisms of specifying the
 	bootargs for the kernel.
 
+- xen,uefi-binary (UEFI boot only)
+
+	String property that specifies the file name to be loaded by the UEFI
+	boot for this module. If this is specified, there is no need to specify
+	the reg property because it will be created by the UEFI stub on boot.
+	This option is needed only when UEFI boot is used, the node needs to be
+	compatible with multiboot,kernel or multiboot,ramdisk.
+
 Examples
 ========
 
diff --git a/docs/misc/efi.pandoc b/docs/misc/efi.pandoc
index 876cd55005..4abbb5bb82 100644
--- a/docs/misc/efi.pandoc
+++ b/docs/misc/efi.pandoc
@@ -167,6 +167,28 @@ sbsign \
 	--output xen.signed.efi \
 	xen.unified.efi
 ```
+## UEFI boot and Dom0 modules on ARM
+
+When booting using UEFI on ARM, it is possible to specify the Dom0 modules
+directly from the device tree without using the Xen configuration file, here an
+example:
+
+chosen {
+	#size-cells = <0x1>;
+	#address-cells = <0x1>;
+	xen,xen-bootargs = "[Xen boot arguments]"
+
+	module@1 {
+		compatible = "multiboot,kernel", "multiboot,module";
+		xen,uefi-binary = "vmlinuz-3.0.31-0.4-xen";
+		bootargs = "[domain 0 command line options]";
+	};
+
+	module@2 {
+		compatible = "multiboot,ramdisk", "multiboot,module";
+		xen,uefi-binary = "initrd-3.0.31-0.4-xen";
+	};
+}
 
 ## UEFI boot and dom0less on ARM
 
@@ -326,10 +348,10 @@ chosen {
 ### Boot Xen, Dom0 and DomU(s)
 
 This configuration is a mix of the two configuration above, to boot this one
-the configuration file must be processed so the /chosen node must have the
-"xen,uefi-cfg-load" property.
+the configuration file can be processed or the Dom0 modules can be read from
+the device tree.
 
-Here an example:
+Here the first example:
 
 Xen configuration file:
 
@@ -369,4 +391,40 @@ chosen {
 };
 ```
 
+Here the second example:
+
+Device tree:
+
+```
+chosen {
+	#size-cells = <0x1>;
+	#address-cells = <0x1>;
+	xen,xen-bootargs = "[Xen boot arguments]"
+
+	module@1 {
+		compatible = "multiboot,kernel", "multiboot,module";
+		xen,uefi-binary = "vmlinuz-3.0.31-0.4-xen";
+		bootargs = "[domain 0 command line options]";
+	};
+
+	module@2 {
+		compatible = "multiboot,ramdisk", "multiboot,module";
+		xen,uefi-binary = "initrd-3.0.31-0.4-xen";
+	};
+
+	domU1 {
+		#size-cells = <0x1>;
+		#address-cells = <0x1>;
+		compatible = "xen,domain";
+		cpus = <0x1>;
+		memory = <0x0 0xc0000>;
+		vpl011;
 
+		module@1 {
+			compatible = "multiboot,kernel", "multiboot,module";
+			xen,uefi-binary = "Image-domu1.bin";
+			bootargs = "console=ttyAMA0 root=/dev/ram0 rw";
+		};
+	};
+};
+```
diff --git a/xen/arch/arm/efi/efi-boot.h b/xen/arch/arm/efi/efi-boot.h
index f35e035b22..840728d6c0 100644
--- a/xen/arch/arm/efi/efi-boot.h
+++ b/xen/arch/arm/efi/efi-boot.h
@@ -32,8 +32,12 @@ static unsigned int __initdata modules_idx;
 #define ERROR_RENAME_MODULE_NAME    (-4)
 #define ERROR_SET_REG_PROPERTY      (-5)
 #define ERROR_CHECK_MODULE_COMPAT   (-6)
+#define ERROR_DOM0_ALREADY_FOUND    (-7)
+#define ERROR_DOM0_RAMDISK_FOUND    (-8)
+#define ERROR_XSM_ALREADY_FOUND     (-9)
 #define ERROR_DT_MODULE_DOMU        (-1)
 #define ERROR_DT_CHOSEN_NODE        (-2)
+#define ERROR_DT_MODULE_DOM0        (-3)
 
 void noreturn efi_xen_start(void *fdt_ptr, uint32_t fdt_size);
 void __flush_dcache_area(const void *vaddr, unsigned long size);
@@ -46,7 +50,8 @@ static int allocate_module_file(EFI_FILE_HANDLE dir_handle,
 static int handle_module_node(EFI_FILE_HANDLE dir_handle,
                               int module_node_offset,
                               int reg_addr_cells,
-                              int reg_size_cells);
+                              int reg_size_cells,
+                              bool is_domu_module);
 static int handle_dom0less_domain_node(EFI_FILE_HANDLE dir_handle,
                                        int domain_node);
 static int efi_check_dt_boot(EFI_FILE_HANDLE dir_handle);
@@ -701,7 +706,8 @@ static int __init allocate_module_file(EFI_FILE_HANDLE dir_handle,
 static int __init handle_module_node(EFI_FILE_HANDLE dir_handle,
                                      int module_node_offset,
                                      int reg_addr_cells,
-                                     int reg_size_cells)
+                                     int reg_size_cells,
+                                     bool is_domu_module)
 {
     const void *uefi_name_prop;
     char mod_string[24]; /* Placeholder for module@ + a 64-bit number + \0 */
@@ -754,6 +760,41 @@ static int __init handle_module_node(EFI_FILE_HANDLE dir_handle,
         return ERROR_SET_REG_PROPERTY;
     }
 
+    if ( !is_domu_module )
+    {
+        if ( (fdt_node_check_compatible(fdt, module_node_offset,
+                                    "multiboot,kernel") == 0) )
+        {
+            /*
+            * This is the Dom0 kernel, wire it to the kernel variable because it
+            * will be verified by the shim lock protocol later in the common
+            * code.
+            */
+            if ( kernel.addr )
+            {
+                PrintMessage(L"Dom0 kernel already found in cfg file.");
+                return ERROR_DOM0_ALREADY_FOUND;
+            }
+            kernel.need_to_free = false; /* Freed using the module array */
+            kernel.addr = file->addr;
+            kernel.size = file->size;
+        }
+        else if ( ramdisk.addr &&
+                  (fdt_node_check_compatible(fdt, module_node_offset,
+                                             "multiboot,ramdisk") == 0) )
+        {
+            PrintMessage(L"Dom0 ramdisk already found in cfg file.");
+            return ERROR_DOM0_RAMDISK_FOUND;
+        }
+        else if ( xsm.addr &&
+                  (fdt_node_check_compatible(fdt, module_node_offset,
+                                             "xen,xsm-policy") == 0) )
+        {
+            PrintMessage(L"XSM policy already found in cfg file.");
+            return ERROR_XSM_ALREADY_FOUND;
+        }
+    }
+
     return 0;
 }
 
@@ -793,7 +834,7 @@ static int __init handle_dom0less_domain_node(EFI_FILE_HANDLE dir_handle,
           module_node = fdt_next_subnode(fdt, module_node) )
     {
         int ret = handle_module_node(dir_handle, module_node, addr_cells,
-                                        size_cells);
+                                     size_cells, true);
         if ( ret < 0 )
             return ret;
     }
@@ -803,7 +844,7 @@ static int __init handle_dom0less_domain_node(EFI_FILE_HANDLE dir_handle,
 
 /*
  * This function checks for xen domain nodes under the /chosen node for possible
- * domU guests to be loaded.
+ * dom0 and domU guests to be loaded.
  * Returns the number of modules loaded or a negative number for error.
  */
 static int __init efi_check_dt_boot(EFI_FILE_HANDLE dir_handle)
@@ -830,6 +871,9 @@ static int __init efi_check_dt_boot(EFI_FILE_HANDLE dir_handle)
             if ( handle_dom0less_domain_node(dir_handle, node) < 0 )
                 return ERROR_DT_MODULE_DOMU;
         }
+        else if ( handle_module_node(dir_handle, node, addr_len, size_len,
+                                     false) < 0 )
+                 return ERROR_DT_MODULE_DOM0;
     }
 
     /* Free boot modules file names if any */
diff --git a/xen/common/efi/boot.c b/xen/common/efi/boot.c
index 7879b93f93..531975326f 100644
--- a/xen/common/efi/boot.c
+++ b/xen/common/efi/boot.c
@@ -1302,11 +1302,6 @@ efi_start(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE *SystemTable)
         {
             read_file(dir_handle, s2w(&name), &kernel, option_str);
             efi_bs->FreePool(name.w);
-
-            if ( !EFI_ERROR(efi_bs->LocateProtocol(&shim_lock_guid, NULL,
-                            (void **)&shim_lock)) &&
-                 (status = shim_lock->Verify(kernel.ptr, kernel.size)) != EFI_SUCCESS )
-                PrintErrMesg(L"Dom0 kernel image could not be verified", status);
         }
 
         if ( !read_section(loaded_image, L"ramdisk", &ramdisk, NULL) )
@@ -1384,6 +1379,17 @@ efi_start(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE *SystemTable)
     if ( !dt_modules_found && !kernel.ptr )
         blexit(L"No initial domain kernel specified.");
 
+    /*
+     * The Dom0 kernel can be loaded from the configuration file or by the
+     * device tree through the efi_check_dt_boot function, in this stage
+     * verify it.
+     */
+    if ( kernel.ptr &&
+         !EFI_ERROR(efi_bs->LocateProtocol(&shim_lock_guid, NULL,
+                                           (void **)&shim_lock)) &&
+         (status = shim_lock->Verify(kernel.ptr, kernel.size)) != EFI_SUCCESS )
+        PrintErrMesg(L"Dom0 kernel image could not be verified", status);
+
     efi_arch_edd();
 
     /* XXX Collect EDID info. */
-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Mon Oct 11 18:18:38 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 18:18:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.206490.362086 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZzsj-0001fP-5I; Mon, 11 Oct 2021 18:18:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 206490.362086; Mon, 11 Oct 2021 18:18:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mZzsj-0001fI-1c; Mon, 11 Oct 2021 18:18:37 +0000
Received: by outflank-mailman (input) for mailman id 206490;
 Mon, 11 Oct 2021 18:18:35 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=gQnf=O7=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1mZzsh-0001fC-Ox
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 18:18:35 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 84189170-b65e-4f99-8fd2-4006f69d8b5e;
 Mon, 11 Oct 2021 18:18:34 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id 57A3060F0F;
 Mon, 11 Oct 2021 18:18:33 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 84189170-b65e-4f99-8fd2-4006f69d8b5e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1633976313;
	bh=Cjuja8k1RVECncvnL9T/xemSuheF1RChVpdZLn5/L3Y=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=f8iymEF+I/E6J0xB6st0pkkP709Z9W6GdkGQgJpxy240STVUZXEWwHvH6AejtXDzQ
	 VvCihBAAwpZgVXKztdvsXlDdz+4/3BKVXA3YV3+TPzXs/z8xclTPAdAsPSY/8UQfpn
	 W1ot/wufjkXahJUdtZBpk4btYOGFtJQzpaC7FlUcIuipi8yXzYopOFIRZ5Hz61gylI
	 +vSpbJQFgReR/XP9+Y0KGvUHgYeYKvfayM6CP5ILVCGd9jh24k8RanKQQ+2lUf4Lia
	 Ow7z5azuDAEnMNujoOJ6d6EHUelSJSnRX+szwddo+UqRPHPB2ChAw3zY8XQWk337o6
	 zkEqGwsLzMbmQ==
Date: Mon, 11 Oct 2021 11:18:32 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Jan Beulich <jbeulich@suse.com>
cc: Bertrand Marquis <Bertrand.Marquis@arm.com>, 
    Rahul Singh <Rahul.Singh@arm.com>, Andre Przywara <Andre.Przywara@arm.com>, 
    Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, 
    Andrew Cooper <andrew.cooper3@citrix.com>, 
    George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>, 
    Wei Liu <wl@xen.org>, Paul Durrant <paul@xen.org>, 
    =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= <roger.pau@citrix.com>, 
    "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v5 08/11] xen/arm: Enable the existing x86 virtual PCI
 support for ARM.
In-Reply-To: <59c9e102-c710-64d3-2a1a-cc8dcbcceead@suse.com>
Message-ID: <alpine.DEB.2.21.2110111105180.25528@sstabellini-ThinkPad-T480s>
References: <cover.1633540842.git.rahul.singh@arm.com> <9bdca2cda5d2e83f94dc2423e55714273539760a.1633540842.git.rahul.singh@arm.com> <6752f2d3-171b-37f5-c809-82995a8f3f36@suse.com> <CEF7FFB0-779A-4F46-8667-6BCD9BA5CB6C@arm.com> <b735c2d3-1dbb-ce0a-c2fa-160d4c6938d3@suse.com>
 <A8DEBD07-FB45-4E4E-A2C3-7AF8B393B032@arm.com> <59c9e102-c710-64d3-2a1a-cc8dcbcceead@suse.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Mon, 11 Oct 2021, Jan Beulich wrote:
> On 11.10.2021 15:34, Bertrand Marquis wrote:
> >> On 11 Oct 2021, at 14:09, Jan Beulich <jbeulich@suse.com> wrote:
> >> On 11.10.2021 14:41, Bertrand Marquis wrote:
> >>>> On 7 Oct 2021, at 14:43, Jan Beulich <jbeulich@suse.com> wrote:
> >>>> On 06.10.2021 19:40, Rahul Singh wrote:
> >>>>> --- /dev/null
> >>>>> +++ b/xen/arch/arm/vpci.c
> >>>>> @@ -0,0 +1,102 @@
> >>>>> +/*
> >>>>> + * xen/arch/arm/vpci.c
> >>>>> + *
> >>>>> + * This program is free software; you can redistribute it and/or modify
> >>>>> + * it under the terms of the GNU General Public License as published by
> >>>>> + * the Free Software Foundation; either version 2 of the License, or
> >>>>> + * (at your option) any later version.
> >>>>> + *
> >>>>> + * This program is distributed in the hope that it will be useful,
> >>>>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> >>>>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> >>>>> + * GNU General Public License for more details.
> >>>>> + */
> >>>>> +#include <xen/sched.h>
> >>>>> +
> >>>>> +#include <asm/mmio.h>
> >>>>> +
> >>>>> +#define REGISTER_OFFSET(addr)  ( (addr) & 0x00000fff)
> >>>>
> >>>> Nit: Stray blank (like you had in an earlier version for MMCFG_BDF()).
> >>>> Also isn't this effectively part of the public interface (along with
> >>>> MMCFG_BDF()), alongside GUEST_VPCI_ECAM_{BASE,SIZE}?
> >>>
> >>> I will move that in the next version to xen/pci.h and rename itMMCFG_REG_OFFSET.
> >>> Would that be ok ?
> >>
> >> That would be okay and make sense when put next to MMCFG_BDF(), but
> >> it would not address my comment: That still wouldn't be the public
> >> interface. Otoh you only mimic hardware behavior, so perhaps the
> >> splitting of the address isn't as relevant to put there as would be
> >> GUEST_VPCI_ECAM_{BASE,SIZE}.
> > 
> > Ok now I get what you wanted.
> > 
> > You would actually like both MMCFG_BDF and MMCFG_REG_OFFSET to
> > be moved to arch-arm.h.
> > 
> > Then I am not quite sure to follow why.
> > Those are not macros coming out of a way we have to define this but from
> > how it works in standard PCI.
> > The base and size are needed to know where the PCI bus will be.
> > 
> > So why should those be needed in public headers ?
> 
> Well, see my "Otoh ..." in the earlier reply. Keeping the two
> address splitting macros out of there is okay.
> 
> >>>>> --- a/xen/drivers/passthrough/pci.c
> >>>>> +++ b/xen/drivers/passthrough/pci.c
> >>>>> @@ -766,6 +766,24 @@ int pci_add_device(u16 seg, u8 bus, u8 devfn,
> >>>>>    else
> >>>>>        iommu_enable_device(pdev);
> >>>>
> >>>> Please note the context above; ...
> >>>>
> >>>>> +#ifdef CONFIG_ARM
> >>>>> +    /*
> >>>>> +     * On ARM PCI devices discovery will be done by Dom0. Add vpci handler when
> >>>>> +     * Dom0 inform XEN to add the PCI devices in XEN.
> >>>>> +     */
> >>>>> +    ret = vpci_add_handlers(pdev);
> >>>>> +    if ( ret )
> >>>>> +    {
> >>>>> +        printk(XENLOG_ERR "setup of vPCI failed: %d\n", ret);
> >>>>> +        pci_cleanup_msi(pdev);
> >>>>> +        ret = iommu_remove_device(pdev);
> >>>>> +        if ( pdev->domain )
> >>>>> +            list_del(&pdev->domain_list);
> >>>>> +        free_pdev(pseg, pdev);
> >>>>
> >>>> ... you unconditionally undo the if() part of the earlier conditional;
> >>>> is there any guarantee that the other path can't ever be taken, now
> >>>> and forever? If it can't be taken now (which I think is the case as
> >>>> long as Dom0 wouldn't report the same device twice), then at least some
> >>>> precaution wants taking. Maybe moving your addition into that if()
> >>>> could be an option.
> >>>>
> >>>> Furthermore I continue to wonder whether this ordering is indeed
> >>>> preferable over doing software setup before hardware arrangements. This
> >>>> would address the above issue as well as long as vpci_add_handlers() is
> >>>> idempotent. And it would likely simplify error cleanup.
> >>>
> >>> I agree with you so I will move this code block before iommu part.
> >>>
> >>> But digging deeper into this, I would have 2 questions:
> >>>
> >>> - msi_cleanup was done there after a request from Stefano, but is not
> >>> done in case or iommu error, is there an issue to solve here ?
> >>
> >> Maybe, but I'm not sure. This very much depends on what a domain
> >> could in principle do with a partly set-up device. Plus let's
> >> not forget that we're talking of only Dom0 here (for now at least,
> >> i.e. not considering the dom0less case).
> >>
> >> But I'd also like to further defer to Stefano.
> > 
> > Ok, I must admit I do not really see at that stage why doing an MSI cleanup
> > could be needed so I will wait for Stefano to know if I need to keep this when
> > moving the block up (at the end it is theoretical right now as this is empty).

I know that MSIs are not supported yet on ARM (pci_cleanup_msi does
nothing). But I wanted to make sure that the pci_cleanup_msi() calls are
present anywhere necessary, especially on the error paths. So that once
we add MSI support, we don't need to search through the code to find all
the error paths missing a pci_cleanup_msi() call.

To answer your first question: you are right, we are also missing a
pci_cleanup_msi() call in the case of IOMMU error. So it might be better
to move the call to pci_cleanup_msi() under the "out" label so that we
can do it once for both cases.

To answer your second point about whether it is necessary at all: if
MSIs and MSI-Xs cannot be already setup at this point at all (not even
the enable bit), then we don't need any call to pci_cleanup_msi() in
pci_add_device.


From xen-devel-bounces@lists.xenproject.org Mon Oct 11 18:31:10 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 18:31:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.206503.362097 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ma04l-0003xs-Bs; Mon, 11 Oct 2021 18:31:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 206503.362097; Mon, 11 Oct 2021 18:31:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ma04l-0003xl-8q; Mon, 11 Oct 2021 18:31:03 +0000
Received: by outflank-mailman (input) for mailman id 206503;
 Mon, 11 Oct 2021 18:31:02 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=LRsb=O7=epam.com=prvs=0918241709=oleksandr_andrushchenko@srs-us1.protection.inumbo.net>)
 id 1ma04j-0003xf-M4
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 18:31:01 +0000
Received: from mx0a-0039f301.pphosted.com (unknown [148.163.133.242])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 617937c8-2ac1-11ec-80f0-12813bfff9fa;
 Mon, 11 Oct 2021 18:30:59 +0000 (UTC)
Received: from pps.filterd (m0174677.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 19BI419E003994; 
 Mon, 11 Oct 2021 18:30:55 GMT
Received: from eur05-vi1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2176.outbound.protection.outlook.com [104.47.17.176])
 by mx0a-0039f301.pphosted.com with ESMTP id 3bmt7dr2h7-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Mon, 11 Oct 2021 18:30:54 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by AM0PR03MB5698.eurprd03.prod.outlook.com (2603:10a6:208:171::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18; Mon, 11 Oct
 2021 18:30:51 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::b034:334a:abf5:223c]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::b034:334a:abf5:223c%7]) with mapi id 15.20.4587.026; Mon, 11 Oct 2021
 18:30:51 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 617937c8-2ac1-11ec-80f0-12813bfff9fa
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=KNgOcWshRjKQRbYbo2rGzVtB7SBl86h9sNLgAKDtRMctyWh/H0b4iCwSdFgoGNxp7aMQNmew8k1T/X0LB1zh5ZjwPFlmvB5VXMRyBVB23ACiM7HO3Ah2X8J/Fd0AAm3X8DEk81/ODFKicxm4+Vx1DwggMai0oqV3S2VLgFwdMUoFPbScsCU2IWQrTITPFcrCKICUfkBeVtfS63Am/wOHtVT0SMfiv2WPnkbuIsPlaI3r339QAUbBFgrhVYpi8U7AeC8SWo/laqn0CUk7+5uWy99+yVKuLbnAPQdzxapvMU7YRmjGuSIfa6ld0ZcvwQ0nmP4VkD0kkEaneYfno0LFUg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=vz0PKuct4bXofYOTPrFEEgYI039qmUUKQNsSnLtdC0w=;
 b=BVh7NIGCnYdgLEXVQOqoxA8YF7VxulSiM4uJjBUlvbtv20AOEXc4eSkpokSqo5Sr5uTKMxJkFQbB6r5Zmz7I5uzFijpmTqwERyqWAbUF/AHvZ1PGOqZhNgdRarqMjwwSeA6LwQPRPA2MYuo0pWusk3N6KieMCPcsyHdrXFMP7K0GEZQqasAMz6+64NRAXzoE4ICQIZhJe9eFbe2n+O39Wjdo9CkppT0+gpTlC/AbNPAQ0/hs9BqLAcqpkSj0eKtzxlKS6gdMZeQvuJZd5Mwywj18y4u8KRS6ga5zqY+fnELKOuqxO19N9ylnbDAQQxnWj3ZeFto/CcnJQBWupimHgw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=vz0PKuct4bXofYOTPrFEEgYI039qmUUKQNsSnLtdC0w=;
 b=Dy5D5loUsrSuTncxhAg9hkzmDz0YoXTGdXMDP2QIVuio2kd1ESgZtkcYiCTjZlBs966BjjSmvkTZ/+FT7x4JGPTE53KLHBzVF36+MINzlOVgttT++QCmtTwuxMamA030Yyzpjv9qiIji802oG8hQHnWz9Au/kUL6aj0M3/LKaopbUM+oTg5+Aufi3N8NbePyybIviAL8MShUgRYLJlNwOHrpj4c+OcMTp5jblMUld4J2fGYpi71d0UVNXGqVYGbwFk5+dT0AelrtwrIlb6OQPfZOIet0ldH83qdxp4zBd8gh0QZyigknpzk1Y78FWgb0s+jKGEOOkBenSAeEQQD66g==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Bertrand Marquis <bertrand.marquis@arm.com>,
        =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>
CC: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>,
        Rahul Singh
	<rahul.singh@arm.com>,
        "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>,
        Andre Przywara <Andre.Przywara@arm.com>,
        Stefano Stabellini <sstabellini@kernel.org>,
        Julien Grall <julien@xen.org>,
        Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
        Andrew Cooper
	<andrew.cooper3@citrix.com>,
        George Dunlap <george.dunlap@citrix.com>,
        Ian
 Jackson <iwj@xenproject.org>, Jan Beulich <jbeulich@suse.com>,
        Wei Liu
	<wl@xen.org>, Paul Durrant <paul@xen.org>
Subject: Re: [PATCH v5 08/11] xen/arm: Enable the existing x86 virtual PCI
 support for ARM.
Thread-Topic: [PATCH v5 08/11] xen/arm: Enable the existing x86 virtual PCI
 support for ARM.
Thread-Index: 
 AQHXutl3YqS5dHXsYk6KpdKt4d14RavNphKAgABZ5QCAAAISgIAABoqAgAAJBQCAABTvgA==
Date: Mon, 11 Oct 2021 18:30:50 +0000
Message-ID: <611b61a4-9635-f1e6-a078-e40d4cbd49fd@epam.com>
References: <cover.1633540842.git.rahul.singh@arm.com>
 <9bdca2cda5d2e83f94dc2423e55714273539760a.1633540842.git.rahul.singh@arm.com>
 <YWQXF2vDaWQvi+bT@MacBook-Air-de-Roger.local>
 <4F406854-4F90-48F6-8470-6CCB60A3CB77@arm.com>
 <e199bfe2-0bcc-989f-fd4a-ecf44a3cd1ac@epam.com>
 <YWRpuUtHkyA4RY5H@MacBook-Air-de-Roger.local>
 <AF7AB609-3E79-4017-A296-CC7C87E1705F@arm.com>
In-Reply-To: <AF7AB609-3E79-4017-A296-CC7C87E1705F@arm.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
authentication-results: arm.com; dkim=none (message not signed)
 header.d=none;arm.com; dmarc=none action=none header.from=epam.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 44b6c739-f68f-4312-c38f-08d98ce540b7
x-ms-traffictypediagnostic: AM0PR03MB5698:
x-ms-exchange-transport-forked: True
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <AM0PR03MB56986566D83222E64E2B79D9E7B59@AM0PR03MB5698.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 uJmYRgb9XQcCIgoqLYHC42ckxrsZs68ApPOMl4wFVlFu51OTgBIl5CUMXVtmT4SOwaDQsi8BgbErFYlxESuDK25ZA10dJDOxqvZTea9im2gtEIfDvjFKVDBNkM0+NkA28WG0D+Ozgn3qfFZNyZf3q7Ue++ZpfRqo6MNT8Sb0kJ488I69hX7VYw7aelqVYjHch7zezP1yLMz6ggWH6Svw00I/jsPm8P67S5kK0avRXZi8vO7yWMVNRCgK6JixmTuSpwJ4BzkZ5tLqJmCzV6NjU5NTShPFA6G/+nEi6Ej0pG5nVsj5xW0K62LDhHwcLRR5qaQCYv2OXcMpmdXLBbNfXZmC+6dQ5VVHQPAFm/7jjDOwbmVzgWjicrqcsDP3FXBYrlrEKwnQ+91AfJMX1GN9F5+6xzIw/TLYxAY8e1XMcX5PkV0yuugvATPPHI7bU+NU1GJiTg2eYqrPcFXiQjSjN8DbWgpMY4VpqbHU/cgGcmWHcvxmUOmWYGSVH35zbIC5wDWM1q/NMq+/kPULySM8EgGcKr/qpdVYo4a5bEvDgqSjqE679n6goOY1XtbHkLvHqUbl60UD9mGSdwN6rluYiLGlT8V0RuDhjIAvMxqnGRQy4/CN0YpgbfH1sauwz/xP21/TUtgkkIUtRvcNskfY0HUThqwucOTnMRk5Yu514dSpmmY3M05rLak52LR5QXiPTQLrk6mEXfw/cLFKEV+gfuTtHUAsnf1kViJHyuLkJO1zDsnDDVl0Gy3tzZFVp4YA
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(71200400001)(316002)(55236004)(54906003)(26005)(38100700002)(5660300002)(2616005)(110136005)(31686004)(4326008)(6512007)(7416002)(2906002)(186003)(64756008)(122000001)(66556008)(66476007)(38070700005)(66946007)(86362001)(31696002)(8936002)(8676002)(53546011)(6486002)(66446008)(6506007)(76116006)(508600001)(36756003)(83380400001)(91956017)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?Y2pnQmlEWHVMZVE1V3FPajhHbkR3TUVuT0FmdDBwRjhMU1VlL002SFJoZzV1?=
 =?utf-8?B?YUtwYndjRWtIemRwSEVvRmJINnJhQnpiWlZSanpOcjRVYVd3ZndoV3BNalA2?=
 =?utf-8?B?MHpoOTMrSytxbStlbkFrbDg3eWhTdWxYN0N2ZE5GUFlIL2lLTTlTS0h1YnBh?=
 =?utf-8?B?REI3WHBtSE5lRFZiU0VyODFtVCtCN0pIYUE4dnZ1ZzYrVHJ0QVk4MGtHU1Rh?=
 =?utf-8?B?dlNockpwL3pLSk1qSzZ1Z09ROWU0SEJ6SDVaYXZHTjhkcHQzV1VTKzYydERk?=
 =?utf-8?B?d0IxMUJ6QkxmSTBFaDBpbkhTNUoxM2YzZi9sTEQ1aUJOS095c0lrRlNLMXFx?=
 =?utf-8?B?Z0U1YmF1NWI2R1lJZUVPQ0ZINGpmWmlJc3V3Sk9YRFlxMXlJcGJnR1ZVRnRk?=
 =?utf-8?B?UDUvSTlVQ0Q1WU5UeCsvUDVRVFRSdWpjMzc1SFZaYzJMSEdBd3pTTXFzR0ty?=
 =?utf-8?B?MEswL0lVVlE5QysvVHY3ck8yQnRWZlhmS2pJa0pheWp5ZDNzZ3V3Ny8yZU9H?=
 =?utf-8?B?VEl4SkJSTlJoNFlFVzdGVy9XbkU3aEFpSzNJNjNLbmV3WHRkYlQrQmJKcTEy?=
 =?utf-8?B?SlFyZFN0WE04b2lrbTBvWFFRTVc1YkhIRnRZcTBreFV1WTZhOXVzTE8wRjcw?=
 =?utf-8?B?WkdOTytKZWZ0eVpTMy9pYWlLVnpSNjZmNDFTVjhmZi9Rdm44dGxsQThxTGxh?=
 =?utf-8?B?TFJrdjRrTndwcVM5SGcrN2FxQ01lVmx1dXNtMTdhWEY5dlNuTlkzQ3FsaUlM?=
 =?utf-8?B?UUxWNXpyQllITE1NUnVHWC9xd0Frb2lxT0pBL0YvNHd5dTRCcktoSDFpeGVI?=
 =?utf-8?B?VzdNTEV3Sk9iL0dYaGY0M0FPNm1vSUpob2d3KzB5bEtiR0U5ckQrTlRKb3hs?=
 =?utf-8?B?bDFNZUtlQlVtL05PbFFDR2lVa01yUzU5SDhxYk0yWGdDRzdjUXNJYUwvTmJU?=
 =?utf-8?B?Y2F0Z21qdjRHOExZVzRpRG9jMmMwWk9SSk5VT2JWdnZueko4RXZTOTY2elpJ?=
 =?utf-8?B?TlhxVFhBMUZ5OHF1NnZPNVBVNkVLM1RKZ1hDczZnL2JZYno1NC85cUpSSllm?=
 =?utf-8?B?dkZFMURjRlc2MU9QY0U0TUZVamRSenVPWktFRGoxMmpaRDk1V0V5MGo4cnZL?=
 =?utf-8?B?K0F4blFWS1J2d0dFTElPMXNXRTBvT0hNcnF2d0JHNjBMY0hzbTdFbW9HMWd6?=
 =?utf-8?B?WnNRNXZSTDZhbnltdUViaUd0SGxCYVdJc085VkdEaVJ0cFp5akg4SWxxTmNX?=
 =?utf-8?B?cXlyTW9Xc3lOOHFVWTNLd1RMQ0NnKzdndDAvK1lIRm1MRStKL3BTa09BTWdz?=
 =?utf-8?B?Znh1S05ZTGJGd1o3SXlOOG5mM2RkbVFya3lGdXhIblFBUzNFbGdlT3FsZExj?=
 =?utf-8?B?R3o3YTBBczY4RUVDeDhuMW9JeitJOG1lT25lS0hjeVY5QzZGTG0vOVRvenpS?=
 =?utf-8?B?Z2dtRVg3aEFsNDN2Q25pTms1MGFkSTBjL0JmQmJ2Vng4T1N4OVNpRXVMRnVV?=
 =?utf-8?B?Nk51WTBtSXJDQWlBS1B0aWoyb3RIZDl1K1EyNTZ3N1VOZUwrNmZEWUkwZjlp?=
 =?utf-8?B?NjJLa1lkb1NSbmJmUnEyV2JzSlRaNTdmejVxY2lXTElIa0ZTNXRxUGUwUTVS?=
 =?utf-8?B?czZ1Y1hrTjZZVm05dHFsNDZPR0N1VnoxMHcyNzZhbVJWZ0pma1Z0U3E3S0dR?=
 =?utf-8?B?a2V3anRuMHV6dEJKUVQ1VzdMM0t1NG1wTTFrcGxUS3lMajNDTkRrU1k0WGM5?=
 =?utf-8?B?dXl2TnlEeEozUStCVlNoV0hjUTBYNTI3aFJoQ0o4bnFueTdTWVN5VmNCdHYy?=
 =?utf-8?B?dUpwRER6SHRxNEdrbU9PQT09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <5E6C45A02E6E1A4A8B2406B1B2B7E3AB@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 44b6c739-f68f-4312-c38f-08d98ce540b7
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Oct 2021 18:30:50.9824
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Jo9EcIoh4524d+8RdYZ5R3UZ/rwlJSdEPvfp8BgDD6KXXP03Y4Wycmi5aUy2xxYb8+aHXtfCVoxKp0EWzzBISbGyz6bUG7aTlOs3K9nTmMGimIzYS9NcVkQGCO2Bx3Vs
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR03MB5698
X-Proofpoint-ORIG-GUID: vwEIfDpioqbctXO1YZruuHaHiQ4BrxCM
X-Proofpoint-GUID: vwEIfDpioqbctXO1YZruuHaHiQ4BrxCM
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475
 definitions=2021-10-11_06,2021-10-11_01,2020-04-07_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501
 mlxlogscore=999 spamscore=0 suspectscore=0 adultscore=0 clxscore=1015
 phishscore=0 bulkscore=0 malwarescore=0 impostorscore=0 lowpriorityscore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2109230001 definitions=main-2110110106

DQoNCk9uIDExLjEwLjIxIDIwOjE1LCBCZXJ0cmFuZCBNYXJxdWlzIHdyb3RlOg0KPiBIaSBSb2dl
ciwNCj4NCj4+IE9uIDExIE9jdCAyMDIxLCBhdCAxNzo0MywgUm9nZXIgUGF1IE1vbm7DqSA8cm9n
ZXIucGF1QGNpdHJpeC5jb20+IHdyb3RlOg0KPj4NCj4+IE9uIE1vbiwgT2N0IDExLCAyMDIxIGF0
IDA0OjIwOjE0UE0gKzAwMDAsIE9sZWtzYW5kciBBbmRydXNoY2hlbmtvIHdyb3RlOg0KPj4+DQo+
Pj4gT24gMTEuMTAuMjEgMTk6MTIsIEJlcnRyYW5kIE1hcnF1aXMgd3JvdGU6DQo+Pj4+IEhpIFJv
Z2VyLA0KPj4+Pg0KPj4+Pj4gT24gMTEgT2N0IDIwMjEsIGF0IDExOjUxLCBSb2dlciBQYXUgTW9u
bsOpIDxyb2dlci5wYXVAY2l0cml4LmNvbT4gd3JvdGU6DQo+Pj4+Pg0KPj4+Pj4gT24gV2VkLCBP
Y3QgMDYsIDIwMjEgYXQgMDY6NDA6MzRQTSArMDEwMCwgUmFodWwgU2luZ2ggd3JvdGU6DQo+Pj4+
Pj4gVGhlIGV4aXN0aW5nIFZQQ0kgc3VwcG9ydCBhdmFpbGFibGUgZm9yIFg4NiBpcyBhZGFwdGVk
IGZvciBBcm0uDQo+Pj4+Pj4gV2hlbiB0aGUgZGV2aWNlIGlzIGFkZGVkIHRvIFhFTiB2aWEgdGhl
IGh5cGVyIGNhbGwNCj4+Pj4+PiDigJxQSFlTREVWT1BfcGNpX2RldmljZV9hZGTigJ0sIFZQQ0kg
aGFuZGxlciBmb3IgdGhlIGNvbmZpZyBzcGFjZQ0KPj4+Pj4+IGFjY2VzcyBpcyBhZGRlZCB0byB0
aGUgWGVuIHRvIGVtdWxhdGUgdGhlIFBDSSBkZXZpY2VzIGNvbmZpZyBzcGFjZS4NCj4+Pj4+Pg0K
Pj4+Pj4+IEEgTU1JTyB0cmFwIGhhbmRsZXIgZm9yIHRoZSBQQ0kgRUNBTSBzcGFjZSBpcyByZWdp
c3RlcmVkIGluIFhFTg0KPj4+Pj4+IHNvIHRoYXQgd2hlbiBndWVzdCBpcyB0cnlpbmcgdG8gYWNj
ZXNzIHRoZSBQQ0kgY29uZmlnIHNwYWNlLFhFTg0KPj4+Pj4+IHdpbGwgdHJhcCB0aGUgYWNjZXNz
IGFuZCBlbXVsYXRlIHJlYWQvd3JpdGUgdXNpbmcgdGhlIFZQQ0kgYW5kDQo+Pj4+Pj4gbm90IHRo
ZSByZWFsIFBDSSBoYXJkd2FyZS4NCj4+Pj4+Pg0KPj4+Pj4+IEZvciBEb20wbGVzcyBzeXN0ZW1z
IHNjYW5fcGNpX2RldmljZXMoKSB3b3VsZCBiZSB1c2VkIHRvIGRpc2NvdmVyIHRoZQ0KPj4+Pj4+
IFBDSSBkZXZpY2UgaW4gWEVOIGFuZCBWUENJIGhhbmRsZXIgd2lsbCBiZSBhZGRlZCBkdXJpbmcg
WEVOIGJvb3RzLg0KPj4+Pj4+DQo+Pj4+Pj4gU2lnbmVkLW9mZi1ieTogUmFodWwgU2luZ2ggPHJh
aHVsLnNpbmdoQGFybS5jb20+DQo+Pj4+Pj4gUmV2aWV3ZWQtYnk6IFN0ZWZhbm8gU3RhYmVsbGlu
aSA8c3N0YWJlbGxpbmlAa2VybmVsLm9yZz4NCj4+Pj4+PiAtLS0NCj4+Pj4+PiBDaGFuZ2UgaW4g
djU6DQo+Pj4+Pj4gLSBBZGQgcGNpX2NsZWFudXBfbXNpKHBkZXYpIGluIGNsZWFudXAgcGFydC4N
Cj4+Pj4+PiAtIEFkZGVkIFJldmlld2VkLWJ5OiBTdGVmYW5vIFN0YWJlbGxpbmkgPHNzdGFiZWxs
aW5pQGtlcm5lbC5vcmc+DQo+Pj4+Pj4gQ2hhbmdlIGluIHY0Og0KPj4+Pj4+IC0gTW92ZSBhZGRp
dGlvbiBvZiBYRU5fRE9NQ1RMX0NERl92cGNpIGZsYWcgdG8gc2VwYXJhdGUgcGF0Y2gNCj4+Pj4+
PiBDaGFuZ2UgaW4gdjM6DQo+Pj4+Pj4gLSBVc2UgaXNfcGNpX3Bhc3N0aHJvdWdoX2VuYWJsZWQo
KSBpbiBwbGFjZSBvZiBwY2lfcGFzc3Rocm91Z2hfZW5hYmxlZCB2YXJpYWJsZQ0KPj4+Pj4+IC0g
UmVqZWN0IFhFTl9ET01DVExfQ0RGX3ZwY2kgZm9yIHg4NiBpbiBhcmNoX3Nhbml0aXNlX2RvbWFp
bl9jb25maWcoKQ0KPj4+Pj4+IC0gUmVtb3ZlIElTX0VOQUJMRUQoQ09ORklHX0hBU19WUENJKSBm
cm9tIGhhc192cGNpKCkNCj4+Pj4+PiBDaGFuZ2UgaW4gdjI6DQo+Pj4+Pj4gLSBBZGQgbmV3IFhF
Tl9ET01DVExfQ0RGX3ZwY2kgZmxhZw0KPj4+Pj4+IC0gbW9kaWZ5IGhhc192cGNpKCkgdG8gaW5j
bHVkZSBYRU5fRE9NQ1RMX0NERl92cGNpDQo+Pj4+Pj4gLSBlbmFibGUgdnBjaSBzdXBwb3J0IHdo
ZW4gcGNpLXBhc3N0aG91Z2ggb3B0aW9uIGlzIGVuYWJsZWQuDQo+Pj4+Pj4gLS0tDQo+Pj4+Pj4g
LS0tDQo+Pj4+Pj4geGVuL2FyY2gvYXJtL01ha2VmaWxlICAgICAgICAgfCAgIDEgKw0KPj4+Pj4+
IHhlbi9hcmNoL2FybS9kb21haW4uYyAgICAgICAgIHwgICA0ICsrDQo+Pj4+Pj4geGVuL2FyY2gv
YXJtL2RvbWFpbl9idWlsZC5jICAgfCAgIDMgKw0KPj4+Pj4+IHhlbi9hcmNoL2FybS92cGNpLmMg
ICAgICAgICAgIHwgMTAyICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysNCj4+Pj4+
PiB4ZW4vYXJjaC9hcm0vdnBjaS5oICAgICAgICAgICB8ICAzNiArKysrKysrKysrKysNCj4+Pj4+
PiB4ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC9wY2kuYyB8ICAxOCArKysrKysNCj4+Pj4+PiB4ZW4v
aW5jbHVkZS9hc20tYXJtL2RvbWFpbi5oICB8ICAgNyArKy0NCj4+Pj4+PiB4ZW4vaW5jbHVkZS9h
c20teDg2L3BjaS5oICAgICB8ICAgMiAtDQo+Pj4+Pj4geGVuL2luY2x1ZGUvcHVibGljL2FyY2gt
YXJtLmggfCAgIDcgKysrDQo+Pj4+Pj4geGVuL2luY2x1ZGUveGVuL3BjaS5oICAgICAgICAgfCAg
IDIgKw0KPj4+Pj4+IDEwIGZpbGVzIGNoYW5nZWQsIDE3OSBpbnNlcnRpb25zKCspLCAzIGRlbGV0
aW9ucygtKQ0KPj4+Pj4+IGNyZWF0ZSBtb2RlIDEwMDY0NCB4ZW4vYXJjaC9hcm0vdnBjaS5jDQo+
Pj4+Pj4gY3JlYXRlIG1vZGUgMTAwNjQ0IHhlbi9hcmNoL2FybS92cGNpLmgNCj4+Pj4+Pg0KPj4+
Pj4+IGRpZmYgLS1naXQgYS94ZW4vYXJjaC9hcm0vTWFrZWZpbGUgYi94ZW4vYXJjaC9hcm0vTWFr
ZWZpbGUNCj4+Pj4+PiBpbmRleCA0NGQ3Y2M4MWZhLi5mYjljOTc2ZWEyIDEwMDY0NA0KPj4+Pj4+
IC0tLSBhL3hlbi9hcmNoL2FybS9NYWtlZmlsZQ0KPj4+Pj4+ICsrKyBiL3hlbi9hcmNoL2FybS9N
YWtlZmlsZQ0KPj4+Pj4+IEBAIC03LDYgKzcsNyBAQCBpZm5lcSAoJChDT05GSUdfTk9fUExBVCks
eSkNCj4+Pj4+PiBvYmoteSArPSBwbGF0Zm9ybXMvDQo+Pj4+Pj4gZW5kaWYNCj4+Pj4+PiBvYmot
JChDT05GSUdfVEVFKSArPSB0ZWUvDQo+Pj4+Pj4gK29iai0kKENPTkZJR19IQVNfVlBDSSkgKz0g
dnBjaS5vDQo+Pj4+Pj4NCj4+Pj4+PiBvYmotJChDT05GSUdfSEFTX0FMVEVSTkFUSVZFKSArPSBh
bHRlcm5hdGl2ZS5vDQo+Pj4+Pj4gb2JqLXkgKz0gYm9vdGZkdC5pbml0Lm8NCj4+Pj4+PiBkaWZm
IC0tZ2l0IGEveGVuL2FyY2gvYXJtL2RvbWFpbi5jIGIveGVuL2FyY2gvYXJtL2RvbWFpbi5jDQo+
Pj4+Pj4gaW5kZXggMzYxMzhjMWIyZS4uZmJiNTJmNzhmMSAxMDA2NDQNCj4+Pj4+PiAtLS0gYS94
ZW4vYXJjaC9hcm0vZG9tYWluLmMNCj4+Pj4+PiArKysgYi94ZW4vYXJjaC9hcm0vZG9tYWluLmMN
Cj4+Pj4+PiBAQCAtMzksNiArMzksNyBAQA0KPj4+Pj4+ICNpbmNsdWRlIDxhc20vdmdpYy5oPg0K
Pj4+Pj4+ICNpbmNsdWRlIDxhc20vdnRpbWVyLmg+DQo+Pj4+Pj4NCj4+Pj4+PiArI2luY2x1ZGUg
InZwY2kuaCINCj4+Pj4+PiAjaW5jbHVkZSAidnVhcnQuaCINCj4+Pj4+Pg0KPj4+Pj4+IERFRklO
RV9QRVJfQ1BVKHN0cnVjdCB2Y3B1ICosIGN1cnJfdmNwdSk7DQo+Pj4+Pj4gQEAgLTc2Nyw2ICs3
NjgsOSBAQCBpbnQgYXJjaF9kb21haW5fY3JlYXRlKHN0cnVjdCBkb21haW4gKmQsDQo+Pj4+Pj4g
ICAgICBpZiAoIGlzX2hhcmR3YXJlX2RvbWFpbihkKSAmJiAocmMgPSBkb21haW5fdnVhcnRfaW5p
dChkKSkgKQ0KPj4+Pj4+ICAgICAgICAgIGdvdG8gZmFpbDsNCj4+Pj4+Pg0KPj4+Pj4+ICsgICAg
aWYgKCAocmMgPSBkb21haW5fdnBjaV9pbml0KGQpKSAhPSAwICkNCj4+Pj4+PiArICAgICAgICBn
b3RvIGZhaWw7DQo+Pj4+Pj4gKw0KPj4+Pj4+ICAgICAgcmV0dXJuIDA7DQo+Pj4+Pj4NCj4+Pj4+
PiBmYWlsOg0KPj4+Pj4+IGRpZmYgLS1naXQgYS94ZW4vYXJjaC9hcm0vZG9tYWluX2J1aWxkLmMg
Yi94ZW4vYXJjaC9hcm0vZG9tYWluX2J1aWxkLmMNCj4+Pj4+PiBpbmRleCBjNWFmYmUyZTA1Li5m
NGM4OWJkZThjIDEwMDY0NA0KPj4+Pj4+IC0tLSBhL3hlbi9hcmNoL2FybS9kb21haW5fYnVpbGQu
Yw0KPj4+Pj4+ICsrKyBiL3hlbi9hcmNoL2FybS9kb21haW5fYnVpbGQuYw0KPj4+Pj4+IEBAIC0z
MDUzLDYgKzMwNTMsOSBAQCB2b2lkIF9faW5pdCBjcmVhdGVfZG9tMCh2b2lkKQ0KPj4+Pj4+ICAg
ICAgaWYgKCBpb21tdV9lbmFibGVkICkNCj4+Pj4+PiAgICAgICAgICBkb20wX2NmZy5mbGFncyB8
PSBYRU5fRE9NQ1RMX0NERl9pb21tdTsNCj4+Pj4+Pg0KPj4+Pj4+ICsgICAgaWYgKCBpc19wY2lf
cGFzc3Rocm91Z2hfZW5hYmxlZCgpICkNCj4+Pj4+PiArICAgICAgICBkb20wX2NmZy5mbGFncyB8
PSBYRU5fRE9NQ1RMX0NERl92cGNpOw0KPj4+Pj4gSSB0aGluayBJJ20gY29uZnVzZWQgd2l0aCB0
aGlzLiBZb3Ugc2VlbSB0byBlbmFibGUgdlBDSSBmb3IgZG9tMCwgYnV0DQo+Pj4+PiB0aGVuIGRv
bWFpbl92cGNpX2luaXQgd2lsbCBzZXR1cCB0cmFwcyBmb3IgdGhlIGd1ZXN0IHZpcnR1YWwgRUNB
TQ0KPj4+Pj4gbGF5b3V0LCBub3QgdGhlIG5hdGl2ZSBvbmUgdGhhdCBkb20wIHdpbGwgYmUgdXNp
bmcuDQo+Pj4+IEkgdGhpbmsgYWZ0ZXIgdGhlIGxhc3QgZGlzY3Vzc2lvbnMsIGl0IHdhcyBkZWNp
ZGVkIHRvIGFsc28gaW5zdGFsbGVkIHRoZSB2cGNpDQo+Pj4+IGhhbmRsZXIgZm9yIGRvbTAuIEkg
d2lsbCBoYXZlIHRvIGxvb2sgaW50byB0aGlzIGFuZCBjb21lIGJhY2sgdG8geW91Lg0KPj4+PiBA
T2xla3NhbmRyOiBDb3VsZCB5b3UgY29tbWVudCBvbiB0aGlzLg0KPj4+IFllcywgd2UgZG8gdHJh
cCBEb20wIGFzIHdlbGwuIFRoZSBEb20wIHRyYXBzIGFyZSBub3QgaW4gdGhpcyBzZXJpZXMsIGJ1
dA0KPj4+IGFyZSBpbiBtaW5lIGFzIGl0IG5lZWRzIG1vcmUgcHJlcGFyYXRvcnkgd29yayBmb3Ig
dGhhdC4gUGxlYXNlIHNlZSBbMV0NCj4+IFRoZW4gSSBkb24ndCB0aGluayB3ZSBzaG91bGQgc2V0
IFhFTl9ET01DVExfQ0RGX3ZwY2kgZm9yIGRvbTAgaGVyZSwgaXQNCj4+IHNob3VsZCBpbnN0ZWFk
IGJlIGRvbmUgaW4gdGhlIHBhdGNoIHdoZXJlIGRvbTAgc3VwcG9ydCBpcyBpbnRyb2R1Y2VkLg0K
PiBPayBJIHdpbGwgY2hlY2sgdG8gcmVtb3ZlIHRoaXMgYW5kIGluY2x1ZGUgdGhlIGNoYW5nZSBp
biB2Ni4NCkp1c3QgdG8gbWFrZSBpdCBjbGVhcjogZG8gd2Ugd2FudCB0byByZW1vdmUgdGhpcyBw
aWVjZSBmcm9tIHRoaXMgcGF0Y2gNCmFuZCBpbnN0ZWFkIGhhdmUgYSBkZWRpY2F0ZWQgcGF0Y2gg
b24gdG9wIG9mIG15IHNlcmllcywgc28gaXQgaXMgZW5hYmxlZA0KcmlnaHQgYWZ0ZXIgd2UgaGF2
ZSB0aGUgY29kZSB0aGF0IHNldHMgdXAgdGhlIHRyYXAgaGFuZGxlcnMgZm9yIERvbTA/DQpJZiBz
bywgdGhlbiBkbyB3ZSB3YW50IHRoYXQgcGF0Y2ggdG8gYmUgY2hhaW5lZCBpbiBteSBzZXJpZXMg
b3Igc2VudCBhcw0KYSBmb2xsb3cgdXAgcmlnaHQgYWZ0ZXIgaXQgc2VwYXJhdGVseT8NCg0KVGhh
bmtzLA0KT2xla3NhbmRyDQo+DQo+IENoZWVycw0KPiBCZXJ0cmFuZA0KPg0KPj4gVGhhbmtzLCBS
b2dlci4NCg==


From xen-devel-bounces@lists.xenproject.org Mon Oct 11 19:28:18 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 19:28:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.206516.362108 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ma0xu-0000Z5-HZ; Mon, 11 Oct 2021 19:28:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 206516.362108; Mon, 11 Oct 2021 19:28:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ma0xu-0000Yy-EI; Mon, 11 Oct 2021 19:28:02 +0000
Received: by outflank-mailman (input) for mailman id 206516;
 Mon, 11 Oct 2021 19:28:01 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=gQnf=O7=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1ma0xt-0000Ys-6c
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 19:28:01 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id a777ce03-fb62-44c7-8d60-4ecab70e03ff;
 Mon, 11 Oct 2021 19:27:59 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id 95F7E60555;
 Mon, 11 Oct 2021 19:27:58 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a777ce03-fb62-44c7-8d60-4ecab70e03ff
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1633980479;
	bh=d02FKdswlvpJ3+XHcAlVdRCv/88Vs0zDcQacreicA/M=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=Qcpb7unluM5R+OqOVECf85826qSXF1ZVjL1K73+6QP7288NL6wWr9pRAVLygGszBA
	 6u7hO0/ypqnJD0SO48umFEoKvpo24cEdxCa3/hUR/AKCHlP0YdV1ERt39urNL/ohpJ
	 bhvzoOT+GbtnsvgW6jbXGFNB/DmEhIcSaLARwg7pyOvSgNTeUxtt1aymfkF/3gjVuL
	 2JgM6Co2+XksASPw8463vTPx3xkQd1/JLdpxkcqju8ZctdB14twV9JtMrKest+ni9h
	 RT638vOE+fjiLgUvl0389/2w674MlxajgvEKno2cBWJrV8IAPfCuujrp1JsWHR88rI
	 X6M0Hd9sNfY2Q==
Date: Mon, 11 Oct 2021 12:27:56 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
cc: Bertrand Marquis <bertrand.marquis@arm.com>, 
    =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= <roger.pau@citrix.com>, 
    Rahul Singh <rahul.singh@arm.com>, 
    "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, 
    Andre Przywara <Andre.Przywara@arm.com>, 
    Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, 
    Andrew Cooper <andrew.cooper3@citrix.com>, 
    George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>, 
    Jan Beulich <jbeulich@suse.com>, Wei Liu <wl@xen.org>, 
    Paul Durrant <paul@xen.org>
Subject: Re: [PATCH v5 08/11] xen/arm: Enable the existing x86 virtual PCI
 support for ARM.
In-Reply-To: <611b61a4-9635-f1e6-a078-e40d4cbd49fd@epam.com>
Message-ID: <alpine.DEB.2.21.2110111226220.25528@sstabellini-ThinkPad-T480s>
References: <cover.1633540842.git.rahul.singh@arm.com> <9bdca2cda5d2e83f94dc2423e55714273539760a.1633540842.git.rahul.singh@arm.com> <YWQXF2vDaWQvi+bT@MacBook-Air-de-Roger.local> <4F406854-4F90-48F6-8470-6CCB60A3CB77@arm.com> <e199bfe2-0bcc-989f-fd4a-ecf44a3cd1ac@epam.com>
 <YWRpuUtHkyA4RY5H@MacBook-Air-de-Roger.local> <AF7AB609-3E79-4017-A296-CC7C87E1705F@arm.com> <611b61a4-9635-f1e6-a078-e40d4cbd49fd@epam.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="8323329-1433164912-1633980479=:25528"

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-1433164912-1633980479=:25528
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT

On Mon, 11 Oct 2021, Oleksandr Andrushchenko wrote:
> On 11.10.21 20:15, Bertrand Marquis wrote:
> > Hi Roger,
> >
> >> On 11 Oct 2021, at 17:43, Roger Pau Monné <roger.pau@citrix.com> wrote:
> >>
> >> On Mon, Oct 11, 2021 at 04:20:14PM +0000, Oleksandr Andrushchenko wrote:
> >>>
> >>> On 11.10.21 19:12, Bertrand Marquis wrote:
> >>>> Hi Roger,
> >>>>
> >>>>> On 11 Oct 2021, at 11:51, Roger Pau Monné <roger.pau@citrix.com> wrote:
> >>>>>
> >>>>> On Wed, Oct 06, 2021 at 06:40:34PM +0100, Rahul Singh wrote:
> >>>>>> The existing VPCI support available for X86 is adapted for Arm.
> >>>>>> When the device is added to XEN via the hyper call
> >>>>>> “PHYSDEVOP_pci_device_add”, VPCI handler for the config space
> >>>>>> access is added to the Xen to emulate the PCI devices config space.
> >>>>>>
> >>>>>> A MMIO trap handler for the PCI ECAM space is registered in XEN
> >>>>>> so that when guest is trying to access the PCI config space,XEN
> >>>>>> will trap the access and emulate read/write using the VPCI and
> >>>>>> not the real PCI hardware.
> >>>>>>
> >>>>>> For Dom0less systems scan_pci_devices() would be used to discover the
> >>>>>> PCI device in XEN and VPCI handler will be added during XEN boots.
> >>>>>>
> >>>>>> Signed-off-by: Rahul Singh <rahul.singh@arm.com>
> >>>>>> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
> >>>>>> ---
> >>>>>> Change in v5:
> >>>>>> - Add pci_cleanup_msi(pdev) in cleanup part.
> >>>>>> - Added Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
> >>>>>> Change in v4:
> >>>>>> - Move addition of XEN_DOMCTL_CDF_vpci flag to separate patch
> >>>>>> Change in v3:
> >>>>>> - Use is_pci_passthrough_enabled() in place of pci_passthrough_enabled variable
> >>>>>> - Reject XEN_DOMCTL_CDF_vpci for x86 in arch_sanitise_domain_config()
> >>>>>> - Remove IS_ENABLED(CONFIG_HAS_VPCI) from has_vpci()
> >>>>>> Change in v2:
> >>>>>> - Add new XEN_DOMCTL_CDF_vpci flag
> >>>>>> - modify has_vpci() to include XEN_DOMCTL_CDF_vpci
> >>>>>> - enable vpci support when pci-passthough option is enabled.
> >>>>>> ---
> >>>>>> ---
> >>>>>> xen/arch/arm/Makefile         |   1 +
> >>>>>> xen/arch/arm/domain.c         |   4 ++
> >>>>>> xen/arch/arm/domain_build.c   |   3 +
> >>>>>> xen/arch/arm/vpci.c           | 102 ++++++++++++++++++++++++++++++++++
> >>>>>> xen/arch/arm/vpci.h           |  36 ++++++++++++
> >>>>>> xen/drivers/passthrough/pci.c |  18 ++++++
> >>>>>> xen/include/asm-arm/domain.h  |   7 ++-
> >>>>>> xen/include/asm-x86/pci.h     |   2 -
> >>>>>> xen/include/public/arch-arm.h |   7 +++
> >>>>>> xen/include/xen/pci.h         |   2 +
> >>>>>> 10 files changed, 179 insertions(+), 3 deletions(-)
> >>>>>> create mode 100644 xen/arch/arm/vpci.c
> >>>>>> create mode 100644 xen/arch/arm/vpci.h
> >>>>>>
> >>>>>> diff --git a/xen/arch/arm/Makefile b/xen/arch/arm/Makefile
> >>>>>> index 44d7cc81fa..fb9c976ea2 100644
> >>>>>> --- a/xen/arch/arm/Makefile
> >>>>>> +++ b/xen/arch/arm/Makefile
> >>>>>> @@ -7,6 +7,7 @@ ifneq ($(CONFIG_NO_PLAT),y)
> >>>>>> obj-y += platforms/
> >>>>>> endif
> >>>>>> obj-$(CONFIG_TEE) += tee/
> >>>>>> +obj-$(CONFIG_HAS_VPCI) += vpci.o
> >>>>>>
> >>>>>> obj-$(CONFIG_HAS_ALTERNATIVE) += alternative.o
> >>>>>> obj-y += bootfdt.init.o
> >>>>>> diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
> >>>>>> index 36138c1b2e..fbb52f78f1 100644
> >>>>>> --- a/xen/arch/arm/domain.c
> >>>>>> +++ b/xen/arch/arm/domain.c
> >>>>>> @@ -39,6 +39,7 @@
> >>>>>> #include <asm/vgic.h>
> >>>>>> #include <asm/vtimer.h>
> >>>>>>
> >>>>>> +#include "vpci.h"
> >>>>>> #include "vuart.h"
> >>>>>>
> >>>>>> DEFINE_PER_CPU(struct vcpu *, curr_vcpu);
> >>>>>> @@ -767,6 +768,9 @@ int arch_domain_create(struct domain *d,
> >>>>>>      if ( is_hardware_domain(d) && (rc = domain_vuart_init(d)) )
> >>>>>>          goto fail;
> >>>>>>
> >>>>>> +    if ( (rc = domain_vpci_init(d)) != 0 )
> >>>>>> +        goto fail;
> >>>>>> +
> >>>>>>      return 0;
> >>>>>>
> >>>>>> fail:
> >>>>>> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
> >>>>>> index c5afbe2e05..f4c89bde8c 100644
> >>>>>> --- a/xen/arch/arm/domain_build.c
> >>>>>> +++ b/xen/arch/arm/domain_build.c
> >>>>>> @@ -3053,6 +3053,9 @@ void __init create_dom0(void)
> >>>>>>      if ( iommu_enabled )
> >>>>>>          dom0_cfg.flags |= XEN_DOMCTL_CDF_iommu;
> >>>>>>
> >>>>>> +    if ( is_pci_passthrough_enabled() )
> >>>>>> +        dom0_cfg.flags |= XEN_DOMCTL_CDF_vpci;
> >>>>> I think I'm confused with this. You seem to enable vPCI for dom0, but
> >>>>> then domain_vpci_init will setup traps for the guest virtual ECAM
> >>>>> layout, not the native one that dom0 will be using.
> >>>> I think after the last discussions, it was decided to also installed the vpci
> >>>> handler for dom0. I will have to look into this and come back to you.
> >>>> @Oleksandr: Could you comment on this.
> >>> Yes, we do trap Dom0 as well. The Dom0 traps are not in this series, but
> >>> are in mine as it needs more preparatory work for that. Please see [1]
> >> Then I don't think we should set XEN_DOMCTL_CDF_vpci for dom0 here, it
> >> should instead be done in the patch where dom0 support is introduced.
> > Ok I will check to remove this and include the change in v6.
> Just to make it clear: do we want to remove this piece from this patch
> and instead have a dedicated patch on top of my series, so it is enabled
> right after we have the code that sets up the trap handlers for Dom0?
> If so, then do we want that patch to be chained in my series or sent as
> a follow up right after it separately?

I think we want to remove the XEN_DOMCTL_CDF_vpci chunk from this patch.

Where exactly it should be introduced, I am not sure. I think it would
be OK as a separate single patch at the end. I doesn't have to be part
of the outstanding series, considering that we are also missing the
patch to add "select HAS_PCI" for ARM.
--8323329-1433164912-1633980479=:25528--


From xen-devel-bounces@lists.xenproject.org Mon Oct 11 19:38:22 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 19:38:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.206526.362118 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ma17q-00021G-H9; Mon, 11 Oct 2021 19:38:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 206526.362118; Mon, 11 Oct 2021 19:38:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ma17q-000219-E6; Mon, 11 Oct 2021 19:38:18 +0000
Received: by outflank-mailman (input) for mailman id 206526;
 Mon, 11 Oct 2021 19:38:17 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=gQnf=O7=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1ma17p-000213-BW
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 19:38:17 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id c6b762a0-2aca-11ec-80f4-12813bfff9fa;
 Mon, 11 Oct 2021 19:38:15 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id 0F77660698;
 Mon, 11 Oct 2021 19:38:14 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c6b762a0-2aca-11ec-80f4-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1633981094;
	bh=FmcGt5kBm2Ry9W+S9xL78X3lxQxoIDmnk/fEN2NBq9w=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=eIe680wNg9zCzNmegAoKnuL6nRtnjcftAK+C6f8lasOAP2nwemBIs1oMS9uXJsZSs
	 S+099WQEimXzJyBtnEO7NKxX6Fp1drdmaRlSs/t9xnCpT2Be/KelEXmWp5RI8iB47D
	 LZxjGKMYzP1u719LBlUU3hfvum8l75YBFVIjfWt77H9iJbY1b1xeR+bEUsY3YFwUId
	 blUlkLLGZQPb99a8/v0xdY8V2hUKjDP69amomFQAGWTclQVtNrj91BMqdkFxioGUjO
	 a9EJr+Xye5TWNOIgu22Cz2VWaBFjktLtN14CT92F/33KGyr86yaqftm3l7mA+SS3Sn
	 U04cMSjG+5Fdw==
Date: Mon, 11 Oct 2021 12:38:13 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Luca Fancellu <luca.fancellu@arm.com>
cc: xen-devel@lists.xenproject.org, bertrand.marquis@arm.com, wei.chen@arm.com, 
    Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, 
    Andrew Cooper <andrew.cooper3@citrix.com>, 
    George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>, 
    Jan Beulich <jbeulich@suse.com>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH v6 1/2] arm/efi: Use dom0less configuration when using
 EFI boot
In-Reply-To: <20211011181528.17367-2-luca.fancellu@arm.com>
Message-ID: <alpine.DEB.2.21.2110111235180.25528@sstabellini-ThinkPad-T480s>
References: <20211011181528.17367-1-luca.fancellu@arm.com> <20211011181528.17367-2-luca.fancellu@arm.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Mon, 11 Oct 2021, Luca Fancellu wrote:
> This patch introduces the support for dom0less configuration
> when using UEFI boot on ARM, it permits the EFI boot to
> continue if no dom0 kernel is specified but at least one domU
> is found.
> 
> Introduce the new property "xen,uefi-binary" for device tree boot
> module nodes that are subnode of "xen,domain" compatible nodes.
> The property holds a string containing the file name of the
> binary that shall be loaded by the uefi loader from the filesystem.
> 
> Introduce a new call efi_check_dt_boot(...) called during EFI boot
> that checks for module to be loaded using device tree.
> Architectures that don't support device tree don't have to
> provide this function.
> 
> Update efi documentation about how to start a dom0less
> setup using UEFI
> 
> Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>

Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>


> ---
> Changes in v6:
> - change is_boot_module() to check for every multiboot,module
> instead of multiboot,{kernel,ramdisk,device-tree} (Julien), as
> a result of that remove the function and put the check inside of
> handle_module_node(...)
> Changes in v5:
> - Removed unneeded variable initialization
> - Fixed comment
> - Fixed error message for the absence of an initial domain kernel
> - changed efi_arch_check_dt_boot to efi_check_dt_boot and add
> a stub if CONFIG_HAS_DEVICE_TREE is not declared, updated commit
> message about the call introduction in the EFI boot flow.
> Changes in v4:
> - update uefi,cfg-load to xen,uefi-cfg-load in documentation
> - fixed comments and code style
> - changed variable name from dt_module_found to dt_modules_found
> in boot.c
> - removed stub efi_arch_check_dt_boot from x86 code because the
> architecture does not support DT, protected call with #ifdef
> in the common code.
> - add comment to explain the result from efi_arch_check_dt_boot
> just looking the common code
> - Add space before comment in boot.c
> - renamed uefi,binary property to xen,uefi-binary
> Changes in v3:
> - fixed documentation
> - fixed name len in strlcpy
> - fixed some style issues
> - closed filesystem handle before calling blexit
> - passed runtime errors up to the stack instead
> of calling blexit
> - renamed names and function to make them more
> general in prevision to load also Dom0 kernel
> and ramdisk from DT
> Changes in v2:
> - remove array of struct file
> - fixed some int types
> - Made the code use filesystem even when configuration
> file is skipped.
> - add documentation of uefi,binary in booting.txt
> - add documentation on how to boot all configuration
> for Xen using UEFI in efi.pandoc
> ---
>  docs/misc/arm/device-tree/booting.txt |  21 ++
>  docs/misc/efi.pandoc                  | 203 +++++++++++++++++
>  xen/arch/arm/efi/efi-boot.h           | 299 +++++++++++++++++++++++++-
>  xen/common/efi/boot.c                 |  39 +++-
>  4 files changed, 550 insertions(+), 12 deletions(-)
> 
> diff --git a/docs/misc/arm/device-tree/booting.txt b/docs/misc/arm/device-tree/booting.txt
> index 352b0ec43a..7258e7e1ec 100644
> --- a/docs/misc/arm/device-tree/booting.txt
> +++ b/docs/misc/arm/device-tree/booting.txt
> @@ -190,6 +190,13 @@ The kernel sub-node has the following properties:
>  
>      Command line parameters for the guest kernel.
>  
> +- xen,uefi-binary (UEFI boot only)
> +
> +    String property that specifies the file name to be loaded by the UEFI boot
> +    for this module. If this is specified, there is no need to specify the reg
> +    property because it will be created by the UEFI stub on boot.
> +    This option is needed only when UEFI boot is used.
> +
>  The ramdisk sub-node has the following properties:
>  
>  - compatible
> @@ -201,6 +208,13 @@ The ramdisk sub-node has the following properties:
>      Specifies the physical address of the ramdisk in RAM and its
>      length.
>  
> +- xen,uefi-binary (UEFI boot only)
> +
> +    String property that specifies the file name to be loaded by the UEFI boot
> +    for this module. If this is specified, there is no need to specify the reg
> +    property because it will be created by the UEFI stub on boot.
> +    This option is needed only when UEFI boot is used.
> +
>  
>  Example
>  =======
> @@ -265,6 +279,13 @@ The dtb sub-node should have the following properties:
>      Specifies the physical address of the device tree binary fragment
>      RAM and its length.
>  
> +- xen,uefi-binary (UEFI boot only)
> +
> +    String property that specifies the file name to be loaded by the UEFI boot
> +    for this module. If this is specified, there is no need to specify the reg
> +    property because it will be created by the UEFI stub on boot.
> +    This option is needed only when UEFI boot is used.
> +
>  As an example:
>  
>          module@0xc000000 {
> diff --git a/docs/misc/efi.pandoc b/docs/misc/efi.pandoc
> index ed85351541..876cd55005 100644
> --- a/docs/misc/efi.pandoc
> +++ b/docs/misc/efi.pandoc
> @@ -167,3 +167,206 @@ sbsign \
>  	--output xen.signed.efi \
>  	xen.unified.efi
>  ```
> +
> +## UEFI boot and dom0less on ARM
> +
> +Dom0less feature is supported by ARM and it is possible to use it when Xen is
> +started as an EFI application.
> +The way to specify the domU domains is by Device Tree as specified in the
> +[dom0less](dom0less.html) documentation page under the "Device Tree
> +configuration" section, but instead of declaring the reg property in the boot
> +module, the user must specify the "xen,uefi-binary" property containing the name
> +of the binary file that has to be loaded in memory.
> +The UEFI stub will load the binary in memory and it will add the reg property
> +accordingly.
> +
> +An example here:
> +
> +domU1 {
> +	#address-cells = <1>;
> +	#size-cells = <1>;
> +	compatible = "xen,domain";
> +	memory = <0 0x20000>;
> +	cpus = <1>;
> +	vpl011;
> +
> +	module@1 {
> +		compatible = "multiboot,kernel", "multiboot,module";
> +		xen,uefi-binary = "vmlinuz-3.0.31-0.4-xen";
> +		bootargs = "console=ttyAMA0";
> +	};
> +	module@2 {
> +		compatible = "multiboot,ramdisk", "multiboot,module";
> +		xen,uefi-binary = "initrd-3.0.31-0.4-xen";
> +	};
> +	module@3 {
> +		compatible = "multiboot,ramdisk", "multiboot,module";
> +		xen,uefi-binary = "passthrough.dtb";
> +	};
> +};
> +
> +## How to boot different Xen setup using UEFI
> +
> +These are the different ways to boot a Xen system from UEFI:
> +
> + - Boot Xen and Dom0 (minimum required)
> + - Boot Xen and DomU(s) (true dom0less, only on ARM)
> + - Boot Xen, Dom0 and DomU(s) (only on ARM)
> +
> +### Boot Xen and Dom0
> +
> +This configuration can be started using the Xen configuration file in the
> +example above.
> +
> +### Boot Xen and DomU(s)
> +
> +This configuration needs the domU domain(s) specified in the /chosen node,
> +examples of how to do that are provided by the documentation about dom0less
> +and the example above shows how to use the "xen,uefi-binary" property to use the
> +UEFI stub for module loading.
> +When adding DomU modules to device tree, also add the property
> +xen,uefi-cfg-load under chosen for Xen to load the Xen config file.
> +Otherwise, Xen will skip the config file and rely on device tree alone.
> +
> +Example 1 of how to boot a true dom0less configuration:
> +
> +Xen configuration file: skipped.
> +
> +Device tree:
> +
> +```
> +chosen {
> +	#size-cells = <0x1>;
> +	#address-cells = <0x1>;
> +	xen,xen-bootargs = "<Xen command line>"
> +
> +	domU1 {
> +		#size-cells = <0x1>;
> +		#address-cells = <0x1>;
> +		compatible = "xen,domain";
> +		cpus = <0x1>;
> +		memory = <0x0 0xc0000>;
> +		vpl011;
> +
> +		module@1 {
> +			compatible = "multiboot,kernel", "multiboot,module";
> +			xen,uefi-binary = "Image-domu1.bin";
> +			bootargs = "console=ttyAMA0 root=/dev/ram0 rw";
> +		};
> +	};
> +	domU2 {
> +		#size-cells = <0x1>;
> +		#address-cells = <0x1>;
> +		compatible = "xen,domain";
> +		cpus = <0x1>;
> +		memory = <0x0 0x100000>;
> +		vpl011;
> +
> +		module@2 {
> +			compatible = "multiboot,kernel", "multiboot,module";
> +			xen,uefi-binary = "Image-domu2.bin";
> +			bootargs = "console=ttyAMA0 root=/dev/ram0 rw";
> +		};
> +	};
> +};
> +```
> +
> +Example 2 of how to boot a true dom0less configuration:
> +
> +Xen configuration file:
> +
> +```
> +[global]
> +default=xen
> +
> +[xen]
> +options=<Xen command line>
> +dtb=<optional DTB>
> +```
> +
> +Device tree:
> +
> +```
> +chosen {
> +	#size-cells = <0x1>;
> +	#address-cells = <0x1>;
> +	xen,uefi-cfg-load;
> +
> +	domU1 {
> +		#size-cells = <0x1>;
> +		#address-cells = <0x1>;
> +		compatible = "xen,domain";
> +		cpus = <0x1>;
> +		memory = <0x0 0xc0000>;
> +		vpl011;
> +
> +		module@1 {
> +			compatible = "multiboot,kernel", "multiboot,module";
> +			xen,uefi-binary = "Image-domu1.bin";
> +			bootargs = "console=ttyAMA0 root=/dev/ram0 rw";
> +		};
> +	};
> +	domU2 {
> +		#size-cells = <0x1>;
> +		#address-cells = <0x1>;
> +		compatible = "xen,domain";
> +		cpus = <0x1>;
> +		memory = <0x0 0x100000>;
> +		vpl011;
> +
> +		module@2 {
> +			compatible = "multiboot,kernel", "multiboot,module";
> +			xen,uefi-binary = "Image-domu2.bin";
> +			bootargs = "console=ttyAMA0 root=/dev/ram0 rw";
> +		};
> +	};
> +};
> +```
> +
> +### Boot Xen, Dom0 and DomU(s)
> +
> +This configuration is a mix of the two configuration above, to boot this one
> +the configuration file must be processed so the /chosen node must have the
> +"xen,uefi-cfg-load" property.
> +
> +Here an example:
> +
> +Xen configuration file:
> +
> +```
> +[global]
> +default=xen
> +
> +[xen]
> +options=<Xen command line>
> +kernel=vmlinuz-3.0.31-0.4-xen [domain 0 command line options]
> +ramdisk=initrd-3.0.31-0.4-xen
> +dtb=<optional DTB>
> +```
> +
> +Device tree:
> +
> +```
> +chosen {
> +	#size-cells = <0x1>;
> +	#address-cells = <0x1>;
> +	xen,uefi-cfg-load;
> +
> +	domU1 {
> +		#size-cells = <0x1>;
> +		#address-cells = <0x1>;
> +		compatible = "xen,domain";
> +		cpus = <0x1>;
> +		memory = <0x0 0xc0000>;
> +		vpl011;
> +
> +		module@1 {
> +			compatible = "multiboot,kernel", "multiboot,module";
> +			xen,uefi-binary = "Image-domu1.bin";
> +			bootargs = "console=ttyAMA0 root=/dev/ram0 rw";
> +		};
> +	};
> +};
> +```
> +
> +
> diff --git a/xen/arch/arm/efi/efi-boot.h b/xen/arch/arm/efi/efi-boot.h
> index a3e46453d4..f35e035b22 100644
> --- a/xen/arch/arm/efi/efi-boot.h
> +++ b/xen/arch/arm/efi/efi-boot.h
> @@ -8,9 +8,49 @@
>  #include <asm/setup.h>
>  #include <asm/smp.h>
>  
> +typedef struct {
> +    char *name;
> +    unsigned int name_len;
> +    EFI_PHYSICAL_ADDRESS addr;
> +    UINTN size;
> +} module_name;
> +
> +/*
> + * Binaries will be translated into bootmodules, the maximum number for them is
> + * MAX_MODULES where we should remove a unit for Xen and one for Xen DTB
> + */
> +#define MAX_UEFI_MODULES (MAX_MODULES - 2)
> +static struct file __initdata module_binary;
> +static module_name __initdata modules[MAX_UEFI_MODULES];
> +static unsigned int __initdata modules_available = MAX_UEFI_MODULES;
> +static unsigned int __initdata modules_idx;
> +
> +#define ERROR_BINARY_FILE_NOT_FOUND (-1)
> +#define ERROR_ALLOC_MODULE_NO_SPACE (-1)
> +#define ERROR_ALLOC_MODULE_NAME     (-2)
> +#define ERROR_MISSING_DT_PROPERTY   (-3)
> +#define ERROR_RENAME_MODULE_NAME    (-4)
> +#define ERROR_SET_REG_PROPERTY      (-5)
> +#define ERROR_CHECK_MODULE_COMPAT   (-6)
> +#define ERROR_DT_MODULE_DOMU        (-1)
> +#define ERROR_DT_CHOSEN_NODE        (-2)
> +
>  void noreturn efi_xen_start(void *fdt_ptr, uint32_t fdt_size);
>  void __flush_dcache_area(const void *vaddr, unsigned long size);
>  
> +static int get_module_file_index(const char *name, unsigned int name_len);
> +static void PrintMessage(const CHAR16 *s);
> +static int allocate_module_file(EFI_FILE_HANDLE dir_handle,
> +                                const char *name,
> +                                unsigned int name_len);
> +static int handle_module_node(EFI_FILE_HANDLE dir_handle,
> +                              int module_node_offset,
> +                              int reg_addr_cells,
> +                              int reg_size_cells);
> +static int handle_dom0less_domain_node(EFI_FILE_HANDLE dir_handle,
> +                                       int domain_node);
> +static int efi_check_dt_boot(EFI_FILE_HANDLE dir_handle);
> +
>  #define DEVICE_TREE_GUID \
>  {0xb1b621d5, 0xf19c, 0x41a5, {0x83, 0x0b, 0xd9, 0x15, 0x2c, 0x69, 0xaa, 0xe0}}
>  
> @@ -552,8 +592,254 @@ static void __init efi_arch_handle_module(const struct file *file,
>                           kernel.size) < 0 )
>              blexit(L"Unable to set reg property.");
>      }
> -    else
> +    else if ( file != &module_binary )
> +        /*
> +         * If file is not a dom0 module file and it's not a domU module,
> +         * stop here.
> +         */
>          blexit(L"Unknown module type");
> +
> +    /*
> +     * modules_available is decremented here because for each dom0 file added
> +     * from the configuration file, there will be an additional bootmodule,
> +     * so the number of available slots will be decremented because there is a
> +     * maximum amount of bootmodules that can be loaded.
> +     */
> +    modules_available--;
> +}
> +
> +/*
> + * This function checks for a binary previously loaded with a give name, it
> + * returns the index of the file in the modules array or a negative number if no
> + * file with that name is found.
> + */
> +static int __init get_module_file_index(const char *name,
> +                                        unsigned int name_len)
> +{
> +    unsigned int i;
> +    int ret = ERROR_BINARY_FILE_NOT_FOUND;
> +
> +    for ( i = 0; i < modules_idx; i++ )
> +    {
> +        module_name *mod = &modules[i];
> +        if ( (mod->name_len == name_len) &&
> +             (strncmp(mod->name, name, name_len) == 0) )
> +        {
> +            ret = i;
> +            break;
> +        }
> +    }
> +    return ret;
> +}
> +
> +static void __init PrintMessage(const CHAR16 *s)
> +{
> +    PrintStr(s);
> +    PrintStr(newline);
> +}
> +
> +/*
> + * This function allocates a binary and keeps track of its name, it returns the
> + * index of the file in the modules array or a negative number on error.
> + */
> +static int __init allocate_module_file(EFI_FILE_HANDLE dir_handle,
> +                                       const char *name,
> +                                       unsigned int name_len)
> +{
> +    module_name *file_name;
> +    union string module_name;
> +    int ret;
> +
> +    /*
> +     * Check if there is any space left for a module, the variable
> +     * modules_available is updated each time we use read_file(...)
> +     * successfully.
> +     */
> +    if ( !modules_available )
> +    {
> +        PrintMessage(L"No space left for modules");
> +        return ERROR_ALLOC_MODULE_NO_SPACE;
> +    }
> +
> +    module_name.cs = name;
> +    ret = modules_idx;
> +
> +    /* Save at this index the name of this binary */
> +    file_name = &modules[ret];
> +
> +    if ( efi_bs->AllocatePool(EfiLoaderData, (name_len + 1) * sizeof(char),
> +                              (void**)&file_name->name) != EFI_SUCCESS )
> +    {
> +        PrintMessage(L"Error allocating memory for module binary name");
> +        return ERROR_ALLOC_MODULE_NAME;
> +    }
> +
> +    /* Save name and length of the binary in the data structure */
> +    strlcpy(file_name->name, name, name_len + 1);
> +    file_name->name_len = name_len;
> +
> +    /* Load the binary in memory */
> +    read_file(dir_handle, s2w(&module_name), &module_binary, NULL);
> +
> +    /* Save address and size */
> +    file_name->addr = module_binary.addr;
> +    file_name->size = module_binary.size;
> +
> +    /* s2w(...) allocates some memory, free it */
> +    efi_bs->FreePool(module_name.w);
> +
> +    modules_idx++;
> +
> +    return ret;
> +}
> +
> +/*
> + * This function checks for the presence of the xen,uefi-binary property in the
> + * module, if found it loads the binary as module and sets the right address
> + * for the reg property into the module DT node.
> + */
> +static int __init handle_module_node(EFI_FILE_HANDLE dir_handle,
> +                                     int module_node_offset,
> +                                     int reg_addr_cells,
> +                                     int reg_size_cells)
> +{
> +    const void *uefi_name_prop;
> +    char mod_string[24]; /* Placeholder for module@ + a 64-bit number + \0 */
> +    int uefi_name_len, file_idx, module_compat;
> +    module_name *file;
> +
> +    /* Check if the node is a multiboot,module otherwise return */
> +    module_compat = fdt_node_check_compatible(fdt, module_node_offset,
> +                                              "multiboot,module");
> +    if ( module_compat < 0 )
> +        /* Error while checking the compatible string */
> +        return ERROR_CHECK_MODULE_COMPAT;
> +
> +    if ( module_compat != 0 )
> +        /* Module is not a multiboot,module */
> +        return 0;
> +
> +    /* Read xen,uefi-binary property to get the file name. */
> +    uefi_name_prop = fdt_getprop(fdt, module_node_offset, "xen,uefi-binary",
> +                                 &uefi_name_len);
> +
> +    if ( !uefi_name_prop )
> +        /* Property not found */
> +        return 0;
> +
> +    file_idx = get_module_file_index(uefi_name_prop, uefi_name_len);
> +    if ( file_idx < 0 )
> +    {
> +        file_idx = allocate_module_file(dir_handle, uefi_name_prop,
> +                                        uefi_name_len);
> +        if ( file_idx < 0 )
> +            return file_idx;
> +    }
> +
> +    file = &modules[file_idx];
> +
> +    snprintf(mod_string, sizeof(mod_string), "module@%"PRIx64, file->addr);
> +
> +    /* Rename the module to be module@{address} */
> +    if ( fdt_set_name(fdt, module_node_offset, mod_string) < 0 )
> +    {
> +        PrintMessage(L"Unable to modify module node name.");
> +        return ERROR_RENAME_MODULE_NAME;
> +    }
> +
> +    if ( fdt_set_reg(fdt, module_node_offset, reg_addr_cells, reg_size_cells,
> +                     file->addr, file->size) < 0 )
> +    {
> +        PrintMessage(L"Unable to set module reg property.");
> +        return ERROR_SET_REG_PROPERTY;
> +    }
> +
> +    return 0;
> +}
> +
> +/*
> + * This function checks for boot modules under the domU guest domain node
> + * in the DT.
> + * Returns 0 on success, negative number on error.
> + */
> +static int __init handle_dom0less_domain_node(EFI_FILE_HANDLE dir_handle,
> +                                              int domain_node)
> +{
> +    int module_node, addr_cells, size_cells, len;
> +    const struct fdt_property *prop;
> +
> +    /* Get #address-cells and #size-cells from domain node */
> +    prop = fdt_get_property(fdt, domain_node, "#address-cells", &len);
> +    if ( !prop )
> +    {
> +        PrintMessage(L"#address-cells not found in domain node.");
> +        return ERROR_MISSING_DT_PROPERTY;
> +    }
> +
> +    addr_cells = fdt32_to_cpu(*((uint32_t *)prop->data));
> +
> +    prop = fdt_get_property(fdt, domain_node, "#size-cells", &len);
> +    if ( !prop )
> +    {
> +        PrintMessage(L"#size-cells not found in domain node.");
> +        return ERROR_MISSING_DT_PROPERTY;
> +    }
> +
> +    size_cells = fdt32_to_cpu(*((uint32_t *)prop->data));
> +
> +    /* Check for nodes compatible with multiboot,module inside this node */
> +    for ( module_node = fdt_first_subnode(fdt, domain_node);
> +          module_node > 0;
> +          module_node = fdt_next_subnode(fdt, module_node) )
> +    {
> +        int ret = handle_module_node(dir_handle, module_node, addr_cells,
> +                                        size_cells);
> +        if ( ret < 0 )
> +            return ret;
> +    }
> +
> +    return 0;
> +}
> +
> +/*
> + * This function checks for xen domain nodes under the /chosen node for possible
> + * domU guests to be loaded.
> + * Returns the number of modules loaded or a negative number for error.
> + */
> +static int __init efi_check_dt_boot(EFI_FILE_HANDLE dir_handle)
> +{
> +    int chosen, node, addr_len, size_len;
> +    unsigned int i = 0;
> +
> +    /* Check for the chosen node in the current DTB */
> +    chosen = setup_chosen_node(fdt, &addr_len, &size_len);
> +    if ( chosen < 0 )
> +    {
> +        PrintMessage(L"Unable to setup chosen node");
> +        return ERROR_DT_CHOSEN_NODE;
> +    }
> +
> +    /* Check for nodes compatible with xen,domain under the chosen node */
> +    for ( node = fdt_first_subnode(fdt, chosen);
> +          node > 0;
> +          node = fdt_next_subnode(fdt, node) )
> +    {
> +        if ( !fdt_node_check_compatible(fdt, node, "xen,domain") )
> +        {
> +            /* Found a node with compatible xen,domain; handle this node. */
> +            if ( handle_dom0less_domain_node(dir_handle, node) < 0 )
> +                return ERROR_DT_MODULE_DOMU;
> +        }
> +    }
> +
> +    /* Free boot modules file names if any */
> +    for ( ; i < modules_idx; i++ )
> +    {
> +        /* Free boot modules binary names */
> +        efi_bs->FreePool(modules[i].name);
> +    }
> +
> +    return modules_idx;
>  }
>  
>  static void __init efi_arch_cpu(void)
> @@ -562,8 +848,19 @@ static void __init efi_arch_cpu(void)
>  
>  static void __init efi_arch_blexit(void)
>  {
> +    unsigned int i = 0;
> +
>      if ( dtbfile.need_to_free )
>          efi_bs->FreePages(dtbfile.addr, PFN_UP(dtbfile.size));
> +    /* Free boot modules file names if any */
> +    for ( ; i < modules_idx; i++ )
> +    {
> +        /* Free boot modules binary names */
> +        efi_bs->FreePool(modules[i].name);
> +        /* Free modules binaries */
> +        efi_bs->FreePages(modules[i].addr,
> +                          PFN_UP(modules[i].size));
> +    }
>      if ( memmap )
>          efi_bs->FreePool(memmap);
>  }
> diff --git a/xen/common/efi/boot.c b/xen/common/efi/boot.c
> index 758f9d74d2..7879b93f93 100644
> --- a/xen/common/efi/boot.c
> +++ b/xen/common/efi/boot.c
> @@ -166,6 +166,13 @@ static void __init PrintErr(const CHAR16 *s)
>      StdErr->OutputString(StdErr, (CHAR16 *)s );
>  }
>  
> +#ifndef CONFIG_HAS_DEVICE_TREE
> +static inline int __init efi_check_dt_boot(EFI_FILE_HANDLE dir_handle)
> +{
> +    return 0;
> +}
> +#endif
> +
>  /*
>   * Include architecture specific implementation here, which references the
>   * static globals defined above.
> @@ -1136,6 +1143,8 @@ efi_start(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE *SystemTable)
>      bool base_video = false;
>      const char *option_str;
>      bool use_cfg_file;
> +    int dt_modules_found;
> +    EFI_FILE_HANDLE dir_handle;
>  
>      __set_bit(EFI_BOOT, &efi_flags);
>      __set_bit(EFI_LOADER, &efi_flags);
> @@ -1216,9 +1225,11 @@ efi_start(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE *SystemTable)
>  
>      efi_arch_relocate_image(0);
>  
> +    /* Get the file system interface. */
> +    dir_handle = get_parent_handle(loaded_image, &file_name);
> +
>      if ( use_cfg_file )
>      {
> -        EFI_FILE_HANDLE dir_handle;
>          UINTN depth, cols, rows, size;
>  
>          size = cols = rows = depth = 0;
> @@ -1229,9 +1240,6 @@ efi_start(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE *SystemTable)
>  
>          gop = efi_get_gop();
>  
> -        /* Get the file system interface. */
> -        dir_handle = get_parent_handle(loaded_image, &file_name);
> -
>          /* Read and parse the config file. */
>          if ( read_section(loaded_image, L"config", &cfg, NULL) )
>              PrintStr(L"Using builtin config file\r\n");
> @@ -1285,14 +1293,12 @@ efi_start(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE *SystemTable)
>              efi_bs->FreePool(name.w);
>          }
>  
> -        if ( !name.s )
> -            blexit(L"No Dom0 kernel image specified.");
> -
>          efi_arch_cfg_file_early(loaded_image, dir_handle, section.s);
>  
> -        option_str = split_string(name.s);
> +        option_str = name.s ? split_string(name.s) : NULL;
>  
> -        if ( !read_section(loaded_image, L"kernel", &kernel, option_str) )
> +        if ( !read_section(loaded_image, L"kernel", &kernel, option_str) &&
> +             name.s )
>          {
>              read_file(dir_handle, s2w(&name), &kernel, option_str);
>              efi_bs->FreePool(name.w);
> @@ -1361,12 +1367,23 @@ efi_start(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE *SystemTable)
>          efi_bs->FreePages(cfg.addr, PFN_UP(cfg.size));
>          cfg.addr = 0;
>  
> -        dir_handle->Close(dir_handle);
> -
>          if ( gop && !base_video )
>              gop_mode = efi_find_gop_mode(gop, cols, rows, depth);
>      }
>  
> +    /* Get the number of boot modules specified on the DT or an error (<0) */
> +    dt_modules_found = efi_check_dt_boot(dir_handle);
> +
> +    dir_handle->Close(dir_handle);
> +
> +    if ( dt_modules_found < 0 )
> +        /* efi_check_dt_boot throws some error */
> +        blexit(L"Error processing boot modules on DT.");
> +
> +    /* Check if at least one of Dom0 or DomU(s) is specified */
> +    if ( !dt_modules_found && !kernel.ptr )
> +        blexit(L"No initial domain kernel specified.");
> +
>      efi_arch_edd();
>  
>      /* XXX Collect EDID info. */
> -- 
> 2.17.1
> 


From xen-devel-bounces@lists.xenproject.org Mon Oct 11 19:53:32 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 19:53:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.206536.362130 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ma1MT-0004Jg-Vg; Mon, 11 Oct 2021 19:53:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 206536.362130; Mon, 11 Oct 2021 19:53:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ma1MT-0004JZ-Sn; Mon, 11 Oct 2021 19:53:25 +0000
Received: by outflank-mailman (input) for mailman id 206536;
 Mon, 11 Oct 2021 19:53:24 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=gQnf=O7=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1ma1MS-0004JT-KF
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 19:53:24 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id e43827a4-2acc-11ec-80f4-12813bfff9fa;
 Mon, 11 Oct 2021 19:53:23 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id 8434A60F5B;
 Mon, 11 Oct 2021 19:53:22 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e43827a4-2acc-11ec-80f4-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1633982002;
	bh=x6nuLNNO0CSS+lqXe6rR81flILAADJkHmjOTAhqx8cM=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=BZRm0oFwrZO9qGHaPZqbXrFSgjE89zt273wrOYUeu8q44op3iTpUGBlYwUgO3nyV0
	 CR9WpEm6jHX336DJHXXncyREZNTnBqzg6/VpvuwKJjrEMIcha9/rJ222CA0fjFQbe9
	 icleOSYMA29PNBFs9FGvfuMgjlGvBmnDUTlob9syf8Hn4twIXbRjoctovn3WF1/V2m
	 aBhXljw/J6Sk8DwlAN0HEgFx8c93OdUSI7N9cYjB9inEylKfS1KvglHQJK1IO+iVIZ
	 VhmCzbfs4sl7rEsPogSVfJCI4VOh8p7eZcb+Y/x7Euim6VN7LjFJNlPbcskRKhLfz9
	 VEFfJyS9CWzLg==
Date: Mon, 11 Oct 2021 12:53:21 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Luca Fancellu <luca.fancellu@arm.com>
cc: xen-devel@lists.xenproject.org, bertrand.marquis@arm.com, wei.chen@arm.com, 
    Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, 
    Andrew Cooper <andrew.cooper3@citrix.com>, 
    George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>, 
    Jan Beulich <jbeulich@suse.com>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH v6 2/2] arm/efi: load dom0 modules from DT using UEFI
In-Reply-To: <20211011181528.17367-3-luca.fancellu@arm.com>
Message-ID: <alpine.DEB.2.21.2110111243290.25528@sstabellini-ThinkPad-T480s>
References: <20211011181528.17367-1-luca.fancellu@arm.com> <20211011181528.17367-3-luca.fancellu@arm.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Mon, 11 Oct 2021, Luca Fancellu wrote:
> Add support to load Dom0 boot modules from
> the device tree using the xen,uefi-binary property.
> 
> Update documentation about that.
> 
> Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>

Unfortunately, due to the change to the previous patch, this patch now
has one issue, see below.


> @@ -754,6 +760,41 @@ static int __init handle_module_node(EFI_FILE_HANDLE dir_handle,
>          return ERROR_SET_REG_PROPERTY;
>      }
>  
> +    if ( !is_domu_module )
> +    {
> +        if ( (fdt_node_check_compatible(fdt, module_node_offset,
> +                                    "multiboot,kernel") == 0) )
> +        {
> +            /*
> +            * This is the Dom0 kernel, wire it to the kernel variable because it
> +            * will be verified by the shim lock protocol later in the common
> +            * code.
> +            */
> +            if ( kernel.addr )
> +            {
> +                PrintMessage(L"Dom0 kernel already found in cfg file.");
> +                return ERROR_DOM0_ALREADY_FOUND;
> +            }
> +            kernel.need_to_free = false; /* Freed using the module array */
> +            kernel.addr = file->addr;
> +            kernel.size = file->size;
> +        }
> +        else if ( ramdisk.addr &&
> +                  (fdt_node_check_compatible(fdt, module_node_offset,
> +                                             "multiboot,ramdisk") == 0) )
> +        {
> +            PrintMessage(L"Dom0 ramdisk already found in cfg file.");
> +            return ERROR_DOM0_RAMDISK_FOUND;
> +        }
> +        else if ( xsm.addr &&
> +                  (fdt_node_check_compatible(fdt, module_node_offset,
> +                                             "xen,xsm-policy") == 0) )
> +        {
> +            PrintMessage(L"XSM policy already found in cfg file.");
> +            return ERROR_XSM_ALREADY_FOUND;
> +        }
> +    }
> +
>      return 0;
>  }
>  
> @@ -793,7 +834,7 @@ static int __init handle_dom0less_domain_node(EFI_FILE_HANDLE dir_handle,
>            module_node = fdt_next_subnode(fdt, module_node) )
>      {
>          int ret = handle_module_node(dir_handle, module_node, addr_cells,
> -                                        size_cells);
> +                                     size_cells, true);
>          if ( ret < 0 )
>              return ret;
>      }
> @@ -803,7 +844,7 @@ static int __init handle_dom0less_domain_node(EFI_FILE_HANDLE dir_handle,
>  
>  /*
>   * This function checks for xen domain nodes under the /chosen node for possible
> - * domU guests to be loaded.
> + * dom0 and domU guests to be loaded.
>   * Returns the number of modules loaded or a negative number for error.
>   */
>  static int __init efi_check_dt_boot(EFI_FILE_HANDLE dir_handle)
> @@ -830,6 +871,9 @@ static int __init efi_check_dt_boot(EFI_FILE_HANDLE dir_handle)
>              if ( handle_dom0less_domain_node(dir_handle, node) < 0 )
>                  return ERROR_DT_MODULE_DOMU;
>          }
> +        else if ( handle_module_node(dir_handle, node, addr_len, size_len,
> +                                     false) < 0 )
> +                 return ERROR_DT_MODULE_DOM0;
>      }

handle_module_node comes with a "multiboot,module" compatible check now,
which is fine for dom0less DomU modules, but it is not OK for dom0
modules.

That is because it is also possible to write the dom0 modules (kernel
and ramdisk) with the following compabile strings:

/chosen/dom0 compatible "xen,linux-zimage" "xen,multiboot-module"
/chosen/dom0-ramdisk compatible "xen,linux-initrd" "xen,multiboot-module"

They are legacy but we are not meant to break support for them. Also
third party tools might still use them -- I checked and even
ImageBuilder still uses them.

One way to solve the problem is to make the "multiboot,module"
compatible check at the beginning of handle_module_node conditional on
!is_domu_module.

Or maybe just ignore compabible errors if !is_domu_module. Something like:

diff --git a/xen/arch/arm/efi/efi-boot.h b/xen/arch/arm/efi/efi-boot.h
index 840728d6c0..cbfcd55449 100644
--- a/xen/arch/arm/efi/efi-boot.h
+++ b/xen/arch/arm/efi/efi-boot.h
@@ -721,7 +721,7 @@ static int __init handle_module_node(EFI_FILE_HANDLE dir_handle,
         /* Error while checking the compatible string */
         return ERROR_CHECK_MODULE_COMPAT;
 
-    if ( module_compat != 0 )
+    if ( is_domu_module && module_compat != 0 )
         /* Module is not a multiboot,module */
         return 0;
 


From xen-devel-bounces@lists.xenproject.org Mon Oct 11 20:00:19 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 20:00:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.206544.362141 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ma1T6-0005pe-NH; Mon, 11 Oct 2021 20:00:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 206544.362141; Mon, 11 Oct 2021 20:00:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ma1T6-0005pX-KH; Mon, 11 Oct 2021 20:00:16 +0000
Received: by outflank-mailman (input) for mailman id 206544;
 Mon, 11 Oct 2021 20:00:15 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=gQnf=O7=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1ma1T5-0005pR-9g
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 20:00:15 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id d8ac4d2e-2acd-11ec-80f4-12813bfff9fa;
 Mon, 11 Oct 2021 20:00:13 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id AD22E6052B;
 Mon, 11 Oct 2021 20:00:12 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d8ac4d2e-2acd-11ec-80f4-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1633982413;
	bh=ygTf15c1Vzl9hOp5eIAKzulGVPoWhgm/vsmgtPkfFDA=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=Ncqsgkb4WISD6mB0k3p884YO2Aao/2S5U37DTNdQQuBsT09BKNNhPeLOPGOAIYgDz
	 3mGqe/J+AuxSOM8NLsXRmjMUDt32X2otE3uvnfi5nnIN4NucUmd0XEKklMn98zPUSC
	 Poctbcb1LyFiDtJkiqoXuVyMISNf0LIs187rh4gQdu6Vvt77BpsnhR2U1+xC+SwZo/
	 IDlxLYHtoJAJfCj76twkFKLCEvoqvtblH19FPjORkYzDQ8GeB52A738BqLc5lqDYp8
	 1QqeNjO9awApyxrxFD8A98UF/okKyBuD8OEUM1D1J5F7Y3w9aI5n72xx+9Z4jSExxE
	 Pc7xwi+nmrFKw==
Date: Mon, 11 Oct 2021 13:00:12 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Oleksandr Tyshchenko <olekstysh@gmail.com>
cc: xen-devel@lists.xenproject.org, 
    Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, 
    Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>, 
    Anthony PERARD <anthony.perard@citrix.com>, 
    Juergen Gross <jgross@suse.com>, 
    Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH V6 2/2] libxl/arm: Add handling of extended regions for
 DomU
In-Reply-To: <1633974539-7380-3-git-send-email-olekstysh@gmail.com>
Message-ID: <alpine.DEB.2.21.2110111300030.25528@sstabellini-ThinkPad-T480s>
References: <1633974539-7380-1-git-send-email-olekstysh@gmail.com> <1633974539-7380-3-git-send-email-olekstysh@gmail.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Mon, 11 Oct 2021, Oleksandr Tyshchenko wrote:
> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> 
> The extended region (safe range) is a region of guest physical
> address space which is unused and could be safely used to create
> grant/foreign mappings instead of wasting real RAM pages from
> the domain memory for establishing these mappings.
> 
> The extended regions are chosen at the domain creation time and
> advertised to it via "reg" property under hypervisor node in
> the guest device-tree. As region 0 is reserved for grant table
> space (always present), the indexes for extended regions are 1...N.
> If extended regions could not be allocated for some reason,
> Xen doesn't fail and behaves as usual, so only inserts region 0.
> 
> Please note the following limitations:
> - The extended region feature is only supported for 64-bit domain
>   currently.
> - The ACPI case is not covered.
> 
> ***
> 
> The algorithm to choose extended regions for non-direct mapped
> DomU is simpler in comparison with the algorithm for direct mapped
> Dom0. We usually have a lot of unused space above 4GB, and might
> have some unused space below 4GB (depends on guest memory size).
> Try to allocate separate 2MB-aligned extended regions from the first
> (below 4GB) and second (above 4GB) RAM banks taking into the account
> the maximum supported guest physical address space size and the amount
> of memory assigned to the guest. The minimum size of extended region
> the same as for Dom0 (64MB).
> 
> Suggested-by: Julien Grall <jgrall@amazon.com>
> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>

Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>


> ---
> Changes RFC -> V2:
>    - update patch description
>    - drop uneeded "extended-region" DT property
>    - clear reg array in finalise_ext_region() and add a TODO
> 
> Changes V2 -> V3:
>    - update patch description, comments in code
>    - only pick up regions with size >= 64MB
>    - move the region calculation to make_hypervisor_node() and drop
>      finalise_ext_region()
>    - extend the list of arguments for make_hypervisor_node()
>    - do not show warning for 32-bit domain
>    - change the region alignment from 1GB to 2MB
>    - move EXT_REGION_SIZE to public/arch-arm.h
> 
> Changes V3 -> V4:
>    - add R-b, A-b and T-b
> 
> Changes V4 -> V5:
>    - update patch description and comments in code
>    - reflect changes done in previous patch to pass gpaddr_bits
>      via createdomain domctl (struct xen_arch_domainconfig)
>    - drop R-b, A-b and T-b
>    - drop limit for maximum extended region size (128GB)
>    - try to also allocate region below 4GB, optimize code
>      for calculating extended regions
> 
> Change V5 -> V6:
>    - reflect changes done in previous patch to pass gpaddr_bits
>      via getdomaininfo domctl (struct xen_domctl_getdomaininfo)
>    - reduce the number of local variables, rework calculations
> ---
>  tools/libs/light/libxl_arm.c  | 76 ++++++++++++++++++++++++++++++++++++++++---
>  xen/include/public/arch-arm.h |  2 ++
>  2 files changed, 73 insertions(+), 5 deletions(-)
> 
> diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c
> index e3140a6..c0e8415 100644
> --- a/tools/libs/light/libxl_arm.c
> +++ b/tools/libs/light/libxl_arm.c
> @@ -598,9 +598,20 @@ static int make_timer_node(libxl__gc *gc, void *fdt,
>      return 0;
>  }
>  
> +#define ALIGN_UP_TO_2MB(x)   (((x) + MB(2) - 1) & (~(MB(2) - 1)))
> +
>  static int make_hypervisor_node(libxl__gc *gc, void *fdt,
> -                                const libxl_version_info *vers)
> +                                const libxl_version_info *vers,
> +                                const libxl_domain_build_info *b_info,
> +                                const struct xc_dom_image *dom)
>  {
> +    uint64_t region_size[GUEST_RAM_BANKS] = {0}, region_base[GUEST_RAM_BANKS],
> +        bank1end, ramsize;
> +    uint32_t regs[(GUEST_ROOT_ADDRESS_CELLS + GUEST_ROOT_SIZE_CELLS) *
> +                  (GUEST_RAM_BANKS + 1)];
> +    be32 *cells = &regs[0];
> +    unsigned int i, len, nr_regions = 0;
> +    libxl_dominfo info;
>      int res;
>      gic_interrupt intr;
>  
> @@ -615,9 +626,64 @@ static int make_hypervisor_node(libxl__gc *gc, void *fdt,
>                                "xen,xen");
>      if (res) return res;
>  
> -    /* reg 0 is grant table space */
> -    res = fdt_property_regs(gc, fdt, GUEST_ROOT_ADDRESS_CELLS, GUEST_ROOT_SIZE_CELLS,
> -                            1,GUEST_GNTTAB_BASE, GUEST_GNTTAB_SIZE);
> +    if (strcmp(dom->guest_type, "xen-3.0-aarch64")) {
> +        LOG(WARN, "The extended regions are only supported for 64-bit guest currently");
> +        goto out;
> +    }
> +
> +    res = libxl_domain_info(CTX, &info, dom->guest_domid);
> +    if (res) return res;
> +
> +    assert(info.gpaddr_bits >= 32 && info.gpaddr_bits <= 48);
> +
> +    /*
> +     * Try to allocate separate 2MB-aligned extended regions from the first
> +     * (below 4GB) and second (above 4GB) RAM banks taking into the account
> +     * the maximum supported guest physical address space size and the amount
> +     * of memory assigned to the guest.
> +     * As the guest memory layout is not populated yet we cannot rely on
> +     * dom->rambank_size[], so calculate the actual size of both banks using
> +     * "max_memkb" value.
> +     */
> +    ramsize = b_info->max_memkb * 1024;
> +    if (ramsize <= GUEST_RAM0_SIZE) {
> +        region_base[0] = GUEST_RAM0_BASE + ALIGN_UP_TO_2MB(ramsize);
> +        region_size[0] = GUEST_RAM0_SIZE - ALIGN_UP_TO_2MB(ramsize);
> +        region_base[1] = GUEST_RAM1_BASE;
> +    } else
> +        region_base[1] = GUEST_RAM1_BASE +
> +            ALIGN_UP_TO_2MB(ramsize - GUEST_RAM0_SIZE);
> +
> +    bank1end = min(1ULL << info.gpaddr_bits, GUEST_RAM1_BASE + GUEST_RAM1_SIZE);
> +    if (bank1end > region_base[1])
> +        region_size[1] = bank1end - region_base[1];
> +
> +out:
> +    /*
> +     * The region 0 for grant table space must be always present. If we managed
> +     * to allocate the extended regions then insert them as regions 1...N.
> +     */
> +    set_range(&cells, GUEST_ROOT_ADDRESS_CELLS, GUEST_ROOT_SIZE_CELLS,
> +              GUEST_GNTTAB_BASE, GUEST_GNTTAB_SIZE);
> +
> +    for (i = 0; i < GUEST_RAM_BANKS; i++) {
> +        if (region_size[i] < GUEST_EXT_REGION_MIN_SIZE)
> +            continue;
> +
> +        LOG(DEBUG, "Extended region %u: %#"PRIx64"->%#"PRIx64"\n",
> +            nr_regions, region_base[i], region_base[i] + region_size[i]);
> +
> +        set_range(&cells, GUEST_ROOT_ADDRESS_CELLS, GUEST_ROOT_SIZE_CELLS,
> +                  region_base[i], region_size[i]);
> +        nr_regions++;
> +    }
> +
> +    if (!nr_regions)
> +        LOG(WARN, "The extended regions cannot be allocated, not enough space");
> +
> +    len = sizeof(regs[0]) * (GUEST_ROOT_ADDRESS_CELLS + GUEST_ROOT_SIZE_CELLS) *
> +        (nr_regions + 1);
> +    res = fdt_property(fdt, "reg", regs, len);
>      if (res) return res;
>  
>      /*
> @@ -963,7 +1029,7 @@ next_resize:
>          }
>  
>          FDT( make_timer_node(gc, fdt, ainfo, state->clock_frequency) );
> -        FDT( make_hypervisor_node(gc, fdt, vers) );
> +        FDT( make_hypervisor_node(gc, fdt, vers, info, dom) );
>  
>          if (info->arch_arm.vuart == LIBXL_VUART_TYPE_SBSA_UART)
>              FDT( make_vpl011_uart_node(gc, fdt, ainfo, dom) );
> diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h
> index d46c61f..19ca2b0 100644
> --- a/xen/include/public/arch-arm.h
> +++ b/xen/include/public/arch-arm.h
> @@ -451,6 +451,8 @@ typedef uint64_t xen_callback_t;
>  #define GUEST_RAM_BANK_BASES   { GUEST_RAM0_BASE, GUEST_RAM1_BASE }
>  #define GUEST_RAM_BANK_SIZES   { GUEST_RAM0_SIZE, GUEST_RAM1_SIZE }
>  
> +#define GUEST_EXT_REGION_MIN_SIZE   xen_mk_ullong(0x0004000000) /* 64MB */
> +
>  /* Current supported guest VCPUs */
>  #define GUEST_MAX_VCPUS 128
>  
> -- 
> 2.7.4
> 


From xen-devel-bounces@lists.xenproject.org Mon Oct 11 20:01:14 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 20:01:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.206549.362152 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ma1U2-0006OT-2j; Mon, 11 Oct 2021 20:01:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 206549.362152; Mon, 11 Oct 2021 20:01:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ma1U1-0006OM-Ud; Mon, 11 Oct 2021 20:01:13 +0000
Received: by outflank-mailman (input) for mailman id 206549;
 Mon, 11 Oct 2021 20:01:12 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=gQnf=O7=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1ma1U0-0006OC-MB
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 20:01:12 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id fad2822e-2acd-11ec-80f4-12813bfff9fa;
 Mon, 11 Oct 2021 20:01:11 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id DF41960C40;
 Mon, 11 Oct 2021 20:01:09 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fad2822e-2acd-11ec-80f4-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1633982470;
	bh=z8EHoqVn2Sjd6bgr7U+pfFNBL09N8RkT9cd6vV2089A=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=Ie68kSqA5hsAGO08Jd7+GwzW11lICJ5VZmQy+m3b5HQAL719dTJJzrc0oKxB5XF1a
	 Waz0WKKk8VDez1fEJtGsiCOqL450s7R3eiLITtiyCipepFgF7LxNE9V7gSR4cecRHl
	 V9xy6kWwoSpU96tBAp0+lH8tkTlR1MqbMKOE59Rl/zMgZGjOr0xU/zPjO1OAf4F7EG
	 O/eYrPaecVBJCza52QLP+FSaBB1ogTXl+aIzb/xj/9bhRS3YPAk4dRNjYorlzMmzXB
	 p4dZxotfv+JN/JS8vRZ115PqVnhN2o0Gs/CsIDgs659XK4hrx6cSV8ha18sSEpeKr/
	 m58Eoa313km+A==
Date: Mon, 11 Oct 2021 13:01:09 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Oleksandr Tyshchenko <olekstysh@gmail.com>
cc: xen-devel@lists.xenproject.org, 
    Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, 
    Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>, 
    Anthony PERARD <anthony.perard@citrix.com>, 
    Andrew Cooper <andrew.cooper3@citrix.com>, 
    George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>, 
    Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>, 
    Juergen Gross <jgross@suse.com>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, 
    =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= <roger.pau@citrix.com>
Subject: Re: [PATCH V6 1/2] xen/arm: Introduce gpaddr_bits field to struct
 xen_domctl_getdomaininfo
In-Reply-To: <1633974539-7380-2-git-send-email-olekstysh@gmail.com>
Message-ID: <alpine.DEB.2.21.2110111300160.25528@sstabellini-ThinkPad-T480s>
References: <1633974539-7380-1-git-send-email-olekstysh@gmail.com> <1633974539-7380-2-git-send-email-olekstysh@gmail.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Mon, 11 Oct 2021, Oleksandr Tyshchenko wrote:
> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> 
> We need to pass info about maximum supported guest physical
> address space size to the toolstack on Arm in order to properly
> calculate the base and size of the extended region (safe range)
> for the guest. The extended region is unused address space which
> could be safely used by domain for foreign/grant mappings on Arm.
> The extended region itself will be handled by the subsequent
> patch.
> 
> Currently the same guest physical address space size is used
> for all guests (p2m_ipa_bits variable on Arm, the x86 equivalent
> is hap_paddr_bits).
> 
> As we add new field to the structure bump the interface version.
> 
> Suggested-by: Julien Grall <jgrall@amazon.com>
> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>

I couldn't spot any errors in this patch


> ---
> Changes RFC -> V2:
>    - update patch subject/description
>    - replace arch-specific sub-struct with common gpaddr_bits
>      field and update code to reflect that
> 
> Changes V2 -> V3:
>    - make the field uint8_t and add uint8_t pad[7] after
>    - remove leading blanks in libxl.h
> 
> Changes V3 -> V4:
>    - also print gpaddr_bits from output_physinfo()
>    - add Michal's R-b
> 
> Changes V4 -> V5:
>    - update patch subject and description
>    - drop Michal's R-b
>    - pass gpaddr_bits via createdomain domctl
>      (struct xen_arch_domainconfig)
> 
> Changes V5 -> V6:
>    - update patch subject and description
>    - pass gpaddr_bits via getdomaininfo domctl
>      (struct xen_domctl_getdomaininfo)
> ---
>  tools/include/libxl.h            | 8 ++++++++
>  tools/include/xenctrl.h          | 1 +
>  tools/libs/ctrl/xc_domain.c      | 1 +
>  tools/libs/light/libxl_domain.c  | 1 +
>  tools/libs/light/libxl_types.idl | 1 +
>  xen/arch/arm/domctl.c            | 2 ++
>  xen/arch/x86/domctl.c            | 1 +
>  xen/include/public/domctl.h      | 3 ++-
>  8 files changed, 17 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/include/libxl.h b/tools/include/libxl.h
> index b9ba16d..deb5022 100644
> --- a/tools/include/libxl.h
> +++ b/tools/include/libxl.h
> @@ -874,6 +874,14 @@ typedef struct libxl__ctx libxl_ctx;
>  #define LIBXL_HAVE_DOMINFO_NEVER_STOP 1
>  
>  /*
> + * LIBXL_HAVE_DOMINFO_GPADDR_BITS
> + *
> + * If this is defined, libxl_dominfo will contain an uint8 field called
> + * gpaddr_bits, containing the guest physical address space size.
> + */
> +#define LIBXL_HAVE_DOMINFO_GPADDR_BITS 1
> +
> +/*
>   * LIBXL_HAVE_QXL
>   *
>   * If defined, then the libxl_vga_interface_type will contain another value:
> diff --git a/tools/include/xenctrl.h b/tools/include/xenctrl.h
> index a306399..07b96e6 100644
> --- a/tools/include/xenctrl.h
> +++ b/ tools/include/xenctrl.h
> @@ -462,6 +462,7 @@ typedef struct xc_dominfo {
>      unsigned int  max_vcpu_id;
>      xen_domain_handle_t handle;
>      unsigned int  cpupool;
> +    uint8_t       gpaddr_bits;
>      struct xen_arch_domainconfig arch_config;
>  } xc_dominfo_t;
>  
> diff --git a/tools/libs/ctrl/xc_domain.c b/tools/libs/ctrl/xc_domain.c
> index 23322b7..b155d6a 100644
> --- a/tools/libs/ctrl/xc_domain.c
> +++ b/tools/libs/ctrl/xc_domain.c
> @@ -396,6 +396,7 @@ int xc_domain_getinfo(xc_interface *xch,
>          info->nr_online_vcpus = domctl.u.getdomaininfo.nr_online_vcpus;
>          info->max_vcpu_id = domctl.u.getdomaininfo.max_vcpu_id;
>          info->cpupool = domctl.u.getdomaininfo.cpupool;
> +        info->gpaddr_bits = domctl.u.getdomaininfo.gpaddr_bits;
>          info->arch_config = domctl.u.getdomaininfo.arch_config;
>  
>          memcpy(info->handle, domctl.u.getdomaininfo.handle,
> diff --git a/tools/libs/light/libxl_domain.c b/tools/libs/light/libxl_domain.c
> index 51a6127..544a9bf 100644
> --- a/tools/libs/light/libxl_domain.c
> +++ b/tools/libs/light/libxl_domain.c
> @@ -306,6 +306,7 @@ void libxl__xcinfo2xlinfo(libxl_ctx *ctx,
>      xlinfo->vcpu_max_id = xcinfo->max_vcpu_id;
>      xlinfo->vcpu_online = xcinfo->nr_online_vcpus;
>      xlinfo->cpupool = xcinfo->cpupool;
> +    xlinfo->gpaddr_bits = xcinfo->gpaddr_bits;
>      xlinfo->domain_type = (xcinfo->flags & XEN_DOMINF_hvm_guest) ?
>          LIBXL_DOMAIN_TYPE_HVM : LIBXL_DOMAIN_TYPE_PV;
>  }
> diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_types.idl
> index 3f9fff6..2df7258 100644
> --- a/tools/libs/light/libxl_types.idl
> +++ b/tools/libs/light/libxl_types.idl
> @@ -357,6 +357,7 @@ libxl_dominfo = Struct("dominfo",[
>      ("vcpu_max_id", uint32),
>      ("vcpu_online", uint32),
>      ("cpupool",     uint32),
> +    ("gpaddr_bits", uint8),
>      ("domain_type", libxl_domain_type),
>      ], dir=DIR_OUT)
>  
> diff --git a/xen/arch/arm/domctl.c b/xen/arch/arm/domctl.c
> index b7d27f3..6245af6 100644
> --- a/xen/arch/arm/domctl.c
> +++ b/xen/arch/arm/domctl.c
> @@ -20,6 +20,8 @@ void arch_get_domain_info(const struct domain *d,
>  {
>      /* All ARM domains use hardware assisted paging. */
>      info->flags |= XEN_DOMINF_hap;
> +
> +    info->gpaddr_bits = p2m_ipa_bits;
>  }
>  
>  static int handle_vuart_init(struct domain *d, 
> diff --git a/xen/arch/x86/domctl.c b/xen/arch/x86/domctl.c
> index 26a76d2..7d102e0 100644
> --- a/xen/arch/x86/domctl.c
> +++ b/xen/arch/x86/domctl.c
> @@ -151,6 +151,7 @@ void arch_get_domain_info(const struct domain *d,
>          info->flags |= XEN_DOMINF_hap;
>  
>      info->arch_config.emulation_flags = d->arch.emulation_flags;
> +    info->gpaddr_bits = hap_paddr_bits;
>  }
>  
>  static int do_vmtrace_op(struct domain *d, struct xen_domctl_vmtrace_op *op,
> diff --git a/xen/include/public/domctl.h b/xen/include/public/domctl.h
> index 4cb3f66..b93f776 100644
> --- a/xen/include/public/domctl.h
> +++ b/xen/include/public/domctl.h
> @@ -38,7 +38,7 @@
>  #include "hvm/save.h"
>  #include "memory.h"
>  
> -#define XEN_DOMCTL_INTERFACE_VERSION 0x00000014
> +#define XEN_DOMCTL_INTERFACE_VERSION 0x00000015
>  
>  /*
>   * NB. xen_domctl.domain is an IN/OUT parameter for this operation.
> @@ -150,6 +150,7 @@ struct xen_domctl_getdomaininfo {
>      uint32_t ssidref;
>      xen_domain_handle_t handle;
>      uint32_t cpupool;
> +    uint8_t gpaddr_bits; /* Guest physical address space size. */
>      struct xen_arch_domainconfig arch_config;
>  };
>  typedef struct xen_domctl_getdomaininfo xen_domctl_getdomaininfo_t;
> -- 
> 2.7.4
> 


From xen-devel-bounces@lists.xenproject.org Mon Oct 11 20:09:49 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 20:09:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.206558.362162 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ma1cE-000789-T7; Mon, 11 Oct 2021 20:09:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 206558.362162; Mon, 11 Oct 2021 20:09:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ma1cE-000782-QI; Mon, 11 Oct 2021 20:09:42 +0000
Received: by outflank-mailman (input) for mailman id 206558;
 Mon, 11 Oct 2021 20:09:42 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=gQnf=O7=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1ma1cE-00077w-0Z
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 20:09:42 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 2ad9d5e8-2acf-11ec-80f4-12813bfff9fa;
 Mon, 11 Oct 2021 20:09:41 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id 8B0F160E54;
 Mon, 11 Oct 2021 20:09:39 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2ad9d5e8-2acf-11ec-80f4-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1633982980;
	bh=jnGaE5g/va4Gc5z2OyMEuCE0QBZfW5iZSXLNifEFSII=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=Unzv9EK64YQz3uVZtUGAJJfNOsQ30yyX0KUIazox6INRg/kEKq5Oebasr85VxE5jf
	 7xoq0TvelF+/ETMIu3f3p9PnaVWduCg9RLWxsx15+IajJ40J3ov7vuU9d8mUtSL2SZ
	 iQ+x5Fk2k3z3q8BWQ8BDuiw+5ol5nhrSmPr1WRPWq26y32Ns0qv6WwdPuVixoLOVWe
	 UV/3DBoQHaq+0BnPjLoklHa9YXLK69wL9Bti0I48mBXZH2eZ36tFdFoMpCL1WIDO0b
	 oVj0L11M9fQMfXWFPOtbXNTwlrudU9LLxmaL5xZQq754uqm+JKNmqGomNplH2XMAeF
	 E4wfNM8DksjVQ==
Date: Mon, 11 Oct 2021 13:09:38 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Michal Orzel <michal.orzel@arm.com>
cc: xen-devel@lists.xenproject.org, Ian Jackson <iwj@xenproject.org>, 
    Wei Liu <wl@xen.org>, Andrew Cooper <andrew.cooper3@citrix.com>, 
    George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>, 
    Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>, 
    Nick Rosbrook <rosbrookn@ainfosec.com>, 
    Anthony PERARD <anthony.perard@citrix.com>, 
    Juergen Gross <jgross@suse.com>, 
    Christian Lindig <christian.lindig@citrix.com>, 
    David Scott <dave@recoil.org>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, bertrand.marquis@arm.com
Subject: Re: [PATCH v4 3/3] xen: Expose the PMU to the guests
In-Reply-To: <20211011090047.8878-4-michal.orzel@arm.com>
Message-ID: <alpine.DEB.2.21.2110111308230.25528@sstabellini-ThinkPad-T480s>
References: <20211011090047.8878-1-michal.orzel@arm.com> <20211011090047.8878-4-michal.orzel@arm.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Mon, 11 Oct 2021, Michal Orzel wrote:
> Add parameter vpmu to xl domain configuration syntax
> to enable the access to PMU registers by disabling
> the PMU traps(currently only for ARM).
> 
> The current status is that the PMU registers are not
> virtualized and the physical registers are directly
> accessible when this parameter is enabled. There is no
> interrupt support and Xen will not save/restore the
> register values on context switches.
> 
> Please note that this feature is experimental.
> 
> Signed-off-by: Michal Orzel <michal.orzel@arm.com>
> Signed-off-by: Julien Grall <julien@xen.org>
> Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>

I just wanted to say that I don't have any further comments on this
patch (I saw the ones from Julien which are fine)



From xen-devel-bounces@lists.xenproject.org Mon Oct 11 20:13:30 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 20:13:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.206566.362174 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ma1fo-00007A-Fs; Mon, 11 Oct 2021 20:13:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 206566.362174; Mon, 11 Oct 2021 20:13:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ma1fo-00006w-Ck; Mon, 11 Oct 2021 20:13:24 +0000
Received: by outflank-mailman (input) for mailman id 206566;
 Mon, 11 Oct 2021 20:13:23 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ma1fn-00006k-BC; Mon, 11 Oct 2021 20:13:23 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ma1fn-0005Mc-5n; Mon, 11 Oct 2021 20:13:23 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ma1fm-000349-S2; Mon, 11 Oct 2021 20:13:22 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ma1fm-0002Om-RY; Mon, 11 Oct 2021 20:13:22 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=6D1HwSNNLoWCebA8dRh8OezYR31HRZIu545hST/wsAQ=; b=Zs+ZCUeY/oTJmcM9P5mDK9xw1H
	JYb1zLHg7sehnYy3Q306zNpYljO3VcsAeIkfNpwufjYnypi55CTgZiq1tE60w5hDyNhrflre2XyT7
	+CdXWtkMu6RMmRPkjBDq5+FaICTER3scgeqsLtnLgh9lmKAU9AKYxquahANae+ZpYGdw=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165463-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-5.4 test] 165463: regressions - FAIL
X-Osstest-Failures:
    linux-5.4:test-armhf-armhf-xl-credit1:guest-start:fail:regression
    linux-5.4:test-arm64-arm64-libvirt-raw:debian-di-install:fail:heisenbug
    linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:heisenbug
    linux-5.4:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:heisenbug
    linux-5.4:test-amd64-amd64-xl-multivcpu:guest-stop:fail:heisenbug
    linux-5.4:test-amd64-amd64-examine:memdisk-try-append:fail:heisenbug
    linux-5.4:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    linux-5.4:test-arm64-arm64-libvirt-raw:guest-start/debian.repeat:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=faaca480fd5cd1976b6db743c43ac1f8d583de72
X-Osstest-Versions-That:
    linux=e74e2950a0d6f800858e54860d7124c86e494f62
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 11 Oct 2021 20:13:22 +0000

flight 165463 linux-5.4 real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165463/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-armhf-armhf-xl-credit1  14 guest-start              fail REGR. vs. 165206

Tests which are failing intermittently (not blocking):
 test-arm64-arm64-libvirt-raw 12 debian-di-install fail in 165458 pass in 165463
 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail in 165458 pass in 165463
 test-amd64-amd64-xl-rtds     20 guest-localmigrate/x10     fail pass in 165449
 test-amd64-amd64-xl-multivcpu 21 guest-stop                fail pass in 165458
 test-amd64-amd64-examine      4 memdisk-try-append         fail pass in 165458
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 165458

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-libvirt-raw 17 guest-start/debian.repeat fail in 165449 like 165206
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165206
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 165206
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 165206
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 165206
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165206
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165206
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 165206
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 165206
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 165206
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 165206
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 165206
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 165206
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 linux                faaca480fd5cd1976b6db743c43ac1f8d583de72
baseline version:
 linux                e74e2950a0d6f800858e54860d7124c86e494f62

Last test of basis   165206  2021-09-26 12:42:13 Z   15 days
Failing since        165346  2021-10-04 12:42:32 Z    7 days   10 attempts
Testing same since   165449  2021-10-09 23:12:14 Z    1 days    4 attempts

------------------------------------------------------------
People who touched revisions under test:
  Alan Stern <stern@rowland.harvard.edu>
  Alex Deucher <alexander.deucher@amd.com>
  Alexei Starovoitov <ast@kernel.org>
  Anand K Mistry <amistry@google.com>
  Anders Roxell <anders.roxell@linaro.org>
  Andrea Claudi <aclaudi@redhat.com>
  Andreas Larsson <andreas@gaisler.com>
  Andrej Shadura <andrew.shadura@collabora.co.uk>
  Andrew Morton <akpm@linux-foundation.org>
  Andy Shevchenko <andriy.shevchenko@linux.intel.com>
  Anirudh Rayabharam <mail@anirudhrb.com>
  Anson Jacob <Anson.Jacob@amd.com>
  Antoine Tenart <atenart@kernel.org>
  Anton Eidelman <anton.eidelman@gmail.com>
  Anton Eidelman <anton@lightbitslabs.com>
  Ariel Elior <aelior@marvell.com>
  Arnd Bergmann <arnd@arndb.de>
  Aswath Govindraju <a-govindraju@ti.com>
  Aya Levin <ayal@nvidia.com>
  Baokun Li <libaokun1@huawei.com>
  Bartosz Golaszewski <brgl@bgdev.pl>
  Bixuan Cui <cuibixuan@huawei.com>
  Bjorn Helgaas <bhelgaas@google.com>
  Borislav Petkov <bp@suse.de>
  Carlo Lobrano <c.lobrano@gmail.com>
  Catalin Marinas <catalin.marinas@arm.com>
  Changbin Du <changbin.du@gmail.com>
  Charlene Liu <Charlene.Liu@amd.com>
  Chen Jingwen <chenjingwen6@huawei.com>
  Chih-Kang Chang <gary.chang@realtek.com>
  Chris Chiu <chris.chiu@canonical.com>
  Christian Brauner <christian.brauner@ubuntu.com>
  Christoph Hellwig <hch@lst.de>
  Claudiu Manoil <claudiu.manoil@nxp.com>
  Cong Wang <cong.wang@bytedance.com>
  Dan Carpenter <dan.carpenter@oracle.com>
  Dan Li <ashimida@linux.alibaba.com>
  Dan Williams <dan.j.williams@intel.com>
  Daniel Borkmann <daniel@iogearbox.net>
  Daniel Lezcano <daniel.lezcano@linaro.org>
  Daniel Wheeler <daniel.wheeler@amd.com>
  David Howells <dhowells@redhat.com>
  David S. Miller <davem@davemloft.net>
  David Sterba <dsterba@suse.com>
  Dmitry Bogdanov <d.bogdanov@yadro.com>
  Dongliang Mu <mudongliangabcd@gmail.com>
  Eric Biggers <ebiggers@google.com>
  Eric Dumazet <edumazet@google.com>
  F.A. SULAIMAN <asha.16@itfac.mrt.ac.lk>
  F.A.Sulaiman <asha.16@itfac.mrt.ac.lk>
  Faizel K B <faizel.kb@dicortech.com>
  Fares Mehanna <faresx@amazon.de>
  Felipe Balbi <balbi@kernel.org>
  Florian Fainelli <f.fainelli@gmail.com>
  Gao Xiang <hsiangkao@linux.alibaba.com>
  Geert Uytterhoeven <geert@linux-m68k.org>
  Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  Gregory CLEMENT <gregory.clement@bootlin.com>
  Guangbin Huang <huangguangbin2@huawei.com>
  Guenter Roeck <linux@roeck-us.net>
  Hans de Goede <hdegoede@redhat.com>
  Helge Deller <deller@gmx.de>
  Herbert Xu <herbert@gondor.apana.org.au>
  Hulk Robot <hulkrobot@huawei.com>
  Igor Matheus Andrade Torrente <igormtorrente@gmail.com>
  J. Bruce Fields <bfields@redhat.com>
  Jacob Keller <jacob.e.keller@intel.com>
  James Morse <james.morse@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Jan Kara <jack@suse.cz>
  Jeffle Xu <jefflexu@linux.alibaba.com>
  Jens Axboe <axboe@kernel.dk>
  Jesper Nilsson <jesper.nilsson@axis.com>
  Jian Shen <shenjian15@huawei.com>
  Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
  Jiri Benc <jbenc@redhat.com>
  Jiri Kosina <jkosina@suse.cz>
  Jiri Slaby <jslaby@suse.cz>
  Johan Hovold <johan@kernel.org>
  Johannes Berg <johannes.berg@intel.com>
  Johannes Thumshirn <jth@kernel.org>
  John Allen <john.allen@amd.com>
  Jon Hunter <jonathanh@nvidia.com>
  Jonathan Hsu <jonathan.hsu@mediatek.com>
  Jozsef Kadlecsik <kadlec@netfilter.org>
  Juergen Gross <jgross@suse.com>
  Julian Anastasov <ja@ssi.bg>
  Julian Sikorski <belegdol+github@gmail.com>
  Julian Sikorski <belegdol@gmail.com>
  Kaige Fu <kaige.fu@linux.alibaba.com>
  Kan Liang <kan.liang@linux.intel.com>
  Karsten Graul <kgraul@linux.ibm.com>
  Kate Hsuan <hpa@redhat.com>
  Kevin Hao <haokexin@gmail.com>
  Kishon Vijay Abraham I <kishon@ti.com>
  Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
  Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
  Leon Yu <leoyu@nvidia.com>
  Li Jinlin <lijinlin3@huawei.com>
  Li Zhijian <lizhijian@cn.fujitsu.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Linux Kernel Functional Testing <lkft@linaro.org>
  Lorenzo Bianconi <lorenzo@kernel.org>
  Marc Zyngier <maz@kernel.org>
  Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
  Mark Rutland <mark.rutland@arm.com>
  Markus Suvanto <markus.suvanto@gmail.com>
  Martin K. Petersen <martin.petersen@oracle.com>
  Michael Chan <michael.chan@broadcom.com>
  Michael Chan <michael.chan@broadocm.com>
  Michal Kalderon <mkalderon@marvell.com>
  Minas Harutyunyan <Minas.Harutyunyan@synopsys.com>
  Ming Lei <ming.lei@redhat.com>
  Moritz Fischer <mdf@kernel.org>
  Nadezda Lutovinova <lutovinova@ispras.ru>
  Nicolas Ferre <nicolas.ferre@microchip.com>
  Nirmoy Das <nirmoy.das@amd.com>
  Oliver Neukum <oneukum@suse.com>
  Ondrej Zary <linux@zary.sk>
  Ovidiu Panait <ovidiu.panait@windriver.com>
  Pablo Neira Ayuso <pablo@netfilter.org>
  Pali Rohár <pali@kernel.org>
  Paolo Bonzini <pbonzini@redhat.com>
  Paul Fertser <fercerpav@gmail.com>
  Pawel Laszczak <pawell@cadence.com>
  Peter Zijlstra (Intel) <peterz@infradead.org>
  Ping-Ke Shih <pkshih@realtek.com>
  Qu Wenruo <wqu@suse.com>
  Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
  Randy Dunlap <rdunlap@infradead.org>
  Rik van Riel <riel@surriel.com>
  Ritesh Harjani <riteshh@linux.ibm.com>
  Rob Herring <robh@kernel.org>
  Ronnie Sahlberg <lsahlber@redhat.com>
  Sai Krishna Potthuri <lakshmi.sai.krishna.potthuri@xilinx.com>
  Samuel Iglesias Gonsalvez <siglesias@igalia.com>
  Sasha Levin <sashal@kernel.org>
  Sergey Senozhatsky <senozhatsky@chromium.org>
  Shai Malin <smalin@marvell.com>
  Shuah Khan <skhan@linuxfoundation.org>
  Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
  Simon Horman <horms@verge.net.au>
  Slark Xiao <slark_xiao@163.com>
  Song Liu <songliubraving@fb.com>
  Srinivas Pandruvada <srinivas.pI andruvada@linux.intel.com>
  Steve French <stfrench@microsoft.com>
  Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
  sumiyawang <sumiyawang@tencent.com>
  syzbot+47b26cd837ececfc666d@syzkaller.appspotmail.com
  syzbot+fadc0aaf497e6a493b9f@syzkaller.appspotmail.com
  Tariq Toukan <tariqt@nvidia.com>
  Tejun Heo <tj@kernel.org>
  Theodore Ts'o <tytso@mit.edu>
  Todd Kjos <tkjos@google.com>
  Tom Rix <trix@redhat.com>
  Tong Zhang <ztong0001@gmail.com>
  Tony Nguyen <anthony.l.nguyen@intel.com>
  Tyler Hicks <tyhicks@linux.microsoft.com>
  Uwe Brandt <uwe.brandt@gmail.com>
  Vadim Pasternak <vadimp@nvidia.com>
  Viresh Kumar <viresh.kumar@linaro.org>
  Vlad Buslov <vladbu@nvidia.com>
  Vladimir Oltean <vladimir.oltean@nxp.com>
  Wen Xiong <wenxiong@linux.ibm.com>
  Wengang Wang <wen.gang.wang@oracle.com>
  Xiao Liang <shaw.leon@gmail.com>
  Xin Long <lucien.xin@gmail.com>
  Yang Yingliang <yangyingliang@huawei.com>
  yangerkun <yangerkun@huawei.com>
  Yonghong Song <yhs@fb.com>
  Zelin Deng <zelin.deng@linux.alibaba.com>
  zhang kai <zhangkaiheb@126.com>
  Zhihao Cheng <chengzhihao1@huawei.com>
  Zong-Zhe Yang <kevin_yang@realtek.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                fail    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     fail    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 4201 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Oct 11 20:51:32 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 20:51:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.206578.362188 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ma2GX-0004CD-G1; Mon, 11 Oct 2021 20:51:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 206578.362188; Mon, 11 Oct 2021 20:51:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ma2GX-0004C6-Cm; Mon, 11 Oct 2021 20:51:21 +0000
Received: by outflank-mailman (input) for mailman id 206578;
 Mon, 11 Oct 2021 20:51:20 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=RBe3=O7=arm.com=Luca.Fancellu@srs-us1.protection.inumbo.net>)
 id 1ma2GV-0004C0-Sz
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 20:51:20 +0000
Received: from EUR01-VE1-obe.outbound.protection.outlook.com (unknown
 [40.107.14.58]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 91d17c0b-df7e-42db-8734-6b7d7826bfe8;
 Mon, 11 Oct 2021 20:51:16 +0000 (UTC)
Received: from AS9PR06CA0047.eurprd06.prod.outlook.com (2603:10a6:20b:463::9)
 by AM6PR08MB3558.eurprd08.prod.outlook.com (2603:10a6:20b:4b::23)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.22; Mon, 11 Oct
 2021 20:51:13 +0000
Received: from VE1EUR03FT045.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:463:cafe::74) by AS9PR06CA0047.outlook.office365.com
 (2603:10a6:20b:463::9) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.24 via Frontend
 Transport; Mon, 11 Oct 2021 20:51:13 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT045.mail.protection.outlook.com (10.152.19.51) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4587.18 via Frontend Transport; Mon, 11 Oct 2021 20:51:12 +0000
Received: ("Tessian outbound 16951d3c485e:v103");
 Mon, 11 Oct 2021 20:51:12 +0000
Received: from 9f7ae8fc2c5e.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 7328E317-07D6-4FD6-A56B-78C6F9D1476A.1; 
 Mon, 11 Oct 2021 20:51:01 +0000
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 9f7ae8fc2c5e.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Mon, 11 Oct 2021 20:51:01 +0000
Received: from PAXPR08MB6816.eurprd08.prod.outlook.com (2603:10a6:102:130::10)
 by PR3PR08MB5737.eurprd08.prod.outlook.com (2603:10a6:102:8d::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.19; Mon, 11 Oct
 2021 20:50:57 +0000
Received: from PAXPR08MB6816.eurprd08.prod.outlook.com
 ([fe80::c1b4:db1c:376f:b697]) by PAXPR08MB6816.eurprd08.prod.outlook.com
 ([fe80::c1b4:db1c:376f:b697%8]) with mapi id 15.20.4587.026; Mon, 11 Oct 2021
 20:50:56 +0000
Received: from smtpclient.apple (82.8.129.65) by
 LO4P123CA0134.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:193::13) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4587.21 via Frontend Transport; Mon, 11 Oct 2021 20:50:55 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 91d17c0b-df7e-42db-8734-6b7d7826bfe8
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=SNemV4gf7a+b81w5t+Zct0XOrs8mV92FZOXmLyMBxyc=;
 b=RUxyUkfz7F+tPd3PkU2HigOeh/CSomv0vQ1HGvYamndP4rXgoZSxXHIyxDHjIx9nErABlu7nD+pMUmgMBM7JeXQlzvj5qwbgGiSoiBrKJs8ZAHdOJAtj+ajbP4FcEshfK1BO0C4LF32vkFJTsaY/GEUU+dszowvfrbjv9KW81AI=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 9c4bfe3572ff330e
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=OPayyTSbwi3I/9sbw0FYUmXkx3uB1+UZo0k7wTf8Qp6UYR6x++OFrXPWIBX/LUaGM/WCrbMD/JYFTIqQAclnu6oZfADZr6cGNbA71vB0nQOTXUWKcRVKJK+P90yAC2vcbprOAjeW/lPH1egXj0V6CNuoml+JY7egTm2IwPJ2vJkAza9Kcqd1f5sZJW/M40/gM25DXd0J2lGBGbN1GB0ym4WmGERJgjTEITmERP3rAQNfPbIakE/JkkzLc3SrKopk0BMBNCVRV0WPO/qqfG59McjURE76XvKraC67Z+Vm3lwBfMy8J/rVhk9fSNFI8uCcDsypbIo0DjFTR6K7/BW41w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=SNemV4gf7a+b81w5t+Zct0XOrs8mV92FZOXmLyMBxyc=;
 b=fshpUbghtzRoMM1lXpHYuz1a1IDMtRhKUJRgsmQ7XFkamAkHvJ2/wjmyy2Te/qlDuufITBu5mZtc/dhHuFroazEe/wO8/QLti7av68wv5y+foRXgl3WaduBgNvEsWNHdRDpMct7ZEuuOplTDJybUiHPkQ5yQQh8tkRUdixECqioSpqmcaJ9+YIlOEdi8VvuK6aTrm8S58/yhyqXazeKM6L8uBbuhYltvpOMk5aOZ9m3rusG9On4ruqYHl2UaYrmseaeppWPXh8nHvvZpqQcIx3zJAzTMIsvCgLgJmPAnPJRiX96hkiN6yoxS3yoPik/RhPKucPoNr5qAYcjN1eJIbA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=SNemV4gf7a+b81w5t+Zct0XOrs8mV92FZOXmLyMBxyc=;
 b=RUxyUkfz7F+tPd3PkU2HigOeh/CSomv0vQ1HGvYamndP4rXgoZSxXHIyxDHjIx9nErABlu7nD+pMUmgMBM7JeXQlzvj5qwbgGiSoiBrKJs8ZAHdOJAtj+ajbP4FcEshfK1BO0C4LF32vkFJTsaY/GEUU+dszowvfrbjv9KW81AI=
Authentication-Results-Original: kernel.org; dkim=none (message not signed)
 header.d=none;kernel.org; dmarc=none action=none header.from=arm.com;
Content-Type: text/plain;
	charset=utf-8
Subject: Re: [PATCH v6 2/2] arm/efi: load dom0 modules from DT using UEFI
From: Luca Fancellu <luca.fancellu@arm.com>
In-Reply-To: <alpine.DEB.2.21.2110111243290.25528@sstabellini-ThinkPad-T480s>
Date: Mon, 11 Oct 2021 21:50:47 +0100
Cc: xen-devel@lists.xenproject.org,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 wei.chen@arm.com,
 Julien Grall <julien@xen.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Ian Jackson <iwj@xenproject.org>,
 Jan Beulich <jbeulich@suse.com>,
 Wei Liu <wl@xen.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <EC7165F9-09CE-4001-93ED-FA637F5ED36C@arm.com>
References: <20211011181528.17367-1-luca.fancellu@arm.com>
 <20211011181528.17367-3-luca.fancellu@arm.com>
 <alpine.DEB.2.21.2110111243290.25528@sstabellini-ThinkPad-T480s>
To: Stefano Stabellini <sstabellini@kernel.org>
X-Mailer: Apple Mail (2.3654.120.0.1.13)
X-ClientProxiedBy: LO4P123CA0134.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:193::13) To PAXPR08MB6816.eurprd08.prod.outlook.com
 (2603:10a6:102:130::10)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: e7dd67c1-8e87-48db-f45b-08d98cf8dc86
X-MS-TrafficTypeDiagnostic: PR3PR08MB5737:|AM6PR08MB3558:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS:
	<AM6PR08MB3558C66BF68F9BCB3C51EE07E4B59@AM6PR08MB3558.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 2sb57jaub0CYBh7p+6Tw+xneRY901d+DA6IfXrE37RcMP/mL4QIFYqyYGV0WXsMQLjFUL9QxIV0ch7BK24oG6uyUNtsJnzLmLDD6rKOrAoGSWVswUU0RS3wTMqYoVek9bVZIU8NDRhAmne7xZbf4V8DFy4kNmEGnYHhzBGceqTFXzSpfHYgqKwdx1MKHj9mwqd8Rv+gIzhgJ7G1PilEyvNKiH5HuPjKBCeLMr12IQEHoZL/pkWOR124Pg+NeFtzsQn7aIdCJA7YgNAUyyYCETkwdb46QqkC+NrcvHoL2y9ssrGtL1phQWf9W2kHBc6f4/vlmLIai0K/A/Np8HhEWDyLjTjabM9GPvYPTALZI9yywrmIPpFkBlh8rcmxJjOkf1f4IU3qTLYGeH5w9fHLy/2O9UQivPyuDZpw3lyVVOG51YvkULsvtUGAtW+5p3h7vEDw+jBvjwGr2kr7bVUCUPZN6qrsmbeUKncJGEJehblMm5cJhkw9fwjkz0n7Keqlii5mS/bUCLoHPne4MPmgHSaK7tX5ssbMbS395LNxCvv4/R14V23MBxYsPJmpWQnIeqyT0NjICxmMyfsJBkbYJFUdJJz8sDmI7Qv4o49evBGSc0Rm3fOVg3n+dIJ427WZZCfb4+SlFwVTBALseAqSvO3rZ1GW19h4DobD6Bk28YS3XafHmzJt9N8CDkgCUXZtHWPtM3oHrt8iKIKq1qN2ZcH5pkzsQf5Q96T7/ce1xpdWFhQCiNWnaBySvYDdCv7uX
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB6816.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(38350700002)(38100700002)(8676002)(66476007)(6512007)(8936002)(6916009)(66556008)(86362001)(66946007)(6486002)(2906002)(6666004)(33656002)(36756003)(956004)(2616005)(186003)(53546011)(6506007)(4326008)(54906003)(26005)(508600001)(83380400001)(44832011)(316002)(5660300002)(52116002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR08MB5737
Original-Authentication-Results: kernel.org; dkim=none (message not signed)
 header.d=none;kernel.org; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT045.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	749ff1d2-8107-448d-3af0-08d98cf8d292
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Mt6CNLl20y1eiUDqKBZ2LXuSfAi5fc4gP7rR1UR31ShIjqJ2cLC+5kAnwFpfmlqy5H4k167GLkAj8Tv4/Lzm5PPH+nIdrgmWMTEO89UPxwu+GCq5fYrEHg1ch0f1v1X4rXc+F498XW3S3dIFZkE2AuVm5wg7tsCmU2QxTsyMTUoZT2llGKkYZKIKwSePUJR0byI/lwhVT11rpMJATyBiYShwPzGC00eKu6P8cs0ht4dIdwqa0stGC4I32llf3QnHBaT3FHvTosPomrVMdHEZ2S7wSxvz+/cZoMCOqxW9ftFDlImexccmklhwxnIYrA8TIZt/QD2/4EkfGrrXxOJnkudKw6UjhsJREFBGSsUnJmO7QjRbZd0+j5xBF44HfHI8nYUz3YssppxZYukfrCqjm4ht6Do2Psqm1NWoJQ6Od+bd3QAf++vaLe5k9ORCsUzejj8aJkVRICW9Bv2+U0hCKqMKRww2I4uKS10HSN3rnqXVZjMXJdG5QnrmUYpOxAo/yBtTgQALPexrbA2RZI5T7JBbSyvoYkk7Pd0MZW6rGge7ovRVudnUpo6Sp1hc0jno4sznLOluX4IARrQFuISGpheKFKK6KPtcdKolnLKKXNkI6vgQ16wTb2A6hzAxBH4ZTm8BY5RmvJFAj6VFbWO9Td0ainuysNXkN85FLlBmL0U+TCGPYAmG1UdCIAbBR5bIrtCE9a4WnTcd40tQIuiL3A==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(70206006)(6506007)(33656002)(70586007)(26005)(2906002)(336012)(53546011)(8676002)(2616005)(8936002)(83380400001)(508600001)(44832011)(82310400003)(86362001)(6666004)(36860700001)(186003)(6486002)(956004)(47076005)(81166007)(36756003)(4326008)(316002)(5660300002)(6512007)(6862004)(54906003)(356005);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2021 20:51:12.7426
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: e7dd67c1-8e87-48db-f45b-08d98cf8dc86
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT045.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3558



> On 11 Oct 2021, at 20:53, Stefano Stabellini <sstabellini@kernel.org> wro=
te:
>=20
> On Mon, 11 Oct 2021, Luca Fancellu wrote:
>> Add support to load Dom0 boot modules from
>> the device tree using the xen,uefi-binary property.
>>=20
>> Update documentation about that.
>>=20
>> Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>
>=20

Hi Stefano,

> Unfortunately, due to the change to the previous patch, this patch now
> has one issue, see below.
>=20
>=20
>> @@ -754,6 +760,41 @@ static int __init handle_module_node(EFI_FILE_HANDL=
E dir_handle,
>>         return ERROR_SET_REG_PROPERTY;
>>     }
>>=20
>> +    if ( !is_domu_module )
>> +    {
>> +        if ( (fdt_node_check_compatible(fdt, module_node_offset,
>> +                                    "multiboot,kernel") =3D=3D 0) )
>> +        {
>> +            /*
>> +            * This is the Dom0 kernel, wire it to the kernel variable b=
ecause it
>> +            * will be verified by the shim lock protocol later in the c=
ommon
>> +            * code.
>> +            */
>> +            if ( kernel.addr )
>> +            {
>> +                PrintMessage(L"Dom0 kernel already found in cfg file.")=
;
>> +                return ERROR_DOM0_ALREADY_FOUND;
>> +            }
>> +            kernel.need_to_free =3D false; /* Freed using the module ar=
ray */
>> +            kernel.addr =3D file->addr;
>> +            kernel.size =3D file->size;
>> +        }
>> +        else if ( ramdisk.addr &&
>> +                  (fdt_node_check_compatible(fdt, module_node_offset,
>> +                                             "multiboot,ramdisk") =3D=
=3D 0) )
>> +        {
>> +            PrintMessage(L"Dom0 ramdisk already found in cfg file.");
>> +            return ERROR_DOM0_RAMDISK_FOUND;
>> +        }
>> +        else if ( xsm.addr &&
>> +                  (fdt_node_check_compatible(fdt, module_node_offset,
>> +                                             "xen,xsm-policy") =3D=3D 0=
) )
>> +        {
>> +            PrintMessage(L"XSM policy already found in cfg file.");
>> +            return ERROR_XSM_ALREADY_FOUND;
>> +        }
>> +    }
>> +
>>     return 0;
>> }
>>=20
>> @@ -793,7 +834,7 @@ static int __init handle_dom0less_domain_node(EFI_FI=
LE_HANDLE dir_handle,
>>           module_node =3D fdt_next_subnode(fdt, module_node) )
>>     {
>>         int ret =3D handle_module_node(dir_handle, module_node, addr_cel=
ls,
>> -                                        size_cells);
>> +                                     size_cells, true);
>>         if ( ret < 0 )
>>             return ret;
>>     }
>> @@ -803,7 +844,7 @@ static int __init handle_dom0less_domain_node(EFI_FI=
LE_HANDLE dir_handle,
>>=20
>> /*
>>  * This function checks for xen domain nodes under the /chosen node for =
possible
>> - * domU guests to be loaded.
>> + * dom0 and domU guests to be loaded.
>>  * Returns the number of modules loaded or a negative number for error.
>>  */
>> static int __init efi_check_dt_boot(EFI_FILE_HANDLE dir_handle)
>> @@ -830,6 +871,9 @@ static int __init efi_check_dt_boot(EFI_FILE_HANDLE =
dir_handle)
>>             if ( handle_dom0less_domain_node(dir_handle, node) < 0 )
>>                 return ERROR_DT_MODULE_DOMU;
>>         }
>> +        else if ( handle_module_node(dir_handle, node, addr_len, size_l=
en,
>> +                                     false) < 0 )
>> +                 return ERROR_DT_MODULE_DOM0;
>>     }
>=20
> handle_module_node comes with a "multiboot,module" compatible check now,
> which is fine for dom0less DomU modules, but it is not OK for dom0
> modules.
>=20
> That is because it is also possible to write the dom0 modules (kernel
> and ramdisk) with the following compabile strings:
>=20
> /chosen/dom0 compatible "xen,linux-zimage" "xen,multiboot-module"
> /chosen/dom0-ramdisk compatible "xen,linux-initrd" "xen,multiboot-module"

Oh ok I=E2=80=99m surprised because I think even before I was not managing =
any module
with =E2=80=9Cxen,multiboot-module=E2=80=9D, just any multiboot,{kernel,ram=
disk,device-tree}

>=20
> They are legacy but we are not meant to break support for them. Also
> third party tools might still use them -- I checked and even
> ImageBuilder still uses them.
>=20
> One way to solve the problem is to make the "multiboot,module"
> compatible check at the beginning of handle_module_node conditional on
> !is_domu_module.
>=20
> Or maybe just ignore compabible errors if !is_domu_module. Something like=
:
>=20
> diff --git a/xen/arch/arm/efi/efi-boot.h b/xen/arch/arm/efi/efi-boot.h
> index 840728d6c0..cbfcd55449 100644
> --- a/xen/arch/arm/efi/efi-boot.h
> +++ b/xen/arch/arm/efi/efi-boot.h
> @@ -721,7 +721,7 @@ static int __init handle_module_node(EFI_FILE_HANDLE =
dir_handle,
>         /* Error while checking the compatible string */
>         return ERROR_CHECK_MODULE_COMPAT;
>=20
> -    if ( module_compat !=3D 0 )
> +    if ( is_domu_module && module_compat !=3D 0 )
>         /* Module is not a multiboot,module */
>         return 0;
>=20

I can be ok with this change but it means that any node under chosen that i=
s not a =E2=80=9Cxen,domain=E2=80=9D
will be handled as it is a Dom0 boot module (if it has xen,uefi-binary), is=
 it always true?

Otherwise I can do these changes:

--- a/xen/arch/arm/efi/efi-boot.h
+++ b/xen/arch/arm/efi/efi-boot.h
@@ -721,10 +721,19 @@ static int __init handle_module_node(EFI_FILE_HANDLE =
dir_handle,
         /* Error while checking the compatible string */
         return ERROR_CHECK_MODULE_COMPAT;
=20
-    if ( module_compat !=3D 0 )
+    if ( is_domu_module && (module_compat !=3D 0) )
         /* Module is not a multiboot,module */
         return 0;
=20
+    /*
+     * For Dom0 boot modules can be specified also using the legacy compat=
ible
+     * xen,multiboot-module
+     */
+    if ( !is_domu_module && module_compat &&
+         (fdt_node_check_compatible(fdt, module_node_offset,
+                                    "xen,multiboot-module") !=3D 0) )
+         return 0;
+
     /* Read xen,uefi-binary property to get the file name. */
     uefi_name_prop =3D fdt_getprop(fdt, module_node_offset, "xen,uefi-bina=
ry",
                                  &uefi_name_len);
@@ -763,7 +772,9 @@ static int __init handle_module_node(EFI_FILE_HANDLE di=
r_handle,
     if ( !is_domu_module )
     {
         if ( (fdt_node_check_compatible(fdt, module_node_offset,
-                                    "multiboot,kernel") =3D=3D 0) )
+                                        "multiboot,kernel") =3D=3D 0) ||
+             (fdt_node_check_compatible(fdt, module_node_offset,
+                                        "xen,linux-zimage") =3D=3D 0) )
         {
             /*
             * This is the Dom0 kernel, wire it to the kernel variable beca=
use it
@@ -780,8 +791,10 @@ static int __init handle_module_node(EFI_FILE_HANDLE d=
ir_handle,
             kernel.size =3D file->size;
         }
         else if ( ramdisk.addr &&
-                  (fdt_node_check_compatible(fdt, module_node_offset,
-                                             "multiboot,ramdisk") =3D=3D 0=
) )
+                  ((fdt_node_check_compatible(fdt, module_node_offset,
+                                              "multiboot,ramdisk") =3D=3D =
0) ||
+                   (fdt_node_check_compatible(fdt, module_node_offset,
+                                              "xen,linux-initrd") =3D=3D 0=
)) )
         {
             PrintMessage(L"Dom0 ramdisk already found in cfg file.");
             return ERROR_DOM0_RAMDISK_FOUND;


I would need to check for =E2=80=9Cxen,linux-zimage=E2=80=9D and =E2=80=9Cx=
en,linux-initrd=E2=80=9D however
to be sure the user is not specifying the kernel and ramdisk twice.

Please let me know if you agree or if there is some issue with them.

Cheers,
Luca




From xen-devel-bounces@lists.xenproject.org Mon Oct 11 21:22:05 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 21:22:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.206591.362199 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ma2kA-0007Sy-S7; Mon, 11 Oct 2021 21:21:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 206591.362199; Mon, 11 Oct 2021 21:21:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ma2kA-0007Sr-OX; Mon, 11 Oct 2021 21:21:58 +0000
Received: by outflank-mailman (input) for mailman id 206591;
 Mon, 11 Oct 2021 21:21:57 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=gQnf=O7=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1ma2k9-0007Sl-1z
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 21:21:57 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 3ef88061-4c9e-48dd-91c9-dede7bba0858;
 Mon, 11 Oct 2021 21:21:55 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id 71A7860EE2;
 Mon, 11 Oct 2021 21:21:54 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3ef88061-4c9e-48dd-91c9-dede7bba0858
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1633987314;
	bh=X4cp+7/AHJz+otNEe/hvF3Sj6FMgapPe5ShqN8Y9a/Q=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=jjWxF4SH+xw3eP7xrUihssPGZr5F7H1ALW5cuzIYPwKIthYVU3TIsad0v4ov5hOKy
	 BDgiRTSfZlRNA6MxOO9i9IYQyDpG9Zu3j4dFN2BbnP4C9y3VCW9qZOGFV/GfXfVAUm
	 XMKCOq+3mGe06KJRW4I/NloVKJMTC0nUsp+mZtvwaZCFPpiy4MSJ8XxypEwB0Xy57H
	 IKXMOw7UrujKzeLbzvlaq5km1Bva6DdGd56CnGFBknndPut2naKYPboYrT0FZbooob
	 n/kigqFbo3Xv4rDuXwMyTilfO5H08kovYfwzYjuRHLumYZdHFatakFJPeIzGxyDDjC
	 vYu55FYZUARNw==
Date: Mon, 11 Oct 2021 14:21:53 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Luca Fancellu <luca.fancellu@arm.com>
cc: Stefano Stabellini <sstabellini@kernel.org>, 
    xen-devel@lists.xenproject.org, 
    Bertrand Marquis <bertrand.marquis@arm.com>, wei.chen@arm.com, 
    Julien Grall <julien@xen.org>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, 
    Andrew Cooper <andrew.cooper3@citrix.com>, 
    George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>, 
    Jan Beulich <jbeulich@suse.com>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH v6 2/2] arm/efi: load dom0 modules from DT using UEFI
In-Reply-To: <EC7165F9-09CE-4001-93ED-FA637F5ED36C@arm.com>
Message-ID: <alpine.DEB.2.21.2110111415350.25528@sstabellini-ThinkPad-T480s>
References: <20211011181528.17367-1-luca.fancellu@arm.com> <20211011181528.17367-3-luca.fancellu@arm.com> <alpine.DEB.2.21.2110111243290.25528@sstabellini-ThinkPad-T480s> <EC7165F9-09CE-4001-93ED-FA637F5ED36C@arm.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: multipart/mixed; BOUNDARY="8323329-1793931403-1633987085=:25528"
Content-ID: <alpine.DEB.2.21.2110111421330.25528@sstabellini-ThinkPad-T480s>

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-1793931403-1633987085=:25528
Content-Type: text/plain; CHARSET=UTF-8
Content-Transfer-Encoding: 8BIT
Content-ID: <alpine.DEB.2.21.2110111421331.25528@sstabellini-ThinkPad-T480s>

On Mon, 11 Oct 2021, Luca Fancellu wrote:
> > On 11 Oct 2021, at 20:53, Stefano Stabellini <sstabellini@kernel.org> wrote:
> > 
> > On Mon, 11 Oct 2021, Luca Fancellu wrote:
> >> Add support to load Dom0 boot modules from
> >> the device tree using the xen,uefi-binary property.
> >> 
> >> Update documentation about that.
> >> 
> >> Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>
> > 
> 
> Hi Stefano,
> 
> > Unfortunately, due to the change to the previous patch, this patch now
> > has one issue, see below.
> > 
> > 
> >> @@ -754,6 +760,41 @@ static int __init handle_module_node(EFI_FILE_HANDLE dir_handle,
> >>         return ERROR_SET_REG_PROPERTY;
> >>     }
> >> 
> >> +    if ( !is_domu_module )
> >> +    {
> >> +        if ( (fdt_node_check_compatible(fdt, module_node_offset,
> >> +                                    "multiboot,kernel") == 0) )
> >> +        {
> >> +            /*
> >> +            * This is the Dom0 kernel, wire it to the kernel variable because it
> >> +            * will be verified by the shim lock protocol later in the common
> >> +            * code.
> >> +            */
> >> +            if ( kernel.addr )
> >> +            {
> >> +                PrintMessage(L"Dom0 kernel already found in cfg file.");
> >> +                return ERROR_DOM0_ALREADY_FOUND;
> >> +            }
> >> +            kernel.need_to_free = false; /* Freed using the module array */
> >> +            kernel.addr = file->addr;
> >> +            kernel.size = file->size;
> >> +        }
> >> +        else if ( ramdisk.addr &&
> >> +                  (fdt_node_check_compatible(fdt, module_node_offset,
> >> +                                             "multiboot,ramdisk") == 0) )
> >> +        {
> >> +            PrintMessage(L"Dom0 ramdisk already found in cfg file.");
> >> +            return ERROR_DOM0_RAMDISK_FOUND;
> >> +        }
> >> +        else if ( xsm.addr &&
> >> +                  (fdt_node_check_compatible(fdt, module_node_offset,
> >> +                                             "xen,xsm-policy") == 0) )
> >> +        {
> >> +            PrintMessage(L"XSM policy already found in cfg file.");
> >> +            return ERROR_XSM_ALREADY_FOUND;
> >> +        }
> >> +    }
> >> +
> >>     return 0;
> >> }
> >> 
> >> @@ -793,7 +834,7 @@ static int __init handle_dom0less_domain_node(EFI_FILE_HANDLE dir_handle,
> >>           module_node = fdt_next_subnode(fdt, module_node) )
> >>     {
> >>         int ret = handle_module_node(dir_handle, module_node, addr_cells,
> >> -                                        size_cells);
> >> +                                     size_cells, true);
> >>         if ( ret < 0 )
> >>             return ret;
> >>     }
> >> @@ -803,7 +844,7 @@ static int __init handle_dom0less_domain_node(EFI_FILE_HANDLE dir_handle,
> >> 
> >> /*
> >>  * This function checks for xen domain nodes under the /chosen node for possible
> >> - * domU guests to be loaded.
> >> + * dom0 and domU guests to be loaded.
> >>  * Returns the number of modules loaded or a negative number for error.
> >>  */
> >> static int __init efi_check_dt_boot(EFI_FILE_HANDLE dir_handle)
> >> @@ -830,6 +871,9 @@ static int __init efi_check_dt_boot(EFI_FILE_HANDLE dir_handle)
> >>             if ( handle_dom0less_domain_node(dir_handle, node) < 0 )
> >>                 return ERROR_DT_MODULE_DOMU;
> >>         }
> >> +        else if ( handle_module_node(dir_handle, node, addr_len, size_len,
> >> +                                     false) < 0 )
> >> +                 return ERROR_DT_MODULE_DOM0;
> >>     }
> > 
> > handle_module_node comes with a "multiboot,module" compatible check now,
> > which is fine for dom0less DomU modules, but it is not OK for dom0
> > modules.
> > 
> > That is because it is also possible to write the dom0 modules (kernel
> > and ramdisk) with the following compabile strings:
> > 
> > /chosen/dom0 compatible "xen,linux-zimage" "xen,multiboot-module"
> > /chosen/dom0-ramdisk compatible "xen,linux-initrd" "xen,multiboot-module"
> 
> Oh ok I’m surprised because I think even before I was not managing any module
> with “xen,multiboot-module”, just any multiboot,{kernel,ramdisk,device-tree}

At least by looking at the code it seemed to work before, although we
weren't explicitly checking for this case 

 
> > They are legacy but we are not meant to break support for them. Also
> > third party tools might still use them -- I checked and even
> > ImageBuilder still uses them.
> > 
> > One way to solve the problem is to make the "multiboot,module"
> > compatible check at the beginning of handle_module_node conditional on
> > !is_domu_module.
> > 
> > Or maybe just ignore compabible errors if !is_domu_module. Something like:
> > 
> > diff --git a/xen/arch/arm/efi/efi-boot.h b/xen/arch/arm/efi/efi-boot.h
> > index 840728d6c0..cbfcd55449 100644
> > --- a/xen/arch/arm/efi/efi-boot.h
> > +++ b/xen/arch/arm/efi/efi-boot.h
> > @@ -721,7 +721,7 @@ static int __init handle_module_node(EFI_FILE_HANDLE dir_handle,
> >         /* Error while checking the compatible string */
> >         return ERROR_CHECK_MODULE_COMPAT;
> > 
> > -    if ( module_compat != 0 )
> > +    if ( is_domu_module && module_compat != 0 )
> >         /* Module is not a multiboot,module */
> >         return 0;
> > 
> 
> I can be ok with this change but it means that any node under chosen that is not a “xen,domain”
> will be handled as it is a Dom0 boot module (if it has xen,uefi-binary), is it always true?
 
Good point. I don't think it is a safe assumption.


> Otherwise I can do these changes:
> 
> --- a/xen/arch/arm/efi/efi-boot.h
> +++ b/xen/arch/arm/efi/efi-boot.h
> @@ -721,10 +721,19 @@ static int __init handle_module_node(EFI_FILE_HANDLE dir_handle,
>          /* Error while checking the compatible string */
>          return ERROR_CHECK_MODULE_COMPAT;
>  
> -    if ( module_compat != 0 )
> +    if ( is_domu_module && (module_compat != 0) )
>          /* Module is not a multiboot,module */
>          return 0;
>  
> +    /*
> +     * For Dom0 boot modules can be specified also using the legacy compatible
> +     * xen,multiboot-module
> +     */
> +    if ( !is_domu_module && module_compat &&
> +         (fdt_node_check_compatible(fdt, module_node_offset,
> +                                    "xen,multiboot-module") != 0) )
> +         return 0;
> +
>      /* Read xen,uefi-binary property to get the file name. */
>      uefi_name_prop = fdt_getprop(fdt, module_node_offset, "xen,uefi-binary",
>                                   &uefi_name_len);
> @@ -763,7 +772,9 @@ static int __init handle_module_node(EFI_FILE_HANDLE dir_handle,
>      if ( !is_domu_module )
>      {
>          if ( (fdt_node_check_compatible(fdt, module_node_offset,
> -                                    "multiboot,kernel") == 0) )
> +                                        "multiboot,kernel") == 0) ||
> +             (fdt_node_check_compatible(fdt, module_node_offset,
> +                                        "xen,linux-zimage") == 0) )
>          {
>              /*
>              * This is the Dom0 kernel, wire it to the kernel variable because it
> @@ -780,8 +791,10 @@ static int __init handle_module_node(EFI_FILE_HANDLE dir_handle,
>              kernel.size = file->size;
>          }
>          else if ( ramdisk.addr &&
> -                  (fdt_node_check_compatible(fdt, module_node_offset,
> -                                             "multiboot,ramdisk") == 0) )
> +                  ((fdt_node_check_compatible(fdt, module_node_offset,
> +                                              "multiboot,ramdisk") == 0) ||
> +                   (fdt_node_check_compatible(fdt, module_node_offset,
> +                                              "xen,linux-initrd") == 0)) )
>          {
>              PrintMessage(L"Dom0 ramdisk already found in cfg file.");
>              return ERROR_DOM0_RAMDISK_FOUND;
> 
> 
> I would need to check for “xen,linux-zimage” and “xen,linux-initrd” however
> to be sure the user is not specifying the kernel and ramdisk twice.
> 
> Please let me know if you agree or if there is some issue with them.

I have another idea: I don't think we need to actually check for
"xen,linux-zimage" or "xen,linux-initrd" because I am pretty sure they
were always used in conjunction with "xen,multiboot-module".

So maybe it is enough to check for:

- for dom0: "xen,multiboot-module"
- domU: "multiboot,module"


E.g.:

diff --git a/xen/arch/arm/efi/efi-boot.h b/xen/arch/arm/efi/efi-boot.h
index 840728d6c0..076b827bdd 100644
--- a/xen/arch/arm/efi/efi-boot.h
+++ b/xen/arch/arm/efi/efi-boot.h
@@ -713,10 +713,12 @@ static int __init handle_module_node(EFI_FILE_HANDLE dir_handle,
     char mod_string[24]; /* Placeholder for module@ + a 64-bit number + \0 */
     int uefi_name_len, file_idx, module_compat;
     module_name *file;
+    const char *compat_string = is_domu_module ? "multiboot,module" :
+                                "xen,multiboot-module";
 
     /* Check if the node is a multiboot,module otherwise return */
     module_compat = fdt_node_check_compatible(fdt, module_node_offset,
-                                              "multiboot,module");
+                                              compat_string);
     if ( module_compat < 0 )
         /* Error while checking the compatible string */
         return ERROR_CHECK_MODULE_COMPAT;
--8323329-1793931403-1633987085=:25528--


From xen-devel-bounces@lists.xenproject.org Mon Oct 11 21:24:21 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 21:24:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.206602.362210 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ma2mS-00084S-8l; Mon, 11 Oct 2021 21:24:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 206602.362210; Mon, 11 Oct 2021 21:24:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ma2mS-00084L-51; Mon, 11 Oct 2021 21:24:20 +0000
Received: by outflank-mailman (input) for mailman id 206602;
 Mon, 11 Oct 2021 21:24:19 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=gQnf=O7=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1ma2mR-00084F-3V
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 21:24:19 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id e59145ba-33d9-4552-a6f3-cd028a09fcb8;
 Mon, 11 Oct 2021 21:24:17 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id 9103560EFE;
 Mon, 11 Oct 2021 21:24:16 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e59145ba-33d9-4552-a6f3-cd028a09fcb8
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1633987457;
	bh=CiZm7U3N/x/vTwC/JxzgyXPM3FhIs2K6dPxDgM1T6wY=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=o9CAahxveeKrIG2CEQUPMZP3Trolha0lgwN65h7HCfGfjzYNe3pmZc4RAkkm2gwTN
	 1Dqsp+r+pqDnEsfjKQzcXmYFadjnun0PUflXmrowAwL1wMQzBZRKljY8MIjQAIQb18
	 EANV8abYT7b+igPQwZQYMmyFFhP5DHELH4w4p031PPXTEbIjuv6ICnfkK0rLXrEolY
	 5EtuD6ADgvSSBE/KeDsleI0adoPSwBOGBW+IC4fBBETs7iflwZnhkQQl1zOKM87Goj
	 dqz0HIwCC3Kiu1zDh+KnyWinEaENnJwoornO+0Qp8qCSZ/RSF7exjgCXbyhJnz0XIa
	 sZW8hGR09N+oA==
Date: Mon, 11 Oct 2021 14:24:15 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Stefano Stabellini <sstabellini@kernel.org>
cc: Luca Fancellu <luca.fancellu@arm.com>, xen-devel@lists.xenproject.org, 
    Bertrand Marquis <bertrand.marquis@arm.com>, wei.chen@arm.com, 
    Julien Grall <julien@xen.org>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, 
    Andrew Cooper <andrew.cooper3@citrix.com>, 
    George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>, 
    Jan Beulich <jbeulich@suse.com>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH v6 2/2] arm/efi: load dom0 modules from DT using UEFI
In-Reply-To: <alpine.DEB.2.21.2110111415350.25528@sstabellini-ThinkPad-T480s>
Message-ID: <alpine.DEB.2.21.2110111423310.25528@sstabellini-ThinkPad-T480s>
References: <20211011181528.17367-1-luca.fancellu@arm.com> <20211011181528.17367-3-luca.fancellu@arm.com> <alpine.DEB.2.21.2110111243290.25528@sstabellini-ThinkPad-T480s> <EC7165F9-09CE-4001-93ED-FA637F5ED36C@arm.com>
 <alpine.DEB.2.21.2110111415350.25528@sstabellini-ThinkPad-T480s>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="8323329-389585025-1633987456=:25528"

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-389585025-1633987456=:25528
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT

On Mon, 11 Oct 2021, Stefano Stabellini wrote:
> On Mon, 11 Oct 2021, Luca Fancellu wrote:
> > > On 11 Oct 2021, at 20:53, Stefano Stabellini <sstabellini@kernel.org> wrote:
> > > 
> > > On Mon, 11 Oct 2021, Luca Fancellu wrote:
> > >> Add support to load Dom0 boot modules from
> > >> the device tree using the xen,uefi-binary property.
> > >> 
> > >> Update documentation about that.
> > >> 
> > >> Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>
> > > 
> > 
> > Hi Stefano,
> > 
> > > Unfortunately, due to the change to the previous patch, this patch now
> > > has one issue, see below.
> > > 
> > > 
> > >> @@ -754,6 +760,41 @@ static int __init handle_module_node(EFI_FILE_HANDLE dir_handle,
> > >>         return ERROR_SET_REG_PROPERTY;
> > >>     }
> > >> 
> > >> +    if ( !is_domu_module )
> > >> +    {
> > >> +        if ( (fdt_node_check_compatible(fdt, module_node_offset,
> > >> +                                    "multiboot,kernel") == 0) )
> > >> +        {
> > >> +            /*
> > >> +            * This is the Dom0 kernel, wire it to the kernel variable because it
> > >> +            * will be verified by the shim lock protocol later in the common
> > >> +            * code.
> > >> +            */
> > >> +            if ( kernel.addr )
> > >> +            {
> > >> +                PrintMessage(L"Dom0 kernel already found in cfg file.");
> > >> +                return ERROR_DOM0_ALREADY_FOUND;
> > >> +            }
> > >> +            kernel.need_to_free = false; /* Freed using the module array */
> > >> +            kernel.addr = file->addr;
> > >> +            kernel.size = file->size;
> > >> +        }
> > >> +        else if ( ramdisk.addr &&
> > >> +                  (fdt_node_check_compatible(fdt, module_node_offset,
> > >> +                                             "multiboot,ramdisk") == 0) )
> > >> +        {
> > >> +            PrintMessage(L"Dom0 ramdisk already found in cfg file.");
> > >> +            return ERROR_DOM0_RAMDISK_FOUND;
> > >> +        }
> > >> +        else if ( xsm.addr &&
> > >> +                  (fdt_node_check_compatible(fdt, module_node_offset,
> > >> +                                             "xen,xsm-policy") == 0) )
> > >> +        {
> > >> +            PrintMessage(L"XSM policy already found in cfg file.");
> > >> +            return ERROR_XSM_ALREADY_FOUND;
> > >> +        }
> > >> +    }
> > >> +
> > >>     return 0;
> > >> }
> > >> 
> > >> @@ -793,7 +834,7 @@ static int __init handle_dom0less_domain_node(EFI_FILE_HANDLE dir_handle,
> > >>           module_node = fdt_next_subnode(fdt, module_node) )
> > >>     {
> > >>         int ret = handle_module_node(dir_handle, module_node, addr_cells,
> > >> -                                        size_cells);
> > >> +                                     size_cells, true);
> > >>         if ( ret < 0 )
> > >>             return ret;
> > >>     }
> > >> @@ -803,7 +844,7 @@ static int __init handle_dom0less_domain_node(EFI_FILE_HANDLE dir_handle,
> > >> 
> > >> /*
> > >>  * This function checks for xen domain nodes under the /chosen node for possible
> > >> - * domU guests to be loaded.
> > >> + * dom0 and domU guests to be loaded.
> > >>  * Returns the number of modules loaded or a negative number for error.
> > >>  */
> > >> static int __init efi_check_dt_boot(EFI_FILE_HANDLE dir_handle)
> > >> @@ -830,6 +871,9 @@ static int __init efi_check_dt_boot(EFI_FILE_HANDLE dir_handle)
> > >>             if ( handle_dom0less_domain_node(dir_handle, node) < 0 )
> > >>                 return ERROR_DT_MODULE_DOMU;
> > >>         }
> > >> +        else if ( handle_module_node(dir_handle, node, addr_len, size_len,
> > >> +                                     false) < 0 )
> > >> +                 return ERROR_DT_MODULE_DOM0;
> > >>     }
> > > 
> > > handle_module_node comes with a "multiboot,module" compatible check now,
> > > which is fine for dom0less DomU modules, but it is not OK for dom0
> > > modules.
> > > 
> > > That is because it is also possible to write the dom0 modules (kernel
> > > and ramdisk) with the following compabile strings:
> > > 
> > > /chosen/dom0 compatible "xen,linux-zimage" "xen,multiboot-module"
> > > /chosen/dom0-ramdisk compatible "xen,linux-initrd" "xen,multiboot-module"
> > 
> > Oh ok I’m surprised because I think even before I was not managing any module
> > with “xen,multiboot-module”, just any multiboot,{kernel,ramdisk,device-tree}
> 
> At least by looking at the code it seemed to work before, although we
> weren't explicitly checking for this case 
> 
>  
> > > They are legacy but we are not meant to break support for them. Also
> > > third party tools might still use them -- I checked and even
> > > ImageBuilder still uses them.
> > > 
> > > One way to solve the problem is to make the "multiboot,module"
> > > compatible check at the beginning of handle_module_node conditional on
> > > !is_domu_module.
> > > 
> > > Or maybe just ignore compabible errors if !is_domu_module. Something like:
> > > 
> > > diff --git a/xen/arch/arm/efi/efi-boot.h b/xen/arch/arm/efi/efi-boot.h
> > > index 840728d6c0..cbfcd55449 100644
> > > --- a/xen/arch/arm/efi/efi-boot.h
> > > +++ b/xen/arch/arm/efi/efi-boot.h
> > > @@ -721,7 +721,7 @@ static int __init handle_module_node(EFI_FILE_HANDLE dir_handle,
> > >         /* Error while checking the compatible string */
> > >         return ERROR_CHECK_MODULE_COMPAT;
> > > 
> > > -    if ( module_compat != 0 )
> > > +    if ( is_domu_module && module_compat != 0 )
> > >         /* Module is not a multiboot,module */
> > >         return 0;
> > > 
> > 
> > I can be ok with this change but it means that any node under chosen that is not a “xen,domain”
> > will be handled as it is a Dom0 boot module (if it has xen,uefi-binary), is it always true?
>  
> Good point. I don't think it is a safe assumption.
> 
> 
> > Otherwise I can do these changes:
> > 
> > --- a/xen/arch/arm/efi/efi-boot.h
> > +++ b/xen/arch/arm/efi/efi-boot.h
> > @@ -721,10 +721,19 @@ static int __init handle_module_node(EFI_FILE_HANDLE dir_handle,
> >          /* Error while checking the compatible string */
> >          return ERROR_CHECK_MODULE_COMPAT;
> >  
> > -    if ( module_compat != 0 )
> > +    if ( is_domu_module && (module_compat != 0) )
> >          /* Module is not a multiboot,module */
> >          return 0;
> >  
> > +    /*
> > +     * For Dom0 boot modules can be specified also using the legacy compatible
> > +     * xen,multiboot-module
> > +     */
> > +    if ( !is_domu_module && module_compat &&
> > +         (fdt_node_check_compatible(fdt, module_node_offset,
> > +                                    "xen,multiboot-module") != 0) )
> > +         return 0;
> > +
> >      /* Read xen,uefi-binary property to get the file name. */
> >      uefi_name_prop = fdt_getprop(fdt, module_node_offset, "xen,uefi-binary",
> >                                   &uefi_name_len);
> > @@ -763,7 +772,9 @@ static int __init handle_module_node(EFI_FILE_HANDLE dir_handle,
> >      if ( !is_domu_module )
> >      {
> >          if ( (fdt_node_check_compatible(fdt, module_node_offset,
> > -                                    "multiboot,kernel") == 0) )
> > +                                        "multiboot,kernel") == 0) ||
> > +             (fdt_node_check_compatible(fdt, module_node_offset,
> > +                                        "xen,linux-zimage") == 0) )
> >          {
> >              /*
> >              * This is the Dom0 kernel, wire it to the kernel variable because it
> > @@ -780,8 +791,10 @@ static int __init handle_module_node(EFI_FILE_HANDLE dir_handle,
> >              kernel.size = file->size;
> >          }
> >          else if ( ramdisk.addr &&
> > -                  (fdt_node_check_compatible(fdt, module_node_offset,
> > -                                             "multiboot,ramdisk") == 0) )
> > +                  ((fdt_node_check_compatible(fdt, module_node_offset,
> > +                                              "multiboot,ramdisk") == 0) ||
> > +                   (fdt_node_check_compatible(fdt, module_node_offset,
> > +                                              "xen,linux-initrd") == 0)) )
> >          {
> >              PrintMessage(L"Dom0 ramdisk already found in cfg file.");
> >              return ERROR_DOM0_RAMDISK_FOUND;
> > 
> > 
> > I would need to check for “xen,linux-zimage” and “xen,linux-initrd” however
> > to be sure the user is not specifying the kernel and ramdisk twice.
> > 
> > Please let me know if you agree or if there is some issue with them.
> 
> I have another idea: I don't think we need to actually check for
> "xen,linux-zimage" or "xen,linux-initrd" because I am pretty sure they
> were always used in conjunction with "xen,multiboot-module".
> 
> So maybe it is enough to check for:
> 
> - for dom0: "xen,multiboot-module"
> - domU: "multiboot,module"
> 
> 
> E.g.:
> 
> diff --git a/xen/arch/arm/efi/efi-boot.h b/xen/arch/arm/efi/efi-boot.h
> index 840728d6c0..076b827bdd 100644
> --- a/xen/arch/arm/efi/efi-boot.h
> +++ b/xen/arch/arm/efi/efi-boot.h
> @@ -713,10 +713,12 @@ static int __init handle_module_node(EFI_FILE_HANDLE dir_handle,
>      char mod_string[24]; /* Placeholder for module@ + a 64-bit number + \0 */
>      int uefi_name_len, file_idx, module_compat;
>      module_name *file;
> +    const char *compat_string = is_domu_module ? "multiboot,module" :
> +                                "xen,multiboot-module";
>  
>      /* Check if the node is a multiboot,module otherwise return */
>      module_compat = fdt_node_check_compatible(fdt, module_node_offset,
> -                                              "multiboot,module");
> +                                              compat_string);
>      if ( module_compat < 0 )
>          /* Error while checking the compatible string */
>          return ERROR_CHECK_MODULE_COMPAT;


Well... not exactly like this because this would stop a normal
"multiboot,module" dom0 kernel from being recognized.

So we need for domU: only "multiboot,module"
For Dom0, either "multiboot,module" or "xen,multiboot-module"
--8323329-389585025-1633987456=:25528--


From xen-devel-bounces@lists.xenproject.org Mon Oct 11 21:34:00 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 11 Oct 2021 21:34:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.206609.362220 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ma2vk-00017l-7G; Mon, 11 Oct 2021 21:33:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 206609.362220; Mon, 11 Oct 2021 21:33:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ma2vk-00017e-49; Mon, 11 Oct 2021 21:33:56 +0000
Received: by outflank-mailman (input) for mailman id 206609;
 Mon, 11 Oct 2021 21:33:54 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1ma2vi-00017Y-U3
 for xen-devel@lists.xenproject.org; Mon, 11 Oct 2021 21:33:54 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ma2vh-0006hx-Cq; Mon, 11 Oct 2021 21:33:53 +0000
Received: from 54-240-197-230.amazon.com ([54.240.197.230]
 helo=[192.168.17.141]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ma2vh-0005oH-4O; Mon, 11 Oct 2021 21:33:53 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=SFekq2OcRLR7h8SATMFqG93Sor5I/853dkdAnCZxH7s=; b=DCJ5Kjn1vdLA94BFshQ4iIoyt3
	kL/C3D8BRs/d0Nm77wjStR4ToDDGvmtaq6IpY+rwAAto7vHbx347d6bhL/x2XbhfSr6KDLcypHdJH
	J9hT4r/q8mMNhwk9hnnXGasyTZUlHKTQ5zpyplwc1oRJsjGerHTTirb10Metcp8XzD/M=;
Message-ID: <29cc47f2-4727-0397-db0c-a6c1f5a52bf7@xen.org>
Date: Mon, 11 Oct 2021 22:33:50 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.2.0
Subject: Re: [PATCH v6 2/2] arm/efi: load dom0 modules from DT using UEFI
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: Luca Fancellu <luca.fancellu@arm.com>, xen-devel@lists.xenproject.org,
 Bertrand Marquis <bertrand.marquis@arm.com>, wei.chen@arm.com,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Jan Beulich <jbeulich@suse.com>, Wei Liu <wl@xen.org>
References: <20211011181528.17367-1-luca.fancellu@arm.com>
 <20211011181528.17367-3-luca.fancellu@arm.com>
 <alpine.DEB.2.21.2110111243290.25528@sstabellini-ThinkPad-T480s>
 <EC7165F9-09CE-4001-93ED-FA637F5ED36C@arm.com>
 <alpine.DEB.2.21.2110111415350.25528@sstabellini-ThinkPad-T480s>
 <alpine.DEB.2.21.2110111423310.25528@sstabellini-ThinkPad-T480s>
From: Julien Grall <julien@xen.org>
In-Reply-To: <alpine.DEB.2.21.2110111423310.25528@sstabellini-ThinkPad-T480s>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Stefano,

On 11/10/2021 22:24, Stefano Stabellini wrote:
>> diff --git a/xen/arch/arm/efi/efi-boot.h b/xen/arch/arm/efi/efi-boot.h
>> index 840728d6c0..076b827bdd 100644
>> --- a/xen/arch/arm/efi/efi-boot.h
>> +++ b/xen/arch/arm/efi/efi-boot.h
>> @@ -713,10 +713,12 @@ static int __init handle_module_node(EFI_FILE_HANDLE dir_handle,
>>       char mod_string[24]; /* Placeholder for module@ + a 64-bit number + \0 */
>>       int uefi_name_len, file_idx, module_compat;
>>       module_name *file;
>> +    const char *compat_string = is_domu_module ? "multiboot,module" :
>> +                                "xen,multiboot-module";
>>   
>>       /* Check if the node is a multiboot,module otherwise return */
>>       module_compat = fdt_node_check_compatible(fdt, module_node_offset,
>> -                                              "multiboot,module");
>> +                                              compat_string);
>>       if ( module_compat < 0 )
>>           /* Error while checking the compatible string */
>>           return ERROR_CHECK_MODULE_COMPAT;
> 
> 
> Well... not exactly like this because this would stop a normal
> "multiboot,module" dom0 kernel from being recognized.
> 
> So we need for domU: only "multiboot,module"
> For Dom0, either "multiboot,module" or "xen,multiboot-module"

Looking at the history, xen,multiboot-module has been considered as a 
legacy binding since before UEFI was introduced. In fact, without this 
series, I believe, there is limited reasons for the compatible to be 
present in the DT as you would either use grub (which use the new 
compatible) or xen.cfg (the stub will create the node).

So I would argue that this compatible should not be used in combination 
with UEFI and therefore we should not handle it. This would make the 
code simpler :).

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Tue Oct 12 01:11:04 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 01:11:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.206637.362231 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ma6Ja-0006Uv-FZ; Tue, 12 Oct 2021 01:10:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 206637.362231; Tue, 12 Oct 2021 01:10:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ma6Ja-0006Uo-Bs; Tue, 12 Oct 2021 01:10:46 +0000
Received: by outflank-mailman (input) for mailman id 206637;
 Tue, 12 Oct 2021 01:10:44 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ma6JY-0006Ue-Bp; Tue, 12 Oct 2021 01:10:44 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ma6JY-00040B-45; Tue, 12 Oct 2021 01:10:44 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ma6JX-0007g1-NY; Tue, 12 Oct 2021 01:10:43 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ma6JX-0004Iv-Mz; Tue, 12 Oct 2021 01:10:43 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=HtmgLU2IzjWY21fsN771MiniViZ7AWXNNMveDzx5UIs=; b=hSBI9NTgj0FaXYEy5mueosG2Jr
	TBim7/mTpq4Too1H8b+HCO8acnEuj/mXMU8H7mr35j8zSbNpLBJCLfvkV8fEHuvpKOU3VKI+WkPZn
	H6vPsTpmMAbeNmHzc2zlt8Tmh5/IhbQmdYlofLdKWy/WdC6rtijv/dKLJnrFFLsVhTzA=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165467-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 165467: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=2fac4e3ea3bb301f87426e24b9dfd765c22c9cf9
X-Osstest-Versions-That:
    xen=664cc3c3d381e4f9a61dcb68cbd7a6a00070370e
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 12 Oct 2021 01:10:43 +0000

flight 165467 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165467/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 165460
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 165460
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165460
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165460
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 165460
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 165460
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 165460
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 165460
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 165460
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 165460
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165460
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 165460
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  2fac4e3ea3bb301f87426e24b9dfd765c22c9cf9
baseline version:
 xen                  664cc3c3d381e4f9a61dcb68cbd7a6a00070370e

Last test of basis   165460  2021-10-11 01:52:59 Z    0 days
Testing same since   165467  2021-10-11 15:06:53 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Christopher Clark <christopher.w.clark@gmail.com>
  Jan Beulich <jbeulich@suse.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   664cc3c3d3..2fac4e3ea3  2fac4e3ea3bb301f87426e24b9dfd765c22c9cf9 -> master


From xen-devel-bounces@lists.xenproject.org Tue Oct 12 01:31:49 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 01:31:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.206649.362257 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ma6dq-0000Yi-AE; Tue, 12 Oct 2021 01:31:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 206649.362257; Tue, 12 Oct 2021 01:31:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ma6dq-0000Yb-7H; Tue, 12 Oct 2021 01:31:42 +0000
Received: by outflank-mailman (input) for mailman id 206649;
 Tue, 12 Oct 2021 01:31:40 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=SIAI=PA=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1ma6do-0000YV-P3
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 01:31:40 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 360faa13-b9f6-4e71-941d-f606d04c4d41;
 Tue, 12 Oct 2021 01:31:39 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id C104661059;
 Tue, 12 Oct 2021 01:31:38 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 360faa13-b9f6-4e71-941d-f606d04c4d41
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1634002299;
	bh=phxF93lYoV9NXd17ob3aSeDHRZ/kszY9yWaG01Uqrow=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=LbJ46FCyqAX+6V2pF0xiaURjT9y3hyJJLwNfKk3txd3f94rz+9QLv9genskPkQ0Ts
	 WDVZGHhJtCV6DwCSQNYxgQ/5U7x/ZtosCzS6E9oB/SU3kfx/CVhZV/KFX9Y/sORhOq
	 EPSnEtB6RPnD7nSeUU589DF7eE+ouwr9BWI5DDk1B28LsMcv0dLvmsKylBsGBWWG6O
	 1aqoWl+6bydDHfcQZ3uMVLkYyCdfCRp5eYKA0WNkWGAzAyYHqENKnxJXobA+/hYY39
	 T6w7D/nRtT/guZVqfO/wxc3Kd9bsBasTjcL2wxuIm63xeJ3F/UGhaOr8dF4KMgMRCP
	 W3AmoAysyi1lA==
Date: Mon, 11 Oct 2021 18:31:38 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Julien Grall <julien@xen.org>
cc: Stefano Stabellini <sstabellini@kernel.org>, 
    Luca Fancellu <luca.fancellu@arm.com>, xen-devel@lists.xenproject.org, 
    Bertrand Marquis <bertrand.marquis@arm.com>, wei.chen@arm.com, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, 
    Andrew Cooper <andrew.cooper3@citrix.com>, 
    George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>, 
    Jan Beulich <jbeulich@suse.com>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH v6 2/2] arm/efi: load dom0 modules from DT using UEFI
In-Reply-To: <29cc47f2-4727-0397-db0c-a6c1f5a52bf7@xen.org>
Message-ID: <alpine.DEB.2.21.2110111813510.25528@sstabellini-ThinkPad-T480s>
References: <20211011181528.17367-1-luca.fancellu@arm.com> <20211011181528.17367-3-luca.fancellu@arm.com> <alpine.DEB.2.21.2110111243290.25528@sstabellini-ThinkPad-T480s> <EC7165F9-09CE-4001-93ED-FA637F5ED36C@arm.com> <alpine.DEB.2.21.2110111415350.25528@sstabellini-ThinkPad-T480s>
 <alpine.DEB.2.21.2110111423310.25528@sstabellini-ThinkPad-T480s> <29cc47f2-4727-0397-db0c-a6c1f5a52bf7@xen.org>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Mon, 11 Oct 2021, Julien Grall wrote:
> Hi Stefano,
> 
> On 11/10/2021 22:24, Stefano Stabellini wrote:
> > > diff --git a/xen/arch/arm/efi/efi-boot.h b/xen/arch/arm/efi/efi-boot.h
> > > index 840728d6c0..076b827bdd 100644
> > > --- a/xen/arch/arm/efi/efi-boot.h
> > > +++ b/xen/arch/arm/efi/efi-boot.h
> > > @@ -713,10 +713,12 @@ static int __init handle_module_node(EFI_FILE_HANDLE
> > > dir_handle,
> > >       char mod_string[24]; /* Placeholder for module@ + a 64-bit number +
> > > \0 */
> > >       int uefi_name_len, file_idx, module_compat;
> > >       module_name *file;
> > > +    const char *compat_string = is_domu_module ? "multiboot,module" :
> > > +                                "xen,multiboot-module";
> > >         /* Check if the node is a multiboot,module otherwise return */
> > >       module_compat = fdt_node_check_compatible(fdt, module_node_offset,
> > > -                                              "multiboot,module");
> > > +                                              compat_string);
> > >       if ( module_compat < 0 )
> > >           /* Error while checking the compatible string */
> > >           return ERROR_CHECK_MODULE_COMPAT;
> > 
> > 
> > Well... not exactly like this because this would stop a normal
> > "multiboot,module" dom0 kernel from being recognized.
> > 
> > So we need for domU: only "multiboot,module"
> > For Dom0, either "multiboot,module" or "xen,multiboot-module"
> 
> Looking at the history, xen,multiboot-module has been considered as a legacy
> binding since before UEFI was introduced. In fact, without this series, I
> believe, there is limited reasons for the compatible to be present in the DT
> as you would either use grub (which use the new compatible) or xen.cfg (the
> stub will create the node).
> 
> So I would argue that this compatible should not be used in combination with
> UEFI and therefore we should not handle it. This would make the code simpler
> :).

What you suggested is a viable option, however ImageBuilder is still
using the "xen,multiboot-module" format somehow today (no idea why) and
we have the following written in docs/misc/arm/device-tree/booting.txt:

	Xen 4.4 supported a different set of legacy compatible strings
	which remain supported such that systems supporting both 4.4
	and later can use a single DTB.

	- "xen,multiboot-module" equivalent to "multiboot,module"
	- "xen,linux-zimage"     equivalent to "multiboot,kernel"
	- "xen,linux-initrd"     equivalent to "multiboot,ramdisk"

	For compatibility with Xen 4.4 the more specific "xen,linux-*"
	names are non-optional and must be included.

My preference is to avoid breaking compatibility (even with UEFI
booting). The way I suggested above is one way to do it.

But I don't feel strongly about this at all, I am fine with ignoring
"xen,multiboot-module" in the EFI stub. I can get ImageBuilder fixed
very quickly (I should do that in any case). If we are going to ignore
"xen,multiboot-module" then we probably want to update the text in
docs/misc/arm/device-tree/booting.txt also.


From xen-devel-bounces@lists.xenproject.org Tue Oct 12 01:32:30 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 01:32:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.206655.362268 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ma6ec-00016s-JV; Tue, 12 Oct 2021 01:32:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 206655.362268; Tue, 12 Oct 2021 01:32:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ma6ec-00016j-GJ; Tue, 12 Oct 2021 01:32:30 +0000
Received: by outflank-mailman (input) for mailman id 206655;
 Tue, 12 Oct 2021 01:32:29 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=SIAI=PA=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1ma6eb-00016d-Jy
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 01:32:29 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 35f6a6c3-e69a-440b-b45b-93814a0dc727;
 Tue, 12 Oct 2021 01:32:28 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id C0CF560462;
 Tue, 12 Oct 2021 01:32:27 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 35f6a6c3-e69a-440b-b45b-93814a0dc727
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1634002348;
	bh=ItEsptxYgixycqcUTZ8q5oqj49kgLf4k43K0tTpOQbg=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=HpSm7Nuia6pH6CTgVbIFQV7CIrAd9ZnScMR5y9uLduAtQ9YqtF+n4HW11yT2F8E4g
	 RcOEu9GkIMy1Tt6f6/r1etHffWhyeO0kQvqEXNwl534KIUbwUAqUCRaaRDlTMoyTqG
	 Ie8hcpHorO5zcYzg/0dm7ExrGIr47Q4R/K446OmrJ3749r0ta1pK/AXCTiHedj4h+n
	 jjhQy+ioPoKvFYckiJPE9bfpZrAbsSaTKaLkZPTg/NFdikQJvS2IXbJnqvhSQJJn1B
	 jakhCppQaniY40gHi4DM4OAWLQ2VrZV2XGFtDB8nxlOxwYsQ3V0Zw49aY9gp3e93/k
	 WGq1RKGEkLQig==
Date: Mon, 11 Oct 2021 18:32:26 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Anthony PERARD <anthony.perard@citrix.com>
cc: Oleksandr Andrushchenko <andr2000@gmail.com>, 
    xen-devel@lists.xenproject.org, julien@xen.org, sstabellini@kernel.org, 
    oleksandr_tyshchenko@epam.com, volodymyr_babchuk@epam.com, 
    Artem_Mygaiev@epam.com, roger.pau@citrix.com, jbeulich@suse.com, 
    andrew.cooper3@citrix.com, george.dunlap@citrix.com, paul@xen.org, 
    bertrand.marquis@arm.com, rahul.singh@arm.com, 
    Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>, 
    Ian Jackson <iwj@xenproject.org>, Juergen Gross <jgross@suse.com>
Subject: Re: [PATCH v5 07/10] libxl: Only map legacy PCI IRQs if they are
 supported
In-Reply-To: <YWRoMtLTd4G55koT@perard>
Message-ID: <alpine.DEB.2.21.2110111329520.25528@sstabellini-ThinkPad-T480s>
References: <20211008055535.337436-1-andr2000@gmail.com> <20211008055535.337436-8-andr2000@gmail.com> <YWRoMtLTd4G55koT@perard>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Mon, 11 Oct 2021, Anthony PERARD wrote:
> On Fri, Oct 08, 2021 at 08:55:32AM +0300, Oleksandr Andrushchenko wrote:
> > From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> > 
> > Arm's PCI passthrough implementation doesn't support legacy interrupts,
> > but MSI/MSI-X. This can be the case for other platforms too.
> > For that reason introduce a new CONFIG_PCI_SUPP_LEGACY_IRQ and add
> > it to the CFLAGS and compile the relevant code in the toolstack only if
> > applicable.
> 
> I don't think that's true anymore since v2 ;-). The compiler may
> choose to avoid compiling code that wouldn't be executed, but I think
> that would just be optimisation.
> 
> > Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> > Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
> > Reviewed-by: Rahul Singh <rahul.singh@arm.com>
> > Tested-by: Rahul Singh <rahul.singh@arm.com>
> > ---
> > diff --git a/tools/libs/light/Makefile b/tools/libs/light/Makefile
> > index 7d8c51d49242..bd3f6be2a183 100644
> > --- a/tools/libs/light/Makefile
> > +++ b/tools/libs/light/Makefile
> > @@ -46,6 +46,10 @@ CFLAGS += -Wno-format-zero-length -Wmissing-declarations \
> >  	-Wno-declaration-after-statement -Wformat-nonliteral
> >  CFLAGS += -I.
> >  
> > +ifeq ($(CONFIG_X86),y)
> > +CFLAGS += -DCONFIG_PCI_SUPP_LEGACY_IRQ
> > +endif
> > +
> 
> Could you write this instead:
>   CFLAGS-$(CONFIG_X86) += -DCONFIG_PCI_SUPP_LEGACY_IRQ
> 
> In any case,
> Acked-by: Anthony PERARD <anthony.perard@citrix.com>

Thanks Anthony! I made this change on commit and committed both this
patch and the previous one.


From xen-devel-bounces@lists.xenproject.org Tue Oct 12 01:32:35 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 01:32:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.206656.362280 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ma6eh-0001Pe-05; Tue, 12 Oct 2021 01:32:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 206656.362280; Tue, 12 Oct 2021 01:32:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ma6eg-0001PV-Sj; Tue, 12 Oct 2021 01:32:34 +0000
Received: by outflank-mailman (input) for mailman id 206656;
 Tue, 12 Oct 2021 01:32:33 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=SIAI=PA=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1ma6ef-0001Od-NT
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 01:32:33 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 456a324a-2afc-11ec-8102-12813bfff9fa;
 Tue, 12 Oct 2021 01:32:33 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id 28F8060F43;
 Tue, 12 Oct 2021 01:32:32 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 456a324a-2afc-11ec-8102-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1634002352;
	bh=LehBiNxPKkdBlc0pnX5/g6rgQkE4rqRjslMnfsgQJB8=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=gWJ4H2vVY7t/wGWZBcDS7nPcjQo3YklTOakwewlKA500Ja9/boFudUJCDphArBcLr
	 4jmfGgXf6kl1L/F+csfXcTRX6AmjvVm2NVF/75cJeEqPUOrdNZwh6/7P3OHWqaGOHQ
	 +LZ4zFHwRe2GMZ1eNLfZxpUFlbgq/sI8PqHAnGBRDCA5WWx7p/ZLca2DYbkq/uJr6s
	 ME+7QOiQnA/ybqSlhroLMCz7N5vksYdJj3bn8PW0jPpR9RbfO0meSzFCw2sGeBvw0U
	 BZ6HGtoFuE+Q/wh0MRWjtjjN6QeE1Eq5LJHz68BSeUW6x3fhC0HyPm6J6itAqLpJnS
	 NhpfiQjJIA6JA==
Date: Mon, 11 Oct 2021 18:32:31 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Bertrand Marquis <Bertrand.Marquis@arm.com>
cc: =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= <roger.pau@citrix.com>, 
    Rahul Singh <Rahul.Singh@arm.com>, 
    "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, 
    Andre Przywara <Andre.Przywara@arm.com>, 
    Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH v5 09/11] xen/arm: Transitional change to build HAS_VPCI
 on ARM.
In-Reply-To: <647F47F9-E89B-43C3-8226-5F59286CA0C8@arm.com>
Message-ID: <alpine.DEB.2.21.2110111318460.25528@sstabellini-ThinkPad-T480s>
References: <cover.1633540842.git.rahul.singh@arm.com> <b9653c6247060574cf68e1f780ef1db3dd0c20d3.1633540842.git.rahul.singh@arm.com> <YWQjTOypE96IqWmA@MacBook-Air-de-Roger.local> <647F47F9-E89B-43C3-8226-5F59286CA0C8@arm.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: multipart/mixed; BOUNDARY="8323329-763960906-1633983540=:25528"
Content-ID: <alpine.DEB.2.21.2110111832290.25528@sstabellini-ThinkPad-T480s>

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-763960906-1633983540=:25528
Content-Type: text/plain; CHARSET=UTF-8
Content-Transfer-Encoding: 8BIT
Content-ID: <alpine.DEB.2.21.2110111832291.25528@sstabellini-ThinkPad-T480s>

On Mon, 11 Oct 2021, Bertrand Marquis wrote:
> Hi Roger,
> 
> > On 11 Oct 2021, at 12:43, Roger Pau Monné <roger.pau@citrix.com> wrote:
> > 
> > On Wed, Oct 06, 2021 at 06:40:35PM +0100, Rahul Singh wrote:
> >> This patch will be reverted once we add support for VPCI MSI/MSIX
> >> support on ARM.
> >> 
> >> Signed-off-by: Rahul Singh <rahul.singh@arm.com>
> >> Acked-by: Stefano Stabellini <sstabellini@kernel.org>
> >> Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>
> > 
> > Reviewed-by: Roger Pau Monné <rogewr.pau@citrix.com>
> 
> Thanks

Thanks! I committed this patch.
--8323329-763960906-1633983540=:25528--


From xen-devel-bounces@lists.xenproject.org Tue Oct 12 02:29:44 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 02:29:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.206679.362307 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ma7Xn-0007Kw-Ad; Tue, 12 Oct 2021 02:29:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 206679.362307; Tue, 12 Oct 2021 02:29:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ma7Xn-0007Kp-6s; Tue, 12 Oct 2021 02:29:31 +0000
Received: by outflank-mailman (input) for mailman id 206679;
 Tue, 12 Oct 2021 02:29:29 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=O3og=PA=arm.com=Penny.Zheng@srs-us1.protection.inumbo.net>)
 id 1ma7Xl-0007Kj-Js
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 02:29:29 +0000
Received: from EUR02-HE1-obe.outbound.protection.outlook.com (unknown
 [40.107.1.80]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 384d0788-2b04-11ec-8102-12813bfff9fa;
 Tue, 12 Oct 2021 02:29:27 +0000 (UTC)
Received: from AM6PR08CA0028.eurprd08.prod.outlook.com (2603:10a6:20b:c0::16)
 by AM4PR08MB2628.eurprd08.prod.outlook.com (2603:10a6:205:c::13) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.25; Tue, 12 Oct
 2021 02:29:24 +0000
Received: from VE1EUR03FT051.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:c0:cafe::a2) by AM6PR08CA0028.outlook.office365.com
 (2603:10a6:20b:c0::16) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18 via Frontend
 Transport; Tue, 12 Oct 2021 02:29:24 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT051.mail.protection.outlook.com (10.152.19.75) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4587.18 via Frontend Transport; Tue, 12 Oct 2021 02:29:23 +0000
Received: ("Tessian outbound a8bfe25d7364:v103");
 Tue, 12 Oct 2021 02:29:23 +0000
Received: from 954cb03bd255.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 CD500A6E-C049-49F8-9839-A86FB5553C2E.1; 
 Tue, 12 Oct 2021 02:29:17 +0000
Received: from EUR02-AM5-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 954cb03bd255.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Tue, 12 Oct 2021 02:29:17 +0000
Received: from VE1PR08MB5215.eurprd08.prod.outlook.com (2603:10a6:803:10a::33)
 by VI1PR08MB3406.eurprd08.prod.outlook.com (2603:10a6:803:7b::32)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.19; Tue, 12 Oct
 2021 02:29:16 +0000
Received: from VE1PR08MB5215.eurprd08.prod.outlook.com
 ([fe80::41d6:b115:3b22:2cd]) by VE1PR08MB5215.eurprd08.prod.outlook.com
 ([fe80::41d6:b115:3b22:2cd%2]) with mapi id 15.20.4587.026; Tue, 12 Oct 2021
 02:29:16 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 384d0788-2b04-11ec-8102-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=PVIEyy3QOklML/pa/qDqtFCqZ+r61uQKBWWmHlqHiIM=;
 b=rtsOKu7541/JLwq15EHCHNBJbs6q1oYXl46lbX3Lg4153Hs7Hy6/Un/23TBNWnDIR2LxrP2G63jK4RdHxSJkiCo9x0UnTJLjXAn3IKKEfbbxKe9XcBu7sk7DqFpyRofc1D06iacKeSEAwvuwb5y0Gc4aPELNGAYwtrPcQGdKqEY=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=IbDdndyRPOL04CiBixPaJGbKIyFOrDRyWJs+4GBv0xttl5lNDKIppVqiroN8lT8zupmJkNnZmgdTJx6NZtXC6/RkADMFgjYYuYyACOEsDG/NRzNnqWcFiK/l/yZCy+HSd31XLHzTcMAhsGiOkwLksWvtqUuUKYwM7+nc4IMpwPrzHkJ5LHR0CryD64DBucZM0GFJ5acARcdg2bMR21F3dFuNJitI5AsYaT/IWMUDoHTh7c/yx8JgT6b+LXhhNzDw/qGolWCXfbTpqTto85to2NPG3X7RlTSjqLCZJwRNPGYeMO8rIBBrJvRtfq2eGNkShKGUxQ97fjHXrnbKfqykbw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=PVIEyy3QOklML/pa/qDqtFCqZ+r61uQKBWWmHlqHiIM=;
 b=FVThkmEXe1yROp7MJvNy6llF0sw+UoCKVky+q7Y2cA+3sQRyxIx8ZjUXs+auJ/iMgtDryjdkf4CREAYFQXVMtTPoHAY9IH9v15QwiJvxNBV+tPvzYG586Ybu3vHa5j0lLaq43bnB1KVyI4R4AjkGM81h4dunrJ0hvCJHKt69Xmxtj5IBt7oL8o3lKFkBA1ckSEPlgPC5qaY4GMZe1i4vmxXmVAw3XBvbTy096q2GqtvcOLYwUXVroCsJPalsi7SGlBCXZXc5zksPzpHXMdF0X8aq4AhQMkS898MmJjkmHuIR3oFjsiEoghCgcrWTVpPqBM3tCSlEnmjUg5j+aNKehw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=PVIEyy3QOklML/pa/qDqtFCqZ+r61uQKBWWmHlqHiIM=;
 b=rtsOKu7541/JLwq15EHCHNBJbs6q1oYXl46lbX3Lg4153Hs7Hy6/Un/23TBNWnDIR2LxrP2G63jK4RdHxSJkiCo9x0UnTJLjXAn3IKKEfbbxKe9XcBu7sk7DqFpyRofc1D06iacKeSEAwvuwb5y0Gc4aPELNGAYwtrPcQGdKqEY=
From: Penny Zheng <Penny.Zheng@arm.com>
To: Julien Grall <julien@xen.org>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, "sstabellini@kernel.org"
	<sstabellini@kernel.org>
CC: Bertrand Marquis <Bertrand.Marquis@arm.com>, Wei Chen <Wei.Chen@arm.com>
Subject: RE: [PATCH 10/11] xen/arm: device assignment on 1:1 direct-map domain
Thread-Topic: [PATCH 10/11] xen/arm: device assignment on 1:1 direct-map
 domain
Thread-Index: AQHXsCjEx0HGlBpA+Em1L92CXDXaB6uxe3AAgBj87fCAA0mcAIAA/Yeg
Date: Tue, 12 Oct 2021 02:29:15 +0000
Message-ID:
 <VE1PR08MB521558584344ED4A7D97CA4AF7B69@VE1PR08MB5215.eurprd08.prod.outlook.com>
References: <20210923031115.1429719-1-penny.zheng@arm.com>
 <20210923031115.1429719-11-penny.zheng@arm.com>
 <c6730ec5-53c7-9bf2-4620-eefbc7c7c4a3@xen.org>
 <VE1PR08MB5215A1D5695F388F17C367D4F7B39@VE1PR08MB5215.eurprd08.prod.outlook.com>
 <9237c85c-87d0-14ac-07ce-244958add7d3@xen.org>
In-Reply-To: <9237c85c-87d0-14ac-07ce-244958add7d3@xen.org>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: 63436D5B58CE0448AB37AF11C4E5BC46.0
x-checkrecipientchecked: true
Authentication-Results-Original: xen.org; dkim=none (message not signed)
 header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: 91237540-c42c-4fe3-9b4b-08d98d281b02
x-ms-traffictypediagnostic: VI1PR08MB3406:|AM4PR08MB2628:
x-ms-exchange-transport-forked: True
X-Microsoft-Antispam-PRVS:
	<AM4PR08MB262844155A70FA86F2B4AA3EF7B69@AM4PR08MB2628.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:9508;OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 wqLrc215ejlKxvqMGTvRV4cuDK1v8GklhK7UwmTzMnU0K/ed1F2+EWUijcB6Qe1bCd1XMweoala7NgKDsm37ud3RPwJHLui3S6vZsEl605/uHhwrq15Ikd+N26x+3ugIKYK82fs05uZm3vHwCmno42F5RuDtgylsZSu/gLluuVYyn3AlGqKzHva9GB9oJs35lJ6aNp99FcaCfQM5A5Y6AIw85/+MPEAzooHXYnmgq5qHn1YvJ7yekWhl6UxhPG3BwdiI/ZhEFo1+ag5bQjIDHLFx6u4bBqIoum8A5RpsfC5H8PPu5Nre2DGIdJVixAio+rMPKq2dl85IxWONp/7DHnPD6cSF8LM62C2e0NJYCGy9SLbxuTyMxKvGAVt/QTPAWkWjPWyMdB9P970BqurF1NFJQcGU572LKZRFjFKxbSKqWf8NsDfsc8kWULaFJRzaJmsaKRm2OPriguRB1svcAHKWj3TrSNiwsJK9g4OemryoZ1y+AyCc2YGEwrKvVrqqnd0He7cUltnvY+/LqPpkRtMCeMuMDwgM1Ev3QteG6u26InP1nOfhJJ5iFrmFk1Hr72hmR1k6CtZ0VYv+t8MFccgxEePRj0D4RLROGsNl6cgh7p/qG3iSHSmrKuOn8JxWb2PyRpCySpkgHgAYKPx++HEIsZeuTL3hOWBpoWA2H+ZHwlPXGCpm2EzAaGnLqTxePe6EyfYzY1Rcm/ZKs25m3A==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR08MB5215.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(66476007)(9686003)(110136005)(4326008)(38100700002)(26005)(52536014)(5660300002)(55016002)(54906003)(33656002)(38070700005)(8936002)(122000001)(186003)(66446008)(508600001)(66556008)(316002)(66946007)(8676002)(76116006)(2906002)(64756008)(83380400001)(6506007)(71200400001)(53546011)(86362001)(7696005);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3406
Original-Authentication-Results: xen.org; dkim=none (message not signed)
 header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT051.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	f386a2d5-7be0-40b8-277c-08d98d281638
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	4zQsdqTPQgJrgFF3zlt19k4U9BYsbsOKZkx2ChNhau7cYtTk4wg/N2+GfjjEqeMco4mJ66VsFxGp8KqakC1Qq+9hbK33f0PeZJZex661BbIx/u6vZHnEhpKwXdaC/8C21ZcLRxfeq7SFkgHyKZWMY2M96I8HvFKmbA/yKUAddrQ0+pFSzcVBu4uz0u2xSCpVn3yNB8c9NqeGYKjjov9PS1tZoTJpOlH06KUU4EqZ/B0el9UuxFr4ARk+MFdD2GOAfB09BGeotIki54tjD8QSdV7JMTHRUGq7F8g4+eVbIy4CHTBJXESh5iUkfnw5MXa/wZNwATWCRW8wdXdvL07BJU5ZG/JA6eD1uCA4j9n5jjCxi6n/49HpAhbYf0lvky0tyYK3rZ6gU/FJq9Mg+abEyd7KQ9MTd8+lzygjsDjj+Y4nWRXNDMDC3J5hEHTfl/Jz06tz8OB30IXmXP3pxzFbWD9Hn6nx1xhSKbpDGNodMVGdUVDlCuiL4VNHtYdRKd+Xfo+4hXXUYLAKRMSE/i+D8irtHnkowwJkwITkXaPbLsWLjnZ124Bb/5vobhR4hhL2AkA/bjEQjl40QhRCuBwlnWKnupOx6XfAqB4HOjldoCHOCeN/VgQGI1xYHjM0EiZYsDuwbje47hIxFX8hTXn+qqfnww5ATfRuhYY+elxQYAzdL2PE9BlTQIloBSrOfgedNBpiXxUxxEgrpQuZh8KeVw==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(356005)(47076005)(83380400001)(53546011)(6506007)(54906003)(336012)(9686003)(316002)(110136005)(4326008)(5660300002)(81166007)(55016002)(86362001)(7696005)(508600001)(8936002)(70206006)(52536014)(8676002)(26005)(36860700001)(2906002)(186003)(82310400003)(33656002)(70586007);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2021 02:29:23.9820
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 91237540-c42c-4fe3-9b4b-08d98d281b02
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT051.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR08MB2628

SGkganVsaWVuDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogSnVsaWVu
IEdyYWxsIDxqdWxpZW5AeGVuLm9yZz4NCj4gU2VudDogTW9uZGF5LCBPY3RvYmVyIDExLCAyMDIx
IDc6MTQgUE0NCj4gVG86IFBlbm55IFpoZW5nIDxQZW5ueS5aaGVuZ0Bhcm0uY29tPjsgeGVuLWRl
dmVsQGxpc3RzLnhlbnByb2plY3Qub3JnOw0KPiBzc3RhYmVsbGluaUBrZXJuZWwub3JnDQo+IENj
OiBCZXJ0cmFuZCBNYXJxdWlzIDxCZXJ0cmFuZC5NYXJxdWlzQGFybS5jb20+OyBXZWkgQ2hlbg0K
PiA8V2VpLkNoZW5AYXJtLmNvbT4NCj4gU3ViamVjdDogUmU6IFtQQVRDSCAxMC8xMV0geGVuL2Fy
bTogZGV2aWNlIGFzc2lnbm1lbnQgb24gMToxIGRpcmVjdC1tYXANCj4gZG9tYWluDQo+IA0KPiAN
Cj4gDQo+IE9uIDA5LzEwLzIwMjEgMTA6NDAsIFBlbm55IFpoZW5nIHdyb3RlOg0KPiA+IEhpIEp1
bGllbg0KPiANCj4gSGkgUGVubnksDQo+IA0KPiA+DQo+ID4+IC0tLS0tT3JpZ2luYWwgTWVzc2Fn
ZS0tLS0tDQo+ID4+IEZyb206IEp1bGllbiBHcmFsbCA8anVsaWVuQHhlbi5vcmc+DQo+ID4+IFNl
bnQ6IFRodXJzZGF5LCBTZXB0ZW1iZXIgMjMsIDIwMjEgNzoyNyBQTQ0KPiA+PiBUbzogUGVubnkg
WmhlbmcgPFBlbm55LlpoZW5nQGFybS5jb20+Ow0KPiA+PiB4ZW4tZGV2ZWxAbGlzdHMueGVucHJv
amVjdC5vcmc7IHNzdGFiZWxsaW5pQGtlcm5lbC5vcmcNCj4gPj4gQ2M6IEJlcnRyYW5kIE1hcnF1
aXMgPEJlcnRyYW5kLk1hcnF1aXNAYXJtLmNvbT47IFdlaSBDaGVuDQo+ID4+IDxXZWkuQ2hlbkBh
cm0uY29tPg0KPiA+PiBTdWJqZWN0OiBSZTogW1BBVENIIDEwLzExXSB4ZW4vYXJtOiBkZXZpY2Ug
YXNzaWdubWVudCBvbiAxOjENCj4gPj4gZGlyZWN0LW1hcCBkb21haW4NCj4gPj4NCj4gPj4gSGks
DQo+ID4+DQo+ID4+IE9uIDIzLzA5LzIwMjEgMDg6MTEsIFBlbm55IFpoZW5nIHdyb3RlOg0KPiA+
Pj4gVXNlciBjb3VsZCBkbyBkZXZpY2UgcGFzc3Rocm91Z2gsIHdpdGgNCj4gPj4+ICJ4ZW4sZm9y
Y2UtYXNzaWduLXdpdGhvdXQtaW9tbXUiIGluIHRoZSBkZXZpY2UgdHJlZSBzbmlwcGV0LCBvbg0K
PiA+Pj4gdHJ1c3RlZCBndWVzdCB0aHJvdWdoIDE6MSBkaXJlY3QtbWFwLCBpZiBJT01NVSBhYnNl
bnQgb3IgZGlzYWJsZWQgb24NCj4gPj4gaGFyZHdhcmUuDQo+ID4+DQo+ID4+IEF0IHRoZSBtb21l
bnQsIGl0IHdvdWxkIGJlIHBvc3NpYmxlIHRvIHBhc3N0aHJvdWdoIGEgbm9uLURNQSBjYXBhYmxl
DQo+ID4+IGRldmljZSB3aXRoIGRpcmVjdC1tYXBwaW5nLiBBZnRlciB0aGlzIHBhdGNoLCB0aGlz
IGlzIGdvaW5nIHRvIGJlIGZvcmJpZGRlbi4NCj4gPj4NCj4gPj4+DQo+ID4+PiBJbiBvcmRlciB0
byBhY2hpZXZlIHRoYXQsIHRoaXMgcGF0Y2ggYWRkcyAxOjEgZGlyZWN0LW1hcCBjaGVjayBhbmQN
Cj4gPj4+IGRpc2FibGVzIGlvbW11LXJlbGF0ZWQgYWN0aW9uLg0KPiA+Pj4NCj4gPj4+IFNpZ25l
ZC1vZmYtYnk6IFBlbm55IFpoZW5nIDxwZW5ueS56aGVuZ0Bhcm0uY29tPg0KPiA+Pj4gLS0tDQo+
ID4+PiAgICB4ZW4vYXJjaC9hcm0vZG9tYWluX2J1aWxkLmMgfCAxMiArKysrKysrKy0tLS0NCj4g
Pj4+ICAgIDEgZmlsZSBjaGFuZ2VkLCA4IGluc2VydGlvbnMoKyksIDQgZGVsZXRpb25zKC0pDQo+
ID4+Pg0KPiA+Pj4gZGlmZiAtLWdpdCBhL3hlbi9hcmNoL2FybS9kb21haW5fYnVpbGQuYw0KPiA+
Pj4gYi94ZW4vYXJjaC9hcm0vZG9tYWluX2J1aWxkLmMgaW5kZXggYzkyZTUxMGFlNy4uOWE5ZDI1
MjJiNyAxMDA2NDQNCj4gPj4+IC0tLSBhL3hlbi9hcmNoL2FybS9kb21haW5fYnVpbGQuYw0KPiA+
Pj4gKysrIGIveGVuL2FyY2gvYXJtL2RvbWFpbl9idWlsZC5jDQo+ID4+PiBAQCAtMjA3MCwxNCAr
MjA3MCwxOCBAQCBzdGF0aWMgaW50IF9faW5pdA0KPiA+PiBoYW5kbGVfcGFzc3Rocm91Z2hfcHJv
cChzdHJ1Y3Qga2VybmVsX2luZm8gKmtpbmZvLA0KPiA+Pj4gICAgICAgIGlmICggcmVzIDwgMCAp
DQo+ID4+PiAgICAgICAgICAgIHJldHVybiByZXM7DQo+ID4+Pg0KPiA+Pj4gKyAgICAvKg0KPiA+
Pj4gKyAgICAgKiBJZiB4ZW5fZm9yY2UsIHdlIGFsbG93IGFzc2lnbm1lbnQgb2YgZGV2aWNlcyB3
aXRob3V0IElPTU1VDQo+ID4+IHByb3RlY3Rpb24uDQo+ID4+PiArICAgICAqIEFuZCBpZiBJT01N
VSBpcyBkaXNhYmxlZCBvciBhYnNlbnQsIDE6MSBkaXJlY3QtbWFwIGlzDQo+ID4+PiArIG5lY2Vz
c2FyeSA+ICsNCj4gPj4gKi8NCj4gPj4+ICsgICAgaWYgKCB4ZW5fZm9yY2UgJiYgaXNfZG9tYWlu
X2RpcmVjdF9tYXBwZWQoa2luZm8tPmQpICYmDQo+ID4+PiArICAgICAgICAgIWR0X2RldmljZV9p
c19wcm90ZWN0ZWQobm9kZSkgKQ0KPiA+Pg0KPiA+PiBkdF9kZXZpY2VfaXNfcHJvdGVjdGVkKCkg
d2lsbCBiZSBhbHdheXMgZmFsc2UgdW5sZXNzIHRoZSBkZXZpY2UgaXMNCj4gPj4gcHJvdGVjdGVk
IGJlaGluZyBhbiBTTU1VIHVzaW5nIHRoZSBsZWdhY3kgYmluZGluZy4gU28gSSBkb24ndCB0aGlu
aw0KPiA+PiB0aGlzIGlzIGNvcnJlY3QgdG8gbW92ZSB0aGlzIGNoZWNrIGFoZWFkLiBJbiBmYWN0
Li4NCj4gPj4NCj4gPj4+ICsgICAgICAgIHJldHVybiAwOw0KPiA+Pj4gKw0KPiA+Pj4gICAgICAg
IHJlcyA9IGlvbW11X2FkZF9kdF9kZXZpY2Uobm9kZSk7DQo+ID4+DQo+ID4+IC4uLiB0aGUgY2Fs
bCBzaG91bGQgYWxyZWFkeSBiZSBhIE5PUCB3aGVuIHRoZSBJT01NVSBpcyBkaXNhYmxlZCBvcg0K
PiA+PiB0aGUgZGV2aWNlIGlzIG5vdCBiZWhpbmQgYW4gSU9NTVUuIFNvIGNhbiB5b3UgZXhwbGFp
biB3aGF0IHlvdSBhcmUNCj4gPj4gdHJ5aW5nIHRvIHByZXZlbnQgaGVyZT8NCj4gPj4NCj4gPg0K
PiA+IElmIHRoZSBJT01NVSBpcyBkaXNhYmxlZCwgaW9tbXVfYWRkX2R0X2RldmljZSB3aWxsIHJl
dHVybiAxIGFzIGVycm5vLg0KPiA+IFNvIHdlIGNvdWxkIG5vdCBtYWtlIGl0IHRvIHRoZSB4ZW5f
Zm9yY2UgY2hlY2suLi4NCj4gDQo+IEkgZGlzYWdyZWUuIFRoZSBjaGVjayBpczoNCj4gDQo+IGlm
ICggcmVzIDwgMCApDQo+ICAgIHJldHVybiByZXM7DQo+IA0KPiBHaXZlbiB0aGF0IHJlcyBpcyAx
LCB3ZSB3b3VsZG4ndCByZXR1cm4gYW5kIG1vdmUgdG8gY2hlY2sgd2hldGhlciB0aGUNCj4gYXNz
aWdubWVudCBjYW4gYmUgZG9uZS4NCj4gDQo+ID4NCj4gPiBTbyBJIHRyaWVkIHRvIG1vdmUgYWxs
IElPTU1VIGFjdGlvbiBiZWhpbmQgeGVuX2ZvcmNlIGNoZWNrLg0KPiA+DQo+ID4gTm93LCBkZXZp
Y2UgYXNzaWdubWVudCB3aXRob3V0IElPTU1VIHByb3RlY3Rpb24gaXMgb25seSBhcHBsaWNhYmxl
IG9uDQo+ID4gZGlyZWN0LW1hcCBkb21haW5zLA0KPiANCj4gSXQgaXMgZmluZSB0byBhc3NpZ24g
YSBub24tRE1BIGNhcGFibGUgZGV2aWNlIHdpdGhvdXQgZGlyZWN0LW1hcHBpbmcuIFNvIHdoeQ0K
PiBkbyB5b3Ugd2FudCB0byBhZGQgdGhpcyByZXN0cmljdGlvbj8NCg0KSSB1bmRlcnN0YW5kLg0K
SWYgaXQgaXMgZmluZSB0byBhc3NpZ24gYSBub24tRE1BIGNhcGFibGUgZGV2aWNlIHdpdGhvdXQg
ZGlyZWN0LW1hcHBpbmcsIHRoZSBmb3JtZXINCmNvbW1pdCBjb250YWluaW5nIHRoZSBmb2xsb3dp
bmcgY2hhbmdlcyBuZWVkcyBmaXguDQoNCiAgICAgICAgIGlmICggZHRfZmluZF9jb21wYXRpYmxl
X25vZGUobm9kZSwgTlVMTCwgIm11bHRpYm9vdCxkZXZpY2UtdHJlZSIpICkNCiAgICAgICAgew0K
ICAgICAgICAgICAgaWYgKCBpb21tdV9lbmFibGVkICkNCiAgICAgICAgICAgICAgICBkX2NmZy5m
bGFncyB8PSBYRU5fRE9NQ1RMX0NERl9pb21tdTsNCiAgICAgICAgICAgIGVsc2UgaWYgKCBkX2Nm
Zy5mbGFncyAmIFhFTl9ET01DVExfSU5URVJOQUxfZGlyZWN0bWFwICkNCiAgICAgICAgICAgICAg
ICB3YXJuaW5nX2FkZCgiUGxlYXNlIGJlIHN1cmUgb2YgaGF2aW5nIHRydXN0ZWQgZ3Vlc3RzLCB3
aGVuIGRvaW5nIGRldmljZSBhc3NpZ25tZW50IHdpdGhvdXQgSU9NTVUgcHJvdGVjdGlvblxuIik7
DQogICAgICAgICAgICBlbHNlDQogICAgICAgICAgICAgICAgcGFuaWMoIkFzc2lnbiBhIGRldmlj
ZSBidXQgSU9NTVUgYW5kIGRpcmVjdC1tYXAgYXJlIGFsbCBkaXNhYmxlZFxuIik7DQogICAgICAg
IH0NCg0KRGVmaW5pdGVseSBubyBwYW5pYyB3aGVuIElPTU1VIGFuZCBkaXJlY3QtbWFwIGFyZSBh
bGwgZGlzYWJsZWQuDQoNCj4gDQo+IENoZWVycywNCj4gDQo+IC0tDQo+IEp1bGllbiBHcmFsbA0K


From xen-devel-bounces@lists.xenproject.org Tue Oct 12 02:43:01 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 02:43:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.206687.362317 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ma7km-00017g-GH; Tue, 12 Oct 2021 02:42:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 206687.362317; Tue, 12 Oct 2021 02:42:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ma7km-00017Z-DE; Tue, 12 Oct 2021 02:42:56 +0000
Received: by outflank-mailman (input) for mailman id 206687;
 Tue, 12 Oct 2021 02:42:55 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=O3og=PA=arm.com=Penny.Zheng@srs-us1.protection.inumbo.net>)
 id 1ma7kl-00017D-4P
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 02:42:55 +0000
Received: from EUR02-VE1-obe.outbound.protection.outlook.com (unknown
 [40.107.2.84]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 3cf5b682-3cdb-498e-8754-aa845def9c99;
 Tue, 12 Oct 2021 02:42:52 +0000 (UTC)
Received: from DB6PR07CA0055.eurprd07.prod.outlook.com (2603:10a6:6:2a::17) by
 VI1PR0802MB2205.eurprd08.prod.outlook.com (2603:10a6:800:9d::14) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.22; Tue, 12 Oct
 2021 02:42:49 +0000
Received: from DB5EUR03FT014.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:6:2a:cafe::46) by DB6PR07CA0055.outlook.office365.com
 (2603:10a6:6:2a::17) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.4 via Frontend
 Transport; Tue, 12 Oct 2021 02:42:49 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT014.mail.protection.outlook.com (10.152.20.102) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4587.18 via Frontend Transport; Tue, 12 Oct 2021 02:42:48 +0000
Received: ("Tessian outbound e27daf245730:v103");
 Tue, 12 Oct 2021 02:42:48 +0000
Received: from 3097b8fb5dca.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 EA6E444B-50D5-4591-A1EE-9D137911371E.1; 
 Tue, 12 Oct 2021 02:42:42 +0000
Received: from EUR02-AM5-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 3097b8fb5dca.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Tue, 12 Oct 2021 02:42:42 +0000
Received: from VE1PR08MB5215.eurprd08.prod.outlook.com (2603:10a6:803:10a::33)
 by VI1PR0802MB2173.eurprd08.prod.outlook.com (2603:10a6:800:a2::7)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.22; Tue, 12 Oct
 2021 02:42:39 +0000
Received: from VE1PR08MB5215.eurprd08.prod.outlook.com
 ([fe80::41d6:b115:3b22:2cd]) by VE1PR08MB5215.eurprd08.prod.outlook.com
 ([fe80::41d6:b115:3b22:2cd%2]) with mapi id 15.20.4587.026; Tue, 12 Oct 2021
 02:42:39 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3cf5b682-3cdb-498e-8754-aa845def9c99
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=4NaK2pzKJGtunX1b9aH4TQwTRRIHHBEnSoEkQR7CX2I=;
 b=159GRSqb8bK+aeUyxBwAiRnREedkfWdajb5/slg9moidQkgHRXpkPK+FNz2YdCjcgPNC9nD7EcBdHX7TNfZfvizOa5pCymcFINGXmB2XUbrbiN8NmDCFRPPdgDjBHyFECnVmB4bJj8QnLwgpgGPVDGb285f8/9IBkuyCSZNOwLM=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=h/3uxxpWiUEx7tE5U1zTdnnGyIvefCiIW59VDzbXVh84KJ5G88I73zrrgBBQ63a62UIGOf7+yakhKm3Z8dR3ZI6IKwdjlxZSS9KabqCFvVL6cTzpO3SxspsC5o+lzGST5AmyxhQlYThRsWIKrwNp0w9igPeqHoqCo5KT30yGM4R3VyWE6y40cYRum348zleog4bcJrX2ni9r7SXMYrGxjOg1E/VbFr1TpjArcD3FHlx9qB0TFodQPG54xdxGvEI+RFDUA2XfDPII3EjsIpAT1qKEeHbvj6kZIXu9Wdjc4ZWRXWElNgDqqDXy7Xd44fENERtLDXtGU66uE+e9z7cetw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=4NaK2pzKJGtunX1b9aH4TQwTRRIHHBEnSoEkQR7CX2I=;
 b=V092FK9PVE3GtrYcG7JNt7FeY3FqqdGSZm/19vm9onN2+AaQEaXZVZGDakaYMm2Yiu968PrvMoYjfDLk7VWLXcLfqH9DrRAAY8wPEk8rYO1V3ARVeWuom/4KMa25UoPDoeUsvp2wn0U9cpuJZJp6sz7wTKTdtnAFJo1Q5+RtyU2k3af11Cq+LfUdKSBRlIgXHG8/tluPOYgQkKOmMqsw5GSYJRcPZTPXLxe2l2fujsdD4ZCt+DVs0gCltdA3pA55jKfDSG2HbAIDpGALGIteuZVzGXv0VvyUc9cNhc2jDwun0IjmySZrxeCMTf+eADv41F13ld4Xxe7xKKs4l5/sxw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=4NaK2pzKJGtunX1b9aH4TQwTRRIHHBEnSoEkQR7CX2I=;
 b=159GRSqb8bK+aeUyxBwAiRnREedkfWdajb5/slg9moidQkgHRXpkPK+FNz2YdCjcgPNC9nD7EcBdHX7TNfZfvizOa5pCymcFINGXmB2XUbrbiN8NmDCFRPPdgDjBHyFECnVmB4bJj8QnLwgpgGPVDGb285f8/9IBkuyCSZNOwLM=
From: Penny Zheng <Penny.Zheng@arm.com>
To: Julien Grall <julien@xen.org>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, "sstabellini@kernel.org"
	<sstabellini@kernel.org>
CC: Bertrand Marquis <Bertrand.Marquis@arm.com>, Wei Chen <Wei.Chen@arm.com>
Subject: RE: [PATCH 09/11] xen/arm: if 1:1 direct-map domain use native UART
 address and IRQ number for vPL011
Thread-Topic: [PATCH 09/11] xen/arm: if 1:1 direct-map domain use native UART
 address and IRQ number for vPL011
Thread-Index: AQHXsCjCE2lhlSGmBkKIt8npCa4pm6uxd+8AgBj2EFCAA0z5AIABBw7Q
Date: Tue, 12 Oct 2021 02:42:39 +0000
Message-ID:
 <VE1PR08MB5215C5883D3913F14C6F246AF7B69@VE1PR08MB5215.eurprd08.prod.outlook.com>
References: <20210923031115.1429719-1-penny.zheng@arm.com>
 <20210923031115.1429719-10-penny.zheng@arm.com>
 <db752d34-fc23-04b3-3c84-12d4de6859e0@xen.org>
 <VE1PR08MB5215F07156273D0822515E92F7B39@VE1PR08MB5215.eurprd08.prod.outlook.com>
 <45f31ced-f011-a8fd-5c80-822b9c731adb@xen.org>
In-Reply-To: <45f31ced-f011-a8fd-5c80-822b9c731adb@xen.org>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: 88DE8C755FD6B24D817D65652C86E949.0
x-checkrecipientchecked: true
Authentication-Results-Original: xen.org; dkim=none (message not signed)
 header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: e927127d-7658-4ce5-cf1c-08d98d29fac1
x-ms-traffictypediagnostic: VI1PR0802MB2173:|VI1PR0802MB2205:
x-ms-exchange-transport-forked: True
X-Microsoft-Antispam-PRVS:
	<VI1PR0802MB2205C6F2F05C2BC27D528A17F7B69@VI1PR0802MB2205.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:9508;OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 KngXgfmxOJ45VXKiaLuPW+DPhOVjrNJQAVgPJs8OQxTWvXINH1TBw2Bxl0Jg3n5F9q9QKcUUWCAyVCJ2beinrtOZ1aPgPYbswkmH/2/imCfHbgOB8GUjzv98Yf3bpQ7AU2sRAG5a+7LNtC8w3muEjs/E7gjPFFs7eGKRV0YEtiOq2NPjd9tHX53QreAO5XsOR9aHcVfjFV71P+oQ9/M7/N2NWm1ty1U2v2IlpXffPEBdabP+8m/QqGB6S6PCGexumkMpdXbEFybkte96IP64deoPzCz8JqEvfkuJZ53PTnN3E5PgMjeXvBJf6HFKagN8rNXvtx6gS/75F0rFCiJ4ISfo4Y5djVdB9PegY6ttZi7KPSAB0dwT8cEY/h7nkQsYzYYrgq8DXCKFvZl0IpfTs7d751zB4bQ0wMnZQlkCIeCLsPvGbPbOOSAb7A0U9rxztgPBcqphBOAQkwNmWFAArSgKCMjxkUCgc6y4TmX535zhDEOWmzl2jiPA4ON49IMBlw5+YjhicWcJy3N4u7+nhOoG1whnIFQ0D7tfUCMMy8TTOd3mk+yUJI/xs+lR5D4Yu/xg/TVjWOLvsVYsnLz51OnSKKpjRgGIciPLiJ5vZl8dD7jc0LsSZJql9vYDpb2xXlBYKxEpVaxTSO0PljlHHcBEHFMR7Kcrxmw5ZD7UEmlvjdKln0VT47IYu3DJIM7Q7RqFGSQUs/e1yX87g7O5WA==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR08MB5215.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(186003)(8676002)(71200400001)(26005)(2906002)(55016002)(54906003)(76116006)(66476007)(122000001)(38070700005)(508600001)(66446008)(38100700002)(66946007)(110136005)(66556008)(4326008)(64756008)(33656002)(9686003)(83380400001)(52536014)(5660300002)(53546011)(6506007)(316002)(7696005)(8936002)(86362001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0802MB2173
Original-Authentication-Results: xen.org; dkim=none (message not signed)
 header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT014.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	49a57bad-bfff-4b69-69b4-08d98d29f535
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	YJaRkVCrBVzY6Sc60dOnEkoClbHYYaMPZoyeja+SI8jGPITTqANOr/AAv764YZMR7D43xqOGm9UkbkPaKE+XBz1erxCiX/RTxhcQmUXIoA7c5oMBTNimClYciigwbpDCPRqsiiBfrWNrH3rp/6z/tPijlmnFJCUwzxRw45KKEEZq2quEh709+dA6MAL2UItUB9nRZsFbroWlhALB3oy1id1xCwq2HnI7fnqnL0UslWOSK+tJf9bV1YYRNouq6x/sP2YW57JkNxBlqeU9cqcKURowCrSK1S2aPOgmuU7J6pEJPfjVJLILmY4IBP/uDrxHkm1K2rtG87hXZoHp18B63lRhFVARCMGdPcqKlbe41IJxaNECanZYUj1jnouElOZf8EH67BEWpYn90erby4ZGdMfr3y26KGS5QdXH1GLvMibSs4v0ZRSIr7twYYHDui68npAyKY2YM1mXpmEj7dXVoHlTeDZGTt85WotxIKpxA7v6Q8Ok60QY4DjdJt0GtbWnHKwXR/1DZlTTfI67WmBYrLkzpmKA+oAI0bcY4a6riMdpcOZ1QVAxmhvEYKhR/LDB/l7ebzxQR9ZXwEIugeY1/4lPsciRxpspcpP6JCcv22gfayJbyWF553KClHy0FiIcbjNbYO6EU2ktv7ZROvCbhdBerJX5fPT/Pb92Im5/V13w9cX4e0J2I998foSyEJXIGBIly/CaA8sNPMlnGw/a0g==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(186003)(36860700001)(81166007)(47076005)(8676002)(4326008)(336012)(82310400003)(26005)(2906002)(55016002)(54906003)(70586007)(70206006)(508600001)(356005)(110136005)(86362001)(30864003)(33656002)(83380400001)(52536014)(5660300002)(8936002)(316002)(53546011)(7696005)(6506007)(9686003);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2021 02:42:48.9746
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: e927127d-7658-4ce5-cf1c-08d98d29fac1
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT014.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0802MB2205

SGkgSnVsaWVuDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogSnVsaWVu
IEdyYWxsIDxqdWxpZW5AeGVuLm9yZz4NCj4gU2VudDogTW9uZGF5LCBPY3RvYmVyIDExLCAyMDIx
IDY6NDkgUE0NCj4gVG86IFBlbm55IFpoZW5nIDxQZW5ueS5aaGVuZ0Bhcm0uY29tPjsgeGVuLWRl
dmVsQGxpc3RzLnhlbnByb2plY3Qub3JnOw0KPiBzc3RhYmVsbGluaUBrZXJuZWwub3JnDQo+IENj
OiBCZXJ0cmFuZCBNYXJxdWlzIDxCZXJ0cmFuZC5NYXJxdWlzQGFybS5jb20+OyBXZWkgQ2hlbg0K
PiA8V2VpLkNoZW5AYXJtLmNvbT4NCj4gU3ViamVjdDogUmU6IFtQQVRDSCAwOS8xMV0geGVuL2Fy
bTogaWYgMToxIGRpcmVjdC1tYXAgZG9tYWluIHVzZSBuYXRpdmUgVUFSVA0KPiBhZGRyZXNzIGFu
ZCBJUlEgbnVtYmVyIGZvciB2UEwwMTENCj4gDQo+IE9uIDA5LzEwLzIwMjEgMDk6NDcsIFBlbm55
IFpoZW5nIHdyb3RlOg0KPiA+IEhpIEp1bGllbg0KPiANCj4gSGkgUGVubnksDQo+IA0KPiA+PiAt
LS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiA+PiBGcm9tOiBKdWxpZW4gR3JhbGwgPGp1bGll
bkB4ZW4ub3JnPg0KPiA+PiBTZW50OiBUaHVyc2RheSwgU2VwdGVtYmVyIDIzLCAyMDIxIDc6MTQg
UE0NCj4gPj4gVG86IFBlbm55IFpoZW5nIDxQZW5ueS5aaGVuZ0Bhcm0uY29tPjsNCj4gPj4geGVu
LWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnOyBzc3RhYmVsbGluaUBrZXJuZWwub3JnDQo+ID4+
IENjOiBCZXJ0cmFuZCBNYXJxdWlzIDxCZXJ0cmFuZC5NYXJxdWlzQGFybS5jb20+OyBXZWkgQ2hl
bg0KPiA+PiA8V2VpLkNoZW5AYXJtLmNvbT4NCj4gPj4gU3ViamVjdDogUmU6IFtQQVRDSCAwOS8x
MV0geGVuL2FybTogaWYgMToxIGRpcmVjdC1tYXAgZG9tYWluIHVzZQ0KPiA+PiBuYXRpdmUgVUFS
VCBhZGRyZXNzIGFuZCBJUlEgbnVtYmVyIGZvciB2UEwwMTENCj4gPj4NCj4gPj4NCj4gPj4NCj4g
Pj4gT24gMjMvMDkvMjAyMSAwODoxMSwgUGVubnkgWmhlbmcgd3JvdGU6DQo+ID4+PiBGcm9tOiBT
dGVmYW5vIFN0YWJlbGxpbmkgPHN0ZWZhbm8uc3RhYmVsbGluaUB4aWxpbnguY29tPg0KPiA+Pj4N
Cj4gPj4+IFdlIGFsd2F5cyB1c2UgYSBmaXggYWRkcmVzcyB0byBtYXAgdGhlIHZQTDAxMSB0byBk
b21haW5zLiBUaGUNCj4gPj4+IGFkZHJlc3MgY291bGQgYmUgYSBwcm9ibGVtIGZvciBkb21haW5z
IHRoYXQgYXJlIGRpcmVjdGx5IG1hcHBlZC4NCj4gPj4+DQo+ID4+PiBTbywgZm9yIGRvbWFpbnMg
dGhhdCBhcmUgZGlyZWN0bHkgbWFwcGVkLCByZXVzZSB0aGUgYWRkcmVzcyBvZiB0aGUNCj4gPj4+
IHBoeXNpY2FsIFVBUlQgb24gdGhlIHBsYXRmb3JtIHRvIGF2b2lkIHBvdGVudGlhbCBjbGFzaGVz
Lg0KPiA+Pj4NCj4gPj4+IERvIHRoZSBzYW1lIGZvciB0aGUgdmlydHVhbCBJUlEgbnVtYmVyOiBp
bnN0ZWFkIG9mIGFsd2F5cyB1c2luZw0KPiA+Pj4gR1VFU1RfVlBMMDExX1NQSSwgdHJ5IHRvIHJl
dXNlIHRoZSBwaHlzaWNhbCBTUEkgbnVtYmVyIGlmIHBvc3NpYmxlLg0KPiA+Pj4NCj4gPj4+IFNp
Z25lZC1vZmYtYnk6IFN0ZWZhbm8gU3RhYmVsbGluaSA8c3RlZmFuby5zdGFiZWxsaW5pQHhpbGlu
eC5jb20+DQo+ID4+PiBTaWduZWQtb2ZmLWJ5OiBQZW5ueSBaaGVuZyA8cGVubnkuemhlbmdAYXJt
LmNvbT4NCj4gPj4+IC0tLQ0KPiA+Pj4gICAgeGVuL2FyY2gvYXJtL2RvbWFpbl9idWlsZC5jICB8
IDM0ICsrKysrKysrKysrKysrKysrKysrKysrKysrKy0tLS0tDQo+IC0tDQo+ID4+PiAgICB4ZW4v
YXJjaC9hcm0vdnBsMDExLmMgICAgICAgIHwgMzQgKysrKysrKysrKysrKysrKysrKysrKysrKysr
LS0tLS0tLQ0KPiA+Pj4gICAgeGVuL2luY2x1ZGUvYXNtLWFybS92cGwwMTEuaCB8ICAyICsrDQo+
ID4+PiAgICAzIGZpbGVzIGNoYW5nZWQsIDU2IGluc2VydGlvbnMoKyksIDE0IGRlbGV0aW9ucygt
KQ0KPiA+Pj4NCj4gPj4+IGRpZmYgLS1naXQgYS94ZW4vYXJjaC9hcm0vZG9tYWluX2J1aWxkLmMN
Cj4gPj4+IGIveGVuL2FyY2gvYXJtL2RvbWFpbl9idWlsZC5jIGluZGV4IDEyMGYxYWU1NzUuLmM5
MmU1MTBhZTcgMTAwNjQ0DQo+ID4+PiAtLS0gYS94ZW4vYXJjaC9hcm0vZG9tYWluX2J1aWxkLmMN
Cj4gPj4+ICsrKyBiL3hlbi9hcmNoL2FybS9kb21haW5fYnVpbGQuYw0KPiA+Pj4gQEAgLTMwLDYg
KzMwLDcgQEANCj4gPj4+DQo+ID4+PiAgICAjaW5jbHVkZSA8eGVuL2lycS5oPg0KPiA+Pj4gICAg
I2luY2x1ZGUgPHhlbi9ncmFudF90YWJsZS5oPg0KPiA+Pj4gKyNpbmNsdWRlIDx4ZW4vc2VyaWFs
Lmg+DQo+ID4+Pg0KPiA+Pj4gICAgc3RhdGljIHVuc2lnbmVkIGludCBfX2luaXRkYXRhIG9wdF9k
b20wX21heF92Y3B1czsNCj4gPj4+ICAgIGludGVnZXJfcGFyYW0oImRvbTBfbWF4X3ZjcHVzIiwg
b3B0X2RvbTBfbWF4X3ZjcHVzKTsgQEAgLQ0KPiAxOTQyLDgNCj4gPj4+ICsxOTQzLDExIEBAIHN0
YXRpYyBpbnQgX19pbml0IG1ha2VfdnBsMDExX3VhcnRfbm9kZShzdHJ1Y3QNCj4gPj4+ICtrZXJu
ZWxfaW5mbw0KPiA+PiAqa2luZm8pDQo+ID4+PiAgICAgICAgZ2ljX2ludGVycnVwdF90IGludHI7
DQo+ID4+PiAgICAgICAgX19iZTMyIHJlZ1tHVUVTVF9ST09UX0FERFJFU1NfQ0VMTFMgKw0KPiBH
VUVTVF9ST09UX1NJWkVfQ0VMTFNdOw0KPiA+Pj4gICAgICAgIF9fYmUzMiAqY2VsbHM7DQo+ID4+
PiArICAgIHN0cnVjdCBkb21haW4gKmQgPSBraW5mby0+ZDsNCj4gPj4+ICsgICAgY2hhciBidWZb
MjddOw0KPiA+Pj4NCj4gPj4+IC0gICAgcmVzID0gZmR0X2JlZ2luX25vZGUoZmR0LCAic2JzYS0N
Cj4gdWFydEAiX19zdHJpbmdpZnkoR1VFU1RfUEwwMTFfQkFTRSkpOw0KPiA+Pj4gKyAgICBzbnBy
aW50ZihidWYsIHNpemVvZihidWYpLCAic2JzYS11YXJ0QCUiUFJJeDY0LCBkLQ0KPiA+Pj4gYXJj
aC52cGwwMTEuYmFzZV9hZGRyKTsNCj4gPj4+ICsgICAgcmVzID0gZmR0X2JlZ2luX25vZGUoZmR0
LCBidWYpOw0KPiA+Pj4gICAgICAgIGlmICggcmVzICkNCj4gPj4+ICAgICAgICAgICAgcmV0dXJu
IHJlczsNCj4gPj4+DQo+ID4+PiBAQCAtMTk1MywxNCArMTk1NywxNCBAQCBzdGF0aWMgaW50IF9f
aW5pdA0KPiA+Pj4gbWFrZV92cGwwMTFfdWFydF9ub2RlKHN0cnVjdCBrZXJuZWxfaW5mbyAqa2lu
Zm8pDQo+ID4+Pg0KPiA+Pj4gICAgICAgIGNlbGxzID0gJnJlZ1swXTsNCj4gPj4+ICAgICAgICBk
dF9jaGlsZF9zZXRfcmFuZ2UoJmNlbGxzLCBHVUVTVF9ST09UX0FERFJFU1NfQ0VMTFMsDQo+ID4+
PiAtICAgICAgICAgICAgICAgICAgICAgICBHVUVTVF9ST09UX1NJWkVfQ0VMTFMsIEdVRVNUX1BM
MDExX0JBU0UsDQo+ID4+PiArICAgICAgICAgICAgICAgICAgICAgICBHVUVTVF9ST09UX1NJWkVf
Q0VMTFMsDQo+ID4+PiArIGQtPmFyY2gudnBsMDExLmJhc2VfYWRkciwNCj4gPj4+ICAgICAgICAg
ICAgICAgICAgICAgICAgICAgR1VFU1RfUEwwMTFfU0laRSk7DQo+ID4+Pg0KPiA+Pj4gICAgICAg
IHJlcyA9IGZkdF9wcm9wZXJ0eShmZHQsICJyZWciLCByZWcsIHNpemVvZihyZWcpKTsNCj4gPj4+
ICAgICAgICBpZiAoIHJlcyApDQo+ID4+PiAgICAgICAgICAgIHJldHVybiByZXM7DQo+ID4+Pg0K
PiA+Pj4gLSAgICBzZXRfaW50ZXJydXB0KGludHIsIEdVRVNUX1ZQTDAxMV9TUEksIDB4ZiwgRFRf
SVJRX1RZUEVfTEVWRUxfSElHSCk7DQo+ID4+PiArICAgIHNldF9pbnRlcnJ1cHQoaW50ciwgZC0+
YXJjaC52cGwwMTEudmlycSwgMHhmLA0KPiA+Pj4gKyBEVF9JUlFfVFlQRV9MRVZFTF9ISUdIKTsN
Cj4gPj4+DQo+ID4+PiAgICAgICAgcmVzID0gZmR0X3Byb3BlcnR5KGZkdCwgImludGVycnVwdHMi
LCBpbnRyLCBzaXplb2YgKGludHIpKTsNCj4gPj4+ICAgICAgICBpZiAoIHJlcyApDQo+ID4+PiBA
QCAtMjY3MCw2ICsyNjc0LDEzIEBAIHN0YXRpYyBpbnQgX19pbml0IGNvbnN0cnVjdF9kb21VKHN0
cnVjdA0KPiA+Pj4gZG9tYWluDQo+ID4+ICpkLA0KPiA+Pj4gICAgICAgIGVsc2UNCj4gPj4+ICAg
ICAgICAgICAgYWxsb2NhdGVfc3RhdGljX21lbW9yeShkLCAma2luZm8sIG5vZGUpOw0KPiA+Pj4N
Cj4gPj4+ICsgICAgLyoNCj4gPj4+ICsgICAgICogSW5pdGlhbGl6YXRpb24gYmVmb3JlIGNyZWF0
aW5nIGl0cyBkZXZpY2UNCj4gPj4+ICsgICAgICogdHJlZSBub2RlIGluIHByZXBhcmVfZHRiX2Rv
bVUuDQo+ID4+PiArICAgICAqLw0KPiA+Pg0KPiA+PiBJIHRoaW5rIGl0IHdvdWxkIGJlIGJldHRl
ciB0byBleHBsYWluICp3aHkqIHRoaXMgbmVlZHMgdG8gYmUgZG9uZSBiZWZvcmUuDQo+ID4+DQo+
ID4+PiArICAgIGlmICgga2luZm8udnBsMDExICkNCj4gPj4+ICsgICAgICAgIHJjID0gZG9tYWlu
X3ZwbDAxMV9pbml0KGQsIE5VTEwpOw0KPiA+Pj4gKw0KPiA+Pj4gICAgICAgIHJjID0gcHJlcGFy
ZV9kdGJfZG9tVShkLCAma2luZm8pOw0KPiA+Pj4gICAgICAgIGlmICggcmMgPCAwICkNCj4gPj4+
ICAgICAgICAgICAgcmV0dXJuIHJjOw0KPiA+Pj4gQEAgLTI2NzgsOSArMjY4OSw2IEBAIHN0YXRp
YyBpbnQgX19pbml0IGNvbnN0cnVjdF9kb21VKHN0cnVjdCBkb21haW4NCj4gPj4gKmQsDQo+ID4+
PiAgICAgICAgaWYgKCByYyA8IDAgKQ0KPiA+Pj4gICAgICAgICAgICByZXR1cm4gcmM7DQo+ID4+
Pg0KPiA+Pj4gLSAgICBpZiAoIGtpbmZvLnZwbDAxMSApDQo+ID4+PiAtICAgICAgICByYyA9IGRv
bWFpbl92cGwwMTFfaW5pdChkLCBOVUxMKTsNCj4gPj4+IC0NCj4gPj4+ICAgICAgICByZXR1cm4g
cmM7DQo+ID4+PiAgICB9DQo+ID4+Pg0KPiA+Pj4gQEAgLTI3MjMsMTUgKzI3MzEsMjcgQEAgdm9p
ZCBfX2luaXQgY3JlYXRlX2RvbVVzKHZvaWQpDQo+ID4+Pg0KPiA+Pj4gICAgICAgICAgICBpZiAo
ICFkdF9wcm9wZXJ0eV9yZWFkX3UzMihub2RlLCAibnJfc3BpcyIsICZkX2NmZy5hcmNoLm5yX3Nw
aXMpICkNCj4gPj4+ICAgICAgICAgICAgew0KPiA+Pj4gKyAgICAgICAgICAgIHVuc2lnbmVkIGlu
dCB2cGwwMTFfdmlycSA9IEdVRVNUX1ZQTDAxMV9TUEk7DQo+ID4+DQo+ID4+IENvZGluZyBzdHls
ZTogQWRkIGEgbmV3bGluZSBoZXJlLg0KPiA+Pg0KPiA+Pj4gICAgICAgICAgICAgICAgZF9jZmcu
YXJjaC5ucl9zcGlzID0gZ2ljX251bWJlcl9saW5lcygpIC0gMzI7DQo+ID4+Pg0KPiA+Pj4gKyAg
ICAgICAgICAgIC8qDQo+ID4+PiArICAgICAgICAgICAgICogVGhlIFZQTDAxMSB2aXJxIGlzIEdV
RVNUX1ZQTDAxMV9TUEksIHVubGVzcyBkaXJlY3QtbWFwIGluDQo+ID4+PiArICAgICAgICAgICAg
ICogc2V0LCBpbiB3aGljaCBjYXNlIHdlJ2xsIHRyeSB0byBtYXRjaCB0aGUgaGFyZHdhcmUuDQo+
ID4+PiArICAgICAgICAgICAgICoNCj4gPj4+ICsgICAgICAgICAgICAgKiBUeXBpY2FsbHksIGQt
PmFyY2gudnBsMDExLnZpcnEgaGFzIHRoZSB2cGwwMTEgaXJxIG51bWJlcg0KPiA+Pj4gKyAgICAg
ICAgICAgICAqIGJ1dCBhdCB0aGlzIHBvaW50IG9mIHRoZSBib290IHNlcXVlbmNlIGl0IGlzIG5v
dA0KPiA+Pj4gKyAgICAgICAgICAgICAqIGluaXRpYWxpemVkIHlldC4NCj4gPj4+ICsgICAgICAg
ICAgICAgKi8NCj4gPj4+ICsgICAgICAgICAgICBpZiAoIGRpcmVjdF9tYXAgJiYgc2VyaWFsX2ly
cShTRVJITkRfRFRVQVJUKSA+IDAgKQ0KPiA+Pj4gKyAgICAgICAgICAgICAgICB2cGwwMTFfdmly
cSA9IHNlcmlhbF9pcnEoU0VSSE5EX0RUVUFSVCk7DQo+ID4+DQo+ID4+IEkgdGhpbmsgd2Ugc2hv
dWxkIG5vdCBjb250aW51ZSBpZiB0aGUgZG9tYWluIGlzIGRpcmVjdC1tYXBwZWQgKmFuZCoNCj4g
Pj4gdGhlIElSUSBpcyBub3QgZm91bmQuIE90aGVyd2lzZSwgdGhpcyB3aWxsIG1heSBqdXN0IHJl
c3VsdCB0bw0KPiA+PiBwb3RlbnRpYWwgYnJlYWthZ2UgaWYgR1VFU1RfVlBMMDExX1NQSSBoYXBw
ZW5zIHRvIGJlIHVzZWQgZm9yIGFuIEhXDQo+IGRldmljZS4NCj4gPj4NCj4gPj4+ICsNCj4gPj4+
ICAgICAgICAgICAgICAgIC8qDQo+ID4+PiAgICAgICAgICAgICAgICAgKiB2cGwwMTEgdXNlcyBv
bmUgZW11bGF0ZWQgU1BJLiBJZiB2cGwwMTEgaXMgcmVxdWVzdGVkLCBtYWtlDQo+ID4+PiAgICAg
ICAgICAgICAgICAgKiBzdXJlIHRoYXQgd2UgYWxsb2NhdGUgZW5vdWdoIFNQSXMgZm9yIGl0Lg0K
PiA+Pj4gICAgICAgICAgICAgICAgICovDQo+ID4+PiAgICAgICAgICAgICAgICBpZiAoIGR0X3By
b3BlcnR5X3JlYWRfYm9vbChub2RlLCAidnBsMDExIikgKQ0KPiA+Pj4gICAgICAgICAgICAgICAg
ICAgIGRfY2ZnLmFyY2gubnJfc3BpcyA9IE1BWChkX2NmZy5hcmNoLm5yX3NwaXMsDQo+ID4+PiAt
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBHVUVTVF9WUEwwMTFfU1BJ
IC0gMzIgKyAxKTsNCj4gPj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgIHZwbDAxMV92aXJxIC0gMzIgKyAxKTsNCj4gPj4+ICAgICAgICAgICAgfQ0KPiA+Pj4NCj4g
Pj4+ICAgICAgICAgICAgLyoNCj4gPj4+IGRpZmYgLS1naXQgYS94ZW4vYXJjaC9hcm0vdnBsMDEx
LmMgYi94ZW4vYXJjaC9hcm0vdnBsMDExLmMgaW5kZXgNCj4gPj4+IDg5NWY0MzZjYzQuLjEwZGYy
NWYwOTggMTAwNjQ0DQo+ID4+PiAtLS0gYS94ZW4vYXJjaC9hcm0vdnBsMDExLmMNCj4gPj4+ICsr
KyBiL3hlbi9hcmNoL2FybS92cGwwMTEuYw0KPiA+Pj4gQEAgLTI5LDYgKzI5LDcgQEANCj4gPj4+
ICAgICNpbmNsdWRlIDx4ZW4vbW0uaD4NCj4gPj4+ICAgICNpbmNsdWRlIDx4ZW4vc2NoZWQuaD4N
Cj4gPj4+ICAgICNpbmNsdWRlIDx4ZW4vY29uc29sZS5oPg0KPiA+Pj4gKyNpbmNsdWRlIDx4ZW4v
c2VyaWFsLmg+DQo+ID4+PiAgICAjaW5jbHVkZSA8cHVibGljL2RvbWN0bC5oPg0KPiA+Pj4gICAg
I2luY2x1ZGUgPHB1YmxpYy9pby9jb25zb2xlLmg+DQo+ID4+PiAgICAjaW5jbHVkZSA8YXNtL3Bs
MDExLXVhcnQuaD4NCj4gPj4+IEBAIC03MSwxMSArNzIsMTEgQEAgc3RhdGljIHZvaWQNCj4gPj4+
IHZwbDAxMV91cGRhdGVfaW50ZXJydXB0X3N0YXR1cyhzdHJ1Y3QNCj4gPj4gZG9tYWluICpkKQ0K
PiA+Pj4gICAgICAgICAqIHN0YXR1cyBiaXQgaGFzIGJlZW4gc2V0IHNpbmNlIHRoZSBsYXN0IHRp
bWUuDQo+ID4+PiAgICAgICAgICovDQo+ID4+PiAgICAgICAgaWYgKCB1YXJ0bWlzICYgfnZwbDAx
MS0+c2hhZG93X3VhcnRtaXMgKQ0KPiA+Pj4gLSAgICAgICAgdmdpY19pbmplY3RfaXJxKGQsIE5V
TEwsIEdVRVNUX1ZQTDAxMV9TUEksIHRydWUpOw0KPiA+Pj4gKyAgICAgICAgdmdpY19pbmplY3Rf
aXJxKGQsIE5VTEwsIHZwbDAxMS0+dmlycSwgdHJ1ZSk7DQo+ID4+Pg0KPiA+Pj4gICAgICAgIHZw
bDAxMS0+c2hhZG93X3VhcnRtaXMgPSB1YXJ0bWlzOw0KPiA+Pj4gICAgI2Vsc2UNCj4gPj4+IC0g
ICAgdmdpY19pbmplY3RfaXJxKGQsIE5VTEwsIEdVRVNUX1ZQTDAxMV9TUEksIHVhcnRtaXMpOw0K
PiA+Pj4gKyAgICB2Z2ljX2luamVjdF9pcnEoZCwgTlVMTCwgdnBsMDExLT52aXJxLCB1YXJ0bWlz
KTsNCj4gPj4+ICAgICNlbmRpZg0KPiA+Pj4gICAgfQ0KPiA+Pj4NCj4gPj4+IEBAIC0zNDcsNyAr
MzQ4LDggQEAgc3RhdGljIGludCB2cGwwMTFfbW1pb19yZWFkKHN0cnVjdCB2Y3B1ICp2LA0KPiA+
Pj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHZvaWQgKnByaXYpDQo+ID4+PiAgICB7
DQo+ID4+PiAgICAgICAgc3RydWN0IGhzcl9kYWJ0IGRhYnQgPSBpbmZvLT5kYWJ0Ow0KPiA+Pj4g
LSAgICB1aW50MzJfdCB2cGwwMTFfcmVnID0gKHVpbnQzMl90KShpbmZvLT5ncGEgLSBHVUVTVF9Q
TDAxMV9CQVNFKTsNCj4gPj4+ICsgICAgdWludDMyX3QgdnBsMDExX3JlZyA9ICh1aW50MzJfdCko
aW5mby0+Z3BhIC0NCj4gPj4+ICsNCj4gPj4+ICsgdi0+ZG9tYWluLT5hcmNoLnZwbDAxMS5iYXNl
X2FkZHIpOw0KPiA+Pj4gICAgICAgIHN0cnVjdCB2cGwwMTEgKnZwbDAxMSA9ICZ2LT5kb21haW4t
PmFyY2gudnBsMDExOw0KPiA+Pj4gICAgICAgIHN0cnVjdCBkb21haW4gKmQgPSB2LT5kb21haW47
DQo+ID4+PiAgICAgICAgdW5zaWduZWQgbG9uZyBmbGFnczsNCj4gPj4+IEBAIC00MzAsNyArNDMy
LDggQEAgc3RhdGljIGludCB2cGwwMTFfbW1pb193cml0ZShzdHJ1Y3QgdmNwdSAqdiwNCj4gPj4+
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdm9pZCAqcHJpdikNCj4gPj4+ICAgIHsN
Cj4gPj4+ICAgICAgICBzdHJ1Y3QgaHNyX2RhYnQgZGFidCA9IGluZm8tPmRhYnQ7DQo+ID4+PiAt
ICAgIHVpbnQzMl90IHZwbDAxMV9yZWcgPSAodWludDMyX3QpKGluZm8tPmdwYSAtIEdVRVNUX1BM
MDExX0JBU0UpOw0KPiA+Pj4gKyAgICB1aW50MzJfdCB2cGwwMTFfcmVnID0gKHVpbnQzMl90KShp
bmZvLT5ncGEgLQ0KPiA+Pj4gKw0KPiA+Pj4gKyB2LT5kb21haW4tPmFyY2gudnBsMDExLmJhc2Vf
YWRkcik7DQo+ID4+PiAgICAgICAgc3RydWN0IHZwbDAxMSAqdnBsMDExID0gJnYtPmRvbWFpbi0+
YXJjaC52cGwwMTE7DQo+ID4+PiAgICAgICAgc3RydWN0IGRvbWFpbiAqZCA9IHYtPmRvbWFpbjsN
Cj4gPj4+ICAgICAgICB1bnNpZ25lZCBsb25nIGZsYWdzOw0KPiA+Pj4gQEAgLTYyMiwxMCArNjI1
LDI3IEBAIGludCBkb21haW5fdnBsMDExX2luaXQoc3RydWN0IGRvbWFpbiAqZCwNCj4gPj4+IHN0
cnVjdA0KPiA+PiB2cGwwMTFfaW5pdF9pbmZvICppbmZvKQ0KPiA+Pj4gICAgew0KPiA+Pj4gICAg
ICAgIGludCByYzsNCj4gPj4+ICAgICAgICBzdHJ1Y3QgdnBsMDExICp2cGwwMTEgPSAmZC0+YXJj
aC52cGwwMTE7DQo+ID4+PiArICAgIGNvbnN0IHN0cnVjdCB2dWFydF9pbmZvICp1YXJ0ID0NCj4g
Pj4+ICsgc2VyaWFsX3Z1YXJ0X2luZm8oU0VSSE5EX0RUVUFSVCk7DQo+ID4+Pg0KPiA+Pj4gICAg
ICAgIGlmICggdnBsMDExLT5iYWNrZW5kLmRvbS5yaW5nX2J1ZiApDQo+ID4+PiAgICAgICAgICAg
IHJldHVybiAtRUlOVkFMOw0KPiA+Pj4NCj4gPj4+ICsgICAgdnBsMDExLT5iYXNlX2FkZHIgPSBH
VUVTVF9QTDAxMV9CQVNFOw0KPiA+Pj4gKyAgICB2cGwwMTEtPnZpcnEgPSBHVUVTVF9WUEwwMTFf
U1BJOw0KPiA+Pj4gKyAgICBpZiAoIGlzX2RvbWFpbl9kaXJlY3RfbWFwcGVkKGQpICkNCj4gPj4+
ICsgICAgew0KPiA+Pj4gKyAgICAgICAgaWYgKCB1YXJ0ICE9IE5VTEwgJiYgc2VyaWFsX2lycShT
RVJITkRfRFRVQVJUKSA+IDAgKQ0KPiA+Pj4gKyAgICAgICAgew0KPiA+Pj4gKyAgICAgICAgICAg
IHZwbDAxMS0+YmFzZV9hZGRyID0gdWFydC0+YmFzZV9hZGRyOw0KPiA+Pj4gKyAgICAgICAgICAg
IHZwbDAxMS0+dmlycSA9IHNlcmlhbF9pcnEoU0VSSE5EX0RUVUFSVCk7DQo+ID4+DQo+ID4+IFRo
aXMgc2VlbXMgYSBiaXQgcG9pbnRsZXNzIHRvIGNhbGwgc2VyaWFsX2lycSgpIHR3aWNlLiBIb3cg
YWJvdXQgYWRkDQo+ID4+IGEgZmllbGQgaW4gdnVhcnRfaW5mbyB0byByZXR1cm4gdGhlIGludGVy
cnVwdCBudW1iZXI/DQo+ID4+DQo+ID4+PiArICAgICAgICB9DQo+ID4+PiArICAgICAgICBlbHNl
DQo+ID4+PiArICAgICAgICAgICAgcHJpbnRrKFhFTkxPR19FUlINCj4gPj4+ICsgICAgICAgICAg
ICAgICAgICAgIlVuYWJsZSB0byByZXVzZSBwaHlzaWNhbCBVQVJUIGFkZHJlc3MgYW5kIGlycSBm
b3IgdlBMMDExLlxuIg0KPiA+Pj4gKyAgICAgICAgICAgICAgICAgICAiRGVmYXVsdGluZyB0byBh
ZGRyICUjIlBSSXBhZGRyIiBhbmQgSVJRICV1XG4iLA0KPiA+Pj4gKyAgICAgICAgICAgICAgICAg
ICB2cGwwMTEtPmJhc2VfYWRkciwgdnBsMDExLT52aXJxKTsNCj4gPj4+ICsgICAgfQ0KPiA+Pj4g
Kw0KPiA+Pj4gICAgICAgIC8qDQo+ID4+PiAgICAgICAgICogaW5mbyBpcyBOVUxMIHdoZW4gdGhl
IGJhY2tlbmQgaXMgaW4gWGVuLg0KPiA+Pj4gICAgICAgICAqIGluZm8gaXMgIT0gTlVMTCB3aGVu
IHRoZSBiYWNrZW5kIGlzIGluIGEgZG9tYWluLg0KPiA+Pj4gQEAgLTY2MSw3ICs2ODEsNyBAQCBp
bnQgZG9tYWluX3ZwbDAxMV9pbml0KHN0cnVjdCBkb21haW4gKmQsIHN0cnVjdA0KPiA+PiB2cGww
MTFfaW5pdF9pbmZvICppbmZvKQ0KPiA+Pj4gICAgICAgICAgICB9DQo+ID4+PiAgICAgICAgfQ0K
PiA+Pj4NCj4gPj4+IC0gICAgcmMgPSB2Z2ljX3Jlc2VydmVfdmlycShkLCBHVUVTVF9WUEwwMTFf
U1BJKTsNCj4gPj4+ICsgICAgcmMgPSB2Z2ljX3Jlc2VydmVfdmlycShkLCB2cGwwMTEtPnZpcnEp
Ow0KPiA+Pj4gICAgICAgIGlmICggIXJjICkNCj4gPj4+ICAgICAgICB7DQo+ID4+PiAgICAgICAg
ICAgIHJjID0gLUVJTlZBTDsNCj4gPj4+IEBAIC02NzMsMTIgKzY5MywxMiBAQCBpbnQgZG9tYWlu
X3ZwbDAxMV9pbml0KHN0cnVjdCBkb21haW4gKmQsDQo+ID4+PiBzdHJ1Y3QNCj4gPj4gdnBsMDEx
X2luaXRfaW5mbyAqaW5mbykNCj4gPj4+ICAgICAgICBzcGluX2xvY2tfaW5pdCgmdnBsMDExLT5s
b2NrKTsNCj4gPj4+DQo+ID4+PiAgICAgICAgcmVnaXN0ZXJfbW1pb19oYW5kbGVyKGQsICZ2cGww
MTFfbW1pb19oYW5kbGVyLA0KPiA+Pj4gLSAgICAgICAgICAgICAgICAgICAgICAgICAgR1VFU1Rf
UEwwMTFfQkFTRSwgR1VFU1RfUEwwMTFfU0laRSwgTlVMTCk7DQo+ID4+PiArICAgICAgICAgICAg
ICAgICAgICAgICAgICB2cGwwMTEtPmJhc2VfYWRkciwgR1VFU1RfUEwwMTFfU0laRSwNCj4gPj4+
ICsgTlVMTCk7DQo+ID4+DQo+ID4+IFNvIHlvdSBhcmUgbWFraW5nIHRoZSBhc3N1bXBwdGlvbiB0
aGF0IHRoZSBVQVJUIHJlZ2lvbiB3aWxsIGJlIGVxdWFsDQo+ID4+IHRvIChvcg0KPiA+PiBiaWdn
ZXIpIHRoYW4gR1VFU1RfUEwwMTFfU0laRS4gVGhlcmUgYXJlIGRlZmluaXRlbHkgVUFSVCBvdXQg
d2hlcmUNCj4gPj4gdGhlIE1NSU8gcmVnaW9uIGlzIHNtYWxsZXIgdGhhbiA0Sy4NCj4gPj4NCj4g
Pg0KPiA+IFNvcnJ5LiBJIGdvdCBhIGZldyBjb25mdXNlZCBoZXJlLCBzaW5jZSBJIGFtIG5vdCB2
ZXJ5IGZhbWlsaWFyIHdpdGggcGwwMTEvVUFSVA0KPiBrbm93bGVkZ2UuDQo+ID4NCj4gPiBQcm9i
bGVtcyB3aWxsIG9jY3VyIHdoZW4gVUFSVCByZWdpb24gaXMgYmlnZ2VyIHRoYW4gR1VFU1RfUEww
MTFfU0laRSwNCj4gPiBzaW5jZSB3ZSBhcmUgb25seSBjb25zaWRlcmluZyBNTUlPIHJlZ2lvbiBv
ZiBbdnBsMDExLT5iYXNlX2FkZHIsIHZwbDAxMS0NCj4gPmJhc2VfYWRkciArIEdVRVNUX1BMMDEx
X1NJWkVdLCByaWdodD8NCj4gDQo+IEl0IGlzIGluIGZhY3QgdGhlIG90aGVyIHdheSBhcm91bmQu
IFRoZSBwcm9ibGVtIHdpbGwgYXBwZWFyIGlmIHRoZSBob3N0IFVBUlQNCj4gTU1JTyByZWdpb24g
aXMgc21hbGxlciB0aGFuIHRoZSBvbmUgd2Ugd2lsbCBlbXVsYXRlIGZvciB0aGUgZ3Vlc3QgUEww
MTEuDQo+IA0KDQpTb3JyeSB0byBrZWVwIGJvdGhlcmluZy4NCklzIGl0IHRoYXQgYmVjYXVzZSB3
aGVuIHRoZSBVQVJUIE1NSU8gcmVnaW9uIGlzIHNtYWxsZXIgdGhhbiB0aGUgb25lIHdlIGVtdWxh
dGVkLA0KcmVnaXN0ZXIoRFIsIFJTUiwgRlIsIC4uLikgd2lsbCBub3QgYmUgYXQgdGhlIHBsYWNl
IHdoZXJlIHdlIGVtdWxhdGVkPw0KICANCj4gPg0KPiA+IFNvIEkgc2hhbGwgYWRkIHRoZSBqdXN0
aWZpY2F0aW9uIGxpa2UNCj4gPiBBU1NFUlQodWFydC0+c2l6ZSA8PSBHVUVTVF9QTDAxMV9TSVpF
KTsNCj4gDQo+IEkgdGhpbmsgdGhpcyB3b3VsZCB3YW50IHRvIGJlIGEgcHJvcGVyIGNoZWNrIHNv
IGRpc3RybyB1c2VycyB3b3VsZCBnZXQgYW4gZXJyb3INCj4gaWYgdGhleSBhcmUgdHJ5aW5nIHRv
IHVzZSB0aGlzIGZlYXR1cmUgb24gc3VjaCBwbGF0Zm9ybS4NCj4gDQoNClN1cmUsIEnigJlsbCBh
ZGQgdGhlIGxlbmd0aCBjaGVjay4NCg0KPiBDaGVlcnMsDQo+IA0KPiAtLQ0KPiBKdWxpZW4gR3Jh
bGwNCg==


From xen-devel-bounces@lists.xenproject.org Tue Oct 12 03:40:14 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 03:40:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.206697.362329 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ma8dw-0006A5-Ss; Tue, 12 Oct 2021 03:39:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 206697.362329; Tue, 12 Oct 2021 03:39:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ma8dw-00069y-P9; Tue, 12 Oct 2021 03:39:56 +0000
Received: by outflank-mailman (input) for mailman id 206697;
 Tue, 12 Oct 2021 03:39:55 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=amut=PA=intel.com=kevin.tian@srs-us1.protection.inumbo.net>)
 id 1ma8dv-00069V-4E
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 03:39:55 +0000
Received: from mga07.intel.com (unknown [134.134.136.100])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 0e8dcea0-2b0e-11ec-8104-12813bfff9fa;
 Tue, 12 Oct 2021 03:39:52 +0000 (UTC)
Received: from fmsmga001.fm.intel.com ([10.253.24.23])
 by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 11 Oct 2021 20:39:50 -0700
Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85])
 by fmsmga001.fm.intel.com with ESMTP; 11 Oct 2021 20:39:50 -0700
Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by
 fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2242.12; Mon, 11 Oct 2021 20:39:49 -0700
Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by
 fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2242.12 via Frontend Transport; Mon, 11 Oct 2021 20:39:49 -0700
Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.57.48) by
 edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.1.2242.12; Mon, 11 Oct 2021 20:39:49 -0700
Received: from BN9PR11MB5433.namprd11.prod.outlook.com (2603:10b6:408:11e::13)
 by BN7PR11MB2850.namprd11.prod.outlook.com (2603:10b6:406:b3::31)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.19; Tue, 12 Oct
 2021 03:39:48 +0000
Received: from BN9PR11MB5433.namprd11.prod.outlook.com
 ([fe80::ddb7:fa7f:2cc:45df]) by BN9PR11MB5433.namprd11.prod.outlook.com
 ([fe80::ddb7:fa7f:2cc:45df%9]) with mapi id 15.20.4587.026; Tue, 12 Oct 2021
 03:39:48 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0e8dcea0-2b0e-11ec-8104-12813bfff9fa
X-IronPort-AV: E=McAfee;i="6200,9189,10134"; a="290524237"
X-IronPort-AV: E=Sophos;i="5.85,366,1624345200"; 
   d="scan'208";a="290524237"
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.85,366,1624345200"; 
   d="scan'208";a="625755457"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=aMcr9J2X4rcuo584n3CcPpspZwfUbBWAtu3ml2qxmy9PvDMAZtU/u5HU8OfrrdTw8mF61h+/TdqonGZQvCDzLmjgDw1WMLU5zAaZwfYAbB16K2IrncAdPIbWmbPogr7Uhl2GZTqY9IcU+jpy7R+AJoZkU0h8BZGn7jvYI/doN3I5FjsxpFR5bRySLya1oqSQhE8T1cGaAxdOAzhoZgURZ4GEXlQvoE5nojxYEiXO4u5t18zGvg7bwXWsiJQwW36jcuyynCoXKnOj+1ZJcCjzbSaFKLOLr+38CAASu1uLHoKZ62zNwZEkSwNwIlJ8MiiXNdTNezShPR63gJn0W1PysQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=mZx4LVInx3jJVd+Jk20AQWUe2yMLxTUrm5mn3U441II=;
 b=eZ0aqIFmFlpsnFMViusEc9AIY8bQAqEqqqtYFE7Rya+839SgBeU2zfRpuN7Lmlis/Eg9YCFOVKhlBBfoMPodhpqHwMDhcxObSqQV4+TldaPicG6BJWU/ulZBv6ils9vlCMRNbsu8bq2MDX5zEc7aqLq4uSxOAHEf4MgikRTgnIBshfOTxVDbwSMUSVjN3KPPKIXQsZebD9rqDmCMZ4tIuOUA/2Z95PA06nvwV1kYz2EmppeBTrYQxcFkhsH3FEaPiGUBaT/ARMh5sB+/CoTcbkT1Tj3njVyCq8mhKZn9Y1lYRakiVlpuhiAiycj2fI3hzREWD+IFiPIV+DQYyW9dCg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;
 dkim=pass header.d=intel.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com;
 s=selector2-intel-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=mZx4LVInx3jJVd+Jk20AQWUe2yMLxTUrm5mn3U441II=;
 b=P1DbP3HS3R808N1OT4UB1DfH7aakCsYMweujIZ3/rm2TSG3fw3M1gOithQupmOBEpdfdPnQLYb1TP3YJuAQGX9j7wcorR9SuO5ELKZ9nIRGR+vi0h0ecsvMhl7oRy9hn96xPx4ZCGBXdGXtx2rOxZlKF/mOPhndMAUERnfHrN+w=
From: "Tian, Kevin" <kevin.tian@intel.com>
To: Jan Beulich <jbeulich@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Ian Jackson <iwj@xenproject.org>
Subject: RE: [PATCH 1/2] VT-d: generalize and correct "iommu=no-igfx" handling
Thread-Topic: [PATCH 1/2] VT-d: generalize and correct "iommu=no-igfx"
 handling
Thread-Index: AQHXvnzo4Ip5MEhSkEq0GJRaR1PfzavOuIvg
Date: Tue, 12 Oct 2021 03:39:48 +0000
Message-ID: <BN9PR11MB54335BDA95CE264683DF79878CB69@BN9PR11MB5433.namprd11.prod.outlook.com>
References: <ced41449-6aa2-3b20-77cd-78dafcad4bc7@suse.com>
 <388b8562-e76f-e07c-a13d-f325bbc731c9@suse.com>
In-Reply-To: <388b8562-e76f-e07c-a13d-f325bbc731c9@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: suse.com; dkim=none (message not signed)
 header.d=none;suse.com; dmarc=none action=none header.from=intel.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: cfe3ecfc-8765-4704-5592-08d98d31f0e3
x-ms-traffictypediagnostic: BN7PR11MB2850:
x-microsoft-antispam-prvs: <BN7PR11MB285027C976CFF001D256C3F28CB69@BN7PR11MB2850.namprd11.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:9508;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: EwbuNebp4JvUJj08rRuiGm7YU+s+wIchNVrJIpOlbPlSHG86ktNLwHgRfxm9XNIH0FZ95Okj/4NgipJRfCzEUyd+UkUXXIk9YhVe/yofCQhRa6ut9gXIFdsZsOhMi4k57KPJKc8o41LASYWrmgZ1kHXlSwcw+ovpwfryryBVsRvsQNuGRVNEwj4eiaKFSdfSd6d66HBJ/LAC2q6hFJdC7z0tlGWVeVd9OACU8b1uV4t/usodkovXi1cUbVwtYs/bGIkj+YcK6qfidHtkVy0TYGv+gLSqIeaejTkZbqAJ/hExfVyCnMmcTUkrEZJ1W0nPgLt3h/O4tkp6hZ5Ca8ZJ8YXuiUcDgfkyE6bkpyPAUFBmtS0ceYO7U6y2yPzk2Wt+82Y+FrRbGs65xo1wCKihZBckJj7m3+V4dQL3Qj3NGCQBSfoUdThsTGx4UFMMRhJWlUUkqZzoGLTC3SToTjjM0H5vCYMVaFsWkLKAom/k9+sw4lWD4YkTctM1zDj3/WF/CFRh7y+xRbm+2lalIiXjN09ZRXCVof2HVVbY7RvEM6rp0veaYpKhtuYrHoHg5xyKpXhGT+R2TZpwKH4Rj9DjZKC1ZnS0hCqHsGyIakwH5mUkhVZfmyQ6ofCaB/Ya1kGrbnqyAWCmj7FKWybmDpDiTKZszFTbQeCKVz0UBXLzKTj1Mf00HPkWmqR30iHYFddzuICw9lsgPC3qmy0utyFHOQ==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR11MB5433.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(55016002)(38100700002)(508600001)(9686003)(86362001)(316002)(5660300002)(33656002)(110136005)(7696005)(6506007)(38070700005)(26005)(4326008)(52536014)(122000001)(8676002)(64756008)(66446008)(66946007)(66556008)(66476007)(83380400001)(8936002)(71200400001)(76116006)(2906002)(186003);DIR:OUT;SFP:1102;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?a0lMOC9SRVdZelJJQitrMzllTDBKVjJMYUc3UUpVUThJTEY3Vko1c0dLdG9T?=
 =?utf-8?B?WEpDY3BHblRKZjg1aUFjUG02U0xlRlZsKzlmRlNFcnkvOXVVakNwU2hPWlRU?=
 =?utf-8?B?ZGNzTGlUdXA3V2Zob3FWRVJBWk1wUUZRT3hZam9vczNSbmFwS1N2bGNuM1Zw?=
 =?utf-8?B?ajM0ekdkS3RlU1NtaWpId3RvQ1hncWhnN2N1cjhhMmpWc1hQNWZKVDNqa25F?=
 =?utf-8?B?dSsyK2hkaEYwa0FJeVJ3RDAyWTJVU2FBN2xlcGNmd1RTV1Q2ckZKK1ZqSjQv?=
 =?utf-8?B?MWV5SVF0NUY0NUdsM01BV1ZZbkl1MTl6K1loSkNZZEFHbm1wZ3ZkQWlibW4r?=
 =?utf-8?B?ZjJRR2hLWmoyVnA1aXZMcFhlNklvRlYrM3BNd1NlbkFGSVlRcU05SzAxZjVi?=
 =?utf-8?B?anQ1UjhKTktLM28zdUgxMUFyM0tDelgzb05YcFo5S0ZFTWhsM0V3cExSNFEv?=
 =?utf-8?B?dVByZ256Sk9IUithT1Z6V0hqOU9tbU9CeE5JVGU1Z1JEVHBNK3FMK2w2VFg1?=
 =?utf-8?B?VjhoK1JHMnFDMWNJREVwV3Y2NERxZVpDdEkwRldIWDZyR1hick9jSjZJMWVo?=
 =?utf-8?B?WklQRlpSa2QzZXd3d3FLbHI0TTB1U1ZvV1FYUHNPM1NtVjZ3NTd0alBoUXFC?=
 =?utf-8?B?b2RmZ04wQ2lVMmhUVUZzcHNQeExBekFMS2hqNmk0Z3dxeDBML1hiSmVyZGdw?=
 =?utf-8?B?dElRMFJ5NzRxS1VaQlNQUjd2eVBFM25Qa3dUQ0w2TnZ6MjU1RzBzNmp4bjFI?=
 =?utf-8?B?Nit0UnI3TEYybmhUK282RTdTS3FUTjZudEFLV1Zla2ozM2hsdUJtRXFGaVY3?=
 =?utf-8?B?NUVldHpEeE9rbi93aTN3bTg2UitMVnJJUjBiVVA2Z1RRWjFHY0FPd29pTTZS?=
 =?utf-8?B?NFVsbE9xVTQ3SmNXTEJ6SGR5OXl2cXoycFRjdjQ4bzgzeWp1TUNpSmZEUW1Y?=
 =?utf-8?B?Q1YvQzdOVyt5L2h6ekp4TkdFeElYaHU0NlFMTGd1VGcxSzlwQ0orWTk5Zldh?=
 =?utf-8?B?U3FidFZwYVo5azFEc1VBdEQ5RWw3dG1ZbWpFYlYrellTQmF6TlE1TmN1NlMw?=
 =?utf-8?B?cEVFWFB0TmRrWkorNlFaN2NJRndXa1FQMU5FVHBaNTJ1bkROZFFXYVVJNEVP?=
 =?utf-8?B?dkE4T3ZZNUt0RmxSTk05SFJ6UDN0TUlDaFV5dGV4SGxRODgyWEROUjdvNU9r?=
 =?utf-8?B?R0NlMTJpa25Uckd3VFMva2hpQ3JzVElvYXpHN21YY2JpUjIrTVNqaEI5OHRQ?=
 =?utf-8?B?aStoN1k3OVBOU2VkUFVqakxHdW1yekdwRkZFYkhvV2xZajdCM2xPUVJvZ2xw?=
 =?utf-8?B?VXEybUoyOFo2Si8vRjFKOHF5Uy82Q0pRQmJiRXRPRWVJZ2tHT0dHaWdhMUt6?=
 =?utf-8?B?ODh5alNiOXo4aENzdVg1WWJmQWVvd0drMyttY0VHSllZazgyRjE5UktaakM3?=
 =?utf-8?B?WkQyRHRSVmFjTENxR1MvVzJMeHJpLzFvTG5NNFcweDAwK0RqTnNvYm5RSXNk?=
 =?utf-8?B?WU42VWNuc1oxRGpXNm9JTzNZK011NGQ3THZUQUdyTkh1TFNOZHV4emxDMHNa?=
 =?utf-8?B?OFZQT2FvZS9EVWlXZGdiQlBBN0VXUkM3MFIyY3ZqKzN4RG9TUkJpTldEZnZX?=
 =?utf-8?B?OElCMzY1YzJNaG1GN21zK0ZVZWllWll6UVVLRWJqelFyUUw0KzFxbkJXb1J4?=
 =?utf-8?B?c0RTWFVESUFvNmkvTCtoZi9vWVhxN1lPaFJhOVlIMWRGVEdxejhHU2twNDlJ?=
 =?utf-8?Q?NcKjDwHVPsCyQ5k96Dm2Lt6a7DxrAg7DR30bTx5?=
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5433.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cfe3ecfc-8765-4704-5592-08d98d31f0e3
X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Oct 2021 03:39:48.3442
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: bIauc4QsAqE4ox9GKFV4j1Tte/c5KVv4XSoZ2kpAgV8cmGofXq+JgAF1R/zpLf+Hsr2Mja2hLJGqzSMzI9qc8w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR11MB2850
X-OriginatorOrg: intel.com

PiBGcm9tOiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+DQo+IFNlbnQ6IE1vbmRheSwg
T2N0b2JlciAxMSwgMjAyMSA0OjQ5IFBNDQo+IA0KPiBMaW51eCdlcyBzdXBwb3NlZGx5IGVxdWl2
YWxlbnQgImludGVsX2lvbW11PWlnZnhfb2ZmIiBkZWFscyB3aXRoIGFueQ0KPiBncmFwaGljcyBk
ZXZpY2VzIChub3QganVzdCBJbnRlbCBvbmVzKSB3aGlsZSBhdCB0aGUgc2FtZSB0aW1lIGxpbWl0
aW5nDQo+IHRoZSBlZmZlY3QgdG8gSU9NTVVzIGNvdmVyaW5nIG9ubHkgZ3JhcGhpY3MgZGV2aWNl
cy4gS2V5aW5nIHRoZSBkZWNpc2lvbg0KPiB0byBsZWF2ZSB0cmFuc2xhdGlvbiBkaXNhYmxlZCBm
b3IgYW4gSU9NTVUgdG8gbWVyZWx5IGEgbWFnaWMgU0JERiB0dXBsZQ0KPiB3YXMgd3JvbmcgaW4g
dGhlIGZpcnN0IHBsYWNlIC0gc3lzdGVtcyBtYXkgdmVyeSB3ZWxsIGhhdmUgbm9uLWdyYXBoaWNz
DQo+IGRldmljZXMgYXQgMDAwMDowMDowMi4wIChvcmRpbmFyeSByb290IHBvcnRzIGNvbW1vbmx5
IGxpdmUgdGhlcmUsIGZvcg0KPiBleGFtcGxlKS4gQW55IHVzZSBvZiBpZ2RfZHJoZF9hZGRyZXNz
IChhbmQgaGVuY2UgaXNfaWdkX2RyaGQoKSkgbmVlZHMNCj4gZnVydGhlciBxdWFsaWZpY2F0aW9u
Lg0KPiANCj4gSW50cm9kdWNlIGEgbmV3ICJncmFwaGljcyBvbmx5IiBmaWVsZCBpbiBzdHJ1Y3Qg
YWNwaV9kcmhkX3VuaXQgYW5kIHNldA0KPiBpdCBhY2NvcmRpbmcgdG8gZGV2aWNlIHNjb3BlIHBh
cnNpbmcgb3V0Y29tZS4gUmVwbGFjZSB0aGUgYmFkIHVzZSBvZg0KPiBpc19pZ2RfZHJoZCgpIGlu
IGlvbW11X2VuYWJsZV90cmFuc2xhdGlvbigpIGJ5IHVzZSBvZiB0aGlzIG5ldyBmaWVsZC4NCj4g
DQo+IFdoaWxlIGFkZGluZyB0aGUgbmV3IGZpZWxkIGFsc28gY29udmVydCB0aGUgYWRqYWNlbnQg
aW5jbHVkZV9hbGwgb25lIHRvDQo+ICJib29sIi4NCj4gDQo+IFNpZ25lZC1vZmYtYnk6IEphbiBC
ZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCg0KUmV2aWV3ZWQtYnk6IEtldmluIFRpYW4gPGtl
dmluLnRpYW5AaW50ZWwuY29tPg0KDQo+IC0tLQ0KPiBJIGFzc3VtZSBhbiBpbXBsaWNhdGlvbiBp
cyB0aGF0IHRoZXNlIGRldmljZXMgdGhlbiBtYXkgbm90IGJlIHBhc3NlZA0KPiB0aHJvdWdoIHRv
IGd1ZXN0cywgeWV0IEkgZG9uJ3Qgc2VlIHVzIGVuZm9yY2luZyB0aGlzIGFueXdoZXJlLg0KPiAN
Cj4gLS0tIGEvZG9jcy9taXNjL3hlbi1jb21tYW5kLWxpbmUucGFuZG9jDQo+ICsrKyBiL2RvY3Mv
bWlzYy94ZW4tY29tbWFuZC1saW5lLnBhbmRvYw0KPiBAQCAtMTQ5NCw4ICsxNDk0LDggQEAgVGhl
IGZvbGxvd2luZyBvcHRpb25zIGFyZSBzcGVjaWZpYyB0byBJbg0KPiAgICAgIHZlcnNpb24gNiBh
bmQgZ3JlYXRlciBhcyBSZWdpc3RlcmVkLUJhc2VkIEludmFsaWRhdGlvbiBpc24ndCBzdXBwb3J0
ZWQNCj4gICAgICBieSB0aGVtLg0KPiANCj4gLSogICBUaGUgYGlnZnhgIGJvb2xlYW4gaXMgYWN0
aXZlIGJ5IGRlZmF1bHQsIGFuZCBjb250cm9scyB3aGV0aGVyIHRoZSBJT01NVQ0KPiBpbg0KPiAt
ICAgIGZyb250IG9mIGFuIEludGVsIEdyYXBoaWNzIERldmljZSBpcyBlbmFibGVkIG9yIG5vdC4N
Cj4gKyogICBUaGUgYGlnZnhgIGJvb2xlYW4gaXMgYWN0aXZlIGJ5IGRlZmF1bHQsIGFuZCBjb250
cm9scyB3aGV0aGVyIElPTU1VcyBpbg0KPiArICAgIGZyb250IG9mIHNvbGVseSBncmFwaGljcyBk
ZXZpY2VzIGdldCBlbmFibGVkIG9yIG5vdC4NCj4gDQo+ICAgICAgSXQgaXMgaW50ZW5kZWQgYXMg
YSBkZWJ1Z2dpbmcgbWVjaGFuaXNtIGZvciBncmFwaGljcyBpc3N1ZXMsIGFuZCB0byBiZQ0KPiAg
ICAgIHNpbWlsYXIgdG8gTGludXgncyBgaW50ZWxfaW9tbXU9aWdmeF9vZmZgIG9wdGlvbi4gIElm
IHNwZWNpZnlpbmcgYG5vLWlnZnhgDQo+IC0tLSBhL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL3Z0
ZC9kbWFyLmMNCj4gKysrIGIveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvdnRkL2RtYXIuYw0KPiBA
QCAtMzE1LDYgKzMxNSw3IEBAIHN0YXRpYyBpbnQgX19pbml0IGFjcGlfcGFyc2VfZGV2X3Njb3Bl
KA0KPiAgICAgIHN0cnVjdCBhY3BpX2RyaGRfdW5pdCAqZHJoZCA9IHR5cGUgPT0gRE1BUl9UWVBF
ID8NCj4gICAgICAgICAgY29udGFpbmVyX29mKHNjb3BlLCBzdHJ1Y3QgYWNwaV9kcmhkX3VuaXQs
IHNjb3BlKSA6IE5VTEw7DQo+ICAgICAgaW50IGRlcHRoLCBjbnQsIGRpZHggPSAwLCByZXQ7DQo+
ICsgICAgYm9vbCBnZnhfb25seSA9IGZhbHNlOw0KPiANCj4gICAgICBpZiAoIChjbnQgPSBzY29w
ZV9kZXZpY2VfY291bnQoc3RhcnQsIGVuZCkpIDwgMCApDQo+ICAgICAgICAgIHJldHVybiBjbnQ7
DQo+IEBAIC0zMjQsNiArMzI1LDggQEAgc3RhdGljIGludCBfX2luaXQgYWNwaV9wYXJzZV9kZXZf
c2NvcGUoDQo+ICAgICAgICAgIHNjb3BlLT5kZXZpY2VzID0geHphbGxvY19hcnJheSh1MTYsIGNu
dCk7DQo+ICAgICAgICAgIGlmICggIXNjb3BlLT5kZXZpY2VzICkNCj4gICAgICAgICAgICAgIHJl
dHVybiAtRU5PTUVNOw0KPiArDQo+ICsgICAgICAgIGdmeF9vbmx5ID0gZHJoZCAmJiAhZHJoZC0+
aW5jbHVkZV9hbGw7DQo+ICAgICAgfQ0KPiAgICAgIHNjb3BlLT5kZXZpY2VzX2NudCA9IGNudDsN
Cj4gDQo+IEBAIC0zNTQsNiArMzU3LDcgQEAgc3RhdGljIGludCBfX2luaXQgYWNwaV9wYXJzZV9k
ZXZfc2NvcGUoDQo+ICAgICAgICAgICAgICAgICAgICAgICAgIGFjcGlfc2NvcGUtPmJ1cywgc2Vj
X2J1cywgc3ViX2J1cyk7DQo+IA0KPiAgICAgICAgICAgICAgZG1hcl9zY29wZV9hZGRfYnVzZXMo
c2NvcGUsIHNlY19idXMsIHN1Yl9idXMpOw0KPiArICAgICAgICAgICAgZ2Z4X29ubHkgPSBmYWxz
ZTsNCj4gICAgICAgICAgICAgIGJyZWFrOw0KPiANCj4gICAgICAgICAgY2FzZSBBQ1BJX0RNQVJf
U0NPUEVfVFlQRV9IUEVUOg0KPiBAQCAtMzc0LDYgKzM3OCw4IEBAIHN0YXRpYyBpbnQgX19pbml0
IGFjcGlfcGFyc2VfZGV2X3Njb3BlKA0KPiAgICAgICAgICAgICAgICAgIGFjcGlfaHBldF91bml0
LT5kZXYgPSBwYXRoLT5kZXY7DQo+ICAgICAgICAgICAgICAgICAgYWNwaV9ocGV0X3VuaXQtPmZ1
bmMgPSBwYXRoLT5mbjsNCj4gICAgICAgICAgICAgICAgICBsaXN0X2FkZCgmYWNwaV9ocGV0X3Vu
aXQtPmxpc3QsICZkcmhkLT5ocGV0X2xpc3QpOw0KPiArDQo+ICsgICAgICAgICAgICAgICAgZ2Z4
X29ubHkgPSBmYWxzZTsNCj4gICAgICAgICAgICAgIH0NCj4gDQo+ICAgICAgICAgICAgICBicmVh
azsNCj4gQEAgLTM4OCw2ICszOTQsMTIgQEAgc3RhdGljIGludCBfX2luaXQgYWNwaV9wYXJzZV9k
ZXZfc2NvcGUoDQo+ICAgICAgICAgICAgICAgICAgaWYgKCAoc2VnID09IDApICYmIChidXMgPT0g
MCkgJiYgKHBhdGgtPmRldiA9PSAyKSAmJg0KPiAgICAgICAgICAgICAgICAgICAgICAgKHBhdGgt
PmZuID09IDApICkNCj4gICAgICAgICAgICAgICAgICAgICAgaWdkX2RyaGRfYWRkcmVzcyA9IGRy
aGQtPmFkZHJlc3M7DQo+ICsNCj4gKyAgICAgICAgICAgICAgICBpZiAoIGdmeF9vbmx5ICYmDQo+
ICsgICAgICAgICAgICAgICAgICAgICBwY2lfY29uZl9yZWFkOChQQ0lfU0JERihzZWcsIGJ1cywg
cGF0aC0+ZGV2LCBwYXRoLT5mbiksDQo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICBQQ0lfQ0xBU1NfREVWSUNFICsgMSkgIT0gMHgwMw0KPiArICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgLyogUENJX0JBU0VfQ0xBU1NfRElTUExBWSAqLyApDQo+ICsgICAg
ICAgICAgICAgICAgICAgIGdmeF9vbmx5ID0gZmFsc2U7DQo+ICAgICAgICAgICAgICB9DQo+IA0K
PiAgICAgICAgICAgICAgYnJlYWs7DQo+IEBAIC00MDgsNiArNDIwLDggQEAgc3RhdGljIGludCBf
X2luaXQgYWNwaV9wYXJzZV9kZXZfc2NvcGUoDQo+ICAgICAgICAgICAgICAgICAgYWNwaV9pb2Fw
aWNfdW5pdC0+aW9hcGljLmJkZi5kZXYgPSBwYXRoLT5kZXY7DQo+ICAgICAgICAgICAgICAgICAg
YWNwaV9pb2FwaWNfdW5pdC0+aW9hcGljLmJkZi5mdW5jID0gcGF0aC0+Zm47DQo+ICAgICAgICAg
ICAgICAgICAgbGlzdF9hZGQoJmFjcGlfaW9hcGljX3VuaXQtPmxpc3QsICZkcmhkLT5pb2FwaWNf
bGlzdCk7DQo+ICsNCj4gKyAgICAgICAgICAgICAgICBnZnhfb25seSA9IGZhbHNlOw0KPiAgICAg
ICAgICAgICAgfQ0KPiANCj4gICAgICAgICAgICAgIGJyZWFrOw0KPiBAQCAtNDE3LDExICs0MzEs
MTUgQEAgc3RhdGljIGludCBfX2luaXQgYWNwaV9wYXJzZV9kZXZfc2NvcGUoDQo+ICAgICAgICAg
ICAgICAgICAgcHJpbnRrKFhFTkxPR19XQVJOSU5HIFZURFBSRUZJWCAiVW5rbm93biBzY29wZSB0
eXBlICUjeFxuIiwNCj4gICAgICAgICAgICAgICAgICAgICAgICAgYWNwaV9zY29wZS0+ZW50cnlf
dHlwZSk7DQo+ICAgICAgICAgICAgICBzdGFydCArPSBhY3BpX3Njb3BlLT5sZW5ndGg7DQo+ICsg
ICAgICAgICAgICBnZnhfb25seSA9IGZhbHNlOw0KPiAgICAgICAgICAgICAgY29udGludWU7DQo+
ICAgICAgICAgIH0NCj4gICAgICAgICAgc2NvcGUtPmRldmljZXNbZGlkeCsrXSA9IFBDSV9CREYo
YnVzLCBwYXRoLT5kZXYsIHBhdGgtPmZuKTsNCj4gICAgICAgICAgc3RhcnQgKz0gYWNwaV9zY29w
ZS0+bGVuZ3RoOw0KPiAtICAgfQ0KPiArICAgIH0NCj4gKw0KPiArICAgIGlmICggZHJoZCAmJiBn
Znhfb25seSApDQo+ICsgICAgICAgIGRyaGQtPmdmeF9vbmx5ID0gdHJ1ZTsNCj4gDQo+ICAgICAg
cmV0ID0gMDsNCj4gDQo+IC0tLSBhL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL3Z0ZC9kbWFyLmgN
Cj4gKysrIGIveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvdnRkL2RtYXIuaA0KPiBAQCAtNjIsNyAr
NjIsOCBAQCBzdHJ1Y3QgYWNwaV9kcmhkX3VuaXQgew0KPiAgICAgIHN0cnVjdCBsaXN0X2hlYWQg
bGlzdDsNCj4gICAgICB1NjQgICAgYWRkcmVzczsgICAgICAgICAgICAgICAgICAgICAvKiByZWdp
c3RlciBiYXNlIGFkZHJlc3Mgb2YgdGhlIHVuaXQgKi8NCj4gICAgICB1MTYgICAgc2VnbWVudDsN
Cj4gLSAgICB1OCAgICAgaW5jbHVkZV9hbGw6MTsNCj4gKyAgICBib29sICAgaW5jbHVkZV9hbGw6
MTsNCj4gKyAgICBib29sICAgZ2Z4X29ubHk6MTsNCj4gICAgICBzdHJ1Y3QgdnRkX2lvbW11ICpp
b21tdTsNCj4gICAgICBzdHJ1Y3QgbGlzdF9oZWFkIGlvYXBpY19saXN0Ow0KPiAgICAgIHN0cnVj
dCBsaXN0X2hlYWQgaHBldF9saXN0Ow0KPiAtLS0gYS94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC92
dGQvaW9tbXUuYw0KPiArKysgYi94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC92dGQvaW9tbXUuYw0K
PiBAQCAtNzUxLDcgKzc1MSw3IEBAIHN0YXRpYyB2b2lkIGlvbW11X2VuYWJsZV90cmFuc2xhdGlv
bihzdHINCj4gICAgICB1bnNpZ25lZCBsb25nIGZsYWdzOw0KPiAgICAgIHN0cnVjdCB2dGRfaW9t
bXUgKmlvbW11ID0gZHJoZC0+aW9tbXU7DQo+IA0KPiAtICAgIGlmICggaXNfaWdkX2RyaGQoZHJo
ZCkgKQ0KPiArICAgIGlmICggZHJoZC0+Z2Z4X29ubHkgKQ0KPiAgICAgIHsNCj4gICAgICAgICAg
aWYgKCAhaW9tbXVfaWdmeCApDQo+ICAgICAgICAgIHsNCg0K


From xen-devel-bounces@lists.xenproject.org Tue Oct 12 04:26:58 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 04:26:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.206708.362340 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ma9NL-0002ei-Et; Tue, 12 Oct 2021 04:26:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 206708.362340; Tue, 12 Oct 2021 04:26:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ma9NL-0002eb-AQ; Tue, 12 Oct 2021 04:26:51 +0000
Received: by outflank-mailman (input) for mailman id 206708;
 Tue, 12 Oct 2021 04:26:50 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ma9NK-0002eQ-7Z; Tue, 12 Oct 2021 04:26:50 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ma9NK-0007uG-1Z; Tue, 12 Oct 2021 04:26:50 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ma9NJ-00030W-L3; Tue, 12 Oct 2021 04:26:49 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ma9NJ-00083H-KC; Tue, 12 Oct 2021 04:26:49 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=5RtJVKfoSbxydHNeabu+TP0ylO/BU5BRGszurAeRa+Q=; b=Xdg7xQ0PMYU9pyVycIXM0rLdio
	6J0o71GpRdPQZOVZVl/GGWNK+fnEP3apjYInH7v2afEcjKl5CDDSHSa3jufiQ7bG6/KHDsJasfbfA
	S3k67GoGnWVZE1yf3nZo6UvLhBAkvb/kiQmFlDzXcR2ahdE/mlksppBdDzzzbNnwLyeU=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165468-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 165468: tolerable FAIL - PUSHED
X-Osstest-Failures:
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=c09124dcb8401a0d635b4a52b295e9b3fc12392a
X-Osstest-Versions-That:
    qemuu=15a0578903dc0d612e63f542d159fe1f3fb8a17a
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 12 Oct 2021 04:26:49 +0000

flight 165468 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165468/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165442
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165442
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 165442
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 165442
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 165442
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 165442
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 165442
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165442
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 qemuu                c09124dcb8401a0d635b4a52b295e9b3fc12392a
baseline version:
 qemuu                15a0578903dc0d612e63f542d159fe1f3fb8a17a

Last test of basis   165442  2021-10-09 04:54:47 Z    2 days
Testing same since   165468  2021-10-11 18:37:55 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Richard Henderson <richard.henderson@linaro.org>
  Stefan Hajnoczi <stefanha@redhat.com>
  Stefano Garzarella <sgarzare@redhat.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/qemu-xen.git
   15a0578903..c09124dcb8  c09124dcb8401a0d635b4a52b295e9b3fc12392a -> upstream-tested


From xen-devel-bounces@lists.xenproject.org Tue Oct 12 04:40:29 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 04:40:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.206719.362353 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ma9aL-000589-Nh; Tue, 12 Oct 2021 04:40:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 206719.362353; Tue, 12 Oct 2021 04:40:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ma9aL-000582-KQ; Tue, 12 Oct 2021 04:40:17 +0000
Received: by outflank-mailman (input) for mailman id 206719;
 Tue, 12 Oct 2021 04:40:16 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=amut=PA=intel.com=kevin.tian@srs-us1.protection.inumbo.net>)
 id 1ma9aJ-00057w-Ra
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 04:40:16 +0000
Received: from mga04.intel.com (unknown [192.55.52.120])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id d5a21374-e404-4a92-82a6-e5f867fb35d4;
 Tue, 12 Oct 2021 04:40:12 +0000 (UTC)
Received: from orsmga001.jf.intel.com ([10.7.209.18])
 by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 11 Oct 2021 21:40:11 -0700
Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19])
 by orsmga001.jf.intel.com with ESMTP; 11 Oct 2021 21:40:11 -0700
Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by
 ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2242.12; Mon, 11 Oct 2021 21:40:11 -0700
Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by
 ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2242.12; Mon, 11 Oct 2021 21:40:10 -0700
Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by
 orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2242.12 via Frontend Transport; Mon, 11 Oct 2021 21:40:10 -0700
Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.108)
 by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.1.2242.12; Mon, 11 Oct 2021 21:40:10 -0700
Received: from BN9PR11MB5433.namprd11.prod.outlook.com (2603:10b6:408:11e::13)
 by BN8PR11MB3700.namprd11.prod.outlook.com (2603:10b6:408:89::32)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.19; Tue, 12 Oct
 2021 04:40:07 +0000
Received: from BN9PR11MB5433.namprd11.prod.outlook.com
 ([fe80::ddb7:fa7f:2cc:45df]) by BN9PR11MB5433.namprd11.prod.outlook.com
 ([fe80::ddb7:fa7f:2cc:45df%9]) with mapi id 15.20.4587.026; Tue, 12 Oct 2021
 04:40:07 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d5a21374-e404-4a92-82a6-e5f867fb35d4
X-IronPort-AV: E=McAfee;i="6200,9189,10134"; a="225811169"
X-IronPort-AV: E=Sophos;i="5.85,366,1624345200"; 
   d="scan'208";a="225811169"
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.85,366,1624345200"; 
   d="scan'208";a="524068733"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=UxKrZia/TlW9aexlPblbb/Xq6NtzR1TadVkbr9Y8647Lg8t2UOG/pwvvm/uzFQY2t06f6jkyZj91x9YygPc+AxDPxD/KZjWGglQlqq/loAzvA/xqg9SZz+G3FFkuC++tuRomuCD+0x22NJKenwFJIaAMSKGgvpSTDHC+ZtwrI2dM3q6ST7GvKv7N5t9UNpC8nM8yhywLz/LvvBlCq8P7ruce0Gm1466ajhHe1xn6KyRuOObsytIFd3NT7bXboATdPycPpzHntyhFlPr0FOXCXI+/+y28lgWMrwDeN9SaH0XjcVhkNNu4HG9REMeEWkXpmqW6MY08P5YVaC59lMtrng==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=cCFKs9erdRcacidxxprgWQWJ+ULIZ4pcgNIxefaRizA=;
 b=GORpbdqm43rFEtd0Qrv9cSHID6fDD+gJXj6g0Aya8Blu/YgUL/VzZkpJW+fhsRoe86gnbJYn68BsB+hAlQO94532V5xgtUPi8V/qWlTIX2L46jMUlddGBKFeyF0DPAXw0pk8rvT5HeADdmni8OVIanuQ5aEBdDh65C+zd84N8nXB5y7DQ73DsfOl/vXhziG9phM6PCp81oSgqkr3TnDgo1gaM2FH3AVbgb87FHij5DgRtVH6OYVjjErMnixXjfRoZm58kvTzMCkmOf/5k3W1by0CwDRYMRr/zdnquB2Tj0m0yZRbIwHowPClcly/k27Ld0dZqXTYdljJNZHuhRT3rQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;
 dkim=pass header.d=intel.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com;
 s=selector2-intel-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=cCFKs9erdRcacidxxprgWQWJ+ULIZ4pcgNIxefaRizA=;
 b=ltlAlQ2RPXpi7WUsStNrF9q9LHgFA1CIMpee0Zz9PcpnGKFQzPQ31eJXUMkMCqBXbSRwKwRm/D+lmWmZFt3VM9LCpssmPG2MS+VH9TTHDqmZyLHtOf+mZep8n97o7EZ5bRj6U380LoLHjiBBdWXLR186FxyWZek/9rKJ8Vc5A2k=
From: "Tian, Kevin" <kevin.tian@intel.com>
To: Jan Beulich <jbeulich@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Ian Jackson <iwj@xenproject.org>
Subject: RE: [PATCH 2/2] VT-d: Tylersburg isoch DMAR unit with no TLB space
Thread-Topic: [PATCH 2/2] VT-d: Tylersburg isoch DMAR unit with no TLB space
Thread-Index: AQHXvnz7yqUSecH0tE2jO7udKupRsKvOx/6Q
Date: Tue, 12 Oct 2021 04:40:07 +0000
Message-ID: <BN9PR11MB54332C8D22C30EBF151133338CB69@BN9PR11MB5433.namprd11.prod.outlook.com>
References: <ced41449-6aa2-3b20-77cd-78dafcad4bc7@suse.com>
 <a385938d-243e-1790-da1f-be7c4f5f2c3f@suse.com>
In-Reply-To: <a385938d-243e-1790-da1f-be7c4f5f2c3f@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: suse.com; dkim=none (message not signed)
 header.d=none;suse.com; dmarc=none action=none header.from=intel.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 13ef5e4e-37c2-45e0-0e01-08d98d3a5e35
x-ms-traffictypediagnostic: BN8PR11MB3700:
x-microsoft-antispam-prvs: <BN8PR11MB3700472FB1E663ACECC85F268CB69@BN8PR11MB3700.namprd11.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:7219;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: qr9sdjAJ3/x4YNdt5+ntAn3dRi2u+wTK9CVi9PoC1u09RUIfJZouCeoka98DJ3o7hABnoqUe94vhPoePgzJWJVxMCWMp3Byk+9XFmyu4kHGBZqfGJEvcqnjMUWGnVhz2NPp2yox2iQx27aUGn3/Ym9JMMxhkgGMp6iO2PnebGBkLVYnq4L0MBwhm+jNPvB/Tg+/fctrMzxy050kuhzkb7rnyIR0pAv08eS+e9RVYRcicX33DgBEOhChTJ0GnhHb3oPdhPHljej+ttkLFrxz81/cAtvx16cr+YHhJ91YqCftk96i+c8/XNa+Dmj4cLz03EbuRWcaAEtv3W16pSmZvdTNKk6NGhg0TYBK0Jm0cP4w+O+kV3BxUO7ZWqR8iXvF1Wl7IGPgPzOF5ofSsDnjMubmMcnxr8OT1JJtZ/rzYypEhd5yGTTWRnV5BgveDiDc/tZf7TCscC1Kh+0zmTEVq7TEXGdK08/l6zr3FQ0y0K7TBSQ4ZJv2Y2IrEuZ/1BvhGS3J4iqE65mM0sez9oKgGtX63SKIODXN24kiGx7VhrvKa7SmO+6OTgRUBfpT65QN4MWqtpF/NQN3yg8+G5W9YgLDvZyDQUQeMpClQsnmjC0txQeRqjgs8qykQ+328U4gYHFelGsB5AlooPN68ORMMXI7P2KSMUz9/7k2xpCrHkQxTYdiF7BNJI3NKLdu/49CpWoWYGaNl9hsV9l5hikEJGw==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR11MB5433.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(52536014)(2906002)(64756008)(66556008)(71200400001)(6506007)(7696005)(186003)(26005)(38100700002)(83380400001)(66446008)(9686003)(122000001)(76116006)(38070700005)(86362001)(316002)(66476007)(8676002)(5660300002)(4326008)(508600001)(110136005)(33656002)(66946007)(55016002)(8936002);DIR:OUT;SFP:1102;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?WncwclI5Zy9ObTJ3ekhYd3RpakZuRTVjenhlM0prWTRiNXB2aUVrODJWSC9X?=
 =?utf-8?B?czV2eFVzZzQrWGsxTkRzVE8yeFZ2WGMzRTcwN2JLWm9CWHFuSWxxMTc0RGNz?=
 =?utf-8?B?bjlHTVRsVUs1STJDWkUwRzN2aTNMR3lBSm5DK3BIMjdzVjJkWXo3bE02c3pG?=
 =?utf-8?B?YlNMYlB3V3ZqTCs5d1F6NjNnRnJYQXRFd1pXWWJxZHN4YkZ4blJ5cVk4M29h?=
 =?utf-8?B?eitHc0lnWElKbVZaK1Q4SmUycVFJRnhETWd5dVlac1ZWMTRKWEpQaXZZZVJt?=
 =?utf-8?B?SlVPckpLc3Nwc0l2NDRTWDdsWWMydkZ6VHJVMzV2UlQvYjBCMitxQmxNOVpI?=
 =?utf-8?B?TGJXZ3V0OHlyemw0bnhPSFVzU2VCTGQwTWh4QTBLSWNMa0RHblZERE9LOVlU?=
 =?utf-8?B?dzJ2cjBManVOMk5hRU5zVmJZKyt5TUFsNm9ORHRPRVdaR01lVnJ3WVVadW91?=
 =?utf-8?B?dnBtMmFQQTBGTWFkUEVCSjVLWUNzb2RUY3FUZHFmVCt1VDRIeUJjS2ROQUI3?=
 =?utf-8?B?TDJXYUhSblh2MUsxRWZRME5tMjE0UlhJSTNiNlN1TnJCMCtnakVNQjdvZmpm?=
 =?utf-8?B?RGV0WGNGYzd4UW5nZFc3c0dWM0tzbytQelZaR3RjSVhvUE5iRFlTTWJEcGtV?=
 =?utf-8?B?YjlibXpPRWF0MHZuYTBFbUFmQTlNUE1FdWdsdXpnWUZCU3ltYy9sOWZ6SC8z?=
 =?utf-8?B?bEhNNGd2Y2FWRTBPZ010V29SbnI5ZStKOWx0QUZUQ25DaFZObE1HNzJ2dlJu?=
 =?utf-8?B?a2xRWFRwUVQ0Y1dqeTJGUG5rQlVNY0hkRHNranpzVXNaSDFNTlArQVRHWUtz?=
 =?utf-8?B?Rmg1SnZjd1VxUHhXNlpKNzJueHN4NmphM3c3Z3p5aTY3UGR1dDZBamd4WUxK?=
 =?utf-8?B?NlJ4SW9jK3ZESGFtYjQrV0k4OTFEUlFSSDFTdHl1UzhJUStvUElRbnR6UkNZ?=
 =?utf-8?B?bXhwcmltaVh0YTJmWURNRkdUeHdDbThmS2RzR3BMS0JhdGxzc3dtUXgwNUxl?=
 =?utf-8?B?TkhTbHJiR3NibDlsRDBrYTlTUSt0WGFVb3lCUlRrQmpOQzYxSWVKR3NlK0s3?=
 =?utf-8?B?dWNVald3K2lsYXdJVHJpRG9YRk9nOWNCeVB0TmE5ZXgxd29WUkd4WjEzTDBG?=
 =?utf-8?B?YXdHL2VlT0M4Q2J6cVNhbHY4RmRsTEh0TEVNa2twU28wTFJzOXBYdGZiSHBQ?=
 =?utf-8?B?R2lTZDdyQmQwMnFocjZEWjBWSGpoWVJFNmxTVDd5c1c3S1Z1UEgxNzY0UXpV?=
 =?utf-8?B?WVhIWVNTemxuT09DVENMMHMvNTFoOXhpL0FZYTZvc3dDS3dRTTlsQThXV3Na?=
 =?utf-8?B?RHlsdjQ1NWhHUCtaeTlIeGwyWFB6UWNUamt6RUg3WmtlZklhYnY1QkhCSXE3?=
 =?utf-8?B?Nlc2Y2RLMzBwRjhDb3lXb0lKQVpEYzN2WDRrOUFuUWpzQTh0YWcwbDlNYkJQ?=
 =?utf-8?B?QytIeUFVcWFyUmpNL0lzUlV3VUQ2bFBCUDBka3lkSWdVdjlCcnhPRWlKb2VX?=
 =?utf-8?B?YkxCNGNiT0wvdmUzRU81MTBMZWlocmtxbktCdVNQaG1jM2dXZllxc2Y3eTkw?=
 =?utf-8?B?aGZhOEM5SWI3VjVOR3djbTV1RHFmZURkVnBhaXVEWnYvUmNNOFlnSGFDQ2lt?=
 =?utf-8?B?aFFOd2Q3eHhFVTNqcHBwNHZib3VSWGRtNjRJNEt6WU5tYjZaZzlYM096cDZO?=
 =?utf-8?B?cFhMR2pTSXUreG9Nd3BoOWs2anFsYy9oU1gxVVgzUWVSNjZlVVdRbThnamVs?=
 =?utf-8?Q?eLj8x08ewIQjUfhgGXGPEeeUR+HpyF4JMj/RWpe?=
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5433.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 13ef5e4e-37c2-45e0-0e01-08d98d3a5e35
X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Oct 2021 04:40:07.7352
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: pUWJEItk0PR9IC1w74wJhmLVsInXbeWVW0sB8M0E6gdCGR/w9O1NBd0qt+206je44m6QwSEYaCzrqqS+0sGuGA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR11MB3700
X-OriginatorOrg: intel.com

PiBGcm9tOiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+DQo+IFNlbnQ6IE1vbmRheSwg
T2N0b2JlciAxMSwgMjAyMSA0OjUwIFBNDQo+IA0KPiBCSU9TZXMsIHdoZW4gZW5hYmxpbmcgdGhl
IGRlZGljYXRlZCBETUFSIHVuaXQgZm9yIHRoZSBzb3VuZCBkZXZpY2UsDQo+IG5lZWQgdG8gYWxz
byBzZXQgYSBub24temVybyBudW1iZXIgb2YgVExCIGVudHJpZXMgaW4gYSByZXNwZWN0aXZlDQo+
IHN5c3RlbSBtYW5hZ2VtZW50IHJlZ2lzdGVyIChWVElTT0NIQ1RSTCkuIEF0IGxlYXN0IG9uZSBC
SU9TIGlzIGtub3duDQo+IHRvIGZhaWwgdG8gZG8gc28sIGNhdXNpbmcgdGhlIFZULWQgZW5naW5l
IHRvIGRlYWRsb2NrIHdoZW4gdXNlZC4NCj4gDQo+IFZhZ3VlbHkgYmFzZWQgb24gTGludXgnZXMg
ZTBmYzdlMGI0YjVlICgiaW50ZWwtaW9tbXU6IFlldCBhbm90aGVyIEJJT1MNCj4gd29ya2Fyb3Vu
ZDogSXNvY2ggRE1BUiB1bml0IHdpdGggbm8gVExCIHNwYWNlIikuDQo+IA0KPiBUbyBsaW1pdCBt
ZXNzYWdlIHN0cmluZyByZWR1bmRhbmN5LCBmb2xkIHBhcnRzIHdpdGggdGhlIElHRCBxdWlyayBs
b2dpYy4NCj4gDQo+IFNpZ25lZC1vZmYtYnk6IEphbiBCZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNv
bT4NCj4gLS0tDQo+IFJGQzogVGhpcyByZXF1aXJlcyBNTUNGRyBhdmFpbGFiaWxpdHkgYmVmb3Jl
IERvbTAgc3RhcnRzIHVwLCB3aGljaCBpcw0KPiAgICAgIG5vdCBnZW5lcmFsbHkgZ2l2ZW4uIFdl
IG1heSB3YW50L25lZWQgdG8gZS5nLiAoYWIpdXNlIHRoZQ0KPiAgICAgIC5lbmFibGVfZGV2aWNl
KCkgaG9vayB0byBhY3R1YWxseSBkaXNhYmxlIHRyYW5zbGF0aW9uIGlmIE1NQ0ZHDQo+ICAgICAg
YWNjZXNzZXMgYmVjb21lIGF2YWlsYWJsZSBvbmx5IGluIHRoZSBjb3Vyc2Ugb2YgRG9tMCBib290
aW5nLg0KDQptYWtlIHNlbnNlDQoNCj4gUkZDOiBXaGlsZSBmb2xsb3dpbmcgTGludXggaW4gdGhp
cyByZWdhcmQsIEknbSBub3QgY29udmluY2VkIG9mIGlzc3VpbmcNCj4gICAgICB0aGUgd2Fybmlu
ZyBhYm91dCB0aGUgbnVtYmVyIG9mIFRMQiBlbnRyaWVzIHdoZW4gZmlybXdhcmUgc2V0IG1vcmUN
Cj4gICAgICB0aGFuIDE2IChJIGNhbiBvYnNlcnZlIDIwIG9uIHRoZSBvbiBtYXRjaGluZyBzeXN0
ZW0gSSBoYXZlIGFjY2Vzcw0KPiAgICAgIHRvLikNCg0KbWUgZWl0aGVyLiBTaW5jZSB5b3UgYWxy
ZWFkeSBvYnNlcnZlZCAyMCBvbiBvbmUgc3lzdGVtLCBjaGFuZ2luZyB0aGUNCmNoZWNrIHRvID49
MTYgbWFrZXMgbW9yZSBzZW5zZS4NCg0KVGhlIHJlc3QgbG9va3MgZ29vZCB0byBtZToNCg0KCVJl
dmlld2VkLWJ5OiBLZXZpbiBUaWFuIDxrZXZpbi50aWFuQGludGVsLmNvbT4NCg0KPiANCj4gSSBh
c3N1bWUgYW4gaW1wbGljYXRpb24gaXMgdGhhdCB0aGUgZGV2aWNlIGluIHRoaXMgY2FzZSB0aGVu
IG1heSBub3QgYmUNCj4gcGFzc2VkIHRocm91Z2ggdG8gZ3Vlc3RzLCBidXQgSSBkb24ndCBzZWUg
dXMgZW5mb3JjaW5nIHRoZSBzYW1lIGFueXdoZXJlDQo+IGZvciBncmFwaGljcyBkZXZpY2VzIHdo
ZW4gIm5vLWlnZngiIGlzIGluIHVzZS4gWWV0IGhlcmUgSSB3b3VsZCB3YW50IHRvDQo+IGZvbGxv
dyB3aGF0ZXZlciBwcmUtZXhpc3RpbmcgbW9kZWwgLi4uDQo+IA0KPiAtLS0gYS94ZW4vZHJpdmVy
cy9wYXNzdGhyb3VnaC92dGQvZXh0ZXJuLmgNCj4gKysrIGIveGVuL2RyaXZlcnMvcGFzc3Rocm91
Z2gvdnRkL2V4dGVybi5oDQo+IEBAIC0xMDAsNiArMTAwLDcgQEAgaW50IG1zaV9tc2dfd3JpdGVf
cmVtYXBfcnRlKHN0cnVjdCBtc2lfZA0KPiAgaW50IGludGVsX3NldHVwX2hwZXRfbXNpKHN0cnVj
dCBtc2lfZGVzYyAqKTsNCj4gDQo+ICBpbnQgaXNfaWdkX3Z0X2VuYWJsZWRfcXVpcmsodm9pZCk7
DQo+ICtib29sIGlzX2F6YWxpYV90bGJfZW5hYmxlZChjb25zdCBzdHJ1Y3QgYWNwaV9kcmhkX3Vu
aXQgKik7DQo+ICB2b2lkIHBsYXRmb3JtX3F1aXJrc19pbml0KHZvaWQpOw0KPiAgdm9pZCB2dGRf
b3BzX3ByZWFtYmxlX3F1aXJrKHN0cnVjdCB2dGRfaW9tbXUgKmlvbW11KTsNCj4gIHZvaWQgdnRk
X29wc19wb3N0YW1ibGVfcXVpcmsoc3RydWN0IHZ0ZF9pb21tdSAqaW9tbXUpOw0KPiAtLS0gYS94
ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC92dGQvaW9tbXUuYw0KPiArKysgYi94ZW4vZHJpdmVycy9w
YXNzdGhyb3VnaC92dGQvaW9tbXUuYw0KPiBAQCAtNzUwLDI3ICs3NTAsNDMgQEAgc3RhdGljIHZv
aWQgaW9tbXVfZW5hYmxlX3RyYW5zbGF0aW9uKHN0cg0KPiAgICAgIHUzMiBzdHM7DQo+ICAgICAg
dW5zaWduZWQgbG9uZyBmbGFnczsNCj4gICAgICBzdHJ1Y3QgdnRkX2lvbW11ICppb21tdSA9IGRy
aGQtPmlvbW11Ow0KPiArICAgIHN0YXRpYyBjb25zdCBjaGFyIGNyYXNoX2ZtdFtdID0gIiVzOyBj
cmFzaCBYZW4gZm9yIHNlY3VyaXR5IHB1cnBvc2VcbiI7DQo+IA0KPiAgICAgIGlmICggZHJoZC0+
Z2Z4X29ubHkgKQ0KPiAgICAgIHsNCj4gKyAgICAgICAgc3RhdGljIGNvbnN0IGNoYXIgZGlzYWJs
ZV9mbXRbXSA9IFhFTkxPR19XQVJOSU5HIFZURFBSRUZJWA0KPiArICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgIiAlczsgZGlzYWJsaW5nIElHRCBWVC1kIGVuZ2luZVxu
IjsNCj4gKw0KPiAgICAgICAgICBpZiAoICFpb21tdV9pZ2Z4ICkNCj4gICAgICAgICAgew0KPiAt
ICAgICAgICAgICAgcHJpbnRrKFhFTkxPR19JTkZPIFZURFBSRUZJWA0KPiAtICAgICAgICAgICAg
ICAgICAgICJQYXNzZWQgaW9tbXU9bm8taWdmeCBvcHRpb24uICBEaXNhYmxpbmcgSUdEIFZULWQg
ZW5naW5lLlxuIik7DQo+ICsgICAgICAgICAgICBwcmludGsoZGlzYWJsZV9mbXQsICJwYXNzZWQg
aW9tbXU9bm8taWdmeCBvcHRpb24iKTsNCj4gICAgICAgICAgICAgIHJldHVybjsNCj4gICAgICAg
ICAgfQ0KPiANCj4gICAgICAgICAgaWYgKCAhaXNfaWdkX3Z0X2VuYWJsZWRfcXVpcmsoKSApDQo+
ICAgICAgICAgIHsNCj4gKyAgICAgICAgICAgIHN0YXRpYyBjb25zdCBjaGFyIG1zZ1tdID0gImZp
cm13YXJlIGRpZCBub3QgZW5hYmxlIElHRCBmb3IgVlQNCj4gcHJvcGVybHkiOw0KPiArDQo+ICAg
ICAgICAgICAgICBpZiAoIGZvcmNlX2lvbW11ICkNCj4gLSAgICAgICAgICAgICAgICBwYW5pYygi
QklPUyBkaWQgbm90IGVuYWJsZSBJR0QgZm9yIFZUIHByb3Blcmx5LCBjcmFzaCBYZW4gZm9yDQo+
IHNlY3VyaXR5IHB1cnBvc2VcbiIpOw0KPiArICAgICAgICAgICAgICAgIHBhbmljKGNyYXNoX2Zt
dCwgbXNnKTsNCj4gDQo+IC0gICAgICAgICAgICBwcmludGsoWEVOTE9HX1dBUk5JTkcgVlREUFJF
RklYDQo+IC0gICAgICAgICAgICAgICAgICAgIkJJT1MgZGlkIG5vdCBlbmFibGUgSUdEIGZvciBW
VCBwcm9wZXJseS4gIERpc2FibGluZyBJR0QgVlQtZA0KPiBlbmdpbmUuXG4iKTsNCj4gKyAgICAg
ICAgICAgIHByaW50ayhkaXNhYmxlX2ZtdCwgbXNnKTsNCj4gICAgICAgICAgICAgIHJldHVybjsN
Cj4gICAgICAgICAgfQ0KPiAgICAgIH0NCj4gDQo+ICsgICAgaWYgKCAhaXNfYXphbGlhX3RsYl9l
bmFibGVkKGRyaGQpICkNCj4gKyAgICB7DQo+ICsgICAgICAgIHN0YXRpYyBjb25zdCBjaGFyIG1z
Z1tdID0gImZpcm13YXJlIGRpZCBub3QgZW5hYmxlIFRMQiBmb3Igc291bmQNCj4gZGV2aWNlIjsN
Cj4gKw0KPiArICAgICAgICBpZiAoIGZvcmNlX2lvbW11ICkNCj4gKyAgICAgICAgICAgIHBhbmlj
KGNyYXNoX2ZtdCwgbXNnKTsNCj4gKw0KPiArICAgICAgICBwcmludGsoWEVOTE9HX1dBUk5JTkcg
VlREUFJFRklYICIgJXM7IGRpc2FibGluZyBJU09DSCBWVC1kDQo+IGVuZ2luZVxuIiwNCj4gKyAg
ICAgICAgICAgICAgIG1zZyk7DQo+ICsgICAgICAgIHJldHVybjsNCj4gKyAgICB9DQo+ICsNCj4g
ICAgICAvKiBhcHBseSBwbGF0Zm9ybSBzcGVjaWZpYyBlcnJhdGEgd29ya2Fyb3VuZHMgKi8NCj4g
ICAgICB2dGRfb3BzX3ByZWFtYmxlX3F1aXJrKGlvbW11KTsNCj4gDQo+IC0tLSBhL3hlbi9kcml2
ZXJzL3Bhc3N0aHJvdWdoL3Z0ZC9xdWlya3MuYw0KPiArKysgYi94ZW4vZHJpdmVycy9wYXNzdGhy
b3VnaC92dGQvcXVpcmtzLmMNCj4gQEAgLTEwMCw2ICsxMDAsNjkgQEAgc3RhdGljIHZvaWQgX19p
bml0IGNhbnRpZ2FfYjNfZXJyYXRhX2luaQ0KPiAgICAgICAgICBpc19jYW50aWdhX2IzID0gMTsN
Cj4gIH0NCj4gDQo+ICsvKg0KPiArICogUVVJUksgdG8gd29yayBhcm91bmQgY2VydGFpbiBCSU9T
ZXMgZW5hYmxpbmcgdGhlIElTT0NIIERNQVIgdW5pdCBmb3INCj4gdGhlDQo+ICsgKiBBemFsaWEg
c291bmQgZGV2aWNlLCBidXQgbm90IGdpdmluZyBpdCBhbnkgVExCIGVudHJpZXMsIGNhdXNpbmcg
aXQgdG8NCj4gKyAqIGRlYWRsb2NrLg0KPiArICovDQo+ICtib29sIGlzX2F6YWxpYV90bGJfZW5h
YmxlZChjb25zdCBzdHJ1Y3QgYWNwaV9kcmhkX3VuaXQgKmRyaGQpDQo+ICt7DQo+ICsgICAgcGNp
X3NiZGZfdCBzYmRmOw0KPiArICAgIHVuc2lnbmVkIGludCB2dGlzb2NoY3RybDsNCj4gKw0KPiAr
ICAgIC8qIE9ubHkgZGVkaWNhdGVkIHVuaXRzIGFyZSBvZiBpbnRlcmVzdC4gKi8NCj4gKyAgICBp
ZiAoIGRyaGQtPmluY2x1ZGVfYWxsIHx8IGRyaGQtPnNjb3BlLmRldmljZXNfY250ICE9IDEgKQ0K
PiArICAgICAgICByZXR1cm4gdHJ1ZTsNCj4gKw0KPiArICAgIC8qIENoZWNrIGZvciB0aGUgc3Bl
Y2lmaWMgZGV2aWNlLiAqLw0KPiArICAgIHNiZGYgPSBQQ0lfU0JERjIoZHJoZC0+c2VnbWVudCwg
ZHJoZC0+c2NvcGUuZGV2aWNlc1swXSk7DQo+ICsgICAgaWYgKCBwY2lfY29uZl9yZWFkMTYoc2Jk
ZiwgUENJX1ZFTkRPUl9JRCkgIT0gUENJX1ZFTkRPUl9JRF9JTlRFTCB8fA0KPiArICAgICAgICAg
cGNpX2NvbmZfcmVhZDE2KHNiZGYsIFBDSV9ERVZJQ0VfSUQpICE9IDB4M2EzZSApDQo+ICsgICAg
ICAgIHJldHVybiB0cnVlOw0KPiArDQo+ICsgICAgLyogQ2hlY2sgZm9yIHRoZSBjb3JyZXNwb25k
aW5nIFN5c3RlbSBNYW5hZ2VtZW50IFJlZ2lzdGVycyBkZXZpY2UuICovDQo+ICsgICAgc2JkZiA9
IFBDSV9TQkRGKGRyaGQtPnNlZ21lbnQsIDAsIDB4MTQsIDApOw0KPiArICAgIGlmICggcGNpX2Nv
bmZfcmVhZDE2KHNiZGYsIFBDSV9WRU5ET1JfSUQpICE9IFBDSV9WRU5ET1JfSURfSU5URUwgfHwN
Cj4gKyAgICAgICAgIHBjaV9jb25mX3JlYWQxNihzYmRmLCBQQ0lfREVWSUNFX0lEKSAhPSAweDM0
MmUgKQ0KPiArICAgICAgICByZXR1cm4gdHJ1ZTsNCj4gKw0KPiArICAgIHZ0aXNvY2hjdHJsID0g
cGNpX2NvbmZfcmVhZDMyKHNiZGYsIDB4MTg4KTsNCj4gKyAgICBpZiAoIHZ0aXNvY2hjdHJsID09
IDB4ZmZmZmZmZmYgKQ0KPiArICAgIHsNCj4gKyAgICAgICAgcHJpbnRrKFhFTkxPR19XQVJOSU5H
IFZURFBSRUZJWA0KPiArICAgICAgICAgICAgICAgIiBDYW5ub3QgYWNjZXNzIFZUSVNPQ0hDVFJM
IGF0IHRoaXMgdGltZVxuIik7DQo+ICsgICAgICAgIHJldHVybiB0cnVlOw0KPiArICAgIH0NCj4g
Kw0KPiArICAgIC8qDQo+ICsgICAgICogSWYgQXphbGlhIERNQSBpcyByb3V0ZWQgdG8gdGhlIG5v
bi1pc29jaCBETUFSIHVuaXQsIHRoYXQncyBmaW5lIGluDQo+ICsgICAgICogcHJpbmNpcGxlLCBi
dXQgbm90IGNvbnNpc3RlbnQgd2l0aCB0aGUgQUNQSSB0YWJsZXMuDQo+ICsgICAgICovDQo+ICsg
ICAgaWYgKCB2dGlzb2NoY3RybCAmIDEgKQ0KPiArICAgIHsNCj4gKyAgICAgICAgcHJpbnRrKFhF
TkxPR19XQVJOSU5HIFZURFBSRUZJWA0KPiArICAgICAgICAgICAgICAgIiBJbmNvbnNpc3RlbmN5
IGJldHdlZW4gY2hpcHNldCByZWdpc3RlcnMgYW5kIEFDUEkgdGFibGVzXG4iKTsNCj4gKyAgICAg
ICAgcmV0dXJuIHRydWU7DQo+ICsgICAgfQ0KPiArDQo+ICsgICAgLyogRHJvcCBhbGwgYml0cyBv
dGhlciB0aGFuIHRoZSBudW1iZXIgb2YgVExCIGVudHJpZXMuICovDQo+ICsgICAgdnRpc29jaGN0
cmwgJj0gMHgxYzsNCj4gKw0KPiArICAgIC8qIElmIHdlIGhhdmUgdGhlIHJlY29tbWVuZGVkIG51
bWJlciBvZiBUTEIgZW50cmllcywgZmluZS4gKi8NCj4gKyAgICBpZiAoIHZ0aXNvY2hjdHJsID09
IDE2ICkNCj4gKyAgICAgICAgcmV0dXJuIHRydWU7DQo+ICsNCj4gKyAgICAvKiBaZXJvIFRMQiBl
bnRyaWVzPyAqLw0KPiArICAgIGlmICggIXZ0aXNvY2hjdHJsICkNCj4gKyAgICAgICAgcmV0dXJu
IGZhbHNlOw0KPiArDQo+ICsgICAgcHJpbnRrKFhFTkxPR19XQVJOSU5HIFZURFBSRUZJWA0KPiAr
ICAgICAgICAgICAiIFJlY29tbWVuZGVkIFRMQiBlbnRyaWVzIGZvciBJU09DSCB1bml0IGlzIDE2
OyBmaXJtd2FyZSBzZXQgJXVcbiIsDQo+ICsgICAgICAgICAgIHZ0aXNvY2hjdHJsKTsNCj4gKw0K
PiArICAgIHJldHVybiB0cnVlOw0KPiArfQ0KPiArDQo+ICAvKiBjaGVjayBmb3IgU2FuZHlicmlk
Z2UgSUdEIGRldmljZSBJRCdzICovDQo+ICBzdGF0aWMgdm9pZCBfX2luaXQgc25iX2VycmF0YV9p
bml0KHZvaWQpDQo+ICB7DQoNCg==


From xen-devel-bounces@lists.xenproject.org Tue Oct 12 05:17:51 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 05:17:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.206727.362365 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maAAa-0000F7-K8; Tue, 12 Oct 2021 05:17:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 206727.362365; Tue, 12 Oct 2021 05:17:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maAAa-0000F0-Fy; Tue, 12 Oct 2021 05:17:44 +0000
Received: by outflank-mailman (input) for mailman id 206727;
 Tue, 12 Oct 2021 05:17:42 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1maAAY-0000Eq-D8; Tue, 12 Oct 2021 05:17:42 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1maAAY-0000dr-3n; Tue, 12 Oct 2021 05:17:42 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1maAAU-0005K5-Fq; Tue, 12 Oct 2021 05:17:38 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1maAAU-00016q-FM; Tue, 12 Oct 2021 05:17:38 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=eof2l7DxKE+ugnOATVoE+TWUHb11GxCwzsG2y3rwdUE=; b=re8txewL02qgNI5LZR3l26kJ3u
	u40Cz3/A1SvzQ2KGgmNzTBJtbOEEKhlQaP7L7VhGNXbpRpGbZ4mEOBU29NOn36Of76DYcEs5NTGUC
	j1m8AeZhsdVsKNZkqoTxTO3DTGwK+KKBd79pVEq29P3VS2JFMnbDOHDw0vgzDudWwha0=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165472-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 165472: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=e26f810a6f9295afe30ea08195715ddd96e2a123
X-Osstest-Versions-That:
    xen=e8b42a4e8810844ccffd2eab072921b1e4e2ed79
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 12 Oct 2021 05:17:38 +0000

flight 165472 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165472/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  e26f810a6f9295afe30ea08195715ddd96e2a123
baseline version:
 xen                  e8b42a4e8810844ccffd2eab072921b1e4e2ed79

Last test of basis   165466  2021-10-11 15:02:49 Z    0 days
Testing same since   165472  2021-10-12 02:00:27 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Anthony PERARD <anthony.perard@citrix.com>
  Luca Fancellu <luca.fancellu@arm.com>
  Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
  Rahul Singh <rahul.singh@arm.com>
  Stefano Stabellini <sstabellini@kernel.org>
  Stefano Stabellini <stefano.stabellini@xilinx.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   e8b42a4e88..e26f810a6f  e26f810a6f9295afe30ea08195715ddd96e2a123 -> smoke


From xen-devel-bounces@lists.xenproject.org Tue Oct 12 05:35:17 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 05:35:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.206736.362378 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maARS-0002Xg-3v; Tue, 12 Oct 2021 05:35:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 206736.362378; Tue, 12 Oct 2021 05:35:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maARS-0002XU-0i; Tue, 12 Oct 2021 05:35:10 +0000
Received: by outflank-mailman (input) for mailman id 206736;
 Tue, 12 Oct 2021 05:35:09 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=fUjJ=PA=epam.com=prvs=091947bc67=oleksandr_andrushchenko@srs-us1.protection.inumbo.net>)
 id 1maARQ-0002Wd-Og
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 05:35:08 +0000
Received: from mx0b-0039f301.pphosted.com (unknown [148.163.137.242])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 286830c6-2b1e-11ec-8110-12813bfff9fa;
 Tue, 12 Oct 2021 05:35:07 +0000 (UTC)
Received: from pps.filterd (m0174682.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 19C3m8hK009515; 
 Tue, 12 Oct 2021 05:35:02 GMT
Received: from eur04-db3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2052.outbound.protection.outlook.com [104.47.12.52])
 by mx0b-0039f301.pphosted.com with ESMTP id 3bn0gp8e9x-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Tue, 12 Oct 2021 05:35:01 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by VI1PR0302MB2768.eurprd03.prod.outlook.com (2603:10a6:800:e3::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.19; Tue, 12 Oct
 2021 05:34:57 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::b034:334a:abf5:223c]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::b034:334a:abf5:223c%7]) with mapi id 15.20.4587.026; Tue, 12 Oct 2021
 05:34:57 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 286830c6-2b1e-11ec-8110-12813bfff9fa
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=O0L71adsplHhtKiMJXbbyVxLAstc1zMgUZ+9jVqEzaEOa+tubayBbUhHlhpd2uqr1SPtNRV1n3pKzdPM9Va/rDmhMV/58JfR6ghTL60nL2vUG8hl8T4bCNhCJKftpmvbfjzNbPy6ugd2rKno+lO7AVkhkuHkusmTPqmSkBIt2JhK8UU9+41fQRdQeYdOkuwtQwkD0pwomqUZT1/NIjlZBeXjit6rlUuM+fHF9S75rJxPFTp0wDMWzICP7j5IWY5bt1wtTTL1mkOL3H9aL4dgVKULX2vO0z+jnVVZigLhSK2s47EZkJhMNrZlMgtr01QcXd+GyidzhEpKhX6mRE2N3Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=7qAI6hrCLaj07iwVgjkx6oF+//QWPUavjl1iD8By0QE=;
 b=Iqn9boVcF1IlPRm6jkgU4WiK7nDe28hDcX9pYuwhuKFHDP5j0ohVMoWfff7dwmDFKxKUYIfwMIIN/EWdtRMjgsf7d3KWJGN9zGN4PR2J75iXENP/k2nb2OnR+7Wh2Bb2rCXgeQfrKEYFxkeIob7QsDhWqN3dBmVLo83k+6mmbOuQm8s23fjVcJFWTK/2aIrUMG8REG+xYMvdmBOYqecXmK5Z9FXfKWL94g/MX12eSGE6AsB3h3ywrCttPdsDpsSXD2KvsnwKSWSiv7sFGrshqHYqjET9GGcXcumkUD/KIt3wR/HD3BpVxoiXZ7V11O4aOwD0RgDFf58fY8KqIEL0Ig==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=7qAI6hrCLaj07iwVgjkx6oF+//QWPUavjl1iD8By0QE=;
 b=1Xtq92CCgYotJkWlGLiE6KFR7xgvYkIRC2C3dOQDtQQvxa+L+20eKrrgYZPKqwqB0uSZSpZYcboj73v3L+ZQX/U6M7+ezo8UQKpmeUBhZffxtxiWvUcxQRSpbfFKKWGOFEJDNo50r04kPE96MvJh0QsJV52FV4UM0VAgN8QfOySzJZfHNqVjCZo/mX8Te2vLQFbNAnYgOihOZf4IdWgxZFORScLdGHt9L78UXb1RJpfzy/UFiE5tp81Dg43RYkUyuulU+Yk4WwlnozXLRWqbxld1vwLyea7gcY12nB/eKstYeT/fDSCJlySOcs97Uaf0mFulZ27H/LthJS1n0JgmEA==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Stefano Stabellini <sstabellini@kernel.org>
CC: Bertrand Marquis <bertrand.marquis@arm.com>,
        =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>,
        Rahul Singh
	<rahul.singh@arm.com>,
        "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>,
        Andre Przywara <Andre.Przywara@arm.com>, Julien Grall <julien@xen.org>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Andrew Cooper <andrew.cooper3@citrix.com>,
        George Dunlap <george.dunlap@citrix.com>,
        Ian Jackson <iwj@xenproject.org>, Jan Beulich <jbeulich@suse.com>,
        Wei Liu <wl@xen.org>, Paul Durrant
	<paul@xen.org>,
        Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH v5 08/11] xen/arm: Enable the existing x86 virtual PCI
 support for ARM.
Thread-Topic: [PATCH v5 08/11] xen/arm: Enable the existing x86 virtual PCI
 support for ARM.
Thread-Index: 
 AQHXutl3YqS5dHXsYk6KpdKt4d14RavNphKAgABZ5QCAAAISgIAABoqAgAAJBQCAABTvgIAAD/UAgACpmAA=
Date: Tue, 12 Oct 2021 05:34:57 +0000
Message-ID: <b0b0fef0-5985-f2ac-8d62-1cdf9b2e2153@epam.com>
References: <cover.1633540842.git.rahul.singh@arm.com>
 <9bdca2cda5d2e83f94dc2423e55714273539760a.1633540842.git.rahul.singh@arm.com>
 <YWQXF2vDaWQvi+bT@MacBook-Air-de-Roger.local>
 <4F406854-4F90-48F6-8470-6CCB60A3CB77@arm.com>
 <e199bfe2-0bcc-989f-fd4a-ecf44a3cd1ac@epam.com>
 <YWRpuUtHkyA4RY5H@MacBook-Air-de-Roger.local>
 <AF7AB609-3E79-4017-A296-CC7C87E1705F@arm.com>
 <611b61a4-9635-f1e6-a078-e40d4cbd49fd@epam.com>
 <alpine.DEB.2.21.2110111226220.25528@sstabellini-ThinkPad-T480s>
In-Reply-To: <alpine.DEB.2.21.2110111226220.25528@sstabellini-ThinkPad-T480s>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
authentication-results: kernel.org; dkim=none (message not signed)
 header.d=none;kernel.org; dmarc=none action=none header.from=epam.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 69355542-7505-4d49-52a5-08d98d4206f0
x-ms-traffictypediagnostic: VI1PR0302MB2768:
x-ms-exchange-transport-forked: True
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <VI1PR0302MB2768B918CBF0B85FE304F5F7E7B69@VI1PR0302MB2768.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:9508;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 nDB4vZAS3ibAWLLTjM0yg2x/V+uSvTX1spJnsidBRNVZdGcYm1Zgy7aZYUtEgvAPIEbFY7sQFzfhTZVoMNSWyMIPrSvs2gzP6A0TcuKnGZ3rbT3KpIo7M8EDUTNzySJJr3k1Sipjo9LX0L6Day1NERFrxsoxyXx9f+YdOcxG71mlUQIw57o7NOqY/W5lkUUNVVCIpB+MD0SLiO3jrsWYGtOC6F0I63vpaTP1HUDaEcJVDn9v1kB9jg4tju/6lpI1n2oRbr8MGrRlBISdX24L327FYaVnOXL8yqrF/OjHjurMYcjyZ2RQhgMRQh6iEXsDT15uf0fqMF7v7wAGd7LyDG3Fg/c4YbpVcZ7fx2v3OzdmY9MRI5Jeo4Ir+a2M0dsXPMm1PddnQJ+0lLrbrPPMkh/UOPwPHGBUwobXlLREwiwkyIZUZU4dD0ICMKUERbedWREoA4OOhVoIUg02wR4aIZgi/oY8qcZLsJfTwtnwrLyUSCcgwjmr2Xr3BCSvZ0qMK1NewlpxseGAHc2SU6Cl9dqRTYSKNoL9eAW4g8eF6ZLbjSNfPJyzOBC8VyWFW7e9HDTCs15YPSh9258MIJ62mtMWMMCIpQoQ/de2ncrgVd+6w19dmt9nxJ1izcxqUTXD3qBxdubuIZZJvVBpndqak7qCubC+HcGCRGdJSY782HPqEXrBvCaasLTYvY3C+5EYlvZBqdx8Ww60kK1NX77QMxEjY40PDEjd7jQFAbxg+zhqBWLTW1x9+f9KuAv1QvlJ
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(66946007)(71200400001)(2616005)(38100700002)(6916009)(54906003)(76116006)(91956017)(6512007)(31696002)(66446008)(64756008)(66556008)(66476007)(316002)(7416002)(8936002)(2906002)(508600001)(26005)(107886003)(186003)(4326008)(6486002)(83380400001)(86362001)(122000001)(36756003)(53546011)(6506007)(31686004)(38070700005)(8676002)(5660300002)(55236004)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?U2hudjJJdHBUU2hMWnN2Sm01WkJQSmVQUTc5S2xpSmpXaFMvejJzUUJxS3Qy?=
 =?utf-8?B?dU9pcFN0dlpsZkhLSHR0bmNmZXkvZWN0NENlS0lQa2g4UHhFcnZoWkxyM2pr?=
 =?utf-8?B?cytrUDdSdEk4TkUxc2ZqZzRuT2YvZHlDRXVEUkZHRDFaL21tQVJPVzF4L0t5?=
 =?utf-8?B?a2V2UkFJMUZ0WFNhTmtyVXJ3YXZjZ2NOSnBqWmlQZGhDM0c4QkU1QzJCOHpR?=
 =?utf-8?B?azdKTmFDcU0vNjhDUDhTTUlwTTVKQk9BdGtsWkIwQW0walBHV2FjZUVuVEh1?=
 =?utf-8?B?QXFCeHRpaDI4Zm1qN2c1YmVWYnV6amNEOFd3UVArbjIvT3R0NDBPUnpjRTYy?=
 =?utf-8?B?amd5UHg2cXlRdlR3RTNkcFc1ZlRBN2YxM1liRTNQbUdzTG5KS2VCNVhFaWJM?=
 =?utf-8?B?ZDBPTWRTV2UxRFRmMS9uQ2QxUUpSNG9HekZRQXVNNUVWY0U3dGo5R0ZsVjNl?=
 =?utf-8?B?S3FiQnJMa1BKVllOWWlRQ3gydEo1MmN6eHBmMHp2MjUwRUJLeUY5em16NkZV?=
 =?utf-8?B?MHBRY0FKVWIvR3E5NUVpQTZaYkZ0SlV1a3VnY1gwYzlJeW9QaGg3UnZUV3Q0?=
 =?utf-8?B?bWo3dFlyOEdURTNDTVRjV2hkT3o3ZWRCU3FWVFFkWHFrUXZIQnZoWmtnYmlS?=
 =?utf-8?B?ekJSeXlKUXN0YSsxaERvQndUaDBMNlVUK29OeHVsMWFJSk91alo0c1UxbGk1?=
 =?utf-8?B?WUdsenR6Y0ZsTzJlSG5idzcvSjlKRWVrOVNidllnK0pnNzN1Tm5qRjFWRG96?=
 =?utf-8?B?Sk9aUG8vbUtMNk50UVpLbm91NlpVTFRLYlo5WVc2enV4bFJFWEhmMC9kVGRt?=
 =?utf-8?B?bkRwNy9hRDdZSm1KMklTZHFXNWRTY2pqc01ENEVPMkJXNHE0VmFwUjg5YkVT?=
 =?utf-8?B?VkJsMXVNd3JxOWFFa0RoSGs1bVZGVUtUeTNFSTJzZit3cm55eFQ3SmNDOXFm?=
 =?utf-8?B?N3p1dUNHbUl0VnhhN1RFWnJKMmthYVF5V3p6R0NCYmRoL1QraHF2WTVhZ0sx?=
 =?utf-8?B?QmRSK21sb2p0YWtWR081Y0ppaHc3NndoZ3R4MlVDTi96aDBSOHJpcHptTG9E?=
 =?utf-8?B?Ykd1VFpEeHJGODQyWmY1ZzRJdnRuTWZXaFRWMVVpaUt5alAyWTcxSlREL0dT?=
 =?utf-8?B?NTRVWHozeTJ4T0h4WmFqN214TEZQUmUyU0QzcGNUOHY3bE8yR09uRm4rSzB2?=
 =?utf-8?B?ZjhoVi9uRUN2RkRuaThuMi9TekJyNHJKcTljK1RwYVQ3OHkzbjRuU0VUSGpj?=
 =?utf-8?B?TllTNlMrU0tWZ2l5RkZMNkNqdHpHcnF4RVE1T0FubTVzNmR5YTVnUzN0NmRC?=
 =?utf-8?B?ZWZFTGZtVk9WeXdyU09HZmVXVy9DdEJzMnRzUGpYd2E3cVhQY1hlWnM4WUxk?=
 =?utf-8?B?ZmgvVVhFOS9xSzV3VHVQSHYyWkZNempVQThPTm14dWdKSFlSOWpBVDhMK0xC?=
 =?utf-8?B?U21PL1RQNzlNSlFqbFpZakxKTk1XdWE4Ny9Yc1JpUDAzZUY0RDc0Z0EyQ2NY?=
 =?utf-8?B?VlRNeUxiMnVZLzFpQVVoTzlmeHg5OFVQR0srUXQ5bk94TVNtVmg4TGc2ZHJp?=
 =?utf-8?B?NEovN0pVam9pVElmT0NnMTBDN3praSswd294KzNmN0pQbWNEcXVUekR1QkxB?=
 =?utf-8?B?SmUxNnRVd3I3ejNMZmdLSG0yV3dQYU54Z0E5ckRvcjFEYSthZVVjTFNDZENo?=
 =?utf-8?B?UUs3OWRTZmJVV0RoUUlucHZpNmR2dERWZkYwL05ieElOSVJiMEZRbytndUd5?=
 =?utf-8?B?RHd4L2FxNmZacWRSY0NKQ0JpbWxldm96UkEyWitLV2VGdVJFMzN1V1c3STdq?=
 =?utf-8?B?K2EyanRmRUt5NnFNNHpRdz09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <A81FCB9D40E65A4084EF80BD6CE7990E@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 69355542-7505-4d49-52a5-08d98d4206f0
X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Oct 2021 05:34:57.2331
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: bB2ShlEhreycuxgfSVMZWJHsgO/Txxi5we/QB1for21y8QNuDSUVisdgrnNBSIZyYI72zOGHKnj5SNjrpbzo1u0fuRDd4XxO1sR2wLK7h4yOo7f83PWtOQ1uNOZUC3Zi
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0302MB2768
X-Proofpoint-ORIG-GUID: B3H6BzW-RcM_2GaWpENtVqyllXMS-3Tu
X-Proofpoint-GUID: B3H6BzW-RcM_2GaWpENtVqyllXMS-3Tu
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475
 definitions=2021-10-12_01,2021-10-11_01,2020-04-07_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 bulkscore=0
 adultscore=0 spamscore=0 clxscore=1015 malwarescore=0 suspectscore=0
 priorityscore=1501 mlxlogscore=999 phishscore=0 impostorscore=0
 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2109230001 definitions=main-2110120030

DQoNCk9uIDExLjEwLjIxIDIyOjI3LCBTdGVmYW5vIFN0YWJlbGxpbmkgd3JvdGU6DQo+IE9uIE1v
biwgMTEgT2N0IDIwMjEsIE9sZWtzYW5kciBBbmRydXNoY2hlbmtvIHdyb3RlOg0KPj4gT24gMTEu
MTAuMjEgMjA6MTUsIEJlcnRyYW5kIE1hcnF1aXMgd3JvdGU6DQo+Pj4gSGkgUm9nZXIsDQo+Pj4N
Cj4+Pj4gT24gMTEgT2N0IDIwMjEsIGF0IDE3OjQzLCBSb2dlciBQYXUgTW9ubsOpIDxyb2dlci5w
YXVAY2l0cml4LmNvbT4gd3JvdGU6DQo+Pj4+DQo+Pj4+IE9uIE1vbiwgT2N0IDExLCAyMDIxIGF0
IDA0OjIwOjE0UE0gKzAwMDAsIE9sZWtzYW5kciBBbmRydXNoY2hlbmtvIHdyb3RlOg0KPj4+Pj4g
T24gMTEuMTAuMjEgMTk6MTIsIEJlcnRyYW5kIE1hcnF1aXMgd3JvdGU6DQo+Pj4+Pj4gSGkgUm9n
ZXIsDQo+Pj4+Pj4NCj4+Pj4+Pj4gT24gMTEgT2N0IDIwMjEsIGF0IDExOjUxLCBSb2dlciBQYXUg
TW9ubsOpIDxyb2dlci5wYXVAY2l0cml4LmNvbT4gd3JvdGU6DQo+Pj4+Pj4+DQo+Pj4+Pj4+IE9u
IFdlZCwgT2N0IDA2LCAyMDIxIGF0IDA2OjQwOjM0UE0gKzAxMDAsIFJhaHVsIFNpbmdoIHdyb3Rl
Og0KPj4+Pj4+Pj4gVGhlIGV4aXN0aW5nIFZQQ0kgc3VwcG9ydCBhdmFpbGFibGUgZm9yIFg4NiBp
cyBhZGFwdGVkIGZvciBBcm0uDQo+Pj4+Pj4+PiBXaGVuIHRoZSBkZXZpY2UgaXMgYWRkZWQgdG8g
WEVOIHZpYSB0aGUgaHlwZXIgY2FsbA0KPj4+Pj4+Pj4g4oCcUEhZU0RFVk9QX3BjaV9kZXZpY2Vf
YWRk4oCdLCBWUENJIGhhbmRsZXIgZm9yIHRoZSBjb25maWcgc3BhY2UNCj4+Pj4+Pj4+IGFjY2Vz
cyBpcyBhZGRlZCB0byB0aGUgWGVuIHRvIGVtdWxhdGUgdGhlIFBDSSBkZXZpY2VzIGNvbmZpZyBz
cGFjZS4NCj4+Pj4+Pj4+DQo+Pj4+Pj4+PiBBIE1NSU8gdHJhcCBoYW5kbGVyIGZvciB0aGUgUENJ
IEVDQU0gc3BhY2UgaXMgcmVnaXN0ZXJlZCBpbiBYRU4NCj4+Pj4+Pj4+IHNvIHRoYXQgd2hlbiBn
dWVzdCBpcyB0cnlpbmcgdG8gYWNjZXNzIHRoZSBQQ0kgY29uZmlnIHNwYWNlLFhFTg0KPj4+Pj4+
Pj4gd2lsbCB0cmFwIHRoZSBhY2Nlc3MgYW5kIGVtdWxhdGUgcmVhZC93cml0ZSB1c2luZyB0aGUg
VlBDSSBhbmQNCj4+Pj4+Pj4+IG5vdCB0aGUgcmVhbCBQQ0kgaGFyZHdhcmUuDQo+Pj4+Pj4+Pg0K
Pj4+Pj4+Pj4gRm9yIERvbTBsZXNzIHN5c3RlbXMgc2Nhbl9wY2lfZGV2aWNlcygpIHdvdWxkIGJl
IHVzZWQgdG8gZGlzY292ZXIgdGhlDQo+Pj4+Pj4+PiBQQ0kgZGV2aWNlIGluIFhFTiBhbmQgVlBD
SSBoYW5kbGVyIHdpbGwgYmUgYWRkZWQgZHVyaW5nIFhFTiBib290cy4NCj4+Pj4+Pj4+DQo+Pj4+
Pj4+PiBTaWduZWQtb2ZmLWJ5OiBSYWh1bCBTaW5naCA8cmFodWwuc2luZ2hAYXJtLmNvbT4NCj4+
Pj4+Pj4+IFJldmlld2VkLWJ5OiBTdGVmYW5vIFN0YWJlbGxpbmkgPHNzdGFiZWxsaW5pQGtlcm5l
bC5vcmc+DQo+Pj4+Pj4+PiAtLS0NCj4+Pj4+Pj4+IENoYW5nZSBpbiB2NToNCj4+Pj4+Pj4+IC0g
QWRkIHBjaV9jbGVhbnVwX21zaShwZGV2KSBpbiBjbGVhbnVwIHBhcnQuDQo+Pj4+Pj4+PiAtIEFk
ZGVkIFJldmlld2VkLWJ5OiBTdGVmYW5vIFN0YWJlbGxpbmkgPHNzdGFiZWxsaW5pQGtlcm5lbC5v
cmc+DQo+Pj4+Pj4+PiBDaGFuZ2UgaW4gdjQ6DQo+Pj4+Pj4+PiAtIE1vdmUgYWRkaXRpb24gb2Yg
WEVOX0RPTUNUTF9DREZfdnBjaSBmbGFnIHRvIHNlcGFyYXRlIHBhdGNoDQo+Pj4+Pj4+PiBDaGFu
Z2UgaW4gdjM6DQo+Pj4+Pj4+PiAtIFVzZSBpc19wY2lfcGFzc3Rocm91Z2hfZW5hYmxlZCgpIGlu
IHBsYWNlIG9mIHBjaV9wYXNzdGhyb3VnaF9lbmFibGVkIHZhcmlhYmxlDQo+Pj4+Pj4+PiAtIFJl
amVjdCBYRU5fRE9NQ1RMX0NERl92cGNpIGZvciB4ODYgaW4gYXJjaF9zYW5pdGlzZV9kb21haW5f
Y29uZmlnKCkNCj4+Pj4+Pj4+IC0gUmVtb3ZlIElTX0VOQUJMRUQoQ09ORklHX0hBU19WUENJKSBm
cm9tIGhhc192cGNpKCkNCj4+Pj4+Pj4+IENoYW5nZSBpbiB2MjoNCj4+Pj4+Pj4+IC0gQWRkIG5l
dyBYRU5fRE9NQ1RMX0NERl92cGNpIGZsYWcNCj4+Pj4+Pj4+IC0gbW9kaWZ5IGhhc192cGNpKCkg
dG8gaW5jbHVkZSBYRU5fRE9NQ1RMX0NERl92cGNpDQo+Pj4+Pj4+PiAtIGVuYWJsZSB2cGNpIHN1
cHBvcnQgd2hlbiBwY2ktcGFzc3Rob3VnaCBvcHRpb24gaXMgZW5hYmxlZC4NCj4+Pj4+Pj4+IC0t
LQ0KPj4+Pj4+Pj4gLS0tDQo+Pj4+Pj4+PiB4ZW4vYXJjaC9hcm0vTWFrZWZpbGUgICAgICAgICB8
ICAgMSArDQo+Pj4+Pj4+PiB4ZW4vYXJjaC9hcm0vZG9tYWluLmMgICAgICAgICB8ICAgNCArKw0K
Pj4+Pj4+Pj4geGVuL2FyY2gvYXJtL2RvbWFpbl9idWlsZC5jICAgfCAgIDMgKw0KPj4+Pj4+Pj4g
eGVuL2FyY2gvYXJtL3ZwY2kuYyAgICAgICAgICAgfCAxMDIgKysrKysrKysrKysrKysrKysrKysr
KysrKysrKysrKysrKw0KPj4+Pj4+Pj4geGVuL2FyY2gvYXJtL3ZwY2kuaCAgICAgICAgICAgfCAg
MzYgKysrKysrKysrKysrDQo+Pj4+Pj4+PiB4ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC9wY2kuYyB8
ICAxOCArKysrKysNCj4+Pj4+Pj4+IHhlbi9pbmNsdWRlL2FzbS1hcm0vZG9tYWluLmggIHwgICA3
ICsrLQ0KPj4+Pj4+Pj4geGVuL2luY2x1ZGUvYXNtLXg4Ni9wY2kuaCAgICAgfCAgIDIgLQ0KPj4+
Pj4+Pj4geGVuL2luY2x1ZGUvcHVibGljL2FyY2gtYXJtLmggfCAgIDcgKysrDQo+Pj4+Pj4+PiB4
ZW4vaW5jbHVkZS94ZW4vcGNpLmggICAgICAgICB8ICAgMiArDQo+Pj4+Pj4+PiAxMCBmaWxlcyBj
aGFuZ2VkLCAxNzkgaW5zZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkNCj4+Pj4+Pj4+IGNyZWF0
ZSBtb2RlIDEwMDY0NCB4ZW4vYXJjaC9hcm0vdnBjaS5jDQo+Pj4+Pj4+PiBjcmVhdGUgbW9kZSAx
MDA2NDQgeGVuL2FyY2gvYXJtL3ZwY2kuaA0KPj4+Pj4+Pj4NCj4+Pj4+Pj4+IGRpZmYgLS1naXQg
YS94ZW4vYXJjaC9hcm0vTWFrZWZpbGUgYi94ZW4vYXJjaC9hcm0vTWFrZWZpbGUNCj4+Pj4+Pj4+
IGluZGV4IDQ0ZDdjYzgxZmEuLmZiOWM5NzZlYTIgMTAwNjQ0DQo+Pj4+Pj4+PiAtLS0gYS94ZW4v
YXJjaC9hcm0vTWFrZWZpbGUNCj4+Pj4+Pj4+ICsrKyBiL3hlbi9hcmNoL2FybS9NYWtlZmlsZQ0K
Pj4+Pj4+Pj4gQEAgLTcsNiArNyw3IEBAIGlmbmVxICgkKENPTkZJR19OT19QTEFUKSx5KQ0KPj4+
Pj4+Pj4gb2JqLXkgKz0gcGxhdGZvcm1zLw0KPj4+Pj4+Pj4gZW5kaWYNCj4+Pj4+Pj4+IG9iai0k
KENPTkZJR19URUUpICs9IHRlZS8NCj4+Pj4+Pj4+ICtvYmotJChDT05GSUdfSEFTX1ZQQ0kpICs9
IHZwY2kubw0KPj4+Pj4+Pj4NCj4+Pj4+Pj4+IG9iai0kKENPTkZJR19IQVNfQUxURVJOQVRJVkUp
ICs9IGFsdGVybmF0aXZlLm8NCj4+Pj4+Pj4+IG9iai15ICs9IGJvb3RmZHQuaW5pdC5vDQo+Pj4+
Pj4+PiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gvYXJtL2RvbWFpbi5jIGIveGVuL2FyY2gvYXJtL2Rv
bWFpbi5jDQo+Pj4+Pj4+PiBpbmRleCAzNjEzOGMxYjJlLi5mYmI1MmY3OGYxIDEwMDY0NA0KPj4+
Pj4+Pj4gLS0tIGEveGVuL2FyY2gvYXJtL2RvbWFpbi5jDQo+Pj4+Pj4+PiArKysgYi94ZW4vYXJj
aC9hcm0vZG9tYWluLmMNCj4+Pj4+Pj4+IEBAIC0zOSw2ICszOSw3IEBADQo+Pj4+Pj4+PiAjaW5j
bHVkZSA8YXNtL3ZnaWMuaD4NCj4+Pj4+Pj4+ICNpbmNsdWRlIDxhc20vdnRpbWVyLmg+DQo+Pj4+
Pj4+Pg0KPj4+Pj4+Pj4gKyNpbmNsdWRlICJ2cGNpLmgiDQo+Pj4+Pj4+PiAjaW5jbHVkZSAidnVh
cnQuaCINCj4+Pj4+Pj4+DQo+Pj4+Pj4+PiBERUZJTkVfUEVSX0NQVShzdHJ1Y3QgdmNwdSAqLCBj
dXJyX3ZjcHUpOw0KPj4+Pj4+Pj4gQEAgLTc2Nyw2ICs3NjgsOSBAQCBpbnQgYXJjaF9kb21haW5f
Y3JlYXRlKHN0cnVjdCBkb21haW4gKmQsDQo+Pj4+Pj4+PiAgICAgICBpZiAoIGlzX2hhcmR3YXJl
X2RvbWFpbihkKSAmJiAocmMgPSBkb21haW5fdnVhcnRfaW5pdChkKSkgKQ0KPj4+Pj4+Pj4gICAg
ICAgICAgIGdvdG8gZmFpbDsNCj4+Pj4+Pj4+DQo+Pj4+Pj4+PiArICAgIGlmICggKHJjID0gZG9t
YWluX3ZwY2lfaW5pdChkKSkgIT0gMCApDQo+Pj4+Pj4+PiArICAgICAgICBnb3RvIGZhaWw7DQo+
Pj4+Pj4+PiArDQo+Pj4+Pj4+PiAgICAgICByZXR1cm4gMDsNCj4+Pj4+Pj4+DQo+Pj4+Pj4+PiBm
YWlsOg0KPj4+Pj4+Pj4gZGlmZiAtLWdpdCBhL3hlbi9hcmNoL2FybS9kb21haW5fYnVpbGQuYyBi
L3hlbi9hcmNoL2FybS9kb21haW5fYnVpbGQuYw0KPj4+Pj4+Pj4gaW5kZXggYzVhZmJlMmUwNS4u
ZjRjODliZGU4YyAxMDA2NDQNCj4+Pj4+Pj4+IC0tLSBhL3hlbi9hcmNoL2FybS9kb21haW5fYnVp
bGQuYw0KPj4+Pj4+Pj4gKysrIGIveGVuL2FyY2gvYXJtL2RvbWFpbl9idWlsZC5jDQo+Pj4+Pj4+
PiBAQCAtMzA1Myw2ICszMDUzLDkgQEAgdm9pZCBfX2luaXQgY3JlYXRlX2RvbTAodm9pZCkNCj4+
Pj4+Pj4+ICAgICAgIGlmICggaW9tbXVfZW5hYmxlZCApDQo+Pj4+Pj4+PiAgICAgICAgICAgZG9t
MF9jZmcuZmxhZ3MgfD0gWEVOX0RPTUNUTF9DREZfaW9tbXU7DQo+Pj4+Pj4+Pg0KPj4+Pj4+Pj4g
KyAgICBpZiAoIGlzX3BjaV9wYXNzdGhyb3VnaF9lbmFibGVkKCkgKQ0KPj4+Pj4+Pj4gKyAgICAg
ICAgZG9tMF9jZmcuZmxhZ3MgfD0gWEVOX0RPTUNUTF9DREZfdnBjaTsNCj4+Pj4+Pj4gSSB0aGlu
ayBJJ20gY29uZnVzZWQgd2l0aCB0aGlzLiBZb3Ugc2VlbSB0byBlbmFibGUgdlBDSSBmb3IgZG9t
MCwgYnV0DQo+Pj4+Pj4+IHRoZW4gZG9tYWluX3ZwY2lfaW5pdCB3aWxsIHNldHVwIHRyYXBzIGZv
ciB0aGUgZ3Vlc3QgdmlydHVhbCBFQ0FNDQo+Pj4+Pj4+IGxheW91dCwgbm90IHRoZSBuYXRpdmUg
b25lIHRoYXQgZG9tMCB3aWxsIGJlIHVzaW5nLg0KPj4+Pj4+IEkgdGhpbmsgYWZ0ZXIgdGhlIGxh
c3QgZGlzY3Vzc2lvbnMsIGl0IHdhcyBkZWNpZGVkIHRvIGFsc28gaW5zdGFsbGVkIHRoZSB2cGNp
DQo+Pj4+Pj4gaGFuZGxlciBmb3IgZG9tMC4gSSB3aWxsIGhhdmUgdG8gbG9vayBpbnRvIHRoaXMg
YW5kIGNvbWUgYmFjayB0byB5b3UuDQo+Pj4+Pj4gQE9sZWtzYW5kcjogQ291bGQgeW91IGNvbW1l
bnQgb24gdGhpcy4NCj4+Pj4+IFllcywgd2UgZG8gdHJhcCBEb20wIGFzIHdlbGwuIFRoZSBEb20w
IHRyYXBzIGFyZSBub3QgaW4gdGhpcyBzZXJpZXMsIGJ1dA0KPj4+Pj4gYXJlIGluIG1pbmUgYXMg
aXQgbmVlZHMgbW9yZSBwcmVwYXJhdG9yeSB3b3JrIGZvciB0aGF0LiBQbGVhc2Ugc2VlIFsxXQ0K
Pj4+PiBUaGVuIEkgZG9uJ3QgdGhpbmsgd2Ugc2hvdWxkIHNldCBYRU5fRE9NQ1RMX0NERl92cGNp
IGZvciBkb20wIGhlcmUsIGl0DQo+Pj4+IHNob3VsZCBpbnN0ZWFkIGJlIGRvbmUgaW4gdGhlIHBh
dGNoIHdoZXJlIGRvbTAgc3VwcG9ydCBpcyBpbnRyb2R1Y2VkLg0KPj4+IE9rIEkgd2lsbCBjaGVj
ayB0byByZW1vdmUgdGhpcyBhbmQgaW5jbHVkZSB0aGUgY2hhbmdlIGluIHY2Lg0KPj4gSnVzdCB0
byBtYWtlIGl0IGNsZWFyOiBkbyB3ZSB3YW50IHRvIHJlbW92ZSB0aGlzIHBpZWNlIGZyb20gdGhp
cyBwYXRjaA0KPj4gYW5kIGluc3RlYWQgaGF2ZSBhIGRlZGljYXRlZCBwYXRjaCBvbiB0b3Agb2Yg
bXkgc2VyaWVzLCBzbyBpdCBpcyBlbmFibGVkDQo+PiByaWdodCBhZnRlciB3ZSBoYXZlIHRoZSBj
b2RlIHRoYXQgc2V0cyB1cCB0aGUgdHJhcCBoYW5kbGVycyBmb3IgRG9tMD8NCj4+IElmIHNvLCB0
aGVuIGRvIHdlIHdhbnQgdGhhdCBwYXRjaCB0byBiZSBjaGFpbmVkIGluIG15IHNlcmllcyBvciBz
ZW50IGFzDQo+PiBhIGZvbGxvdyB1cCByaWdodCBhZnRlciBpdCBzZXBhcmF0ZWx5Pw0KPiBJIHRo
aW5rIHdlIHdhbnQgdG8gcmVtb3ZlIHRoZSBYRU5fRE9NQ1RMX0NERl92cGNpIGNodW5rIGZyb20g
dGhpcyBwYXRjaC4NCj4NCj4gV2hlcmUgZXhhY3RseSBpdCBzaG91bGQgYmUgaW50cm9kdWNlZCwg
SSBhbSBub3Qgc3VyZS4gSSB0aGluayBpdCB3b3VsZA0KPiBiZSBPSyBhcyBhIHNlcGFyYXRlIHNp
bmdsZSBwYXRjaCBhdCB0aGUgZW5kLiBJIGRvZXNuJ3QgaGF2ZSB0byBiZSBwYXJ0DQo+IG9mIHRo
ZSBvdXRzdGFuZGluZyBzZXJpZXMsIGNvbnNpZGVyaW5nIHRoYXQgd2UgYXJlIGFsc28gbWlzc2lu
ZyB0aGUNCj4gcGF0Y2ggdG8gYWRkICJzZWxlY3QgSEFTX1BDSSIgZm9yIEFSTS4NClllcywgbWFr
ZXMgc2Vuc2U=


From xen-devel-bounces@lists.xenproject.org Tue Oct 12 06:00:59 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 06:00:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.206749.362390 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maAqD-0005o4-B8; Tue, 12 Oct 2021 06:00:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 206749.362390; Tue, 12 Oct 2021 06:00:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maAqD-0005nx-7j; Tue, 12 Oct 2021 06:00:45 +0000
Received: by outflank-mailman (input) for mailman id 206749;
 Tue, 12 Oct 2021 06:00:44 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=DBHH=PA=arm.com=Hongda.Deng@srs-us1.protection.inumbo.net>)
 id 1maAqB-0005nr-Vd
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 06:00:44 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com (unknown
 [40.107.20.65]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id bab58cdc-2b21-11ec-8110-12813bfff9fa;
 Tue, 12 Oct 2021 06:00:41 +0000 (UTC)
Received: from DB6PR0501CA0001.eurprd05.prod.outlook.com (2603:10a6:4:8f::11)
 by VI1PR0802MB2558.eurprd08.prod.outlook.com (2603:10a6:800:ae::8)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.19; Tue, 12 Oct
 2021 06:00:30 +0000
Received: from DB5EUR03FT057.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:4:8f:cafe::fa) by DB6PR0501CA0001.outlook.office365.com
 (2603:10a6:4:8f::11) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18 via Frontend
 Transport; Tue, 12 Oct 2021 06:00:30 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT057.mail.protection.outlook.com (10.152.20.235) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4587.18 via Frontend Transport; Tue, 12 Oct 2021 06:00:30 +0000
Received: ("Tessian outbound a8bfe25d7364:v103");
 Tue, 12 Oct 2021 06:00:30 +0000
Received: from 8228f5b911a2.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 72D84EAE-38E6-49C9-8B88-9680A1291EB8.1; 
 Tue, 12 Oct 2021 06:00:24 +0000
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 8228f5b911a2.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Tue, 12 Oct 2021 06:00:24 +0000
Received: from VE1PR08MB5677.eurprd08.prod.outlook.com (2603:10a6:800:1ab::17)
 by VI1PR08MB3455.eurprd08.prod.outlook.com (2603:10a6:803:7c::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.25; Tue, 12 Oct
 2021 06:00:21 +0000
Received: from VE1PR08MB5677.eurprd08.prod.outlook.com
 ([fe80::d810:52a3:dce3:4d06]) by VE1PR08MB5677.eurprd08.prod.outlook.com
 ([fe80::d810:52a3:dce3:4d06%6]) with mapi id 15.20.4587.026; Tue, 12 Oct 2021
 06:00:20 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: bab58cdc-2b21-11ec-8110-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=UQ/SOJZMdpXAB64KPTLVoTiUFV4F8QWzRnxN6r2WL9c=;
 b=B9EnXsMtjEVbbFPBOJh7BV6shUAvTOC/yiBYgebkiHmz6W+8BbuamR62EyYYcMq9OVow2p1rllHg19yw/tEMM0PiCQhEhrMGEWe2LBo+Z6J6UoVNgTa3AgGYKAAN8c+nQB+3gm/oILrDhpzyoBrR4GGMHFLKbFCZMw5rt1A4ArU=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=J/+UA1roMqsdVrpzpEfJxNNlZFuQwXxFana6oeIo1Z8GnBv6cvLDUzTrJxsxYb/QVGi+3HtDjScWMBz8Qa8xE09yEbMt/AUTwc4iZXSm1hJxmpeY6qucn+dcnMBo15HYTHwhwNoxL70SR59VZwXLw3y2/Y9EOuhm/0gSm1tinSaFp/whO2LI/a5Cl1l14CORIhIMsE4UR97NpHoKKrBkOGo5HrzeZ78O7PY/4Sg1Ao9lI1SQLKOxa4jIwB77JHil/CZlakpadx2v/h9CXnhCvrlwjPETKy/lZ6JTknDJSGR5I+Wk+CW0S/x25sUZ7/1MS12TIg7Z6VDRTkCZFoZvmA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=UQ/SOJZMdpXAB64KPTLVoTiUFV4F8QWzRnxN6r2WL9c=;
 b=jMuTXZm9fDorHwkrcd777bcrkFK18/JSAcm64Z9HTp7dg+Lvjkr4lJOaAHnI0XolA7xlOgepG+KlaOBT7qz5z5JHj08GABtxv0XamhHFBO+OWtV2TB/lMcNGg6Gu/jvhrK7OcRaZ6GPQMKlZkhYoZP2EPKJ110xhtFuHj3bZjZCjspTwohnbzvlJyIJPACEGGPKcAcq8BM9E+KeI0SWwgIOCZrpX47sV3iorAg8O+Cz6+dJSwJDobpckEN1wjuP1wh+3NfZ+yw/u/Uoj3wX6u10P8XPx3U57pBPjErMeJZJsj1eLqfF054RMM6b7hxqv5XPTscXw3Jz54fOmW/Iatw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=UQ/SOJZMdpXAB64KPTLVoTiUFV4F8QWzRnxN6r2WL9c=;
 b=B9EnXsMtjEVbbFPBOJh7BV6shUAvTOC/yiBYgebkiHmz6W+8BbuamR62EyYYcMq9OVow2p1rllHg19yw/tEMM0PiCQhEhrMGEWe2LBo+Z6J6UoVNgTa3AgGYKAAN8c+nQB+3gm/oILrDhpzyoBrR4GGMHFLKbFCZMw5rt1A4ArU=
From: Hongda Deng <Hongda.Deng@arm.com>
To: Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	Bertrand Marquis <Bertrand.Marquis@arm.com>, Wei Chen <Wei.Chen@arm.com>
Subject: RE: [PATCH] xen/arm: vgic to ignore GICD ICPENRn registers access
Thread-Topic: [PATCH] xen/arm: vgic to ignore GICD ICPENRn registers access
Thread-Index: AQHXsEJR/bwf5T3s+UClXsOnMpcjEquxXHcAgAC9YACAHOFnsA==
Date: Tue, 12 Oct 2021 06:00:20 +0000
Message-ID:
 <VE1PR08MB56779A21C29E3FE977BF7EE7E6B69@VE1PR08MB5677.eurprd08.prod.outlook.com>
References: <20210923061429.16361-1-Hongda.Deng@arm.com>
 <0b0ede18-b944-8693-dede-616c3386e965@xen.org>
 <alpine.DEB.2.21.2109231348200.17979@sstabellini-ThinkPad-T480s>
In-Reply-To: <alpine.DEB.2.21.2109231348200.17979@sstabellini-ThinkPad-T480s>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: 573175DF71BC404DB7EA184F64FE3B78.0
x-checkrecipientchecked: true
Authentication-Results-Original: kernel.org; dkim=none (message not signed)
 header.d=none;kernel.org; dmarc=none action=none header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: 58d3e0e2-8fd2-493e-bbf1-08d98d4598ac
x-ms-traffictypediagnostic: VI1PR08MB3455:|VI1PR0802MB2558:
x-ms-exchange-transport-forked: True
X-Microsoft-Antispam-PRVS:
	<VI1PR0802MB25588D252A0133D2C1BFE550E6B69@VI1PR0802MB2558.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:6790;OLM:6790;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 HnoiPJhWEAlnO/ll/kgEfq14O5MgfEcVfczyI7o05nyIoUg8lKudvan+Mshv5J4jX7vzJ885BRVZjeskN+FofZ/Z2q90rd1vzsnFNFYzU4oKZbC8FZEFn5YDZlSpmgblr5pb6VB26cErvR8ifJsbFEgIqXCvlxVjdOeywLr79q6JkqjUth7+c83xbgzEhCK0vPuzgluZ5Gjgtzj3hNB5pkq7x5hh4A5AoYc5awFKnZfVKvtrYkZGi9WRsV/cBc694zUTOUD7Qg774ND2N8ZusiqHWKHEZMFLW/4L1VQAqCO1kjN61J3CppncYgVcI0yWBZdP0TWSXwNPTaQadlh568x/oCyBu3vXk30Q07aYuQiTmK4+mNkKZ5dhd7tWI2UgVIisz74ZcbrLfDFpddC5m3xcvN4KkB9lyWm0u1hsxxqBiTznqLlg9hjT6GW0m+iCo9CA/73stLIUP15FzBWNRmTlNqW/4MhkPCSE1FZ1h/MSFDNx3aR9+cYo3kgjOFlO7PxdQvh6cw3NYhMiy1ILZJ0NNJ27UyYFnmNBMVI9qRW2tJpyZv/GJe+RXpAyQcZIzg0vq0w0tpp4tD+wMNaclcdPzXPje08I1RwGdueMbSNOQS1W5nAXMVGooxCYZUMbPpU6g0x4cpkGQmb9IxYc2q6+awBG+/Ifmh6sIZUAIRQIte0JlB7U2GMoVxI2a/H4bNWmHepIRI6wLJwEHQ7tt09ZQWXlq+sl1+506PXOBE3+toMgl/LMoEg/A+Y2owFjEoIO1QgEruCzd8AK4hlCByFRRQJTOead7U77OvPz7EA=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR08MB5677.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(38100700002)(508600001)(8936002)(66556008)(55016002)(66476007)(5660300002)(122000001)(54906003)(6506007)(83380400001)(9686003)(66446008)(76116006)(966005)(66946007)(110136005)(7696005)(64756008)(53546011)(52536014)(33656002)(38070700005)(2906002)(8676002)(316002)(4326008)(86362001)(186003)(26005)(71200400001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="iso-2022-jp"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3455
Original-Authentication-Results: kernel.org; dkim=none (message not signed)
 header.d=none;kernel.org; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT057.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	aa1905b1-7a1a-4270-ec5a-08d98d4592d8
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	a5oKBta59CO9nNVwkneJD2taS85wjV769HUIp5mnOeQzxaf6sBkXbQYFKpYSHFS27mWFhcJxhFXwl5X6gZ9h9scqRQSZZX84JsjicIdICP8+2HLuQHeUjf45fQQZjUK2QvazmOFImbx8fK+Lx2AjQzXr0Xp7lL/LUnbGRYPzpVuiedKT1BVgEzUqMhXZPVlMYFtWcgLga/OBHqtClS5RQNRND1SnELuFjdrl3xjSDcTr6AUq3kMyHpc4TQHK6R/hBdAUVS5UMPCkAbAIUVwHYxliO5cApaD+zX82eI/mIQKV8SognedQg6uwoLDje0OKoXbxnZ4q+alKSkMuV143Hgz5JkyHosaQz/RlXcybz2v6pkCLib9Mlq0JMd3nfPCRvjDofjq0muxqpfEUqxVwnEtOSQ72Uqj1ZAtVcgztirwmI2NO8XydR3gZtmHTGoKDR3xx8rW1fRKqyy1CP3Lr5+V1lFvIQxBBrMAJVxmk2bmiqi8pggsXBZbnJxQtUbuXN0aZxk1OMyfQBZQeqeGXvw4rn1NnRS+FotNMNvLrEFO81VpU46DeUu95XhrndemCjtofOPIK2f6srJLdNSbprnsWf+Ogy9fMF/a5BA8bcDds+ExBcaB6EREZWXvG9dQN+evVbfBL8m3f+oqA2Nhr+W4EFziKxZdi6KNiCi56biFPTvUdFfiOweKvDAuFDN+Ym2f6UfZId2Wn/KiqubraE8QSF0MtAhxjfruXqo7FCXeLH9s5Asy6DnOk9/A/oX7ICciS7+t4fpWMzMaJS0omnIHV+7/wcAwCH0TiMNnOWzw=
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(83380400001)(8936002)(336012)(70586007)(82310400003)(8676002)(186003)(70206006)(2906002)(86362001)(316002)(47076005)(5660300002)(55016002)(81166007)(356005)(966005)(36860700001)(54906003)(508600001)(53546011)(6506007)(4326008)(33656002)(9686003)(26005)(110136005)(52536014)(7696005);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2021 06:00:30.3262
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 58d3e0e2-8fd2-493e-bbf1-08d98d4598ac
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT057.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0802MB2558

Hi,

Thanks for your great and detailed advice, I did some investigations about =
vgic especially inflight_irqs in the last few days.

> -----Original Message-----
> From: Stefano Stabellini <sstabellini@kernel.org>
> Sent: 2021=1B$BG/=1B(B9=1B$B7n=1B(B24=1B$BF|=1B(B 4:54
> To: Julien Grall <julien@xen.org>
> Cc: Hongda Deng <Hongda.Deng@arm.com>; xen-devel@lists.xenproject.org;
> sstabellini@kernel.org; Bertrand Marquis <Bertrand.Marquis@arm.com>; Wei
> Chen <Wei.Chen@arm.com>
> Subject: Re: [PATCH] xen/arm: vgic to ignore GICD ICPENRn registers acces=
s
>=20
> On Thu, 23 Sep 2021, Julien Grall wrote:
> > Hi,
> >
> > On 23/09/2021 11:14, Hongda Deng wrote:
> > > Currently, Xen will return IO unhandled when guests access GICD ICPEN=
Rn
> > > registers. This will raise a data abort inside guest. For Linux Guest=
,
> > > these virtual registers will not be accessed. But for Zephyr, in its
> > > GIC initilization code, these virtual registers will be accessed. And
> > > zephyr guest will get an IO dataabort in initilization stage and ente=
r
> >
> > s/dataabort/data abort/
> > s/initilization/initialization/
> >

Ack.

> > > fatal error. Emulating ICPENDR is not easy with the existing vGIC, so
> > > we currently ignore these virtual registers access and print a messag=
e
> > > about whether they are already pending instead of returning unhandled=
.
> > > More details can be found at [1].
> > >
> > > [1] https://lists.xenproject.org/archives/html/xen-devel/2021-09/
> > > msg00744.html
> > >
> > > Signed-off-by: Hongda Deng <hongda.deng@arm.com>
> > > ---
> > >   xen/arch/arm/vgic-v2.c     | 10 +++++++---
> > >   xen/arch/arm/vgic-v3.c     | 29 +++++++++++++++++------------
> > >   xen/arch/arm/vgic.c        | 37 +++++++++++++++++++++++++++++++++++=
++
> > >   xen/include/asm-arm/vgic.h |  2 ++
> > >   4 files changed, 63 insertions(+), 15 deletions(-)
> > >
> > > diff --git a/xen/arch/arm/vgic-v2.c b/xen/arch/arm/vgic-v2.c
> > > index b2da886adc..644c62757c 100644
> > > --- a/xen/arch/arm/vgic-v2.c
> > > +++ b/xen/arch/arm/vgic-v2.c
> > > @@ -481,10 +481,14 @@ static int vgic_v2_distr_mmio_write(struct vcpu=
 *v,
> > > mmio_info_t *info,
> > >         case VRANGE32(GICD_ICPENDR, GICD_ICPENDRN):
> > >           if ( dabt.size !=3D DABT_WORD ) goto bad_width;
> > > +        rank =3D vgic_rank_offset(v, 1, gicd_reg - GICD_ICPENDR, DAB=
T_WORD);
> > > +        if ( rank =3D=3D NULL ) goto write_ignore;
> >
> >
> >
> > > +
> > >           printk(XENLOG_G_ERR
> > > -               "%pv: vGICD: unhandled word write %#"PRIregister" to
> > > ICPENDR%d\n",
> > > -               v, r, gicd_reg - GICD_ICPENDR);
> > > -        return 0;
> > > +               "%pv: vGICD: unhandled word write %#"PRIregister" to
> > > ICPENDR%d, and current pending state is: %s\n",
> > > +               v, r, gicd_reg - GICD_ICPENDR,
> > > +               vgic_get_irqs_pending(v, r, rank->index) ? "on" : "of=
f");
> >
> > Each register contain the information for multiple pending interrupts. =
So it
> > is a bit confusing to say whether the state is on/off. Instead, it woul=
d be
> > better to state which interrupt is pending.
> >
> > Also, I would rather avoid printing a message if there are no interrupt=
s
> > pending because there are no issues if this is happening.

I will fix it in the next version patch.

> >
> > > +        goto write_ignore_32;
> > >         case VRANGE32(GICD_ISACTIVER, GICD_ISACTIVERN):
> > >           if ( dabt.size !=3D DABT_WORD ) goto bad_width;
> > > diff --git a/xen/arch/arm/vgic-v3.c b/xen/arch/arm/vgic-v3.c
> > > index cb5a70c42e..c94e33ff4f 100644
> > > --- a/xen/arch/arm/vgic-v3.c
> > > +++ b/xen/arch/arm/vgic-v3.c
> > > @@ -817,10 +817,14 @@ static int
> __vgic_v3_distr_common_mmio_write(const
> > > char *name, struct vcpu *v,
> > >         case VRANGE32(GICD_ICPENDR, GICD_ICPENDRN):
> > >           if ( dabt.size !=3D DABT_WORD ) goto bad_width;
> > > +        rank =3D vgic_rank_offset(v, 1, reg - GICD_ICPENDR, DABT_WOR=
D);
> > > +        if ( rank =3D=3D NULL ) goto write_ignore;
> > > +
> > >           printk(XENLOG_G_ERR
> > > -               "%pv: %s: unhandled word write %#"PRIregister" to
> > > ICPENDR%d\n",
> > > -               v, name, r, reg - GICD_ICPENDR);
> > > -        return 0;
> > > +               "%pv: %s: unhandled word write %#"PRIregister" to ICP=
ENDR%d,
> > > and current pending state is: %s\n",
> > > +               v, name, r, reg - GICD_ICPENDR,
> > > +               vgic_get_irqs_pending(v, r, rank->index) ? "on" : "of=
f");
> > > +        goto write_ignore_32;
> > >         case VRANGE32(GICD_ISACTIVER, GICD_ISACTIVERN):
> > >           if ( dabt.size !=3D DABT_WORD ) goto bad_width;
> > > @@ -978,19 +982,20 @@ static int vgic_v3_rdistr_sgi_mmio_write(struct
> vcpu
> > > *v, mmio_info_t *info,
> > >       case VREG32(GICR_ICFGR1):
> > >       case VRANGE32(GICR_IPRIORITYR0, GICR_IPRIORITYR7):
> > >       case VREG32(GICR_ISPENDR0):
> > > -         /*
> > > -          * Above registers offset are common with GICD.
> > > -          * So handle common with GICD handling
> > > -          */
> > > +        /*
> > > +         * Above registers offset are common with GICD.
> > > +         * So handle common with GICD handling
> > > +         */
> > >           return __vgic_v3_distr_common_mmio_write("vGICR: SGI", v,
> > >                                                    info, gicr_reg, r)=
;
> > >         case VREG32(GICR_ICPENDR0):
> > > -        if ( dabt.size !=3D DABT_WORD ) goto bad_width;
> > > -        printk(XENLOG_G_ERR
> > > -               "%pv: vGICR: SGI: unhandled word write %#"PRIregister=
" to
> > > ICPENDR0\n",
> > > -               v, r);
> > > -        return 0;
> > > +        /*
> > > +         * Above registers offset are common with GICD.
> > > +         * So handle common with GICD handling
> > > +         */
> > > +        return __vgic_v3_distr_common_mmio_write("vGICR: SGI", v,
> > > +                                                 info, gicr_reg, r);
> > >         case VREG32(GICR_IGRPMODR0):
> > >           /* We do not implement security extensions for guests, writ=
e
> > > ignore */
> > > diff --git a/xen/arch/arm/vgic.c b/xen/arch/arm/vgic.c
> > > index 8f9400a519..29a1aa5056 100644
> > > --- a/xen/arch/arm/vgic.c
> > > +++ b/xen/arch/arm/vgic.c
> > > @@ -470,6 +470,43 @@ void vgic_set_irqs_pending(struct vcpu *v, uint3=
2_t
> r,
> > > unsigned int rank)
> > >       }
> > >   }
> > >   +bool vgic_get_irqs_pending(struct vcpu *v, uint32_t r, unsigned in=
t rank)
> > > +{
> > > +    const unsigned long mask =3D r;
> > > +    unsigned int i;
> > > +    /* The first rank is always per-vCPU */
> > > +    bool private =3D rank =3D=3D 0;
> > > +    bool is_pending =3D false;
> > > +
> > > +    /* LPIs status will never be retrieved via this function */
> > > +    ASSERT(!is_lpi(32 * rank + 31));
> > > +
> > > +    for_each_set_bit( i, &mask, 32 )
> > > +    {
> > > +        unsigned int irq =3D i + 32 * rank;
> > > +
> > > +        if ( !private )
> >
> > It is not clear to me why you not handling PPIs/SGIs and ...
> >
> > > +        {
> > > +            struct pending_irq *p =3D spi_to_pending(v->domain, irq)=
;
> > > +
> > > +            if ( p->desc !=3D NULL )
> >
> > ... emulated SPIs (e.g. PL011).
> >
> > > +            {
> > > +                unsigned long flags;
> > > +
> > > +                spin_lock_irqsave(&p->desc->lock, flags);
> > > +                is_pending =3D gic_read_pending_state(p->desc);
> > > +                spin_unlock_irqrestore(&p->desc->lock, flags);
> >
> > What you are reading here is the pending state from the HW. This is not=
 the
> > same as the pending state from the VM PoV. In fact, in the most common =
case,
> > the interrupt will be pending from the VM PoV, but simply active from t=
he HW
> > PoV (it is deactivated once the interrupt has been handled by the guest=
).
> >
> > I think what you want to check is whether the flag GIC_IRQ_GUEST_QUEUED
> is set
> > in p->status (Stefano ?).
>=20
> Yeah, that's right. In fact, there is no need for checking the hardware
> registers. You can just go through the inflight_irqs list and print all
> of them (the list is sync on hyp entry on the cpu you are running on,
> not the others of course).
>=20
>=20
> > This is technically still a bit racy as Xen may still think the interru=
pt is
> > pending while the it may be actually active in the guest. AFAIK, the ot=
her way
> > around (i.e. not pending in Xen but pending in the guest) cannot happen=
.
> >
> > Anyway, this is just a message, so it is still better than crashing :).
>=20
> +1

Thanks again for your advice.=20
Based on that, I wrote a new patch to go through vcpu->arch.vgic.inflight_i=
rqs to check the pending
states and print them if there are in the next version patch. I will send i=
t for review later.

Cheers,
Hongda



From xen-devel-bounces@lists.xenproject.org Tue Oct 12 06:09:04 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 06:09:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.206747.362401 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maAyD-0006Wa-5H; Tue, 12 Oct 2021 06:09:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 206747.362401; Tue, 12 Oct 2021 06:09:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maAyD-0006WT-1o; Tue, 12 Oct 2021 06:09:01 +0000
Received: by outflank-mailman (input) for mailman id 206747;
 Tue, 12 Oct 2021 05:37:37 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=5yXa=PA=oderland.se=josef@srs-us1.protection.inumbo.net>)
 id 1maATp-0003Db-Qg
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 05:37:37 +0000
Received: from office.oderland.com (unknown [91.201.60.5])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 8048c378-2b1e-11ec-8110-12813bfff9fa;
 Tue, 12 Oct 2021 05:37:34 +0000 (UTC)
Received: from [193.180.18.161] (port=33226 helo=[10.137.0.14])
 by office.oderland.com with esmtpsa (TLS1.2) tls
 TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2)
 (envelope-from <josef@oderland.se>)
 id 1maATl-009h3S-Qb; Tue, 12 Oct 2021 07:37:33 +0200
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8048c378-2b1e-11ec-8110-12813bfff9fa
Message-ID: <ef163327-f965-09f8-4396-2c1c4e689a6d@oderland.se>
Date: Tue, 12 Oct 2021 07:37:30 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:93.0) Gecko/20100101
 Thunderbird/93.0
Content-Language: en-US
From: Josef Johansson <josef@oderland.se>
To: tglx@linutronix.de
Cc: maz@kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
 xen-devel@lists.xenproject.org
References: <CALjTZvbzYfBuLB+H=fj2J+9=DxjQ2Uqcy0if_PvmJ-nU-qEgkg@mail.gmail.com>
 <b023adf9-e21c-59ac-de49-57915c8cede8@oderland.se>
 <c9218eb4-9fc1-28f4-d053-895bab0473d4@oderland.se>
Subject: Re: [REGRESSION][BISECTED] 5.15-rc1: Broken AHCI on NVIDIA ION
 (MCP79)
In-Reply-To: <c9218eb4-9fc1-28f4-d053-895bab0473d4@oderland.se>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-AntiAbuse: This header was added to track abuse, please include it with any abuse report
X-AntiAbuse: Primary Hostname - office.oderland.com
X-AntiAbuse: Original Domain - lists.xenproject.org
X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12]
X-AntiAbuse: Sender Address Domain - oderland.se
X-Get-Message-Sender-Via: office.oderland.com: authenticated_id: josjoh@oderland.se
X-Authenticated-Sender: office.oderland.com: josjoh@oderland.se

On 10/11/21 21:34, Josef Johansson wrote:
> On 10/11/21 20:47, Josef Johansson wrote:
>> Hi,
>>
>> I've got a late regression to this commit as well, but in the GPU area.
>> The problem arises when booting it as XEN dom0.
>> My hardware is Lenovo P14s Gen1 AMD Ryzen 7 Pro 4750U.
>>
>> I'm a bit lost myself, and could use some hints how to fix it.
>> I should note that this mainly happens when a modeset is done (i think).
>> If I wait for 5 minutes the lock eventually releases, but I switch in an
>> out between X
>> and console it locks again.
>>
>> kernel: ------------[ cut here ]------------
>> kernel: WARNING: CPU: 6 PID: 3754 at
>> drivers/gpu/drm/amd/amdgpu/../display/amdgp
>> u_dm/amdgpu_dm.c:8630 amdgpu_dm_commit_planes+0x9b4/0x9c0 [amdgpu]
>> kernel: Modules linked in: nf_tables nfnetlink vfat fat intel_rapl_msr
>> wmi_bmof
>> intel_rapl_common pcspkr joydev uvcvideo k10temp sp5100_tco
>> videobuf2_vmalloc vi
>> deobuf2_memops i2c_piix4 videobuf2_v4l2 videobuf2_common videodev mc
>> iwlwifi thi
>> nkpad_acpi platform_profile ipmi_devintf ledtrig_audio ucsi_acpi
>> cfg80211 ipmi_m
>> sghandler r8169 snd typec_ucsi soundcore typec rfkill wmi video amd_pmc
>> i2c_scmi
>>  fuse xenfs ip_tables dm_thin_pool dm_persistent_data dm_bio_prison
>> dm_crypt tru
>> sted asn1_encoder hid_multitouch amdgpu crct10dif_pclmul iommu_v2
>> crc32_pclmul c
>> rc32c_intel gpu_sched i2c_algo_bit drm_ttm_helper ttm drm_kms_helper ccp
>> cec gha
>> sh_clmulni_intel sdhci_pci xhci_pci xhci_pci_renesas serio_raw cqhci drm
>> sdhci x
>> hci_hcd mmc_core nvme ehci_pci ehci_hcd nvme_core xen_acpi_processor
>> xen_privcmd
>>  xen_pciback xen_blkback xen_gntalloc xen_gntdev xen_evtchn uinput
>> kernel: CPU: 6 PID: 3754 Comm: Xorg Tainted: G        W        
>> 5.15.0-1.fc32.qu
>> bes.x86_64 #1
>> kernel: Hardware name: LENOVO 20Y1S02400/20Y1S02400, BIOS R1BET61W(1.30
>> ) 12/21/
>> 2020
>> kernel: RIP: e030:amdgpu_dm_commit_planes+0x9b4/0x9c0 [amdgpu]
>> kernel: Code: 8b 45 b0 48 c7 c7 4b fc 90 c0 4c 89 55 88 8b b0 f0 03 00
>> 00 e8 6d
>> cb ca ff 4c 8b 55 88 0f b6 55 ab 49 8b 72 08 e9 2b fa ff ff <0f> 0b e9
>> fa fe ff
>> ff e8 40 2f 6e c1 0f 1f 44 00 00 55 b9 27 00 00
>> kernel: RSP: e02b:ffffc90042d93638 EFLAGS: 00010002
>> kernel: RAX: ffff888110840210 RBX: 00000000000083c1 RCX: 0000000000000466
>> kernel: RDX: 0000000000000001 RSI: 0000000000000204 RDI: ffff888110840170
>> kernel: RBP: ffffc90042d936f8 R08: 0000000000000002 R09: 0000000000000001
>> kernel: R10: 0000000000000000 R11: ffff88810cb2e118 R12: ffff888110840210
>> kernel: R13: ffff88810cb2e000 R14: ffff888103d50400 R15: ffff888103bb2c00
>> kernel: FS:  0000718c6de4da40(0000) GS:ffff888140780000(0000)
>> knlGS:000000000000
>> 0000
>> kernel: CS:  10000e030 DS: 0000 ES: 0000 CR0: 0000000080050033
>> kernel: CR2: 0000726ada294000 CR3: 0000000103f0e000 CR4: 0000000000050660
>> kernel: Call Trace:
>> kernel:  amdgpu_dm_atomic_commit_tail+0xc3e/0x1360 [amdgpu]
>> kernel:  commit_tail+0x94/0x130 [drm_kms_helper]
>> kernel:  drm_atomic_helper_commit+0x113/0x140 [drm_kms_helper]
>> kernel:  drm_client_modeset_commit_atomic+0x1fc/0x240 [drm]
>> kernel:  drm_client_modeset_commit_locked+0x53/0x80 [drm]
>> kernel:  drm_fb_helper_pan_display+0xdc/0x210 [drm_kms_helper]
>> kernel:  fb_pan_display+0x83/0x100
>> kernel:  fb_set_var+0x200/0x3b0
>> kernel:  fbcon_blank+0x186/0x280
>> kernel:  do_unblank_screen+0xaa/0x150
>> kernel:  complete_change_console+0x54/0x120
>> kernel:  vt_ioctl+0x31d/0x5f0
>> kernel:  tty_ioctl+0x312/0x780
>> kernel:  __x64_sys_ioctl+0x83/0xb0
>> kernel:  do_syscall_64+0x3b/0x90
>> kernel:  entry_SYSCALL_64_after_hwframe+0x44/0xae
>> kernel: RIP: 0033:0x718c6e33217b
>> kernel: Code: 0f 1e fa 48 8b 05 1d ad 0c 00 64 c7 00 26 00 00 00 48 c7
>> c0 ff ff
>> ff ff c3 66 0f 1f 44 00 00 f3 0f 1e fa b8 10 00 00 00 0f 05 <48> 3d 01
>> f0 ff ff
>> 73 01 c3 48 8b 0d ed ac 0c 00 f7 d8 64 89 01 48
>> kernel: RSP: 002b:00007ffd5c6157c8 EFLAGS: 00000246 ORIG_RAX:
>> 0000000000000010
>> kernel: RAX: ffffffffffffffda RBX: 0000000000000001 RCX: 0000718c6e33217b
>> kernel: RDX: 0000000000000001 RSI: 0000000000005605 RDI: 0000000000000014
>> kernel: RBP: 000057b9b2aa93f4 R08: 0000000000000000 R09: 0000000000000001
>> kernel: R10: fffffffffffff9ce R11: 0000000000000246 R12: 000057b9b2aa94b0
>> kernel: R13: 000057b9b2aa94a0 R14: 000057b9b2aa93f0 R15: 00007ffd5c615844
>> kernel: ---[ end trace 2c3e3998803422cb ]---
>> kernel: ------------[ cut here ]------------
>> kernel: WARNING: CPU: 6 PID: 3754 at
>> drivers/gpu/drm/amd/amdgpu/../display/amdgp
>> u_dm/amdgpu_dm.c:8217 prepare_flip_isr+0x64/0x70 [amdgpu]
>> kernel: Modules linked in: nf_tables nfnetlink vfat fat intel_rapl_msr
>> wmi_bmof
>> intel_rapl_common pcspkr joydev uvcvideo k10temp sp5100_tco
>> videobuf2_vmalloc vi
>> deobuf2_memops i2c_piix4 videobuf2_v4l2 videobuf2_common videodev mc
>> iwlwifi thi
>> nkpad_acpi platform_profile ipmi_devintf ledtrig_audio ucsi_acpi
>> cfg80211 ipmi_m
>> sghandler r8169 snd typec_ucsi soundcore typec rfkill wmi video amd_pmc
>> i2c_scmi
>>  fuse xenfs ip_tables dm_thin_pool dm_persistent_data dm_bio_prison
>> dm_crypt tru
>> sted asn1_encoder hid_multitouch amdgpu crct10dif_pclmul iommu_v2
>> crc32_pclmul c
>> rc32c_intel gpu_sched i2c_algo_bit drm_ttm_helper ttm drm_kms_helper ccp
>> cec gha
>> sh_clmulni_intel sdhci_pci xhci_pci xhci_pci_renesas serio_raw cqhci drm
>> sdhci x
>> hci_hcd mmc_core nvme ehci_pci ehci_hcd nvme_core xen_acpi_processor
>> xen_privcmd
>>  xen_pciback xen_blkback xen_gntalloc xen_gntdev xen_evtchn uinput
>> kernel: CPU: 6 PID: 3754 Comm: Xorg Tainted: G        W        
>> 5.15.0-1.fc32.qu
>> bes.x86_64 #1
>> kernel: Hardware name: LENOVO 20Y1S02400/20Y1S02400, BIOS R1BET61W(1.30
>> ) 12/21/
>> 2020
>> kernel: RIP: e030:prepare_flip_isr+0x64/0x70 [amdgpu]
>> kernel: Code: 00 48 c7 80 38 01 00 00 00 00 00 00 66 90 c3 8b 97 f0 03
>> 00 00 48
>> c7 c6 18 72 8d c0 48 c7 c7 90 5b a7 c0 e9 7e 6e 13 c1 0f 0b <0f> 0b eb
>> b4 0f 1f
>> 84 00 00 00 00 00 0f 1f 44 00 00 41 57 41 56 41
>> kernel: RSP: e02b:ffffc90042d93630 EFLAGS: 00010086
>> kernel: RAX: 0000000000000001 RBX: 00000000000083c1 RCX: 0000000000000466
>> kernel: RDX: 0000000000000001 RSI: 0000000000000204 RDI: ffff88810cb2e000
>> kernel: RBP: ffffc90042d936f8 R08: 0000000000000002 R09: 0000000000000001
>> kernel: R10: 0000000000000000 R11: ffff88810cb2e118 R12: ffff888110840210
>> kernel: R13: ffff88810cb2e000 R14: ffff888103d50400 R15: ffff888103bb2c00
>> kernel: FS:  0000718c6de4da40(0000) GS:ffff888140780000(0000)
>> knlGS:000000000000
>> 0000
>> kernel: CS:  10000e030 DS: 0000 ES: 0000 CR0: 0000000080050033
>> kernel: CR2: 0000726ada294000 CR3: 0000000103f0e000 CR4: 0000000000050660
>> kernel: Call Trace:
>> kernel:  amdgpu_dm_commit_planes+0x8bd/0x9c0 [amdgpu]
>> kernel:  amdgpu_dm_atomic_commit_tail+0xc3e/0x1360 [amdgpu]
>> kernel:  commit_tail+0x94/0x130 [drm_kms_helper]
>> kernel:  drm_atomic_helper_commit+0x113/0x140 [drm_kms_helper]
>> kernel:  drm_client_modeset_commit_atomic+0x1fc/0x240 [drm]
>> kernel:  drm_client_modeset_commit_locked+0x53/0x80 [drm]
>> kernel:  drm_fb_helper_pan_display+0xdc/0x210 [drm_kms_helper]
>> kernel:  fb_pan_display+0x83/0x100
>> kernel:  fb_set_var+0x200/0x3b0
>> kernel:  fbcon_blank+0x186/0x280
>> kernel:  do_unblank_screen+0xaa/0x150
>> kernel:  complete_change_console+0x54/0x120
>> kernel:  vt_ioctl+0x31d/0x5f0
>> kernel:  tty_ioctl+0x312/0x780
>> kernel:  __x64_sys_ioctl+0x83/0xb0
>> kernel:  do_syscall_64+0x3b/0x90
>> kernel:  entry_SYSCALL_64_after_hwframe+0x44/0xae
>> kernel: RIP: 0033:0x718c6e33217b
>> kernel: Code: 0f 1e fa 48 8b 05 1d ad 0c 00 64 c7 00 26 00 00 00 48 c7
>> c0 ff ff
>> ff ff c3 66 0f 1f 44 00 00 f3 0f 1e fa b8 10 00 00 00 0f 05 <48> 3d 01
>> f0 ff ff
>> 73 01 c3 48 8b 0d ed ac 0c 00 f7 d8 64 89 01 48
>> kernel: RSP: 002b:00007ffd5c6157c8 EFLAGS: 00000246 ORIG_RAX:
>> 0000000000000010
>> kernel: RAX: ffffffffffffffda RBX: 0000000000000001 RCX: 0000718c6e33217b
>> kernel: RDX: 0000000000000001 RSI: 0000000000005605 RDI: 0000000000000014
>> kernel: RBP: 000057b9b2aa93f4 R08: 0000000000000000 R09: 0000000000000001
>> kernel: R10: fffffffffffff9ce R11: 0000000000000246 R12: 000057b9b2aa94b0
>> kernel: R13: 000057b9b2aa94a0 R14: 000057b9b2aa93f0 R15: 00007ffd5c615844
>> kernel: ---[ end trace 2c3e3998803422cc ]---
>>
>> Tested with latest tip, reverting this commit makes it all go away, or
>> booting with pci=nomsi.
>>
>> Managed to instruct sysrq to dump locks
>>
>> kernel: sysrq: Show Locks Held
>> kernel: Showing all locks held in the system:
>> kernel: 2 locks held by Xorg/2929:
>> kernel:  #0: ffffc90042ea7d10 (crtc_ww_class_acquire){+.+.}-{0:0}, at:
>> drm_mode_setcrtc+0x158/0x780 [drm]
>> kernel:  #1: ffff888111c00490 (crtc_ww_class_mutex){+.+.}-{3:3}, at:
>> modeset_lock+0x62/0x1c0 [drm]
>> kernel: =============================================
>>
>> More can be read over at freedesktop:
>> https://gitlab.freedesktop.org/drm/amd/-/issues/1715
>>
>>
>>
>> Josef Johansson
>>
>>
>>
> Here is a lspci -vvnn for verbosity, I am trying out Marc's first patch
> now and
> will let you know the result.
>
> 00:00.0 Host bridge [0600]: Advanced Micro Devices, Inc. [AMD] Renoir
> Root Compl
> ex [1022:1630]
>     Subsystem: Lenovo Device [17aa:5081]
>     Control: I/O- Mem- BusMaster- SpecCycle- MemWINV- VGASnoop- ParErr- Step
> ping- SERR- FastB2B- DisINTx-
>     Status: Cap- 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort-
> <MAbort- >SERR- <PERR- INTx-
>
> 00:00.2 IOMMU [0806]: Advanced Micro Devices, Inc. [AMD] Renoir IOMMU
> [1022:1631
> ]
>     Subsystem: Lenovo Device [17aa:5081]
>     Control: I/O- Mem- BusMaster- SpecCycle- MemWINV- VGASnoop- ParErr- Step
> ping- SERR- FastB2B- DisINTx-
>     Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort-
> <MAbort- >SERR- <PERR- INTx-
>     Interrupt: pin A routed to IRQ 255
>     Capabilities: <access denied>
>
> 00:01.0 Host bridge [0600]: Advanced Micro Devices, Inc. [AMD] Renoir
> PCIe Dummy
>  Host Bridge [1022:1632]
>     Control: I/O- Mem- BusMaster- SpecCycle- MemWINV- VGASnoop- ParErr- Step
> ping- SERR- FastB2B- DisINTx-
>     Status: Cap- 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort-
> <MAbort- >SERR- <PERR- INTx-
>
> 00:02.0 Host bridge [0600]: Advanced Micro Devices, Inc. [AMD] Renoir
> PCIe Dummy
>  Host Bridge [1022:1632]
>     Control: I/O- Mem- BusMaster- SpecCycle- MemWINV- VGASnoop- ParErr- Step
> ping- SERR- FastB2B- DisINTx-
>     Status: Cap- 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort-
> <MAbort- >SERR- <PERR- INTx-
>
> 00:02.1 PCI bridge [0604]: Advanced Micro Devices, Inc. [AMD] Renoir
> PCIe GPP Br
> idge [1022:1634] (prog-if 00 [Normal decode])
>     Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Step
> ping- SERR- FastB2B- DisINTx+
>     Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort-
> <MAbort- >SERR- <PERR- INTx-
>     Latency: 0, Cache Line Size: 32 bytes
>     Interrupt: pin ? routed to IRQ 106
>     Bus: primary=00, secondary=01, subordinate=01, sec-latency=0
>     I/O behind bridge: [disabled]
>     Memory behind bridge: fd900000-fd9fffff [size=1M]
>     Prefetchable memory behind bridge: [disabled]
>     Secondary status: 66MHz- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort-
> <MAbort+ <SERR- <PERR-
>     BridgeCtl: Parity- SERR+ NoISA- VGA- VGA16- MAbort- >Reset- FastB2B-
>         PriDiscTmr- SecDiscTmr- DiscTmrStat- DiscTmrSERREn-
>     Capabilities: <access denied>
>     Kernel driver in use: pcieport
>
> 00:02.2 PCI bridge [0604]: Advanced Micro Devices, Inc. [AMD] Renoir
> PCIe GPP Br
> idge [1022:1634] (prog-if 00 [Normal decode])
>     Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Step
> ping- SERR- FastB2B- DisINTx+
>     Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort-
> <MAbort- >SERR- <PERR- INTx-
>     Latency: 0, Cache Line Size: 32 bytes
>     Interrupt: pin ? routed to IRQ 107
>     Bus: primary=00, secondary=02, subordinate=02, sec-latency=0
>     I/O behind bridge: 00003000-00003fff [size=4K]
>     Memory behind bridge: fd800000-fd8fffff [size=1M]
>     Prefetchable memory behind bridge: [disabled]
>     Secondary status: 66MHz- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort-
> <MAbort+ <SERR- <PERR-
>     BridgeCtl: Parity- SERR+ NoISA- VGA- VGA16- MAbort- >Reset- FastB2B-
>         PriDiscTmr- SecDiscTmr- DiscTmrStat- DiscTmrSERREn-
>     Capabilities: <access denied>
>     Kernel driver in use: pcieport
>
> 00:02.3 PCI bridge [0604]: Advanced Micro Devices, Inc. [AMD] Renoir
> PCIe GPP Br
> idge [1022:1634] (prog-if 00 [Normal decode])
>     Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Step
> ping- SERR- FastB2B- DisINTx+
>     Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort-
> <MAbort- >SERR- <PERR- INTx-
>     Latency: 0, Cache Line Size: 32 bytes
>     Interrupt: pin ? routed to IRQ 108
>     Bus: primary=00, secondary=03, subordinate=03, sec-latency=0
>     I/O behind bridge: 00004000-00004fff [size=4K]
>     Memory behind bridge: fd700000-fd7fffff [size=1M]
>     Prefetchable memory behind bridge: 0000000c30000000-0000000c301fffff [si
> ze=2M]
>     Secondary status: 66MHz- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort-
> <MAbort+ <SERR- <PERR-
>     BridgeCtl: Parity- SERR+ NoISA- VGA- VGA16- MAbort- >Reset- FastB2B-
>         PriDiscTmr- SecDiscTmr- DiscTmrStat- DiscTmrSERREn-
>     Capabilities: <access denied>
>     Kernel driver in use: pcieport
>
> 00:02.4 PCI bridge [0604]: Advanced Micro Devices, Inc. [AMD] Renoir
> PCIe GPP Br
> idge [1022:1634] (prog-if 00 [Normal decode])
>     Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Step
> ping- SERR- FastB2B- DisINTx+
>     Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort-
> <MAbort- >SERR- <PERR- INTx-
>     Latency: 0, Cache Line Size: 32 bytes
>     Interrupt: pin ? routed to IRQ 109
>     Bus: primary=00, secondary=04, subordinate=04, sec-latency=0
>     I/O behind bridge: [disabled]
>     Memory behind bridge: fd600000-fd6fffff [size=1M]
>     Prefetchable memory behind bridge: [disabled]
>     Secondary status: 66MHz- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort-
> <MAbort+ <SERR- <PERR-
>     BridgeCtl: Parity- SERR+ NoISA- VGA- VGA16- MAbort- >Reset- FastB2B-
>         PriDiscTmr- SecDiscTmr- DiscTmrStat- DiscTmrSERREn-
>     Capabilities: <access denied>
>     Kernel driver in use: pcieport
>
> 00:02.6 PCI bridge [0604]: Advanced Micro Devices, Inc. [AMD] Renoir
> PCIe GPP Br
> idge [1022:1634] (prog-if 00 [Normal decode])
>     Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Step
> ping- SERR- FastB2B- DisINTx+
>     Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort-
> <MAbort- >SERR- <PERR- INTx-
>     Latency: 0, Cache Line Size: 32 bytes
>     Interrupt: pin ? routed to IRQ 110
>     Bus: primary=00, secondary=05, subordinate=05, sec-latency=0
>     I/O behind bridge: 00002000-00002fff [size=4K]
>     Memory behind bridge: fd500000-fd5fffff [size=1M]
>     Prefetchable memory behind bridge: [disabled]
>     Secondary status: 66MHz- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort-
> <MAbort+ <SERR- <PERR-
>     BridgeCtl: Parity- SERR+ NoISA- VGA- VGA16- MAbort- >Reset- FastB2B-
>         PriDiscTmr- SecDiscTmr- DiscTmrStat- DiscTmrSERREn-
>     Capabilities: <access denied>
>     Kernel driver in use: pcieport
>
> 00:02.7 PCI bridge [0604]: Advanced Micro Devices, Inc. [AMD] Renoir
> PCIe GPP Br
> idge [1022:1634] (prog-if 00 [Normal decode])
>     Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Step
> ping- SERR- FastB2B- DisINTx+
>     Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort-
> <MAbort- >SERR- <PERR- INTx-
>     Latency: 0, Cache Line Size: 32 bytes
>     Interrupt: pin ? routed to IRQ 111
>     Bus: primary=00, secondary=06, subordinate=06, sec-latency=0
>     I/O behind bridge: [disabled]
>     Memory behind bridge: fd400000-fd4fffff [size=1M]
>     Prefetchable memory behind bridge: [disabled]
>     Secondary status: 66MHz- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort-
> <MAbort+ <SERR- <PERR-
>     BridgeCtl: Parity- SERR+ NoISA- VGA- VGA16- MAbort- >Reset- FastB2B-
>         PriDiscTmr- SecDiscTmr- DiscTmrStat- DiscTmrSERREn-
>     Capabilities: <access denied>
>     Kernel driver in use: pcieport
>
> 00:08.0 Host bridge [0600]: Advanced Micro Devices, Inc. [AMD] Renoir
> PCIe Dummy
>  Host Bridge [1022:1632]
>     Control: I/O- Mem- BusMaster- SpecCycle- MemWINV- VGASnoop- ParErr- Step
> ping- SERR- FastB2B- DisINTx-
>     Status: Cap- 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort-
> <MAbort- >SERR- <PERR- INTx-
>
> 00:08.1 PCI bridge [0604]: Advanced Micro Devices, Inc. [AMD] Renoir
> Internal PC
> Ie GPP Bridge to Bus [1022:1635] (prog-if 00 [Normal decode])
>     Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Step
> ping- SERR- FastB2B- DisINTx+
>     Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort-
> <MAbort- >SERR- <PERR- INTx-
>     Latency: 0, Cache Line Size: 32 bytes
>     Interrupt: pin A routed to IRQ 112
>     Bus: primary=00, secondary=07, subordinate=07, sec-latency=0
>     I/O behind bridge: 00001000-00001fff [size=4K]
>     Memory behind bridge: fd000000-fd3fffff [size=4M]
>     Prefetchable memory behind bridge: 0000000c60000000-0000000c701fffff [si
> ze=258M]
>     Secondary status: 66MHz- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort-
> <MAbort- <SERR- <PERR-
>     BridgeCtl: Parity- SERR+ NoISA- VGA- VGA16- MAbort- >Reset- FastB2B-
>         PriDiscTmr- SecDiscTmr- DiscTmrStat- DiscTmrSERREn-
>     Capabilities: <access denied>
>     Kernel driver in use: pcieport
>
> 00:14.0 SMBus [0c05]: Advanced Micro Devices, Inc. [AMD] FCH SMBus
> Controller [1
> 022:790b] (rev 51)
>     Subsystem: Lenovo Device [17aa:5081]
>     Control: I/O- Mem- BusMaster- SpecCycle- MemWINV- VGASnoop- ParErr- Step
> ping- SERR- FastB2B- DisINTx+
>     Status: Cap- 66MHz+ UDF- FastB2B- ParErr- DEVSEL=medium >TAbort- <TAbort
> - <MAbort- >SERR- <PERR- INTx-
>     Kernel driver in use: piix4_smbus
>     Kernel modules: i2c_piix4, sp5100_tco
>
> 00:14.3 ISA bridge [0601]: Advanced Micro Devices, Inc. [AMD] FCH LPC
> Bridge [10
> 22:790e] (rev 51)
>     Subsystem: Lenovo Device [17aa:5081]
>     Control: I/O+ Mem+ BusMaster+ SpecCycle+ MemWINV- VGASnoop- ParErr- Step
> ping- SERR- FastB2B- DisINTx-
>     Status: Cap- 66MHz+ UDF- FastB2B- ParErr- DEVSEL=medium >TAbort- <TAbort
> - <MAbort- >SERR- <PERR- INTx-
>     Latency: 0
>
> 00:18.0 Host bridge [0600]: Advanced Micro Devices, Inc. [AMD] Renoir
> Device 24:
>  Function 0 [1022:1448]
>     Control: I/O- Mem- BusMaster- SpecCycle- MemWINV- VGASnoop- ParErr- Step
> ping- SERR- FastB2B- DisINTx-
>     Status: Cap- 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort-
> <MAbort- >SERR- <PERR- INTx-
>
> 00:18.1 Host bridge [0600]: Advanced Micro Devices, Inc. [AMD] Renoir
> Device 24:
>  Function 1 [1022:1449]
>     Control: I/O- Mem- BusMaster- SpecCycle- MemWINV- VGASnoop- ParErr- Step
> ping- SERR- FastB2B- DisINTx-
>     Status: Cap- 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort-
> <MAbort- >SERR- <PERR- INTx-
>
> 00:18.2 Host bridge [0600]: Advanced Micro Devices, Inc. [AMD] Renoir
> Device 24:
>  Function 2 [1022:144a]
>     Control: I/O- Mem- BusMaster- SpecCycle- MemWINV- VGASnoop- ParErr- Step
> ping- SERR- FastB2B- DisINTx-
>     Status: Cap- 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort-
> <MAbort- >SERR- <PERR- INTx-
>
> 00:18.3 Host bridge [0600]: Advanced Micro Devices, Inc. [AMD] Renoir
> Device 24:
>  Function 3 [1022:144b]
>     Control: I/O- Mem- BusMaster- SpecCycle- MemWINV- VGASnoop- ParErr- Step
> ping- SERR- FastB2B- DisINTx-
>     Status: Cap- 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort-
> <MAbort- >SERR- <PERR- INTx-
>     Kernel driver in use: k10temp
>     Kernel modules: k10temp
>
> 00:18.4 Host bridge [0600]: Advanced Micro Devices, Inc. [AMD] Renoir
> Device 24:
>  Function 4 [1022:144c]
>     Control: I/O- Mem- BusMaster- SpecCycle- MemWINV- VGASnoop- ParErr- Step
> ping- SERR- FastB2B- DisINTx-
>     Status: Cap- 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort-
> <MAbort- >SERR- <PERR- INTx-
>
> 00:18.5 Host bridge [0600]: Advanced Micro Devices, Inc. [AMD] Renoir
> Device 24:
>  Function 5 [1022:144d]
>     Control: I/O- Mem- BusMaster- SpecCycle- MemWINV- VGASnoop- ParErr- Step
> ping- SERR- FastB2B- DisINTx-
>     Status: Cap- 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort-
> <MAbort- >SERR- <PERR- INTx-
>
> 00:18.6 Host bridge [0600]: Advanced Micro Devices, Inc. [AMD] Renoir
> Device 24:
>  Function 6 [1022:144e]
>     Control: I/O- Mem- BusMaster- SpecCycle- MemWINV- VGASnoop- ParErr- Step
> ping- SERR- FastB2B- DisINTx-
>     Status: Cap- 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort-
> <MAbort- >SERR- <PERR- INTx-
>
> 00:18.7 Host bridge [0600]: Advanced Micro Devices, Inc. [AMD] Renoir
> Device 24:
>  Function 7 [1022:144f]
>     Control: I/O- Mem- BusMaster- SpecCycle- MemWINV- VGASnoop- ParErr- Step
> ping- SERR- FastB2B- DisINTx-
>     Status: Cap- 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort-
> <MAbort- >SERR- <PERR- INTx-
>
> 01:00.0 Non-Volatile memory controller [0108]: SK hynix Device
> [1c5c:1639] (prog
> -if 02 [NVM Express])
>     Subsystem: SK hynix Device [1c5c:1639]
>     Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Step
> ping- SERR- FastB2B- DisINTx+
>     Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort-
> <MAbort- >SERR- <PERR- INTx-
>     Latency: 0, Cache Line Size: 32 bytes
>     Interrupt: pin A routed to IRQ 36
>     NUMA node: 0
>     Region 0: Memory at fd900000 (64-bit, non-prefetchable) [size=16K]
>     Region 2: Memory at fd905000 (32-bit, non-prefetchable) [size=4K]
>     Region 3: Memory at fd904000 (32-bit, non-prefetchable) [size=4K]
>     Capabilities: <access denied>
>     Kernel driver in use: nvme
>     Kernel modules: nvme
>
> 02:00.0 Ethernet controller [0200]: Realtek Semiconductor Co., Ltd.
> RTL8111/8168
> /8411 PCI Express Gigabit Ethernet Controller [10ec:8168] (rev 0e)
>     Subsystem: Lenovo Device [17aa:5081]
>     Control: I/O+ Mem+ BusMaster- SpecCycle- MemWINV- VGASnoop- ParErr- Step
> ping- SERR- FastB2B- DisINTx-
>     Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort-
> <MAbort- >SERR- <PERR- INTx-
>     Interrupt: pin A routed to IRQ 40
>     Region 0: I/O ports at 3400 [size=256]
>     Region 2: Memory at fd814000 (64-bit, non-prefetchable) [size=4K]
>     Region 4: Memory at fd800000 (64-bit, non-prefetchable) [size=16K]
>     Capabilities: <access denied>
>     Kernel driver in use: pciback
>     Kernel modules: r8169
>
> 02:00.1 Serial controller [0700]: Realtek Semiconductor Co., Ltd.
> RTL8111xP UART
>  #1 [10ec:816a] (rev 0e) (prog-if 02 [16550])
>     Subsystem: Lenovo Device [17aa:5081]
>     Control: I/O+ Mem+ BusMaster- SpecCycle- MemWINV- VGASnoop- ParErr- Step
> ping- SERR- FastB2B- DisINTx-
>     Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort-
> <MAbort- >SERR- <PERR- INTx-
>     Interrupt: pin B routed to IRQ 41
>     Region 0: I/O ports at 3200 [size=256]
>     Region 2: Memory at fd815000 (64-bit, non-prefetchable) [size=4K]
>     Region 4: Memory at fd804000 (64-bit, non-prefetchable) [size=16K]
>     Capabilities: <access denied>
>     Kernel driver in use: serial
>
> 02:00.2 Serial controller [0700]: Realtek Semiconductor Co., Ltd.
> RTL8111xP UART
>  #2 [10ec:816b] (rev 0e) (prog-if 02 [16550])
>     Subsystem: Lenovo Device [17aa:5081]
>     Control: I/O+ Mem+ BusMaster- SpecCycle- MemWINV- VGASnoop- ParErr- Step
> ping- SERR- FastB2B- DisINTx-
>     Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort-
> <MAbort- >SERR- <PERR- INTx-
>     Interrupt: pin C routed to IRQ 42
>     Region 0: I/O ports at 3100 [size=256]
>     Region 2: Memory at fd816000 (64-bit, non-prefetchable) [size=4K]
>     Region 4: Memory at fd808000 (64-bit, non-prefetchable) [size=16K]
>     Capabilities: <access denied>
>     Kernel driver in use: serial
>
> 02:00.3 IPMI Interface [0c07]: Realtek Semiconductor Co., Ltd. RTL8111xP
> IPMI in
> terface [10ec:816c] (rev 0e) (prog-if 01 [KCS])
>     Subsystem: Lenovo Device [17aa:5081]
>     Control: I/O- Mem- BusMaster- SpecCycle- MemWINV- VGASnoop- ParErr- Step
> ping- SERR- FastB2B- DisINTx-
>     Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort-
> <MAbort- >SERR- <PERR- INTx-
>     Interrupt: pin D routed to IRQ 255
>     Region 0: I/O ports at 3000 [disabled] [size=256]
>     Region 2: Memory at fd817000 (64-bit, non-prefetchable) [disabled] [size
> =4K]
>     Region 4: Memory at fd80c000 (64-bit, non-prefetchable) [disabled] [size
> =16K]
>     Capabilities: <access denied>
>     Kernel modules: ipmi_si
>
> 02:00.4 USB controller [0c03]: Realtek Semiconductor Co., Ltd. RTL811x
> EHCI host
>  controller [10ec:816d] (rev 0e) (prog-if 20 [EHCI])
>     Subsystem: Lenovo Device [17aa:5081]
>     Control: I/O- Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Step
> ping- SERR- FastB2B- DisINTx+
>     Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort-
> <MAbort- >SERR- <PERR- INTx-
>     Latency: 0, Cache Line Size: 32 bytes
>     Interrupt: pin D routed to IRQ 114
>     Region 0: Memory at fd818000 (32-bit, non-prefetchable) [size=4K]
>     Region 2: Memory at fd810000 (64-bit, non-prefetchable) [size=16K]
>     Capabilities: <access denied>
>     Kernel driver in use: ehci-pci
>     Kernel modules: ehci_pci
>
> 03:00.0 Network controller [0280]: Intel Corporation Wi-Fi 6 AX200
> [8086:2723] (
> rev 1a)
>     Subsystem: Intel Corporation Device [8086:0080]
>     Control: I/O- Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Step
> ping- SERR- FastB2B- DisINTx+
>     Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort-
> <MAbort- >SERR- <PERR- INTx-
>     Latency: 0, Cache Line Size: 32 bytes
>     Interrupt: pin A routed to IRQ 44
>     Region 0: Memory at fd700000 (64-bit, non-prefetchable) [size=16K]
>     Capabilities: <access denied>
>     Kernel driver in use: pciback
>     Kernel modules: iwlwifi
>
> 04:00.0 SD Host controller [0805]: Genesys Logic, Inc GL9750 SD Host
> Controller
> [17a0:9750] (rev 01) (prog-if 01)
>     Subsystem: Lenovo Device [17aa:5082]
>     Control: I/O- Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Step
> ping- SERR- FastB2B- DisINTx+
>     Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort-
> <MAbort- >SERR- <PERR- INTx-
>     Latency: 0, Cache Line Size: 32 bytes
>     Interrupt: pin A routed to IRQ 118
>     Region 0: Memory at fd600000 (32-bit, non-prefetchable) [size=4K]
>     Capabilities: <access denied>
>     Kernel driver in use: sdhci-pci
>     Kernel modules: sdhci_pci
>
> 05:00.0 Ethernet controller [0200]: Realtek Semiconductor Co., Ltd.
> RTL8111/8168
> /8411 PCI Express Gigabit Ethernet Controller [10ec:8168] (rev 15)
>     Subsystem: Lenovo Device [17aa:5081]
>     Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Step
> ping- SERR- FastB2B- DisINTx+
>     Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort-
> <MAbort- >SERR- <PERR- INTx-
>     Latency: 0, Cache Line Size: 32 bytes
>     Interrupt: pin A routed to IRQ 46
>     Region 0: I/O ports at 2000 [size=256]
>     Region 2: Memory at fd504000 (64-bit, non-prefetchable) [size=4K]
>     Region 4: Memory at fd500000 (64-bit, non-prefetchable) [size=16K]
>     Capabilities: <access denied>
>     Kernel driver in use: pciback
>     Kernel modules: r8169
>
> 06:00.0 USB controller [0c03]: Renesas Technology Corp. uPD720202 USB
> 3.0 Host C
> ontroller [1912:0015] (rev 02) (prog-if 30 [XHCI])
>     Control: I/O- Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Step
> ping- SERR- FastB2B- DisINTx+
>     Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort-
> <MAbort- >SERR- <PERR- INTx-
>     Latency: 0, Cache Line Size: 32 bytes
>     Interrupt: pin A routed to IRQ 42
>     Region 0: Memory at fd400000 (64-bit, non-prefetchable) [size=8K]
>     Capabilities: <access denied>
>     Kernel driver in use: xhci_hcd
>     Kernel modules: xhci_pci
>
> 07:00.0 VGA compatible controller [0300]: Advanced Micro Devices, Inc.
> [AMD/ATI]
>  Renoir [1002:1636] (rev d1) (prog-if 00 [VGA controller])
>     Subsystem: Lenovo Device [17aa:5099]
>     Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Step
> ping- SERR- FastB2B- DisINTx+
>     Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort+ <TAbort-
> <MAbort- >SERR- <PERR- INTx-
>     Latency: 0, Cache Line Size: 32 bytes
>     Interrupt: pin A routed to IRQ 38
>     Region 0: Memory at c60000000 (64-bit, prefetchable) [size=256M]
>     Region 2: Memory at c70000000 (64-bit, prefetchable) [size=2M]
>     Region 4: I/O ports at 1000 [size=256]
>     Region 5: Memory at fd300000 (32-bit, non-prefetchable) [size=512K]
>     Capabilities: <access denied>
>     Kernel driver in use: amdgpu
>     Kernel modules: amdgpu
>
> 07:00.2 Encryption controller [1080]: Advanced Micro Devices, Inc. [AMD]
> Family
> 17h (Models 10h-1fh) Platform Security Processor [1022:15df]
>     Subsystem: Lenovo Device [17aa:5081]
>     Control: I/O- Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Step
> ping- SERR- FastB2B- DisINTx+
>     Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort+ <TAbort-
> <MAbort- >SERR- <PERR- INTx-
>     Latency: 0, Cache Line Size: 32 bytes
>     Interrupt: pin C routed to IRQ 36
>     Region 2: Memory at fd200000 (32-bit, non-prefetchable) [size=1M]
>     Region 5: Memory at fd380000 (32-bit, non-prefetchable) [size=8K]
>     Capabilities: <access denied>
>     Kernel driver in use: ccp
>     Kernel modules: ccp
>
> 07:00.3 USB controller [0c03]: Advanced Micro Devices, Inc. [AMD] Renoir
> USB 3.1
>  [1022:1639] (prog-if 30 [XHCI])
>     Subsystem: Lenovo Device [17aa:5081]
>     Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Step
> ping- SERR- FastB2B- DisINTx+
>     Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort-
> <MAbort- >SERR- <PERR- INTx-
>     Latency: 0, Cache Line Size: 32 bytes
>     Interrupt: pin D routed to IRQ 37
>     Region 0: Memory at fd000000 (64-bit, non-prefetchable) [size=1M]
>     Capabilities: <access denied>
>     Kernel driver in use: pciback
>     Kernel modules: xhci_pci
>
> 07:00.4 USB controller [0c03]: Advanced Micro Devices, Inc. [AMD] Renoir
> USB 3.1
>  [1022:1639] (prog-if 30 [XHCI])
>     Subsystem: Lenovo Device [17aa:5081]
>     Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Step
> ping- SERR- FastB2B- DisINTx+
>     Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort-
> <MAbort- >SERR- <PERR- INTx-
>     Latency: 0, Cache Line Size: 32 bytes
>     Interrupt: pin A routed to IRQ 38
>     Region 0: Memory at fd100000 (64-bit, non-prefetchable) [size=1M]
>     Capabilities: <access denied>
>     Kernel driver in use: pciback
>     Kernel modules: xhci_pci
>
> Regards
> - Josef

No go sadly, still the same behavior. I guess that Maskable- is a bad
thing here?

CC xen-devel, you guys may have a clue here?



From xen-devel-bounces@lists.xenproject.org Tue Oct 12 06:25:18 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 06:25:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.206766.362411 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maBDt-0000QQ-Jd; Tue, 12 Oct 2021 06:25:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 206766.362411; Tue, 12 Oct 2021 06:25:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maBDt-0000QJ-GT; Tue, 12 Oct 2021 06:25:13 +0000
Received: by outflank-mailman (input) for mailman id 206766;
 Tue, 12 Oct 2021 06:25:12 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=DBHH=PA=arm.com=Hongda.Deng@srs-us1.protection.inumbo.net>)
 id 1maBDs-0000QD-ED
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 06:25:12 +0000
Received: from EUR01-DB5-obe.outbound.protection.outlook.com (unknown
 [40.107.15.55]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id bc608d6d-0264-4bb9-954c-d33cef620ceb;
 Tue, 12 Oct 2021 06:25:09 +0000 (UTC)
Received: from AM7PR03CA0020.eurprd03.prod.outlook.com (2603:10a6:20b:130::30)
 by PR3PR08MB5659.eurprd08.prod.outlook.com (2603:10a6:102:83::7) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.19; Tue, 12 Oct
 2021 06:25:07 +0000
Received: from VE1EUR03FT033.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:130:cafe::49) by AM7PR03CA0020.outlook.office365.com
 (2603:10a6:20b:130::30) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.14 via Frontend
 Transport; Tue, 12 Oct 2021 06:25:06 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT033.mail.protection.outlook.com (10.152.18.147) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4587.18 via Frontend Transport; Tue, 12 Oct 2021 06:25:06 +0000
Received: ("Tessian outbound d5def7722ff7:v103");
 Tue, 12 Oct 2021 06:25:06 +0000
Received: from ea4fc242f4cb.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 8B457C24-88F5-4AC4-BCC8-3935B5889CB1.1; 
 Tue, 12 Oct 2021 06:24:59 +0000
Received: from EUR02-AM5-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id ea4fc242f4cb.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Tue, 12 Oct 2021 06:24:59 +0000
Received: from AM6PR10CA0058.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:209:80::35)
 by AM8PR08MB5746.eurprd08.prod.outlook.com (2603:10a6:20b:1d8::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.19; Tue, 12 Oct
 2021 06:24:56 +0000
Received: from AM5EUR03FT011.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:209:80:cafe::aa) by AM6PR10CA0058.outlook.office365.com
 (2603:10a6:209:80::35) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.24 via Frontend
 Transport; Tue, 12 Oct 2021 06:24:56 +0000
Received: from nebula.arm.com (40.67.248.234) by
 AM5EUR03FT011.mail.protection.outlook.com (10.152.16.152) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.4587.18 via Frontend Transport; Tue, 12 Oct 2021 06:24:55 +0000
Received: from AZ-NEU-EX03.Arm.com (10.251.24.31) by AZ-NEU-EX03.Arm.com
 (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.14; Tue, 12 Oct
 2021 06:25:02 +0000
Received: from hongda-OptiPlex-7070.shanghai.arm.com (10.169.190.17) by
 mail.arm.com (10.251.24.31) with Microsoft SMTP Server id 15.1.2308.14 via
 Frontend Transport; Tue, 12 Oct 2021 06:25:00 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: bc608d6d-0264-4bb9-954c-d33cef620ceb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=yiQbNkgxehEJ/Kbs58zs0bM/XHm9TcEKA9+pvY3XQmM=;
 b=HppvwCbpz3DJjQom08scRu5lWxKK1TEkDojwQlcDi4bim9jSzkBxlwC86Ai9QvXbw4Ct7yQbiLvGNUhMVzF+dWnHdAm2/mb7dIIhq4OiajTLdcw6GhiC9Bb2k8LhCR+Xl17hBv9GnuOcaTz/w+dQoYewb7Ch4uzSnJptvb3UknE=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: c7235164e07cb982
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=DH7zQajXq+ZRrX5fhy5aZNB/RHofn4lcKclQkOc46YWX8jOfC8b+JVmb/QTOcIvXjPFcDhQ4FYLRAyXc5ZOLUfXqoO2J19Qfpmhnt116uSESpIAl2+tjHotYJ6hKnFesdicVPC72Z6VRG068kp7B6g9oWe09ClHDl+K1Lic/KUGU9gHYhXzwwPDbyexPzSwF1Fagt4CWNWuqSez8YY5LOeFObPoaKtdo3kVv/v7r9cIbQNcYLJf+3gMP6I/OcrDMU7EVNegYuXIazARN4Rd0ND1KlcyHMx+8Q0bxL2aeuPOCEq5w/XgW6cuM6tlHRpQzLmqlKdc7n/+ZK9/onPUQsA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=yiQbNkgxehEJ/Kbs58zs0bM/XHm9TcEKA9+pvY3XQmM=;
 b=G3CgCwDUz4US4xYWerCWbeeMrpgLpDMFlwMguMaTPV779I7kQOYSvHAtZLE1YtIapaNIuu3WFzjgIiHbIA7jtNll9tiCDG4wuuIKti7KZKG7n29A9h2X65rooV1H61Hgo66E0e0Icajn5+zIcTxZFIAH5t3Y+jY3VWIIoj7VEfFAGwMesJPu8XhHrdM1ci1Rbqw5eUVePeMOliwkmanjomVF6lNsYrBZN1VUbhsrAUYbFOm0XywWafEVScmPK1fVDFXeDEjURba2BhUKY55IAFHcMaNSZ/PAsIqhTMcPwgAC6TxivWdKl+j6wiwZTP4ma+st5/KIOwvY8Ie/Nj24LA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=yiQbNkgxehEJ/Kbs58zs0bM/XHm9TcEKA9+pvY3XQmM=;
 b=HppvwCbpz3DJjQom08scRu5lWxKK1TEkDojwQlcDi4bim9jSzkBxlwC86Ai9QvXbw4Ct7yQbiLvGNUhMVzF+dWnHdAm2/mb7dIIhq4OiajTLdcw6GhiC9Bb2k8LhCR+Xl17hBv9GnuOcaTz/w+dQoYewb7Ch4uzSnJptvb3UknE=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=pass action=none
 header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 40.67.248.234 as permitted sender) receiver=protection.outlook.com;
 client-ip=40.67.248.234; helo=nebula.arm.com;
From: Hongda Deng <Hongda.Deng@arm.com>
To: <xen-devel@lists.xenproject.org>, <sstabellini@kernel.org>,
	<julien@xen.org>
CC: <Bertrand.Marquis@arm.com>, <Wei.Chen@arm.com>, <Hongda.Deng@arm.com>
Subject: [PATCH v2] xen/arm: vgic to ignore GICD ICPENRn registers access
Date: Tue, 12 Oct 2021 14:24:49 +0800
Message-ID: <20211012062449.30966-1-Hongda.Deng@arm.com>
X-Mailer: git-send-email 2.17.1
MIME-Version: 1.0
Content-Type: text/plain
X-EOPAttributedMessage: 1
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 99273ac2-3d74-4863-b9aa-08d98d4908a5
X-MS-TrafficTypeDiagnostic: AM8PR08MB5746:|PR3PR08MB5659:
X-Microsoft-Antispam-PRVS:
	<PR3PR08MB565994A0678B49E2CAA168F2E6B69@PR3PR08MB5659.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Oob-TLC-OOBClassifiers: OLM:1332;OLM:1332;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 AY6xDQl4wOqYR8/yDOkp7+50z16Lldkq4fkm4QnaeDpUucC+38gA1rZ9O6XCOEq5btHhlA8x5Rp+Pyg7ClMHwd900qozC4mqhQb45NjTRDl5xFv84HRTthd8svmQw3QngxZA/CwJ/aUV/l4uKauTx+poZxSMM2VaqTXUSQOeDLcK30AiJiDxq41b+fpQ2kZbpKghzqPPoRvoE1LhNDqjD665NDNeoj9uSnZTivVBp3R1h9xX4HpzzS+rdDgnJsrTYLjuXGmWYc3wHZukYjDBP/U/ZuOITg+rz0QFxVFnwxejLsXu9sDO/iyai2heGomTJCwEN1YjDQvJSoTTPIzbJaXTRppbLIA1eWi4kME/Huk/ALo5cfAnKnQujd7058egLhHUWFldv8NDHD1RPDHBv3KDrJ98MvszRK5nRA2ebfHoTS3oC7+i8Ri0hFFyct1AEpkKIKAG1PNPxkOIkCJwyhMa6+moIIea0js/DpQihSxkAMaEaYcGjfyWp44KUsWxBOHy2AVpsVL9DlzEugXvChN/xTkjefsOzRnnX6uvQBhBCVlLjVuIF28VGrsOeCmBd2eT3X8s+zZ/9lmzj5apbi4PJwMIpeKtpYKTcEbmeSPf8XsxTAYQRQf827cRNEyCU0OkF4d/3Y0oQdOUlcfk0vxnG3wvHSGmZez1I1gDl/ISOZR/FhCEK3JsBNckJM2ZqEp+klOVdtR1PRhoAcjMslWSY/muPBPKm8G90dhn81jInEuMgw0KlQGEsYeM/HDlD5xB3ky4delIwSaFabUjKmaNzzZnaZp9yjcKvV6M3UiC6sqs2+lr30dcBTFeHX5h
X-Forefront-Antispam-Report-Untrusted:
 CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(186003)(966005)(316002)(54906003)(110136005)(81166007)(7696005)(508600001)(6666004)(356005)(26005)(2906002)(86362001)(47076005)(4326008)(83380400001)(36756003)(8936002)(8676002)(36860700001)(70206006)(70586007)(1076003)(82310400003)(426003)(336012)(2616005)(5660300002)(36900700001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB5746
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT033.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	139193c6-eb4d-4bc3-d8d5-08d98d49023a
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	stqtYa25Cq8a9nCvXInCgEHMR3uzyldPoEuA7uIP9OkSfU8Te/lrTgibQ06FaByWJOGEUEYXsHrVQhJAHVWBuC8NWWtEvq+q0cSgw/qZKtXbICkNeLFUFCfjyGYL0EcYTV9bWQhudP8uQZG53PZJMYyKaEoBvia430P7V2adWX91brdqPupJgsLR50Ms5yGHKD4btCYWE5ReToFUgm27htpiLeNQQMzAo1vAB6YvfiVKYissudyjNCzlXO9ohys/JviwIt/1D/YfIf1MAq7M/U/RJCBN0dLX7HlTZCkXdY0aHDBwfEWBHD5os7p+ZBgpjUWwsBQh5kwDReEBMHWuUMScnaF6nvrP7B9bce5Yo3EPLJaKiEXvFCBOSQ7rM/Immj4nN4ypuhxmBmZUPLgg/6cNnH/Dth6ncXw6CNd62KURru7kzIi6vq6UuUe+G8vtbpdJFjuSPknm7AMn47wI3TffqKJNm3QCqECOQ+itDXK6jd6BEyUy5t6kY7vphRx8tnwCNUQbGO180cnv/kTSROochl0Qz8iY5e8QzZzP+Gy5MIiVhYV4ICcAxpGDedyEKiViguedYNRmG7BD8oFiBwCPPfVJbbkRyRITsVoAvdUvfhTABeKwTkZ897TnprA4liIwp9pHJL1IZ3TJJY3Nvumt/kS04jr/QhmmqhsT+Ekg+tXAPeVb5MvcWKlU7SvKQyJqua4cNCS0SD9WHV/mUCIdWM0aVNdjJG6ter+wTUCieCNrN+QzrlDaxl9MQnglQMrFJx/RQmwbscXJ8ZH6Ow==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(81166007)(70206006)(70586007)(86362001)(36860700001)(36756003)(82310400003)(47076005)(1076003)(8676002)(966005)(426003)(2616005)(8936002)(5660300002)(26005)(2906002)(186003)(508600001)(336012)(7696005)(110136005)(316002)(54906003)(83380400001)(4326008)(6666004);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2021 06:25:06.5775
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 99273ac2-3d74-4863-b9aa-08d98d4908a5
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT033.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR08MB5659

Currently, Xen will return IO unhandled when guests access GICD ICPENRn
registers. This will raise a data abort inside guest. For Linux Guest,
these virtual registers will not be accessed. But for Zephyr, in its
GIC initialization code, these virtual registers will be accessed. And
zephyr guest will get an IO data abort in initilization stage and enter
fatal error. Emulating ICPENDR is not easy with the existing vGIC, so
we currently ignore these virtual registers access and print a message
about whether they are already pending instead of returning unhandled.
More details can be found at [1].

[1] https://lists.xenproject.org/archives/html/xen-devel/2021-09/
msg00744.html

Signed-off-by: Hongda Deng <hongda.deng@arm.com>
---
 xen/arch/arm/vgic-v2.c | 26 +++++++++++++++++++++++++-
 xen/arch/arm/vgic-v3.c | 40 +++++++++++++++++++++++++++++++---------
 2 files changed, 56 insertions(+), 10 deletions(-)

diff --git a/xen/arch/arm/vgic-v2.c b/xen/arch/arm/vgic-v2.c
index b2da886adc..d7ffaeeb65 100644
--- a/xen/arch/arm/vgic-v2.c
+++ b/xen/arch/arm/vgic-v2.c
@@ -480,11 +480,35 @@ static int vgic_v2_distr_mmio_write(struct vcpu *v, mmio_info_t *info,
         return 1;
 
     case VRANGE32(GICD_ICPENDR, GICD_ICPENDRN):
+    {
+        struct pending_irq *iter;
+        unsigned int irq_start;
+        unsigned int irq_end;
+        uint32_t irq_pending = 0;
+
         if ( dabt.size != DABT_WORD ) goto bad_width;
         printk(XENLOG_G_ERR
                "%pv: vGICD: unhandled word write %#"PRIregister" to ICPENDR%d\n",
                v, r, gicd_reg - GICD_ICPENDR);
-        return 0;
+
+        irq_start = (gicd_reg - GICD_ICPENDR) * 32;
+        irq_end = irq_start + 31;
+        /* go through inflight_irqs and print specified pending irqs */
+        list_for_each_entry(iter, &v->arch.vgic.inflight_irqs, inflight)
+        {
+            if ( iter->irq < irq_start || irq_end < iter->irq )
+                continue;
+
+            if ( test_bit(GIC_IRQ_GUEST_QUEUED, &iter->status) )
+                irq_pending = irq_pending | (1 << (iter->irq - irq_start));
+        }
+
+        if ( irq_pending != 0 )
+            printk(XENLOG_G_ERR
+                   "%pv: vGICD: ICPENDR%d=0x%08x\n",
+                   v, gicd_reg - GICD_ICPENDR, irq_pending);
+        goto write_ignore_32;
+    }
 
     case VRANGE32(GICD_ISACTIVER, GICD_ISACTIVERN):
         if ( dabt.size != DABT_WORD ) goto bad_width;
diff --git a/xen/arch/arm/vgic-v3.c b/xen/arch/arm/vgic-v3.c
index cb5a70c42e..243b24e496 100644
--- a/xen/arch/arm/vgic-v3.c
+++ b/xen/arch/arm/vgic-v3.c
@@ -816,11 +816,35 @@ static int __vgic_v3_distr_common_mmio_write(const char *name, struct vcpu *v,
         return 1;
 
     case VRANGE32(GICD_ICPENDR, GICD_ICPENDRN):
+    {
+        struct pending_irq *iter;
+        unsigned int irq_start;
+        unsigned int irq_end;
+        uint32_t irq_pending = 0;
+
         if ( dabt.size != DABT_WORD ) goto bad_width;
         printk(XENLOG_G_ERR
                "%pv: %s: unhandled word write %#"PRIregister" to ICPENDR%d\n",
                v, name, r, reg - GICD_ICPENDR);
-        return 0;
+
+        irq_start = (reg - GICD_ICPENDR) * 32;
+        irq_end = irq_start + 31;
+        /* go through inflight_irqs and print specified pending irqs */
+        list_for_each_entry(iter, &v->arch.vgic.inflight_irqs, inflight)
+        {
+            if ( iter->irq < irq_start || irq_end < iter->irq )
+                continue;
+
+            if ( test_bit(GIC_IRQ_GUEST_QUEUED, &iter->status) )
+                irq_pending = irq_pending | (1 << (iter->irq - irq_start));
+        }
+
+        if ( irq_pending != 0 )
+            printk(XENLOG_G_ERR
+                   "%pv: %s: ICPENDR%d=0x%08x\n",
+                   v, name, reg - GICD_ICPENDR, irq_pending);
+        goto write_ignore_32;
+    }
 
     case VRANGE32(GICD_ISACTIVER, GICD_ISACTIVERN):
         if ( dabt.size != DABT_WORD ) goto bad_width;
@@ -978,19 +1002,17 @@ static int vgic_v3_rdistr_sgi_mmio_write(struct vcpu *v, mmio_info_t *info,
     case VREG32(GICR_ICFGR1):
     case VRANGE32(GICR_IPRIORITYR0, GICR_IPRIORITYR7):
     case VREG32(GICR_ISPENDR0):
-         /*
-          * Above registers offset are common with GICD.
-          * So handle common with GICD handling
-          */
+        /*
+        * Above registers offset are common with GICD.
+        * So handle common with GICD handling
+        */
         return __vgic_v3_distr_common_mmio_write("vGICR: SGI", v,
                                                  info, gicr_reg, r);
 
     case VREG32(GICR_ICPENDR0):
         if ( dabt.size != DABT_WORD ) goto bad_width;
-        printk(XENLOG_G_ERR
-               "%pv: vGICR: SGI: unhandled word write %#"PRIregister" to ICPENDR0\n",
-               v, r);
-        return 0;
+        return __vgic_v3_distr_common_mmio_write("vGICR: SGI", v,
+                                                 info, gicr_reg, r);
 
     case VREG32(GICR_IGRPMODR0):
         /* We do not implement security extensions for guests, write ignore */
-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Tue Oct 12 07:10:52 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 07:10:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.206775.362423 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maBvq-0005Ij-Uk; Tue, 12 Oct 2021 07:10:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 206775.362423; Tue, 12 Oct 2021 07:10:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maBvq-0005Ic-RX; Tue, 12 Oct 2021 07:10:38 +0000
Received: by outflank-mailman (input) for mailman id 206775;
 Tue, 12 Oct 2021 06:55:03 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=WKCD=PA=gmail.com=ryancaicse@srs-us1.protection.inumbo.net>)
 id 1maBgl-0003Y3-PA
 for xen-devel@lists.xen.org; Tue, 12 Oct 2021 06:55:03 +0000
Received: from mail-pj1-x102c.google.com (unknown [2607:f8b0:4864:20::102c])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 12b90e37-6251-44b2-956f-cdc3ac6b83cf;
 Tue, 12 Oct 2021 06:55:02 +0000 (UTC)
Received: by mail-pj1-x102c.google.com with SMTP id oa4so14279052pjb.2
 for <xen-devel@lists.xen.org>; Mon, 11 Oct 2021 23:55:02 -0700 (PDT)
Received: from [30.135.82.253] ([23.98.35.75])
 by smtp.gmail.com with ESMTPSA id r5sm1517362pjd.13.2021.10.11.23.55.00
 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
 Mon, 11 Oct 2021 23:55:01 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 12b90e37-6251-44b2-956f-cdc3ac6b83cf
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=user-agent:date:subject:from:to:message-id:thread-topic
         :mime-version;
        bh=R/vIZ5wUWsewvsCHSMp/LZJQsRQ5v5ylj55ne08rR6Q=;
        b=TNUENUnXsW0uSysSIqkqkFDEu8cl7aANF/3cEfW17wjWDoYS5IBjB2m0HQIRNUVXjn
         a8QD4gyqCNYxu55hNjB4SEFQKZJvjWPfUQge9Vd2qUbt7WnSLujlzcwi50Ee3tjBuA4g
         Giokn+qA13rNbuvsKyNeSRwTGr2z4VwLYJNKGyGux97Rxyv32NnX2iwER02O7JexmnMc
         9MyL20AOMGE1orpsLyADng/B9Gty/IoWgpZuMOXXKHBiVRx2N70nzuKI0M9pfy9FZebV
         rEumN2smv4iEz4nh0N3Zp6Y/jlDqi0etywvCcZSH6rD7x6ULEMPOMigcy8Kqy6Fr/Ujw
         JnGA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:user-agent:date:subject:from:to:message-id
         :thread-topic:mime-version;
        bh=R/vIZ5wUWsewvsCHSMp/LZJQsRQ5v5ylj55ne08rR6Q=;
        b=296yA5DBKy0iHo4x5leig1ShVzzdy9YvjNotsa+xAgRmNGmZ0Vfy6qGZ1KABDD8NZC
         T9wXMsUliTy9nx2rVrLKaQo5ICx+uj8M4GjcZNVlw+s/nO+ZxDj9msip6WzTX5sAQmWs
         LRmK49ylWD8Yk6htFiMCV9xXT0LSTvBIi7LaAEWJ4gsJyWDMwwN7mgDwh0Sb2jfotmjl
         /P3gZgKsAVl5HxdNCTtfSRey3C7m90q5/eIlFgC67ad1IBwk9NBtwqOIeZ1e9noWkF6x
         7UrcnWlAkqbzr0WisbZiRX/KvGWfdDcrWNS/4MFdH+tfjpYMDHDtrFmvmKqYVp6WiEVK
         gxhg==
X-Gm-Message-State: AOAM533gGhzXqIIIUgk1230v0BBtXI29f/4HU63OGKgvJJ6G9mT1Apyo
	lmeOoo82to9IGyLt8f957EcnQktQ/vI=
X-Google-Smtp-Source: ABdhPJzx0x4B57V5RuX/vFxRy1ULjPQX3pzLyOJiKPcgIDKIKf6LZDli68ooKofdWe3bFHs0WocvEA==
X-Received: by 2002:a17:90a:df91:: with SMTP id p17mr4041156pjv.185.1634021701612;
        Mon, 11 Oct 2021 23:55:01 -0700 (PDT)
User-Agent: Microsoft-MacOutlook/16.53.21091200
Date: Tue, 12 Oct 2021 14:54:57 +0800
Subject: [BUG] improper locking due to the unreleased lock
From: Ryan Cai <ryancaicse@gmail.com>
To: <xen-devel@lists.xen.org>,
	<ian.jackson@eu.citrix.com>
Message-ID: <747C0632-F341-4716-8B4A-10428A39A07D@gmail.com>
Thread-Topic: [BUG] improper locking due to the unreleased lock
Mime-version: 1.0
Content-type: multipart/alternative;
	boundary="B_3716895300_1494279762"

> This message is in MIME format. Since your mail reader does not understand
this format, some or all of this message may not be legible.

--B_3716895300_1494279762
Content-type: text/plain;
	charset="UTF-8"
Content-transfer-encoding: quoted-printable

Dear maintainers for Xen Project,

=20

=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 I am writing you to report a bug due to the unrele=
ased lock. The impact could be deadlock or memory consumption. In the functi=
on of read_watch_internal, the mutex lock h->watch_mutex (Line901) is not re=
leased correctly when read_message(h,nonblocking)=3D=3D -1(Line 923). Looking fo=
rward to your feedback. Thank for checking.

=20

=20

Locations, https://github.com/xen-project/xen/blob/master/tools/libs/store/=
xs.c#L902-L924

=20

Best,

Ryan Cai

=20


--B_3716895300_1494279762
Content-type: text/html;
	charset="UTF-8"
Content-transfer-encoding: quoted-printable

<html xmlns:o=3D"urn:schemas-microsoft-com:office:office" xmlns:w=3D"urn:schema=
s-microsoft-com:office:word" xmlns:m=3D"http://schemas.microsoft.com/office/20=
04/12/omml" xmlns=3D"http://www.w3.org/TR/REC-html40"><head><meta http-equiv=3DC=
ontent-Type content=3D"text/html; charset=3Dutf-8"><meta name=3DGenerator content=3D=
"Microsoft Word 15 (filtered medium)"><style><!--
/* Font Definitions */
@font-face
	{font-family:"Cambria Math";
	panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
	{font-family:DengXian;
	panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
	{font-family:Calibri;
	panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
	{font-family:"\@DengXian";
	panose-1:2 1 6 0 3 1 1 1 1 1;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
	{margin:0cm;
	font-size:12.0pt;
	font-family:"Calibri",sans-serif;}
span.EmailStyle17
	{mso-style-type:personal-compose;
	font-family:"Calibri",sans-serif;
	color:windowtext;}
.MsoChpDefault
	{mso-style-type:export-only;
	font-size:12.0pt;
	font-family:"Calibri",sans-serif;}
@page WordSection1
	{size:612.0pt 792.0pt;
	margin:72.0pt 72.0pt 72.0pt 72.0pt;}
div.WordSection1
	{page:WordSection1;}
--></style></head><body lang=3DEN-HK link=3D"#0563C1" vlink=3D"#954F72" style=3D'wo=
rd-wrap:break-word'><div class=3DWordSection1><p class=3DMsoNormal><span lang=3DEN=
-US style=3D'font-size:14.0pt'>Dear maintainers for Xen Project,<o:p></o:p></s=
pan></p><p class=3DMsoNormal><span lang=3DEN-US style=3D'font-size:14.0pt'><o:p>&n=
bsp;</o:p></span></p><p class=3DMsoNormal><span lang=3DEN-US style=3D'font-size:14=
.0pt'>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 I am writing you to report a bug due to the u=
nreleased lock. The impact could be deadlock or memory consumption. In the f=
unction of <i>read_watch_internal</i>, the mutex lock <i>h-&gt;watch_mutex</=
i> (<b>Line901</b>) is not released correctly when </span><i><span style=3D'fo=
nt-size:14.0pt'>read_message(h,nonblocking)=3D=3D -1</span></i><span style=3D'font=
-size:14.0pt'>(<b>Line 923</b>). Looking forward to your feedback. Thank for=
 checking</span><span lang=3DEN-US style=3D'font-size:14.0pt'>.<o:p></o:p></span=
></p><p class=3DMsoNormal><span style=3D'font-size:14.0pt'><o:p>&nbsp;</o:p></sp=
an></p><p class=3DMsoNormal><span lang=3DEN-US style=3D'font-size:14.0pt'><o:p>&nb=
sp;</o:p></span></p><p class=3DMsoNormal><span lang=3DEN-US style=3D'font-size:14.=
0pt'>Locations, https://github.com/xen-project/xen/blob/master/tools/libs/st=
ore/xs.c#L902-L924<o:p></o:p></span></p><p class=3DMsoNormal><span lang=3DEN-US =
style=3D'font-size:14.0pt'><o:p>&nbsp;</o:p></span></p><p class=3DMsoNormal><spa=
n style=3D'font-size:14.0pt'>Best,<o:p></o:p></span></p><p class=3DMsoNormal><sp=
an style=3D'font-size:14.0pt'>Ryan Cai<o:p></o:p></span></p><p class=3DMsoNormal=
><span lang=3DEN-US style=3D'font-size:11.0pt'><o:p>&nbsp;</o:p></span></p></div=
></body></html>

--B_3716895300_1494279762--




From xen-devel-bounces@lists.xenproject.org Tue Oct 12 07:25:12 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 07:25:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.206784.362434 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maC9s-0006nP-5I; Tue, 12 Oct 2021 07:25:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 206784.362434; Tue, 12 Oct 2021 07:25:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maC9s-0006nI-22; Tue, 12 Oct 2021 07:25:08 +0000
Received: by outflank-mailman (input) for mailman id 206784;
 Tue, 12 Oct 2021 07:25:06 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=kpIn=PA=oracle.com=dongli.zhang@srs-us1.protection.inumbo.net>)
 id 1maC9q-0006n6-E8
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 07:25:06 +0000
Received: from mx0b-00069f02.pphosted.com (unknown [205.220.177.32])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 85092268-2b2d-11ec-811a-12813bfff9fa;
 Tue, 12 Oct 2021 07:25:05 +0000 (UTC)
Received: from pps.filterd (m0246631.ppops.net [127.0.0.1])
 by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 19C6q3TU017592; 
 Tue, 12 Oct 2021 07:24:51 GMT
Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80])
 by mx0b-00069f02.pphosted.com with ESMTP id 3bmtmk3tpr-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Tue, 12 Oct 2021 07:24:51 +0000
Received: from pps.filterd (userp3030.oracle.com [127.0.0.1])
 by userp3030.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 19C7F6wv153005;
 Tue, 12 Oct 2021 07:24:50 GMT
Received: from nam10-mw2-obe.outbound.protection.outlook.com
 (mail-mw2nam10lp2107.outbound.protection.outlook.com [104.47.55.107])
 by userp3030.oracle.com with ESMTP id 3bkyv8damt-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Tue, 12 Oct 2021 07:24:50 +0000
Received: from BYAPR10MB2663.namprd10.prod.outlook.com (2603:10b6:a02:a9::20)
 by BYAPR10MB3592.namprd10.prod.outlook.com (2603:10b6:a03:11f::31)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.25; Tue, 12 Oct
 2021 07:24:49 +0000
Received: from BYAPR10MB2663.namprd10.prod.outlook.com
 ([fe80::2848:63dc:b87:8021]) by BYAPR10MB2663.namprd10.prod.outlook.com
 ([fe80::2848:63dc:b87:8021%7]) with mapi id 15.20.4587.026; Tue, 12 Oct 2021
 07:24:49 +0000
Received: from localhost.localdomain (138.3.200.16) by
 SA9P223CA0029.NAMP223.PROD.OUTLOOK.COM (2603:10b6:806:26::34) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.14 via Frontend Transport; Tue, 12 Oct 2021 07:24:47 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 85092268-2b2d-11ec-811a-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc :
 subject : date : message-id : in-reply-to : references : content-type :
 mime-version; s=corp-2021-07-09;
 bh=uUBzOadnaIwwsYIV3T/XKD51rUxNsmjfESD7O5siaBc=;
 b=c/wCRmyfbO3PQ5D+SbvaDmJtP91setYBDOS+a8r/qC6X5Wbd4+lnJLyPAwSmyE+Nvg9D
 WaJkFZ28cp8iXQGztFHh2pPCiY7V3w1bRkF5R6IemRpyCXLSRehd3z7h7J7Sb9qzdg9/
 Eu27/YPFT6odsH5IFv6g+H4RzwuEbW8UED5uRRzyDmgKNlOhlCG9rLxnA3Ho9/7Nb/LV
 aDhAax7RVztknEuw8FzD3mIEOewoire0t/xZePZmsVjfEkzkSq0XmfLlRWUQ8lVmoVu+
 LQuTpZi0eU7MMpPt0eQxsIH++BeDQzJXB/oRMTTzaOPczeGR2qUyhFH9V2uMfX2yJRDZ dA== 
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=f/vO2Cu4mEpfsfrD+0+lk+EdvxgZWNfodU5k8p9xOuWSmRdpvDEHIsAC54RPE1IoMiHk1wRxH2B+MM9rK0ON0v1Wam/erHjgZtvK/qe4WnOf1tZ6iagP0wJ5SR9Vg9YRiVRCbROGwhS1J1CpZ1VHqzOyReX7HrDswkRYFd0GdYwFd8II/e2uWuVrr+UGo/CjZZw8AxEwPGPVORYQ+c0R/pfh/81IXuxJmwmXcDvcz0vzSQnfWPlY7NrRHMHIelMKLmxfjjCAguio9kuHDWNIL1sQOrqdHEhxcwasLrnz47J769KSvXBE1c40q6/X10Po+M6HtZxGO8gCPUHNCK7fFw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=uUBzOadnaIwwsYIV3T/XKD51rUxNsmjfESD7O5siaBc=;
 b=Kz7hh2LYjUxOZ5hRHw3nxLx9PKPqMtRfUx15eTktxVOwTyPxtSEyYzLtIRdRSvKqzXTnepmF3iayrSVY0lxFgPwjclxKSZLOmzh3ax/nlVzhE+Cr0Kpjy8Sbybea8Disq4TkRhF7eUv+B9cs2ZSE6/CqN508KyYGRxzDIoW9Y7H2HNMglpb1PIomJQpuOFI6IA39ZHDQroxW9kE9WoaS3IyliWbbiSiNNvVLJPvsylBXlERlXfyWWPnt1EpdLWq8QZYfcGQHBynAVhT9MzFG0fuZRFdRuQPYhbjYSrb4QxjsPgwtqGbGPpuQbAe/VgaS1a1F5y/4I+TDHL/zobK6bg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com;
 dkim=pass header.d=oracle.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=uUBzOadnaIwwsYIV3T/XKD51rUxNsmjfESD7O5siaBc=;
 b=GYnXHGSgwuSuajEf8ImgHKLUWffESxAN+r3uFfJlDxCJGWFr74J4z6Ip89eoBWytXFN4+/SQ7K3YkMeb1Jg5ZNLGo5G86jb5AI1Cha+/vkDj40sEvaIrux3Ka9RcVkqlAaoTAOlE7Xm6fNSE/HMcMGg6yYwLJrsVQKxJlHaayZ8=
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=oracle.com;
From: Dongli Zhang <dongli.zhang@oracle.com>
To: xen-devel@lists.xenproject.org
Cc: linux-kernel@vger.kernel.org, x86@kernel.org, boris.ostrovsky@oracle.com,
        jgross@suse.com, sstabellini@kernel.org, tglx@linutronix.de,
        mingo@redhat.com, bp@alien8.de, hpa@zytor.com,
        andrew.cooper3@citrix.com, george.dunlap@citrix.com,
        iwj@xenproject.org, jbeulich@suse.com, julien@xen.org, wl@xen.org,
        joe.jin@oracle.com
Subject: [PATCH xen 2/2] xen: update system time immediately when VCPUOP_register_vcpu_info
Date: Tue, 12 Oct 2021 00:24:28 -0700
Message-Id: <20211012072428.2569-3-dongli.zhang@oracle.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20211012072428.2569-1-dongli.zhang@oracle.com>
References: <20211012072428.2569-1-dongli.zhang@oracle.com>
Content-Type: text/plain
X-ClientProxiedBy: SA9P223CA0029.NAMP223.PROD.OUTLOOK.COM
 (2603:10b6:806:26::34) To BYAPR10MB2663.namprd10.prod.outlook.com
 (2603:10b6:a02:a9::20)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 2159f8b3-e7e9-4483-7534-08d98d515fcc
X-MS-TrafficTypeDiagnostic: BYAPR10MB3592:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: 
	<BYAPR10MB35926DE8158385CFFAC38766F0B69@BYAPR10MB3592.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:3383;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 
	vz1hN7kqa8yvwTluY/yONzJgUTrCw3wIIRTwdBS4P+Ion9+ZB/ScZrJwRRCehbWdjlEupOO0ku5avR9CcV6yh5/le91VhuxtLt6yflmezquIlgRT5Q2/I7lEtgT1Bq4gh/oJqCtQL0Gws5BnqJm23z0kyw/ZI18zZZYmeSgbdPPVeQSxs0hOrEcG/ias6LBlaJrErh1ri043IYQmfEsBbt7MWwrhSK7BSxfKSv4HnyLIKsga7dxGb+/T3semu4lqJpizAXyHYeNP83MSncavoAvjrt3yYrlQiGJLbTR1Ke5MRbAaXS1X8ZhiIGu4EIO9XwgcSuiHRhuRMG1T48K4xX8R19fQHeEg0HSfvXZ3uQsJlYPIY9uZzRZh0nsHS3pJTDRtbzg7Sokqjauqfl+mQfNjpGwfcbnYEw/vAaUkIRpOoIeOmUfFjm7TDyK5DXcbwLmMv6nErRgica5NzGD4VztoS6IoQwCIcHSPXtqJPl1aKgPGCggjowLtTnBtvk9XkBQAzZB8GPEIn/y3dhDeHBq3k1IevDCBV0d3291zRj8lV0CyaDtab6jCdcG0dIJY4TXHHE6+nU/ejy3i7jFTeO1MLFL8jtC2W5+LEce1TsI2u8ypUavzqW16Mznh9ovBIRC+SBvv1rs2FGfWHHY9aprUb12MxJc+Zlu7hNyqIXnYsE3ok3eqEuiq+JNqPZCPeCCCy9WYIvCerrHfMRBfIYTjWJ8oZvARRsgvflMrXp0=
X-Forefront-Antispam-Report: 
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB2663.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(7416002)(44832011)(186003)(86362001)(6506007)(508600001)(8936002)(5660300002)(4326008)(36756003)(26005)(956004)(2616005)(52116002)(6916009)(316002)(6666004)(8676002)(66476007)(6512007)(83380400001)(66556008)(4744005)(38350700002)(38100700002)(1076003)(2906002)(107886003)(6486002)(66946007)(14773001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?O0dHk2t4n2STRnP4K5+otTdJ/3QHuT5PhQe+qijr9PsaikiZ5sXWJ6FFPryy?=
 =?us-ascii?Q?JarKyohTB1YcktAyiDw99oejGAEE8Pp4JhvMH/2i6Xl8tcl9a0eq3XMKvSir?=
 =?us-ascii?Q?VXWKUxfjr9B6VgLZzJZ8Oo993pWNscVeQYPCLZfoYScPHMgjSJCGCmQwEiUX?=
 =?us-ascii?Q?apAZnt3vHI4yChLUwbMugxZ8OXDbC43R3jXQhskWEkoF7IjAaEUvDYvKxdUI?=
 =?us-ascii?Q?EtdBJ22p4wASW7oVgWbAnjz5GQdGoM4taA2IAro7Yk3v89PK7RA4X6cMBGbd?=
 =?us-ascii?Q?C/A2rAZPlSIx/k25bBs/soLT/xQBDHAZ57lJaX4HHIsdcMjFdmvRiN5+mAMX?=
 =?us-ascii?Q?e84+V8RsHePCHxsN+G6gE5dZj4rQcj+yCLaXObwSqDhUxUZqCg1iz6ucbsG7?=
 =?us-ascii?Q?Jp0FRvLOscoMuRdXeJwblDIdMGEYPQgTjBulivvxXixv+ZNigALf2X6w9r7O?=
 =?us-ascii?Q?klqIbyOg/FaViJdosSR0ltmp1ZRWDbV3pQsaoswdyD7kuzTQfJNoPZq61TAF?=
 =?us-ascii?Q?xT1QY3j+FKVWaHt24QsGeMqYmIxPBdt9nfpyNquUMG2fmEUchkwbg1jmEX6T?=
 =?us-ascii?Q?fjzrDqtTQMAFNPWNNHpA2n25izQbFeNyKiMZrGunhr92IHY3767t0FtzXyvq?=
 =?us-ascii?Q?AUkLtHA9rHGDyj+JPJ+kcRBFUlNOnAbDq/nUDkposVSOfQZ5SP9GPQ1k1Ctk?=
 =?us-ascii?Q?83Zn3Z8oErgPw4u/cPWXIG0QZHrPNReQKnljOZsvn6W/mBEYIlu7IF59PQoR?=
 =?us-ascii?Q?dFzimOjB3EjpnHjyXrsWfu7mryilT7ENBepjIg/nLqmbBgD7YOhgw+LK93Ya?=
 =?us-ascii?Q?ETIf/zmsJIcEcUZrSZBWiVdOW9XYtVWXQ9nGgPGsAAKAFZes0SelbF7ieT/8?=
 =?us-ascii?Q?hi/BWzT7q8KVoyQMYul1AzrfwTlxJ/UJwSrCtSvfGyqfyO8PPQKRrtixaXDJ?=
 =?us-ascii?Q?RO7Kx2FxNqtLrWSjHcuGNbgxg8pavolRedzlYhURNDvt1pJE7qsPQ5Vlqu+9?=
 =?us-ascii?Q?RnUKzpUE6uOzV9SByMWK5ubhpKyHptz2OtGxpwLwb3rcl/Fc5Ck7LQqtj4RI?=
 =?us-ascii?Q?6TFFlKnP4M+Ms3AHCFAahdcfb4y+kpFT9VcxEfoJi03n8y+2zrNHc6qQKhCK?=
 =?us-ascii?Q?mb50+6ab9Llm44v6mivbexcSq9clYQ8DnqRuRyENGw5rP5tQMi2gk6cSjCpJ?=
 =?us-ascii?Q?DMVt5SYkN3UWtGGJZZxE+jgDWXNY4nmXqldvo1AA5sId4N11wHdox+VXuLP3?=
 =?us-ascii?Q?p74f7HxmMOAorRau3qhofgjOw5mC0F8k3JdEPpk68mrW4QF4EsJ+/a5+DF1Y?=
 =?us-ascii?Q?ZrgohxLz/7YKVioAT+468gp2?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2159f8b3-e7e9-4483-7534-08d98d515fcc
X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB2663.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2021 07:24:49.1536
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Kq7Op4hdU2L+ReQ5ED8TlHTloEDQeIZtYF2cclbt07DdIyPu7DdWrzug3WtxNWql49dtfNV+04x18SnwxIGnIw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB3592
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10134 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 phishscore=0 bulkscore=0
 malwarescore=0 adultscore=0 mlxscore=0 spamscore=0 mlxlogscore=999
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109230001
 definitions=main-2110120040
X-Proofpoint-GUID: yfUNozGS-NVNFifuP6d2uD8wX1hV75yL
X-Proofpoint-ORIG-GUID: yfUNozGS-NVNFifuP6d2uD8wX1hV75yL

The guest may access the pv vcpu_time_info immediately after
VCPUOP_register_vcpu_info. This is to borrow the idea of
VCPUOP_register_vcpu_time_memory_area, where the
force_update_vcpu_system_time() is called immediately when the new memory
area is registered.

Otherwise, we may observe clock drift at the VM side if the VM accesses
the clocksource immediately after VCPUOP_register_vcpu_info().

Cc: Joe Jin <joe.jin@oracle.com>
Signed-off-by: Dongli Zhang <dongli.zhang@oracle.com>
---
 xen/common/domain.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/xen/common/domain.c b/xen/common/domain.c
index 40d67ec342..c879f6723b 100644
--- a/xen/common/domain.c
+++ b/xen/common/domain.c
@@ -1695,6 +1695,8 @@ long do_vcpu_op(int cmd, unsigned int vcpuid, XEN_GUEST_HANDLE_PARAM(void) arg)
         rc = map_vcpu_info(v, info.mfn, info.offset);
         domain_unlock(d);
 
+        force_update_vcpu_system_time(v);
+
         break;
     }
 
-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Tue Oct 12 07:25:12 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 07:25:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.206785.362445 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maC9t-00074D-L8; Tue, 12 Oct 2021 07:25:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 206785.362445; Tue, 12 Oct 2021 07:25:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maC9t-000742-EI; Tue, 12 Oct 2021 07:25:09 +0000
Received: by outflank-mailman (input) for mailman id 206785;
 Tue, 12 Oct 2021 07:25:07 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=kpIn=PA=oracle.com=dongli.zhang@srs-us1.protection.inumbo.net>)
 id 1maC9r-0006nC-Ax
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 07:25:07 +0000
Received: from mx0b-00069f02.pphosted.com (unknown [205.220.177.32])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 2adee3c7-c373-4de7-89e0-212a6fb97407;
 Tue, 12 Oct 2021 07:25:04 +0000 (UTC)
Received: from pps.filterd (m0246631.ppops.net [127.0.0.1])
 by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 19C6q3TS017592; 
 Tue, 12 Oct 2021 07:24:49 GMT
Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71])
 by mx0b-00069f02.pphosted.com with ESMTP id 3bmtmk3tpj-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Tue, 12 Oct 2021 07:24:48 +0000
Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1])
 by aserp3030.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 19C7GMUt128333;
 Tue, 12 Oct 2021 07:24:47 GMT
Received: from nam10-mw2-obe.outbound.protection.outlook.com
 (mail-mw2nam10lp2107.outbound.protection.outlook.com [104.47.55.107])
 by aserp3030.oracle.com with ESMTP id 3bkyxr7vr6-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Tue, 12 Oct 2021 07:24:47 +0000
Received: from BYAPR10MB2663.namprd10.prod.outlook.com (2603:10b6:a02:a9::20)
 by BYAPR10MB3592.namprd10.prod.outlook.com (2603:10b6:a03:11f::31)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.25; Tue, 12 Oct
 2021 07:24:45 +0000
Received: from BYAPR10MB2663.namprd10.prod.outlook.com
 ([fe80::2848:63dc:b87:8021]) by BYAPR10MB2663.namprd10.prod.outlook.com
 ([fe80::2848:63dc:b87:8021%7]) with mapi id 15.20.4587.026; Tue, 12 Oct 2021
 07:24:44 +0000
Received: from localhost.localdomain (138.3.200.16) by
 SA9P223CA0029.NAMP223.PROD.OUTLOOK.COM (2603:10b6:806:26::34) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.14 via Frontend Transport; Tue, 12 Oct 2021 07:24:43 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2adee3c7-c373-4de7-89e0-212a6fb97407
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc :
 subject : date : message-id : content-type : mime-version;
 s=corp-2021-07-09; bh=O7D6Lx0SGGeULyAuzI6QSTKRXt1l8pLOBAU8iEv1O+E=;
 b=0hBAu4+d+odE5Rb0CuKXlImBSuvfVgqVWtBK+BJ3m+k+AZ+UCBhlTttrRKhxA9408IUs
 8xCnv6Pilo9n5PhG85UdDuD9fyp9b24TKgTEdBiV1vAgrED/KmSJu6oBlSi5YksQq5xn
 VDs2rqmv1CQcxqCW6SKUH42V6IfZ7payYDNijGC1dcXWfuPVIuAZFjLM5hbU7aj5Ol7a
 NtOxjDnKezUaUD74WNAA5312nHNfy2pDskLs4yx0/CTIKor7nkbpYakmbyxT7QpKPxFz
 PtUgdZWkYHm8vErj6LfYZVK6oApB+HP1xHpRjFcdNVS8ZoWPwkgmgoAMNzUDlnpp0a1m Nw== 
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=k9D2aAH5bsy8IrFQuiwEiSON7gR86ONrFuytar1wzDMWwOAz+zpOvMXtkpPb8PJLoWdgaVLog0rhMYNZiHfSLOb0Al1iMp6SgyeSTFApdHwi/hfMr4bhYNgqxVKXM0wdqKaF6cHowcT2csIce7a8U2YPJzIln+wbckuFS+VkoQlMF77HSS0OoHU1rc4ak5ZleH0R9F0FMxyu0A6Z1AqLFqlvPnxM41cWlzyx0HxxHAc5m9MvhQvNJ0LWxrPkpvmw191wgsJA6iJRv/Zb2i+cdmUjUIWKTS0JaVHkDdGsfei5mUh/XNcDkBrb5WDZmf32ncCXbo9Ulhn9bIFq08bH1A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=O7D6Lx0SGGeULyAuzI6QSTKRXt1l8pLOBAU8iEv1O+E=;
 b=n4KL1yIpa1AuF1gcxpXbISU96G43iAJ900KsNnKm1OLYVbWZWcivkjmvgVko13OTwNanFC7EMhlYZXmxKz3wJh6iIVxM7yvoC/FPiB58a0Ozd91W6g98MqYT9bAp/478RvmGR2pD3sfeHOMpLvDZ92bRvcRXgLyUX4KkDw5OjrrBSlzjInQH/6lWTHC2/XwtYuh30DDL5cqTBAi/nc9WmNuFl/x3HeaVhJ4bhLafBNDEYm+c+OGMlDDXWRvfbbcQE9feEBrafqkfC6Y/ahDRSVSDuzs2kjm9ARZ9rais+CcgUO80jh4JEReL2NtFMtXmS+w31c0NH30t01Qd/m55Jg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com;
 dkim=pass header.d=oracle.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=O7D6Lx0SGGeULyAuzI6QSTKRXt1l8pLOBAU8iEv1O+E=;
 b=pZ59AZmLogCR/P9XAuWJ4pJUdveq0jyKN+BDEtBzlN/OGO5M9klTfxN/zoR2EnExjIXRn/CwAm8IwMYCNzdtvbhsHCg8roliR2/lDNc5KOxNtn+dksBGJEh8LCALBzt306S1f4T5+Zpj4bEpFdmwSRvAV81s62XQmw1K1IbYky8=
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=oracle.com;
From: Dongli Zhang <dongli.zhang@oracle.com>
To: xen-devel@lists.xenproject.org
Cc: linux-kernel@vger.kernel.org, x86@kernel.org, boris.ostrovsky@oracle.com,
        jgross@suse.com, sstabellini@kernel.org, tglx@linutronix.de,
        mingo@redhat.com, bp@alien8.de, hpa@zytor.com,
        andrew.cooper3@citrix.com, george.dunlap@citrix.com,
        iwj@xenproject.org, jbeulich@suse.com, julien@xen.org, wl@xen.org,
        joe.jin@oracle.com
Subject: [PATCH 0/2] Fix the Xen HVM kdump/kexec boot panic issue
Date: Tue, 12 Oct 2021 00:24:26 -0700
Message-Id: <20211012072428.2569-1-dongli.zhang@oracle.com>
X-Mailer: git-send-email 2.17.1
Content-Type: text/plain
X-ClientProxiedBy: SA9P223CA0029.NAMP223.PROD.OUTLOOK.COM
 (2603:10b6:806:26::34) To BYAPR10MB2663.namprd10.prod.outlook.com
 (2603:10b6:a02:a9::20)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 09aefd72-74a2-4ca2-dc82-08d98d515d33
X-MS-TrafficTypeDiagnostic: BYAPR10MB3592:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: 
	<BYAPR10MB3592C6401473B25DA033915CF0B69@BYAPR10MB3592.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 
	P86hrSXa6fDwCBQSykKhavM5qZx0chdBhGgT4G0t/Fzfisb4I2nfJfLX0hGsP7tIzWWpTx3LGJGUosswSPDtNfGSl0MVWBsSgc0Iq0LHPYHzKiFSaeURiYuz2zzb66McBOyFD81xq808I6GHkLBZXeBVKoiZ9d6E/8qBB34CiiAts8jenKjsjK2e5kgBn7PKN4zjZsjKWa2VRZKfQCvCDl2rn0V3WQGT2Ghc4WT6C5oJyktfWzAsUF73A9OMMkzykl+DlLdFtdbR+lOBE9TiFM7sDFskc22sQV77RmcGN9bywtzo+HUro1HNiC6ZUwbhpKq+2ValNQhIHGCjwNd42oT8x2VId5o5Eur4ehSbgebPJiC1V2hRcHHS7/WUdhXQt4TY9kzwak9Dxtg0dqihcix5nQ2SfEmCt1fI2euESbxMJz+qnkkQHkDNPL6O8RLJ76RU/o5F2uaJjqjmMbh0eLM4T/AbY7mpXEicAXMT71JZopyLbfk4PW4c5xo3y28Y6uh8vsnOXNzwTUtllN1UEWVaOnFb5yLTnJiS4+olqgEkXps45a+k5CRzry311v1226e/L8vyq951hFBt0usHjbcfAw0MJU57zzRl/IJ61KhLt0LX9SA87dF5eM99Fe4UobVU0xZBmwgKTZTnHdjSNGdRUgFs/x/1dFvhYcBmBLoz6azK0bT/aSZXWEN4Nfr3XkRclR3IHdh9dad1rAlrFw==
X-Forefront-Antispam-Report: 
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB2663.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(7416002)(44832011)(186003)(86362001)(6506007)(508600001)(8936002)(5660300002)(4326008)(36756003)(26005)(956004)(2616005)(52116002)(6916009)(316002)(6666004)(8676002)(66476007)(6512007)(83380400001)(66556008)(38350700002)(38100700002)(1076003)(2906002)(107886003)(6486002)(66946007);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?fsJETzHqyc8lZrZdGSo/+RSSuMjrAdudYLlP5mKScax3WBEPhgWfpvz+aYEB?=
 =?us-ascii?Q?gt9UboqkuochgEq6dA8DI3W1uqdks0lMSeKVmKTZepfVH1+q1vgKJv+HuRgV?=
 =?us-ascii?Q?Ojh97jlm4mY6lBlHF00/ICsemFU2t69TALufrjhmyTgjpJA83Rs4EgRUYUb6?=
 =?us-ascii?Q?Czwlhwa5QBsDZZ+ugxaWCH6XgecGZ28gbvKz2l1/2JZ9ex0arWQt6VdfJR12?=
 =?us-ascii?Q?HhFhtxiFnuegbKWPEMUbchaOA3+oKcFw9sj5l9Np6qLyalstAdDfogZOstY0?=
 =?us-ascii?Q?oc+P8ZnGqb8pbHAaE3rRI599Qsrmm5DixSQewwwIZn+52B6kK0LXmROBSCyF?=
 =?us-ascii?Q?S9WfEU+ywKi7VCWEkt+TDGvkCOvD1uKG0JWnVfzDDYdMmNLSl1fKkl5eNJNO?=
 =?us-ascii?Q?1QUwpPGiHkgh1GkHjosa0WoLYo4D6fGpdw30Va6lMFt1faIbnS/PisUY8EO8?=
 =?us-ascii?Q?C2+kUmgPdY1eNp2DGXmgFQpU/uNSrALE1GYLW10vasdfXax2apztEj3WW2dl?=
 =?us-ascii?Q?ZW+CG+wdZpxQWse1RPtdUNFz4mRYANtXsDSlDog3ss6V+fQtI1/NFPR80UUX?=
 =?us-ascii?Q?elh0QrumvP34k1PxRCFH9oAp7pXaq/2hOf+aS4+Xl6arqyQ4CgRdEg486A/v?=
 =?us-ascii?Q?44hBWsbehD+s0eLlmaDCR3h55BAhTKdY9MzvCUAlp+f/wyTI16UTjB6vgJ73?=
 =?us-ascii?Q?4xDHVErd2mIzl2BgGXLZKWgkYGDMR1q3068Ao7nyCUc+EKp+UKhVByGbuzfP?=
 =?us-ascii?Q?jsNrm9c1Fytbh0TiogdhkMSMZSr7t/BkBiCag6Gd76NX5LUJA/lKGvs/zaz5?=
 =?us-ascii?Q?dsP2QeeYD6rQZEba1HQiqxvXx/poX0mTKTWHeeiwrJmWyn655lXm2o6fO8uE?=
 =?us-ascii?Q?p/hOL47YYa3gD2RU5riZKHyCXlaRFr5NPUDDAbsRWuzag7h7VyYsowNW5yr4?=
 =?us-ascii?Q?nAx5dlJKd86IJCV13MBhrTuWABculGZB5RoqM0G8dSP5jpWh+bG7KX2x29yU?=
 =?us-ascii?Q?zZHv0iA0BUNDZ3ExKlaL+KzffY2k0JdypKhJaLOwnAveViCVTN75ikWNOz9s?=
 =?us-ascii?Q?veZhS/MmM8letl9WTYpc2ggYl/xCuwgXwMw9uOjp5mbXKOb98h+XosRm+ksQ?=
 =?us-ascii?Q?Awus4PgtqNFta5XCH2L+KpuxB313UIiqURuVdMJ/D3BcmU3+D2qDH5HDcHPp?=
 =?us-ascii?Q?irYdVIhMwdCMievFgsfcuR1595Wz6PINO6hJh+f8/kq1UyNJUNQO0bbFFCaf?=
 =?us-ascii?Q?BuZI7GJlOMSAoaL4HBz+snc7Jb7SjQkz4nDAbN9k4TSWy0H/DGnsYjmZZeWE?=
 =?us-ascii?Q?yS00Osfra5lbqTdrCrU8mVOL?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 09aefd72-74a2-4ca2-dc82-08d98d515d33
X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB2663.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2021 07:24:44.7491
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: cq3mSf6zw5NW5Uqsu4yKFLGjs+Zn5mZWwbp8fswGS04PyPBYDWuDyYZ1IjCOQEz0hnwS3mj4yuIU+ab23D3xGw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB3592
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10134 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 phishscore=0 suspectscore=0
 mlxlogscore=999 mlxscore=0 bulkscore=0 adultscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109230001
 definitions=main-2110120040
X-Proofpoint-GUID: mlVgeoZ3IhzkcvrKSIWiYwH0rPZiJYw9
X-Proofpoint-ORIG-GUID: mlVgeoZ3IhzkcvrKSIWiYwH0rPZiJYw9

When the kdump/kexec is enabled at HVM VM side, to panic kernel will trap
to xen side with reason=soft_reset. As a result, the xen will reboot the VM
with the kdump kernel.

Unfortunately, when the VM is panic with below command line ...

"taskset -c 33 echo c > /proc/sysrq-trigger"

... the kdump kernel is panic at early stage ...

PANIC: early exception 0x0e IP 10:ffffffffa8c66876 error 0 cr2 0x20
[    0.000000] CPU: 0 PID: 0 Comm: swapper Not tainted 5.15.0-rc5xen #1
[    0.000000] Hardware name: Xen HVM domU
[    0.000000] RIP: 0010:pvclock_clocksource_read+0x6/0xb0
... ...
[    0.000000] RSP: 0000:ffffffffaa203e20 EFLAGS: 00010082 ORIG_RAX: 0000000000000000
[    0.000000] RAX: 0000000000000003 RBX: 0000000000010000 RCX: 00000000ffffdfff
[    0.000000] RDX: 0000000000000003 RSI: 00000000ffffdfff RDI: 0000000000000020
[    0.000000] RBP: 0000000000011000 R08: 0000000000000000 R09: 0000000000000001
[    0.000000] R10: ffffffffaa203e00 R11: ffffffffaa203c70 R12: 0000000040000004
[    0.000000] R13: ffffffffaa203e5c R14: ffffffffaa203e58 R15: 0000000000000000
[    0.000000] FS:  0000000000000000(0000) GS:ffffffffaa95e000(0000) knlGS:0000000000000000
[    0.000000] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[    0.000000] CR2: 0000000000000020 CR3: 00000000ec9e0000 CR4: 00000000000406a0
[    0.000000] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
[    0.000000] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
[    0.000000] Call Trace:
[    0.000000]  ? xen_init_time_common+0x11/0x55
[    0.000000]  ? xen_hvm_init_time_ops+0x23/0x45
[    0.000000]  ? xen_hvm_guest_init+0x214/0x251
[    0.000000]  ? 0xffffffffa8c00000
[    0.000000]  ? setup_arch+0x440/0xbd6
[    0.000000]  ? start_kernel+0x6a/0x689
[    0.000000]  ? secondary_startup_64_no_verify+0xc2/0xcb

This is because Xen HVM supports at most MAX_VIRT_CPUS=32 'vcpu_info'
embedded inside 'shared_info' during early stage until xen_vcpu_setup() is
used to allocate/relocate 'vcpu_info' for boot cpu at arbitrary address.


The 1st patch is to fix the issue at VM kernel side. However, we may
observe clock drift at VM side due to the issue at xen hypervisor side.
This is because the pv vcpu_time_info is not updated when
VCPUOP_register_vcpu_info.

The 2nd patch is to force_update_vcpu_system_time() at xen side when
VCPUOP_register_vcpu_info, to avoid the VM clock drift during kdump kernel
boot.


I did test the fix by backporting the 2nd patch to a prior old xen version.
This is because I am not able to use soft_reset successfully with mainline
xen. I have encountered below error when testing soft_reset with mainline
xen. Please let me know if there is any know issue/solution.

# xl -v create -F vm.cfg
... ...
... ...
Domain 1 has shut down, reason code 5 0x5
Action for shutdown reason code 5 is soft-reset
Done. Rebooting now
xc: error: Failed to set d1's policy (err leaf 0xffffffff, subleaf 0xffffffff, msr 0xffffffff) (17 = File exists): Internal error
libxl: error: libxl_cpuid.c:488:libxl__cpuid_legacy: Domain 1:Failed to apply CPUID policy: File exists
libxl: error: libxl_create.c:1573:domcreate_rebuild_done: Domain 1:cannot (re-)build domain: -3
libxl: error: libxl_xshelp.c:201:libxl__xs_read_mandatory: xenstore read failed: `/libxl/1/type': No such file or directory
libxl: warning: libxl_dom.c:53:libxl__domain_type: unable to get domain type for domid=1, assuming HVM


Thank you very much!

Dongli Zhang




From xen-devel-bounces@lists.xenproject.org Tue Oct 12 07:25:13 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 07:25:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.206786.362456 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maC9x-0007OH-Ru; Tue, 12 Oct 2021 07:25:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 206786.362456; Tue, 12 Oct 2021 07:25:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maC9x-0007O5-Oh; Tue, 12 Oct 2021 07:25:13 +0000
Received: by outflank-mailman (input) for mailman id 206786;
 Tue, 12 Oct 2021 07:25:12 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=kpIn=PA=oracle.com=dongli.zhang@srs-us1.protection.inumbo.net>)
 id 1maC9w-0006nC-8Y
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 07:25:12 +0000
Received: from mx0b-00069f02.pphosted.com (unknown [205.220.177.32])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 868517b2-bba8-459c-9b97-a04f479051a4;
 Tue, 12 Oct 2021 07:25:04 +0000 (UTC)
Received: from pps.filterd (m0246631.ppops.net [127.0.0.1])
 by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 19C6q3TT017592; 
 Tue, 12 Oct 2021 07:24:50 GMT
Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80])
 by mx0b-00069f02.pphosted.com with ESMTP id 3bmtmk3tpp-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Tue, 12 Oct 2021 07:24:50 +0000
Received: from pps.filterd (userp3030.oracle.com [127.0.0.1])
 by userp3030.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 19C7F6wu153005;
 Tue, 12 Oct 2021 07:24:49 GMT
Received: from nam10-mw2-obe.outbound.protection.outlook.com
 (mail-mw2nam10lp2107.outbound.protection.outlook.com [104.47.55.107])
 by userp3030.oracle.com with ESMTP id 3bkyv8damt-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Tue, 12 Oct 2021 07:24:49 +0000
Received: from BYAPR10MB2663.namprd10.prod.outlook.com (2603:10b6:a02:a9::20)
 by BYAPR10MB3592.namprd10.prod.outlook.com (2603:10b6:a03:11f::31)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.25; Tue, 12 Oct
 2021 07:24:47 +0000
Received: from BYAPR10MB2663.namprd10.prod.outlook.com
 ([fe80::2848:63dc:b87:8021]) by BYAPR10MB2663.namprd10.prod.outlook.com
 ([fe80::2848:63dc:b87:8021%7]) with mapi id 15.20.4587.026; Tue, 12 Oct 2021
 07:24:47 +0000
Received: from localhost.localdomain (138.3.200.16) by
 SA9P223CA0029.NAMP223.PROD.OUTLOOK.COM (2603:10b6:806:26::34) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.14 via Frontend Transport; Tue, 12 Oct 2021 07:24:45 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 868517b2-bba8-459c-9b97-a04f479051a4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc :
 subject : date : message-id : in-reply-to : references : content-type :
 mime-version; s=corp-2021-07-09;
 bh=nwfSvPTOo4gh2UoyMUD98r2uUx7xcXV8jueIuef2qVw=;
 b=ibe3RxerHT+rZejVK3+lHdo16cjxOoS3be+ubMLTgkJsku5r7xndtNgoG8GET6RCFal2
 sycVx3TVH7WsYlfZ/F1SKFBDd3cmoDgEHeh/mSo9kV726rPFplu0CE35/rf/k31tC5A3
 WsH9fzR7BmvN9Nu/kMA5t/MQH038x9CSMlvGCRlpBgbZUmOWHonj8+1/r6N/BMLkiiP9
 evKwGAPB1Fxmg63MFcQz2kX8Zx/CQc5vwTUna0fuK+RXD6qQmBNXQdTlhJLdo2tc0xm2
 jwdyODTAZEbI+LCIYfCvJT22gV248Nh2S2nxHwdbvyjwfqMRTWhbB6ltzr0PQ8lr0l3v HQ== 
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=AMYA/XFHuyNgEJOnzAegmXCNGbowR6VuOxgSZe8ivQVEX+sYNtLCAXbFTlbgATxTJFrQUJzrsn6H88R+sBAZ3Pxo11u7lgepPxCI/6npONOcNigsJjZFIuBVLy6+EmEsN06P/tEdcvIZVOg4rqLWp5hKLFuN1exkVkl3rJHBPCyON5NmRHIrIAMtfpoe1POOZSm94AWLvCGZ8AuaIgbzQURUj7bEoOAnb/9Uzs/m8ydx8WfOrJ/49Z3xdMZT8RgnX1uFxSLr83hdyxzlmg5f+3qVz5LjvqXS7CFdEBgf46lPbN9sZh1ZT+aJjLzAv9OiyA/meyltVCZijZpeBBpH2A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=nwfSvPTOo4gh2UoyMUD98r2uUx7xcXV8jueIuef2qVw=;
 b=KxxWQlt9XcMFVbq7SkJx7ZOdNq2A21+OMazZ/GnlQcd8HugnrKcXYYaTKZfaANQFl2o6vJkhR2ElNmXQ6oxY1JGOsHe9NgQFTyViBaDqAFUovXRhzhQg93dj9wNidxaA6OUL78rqBNHHRRTfeZ9cwl21VG7xo5iSMFIWO9N0XBsKL2VsjEA/1iz+bSo33KmiT9JWafxBxy/KGYdaeWIx9t+Yfl05/QoHl0L92EEgiLWqhYXHhZU9U5yvVB5O0Xm3yJD2jNmPVob/RolAAzr4mbhtgpdoxoUzA4vWllzfFFES7OCXYIx9cV4aFL4xxZvmSQojHjmWD5ozmNGlMY8wbg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com;
 dkim=pass header.d=oracle.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=nwfSvPTOo4gh2UoyMUD98r2uUx7xcXV8jueIuef2qVw=;
 b=QP3zsNXK8+vTr+uiWKEwrN4R3dGXc5UhJxok5aiX6yZdvEPdUzhQwSTkjpo/3UXsqrxSa9Dp9V6Tq6RXy/V052ExTEdkLZ2FggqsAllod32d6jB077YBlzfTJ8xaG32we2Z6EYgORlqeW79uK26pWtCUcpA70EW2b6HChx3PgwE=
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=oracle.com;
From: Dongli Zhang <dongli.zhang@oracle.com>
To: xen-devel@lists.xenproject.org
Cc: linux-kernel@vger.kernel.org, x86@kernel.org, boris.ostrovsky@oracle.com,
        jgross@suse.com, sstabellini@kernel.org, tglx@linutronix.de,
        mingo@redhat.com, bp@alien8.de, hpa@zytor.com,
        andrew.cooper3@citrix.com, george.dunlap@citrix.com,
        iwj@xenproject.org, jbeulich@suse.com, julien@xen.org, wl@xen.org,
        joe.jin@oracle.com
Subject: [PATCH linux 1/2] xen: delay xen_hvm_init_time_ops() if kdump is boot on vcpu>=32
Date: Tue, 12 Oct 2021 00:24:27 -0700
Message-Id: <20211012072428.2569-2-dongli.zhang@oracle.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20211012072428.2569-1-dongli.zhang@oracle.com>
References: <20211012072428.2569-1-dongli.zhang@oracle.com>
Content-Type: text/plain
X-ClientProxiedBy: SA9P223CA0029.NAMP223.PROD.OUTLOOK.COM
 (2603:10b6:806:26::34) To BYAPR10MB2663.namprd10.prod.outlook.com
 (2603:10b6:a02:a9::20)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 43bfdb0d-812b-4605-73c6-08d98d515ead
X-MS-TrafficTypeDiagnostic: BYAPR10MB3592:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: 
	<BYAPR10MB359206A16758AB39541D2009F0B69@BYAPR10MB3592.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 
	dA5GBJeElMS5CFENyOt/h49wxBvO4Du/6CePcCtyPgT5Qwqrh23BtAGl8CYQ8lGTJQqemenAeqxFWSXqvqD+NNzOu6k1pdgUUwmPme9WI0LnW+wJzRRmjXkb+QlU5c227PgKVPxpcmkMU2AAiyLN0JzlHx79/dwEnv82USqnPtumElozwTt+chn8e0fCrSeC2RupqbOs2HFPHCvykjkMXovXMr6AXSxe5RPCB8tNAM8b3t5O8IyXosab+nYPZVepWFiKpGeaTf5fnVQwm4oYHXHAZ7JaUgwqG2/0yqpCDxfdpYI9dvtxQ8+ZH8YOk1DF/LJBHvOLVLeKSaVYSFv/fx+fpcwLLTwyXeLwAYpeWL9WpS0dL5a4NWaP8A8ILIbxOy1+tD/Hm8j/Q7stXws9/3L1jVm4DrojAOLppCmIM/RvYLhzCfzT4QV5H54zmEzxTyexP6ndRjYIAx009dkyZKXJPP15w2pqMoig/OVPKODMjp+oRNV30E5n5TcRaAtj+oREcu4VRt6ecs2aArhpFLTJ64ZeO10Ru1KL0t+7xrkVI10hkSZwGy1mQkXOFNwknHUtPGKBiYl9OjrvHhNrWXKJ88LEGuZWemgPJe792V07bjIS31Dp8oVkT1vLbSbRJehmcUCWYYlkzVKGDPZHUTvq/TxV1LKGDPi2tvZsHDKbRKgHTtJJvymzB5A9LRTnZRE8stYx09XyvdXY8z8w1g==
X-Forefront-Antispam-Report: 
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB2663.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(7416002)(44832011)(186003)(86362001)(6506007)(508600001)(8936002)(5660300002)(4326008)(36756003)(26005)(956004)(2616005)(52116002)(6916009)(316002)(6666004)(8676002)(66476007)(6512007)(83380400001)(66556008)(38350700002)(38100700002)(1076003)(2906002)(107886003)(6486002)(66946007);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?mw7W1gKsL2WbnbLI3QPsfOTzt0p6TOX/ADkczBbshZ9d+6S84K63KTKL5w/6?=
 =?us-ascii?Q?fFQ6lnOSABpucXYqh54LszatBLDzmllh+7vu6pFnfyPByQUi3cOw0j/bYkCT?=
 =?us-ascii?Q?h3jLPHHUWp7RLQ7+v4NEF2yRvHgtnRA1tAqTY7Dn7U5iheHi+uXs1RFQGJil?=
 =?us-ascii?Q?1uqpwJa3I/jnVOVvQ+X4ge8g155a5zo1NyifG8zPAXGBtOFiZPu2GPvAZxep?=
 =?us-ascii?Q?x77ShlQG5FrQe7LWAiK6kilPsKiYHNICtHDprxywgGz6Wq8vYR7yPtscfb3o?=
 =?us-ascii?Q?FDAZ4dQFMiLY9AzHm1EVrrVNYurwl0421ltgb0Rf75y6+2KuwlgUCOifI7Ze?=
 =?us-ascii?Q?fs+0F1hFitFafrJ3N82t41PxCjU9qaZLAAVfddsfvvp7VkRXuskxXoezdUzv?=
 =?us-ascii?Q?btk9lmgd4zNH9/iVzXzQRTFoTKnXfqYjTin8AztGqRtqQ1mrOhciHZiZuAnW?=
 =?us-ascii?Q?vzMqdkb+xuKZ3Xpc67ZiRalI3xC6OcGEACaAP0Wc9oxRE+5DOa6QMNmpFyiY?=
 =?us-ascii?Q?cy8D77+9gW4dwACO76l9ZepIdo05wGfAQP46W1G56FQ6WBggy6FHCKjdEuE9?=
 =?us-ascii?Q?O/CFp0ZfQxwcLihnK8+3Fu/xUWAXf4gMGrAtAvlJ2z1QF+sOMHXLpmsrQI+p?=
 =?us-ascii?Q?vwVvjkFj4J1ba9Ke1KRykQNSaVBVq7eokQfwzzWA/v+3mq6pfaK0cLT+KxjT?=
 =?us-ascii?Q?ZXHuLdxn5vjGCAVvue47v1s4H4euujdRq6qA5rZ462EgrJCD+kwWYHojvztu?=
 =?us-ascii?Q?LGplqo9xXntpbSM4BYr14vYWc8RnE5OMfDLACRd2k/R5Zz2W3Ks8SRrYU1fE?=
 =?us-ascii?Q?rYuoVXLUGZcmzT7zW+65VVYNcucyGix28RvMurmtXJXxGXgksGPH3DgQOn6O?=
 =?us-ascii?Q?GbNHKSjkLtn/hqIsuRIhd9Dcsd9uN2gcraBFwbe+wG6mtSU3CQHMTzlmF/T5?=
 =?us-ascii?Q?4ece+fU+M1veRC85q7tldEQtLtrjXswdca5+cT2Z+kmAKBBt8kfGm77v4Iju?=
 =?us-ascii?Q?3FECtezZmgDnzUcFRxlcNVEtDXmWxkrNt1+htMLxFz2p+nQrZHWCdqBY3WL5?=
 =?us-ascii?Q?maWMhIHGQNMeoUstgGaOgMKf2WN9paA0ktWgsP1qe9Q8zEzNj77ii+znyX8G?=
 =?us-ascii?Q?BoYChOBx3I/Iey1YEAA4bOZZY9oXty4qvgvlIK//hBBkF26Az8gtyCjJ0LX4?=
 =?us-ascii?Q?3Ucjd2yVNIZ+oHQHnaPr60fIwIcsg5m7bvvCMknUE0A2tQu6JMpWwIW1C5Vk?=
 =?us-ascii?Q?WnqNpmXEoxzAiTYAaNjHtY6cOm9DN7/h+wq6HgWat5ecjaRIwKohaZPTnZye?=
 =?us-ascii?Q?1ScdECBT0qaSDariK9lY4PD5?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 43bfdb0d-812b-4605-73c6-08d98d515ead
X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB2663.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2021 07:24:47.1967
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Cg0tjFXPw4wRcc/5RZQV7PwDfUbjHIFWCIni6pJdMjiW+5A3pjkBvudDo59ROlcXzt9rWDEnrk0n0Fdr/z07Gw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB3592
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10134 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 phishscore=0 bulkscore=0
 malwarescore=0 adultscore=0 mlxscore=0 spamscore=0 mlxlogscore=999
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109230001
 definitions=main-2110120040
X-Proofpoint-GUID: epHvCdqTYPpBXldlhYPNKkjXr_QRcds0
X-Proofpoint-ORIG-GUID: epHvCdqTYPpBXldlhYPNKkjXr_QRcds0

The sched_clock() can be used very early since upstream
commit 857baa87b642 ("sched/clock: Enable sched clock early"). In addition,
with upstream commit 38669ba205d1 ("x86/xen/time: Output xen sched_clock
time from 0"), kdump kernel in Xen HVM guest may panic at very early stage
when accessing &__this_cpu_read(xen_vcpu)->time as in below:

setup_arch()
 -> init_hypervisor_platform()
     -> x86_init.hyper.init_platform = xen_hvm_guest_init()
         -> xen_hvm_init_time_ops()
             -> xen_clocksource_read()
                 -> src = &__this_cpu_read(xen_vcpu)->time;

This is because Xen HVM supports at most MAX_VIRT_CPUS=32 'vcpu_info'
embedded inside 'shared_info' during early stage until xen_vcpu_setup() is
used to allocate/relocate 'vcpu_info' for boot cpu at arbitrary address.

However, when Xen HVM guest panic on vcpu >= 32, since
xen_vcpu_info_reset(0) would set per_cpu(xen_vcpu, cpu) = NULL when
vcpu >= 32, xen_clocksource_read() on vcpu >= 32 would panic.

This patch delays xen_hvm_init_time_ops() to later in
xen_hvm_smp_prepare_boot_cpu() after the 'vcpu_info' for boot vcpu is
registered when the boot vcpu is >= 32.

This issue can be reproduced on purpose via below command at the guest
side when kdump/kexec is enabled:

"taskset -c 33 echo c > /proc/sysrq-trigger"

Cc: Joe Jin <joe.jin@oracle.com>
Signed-off-by: Dongli Zhang <dongli.zhang@oracle.com>
---
 arch/x86/xen/enlighten_hvm.c | 20 +++++++++++++++++++-
 arch/x86/xen/smp_hvm.c       |  3 +++
 2 files changed, 22 insertions(+), 1 deletion(-)

diff --git a/arch/x86/xen/enlighten_hvm.c b/arch/x86/xen/enlighten_hvm.c
index e68ea5f4ad1c..152279416d9a 100644
--- a/arch/x86/xen/enlighten_hvm.c
+++ b/arch/x86/xen/enlighten_hvm.c
@@ -216,7 +216,25 @@ static void __init xen_hvm_guest_init(void)
 	WARN_ON(xen_cpuhp_setup(xen_cpu_up_prepare_hvm, xen_cpu_dead_hvm));
 	xen_unplug_emulated_devices();
 	x86_init.irqs.intr_init = xen_init_IRQ;
-	xen_hvm_init_time_ops();
+
+	/*
+	 * Only MAX_VIRT_CPUS 'vcpu_info' are embedded inside 'shared_info'
+	 * and the VM would use them until xen_vcpu_setup() is used to
+	 * allocate/relocate them at arbitrary address.
+	 *
+	 * However, when Xen HVM guest panic on vcpu >= MAX_VIRT_CPUS,
+	 * per_cpu(xen_vcpu, cpu) is still NULL at this stage. To access
+	 * per_cpu(xen_vcpu, cpu) via xen_clocksource_read() would panic.
+	 *
+	 * Therefore we delay xen_hvm_init_time_ops() to
+	 * xen_hvm_smp_prepare_boot_cpu() when boot vcpu is >= MAX_VIRT_CPUS.
+	 */
+	if (xen_vcpu_nr(0) >= MAX_VIRT_CPUS)
+		pr_info("Delay xen_hvm_init_time_ops() as kernel is running on vcpu=%d\n",
+			xen_vcpu_nr(0));
+	else
+		xen_hvm_init_time_ops();
+
 	xen_hvm_init_mmu_ops();
 
 #ifdef CONFIG_KEXEC_CORE
diff --git a/arch/x86/xen/smp_hvm.c b/arch/x86/xen/smp_hvm.c
index 6ff3c887e0b9..60cd4fafd188 100644
--- a/arch/x86/xen/smp_hvm.c
+++ b/arch/x86/xen/smp_hvm.c
@@ -19,6 +19,9 @@ static void __init xen_hvm_smp_prepare_boot_cpu(void)
 	 */
 	xen_vcpu_setup(0);
 
+	if (xen_vcpu_nr(0) >= MAX_VIRT_CPUS)
+		xen_hvm_init_time_ops();
+
 	/*
 	 * The alternative logic (which patches the unlock/lock) runs before
 	 * the smp bootup up code is activated. Hence we need to set this up
-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Tue Oct 12 07:45:19 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 07:45:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.206812.362467 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maCTK-00020H-CZ; Tue, 12 Oct 2021 07:45:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 206812.362467; Tue, 12 Oct 2021 07:45:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maCTK-00020A-9U; Tue, 12 Oct 2021 07:45:14 +0000
Received: by outflank-mailman (input) for mailman id 206812;
 Tue, 12 Oct 2021 07:45:13 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=B8jq=PA=arm.com=Bertrand.Marquis@srs-us1.protection.inumbo.net>)
 id 1maCTJ-000204-0W
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 07:45:13 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com (unknown
 [40.107.20.84]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 5443f704-2b30-11ec-811a-12813bfff9fa;
 Tue, 12 Oct 2021 07:45:11 +0000 (UTC)
Received: from AM6PR01CA0070.eurprd01.prod.exchangelabs.com
 (2603:10a6:20b:e0::47) by VI1PR08MB3053.eurprd08.prod.outlook.com
 (2603:10a6:803:45::18) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.20; Tue, 12 Oct
 2021 07:45:08 +0000
Received: from VE1EUR03FT028.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:e0:cafe::9f) by AM6PR01CA0070.outlook.office365.com
 (2603:10a6:20b:e0::47) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.21 via Frontend
 Transport; Tue, 12 Oct 2021 07:45:08 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT028.mail.protection.outlook.com (10.152.18.88) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4587.18 via Frontend Transport; Tue, 12 Oct 2021 07:45:08 +0000
Received: ("Tessian outbound d5def7722ff7:v103");
 Tue, 12 Oct 2021 07:45:07 +0000
Received: from 8eb322abf5dd.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 AC606DAF-1618-47F8-B52E-DCE4215067A2.1; 
 Tue, 12 Oct 2021 07:45:01 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 8eb322abf5dd.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Tue, 12 Oct 2021 07:45:01 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com (2603:10a6:4:74::9)
 by DB6PR0802MB2183.eurprd08.prod.outlook.com (2603:10a6:4:84::17) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.25; Tue, 12 Oct
 2021 07:44:49 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955]) by DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955%4]) with mapi id 15.20.4587.026; Tue, 12 Oct 2021
 07:44:49 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5443f704-2b30-11ec-811a-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=fUAl/sM9s17G+Kd5NIK07BU8aGRMTtMauo0zrZm1+Fo=;
 b=xZ9ou9agT3bxiIG9Yy//o605dTDtOOw61jFrM6V2JCWyjkR8u8lRFhD4bB+N1m1JIYxj7W1jr9DCNDHxNQ77+Vxa/oUvIcfdX2n80nk574m8eCEcoghRTQqx3TKPWbirKX04kzl4xl1rZQLiwgvPbihNUVVnCZXUwxBoncQRPDY=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: a467c569c1c0927e
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=b+CrAho0ISpSkQEbX54xe+esbQkf7yLN4ksQ44PNkGTGcBPdbkY4JK08HzSI/uw8bSrBO6BjmwFfk5W/6EjaCW3jEqORrCJ1GC1rENlg8Y4pBTt26s9MrNys9W4D3NXbzJBBczTtN8T7LTH2D98CXEtLEPW1nJ0Ip9Nbp1jdhRmLYLFoq0BBbUYiRp8/BOVg8mlyEg8eEe5agnk1FvOCeJduGrNxZIQv3AkpJfe4/NsQNZJdGR5aZWr1ofjPhATknK2ZB2/mWBN5/u4WsvNjo271FnDXjAl47wzSrXivf57AAQdjTW/nlnXEpgu9wXZTsNSlug9NkJeiv43Pt48l+A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=fUAl/sM9s17G+Kd5NIK07BU8aGRMTtMauo0zrZm1+Fo=;
 b=I8cThLSmS+CBImVnflgalfe3eXnin6k/CoevhnJF4Wdn5JRXep4Xt00AxWjYCKoak4T/7jJJV9LzjzJS0Bc5jlRONB2z8eru5pHptplT5EqlXMIkiGwW4RicvCVdqF9yhxbRUqwfzHeIMLMKpCHC9RdFVp0itTMZCX80QPeO9LWakiKqWcxCPDhHuQ3zzJPKxPxE2FXN45ry30NSHyn+pw+dikktcE4btO6HxFeEvvj4uwoY5ruWunK7DyeriIKA/ZIejWOBbXbm1lCFQhK0O37kHYH9yGD70UqVNZ22hadCKm1N+uA9n+yqIOoNWa/XFQ3n1LrUsWeV11LxVbLtcQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=fUAl/sM9s17G+Kd5NIK07BU8aGRMTtMauo0zrZm1+Fo=;
 b=xZ9ou9agT3bxiIG9Yy//o605dTDtOOw61jFrM6V2JCWyjkR8u8lRFhD4bB+N1m1JIYxj7W1jr9DCNDHxNQ77+Vxa/oUvIcfdX2n80nk574m8eCEcoghRTQqx3TKPWbirKX04kzl4xl1rZQLiwgvPbihNUVVnCZXUwxBoncQRPDY=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Stefano Stabellini <sstabellini@kernel.org>
CC: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>,
	=?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>, Rahul Singh
	<Rahul.Singh@arm.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, Andre Przywara <Andre.Przywara@arm.com>,
	Julien Grall <julien@xen.org>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
	Jan Beulich <jbeulich@suse.com>, Wei Liu <wl@xen.org>, Paul Durrant
	<paul@xen.org>
Subject: Re: [PATCH v5 08/11] xen/arm: Enable the existing x86 virtual PCI
 support for ARM.
Thread-Topic: [PATCH v5 08/11] xen/arm: Enable the existing x86 virtual PCI
 support for ARM.
Thread-Index:
 AQHXutl3YqS5dHXsYk6KpdKt4d14RavNphKAgABZ5QCAAAISgIAABoqAgAAJBQCAABTvgIAAD/UAgADN4QA=
Date: Tue, 12 Oct 2021 07:44:49 +0000
Message-ID: <0DF5666A-937D-42A5-A521-0387F6BEE765@arm.com>
References: <cover.1633540842.git.rahul.singh@arm.com>
 <9bdca2cda5d2e83f94dc2423e55714273539760a.1633540842.git.rahul.singh@arm.com>
 <YWQXF2vDaWQvi+bT@MacBook-Air-de-Roger.local>
 <4F406854-4F90-48F6-8470-6CCB60A3CB77@arm.com>
 <e199bfe2-0bcc-989f-fd4a-ecf44a3cd1ac@epam.com>
 <YWRpuUtHkyA4RY5H@MacBook-Air-de-Roger.local>
 <AF7AB609-3E79-4017-A296-CC7C87E1705F@arm.com>
 <611b61a4-9635-f1e6-a078-e40d4cbd49fd@epam.com>
 <alpine.DEB.2.21.2110111226220.25528@sstabellini-ThinkPad-T480s>
In-Reply-To: <alpine.DEB.2.21.2110111226220.25528@sstabellini-ThinkPad-T480s>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3654.120.0.1.13)
Authentication-Results-Original: kernel.org; dkim=none (message not signed)
 header.d=none;kernel.org; dmarc=none action=none header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: 24dccaf6-2c09-484d-45b9-08d98d543691
x-ms-traffictypediagnostic: DB6PR0802MB2183:|VI1PR08MB3053:
x-ms-exchange-transport-forked: True
X-Microsoft-Antispam-PRVS:
	<VI1PR08MB3053C3AF35C4F44CF69228969DB69@VI1PR08MB3053.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:9508;OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 uKz/Ucsjsih/t1EOceNpJa3hSUDEk5w5dE2EuABt6y2ixSsssuzp0MhcFRkQ9HCp3MrCn0MV1Gwsl9/JR5wYkcRFLrC7SvRnnOLlOHQG5s5h1syHsAVvgFVVNBREA49gg1nYSpYqUGLKW5etIHmSF9QWNaEPV0vzWmQQNwHNWa931GXvG2fvTFuFg84bxuXdbJ2k5WR+WhAu3MrRO8aBnQMIxDnMVe/sLKjHfH+3pGB0iLr2SZU7Doy6rs1PXN6wL2U5pM6FSL/ra/n2a4X7vFblmkAgpJBi5FP7hC9uDU9gEbHNSERR5UwJE/eVBRn0t8oQL+TCs2afCggvS4TDSnbP+/x5Km+Hp91J13Hag0vpngBwd+7Yl9+gGBs2k9n9+rGhDvVSM/hqR6rV82iztwoYgdEcCOuPmQ4zg1/DA5f+sVbe/WiHgNKqcU2gJJmKXAPZOxk0G7xh5ykaesSDnN62iDc9xQwBvYLRwVLRqqp033nHVHs23iMb2p/n2sssUD/mRwL5oWOB2a97vOraK0Xw4OW1QLhSpGbX3EnXcOoiWSNj43svSmKpv/fnKJgwAe39gq/+ra/Vax4FYHrtgSicfsD/LF5Dq2xXNu8Vx4YOEObo0e8nSp4oZK4yd652ag9NqzZKdPWVUR393sQhxcslhHBjnGl21Y5fDbe8r96qkiV4rOQEzmVXLIziywbWE6CiWWFjg8x40zDleXOP7nrlm+Ty5m2ZQbtS2imoEkZrxWSmdB6OWJ/IdZIAdJbM
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB6PR0801MB2024.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(38070700005)(53546011)(5660300002)(6486002)(6506007)(71200400001)(6916009)(8936002)(38100700002)(122000001)(4326008)(8676002)(26005)(83380400001)(66476007)(36756003)(64756008)(66556008)(86362001)(7416002)(33656002)(316002)(54906003)(2906002)(508600001)(2616005)(6512007)(66446008)(91956017)(186003)(76116006)(66946007)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-ID: <DA97348E26A89F47A9185C13D91D298C@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0802MB2183
Original-Authentication-Results: kernel.org; dkim=none (message not signed)
 header.d=none;kernel.org; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT028.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	805d50d9-1569-4438-1601-08d98d542b52
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	EeCcLv/5wHLKSP3r5TSpvmiomjuY1RsSpLTISUYFTzwKdzH5QRfukpnKumJaT6FHnKsIG7zlVHqS6igNMvmiWxD+duUrDQQpXO/aaUCS9LNHIpU1DvuSPiuA13wAQylIJu6NvlePtJsgR6pFRFdEUq496Xb4NwTntLojpnuuudf8XkASDT/W2oiXQxN5NRb2M3KC32k3Qt4aliQEwhuExQYhG+GcIQoAtgfkyNRuyHkpxS7fw8fMKgO/QCTEcM8yPE98HiWYwaS49mhrPDFxtYoKP1UmsGmh0EKgSHdOeHHecHxU4NvxGY5sXFlgyZU22ZqfXTVTEeJ5dXfLIzzlHW443ypC0wOncynhoYpwZh7beX8X9dVU90qW+dbHK/d3j4PgoMMFbiCWLdG1Unwzde9X8PIuh78i1+795HAi3OUQomMyKMZkjsoUaT+enEVbVSjyuIhYXwnf1sfHGJl3unPNtHWk+EfcRIvtnbOAmJAOvdHN2r0JP2s8gspMpBiS59c4In6YGrB8tuv5vbnZcmR9YJaHwkDwzAwrpR1NAoQX7MIijX/qvuVIHclxWaBvlW0jqzJJcve7lcJ0190O2coUkHo2dsxiqKOOvdDU3mapTIxTLHqwbnq1EyKaA6bJsX2Vd8kXFFtFjQIGcowTYakevUYLOitOQGF2QJ51cJJkr0uSTajw53el5Hw6nQSAN/J3TrHyXXXXRLzLOFw5IQ==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(336012)(2616005)(508600001)(47076005)(82310400003)(8936002)(8676002)(81166007)(83380400001)(356005)(2906002)(36860700001)(86362001)(36756003)(6512007)(33656002)(53546011)(4326008)(6486002)(5660300002)(316002)(26005)(186003)(70586007)(70206006)(6506007)(6862004)(54906003);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2021 07:45:08.0476
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 24dccaf6-2c09-484d-45b9-08d98d543691
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT028.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3053

SGkgU3RlZmFubywNCg0KPiBPbiAxMSBPY3QgMjAyMSwgYXQgMjA6MjcsIFN0ZWZhbm8gU3RhYmVs
bGluaSA8c3N0YWJlbGxpbmlAa2VybmVsLm9yZz4gd3JvdGU6DQo+IA0KPiBPbiBNb24sIDExIE9j
dCAyMDIxLCBPbGVrc2FuZHIgQW5kcnVzaGNoZW5rbyB3cm90ZToNCj4+IE9uIDExLjEwLjIxIDIw
OjE1LCBCZXJ0cmFuZCBNYXJxdWlzIHdyb3RlOg0KPj4+IEhpIFJvZ2VyLA0KPj4+IA0KPj4+PiBP
biAxMSBPY3QgMjAyMSwgYXQgMTc6NDMsIFJvZ2VyIFBhdSBNb25uw6kgPHJvZ2VyLnBhdUBjaXRy
aXguY29tPiB3cm90ZToNCj4+Pj4gDQo+Pj4+IE9uIE1vbiwgT2N0IDExLCAyMDIxIGF0IDA0OjIw
OjE0UE0gKzAwMDAsIE9sZWtzYW5kciBBbmRydXNoY2hlbmtvIHdyb3RlOg0KPj4+Pj4gDQo+Pj4+
PiBPbiAxMS4xMC4yMSAxOToxMiwgQmVydHJhbmQgTWFycXVpcyB3cm90ZToNCj4+Pj4+PiBIaSBS
b2dlciwNCj4+Pj4+PiANCj4+Pj4+Pj4gT24gMTEgT2N0IDIwMjEsIGF0IDExOjUxLCBSb2dlciBQ
YXUgTW9ubsOpIDxyb2dlci5wYXVAY2l0cml4LmNvbT4gd3JvdGU6DQo+Pj4+Pj4+IA0KPj4+Pj4+
PiBPbiBXZWQsIE9jdCAwNiwgMjAyMSBhdCAwNjo0MDozNFBNICswMTAwLCBSYWh1bCBTaW5naCB3
cm90ZToNCj4+Pj4+Pj4+IFRoZSBleGlzdGluZyBWUENJIHN1cHBvcnQgYXZhaWxhYmxlIGZvciBY
ODYgaXMgYWRhcHRlZCBmb3IgQXJtLg0KPj4+Pj4+Pj4gV2hlbiB0aGUgZGV2aWNlIGlzIGFkZGVk
IHRvIFhFTiB2aWEgdGhlIGh5cGVyIGNhbGwNCj4+Pj4+Pj4+IOKAnFBIWVNERVZPUF9wY2lfZGV2
aWNlX2FkZOKAnSwgVlBDSSBoYW5kbGVyIGZvciB0aGUgY29uZmlnIHNwYWNlDQo+Pj4+Pj4+PiBh
Y2Nlc3MgaXMgYWRkZWQgdG8gdGhlIFhlbiB0byBlbXVsYXRlIHRoZSBQQ0kgZGV2aWNlcyBjb25m
aWcgc3BhY2UuDQo+Pj4+Pj4+PiANCj4+Pj4+Pj4+IEEgTU1JTyB0cmFwIGhhbmRsZXIgZm9yIHRo
ZSBQQ0kgRUNBTSBzcGFjZSBpcyByZWdpc3RlcmVkIGluIFhFTg0KPj4+Pj4+Pj4gc28gdGhhdCB3
aGVuIGd1ZXN0IGlzIHRyeWluZyB0byBhY2Nlc3MgdGhlIFBDSSBjb25maWcgc3BhY2UsWEVODQo+
Pj4+Pj4+PiB3aWxsIHRyYXAgdGhlIGFjY2VzcyBhbmQgZW11bGF0ZSByZWFkL3dyaXRlIHVzaW5n
IHRoZSBWUENJIGFuZA0KPj4+Pj4+Pj4gbm90IHRoZSByZWFsIFBDSSBoYXJkd2FyZS4NCj4+Pj4+
Pj4+IA0KPj4+Pj4+Pj4gRm9yIERvbTBsZXNzIHN5c3RlbXMgc2Nhbl9wY2lfZGV2aWNlcygpIHdv
dWxkIGJlIHVzZWQgdG8gZGlzY292ZXIgdGhlDQo+Pj4+Pj4+PiBQQ0kgZGV2aWNlIGluIFhFTiBh
bmQgVlBDSSBoYW5kbGVyIHdpbGwgYmUgYWRkZWQgZHVyaW5nIFhFTiBib290cy4NCj4+Pj4+Pj4+
IA0KPj4+Pj4+Pj4gU2lnbmVkLW9mZi1ieTogUmFodWwgU2luZ2ggPHJhaHVsLnNpbmdoQGFybS5j
b20+DQo+Pj4+Pj4+PiBSZXZpZXdlZC1ieTogU3RlZmFubyBTdGFiZWxsaW5pIDxzc3RhYmVsbGlu
aUBrZXJuZWwub3JnPg0KPj4+Pj4+Pj4gLS0tDQo+Pj4+Pj4+PiBDaGFuZ2UgaW4gdjU6DQo+Pj4+
Pj4+PiAtIEFkZCBwY2lfY2xlYW51cF9tc2kocGRldikgaW4gY2xlYW51cCBwYXJ0Lg0KPj4+Pj4+
Pj4gLSBBZGRlZCBSZXZpZXdlZC1ieTogU3RlZmFubyBTdGFiZWxsaW5pIDxzc3RhYmVsbGluaUBr
ZXJuZWwub3JnPg0KPj4+Pj4+Pj4gQ2hhbmdlIGluIHY0Og0KPj4+Pj4+Pj4gLSBNb3ZlIGFkZGl0
aW9uIG9mIFhFTl9ET01DVExfQ0RGX3ZwY2kgZmxhZyB0byBzZXBhcmF0ZSBwYXRjaA0KPj4+Pj4+
Pj4gQ2hhbmdlIGluIHYzOg0KPj4+Pj4+Pj4gLSBVc2UgaXNfcGNpX3Bhc3N0aHJvdWdoX2VuYWJs
ZWQoKSBpbiBwbGFjZSBvZiBwY2lfcGFzc3Rocm91Z2hfZW5hYmxlZCB2YXJpYWJsZQ0KPj4+Pj4+
Pj4gLSBSZWplY3QgWEVOX0RPTUNUTF9DREZfdnBjaSBmb3IgeDg2IGluIGFyY2hfc2FuaXRpc2Vf
ZG9tYWluX2NvbmZpZygpDQo+Pj4+Pj4+PiAtIFJlbW92ZSBJU19FTkFCTEVEKENPTkZJR19IQVNf
VlBDSSkgZnJvbSBoYXNfdnBjaSgpDQo+Pj4+Pj4+PiBDaGFuZ2UgaW4gdjI6DQo+Pj4+Pj4+PiAt
IEFkZCBuZXcgWEVOX0RPTUNUTF9DREZfdnBjaSBmbGFnDQo+Pj4+Pj4+PiAtIG1vZGlmeSBoYXNf
dnBjaSgpIHRvIGluY2x1ZGUgWEVOX0RPTUNUTF9DREZfdnBjaQ0KPj4+Pj4+Pj4gLSBlbmFibGUg
dnBjaSBzdXBwb3J0IHdoZW4gcGNpLXBhc3N0aG91Z2ggb3B0aW9uIGlzIGVuYWJsZWQuDQo+Pj4+
Pj4+PiAtLS0NCj4+Pj4+Pj4+IC0tLQ0KPj4+Pj4+Pj4geGVuL2FyY2gvYXJtL01ha2VmaWxlICAg
ICAgICAgfCAgIDEgKw0KPj4+Pj4+Pj4geGVuL2FyY2gvYXJtL2RvbWFpbi5jICAgICAgICAgfCAg
IDQgKysNCj4+Pj4+Pj4+IHhlbi9hcmNoL2FybS9kb21haW5fYnVpbGQuYyAgIHwgICAzICsNCj4+
Pj4+Pj4+IHhlbi9hcmNoL2FybS92cGNpLmMgICAgICAgICAgIHwgMTAyICsrKysrKysrKysrKysr
KysrKysrKysrKysrKysrKysrKysNCj4+Pj4+Pj4+IHhlbi9hcmNoL2FybS92cGNpLmggICAgICAg
ICAgIHwgIDM2ICsrKysrKysrKysrKw0KPj4+Pj4+Pj4geGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gv
cGNpLmMgfCAgMTggKysrKysrDQo+Pj4+Pj4+PiB4ZW4vaW5jbHVkZS9hc20tYXJtL2RvbWFpbi5o
ICB8ICAgNyArKy0NCj4+Pj4+Pj4+IHhlbi9pbmNsdWRlL2FzbS14ODYvcGNpLmggICAgIHwgICAy
IC0NCj4+Pj4+Pj4+IHhlbi9pbmNsdWRlL3B1YmxpYy9hcmNoLWFybS5oIHwgICA3ICsrKw0KPj4+
Pj4+Pj4geGVuL2luY2x1ZGUveGVuL3BjaS5oICAgICAgICAgfCAgIDIgKw0KPj4+Pj4+Pj4gMTAg
ZmlsZXMgY2hhbmdlZCwgMTc5IGluc2VydGlvbnMoKyksIDMgZGVsZXRpb25zKC0pDQo+Pj4+Pj4+
PiBjcmVhdGUgbW9kZSAxMDA2NDQgeGVuL2FyY2gvYXJtL3ZwY2kuYw0KPj4+Pj4+Pj4gY3JlYXRl
IG1vZGUgMTAwNjQ0IHhlbi9hcmNoL2FybS92cGNpLmgNCj4+Pj4+Pj4+IA0KPj4+Pj4+Pj4gZGlm
ZiAtLWdpdCBhL3hlbi9hcmNoL2FybS9NYWtlZmlsZSBiL3hlbi9hcmNoL2FybS9NYWtlZmlsZQ0K
Pj4+Pj4+Pj4gaW5kZXggNDRkN2NjODFmYS4uZmI5Yzk3NmVhMiAxMDA2NDQNCj4+Pj4+Pj4+IC0t
LSBhL3hlbi9hcmNoL2FybS9NYWtlZmlsZQ0KPj4+Pj4+Pj4gKysrIGIveGVuL2FyY2gvYXJtL01h
a2VmaWxlDQo+Pj4+Pj4+PiBAQCAtNyw2ICs3LDcgQEAgaWZuZXEgKCQoQ09ORklHX05PX1BMQVQp
LHkpDQo+Pj4+Pj4+PiBvYmoteSArPSBwbGF0Zm9ybXMvDQo+Pj4+Pj4+PiBlbmRpZg0KPj4+Pj4+
Pj4gb2JqLSQoQ09ORklHX1RFRSkgKz0gdGVlLw0KPj4+Pj4+Pj4gK29iai0kKENPTkZJR19IQVNf
VlBDSSkgKz0gdnBjaS5vDQo+Pj4+Pj4+PiANCj4+Pj4+Pj4+IG9iai0kKENPTkZJR19IQVNfQUxU
RVJOQVRJVkUpICs9IGFsdGVybmF0aXZlLm8NCj4+Pj4+Pj4+IG9iai15ICs9IGJvb3RmZHQuaW5p
dC5vDQo+Pj4+Pj4+PiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gvYXJtL2RvbWFpbi5jIGIveGVuL2Fy
Y2gvYXJtL2RvbWFpbi5jDQo+Pj4+Pj4+PiBpbmRleCAzNjEzOGMxYjJlLi5mYmI1MmY3OGYxIDEw
MDY0NA0KPj4+Pj4+Pj4gLS0tIGEveGVuL2FyY2gvYXJtL2RvbWFpbi5jDQo+Pj4+Pj4+PiArKysg
Yi94ZW4vYXJjaC9hcm0vZG9tYWluLmMNCj4+Pj4+Pj4+IEBAIC0zOSw2ICszOSw3IEBADQo+Pj4+
Pj4+PiAjaW5jbHVkZSA8YXNtL3ZnaWMuaD4NCj4+Pj4+Pj4+ICNpbmNsdWRlIDxhc20vdnRpbWVy
Lmg+DQo+Pj4+Pj4+PiANCj4+Pj4+Pj4+ICsjaW5jbHVkZSAidnBjaS5oIg0KPj4+Pj4+Pj4gI2lu
Y2x1ZGUgInZ1YXJ0LmgiDQo+Pj4+Pj4+PiANCj4+Pj4+Pj4+IERFRklORV9QRVJfQ1BVKHN0cnVj
dCB2Y3B1ICosIGN1cnJfdmNwdSk7DQo+Pj4+Pj4+PiBAQCAtNzY3LDYgKzc2OCw5IEBAIGludCBh
cmNoX2RvbWFpbl9jcmVhdGUoc3RydWN0IGRvbWFpbiAqZCwNCj4+Pj4+Pj4+ICAgICBpZiAoIGlz
X2hhcmR3YXJlX2RvbWFpbihkKSAmJiAocmMgPSBkb21haW5fdnVhcnRfaW5pdChkKSkgKQ0KPj4+
Pj4+Pj4gICAgICAgICBnb3RvIGZhaWw7DQo+Pj4+Pj4+PiANCj4+Pj4+Pj4+ICsgICAgaWYgKCAo
cmMgPSBkb21haW5fdnBjaV9pbml0KGQpKSAhPSAwICkNCj4+Pj4+Pj4+ICsgICAgICAgIGdvdG8g
ZmFpbDsNCj4+Pj4+Pj4+ICsNCj4+Pj4+Pj4+ICAgICByZXR1cm4gMDsNCj4+Pj4+Pj4+IA0KPj4+
Pj4+Pj4gZmFpbDoNCj4+Pj4+Pj4+IGRpZmYgLS1naXQgYS94ZW4vYXJjaC9hcm0vZG9tYWluX2J1
aWxkLmMgYi94ZW4vYXJjaC9hcm0vZG9tYWluX2J1aWxkLmMNCj4+Pj4+Pj4+IGluZGV4IGM1YWZi
ZTJlMDUuLmY0Yzg5YmRlOGMgMTAwNjQ0DQo+Pj4+Pj4+PiAtLS0gYS94ZW4vYXJjaC9hcm0vZG9t
YWluX2J1aWxkLmMNCj4+Pj4+Pj4+ICsrKyBiL3hlbi9hcmNoL2FybS9kb21haW5fYnVpbGQuYw0K
Pj4+Pj4+Pj4gQEAgLTMwNTMsNiArMzA1Myw5IEBAIHZvaWQgX19pbml0IGNyZWF0ZV9kb20wKHZv
aWQpDQo+Pj4+Pj4+PiAgICAgaWYgKCBpb21tdV9lbmFibGVkICkNCj4+Pj4+Pj4+ICAgICAgICAg
ZG9tMF9jZmcuZmxhZ3MgfD0gWEVOX0RPTUNUTF9DREZfaW9tbXU7DQo+Pj4+Pj4+PiANCj4+Pj4+
Pj4+ICsgICAgaWYgKCBpc19wY2lfcGFzc3Rocm91Z2hfZW5hYmxlZCgpICkNCj4+Pj4+Pj4+ICsg
ICAgICAgIGRvbTBfY2ZnLmZsYWdzIHw9IFhFTl9ET01DVExfQ0RGX3ZwY2k7DQo+Pj4+Pj4+IEkg
dGhpbmsgSSdtIGNvbmZ1c2VkIHdpdGggdGhpcy4gWW91IHNlZW0gdG8gZW5hYmxlIHZQQ0kgZm9y
IGRvbTAsIGJ1dA0KPj4+Pj4+PiB0aGVuIGRvbWFpbl92cGNpX2luaXQgd2lsbCBzZXR1cCB0cmFw
cyBmb3IgdGhlIGd1ZXN0IHZpcnR1YWwgRUNBTQ0KPj4+Pj4+PiBsYXlvdXQsIG5vdCB0aGUgbmF0
aXZlIG9uZSB0aGF0IGRvbTAgd2lsbCBiZSB1c2luZy4NCj4+Pj4+PiBJIHRoaW5rIGFmdGVyIHRo
ZSBsYXN0IGRpc2N1c3Npb25zLCBpdCB3YXMgZGVjaWRlZCB0byBhbHNvIGluc3RhbGxlZCB0aGUg
dnBjaQ0KPj4+Pj4+IGhhbmRsZXIgZm9yIGRvbTAuIEkgd2lsbCBoYXZlIHRvIGxvb2sgaW50byB0
aGlzIGFuZCBjb21lIGJhY2sgdG8geW91Lg0KPj4+Pj4+IEBPbGVrc2FuZHI6IENvdWxkIHlvdSBj
b21tZW50IG9uIHRoaXMuDQo+Pj4+PiBZZXMsIHdlIGRvIHRyYXAgRG9tMCBhcyB3ZWxsLiBUaGUg
RG9tMCB0cmFwcyBhcmUgbm90IGluIHRoaXMgc2VyaWVzLCBidXQNCj4+Pj4+IGFyZSBpbiBtaW5l
IGFzIGl0IG5lZWRzIG1vcmUgcHJlcGFyYXRvcnkgd29yayBmb3IgdGhhdC4gUGxlYXNlIHNlZSBb
MV0NCj4+Pj4gVGhlbiBJIGRvbid0IHRoaW5rIHdlIHNob3VsZCBzZXQgWEVOX0RPTUNUTF9DREZf
dnBjaSBmb3IgZG9tMCBoZXJlLCBpdA0KPj4+PiBzaG91bGQgaW5zdGVhZCBiZSBkb25lIGluIHRo
ZSBwYXRjaCB3aGVyZSBkb20wIHN1cHBvcnQgaXMgaW50cm9kdWNlZC4NCj4+PiBPayBJIHdpbGwg
Y2hlY2sgdG8gcmVtb3ZlIHRoaXMgYW5kIGluY2x1ZGUgdGhlIGNoYW5nZSBpbiB2Ni4NCj4+IEp1
c3QgdG8gbWFrZSBpdCBjbGVhcjogZG8gd2Ugd2FudCB0byByZW1vdmUgdGhpcyBwaWVjZSBmcm9t
IHRoaXMgcGF0Y2gNCj4+IGFuZCBpbnN0ZWFkIGhhdmUgYSBkZWRpY2F0ZWQgcGF0Y2ggb24gdG9w
IG9mIG15IHNlcmllcywgc28gaXQgaXMgZW5hYmxlZA0KPj4gcmlnaHQgYWZ0ZXIgd2UgaGF2ZSB0
aGUgY29kZSB0aGF0IHNldHMgdXAgdGhlIHRyYXAgaGFuZGxlcnMgZm9yIERvbTA/DQo+PiBJZiBz
bywgdGhlbiBkbyB3ZSB3YW50IHRoYXQgcGF0Y2ggdG8gYmUgY2hhaW5lZCBpbiBteSBzZXJpZXMg
b3Igc2VudCBhcw0KPj4gYSBmb2xsb3cgdXAgcmlnaHQgYWZ0ZXIgaXQgc2VwYXJhdGVseT8NCj4g
DQo+IEkgdGhpbmsgd2Ugd2FudCB0byByZW1vdmUgdGhlIFhFTl9ET01DVExfQ0RGX3ZwY2kgY2h1
bmsgZnJvbSB0aGlzIHBhdGNoLg0KPiANCj4gV2hlcmUgZXhhY3RseSBpdCBzaG91bGQgYmUgaW50
cm9kdWNlZCwgSSBhbSBub3Qgc3VyZS4gSSB0aGluayBpdCB3b3VsZA0KPiBiZSBPSyBhcyBhIHNl
cGFyYXRlIHNpbmdsZSBwYXRjaCBhdCB0aGUgZW5kLiBJIGRvZXNuJ3QgaGF2ZSB0byBiZSBwYXJ0
DQo+IG9mIHRoZSBvdXRzdGFuZGluZyBzZXJpZXMsIGNvbnNpZGVyaW5nIHRoYXQgd2UgYXJlIGFs
c28gbWlzc2luZyB0aGUNCj4gcGF0Y2ggdG8gYWRkICJzZWxlY3QgSEFTX1BDSSIgZm9yIEFSTS4N
Cg0KQWdyZWUsIEkgd2lsbCByZW1vdmUgdGhhdCBmcm9tIHY2Lg0KDQpDaGVlcnMNCkJlcnRyYW5k
DQoNCg0K


From xen-devel-bounces@lists.xenproject.org Tue Oct 12 07:50:51 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 07:50:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.206822.362478 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maCYi-0003SX-52; Tue, 12 Oct 2021 07:50:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 206822.362478; Tue, 12 Oct 2021 07:50:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maCYi-0003SQ-1k; Tue, 12 Oct 2021 07:50:48 +0000
Received: by outflank-mailman (input) for mailman id 206822;
 Tue, 12 Oct 2021 07:50:46 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=B8jq=PA=arm.com=Bertrand.Marquis@srs-us1.protection.inumbo.net>)
 id 1maCYg-0003SK-LW
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 07:50:46 +0000
Received: from EUR03-AM5-obe.outbound.protection.outlook.com (unknown
 [2a01:111:f400:fe08::620])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 9cafddc9-e57d-424a-81c3-3a6a395459f5;
 Tue, 12 Oct 2021 07:50:44 +0000 (UTC)
Received: from AM5PR0701CA0023.eurprd07.prod.outlook.com
 (2603:10a6:203:51::33) by AM8PR08MB6500.eurprd08.prod.outlook.com
 (2603:10a6:20b:361::22) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.19; Tue, 12 Oct
 2021 07:50:42 +0000
Received: from VE1EUR03FT059.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:203:51:cafe::f9) by AM5PR0701CA0023.outlook.office365.com
 (2603:10a6:203:51::33) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.4 via Frontend
 Transport; Tue, 12 Oct 2021 07:50:42 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT059.mail.protection.outlook.com (10.152.19.60) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4587.18 via Frontend Transport; Tue, 12 Oct 2021 07:50:42 +0000
Received: ("Tessian outbound 2e7020cc8961:v103");
 Tue, 12 Oct 2021 07:50:42 +0000
Received: from e4ee606929fe.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 E4D67BB3-C886-46B3-B6B0-0A5E556C1022.1; 
 Tue, 12 Oct 2021 07:50:33 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id e4ee606929fe.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Tue, 12 Oct 2021 07:50:33 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com (10.168.85.9) by
 DB6PR0802MB2183.eurprd08.prod.outlook.com (10.172.227.17) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4587.25; Tue, 12 Oct 2021 07:50:28 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955]) by DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955%4]) with mapi id 15.20.4587.026; Tue, 12 Oct 2021
 07:50:28 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9cafddc9-e57d-424a-81c3-3a6a395459f5
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=fd/TmEEpvopj+oO/GFKbzPRWMuThwOAMH+YnNav0ij8=;
 b=kAV9Xh1Dvp4ArxI2RlvethFcoUYPQKKGpGa15ZNwrOMoa0YO0nPoFCzJ7pagLcIvPWLb6RtqUXnpwcg3Haf6l5rJbbtqt+Ek6EYjegJAqBZoREqFmZwkUeghDPOBKWQLb2RPQI1jb8ifBZMd5SjbkyC5rAXCNYa4rUZpXARIrTA=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 25d7895c4c4e2104
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=UI+o7MIuCILiQR7MRprx015pbqM93dfpzN5UYHQKS2ck1T/Wqbn8DeSgEh5pOLqDCa9t8MuTw37W1/zBEUKhVLja4U9RHLC2K3SkLOvWpGebpLcyAX+sqk3Cml/8z8a0BvX5ZCSo5BjE8c2Bdxm9fVkT3veYUZk0IKHaIv+0g7HuhJw/tD0ybRu6PeZZEVJBKu06XcAZOncfI6+t2/FN4GqQOiXtJYg1cQ1ftzmjrdq1u6ko/VBTBh5pk2FA39sLGq30HyBiZ3VTlhxb1zHPWf1U8nvZ1wqHVMtdXwhBQGiXDkH5D3j3Rs/D+AgJCzrRkgt170H12Tu/c2DSqpir1A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=fd/TmEEpvopj+oO/GFKbzPRWMuThwOAMH+YnNav0ij8=;
 b=jU3VXmeZe1Ly6WGKG5nlHsnu/jjv0iqTlkptuPhBq3/2Ct/8TKGIOWSOqQ4rIQYf/rmf08tZIydVuliC3f0udAREHyavbj17cokitci4auEdbg8Zmhh/sp4LaeJbwwYy4ykLh33RREfYsOaYvBhnAs7IJmdP+5NrWjO8QyFpj0S4waBBNITprSnORM8xkA4qxHFkQT2C9y+qpeSFD5WYuAnXnlbldzXnFqI01aTK3BcltuFi4sds7PWiWwhhyW9MiE7J3p39uCxP/C5Bp+mT/yKMhz1i5dXhcxlEa3GkyUjG1DPGqljN/WOaBtu8xJzf+IkFJHi9/nzvMqlVRVRQQA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=fd/TmEEpvopj+oO/GFKbzPRWMuThwOAMH+YnNav0ij8=;
 b=kAV9Xh1Dvp4ArxI2RlvethFcoUYPQKKGpGa15ZNwrOMoa0YO0nPoFCzJ7pagLcIvPWLb6RtqUXnpwcg3Haf6l5rJbbtqt+Ek6EYjegJAqBZoREqFmZwkUeghDPOBKWQLb2RPQI1jb8ifBZMd5SjbkyC5rAXCNYa4rUZpXARIrTA=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Luca Fancellu <Luca.Fancellu@arm.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>, Wei Chen <Wei.Chen@arm.com>,
	Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, Andrew Cooper
	<andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>, Ian
 Jackson <iwj@xenproject.org>, Jan Beulich <jbeulich@suse.com>, Wei Liu
	<wl@xen.org>
Subject: Re: [PATCH v6 1/2] arm/efi: Use dom0less configuration when using EFI
 boot
Thread-Topic: [PATCH v6 1/2] arm/efi: Use dom0less configuration when using
 EFI boot
Thread-Index: AQHXvswUDRnPxVunP0m5apMrxxAb46vO/gyA
Date: Tue, 12 Oct 2021 07:50:28 +0000
Message-ID: <4844DB91-CFE2-4CD7-B3CA-62DDAB171F3F@arm.com>
References: <20211011181528.17367-1-luca.fancellu@arm.com>
 <20211011181528.17367-2-luca.fancellu@arm.com>
In-Reply-To: <20211011181528.17367-2-luca.fancellu@arm.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3654.120.0.1.13)
Authentication-Results-Original: arm.com; dkim=none (message not signed)
 header.d=none;arm.com; dmarc=none action=none header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: 2d6aba37-afbd-43fe-c237-08d98d54fddd
x-ms-traffictypediagnostic: DB6PR0802MB2183:|AM8PR08MB6500:
x-ms-exchange-transport-forked: True
X-Microsoft-Antispam-PRVS:
	<AM8PR08MB6500C2AB7CB57ABF242DEBCE9DB69@AM8PR08MB6500.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:151;OLM:151;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 6Tw98ZEXCB2oIBcpgZMvnZAB+7nuRluygtiM6ml135EX9q3DT+PdWObFRdQ//rwpiHxhDljHdh3X1BP+9aSglCd3LOsULC5laMZ/c7zty70+5x8tc6L7oRszmADbbhsj3A3qm190vICbmdlDRDjZozdXCuBV2s+buImSaK7AO7yPgYcXhlulBkXaOKBrbjp/t7cRxvOn+anUyRMVntry8/S9N6jhAh6KGAo8/kQJUMC2YVj9/Wk3aBH7yBD908e9wTCEC7FpvM34dQoCoXcxlB7G/oQhu/6ODqxP9NGLrb54ZTHbyjPt7Uj+AArgXTvXsPsI3mbG66brjO6Pz18WIGGzigHW/rQmJI+BqBTrHt9SZx6hrF/pXJy9Ggn50dQa+aRaCv4uLhDZib+x7elshaPWaNVYeOUd65YVlgpNVLmUFi4oMX19rBK5nvrv+0yFOjaTPjPl6aN9+SCtDxDc14J8gFsfRxaPUq+9Sl3ZTo6bpd30aE9Et0OAKK19VyfZffq3r4NMnFVwpqWPcl3gqW077l9s/4TsYgOhmnuXyAgOGzmMnX9IjuYEaR/WWMYcl6dWxBxtDxTHjViFA2xI+xZlvUVtgL6YaZjhYTgLpH5vi/i7fsJ0NHvUoHsS05nuV6uHUcJLea0vpG9vkOj4RHTdwfXk1eNs0lZPSqNn+4o+qu6Dbp0cG+NMZn77S1qa2KXXAOd07nLKz3qYjMf2EiZfBg27GQOwHZETbSwdD5ftjpD1p78NRQzER0Ugfpq8eitHHl2l/TMdW3m17kYvWcjcdLDujxlhQNwGwukEAGA=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB6PR0801MB2024.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(6862004)(66556008)(86362001)(54906003)(2906002)(33656002)(316002)(30864003)(66476007)(36756003)(37006003)(64756008)(76116006)(66946007)(6512007)(508600001)(2616005)(91956017)(186003)(66446008)(6486002)(6506007)(71200400001)(38070700005)(53546011)(5660300002)(6636002)(8676002)(26005)(83380400001)(8936002)(38100700002)(122000001)(4326008)(21314003)(32563001)(45980500001)(559001)(579004);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="us-ascii"
Content-ID: <45CD47301E4ED346A1088FD2CED036E9@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0802MB2183
Original-Authentication-Results: arm.com; dkim=none (message not signed)
 header.d=none;arm.com; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT059.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	c67b17cc-1033-4992-22cc-08d98d54f55a
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	/Gy4SxSUaWiF6LEQ9b39JaB9oj8im+krIGyiOCbPCegj89nXFpYh64S2/Da7xrcQti63vAT3EmqXLbxqbT1ChQybGgRfKuYKjDMOtYr+sNHDw49vqROp7lxmmQVAzuXdWrtWbLtpB/61Sl6EMvm0zKdBJ7lLX07TK+HT1J7Fki1rOJ0oiDpj/BCojmjUrCFDsRDzxClBSSk/2WMMdIVMysH6M+fNP99/JGFG+gMuFNF9Bqg7r6aq7whZ+WLpHaBL3qjabKK9PG4aegyf68NLTbmYvg+M3KsqduCV6XSvtvCCt0dkIUbjm74FL8tIU6JDoyIUik8WuhkAYqcWKACqUQxMH7hREgEni2H/PnkLQ0oe/k3U20Dh22n8ST6mUXjTYE6S8qHk6h91Rb0ylNBrpp5fBQ4m2YlDdB5ykCN8NVWfWAPRJ1+xQ1rFGszWdyMt94h0tPbNFW8CXRnYOvc4CBIVkHX6m8PAb3W+rxZDHg3eW9fp403suOFJmS78oghDizDAwDCy+txQQrBrIauginTILU8BJ7MjclH53hBSHUjqIxR3vpUWRBQif1V6YmAB0YLz70y8z/jBYsU63kul/MBk4aPfirsGChaP1oLLAFF1cuVRwAd/AxbrvzkKpIcT0XLnRJIyfw7DZPyMbISz2cjr13t7u3Q6VPZJIY7sMrCW1EgFrEu714dMJbE+0qDsOVlO5zU522RDoP491ijDa4fMA3sMrFmYI/IOTKFucCe4g7FWYceB2huEhEOh+ID2
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(36860700001)(356005)(47076005)(4326008)(81166007)(54906003)(86362001)(316002)(508600001)(5660300002)(33656002)(26005)(6512007)(6636002)(6506007)(37006003)(53546011)(6486002)(6862004)(36756003)(8936002)(336012)(70586007)(82310400003)(83380400001)(2616005)(70206006)(186003)(2906002)(30864003)(8676002)(21314003)(32563001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2021 07:50:42.4134
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 2d6aba37-afbd-43fe-c237-08d98d54fddd
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT059.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB6500

Hi Luca,

> On 11 Oct 2021, at 19:15, Luca Fancellu <Luca.Fancellu@arm.com> wrote:
>=20
> This patch introduces the support for dom0less configuration
> when using UEFI boot on ARM, it permits the EFI boot to
> continue if no dom0 kernel is specified but at least one domU
> is found.
>=20
> Introduce the new property "xen,uefi-binary" for device tree boot
> module nodes that are subnode of "xen,domain" compatible nodes.
> The property holds a string containing the file name of the
> binary that shall be loaded by the uefi loader from the filesystem.
>=20
> Introduce a new call efi_check_dt_boot(...) called during EFI boot
> that checks for module to be loaded using device tree.
> Architectures that don't support device tree don't have to
> provide this function.
>=20
> Update efi documentation about how to start a dom0less
> setup using UEFI
>=20
> Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>

Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>

Cheers
Bertrand

> ---
> Changes in v6:
> - change is_boot_module() to check for every multiboot,module
> instead of multiboot,{kernel,ramdisk,device-tree} (Julien), as
> a result of that remove the function and put the check inside of
> handle_module_node(...)
> Changes in v5:
> - Removed unneeded variable initialization
> - Fixed comment
> - Fixed error message for the absence of an initial domain kernel
> - changed efi_arch_check_dt_boot to efi_check_dt_boot and add
> a stub if CONFIG_HAS_DEVICE_TREE is not declared, updated commit
> message about the call introduction in the EFI boot flow.
> Changes in v4:
> - update uefi,cfg-load to xen,uefi-cfg-load in documentation
> - fixed comments and code style
> - changed variable name from dt_module_found to dt_modules_found
> in boot.c
> - removed stub efi_arch_check_dt_boot from x86 code because the
> architecture does not support DT, protected call with #ifdef
> in the common code.
> - add comment to explain the result from efi_arch_check_dt_boot
> just looking the common code
> - Add space before comment in boot.c
> - renamed uefi,binary property to xen,uefi-binary
> Changes in v3:
> - fixed documentation
> - fixed name len in strlcpy
> - fixed some style issues
> - closed filesystem handle before calling blexit
> - passed runtime errors up to the stack instead
> of calling blexit
> - renamed names and function to make them more
> general in prevision to load also Dom0 kernel
> and ramdisk from DT
> Changes in v2:
> - remove array of struct file
> - fixed some int types
> - Made the code use filesystem even when configuration
> file is skipped.
> - add documentation of uefi,binary in booting.txt
> - add documentation on how to boot all configuration
> for Xen using UEFI in efi.pandoc
> ---
> docs/misc/arm/device-tree/booting.txt |  21 ++
> docs/misc/efi.pandoc                  | 203 +++++++++++++++++
> xen/arch/arm/efi/efi-boot.h           | 299 +++++++++++++++++++++++++-
> xen/common/efi/boot.c                 |  39 +++-
> 4 files changed, 550 insertions(+), 12 deletions(-)
>=20
> diff --git a/docs/misc/arm/device-tree/booting.txt b/docs/misc/arm/device=
-tree/booting.txt
> index 352b0ec43a..7258e7e1ec 100644
> --- a/docs/misc/arm/device-tree/booting.txt
> +++ b/docs/misc/arm/device-tree/booting.txt
> @@ -190,6 +190,13 @@ The kernel sub-node has the following properties:
>=20
>     Command line parameters for the guest kernel.
>=20
> +- xen,uefi-binary (UEFI boot only)
> +
> +    String property that specifies the file name to be loaded by the UEF=
I boot
> +    for this module. If this is specified, there is no need to specify t=
he reg
> +    property because it will be created by the UEFI stub on boot.
> +    This option is needed only when UEFI boot is used.
> +
> The ramdisk sub-node has the following properties:
>=20
> - compatible
> @@ -201,6 +208,13 @@ The ramdisk sub-node has the following properties:
>     Specifies the physical address of the ramdisk in RAM and its
>     length.
>=20
> +- xen,uefi-binary (UEFI boot only)
> +
> +    String property that specifies the file name to be loaded by the UEF=
I boot
> +    for this module. If this is specified, there is no need to specify t=
he reg
> +    property because it will be created by the UEFI stub on boot.
> +    This option is needed only when UEFI boot is used.
> +
>=20
> Example
> =3D=3D=3D=3D=3D=3D=3D
> @@ -265,6 +279,13 @@ The dtb sub-node should have the following propertie=
s:
>     Specifies the physical address of the device tree binary fragment
>     RAM and its length.
>=20
> +- xen,uefi-binary (UEFI boot only)
> +
> +    String property that specifies the file name to be loaded by the UEF=
I boot
> +    for this module. If this is specified, there is no need to specify t=
he reg
> +    property because it will be created by the UEFI stub on boot.
> +    This option is needed only when UEFI boot is used.
> +
> As an example:
>=20
>         module@0xc000000 {
> diff --git a/docs/misc/efi.pandoc b/docs/misc/efi.pandoc
> index ed85351541..876cd55005 100644
> --- a/docs/misc/efi.pandoc
> +++ b/docs/misc/efi.pandoc
> @@ -167,3 +167,206 @@ sbsign \
> 	--output xen.signed.efi \
> 	xen.unified.efi
> ```
> +
> +## UEFI boot and dom0less on ARM
> +
> +Dom0less feature is supported by ARM and it is possible to use it when X=
en is
> +started as an EFI application.
> +The way to specify the domU domains is by Device Tree as specified in th=
e
> +[dom0less](dom0less.html) documentation page under the "Device Tree
> +configuration" section, but instead of declaring the reg property in the=
 boot
> +module, the user must specify the "xen,uefi-binary" property containing =
the name
> +of the binary file that has to be loaded in memory.
> +The UEFI stub will load the binary in memory and it will add the reg pro=
perty
> +accordingly.
> +
> +An example here:
> +
> +domU1 {
> +	#address-cells =3D <1>;
> +	#size-cells =3D <1>;
> +	compatible =3D "xen,domain";
> +	memory =3D <0 0x20000>;
> +	cpus =3D <1>;
> +	vpl011;
> +
> +	module@1 {
> +		compatible =3D "multiboot,kernel", "multiboot,module";
> +		xen,uefi-binary =3D "vmlinuz-3.0.31-0.4-xen";
> +		bootargs =3D "console=3DttyAMA0";
> +	};
> +	module@2 {
> +		compatible =3D "multiboot,ramdisk", "multiboot,module";
> +		xen,uefi-binary =3D "initrd-3.0.31-0.4-xen";
> +	};
> +	module@3 {
> +		compatible =3D "multiboot,ramdisk", "multiboot,module";
> +		xen,uefi-binary =3D "passthrough.dtb";
> +	};
> +};
> +
> +## How to boot different Xen setup using UEFI
> +
> +These are the different ways to boot a Xen system from UEFI:
> +
> + - Boot Xen and Dom0 (minimum required)
> + - Boot Xen and DomU(s) (true dom0less, only on ARM)
> + - Boot Xen, Dom0 and DomU(s) (only on ARM)
> +
> +### Boot Xen and Dom0
> +
> +This configuration can be started using the Xen configuration file in th=
e
> +example above.
> +
> +### Boot Xen and DomU(s)
> +
> +This configuration needs the domU domain(s) specified in the /chosen nod=
e,
> +examples of how to do that are provided by the documentation about dom0l=
ess
> +and the example above shows how to use the "xen,uefi-binary" property to=
 use the
> +UEFI stub for module loading.
> +When adding DomU modules to device tree, also add the property
> +xen,uefi-cfg-load under chosen for Xen to load the Xen config file.
> +Otherwise, Xen will skip the config file and rely on device tree alone.
> +
> +Example 1 of how to boot a true dom0less configuration:
> +
> +Xen configuration file: skipped.
> +
> +Device tree:
> +
> +```
> +chosen {
> +	#size-cells =3D <0x1>;
> +	#address-cells =3D <0x1>;
> +	xen,xen-bootargs =3D "<Xen command line>"
> +
> +	domU1 {
> +		#size-cells =3D <0x1>;
> +		#address-cells =3D <0x1>;
> +		compatible =3D "xen,domain";
> +		cpus =3D <0x1>;
> +		memory =3D <0x0 0xc0000>;
> +		vpl011;
> +
> +		module@1 {
> +			compatible =3D "multiboot,kernel", "multiboot,module";
> +			xen,uefi-binary =3D "Image-domu1.bin";
> +			bootargs =3D "console=3DttyAMA0 root=3D/dev/ram0 rw";
> +		};
> +	};
> +	domU2 {
> +		#size-cells =3D <0x1>;
> +		#address-cells =3D <0x1>;
> +		compatible =3D "xen,domain";
> +		cpus =3D <0x1>;
> +		memory =3D <0x0 0x100000>;
> +		vpl011;
> +
> +		module@2 {
> +			compatible =3D "multiboot,kernel", "multiboot,module";
> +			xen,uefi-binary =3D "Image-domu2.bin";
> +			bootargs =3D "console=3DttyAMA0 root=3D/dev/ram0 rw";
> +		};
> +	};
> +};
> +```
> +
> +Example 2 of how to boot a true dom0less configuration:
> +
> +Xen configuration file:
> +
> +```
> +[global]
> +default=3Dxen
> +
> +[xen]
> +options=3D<Xen command line>
> +dtb=3D<optional DTB>
> +```
> +
> +Device tree:
> +
> +```
> +chosen {
> +	#size-cells =3D <0x1>;
> +	#address-cells =3D <0x1>;
> +	xen,uefi-cfg-load;
> +
> +	domU1 {
> +		#size-cells =3D <0x1>;
> +		#address-cells =3D <0x1>;
> +		compatible =3D "xen,domain";
> +		cpus =3D <0x1>;
> +		memory =3D <0x0 0xc0000>;
> +		vpl011;
> +
> +		module@1 {
> +			compatible =3D "multiboot,kernel", "multiboot,module";
> +			xen,uefi-binary =3D "Image-domu1.bin";
> +			bootargs =3D "console=3DttyAMA0 root=3D/dev/ram0 rw";
> +		};
> +	};
> +	domU2 {
> +		#size-cells =3D <0x1>;
> +		#address-cells =3D <0x1>;
> +		compatible =3D "xen,domain";
> +		cpus =3D <0x1>;
> +		memory =3D <0x0 0x100000>;
> +		vpl011;
> +
> +		module@2 {
> +			compatible =3D "multiboot,kernel", "multiboot,module";
> +			xen,uefi-binary =3D "Image-domu2.bin";
> +			bootargs =3D "console=3DttyAMA0 root=3D/dev/ram0 rw";
> +		};
> +	};
> +};
> +```
> +
> +### Boot Xen, Dom0 and DomU(s)
> +
> +This configuration is a mix of the two configuration above, to boot this=
 one
> +the configuration file must be processed so the /chosen node must have t=
he
> +"xen,uefi-cfg-load" property.
> +
> +Here an example:
> +
> +Xen configuration file:
> +
> +```
> +[global]
> +default=3Dxen
> +
> +[xen]
> +options=3D<Xen command line>
> +kernel=3Dvmlinuz-3.0.31-0.4-xen [domain 0 command line options]
> +ramdisk=3Dinitrd-3.0.31-0.4-xen
> +dtb=3D<optional DTB>
> +```
> +
> +Device tree:
> +
> +```
> +chosen {
> +	#size-cells =3D <0x1>;
> +	#address-cells =3D <0x1>;
> +	xen,uefi-cfg-load;
> +
> +	domU1 {
> +		#size-cells =3D <0x1>;
> +		#address-cells =3D <0x1>;
> +		compatible =3D "xen,domain";
> +		cpus =3D <0x1>;
> +		memory =3D <0x0 0xc0000>;
> +		vpl011;
> +
> +		module@1 {
> +			compatible =3D "multiboot,kernel", "multiboot,module";
> +			xen,uefi-binary =3D "Image-domu1.bin";
> +			bootargs =3D "console=3DttyAMA0 root=3D/dev/ram0 rw";
> +		};
> +	};
> +};
> +```
> +
> +
> diff --git a/xen/arch/arm/efi/efi-boot.h b/xen/arch/arm/efi/efi-boot.h
> index a3e46453d4..f35e035b22 100644
> --- a/xen/arch/arm/efi/efi-boot.h
> +++ b/xen/arch/arm/efi/efi-boot.h
> @@ -8,9 +8,49 @@
> #include <asm/setup.h>
> #include <asm/smp.h>
>=20
> +typedef struct {
> +    char *name;
> +    unsigned int name_len;
> +    EFI_PHYSICAL_ADDRESS addr;
> +    UINTN size;
> +} module_name;
> +
> +/*
> + * Binaries will be translated into bootmodules, the maximum number for =
them is
> + * MAX_MODULES where we should remove a unit for Xen and one for Xen DTB
> + */
> +#define MAX_UEFI_MODULES (MAX_MODULES - 2)
> +static struct file __initdata module_binary;
> +static module_name __initdata modules[MAX_UEFI_MODULES];
> +static unsigned int __initdata modules_available =3D MAX_UEFI_MODULES;
> +static unsigned int __initdata modules_idx;
> +
> +#define ERROR_BINARY_FILE_NOT_FOUND (-1)
> +#define ERROR_ALLOC_MODULE_NO_SPACE (-1)
> +#define ERROR_ALLOC_MODULE_NAME     (-2)
> +#define ERROR_MISSING_DT_PROPERTY   (-3)
> +#define ERROR_RENAME_MODULE_NAME    (-4)
> +#define ERROR_SET_REG_PROPERTY      (-5)
> +#define ERROR_CHECK_MODULE_COMPAT   (-6)
> +#define ERROR_DT_MODULE_DOMU        (-1)
> +#define ERROR_DT_CHOSEN_NODE        (-2)
> +
> void noreturn efi_xen_start(void *fdt_ptr, uint32_t fdt_size);
> void __flush_dcache_area(const void *vaddr, unsigned long size);
>=20
> +static int get_module_file_index(const char *name, unsigned int name_len=
);
> +static void PrintMessage(const CHAR16 *s);
> +static int allocate_module_file(EFI_FILE_HANDLE dir_handle,
> +                                const char *name,
> +                                unsigned int name_len);
> +static int handle_module_node(EFI_FILE_HANDLE dir_handle,
> +                              int module_node_offset,
> +                              int reg_addr_cells,
> +                              int reg_size_cells);
> +static int handle_dom0less_domain_node(EFI_FILE_HANDLE dir_handle,
> +                                       int domain_node);
> +static int efi_check_dt_boot(EFI_FILE_HANDLE dir_handle);
> +
> #define DEVICE_TREE_GUID \
> {0xb1b621d5, 0xf19c, 0x41a5, {0x83, 0x0b, 0xd9, 0x15, 0x2c, 0x69, 0xaa, 0=
xe0}}
>=20
> @@ -552,8 +592,254 @@ static void __init efi_arch_handle_module(const str=
uct file *file,
>                          kernel.size) < 0 )
>             blexit(L"Unable to set reg property.");
>     }
> -    else
> +    else if ( file !=3D &module_binary )
> +        /*
> +         * If file is not a dom0 module file and it's not a domU module,
> +         * stop here.
> +         */
>         blexit(L"Unknown module type");
> +
> +    /*
> +     * modules_available is decremented here because for each dom0 file =
added
> +     * from the configuration file, there will be an additional bootmodu=
le,
> +     * so the number of available slots will be decremented because ther=
e is a
> +     * maximum amount of bootmodules that can be loaded.
> +     */
> +    modules_available--;
> +}
> +
> +/*
> + * This function checks for a binary previously loaded with a give name,=
 it
> + * returns the index of the file in the modules array or a negative numb=
er if no
> + * file with that name is found.
> + */
> +static int __init get_module_file_index(const char *name,
> +                                        unsigned int name_len)
> +{
> +    unsigned int i;
> +    int ret =3D ERROR_BINARY_FILE_NOT_FOUND;
> +
> +    for ( i =3D 0; i < modules_idx; i++ )
> +    {
> +        module_name *mod =3D &modules[i];
> +        if ( (mod->name_len =3D=3D name_len) &&
> +             (strncmp(mod->name, name, name_len) =3D=3D 0) )
> +        {
> +            ret =3D i;
> +            break;
> +        }
> +    }
> +    return ret;
> +}
> +
> +static void __init PrintMessage(const CHAR16 *s)
> +{
> +    PrintStr(s);
> +    PrintStr(newline);
> +}
> +
> +/*
> + * This function allocates a binary and keeps track of its name, it retu=
rns the
> + * index of the file in the modules array or a negative number on error.
> + */
> +static int __init allocate_module_file(EFI_FILE_HANDLE dir_handle,
> +                                       const char *name,
> +                                       unsigned int name_len)
> +{
> +    module_name *file_name;
> +    union string module_name;
> +    int ret;
> +
> +    /*
> +     * Check if there is any space left for a module, the variable
> +     * modules_available is updated each time we use read_file(...)
> +     * successfully.
> +     */
> +    if ( !modules_available )
> +    {
> +        PrintMessage(L"No space left for modules");
> +        return ERROR_ALLOC_MODULE_NO_SPACE;
> +    }
> +
> +    module_name.cs =3D name;
> +    ret =3D modules_idx;
> +
> +    /* Save at this index the name of this binary */
> +    file_name =3D &modules[ret];
> +
> +    if ( efi_bs->AllocatePool(EfiLoaderData, (name_len + 1) * sizeof(cha=
r),
> +                              (void**)&file_name->name) !=3D EFI_SUCCESS=
 )
> +    {
> +        PrintMessage(L"Error allocating memory for module binary name");
> +        return ERROR_ALLOC_MODULE_NAME;
> +    }
> +
> +    /* Save name and length of the binary in the data structure */
> +    strlcpy(file_name->name, name, name_len + 1);
> +    file_name->name_len =3D name_len;
> +
> +    /* Load the binary in memory */
> +    read_file(dir_handle, s2w(&module_name), &module_binary, NULL);
> +
> +    /* Save address and size */
> +    file_name->addr =3D module_binary.addr;
> +    file_name->size =3D module_binary.size;
> +
> +    /* s2w(...) allocates some memory, free it */
> +    efi_bs->FreePool(module_name.w);
> +
> +    modules_idx++;
> +
> +    return ret;
> +}
> +
> +/*
> + * This function checks for the presence of the xen,uefi-binary property=
 in the
> + * module, if found it loads the binary as module and sets the right add=
ress
> + * for the reg property into the module DT node.
> + */
> +static int __init handle_module_node(EFI_FILE_HANDLE dir_handle,
> +                                     int module_node_offset,
> +                                     int reg_addr_cells,
> +                                     int reg_size_cells)
> +{
> +    const void *uefi_name_prop;
> +    char mod_string[24]; /* Placeholder for module@ + a 64-bit number + =
\0 */
> +    int uefi_name_len, file_idx, module_compat;
> +    module_name *file;
> +
> +    /* Check if the node is a multiboot,module otherwise return */
> +    module_compat =3D fdt_node_check_compatible(fdt, module_node_offset,
> +                                              "multiboot,module");
> +    if ( module_compat < 0 )
> +        /* Error while checking the compatible string */
> +        return ERROR_CHECK_MODULE_COMPAT;
> +
> +    if ( module_compat !=3D 0 )
> +        /* Module is not a multiboot,module */
> +        return 0;
> +
> +    /* Read xen,uefi-binary property to get the file name. */
> +    uefi_name_prop =3D fdt_getprop(fdt, module_node_offset, "xen,uefi-bi=
nary",
> +                                 &uefi_name_len);
> +
> +    if ( !uefi_name_prop )
> +        /* Property not found */
> +        return 0;
> +
> +    file_idx =3D get_module_file_index(uefi_name_prop, uefi_name_len);
> +    if ( file_idx < 0 )
> +    {
> +        file_idx =3D allocate_module_file(dir_handle, uefi_name_prop,
> +                                        uefi_name_len);
> +        if ( file_idx < 0 )
> +            return file_idx;
> +    }
> +
> +    file =3D &modules[file_idx];
> +
> +    snprintf(mod_string, sizeof(mod_string), "module@%"PRIx64, file->add=
r);
> +
> +    /* Rename the module to be module@{address} */
> +    if ( fdt_set_name(fdt, module_node_offset, mod_string) < 0 )
> +    {
> +        PrintMessage(L"Unable to modify module node name.");
> +        return ERROR_RENAME_MODULE_NAME;
> +    }
> +
> +    if ( fdt_set_reg(fdt, module_node_offset, reg_addr_cells, reg_size_c=
ells,
> +                     file->addr, file->size) < 0 )
> +    {
> +        PrintMessage(L"Unable to set module reg property.");
> +        return ERROR_SET_REG_PROPERTY;
> +    }
> +
> +    return 0;
> +}
> +
> +/*
> + * This function checks for boot modules under the domU guest domain nod=
e
> + * in the DT.
> + * Returns 0 on success, negative number on error.
> + */
> +static int __init handle_dom0less_domain_node(EFI_FILE_HANDLE dir_handle=
,
> +                                              int domain_node)
> +{
> +    int module_node, addr_cells, size_cells, len;
> +    const struct fdt_property *prop;
> +
> +    /* Get #address-cells and #size-cells from domain node */
> +    prop =3D fdt_get_property(fdt, domain_node, "#address-cells", &len);
> +    if ( !prop )
> +    {
> +        PrintMessage(L"#address-cells not found in domain node.");
> +        return ERROR_MISSING_DT_PROPERTY;
> +    }
> +
> +    addr_cells =3D fdt32_to_cpu(*((uint32_t *)prop->data));
> +
> +    prop =3D fdt_get_property(fdt, domain_node, "#size-cells", &len);
> +    if ( !prop )
> +    {
> +        PrintMessage(L"#size-cells not found in domain node.");
> +        return ERROR_MISSING_DT_PROPERTY;
> +    }
> +
> +    size_cells =3D fdt32_to_cpu(*((uint32_t *)prop->data));
> +
> +    /* Check for nodes compatible with multiboot,module inside this node=
 */
> +    for ( module_node =3D fdt_first_subnode(fdt, domain_node);
> +          module_node > 0;
> +          module_node =3D fdt_next_subnode(fdt, module_node) )
> +    {
> +        int ret =3D handle_module_node(dir_handle, module_node, addr_cel=
ls,
> +                                        size_cells);
> +        if ( ret < 0 )
> +            return ret;
> +    }
> +
> +    return 0;
> +}
> +
> +/*
> + * This function checks for xen domain nodes under the /chosen node for =
possible
> + * domU guests to be loaded.
> + * Returns the number of modules loaded or a negative number for error.
> + */
> +static int __init efi_check_dt_boot(EFI_FILE_HANDLE dir_handle)
> +{
> +    int chosen, node, addr_len, size_len;
> +    unsigned int i =3D 0;
> +
> +    /* Check for the chosen node in the current DTB */
> +    chosen =3D setup_chosen_node(fdt, &addr_len, &size_len);
> +    if ( chosen < 0 )
> +    {
> +        PrintMessage(L"Unable to setup chosen node");
> +        return ERROR_DT_CHOSEN_NODE;
> +    }
> +
> +    /* Check for nodes compatible with xen,domain under the chosen node =
*/
> +    for ( node =3D fdt_first_subnode(fdt, chosen);
> +          node > 0;
> +          node =3D fdt_next_subnode(fdt, node) )
> +    {
> +        if ( !fdt_node_check_compatible(fdt, node, "xen,domain") )
> +        {
> +            /* Found a node with compatible xen,domain; handle this node=
. */
> +            if ( handle_dom0less_domain_node(dir_handle, node) < 0 )
> +                return ERROR_DT_MODULE_DOMU;
> +        }
> +    }
> +
> +    /* Free boot modules file names if any */
> +    for ( ; i < modules_idx; i++ )
> +    {
> +        /* Free boot modules binary names */
> +        efi_bs->FreePool(modules[i].name);
> +    }
> +
> +    return modules_idx;
> }
>=20
> static void __init efi_arch_cpu(void)
> @@ -562,8 +848,19 @@ static void __init efi_arch_cpu(void)
>=20
> static void __init efi_arch_blexit(void)
> {
> +    unsigned int i =3D 0;
> +
>     if ( dtbfile.need_to_free )
>         efi_bs->FreePages(dtbfile.addr, PFN_UP(dtbfile.size));
> +    /* Free boot modules file names if any */
> +    for ( ; i < modules_idx; i++ )
> +    {
> +        /* Free boot modules binary names */
> +        efi_bs->FreePool(modules[i].name);
> +        /* Free modules binaries */
> +        efi_bs->FreePages(modules[i].addr,
> +                          PFN_UP(modules[i].size));
> +    }
>     if ( memmap )
>         efi_bs->FreePool(memmap);
> }
> diff --git a/xen/common/efi/boot.c b/xen/common/efi/boot.c
> index 758f9d74d2..7879b93f93 100644
> --- a/xen/common/efi/boot.c
> +++ b/xen/common/efi/boot.c
> @@ -166,6 +166,13 @@ static void __init PrintErr(const CHAR16 *s)
>     StdErr->OutputString(StdErr, (CHAR16 *)s );
> }
>=20
> +#ifndef CONFIG_HAS_DEVICE_TREE
> +static inline int __init efi_check_dt_boot(EFI_FILE_HANDLE dir_handle)
> +{
> +    return 0;
> +}
> +#endif
> +
> /*
>  * Include architecture specific implementation here, which references th=
e
>  * static globals defined above.
> @@ -1136,6 +1143,8 @@ efi_start(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE =
*SystemTable)
>     bool base_video =3D false;
>     const char *option_str;
>     bool use_cfg_file;
> +    int dt_modules_found;
> +    EFI_FILE_HANDLE dir_handle;
>=20
>     __set_bit(EFI_BOOT, &efi_flags);
>     __set_bit(EFI_LOADER, &efi_flags);
> @@ -1216,9 +1225,11 @@ efi_start(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE=
 *SystemTable)
>=20
>     efi_arch_relocate_image(0);
>=20
> +    /* Get the file system interface. */
> +    dir_handle =3D get_parent_handle(loaded_image, &file_name);
> +
>     if ( use_cfg_file )
>     {
> -        EFI_FILE_HANDLE dir_handle;
>         UINTN depth, cols, rows, size;
>=20
>         size =3D cols =3D rows =3D depth =3D 0;
> @@ -1229,9 +1240,6 @@ efi_start(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE =
*SystemTable)
>=20
>         gop =3D efi_get_gop();
>=20
> -        /* Get the file system interface. */
> -        dir_handle =3D get_parent_handle(loaded_image, &file_name);
> -
>         /* Read and parse the config file. */
>         if ( read_section(loaded_image, L"config", &cfg, NULL) )
>             PrintStr(L"Using builtin config file\r\n");
> @@ -1285,14 +1293,12 @@ efi_start(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABL=
E *SystemTable)
>             efi_bs->FreePool(name.w);
>         }
>=20
> -        if ( !name.s )
> -            blexit(L"No Dom0 kernel image specified.");
> -
>         efi_arch_cfg_file_early(loaded_image, dir_handle, section.s);
>=20
> -        option_str =3D split_string(name.s);
> +        option_str =3D name.s ? split_string(name.s) : NULL;
>=20
> -        if ( !read_section(loaded_image, L"kernel", &kernel, option_str)=
 )
> +        if ( !read_section(loaded_image, L"kernel", &kernel, option_str)=
 &&
> +             name.s )
>         {
>             read_file(dir_handle, s2w(&name), &kernel, option_str);
>             efi_bs->FreePool(name.w);
> @@ -1361,12 +1367,23 @@ efi_start(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABL=
E *SystemTable)
>         efi_bs->FreePages(cfg.addr, PFN_UP(cfg.size));
>         cfg.addr =3D 0;
>=20
> -        dir_handle->Close(dir_handle);
> -
>         if ( gop && !base_video )
>             gop_mode =3D efi_find_gop_mode(gop, cols, rows, depth);
>     }
>=20
> +    /* Get the number of boot modules specified on the DT or an error (<=
0) */
> +    dt_modules_found =3D efi_check_dt_boot(dir_handle);
> +
> +    dir_handle->Close(dir_handle);
> +
> +    if ( dt_modules_found < 0 )
> +        /* efi_check_dt_boot throws some error */
> +        blexit(L"Error processing boot modules on DT.");
> +
> +    /* Check if at least one of Dom0 or DomU(s) is specified */
> +    if ( !dt_modules_found && !kernel.ptr )
> +        blexit(L"No initial domain kernel specified.");
> +
>     efi_arch_edd();
>=20
>     /* XXX Collect EDID info. */
> --=20
> 2.17.1
>=20
>=20



From xen-devel-bounces@lists.xenproject.org Tue Oct 12 08:05:02 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 08:05:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.206835.362489 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maCmO-0005jm-Mw; Tue, 12 Oct 2021 08:04:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 206835.362489; Tue, 12 Oct 2021 08:04:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maCmO-0005jf-Jj; Tue, 12 Oct 2021 08:04:56 +0000
Received: by outflank-mailman (input) for mailman id 206835;
 Tue, 12 Oct 2021 08:04:55 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=/4YK=PA=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1maCmN-0005jV-HI
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 08:04:55 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 08ae4144-eddc-478a-a03a-913d0c8dc80c;
 Tue, 12 Oct 2021 08:04:54 +0000 (UTC)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2111.outbound.protection.outlook.com [104.47.17.111])
 (Using TLS) by relay.mimecast.com with ESMTP id
 de-mta-1-Lbj6k39cOESxxIvC8fSXDQ-1; Tue, 12 Oct 2021 10:04:52 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0401MB2605.eurprd04.prod.outlook.com (2603:10a6:800:57::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.20; Tue, 12 Oct
 2021 08:04:49 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4587.026; Tue, 12 Oct 2021
 08:04:49 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS9PR06CA0360.eurprd06.prod.outlook.com (2603:10a6:20b:466::16) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.21 via Frontend
 Transport; Tue, 12 Oct 2021 08:04:48 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 08ae4144-eddc-478a-a03a-913d0c8dc80c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634025893;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=lVEXBl0eMQBubCfHAGRRC1pbQ6ipJZYOZgJooedLi6c=;
	b=ijLTAnyS/TLOctzFZdSYOmMBDahz3Md8mqj1hGjOHaWQQd/iXs5qEtt+jHHhBe3VwYpmey
	2k5k2uIuHwj7/qTzQt4ftVz5HZvsgDqjc0mB2i8Trz0jByF46QN9kntr1eWJ+dyRS3y+rF
	fp3WrGoCblhJ6YEziXcpFrvDroohoCI=
X-MC-Unique: Lbj6k39cOESxxIvC8fSXDQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Ur+XKUpi9ZRqHLuW/o3hCh40flWXPGBdrX2wkiZLwJLZywUCIwT/QNkEYQ+WD63ESL2F6eG7P9WLEA8mQCno2mn7SNeVOnebrZvLaWXx4JFEgBTpvKWoCNucZOArITzkGoOCrRZdcaWMDVStP75de4WdhllJ7xKiDykB8BIk4oXwfKfLuZ8dUJDP+p5BjQWEofJO9U7Ch2+06NAo/pOyOpB1hb1uxQtNpO4RI2HRsT6vdYbG/oNo+0qPB/D54+Jm6oMUtkolnR8on/zgTGAP7qRsgJxUWJzMzzPwVe3XBvTgl6unzsBYkjKAD+dpiwXQ7vkLA4Y25TVbA0bK9bRheQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=lVEXBl0eMQBubCfHAGRRC1pbQ6ipJZYOZgJooedLi6c=;
 b=MNWrAQmOOfHFdegdFT7tmlWR8K0Ld3K4NEGboqZZ2lPqEhh+vrnHTVINKKwD/d4ABzgnogrJMv0exwKVeqQ7Ybg+EQqbtx954c3pfsRwOp0R4Y9UTejR5Gvyk8P1ipN2WTaFjXvaAQ6+SKWS3HnCT0KMe0Qa1CyKzrA0rZz4ha7inQwn/izqMoswd2dRtoQKawOhSCJO2l38gdue9UCVE+w1+9M/kPrZGCexzdjUWcFr0pqviqe4bVpBv2G1bVwoKkVke0o56ehw7HaRsqxOkRwC4sHlSCXKzqHNetYLGN0KgCnrjAAuitDprBIJ2aGsYV0qn2jsLbkXRAx16CaS7Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [PATCH v5 08/11] xen/arm: Enable the existing x86 virtual PCI
 support for ARM.
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: Bertrand Marquis <Bertrand.Marquis@arm.com>,
 Rahul Singh <Rahul.Singh@arm.com>, Andre Przywara <Andre.Przywara@arm.com>,
 Julien Grall <julien@xen.org>, Volodymyr Babchuk
 <Volodymyr_Babchuk@epam.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Wei Liu <wl@xen.org>, Paul Durrant <paul@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <cover.1633540842.git.rahul.singh@arm.com>
 <9bdca2cda5d2e83f94dc2423e55714273539760a.1633540842.git.rahul.singh@arm.com>
 <6752f2d3-171b-37f5-c809-82995a8f3f36@suse.com>
 <CEF7FFB0-779A-4F46-8667-6BCD9BA5CB6C@arm.com>
 <b735c2d3-1dbb-ce0a-c2fa-160d4c6938d3@suse.com>
 <A8DEBD07-FB45-4E4E-A2C3-7AF8B393B032@arm.com>
 <59c9e102-c710-64d3-2a1a-cc8dcbcceead@suse.com>
 <alpine.DEB.2.21.2110111105180.25528@sstabellini-ThinkPad-T480s>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <2fa4d2e2-7daf-6d52-ff4c-38a482af1fb9@suse.com>
Date: Tue, 12 Oct 2021 10:04:47 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <alpine.DEB.2.21.2110111105180.25528@sstabellini-ThinkPad-T480s>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0360.eurprd06.prod.outlook.com
 (2603:10a6:20b:466::16) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 42da314c-90ae-4949-a21a-08d98d56f6d2
X-MS-TrafficTypeDiagnostic: VI1PR0401MB2605:
X-Microsoft-Antispam-PRVS:
	<VI1PR0401MB260515262E4184005107A035B3B69@VI1PR0401MB2605.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	TGRW6AmqItX2o0n8LIyKvORwZDeZaaL2D8BT9WhjwvrGP+UUm1BYfC7jJAnwycLfeaj+OQsXYUy0+yrruvV7mCVOMwkj4/fzhm04idk9w/N+InHVX4fQKIDn9xJ0mSgSCnpJs55tV8uu7BzWhwfwkSiUPt+leaNNgoPzKzrHk4gLmlVOa3jg1P3DyIlAcWbpJzulJ9pt2nNHfsP2luGBO6jysA/P0Tua8nLE38lvsBuY4rlUGnq6DstRTwfQNMZu6UvSkQrENXzdaPA8Eb3LsPdQqatOOMgFDCSQdU5j6i7/f6XE6sqcOgSNrRwlRGgOQgB6aWFrGrjKZXa4TlaKpGCF3814V/YcDUCsP/y0ZPRx2xo8Esewsjjk9D4b8zfa3cXJvP37rrXmzJV3GxN5UoGe3qUp7xd7rZ7RbKPorMAH7dET10Iqjg+cgxXtyimjI59y2OEJGvlhb0bkP6XubWoYkAQvTitJF1DR/exFA6O5XkXGP/dfOCPQRsJtbxQ5oE6OHAm9kwMAY5rWICcphCSgEOlOcGS5tOvVfw/eDN0cS0RUm0kG5nCS6O9/a4Srbmgvh5Sxi93CTOA+unWJn/gEeR6AV0JyQmEKJpGDQXC0I0s8mxNngK5ZNW1sRP9FBXnvbG5W+OEzbVNOvqSi9E3LzWbi8Rl3BdNbKzaB2Y0GmiRm0D/Oij8oc0F9A6Q5OQjhi83r27LT3LC556jlZrAx/f8seWEAPwwSuoYA4t0qm7/fTywKbGiQqUUJ3N1I
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(186003)(316002)(36756003)(83380400001)(8676002)(2906002)(53546011)(8936002)(6486002)(508600001)(26005)(6916009)(7416002)(66556008)(38100700002)(16576012)(66946007)(31686004)(5660300002)(66476007)(86362001)(2616005)(31696002)(54906003)(4326008)(956004)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?a3ZXcXF2ZXhMbDR6d0RTS1VWSjhJQmh4eEFBMkY3UVU0YlI0Zk5heHBqSDIw?=
 =?utf-8?B?NEFTc2swQmJqRXRaazlqVVc1ZWNQMXJJUlZxZjJYQm9wQWZheTZySS9YWlRa?=
 =?utf-8?B?eUU0QU5SdnJ1YVNQRFQ4cFRMd0JMSitSeW1GbHQzOU9UTjhUdk4rUkQ5OHJF?=
 =?utf-8?B?ZnlzS3JUdjlYTUdQWCsyNjl1RUJrazN2aXhsQ2orSlZobW44N3QxZXZ0Z0Vq?=
 =?utf-8?B?dHpReFppQSs4M1B6eFdWcUVBMUw1ZlE0L3NjTDZoYUszYkRSR1VkUGI3ZFEv?=
 =?utf-8?B?OGR4WnR0ZElibW5hNmJBOTBqbGZRY3ZkOGdCRDdjZDBzc3kxRWlKeW8yR3pq?=
 =?utf-8?B?MU01VlhoRDh5dStXeVhkZGVQTzZWSGtNRzc2ZHJxSXZna1Jaa3JlYjlKdEZi?=
 =?utf-8?B?VHM5aTJjbVJNQ1Nta2U2aGNyM1NLZmVGejZVRGd4LzhFbDZBcVBNTVV5cWMz?=
 =?utf-8?B?Mk9jTUd1MGtRWURVNkhGSExKOS92S2ltck1yZXF6MitZRVBibjVQSk5SREdz?=
 =?utf-8?B?YnpoL3ZwTHpxN0ZobWxQcEF4eEZwRElqTDdFQkRyT2lCV1A2T2RKTmNjQUpv?=
 =?utf-8?B?M1N6RmVzK3k5UWVFRElGQzYxWWdrbDlOaUlkSExsV0V3NFJOdS91QVhOaFg2?=
 =?utf-8?B?VFNKZ0hpcVQzemtaaVFGMjFzd0RkOHBkaFI4NDg2d3BYY2pQTUpITExBMXZH?=
 =?utf-8?B?VG9ZbmNMWk1lT25IR2xyeDIzZXZ3ZjFlNGNvVTZvNURrRnZkaHJiWnJtNTAv?=
 =?utf-8?B?d2xQZjBDdlpsWm1CS3pVaFFJUGw2alZsN3VZM0xmanpFNU9zZjZYcXFvRk5E?=
 =?utf-8?B?UEt5bHByenA4Y1hjbVQ4Zkttdmo5dkNIL3lvWXJxdFNDYUl3N2F2ZDFaWUNJ?=
 =?utf-8?B?UzNZSmdUQnpDbHhGSldRM0poZ0NSZGdMT2tzMktNRkFpSXd1eWtWQnEwMnAw?=
 =?utf-8?B?bWhsTTU5cmRiSzNiZUhTUFYyWERCa0dYZ0ZZYUNKYWNlUVdKTk9hMFRmTjhw?=
 =?utf-8?B?ZGVjbXpvdkJjTVpmL0RJV051cEhBaEFPZ3JZZzVFcG5UbjBSV3hlM1diMEww?=
 =?utf-8?B?SFN0U1dHZ0lXTG14SENTdDdqc2MvTXJTZnpPKzFRaWY1WHg5dTVQaFZWUVov?=
 =?utf-8?B?Z3NTVU1Mc2MwSDJyRG11bU5kbHdpeXZyWUxmcmszOExmVnRXOXNzL2FiUGc1?=
 =?utf-8?B?bktVK2grZkJMblNhcmJUbkxtTjFpUmRCTTIyY0YrWFk0Ykx3cEsxT2FXQjgz?=
 =?utf-8?B?VkxmZWZnb1JvVzFIUnQ1WlVPUFczM2FRZWRoeERyYXVyNjVDT1VtQXQvam9C?=
 =?utf-8?B?aVJoeFdRLzNNY0xoNHdjSXBsUTRQMFJIazN4N096Z0VsUElQQktxNmZzbXNO?=
 =?utf-8?B?d3BYdnJZWE5CKzJOdWRneUUzNGRnQXg3cDBQWU1XdjJVNmdoaVJrbTFOeGQ0?=
 =?utf-8?B?aEdzclp3TGdZU25HMnZQa040OFUwM3lOcVRBdzVScnNWZkJ4eVVSQStWaXdD?=
 =?utf-8?B?Y1FuSk1yaG9NSjUxdUJCQUhUaE91NEM1SEZDbWN2WmVJRzJhWUo1L1hZdjYx?=
 =?utf-8?B?djE2WlgySExlRXA3M1NtOHQydmprTFBhNFRsVUVhb3l1Q1RZY212RU9FRmxG?=
 =?utf-8?B?UUYzblBFRmJaSE9RTU1Vblg5UXoxU0Y2MVRZMW5hZ1d2NEczMU1wblpyR1dh?=
 =?utf-8?B?QUVuY3FBZEtzZWU3MlcyMVNyUzhTS3hPU21DVVlRcVZNeGg4Ymh2TGYrcW5Q?=
 =?utf-8?Q?6suBYBp9ENwJj/jbAmJD6jwKQtS6Pyc0Clj4wgH?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 42da314c-90ae-4949-a21a-08d98d56f6d2
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2021 08:04:49.8428
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: EOd0+yBzOZ4KQMWkElgLcAmCthezO8UwizXJOsRdV5nvgHShHyn7h/zcBXDA2KuVKCKtQYOKlMAmcMo9nvUtJA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2605

On 11.10.2021 20:18, Stefano Stabellini wrote:
> On Mon, 11 Oct 2021, Jan Beulich wrote:
>> On 11.10.2021 15:34, Bertrand Marquis wrote:
>>>> On 11 Oct 2021, at 14:09, Jan Beulich <jbeulich@suse.com> wrote:
>>>> On 11.10.2021 14:41, Bertrand Marquis wrote:
>>>>> But digging deeper into this, I would have 2 questions:
>>>>>
>>>>> - msi_cleanup was done there after a request from Stefano, but is not
>>>>> done in case or iommu error, is there an issue to solve here ?
>>>>
>>>> Maybe, but I'm not sure. This very much depends on what a domain
>>>> could in principle do with a partly set-up device. Plus let's
>>>> not forget that we're talking of only Dom0 here (for now at least,
>>>> i.e. not considering the dom0less case).
>>>>
>>>> But I'd also like to further defer to Stefano.
>>>
>>> Ok, I must admit I do not really see at that stage why doing an MSI cleanup
>>> could be needed so I will wait for Stefano to know if I need to keep this when
>>> moving the block up (at the end it is theoretical right now as this is empty).
> 
> I know that MSIs are not supported yet on ARM (pci_cleanup_msi does
> nothing). But I wanted to make sure that the pci_cleanup_msi() calls are
> present anywhere necessary, especially on the error paths. So that once
> we add MSI support, we don't need to search through the code to find all
> the error paths missing a pci_cleanup_msi() call.
> 
> To answer your first question: you are right, we are also missing a
> pci_cleanup_msi() call in the case of IOMMU error. So it might be better
> to move the call to pci_cleanup_msi() under the "out" label so that we
> can do it once for both cases.
> 
> To answer your second point about whether it is necessary at all: if
> MSIs and MSI-Xs cannot be already setup at this point at all (not even
> the enable bit), then we don't need any call to pci_cleanup_msi() in
> pci_add_device.

Well, at the very least MSI can't be set up ahead of the traps getting
put in place. Whether partial success of putting traps in place may
allow a cunning guest to set up MSI may depend on further aspects.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Oct 12 08:06:21 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 08:06:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.206841.362500 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maCnl-0006LK-15; Tue, 12 Oct 2021 08:06:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 206841.362500; Tue, 12 Oct 2021 08:06:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maCnk-0006LD-UK; Tue, 12 Oct 2021 08:06:20 +0000
Received: by outflank-mailman (input) for mailman id 206841;
 Tue, 12 Oct 2021 08:06:19 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=/4YK=PA=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1maCnj-0006L5-Nm
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 08:06:19 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id a864fbbb-e334-472f-be78-5b6289200caa;
 Tue, 12 Oct 2021 08:06:18 +0000 (UTC)
Received: from EUR03-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur03lp2051.outbound.protection.outlook.com [104.47.10.51]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-15-iUoBeIg7PcOu5RhIdwZHug-1; Tue, 12 Oct 2021 10:06:16 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB3119.eurprd04.prod.outlook.com (2603:10a6:802:10::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18; Tue, 12 Oct
 2021 08:06:14 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4587.026; Tue, 12 Oct 2021
 08:06:14 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS9PR06CA0391.eurprd06.prod.outlook.com (2603:10a6:20b:461::13) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.24 via Frontend
 Transport; Tue, 12 Oct 2021 08:06:13 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a864fbbb-e334-472f-be78-5b6289200caa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634025978;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=ekSHirgG27bQ0QufMpRD9KcZLOUJTkvIRdDFX8JC+/I=;
	b=cZjVkPAhJkCh4zrKpwYtCs4AsahY96m1QvF1BWX/5kojUX+rQrvPimlAVBXUJ0KKjNmjPW
	OPUS+qULRuI3dS22jlMdSCnF6nPZ4QHTwb53seSBReCbhG3HpLEXPPj1EtGlY3PEzqnQZD
	j5JuMpWmmnkAQX4y06A+dio83z49eac=
X-MC-Unique: iUoBeIg7PcOu5RhIdwZHug-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=YFLarFLhQXt+IKAHcdBnxPwN+s/9r9lUXquaOFCNQVg/CwHvG0GjkDX9Bal6Cz8kYJsGg2Eb74yGDKw9bUQJaYFqsRuj8mMhACp7DQ14N5xZcHgBielYQr4hXdDrgfQXCzUBcrV3meS5Dfq0SZBoHe+xXOE572kPbTMyNG7mgaXtI7hssRRzPsnbQk7j3g4iAz4+CzLdDfDlgg5XKPj2daLf3Q+Xvc7D54UM6ar0BJhKuq6uDuxTotQ29P+w7niPSOi602xGb2h0wVdQSOrrEewIIxMdoHktqk6IEvWThHCDLNxArheCe6eXfb9NANCUDp+xBPNcCkwBd792xbnt7Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ekSHirgG27bQ0QufMpRD9KcZLOUJTkvIRdDFX8JC+/I=;
 b=M3QVcGZEhgZmGdmhMHaGCPDoaf8AjQF7JtO4cCQoaYGKz5rLRXr6yQubjMJqE9hVdnMAfUz7G5mXo3FbFDNg/j8ILrSNo5P4ZJ3v+FAOH3sv9LxtMY3KIfBpoFMOTwTLDQRBYCH83jYIvhfKFXsrh1ZXdP1GCIeLyrvMht3fMPWqza7C7O8TIMEvyTtql4wtJHtatw2q/W9+u4/1Bh+F6HnKysr8/bSzvQl0S+qGd5gZkb8WzJ5usPX/2HeSo5V4bn/ye01snyYGmhbA2JrvzCSyu6Mt+PR9u7XPRvFEC4GCOgEOSWRYFk8bNAc/vdTRX6hv40GWOtRJEP5U21TmyA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [XEN PATCH v7 20/51] build: avoid re-executing the main Makefile
 by introducing build.mk
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>, xen-devel@lists.xenproject.org
References: <20210824105038.1257926-1-anthony.perard@citrix.com>
 <20210824105038.1257926-21-anthony.perard@citrix.com>
 <87036d63-b5d4-55bf-0bb3-9b981a147f15@suse.com> <YWRRFxlvmDMu8nRZ@perard>
 <b30bff47-226c-6f82-5f59-81d17b191ab4@suse.com> <YWRvRlh5MlX1eMz+@perard>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <1d58430c-5c78-7379-7a02-7505342bff29@suse.com>
Date: Tue, 12 Oct 2021 10:06:12 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <YWRvRlh5MlX1eMz+@perard>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0391.eurprd06.prod.outlook.com
 (2603:10a6:20b:461::13) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 9bc43ef0-991d-4531-599d-08d98d572915
X-MS-TrafficTypeDiagnostic: VI1PR04MB3119:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB3119717BF0948C22C8F7D1D6B3B69@VI1PR04MB3119.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	P/zrGfOTwsCPiaeXRTc5X1pOgX8R7WrfFRudKsPd3q7CTJTY+o30Mc5QgWTAP1LOul7hhaye25DOE5pc32sk3drVpi8teBZ6O6o+KwH0gmmLnbbmKaALQs36r6d9wRDl2eLo/au/4vBp/3b1JT2IupvA79RaiO8T4JkG/qr6FJzcQ79m1dmYCh42AbG8YC0WXtDdJ5Fj3+BoCjFOaJ8I6imp+XPwQ7FjJbDjow5LXWqTJWzcDZ4Om03yo09sqe3DALi0trBfYy8xMmbS4bZ8huV2CEuk/5oLmlc/N0B1orlLu/H20ZsXEzmjpuVUYPuqLQ0rTPh9hG9NNeOLSfendU4ey8TDxjFsm1vpRc9QChaCRd1Tc7IaiVNfkPNxzHP4oJ+Xv+9TD1lX6wogc3oyh79tlgBP08BVS1rqvDcCGaIaVE+DVoIdI4XHjsl91KjvjyZPypgVfqT1xicADgOY7Ih9ea8J9YGBnklv+VIS7y/84+VOlLD0Tmlbg7ZpprwUrD5WfXGCuv0Vu+q7uiCtLlsP+dKgZQmTg0bvqWo6b4ywdrPXxBnW/Du7dYbGgHKkbZhV/GyKJYc8c5aWNO26lbDps9sAKuJ66p8NrUoRaSnYRsIeOrYdI2nGtn5BSK1UZQPh1AR/FovwogbFm332IKrsavDy+PduHej+tzDdTSpzQJv8TCEAxhmdQHBArE2Kli7atE4Bg8VvNir+u43iwXfj8lDwZZYfRyoxOVJgkD4jbr/qcsWhfQdNR9EY9ljM
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(16576012)(956004)(6916009)(2616005)(31696002)(2906002)(54906003)(5660300002)(83380400001)(38100700002)(31686004)(316002)(36756003)(8676002)(86362001)(26005)(6486002)(508600001)(66946007)(4326008)(66476007)(66556008)(186003)(8936002)(53546011)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?RUc4TVV0UlBKUHNzRGk1aXNHQU1GNythdFMvZkFpYmFYTWFnTHB0SVRvcDRD?=
 =?utf-8?B?VUxjYTQzYjIxK3A0bzh3eTBtemd4Sm5RRmlsOXdCVTNDc3pkUG1hUXJ1RDJZ?=
 =?utf-8?B?aTFiZHcxK2x4azNWczJTb0JxcnhLcEZuVVdKbVRBL2prcHZaNzVrdThrMENz?=
 =?utf-8?B?eFRsbzRXREhrZ2ZzV0lIVldxbWJ0MCttazhUenpKalBZNCswTmk3ZjBQbnpj?=
 =?utf-8?B?V3orVGlpSkY5QXlkbnVHbi9oOGVVNjJMSkpNT1BPY2dhZllaWGsvbVppZThC?=
 =?utf-8?B?Vjh2VnY4NThWSzhzdmVxcjdBR0dqRHhDTnFsUnJDODVkQnhZbGxubTZLbHZL?=
 =?utf-8?B?VkRxK1JZUUJ6TWtTbHZBenF0bEQ3M2FURHlVM214UENjWnhjZmtSRzNhTGxU?=
 =?utf-8?B?c1hkY3ZlOG00VmxaMFJaR0I0UEIyR3JLT2M4UWtSS1JIZ293N2JVWGtBRkU1?=
 =?utf-8?B?R1hzcUNReFc3d3NHbnh6eDYxOVJVam40TnY1SVFQY2RySUJGUkxFRG41Q2Ja?=
 =?utf-8?B?cjVRSVRwMFhaWGg5ZXkwNWRnK3NjTnFFK3BlMVptenhDeEtNNnRrdGwwS2Nr?=
 =?utf-8?B?RUVrUGFRbUpLN1duUkRXL2VkWnh5dndzbk5jZlJDcHZpdjdxRWNQTGZwUWlH?=
 =?utf-8?B?c0M3ZHpKbk1zd3BOaURVaTdRaHlURng2ODN0Vy9DU2lxbTVISDJtUDdVd1dI?=
 =?utf-8?B?TXUvWGsrdjFEZzRIaW5BTWt3cnczOTBNVjB4cVFwYnlzUk94VTRyVjdZMnIr?=
 =?utf-8?B?UDlpWUgxVUMyZXNHTExndWdJbnpWeVF6UnN3ZHRmU3pxYUlRQk45Qk9qK1pw?=
 =?utf-8?B?aEhrbEloa2VmdDdoK0Z4ZFhDUGEzWEdjejlwaW9qTWJndlVXaVIxcGJwTnc0?=
 =?utf-8?B?OHJ6MmZjZ0p3Tll5cmdvYW1tSXJBZHBKSjYvRktiUDJzMjArWG1yK1lMVi9p?=
 =?utf-8?B?L1ByckRvMklFUkplRmJuZHdjdklTdk4rNEtmZ2R1L1RBUlc5RXU3NlBZR2xG?=
 =?utf-8?B?aTUvd3pJSGJiSmhsTzZpQXBKcVV6ejJjeC9udDdGQXFtOFRkdlRFeFZIRm90?=
 =?utf-8?B?Ti80NzE0Skltdi96U2k5bjZZK1Z0VDM5U01MbHZIZldKV1ExSVUrdGFlMjVB?=
 =?utf-8?B?L01UVmNZeWNYcjJaTmVVSEJUdENlUWxqZkRabHhBTllsaTNLcXdmd1dWdEVw?=
 =?utf-8?B?Yit3R29hOUYvWFFJWkxoZkppZ2pZSjhnVmpMcSt4TG9mdng3Y0dRTGo0d3d3?=
 =?utf-8?B?MHVkaWVBQkVXYUlJeXcwa3llTm9ZQStldzFpSjEwQk50OFN0MzMrUndSUjBJ?=
 =?utf-8?B?TllLak1nb1I1bXRoWXFvYUcyZlp6bS85eEtOejhRODBlU2VHbE5IYkR0OVpD?=
 =?utf-8?B?M3hEcVRSK1gwZUtRUzhpWWZwR200T1hNS2hNb0oxZDVLZXRjRE0zOVFUZUdQ?=
 =?utf-8?B?T0dnREhjdW52TVBYb2pKWGxaMUlUNWhjRG9IMHE5Zk1iVis3S09xVHRWaEdZ?=
 =?utf-8?B?YnpqcHZVWno1Z2JiVUpBenA1ZEsvNVFTSnFsTS80YTdNZlE2VGtyL2dJeDNx?=
 =?utf-8?B?U1lQZUpTcFg2ZlVOYTlBcUE5a2FoOHhzanRyU2JZQTVpb1FlVmtrWmNIK0ti?=
 =?utf-8?B?alpzVnhtRC93VEIrZVdCeUNMRE5oRUE2bk5INFpXVWlsTDhOeThoVms1SlBJ?=
 =?utf-8?B?cFFkYzQ3WFlRa1A5ZElvbW45VXB6WTlsY2JGVmlJdzRML05qeUE0WUNQSUZs?=
 =?utf-8?Q?R77okmO4dREZG7Hh5lD96nYfODAx38w1p+bzwEv?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9bc43ef0-991d-4531-599d-08d98d572915
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2021 08:06:14.6198
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: caSQc7vkxxH5lTC2M2ATGfcNxAFhzNYNkkGKmseTyHQDIrcDyd5e0yg01FQ6ILlu8bfROqJnnkpHvyOTuirDCQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB3119

On 11.10.2021 19:07, Anthony PERARD wrote:
> On Mon, Oct 11, 2021 at 05:31:08PM +0200, Jan Beulich wrote:
>> On 11.10.2021 16:58, Anthony PERARD wrote:
>>> On Mon, Oct 11, 2021 at 12:56:54PM +0200, Jan Beulich wrote:
>>>> On 24.08.2021 12:50, Anthony PERARD wrote:
>>>>> With nearly everything needed to move to "build.mk" moved, there is a
>>>>> single dependency left from "Rules.mk": $(TARGET), which is moved to
>>>>> the main Makefile.
>>>>
>>>> I'm having trouble identifying what this describes. Searching for
>>>> $(TARGET) in the patch doesn't yield any obvious match. Thinking
>>>> about it, do you perhaps mean the setting of that variable? Is
>>>> moving that guaranteed to not leave the variable undefined? Or in
>>>> other words is there no scenario at all where xen/Makefile might
>>>> get bypassed? (Aiui building an individual .o, .i, or .s would
>>>> continue to be fine, but it feels like something along these lines
>>>> might get broken.)
>>>
>>> I mean that "xen/Rules.mk" will never "include" "xen/Makefile" after
>>> this patch, but the variable "TARGET" is only set in "xen/Rules.mk". But
>>> "xen/Makefile" still needs "TARGET" to be set so I moved the assignment
>>> of the variable from "xen/Rules.mk" into "xen/Makefile".
>>
>> Okay, thanks, this confirms the understanding I had developed; maybe
>> you try to reword this some. What your reply doesn't address is my
>> question, though.
> 
> Which question, there seems to be 3 of them :-). Is it about
> xen/Makefile been bypassed?

Yes, sorry for being imprecise.

> Building anything in xen/ requires to first execute xen/Makefile as this
> is where variables like CFLAGS or XEN_ROOT are defined, and this
> includes single builds or building an individual .o.

Okay, thanks for confirming.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Oct 12 08:07:50 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 08:07:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.206851.362511 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maCpC-0006xs-Cm; Tue, 12 Oct 2021 08:07:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 206851.362511; Tue, 12 Oct 2021 08:07:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maCpC-0006xl-9W; Tue, 12 Oct 2021 08:07:50 +0000
Received: by outflank-mailman (input) for mailman id 206851;
 Tue, 12 Oct 2021 08:07:49 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=GT6b=PA=arm.com=Luca.Fancellu@srs-us1.protection.inumbo.net>)
 id 1maCpB-0006xa-2e
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 08:07:49 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com (unknown
 [2a01:111:f400:7d00::600])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 94f1b6bf-6752-434a-9829-907c4fdaee9c;
 Tue, 12 Oct 2021 08:07:46 +0000 (UTC)
Received: from DB6PR0802CA0043.eurprd08.prod.outlook.com (2603:10a6:4:a3::29)
 by DB6PR0801MB1655.eurprd08.prod.outlook.com (2603:10a6:4:38::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.20; Tue, 12 Oct
 2021 08:07:44 +0000
Received: from DB5EUR03FT055.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:4:a3:cafe::1d) by DB6PR0802CA0043.outlook.office365.com
 (2603:10a6:4:a3::29) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.21 via Frontend
 Transport; Tue, 12 Oct 2021 08:07:44 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT055.mail.protection.outlook.com (10.152.21.30) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4587.18 via Frontend Transport; Tue, 12 Oct 2021 08:07:44 +0000
Received: ("Tessian outbound a8bfe25d7364:v103");
 Tue, 12 Oct 2021 08:07:44 +0000
Received: from d27ff33f5bd3.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 EC4E6E52-82EE-4763-B4A0-55AB8B0D21A9.1; 
 Tue, 12 Oct 2021 08:07:33 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id d27ff33f5bd3.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Tue, 12 Oct 2021 08:07:33 +0000
Received: from PAXPR08MB6816.eurprd08.prod.outlook.com (2603:10a6:102:130::10)
 by PA4PR08MB5968.eurprd08.prod.outlook.com (2603:10a6:102:e9::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.19; Tue, 12 Oct
 2021 08:07:31 +0000
Received: from PAXPR08MB6816.eurprd08.prod.outlook.com
 ([fe80::c1b4:db1c:376f:b697]) by PAXPR08MB6816.eurprd08.prod.outlook.com
 ([fe80::c1b4:db1c:376f:b697%8]) with mapi id 15.20.4587.026; Tue, 12 Oct 2021
 08:07:31 +0000
Received: from smtpclient.apple (82.8.129.65) by
 LO4P123CA0148.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:188::9) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.14 via Frontend Transport; Tue, 12 Oct 2021 08:07:30 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 94f1b6bf-6752-434a-9829-907c4fdaee9c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=7LqK2djBglZ6W876FhQQNQJ/B9g3vWex0Q3gE7gNLhs=;
 b=Q6JjPFsoiuLEDRf3pD1NunujOvaI/pqtqYI//DFm0FVdf3FShcF2kH5JEw6RZIQhBnMBiifkxxs/3yM71E4+TiXSZD7cS5FdcCGXk/n3JQJtzccJBXILqzt7PrMi4ByB4OUWN66HYJ7wkvSL0QGDqBsugCjHjp25r7o5+8Qs7fE=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: bf6a822aa4925aac
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=SCIImYdmKt5vEppc89yj143IAEg9McjGhXlvze647EDhTdHSUBJCXuUVTiztDWskAX1fyzwFHP8jbhDkzCe8uTVtCBL++cm9ogziHTrF4gRXLwBX2GZcSDc3RpDHzlBDjLvNzLoLH7fuq2rodRCGFsk6w+/ekmytPYPw/uc/fFoNgk8/PkoR48MD+G+2/tzHgXCQMkaZE3Qk2aNM7VYycb6M2V/S1JIC+Lx6foKAg3I77Slj2uT+NdNl4/DjvY536LcztfCj2icavaGHyroYQ3brno2sAC5a/aZfkaoEqGFJnuVc/VDFLjte+CASx4UE0LAsKG/4DbBKc0PQVvco+Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=7LqK2djBglZ6W876FhQQNQJ/B9g3vWex0Q3gE7gNLhs=;
 b=BrAR9eILzIvTnTdTo7lK7M36FkEfWCqE7nZk0GXDCtPZTqZu40Ko4Yv+lT8PjtCD5ozRZcU4Rr2wV1C8cBsBYygKdy6rAMXC7yCuUlgyzee7f3BrK+Ylqx6rhQ4ojGZkbnrZkzBWq89p609w+2dCDGktsHZrEt4fHU+nnxXAXMkw+LNqwdHZsLazAA8kYxtelcBKdZ++Y+K8fBmJ9VoJPwgIp9Grsk/8CZN6k81sbgAzYXdtqYYYiq++uvPLT5Wn+qjflaap4trh/MI7nCFmheBSbKtEa9Ewv2PllYNZqNtxXbSNy2kJlmryQicmcWT7dOlKAlcjCjT/k+M6+Nv3hg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=7LqK2djBglZ6W876FhQQNQJ/B9g3vWex0Q3gE7gNLhs=;
 b=Q6JjPFsoiuLEDRf3pD1NunujOvaI/pqtqYI//DFm0FVdf3FShcF2kH5JEw6RZIQhBnMBiifkxxs/3yM71E4+TiXSZD7cS5FdcCGXk/n3JQJtzccJBXILqzt7PrMi4ByB4OUWN66HYJ7wkvSL0QGDqBsugCjHjp25r7o5+8Qs7fE=
Authentication-Results-Original: kernel.org; dkim=none (message not signed)
 header.d=none;kernel.org; dmarc=none action=none header.from=arm.com;
Content-Type: text/plain;
	charset=utf-8
Subject: Re: [PATCH v6 2/2] arm/efi: load dom0 modules from DT using UEFI
From: Luca Fancellu <luca.fancellu@arm.com>
In-Reply-To: <alpine.DEB.2.21.2110111813510.25528@sstabellini-ThinkPad-T480s>
Date: Tue, 12 Oct 2021 09:07:24 +0100
Cc: Julien Grall <julien@xen.org>,
 xen-devel@lists.xenproject.org,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 wei.chen@arm.com,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Ian Jackson <iwj@xenproject.org>,
 Jan Beulich <jbeulich@suse.com>,
 Wei Liu <wl@xen.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <81EA782B-762E-4B8A-8D33-EC79203439BC@arm.com>
References: <20211011181528.17367-1-luca.fancellu@arm.com>
 <20211011181528.17367-3-luca.fancellu@arm.com>
 <alpine.DEB.2.21.2110111243290.25528@sstabellini-ThinkPad-T480s>
 <EC7165F9-09CE-4001-93ED-FA637F5ED36C@arm.com>
 <alpine.DEB.2.21.2110111415350.25528@sstabellini-ThinkPad-T480s>
 <alpine.DEB.2.21.2110111423310.25528@sstabellini-ThinkPad-T480s>
 <29cc47f2-4727-0397-db0c-a6c1f5a52bf7@xen.org>
 <alpine.DEB.2.21.2110111813510.25528@sstabellini-ThinkPad-T480s>
To: Stefano Stabellini <sstabellini@kernel.org>
X-Mailer: Apple Mail (2.3654.120.0.1.13)
X-ClientProxiedBy: LO4P123CA0148.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:188::9) To PAXPR08MB6816.eurprd08.prod.outlook.com
 (2603:10a6:102:130::10)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: b17df41a-2d2f-4577-0ec7-08d98d575f11
X-MS-TrafficTypeDiagnostic: PA4PR08MB5968:|DB6PR0801MB1655:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS:
	<DB6PR0801MB16555F067153307B57B0B991E4B69@DB6PR0801MB1655.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 KPPd/PzlQcoN7PNAkbScLpl3SqR6RY9Ur+WaCRnMTSuBshFfqcQigO3upwlZ3TTB+XLmd6uGk26ukSuHypfFoDX/UTHOQuHfrkkWDiWWURsENY1JLr+ApbhMUkUJ5zrPgE6sW4J9DoESt4CPnCYs/D/i3glutb1f2+UKRAA59aPremO8PDE+LzISuAbNP1XriM6RcV1smjXUj5+sKy9UCrCNxiOno62WrKJVOXrX2mumcNIx+3SIY+6SrrjZGU8Z9mTkrgDdUv1U0WSIFyfl65hfe/Tcvw8T0FIVijfQgx5tg+UKASZRxBvIrV22VjGipKS91Ot5oOdOE84FCNM8AEALSkABEnI0oKhQa4DTvXh0ul9bIKKn5CxtN/COTx+3u9y4SVw5GNLdTxtGTWhZ07NmoUaSJiq7diVwS8LIw1Bs4507svbO8ZTvtgFGGK5Ro0oDF6BehRw3/yWy8Y/C8m2qOXi8k1Oqk0BL6nz7HQ1tgfWsClQTa1TBC4vA09N9zcVC5lN/6KqpTGsnE64s0R6Kaw5ea2N9KaDlZag0bJtctK7wY9csD0mknsV0Ei3lCix3ZKdsl1ukkVJRJz6Iu5JX8SHXE3rzf98LPDeYytopxmk49DyKcswiBFECHcJP8zv2NrM4iFyBvBlVz5mjGfxEBsy0Ij+wLZexO52umH78PIzjvl6L7RQuoWxR6zeKkDLcZJfzxC7zLi8VZQOC2IIzJhByUnfbigoW9xXupQI=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB6816.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(66476007)(38100700002)(4326008)(36756003)(6512007)(33656002)(54906003)(6486002)(26005)(44832011)(6916009)(5660300002)(186003)(38350700002)(8936002)(66556008)(316002)(8676002)(2616005)(66946007)(53546011)(2906002)(956004)(83380400001)(52116002)(86362001)(6506007)(508600001)(6666004)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB5968
Original-Authentication-Results: kernel.org; dkim=none (message not signed)
 header.d=none;kernel.org; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT055.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	07f42f20-fbc6-45b0-36d5-08d98d575733
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	e5bI/jRlBja4DK1eOqZBxptarcZ1z2lPNn6dtxslYimSGDqCD+JYVEDL/nvMmUBDJXN45yLJLlXk9YqFcjz1M7rafMJigzTGtXr3A+HmO8x2mH/LysEIWmXcXGwQV9ZEXYpkPWR6r57+49WE2psydOAocc85rhc/Hj5k/lG5O1vYHvCj57NOzmnwAFLzZzAWEstO+DojVick5j5P8w28ayPdJPr5lCv6lp6z/WMciQQ5fOonxrOrHwj07Eg+rxxcmMda5i38JVocORRARJOCqumyVz5j015+whKRLYMdx6xjdP1oKVqy20nqEcSUmq+p+GyEt09Zkrn/qYasXBsuUedwAjrsYZGQxjxWFBotoLLMZswWcJpjxIMpN1yvABu1j1jx4LZVzeCpYMcM9zspippPhTsCVOKI45nd3TbSfwizxEJRnYxP6IIGgB2d7ZMRVV0aMR/rnF8kELz7LAQ+tMP5ihcMnVUIZYSAf3B8ybGaxeSB9DHWwduOArpsceWRClF3rKS9qhlggGEoKoyphm0O+o7b8Lpj613F7bAUKl9x/QHvXtimAHhxmDHPLjxlZmwAvzdSU5CqmgvtDUIRP3F/Ngpn6rOUP/DBlwt/r5sah0nWSNvSUr7Xhw/fl/ko7N1+nyaJnModJbOLI/vbhXKX0Sw1FmGzTDtxGrhck6XdF81wREplVHpizqtgVckevGU28GKHlsHoNXM3VjBtvA==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(316002)(36860700001)(6862004)(54906003)(47076005)(508600001)(86362001)(8676002)(4326008)(2906002)(5660300002)(36756003)(44832011)(6506007)(6512007)(83380400001)(26005)(336012)(6666004)(2616005)(8936002)(70206006)(956004)(6486002)(70586007)(81166007)(186003)(33656002)(53546011)(356005)(82310400003);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2021 08:07:44.6200
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: b17df41a-2d2f-4577-0ec7-08d98d575f11
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT055.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0801MB1655



> On 12 Oct 2021, at 02:31, Stefano Stabellini <sstabellini@kernel.org> wro=
te:
>=20
> On Mon, 11 Oct 2021, Julien Grall wrote:
>> Hi Stefano,
>>=20
>> On 11/10/2021 22:24, Stefano Stabellini wrote:
>>>> diff --git a/xen/arch/arm/efi/efi-boot.h b/xen/arch/arm/efi/efi-boot.h
>>>> index 840728d6c0..076b827bdd 100644
>>>> --- a/xen/arch/arm/efi/efi-boot.h
>>>> +++ b/xen/arch/arm/efi/efi-boot.h
>>>> @@ -713,10 +713,12 @@ static int __init handle_module_node(EFI_FILE_HA=
NDLE
>>>> dir_handle,
>>>>      char mod_string[24]; /* Placeholder for module@ + a 64-bit number=
 +
>>>> \0 */
>>>>      int uefi_name_len, file_idx, module_compat;
>>>>      module_name *file;
>>>> +    const char *compat_string =3D is_domu_module ? "multiboot,module"=
 :
>>>> +                                "xen,multiboot-module";
>>>>        /* Check if the node is a multiboot,module otherwise return */
>>>>      module_compat =3D fdt_node_check_compatible(fdt, module_node_offs=
et,
>>>> -                                              "multiboot,module");
>>>> +                                              compat_string);
>>>>      if ( module_compat < 0 )
>>>>          /* Error while checking the compatible string */
>>>>          return ERROR_CHECK_MODULE_COMPAT;
>>>=20
>>>=20
>>> Well... not exactly like this because this would stop a normal
>>> "multiboot,module" dom0 kernel from being recognized.
>>>=20
>>> So we need for domU: only "multiboot,module"
>>> For Dom0, either "multiboot,module" or "xen,multiboot-module"
>>=20
>> Looking at the history, xen,multiboot-module has been considered as a le=
gacy
>> binding since before UEFI was introduced. In fact, without this series, =
I
>> believe, there is limited reasons for the compatible to be present in th=
e DT
>> as you would either use grub (which use the new compatible) or xen.cfg (=
the
>> stub will create the node).
>>=20
>> So I would argue that this compatible should not be used in combination =
with
>> UEFI and therefore we should not handle it. This would make the code sim=
pler
>> :).
>=20

Hi Stefano,

> What you suggested is a viable option, however ImageBuilder is still
> using the "xen,multiboot-module" format somehow today (no idea why) and
> we have the following written in docs/misc/arm/device-tree/booting.txt:
>=20
> 	Xen 4.4 supported a different set of legacy compatible strings
> 	which remain supported such that systems supporting both 4.4
> 	and later can use a single DTB.
>=20
> 	- "xen,multiboot-module" equivalent to "multiboot,module"
> 	- "xen,linux-zimage"     equivalent to "multiboot,kernel"
> 	- "xen,linux-initrd"     equivalent to "multiboot,ramdisk"
>=20
> 	For compatibility with Xen 4.4 the more specific "xen,linux-*"
> 	names are non-optional and must be included.
>=20
> My preference is to avoid breaking compatibility (even with UEFI
> booting). The way I suggested above is one way to do it.
>=20
> But I don't feel strongly about this at all, I am fine with ignoring
> "xen,multiboot-module" in the EFI stub. I can get ImageBuilder fixed
> very quickly (I should do that in any case). If we are going to ignore
> "xen,multiboot-module" then we probably want to update the text in
> docs/misc/arm/device-tree/booting.txt also.

The changes to support legacy compatible strings can be done but it will re=
sult in
complex code, I would go for Julien suggestion to just drop it for UEFI.

I can add a note on docs/misc/arm/device-tree/booting.txt saying that for U=
EFI boot
the legacy strings are not supported.

Something like:

--- a/docs/misc/arm/device-tree/booting.txt
+++ b/docs/misc/arm/device-tree/booting.txt
@@ -51,6 +51,8 @@ Each node contains the following properties:
        Xen 4.4 supported a different set of legacy compatible strings
        which remain supported such that systems supporting both 4.4
        and later can use a single DTB.
+       However when booting Xen using UEFI and Device Tree, the legacy com=
patible
+       strings are not supported.
=20
        - "xen,multiboot-module" equivalent to "multiboot,module"
        - "xen,linux-zimage"     equivalent to "multiboot,kernel=E2=80=9D


What do you think about that?

Cheers,
Luca



From xen-devel-bounces@lists.xenproject.org Tue Oct 12 08:13:59 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 08:13:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.206864.362555 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maCv8-0000z4-VX; Tue, 12 Oct 2021 08:13:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 206864.362555; Tue, 12 Oct 2021 08:13:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maCv8-0000yt-SG; Tue, 12 Oct 2021 08:13:58 +0000
Received: by outflank-mailman (input) for mailman id 206864;
 Tue, 12 Oct 2021 08:13:57 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=lNhP=PA=arm.com=michal.orzel@srs-us1.protection.inumbo.net>)
 id 1maCv6-0008RX-VI
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 08:13:57 +0000
Received: from foss.arm.com (unknown [217.140.110.172])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTP
 id 5335a8e3-a0bb-4acd-8631-c3f7c8b9aa6a;
 Tue, 12 Oct 2021 08:13:50 +0000 (UTC)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id DE77DED1;
 Tue, 12 Oct 2021 01:13:49 -0700 (PDT)
Received: from e123311-lin.arm.com (unknown [10.57.27.99])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 893EE3F694;
 Tue, 12 Oct 2021 01:13:46 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5335a8e3-a0bb-4acd-8631-c3f7c8b9aa6a
From: Michal Orzel <michal.orzel@arm.com>
To: xen-devel@lists.xenproject.org
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Ian Jackson <iwj@xenproject.org>,
	Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wl@xen.org>,
	Nick Rosbrook <rosbrookn@ainfosec.com>,
	Anthony PERARD <anthony.perard@citrix.com>,
	Juergen Gross <jgross@suse.com>,
	Christian Lindig <christian.lindig@citrix.com>,
	David Scott <dave@recoil.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	bertrand.marquis@arm.com
Subject: [PATCH v5 3/3] xen: Expose the PMU to the guests
Date: Tue, 12 Oct 2021 10:13:23 +0200
Message-Id: <20211012081323.14141-4-michal.orzel@arm.com>
X-Mailer: git-send-email 2.29.0
In-Reply-To: <20211012081323.14141-1-michal.orzel@arm.com>
References: <20211012081323.14141-1-michal.orzel@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Add parameter vpmu to xl domain configuration syntax
to enable the access to PMU registers by disabling
the PMU traps(currently only for ARM).

The current status is that the PMU registers are not
virtualized and the physical registers are directly
accessible when this parameter is enabled. There is no
interrupt support and Xen will not save/restore the
register values on context switches.

According to Arm Arm, section D7.1:
"The Performance Monitors Extension is common
to AArch64 operation and AArch32 operation."
That means we have an ensurance that if PMU is
present in one exception state, it must also be
present in the other.

Please note that this feature is experimental.

Signed-off-by: Michal Orzel <michal.orzel@arm.com>
Signed-off-by: Julien Grall <julien@xen.org>
Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>
---
Changes since v4:
-update SUPPORT.md
-move vpmu_is_available assignment after the secondary
CPUs have been brought up
-introduce masks for flags that need to be set and
for flags that are optional
Changes since v3:
-fail if vpmu is set but not supported
Changes since v2:
-remove redundant check from x86 code
-do not define bit position and mask separately
Changes since v1:
-modify vpmu parameter to be common rather than arch specific
---
 SUPPORT.md                           |  9 +++++++++
 docs/man/xl.cfg.5.pod.in             | 17 +++++++++++++++++
 tools/golang/xenlight/helpers.gen.go |  6 ++++++
 tools/golang/xenlight/types.gen.go   |  1 +
 tools/include/libxl.h                |  6 ++++++
 tools/libs/light/libxl_create.c      | 10 ++++++++++
 tools/libs/light/libxl_types.idl     |  2 ++
 tools/ocaml/libs/xc/xenctrl.ml       |  1 +
 tools/ocaml/libs/xc/xenctrl.mli      |  1 +
 tools/xl/xl_parse.c                  |  2 ++
 xen/arch/arm/domain.c                | 13 ++++++++++---
 xen/arch/arm/setup.c                 |  3 +++
 xen/common/domain.c                  | 10 +++++++++-
 xen/include/asm-arm/domain.h         |  1 +
 xen/include/public/domctl.h          |  4 +++-
 15 files changed, 81 insertions(+), 5 deletions(-)

diff --git a/SUPPORT.md b/SUPPORT.md
index 317392d8f3..2f1f60c49a 100644
--- a/SUPPORT.md
+++ b/SUPPORT.md
@@ -256,6 +256,15 @@ from dom0.
 
     Status, x86: Tech Preview
 
+### vPMU support
+
+Support for accessing PMU registers from the guests.
+There is no interrupt support and Xen will not save/restore
+the register values on context switches.
+Disabled by default (enable with guest parameter).
+
+    Status, ARM: Experimental
+
 ## Memory Management
 
 ### Dynamic memory control
diff --git a/docs/man/xl.cfg.5.pod.in b/docs/man/xl.cfg.5.pod.in
index 4b1e3028d2..55c4881205 100644
--- a/docs/man/xl.cfg.5.pod.in
+++ b/docs/man/xl.cfg.5.pod.in
@@ -690,6 +690,23 @@ default.
 B<NOTE>: Acceptable values are platform specific.  For Intel Processor
 Trace, this value must be a power of 2 between 4k and 16M.
 
+=item B<vpmu=BOOLEAN>
+
+Currently ARM only.
+
+Specifies whether to enable the access to PMU registers by disabling
+the PMU traps.
+
+The PMU registers are not virtualized and the physical registers are directly
+accessible when this parameter is enabled. There is no interrupt support and
+Xen will not save/restore the register values on context switches.
+
+vPMU, by design and purpose, exposes system level performance
+information to the guest. Only to be used by sufficiently privileged
+domains. This feature is currently in experimental state.
+
+If this option is not specified then it will default to B<false>.
+
 =back
 
 =head2 Devices
diff --git a/tools/golang/xenlight/helpers.gen.go b/tools/golang/xenlight/helpers.gen.go
index c8669837d8..2449580bad 100644
--- a/tools/golang/xenlight/helpers.gen.go
+++ b/tools/golang/xenlight/helpers.gen.go
@@ -1119,6 +1119,9 @@ return fmt.Errorf("converting field ArchX86.MsrRelaxed: %v", err)
 }
 x.Altp2M = Altp2MMode(xc.altp2m)
 x.VmtraceBufKb = int(xc.vmtrace_buf_kb)
+if err := x.Vpmu.fromC(&xc.vpmu);err != nil {
+return fmt.Errorf("converting field Vpmu: %v", err)
+}
 
  return nil}
 
@@ -1600,6 +1603,9 @@ return fmt.Errorf("converting field ArchX86.MsrRelaxed: %v", err)
 }
 xc.altp2m = C.libxl_altp2m_mode(x.Altp2M)
 xc.vmtrace_buf_kb = C.int(x.VmtraceBufKb)
+if err := x.Vpmu.toC(&xc.vpmu); err != nil {
+return fmt.Errorf("converting field Vpmu: %v", err)
+}
 
  return nil
  }
diff --git a/tools/golang/xenlight/types.gen.go b/tools/golang/xenlight/types.gen.go
index 45f2cba3d2..b2e8bd1a85 100644
--- a/tools/golang/xenlight/types.gen.go
+++ b/tools/golang/xenlight/types.gen.go
@@ -521,6 +521,7 @@ MsrRelaxed Defbool
 }
 Altp2M Altp2MMode
 VmtraceBufKb int
+Vpmu Defbool
 }
 
 type DomainBuildInfoTypeUnion interface {
diff --git a/tools/include/libxl.h b/tools/include/libxl.h
index ec5e3badae..ee73eb06f1 100644
--- a/tools/include/libxl.h
+++ b/tools/include/libxl.h
@@ -508,6 +508,12 @@
  */
 #define LIBXL_HAVE_PHYSINFO_CAP_VPMU 1
 
+/*
+ * LIBXL_HAVE_VPMU indicates that libxl_domain_build_info has a vpmu parameter,
+ * which allows to enable the access to PMU registers.
+ */
+#define LIBXL_HAVE_VPMU 1
+
 /*
  * libxl ABI compatibility
  *
diff --git a/tools/libs/light/libxl_create.c b/tools/libs/light/libxl_create.c
index e356b2106d..2a0234ec16 100644
--- a/tools/libs/light/libxl_create.c
+++ b/tools/libs/light/libxl_create.c
@@ -91,6 +91,7 @@ int libxl__domain_build_info_setdefault(libxl__gc *gc,
     }
 
     libxl_defbool_setdefault(&b_info->device_model_stubdomain, false);
+    libxl_defbool_setdefault(&b_info->vpmu, false);
 
     if (libxl_defbool_val(b_info->device_model_stubdomain) &&
         !b_info->device_model_ssidref)
@@ -622,6 +623,9 @@ int libxl__domain_make(libxl__gc *gc, libxl_domain_config *d_config,
                 create.flags |= XEN_DOMCTL_CDF_nested_virt;
         }
 
+        if ( libxl_defbool_val(b_info->vpmu) )
+            create.flags |= XEN_DOMCTL_CDF_vpmu;
+
         assert(info->passthrough != LIBXL_PASSTHROUGH_DEFAULT);
         LOG(DETAIL, "passthrough: %s",
             libxl_passthrough_to_string(info->passthrough));
@@ -1199,6 +1203,12 @@ int libxl__domain_config_setdefault(libxl__gc *gc,
         goto error_out;
     }
 
+    if (libxl_defbool_val(d_config->b_info.vpmu) && !physinfo.cap_vpmu) {
+        ret = ERROR_INVAL;
+        LOGD(ERROR, domid, "vpmu not supported on this platform\n");
+        goto error_out;
+    }
+
     ret = 0;
  error_out:
     return ret;
diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_types.idl
index 993e83acca..b96fb5c47e 100644
--- a/tools/libs/light/libxl_types.idl
+++ b/tools/libs/light/libxl_types.idl
@@ -655,6 +655,8 @@ libxl_domain_build_info = Struct("domain_build_info",[
     # Use zero value to disable this feature.
     ("vmtrace_buf_kb", integer),
 
+    ("vpmu", libxl_defbool),
+
     ], dir=DIR_IN,
        copy_deprecated_fn="libxl__domain_build_info_copy_deprecated",
 )
diff --git a/tools/ocaml/libs/xc/xenctrl.ml b/tools/ocaml/libs/xc/xenctrl.ml
index 7a4030a192..86758babb3 100644
--- a/tools/ocaml/libs/xc/xenctrl.ml
+++ b/tools/ocaml/libs/xc/xenctrl.ml
@@ -70,6 +70,7 @@ type domain_create_flag =
 	| CDF_IOMMU
 	| CDF_NESTED_VIRT
 	| CDF_VPCI
+	| CDF_VPMU
 
 type domain_create_iommu_opts =
 	| IOMMU_NO_SHAREPT
diff --git a/tools/ocaml/libs/xc/xenctrl.mli b/tools/ocaml/libs/xc/xenctrl.mli
index 6900513e7f..0fdb0cc169 100644
--- a/tools/ocaml/libs/xc/xenctrl.mli
+++ b/tools/ocaml/libs/xc/xenctrl.mli
@@ -63,6 +63,7 @@ type domain_create_flag =
   | CDF_IOMMU
   | CDF_NESTED_VIRT
   | CDF_VPCI
+  | CDF_VPMU
 
 type domain_create_iommu_opts =
   | IOMMU_NO_SHAREPT
diff --git a/tools/xl/xl_parse.c b/tools/xl/xl_parse.c
index 17dddb4cd5..c503b9be00 100644
--- a/tools/xl/xl_parse.c
+++ b/tools/xl/xl_parse.c
@@ -2750,6 +2750,8 @@ skip_usbdev:
                     "If it fixes an issue you are having please report to "
                     "xen-devel@lists.xenproject.org.\n");
 
+    xlu_cfg_get_defbool(config, "vpmu", &b_info->vpmu, 0);
+
     xlu_cfg_destroy(config);
 }
 
diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
index aae4472479..ad21c9b950 100644
--- a/xen/arch/arm/domain.c
+++ b/xen/arch/arm/domain.c
@@ -276,6 +276,8 @@ static void ctxt_switch_to(struct vcpu *n)
      * timer. The interrupt needs to be injected into the guest. */
     WRITE_SYSREG(n->arch.cntkctl, CNTKCTL_EL1);
     virt_timer_restore(n);
+
+    WRITE_SYSREG(n->arch.mdcr_el2, MDCR_EL2);
 }
 
 /* Update per-VCPU guest runstate shared memory area (if registered). */
@@ -586,6 +588,10 @@ int arch_vcpu_create(struct vcpu *v)
 
     v->arch.hcr_el2 = get_default_hcr_flags();
 
+    v->arch.mdcr_el2 = HDCR_TDRA | HDCR_TDOSA | HDCR_TDA;
+    if ( !(v->domain->options & XEN_DOMCTL_CDF_vpmu) )
+        v->arch.mdcr_el2 |= HDCR_TPM | HDCR_TPMCR;
+
     if ( (rc = vcpu_vgic_init(v)) != 0 )
         goto fail;
 
@@ -621,10 +627,11 @@ void vcpu_switch_to_aarch64_mode(struct vcpu *v)
 int arch_sanitise_domain_config(struct xen_domctl_createdomain *config)
 {
     unsigned int max_vcpus;
+    unsigned int flags_required = (XEN_DOMCTL_CDF_hvm | XEN_DOMCTL_CDF_hap);
+    unsigned int flags_optional = (XEN_DOMCTL_CDF_iommu | XEN_DOMCTL_CDF_vpci |
+                                   XEN_DOMCTL_CDF_vpmu);
 
-    /* HVM and HAP must be set. IOMMU and VPCI may or may not be */
-    if ( (config->flags & ~XEN_DOMCTL_CDF_iommu & ~XEN_DOMCTL_CDF_vpci) !=
-         (XEN_DOMCTL_CDF_hvm | XEN_DOMCTL_CDF_hap) )
+    if ( (config->flags & ~flags_optional) != flags_required )
     {
         dprintk(XENLOG_INFO, "Unsupported configuration %#x\n",
                 config->flags);
diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c
index 49dc90d198..d5d0792ed4 100644
--- a/xen/arch/arm/setup.c
+++ b/xen/arch/arm/setup.c
@@ -999,6 +999,9 @@ void __init start_xen(unsigned long boot_phys_offset,
     printk("Brought up %ld CPUs\n", (long)num_online_cpus());
     /* TODO: smp_cpus_done(); */
 
+    /* This should be done in a vpmu driver but we do not have one yet. */
+    vpmu_is_available = cpu_has_pmu;
+
     /*
      * The IOMMU subsystem must be initialized before P2M as we need
      * to gather requirements regarding the maximum IPA bits supported by
diff --git a/xen/common/domain.c b/xen/common/domain.c
index 262b6c0c3c..8543fb54fd 100644
--- a/xen/common/domain.c
+++ b/xen/common/domain.c
@@ -480,12 +480,14 @@ static int sanitise_domain_config(struct xen_domctl_createdomain *config)
     bool hvm = config->flags & XEN_DOMCTL_CDF_hvm;
     bool hap = config->flags & XEN_DOMCTL_CDF_hap;
     bool iommu = config->flags & XEN_DOMCTL_CDF_iommu;
+    bool vpmu = config->flags & XEN_DOMCTL_CDF_vpmu;
 
     if ( config->flags &
          ~(XEN_DOMCTL_CDF_hvm | XEN_DOMCTL_CDF_hap |
            XEN_DOMCTL_CDF_s3_integrity | XEN_DOMCTL_CDF_oos_off |
            XEN_DOMCTL_CDF_xs_domain | XEN_DOMCTL_CDF_iommu |
-           XEN_DOMCTL_CDF_nested_virt | XEN_DOMCTL_CDF_vpci) )
+           XEN_DOMCTL_CDF_nested_virt | XEN_DOMCTL_CDF_vpci |
+           XEN_DOMCTL_CDF_vpmu) )
     {
         dprintk(XENLOG_INFO, "Unknown CDF flags %#x\n", config->flags);
         return -EINVAL;
@@ -534,6 +536,12 @@ static int sanitise_domain_config(struct xen_domctl_createdomain *config)
         return -EINVAL;
     }
 
+    if ( vpmu && !vpmu_is_available )
+    {
+        dprintk(XENLOG_INFO, "vpmu requested but cannot be enabled this way\n");
+        return -EINVAL;
+    }
+
     return arch_sanitise_domain_config(config);
 }
 
diff --git a/xen/include/asm-arm/domain.h b/xen/include/asm-arm/domain.h
index c9277b5c6d..14e575288f 100644
--- a/xen/include/asm-arm/domain.h
+++ b/xen/include/asm-arm/domain.h
@@ -166,6 +166,7 @@ struct arch_vcpu
 
     /* HYP configuration */
     register_t hcr_el2;
+    register_t mdcr_el2;
 
     uint32_t teecr, teehbr; /* ThumbEE, 32-bit guests only */
 #ifdef CONFIG_ARM_32
diff --git a/xen/include/public/domctl.h b/xen/include/public/domctl.h
index 4cb3f662c2..a53cbd16f4 100644
--- a/xen/include/public/domctl.h
+++ b/xen/include/public/domctl.h
@@ -71,9 +71,11 @@ struct xen_domctl_createdomain {
 #define _XEN_DOMCTL_CDF_nested_virt   6
 #define XEN_DOMCTL_CDF_nested_virt    (1U << _XEN_DOMCTL_CDF_nested_virt)
 #define XEN_DOMCTL_CDF_vpci           (1U << 7)
+/* Should we expose the vPMU to the guest? */
+#define XEN_DOMCTL_CDF_vpmu           (1U << 8)
 
 /* Max XEN_DOMCTL_CDF_* constant.  Used for ABI checking. */
-#define XEN_DOMCTL_CDF_MAX XEN_DOMCTL_CDF_vpci
+#define XEN_DOMCTL_CDF_MAX XEN_DOMCTL_CDF_vpmu
 
     uint32_t flags;
 
-- 
2.29.0



From xen-devel-bounces@lists.xenproject.org Tue Oct 12 08:13:59 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 08:13:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.206863.362544 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maCv3-0000cV-Mp; Tue, 12 Oct 2021 08:13:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 206863.362544; Tue, 12 Oct 2021 08:13:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maCv3-0000cL-Jc; Tue, 12 Oct 2021 08:13:53 +0000
Received: by outflank-mailman (input) for mailman id 206863;
 Tue, 12 Oct 2021 08:13:52 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=lNhP=PA=arm.com=michal.orzel@srs-us1.protection.inumbo.net>)
 id 1maCv1-0008RX-V9
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 08:13:51 +0000
Received: from foss.arm.com (unknown [217.140.110.172])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTP
 id 6dd81224-02b3-4a37-93d3-3039d4c0fd52;
 Tue, 12 Oct 2021 08:13:46 +0000 (UTC)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2A3861063;
 Tue, 12 Oct 2021 01:13:46 -0700 (PDT)
Received: from e123311-lin.arm.com (unknown [10.57.27.99])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B0EBC3F694;
 Tue, 12 Oct 2021 01:13:44 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6dd81224-02b3-4a37-93d3-3039d4c0fd52
From: Michal Orzel <michal.orzel@arm.com>
To: xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	bertrand.marquis@arm.com
Subject: [PATCH v5 2/3] xen/arm: Check for PMU platform support
Date: Tue, 12 Oct 2021 10:13:22 +0200
Message-Id: <20211012081323.14141-3-michal.orzel@arm.com>
X-Mailer: git-send-email 2.29.0
In-Reply-To: <20211012081323.14141-1-michal.orzel@arm.com>
References: <20211012081323.14141-1-michal.orzel@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

ID_AA64DFR0_EL1/ID_DFR0_EL1 registers provide
information about PMU support. Replace structure
dbg64/dbg32 with a union and fill in all the
register fields according to document:
ARM Architecture Registers(DDI 0595, 2021-06).

Add macros boot_dbg_feature64/boot_dbg_feature32
to check for a debug feature. Add macro
cpu_has_pmu to check for PMU support.
Any value higher than 0 and less than 15 means
that PMU is supported (we do not care about its
version for now).

Signed-off-by: Michal Orzel <michal.orzel@arm.com>
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>
---
Changes since v4:
-improve checks for PMU
Changes since v3:
-none
Changes since v2:
-none
Changes since v1:
-new in v2
---
 xen/include/asm-arm/cpufeature.h | 51 ++++++++++++++++++++++++++++++--
 1 file changed, 49 insertions(+), 2 deletions(-)

diff --git a/xen/include/asm-arm/cpufeature.h b/xen/include/asm-arm/cpufeature.h
index 5ca09b0bff..0ddf38858a 100644
--- a/xen/include/asm-arm/cpufeature.h
+++ b/xen/include/asm-arm/cpufeature.h
@@ -4,6 +4,7 @@
 #ifdef CONFIG_ARM_64
 #define cpu_feature64(c, feat)         ((c)->pfr64.feat)
 #define boot_cpu_feature64(feat)       (system_cpuinfo.pfr64.feat)
+#define boot_dbg_feature64(feat)       (system_cpuinfo.dbg64.feat)
 
 #define cpu_feature64_has_el0_32(c)    (cpu_feature64(c, el0) == 2)
 
@@ -22,6 +23,7 @@
 
 #define cpu_feature32(c, feat)         ((c)->pfr32.feat)
 #define boot_cpu_feature32(feat)       (system_cpuinfo.pfr32.feat)
+#define boot_dbg_feature32(feat)       (system_cpuinfo.dbg32.feat)
 
 #define cpu_has_arm       (boot_cpu_feature32(arm) == 1)
 #define cpu_has_thumb     (boot_cpu_feature32(thumb) >= 1)
@@ -32,8 +34,12 @@
 
 #ifdef CONFIG_ARM_32
 #define cpu_has_gentimer  (boot_cpu_feature32(gentimer) == 1)
+#define cpu_has_pmu       ((boot_dbg_feature32(perfmon) >= 1) && \
+                           (boot_dbg_feature32(perfmon) < 15))
 #else
 #define cpu_has_gentimer  (1)
+#define cpu_has_pmu       ((boot_dbg_feature64(pmu_ver) >= 1) && \
+                           (boot_dbg_feature64(pmu_ver) < 15))
 #endif
 #define cpu_has_security  (boot_cpu_feature32(security) > 0)
 
@@ -181,8 +187,28 @@ struct cpuinfo_arm {
         };
     } pfr64;
 
-    struct {
+    union {
         register_t bits[2];
+        struct {
+            /* DFR0 */
+            unsigned long debug_ver:4;
+            unsigned long trace_ver:4;
+            unsigned long pmu_ver:4;
+            unsigned long brps:4;
+            unsigned long __res0:4;
+            unsigned long wrps:4;
+            unsigned long __res1:4;
+            unsigned long ctx_cmps:4;
+            unsigned long pms_ver:4;
+            unsigned long double_lock:4;
+            unsigned long trace_filt:4;
+            unsigned long __res2:4;
+            unsigned long mtpmu:4;
+            unsigned long __res3:12;
+
+            /* DFR1 */
+            unsigned long __res4:64;
+        };
     } dbg64;
 
     struct {
@@ -321,8 +347,29 @@ struct cpuinfo_arm {
         };
     } pfr32;
 
-    struct {
+    union {
         register_t bits[2];
+        struct {
+            /* DFR0 */
+            unsigned long copdbg:4;
+            unsigned long copsdbg:4;
+            unsigned long mmapdbg:4;
+            unsigned long coptrc:4;
+            unsigned long mmaptrc:4;
+            unsigned long mprofdbg:4;
+            unsigned long perfmon:4;
+            unsigned long tracefilt:4;
+#ifdef CONFIG_ARM_64
+            unsigned long __res0:32;
+#endif
+
+            /* DFR1 */
+            unsigned long mtpmu:4;
+            unsigned long __res1:28;
+#ifdef CONFIG_ARM_64
+            unsigned long __res2:32;
+#endif
+        };
     } dbg32;
 
     struct {
-- 
2.29.0



From xen-devel-bounces@lists.xenproject.org Tue Oct 12 08:14:01 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 08:14:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.206861.362522 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maCut-0008Rk-7j; Tue, 12 Oct 2021 08:13:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 206861.362522; Tue, 12 Oct 2021 08:13:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maCut-0008Rd-3K; Tue, 12 Oct 2021 08:13:43 +0000
Received: by outflank-mailman (input) for mailman id 206861;
 Tue, 12 Oct 2021 08:13:42 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=lNhP=PA=arm.com=michal.orzel@srs-us1.protection.inumbo.net>)
 id 1maCus-0008RX-2b
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 08:13:42 +0000
Received: from foss.arm.com (unknown [217.140.110.172])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTP
 id adb86a57-9eab-4fe5-81aa-b5f7cceecdac;
 Tue, 12 Oct 2021 08:13:40 +0000 (UTC)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8522EED1;
 Tue, 12 Oct 2021 01:13:40 -0700 (PDT)
Received: from e123311-lin.arm.com (unknown [10.57.27.99])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 117383F694;
 Tue, 12 Oct 2021 01:13:36 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: adb86a57-9eab-4fe5-81aa-b5f7cceecdac
From: Michal Orzel <michal.orzel@arm.com>
To: xen-devel@lists.xenproject.org
Cc: George Dunlap <george.dunlap@citrix.com>,
	Nick Rosbrook <rosbrookn@ainfosec.com>,
	Ian Jackson <iwj@xenproject.org>,
	Wei Liu <wl@xen.org>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Anthony PERARD <anthony.perard@citrix.com>,
	Juergen Gross <jgross@suse.com>,
	Christian Lindig <christian.lindig@citrix.com>,
	David Scott <dave@recoil.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	bertrand.marquis@arm.com
Subject: [PATCH v5 0/3] Expose PMU to the guests
Date: Tue, 12 Oct 2021 10:13:20 +0200
Message-Id: <20211012081323.14141-1-michal.orzel@arm.com>
X-Mailer: git-send-email 2.29.0
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

This patch series is a rework of an already pushed patch
exposing PMU to the guests. Since the second version the vpmu
parameter is common and prework in the form of reporting
availability of vPMU on the hardware is added.

The third version of the patch series removes the redundant check
from x86 code and modifies the way to define the flags XEN_DOMCTL_CDF and
XEN_SYSCTL_PHYSCAP, meaning not to define bit position and mask separately.

In the fourth version, the additional check is added so that we fail
if vpmu is set in the config file but XEN_SYSCTL_PHYSCAP_vpmu is not available.

In the fifth version, SUPPORT.md is updated with the information about
vPMU feature and checks for platform PMU support are improved.

The current status is that the PMU registers are not virtualized
and the physical registers are directly accessible when "vpmu"
parameter is enabled in the guest config file. There is no interrupt
support and Xen will not save/restore the register values on context
switches. This is to be done in the future.

Michal Orzel (3):
  xen+tools: Introduce XEN_SYSCTL_PHYSCAP_vpmu
  xen/arm: Check for PMU platform support
  xen: Expose the PMU to the guests

 SUPPORT.md                           |  9 +++++
 docs/man/xl.cfg.5.pod.in             | 17 ++++++++++
 tools/golang/xenlight/helpers.gen.go |  8 +++++
 tools/golang/xenlight/types.gen.go   |  2 ++
 tools/include/libxl.h                | 12 +++++++
 tools/libs/light/libxl.c             |  1 +
 tools/libs/light/libxl_create.c      | 10 ++++++
 tools/libs/light/libxl_types.idl     |  3 ++
 tools/ocaml/libs/xc/xenctrl.ml       |  2 ++
 tools/ocaml/libs/xc/xenctrl.mli      |  2 ++
 tools/xl/xl_info.c                   |  5 +--
 tools/xl/xl_parse.c                  |  2 ++
 xen/arch/arm/domain.c                | 13 +++++--
 xen/arch/arm/setup.c                 |  3 ++
 xen/common/domain.c                  | 12 ++++++-
 xen/common/sysctl.c                  |  3 ++
 xen/include/asm-arm/cpufeature.h     | 51 ++++++++++++++++++++++++++--
 xen/include/asm-arm/domain.h         |  1 +
 xen/include/public/domctl.h          |  4 ++-
 xen/include/public/sysctl.h          |  6 ++--
 xen/include/xen/domain.h             |  2 ++
 21 files changed, 157 insertions(+), 11 deletions(-)

-- 
2.29.0



From xen-devel-bounces@lists.xenproject.org Tue Oct 12 08:14:01 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 08:14:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.206862.362533 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maCuy-0000Hn-F4; Tue, 12 Oct 2021 08:13:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 206862.362533; Tue, 12 Oct 2021 08:13:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maCuy-0000Hb-BN; Tue, 12 Oct 2021 08:13:48 +0000
Received: by outflank-mailman (input) for mailman id 206862;
 Tue, 12 Oct 2021 08:13:47 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=lNhP=PA=arm.com=michal.orzel@srs-us1.protection.inumbo.net>)
 id 1maCuw-0008RX-V8
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 08:13:46 +0000
Received: from foss.arm.com (unknown [217.140.110.172])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTP
 id 62797bfd-b31b-4777-b009-26179e934a09;
 Tue, 12 Oct 2021 08:13:44 +0000 (UTC)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 506A6ED1;
 Tue, 12 Oct 2021 01:13:44 -0700 (PDT)
Received: from e123311-lin.arm.com (unknown [10.57.27.99])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E43823F694;
 Tue, 12 Oct 2021 01:13:40 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 62797bfd-b31b-4777-b009-26179e934a09
From: Michal Orzel <michal.orzel@arm.com>
To: xen-devel@lists.xenproject.org
Cc: George Dunlap <george.dunlap@citrix.com>,
	Nick Rosbrook <rosbrookn@ainfosec.com>,
	Ian Jackson <iwj@xenproject.org>,
	Wei Liu <wl@xen.org>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Anthony PERARD <anthony.perard@citrix.com>,
	Juergen Gross <jgross@suse.com>,
	Christian Lindig <christian.lindig@citrix.com>,
	David Scott <dave@recoil.org>,
	bertrand.marquis@arm.com
Subject: [PATCH v5 1/3] xen+tools: Introduce XEN_SYSCTL_PHYSCAP_vpmu
Date: Tue, 12 Oct 2021 10:13:21 +0200
Message-Id: <20211012081323.14141-2-michal.orzel@arm.com>
X-Mailer: git-send-email 2.29.0
In-Reply-To: <20211012081323.14141-1-michal.orzel@arm.com>
References: <20211012081323.14141-1-michal.orzel@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Introduce flag XEN_SYSCTL_PHYSCAP_vpmu which
indicates whether the platform supports vPMU
functionality. Modify Xen and tools accordingly.

Take the opportunity and fix XEN_SYSCTL_PHYSCAP_vmtrace
definition in sysctl.h which wrongly use (1 << 6)
instead of (1u << 6).

Signed-off-by: Michal Orzel <michal.orzel@arm.com>
Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>
Acked-by: Nick Rosbrook <rosbrookn@ainfosec.com>
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
Acked-by: Ian Jackson <iwj@xenproject.org>
---
Changes since v4:
-none
Changes since v3:
-add spaces between brackets and keyword
Changes since v2:
-do not define bit position and mask separately
Changes since v1:
-new in v2
---
 tools/golang/xenlight/helpers.gen.go | 2 ++
 tools/golang/xenlight/types.gen.go   | 1 +
 tools/include/libxl.h                | 6 ++++++
 tools/libs/light/libxl.c             | 1 +
 tools/libs/light/libxl_types.idl     | 1 +
 tools/ocaml/libs/xc/xenctrl.ml       | 1 +
 tools/ocaml/libs/xc/xenctrl.mli      | 1 +
 tools/xl/xl_info.c                   | 5 +++--
 xen/common/domain.c                  | 2 ++
 xen/common/sysctl.c                  | 3 +++
 xen/include/public/sysctl.h          | 6 ++++--
 xen/include/xen/domain.h             | 2 ++
 12 files changed, 27 insertions(+), 4 deletions(-)

diff --git a/tools/golang/xenlight/helpers.gen.go b/tools/golang/xenlight/helpers.gen.go
index bfc1e7f312..c8669837d8 100644
--- a/tools/golang/xenlight/helpers.gen.go
+++ b/tools/golang/xenlight/helpers.gen.go
@@ -3360,6 +3360,7 @@ x.CapHap = bool(xc.cap_hap)
 x.CapShadow = bool(xc.cap_shadow)
 x.CapIommuHapPtShare = bool(xc.cap_iommu_hap_pt_share)
 x.CapVmtrace = bool(xc.cap_vmtrace)
+x.CapVpmu = bool(xc.cap_vpmu)
 
  return nil}
 
@@ -3391,6 +3392,7 @@ xc.cap_hap = C.bool(x.CapHap)
 xc.cap_shadow = C.bool(x.CapShadow)
 xc.cap_iommu_hap_pt_share = C.bool(x.CapIommuHapPtShare)
 xc.cap_vmtrace = C.bool(x.CapVmtrace)
+xc.cap_vpmu = C.bool(x.CapVpmu)
 
  return nil
  }
diff --git a/tools/golang/xenlight/types.gen.go b/tools/golang/xenlight/types.gen.go
index 09a3bb67e2..45f2cba3d2 100644
--- a/tools/golang/xenlight/types.gen.go
+++ b/tools/golang/xenlight/types.gen.go
@@ -1008,6 +1008,7 @@ CapHap bool
 CapShadow bool
 CapIommuHapPtShare bool
 CapVmtrace bool
+CapVpmu bool
 }
 
 type Connectorinfo struct {
diff --git a/tools/include/libxl.h b/tools/include/libxl.h
index b9ba16d698..ec5e3badae 100644
--- a/tools/include/libxl.h
+++ b/tools/include/libxl.h
@@ -502,6 +502,12 @@
  */
 #define LIBXL_HAVE_X86_MSR_RELAXED 1
 
+/*
+ * LIBXL_HAVE_PHYSINFO_CAP_VPMU indicates that libxl_physinfo has a cap_vpmu
+ * field, which indicates the availability of vPMU functionality.
+ */
+#define LIBXL_HAVE_PHYSINFO_CAP_VPMU 1
+
 /*
  * libxl ABI compatibility
  *
diff --git a/tools/libs/light/libxl.c b/tools/libs/light/libxl.c
index 204eb0be2d..a032723fde 100644
--- a/tools/libs/light/libxl.c
+++ b/tools/libs/light/libxl.c
@@ -404,6 +404,7 @@ int libxl_get_physinfo(libxl_ctx *ctx, libxl_physinfo *physinfo)
         !!(xcphysinfo.capabilities & XEN_SYSCTL_PHYSCAP_iommu_hap_pt_share);
     physinfo->cap_vmtrace =
         !!(xcphysinfo.capabilities & XEN_SYSCTL_PHYSCAP_vmtrace);
+    physinfo->cap_vpmu = !!(xcphysinfo.capabilities & XEN_SYSCTL_PHYSCAP_vpmu);
 
     GC_FREE;
     return 0;
diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_types.idl
index 3f9fff653a..993e83acca 100644
--- a/tools/libs/light/libxl_types.idl
+++ b/tools/libs/light/libxl_types.idl
@@ -1061,6 +1061,7 @@ libxl_physinfo = Struct("physinfo", [
     ("cap_shadow", bool),
     ("cap_iommu_hap_pt_share", bool),
     ("cap_vmtrace", bool),
+    ("cap_vpmu", bool),
     ], dir=DIR_OUT)
 
 libxl_connectorinfo = Struct("connectorinfo", [
diff --git a/tools/ocaml/libs/xc/xenctrl.ml b/tools/ocaml/libs/xc/xenctrl.ml
index 7ed1c00e47..7a4030a192 100644
--- a/tools/ocaml/libs/xc/xenctrl.ml
+++ b/tools/ocaml/libs/xc/xenctrl.ml
@@ -122,6 +122,7 @@ type physinfo_cap_flag =
 	| CAP_Shadow
 	| CAP_IOMMU_HAP_PT_SHARE
 	| CAP_Vmtrace
+	| CAP_Vpmu
 
 type physinfo =
 {
diff --git a/tools/ocaml/libs/xc/xenctrl.mli b/tools/ocaml/libs/xc/xenctrl.mli
index 391d4abdf8..6900513e7f 100644
--- a/tools/ocaml/libs/xc/xenctrl.mli
+++ b/tools/ocaml/libs/xc/xenctrl.mli
@@ -107,6 +107,7 @@ type physinfo_cap_flag =
   | CAP_Shadow
   | CAP_IOMMU_HAP_PT_SHARE
   | CAP_Vmtrace
+  | CAP_Vpmu
 
 type physinfo = {
   threads_per_core : int;
diff --git a/tools/xl/xl_info.c b/tools/xl/xl_info.c
index 8383e4a6df..2c86b317b7 100644
--- a/tools/xl/xl_info.c
+++ b/tools/xl/xl_info.c
@@ -210,7 +210,7 @@ static void output_physinfo(void)
          info.hw_cap[4], info.hw_cap[5], info.hw_cap[6], info.hw_cap[7]
         );
 
-    maybe_printf("virt_caps              :%s%s%s%s%s%s%s%s\n",
+    maybe_printf("virt_caps              :%s%s%s%s%s%s%s%s%s\n",
          info.cap_pv ? " pv" : "",
          info.cap_hvm ? " hvm" : "",
          info.cap_hvm && info.cap_hvm_directio ? " hvm_directio" : "",
@@ -218,7 +218,8 @@ static void output_physinfo(void)
          info.cap_hap ? " hap" : "",
          info.cap_shadow ? " shadow" : "",
          info.cap_iommu_hap_pt_share ? " iommu_hap_pt_share" : "",
-         info.cap_vmtrace ? " vmtrace" : ""
+         info.cap_vmtrace ? " vmtrace" : "",
+         info.cap_vpmu ? " vpmu" : ""
         );
 
     vinfo = libxl_get_version_info(ctx);
diff --git a/xen/common/domain.c b/xen/common/domain.c
index 40d67ec342..262b6c0c3c 100644
--- a/xen/common/domain.c
+++ b/xen/common/domain.c
@@ -84,6 +84,8 @@ vcpu_info_t dummy_vcpu_info;
 
 bool __read_mostly vmtrace_available;
 
+bool __read_mostly vpmu_is_available;
+
 static void __domain_finalise_shutdown(struct domain *d)
 {
     struct vcpu *v;
diff --git a/xen/common/sysctl.c b/xen/common/sysctl.c
index 3558641cd9..6e7189bb3c 100644
--- a/xen/common/sysctl.c
+++ b/xen/common/sysctl.c
@@ -280,6 +280,9 @@ long do_sysctl(XEN_GUEST_HANDLE_PARAM(xen_sysctl_t) u_sysctl)
         if ( vmtrace_available )
             pi->capabilities |= XEN_SYSCTL_PHYSCAP_vmtrace;
 
+        if ( vpmu_is_available )
+            pi->capabilities |= XEN_SYSCTL_PHYSCAP_vpmu;
+
         if ( copy_to_guest(u_sysctl, op, 1) )
             ret = -EFAULT;
     }
diff --git a/xen/include/public/sysctl.h b/xen/include/public/sysctl.h
index 039ccf885c..fead0e5b53 100644
--- a/xen/include/public/sysctl.h
+++ b/xen/include/public/sysctl.h
@@ -100,10 +100,12 @@ struct xen_sysctl_tbuf_op {
 #define _XEN_SYSCTL_PHYSCAP_iommu_hap_pt_share 5
 #define XEN_SYSCTL_PHYSCAP_iommu_hap_pt_share  \
     (1u << _XEN_SYSCTL_PHYSCAP_iommu_hap_pt_share)
-#define XEN_SYSCTL_PHYSCAP_vmtrace       (1 << 6)
+#define XEN_SYSCTL_PHYSCAP_vmtrace       (1u << 6)
+/* The platform supports vPMU. */
+#define XEN_SYSCTL_PHYSCAP_vpmu          (1u << 7)
 
 /* Max XEN_SYSCTL_PHYSCAP_* constant.  Used for ABI checking. */
-#define XEN_SYSCTL_PHYSCAP_MAX XEN_SYSCTL_PHYSCAP_vmtrace
+#define XEN_SYSCTL_PHYSCAP_MAX XEN_SYSCTL_PHYSCAP_vpmu
 
 struct xen_sysctl_physinfo {
     uint32_t threads_per_core;
diff --git a/xen/include/xen/domain.h b/xen/include/xen/domain.h
index 1708c36964..160c8dbdab 100644
--- a/xen/include/xen/domain.h
+++ b/xen/include/xen/domain.h
@@ -133,4 +133,6 @@ static inline void vnuma_destroy(struct vnuma_info *vnuma) { ASSERT(!vnuma); }
 
 extern bool vmtrace_available;
 
+extern bool vpmu_is_available;
+
 #endif /* __XEN_DOMAIN_H__ */
-- 
2.29.0



From xen-devel-bounces@lists.xenproject.org Tue Oct 12 08:24:36 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 08:24:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.206891.362565 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maD5K-0003QW-5o; Tue, 12 Oct 2021 08:24:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 206891.362565; Tue, 12 Oct 2021 08:24:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maD5K-0003QP-2T; Tue, 12 Oct 2021 08:24:30 +0000
Received: by outflank-mailman (input) for mailman id 206891;
 Tue, 12 Oct 2021 08:24:28 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=xSmm=PA=suse.com=jgross@srs-us1.protection.inumbo.net>)
 id 1maD5I-0003QJ-Ii
 for xen-devel@lists.xen.org; Tue, 12 Oct 2021 08:24:28 +0000
Received: from smtp-out1.suse.de (unknown [195.135.220.28])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id d0366dc4-2b35-11ec-811a-12813bfff9fa;
 Tue, 12 Oct 2021 08:24:27 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 72A0821F2D;
 Tue, 12 Oct 2021 08:24:26 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 51B0113AD5;
 Tue, 12 Oct 2021 08:24:26 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id XtnBEjpGZWHkRwAAMHmgww
 (envelope-from <jgross@suse.com>); Tue, 12 Oct 2021 08:24:26 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d0366dc4-2b35-11ec-811a-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1634027066; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=eZjHPAwxkS2O7gpf6XWworSpUX0ovTDgAwSOnKL33oQ=;
	b=ks/mBVT0A949O5nI8fL8yYYwM4BW7FZBmhNA4+WiL/zYBuWBZu+iH26YEZEcb1qshPIs9a
	vnbBkR0S/aTHhjAWguK6N3RiLidqAf0Yb2m1f2RnSb795hjMgEMi7UpWL4cy6RFJTQEeW4
	0C4fMCGmSJyK1XUyAmFr05WTMw5XFDM=
To: Ryan Cai <ryancaicse@gmail.com>, xen-devel@lists.xen.org,
 ian.jackson@eu.citrix.com
References: <747C0632-F341-4716-8B4A-10428A39A07D@gmail.com>
From: Juergen Gross <jgross@suse.com>
Subject: Re: [BUG] improper locking due to the unreleased lock
Message-ID: <20dccfa2-ec94-f2b0-b357-d6205f55abb4@suse.com>
Date: Tue, 12 Oct 2021 10:24:25 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <747C0632-F341-4716-8B4A-10428A39A07D@gmail.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="czGOlA9TKUk6esJh50Xy9liR95WCObflV"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--czGOlA9TKUk6esJh50Xy9liR95WCObflV
Content-Type: multipart/mixed; boundary="HQx2NjqtF387DvUNPuFJbSNP4wvW5AgM2";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Ryan Cai <ryancaicse@gmail.com>, xen-devel@lists.xen.org,
 ian.jackson@eu.citrix.com
Message-ID: <20dccfa2-ec94-f2b0-b357-d6205f55abb4@suse.com>
Subject: Re: [BUG] improper locking due to the unreleased lock
References: <747C0632-F341-4716-8B4A-10428A39A07D@gmail.com>
In-Reply-To: <747C0632-F341-4716-8B4A-10428A39A07D@gmail.com>

--HQx2NjqtF387DvUNPuFJbSNP4wvW5AgM2
Content-Type: multipart/mixed;
 boundary="------------3288E81149A77D9985814311"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------3288E81149A77D9985814311
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 12.10.21 08:54, Ryan Cai wrote:
> Dear maintainers for Xen Project,
>=20
>  =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
 I am writing you to report a bug due to the unreleased=20
> lock. The impact could be deadlock or memory consumption. In the=20
> function of /read_watch_internal/, the mutex lock /h->watch_mutex/=20
> (*Line901*) is not released correctly when=20
> /read_message(h,nonblocking)=3D=3D -1/(*Line 923*). Looking forward to =
your=20
> feedback. Thank for checking.
>=20
> Locations,=20
> https://github.com/xen-project/xen/blob/master/tools/libs/store/xs.c#L9=
02-L924

Thanks for the report.

 From looking at read_watch_internal() this seems to be right, but this
is no issue in reality.

The missing mutex_unlock() is inside a !USE_PTHREAD section. This
implies muex_lock() and mutex_unlock() being defined as ((void)0),
so there is no risk of anything going wrong.

Even with no risk something going wrong here, the code should be
corrected nevertheless in order to avoid others to stumble over that.


Juergen

--------------3288E81149A77D9985814311
Content-Type: application/pgp-keys;
 name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Transfer-Encoding: quoted-printable
Content-Description: OpenPGP public key
Content-Disposition: attachment;
 filename="OpenPGP_0xB0DE9DD628BF132F.asc"

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy=
cWx
w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O=
f8Z
d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y=
9bf
IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq=
G7/
377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR=
3Jv
c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA=
QIe
AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT=
hpw
dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0=
MbD
1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv=
oPH
Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v=
5QL
+qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ=
2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC=
QoL
BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr=
Wf0
teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC=
/nu
AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh=
ITT
d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm=
XBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz=
80h
SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC=
AcD
AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn=
FOX
gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1=
jnD
kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0=
N51
N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l=
otu
fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1=
tqS
EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA=
hsD
BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3=
g3O
ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5=
dM7
wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5=
D+j
LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm=
V2x
AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N=
Eaw
QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW=
nHI
s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR=
wgn
BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV=
bVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk=
pEd
IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA=
QAB
wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw=
Tbe
8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1=
vJz
Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8=
VGi
wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW=
svi
uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX=
zXs
ZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------3288E81149A77D9985814311--

--HQx2NjqtF387DvUNPuFJbSNP4wvW5AgM2--

--czGOlA9TKUk6esJh50Xy9liR95WCObflV
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmFlRjkFAwAAAAAACgkQsN6d1ii/Ey/0
xQf8CP3spAyQPWOBAezk9NtS2Cp7Ers1AwOK8gn5MdrMfgHnJIJuJ7WAOl2f4Itslh47P/xMszLN
w0AoDZFvLCKWjX7qeDA0JjI5i1FJClkg9vKP4tjRDymE19rKFXis+CwL9UG3rJRFSJfAwoonuF4h
HFhjJ54yiY4cq0t/u9oWCjPyRiI1ELQEY2jW8a8ZokIYkKR0PwNJg/s48sQoLuR/0C0D0s06IdJL
FQyX9C5nGZb5rrSXD66ckweG4zrv7yo+F7a65xJd/sAgDqRX/TqSoPdkQOxHf4TGS4qo9zY3OZSk
p2ul5OEHHSDW2i6MNYXXPjESfcaAnA7BFWGniMkpVw==
=k8lN
-----END PGP SIGNATURE-----

--czGOlA9TKUk6esJh50Xy9liR95WCObflV--


From xen-devel-bounces@lists.xenproject.org Tue Oct 12 08:26:12 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 08:26:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.206897.362577 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maD6y-00042Q-Hx; Tue, 12 Oct 2021 08:26:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 206897.362577; Tue, 12 Oct 2021 08:26:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maD6y-00042J-E2; Tue, 12 Oct 2021 08:26:12 +0000
Received: by outflank-mailman (input) for mailman id 206897;
 Tue, 12 Oct 2021 08:26:11 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=oTzd=PA=citrix.com=christian.lindig@srs-us1.protection.inumbo.net>)
 id 1maD6w-00042B-Sx
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 08:26:11 +0000
Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 897426d9-5904-426a-b48e-ffdfe811a2e3;
 Tue, 12 Oct 2021 08:26:09 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 897426d9-5904-426a-b48e-ffdfe811a2e3
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1634027169;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:mime-version;
  bh=ji27IzYFNo9CFef/uxdfYVof40kw6Z47Kly80gm8LMc=;
  b=bt6iC8jzeILn+a50Jxmo2H8XOqDu+JjhArFGPTGrGJoSJ2rlMXkL2V8m
   CqoavZNbSuDQcJJquBU00dXCkBqvl9fRzbCJxDQapFQGOWQ8SCiu5V8/J
   5AYmzefPEjK2WkkAzz1H5RSOHiBMWkANFItTeCY2a6BXzuXV3IZpUvBm+
   g=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: rFvlZII930Li9SFz08UVjIbWq37B2498gvA2o+J2dZpE8hGb9gsJdpvPmNbd5YEb0rPuXQBMTS
 Yln1bCYRb/tb+eHXUGH59+75rOFGw8k5GAk/3qS79mvujWsT3Tm38T8jY2RSTlrirq3wimSE4q
 gKw8YRR0T95lMn3Myz1VEFgLp0+m4+ySmTKpGBeVUjjQy+slqIEdweJdvVSRgtldlPGIOKg2Tf
 YqpfX/hp140NdN8JmS1bFIikN1IWA5ZEnFNNGHCjDsyUN+V1lt8LSX5cgBI4EGilYr+lOIjeN6
 HQ2KmaIE22IgGfsYElY6vx8z
X-SBRS: 5.1
X-MesageID: 54987477
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:3VqLG6ANOeDEyRVW/wvlw5YqxClBgxIJ4kV8jS/XYbTApDlxgjECx
 jAZXjvQa/6PMTb2e9klOtvj/EIAv8PWz4c1QQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA
 xA2M4GYRCwMo/u1Si6FatANl1ElvU2zbue6WLOs1hxZH1c+EX550Eg7wobVv6Yz6TSHK1LV0
 T/Ni5W31G+Ng1aY5UpNtspvADs21BjDkGtwUm4WPJinj3eH/5UhN7oNJLnZEpfNatI88thW5
 Qr05OrREmvxp3/BAz4++1rxWhVirrX6ZWBihpfKMkQLb9crSiEai84G2PQghUh/kT6nsstO6
 fp3hJ2wQjl1Yqfcnd4+XEwNe81+FfUuFL7vJHG+tYqYzlHccmuqyPJrZK00FdRGoKAtWzgIr
 KFGbmBWBvyAr7veLLaTQel2h98/LcDteocevH1hwhnSDOo8QICFSKLPjTNd9Gps15ARQamBD
 yYfQWF2XUqbOxNlARBUUa4ujt7zt3XCdyIN/Tp5ooJoujOOnWSdyoPFMtXPfceRbd5IhUver
 WXDl0ziGQ0TPtGbzTuD81qvi/XJkCe9X5gdfJW66/prjVu71mEVThoMWjOTq/SjllS3Xd4ZL
 kUO4zcvtoA77kntRd74NzWGp3qDsg8ZSsBnOeQw4wGQyYLZ+w+cQGMDS1ZpZNU4uecsSDct1
 1vPmMnmbRR1t6afU3Wa9bG8pDK0Ny8OIGREbigBJSMV7t+mrIwtgxbnStd4DLXzntDzASv3w
 T2BsG45nbp7pcsK3KWy+RbAmSChorDAVAtz7QLSNkqn5A5kYI+uZ6Sz9EPWq/1HKe6xUV2pr
 HUC3c+E44gmDI6PvDyARv0XG7Ok7OrDNyfT6WODBLF4qW7roST6O9kNvncufy+FL/roZxfza
 2H+ojxwy6ViPXuhU/MraZK0MeclmP2I+cveatjYad9HY55UfQCB/T1zaUP4410BgHTAgolkZ
 s/FKZfE4WIyTP09lmLvFrh1PaoDn3hmnQvuqYbHIwNLOFZ0TEWeTqsZKxOwZ+Q94bLsTO79o
 osHaZXiJ/myVoTDjsjrHWw7cQ5iwZsTX8meRylrmgireFQO9IYJUa65/F/ZU9Y595m5b8+Rl
 p1HZmdWyUDkmVrMIhiQZ3ZoZdvHBMgk9iNkYnx8Ywj1hxDPhLpDCo9FKfPbmpF9pYReIQNcF
 aFZK61s/NweItg4x9jtRcak99EzHPharQmPIzCkcFACk21IHGT0FivfVlK3rkEmV3Pv3eNn+
 uHI/l6LEPIrGlU5ZO6LOa3H8r9ElSVE8A6EdxCTeYc7lYSF2NUCFhEdeddue5tSdk6ZmmfDv
 +tUaD9BzdTwT0YO2IChrYiPrpuzEvs4GUxfHmLB6q2xOzWc9W2mqbKsms7RFdwEfG+rqqike
 8tPyPTwbK8OkFpQ6tIuGLd316MuodDoouYCnAhjGXzKaXWtC69hfSbajZUe6PUVy+8LoxayV
 2KO5sJeZeeDNvT6HQNDPwEidOmCi60Zw2GA8fQvLUzmzyZr577bA15KNhyBhXUFfrt4OY8o2
 8k7v8sS51DtgxYmKI/e3CtV636NPjoLVKB+7sMWB4riiwwKzFBeYMODVn+qsc/XM9gVaxskO
 D6ZgqbGlo9w/EuafiphD2XJ0MpcmY8K5EJAwmgdKgnbgdHCnPI2gkFcqGxlUgRPwxxb+OtvI
 Ww3ZVZtLKCD8jo01shOW2egR1NICBGDoxGjzlIIkCvSTlWyV3yLJ2o4YL7f8Ecc+mNaXz5a4
 LDHlzq1DWe0JJn8jnkoREpoi/3/VtggpATNlfeuE9mBA5RnMyHuhbWjZDZQphbqaS/raJYre
 QW+ED5MVJDG
IronPort-HdrOrdr: A9a23:XFCkbq8DSmFqzxgV1y5uk+DxI+orL9Y04lQ7vn2ZHyYlCvBw8P
 re+MjztCWE7Qr4Ohkb8+xoXZPsfZqyz/JICOUqUotKPzOW2ldATrsD0WK4+UyYJ8SWzIc0vp
 uIFZIRNDSaNykYsS+V2miF+3lL+qj9zEgF792uqEuE7GtRGsdd0zs=
X-IronPort-AV: E=Sophos;i="5.85,367,1624334400"; 
   d="scan'208,217";a="54987477"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=BEEwxDpZlUNMhh6Qij5nKYBtjQzFxGQU8vN3eeosAYDXnoTgdmDzglVAMWbZLHxgISr/wp1GVH/P6dhS4e5j6kemGzx8gplMtMAQ0J35BBMen3iHD+ozsecm/tKckCUG+7TppUEC5KytFBzkICXWhtPonBHp5H9+G3sFyFSvlBsa3ChF64Fi6PpxUjnV1mFyi02zzr46rlxsEtvrYjzwUui4cuZMEEfJ9lb/zaEvV4/MmFAbUmSV/3q2XmN7A0yhEKKNrBs+L0L//cNrdmUw+43/ZZ5dsLSxyopNkiGlSo7PFKhFUuQtV+Lo68Zx7ZKXUdwRHFv5M6gPhVcDKtZFWg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ji27IzYFNo9CFef/uxdfYVof40kw6Z47Kly80gm8LMc=;
 b=NT4Hq4i2zXZ/BUcwbWV0Kaprk+3B69AVo8OzaOkToWTo+sp4x9JSE6xik6sJbafnJK8c8GPqt0fW5cV2uqD1ho2rfCe2KpJjvc5mfFVVcsD6NQrn1fgJtfdSkUFVRkQbrWp2BYs3Ux8eL2mS9mdWzqAAhKzrlGAbMJ69gKYxxCtXL9JLsjA7EStI2q79zN24+qHqzZKqzxRsL0Umce4DN8HrcrdEB0M4HX6b0DmeGIcE6B1qR2t17LQSazQYE2aKRezeFHw9oqbMgudqsDyj+He2ixCefbFhzNbRQ/g+Imav1MmSHDHMoUcelM1g+4fhidoqj2Fa3G98CXmLYJ931g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ji27IzYFNo9CFef/uxdfYVof40kw6Z47Kly80gm8LMc=;
 b=xVJN0YbGujj9X+neM8NLOJZgKnO1w3NilHUaNB3lSezjSxBP+93L2G1eevXE/Zq1aV3jYdaeKeyNiLfNxtnPnWDVmnL3ua0HDByY1XtxG2U7Sop6Mll/Z0I9TYUMaB1LSQ3bH4iObQglLH00Ao/7KMjyNrKXkFF1uMjJzwzq43s=
From: Christian Lindig <christian.lindig@citrix.com>
To: Michal Orzel <michal.orzel@arm.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, "George
 Dunlap" <George.Dunlap@citrix.com>, Nick Rosbrook <rosbrookn@ainfosec.com>,
	Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>, Andrew Cooper
	<Andrew.Cooper3@citrix.com>, Jan Beulich <jbeulich@suse.com>, Julien Grall
	<julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>, Anthony Perard
	<anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>, David Scott
	<dave@recoil.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	"bertrand.marquis@arm.com" <bertrand.marquis@arm.com>
Subject: Re: [PATCH v5 0/3] Expose PMU to the guests
Thread-Topic: [PATCH v5 0/3] Expose PMU to the guests
Thread-Index: AQHXv0Ea8wbdbS6/Ik+7S9shoWs6iavPBwiA
Date: Tue, 12 Oct 2021 08:25:53 +0000
Message-ID: <B7AFA708-2CFC-49FE-8506-046CA789C2C0@citrix.com>
References: <20211012081323.14141-1-michal.orzel@arm.com>
In-Reply-To: <20211012081323.14141-1-michal.orzel@arm.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3608.120.23.2.4)
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 640ccb12-a4e5-45b4-1c7f-08d98d59e837
x-ms-traffictypediagnostic: MWHPR03MB2480:
x-ms-exchange-transport-forked: True
x-microsoft-antispam-prvs: <MWHPR03MB2480C2C9D160C7BF6A220487F6B69@MWHPR03MB2480.namprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:9508;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: LNxK9vXMofvDmDRFm/02zmrFMVIu7fm5ijLi7B9hwX/hXxtLYlmX2WCE82lxhkftK19NEPPI13TCRI4Mcwa4+DX/sF1vYYnJv4IyeQIv/WyTIZf5AH3xNQNCtkQSzY0Vc2pLE8/Jg/wjMO+AqpXpUdGox2P1hvqmRzBJ0UUfxqQjY028vH4mETrhAlZRGR5oNT8iF6pjNKVPx9S2OiDS/HExKDtFTkDcH0vKq9naLBmFW2uC6D5eQwBdAQwGg3ZQuzWk3yZGH804coby6kAnZdagsDrghWbpPgGsrHLP9A4hsf36FHEQrMcWlRDhC9dg2QKBn56Xew278mpdkTTKimbbyXWZpE3My4q27cG+RzlH1qc4h4K9+Gy+TZHMhg9vZZggkpwUbMujRvXZLA/1Wrio1JqxzF786Qw1IfUaPfS/iHd3F+mbx03M/Kuh9zKAASfQEbb+GPk8yRhI1NYGkQ4L5PoaodJ6gwcGzifpnIioTbY6+aOXSVANVdA4GnGCZ8YX0kIUJGdwJ7Bp6AuBiJV4hZsyYoEMjs0KyXcDhrOvBKBQqAfzpLgPUgo+rkTR6BXWXIldryCDajeJR8/jEmgbLjQUJ+3KVIijXid9UrP85jvn+IQtNZPpNZYjgaTDHWwPbrwbB4qn+NE8X0V31L5UpoqU44kMFHWcVED99RIn7RzYjK54Yv1kME2iPvJniorad0LaxKet7v9rn6qapepX1657I7ftQJLrwe97HwOijsa52sLPTw7fzSx5Ezcc
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR03MB6380.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(508600001)(316002)(44832011)(66476007)(2906002)(6512007)(66446008)(33656002)(66556008)(64756008)(6916009)(4326008)(2616005)(71200400001)(54906003)(53546011)(8936002)(186003)(26005)(66946007)(6506007)(7416002)(76116006)(83380400001)(6486002)(86362001)(91956017)(8676002)(122000001)(5660300002)(38070700005)(38100700002)(36756003)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?c3FPbjFZQ3RTMUt0TVlydjk5anBjUyt0emtyV0pQelEyWFJRRFhlb3FaeXR1?=
 =?utf-8?B?S0s3NXJMdklFdGtPQ2JsRnIxK1ZBTDdQUFNqZ3B1ZHIwS3Y3NmF6Z3o4UndI?=
 =?utf-8?B?OWFzdENwb2tpRk9lNWpQd3hLejBCNEo2ZVBFOEd0NW5rYmtYTnVlRFZ5QTFa?=
 =?utf-8?B?UGlDNGRqczZmNW5xTXRUaUNyYnhVa3VKYXdhUkVCUmFRdk83WC92aWpMNUxy?=
 =?utf-8?B?Vk4rUVNpemxIZURnYlR5d2lDcTZKczFSSnVEZzlKaGgrREIwTlpscHE5dlh6?=
 =?utf-8?B?Ky9MQjNZMFBYQlR1cjlwSC9qbjF6YzBvTFBqTVJLM3RqWHBjelViN2xPcnUy?=
 =?utf-8?B?akpsVktMRVArMksxeUpvdGNoU2pOc0VjZmRmT25VbXkyU3BEc2ozSzRzeGJu?=
 =?utf-8?B?cU1aNTk2VnlSZGxCVCswdVhXeG5mQXBGTzc2UmZ4L250RGtpa0VsbkREVlhu?=
 =?utf-8?B?MXMyQ0g0dzRRV00xQUJtbW9YYXJOd2NjUXVwWTUwaUdtblpEeEpMN1NsczF1?=
 =?utf-8?B?cUtBdEh1cGg4aVdYMHl3THRhdzNzZFdRK0lETWlwTVZJYnl5L1duTEZPVy9G?=
 =?utf-8?B?anlhWnZoZHRFWEgxUHBoaGhJRW85a1pTSFZHb1M0SE1JK21LbVFucnJHM0Nv?=
 =?utf-8?B?aDBpL0Y1aVdIVEJENnBiU0FWQ0FsbnJLMm5ZVVNSV05BcFVBeXhva0xjTmlK?=
 =?utf-8?B?VFp5ZlU4YS9HUnM0ZTVTeDV5eDR6dFVoei9odUgzM1VXYTd1VERjRlpxSERM?=
 =?utf-8?B?dUYyM2xOaW42MmR0VWpZU1R2ZU84dzUwemJ4UnlqL3loMWdaTVlEYXc4L3RT?=
 =?utf-8?B?UWtNTWZ1S2RiSlh6dWkrcFhONGpMcXhlWFZheWZiZERlaEd3MERwVE9IZFlD?=
 =?utf-8?B?VUg2QWVVRTcyTlRZS01uSjJOZ2NtRE9vU3lCOUpaaFhXN0hzQXozUDlUNURw?=
 =?utf-8?B?c3J4ODd3QWFVVmZQRXJ6dmY2bCtFemdKZU44emRqRXNUL0UzRFdPck1MYnNy?=
 =?utf-8?B?NXo5S3FnNDN4Q055dkdmZWJPTXkya1RIZ0doamNDTTJpdjB3VS9EWGxpbjlo?=
 =?utf-8?B?TFZ2TmVRRVI5L3F6N0U5eS9Dd3djRGMyaEY4MWtEQ1ZlQVQ5YkRTNWYxL24w?=
 =?utf-8?B?R1dpQUpOSWlLdDMyQ0JJSXNIOWZaN3YwZTJzTjBFQUxFTkFyZXNvL1ZiUWZ4?=
 =?utf-8?B?RUtxWkw1L052ZGxxQ1QwMndLdEhtV0R6NkhNL2sxc3RqWnh1QjJlQmh5bXA4?=
 =?utf-8?B?aUhyWkZRNnJEU3VSam9lZmxWaS9TR3VwYlBlMnlvTmhLa2NUSUROL0Eva1RD?=
 =?utf-8?B?emkrbkZERVE2MXMya3MrdXlBTnU1eFZoKzViWDZBaHdmTnk0UmtUSGJPcjd3?=
 =?utf-8?B?Z3Rxc3hySUtnUWxIdlRwdG4rRU9pajk2elVVN05tMktzY3BVaUtFSk1jSTF3?=
 =?utf-8?B?S3NzakRpT2RVTno1MFdzS3hiRGE3bHpQc3dub0l0SkRGWnRtd0lCMUtYRVRz?=
 =?utf-8?B?YmNCT2dmY2lmdjZta3dKSXhrSnd1Ryt3M1o1K0lXQjhQV1FzWUxGTzhQek9x?=
 =?utf-8?B?OUlpcEo3TmJzOXJMSUpRNWxkQ2tMaTJ3OUFtUzRDMHNMNzNJQWNBUWF3ZDlM?=
 =?utf-8?B?ZktIa2xJVTlBWWZiTkVXYWV6bkZSTnEzT3NFNkxZRjRTb3pyVC8rOFpxNTYw?=
 =?utf-8?B?ZUNzc2IrcWpadDZVcHZuVWlIOTl2SWxsaCtUSlhjNVpYT3hQVFJpZVFidEFS?=
 =?utf-8?B?UlBySXV3VVR3MUxsMW53b0Rib01IVzNYeXgzdURjdkYxS2VzSUcwZkVSZHFi?=
 =?utf-8?B?S1VTYmk2YUFsdFNsdDJDQT09?=
Content-Type: multipart/alternative;
	boundary="_000_B7AFA7082CFC49FE8506046CA789C2C0citrixcom_"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MW4PR03MB6380.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 640ccb12-a4e5-45b4-1c7f-08d98d59e837
X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Oct 2021 08:25:53.5942
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: M/i+guohsM6o824jEv0lU5+f4nyoELQB6fa7xA84/U7cHyZljCaukYua7UePB1r+E4cRnCf+ds1s+XwMuuPQcLTvG2JvSGx0e/L4Nc+Z88s=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR03MB2480
X-OriginatorOrg: citrix.com

--_000_B7AFA7082CFC49FE8506046CA789C2C0citrixcom_
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64

DQoNCk9uIDEyIE9jdCAyMDIxLCBhdCAwOToxMywgTWljaGFsIE9yemVsIDxtaWNoYWwub3J6ZWxA
YXJtLmNvbTxtYWlsdG86bWljaGFsLm9yemVsQGFybS5jb20+PiB3cm90ZToNCg0KVGhpcyBwYXRj
aCBzZXJpZXMgaXMgYSByZXdvcmsgb2YgYW4gYWxyZWFkeSBwdXNoZWQgcGF0Y2gNCmV4cG9zaW5n
IFBNVSB0byB0aGUgZ3Vlc3RzLiBTaW5jZSB0aGUgc2Vjb25kIHZlcnNpb24gdGhlIHZwbXUNCnBh
cmFtZXRlciBpcyBjb21tb24gYW5kIHByZXdvcmsgaW4gdGhlIGZvcm0gb2YgcmVwb3J0aW5nDQph
dmFpbGFiaWxpdHkgb2YgdlBNVSBvbiB0aGUgaGFyZHdhcmUgaXMgYWRkZWQuDQoNClRoZSB0aGly
ZCB2ZXJzaW9uIG9mIHRoZSBwYXRjaCBzZXJpZXMgcmVtb3ZlcyB0aGUgcmVkdW5kYW50IGNoZWNr
DQpmcm9tIHg4NiBjb2RlIGFuZCBtb2RpZmllcyB0aGUgd2F5IHRvIGRlZmluZSB0aGUgZmxhZ3Mg
WEVOX0RPTUNUTF9DREYgYW5kDQpYRU5fU1lTQ1RMX1BIWVNDQVAsIG1lYW5pbmcgbm90IHRvIGRl
ZmluZSBiaXQgcG9zaXRpb24gYW5kIG1hc2sgc2VwYXJhdGVseS4NCg0KSW4gdGhlIGZvdXJ0aCB2
ZXJzaW9uLCB0aGUgYWRkaXRpb25hbCBjaGVjayBpcyBhZGRlZCBzbyB0aGF0IHdlIGZhaWwNCmlm
IHZwbXUgaXMgc2V0IGluIHRoZSBjb25maWcgZmlsZSBidXQgWEVOX1NZU0NUTF9QSFlTQ0FQX3Zw
bXUgaXMgbm90IGF2YWlsYWJsZS4NCg0KSW4gdGhlIGZpZnRoIHZlcnNpb24sIFNVUFBPUlQubWQg
aXMgdXBkYXRlZCB3aXRoIHRoZSBpbmZvcm1hdGlvbiBhYm91dA0KdlBNVSBmZWF0dXJlIGFuZCBj
aGVja3MgZm9yIHBsYXRmb3JtIFBNVSBzdXBwb3J0IGFyZSBpbXByb3ZlZC4NCg0KVGhlIGN1cnJl
bnQgc3RhdHVzIGlzIHRoYXQgdGhlIFBNVSByZWdpc3RlcnMgYXJlIG5vdCB2aXJ0dWFsaXplZA0K
YW5kIHRoZSBwaHlzaWNhbCByZWdpc3RlcnMgYXJlIGRpcmVjdGx5IGFjY2Vzc2libGUgd2hlbiAi
dnBtdSINCnBhcmFtZXRlciBpcyBlbmFibGVkIGluIHRoZSBndWVzdCBjb25maWcgZmlsZS4gVGhl
cmUgaXMgbm8gaW50ZXJydXB0DQpzdXBwb3J0IGFuZCBYZW4gd2lsbCBub3Qgc2F2ZS9yZXN0b3Jl
IHRoZSByZWdpc3RlciB2YWx1ZXMgb24gY29udGV4dA0Kc3dpdGNoZXMuIFRoaXMgaXMgdG8gYmUg
ZG9uZSBpbiB0aGUgZnV0dXJlLg0KDQpNaWNoYWwgT3J6ZWwgKDMpOg0KIHhlbit0b29sczogSW50
cm9kdWNlIFhFTl9TWVNDVExfUEhZU0NBUF92cG11DQogeGVuL2FybTogQ2hlY2sgZm9yIFBNVSBw
bGF0Zm9ybSBzdXBwb3J0DQogeGVuOiBFeHBvc2UgdGhlIFBNVSB0byB0aGUgZ3Vlc3RzDQoNClNV
UFBPUlQubWQgICAgICAgICAgICAgICAgICAgICAgICAgICB8ICA5ICsrKysrDQpkb2NzL21hbi94
bC5jZmcuNS5wb2QuaW4gICAgICAgICAgICAgfCAxNyArKysrKysrKysrDQp0b29scy9nb2xhbmcv
eGVubGlnaHQvaGVscGVycy5nZW4uZ28gfCAgOCArKysrKw0KdG9vbHMvZ29sYW5nL3hlbmxpZ2h0
L3R5cGVzLmdlbi5nbyAgIHwgIDIgKysNCnRvb2xzL2luY2x1ZGUvbGlieGwuaCAgICAgICAgICAg
ICAgICB8IDEyICsrKysrKysNCnRvb2xzL2xpYnMvbGlnaHQvbGlieGwuYyAgICAgICAgICAgICB8
ICAxICsNCnRvb2xzL2xpYnMvbGlnaHQvbGlieGxfY3JlYXRlLmMgICAgICB8IDEwICsrKysrKw0K
dG9vbHMvbGlicy9saWdodC9saWJ4bF90eXBlcy5pZGwgICAgIHwgIDMgKysNCnRvb2xzL29jYW1s
L2xpYnMveGMveGVuY3RybC5tbCAgICAgICB8ICAyICsrDQp0b29scy9vY2FtbC9saWJzL3hjL3hl
bmN0cmwubWxpICAgICAgfCAgMiArKw0KdG9vbHMveGwveGxfaW5mby5jICAgICAgICAgICAgICAg
ICAgIHwgIDUgKy0tDQp0b29scy94bC94bF9wYXJzZS5jICAgICAgICAgICAgICAgICAgfCAgMiAr
Kw0KeGVuL2FyY2gvYXJtL2RvbWFpbi5jICAgICAgICAgICAgICAgIHwgMTMgKysrKystLQ0KeGVu
L2FyY2gvYXJtL3NldHVwLmMgICAgICAgICAgICAgICAgIHwgIDMgKysNCnhlbi9jb21tb24vZG9t
YWluLmMgICAgICAgICAgICAgICAgICB8IDEyICsrKysrKy0NCnhlbi9jb21tb24vc3lzY3RsLmMg
ICAgICAgICAgICAgICAgICB8ICAzICsrDQp4ZW4vaW5jbHVkZS9hc20tYXJtL2NwdWZlYXR1cmUu
aCAgICAgfCA1MSArKysrKysrKysrKysrKysrKysrKysrKysrKy0tDQp4ZW4vaW5jbHVkZS9hc20t
YXJtL2RvbWFpbi5oICAgICAgICAgfCAgMSArDQp4ZW4vaW5jbHVkZS9wdWJsaWMvZG9tY3RsLmgg
ICAgICAgICAgfCAgNCArKy0NCnhlbi9pbmNsdWRlL3B1YmxpYy9zeXNjdGwuaCAgICAgICAgICB8
ICA2ICsrLS0NCnhlbi9pbmNsdWRlL3hlbi9kb21haW4uaCAgICAgICAgICAgICB8ICAyICsrDQoy
MSBmaWxlcyBjaGFuZ2VkLCAxNTcgaW5zZXJ0aW9ucygrKSwgMTEgZGVsZXRpb25zKC0pDQoNCuKA
lA0KMi4yOS4wDQoNCg0KQWNrZWQtYnk6IENocmlzdGlhbiBMaW5kaWcgPGNocmlzdGlhbi5saW5k
aWdAY2l0cml4LmNvbTxtYWlsdG86Y2hyaXN0aWFuLmxpbmRpZ0BjaXRyaXguY29tPj4NCg0KDQo=

--_000_B7AFA7082CFC49FE8506046CA789C2C0citrixcom_
Content-Type: text/html; charset="utf-8"
Content-ID: <7028C32FEDFDAE43911711AE3FFDD242@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64

PGh0bWw+DQo8aGVhZD4NCjxtZXRhIGh0dHAtZXF1aXY9IkNvbnRlbnQtVHlwZSIgY29udGVudD0i
dGV4dC9odG1sOyBjaGFyc2V0PXV0Zi04Ij4NCjwvaGVhZD4NCjxib2R5IHN0eWxlPSJ3b3JkLXdy
YXA6IGJyZWFrLXdvcmQ7IC13ZWJraXQtbmJzcC1tb2RlOiBzcGFjZTsgbGluZS1icmVhazogYWZ0
ZXItd2hpdGUtc3BhY2U7IiBjbGFzcz0iIj4NCjxiciBjbGFzcz0iIj4NCjxkaXY+PGJyIGNsYXNz
PSIiPg0KPGJsb2NrcXVvdGUgdHlwZT0iY2l0ZSIgY2xhc3M9IiI+DQo8ZGl2IGNsYXNzPSIiPk9u
IDEyIE9jdCAyMDIxLCBhdCAwOToxMywgTWljaGFsIE9yemVsICZsdDs8YSBocmVmPSJtYWlsdG86
bWljaGFsLm9yemVsQGFybS5jb20iIGNsYXNzPSIiPm1pY2hhbC5vcnplbEBhcm0uY29tPC9hPiZn
dDsgd3JvdGU6PC9kaXY+DQo8YnIgY2xhc3M9IkFwcGxlLWludGVyY2hhbmdlLW5ld2xpbmUiPg0K
PGRpdiBjbGFzcz0iIj4NCjxkaXYgY2xhc3M9IiI+VGhpcyBwYXRjaCBzZXJpZXMgaXMgYSByZXdv
cmsgb2YgYW4gYWxyZWFkeSBwdXNoZWQgcGF0Y2g8YnIgY2xhc3M9IiI+DQpleHBvc2luZyBQTVUg
dG8gdGhlIGd1ZXN0cy4gU2luY2UgdGhlIHNlY29uZCB2ZXJzaW9uIHRoZSB2cG11PGJyIGNsYXNz
PSIiPg0KcGFyYW1ldGVyIGlzIGNvbW1vbiBhbmQgcHJld29yayBpbiB0aGUgZm9ybSBvZiByZXBv
cnRpbmc8YnIgY2xhc3M9IiI+DQphdmFpbGFiaWxpdHkgb2YgdlBNVSBvbiB0aGUgaGFyZHdhcmUg
aXMgYWRkZWQuPGJyIGNsYXNzPSIiPg0KPGJyIGNsYXNzPSIiPg0KVGhlIHRoaXJkIHZlcnNpb24g
b2YgdGhlIHBhdGNoIHNlcmllcyByZW1vdmVzIHRoZSByZWR1bmRhbnQgY2hlY2s8YnIgY2xhc3M9
IiI+DQpmcm9tIHg4NiBjb2RlIGFuZCBtb2RpZmllcyB0aGUgd2F5IHRvIGRlZmluZSB0aGUgZmxh
Z3MgWEVOX0RPTUNUTF9DREYgYW5kPGJyIGNsYXNzPSIiPg0KWEVOX1NZU0NUTF9QSFlTQ0FQLCBt
ZWFuaW5nIG5vdCB0byBkZWZpbmUgYml0IHBvc2l0aW9uIGFuZCBtYXNrIHNlcGFyYXRlbHkuPGJy
IGNsYXNzPSIiPg0KPGJyIGNsYXNzPSIiPg0KSW4gdGhlIGZvdXJ0aCB2ZXJzaW9uLCB0aGUgYWRk
aXRpb25hbCBjaGVjayBpcyBhZGRlZCBzbyB0aGF0IHdlIGZhaWw8YnIgY2xhc3M9IiI+DQppZiB2
cG11IGlzIHNldCBpbiB0aGUgY29uZmlnIGZpbGUgYnV0IFhFTl9TWVNDVExfUEhZU0NBUF92cG11
IGlzIG5vdCBhdmFpbGFibGUuPGJyIGNsYXNzPSIiPg0KPGJyIGNsYXNzPSIiPg0KSW4gdGhlIGZp
ZnRoIHZlcnNpb24sIFNVUFBPUlQubWQgaXMgdXBkYXRlZCB3aXRoIHRoZSBpbmZvcm1hdGlvbiBh
Ym91dDxiciBjbGFzcz0iIj4NCnZQTVUgZmVhdHVyZSBhbmQgY2hlY2tzIGZvciBwbGF0Zm9ybSBQ
TVUgc3VwcG9ydCBhcmUgaW1wcm92ZWQuPGJyIGNsYXNzPSIiPg0KPGJyIGNsYXNzPSIiPg0KVGhl
IGN1cnJlbnQgc3RhdHVzIGlzIHRoYXQgdGhlIFBNVSByZWdpc3RlcnMgYXJlIG5vdCB2aXJ0dWFs
aXplZDxiciBjbGFzcz0iIj4NCmFuZCB0aGUgcGh5c2ljYWwgcmVnaXN0ZXJzIGFyZSBkaXJlY3Rs
eSBhY2Nlc3NpYmxlIHdoZW4gJnF1b3Q7dnBtdSZxdW90OzxiciBjbGFzcz0iIj4NCnBhcmFtZXRl
ciBpcyBlbmFibGVkIGluIHRoZSBndWVzdCBjb25maWcgZmlsZS4gVGhlcmUgaXMgbm8gaW50ZXJy
dXB0PGJyIGNsYXNzPSIiPg0Kc3VwcG9ydCBhbmQgWGVuIHdpbGwgbm90IHNhdmUvcmVzdG9yZSB0
aGUgcmVnaXN0ZXIgdmFsdWVzIG9uIGNvbnRleHQ8YnIgY2xhc3M9IiI+DQpzd2l0Y2hlcy4gVGhp
cyBpcyB0byBiZSBkb25lIGluIHRoZSBmdXR1cmUuPGJyIGNsYXNzPSIiPg0KPGJyIGNsYXNzPSIi
Pg0KTWljaGFsIE9yemVsICgzKTo8YnIgY2xhc3M9IiI+DQombmJzcDt4ZW4rdG9vbHM6IEludHJv
ZHVjZSBYRU5fU1lTQ1RMX1BIWVNDQVBfdnBtdTxiciBjbGFzcz0iIj4NCiZuYnNwO3hlbi9hcm06
IENoZWNrIGZvciBQTVUgcGxhdGZvcm0gc3VwcG9ydDxiciBjbGFzcz0iIj4NCiZuYnNwO3hlbjog
RXhwb3NlIHRoZSBQTVUgdG8gdGhlIGd1ZXN0czxiciBjbGFzcz0iIj4NCjxiciBjbGFzcz0iIj4N
ClNVUFBPUlQubWQgJm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5i
c3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7
Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7fCAm
bmJzcDs5ICsrKysrPGJyIGNsYXNzPSIiPg0KZG9jcy9tYW4veGwuY2ZnLjUucG9kLmluICZuYnNw
OyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZu
YnNwOyZuYnNwO3wgMTcgKysrKysrKysrKzxiciBjbGFzcz0iIj4NCnRvb2xzL2dvbGFuZy94ZW5s
aWdodC9oZWxwZXJzLmdlbi5nbyB8ICZuYnNwOzggKysrKys8YnIgY2xhc3M9IiI+DQp0b29scy9n
b2xhbmcveGVubGlnaHQvdHlwZXMuZ2VuLmdvICZuYnNwOyZuYnNwO3wgJm5ic3A7MiArKzxiciBj
bGFzcz0iIj4NCnRvb2xzL2luY2x1ZGUvbGlieGwuaCAmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsm
bmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJz
cDsmbmJzcDt8IDEyICsrKysrKys8YnIgY2xhc3M9IiI+DQp0b29scy9saWJzL2xpZ2h0L2xpYnhs
LmMgJm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7
Jm5ic3A7Jm5ic3A7Jm5ic3A7fCAmbmJzcDsxICs8YnIgY2xhc3M9IiI+DQp0b29scy9saWJzL2xp
Z2h0L2xpYnhsX2NyZWF0ZS5jICZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwO3wgMTAgKysr
KysrPGJyIGNsYXNzPSIiPg0KdG9vbHMvbGlicy9saWdodC9saWJ4bF90eXBlcy5pZGwgJm5ic3A7
Jm5ic3A7Jm5ic3A7Jm5ic3A7fCAmbmJzcDszICsrPGJyIGNsYXNzPSIiPg0KdG9vbHMvb2NhbWwv
bGlicy94Yy94ZW5jdHJsLm1sICZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwO3wg
Jm5ic3A7MiArKzxiciBjbGFzcz0iIj4NCnRvb2xzL29jYW1sL2xpYnMveGMveGVuY3RybC5tbGkg
Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7fCAmbmJzcDsyICsrPGJyIGNsYXNzPSIiPg0K
dG9vbHMveGwveGxfaW5mby5jICZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZu
YnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNw
OyZuYnNwOyZuYnNwO3wgJm5ic3A7NSArLS08YnIgY2xhc3M9IiI+DQp0b29scy94bC94bF9wYXJz
ZS5jICZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNw
OyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwO3wgJm5ic3A7
MiArKzxiciBjbGFzcz0iIj4NCnhlbi9hcmNoL2FybS9kb21haW4uYyAmbmJzcDsmbmJzcDsmbmJz
cDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsm
bmJzcDsmbmJzcDsmbmJzcDt8IDEzICsrKysrLS08YnIgY2xhc3M9IiI+DQp4ZW4vYXJjaC9hcm0v
c2V0dXAuYyAmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsm
bmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDt8ICZuYnNwOzMg
Kys8YnIgY2xhc3M9IiI+DQp4ZW4vY29tbW9uL2RvbWFpbi5jICZuYnNwOyZuYnNwOyZuYnNwOyZu
YnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNw
OyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwO3wgMTIgKysrKysrLTxiciBjbGFzcz0iIj4NCnhlbi9j
b21tb24vc3lzY3RsLmMgJm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7
Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5i
c3A7fCAmbmJzcDszICsrPGJyIGNsYXNzPSIiPg0KeGVuL2luY2x1ZGUvYXNtLWFybS9jcHVmZWF0
dXJlLmggJm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7fCA1MSArKysrKysrKysrKysrKysrKysrKysr
KysrKy0tPGJyIGNsYXNzPSIiPg0KeGVuL2luY2x1ZGUvYXNtLWFybS9kb21haW4uaCAmbmJzcDsm
bmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDt8ICZuYnNwOzEgKzxiciBj
bGFzcz0iIj4NCnhlbi9pbmNsdWRlL3B1YmxpYy9kb21jdGwuaCAmbmJzcDsmbmJzcDsmbmJzcDsm
bmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDt8ICZuYnNwOzQgKystPGJyIGNsYXNz
PSIiPg0KeGVuL2luY2x1ZGUvcHVibGljL3N5c2N0bC5oICZuYnNwOyZuYnNwOyZuYnNwOyZuYnNw
OyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwO3wgJm5ic3A7NiArKy0tPGJyIGNsYXNzPSIi
Pg0KeGVuL2luY2x1ZGUveGVuL2RvbWFpbi5oICZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNw
OyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwO3wgJm5ic3A7MiArKzxi
ciBjbGFzcz0iIj4NCjIxIGZpbGVzIGNoYW5nZWQsIDE1NyBpbnNlcnRpb25zKCspLCAxMSBkZWxl
dGlvbnMoLSk8YnIgY2xhc3M9IiI+DQo8YnIgY2xhc3M9IiI+DQrigJQgPGJyIGNsYXNzPSIiPg0K
Mi4yOS4wPGJyIGNsYXNzPSIiPg0KPGJyIGNsYXNzPSIiPg0KPC9kaXY+DQo8L2Rpdj4NCjwvYmxv
Y2txdW90ZT4NCjxiciBjbGFzcz0iIj4NCjwvZGl2Pg0KPGRpdj5BY2tlZC1ieTogQ2hyaXN0aWFu
IExpbmRpZyAmbHQ7PGEgaHJlZj0ibWFpbHRvOmNocmlzdGlhbi5saW5kaWdAY2l0cml4LmNvbSIg
Y2xhc3M9IiI+Y2hyaXN0aWFuLmxpbmRpZ0BjaXRyaXguY29tPC9hPiZndDs8L2Rpdj4NCjxkaXY+
PGJyIGNsYXNzPSIiPg0KPC9kaXY+DQo8YnIgY2xhc3M9IiI+DQo8L2JvZHk+DQo8L2h0bWw+DQo=

--_000_B7AFA7082CFC49FE8506046CA789C2C0citrixcom_--


From xen-devel-bounces@lists.xenproject.org Tue Oct 12 08:30:00 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 08:30:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.206906.362588 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maDAb-0004lS-62; Tue, 12 Oct 2021 08:29:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 206906.362588; Tue, 12 Oct 2021 08:29:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maDAb-0004lL-2y; Tue, 12 Oct 2021 08:29:57 +0000
Received: by outflank-mailman (input) for mailman id 206906;
 Tue, 12 Oct 2021 08:29:55 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=/4YK=PA=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1maDAZ-0004lB-PT
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 08:29:55 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 92ecb6f2-2b36-11ec-811b-12813bfff9fa;
 Tue, 12 Oct 2021 08:29:54 +0000 (UTC)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2113.outbound.protection.outlook.com [104.47.18.113])
 (Using TLS) by relay.mimecast.com with ESMTP id
 de-mta-5-8Lp7VwHvMwOkquJV_Vl9vA-1; Tue, 12 Oct 2021 10:29:52 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB4381.eurprd04.prod.outlook.com (2603:10a6:803:6d::30)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18; Tue, 12 Oct
 2021 08:29:49 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4587.026; Tue, 12 Oct 2021
 08:29:49 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6PR01CA0056.eurprd01.prod.exchangelabs.com (2603:10a6:20b:e0::33) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.21 via Frontend
 Transport; Tue, 12 Oct 2021 08:29:48 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 92ecb6f2-2b36-11ec-811b-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634027393;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=CoQlxc2pXslrQ83VKgQjeoyEexGYt+PzcmC7VDLMAbU=;
	b=L+TDwes85K81stIl4wEiY024ozzmVlNLIH8/2/AhG30ZvY4jX08uikppPFejG0RoRWN3Dg
	aI7yUcbAQUy6IYVqqAuAbx+BUJ8mrqjp8QzxXR6K1mleE/s4h7dv6xrynmiG3TdumPQzRc
	Lu2Ae+0k8mTi+SLOA88d/C2EsXAA36Y=
X-MC-Unique: 8Lp7VwHvMwOkquJV_Vl9vA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=b648thI8HlwTNvTJT+fKwzU3PC7L/g++UvRAJp9Lc54VdXUBCLC76fFjyDSAp1P2whQmtM+Y0lnewd4d9S9Jb/tyurwbqZ6rNDXbQmqYApOPEpdZYyDJD50GIgkXhAh+EorYg87mq+ml7PmAlON9RLJ42KzSkpjMArKk6oakif0mi1KWzeIIhoKmkUAy3gT7vxF7KjBmi4e+jC+YasQco44EM6E5sKXlq3SAtz2pDE78jfxIHOCQKmQUOl61MdEQOWTPKBVtlWgRia0b+vY4ZrQkieCoKb7J6t1RNF7s56OZfNbwpgy34GWlHpOBlrPaQHOu4UDrx4PuesOzk6BshQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=rmcOL/lOL1QTNko6R0vSnQ0zydXSr2pqSTo0WVNFneQ=;
 b=ZdaYNfjVUU8UNl3oF4JebI/qaFOCgY2NER5o5/zjZ+Z3Qw24kn4aOWM2tT5dJhpxwNeHfpiYr1CZR1i3fqMT1DAZjwVHY3NJbCp/r6/ZJejroqj0b+rclOyvpVNNNuZaY5ehcO/wV6o4DaTe9uGlug9EP0ETTd9ZDZ4UagIg1Z/NfaJ/QlyieyJgmEiunmfGvVQzxXZQ1Wm4zZWJG+6JEehHVwEznNs6GkiR3hSjBo7tja3f/bQvi+Fu0TgoDObpQBIDYen6fe20ILaQ/V3HX9tYLCrKTN828lYe0goOknHI0tFoFUTD9pkCKz1ph9SD0dw9X+k5pKNuQFUOI/ZBaw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: citrix.com; dkim=none (message not signed)
 header.d=none;citrix.com; dmarc=none action=none header.from=suse.com;
Subject: Re: [PATCH v5 01/11] xen/arm: xc_domain_ioport_permission(..) not
 supported on ARM.
To: Bertrand Marquis <Bertrand.Marquis@arm.com>
CC: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>,
 Rahul Singh <Rahul.Singh@arm.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andre Przywara <Andre.Przywara@arm.com>, Ian Jackson <iwj@xenproject.org>,
 Wei Liu <wl@xen.org>, Juergen Gross <jgross@suse.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <cover.1633540842.git.rahul.singh@arm.com>
 <d292392268df2c74c4103a82ef917072643407a8.1633540842.git.rahul.singh@arm.com>
 <YWQkblfNMYEs6jI9@MacBook-Air-de-Roger.local>
 <77CF7FA5-C566-469E-B4A8-0400789890BB@arm.com>
 <YWQ6Nk3Jk+BqgkwZ@MacBook-Air-de-Roger.local>
 <53AE6E2A-01D7-41EC-9B2C-C0D596EB8D4D@arm.com>
 <YWRCxXGQIyTOAepC@MacBook-Air-de-Roger.local>
 <FEF0B03A-5AC8-4F8D-B821-191AC2EF8295@arm.com>
 <YWRnMfAi808TQ4Gt@MacBook-Air-de-Roger.local>
 <EB1CB53B-9D5A-49C5-A687-841BF94A153F@arm.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <ac6d4785-ac9a-4491-26bb-c66ffe82c55b@suse.com>
Date: Tue, 12 Oct 2021 10:29:47 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <EB1CB53B-9D5A-49C5-A687-841BF94A153F@arm.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6PR01CA0056.eurprd01.prod.exchangelabs.com
 (2603:10a6:20b:e0::33) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: fc7c9813-f2f6-4b40-caf9-08d98d5a747b
X-MS-TrafficTypeDiagnostic: VI1PR04MB4381:
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB438176882A857E61C2704E02B3B69@VI1PR04MB4381.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	G15zjZDD0EZ8plfUUSfvtOaxs0BBrQdF9wDfYFQSUR3zK+oWt2cdK4AOGUqwprLB+T4eOUZLGKsSreN8hyUuZOY4VOyVutq+84T/J20w60K+rzimrsJQziD1Pm1HUov1a9uuLjrWhLt8ezcz41pYoFBcjrLpMOj3VecXa9Z2RNxFb5ZyM/KFnA8lALn9Ix4FnxKpYcATRZTJfT30LBZIJXYVL9EyYui0y+pAKEIgSDN7Rkwnmwt8++YmezRLpV/2mXmj8xTeduvrjjt21tBgPXhQ9VCe7WFkFxhKQElc9OOgZ+hbGicGmjwyT3OjbE2otsg3hbgJorN9kLkInYMH0G86EfQpnI1VmnlmCm1LU02zvLftr6+1JVKYyu2zAi35y17JomlfUmy/RdjD042iTtvCwiiM/H3Yb55qfVB/lTuEOtAigoMTH7iM+vwxSjtZvgfyJvrM/qw7c9vfrlkQv2QCoO8GYQiGbSnqxJZeA+GkE2h0NsIJE8+wUGnztBhj/cHBIbRg465at2CNkxNQPDyCWGYWzHe6ojeSYwK+7xH8eOkk3Y0K+jhraw0Q9219aZlVlOxgjsLGbqDL+SmFcdnlL0nBMNodKqooYrwbt6VAxsbJmRZpph7IepvRutLMoxJVMxNJpU+kxzEcFp1CT4/C6UUVvZL0ajMCzYjc5vdIKx7P90Z/s4+hKNaEiUOGAzFUhx1m4arG1EeGmEMqGw==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(2616005)(66476007)(316002)(956004)(66556008)(54906003)(6486002)(16576012)(66946007)(8936002)(5660300002)(86362001)(8676002)(26005)(186003)(38100700002)(6916009)(83380400001)(53546011)(508600001)(4326008)(36756003)(31696002)(31686004)(2906002)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?NEEWQliKOIDElNLHxbE7AO00NrRJNpw/h8VfHJj+RaFJ0cO0/q5NKHSUJmRT?=
 =?us-ascii?Q?EPnAjWjV4sAGeCM9gmtcIyFXsRP2jLTFN3vxbhd0IwSEDrC9xqyHKO2xiq5U?=
 =?us-ascii?Q?my0OusoJwwAUYKxSDZH3FpYi6VWOAdfds/zxDu6ssjooBIE/Xv7zyCu4nPn9?=
 =?us-ascii?Q?SFYwYZDaCV/CX4QHfo5ON40s6QMgkzKYmcpW2Rt84WIw1ICUP3KMsmSYyOgC?=
 =?us-ascii?Q?Nl3dP/EgFHxTNAq0aIksthAFcAMBLQ15mbEWs8b5MkPAvWWAJ8F/7FaixXLd?=
 =?us-ascii?Q?5NDCihxYfT2dQuJ3aVC6rLt5Ob3PQGSA5Ck/ZSB3C4G3zHM+IHolI3qd+XMd?=
 =?us-ascii?Q?DlIW31VINAuc7S5kvShNXbJOPGeFzGjSEifeLnZB4Ycuh856lzmZcpMrlMKN?=
 =?us-ascii?Q?xjZ1BAhgH/gy1MZObw1+9VsmnLbHeqTtHDMEjElUyp9DadRicMDhr2PucK5N?=
 =?us-ascii?Q?y3mOMdVsz5nuIXi3jrC49S8fXpsKppmUyJbb3eDQ7pzAdpMRarbI1GILlxvm?=
 =?us-ascii?Q?GtmRrplnbKNhtBw6dYlswx/0G2s6YCFkZwNPh3Iyr/aVeNRwZn5wIwAVEO0L?=
 =?us-ascii?Q?P/4Vx8eurV3319nfiICFrUB/fbWSkdr/xRBBQrV7swYQnLn2lCT+I8Yc4nxT?=
 =?us-ascii?Q?asSTgdbtHK+kYjuKiBXS8uVF31kWcQQa5b7rinisq9z6kN7JHXyKWOCGmVkZ?=
 =?us-ascii?Q?nQv3tz5kGVyKBuHWIIxwy7dMsWonGyc9ixAPTJ3vGK/w46rjoQDrtAAi5eH1?=
 =?us-ascii?Q?2kXNydvLN2ugJvSpelbapiKkIbMkXn3GD7jLSDkfpeOcYsNKinfmdYrylif8?=
 =?us-ascii?Q?0IChfEbzQiSxBkYDOFmr6Z7VpZzsAN6tH3gYFmXxPmKoAuX9kH9ZOwJmFYbo?=
 =?us-ascii?Q?1VKW+Ek8wYIt8mmzu5QapxvqwSnusvkXA2amJIRzFfaHKnx9S9JrhGvA1aAF?=
 =?us-ascii?Q?DR7SDunsuChta0NNvk6ejesjbe21s4ZVlOkAgjttc0bNwI2uSYOMWhqrt5HQ?=
 =?us-ascii?Q?xEcWDDAYBS3OZW8Uc4+kDzVsgQXFJtb1HBHotE561BU+RgQ4Hl1PkvoRYniT?=
 =?us-ascii?Q?eD4U2Xg+pvj0WFUXJVHSMoxt4Jws7jE1CyQnibV+GNKtbTSXYJf3tj3gJkSY?=
 =?us-ascii?Q?cJgaDrc1VNwL80GKBSA6c1J3xC93qkiCtlY8eOcBoCIRLzIlTH3+FD9E8Vox?=
 =?us-ascii?Q?dnXAef0ypAs9tpP/9afx+LIvYqkL3UiKRt6xNNV1Adh0Z7ZG9+o3V442ce5U?=
 =?us-ascii?Q?nsGWZoBVUZuu1uw0KY8ieXRFZUGBpGN99fGTZM/y5GFjwsJyJe4P1Z3AqBRR?=
 =?us-ascii?Q?eXx6iAq6BPbpnKIitdxbUNcy?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fc7c9813-f2f6-4b40-caf9-08d98d5a747b
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2021 08:29:49.2677
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: COKIUFKyOO1gCes2bFqle6xbdSe9uMzjfV34h3oaw/mEUlV5DC4wwjFLCwWEw3kGGcQ4TLtDhSVqvqG4dmYonw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4381

On 11.10.2021 19:11, Bertrand Marquis wrote:
>> On 11 Oct 2021, at 17:32, Roger Pau Monn=C3=A9 <roger.pau@citrix.com> wr=
ote:
>> On Mon, Oct 11, 2021 at 02:16:19PM +0000, Bertrand Marquis wrote:
>>>> On 11 Oct 2021, at 14:57, Roger Pau Monn=C3=A9 <roger.pau@citrix.com> =
wrote:
>>>> I think the commit message needs to at least be expanded in order to
>>>> contain the information provided here. It might also be helpful to
>>>> figure out whether we would have to handle IO port accesses in the
>>>> future on Arm, or if it's fine to just ignore them.
>>>
>>> All our investigations and tests have been done without supporting it
>>> without any issues so this is not a critical feature (most devices can
>>> be operated without using the I/O ports).
>>
>> IMO we should let the users know they attempted to use a device with
>> BARs in the IO space, and that those BARs won't be accessible which
>> could make the device not function as expected.
>>
>> Do you think it would be reasonable to attempt the hypercall on Arm
>> also, and in case of error (on Arm) just print a warning message and
>> continue operations as normal?
>=20
> I think this would lead to a warning printed on lots of devices where in
> fact there would be no issues.
>=20
> If this is an issue for a device driver because it cannot operate without
> I/O ports, this will be raised by the driver inside the guest.

On what basis would the driver complain? The kernel might know of
the MMIO equivalent for ports, and hence might allow the driver
to properly obtain whatever is needed to later access the ports.
Just that the port accesses then wouldn't work (possibly crashing
the guest, or making it otherwise misbehave).

Jan



From xen-devel-bounces@lists.xenproject.org Tue Oct 12 08:40:42 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 08:40:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.206914.362599 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maDKs-0006yi-6Z; Tue, 12 Oct 2021 08:40:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 206914.362599; Tue, 12 Oct 2021 08:40:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maDKs-0006yb-2i; Tue, 12 Oct 2021 08:40:34 +0000
Received: by outflank-mailman (input) for mailman id 206914;
 Tue, 12 Oct 2021 08:40:32 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=/4YK=PA=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1maDKq-0006yV-1J
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 08:40:32 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 0dc8bd71-2b38-11ec-811b-12813bfff9fa;
 Tue, 12 Oct 2021 08:40:29 +0000 (UTC)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2054.outbound.protection.outlook.com [104.47.13.54]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-11-Pq_ignnFOuWD3beqfZVI7A-1; Tue, 12 Oct 2021 10:40:27 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB3117.eurprd04.prod.outlook.com (2603:10a6:802:6::32) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.25; Tue, 12 Oct
 2021 08:40:25 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4587.026; Tue, 12 Oct 2021
 08:40:25 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 FR0P281CA0057.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:49::14) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.4 via Frontend Transport; Tue, 12 Oct 2021 08:40:24 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0dc8bd71-2b38-11ec-811b-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634028029;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=JJrnzztcgpAUtNQ9QtKq8z2DdFZssTkvFswiHvb4aLg=;
	b=bh3Yz0lBTG9MXoqQi/lakFAKEUnKgfOQtJpz0N5VbBSPqRpckDtoEtx5mBYOHE8cYOqJ/Z
	/zQQ81+pV7+E19NUIAKZMNclq+gUMO3G5nABw8pZ12CSPi05Jf+hDTVYJkLNKq2rnGwzbJ
	qRHZf/Uzb+M/VkfjZGMqHHt2xy21yPU=
X-MC-Unique: Pq_ignnFOuWD3beqfZVI7A-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Xz8BiXZG0ZxM/iUBDufux8NmZE6L0IwQUa0QvA4SnqD0I9ipVX6tfeyJrgrnx6aUIjer7kIL90UO6VkXfOFTCe1RmmOPCDfE65SBHHsJ2tgSKwacrFQTTnWIyd1ZQrsWaAIiY0KSDILXJ0FGKWdzmMjY78okCqcRt6CXkG7w0U/MsX1p7dbcF34MyTV18gv9vDZPNDKXutskzeoP5zltQ6nI6m5GMTFx3PJGZ8UX6VXpdl14x5ycdsGcXRjB6SA2GcRQTFaNv7pSVnKD+uA0Wd7ZzBJMdwiJ+4szPAlxI47sUDxOV8IvxNL5xI/P7VwT2y5Nt23uca1DjWkRNiug/A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=JJrnzztcgpAUtNQ9QtKq8z2DdFZssTkvFswiHvb4aLg=;
 b=feUryQlUXsrUphk53oqfvex7WBSOlshLGRgPph8ISvdqfzQT4dRdfDlprOGSRbARPj9lyjDfJ3kW7PS3/izaodd19nMYsQ+azNX6/GTPOgrtmrPP+S16xZpS9VGkEWf+sttn343vMGtpdG2OG4Fa9jkp9Ni37S76z2/3KHtCM8Ha7xR98LirRYrwNg19y27EU9WdRZlPPOkbL8KNM26rIZGrOOuHD6ASdjWpuG1yl2Wf2iaRqVaXehkGW3ke8fycgUqZv1XZFkes1I/2XTofTCJISCQhnRxzl7FzUDMzl4pQShQW71gx+AUa7Zd00rOufv74XABHXwqYRJuD/UQv3w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [PATCH xen 2/2] xen: update system time immediately when
 VCPUOP_register_vcpu_info
To: Dongli Zhang <dongli.zhang@oracle.com>
Cc: sstabellini@kernel.org, andrew.cooper3@citrix.com,
 george.dunlap@citrix.com, iwj@xenproject.org, julien@xen.org, wl@xen.org,
 joe.jin@oracle.com, xen-devel@lists.xenproject.org
References: <20211012072428.2569-1-dongli.zhang@oracle.com>
 <20211012072428.2569-3-dongli.zhang@oracle.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <317163fa-f736-ccfe-40d4-b918ce2834f9@suse.com>
Date: Tue, 12 Oct 2021 10:40:23 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <20211012072428.2569-3-dongli.zhang@oracle.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR0P281CA0057.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:49::14) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: bd2e4cf2-8489-44e3-c50d-08d98d5bef8d
X-MS-TrafficTypeDiagnostic: VI1PR04MB3117:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB3117A952E1BC0E23C1864308B3B69@VI1PR04MB3117.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6790;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	4DoI8DWw4lXBvbUmvi9qEpzxwYa0pAYJNm8+byZSORdiCQ6x/xoHrU2DHmUyN0ScfN2NuCPi8SOXcYm5Hk6LYeOmXvoX+Q7mfzRczvCwzAMGdXgwEz5xXGXg148q01d39IxR9AwbxUk2h5ZGIkyOoTvpwNozre6jG3QVVwWqb3Exvy0k94Q7iJi4jaoDxqLUJCTH8maPt8HBfi94KBx/LF65bwXn0LkB3L//ybFtuvnzJgMUGhm2edXWxbp5BAPwZbPqjt2lR+TFVuZHWcJgKkFIXCm45R9tRi6kftgKtCXheC/raa6uIpyvYVL56Lr90iWfgx0YNyMs+ucJcaG5FuQWhjT+PeN7/gAPZsSunYlDNJEq/inas6junWTneprDenFm7aKqAM6o5L7CSCPWgjUh2wKrKA/hPfBL9X84tR8aVnzLlrDyEl5h+Uk1y3DaQCcgEdfVEw274kyzi9m7xVzP8gCLUe1h6wMRNdCxJ/20lWeReGYsJglAd/aMSTzMgjR6/J/0KKbZrdfxLvd/8vr0LC5FmyKhJfEajn/SueHG/cgLqJTsoTdBuwQ95QY92QliF7lqTQB168gcyRpVukwz1fJvkAQXaJUJfZUrA0pObHrN9uW6+5spuC5uJd3IM6KvNbkiKDk9KImneSnevZ+yGWMq6Az5J5hvM5UE8kpG9cFWTVdGLzRYHvtHaecFAZOk7SbYsnK6mNS7PHWQVHWbbyE7ETP5IAAAhq5LiBl7cQcTcQaPajix6/q+3Ym3
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(36756003)(186003)(31696002)(86362001)(53546011)(508600001)(8936002)(16576012)(5660300002)(956004)(2616005)(26005)(6916009)(316002)(4326008)(66476007)(2906002)(66556008)(31686004)(83380400001)(66946007)(4744005)(6486002)(8676002)(38100700002)(14773001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?NUpSVHp1ZUtMMG5CeWxDTXMzUEhIRXZqWVpzNXFJY29IZ0lEY0FiR3plS3Z4?=
 =?utf-8?B?OWZVVzU3OEd0aVg4K3RkNU1IVzJXZzhXWStvQ0ZweXVkVzIybkJvcFRuSlVp?=
 =?utf-8?B?TTRKK3JuVWJpdURFQVdtdUVIcC9xOUMwNTNwYmZWVldNQ1JSby9SKzJ4V3lT?=
 =?utf-8?B?WE9uL1kxTTNKME82TmtvY1dzK1Vra1pGcS91VmZBaGFja0MweWQ3OUN6K1pH?=
 =?utf-8?B?aXptd0JtU1plWDZiWUl4QnFQL3pyWTZ1UTJkc29CZVBpYVA2V083bWRZZyt6?=
 =?utf-8?B?VUo1cWZrQk9mUjd1OUtjdWhZU2plZmtQRHBEYUVzcG51UUNibFZwM0ZLZmFK?=
 =?utf-8?B?dzVLUGs2bUNndkEwTVJ5WVNGTGx3MGt1KzhHa2IwT3luZk1RUnozNmFFa1NW?=
 =?utf-8?B?MnU0dXNNbDEzM2NIM1VTdFR1SWNlcUFEaUxhQ1hYT0tiY3A5TlR1WWNHbnNV?=
 =?utf-8?B?ZHpwLzBkNzRwMWFDTVArVmpWQi9qOFdxUUsyaml4V0NWcDFlSDNwWFkyeHVS?=
 =?utf-8?B?bnpDWXFUb1FQSGdIR0I1WnR1b0o2WUx0MmpybDkxZkUySUZMM2hsWEpjbDFC?=
 =?utf-8?B?OVNISCtnTDNpdDNVOUJxVTBGcXRpalVLQjF2UXJLcThFWHVPTTZKV2h6R1Y5?=
 =?utf-8?B?VnM3UTYybWV3Ky9QOUtnOWN5R0lkMnNMV2pzRHVkQVFIc2g2WTF0MmpQN1BD?=
 =?utf-8?B?OXVYS1EyaWdscDZ6alFNQi9sWjI5dVBnbmdTMitUZkVxU1JpRWJLVUZHT2Fv?=
 =?utf-8?B?bzgxa29rTkwvTXZTUHhnSktIb2ZBT3BzSHd5U3lLODVYVjZkd0cyUlk5UTVk?=
 =?utf-8?B?ZnlGbXREK09jRjFSRjFLS25NaGFOaVJJTi80d05GVDNJUjZkazVhU3ZsaGky?=
 =?utf-8?B?aUlvTUI3ZDVsNUYraXRhdXBDNm40ak5PYlBhTVpjS1dHYksvcVJ1K3VUcHEw?=
 =?utf-8?B?MEZNNHNUSTFuSWdyNkRPK2laVUx5TVBzc0RuMXdFY1RUYTBGRUhIcCs0K20y?=
 =?utf-8?B?UXV5M1lFWUtSSm1iK0N2RzlrWjBMcHgwRVE1ank5MGxjMVhRbEp2L1lHU3hB?=
 =?utf-8?B?WXByM1hmWEhZZUhwakhqclFUQWF0Nk56em5EcXJUR0tkaGt3OXdsUWxQOHA4?=
 =?utf-8?B?OElTaHc3WmxzekxIZy82UkJvSnJDVE5nV1dlejBKVnRTQ3JQRlZSZzFQYm5G?=
 =?utf-8?B?U3F2RnhrRWt1WkRaN1loYVpKV2hGZEhKaXRJSnlKc1llSXplZ1oycEVsNDBp?=
 =?utf-8?B?TUhYZlcrdFErQTZtdEdMQjE0dzc1UFVtQi95alVuTU1RVGp0Zmp1bm5ZRm15?=
 =?utf-8?B?a0Y5cTMwMlFzdFFjcll2N2lIQWlFVkwxM01OWmJ2Ty9UN3JOb0IzcDVNdnVw?=
 =?utf-8?B?K0ZHUHNTZ2lINUZzMFUrMzFEZ1RrS2NGMDFlRGZhSkprVXVITjk2ekk0R0Vt?=
 =?utf-8?B?MXYzTlFOd2ZUalRmZHowTTg1dENhOSs5UGxMbzJGekJIaVdDKy9yakNpaGFT?=
 =?utf-8?B?MFVXSjNBZ0M1VHF0dTdjdURFNmZ0VkdLRHhqbHQzSE5pbnl5dUR5YUYrMUZ2?=
 =?utf-8?B?ZUY1KzMzT2MvQzBrWHdSZExQazRyYmczWWFPMSt6Z28zVjBRb0I3R3lPYy92?=
 =?utf-8?B?T3I1RkRtSzN3WjJETlgzZkVZNll4TDJ2dUNSWlM0RjgwdWY2MHorWGxyZWI4?=
 =?utf-8?B?aFZqUk9xNjZIVFY2NjUxNC8xRmg1NWllN2d3MjJkeGM5U1VOWkgydE9pVmR3?=
 =?utf-8?Q?5wg4W+I+yXdAOF640/bUzYO/Z3NiXT5kX4ud4yR?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bd2e4cf2-8489-44e3-c50d-08d98d5bef8d
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2021 08:40:25.2800
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: q5y3TD7+ubdZknU4oHqc5PlDtofNkPt+Wnrw6G8JLf4Mj8isw6VXri8gAZ4icyxueyq+PCLmk5mdYzCz7k8fZQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB3117

On 12.10.2021 09:24, Dongli Zhang wrote:
> The guest may access the pv vcpu_time_info immediately after
> VCPUOP_register_vcpu_info. This is to borrow the idea of
> VCPUOP_register_vcpu_time_memory_area, where the
> force_update_vcpu_system_time() is called immediately when the new memory
> area is registered.
> 
> Otherwise, we may observe clock drift at the VM side if the VM accesses
> the clocksource immediately after VCPUOP_register_vcpu_info().
> 
> Cc: Joe Jin <joe.jin@oracle.com>
> Signed-off-by: Dongli Zhang <dongli.zhang@oracle.com>

While I agree with the change in principle, ...

> --- a/xen/common/domain.c
> +++ b/xen/common/domain.c
> @@ -1695,6 +1695,8 @@ long do_vcpu_op(int cmd, unsigned int vcpuid, XEN_GUEST_HANDLE_PARAM(void) arg)
>          rc = map_vcpu_info(v, info.mfn, info.offset);
>          domain_unlock(d);
>  
> +        force_update_vcpu_system_time(v);

... I'm afraid you're breaking the Arm build here. Arm will first need
to gain this function.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Oct 12 08:42:07 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 08:42:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.206922.362610 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maDMN-0007Z0-HU; Tue, 12 Oct 2021 08:42:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 206922.362610; Tue, 12 Oct 2021 08:42:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maDMN-0007Yt-E1; Tue, 12 Oct 2021 08:42:07 +0000
Received: by outflank-mailman (input) for mailman id 206922;
 Tue, 12 Oct 2021 08:42:06 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=B8jq=PA=arm.com=Bertrand.Marquis@srs-us1.protection.inumbo.net>)
 id 1maDMM-0007Yl-Lw
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 08:42:06 +0000
Received: from EUR02-AM5-obe.outbound.protection.outlook.com (unknown
 [40.107.0.86]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 8679cca3-e248-4af8-a883-509a74afdb45;
 Tue, 12 Oct 2021 08:42:05 +0000 (UTC)
Received: from DB9PR06CA0006.eurprd06.prod.outlook.com (2603:10a6:10:1db::11)
 by AM0PR08MB4323.eurprd08.prod.outlook.com (2603:10a6:208:13d::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.24; Tue, 12 Oct
 2021 08:41:50 +0000
Received: from DB5EUR03FT038.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:10:1db:cafe::85) by DB9PR06CA0006.outlook.office365.com
 (2603:10a6:10:1db::11) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.25 via Frontend
 Transport; Tue, 12 Oct 2021 08:41:50 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT038.mail.protection.outlook.com (10.152.21.84) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4587.18 via Frontend Transport; Tue, 12 Oct 2021 08:41:49 +0000
Received: ("Tessian outbound f1898412aff1:v103");
 Tue, 12 Oct 2021 08:41:49 +0000
Received: from 7cf18b9fcf48.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 F1AD805C-1B79-4E2C-82EC-FC44056647FD.1; 
 Tue, 12 Oct 2021 08:41:38 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 7cf18b9fcf48.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Tue, 12 Oct 2021 08:41:38 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com (2603:10a6:4:74::9)
 by DB9PR08MB6346.eurprd08.prod.outlook.com (2603:10a6:10:25b::7) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18; Tue, 12 Oct
 2021 08:41:34 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955]) by DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955%4]) with mapi id 15.20.4587.026; Tue, 12 Oct 2021
 08:41:34 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8679cca3-e248-4af8-a883-509a74afdb45
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=QkutoNjGLjMwbg6AXEtWuX80xaGsQXQVb0fNCzh1adA=;
 b=RHZWGMHpGLUgwZRSp8HK4W710/qmLsRt0scHF2ohC8KrcPG3k5epETefETwmZYp1By0IHT9537k8ohJOpfY/401gbgLMomPlb/YzpANnzyzVsWh1bw6N/gPzvZrOVpf2Rno+jeo9ciSoFQ1tPNw2mIafNpmoM+ts8+vxbzjfyEs=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 0431c04c60ab214e
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=HagpDoqf3H37fGU7EE5fjCjl2qjsjOsJkejjJquf6n4YkZrmLf3QcHeQUkqMf8NE6Dt73OueisK433YJLgqkaziawc/jaxLfsFzb8BWWy2Z3NNSytNpPwcS/2Z5by/fkK6HY/ereEpbx8pQUSCbvl3xkCORxuaCOpTrbirXYTNmBjsEdZd4ZEb0qWQF5y7yUtDXUhHPOo7Mb4bzaJdzNSzNzS99+I6sfc/pnJs43rik2NHXa3syI6iQbGswK7I8pPJnBeFkqz0/t2+XIssxzl857CCJdi/EZK+Vt4Xm2X473J3yPtZf6qyU6CNcnvIefq5x73CsgT2uhT1LsWM3XUw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=QkutoNjGLjMwbg6AXEtWuX80xaGsQXQVb0fNCzh1adA=;
 b=LM4EkYqK/7tMaIDc52qYrtndMKO1ik6Nsx04Kqc+z0wFlqeLufVk9miyyAOnyYWW0RdSfLwFk1UIpgtRDxVq52iI3fjJT7Q0tvL8QwWxyLFDIfYTYDNHLK3HRN05LoOkh3c2jCEPuZ3PZfcOM2rY3/kKEOZgt5dIZuSiMXV1mkdn4e2iSlibiEsa2P1VshqEQE3s+DZPlHUK5MqvZXjcKS2k85sBbHrIUFvIlbXDDZLcNYFdrX8IxQeGuWnNQ89GrtoWIiw6doqo60GTowO+L8S8HjaHCJwPmL5vK4HdXU5LXY+3CttTzpaiAdL3716weOwD8Qg5e+J70bNzTANAaw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=QkutoNjGLjMwbg6AXEtWuX80xaGsQXQVb0fNCzh1adA=;
 b=RHZWGMHpGLUgwZRSp8HK4W710/qmLsRt0scHF2ohC8KrcPG3k5epETefETwmZYp1By0IHT9537k8ohJOpfY/401gbgLMomPlb/YzpANnzyzVsWh1bw6N/gPzvZrOVpf2Rno+jeo9ciSoFQ1tPNw2mIafNpmoM+ts8+vxbzjfyEs=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>, Rahul Singh
	<Rahul.Singh@arm.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, Andre Przywara <Andre.Przywara@arm.com>,
	Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>, Juergen Gross
	<jgross@suse.com>, Stefano Stabellini <sstabellini@kernel.org>,
	=?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>
Subject: Re: [PATCH v5 01/11] xen/arm: xc_domain_ioport_permission(..) not
 supported on ARM.
Thread-Topic: [PATCH v5 01/11] xen/arm: xc_domain_ioport_permission(..) not
 supported on ARM.
Thread-Index:
 AQHXutl5d8zkP9bsD0GXT4+5QPGclKvNtfkAgAAGc4CAABOEAIAABXoAgAAEuYCAAAVHAIAAJiWAgAAK0ICAAQCPgIAAA0qA
Date: Tue, 12 Oct 2021 08:41:34 +0000
Message-ID: <ED8FC92F-B5EF-4473-B4A9-641C7D44859F@arm.com>
References: <cover.1633540842.git.rahul.singh@arm.com>
 <d292392268df2c74c4103a82ef917072643407a8.1633540842.git.rahul.singh@arm.com>
 <YWQkblfNMYEs6jI9@MacBook-Air-de-Roger.local>
 <77CF7FA5-C566-469E-B4A8-0400789890BB@arm.com>
 <YWQ6Nk3Jk+BqgkwZ@MacBook-Air-de-Roger.local>
 <53AE6E2A-01D7-41EC-9B2C-C0D596EB8D4D@arm.com>
 <YWRCxXGQIyTOAepC@MacBook-Air-de-Roger.local>
 <FEF0B03A-5AC8-4F8D-B821-191AC2EF8295@arm.com>
 <YWRnMfAi808TQ4Gt@MacBook-Air-de-Roger.local>
 <EB1CB53B-9D5A-49C5-A687-841BF94A153F@arm.com>
 <ac6d4785-ac9a-4491-26bb-c66ffe82c55b@suse.com>
In-Reply-To: <ac6d4785-ac9a-4491-26bb-c66ffe82c55b@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3654.120.0.1.13)
Authentication-Results-Original: suse.com; dkim=none (message not signed)
 header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: e4617f27-a836-4c82-9050-08d98d5c2230
x-ms-traffictypediagnostic: DB9PR08MB6346:|AM0PR08MB4323:
x-ms-exchange-transport-forked: True
X-Microsoft-Antispam-PRVS:
	<AM0PR08MB432312DA5C6D193AEADE1CCB9DB69@AM0PR08MB4323.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:10000;OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 dAjKjQkbKbYQNR5RQynB7XutHDEdphyuD55evcAwRFjzfVkMC5RauN5q//2jLosCd9wPYRlFnYy5yseNJD0QO1V3xKnjNJyerF9dO9eqpD61dPMV3pp7t8eWoSrwDTKDgAgbJwf90QhBVSHKw5VunZooJC6ecx3Prb3swH+EbzpscYIzyG/RBRZKhdXA2e+FrR9NhPEjw/64CEXIKHwnX29GbpExvvcRsX+PL/A2GJF2kttkBcZfZS7ncy1TAFGKhBb5IEouY7Z0OS2fap+lHvrR7E37SnhQHwDazv5ejRJK4wsvmENhW91S2k9tJ7klMOr3tkloqNhNvD3Tr3MooieogN4RJyeCzPuGAOdt4NFoL0+98vhlYHC6Om+STU3qx28uqeIvv4EEKwuW0EcIw2SdG0rIsIXIlS7RZBo+o9GtdyCvAPXed3rWwthOqwvSxsf/OK/SNpDGdoQv+3cxidJ+PQ5nXQqxpzHD2z4zy/ZQ7CB/C531RcIvFIiq/IUTRyAMoWzwSvIB5+XONDXWsI3Pp+Sw2c86iJC/8a3Uvaou9YEcAuNZH4uTiiiLS8WswDptiuhsnpqxfy7IpD153ZtzmG8d4raVICzgIFHxWw7IwDAX0SwWLDYZEY5ZLJQp1DHqGJBLF4CCh+4FHiiWwivfIHz9XYy7jAqa7MYOapKAxAn7e2f2TX1gOHr/y8WTp5b4Yb/GMCvEntYFzdPa2Nr7ByCW0ISZyKj8eC9uRKDaY7KakWk6zzDV3T91AO44
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB6PR0801MB2024.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(66946007)(83380400001)(76116006)(6506007)(8936002)(53546011)(186003)(26005)(122000001)(38100700002)(38070700005)(86362001)(36756003)(5660300002)(6486002)(8676002)(91956017)(2906002)(316002)(6512007)(33656002)(6916009)(66556008)(64756008)(66446008)(66476007)(2616005)(71200400001)(508600001)(54906003)(4326008)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-ID: <F794A02005889F43AEA2401FDCC87F99@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB6346
Original-Authentication-Results: suse.com; dkim=none (message not signed)
 header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT038.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	300898d1-3749-4f63-e2f2-08d98d5c18c4
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	XG/fBec2mp88daRFy1B35xAF7hoTMlZ8RmtNC4jmFYUZaRSdfJgc27ouKy4wiJyKg5cdP2BWseVb6/1BMQt0jY9R0RE6a3kF0oCXIg48Kw5X5kgxVo8Qzo4tZKe3sdGo1MQB1ndOY5oYg7G5kff7y44kpVp/p4jz0CUrYadBC20kytA7BxKTzMxLa1r0bt9SbeJSSZcBs6cgJGchTHw5JLt6h5KnjDSbjrvnI3iLAlm6WuKsXq9nBTW97eyp+MOlElHJh45AjVK1I0D50nqzQsDRulDgi+0F0pFNPmt8jqqkdioV5My57rYVnklaZtJkpx2sVxyjU9ur8tPHOWfR6FbrBU/TpspjWbSWU1rsN1JPuS5UwEOKuS/7sxxmwEoR3ZUttzcpiKYTiSKhKa/KQMlX3Mts1jHuKcYcK4QkKichxqfY7gmVWmAvTsnkDNM7cMjt/WmNgTAFrwiT9lcPbCahBnACt1jhpbAXDMOMkbDc9mvbX7e02zCWQxF0SdWgi1iPV39ldVNpX3qxcwIueOGqU+G4bAMHAm21ozJtsotwDZ+eDMzkELBuB2Swz1Q5UxaYSUF8EG8CnJOdt1zIg0UsLD/h51Dj3+NSjRda3zbCerryRsAmAsFYzUHOvf2DhWgJoJiWyTZnCzjAjY2iMhiM/qMxKQrY1wRiCKp6i+IAWzcu5TrdyRvwTqazLwSStlr6Zv4M3GPviS0tBK78Fw==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(53546011)(47076005)(6862004)(4326008)(70586007)(70206006)(336012)(8936002)(186003)(8676002)(6512007)(36756003)(86362001)(6506007)(2616005)(54906003)(5660300002)(508600001)(36860700001)(33656002)(81166007)(356005)(26005)(107886003)(6486002)(82310400003)(316002)(2906002)(83380400001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2021 08:41:49.9681
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: e4617f27-a836-4c82-9050-08d98d5c2230
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT038.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB4323

SGkgSmFuLA0KDQo+IE9uIDEyIE9jdCAyMDIxLCBhdCAwOToyOSwgSmFuIEJldWxpY2ggPGpiZXVs
aWNoQHN1c2UuY29tPiB3cm90ZToNCj4gDQo+IE9uIDExLjEwLjIwMjEgMTk6MTEsIEJlcnRyYW5k
IE1hcnF1aXMgd3JvdGU6DQo+Pj4gT24gMTEgT2N0IDIwMjEsIGF0IDE3OjMyLCBSb2dlciBQYXUg
TW9ubsOpIDxyb2dlci5wYXVAY2l0cml4LmNvbT4gd3JvdGU6DQo+Pj4gT24gTW9uLCBPY3QgMTEs
IDIwMjEgYXQgMDI6MTY6MTlQTSArMDAwMCwgQmVydHJhbmQgTWFycXVpcyB3cm90ZToNCj4+Pj4+
IE9uIDExIE9jdCAyMDIxLCBhdCAxNDo1NywgUm9nZXIgUGF1IE1vbm7DqSA8cm9nZXIucGF1QGNp
dHJpeC5jb20+IHdyb3RlOg0KPj4+Pj4gSSB0aGluayB0aGUgY29tbWl0IG1lc3NhZ2UgbmVlZHMg
dG8gYXQgbGVhc3QgYmUgZXhwYW5kZWQgaW4gb3JkZXIgdG8NCj4+Pj4+IGNvbnRhaW4gdGhlIGlu
Zm9ybWF0aW9uIHByb3ZpZGVkIGhlcmUuIEl0IG1pZ2h0IGFsc28gYmUgaGVscGZ1bCB0bw0KPj4+
Pj4gZmlndXJlIG91dCB3aGV0aGVyIHdlIHdvdWxkIGhhdmUgdG8gaGFuZGxlIElPIHBvcnQgYWNj
ZXNzZXMgaW4gdGhlDQo+Pj4+PiBmdXR1cmUgb24gQXJtLCBvciBpZiBpdCdzIGZpbmUgdG8ganVz
dCBpZ25vcmUgdGhlbS4NCj4+Pj4gDQo+Pj4+IEFsbCBvdXIgaW52ZXN0aWdhdGlvbnMgYW5kIHRl
c3RzIGhhdmUgYmVlbiBkb25lIHdpdGhvdXQgc3VwcG9ydGluZyBpdA0KPj4+PiB3aXRob3V0IGFu
eSBpc3N1ZXMgc28gdGhpcyBpcyBub3QgYSBjcml0aWNhbCBmZWF0dXJlIChtb3N0IGRldmljZXMg
Y2FuDQo+Pj4+IGJlIG9wZXJhdGVkIHdpdGhvdXQgdXNpbmcgdGhlIEkvTyBwb3J0cykuDQo+Pj4g
DQo+Pj4gSU1PIHdlIHNob3VsZCBsZXQgdGhlIHVzZXJzIGtub3cgdGhleSBhdHRlbXB0ZWQgdG8g
dXNlIGEgZGV2aWNlIHdpdGgNCj4+PiBCQVJzIGluIHRoZSBJTyBzcGFjZSwgYW5kIHRoYXQgdGhv
c2UgQkFScyB3b24ndCBiZSBhY2Nlc3NpYmxlIHdoaWNoDQo+Pj4gY291bGQgbWFrZSB0aGUgZGV2
aWNlIG5vdCBmdW5jdGlvbiBhcyBleHBlY3RlZC4NCj4+PiANCj4+PiBEbyB5b3UgdGhpbmsgaXQg
d291bGQgYmUgcmVhc29uYWJsZSB0byBhdHRlbXB0IHRoZSBoeXBlcmNhbGwgb24gQXJtDQo+Pj4g
YWxzbywgYW5kIGluIGNhc2Ugb2YgZXJyb3IgKG9uIEFybSkganVzdCBwcmludCBhIHdhcm5pbmcg
bWVzc2FnZSBhbmQNCj4+PiBjb250aW51ZSBvcGVyYXRpb25zIGFzIG5vcm1hbD8NCj4+IA0KPj4g
SSB0aGluayB0aGlzIHdvdWxkIGxlYWQgdG8gYSB3YXJuaW5nIHByaW50ZWQgb24gbG90cyBvZiBk
ZXZpY2VzIHdoZXJlIGluDQo+PiBmYWN0IHRoZXJlIHdvdWxkIGJlIG5vIGlzc3Vlcy4NCj4+IA0K
Pj4gSWYgdGhpcyBpcyBhbiBpc3N1ZSBmb3IgYSBkZXZpY2UgZHJpdmVyIGJlY2F1c2UgaXQgY2Fu
bm90IG9wZXJhdGUgd2l0aG91dA0KPj4gSS9PIHBvcnRzLCB0aGlzIHdpbGwgYmUgcmFpc2VkIGJ5
IHRoZSBkcml2ZXIgaW5zaWRlIHRoZSBndWVzdC4NCj4gDQo+IE9uIHdoYXQgYmFzaXMgd291bGQg
dGhlIGRyaXZlciBjb21wbGFpbj8gVGhlIGtlcm5lbCBtaWdodCBrbm93IG9mDQo+IHRoZSBNTUlP
IGVxdWl2YWxlbnQgZm9yIHBvcnRzLCBhbmQgaGVuY2UgbWlnaHQgYWxsb3cgdGhlIGRyaXZlcg0K
PiB0byBwcm9wZXJseSBvYnRhaW4gd2hhdGV2ZXIgaXMgbmVlZGVkIHRvIGxhdGVyIGFjY2VzcyB0
aGUgcG9ydHMuDQo+IEp1c3QgdGhhdCB0aGUgcG9ydCBhY2Nlc3NlcyB0aGVuIHdvdWxkbid0IHdv
cmsgKHBvc3NpYmx5IGNyYXNoaW5nDQo+IHRoZSBndWVzdCwgb3IgbWFraW5nIGl0IG90aGVyd2lz
ZSBtaXNiZWhhdmUpLg0KDQpBcyBFQ0FNIGFuZCBBcm0gZG9lcyBub3Qgc3VwcG9ydCBJL08gcG9y
dHMsIGEgZHJpdmVyIHJlcXVlc3RpbmcgYWNjZXNzDQp0byB0aGVtIHdvdWxkIGdldCBhbiBlcnJv
ciBiYWNrLg0KU28gaW4gcHJhY3RpY2UgaXQgaXMgbm90IHBvc3NpYmxlIHRvIHRyeSB0byBhY2Nl
c3MgdGhlIGlvcG9ydHMgYXMgdGhlcmUgaXMgbm8NCndheSBvbiBhcm0gdG8gdXNlIHRoZW0gKG5v
IGluc3RydWN0aW9ucykuDQoNCkEgZHJpdmVyIGNvdWxkIG1pc2JlaGF2ZSBieSBpZ25vcmluZyB0
aGUgZmFjdCB0aGF0IGlvcG9ydHMgYXJlIG5vdCB0aGVyZSBidXQNCkkgYW0gbm90IHF1aXRlIHN1
cmUgaG93IHdlIGNvdWxkIHNvbHZlIHRoYXQgYXMgaXQgd291bGQgYmUgYSBidWcgaW4gdGhlIGRy
aXZlci4NCg0KUmVnYXJkcw0KQmVydHJhbmQNCg0KPiANCj4gSmFuDQo+IA0KDQo=


From xen-devel-bounces@lists.xenproject.org Tue Oct 12 08:45:48 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 08:45:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.206933.362621 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maDPt-0008IV-6a; Tue, 12 Oct 2021 08:45:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 206933.362621; Tue, 12 Oct 2021 08:45:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maDPt-0008IO-2x; Tue, 12 Oct 2021 08:45:45 +0000
Received: by outflank-mailman (input) for mailman id 206933;
 Tue, 12 Oct 2021 08:45:43 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=/4YK=PA=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1maDPr-0008II-Oj
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 08:45:43 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id c7640fcb-2b38-11ec-811b-12813bfff9fa;
 Tue, 12 Oct 2021 08:45:42 +0000 (UTC)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2058.outbound.protection.outlook.com [104.47.12.58]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-17-peeFuJZsM_aZ4wEQjb2epw-1; Tue, 12 Oct 2021 10:45:40 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB6176.eurprd04.prod.outlook.com (2603:10a6:803:f6::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.22; Tue, 12 Oct
 2021 08:45:38 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4587.026; Tue, 12 Oct 2021
 08:45:38 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS9PR04CA0055.eurprd04.prod.outlook.com (2603:10a6:20b:46a::11) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.25 via Frontend
 Transport; Tue, 12 Oct 2021 08:45:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c7640fcb-2b38-11ec-811b-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634028341;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=BPt/E1JfLJqoDnFH7T65ED/KwnzJBIlFxt5MNN0OBfw=;
	b=Mwg4l9WPMG4Ji5Beih+dmcFb2f3DWCSRzzLt5zKNlGhljsSfjuefrZylwFy1EDHpsewTRd
	peiIscCxHchYNwRuqK3C7Hvu4wK1pvzvrhlVAmyeyl9cxXft7/Mr8s7OI9tmy24cj7SlD3
	zthIKpMNKSSpReqitM36ASHj8z01uac=
X-MC-Unique: peeFuJZsM_aZ4wEQjb2epw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=I0hp8R84309ZbQDxJ7rOC9z/5SUpYHRxWXxK/K/vPlzW1QIi7CLZhg9HlcM2HHcy73kH8pPl8TNX8G4pM7Ln3WzFMHrgesP7kEAOPrQ68SLJq4CA4E8yg4bmUBGzuJlaafgZnWQPH783UXfT/jVQnMLx2+TMJOHDHZvp4ajuvcEzi3wY5ENyzwqA2N6GT4nnFMBepDVw55IyoYCnkmIoOAwFh9JIeTipGnHj0QuUOcO0IR5Lm3X39/s8Yk4AO4pW1Tbwn5HlDylZK08jDYsxFy4sXvP7xbopx6VFAcMXgptayFOm6yODApMYLQYW3rMgCSGhHXNv8OjNhuk7c8koag==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=BPt/E1JfLJqoDnFH7T65ED/KwnzJBIlFxt5MNN0OBfw=;
 b=SFpN+a3Q90rUedKBDY7GyUUMIdKDA4e4pA8seEVLDOmNXjxKy5c/VUqxOVTL9NxhpUi/1JZ9g9OZEjqL5wl7cii4navmnoxeD1ApsEvBbZfJyA6u82X8/2NIHH/ZM1jt8+KIuIk0Lold6H7oYi91CUbDSJ0cEns2GrTmoDoXGqn5z8K33LbG7gV0ctgCohx1V/IhwkYJdRUnr5Wp25sBq4DTPoBEQJvYbwL49gAFbPWcKF2aWXujOvylp7zSsLErC2SsDbie96YU1tpd7DGFfm8l9Ynm/mouhgFuOXStKyWx9eZCj0cGoXk9jY7kMhtnjN5Ol3i2XGWXhymvyxMupg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [PATCH v6 1/2] arm/efi: Use dom0less configuration when using EFI
 boot
To: Luca Fancellu <luca.fancellu@arm.com>
Cc: bertrand.marquis@arm.com, wei.chen@arm.com,
 Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Wei Liu <wl@xen.org>, xen-devel@lists.xenproject.org
References: <20211011181528.17367-1-luca.fancellu@arm.com>
 <20211011181528.17367-2-luca.fancellu@arm.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <f29c8062-8430-6e08-7d4b-02096a6b049f@suse.com>
Date: Tue, 12 Oct 2021 10:45:35 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <20211011181528.17367-2-luca.fancellu@arm.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR04CA0055.eurprd04.prod.outlook.com
 (2603:10a6:20b:46a::11) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 54ff1f14-7092-4c96-1ae1-08d98d5caa01
X-MS-TrafficTypeDiagnostic: VI1PR04MB6176:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB61764DC53F03A93A19F9AEB9B3B69@VI1PR04MB6176.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:209;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	6RjXkSZ9M3t2YJWv4KJAMtplbtreER0elHdZ6SIEcUyb76ELwotGueHh/NX4n1wt6XorfNqL3fNfUZa4a4tXDc+7q1/JlOaFfAoz94LrKY5MnhB/i0BM0mHShdJGPcbYL3hStbf97Lwgq9JdK/0Rrek4CdSugiUVhIEFgWWJ/n4LPiWWvyDDYCI3+fxvR6j1DJYEu+xb3itzLraMObuJNr8bm39UK0FSBitobzS03OJWZzPTqnr2hRbFr2o1GjjDd9IrmPspWgH/vX1pJRUGb/UXSHog74JJgQrG5QQP2JhroKj1lfYGhsfMIkAWffBEXQKu+QidqlYtZTJ23SM6YGv1O2LQBJyaREFoZVQh1QOLzkajArr/02JV4lztzMStzccDhAcYXyyVK/d/kdbcCJE8YccmhQikaacPDbfwpi/eJd+J6YHCERofANZbMufGTEF+vMt8u7DsFVzEq7+DdAC4Xwu3mosZ2oNh0mPxMPxlrzRiXmAxbAsZoMIZ6dwLYGrvpfOfT/Eppj8wLO/igXPenzEeq+oz6MzJjJdtxRFmQvmSHmTkuMUr7t2399vmBK/Zyb0MDy248EqwD35jJt8naGzkQaylbFzX90e/QINW/xrLw5XEWvZr7RMNWinyDNdAy8/nh1Ls5LGiiZeQQLfLLXVubJYUaxdG1NDkb/ztUc9FRVfzcGfUiKIPVGymvakycdEt/S/Z6rtPkxaxZL6YDFz4znagDPIdrZwwWQMS+SkpzMBLt4Mlu0srkAEa
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(16576012)(186003)(8676002)(6486002)(26005)(2906002)(31696002)(54906003)(66476007)(36756003)(6916009)(38100700002)(31686004)(66946007)(508600001)(66556008)(4326008)(2616005)(86362001)(956004)(7416002)(5660300002)(53546011)(4744005)(8936002)(316002)(32563001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?TXNlN1N3MU16dEt6TUc0M0piblk4V1FHR2l2bmoyRXlURzU4elA2S0ZpK0E2?=
 =?utf-8?B?K3czdmM5bUNMZUdncU5xaGZzWFB3TWk2NVc5TG8yaVZMdnRjQWRtdGNyZENo?=
 =?utf-8?B?OVJrNGE4MFk3SGhnWnVjTFhEQjdlb2Z2djdlak9WSGJBbkxPUkllN1g1S3p5?=
 =?utf-8?B?SElNd2FqWEIra0tmaUt5QjZxbkdROEZiQXNXb2xBcDJSNW8vUXZoMjdrQVV5?=
 =?utf-8?B?L0FBWWwyMFRhMXU2RUpBYnlUNlNOSXNuSDd2RVVZL1YwSWw0aTM2OXdKMTJv?=
 =?utf-8?B?Njl6bkFyVEVKU1VXYXp5Wjg1TzAxOXlkWjNiRmdvaTlWSVpVQjBBL2JQTG1E?=
 =?utf-8?B?TFdaaUlwZ016UHRxRlBBbkw5bytQcHoyMEtvRW9TZG1wbGRGWFh2VldCZ1lM?=
 =?utf-8?B?WTJ0Zit0azNNN1pkNnJ5WmZnNlRHMHBpOU9tOFAvTVc3KzQxbmtEemZiWTJ4?=
 =?utf-8?B?ODk1ZGRKTU53REdxdHE4RzVERkNPT01pdU5PUFNaWHo3K0FmeTJaUGVrNTFi?=
 =?utf-8?B?WjdROUNYNWlUWlZOTkZHaVM2WXlmMkhXbmFkT2F0TGRWSjhXdS9XK1k5VXAz?=
 =?utf-8?B?K0xaNmpDSkVOM2E1NDBnR2NaaUFVUjFFZFlxK2FzNFIvVGYxcHlWUjRiRDJI?=
 =?utf-8?B?REZyLzJNd2ltdVdiV2xkdklIZUg3WmxscDlaakp6UVArSFA1aDlFbEdnRVV3?=
 =?utf-8?B?WWtxRHpERHZKd1dLZEhxKzhvdkpjdnJNOUZMdWdVMVc0UVFqcDdjUmRsVmht?=
 =?utf-8?B?SFNXNHJtN2k1K01jOTYreXNkMlByRGxWQTNJS3F4aDVJNUxmelhBbFRFd3Va?=
 =?utf-8?B?emJmUkpISmtVK0o2YXhHakI2a3lqTTJOK2pHWUdsZ2ZIZGJNWEZMM3RUUEZZ?=
 =?utf-8?B?QlZYYVpTdCtuczl6SjhPYTJiSy9QemNjS2F3UzlYcE9Cd0Evcm1ndTA3bmlR?=
 =?utf-8?B?Q3Y4SDYyUzM3TVpGUUp2VkN0cVBlOUs2VHB0ZVFLKzNKWllVV1hWa0x4QmFM?=
 =?utf-8?B?ZVNYangvb0ZjYXBaTzNxODNueHE1anFsVHluQUk5U05KbnZ4YWpRNDdLVGdF?=
 =?utf-8?B?Y2I4MzUrVlpvT2NvT3BkQmt4WE5ZeUJWQWxXbU10eHNhclpNbVJUVm91aDV5?=
 =?utf-8?B?Tkx0cUM5blMrUEU5Z3pTYW1UMjV6VzQvc0pPZXBzVFZhc2U3c1JSRkR1d2ZN?=
 =?utf-8?B?UVBxak9xd1RzYWZiYitEUHpJMHc3M0tONWErcDJERTUrZjV4eEYyOGJDQ01l?=
 =?utf-8?B?V0cwRUNoeE0zdXVVeXRZVjdUWDBxVUNsV00yREhWbnpTbWc1VE02S2dKNkJn?=
 =?utf-8?B?Rm55VXpBSlNuWmV4T1c2a2hnMFV5WlkrRjRWQzU2cjBtM0V3cDZveGtMY3JK?=
 =?utf-8?B?Z1Z5MmRKZllFWnpUSW04bEJMYjhPbmYwS0RuY2V6ajVmdWxXeXRaSE1Fa3hj?=
 =?utf-8?B?cmVVWnc1amJ6c1dXR0N2VUIrdjNETUtIQTl3STI0RXI5WTJadG5RY2lDcUtz?=
 =?utf-8?B?dEFZR0ZHM3N1bzNQdlRzcisxUExldHVrSUlKbVRxM0d4WE8yQVk2YXFSRThh?=
 =?utf-8?B?RnZtcTJCdExFYlg3aVVycHRRVEpGRVNRZXdpNnhMbEV5dDFDMlpkZzljUS90?=
 =?utf-8?B?NDlRejNvWGFqY3JVUmVINVRtQlYxRnJCNndRSW9WTjhoUGRqcjR1QnlCSGVO?=
 =?utf-8?B?akpPd2IxOVFMODlyUkxyZzNNN3hWY0FpWHVCWHJ3TjE1aGt0MDJQZ2RrZk9I?=
 =?utf-8?Q?7w9+obaC8y4g/AuS9Ss+zVETgXsUGVbDzYgcf/e?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 54ff1f14-7092-4c96-1ae1-08d98d5caa01
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2021 08:45:37.9422
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: qMLpg1gJoLhCn8zLdyWmQamfOt5s5xl8gxtfxnfESYfmFJhFv7idY3Ol2XTfP8PsiqadQYeh7kPnFhObByj/eA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6176

On 11.10.2021 20:15, Luca Fancellu wrote:
> --- a/xen/common/efi/boot.c
> +++ b/xen/common/efi/boot.c
> @@ -166,6 +166,13 @@ static void __init PrintErr(const CHAR16 *s)
>      StdErr->OutputString(StdErr, (CHAR16 *)s );
>  }
>  
> +#ifndef CONFIG_HAS_DEVICE_TREE
> +static inline int __init efi_check_dt_boot(EFI_FILE_HANDLE dir_handle)

Didn't we agree that you would drop "inline" from here?

Jan



From xen-devel-bounces@lists.xenproject.org Tue Oct 12 08:47:15 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 08:47:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.206940.362631 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maDRK-0000SV-Hh; Tue, 12 Oct 2021 08:47:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 206940.362631; Tue, 12 Oct 2021 08:47:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maDRK-0000SO-Eb; Tue, 12 Oct 2021 08:47:14 +0000
Received: by outflank-mailman (input) for mailman id 206940;
 Tue, 12 Oct 2021 08:47:12 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=xSmm=PA=suse.com=jgross@srs-us1.protection.inumbo.net>)
 id 1maDRI-0000SG-J7
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 08:47:12 +0000
Received: from smtp-out2.suse.de (unknown [195.135.220.29])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id fd59dd4c-2b38-11ec-811c-12813bfff9fa;
 Tue, 12 Oct 2021 08:47:11 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id BD49F2018C;
 Tue, 12 Oct 2021 08:47:10 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 4E1F4132D4;
 Tue, 12 Oct 2021 08:47:10 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id 6RzSEY5LZWFnUgAAMHmgww
 (envelope-from <jgross@suse.com>); Tue, 12 Oct 2021 08:47:10 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fd59dd4c-2b38-11ec-811c-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1634028430; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=JB2Z/ap3p/ozir+kNXemf/7ULjDPoEQIOSGuS/Q+J1g=;
	b=RueUjpu8xXwCeuaJV1kiIzfMB7u3j6pafWXmkTr4oVLLC5rOVmLAmdEE29LHiEDkr2EnUK
	ormQtxbLWA2aUgGJbh3V1F3XFeyoubbCFc/smjpCB/sVPLJdyOgmqMDWwI9yz1e7aPe0si
	JfUB8uLVtxiS3tWoglsSBY1dmCMv+h4=
Subject: Re: [PATCH 0/2] Fix the Xen HVM kdump/kexec boot panic issue
To: Dongli Zhang <dongli.zhang@oracle.com>, xen-devel@lists.xenproject.org
Cc: linux-kernel@vger.kernel.org, x86@kernel.org, boris.ostrovsky@oracle.com,
 sstabellini@kernel.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
 hpa@zytor.com, andrew.cooper3@citrix.com, george.dunlap@citrix.com,
 iwj@xenproject.org, jbeulich@suse.com, julien@xen.org, wl@xen.org,
 joe.jin@oracle.com
References: <20211012072428.2569-1-dongli.zhang@oracle.com>
From: Juergen Gross <jgross@suse.com>
Message-ID: <cb2e1a63-de79-5050-bf2b-bfb302997381@suse.com>
Date: Tue, 12 Oct 2021 10:47:09 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <20211012072428.2569-1-dongli.zhang@oracle.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="uPRoEoKWHKHoHy3MLDlGvNADfKQ7szQES"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--uPRoEoKWHKHoHy3MLDlGvNADfKQ7szQES
Content-Type: multipart/mixed; boundary="uicLRxaF8iOZHvIT8WoJMuxTg06qUTpt6";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Dongli Zhang <dongli.zhang@oracle.com>, xen-devel@lists.xenproject.org
Cc: linux-kernel@vger.kernel.org, x86@kernel.org, boris.ostrovsky@oracle.com,
 sstabellini@kernel.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
 hpa@zytor.com, andrew.cooper3@citrix.com, george.dunlap@citrix.com,
 iwj@xenproject.org, jbeulich@suse.com, julien@xen.org, wl@xen.org,
 joe.jin@oracle.com
Message-ID: <cb2e1a63-de79-5050-bf2b-bfb302997381@suse.com>
Subject: Re: [PATCH 0/2] Fix the Xen HVM kdump/kexec boot panic issue
References: <20211012072428.2569-1-dongli.zhang@oracle.com>
In-Reply-To: <20211012072428.2569-1-dongli.zhang@oracle.com>

--uicLRxaF8iOZHvIT8WoJMuxTg06qUTpt6
Content-Type: multipart/mixed;
 boundary="------------68E2B457EE3B2A0920C5CFF1"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------68E2B457EE3B2A0920C5CFF1
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 12.10.21 09:24, Dongli Zhang wrote:
> When the kdump/kexec is enabled at HVM VM side, to panic kernel will tr=
ap
> to xen side with reason=3Dsoft_reset. As a result, the xen will reboot =
the VM
> with the kdump kernel.
>=20
> Unfortunately, when the VM is panic with below command line ...
>=20
> "taskset -c 33 echo c > /proc/sysrq-trigger"
>=20
> ... the kdump kernel is panic at early stage ...
>=20
> PANIC: early exception 0x0e IP 10:ffffffffa8c66876 error 0 cr2 0x20
> [    0.000000] CPU: 0 PID: 0 Comm: swapper Not tainted 5.15.0-rc5xen #1=

> [    0.000000] Hardware name: Xen HVM domU
> [    0.000000] RIP: 0010:pvclock_clocksource_read+0x6/0xb0
> ... ...
> [    0.000000] RSP: 0000:ffffffffaa203e20 EFLAGS: 00010082 ORIG_RAX: 00=
00000000000000
> [    0.000000] RAX: 0000000000000003 RBX: 0000000000010000 RCX: 0000000=
0ffffdfff
> [    0.000000] RDX: 0000000000000003 RSI: 00000000ffffdfff RDI: 0000000=
000000020
> [    0.000000] RBP: 0000000000011000 R08: 0000000000000000 R09: 0000000=
000000001
> [    0.000000] R10: ffffffffaa203e00 R11: ffffffffaa203c70 R12: 0000000=
040000004
> [    0.000000] R13: ffffffffaa203e5c R14: ffffffffaa203e58 R15: 0000000=
000000000
> [    0.000000] FS:  0000000000000000(0000) GS:ffffffffaa95e000(0000) kn=
lGS:0000000000000000
> [    0.000000] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> [    0.000000] CR2: 0000000000000020 CR3: 00000000ec9e0000 CR4: 0000000=
0000406a0
> [    0.000000] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000=
000000000
> [    0.000000] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000=
000000400
> [    0.000000] Call Trace:
> [    0.000000]  ? xen_init_time_common+0x11/0x55
> [    0.000000]  ? xen_hvm_init_time_ops+0x23/0x45
> [    0.000000]  ? xen_hvm_guest_init+0x214/0x251
> [    0.000000]  ? 0xffffffffa8c00000
> [    0.000000]  ? setup_arch+0x440/0xbd6
> [    0.000000]  ? start_kernel+0x6a/0x689
> [    0.000000]  ? secondary_startup_64_no_verify+0xc2/0xcb
>=20
> This is because Xen HVM supports at most MAX_VIRT_CPUS=3D32 'vcpu_info'=

> embedded inside 'shared_info' during early stage until xen_vcpu_setup()=
 is
> used to allocate/relocate 'vcpu_info' for boot cpu at arbitrary address=
=2E
>=20
>=20
> The 1st patch is to fix the issue at VM kernel side. However, we may
> observe clock drift at VM side due to the issue at xen hypervisor side.=

> This is because the pv vcpu_time_info is not updated when
> VCPUOP_register_vcpu_info.
>=20
> The 2nd patch is to force_update_vcpu_system_time() at xen side when
> VCPUOP_register_vcpu_info, to avoid the VM clock drift during kdump ker=
nel
> boot.

Please don't mix patches for multiple projects in one series.

In cases like this it is fine to mention the other project's patch
verbally instead.


Juergen

--------------68E2B457EE3B2A0920C5CFF1
Content-Type: application/pgp-keys;
 name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Transfer-Encoding: quoted-printable
Content-Description: OpenPGP public key
Content-Disposition: attachment;
 filename="OpenPGP_0xB0DE9DD628BF132F.asc"

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy=
cWx
w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O=
f8Z
d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y=
9bf
IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq=
G7/
377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR=
3Jv
c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA=
QIe
AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT=
hpw
dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0=
MbD
1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv=
oPH
Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v=
5QL
+qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ=
2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC=
QoL
BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr=
Wf0
teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC=
/nu
AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh=
ITT
d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm=
XBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz=
80h
SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC=
AcD
AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn=
FOX
gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1=
jnD
kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0=
N51
N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l=
otu
fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1=
tqS
EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA=
hsD
BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3=
g3O
ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5=
dM7
wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5=
D+j
LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm=
V2x
AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N=
Eaw
QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW=
nHI
s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR=
wgn
BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV=
bVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk=
pEd
IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA=
QAB
wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw=
Tbe
8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1=
vJz
Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8=
VGi
wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW=
svi
uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX=
zXs
ZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------68E2B457EE3B2A0920C5CFF1--

--uicLRxaF8iOZHvIT8WoJMuxTg06qUTpt6--

--uPRoEoKWHKHoHy3MLDlGvNADfKQ7szQES
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmFlS40FAwAAAAAACgkQsN6d1ii/Ey86
aQf/Uv2hdFYAoRQS28mAvxu0GFBM7BcCLV7n9bNrkyI6o0QH8K1T6k2jnotRX89UcLs+m4kg7l+j
6lBCVV8Xc3pOehh9E7rwsdjBQ/haQJ54o98pdZFFdrhTYpmr9/UhvuJhO92TyAjqKnGhzRnGIjY3
rgN5odaJWWLy1Q6/uB4cHYGSfOfrjakTE4BRbmx+LvhXtm/db2puG5vNVK7BUEjOIypT6mQUPrYO
41RnpJv4wJpoX8XdX5F2rqOHQ6BN+gYEindMOlXvaNocgZEpCl4L2waRYN/VPoo8sDzLE1hUZ7X+
JTJ1YNiEwGm67N0JrmvmVaRYoSEWOaM3YcfIIghLjQ==
=Nmh3
-----END PGP SIGNATURE-----

--uPRoEoKWHKHoHy3MLDlGvNADfKQ7szQES--


From xen-devel-bounces@lists.xenproject.org Tue Oct 12 08:48:49 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 08:48:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.206947.362642 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maDSq-00015G-TM; Tue, 12 Oct 2021 08:48:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 206947.362642; Tue, 12 Oct 2021 08:48:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maDSq-000159-QP; Tue, 12 Oct 2021 08:48:48 +0000
Received: by outflank-mailman (input) for mailman id 206947;
 Tue, 12 Oct 2021 08:48:47 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=xSmm=PA=suse.com=jgross@srs-us1.protection.inumbo.net>)
 id 1maDSp-00014x-9W
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 08:48:47 +0000
Received: from smtp-out2.suse.de (unknown [195.135.220.29])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 63b71ba4-e2eb-4760-8809-e28a8837e41c;
 Tue, 12 Oct 2021 08:48:46 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 70AF32018C;
 Tue, 12 Oct 2021 08:48:45 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 05920132D4;
 Tue, 12 Oct 2021 08:48:45 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id yUgdAO1LZWERUwAAMHmgww
 (envelope-from <jgross@suse.com>); Tue, 12 Oct 2021 08:48:45 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 63b71ba4-e2eb-4760-8809-e28a8837e41c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1634028525; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=q3KUcXkQJ10FRCj4YgZOCN8rFwXTQD7vMOH9ik9p7iA=;
	b=sffvnVCB3QQpIpRny0e7FcxRcmpQxsvWaFUCOBST3H+ud49L5hRYNM+aVaQgL57tjSvpjB
	byOEVLiToOADDY50a4JDCeRMv0UyxRC7Z+sqmHkPTitdCKEh9EJGVcAxUR+dpWoUpnszDf
	/GiwMMbQcoOjMbS5bC8ueMd5W5DNqbQ=
Subject: Re: [PATCH linux 1/2] xen: delay xen_hvm_init_time_ops() if kdump is
 boot on vcpu>=32
To: Dongli Zhang <dongli.zhang@oracle.com>, xen-devel@lists.xenproject.org
Cc: linux-kernel@vger.kernel.org, x86@kernel.org, boris.ostrovsky@oracle.com,
 sstabellini@kernel.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
 hpa@zytor.com, andrew.cooper3@citrix.com, george.dunlap@citrix.com,
 iwj@xenproject.org, jbeulich@suse.com, julien@xen.org, wl@xen.org,
 joe.jin@oracle.com
References: <20211012072428.2569-1-dongli.zhang@oracle.com>
 <20211012072428.2569-2-dongli.zhang@oracle.com>
From: Juergen Gross <jgross@suse.com>
Message-ID: <c58fe0bb-d1be-4dac-acf1-040cceb1271a@suse.com>
Date: Tue, 12 Oct 2021 10:48:44 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <20211012072428.2569-2-dongli.zhang@oracle.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="MqMswA9vGM6pPMxHJ3Nj3XxEnoTGHrXao"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--MqMswA9vGM6pPMxHJ3Nj3XxEnoTGHrXao
Content-Type: multipart/mixed; boundary="5J4vDOXKh5d9mCnHws61KPXU9QUYI7STa";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Dongli Zhang <dongli.zhang@oracle.com>, xen-devel@lists.xenproject.org
Cc: linux-kernel@vger.kernel.org, x86@kernel.org, boris.ostrovsky@oracle.com,
 sstabellini@kernel.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
 hpa@zytor.com, andrew.cooper3@citrix.com, george.dunlap@citrix.com,
 iwj@xenproject.org, jbeulich@suse.com, julien@xen.org, wl@xen.org,
 joe.jin@oracle.com
Message-ID: <c58fe0bb-d1be-4dac-acf1-040cceb1271a@suse.com>
Subject: Re: [PATCH linux 1/2] xen: delay xen_hvm_init_time_ops() if kdump is
 boot on vcpu>=32
References: <20211012072428.2569-1-dongli.zhang@oracle.com>
 <20211012072428.2569-2-dongli.zhang@oracle.com>
In-Reply-To: <20211012072428.2569-2-dongli.zhang@oracle.com>

--5J4vDOXKh5d9mCnHws61KPXU9QUYI7STa
Content-Type: multipart/mixed;
 boundary="------------4AF84FE6AF4427206B1EC4B0"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------4AF84FE6AF4427206B1EC4B0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 12.10.21 09:24, Dongli Zhang wrote:
> The sched_clock() can be used very early since upstream
> commit 857baa87b642 ("sched/clock: Enable sched clock early"). In addit=
ion,
> with upstream commit 38669ba205d1 ("x86/xen/time: Output xen sched_cloc=
k
> time from 0"), kdump kernel in Xen HVM guest may panic at very early st=
age
> when accessing &__this_cpu_read(xen_vcpu)->time as in below:
>=20
> setup_arch()
>   -> init_hypervisor_platform()
>       -> x86_init.hyper.init_platform =3D xen_hvm_guest_init()
>           -> xen_hvm_init_time_ops()
>               -> xen_clocksource_read()
>                   -> src =3D &__this_cpu_read(xen_vcpu)->time;
>=20
> This is because Xen HVM supports at most MAX_VIRT_CPUS=3D32 'vcpu_info'=

> embedded inside 'shared_info' during early stage until xen_vcpu_setup()=
 is
> used to allocate/relocate 'vcpu_info' for boot cpu at arbitrary address=
=2E
>=20
> However, when Xen HVM guest panic on vcpu >=3D 32, since
> xen_vcpu_info_reset(0) would set per_cpu(xen_vcpu, cpu) =3D NULL when
> vcpu >=3D 32, xen_clocksource_read() on vcpu >=3D 32 would panic.
>=20
> This patch delays xen_hvm_init_time_ops() to later in
> xen_hvm_smp_prepare_boot_cpu() after the 'vcpu_info' for boot vcpu is
> registered when the boot vcpu is >=3D 32.
>=20
> This issue can be reproduced on purpose via below command at the guest
> side when kdump/kexec is enabled:
>=20
> "taskset -c 33 echo c > /proc/sysrq-trigger"
>=20
> Cc: Joe Jin <joe.jin@oracle.com>
> Signed-off-by: Dongli Zhang <dongli.zhang@oracle.com>
> ---
>   arch/x86/xen/enlighten_hvm.c | 20 +++++++++++++++++++-
>   arch/x86/xen/smp_hvm.c       |  3 +++
>   2 files changed, 22 insertions(+), 1 deletion(-)
>=20
> diff --git a/arch/x86/xen/enlighten_hvm.c b/arch/x86/xen/enlighten_hvm.=
c
> index e68ea5f4ad1c..152279416d9a 100644
> --- a/arch/x86/xen/enlighten_hvm.c
> +++ b/arch/x86/xen/enlighten_hvm.c
> @@ -216,7 +216,25 @@ static void __init xen_hvm_guest_init(void)
>   	WARN_ON(xen_cpuhp_setup(xen_cpu_up_prepare_hvm, xen_cpu_dead_hvm));
>   	xen_unplug_emulated_devices();
>   	x86_init.irqs.intr_init =3D xen_init_IRQ;
> -	xen_hvm_init_time_ops();
> +
> +	/*
> +	 * Only MAX_VIRT_CPUS 'vcpu_info' are embedded inside 'shared_info'
> +	 * and the VM would use them until xen_vcpu_setup() is used to
> +	 * allocate/relocate them at arbitrary address.
> +	 *
> +	 * However, when Xen HVM guest panic on vcpu >=3D MAX_VIRT_CPUS,
> +	 * per_cpu(xen_vcpu, cpu) is still NULL at this stage. To access
> +	 * per_cpu(xen_vcpu, cpu) via xen_clocksource_read() would panic.
> +	 *
> +	 * Therefore we delay xen_hvm_init_time_ops() to
> +	 * xen_hvm_smp_prepare_boot_cpu() when boot vcpu is >=3D MAX_VIRT_CPU=
S.
> +	 */
> +	if (xen_vcpu_nr(0) >=3D MAX_VIRT_CPUS)
> +		pr_info("Delay xen_hvm_init_time_ops() as kernel is running on vcpu=3D=
%d\n",
> +			xen_vcpu_nr(0));
> +	else
> +		xen_hvm_init_time_ops();
> +
>   	xen_hvm_init_mmu_ops();
>  =20
>   #ifdef CONFIG_KEXEC_CORE
> diff --git a/arch/x86/xen/smp_hvm.c b/arch/x86/xen/smp_hvm.c
> index 6ff3c887e0b9..60cd4fafd188 100644
> --- a/arch/x86/xen/smp_hvm.c
> +++ b/arch/x86/xen/smp_hvm.c
> @@ -19,6 +19,9 @@ static void __init xen_hvm_smp_prepare_boot_cpu(void)=

>   	 */
>   	xen_vcpu_setup(0);
>  =20
> +	if (xen_vcpu_nr(0) >=3D MAX_VIRT_CPUS)
> +		xen_hvm_init_time_ops();
> +

Please add a comment referencing the related code in
xen_hvm_guest_init().


Juergen

--------------4AF84FE6AF4427206B1EC4B0
Content-Type: application/pgp-keys;
 name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Transfer-Encoding: quoted-printable
Content-Description: OpenPGP public key
Content-Disposition: attachment;
 filename="OpenPGP_0xB0DE9DD628BF132F.asc"

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy=
cWx
w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O=
f8Z
d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y=
9bf
IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq=
G7/
377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR=
3Jv
c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA=
QIe
AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT=
hpw
dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0=
MbD
1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv=
oPH
Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v=
5QL
+qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ=
2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC=
QoL
BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr=
Wf0
teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC=
/nu
AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh=
ITT
d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm=
XBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz=
80h
SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC=
AcD
AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn=
FOX
gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1=
jnD
kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0=
N51
N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l=
otu
fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1=
tqS
EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA=
hsD
BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3=
g3O
ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5=
dM7
wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5=
D+j
LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm=
V2x
AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N=
Eaw
QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW=
nHI
s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR=
wgn
BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV=
bVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk=
pEd
IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA=
QAB
wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw=
Tbe
8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1=
vJz
Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8=
VGi
wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW=
svi
uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX=
zXs
ZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------4AF84FE6AF4427206B1EC4B0--

--5J4vDOXKh5d9mCnHws61KPXU9QUYI7STa--

--MqMswA9vGM6pPMxHJ3Nj3XxEnoTGHrXao
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmFlS+wFAwAAAAAACgkQsN6d1ii/Ey96
Fgf/cUeloFlsH/cedS7E2oehk/aXw62ESyjJVfKjNl9tW7JE6CX0NxvqARl4VepSr/Tk4k7LZc88
75QR6XX+pGqB1jX+zIy6tXKuK48yi1tBwkFsLSn11FJ0yV+g+084fTDw48TwxolaSLV2J8ev4YKR
Ny+KDA+FokyXtdzHt363NFj3cafY+f0PuXISN4sLOkQhRs//ZcAnaLwvclmoUsrlyO25LTk5fL6N
zeg/ryClEy5zMHy14Df9pXEA5NQuh+7rohYTH2virh+w4487Id/i54Pd6SzK0LNWoMJcKy1UE0f2
mtco8lWymvneU+91zgTtCVwkU9AqiY6KOAj/lUlTaw==
=xKpQ
-----END PGP SIGNATURE-----

--MqMswA9vGM6pPMxHJ3Nj3XxEnoTGHrXao--


From xen-devel-bounces@lists.xenproject.org Tue Oct 12 09:06:32 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 09:06:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.206958.362654 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maDjt-0003TM-Gp; Tue, 12 Oct 2021 09:06:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 206958.362654; Tue, 12 Oct 2021 09:06:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maDjt-0003TF-CW; Tue, 12 Oct 2021 09:06:25 +0000
Received: by outflank-mailman (input) for mailman id 206958;
 Tue, 12 Oct 2021 09:06:24 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=GT6b=PA=arm.com=Luca.Fancellu@srs-us1.protection.inumbo.net>)
 id 1maDjs-0003T9-0h
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 09:06:24 +0000
Received: from EUR05-AM6-obe.outbound.protection.outlook.com (unknown
 [2a01:111:f400:7e1b::623])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 13be89fd-ff9a-49db-af6b-a5be55d6d32e;
 Tue, 12 Oct 2021 09:06:22 +0000 (UTC)
Received: from AM6P194CA0049.EURP194.PROD.OUTLOOK.COM (2603:10a6:209:84::26)
 by DBBPR08MB6123.eurprd08.prod.outlook.com (2603:10a6:10:20a::5) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.19; Tue, 12 Oct
 2021 09:06:19 +0000
Received: from AM5EUR03FT023.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:209:84:cafe::21) by AM6P194CA0049.outlook.office365.com
 (2603:10a6:209:84::26) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.24 via Frontend
 Transport; Tue, 12 Oct 2021 09:06:19 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM5EUR03FT023.mail.protection.outlook.com (10.152.16.169) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4587.18 via Frontend Transport; Tue, 12 Oct 2021 09:06:17 +0000
Received: ("Tessian outbound d5def7722ff7:v103");
 Tue, 12 Oct 2021 09:06:17 +0000
Received: from 3bc9fbb810a2.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 8CB05183-4295-426E-8EB6-A509E9BF2FAF.1; 
 Tue, 12 Oct 2021 09:06:07 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 3bc9fbb810a2.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Tue, 12 Oct 2021 09:06:07 +0000
Received: from PAXPR08MB6816.eurprd08.prod.outlook.com (2603:10a6:102:130::10)
 by PR2PR08MB4714.eurprd08.prod.outlook.com (2603:10a6:101:1c::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.22; Tue, 12 Oct
 2021 09:06:03 +0000
Received: from PAXPR08MB6816.eurprd08.prod.outlook.com
 ([fe80::c1b4:db1c:376f:b697]) by PAXPR08MB6816.eurprd08.prod.outlook.com
 ([fe80::c1b4:db1c:376f:b697%8]) with mapi id 15.20.4587.026; Tue, 12 Oct 2021
 09:06:03 +0000
Received: from smtpclient.apple (85.255.237.104) by
 LO4P123CA0266.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:194::19) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4587.25 via Frontend Transport; Tue, 12 Oct 2021 09:06:01 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 13be89fd-ff9a-49db-af6b-a5be55d6d32e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=jyG4HKQOj0NacWVS083vK83cbjR4x0e6QbTTpM3q1Kw=;
 b=QcwhdrjJ8NRCGOyWG9zFM6P/bH1zON/aE5mZXTlgVR8GTpyjVuLygaeV/HUah2PNlYMOdJvHnkZQwWjBE33Sg+MHfYNrDfFUAUnam7f9qGIVj43uUSAnp/qwz9tIpvR42zcsinARrKhgh9evNXUQU/Phr4RIn1syIYFo95az65I=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: e3a983ed42c84c11
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=GxudOVeDP3fOnFM4IVQpWEG/b6AKptxYKtjkEanTff+woiHLOTPWW2LLCzf0Qqw13Gm2W3m2ZznEWuFoEVQ5dLa2yaWkShbDc10uOV59hSRzc4voRFMm9IynzyOZzQSyR9yp5uJb4bSN06o1AjjccrI5iJPLhnyhGrX7BOfXwGf1wqpRf34+WwI9QSZgiQpCItcnHcPNslr738zOpsDOnV1lfh76dhRwrSAwi8pC9xgAsTpah121iNgQftzWRa+uqTT/veODcAXC0kBhiJdWx6dSdsvQlFYmU0lVPHo1WZYWnjIafzhIWk9pzLiVgSyJENx/NSPZP6Kn2xZDJ5YpfQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=jyG4HKQOj0NacWVS083vK83cbjR4x0e6QbTTpM3q1Kw=;
 b=WUay/CHIrZSYh3EXZZ5vAf3qYb86oLfU+zxuAeckFQ+JbGIV8O6nT4mfxAXQjU4L1akieYA3zN2AgXVKFlU8HrLXN9Oa/A0LY9MshZEh6aGYC9pb5mI1wNmHr2v9bHty0CZ7y5YwSyvaNF+wk76pzZR9Ai5Yv2b9MNtKhqmab337BPFfoFWUV6m5/t9Jh3W3HNNE7uzW/Gx/mlyPfPpwGK7fez7WRapT/mlIlD3dkqq0BLmkvzDmEeVg8r3m9aIxetYD5M0zeybvAVtxtLDbEdsU3XZN/8M+NjFdu1GssxosZ1keFodOnWDYSHOjsTm9dU12YBcZegI4FcJnQzEZmQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=jyG4HKQOj0NacWVS083vK83cbjR4x0e6QbTTpM3q1Kw=;
 b=QcwhdrjJ8NRCGOyWG9zFM6P/bH1zON/aE5mZXTlgVR8GTpyjVuLygaeV/HUah2PNlYMOdJvHnkZQwWjBE33Sg+MHfYNrDfFUAUnam7f9qGIVj43uUSAnp/qwz9tIpvR42zcsinARrKhgh9evNXUQU/Phr4RIn1syIYFo95az65I=
Authentication-Results-Original: suse.com; dkim=none (message not signed)
 header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
Content-Type: text/plain;
	charset=utf-8
Subject: Re: [PATCH v6 1/2] arm/efi: Use dom0less configuration when using EFI
 boot
From: Luca Fancellu <luca.fancellu@arm.com>
In-Reply-To: <f29c8062-8430-6e08-7d4b-02096a6b049f@suse.com>
Date: Tue, 12 Oct 2021 10:05:53 +0100
Cc: Bertrand Marquis <bertrand.marquis@arm.com>,
 wei.chen@arm.com,
 Stefano Stabellini <sstabellini@kernel.org>,
 Julien Grall <julien@xen.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Ian Jackson <iwj@xenproject.org>,
 Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <4FFFB177-883F-44DE-BF7E-53137AA7F0CB@arm.com>
References: <20211011181528.17367-1-luca.fancellu@arm.com>
 <20211011181528.17367-2-luca.fancellu@arm.com>
 <f29c8062-8430-6e08-7d4b-02096a6b049f@suse.com>
To: Jan Beulich <jbeulich@suse.com>
X-Mailer: Apple Mail (2.3654.120.0.1.13)
X-ClientProxiedBy: LO4P123CA0266.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:194::19) To PAXPR08MB6816.eurprd08.prod.outlook.com
 (2603:10a6:102:130::10)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: f2f4c524-5025-42f6-2fcd-08d98d5f8d23
X-MS-TrafficTypeDiagnostic: PR2PR08MB4714:|DBBPR08MB6123:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS:
	<DBBPR08MB6123BBB4D8D2AA68CAF1F45EE4B69@DBBPR08MB6123.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Oob-TLC-OOBClassifiers: OLM:972;OLM:972;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 16PZtdk7Qdf/euWJvyXCBmp/f6aeETmBqUAmRXP1vavc7uZ3I8IZlJXPuuNf2T1LtYU701HxJeYtZLrpo1i+2ofXFohtr7162GVe4K5D/T4U0exxNFo60inCpiUXQ9HVg1j1rrHW5XqXLnFzPHcXJpfY4DTU8EU2YdqVQpYdOCatEXhx4It94Tvdx/KombUHLBzGMpBsyv4McNPza/QmdDFptCsCIsNSMnTVn4rAM9e2F/Doqy9V9nGLiqga0Bx/z+4svO9rXPaka5iT6IU8EUuoiELEme//qs9fmmbJVaSU7yv9LvNIv+RvzvdVQkqnzsZFHLLvejlW3StxWtypVeQae+mRDvqas0Ftg5zyhTT2l+NP95hb/+c+75nhVev3d2aDg4CHFTVrLWqi0h48bi20Y40an0SEbQiyUJ8U9lMvrfS6E5ROhZETRHFaPIzdkLpCtUYAwadWC63b+WnB6REN6N0Rmd7w9CxPfcAW8moraEZ7c1RUlD7wmvGMnKZMnx6gzBSG/eg5m78ycuyv2ozg/bqlLIgpSmbSPV8Mtkd92prbCKYh75JOROc1RjWsgttq8ipyQaHu1DIAa9JsK5CFlDlWmM1qtOui94yPsm7JJunGIxv8wvPgBSHfcbvPD7nBroxixgLZa6vXA4jQGoqoB8p2iJPiQq5Hv4ANxzXe5iNcaMCwZOkg39gpxe+5mpZae4UJPYnkhT/1BMNFbK7kfK/+yx4MTC1Iqa93BjsOYFcu3ym7w/8z2HPn8VszGo2+UrzHw/zRaGe6ihVk2Q==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB6816.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(2906002)(6486002)(54906003)(66946007)(36756003)(4744005)(52116002)(53546011)(6506007)(508600001)(66556008)(66476007)(316002)(6512007)(6666004)(956004)(8936002)(2616005)(33656002)(186003)(6916009)(26005)(86362001)(44832011)(38100700002)(38350700002)(5660300002)(4326008)(8676002)(32563001)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR2PR08MB4714
Original-Authentication-Results: suse.com; dkim=none (message not signed)
 header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM5EUR03FT023.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	d281bbe6-2273-44a0-8201-08d98d5f8408
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	WsXPKHvj0s7MrGJ2kdpKtmhp60ASElUD18SbQIsUllV2I9FOo3Jy4KQE6EJUrj6GeZVP4s/K6o++1yme4sFHNxQtFOregqVhwWlMl0ukvn03ClqHcidAy9uP36ZoMKpmsBMMblMIHBTy9bPzSD9rzTQTB6S0NZhKQ4T0mgLFOK7WNQoJHxSkkry5Wn05j3PAZ6v9SM62X59xmHjjhuevtbGkd/utdzbabfEs23390cQc02irjfxdjFpaC6P10akTSNZkKhafuxTqcean2B/OywtCEUnadyaYhKWem9FgxkfRO9C77VR6M+IVE3vWTEXa/V6JSt2G+JiuBoPBlH9JUq1L2WpBN7H9Ty06HUydhFoPrAp/3O7fp7CIPlw6wgO1mELSViPtrrVha7Ur5vQDkF4YbYBWADdOO0gFvxdi7PVaP6L6AAvlwz1zb8O7ViBC7sm+TsJIFGzZXYLV6nzPBKa8RFmH/JHoYhgkmHOtBNe2+jEjHINs30N84hyIlJ1oA+o5J3PqaBG2Qa1wUDJ1Q2CDWYagGbwIgc3k8x9EOOoQu83neixdlBJDrToEsWhfZT++cHneie35FVMmCHkiG8VGVv9jpTwBVuEtrqVewyq062AdQrboCUoTpbKDNHSpYZsoRXKD6Uh+nOm5LcUFYRxN8LZLbGPu2Q20yV9jRbY+gTaebXRG3kW5vPEMbWOFsvc1v4E3Mt/ya9bercc3hnKzP+P6TImfrY0fh5Lt1k0=
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(54906003)(33656002)(956004)(2616005)(82310400003)(36756003)(4326008)(356005)(5660300002)(6862004)(336012)(36860700001)(53546011)(6506007)(44832011)(316002)(508600001)(186003)(6666004)(26005)(47076005)(81166007)(8676002)(70586007)(8936002)(70206006)(6512007)(4744005)(6486002)(86362001)(2906002)(32563001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2021 09:06:17.8399
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: f2f4c524-5025-42f6-2fcd-08d98d5f8d23
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM5EUR03FT023.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB6123



> On 12 Oct 2021, at 09:45, Jan Beulich <jbeulich@suse.com> wrote:
>=20
> On 11.10.2021 20:15, Luca Fancellu wrote:
>> --- a/xen/common/efi/boot.c
>> +++ b/xen/common/efi/boot.c
>> @@ -166,6 +166,13 @@ static void __init PrintErr(const CHAR16 *s)
>>     StdErr->OutputString(StdErr, (CHAR16 *)s );
>> }
>>=20
>> +#ifndef CONFIG_HAS_DEVICE_TREE
>> +static inline int __init efi_check_dt_boot(EFI_FILE_HANDLE dir_handle)
>=20
> Didn't we agree that you would drop "inline" from here?
>=20

Yes we did, really sorry I forgot to drop it, I=E2=80=99ll push another ser=
ie, given the inline
Dropped are you ok with the patch?

> Jan
>=20



From xen-devel-bounces@lists.xenproject.org Tue Oct 12 09:24:39 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 09:24:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.206968.362664 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maE1M-0005ji-28; Tue, 12 Oct 2021 09:24:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 206968.362664; Tue, 12 Oct 2021 09:24:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maE1L-0005jb-VZ; Tue, 12 Oct 2021 09:24:27 +0000
Received: by outflank-mailman (input) for mailman id 206968;
 Tue, 12 Oct 2021 09:24:27 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=/4YK=PA=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1maE1K-0005jV-UG
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 09:24:26 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 3d384706-f659-429b-b890-7d8b6df125ac;
 Tue, 12 Oct 2021 09:24:25 +0000 (UTC)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2052.outbound.protection.outlook.com [104.47.14.52]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-34-S8iHYoLNMzO4LpKNs88Q-A-1; Tue, 12 Oct 2021 11:24:23 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB7150.eurprd04.prod.outlook.com (2603:10a6:800:12a::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.19; Tue, 12 Oct
 2021 09:24:22 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4587.026; Tue, 12 Oct 2021
 09:24:22 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6P193CA0139.EURP193.PROD.OUTLOOK.COM (2603:10a6:209:85::44) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4587.25 via Frontend Transport; Tue, 12 Oct 2021 09:24:21 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3d384706-f659-429b-b890-7d8b6df125ac
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634030664;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=YJZGcpXtDh02n9Dttd375ZEN/OhO4vsMLJThZyN/6xA=;
	b=enHeJG1RiQJpmsiWIy83hMoNy7jFl2EGDqXGXuiwAAXGg8Xmks4TfbADbhQ7OjoLXmPwx/
	8bKM4nBujYu8utHJpMgOwcSsrOQx9b0R2cqYeI6mMtVWp0l1zEAE1JSNdPUlbcou9p4j5a
	fQBZLsznSVBBGTdL7sLiUt0wZAvP4go=
X-MC-Unique: S8iHYoLNMzO4LpKNs88Q-A-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Aq1sQFcEMdeRPHlrGJaaYv0tiXDnxgNnRTrgnq02Z4Ah4xvEDKHKEnSNyZb58oBtveX2H2Li8Zm7B2JR7OqSsQ/SdK4ztNsZLGO3sb1H9J/QIA3C/Mc6Wgu5vS+vT6wNY4qxl7RifeNyAGgjh6v9Z/FApczv2K+AR2N6kkYwnWpiLa+K5iNPeePkSx7TpwjPPttIa2wYwBPKxd2dO/+lbxaepuJzeAtxGovFkQhqOPHAubnFi9P7RUyam8jLeWZCTKUnkPHrmCdvj4+ESO2U8REbm1JCM+y0RBrk3XE+Owsp2it5UMywUUjL63tXazz48xEYbCMYe1PTsn7Au8XdAA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=YJZGcpXtDh02n9Dttd375ZEN/OhO4vsMLJThZyN/6xA=;
 b=T8MLz7TsJ0GY2cwNb/QgPTyjyKycVnOgq8+rCFU0r82J3kuSBd0Jc0gj0fRXuB2qHFSZjJkX//hDwZ4LaPB3tXkygY89OQZtIXs8yODwdDvilzcdgUe+vxccOvfaY5T0l9tAmzB4F8Yk9z11wNUxHE99ZZCWCMs5pk0+Y8SGeIAn6WjsNbIdV/G7gGhu/1LIZmod9uzWMDBhvx9dTDuJdYrj9rw6bAHtsGNnCs0GdT4P9GuxoHyn9dAW0WaVATvleNwqG/TRU967B/EcYuVZ1uaarJeA++14fp0Ce6VKljbsaFDqLXaDRQT0rSDrZYJdyVnnYz42ssbvWUb7+GpBYw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [PATCH V6 1/2] xen/arm: Introduce gpaddr_bits field to struct
 xen_domctl_getdomaininfo
To: Oleksandr Tyshchenko <olekstysh@gmail.com>
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>,
 Anthony PERARD <anthony.perard@citrix.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Juergen Gross
 <jgross@suse.com>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 xen-devel@lists.xenproject.org
References: <1633974539-7380-1-git-send-email-olekstysh@gmail.com>
 <1633974539-7380-2-git-send-email-olekstysh@gmail.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <1466e946-d247-2380-6d7d-cda405a2f255@suse.com>
Date: Tue, 12 Oct 2021 11:24:20 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <1633974539-7380-2-git-send-email-olekstysh@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P193CA0139.EURP193.PROD.OUTLOOK.COM
 (2603:10a6:209:85::44) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 9c0417cc-9000-4885-c66d-08d98d621352
X-MS-TrafficTypeDiagnostic: VI1PR04MB7150:
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB7150FBA15267CD5C174E4C8FB3B69@VI1PR04MB7150.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	GzB8GA8GR5pM9b0lhJj38EXUQV2BM+eSB5oA5q1E0samvaNt10y7pPxi1zpbNSQyazzKEnm+rqjM7yviaQSj2/e2aSNkwEH6YcqcGeSR4N4Nqzppb57qnWZ0BrGlaGG5Ck4AL69LNw5DCRboyGvTZOJst8Ntb0pQVFzrzIxGQ+uiZDRwr+NFok4nfoZe+bI0oAAK+GrbbAolFMBVk4T2iT/e11h9NxArhbsma2c0BxBqo9JY4+WN+9xYXwsLaxAylKxZ1y+JlXSYWAfgMBraJhkqr+varmCFrd/Gl59yu+7pFQX3hOOkGlmhGdgo6gKcJ7q5JM1RSDyaE/FZl4spRwziZ8wuC7GE+nIet9Mkje6Ike4PdiZq3698V/N1Gxmjl6xqBWYwYlaqumO5axL7VJ2S0O61LstPfoHqFkVIwQkzDs4+JRwClBaNPOzkCuzKTGuq169Oty8BTlUl14LvILFxhQIb72hN48xRZE31u4p/DEPAyR4zg/SGBJn890uGdc+/sbUhhu5ZFhgFtMRx5+nJ2cD7aUf4uaX2nauHgS1n1p8uRAT3xJ9nz/ALqkzFNVsTSeYYC3dVl+JIP8YjdoNAacRV+rUlTZVkHoacnL/UiFp/5X5Mb8rPmCwMto9uHr1KtAauiQvXCfzzqIHuFwJ2yjfm1T0a8Wg9Fc2n1dT6w33xZpTRUIu7MMsfg1/T5fqxevSK3XcfZFvrAdrFHADlBcnRgcq2nHcCbxkge02JHj6sH46oQkf8/O16UMQQ
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(66946007)(38100700002)(2616005)(31696002)(7416002)(956004)(316002)(16576012)(5660300002)(54906003)(66556008)(66476007)(6916009)(2906002)(508600001)(8936002)(186003)(26005)(4326008)(6486002)(86362001)(36756003)(53546011)(8676002)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?ZGxmalR2M1gySjFNa3BqdERIakJucElZYm1CRVlKenRTTm03dTEvSHFSa0s0?=
 =?utf-8?B?UCtBRHdjeFpjQUk0eld0OXd5WllZbHRSaVlEcm9PZnhrZzFHd3BLaTFTSEJ1?=
 =?utf-8?B?TDVrNmg3Uk55ajVrVDltaGt2aFV4aXA5bGZlSGRhWHQ4aC9RTVlSakN5NVRi?=
 =?utf-8?B?NkI5VTBDZE14VFNMNUhvbFlaajJYWlV6ZmppQk5neXVHdVBuVis1QXptT1l4?=
 =?utf-8?B?c2hhU0xHZ1NqMGpRZ1VtemtiQXFQcGdFdExvcG96OWU2eTdGZHJ3Vml4YWNY?=
 =?utf-8?B?MHpvbHIzc0RzOTIwZkkxbEVvZFZKbUIyUDYzanIwZlEwa21MUlhvOTJBYkNh?=
 =?utf-8?B?d1lNay81UG9ud2U5dXZZTDZKTTBwek96cGd5RUgxZVhCYVFSaHliWjVKWk9V?=
 =?utf-8?B?SE5kUmtWdnlGbzk1clR3WkxXNHczNG9VeW5TUE9VSG1VYzRUU3VTRjhVaGtW?=
 =?utf-8?B?QUNxMTIxTEpvS2w2OGNHWVhOZmErZ0t1dnoraVRmVFZOWjlURERsZTE0Q3pj?=
 =?utf-8?B?TXZnNEpaWmhxY3VFbGpuazJBTlczR1FiMnN6NHpUQ1QxMEU4NEtCdkJEb3Vw?=
 =?utf-8?B?T1o4VThEajN5REVoTTRzRlJmRkpzZ2phSzRmZ0pZR3JUR0ZqakpLM21KRVFI?=
 =?utf-8?B?QWliUVhrajhSb2FJLzFlVUQyQ0kxS3E4eEpYcFZoakNEZVlMUGY3QzNuWmxz?=
 =?utf-8?B?aVl0dlAvZ1lmaXVXS2RUREQxTzcyVFpXMExnZnJKS05MWDQ4Si9aNTAwRFBD?=
 =?utf-8?B?d0pOcVVld2t2VTU4RGsvRXJlN09KQzQwcnBHRHByOVJqaXVFVHdhZjBtNkpD?=
 =?utf-8?B?S3QzcFhoWGZORHZ6Ykp6bVE1RnpDbG0vTnF1c25OVFA4Rm1GVDlJOERuejRL?=
 =?utf-8?B?RG9QNnVGVmhsbzZUSUNFUFBORmlPbDBiTURPQVRnSXZSK0xNVjI4RkhwakZS?=
 =?utf-8?B?K2J6bkRHZUk0OG9mMG1mNTFlVHE3MlltNFN1UGMwZGc1cTIzWGxvYzVCMHlG?=
 =?utf-8?B?YTFLOFI3SEZkYjJBWTg3S3BjNWZkeEhRYitjUEN1ZU1TY1I2UXFtYzBwT2x0?=
 =?utf-8?B?bzM5QjJxK1ZYNkFxZFl6eDFDYlJRSXUwZlVQU0tZU0FJWGp3c0l4MFhZVTJy?=
 =?utf-8?B?WWxWaGRyK1hoSTUwZVJxelBXc2tEYjlwaVNnNUNnN2tzc1RaMEM1L245c041?=
 =?utf-8?B?ckVVN1ZuV2Ntd0dsbzUxR0tZVnRRTW1wdmd4dUU1VHZYY3RzZ2RSQy9YL1cv?=
 =?utf-8?B?UnNKRXNHUXZWeGZXWjZoQms5R1Y2cGU0L2Y0Nnl5TnVKTWFoTzNORHRONllK?=
 =?utf-8?B?UE40RkI2QVlxdTBWWWo5YXMwMWtnWXcyd3BCR25uQ3ZHWWJTS3lnS3hvOHNh?=
 =?utf-8?B?OVZCUUFnVXZTZGpxZktxWUtuRzB2bHd1V1FkQitsZEZLeEEzWElXZmlEc1VX?=
 =?utf-8?B?WElXK1RPODF2WUk5ZWlvQ0RHcUJoRndTbE9tenV1UG5kNUU0cFFJMGxlRWtH?=
 =?utf-8?B?ZFJReEFjL0RtRUVITGtZYTl1WjFISG84Qm50MllGYXNCQzR2YTNGLzFIUlNV?=
 =?utf-8?B?OHE2WFl1cTlxa0JJbm1SMnh5b25sU3I4RzA0RzViS1dOS1pHSG9FS1B5YnhU?=
 =?utf-8?B?a3RRY0o1SGU0TzJ0Vis3NU5pWUZaNEp1V3hxRjlIRXlnUE9qSUQ3c1V3NndS?=
 =?utf-8?B?V0NvMEorY2YzRnJkTGZRQ2ltUU9LdktidXBSTWZDYXBNTEdidDk4TFZaZk14?=
 =?utf-8?Q?00ZxKT8NC6LZnxcjGeVPUcfLx6y3N6m9Sj+uslI?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9c0417cc-9000-4885-c66d-08d98d621352
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2021 09:24:22.1018
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 7n0cfP9kIOzckP3KRsYeqcEJhFKMaBJ+HExqRm6rdotprUQ5tpTjysnCKUOeGGWg4m5PTGrQAySj/ZLP4yc00Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7150

On 11.10.2021 19:48, Oleksandr Tyshchenko wrote:
> --- a/xen/include/public/domctl.h
> +++ b/xen/include/public/domctl.h
> @@ -38,7 +38,7 @@
>  #include "hvm/save.h"
>  #include "memory.h"
>  
> -#define XEN_DOMCTL_INTERFACE_VERSION 0x00000014
> +#define XEN_DOMCTL_INTERFACE_VERSION 0x00000015

So this bump would not have been needed if the rule of making padding
fields explicit in the public interface had been followed by earlier
changes, as you could have fit the 8-bit field in the 16-bit gap
after domid.

Furthermore this bump is only going to be necessary if your patch
doesn't make 4.16. 4.15 uses 0x13 here, i.e. a bump has already
occurred in this release cycle.

Otoh, because of the re-use of the struct in a sysctl, you do need
to bump XEN_SYSCTL_INTERFACE_VERSION here (unless you fit the new
field in the existing padding slot, which for the sysctl has been
guaranteed to be zero; see also below).

> @@ -150,6 +150,7 @@ struct xen_domctl_getdomaininfo {
>      uint32_t ssidref;
>      xen_domain_handle_t handle;
>      uint32_t cpupool;
> +    uint8_t gpaddr_bits; /* Guest physical address space size. */
>      struct xen_arch_domainconfig arch_config;

On the basis of the above, please add uint8_t pad[3] (or perhaps
better pad[7] to be independent of the present
alignof(struct xen_arch_domainconfig) == 4) and make sure the
array will always be zero-filled, such that the padding space can
subsequently be assigned a purpose without needing to bump the
interface version(s) again.

Right now the sysctl caller of getdomaininfo() clears the full
structure (albeit only once, so stale / inapplicable data might get
reported for higher numbered domains if any field was filled only
in certain cases), while the domctl one doesn't. Maybe it would be
best looking forward if the domctl path also cleared the full buffer
up front, or if the clearing was moved into the function. (In the
latter case some writes of zeros into the struct could be eliminated
in return.)

Perhaps, once properly first zero-filling the struct in all cases,
the padding field near the start should also be made explicit,
clarifying visually that it is an option to use the space there for
something that makes sense to live early in the struct (i.e. I
wouldn't necessarily recommend putting there the new field you add,
albeit - as mentioned near the top - that's certainly an option).

Jan



From xen-devel-bounces@lists.xenproject.org Tue Oct 12 09:26:43 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 09:26:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.206976.362676 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maE3W-0006Mu-GC; Tue, 12 Oct 2021 09:26:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 206976.362676; Tue, 12 Oct 2021 09:26:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maE3W-0006Mn-Ch; Tue, 12 Oct 2021 09:26:42 +0000
Received: by outflank-mailman (input) for mailman id 206976;
 Tue, 12 Oct 2021 09:26:41 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=/4YK=PA=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1maE3V-0006Mf-1s
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 09:26:41 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 6cd8cc66-edd3-4238-bc5f-abb866dfa310;
 Tue, 12 Oct 2021 09:26:40 +0000 (UTC)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2054.outbound.protection.outlook.com [104.47.12.54]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-20-WF0At2RGO7edNOEFeJJlBA-1; Tue, 12 Oct 2021 11:26:38 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB6174.eurprd04.prod.outlook.com (2603:10a6:803:fa::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.22; Tue, 12 Oct
 2021 09:26:37 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4587.026; Tue, 12 Oct 2021
 09:26:36 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6P191CA0092.EURP191.PROD.OUTLOOK.COM (2603:10a6:209:8a::33) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4587.18 via Frontend Transport; Tue, 12 Oct 2021 09:26:36 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6cd8cc66-edd3-4238-bc5f-abb866dfa310
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634030799;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=ZfgbzRb7yA4XjUtaUAf4Abv7ClKyEgs3Gf8y/3mHnz8=;
	b=iqS6Q6oJjLZNhg1gHOTakqTMfOZCwXueUK2dhkuNjD9/TkudrxlHxj6DjpDlLnwA+Kj5j5
	AwiH5OT7Ro3tC+uT6HtvxEnfN+i0+QrP3OJQPpNJzFFoxztnl1UDILZYsw9HKtnwZzKDJd
	PPufb5tVBL0txQB4k13qc8whxKSxAcw=
X-MC-Unique: WF0At2RGO7edNOEFeJJlBA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=F/TtfJs983dTU5Vzn3GuiVYpY38mHuqzjb+qs7XJ+HhVE/RRL/TtLo8mYw+zanByqGe0ca4z2GdLnYeua3P/smMvWDszCu61s1DP9JNbS3/moftrTV8SstC317iOHkOI/zbfB5XarJ7CVSIP7X/gp0WNG2RFsfkKl5GCgPFe56YkmMXv1cusqaAVnE0dtvrOnAB3UheOB5YRts1t2yLsr/bDU5O1XwRKa1QO8OiFqTqmstSQHMsbabT2VVSGNQnXT7HXeIz2SOntNKt2SccNiEJc6b5W5qWp9wzzFKOUAWVqx7VW1bJ6uZam0/FBnonqlbd6yyqzyhUKVf1wLrmKJg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ZfgbzRb7yA4XjUtaUAf4Abv7ClKyEgs3Gf8y/3mHnz8=;
 b=DfdoUZZ8lJ78lJyGjvgCxZQJ3zQJKWODDzkgeY9iEJiNhqe9LQOUtHa5YfUI+xb/yP9leA7t+jlicMfVjUI2bVTQvQEG1CrHyG0/Gtw+g0J2+vLfNh/w8aNlS7QB0XA7ABeikKp5BgCUaE01JXVpzPJg0uoqXqVYchm40sRxKTVJDWR+TnU2AhWQLQ+E0L1kM7QenpMlxYR0d5xALjZlywSut12NS3PoOOF3539YSD5bSF7pJj4qkAjOkYq5xihJj5n/5FdoXKy9LSzrIxbLgVw6GvLrGyPwZPA9FtB8k/d2AKuIh4rxTuDhZCmkO+NWDv1ZN9eFqqDDkAeFqjhMNA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [PATCH] x86/pv: Split pv_hypercall() in two
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Xen-devel <xen-devel@lists.xenproject.org>
References: <20211011180541.24501-1-andrew.cooper3@citrix.com>
 <20211011180541.24501-2-andrew.cooper3@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <cfc8940b-81bf-58ae-8c3d-d9f3a5d662db@suse.com>
Date: Tue, 12 Oct 2021 11:26:35 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <20211011180541.24501-2-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P191CA0092.EURP191.PROD.OUTLOOK.COM
 (2603:10a6:209:8a::33) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 24e5447d-9d4c-4644-898c-08d98d6263a8
X-MS-TrafficTypeDiagnostic: VI1PR04MB6174:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB6174DCFA6E03FF9D7E2250D7B3B69@VI1PR04MB6174.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	KkBAj/SCcUp3j9Ba7c8cUTiBYSNJHmOA78iGyd2w6XkUjYuZNUCo86zGv7Zt9Wr/1w4QGXV+GPu9Y/gIJMGNKRfc8Yn16qDy+qEb1pEuvz1FG/m4GUuqepxdLOqZlb+fl0Ya6QtQejQg+SpbZRHlD+tBjXc2w4IlGV+wsrqXebc1bWpu+yZVkdy1l3v/6IyU4ngVBsCbbsevWnx/E4znJgFUwXZNYTVNOw2vjn41pLMJV0BKq3n+9u8K2FdElATEmDns8PAZx523+pKhFDpz1K69YW6POs67XzhMGvnar3nq5TqpIYRNgFQ08asn5rsYyBeXSuX0hVitN4dK2M+BhuRMrMPCUYr4ezKduQ0ioDgnvO5QX/egSUrdGFqmTmv2uH32FZTf7PHyo7MTt0hZmgpT+OGfOo1KXjoQFdBG/9zIuaafmIYdw0/Ek6OjaP02K3RBICqZHfcgWk5M49mvbVwBo0wU/pHvr71qLw2wpXn8qPmTB7ADu9Vg97hXRsb/AkZPO8BIfOtNaQA7wtSnrj/iPncTLfGbUNxsMOn8EQrzvj6fA2QvLmh3pHBa8pueKJNgjwNojqeKFH4v4Mf47jpjd47OLuBoRKO+nCB7VXTH+2xguhInSe295mGTuowOePCN+rE4IAvb4sRI6+/6Cg/cvF81y3WFxunUPbGRaXOZordH2arK4im6XNrAc41J3yXjiuGgn7gNyjqdRSzAPrs7xVppAK3nLPGrQH6sN9Q=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(53546011)(8936002)(6486002)(36756003)(4326008)(5660300002)(186003)(26005)(31686004)(54906003)(508600001)(66556008)(66476007)(2906002)(66946007)(16576012)(6916009)(316002)(38100700002)(2616005)(8676002)(956004)(31696002)(86362001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?NzNweU9NZ3d6ZjVUaENRa25UcGN5K0UyVlZhOVJ5SmRMVy90OXVseWVjSGlz?=
 =?utf-8?B?RUxqZE1RR1BFMU4rb2NuMitHZi94eVlmSVk4UWR4V0xPQXZmWmFpRHRPOVVt?=
 =?utf-8?B?M0dLMysxUUZtOFdHMkhjeHBQK2N2M1FUTEZ5cC9ZZ1Y3NTNMOVh5YXN6MlZo?=
 =?utf-8?B?ZEc4VTlSMUZwb3QzRG1KWU9iMGx2ZTZQMVlYL1dXaVU3Z1FGRWJZVWpYZmt6?=
 =?utf-8?B?aklEaXBnay9LTFV6dUg2QS9EUk9kZzBkWDFVallscmwyS2ZydVpVRmQ0aTNz?=
 =?utf-8?B?dlZRMUJyRGd3andPZCtoQTVNbGYveEtBWlRZNXoxN285dTZiS0FXNDVkUm5N?=
 =?utf-8?B?dzVsTTExQTA4YklSQVUwVTdZZm1vQjBwcDVsYW5LQk1qUkV5QTRHdGhxTmtT?=
 =?utf-8?B?TTMxei9oZWJlcGtVYlFHc1dNSVpRd0pUY1phT1BvTkR1VVMvcU15RDE4ZTRk?=
 =?utf-8?B?SmY2cGNzd0hPYUFNaVdiTHI2RGFKeHI4dDdQazZGaVRIV0ZDUVVETUZWbDF1?=
 =?utf-8?B?VHk4YmwveHVJWm8vR2ZzbVZUTk12RlpKMGtGN3lPaWpWTEE2TWJIdEVSb0xK?=
 =?utf-8?B?VXFPZHVmSk0xanNTbWFFaVFJcmlGeW0zZWNjVU0zaWVqdVJNa0ZuaGROUmZK?=
 =?utf-8?B?MncvWUU3S2dNQlFFNDdOeGFSMnZMUWFUZnJoZWR6R3JvWW4vTnFSd1FkeSsy?=
 =?utf-8?B?aEVwVUdFQ0NKSGo3RzhDR0dzam43cE1ZRjJ4bFhudzBaYk5DYlAvSWl4NzZt?=
 =?utf-8?B?OXhEaVFGNmZlVmV3OTdsZkxYME54aVpRY1JyOXpQVkhyNkpWWm9lalZsRkxX?=
 =?utf-8?B?RlJTNSt2QXBiVUFFV1J3Tm5wZ0s1QUFGZG10TlNOR1lLTWhHMnBPdDFkdmRj?=
 =?utf-8?B?blVYaG4yRmdTTE8wbFAxQ2o5MkU4QWkyVUgvSENNam84Y2dMQUtLSVZ5Ym9o?=
 =?utf-8?B?NWx2NnU1SnlXWjZXL05zQW9LaEU3czI2eFdVeU8yT1NrQ3lidmhyMjVRNTZ0?=
 =?utf-8?B?Sko2UUVoOE1kaHp0VHhjVDFMN2dGd0gvdFlZQ0c1ZnJDaVdOSnJtLzVqU3ZW?=
 =?utf-8?B?cGlRYVl4cGlHNDc4a1l4M0F6WmVRVTFjc0FFMFUreXBTOE1BTm1YREttZ28v?=
 =?utf-8?B?L3J4TnNrR2JzRTFvSTc4QTlDdXVURHNBNVRJakFhMnN1UHZ1bENtKzYybHdP?=
 =?utf-8?B?aVpwbWlwSHhvM0tnMmlNeGlOVm5lcnM5ekRUZVBzVWs4R0RMSlpXL28yWkFz?=
 =?utf-8?B?VU1JS0gxYm5yMHc3MkZkRHNGKzAzQUtta1ovUW1UVldORjYvbDJVVlJKTXNL?=
 =?utf-8?B?SHh6WDh0R2d6QmtpQWlISWtiN0lLM1hGdWRHMmZYTHJud0plcHZrVzNwbFpq?=
 =?utf-8?B?WVliOEdVN3BuSTY1enQ3RVhGUWdpd1lZbXZRRk1DQjhJbnVPYUgxUHdlMzdF?=
 =?utf-8?B?Qnh1YjJiSUdBQ2p5YkFSMTE1dzNvS2MyTTd1UzNja3FRSEViSW96ajNSNmd1?=
 =?utf-8?B?d3Y0TmlaVmVsMVF4QjRHR3hKV1RncndiTXVHVVdmaURUVmpyQkpBck56OWZQ?=
 =?utf-8?B?QmtIR1ZIYy82QVRZZkl2eWVrRzlLTnNHWmtXSU83L0pmZG9TOGxPYXRqWFVy?=
 =?utf-8?B?WXhXWTczYWJLSnhEek9MRDJKMmtIcmVQTVg2ZngwRFdZejJ2NXdaYnYybWww?=
 =?utf-8?B?ZDJ3MHRuSzdhdzFKM0JuWDNLeWxpYkNYSTErSXlFaXdKQU5hNkZoSmF1RE94?=
 =?utf-8?Q?afcmq6H6lBX+bSKiUSM0Pe1NFImuVMnITGnxGhX?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 24e5447d-9d4c-4644-898c-08d98d6263a8
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2021 09:26:36.8626
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: k1sRRMVqticOnZ/FQ9rqdeCXwC6q0VRzW0U73ad11NNpGM3o8iBKpoBO8w6nKp8sCL+INETKsf5Y6OfkuSCIsw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6174

On 11.10.2021 20:05, Andrew Cooper wrote:
> The is_pv_32bit_vcpu() conditionals hide four lfences, with two taken on any
> individual path through the function.  There is very little code common
> between compat and native, and context-dependent conditionals predict very
> badly for a period of time after context switch.
> 
> Move do_entry_int82() from pv/traps.c into pv/hypercall.c, allowing
> _pv_hypercall() to be static and forced inline.  The delta is:
> 
>   add/remove: 0/0 grow/shrink: 1/1 up/down: 300/-282 (18)
>   Function                                     old     new   delta
>   do_entry_int82                                50     350    +300
>   pv_hypercall                                 579     297    -282
> 
> which is tiny, but the perf implications are large:
> 
>   Guest | Naples | Milan  | SKX    | CFL-R  |
>   ------+--------+--------+--------+--------+
>   pv64  |  17.4% |  15.5% |   2.6% |   4.5% |
>   pv32  |   1.9% |  10.9% |   1.4% |   2.5% |
> 
> These are percentage improvements in raw TSC detlas for a xen_version
> hypercall, with obvious outliers excluded.  Therefore, it is an idealised best
> case improvement.
> 
> The pv64 path uses `syscall`, while the pv32 path uses `int $0x82` so
> necessarily has higher overhead.  Therefore, dropping the lfences is less over
> an overall improvement.
> 
> I don't know why the Naples pv32 improvement is so small, but I've double
> checked the numbers and they're correct.  There's something we're doing which
> is a large overhead in the pipeline.
> 
> On the Intel side, both systems are writing to MSR_SPEC_CTRL on
> entry/exit (SKX using the retrofitted microcode implementation, CFL-R using
> the hardware implementation), while SKX is suffering further from XPTI for
> Meltdown protection.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Reviewed-by: Jan Beulich <jbeulich@suse.com>



From xen-devel-bounces@lists.xenproject.org Tue Oct 12 09:32:24 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 09:32:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.206985.362687 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maE8y-0007qY-7R; Tue, 12 Oct 2021 09:32:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 206985.362687; Tue, 12 Oct 2021 09:32:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maE8y-0007qR-4W; Tue, 12 Oct 2021 09:32:20 +0000
Received: by outflank-mailman (input) for mailman id 206985;
 Tue, 12 Oct 2021 09:32:19 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=/4YK=PA=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1maE8x-0007qL-6D
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 09:32:19 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 4a3f40d8-2b3f-11ec-811d-12813bfff9fa;
 Tue, 12 Oct 2021 09:32:17 +0000 (UTC)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2112.outbound.protection.outlook.com [104.47.17.112])
 (Using TLS) by relay.mimecast.com with ESMTP id
 de-mta-32-B6IKL9ulMh-ep-neVQWUHg-1; Tue, 12 Oct 2021 11:32:15 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB6174.eurprd04.prod.outlook.com (2603:10a6:803:fa::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.22; Tue, 12 Oct
 2021 09:32:14 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4587.026; Tue, 12 Oct 2021
 09:32:14 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6P191CA0019.EURP191.PROD.OUTLOOK.COM (2603:10a6:209:8b::32) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4587.24 via Frontend Transport; Tue, 12 Oct 2021 09:32:13 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4a3f40d8-2b3f-11ec-811d-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634031136;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=WxUYejhFFr4hBbGUrgNeoZxFCqMl2FOkZil4sMYsVEs=;
	b=X0kRJpOPJHFhs9lm0SPOIIAhl3G0LTQE7suyV3/Om94G42+AWBma6qSpn5aUDmAkvMxfP4
	K4D6B8MbrNgLnNo+pL/9nv4szxN5t4p8Hy5GzKEY4RQF444grcXF6j0pK76n9zaZ7PKiEa
	aR4Xf4EWA0ksSzuazZ8whdZBJS+loh4=
X-MC-Unique: B6IKL9ulMh-ep-neVQWUHg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=TqG2KDlIA8x3e6SbDjfNXKLEE8GxlA+3BosiRivCrWQwHf1kZrLE4pGJ+10M8KdmLjbaBQkrNcb7QPIn6IcLndRR3oVJd7KywRHeHf30T6TnYHG6GcvXWGoetDpVoZ9M0nL7NgW0+8/FEDOG1+DDmo/fY54HcdT//XvRO+vc0LaLavgos3XqRF4H3GeVeHsPaVL8WMwmprQ3x3rlFrWgFth9jV/PQIau71h7pXJc1NBh3Mh/XT7z7oBV77Jqm7dDKsOLBOQ1L7CiwJSFDRc8Q0yAwlhpS8hA9AvsLOKlUmz5vvZxy+2iaH2cRe5KHziJXNdSJbprcktC83sjwd6R/w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=gDaryNORZQ99VMa9lIXzCL05ed6AFy1YIHp50Rl0NkU=;
 b=Bc7sn50viJ3Wyjf44jeqeByQp2RI2CsbtqkDz1zaysaE6Kd+AvEvOITQlhXSWpVPx8ODSlaJ1vDSFXJBUXMhqyrwv4lgkKEH3q8CWAkQmbXrbeIC7oKOZAgDlUE74uJcztd+OJ8WfwqKOt8FzRpDOluPGveWwxMZU35AMmkmvnXMuFTP9dszzPcq/+i5PGMQvbBHAZR9bmXJgIrQme9z0lHU95Hyg1XSSA+SuczAFVaGUf5LcFhQ+qYDdk1lgf0xlPNHgFSgaLmU+xdDBU/u6Ox+SGBxaSYhD/WBwy3E3TRa2/PBaFkHH5mdEQjvBNs/C9ef+1Fd80gmWDiwPUCP0Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: citrix.com; dkim=none (message not signed)
 header.d=none;citrix.com; dmarc=none action=none header.from=suse.com;
Subject: Re: [PATCH v5 01/11] xen/arm: xc_domain_ioport_permission(..) not
 supported on ARM.
To: Bertrand Marquis <Bertrand.Marquis@arm.com>
CC: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>,
 Rahul Singh <Rahul.Singh@arm.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andre Przywara <Andre.Przywara@arm.com>, Ian Jackson <iwj@xenproject.org>,
 Wei Liu <wl@xen.org>, Juergen Gross <jgross@suse.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <cover.1633540842.git.rahul.singh@arm.com>
 <d292392268df2c74c4103a82ef917072643407a8.1633540842.git.rahul.singh@arm.com>
 <YWQkblfNMYEs6jI9@MacBook-Air-de-Roger.local>
 <77CF7FA5-C566-469E-B4A8-0400789890BB@arm.com>
 <YWQ6Nk3Jk+BqgkwZ@MacBook-Air-de-Roger.local>
 <53AE6E2A-01D7-41EC-9B2C-C0D596EB8D4D@arm.com>
 <YWRCxXGQIyTOAepC@MacBook-Air-de-Roger.local>
 <FEF0B03A-5AC8-4F8D-B821-191AC2EF8295@arm.com>
 <YWRnMfAi808TQ4Gt@MacBook-Air-de-Roger.local>
 <EB1CB53B-9D5A-49C5-A687-841BF94A153F@arm.com>
 <ac6d4785-ac9a-4491-26bb-c66ffe82c55b@suse.com>
 <ED8FC92F-B5EF-4473-B4A9-641C7D44859F@arm.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <0744b957-1832-dff2-9ae2-b8e8534f501b@suse.com>
Date: Tue, 12 Oct 2021 11:32:11 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <ED8FC92F-B5EF-4473-B4A9-641C7D44859F@arm.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6P191CA0019.EURP191.PROD.OUTLOOK.COM
 (2603:10a6:209:8b::32) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 8cb2c9e5-a8f5-441b-f564-08d98d632c85
X-MS-TrafficTypeDiagnostic: VI1PR04MB6174:
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB617421FD1B1B024A1B8ACF3BB3B69@VI1PR04MB6174.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	QKI080VSScWtsJGVTeATtgJOpwAnO+HvFwtDTblcv35c72TQFzOg6pUwA58GZbK231mleY2ZGMHtqu38AvJ+B9Vs6cTi40IhVfscKdm7TFBVK4G9h4QaJh7aCJ79C4+nh5yRYvJuh0dPsZeNJeg6JfBPgolZVpZx5rpFyGU9OA8KI1T8/bYEJ5iyPNWtA3sdC9KhCY+CgJs3azoQaNocvm/sN5tRU1kBWNkz87RjKITczzZ+iXXo/zZiFPxW0/OmnxmKP/p68Ob/akK0BRJZAO9hE78fvi6CDrBMlIN1mJtquZ1Gme1jI+eDewgGXMb6P+8th50DBCBQe5QcfYn6E+i3k3Ho5E18/VKR59gE9/uMO8DKPqwOKADSf6UFLj3a5zGD52jBhddj0EYIDIJ2qM+D5/iP0iWBAtPfm9mP3gnqUmfpCZJB6i4pwG6sgol0bdwOfqD8WkZxF7YtNKb09reiJMpSIGYu5wFs+L62np/tnNQF957Jgz1LE6CfAbZ2gzsFi6EWbXPcILlwCP5Fkw5u1kCoSaQ1vSo7a/xVy/SEy/6TtU4TkyEo37TEHcWneND50gnOUYndx2B5jBbNmoDplWeIeHmPH90v10ldzi0az8OPCd0SeYyE4Xy6QGTCh79/IjjKB6zVyjvbiiKA8OakmZZouKjMsK9aKI5nSbrKHgVvLWHQw/Q0ZsJ8v/H7B3JpMs7bBlrcg+7UkexyeA1ea36tL8cSfpMPe7cUU3JZiIK43R3BOrNdARgsDCp7
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(53546011)(8936002)(83380400001)(6486002)(36756003)(4326008)(5660300002)(186003)(26005)(31686004)(54906003)(508600001)(66556008)(66476007)(2906002)(66946007)(16576012)(6916009)(316002)(38100700002)(2616005)(8676002)(956004)(31696002)(86362001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?FlAxs33G2XRnzFiW5UwCnezDI9dzXm7yTBUTkJhmONTJRO5ZrFAPuB6f4iGj?=
 =?us-ascii?Q?Gb4Jf6PpSV8Q74JIVrFRS6kOtk+xOsg1S/oTakcbenLi+q13+SbfaX6RTDkf?=
 =?us-ascii?Q?AHO8K4citaX5NoQdrfydHzP+7sz3m+KtL6Tnvx/eyNawyHyFQWoOG5Se3953?=
 =?us-ascii?Q?CntzHFXU0+FmQdjY/7YtJNUQ4P600IW61W2hGlX2gfSgGwtUJnXIt4OaKi3z?=
 =?us-ascii?Q?CpzvELXPr3dNlIP5bZFbYGv0/PUVh++hqevjzA89vF3Bc+0Z7pZ1rFHQDIQU?=
 =?us-ascii?Q?xxvwWj9mKEQnLSytBZi4t3qneM331HesaKhhaIl3ibtkOo5xZLQHeSz9OFgA?=
 =?us-ascii?Q?txVmmhsCHxzqCaqvixVAcymbvwXveCK9nZxA9gnecWzj90WGcTU2on1Gw0/X?=
 =?us-ascii?Q?OOwppaxnFdnv5nR+el1xt0xaaDW1wGvMbpvIfS8Q59Xrpz+BgOBPu6XHe09K?=
 =?us-ascii?Q?j0Rk/bs6rI952F+hephtvCO7lb8w3E5J9ZL37J5szyoYLzZB+AbbZxOpqupy?=
 =?us-ascii?Q?37TOYHsIZ7+aGfwQJUHXkZu4Io9uJsc32T9xfEes5ZjIE+jMd99AN1q6j441?=
 =?us-ascii?Q?Af1td6qH5gJSVoY234XUuVBglLR2BqufnQ+FJ373A0BUlsZzRGvIlVHeiLSH?=
 =?us-ascii?Q?BkNoUaB/jXrIi/ruu9kvTC+hH5mfSHc9DXP1dL3feEJMbBoSIrl3GhwuriV1?=
 =?us-ascii?Q?fMypVBnDI7jetCXTx+i2rBDFdeU77uYncJfABzmOTnt5HcBAhyZoo1y4DIip?=
 =?us-ascii?Q?KNmi4UJD7DsbfeSpBvYCDo19D2DSnmHwX7ZmKw6rxElNLan9Pvk7AMtGyzqc?=
 =?us-ascii?Q?g4UnaNxgYfW2f0jtZs7aTheGzMQ8jpdx42562pgkfsDE5iRk182A6UNqT/u0?=
 =?us-ascii?Q?hDTY7vbyo/qk8qrG+lLvaWaDrMuIZVifxtMNHotbcFd61Wjj0V13dsSQVjDh?=
 =?us-ascii?Q?FU4s6JL3Y1eh4BtA2W9vJnRfQ0fSoCyuDNCiiIqpwH9PdP+5M7x9GHG3/yG0?=
 =?us-ascii?Q?Up4UDKppIkcL3NHM+rAmJYZ9g46h2OGapzsxvCCKTtKi/4TXugCiC/RNwUlc?=
 =?us-ascii?Q?vrtkmkhUVC4PVQ3AAzEvEpqRE6X6EYqxu+4NZibvCCKERd7Gm1DfKBRUr1pj?=
 =?us-ascii?Q?eonjbcaeS2tIjg7hxnazrBQj/QnaiIeSEbufypvrSrqPiXQHoLUfzURm2kOT?=
 =?us-ascii?Q?RfCRp5AhoYY774ix7ULQC1g8yOerX9dfTryCCnXYZ9sOE/BxJF02Mfc2puqm?=
 =?us-ascii?Q?FsVBlbDGEEQen75NLiGeoP8tTisBQjUEcDWWCc/ocro97JU9TI2QmHb/YWkr?=
 =?us-ascii?Q?AArivnZkYuyIdmwPi4QKzltQ?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8cb2c9e5-a8f5-441b-f564-08d98d632c85
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2021 09:32:13.9110
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: mMVgBm48g5mcys6V/AMc4tjYtlsXUEqlZFk3F2ojpxgVSZDM9Zx1ZEEfv+JjAGoixLG09OVmgmP0dGKWzFWo6A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6174

On 12.10.2021 10:41, Bertrand Marquis wrote:
> Hi Jan,
>=20
>> On 12 Oct 2021, at 09:29, Jan Beulich <jbeulich@suse.com> wrote:
>>
>> On 11.10.2021 19:11, Bertrand Marquis wrote:
>>>> On 11 Oct 2021, at 17:32, Roger Pau Monn=C3=A9 <roger.pau@citrix.com> =
wrote:
>>>> On Mon, Oct 11, 2021 at 02:16:19PM +0000, Bertrand Marquis wrote:
>>>>>> On 11 Oct 2021, at 14:57, Roger Pau Monn=C3=A9 <roger.pau@citrix.com=
> wrote:
>>>>>> I think the commit message needs to at least be expanded in order to
>>>>>> contain the information provided here. It might also be helpful to
>>>>>> figure out whether we would have to handle IO port accesses in the
>>>>>> future on Arm, or if it's fine to just ignore them.
>>>>>
>>>>> All our investigations and tests have been done without supporting it
>>>>> without any issues so this is not a critical feature (most devices ca=
n
>>>>> be operated without using the I/O ports).
>>>>
>>>> IMO we should let the users know they attempted to use a device with
>>>> BARs in the IO space, and that those BARs won't be accessible which
>>>> could make the device not function as expected.
>>>>
>>>> Do you think it would be reasonable to attempt the hypercall on Arm
>>>> also, and in case of error (on Arm) just print a warning message and
>>>> continue operations as normal?
>>>
>>> I think this would lead to a warning printed on lots of devices where i=
n
>>> fact there would be no issues.
>>>
>>> If this is an issue for a device driver because it cannot operate witho=
ut
>>> I/O ports, this will be raised by the driver inside the guest.
>>
>> On what basis would the driver complain? The kernel might know of
>> the MMIO equivalent for ports, and hence might allow the driver
>> to properly obtain whatever is needed to later access the ports.
>> Just that the port accesses then wouldn't work (possibly crashing
>> the guest, or making it otherwise misbehave).
>=20
> As ECAM and Arm does not support I/O ports, a driver requesting access
> to them would get an error back.
> So in practice it is not possible to try to access the ioports as there i=
s no
> way on arm to use them (no instructions).
>=20
> A driver could misbehave by ignoring the fact that ioports are not there =
but
> I am not quite sure how we could solve that as it would be a bug in the d=
river.

The minimal thing I'd suggest (or maybe you're doing this already)
would be to expose such BARs to the guest as r/o zero, rather than
letting their port nature "shine through".

Jan



From xen-devel-bounces@lists.xenproject.org Tue Oct 12 09:32:35 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 09:32:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.206987.362697 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maE9D-0008E7-Fn; Tue, 12 Oct 2021 09:32:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 206987.362697; Tue, 12 Oct 2021 09:32:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maE9D-0008E0-Cj; Tue, 12 Oct 2021 09:32:35 +0000
Received: by outflank-mailman (input) for mailman id 206987;
 Tue, 12 Oct 2021 09:32:34 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1maE9C-0008Dg-AK
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 09:32:34 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1maE9A-0005sf-ME; Tue, 12 Oct 2021 09:32:32 +0000
Received: from 54-240-197-233.amazon.com ([54.240.197.233] helo=[192.168.23.5])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1maE9A-0002fl-F7; Tue, 12 Oct 2021 09:32:32 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=AQv7zd/uUui1VPwcYJpZu5xIJ2rSSFd97v5wRlbSECM=; b=ib5iGHE/7Y3+ssDNApZ6RooVRJ
	WDJnHvpygXWuuNEeqV4fkZ86/AqWUJvoDwM1w4Qj1kr0MGj3fA2FBCfLlw8xoZKTSRGQxS2vaPnYx
	CYKlqu57u/c+ly08lEBP63ZdGotxCpxgh6Nua/hNpSKkmoIPgDd/LjFGKXT6NN7VEnG8=;
Message-ID: <1609e9a0-99d4-955c-1d12-477f25797bb7@xen.org>
Date: Tue, 12 Oct 2021 10:32:29 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.2.0
Subject: Re: [PATCH v6 2/2] arm/efi: load dom0 modules from DT using UEFI
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: Luca Fancellu <luca.fancellu@arm.com>, xen-devel@lists.xenproject.org,
 Bertrand Marquis <bertrand.marquis@arm.com>, wei.chen@arm.com,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Jan Beulich <jbeulich@suse.com>, Wei Liu <wl@xen.org>
References: <20211011181528.17367-1-luca.fancellu@arm.com>
 <20211011181528.17367-3-luca.fancellu@arm.com>
 <alpine.DEB.2.21.2110111243290.25528@sstabellini-ThinkPad-T480s>
 <EC7165F9-09CE-4001-93ED-FA637F5ED36C@arm.com>
 <alpine.DEB.2.21.2110111415350.25528@sstabellini-ThinkPad-T480s>
 <alpine.DEB.2.21.2110111423310.25528@sstabellini-ThinkPad-T480s>
 <29cc47f2-4727-0397-db0c-a6c1f5a52bf7@xen.org>
 <alpine.DEB.2.21.2110111813510.25528@sstabellini-ThinkPad-T480s>
From: Julien Grall <julien@xen.org>
In-Reply-To: <alpine.DEB.2.21.2110111813510.25528@sstabellini-ThinkPad-T480s>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Stefano,

On 12/10/2021 02:31, Stefano Stabellini wrote:
> On Mon, 11 Oct 2021, Julien Grall wrote:
>> Hi Stefano,
>>
>> On 11/10/2021 22:24, Stefano Stabellini wrote:
>>>> diff --git a/xen/arch/arm/efi/efi-boot.h b/xen/arch/arm/efi/efi-boot.h
>>>> index 840728d6c0..076b827bdd 100644
>>>> --- a/xen/arch/arm/efi/efi-boot.h
>>>> +++ b/xen/arch/arm/efi/efi-boot.h
>>>> @@ -713,10 +713,12 @@ static int __init handle_module_node(EFI_FILE_HANDLE
>>>> dir_handle,
>>>>        char mod_string[24]; /* Placeholder for module@ + a 64-bit number +
>>>> \0 */
>>>>        int uefi_name_len, file_idx, module_compat;
>>>>        module_name *file;
>>>> +    const char *compat_string = is_domu_module ? "multiboot,module" :
>>>> +                                "xen,multiboot-module";
>>>>          /* Check if the node is a multiboot,module otherwise return */
>>>>        module_compat = fdt_node_check_compatible(fdt, module_node_offset,
>>>> -                                              "multiboot,module");
>>>> +                                              compat_string);
>>>>        if ( module_compat < 0 )
>>>>            /* Error while checking the compatible string */
>>>>            return ERROR_CHECK_MODULE_COMPAT;
>>>
>>>
>>> Well... not exactly like this because this would stop a normal
>>> "multiboot,module" dom0 kernel from being recognized.
>>>
>>> So we need for domU: only "multiboot,module"
>>> For Dom0, either "multiboot,module" or "xen,multiboot-module"
>>
>> Looking at the history, xen,multiboot-module has been considered as a legacy
>> binding since before UEFI was introduced. In fact, without this series, I
>> believe, there is limited reasons for the compatible to be present in the DT
>> as you would either use grub (which use the new compatible) or xen.cfg (the
>> stub will create the node).
>>
>> So I would argue that this compatible should not be used in combination with
>> UEFI and therefore we should not handle it. This would make the code simpler
>> :).
> 
> What you suggested is a viable option, however ImageBuilder is still
> using the "xen,multiboot-module" format somehow today (no idea why) and
> we have the following written in docs/misc/arm/device-tree/booting.txt:
> 
> 	Xen 4.4 supported a different set of legacy compatible strings
> 	which remain supported such that systems supporting both 4.4
> 	and later can use a single DTB.
> 
> 	- "xen,multiboot-module" equivalent to "multiboot,module"
> 	- "xen,linux-zimage"     equivalent to "multiboot,kernel"
> 	- "xen,linux-initrd"     equivalent to "multiboot,ramdisk"
> 
> 	For compatibility with Xen 4.4 the more specific "xen,linux-*"
> 	names are non-optional and must be included.
> 
> My preference is to avoid breaking compatibility (even with UEFI
> booting). The way I suggested above is one way to do it.

I understand that from the documentation PoV we claim that the legacy 
bindings is supported in EFI. However, looking at the code, I don't 
think we ever supported them.

Indeed, the function efi_arch_use_config_file() has always only looked 
for nodes contains the compatible "multiboot,module". If there are none 
present, then the stub would require to have a xen.cfg present.

> 
> But I don't feel strongly about this at all, I am fine with ignoring
> "xen,multiboot-module" in the EFI stub.

I think this has always been the case for the past 7 years (or so). This 
leads me to think that nobody ever used UEFI in combination of 
ImageBuilder and therefore I think...

> I can get ImageBuilder fixed
> very quickly (I should do that in any case).

... it is more suitable to fix ImageBuilder over trying to add 
retrospectively a legacy binding in the UEFI stub.

> If we are going to ignore
> "xen,multiboot-module" then we probably want to update the text in
> docs/misc/arm/device-tree/booting.txt also.

I agree the docs probably wants to be updated. Although, I think this 
should happen in a separate patch because this doesn't look a new problem.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Tue Oct 12 09:33:07 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 09:33:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.206996.362709 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maE9j-0000UZ-Ot; Tue, 12 Oct 2021 09:33:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 206996.362709; Tue, 12 Oct 2021 09:33:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maE9j-0000US-Lb; Tue, 12 Oct 2021 09:33:07 +0000
Received: by outflank-mailman (input) for mailman id 206996;
 Tue, 12 Oct 2021 09:33:06 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=/4YK=PA=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1maE9i-0000U4-3z
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 09:33:06 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 66951bfe-2b3f-11ec-811d-12813bfff9fa;
 Tue, 12 Oct 2021 09:33:05 +0000 (UTC)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2059.outbound.protection.outlook.com [104.47.13.59]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-31-_hn4KmnCNYm9L6wx4HPYQg-1; Tue, 12 Oct 2021 11:33:03 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB2958.eurprd04.prod.outlook.com (2603:10a6:802:a::29) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.19; Tue, 12 Oct
 2021 09:33:00 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4587.026; Tue, 12 Oct 2021
 09:33:00 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6P191CA0007.EURP191.PROD.OUTLOOK.COM (2603:10a6:209:8b::20) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.14 via Frontend Transport; Tue, 12 Oct 2021 09:32:59 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 66951bfe-2b3f-11ec-811d-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634031184;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=JlI/HVsUnSbYF2SmiCes7TEgINUyNDX3u3LORnPGhR4=;
	b=FsloSH/QVbZp6gAPD2T0N7Ea9oknkAgAajugXbt0/hshFM3goNRvSCI9x0jwxjemDZiEEO
	AcZbix/Hpme6+ueDnwUECyg9Jb+BmHvOLrjOFIVuIQRJlpJHuRlQ0i4GyelPq+MojMhrdY
	TXF6t40VekXBce6pmezw/nzWSv154Yk=
X-MC-Unique: _hn4KmnCNYm9L6wx4HPYQg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=KNpWD9Ej/mrMsqUYLXq10MNAzlTimq+EI5WOUVNZEcvqRALQv4NGcpcUFfJe1ONlofPAfECPnY6kNq+y4j7ZCi2BRkZBUX76q6r8yDN7rHN4w8ML3KW3meA5dHYfLch0U9E8SL5FJWjv0EUhLY7JPMP5fudl3gD/SMAijZX0Y5cOhKvsy9NXFpVr+qc4gy6XEzPmJeOmSrmRO0BoE2IvXKA2clAMo6MJ2PniVDSXqsJjyPSm/YSMwsFRQ1OyZKKKNOj9q4FN6BMH7n7+lJomUjXMuqbpLWecClc6ucKm/8O5UFbYHOFYj5lbpWsTBkhOtxfLQxXpdT+6+k66JoqBTA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=YlTc4OsIizvgWEywmcw3f300USyHnitFoSeAdgXICXM=;
 b=MltWd9C4ebx8oAWUqXx1XP/K9u2378jpa1ck38xNhsfuzU3iV4mzxA4EyAgvHH/1YQEpQXpAsk+J2H9Wg9kSdXC8kgg3VIAIwgR3Myn1+GG0TI3dih/sBFm9dg/q/m4YlkC2JxN0F10IIEPccI137DLAEM11Un5/bgAqBgL3vV0aaBgxN/c/897/mL5l1cLPP3uujMyeYudqQp+NocVwazlAJGocQKFCfmvmXqgfOO7Ttwk33xVPKCXVTBpFuRSJ/WwtGYXDkk2pQ8Wu2XVn5QyS08ZTl5jAAxd7vA83HsTNlqf9yvWEJnxBuCH3hdsfbaTN7DteudAa0QVC5fHnVg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [PATCH v6 1/2] arm/efi: Use dom0less configuration when using EFI
 boot
To: Luca Fancellu <luca.fancellu@arm.com>
CC: Bertrand Marquis <bertrand.marquis@arm.com>, wei.chen@arm.com,
 Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Wei Liu <wl@xen.org>, xen-devel@lists.xenproject.org
References: <20211011181528.17367-1-luca.fancellu@arm.com>
 <20211011181528.17367-2-luca.fancellu@arm.com>
 <f29c8062-8430-6e08-7d4b-02096a6b049f@suse.com>
 <4FFFB177-883F-44DE-BF7E-53137AA7F0CB@arm.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <0bae71a5-4637-d2a6-ddcc-3497e22470f1@suse.com>
Date: Tue, 12 Oct 2021 11:32:58 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <4FFFB177-883F-44DE-BF7E-53137AA7F0CB@arm.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6P191CA0007.EURP191.PROD.OUTLOOK.COM
 (2603:10a6:209:8b::20) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: ba76ea30-99cc-4dd8-5c67-08d98d634828
X-MS-TrafficTypeDiagnostic: VI1PR04MB2958:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB2958D0A82F395224DC1315E6B3B69@VI1PR04MB2958.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:1186;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	D01znZXJv8i2k3ivH56RCUD7jzAjFjYGL+PZhRIyRPwVqWQ9nL3q2odisFI69pr0GdNk3mks5YCRB7O0XsMkyXn6DAXXWBlkISJVhH9AbMju1NmNsOH/0kwuPfLJa5YE9VVuwKw/2dn04O5O2U3ojq/x5qCthoplDuOQQiQ8qM5Yjcl28cheacFI5i3LjtxBOG+mB+Fds/FE4zIavAuHqrYPe5EX6PkicpsYPkxVuK/9oKc94qG/DLNAC9Pt5HaUDq/N2pelyEwEpKc5dMQtrRrQ6KAVQ3l+2RTccudEWAcfOHYsSKIkZxqXG512S/oIgSGlnlzzM9C7fZmvdTQu7SEWUK6tJlhWMUlYkDlPWGEhAyeOfkAqcuARvlgRuFCxtSDOuU//2+SzHiY46pt55U3UqzfeqXv60WycdAP99QpkMDlE2geqeHJ9Pb96T2ea6LPI7eQOAtuTDnXUqjnqVy/n8QS9Cu7tTCxOx4B/nUibg3MDNr6jbRCHVjBQQW7dfjIkUHeSUyiyowfvPdAuv57pjUmKzoA7l2mafCZNzYZdzbTFQc+UBUl8ZHipreLb5H5brBi7tfNjsy68BMOhgmau1k0guTu2JtGry90Ay0+9s+fdBlPc8iNtomT1eYeQIBq572WfDgr3zOc+pXq7xb3n0s8Jj+Yqitp+xGDEo6k1GWMyJzQS/SVuzc1XF7p9KZVFacABovXA4lYBmJJymHv3GIdBS6/I6zu2m2sgDSZod3nWWKzZHqiAXY8nFpRwphZQaWVTyQe464R46fFelg==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(66476007)(4326008)(36756003)(6916009)(26005)(31686004)(38100700002)(16576012)(54906003)(6486002)(7416002)(5660300002)(8936002)(186003)(4744005)(66556008)(31696002)(316002)(66946007)(8676002)(2616005)(2906002)(956004)(53546011)(86362001)(508600001)(32563001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?JtLOmxohozkzMfnczFVOZcF0yXJuSmfIKMECWgE7nN5bHDDX/DueHpuDkI2z?=
 =?us-ascii?Q?2H9x1tge5yUgCic3Nq1izKf+mmKQSlIzTrjzLmVq0+hlquBmay0NwBYow2Ca?=
 =?us-ascii?Q?/ael/excL5jmz41xZwP4k39COK/3avW6CtSZq7sKgdfj05SFR2pZmRfn60Ts?=
 =?us-ascii?Q?C/BdJ7ToIe5PQ9izBdYdNjqu2q0mqEEYceutNBFbUY/mp01797TAbewMx1YR?=
 =?us-ascii?Q?4aircRetfXvQUNApviiV1r+aHSFQfUFg0R+cjWqUZTYPPeWwRQNLCbIx01eB?=
 =?us-ascii?Q?ZYTxlZSoY5TfvvF0MQqlUNyLEM+J045zFfpl9bEnt6MawDWrcNwC8UPjBY3x?=
 =?us-ascii?Q?la5yNWIyvBL1Cbz2fIscBDwSkFmmy+/5nKZ/wahx7iwocFEc/KStrCFN7iNh?=
 =?us-ascii?Q?GW/N2iUO0FFA/QVW7AdUm+minTaiBJhCoyTXxbxtGXa6QRCc5kzomLi5m7L9?=
 =?us-ascii?Q?0Hxi6tw8diOiY2OvABgkgUwRWHWg/5ZqKW27iPYNGuc8dqZ5bk3DZE0JjPBk?=
 =?us-ascii?Q?IIbJKYdBC8f18zBmkyuOjoEwcRnogQbLOn9zIbAVT3WW/c+CLrqeqJmPNgwe?=
 =?us-ascii?Q?tMc0uJfink01WWZvBRB89Bs291Hs7KrLatUPW/fYYQr98Db6IQLXF6eWRMej?=
 =?us-ascii?Q?7OiTEWcztcGyNdggmdkqkVomQaeUwv6POGur6pEeBQbr0ZCNmfVjonTjD97s?=
 =?us-ascii?Q?tOHWIb4ZofAkGsvTPgOTafxUclxF8Cs+0T7YMf5VnAb55KDhp2kDjwKtYjec?=
 =?us-ascii?Q?ol3zAiISO3jSdn/fzVq3bBHX82cbeOarPbDLLw5OB4BsFwCq0+6ZQzWNzFjz?=
 =?us-ascii?Q?1ELhgqA93U1QImKkFyNxzXrI99WzrGT6yOyEE7JlDNLBNDBqjn3BYVRpq8FA?=
 =?us-ascii?Q?/tqw/oquH/Gwwe40+It9r8u9qNaXkBjBFuXTP6rO+XejDpBAtJ9o+kQOQE7R?=
 =?us-ascii?Q?fP5u1DF0bOd7MhflauWuplyb2ecAgbXLrjhsG4XyRmrjhD4iNERrK+Hakg5j?=
 =?us-ascii?Q?cwT98SQGFMMYJeYKyFAp5n6QOpOULsLeHWfYuaHUspQEGV99kNw+k2eI5vJg?=
 =?us-ascii?Q?1kXZqo3VzRucdqSUUZzRiZx4lGmDz9bWven1nVu8TE5GuN1ZmGaDUu9l8o10?=
 =?us-ascii?Q?UHvcvhQ4uwIXYQ5qRKYvBDG8/woD7UcV0RIBWV9uAhsjNn7h0UTf4TT0Hrtx?=
 =?us-ascii?Q?0lyINs2aRlYoVdCN4WhRbxFPBoncYtf0ZuULswXD/vXAoBDhIGuqJ5G6N5lC?=
 =?us-ascii?Q?ilIkX+bg2kaCwcG7Vq67ZrkurlkdQ+mVBrBEbMnYk8cF6u0XZGbUo/YEyFOn?=
 =?us-ascii?Q?pjWwBzoVsIEy95hityLGzt0P?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ba76ea30-99cc-4dd8-5c67-08d98d634828
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2021 09:33:00.2238
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Pdl6S08b3jeZyfrD4Ae6ExXsffYGrI+fDyZ3OtmyWnzuIJJddpOMRtKdfo+m0e9lk0trSiZhHLg0feyBun+Asw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB2958

On 12.10.2021 11:05, Luca Fancellu wrote:
>> On 12 Oct 2021, at 09:45, Jan Beulich <jbeulich@suse.com> wrote:
>> On 11.10.2021 20:15, Luca Fancellu wrote:
>>> --- a/xen/common/efi/boot.c
>>> +++ b/xen/common/efi/boot.c
>>> @@ -166,6 +166,13 @@ static void __init PrintErr(const CHAR16 *s)
>>>     StdErr->OutputString(StdErr, (CHAR16 *)s );
>>> }
>>>
>>> +#ifndef CONFIG_HAS_DEVICE_TREE
>>> +static inline int __init efi_check_dt_boot(EFI_FILE_HANDLE dir_handle)
>>
>> Didn't we agree that you would drop "inline" from here?
>=20
> Yes we did, really sorry I forgot to drop it, I=E2=80=99ll push another s=
erie, given the inline
> Dropped are you ok with the patch?

Well, yes - I had given my ack for it already.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Oct 12 09:39:16 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 09:39:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.207007.362719 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maEFc-0001Id-Ds; Tue, 12 Oct 2021 09:39:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 207007.362719; Tue, 12 Oct 2021 09:39:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maEFc-0001IW-B0; Tue, 12 Oct 2021 09:39:12 +0000
Received: by outflank-mailman (input) for mailman id 207007;
 Tue, 12 Oct 2021 09:39:10 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=fUjJ=PA=epam.com=prvs=091947bc67=oleksandr_andrushchenko@srs-us1.protection.inumbo.net>)
 id 1maEFa-0001IQ-OO
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 09:39:10 +0000
Received: from mx0a-0039f301.pphosted.com (unknown [148.163.133.242])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id df25a5bf-0985-4a30-b363-006f4abde3b4;
 Tue, 12 Oct 2021 09:39:08 +0000 (UTC)
Received: from pps.filterd (m0174678.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 19C9TMgF024244; 
 Tue, 12 Oct 2021 09:39:04 GMT
Received: from eur04-vi1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2053.outbound.protection.outlook.com [104.47.14.53])
 by mx0a-0039f301.pphosted.com with ESMTP id 3bn7sar2rp-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Tue, 12 Oct 2021 09:39:04 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by AM9PR03MB6769.eurprd03.prod.outlook.com (2603:10a6:20b:284::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.24; Tue, 12 Oct
 2021 09:38:29 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::b034:334a:abf5:223c]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::b034:334a:abf5:223c%7]) with mapi id 15.20.4587.026; Tue, 12 Oct 2021
 09:38:29 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: df25a5bf-0985-4a30-b363-006f4abde3b4
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=a2k2YQlQh44fZjBLVj8/ejiyeDEElNCwFZsti/jFbuCnusa/VXWabGqcTAwL/fYV62+tkHIdYxaWd2FV1N925Dp9xdulmYTkJZFxqWiy5M1g99QslGsiCYFNq+yMVevXL33KYWOxj1tY7bQd7RPlSrv6RIV704z+IH0Gs2nImeuHhM9BiVbXSxkC+oC33RbhIaZWPBz+7jQhWzgjyH+6Ch2ndXycOIN12INPnIB2tCeIvNWhm7JrOdam2KpJxN05WKyzVZB4NqXpfEi2yb+I9GtqFdWb/9F3gkbjD/8zOIihx1sRpzgBxlXPppL+JbWUX+dkv0X86+9HHOZUzCLw4Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Nadob0BJi1S5cYNUrOWwvfMRuGbbvlMx+zTvAkdCFDM=;
 b=WvEtlMLhLD617i/N7ihPMrIY2LTPxrJU2pgZhsUuCjYE49670moiwQKggX7P+4fpLIdV9rxlhdoAVhwtkbFRsX3tNjXIqTyl/y8sdwatAIM0bi+Aj64Kj3f6n/yOEOawjUwzx+IfhrDMW4+pb8CsCWO/ZeE+f2GWyEfg2ct+Fo99LZFMS2JB8ztjp+PlqujkKr85vTcEOOBDENdw3azBTRkO5/Ktjgp3NDtWGTI6XucNBFVd9evhxfo1wL3mnx/v+zKZbLFw4lD29jVQaBp8BvuBjV5dOiaJWHronjaAqM7PgekLw8yy+0J7FUNMvv4tNs1mgfk3X6bHa5P4+3vGow==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Nadob0BJi1S5cYNUrOWwvfMRuGbbvlMx+zTvAkdCFDM=;
 b=uelhjWl1sQzGmsF+TQ2SqUVLTaQqNpE6JTtdRHO9C6yfzqU/JugLrhbjlBZdAvmJL3R6Wapa0jXxLSBRXt8LEnx55EYBozZwfMRn7jsaQNDlV2qpiA/w229vDMXKb/N1K8H5TlFOOSFjnFsIKhED5laO/IGfp0C45iHLCIv+4URSa5Q2C6T0WMWxw7HWqeIq8J09dDhsVuTnkiEEOnnHwxDSYwdOY1qZDPEnOzlM2tc8cv6lG7LtTKDig+HCyuAOdo0NlZZUUDvFBhrbT7siUPU2pLfYoozJb93ffP0Yvx4T1smrTVTjNosEzxt3VCc4/KaGdpMRiQNpInlc+SbTOw==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Jan Beulich <jbeulich@suse.com>,
        Bertrand Marquis
	<bertrand.marquis@arm.com>
CC: Rahul Singh <rahul.singh@arm.com>,
        "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>,
        Andre Przywara <Andre.Przywara@arm.com>,
        Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>,
        Juergen Gross
	<jgross@suse.com>,
        Stefano Stabellini <sstabellini@kernel.org>,
        =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>,
        Oleksandr
 Andrushchenko <Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH v5 01/11] xen/arm: xc_domain_ioport_permission(..) not
 supported on ARM.
Thread-Topic: [PATCH v5 01/11] xen/arm: xc_domain_ioport_permission(..) not
 supported on ARM.
Thread-Index: 
 AQHXutl5d8zkP9bsD0GXT4+5QPGclKvNtfkAgAAGc4CAABOEAIAABXoAgAAEuYCAAAVHAIAAJiWAgAAK0ICAAQCPgIAAA0qAgAAOJYCAAAHCAA==
Date: Tue, 12 Oct 2021 09:38:29 +0000
Message-ID: <c3952fd5-b893-4cb6-a9bc-325a89e859db@epam.com>
References: <cover.1633540842.git.rahul.singh@arm.com>
 <d292392268df2c74c4103a82ef917072643407a8.1633540842.git.rahul.singh@arm.com>
 <YWQkblfNMYEs6jI9@MacBook-Air-de-Roger.local>
 <77CF7FA5-C566-469E-B4A8-0400789890BB@arm.com>
 <YWQ6Nk3Jk+BqgkwZ@MacBook-Air-de-Roger.local>
 <53AE6E2A-01D7-41EC-9B2C-C0D596EB8D4D@arm.com>
 <YWRCxXGQIyTOAepC@MacBook-Air-de-Roger.local>
 <FEF0B03A-5AC8-4F8D-B821-191AC2EF8295@arm.com>
 <YWRnMfAi808TQ4Gt@MacBook-Air-de-Roger.local>
 <EB1CB53B-9D5A-49C5-A687-841BF94A153F@arm.com>
 <ac6d4785-ac9a-4491-26bb-c66ffe82c55b@suse.com>
 <ED8FC92F-B5EF-4473-B4A9-641C7D44859F@arm.com>
 <0744b957-1832-dff2-9ae2-b8e8534f501b@suse.com>
In-Reply-To: <0744b957-1832-dff2-9ae2-b8e8534f501b@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
authentication-results: suse.com; dkim=none (message not signed)
 header.d=none;suse.com; dmarc=none action=none header.from=epam.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: dc5a68ec-2a26-47f1-d81e-08d98d640c7c
x-ms-traffictypediagnostic: AM9PR03MB6769:
x-ms-exchange-transport-forked: True
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <AM9PR03MB67694DA5D6D537FB4A080A7CE7B69@AM9PR03MB6769.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 Y/lCQr7otf80wNb3r9WvzeLzzSr3refenWxyUNM/YMmKEnFUpVrfZ9FLsIwBI8M3Gk72cU8WyrIMN5C+CQuKdgSGC4FCJlIt94WrMoVe+hIcuI4J504v2RtuPxTNuOiFv9/ZtMeoUWFvGlmjsQuzncngZMHpCVop40U3yK4Hzw5T3Eb/S59mtUwldzd1GE7agMLojzixfZbMWwCOLcZdQz8oG0ofbIB6aBuoTmEI8FKXC2W6chjb1v3br9h1GouZUpMNLHfWQQRcbXUEaW7PejVcksVSq4KaQwpkNFEYJ1dDDchXYQsTzO9G4Vn7s6IUTGLlELj06ZVglyNEs4wqwcG4gPWVBjlOK/6Awln7LJ8tETLVyroIDLHWmQpPNejOTXrrIFwR300P5o8k3kyR5At+iKhEYcFZ4gtvwooKhDLUbgRBlkj11dD2VG7MY8/hCnNz2I8565uV6P3IjElB2KP2FxhDZMXpcReqUgA02gfZ30GFw5oymV+vAaJhFJ/8IHAEpNTmL8R85WNppnS77VqQQDZa0CK/sSbaaIAkKvrOEaKsrxq7DhuS5HiNdxo2ijYcmOSZPHyrlsiLUYXyTes59rbCwarqsad83DltEQr6XDfgkyrsbc/libsunlioTD1oGIgJvtKDdMS08OQjTA9NCwrYS3nNd9zH719rCyTpdHA3bBTZayOrSSfV2fHMRsPM++6jQw+eq6K7FJCNZ2V7Xse7sM0L/RlwU8OURTPz2uQdRAZQn7vZU2ftD2lb
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(26005)(6512007)(53546011)(186003)(36756003)(107886003)(71200400001)(6506007)(38070700005)(5660300002)(54906003)(110136005)(8936002)(8676002)(6486002)(55236004)(316002)(31696002)(508600001)(86362001)(4326008)(66446008)(2616005)(83380400001)(66556008)(64756008)(66946007)(76116006)(91956017)(7416002)(66476007)(38100700002)(122000001)(2906002)(31686004)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?dEJFMGtpMmZmd1lKQVRjSmlSVE1rbFU4M0N2dERUU3pqNE95WEFwK0o4TEww?=
 =?utf-8?B?bVc4ZDlnQTZDWDU5WHZnb2VJdWllNkRjWE5NSGpVSmdZaW02UjRsQ2ZnR2lS?=
 =?utf-8?B?Tk5WR2tIUDNZUnJ3VUI2LzVlYzdzNjMrUktweEg4aGIxWldHWWZrUXNMRVVi?=
 =?utf-8?B?VTk1ZTZINHdaZWp1UXdrNlY0WTE0VkJ0R1VkV2gzSCtwN0RNcFhVYnpIcXl4?=
 =?utf-8?B?cjZ1RC9MZG84V2UvMFhpOWZJK0lFckxYU2VYNm1Sb2M0b2lEMEV2TWJkbDJY?=
 =?utf-8?B?SHNiY050MEpocEh0ajI4eHNSTi90ZHp3QUlOOXRYOEVBd2JTbXpEeUNxR1JN?=
 =?utf-8?B?TzJTQzRmaHd1OGtrSkpZT1grSGtyeXVQMVllS2ZyOE5HOWxQZUFaS3FZN21p?=
 =?utf-8?B?U3hoM3JhVFNGOXQ2OS9hM3NNQW5KSkpLekVCOHV1N01HRDVIcEdBeXVJMVEr?=
 =?utf-8?B?YWttOWhISG1YanVVWm5HODBESlRpR1Q2UlczYml6SCtZMFh0bGJBQUZ0N2t3?=
 =?utf-8?B?VGdOSWM5bkM5R0hSUHU4YnA0dS8rMk5OOGlVSnkyeEpkZ0tIZFZyTGJOVGZE?=
 =?utf-8?B?ckNUQWlocUt0NmMzS2VpSkkxUmV2RmxUTjdSUlY0dGZ0RHZOTjNKd05ZaERx?=
 =?utf-8?B?aXhsQy9EcUFFZkFCMjR5N25TVkExQlUxcWkyMVMzZXVTaGRQQmh2bUo1bXBN?=
 =?utf-8?B?VGVBWHBqb0MvL25RRmg5OXRrMGZtTDhZSW9BSXhHMFM5azhEN2xVQmZXSmRv?=
 =?utf-8?B?RzZGRHhjSUV4SUpjZGdCUkdIV3cxNjM2QUZvZkR2RzZ4WU9MeDUwZnZiYUhp?=
 =?utf-8?B?bzBqU1J4QlhoaE1wY0hyU1plenVTTDhpRUJyekRoNXFTcDEybWM0SzFVblNn?=
 =?utf-8?B?VlhaN3VJeXZiRVd4a0dkcTM5WW5vNHFYd3g5WEhmaFFCSE1iOGdQWUIyY1k3?=
 =?utf-8?B?em9GVzdqSHNoRE5IdkMxcXM2Vy9Yc253TCtOSmd0bGZjbHJCanptZ3A0UzdF?=
 =?utf-8?B?c29VcDdPcENRWFpKTFUyWmpqQUJiM1EzemRSS2lPcHl6cFM3bEJaaWpBSFRO?=
 =?utf-8?B?Z0hDbXdadkg5bm1UOTMvdzQvSGtxR29XUHF6aWtNVzJwT2lEUitUWlRQUlla?=
 =?utf-8?B?MXE5OG0xdnZ6cytsNlIyaU1Ma1N4dFlSNm84akJST2Nwa21PaTNNZ0hlbjVB?=
 =?utf-8?B?czJlS0JHZ2RXWEpXY3JXUHJLSGxLQ2pDdCtvcTlhY2dhdk5hTEhDOEFjVDFY?=
 =?utf-8?B?YUpVWjllWm1uM3luZ251bnJ2Nkt2clh4cVYyM2tNYk9LeCt3Mlc2TFdQOGtH?=
 =?utf-8?B?c3RUeFZ1UjN5OEJGNTIxVzdzKzlmUW5RT2RmZUczaUtPRVNyZkdsbmdjd0ZP?=
 =?utf-8?B?U1pUQmtzZzlQL3A3K3cxK1AzZ3NzQVhCTStzaVplWnp6UDNDdlBXcit5OWpp?=
 =?utf-8?B?SGdKeWtERC8wZHA2L0dJM3BNbGdhS2s5RFZKdUQrTE85Q3VwRnUwbGJXNHBT?=
 =?utf-8?B?WVpnZFFuSGowSU5qOVdCbElpditheFBBZmZDWVFEUHNVTFlhRmpUSkFUUDVO?=
 =?utf-8?B?SGNLcXVnL1VhREY4SE41eU5DdG91ZWhOWk5zM1JSZFhQK1RGZldUalBsUC84?=
 =?utf-8?B?cXpOdG5yVFpQcVZmdTd3V2JSMjh6OVZkeUpLMVhpOWw3NTExK3BpdUxiN3o2?=
 =?utf-8?B?SzZWZXkwS1pNcnEzSVUyR21yQWlOWXMyY0lqbjd6WHhERVhNZ2NDSzh3ay96?=
 =?utf-8?B?b01oTWZnZmZJZ0dxVUoxS0ZmempRTmFwWlZ5QnZNNzREck5CWTNjd3JmZGE0?=
 =?utf-8?B?Q2ZIZjkvYUhPUzBpcmppdz09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <CC0440E8BCA3584C9C4A49E96842143A@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: dc5a68ec-2a26-47f1-d81e-08d98d640c7c
X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Oct 2021 09:38:29.4563
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 5K+Lg5zB10Z80LGOzWoCsBwLspDPaABdSL0ocm21k/QVNFHR3gCiAA6SFFoFv+1+9eEklpCIsXXwQE512hdfFF4ZJCCJibO9U5yBtYvp/gDSV1JLWMWCk5lxotx3Np1I
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR03MB6769
X-Proofpoint-ORIG-GUID: -jHCU8QPPXcjjY-ZtjajZwVzIGW5Vk30
X-Proofpoint-GUID: -jHCU8QPPXcjjY-ZtjajZwVzIGW5Vk30
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475
 definitions=2021-10-12_02,2021-10-11_01,2020-04-07_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 mlxlogscore=999
 lowpriorityscore=0 malwarescore=0 suspectscore=0 mlxscore=0 clxscore=1015
 bulkscore=0 impostorscore=0 priorityscore=1501 adultscore=0 spamscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109230001
 definitions=main-2110120054

DQoNCk9uIDEyLjEwLjIxIDEyOjMyLCBKYW4gQmV1bGljaCB3cm90ZToNCj4gT24gMTIuMTAuMjAy
MSAxMDo0MSwgQmVydHJhbmQgTWFycXVpcyB3cm90ZToNCj4+IEhpIEphbiwNCj4+DQo+Pj4gT24g
MTIgT2N0IDIwMjEsIGF0IDA5OjI5LCBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+IHdy
b3RlOg0KPj4+DQo+Pj4gT24gMTEuMTAuMjAyMSAxOToxMSwgQmVydHJhbmQgTWFycXVpcyB3cm90
ZToNCj4+Pj4+IE9uIDExIE9jdCAyMDIxLCBhdCAxNzozMiwgUm9nZXIgUGF1IE1vbm7DqSA8cm9n
ZXIucGF1QGNpdHJpeC5jb20+IHdyb3RlOg0KPj4+Pj4gT24gTW9uLCBPY3QgMTEsIDIwMjEgYXQg
MDI6MTY6MTlQTSArMDAwMCwgQmVydHJhbmQgTWFycXVpcyB3cm90ZToNCj4+Pj4+Pj4gT24gMTEg
T2N0IDIwMjEsIGF0IDE0OjU3LCBSb2dlciBQYXUgTW9ubsOpIDxyb2dlci5wYXVAY2l0cml4LmNv
bT4gd3JvdGU6DQo+Pj4+Pj4+IEkgdGhpbmsgdGhlIGNvbW1pdCBtZXNzYWdlIG5lZWRzIHRvIGF0
IGxlYXN0IGJlIGV4cGFuZGVkIGluIG9yZGVyIHRvDQo+Pj4+Pj4+IGNvbnRhaW4gdGhlIGluZm9y
bWF0aW9uIHByb3ZpZGVkIGhlcmUuIEl0IG1pZ2h0IGFsc28gYmUgaGVscGZ1bCB0bw0KPj4+Pj4+
PiBmaWd1cmUgb3V0IHdoZXRoZXIgd2Ugd291bGQgaGF2ZSB0byBoYW5kbGUgSU8gcG9ydCBhY2Nl
c3NlcyBpbiB0aGUNCj4+Pj4+Pj4gZnV0dXJlIG9uIEFybSwgb3IgaWYgaXQncyBmaW5lIHRvIGp1
c3QgaWdub3JlIHRoZW0uDQo+Pj4+Pj4gQWxsIG91ciBpbnZlc3RpZ2F0aW9ucyBhbmQgdGVzdHMg
aGF2ZSBiZWVuIGRvbmUgd2l0aG91dCBzdXBwb3J0aW5nIGl0DQo+Pj4+Pj4gd2l0aG91dCBhbnkg
aXNzdWVzIHNvIHRoaXMgaXMgbm90IGEgY3JpdGljYWwgZmVhdHVyZSAobW9zdCBkZXZpY2VzIGNh
bg0KPj4+Pj4+IGJlIG9wZXJhdGVkIHdpdGhvdXQgdXNpbmcgdGhlIEkvTyBwb3J0cykuDQo+Pj4+
PiBJTU8gd2Ugc2hvdWxkIGxldCB0aGUgdXNlcnMga25vdyB0aGV5IGF0dGVtcHRlZCB0byB1c2Ug
YSBkZXZpY2Ugd2l0aA0KPj4+Pj4gQkFScyBpbiB0aGUgSU8gc3BhY2UsIGFuZCB0aGF0IHRob3Nl
IEJBUnMgd29uJ3QgYmUgYWNjZXNzaWJsZSB3aGljaA0KPj4+Pj4gY291bGQgbWFrZSB0aGUgZGV2
aWNlIG5vdCBmdW5jdGlvbiBhcyBleHBlY3RlZC4NCj4+Pj4+DQo+Pj4+PiBEbyB5b3UgdGhpbmsg
aXQgd291bGQgYmUgcmVhc29uYWJsZSB0byBhdHRlbXB0IHRoZSBoeXBlcmNhbGwgb24gQXJtDQo+
Pj4+PiBhbHNvLCBhbmQgaW4gY2FzZSBvZiBlcnJvciAob24gQXJtKSBqdXN0IHByaW50IGEgd2Fy
bmluZyBtZXNzYWdlIGFuZA0KPj4+Pj4gY29udGludWUgb3BlcmF0aW9ucyBhcyBub3JtYWw/DQo+
Pj4+IEkgdGhpbmsgdGhpcyB3b3VsZCBsZWFkIHRvIGEgd2FybmluZyBwcmludGVkIG9uIGxvdHMg
b2YgZGV2aWNlcyB3aGVyZSBpbg0KPj4+PiBmYWN0IHRoZXJlIHdvdWxkIGJlIG5vIGlzc3Vlcy4N
Cj4+Pj4NCj4+Pj4gSWYgdGhpcyBpcyBhbiBpc3N1ZSBmb3IgYSBkZXZpY2UgZHJpdmVyIGJlY2F1
c2UgaXQgY2Fubm90IG9wZXJhdGUgd2l0aG91dA0KPj4+PiBJL08gcG9ydHMsIHRoaXMgd2lsbCBi
ZSByYWlzZWQgYnkgdGhlIGRyaXZlciBpbnNpZGUgdGhlIGd1ZXN0Lg0KPj4+IE9uIHdoYXQgYmFz
aXMgd291bGQgdGhlIGRyaXZlciBjb21wbGFpbj8gVGhlIGtlcm5lbCBtaWdodCBrbm93IG9mDQo+
Pj4gdGhlIE1NSU8gZXF1aXZhbGVudCBmb3IgcG9ydHMsIGFuZCBoZW5jZSBtaWdodCBhbGxvdyB0
aGUgZHJpdmVyDQo+Pj4gdG8gcHJvcGVybHkgb2J0YWluIHdoYXRldmVyIGlzIG5lZWRlZCB0byBs
YXRlciBhY2Nlc3MgdGhlIHBvcnRzLg0KPj4+IEp1c3QgdGhhdCB0aGUgcG9ydCBhY2Nlc3NlcyB0
aGVuIHdvdWxkbid0IHdvcmsgKHBvc3NpYmx5IGNyYXNoaW5nDQo+Pj4gdGhlIGd1ZXN0LCBvciBt
YWtpbmcgaXQgb3RoZXJ3aXNlIG1pc2JlaGF2ZSkuDQo+PiBBcyBFQ0FNIGFuZCBBcm0gZG9lcyBu
b3Qgc3VwcG9ydCBJL08gcG9ydHMsIGEgZHJpdmVyIHJlcXVlc3RpbmcgYWNjZXNzDQo+PiB0byB0
aGVtIHdvdWxkIGdldCBhbiBlcnJvciBiYWNrLg0KPj4gU28gaW4gcHJhY3RpY2UgaXQgaXMgbm90
IHBvc3NpYmxlIHRvIHRyeSB0byBhY2Nlc3MgdGhlIGlvcG9ydHMgYXMgdGhlcmUgaXMgbm8NCj4+
IHdheSBvbiBhcm0gdG8gdXNlIHRoZW0gKG5vIGluc3RydWN0aW9ucykuDQo+Pg0KPj4gQSBkcml2
ZXIgY291bGQgbWlzYmVoYXZlIGJ5IGlnbm9yaW5nIHRoZSBmYWN0IHRoYXQgaW9wb3J0cyBhcmUg
bm90IHRoZXJlIGJ1dA0KPj4gSSBhbSBub3QgcXVpdGUgc3VyZSBob3cgd2UgY291bGQgc29sdmUg
dGhhdCBhcyBpdCB3b3VsZCBiZSBhIGJ1ZyBpbiB0aGUgZHJpdmVyLg0KPiBUaGUgbWluaW1hbCB0
aGluZyBJJ2Qgc3VnZ2VzdCAob3IgbWF5YmUgeW91J3JlIGRvaW5nIHRoaXMgYWxyZWFkeSkNCj4g
d291bGQgYmUgdG8gZXhwb3NlIHN1Y2ggQkFScyB0byB0aGUgZ3Vlc3QgYXMgci9vIHplcm8sIHJh
dGhlciB0aGFuDQo+IGxldHRpbmcgdGhlaXIgcG9ydCBuYXR1cmUgInNoaW5lIHRocm91Z2giLg0K
SWYgd2UgaGF2ZSB0aGUgc2FtZSwgYnV0IGJhcmVtZXRhbCB0aGVuIHdoaWNoIGVudGl0eSBkaXNh
bGxvd3MNCnRob3NlIEJBUnMgdG8gc2hpbmU/IEkgbWVhbiB0aGF0IGlmIGd1ZXN0IHdhbnRzIHRv
IGNyYXNoLi4uIHdoeQ0Kc2hvdWxkIHdlIHN0b3AgaXQgYW5kIHRyeSBlbXVsYXRpbmcgc29tZXRo
aW5nIHNwZWNpYWwgZm9yIGl0Pw0KPg0KPiBKYW4NCj4NCg==


From xen-devel-bounces@lists.xenproject.org Tue Oct 12 09:40:27 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 09:40:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.207016.362730 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maEGn-0002gL-Sp; Tue, 12 Oct 2021 09:40:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 207016.362730; Tue, 12 Oct 2021 09:40:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maEGn-0002gE-Pn; Tue, 12 Oct 2021 09:40:25 +0000
Received: by outflank-mailman (input) for mailman id 207016;
 Tue, 12 Oct 2021 09:40:24 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=B8jq=PA=arm.com=Bertrand.Marquis@srs-us1.protection.inumbo.net>)
 id 1maEGm-0002g6-7n
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 09:40:24 +0000
Received: from EUR05-AM6-obe.outbound.protection.outlook.com (unknown
 [2a01:111:f400:7e1b::622])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 0ac8061e-6608-44f2-a246-363dec1f8856;
 Tue, 12 Oct 2021 09:40:22 +0000 (UTC)
Received: from AM6P195CA0013.EURP195.PROD.OUTLOOK.COM (2603:10a6:209:81::26)
 by VE1PR08MB5869.eurprd08.prod.outlook.com (2603:10a6:800:1b2::17) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.22; Tue, 12 Oct
 2021 09:40:19 +0000
Received: from VE1EUR03FT010.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:209:81:cafe::3) by AM6P195CA0013.outlook.office365.com
 (2603:10a6:209:81::26) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18 via Frontend
 Transport; Tue, 12 Oct 2021 09:40:19 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT010.mail.protection.outlook.com (10.152.18.113) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4587.18 via Frontend Transport; Tue, 12 Oct 2021 09:40:18 +0000
Received: ("Tessian outbound e27daf245730:v103");
 Tue, 12 Oct 2021 09:40:17 +0000
Received: from 529144006467.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 63EEF43E-4FCE-4EFA-81C5-392ABC75596D.1; 
 Tue, 12 Oct 2021 09:40:11 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 529144006467.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Tue, 12 Oct 2021 09:40:11 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com (2603:10a6:4:74::9)
 by DBBPR08MB6204.eurprd08.prod.outlook.com (2603:10a6:10:1f5::6) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.19; Tue, 12 Oct
 2021 09:40:11 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955]) by DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955%4]) with mapi id 15.20.4587.026; Tue, 12 Oct 2021
 09:40:10 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0ac8061e-6608-44f2-a246-363dec1f8856
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=RlWQSlb09wP+zQ1sz9K4CIix3ZQ4bgwUujKrkjp9vU8=;
 b=0T5iJhaSML1a+hBABFUKfeIGysbWYaffYgqHAVPWy/tBNgg+utbgRjTDHtDvum6FUz7ix4q+BwNTocqedEw3BlNtiR4nrFSVcFaRaZpKoBHGWSzCiwCJQa/KJRqkpJbSpgdcBsfryQy1VD//VKg5yRC/G1F9W3Tkqp8qVHkgCuM=
X-MS-Exchange-Authentication-Results: spf=temperror (sender IP is
 63.35.35.123) smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass
 (signature was verified) header.d=armh.onmicrosoft.com;lists.xenproject.org;
 dmarc=temperror action=none header.from=arm.com;
Received-SPF: TempError (protection.outlook.com: error in processing during
 lookup of arm.com: DNS Timeout)
X-CheckRecipientChecked: true
X-CR-MTA-CID: adf5f7b01ff45300
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=IYXrsTR5ceamoxLqivWj9gGFi37aR4SMqB/ot+qYUZAy+278D8DPmuSDy90KEimVRWQ0clA1PrjBw4y420et1A21y03sHqZ+NORScbMaxVjE+sEgAtOM5Q6e35Rc0HyKRYvHscHE4PRJ7N/zQZ5IMyMmTsFnhqPQyWje7mk1Mm0H4+mqZ5SrZUfW8Fpcd16uCRPO0gC18dHrC+G1XKksx9dTcJQT9XlEddpggm0aR8rwmV+Pm4ozUEgFqEPMPmXINSWHjvVzK9VGpWQWqc6Oq5AAr2YCORzq/jUVAezEM8wLAntSVgb7mlyv8MIzW8+UrPao056o3YcFaMEbg6Qdeg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=RlWQSlb09wP+zQ1sz9K4CIix3ZQ4bgwUujKrkjp9vU8=;
 b=CbbyNrFlgLlkjL2IEWX/v0cJiLtHFArK0q+hpFIqrnRMrIm66cD3yJYUinCYPsXhTogvhLAU9Pb2LU4+OBhvbHEvhCFFA4npKIOfdHeymmOctUq1Yh2YX1oEjlN4KUbp2iAQ6ufGATSTt3T8bnTH46vu+shvxkdCwHq7rcOm+V2QjUVkF255BXG0q4QkSyuoci9rxs7G+/zPY0hNkqFWrxkkD6rBhpo6kEWCiYFMVX2LSARV+PxJkIhbKZCmfaXIqKh7OCuzl5JxAWWeV2EvQRpyi31GqVTrTn6mzqKXRGI2U66Gx3gWdqSFY4V2poATpDIA3yYjcy9EBCeIKGZdJA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=RlWQSlb09wP+zQ1sz9K4CIix3ZQ4bgwUujKrkjp9vU8=;
 b=0T5iJhaSML1a+hBABFUKfeIGysbWYaffYgqHAVPWy/tBNgg+utbgRjTDHtDvum6FUz7ix4q+BwNTocqedEw3BlNtiR4nrFSVcFaRaZpKoBHGWSzCiwCJQa/KJRqkpJbSpgdcBsfryQy1VD//VKg5yRC/G1F9W3Tkqp8qVHkgCuM=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>, Rahul Singh
	<Rahul.Singh@arm.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, Andre Przywara <Andre.Przywara@arm.com>,
	Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>, Juergen Gross
	<jgross@suse.com>, Stefano Stabellini <sstabellini@kernel.org>,
	=?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>
Subject: Re: [PATCH v5 01/11] xen/arm: xc_domain_ioport_permission(..) not
 supported on ARM.
Thread-Topic: [PATCH v5 01/11] xen/arm: xc_domain_ioport_permission(..) not
 supported on ARM.
Thread-Index:
 AQHXutl5d8zkP9bsD0GXT4+5QPGclKvNtfkAgAAGc4CAABOEAIAABXoAgAAEuYCAAAVHAIAAJiWAgAAK0ICAAQCPgIAAA0qAgAAOJYCAAAI7AA==
Date: Tue, 12 Oct 2021 09:40:10 +0000
Message-ID: <76E73DCA-1AF0-4B64-9305-6C349280A911@arm.com>
References: <cover.1633540842.git.rahul.singh@arm.com>
 <d292392268df2c74c4103a82ef917072643407a8.1633540842.git.rahul.singh@arm.com>
 <YWQkblfNMYEs6jI9@MacBook-Air-de-Roger.local>
 <77CF7FA5-C566-469E-B4A8-0400789890BB@arm.com>
 <YWQ6Nk3Jk+BqgkwZ@MacBook-Air-de-Roger.local>
 <53AE6E2A-01D7-41EC-9B2C-C0D596EB8D4D@arm.com>
 <YWRCxXGQIyTOAepC@MacBook-Air-de-Roger.local>
 <FEF0B03A-5AC8-4F8D-B821-191AC2EF8295@arm.com>
 <YWRnMfAi808TQ4Gt@MacBook-Air-de-Roger.local>
 <EB1CB53B-9D5A-49C5-A687-841BF94A153F@arm.com>
 <ac6d4785-ac9a-4491-26bb-c66ffe82c55b@suse.com>
 <ED8FC92F-B5EF-4473-B4A9-641C7D44859F@arm.com>
 <0744b957-1832-dff2-9ae2-b8e8534f501b@suse.com>
In-Reply-To: <0744b957-1832-dff2-9ae2-b8e8534f501b@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3654.120.0.1.13)
Authentication-Results-Original: suse.com; dkim=none (message not signed)
 header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: 7c3d05d3-ac9a-4c17-af6e-08d98d644d3c
x-ms-traffictypediagnostic: DBBPR08MB6204:|VE1PR08MB5869:
x-ms-exchange-transport-forked: True
X-Microsoft-Antispam-PRVS:
	<VE1PR08MB5869C9C1A8C2D7BD6AA8BFFF9DB69@VE1PR08MB5869.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:10000;OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 hOwmJ/rimwcFR70Ane1p0Czh1CivafYzLCDGPZGi6ZAEBgAI/cfywv/2kslMK1+fy+V8RrcOEiL5bwthKrqtg6R6zNcZjMVfiHfEw9JcIHIE9IKnDhVtrOKEEelHe+r7qCYB8XfLpfLUHdsOwcaFzW2eeQXWbbSLCa7XkKWQ7qsnmekGUYN/c0gHW34q3MC6YjNgz2u5poKF6Xlb+yPPQrtrp+FaZGTdo5N0bzfqE2Udj4RvXiEOHhYQBd1yYcKshELhpHoQR1CQsXEMVzJ/SzNdrSD6UMMMBsjptk7Jke8olOsiUt4DzVKpIlwsE2rHXhQAChYRVESgE/IJ5kCbz2W45AlqwwxXUEZWL+GdVsLa7kVgvc7hes+s/5+PuDOrfpHL71bfE++AiQbz6NfcJcnyZHZFPDDh1Fnm6vu8QYBJodLgnf/A4zoiQd5a3c6hP+Or+WEiAGfO1dMxdH87IfeaWBx9uCpFlQl6sbzQwLMELub5MU64ROFxMydkga3pVst3oVH3oqBzw94NF43VfONyo4NLlf4/jEPorQzl5I4okfjWYLWJHWy244HpaVikct4YmQwo/RZdqy1KKeLLYWQ10dESIfSgqySb1M0Nrxl6F+AnGcBFZLA6nM1AmQOm3HjdrYX6WMJwnXeBnkPq73Bb99jqWBBUp80mWnvJI2xUqz11WvR7L0UgLm4Ipj9ptsDwCfRDhfRpKx/G2/UvFYTgUv7KSa9LuqgR47nhI8w=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB6PR0801MB2024.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(122000001)(38100700002)(76116006)(38070700005)(508600001)(54906003)(316002)(5660300002)(8936002)(83380400001)(2616005)(26005)(91956017)(64756008)(53546011)(66446008)(33656002)(4326008)(86362001)(8676002)(66946007)(66556008)(66476007)(71200400001)(6486002)(6512007)(36756003)(6916009)(186003)(6506007)(2906002)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-ID: <99CB8C54D94C7649B920823C9535ED39@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB6204
Original-Authentication-Results: suse.com; dkim=none (message not signed)
 header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT010.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	caa3a72e-463e-44cb-c441-08d98d6448f6
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	6r3M3KPT9T3UIotAQG/mESXZi/ruv56s1mdLmBoQfb3dBaZzKeGgkGjCzod6RHwad2fc0YgZ1WJpk/cU3pSCSgHJRk3uW6ORDglZ0LvoF/HIvk27incaS2DCU37j2C4ArGkYrad0cSXS7sNG/r2fP33u4M/xFNZiDOj2cGqPJUrMG26M/+sflPQIftvPKKyOJgTgbjdvf/L/xzW/yO0CoG1N5CgCdzi3tQ6TCq/gh+rbgV1/wj1GeCMwaXkVis6g73Noyk1HojhgCn/7Tbcx9wn3IGOxBOnBo4Sk6pNPM6Y5seJxnV8VGtHNFe4aY1BcBma9QCyaM7CQv9IsnZxEi3p4YfGlFnTkY7giklFE400480UKUHp3fkbu6ziV9WF2oPKqJToyNasZKY2aU0lsVBeWotPCVRzuMgyhRGIDn/tYNs8/M6385l7xH4qKq/dqHTF8uaS74p6CVlSi5RAuNjSYooWLJWJa44RfguSPwRH5tJcanD4rOARWUN2A/FOnSbTr4B46sOQROZMceu16jbqjw6ktMuYfAsXmFvhpF0mD31scCxnAJuVUwUPiLSG1MngURvLLGKKUGi746BKeZ7dOInHtCpnXwvUNWS5Cwt1zv8h4oFYDKtg94Crc7iqgpJufb6vHuER1aBe7r9kPvHYADdmJT7DfuY9LLEet77Z4QVgO4/EytzckgY5M2UkMtfS/qGlGaUWF0wzEu119CjSKgfUNUPAEvdUYTQyAqlY=
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(70206006)(70586007)(107886003)(36860700001)(508600001)(5660300002)(53546011)(86362001)(2616005)(336012)(54906003)(83380400001)(6506007)(47076005)(6512007)(26005)(316002)(8936002)(8676002)(82310400003)(356005)(4326008)(33656002)(81166007)(6862004)(6486002)(63350400001)(63370400001)(2906002)(186003)(36756003)(45980500001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2021 09:40:18.0305
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 7c3d05d3-ac9a-4c17-af6e-08d98d644d3c
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT010.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5869

SGkgSmFuLA0KDQo+IE9uIDEyIE9jdCAyMDIxLCBhdCAxMDozMiwgSmFuIEJldWxpY2ggPGpiZXVs
aWNoQHN1c2UuY29tPiB3cm90ZToNCj4gDQo+IE9uIDEyLjEwLjIwMjEgMTA6NDEsIEJlcnRyYW5k
IE1hcnF1aXMgd3JvdGU6DQo+PiBIaSBKYW4sDQo+PiANCj4+PiBPbiAxMiBPY3QgMjAyMSwgYXQg
MDk6MjksIEphbiBCZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNvbT4gd3JvdGU6DQo+Pj4gDQo+Pj4g
T24gMTEuMTAuMjAyMSAxOToxMSwgQmVydHJhbmQgTWFycXVpcyB3cm90ZToNCj4+Pj4+IE9uIDEx
IE9jdCAyMDIxLCBhdCAxNzozMiwgUm9nZXIgUGF1IE1vbm7DqSA8cm9nZXIucGF1QGNpdHJpeC5j
b20+IHdyb3RlOg0KPj4+Pj4gT24gTW9uLCBPY3QgMTEsIDIwMjEgYXQgMDI6MTY6MTlQTSArMDAw
MCwgQmVydHJhbmQgTWFycXVpcyB3cm90ZToNCj4+Pj4+Pj4gT24gMTEgT2N0IDIwMjEsIGF0IDE0
OjU3LCBSb2dlciBQYXUgTW9ubsOpIDxyb2dlci5wYXVAY2l0cml4LmNvbT4gd3JvdGU6DQo+Pj4+
Pj4+IEkgdGhpbmsgdGhlIGNvbW1pdCBtZXNzYWdlIG5lZWRzIHRvIGF0IGxlYXN0IGJlIGV4cGFu
ZGVkIGluIG9yZGVyIHRvDQo+Pj4+Pj4+IGNvbnRhaW4gdGhlIGluZm9ybWF0aW9uIHByb3ZpZGVk
IGhlcmUuIEl0IG1pZ2h0IGFsc28gYmUgaGVscGZ1bCB0bw0KPj4+Pj4+PiBmaWd1cmUgb3V0IHdo
ZXRoZXIgd2Ugd291bGQgaGF2ZSB0byBoYW5kbGUgSU8gcG9ydCBhY2Nlc3NlcyBpbiB0aGUNCj4+
Pj4+Pj4gZnV0dXJlIG9uIEFybSwgb3IgaWYgaXQncyBmaW5lIHRvIGp1c3QgaWdub3JlIHRoZW0u
DQo+Pj4+Pj4gDQo+Pj4+Pj4gQWxsIG91ciBpbnZlc3RpZ2F0aW9ucyBhbmQgdGVzdHMgaGF2ZSBi
ZWVuIGRvbmUgd2l0aG91dCBzdXBwb3J0aW5nIGl0DQo+Pj4+Pj4gd2l0aG91dCBhbnkgaXNzdWVz
IHNvIHRoaXMgaXMgbm90IGEgY3JpdGljYWwgZmVhdHVyZSAobW9zdCBkZXZpY2VzIGNhbg0KPj4+
Pj4+IGJlIG9wZXJhdGVkIHdpdGhvdXQgdXNpbmcgdGhlIEkvTyBwb3J0cykuDQo+Pj4+PiANCj4+
Pj4+IElNTyB3ZSBzaG91bGQgbGV0IHRoZSB1c2VycyBrbm93IHRoZXkgYXR0ZW1wdGVkIHRvIHVz
ZSBhIGRldmljZSB3aXRoDQo+Pj4+PiBCQVJzIGluIHRoZSBJTyBzcGFjZSwgYW5kIHRoYXQgdGhv
c2UgQkFScyB3b24ndCBiZSBhY2Nlc3NpYmxlIHdoaWNoDQo+Pj4+PiBjb3VsZCBtYWtlIHRoZSBk
ZXZpY2Ugbm90IGZ1bmN0aW9uIGFzIGV4cGVjdGVkLg0KPj4+Pj4gDQo+Pj4+PiBEbyB5b3UgdGhp
bmsgaXQgd291bGQgYmUgcmVhc29uYWJsZSB0byBhdHRlbXB0IHRoZSBoeXBlcmNhbGwgb24gQXJt
DQo+Pj4+PiBhbHNvLCBhbmQgaW4gY2FzZSBvZiBlcnJvciAob24gQXJtKSBqdXN0IHByaW50IGEg
d2FybmluZyBtZXNzYWdlIGFuZA0KPj4+Pj4gY29udGludWUgb3BlcmF0aW9ucyBhcyBub3JtYWw/
DQo+Pj4+IA0KPj4+PiBJIHRoaW5rIHRoaXMgd291bGQgbGVhZCB0byBhIHdhcm5pbmcgcHJpbnRl
ZCBvbiBsb3RzIG9mIGRldmljZXMgd2hlcmUgaW4NCj4+Pj4gZmFjdCB0aGVyZSB3b3VsZCBiZSBu
byBpc3N1ZXMuDQo+Pj4+IA0KPj4+PiBJZiB0aGlzIGlzIGFuIGlzc3VlIGZvciBhIGRldmljZSBk
cml2ZXIgYmVjYXVzZSBpdCBjYW5ub3Qgb3BlcmF0ZSB3aXRob3V0DQo+Pj4+IEkvTyBwb3J0cywg
dGhpcyB3aWxsIGJlIHJhaXNlZCBieSB0aGUgZHJpdmVyIGluc2lkZSB0aGUgZ3Vlc3QuDQo+Pj4g
DQo+Pj4gT24gd2hhdCBiYXNpcyB3b3VsZCB0aGUgZHJpdmVyIGNvbXBsYWluPyBUaGUga2VybmVs
IG1pZ2h0IGtub3cgb2YNCj4+PiB0aGUgTU1JTyBlcXVpdmFsZW50IGZvciBwb3J0cywgYW5kIGhl
bmNlIG1pZ2h0IGFsbG93IHRoZSBkcml2ZXINCj4+PiB0byBwcm9wZXJseSBvYnRhaW4gd2hhdGV2
ZXIgaXMgbmVlZGVkIHRvIGxhdGVyIGFjY2VzcyB0aGUgcG9ydHMuDQo+Pj4gSnVzdCB0aGF0IHRo
ZSBwb3J0IGFjY2Vzc2VzIHRoZW4gd291bGRuJ3Qgd29yayAocG9zc2libHkgY3Jhc2hpbmcNCj4+
PiB0aGUgZ3Vlc3QsIG9yIG1ha2luZyBpdCBvdGhlcndpc2UgbWlzYmVoYXZlKS4NCj4+IA0KPj4g
QXMgRUNBTSBhbmQgQXJtIGRvZXMgbm90IHN1cHBvcnQgSS9PIHBvcnRzLCBhIGRyaXZlciByZXF1
ZXN0aW5nIGFjY2Vzcw0KPj4gdG8gdGhlbSB3b3VsZCBnZXQgYW4gZXJyb3IgYmFjay4NCj4+IFNv
IGluIHByYWN0aWNlIGl0IGlzIG5vdCBwb3NzaWJsZSB0byB0cnkgdG8gYWNjZXNzIHRoZSBpb3Bv
cnRzIGFzIHRoZXJlIGlzIG5vDQo+PiB3YXkgb24gYXJtIHRvIHVzZSB0aGVtIChubyBpbnN0cnVj
dGlvbnMpLg0KPj4gDQo+PiBBIGRyaXZlciBjb3VsZCBtaXNiZWhhdmUgYnkgaWdub3JpbmcgdGhl
IGZhY3QgdGhhdCBpb3BvcnRzIGFyZSBub3QgdGhlcmUgYnV0DQo+PiBJIGFtIG5vdCBxdWl0ZSBz
dXJlIGhvdyB3ZSBjb3VsZCBzb2x2ZSB0aGF0IGFzIGl0IHdvdWxkIGJlIGEgYnVnIGluIHRoZSBk
cml2ZXIuDQo+IA0KPiBUaGUgbWluaW1hbCB0aGluZyBJJ2Qgc3VnZ2VzdCAob3IgbWF5YmUgeW91
J3JlIGRvaW5nIHRoaXMgYWxyZWFkeSkNCj4gd291bGQgYmUgdG8gZXhwb3NlIHN1Y2ggQkFScyB0
byB0aGUgZ3Vlc3QgYXMgci9vIHplcm8sIHJhdGhlciB0aGFuDQo+IGxldHRpbmcgdGhlaXIgcG9y
dCBuYXR1cmUgInNoaW5lIHRocm91Z2giLg0KDQpXZSBhcmUgZW11bGF0aW5nIGFuIEVDQU0gUENJ
IHdoaWNoIGRvZXMgbm90IHN1cHBvcnQgSS9PIHBvcnRzIHNvIEkgZG8gbm90DQp0aGluayB3ZSBh
cmUgKGFuZCBjYW4pIGV4cG9zZSB0aG9zZSB0byBndWVzdHMuDQoNCkFueXdheSBJIHdpbGwgbWFy
ayB0aGlzIGFzIGEgcG9pbnQgdG8gY2hlY2sgZm9yIFJhaHVsIHdoZW4gaGUgaXMgYmFjay4NCg0K
Q2hlZXJzDQpCZXJ0cmFuZA0KDQo+IA0KPiBKYW4NCg0K


From xen-devel-bounces@lists.xenproject.org Tue Oct 12 10:01:50 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 10:01:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.207038.362770 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maEbQ-0005Qp-W6; Tue, 12 Oct 2021 10:01:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 207038.362770; Tue, 12 Oct 2021 10:01:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maEbQ-0005Qi-Sm; Tue, 12 Oct 2021 10:01:44 +0000
Received: by outflank-mailman (input) for mailman id 207038;
 Tue, 12 Oct 2021 10:01:43 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=/4YK=PA=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1maEbP-0005Qc-3u
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 10:01:43 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id c3a3496e-d33a-49c1-9904-a47dd2b50769;
 Tue, 12 Oct 2021 10:01:41 +0000 (UTC)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2168.outbound.protection.outlook.com [104.47.17.168])
 (Using TLS) by relay.mimecast.com with ESMTP id
 de-mta-30-e6HSZbttMXKoq5QMr_a8hg-1; Tue, 12 Oct 2021 12:01:39 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0401MB2335.eurprd04.prod.outlook.com (2603:10a6:800:2e::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.25; Tue, 12 Oct
 2021 10:01:36 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4587.026; Tue, 12 Oct 2021
 10:01:36 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 FR3P281CA0043.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4a::15) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.4 via Frontend Transport; Tue, 12 Oct 2021 10:01:35 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c3a3496e-d33a-49c1-9904-a47dd2b50769
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634032901;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=tJjhX86f3EAGln+TbUHg2oryS2vcZ3ceHW2kRO4z6k8=;
	b=abkHDC24TvPyXUI0LuVjBs+oGcVb4Ndf+obGfkduqU+FA0ac8P9bjE2h+OLpQHFQ9Qi0Zk
	khbw8STRBvBBK/jUydedMzKgmGtHsEKLXLd15pVQ+Qy083v6KicPT1F2Ix8f65iKlfpVKQ
	PZ9yJBNNiXc+G2w6MJ8mD8+xYCG8t7s=
X-MC-Unique: e6HSZbttMXKoq5QMr_a8hg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=joTBokRUKRaw/jfIivDfKvIzsojVBvDtdsN/prdYZHzrjO9bBKftGIYRck7byOVK+LMe++pA5U6Epp5Zbwki27reCFqb3pPapWwlokoK1XrIdOGGIk6PSCOhl07bnqBPur9Onrj3OpJlORBqdNUPPeDSTuTlwBG21aM5yNOUZGYGVGFn6+sRHySsNQ5w0vCzVJ+3zbkxxJKHN80BoYLx1JOyFxMEaXvWbsgm5gUv+OUWXcAAGRxij++Kzd8acIc1Pw5j8Xt6dEmbaR0Da26RY8OqkXZbKHkH384Re0IoRPdLGUumDADJ3kAiM+fcXirZEHaQXZEDgDxLtLrYtl9vzQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=RZBGOB0yTTyttKdwtPTE+h6ujJQ2LdOuE0OtYnrKmg0=;
 b=hpVc2oKWaHIt896mHFHclYGgI+Sf1RdBQPYzsub6ENd1H0mcXBeoW0dTa5wwr908wCHgn+B/Jld8ZEq81PekFk+kc9BYa/6AsdLdNKcK5h3kkt93DnfrWoOgpCSg+oWb361la7SNnsOdJYcs+0nSSu4JDnITsgQpEVL8t6ySxjYs1AkJ81MKPA1yO3J3jGXn8dSyS9cMhm4WYtk551b8n/r0OkmpaozBw6bVIy5P5Yp2zG8Be0MvzPb0TZ4avtWsxjURKAYLiHudOkd7P1jlueDmNnn9IBgRoV/KS+JrOGrLjDjV8nTK0qn6lMU8RUAsXp+DNQG9bxPkttsSvhhJ3Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: citrix.com; dkim=none (message not signed)
 header.d=none;citrix.com; dmarc=none action=none header.from=suse.com;
Subject: Re: [PATCH v5 01/11] xen/arm: xc_domain_ioport_permission(..) not
 supported on ARM.
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>
CC: Rahul Singh <rahul.singh@arm.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andre Przywara <Andre.Przywara@arm.com>, Ian Jackson <iwj@xenproject.org>,
 Wei Liu <wl@xen.org>, Juergen Gross <jgross@suse.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <cover.1633540842.git.rahul.singh@arm.com>
 <d292392268df2c74c4103a82ef917072643407a8.1633540842.git.rahul.singh@arm.com>
 <YWQkblfNMYEs6jI9@MacBook-Air-de-Roger.local>
 <77CF7FA5-C566-469E-B4A8-0400789890BB@arm.com>
 <YWQ6Nk3Jk+BqgkwZ@MacBook-Air-de-Roger.local>
 <53AE6E2A-01D7-41EC-9B2C-C0D596EB8D4D@arm.com>
 <YWRCxXGQIyTOAepC@MacBook-Air-de-Roger.local>
 <FEF0B03A-5AC8-4F8D-B821-191AC2EF8295@arm.com>
 <YWRnMfAi808TQ4Gt@MacBook-Air-de-Roger.local>
 <EB1CB53B-9D5A-49C5-A687-841BF94A153F@arm.com>
 <ac6d4785-ac9a-4491-26bb-c66ffe82c55b@suse.com>
 <ED8FC92F-B5EF-4473-B4A9-641C7D44859F@arm.com>
 <0744b957-1832-dff2-9ae2-b8e8534f501b@suse.com>
 <c3952fd5-b893-4cb6-a9bc-325a89e859db@epam.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <c125b447-53e8-7d13-3b08-af62fd3a9140@suse.com>
Date: Tue, 12 Oct 2021 12:01:34 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <c3952fd5-b893-4cb6-a9bc-325a89e859db@epam.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: FR3P281CA0043.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:4a::15) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 69a2fa04-e34a-4fda-6634-08d98d6746fd
X-MS-TrafficTypeDiagnostic: VI1PR0401MB2335:
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS:
	<VI1PR0401MB2335894AF50ABEAD75C51DC0B3B69@VI1PR0401MB2335.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	P680sfhmDyr5HR7w8Y5Z+LH3NFTtALNSMGMiUF5kJgBGsckkYoPN+6kLFwEQ7Mb+C8YQLNOEOjLJ2eQ9ltVOHoGXx2VzLw0Uhb29dOPO1XEy9ex+XVErsv5kXdDXWiDrBkWsIIsrxNFV1czpGHE8AsUOxXLeZUoRux7uaJKWa1fhdiev6lwrSU70ch24h3mhAnW1680QxwNflZJd0UkKElegd5qVQehDkg+zRaFQMqsadzoTAWovMBzZf+2RD0Qtq1L2Esw6uIBWofBfBr7I1PLZIYh1Qh5Nzvz+qqAlE74vvfJ/lb/KSPrW+ha+qSmQBhPVYk5nT5OQYeF5X4AHVDk7rGbCzBwaQIRw/gv63PEQAiCf+ce3VvbXibO5onfsFmml/TFUYAgEuVqVG7sAhKMips09mOk4u07ycB1zrc3oPZvlpftzBz6AUwuJtzfR2Utd9egMrGa8QJClbhMj/UkU3rkeCJJY/YfqqfnktdZRNdnXzsw1PJYlNeVseyKRnVpJ0kd5kRIict0zWEXM0ur3Pv1GlBGN3v+X5GI5VYm9yipLfnvHAXS7KRB/Zjt7t9q8BAmFaTXX3bJGdSDdNZpfWzps9oYR+xmSeJ67G8NpeyXLrJALjijhH+iPt1hOTu1pxAcQjiT+1F1a98eHLbLNvQ9iN65UGcg2lLoGBxb+moUNZ4IN1AuphpgQpBQAaIy1Trn4gTHcJdj1PVETx4pSobrC98wkVvT7B17sSsHDkqqh49H9Y5rHeFW9nA5S
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(16576012)(54906003)(53546011)(4326008)(5660300002)(956004)(83380400001)(2616005)(316002)(110136005)(6486002)(86362001)(38100700002)(8676002)(8936002)(508600001)(66476007)(36756003)(66556008)(66946007)(26005)(31686004)(2906002)(186003)(31696002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?+9LD88kRp+vkCb3VoJAQaVEJNBAoTDl/G5Sb2tQx06P4c6MYakF57Go0BOOG?=
 =?us-ascii?Q?3PMtzBlIEuyVyxbVQGJWAC3946tVHwne5idgnPfR9yNAL4t7syJXICq64hGd?=
 =?us-ascii?Q?RdK+6xMq8kux/Ab9hQAMMKVgHkomOna43FXC12+ONryydtbzAdsWK2sFLORN?=
 =?us-ascii?Q?0QQ+HyZAQ2j+eMCcpKztVPd0G67Z29u5JT+BTfYc8DBO/QhT5i0kQ2A2Ioa/?=
 =?us-ascii?Q?yyaoKcZOz202aimdpc+OAtosdI1+6TUfZDzm49q8oba4PpSdYaWvCOm+a78G?=
 =?us-ascii?Q?UEP9JYYfNeImX88UHcv/fUliSS9IgZqDjHqJrZHXGOVYkJzf7SqWy2NjaRMT?=
 =?us-ascii?Q?5lCJJtWnEoBIq5iUZa4vcJakcyZ5AU8lcvzQnMLcKbrgZg2luovsXgzUzlVd?=
 =?us-ascii?Q?WuHiWY7vnJp6rffQopV/9fxswjRllGoUdESORSxTd0OPxJbJwaDiQ54uLwRD?=
 =?us-ascii?Q?rBkZ+ohgi3QCTBo66C2TBLwj9mskjkStmWXHoSG0XO+jX+LnNtCyJAe4ifGD?=
 =?us-ascii?Q?kh1k0hcDkUTqmCQmS2GZw8EYrtWTMCSfDER2ENN1TNKTOxN8+u0AdsezksnU?=
 =?us-ascii?Q?T8ArohTIfP6gtE7mVGCoMtsaEfmnIEFoQy1P9L8rPYCq/iBTYuOGkiHCFTEq?=
 =?us-ascii?Q?KV3v5dQEAGknYPIkbaEMLk4JpqI4+sAEKMhbvZ3mhezXicMiWGOjadmJfIob?=
 =?us-ascii?Q?1AcsTAmWk+VT3Fl3TA7LDcaRSDzcOObQ02f2oYJicKdU8MmmPvHTL9IUeySV?=
 =?us-ascii?Q?DyVN8NXhpfh07imW+DvEu0g/Nvoct/AhbVlGSyDH+EiAhgs3B/IQJv1A6Tf0?=
 =?us-ascii?Q?X2H7ZJ6/WqqBvVBzJ3YQDMJqrqdJ/kykgr0DO5FH4I3mW7o+BFJeXKudgR86?=
 =?us-ascii?Q?6Ajfz7Fv5fsN23h+IVknmChDJS3fpju1J/IQYPca7BMEzC7cQsn6KnTRlTkV?=
 =?us-ascii?Q?+6fmtcGCI9dAh1a0gPyrqn6V9mOsTcO6rgBYGScHuQ7P0jdFgitHdsAnzR/B?=
 =?us-ascii?Q?3oCYacCV9CjF7A0mzi9JPqp2Xri4GrZNPgPqRK/asL/C12o+YpBIgTlgdNTN?=
 =?us-ascii?Q?W2a4fgtNVJebsLrgP1mOPcO+79eD0sW+T4k6QZFujmpwzdIG2MlQpl4wcUxk?=
 =?us-ascii?Q?4efbveeDRa6VGblN72NLnvJKlpuoJFbkq585bRe+UPiDaWDD8izpnWqhO9Hp?=
 =?us-ascii?Q?Gt9SqSnCRLK+yev8HVyNWCEU0SCGY5Z9silc0c/oiXNZuVT/rpk4oyjim20o?=
 =?us-ascii?Q?0QJUL5dfjA1/rQs2kV0fmsr5PbuTcHCNsGh7YGvH66qHxOk8LRrlz9X6rBIh?=
 =?us-ascii?Q?Vw1ceU5QBXvYA2afr41RI2Kg?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 69a2fa04-e34a-4fda-6634-08d98d6746fd
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2021 10:01:36.2685
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jCHSwiBVMrNmiO1WUK0B59nMiGtoGnPWvSj6GlwBHRYjSR/rxtXXkCAIWfBU+01RCTLBLtRBjgd9vIMssbCqUQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2335

On 12.10.2021 11:38, Oleksandr Andrushchenko wrote:
> On 12.10.21 12:32, Jan Beulich wrote:
>> On 12.10.2021 10:41, Bertrand Marquis wrote:
>>>> On 12 Oct 2021, at 09:29, Jan Beulich <jbeulich@suse.com> wrote:
>>>> On 11.10.2021 19:11, Bertrand Marquis wrote:
>>>>>> On 11 Oct 2021, at 17:32, Roger Pau Monn=C3=A9 <roger.pau@citrix.com=
> wrote:
>>>>>> On Mon, Oct 11, 2021 at 02:16:19PM +0000, Bertrand Marquis wrote:
>>>>>>>> On 11 Oct 2021, at 14:57, Roger Pau Monn=C3=A9 <roger.pau@citrix.c=
om> wrote:
>>>>>>>> I think the commit message needs to at least be expanded in order =
to
>>>>>>>> contain the information provided here. It might also be helpful to
>>>>>>>> figure out whether we would have to handle IO port accesses in the
>>>>>>>> future on Arm, or if it's fine to just ignore them.
>>>>>>> All our investigations and tests have been done without supporting =
it
>>>>>>> without any issues so this is not a critical feature (most devices =
can
>>>>>>> be operated without using the I/O ports).
>>>>>> IMO we should let the users know they attempted to use a device with
>>>>>> BARs in the IO space, and that those BARs won't be accessible which
>>>>>> could make the device not function as expected.
>>>>>>
>>>>>> Do you think it would be reasonable to attempt the hypercall on Arm
>>>>>> also, and in case of error (on Arm) just print a warning message and
>>>>>> continue operations as normal?
>>>>> I think this would lead to a warning printed on lots of devices where=
 in
>>>>> fact there would be no issues.
>>>>>
>>>>> If this is an issue for a device driver because it cannot operate wit=
hout
>>>>> I/O ports, this will be raised by the driver inside the guest.
>>>> On what basis would the driver complain? The kernel might know of
>>>> the MMIO equivalent for ports, and hence might allow the driver
>>>> to properly obtain whatever is needed to later access the ports.
>>>> Just that the port accesses then wouldn't work (possibly crashing
>>>> the guest, or making it otherwise misbehave).
>>> As ECAM and Arm does not support I/O ports, a driver requesting access
>>> to them would get an error back.
>>> So in practice it is not possible to try to access the ioports as there=
 is no
>>> way on arm to use them (no instructions).
>>>
>>> A driver could misbehave by ignoring the fact that ioports are not ther=
e but
>>> I am not quite sure how we could solve that as it would be a bug in the=
 driver.
>> The minimal thing I'd suggest (or maybe you're doing this already)
>> would be to expose such BARs to the guest as r/o zero, rather than
>> letting their port nature "shine through".
> If we have the same, but baremetal then which entity disallows
> those BARs to shine?

I'm sorry, but I don't understand what you're trying to say.

> I mean that if guest wants to crash... why
> should we stop it and try emulating something special for it?

This isn't about a guest "wanting to crash", but a driver potentially
getting mislead into thinking that it can driver a device a certain
way.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Oct 12 10:04:00 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 10:04:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.207045.362781 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maEdb-00062C-Dc; Tue, 12 Oct 2021 10:03:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 207045.362781; Tue, 12 Oct 2021 10:03:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maEdb-000625-AK; Tue, 12 Oct 2021 10:03:59 +0000
Received: by outflank-mailman (input) for mailman id 207045;
 Tue, 12 Oct 2021 10:03:58 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=/4YK=PA=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1maEda-00061z-J2
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 10:03:58 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id b67bc010-2b43-11ec-811d-12813bfff9fa;
 Tue, 12 Oct 2021 10:03:57 +0000 (UTC)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2169.outbound.protection.outlook.com [104.47.17.169])
 (Using TLS) by relay.mimecast.com with ESMTP id
 de-mta-16-B8rmc6vWP1mniMFo1xJqKQ-1; Tue, 12 Oct 2021 12:03:55 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0401MB2335.eurprd04.prod.outlook.com (2603:10a6:800:2e::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.25; Tue, 12 Oct
 2021 10:03:54 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4587.026; Tue, 12 Oct 2021
 10:03:54 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS8PR04CA0200.eurprd04.prod.outlook.com (2603:10a6:20b:2f3::25) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18 via Frontend
 Transport; Tue, 12 Oct 2021 10:03:53 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b67bc010-2b43-11ec-811d-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634033036;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=FhL93p3rUL8EJlYUEMvVE2iZPRkSnVb0SCpcwgvrHro=;
	b=DTuwd0DsgsF+aEPuAcmSZOMoFrT52jwglrEBYKWk4UYDXyUY5dYa+s3LRJmsZW3DAgPSCm
	nXoBJ7AWaUqcTIuPL30mVhl4ur9fL7+AStFU0b2z2JrOcleirbI66q7RkM98gY5qNKWrPL
	EiFwoqf5QHMrLclq3Ot8xwPniQRj1JE=
X-MC-Unique: B8rmc6vWP1mniMFo1xJqKQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=JcEGuqcP/FDhQQSXN5oP4oxToSkVLgAj5o71aGr3tZCfChWsOAhH3DNqQ6R1WgQ95O1NEndqBYpReH1AOABmCRwEKt1ViQKzfPCNHcsrT6a4ou/FLTdAwr936ZHnxSDUfssfdZ2rj+sdtWPtJESyZ9SALgN2KdpnKJrqchlgy2Cv3RocQBaqdSkcytdwo3dCI+IlIdTvXX6xJZZVnnH+/a2caBy1pPgxGT8gyLqP8Rvj0jRAIJgWTMww8YM4iaSWskuJbkyXkbnEcMvA17UrWaDzspyhBOQemhtEBe5WAyG5fMhZNR1bF4PwAbhdWN+6g6R/rJZ7UqPy8KR5jPbtcg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=FSelyn2GNiLeHHZsI2XBP/pqcmLhnNtXThtS2+gh2JM=;
 b=ZzHjMsUbjIxAaJliwMOXCiHmw9QISAKhPtue3augAvgjX35e6XEZCPXT9RwRJLoce3uY4hYiT86xlrrSD0yY7TZhdtBdjpBi4dpqq/9MS9E7tKnvSljqt0ZsLmBq6f+uqVNDTK2wKY9ESgBp8AiO6VsHDL5W1n8EW7RilpGrGg4GqOb2Gj5Y5gdu+l/dcLrOr8T8AvR+zKVhoTCUSRh/2i1WsdUARBLEhjPhm44YyE2o5xS4ceACiRaolyTD8VAlv92/Sd35kBlVEdrgWbcXewotcwtBsjdya42rj3qozSfZj1z1Xp12RwLwjJs3BmB509JxKcMri88zM7UExReJHg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: citrix.com; dkim=none (message not signed)
 header.d=none;citrix.com; dmarc=none action=none header.from=suse.com;
Subject: Re: [PATCH v5 01/11] xen/arm: xc_domain_ioport_permission(..) not
 supported on ARM.
To: Bertrand Marquis <Bertrand.Marquis@arm.com>
CC: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>,
 Rahul Singh <Rahul.Singh@arm.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andre Przywara <Andre.Przywara@arm.com>, Ian Jackson <iwj@xenproject.org>,
 Wei Liu <wl@xen.org>, Juergen Gross <jgross@suse.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <cover.1633540842.git.rahul.singh@arm.com>
 <d292392268df2c74c4103a82ef917072643407a8.1633540842.git.rahul.singh@arm.com>
 <YWQkblfNMYEs6jI9@MacBook-Air-de-Roger.local>
 <77CF7FA5-C566-469E-B4A8-0400789890BB@arm.com>
 <YWQ6Nk3Jk+BqgkwZ@MacBook-Air-de-Roger.local>
 <53AE6E2A-01D7-41EC-9B2C-C0D596EB8D4D@arm.com>
 <YWRCxXGQIyTOAepC@MacBook-Air-de-Roger.local>
 <FEF0B03A-5AC8-4F8D-B821-191AC2EF8295@arm.com>
 <YWRnMfAi808TQ4Gt@MacBook-Air-de-Roger.local>
 <EB1CB53B-9D5A-49C5-A687-841BF94A153F@arm.com>
 <ac6d4785-ac9a-4491-26bb-c66ffe82c55b@suse.com>
 <ED8FC92F-B5EF-4473-B4A9-641C7D44859F@arm.com>
 <0744b957-1832-dff2-9ae2-b8e8534f501b@suse.com>
 <76E73DCA-1AF0-4B64-9305-6C349280A911@arm.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <808c058a-ac40-add5-cab0-dcb9ce7e70cb@suse.com>
Date: Tue, 12 Oct 2021 12:03:52 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <76E73DCA-1AF0-4B64-9305-6C349280A911@arm.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS8PR04CA0200.eurprd04.prod.outlook.com
 (2603:10a6:20b:2f3::25) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 0aeedf21-7dda-4c0b-c3d0-08d98d67992b
X-MS-TrafficTypeDiagnostic: VI1PR0401MB2335:
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS:
	<VI1PR0401MB2335418A354F255CB2D1BDA5B3B69@VI1PR0401MB2335.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	rKNDolRKJBeoeWRKDnHViEXGhZS4psLXOQ6tha4S0PZ3WZRvqus4RQxyHAuhcN47rWlJiOH595fj6hA+r99dfe81nqm+fK9PuXVIgtOTpRtYeMlJ1O7Q7R8yzeahXBOCPcIf42/XpzLvcXWyyLmKv9S3NMTOyLeQvgnIfizFGyFYFmH90gtzy7t2brGkgmQj2ZYAFdLMJQmpbulSqKMnvuE3Upn0Z8x7QWzkrdMC0OrzaTS5PKRyseo6slL7/13g5rJMF2M7xPgd/wvvi1vqfZrQhW1UQUPfApIFRnNoEIPofB3fSD+0lEitiJE8Yn3YBn8x/vHr/1Ta/IQnDNOKKDkwaDDMrsSOnedbBGPRqcc9tGUHhHW6x6NhoMK3U1doYgH99fK42oNwJRYDyGwRlYb/KFyvuVh3NhkdsSj+zvaJXadRmGAYAWfaWG/s2LXptiKa2AZhNB5rK49BTKY+wq/uVXsx4yrYjR++eWxnsoR0HbGkBNZU6VWfuVbg6wCs7uDllqxBd+bvALwHzMem767ofM15pF0XNGmYY1Avn6NcBofOeS73Ae4Ga6SfwSS/zW/IqMtDMIgmROWG5tofhraxvhvjqbqo4K7ESrQBR1Tb+AeW/umYrExgYwAZrOyiAq1KSu5w/6/Cv1DGnEM8+iEPNv5RqKdCJiF2BoeK5nQqcQqizGjtUMJHsAzY0qIlIVQEvPAuv/aZJFnNXMgmQm5KuRaT7wbU5FLgskNHS3I=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(16576012)(54906003)(53546011)(4326008)(5660300002)(956004)(83380400001)(2616005)(316002)(6486002)(86362001)(38100700002)(8676002)(6916009)(8936002)(508600001)(66476007)(36756003)(66556008)(66946007)(26005)(31686004)(2906002)(186003)(31696002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?VO5+QGaYDDbtv5nwmSJ1wM/gs7CAL9X9UWszPMVafcg6XuEvgoqizuXrCICK?=
 =?us-ascii?Q?dO/GaXrwRhI8MRPECjUwd8vYATa4Z8nEXlH0RSfAhwlF2I3FYebs/8bcFSDu?=
 =?us-ascii?Q?WoMZKoKqeRiAWR59AJ1g6cRgY1M8t9/w/ZzZRMKiODwkyoqNNqOwf+BiFsIL?=
 =?us-ascii?Q?MMugHzhQvwFtKMeyqS68RIOQcMNormK7IHJHK4+p0UYjppHQGmFekhMQmg7V?=
 =?us-ascii?Q?OMbZo7bBivssp+q3Tq8F+3G6isAPEfyyGUAZCFfIaW9a6qDktOCzGBf3cd7C?=
 =?us-ascii?Q?c90U3iEKmuKtNc/htCAL8W1F+An/ua/YI/+T7XISKcKKuO2uLDmifpQQR/wj?=
 =?us-ascii?Q?rZFTabYj7h33/Mj6s3yNJ/6H7eIkFa0aIwe+a3LUoIV4q9B3L7+k/WMGtZQR?=
 =?us-ascii?Q?ZrBQ5kyNevmI4paF1n5WVmuHGF3Tip4T5HH/wAkAnUI5nq2gd7xzIdvDZtVZ?=
 =?us-ascii?Q?nd4Vg8MpTT1aPMg0PrLE728T0KPrAotPKCPg3ba9mumpagDVvQOK75zYD0++?=
 =?us-ascii?Q?4A7meuquwwrx3yMxN0PmDvZCWnz2DA1ue9M99AMkeJrUL6USkGkBjoKI/RUP?=
 =?us-ascii?Q?H6uxHU9vppru76gbz+8DkdFPug8Q66nPxEjgC5OBGwYF0Y5vWUGFjn+0wCCh?=
 =?us-ascii?Q?DB1CTX03wOAPGMnIbeA/oNlZpyz6ePluiyf62GDzOwP0Tt2DB6tIO5Iz1vdy?=
 =?us-ascii?Q?SZOabOCaJW5mo2K7NDqcSKq+0P84e9qvCQPLnRpn8hAtBB4vAeDZu72qEt7Q?=
 =?us-ascii?Q?gOVlCzZ9icDhLst7zIuUtaLgFOKAAJCjh/inqse0IYuYFOPUcDfcV8RpFsJk?=
 =?us-ascii?Q?hHY32rbzVOzwOCPY06OoYEtHwlQAXVgWm3gPmz3yBer7ARNv1rPSNYw3/xqd?=
 =?us-ascii?Q?/1wILpwhkvXSi1as1GijnrAOmoGKzJTokmHfYXULM1Gn6Ugsl6J8ogeqzfoZ?=
 =?us-ascii?Q?UGDDAzM4ojsqVjjTx8pvnm7KlBx9RhYjm16IcTF13szESaTeyOjQxXZfdN5k?=
 =?us-ascii?Q?Q/KkzCnmYipLceuruz1cx9wnnf5KgePi/AWiS4I8XLdo/gR5jAKQ8TiuzV3O?=
 =?us-ascii?Q?b2XKH3HjsAJaQagoYG55wos8xDfO2eZC3L3uoA3jNwdkeIETv6Ftbe7CefYv?=
 =?us-ascii?Q?8XZWGK9RJ9R8cmr9GR5lZJ3a/y6B+CtFTA6gt2LFfXzcAF2z/trYocM47q3Z?=
 =?us-ascii?Q?830BksPu388e8pB88ZQsmtSdH0Qn4hU7J2Gj5n4zvpoVoamY7bcAcCgFtEUW?=
 =?us-ascii?Q?GB2aG1Aa5HKUBiy2iQASjXOV/COOdq1PHvgz/dBXh3pGlPXdXiXWZcMVOus7?=
 =?us-ascii?Q?uhO7gGDcgO1aGj4g5Cud3uTp?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0aeedf21-7dda-4c0b-c3d0-08d98d67992b
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2021 10:03:54.1495
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: mDYhrMdRA6qhrDTpaR0DqK5vP4ID58PFMzPpUl2GFbZqohCbfXsfPeyZqSnz9BLh+icRWaBRLm0ekBCEM5ALEQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2335

On 12.10.2021 11:40, Bertrand Marquis wrote:
> Hi Jan,
>=20
>> On 12 Oct 2021, at 10:32, Jan Beulich <jbeulich@suse.com> wrote:
>>
>> On 12.10.2021 10:41, Bertrand Marquis wrote:
>>> Hi Jan,
>>>
>>>> On 12 Oct 2021, at 09:29, Jan Beulich <jbeulich@suse.com> wrote:
>>>>
>>>> On 11.10.2021 19:11, Bertrand Marquis wrote:
>>>>>> On 11 Oct 2021, at 17:32, Roger Pau Monn=C3=A9 <roger.pau@citrix.com=
> wrote:
>>>>>> On Mon, Oct 11, 2021 at 02:16:19PM +0000, Bertrand Marquis wrote:
>>>>>>>> On 11 Oct 2021, at 14:57, Roger Pau Monn=C3=A9 <roger.pau@citrix.c=
om> wrote:
>>>>>>>> I think the commit message needs to at least be expanded in order =
to
>>>>>>>> contain the information provided here. It might also be helpful to
>>>>>>>> figure out whether we would have to handle IO port accesses in the
>>>>>>>> future on Arm, or if it's fine to just ignore them.
>>>>>>>
>>>>>>> All our investigations and tests have been done without supporting =
it
>>>>>>> without any issues so this is not a critical feature (most devices =
can
>>>>>>> be operated without using the I/O ports).
>>>>>>
>>>>>> IMO we should let the users know they attempted to use a device with
>>>>>> BARs in the IO space, and that those BARs won't be accessible which
>>>>>> could make the device not function as expected.
>>>>>>
>>>>>> Do you think it would be reasonable to attempt the hypercall on Arm
>>>>>> also, and in case of error (on Arm) just print a warning message and
>>>>>> continue operations as normal?
>>>>>
>>>>> I think this would lead to a warning printed on lots of devices where=
 in
>>>>> fact there would be no issues.
>>>>>
>>>>> If this is an issue for a device driver because it cannot operate wit=
hout
>>>>> I/O ports, this will be raised by the driver inside the guest.
>>>>
>>>> On what basis would the driver complain? The kernel might know of
>>>> the MMIO equivalent for ports, and hence might allow the driver
>>>> to properly obtain whatever is needed to later access the ports.
>>>> Just that the port accesses then wouldn't work (possibly crashing
>>>> the guest, or making it otherwise misbehave).
>>>
>>> As ECAM and Arm does not support I/O ports, a driver requesting access
>>> to them would get an error back.
>>> So in practice it is not possible to try to access the ioports as there=
 is no
>>> way on arm to use them (no instructions).
>>>
>>> A driver could misbehave by ignoring the fact that ioports are not ther=
e but
>>> I am not quite sure how we could solve that as it would be a bug in the=
 driver.
>>
>> The minimal thing I'd suggest (or maybe you're doing this already)
>> would be to expose such BARs to the guest as r/o zero, rather than
>> letting their port nature "shine through".
>=20
> We are emulating an ECAM PCI which does not support I/O ports so I do not
> think we are (and can) expose those to guests.

I'm afraid I don't follow: What do you mean by "expose to guests" in
relation to what I've said? I did specifically suggest to hide the real
nature of such BARs, and instead surface them such that the guest would
have to conclude the BAR is actually not in use at all.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Oct 12 10:06:17 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 10:06:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.207053.362792 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maEfo-0006lK-00; Tue, 12 Oct 2021 10:06:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 207053.362792; Tue, 12 Oct 2021 10:06:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maEfn-0006lD-SU; Tue, 12 Oct 2021 10:06:15 +0000
Received: by outflank-mailman (input) for mailman id 207053;
 Tue, 12 Oct 2021 10:06:14 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=fUjJ=PA=epam.com=prvs=091947bc67=oleksandr_andrushchenko@srs-us1.protection.inumbo.net>)
 id 1maEfm-0006l5-QK
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 10:06:14 +0000
Received: from mx0a-0039f301.pphosted.com (unknown [148.163.133.242])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 072fc9e9-2b44-11ec-811d-12813bfff9fa;
 Tue, 12 Oct 2021 10:06:13 +0000 (UTC)
Received: from pps.filterd (m0174676.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 19C9wv39004055; 
 Tue, 12 Oct 2021 10:06:07 GMT
Received: from eur03-ve1-obe.outbound.protection.outlook.com
 (mail-ve1eur03lp2051.outbound.protection.outlook.com [104.47.9.51])
 by mx0a-0039f301.pphosted.com with ESMTP id 3bn874g11p-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Tue, 12 Oct 2021 10:06:07 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by AM4PR0302MB2660.eurprd03.prod.outlook.com (2603:10a6:200:93::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.20; Tue, 12 Oct
 2021 10:06:04 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::b034:334a:abf5:223c]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::b034:334a:abf5:223c%7]) with mapi id 15.20.4587.026; Tue, 12 Oct 2021
 10:06:04 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 072fc9e9-2b44-11ec-811d-12813bfff9fa
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=d/OPV1dJ4KnMjkycXbxXo7gMG5I2TWoXJWSA9d2ScmiicElIrD+M/m6f/vCcKs/p18q9JlMid7bXKIHJCRY8mYYMybJ4qa7IUgE4u+dMmwF9nOviTQJyN3RNMQfN78tLWc3NyXLooyK+DiBykQXrjlDkUOdzesYr/UbIVql3nqus7E478FHXzPG3DOEmkSEY1GxbBaQpIpVTZwM4MkOOir5IPYGScWoAIfZ6TqQC/hUpUmpy5qmkC5LK1L9trG0nV48tyoO6S89uZ+7iXp5h+rXdCbuVXL7jNCk+IKIA0jx4bzzNJ5nMznnr01oQ0/p4I+5MKWZDOqlXr9jNAmCx7A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=bAAKj+mjbcLNrefHOaYAJNKi82rGpZcHncXHCee6OO0=;
 b=KgVVulVSGxX0njJG+7JxyVlwsenhk70fC7KD6rSemqBleQcbRIbzTRyznOm8EIdarHC1SF3+xDPNp2aCPahnMqkoZQDXGWF8dOD70qRg2+B2RCGLQ8XTf+jvpL+oLtkQRe+CIo9Ef95wxxPe7Nw6V6Kg7VSjxrBQGHC50H+SjSZ9UBuNliBPJ1fZf/J7u5ZlkJz+aQfYiLEkIK5nZAWlFG0OaHJZMVz/LCfS+TY1sZZT2S1WuSuAYDxnUMGQ9mghP1VxyxDNzI7pvKZqA4v++Ofpq2Be/xztMB/G0YSr6mdlUBxFwdhYhx4HH4yFcxk67AiiNpKKcxI9A3b31ULIag==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=bAAKj+mjbcLNrefHOaYAJNKi82rGpZcHncXHCee6OO0=;
 b=bjCyJxL9jhlIhLLnPpZZUV5vB9OFbullmFzjMFuqd09cXhI//pLRy1dyxqYzmH0cdZcKgxv69rJ2q1AoD7ystq3UO7xI0xp6FoJ8J9r04aQvJOorHoRmIGQG+k3ynlu1nhkPgzghMu7Unx6YWDe2imkrG1ExkkRahGlPq5qHZGg60ZAkSjGWTf13wdjkI8uZnTwzwNXym/QKvWMkKw7B6cMK/PkNBEmP5xPQoKedt8MkmH80BXUjy+QIWbNwMhvHU/NvBqQwP7rVDJjSboPDYtMQ76b+K/Zc8fmSYC8w75izelBhSiw++D/HgZ5qTvpCFSx1udhrHmYT/jf1zCHcdg==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Jan Beulich <jbeulich@suse.com>,
        Bertrand Marquis
	<bertrand.marquis@arm.com>
CC: Rahul Singh <rahul.singh@arm.com>,
        "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>,
        Andre Przywara <Andre.Przywara@arm.com>,
        Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>,
        Juergen Gross
	<jgross@suse.com>,
        Stefano Stabellini <sstabellini@kernel.org>,
        =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>,
        Oleksandr
 Andrushchenko <Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH v5 01/11] xen/arm: xc_domain_ioport_permission(..) not
 supported on ARM.
Thread-Topic: [PATCH v5 01/11] xen/arm: xc_domain_ioport_permission(..) not
 supported on ARM.
Thread-Index: 
 AQHXutl5d8zkP9bsD0GXT4+5QPGclKvNtfkAgAAGc4CAABOEAIAABXoAgAAEuYCAAAVHAIAAJiWAgAAK0ICAAQCPgIAAA0qAgAAOJYCAAAHCAIAABnQAgAABQgA=
Date: Tue, 12 Oct 2021 10:06:04 +0000
Message-ID: <c6b6c22f-fb8a-f2d9-7735-f1ebc9809908@epam.com>
References: <cover.1633540842.git.rahul.singh@arm.com>
 <d292392268df2c74c4103a82ef917072643407a8.1633540842.git.rahul.singh@arm.com>
 <YWQkblfNMYEs6jI9@MacBook-Air-de-Roger.local>
 <77CF7FA5-C566-469E-B4A8-0400789890BB@arm.com>
 <YWQ6Nk3Jk+BqgkwZ@MacBook-Air-de-Roger.local>
 <53AE6E2A-01D7-41EC-9B2C-C0D596EB8D4D@arm.com>
 <YWRCxXGQIyTOAepC@MacBook-Air-de-Roger.local>
 <FEF0B03A-5AC8-4F8D-B821-191AC2EF8295@arm.com>
 <YWRnMfAi808TQ4Gt@MacBook-Air-de-Roger.local>
 <EB1CB53B-9D5A-49C5-A687-841BF94A153F@arm.com>
 <ac6d4785-ac9a-4491-26bb-c66ffe82c55b@suse.com>
 <ED8FC92F-B5EF-4473-B4A9-641C7D44859F@arm.com>
 <0744b957-1832-dff2-9ae2-b8e8534f501b@suse.com>
 <c3952fd5-b893-4cb6-a9bc-325a89e859db@epam.com>
 <c125b447-53e8-7d13-3b08-af62fd3a9140@suse.com>
In-Reply-To: <c125b447-53e8-7d13-3b08-af62fd3a9140@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
authentication-results: suse.com; dkim=none (message not signed)
 header.d=none;suse.com; dmarc=none action=none header.from=epam.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 6dd36193-3e06-4d3b-348e-08d98d67e704
x-ms-traffictypediagnostic: AM4PR0302MB2660:
x-ms-exchange-transport-forked: True
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <AM4PR0302MB26606F7B759C0610224597EAE7B69@AM4PR0302MB2660.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 alwr5lus+WgFbERXDLIOXS5tCUHtc7HTHRzl9a94tVJdE3xzVewUIreFa27akoU8imF5n8JsQyxEzbBpWxDJlMB4aRGSDfwNTM/Pnq6uuXL0Ape8V0dL2eT9i817d7DeMoWncFcfXjbA312R9de8Wnd2JJkA1UcdcfcLHYV5MmKaGopAfEnJ6Vmkv3wYZsW7SNWOL4HsPApWctMg7ClL0O7EJfwpSZKru5WlLESqS6n1KmK6sCMS0VW1zNA1n//a/WGGCcL/jKl7NQi0aapX88Y+nCrfvTeXAAWILfRxOdYAzj5aMFqPrCsduROhsqjWp+b9h4epgJJ0ZS+VKbm7gj73zpXmjJw6CAuPjIvdw9A22zajpMtfXnpyNku8ZvQP4ERIrtAxB6qyH2ndQmcAZRRjQvAk1w8TGMauYcD6R8UmTJl/yi2N9GlQvkHIXqjtbhHCv7NONHK4F05Sh15GVBp8Tun/dM7V1+yoguVtWm6vWBKl/ginGs5B2H5rFrORlDeaxhP52I3D6ZekdoHIaurld2EBsu7C8A++tWep8bdkLl08TZDyacMO5A1NajImmudnxKqqewwYjppFQ3m53qN0odajG0eWM/Ql8Q0rd0Rec7xvr9acc4MvWm+eUCGdGFCZwBFfqdxjtUqj+cnJ/YI4HnkbsoaLGjgwkMQXTH5oto7lOyNg7sXBLghf+mL3JrgoLXUie+RwPEVfXqSqEUZmExUoh/kAd9C2TlPSLHNcdjnmZ3zKsRhvvMD2CVVc
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(38070700005)(316002)(36756003)(31696002)(86362001)(122000001)(54906003)(110136005)(38100700002)(31686004)(508600001)(8676002)(4326008)(2906002)(5660300002)(53546011)(6506007)(7416002)(66556008)(66446008)(83380400001)(107886003)(6512007)(76116006)(66476007)(91956017)(26005)(2616005)(8936002)(64756008)(71200400001)(6486002)(55236004)(186003)(66946007)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?eVllY3lLVitXSDl0cXNqUWUvbklpa295T1N5SHRid0xjU2hmRE42dzh5WEky?=
 =?utf-8?B?VkYvaUNLdWpMK1kvZWhrcjdYaS8wemNPdlN1aGhadTlteUU3YWpaUWYybGor?=
 =?utf-8?B?RGdOZVkyVDVzaGE0ZXFYTHUzazhrdTdhYzZxRDNtQ3ZnYjJWZkpSTVhXdFJ3?=
 =?utf-8?B?VVZzREpuWUQ0NldRamJIUUNkY0JxK0U2eC9Pb1JrZEIzL0dTVDB6UDgvcFp1?=
 =?utf-8?B?TDJiZUpUZjV6RlovZlFpVjFjaEJXazZvcHlYUldPRXQ4NUN4bXdGK1F1MWl2?=
 =?utf-8?B?Z21oaTJtUzNYZzBNeEx1djY2UnFlei9EVVVXTWhJR2J0Yy9OVFdMVWJIL0hz?=
 =?utf-8?B?Zzg0Mmw0aWk5Y1pCVmpDVTlHTytHSGpOYm1nN0ZNRmlXbHBjY013ODQ0dk83?=
 =?utf-8?B?NWhSbkJUMlZPYVlQL1JUc1l4T0tRN3BRL2tzbTlGZUdzNXltaTI0WmhpWkJM?=
 =?utf-8?B?MFZIdHY3cGR0UlIzczJQcjQyZnVCNTlXN3dOblNHWUJMbE4wdjI3R3F2L3Ew?=
 =?utf-8?B?YmhCZUlxalp5blpDcUJlZmp1YTk3T0NIOTN0WTFSMG5wMURMNkFuTDhlanBo?=
 =?utf-8?B?Z3YxNHBBb0l2L2lwVHplNWxxVE01MXFZRm0yTUQvSDVRMUYvbTdkRjQ4THkx?=
 =?utf-8?B?QzloZVJyQTdOemFBcUpIMjhhSGx0OGp4UVVWWkFqdHQybEh5NEpjYWlxSnZ5?=
 =?utf-8?B?OGQ3c1RiVm5yN0laV2kvMlB5MWxTb2tDUndzM1FSS25EdzBoUWtacXdVZHF4?=
 =?utf-8?B?Um5NSmEvYTl6WjI4WUZ1enk5djZlaTdPU2RBZ1hWSVM5cEZYWVc2YUNYOE9a?=
 =?utf-8?B?RlZ0WGk1SHBjRFV2dTlZTVdBU05SU2RyM1VXbjBXcFFZZHl5a3RWaVYrS2VJ?=
 =?utf-8?B?UlAzWEJGcWZDR3EvNkFSQkVIcXVHZTVHVGp5bnVsWjRHa2dSVVRCcnZ6K0di?=
 =?utf-8?B?S3h0Z3NJZ1hsTWZwd1NYVEJTODVneStOeUNhYkFCOVhRa1VCRGFER1pMaEcv?=
 =?utf-8?B?cWdqbU5VTFZhSTVDZ2xWSUJpNWd5eDEwMU1OTHVnS0lCSGF5dFhLTHd0VFM5?=
 =?utf-8?B?QTZ6aHRHNnpjcmlBTmFLTDBrendrb25VVVQwUm4vSDA2SGpnQzN5UlptUUdE?=
 =?utf-8?B?OWJIZy9WNjlSdnNUMFhxb1B0RC80cDVaNXJjVWtkQ0JKb3dQNmV2VkJxUUZI?=
 =?utf-8?B?QWIrUkVjVmFzb3d2eVdDMVM4bU5wZHVTWVljWlBnWGdPTUFVbU4yK2pKVW5H?=
 =?utf-8?B?RXZuNEdTRmVyRE5TZSt6UVpjbWx6MnJZYWlHSXFqd2M1RGNmOU1WMVg5WXVU?=
 =?utf-8?B?aWdMSkNkcytrTDhlNERVaTdQWFFOdy9vTk9YNEJESFR5ak5mZHYxV1RGTzBP?=
 =?utf-8?B?TUVWczJsWC93TWZVS0drL0ROY0RHczRJTWJNdEg2SXIza2U5WEFzWTZyTzNZ?=
 =?utf-8?B?NVpzdXVSenVnbWcrcWZ0aHl3ZVlPbktNd3FYc3lhZnB2TlFOd2tQRFFzWnha?=
 =?utf-8?B?Wks4VjdIbFZETDhBZFE4S2lUcU1vRnV0NjJpa2g1ZFhuNzdxeFp3OWNLVFJG?=
 =?utf-8?B?bTZwKzBEVHdWNDFXNmZJdVJTQU14RUtoTnlCaXRXK1FSTXovMGhYc2t6akRD?=
 =?utf-8?B?dUUyRXJ1L1V0MmRRSmtma2w3UlZFR1pibWdGVmJPa0lmUFB0bnlsaENJZDg3?=
 =?utf-8?B?a1JFL1UybzlSN3dSd0JOQzM4NlVRWHBycndFZ3ZYdkdWeW5XYUk1WFNGNE9T?=
 =?utf-8?B?NWViNFM5SEUrUE1kMDNQZWJzVFZLYjIvUDRBNm5uOU9qMXNuYURCRTR4TGtx?=
 =?utf-8?B?WmpBNXdrZWtUY3ZHRVhzQT09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <B87EFEA16AA2814C9F754E79DB035BB3@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6dd36193-3e06-4d3b-348e-08d98d67e704
X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Oct 2021 10:06:04.5461
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: N8q8rowZknW+ZSWPqQszMoLRl8pVWA3XrPo7vTPUQMEbbcROvP/68QFSTGErhYMVtZmawHymIpP/ktkRQK6y7I07j4QgX7mNn2nKylu2SfvIVGFGEyCB5nxyUs1Yl8SP
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR0302MB2660
X-Proofpoint-GUID: LADBQw8Qs791kq-3U0Uhdxlra9IXLqV8
X-Proofpoint-ORIG-GUID: LADBQw8Qs791kq-3U0Uhdxlra9IXLqV8
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475
 definitions=2021-10-12_02,2021-10-11_01,2020-04-07_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 spamscore=0
 phishscore=0 clxscore=1015 lowpriorityscore=0 suspectscore=0 mlxscore=0
 mlxlogscore=999 malwarescore=0 priorityscore=1501 adultscore=0 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109230001
 definitions=main-2110120057

DQoNCk9uIDEyLjEwLjIxIDEzOjAxLCBKYW4gQmV1bGljaCB3cm90ZToNCj4gT24gMTIuMTAuMjAy
MSAxMTozOCwgT2xla3NhbmRyIEFuZHJ1c2hjaGVua28gd3JvdGU6DQo+PiBPbiAxMi4xMC4yMSAx
MjozMiwgSmFuIEJldWxpY2ggd3JvdGU6DQo+Pj4gT24gMTIuMTAuMjAyMSAxMDo0MSwgQmVydHJh
bmQgTWFycXVpcyB3cm90ZToNCj4+Pj4+IE9uIDEyIE9jdCAyMDIxLCBhdCAwOToyOSwgSmFuIEJl
dWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPiB3cm90ZToNCj4+Pj4+IE9uIDExLjEwLjIwMjEgMTk6
MTEsIEJlcnRyYW5kIE1hcnF1aXMgd3JvdGU6DQo+Pj4+Pj4+IE9uIDExIE9jdCAyMDIxLCBhdCAx
NzozMiwgUm9nZXIgUGF1IE1vbm7DqSA8cm9nZXIucGF1QGNpdHJpeC5jb20+IHdyb3RlOg0KPj4+
Pj4+PiBPbiBNb24sIE9jdCAxMSwgMjAyMSBhdCAwMjoxNjoxOVBNICswMDAwLCBCZXJ0cmFuZCBN
YXJxdWlzIHdyb3RlOg0KPj4+Pj4+Pj4+IE9uIDExIE9jdCAyMDIxLCBhdCAxNDo1NywgUm9nZXIg
UGF1IE1vbm7DqSA8cm9nZXIucGF1QGNpdHJpeC5jb20+IHdyb3RlOg0KPj4+Pj4+Pj4+IEkgdGhp
bmsgdGhlIGNvbW1pdCBtZXNzYWdlIG5lZWRzIHRvIGF0IGxlYXN0IGJlIGV4cGFuZGVkIGluIG9y
ZGVyIHRvDQo+Pj4+Pj4+Pj4gY29udGFpbiB0aGUgaW5mb3JtYXRpb24gcHJvdmlkZWQgaGVyZS4g
SXQgbWlnaHQgYWxzbyBiZSBoZWxwZnVsIHRvDQo+Pj4+Pj4+Pj4gZmlndXJlIG91dCB3aGV0aGVy
IHdlIHdvdWxkIGhhdmUgdG8gaGFuZGxlIElPIHBvcnQgYWNjZXNzZXMgaW4gdGhlDQo+Pj4+Pj4+
Pj4gZnV0dXJlIG9uIEFybSwgb3IgaWYgaXQncyBmaW5lIHRvIGp1c3QgaWdub3JlIHRoZW0uDQo+
Pj4+Pj4+PiBBbGwgb3VyIGludmVzdGlnYXRpb25zIGFuZCB0ZXN0cyBoYXZlIGJlZW4gZG9uZSB3
aXRob3V0IHN1cHBvcnRpbmcgaXQNCj4+Pj4+Pj4+IHdpdGhvdXQgYW55IGlzc3VlcyBzbyB0aGlz
IGlzIG5vdCBhIGNyaXRpY2FsIGZlYXR1cmUgKG1vc3QgZGV2aWNlcyBjYW4NCj4+Pj4+Pj4+IGJl
IG9wZXJhdGVkIHdpdGhvdXQgdXNpbmcgdGhlIEkvTyBwb3J0cykuDQo+Pj4+Pj4+IElNTyB3ZSBz
aG91bGQgbGV0IHRoZSB1c2VycyBrbm93IHRoZXkgYXR0ZW1wdGVkIHRvIHVzZSBhIGRldmljZSB3
aXRoDQo+Pj4+Pj4+IEJBUnMgaW4gdGhlIElPIHNwYWNlLCBhbmQgdGhhdCB0aG9zZSBCQVJzIHdv
bid0IGJlIGFjY2Vzc2libGUgd2hpY2gNCj4+Pj4+Pj4gY291bGQgbWFrZSB0aGUgZGV2aWNlIG5v
dCBmdW5jdGlvbiBhcyBleHBlY3RlZC4NCj4+Pj4+Pj4NCj4+Pj4+Pj4gRG8geW91IHRoaW5rIGl0
IHdvdWxkIGJlIHJlYXNvbmFibGUgdG8gYXR0ZW1wdCB0aGUgaHlwZXJjYWxsIG9uIEFybQ0KPj4+
Pj4+PiBhbHNvLCBhbmQgaW4gY2FzZSBvZiBlcnJvciAob24gQXJtKSBqdXN0IHByaW50IGEgd2Fy
bmluZyBtZXNzYWdlIGFuZA0KPj4+Pj4+PiBjb250aW51ZSBvcGVyYXRpb25zIGFzIG5vcm1hbD8N
Cj4+Pj4+PiBJIHRoaW5rIHRoaXMgd291bGQgbGVhZCB0byBhIHdhcm5pbmcgcHJpbnRlZCBvbiBs
b3RzIG9mIGRldmljZXMgd2hlcmUgaW4NCj4+Pj4+PiBmYWN0IHRoZXJlIHdvdWxkIGJlIG5vIGlz
c3Vlcy4NCj4+Pj4+Pg0KPj4+Pj4+IElmIHRoaXMgaXMgYW4gaXNzdWUgZm9yIGEgZGV2aWNlIGRy
aXZlciBiZWNhdXNlIGl0IGNhbm5vdCBvcGVyYXRlIHdpdGhvdXQNCj4+Pj4+PiBJL08gcG9ydHMs
IHRoaXMgd2lsbCBiZSByYWlzZWQgYnkgdGhlIGRyaXZlciBpbnNpZGUgdGhlIGd1ZXN0Lg0KPj4+
Pj4gT24gd2hhdCBiYXNpcyB3b3VsZCB0aGUgZHJpdmVyIGNvbXBsYWluPyBUaGUga2VybmVsIG1p
Z2h0IGtub3cgb2YNCj4+Pj4+IHRoZSBNTUlPIGVxdWl2YWxlbnQgZm9yIHBvcnRzLCBhbmQgaGVu
Y2UgbWlnaHQgYWxsb3cgdGhlIGRyaXZlcg0KPj4+Pj4gdG8gcHJvcGVybHkgb2J0YWluIHdoYXRl
dmVyIGlzIG5lZWRlZCB0byBsYXRlciBhY2Nlc3MgdGhlIHBvcnRzLg0KPj4+Pj4gSnVzdCB0aGF0
IHRoZSBwb3J0IGFjY2Vzc2VzIHRoZW4gd291bGRuJ3Qgd29yayAocG9zc2libHkgY3Jhc2hpbmcN
Cj4+Pj4+IHRoZSBndWVzdCwgb3IgbWFraW5nIGl0IG90aGVyd2lzZSBtaXNiZWhhdmUpLg0KPj4+
PiBBcyBFQ0FNIGFuZCBBcm0gZG9lcyBub3Qgc3VwcG9ydCBJL08gcG9ydHMsIGEgZHJpdmVyIHJl
cXVlc3RpbmcgYWNjZXNzDQo+Pj4+IHRvIHRoZW0gd291bGQgZ2V0IGFuIGVycm9yIGJhY2suDQo+
Pj4+IFNvIGluIHByYWN0aWNlIGl0IGlzIG5vdCBwb3NzaWJsZSB0byB0cnkgdG8gYWNjZXNzIHRo
ZSBpb3BvcnRzIGFzIHRoZXJlIGlzIG5vDQo+Pj4+IHdheSBvbiBhcm0gdG8gdXNlIHRoZW0gKG5v
IGluc3RydWN0aW9ucykuDQo+Pj4+DQo+Pj4+IEEgZHJpdmVyIGNvdWxkIG1pc2JlaGF2ZSBieSBp
Z25vcmluZyB0aGUgZmFjdCB0aGF0IGlvcG9ydHMgYXJlIG5vdCB0aGVyZSBidXQNCj4+Pj4gSSBh
bSBub3QgcXVpdGUgc3VyZSBob3cgd2UgY291bGQgc29sdmUgdGhhdCBhcyBpdCB3b3VsZCBiZSBh
IGJ1ZyBpbiB0aGUgZHJpdmVyLg0KPj4+IFRoZSBtaW5pbWFsIHRoaW5nIEknZCBzdWdnZXN0IChv
ciBtYXliZSB5b3UncmUgZG9pbmcgdGhpcyBhbHJlYWR5KQ0KPj4+IHdvdWxkIGJlIHRvIGV4cG9z
ZSBzdWNoIEJBUnMgdG8gdGhlIGd1ZXN0IGFzIHIvbyB6ZXJvLCByYXRoZXIgdGhhbg0KPj4+IGxl
dHRpbmcgdGhlaXIgcG9ydCBuYXR1cmUgInNoaW5lIHRocm91Z2giLg0KPj4gSWYgd2UgaGF2ZSB0
aGUgc2FtZSwgYnV0IGJhcmVtZXRhbCB0aGVuIHdoaWNoIGVudGl0eSBkaXNhbGxvd3MNCj4+IHRo
b3NlIEJBUnMgdG8gc2hpbmU/DQo+IEknbSBzb3JyeSwgYnV0IEkgZG9uJ3QgdW5kZXJzdGFuZCB3
aGF0IHlvdSdyZSB0cnlpbmcgdG8gc2F5Lg0KPg0KPj4gSSBtZWFuIHRoYXQgaWYgZ3Vlc3Qgd2Fu
dHMgdG8gY3Jhc2guLi4gd2h5DQo+PiBzaG91bGQgd2Ugc3RvcCBpdCBhbmQgdHJ5IGVtdWxhdGlu
ZyBzb21ldGhpbmcgc3BlY2lhbCBmb3IgaXQ/DQo+IFRoaXMgaXNuJ3QgYWJvdXQgYSBndWVzdCAi
d2FudGluZyB0byBjcmFzaCIsIGJ1dCBhIGRyaXZlciBwb3RlbnRpYWxseQ0KPiBnZXR0aW5nIG1p
c2xlYWQgaW50byB0aGlua2luZyB0aGF0IGl0IGNhbiBkcml2ZXIgYSBkZXZpY2UgYSBjZXJ0YWlu
DQo+IHdheS4NCldlbGwsIGZvciB0aGUgZ3Vlc3QsIGFzIHdlIGRvIG5vdCBhZHZlcnRpc2UgSU8g
aW4gdGhlIGVtdWxhdGVkIGhvc3QNCmJyaWRnZSwgdGhlIGRyaXZlciB3b24ndCBiZSBhYmxlIHRv
IGFsbG9jYXRlIGFueSBJTyBhdCBhbGwuIFRodXMsIGV2ZW4NCmlmIHdlIGhhdmUgYSBCQVIgd2l0
aCBQQ0lfQkFTRV9BRERSRVNTX1NQQUNFX0lPIGJpdCBzZXQsIHRoZQ0KZHJpdmVyIHdvbid0IGdl
dCBhbnl0aGluZy4gU28sIEkgdGhpbmsgdGhpcyBpcyBlcXVpdmFsZW50IHRvIGEgYmFyZW1ldGFs
DQp1c2UtY2FzZSB3aGVyZSB3ZSBoYXZlIG5vIElPIHN1cHBvcnRlZCBieSB0aGUgaG9zdCBicmlk
Z2UgYW5kDQphIGRldmljZSB3aXRoIElPIEJBUi4NCj4NCj4gSmFuDQo+DQo=


From xen-devel-bounces@lists.xenproject.org Tue Oct 12 10:06:29 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 10:06:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.207054.362803 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maEg1-00075y-8R; Tue, 12 Oct 2021 10:06:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 207054.362803; Tue, 12 Oct 2021 10:06:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maEg1-00075r-4K; Tue, 12 Oct 2021 10:06:29 +0000
Received: by outflank-mailman (input) for mailman id 207054;
 Tue, 12 Oct 2021 10:06:28 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1maEfz-00074z-Vb; Tue, 12 Oct 2021 10:06:27 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1maEfz-0006Zw-Qz; Tue, 12 Oct 2021 10:06:27 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1maEfz-0001KX-Fw; Tue, 12 Oct 2021 10:06:27 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1maEfz-00014v-FN; Tue, 12 Oct 2021 10:06:27 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=crhx2qW69nEQOQl+B4+2BomPPocjYsmB9TejV2iSG6s=; b=Pwrm9ay8PhJ3CfJZQk8EIjXK8T
	TYLzdyRFK2DsCDlfIM3TsrD383jTvRE9arN7f9Ie/Ad3ad9Eq8Rq/pECQbJb5vOtlkRe5yAjjzrgB
	q5j6IRFWQoRzuj7oT1rbheJxUqI7bnv1Mq0URR7O3zHkbqGcR6lYAKacfrMffsPcDL1g=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165469-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-5.4 test] 165469: regressions - FAIL
X-Osstest-Failures:
    linux-5.4:test-armhf-armhf-xl-credit1:guest-start:fail:regression
    linux-5.4:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:heisenbug
    linux-5.4:test-amd64-amd64-xl-multivcpu:guest-stop:fail:heisenbug
    linux-5.4:test-amd64-amd64-examine:memdisk-try-append:fail:heisenbug
    linux-5.4:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    linux-5.4:test-amd64-amd64-xl-rtds:guest-localmigrate:fail:heisenbug
    linux-5.4:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    linux-5.4:test-arm64-arm64-libvirt-raw:guest-start/debian.repeat:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=faaca480fd5cd1976b6db743c43ac1f8d583de72
X-Osstest-Versions-That:
    linux=e74e2950a0d6f800858e54860d7124c86e494f62
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 12 Oct 2021 10:06:27 +0000

flight 165469 linux-5.4 real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165469/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-armhf-armhf-xl-credit1  14 guest-start              fail REGR. vs. 165206

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-xl-rtds 20 guest-localmigrate/x10 fail in 165463 pass in 165449
 test-amd64-amd64-xl-multivcpu 21 guest-stop      fail in 165463 pass in 165469
 test-amd64-amd64-examine    4 memdisk-try-append fail in 165463 pass in 165469
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail in 165463 pass in 165469
 test-amd64-amd64-xl-rtds     18 guest-localmigrate         fail pass in 165463
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 165463

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-libvirt-raw 17 guest-start/debian.repeat fail in 165449 like 165206
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165206
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 165206
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 165206
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 165206
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165206
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165206
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 165206
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 165206
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 165206
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 165206
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 165206
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 165206
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 linux                faaca480fd5cd1976b6db743c43ac1f8d583de72
baseline version:
 linux                e74e2950a0d6f800858e54860d7124c86e494f62

Last test of basis   165206  2021-09-26 12:42:13 Z   15 days
Failing since        165346  2021-10-04 12:42:32 Z    7 days   11 attempts
Testing same since   165449  2021-10-09 23:12:14 Z    2 days    5 attempts

------------------------------------------------------------
People who touched revisions under test:
  Alan Stern <stern@rowland.harvard.edu>
  Alex Deucher <alexander.deucher@amd.com>
  Alexei Starovoitov <ast@kernel.org>
  Anand K Mistry <amistry@google.com>
  Anders Roxell <anders.roxell@linaro.org>
  Andrea Claudi <aclaudi@redhat.com>
  Andreas Larsson <andreas@gaisler.com>
  Andrej Shadura <andrew.shadura@collabora.co.uk>
  Andrew Morton <akpm@linux-foundation.org>
  Andy Shevchenko <andriy.shevchenko@linux.intel.com>
  Anirudh Rayabharam <mail@anirudhrb.com>
  Anson Jacob <Anson.Jacob@amd.com>
  Antoine Tenart <atenart@kernel.org>
  Anton Eidelman <anton.eidelman@gmail.com>
  Anton Eidelman <anton@lightbitslabs.com>
  Ariel Elior <aelior@marvell.com>
  Arnd Bergmann <arnd@arndb.de>
  Aswath Govindraju <a-govindraju@ti.com>
  Aya Levin <ayal@nvidia.com>
  Baokun Li <libaokun1@huawei.com>
  Bartosz Golaszewski <brgl@bgdev.pl>
  Bixuan Cui <cuibixuan@huawei.com>
  Bjorn Helgaas <bhelgaas@google.com>
  Borislav Petkov <bp@suse.de>
  Carlo Lobrano <c.lobrano@gmail.com>
  Catalin Marinas <catalin.marinas@arm.com>
  Changbin Du <changbin.du@gmail.com>
  Charlene Liu <Charlene.Liu@amd.com>
  Chen Jingwen <chenjingwen6@huawei.com>
  Chih-Kang Chang <gary.chang@realtek.com>
  Chris Chiu <chris.chiu@canonical.com>
  Christian Brauner <christian.brauner@ubuntu.com>
  Christoph Hellwig <hch@lst.de>
  Claudiu Manoil <claudiu.manoil@nxp.com>
  Cong Wang <cong.wang@bytedance.com>
  Dan Carpenter <dan.carpenter@oracle.com>
  Dan Li <ashimida@linux.alibaba.com>
  Dan Williams <dan.j.williams@intel.com>
  Daniel Borkmann <daniel@iogearbox.net>
  Daniel Lezcano <daniel.lezcano@linaro.org>
  Daniel Wheeler <daniel.wheeler@amd.com>
  David Howells <dhowells@redhat.com>
  David S. Miller <davem@davemloft.net>
  David Sterba <dsterba@suse.com>
  Dmitry Bogdanov <d.bogdanov@yadro.com>
  Dongliang Mu <mudongliangabcd@gmail.com>
  Eric Biggers <ebiggers@google.com>
  Eric Dumazet <edumazet@google.com>
  F.A. SULAIMAN <asha.16@itfac.mrt.ac.lk>
  F.A.Sulaiman <asha.16@itfac.mrt.ac.lk>
  Faizel K B <faizel.kb@dicortech.com>
  Fares Mehanna <faresx@amazon.de>
  Felipe Balbi <balbi@kernel.org>
  Florian Fainelli <f.fainelli@gmail.com>
  Gao Xiang <hsiangkao@linux.alibaba.com>
  Geert Uytterhoeven <geert@linux-m68k.org>
  Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  Gregory CLEMENT <gregory.clement@bootlin.com>
  Guangbin Huang <huangguangbin2@huawei.com>
  Guenter Roeck <linux@roeck-us.net>
  Hans de Goede <hdegoede@redhat.com>
  Helge Deller <deller@gmx.de>
  Herbert Xu <herbert@gondor.apana.org.au>
  Hulk Robot <hulkrobot@huawei.com>
  Igor Matheus Andrade Torrente <igormtorrente@gmail.com>
  J. Bruce Fields <bfields@redhat.com>
  Jacob Keller <jacob.e.keller@intel.com>
  James Morse <james.morse@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Jan Kara <jack@suse.cz>
  Jeffle Xu <jefflexu@linux.alibaba.com>
  Jens Axboe <axboe@kernel.dk>
  Jesper Nilsson <jesper.nilsson@axis.com>
  Jian Shen <shenjian15@huawei.com>
  Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
  Jiri Benc <jbenc@redhat.com>
  Jiri Kosina <jkosina@suse.cz>
  Jiri Slaby <jslaby@suse.cz>
  Johan Hovold <johan@kernel.org>
  Johannes Berg <johannes.berg@intel.com>
  Johannes Thumshirn <jth@kernel.org>
  John Allen <john.allen@amd.com>
  Jon Hunter <jonathanh@nvidia.com>
  Jonathan Hsu <jonathan.hsu@mediatek.com>
  Jozsef Kadlecsik <kadlec@netfilter.org>
  Juergen Gross <jgross@suse.com>
  Julian Anastasov <ja@ssi.bg>
  Julian Sikorski <belegdol+github@gmail.com>
  Julian Sikorski <belegdol@gmail.com>
  Kaige Fu <kaige.fu@linux.alibaba.com>
  Kan Liang <kan.liang@linux.intel.com>
  Karsten Graul <kgraul@linux.ibm.com>
  Kate Hsuan <hpa@redhat.com>
  Kevin Hao <haokexin@gmail.com>
  Kishon Vijay Abraham I <kishon@ti.com>
  Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
  Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
  Leon Yu <leoyu@nvidia.com>
  Li Jinlin <lijinlin3@huawei.com>
  Li Zhijian <lizhijian@cn.fujitsu.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Linux Kernel Functional Testing <lkft@linaro.org>
  Lorenzo Bianconi <lorenzo@kernel.org>
  Marc Zyngier <maz@kernel.org>
  Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
  Mark Rutland <mark.rutland@arm.com>
  Markus Suvanto <markus.suvanto@gmail.com>
  Martin K. Petersen <martin.petersen@oracle.com>
  Michael Chan <michael.chan@broadcom.com>
  Michael Chan <michael.chan@broadocm.com>
  Michal Kalderon <mkalderon@marvell.com>
  Minas Harutyunyan <Minas.Harutyunyan@synopsys.com>
  Ming Lei <ming.lei@redhat.com>
  Moritz Fischer <mdf@kernel.org>
  Nadezda Lutovinova <lutovinova@ispras.ru>
  Nicolas Ferre <nicolas.ferre@microchip.com>
  Nirmoy Das <nirmoy.das@amd.com>
  Oliver Neukum <oneukum@suse.com>
  Ondrej Zary <linux@zary.sk>
  Ovidiu Panait <ovidiu.panait@windriver.com>
  Pablo Neira Ayuso <pablo@netfilter.org>
  Pali Rohár <pali@kernel.org>
  Paolo Bonzini <pbonzini@redhat.com>
  Paul Fertser <fercerpav@gmail.com>
  Pawel Laszczak <pawell@cadence.com>
  Peter Zijlstra (Intel) <peterz@infradead.org>
  Ping-Ke Shih <pkshih@realtek.com>
  Qu Wenruo <wqu@suse.com>
  Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
  Randy Dunlap <rdunlap@infradead.org>
  Rik van Riel <riel@surriel.com>
  Ritesh Harjani <riteshh@linux.ibm.com>
  Rob Herring <robh@kernel.org>
  Ronnie Sahlberg <lsahlber@redhat.com>
  Sai Krishna Potthuri <lakshmi.sai.krishna.potthuri@xilinx.com>
  Samuel Iglesias Gonsalvez <siglesias@igalia.com>
  Sasha Levin <sashal@kernel.org>
  Sergey Senozhatsky <senozhatsky@chromium.org>
  Shai Malin <smalin@marvell.com>
  Shuah Khan <skhan@linuxfoundation.org>
  Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
  Simon Horman <horms@verge.net.au>
  Slark Xiao <slark_xiao@163.com>
  Song Liu <songliubraving@fb.com>
  Srinivas Pandruvada <srinivas.pI andruvada@linux.intel.com>
  Steve French <stfrench@microsoft.com>
  Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
  sumiyawang <sumiyawang@tencent.com>
  syzbot+47b26cd837ececfc666d@syzkaller.appspotmail.com
  syzbot+fadc0aaf497e6a493b9f@syzkaller.appspotmail.com
  Tariq Toukan <tariqt@nvidia.com>
  Tejun Heo <tj@kernel.org>
  Theodore Ts'o <tytso@mit.edu>
  Todd Kjos <tkjos@google.com>
  Tom Rix <trix@redhat.com>
  Tong Zhang <ztong0001@gmail.com>
  Tony Nguyen <anthony.l.nguyen@intel.com>
  Tyler Hicks <tyhicks@linux.microsoft.com>
  Uwe Brandt <uwe.brandt@gmail.com>
  Vadim Pasternak <vadimp@nvidia.com>
  Viresh Kumar <viresh.kumar@linaro.org>
  Vlad Buslov <vladbu@nvidia.com>
  Vladimir Oltean <vladimir.oltean@nxp.com>
  Wen Xiong <wenxiong@linux.ibm.com>
  Wengang Wang <wen.gang.wang@oracle.com>
  Xiao Liang <shaw.leon@gmail.com>
  Xin Long <lucien.xin@gmail.com>
  Yang Yingliang <yangyingliang@huawei.com>
  yangerkun <yangerkun@huawei.com>
  Yonghong Song <yhs@fb.com>
  Zelin Deng <zelin.deng@linux.alibaba.com>
  zhang kai <zhangkaiheb@126.com>
  Zhihao Cheng <chengzhihao1@huawei.com>
  Zong-Zhe Yang <kevin_yang@realtek.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 fail    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     fail    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 4201 lines long.)


From xen-devel-bounces@lists.xenproject.org Tue Oct 12 10:20:50 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 10:20:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.207075.362817 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maEto-0001GA-Pg; Tue, 12 Oct 2021 10:20:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 207075.362817; Tue, 12 Oct 2021 10:20:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maEto-0001G3-Kv; Tue, 12 Oct 2021 10:20:44 +0000
Received: by outflank-mailman (input) for mailman id 207075;
 Tue, 12 Oct 2021 10:20:44 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=/4YK=PA=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1maEto-0001Fq-1a
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 10:20:44 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 0d99357e-2b46-11ec-811d-12813bfff9fa;
 Tue, 12 Oct 2021 10:20:42 +0000 (UTC)
Received: from EUR02-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur02lp2051.outbound.protection.outlook.com [104.47.6.51]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-23-kaDB7sXmM0WWGYZg9zG1pg-1; Tue, 12 Oct 2021 12:20:40 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VE1PR04MB6670.eurprd04.prod.outlook.com (2603:10a6:803:120::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.21; Tue, 12 Oct
 2021 10:20:37 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4587.026; Tue, 12 Oct 2021
 10:20:37 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS9PR06CA0322.eurprd06.prod.outlook.com (2603:10a6:20b:45b::6) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4587.25 via Frontend Transport; Tue, 12 Oct 2021 10:20:36 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0d99357e-2b46-11ec-811d-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634034041;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=vn6niiN5/polZaKHLQq7Qh7EXq+UY/qH5iK5QeVq9NU=;
	b=Dr+atFJaZ85BMc+3OipZ0YYrKcIK3rDbFLi75teknwvJZUSUan8//mjW7NAYE6GD4aL8uH
	FwzMYYKygJq5VRSO0S6Z+3Sf4EjShplplF906Vdg8IJ65EaKBGPBPzelppPfL1yfSg/3Ed
	r2el8pQpY2Sg5ybDcwHrOUHRMf/htLs=
X-MC-Unique: kaDB7sXmM0WWGYZg9zG1pg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=bJ53Z0FKC+pbHgk+xNphy/tUnlIbavGHw2+2/ACNZt8OM/nvsE7s9SnGjfjzHA1veE5uMSS0U0e2t7026iE8Y/0SGaM7UQWsAy1ST4unqP5R/zsdEE7L6WY9u1S13novpwsKRdYxUMfHXstwFSv/d9wqDUbGJedLfNF/ocjz4Dri1a013VQlt/IX7px959172Qps53m5MGvKRfx7bVjLMwSAKPcNt1IovYOz7q9C1D0QMRTDNb3TIWjHYMvX3vWFAWlEDiQmE+JkKkCfcr7lcLAXv9+Yi5AbYUYhpbGqT9k1ESd9zrUlip9w1wbRsVj3itiooiEBuT2uu7ynuSrMuA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=vn6niiN5/polZaKHLQq7Qh7EXq+UY/qH5iK5QeVq9NU=;
 b=HZIM3l5sPF/NrGuMDkxMw6zZl7eQdODjWhjn9h0/x8FN+vy3MRlQFTwgMzih0dGbNAt/xS823BFJndJj/YxuwfhPE7rvH/OSysfBD3Q2lhYSVU1NbYFmFB08dnzGe3Wdfp/8SoZ6O/p84CWbkra3CS5FyqVEnROzHbeLP6S4TS+OLBuOTA66bOisdkAw6epoUghTMgSMVGZgttMLB+mwdnZ0quuMAOj5y9MAB18jUVjyePEeguF70pF7ev5Scb5UMIMRwluvEUTTTsRv14YjnofStI/hEArQFk8CwZJVv/cJjxvI/vXnHGZFkYtX/thX0m6IYtENa7jLqtvql11yVw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: citrix.com; dkim=none (message not signed)
 header.d=none;citrix.com; dmarc=none action=none header.from=suse.com;
Subject: Re: [PATCH v5 01/11] xen/arm: xc_domain_ioport_permission(..) not
 supported on ARM.
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>
Cc: Rahul Singh <rahul.singh@arm.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andre Przywara <Andre.Przywara@arm.com>, Ian Jackson <iwj@xenproject.org>,
 Wei Liu <wl@xen.org>, Juergen Gross <jgross@suse.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <cover.1633540842.git.rahul.singh@arm.com>
 <d292392268df2c74c4103a82ef917072643407a8.1633540842.git.rahul.singh@arm.com>
 <YWQkblfNMYEs6jI9@MacBook-Air-de-Roger.local>
 <77CF7FA5-C566-469E-B4A8-0400789890BB@arm.com>
 <YWQ6Nk3Jk+BqgkwZ@MacBook-Air-de-Roger.local>
 <53AE6E2A-01D7-41EC-9B2C-C0D596EB8D4D@arm.com>
 <YWRCxXGQIyTOAepC@MacBook-Air-de-Roger.local>
 <FEF0B03A-5AC8-4F8D-B821-191AC2EF8295@arm.com>
 <YWRnMfAi808TQ4Gt@MacBook-Air-de-Roger.local>
 <EB1CB53B-9D5A-49C5-A687-841BF94A153F@arm.com>
 <ac6d4785-ac9a-4491-26bb-c66ffe82c55b@suse.com>
 <ED8FC92F-B5EF-4473-B4A9-641C7D44859F@arm.com>
 <0744b957-1832-dff2-9ae2-b8e8534f501b@suse.com>
 <c3952fd5-b893-4cb6-a9bc-325a89e859db@epam.com>
 <c125b447-53e8-7d13-3b08-af62fd3a9140@suse.com>
 <c6b6c22f-fb8a-f2d9-7735-f1ebc9809908@epam.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <09656882-b297-7144-c291-1ee997edb119@suse.com>
Date: Tue, 12 Oct 2021 12:20:34 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <c6b6c22f-fb8a-f2d9-7735-f1ebc9809908@epam.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0322.eurprd06.prod.outlook.com
 (2603:10a6:20b:45b::6) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 742714b5-421c-45ed-f217-08d98d69eed6
X-MS-TrafficTypeDiagnostic: VE1PR04MB6670:
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS:
	<VE1PR04MB66702A79108CA21867C3A64BB3B69@VE1PR04MB6670.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8273;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	49u6vKpbA9G1JNmc7qDQ2OmEdL0urFhDtJkUrqlutMxZ5abu5arF8StCPHAiiDa4GYykxb8S1GFWimRdLKYutdTmTUp0427/jYIhToAuTiNnfGX2fSu1YEiEoNNfVRO78Pm9Qof10Rrv0GRC9Et41Mc4/7w1UzbZm0N1MXvNdn/j7zK2epaFtOzlBRcaMlQwjJCoooRBpYJd+Ae1lOVk6Gz03ntlh/qFRbETNffYnKVpyzOjqo+peOAQ9K9Pr0KGBnUu1u/QJH6fuXh58aF9HgZGr42kL9NL02/w5/W2OS4/vUg+7JW4pOqCrEiA/0s1FFE6zuL5UZSJNO844wXz0YV6+/KjoRKJVZBo7eRUG+TRA9gKOZfMR1kLEIM4rpMR9Euquy26qN0kP//zZf2w2utN1Zp9cv3RjWHjm7qh8q2DQu8iIPpMBuu9XXZIVYVvgS1ifiY089kBJeo+JvkHuXEDt3Uf7lcTaZ90BF3PdiuR0WOcW88fiClnLfkD+qOkfa03sXLVDcbe6OkcO568aUBhW3fLD3JS6lbefrYyicy8yaotAyZKwyYqYY1eqOMzVYKyKA31Nlwjti96ETd639I1RVBqhNU1YNE5AxOCzdBbl8djX1hGg1zCoLiVC3/1DB7SCYg3XWuqv4h0mMMaC6bTZMhifJd8vSswaS+As6ddmNVpDSp2SX4mNqnLxAHCzVGdEZWenkrQTn25TxIYM25/vk0+oIbU7GIabWoIG1o=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(86362001)(2616005)(36756003)(508600001)(38100700002)(66476007)(31696002)(4326008)(66946007)(66556008)(186003)(31686004)(5660300002)(956004)(2906002)(316002)(6486002)(16576012)(53546011)(110136005)(54906003)(8936002)(8676002)(26005)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?N3ZmYklqNm9YbktvRGJ5OTJWVXVhd0l1VUgzVW5HeHhtZEl5Tm9QWHZIcFU3?=
 =?utf-8?B?dG1rVzlpTlFwc2hCK0NNZUk3YVJaRThNcEFvWEZNZFd2dEZ2K2h5QW9USDV2?=
 =?utf-8?B?dmhCZnBJNHhwOHJrY3g3ZEVETW8xdzlRQ1pDTnpaNEFMRkFzUW1pcEFHTDBs?=
 =?utf-8?B?cW9JU1JzT1AxV0loNTI5R2d1QWc5R1BESUdOZ1NlTkxmZExKNW9CaitjOTQ5?=
 =?utf-8?B?QktiTERwNUk5bnZ4N1VmRE5TbmZ3QUpEZGt5cGR4MUlnQXB2djNZVzlacU1p?=
 =?utf-8?B?cVF5OFN5RXVoc1phZFVpSVdubEVmTy9DUHJUaDZ4UXJhTjE3aCsxcGFraE0y?=
 =?utf-8?B?bTVWNXFVQzF0cmZqOUZRazNRdXNNTWk4eFNGVjJMekFmOW9td0hXSWFGOGV0?=
 =?utf-8?B?SEkxaWJ0TmVMMlEwTHdxN09iV2NiTkxEODdKOTE2cmgzK0xaTXgwUkNpWmVa?=
 =?utf-8?B?QmVsMFkrMFhkM2VVK3lOZ1N0SldLYlVORk1GYVUzbDRqdzNlMVlyUWVLKzJn?=
 =?utf-8?B?OWxVdkZNUXdTVlUyaVROM1kxR01pckQ3bTg5VjQxckNjOGVUYTdZcHNxdlpI?=
 =?utf-8?B?eTB1eWIwMXdkQVE3U2RrVC9HZGcvUi9vWE5idjRBZG9Jd2xZa0FyeUgrUXNZ?=
 =?utf-8?B?NCs2bXR1Z2loaXFJTmNiNGczR0RaS2wwZFpJbnVXdTJrZGl4SFRVVUUvQ3dw?=
 =?utf-8?B?VWMyQmd4NkhsVlFCd0lNUUtwZmYyTmpMVWxwK0NCZ2VmSGlsRE5IV1Y0TWc3?=
 =?utf-8?B?QUMxSmxaYmwyRDZJUXlBZGlpM3NGdkxjc2ErSi9US2dyMkhwNVNoaDZFclBq?=
 =?utf-8?B?SWdOa3JOZ2FzM05UQ3VpVHRwclcxRUl1d0N6cFUyOUx4bnk4QUxmWGV6S0tG?=
 =?utf-8?B?Y0FEWFhyeDhKd21yRUgxNHVmWkY3T2Z1R0tqRFl2MkVlN2VieXRKQTRFeGpk?=
 =?utf-8?B?clBZaGFVZHZXaHdmc29aQmNuRnBsVURyRVJqdGNYT2xUMVN5eFIrcEM0LzVW?=
 =?utf-8?B?QnZCUlVEUTRFN0NCNmRsWGUyaDdHNGQ4YzllZnJ3WVBZTkxQRFdjL2pDTlJG?=
 =?utf-8?B?QWcyU3JZa2ZPcFU5d2s4c1JnUzFrNEc0MmxGZTgrcXR1SGFuMlpwT3oyZS9M?=
 =?utf-8?B?MkFjelhxaVlOdXZ2Sms5VUdVelljU3FuU0xsUWtuZ2xseFNqR0diQnhkZWpD?=
 =?utf-8?B?dDJCeDBwWTQ0MWlodzJLMmM2MitvbUZsb3VRQ3Q0aU5BYTRVM1Y4ZmFnWjZM?=
 =?utf-8?B?NWJYSW1EYmRJS0RvWW1lSW5CSmhudm1maFZMaFJDRTNMd0pWZkdyRE04Lzd4?=
 =?utf-8?B?MUJqYm95MDBha0VHOGI3VVd6VmFnRlZFeGNXSHJQaTBpRzM3ZkYwUTAxVEkr?=
 =?utf-8?B?ckRRalZBL2FINkhGMTMxVm5aTFc1bkRKRm1CVDErK2hzU2NHQjg5ZmlVK1lh?=
 =?utf-8?B?RmRGU2Yzc1lzV3duZHBkR0o1ajFpOFdBZGQrUzcxZW95VVFEa2NYQ0pucjQv?=
 =?utf-8?B?ckFVeWJGVnh1Y0dWMSthZnM2NHdSd2NyeENXZTg2LzkyTUxLSForWFZXZUto?=
 =?utf-8?B?cmRSY2QwQ1hlTFlVdFYrN2JZdmRPM0lxSGt2Y3ppM1RhYUhrd25tZVFWNDVy?=
 =?utf-8?B?QU1XZ3JQOHRHa050dG5EbDRPTDdyajJIaXF1a0ZTL0U5ejBrT3paK3BLNS93?=
 =?utf-8?B?OUFGSG96Umo1VDk3azVlL1FlV1NhUjJpZkJ6eDlBdGYvRUNESVMwUnIyMkxt?=
 =?utf-8?Q?KwSDiLeyMIPl8wESTMHjJDCiBoY+rl0Ny80B7fo?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 742714b5-421c-45ed-f217-08d98d69eed6
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2021 10:20:37.1010
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8d3ZAI3DRk1lTLUradsr1nv7Cm9IihsUSMI/hEpIj4MLVzGSqwlEfx3eovD9DSmQW+YoHlMFtwV5djyAvXvvdw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6670

On 12.10.2021 12:06, Oleksandr Andrushchenko wrote:
> On 12.10.21 13:01, Jan Beulich wrote:
>> On 12.10.2021 11:38, Oleksandr Andrushchenko wrote:
>>> On 12.10.21 12:32, Jan Beulich wrote:
>>>> The minimal thing I'd suggest (or maybe you're doing this already)
>>>> would be to expose such BARs to the guest as r/o zero, rather than
>>>> letting their port nature "shine through".
>>> If we have the same, but baremetal then which entity disallows
>>> those BARs to shine?
>> I'm sorry, but I don't understand what you're trying to say.
>>
>>> I mean that if guest wants to crash... why
>>> should we stop it and try emulating something special for it?
>> This isn't about a guest "wanting to crash", but a driver potentially
>> getting mislead into thinking that it can driver a device a certain
>> way.
> Well, for the guest, as we do not advertise IO in the emulated host
> bridge, the driver won't be able to allocate any IO at all. Thus, even
> if we have a BAR with PCI_BASE_ADDRESS_SPACE_IO bit set, the
> driver won't get anything. So, I think this is equivalent to a baremetal
> use-case where we have no IO supported by the host bridge and
> a device with IO BAR.

Oh, now I follow. Fair enough.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Oct 12 10:39:08 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 10:39:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.207084.362828 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maFBN-0002nJ-9t; Tue, 12 Oct 2021 10:38:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 207084.362828; Tue, 12 Oct 2021 10:38:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maFBN-0002nC-6X; Tue, 12 Oct 2021 10:38:53 +0000
Received: by outflank-mailman (input) for mailman id 207084;
 Tue, 12 Oct 2021 10:38:52 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=lNhP=PA=arm.com=michal.orzel@srs-us1.protection.inumbo.net>)
 id 1maFBM-0002n6-HS
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 10:38:52 +0000
Received: from foss.arm.com (unknown [217.140.110.172])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTP
 id e2e21057-9cfb-4602-b91b-09cdc559f2d3;
 Tue, 12 Oct 2021 10:38:50 +0000 (UTC)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4ED12101E;
 Tue, 12 Oct 2021 03:38:50 -0700 (PDT)
Received: from [10.57.27.99] (unknown [10.57.27.99])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0529E3F694;
 Tue, 12 Oct 2021 03:38:46 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e2e21057-9cfb-4602-b91b-09cdc559f2d3
Subject: Re: [PATCH v5 07/11] xen/domctl: Introduce XEN_DOMCTL_CDF_vpci flag
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Rahul Singh <rahul.singh@arm.com>
Cc: xen-devel@lists.xenproject.org, bertrand.marquis@arm.com,
 Andre.Przywara@arm.com, Christian Lindig <christian.lindig@citrix.com>,
 David Scott <dave@recoil.org>, Ian Jackson <iwj@xenproject.org>,
 Wei Liu <wl@xen.org>, Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <cover.1633540842.git.rahul.singh@arm.com>
 <20d5b9d6a0d01a7b90711d28cbefb5701a88b438.1633540842.git.rahul.singh@arm.com>
 <YWQDguvmf/O4rDIs@MacBook-Air-de-Roger.local>
From: Michal Orzel <michal.orzel@arm.com>
Message-ID: <9217a6b8-fc53-a049-7cd3-7458b574424b@arm.com>
Date: Tue, 12 Oct 2021 12:38:35 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <YWQDguvmf/O4rDIs@MacBook-Air-de-Roger.local>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit

Hi Roger,

On 11.10.2021 11:27, Roger Pau Monné wrote:
> On Wed, Oct 06, 2021 at 06:40:33PM +0100, Rahul Singh wrote:
>> Introduce XEN_DOMCTL_CDF_vpci flag to enable VPCI support in XEN.
>> Reject the use of this new flag for x86 as VPCI is not supported for
>> DOMU guests for x86.
> 
> I don't like this approach, XEN_DOMCTL_CDF_vpci should be set for x86
> PVH dom0, like we do for any other CDF flags when Xen builds dom0.
> 
> Things like PVH vs PV get translated into CDF flags by create_dom0,
> and processed normally by the sanitise_domain_config logic, vPCI
> should be handled that way.
> 
> Do you think you could see about fixing this?
> 
> Thanks, Roger.
> 

I have one question about this fix.
If I set XEN_DOMCTL_CDF_vpci for dom0 pvh in create_dom0, then in
sanitise_domain_config or arch_sanitise_domain_config I have no
knowledge on whether I am dom0 or not. I can check if I'm PVH but not if dom0.
This would be needed to add a warning if this flag is set but we are not dom0 pvh.

Any ideas?

Cheers,
Michal


From xen-devel-bounces@lists.xenproject.org Tue Oct 12 10:41:53 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 10:41:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.207092.362838 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maFEG-00049b-OL; Tue, 12 Oct 2021 10:41:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 207092.362838; Tue, 12 Oct 2021 10:41:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maFEG-00049U-LE; Tue, 12 Oct 2021 10:41:52 +0000
Received: by outflank-mailman (input) for mailman id 207092;
 Tue, 12 Oct 2021 10:41:51 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=B8jq=PA=arm.com=Bertrand.Marquis@srs-us1.protection.inumbo.net>)
 id 1maFEF-00049O-B1
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 10:41:51 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com (unknown
 [40.107.7.40]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 017918ba-2b49-11ec-811d-12813bfff9fa;
 Tue, 12 Oct 2021 10:41:50 +0000 (UTC)
Received: from DU2PR04CA0347.eurprd04.prod.outlook.com (2603:10a6:10:2b4::27)
 by VE1PR08MB5856.eurprd08.prod.outlook.com (2603:10a6:800:1ab::23)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18; Tue, 12 Oct
 2021 10:41:40 +0000
Received: from DB5EUR03FT006.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:10:2b4:cafe::52) by DU2PR04CA0347.outlook.office365.com
 (2603:10a6:10:2b4::27) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.26 via Frontend
 Transport; Tue, 12 Oct 2021 10:41:40 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT006.mail.protection.outlook.com (10.152.20.106) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4587.18 via Frontend Transport; Tue, 12 Oct 2021 10:41:40 +0000
Received: ("Tessian outbound d5def7722ff7:v103");
 Tue, 12 Oct 2021 10:41:40 +0000
Received: from e976e0b4b12a.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 B3F02F59-F06D-47F3-A243-F9B4CAFBE269.1; 
 Tue, 12 Oct 2021 10:41:29 +0000
Received: from EUR01-HE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id e976e0b4b12a.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Tue, 12 Oct 2021 10:41:29 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com (2603:10a6:4:74::9)
 by DB6PR0802MB2582.eurprd08.prod.outlook.com (2603:10a6:4:a2::11) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.22; Tue, 12 Oct
 2021 10:41:23 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955]) by DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955%4]) with mapi id 15.20.4587.026; Tue, 12 Oct 2021
 10:41:23 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 017918ba-2b49-11ec-811d-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Yu7nT04e8SwimeoWa4uhZ2M5IJUjFclNEp5sAd9mDcU=;
 b=nkLIgogfRs0rR6VHs7qZc95TfY1lIrNc33E2IRIpIIM143XScih5pIg+40SD83SK1W/WyyqXOb3ae8aEMOvK5zfFMXpEAxI1EcphckzNHjuOHzCtNKkyG6KTWwyjOkF19w7sySw6oSDGEKGWAHeyaT9s9BrNejuiDmupfZNsrx8=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: b084969528c43722
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=m/Xh3t6EPbUDcgwHDidQqGzYBEPBaxPQ2jrazC4ZEDromrbAJ4uQnlAjpwnmV/L/MROwRVyNOCTMR+J7xiLOUv0TJTMZf4do54wMBYStDv9wQkyCTwxPhS2lhl8ZcrrE6lUoY5wC+jFKeXrmisZs3J+H394kyjOhqCXI2gPnf0Scp5bMzXk3KiVAA97Lln2E5k04ilkH2wU+yDEbSlXD2eah115Snaw5CDrXG8T+ieOUWaqyulbnV1P6GaBK8kUb3Eoh6Xl3SSZi69lNUn8O+m7Dflf2G2rBQ7w4aTQyFVXDiw3uz+fVp8mlshLTKt8bZR7v5z41IPwpwQfbjJ9lAw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Yu7nT04e8SwimeoWa4uhZ2M5IJUjFclNEp5sAd9mDcU=;
 b=M2HXLF8KrsGLfQffjNbJBjlXilQ8tr6CwvO4gUehBU4C5UCrT7yz8TSDhak7ZpkYS6uOWFUsh83koB1hiXM1wvNmg6ByDBui4SmAt3thQFlfb5NeVwYyWOgcPnAuZhVDbT0toTPlP8gOW0T9qEA6aXBrYq6raG2Ks9/ptdRQFhT+rFmw2o8TzWgXFDnUz+xym/xGSXEI4iPmtJ9GVLPLQEeu68qkWDGCAAaJfNh3pU3F4bj+eoDTzDbH325/2TdqsdEoNsIzTm6rQvK1NreV1lC5yu5wTXysnKHd5zVOEOhk1C3/0kxyu2CYyoTbN85dpcHROO/Q+qdYvdL0WHP7OQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Yu7nT04e8SwimeoWa4uhZ2M5IJUjFclNEp5sAd9mDcU=;
 b=nkLIgogfRs0rR6VHs7qZc95TfY1lIrNc33E2IRIpIIM143XScih5pIg+40SD83SK1W/WyyqXOb3ae8aEMOvK5zfFMXpEAxI1EcphckzNHjuOHzCtNKkyG6KTWwyjOkF19w7sySw6oSDGEKGWAHeyaT9s9BrNejuiDmupfZNsrx8=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>, Rahul Singh
	<Rahul.Singh@arm.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, Andre Przywara <Andre.Przywara@arm.com>,
	Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>, Juergen Gross
	<jgross@suse.com>, Stefano Stabellini <sstabellini@kernel.org>,
	=?iso-8859-1?Q?Roger_Pau_Monn=E9?= <roger.pau@citrix.com>
Subject: Re: [PATCH v5 01/11] xen/arm: xc_domain_ioport_permission(..) not
 supported on ARM.
Thread-Topic: [PATCH v5 01/11] xen/arm: xc_domain_ioport_permission(..) not
 supported on ARM.
Thread-Index:
 AQHXutl5d8zkP9bsD0GXT4+5QPGclKvNtfkAgAAGc4CAABOEAIAABXoAgAAEuYCAAAVHAIAAJiWAgAAK0ICAAQCPgIAAA0qAgAAOJYCAAAHCAIAABnQAgAABQgCAAAQNAIAABdAA
Date: Tue, 12 Oct 2021 10:41:23 +0000
Message-ID: <69A83587-B7E0-4653-AF8C-AEE802922CE5@arm.com>
References: <cover.1633540842.git.rahul.singh@arm.com>
 <d292392268df2c74c4103a82ef917072643407a8.1633540842.git.rahul.singh@arm.com>
 <YWQkblfNMYEs6jI9@MacBook-Air-de-Roger.local>
 <77CF7FA5-C566-469E-B4A8-0400789890BB@arm.com>
 <YWQ6Nk3Jk+BqgkwZ@MacBook-Air-de-Roger.local>
 <53AE6E2A-01D7-41EC-9B2C-C0D596EB8D4D@arm.com>
 <YWRCxXGQIyTOAepC@MacBook-Air-de-Roger.local>
 <FEF0B03A-5AC8-4F8D-B821-191AC2EF8295@arm.com>
 <YWRnMfAi808TQ4Gt@MacBook-Air-de-Roger.local>
 <EB1CB53B-9D5A-49C5-A687-841BF94A153F@arm.com>
 <ac6d4785-ac9a-4491-26bb-c66ffe82c55b@suse.com>
 <ED8FC92F-B5EF-4473-B4A9-641C7D44859F@arm.com>
 <0744b957-1832-dff2-9ae2-b8e8534f501b@suse.com>
 <c3952fd5-b893-4cb6-a9bc-325a89e859db@epam.com>
 <c125b447-53e8-7d13-3b08-af62fd3a9140@suse.com>
 <c6b6c22f-fb8a-f2d9-7735-f1ebc9809908@epam.com>
 <09656882-b297-7144-c291-1ee997edb119@suse.com>
In-Reply-To: <09656882-b297-7144-c291-1ee997edb119@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3654.120.0.1.13)
Authentication-Results-Original: suse.com; dkim=none (message not signed)
 header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: 4c7f701b-1974-4294-05ae-08d98d6ce042
x-ms-traffictypediagnostic: DB6PR0802MB2582:|VE1PR08MB5856:
x-ms-exchange-transport-forked: True
X-Microsoft-Antispam-PRVS:
	<VE1PR08MB5856C976AF6A71A9D37CA28D9DB69@VE1PR08MB5856.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:9508;OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 j36J/qGzBTdW2KjK9xEepxp5r/V/cLYdRLTW7pNO+QZJIrG3qp6a+uoy1TlosGzEv0JG4RxQoIrPs9r3Hz3RH6GkW7Q2D5fwF54MHbj+XrIEf02yXLnfQONRvpv7z2MDy2tqjmn04uyrJmQ7HTIn8bdMn34S9ytVoAy698WdaJyICjCvuLfDczRFaX1uKGkiFEvZeQ/R8SY6JcCraIJbF2K99EZqEwilxMwSejJHA8ktHj0mlJOsEp6kIwUKstgEFcU8M86i1vZK12nLsbPEhuvSJaiWsEsPHOZYiBnsGpPXJFECh0QWv5+i5Dw6hPAoIUvDBmoN4u4uAw/puGXKbwV3qUz3HlF4K6KqsL7zkMZM84t5EpOBmLpQL8RljvcTumEEEekhgNVT5OCdP+wV8cFEbj+LS6ZNPgL/ajwuegoV/HmF0l+cR6iPJ0AWY8NViVcp270FgOT3MZFWq24IY5GjQf2PRzHAEaDmLI9D5RpwD/CA7PMz1dlOKVHY4N9hFmcM6yWNUo5dZIZglG6RvlmBxxQqn0cRErFYZl/d7btxdu3ITQm5hssKvBZVAWQnVGBpFp3iXLWwONOBqnW6ubhhoWe+c2w4/OfafpYkgCeT3uL2KJEarH3C8fLDvGyLc4QRjGbhPIy/sJZWeg9iRmD+rhbTGNVz2s/0EuUJiqKTHvsq4ilAKn5PRFGL7HYxE9BhokBM3Wl4UbMTXvErTDeUEQR5JxamyrH4w6ABCVN1KWA5rLwAlsk9psit+tr8
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB6PR0801MB2024.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(6512007)(4326008)(186003)(6506007)(8676002)(66476007)(26005)(54906003)(6916009)(38100700002)(36756003)(8936002)(66556008)(53546011)(316002)(6486002)(86362001)(2906002)(2616005)(508600001)(71200400001)(66446008)(33656002)(38070700005)(122000001)(64756008)(66946007)(76116006)(91956017)(5660300002)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="iso-8859-1"
Content-ID: <44730136B7A0B2488DB839C18441993E@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0802MB2582
Original-Authentication-Results: suse.com; dkim=none (message not signed)
 header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT006.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	b68a57c3-1e78-40aa-92ca-08d98d6cd5f4
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	GWE8Yb2GtpqvIr1lhm7oqXO5NisWC/dECksAMZZrTZXS/ZeRbVtUgpv6zKoqTynxOLjSUJqy1RZbixU4d7uwAVh92dolR0qERd+7ls6hY8GFbg80SVxmE/mvtwVlW/S1U65ZZeYsoyAZRAZKseAAAga1zyzZ3RCWspPYEvA/u1f6g7iCQFWBuCKywMxFn9WYKoE46aEZsumkbWcx6lUnhBy+GOtbl9nosbHvxXSJ/3y0wKHvFVwgDWAKuD2c1iqj9Ax/HOhZ9VNCX6yQKgcmKwlWb3SQ8kh8aZWYFFTwxciAS4ehAgUdv3nwuHuIXyW9c1E+RHZTZfLdrgT8pj3QaJWrkyufyimmfYzUHadKaMqwoNSMKgeEL0XajhoenMqakctwMZfF5ds4XEMVj6YCKYe7Mqr74SzCOi18neMtL7N6wRjDoJrFxlVeew6M8uscVphexiKSJ2+un5SmyvwQpCDzSnMmAMgaiWQMVg0VN53tecEfHwo+KAxK0IHTbaAH7FB3d+Ql4kTmOoz3G2KrlyOMh/xlOEl3w29GWa+mDZak04evxHvkk059S9DEXPpuuRwEqzpJXKx7bRQ/Vrwl4SLgsB2mGbcZywVj1z1eBuYK71vtYmK/bi+1+SlCQ84rUcAadXiHn87KHws9/+qiosdUeNzja0Y7DN+CXb30WxfBmQTLxNI9BYNQT0H53CGUTlKqs0pZxLneqcObAx7AQQ==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(26005)(5660300002)(2906002)(86362001)(508600001)(81166007)(107886003)(6506007)(53546011)(186003)(36756003)(36860700001)(2616005)(336012)(6486002)(47076005)(82310400003)(8676002)(6512007)(54906003)(6862004)(33656002)(4326008)(356005)(8936002)(70586007)(70206006)(316002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2021 10:41:40.7973
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 4c7f701b-1974-4294-05ae-08d98d6ce042
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT006.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5856

Hi Jan,

> On 12 Oct 2021, at 11:20, Jan Beulich <jbeulich@suse.com> wrote:
>=20
> On 12.10.2021 12:06, Oleksandr Andrushchenko wrote:
>> On 12.10.21 13:01, Jan Beulich wrote:
>>> On 12.10.2021 11:38, Oleksandr Andrushchenko wrote:
>>>> On 12.10.21 12:32, Jan Beulich wrote:
>>>>> The minimal thing I'd suggest (or maybe you're doing this already)
>>>>> would be to expose such BARs to the guest as r/o zero, rather than
>>>>> letting their port nature "shine through".
>>>> If we have the same, but baremetal then which entity disallows
>>>> those BARs to shine?
>>> I'm sorry, but I don't understand what you're trying to say.
>>>=20
>>>> I mean that if guest wants to crash... why
>>>> should we stop it and try emulating something special for it?
>>> This isn't about a guest "wanting to crash", but a driver potentially
>>> getting mislead into thinking that it can driver a device a certain
>>> way.
>> Well, for the guest, as we do not advertise IO in the emulated host
>> bridge, the driver won't be able to allocate any IO at all. Thus, even
>> if we have a BAR with PCI_BASE_ADDRESS_SPACE_IO bit set, the
>> driver won't get anything. So, I think this is equivalent to a baremetal
>> use-case where we have no IO supported by the host bridge and
>> a device with IO BAR.
>=20
> Oh, now I follow. Fair enough.

So there is no comment remaining on this patch ?

Would it possible to get an ack on it ?

Thanks
Bertrand

>=20
> Jan



From xen-devel-bounces@lists.xenproject.org Tue Oct 12 10:44:54 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 10:44:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.207099.362850 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maFHA-0004lz-6o; Tue, 12 Oct 2021 10:44:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 207099.362850; Tue, 12 Oct 2021 10:44:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maFHA-0004ls-3Z; Tue, 12 Oct 2021 10:44:52 +0000
Received: by outflank-mailman (input) for mailman id 207099;
 Tue, 12 Oct 2021 10:44:50 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=/4YK=PA=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1maFH8-0004lm-8L
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 10:44:50 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id b619b2ec-bd5d-44ad-b1e1-b5bb928227a8;
 Tue, 12 Oct 2021 10:44:49 +0000 (UTC)
Received: from EUR01-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur01lp2056.outbound.protection.outlook.com [104.47.0.56]) (Using
 TLS) by relay.mimecast.com with ESMTP id de-mta-3-EndXMT0aPuKwWAY5tVMqwg-1;
 Tue, 12 Oct 2021 12:44:47 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB5599.eurprd04.prod.outlook.com (2603:10a6:803:de::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.19; Tue, 12 Oct
 2021 10:44:45 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4587.026; Tue, 12 Oct 2021
 10:44:45 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6P192CA0087.EURP192.PROD.OUTLOOK.COM (2603:10a6:209:8d::28) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4544.27 via Frontend Transport; Tue, 12 Oct 2021 10:44:44 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b619b2ec-bd5d-44ad-b1e1-b5bb928227a8
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634035488;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=xYx0Oca5q9WtFK1Q+0zPto8fLAaNTygfy9vMrtYAAB8=;
	b=hxWHE/X379vgi77cCl0c0dY7o/ISzHWmgFY3kUwjXG8u2vuLmcGieMN0+XR9rOqx6ZHGBz
	jIaqPtCzFqZysJqNLpZV/P2YxW9B0LwooxgU6JSitfQ3iEv2sf9jiIRVOnz1bU6sabLwdH
	LdYD1vp7Ra8OejMgK70SK+UXbgLPxcs=
X-MC-Unique: EndXMT0aPuKwWAY5tVMqwg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Vh5msktervtd5lIkM7O19lIk0SqLLdlb/QOoo/enAYEz+a1Km1uZhx10bPJX49Imab24IrTmlYqqJaWxFAeYDfwbSnQAhBbbhMOwVwszCUACHTTGk58bIT0ouEizS0/uIhaVUPxr3orLqe5jKDtmpqM95WFbB9mQVwB1jokRQFooEl6zIltZVXGmymmnNYVKlXcrbCcg2h2SUrPLeQVKMj9TOi0iSLVgBKUGgoWH9cofh0hpx8njPaaHeBpiklb7lwKPP712+HH61h+o+QjkConXuCZChiWk2I38rFvnXxUpohXon3zpxPLJapRQdL/GqKHN610gZdPsVlO3DAsEwg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=xYx0Oca5q9WtFK1Q+0zPto8fLAaNTygfy9vMrtYAAB8=;
 b=Wb/qsDg/401lcU7WI11mEZoiNtXz7t9WhoXg1Cid3Odam+847feEW1uV977FhgHdEzXzAOxe7eNc3af58dCF+1kqRaF4iFv+1jduu8foYV6KRjsACQJ7i3XmKeAzlIyMLygqm4dOjygSzY4b4eZrK/9L2J1QryyOcVuh+4m3ZgpvnMU5+7pOMdBKhlxcrRQUc1b3UKLA1YaUCPeMYZKmCxeOtYEMEWtBXzDiTBrgx1W+ebVIkovpnJOxOMNiLaTeAv92RlhEhC4FsVDU+0F6nNbcaXgtZ4fuwvsNE37ltPD44Ni9gI8oi82pKFX7WeUZtvt8AyB/thd9VMpqqmyx3A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: citrix.com; dkim=none (message not signed)
 header.d=none;citrix.com; dmarc=none action=none header.from=suse.com;
Subject: Re: [PATCH v5 01/11] xen/arm: xc_domain_ioport_permission(..) not
 supported on ARM.
To: Bertrand Marquis <Bertrand.Marquis@arm.com>
Cc: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>,
 Rahul Singh <Rahul.Singh@arm.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andre Przywara <Andre.Przywara@arm.com>, Ian Jackson <iwj@xenproject.org>,
 Wei Liu <wl@xen.org>, Juergen Gross <jgross@suse.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <cover.1633540842.git.rahul.singh@arm.com>
 <d292392268df2c74c4103a82ef917072643407a8.1633540842.git.rahul.singh@arm.com>
 <YWQkblfNMYEs6jI9@MacBook-Air-de-Roger.local>
 <77CF7FA5-C566-469E-B4A8-0400789890BB@arm.com>
 <YWQ6Nk3Jk+BqgkwZ@MacBook-Air-de-Roger.local>
 <53AE6E2A-01D7-41EC-9B2C-C0D596EB8D4D@arm.com>
 <YWRCxXGQIyTOAepC@MacBook-Air-de-Roger.local>
 <FEF0B03A-5AC8-4F8D-B821-191AC2EF8295@arm.com>
 <YWRnMfAi808TQ4Gt@MacBook-Air-de-Roger.local>
 <EB1CB53B-9D5A-49C5-A687-841BF94A153F@arm.com>
 <ac6d4785-ac9a-4491-26bb-c66ffe82c55b@suse.com>
 <ED8FC92F-B5EF-4473-B4A9-641C7D44859F@arm.com>
 <0744b957-1832-dff2-9ae2-b8e8534f501b@suse.com>
 <c3952fd5-b893-4cb6-a9bc-325a89e859db@epam.com>
 <c125b447-53e8-7d13-3b08-af62fd3a9140@suse.com>
 <c6b6c22f-fb8a-f2d9-7735-f1ebc9809908@epam.com>
 <09656882-b297-7144-c291-1ee997edb119@suse.com>
 <69A83587-B7E0-4653-AF8C-AEE802922CE5@arm.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <e5a25f27-4361-d61b-ca63-9f031cd53600@suse.com>
Date: Tue, 12 Oct 2021 12:44:43 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <69A83587-B7E0-4653-AF8C-AEE802922CE5@arm.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P192CA0087.EURP192.PROD.OUTLOOK.COM
 (2603:10a6:209:8d::28) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 8b5c9f39-0c51-4efa-cb1e-08d98d6d4e34
X-MS-TrafficTypeDiagnostic: VI1PR04MB5599:
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB5599CE177BD452DDE2F126E0B3B69@VI1PR04MB5599.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8273;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	3gHEavgAdKGbI3nKIw+HyAqxR99XM+yfj4YJVMKiS2UhQFLdn/+xFYClH82c0R28Og4o55eD/wMtgo22aS8gyoaifmxH03WLPyffqBjw0uISad5Beos0ir4zZxRLlUl7NWj4X0FX1bDYJVLksNyLmMTPjQWGNb5sZiu4AC/sjbu/JWoDf8bUChb9iFMYnfUb2rLtFWycHkBsHKuk3nwAuIQOfr7r2xWKBMzNxus9dpgoqdPOZAjhrIT/kP37AUaEgT1IvgeLqHHu1p1alfQAeuIavgZyGViv2wPybyuDIlGgsZ5wfuAjhxseApHH6OlPlbT78tTNFhkrETT+ReWpfYq77RrvMwnk+dnKuzftNFIEzjjZ3WkfM3YCjcHRMVtyA2/U19mORLTwt09qbLi387Hw/CHIE2bZK/CpgSvv7nW+ydXOyP7pgx/hywGJU7nWFZfehGWPyi9Z9S+TRfEgKz1lcBFxHqrMAtfOBolx90WaGsmYecbYNuQrHpSjOt2qfPjHLj+4vx5lCJ+nRY6Kak+27zl4WBo1t5o0HqmbPNeA6xcrSrAjFAs0pfPMK8oGhVKLhslNSwdP+yc0Q6ocYyHvheHhc+hQln0y109r1m0ixqoViSaHr3xY614+cmxxrwNiPeNegDRNi9Y5vrqKO8VcVluf+uBQTMNQQyaF0QFBL2PQ+Vrj960joL5CtRfVwE3gabJmG0iljgYbHMr091WlUp7rIlJRJJWVhxCl8sQ=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(8936002)(31686004)(66476007)(66556008)(66946007)(2906002)(31696002)(4744005)(36756003)(8676002)(956004)(2616005)(186003)(16576012)(508600001)(5660300002)(38100700002)(54906003)(53546011)(6916009)(86362001)(26005)(316002)(6486002)(4326008)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?bndOY21KNnNta0dVWWVVd283anpUWWp0TGZiaE1JUFlCKzJGSkVuZ3ZXV0gr?=
 =?utf-8?B?enM5WVBEUWUxQkFKRDNMdzNHTnlyOW10SWFzZE1LQ2g1MGhhaUYxV1BwSEtV?=
 =?utf-8?B?amIvd0FVVWU1TzVzeGlPLzZyRWx5Q0EyVUdnd09RZW5EZzRSVkhNRW1pcExt?=
 =?utf-8?B?WnRvNHhGQ0FSZ2JGeWRUWWZ0R0JPTVFidXprWjR5L2lMQk9Yd0N1SUM5REtL?=
 =?utf-8?B?MFgxaTRYZnQ4UXEwR1NyTUV2L0g3RUpWQ0tSMTdjaUE2SEY0eStESjJoM3lR?=
 =?utf-8?B?SWxScnNzNFdrck9MTkJhaEloSVhIYWh2dkdsMkR3WEhISHNrMDdua1NFc2JD?=
 =?utf-8?B?TVQwb1RzVEFsb004cFJJL3lwK09MZkhyVlJzK2oxSjZyRnpFeFdwR1g4U2dW?=
 =?utf-8?B?SmpJQk1HOEhWUmd1Z0RXeWhYSUlGb3RETXdXSmxYWFRyc0Nta0w1RmpMUVor?=
 =?utf-8?B?V2RiVnZ0MHZ5WHdpRFN1STVhdTRIczFqbCtiSGxVd2tobC8wZGRzODRzRGEv?=
 =?utf-8?B?M3JBSmJydEdPZUNFNlYyOEhvRXo3aSt6ck1vRHFWdDVqRUVWRVQ0RStVQ0lI?=
 =?utf-8?B?YTBrK2sramRad09zamxOa0ptRHBBbjBNR2cyaWFtUjhvdzJ4VmFNZUMvcUVz?=
 =?utf-8?B?Tjg1UTE1cEhKNFNLemozaUl1eld1RFNNSGN0ZnpFckNpWkIrdGZCWkZYcVpN?=
 =?utf-8?B?aDJvTGtQbW9YdW0wRnZrdFBLR2pTOG1pdS8xTUFmVkFHQ3VCM3NOczJESExm?=
 =?utf-8?B?VGlybytmRkRZWE41Umx0MnJTMGhGdEZwNFJwemhlKzl3azJOWTNTRmR1YU82?=
 =?utf-8?B?azJqY0Y4U2VpVWhwVWFNN3R6YXFaMW1pQkN6eVdzblU5WUFnYWloemZPZXht?=
 =?utf-8?B?MURQYnQrRVJNSGI1aC96YmtvalNkUm12L255U0ZnZjFuK0hpS1FiNDJ4dG10?=
 =?utf-8?B?WmErNGR5NUdMTkJlWVNEQ0ZHdDYydmJPMnVNUWJtZDY2OVlSaGhOWFp3b2x3?=
 =?utf-8?B?VFR5NFl6UlNTVW1BNDZmb1YxM25KZ1c1NWZXdGFaTDhhNHE3TjJZL2xDNmRT?=
 =?utf-8?B?bnhPR2laVFlEZG8vd0ZqOUliZldwUmczOElQeVBURSs4eFg2M3FjTGhoMnRJ?=
 =?utf-8?B?OEdyRXd6emRKeC90ZDJxOE9HZWlkWnN2VTNlOHMwRWxFQjhPSTVDdXFkaCsx?=
 =?utf-8?B?R1lJOEs2cmpGbmJLUnRFSGVYZ0p3VEkya2ozSmtwelVlQmNtMU1aMXlNU2V3?=
 =?utf-8?B?VGlkb2ZGUFczRFNjNDRhT1BkMzNKUVJ4RzMrU1AwalBCZ09YSUcxU3RCWnZW?=
 =?utf-8?B?ekYyR1RGbENiSVQvdTUyeXc3Y0dkdmM1Sy9WNW9nSDNBMDAvM1JSUjRpK3Rn?=
 =?utf-8?B?UlgxWDV3RWtlMlE4UXVCWnNCRFpMSVJrRWQrdHRIc204a2ZZaW9yZ2ZZREJu?=
 =?utf-8?B?WnV1OTZWR0k3T1RZZlU0dDhJMTFVRnJLNVVRQTdNT1Zwc1FXK1JqWUJPaFZV?=
 =?utf-8?B?YUZVRHN2TWF0dWFWNU9aVTVIb3FRUnhnVG9rdllRbGxMb2IwUTIzQ28rcmM3?=
 =?utf-8?B?bkRhemF6OVZiN3BBN1IvbmRWN24yekJkOHR1MmsySk5lMHhaK2wwV0hrbzN1?=
 =?utf-8?B?RUZxTGZBdFl1c3R4QWoyQ2NMYUlmSEpzRnl2cmx5N2dBR25wRENTMnF0NXcv?=
 =?utf-8?B?YTFLOXFQUHlJN2xZTXg1S0tmQXhkaFhkZlhNMU8yZ3ZPK3VrYTJhRzNmL2RN?=
 =?utf-8?Q?+sczqPTyWZEmsLNu+GEwJToRyfUp8qtHpe1ll86?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8b5c9f39-0c51-4efa-cb1e-08d98d6d4e34
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2021 10:44:45.4169
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Fd4fEABGFasYJ6jwGlPU2wMieQ59ZjKiutOBZmezm61o3Nu7P2VR840n/aTKgEFpcIcrSN3lKcsjDGdl0nux4A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5599

On 12.10.2021 12:41, Bertrand Marquis wrote:
> So there is no comment remaining on this patch ?

No, but the comments weren't on the patch anyway, but on a question
raised in the course of the discussion.

> Would it possible to get an ack on it ?

No, as I can't ack this patch: I'm not a maintainer of the file being
changed. And I don't feel qualified to give an R-b.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Oct 12 11:28:50 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 11:28:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.207121.362861 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maFxc-0000WL-I1; Tue, 12 Oct 2021 11:28:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 207121.362861; Tue, 12 Oct 2021 11:28:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maFxc-0000WE-F1; Tue, 12 Oct 2021 11:28:44 +0000
Received: by outflank-mailman (input) for mailman id 207121;
 Tue, 12 Oct 2021 11:28:44 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=P4MT=PA=gmail.com=olekstysh@srs-us1.protection.inumbo.net>)
 id 1maFxb-0000W8-TQ
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 11:28:43 +0000
Received: from mail-lf1-x12f.google.com (unknown [2a00:1450:4864:20::12f])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id ed2dff2d-0ca7-470f-9229-f74c6e40ae8e;
 Tue, 12 Oct 2021 11:28:42 +0000 (UTC)
Received: by mail-lf1-x12f.google.com with SMTP id y15so86438037lfk.7
 for <xen-devel@lists.xenproject.org>; Tue, 12 Oct 2021 04:28:42 -0700 (PDT)
Received: from [192.168.1.7] ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id m7sm411639lfp.267.2021.10.12.04.28.39
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Tue, 12 Oct 2021 04:28:40 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ed2dff2d-0ca7-470f-9229-f74c6e40ae8e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-transfer-encoding:content-language;
        bh=GizbPFZSmmKg7ldAcUWwq8rUYFgjC85kABZ+tHbiFhE=;
        b=VVcOFNK+qVSNCqICDk856pBQr1TB8EeNUL4Pcc+TGL/ZRFU1PXHxmzJs5nSWc6hbhy
         VExZM8Eo9NUXaI7TD5//hsUf63IEd0Sz/ImlyWMCgaY1aC2nKa/uuSW+zXKrgqUtBKYC
         nlcSIw99zQ7G7tiRtWgYVdJUCeg/X4mSoOzzi+jKVObvS7WLNavDBdK5EgbNt2MmVlaA
         My51nVEHsr2irXLATEsXg2id+N+TahebJ0VREc4UFEqT2iwCCFfSCvKSdeiXYYLfoZIo
         Jt/YwzbDThrD101+k+MU5uY4PnvL9R0df07g1IG/YG8gD6MghlekfNLSnWJftO44AXGB
         RD3w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding
         :content-language;
        bh=GizbPFZSmmKg7ldAcUWwq8rUYFgjC85kABZ+tHbiFhE=;
        b=R9UieBUK9cRLBNHBHIiGtosTsSZ3mxNbBi1hsiBTt9l5DDj51zGrbL1IQAOeFsECEj
         AI/U1d8uMVspZ3h5wB2uOmivwhKSFQ9V1bfELivpI1fhEek6FihQS0GEWOJCKNL77olo
         UbTE8YdB5SHbXuMy6einGQ+yoiniBdfVJt4tyk4WrBL52ZL7NKQy+qu916qZXQxzeM+b
         3qOhiWf3cKc2dD7yqKzzAG8SmaZ9nmWWbdqVNlS1AtMq/0LqMERQRqTLiknblIa7xUSC
         Vko+azVxlsxxJa7V4fB8/IC1rDPHz7A1buSY3DctmHDHfiod/0fqmYOqVUyX9fhWbxNc
         vIIg==
X-Gm-Message-State: AOAM532ap0F0/9gphFTikx0MmFVqqx6qT+P+NTGvvv5Hs67Gx4bD4tPu
	DgqawGQcXWaSbGzNeHzGxXhg3LRd8ag=
X-Google-Smtp-Source: ABdhPJxU4fhbrFAWPwry9gKeASVMd7RN0Ffk3pItBzcRtJnWCV3BmfU1yYbhhdpbmY8dbU7wLvDGCQ==
X-Received: by 2002:a05:651c:b23:: with SMTP id b35mr28179082ljr.166.1634038120881;
        Tue, 12 Oct 2021 04:28:40 -0700 (PDT)
Subject: Re: [PATCH V6 1/2] xen/arm: Introduce gpaddr_bits field to struct
 xen_domctl_getdomaininfo
To: Jan Beulich <jbeulich@suse.com>
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>,
 Anthony PERARD <anthony.perard@citrix.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Juergen Gross
 <jgross@suse.com>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 xen-devel@lists.xenproject.org
References: <1633974539-7380-1-git-send-email-olekstysh@gmail.com>
 <1633974539-7380-2-git-send-email-olekstysh@gmail.com>
 <1466e946-d247-2380-6d7d-cda405a2f255@suse.com>
From: Oleksandr <olekstysh@gmail.com>
Message-ID: <68213f79-2cbc-e0cf-3181-bc487f0a5eff@gmail.com>
Date: Tue, 12 Oct 2021 14:28:39 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <1466e946-d247-2380-6d7d-cda405a2f255@suse.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US


On 12.10.21 12:24, Jan Beulich wrote:

Hi Jan

Thank you for thorough review.

> On 11.10.2021 19:48, Oleksandr Tyshchenko wrote:
>> --- a/xen/include/public/domctl.h
>> +++ b/xen/include/public/domctl.h
>> @@ -38,7 +38,7 @@
>>   #include "hvm/save.h"
>>   #include "memory.h"
>>   
>> -#define XEN_DOMCTL_INTERFACE_VERSION 0x00000014
>> +#define XEN_DOMCTL_INTERFACE_VERSION 0x00000015
> So this bump would not have been needed if the rule of making padding
> fields explicit in the public interface had been followed by earlier
> changes, as you could have fit the 8-bit field in the 16-bit gap
> after domid.
>
> Furthermore this bump is only going to be necessary if your patch
> doesn't make 4.16. 4.15 uses 0x13 here, i.e. a bump has already
> occurred in this release cycle.

I got it, will remove the bumping.


>
> Otoh, because of the re-use of the struct in a sysctl, you do need
> to bump XEN_SYSCTL_INTERFACE_VERSION here (unless you fit the new
> field in the existing padding slot, which for the sysctl has been
> guaranteed to be zero; see also below).

Oops, indeed, will bump.


>
>> @@ -150,6 +150,7 @@ struct xen_domctl_getdomaininfo {
>>       uint32_t ssidref;
>>       xen_domain_handle_t handle;
>>       uint32_t cpupool;
>> +    uint8_t gpaddr_bits; /* Guest physical address space size. */
>>       struct xen_arch_domainconfig arch_config;
> On the basis of the above, please add uint8_t pad[3] (or perhaps
> better pad[7] to be independent of the present
> alignof(struct xen_arch_domainconfig) == 4) and make sure the
> array will always be zero-filled, such that the padding space can
> subsequently be assigned a purpose without needing to bump the
> interface version(s) again.

ok, will do.


>
> Right now the sysctl caller of getdomaininfo() clears the full
> structure (albeit only once, so stale / inapplicable data might get
> reported for higher numbered domains if any field was filled only
> in certain cases), while the domctl one doesn't. Maybe it would be
> best looking forward if the domctl path also cleared the full buffer
> up front, or if the clearing was moved into the function. (In the
> latter case some writes of zeros into the struct could be eliminated
> in return.)

Well, I would be OK either way, with a little preference for the latter.

Is it close to what you meant?


diff --git a/xen/common/domctl.c b/xen/common/domctl.c
index 46a0c8a..9bca133 100644
--- a/xen/common/domctl.c
+++ b/xen/common/domctl.c
@@ -69,10 +69,10 @@ void getdomaininfo(struct domain *d, struct 
xen_domctl_getdomaininfo *info)
      int flags = XEN_DOMINF_blocked;
      struct vcpu_runstate_info runstate;

+    memset(info, 0, sizeof(*info));
+
      info->domain = d->domain_id;
      info->max_vcpu_id = XEN_INVALID_MAX_VCPU_ID;
-    info->nr_online_vcpus = 0;
-    info->ssidref = 0;

      /*
       * - domain is marked as blocked only if all its vcpus are blocked
diff --git a/xen/common/sysctl.c b/xen/common/sysctl.c
index 3558641..a7ab95d 100644
--- a/xen/common/sysctl.c
+++ b/xen/common/sysctl.c
@@ -76,7 +76,7 @@ long do_sysctl(XEN_GUEST_HANDLE_PARAM(xen_sysctl_t) 
u_sysctl)
      case XEN_SYSCTL_getdomaininfolist:
      {
          struct domain *d;
-        struct xen_domctl_getdomaininfo info = { 0 };
+        struct xen_domctl_getdomaininfo info;
          u32 num_domains = 0;

          rcu_read_lock(&domlist_read_lock);


>
> Perhaps, once properly first zero-filling the struct in all cases,
> the padding field near the start should also be made explicit,
> clarifying visually that it is an option to use the space there for
> something that makes sense to live early in the struct (i.e. I
> wouldn't necessarily recommend putting there the new field you add,
> albeit - as mentioned near the top - that's certainly an option).

I read this as a request to also add uint16_t pad after "domid_t domain" 
at least. Correct?


>
> Jan
>
-- 
Regards,

Oleksandr Tyshchenko



From xen-devel-bounces@lists.xenproject.org Tue Oct 12 11:49:42 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 11:49:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.207134.362871 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maGHf-0002py-6U; Tue, 12 Oct 2021 11:49:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 207134.362871; Tue, 12 Oct 2021 11:49:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maGHf-0002pr-3D; Tue, 12 Oct 2021 11:49:27 +0000
Received: by outflank-mailman (input) for mailman id 207134;
 Tue, 12 Oct 2021 11:49:25 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=/4YK=PA=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1maGHd-0002pl-Lw
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 11:49:25 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 71431674-2b52-11ec-8120-12813bfff9fa;
 Tue, 12 Oct 2021 11:49:23 +0000 (UTC)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2056.outbound.protection.outlook.com [104.47.13.56]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-23-c4SuMLFbO42Jbk3DLWZJfg-1; Tue, 12 Oct 2021 13:49:21 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB5328.eurprd04.prod.outlook.com (2603:10a6:803:59::25)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18; Tue, 12 Oct
 2021 11:49:19 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4587.026; Tue, 12 Oct 2021
 11:49:19 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS9PR06CA0015.eurprd06.prod.outlook.com (2603:10a6:20b:462::6) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4587.21 via Frontend Transport; Tue, 12 Oct 2021 11:49:18 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 71431674-2b52-11ec-8120-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634039362;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=KcOYGgvuC1t8g3J76ShE2Z9Zi2E2a2o6MV71wjUpiZc=;
	b=OHu8Lo1i7he/qDMzEasGUWpG52m2orGj/NxwS6eJzIUEXw+8c89a+wsM1A6j7BtJCUig9z
	o3vqV7j27VEH6FpQG7IloevF2Urau3SgmhrUROibU7ycP7O2BLjz8VQCjyAUXv0TWT+Do9
	mVJmZOXH34IYHrMuJc6bdplZX9TRo8A=
X-MC-Unique: c4SuMLFbO42Jbk3DLWZJfg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=MC8PTaVet+9UB850fQ259X3+mgSZGZ60J7G8KOiIoIuRnCKBpPmy2x8byzuzdG3IWGXb43f4tWy0JHwrjxa6EAQyDWRFl54M3WgXLcR5XMRN3NRWD9uz3Gr1dd6FQTQ1943KJMWCk7TJQnjjYiGk23oJO7fP0bUWKwTBiE2BqSYPGmNLjuVSmFSVgZxm4UkMcIIrxw7uDXJOZTn32UkkyBw40afrooOAgJpkKItZ0ASzWiHvqaiwAewif8iBX3PQIa+AQiZWfLm9h0lTSrXKZT+MSijrOi18MoIxO45qIhl/bbdeCOg3I7DHYCzbRdU3XcpeATpfxiK6B3i9MMdcXw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=LrXYyPsZMP3IyLVpP4WPdYGaL6Pi4ZtvbWuubEvrdTw=;
 b=V3HJ0TYN8OqM6cwdMT3LQgyFuMTn4a7Z1VPWgupP9duzG8m1hJqiXbmhwKbibY5FpJYQRxUPonqF1a9MEh9pB5zVddFzvyupKEooSXJmIjdQaLw+J5GkYWN09WruqKD4YVg0Igm7Sh90GaNwjCprsMG4kSBZs+PXuetWnC/7anL5e2GdO4FzAOmVruipKMbaqOXwYBiMSLCHXpq4u6Yg6EgOtfYQDvJip/qhy9JG3+DCNbc1eho7aUOqyxbfEzFHEgWk5U+9c6sC47Iq0l2OMcJ601EpOhRgEYXc2UE+BeS91Bg6wkAv7bxuIqiMlX7J+S7iLK8Y5btX5l9+e487RQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [PATCH V6 1/2] xen/arm: Introduce gpaddr_bits field to struct
 xen_domctl_getdomaininfo
To: Oleksandr <olekstysh@gmail.com>
CC: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>,
 Anthony PERARD <anthony.perard@citrix.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Juergen Gross
 <jgross@suse.com>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 xen-devel@lists.xenproject.org
References: <1633974539-7380-1-git-send-email-olekstysh@gmail.com>
 <1633974539-7380-2-git-send-email-olekstysh@gmail.com>
 <1466e946-d247-2380-6d7d-cda405a2f255@suse.com>
 <68213f79-2cbc-e0cf-3181-bc487f0a5eff@gmail.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <0e03fe6e-8236-fc7d-669f-98107f40e014@suse.com>
Date: Tue, 12 Oct 2021 13:49:17 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <68213f79-2cbc-e0cf-3181-bc487f0a5eff@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS9PR06CA0015.eurprd06.prod.outlook.com
 (2603:10a6:20b:462::6) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 30c08992-a9d5-4b94-ef28-08d98d765356
X-MS-TrafficTypeDiagnostic: VI1PR04MB5328:
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB53288AE73DE0D79BD8CC0FAEB3B69@VI1PR04MB5328.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	WcgmsnDQ84bYfdO6bZhJqA0eAkMZrVEU5vWFXmdg3sZ8uL/Bv3GSoA7IrUn7iKnHNXNHdZOi9OMNk52/IHVUQ2lDTQ/BOovVqP7zjADmkqsbVJymvC0Oefr3KMQ7sxTyQReBhu827Ni+wOqDZ74R6UnEYXBtt0aW9jKg5UBqVFzNjvmIYc8f/8hMsUNJiDrleT7amQaQvD/+EL1MUYdMS9DC2LWVeEX1T8Uze0+jBsBZgiP6BoULknRXv0YtEp5+X9EthcknLVAZAZx876DYjoBqBDCqq4YQc8k57vDjMxYcShxXC3gXVSa4ZYxuNNNu4ioC1J4mUnz4Kw+1PYFeuChm3ZdyJ5bwMq+6mOiK8EYKmhRf3TltHqwWZVBYXaFu6LQ006W3ZYPNkoAWW0fxY4Uj1IBhghl2aKxM86+5/nAZ1qwchjGgv5mSVc7nItcT9hP22ROPY3If6zVEdfo1bn1uXt7H085OrGkg7SfGoI4dqhOW46G9p76o+dTjQDrw+TTp1uqJkp38cfgnqg0lM1hPCh4TCGLYhdyHx0mhr1i6+yVcIkQU0a8xkXSL8wwdIAubvezk3d1UafK2R6nxy/L0i/+ngGSGPRHbaRGbRK3d5mR8775BkTToEIg0BSMjJibRvXjXM3jURcFmXBE/7WLirp624W99HfrzcQKgWDJm385R64fDNXdp4e+wGI3BQvvF42ewSFj0jKhU5TLp61TF6sp3tjA1a+gYDGQ919YmKb0HTtez/BOJSxc4qvX4
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(2906002)(186003)(6916009)(31686004)(36756003)(8676002)(7416002)(54906003)(508600001)(26005)(8936002)(316002)(4326008)(5660300002)(16576012)(83380400001)(66946007)(66476007)(53546011)(38100700002)(31696002)(956004)(2616005)(86362001)(66556008)(6486002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?UqWNmKloLx2eBZlzYjKnmmHpu35Z3q0d6eqzdin9KeAclmUmtJER40vFpupi?=
 =?us-ascii?Q?Filos1zVpae/7SulDCfGvucmN8fLYnOMHZLHwYzgqy5V/vHpfxAp3UNKk4zQ?=
 =?us-ascii?Q?LpjrUaMTBcnwHWQOi1zpwLpevOFx39fwp0STEH4Ddx3UBiQhdgoFvXfy9rDR?=
 =?us-ascii?Q?UxKTNpnkcESzb2M3r/R0CEFZtvIR6eDqIGrh8ByWJaA7OIzSc5lr8dPdXtem?=
 =?us-ascii?Q?gdeBMtz2Aw1lJT5rSraHgDd4mqEOyo440/AjD85np7roP9IcxQK5eac+UcpH?=
 =?us-ascii?Q?emuBc72AGnP9RJSGCGy+5T1Zu+LtL36nBdDLtIVI6Ahvc5yvU7PClQg2MIAZ?=
 =?us-ascii?Q?ZHkL6BKz/D0yMFotni/Q0Q5FlDfQ5CZWZ/gqEKTNL4lnCddgN7tjSd9K/aVk?=
 =?us-ascii?Q?mL04nPrcpf8giEl4x8njJhSpY1+XAc58bBp5ls37SjzXY6iuEI3TeULUBCRb?=
 =?us-ascii?Q?gsWpVmvQbHWo4uv1MXHrZvSus0ufGUSQxpsefnUAjts2dWgMEusBkgsQ2GrQ?=
 =?us-ascii?Q?eYgoHCHtFw9M0QNohva1qLEFk5yUmdDbtCKs3gjl82/4LHJdv1tDDnAZZiru?=
 =?us-ascii?Q?bIXcjC3M9NboQUOtrqnNSYvD9GyVJs9sWznXiqSqGom0VE1Y1tb2feQK03Aw?=
 =?us-ascii?Q?FK7zy14nJrx8ObUGkCcYSq3ZOi4oXoi/WoA0e96DVYNHJ78Ueol5I7ihtWBi?=
 =?us-ascii?Q?6/lR5+dRzPIoVnGvk7sb7lAMjQEjYGIB7pUjpS2+mBkEeA52ncdp7hZq/TNw?=
 =?us-ascii?Q?7YnEK0UjZSf3N7JFh+iOvhSegagEAe6Y/M8ByZsIacqd6uMf+9ymS9aUBmvr?=
 =?us-ascii?Q?oCtHxruRihrklBgPenfkPZoGGT6rfhfAHRv6Pe8gcQVh9z2G9zwjOJIOuYwr?=
 =?us-ascii?Q?UpQt6udhKsvMH8QN/zKY/LmQEV/ClCtTvMG92WnoLbjRvMoSg8j92Z+EfvLK?=
 =?us-ascii?Q?PDi+Drl6Liv6xszdedqobZ5eKIJu6MXjXzfjL48lSHNLhxUGgQ9rVKzHKXQ7?=
 =?us-ascii?Q?Xame8XpCROMSTFdMd0BgQPQmskahLLvP33t4aJkliyOr5Jg56auPTZuuvmO3?=
 =?us-ascii?Q?IipZLedDleWYIUlvuYkUGgqHXgwCQ4EjXk9dfU126zSfzOnm2uuvIyx/QcJc?=
 =?us-ascii?Q?g9yxKqBPDMcQuMwJ1hwhZKdLqsjKuWWCcchb5kV45oMMQNqQvx+fBJqvWGvo?=
 =?us-ascii?Q?wNhaUsTZCmzgdX348t7I1xPQKK9FHTAFsnwnTVq8t85Y9ErEI322u7ilRJyb?=
 =?us-ascii?Q?Hbv3HHrF/j5vv3LhexqzCmkMDuVkZTMbE6ZC5m54yFgIoSYfLQoMyaOS8FF1?=
 =?us-ascii?Q?yr3KTFte99UbmUqKNp+IhJDR?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 30c08992-a9d5-4b94-ef28-08d98d765356
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2021 11:49:19.4358
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: rEJVmAQtFH8xhtYV/QYlsS+TCHhQH0XYsHVFKWrXBJq9q0nByDsgkUr2qi/vrGQIRFRE8a2mNdAvd5E7hFBkOA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5328

On 12.10.2021 13:28, Oleksandr wrote:
> On 12.10.21 12:24, Jan Beulich wrote:
>> On 11.10.2021 19:48, Oleksandr Tyshchenko wrote:
>>> @@ -150,6 +150,7 @@ struct xen_domctl_getdomaininfo {
>>>       uint32_t ssidref;
>>>       xen_domain_handle_t handle;
>>>       uint32_t cpupool;
>>> +    uint8_t gpaddr_bits; /* Guest physical address space size. */
>>>       struct xen_arch_domainconfig arch_config;
>> On the basis of the above, please add uint8_t pad[3] (or perhaps
>> better pad[7] to be independent of the present
>> alignof(struct xen_arch_domainconfig) =3D=3D 4) and make sure the
>> array will always be zero-filled, such that the padding space can
>> subsequently be assigned a purpose without needing to bump the
>> interface version(s) again.
>=20
> ok, will do.
>=20
>=20
>>
>> Right now the sysctl caller of getdomaininfo() clears the full
>> structure (albeit only once, so stale / inapplicable data might get
>> reported for higher numbered domains if any field was filled only
>> in certain cases), while the domctl one doesn't. Maybe it would be
>> best looking forward if the domctl path also cleared the full buffer
>> up front, or if the clearing was moved into the function. (In the
>> latter case some writes of zeros into the struct could be eliminated
>> in return.)
>=20
> Well, I would be OK either way, with a little preference for the latter.
>=20
> Is it close to what you meant?

Yes, just that ...

> --- a/xen/common/domctl.c
> +++ b/xen/common/domctl.c
> @@ -69,10 +69,10 @@ void getdomaininfo(struct domain *d, struct=20
> xen_domctl_getdomaininfo *info)
>  =C2=A0=C2=A0=C2=A0=C2=A0 int flags =3D XEN_DOMINF_blocked;
>  =C2=A0=C2=A0=C2=A0=C2=A0 struct vcpu_runstate_info runstate;
>=20
> +=C2=A0=C2=A0=C2=A0 memset(info, 0, sizeof(*info));
> +
>  =C2=A0=C2=A0=C2=A0=C2=A0 info->domain =3D d->domain_id;
>  =C2=A0=C2=A0=C2=A0=C2=A0 info->max_vcpu_id =3D XEN_INVALID_MAX_VCPU_ID;
> -=C2=A0=C2=A0=C2=A0 info->nr_online_vcpus =3D 0;
> -=C2=A0=C2=A0=C2=A0 info->ssidref =3D 0;

... there are a few more "... =3D 0" further down iirc.

>> Perhaps, once properly first zero-filling the struct in all cases,
>> the padding field near the start should also be made explicit,
>> clarifying visually that it is an option to use the space there for
>> something that makes sense to live early in the struct (i.e. I
>> wouldn't necessarily recommend putting there the new field you add,
>> albeit - as mentioned near the top - that's certainly an option).
>=20
> I read this as a request to also add uint16_t pad after "domid_t domain"=
=20
> at least. Correct?

I guess I should really leave this up to you - that's largely a cosmetic
thing after all once clearing the whole struct up front.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Oct 12 12:16:24 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 12:16:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.207149.362882 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maGhd-000642-9Y; Tue, 12 Oct 2021 12:16:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 207149.362882; Tue, 12 Oct 2021 12:16:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maGhd-00063v-6f; Tue, 12 Oct 2021 12:16:17 +0000
Received: by outflank-mailman (input) for mailman id 207149;
 Tue, 12 Oct 2021 12:16:16 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1maGhc-00063l-AE; Tue, 12 Oct 2021 12:16:16 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1maGhc-0000OM-3d; Tue, 12 Oct 2021 12:16:16 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1maGhb-0000XH-PW; Tue, 12 Oct 2021 12:16:15 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1maGhb-0008Sw-P1; Tue, 12 Oct 2021 12:16:15 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=gbt2T+biD7iHDsQMn3E4tNW5mYpKTWINT6oCby0P1gQ=; b=JuoCYpwqqlvan9Qlq4RDUXa5M8
	yI5E28HuEciHDwnsH78YXX9eYCZVAIKMgP21rAdPtgDziZssVQevRoaH2pUWMXBHn3S8IIT3MNlG+
	fm8ZZ3r/t365+uFv+s0RVmF8xONC7MYkl9dVI4yW69a1hEra0xNaS0YHUd1sO0OiTOfQ=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165473-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 165473: regressions - FAIL
X-Osstest-Failures:
    libvirt:build-armhf-libvirt:libvirt-build:fail:regression
    libvirt:build-amd64-libvirt:libvirt-build:fail:regression
    libvirt:build-arm64-libvirt:libvirt-build:fail:regression
    libvirt:build-i386-libvirt:libvirt-build:fail:regression
    libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    libvirt=e3c5a8ec735ac62817d6d4c42e89720cbbfeaf9c
X-Osstest-Versions-That:
    libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 12 Oct 2021 12:16:15 +0000

flight 165473 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165473/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-armhf-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-amd64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-arm64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-i386-libvirt            6 libvirt-build            fail REGR. vs. 151777

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-libvirt-vhd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a

version targeted for testing:
 libvirt              e3c5a8ec735ac62817d6d4c42e89720cbbfeaf9c
baseline version:
 libvirt              2c846fa6bcc11929c9fb857a22430fb9945654ad

Last test of basis   151777  2020-07-10 04:19:19 Z  459 days
Failing since        151818  2020-07-11 04:18:52 Z  458 days  444 attempts
Testing same since   165473  2021-10-12 04:20:04 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
    Adolfo Jayme Barrientos <fitoschido@gmail.com>
  Aleksandr Alekseev <alexander.alekseev@virtuozzo.com>
  Aleksei Zakharov <zaharov@selectel.ru>
  Andika Triwidada <andika@gmail.com>
  Andrea Bolognani <abologna@redhat.com>
  Ani Sinha <ani@anisinha.ca>
  Balázs Meskó <meskobalazs@mailbox.org>
  Barrett Schonefeld <bschoney@utexas.edu>
  Bastian Germann <bastiangermann@fishpost.de>
  Bastien Orivel <bastien.orivel@diateam.net>
  BiaoXiang Ye <yebiaoxiang@huawei.com>
  Bihong Yu <yubihong@huawei.com>
  Binfeng Wu <wubinfeng@huawei.com>
  Bjoern Walk <bwalk@linux.ibm.com>
  Boris Fiuczynski <fiuczy@linux.ibm.com>
  Brian Turek <brian.turek@gmail.com>
  Bruno Haible <bruno@clisp.org>
  Chris Mayo <aklhfex@gmail.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Ehrhardt <christian.ehrhardt@canonical.com>
  Christian Kirbach <christian.kirbach@gmail.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Cole Robinson <crobinso@redhat.com>
  Collin Walling <walling@linux.ibm.com>
  Cornelia Huck <cohuck@redhat.com>
  Cédric Bosdonnat <cbosdonnat@suse.com>
  Côme Borsoi <fedora@borsoi.fr>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniel Letai <dani@letai.org.il>
  Daniel P. Berrange <berrange@redhat.com>
  Daniel P. Berrangé <berrange@redhat.com>
  Didik Supriadi <didiksupriadi41@gmail.com>
  dinglimin <dinglimin@cmss.chinamobile.com>
  Dmytro Linkin <dlinkin@nvidia.com>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Eric Farman <farman@linux.ibm.com>
  Erik Skultety <eskultet@redhat.com>
  Fabian Affolter <mail@fabian-affolter.ch>
  Fabian Freyer <fabian.freyer@physik.tu-berlin.de>
  Fabiano Fidêncio <fabiano@fidencio.org>
  Fangge Jin <fjin@redhat.com>
  Farhan Ali <alifm@linux.ibm.com>
  Fedora Weblate Translation <i18n@lists.fedoraproject.org>
  gongwei <gongwei@smartx.com>
  Guoyi Tu<tu.guoyi@h3c.com>
  Göran Uddeborg <goeran@uddeborg.se>
  Halil Pasic <pasic@linux.ibm.com>
  Han Han <hhan@redhat.com>
  Hao Wang <wanghao232@huawei.com>
  Hela Basa <r45xveza@pm.me>
  Helmut Grohne <helmut@subdivi.de>
  Hiroki Narukawa <hnarukaw@yahoo-corp.jp>
  Ian Wienand <iwienand@redhat.com>
  Jakob Meng <jakobmeng@web.de>
  Jamie Strandboge <jamie@canonical.com>
  Jamie Strandboge <jamie@ubuntu.com>
  Jan Kuparinen <copper_fin@hotmail.com>
  jason lee <ppark5237@gmail.com>
  Jean-Baptiste Holcroft <jean-baptiste@holcroft.fr>
  Jia Zhou <zhou.jia2@zte.com.cn>
  Jianan Gao <jgao@redhat.com>
  Jim Fehlig <jfehlig@suse.com>
  Jin Yan <jinyan12@huawei.com>
  Jinsheng Zhang <zhangjl02@inspur.com>
  Jiri Denemark <jdenemar@redhat.com>
  John Ferlan <jferlan@redhat.com>
  Jonathan Watt <jwatt@jwatt.org>
  Jonathon Jongsma <jjongsma@redhat.com>
  Julio Faracco <jcfaracco@gmail.com>
  Justin Gatzen <justin.gatzen@gmail.com>
  Ján Tomko <jtomko@redhat.com>
  Kashyap Chamarthy <kchamart@redhat.com>
  Kevin Locke <kevin@kevinlocke.name>
  Kristina Hanicova <khanicov@redhat.com>
  Laine Stump <laine@redhat.com>
  Laszlo Ersek <lersek@redhat.com>
  Lee Yarwood <lyarwood@redhat.com>
  Lei Yang <yanglei209@huawei.com>
  Liao Pingfang <liao.pingfang@zte.com.cn>
  Lin Ma <lma@suse.com>
  Lin Ma <lma@suse.de>
  Lin Ma <morecache@gmail.com>
  Liu Yiding <liuyd.fnst@fujitsu.com>
  Luke Yue <lukedyue@gmail.com>
  Luyao Zhong <luyao.zhong@intel.com>
  Marc Hartmayer <mhartmay@linux.ibm.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Markus Schade <markus.schade@hetzner.com>
  Martin Kletzander <mkletzan@redhat.com>
  Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
  Matej Cepl <mcepl@cepl.eu>
  Matt Coleman <matt@datto.com>
  Matt Coleman <mcoleman@datto.com>
  Mauro Matteo Cascella <mcascell@redhat.com>
  Meina Li <meili@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Michał Smyk <fedora@smyk.it>
  Milo Casagrande <milo@milo.name>
  Moshe Levi <moshele@nvidia.com>
  Muha Aliss <muhaaliss@gmail.com>
  Nathan <nathan95@live.it>
  Neal Gompa <ngompa13@gmail.com>
  Nick Chevsky <nchevsky@gmail.com>
  Nick Shyrokovskiy <nshyrokovskiy@gmail.com>
  Nickys Music Group <nickys.music.group@gmail.com>
  Nico Pache <npache@redhat.com>
  Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
  Olaf Hering <olaf@aepfle.de>
  Olesya Gerasimenko <gammaray@basealt.ru>
  Orion Poplawski <orion@nwra.com>
  Pany <geekpany@gmail.com>
  Patrick Magauran <patmagauran.j@gmail.com>
  Paulo de Rezende Pinatti <ppinatti@linux.ibm.com>
  Pavel Hrdina <phrdina@redhat.com>
  Peng Liang <liangpeng10@huawei.com>
  Peter Krempa <pkrempa@redhat.com>
  Pino Toscano <ptoscano@redhat.com>
  Pino Toscano <toscano.pino@tiscali.it>
  Piotr Drąg <piotrdrag@gmail.com>
  Prathamesh Chavan <pc44800@gmail.com>
  Richard W.M. Jones <rjones@redhat.com>
  Ricky Tigg <ricky.tigg@gmail.com>
  Robin Lee <cheeselee@fedoraproject.org>
  Roman Bogorodskiy <bogorodskiy@gmail.com>
  Roman Bolshakov <r.bolshakov@yadro.com>
  Ryan Gahagan <rgahagan@cs.utexas.edu>
  Ryan Schmidt <git@ryandesign.com>
  Sam Hartman <hartmans@debian.org>
  Scott Shambarger <scott-libvirt@shambarger.net>
  Sebastian Mitterle <smitterl@redhat.com>
  SeongHyun Jo <caelus9536@gmail.com>
  Shalini Chellathurai Saroja <shalini@linux.ibm.com>
  Shaojun Yang <yangshaojun@phytium.com.cn>
  Shi Lei <shi_lei@massclouds.com>
  simmon <simmon@nplob.com>
  Simon Chopin <chopin.simon@gmail.com>
  Simon Gaiser <simon@invisiblethingslab.com>
  Simon Rowe <simon.rowe@nutanix.com>
  Stefan Bader <stefan.bader@canonical.com>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Berger <stefanb@linux.vnet.ibm.com>
  Stefan Hajnoczi <stefanha@gmail.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Szymon Scholz <szymonscholz@gmail.com>
  Thomas Huth <thuth@redhat.com>
  Tim Wiederhake <twiederh@redhat.com>
  Tomáš Golembiovský <tgolembi@redhat.com>
  Tomáš Janoušek <tomi@nomi.cz>
  Tuguoyi <tu.guoyi@h3c.com>
  Victor Toso <victortoso@redhat.com>
  Ville Skyttä <ville.skytta@iki.fi>
  Vinayak Kale <vkale@nvidia.com>
  Wang Xin <wangxinxin.wang@huawei.com>
  WangJian <wangjian161@huawei.com>
  Weblate <noreply@weblate.org>
  Wei Liu <liuwe@microsoft.com>
  Wei Liu <wei.liu@kernel.org>
  William Douglas <william.douglas@intel.com>
  Yalei Li <274268859@qq.com>
  Yalei Li <liyl43@chinatelecom.cn>
  Yang Fei <yangfei85@huawei.com>
  Yang Hang <yanghang44@huawei.com>
  Yanqiu Zhang <yanqzhan@redhat.com>
  Yaroslav Kargin <ykargin@virtuozzo.com>
  Yi Li <yili@winhong.com>
  Yi Wang <wang.yi59@zte.com.cn>
  Yuri Chornoivan <yurchor@ukr.net>
  Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
  zhangjl02 <zhangjl02@inspur.com>
  Zheng Chuan <zhengchuan@huawei.com>
  zhenwei pi <pizhenwei@bytedance.com>
  Zhenyu Ye <yezhenyu2@huawei.com>
  Zhenyu Zheng <zheng.zhenyu@outlook.com>
  Zhenzhong Duan <zhenzhong.duan@intel.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          fail    
 build-arm64-libvirt                                          fail    
 build-armhf-libvirt                                          fail    
 build-i386-libvirt                                           fail    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           blocked 
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-libvirt-xsm                                 blocked 
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-libvirt                                     blocked 
 test-arm64-arm64-libvirt                                     blocked 
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-libvirt-pair                                blocked 
 test-amd64-i386-libvirt-pair                                 blocked 
 test-arm64-arm64-libvirt-qcow2                               blocked 
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-libvirt-vhd                                 blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 77452 lines long.)


From xen-devel-bounces@lists.xenproject.org Tue Oct 12 12:31:41 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 12:31:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.207159.362897 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maGwQ-0008JT-Ld; Tue, 12 Oct 2021 12:31:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 207159.362897; Tue, 12 Oct 2021 12:31:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maGwQ-0008JM-IF; Tue, 12 Oct 2021 12:31:34 +0000
Received: by outflank-mailman (input) for mailman id 207159;
 Tue, 12 Oct 2021 12:31:32 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1maGwO-0008JG-Sc
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 12:31:32 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1maGwO-0000df-Jz; Tue, 12 Oct 2021 12:31:32 +0000
Received: from 54-240-197-233.amazon.com ([54.240.197.233] helo=[192.168.23.5])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1maGwO-00049r-Dh; Tue, 12 Oct 2021 12:31:32 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=KY7ufSCulkJ7KA2tjZh4c+Ude6x03oYo4RlI8eXkAlI=; b=lWnvqk4IVjtFdTS2aD1gTq4pZp
	JEoDzgJy7v5HzxqZ5NGa68uGzWhEfIBLNax7PEN+sIJ13ObOr+ZJn4pZ/3aSIXIahDgmIBWoGckWs
	9kHt2UrFFQx05slTxvZVEIttFAlbxHmpXbunumYEn1LMmFqnYFjT+3wSlnCWtYeg7pSs=;
Message-ID: <deb9f2e3-f0d7-e6ea-9867-ed9c1a66dcb0@xen.org>
Date: Tue, 12 Oct 2021 13:31:30 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.2.0
Subject: Re: [PATCH v2 11/12] xen/arch: Drop asm-*/trace.h
To: Andrew Cooper <andrew.cooper3@citrix.com>,
 Xen-devel <xen-devel@lists.xenproject.org>
Cc: Jan Beulich <JBeulich@suse.com>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>, Wei Liu <wl@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <20210920172529.24932-1-andrew.cooper3@citrix.com>
 <20210920172529.24932-12-andrew.cooper3@citrix.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20210920172529.24932-12-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Andrew,

On 20/09/2021 18:25, Andrew Cooper wrote:
> The feature is x86 and pv-dom0 specific, and each architecture's main trace.h
> files are empty.  Don't force all new architectures to create an empty file.
> 
> While moving the declaration of tb_init_done, change from int to bool.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

For the Arm bits:

Acked-by: Julien Grall <jgrall@amazon.com>

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Tue Oct 12 13:08:07 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 13:08:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.207170.362908 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maHVT-00039b-CT; Tue, 12 Oct 2021 13:07:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 207170.362908; Tue, 12 Oct 2021 13:07:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maHVT-00039U-9M; Tue, 12 Oct 2021 13:07:47 +0000
Received: by outflank-mailman (input) for mailman id 207170;
 Tue, 12 Oct 2021 13:07:45 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=/L4W=PA=gmail.com=jandryuk@srs-us1.protection.inumbo.net>)
 id 1maHVR-00038a-A1
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 13:07:45 +0000
Received: from mail-lf1-x131.google.com (unknown [2a00:1450:4864:20::131])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 1fa1a7b2-bd31-4b19-ba9a-5178f89003e2;
 Tue, 12 Oct 2021 13:07:44 +0000 (UTC)
Received: by mail-lf1-x131.google.com with SMTP id j21so69921848lfe.0
 for <xen-devel@lists.xenproject.org>; Tue, 12 Oct 2021 06:07:44 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1fa1a7b2-bd31-4b19-ba9a-5178f89003e2
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=rYG56F/pmgMHv1mArUcA8EEq00+Sgti/K9FJa+oQWXk=;
        b=M9NkcejAIFMD9Vvc5kH26nk2yLKGRqy48zBmflcT4XDcmuPtHMkFigWJykHZGApZMz
         Rttt21COCUYuUewkdNzceE0E1cZRcP/I/h/jk9Z5N0Kt0wxFe62o1brCdWPBjot0/dfh
         HZyA92CLwzWKsdJHcJsJERPPlRLvQrp8cd4+Lonjq8MU/PbI7gg6Mb2+1gF3NqVn10M+
         tCPNLBDxFH6bxB2LOSouw8rn6om3JPZdKlhDfgvQZP8CEDZyrvS3xbSqVzHboJdRATkZ
         +bAaEvn+ifst8AyUGQPhfb5/ntK+cPpCrSs1f6VRJoO7c5PDY0+LL5MqT4R5YeChV07B
         t/BA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=rYG56F/pmgMHv1mArUcA8EEq00+Sgti/K9FJa+oQWXk=;
        b=cLbfozmgJp30mad1hNTRSqE3x+V3WEQJCYLeEo8qAkTt9cuv8U39ZnPLnwlMxsse7G
         7+OiTdooIGMA0TEoQS5rb9PQdWYAU4w4jfiP38wenMVkMQdcRwVlf6IcbutqQTEXm/lu
         2WnOvpjqCagzUQss4GJz82U8P0hWsLil2vHvNZ6+YrPIWrdoYXZhVJPVuO8gaP75HOsi
         xU+Qr6RWbKi8JhQnJjNSmxvr9jQX/dwHswjSn1Hd/gk/nLynecR3kzVw/0Gd4lQFscrE
         1JMsrg6QkrHGt57Pn0ubdws8Dn2E/p/uUrKvqSG30nhI9MaOUP5s+tc3YfIqJnzmUePR
         /6XQ==
X-Gm-Message-State: AOAM530M68rZ1uLqd8yQlj9CwmQPCSpYzbR2NL0lWaMiiqlQyd458gGl
	uRgilveWOv5jsz8lNZgBHu5ntcz1unxUXJ8fyI8=
X-Google-Smtp-Source: ABdhPJz61t07almgu0IAokxTxZ7zlkSBd1avA5oFDY7xmLI1j3ABt4rWihEiEMk01DF+Cr5t5BcjWjuAZsMbGht60Es=
X-Received: by 2002:a2e:89cd:: with SMTP id c13mr28669547ljk.168.1634044063520;
 Tue, 12 Oct 2021 06:07:43 -0700 (PDT)
MIME-Version: 1.0
References: <CALjTZvbzYfBuLB+H=fj2J+9=DxjQ2Uqcy0if_PvmJ-nU-qEgkg@mail.gmail.com>
 <b023adf9-e21c-59ac-de49-57915c8cede8@oderland.se> <c9218eb4-9fc1-28f4-d053-895bab0473d4@oderland.se>
 <ef163327-f965-09f8-4396-2c1c4e689a6d@oderland.se>
In-Reply-To: <ef163327-f965-09f8-4396-2c1c4e689a6d@oderland.se>
From: Jason Andryuk <jandryuk@gmail.com>
Date: Tue, 12 Oct 2021 09:07:31 -0400
Message-ID: <CAKf6xpvGyCKVHsvauP54=0j10fxis4XiiqBNWH+1cpkbtt_QJw@mail.gmail.com>
Subject: Re: [REGRESSION][BISECTED] 5.15-rc1: Broken AHCI on NVIDIA ION (MCP79)
To: Josef Johansson <josef@oderland.se>
Cc: Thomas Gleixner <tglx@linutronix.de>, maz@kernel.org, linux-pci@vger.kernel.org, 
	open list <linux-kernel@vger.kernel.org>, xen-devel <xen-devel@lists.xenproject.org>
Content-Type: text/plain; charset="UTF-8"

On Tue, Oct 12, 2021 at 2:09 AM Josef Johansson <josef@oderland.se> wrote:
>
> On 10/11/21 21:34, Josef Johansson wrote:
> > On 10/11/21 20:47, Josef Johansson wrote:
> >> More can be read over at freedesktop:
> >> https://gitlab.freedesktop.org/drm/amd/-/issues/1715

Hi, Josef,

If you compare
commit fcacdfbef5a1633211ebfac1b669a7739f5b553e "PCI/MSI: Provide a
new set of mask and unmask functions"
and
commit 446a98b19fd6da97a1fb148abb1766ad89c9b767 "PCI/MSI: Use new
mask/unmask functions" some of the replacement functions in 446198b1
no longer exit early for the pci_msi_ignore_mask flag.

Josef, I'd recommend you try adding pci_msi_ignore_mask checks to the
new functions in fcacdfbef5a to see if that helps.

There was already a pci_msi_ignore_mask fixup in commit
1a519dc7a73c977547d8b5108d98c6e769c89f4b "PCI/MSI: Skip masking MSI-X
on Xen PV" though the kernel was crashing in that case.

Regards,
Jason


From xen-devel-bounces@lists.xenproject.org Tue Oct 12 13:18:23 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 13:18:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.207177.362918 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maHfc-0004bP-Cd; Tue, 12 Oct 2021 13:18:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 207177.362918; Tue, 12 Oct 2021 13:18:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maHfc-0004bI-9f; Tue, 12 Oct 2021 13:18:16 +0000
Received: by outflank-mailman (input) for mailman id 207177;
 Tue, 12 Oct 2021 13:18:15 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=P4MT=PA=gmail.com=olekstysh@srs-us1.protection.inumbo.net>)
 id 1maHfb-0004bC-BO
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 13:18:15 +0000
Received: from mail-lf1-x12e.google.com (unknown [2a00:1450:4864:20::12e])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 4d6b9054-f05d-4417-9f2f-9703a95a810d;
 Tue, 12 Oct 2021 13:18:14 +0000 (UTC)
Received: by mail-lf1-x12e.google.com with SMTP id p16so16954960lfa.2
 for <xen-devel@lists.xenproject.org>; Tue, 12 Oct 2021 06:18:14 -0700 (PDT)
Received: from [192.168.1.7] ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id o6sm183465lfr.19.2021.10.12.06.18.12
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Tue, 12 Oct 2021 06:18:12 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4d6b9054-f05d-4417-9f2f-9703a95a810d
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-transfer-encoding:content-language;
        bh=QpKqygwgbmbmWIw4bWoPgXdUNCBdr92kg5Gqj+0zhcI=;
        b=d5xlA7cNkd2c4RSzms7sRDsLz9LIF+iZwSQ/exz6smKJEKzbAavNlHGI+tw4k9VQ+/
         LgPUekRF3a3ViamnNtzHNQ/BHL68iiX8KJvFm0avlQ6CV5G+RqFt+M7s6LrtwXJkaRlX
         w1jFsvL/eSg4ISRAosNByHT/EK7qpXp9tg6EOdiEQsQIaHlxeHLAmzG6hVikmbigCsFK
         kch1nKcCbyCSDXpDcbtHKYbiV2llUTZx3sXowWwoo06orV6NlaF3vs62yMtnaHVRz1D2
         uXPD9iJnxL8KiWO/8JuoRiNpYMsUw8opewJJVpUPkMrAm0h3TKbuMILwVXKnIyJDLPYE
         k5aQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding
         :content-language;
        bh=QpKqygwgbmbmWIw4bWoPgXdUNCBdr92kg5Gqj+0zhcI=;
        b=IBmXmhLrkIq4jx7vUiCF6WfqUmtbKiXxrD8JgN3EP3c5c6g+iUe/9VEVNxpkXmQaqn
         iN4AiINylb9Kh8/f4y6T/r7oRaOhfnYh6xcD6PPduEEP3N/9oo4Ouei7qCSoq5iGPaob
         zHXJsy6816rgYS4ix/YT4LkIFL05X4l2/5imUf0Ijs+T3/akYsJARSGANaW1J7K3Zl5z
         +4LgzizioasYP50pUw3BE+LK7bWjckNBTAWKighwrh10dE73SSDYP+ZGa7ykKpv343xn
         h4jgZtU95eoROLfu/paIFG7xIbFYYPEJ2zeT5avxMSXYMxAHKJ19188D25bwnQOPvTQN
         zO6g==
X-Gm-Message-State: AOAM531Jca0CpaSfphgKC8MuvttGedV4W2UG2uUGrSJ93yu0bjEDJOD2
	ik2+Jmqgf85d0oha2zW5+5x5ewklVZA=
X-Google-Smtp-Source: ABdhPJza7QD9Hl1E0JIABgAUh14c24M70XmvT9FrGvSbwPa+H+tubiYWTivSuATxkicMW/jkCGXadw==
X-Received: by 2002:ac2:592f:: with SMTP id v15mr17816973lfi.17.1634044692972;
        Tue, 12 Oct 2021 06:18:12 -0700 (PDT)
Subject: Re: [PATCH V6 1/2] xen/arm: Introduce gpaddr_bits field to struct
 xen_domctl_getdomaininfo
To: Jan Beulich <jbeulich@suse.com>
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>,
 Anthony PERARD <anthony.perard@citrix.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Juergen Gross
 <jgross@suse.com>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 xen-devel@lists.xenproject.org
References: <1633974539-7380-1-git-send-email-olekstysh@gmail.com>
 <1633974539-7380-2-git-send-email-olekstysh@gmail.com>
 <1466e946-d247-2380-6d7d-cda405a2f255@suse.com>
 <68213f79-2cbc-e0cf-3181-bc487f0a5eff@gmail.com>
 <0e03fe6e-8236-fc7d-669f-98107f40e014@suse.com>
From: Oleksandr <olekstysh@gmail.com>
Message-ID: <31f869a5-5788-74c7-c290-ce6797584e9e@gmail.com>
Date: Tue, 12 Oct 2021 16:18:11 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <0e03fe6e-8236-fc7d-669f-98107f40e014@suse.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US


On 12.10.21 14:49, Jan Beulich wrote:

Hi Jan

> On 12.10.2021 13:28, Oleksandr wrote:
>> On 12.10.21 12:24, Jan Beulich wrote:
>>> On 11.10.2021 19:48, Oleksandr Tyshchenko wrote:
>>>> @@ -150,6 +150,7 @@ struct xen_domctl_getdomaininfo {
>>>>        uint32_t ssidref;
>>>>        xen_domain_handle_t handle;
>>>>        uint32_t cpupool;
>>>> +    uint8_t gpaddr_bits; /* Guest physical address space size. */
>>>>        struct xen_arch_domainconfig arch_config;
>>> On the basis of the above, please add uint8_t pad[3] (or perhaps
>>> better pad[7] to be independent of the present
>>> alignof(struct xen_arch_domainconfig) == 4) and make sure the
>>> array will always be zero-filled, such that the padding space can
>>> subsequently be assigned a purpose without needing to bump the
>>> interface version(s) again.
>> ok, will do.
>>
>>
>>> Right now the sysctl caller of getdomaininfo() clears the full
>>> structure (albeit only once, so stale / inapplicable data might get
>>> reported for higher numbered domains if any field was filled only
>>> in certain cases), while the domctl one doesn't. Maybe it would be
>>> best looking forward if the domctl path also cleared the full buffer
>>> up front, or if the clearing was moved into the function. (In the
>>> latter case some writes of zeros into the struct could be eliminated
>>> in return.)
>> Well, I would be OK either way, with a little preference for the latter.
>>
>> Is it close to what you meant?
> Yes, just that ...
>
>> --- a/xen/common/domctl.c
>> +++ b/xen/common/domctl.c
>> @@ -69,10 +69,10 @@ void getdomaininfo(struct domain *d, struct
>> xen_domctl_getdomaininfo *info)
>>        int flags = XEN_DOMINF_blocked;
>>        struct vcpu_runstate_info runstate;
>>
>> +    memset(info, 0, sizeof(*info));
>> +
>>        info->domain = d->domain_id;
>>        info->max_vcpu_id = XEN_INVALID_MAX_VCPU_ID;
>> -    info->nr_online_vcpus = 0;
>> -    info->ssidref = 0;
> ... there are a few more "... = 0" further down iirc.

I didn't spot anything except "info->flags = ..." which probably can now 
be converted into "info->flags |= ..."


>
>>> Perhaps, once properly first zero-filling the struct in all cases,
>>> the padding field near the start should also be made explicit,
>>> clarifying visually that it is an option to use the space there for
>>> something that makes sense to live early in the struct (i.e. I
>>> wouldn't necessarily recommend putting there the new field you add,
>>> albeit - as mentioned near the top - that's certainly an option).
>> I read this as a request to also add uint16_t pad after "domid_t domain"
>> at least. Correct?
> I guess I should really leave this up to you - that's largely a cosmetic
> thing after all once clearing the whole struct up front.

ok, thank you for the clarification.


>
> Jan
>
-- 
Regards,

Oleksandr Tyshchenko



From xen-devel-bounces@lists.xenproject.org Tue Oct 12 13:26:31 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 13:26:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.207186.362929 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maHnX-00065W-8P; Tue, 12 Oct 2021 13:26:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 207186.362929; Tue, 12 Oct 2021 13:26:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maHnX-00065P-5X; Tue, 12 Oct 2021 13:26:27 +0000
Received: by outflank-mailman (input) for mailman id 207186;
 Tue, 12 Oct 2021 13:26:25 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=/4YK=PA=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1maHnV-00065J-RQ
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 13:26:25 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id fee2ed6c-2b5f-11ec-8128-12813bfff9fa;
 Tue, 12 Oct 2021 13:26:24 +0000 (UTC)
Received: from EUR03-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur03lp2056.outbound.protection.outlook.com [104.47.10.56]) (Using
 TLS) by relay.mimecast.com with ESMTP id de-mta-1-hdrcOWgbN9qPkIOw4Dr4ow-2;
 Tue, 12 Oct 2021 15:26:22 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB2957.eurprd04.prod.outlook.com (2603:10a6:802:4::28) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.25; Tue, 12 Oct
 2021 13:26:19 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4587.026; Tue, 12 Oct 2021
 13:26:19 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM5PR0101CA0022.eurprd01.prod.exchangelabs.com (2603:10a6:206:16::35) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.25 via Frontend
 Transport; Tue, 12 Oct 2021 13:26:18 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fee2ed6c-2b5f-11ec-8128-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634045183;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=kMM+Wk8I0JSbqcSEVuP6xXOlW16RBO1J/1v5wqpoWLE=;
	b=A58c1lqurxaaNucg0QhTUDeUNBAwyq81HP9KxxAvtZv9eIZsZB1Z4SSPqOXAjBreTHev3G
	UTwucTJyIVd2jJwYJqqEwrzNwhOOYAWzsTraUoMbY1SYqfPL3uEaBGimHxigvqBpzhjnVV
	NvOUh1pA9gwJFfQ3lKumet94AG/i8ic=
X-MC-Unique: hdrcOWgbN9qPkIOw4Dr4ow-2
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=JFGf7RtcuwTxpn0yLtDNfcS5oHJLRkJpa0KCRGZcTRux8XksvZefduQO9l5vswZFQF2ucoPRgPWfDj8Ljprstx+oeFETpbVnP7CHxwH9Vk4fQGC+9tM9wH0TMbMV/YuVzhoY2eMufMNCqmk7BQPXLiGCLAbq+Gjj0kbWOmJTuIqi3bofaiTmP1ihIZN4+cPTw48tfUng+/2gORtQrQwzN7lerEimPJQPdffcnIuuGU8k+ETNKGD7tRJxC9OKB7YgAXT+hWtJUp11FGIy/pCROV/f2ATutepanbN9U/9I8zXP1ssT+rOptnnzBOzZgJ4gZ1Af1aYCLIIGOJkERMOp9w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=IToWpyt7AOU2OjtGOwE90l5w1WwgETQz987UHIC8epE=;
 b=GNzEwt1za7g2GhaZgNvknqImBrsuJYMTEu4agVzVFpXBsj5FLxwWnz/+Z1QxM+49U7OFc0+alwqZzRDiAHIWve/oXzv1ww14c4OkY0906K4uJcJ0KB2opFKYIjjJPCK4HUxEMa3ToA1/Bn2ddxR9mZpHZvmcRG3js42yARCMicqB5GrUP+v/HSQzqggs4mWRefq37C0GrdEhWkT8mTj7sNMTEcB+sbk4axUZryRisUTTgEa16T4aYRju/TtpQIxvRJBhhtFrvdhYR32vUMVOyS+GYOMOeKkJeOIkNx/NC0vxQ6n1n7XE8EwLY0DMYz5hs40T7JDlSJ//8OSux1rYhQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [PATCH V6 1/2] xen/arm: Introduce gpaddr_bits field to struct
 xen_domctl_getdomaininfo
To: Oleksandr <olekstysh@gmail.com>
CC: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>,
 Anthony PERARD <anthony.perard@citrix.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Juergen Gross
 <jgross@suse.com>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 xen-devel@lists.xenproject.org
References: <1633974539-7380-1-git-send-email-olekstysh@gmail.com>
 <1633974539-7380-2-git-send-email-olekstysh@gmail.com>
 <1466e946-d247-2380-6d7d-cda405a2f255@suse.com>
 <68213f79-2cbc-e0cf-3181-bc487f0a5eff@gmail.com>
 <0e03fe6e-8236-fc7d-669f-98107f40e014@suse.com>
 <31f869a5-5788-74c7-c290-ce6797584e9e@gmail.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <d2d0f5ef-09c8-a213-2667-828abce56e6f@suse.com>
Date: Tue, 12 Oct 2021 15:26:17 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <31f869a5-5788-74c7-c290-ce6797584e9e@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM5PR0101CA0022.eurprd01.prod.exchangelabs.com
 (2603:10a6:206:16::35) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 5e14350d-6a60-4d58-7219-08d98d83e03d
X-MS-TrafficTypeDiagnostic: VI1PR04MB2957:
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB2957CB6DCD7FC120C6CDD1ADB3B69@VI1PR04MB2957.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	tZo6MIGAHb3olr7LjhRiTgr+vlfnFe8PU73KnEYYzUaQxpg3Ra/dbbUB6h/lnfUE2qW0A/085srpdzu5H6ypEO0bIv4FBTzIg/eQimPsaa1yFOhdUxgQ7P4ce9e+Vv4HxxWstiJ8YAFk98gkBrS2CGrzWUO6OHI82OB8ZONlrSXnva21xKGxujqtdZYp5bcTfV0wvD5BGOaLujFxo6I8F33/a/tDiCXIKg/ChG+UHsYeDX4mFHumc+Nt1GTrnyETLBccshnuDYVucMQN0kyGBpzQgFMvX5pSP3sNDuwdlDTfG4oXbUTvcUvFp+FrNUigXS3JMJ441LU70aBJyAGdYzypbeOV/uoH/6ULnAOUBrojy/4k3pC5rVRLwJivhX0WfA4L4csJs29NWYgklOJKRj3YqcDybdV0stmFZdIqVGzvqKr6KGuQI9+je+xSDitEE8D5ZVJrJ77tBtlahWZmuHd5HLE6HPrsw2H+qYX0qKs2D3D6EAIC71AA8xsmOvQ3r7Cx7d7+t89GKdYMoRWAPcFYpIToY1SYzWRscFnkQLw/1fPzV87913tzgaQXsZYU5Den4IAlBl/lJnRDG6CltIKZffTsD2PV8+f0QbC32vspVKOz0Ws4P06RoFqYqSF2APfSJyrmtRacVfirB0xU7/sxyvorgRrrR89vV9VBToAbdjM8ggvxih82QWuKy2VE1KsYQGU8qgNRmPkq2K99bw==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(508600001)(956004)(5660300002)(66476007)(31686004)(7416002)(4326008)(36756003)(38100700002)(66946007)(86362001)(6486002)(53546011)(2906002)(2616005)(66556008)(186003)(8676002)(316002)(54906003)(8936002)(31696002)(6916009)(26005)(16576012)(83380400001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?Tq+ok4o1p99fs/yA8Or7rj7G07Q9X/AqxjcA90zgVMbB3h9L4HutVeN2YT8H?=
 =?us-ascii?Q?IkJC6jY4e1KVLUGkbK+zeyeqwxjwYxYoOBVLg5b4yePTWoht6HExgU68g6nx?=
 =?us-ascii?Q?BgmLebLkwGeXCJ428Jt0AZFHnYR/rn7tfDodvQeVFP1oNfwypAHNNgIokLG5?=
 =?us-ascii?Q?pJrJ0d/x7FI7je70LOeo3ZC0D7ULDeDebwLBmsEw352Iq0DMhBZMzu3b1UXz?=
 =?us-ascii?Q?ObpcEpbsY1aYbhOi2EyPfI3AqDLSoyHOXJwruVZOM3e8QdE4XxlHNlbKjeKF?=
 =?us-ascii?Q?qTBuk3A1oV40IqtycKQYMV9FfDIH3Y41U67AcR7CXjGl+bXZMrS5zKwPXISI?=
 =?us-ascii?Q?p/hqExT1mqS9lorTnrM4c/Mb6oKHPN3Ys+TrURb/28CR3fA7lAd1TBUBzf1E?=
 =?us-ascii?Q?FNygj9ryb/9BQ09rvXwxA9/zK6LoE5Dxg51tlJS59kLu/QTGeddqU5skw0TC?=
 =?us-ascii?Q?P+T69OeZEZPNdaqnbqTH6ZNDi/9pmzzMf5/K0kz3w9nC7s+2eFprpUyXPxUI?=
 =?us-ascii?Q?L9jEv2mpUDK+cH3aJXib7bI6d2ChLyetx1agKGGIou9KLePsgdlvV45rISgK?=
 =?us-ascii?Q?F8giHkikgdJDq+TuUWowx5KpuXxpbQghlwgs0yF/382iWGfDrNvQI13b1q18?=
 =?us-ascii?Q?VTemXfYj74TDEUJvwhMB4XZnUd5Rx/BuoF0BueED7SpR/paTfvPv0AP+SELO?=
 =?us-ascii?Q?avju7Ief9ZNyUNlnAtSPjm+BMru3awACtLzf0YTTtlFVAjPffJsY4psGMSqj?=
 =?us-ascii?Q?Sl4z6GRI9ync/gk+4l+YolCMjY/yUUdH38TCq1BuA38ZB2jO6TpD0f/nWIce?=
 =?us-ascii?Q?XgnIzjBr+axkdPjmfanonrVM+LDYJUQycouGX9wmOAbHcaA+VA31VQ3F9NIR?=
 =?us-ascii?Q?NFpZiazt7cMFRtjFLDBZpjIfnZTmTOpsFfzT4M2ZYRFUVZYQHRPlp7t0+YbN?=
 =?us-ascii?Q?nUk2DgPQ977KK0ApwfDcg90gJLJl0sQ3HXNNTSPtjtULLIPqSpBKnIjEZfKe?=
 =?us-ascii?Q?dM5UN4fz41yVOnKYo/v0++9bFbvWYbS6jnoYC8ss/pRNlLZY5WCtF4Ok4WVV?=
 =?us-ascii?Q?Rk7gR9f1v8CsQ20/h06xJXGS0SSmJIeTXqjen8/cJ6EKNqSo7flC9DiPEBYP?=
 =?us-ascii?Q?dV5/zqKLhIaxY87sWAjpwusAW1qQZjHTPLrR09jFZu01My54SpU28ZOwUIYA?=
 =?us-ascii?Q?cR40vz63pczOz9SKstI4Y0jKJBGY3ejYTTdYOcT0CLc7kqI6NGUDT7ECb/HJ?=
 =?us-ascii?Q?sbhhANImU31FoZerLrhEg7aJC7JpJwwIVK3KGuQ0YzMnaio3l5d2Ymb2UjvS?=
 =?us-ascii?Q?Ps3Mbguy1whwqtIA90YCYEqJ?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5e14350d-6a60-4d58-7219-08d98d83e03d
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2021 13:26:19.3960
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: FAm/1sUOWt+aVUW1IQEmTyJa7r5+72yOguEKhnI628jYuTU2+VPscfDgdYro19GC1pitTBo98iOBuUALEXYn4A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB2957

On 12.10.2021 15:18, Oleksandr wrote:
> On 12.10.21 14:49, Jan Beulich wrote:
>> On 12.10.2021 13:28, Oleksandr wrote:
>>> On 12.10.21 12:24, Jan Beulich wrote:
>>>> On 11.10.2021 19:48, Oleksandr Tyshchenko wrote:
>>>>> @@ -150,6 +150,7 @@ struct xen_domctl_getdomaininfo {
>>>>>        uint32_t ssidref;
>>>>>        xen_domain_handle_t handle;
>>>>>        uint32_t cpupool;
>>>>> +    uint8_t gpaddr_bits; /* Guest physical address space size. */
>>>>>        struct xen_arch_domainconfig arch_config;
>>>> On the basis of the above, please add uint8_t pad[3] (or perhaps
>>>> better pad[7] to be independent of the present
>>>> alignof(struct xen_arch_domainconfig) =3D=3D 4) and make sure the
>>>> array will always be zero-filled, such that the padding space can
>>>> subsequently be assigned a purpose without needing to bump the
>>>> interface version(s) again.
>>> ok, will do.
>>>
>>>
>>>> Right now the sysctl caller of getdomaininfo() clears the full
>>>> structure (albeit only once, so stale / inapplicable data might get
>>>> reported for higher numbered domains if any field was filled only
>>>> in certain cases), while the domctl one doesn't. Maybe it would be
>>>> best looking forward if the domctl path also cleared the full buffer
>>>> up front, or if the clearing was moved into the function. (In the
>>>> latter case some writes of zeros into the struct could be eliminated
>>>> in return.)
>>> Well, I would be OK either way, with a little preference for the latter=
.
>>>
>>> Is it close to what you meant?
>> Yes, just that ...
>>
>>> --- a/xen/common/domctl.c
>>> +++ b/xen/common/domctl.c
>>> @@ -69,10 +69,10 @@ void getdomaininfo(struct domain *d, struct
>>> xen_domctl_getdomaininfo *info)
>>>   =C2=A0=C2=A0=C2=A0=C2=A0 int flags =3D XEN_DOMINF_blocked;
>>>   =C2=A0=C2=A0=C2=A0=C2=A0 struct vcpu_runstate_info runstate;
>>>
>>> +=C2=A0=C2=A0=C2=A0 memset(info, 0, sizeof(*info));
>>> +
>>>   =C2=A0=C2=A0=C2=A0=C2=A0 info->domain =3D d->domain_id;
>>>   =C2=A0=C2=A0=C2=A0=C2=A0 info->max_vcpu_id =3D XEN_INVALID_MAX_VCPU_I=
D;
>>> -=C2=A0=C2=A0=C2=A0 info->nr_online_vcpus =3D 0;
>>> -=C2=A0=C2=A0=C2=A0 info->ssidref =3D 0;
>> ... there are a few more "... =3D 0" further down iirc.
>=20
> I didn't spot anything except "info->flags =3D ..." which probably can no=
w=20
> be converted into "info->flags |=3D ..."

Oh, I guess you're right: I've been looking at my own tree, with
"paged_pages field is MEM_PAGING-only" and "shr_pages field is
MEM_SHARING-only" already applied. These sadly are still waiting
to go in, as they depend on earlier patches in their series.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Oct 12 13:33:22 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 13:33:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.207192.362940 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maHu7-0007UK-VP; Tue, 12 Oct 2021 13:33:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 207192.362940; Tue, 12 Oct 2021 13:33:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maHu7-0007UD-SC; Tue, 12 Oct 2021 13:33:15 +0000
Received: by outflank-mailman (input) for mailman id 207192;
 Tue, 12 Oct 2021 13:33:14 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=cVDt=PA=linutronix.de=tglx@srs-us1.protection.inumbo.net>)
 id 1maHu5-0007U7-Mk
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 13:33:13 +0000
Received: from galois.linutronix.de (unknown [2a0a:51c0:0:12e:550::1])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 343866f4-3828-4a5e-a860-abfad85b9e75;
 Tue, 12 Oct 2021 13:33:11 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 343866f4-3828-4a5e-a860-abfad85b9e75
From: Thomas Gleixner <tglx@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1634045590; h=from:from:reply-to:subject:subject:subject:date:date:
	 message-id:message-id:to:to:cc:cc:mime-version:mime-version:
	 content-type:content-type; bh=kzzhCfXTDEtjAULZoQTQAQVk/vJzN0Qs+xvw5wZ2xW8=;
	b=fshm+r6GuZJqUIjderhxFapYx9zHU+cgacgZcb4X3qqfOA3jGaDvAbH+anIC+WP9685mk6
	q0TKBkDt0g/d8TCr49QoRZoKVvEr9W7tfTXsay5DDNIsnJLYAZcf91hSz8dBlwGedoMCo9
	E74g57CWEurmdTWYM21l5cxRenKL2vF/eJBF0PpyTMLJ6QaH0Fobe2OR8yswaRfFby+9eA
	hDJbrq09yA+2Jq8k3m5/rJ7IQVWFni4JnkTVKlxJRtH1NXEuWURVID/OZfZGLUcu+Ku8wc
	jpIijHLw/98IL8yJ54WQkKkChMx7UdL3OlW8F8slrV1oEnGz20/GXC4PLQttvA==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1634045590; h=from:from:reply-to:subject:subject:subject:date:date:
	 message-id:message-id:to:to:cc:cc:mime-version:mime-version:
	 content-type:content-type; bh=kzzhCfXTDEtjAULZoQTQAQVk/vJzN0Qs+xvw5wZ2xW8=;
	b=Jtzxoe+JH4LioMrpry7wl7nAZ54N2HKh7QirrOr/uYKDM93VU1+yZMsGl5o/abis+gR7Hv
	XGzy0J0vXb45WQCQ==
To: LKML <linux-kernel@vger.kernel.org>
Cc: x86@kernel.org, Juergen Gross <jgross@suse.com>, Stefano Stabellini
 <sstabellini@kernel.org>, Boris Ostrovsky <boris.ostrovsky@oracle.com>,
 xen-devel@lists.xenproject.org
Subject: [PATCH] x86/xen: Remove redundant irq_enter/exit() invocations
Subject: 
Date: Tue, 12 Oct 2021 15:33:09 +0200
Message-ID: <877deicqqy.ffs@tglx>
MIME-Version: 1.0
Content-Type: text/plain

All these handlers are regular device interrupt handlers, so they already
went through the proper entry code which handles this correctly.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Juergen Gross <jgross@suse.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: x86@kernel.org
Cc: xen-devel@lists.xenproject.org
---
 arch/x86/xen/smp.c    |    4 ----
 arch/x86/xen/smp_pv.c |    2 --
 2 files changed, 6 deletions(-)

--- a/arch/x86/xen/smp.c
+++ b/arch/x86/xen/smp.c
@@ -268,20 +268,16 @@ void xen_send_IPI_allbutself(int vector)
 
 static irqreturn_t xen_call_function_interrupt(int irq, void *dev_id)
 {
-	irq_enter();
 	generic_smp_call_function_interrupt();
 	inc_irq_stat(irq_call_count);
-	irq_exit();
 
 	return IRQ_HANDLED;
 }
 
 static irqreturn_t xen_call_function_single_interrupt(int irq, void *dev_id)
 {
-	irq_enter();
 	generic_smp_call_function_single_interrupt();
 	inc_irq_stat(irq_call_count);
-	irq_exit();
 
 	return IRQ_HANDLED;
 }
--- a/arch/x86/xen/smp_pv.c
+++ b/arch/x86/xen/smp_pv.c
@@ -458,10 +458,8 @@ static void xen_pv_stop_other_cpus(int w
 
 static irqreturn_t xen_irq_work_interrupt(int irq, void *dev_id)
 {
-	irq_enter();
 	irq_work_run();
 	inc_irq_stat(apic_irq_work_irqs);
-	irq_exit();
 
 	return IRQ_HANDLED;
 }


From xen-devel-bounces@lists.xenproject.org Tue Oct 12 13:33:38 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 13:33:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.207196.362952 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maHuU-0007vW-8d; Tue, 12 Oct 2021 13:33:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 207196.362952; Tue, 12 Oct 2021 13:33:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maHuU-0007vP-4C; Tue, 12 Oct 2021 13:33:38 +0000
Received: by outflank-mailman (input) for mailman id 207196;
 Tue, 12 Oct 2021 13:33:37 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=5yXa=PA=oderland.se=josef@srs-us1.protection.inumbo.net>)
 id 1maHuT-0007rU-Pc
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 13:33:37 +0000
Received: from office.oderland.com (unknown [91.201.60.5])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id fdc5269c-2b60-11ec-8128-12813bfff9fa;
 Tue, 12 Oct 2021 13:33:32 +0000 (UTC)
Received: from 161.193-180-18.r.oderland.com ([193.180.18.161]:33232
 helo=[10.137.0.14]) by office.oderland.com with esmtpsa (TLS1.2) tls
 TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2)
 (envelope-from <josef@oderland.se>)
 id 1maHuN-003NMa-4k; Tue, 12 Oct 2021 15:33:31 +0200
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fdc5269c-2b60-11ec-8128-12813bfff9fa
Message-ID: <fdfb6267-e467-4785-b4a0-00859f6dc161@oderland.se>
Date: Tue, 12 Oct 2021 15:33:29 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:93.0) Gecko/20100101
 Thunderbird/93.0
Subject: Re: [REGRESSION][BISECTED] 5.15-rc1: Broken AHCI on NVIDIA ION
 (MCP79)
Content-Language: en-US
To: Jason Andryuk <jandryuk@gmail.com>
Cc: Thomas Gleixner <tglx@linutronix.de>, maz@kernel.org,
 linux-pci@vger.kernel.org, open list <linux-kernel@vger.kernel.org>,
 xen-devel <xen-devel@lists.xenproject.org>
References: <CALjTZvbzYfBuLB+H=fj2J+9=DxjQ2Uqcy0if_PvmJ-nU-qEgkg@mail.gmail.com>
 <b023adf9-e21c-59ac-de49-57915c8cede8@oderland.se>
 <c9218eb4-9fc1-28f4-d053-895bab0473d4@oderland.se>
 <ef163327-f965-09f8-4396-2c1c4e689a6d@oderland.se>
 <CAKf6xpvGyCKVHsvauP54=0j10fxis4XiiqBNWH+1cpkbtt_QJw@mail.gmail.com>
From: Josef Johansson <josef@oderland.se>
In-Reply-To: <CAKf6xpvGyCKVHsvauP54=0j10fxis4XiiqBNWH+1cpkbtt_QJw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-AntiAbuse: This header was added to track abuse, please include it with any abuse report
X-AntiAbuse: Primary Hostname - office.oderland.com
X-AntiAbuse: Original Domain - lists.xenproject.org
X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12]
X-AntiAbuse: Sender Address Domain - oderland.se
X-Get-Message-Sender-Via: office.oderland.com: authenticated_id: josjoh@oderland.se
X-Authenticated-Sender: office.oderland.com: josjoh@oderland.se

On 10/12/21 15:07, Jason Andryuk wrote:
> On Tue, Oct 12, 2021 at 2:09 AM Josef Johansson <josef@oderland.se> wrote:
>> On 10/11/21 21:34, Josef Johansson wrote:
>>> On 10/11/21 20:47, Josef Johansson wrote:
>>>> More can be read over at freedesktop:
>>>> https://gitlab.freedesktop.org/drm/amd/-/issues/1715
> Hi, Josef,
>
> If you compare
> commit fcacdfbef5a1633211ebfac1b669a7739f5b553e "PCI/MSI: Provide a
> new set of mask and unmask functions"
> and
> commit 446a98b19fd6da97a1fb148abb1766ad89c9b767 "PCI/MSI: Use new
> mask/unmask functions" some of the replacement functions in 446198b1
> no longer exit early for the pci_msi_ignore_mask flag.
>
> Josef, I'd recommend you try adding pci_msi_ignore_mask checks to the
> new functions in fcacdfbef5a to see if that helps.
>
> There was already a pci_msi_ignore_mask fixup in commit
> 1a519dc7a73c977547d8b5108d98c6e769c89f4b "PCI/MSI: Skip masking MSI-X
> on Xen PV" though the kernel was crashing in that case.
>
> Regards,
> Jason

Hi Jason,

Makes sense. I am compiling now, will try it as soon as it's done.

diff --git a/drivers/pci/msi.c b/drivers/pci/msi.c
index 0099a00af361..620928fd0065 100644
--- a/drivers/pci/msi.c
+++ b/drivers/pci/msi.c
@@ -148,6 +148,9 @@ static noinline void pci_msi_update_mask(struct
msi_desc *desc, u32 clear, u32 s
     raw_spinlock_t *lock = &desc->dev->msi_lock;
     unsigned long flags;
 
+    if (pci_msi_ignore_mask)
+        return;
+
     raw_spin_lock_irqsave(lock, flags);
     desc->msi_mask &= ~clear;
     desc->msi_mask |= set;
@@ -179,6 +182,9 @@ static inline void __iomem
*pci_msix_desc_addr(struct msi_desc *desc)
  */
 static void pci_msix_write_vector_ctrl(struct msi_desc *desc, u32 ctrl)
 {
+    if (pci_msi_ignore_mask)
+        return;
+
     void __iomem *desc_addr = pci_msix_desc_addr(desc);
 
     writel(ctrl, desc_addr + PCI_MSIX_ENTRY_VECTOR_CTRL);
@@ -186,6 +192,9 @@ static void pci_msix_write_vector_ctrl(struct
msi_desc *desc, u32 ctrl)
 
 static inline void pci_msix_mask(struct msi_desc *desc)
 {
+    if (pci_msi_ignore_mask)
+        return;
+
     desc->msix_ctrl |= PCI_MSIX_ENTRY_CTRL_MASKBIT;
     pci_msix_write_vector_ctrl(desc, desc->msix_ctrl);
     /* Flush write to device */
@@ -194,6 +203,9 @@ static inline void pci_msix_mask(struct msi_desc *desc)
 
 static inline void pci_msix_unmask(struct msi_desc *desc)
 {
+    if (pci_msi_ignore_mask)
+        return;
+
     desc->msix_ctrl &= ~PCI_MSIX_ENTRY_CTRL_MASKBIT;
     pci_msix_write_vector_ctrl(desc, desc->msix_ctrl);
 }



From xen-devel-bounces@lists.xenproject.org Tue Oct 12 13:36:07 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 13:36:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.207210.362963 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maHws-0000In-KV; Tue, 12 Oct 2021 13:36:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 207210.362963; Tue, 12 Oct 2021 13:36:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maHws-0000Ig-Gd; Tue, 12 Oct 2021 13:36:06 +0000
Received: by outflank-mailman (input) for mailman id 207210;
 Tue, 12 Oct 2021 13:36:05 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1maHwr-0000IW-B4; Tue, 12 Oct 2021 13:36:05 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1maHwr-0001jW-6x; Tue, 12 Oct 2021 13:36:05 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1maHwr-0005sC-0K; Tue, 12 Oct 2021 13:36:05 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1maHwq-0004h6-W2; Tue, 12 Oct 2021 13:36:04 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=hlU1On59jzoUs7XjUP8ORfLJhe+Jk6dCnJIcCCMp0/A=; b=cmso/N0SSUki9iVYRDB1VSh1Hr
	r3pf40uONUUX9sLr11/1hk8rSh5CfNTpR5uKOMVykf0UL2sdJXyFnPiCXA702BAr3NL8Cnzge2rg/
	y4taqGSYrypMoFT/IdrHVU1XC/VhJafzydyCmJRt0zUzUTl2K7Sh0P5FGx0efV+MvxRY=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165475-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 165475: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=d3b05f9b16d6ba9c550c3a35ac11ed292bf87f68
X-Osstest-Versions-That:
    xen=e26f810a6f9295afe30ea08195715ddd96e2a123
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 12 Oct 2021 13:36:04 +0000

flight 165475 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165475/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  d3b05f9b16d6ba9c550c3a35ac11ed292bf87f68
baseline version:
 xen                  e26f810a6f9295afe30ea08195715ddd96e2a123

Last test of basis   165472  2021-10-12 02:00:27 Z    0 days
Testing same since   165475  2021-10-12 10:01:35 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Anthony PERARD <anthony.perard@citrix.com>
  Jan Beulich <jbeulich@suse.com>
  Julien Grall <jgrall@amazon.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   e26f810a6f..d3b05f9b16  d3b05f9b16d6ba9c550c3a35ac11ed292bf87f68 -> smoke


From xen-devel-bounces@lists.xenproject.org Tue Oct 12 13:41:58 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 13:41:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.207219.362977 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maI2U-0001iQ-A1; Tue, 12 Oct 2021 13:41:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 207219.362977; Tue, 12 Oct 2021 13:41:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maI2U-0001iJ-5q; Tue, 12 Oct 2021 13:41:54 +0000
Received: by outflank-mailman (input) for mailman id 207219;
 Tue, 12 Oct 2021 13:41:52 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=xSmm=PA=suse.com=jgross@srs-us1.protection.inumbo.net>)
 id 1maI2S-0001i8-Tf
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 13:41:52 +0000
Received: from smtp-out1.suse.de (unknown [195.135.220.28])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 6e277c9a-b0a5-479e-9360-bdd38a5ac81b;
 Tue, 12 Oct 2021 13:41:52 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 2C83E22185;
 Tue, 12 Oct 2021 13:41:51 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id EC2B813E43;
 Tue, 12 Oct 2021 13:41:50 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id cOxCOJ6QZWGabgAAMHmgww
 (envelope-from <jgross@suse.com>); Tue, 12 Oct 2021 13:41:50 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6e277c9a-b0a5-479e-9360-bdd38a5ac81b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1634046111; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=Q5L7RANFuY0lTjcILncAay9zDfSZ+zR/cGF7re2yY04=;
	b=k3qCzLkwOK9uYRQWGTlPf0TWQ5zGIPjtZ04AryLo8EoEVfngOLI3Nw1SrV2nR+gNavOSnw
	AsVQXpzUIGDAkXvkBBL/Ov0TeF3JQOmuFsFxIU5wEz5Thb1mjedgvbcbIpEC6wyPc9kYjl
	GmFocuIifMbKqo8SPNtKUZoVyovSsQ8=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org
Cc: Juergen Gross <jgross@suse.com>,
	Ian Jackson <iwj@xenproject.org>,
	Wei Liu <wl@xen.org>
Subject: [PATCH v6 1/2] tools/xenstore: set oom score for xenstore daemon on Linux
Date: Tue, 12 Oct 2021 15:41:47 +0200
Message-Id: <20211012134148.6280-2-jgross@suse.com>
X-Mailer: git-send-email 2.26.2
In-Reply-To: <20211012134148.6280-1-jgross@suse.com>
References: <20211012134148.6280-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Xenstored is absolutely mandatory for a Xen host and it can't be
restarted, so being killed by OOM-killer in case of memory shortage is
to be avoided.

Set /proc/$pid/oom_score_adj (if available) per default to -500 (this
translates to 50% of dom0 memory size) in order to allow xenstored to
use large amounts of memory without being killed.

The percentage of dom0 memory above which the oom killer is allowed to
kill xenstored can be set via XENSTORED_OOM_MEM_THRESHOLD in
xencommons.

Make sure the pid file isn't a left-over from a previous run delete it
before starting xenstored.

Signed-off-by: Juergen Gross <jgross@suse.com>
Reviewed-by: Ian Jackson <iwj@xenproject.org>
---
V2:
- set oom score from launch script (Julien Grall)
- split off open file descriptor limit setting (Julien Grall)
V3:
- make oom killer threshold configurable (Julien Grall)
V4:
- extend comment (Ian Jackson)
---
 tools/hotplug/Linux/init.d/sysconfig.xencommons.in | 9 +++++++++
 tools/hotplug/Linux/launch-xenstore.in             | 6 ++++++
 2 files changed, 15 insertions(+)

diff --git a/tools/hotplug/Linux/init.d/sysconfig.xencommons.in b/tools/hotplug/Linux/init.d/sysconfig.xencommons.in
index 00cf7f91d4..b83101ab7e 100644
--- a/tools/hotplug/Linux/init.d/sysconfig.xencommons.in
+++ b/tools/hotplug/Linux/init.d/sysconfig.xencommons.in
@@ -48,6 +48,15 @@ XENSTORED_ARGS=
 # Only evaluated if XENSTORETYPE is "daemon".
 #XENSTORED_TRACE=[yes|on|1]
 
+## Type: integer
+## Default: 50
+#
+# Percentage of dom0 memory size the xenstore daemon can use before the
+# OOM killer is allowed to kill it.
+# The specified value is multiplied by -10 and echoed to
+# /proc/PID/oom_score_adj.
+#XENSTORED_OOM_MEM_THRESHOLD=50
+
 ## Type: string
 ## Default: @LIBEXEC@/boot/xenstore-stubdom.gz
 #
diff --git a/tools/hotplug/Linux/launch-xenstore.in b/tools/hotplug/Linux/launch-xenstore.in
index 019f9d6f4d..1747c96065 100644
--- a/tools/hotplug/Linux/launch-xenstore.in
+++ b/tools/hotplug/Linux/launch-xenstore.in
@@ -59,11 +59,17 @@ test -f @CONFIG_DIR@/@CONFIG_LEAF_DIR@/xencommons && . @CONFIG_DIR@/@CONFIG_LEAF
 		echo "No xenstored found"
 		exit 1
 	}
+	[ -z "$XENSTORED_OOM_MEM_THRESHOLD" ] || XENSTORED_OOM_MEM_THRESHOLD=50
+	XS_OOM_SCORE=-$(($XENSTORED_OOM_MEM_THRESHOLD * 10))
+
+	rm -f @XEN_RUN_DIR@/xenstored.pid
 
 	echo -n Starting $XENSTORED...
 	$XENSTORED --pid-file @XEN_RUN_DIR@/xenstored.pid $XENSTORED_ARGS
 
 	systemd-notify --booted 2>/dev/null || timeout_xenstore $XENSTORED || exit 1
+	XS_PID=`cat @XEN_RUN_DIR@/xenstored.pid`
+	echo $XS_OOM_SCORE >/proc/$XS_PID/oom_score_adj
 
 	exit 0
 }
-- 
2.26.2



From xen-devel-bounces@lists.xenproject.org Tue Oct 12 13:41:58 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 13:41:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.207220.362983 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maI2U-0001lR-Ji; Tue, 12 Oct 2021 13:41:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 207220.362983; Tue, 12 Oct 2021 13:41:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maI2U-0001k9-D1; Tue, 12 Oct 2021 13:41:54 +0000
Received: by outflank-mailman (input) for mailman id 207220;
 Tue, 12 Oct 2021 13:41:52 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=xSmm=PA=suse.com=jgross@srs-us1.protection.inumbo.net>)
 id 1maI2S-0001i7-TU
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 13:41:52 +0000
Received: from smtp-out2.suse.de (unknown [195.135.220.29])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 278c30b4-2b62-11ec-8129-12813bfff9fa;
 Tue, 12 Oct 2021 13:41:51 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id ECD59200AB;
 Tue, 12 Oct 2021 13:41:50 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id BA4CE13BC9;
 Tue, 12 Oct 2021 13:41:50 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id Lfw2LJ6QZWGabgAAMHmgww
 (envelope-from <jgross@suse.com>); Tue, 12 Oct 2021 13:41:50 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 278c30b4-2b62-11ec-8129-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1634046110; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:  content-transfer-encoding:content-transfer-encoding;
	bh=uih8tIuxkl60Joc9qtXew+1sWSQCt+Ig3NkEphj54cI=;
	b=KrP0lCo/Ym6SbS0ILKKt2+kfUpdkqNu8Vei5s4fq/kJlZ892fyyxtgoTgA2+1amgCY/2gG
	EdTJflBnIJRDbhDpQ4whSjVGIT8SqziwcFW5/YZbOn/EDmJH/W9lsScFUOe5/a0nuSXoyh
	w8IRvht09vB8pw2hSHxLRGS+qbbZ2Kk=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org
Cc: Juergen Gross <jgross@suse.com>,
	Ian Jackson <iwj@xenproject.org>,
	Wei Liu <wl@xen.org>
Subject: [PATCH v6 0/2] tools/xenstore: set resource limits of xenstored
Date: Tue, 12 Oct 2021 15:41:46 +0200
Message-Id: <20211012134148.6280-1-jgross@suse.com>
X-Mailer: git-send-email 2.26.2
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Set some limits for xenstored in order to avoid it being killed by
OOM killer, or to run out of file descriptors.

Changes in V6:
- start daemon directly via prlimit

Changes in V5:
- respect /proc/sys/fs/nr_open (Ian Jackson)

Changes in V4:
- add comments
- switch to configure open file descriptors directly

Changes in V3:
- make oom score configurable

Changes in V2:
- split into 2 patches
- set limits from start script

Juergen Gross (2):
  tools/xenstore: set oom score for xenstore daemon on Linux
  tools/xenstore: set open file descriptor limit for xenstored

 .../Linux/init.d/sysconfig.xencommons.in      | 22 +++++++++++++++
 tools/hotplug/Linux/launch-xenstore.in        | 27 ++++++++++++++++++-
 2 files changed, 48 insertions(+), 1 deletion(-)

-- 
2.26.2



From xen-devel-bounces@lists.xenproject.org Tue Oct 12 13:41:59 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 13:41:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.207221.362999 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maI2Y-0002HP-Vl; Tue, 12 Oct 2021 13:41:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 207221.362999; Tue, 12 Oct 2021 13:41:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maI2Y-0002HG-SP; Tue, 12 Oct 2021 13:41:58 +0000
Received: by outflank-mailman (input) for mailman id 207221;
 Tue, 12 Oct 2021 13:41:57 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=xSmm=PA=suse.com=jgross@srs-us1.protection.inumbo.net>)
 id 1maI2X-0001i7-N1
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 13:41:57 +0000
Received: from smtp-out2.suse.de (unknown [195.135.220.29])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 27ae2b7f-2b62-11ec-8129-12813bfff9fa;
 Tue, 12 Oct 2021 13:41:52 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 51D2F200AD;
 Tue, 12 Oct 2021 13:41:51 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 2774F13BC9;
 Tue, 12 Oct 2021 13:41:51 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id aLQ6CJ+QZWGabgAAMHmgww
 (envelope-from <jgross@suse.com>); Tue, 12 Oct 2021 13:41:51 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 27ae2b7f-2b62-11ec-8129-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1634046111; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=SEIm+LDplzdzplbZtDj1JKs78X3CX933Us/EMZK8kUQ=;
	b=DeH1SPQanWNTalBCfT28ybemBt/DXolwcq5aIAsmOeLi69vKGr6llMAujDPpxgEj7UaG9I
	WrgWUnDVeIJfO6pbffBCNn8fwYAE8OeO2Y9nhLhVzUQ8PWtUDKcCWq5uRcepdOi9FOyhbw
	YifqJlTD/O76cBP2JIhEzv4Zw8SllxI=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org
Cc: Juergen Gross <jgross@suse.com>,
	Ian Jackson <iwj@xenproject.org>,
	Wei Liu <wl@xen.org>
Subject: [PATCH v6 2/2] tools/xenstore: set open file descriptor limit for xenstored
Date: Tue, 12 Oct 2021 15:41:48 +0200
Message-Id: <20211012134148.6280-3-jgross@suse.com>
X-Mailer: git-send-email 2.26.2
In-Reply-To: <20211012134148.6280-1-jgross@suse.com>
References: <20211012134148.6280-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Add a configuration item for the maximum number of open file
descriptors xenstored should be allowed to have.

The default should be "unlimited" in order not to restrict xenstored
in the number of domains it can support, but unfortunately the kernel
is normally limiting the maximum value via /proc/sys/fs/nr_open [1],
[2]. So check that file to exist and if it does, limit the maximum
value to the one specified by /proc/sys/fs/nr_open.

As an aid for the admin configuring the value add a comment specifying
the common needs of xenstored for the different domain types.

[1]: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=60fd760fb9ff7034360bab7137c917c0330628c2
[2]: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=0c2d64fb6cae9aae480f6a46cfe79f8d7d48b59f

Signed-off-by: Juergen Gross <jgross@suse.com>
---
V2:
- set ulimit form launch script (Julien Grall)
- split off from original patch (Julien Grall)
V4:
- switch to directly configuring the limit of file descriptors instead
  of domains (Ian Jackson)
V5:
- use /proc/sys/fs/nr_open (Ian Jackson)
V6:
- start daemon directly via prlimit
---
 .../Linux/init.d/sysconfig.xencommons.in      | 13 ++++++++++++
 tools/hotplug/Linux/launch-xenstore.in        | 21 ++++++++++++++++++-
 2 files changed, 33 insertions(+), 1 deletion(-)

diff --git a/tools/hotplug/Linux/init.d/sysconfig.xencommons.in b/tools/hotplug/Linux/init.d/sysconfig.xencommons.in
index b83101ab7e..433e4849af 100644
--- a/tools/hotplug/Linux/init.d/sysconfig.xencommons.in
+++ b/tools/hotplug/Linux/init.d/sysconfig.xencommons.in
@@ -32,6 +32,19 @@
 # Changing this requires a reboot to take effect.
 #XENSTORED=@XENSTORED@
 
+## Type: string
+## Default: unlimited
+#
+# Select maximum number of file descriptors xenstored is allowed to have
+# opened at one time.
+# For each HVM domain xenstored might need up to 5 open file descriptors,
+# PVH and PV domains will require up to 3 open file descriptors. Additionally
+# 20-30 file descriptors will be opened for internal uses.
+# The specified value (including "unlimited") will be capped by the contents
+# of /proc/sys/fs/nr_open if existing.
+# Only evaluated if XENSTORETYPE is "daemon".
+#XENSTORED_MAX_OPEN_FDS=unlimited
+
 ## Type: string
 ## Default: ""
 #
diff --git a/tools/hotplug/Linux/launch-xenstore.in b/tools/hotplug/Linux/launch-xenstore.in
index 1747c96065..8438af9977 100644
--- a/tools/hotplug/Linux/launch-xenstore.in
+++ b/tools/hotplug/Linux/launch-xenstore.in
@@ -54,6 +54,7 @@ test -f @CONFIG_DIR@/@CONFIG_LEAF_DIR@/xencommons && . @CONFIG_DIR@/@CONFIG_LEAF
 
 [ "$XENSTORETYPE" = "daemon" ] && {
 	[ -z "$XENSTORED_TRACE" ] || XENSTORED_ARGS="$XENSTORED_ARGS -T @XEN_LOG_DIR@/xenstored-trace.log"
+	[ -z "$XENSTORED_MAX_OPEN_FDS" ] && XENSTORED_MAX_OPEN_FDS=unlimited
 	[ -z "$XENSTORED" ] && XENSTORED=@XENSTORED@
 	[ -x "$XENSTORED" ] || {
 		echo "No xenstored found"
@@ -62,10 +63,28 @@ test -f @CONFIG_DIR@/@CONFIG_LEAF_DIR@/xencommons && . @CONFIG_DIR@/@CONFIG_LEAF
 	[ -z "$XENSTORED_OOM_MEM_THRESHOLD" ] || XENSTORED_OOM_MEM_THRESHOLD=50
 	XS_OOM_SCORE=-$(($XENSTORED_OOM_MEM_THRESHOLD * 10))
 
+	[ "$XENSTORED_MAX_OPEN_FDS" = "unlimited" ] || {
+		[ -z "${XENSTORED_MAX_OPEN_FDS//[0-9]}" ] &&
+		[ -n "$XENSTORED_MAX_OPEN_FDS" ] || {
+			echo "XENSTORED_MAX_OPEN_FDS=$XENSTORED_MAX_OPEN_FDS invalid"
+			echo "Setting to default \"unlimited\"."
+			XENSTORED_MAX_OPEN_FDS=unlimited
+		}
+	}
+	[ -r /proc/sys/fs/nr_open ] && {
+		MAX_FDS=`cat /proc/sys/fs/nr_open`
+		[ "$XENSTORED_MAX_OPEN_FDS" = "unlimited" ] && XENSTORED_MAX_OPEN_FDS=$MAX_FDS
+		[ $XENSTORED_MAX_OPEN_FDS -gt $MAX_FDS ] && {
+			echo "XENSTORED_MAX_OPEN_FDS exceeds system limit."
+			echo "Setting to \"$MAX_FDS\"."
+			XENSTORED_MAX_OPEN_FDS=$MAX_FDS
+		}
+	}
+
 	rm -f @XEN_RUN_DIR@/xenstored.pid
 
 	echo -n Starting $XENSTORED...
-	$XENSTORED --pid-file @XEN_RUN_DIR@/xenstored.pid $XENSTORED_ARGS
+	prlimit --nofile=$XENSTORED_MAX_OPEN_FDS $XENSTORED --pid-file @XEN_RUN_DIR@/xenstored.pid $XENSTORED_ARGS
 
 	systemd-notify --booted 2>/dev/null || timeout_xenstore $XENSTORED || exit 1
 	XS_PID=`cat @XEN_RUN_DIR@/xenstored.pid`
-- 
2.26.2



From xen-devel-bounces@lists.xenproject.org Tue Oct 12 13:56:57 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 13:56:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.207245.363014 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maIGy-0004WQ-7t; Tue, 12 Oct 2021 13:56:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 207245.363014; Tue, 12 Oct 2021 13:56:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maIGy-0004WJ-3z; Tue, 12 Oct 2021 13:56:52 +0000
Received: by outflank-mailman (input) for mailman id 207245;
 Tue, 12 Oct 2021 13:56:51 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1maIGx-0004WD-8o
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 13:56:51 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1maIGx-00027C-75
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 13:56:51 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1maIGx-00048y-6L
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 13:56:51 +0000
Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89)
 (envelope-from <iwj@xenproject.org>)
 id 1maIGt-0004SV-Qw; Tue, 12 Oct 2021 14:56:47 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date
	:Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From;
	bh=niPKva7Cuu52jutyU+GIldq4IhhWYHgilMd+nTZ014w=; b=UycMHwzE83BpQh7IUROhjpy6Q0
	rUW1hcuaEaQuVTLlwTqMid8JTYQd5eJPx3NRy7nNBmQaEVIY97wDXlGHe3hzeDp/y3pJ69oycnqQH
	7lbkpoJIPEseBM/c9XRwhPBOMidhuprnSr2xFPoNor4qDnNvYqxsK4tebpR3tKtb3X9Q=;
From: Ian Jackson <iwj@xenproject.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <24933.37919.481655.602107@mariner.uk.xensource.com>
Date: Tue, 12 Oct 2021 14:56:47 +0100
To: Juergen Gross <jgross@suse.com>
Cc: xen-devel@lists.xenproject.org,
    Wei Liu <wl@xen.org>
Subject: [PATCH v6 2/2] tools/xenstore: set open file descriptor limit for xenstored
In-Reply-To: <20211012134148.6280-3-jgross@suse.com>
References: <20211012134148.6280-1-jgross@suse.com>
	<20211012134148.6280-3-jgross@suse.com>
X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu)

Juergen Gross writes ("[PATCH v6 2/2] tools/xenstore: set open file descriptor limit for xenstored"):
> Add a configuration item for the maximum number of open file
> descriptors xenstored should be allowed to have.
> 
> The default should be "unlimited" in order not to restrict xenstored
> in the number of domains it can support, but unfortunately the kernel
> is normally limiting the maximum value via /proc/sys/fs/nr_open [1],
> [2]. So check that file to exist and if it does, limit the maximum
> value to the one specified by /proc/sys/fs/nr_open.
> 
> As an aid for the admin configuring the value add a comment specifying
> the common needs of xenstored for the different domain types.
> 
> [1]: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=60fd760fb9ff7034360bab7137c917c0330628c2
> [2]: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=0c2d64fb6cae9aae480f6a46cfe79f8d7d48b59f
> 
> Signed-off-by: Juergen Gross <jgross@suse.com>

Reviewed-by: Ian Jackson <iwj@xenproject.org>


From xen-devel-bounces@lists.xenproject.org Tue Oct 12 14:11:46 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 14:11:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.207259.363025 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maIVA-0006qt-G2; Tue, 12 Oct 2021 14:11:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 207259.363025; Tue, 12 Oct 2021 14:11:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maIVA-0006qm-D2; Tue, 12 Oct 2021 14:11:32 +0000
Received: by outflank-mailman (input) for mailman id 207259;
 Tue, 12 Oct 2021 14:11:31 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=U2oI=PA=gmail.com=rm.skakun@srs-us1.protection.inumbo.net>)
 id 1maIV9-0006qf-CD
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 14:11:31 +0000
Received: from mail-lf1-x12b.google.com (unknown [2a00:1450:4864:20::12b])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id d3f59fc1-7a5a-401c-a68a-36b8b28a8d2c;
 Tue, 12 Oct 2021 14:11:30 +0000 (UTC)
Received: by mail-lf1-x12b.google.com with SMTP id r19so85595466lfe.10
 for <xen-devel@lists.xenproject.org>; Tue, 12 Oct 2021 07:11:30 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d3f59fc1-7a5a-401c-a68a-36b8b28a8d2c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc:content-transfer-encoding;
        bh=KMJkGulYO08hK7uvXbwHieCG67DH8mAGFG+J88k0HtQ=;
        b=jGyv35w1Th/VcGjS0uXIYS1/hZw0Tbs9LcOJM3zlikFdoX4qYKcvbY/iwckN5rLYJI
         Wf0o0q+9ogDv4Hn5GCXA93UrVYK/e4uy3LMtClD3FaHm14qHZ0SSOZOSBbaTmZthLzvB
         JDA9KBFrwNaI9u5EMBStAGE2cx2Modf4ZhzlQUkrkFDszBRA2MHXmUxiMVfrdQx5Kz/9
         FoWR3xJ6hXtoUPqH7oEN23FUiq04HzOEGFWnoTO6fk3IU9JVTr+irX++fnYsDPm4iZwh
         HmOJc9espvH9LI+yJ1pi3S+ONlomWnpeFMUQ4twh039K3QTsuzy5VJr6g56Kd0MkoAna
         +n9w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc:content-transfer-encoding;
        bh=KMJkGulYO08hK7uvXbwHieCG67DH8mAGFG+J88k0HtQ=;
        b=yGLgKKN4BTltyZjoP/H5XsssXsZcjV3voCruoQFlOFJawPe0FcooCaeTEh6ceBD25T
         jOIXB0rWzEnwigwo/20PCqNqSoWa4avMamscJISUTxBWOjvPJKLouOJ/uDOSSrGmglp+
         L2fTwQseBzgFEkxZ6TTHFap11QVeKLQI0VozLvBqB/5l/ll3hDUpAOSQEhOslFQuPMiY
         qkpoeH46v+XcPqgz3GuLTl9cg7Jwth+h2cBua/kvwng/UFbr0bBepZsXa2geJWisr0WF
         ZFcIu34gKk2N/sAPj6Jjj7nbtHIcj+oPFXqLSYQJffNSwBwEffc0x99NCqux6sw2bJc/
         RXmg==
X-Gm-Message-State: AOAM532zjUt9bdYVufalxr1k12bmokQ6+Dlv6W/hzl7RcQNEPsHIskjT
	dpoAtxauPmX5PwtjusIgDN8tEoRddAZe8T1Jr2w=
X-Google-Smtp-Source: ABdhPJxfkMCEjeeLV/Ewm3f+AZNuNNymij2vhZOjkUSGinYcnXpgag3KIHEc+pI3tC0HlGD+3NbZizDkPEragXGFP2Y=
X-Received: by 2002:a2e:530b:: with SMTP id h11mr29408481ljb.310.1634047884386;
 Tue, 12 Oct 2021 07:11:24 -0700 (PDT)
MIME-Version: 1.0
References: <cover.1633106362.git.roman_skakun@epam.com>
In-Reply-To: <cover.1633106362.git.roman_skakun@epam.com>
From: Roman Skakun <rm.skakun@gmail.com>
Date: Tue, 12 Oct 2021 17:11:13 +0300
Message-ID: <CADu_u-PVqHc6RQ4JTpkrmNap+QxEh7=0Mu2xsiAjOty3J5hKjQ@mail.gmail.com>
Subject: Re: [RFC 0/1] tag IOMMU-protected devices in Dom0 fdt
To: Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>, 
	xen-devel@lists.xenproject.org
Cc: Roman Skakun <roman_skakun@epam.com>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, 
	Andrii Anisov <andrii_anisov@epam.com>, Roman Skakun <rm.skakun@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi,

Would you be so kind to look at my patches, it would help me to
know exactly whether I'm moving correctly and whether I've chosen
the right path?
Thanks!

Best regards,
Roman

=D0=BF=D0=BD, 4 =D0=BE=D0=BA=D1=82. 2021 =D0=B3. =D0=B2 12:54, Roman Skakun=
 <rm.skakun@gmail.com>:
>
> From: Roman Skakun <roman_skakun@epam.com>
>
> At the moment, Dom0 can't distinguish which devices are protected by
> IOMMU and which are not. In some cases, this can cause swiotlb bounce
> buffer use for DMA addresses above 32 bits, which in turn can lead
> to poor performance. I started a conversation at [1], where we discussed
> addition of a new device tree property to mark IOMMU-protected devices fo=
r Dom0.
>
> As a result of negotiation at [1], I would like to present two
> patches:
>
> 1. The first patch for the hypervisor. It adds a new device property
> 'xen,behind-iommu' to a relevant device node when the device is
> IOMMU-protected.
>
> 2. The second patch is a Linux kernel counterpart. It detects the said
> property and disables swiotlb for a device.
>
> There is a possible issue: some devices may not be able to use DMA
> addresses above 32 bit boundaries, so we can have problems in the
> direct DMA mechanism when swiotlb-xen is disabled for a such
> device. More generally, this can affect any device which DMA address
> range is narrower than CPU one.
>
> In this case,
> the device DMA address should be no bigger than 32 bit boundaries for
> each device that is not using swiotlb-xen.
>
> Several ideas on how to overcome it:
> 1. Do not use high memory for Dom0.
> 2. Set DMA 32bit mask for each device if swiotlb is not used for this dev=
ice.
> 3. Force balloon driver to allocate buffers only below 4GB.
>
> I will be glad to get any comments or suggestions.
>
> [1] https://lore.kernel.org/xen-devel/AM7PR03MB65936E5D0B25567D1B2FAECA85=
CC9@AM7PR03MB6593.eurprd03.prod.outlook.com/
>
> Roman Skakun (1):
>   xen/arm: set iommu property for IOMMU-protected devices
>
>  xen/arch/arm/domain_build.c | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> --
> 2.27.0
>


--=20
Best Regards, Roman.


From xen-devel-bounces@lists.xenproject.org Tue Oct 12 14:20:34 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 14:20:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.207269.363036 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maIdq-0008Jw-Cf; Tue, 12 Oct 2021 14:20:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 207269.363036; Tue, 12 Oct 2021 14:20:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maIdq-0008Jp-8n; Tue, 12 Oct 2021 14:20:30 +0000
Received: by outflank-mailman (input) for mailman id 207269;
 Tue, 12 Oct 2021 14:20:28 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1maIdo-0008Jj-CZ
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 14:20:28 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1maIdn-0002aV-Nc; Tue, 12 Oct 2021 14:20:27 +0000
Received: from 54-240-197-225.amazon.com ([54.240.197.225] helo=[192.168.23.5])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1maIdn-0006ae-Go; Tue, 12 Oct 2021 14:20:27 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=DNLi+OaqYxafUdxxDsvPgrMYg9wEILg3t4r9BKxE2Ck=; b=b8IiIU/sTJ2kDJ4+L4DB6SyjxG
	VjaAaVaXRkS3wnDwvswEwVECkUpjPyYGBDWaxOkF9g3cDdBrLRgHIekJ8QUxvwBwZOdNpf1MUBdod
	jP8LQTg6rHVbYTW99RIqjLY1KbFA61hK1FBURnnEtLocyALYb4/cD9T7FmaT3VsUYPGE=;
Message-ID: <243d4615-fb29-6be0-eef9-c892cb56f8bc@xen.org>
Date: Tue, 12 Oct 2021 15:20:25 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.2.0
Subject: Re: [RFC 0/1] tag IOMMU-protected devices in Dom0 fdt
To: Roman Skakun <rm.skakun@gmail.com>,
 Stefano Stabellini <sstabellini@kernel.org>, xen-devel@lists.xenproject.org
Cc: Roman Skakun <roman_skakun@epam.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrii Anisov <andrii_anisov@epam.com>
References: <cover.1633106362.git.roman_skakun@epam.com>
 <CADu_u-PVqHc6RQ4JTpkrmNap+QxEh7=0Mu2xsiAjOty3J5hKjQ@mail.gmail.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <CADu_u-PVqHc6RQ4JTpkrmNap+QxEh7=0Mu2xsiAjOty3J5hKjQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit



On 12/10/2021 15:11, Roman Skakun wrote:
> Hi,

Hi Roman,

> Would you be so kind to look at my patches, it would help me to
> know exactly whether I'm moving correctly and whether I've chosen
> the right path?

This is in my queue to review. At the moment, I am prioritizing work 
targeting 4.16. Unfortunately, this RFC was posted after the last 
posting date. So I will review it after the feature freeze.

Best regards,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Tue Oct 12 14:23:24 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 14:23:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.207278.363047 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maIgc-0000Vi-PN; Tue, 12 Oct 2021 14:23:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 207278.363047; Tue, 12 Oct 2021 14:23:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maIgc-0000Vb-MU; Tue, 12 Oct 2021 14:23:22 +0000
Received: by outflank-mailman (input) for mailman id 207278;
 Tue, 12 Oct 2021 14:23:20 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=U2oI=PA=gmail.com=rm.skakun@srs-us1.protection.inumbo.net>)
 id 1maIga-0000VT-MB
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 14:23:20 +0000
Received: from mail-lf1-x12c.google.com (unknown [2a00:1450:4864:20::12c])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id bfac3e54-a5a3-4c79-85e8-5dd6bff9a7d8;
 Tue, 12 Oct 2021 14:23:19 +0000 (UTC)
Received: by mail-lf1-x12c.google.com with SMTP id y15so88483043lfk.7
 for <xen-devel@lists.xenproject.org>; Tue, 12 Oct 2021 07:23:19 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: bfac3e54-a5a3-4c79-85e8-5dd6bff9a7d8
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc:content-transfer-encoding;
        bh=ct4m37rxCiZlZTpZjjg9zCs/ZaOobzFpJHx7onj7Shc=;
        b=IOttjUkcdv39ZC0AVC0HdqEg0oHaJf+JfXfz2HD2BNODJoesqjS75WvDAWtgB/wFsU
         nMzfW+6ud7+HBZKKPDHVgqvHjMD9d/+YoM6BOV3wtnRgpII+M3Ch49cPPVAWAcwaiFe+
         urfsVC+JquLDU35+5FG52FaLONO1i+07f5RjftwLTGDnEKBpyjRK+3RWwZlJPOzUK+jb
         3KCoqZSAYKkLYaE0e6A8sbx2A96z0VwwVK5T66bjQbT/FhIFldlFFRpPYDn5uIbpWWPo
         sCtHHLowGVaTAnT8wpzbHW/CeSw520KMKjXVubWtPx7BKt7ho2gqsGGnDN+PziN854X2
         J3EA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc:content-transfer-encoding;
        bh=ct4m37rxCiZlZTpZjjg9zCs/ZaOobzFpJHx7onj7Shc=;
        b=wYMe9r7grOiPQKHPFfraqIbImmbXC9efmcPCYbiuppbXu+tfUay/Eox/pOYQMeGiKB
         GaI/nr9Wrqw13TRn66cXV95tfo64fVEBs5AtiBDdp1ZmsvvGplRMt/qfIFitsFD+M0bM
         g6/CeBB7WmwVAPKjgQ2Ocm+BbmAgIwBw0sg6aHmHClN/CFftp8ShtozjNf5lEeoymkHO
         Hj3GDK6/ZmV+kBXerFvA5lzoQJdtkdC4KxVBJMMq8axaewvLoGA6Yy/Fx/JlOhVLHb34
         InOEPjAa76J0csGeP9Ch8J1rRbFLKM33d4osikCNrrPR0g/0T5NtxmVUMOFzbew/B2w9
         VMQQ==
X-Gm-Message-State: AOAM532wgzPhS+suVIcV5BooGpxO6RkTN6VEXuiIi4QWTCzK0TOxqjMA
	EHDzzLul1iZUxsp3cOptsxXM0sdKhhTiDBVloUU=
X-Google-Smtp-Source: ABdhPJxnHoyZKaY+ELcqvbRVw+32P7kWeZ79yogq8t+sqUa/nhI5uzLbLUjsq4mk2TNxG98V+VdCLQsMwaAS1VmbcI4=
X-Received: by 2002:a2e:8099:: with SMTP id i25mr18024414ljg.277.1634048598802;
 Tue, 12 Oct 2021 07:23:18 -0700 (PDT)
MIME-Version: 1.0
References: <cover.1633106362.git.roman_skakun@epam.com> <CADu_u-PVqHc6RQ4JTpkrmNap+QxEh7=0Mu2xsiAjOty3J5hKjQ@mail.gmail.com>
 <243d4615-fb29-6be0-eef9-c892cb56f8bc@xen.org>
In-Reply-To: <243d4615-fb29-6be0-eef9-c892cb56f8bc@xen.org>
From: Roman Skakun <rm.skakun@gmail.com>
Date: Tue, 12 Oct 2021 17:23:08 +0300
Message-ID: <CADu_u-OE2ZoB6vPDwayRyBV+03szTx7Ah84GWLeQeSEGvCbjpQ@mail.gmail.com>
Subject: Re: [RFC 0/1] tag IOMMU-protected devices in Dom0 fdt
To: Julien Grall <julien@xen.org>
Cc: Stefano Stabellini <sstabellini@kernel.org>, xen-devel@lists.xenproject.org, 
	Roman Skakun <roman_skakun@epam.com>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, 
	Andrii Anisov <andrii_anisov@epam.com>, Roman Skakun <rm.skakun@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Understood.
Thank you!

=D0=B2=D1=82, 12 =D0=BE=D0=BA=D1=82. 2021 =D0=B3. =D0=B2 17:20, Julien Gral=
l <julien@xen.org>:
>
>
>
> On 12/10/2021 15:11, Roman Skakun wrote:
> > Hi,
>
> Hi Roman,
>
> > Would you be so kind to look at my patches, it would help me to
> > know exactly whether I'm moving correctly and whether I've chosen
> > the right path?
>
> This is in my queue to review. At the moment, I am prioritizing work
> targeting 4.16. Unfortunately, this RFC was posted after the last
> posting date. So I will review it after the feature freeze.
>
> Best regards,
>
> --
> Julien Grall



--=20
Best Regards, Roman.


From xen-devel-bounces@lists.xenproject.org Tue Oct 12 14:25:42 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 14:25:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.207286.363059 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maIio-00019f-8l; Tue, 12 Oct 2021 14:25:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 207286.363059; Tue, 12 Oct 2021 14:25:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maIio-00019Y-3V; Tue, 12 Oct 2021 14:25:38 +0000
Received: by outflank-mailman (input) for mailman id 207286;
 Tue, 12 Oct 2021 14:25:37 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=xSmm=PA=suse.com=jgross@srs-us1.protection.inumbo.net>)
 id 1maIin-00019S-AA
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 14:25:37 +0000
Received: from smtp-out1.suse.de (unknown [195.135.220.28])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 432e4bc7-2b68-11ec-812c-12813bfff9fa;
 Tue, 12 Oct 2021 14:25:36 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 90461221A8;
 Tue, 12 Oct 2021 14:25:35 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 5C47213BEC;
 Tue, 12 Oct 2021 14:25:35 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id ZZblFN+aZWH/BQAAMHmgww
 (envelope-from <jgross@suse.com>); Tue, 12 Oct 2021 14:25:35 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 432e4bc7-2b68-11ec-812c-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1634048735; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=guPk8zfBCthwS8F0QeAJsSijnxRzwqmqBpspkXyo3us=;
	b=K4WaRSTTOorCwm3T01p6W3EQDKkI4I6B7QYi+KH1roUrXWhZ24DEgS/frpXdYyT2uy/RnE
	wB2XqfCvkaUVx2xeW8FFzP1xc3cNteyCfjE+ycGCUHgdHtAjA6yHO+gI0VsdFccNaScK92
	3V8fOxCKEowLYR5beCklx5byD2e6y9w=
Subject: Re: [PATCH] x86/xen: Remove redundant irq_enter/exit() invocations
To: Thomas Gleixner <tglx@linutronix.de>, LKML <linux-kernel@vger.kernel.org>
Cc: x86@kernel.org, Stefano Stabellini <sstabellini@kernel.org>,
 Boris Ostrovsky <boris.ostrovsky@oracle.com>, xen-devel@lists.xenproject.org
References: <877deicqqy.ffs@tglx>
From: Juergen Gross <jgross@suse.com>
Message-ID: <bc88bc9c-d5bb-d9a2-0d48-c8703a613c59@suse.com>
Date: Tue, 12 Oct 2021 16:25:34 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <877deicqqy.ffs@tglx>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="2sPSvhgQKMYS9Whh2PdAfAQQKaZ488tDk"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--2sPSvhgQKMYS9Whh2PdAfAQQKaZ488tDk
Content-Type: multipart/mixed; boundary="XvPhciOFEbq9tYu14J8sSBzEis0fr8ySK";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Thomas Gleixner <tglx@linutronix.de>, LKML <linux-kernel@vger.kernel.org>
Cc: x86@kernel.org, Stefano Stabellini <sstabellini@kernel.org>,
 Boris Ostrovsky <boris.ostrovsky@oracle.com>, xen-devel@lists.xenproject.org
Message-ID: <bc88bc9c-d5bb-d9a2-0d48-c8703a613c59@suse.com>
Subject: Re: [PATCH] x86/xen: Remove redundant irq_enter/exit() invocations
References: <877deicqqy.ffs@tglx>
In-Reply-To: <877deicqqy.ffs@tglx>

--XvPhciOFEbq9tYu14J8sSBzEis0fr8ySK
Content-Type: multipart/mixed;
 boundary="------------8E0116D9A3A0427AB8D1A423"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------8E0116D9A3A0427AB8D1A423
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 12.10.21 15:33, Thomas Gleixner wrote:
> All these handlers are regular device interrupt handlers, so they alrea=
dy
> went through the proper entry code which handles this correctly.
>=20
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Cc: Juergen Gross <jgross@suse.com>
> Cc: Stefano Stabellini <sstabellini@kernel.org>
> Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> Cc: x86@kernel.org
> Cc: xen-devel@lists.xenproject.org

Reviewed-by: Juergen Gross <jgross@suse.com>


Juergen

--------------8E0116D9A3A0427AB8D1A423
Content-Type: application/pgp-keys;
 name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Transfer-Encoding: quoted-printable
Content-Description: OpenPGP public key
Content-Disposition: attachment;
 filename="OpenPGP_0xB0DE9DD628BF132F.asc"

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy=
cWx
w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O=
f8Z
d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y=
9bf
IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq=
G7/
377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR=
3Jv
c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA=
QIe
AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT=
hpw
dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0=
MbD
1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv=
oPH
Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v=
5QL
+qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ=
2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC=
QoL
BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr=
Wf0
teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC=
/nu
AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh=
ITT
d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm=
XBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz=
80h
SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC=
AcD
AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn=
FOX
gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1=
jnD
kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0=
N51
N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l=
otu
fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1=
tqS
EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA=
hsD
BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3=
g3O
ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5=
dM7
wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5=
D+j
LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm=
V2x
AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N=
Eaw
QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW=
nHI
s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR=
wgn
BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV=
bVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk=
pEd
IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA=
QAB
wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw=
Tbe
8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1=
vJz
Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8=
VGi
wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW=
svi
uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX=
zXs
ZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------8E0116D9A3A0427AB8D1A423--

--XvPhciOFEbq9tYu14J8sSBzEis0fr8ySK--

--2sPSvhgQKMYS9Whh2PdAfAQQKaZ488tDk
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmFlmt4FAwAAAAAACgkQsN6d1ii/Ey+Y
dAf/f9Fq0nkc61S210cbOT9pAAa2POrdWr8auU+46lGlTPqgEvpYrlaltzudbe5i/RLzgGR5/owZ
XTG6aS8emK8RK9rH9JPuGa3nhZPPH202luvmjKCfQ9u6S2RPSt7Znmo1PUGwnRAL8jom2JkbMvbA
05MMkC3SuLUcmYGDg+7nkG7oi8WUHVcbJPj0i+FUmH6jFSQrMVXzlJB4Ja4aejnz2KeZOSa0Z1ov
F8/bAImhKtXG94XET5xOAiBozjzbaWSYsgoYIM9ZQnEKtc4dUEk9IqJP0mhdfGOgM7D0QZx+wGix
I93t1h2skDRGb7BVvKA4C9VUyeA3TVa5oMF1Htfsrg==
=tDHm
-----END PGP SIGNATURE-----

--2sPSvhgQKMYS9Whh2PdAfAQQKaZ488tDk--


From xen-devel-bounces@lists.xenproject.org Tue Oct 12 14:31:51 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 14:31:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.207296.363069 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maIok-0002c7-V6; Tue, 12 Oct 2021 14:31:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 207296.363069; Tue, 12 Oct 2021 14:31:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maIok-0002c0-Ry; Tue, 12 Oct 2021 14:31:46 +0000
Received: by outflank-mailman (input) for mailman id 207296;
 Tue, 12 Oct 2021 14:31:45 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Tock=PA=citrix.com=anthony.perard@srs-us1.protection.inumbo.net>)
 id 1maIoj-0002bu-GX
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 14:31:45 +0000
Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 1f20046d-2b69-11ec-812e-12813bfff9fa;
 Tue, 12 Oct 2021 14:31:44 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1f20046d-2b69-11ec-812e-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1634049104;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=MBrbwQMGHzNokWHhDM1T2+lCJW7y+/uZ0c5p5B8LL/g=;
  b=QHa8inzc699qzDl1ITn985AYDDdRU+qbybCyXmejYLszqg+cizL7kxMr
   tlJBV4IfH9XbeOpPW7dTHutfDbMkKeqs/hsA84Uj/i0Ji3GB3aAifCIVa
   LWwHj/AW2hNyjfLpegMGcuJRiJ5lzcybLt5B7tJr7NbXkILxcTxrypKKO
   4=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: +jZ2SpFyoidCyXWXZ+PCGJqEnlGPwRIlziQeAjVkCFWLEstTExLy11T7F882rjq2PeUpd0TJVk
 AnNGy9YmjB8MOt5JIzAmDJ3CgK8V/ziJZUiEqwr+pQnQiQlVI/9yG5t/9mmz0Wj4SvfiVIMfjs
 mnqGIvZ9/bv4vqaF+wvbNrO4zh7QqFGLHHMQ/yiCbwZNVBSvbG61zYaYUvHp5EKrdosFQIOX9K
 4xNn1IcEkqZakBzUITmGxGuDuw1lnlb+UDk33NCjMDt4VYTMZ7aK/p+FoG0YHBdBmMnkEzJ9/9
 xDb4tdXkVfM8rVIMwd+K5Wdz
X-SBRS: 5.1
X-MesageID: 55020974
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:SjdkuqsJ0EPbKApA0LeDUtnSmefnVF1YMUV32f8akzHdYApBsoF/q
 tZmKWuOb6yNajD8ctojb4q19ExTuJKExoJmQVRlqSA0Qy4X+JbJXdiXEBz9bniYRiHhoOOLz
 Cm8hv3odp1coqr0/0/1WlTZQP0VOZigHtIQMsadUsxKbVIiGHpJZS5LwbZj29cw2ILhWmthh
 PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe
 gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ
 Npl8reXFT8QA4/wquFaTiRVEgxdE5FWweqSSZS/mZT7I0zudnLtx7NlDV0sPJ1e8eFyaY1M3
 aVGcnZXNEnF3r/ohuLgIgVvrp1LwM3DNYUDunZm3HfBAOwvW5zrSKTW/95Imjw3g6iiGN6DO
 pJDMWswMHwsZTURCH4WNqM/o9yXxSH1cQdRtGOFqYw4tj27IAtZj+G2bYu9lsaxbcdahEGDv
 Urd4n/0RBodMbS30z2e+GirgezJtSr6XowVD7CzsPVthTW72Wg7GBAQE1yhrpGRgEOkR8hWL
 UBS/yM0tLUz72SiVNy7VBq9yFa6uRobV8tVAvcNwgiHwarJ4C6UHmEBCDVGbbQOuMYoSBQw2
 1SOntevAiZg2JWUVnC15rqStSm1OyUeMSkFfyBsZRsI5ZzvrZ8+ijrLT81/C+ilg9vtAzbyz
 juW6i8kiN07iM8A16y/u1fdkT+ojpHTS0g+4QC/dnm+8gpzaYqhZoqpwVvW9/BNKMCeVFbpl
 HoZn8mT6sgeAJfLkzaCKM0PFry04/eOMBXHnEViWZIm8lyQF2WLJN4KpmskfQEwb5hCKWSBj
 FLvVR15o7R0YEOTUI1LUYf2FvknzIXDO+j1b6WBBjZRWaRZeAiC9SBoQEef2WHxjUQh+Z0C1
 YenndWEVilCV/w2pNaib6JEi+Vzn3FhrY/Gbcmjl0zP7FaIWJKCpV7p2nO1Zecl8LjMngzR9
 9tOXydh40QCCLOgCsU7HIh6ELzrEZTZLcyowyC0XrTaSuaDJI3HI6WPqV/GU9Y095m5bs+So
 hmAtrZwkTITf0HvJwSQcWxEY7jyR5t5pn9TFXVyZg35hCdzMdjxsft3m34LkV8PrrILIRlcF
 ahtRil9Kq4XFmSvF8o1PPERU7COhDz03FnTbkJJkRA0foJ6RhyhxzMXVlCHycX6NQLu7ZFWi
 +T5jmvzGMNfLyw/XJe+QK/+lDuZ4ClC8N+eqmOVe7G/jm23q9M0Q8Ew59dqS/wxxeLrn2PAi
 VnNW0tE/IEgYeYdqbH0uExNlK/xe8MWI6aQNzezAW+eOXaI82y975VHVerULznRWHmtoPepZ
 PlPzuG6O/oCxQ4Yv415Grdt7KQ/+9qw+OMKklU6RC3GPwaxF7dtAniaxs0T5KdD8aBU5FmtU
 UWV99gEZbjQYJH5EEQcLRYOZ/iY0a1GgSHb6Pk4eR2o5CJ+8Ledf19VOh2A1H5UILdvadt3y
 uY9os8GrQe4j0NyYNqBiylV8UWKL2ABDPp75s1LXtezh1NymF9YYJHaBivn2721ao1BYhswP
 zuZpKvenLAAlEDMRGU+SCrW1u1HiJVQ5B0TlA0eJ06Ek8buj+Ms2EED6iw+SwlYw0kV0+93P
 WQ3ZUR5Kb/XomVtjclHGWutBxtAFFuS/UmokwkFk2jQTk+JUG3RLTJiZbbRrR5Bq28MLCJG+
 Ly4yXr+VWe4dc786SI+REp5pqGxVtd27ADDxJiqEsnt80PWutY5bntCvVY1liY=
IronPort-HdrOrdr: A9a23:re19RqFUVVlyzVuYpLqE7MeALOsnbusQ8zAXPidKOHtom62j5q
 STdZEgviMc5wx8ZJhNo7+90cq7IU80l6Qa3WB5B97LNmTbUQCTTb1K3M/PxCDhBj271sM179
 YET0GmMqySMbGtt7eZ3DWF
X-IronPort-AV: E=Sophos;i="5.85,367,1624334400"; 
   d="scan'208";a="55020974"
Date: Tue, 12 Oct 2021 15:31:25 +0100
From: Anthony PERARD <anthony.perard@citrix.com>
To: Michal Orzel <michal.orzel@arm.com>
CC: <xen-devel@lists.xenproject.org>, Andrew Cooper
	<andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>, "Ian
 Jackson" <iwj@xenproject.org>, Jan Beulich <jbeulich@suse.com>, Julien Grall
	<julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>, Wei Liu
	<wl@xen.org>, Nick Rosbrook <rosbrookn@ainfosec.com>, Juergen Gross
	<jgross@suse.com>, Christian Lindig <christian.lindig@citrix.com>, "David
 Scott" <dave@recoil.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	<bertrand.marquis@arm.com>
Subject: Re: [PATCH v5 3/3] xen: Expose the PMU to the guests
Message-ID: <YWWcPTdeK3s960i2@perard>
References: <20211012081323.14141-1-michal.orzel@arm.com>
 <20211012081323.14141-4-michal.orzel@arm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20211012081323.14141-4-michal.orzel@arm.com>

On Tue, Oct 12, 2021 at 10:13:23AM +0200, Michal Orzel wrote:
> diff --git a/tools/libs/light/libxl_create.c b/tools/libs/light/libxl_create.c
> index e356b2106d..2a0234ec16 100644
> --- a/tools/libs/light/libxl_create.c
> +++ b/tools/libs/light/libxl_create.c
> @@ -622,6 +623,9 @@ int libxl__domain_make(libxl__gc *gc, libxl_domain_config *d_config,
>                  create.flags |= XEN_DOMCTL_CDF_nested_virt;
>          }
>  
> +        if ( libxl_defbool_val(b_info->vpmu) )

We don't usually have space between the parentheses and the condition in
libxl.

> +            create.flags |= XEN_DOMCTL_CDF_vpmu;
> +
>          assert(info->passthrough != LIBXL_PASSTHROUGH_DEFAULT);
>          LOG(DETAIL, "passthrough: %s",
>              libxl_passthrough_to_string(info->passthrough));
> @@ -1199,6 +1203,12 @@ int libxl__domain_config_setdefault(libxl__gc *gc,
>          goto error_out;
>      }
>  
> +    if (libxl_defbool_val(d_config->b_info.vpmu) && !physinfo.cap_vpmu) {
> +        ret = ERROR_INVAL;
> +        LOGD(ERROR, domid, "vpmu not supported on this platform\n");

You don't need a '\n' here. Also, you could write "vPMU" instead of
"vpmu" in the error message.

Otherwise, changes for libxl and xl looks good:
Acked-by: Anthony PERARD <anthony.perard@citrix.com>

Thanks,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Tue Oct 12 14:32:18 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 14:32:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.207301.363080 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maIpG-000385-8f; Tue, 12 Oct 2021 14:32:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 207301.363080; Tue, 12 Oct 2021 14:32:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maIpG-00037y-3b; Tue, 12 Oct 2021 14:32:18 +0000
Received: by outflank-mailman (input) for mailman id 207301;
 Tue, 12 Oct 2021 14:32:16 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1maIpE-00037p-DU
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 14:32:16 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1maIpD-0002oD-ED; Tue, 12 Oct 2021 14:32:15 +0000
Received: from 54-240-197-225.amazon.com ([54.240.197.225] helo=[192.168.23.5])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1maIpD-0007eO-7V; Tue, 12 Oct 2021 14:32:15 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=ZXweFQqQkp2UfaduC2vwvJaXMd6vg+Z6mZsfPzym/MY=; b=J9PIOxN3HmST4fPzrTd3SNTNVK
	IIe7/vT6aunN1MC2rVI/nrfONh3VkixQQTOPkyG4CLuqfklR4Mg34If4jhyLhEVA/qFqUEMqHBg1n
	32U3ghJ81tGqukNSbVxwlZwye9XIw8mpVeS679D3l13+pssEvssDmjAikScyLdeX3TaM=;
Message-ID: <82a77cd7-4562-48ac-805e-69ec46e45ef7@xen.org>
Date: Tue, 12 Oct 2021 15:32:12 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.2.0
Subject: Re: [PATCH v5 08/11] xen/arm: Enable the existing x86 virtual PCI
 support for ARM.
To: Rahul Singh <rahul.singh@arm.com>, xen-devel@lists.xenproject.org
Cc: bertrand.marquis@arm.com, Andre.Przywara@arm.com,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Jan Beulich <jbeulich@suse.com>, Wei Liu <wl@xen.org>,
 Paul Durrant <paul@xen.org>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>
References: <cover.1633540842.git.rahul.singh@arm.com>
 <9bdca2cda5d2e83f94dc2423e55714273539760a.1633540842.git.rahul.singh@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <9bdca2cda5d2e83f94dc2423e55714273539760a.1633540842.git.rahul.singh@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi Rahul,

On 06/10/2021 18:40, Rahul Singh wrote:
> diff --git a/xen/include/asm-arm/domain.h b/xen/include/asm-arm/domain.h
> index c9277b5c6d..91d614b37e 100644
> --- a/xen/include/asm-arm/domain.h
> +++ b/xen/include/asm-arm/domain.h
> @@ -2,6 +2,7 @@
>   #define __ASM_DOMAIN_H__
>   
>   #include <xen/cache.h>
> +#include <xen/nospec.h>
>   #include <xen/timer.h>
>   #include <asm/page.h>
>   #include <asm/p2m.h>
> @@ -262,7 +263,11 @@ static inline void arch_vcpu_block(struct vcpu *v) {}
>   
>   #define arch_vm_assist_valid_mask(d) (1UL << VMASST_TYPE_runstate_update_flag)
>   
> -#define has_vpci(d)    ({ (void)(d); false; })
> +/*
> + * For X86 VPCI is enabled and tested for PVH DOM0 only but
> + * for ARM we enable support VPCI for guest domain also.
> + */

This is the sort of comment that will easily get rot if we change the 
behavior on x86. But I find a bit odd to justify the implementation 
based on x86. Can we simply avoid to mention x86?

> +#define has_vpci(d) evaluate_nospec((d)->options & XEN_DOMCTL_CDF_vpci)
>   
>   #endif /* __ASM_DOMAIN_H__ */
>   
> diff --git a/xen/include/asm-x86/pci.h b/xen/include/asm-x86/pci.h
> index e076951032..c4a4fdcbc2 100644
> --- a/xen/include/asm-x86/pci.h
> +++ b/xen/include/asm-x86/pci.h
> @@ -6,8 +6,6 @@
>   #define CF8_ADDR_HI(cf8) (  ((cf8) & 0x0f000000) >> 16)
>   #define CF8_ENABLED(cf8) (!!((cf8) & 0x80000000))
>   
> -#define MMCFG_BDF(addr)  ( ((addr) & 0x0ffff000) >> 12)
> -
>   #define IS_SNB_GFX(id) (id == 0x01068086 || id == 0x01168086 \
>                           || id == 0x01268086 || id == 0x01028086 \
>                           || id == 0x01128086 || id == 0x01228086 \
> diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h
> index d46c61fca9..44be337dec 100644
> --- a/xen/include/public/arch-arm.h
> +++ b/xen/include/public/arch-arm.h
> @@ -418,6 +418,13 @@ typedef uint64_t xen_callback_t;
>   #define GUEST_GICV3_GICR0_BASE     xen_mk_ullong(0x03020000) /* vCPU0..127 */
>   #define GUEST_GICV3_GICR0_SIZE     xen_mk_ullong(0x01000000)
>   
> +/*
> + * 256 MB is reserved for VPCI configuration space based on calculation
> + * 256 buses × 32 devices × 8 functions × 4 KB = 256 MB
> + */
> +#define GUEST_VPCI_ECAM_BASE    xen_mk_ullong(0x10000000)
> +#define GUEST_VPCI_ECAM_SIZE    xen_mk_ullong(0x10000000)
> +
>   /* ACPI tables physical address */
>   #define GUEST_ACPI_BASE xen_mk_ullong(0x20000000)
>   #define GUEST_ACPI_SIZE xen_mk_ullong(0x02000000)
> diff --git a/xen/include/xen/pci.h b/xen/include/xen/pci.h
> index 70ac25345c..43b8a08170 100644
> --- a/xen/include/xen/pci.h
> +++ b/xen/include/xen/pci.h
> @@ -40,6 +40,8 @@
>   #define PCI_SBDF3(s,b,df) \
>       ((pci_sbdf_t){ .sbdf = (((s) & 0xffff) << 16) | PCI_BDF2(b, df) })
>   
> +#define MMCFG_BDF(addr)  (((addr) & 0x0ffff000) >> 12)
> +
>   typedef union {
>       uint32_t sbdf;
>       struct {
> 

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Tue Oct 12 14:35:03 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 14:35:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.207310.363091 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maIru-0003pQ-M1; Tue, 12 Oct 2021 14:35:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 207310.363091; Tue, 12 Oct 2021 14:35:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maIru-0003pJ-Iu; Tue, 12 Oct 2021 14:35:02 +0000
Received: by outflank-mailman (input) for mailman id 207310;
 Tue, 12 Oct 2021 14:35:01 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=B8jq=PA=arm.com=Bertrand.Marquis@srs-us1.protection.inumbo.net>)
 id 1maIrt-0003pD-2f
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 14:35:01 +0000
Received: from EUR02-AM5-obe.outbound.protection.outlook.com (unknown
 [2a01:111:f400:fe07::60f])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 882ebdf1-973d-4667-8e3e-5a633381bdb5;
 Tue, 12 Oct 2021 14:34:58 +0000 (UTC)
Received: from AM6P192CA0100.EURP192.PROD.OUTLOOK.COM (2603:10a6:209:8d::41)
 by AM6PR08MB3992.eurprd08.prod.outlook.com (2603:10a6:20b:a4::10) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.25; Tue, 12 Oct
 2021 14:34:55 +0000
Received: from VE1EUR03FT044.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:209:8d:cafe::9e) by AM6P192CA0100.outlook.office365.com
 (2603:10a6:209:8d::41) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.26 via Frontend
 Transport; Tue, 12 Oct 2021 14:34:55 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT044.mail.protection.outlook.com (10.152.19.106) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4587.18 via Frontend Transport; Tue, 12 Oct 2021 14:34:55 +0000
Received: ("Tessian outbound e27daf245730:v103");
 Tue, 12 Oct 2021 14:34:54 +0000
Received: from 9580579dfab0.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 2843FE71-1F80-45F3-8040-64B28F9BD6A0.1; 
 Tue, 12 Oct 2021 14:34:47 +0000
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 9580579dfab0.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Tue, 12 Oct 2021 14:34:47 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com (2603:10a6:4:74::9)
 by DB6PR0801MB1750.eurprd08.prod.outlook.com (2603:10a6:4:39::11) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.25; Tue, 12 Oct
 2021 14:34:45 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955]) by DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955%4]) with mapi id 15.20.4587.026; Tue, 12 Oct 2021
 14:34:45 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 882ebdf1-973d-4667-8e3e-5a633381bdb5
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=0/OPZo2EJLtwgu0qtytCBTTOfvDfWlVEMa5hLZsP31E=;
 b=IcWGTByWojCiZMl8u6/nDiBBvqiz4ON+387ONdQC7kj96ykPjr5Y/Tx4N/kDrvOjLOUZIr6sqXi3hzAXhdik1Z+E54bDbxylqzJ63SRMNeS06FMz9I0Hmp9HAbkXNkGd7sB4u/jEikOygunCLjKU95mzFtwH1tDI/q/O4tf05RM=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: e64bac94060bb996
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=GmDLVRMmgKzX0CbWBuPn9c04w6p6SuI8GpOTHS3hBJU93fL5z733LFKPh8E65XOhXmxbrxjMxUf/OB+ISzODKekAd/h4eLSa8vU7QrT5vxogTyd05KGxDwhjVM4GKoOU5Dy6uMhNzftvl1k4hNm9vR30B/JD/a1WEnu8mzO2bucg4eTKFtvNZfZN/CArQPuxMk4c3vRPziv7VCwWqt6hIqm43K2NyaPBZwny3HcbNrnRYALwMeKQiELy48B2/vd71xEDVAsGIjHhdazzD6gZCn+immTBMcb6JzXi+GC2ImCjb0visKydUDzE59l6u80E+5CSGrSWSh+f7CxNRn7AwA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=0/OPZo2EJLtwgu0qtytCBTTOfvDfWlVEMa5hLZsP31E=;
 b=NS50L8N/3g7ecMHaUwotxBFalXgl/5t4qSWCcHc2JeJ0xICVhyBTTubAbR4LCwpM1mR0V1R4yBahuDWVT7w7qe9ckND3mQC3oOtDXD4easS9JUFAMEXqz82yACC2rMkS1O8UzC7qa+cMj8UNTM7JjP/fuzaY/2k2beVjCx+8ttQ9xExgxazayNCjsifYVlB3kUzviJgqZoWIry4xiWXEbsdLelFhS3rFAbXa6f3T2RGb1FxAYLzbRout7RAmSyxHP2+wSa41rH3PfgzK6UC6SBJ1XC9ToiZLyMbjcHiOLgFtQQuSIOGIDm2+FO16nl3i5TXrxHaO/tN/ZRXPI+BPeA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=0/OPZo2EJLtwgu0qtytCBTTOfvDfWlVEMa5hLZsP31E=;
 b=IcWGTByWojCiZMl8u6/nDiBBvqiz4ON+387ONdQC7kj96ykPjr5Y/Tx4N/kDrvOjLOUZIr6sqXi3hzAXhdik1Z+E54bDbxylqzJ63SRMNeS06FMz9I0Hmp9HAbkXNkGd7sB4u/jEikOygunCLjKU95mzFtwH1tDI/q/O4tf05RM=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Julien Grall <julien@xen.org>
CC: Rahul Singh <Rahul.Singh@arm.com>, Xen-devel
	<xen-devel@lists.xenproject.org>, Andre Przywara <Andre.Przywara@arm.com>,
	Stefano Stabellini <sstabellini@kernel.org>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
	Jan Beulich <jbeulich@suse.com>, Wei Liu <wl@xen.org>, Paul Durrant
	<paul@xen.org>, =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>
Subject: Re: [PATCH v5 08/11] xen/arm: Enable the existing x86 virtual PCI
 support for ARM.
Thread-Topic: [PATCH v5 08/11] xen/arm: Enable the existing x86 virtual PCI
 support for ARM.
Thread-Index: AQHXutl3YqS5dHXsYk6KpdKt4d14RavPdjAAgAAAt4A=
Date: Tue, 12 Oct 2021 14:34:45 +0000
Message-ID: <FD746284-1A8C-4964-982B-6B2A4E127077@arm.com>
References: <cover.1633540842.git.rahul.singh@arm.com>
 <9bdca2cda5d2e83f94dc2423e55714273539760a.1633540842.git.rahul.singh@arm.com>
 <82a77cd7-4562-48ac-805e-69ec46e45ef7@xen.org>
In-Reply-To: <82a77cd7-4562-48ac-805e-69ec46e45ef7@xen.org>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3654.120.0.1.13)
Authentication-Results-Original: xen.org; dkim=none (message not signed)
 header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: 774df500-559e-4ddd-281d-08d98d8d75a2
x-ms-traffictypediagnostic: DB6PR0801MB1750:|AM6PR08MB3992:
x-ms-exchange-transport-forked: True
X-Microsoft-Antispam-PRVS:
	<AM6PR08MB3992B605A09A9472A50B9D299DB69@AM6PR08MB3992.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:883;OLM:883;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 B7lreuX8a+yPM8ncFYYzlekNuRkpiuYJH1uHhrfhK3hYZLN48RL2CjJ7St/Goue5HMkpm22bwKm4CT5GA6fCfw1AEUIcp3J7nYREj0wUGhLewnDNFfgOKjrjkKai1fcTvbsm/epYzRz5cYXEWeAaCy6m+/ZaT3/yB2OofJWs/tuH/fUvi0wyPJm0xbILcLqeyTFbKPv9/C6/vyLOaTJj2qYaXiZQY6sFTWYhBR7DqQP/Igc2qiRkqWtTQ8UCOhN5VQttBjH07nmj2LLnpWIrhrnjXr2chpzF4w/XrMkT3xwoQhRpaJT/FMamKPGASf7P5Pqyb+0AWui+L+Sh8EavNkh2nbAWzUanGWhvpMvh7R3umvgB94VveDdmXC50iAcSvwCZwThqDK0GLdcT61zhlJu58h0aVi+Ar3tMzA86c2/8xZAw4hMR0SkFe4APAcmDFYdf26ORmLVGWZ9yVREaTgb4sIjliEeixYttEeYzs9v0K7Id2GrrPYE1J/GFCXdjc45r+xVDP2qrbbu7KIPL8+v28NQxLI0aZqgctHUrwtPogV/nCdtQ9ulBopv2fNadxIGra/U188djZOp0PWAa0jlCKlh+v0Z7ZCWRxXkt2BXAOvrhRz21U4yIQhMyMcBToNn1pkLcRNDsRA5hN478X3u+PKbgePleI751GqtVFXLmyEIzxcyw3evOOkGQJCZdQgUNOl5C9y1d1vjf+bqoIsKhs3aFgxWHDrIA+cfHtOgQUlvAXaKV+I80PuIE++9D
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB6PR0801MB2024.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(83380400001)(8676002)(66476007)(66556008)(7416002)(2616005)(76116006)(64756008)(8936002)(6486002)(186003)(66446008)(66946007)(316002)(91956017)(4326008)(86362001)(33656002)(38070700005)(26005)(54906003)(36756003)(38100700002)(53546011)(6512007)(122000001)(5660300002)(6916009)(6506007)(508600001)(2906002)(71200400001)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-ID: <D160864B5CE8A8459B0E838DEB8D37BB@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0801MB1750
Original-Authentication-Results: xen.org; dkim=none (message not signed)
 header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT044.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	e6bafb5c-84c3-4874-fe66-08d98d8d6fc6
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	oDrQHkW2VPzPEmi03XS23uVBBhOWT8UtOaBmyyNQz1Nb6oIAt96omXP6asqUhqg8tuQ9oLmKVbQAQU5WnwIFcFrjcIc+HVGMI981Fj4w4PLfmh726CrHrB+RCE7qARCZgZ0xH8oI4IAwzbXC5Czs5es8EXAZQ5/ro86VP+uW85yQoEIimP5GHx6NJRGDSTVpbc5JPZ76pSEXF77EE2+bDXdvV8OBhP+cmYomABToDgsMjRscpP87MduHNoykVFim7wT7JjM7gOT8tAoBAPWYJA2bvHzBGPcmsu/8UfDfAhUf2YgDesK/+YYDk6pIPwpaxSNFqJ0jo37nJwsRbULoUEI9pPbt0HI5h7X23K8sPHPQQWCwMA/kersvukgEXeFXlSfG8If97EeDDbGGH6kFNA4MZ75eQJwWbS1L+DpHwk/wdbHvbPVIcaHMfd9Ub2gg7F4wOmo6ANKs30WnnWmrrHDh4kyWwQHWHWex0sQBMTK1zRXZr7VZAcLusBhOc6lNjHFzsdBt//sRkGLPiWMt5xn5vAE+jubKOj/ofs85A0+S52aXO9em5XtBwObycgfWnnt+muXqMiADEVtCt7eU/z8CDLHCEc6tGDDoJEXE91YiVMXveX1ZolATQw1ybm2vXr/wQBfZuy51QEJ7e9iuS9cwPK8aTShN4j6SymaIowezTj7VKK145z6NhQ/7dxdXXORY1cQFR0HPzh4qcDherg==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(4326008)(70206006)(83380400001)(356005)(70586007)(47076005)(2616005)(81166007)(8676002)(316002)(336012)(6512007)(36860700001)(508600001)(6506007)(36756003)(82310400003)(86362001)(54906003)(8936002)(6486002)(186003)(26005)(2906002)(33656002)(6862004)(5660300002)(107886003)(53546011);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2021 14:34:55.1633
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 774df500-559e-4ddd-281d-08d98d8d75a2
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT044.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3992

SGkgSnVsaWVuLA0KDQo+IE9uIDEyIE9jdCAyMDIxLCBhdCAxNTozMiwgSnVsaWVuIEdyYWxsIDxq
dWxpZW5AeGVuLm9yZz4gd3JvdGU6DQo+IA0KPiBIaSBSYWh1bCwNCj4gDQo+IE9uIDA2LzEwLzIw
MjEgMTg6NDAsIFJhaHVsIFNpbmdoIHdyb3RlOg0KPj4gZGlmZiAtLWdpdCBhL3hlbi9pbmNsdWRl
L2FzbS1hcm0vZG9tYWluLmggYi94ZW4vaW5jbHVkZS9hc20tYXJtL2RvbWFpbi5oDQo+PiBpbmRl
eCBjOTI3N2I1YzZkLi45MWQ2MTRiMzdlIDEwMDY0NA0KPj4gLS0tIGEveGVuL2luY2x1ZGUvYXNt
LWFybS9kb21haW4uaA0KPj4gKysrIGIveGVuL2luY2x1ZGUvYXNtLWFybS9kb21haW4uaA0KPj4g
QEAgLTIsNiArMiw3IEBADQo+PiAgI2RlZmluZSBfX0FTTV9ET01BSU5fSF9fDQo+PiAgICAjaW5j
bHVkZSA8eGVuL2NhY2hlLmg+DQo+PiArI2luY2x1ZGUgPHhlbi9ub3NwZWMuaD4NCj4+ICAjaW5j
bHVkZSA8eGVuL3RpbWVyLmg+DQo+PiAgI2luY2x1ZGUgPGFzbS9wYWdlLmg+DQo+PiAgI2luY2x1
ZGUgPGFzbS9wMm0uaD4NCj4+IEBAIC0yNjIsNyArMjYzLDExIEBAIHN0YXRpYyBpbmxpbmUgdm9p
ZCBhcmNoX3ZjcHVfYmxvY2soc3RydWN0IHZjcHUgKnYpIHt9DQo+PiAgICAjZGVmaW5lIGFyY2hf
dm1fYXNzaXN0X3ZhbGlkX21hc2soZCkgKDFVTCA8PCBWTUFTU1RfVFlQRV9ydW5zdGF0ZV91cGRh
dGVfZmxhZykNCj4+ICAtI2RlZmluZSBoYXNfdnBjaShkKSAgICAoeyAodm9pZCkoZCk7IGZhbHNl
OyB9KQ0KPj4gKy8qDQo+PiArICogRm9yIFg4NiBWUENJIGlzIGVuYWJsZWQgYW5kIHRlc3RlZCBm
b3IgUFZIIERPTTAgb25seSBidXQNCj4+ICsgKiBmb3IgQVJNIHdlIGVuYWJsZSBzdXBwb3J0IFZQ
Q0kgZm9yIGd1ZXN0IGRvbWFpbiBhbHNvLg0KPj4gKyAqLw0KPiANCj4gVGhpcyBpcyB0aGUgc29y
dCBvZiBjb21tZW50IHRoYXQgd2lsbCBlYXNpbHkgZ2V0IHJvdCBpZiB3ZSBjaGFuZ2UgdGhlIGJl
aGF2aW9yIG9uIHg4Ni4gQnV0IEkgZmluZCBhIGJpdCBvZGQgdG8ganVzdGlmeSB0aGUgaW1wbGVt
ZW50YXRpb24gYmFzZWQgb24geDg2LiBDYW4gd2Ugc2ltcGx5IGF2b2lkIHRvIG1lbnRpb24geDg2
Pw0KDQpZZXMgSSB3aWxsIHJlbW92ZSB0aGUgeDg2IHBhcnQgb2YgaXQuDQoNCkNoZWVycw0KQmVy
dHJhbmQNCg0KPiANCj4+ICsjZGVmaW5lIGhhc192cGNpKGQpIGV2YWx1YXRlX25vc3BlYygoZCkt
Pm9wdGlvbnMgJiBYRU5fRE9NQ1RMX0NERl92cGNpKQ0KPj4gICAgI2VuZGlmIC8qIF9fQVNNX0RP
TUFJTl9IX18gKi8NCj4+ICBkaWZmIC0tZ2l0IGEveGVuL2luY2x1ZGUvYXNtLXg4Ni9wY2kuaCBi
L3hlbi9pbmNsdWRlL2FzbS14ODYvcGNpLmgNCj4+IGluZGV4IGUwNzY5NTEwMzIuLmM0YTRmZGNi
YzIgMTAwNjQ0DQo+PiAtLS0gYS94ZW4vaW5jbHVkZS9hc20teDg2L3BjaS5oDQo+PiArKysgYi94
ZW4vaW5jbHVkZS9hc20teDg2L3BjaS5oDQo+PiBAQCAtNiw4ICs2LDYgQEANCj4+ICAjZGVmaW5l
IENGOF9BRERSX0hJKGNmOCkgKCAgKChjZjgpICYgMHgwZjAwMDAwMCkgPj4gMTYpDQo+PiAgI2Rl
ZmluZSBDRjhfRU5BQkxFRChjZjgpICghISgoY2Y4KSAmIDB4ODAwMDAwMDApKQ0KPj4gIC0jZGVm
aW5lIE1NQ0ZHX0JERihhZGRyKSAgKCAoKGFkZHIpICYgMHgwZmZmZjAwMCkgPj4gMTIpDQo+PiAt
DQo+PiAgI2RlZmluZSBJU19TTkJfR0ZYKGlkKSAoaWQgPT0gMHgwMTA2ODA4NiB8fCBpZCA9PSAw
eDAxMTY4MDg2IFwNCj4+ICAgICAgICAgICAgICAgICAgICAgICAgICB8fCBpZCA9PSAweDAxMjY4
MDg2IHx8IGlkID09IDB4MDEwMjgwODYgXA0KPj4gICAgICAgICAgICAgICAgICAgICAgICAgIHx8
IGlkID09IDB4MDExMjgwODYgfHwgaWQgPT0gMHgwMTIyODA4NiBcDQo+PiBkaWZmIC0tZ2l0IGEv
eGVuL2luY2x1ZGUvcHVibGljL2FyY2gtYXJtLmggYi94ZW4vaW5jbHVkZS9wdWJsaWMvYXJjaC1h
cm0uaA0KPj4gaW5kZXggZDQ2YzYxZmNhOS4uNDRiZTMzN2RlYyAxMDA2NDQNCj4+IC0tLSBhL3hl
bi9pbmNsdWRlL3B1YmxpYy9hcmNoLWFybS5oDQo+PiArKysgYi94ZW4vaW5jbHVkZS9wdWJsaWMv
YXJjaC1hcm0uaA0KPj4gQEAgLTQxOCw2ICs0MTgsMTMgQEAgdHlwZWRlZiB1aW50NjRfdCB4ZW5f
Y2FsbGJhY2tfdDsNCj4+ICAjZGVmaW5lIEdVRVNUX0dJQ1YzX0dJQ1IwX0JBU0UgICAgIHhlbl9t
a191bGxvbmcoMHgwMzAyMDAwMCkgLyogdkNQVTAuLjEyNyAqLw0KPj4gICNkZWZpbmUgR1VFU1Rf
R0lDVjNfR0lDUjBfU0laRSAgICAgeGVuX21rX3VsbG9uZygweDAxMDAwMDAwKQ0KPj4gICsvKg0K
Pj4gKyAqIDI1NiBNQiBpcyByZXNlcnZlZCBmb3IgVlBDSSBjb25maWd1cmF0aW9uIHNwYWNlIGJh
c2VkIG9uIGNhbGN1bGF0aW9uDQo+PiArICogMjU2IGJ1c2VzIMOXIDMyIGRldmljZXMgw5cgOCBm
dW5jdGlvbnMgw5cgNCBLQiA9IDI1NiBNQg0KPj4gKyAqLw0KPj4gKyNkZWZpbmUgR1VFU1RfVlBD
SV9FQ0FNX0JBU0UgICAgeGVuX21rX3VsbG9uZygweDEwMDAwMDAwKQ0KPj4gKyNkZWZpbmUgR1VF
U1RfVlBDSV9FQ0FNX1NJWkUgICAgeGVuX21rX3VsbG9uZygweDEwMDAwMDAwKQ0KPj4gKw0KPj4g
IC8qIEFDUEkgdGFibGVzIHBoeXNpY2FsIGFkZHJlc3MgKi8NCj4+ICAjZGVmaW5lIEdVRVNUX0FD
UElfQkFTRSB4ZW5fbWtfdWxsb25nKDB4MjAwMDAwMDApDQo+PiAgI2RlZmluZSBHVUVTVF9BQ1BJ
X1NJWkUgeGVuX21rX3VsbG9uZygweDAyMDAwMDAwKQ0KPj4gZGlmZiAtLWdpdCBhL3hlbi9pbmNs
dWRlL3hlbi9wY2kuaCBiL3hlbi9pbmNsdWRlL3hlbi9wY2kuaA0KPj4gaW5kZXggNzBhYzI1MzQ1
Yy4uNDNiOGEwODE3MCAxMDA2NDQNCj4+IC0tLSBhL3hlbi9pbmNsdWRlL3hlbi9wY2kuaA0KPj4g
KysrIGIveGVuL2luY2x1ZGUveGVuL3BjaS5oDQo+PiBAQCAtNDAsNiArNDAsOCBAQA0KPj4gICNk
ZWZpbmUgUENJX1NCREYzKHMsYixkZikgXA0KPj4gICAgICAoKHBjaV9zYmRmX3QpeyAuc2JkZiA9
ICgoKHMpICYgMHhmZmZmKSA8PCAxNikgfCBQQ0lfQkRGMihiLCBkZikgfSkNCj4+ICArI2RlZmlu
ZSBNTUNGR19CREYoYWRkcikgICgoKGFkZHIpICYgMHgwZmZmZjAwMCkgPj4gMTIpDQo+PiArDQo+
PiAgdHlwZWRlZiB1bmlvbiB7DQo+PiAgICAgIHVpbnQzMl90IHNiZGY7DQo+PiAgICAgIHN0cnVj
dCB7DQo+IA0KPiBDaGVlcnMsDQo+IA0KPiAtLSANCj4gSnVsaWVuIEdyYWxsDQoNCg==


From xen-devel-bounces@lists.xenproject.org Tue Oct 12 14:42:25 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 14:42:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.207318.363102 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maIyz-0005Fq-F6; Tue, 12 Oct 2021 14:42:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 207318.363102; Tue, 12 Oct 2021 14:42:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maIyz-0005Fj-C3; Tue, 12 Oct 2021 14:42:21 +0000
Received: by outflank-mailman (input) for mailman id 207318;
 Tue, 12 Oct 2021 14:42:20 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1maIyy-0005FZ-B3; Tue, 12 Oct 2021 14:42:20 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1maIyy-0002zd-7A; Tue, 12 Oct 2021 14:42:20 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1maIyx-0008Lh-UR; Tue, 12 Oct 2021 14:42:20 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1maIyx-0007K1-Ty; Tue, 12 Oct 2021 14:42:19 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=lk+0YB/VDJMjpjpKDbdk+zovGovYHmFbyyWnj2hSG4E=; b=W+knjy3P4Gp7+HvvnKMmJs9dMY
	EaBzha9vPb7D3YZxypcmqPX75gUOrTNKtcz4Dk7Atz3te3ubMvp7BEmH1ls4nMzKtJx40lWPqwyaa
	crX0xkJST7jgK4LL+jI1ku79UGOUbxR9/knDIGCCANZfno9ycbDj2HkSb5yHwF7XHddA=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165474-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 165474: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=ba4ae92234b1985a89b3abed221d825b8d9ef9e2
X-Osstest-Versions-That:
    ovmf=19ee56c4b33faa33078894a6c8495c81c660b8be
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 12 Oct 2021 14:42:19 +0000

flight 165474 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165474/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 ba4ae92234b1985a89b3abed221d825b8d9ef9e2
baseline version:
 ovmf                 19ee56c4b33faa33078894a6c8495c81c660b8be

Last test of basis   165462  2021-10-11 06:10:05 Z    1 days
Testing same since   165474  2021-10-12 06:12:32 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Star Zeng <star.zeng@intel.com>
  Zeng, Star <star.zeng@intel.com>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   19ee56c4b3..ba4ae92234  ba4ae92234b1985a89b3abed221d825b8d9ef9e2 -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Tue Oct 12 14:52:43 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 14:52:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.207329.363116 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maJ8w-0006mg-HV; Tue, 12 Oct 2021 14:52:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 207329.363116; Tue, 12 Oct 2021 14:52:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maJ8w-0006mZ-EY; Tue, 12 Oct 2021 14:52:38 +0000
Received: by outflank-mailman (input) for mailman id 207329;
 Tue, 12 Oct 2021 14:52:36 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <ijackson@chiark.greenend.org.uk>) id 1maJ8u-0006mT-RH
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 14:52:36 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <ijackson@chiark.greenend.org.uk>) id 1maJ8u-0003A3-Mz
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 14:52:36 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <ijackson@chiark.greenend.org.uk>) id 1maJ8u-0001Ed-Kr
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 14:52:36 +0000
Received: from [172.18.45.5] (helo=zealot.relativity.greenend.org.uk)
 by mariner.uk.xensource.com with esmtp (Exim 4.89)
 (envelope-from <ijackson@chiark.greenend.org.uk>)
 id 1maJ8s-0004av-01; Tue, 12 Oct 2021 15:52:34 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:
	Message-Id:Date:Subject:Cc:To:From;
	bh=tsz77/5xeZhmnHGluoTZbMqWy0a4RfWmz+SZOgkwhG4=; b=zYYU+D0FUUhZmnVepmpzbKoQfg
	ewMm48HKPGHWBAL/GUpeJgJ1e/bsO1qVJjBa5C1Ts+OzIwYvwX2IXayKm5obnMV5o8xCeZ4ASNR+t
	cNhk6tUN+3yxBJrQK25xzaWBWcPCGnrPKIUUCSbEGoZxr4FzY/Y7azl5cLiBixoTcsyc=;
From: Ian Jackson <iwj@xenproject.org>
To: xen-devel@lists.xenproject.org
Cc: iwj@xenproject.org,
	Wei Liu <wl@xen.org>,
	Anthony PERARD <anthony.perard@citrix.com>,
	Juergen Gross <jgross@suse.com>
Subject: [PATCH] libxl: CODING_STYLE: Explicitly deprecate #ifdef
Date: Tue, 12 Oct 2021 15:52:26 +0100
Message-Id: <20211012145226.6065-1-iwj@xenproject.org>
X-Mailer: git-send-email 2.20.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

We don't use ifdefs in the main code.  Actually document this.

Signed-off-by: Ian Jackson <iwj@xenproject.org>
---
 tools/libs/light/CODING_STYLE | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/tools/libs/light/CODING_STYLE b/tools/libs/light/CODING_STYLE
index 3d572f6925..c2342c9d3b 100644
--- a/tools/libs/light/CODING_STYLE
+++ b/tools/libs/light/CODING_STYLE
@@ -121,6 +121,16 @@ permitted exceptions to the usual libxl code formatting rules.
 
 
 
+ARCHITECTURE-SPECIFIC CODE, CONDITIONAL COMPILATION
+---------------------------------------------------
+
+Architecture-specific code should be isolated in libxl_<arch>.c,
+with a function call interface, whereever possible.
+
+#ifdefs should be avoided, and in any case not interspersed through
+the primary functional code.
+
+
 IDEMPOTENT DATA STRUCTURE CONSTRUCTION/DESTRUCTION
 --------------------------------------------------
 
-- 
2.20.1



From xen-devel-bounces@lists.xenproject.org Tue Oct 12 14:54:08 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 14:54:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.207335.363127 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maJAN-0007N3-Sj; Tue, 12 Oct 2021 14:54:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 207335.363127; Tue, 12 Oct 2021 14:54:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maJAN-0007Mw-PP; Tue, 12 Oct 2021 14:54:07 +0000
Received: by outflank-mailman (input) for mailman id 207335;
 Tue, 12 Oct 2021 14:54:06 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1maJAM-0007Mo-HE
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 14:54:06 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1maJAM-0003Bt-GM
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 14:54:06 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1maJAM-0001Lw-FY
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 14:54:06 +0000
Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89)
 (envelope-from <iwj@xenproject.org>)
 id 1maJAE-0004bW-83; Tue, 12 Oct 2021 15:53:58 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date
	:Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From;
	bh=dH8iJq3o9Yhes/6IkPftbdJ8pqK8LeeD6+3zVFruVYI=; b=TArYzDXflXlGGgUOUbXZC262nF
	busPQrUrukmAi3Qib1rLChmzUa1hVh1Jr1MB34AEUYlRJ7bEc6vPAInHqic2pHjJe90LMJ7mdO4wB
	kYQkeVTmdWnL2JHDBaw3imyguiVLLq8CBB16cbQ+Ye2Y+GXdsRY9lUhwpfn64UrD79Q8=;
From: Ian Jackson <iwj@xenproject.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <24933.41349.893363.203683@mariner.uk.xensource.com>
Date: Tue, 12 Oct 2021 15:53:57 +0100
To: Bertrand Marquis <Bertrand.Marquis@arm.com>
Cc: Jan Beulich <jbeulich@suse.com>,
    Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>,
    Rahul Singh <Rahul.Singh@arm.com>,
    "xen-devel\@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
    Andre Przywara <Andre.Przywara@arm.com>,
    Ian Jackson <iwj@xenproject.org>,
    Wei Liu <wl@xen.org>,
    Juergen Gross <jgross@suse.com>,
    Stefano Stabellini <sstabellini@kernel.org>,
    Roger Pau =?iso-8859-1?Q?Monn=E9?= <roger.pau@citrix.com>
Subject: Re: [PATCH v5 01/11] xen/arm: xc_domain_ioport_permission(..) not
 supported on ARM.
Newsgroups: chiark.mail.xen.devel
In-Reply-To: <69A83587-B7E0-4653-AF8C-AEE802922CE5@arm.com>
References: <cover.1633540842.git.rahul.singh@arm.com>
	<d292392268df2c74c4103a82ef917072643407a8.1633540842.git.rahul.singh@arm.com>
	<YWQkblfNMYEs6jI9@MacBook-Air-de-Roger.local>
	<77CF7FA5-C566-469E-B4A8-0400789890BB@arm.com>
	<YWQ6Nk3Jk+BqgkwZ@MacBook-Air-de-Roger.local>
	<53AE6E2A-01D7-41EC-9B2C-C0D596EB8D4D@arm.com>
	<YWRCxXGQIyTOAepC@MacBook-Air-de-Roger.local>
	<FEF0B03A-5AC8-4F8D-B821-191AC2EF8295@arm.com>
	<ac6d4785-ac9a-4491-26bb-c66ffe82c55b@suse.com>
	<ED8FC92F-B5EF-4473-B4A9-641C7D44859F@arm.com>
	<0744b957-1832-dff2-9ae2-b8e8534f501b@suse.com>
	<c3952fd5-b893-4cb6-a9bc-325a89e859db@epam.com>
	<c125b447-53e8-7d13-3b08-af62fd3a9140@suse.com>
	<c6b6c22f-fb8a-f2d9-7735-f1ebc9809908@epam.com>
	<09656882-b297-7144-c291-1ee997edb119@suse.com>
	<69A83587-B7E0-4653-AF8C-AEE802922CE5@arm.com>
X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu)

Bertrand Marquis writes ("Re: [PATCH v5 01/11] xen/arm: xc_domain_ioport_permission(..) not supported on ARM."):
> So there is no comment remaining on this patch ?

I have been following this thread.  I think I have a notion of why
this is needed but I'm not 100% clear on it.  The commit message says
this:

> ARM architecture does not implement I/O ports. Ignore this call on ARM
> to avoid the overhead of making a hypercall just for Xen to return
> -ENOSYS.

which implies it's a performance improvement.  But the change also
suppresses an error return, so this commit message is false.  I think
that the thread has concluded something different, but it should be
explained in the commit message.  The purpose of a commit message is
precisely to capture the kind of considerations and discussion that
occurred in this thread.

If the overall outcome implied by this patch is correct (as I *think*
the thread has concluded) then I don't think the #ifdefery is
appropriate.  This should be done with a new arch-specific function in
libxl_x86.c and libxl_arm.c.  I'm not sure precisely what that
function should be called, but maybe something like
  libxl_ioports_supported
?

I see that the fact that we avoid #ifdefs wasn't documented in
CODING_STYLE, so I have sent a patch to add that.  Sorry about that.

Thanks,
Ian.


From xen-devel-bounces@lists.xenproject.org Tue Oct 12 15:03:45 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 15:03:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.207345.363137 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maJJb-0000RD-QA; Tue, 12 Oct 2021 15:03:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 207345.363137; Tue, 12 Oct 2021 15:03:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maJJb-0000R6-NK; Tue, 12 Oct 2021 15:03:39 +0000
Received: by outflank-mailman (input) for mailman id 207345;
 Tue, 12 Oct 2021 15:03:38 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1maJJa-0000R0-1Y
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 15:03:38 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1maJJZ-0003O0-Vx
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 15:03:37 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1maJJZ-0002VP-Uq
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 15:03:37 +0000
Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89)
 (envelope-from <iwj@xenproject.org>)
 id 1maJJW-0004eJ-Ir; Tue, 12 Oct 2021 16:03:34 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date
	:Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From;
	bh=FOYoEW8KI7o4uzQlqUDJZjWTqq3iruwDf0kf/sUVJRw=; b=UuEQirFJ8k3Q5ZR5n2ne+qz5/C
	bzjd0xLE92nDIHRMwdZtl4Juk8tnKkJVDJzwgAxnXuFkvgERn+bog2FPVLXN8hfunUxP2v0ZagTvE
	R4JiwX/ABWJGyHxYGnW2brjI3z6TQ0yF6yRixfH1kxq6o5M9GxD+4LWpSNZ+tgOASSOY=;
From: Ian Jackson <iwj@xenproject.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <24933.41926.168289.698356@mariner.uk.xensource.com>
Date: Tue, 12 Oct 2021 16:03:34 +0100
To: Rahul Singh <rahul.singh@arm.com>
Cc: xen-devel@lists.xenproject.org,
    bertrand.marquis@arm.com,
    Andre.Przywara@arm.com,
    Wei Liu <wl@xen.org>,
    Anthony PERARD <anthony.perard@citrix.com>,
    Juergen Gross <jgross@suse.com>,
    Stefano Stabellini <sstabellini@kernel.org>,
    Julien Grall <julien@xen.org>,
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH v5 10/11] arm/libxl: Emulated PCI device tree node in libxl
Newsgroups: chiark.mail.xen.devel
In-Reply-To: <b81b5dea800c8fe47071f3dbd20588b1e472fb99.1633540842.git.rahul.singh@arm.com>
References: <cover.1633540842.git.rahul.singh@arm.com>
	<b81b5dea800c8fe47071f3dbd20588b1e472fb99.1633540842.git.rahul.singh@arm.com>
X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu)

Rahul Singh writes ("[PATCH v5 10/11] arm/libxl: Emulated PCI device tree node in libxl"):
> libxl will create an emulated PCI device tree node in the device tree to
> enable the guest OS to discover the virtual PCI during guest boot.
> Emulated PCI device tree node will only be created when there is any
> device assigned to guest.
> 
> A new area has been reserved in the arm guest physical map at
> which the VPCI bus is declared in the device tree (reg and ranges
> parameters of the node).

I think this series is targeted for 4.16.  Stefano drew this patch to
my attention.  I have read the thread on this patch and it is not
clear to me that it has converged.  Code freeze is imminent.

Is there some way I can help here ?

Ian.


From xen-devel-bounces@lists.xenproject.org Tue Oct 12 15:04:24 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 15:04:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.207350.363149 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maJKK-0000yy-3c; Tue, 12 Oct 2021 15:04:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 207350.363149; Tue, 12 Oct 2021 15:04:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maJKK-0000yr-0B; Tue, 12 Oct 2021 15:04:24 +0000
Received: by outflank-mailman (input) for mailman id 207350;
 Tue, 12 Oct 2021 15:04:23 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1maJKI-0000yh-V9
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 15:04:22 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1maJKD-0003Ox-Aa; Tue, 12 Oct 2021 15:04:17 +0000
Received: from 54-240-197-233.amazon.com ([54.240.197.233] helo=[192.168.23.5])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1maJKD-0002bB-3y; Tue, 12 Oct 2021 15:04:17 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=1GR2CwjD3R7VzwxcFot31PWBrMQJpsn3Stq843ni6pQ=; b=gDa8Q2AL6pyTKTKZMB79cYzKGR
	M7CnFPnOtF0F1hJnTWkV8c64AXp8DtU3iv09O/3DXGK0Ce6z2ongguu2Msh/8OAfvrI9FXKAxSXiC
	009qYjRxLpos6eEbmn5Ly3ruVQ2UvmOlxROM5a3cBqNSkUJbkh39MiM4+Qs9K30uT/HQ=;
Message-ID: <2b0670e9-b442-047c-9479-daa97d6329f6@xen.org>
Date: Tue, 12 Oct 2021 16:04:14 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.2.0
Subject: Re: [PATCH v5 08/11] xen/arm: Enable the existing x86 virtual PCI
 support for ARM.
To: Bertrand Marquis <Bertrand.Marquis@arm.com>,
 Jan Beulich <jbeulich@suse.com>
Cc: Rahul Singh <Rahul.Singh@arm.com>, Andre Przywara
 <Andre.Przywara@arm.com>, Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Wei Liu <wl@xen.org>, Paul Durrant <paul@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <cover.1633540842.git.rahul.singh@arm.com>
 <9bdca2cda5d2e83f94dc2423e55714273539760a.1633540842.git.rahul.singh@arm.com>
 <6752f2d3-171b-37f5-c809-82995a8f3f36@suse.com>
 <CEF7FFB0-779A-4F46-8667-6BCD9BA5CB6C@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <CEF7FFB0-779A-4F46-8667-6BCD9BA5CB6C@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 11/10/2021 13:41, Bertrand Marquis wrote:
> Hi Jan,

Hi Bertrand,

> As Rahul is on leave, I will answer you and make the changes needed.
> 
>> On 7 Oct 2021, at 14:43, Jan Beulich <jbeulich@suse.com> wrote:
>> Independent of this - is bare metal Arm enforcing this same
>> alignment restriction (unconditionally)? Iirc on x86 we felt we'd
>> better synthesize misaligned accesses.
> 
> Unaligned IO access could be synthesise also on arm to but I would
> rather not make such a change now without testing it (and there is
> also a question of it making sense).

Yes it makes sense. I actually have an item in my TODO list to forbid 
unaligned access because they should not happen on any device we 
currently emulate.

Although, I am not aware of any issue other than the guest would shoot 
itself in the foot if this happens.

> 
> So if it is ok with you I will keep that check and discuss it with Rahul
> when he is back. I will add a comment in the code to make that clear.

I am OK with it.

[...]

>> Throughout this series I haven't been able to spot where the HAS_VPCI
>> Kconfig symbol would get selected. Hence I cannot tell whether all of
>> this is Arm64-specific. Otherwise I wonder whether size 8 actually
>> can occur on Arm32.
> 
> Dabt.size could be 3 even on ARM32 but we should not allow 64bit
> access on mmio regions on arm32.

Hmmm... Looking at the Armv7 and Armv8 spec, ldrd/strd (64-bit read) 
would not present a valid ISV. So I think it is not be possible to have 
dabt.size = 3 for 32-bit domain. But I agree we probably want to harden 
the code.

> 
> So I will surround this code with ifdef CONFIG_ARM_64 and add a test
> for len > 4 to prevent this case on 32bit.
> 
> To be completely right we should disable this also for 32bit guests but
> this change would be a bit more invasive.

I think the following should be sufficient:

if ( is_domain_32bit_domain() && len > 4 )
   return ...;

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Tue Oct 12 15:04:31 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 15:04:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.207351.363160 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maJKR-0001IR-Cm; Tue, 12 Oct 2021 15:04:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 207351.363160; Tue, 12 Oct 2021 15:04:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maJKR-0001IJ-96; Tue, 12 Oct 2021 15:04:31 +0000
Received: by outflank-mailman (input) for mailman id 207351;
 Tue, 12 Oct 2021 15:04:30 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Tock=PA=citrix.com=anthony.perard@srs-us1.protection.inumbo.net>)
 id 1maJKQ-0001Hx-IT
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 15:04:30 +0000
Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id b23ae07f-2b6d-11ec-8135-12813bfff9fa;
 Tue, 12 Oct 2021 15:04:29 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b23ae07f-2b6d-11ec-8135-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1634051069;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=AhaWvrsNw4MxXGdVWPcK2ihNuq8/77IISBWZXWc5DLY=;
  b=c3x8IntEPlPSe+3McbZfMf1ipPS34FYJ1TGkLX5w8U4GUOAncwmHutFP
   f6jtskuzA7Q0nW60X2w3B8KGb7htkXEjnsesztnpEClyLFr7yrl34nf2M
   SE2dIowKMWJd2khRoCy2pqTJKZFIaNdQd+VP5XD3csZOmXvxBjJr66Zx6
   I=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: OuRgQDMzgJy/ub8hNyUZm9KJCEgKY1w+oyVWRSbbZlDqB093nVL0c4WxP77HRnTXHZRJQtlHiI
 B1Nj9uVb2+HYmkuxFLaOy1nxZ5h1t+mqbFpYrClRUvNX1ylqNMqdxES3pIHl9LOzLe7ey3392L
 A3ujECqNFn4c5J9bcLoo2um0uTTv/DmsULNzvClq8G9cfd8jr+7Y7lnYy/OXVtsStrnnsrbwVn
 cmfA/L9G2c9Pgj1HupIwgCxPE5bXUrHqVcVTet4PIuUyGlpPLL9EuafwY+Sp+YHp6lGr7GQMgR
 HqWp+0awIdsQMexm10DblFrL
X-SBRS: 5.1
X-MesageID: 55395209
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:26jMqqykVN5aGP9BwUl6t+fSwSrEfRIJ4+MujC+fZmUNrF6WrkVRx
 jcaWWmDMq2IZzT2fN92O4my80IFvp/Vz4BgTgdv+SAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx
 59DAjUVBJlsFhcwnvopW1TYhSEUOZugH9IQM8aZfHAsLeNYYH1500s6w7dj2tcAbeWRWGthh
 /uj+6UzB3f9s9JEGjp8B3Wr8U4HUFza4Vv0j3RmDRx5lAa2e0o9VfrzEZqZPXrgKrS4K8bhL
 wr1IBNVyUuCl/slIovNfr8W6STmSJaKVeSFoiI+t6RPHnGuD8H9u0o2HKN0VKtZt9mGt/9x8
 dJcqsShdV0SB6mVktUNTCtBTj4raMWq+JefSZS+mcmazkmAeHrw2fR+SkoxOOX0+M4uXzsIr
 6ZBbmlQMFbT3Ipaw5riIgVors0lMMnsOpJZonx6xCvVJf0nXYrCU+PB4towMDIY250VTKuEP
 5txhTxHXAT/fhZCZnAsUY8QsKSGpkanWhNkkQfAzUYwyzeKl1EguFT3C/LKfvSaSMMTmVyXz
 krE8H7+GQoyL8GExHyO9XfEru7QnwvrVYQKDrq6+/V2xlqJyQQ7GBAQEFe2v/S9okq/QM5Eb
 VwZ/DI0qqo//1DtScPyNyBUu1bd4ERaAYAJVbRntkfdkcI4/jp1GEArTgdGecN+pfNsfgUuj
 1W4j8zbHGFw5ej9pW2myp+Yqja7OC4wJGAEZDMZQQZt3+QPsL3fnTqUEY49SP/dYsndXGiqm
 WjT/XdWa6A71JZTj82GEUb7byVAT3QjZjU+4RnLRSqb5wd9aZ/Ni2eAuAWDs6gowGp0SDC8U
 Jk4dyq2sL5m4XKlznXlrAAx8FeBvajt3Nr02w8HInXZ327xk0NPhKgJiN2EGG9nM9wfZRjia
 1LJtAVa6fd7ZSXxNv4oPNLhVZp3kcAM8OgJsNiOMLKihbArJWe6ENxGPxbMjwgBbmB9+U3AB
 XtrWZn1VitLYUiW5DG3W/0cwdcWKtMWngvuqWTA503/i9K2PSfNIZ9caQfmRr1pvcus/VSOm
 /4CZpTi9vmqeLCnCsUh2dVIdg5iwLlSLc2elvG7gcbaelA4Rzp7V6OIqV7jEqQ895loei7z1
 inVcidlJJDX3CKXQelTQnw8Or7pQ7hlqnc3YX4lMVqygiBxaoez9qYPMZAweOB/puBkyPd1S
 dgDetmBXasTGmiWpWxFYMmvtpFmeTSqmRmKY3ivbg8gcsMyXAfO4NLlIFfirXFcEiqtuMIii
 LS8zQeHE4EbTgFvAZ+OOvKixl+8p1YHn+d2UxeaK9VfYhy0ooNrNzbwnrk8JMRVcUfPwT6T1
 gC3BxYEpLaS/99poYeR3a3d9tWnCepzGEZeDlL317fuOHmI5HenzK9BTP2MIWLXWlTr9fjwf
 u5S1fz9bqEKxQ4Yr4pmHr935qsi/N+z9aRCxwFpEXiXPVSmDrRsfiuP0cVV7/Afw7ZYvU29W
 16V+8kcMrKMYZu3HFkULQsjT+KCyfBLxWWCsaVreB33tH1t4b6KcUROJB3d2iVSIYx8PJ4h3
 ep86tUd7Bayi0ZyP9uL5syOG79g8pDUv30bi6wn
IronPort-HdrOrdr: A9a23:ThauEqv/RJPa+3J86J8r55ah7skDdNV00zEX/kB9WHVpmszxra
 GTddAgpHjJYVcqKRUdcL+7VJVoLUmyyXcx2/h2AV7AZniChILLFvAA0WKK+VSJcEeSygce79
 YDT0EXMqyIMbEQt6bHCWeDfeod/A==
X-IronPort-AV: E=Sophos;i="5.85,367,1624334400"; 
   d="scan'208";a="55395209"
Date: Tue, 12 Oct 2021 16:02:52 +0100
From: Anthony PERARD <anthony.perard@citrix.com>
To: Ian Jackson <iwj@xenproject.org>
CC: <xen-devel@lists.xenproject.org>, Wei Liu <wl@xen.org>, Juergen Gross
	<jgross@suse.com>
Subject: Re: [PATCH] libxl: CODING_STYLE: Explicitly deprecate #ifdef
Message-ID: <YWWjnAhkMGbct5Ii@perard>
References: <20211012145226.6065-1-iwj@xenproject.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20211012145226.6065-1-iwj@xenproject.org>

On Tue, Oct 12, 2021 at 03:52:26PM +0100, Ian Jackson wrote:
> We don't use ifdefs in the main code.  Actually document this.
> 
> Signed-off-by: Ian Jackson <iwj@xenproject.org>
> ---
>  tools/libs/light/CODING_STYLE | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/tools/libs/light/CODING_STYLE b/tools/libs/light/CODING_STYLE
> index 3d572f6925..c2342c9d3b 100644
> --- a/tools/libs/light/CODING_STYLE
> +++ b/tools/libs/light/CODING_STYLE
> @@ -121,6 +121,16 @@ permitted exceptions to the usual libxl code formatting rules.
>  
>  
>  
> +ARCHITECTURE-SPECIFIC CODE, CONDITIONAL COMPILATION
> +---------------------------------------------------
> +
> +Architecture-specific code should be isolated in libxl_<arch>.c,
> +with a function call interface, whereever possible.

s/whereever/wherever/ ?

> +
> +#ifdefs should be avoided, and in any case not interspersed through
> +the primary functional code.
> +
> +
>  IDEMPOTENT DATA STRUCTURE CONSTRUCTION/DESTRUCTION
>  --------------------------------------------------
>  

Sounds good,

Acked-by: Anthony PERARD <anthony.perard@citrix.com>

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Tue Oct 12 15:06:22 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 15:06:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.207365.363170 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maJMD-0002GY-Nn; Tue, 12 Oct 2021 15:06:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 207365.363170; Tue, 12 Oct 2021 15:06:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maJMD-0002GR-KZ; Tue, 12 Oct 2021 15:06:21 +0000
Received: by outflank-mailman (input) for mailman id 207365;
 Tue, 12 Oct 2021 15:06:20 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=xSmm=PA=suse.com=jgross@srs-us1.protection.inumbo.net>)
 id 1maJMC-0002GE-JA
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 15:06:20 +0000
Received: from smtp-out1.suse.de (unknown [195.135.220.28])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id f422bd68-2b6d-11ec-8135-12813bfff9fa;
 Tue, 12 Oct 2021 15:06:19 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id A7AEF221D6;
 Tue, 12 Oct 2021 15:06:18 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 8934D13BC9;
 Tue, 12 Oct 2021 15:06:18 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id FXs2IGqkZWFcGgAAMHmgww
 (envelope-from <jgross@suse.com>); Tue, 12 Oct 2021 15:06:18 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f422bd68-2b6d-11ec-8135-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1634051178; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=WMxhSYupztKi9rD+1XObXmitRKUVGq8bAY1DFsaoj1o=;
	b=Ir6in8OLBEhYHyYr11Tq5SzqwCToHwqO8HxwhrSX1SmZ6D4H5B7GYTw1aBL44mMpMAeuIB
	fY1QHioGsArbqyOylnhzTN4vWHCGS6izwFSKeXfqTkOpV7QeX0W77LbsqiCGaRZcjP6W39
	mjc04cMPnMmnkOtvN7qUj5Y1rOvRnz8=
Subject: Re: [PATCH] libxl: CODING_STYLE: Explicitly deprecate #ifdef
To: Ian Jackson <iwj@xenproject.org>, xen-devel@lists.xenproject.org
Cc: Wei Liu <wl@xen.org>, Anthony PERARD <anthony.perard@citrix.com>
References: <20211012145226.6065-1-iwj@xenproject.org>
From: Juergen Gross <jgross@suse.com>
Message-ID: <2d9bcfc7-e7a4-1612-92e5-f584c45894fd@suse.com>
Date: Tue, 12 Oct 2021 17:06:17 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <20211012145226.6065-1-iwj@xenproject.org>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="4NPmeL2sbW78jZVKxHgC2noX2ZNi6FEMG"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--4NPmeL2sbW78jZVKxHgC2noX2ZNi6FEMG
Content-Type: multipart/mixed; boundary="W32msaRBmOyby3avahR3ryycSyB19EDMf";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Ian Jackson <iwj@xenproject.org>, xen-devel@lists.xenproject.org
Cc: Wei Liu <wl@xen.org>, Anthony PERARD <anthony.perard@citrix.com>
Message-ID: <2d9bcfc7-e7a4-1612-92e5-f584c45894fd@suse.com>
Subject: Re: [PATCH] libxl: CODING_STYLE: Explicitly deprecate #ifdef
References: <20211012145226.6065-1-iwj@xenproject.org>
In-Reply-To: <20211012145226.6065-1-iwj@xenproject.org>

--W32msaRBmOyby3avahR3ryycSyB19EDMf
Content-Type: multipart/mixed;
 boundary="------------43E667B491D8174687AEA2B9"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------43E667B491D8174687AEA2B9
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 12.10.21 16:52, Ian Jackson wrote:
> We don't use ifdefs in the main code.  Actually document this.
>=20
> Signed-off-by: Ian Jackson <iwj@xenproject.org>

Reviewed-by: Juergen Gross <jgross@suse.com>


Juergen

--------------43E667B491D8174687AEA2B9
Content-Type: application/pgp-keys;
 name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Transfer-Encoding: quoted-printable
Content-Description: OpenPGP public key
Content-Disposition: attachment;
 filename="OpenPGP_0xB0DE9DD628BF132F.asc"

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy=
cWx
w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O=
f8Z
d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y=
9bf
IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq=
G7/
377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR=
3Jv
c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA=
QIe
AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT=
hpw
dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0=
MbD
1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv=
oPH
Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v=
5QL
+qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ=
2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC=
QoL
BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr=
Wf0
teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC=
/nu
AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh=
ITT
d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm=
XBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz=
80h
SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC=
AcD
AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn=
FOX
gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1=
jnD
kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0=
N51
N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l=
otu
fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1=
tqS
EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA=
hsD
BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3=
g3O
ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5=
dM7
wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5=
D+j
LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm=
V2x
AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N=
Eaw
QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW=
nHI
s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR=
wgn
BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV=
bVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk=
pEd
IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA=
QAB
wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw=
Tbe
8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1=
vJz
Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8=
VGi
wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW=
svi
uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX=
zXs
ZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------43E667B491D8174687AEA2B9--

--W32msaRBmOyby3avahR3ryycSyB19EDMf--

--4NPmeL2sbW78jZVKxHgC2noX2ZNi6FEMG
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmFlpGoFAwAAAAAACgkQsN6d1ii/Ey8u
wAgAlc1FbAMzjqhYI+Ap4+Y3lc/mV/yJxcONkE7tfA5iYM+0UcEpTXk2uEFmKsqGPXzs3T7qt6vg
zgFqR7v2S8zvU4AjeRD/B5HpjR/IZrtwuuhAvsE297bAxIYHtX2KYI+sfUowJ6L7rSvFcWIueHnF
+CxumO4/9jyLl51G2QMdd8G3qQbACTKn7c2/+n8PPHxSbtkHDQQT+Zf8Rg+hVgEEN7uhfAB320j5
FslWXfKziSUNEAqRVa8S4nJEye/rvVILS28FH3hXmUCdMrx7UH4mKi1Uun9xGT7jW/xegPAWNKah
ONs03Lnc6K20pNTadTQhAJhJp9nC2pINilq2k94R6Q==
=dviq
-----END PGP SIGNATURE-----

--4NPmeL2sbW78jZVKxHgC2noX2ZNi6FEMG--


From xen-devel-bounces@lists.xenproject.org Tue Oct 12 15:12:02 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 15:12:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.207377.363181 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maJRU-0003jP-FO; Tue, 12 Oct 2021 15:11:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 207377.363181; Tue, 12 Oct 2021 15:11:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maJRU-0003jI-CS; Tue, 12 Oct 2021 15:11:48 +0000
Received: by outflank-mailman (input) for mailman id 207377;
 Tue, 12 Oct 2021 15:11:47 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1maJRT-0003jC-06
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 15:11:47 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1maJRS-0003ZK-UY
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 15:11:46 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1maJRS-0003Nc-Ta
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 15:11:46 +0000
Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89)
 (envelope-from <iwj@xenproject.org>)
 id 1maJRN-0004hC-IT; Tue, 12 Oct 2021 16:11:41 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date
	:Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From;
	bh=OJI774lIs/2GfmpiDFKJPlNU3bksOf/OlkxlAnheqq8=; b=lx2BW0EPJ/Kn+NuYWozm9KgaW2
	dtseHZcsMhzoFWEp1bv2GHyMiOFT0hcKYgiaP76JBBF9PU3HtensiOSUs+PulEC7BIHUDg6Qh2aLe
	nf8yMBsjhJ+LB64I6cFMuz+FZgahJc+cjCGRl5hRri/kLo6MpVFRlMLXEQi3l4HrdpWI=;
From: Ian Jackson <iwj@xenproject.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <24933.42413.176126.124248@mariner.uk.xensource.com>
Date: Tue, 12 Oct 2021 16:11:41 +0100
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: Oleksandr Tyshchenko <olekstysh@gmail.com>,
    xen-devel@lists.xenproject.org,
    Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
    Wei Liu <wl@xen.org>,
    Anthony PERARD <anthony.perard@citrix.com>,
    Juergen Gross <jgross@suse.com>,
    Julien Grall <julien@xen.org>,
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH V6 2/2] libxl/arm: Add handling of extended regions for
 DomU
Newsgroups: chiark.mail.xen.devel
In-Reply-To: <alpine.DEB.2.21.2110111300030.25528@sstabellini-ThinkPad-T480s>
References: <1633974539-7380-1-git-send-email-olekstysh@gmail.com>
	<1633974539-7380-3-git-send-email-olekstysh@gmail.com>
	<alpine.DEB.2.21.2110111300030.25528@sstabellini-ThinkPad-T480s>
X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu)

Stefano Stabellini writes ("Re: [PATCH V6 2/2] libxl/arm: Add handling of extended regions for DomU"):
> On Mon, 11 Oct 2021, Oleksandr Tyshchenko wrote:
> > From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> > 
> > The extended region (safe range) is a region of guest physical
> > address space which is unused and could be safely used to create
> > grant/foreign mappings instead of wasting real RAM pages from
> > the domain memory for establishing these mappings.
> > 
> > The extended regions are chosen at the domain creation time and
> > advertised to it via "reg" property under hypervisor node in
> > the guest device-tree. As region 0 is reserved for grant table
> > space (always present), the indexes for extended regions are 1...N.
> > If extended regions could not be allocated for some reason,
> > Xen doesn't fail and behaves as usual, so only inserts region 0.
> > 
> > Please note the following limitations:
> > - The extended region feature is only supported for 64-bit domain
> >   currently.
> > - The ACPI case is not covered.
> > 
> > ***
> > 
> > The algorithm to choose extended regions for non-direct mapped
> > DomU is simpler in comparison with the algorithm for direct mapped
> > Dom0. We usually have a lot of unused space above 4GB, and might
> > have some unused space below 4GB (depends on guest memory size).
> > Try to allocate separate 2MB-aligned extended regions from the first
> > (below 4GB) and second (above 4GB) RAM banks taking into the account
> > the maximum supported guest physical address space size and the amount
> > of memory assigned to the guest. The minimum size of extended region
> > the same as for Dom0 (64MB).
> > 
> > Suggested-by: Julien Grall <jgrall@amazon.com>
> > Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> 
> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>

On the basis of that and the diffstat:

Acked-by: Ian Jackson <iwj@xenproject.org>


From xen-devel-bounces@lists.xenproject.org Tue Oct 12 15:16:02 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 15:16:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.207384.363193 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maJVY-0004Na-28; Tue, 12 Oct 2021 15:16:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 207384.363193; Tue, 12 Oct 2021 15:16:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maJVX-0004NT-UQ; Tue, 12 Oct 2021 15:15:59 +0000
Received: by outflank-mailman (input) for mailman id 207384;
 Tue, 12 Oct 2021 15:15:59 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1maJVX-0004NN-HZ
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 15:15:59 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1maJVX-0003d0-Gm
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 15:15:59 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1maJVX-0003f1-Fv
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 15:15:59 +0000
Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89)
 (envelope-from <iwj@xenproject.org>)
 id 1maJVT-0004iL-Qt; Tue, 12 Oct 2021 16:15:55 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date
	:Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From;
	bh=gpnKHEwhE36/gKdPrnfxsCdAsb/wChRC4J3Zp7caD2Q=; b=rKAppI7GxS0sV3q7a3nd0phffp
	kg5MArs/lNDhSJMaZ+QPJRo/yv7DhmB/wWGPNFtVjpebR8SImKjdwewqkVAYkC8iX9bp9wCVfTeD2
	YwSO2TQr2m/XD+8Y1IVbdBEd8sA4Bx5cJfADlEZo5CeKMOeYm9mx71wUlzRY4AVNhHyQ=;
From: Ian Jackson <iwj@xenproject.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <24933.42667.311553.565032@mariner.uk.xensource.com>
Date: Tue, 12 Oct 2021 16:15:55 +0100
To: Oleksandr Tyshchenko <olekstysh@gmail.com>
Cc: xen-devel@lists.xenproject.org,
    Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
    Ian Jackson <iwj@xenproject.org>,
    Wei Liu <wl@xen.org>,
    Anthony PERARD <anthony.perard@citrix.com>,
    Andrew Cooper <andrew.cooper3@citrix.com>,
    George Dunlap <george.dunlap@citrix.com>,
    Jan Beulich <jbeulich@suse.com>,
    Julien Grall <julien@xen.org>,
    Stefano Stabellini <sstabellini@kernel.org>,
    Juergen Gross <jgross@suse.com>,
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
    Roger Pau =?iso-8859-1?Q?Monn=E9?= <roger.pau@citrix.com>
Subject: Re: [PATCH V6 1/2] xen/arm: Introduce gpaddr_bits field to struct xen_domctl_getdomaininfo
Newsgroups: chiark.mail.xen.devel
In-Reply-To: <1633974539-7380-2-git-send-email-olekstysh@gmail.com>
References: <1633974539-7380-1-git-send-email-olekstysh@gmail.com>
	<1633974539-7380-2-git-send-email-olekstysh@gmail.com>
X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu)

Oleksandr Tyshchenko writes ("[PATCH V6 1/2] xen/arm: Introduce gpaddr_bits field to struct xen_domctl_getdomaininfo"):
> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> 
> We need to pass info about maximum supported guest physical
> address space size to the toolstack on Arm in order to properly
> calculate the base and size of the extended region (safe range)
> for the guest. The extended region is unused address space which
> could be safely used by domain for foreign/grant mappings on Arm.
> The extended region itself will be handled by the subsequent
> patch.

You say "to the toolstack", but you are exposing this information up
to callers of libxl.  Do you mean some higher-layer toolstack that
uses libxl ?  What does it use this information for ?

FTAOD I am not opposed to exposing this in this way; indeed it seems
likely to be useful.  I just want to fully understand before I give
this my tools ack.

> +        info->gpaddr_bits = domctl.u.getdomaininfo.gpaddr_bits;

I'm pleased to find that this is not arch-specific.

Thanks,
Ian.


From xen-devel-bounces@lists.xenproject.org Tue Oct 12 15:17:18 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 15:17:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.207390.363204 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maJWl-0004xv-CL; Tue, 12 Oct 2021 15:17:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 207390.363204; Tue, 12 Oct 2021 15:17:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maJWl-0004xo-89; Tue, 12 Oct 2021 15:17:15 +0000
Received: by outflank-mailman (input) for mailman id 207390;
 Tue, 12 Oct 2021 15:17:14 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1maJWk-0004xd-0r; Tue, 12 Oct 2021 15:17:14 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1maJWj-0003gS-SZ; Tue, 12 Oct 2021 15:17:13 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1maJWj-0001cJ-HY; Tue, 12 Oct 2021 15:17:13 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1maJWj-0005DP-H5; Tue, 12 Oct 2021 15:17:13 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=1AvM5Z3T5x+nsMN0mcjsU/ETP6E0FgrXjCYE6A+E+pU=; b=DkCUXMZB0Pc4Bf90UzWj12hKZB
	Ggi2uYvJGND+/7jeizOoa+7di9UIPlhxDPnvp+kHKKZUnA3lQxZ0tt6SljamHqF7j6EGbljCwXEEz
	obGJxMNCBdlypnS61FyEYTZxhB6ba+QwAnJOu41ptJv4eC7ZEDTtY1/At6i7+JK+ank8=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165470-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 165470: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-armhf-armhf-examine:reboot:fail:heisenbug
    linux-linus:test-amd64-amd64-pygrub:guest-start/debian.repeat:fail:heisenbug
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=fa5878760579a9feaa1de3bb2396cd23beb439ca
X-Osstest-Versions-That:
    linux=64570fbc14f8d7cb3fe3995f20e26bc25ce4b2cc
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 12 Oct 2021 15:17:13 +0000

flight 165470 linux-linus real [real]
flight 165478 linux-linus real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/165470/
http://logs.test-lab.xenproject.org/osstest/logs/165478/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-armhf-armhf-examine      8 reboot              fail pass in 165478-retest
 test-amd64-amd64-pygrub 21 guest-start/debian.repeat fail pass in 165478-retest

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 165459
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 165459
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165459
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165459
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 165459
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165459
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 165459
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 165459
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 linux                fa5878760579a9feaa1de3bb2396cd23beb439ca
baseline version:
 linux                64570fbc14f8d7cb3fe3995f20e26bc25ce4b2cc

Last test of basis   165459  2021-10-11 01:11:38 Z    1 days
Testing same since   165470  2021-10-12 00:40:45 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Arnd Bergmann <arnd@arndb.de>
  ArthurChiao <arthurchiao@hotmail.com>
  ArthurChiao <sjtuyananzhao@gmail.com>
  Brendan Higgins <brendanhiggins@google.com>
  Chunguang Xu <brookxu@tencent.com>
  Daniel Latypov <dlatypov@google.com>
  David Gow <davidgow@google.com>
  David Sterba <dsterba@suse.com>
  Fabio Estevam <festevam@denx.de>
  Filipe Manana <fdmanana@suse.com>
  Johan Hovold <johan@kernel.org>
  Jonathan Cameron <Jonathan.Cameron@huawei.com>
  Josef Bacik <josef@toxicpanda.com>
  Kees Cook <keescook@chromium.org>
  Linus Torvalds <torvalds@linux-foundation.org>
  Mika Westerberg <mika.westerberg@linux.intel.com>
  Qu Wenruo <wqu@suse.com>
  Rolf Eike Beer <eb@emlix.com>
  Shuah Khan <skhan@linuxfoundation.org>
  Tejun Heo <tj@kernel.org>
  Waiman Long <longman@redhat.com>
  Xin Tan <tanxin.ctf@gmail.com>
  Xiyu Yang <xiyuyang19@fudan.edu.cn>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     fail    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      fail    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   64570fbc14f8d..fa5878760579a  fa5878760579a9feaa1de3bb2396cd23beb439ca -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Tue Oct 12 15:18:09 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 15:18:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.207398.363217 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maJXd-0005ZC-O4; Tue, 12 Oct 2021 15:18:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 207398.363217; Tue, 12 Oct 2021 15:18:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maJXd-0005Z5-LB; Tue, 12 Oct 2021 15:18:09 +0000
Received: by outflank-mailman (input) for mailman id 207398;
 Tue, 12 Oct 2021 15:18:08 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=5yXa=PA=oderland.se=josef@srs-us1.protection.inumbo.net>)
 id 1maJXc-0005Yx-HH
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 15:18:08 +0000
Received: from office.oderland.com (unknown [91.201.60.5])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 993a42e9-2b6f-11ec-8138-12813bfff9fa;
 Tue, 12 Oct 2021 15:18:06 +0000 (UTC)
Received: from [193.180.18.161] (port=38880 helo=[10.137.0.14])
 by office.oderland.com with esmtpsa (TLS1.2) tls
 TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2)
 (envelope-from <josef@oderland.se>)
 id 1maJXZ-005qGI-W8; Tue, 12 Oct 2021 17:18:06 +0200
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 993a42e9-2b6f-11ec-8138-12813bfff9fa
Message-ID: <29bb9284-668a-8ccf-7727-1e1f0857a0ed@oderland.se>
Date: Tue, 12 Oct 2021 17:17:50 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:93.0) Gecko/20100101
 Thunderbird/93.0
Subject: Re: [REGRESSION][BISECTED] 5.15-rc1: Broken AHCI on NVIDIA ION
 (MCP79)
Content-Language: en-US
From: Josef Johansson <josef@oderland.se>
To: Jason Andryuk <jandryuk@gmail.com>
Cc: Thomas Gleixner <tglx@linutronix.de>, maz@kernel.org,
 linux-pci@vger.kernel.org, open list <linux-kernel@vger.kernel.org>,
 xen-devel <xen-devel@lists.xenproject.org>
References: <CALjTZvbzYfBuLB+H=fj2J+9=DxjQ2Uqcy0if_PvmJ-nU-qEgkg@mail.gmail.com>
 <b023adf9-e21c-59ac-de49-57915c8cede8@oderland.se>
 <c9218eb4-9fc1-28f4-d053-895bab0473d4@oderland.se>
 <ef163327-f965-09f8-4396-2c1c4e689a6d@oderland.se>
 <CAKf6xpvGyCKVHsvauP54=0j10fxis4XiiqBNWH+1cpkbtt_QJw@mail.gmail.com>
 <fdfb6267-e467-4785-b4a0-00859f6dc161@oderland.se>
In-Reply-To: <fdfb6267-e467-4785-b4a0-00859f6dc161@oderland.se>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-AntiAbuse: This header was added to track abuse, please include it with any abuse report
X-AntiAbuse: Primary Hostname - office.oderland.com
X-AntiAbuse: Original Domain - lists.xenproject.org
X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12]
X-AntiAbuse: Sender Address Domain - oderland.se
X-Get-Message-Sender-Via: office.oderland.com: authenticated_id: josjoh@oderland.se
X-Authenticated-Sender: office.oderland.com: josjoh@oderland.se

On 10/12/21 15:33, Josef Johansson wrote:
> On 10/12/21 15:07, Jason Andryuk wrote:
>> On Tue, Oct 12, 2021 at 2:09 AM Josef Johansson <josef@oderland.se> wrote:
>>> On 10/11/21 21:34, Josef Johansson wrote:
>>>> On 10/11/21 20:47, Josef Johansson wrote:
>>>>> More can be read over at freedesktop:
>>>>> https://gitlab.freedesktop.org/drm/amd/-/issues/1715
>> Hi, Josef,
>>
>> If you compare
>> commit fcacdfbef5a1633211ebfac1b669a7739f5b553e "PCI/MSI: Provide a
>> new set of mask and unmask functions"
>> and
>> commit 446a98b19fd6da97a1fb148abb1766ad89c9b767 "PCI/MSI: Use new
>> mask/unmask functions" some of the replacement functions in 446198b1
>> no longer exit early for the pci_msi_ignore_mask flag.
>>
>> Josef, I'd recommend you try adding pci_msi_ignore_mask checks to the
>> new functions in fcacdfbef5a to see if that helps.
>>
>> There was already a pci_msi_ignore_mask fixup in commit
>> 1a519dc7a73c977547d8b5108d98c6e769c89f4b "PCI/MSI: Skip masking MSI-X
>> on Xen PV" though the kernel was crashing in that case.
>>
>> Regards,
>> Jason
> Hi Jason,
>
> Makes sense. I am compiling now, will try it as soon as it's done.
>
> diff --git a/drivers/pci/msi.c b/drivers/pci/msi.c
> index 0099a00af361..620928fd0065 100644
> --- a/drivers/pci/msi.c
> +++ b/drivers/pci/msi.c
> @@ -148,6 +148,9 @@ static noinline void pci_msi_update_mask(struct
> msi_desc *desc, u32 clear, u32 s
>      raw_spinlock_t *lock = &desc->dev->msi_lock;
>      unsigned long flags;
>  
> +    if (pci_msi_ignore_mask)
> +        return;
> +
>      raw_spin_lock_irqsave(lock, flags);
>      desc->msi_mask &= ~clear;
>      desc->msi_mask |= set;
> @@ -179,6 +182,9 @@ static inline void __iomem
> *pci_msix_desc_addr(struct msi_desc *desc)
>   */
>  static void pci_msix_write_vector_ctrl(struct msi_desc *desc, u32 ctrl)
>  {
> +    if (pci_msi_ignore_mask)
> +        return;
> +
>      void __iomem *desc_addr = pci_msix_desc_addr(desc);
>  
>      writel(ctrl, desc_addr + PCI_MSIX_ENTRY_VECTOR_CTRL);
> @@ -186,6 +192,9 @@ static void pci_msix_write_vector_ctrl(struct
> msi_desc *desc, u32 ctrl)
>  
>  static inline void pci_msix_mask(struct msi_desc *desc)
>  {
> +    if (pci_msi_ignore_mask)
> +        return;
> +
>      desc->msix_ctrl |= PCI_MSIX_ENTRY_CTRL_MASKBIT;
>      pci_msix_write_vector_ctrl(desc, desc->msix_ctrl);
>      /* Flush write to device */
> @@ -194,6 +203,9 @@ static inline void pci_msix_mask(struct msi_desc *desc)
>  
>  static inline void pci_msix_unmask(struct msi_desc *desc)
>  {
> +    if (pci_msi_ignore_mask)
> +        return;
> +
>      desc->msix_ctrl &= ~PCI_MSIX_ENTRY_CTRL_MASKBIT;
>      pci_msix_write_vector_ctrl(desc, desc->msix_ctrl);
>  }
>
I love open source. It just works. Was my patch correct btw?

Thanks Jason!

Regards

- Josef



From xen-devel-bounces@lists.xenproject.org Tue Oct 12 15:18:42 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 15:18:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.207405.363228 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maJYA-0006CT-42; Tue, 12 Oct 2021 15:18:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 207405.363228; Tue, 12 Oct 2021 15:18:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maJYA-0006CM-19; Tue, 12 Oct 2021 15:18:42 +0000
Received: by outflank-mailman (input) for mailman id 207405;
 Tue, 12 Oct 2021 15:18:40 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1maJY8-0006C7-SS
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 15:18:40 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1maJY8-0003iQ-Qu
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 15:18:40 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1maJY8-0003sW-QC
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 15:18:40 +0000
Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89)
 (envelope-from <iwj@xenproject.org>)
 id 1maJXv-0004kS-Mi; Tue, 12 Oct 2021 16:18:27 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date
	:Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From;
	bh=52yBbdeSVNUZprStrJdPNpVSMMkaWEU8qRv/AMi4fcc=; b=axZYLh1LVARBTGpK714CWKpI9k
	J1JkLSmxXEPwgXzlVNG8/a+cWv5GSny+8DrAkuV63hcPBbHDQcw6fWXbu54vMcO1D9FHNL/URKLNA
	DgwKbJNfkxWchSsFD6tvLtMConfdWf1KUCvAzWmo+6MFsQijOVc4fvHQVLn3rrUL/DT8=;
From: Ian Jackson <iwj@xenproject.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <24933.42819.375910.803748@mariner.uk.xensource.com>
Date: Tue, 12 Oct 2021 16:18:27 +0100
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: wl@xen.org,
    jgross@suse.com,
    iwj@xenproject.org,
    anthony.perard@citrix.com,
    Rahul.Singh@arm.com,
    Bertrand.Marquis@arm.com,
    xen-devel@lists.xenproject.org,
    michal.orzel@arm.com,
    Oleksandr Andrushchenko <andr2000@gmail.com>,
    roger.pau@citrix.com,
    Oleksandr Tyshchenko <olekstysh@gmail.com>
Subject: Re: ARM series with tools patches for 4.16
In-Reply-To: <alpine.DEB.2.21.2110081605340.25528@sstabellini-ThinkPad-T480s>
References: <alpine.DEB.2.21.2110081605340.25528@sstabellini-ThinkPad-T480s>
X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu)

Stefano Stabellini writes ("ARM series with tools patches for 4.16"):
> I am writing this email as a summary of the outstanding ARM series
> targeting 4.16 that we are aiming to complete by Oct 15.

Thanks.  This is really helpful.

> There has been a lot of traffic on the mailing list and in a few
> occasions there has been 1 or 2 tools patches embedded in larger ARM
> series. Easy to miss. For your convenience and help with tracking I
> thought it would be useful to list the tools and libxl patches from the
> various series that currently need an ack.

I looked at these:

> - PCI devices passthrough on Arm by Rahul
>   https://marc.info/?l=xen-devel&m=163354201102377
>   Status:
>       - patch #1   missing a tools ack
>       - patch #10  missing a libxl ack
>       - patch #9   missing a vpci (Roger) ack
>       - other patches no action needed from tools (either already
>         committed, acked, or almost there)

#1 I think needs work on the commit message and a slight code change
but ought to be doable.  #9 has been committed AIUI.  I think #10 is
having trouble - I replied to it.  I'm happy to help with this if I
could see the wood for the trees...

> - PCI devices passthrough on Arm, part 2 by OleksandrA
>   https://marc.info/?l=xen-devel&m=163367250003118
>   Status:
>       - patch #6, #7  missing a libxl ack
>       - other patches no action needed from tools (either already
>         committed, acked, or almost there)

These now acked I think ?

> - Add handling of extended regions (safe ranges) on Arm by OleksandrT
>   https://marc.info/?l=xen-devel&m=163351932517019
>   Status:
>       - patch #1  missing a libxl ack (but also xen side not finished)
>       - patch #2  missing a libxl ack (Ian is aware)
>       - patch #3  no action needed from tools (committed)

I have acked one of these and asked an easy question of the other.

> - Expose PMU to the guests by Michal
>   https://marc.info/?l=xen-devel&m=163368116008406
>   Status:
>       - patch #1, #3  missing a tools and libxl ack
>       - patch #2      no action needed from tools (acked)

These now acked I think ?

Ian.


From xen-devel-bounces@lists.xenproject.org Tue Oct 12 15:22:55 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 15:22:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.207417.363239 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maJcB-0007eI-Kt; Tue, 12 Oct 2021 15:22:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 207417.363239; Tue, 12 Oct 2021 15:22:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maJcB-0007eB-Hl; Tue, 12 Oct 2021 15:22:51 +0000
Received: by outflank-mailman (input) for mailman id 207417;
 Tue, 12 Oct 2021 15:22:50 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=P4MT=PA=gmail.com=olekstysh@srs-us1.protection.inumbo.net>)
 id 1maJcA-0007e2-1P
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 15:22:50 +0000
Received: from mail-lf1-x135.google.com (unknown [2a00:1450:4864:20::135])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 51189108-88eb-4a6b-ac44-ae0b12c6c4d7;
 Tue, 12 Oct 2021 15:22:48 +0000 (UTC)
Received: by mail-lf1-x135.google.com with SMTP id y15so89241219lfk.7
 for <xen-devel@lists.xenproject.org>; Tue, 12 Oct 2021 08:22:48 -0700 (PDT)
Received: from [192.168.1.7] ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id p28sm527189lfo.71.2021.10.12.08.22.46
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Tue, 12 Oct 2021 08:22:47 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 51189108-88eb-4a6b-ac44-ae0b12c6c4d7
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:from:to:cc:references:message-id:date:user-agent
         :mime-version:in-reply-to:content-transfer-encoding:content-language;
        bh=hf2FXdcY4s9X1KBXkqZ5Xi2KBuIbpX3oPckN48EfHcA=;
        b=OQJyn1STCvk1Oh3mt/vSwtb31fN+UOa2GuC2ClFJCrx+BUAy1J91IfML9EeNgTONLc
         m0a0IerZnLcPwFo8UEGsOfybnhc1RhUwGFCJ/eUsfOih7TmA8F7DWrfmau4La1ygZKA3
         z/RZ77RvD7Ht/MrOXqFruXanMEx+HIKSRiM8Gz8wk+KW9KCmul5rz8UTrUvKeP+0UHMh
         Y2rnN/FR7fisYCaWhBWMzdaP90/NgNEnFl0G5+OIs4qJ6g+4vEq3LeA3aLDWP++SSnDH
         NPQ2hlrPTfn6f/T/vx+oTXZf02r4I2Di5tzB5qRjajl7bCGHRRxIf6LsUWZ6DcrJXyfC
         tN+A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:from:to:cc:references:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding
         :content-language;
        bh=hf2FXdcY4s9X1KBXkqZ5Xi2KBuIbpX3oPckN48EfHcA=;
        b=rv5XoIyo7mfrel/ztVfNSC++Mn4gJbdUD2CvjimM7RBgJHHB+9tW08Wkb9NQZqCdQT
         tS2xhXpaAMAO11rzk2ChZIvH1E0lArnwEh5AWcL/QHV+QgWXiH73vpz/74DIh03cyn4e
         CPUwUabDi33T8j7PN8mjoS3L7tYILzi85M0DDJeNVHGQLfuRWGkfX9XMuJGrdE9Y1gCz
         j2ER6EXunHjaAmniW+Wqm0oSt4NZZZmNO8r+PUJybYu+VgN4Hww5CouU2oc4a7ITq/z6
         Ff7BIxE6JL1Y+Ahg41dp8EHxG2SNQmPdhbiSUcBubxgOmFxZte2jhV+bO3CMZtmUACun
         gkig==
X-Gm-Message-State: AOAM5315KjRo0iD1GOX4hbkkyfkXj0OvpWpZnkk1KSyyzjcgBFRoU5bo
	kpcAAz42m7xIey2007KS5Bk=
X-Google-Smtp-Source: ABdhPJz2/Ti1298+rt7ijsjieji4H5vFh6d1KY4M1PtEXVszO5emQtBk1sbhPN9yau08dYvuJqbpPA==
X-Received: by 2002:a05:6512:3b21:: with SMTP id f33mr6809453lfv.88.1634052167324;
        Tue, 12 Oct 2021 08:22:47 -0700 (PDT)
Subject: Re: [PATCH V6 2/2] libxl/arm: Add handling of extended regions for
 DomU
From: Oleksandr <olekstysh@gmail.com>
To: Ian Jackson <iwj@xenproject.org>,
 Stefano Stabellini <sstabellini@kernel.org>
Cc: xen-devel@lists.xenproject.org,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, Wei Liu <wl@xen.org>,
 Anthony PERARD <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>,
 Julien Grall <julien@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <1633974539-7380-1-git-send-email-olekstysh@gmail.com>
 <1633974539-7380-3-git-send-email-olekstysh@gmail.com>
Message-ID: <37b38f3c-ffc6-b808-13a3-525dcac07d4e@gmail.com>
Date: Tue, 12 Oct 2021 18:22:46 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <1633974539-7380-3-git-send-email-olekstysh@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US


On 11.10.21 20:48, Oleksandr Tyshchenko wrote:

Hi Ian, Stefano

> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>
> The extended region (safe range) is a region of guest physical
> address space which is unused and could be safely used to create
> grant/foreign mappings instead of wasting real RAM pages from
> the domain memory for establishing these mappings.
>
> The extended regions are chosen at the domain creation time and
> advertised to it via "reg" property under hypervisor node in
> the guest device-tree. As region 0 is reserved for grant table
> space (always present), the indexes for extended regions are 1...N.
> If extended regions could not be allocated for some reason,
> Xen doesn't fail and behaves as usual, so only inserts region 0.
>
> Please note the following limitations:
> - The extended region feature is only supported for 64-bit domain
>    currently.
> - The ACPI case is not covered.
>
> ***
>
> The algorithm to choose extended regions for non-direct mapped
> DomU is simpler in comparison with the algorithm for direct mapped
> Dom0. We usually have a lot of unused space above 4GB, and might
> have some unused space below 4GB (depends on guest memory size).
> Try to allocate separate 2MB-aligned extended regions from the first
> (below 4GB) and second (above 4GB) RAM banks taking into the account
> the maximum supported guest physical address space size and the amount
> of memory assigned to the guest. The minimum size of extended region
> the same as for Dom0 (64MB).
>
> Suggested-by: Julien Grall <jgrall@amazon.com>
> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> ---
> Changes RFC -> V2:
>     - update patch description
>     - drop uneeded "extended-region" DT property
>     - clear reg array in finalise_ext_region() and add a TODO
>
> Changes V2 -> V3:
>     - update patch description, comments in code
>     - only pick up regions with size >= 64MB
>     - move the region calculation to make_hypervisor_node() and drop
>       finalise_ext_region()
>     - extend the list of arguments for make_hypervisor_node()
>     - do not show warning for 32-bit domain
>     - change the region alignment from 1GB to 2MB
>     - move EXT_REGION_SIZE to public/arch-arm.h
>
> Changes V3 -> V4:
>     - add R-b, A-b and T-b
>
> Changes V4 -> V5:
>     - update patch description and comments in code
>     - reflect changes done in previous patch to pass gpaddr_bits
>       via createdomain domctl (struct xen_arch_domainconfig)
>     - drop R-b, A-b and T-b
>     - drop limit for maximum extended region size (128GB)
>     - try to also allocate region below 4GB, optimize code
>       for calculating extended regions
>
> Change V5 -> V6:
>     - reflect changes done in previous patch to pass gpaddr_bits
>       via getdomaininfo domctl (struct xen_domctl_getdomaininfo)
>     - reduce the number of local variables, rework calculations
> ---
>   tools/libs/light/libxl_arm.c  | 76 ++++++++++++++++++++++++++++++++++++++++---
>   xen/include/public/arch-arm.h |  2 ++
>   2 files changed, 73 insertions(+), 5 deletions(-)
>
> diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c
> index e3140a6..c0e8415 100644
> --- a/tools/libs/light/libxl_arm.c
> +++ b/tools/libs/light/libxl_arm.c
> @@ -598,9 +598,20 @@ static int make_timer_node(libxl__gc *gc, void *fdt,
>       return 0;
>   }
>   
> +#define ALIGN_UP_TO_2MB(x)   (((x) + MB(2) - 1) & (~(MB(2) - 1)))
> +
>   static int make_hypervisor_node(libxl__gc *gc, void *fdt,
> -                                const libxl_version_info *vers)
> +                                const libxl_version_info *vers,
> +                                const libxl_domain_build_info *b_info,
> +                                const struct xc_dom_image *dom)
>   {
> +    uint64_t region_size[GUEST_RAM_BANKS] = {0}, region_base[GUEST_RAM_BANKS],
> +        bank1end, ramsize;
> +    uint32_t regs[(GUEST_ROOT_ADDRESS_CELLS + GUEST_ROOT_SIZE_CELLS) *
> +                  (GUEST_RAM_BANKS + 1)];
> +    be32 *cells = &regs[0];
> +    unsigned int i, len, nr_regions = 0;
> +    libxl_dominfo info;
>       int res;
>       gic_interrupt intr;
>   
> @@ -615,9 +626,64 @@ static int make_hypervisor_node(libxl__gc *gc, void *fdt,
>                                 "xen,xen");
>       if (res) return res;
>   
> -    /* reg 0 is grant table space */
> -    res = fdt_property_regs(gc, fdt, GUEST_ROOT_ADDRESS_CELLS, GUEST_ROOT_SIZE_CELLS,
> -                            1,GUEST_GNTTAB_BASE, GUEST_GNTTAB_SIZE);
> +    if (strcmp(dom->guest_type, "xen-3.0-aarch64")) {
> +        LOG(WARN, "The extended regions are only supported for 64-bit guest currently");
> +        goto out;
> +    }
> +
> +    res = libxl_domain_info(CTX, &info, dom->guest_domid);
> +    if (res) return res;
> +
> +    assert(info.gpaddr_bits >= 32 && info.gpaddr_bits <= 48);
> +
> +    /*
> +     * Try to allocate separate 2MB-aligned extended regions from the first
> +     * (below 4GB) and second (above 4GB) RAM banks taking into the account
> +     * the maximum supported guest physical address space size and the amount
> +     * of memory assigned to the guest.
> +     * As the guest memory layout is not populated yet we cannot rely on
> +     * dom->rambank_size[], so calculate the actual size of both banks using
> +     * "max_memkb" value.
> +     */
> +    ramsize = b_info->max_memkb * 1024;
> +    if (ramsize <= GUEST_RAM0_SIZE) {
> +        region_base[0] = GUEST_RAM0_BASE + ALIGN_UP_TO_2MB(ramsize);
> +        region_size[0] = GUEST_RAM0_SIZE - ALIGN_UP_TO_2MB(ramsize);
> +        region_base[1] = GUEST_RAM1_BASE;
> +    } else
> +        region_base[1] = GUEST_RAM1_BASE +
> +            ALIGN_UP_TO_2MB(ramsize - GUEST_RAM0_SIZE);
> +
> +    bank1end = min(1ULL << info.gpaddr_bits, GUEST_RAM1_BASE + GUEST_RAM1_SIZE);
> +    if (bank1end > region_base[1])
> +        region_size[1] = bank1end - region_base[1];
> +
> +out:
> +    /*
> +     * The region 0 for grant table space must be always present. If we managed
> +     * to allocate the extended regions then insert them as regions 1...N.
> +     */
> +    set_range(&cells, GUEST_ROOT_ADDRESS_CELLS, GUEST_ROOT_SIZE_CELLS,
> +              GUEST_GNTTAB_BASE, GUEST_GNTTAB_SIZE);
> +
> +    for (i = 0; i < GUEST_RAM_BANKS; i++) {
> +        if (region_size[i] < GUEST_EXT_REGION_MIN_SIZE)
> +            continue;
> +
> +        LOG(DEBUG, "Extended region %u: %#"PRIx64"->%#"PRIx64"\n",

If this appears to be the last version, may I please ask to remove 
unneeded "\n" in the message above while committing? Thank you.


> +            nr_regions, region_base[i], region_base[i] + region_size[i]);
> +
> +        set_range(&cells, GUEST_ROOT_ADDRESS_CELLS, GUEST_ROOT_SIZE_CELLS,
> +                  region_base[i], region_size[i]);
> +        nr_regions++;
> +    }
> +
> +    if (!nr_regions)
> +        LOG(WARN, "The extended regions cannot be allocated, not enough space");
> +
> +    len = sizeof(regs[0]) * (GUEST_ROOT_ADDRESS_CELLS + GUEST_ROOT_SIZE_CELLS) *
> +        (nr_regions + 1);
> +    res = fdt_property(fdt, "reg", regs, len);
>       if (res) return res;
>   
>       /*
> @@ -963,7 +1029,7 @@ next_resize:
>           }
>   
>           FDT( make_timer_node(gc, fdt, ainfo, state->clock_frequency) );
> -        FDT( make_hypervisor_node(gc, fdt, vers) );
> +        FDT( make_hypervisor_node(gc, fdt, vers, info, dom) );
>   
>           if (info->arch_arm.vuart == LIBXL_VUART_TYPE_SBSA_UART)
>               FDT( make_vpl011_uart_node(gc, fdt, ainfo, dom) );
> diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h
> index d46c61f..19ca2b0 100644
> --- a/xen/include/public/arch-arm.h
> +++ b/xen/include/public/arch-arm.h
> @@ -451,6 +451,8 @@ typedef uint64_t xen_callback_t;
>   #define GUEST_RAM_BANK_BASES   { GUEST_RAM0_BASE, GUEST_RAM1_BASE }
>   #define GUEST_RAM_BANK_SIZES   { GUEST_RAM0_SIZE, GUEST_RAM1_SIZE }
>   
> +#define GUEST_EXT_REGION_MIN_SIZE   xen_mk_ullong(0x0004000000) /* 64MB */
> +
>   /* Current supported guest VCPUs */
>   #define GUEST_MAX_VCPUS 128
>   

-- 
Regards,

Oleksandr Tyshchenko



From xen-devel-bounces@lists.xenproject.org Tue Oct 12 15:29:46 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 15:29:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.207424.363251 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maJim-0008KT-D1; Tue, 12 Oct 2021 15:29:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 207424.363251; Tue, 12 Oct 2021 15:29:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maJim-0008KM-9l; Tue, 12 Oct 2021 15:29:40 +0000
Received: by outflank-mailman (input) for mailman id 207424;
 Tue, 12 Oct 2021 15:29:39 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1maJil-0008KG-QN
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 15:29:39 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1maJij-0003uN-8y; Tue, 12 Oct 2021 15:29:37 +0000
Received: from 54-240-197-233.amazon.com ([54.240.197.233] helo=[192.168.23.5])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1maJij-0004nT-1T; Tue, 12 Oct 2021 15:29:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=IjAhp0dFSE8b+kiMEZL+8ezRp6o/hqrmmc3w/wiHa90=; b=eRdjqS0KM1j7fJifTRlkg8l+JS
	Z+mPLlTqUC8nh4DE9hbSOysq2+OkGANMNEECHb1X4UygE17aFmaRUGpc/bHESQ2Dzqfl6UcKtvsDY
	S7Ze2obDGnreqlhmFKg3eS1lFNn12LWUOnDWJOVWzqSrXZ39ZA+YSPSvd+zMPcnQwg1Y=;
Message-ID: <3ab28da6-162a-8449-5c25-3b72f6414567@xen.org>
Date: Tue, 12 Oct 2021 16:29:33 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.2.0
Subject: Re: [PATCH v4 3/3] xen: Expose the PMU to the guests
To: Bertrand Marquis <Bertrand.Marquis@arm.com>
Cc: Michal Orzel <Michal.Orzel@arm.com>,
 Xen-devel <xen-devel@lists.xenproject.org>, Ian Jackson
 <iwj@xenproject.org>, Wei Liu <wl@xen.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Nick Rosbrook <rosbrookn@ainfosec.com>,
 Anthony PERARD <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>,
 Christian Lindig <christian.lindig@citrix.com>, David Scott
 <dave@recoil.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <20211011090047.8878-1-michal.orzel@arm.com>
 <20211011090047.8878-4-michal.orzel@arm.com>
 <a91ddbf4-d1bc-40b5-b971-35dbcdc4d8a3@xen.org>
 <A79191BC-6B58-4438-9CF9-551A2A7F9FF7@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <A79191BC-6B58-4438-9CF9-551A2A7F9FF7@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi Bertrand,

On 11/10/2021 15:11, Bertrand Marquis wrote:
>> On 11/10/2021 10:00, Michal Orzel wrote:
>>> Add parameter vpmu to xl domain configuration syntax
>>> to enable the access to PMU registers by disabling
>>> the PMU traps(currently only for ARM).
>>> The current status is that the PMU registers are not
>>> virtualized and the physical registers are directly
>>> accessible when this parameter is enabled. There is no
>>> interrupt support and Xen will not save/restore the
>>> register values on context switches.
>>> Please note that this feature is experimental.
>>> Signed-off-by: Michal Orzel <michal.orzel@arm.com>
>>> Signed-off-by: Julien Grall <julien@xen.org>
>>> Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>
>>> ---
>>> Changes since v3:
>>> -fail if vpmu is set but not supported
>>> -rebase on top of latest staging
>>> Changes since v2:
>>> -remove redundant check from x86 code
>>> -do not define bit position and mask separately
>>> Changes since v1:
>>> -modify vpmu parameter to be common rather than arch specific
>>> ---
>>>   docs/man/xl.cfg.5.pod.in             | 17 +++++++++++++++++
>>>   tools/golang/xenlight/helpers.gen.go |  6 ++++++
>>>   tools/golang/xenlight/types.gen.go   |  1 +
>>>   tools/include/libxl.h                |  6 ++++++
>>>   tools/libs/light/libxl_create.c      | 10 ++++++++++
>>>   tools/libs/light/libxl_types.idl     |  2 ++
>>>   tools/ocaml/libs/xc/xenctrl.ml       |  1 +
>>>   tools/ocaml/libs/xc/xenctrl.mli      |  1 +
>>>   tools/xl/xl_parse.c                  |  2 ++
>>>   xen/arch/arm/domain.c                | 12 +++++++++---
>>>   xen/arch/arm/setup.c                 |  1 +
>>>   xen/common/domain.c                  | 10 +++++++++-
>>>   xen/include/asm-arm/domain.h         |  1 +
>>>   xen/include/public/domctl.h          |  4 +++-
>>>   14 files changed, 69 insertions(+), 5 deletions(-)
>>> diff --git a/docs/man/xl.cfg.5.pod.in b/docs/man/xl.cfg.5.pod.in
>>> index 4b1e3028d2..55c4881205 100644
>>> --- a/docs/man/xl.cfg.5.pod.in
>>> +++ b/docs/man/xl.cfg.5.pod.in
>>> @@ -690,6 +690,23 @@ default.
>>>   B<NOTE>: Acceptable values are platform specific.  For Intel Processor
>>>   Trace, this value must be a power of 2 between 4k and 16M.
>>>   +=item B<vpmu=BOOLEAN>
>>> +
>>> +Currently ARM only.
>>> +
>>> +Specifies whether to enable the access to PMU registers by disabling
>>> +the PMU traps.
>>> +
>>> +The PMU registers are not virtualized and the physical registers are directly
>>> +accessible when this parameter is enabled. There is no interrupt support and
>>> +Xen will not save/restore the register values on context switches.
>>> +
>>> +vPMU, by design and purpose, exposes system level performance
>>> +information to the guest. Only to be used by sufficiently privileged
>>> +domains. This feature is currently in experimental state.
>>
>> Please update SUPPORT.MD to mention the support of this feature.
>>
>>> +
>>> +If this option is not specified then it will default to B<false>.
>>> +
>>>   =back
>>>     =head2 Devices
>>> diff --git a/tools/golang/xenlight/helpers.gen.go b/tools/golang/xenlight/helpers.gen.go
>>> index c8669837d8..2449580bad 100644
>>> --- a/tools/golang/xenlight/helpers.gen.go
>>> +++ b/tools/golang/xenlight/helpers.gen.go
>>> @@ -1119,6 +1119,9 @@ return fmt.Errorf("converting field ArchX86.MsrRelaxed: %v", err)
>>>   }
>>>   x.Altp2M = Altp2MMode(xc.altp2m)
>>>   x.VmtraceBufKb = int(xc.vmtrace_buf_kb)
>>> +if err := x.Vpmu.fromC(&xc.vpmu);err != nil {
>>> +return fmt.Errorf("converting field Vpmu: %v", err)
>>> +}
>>>      return nil}
>>>   @@ -1600,6 +1603,9 @@ return fmt.Errorf("converting field ArchX86.MsrRelaxed: %v", err)
>>>   }
>>>   xc.altp2m = C.libxl_altp2m_mode(x.Altp2M)
>>>   xc.vmtrace_buf_kb = C.int(x.VmtraceBufKb)
>>> +if err := x.Vpmu.toC(&xc.vpmu); err != nil {
>>> +return fmt.Errorf("converting field Vpmu: %v", err)
>>> +}
>>>      return nil
>>>    }
>>> diff --git a/tools/golang/xenlight/types.gen.go b/tools/golang/xenlight/types.gen.go
>>> index 45f2cba3d2..b2e8bd1a85 100644
>>> --- a/tools/golang/xenlight/types.gen.go
>>> +++ b/tools/golang/xenlight/types.gen.go
>>> @@ -521,6 +521,7 @@ MsrRelaxed Defbool
>>>   }
>>>   Altp2M Altp2MMode
>>>   VmtraceBufKb int
>>> +Vpmu Defbool
>>>   }
>>>     type DomainBuildInfoTypeUnion interface {
>>> diff --git a/tools/include/libxl.h b/tools/include/libxl.h
>>> index ec5e3badae..ee73eb06f1 100644
>>> --- a/tools/include/libxl.h
>>> +++ b/tools/include/libxl.h
>>> @@ -508,6 +508,12 @@
>>>    */
>>>   #define LIBXL_HAVE_PHYSINFO_CAP_VPMU 1
>>>   +/*
>>> + * LIBXL_HAVE_VPMU indicates that libxl_domain_build_info has a vpmu parameter,
>>> + * which allows to enable the access to PMU registers.
>>> + */
>>> +#define LIBXL_HAVE_VPMU 1
>>> +
>>>   /*
>>>    * libxl ABI compatibility
>>>    *
>>> diff --git a/tools/libs/light/libxl_create.c b/tools/libs/light/libxl_create.c
>>> index e356b2106d..2a0234ec16 100644
>>> --- a/tools/libs/light/libxl_create.c
>>> +++ b/tools/libs/light/libxl_create.c
>>> @@ -91,6 +91,7 @@ int libxl__domain_build_info_setdefault(libxl__gc *gc,
>>>       }
>>>         libxl_defbool_setdefault(&b_info->device_model_stubdomain, false);
>>> +    libxl_defbool_setdefault(&b_info->vpmu, false);
>>>         if (libxl_defbool_val(b_info->device_model_stubdomain) &&
>>>           !b_info->device_model_ssidref)
>>> @@ -622,6 +623,9 @@ int libxl__domain_make(libxl__gc *gc, libxl_domain_config *d_config,
>>>                   create.flags |= XEN_DOMCTL_CDF_nested_virt;
>>>           }
>>>   +        if ( libxl_defbool_val(b_info->vpmu) )
>>> +            create.flags |= XEN_DOMCTL_CDF_vpmu;
>>> +
>>>           assert(info->passthrough != LIBXL_PASSTHROUGH_DEFAULT);
>>>           LOG(DETAIL, "passthrough: %s",
>>>               libxl_passthrough_to_string(info->passthrough));
>>> @@ -1199,6 +1203,12 @@ int libxl__domain_config_setdefault(libxl__gc *gc,
>>>           goto error_out;
>>>       }
>>>   +    if (libxl_defbool_val(d_config->b_info.vpmu) && !physinfo.cap_vpmu) {
>>> +        ret = ERROR_INVAL;
>>> +        LOGD(ERROR, domid, "vpmu not supported on this platform\n");
>>> +        goto error_out;
>>> +    }
>>> +
>>>       ret = 0;
>>>    error_out:
>>>       return ret;
>>> diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_types.idl
>>> index 993e83acca..b96fb5c47e 100644
>>> --- a/tools/libs/light/libxl_types.idl
>>> +++ b/tools/libs/light/libxl_types.idl
>>> @@ -655,6 +655,8 @@ libxl_domain_build_info = Struct("domain_build_info",[
>>>       # Use zero value to disable this feature.
>>>       ("vmtrace_buf_kb", integer),
>>>   +    ("vpmu", libxl_defbool),
>>> +
>>>       ], dir=DIR_IN,
>>>          copy_deprecated_fn="libxl__domain_build_info_copy_deprecated",
>>>   )
>>> diff --git a/tools/ocaml/libs/xc/xenctrl.ml b/tools/ocaml/libs/xc/xenctrl.ml
>>> index 7a4030a192..86758babb3 100644
>>> --- a/tools/ocaml/libs/xc/xenctrl.ml
>>> +++ b/tools/ocaml/libs/xc/xenctrl.ml
>>> @@ -70,6 +70,7 @@ type domain_create_flag =
>>>   	| CDF_IOMMU
>>>   	| CDF_NESTED_VIRT
>>>   	| CDF_VPCI
>>> +	| CDF_VPMU
>>>     type domain_create_iommu_opts =
>>>   	| IOMMU_NO_SHAREPT
>>> diff --git a/tools/ocaml/libs/xc/xenctrl.mli b/tools/ocaml/libs/xc/xenctrl.mli
>>> index 6900513e7f..0fdb0cc169 100644
>>> --- a/tools/ocaml/libs/xc/xenctrl.mli
>>> +++ b/tools/ocaml/libs/xc/xenctrl.mli
>>> @@ -63,6 +63,7 @@ type domain_create_flag =
>>>     | CDF_IOMMU
>>>     | CDF_NESTED_VIRT
>>>     | CDF_VPCI
>>> +  | CDF_VPMU
>>>     type domain_create_iommu_opts =
>>>     | IOMMU_NO_SHAREPT
>>> diff --git a/tools/xl/xl_parse.c b/tools/xl/xl_parse.c
>>> index 17dddb4cd5..c503b9be00 100644
>>> --- a/tools/xl/xl_parse.c
>>> +++ b/tools/xl/xl_parse.c
>>> @@ -2750,6 +2750,8 @@ skip_usbdev:
>>>                       "If it fixes an issue you are having please report to "
>>>                       "xen-devel@lists.xenproject.org.\n");
>>>   +    xlu_cfg_get_defbool(config, "vpmu", &b_info->vpmu, 0);
>>> +
>>>       xlu_cfg_destroy(config);
>>>   }
>>>   diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
>>> index aae4472479..2f988c790e 100644
>>> --- a/xen/arch/arm/domain.c
>>> +++ b/xen/arch/arm/domain.c
>>> @@ -276,6 +276,8 @@ static void ctxt_switch_to(struct vcpu *n)
>>>        * timer. The interrupt needs to be injected into the guest. */
>>>       WRITE_SYSREG(n->arch.cntkctl, CNTKCTL_EL1);
>>>       virt_timer_restore(n);
>>> +
>>> +    WRITE_SYSREG(n->arch.mdcr_el2, MDCR_EL2);
>>>   }
>>>     /* Update per-VCPU guest runstate shared memory area (if registered). */
>>> @@ -586,6 +588,10 @@ int arch_vcpu_create(struct vcpu *v)
>>>         v->arch.hcr_el2 = get_default_hcr_flags();
>>>   +    v->arch.mdcr_el2 = HDCR_TDRA | HDCR_TDOSA | HDCR_TDA;
>>> +    if ( !(v->domain->options & XEN_DOMCTL_CDF_vpmu) )
>>> +        v->arch.mdcr_el2 |= HDCR_TPM | HDCR_TPMCR;
>>> +
>>>       if ( (rc = vcpu_vgic_init(v)) != 0 )
>>>           goto fail;
>>>   @@ -622,9 +628,9 @@ int arch_sanitise_domain_config(struct xen_domctl_createdomain *config)
>>>   {
>>>       unsigned int max_vcpus;
>>>   -    /* HVM and HAP must be set. IOMMU and VPCI may or may not be */
>>> -    if ( (config->flags & ~XEN_DOMCTL_CDF_iommu & ~XEN_DOMCTL_CDF_vpci) !=
>>> -         (XEN_DOMCTL_CDF_hvm | XEN_DOMCTL_CDF_hap) )
>>> +    /* HVM and HAP must be set. IOMMU, VPCI and VPMU may or may not be */
>>> +    if ( (config->flags & ~(XEN_DOMCTL_CDF_iommu | XEN_DOMCTL_CDF_vpci |
>>> +          XEN_DOMCTL_CDF_vpmu)) != (XEN_DOMCTL_CDF_hvm | XEN_DOMCTL_CDF_hap) )
>>
>> The split here is not easy to read. Can you introduce two masks (one for the flags that must be set and the other optional) so we don't need to split the optional options over two lines.
>>
>>>       {
>>>           dprintk(XENLOG_INFO, "Unsupported configuration %#x\n",
>>>                   config->flags);
>>> diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c
>>> index 49dc90d198..85386a765a 100644
>>> --- a/xen/arch/arm/setup.c
>>> +++ b/xen/arch/arm/setup.c
>>> @@ -108,6 +108,7 @@ static void __init processor_id(void)
>>>         identify_cpu(c);
>>>       current_cpu_data = *c;
>>> +    vpmu_is_available = cpu_has_pmu;
>>
>> This wants to be set after the ID registers are sanitized (i.e. after the secondary CPUs have been brought).
>>
>> Also, on Armv8, the features supported by 64-bit and 32-bit exception level are separate. I couldn't find anything in the Arm that suggest that if the PMU is implemented by the former, then the latter must be. Do you have the page in hand?
> 
> Chapter D7.1 at the end is saying this:
> 
> "The Performance Monitors Extension is common to AArch64 operation and AArch32 operation.”
> 
> Is this the justification you are looking for ?

Yes. Thank you!

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Tue Oct 12 15:32:13 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 15:32:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.207433.363262 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maJlE-0001Kk-Vx; Tue, 12 Oct 2021 15:32:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 207433.363262; Tue, 12 Oct 2021 15:32:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maJlE-0001Kd-Sc; Tue, 12 Oct 2021 15:32:12 +0000
Received: by outflank-mailman (input) for mailman id 207433;
 Tue, 12 Oct 2021 15:32:12 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1maJlD-0001KX-WC
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 15:32:12 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1maJlD-0003yS-VQ
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 15:32:11 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1maJlD-0004xz-Ub
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 15:32:11 +0000
Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89)
 (envelope-from <iwj@xenproject.org>)
 id 1maJl8-0004nO-Gb; Tue, 12 Oct 2021 16:32:06 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date
	:Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From;
	bh=bbo1bLL+rsvqnjjWkOSva+bJDV1jaPw/6AVQKLIJMfM=; b=E76Xw8qSPG1A68NTt+HyDHW3+y
	oRQLauxtPrN/xr2O/iTPuFyzjvkY+lM8Zp4WdqlNFKcKBhd3wqFwznjMW0XHrnE/nDSaDNSO8fcxq
	k5guj2uhNCe5QVuY77I5iqz5JWv6HQsiu/HxvW5cdy7sxns2bkeu+IHMvAP39obKjI9I=;
From: Ian Jackson <iwj@xenproject.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <24933.43638.23413.704241@mariner.uk.xensource.com>
Date: Tue, 12 Oct 2021 16:32:06 +0100
To: Oleksandr <olekstysh@gmail.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
    xen-devel@lists.xenproject.org,
    Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
    Wei Liu <wl@xen.org>,
    Anthony PERARD <anthony.perard@citrix.com>,
    Juergen Gross <jgross@suse.com>,
    Julien Grall <julien@xen.org>,
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH V6 2/2] libxl/arm: Add handling of extended regions for
 DomU
In-Reply-To: <37b38f3c-ffc6-b808-13a3-525dcac07d4e@gmail.com>
References: <1633974539-7380-1-git-send-email-olekstysh@gmail.com>
	<1633974539-7380-3-git-send-email-olekstysh@gmail.com>
	<37b38f3c-ffc6-b808-13a3-525dcac07d4e@gmail.com>
X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu)

Oleksandr writes ("Re: [PATCH V6 2/2] libxl/arm: Add handling of extended regions for DomU"):
> On 11.10.21 20:48, Oleksandr Tyshchenko wrote:
> Hi Ian, Stefano
> > +        LOG(DEBUG, "Extended region %u: %#"PRIx64"->%#"PRIx64"\n",
> 
> If this appears to be the last version, may I please ask to remove 
> unneeded "\n" in the message above while committing? Thank you.

I think Stefano will be committing this but: personally I don't like
the "edit on commit" workflow.  Committers are already a bottleneck
and it is easy to make uncontrolled mistakes.  I find the most
convenient workflow to be to acquire a git branch from somewhere and
commit that, so if you provide a git branch with the acks folded in
and this kind of minor fix included, that would be ideal.  Ie,
git-request-merge format or something like it.

Thanks,
Ian.


From xen-devel-bounces@lists.xenproject.org Tue Oct 12 15:34:27 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 15:34:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.207440.363273 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maJnO-0001wd-Cs; Tue, 12 Oct 2021 15:34:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 207440.363273; Tue, 12 Oct 2021 15:34:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maJnO-0001wW-8y; Tue, 12 Oct 2021 15:34:26 +0000
Received: by outflank-mailman (input) for mailman id 207440;
 Tue, 12 Oct 2021 15:34:25 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1maJnN-0001wQ-8S
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 15:34:25 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1maJnL-00040w-Im; Tue, 12 Oct 2021 15:34:23 +0000
Received: from 54-240-197-225.amazon.com ([54.240.197.225] helo=[192.168.23.5])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1maJnL-0005NM-D6; Tue, 12 Oct 2021 15:34:23 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=ZbeFZqmFNwlzok7VDP85LVy+9ZNCacj9ZKff0e11BIc=; b=BA/spLaK2AC1KIuwnmjB/MDbL4
	hiDw/29qgOhWUU0X+6CuFS3mxHaDjYOONzw2K3AwY9Ez9Vjd+P80pXl3JnKgDlesgBiZ5mLfdcooI
	SsVzIcoDtCmncbNkqRgZR2aYP1FJA6faLTKgGzieQUSuFubnkn5bndJLvycdH1dBe8SE=;
Message-ID: <eecabba5-9363-9c4a-6b95-6b1f3bbd34e0@xen.org>
Date: Tue, 12 Oct 2021 16:34:20 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.2.0
Subject: Re: [PATCH v5 3/3] xen: Expose the PMU to the guests
To: Michal Orzel <michal.orzel@arm.com>, xen-devel@lists.xenproject.org
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Jan Beulich <jbeulich@suse.com>, Stefano Stabellini
 <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 Nick Rosbrook <rosbrookn@ainfosec.com>,
 Anthony PERARD <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>,
 Christian Lindig <christian.lindig@citrix.com>, David Scott
 <dave@recoil.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 bertrand.marquis@arm.com
References: <20211012081323.14141-1-michal.orzel@arm.com>
 <20211012081323.14141-4-michal.orzel@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20211012081323.14141-4-michal.orzel@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Michal,

On 12/10/2021 09:13, Michal Orzel wrote:
> diff --git a/SUPPORT.md b/SUPPORT.md
> index 317392d8f3..2f1f60c49a 100644
> --- a/SUPPORT.md
> +++ b/SUPPORT.md
> @@ -256,6 +256,15 @@ from dom0.
>   
>       Status, x86: Tech Preview
>   
> +### vPMU support

There is already a section vPMU that is meant to be generic. At the 
moment it mentions the status support for x86 but not Arm. So can you 
fold the status for Arm there?

> +
> +Support for accessing PMU registers from the guests.
> +There is no interrupt support and Xen will not save/restore
> +the register values on context switches.
> +Disabled by default (enable with guest parameter).
> +
> +    Status, ARM: Experimental
> +

The rest of the patch looks good to me.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Tue Oct 12 15:38:15 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 15:38:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.207448.363284 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maJr1-0002be-S9; Tue, 12 Oct 2021 15:38:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 207448.363284; Tue, 12 Oct 2021 15:38:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maJr1-0002bX-Oo; Tue, 12 Oct 2021 15:38:11 +0000
Received: by outflank-mailman (input) for mailman id 207448;
 Tue, 12 Oct 2021 15:38:10 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=P4MT=PA=gmail.com=olekstysh@srs-us1.protection.inumbo.net>)
 id 1maJr0-0002bR-Cs
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 15:38:10 +0000
Received: from mail-lf1-x12e.google.com (unknown [2a00:1450:4864:20::12e])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id e9e6fa80-10d9-441d-b0c4-b20dca6c7eef;
 Tue, 12 Oct 2021 15:38:09 +0000 (UTC)
Received: by mail-lf1-x12e.google.com with SMTP id r19so86537971lfe.10
 for <xen-devel@lists.xenproject.org>; Tue, 12 Oct 2021 08:38:09 -0700 (PDT)
Received: from [192.168.1.7] ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id b4sm1064444lfq.9.2021.10.12.08.38.03
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Tue, 12 Oct 2021 08:38:03 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e9e6fa80-10d9-441d-b0c4-b20dca6c7eef
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-transfer-encoding:content-language;
        bh=40b+ybH6DaWJ8M613inAfoCx0ss8Nsb4+kp6QadTkRY=;
        b=egXkhfaGjJ73+JxvmsExKIDoFJv23OXpMhHBnBa7yxjrHMO9wAuOBu+dxqjlnFPKQW
         pFYX2iZLcBidFDjE64uVsNYeuaFIJj0cDPcXtHcWDvlRhQ33PzMT5Y0jBeSNmSN+eb9U
         ezV04tXEMCu4C8Xl2GkTN5PVmSVpve3tHcmL72XogEroWcuC3uvolCS1hIc+WzBnLROT
         19zzfDE7KdESr7iBNxt5ycwT9Ppzq/kMbeL2yNv0rwzIMRoIgvPEG5fF3+uzKrJmpnbL
         3ETb4S08SOLRdaoQkzPdfnt4E8Yg9JJEYk2elBU3xCbYJH3Jf3vOFLhRh8t3ZnrmExzk
         O4ng==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding
         :content-language;
        bh=40b+ybH6DaWJ8M613inAfoCx0ss8Nsb4+kp6QadTkRY=;
        b=RbYw4LowhQsiVwGYPMUfOY3Hjl69J+o/127ZcNVY4vRNfo2MaJgmMmkr0PP5OTlAfo
         66Le29cekqkrbQLD0hr6Ks13JOIATR48fV1TOqJ9TiiLhPi+HCyeL3NjLjRkB1P2rxqJ
         MFuncsF6TJ2ECty65aNW2QRvaS3nsOSIi8ifvUU47ucOCzaZ9wkgGC/kUv0tML2CymqJ
         udqGvJw1m8O/sLXGJ9JKoaV9HhJg9qIXvv0t3BjLr4f8l1LdrR2NI9F8+O2PTdltaVJt
         D/W8uhiaL/jOvZiENeKnvRrEPYLEuHb+mZmJaZMCf4j8lsADum5+IgXnBJ2fcsCqnxBf
         rJOw==
X-Gm-Message-State: AOAM533i52kZ+iO9blKrG9cEizX1ZemZyMVzviaYPf3PQRRAzLyoV1FK
	FhW/qvenjMq10kqLXSCM4io=
X-Google-Smtp-Source: ABdhPJwUqGfGIoEr9TXr0dWqO5V4ZUfg7MWsvm5upuxsKe6PODjNlEARWFySPyKbA1TzRCEDyLK7Ww==
X-Received: by 2002:a2e:b05a:: with SMTP id d26mr10761695ljl.77.1634053084193;
        Tue, 12 Oct 2021 08:38:04 -0700 (PDT)
Subject: Re: [PATCH V6 2/2] libxl/arm: Add handling of extended regions for
 DomU
To: Ian Jackson <iwj@xenproject.org>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 xen-devel@lists.xenproject.org,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, Wei Liu <wl@xen.org>,
 Anthony PERARD <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>,
 Julien Grall <julien@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <1633974539-7380-1-git-send-email-olekstysh@gmail.com>
 <1633974539-7380-3-git-send-email-olekstysh@gmail.com>
 <37b38f3c-ffc6-b808-13a3-525dcac07d4e@gmail.com>
 <24933.43638.23413.704241@mariner.uk.xensource.com>
From: Oleksandr <olekstysh@gmail.com>
Message-ID: <33145812-b0a4-b2d8-4f1a-f7c32c29c7fc@gmail.com>
Date: Tue, 12 Oct 2021 18:38:02 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <24933.43638.23413.704241@mariner.uk.xensource.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US


On 12.10.21 18:32, Ian Jackson wrote:

Hi Ian

> Oleksandr writes ("Re: [PATCH V6 2/2] libxl/arm: Add handling of extended regions for DomU"):
>> On 11.10.21 20:48, Oleksandr Tyshchenko wrote:
>> Hi Ian, Stefano
>>> +        LOG(DEBUG, "Extended region %u: %#"PRIx64"->%#"PRIx64"\n",
>> If this appears to be the last version, may I please ask to remove
>> unneeded "\n" in the message above while committing? Thank you.
> I think Stefano will be committing this but: personally I don't like
> the "edit on commit" workflow.  Committers are already a bottleneck
> and it is easy to make uncontrolled mistakes.  I find the most
> convenient workflow to be to acquire a git branch from somewhere and
> commit that, so if you provide a git branch with the acks folded in
> and this kind of minor fix included, that would be ideal.  Ie,
> git-request-merge format or something like it.

Yes, I will provide a git branch later on today.


>
> Thanks,
> Ian.

-- 
Regards,

Oleksandr Tyshchenko



From xen-devel-bounces@lists.xenproject.org Tue Oct 12 15:40:54 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 15:40:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.207456.363295 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maJtd-0003xd-Aj; Tue, 12 Oct 2021 15:40:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 207456.363295; Tue, 12 Oct 2021 15:40:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maJtd-0003xW-7M; Tue, 12 Oct 2021 15:40:53 +0000
Received: by outflank-mailman (input) for mailman id 207456;
 Tue, 12 Oct 2021 15:40:51 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1maJtb-0003xM-Q3; Tue, 12 Oct 2021 15:40:51 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1maJtb-00048b-LE; Tue, 12 Oct 2021 15:40:51 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1maJtb-0002fL-Cx; Tue, 12 Oct 2021 15:40:51 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1maJtb-0007xj-CS; Tue, 12 Oct 2021 15:40:51 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=9mUtKvZPv3TtjyucK3SGmGOALsQQahJgu+xeimA0xZk=; b=ZFKQhCCCzDFf3f4t6vpI4m6okF
	zbwWrH70+ut8QkVz7nxri6Gd+/dzN6pem9eMiC5pM9vnHO1UPsSvh0xGo5KFW3+1AR9q/MMW2cnJD
	kju5V5riM/99eDS8BEqQsuqOZoj/FeQboa5KhrREf8IRl9pIN9ZFQfVSlyxr/iDxM72k=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165471-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 165471: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-unstable:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:allowable
    xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=e8b42a4e8810844ccffd2eab072921b1e4e2ed79
X-Osstest-Versions-That:
    xen=2fac4e3ea3bb301f87426e24b9dfd765c22c9cf9
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 12 Oct 2021 15:40:51 +0000

flight 165471 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165471/

Failures :-/ but no regressions.

Regressions which are regarded as allowable (not blocking):
 test-amd64-amd64-xl-rtds     20 guest-localmigrate/x10   fail REGR. vs. 165467
 test-armhf-armhf-xl-rtds    18 guest-start/debian.repeat fail REGR. vs. 165467

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 165467
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 165467
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165467
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165467
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 165467
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 165467
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 165467
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 165467
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 165467
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 165467
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165467
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 165467
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  e8b42a4e8810844ccffd2eab072921b1e4e2ed79
baseline version:
 xen                  2fac4e3ea3bb301f87426e24b9dfd765c22c9cf9

Last test of basis   165467  2021-10-11 15:06:53 Z    1 days
Testing same since   165471  2021-10-12 01:38:53 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Roger Pau Monne <roger.pau@citrix.com>
  Roger Pau Monné <roger.pau@citrix.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     fail    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   2fac4e3ea3..e8b42a4e88  e8b42a4e8810844ccffd2eab072921b1e4e2ed79 -> master


From xen-devel-bounces@lists.xenproject.org Tue Oct 12 15:44:21 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 15:44:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.207466.363313 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maJwx-0004h3-0n; Tue, 12 Oct 2021 15:44:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 207466.363313; Tue, 12 Oct 2021 15:44:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maJww-0004gw-TD; Tue, 12 Oct 2021 15:44:18 +0000
Received: by outflank-mailman (input) for mailman id 207466;
 Tue, 12 Oct 2021 15:44:17 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=kpIn=PA=oracle.com=dongli.zhang@srs-us1.protection.inumbo.net>)
 id 1maJwv-0004gk-6D
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 15:44:17 +0000
Received: from mx0b-00069f02.pphosted.com (unknown [205.220.177.32])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 2679334d-1065-4d87-b338-34641e2aaef2;
 Tue, 12 Oct 2021 15:44:14 +0000 (UTC)
Received: from pps.filterd (m0246631.ppops.net [127.0.0.1])
 by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 19CFW4QX032370; 
 Tue, 12 Oct 2021 15:44:12 GMT
Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80])
 by mx0b-00069f02.pphosted.com with ESMTP id 3bmtmk77jk-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Tue, 12 Oct 2021 15:44:11 +0000
Received: from pps.filterd (userp3030.oracle.com [127.0.0.1])
 by userp3030.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 19CFf569128538;
 Tue, 12 Oct 2021 15:43:12 GMT
Received: from nam11-dm6-obe.outbound.protection.outlook.com
 (mail-dm6nam11lp2175.outbound.protection.outlook.com [104.47.57.175])
 by userp3030.oracle.com with ESMTP id 3bkyv93my4-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Tue, 12 Oct 2021 15:43:12 +0000
Received: from BYAPR10MB2663.namprd10.prod.outlook.com (2603:10b6:a02:a9::20)
 by BY5PR10MB4067.namprd10.prod.outlook.com (2603:10b6:a03:1b4::25)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.22; Tue, 12 Oct
 2021 15:43:08 +0000
Received: from BYAPR10MB2663.namprd10.prod.outlook.com
 ([fe80::2848:63dc:b87:8021]) by BYAPR10MB2663.namprd10.prod.outlook.com
 ([fe80::2848:63dc:b87:8021%7]) with mapi id 15.20.4587.026; Tue, 12 Oct 2021
 15:43:08 +0000
Received: from [IPv6:2606:b400:400:7446:8000::222] (2606:b400:8301:1010::16aa)
 by SN6PR01CA0015.prod.exchangelabs.com (2603:10b6:805:b6::28) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4587.19 via Frontend Transport; Tue, 12 Oct 2021 15:43:07 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2679334d-1065-4d87-b338-34641e2aaef2
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc :
 references : from : message-id : date : in-reply-to : content-type :
 content-transfer-encoding : mime-version; s=corp-2021-07-09;
 bh=m/j0VXFfTgww0jA+0/BLqc1t2J21ixLL93BdHs9cfMQ=;
 b=CHHYkxVWr/oXjgxdxVSTETffZvhynU2uZzjHOt6WnnAwCG6cjsplxP160SX+sP5hpJWS
 ysXjUvxOJ1OOG0XdEmT15ocbBydqUzhJ8pSXkJc7GEL8st8GvfIZtnxQ876WnhPs0yfX
 7ki0Bl18IK94KDszklBlpSPGvitB8tYknST4MAleWcq/ZUmytGRc5Y+/ZJK5933LcAzv
 cqgCV48oC7uIYZHjDfMrQ6BIzH3alzfdqpl5obFa7JyFkUU3UJFgCLmJdcTyMHCA0Tpc
 lwOz0v5CrH1ffweieFozfQqp06NniYaffBUoI0c0/vaayjh7sVfjhIDSfvAOvZf7uKNy zA== 
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ewBsFxHGrnsuqZEMCGnn/FsgYpCdCMpkiqu2VvW0mrHlyv/rIQEbfXvI2IgqEYvnvmUej7Ki9dzvx7mDflKfeRWwDLoC7Fu+F/js2royQKdA6awtM3Qj6/aO8tTBxHfwFCB1Oq+PDLooD7EdwkFfi9uXzra2b65kZSrecx+F0ip9LZgCAcRzw+PUvCi2Jvi3fEjpkZYswedfxIJXS/U5j541CliqFbfzIRrJphzAj1RboOo7AZ9w48ONfKUprI2ITxwqoYSWsHSfMVmNjX85I+bno3g7ede6MeVQFdrjSvEy5H+UyPag/mfrh/f0BAi9nY0Ac5YktvDUh0+4VM33nA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=m/j0VXFfTgww0jA+0/BLqc1t2J21ixLL93BdHs9cfMQ=;
 b=HKngeEmtIzGcda+mWkQSGzumFmSZfie+ok8iJAXDZkL5VfC1VUgOmsnPQBwptwgpqbsU02pBJVDnPNx+UDEEWdHTqA8w5kIWN24SEuMQ6Lugwf+m0AjzCvLD4E4bZ/V+ZT5UAh1eDBZuLlTJphff5IwvJ2WzW5rFVMDwiodv+hZxuYM3vEacDJ9DMpABWKKEsxkKsvbHEjIpnefNXnHt79xiphCJ6Wc+BjkO2i5VUFy1sAvgKKWN7mQZx7TE3IOM18jSRCfONEnctS6b2wVh3G19wLWfoT/RW9Je5TuActY1rrHMxn3yiKt10j9UBTb/a8EyWzWB6GlA19QpTzAGUg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com;
 dkim=pass header.d=oracle.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=m/j0VXFfTgww0jA+0/BLqc1t2J21ixLL93BdHs9cfMQ=;
 b=jsIWyTR7vj2cG4ibygMXgdhAdz83fTeYa455pU8axftkJnb3FBBALOdT54c5oNNIAGX47SocsoPAJeVAiJM9M9b5pb9q0wRqnA88NmfAIZhs8Al33QhM7r3Y31iEVgRtsfHgWc0buMy5WAadvjlRg8MdhdYDUJUgxsnrLQQwtCY=
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=oracle.com;
Subject: Re: [PATCH xen 2/2] xen: update system time immediately when
 VCPUOP_register_vcpu_info
To: Jan Beulich <jbeulich@suse.com>
Cc: sstabellini@kernel.org, andrew.cooper3@citrix.com,
        george.dunlap@citrix.com, iwj@xenproject.org, julien@xen.org,
        wl@xen.org, joe.jin@oracle.com, xen-devel@lists.xenproject.org
References: <20211012072428.2569-1-dongli.zhang@oracle.com>
 <20211012072428.2569-3-dongli.zhang@oracle.com>
 <317163fa-f736-ccfe-40d4-b918ce2834f9@suse.com>
From: Dongli Zhang <dongli.zhang@oracle.com>
Message-ID: <3e16648f-088d-5f62-03d7-ca744e913cbb@oracle.com>
Date: Tue, 12 Oct 2021 08:43:05 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.6.1
In-Reply-To: <317163fa-f736-ccfe-40d4-b918ce2834f9@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: SN6PR01CA0015.prod.exchangelabs.com (2603:10b6:805:b6::28)
 To BYAPR10MB2663.namprd10.prod.outlook.com (2603:10b6:a02:a9::20)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: bde8fd7b-ebcb-4fc4-f855-08d98d96fd42
X-MS-TrafficTypeDiagnostic: BY5PR10MB4067:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: 
	<BY5PR10MB40676BA466484BC620E6C091F0B69@BY5PR10MB4067.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6430;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 
	zMHKwmYjZ53Q1TBZjB7XS8zN9bkyvKJoliqg5T3Z6u6qC31T9oZ6j6ZDOUkIVYIbv3ZkUg3m7jExa43Q0JkrCxXdNhvY6ZxV+1p+7y4L2Kag5JAEZrilahPFa2A89x/ojDZUbR0WOkh/kXoSM1RAJk5csyOj9n58+oNw5fPopbGU7mZ8z3YQK8tZT12+b7fkA9J3JDEv1LnvSXDZuwnETqQVH5x3gAR5VewGM4KxcJEbAv0OkXBXK8ItKdVtGqIwWZncifJT/PLyktQO6NMvrOHK4w7Ze2Mbejy2g2aivHjZzXu3YJPOUIRPKWSlzdrLU62jTEy9KCk8ZX20pgjyiXDLZo3JE0XvW+Z86p6RRICSChV06pC7XLxmfOY/Fu1MxGnfwnyKd93DK7DvmIYHpCuz69KXXxp/DG3AhKSbrWC2OMTJHkaKnUsEUDpI/ovwtQdsK6aTuBqJK5YptnQRbIm/VqXx4fh2OINxwgfwqBeeD5ozXLcuHCG1JaAGJdlEMycq+i3JGdkpQvcQSHdKgpkuyf1R1+TWdFDPsX/EQ7iLvMsuIkINt+QyoJbf4kURse7sh/OiLNH7WDUK3bQALstqpqrEMaB1Yxe+c92cYksK0gnSzZhZYG+Pa6raIItjCYI2o+OuyQRirOdz0Wkzy8NzQm/PdwWG9uVo6+S9OWfoeP+/F78WOMsTZntaohrk5mM6Q5U+0EjrvdsecUOnEC1Hjk4CCdawTg48++cC77I=
X-Forefront-Antispam-Report: 
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB2663.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(186003)(4326008)(8676002)(6486002)(2906002)(31696002)(6916009)(66476007)(36756003)(38100700002)(508600001)(31686004)(66946007)(66556008)(53546011)(44832011)(83380400001)(15650500001)(5660300002)(316002)(8936002)(2616005)(86362001)(14773001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?VG45KzJqWW9JRldZbG85Skw5YmVSeExMWmRNeS9LNmNtemEzdmlKTXdaN1p5?=
 =?utf-8?B?OUxmNTBQZ2FOTW9DSmpLM0VpbWtLMkxza09nd1Rsc2NhKzhPR3lwdnc0MFcv?=
 =?utf-8?B?YjJjNjB3cnkzQjdHK0o4ODN2YW01YWtDU2hBUE1mL29YdDcxcy9KdWt3Z29M?=
 =?utf-8?B?NHEwQWpaZ0hiUGtVUTdLOFVLaGRJZjlsOWdjZnc4OHlvNVV0dThxUFd5aGw4?=
 =?utf-8?B?Zi9XMlRLTDRNbjFMUHJndnU0OXdHQ2JMRjVtT2xrMlBMQ1VpbStNRkwvaGtz?=
 =?utf-8?B?VHNBVjNsSEtoalEwUHRlTVJjbHczVHY5bXdaR25TN3dhSzE5UEIrMmRLTFkr?=
 =?utf-8?B?a1BjQmcxN0NoazNxS3ZMNlh0WlV5bElDTUpwQ29OMCt5RGtnNHpac1J1N2tQ?=
 =?utf-8?B?Mzh5RjU4ZFlDTStLM3N0UUhoZHFYcEo0VCtzMlhRYUpCNTRnRHREclBBbHhn?=
 =?utf-8?B?UDVGdjgrcnJvWVZpTGIyd0tCMEx2RUpyRWtlcUtlSWoxQjhjNkd3S21oU1FU?=
 =?utf-8?B?clV1NVhXTndkWHFyam9ib2ZyTmhRS0ZmcHl5WVExOVpoZStLWUJpcEwraTNW?=
 =?utf-8?B?R0JkOXRXSVJZZVVSZ3VHbkxoTFlDM1N1Y3IxK1kxTGJydHBMZVZsdGZFT2JW?=
 =?utf-8?B?TGFleFI4TysyZVhxKzNpRzFSSExTcHFMMWRrTVZlUTk1WkdBemQvNVBOMU85?=
 =?utf-8?B?Sk1sNkF5NlZjaDdCTStUaWRod2JKa2dXQjA1RDZtRFF3SEN5NHF1SUNRaTRs?=
 =?utf-8?B?Umh5RENPOUVHUnk0Ri9WaTdTQlU1TTB5SEJPajBmZXZHRFdocVVxV09TdlBC?=
 =?utf-8?B?d25pKzF3WFYrME5zbG9IRy9uNDZpMytuOGJWWXl1UWllV1F1NmgraVd1RUFI?=
 =?utf-8?B?Q2hlbTdzbWpSdWJhVFdxU2hxUU9sQzRSY3hFZ0d4ZDNpa1h0YXg4U21BODBB?=
 =?utf-8?B?YUtKTVFpRjNFRC9DZ1NUSFV1aTVGWkVkeU1PYjRTbjQrWTkrUXhUNmlTWDBV?=
 =?utf-8?B?RTR5MFV2bGpZOFpoTDFjL3N4ZmlCU25ibWd0SXA0ZEZ6ZVcxdk5aamg5YTds?=
 =?utf-8?B?SW9rak1PaXNDdmdPZ2xoelpFVzZCcnIxaVhUQmkrMGxzU3FZL1J4R3cvREZC?=
 =?utf-8?B?NkpVanUwS2JEeWcvaGVqQ29CR0E0SUJNTFg0YlBIQ2k2MWx3TnRGNkZUeDhv?=
 =?utf-8?B?UjQyYkdza1llOVNrTFBSRTVqMW1KUTRPQWhLa2ZyaWFxN09ublZDaFY3Wkdx?=
 =?utf-8?B?R3FYVHpSd01HbERsMnFlNTJrZW83NjhSa3RudE5aRGtTbE9PTW5BMUJWZFYv?=
 =?utf-8?B?S1VWa0NsdVhHVHR2TnIyRkx0bWpTbytOM2ZFcklERVNSSFFaOGVyeWM1bkhC?=
 =?utf-8?B?eDVLWHdrSUQwKzF1VzNiaDVpUm5Rb2ZTbzFHUTBrdDBvQnNGU3lVckgxbUw5?=
 =?utf-8?B?aHAyN1JqSEZJM0theG5vVGh2NitYblY4SE5wVmtVUFdFT3lreXRrbk55dlkz?=
 =?utf-8?B?R0xjVVR4VjhXRXUzRHlLZG1LVVoxZnUwV2JLRWdwYmc1N3VaYUVOZ1NQektQ?=
 =?utf-8?B?ckRiVlprc2tiZjZKeW9PWFVQYjlRbC9NVmxOQkdqczlUWlNNUit2a21KQjB6?=
 =?utf-8?B?Qk1kTS93bW4vOFBkRFFscnZMeDJEWFBiMDdERE50b1JocXJpSGpwYmVDR2NR?=
 =?utf-8?B?VE9pQ1h0Sy9YcHJqVDlLem5KR2N6cUJVTGlLczBERGQ0QjJuWW1IaEMvYVpM?=
 =?utf-8?B?NVJkNHJDZUlibytXSzZ5L09JaEx1MjR6YTRrc2JrTUt6V04vYnp1RmNhbDhG?=
 =?utf-8?B?NXVVMkRMUmd1ZGRsazVBUT09?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bde8fd7b-ebcb-4fc4-f855-08d98d96fd42
X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB2663.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2021 15:43:08.5190
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: nwtbgyQipsgJNZhqGf1INSSqAgNlIRIq5q6r14s2qvZILRKEgwwMOiqpOI/qvkmkQAXp7AL0/tC2TLbeiHMDEg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR10MB4067
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10135 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 phishscore=0 bulkscore=0
 malwarescore=0 adultscore=0 mlxscore=0 spamscore=0 mlxlogscore=999
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109230001
 definitions=main-2110120087
X-Proofpoint-GUID: 8-uJoARvX78ZNFCCfUbzOzbW7DU5EJoa
X-Proofpoint-ORIG-GUID: 8-uJoARvX78ZNFCCfUbzOzbW7DU5EJoa

Hi Jan,

On 10/12/21 1:40 AM, Jan Beulich wrote:
> On 12.10.2021 09:24, Dongli Zhang wrote:
>> The guest may access the pv vcpu_time_info immediately after
>> VCPUOP_register_vcpu_info. This is to borrow the idea of
>> VCPUOP_register_vcpu_time_memory_area, where the
>> force_update_vcpu_system_time() is called immediately when the new memory
>> area is registered.
>>
>> Otherwise, we may observe clock drift at the VM side if the VM accesses
>> the clocksource immediately after VCPUOP_register_vcpu_info().
>>
>> Cc: Joe Jin <joe.jin@oracle.com>
>> Signed-off-by: Dongli Zhang <dongli.zhang@oracle.com>
> 
> While I agree with the change in principle, ...
> 
>> --- a/xen/common/domain.c
>> +++ b/xen/common/domain.c
>> @@ -1695,6 +1695,8 @@ long do_vcpu_op(int cmd, unsigned int vcpuid, XEN_GUEST_HANDLE_PARAM(void) arg)
>>          rc = map_vcpu_info(v, info.mfn, info.offset);
>>          domain_unlock(d);
>>  
>> +        force_update_vcpu_system_time(v);
> 
> ... I'm afraid you're breaking the Arm build here. Arm will first need
> to gain this function.
> 

Since I am not familiar with the Xen ARM, would you please let me your
suggestion if I just leave ARM as TODO to the ARM developers to verify
and implement force_update_vcpu_system_time()?

I have tested that the below can build with arm64/aarch64.

diff --git a/xen/common/domain.c b/xen/common/domain.c
index 40d67ec342..644c65ecd3 100644
--- a/xen/common/domain.c
+++ b/xen/common/domain.c
@@ -1695,6 +1695,13 @@ long do_vcpu_op(int cmd, unsigned int vcpuid,
XEN_GUEST_HANDLE_PARAM(void) arg)
         rc = map_vcpu_info(v, info.mfn, info.offset);
         domain_unlock(d);

+#ifdef CONFIG_X86
+        /*
+         * TODO: ARM does not have force_update_vcpu_system_time().
+         */
+        force_update_vcpu_system_time(v);
+#endif
+
         break;
     }



Thank you very much!

Dongli Zhang


From xen-devel-bounces@lists.xenproject.org Tue Oct 12 15:48:17 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 15:48:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.207475.363323 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maK0l-0005Ma-GU; Tue, 12 Oct 2021 15:48:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 207475.363323; Tue, 12 Oct 2021 15:48:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maK0l-0005MT-DP; Tue, 12 Oct 2021 15:48:15 +0000
Received: by outflank-mailman (input) for mailman id 207475;
 Tue, 12 Oct 2021 15:48:13 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=P4MT=PA=gmail.com=olekstysh@srs-us1.protection.inumbo.net>)
 id 1maK0j-0005MN-J7
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 15:48:13 +0000
Received: from mail-lf1-x133.google.com (unknown [2a00:1450:4864:20::133])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 2b8def96-88cf-4d72-ae19-3b189f7e5c57;
 Tue, 12 Oct 2021 15:48:12 +0000 (UTC)
Received: by mail-lf1-x133.google.com with SMTP id t9so87949124lfd.1
 for <xen-devel@lists.xenproject.org>; Tue, 12 Oct 2021 08:48:12 -0700 (PDT)
Received: from [192.168.1.7] ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id c24sm855222lja.52.2021.10.12.08.48.09
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Tue, 12 Oct 2021 08:48:10 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2b8def96-88cf-4d72-ae19-3b189f7e5c57
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-transfer-encoding:content-language;
        bh=b6PuABebMZgQhVbL8I8sua236kFuHfHUd128sudRUvk=;
        b=EWzZvM8zyhVxegPoJZ8E4TQKMNIeoHeDclck1QADTX+NvrMivEAaYPU0lS5jjQju0R
         4PTOsXAhak9LYE7Nptb6S5D+6L7ll+8wQbUwSn4o++i+uBQ/EPPJ1pfAzOIANwdQpW6+
         grilIbL2je5JcZpCD+ktSvKro+lqAG+8MX/VF1dc+KMQ3+mSocX7Oidgh0NaGNLfvboN
         IzTdUtz96aVeQO39kMSwP7/5AIFELi/EG2+YZIEs6bxHDhzsQeI2R4fkWPw+4JzyUMmo
         RPFn9FGWijkmR58xK1UvKeA9ScM2w/dzAmL/IR8OO3TcCeQd2woPZCxYWQGmDJ+SYTj9
         cXKQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding
         :content-language;
        bh=b6PuABebMZgQhVbL8I8sua236kFuHfHUd128sudRUvk=;
        b=ncZ8Olxf+nqsVF0pkYmDanb15ITZ5f2IjajBgFTnjKntn0ahbi97cd1Hka+5sdNKNd
         IeTSF1YCDgJt7zhIYB3ZI+mGb1lULkrwusLLLkM1sGvpQT9GXYl1v6j7HJEZ7vL5XI/Q
         RvcX7Yzf0okkDN0WjDN4jqCD/h/YxbszSwE+f8O3EwgmKsVnG8POKm6xT7DGXuQxhIrM
         ULicJlHiVem1VqcfHvpNyJ+v9NgK00tME20uNWo1dJXK7aoFVMqtTM+uXB5VyQTAedAo
         KNboR5dBP8r9RrIBGA3GBexBIKYaZHhNFZ7XBnUNSmMDfZPqISAc50CmrpeXROC19HQy
         bNhg==
X-Gm-Message-State: AOAM530DPSFO9XgZSXos9dXI6jLuGNWP/5QmEVX+kFmodzkJ5vIrrj5v
	wxmzrEroha7xdf4PF3V3T1Y=
X-Google-Smtp-Source: ABdhPJxwuXnPhUorWIRQQepHLbim8uw0NAEz+1JiJ1VZkWknkCEz1parM/E1h/KOklap+ZK2LsqNAg==
X-Received: by 2002:a05:6512:2291:: with SMTP id f17mr30398792lfu.253.1634053690727;
        Tue, 12 Oct 2021 08:48:10 -0700 (PDT)
Subject: Re: [PATCH V6 1/2] xen/arm: Introduce gpaddr_bits field to struct
 xen_domctl_getdomaininfo
To: Ian Jackson <iwj@xenproject.org>
Cc: xen-devel@lists.xenproject.org,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, Wei Liu <wl@xen.org>,
 Anthony PERARD <anthony.perard@citrix.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Juergen Gross <jgross@suse.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <1633974539-7380-1-git-send-email-olekstysh@gmail.com>
 <1633974539-7380-2-git-send-email-olekstysh@gmail.com>
 <24933.42667.311553.565032@mariner.uk.xensource.com>
From: Oleksandr <olekstysh@gmail.com>
Message-ID: <60541d52-4b44-e212-cc06-bb41e9ce67f9@gmail.com>
Date: Tue, 12 Oct 2021 18:48:09 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <24933.42667.311553.565032@mariner.uk.xensource.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US


On 12.10.21 18:15, Ian Jackson wrote:

Hi Ian

> Oleksandr Tyshchenko writes ("[PATCH V6 1/2] xen/arm: Introduce gpaddr_bits field to struct xen_domctl_getdomaininfo"):
>> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>>
>> We need to pass info about maximum supported guest physical
>> address space size to the toolstack on Arm in order to properly
>> calculate the base and size of the extended region (safe range)
>> for the guest. The extended region is unused address space which
>> could be safely used by domain for foreign/grant mappings on Arm.
>> The extended region itself will be handled by the subsequent
>> patch.
> You say "to the toolstack", but you are exposing this information up
> to callers of libxl.  Do you mean some higher-layer toolstack that
> uses libxl ?  What does it use this information for ?
>
> FTAOD I am not opposed to exposing this in this way; indeed it seems
> likely to be useful.  I just want to fully understand before I give
> this my tools ack.
I didn't mean any higher-layer toolstack, sorry if I was unclear. In the 
first place this information is
needed by the entity which generates the device-tree for the guest on 
Arm (tools/libs/light/libxl_arm.c) to properly calculate the extended 
regions to be inserted into the hypervisor node.


>
>> +        info->gpaddr_bits = domctl.u.getdomaininfo.gpaddr_bits;
> I'm pleased to find that this is not arch-specific.
>
> Thanks,
> Ian.

-- 
Regards,

Oleksandr Tyshchenko



From xen-devel-bounces@lists.xenproject.org Tue Oct 12 15:49:31 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 15:49:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.207481.363335 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maK1u-0005wh-QP; Tue, 12 Oct 2021 15:49:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 207481.363335; Tue, 12 Oct 2021 15:49:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maK1u-0005wa-NR; Tue, 12 Oct 2021 15:49:26 +0000
Received: by outflank-mailman (input) for mailman id 207481;
 Tue, 12 Oct 2021 15:49:25 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=/4YK=PA=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1maK1s-0005wU-V7
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 15:49:24 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id f85e38fc-2b73-11ec-813c-12813bfff9fa;
 Tue, 12 Oct 2021 15:49:23 +0000 (UTC)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2112.outbound.protection.outlook.com [104.47.18.112])
 (Using TLS) by relay.mimecast.com with ESMTP id
 de-mta-20-Unnj1PnNNVakk-TOr-Iw-g-1; Tue, 12 Oct 2021 17:49:21 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB4349.eurprd04.prod.outlook.com (2603:10a6:803:40::27)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.19; Tue, 12 Oct
 2021 15:49:20 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4587.026; Tue, 12 Oct 2021
 15:49:20 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM7PR03CA0022.eurprd03.prod.outlook.com (2603:10a6:20b:130::32) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.25 via Frontend
 Transport; Tue, 12 Oct 2021 15:49:19 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f85e38fc-2b73-11ec-813c-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634053762;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=A8WZ82IlWMAXJKyhCrciJUxbLB/jlI/lyslnFBdBxA4=;
	b=X/x9kNFCrVPRZAFlP8bVwpbzyski2G10hujn0tS2jZw65sUiB44q8Yc5Ws2pFIj9LLIUj9
	B1x6OGiIzu89KC5oEjJzjlrEfyLWzqqD9cy0zUyZBe/ztUENLiyzBwP8s9J2Q8Vr0KVHlK
	wTG2v1Xp1uIIDtq9JhCSwA6b5k/Y1Lo=
X-MC-Unique: Unnj1PnNNVakk-TOr-Iw-g-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=FBES8Y8yt+IBwJ9GFVX5FvQxDE18yQIVLSyD5I75r3OER90Zz/wIOj09uED4Ud5snU855zdErpWjNcJfmZUAFf6fz63dZFuJ5WDZWavsGWhXSukXbya/jSf9vC/5uy8V88fotqkJtXQ92tinRkYmsSh63ysO3oMbUReW4sxQAWuPUsojsQQ+r7EWBSmO8doxCL0+c9qC8t0wMHnqPLPT10oC7SIjMEyN0Z2wYLQqI1dDIRrVggvO4sKtrUc0JUzRMyjm4lW6SewJ5Oa3FyyaoxKvD/CnNElnEex2qAejIu4KD2Z5vJ+fe/D2n7P+vx5ALHq3aFkMV+CPlnp+N6DGlg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=A8WZ82IlWMAXJKyhCrciJUxbLB/jlI/lyslnFBdBxA4=;
 b=fpe3joyn/3l2+Qh4HLGLRvNUdxWU97Ln9jsPteEFJmZI0PJH0bD7095oC8rHaVrbwYaugr32wbdAAgt5n17uoy1wnPKNn+4TsOMTcfy4jmMTQxmUA8pnwNtNmNNaG4S8Mf8ixXzNosasmktfHqrvOTb1QelQ4th5t04cuH08W0nuxc3lX3VudglMBKKAN0AjRESwOEStj5hK/HPdn/0xQpkeWKTJIDnBakzWDtc7TwZBiE2ds99ZThqpntV0oFfBxm/DlL6Kt8q1XIAHytsHJlXoezuTtZL7I2c0TdGpSSqqkIqSVS8Y7j1ZGJqOjSrcJxnvdf1eP7lGYX0O0KCdww==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [PATCH xen 2/2] xen: update system time immediately when
 VCPUOP_register_vcpu_info
To: Dongli Zhang <dongli.zhang@oracle.com>
Cc: sstabellini@kernel.org, andrew.cooper3@citrix.com,
 george.dunlap@citrix.com, iwj@xenproject.org, julien@xen.org, wl@xen.org,
 joe.jin@oracle.com, xen-devel@lists.xenproject.org
References: <20211012072428.2569-1-dongli.zhang@oracle.com>
 <20211012072428.2569-3-dongli.zhang@oracle.com>
 <317163fa-f736-ccfe-40d4-b918ce2834f9@suse.com>
 <3e16648f-088d-5f62-03d7-ca744e913cbb@oracle.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <8b31045b-dbb0-3ca1-074e-a12107b09159@suse.com>
Date: Tue, 12 Oct 2021 17:49:18 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <3e16648f-088d-5f62-03d7-ca744e913cbb@oracle.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM7PR03CA0022.eurprd03.prod.outlook.com
 (2603:10a6:20b:130::32) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 96214f0c-b509-432f-13d0-08d98d97db08
X-MS-TrafficTypeDiagnostic: VI1PR04MB4349:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB4349E1228CAE1BA8F5E11412B3B69@VI1PR04MB4349.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6790;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	ZTU6FLLIY0ddQgH6KFAEYUMUHNMlxkSJDXHYWFCTGw+2mrwt3GqM7+TTQ++KfCTD5gAfX0SUvKlWG5ahiaWpFDQnJZd9xKY9sukOrnRudObJhZ/scn3lhiEPpbPHDZUS2Gshbn8SD9S2/1iUv4lMDS9UdzMrhyoEma+/yhqPON6j09aQg16Wv94+6tKyVR4w0nu4ooCWvdl0nR0+6zS982rvMs+EUAIIV8CqlJ4uLu5E0+tyv9yBZKbrEhg1kvMnY7ZAVwqS5kdQt9auY5bZmkj0D3mdy58Js9+Kh4DXqBlmfHKwhTtW4ipTNnLCLbO3vL5SVC50st5z9SjDvHjl7/dRUf0WmfFbSoE44XIEb+IxDg4HxJYp9a2EhSndvJxC9g2SmBe+pGqZHWoAGt3EYq5ll+Pp3qsAjFBk1JmcFMU9Gndh0RQXd6wXd12IJ0SZfeBSuQ5Kr5NPbnxVTlCctrhFZDckK8xqcuzmrXDtkpQqDZgj1kLkyk0j9aip6TgI8P93GNZTnE1x7mP+AtNOi+Zz5n/pJ7A9ey6ooWqe5/rq4n7SGG1l2ndOzKziRgMQ3LPgdKp5pXC5R4ZX38J9eYPcWs/TxZS2vlX+s1iaVjlbupoQSjKvv0iZfljb/HgiUVM0mYYC1azl4LE+yx+09ub+b6PC1SOuAyBY/a781SiAZ4RgcMURDj1MfyfVY4B9uxbV2v54vkihNwbY/bvZPGoN3rY/UOVL/hsfocMJd1/VuQge6PDRIGDCn26XiH5dwLjqFEfQIPCbpON2XOEMNw==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(186003)(956004)(8936002)(15650500001)(508600001)(5660300002)(6916009)(2616005)(66556008)(6486002)(16576012)(36756003)(26005)(31686004)(66946007)(66476007)(31696002)(38100700002)(53546011)(8676002)(83380400001)(316002)(4326008)(86362001)(2906002)(14773001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?bzYyaEFsekVvSGRZRUNCSlFjTnpQRWl2Y2J6TVBpclZtRHhyeC9mUnR4S2ds?=
 =?utf-8?B?TTBIV0lMRkVwczdDNTVpQ0tIUm5FUytnNUxXSjJpY0lmUFZnc3FXVm5DQUh4?=
 =?utf-8?B?TXJoOXJTN2JlVHZaaVYvNXlnNnluaDRIM2h0Z1I2UVNHdUZZVVRURGQyNStH?=
 =?utf-8?B?MWE1MmdOeW1YUElkWUhpT3hVcWtqVzkvTjNibjNyZEowa1BWcnZOelRuZ1Qz?=
 =?utf-8?B?OXF5Yk12QU43K0hCVXJxR2JGNkFmUXVBSXhpYzFNYzdGVDNlRVRSOHljR0o3?=
 =?utf-8?B?WElDUVhPbUVWZmZQNkVPMTJMYUhGZ2xURmdnV3c1V1haN3JUMVhCQ2Z5SDR1?=
 =?utf-8?B?RHlaT3ROZ25pbkdtcXd6aG1lREFzbzk1YnJsenpRdXpBdUhlaDhueXhHbnh2?=
 =?utf-8?B?c1o4U0dWMVppZzB1ZHhnTEFCRm9hcTk3MlZ1U2ZZRHo5M282enlkelcyRGNJ?=
 =?utf-8?B?dDNQVDEvUGFBQ2xYSENYTStwVDJNRlhTWWQ5alNFd1I2MUlyeXl5ZHVUS282?=
 =?utf-8?B?YlRhVC9xNDA4aHpwNzZmaFBtdndKbjE2bDBZM01mNHFSTXVKR1hYNmxKS3J1?=
 =?utf-8?B?NUk2VEZZU0hiWGJHaDFrSHZmQy9adUViUHk1a28wdWhkb1ovQm9HYksya2Fs?=
 =?utf-8?B?RkYvK0E4d2ZNV0JmYzc0S0tEUEI3U2ZOcGlyNXVXOFE1YktlUXFQM2xqQXBj?=
 =?utf-8?B?eGNVbGl2elVyNU5QWVg0bXpKYkF3RStqQTl3WFVDOXF2RlhPQWdsdE5SbFJI?=
 =?utf-8?B?NjNsekI1VzkrdzlGMTNDSVN6bjNKTDBmM0MvTVdlalFCWFdiR3JYVzRPaHJp?=
 =?utf-8?B?VHQ0VmNhVmNqRjNPREhhOGhLcjdiT0xDZklsMkR0dmNNSUtrcE1kYVV3QklG?=
 =?utf-8?B?K2QrZU9nRkt6SkhjTEJLUzN3YmpWYjlnT0RkM1NHNHhwMVFwTmVuQXcxVDdD?=
 =?utf-8?B?YTRVVDhHV0d6UmNsM3dzYmExbTlhdUZueGRkWkVTeUVJV2FhUXJuVE5HZjYx?=
 =?utf-8?B?SWxlVTVPdzBzTWx3MWRPQ0xjQ3JZWVFwbHV4QWJYcWVpZFplYVVSTWxrUkdo?=
 =?utf-8?B?NkJTMUxjUU8zWm01bWFMcnUzcFNnazF2ZG1xa2VEai9Qc0lHcUo5eE1UaGdO?=
 =?utf-8?B?OXJNODVrNmNTSEFvbGVoRGRSVEVlTXZzYVJlMy9iNjM1Ymg0dnRJQzQrMlZn?=
 =?utf-8?B?d2g3NFlWMFZ6Z1Yzc3BMaTAraFpTdWJPYmZUZXA0Zm9RbGNta1VGNUtDUktx?=
 =?utf-8?B?WGd6OUswc1VnTVpoVUxMdlFFamJXTHArRWVTS010VG51cm4vR3h4Z1Q1dS9j?=
 =?utf-8?B?eUVIYzBaTUg0VkFzT2RNeUIxcG9UR3kyOHN3ZzRUbjkvS0VQcmhQL3NqaFpL?=
 =?utf-8?B?NUlad2RYKzZaSkJ6bnI0TVd0ZHd0dTlFT0VwZzRZSllUSExFdktOdHA3QlVV?=
 =?utf-8?B?K25keWsxRHgxeDRRQmVVY2VyYjV6M3NMc2IzZXhQeWJRVCtxQzRac2FSa2FI?=
 =?utf-8?B?eFZtVk1TVm1sQmUxbi9HelZLSEVtdlpYQVJhWGp3WjF1WGRITzNEeElxVTZa?=
 =?utf-8?B?bUtNUDNibHErYURsaHRJMVZ3aUtod1Q3SXlMaUlDMWhnbzFud1M2NGtnY20r?=
 =?utf-8?B?aWQ5eGhNSko4dkJSdW1EcVp5emJYbUlvSWNydE9ncVg0TGNTM3ZRNXp1cTFK?=
 =?utf-8?B?TkN1clhCWFJEYTZOOThRWE9LTVc2TXhveTg4YnZLYWFyK2dlZWFtSHJOdmpB?=
 =?utf-8?Q?UFz4XNHZYlOb2nznf419NOltmHgT57A8PnQH0oD?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 96214f0c-b509-432f-13d0-08d98d97db08
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2021 15:49:20.4923
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: TCe2/F5V+XNOX39KmzVNKlL1gWttKGGYyKcn/miSPPvIC9rBoTrGxdAEp0wR27wN9ntQs0ZH6X3SKuAmWM+l/A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4349

On 12.10.2021 17:43, Dongli Zhang wrote:
> Hi Jan,
> 
> On 10/12/21 1:40 AM, Jan Beulich wrote:
>> On 12.10.2021 09:24, Dongli Zhang wrote:
>>> The guest may access the pv vcpu_time_info immediately after
>>> VCPUOP_register_vcpu_info. This is to borrow the idea of
>>> VCPUOP_register_vcpu_time_memory_area, where the
>>> force_update_vcpu_system_time() is called immediately when the new memory
>>> area is registered.
>>>
>>> Otherwise, we may observe clock drift at the VM side if the VM accesses
>>> the clocksource immediately after VCPUOP_register_vcpu_info().
>>>
>>> Cc: Joe Jin <joe.jin@oracle.com>
>>> Signed-off-by: Dongli Zhang <dongli.zhang@oracle.com>
>>
>> While I agree with the change in principle, ...
>>
>>> --- a/xen/common/domain.c
>>> +++ b/xen/common/domain.c
>>> @@ -1695,6 +1695,8 @@ long do_vcpu_op(int cmd, unsigned int vcpuid, XEN_GUEST_HANDLE_PARAM(void) arg)
>>>          rc = map_vcpu_info(v, info.mfn, info.offset);
>>>          domain_unlock(d);
>>>  
>>> +        force_update_vcpu_system_time(v);
>>
>> ... I'm afraid you're breaking the Arm build here. Arm will first need
>> to gain this function.
>>
> 
> Since I am not familiar with the Xen ARM, would you please let me your
> suggestion if I just leave ARM as TODO to the ARM developers to verify
> and implement force_update_vcpu_system_time()?

I'd much prefer to avoid this. I don't think the function can be that
difficult to introduce. And I'm sure the Arm maintainers will apply
extra care during review if you point out that you weren't able to
actually test this.

Jan

> I have tested that the below can build with arm64/aarch64.
> 
> diff --git a/xen/common/domain.c b/xen/common/domain.c
> index 40d67ec342..644c65ecd3 100644
> --- a/xen/common/domain.c
> +++ b/xen/common/domain.c
> @@ -1695,6 +1695,13 @@ long do_vcpu_op(int cmd, unsigned int vcpuid,
> XEN_GUEST_HANDLE_PARAM(void) arg)
>          rc = map_vcpu_info(v, info.mfn, info.offset);
>          domain_unlock(d);
> 
> +#ifdef CONFIG_X86
> +        /*
> +         * TODO: ARM does not have force_update_vcpu_system_time().
> +         */
> +        force_update_vcpu_system_time(v);
> +#endif
> +
>          break;
>      }
> 
> 
> 
> Thank you very much!
> 
> Dongli Zhang
> 



From xen-devel-bounces@lists.xenproject.org Tue Oct 12 15:50:46 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 15:50:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.207491.363346 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maK3A-0007MU-96; Tue, 12 Oct 2021 15:50:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 207491.363346; Tue, 12 Oct 2021 15:50:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maK3A-0007MN-5X; Tue, 12 Oct 2021 15:50:44 +0000
Received: by outflank-mailman (input) for mailman id 207491;
 Tue, 12 Oct 2021 15:50:43 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=kpIn=PA=oracle.com=dongli.zhang@srs-us1.protection.inumbo.net>)
 id 1maK38-0007MG-UJ
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 15:50:42 +0000
Received: from mx0a-00069f02.pphosted.com (unknown [205.220.165.32])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 668a8207-cbc8-4cc6-ba18-9c0c1cdb6828;
 Tue, 12 Oct 2021 15:50:40 +0000 (UTC)
Received: from pps.filterd (m0246627.ppops.net [127.0.0.1])
 by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 19CFdSos007580; 
 Tue, 12 Oct 2021 15:50:26 GMT
Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70])
 by mx0b-00069f02.pphosted.com with ESMTP id 3bmpwn94ff-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Tue, 12 Oct 2021 15:50:25 +0000
Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1])
 by aserp3020.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 19CFijcJ179977;
 Tue, 12 Oct 2021 15:50:23 GMT
Received: from nam10-bn7-obe.outbound.protection.outlook.com
 (mail-bn7nam10lp2101.outbound.protection.outlook.com [104.47.70.101])
 by aserp3020.oracle.com with ESMTP id 3bmady7hmu-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Tue, 12 Oct 2021 15:50:23 +0000
Received: from BYAPR10MB2663.namprd10.prod.outlook.com (2603:10b6:a02:a9::20)
 by SJ0PR10MB5802.namprd10.prod.outlook.com (2603:10b6:a03:426::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.22; Tue, 12 Oct
 2021 15:50:21 +0000
Received: from BYAPR10MB2663.namprd10.prod.outlook.com
 ([fe80::2848:63dc:b87:8021]) by BYAPR10MB2663.namprd10.prod.outlook.com
 ([fe80::2848:63dc:b87:8021%7]) with mapi id 15.20.4587.026; Tue, 12 Oct 2021
 15:50:21 +0000
Received: from [IPv6:2606:b400:400:7446:8000::222] (2606:b400:8301:1010::16aa)
 by SN7P222CA0026.NAMP222.PROD.OUTLOOK.COM (2603:10b6:806:124::24) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.14 via Frontend
 Transport; Tue, 12 Oct 2021 15:50:19 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 668a8207-cbc8-4cc6-ba18-9c0c1cdb6828
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc :
 references : from : message-id : date : in-reply-to : content-type :
 content-transfer-encoding : mime-version; s=corp-2021-07-09;
 bh=GqoEQgM92S5KZfr+Vi0Py8JU3W6d7rK+lHKptgGwVbc=;
 b=HQMSM6Zq7F/LFDpA6lLflWEBZgXoVdehF8gXW9MKggRdH/mUWlcQCDJkmPCyzSqxutJL
 2hnhT5zvsV900pHZMYkibDC+P7ks/yq+GL3XYYvGvDcRKKfF/gB7B4NWAbXZvFh8uJvL
 FG8lDA1A9Ho0XIVrMlMDJiIHhzlaR9oGcgYpyoFJ47kz0m+VesnlbxrVYDB9ave/Gg3f
 0ZH7+dIMD3hOQVyg70ApUTenpCMKIm9qlABp+uEStAlSPIezfTJLIuF+evgROjr1ENnL
 x7kvrOC2Hc+gtECdCONz9F+yXgx/M4iNUTWMxxMkQs0l54VSnZIQ+zPJy/bIYkCrHHur 5A== 
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=GG/e2R1kjq5G1IlTWetIgvSP2aY51Cf/gFXF1CcnruCYDMubGjmFjIY02jS/+xxIN+9cGXf8R2JYhAkbQEuKxbcbIe5PkjRU6W4Awa6QOAUZ67/8rRE7o506JrNNGJ0JXwr9tFfjUh3cUvZ/C/ct6G8/sNmxsZwRC07RArPA1x9C3XA3reJcJswB/vZeJ5xl8e8bPLnJd+q9eP+RyvkoLzWgrIWwqRpOMNc+wuQPzSE+KrMyHwMZiZXi1oKZ0HKtcFfOHNp/1xJ6S8Md1GXeAdUZlebUpaSs8NqxV5gWDXjfWSaJiDyK6SDeuwpqB3FlMihyNt2bPln+hjy7uJCjVQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=GqoEQgM92S5KZfr+Vi0Py8JU3W6d7rK+lHKptgGwVbc=;
 b=VSj4QcrNdwCHMPW1nSShZnSWBHqqlCESg5a3T2atRqXb4We2RmXMqwQN2VdmX4h/qnvfNaNGn6zqrMSgZealixV2OdSHrrFkbnGnrAFXY/pGjgcuw2hGJw8Skrngfwl63wUUQ4Gq55APtNjv66rrdFNEiYmv3wZF5aw7xG/4Dqq/FJGjlKUFNFXZTB7Zq9zEgPhX9a8exPY5eEjJLHmqR7ZNv3A9dzmb5HZOgEPf77gBOc503A4893+ECoKq9689ykb2jJT9daFscSixDaXXHtkqAd8HUBGnpe8OyPdC0/4cwHNvw1jBCWeO1eZfccWNL3tFZbk8ee8pVD3IMftXUw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com;
 dkim=pass header.d=oracle.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=GqoEQgM92S5KZfr+Vi0Py8JU3W6d7rK+lHKptgGwVbc=;
 b=yqkktoAi7kwvnN/GQUJ2zd04z8faUUDLvPubsAm3x19pEXe9681JxfpMZhuWU1rBOz8KG1iqJB3s6lban/J/FFMOYUrRSVtFMcyNZgK0JtKSGBP32wlK8zR3+OaSZx04PL5SqIC12xirEZXS2zpK00nkpMRjkrSSuEqzi8u9of8=
Authentication-Results: oracle.com; dkim=none (message not signed)
 header.d=none;oracle.com; dmarc=none action=none header.from=oracle.com;
Subject: Re: [PATCH 0/2] Fix the Xen HVM kdump/kexec boot panic issue
To: Juergen Gross <jgross@suse.com>, xen-devel@lists.xenproject.org
Cc: linux-kernel@vger.kernel.org, x86@kernel.org, boris.ostrovsky@oracle.com,
        sstabellini@kernel.org, tglx@linutronix.de, mingo@redhat.com,
        bp@alien8.de, hpa@zytor.com, andrew.cooper3@citrix.com,
        george.dunlap@citrix.com, iwj@xenproject.org, jbeulich@suse.com,
        julien@xen.org, wl@xen.org, joe.jin@oracle.com
References: <20211012072428.2569-1-dongli.zhang@oracle.com>
 <cb2e1a63-de79-5050-bf2b-bfb302997381@suse.com>
From: Dongli Zhang <dongli.zhang@oracle.com>
Message-ID: <2794895b-6417-7164-8417-0f1edc52ae10@oracle.com>
Date: Tue, 12 Oct 2021 08:50:17 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.6.1
In-Reply-To: <cb2e1a63-de79-5050-bf2b-bfb302997381@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: SN7P222CA0026.NAMP222.PROD.OUTLOOK.COM
 (2603:10b6:806:124::24) To BYAPR10MB2663.namprd10.prod.outlook.com
 (2603:10b6:a02:a9::20)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: f9e7cf76-097e-473e-31ab-08d98d97ff46
X-MS-TrafficTypeDiagnostic: SJ0PR10MB5802:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: 
	<SJ0PR10MB58020A0532ED55EF31CAB15DF0B69@SJ0PR10MB5802.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7219;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 
	YKwHhxg6MZnkr9oPMFIjRTia5rmkmeA5u9xZPdYmcyt0SnVIQd+JNOHEIDH/jPcSJyHXE2iPWgBBMsgZD+mCqFli5SxAXp9SlBdLlIxnGf7XlkVWlFBm/XSLTh8HIky+QraTQ7SMre8xOeicum5dIHBJ9KZE9vc/OyurcxCHk96BLlhC5/1dp1bcXLe7VWpJIPOahNO29jeQ/o97iZOOF7LAb+X7asWoinSoKDpjsXeOZPprXK3j1eNb7yKi0dWSB7dyDG11Hx1pjJWPVSyxcnRlMEu6DrMlWCBaxKgU3Lw40uRGeRHPx6LhGX0jtH19mVj9I60cPRV85kUtc4gcv6IOv0rI5uN7aeDTb8IdP+ehotK1cIRX0lqmZ8hh3mv5SJoCpQMDaFuoYmtZNWaS40yX9ayKNWQbomRr4pG2PGVe5CGkxt7QWZ9rM9Uba9d/k4iIyBXMSiV6qsY4AjPjou7m/EKAhv+PIVk2ScaYaJk7F6wS79aNTJDJK03IdXEXB77TgRsDGjhAf/L+JgzQXnY+90higmFtLroDJNNl4SIbzKJ1aLYTt4ybnz3w7DxU2k5T50tm6mtYfWUhx3dHDOc3q+BJYsXIrPG91ZnmgujOciTc0Xodfoqrdh7uimpYN5YLQK6c5E+FIFultHgY5WjXc4Rld9ewYvyOAZU2E1lFAYkyEcVdRUznGc4pSdHpK2pwbY/fH4BfLrsHbY1YsOC7fkE0uhiT5fBWSzPjKb2TbPJnLOrh+ao1PejsxWed
X-Forefront-Antispam-Report: 
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB2663.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(186003)(66556008)(2906002)(8676002)(6486002)(31696002)(36756003)(4326008)(38100700002)(31686004)(107886003)(66946007)(508600001)(7416002)(53546011)(44832011)(83380400001)(66476007)(5660300002)(8936002)(86362001)(316002)(2616005)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?V1NxTkxSYW1iVWJQQnpwNk1YYjNFYlQyWWZIblR0U0tmNFJEMXFPUm5wY2dq?=
 =?utf-8?B?R2l5T1lLYWNhYlA1SXhHait2Z3Bqbk4zakdTakpkUVpXaWJsZ2plOXhxVzlP?=
 =?utf-8?B?bWxaU3AyQ2N5emxXU3ZoMFc3eDBaelJobGFBM0FSVDI1Ly9ob0tSL21ScDR5?=
 =?utf-8?B?NXVuMWtFc0hqczJpcDJzYVhFVUUvVmNQcEdJUUQ2TFBESld0M3FSUGlGeCs4?=
 =?utf-8?B?V0pqak90TWxxUzYwUUJkSmxGZFFyWkQ2SUNDT3lPWE9iY2RoN3B0b2llV0JM?=
 =?utf-8?B?MkFMV28vd0ZVMExtbmprNytqcU1LRWJyUHhIYlhDQWdVZ2pPRUNNNXVCdmxk?=
 =?utf-8?B?NTFYS0lrbngzNCtKUjlZSnl5ZSsvYjRZeE8vbzJKc08xNGxEV0ZPZWtxc1ZD?=
 =?utf-8?B?QWR3ZlNNSkRwSmZnZkFGejViLyt1NkxQcnE4RUlDSHJQRGZzcVhSaXRaRkFS?=
 =?utf-8?B?VUdUeVhxMkZJd0xuM05mK1RrQUsrSnZGeXMrOVNoTlIxYVpXU01GRld0WmFK?=
 =?utf-8?B?c2M2UGRGNW92U2hsa0FkdVQ2eDFHdHBDd05vWGxKV1BCZ09uQjVvb0Zwd21C?=
 =?utf-8?B?Z2gzbktOTWR0UDZrdTIxODdGeDk5SkFIaEdJeWkvSnBvWlMxL3BpQ1dsUi9r?=
 =?utf-8?B?S0hQckZ6eEhQVENvNnZVeTAvQ1ozbmk0cWlEUXJiTVB0OXgyYlhWMkUxcVFE?=
 =?utf-8?B?aXYzWUJaeTc1em9RTlFqQlBUY0hlbXRKQWY5SUhuc1JvNWNqVllVVDE2QnFS?=
 =?utf-8?B?L3NFUmorT3lOTWhobXAxVUpYbUYyUmJpZzZPSFp3VE5GZmt6emozUHU5c0lU?=
 =?utf-8?B?UEFDVlVHWWZRN3B1eXVpaEIxUFZOZUhIK2NBWTBWeWtaUWR4OGZ6ZlRma2xK?=
 =?utf-8?B?cTVkVEhhNkRwenlSSVRPSjM4L01jSWp4UndPc3pUbW5KaDdtdXdJZ2V2L01h?=
 =?utf-8?B?dEtDYXRKaXF6M0FtM09hb3hNTkQ4YXZLVSs5U3k3OG5obVRCRC9uS2RKS3dT?=
 =?utf-8?B?Z3cxWVBLL3M2STJWaUxUN0loTmIxSndMKzBEZ0wvNGFHRk9YcjRFNi8waVAy?=
 =?utf-8?B?QmZnS2hKL1JWb09QYW5PamtkandZcnQvRUNwbUI5UUhVbGt4YkY4ajVDNU5M?=
 =?utf-8?B?clJuTGZTc0dMbnZZTms2LzRxVEFFL0FWY0lsdkMwOGo1WmlzWHFBc083RzQ2?=
 =?utf-8?B?VGUvUSs3OGxPVnZMeUZYbHExOENSZkp6K0Z4NnNsaitLa2Y4Z0l0WmNEbzJ5?=
 =?utf-8?B?MjVrOFZiUk40WXhHR0NmcFN4bG1vdFNLVnRuWjY1Lys0bjJHVFVBOW5mV3hF?=
 =?utf-8?B?N0hpZ3kvU1VMaTdleFl6RXdoZzlaWUFoTFZEODd6VFNBZXQ0eUltYU9XYVRs?=
 =?utf-8?B?cXRxcDBQb0lnVy9qRU5yZEVpUUJXZXRCSDBMSzUvY1FpV3o0M2p6eWpHcDVZ?=
 =?utf-8?B?WlQ0aFM1RUpGZlliQUlEbnlId3FXbk9FR3dIL2dGZWdDRWIvSjdIWDAwUWpu?=
 =?utf-8?B?eVhHMGE2OUEwTXNxN0pGVXZDM0hYcEUzbk8zNVJaUGFScEQybUxTL3Q2ZW1i?=
 =?utf-8?B?Z3Vud2M5VmE2TEJFcnR6SDJwbiswcHpnUU5SOEp2OFI0eGxsZWFGcC9Xbmtt?=
 =?utf-8?B?RFk3TTFWV2Y3NTc0c2pUcWFCZDhUano2WStxSEpocVRQdWJZQ1NtMEROa1F2?=
 =?utf-8?B?VXh3TktkTXdRejU0L1FwTnE2U250dWYrTnp3Z2Y1cmFRNys2L3FLb2I3YTBH?=
 =?utf-8?B?SU5RU3g3eVEvWlhIVTNSTFNFR1FyVEg2dzhEc2dpank2N1ZHeENLUndlY08r?=
 =?utf-8?Q?oLx2X3Iaoe1y+GQc1TzZepnvLeTUErlSPaTEs=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f9e7cf76-097e-473e-31ab-08d98d97ff46
X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB2663.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2021 15:50:21.4742
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 3rZwxwpPegd7Em1Yb52/IYzQeeyPOfzULvNsdO/uLXzk/m5xXwRyfPZPshC+Df7iU59B3qAdNJIcds1qe4rtBg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB5802
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10135 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 phishscore=0
 suspectscore=0 mlxlogscore=999 bulkscore=0 mlxscore=0 malwarescore=0
 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2109230001 definitions=main-2110120088
X-Proofpoint-GUID: 9ar5uwnedwp_u-K97u1JLQMijareiRop
X-Proofpoint-ORIG-GUID: 9ar5uwnedwp_u-K97u1JLQMijareiRop

Hi Juergen,

On 10/12/21 1:47 AM, Juergen Gross wrote:
> On 12.10.21 09:24, Dongli Zhang wrote:
>> When the kdump/kexec is enabled at HVM VM side, to panic kernel will trap
>> to xen side with reason=soft_reset. As a result, the xen will reboot the VM
>> with the kdump kernel.
>>
>> Unfortunately, when the VM is panic with below command line ...
>>
>> "taskset -c 33 echo c > /proc/sysrq-trigger"
>>
>> ... the kdump kernel is panic at early stage ...
>>
>> PANIC: early exception 0x0e IP 10:ffffffffa8c66876 error 0 cr2 0x20
>> [    0.000000] CPU: 0 PID: 0 Comm: swapper Not tainted 5.15.0-rc5xen #1
>> [    0.000000] Hardware name: Xen HVM domU
>> [    0.000000] RIP: 0010:pvclock_clocksource_read+0x6/0xb0
>> ... ...
>> [    0.000000] RSP: 0000:ffffffffaa203e20 EFLAGS: 00010082 ORIG_RAX:
>> 0000000000000000
>> [    0.000000] RAX: 0000000000000003 RBX: 0000000000010000 RCX: 00000000ffffdfff
>> [    0.000000] RDX: 0000000000000003 RSI: 00000000ffffdfff RDI: 0000000000000020
>> [    0.000000] RBP: 0000000000011000 R08: 0000000000000000 R09: 0000000000000001
>> [    0.000000] R10: ffffffffaa203e00 R11: ffffffffaa203c70 R12: 0000000040000004
>> [    0.000000] R13: ffffffffaa203e5c R14: ffffffffaa203e58 R15: 0000000000000000
>> [    0.000000] FS:  0000000000000000(0000) GS:ffffffffaa95e000(0000)
>> knlGS:0000000000000000
>> [    0.000000] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
>> [    0.000000] CR2: 0000000000000020 CR3: 00000000ec9e0000 CR4: 00000000000406a0
>> [    0.000000] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
>> [    0.000000] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
>> [    0.000000] Call Trace:
>> [    0.000000]  ? xen_init_time_common+0x11/0x55
>> [    0.000000]  ? xen_hvm_init_time_ops+0x23/0x45
>> [    0.000000]  ? xen_hvm_guest_init+0x214/0x251
>> [    0.000000]  ? 0xffffffffa8c00000
>> [    0.000000]  ? setup_arch+0x440/0xbd6
>> [    0.000000]  ? start_kernel+0x6a/0x689
>> [    0.000000]  ? secondary_startup_64_no_verify+0xc2/0xcb
>>
>> This is because Xen HVM supports at most MAX_VIRT_CPUS=32 'vcpu_info'
>> embedded inside 'shared_info' during early stage until xen_vcpu_setup() is
>> used to allocate/relocate 'vcpu_info' for boot cpu at arbitrary address.
>>
>>
>> The 1st patch is to fix the issue at VM kernel side. However, we may
>> observe clock drift at VM side due to the issue at xen hypervisor side.
>> This is because the pv vcpu_time_info is not updated when
>> VCPUOP_register_vcpu_info.
>>
>> The 2nd patch is to force_update_vcpu_system_time() at xen side when
>> VCPUOP_register_vcpu_info, to avoid the VM clock drift during kdump kernel
>> boot.
> 
> Please don't mix patches for multiple projects in one series.
> 
> In cases like this it is fine to mention the other project's patch
> verbally instead.
> 

I will split the patchset in v2 and email to different projects.

The core ideas of this combined patchset are:

1. Fix at HVM domU side (kdump kernel panic)

2. Fix at Xen hypervisor side (clock drift issue in kdump kernel)

3. To report (or seek for help) that soft_reset does not work with mainline-xen
so that I am not able to test my patchset with the most recent mainline xen.

Thank you very much!

Dongli Zhang


From xen-devel-bounces@lists.xenproject.org Tue Oct 12 16:05:50 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 16:05:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.207504.363357 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maKHh-00010m-FX; Tue, 12 Oct 2021 16:05:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 207504.363357; Tue, 12 Oct 2021 16:05:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maKHh-00010f-Cc; Tue, 12 Oct 2021 16:05:45 +0000
Received: by outflank-mailman (input) for mailman id 207504;
 Tue, 12 Oct 2021 16:05:43 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1maKHf-00010Z-Rt
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 16:05:43 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1maKHe-00058k-Mg; Tue, 12 Oct 2021 16:05:42 +0000
Received: from 54-240-197-233.amazon.com ([54.240.197.233] helo=[192.168.23.5])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1maKHe-00007G-Fk; Tue, 12 Oct 2021 16:05:42 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=L4t+9xpTd/dcPIZm+BKkvk+NafIodciLgc7qdUMulrw=; b=Wn+HdUhes0SAzsspYQSprpFn6n
	dpHzvy2TPUHoVCNtrrno7YFWjga81VAOSMzNDupJvMcCQj+u4mef/16rxGIMpGaS9ozCpZiaZDk9B
	+Qw08wmgg5L8/OyCFMnaeV+BJ++Eu5bX+5BWAUSMo5+YetThJd3Yxd6VAcaWmFftPnI0=;
Message-ID: <c98c1acd-86c0-f556-643e-e472b696644f@xen.org>
Date: Tue, 12 Oct 2021 17:05:40 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.2.0
Subject: Re: [PATCH V6 2/2] libxl/arm: Add handling of extended regions for
 DomU
To: Oleksandr Tyshchenko <olekstysh@gmail.com>, xen-devel@lists.xenproject.org
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>,
 Anthony PERARD <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <1633974539-7380-1-git-send-email-olekstysh@gmail.com>
 <1633974539-7380-3-git-send-email-olekstysh@gmail.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <1633974539-7380-3-git-send-email-olekstysh@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Oleksandr,

On 11/10/2021 18:48, Oleksandr Tyshchenko wrote:
> ---
>   tools/libs/light/libxl_arm.c  | 76 ++++++++++++++++++++++++++++++++++++++++---
>   xen/include/public/arch-arm.h |  2 ++
>   2 files changed, 73 insertions(+), 5 deletions(-)
> 
> diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c
> index e3140a6..c0e8415 100644
> --- a/tools/libs/light/libxl_arm.c
> +++ b/tools/libs/light/libxl_arm.c
> @@ -598,9 +598,20 @@ static int make_timer_node(libxl__gc *gc, void *fdt,
>       return 0;
>   }
>   
> +#define ALIGN_UP_TO_2MB(x)   (((x) + MB(2) - 1) & (~(MB(2) - 1)))
> +
>   static int make_hypervisor_node(libxl__gc *gc, void *fdt,
> -                                const libxl_version_info *vers)
> +                                const libxl_version_info *vers,
> +                                const libxl_domain_build_info *b_info,
> +                                const struct xc_dom_image *dom)
>   {
> +    uint64_t region_size[GUEST_RAM_BANKS] = {0}, region_base[GUEST_RAM_BANKS],
> +        bank1end, ramsize;
> +    uint32_t regs[(GUEST_ROOT_ADDRESS_CELLS + GUEST_ROOT_SIZE_CELLS) *
> +                  (GUEST_RAM_BANKS + 1)];
> +    be32 *cells = &regs[0];
> +    unsigned int i, len, nr_regions = 0;
> +    libxl_dominfo info;
>       int res;
>       gic_interrupt intr;
>   
> @@ -615,9 +626,64 @@ static int make_hypervisor_node(libxl__gc *gc, void *fdt,
>                                 "xen,xen");
>       if (res) return res;
>   
> -    /* reg 0 is grant table space */
> -    res = fdt_property_regs(gc, fdt, GUEST_ROOT_ADDRESS_CELLS, GUEST_ROOT_SIZE_CELLS,
> -                            1,GUEST_GNTTAB_BASE, GUEST_GNTTAB_SIZE);
> +    if (strcmp(dom->guest_type, "xen-3.0-aarch64")) {
> +        LOG(WARN, "The extended regions are only supported for 64-bit guest currently");
> +        goto out;
> +    }

I understand why we want to limit to 64-bit domain for dom0. But I am 
not sure this is warrant for 32-bit domain. At worse, the guest will 
ignore the bank because it is not usable. So could we drop the check?

> +
> +    res = libxl_domain_info(CTX, &info, dom->guest_domid);
> +    if (res) return res;
> +
> +    assert(info.gpaddr_bits >= 32 && info.gpaddr_bits <= 48);
What could go wrong below if gpaddr_bits is not within this range?

> +
> +    /*
> +     * Try to allocate separate 2MB-aligned extended regions from the first
> +     * (below 4GB) and second (above 4GB) RAM banks taking into the account
> +     * the maximum supported guest physical address space size and the amount
> +     * of memory assigned to the guest.
> +     * As the guest memory layout is not populated yet we cannot rely on
> +     * dom->rambank_size[], so calculate the actual size of both banks using
> +     * "max_memkb" value.
> +     */

At the moment, libxl doesn't know how libxc will allocate the memory. We 
may decide in the future to have only a small amount of memory below 4GB 
and then the rest above 4GB. With this approach it would be more 
difficult to modify the memory layout. Instead, I think we should create 
a placeholder that is updated once we know the banks in 
libxl__arch_domain_finalise_hw_description.

We also probably want to mention in the memory layout in 
public/arch-arm.h this decision as the suggested way to find extended 
regions will definitely impact our decision to re-order the memory 
layout or shrink some regions in the future (I have in mind the PCI 
Passthrough work).

> +    ramsize = b_info->max_memkb * 1024;
> +    if (ramsize <= GUEST_RAM0_SIZE) {
> +        region_base[0] = GUEST_RAM0_BASE + ALIGN_UP_TO_2MB(ramsize);
> +        region_size[0] = GUEST_RAM0_SIZE - ALIGN_UP_TO_2MB(ramsize);
> +        region_base[1] = GUEST_RAM1_BASE;
> +    } else
> +        region_base[1] = GUEST_RAM1_BASE +
> +            ALIGN_UP_TO_2MB(ramsize - GUEST_RAM0_SIZE);
> +
> +    bank1end = min(1ULL << info.gpaddr_bits, GUEST_RAM1_BASE + GUEST_RAM1_SIZE);
> +    if (bank1end > region_base[1])
> +        region_size[1] = bank1end - region_base[1];

It would be best to not rely on the fact that Bank on is always below 
4GB. If the code is too complex then we should look to add a 
BUILD_BUG_ON() to avoid any surprise.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Tue Oct 12 16:12:46 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 16:12:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.207511.363372 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maKOJ-0002SQ-AA; Tue, 12 Oct 2021 16:12:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 207511.363372; Tue, 12 Oct 2021 16:12:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maKOJ-0002SJ-67; Tue, 12 Oct 2021 16:12:35 +0000
Received: by outflank-mailman (input) for mailman id 207511;
 Tue, 12 Oct 2021 16:12:33 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=B8jq=PA=arm.com=Bertrand.Marquis@srs-us1.protection.inumbo.net>)
 id 1maKOH-0002SD-LY
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 16:12:33 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com (unknown
 [2a01:111:f400:7d00::601])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 189a4c74-de30-4bac-9aa8-c204b4d1bd85;
 Tue, 12 Oct 2021 16:12:31 +0000 (UTC)
Received: from AS9PR06CA0095.eurprd06.prod.outlook.com (2603:10a6:20b:465::28)
 by AM0PR08MB3363.eurprd08.prod.outlook.com (2603:10a6:208:e1::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.19; Tue, 12 Oct
 2021 16:12:29 +0000
Received: from VE1EUR03FT011.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:465:cafe::5f) by AS9PR06CA0095.outlook.office365.com
 (2603:10a6:20b:465::28) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.14 via Frontend
 Transport; Tue, 12 Oct 2021 16:12:29 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT011.mail.protection.outlook.com (10.152.18.134) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4587.18 via Frontend Transport; Tue, 12 Oct 2021 16:12:29 +0000
Received: ("Tessian outbound a8bfe25d7364:v103");
 Tue, 12 Oct 2021 16:12:28 +0000
Received: from 2640eb854b00.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 3868C9F7-C7B1-43F6-863C-FB37F11902DF.1; 
 Tue, 12 Oct 2021 16:12:17 +0000
Received: from EUR03-DB5-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 2640eb854b00.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Tue, 12 Oct 2021 16:12:17 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com (2603:10a6:4:74::9)
 by DB7PR08MB3658.eurprd08.prod.outlook.com (2603:10a6:10:27::13) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18; Tue, 12 Oct
 2021 16:12:16 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955]) by DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955%4]) with mapi id 15.20.4587.026; Tue, 12 Oct 2021
 16:12:16 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 189a4c74-de30-4bac-9aa8-c204b4d1bd85
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=71MFZnlzbv/YzYcN5M7r8f/Ot4fDlYY3vNHI4mHN9As=;
 b=tpo0b7kufBnovtxyGIrr5Hy+r9l/Z+gz97YT5WRmzTKOcoTvl5MzmvKeLglJUpAuVWvig4cXznRaljU3TAjdFHVi4mUzz+3TIJSVe6tUf1+kjIW9+MPRHpUEYDCxnAPWJUOcwfTjR72bhCNaxdYc6K3T0JUNBxPbLy9GXLFPHTE=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 4a73d9d7a40ffff8
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=nEb3CAVt8tlrhoqZVn9HNLjQfaLfEiNsSpvucRwMhpajoNA8WoKvGOuH+h1N/tz/FbzDv/FULjIVYHOUUjJkgy3b22T4BpR6B7SnU4JmC1+5y3fB1v9mc6+01rsXDpGZBuvFleloLlGptFTJtfuSRU2oocUO7vCV8aQlIbJ1Jfe4grnLctWh5T4ro0R5CA+t3O79Fh/gB+SzV8IVt7Vgv9OTUeCJhVfwD04l5Ww7g6DeVRZ9LSn5uZUj5XzrTzTCIYvEwvInFWv+tgy3yWR5BcwMp//NI2bYfbIaljGw83/4+sWGiqiAAgoP6FYwMNHe5ebyNsYaRHnghiudDF7pVw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=71MFZnlzbv/YzYcN5M7r8f/Ot4fDlYY3vNHI4mHN9As=;
 b=mDTC9qK1WYcL0NnwU8YV6HtY92zTvd79Iv+hb429tZHI+GaJGhbRN9Fb0xaTZlUYQHeovjpm+otcSqSZYhpBq0CfHXrBBA1sP1TyubFRMuLA/LlF209r36c6Jkt0O62LMX37eIhYVGvi4Ylw8YwOnV/wO+h+WXifJEbEjirk+O3o9rc5aTgC3PilWvKUHoCsi5p+jx10o8GhqFXTSVBvdYHIW/luPMgYqwNM94bnq5/KiHx/+7CBj8vLLvq1x/UGZgrudoPt+29k3F9dkkGyX/BDZK3hrODzNMXxEInec/Qc5urVkYUJxNXhst76nX2zvBbHU9n24C2ysh3PrqbqzQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=71MFZnlzbv/YzYcN5M7r8f/Ot4fDlYY3vNHI4mHN9As=;
 b=tpo0b7kufBnovtxyGIrr5Hy+r9l/Z+gz97YT5WRmzTKOcoTvl5MzmvKeLglJUpAuVWvig4cXznRaljU3TAjdFHVi4mUzz+3TIJSVe6tUf1+kjIW9+MPRHpUEYDCxnAPWJUOcwfTjR72bhCNaxdYc6K3T0JUNBxPbLy9GXLFPHTE=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Julien Grall <julien@xen.org>
CC: Jan Beulich <jbeulich@suse.com>, Rahul Singh <Rahul.Singh@arm.com>, Andre
 Przywara <Andre.Przywara@arm.com>, Stefano Stabellini
	<sstabellini@kernel.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>, George Dunlap
	<george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>, Wei Liu
	<wl@xen.org>, Paul Durrant <paul@xen.org>, =?iso-8859-1?Q?Roger_Pau_Monn=E9?=
	<roger.pau@citrix.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v5 08/11] xen/arm: Enable the existing x86 virtual PCI
 support for ARM.
Thread-Topic: [PATCH v5 08/11] xen/arm: Enable the existing x86 virtual PCI
 support for ARM.
Thread-Index: AQHXutl3YqS5dHXsYk6KpdKt4d14RavHjPqAgAY38oCAAbo3AIAAEwAA
Date: Tue, 12 Oct 2021 16:12:16 +0000
Message-ID: <16C05F67-E3C8-44BE-9382-BF0EAA69AF5C@arm.com>
References: <cover.1633540842.git.rahul.singh@arm.com>
 <9bdca2cda5d2e83f94dc2423e55714273539760a.1633540842.git.rahul.singh@arm.com>
 <6752f2d3-171b-37f5-c809-82995a8f3f36@suse.com>
 <CEF7FFB0-779A-4F46-8667-6BCD9BA5CB6C@arm.com>
 <2b0670e9-b442-047c-9479-daa97d6329f6@xen.org>
In-Reply-To: <2b0670e9-b442-047c-9479-daa97d6329f6@xen.org>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3654.120.0.1.13)
Authentication-Results-Original: xen.org; dkim=none (message not signed)
 header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: 9d83c649-aa82-4d77-693b-08d98d9b16fd
x-ms-traffictypediagnostic: DB7PR08MB3658:|AM0PR08MB3363:
x-ms-exchange-transport-forked: True
X-Microsoft-Antispam-PRVS:
	<AM0PR08MB3363CF34B537F5421F68AE969DB69@AM0PR08MB3363.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:10000;OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 F26IE9kbP1fdBuws9ogJcPF3w86KTgaR9pOWuZ5ckI7AgIey2TGyVJDOi2khayyazG9vDG4E744UzgRUD/+lkwH+2ylrJCkLzPddr9snCrvshwV6GAUaZsMIDkXpHgn6qkc/WqPSwplpQnfw9fDFbF945NJ3FE4aGAe/xd+7rK/CQ37FtpKzt6KCvagRND3odLDvDHZlLQHco4NhwC+ykojtU9LSwM6fsHbfZE+xjT2SCPKaBNYFoYprhWILWLFlbqBcPy/DOrPI9pLtqy5XlqhS7JQbuJGXZH0koWZZpwZeoxRjvGUs+yjXGvdr21HnqdvsAqxCrj+YS76X/Spzme3uL8Qawa3MdoD/3vTOSbE5auBuVDU8uJ0mz3YV5LKpP5QXLqprEmggVOi2oFzG+J/Wb7AiYlE+G382sNArwnORdcErqVMy0sDOLFDlfMnvk9Kvwm6Onf9V4BUyVa2yoTcC8M56OsiUIWlc8RtSafnC2w24X2gBwPh8R/6zq4kkpGOH+nbaHBgGxMX/IRLUw8GPqlDLc+5cs7Qt1RrZykseuEQwoKfPaNHrjEajHjVv7gj9SO09iZyEcamjPTGt6uzui30dLVzzGDC/GNBTSv0+U+KMMgNx2XXpDTGtRAKcNiBZrOePidPqxhvY741dvEDGcnUV3gXTJXhPIVzvW31kuBfZf81+EmhisI4bUeaG1nP/R3oaufzIvqrhQDFk8+Z5iCxFdxpm2Av+eqnwxXv3w6TtH27oVbYHZ4UWKxbE
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB6PR0801MB2024.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(7416002)(83380400001)(86362001)(26005)(8936002)(6506007)(66946007)(38070700005)(53546011)(76116006)(5660300002)(8676002)(186003)(122000001)(91956017)(38100700002)(6486002)(36756003)(2906002)(33656002)(66556008)(64756008)(66446008)(6916009)(6512007)(54906003)(508600001)(66476007)(2616005)(71200400001)(4326008)(316002)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="iso-8859-1"
Content-ID: <0BDF9B265ABF3A498B73A9AAB89588E6@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3658
Original-Authentication-Results: xen.org; dkim=none (message not signed)
 header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT011.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	499c1d51-6a2d-4b49-39a2-08d98d9b0f1a
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Uo4TVPlqhO0tV4D0T7YHEk4/WEw72eCpiEYuoYYtR2FxfGlPrc9ozHezXkloMGuYVOf/P3CQ0sT87wPUQbc+wVdqcJN8cx45qDKoVQqXvJd5Zo3QXKGrhzkwjJXNS/YMBv8lQrqnUIaLDgMSVFXCS1MuOgtUaI1kExR4qIZeb82Xx46ym5uakY8yx7nDO/2ECPjx1iqjKiGSfkAp6pJL14tC0iuBjV3opz4O/e87986jFjTz6ukUsqWVfvNpCUr4Twvro6EWBQkjQv/8IBoAKPSNJqBOO5ihSN4z/GDy+jDjrmMr5wX9IOzSQnBp0zsXVGDQqwFPeQPTnotUrNeX8EJ6hBRR8NjbWCx3lc5SnDdKh8QQV+Qx8NMqV7/TYAnZ4I1T6s0hZn6F5Bm7pHIKSYxYwatRFlmLUUlon7BhhkFoRKWyK1Tkn1ts9N0b956+JElnwglmosmRxzmBcBl7et7lu8w9z5NUxAoF7HxwHHQtz8vZOPLF9Z15EpYqseH0gh2OoVbocBvMgoY5/AJzZohqr+t0+s/J9OcSvYP8Bp23BnhkGTGo3Q7eHlhsk3cb+LUswwSrWMSkGJ/p0iEOu98Ah1gUPUA0uNsJsxCZ7ZxHlIho4mGvHoHEEJlDtDP8uopzSSzzUgbc1ulLDup+vF6aWKnQsFqaamSzwMXXsdlRfqB6SFzLEjlSqpPF7pSg89HtcOJbpHhhBT0OiYm9lA==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(33656002)(336012)(83380400001)(316002)(8936002)(81166007)(6486002)(26005)(186003)(54906003)(86362001)(6506007)(53546011)(47076005)(356005)(36860700001)(6512007)(2906002)(70586007)(508600001)(6862004)(70206006)(2616005)(4326008)(8676002)(36756003)(82310400003)(5660300002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2021 16:12:29.3649
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 9d83c649-aa82-4d77-693b-08d98d9b16fd
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT011.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3363

Hi Julien,

> On 12 Oct 2021, at 16:04, Julien Grall <julien@xen.org> wrote:
>=20
> On 11/10/2021 13:41, Bertrand Marquis wrote:
>> Hi Jan,
>=20
> Hi Bertrand,
>=20
>> As Rahul is on leave, I will answer you and make the changes needed.
>>> On 7 Oct 2021, at 14:43, Jan Beulich <jbeulich@suse.com> wrote:
>>> Independent of this - is bare metal Arm enforcing this same
>>> alignment restriction (unconditionally)? Iirc on x86 we felt we'd
>>> better synthesize misaligned accesses.
>> Unaligned IO access could be synthesise also on arm to but I would
>> rather not make such a change now without testing it (and there is
>> also a question of it making sense).
>=20
> Yes it makes sense. I actually have an item in my TODO list to forbid una=
ligned access because they should not happen on any device we currently emu=
late.
>=20
> Although, I am not aware of any issue other than the guest would shoot it=
self in the foot if this happens.
>=20
>> So if it is ok with you I will keep that check and discuss it with Rahul
>> when he is back. I will add a comment in the code to make that clear.
>=20
> I am OK with it.
>=20
> [...]
>=20
>>> Throughout this series I haven't been able to spot where the HAS_VPCI
>>> Kconfig symbol would get selected. Hence I cannot tell whether all of
>>> this is Arm64-specific. Otherwise I wonder whether size 8 actually
>>> can occur on Arm32.
>> Dabt.size could be 3 even on ARM32 but we should not allow 64bit
>> access on mmio regions on arm32.
>=20
> Hmmm... Looking at the Armv7 and Armv8 spec, ldrd/strd (64-bit read) woul=
d not present a valid ISV. So I think it is not be possible to have dabt.si=
ze =3D 3 for 32-bit domain. But I agree we probably want to harden the code=
.
>=20
>> So I will surround this code with ifdef CONFIG_ARM_64 and add a test
>> for len > 4 to prevent this case on 32bit.
>> To be completely right we should disable this also for 32bit guests but
>> this change would be a bit more invasive.
>=20
> I think the following should be sufficient:
>=20
> if ( is_domain_32bit_domain() && len > 4 )
>  return ...;

With the last request from Roger to use the function implemented in arch/x8=
6/hw/io.c, the function will move to vpci.h so using is_32bit_domain will n=
ot be possible without ifdefery CONFIG_ARM.
Also I have no access to the domain there.

So the best I can do for now would be something like:
#ifdef CONFIG_ARM_32
If (len =3D=3D 8)
    return false
#endif

A 32bit guest on 64bit xen would not be checked.

Would that be ok for now ?

I could add a comment in the code to warn about the limitation.

Cheers
Bertrand

>=20
> Cheers,
>=20
> --=20
> Julien Grall



From xen-devel-bounces@lists.xenproject.org Tue Oct 12 16:15:19 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 16:15:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.207518.363383 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maKQw-00039q-SO; Tue, 12 Oct 2021 16:15:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 207518.363383; Tue, 12 Oct 2021 16:15:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maKQw-00039j-OD; Tue, 12 Oct 2021 16:15:18 +0000
Received: by outflank-mailman (input) for mailman id 207518;
 Tue, 12 Oct 2021 16:15:17 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=kpIn=PA=oracle.com=dongli.zhang@srs-us1.protection.inumbo.net>)
 id 1maKQv-00039d-Ti
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 16:15:17 +0000
Received: from mx0b-00069f02.pphosted.com (unknown [205.220.177.32])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 21660f23-775b-422f-ab77-f889ebd5cd07;
 Tue, 12 Oct 2021 16:15:16 +0000 (UTC)
Received: from pps.filterd (m0246630.ppops.net [127.0.0.1])
 by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 19CFiuxN020990; 
 Tue, 12 Oct 2021 16:15:14 GMT
Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79])
 by mx0b-00069f02.pphosted.com with ESMTP id 3bmq2vrk7m-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Tue, 12 Oct 2021 16:15:12 +0000
Received: from pps.filterd (userp3020.oracle.com [127.0.0.1])
 by userp3020.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 19CGB8Fi078495;
 Tue, 12 Oct 2021 16:15:10 GMT
Received: from nam04-dm6-obe.outbound.protection.outlook.com
 (mail-dm6nam08lp2046.outbound.protection.outlook.com [104.47.73.46])
 by userp3020.oracle.com with ESMTP id 3bkyvae1m4-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Tue, 12 Oct 2021 16:15:10 +0000
Received: from BYAPR10MB2663.namprd10.prod.outlook.com (2603:10b6:a02:a9::20)
 by BY5PR10MB4196.namprd10.prod.outlook.com (2603:10b6:a03:20d::23)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.19; Tue, 12 Oct
 2021 16:15:07 +0000
Received: from BYAPR10MB2663.namprd10.prod.outlook.com
 ([fe80::2848:63dc:b87:8021]) by BYAPR10MB2663.namprd10.prod.outlook.com
 ([fe80::2848:63dc:b87:8021%7]) with mapi id 15.20.4587.026; Tue, 12 Oct 2021
 16:15:07 +0000
Received: from [IPv6:2606:b400:400:7446:8000::222] (2606:b400:8301:1010::16aa)
 by SN4PR0501CA0130.namprd05.prod.outlook.com (2603:10b6:803:42::47) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.5 via Frontend
 Transport; Tue, 12 Oct 2021 16:15:05 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 21660f23-775b-422f-ab77-f889ebd5cd07
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc :
 references : from : message-id : date : in-reply-to : content-type :
 content-transfer-encoding : mime-version; s=corp-2021-07-09;
 bh=KRmP6MHFP6gso1JruxBlXhR8OhZX1XZEgiFtRP6a3ps=;
 b=apvc2lsl6M4AHzbe3CnHpnGK2JJglnDvKHnO67tRM4CHM0oVl5x+XAJpbHXMd2zkLGri
 hEUwjIOcMDGjmWHfR5QNf69C6O7EsmFw9rVRWDrq27r3/cPKj11ZgYPXjk6xd4Ejs6y+
 xvNAH9RoyPkv2+6tdSxPsp2GvNS//lOJz/JpaWNYNUzEYsoBVt5KfAycL6foVI4TothB
 fS9z4ddKDARQsR0jWxEyARux7j23vEJMkMjTPgLHVmPC/Ao80kNeqqEFG4Y6WHfr/XZn
 X9RYFm1lAjA/Myhv8kBAJuTVmWJ1solxaxEBjDAiBXpidXF6zeQUOSWqc7bHLm1K45FJ nQ== 
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=mB0NkFpTbufLWKDaqEHweE4YfpwGzy9CbegfuFswOVkO4q9U2u4dbEiVzTtmCxC2Vu7ymUE4Y7BOM+zLpzkAemYuLa3auVI15orqNTFU5Y4i6WAiBU8drxJPU+lLEmt2B3xFa80yf4XEoLHk69qpb0j6Lcc7E9G2OmY1pX53dythr2rsXc5R+ej00Fyt5enQCbnDkhhB7mk8IfJo0lxu/tP5vX4kQb8kV4m6iaBUUzejJaghLTKzNF+XnVxiUYGDup85JkuQUt7YV0/a/8MDRdaMHzvGHwSl2stbkdk2llwODmYZ6uLTc7fAe/5X5tOewvzB75skk5Op0lvNkOb4OQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=KRmP6MHFP6gso1JruxBlXhR8OhZX1XZEgiFtRP6a3ps=;
 b=Sbq6esfJtlH271zy5k6wQeTBVn/v6yD3qYUW1Ljb3wKXmLvCDcojC6kZZhlc54gOlMZD9D9xPcsnrd83ghT4bw9XWiTx2bNP5UbDF22HYXVotUbamQXMIykkO4x7f/ZBmcl6eRY9nuUG+V50vur6b9jfeIcmi6f61MJstcz9FcLWe29kcBgBXpgqjGVCuscpSxNH39PiYE7YzgRH1u4rV9BwXkbXhQ7oTs5EAbSxxmL5+HY71srIDtso1Rsuvp7vNV9LO1GIpEuYX1t1HJxLAeIJLC4M1w0trEZelp7vNgHcwOcV9BKEWUCrl9Di/tJaKOD5/xjnvLZAMVxPOiyM+g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com;
 dkim=pass header.d=oracle.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=KRmP6MHFP6gso1JruxBlXhR8OhZX1XZEgiFtRP6a3ps=;
 b=S9q1ay794T8dds88mvsbm5P38UA9TUnZhJ2/ncwmK0biHC/R3Djby3vrr5LinFeEE3C2LnnVgEQroROAjn1YX7ixEGfoWspfhfBJa5XFC3OoARZNShpLPvtG8vYP4q+JqVHc9LvCpBqkUuDKnnwFSSF0CCsTxY8P6vN9qf5gyBk=
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=oracle.com;
Subject: Re: [PATCH xen 2/2] xen: update system time immediately when
 VCPUOP_register_vcpu_info
To: Jan Beulich <jbeulich@suse.com>
Cc: sstabellini@kernel.org, andrew.cooper3@citrix.com,
        george.dunlap@citrix.com, iwj@xenproject.org, julien@xen.org,
        wl@xen.org, joe.jin@oracle.com, xen-devel@lists.xenproject.org
References: <20211012072428.2569-1-dongli.zhang@oracle.com>
 <20211012072428.2569-3-dongli.zhang@oracle.com>
 <317163fa-f736-ccfe-40d4-b918ce2834f9@suse.com>
 <3e16648f-088d-5f62-03d7-ca744e913cbb@oracle.com>
 <8b31045b-dbb0-3ca1-074e-a12107b09159@suse.com>
From: Dongli Zhang <dongli.zhang@oracle.com>
Message-ID: <b9599319-0bbf-94b9-2a0a-405cd9a225a6@oracle.com>
Date: Tue, 12 Oct 2021 09:15:04 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.6.1
In-Reply-To: <8b31045b-dbb0-3ca1-074e-a12107b09159@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: SN4PR0501CA0130.namprd05.prod.outlook.com
 (2603:10b6:803:42::47) To BYAPR10MB2663.namprd10.prod.outlook.com
 (2603:10b6:a02:a9::20)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 2de28965-bf03-4e28-a491-08d98d9b74de
X-MS-TrafficTypeDiagnostic: BY5PR10MB4196:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: 
	<BY5PR10MB4196EC0528692505640D9FE1F0B69@BY5PR10MB4196.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7691;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 
	/JsiSTPzrTopROsHyX5RMwVfEFxbcD02FzHAllNWlNO0JXPp+VohpaEWj5SiqgJndytLwh7PFTlYfHjxAavyBgxr7wLjR1Dw7oELoiCCox4R9vGcTKkD950qHJqeOpB+9spF8I6JsdJ7AlA0HiF1UeTAUd+ApITvlxHSoi/qm8wdwJ8OboNv4EIbQ8sZ9agSFKRkP/1pGo2taBI31GecOSxb6WyXFnoSBtXaBsB4q/NnE0ixGZZW4b76ykmgd1Weu32i4AJISxQjHe6D3A4YibCwcB54Zcr+553IVY81kuSpVnKJt+yrwaglurWgB7+O6uePjlUMC2X+SyiiEYrBLeoniITU6Pvg0kLGAWA8Zi4AxjmiRx8VBPSXhdLmiT3MmI6fXYcmkYmGJXQzOQJKYZ40vaewEiDd5phwwTFyh1kYryM/fIW0f/ldR40xxr3ZxhIIUnAV1tzlNZepxEpnU3QnPYDWsUstBtXcM5X6aHiusVTysah4mVw9Jbtow0u03Uc/T/xsW9Lx+77I4RhTepJsBXmwBwMKl9uZSYUHr4RXEMrn6zF8ZeTNftYbiFDdgk1tGqNYSyvbk5HpYngqLGIzJCzOLPOgIJ6VxOdLar+UXGYnB2Dq3o/YgJXsdpsmu9PhOdHXAhokps6s0ZZM69ateSgnqaMwQz/WsDLjBVfs2jELio5GtndWzqiunQ7OHi/kV9LlrSTqTZc6dKdebLygy1jTGB6QvBJRpN6usY7PLDPyOcFC0rjqNo5BC9MXkQLmXva/xqIPtSDEZfOlmQ8QzsHo+Tydo13JXV8iIEY=
X-Forefront-Antispam-Report: 
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB2663.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(5660300002)(15650500001)(2906002)(86362001)(31696002)(316002)(6916009)(31686004)(38100700002)(2616005)(36756003)(8676002)(6486002)(8936002)(66946007)(66476007)(44832011)(4326008)(53546011)(186003)(508600001)(83380400001)(66556008)(14773001)(21314003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?MjZ6ZFcwU2J2VmpEUWZQN0pVVUdrN1h2d2l2NkU4aitEQys1QkRJSUN5eE1J?=
 =?utf-8?B?WDRkU01yZ1I0MUFieFBDZ0E5eHBOckx5VHY1L1l1UjBlcERsVmhFOVpvM2po?=
 =?utf-8?B?U3BIQ3FLazlPRHFFYklrQ3BkVFZHRWFZV2M0bEJWMFJ3aE9DekZJbWVjUEd1?=
 =?utf-8?B?Z3Z6WThuNDY3YlAzOVlTcUNybWhWSkNVeFNZN3lyVXlKb29HaEVoRmluYkty?=
 =?utf-8?B?UU1xeFZYLzB5dXFWRzhScE4vbDRLY1MxR2dPTmhPZUQxWjNSWGdaTHFKSjlQ?=
 =?utf-8?B?Q0QzbW5WM05qN3UxUGpSUVhXQm04SnRtb0pPWG56WmV0NHBRSFFMQjFrMXA3?=
 =?utf-8?B?ODlIMlV1bVpvVjNxa3RoVG8xbXVISE0xb2pzclRnNVpkMUo3ZUtXeEkzeGJw?=
 =?utf-8?B?NmxsQS9uekhoaGRuY3hDb1haOUNUYklzcVppeVNVd2ZwYUNTTkI5a3dZY29v?=
 =?utf-8?B?Ym0zM25kbGRMZWtsdUIvV24xMjNrOHZBYWxOQjRESGN3b0wvTjAzOW1NM2Nl?=
 =?utf-8?B?QXRqQ200L05UNWVVTldaRnBTMTVCNnhyS2lhN280SVhQS0hxZzEyR3RBVG5E?=
 =?utf-8?B?QUFxK0RWbldrYVBRUytnL1lidG5jQm1RK25FWmk2VEkvZS9yQkR5djA3b1Vn?=
 =?utf-8?B?Wm9WVi9URGNObDdwV3gwOGNEOE1hajk0STNKN2ltTkx6b0VEY0tFV2pRaUZa?=
 =?utf-8?B?c1BiRitMNVJvUWI3TkdQMTFWcVptZHVzVzZjNzFsNisxY08yWXZLekFVRXRW?=
 =?utf-8?B?TnJjb2R6THAzNzRvTnBBVldaR0g0VnFKRXB6bCtVNjhLWkw5ajJjdkl5dDdl?=
 =?utf-8?B?eWFqZnR1bThtVXVVSEF4bkpWWTYyZHFqQ3lWSExXUkN1elBxM3BXN0NMTE1p?=
 =?utf-8?B?Q0FGakR0R05mVjRBbDM2QllRY2JtMWx3ZXA2eHREd2FYSXRpbDdRSXNpOWFS?=
 =?utf-8?B?eGVDSlh2QXZqNms3ZE5aVW85ZzNXaTJxN1E4SlA2TzN5eGxHcGRhNnBhc0E2?=
 =?utf-8?B?NkpkZmpaSG12cE41dThvQVp4YkxGVnc3b2FWK241c2VxRTZHTE9DUVl1Qkl6?=
 =?utf-8?B?Wm1mNDBXYjhOazk4S1R4RTQvMTc4OTNDVnMvYjJVUkxyOEpQT1IxZHd3MFB6?=
 =?utf-8?B?UFF6SHNvWkp0U2o2Nmlra240UVdSRWVIMFJndW5EMUZkOTRQMThMOSsybEk4?=
 =?utf-8?B?ZHh3YVNmREtyTDV5Tlpwdk5CK2FZb3ZPOGtJdVNOMzVuVXROWFJsSkdNajBj?=
 =?utf-8?B?YnlyRHo1Mmt6RmxnTS8rQnFkL25RZytYbktJYUY0WWprbHpjYzVoYUwyMDAx?=
 =?utf-8?B?Ty9lc2hPb0FwYStuV2h6bHpqeEt0Wk9xbGtZTCttWXozMWxsbG4wNFZKckQz?=
 =?utf-8?B?UnNQV2tjVmFKUUovd2hQdnV3VUVFamgrdGxJOERBejlYWXpDeGZPbTBwcW1K?=
 =?utf-8?B?VDBSaXVBUXRVYVE4MWI4MkxLWEtJVFphcDNDaEpLRGlOSmpXL0dHR296ZE9H?=
 =?utf-8?B?U3IwcmpkTnMrRHJtaHoxblRWZzNHRHN4QnkrMHUwd1UrUHEvYUF1Zk81WFB0?=
 =?utf-8?B?dGF5RkhYUVNFTEM4NGJmWkRTK2pGYUpoRWlndXpNMU9Tb0MxRGNBVDBPRmd5?=
 =?utf-8?B?MFhBYUhpTWxnaHhwNDgzZ2l6YUJzc25oK3BRaFR3TjRYSlo5ZG5aQUF0ZDd2?=
 =?utf-8?B?ckJvTHAzUVBDRlc2UU9GZXZ6d1V3OTdFbytxM2lSb3FWUzJncVIwS1dVMHla?=
 =?utf-8?B?eGlDRnVYdjA2c2o0dGNrak05d0lCbzdZNjRwSXpRSkVHbXlOMGVFdlRjNE94?=
 =?utf-8?Q?gRqHq+b2507AD7SvQyGQn0qBRrygYdnIagSxo=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2de28965-bf03-4e28-a491-08d98d9b74de
X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB2663.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2021 16:15:07.1970
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: KrIqCdyqkEO3ap2jDedOGnzusSkUYiqNpmvTSnRs/C/ai3jJUYWlE1g5xAv17iacbGWys+EkG041ODoNAaLMSw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR10MB4196
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10135 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0
 adultscore=0 bulkscore=0 mlxscore=0 spamscore=0 mlxlogscore=999
 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2109230001 definitions=main-2110120091
X-Proofpoint-GUID: tF3h6Cx5nOsjYy0yHXcG_IR1yG7nQMZ2
X-Proofpoint-ORIG-GUID: tF3h6Cx5nOsjYy0yHXcG_IR1yG7nQMZ2

Hi Jan,

On 10/12/21 8:49 AM, Jan Beulich wrote:
> On 12.10.2021 17:43, Dongli Zhang wrote:
>> Hi Jan,
>>
>> On 10/12/21 1:40 AM, Jan Beulich wrote:
>>> On 12.10.2021 09:24, Dongli Zhang wrote:
>>>> The guest may access the pv vcpu_time_info immediately after
>>>> VCPUOP_register_vcpu_info. This is to borrow the idea of
>>>> VCPUOP_register_vcpu_time_memory_area, where the
>>>> force_update_vcpu_system_time() is called immediately when the new memory
>>>> area is registered.
>>>>
>>>> Otherwise, we may observe clock drift at the VM side if the VM accesses
>>>> the clocksource immediately after VCPUOP_register_vcpu_info().
>>>>
>>>> Cc: Joe Jin <joe.jin@oracle.com>
>>>> Signed-off-by: Dongli Zhang <dongli.zhang@oracle.com>
>>>
>>> While I agree with the change in principle, ...
>>>
>>>> --- a/xen/common/domain.c
>>>> +++ b/xen/common/domain.c
>>>> @@ -1695,6 +1695,8 @@ long do_vcpu_op(int cmd, unsigned int vcpuid, XEN_GUEST_HANDLE_PARAM(void) arg)
>>>>          rc = map_vcpu_info(v, info.mfn, info.offset);
>>>>          domain_unlock(d);
>>>>  
>>>> +        force_update_vcpu_system_time(v);
>>>
>>> ... I'm afraid you're breaking the Arm build here. Arm will first need
>>> to gain this function.
>>>
>>
>> Since I am not familiar with the Xen ARM, would you please let me your
>> suggestion if I just leave ARM as TODO to the ARM developers to verify
>> and implement force_update_vcpu_system_time()?
> 
> I'd much prefer to avoid this. I don't think the function can be that
> difficult to introduce. And I'm sure the Arm maintainers will apply
> extra care during review if you point out that you weren't able to
> actually test this.
> 

I do not see pvclock used by arm/arm64 in linux kernel for xen.

In addition, the implementation at xen hypervisor side is empty.

348 /* VCPU PV clock. */
349 void update_vcpu_system_time(struct vcpu *v)
350 {
351     /* XXX update shared_info->wc_* */
352 }

I will add a wrapper for it.

The bad thing is I see riscv is supported by xen and we may need to add the
function for riscv as well.

Thank you very much!

Dongli Zhang


From xen-devel-bounces@lists.xenproject.org Tue Oct 12 16:15:53 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 16:15:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.207526.363394 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maKRU-0003hu-5G; Tue, 12 Oct 2021 16:15:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 207526.363394; Tue, 12 Oct 2021 16:15:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maKRU-0003hn-1S; Tue, 12 Oct 2021 16:15:52 +0000
Received: by outflank-mailman (input) for mailman id 207526;
 Tue, 12 Oct 2021 16:15:51 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=B8jq=PA=arm.com=Bertrand.Marquis@srs-us1.protection.inumbo.net>)
 id 1maKRT-0003hd-Ct
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 16:15:51 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com (unknown
 [40.107.7.50]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 1142dbf2-559d-4f62-85e1-e4212b4a52a7;
 Tue, 12 Oct 2021 16:15:49 +0000 (UTC)
Received: from AS9PR06CA0255.eurprd06.prod.outlook.com (2603:10a6:20b:45f::26)
 by DB6PR0801MB2054.eurprd08.prod.outlook.com (2603:10a6:4:77::7) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.22; Tue, 12 Oct
 2021 16:15:47 +0000
Received: from VE1EUR03FT051.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:45f:cafe::17) by AS9PR06CA0255.outlook.office365.com
 (2603:10a6:20b:45f::26) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.24 via Frontend
 Transport; Tue, 12 Oct 2021 16:15:47 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT051.mail.protection.outlook.com (10.152.19.75) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4587.18 via Frontend Transport; Tue, 12 Oct 2021 16:15:47 +0000
Received: ("Tessian outbound e27daf245730:v103");
 Tue, 12 Oct 2021 16:15:46 +0000
Received: from 01af4a8568e5.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 AAF51EB1-C566-40B2-9C9F-2A3741435DCB.1; 
 Tue, 12 Oct 2021 16:15:25 +0000
Received: from EUR01-VE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 01af4a8568e5.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Tue, 12 Oct 2021 16:15:25 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com (2603:10a6:4:74::9)
 by DB7PR08MB3771.eurprd08.prod.outlook.com (2603:10a6:10:32::29) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18; Tue, 12 Oct
 2021 16:15:20 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955]) by DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955%4]) with mapi id 15.20.4587.026; Tue, 12 Oct 2021
 16:15:20 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1142dbf2-559d-4f62-85e1-e4212b4a52a7
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=YYDm+x1uHHoe95VdJZCKrnBh2rXyUDEoWYPYidSuYM8=;
 b=SWIcgcZQlskBml3SWfjYwOKiLoRv1IZPtigme25sOToLH748WPEUMGTI3MQHg8gOknOAgyBEjx6lOWqxvq8uBk3bnqhMXzaZQJP9hnW6OmjTLZILuUjHSDEnR9WEzLCCh7BPzSH+PrSg3I2sRCTb+fdKmw8uTXa4+U2e+3kcO2w=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 40ee3d2076aefa1b
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=gBa4n+8ccl5cJbXq56rnnfP78VvcShGQASe5r5Kj981+cyWjYBI/naiLjKi5ECZNMOXcKqSz1UvP6tPft0pOzeWMsQbuVdQv1p1zKUddGfiClbB+ZUa4kDfiQU/v1uRgdQYb35+O4cJBg66p4r+fWMF0mZPvIUsiLgNccENAQQYqxgYu5n6Ahv7ev0lQnp2akdr0ls49zKawyY+VV929/ZP/oZqHeB0vplbNHnDfRg7wV65hK+1HkZNAL3qHxYp5mvGBnXF79MW1w1+4AbgeEXT2sOgttDKwNLk+gP6zFj/hy94vHexgISiIUlbCJqm9wVazS2kEd8ImAuXAIPEasQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=YYDm+x1uHHoe95VdJZCKrnBh2rXyUDEoWYPYidSuYM8=;
 b=Zb//hHJ06cnCk8LmN/qWROiq2yPn6/48tKVZYB0XyXXAQO6fg8X16qTBrBMd+uleO6pGpDloFMJIz10Rwv6ymZeG0o1k832SKIaqYM8nJjlB3laotrcpKFcdUBgeWFX21RySTlQlip6jiDiPd8jhMrhZbWsPtYZ6pTWej6sDn6R661HkZ/Hhp2njlfEvZWCkHFYBN9tjh4xo6oivqxmLrb7vi9PADH+O62uza7sSSOH2L8bA1fQiT0gTz2HqzzkFOtyih+k/r+8qg/mn237L76ST5rmAV91EasvhrBup0weQrAK9cgMPM3xmIhYgZVjolQN8sDX4tg00H2NDzrWjgA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=YYDm+x1uHHoe95VdJZCKrnBh2rXyUDEoWYPYidSuYM8=;
 b=SWIcgcZQlskBml3SWfjYwOKiLoRv1IZPtigme25sOToLH748WPEUMGTI3MQHg8gOknOAgyBEjx6lOWqxvq8uBk3bnqhMXzaZQJP9hnW6OmjTLZILuUjHSDEnR9WEzLCCh7BPzSH+PrSg3I2sRCTb+fdKmw8uTXa4+U2e+3kcO2w=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Ian Jackson <iwj@xenproject.org>
CC: Jan Beulich <jbeulich@suse.com>, Oleksandr Andrushchenko
	<Oleksandr_Andrushchenko@epam.com>, Rahul Singh <Rahul.Singh@arm.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Andre
 Przywara <Andre.Przywara@arm.com>, Wei Liu <wl@xen.org>, Juergen Gross
	<jgross@suse.com>, Stefano Stabellini <sstabellini@kernel.org>,
	=?iso-8859-1?Q?Roger_Pau_Monn=E9?= <roger.pau@citrix.com>
Subject: Re: [PATCH v5 01/11] xen/arm: xc_domain_ioport_permission(..) not
 supported on ARM.
Thread-Topic: [PATCH v5 01/11] xen/arm: xc_domain_ioport_permission(..) not
 supported on ARM.
Thread-Index:
 AQHXutl5d8zkP9bsD0GXT4+5QPGclKvNtfkAgAAGc4CAABOEAIAABXoAgAAEuYCAAAVHAIAAJiWAgAAK0ICAAQCPgIAAA0qAgAAOJYCAAAHCAIAABnQAgAABQgCAAAQNAIAABdAAgABGkoCAABa9AA==
Date: Tue, 12 Oct 2021 16:15:20 +0000
Message-ID: <AB6D62B6-2ED2-4957-A933-08EC77A4DFD6@arm.com>
References: <cover.1633540842.git.rahul.singh@arm.com>
 <d292392268df2c74c4103a82ef917072643407a8.1633540842.git.rahul.singh@arm.com>
 <YWQkblfNMYEs6jI9@MacBook-Air-de-Roger.local>
 <77CF7FA5-C566-469E-B4A8-0400789890BB@arm.com>
 <YWQ6Nk3Jk+BqgkwZ@MacBook-Air-de-Roger.local>
 <53AE6E2A-01D7-41EC-9B2C-C0D596EB8D4D@arm.com>
 <YWRCxXGQIyTOAepC@MacBook-Air-de-Roger.local>
 <FEF0B03A-5AC8-4F8D-B821-191AC2EF8295@arm.com>
 <ac6d4785-ac9a-4491-26bb-c66ffe82c55b@suse.com>
 <ED8FC92F-B5EF-4473-B4A9-641C7D44859F@arm.com>
 <0744b957-1832-dff2-9ae2-b8e8534f501b@suse.com>
 <c3952fd5-b893-4cb6-a9bc-325a89e859db@epam.com>
 <c125b447-53e8-7d13-3b08-af62fd3a9140@suse.com>
 <c6b6c22f-fb8a-f2d9-7735-f1ebc9809908@epam.com>
 <09656882-b297-7144-c291-1ee997edb119@suse.com>
 <69A83587-B7E0-4653-AF8C-AEE802922CE5@arm.com>
 <24933.41349.893363.203683@mariner.uk.xensource.com>
In-Reply-To: <24933.41349.893363.203683@mariner.uk.xensource.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3654.120.0.1.13)
Authentication-Results-Original: xenproject.org; dkim=none (message not
 signed) header.d=none;xenproject.org; dmarc=none action=none
 header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: 81a0cbd5-dc03-4de9-3a7f-08d98d9b8ccf
x-ms-traffictypediagnostic: DB7PR08MB3771:|DB6PR0801MB2054:
x-ms-exchange-transport-forked: True
X-Microsoft-Antispam-PRVS:
	<DB6PR0801MB2054BD52A9CF15382907E7A29DB69@DB6PR0801MB2054.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:7219;OLM:7219;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 1LYK1jtZ/J1xMUHRsxB6I+izbc4nbsnja6zOz97Z5b95elJuoYh5pzpy2ImXUh/GHzxEVx4Bwm7mtO5ZIWfbbdtnTyfPFb/N/qdRHe4QvNDgUMEs83flIev/BhEjylH5hKRo/0d2+T4CEcHEoEKQU1Tq2HFHG2yI0sLvuSBJg0l3o32ZH/gEYGlVN/SkPkIE+DpfZPhy16+zXmTL3ohFmsCiH5uF5Lv0Z1amD6S9GHAOEeZPCNjpPS5xK4OhN/yfA5hPC7a0Wxp9Ck4xdBXEcYVkgI1FkCXznL1arHiU0VxNCJNUXw2UrjUMTX42mhrm3bSCoLD5sqJbZN/EV3FsXdjLBqTjSc6a5gVphHH5Njoulg4pQfnQubeP65/KqmUGzLcmjxhi04v+rJirkX5y/7DbxFkEiyQRkw48UHgEA9fLTB/bdF/ePoTaWXFMp/WHns4B2sotSNYUTIRiHaJY6TkhVFjlRf5t/wM8oLqjeQznZoy1Zaj4oObAsqP+naWomR30lOqpY5oy9+6/r1Ky5UTKMzuPMVuZ76CK80nIP56gd7erlOH12XICEgFSgS2MVZal06iM+n1JGd/rZtkhmq7k5d7nJB5bf1MHjU5ZgtDwFZP9a5Y4sMXtSn9mrT1vC3UyWt/3WlT3E6H3tDPar1ZaV8RD5cmH1hXIL68R2VoTzZ/B1677SP9lXw3JXNxOCMbGQh1AqRzm/EAdvcA5uJmE3X7z+eBENTi1SGMazqaoHKXSy0o11MEh325J8Dvi
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB6PR0801MB2024.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(66476007)(2906002)(66556008)(66446008)(64756008)(6512007)(33656002)(6916009)(4326008)(2616005)(71200400001)(508600001)(54906003)(316002)(5660300002)(76116006)(8936002)(53546011)(26005)(186003)(66946007)(83380400001)(6506007)(86362001)(8676002)(38100700002)(122000001)(91956017)(6486002)(36756003)(38070700005)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="iso-8859-1"
Content-ID: <563C9D767C5B0B4BA90AE5712E500FC3@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3771
Original-Authentication-Results: xenproject.org; dkim=none (message not signed)
 header.d=none;xenproject.org; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT051.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	e7d0307d-5dc0-4470-fe88-08d98d9b7d10
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	9memBaNy15avBC9uidcAUSP3gGg1Pdce7P7lQQipdaiYiFX1egkEymFYacLkzJHBVQzOItjw2ZGprWR2z31g/+QN5AtotLrBWRznHl8J+EPcG2NnGJhu9FwfsoQr3Od2IsBENHcMNPTzkVIHm+AfbmDieqakdpD3DsNeYYxDmcIrX0w2I7fD3aoeWqlxUSS2BMbNf+C7cTeWQCeF8eA7ga+xUJznyZtTDZ/B9RCeF2R8VWiTySNRQwJCEI+E5s15rR4X9nZIg2rYU96LYU8XN/UCtODzj+emYwu6ED1ckT5GlaRW1amo/Qh+o8CnhSx1LpiOo/zRERO/tM7xYQKSEbg3H17UGLcGQRhZKdBHtKxxBEOb9y+kIQRyl5VbN65sJrpPHhtiGVhRpZHf725Y0hnUMSiICbzzpVa428Nt9Vuj8OZ95/CkRPXOkPb2Qi5ks5RuY4PZW/v+xLAeR9yOsr4HFXhRAqL1FGqSr+5EdMC0f/PrcMMzUUN198xR5jadQ5Azmlz5jr0KHI0MaGf1YDH2QQo/KF2Jpyu/uZobglSiNPVIwqKBd5fVHC0KcVTTPv8Czdce7P9mDrTvlCm9Yth14EQANPGhTlo3ermW1EiwJjUyDQRaj5bkDs94spdDDhieULJOndVrBY4xjoioo4stc6SvJZ6Si1Y/BIkbu10Iyt+OGcP4E1VedaDD87TEekUiLvpChfHvzPFGi77/EA==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(186003)(70206006)(26005)(6512007)(54906003)(36860700001)(81166007)(336012)(8676002)(86362001)(6486002)(2906002)(36756003)(107886003)(508600001)(47076005)(70586007)(82310400003)(356005)(33656002)(8936002)(53546011)(83380400001)(4326008)(5660300002)(6862004)(316002)(2616005)(6506007);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2021 16:15:47.0384
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 81a0cbd5-dc03-4de9-3a7f-08d98d9b8ccf
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT051.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0801MB2054

Hi Ian,

> On 12 Oct 2021, at 15:53, Ian Jackson <iwj@xenproject.org> wrote:
>=20
> Bertrand Marquis writes ("Re: [PATCH v5 01/11] xen/arm: xc_domain_ioport_=
permission(..) not supported on ARM."):
>> So there is no comment remaining on this patch ?
>=20
> I have been following this thread.  I think I have a notion of why
> this is needed but I'm not 100% clear on it.  The commit message says
> this:
>=20
>> ARM architecture does not implement I/O ports. Ignore this call on ARM
>> to avoid the overhead of making a hypercall just for Xen to return
>> -ENOSYS.
>=20
> which implies it's a performance improvement.  But the change also
> suppresses an error return, so this commit message is false.  I think
> that the thread has concluded something different, but it should be
> explained in the commit message.  The purpose of a commit message is
> precisely to capture the kind of considerations and discussion that
> occurred in this thread.

I can add something in the commit message about the fact that we improve
performance and prevent to do a call that is and will not be supported in X=
en.

>=20
> If the overall outcome implied by this patch is correct (as I *think*
> the thread has concluded) then I don't think the #ifdefery is
> appropriate.  This should be done with a new arch-specific function in
> libxl_x86.c and libxl_arm.c.  I'm not sure precisely what that
> function should be called, but maybe something like
>  libxl_ioports_supported
> ?
>=20
> I see that the fact that we avoid #ifdefs wasn't documented in
> CODING_STYLE, so I have sent a patch to add that.  Sorry about that.

I saw your change in CODING_STYLE and I understand the request.
I will try to see if we can handle this change before the feature freeze.

Regards
Bertrand

>=20
> Thanks,
> Ian.



From xen-devel-bounces@lists.xenproject.org Tue Oct 12 16:18:46 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 16:18:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.207535.363405 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maKUE-0004Nv-JU; Tue, 12 Oct 2021 16:18:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 207535.363405; Tue, 12 Oct 2021 16:18:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maKUE-0004No-Fi; Tue, 12 Oct 2021 16:18:42 +0000
Received: by outflank-mailman (input) for mailman id 207535;
 Tue, 12 Oct 2021 16:18:41 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1maKUD-0004Ni-KK
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 16:18:41 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1maKUD-0005OV-IN
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 16:18:41 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1maKUD-0001U6-HB
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 16:18:41 +0000
Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89)
 (envelope-from <iwj@xenproject.org>)
 id 1maKU8-0004v7-IY; Tue, 12 Oct 2021 17:18:36 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date
	:Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From;
	bh=BqoNaHwO/t2HEKKLHC9PSN+pgvPlyF6oIXIuIW+uIr0=; b=dT/Fp2YET/sLaD0w3uByxvG5bA
	m/xDAwwwJ7ljU4Q/BMGSGDSK7R+6h57aYmsiY3STwSBy43L0ow/si632YMnSpHDQajkJoCMb/X4rE
	XnlIr4cfH5oyOXqxuWNs6T6IO4bW/8SCWkGFzwbSJ7m2+SXrdB+rB+Aa6cg42jrh0kRw=;
From: Ian Jackson <iwj@xenproject.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <24933.46428.243423.112077@mariner.uk.xensource.com>
Date: Tue, 12 Oct 2021 17:18:36 +0100
To: Oleksandr <olekstysh@gmail.com>
Cc: Ian Jackson <iwj@xenproject.org>,
    xen-devel@lists.xenproject.org,
    Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
    Wei Liu <wl@xen.org>,
    Anthony PERARD <anthony.perard@citrix.com>,
    Andrew Cooper <andrew.cooper3@citrix.com>,
    George Dunlap <george.dunlap@citrix.com>,
    Jan Beulich <jbeulich@suse.com>,
    Julien Grall <julien@xen.org>,
    Stefano Stabellini <sstabellini@kernel.org>,
    Juergen Gross <jgross@suse.com>,
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
    Roger Pau =?iso-8859-1?Q?Monn=E9?= <roger.pau@citrix.com>
Subject: Re: [PATCH V6 1/2] xen/arm: Introduce gpaddr_bits field to struct
 xen_domctl_getdomaininfo
In-Reply-To: <60541d52-4b44-e212-cc06-bb41e9ce67f9@gmail.com>
References: <1633974539-7380-1-git-send-email-olekstysh@gmail.com>
	<1633974539-7380-2-git-send-email-olekstysh@gmail.com>
	<24933.42667.311553.565032@mariner.uk.xensource.com>
	<60541d52-4b44-e212-cc06-bb41e9ce67f9@gmail.com>
X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu)

Oleksandr writes ("Re: [PATCH V6 1/2] xen/arm: Introduce gpaddr_bits field to struct xen_domctl_getdomaininfo"):
> > Oleksandr Tyshchenko writes ("[PATCH V6 1/2] xen/arm: Introduce gpaddr_bits field to struct xen_domctl_getdomaininfo"):
> > You say "to the toolstack", but you are exposing this information up
> > to callers of libxl.  Do you mean some higher-layer toolstack that
> > uses libxl ?  What does it use this information for ?
> >
> > FTAOD I am not opposed to exposing this in this way; indeed it seems
> > likely to be useful.  I just want to fully understand before I give
> > this my tools ack.
> 
> I didn't mean any higher-layer toolstack, sorry if I was unclear. In the 
> first place this information is
> needed by the entity which generates the device-tree for the guest on 
> Arm (tools/libs/light/libxl_arm.c) to properly calculate the extended 
> regions to be inserted into the hypervisor node.

Right, OK.  So I think this is being exposed at the libxl
gratuitously, because someone might want it in the future.
I approve :-).

Reviewed-by: Ian Jackson <iwj@xenproject.org>

Thanks,
Ian.


From xen-devel-bounces@lists.xenproject.org Tue Oct 12 16:21:08 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 16:21:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.207544.363416 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maKWY-0005oF-50; Tue, 12 Oct 2021 16:21:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 207544.363416; Tue, 12 Oct 2021 16:21:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maKWY-0005o8-1t; Tue, 12 Oct 2021 16:21:06 +0000
Received: by outflank-mailman (input) for mailman id 207544;
 Tue, 12 Oct 2021 16:21:04 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1maKWW-0005nm-8T
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 16:21:04 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1maKWP-0005RV-Cr; Tue, 12 Oct 2021 16:20:57 +0000
Received: from 54-240-197-225.amazon.com ([54.240.197.225] helo=[192.168.23.5])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1maKWP-0001m5-7U; Tue, 12 Oct 2021 16:20:57 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=sQXO04lq6vrstTxK7ij5JDZTAOLPs/BKLXVVYJ9yUJs=; b=R7QkZCtpw7uxZ14YsLh45CpZW1
	ZVhsH4HcPMDHZOWj+iqXI7PchCJQcWKUC9tQ7dmL4vvhE4Z308ZNHWxWtVg8WtBT7MwxJ4CIvaM1y
	U2K76Ytf0cjLYk+J3efnlQ+e9CIeauzWz/Non+VBLOtsNfADRjcyC5q0Bao0Kw+bkExw=;
Message-ID: <3b8ffd7d-cfc8-34c5-b0ad-aa23942dbe10@xen.org>
Date: Tue, 12 Oct 2021 17:20:54 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.2.0
Subject: Re: [PATCH v5 08/11] xen/arm: Enable the existing x86 virtual PCI
 support for ARM.
To: Bertrand Marquis <Bertrand.Marquis@arm.com>
Cc: Jan Beulich <jbeulich@suse.com>, Rahul Singh <Rahul.Singh@arm.com>,
 Andre Przywara <Andre.Przywara@arm.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Wei Liu <wl@xen.org>, Paul Durrant <paul@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <cover.1633540842.git.rahul.singh@arm.com>
 <9bdca2cda5d2e83f94dc2423e55714273539760a.1633540842.git.rahul.singh@arm.com>
 <6752f2d3-171b-37f5-c809-82995a8f3f36@suse.com>
 <CEF7FFB0-779A-4F46-8667-6BCD9BA5CB6C@arm.com>
 <2b0670e9-b442-047c-9479-daa97d6329f6@xen.org>
 <16C05F67-E3C8-44BE-9382-BF0EAA69AF5C@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <16C05F67-E3C8-44BE-9382-BF0EAA69AF5C@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit



On 12/10/2021 17:12, Bertrand Marquis wrote:
> Hi Julien,
> 
>> On 12 Oct 2021, at 16:04, Julien Grall <julien@xen.org> wrote:
>>
>> On 11/10/2021 13:41, Bertrand Marquis wrote:
>>> Hi Jan,
>>
>> Hi Bertrand,
>>
>>> As Rahul is on leave, I will answer you and make the changes needed.
>>>> On 7 Oct 2021, at 14:43, Jan Beulich <jbeulich@suse.com> wrote:
>>>> Independent of this - is bare metal Arm enforcing this same
>>>> alignment restriction (unconditionally)? Iirc on x86 we felt we'd
>>>> better synthesize misaligned accesses.
>>> Unaligned IO access could be synthesise also on arm to but I would
>>> rather not make such a change now without testing it (and there is
>>> also a question of it making sense).
>>
>> Yes it makes sense. I actually have an item in my TODO list to forbid unaligned access because they should not happen on any device we currently emulate.
>>
>> Although, I am not aware of any issue other than the guest would shoot itself in the foot if this happens.
>>
>>> So if it is ok with you I will keep that check and discuss it with Rahul
>>> when he is back. I will add a comment in the code to make that clear.
>>
>> I am OK with it.
>>
>> [...]
>>
>>>> Throughout this series I haven't been able to spot where the HAS_VPCI
>>>> Kconfig symbol would get selected. Hence I cannot tell whether all of
>>>> this is Arm64-specific. Otherwise I wonder whether size 8 actually
>>>> can occur on Arm32.
>>> Dabt.size could be 3 even on ARM32 but we should not allow 64bit
>>> access on mmio regions on arm32.
>>
>> Hmmm... Looking at the Armv7 and Armv8 spec, ldrd/strd (64-bit read) would not present a valid ISV. So I think it is not be possible to have dabt.size = 3 for 32-bit domain. But I agree we probably want to harden the code.
>>
>>> So I will surround this code with ifdef CONFIG_ARM_64 and add a test
>>> for len > 4 to prevent this case on 32bit.
>>> To be completely right we should disable this also for 32bit guests but
>>> this change would be a bit more invasive.
>>
>> I think the following should be sufficient:
>>
>> if ( is_domain_32bit_domain() && len > 4 )
>>   return ...;
> 
> With the last request from Roger to use the function implemented in arch/x86/hw/io.c, the function will move to vpci.h so using is_32bit_domain will not be possible without ifdefery CONFIG_ARM.
> Also I have no access to the domain there.
> 
> So the best I can do for now would be something like:
> #ifdef CONFIG_ARM_32
> If (len == 8)
>      return false
> #endif
> 
> A 32bit guest on 64bit xen would not be checked.
> 
> Would that be ok for now ?

I think the #ifdef is a bit pointless. My preference would be to not add 
the #ifdef but instead add...

> 
> I could add a comment in the code to warn about the limitation.

.. a comment for now as this is only an hardening problem.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Tue Oct 12 16:29:59 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 16:29:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.207553.363427 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maKf3-0006Vg-1v; Tue, 12 Oct 2021 16:29:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 207553.363427; Tue, 12 Oct 2021 16:29:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maKf2-0006VZ-Tc; Tue, 12 Oct 2021 16:29:52 +0000
Received: by outflank-mailman (input) for mailman id 207553;
 Tue, 12 Oct 2021 16:29:50 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1maKf0-0006VT-Rf
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 16:29:50 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1maKf0-0005b4-JF
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 16:29:50 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1maKf0-0002qo-IJ
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 16:29:50 +0000
Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89)
 (envelope-from <iwj@xenproject.org>)
 id 1maKes-0004xy-Bo; Tue, 12 Oct 2021 17:29:42 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date
	:Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From;
	bh=EBkK6viJRmkY+pR9mowse6hT7mAhVZEi3oWpREtJ/Pc=; b=ZDqVc1/GGeCofWRwqPQibMHtzR
	Fw1LsOrWvn2OSL3b60VAbB6qfEublh9Sw0H8Ix5OSGwGkhPvGKs7juqiIMHZAj6oOmgW1ACUw5xcJ
	LsOMmpaRG5Yv5NeCInGLL+bA+Wv0+ZElds9J/vHHVEWiPdHXf8JI4SQcJdw6Si61jhUc=;
From: Ian Jackson <iwj@xenproject.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <24933.47094.43672.782143@mariner.uk.xensource.com>
Date: Tue, 12 Oct 2021 17:29:42 +0100
To: Bertrand Marquis <Bertrand.Marquis@arm.com>
Cc: Jan Beulich <jbeulich@suse.com>,
    Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>,
    Rahul Singh <Rahul.Singh@arm.com>,
    "xen-devel\@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
    Andre  Przywara <Andre.Przywara@arm.com>,
    Wei Liu <wl@xen.org>,
    Juergen Gross <jgross@suse.com>,
    Stefano Stabellini <sstabellini@kernel.org>,
    Roger Pau =?iso-8859-1?Q?Monn=E9?= <roger.pau@citrix.com>
Subject: Re: [PATCH v5 01/11] xen/arm: xc_domain_ioport_permission(..) not
 supported on ARM.
In-Reply-To: <AB6D62B6-2ED2-4957-A933-08EC77A4DFD6@arm.com>
References: <cover.1633540842.git.rahul.singh@arm.com>
	<d292392268df2c74c4103a82ef917072643407a8.1633540842.git.rahul.singh@arm.com>
	<YWQkblfNMYEs6jI9@MacBook-Air-de-Roger.local>
	<77CF7FA5-C566-469E-B4A8-0400789890BB@arm.com>
	<YWQ6Nk3Jk+BqgkwZ@MacBook-Air-de-Roger.local>
	<53AE6E2A-01D7-41EC-9B2C-C0D596EB8D4D@arm.com>
	<YWRCxXGQIyTOAepC@MacBook-Air-de-Roger.local>
	<FEF0B03A-5AC8-4F8D-B821-191AC2EF8295@arm.com>
	<ac6d4785-ac9a-4491-26bb-c66ffe82c55b@suse.com>
	<ED8FC92F-B5EF-4473-B4A9-641C7D44859F@arm.com>
	<0744b957-1832-dff2-9ae2-b8e8534f501b@suse.com>
	<c3952fd5-b893-4cb6-a9bc-325a89e859db@epam.com>
	<c125b447-53e8-7d13-3b08-af62fd3a9140@suse.com>
	<c6b6c22f-fb8a-f2d9-7735-f1ebc9809908@epam.com>
	<09656882-b297-7144-c291-1ee997edb119@suse.com>
	<69A83587-B7E0-4653-AF8C-AEE802922CE5@arm.com>
	<24933.41349.893363.203683@mariner.uk.xensource.com>
	<AB6D62B6-2ED2-4957-A933-08EC77A4DFD6@arm.com>
X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu)

Bertrand Marquis writes ("Re: [PATCH v5 01/11] xen/arm: xc_domain_ioport_permission(..) not supported on ARM."):
> I can add something in the commit message about the fact that we improve
> performance and prevent to do a call that is and will not be supported in Xen.

Thanks but I'm afraid I don't think that is a correct summary of the
thread.  Nor would it be an adequate justification for the change.  At
least, not unless you plan to write something considerably longer (and
more precise).

Firstly, I'm not convinced this change would be justified by the
performance impact.  This is a small number of hypercalls during
domain startup.  Usually none, I think ?  If someone wants to optimise
domain startup speed then I am very open to that but I think this
change will make negligible change in practice.  Unless someone wants
to tell me I'm wrong about that ?  And if I am wrong about that then
an explanation of why my suppositions are wrong ought to go in the
commit message.

Secondly, there is no justification there for the change in error
status.

Why is this change needed ?  (What goes wrong if it is omitted ?)
That is what the commit message ought to answer.

Plus, given that it stubs out a function to make it into a no-op, that
itself requires an explanation.  Why is it OK for this function which
is supposed to do a thing, to in fact not do anything at all and
return successfully saying "yes I did that" ?

I think (having read the thread) that I know the answers to these
questions but it needs to be clearly and explicitly written down.

> I saw your change in CODING_STYLE and I understand the request.
> I will try to see if we can handle this change before the feature freeze.

Thanks.  I doubt that this will be hard.  I am more worried about the
commit message.

Indeed, since we haven't had the rationale for this change explicitly
written down, there is a risk that when we do so, we will discover
some problem with the approach that we had previously overlooked.

Discovering that kind of thing is one reason to explicitly write down
why we are doing what we are doing, but this situation does mean we
shouldn't feel we've yet achieved confidence that this patch is right.

Sorry,
Ian.


From xen-devel-bounces@lists.xenproject.org Tue Oct 12 17:19:21 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 17:19:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.207566.363438 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maLQe-0002xU-NB; Tue, 12 Oct 2021 17:19:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 207566.363438; Tue, 12 Oct 2021 17:19:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maLQe-0002xN-JZ; Tue, 12 Oct 2021 17:19:04 +0000
Received: by outflank-mailman (input) for mailman id 207566;
 Tue, 12 Oct 2021 17:19:04 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+iE3=PA=oracle.com=boris.ostrovsky@srs-us1.protection.inumbo.net>)
 id 1maLQd-0002xH-Ss
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 17:19:04 +0000
Received: from mx0a-00069f02.pphosted.com (unknown [205.220.165.32])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 2f1c4d98-ee40-49e6-a344-f94358c2f23a;
 Tue, 12 Oct 2021 17:19:02 +0000 (UTC)
Received: from pps.filterd (m0246629.ppops.net [127.0.0.1])
 by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 19CGodtu030660; 
 Tue, 12 Oct 2021 17:18:55 GMT
Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70])
 by mx0b-00069f02.pphosted.com with ESMTP id 3bmq3bh5k4-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Tue, 12 Oct 2021 17:18:49 +0000
Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1])
 by aserp3020.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 19CHF1iH059903;
 Tue, 12 Oct 2021 17:17:48 GMT
Received: from nam10-dm6-obe.outbound.protection.outlook.com
 (mail-dm6nam10lp2105.outbound.protection.outlook.com [104.47.58.105])
 by aserp3020.oracle.com with ESMTP id 3bmadyc6r6-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Tue, 12 Oct 2021 17:17:48 +0000
Received: from BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10)
 by BLAPR10MB5011.namprd10.prod.outlook.com (2603:10b6:208:333::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.19; Tue, 12 Oct
 2021 17:17:46 +0000
Received: from BLAPR10MB5009.namprd10.prod.outlook.com
 ([fe80::3c49:46aa:83e1:a329]) by BLAPR10MB5009.namprd10.prod.outlook.com
 ([fe80::3c49:46aa:83e1:a329%5]) with mapi id 15.20.4587.026; Tue, 12 Oct 2021
 17:17:46 +0000
Received: from [10.197.176.156] (160.34.88.156) by
 SN6PR01CA0001.prod.exchangelabs.com (2603:10b6:805:b6::14) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4587.18 via Frontend Transport; Tue, 12 Oct 2021 17:17:43 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2f1c4d98-ee40-49e6-a344-f94358c2f23a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date :
 subject : to : cc : references : from : in-reply-to : content-type :
 content-transfer-encoding : mime-version; s=corp-2021-07-09;
 bh=cGE2TuyHkADiEiPmnl62LUEd6AbpUdfTJ7Tgho8OOFk=;
 b=dn4J501pUw8bE1sSNrduhW8vUBPxBGlmPEFlYtfbhk7OooKmJYM3a0CfQ2XyerT+kEXH
 SQdPvwGJA8ThD882iIKtC2R9z6DXbK1UgEMcdePOHS79SU13L4Rk/G00gSO3A1QJfKAB
 dqwFrOkWNfQnWBuj+B2PT0dthB8pycQjloyu97LbP4domKkEgZ8RDKuIqCAy0Lww8dwV
 j2rWeEMNK5hbpazL7NvhvmllgxLJeZE5sYaCun84j8ynR+EUULz1uYtSDBZrA8qMNqlw
 s50yo/CX1tOfx06T1uIEaFiLA6Ywpw5Lqa9LdQe29YG7dmnldPx0oWAghAd3SSYZCCcG 3A== 
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=a827fbOd0h84gzNT+TLPqvfFSJl2m9x3QTr7NmoAFLcfHEOCrI4BU8S9QBsO/wGetRqkUFwcU3rHJKCb5q0S7Di1b6FAfBaRLmSw4QEmML1hZ1cV/fP9gNZkwfzPtVKKA6ZlrqsEzLPhi0wGWN7PgShnUjOCF2VXGuzyJQPdYJasF0o2A5oPGzrvsqIvCpUs0VEHYNbsvjWPHHbPQmy6DIfkJ15nBHsOkvBTTLJIr4EDHfdao5cqgX8VOixfCWh/0hjrFNwEQuvp7ZFotf/QiqawYP5QGk7cSKQgujeO4et+eSQXdd84s1ck6Q5n26cpkpCIvwX1BfI/Qmlsvk7SOw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=cGE2TuyHkADiEiPmnl62LUEd6AbpUdfTJ7Tgho8OOFk=;
 b=YYYwRz/l4ZnemluR+0bW4JXdHxDNVIuZm08MNc6TRZzQSqK8YxhxWPhqhHLUbEUrD2+9ZeNRoVOznj0JIZ51BzIXlWSk5RUeph71NkgP72DvYZnxhTT4X5g8Kbf/InFrYqCL4yhyrhwi2taBAczRGaPxYBAUInx4soS337BziQ8kQ1eAc2Diwc84TSQ63m6+hxb33SyaKl5CVHcXZz+ay1ZcBlUWPngOwnFWPa1mW+DLeOAs+b7YRiFLpArG4eNH47Pw4wALD1ohvTTqSmF3rUhry1NlsWzelNE2LI4Fkc+4frWb0NzCmmxQo/YH++FEgNQ8R7EQNep8YHHrB+IaBQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com;
 dkim=pass header.d=oracle.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=cGE2TuyHkADiEiPmnl62LUEd6AbpUdfTJ7Tgho8OOFk=;
 b=lpg3nMxjxpDG+Oy1c9xZeo/936p5Bxoq0iYyovIJmdIeEO5tMAeQi7o3LqyOfODvtvCpzTYBB9vP1t2bC3P1dpSlPR7jUoNhjKvdKy5dqkhJMbmm8nOnr9DSkyDAaA+xj0oR/QruE+1QmfoJ/qcNdwcGnTy4eGgAxbFsUtTnADg=
Authentication-Results: oracle.com; dkim=none (message not signed)
 header.d=none;oracle.com; dmarc=none action=none header.from=oracle.com;
Message-ID: <4faf461f-49ca-5f2b-a7dc-e2b47b904527@oracle.com>
Date: Tue, 12 Oct 2021 13:17:41 -0400
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.1.2
Subject: Re: [PATCH linux 1/2] xen: delay xen_hvm_init_time_ops() if kdump is
 boot on vcpu>=32
Content-Language: en-US
To: Dongli Zhang <dongli.zhang@oracle.com>, xen-devel@lists.xenproject.org
Cc: linux-kernel@vger.kernel.org, x86@kernel.org, jgross@suse.com,
        sstabellini@kernel.org, tglx@linutronix.de, mingo@redhat.com,
        bp@alien8.de, hpa@zytor.com, andrew.cooper3@citrix.com,
        george.dunlap@citrix.com, iwj@xenproject.org, jbeulich@suse.com,
        julien@xen.org, wl@xen.org, joe.jin@oracle.com
References: <20211012072428.2569-1-dongli.zhang@oracle.com>
 <20211012072428.2569-2-dongli.zhang@oracle.com>
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
In-Reply-To: <20211012072428.2569-2-dongli.zhang@oracle.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: SN6PR01CA0001.prod.exchangelabs.com (2603:10b6:805:b6::14)
 To BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: a8202eba-6dee-49ee-ec7e-08d98da43554
X-MS-TrafficTypeDiagnostic: BLAPR10MB5011:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: 
	<BLAPR10MB5011128324CC2F95C2AF13058AB69@BLAPR10MB5011.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7691;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 
	/ORgMNsdmgGiQ9nTtEktdMCoMizc2nO5HgQyIt9DOqMy+mwzbLZjCIi/QX0w5nXltqnw0JMn/cNN0+GbqRrEsdL12pXdWfY+yiINwi73OOL6HcAHK89wsOg+zcbxeWmyLcKVhagWKlKg9ZRZ2Ow00jbuSxYMdbihvQFrVEfGvnk5Unpc55FuTVUe3p0mC3yTpcFsheCyZ1X16CXFqCke0ijzJeSIYQ/eE1zWEURUurI97BNRVwNCS1jmPcXn7lRq0SlmWotzLNgzXdpAgmvgFyPYADw9jHYFn4QdIPvIh4Z87Z2iZ2JDrCXh3FXp8TfRcz+gmPZl1pZrtXUNTpqEdiO7xJa/BuT/3J+qBLFjE5YUm9UiV5wp61ZOB0fta5lMUamDVnhvQmfEFvX7lZqWdoUzi/mtmSH6x01T1qekx0xyHi5eLBlcDfcQR2mxCbaUIuJPb2N1D71lZvo+yw18AF+260A4VGJUl0IARP2RgS0LPMS050PD5NQim6vhVaOoNDdApuA1zhdHdrMTfj3Vy7l5HaQE/j0PFksMQ99OZUgFc94i4XV9FFYSM79Xt4iRJ+0566JRhl5MjPDu7xbSwjlPkndJP+4RyKZ3G0Ivt2kA/r6B0UiDd4iB0cw/vFIM5GX2DRJTFLssZao95o7/w8udWgArtQQQWWuJT8SMO8uf4vV58yd0XXRsEgcrip8ToRmL780nOUc/3Ofvfc11uw==
X-Forefront-Antispam-Report: 
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB5009.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(7416002)(38100700002)(508600001)(16576012)(5660300002)(26005)(4326008)(6486002)(53546011)(86362001)(44832011)(36756003)(66476007)(66556008)(8676002)(316002)(2906002)(31696002)(8936002)(66946007)(83380400001)(31686004)(2616005)(186003)(956004)(107886003)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?Qk9iTnpGU0VvL1M1QW1ZS3QramtBR2llQVMrOExsb3ZaNkZad3JoU2dGM2ty?=
 =?utf-8?B?bkpHMDhaQWZSb0ZxcUQ0MDZTWnNrdUwzaVUxdmdtNHZTQ2lRTnhVZldaN0ow?=
 =?utf-8?B?YlVYVEVQTGVYeTFWczQ2L09zLzRKNEt5eUpOOS9US3dKVnRCbXNLeUNvT050?=
 =?utf-8?B?dnAxRkk5VEtIaW93dHpFUEJHRmVUYzJzL2ZIVG1hcjZzV201TTkxeXB1NjdM?=
 =?utf-8?B?c2o0K0wyelJsNGl4eklvQnNQU01DOFpBVHVJRVVhUmlWdWZpcHVsU3dQdkZw?=
 =?utf-8?B?dWZHRk1jQVpGajJMa0RFdEdWb1lEOGpnTWhUMTR5czhLSG1DdEkzaW5HVkRZ?=
 =?utf-8?B?alVSUTl5MTQ4emVJZGNMbm8xUlorVTh6ZThwOGFKbmt2RjYweFdpWXQ3VDNZ?=
 =?utf-8?B?blpib3JqMDBWL2FXaFpqTGZrU2FtaTFDamRPekZaN2l4UnJEOUJOUm80cEkw?=
 =?utf-8?B?OE8yN1UrSkJIajJwVEFWcnBKV1hiOENuazl2R3hTVlVBT0o3aFdiYUtXanVu?=
 =?utf-8?B?YlpUWm9lVDZ2YW84OVlXdlI3YVFjRTE4d0JNWHl6WnhnMmlKL2FCSC9NbWE0?=
 =?utf-8?B?ejdsajVkNS91eTBpalBMOHJUeHhOVUxQSG1hVGRVcER2Z2lURDFXMHNyOCt0?=
 =?utf-8?B?SEtIUmx6azNQSXFpaFdvY3N3OFRtbjIvZk5tN21sSGtPR1d2ZER2MkxJak40?=
 =?utf-8?B?dnJoUUlKZHY4WGxLOW8wYnNYR1dQZFNraW9Cc2pnM2Zadkh4ZUtmN1R1SjlI?=
 =?utf-8?B?K2Z0NFJBSEtzbHNGdDQ5TkErRWl1bGpwNER3T2NYK2RSK3BQUlBqWFBGSmRa?=
 =?utf-8?B?ODNNMVlMazhnbWhDRUtDN0hVVU9uMkFVWWdMT05NTG4vN1B0R2VMYVN2Qmds?=
 =?utf-8?B?dmowNWZoa2hSV1pPMGx2eXVDdHdLMU40Mk0wbko5T0ppSXV2R2hCQjNmNEtS?=
 =?utf-8?B?RTg1ZjJJZVRabzRtZGFURzJwY3d0SEdCUmNPMmlYTkI1N0RqOEN3eUtxakFF?=
 =?utf-8?B?SmxxWnNCMlk5NWt2WEF1cWdnWHBiQUZlRFREQ0RhclZlUnFPOUozR0l5WTNS?=
 =?utf-8?B?cytnSjREUEl4SWNlaURaNHhTR09Db1A1S3d0Yk80dTZHNEtnWmE5bWdTa2hu?=
 =?utf-8?B?ai9iVVZqUGdQaTFWbE5CcHRvSksxdXhlWmNDQmRiL2p5S1E2SU5veG9aQ0ZW?=
 =?utf-8?B?S1YvdW1GcFU2eXRBZHVDbXZYVHFsV3VzY1ZSMmJabnRBSjBLRitzdlBNUHVQ?=
 =?utf-8?B?VmJodzVvcytlNS9SdDJBTEwzcU5lZzkzUlBsNG40N2JoT05yWmN0OGVqUHhB?=
 =?utf-8?B?M080d3Vuc2RKT3JvQ3M4SG4vczV0TE5SSmQ3MUc1OC84eGM3VWtrdnE5OUND?=
 =?utf-8?B?NUJqb3dCME9uT3cyeWdtSDRDRkY2V2RkUXZJb2pnaWwzN20zYmNtYWUvWXJO?=
 =?utf-8?B?dDhIbnZpWDFJSEhKcXB1OExmNDVlUVpLcmROaW8yWTRwb3FXaURmSE9TTS9q?=
 =?utf-8?B?Z3E1M2krelRtbzFFZlZIZWV2eFg0WWFVdzFHV202Tmd0aC9LZjdwWERSblFJ?=
 =?utf-8?B?b0QyV0oxUVRnRWpnWFBCeENBOTF1aXNHOHlySnp0WDdOeHd6UUJ1bkNTV3Rn?=
 =?utf-8?B?ZWNZOG5WVjMrTHovZ0w0YW44QnBtRHdERjJZM1ovcHUvdW1pNVJSVUtQRDJw?=
 =?utf-8?B?dXZJSE83Ri9tL3lHK3lXUDN5Nmo1VUtOc2pMRkZkNFU1MlE1Mm5oM096NDF5?=
 =?utf-8?Q?APl33gyOHJbNrI2xoBC8vFua5uOqF5f/hULZszI?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a8202eba-6dee-49ee-ec7e-08d98da43554
X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2021 17:17:46.0528
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: JBGkQcaIDrzxh7Vh4RtVFV7DVEOdlZDKHFDFpnMCEohwRmZ/XiJ4rl5znnlH6hcdIgG5afRalkUcEEHVFxySEeO+UIWCM4bR0yoCxBUKGY0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB5011
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10135 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 phishscore=0
 suspectscore=0 mlxlogscore=999 bulkscore=0 mlxscore=0 malwarescore=0
 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2109230001 definitions=main-2110120095
X-Proofpoint-GUID: Z5UMs2uxpJAH0edED9hpu0XtQI0kY1Yz
X-Proofpoint-ORIG-GUID: Z5UMs2uxpJAH0edED9hpu0XtQI0kY1Yz


On 10/12/21 3:24 AM, Dongli Zhang wrote:
> The sched_clock() can be used very early since upstream
> commit 857baa87b642 ("sched/clock: Enable sched clock early"). In addition,
> with upstream commit 38669ba205d1 ("x86/xen/time: Output xen sched_clock
> time from 0"), kdump kernel in Xen HVM guest may panic at very early stage
> when accessing &__this_cpu_read(xen_vcpu)->time as in below:


Please drop "upstream". It's always upstream here.


> +
> +	/*
> +	 * Only MAX_VIRT_CPUS 'vcpu_info' are embedded inside 'shared_info'
> +	 * and the VM would use them until xen_vcpu_setup() is used to
> +	 * allocate/relocate them at arbitrary address.
> +	 *
> +	 * However, when Xen HVM guest panic on vcpu >= MAX_VIRT_CPUS,
> +	 * per_cpu(xen_vcpu, cpu) is still NULL at this stage. To access
> +	 * per_cpu(xen_vcpu, cpu) via xen_clocksource_read() would panic.
> +	 *
> +	 * Therefore we delay xen_hvm_init_time_ops() to
> +	 * xen_hvm_smp_prepare_boot_cpu() when boot vcpu is >= MAX_VIRT_CPUS.
> +	 */
> +	if (xen_vcpu_nr(0) >= MAX_VIRT_CPUS)


What about always deferring this when panicing? Would that work?


Deciding whether to defer based on cpu number feels a bit awkward.


-boris


> +		pr_info("Delay xen_hvm_init_time_ops() as kernel is running on vcpu=%d\n",
> +			xen_vcpu_nr(0));
> +	else
> +		xen_hvm_init_time_ops();
> +
>   	xen_hvm_init_mmu_ops();
>   


From xen-devel-bounces@lists.xenproject.org Tue Oct 12 17:43:07 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 17:43:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.207578.363449 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maLnp-00061U-Gs; Tue, 12 Oct 2021 17:43:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 207578.363449; Tue, 12 Oct 2021 17:43:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maLnp-00061N-Dg; Tue, 12 Oct 2021 17:43:01 +0000
Received: by outflank-mailman (input) for mailman id 207578;
 Tue, 12 Oct 2021 17:43:00 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=P4MT=PA=gmail.com=olekstysh@srs-us1.protection.inumbo.net>)
 id 1maLno-00061H-5B
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 17:43:00 +0000
Received: from mail-lf1-x135.google.com (unknown [2a00:1450:4864:20::135])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 7f203c0a-77ce-4be0-a8d5-4b344e967ad0;
 Tue, 12 Oct 2021 17:42:58 +0000 (UTC)
Received: by mail-lf1-x135.google.com with SMTP id u18so178813lfd.12
 for <xen-devel@lists.xenproject.org>; Tue, 12 Oct 2021 10:42:58 -0700 (PDT)
Received: from [192.168.1.7] ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id d19sm153457ljl.87.2021.10.12.10.42.56
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Tue, 12 Oct 2021 10:42:56 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7f203c0a-77ce-4be0-a8d5-4b344e967ad0
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-transfer-encoding:content-language;
        bh=dK4ua2lDNHlXsDLHwVmhdELBgpGCr+QC72Sg5VHaAIU=;
        b=bMoq/ybZofaez4eA/R3gqaauLN9TM/A28FsB5czmMVpcoSOb3JF4vygHaeBkmcPfTl
         G7WK1axfw/SNEvguHUhnLV5lNQXyZLFltiTrZbFQstNfo6FFS+kGcvqrlQk4TXFQ52tS
         YHQQcJVi4jCf4g9BDXwuwmpBwa5/RHe1Ai8XOmt87o9Q6YqDv3w0BOIJzFTwFu2XHCSw
         sNvO50SPMSg0AQvXJoiM9nJL7RIjrWNW/bYpXtqMGdl8whfX1E41eGuewCoHsu7FDd7D
         EaViVZGmED/X/tiw8LGgDzAtlG0a1EonYcUklPE8VgW2LPMx7GGVsYhv66wrNmmxEUAG
         d/aA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding
         :content-language;
        bh=dK4ua2lDNHlXsDLHwVmhdELBgpGCr+QC72Sg5VHaAIU=;
        b=zO7SMSqqYE5fZmdpAdzHiDQsg7Ka4NPJMsHQcDiAgHLXnayYWEKDnJTKghZVMm/HC2
         y9dM1ukrezvjdvL3ZsbJGpKsXO+vODAMq4tKXBiGoAagRdDQlYN/MmunZ+fqk6ANfol4
         orxo5g4zmaG/ZHnPWEerm/Mj+JHDn6XzNQdVACRfkMxwUNOx2FKjoOamTQHKeNkE3kJA
         ZWcVpFINyQ0+alUs8nxv2psOXhLuJ9R1DtnqOz8bTo2PlB0+Q4Za4i0+qLJS8tdjGkpa
         GIkap8KMz3RNfktVDWl8Um1H7IVmE8NMMgvIFZgt4rhqjl8+30KM8jl4kQIOxqJqMzOh
         Y/qA==
X-Gm-Message-State: AOAM533dUimBgoSTac6hUGMPZBEU0JrRQaQQpqK8CnuGgt7NQEahDN83
	lXjJupkQttufiPnW6F6mWCw=
X-Google-Smtp-Source: ABdhPJzIHjMPQyz6B9/s7LKige4HDV3EFiiQwYB5WBFN4AloMXMlFNTRqPlMC/iyKYswf+IEkuZA3g==
X-Received: by 2002:a05:6512:4029:: with SMTP id br41mr20572595lfb.233.1634060577115;
        Tue, 12 Oct 2021 10:42:57 -0700 (PDT)
Subject: Re: [PATCH V6 2/2] libxl/arm: Add handling of extended regions for
 DomU
To: Julien Grall <julien@xen.org>
Cc: xen-devel@lists.xenproject.org,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>,
 Anthony PERARD <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <1633974539-7380-1-git-send-email-olekstysh@gmail.com>
 <1633974539-7380-3-git-send-email-olekstysh@gmail.com>
 <c98c1acd-86c0-f556-643e-e472b696644f@xen.org>
From: Oleksandr <olekstysh@gmail.com>
Message-ID: <51f9154f-3b65-c7c0-cd93-cecdc2a0975e@gmail.com>
Date: Tue, 12 Oct 2021 20:42:56 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <c98c1acd-86c0-f556-643e-e472b696644f@xen.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US


On 12.10.21 19:05, Julien Grall wrote:
> Hi Oleksandr,

Hi Julien



>
> On 11/10/2021 18:48, Oleksandr Tyshchenko wrote:
>> ---
>>   tools/libs/light/libxl_arm.c  | 76 
>> ++++++++++++++++++++++++++++++++++++++++---
>>   xen/include/public/arch-arm.h |  2 ++
>>   2 files changed, 73 insertions(+), 5 deletions(-)
>>
>> diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c
>> index e3140a6..c0e8415 100644
>> --- a/tools/libs/light/libxl_arm.c
>> +++ b/tools/libs/light/libxl_arm.c
>> @@ -598,9 +598,20 @@ static int make_timer_node(libxl__gc *gc, void 
>> *fdt,
>>       return 0;
>>   }
>>   +#define ALIGN_UP_TO_2MB(x)   (((x) + MB(2) - 1) & (~(MB(2) - 1)))
>> +
>>   static int make_hypervisor_node(libxl__gc *gc, void *fdt,
>> -                                const libxl_version_info *vers)
>> +                                const libxl_version_info *vers,
>> +                                const libxl_domain_build_info *b_info,
>> +                                const struct xc_dom_image *dom)
>>   {
>> +    uint64_t region_size[GUEST_RAM_BANKS] = {0}, 
>> region_base[GUEST_RAM_BANKS],
>> +        bank1end, ramsize;
>> +    uint32_t regs[(GUEST_ROOT_ADDRESS_CELLS + GUEST_ROOT_SIZE_CELLS) *
>> +                  (GUEST_RAM_BANKS + 1)];
>> +    be32 *cells = &regs[0];
>> +    unsigned int i, len, nr_regions = 0;
>> +    libxl_dominfo info;
>>       int res;
>>       gic_interrupt intr;
>>   @@ -615,9 +626,64 @@ static int make_hypervisor_node(libxl__gc *gc, 
>> void *fdt,
>>                                 "xen,xen");
>>       if (res) return res;
>>   -    /* reg 0 is grant table space */
>> -    res = fdt_property_regs(gc, fdt, GUEST_ROOT_ADDRESS_CELLS, 
>> GUEST_ROOT_SIZE_CELLS,
>> -                            1,GUEST_GNTTAB_BASE, GUEST_GNTTAB_SIZE);
>> +    if (strcmp(dom->guest_type, "xen-3.0-aarch64")) {
>> +        LOG(WARN, "The extended regions are only supported for 
>> 64-bit guest currently");
>> +        goto out;
>> +    }
>
> I understand why we want to limit to 64-bit domain for dom0. But I am 
> not sure this is warrant for 32-bit domain. At worse, the guest will 
> ignore the bank because it is not usable. So could we drop the check?

Yes.


>
>
>> +
>> +    res = libxl_domain_info(CTX, &info, dom->guest_domid);
>> +    if (res) return res;
>> +
>> +    assert(info.gpaddr_bits >= 32 && info.gpaddr_bits <= 48);
> What could go wrong below if gpaddr_bits is not within this range?

if info.gpaddr_bits is less than 64, then nothing bad, otherwise, I 
assume we will get shift count overflow.


>
>
>> +
>> +    /*
>> +     * Try to allocate separate 2MB-aligned extended regions from 
>> the first
>> +     * (below 4GB) and second (above 4GB) RAM banks taking into the 
>> account
>> +     * the maximum supported guest physical address space size and 
>> the amount
>> +     * of memory assigned to the guest.
>> +     * As the guest memory layout is not populated yet we cannot 
>> rely on
>> +     * dom->rambank_size[], so calculate the actual size of both 
>> banks using
>> +     * "max_memkb" value.
>> +     */
>
> At the moment, libxl doesn't know how libxc will allocate the memory. 
> We may decide in the future to have only a small amount of memory 
> below 4GB and then the rest above 4GB. With this approach it would be 
> more difficult to modify the memory layout. Instead, I think we should 
> create a placeholder that is updated once we know the banks in 
> libxl__arch_domain_finalise_hw_description.

If I got your point correctly, this is close to how it was done from the 
beginning. Yes, we can create placeholder(s) here and then update them 
once the memory layout is populated. The problem is that we won't be 
able to remove the placeholder(s) if we fail to allocate region(s) for 
some reasons. So, we should know for sure in advance how many region(s) 
we will be able to allocate later on in order to create the required 
number of placeholders right now...  Please, look at the TODO I wrote in 
finalise_ext_region() [1]. Or I misread your point?


>
>
> We also probably want to mention in the memory layout in 
> public/arch-arm.h this decision as the suggested way to find extended 
> regions will definitely impact our decision to re-order the memory 
> layout or shrink some regions in the future (I have in mind the PCI 
> Passthrough work).

Sorry, I couldn't parse.


>
>
>> +    ramsize = b_info->max_memkb * 1024;
>> +    if (ramsize <= GUEST_RAM0_SIZE) {
>> +        region_base[0] = GUEST_RAM0_BASE + ALIGN_UP_TO_2MB(ramsize);
>> +        region_size[0] = GUEST_RAM0_SIZE - ALIGN_UP_TO_2MB(ramsize);
>> +        region_base[1] = GUEST_RAM1_BASE;
>> +    } else
>> +        region_base[1] = GUEST_RAM1_BASE +
>> +            ALIGN_UP_TO_2MB(ramsize - GUEST_RAM0_SIZE);
>> +
>> +    bank1end = min(1ULL << info.gpaddr_bits, GUEST_RAM1_BASE + 
>> GUEST_RAM1_SIZE);
>> +    if (bank1end > region_base[1])
>> +        region_size[1] = bank1end - region_base[1];
>
> It would be best to not rely on the fact that Bank on is always below 
> 4GB. If the code is too complex then we should look to add a 
> BUILD_BUG_ON() to avoid any surprise.

Yes, I can add:

BUILD_BUG_ON((GUEST_RAM0_BASE + GUEST_RAM0_SIZE) > GB(4));


[1] 
https://lore.kernel.org/xen-devel/1631297924-8658-4-git-send-email-olekstysh@gmail.com/


>
> Cheers,
>
-- 
Regards,

Oleksandr Tyshchenko



From xen-devel-bounces@lists.xenproject.org Tue Oct 12 17:51:09 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 17:51:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.207587.363460 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maLvd-0007Wl-GQ; Tue, 12 Oct 2021 17:51:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 207587.363460; Tue, 12 Oct 2021 17:51:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maLvd-0007We-C0; Tue, 12 Oct 2021 17:51:05 +0000
Received: by outflank-mailman (input) for mailman id 207587;
 Tue, 12 Oct 2021 17:51:03 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=B8jq=PA=arm.com=Bertrand.Marquis@srs-us1.protection.inumbo.net>)
 id 1maLvb-0007WY-JJ
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 17:51:03 +0000
Received: from EUR05-AM6-obe.outbound.protection.outlook.com (unknown
 [2a01:111:f400:7e1b::620])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id d8cc1dfd-39c6-4ded-b6ac-e54e634bfe28;
 Tue, 12 Oct 2021 17:51:01 +0000 (UTC)
Received: from AM6PR04CA0070.eurprd04.prod.outlook.com (2603:10a6:20b:f0::47)
 by DB6PR08MB2840.eurprd08.prod.outlook.com (2603:10a6:6:1d::31) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.25; Tue, 12 Oct
 2021 17:50:59 +0000
Received: from AM5EUR03FT008.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:f0:cafe::19) by AM6PR04CA0070.outlook.office365.com
 (2603:10a6:20b:f0::47) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.26 via Frontend
 Transport; Tue, 12 Oct 2021 17:50:59 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM5EUR03FT008.mail.protection.outlook.com (10.152.16.123) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4587.18 via Frontend Transport; Tue, 12 Oct 2021 17:50:58 +0000
Received: ("Tessian outbound 16951d3c485e:v103");
 Tue, 12 Oct 2021 17:50:58 +0000
Received: from bae1d77b7cc4.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 3DB1B3CD-C2B0-4EBF-BA65-21781853F670.1; 
 Tue, 12 Oct 2021 17:50:52 +0000
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id bae1d77b7cc4.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Tue, 12 Oct 2021 17:50:52 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com (2603:10a6:4:74::9)
 by DB8PR08MB5050.eurprd08.prod.outlook.com (2603:10a6:10:e2::18) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.25; Tue, 12 Oct
 2021 17:50:50 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955]) by DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955%4]) with mapi id 15.20.4587.026; Tue, 12 Oct 2021
 17:50:50 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d8cc1dfd-39c6-4ded-b6ac-e54e634bfe28
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=uTEBRcsMW//GFyUzf19PhZO+G+xGbKzglhWcA6XKiDo=;
 b=kMuFbV2NMRttS17qE4KcmBixKESw5QKwTTL3oa8L0vGY+VgjWpQm9lJC+CsZ2hiohOtkFMcJ4s7vOWv7OhQNNFBHoG1SSKY7uIZBRojoi5JyALh6k4zWQO1bGX69JtFxwrQGRV6xJJ+ozSIG/NX9FcOFNcg7wOXJBGzRxBABddQ=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: dc805b360c3f225b
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=YxwFx2AxeCy/uXutu+m3D5v98EitDEPLVdf5Xekp3TWjWgvIGUh3Y5Am3T2C7ABjH4V/qHk9rRW+sK6sHsfhENLg7ocxjNx7qmuNqSXsB0AKWwrgHEMCtkuvc2zMvWN40Og5y7DckeCcasXgYouqJEzjxVPixCGld2wVLcIRTMBHMblSWvhGJHel4dRKGW++QXDLvi+wz9jPfvJByUO0Bi74YsG5cUAvOf6LL8UsXKNFfuRoHRlDNUB2L88H35w6rU1Dnqom68T71Ivl6JdVnq53+b8snWUCvtsitZ4ep1253Y3gEaHURudFL2bdylSe7KXFSidG3/tLIvzoj5E5uw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=uTEBRcsMW//GFyUzf19PhZO+G+xGbKzglhWcA6XKiDo=;
 b=mMvkMcocUK3oC302diekuy752nchdxXaSjAqgoP8icmhhUYVURE3pFH3cs/XeP6vMjO354vNrlMB+PS/njiAlwZ9G3XlCeLhzAbArWz90ZVuUMT4vUwBHfOI6z868eO7pRapU1VfZZc9kIiqsfpvWFoL0wg+5h1XdgFy9wNQIWJh5kH+x/p65PnvKrL5zKepnH27y5txAnPmBW4DWdEhi/bhq+x0dyv2U/KROjYEWL7Z9SK/vs0WJgeVQwLaPm4rZLxPPJ+7V9xkstqo3xyh0CpWp7mqLTCi70XRaosv1nRbiIZp4WPZ68rZ8TOaQQVekuOK/4r7uZP/tHCD7TaSZg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=uTEBRcsMW//GFyUzf19PhZO+G+xGbKzglhWcA6XKiDo=;
 b=kMuFbV2NMRttS17qE4KcmBixKESw5QKwTTL3oa8L0vGY+VgjWpQm9lJC+CsZ2hiohOtkFMcJ4s7vOWv7OhQNNFBHoG1SSKY7uIZBRojoi5JyALh6k4zWQO1bGX69JtFxwrQGRV6xJJ+ozSIG/NX9FcOFNcg7wOXJBGzRxBABddQ=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Julien Grall <julien@xen.org>
CC: Jan Beulich <jbeulich@suse.com>, Rahul Singh <Rahul.Singh@arm.com>, Andre
 Przywara <Andre.Przywara@arm.com>, Stefano Stabellini
	<sstabellini@kernel.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>, George Dunlap
	<george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>, Wei Liu
	<wl@xen.org>, Paul Durrant <paul@xen.org>, =?iso-8859-1?Q?Roger_Pau_Monn=E9?=
	<roger.pau@citrix.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v5 08/11] xen/arm: Enable the existing x86 virtual PCI
 support for ARM.
Thread-Topic: [PATCH v5 08/11] xen/arm: Enable the existing x86 virtual PCI
 support for ARM.
Thread-Index:
 AQHXutl3YqS5dHXsYk6KpdKt4d14RavHjPqAgAY38oCAAbo3AIAAEwAAgAACbACAABkfgA==
Date: Tue, 12 Oct 2021 17:50:50 +0000
Message-ID: <DA041522-CF7C-4C87-8031-55AF0B2D2517@arm.com>
References: <cover.1633540842.git.rahul.singh@arm.com>
 <9bdca2cda5d2e83f94dc2423e55714273539760a.1633540842.git.rahul.singh@arm.com>
 <6752f2d3-171b-37f5-c809-82995a8f3f36@suse.com>
 <CEF7FFB0-779A-4F46-8667-6BCD9BA5CB6C@arm.com>
 <2b0670e9-b442-047c-9479-daa97d6329f6@xen.org>
 <16C05F67-E3C8-44BE-9382-BF0EAA69AF5C@arm.com>
 <3b8ffd7d-cfc8-34c5-b0ad-aa23942dbe10@xen.org>
In-Reply-To: <3b8ffd7d-cfc8-34c5-b0ad-aa23942dbe10@xen.org>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3654.120.0.1.13)
Authentication-Results-Original: xen.org; dkim=none (message not signed)
 header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: a6ec1d87-a755-4b44-3aa0-08d98da8d952
x-ms-traffictypediagnostic: DB8PR08MB5050:|DB6PR08MB2840:
x-ms-exchange-transport-forked: True
X-Microsoft-Antispam-PRVS:
	<DB6PR08MB2840810889F3E9A6A5DFE20D9DB69@DB6PR08MB2840.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:10000;OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 w5hf8mIQoFqoi+VbRKJt0FmAQwowD3fMPmnF0WnO16wiRkZzHg5jBBuj3Cwh2ocKbcwKlyc0Pn5Q0R6nSOcBJawNWvrvFcefVWVXuMNeks0dhX5gTMY1VUQhjLJz2i1A6ALVQ4xBtFG8Im5klbb06nu3/9UKxz3nVQXA9XyijYJpG24NWN6SW0Uy/oA+aEMx7jFzKNShptgaMdy2fb24C9r6v5JPXINwu7FzYbFIagKLfLt2Q+BX23gYpfw3J4KHExjUNGY74uGmJzFuo8EusLzpbJH41Rz1+SOIRsti1DsIO5YyDH7QBY9FYP2f9ffWWqAxVsixUN74bhQW+cLt7kcwfm8Qu6ZyJnK9e3/8HnFn76HEzwISMCcK2tQTRace0Xx8QijYTwsmUrsajs7bDRTdr25U153+3FgkGQffVH8+XbUN9fpvTenBZecq7froybsfsdlqyqwblg8aVgHS3HXnWhycZ5bb7UoTN8RHsEKO8xiVKL6Mt+f5Gc3rSVa767KkRHWoXLSamvbpAXz4cIoNG8c6qsWePp/GcOiulGgx7Iyp93xK0tg+uJCw24MWrLvTv3nbNgbzIRvqR+xi1yItFT71GwgHXvJKNdF8rtIBlGgI9XZRieZktN+O3pNC8CvLQSGHQkVdGcqBcHkbUyL3PGEGVCAjSn6JkpnfeoJDPNNVGTkfv7m7SrILjRlYa6+LY/98/vfS7/+3e2fJklR2OkiWwHUY/eBTkPDXmL3eX8Cs58ZIlwc31Z84gtsg
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB6PR0801MB2024.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(6486002)(8676002)(33656002)(6506007)(53546011)(7416002)(8936002)(38100700002)(54906003)(316002)(122000001)(4326008)(5660300002)(86362001)(508600001)(71200400001)(186003)(6916009)(2906002)(2616005)(64756008)(36756003)(91956017)(83380400001)(76116006)(66556008)(66446008)(38070700005)(66946007)(26005)(66476007)(6512007)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="iso-8859-1"
Content-ID: <DB39016D9825964CB4D271853C7EA9E3@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB5050
Original-Authentication-Results: xen.org; dkim=none (message not signed)
 header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM5EUR03FT008.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	ec65eade-fc62-4760-aa10-08d98da8d431
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	W65y517FlMgDwKEof9l3u3Y0F8Z2ztFZ1Y9UbAr+EKcRjgwoY3q1jrF2zj7bwIfsddFiaFm6a57wQqhTyAnnvMOzPRHf5DiCo2Rtxnq7xhnhjImyiSQzwExEanoaSZaLdUWrlYx/xB0gMUBw5gfkQ7WetmjrpjnBE14uzwW3/BvJ7vnEQHzgpwgw+kcv6kBK6wsXq8xI8AB7tayKRVThZD8SEJYk51wCXui0xHXFjZG+JXNqTLf+/Nn0Z2CizcOnJdnspukiM96BfehzCA8gm1jpmMq/XgXeYbb2J4K2Sg/Q9b0iqDQjR19vdum16OjMOy3Xkn2hUOaszY6/DV1QrXIgJ9iXB3hp7z9d2s9tCaTmoLeTzqSfmXMokqVpYh5XFg8Vt3jWl84w7BEqOBDQoYWp3hoLHEb0/OyqTs109BsdSv+lsRnwT2BmQBsuV3Fqa+1V5tqaI2xvgru+SvARq+M8Rl5HHt9cLPZlOmkNzqd/XmK7Hn4Wc2PYt9xBkwiVdtOtZz6lduiYNuEGV7StJj0fYTWB3V1G4Dq+g26BMXNv8xrJmbE3wAC0poyVstpVskq3XFP+wmspF4my4cr3u5IRAdEDEkCHy3kt+gH8lUJXkHIo6tZEvKRJlAPSoTvapkezaX2iMNRRKjyePwYxZeMQjjI9OH7fTS/ibMHfbpCkn/DZjOy/Kw5LnL2jZ0GqQUYsttZGkCXWazqgUUJeAw==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(186003)(2906002)(8936002)(356005)(81166007)(82310400003)(86362001)(70586007)(36756003)(336012)(53546011)(6506007)(70206006)(47076005)(5660300002)(6512007)(508600001)(33656002)(8676002)(6862004)(6486002)(2616005)(316002)(54906003)(36860700001)(26005)(83380400001)(4326008);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2021 17:50:58.9053
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: a6ec1d87-a755-4b44-3aa0-08d98da8d952
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM5EUR03FT008.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR08MB2840

Hi Julien,

> On 12 Oct 2021, at 17:20, Julien Grall <julien@xen.org> wrote:
>=20
>=20
>=20
> On 12/10/2021 17:12, Bertrand Marquis wrote:
>> Hi Julien,
>>> On 12 Oct 2021, at 16:04, Julien Grall <julien@xen.org> wrote:
>>>=20
>>> On 11/10/2021 13:41, Bertrand Marquis wrote:
>>>> Hi Jan,
>>>=20
>>> Hi Bertrand,
>>>=20
>>>> As Rahul is on leave, I will answer you and make the changes needed.
>>>>> On 7 Oct 2021, at 14:43, Jan Beulich <jbeulich@suse.com> wrote:
>>>>> Independent of this - is bare metal Arm enforcing this same
>>>>> alignment restriction (unconditionally)? Iirc on x86 we felt we'd
>>>>> better synthesize misaligned accesses.
>>>> Unaligned IO access could be synthesise also on arm to but I would
>>>> rather not make such a change now without testing it (and there is
>>>> also a question of it making sense).
>>>=20
>>> Yes it makes sense. I actually have an item in my TODO list to forbid u=
naligned access because they should not happen on any device we currently e=
mulate.
>>>=20
>>> Although, I am not aware of any issue other than the guest would shoot =
itself in the foot if this happens.
>>>=20
>>>> So if it is ok with you I will keep that check and discuss it with Rah=
ul
>>>> when he is back. I will add a comment in the code to make that clear.
>>>=20
>>> I am OK with it.
>>>=20
>>> [...]
>>>=20
>>>>> Throughout this series I haven't been able to spot where the HAS_VPCI
>>>>> Kconfig symbol would get selected. Hence I cannot tell whether all of
>>>>> this is Arm64-specific. Otherwise I wonder whether size 8 actually
>>>>> can occur on Arm32.
>>>> Dabt.size could be 3 even on ARM32 but we should not allow 64bit
>>>> access on mmio regions on arm32.
>>>=20
>>> Hmmm... Looking at the Armv7 and Armv8 spec, ldrd/strd (64-bit read) wo=
uld not present a valid ISV. So I think it is not be possible to have dabt.=
size =3D 3 for 32-bit domain. But I agree we probably want to harden the co=
de.
>>>=20
>>>> So I will surround this code with ifdef CONFIG_ARM_64 and add a test
>>>> for len > 4 to prevent this case on 32bit.
>>>> To be completely right we should disable this also for 32bit guests bu=
t
>>>> this change would be a bit more invasive.
>>>=20
>>> I think the following should be sufficient:
>>>=20
>>> if ( is_domain_32bit_domain() && len > 4 )
>>>  return ...;
>> With the last request from Roger to use the function implemented in arch=
/x86/hw/io.c, the function will move to vpci.h so using is_32bit_domain wil=
l not be possible without ifdefery CONFIG_ARM.
>> Also I have no access to the domain there.
>> So the best I can do for now would be something like:
>> #ifdef CONFIG_ARM_32
>> If (len =3D=3D 8)
>>     return false
>> #endif
>> A 32bit guest on 64bit xen would not be checked.
>> Would that be ok for now ?
>=20
> I think the #ifdef is a bit pointless. My preference would be to not add =
the #ifdef but instead add...
>=20
>> I could add a comment in the code to warn about the limitation.
>=20
> .. a comment for now as this is only an hardening problem.

Agree I will do that.

Cheers
Bertrand

>=20
> Cheers,
>=20
> --=20
> Julien Grall



From xen-devel-bounces@lists.xenproject.org Tue Oct 12 17:57:54 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 17:57:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.207595.363471 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maM29-0008Cn-8Y; Tue, 12 Oct 2021 17:57:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 207595.363471; Tue, 12 Oct 2021 17:57:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maM29-0008Cg-3k; Tue, 12 Oct 2021 17:57:49 +0000
Received: by outflank-mailman (input) for mailman id 207595;
 Tue, 12 Oct 2021 17:57:47 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=P4MT=PA=gmail.com=olekstysh@srs-us1.protection.inumbo.net>)
 id 1maM27-0008CF-Kb
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 17:57:47 +0000
Received: from mail-lf1-x12d.google.com (unknown [2a00:1450:4864:20::12d])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 1b1c4a2d-3409-4e12-a2f6-6eee232f4971;
 Tue, 12 Oct 2021 17:57:46 +0000 (UTC)
Received: by mail-lf1-x12d.google.com with SMTP id i24so314264lfj.13
 for <xen-devel@lists.xenproject.org>; Tue, 12 Oct 2021 10:57:46 -0700 (PDT)
Received: from [192.168.1.7] ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id w8sm813408lft.293.2021.10.12.10.57.44
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Tue, 12 Oct 2021 10:57:45 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1b1c4a2d-3409-4e12-a2f6-6eee232f4971
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-transfer-encoding:content-language;
        bh=eRywIytHJi/TgEwZvUVmCXQLQQ1Au7IWYpYam+eX6QA=;
        b=iKS99wr2tRobObhcnFmU7QcjJgs31sN0SquFHMMt9Z36G2407aIx8RsaIP7p/j0CH8
         JFzNKl00cuE8gM2ejnv1r5SjBd3fbLtHAsDY9xoAyGeMQeuVsESm6uVkhcelKa+G11gm
         KW6iSOErO6jgl3/yTy3wUP/ep5fc7ADqkznXx99ylOEN16p8x/fPkhxZuvzwYLZ9DkYj
         BCBn5fxGY2S5oWFXdjQcKJe7gkei92h50cf6I5gIVUAqn2Xp9N01a18zftItBfdemRwd
         igUZj874YdaB31YHxs0fP3wHDUjazSX3NvFuFg2YHEoLkerKhBO6n3l7Sp06rFUPyGSN
         fjlg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding
         :content-language;
        bh=eRywIytHJi/TgEwZvUVmCXQLQQ1Au7IWYpYam+eX6QA=;
        b=2C0eATavsbbnGGUmItur7eMOUDxBua0iZ4fiCRTcUeJ4JdiJIxzUEBi2vC30X3QYZd
         hOzxovXRUP4UaOtXQvnhSdML0YI+JmANc7VopWuIl0vUYfK2cTojirEWk0M6LGlOuy7M
         jMi15KM0c3xpwXRok3EWCFepswiXLgVn2a4zlaZknvl9q5Vn01PG5tALjs5an7B1JRwp
         A3V7hMMgsEDw5fQqnlp8UTvQxoewAJORIFSxO0nCG7C8uMCAUlgfqcDw71+QBvrUMoGt
         2sqoepOdBtWul1axpvKll0vy3Gf64JiYoRprpxReZ3ZHSf2r+36HGbVo3CTvTzaVshkO
         HSOg==
X-Gm-Message-State: AOAM530HAztEG4k04rIx2lL7nlGhbAe1kdGa0elGD4Zu2wnM6+tLu5+X
	ZKdQbZaM+lM2qsjwKBS70xU=
X-Google-Smtp-Source: ABdhPJy3VAPl86wuApQEinuOvSfSVaQUSgRrK0gU6y9KK5E/j90AH6FXT1S6yT8MDAmRnrceJXCOBQ==
X-Received: by 2002:a2e:9097:: with SMTP id l23mr32494656ljg.416.1634061465491;
        Tue, 12 Oct 2021 10:57:45 -0700 (PDT)
Subject: Re: [PATCH V6 1/2] xen/arm: Introduce gpaddr_bits field to struct
 xen_domctl_getdomaininfo
To: Ian Jackson <iwj@xenproject.org>
Cc: xen-devel@lists.xenproject.org,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, Wei Liu <wl@xen.org>,
 Anthony PERARD <anthony.perard@citrix.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Juergen Gross <jgross@suse.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <1633974539-7380-1-git-send-email-olekstysh@gmail.com>
 <1633974539-7380-2-git-send-email-olekstysh@gmail.com>
 <24933.42667.311553.565032@mariner.uk.xensource.com>
 <60541d52-4b44-e212-cc06-bb41e9ce67f9@gmail.com>
 <24933.46428.243423.112077@mariner.uk.xensource.com>
From: Oleksandr <olekstysh@gmail.com>
Message-ID: <0392bca6-4eb1-bc07-ecc9-fa1def156bfa@gmail.com>
Date: Tue, 12 Oct 2021 20:57:44 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <24933.46428.243423.112077@mariner.uk.xensource.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US


On 12.10.21 19:18, Ian Jackson wrote:

Hi Ian

> Oleksandr writes ("Re: [PATCH V6 1/2] xen/arm: Introduce gpaddr_bits field to struct xen_domctl_getdomaininfo"):
>>> Oleksandr Tyshchenko writes ("[PATCH V6 1/2] xen/arm: Introduce gpaddr_bits field to struct xen_domctl_getdomaininfo"):
>>> You say "to the toolstack", but you are exposing this information up
>>> to callers of libxl.  Do you mean some higher-layer toolstack that
>>> uses libxl ?  What does it use this information for ?
>>>
>>> FTAOD I am not opposed to exposing this in this way; indeed it seems
>>> likely to be useful.  I just want to fully understand before I give
>>> this my tools ack.
>> I didn't mean any higher-layer toolstack, sorry if I was unclear. In the
>> first place this information is
>> needed by the entity which generates the device-tree for the guest on
>> Arm (tools/libs/light/libxl_arm.c) to properly calculate the extended
>> regions to be inserted into the hypervisor node.
> Right, OK.  So I think this is being exposed at the libxl
> gratuitously, because someone might want it in the future.
> I approve :-).
>
> Reviewed-by: Ian Jackson <iwj@xenproject.org>

Thanks!


Please note, it is going to be a new version of this patch based on 
today's discussion with Jan.


>
> Thanks,
> Ian.

-- 
Regards,

Oleksandr Tyshchenko



From xen-devel-bounces@lists.xenproject.org Tue Oct 12 18:07:03 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 18:07:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.207605.363481 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maMB0-0001J1-2J; Tue, 12 Oct 2021 18:06:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 207605.363481; Tue, 12 Oct 2021 18:06:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maMAz-0001Iu-Vi; Tue, 12 Oct 2021 18:06:57 +0000
Received: by outflank-mailman (input) for mailman id 207605;
 Tue, 12 Oct 2021 18:06:56 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1maMAy-0001Ik-6o; Tue, 12 Oct 2021 18:06:56 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1maMAy-0007J5-0N; Tue, 12 Oct 2021 18:06:56 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1maMAx-0002Pz-OC; Tue, 12 Oct 2021 18:06:55 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1maMAx-00086r-Nd; Tue, 12 Oct 2021 18:06:55 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=2S1WWrAsyPP+hLebhUVX/oqJZIfqiNGJIct5zoNddG8=; b=RyK3B9MONZVA/Ad8Z2J7KUgYoP
	1WTWnVnPA0cM39PtYo+a/aacxq8xZuqbRuYVGLCatnaV2GSLwxNEmU1/7SYAP+Zrk86TbyXkTKHxd
	+QjljWl7mOe8N0pNn2eCqUqs9LYtIHoC/IPvxmCjCuvKsZfuuya8rQnJH+YgkYkyj/es=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165479-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 165479: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=2faeb4213d9b412836fe80e5685bfcccc51feb92
X-Osstest-Versions-That:
    xen=d3b05f9b16d6ba9c550c3a35ac11ed292bf87f68
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 12 Oct 2021 18:06:55 +0000

flight 165479 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165479/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  2faeb4213d9b412836fe80e5685bfcccc51feb92
baseline version:
 xen                  d3b05f9b16d6ba9c550c3a35ac11ed292bf87f68

Last test of basis   165475  2021-10-12 10:01:35 Z    0 days
Testing same since   165479  2021-10-12 14:00:26 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Dmitry Isaykin <isaikin-dmitry@yandex.ru>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   d3b05f9b16..2faeb4213d  2faeb4213d9b412836fe80e5685bfcccc51feb92 -> smoke


From xen-devel-bounces@lists.xenproject.org Tue Oct 12 18:07:11 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 18:07:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.207607.363496 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maMBD-0001g3-Au; Tue, 12 Oct 2021 18:07:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 207607.363496; Tue, 12 Oct 2021 18:07:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maMBD-0001fw-7m; Tue, 12 Oct 2021 18:07:11 +0000
Received: by outflank-mailman (input) for mailman id 207607;
 Tue, 12 Oct 2021 18:07:10 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1maMBC-0001el-Or
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 18:07:10 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1maMBC-0007JW-O7
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 18:07:10 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1maMBC-0001Sr-N0
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 18:07:10 +0000
Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89)
 (envelope-from <iwj@xenproject.org>)
 id 1maMB9-0005D8-FC; Tue, 12 Oct 2021 19:07:07 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date
	:Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From;
	bh=YX0yegc7EwoRGUjuEUlT1uQ7OUqbgelAEDuSKbxYD2U=; b=Rz2U5fqCwJ+RpYmE51GBtI7Vdl
	W3VfnQjxk6fQLmogtF9qfiAOpuPjYlVCrSZ89+gngUBNfHYz4T5/Fo7ykFwcwgtAsGA4bqw5jNQ0A
	AHW4oCstFYywsGbk+0A9H9WdT2+NdeH0NGru+zwEmUXoaABUQR+VXMLoT1AgUTtRNhOk=;
From: Ian Jackson <iwj@xenproject.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <24933.52939.127687.784369@mariner.uk.xensource.com>
Date: Tue, 12 Oct 2021 19:07:07 +0100
To: Oleksandr <olekstysh@gmail.com>
Cc: xen-devel@lists.xenproject.org,
    Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
    Wei Liu <wl@xen.org>,
    Anthony PERARD <anthony.perard@citrix.com>,
    Andrew Cooper <andrew.cooper3@citrix.com>,
    George Dunlap <george.dunlap@citrix.com>,
    Jan Beulich <jbeulich@suse.com>,
    Julien Grall <julien@xen.org>,
    Stefano Stabellini <sstabellini@kernel.org>,
    Juergen Gross <jgross@suse.com>,
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
    Roger Pau =?iso-8859-1?Q?Monn=E9?= <roger.pau@citrix.com>
Subject: Re: [PATCH V6 1/2] xen/arm: Introduce gpaddr_bits field to struct
 xen_domctl_getdomaininfo
In-Reply-To: <0392bca6-4eb1-bc07-ecc9-fa1def156bfa@gmail.com>
References: <1633974539-7380-1-git-send-email-olekstysh@gmail.com>
	<1633974539-7380-2-git-send-email-olekstysh@gmail.com>
	<24933.42667.311553.565032@mariner.uk.xensource.com>
	<60541d52-4b44-e212-cc06-bb41e9ce67f9@gmail.com>
	<24933.46428.243423.112077@mariner.uk.xensource.com>
	<0392bca6-4eb1-bc07-ecc9-fa1def156bfa@gmail.com>
X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu)

Oleksandr writes ("Re: [PATCH V6 1/2] xen/arm: Introduce gpaddr_bits field to struct xen_domctl_getdomaininfo"):
> Please note, it is going to be a new version of this patch based on 
> today's discussion with Jan.

OK.  Please retain my R-b if you don't change any of the tools parts.

Ian.


From xen-devel-bounces@lists.xenproject.org Tue Oct 12 18:23:08 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 18:23:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.207622.363507 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maMQN-00049U-L1; Tue, 12 Oct 2021 18:22:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 207622.363507; Tue, 12 Oct 2021 18:22:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maMQN-00049N-GP; Tue, 12 Oct 2021 18:22:51 +0000
Received: by outflank-mailman (input) for mailman id 207622;
 Tue, 12 Oct 2021 18:22:50 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=P4MT=PA=gmail.com=olekstysh@srs-us1.protection.inumbo.net>)
 id 1maMQM-00049H-Ro
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 18:22:50 +0000
Received: from mail-lf1-x12d.google.com (unknown [2a00:1450:4864:20::12d])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 0a670779-b422-481e-846e-22db4d041820;
 Tue, 12 Oct 2021 18:22:50 +0000 (UTC)
Received: by mail-lf1-x12d.google.com with SMTP id j5so693051lfg.8
 for <xen-devel@lists.xenproject.org>; Tue, 12 Oct 2021 11:22:49 -0700 (PDT)
Received: from [192.168.1.7] ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id a6sm1182377ljd.67.2021.10.12.11.22.48
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Tue, 12 Oct 2021 11:22:48 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0a670779-b422-481e-846e-22db4d041820
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-transfer-encoding:content-language;
        bh=1sRuanqPDnAouqY4cGCjF1ATT7nCyQH8JV9jvCp8Cqo=;
        b=jO2XfnYWO7GB159UFynHxNSjWlacymT5Nq/9MWp/KBmj7bRBUgYbVqKR27EKqA4hps
         P3pL5P96VdFXU9mYOrzj03SOCpsnkevpbkysyCrY0xPnf6lA2DTehUNcPH0D3qyX4aWd
         b1DdjcMb2QgkDrOagmyI2STzMHE3U37yx/eLt0GzRV9I2bp8KgqqNBiM4W+wiJPUYLWj
         2fJ9tRB2tQFcRr0yWf39D2HOGWC8br5hKUsVcBuqqAIdOQHymNSeiJnsbKDdzuKHS/DY
         Rwkfqeb5e62R0tRYNa2GFBN2vkxFDycgigif2h4HEfJrJvg+mtf/+D1mul25H0ldmvw2
         2gkw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding
         :content-language;
        bh=1sRuanqPDnAouqY4cGCjF1ATT7nCyQH8JV9jvCp8Cqo=;
        b=o1YpV7swHKobB1y0lvkXmRT8x23VD3FPfC8U12YU41+1ckvXBGWAzfwXa1+qbDAA0W
         ARFrSOXcxb5fotwdOb/88uaHKR9PQUjZK9OzOKCCGa//R5uudLrs3hueUyS4tDbQ4zj9
         KPjfb/ZWsN6Ld9aW/SFQV4WUnA2L6CFj93lteDB02irPV5SgUczKwUOHrUOYJcPnT6Bx
         OoAEIzMMiTqRaAgF2mw9DhL7UlKMtROe14JD5Zy7OwLlMumr4v+ejXhabfuxlaBxOMba
         1hMVmL+KDBOv/2VQPOxXm8arZOVfWmXguZHZ23IqzghoOGxj8uQdu21UKJvj/xKAsu+Y
         tKPA==
X-Gm-Message-State: AOAM530EekjorEXsd4VIVs/A+rTGhKwKtu0Im3bwV/Ry7W5Nkq6L2jgv
	ouepcSO+M6tgKssz/X/S0WE=
X-Google-Smtp-Source: ABdhPJyeaOhoVJJVy6NUV/D4SIv1JjeGDjVYj3cuk6FZJ5Q2VLeB+/twvR/qGl/ExJZ+hts7QHtlBA==
X-Received: by 2002:a2e:a443:: with SMTP id v3mr22873367ljn.101.1634062968943;
        Tue, 12 Oct 2021 11:22:48 -0700 (PDT)
Subject: Re: [PATCH V6 1/2] xen/arm: Introduce gpaddr_bits field to struct
 xen_domctl_getdomaininfo
To: Ian Jackson <iwj@xenproject.org>
Cc: xen-devel@lists.xenproject.org,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, Wei Liu <wl@xen.org>,
 Anthony PERARD <anthony.perard@citrix.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Juergen Gross <jgross@suse.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <1633974539-7380-1-git-send-email-olekstysh@gmail.com>
 <1633974539-7380-2-git-send-email-olekstysh@gmail.com>
 <24933.42667.311553.565032@mariner.uk.xensource.com>
 <60541d52-4b44-e212-cc06-bb41e9ce67f9@gmail.com>
 <24933.46428.243423.112077@mariner.uk.xensource.com>
 <0392bca6-4eb1-bc07-ecc9-fa1def156bfa@gmail.com>
 <24933.52939.127687.784369@mariner.uk.xensource.com>
From: Oleksandr <olekstysh@gmail.com>
Message-ID: <9e6e1378-7ee3-b692-b57d-29b597160661@gmail.com>
Date: Tue, 12 Oct 2021 21:22:47 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <24933.52939.127687.784369@mariner.uk.xensource.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US


On 12.10.21 21:07, Ian Jackson wrote:

Hi Ian

> Oleksandr writes ("Re: [PATCH V6 1/2] xen/arm: Introduce gpaddr_bits field to struct xen_domctl_getdomaininfo"):
>> Please note, it is going to be a new version of this patch based on
>> today's discussion with Jan.
> OK.  Please retain my R-b if you don't change any of the tools parts.

Sure, thanks for confirming. There won't be no new changes for the tools.


>
> Ian.

-- 
Regards,

Oleksandr Tyshchenko



From xen-devel-bounces@lists.xenproject.org Tue Oct 12 20:42:50 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 20:42:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.207641.363520 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maObZ-0008QM-V4; Tue, 12 Oct 2021 20:42:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 207641.363520; Tue, 12 Oct 2021 20:42:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maObZ-0008QF-SE; Tue, 12 Oct 2021 20:42:33 +0000
Received: by outflank-mailman (input) for mailman id 207641;
 Tue, 12 Oct 2021 20:42:33 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=SIAI=PA=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1maObY-0008Q9-VI
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 20:42:33 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id eb9d4350-2b9c-11ec-8151-12813bfff9fa;
 Tue, 12 Oct 2021 20:42:31 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id ED49B60E0C;
 Tue, 12 Oct 2021 20:42:29 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: eb9d4350-2b9c-11ec-8151-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1634071350;
	bh=bfRCIu6SeVZsFtzUcyP2gwhu7cAa5z6kDeSJeg7yVHw=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=Bm1qheDirlh5KoNcdvI8srwjFRuQKnO/7WhdifTvgrhM22rdbRKthmrHH5r0tFVBr
	 fuzXrNCcIEImQtbJOXDUpjjifwzQP3ILqHdeJ/iKfqdLku3SW71VeCLYHyr4rR/NML
	 8RRQNhBJUbetY3sTl92sbWfDBz43ZSITBKsM26McDrtCSVc2E1N5iHQcTRcRgCc9to
	 EV+VFvpBx7l9y/0Hzw3mcJGk3uEBwTA7LUqJolWjoozJbf9nMq+ZUpPd9TXM+Pf52K
	 0bd4nhGMs+Mh15SRciuwWtQ6xOx5CWzUVdzmHZP/7obDzMZChVeqvZzXf1B4jvXppR
	 FqzDXSRlUFODw==
Date: Tue, 12 Oct 2021 13:42:22 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Ian Jackson <iwj@xenproject.org>
cc: Bertrand Marquis <Bertrand.Marquis@arm.com>, 
    Jan Beulich <jbeulich@suse.com>, 
    Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>, 
    Rahul Singh <Rahul.Singh@arm.com>, 
    "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, 
    Andre  Przywara <Andre.Przywara@arm.com>, Wei Liu <wl@xen.org>, 
    Juergen Gross <jgross@suse.com>, 
    Stefano Stabellini <sstabellini@kernel.org>, 
    =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= <roger.pau@citrix.com>
Subject: Re: [PATCH v5 01/11] xen/arm: xc_domain_ioport_permission(..) not
 supported on ARM.
In-Reply-To: <24933.47094.43672.782143@mariner.uk.xensource.com>
Message-ID: <alpine.DEB.2.21.2110121319150.9408@sstabellini-ThinkPad-T480s>
References: <cover.1633540842.git.rahul.singh@arm.com> <d292392268df2c74c4103a82ef917072643407a8.1633540842.git.rahul.singh@arm.com> <YWQkblfNMYEs6jI9@MacBook-Air-de-Roger.local> <77CF7FA5-C566-469E-B4A8-0400789890BB@arm.com> <YWQ6Nk3Jk+BqgkwZ@MacBook-Air-de-Roger.local>
 <53AE6E2A-01D7-41EC-9B2C-C0D596EB8D4D@arm.com> <YWRCxXGQIyTOAepC@MacBook-Air-de-Roger.local> <FEF0B03A-5AC8-4F8D-B821-191AC2EF8295@arm.com> <ac6d4785-ac9a-4491-26bb-c66ffe82c55b@suse.com> <ED8FC92F-B5EF-4473-B4A9-641C7D44859F@arm.com>
 <0744b957-1832-dff2-9ae2-b8e8534f501b@suse.com> <c3952fd5-b893-4cb6-a9bc-325a89e859db@epam.com> <c125b447-53e8-7d13-3b08-af62fd3a9140@suse.com> <c6b6c22f-fb8a-f2d9-7735-f1ebc9809908@epam.com> <09656882-b297-7144-c291-1ee997edb119@suse.com>
 <69A83587-B7E0-4653-AF8C-AEE802922CE5@arm.com> <24933.41349.893363.203683@mariner.uk.xensource.com> <AB6D62B6-2ED2-4957-A933-08EC77A4DFD6@arm.com> <24933.47094.43672.782143@mariner.uk.xensource.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Tue, 12 Oct 2021, Ian Jackson wrote:
> Bertrand Marquis writes ("Re: [PATCH v5 01/11] xen/arm: xc_domain_ioport_permission(..) not supported on ARM."):
> > I can add something in the commit message about the fact that we improve
> > performance and prevent to do a call that is and will not be supported in Xen.
> 
> Thanks but I'm afraid I don't think that is a correct summary of the
> thread.  Nor would it be an adequate justification for the change.  At
> least, not unless you plan to write something considerably longer (and
> more precise).
> 
> Firstly, I'm not convinced this change would be justified by the
> performance impact.  This is a small number of hypercalls during
> domain startup.  Usually none, I think ?  If someone wants to optimise
> domain startup speed then I am very open to that but I think this
> change will make negligible change in practice.  Unless someone wants
> to tell me I'm wrong about that ?  And if I am wrong about that then
> an explanation of why my suppositions are wrong ought to go in the
> commit message.
> 
> Secondly, there is no justification there for the change in error
> status.
> 
> Why is this change needed ?  (What goes wrong if it is omitted ?)
> That is what the commit message ought to answer.
> 
> Plus, given that it stubs out a function to make it into a no-op, that
> itself requires an explanation.  Why is it OK for this function which
> is supposed to do a thing, to in fact not do anything at all and
> return successfully saying "yes I did that" ?
> 
> I think (having read the thread) that I know the answers to these
> questions but it needs to be clearly and explicitly written down.
> 
> > I saw your change in CODING_STYLE and I understand the request.
> > I will try to see if we can handle this change before the feature freeze.
> 
> Thanks.  I doubt that this will be hard.  I am more worried about the
> commit message.
> 
> Indeed, since we haven't had the rationale for this change explicitly
> written down, there is a risk that when we do so, we will discover
> some problem with the approach that we had previously overlooked.
> 
> Discovering that kind of thing is one reason to explicitly write down
> why we are doing what we are doing, but this situation does mean we
> shouldn't feel we've yet achieved confidence that this patch is right.


I don't think it is about performance. From a performance point of view,
we could make as many (unneeded) hypercalls as required. It is mostly
about minimizing unwanted changes to common libxl code. Let me explain.


IO ports on ARM don't exist so all IO ports related hypercalls are going
to fail. This is expected. Today, a failure of
xc_domain_ioport_permission would turn into a critical failure at domain
creation. We need to avoid this outcome; instead we want to continue
with domain creation as normal even if xc_domain_ioport_permission
fails. (FYI the underlying hypercall XEN_DOMCTL_ioport_permission is not
implemented on ARM so it would return -ENOSYS.)


We have a few options to achieve this goal:


1) No xc_domain_ioport_permission calls on ARM

   Use #ifdefs or similar checks in libxl_pci.c to avoid calling
   xc_domain_ioport_permission on ARM. This could be best but it would
   cause some churn in arch-neutral libxl code.


2) Handle xc_domain_ioport_permission errors in libxl

   Introduce checks on the return value of xc_domain_ioport_permission
   and ignore specific errors on ARM in libxl_pci.c.
   For instance: if (ARM && rc == -ENOSYS) continue.

   This might cause less churn than 1) but still requires a few changes
   in arch-neutral libxl code.


3) Force XEN_DOMCTL_ioport_permission to return zero on ARM

   Force the hypercall to return success even if it did nothing.
   Currently it returns -ENOSYS.

   This is possible but it wasn't chosen for the implementation as we
   felt that the hypercall should reflect what was actually done
   (nothing) and it should be userspace to handle the error. I guess
   this could be argued either way.


4) Force xc_domain_ioport_permission to return zero on ARM

   Force xc_domain_ioport_permission to return success even if the
   hypercall would return -ENOSYS. This way there are no changes to
   libxl.
   
   This is what the patch currently implements by using  #ifdef in
   xc_domain_ioport_permission. It could also have achieved the same
   goal by making the implementation of xc_domain_ioport_permission
   arch-specific, and in the ARM implementation returning 0.


All options above achieve the goal of a successful domain creation with
PCI device assigned on ARM. You might be able to think of other options
as well. I think noone here is really set on using one option over the
other -- as long as xc_domain_ioport_permission failures don't turn into
domain creation failures on ARM we are good.

Let us know what you think.


From xen-devel-bounces@lists.xenproject.org Tue Oct 12 21:22:29 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 21:22:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.207649.363532 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maPE7-00041n-O8; Tue, 12 Oct 2021 21:22:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 207649.363532; Tue, 12 Oct 2021 21:22:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maPE7-00041g-KX; Tue, 12 Oct 2021 21:22:23 +0000
Received: by outflank-mailman (input) for mailman id 207649;
 Tue, 12 Oct 2021 21:22:22 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=P4MT=PA=gmail.com=olekstysh@srs-us1.protection.inumbo.net>)
 id 1maPE6-00041a-FA
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 21:22:22 +0000
Received: from mail-lf1-x12a.google.com (unknown [2a00:1450:4864:20::12a])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id e02ae445-c6d6-4d34-9df3-36664bd133d4;
 Tue, 12 Oct 2021 21:22:20 +0000 (UTC)
Received: by mail-lf1-x12a.google.com with SMTP id x27so2435913lfa.9
 for <xen-devel@lists.xenproject.org>; Tue, 12 Oct 2021 14:22:20 -0700 (PDT)
Received: from otyshchenko.router ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id t19sm1225435lfl.30.2021.10.12.14.22.18
 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
 Tue, 12 Oct 2021 14:22:19 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e02ae445-c6d6-4d34-9df3-36664bd133d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references;
        bh=cYWMzG7Y4+yIuZtYg+IWHufWttwrsUzPWk+Z4Hhpz4I=;
        b=JBk76p/EuLGWECDn/lOJCwUFYt9gAi3lWvxRzhW/Pa/xPalPosXakHPPw2Pp0M8mkP
         F4KNxviHeMTuu5BpfRzZ7X9ezIHyUEUFRpMhwfyt52eXHlzQQiGFkBaKVPdw9EdkVa4E
         7Idjsz5eCqD649z5ZmVKJiRHynISTkRsw70ZphmIGLrtaRK3Ev/6jhrqpQfsQT4UwrjG
         GuT4d+3DmUtXFSEpeYFbSRvPKeCNkYtSy6tMs+iKPdcso/TEUx7vyd6rDqLDX8b4U52N
         UHy1IoE79VACShggtpwmukN9C/VssKRoPdyPiIXS43C3Xc+H413BcfCPoDCGEPBs11uO
         8Qsg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references;
        bh=cYWMzG7Y4+yIuZtYg+IWHufWttwrsUzPWk+Z4Hhpz4I=;
        b=ik4VL4or8lEIU6mf0CracQ0KHiA4XcDD/eYdlb3rgrHXITsauusGljOCkhUchqm9ar
         qmrF9lUcAK5djVPWX6NbdLy9iSFe7TB4BdTI7MG0bFSljrreIaJYARQD65Re6G8CuijI
         rRgLAfeFcUgbVO8PXfPZD8AMe+0fBGKoB1Za6i6o6BYvz6+oaGWP89ryTHRflOMk5yzv
         uYF8Qj6X21FtedhUg4wOzzxVMbJudKAwm2ykmxNQF6NdnQRX1oMXGUJ2Rd28Y5bgq3S4
         gTuxP//3b54i8ywSqFiaCdky5XtolUcvo2PfjMbINM3ksiMSwuvdJ10MNO6WfsZW0msr
         zbig==
X-Gm-Message-State: AOAM533yD4RmtnoVF7BRI7///Bs/jCP0vAXL9SFWvScmg5pqV2oHf7tn
	HljLNmn36X6yjljE1yfWz63z/HDco6Q=
X-Google-Smtp-Source: ABdhPJzbD0THil8C1CqmLH+7H60ROzatxU8kXixYOC3xlyuebbY/0D+xbT/+WG8z2aVrO2VVWvIwCg==
X-Received: by 2002:a05:6512:b29:: with SMTP id w41mr36353870lfu.508.1634073739570;
        Tue, 12 Oct 2021 14:22:19 -0700 (PDT)
From: Oleksandr Tyshchenko <olekstysh@gmail.com>
To: xen-devel@lists.xenproject.org
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Ian Jackson <iwj@xenproject.org>,
	Wei Liu <wl@xen.org>,
	Anthony PERARD <anthony.perard@citrix.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Juergen Gross <jgross@suse.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>
Subject: [PATCH V6 1/2] xen/arm: Introduce gpaddr_bits field to struct xen_domctl_getdomaininfo
Date: Wed, 13 Oct 2021 00:22:00 +0300
Message-Id: <1634073720-27901-1-git-send-email-olekstysh@gmail.com>
X-Mailer: git-send-email 2.7.4
In-Reply-To: <9e6e1378-7ee3-b692-b57d-29b597160661@gmail.com>
References: <9e6e1378-7ee3-b692-b57d-29b597160661@gmail.com>

From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>

We need to pass info about maximum supported guest physical
address space size to the toolstack on Arm in order to properly
calculate the base and size of the extended region (safe range)
for the guest. The extended region is unused address space which
could be safely used by domain for foreign/grant mappings on Arm.
The extended region itself will be handled by the subsequent
patch.

Currently the same guest physical address space size is used
for all guests (p2m_ipa_bits variable on Arm, the x86 equivalent
is hap_paddr_bits).

Add an explicit padding after "gpaddr_bits" field and also
(while at it) after "domain" field.

Also make sure that full structure is cleared in all cases by
moving the clearing into getdomaininfo(). Currently it is only
cleared by the sysctl caller (and only once).

Please note, we do not need to bump XEN_DOMCTL_INTERFACE_VERSION
as a bump has already occurred in this release cycle. But we do
need to bump XEN_SYSCTL_INTERFACE_VERSION as the structure is
re-used in a sysctl.

Suggested-by: Julien Grall <jgrall@amazon.com>
Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
Reviewed-by: Ian Jackson <iwj@xenproject.org>
---
Changes RFC -> V2:
   - update patch subject/description
   - replace arch-specific sub-struct with common gpaddr_bits
     field and update code to reflect that

Changes V2 -> V3:
   - make the field uint8_t and add uint8_t pad[7] after
   - remove leading blanks in libxl.h

Changes V3 -> V4:
   - also print gpaddr_bits from output_physinfo()
   - add Michal's R-b

Changes V4 -> V5:
   - update patch subject and description
   - drop Michal's R-b
   - pass gpaddr_bits via createdomain domctl
     (struct xen_arch_domainconfig)

Changes V5 -> V6:
   - update patch subject and description
   - pass gpaddr_bits via getdomaininfo domctl
     (struct xen_domctl_getdomaininfo)

Changes V6 -> V7:
   - update patch description
   - do not bump XEN_DOMCTL_INTERFACE_VERSION
   - bump XEN_SYSCTL_INTERFACE_VERSION
   - add explicit paddings
   - clear the full structure in getdomaininfo()
   - add Ian's R-b
---
 tools/include/libxl.h            | 8 ++++++++
 tools/include/xenctrl.h          | 1 +
 tools/libs/ctrl/xc_domain.c      | 1 +
 tools/libs/light/libxl_domain.c  | 1 +
 tools/libs/light/libxl_types.idl | 1 +
 xen/arch/arm/domctl.c            | 2 ++
 xen/arch/x86/domctl.c            | 1 +
 xen/common/domctl.c              | 6 +++---
 xen/common/sysctl.c              | 2 +-
 xen/include/public/domctl.h      | 3 +++
 xen/include/public/sysctl.h      | 2 +-
 11 files changed, 23 insertions(+), 5 deletions(-)

diff --git a/tools/include/libxl.h b/tools/include/libxl.h
index b9ba16d..deb5022 100644
--- a/tools/include/libxl.h
+++ b/tools/include/libxl.h
@@ -874,6 +874,14 @@ typedef struct libxl__ctx libxl_ctx;
 #define LIBXL_HAVE_DOMINFO_NEVER_STOP 1
 
 /*
+ * LIBXL_HAVE_DOMINFO_GPADDR_BITS
+ *
+ * If this is defined, libxl_dominfo will contain an uint8 field called
+ * gpaddr_bits, containing the guest physical address space size.
+ */
+#define LIBXL_HAVE_DOMINFO_GPADDR_BITS 1
+
+/*
  * LIBXL_HAVE_QXL
  *
  * If defined, then the libxl_vga_interface_type will contain another value:
diff --git a/tools/include/xenctrl.h b/tools/include/xenctrl.h
index a306399..07b96e6 100644
--- a/tools/include/xenctrl.h
+++ b/tools/include/xenctrl.h
@@ -462,6 +462,7 @@ typedef struct xc_dominfo {
     unsigned int  max_vcpu_id;
     xen_domain_handle_t handle;
     unsigned int  cpupool;
+    uint8_t       gpaddr_bits;
     struct xen_arch_domainconfig arch_config;
 } xc_dominfo_t;
 
diff --git a/tools/libs/ctrl/xc_domain.c b/tools/libs/ctrl/xc_domain.c
index 23322b7..b155d6a 100644
--- a/tools/libs/ctrl/xc_domain.c
+++ b/tools/libs/ctrl/xc_domain.c
@@ -396,6 +396,7 @@ int xc_domain_getinfo(xc_interface *xch,
         info->nr_online_vcpus = domctl.u.getdomaininfo.nr_online_vcpus;
         info->max_vcpu_id = domctl.u.getdomaininfo.max_vcpu_id;
         info->cpupool = domctl.u.getdomaininfo.cpupool;
+        info->gpaddr_bits = domctl.u.getdomaininfo.gpaddr_bits;
         info->arch_config = domctl.u.getdomaininfo.arch_config;
 
         memcpy(info->handle, domctl.u.getdomaininfo.handle,
diff --git a/tools/libs/light/libxl_domain.c b/tools/libs/light/libxl_domain.c
index 51a6127..544a9bf 100644
--- a/tools/libs/light/libxl_domain.c
+++ b/tools/libs/light/libxl_domain.c
@@ -306,6 +306,7 @@ void libxl__xcinfo2xlinfo(libxl_ctx *ctx,
     xlinfo->vcpu_max_id = xcinfo->max_vcpu_id;
     xlinfo->vcpu_online = xcinfo->nr_online_vcpus;
     xlinfo->cpupool = xcinfo->cpupool;
+    xlinfo->gpaddr_bits = xcinfo->gpaddr_bits;
     xlinfo->domain_type = (xcinfo->flags & XEN_DOMINF_hvm_guest) ?
         LIBXL_DOMAIN_TYPE_HVM : LIBXL_DOMAIN_TYPE_PV;
 }
diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_types.idl
index 3f9fff6..2df7258 100644
--- a/tools/libs/light/libxl_types.idl
+++ b/tools/libs/light/libxl_types.idl
@@ -357,6 +357,7 @@ libxl_dominfo = Struct("dominfo",[
     ("vcpu_max_id", uint32),
     ("vcpu_online", uint32),
     ("cpupool",     uint32),
+    ("gpaddr_bits", uint8),
     ("domain_type", libxl_domain_type),
     ], dir=DIR_OUT)
 
diff --git a/xen/arch/arm/domctl.c b/xen/arch/arm/domctl.c
index b7d27f3..6245af6 100644
--- a/xen/arch/arm/domctl.c
+++ b/xen/arch/arm/domctl.c
@@ -20,6 +20,8 @@ void arch_get_domain_info(const struct domain *d,
 {
     /* All ARM domains use hardware assisted paging. */
     info->flags |= XEN_DOMINF_hap;
+
+    info->gpaddr_bits = p2m_ipa_bits;
 }
 
 static int handle_vuart_init(struct domain *d, 
diff --git a/xen/arch/x86/domctl.c b/xen/arch/x86/domctl.c
index 26a76d2..7d102e0 100644
--- a/xen/arch/x86/domctl.c
+++ b/xen/arch/x86/domctl.c
@@ -151,6 +151,7 @@ void arch_get_domain_info(const struct domain *d,
         info->flags |= XEN_DOMINF_hap;
 
     info->arch_config.emulation_flags = d->arch.emulation_flags;
+    info->gpaddr_bits = hap_paddr_bits;
 }
 
 static int do_vmtrace_op(struct domain *d, struct xen_domctl_vmtrace_op *op,
diff --git a/xen/common/domctl.c b/xen/common/domctl.c
index 12d6144..2d07a12 100644
--- a/xen/common/domctl.c
+++ b/xen/common/domctl.c
@@ -69,10 +69,10 @@ void getdomaininfo(struct domain *d, struct xen_domctl_getdomaininfo *info)
     int flags = XEN_DOMINF_blocked;
     struct vcpu_runstate_info runstate;
 
+    memset(info, 0, sizeof(*info));
+
     info->domain = d->domain_id;
     info->max_vcpu_id = XEN_INVALID_MAX_VCPU_ID;
-    info->nr_online_vcpus = 0;
-    info->ssidref = 0;
 
     /*
      * - domain is marked as blocked only if all its vcpus are blocked
@@ -95,7 +95,7 @@ void getdomaininfo(struct domain *d, struct xen_domctl_getdomaininfo *info)
 
     info->cpu_time = cpu_time;
 
-    info->flags = (info->nr_online_vcpus ? flags : 0) |
+    info->flags |= (info->nr_online_vcpus ? flags : 0) |
         ((d->is_dying == DOMDYING_dead) ? XEN_DOMINF_dying     : 0) |
         (d->is_shut_down                ? XEN_DOMINF_shutdown  : 0) |
         (d->controller_pause_count > 0  ? XEN_DOMINF_paused    : 0) |
diff --git a/xen/common/sysctl.c b/xen/common/sysctl.c
index 3558641..a7ab95d 100644
--- a/xen/common/sysctl.c
+++ b/xen/common/sysctl.c
@@ -76,7 +76,7 @@ long do_sysctl(XEN_GUEST_HANDLE_PARAM(xen_sysctl_t) u_sysctl)
     case XEN_SYSCTL_getdomaininfolist:
     { 
         struct domain *d;
-        struct xen_domctl_getdomaininfo info = { 0 };
+        struct xen_domctl_getdomaininfo info;
         u32 num_domains = 0;
 
         rcu_read_lock(&domlist_read_lock);
diff --git a/xen/include/public/domctl.h b/xen/include/public/domctl.h
index 4cb3f66..46acc8f 100644
--- a/xen/include/public/domctl.h
+++ b/xen/include/public/domctl.h
@@ -106,6 +106,7 @@ struct xen_domctl_createdomain {
 struct xen_domctl_getdomaininfo {
     /* OUT variables. */
     domid_t  domain;              /* Also echoed in domctl.domain */
+    uint16_t pad1;
  /* Domain is scheduled to die. */
 #define _XEN_DOMINF_dying     0
 #define XEN_DOMINF_dying      (1U<<_XEN_DOMINF_dying)
@@ -150,6 +151,8 @@ struct xen_domctl_getdomaininfo {
     uint32_t ssidref;
     xen_domain_handle_t handle;
     uint32_t cpupool;
+    uint8_t gpaddr_bits; /* Guest physical address space size. */
+    uint8_t pad2[7];
     struct xen_arch_domainconfig arch_config;
 };
 typedef struct xen_domctl_getdomaininfo xen_domctl_getdomaininfo_t;
diff --git a/xen/include/public/sysctl.h b/xen/include/public/sysctl.h
index 039ccf8..41ef7a2 100644
--- a/xen/include/public/sysctl.h
+++ b/xen/include/public/sysctl.h
@@ -35,7 +35,7 @@
 #include "domctl.h"
 #include "physdev.h"
 
-#define XEN_SYSCTL_INTERFACE_VERSION 0x00000013
+#define XEN_SYSCTL_INTERFACE_VERSION 0x00000014
 
 /*
  * Read console content from Xen buffer ring.
-- 
2.7.4



From xen-devel-bounces@lists.xenproject.org Tue Oct 12 21:22:53 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 21:22:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.207653.363543 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maPEb-0004Ug-05; Tue, 12 Oct 2021 21:22:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 207653.363543; Tue, 12 Oct 2021 21:22:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maPEa-0004UZ-TI; Tue, 12 Oct 2021 21:22:52 +0000
Received: by outflank-mailman (input) for mailman id 207653;
 Tue, 12 Oct 2021 21:22:51 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1maPEZ-0004UO-Fa
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 21:22:51 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1maPEX-0002BI-V6; Tue, 12 Oct 2021 21:22:49 +0000
Received: from 54-240-197-233.amazon.com ([54.240.197.233] helo=[192.168.23.5])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1maPEX-0002qj-O3; Tue, 12 Oct 2021 21:22:49 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=IOrFYsYDjTDWoyIl+xPZ63JTc5kbD+N9RXe+e/D5+eA=; b=rHla7rSR0WSalRLGFlpIhp3VtS
	Y96Mb936mZ8IPLIzZTI589hcYlUGdfrCzM7HoRBJAnHgaItzTzdGRSQpuyLEBsEWP3ajihizoU1u5
	VJRi+NuG9hGNVQjp1bIThuy+qUFN7NnJw6yF9XX9SRbSJG6GWGw9y8YTdUeVOEb2i1xI=;
Message-ID: <641173d4-2629-e4b6-d4ec-06bd629141cc@xen.org>
Date: Tue, 12 Oct 2021 22:22:47 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.2.0
Subject: Re: [PATCH V6 2/2] libxl/arm: Add handling of extended regions for
 DomU
To: Oleksandr <olekstysh@gmail.com>
Cc: xen-devel@lists.xenproject.org,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>,
 Anthony PERARD <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <1633974539-7380-1-git-send-email-olekstysh@gmail.com>
 <1633974539-7380-3-git-send-email-olekstysh@gmail.com>
 <c98c1acd-86c0-f556-643e-e472b696644f@xen.org>
 <51f9154f-3b65-c7c0-cd93-cecdc2a0975e@gmail.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <51f9154f-3b65-c7c0-cd93-cecdc2a0975e@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi Oleksandr,

On 12/10/2021 18:42, Oleksandr wrote:
> On 12.10.21 19:05, Julien Grall wrote:
>> On 11/10/2021 18:48, Oleksandr Tyshchenko wrote:
>>> ---
>>>   tools/libs/light/libxl_arm.c  | 76 
>>> ++++++++++++++++++++++++++++++++++++++++---
>>>   xen/include/public/arch-arm.h |  2 ++
>>>   2 files changed, 73 insertions(+), 5 deletions(-)
>>>
>>> diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c
>>> index e3140a6..c0e8415 100644
>>> --- a/tools/libs/light/libxl_arm.c
>>> +++ b/tools/libs/light/libxl_arm.c
>>> @@ -598,9 +598,20 @@ static int make_timer_node(libxl__gc *gc, void 
>>> *fdt,
>>>       return 0;
>>>   }
>>>   +#define ALIGN_UP_TO_2MB(x)   (((x) + MB(2) - 1) & (~(MB(2) - 1)))
>>> +
>>>   static int make_hypervisor_node(libxl__gc *gc, void *fdt,
>>> -                                const libxl_version_info *vers)
>>> +                                const libxl_version_info *vers,
>>> +                                const libxl_domain_build_info *b_info,
>>> +                                const struct xc_dom_image *dom)
>>>   {
>>> +    uint64_t region_size[GUEST_RAM_BANKS] = {0}, 
>>> region_base[GUEST_RAM_BANKS],
>>> +        bank1end, ramsize;
>>> +    uint32_t regs[(GUEST_ROOT_ADDRESS_CELLS + GUEST_ROOT_SIZE_CELLS) *
>>> +                  (GUEST_RAM_BANKS + 1)];
>>> +    be32 *cells = &regs[0];
>>> +    unsigned int i, len, nr_regions = 0;
>>> +    libxl_dominfo info;
>>>       int res;
>>>       gic_interrupt intr;
>>>   @@ -615,9 +626,64 @@ static int make_hypervisor_node(libxl__gc *gc, 
>>> void *fdt,
>>>                                 "xen,xen");
>>>       if (res) return res;
>>>   -    /* reg 0 is grant table space */
>>> -    res = fdt_property_regs(gc, fdt, GUEST_ROOT_ADDRESS_CELLS, 
>>> GUEST_ROOT_SIZE_CELLS,
>>> -                            1,GUEST_GNTTAB_BASE, GUEST_GNTTAB_SIZE);
>>> +    if (strcmp(dom->guest_type, "xen-3.0-aarch64")) {
>>> +        LOG(WARN, "The extended regions are only supported for 
>>> 64-bit guest currently");
>>> +        goto out;
>>> +    }
>>
>> I understand why we want to limit to 64-bit domain for dom0. But I am 
>> not sure this is warrant for 32-bit domain. At worse, the guest will 
>> ignore the bank because it is not usable. So could we drop the check?
> 
> Yes.
> 
> 
>>
>>
>>> +
>>> +    res = libxl_domain_info(CTX, &info, dom->guest_domid);
>>> +    if (res) return res;
>>> +
>>> +    assert(info.gpaddr_bits >= 32 && info.gpaddr_bits <= 48);
>> What could go wrong below if gpaddr_bits is not within this range?
> 
> if info.gpaddr_bits is less than 64, then nothing bad, otherwise, I 
> assume we will get shift count overflow.

So I think the assert() is not suitable here because even if the 
gpaddr_bits is provided by the hypervisor (and therefore should be 
trusted), this is a different component so hardening the code is a good 
practice.

In this case, I would check that info.gpaddr_bits <= 64 and return an 
error. The reason I am suggesting <= 64 and not 48 is because Arm 
already supports 52 bits address space. Yet, I still like to avoid this 
assumption in the code. Something like below should work:

bank1end = GUEST_RAM1_BASE + GUEST_RAM1_SIZE - 1;
bank1end = min(bank1end, ~(0ULL) >> (64 - info.gpaddr_bits);

>>> +
>>> +    /*
>>> +     * Try to allocate separate 2MB-aligned extended regions from 
>>> the first
>>> +     * (below 4GB) and second (above 4GB) RAM banks taking into the 
>>> account
>>> +     * the maximum supported guest physical address space size and 
>>> the amount
>>> +     * of memory assigned to the guest.
>>> +     * As the guest memory layout is not populated yet we cannot 
>>> rely on
>>> +     * dom->rambank_size[], so calculate the actual size of both 
>>> banks using
>>> +     * "max_memkb" value.
>>> +     */
>>
>> At the moment, libxl doesn't know how libxc will allocate the memory. 
>> We may decide in the future to have only a small amount of memory 
>> below 4GB and then the rest above 4GB. With this approach it would be 
>> more difficult to modify the memory layout. Instead, I think we should 
>> create a placeholder that is updated once we know the banks in 
>> libxl__arch_domain_finalise_hw_description.
> 
> If I got your point correctly, this is close to how it was done from the 
> beginning. Yes, we can create placeholder(s) here and then update them 
> once the memory layout is populated. The problem is that we won't be 
> able to remove the placeholder(s) if we fail to allocate region(s) for 
> some reasons. So, we should know for sure in advance how many region(s) 
> we will be able to allocate later on in order to create the required 
> number of placeholders right now...  Please, look at the TODO I wrote in 
> finalise_ext_region() [1]. Or I misread your point?

You read correctly my point. However, I disagree that it is a problem to 
remove the placeholder if we fail to allocate the amount of regions 
expected.

Looking at libfdt, I can see two ways to deal with it:
   1) Use fdt_setprop()
   2) Delete the property using fdt_delprop() and then recreate it with 
fdt_appendprop()

The first solution is ideal and I think can work here to downsize the 
property. At worse, the second solution should work as the FDT blob will 
not increase.

>> We also probably want to mention in the memory layout in 
>> public/arch-arm.h this decision as the suggested way to find extended 
>> regions will definitely impact our decision to re-order the memory 
>> layout or shrink some regions in the future (I have in mind the PCI 
>> Passthrough work).
> 
> Sorry, I couldn't parse.

So this patch is relying on the fact that the regions reserved for the 
RAM are big enough to also accommodate the extended regions.

I am happy with this approach. However, I would like the approach to be 
documented in arch-arm.h because this is the first place one would look 
to understand the memory layout. This will be helpful if/when we need to 
modify the guest memory layout.

> 
> 
>>
>>
>>> +    ramsize = b_info->max_memkb * 1024;
>>> +    if (ramsize <= GUEST_RAM0_SIZE) {
>>> +        region_base[0] = GUEST_RAM0_BASE + ALIGN_UP_TO_2MB(ramsize);
>>> +        region_size[0] = GUEST_RAM0_SIZE - ALIGN_UP_TO_2MB(ramsize);
>>> +        region_base[1] = GUEST_RAM1_BASE;
>>> +    } else
>>> +        region_base[1] = GUEST_RAM1_BASE +
>>> +            ALIGN_UP_TO_2MB(ramsize - GUEST_RAM0_SIZE);
>>> +
>>> +    bank1end = min(1ULL << info.gpaddr_bits, GUEST_RAM1_BASE + 
>>> GUEST_RAM1_SIZE);
>>> +    if (bank1end > region_base[1])
>>> +        region_size[1] = bank1end - region_base[1];
>>
>> It would be best to not rely on the fact that Bank on is always below 
>> 4GB. If the code is too complex then we should look to add a 
>> BUILD_BUG_ON() to avoid any surprise.
> 
> Yes, I can add:
> 
> BUILD_BUG_ON((GUEST_RAM0_BASE + GUEST_RAM0_SIZE) > GB(4));

I am OK with that. But I wonder if we could simply use min(..., ) to 
avoid the BUILD_BUG_ON().

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Tue Oct 12 21:37:32 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 21:37:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.207667.363554 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maPSg-0006Ca-Ba; Tue, 12 Oct 2021 21:37:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 207667.363554; Tue, 12 Oct 2021 21:37:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maPSg-0006CT-7w; Tue, 12 Oct 2021 21:37:26 +0000
Received: by outflank-mailman (input) for mailman id 207667;
 Tue, 12 Oct 2021 21:37:24 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=SIAI=PA=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1maPSe-0006CN-QB
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 21:37:24 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 95f499fb-2ba4-11ec-8154-12813bfff9fa;
 Tue, 12 Oct 2021 21:37:23 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id 52AE060EDF;
 Tue, 12 Oct 2021 21:37:22 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 95f499fb-2ba4-11ec-8154-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1634074642;
	bh=/EYO8lfpC9uYZlP5GQ6hEiDvFhQ1zEIM5ARiVdRZMRw=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=Ld1Niw+JYbMj4g66ZHLy5Iy1NMiJZBrqbHyzhkuMT97NGAW+g3vA8L5j93UbupWNW
	 6pvBSn5FJS6lrX1aFq4eekJbe0gtcS30hr5eSR74XHDTbobHeFt1CTD9x45K7PlfWD
	 YtaBTTa977sQ/eNX3Yt02IIHAwJmunpMCaQHl6Lmn6WnqUQvVJtUs7gesKMdbW6+fR
	 zzjPPqYiEKd8i+JzYYsUde1BeSTrt5ZqnLA5VLEAetyY6MdigSW/FPtbsiEze2Vakd
	 kLgILB1Nicw5bJ9dX2QGmrPeSZIEOr6IJP0Bc9NQlU2jESo9BFIbv87cfGs/hVBuco
	 ldS3SmPCFpbVw==
Date: Tue, 12 Oct 2021 14:37:20 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Jan Beulich <jbeulich@suse.com>
cc: Stefano Stabellini <sstabellini@kernel.org>, 
    Bertrand Marquis <Bertrand.Marquis@arm.com>, 
    Rahul Singh <Rahul.Singh@arm.com>, Andre Przywara <Andre.Przywara@arm.com>, 
    Julien Grall <julien@xen.org>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, 
    Andrew Cooper <andrew.cooper3@citrix.com>, 
    George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>, 
    Wei Liu <wl@xen.org>, Paul Durrant <paul@xen.org>, 
    =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= <roger.pau@citrix.com>, 
    "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v5 08/11] xen/arm: Enable the existing x86 virtual PCI
 support for ARM.
In-Reply-To: <2fa4d2e2-7daf-6d52-ff4c-38a482af1fb9@suse.com>
Message-ID: <alpine.DEB.2.21.2110121436020.9408@sstabellini-ThinkPad-T480s>
References: <cover.1633540842.git.rahul.singh@arm.com> <9bdca2cda5d2e83f94dc2423e55714273539760a.1633540842.git.rahul.singh@arm.com> <6752f2d3-171b-37f5-c809-82995a8f3f36@suse.com> <CEF7FFB0-779A-4F46-8667-6BCD9BA5CB6C@arm.com> <b735c2d3-1dbb-ce0a-c2fa-160d4c6938d3@suse.com>
 <A8DEBD07-FB45-4E4E-A2C3-7AF8B393B032@arm.com> <59c9e102-c710-64d3-2a1a-cc8dcbcceead@suse.com> <alpine.DEB.2.21.2110111105180.25528@sstabellini-ThinkPad-T480s> <2fa4d2e2-7daf-6d52-ff4c-38a482af1fb9@suse.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Tue, 12 Oct 2021, Jan Beulich wrote:
> On 11.10.2021 20:18, Stefano Stabellini wrote:
> > On Mon, 11 Oct 2021, Jan Beulich wrote:
> >> On 11.10.2021 15:34, Bertrand Marquis wrote:
> >>>> On 11 Oct 2021, at 14:09, Jan Beulich <jbeulich@suse.com> wrote:
> >>>> On 11.10.2021 14:41, Bertrand Marquis wrote:
> >>>>> But digging deeper into this, I would have 2 questions:
> >>>>>
> >>>>> - msi_cleanup was done there after a request from Stefano, but is not
> >>>>> done in case or iommu error, is there an issue to solve here ?
> >>>>
> >>>> Maybe, but I'm not sure. This very much depends on what a domain
> >>>> could in principle do with a partly set-up device. Plus let's
> >>>> not forget that we're talking of only Dom0 here (for now at least,
> >>>> i.e. not considering the dom0less case).
> >>>>
> >>>> But I'd also like to further defer to Stefano.
> >>>
> >>> Ok, I must admit I do not really see at that stage why doing an MSI cleanup
> >>> could be needed so I will wait for Stefano to know if I need to keep this when
> >>> moving the block up (at the end it is theoretical right now as this is empty).
> > 
> > I know that MSIs are not supported yet on ARM (pci_cleanup_msi does
> > nothing). But I wanted to make sure that the pci_cleanup_msi() calls are
> > present anywhere necessary, especially on the error paths. So that once
> > we add MSI support, we don't need to search through the code to find all
> > the error paths missing a pci_cleanup_msi() call.
> > 
> > To answer your first question: you are right, we are also missing a
> > pci_cleanup_msi() call in the case of IOMMU error. So it might be better
> > to move the call to pci_cleanup_msi() under the "out" label so that we
> > can do it once for both cases.
> > 
> > To answer your second point about whether it is necessary at all: if
> > MSIs and MSI-Xs cannot be already setup at this point at all (not even
> > the enable bit), then we don't need any call to pci_cleanup_msi() in
> > pci_add_device.
> 
> Well, at the very least MSI can't be set up ahead of the traps getting
> put in place. Whether partial success of putting traps in place may
> allow a cunning guest to set up MSI may depend on further aspects.

Good point about MSIs not being setup before the traps. We should remove
the call to pci_cleanup_msi() in the error path then.


From xen-devel-bounces@lists.xenproject.org Tue Oct 12 21:43:44 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 21:43:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.207675.363565 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maPYb-0007bR-0e; Tue, 12 Oct 2021 21:43:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 207675.363565; Tue, 12 Oct 2021 21:43:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maPYa-0007bK-Tk; Tue, 12 Oct 2021 21:43:32 +0000
Received: by outflank-mailman (input) for mailman id 207675;
 Tue, 12 Oct 2021 21:43:31 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=P4MT=PA=gmail.com=olekstysh@srs-us1.protection.inumbo.net>)
 id 1maPYZ-0007bE-9L
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 21:43:31 +0000
Received: from mail-lf1-x129.google.com (unknown [2a00:1450:4864:20::129])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 675be4a1-4877-435f-8b46-bfe7019e6f03;
 Tue, 12 Oct 2021 21:43:28 +0000 (UTC)
Received: by mail-lf1-x129.google.com with SMTP id x27so2701334lfu.5
 for <xen-devel@lists.xenproject.org>; Tue, 12 Oct 2021 14:43:28 -0700 (PDT)
Received: from [192.168.1.7] ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id u25sm1135883lfc.176.2021.10.12.14.43.26
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Tue, 12 Oct 2021 14:43:27 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 675be4a1-4877-435f-8b46-bfe7019e6f03
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-transfer-encoding:content-language;
        bh=ptdloW3YWcAlJzynbmmiowqjnJFfkXnitqVRK7FB1F4=;
        b=c8ZKgfD2sfQjGiWOwq4ID0OtrYWz6tbfV7+wMNojJHHHy7L3ManQ8gWrcKMSWJ+F5w
         XhPU8xRjzOc6WxTbHROfcb71k7HAePVp6zj6EoCjWHLbd3YyT+ZrzXA4TogVgjBWvuKY
         2tqQE7VVWFo0oBHNNm+Ya2lqA9p2AYbJm1XIdwgSTCAct3v/LrI2OUgu/2t4eoNCzfBX
         WBYfxYVcVzNokF2/+e8JWwWeUjs5jupHjeGP6VPN3Wa+ygIyQe53o+7wjWM7rD+oQrbL
         OhsV7T6jJdGYb8L8Iw2I1rvtP4vXJJ3Z1ShqrTRCCUcC13UJDeeKQwCvpHXy9U69beHc
         kBsA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding
         :content-language;
        bh=ptdloW3YWcAlJzynbmmiowqjnJFfkXnitqVRK7FB1F4=;
        b=LfF1L1PMpncaRu/sqwpoWQYjoYiZfPaRYGyfYLqS8CLdUBdLy96jmOahzeQ95l+UtW
         yYKf6yAuH9mdCWP3atlEP94oW4/6CUIFxg5JgJQS2ULMJhIfSZKTuvhQb/f1w1VmmPja
         kVvhAiPThOevlN0xnLSSVULfKhfOYJaXW9QbCVwvlwBTImguxdcWsGDMAHKNmhz/4stq
         kwUYpxHupLIn/n162G8SiQBTMfwDcB51lvhb5J21+v5fUNEEgJF6/dmXi8+QHGQnpupe
         7qOxJHw9QCISyJHwxWbJzuTK5Aq0PxHYfNoRdk3p5py7MZJlF4Xlwhso+Z0Ug66cEUev
         fgrw==
X-Gm-Message-State: AOAM531+2Ij6+WP2W5kMpEL8DRYNWwN78+nLA+NTnju7TPMx9V+zBbf9
	jZNaxrm6VPnNf6649SZAsgI=
X-Google-Smtp-Source: ABdhPJzh3o7TdBg9Z6plJTphSynCCKUyufYWGiblLjm7jUDOH2s7cpFVafe9G8SoYAFPUnCSJqX+RQ==
X-Received: by 2002:a2e:6c06:: with SMTP id h6mr16861593ljc.317.1634075007705;
        Tue, 12 Oct 2021 14:43:27 -0700 (PDT)
Subject: Re: [PATCH V6 2/2] libxl/arm: Add handling of extended regions for
 DomU
To: Julien Grall <julien@xen.org>, Ian Jackson <iwj@xenproject.org>
Cc: xen-devel@lists.xenproject.org,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, Wei Liu <wl@xen.org>,
 Anthony PERARD <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <1633974539-7380-1-git-send-email-olekstysh@gmail.com>
 <1633974539-7380-3-git-send-email-olekstysh@gmail.com>
 <c98c1acd-86c0-f556-643e-e472b696644f@xen.org>
 <51f9154f-3b65-c7c0-cd93-cecdc2a0975e@gmail.com>
 <641173d4-2629-e4b6-d4ec-06bd629141cc@xen.org>
From: Oleksandr <olekstysh@gmail.com>
Message-ID: <acc06366-b381-daa0-8e2a-54c2761019af@gmail.com>
Date: Wed, 13 Oct 2021 00:43:26 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <641173d4-2629-e4b6-d4ec-06bd629141cc@xen.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US


On 13.10.21 00:22, Julien Grall wrote:
> Hi Oleksandr,

Hi Julien, Ian.


Julien, thank you for the detailed answer, I will analyze it tomorrow.

Ian, I think, there is no reason in providing git branch with the acks 
folded in + my minor fix for the debug message as it was discussed 
before, it sounds like there is more work to do, so it is going to be a 
new version anyway.




>
> On 12/10/2021 18:42, Oleksandr wrote:
>> On 12.10.21 19:05, Julien Grall wrote:
>>> On 11/10/2021 18:48, Oleksandr Tyshchenko wrote:
>>>> ---
>>>>   tools/libs/light/libxl_arm.c  | 76 
>>>> ++++++++++++++++++++++++++++++++++++++++---
>>>>   xen/include/public/arch-arm.h |  2 ++
>>>>   2 files changed, 73 insertions(+), 5 deletions(-)
>>>>
>>>> diff --git a/tools/libs/light/libxl_arm.c 
>>>> b/tools/libs/light/libxl_arm.c
>>>> index e3140a6..c0e8415 100644
>>>> --- a/tools/libs/light/libxl_arm.c
>>>> +++ b/tools/libs/light/libxl_arm.c
>>>> @@ -598,9 +598,20 @@ static int make_timer_node(libxl__gc *gc, void 
>>>> *fdt,
>>>>       return 0;
>>>>   }
>>>>   +#define ALIGN_UP_TO_2MB(x)   (((x) + MB(2) - 1) & (~(MB(2) - 1)))
>>>> +
>>>>   static int make_hypervisor_node(libxl__gc *gc, void *fdt,
>>>> -                                const libxl_version_info *vers)
>>>> +                                const libxl_version_info *vers,
>>>> +                                const libxl_domain_build_info 
>>>> *b_info,
>>>> +                                const struct xc_dom_image *dom)
>>>>   {
>>>> +    uint64_t region_size[GUEST_RAM_BANKS] = {0}, 
>>>> region_base[GUEST_RAM_BANKS],
>>>> +        bank1end, ramsize;
>>>> +    uint32_t regs[(GUEST_ROOT_ADDRESS_CELLS + 
>>>> GUEST_ROOT_SIZE_CELLS) *
>>>> +                  (GUEST_RAM_BANKS + 1)];
>>>> +    be32 *cells = &regs[0];
>>>> +    unsigned int i, len, nr_regions = 0;
>>>> +    libxl_dominfo info;
>>>>       int res;
>>>>       gic_interrupt intr;
>>>>   @@ -615,9 +626,64 @@ static int make_hypervisor_node(libxl__gc 
>>>> *gc, void *fdt,
>>>>                                 "xen,xen");
>>>>       if (res) return res;
>>>>   -    /* reg 0 is grant table space */
>>>> -    res = fdt_property_regs(gc, fdt, GUEST_ROOT_ADDRESS_CELLS, 
>>>> GUEST_ROOT_SIZE_CELLS,
>>>> -                            1,GUEST_GNTTAB_BASE, GUEST_GNTTAB_SIZE);
>>>> +    if (strcmp(dom->guest_type, "xen-3.0-aarch64")) {
>>>> +        LOG(WARN, "The extended regions are only supported for 
>>>> 64-bit guest currently");
>>>> +        goto out;
>>>> +    }
>>>
>>> I understand why we want to limit to 64-bit domain for dom0. But I 
>>> am not sure this is warrant for 32-bit domain. At worse, the guest 
>>> will ignore the bank because it is not usable. So could we drop the 
>>> check?
>>
>> Yes.
>>
>>
>>>
>>>
>>>> +
>>>> +    res = libxl_domain_info(CTX, &info, dom->guest_domid);
>>>> +    if (res) return res;
>>>> +
>>>> +    assert(info.gpaddr_bits >= 32 && info.gpaddr_bits <= 48);
>>> What could go wrong below if gpaddr_bits is not within this range?
>>
>> if info.gpaddr_bits is less than 64, then nothing bad, otherwise, I 
>> assume we will get shift count overflow.
>
> So I think the assert() is not suitable here because even if the 
> gpaddr_bits is provided by the hypervisor (and therefore should be 
> trusted), this is a different component so hardening the code is a 
> good practice.
>
> In this case, I would check that info.gpaddr_bits <= 64 and return an 
> error. The reason I am suggesting <= 64 and not 48 is because Arm 
> already supports 52 bits address space. Yet, I still like to avoid 
> this assumption in the code. Something like below should work:
>
> bank1end = GUEST_RAM1_BASE + GUEST_RAM1_SIZE - 1;
> bank1end = min(bank1end, ~(0ULL) >> (64 - info.gpaddr_bits);
>
>>>> +
>>>> +    /*
>>>> +     * Try to allocate separate 2MB-aligned extended regions from 
>>>> the first
>>>> +     * (below 4GB) and second (above 4GB) RAM banks taking into 
>>>> the account
>>>> +     * the maximum supported guest physical address space size and 
>>>> the amount
>>>> +     * of memory assigned to the guest.
>>>> +     * As the guest memory layout is not populated yet we cannot 
>>>> rely on
>>>> +     * dom->rambank_size[], so calculate the actual size of both 
>>>> banks using
>>>> +     * "max_memkb" value.
>>>> +     */
>>>
>>> At the moment, libxl doesn't know how libxc will allocate the 
>>> memory. We may decide in the future to have only a small amount of 
>>> memory below 4GB and then the rest above 4GB. With this approach it 
>>> would be more difficult to modify the memory layout. Instead, I 
>>> think we should create a placeholder that is updated once we know 
>>> the banks in libxl__arch_domain_finalise_hw_description.
>>
>> If I got your point correctly, this is close to how it was done from 
>> the beginning. Yes, we can create placeholder(s) here and then update 
>> them once the memory layout is populated. The problem is that we 
>> won't be able to remove the placeholder(s) if we fail to allocate 
>> region(s) for some reasons. So, we should know for sure in advance 
>> how many region(s) we will be able to allocate later on in order to 
>> create the required number of placeholders right now...  Please, look 
>> at the TODO I wrote in finalise_ext_region() [1]. Or I misread your 
>> point?
>
> You read correctly my point. However, I disagree that it is a problem 
> to remove the placeholder if we fail to allocate the amount of regions 
> expected.
>
> Looking at libfdt, I can see two ways to deal with it:
>   1) Use fdt_setprop()
>   2) Delete the property using fdt_delprop() and then recreate it with 
> fdt_appendprop()
>
> The first solution is ideal and I think can work here to downsize the 
> property. At worse, the second solution should work as the FDT blob 
> will not increase.
>
>>> We also probably want to mention in the memory layout in 
>>> public/arch-arm.h this decision as the suggested way to find 
>>> extended regions will definitely impact our decision to re-order the 
>>> memory layout or shrink some regions in the future (I have in mind 
>>> the PCI Passthrough work).
>>
>> Sorry, I couldn't parse.
>
> So this patch is relying on the fact that the regions reserved for the 
> RAM are big enough to also accommodate the extended regions.
>
> I am happy with this approach. However, I would like the approach to 
> be documented in arch-arm.h because this is the first place one would 
> look to understand the memory layout. This will be helpful if/when we 
> need to modify the guest memory layout.
>
>>
>>
>>>
>>>
>>>> +    ramsize = b_info->max_memkb * 1024;
>>>> +    if (ramsize <= GUEST_RAM0_SIZE) {
>>>> +        region_base[0] = GUEST_RAM0_BASE + ALIGN_UP_TO_2MB(ramsize);
>>>> +        region_size[0] = GUEST_RAM0_SIZE - ALIGN_UP_TO_2MB(ramsize);
>>>> +        region_base[1] = GUEST_RAM1_BASE;
>>>> +    } else
>>>> +        region_base[1] = GUEST_RAM1_BASE +
>>>> +            ALIGN_UP_TO_2MB(ramsize - GUEST_RAM0_SIZE);
>>>> +
>>>> +    bank1end = min(1ULL << info.gpaddr_bits, GUEST_RAM1_BASE + 
>>>> GUEST_RAM1_SIZE);
>>>> +    if (bank1end > region_base[1])
>>>> +        region_size[1] = bank1end - region_base[1];
>>>
>>> It would be best to not rely on the fact that Bank on is always 
>>> below 4GB. If the code is too complex then we should look to add a 
>>> BUILD_BUG_ON() to avoid any surprise.
>>
>> Yes, I can add:
>>
>> BUILD_BUG_ON((GUEST_RAM0_BASE + GUEST_RAM0_SIZE) > GB(4));
>
> I am OK with that. But I wonder if we could simply use min(..., ) to 
> avoid the BUILD_BUG_ON().
>
> Cheers,
>
-- 
Regards,

Oleksandr Tyshchenko



From xen-devel-bounces@lists.xenproject.org Tue Oct 12 21:48:11 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 21:48:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.207683.363576 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maPd3-0008H0-KQ; Tue, 12 Oct 2021 21:48:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 207683.363576; Tue, 12 Oct 2021 21:48:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maPd3-0008Gt-FZ; Tue, 12 Oct 2021 21:48:09 +0000
Received: by outflank-mailman (input) for mailman id 207683;
 Tue, 12 Oct 2021 21:48:07 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=SIAI=PA=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1maPd1-0008GU-Ae
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 21:48:07 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 1c972439-c221-44e4-82f6-6f4797510a08;
 Tue, 12 Oct 2021 21:48:06 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id 6AB6060F92;
 Tue, 12 Oct 2021 21:48:05 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1c972439-c221-44e4-82f6-6f4797510a08
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1634075286;
	bh=tbto5fAni3B84AbFpdLv1HG9sxkBTBmcZ9Ze4Du/azA=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=pELu/u/M9yHjuoxsQgIRPP6MPOPS8ZrAMPKHBrMiATyABtNvggm4TJXlrwGmZ0cYB
	 1u3Ykcnm9r/fISXUYLVr7Z4plDnutssw6PkIFYrt+qWzXlJGrLsmBB4LdWPQynHunM
	 YKv26m+CVimybHQGyB1IypxZnnWcU5BiZusSYyakBemzxfuJxER/T/4kixqtpNoT9u
	 Bkt9zI86Dhx1RQ/iBTxn/Y0fSFv/UZ1XrF0JmMrmJYleFByKt0iH1hXWC7oFJNwHvE
	 kAvLW4R1i4l+ahqIQtXAJE34rdrE/XafTCJgkP1UX4ames1+o4l3HdLiwH69vcoxsI
	 fMdfM78C5DYDw==
Date: Tue, 12 Oct 2021 14:48:04 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= <roger.pau@citrix.com>
cc: Rahul Singh <rahul.singh@arm.com>, xen-devel@lists.xenproject.org, 
    bertrand.marquis@arm.com, Andre.Przywara@arm.com, 
    Christian Lindig <christian.lindig@citrix.com>, 
    David Scott <dave@recoil.org>, Ian Jackson <iwj@xenproject.org>, 
    Wei Liu <wl@xen.org>, Andrew Cooper <andrew.cooper3@citrix.com>, 
    George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>, 
    Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH v5 07/11] xen/domctl: Introduce XEN_DOMCTL_CDF_vpci
 flag
In-Reply-To: <YWQDguvmf/O4rDIs@MacBook-Air-de-Roger.local>
Message-ID: <alpine.DEB.2.21.2110121439100.9408@sstabellini-ThinkPad-T480s>
References: <cover.1633540842.git.rahul.singh@arm.com> <20d5b9d6a0d01a7b90711d28cbefb5701a88b438.1633540842.git.rahul.singh@arm.com> <YWQDguvmf/O4rDIs@MacBook-Air-de-Roger.local>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: multipart/mixed; BOUNDARY="8323329-664768228-1634074774=:9408"
Content-ID: <alpine.DEB.2.21.2110121439400.9408@sstabellini-ThinkPad-T480s>

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-664768228-1634074774=:9408
Content-Type: text/plain; CHARSET=UTF-8
Content-Transfer-Encoding: 8BIT
Content-ID: <alpine.DEB.2.21.2110121439401.9408@sstabellini-ThinkPad-T480s>

On Mon, 11 Oct 2021, Roger Pau Monné wrote:
> On Wed, Oct 06, 2021 at 06:40:33PM +0100, Rahul Singh wrote:
> > Introduce XEN_DOMCTL_CDF_vpci flag to enable VPCI support in XEN.
> > Reject the use of this new flag for x86 as VPCI is not supported for
> > DOMU guests for x86.
> 
> I don't like this approach, XEN_DOMCTL_CDF_vpci should be set for x86
> PVH dom0, like we do for any other CDF flags when Xen builds dom0.
> 
> Things like PVH vs PV get translated into CDF flags by create_dom0,
> and processed normally by the sanitise_domain_config logic, vPCI
> should be handled that way.
> 
> Do you think you could see about fixing this?

Andrew suggested to use XEN_SYSCTL_PHYSCAP_vpci to check whether we can
set XEN_DOMCTL_CDF_vpci in libxl and it looks like we have consensus on
this approach. [1][2]

So it makes sense that XEN_DOMCTL_CDF_vpci is only set when
XEN_SYSCTL_PHYSCAP_vpci is also set, i.e. XEN_SYSCTL_PHYSCAP_vpci ==
XEN_DOMCTL_CDF_vpci.

>From [2], XEN_SYSCTL_PHYSCAP_vpci is not going to be set on x86, so then
XEN_DOMCTL_CDF_vpci should also be left unset?

If you think XEN_DOMCTL_CDF_vpci should be set for x86 PVH Dom0, then
XEN_SYSCTL_PHYSCAP_vpci should also be set for x86 PVH Dom0.


[1] https://marc.info/?l=xen-devel&m=163372953907637
[2] https://marc.info/?l=xen-devel&m=163395821428850
--8323329-664768228-1634074774=:9408--


From xen-devel-bounces@lists.xenproject.org Tue Oct 12 21:58:05 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 21:58:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.207691.363587 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maPmY-0001Hs-FO; Tue, 12 Oct 2021 21:57:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 207691.363587; Tue, 12 Oct 2021 21:57:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maPmY-0001Hl-BZ; Tue, 12 Oct 2021 21:57:58 +0000
Received: by outflank-mailman (input) for mailman id 207691;
 Tue, 12 Oct 2021 21:57:57 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1maPmX-0001Hf-7d
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 21:57:57 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1maPmX-0002kr-2o; Tue, 12 Oct 2021 21:57:57 +0000
Received: from 54-240-197-225.amazon.com ([54.240.197.225] helo=[192.168.23.5])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1maPmW-0005xW-SR; Tue, 12 Oct 2021 21:57:57 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=0gOdKZSlq9Ajq7NcXh44sS3qwIYrAyVreVd98Uns7nY=; b=l36CLYwwA7N9fTIDFi6RqjMQQU
	LNXIBrnI5+Gip2Y6TNE4uP2rZIeqXPTs9JP5xVCS7wgx5ekg5PxRbjioJYAXHUX8E6h5OFFgEjnh5
	sV3+inc76ZNrOykPY5niB6Vog36/ZEz4J214TVNmllewSoZBYJGKW7IX7xEexBo0ahbQ=;
Message-ID: <2006f09d-25c3-af7a-cbea-dbc811fc8748@xen.org>
Date: Tue, 12 Oct 2021 22:57:55 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.2.0
Subject: Re: [PATCH v2] xen/arm: vgic to ignore GICD ICPENRn registers access
To: Hongda Deng <Hongda.Deng@arm.com>, xen-devel@lists.xenproject.org,
 sstabellini@kernel.org
Cc: Bertrand.Marquis@arm.com, Wei.Chen@arm.com
References: <20211012062449.30966-1-Hongda.Deng@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20211012062449.30966-1-Hongda.Deng@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

On 12/10/2021 07:24, Hongda Deng wrote:
> Currently, Xen will return IO unhandled when guests access GICD ICPENRn
> registers. This will raise a data abort inside guest. For Linux Guest,
> these virtual registers will not be accessed. But for Zephyr, in its
> GIC initialization code, these virtual registers will be accessed. And
> zephyr guest will get an IO data abort in initilization stage and enter
> fatal error. Emulating ICPENDR is not easy with the existing vGIC, so
> we currently ignore these virtual registers access and print a message
> about whether they are already pending instead of returning unhandled.
> More details can be found at [1].

The link you provide only states that I am happy with the warning. This 
doesn't seem relevant for a future reader. Did you intend to point to 
something different?

> 
> [1] https://lists.xenproject.org/archives/html/xen-devel/2021-09/
> msg00744.html
> 
> Signed-off-by: Hongda Deng <hongda.deng@arm.com>
> ---
>   xen/arch/arm/vgic-v2.c | 26 +++++++++++++++++++++++++-
>   xen/arch/arm/vgic-v3.c | 40 +++++++++++++++++++++++++++++++---------
>   2 files changed, 56 insertions(+), 10 deletions(-)
> 
> diff --git a/xen/arch/arm/vgic-v2.c b/xen/arch/arm/vgic-v2.c
> index b2da886adc..d7ffaeeb65 100644
> --- a/xen/arch/arm/vgic-v2.c
> +++ b/xen/arch/arm/vgic-v2.c
> @@ -480,11 +480,35 @@ static int vgic_v2_distr_mmio_write(struct vcpu *v, mmio_info_t *info,
>           return 1;
>   
>       case VRANGE32(GICD_ICPENDR, GICD_ICPENDRN):
> +    {
> +        struct pending_irq *iter;
> +        unsigned int irq_start;
> +        unsigned int irq_end;
> +        uint32_t irq_pending = 0;
> +
>           if ( dabt.size != DABT_WORD ) goto bad_width;
>           printk(XENLOG_G_ERR
>                  "%pv: vGICD: unhandled word write %#"PRIregister" to ICPENDR%d\n",
>                  v, r, gicd_reg - GICD_ICPENDR);

As I wrote in v1, we should avoid to print a message when we know there 
is no pending interrupts.

> -        return 0;
> +
> +        irq_start = (gicd_reg - GICD_ICPENDR) * 32;
> +        irq_end = irq_start + 31;
> +        /* go through inflight_irqs and print specified pending irqs */
> +        list_for_each_entry(iter, &v->arch.vgic.inflight_irqs, inflight)
You need to hold v->arch.vgic.lock (with interrupt disabled) to go 
through the list of inflight irqs. Otherwise, the list may be modified 
while you are walking it.

However, I am a little bit concerned with this approached (I noticed 
Stefano suggested). The list may in theory contains a few hundreds 
interrupts (a malicious OS May decide to never read IAR). So we are 
potentially doing more work than necessary (we need to think about the 
worse case scenario).

Instead, I think it would be better to go through the 32 interrupts and 
for each of them:
   1) find the pending_irq() using irq_to_pending()
   2) check if the IRQ in the inflight list with list_empty(&p->inflight)

In addition to that, you want to check that the rank exists so we don't 
do any extra work if the guest is trying to clear an interrupts above 
the number of interrupts we support.

> +        {
> +            if ( iter->irq < irq_start || irq_end < iter->irq )
> +                continue;
> +
> +            if ( test_bit(GIC_IRQ_GUEST_QUEUED, &iter->status) )
> +                irq_pending = irq_pending | (1 << (iter->irq - irq_start));
> +        }
> +
> +        if ( irq_pending != 0 )
> +            printk(XENLOG_G_ERR
> +                   "%pv: vGICD: ICPENDR%d=0x%08x\n",
> +                   v, gicd_reg - GICD_ICPENDR, irq_pending);

This message is a bit confusing. I think it would be worth to print a 
message for every interrupt not cleared. Maybe something like:

"%pv trying to clear pending interrupt %u."

> +        goto write_ignore_32;
> +    }
>   
>       case VRANGE32(GICD_ISACTIVER, GICD_ISACTIVERN):
>           if ( dabt.size != DABT_WORD ) goto bad_width;
> diff --git a/xen/arch/arm/vgic-v3.c b/xen/arch/arm/vgic-v3.c
> index cb5a70c42e..243b24e496 100644
> --- a/xen/arch/arm/vgic-v3.c
> +++ b/xen/arch/arm/vgic-v3.c
> @@ -816,11 +816,35 @@ static int __vgic_v3_distr_common_mmio_write(const char *name, struct vcpu *v,
>           return 1;
>   
>       case VRANGE32(GICD_ICPENDR, GICD_ICPENDRN):
> +    {
> +        struct pending_irq *iter;
> +        unsigned int irq_start;
> +        unsigned int irq_end;
> +        uint32_t irq_pending = 0;
> +
>           if ( dabt.size != DABT_WORD ) goto bad_width;
>           printk(XENLOG_G_ERR
>                  "%pv: %s: unhandled word write %#"PRIregister" to ICPENDR%d\n",
>                  v, name, r, reg - GICD_ICPENDR);
> -        return 0;
> +
> +        irq_start = (reg - GICD_ICPENDR) * 32;
> +        irq_end = irq_start + 31;
> +        /* go through inflight_irqs and print specified pending irqs */
> +        list_for_each_entry(iter, &v->arch.vgic.inflight_irqs, inflight)
> +        {
> +            if ( iter->irq < irq_start || irq_end < iter->irq )
> +                continue;
> +
> +            if ( test_bit(GIC_IRQ_GUEST_QUEUED, &iter->status) )
> +                irq_pending = irq_pending | (1 << (iter->irq - irq_start));
> +        }
> +
> +        if ( irq_pending != 0 )
> +            printk(XENLOG_G_ERR
> +                   "%pv: %s: ICPENDR%d=0x%08x\n",
> +                   v, name, reg - GICD_ICPENDR, irq_pending);

My remarks apply for GICv3 as well. Note that in the case of GICv3 v may 
not be current.

That said, the code is quite similar and not trivial. Can we provide an 
helper that can be used for the two GICs?

> +        goto write_ignore_32;
> +    }
>   
>       case VRANGE32(GICD_ISACTIVER, GICD_ISACTIVERN):
>           if ( dabt.size != DABT_WORD ) goto bad_width;
> @@ -978,19 +1002,17 @@ static int vgic_v3_rdistr_sgi_mmio_write(struct vcpu *v, mmio_info_t *info,
>       case VREG32(GICR_ICFGR1):
>       case VRANGE32(GICR_IPRIORITYR0, GICR_IPRIORITYR7):
>       case VREG32(GICR_ISPENDR0):
> -         /*
> -          * Above registers offset are common with GICD.
> -          * So handle common with GICD handling
> -          */
> +        /*
> +        * Above registers offset are common with GICD.
> +        * So handle common with GICD handling
> +        */

This looks like a spurious change.

>           return __vgic_v3_distr_common_mmio_write("vGICR: SGI", v,
>                                                    info, gicr_reg, r);
>   
>       case VREG32(GICR_ICPENDR0):
>           if ( dabt.size != DABT_WORD ) goto bad_width;
> -        printk(XENLOG_G_ERR
> -               "%pv: vGICR: SGI: unhandled word write %#"PRIregister" to ICPENDR0\n",
> -               v, r);
> -        return 0;
> +        return __vgic_v3_distr_common_mmio_write("vGICR: SGI", v,
> +                                                 info, gicr_reg, r);
>   
>       case VREG32(GICR_IGRPMODR0):
>           /* We do not implement security extensions for guests, write ignore */
> 

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Tue Oct 12 22:07:38 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 22:07:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.207703.363598 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maPvq-0002pN-Fo; Tue, 12 Oct 2021 22:07:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 207703.363598; Tue, 12 Oct 2021 22:07:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maPvq-0002pG-Ci; Tue, 12 Oct 2021 22:07:34 +0000
Received: by outflank-mailman (input) for mailman id 207703;
 Tue, 12 Oct 2021 22:07:33 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1maPvp-0002pA-KM
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 22:07:33 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1maPvp-0002wP-93; Tue, 12 Oct 2021 22:07:33 +0000
Received: from 54-240-197-225.amazon.com ([54.240.197.225] helo=[192.168.23.5])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1maPvp-0006qZ-3L; Tue, 12 Oct 2021 22:07:33 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=wz7KqvDGMXaU/Hab4xQzpQ+6eQFpSZptb6ArSemFLaU=; b=whb7wICAWlvXegQqWzTQt73OH/
	kDY8z41rqFjHhdoMwIVkXqt1vcxYcR6CXxvcz4OfPzMaSyFMZlmzwESVvbC5sYS06WyP7hwQrYdAs
	50HGj5HQHvUwggmRAvBRXcbm0rJp7tsTEC9w1riBJbZ1OMcSTGOezNRRlViuYgSO0OaM=;
Message-ID: <6ea907cc-0e85-6d86-9219-837c2e98ec3d@xen.org>
Date: Tue, 12 Oct 2021 23:07:31 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.2.0
Subject: Re: [PATCH v5 2/3] xen/arm: Check for PMU platform support
To: Michal Orzel <michal.orzel@arm.com>, xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, bertrand.marquis@arm.com
References: <20211012081323.14141-1-michal.orzel@arm.com>
 <20211012081323.14141-3-michal.orzel@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20211012081323.14141-3-michal.orzel@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Michal,

On 12/10/2021 09:13, Michal Orzel wrote:
> ID_AA64DFR0_EL1/ID_DFR0_EL1 registers provide
> information about PMU support. Replace structure
> dbg64/dbg32 with a union and fill in all the
> register fields according to document:
> ARM Architecture Registers(DDI 0595, 2021-06).
> 
> Add macros boot_dbg_feature64/boot_dbg_feature32
> to check for a debug feature. Add macro
> cpu_has_pmu to check for PMU support.
> Any value higher than 0 and less than 15 means
> that PMU is supported (we do not care about its
> version for now).
> 
> Signed-off-by: Michal Orzel <michal.orzel@arm.com>
> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
> Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>
> ---
> Changes since v4:
> -improve checks for PMU
> Changes since v3:
> -none
> Changes since v2:
> -none
> Changes since v1:
> -new in v2
> ---
>   xen/include/asm-arm/cpufeature.h | 51 ++++++++++++++++++++++++++++++--
>   1 file changed, 49 insertions(+), 2 deletions(-)
> 
> diff --git a/xen/include/asm-arm/cpufeature.h b/xen/include/asm-arm/cpufeature.h
> index 5ca09b0bff..0ddf38858a 100644
> --- a/xen/include/asm-arm/cpufeature.h
> +++ b/xen/include/asm-arm/cpufeature.h
> @@ -4,6 +4,7 @@
>   #ifdef CONFIG_ARM_64
>   #define cpu_feature64(c, feat)         ((c)->pfr64.feat)
>   #define boot_cpu_feature64(feat)       (system_cpuinfo.pfr64.feat)
> +#define boot_dbg_feature64(feat)       (system_cpuinfo.dbg64.feat)
>   
>   #define cpu_feature64_has_el0_32(c)    (cpu_feature64(c, el0) == 2)
>   
> @@ -22,6 +23,7 @@
>   
>   #define cpu_feature32(c, feat)         ((c)->pfr32.feat)
>   #define boot_cpu_feature32(feat)       (system_cpuinfo.pfr32.feat)
> +#define boot_dbg_feature32(feat)       (system_cpuinfo.dbg32.feat)
>   
>   #define cpu_has_arm       (boot_cpu_feature32(arm) == 1)
>   #define cpu_has_thumb     (boot_cpu_feature32(thumb) >= 1)
> @@ -32,8 +34,12 @@
>   
>   #ifdef CONFIG_ARM_32
>   #define cpu_has_gentimer  (boot_cpu_feature32(gentimer) == 1)
> +#define cpu_has_pmu       ((boot_dbg_feature32(perfmon) >= 1) && \
> +                           (boot_dbg_feature32(perfmon) < 15))

So I am happy with this check for arm32. But I would still like to have 
a comment explaining the fact that on Armv7 perfmon == 0 may mean PMUv1 
is may be used. Something like:

"On Armv7, the value 0 is used to indicate that PMUv2 is not supported. 
IOW this doesn't tell us whether the PMU is not supported (a processor 
may implement PMUv1).

For convenience, we treat 0 as not supported which this match the 
meaning on Armv8".

The rest of the code looks fine to me.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Tue Oct 12 22:09:13 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 22:09:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.207711.363608 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maPxQ-0003Rd-RX; Tue, 12 Oct 2021 22:09:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 207711.363608; Tue, 12 Oct 2021 22:09:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maPxQ-0003RW-Oj; Tue, 12 Oct 2021 22:09:12 +0000
Received: by outflank-mailman (input) for mailman id 207711;
 Tue, 12 Oct 2021 22:09:10 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=quuu=PA=gmail.com=alistair23@srs-us1.protection.inumbo.net>)
 id 1maPxO-0003RG-Qt
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 22:09:10 +0000
Received: from mail-io1-xd35.google.com (unknown [2607:f8b0:4864:20::d35])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id f17d6988-d9f5-411b-a1c8-080451070c63;
 Tue, 12 Oct 2021 22:09:09 +0000 (UTC)
Received: by mail-io1-xd35.google.com with SMTP id r134so539455iod.11
 for <xen-devel@lists.xenproject.org>; Tue, 12 Oct 2021 15:09:09 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f17d6988-d9f5-411b-a1c8-080451070c63
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=A8tS+FAHb9od7Jib5DnZFG/AjAZmK7umWqwvEa27qRs=;
        b=KgJmrojIfIEoCIxkxm2pMhrD9TpGtoXxwR1poaKrLuSJGMMYye9D/Ag/6gIhZLwMqK
         QSnS0qgcs/nClxeGvvFml5xlJZ8fKFJL1NHDf3Ytb4dey7VvfMO3V+3TDrAUBSp3YdQc
         rbofhFzPIfc0Qz0/XArKCUn37t2da7sTf4b1aXdhk3Xlq1Smq1nbtV5bxTGwMxBpFHWR
         oxMJnuqDIt/p6TrixyF9DZbhiPPW2Ov7bocA62N1/KmbEjyRPTLmwBdRgvcBO1RRI3WP
         X6XzIJIch5MoxTaCLi6J+2br8EN+LXTHsgu1HgX+BYnNIx9o/KGFpZVEJppKSWLs08dk
         7pbA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=A8tS+FAHb9od7Jib5DnZFG/AjAZmK7umWqwvEa27qRs=;
        b=iNirruqtTvJdodXLMMxm2fxFT+yauZrEKg2X3WySJZf0WPPzy2kc76f5oAdQ7phSeR
         Cb/OeCmyILEKLD1ORlZdQx/pDsZaUU2v8JfH/1hZU2dn+NEz7FsxoCkbFQr0IMEo+9yE
         Cfhy1pP/pmEeDl9bSiupZsrKAN8gFaXCmSIBdX5MvhDh72HwIqD7C/VfcFin5DJ7chNs
         jugyhtbFG5hbvrhtzlBsOOvGjO01UOdEoKLViw9FhHVVd3MPPPNPtmoSpenfjnj0IOZC
         M7kRR/0au3kXEW4bmReZaA7zrlWaR6DZqoLmZ3q0OFFIY1d0vIBt1/Y3rHBkWq8MAWJS
         FFeg==
X-Gm-Message-State: AOAM533J+Q7UNLYO2nL7WO41Ikg2BVwk67lcVf/kIh0w9uyRHN9SY0Pq
	YyB7ztjaOWGzVmatMWvX47H7IhVHiePnVXQxLCc=
X-Google-Smtp-Source: ABdhPJyjn2JGj0C1wSr86O4QoFZL5yrk8p7xpOhtz4Neo2WsSYDHKD/N6rnNIFBr0q08yMYNVeb0MWkdpiH1X0GVpjo=
X-Received: by 2002:a05:6602:2e8c:: with SMTP id m12mr7416731iow.91.1634076549426;
 Tue, 12 Oct 2021 15:09:09 -0700 (PDT)
MIME-Version: 1.0
References: <20210922161405.140018-1-damien.hedde@greensocs.com> <20210922161405.140018-3-damien.hedde@greensocs.com>
In-Reply-To: <20210922161405.140018-3-damien.hedde@greensocs.com>
From: Alistair Francis <alistair23@gmail.com>
Date: Wed, 13 Oct 2021 08:08:43 +1000
Message-ID: <CAKmqyKN5JadUSb=-a5jn3Uz1WKj8Sb23buC0Nooa4mY4g7O=ew@mail.gmail.com>
Subject: Re: [RFC PATCH v2 02/16] qapi: Implement query-machine-phase QMP command
To: Damien Hedde <damien.hedde@greensocs.com>
Cc: "qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>, Peter Maydell <peter.maydell@linaro.org>, 
	"Michael S. Tsirkin" <mst@redhat.com>, David Hildenbrand <david@redhat.com>, Peter Xu <peterx@redhat.com>, 
	mirela.grujic@greensocs.com, Alistair Francis <Alistair.Francis@wdc.com>, 
	Gerd Hoffmann <kraxel@redhat.com>, Ani Sinha <ani@anisinha.ca>, Eric Blake <eblake@redhat.com>, 
	Stefano Stabellini <sstabellini@kernel.org>, "open list:X86" <xen-devel@lists.xenproject.org>, 
	Paul Durrant <paul@xen.org>, Markus Armbruster <armbru@redhat.com>, 
	Anthony Perard <anthony.perard@citrix.com>, 
	=?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= <marcandre.lureau@redhat.com>, 
	Eduardo Habkost <ehabkost@redhat.com>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>, 
	Eric Auger <eric.auger@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, 
	"open list:RISC-V" <qemu-riscv@nongnu.org>, =?UTF-8?Q?Daniel_P=2E_Berrang=C3=A9?= <berrange@redhat.com>, 
	Mark Burton <mark.burton@greensocs.com>, Edgar Iglesias <edgari@xilinx.com>, 
	Igor Mammedov <imammedo@redhat.com>
Content-Type: text/plain; charset="UTF-8"

On Thu, Sep 23, 2021 at 2:20 AM Damien Hedde <damien.hedde@greensocs.com> wrote:
>
> From: Mirela Grujic <mirela.grujic@greensocs.com>
>
> The command returns current machine initialization phase.
> From now on, the MachineInitPhase enum is generated from the
> QAPI schema.
>
> Signed-off-by: Mirela Grujic <mirela.grujic@greensocs.com>

Acked-by: Alistair Francis <alistair.francis@wdc.com>

Alistair

> ---
>  qapi/machine.json          | 56 ++++++++++++++++++++++++++++++++++++++
>  include/hw/qdev-core.h     | 30 ++------------------
>  hw/core/machine-qmp-cmds.c |  9 ++++++
>  hw/core/qdev.c             |  5 ++++
>  4 files changed, 72 insertions(+), 28 deletions(-)
>
> diff --git a/qapi/machine.json b/qapi/machine.json
> index 157712f006..969d37fb03 100644
> --- a/qapi/machine.json
> +++ b/qapi/machine.json
> @@ -1312,3 +1312,59 @@
>       '*cores': 'int',
>       '*threads': 'int',
>       '*maxcpus': 'int' } }
> +
> +##
> +# @MachineInitPhase:
> +#
> +# Enumeration of machine initialization phases.
> +#
> +# @no-machine: machine does not exist
> +#
> +# @machine-created: machine is created, but its accelerator is not
> +#
> +# @accel-created: accelerator is created, but the machine properties have not
> +#                 been validated and machine initialization is not done yet
> +#
> +# @initialized: machine is initialized, thus creating any embedded devices and
> +#               validating machine properties. Devices created at this time are
> +#               considered to be cold-plugged.
> +#
> +# @ready: QEMU is ready to start CPUs and devices created at this time are
> +#         considered to be hot-plugged. The monitor is not restricted to
> +#         "preconfig" commands.
> +#
> +# Since: 6.2
> +##
> +{ 'enum': 'MachineInitPhase',
> +  'data': [ 'no-machine', 'machine-created', 'accel-created', 'initialized',
> +            'ready' ] }
> +
> +##
> +# @MachineInitPhaseStatus:
> +#
> +# Information about machine initialization phase
> +#
> +# @phase: the machine initialization phase
> +#
> +# Since: 6.2
> +##
> +{ 'struct': 'MachineInitPhaseStatus',
> +  'data': { 'phase': 'MachineInitPhase' } }
> +
> +##
> +# @query-machine-phase:
> +#
> +# Return machine initialization phase
> +#
> +# Since: 6.2
> +#
> +# Returns: MachineInitPhaseStatus
> +#
> +# Example:
> +#
> +# -> { "execute": "query-machine-phase" }
> +# <- { "return": { "phase": "initialized" } }
> +#
> +##
> +{ 'command': 'query-machine-phase', 'returns': 'MachineInitPhaseStatus',
> +             'allow-preconfig': true }
> diff --git a/include/hw/qdev-core.h b/include/hw/qdev-core.h
> index 859fd913bb..800eda8f54 100644
> --- a/include/hw/qdev-core.h
> +++ b/include/hw/qdev-core.h
> @@ -1,6 +1,7 @@
>  #ifndef QDEV_CORE_H
>  #define QDEV_CORE_H
>
> +#include "qapi/qapi-types-machine.h"
>  #include "qemu/queue.h"
>  #include "qemu/bitmap.h"
>  #include "qemu/rcu.h"
> @@ -839,35 +840,8 @@ void device_listener_unregister(DeviceListener *listener);
>   */
>  bool qdev_should_hide_device(QemuOpts *opts);
>
> -typedef enum MachineInitPhase {
> -    /* current_machine is NULL.  */
> -    MACHINE_INIT_PHASE_NO_MACHINE,
> -
> -    /* current_machine is not NULL, but current_machine->accel is NULL.  */
> -    MACHINE_INIT_PHASE_MACHINE_CREATED,
> -
> -    /*
> -     * current_machine->accel is not NULL, but the machine properties have
> -     * not been validated and machine_class->init has not yet been called.
> -     */
> -    MACHINE_INIT_PHASE_ACCEL_CREATED,
> -
> -    /*
> -     * machine_class->init has been called, thus creating any embedded
> -     * devices and validating machine properties.  Devices created at
> -     * this time are considered to be cold-plugged.
> -     */
> -    MACHINE_INIT_PHASE_INITIALIZED,
> -
> -    /*
> -     * QEMU is ready to start CPUs and devices created at this time
> -     * are considered to be hot-plugged.  The monitor is not restricted
> -     * to "preconfig" commands.
> -     */
> -    MACHINE_INIT_PHASE_READY,
> -} MachineInitPhase;
> -
>  extern bool phase_check(MachineInitPhase phase);
>  extern void phase_advance(MachineInitPhase phase);
> +extern MachineInitPhase phase_get(void);
>
>  #endif
> diff --git a/hw/core/machine-qmp-cmds.c b/hw/core/machine-qmp-cmds.c
> index 52168a3771..d3b9a04855 100644
> --- a/hw/core/machine-qmp-cmds.c
> +++ b/hw/core/machine-qmp-cmds.c
> @@ -204,3 +204,12 @@ MemdevList *qmp_query_memdev(Error **errp)
>      object_child_foreach(obj, query_memdev, &list);
>      return list;
>  }
> +
> +MachineInitPhaseStatus *qmp_query_machine_phase(Error **errp)
> +{
> +    MachineInitPhaseStatus *status = g_malloc0(sizeof(*status));
> +
> +    status->phase = phase_get();
> +
> +    return status;
> +}
> diff --git a/hw/core/qdev.c b/hw/core/qdev.c
> index c5fc704f55..d83f1c029a 100644
> --- a/hw/core/qdev.c
> +++ b/hw/core/qdev.c
> @@ -1150,6 +1150,11 @@ void phase_advance(MachineInitPhase phase)
>      machine_phase = phase;
>  }
>
> +MachineInitPhase phase_get(void)
> +{
> +    return machine_phase;
> +}
> +
>  static const TypeInfo device_type_info = {
>      .name = TYPE_DEVICE,
>      .parent = TYPE_OBJECT,
> --
> 2.33.0
>
>


From xen-devel-bounces@lists.xenproject.org Tue Oct 12 22:17:02 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 22:17:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.207719.363620 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maQ4v-0004rv-Lv; Tue, 12 Oct 2021 22:16:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 207719.363620; Tue, 12 Oct 2021 22:16:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maQ4v-0004ro-ID; Tue, 12 Oct 2021 22:16:57 +0000
Received: by outflank-mailman (input) for mailman id 207719;
 Tue, 12 Oct 2021 22:16:55 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=quuu=PA=gmail.com=alistair23@srs-us1.protection.inumbo.net>)
 id 1maQ4t-0004ri-Pb
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 22:16:55 +0000
Received: from mail-il1-x130.google.com (unknown [2607:f8b0:4864:20::130])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id c90d86e1-578c-4872-ba9c-1eb57b31c0b7;
 Tue, 12 Oct 2021 22:16:54 +0000 (UTC)
Received: by mail-il1-x130.google.com with SMTP id w10so582321ilc.13
 for <xen-devel@lists.xenproject.org>; Tue, 12 Oct 2021 15:16:54 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c90d86e1-578c-4872-ba9c-1eb57b31c0b7
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=Y8u6sewFGmQKbqoBjnukgKcLj682SKmRME9UMPO/81M=;
        b=VYSVkTvcP+E9CsRNrYmxxDr6MLfsQD8gETS5VVB5I4OIVU9CGooSRhXF/x4hDtcJiT
         lqSjsig6RDb9tL/+pSskI46HDTv1zNoxjQcMm/ze1Gti7BuPM3Tn5/mgKpcaFpPtd9yL
         J43uJJT05sT1IO3xz/cSeRsieDSTPY6VyOWLwTZlu5Ad1IFDExzvLB4tNAP+AXLl9g4R
         SmBrj7XVWU/R1tmMhOLbsc56mrobQOix5Ff2c7Ny/N3WJ15WEO4CKtgwd7P4IfVdmyDa
         Kuo1zFwgXZI99kp/EumCKHY0gOx8jnC5WwapPlZXrNxgRLFsoeEZlETAFFAYZbL8nDqF
         H7dg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=Y8u6sewFGmQKbqoBjnukgKcLj682SKmRME9UMPO/81M=;
        b=Zj0mOVAD2j7vXwcj4aO40u+/W7J1X7SbFCjBRlpfPbrWt2/D67oEoSVafokCeX1/zj
         TlSblW4dvvm1MzU2tIvqwMPRzNio7tiCNJ/DA1Kwkusm4p1Xrus4Jo1PMbLcPpiAuaFd
         FIpfrdHtDqAqOt1D15PSTt0w5SOJ+mdBRk0NkUVZcz29du92fpjZGkAzVijsCV7iOitb
         SXInWg9uoxPMXMPO0h4jBteIht+TQ8CfxWXgapIlFuP9itpE6VYCHN7mY3/XlcM6YZxD
         sUl5IKe6tadeEV65uCbKSb0iSCuQvIhRObkFJphaR7eHn5hhVNCt6ZOxkEDRdM4YxJrU
         pCyA==
X-Gm-Message-State: AOAM5301SV4bi7hmsKCxgQu0+wpsoasj4RDaxWzVXC/r5dMYmG1xqI1p
	aBRcX5l0LjgvzJBzlp7M2MGjDEAMaVY6Ewhg3hk=
X-Google-Smtp-Source: ABdhPJz+pKBr8sJq+4PBGCrNMJ/2fChUgJjSegxseimlZl17yEiWjK8esp2u2bbu1fEv9gzbOOLOx0dCej2kJJyrcNo=
X-Received: by 2002:a05:6e02:1885:: with SMTP id o5mr4525636ilu.221.1634077013816;
 Tue, 12 Oct 2021 15:16:53 -0700 (PDT)
MIME-Version: 1.0
References: <20210922161405.140018-1-damien.hedde@greensocs.com>
In-Reply-To: <20210922161405.140018-1-damien.hedde@greensocs.com>
From: Alistair Francis <alistair23@gmail.com>
Date: Wed, 13 Oct 2021 08:16:27 +1000
Message-ID: <CAKmqyKMUvtRPCp=FJMHcMdsECfJ_fRHBi4dA2N3gtqmPHspNJA@mail.gmail.com>
Subject: Re: [RFC PATCH v2 00/16] Initial support for machine creation via QMP
To: Damien Hedde <damien.hedde@greensocs.com>
Cc: "qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>, Peter Maydell <peter.maydell@linaro.org>, 
	"Michael S. Tsirkin" <mst@redhat.com>, David Hildenbrand <david@redhat.com>, Peter Xu <peterx@redhat.com>, 
	mirela.grujic@greensocs.com, Alistair Francis <Alistair.Francis@wdc.com>, 
	Gerd Hoffmann <kraxel@redhat.com>, Ani Sinha <ani@anisinha.ca>, Eric Blake <eblake@redhat.com>, 
	Stefano Stabellini <sstabellini@kernel.org>, "open list:X86" <xen-devel@lists.xenproject.org>, 
	Paul Durrant <paul@xen.org>, Markus Armbruster <armbru@redhat.com>, 
	Anthony Perard <anthony.perard@citrix.com>, 
	=?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= <marcandre.lureau@redhat.com>, 
	Eduardo Habkost <ehabkost@redhat.com>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>, 
	Eric Auger <eric.auger@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, 
	"open list:RISC-V" <qemu-riscv@nongnu.org>, =?UTF-8?Q?Daniel_P=2E_Berrang=C3=A9?= <berrange@redhat.com>, 
	Mark Burton <mark.burton@greensocs.com>, Edgar Iglesias <edgari@xilinx.com>, 
	Igor Mammedov <imammedo@redhat.com>
Content-Type: text/plain; charset="UTF-8"

On Thu, Sep 23, 2021 at 2:22 AM Damien Hedde <damien.hedde@greensocs.com> wrote:
>
> Hi,
>
> The goal of this work is to bring dynamic machine creation to QEMU:
> we want to setup a machine without compiling a specific machine C
> code. It would ease supporting highly configurable platforms (for
> example resulting from an automated design flow). The requirements
> for such configuration include begin able to specify the number of
> cores, available peripherals, emmory mapping, IRQ mapping, etc.
>
> This series focuses on the first step: populating a machine with
> devices during its creation. We propose patches to support this
> using QMP commands. This is a working set of patches and improves
> over the earlier rfc (posted in May):
> https://lists.gnu.org/archive/html/qemu-devel/2021-05/msg03706.html
>
> Although it is working and could be merged, it is tag as an RFC:
> we probably need to discuss the conditions for allowing a device to
> be created at an early stage. Patches 6, 10 and 13, 15 and 16 depend
> on such conditions and are subject to change. Other patches are
> unrelated to this point.
>
> We address several issues in this series. They are detailed below.
>
> ## 1. Stoping QEMU to populate the machine with devices
>
> QEMU goes through several steps (called _machine phases_) when
> creating the machine: 'no-machine', 'machine-created',
> 'accel-created', 'initialized', and finally 'ready'. At 'ready'
> phase, QEMU is ready to start (see Paolo's page
> https://wiki.qemu.org/User:Paolo_Bonzini/Machine_init_sequence for
> more details).
>
> Using the -preconfig CLI option, QEMU can be stopped today during
> the 'accel-created' phase. Then the 'x-exit-preconfig' QMP command
> triggers QEMU moving forwards to the completion of the machine
> creation ('ready' phase).
>
> The devices are created during the 'initialized' phase.
> In this phase the machine init() method has been executed and thus
> machine properties have been handled. Although the sysbus exists and
> the machine may have been populated by the init(),
> _machine_init_done_ notifiers have not been called yet. At this point
> we can add more devices to a machine.
>
> We propose to add 2 QMP commands:
> + The 'query-machine-phase' command would return the current machine
>   phase.
> + The 'x-machine-init' command would advance the machine phase to
>   'initialized'. 'x-exit-preconfig' could then still be used to
>   advance to the last phase.
>
> ## 2. Adding devices
>
> Right now, the user can create devices in 2 ways: using '-device' CLI
> option or 'device_add' QMP command. Both are executed after the
> machine is ready: such devices are hot-plugged. We propose to allow
> 'device_add' QMP command to be used during the 'initialized' phase.
>
> In this series, we keep the constraint that the device must be
> 'user-creatable' (this is a device class flag). We do not see any
> reason why a device the user can hot-plug could not be created at an
> earlier stage.
>
> This part is still RFC because, as Peter mentioned it (in this thread
> https://lists.gnu.org/archive/html/qemu-devel/2021-08/msg01933.html),
> we may want additional or distinct conditions for:
> + device we can hot-plug
> + device we can add in '-preconfig' (cold-plug)
> We are open to suggestions. We could for example add a
> 'preconfig-creatable' or 'init-creatable' flag to device class, which
> can identify a set of devices we can create this way.
>
> The main addition is how we handle the case of sysbus devices. Sysbus
> devices are particular because unlike, for example, pci devices, you
> have to manually handle the memory mapping and interrupts wiring. So
> right now, a sysbus device is dynamically creatable (using -device
> CLI option or device_add QMP command) only if:
> + it is 'user_creatable' (like any other device),
> + and it is in the current machine sysbus device allow list.
>
> In this series, we propose to relax the second constraint during the
> earlier phases of machine creation so that when using -preconfig we
> can create any 'user-creatable' sysbus device. When the machine
> progresses to the 'ready' phase, sysbus devices creation will come
> back to the legacy behavior: it will be possible only based on the
> per-machine authorization basis.
>
> For sysbus devices, wiring interrupts is not a problem as we can use
> the 'qom-set' QMP command, but memory mapping is.
>
> ## 3. Memory mapping
>
> There is no point allowing the creation sysbus devices if we cannot
> map them onto the memory bus (the 'sysbus').
>
> As far as we know, right now, there is no way to add memory mapping
> for sysbus device using QMP commands. We propose a 'x-sysbus-mmio-map'
> command to do this. This command would only be allowed during the
> 'initialized' phase when using -preconfig.
>
> ## 4. Working example
>
> The last patches of the series add and modify devices in order to
> build a working machine starting from the 'none' machine.
>
> We add a new sysbus device modeling a simple memory (ram or rom). We
> also set 'user-creatable' flag of some sysbus devices. These are
> trivial patches, but they depends on the conditions we choose to allow
> creating devices with -preconfig. Therefore, there is really no need
> to review them until we settled on the device conditions first.
>
> With these devices (memory, ibex_uart, ibex_plic) we can dynamically
> configure a part (we did not add the timer, but we could) the
> opentitan machine very easily and run firmwares which demonstrates
> interrupts and memory-mapping are working.
>
> We use the existing qmp-shell script to issue machine devices
> from a qmp commands script file which contains qmp commands listed in
> a file.
>
> The following qmp commands add some memories, an interrupt controller
> and an uart with an interrupt.
>
> cat > opentitan.qmp <<EOF
> x-machine-init
>
> # ROM 0x00008000
> device_add        driver=sysbus-memory id=rom size=0x4000 readonly=true
> x-sysbus-mmio-map device=rom addr=32768
>
> # FLASH 0x20000000
> device_add        driver=sysbus-memory id=flash size=0x80000 readonly=true
> x-sysbus-mmio-map device=flash addr=536870912
>
> # RAM 0x10000000
> device_add        driver=sysbus-memory id=ram size=0x10000
> x-sysbus-mmio-map device=ram addr=268435456
>
> # PLIC 0x41010000
> device_add        driver=ibex-plic id=plic
> x-sysbus-mmio-map device=plic addr=1090584576
>
> # UART 0x40000000
> device_add        driver=ibex-uart id=uart chardev=serial0
> x-sysbus-mmio-map device=uart addr=1073741824
> qom-set path=uart property=sysbus-irq[1] value=plic/unnamed-gpio-in[2]
>
> x-exit-preconfig
> EOF
>
> We've put the opentitan.qmp and a firmware opentitan-echo.elf here
> (among some other qmp machine files we are working on):
> https://github.com/GreenSocs/qemu-qmp-machines

I am unable to access this repo, maybe it's not public?

Alistair


From xen-devel-bounces@lists.xenproject.org Tue Oct 12 22:19:49 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 22:19:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.207728.363631 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maQ7f-0005V7-40; Tue, 12 Oct 2021 22:19:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 207728.363631; Tue, 12 Oct 2021 22:19:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maQ7f-0005V0-19; Tue, 12 Oct 2021 22:19:47 +0000
Received: by outflank-mailman (input) for mailman id 207728;
 Tue, 12 Oct 2021 22:19:45 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=quuu=PA=gmail.com=alistair23@srs-us1.protection.inumbo.net>)
 id 1maQ7d-0005Uu-OB
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 22:19:45 +0000
Received: from mail-io1-xd30.google.com (unknown [2607:f8b0:4864:20::d30])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 2e596a25-4093-4d8c-9817-bdd7f4f8ebb9;
 Tue, 12 Oct 2021 22:19:44 +0000 (UTC)
Received: by mail-io1-xd30.google.com with SMTP id n7so657508iod.0
 for <xen-devel@lists.xenproject.org>; Tue, 12 Oct 2021 15:19:44 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2e596a25-4093-4d8c-9817-bdd7f4f8ebb9
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=NB4zMWjVCozDyRqrRazsv7gECHlthWA9j/5E69e+2pE=;
        b=O3E8Na1Lu/kg9q1317gF82pOCZSAMuuoHn9gufZyGxGSmsbzzQuMOVwF55Mu1iLW6V
         PCF0bB5+i5baqpeBi4h/xhHYwcXBogMplyx2nUX6DUEsErcrra5z1EPRUgOElfsH0lg1
         I/BwklgzMNPayXfCFl9iwhqVifSnxzvdpvzXqwQ4HCx7BjgzeqJxBhXOEohGI1rwykZn
         lXUiMVocjsfQYqnLJkmu3QYInXK597Co5vY7nIGVpvZYghsGhXTZ1jdQ+cXWePtVTJ0Q
         NYIARl/MQFTZ5C41TQ8TdOW5Yx6HYV1q29+D6fM3fBxt5E8SYSDrI2cfXDSrUcWLSG0P
         rjPQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=NB4zMWjVCozDyRqrRazsv7gECHlthWA9j/5E69e+2pE=;
        b=l99PAKeRI+r4+HVdEJaK1nWVE9JmwSc4u8DM6mJu66QrT+YAua8EMu8FJf5cnsGm7h
         uyD4RoqsQyiRN2yDyb2ngNB+Gn2A8hTMJkMM6p/XbB8IIqj+jSIcEL9tr8sE/LNuqaTf
         LvheVbxGacBPNm9P92RqkydjuyOm/t8Kycg281Ms+9DR3B+wTSpu2RwssDA//rAhyWoP
         OY9NxI+Lcoz2et5YTuGtcRhVjVIwg7VkkH7iGDPmb8w0YQTR32OqcGpY3g6r7tmv8KpC
         xoWbjvgNTb0eUm9z7uTZ1uz7+7u3C3j/ijWygv9kIRUirCBgTOv0YJxG3KyJNz51bVxs
         /sUw==
X-Gm-Message-State: AOAM5321qCA1qZFw/0POEj36nZyE28YhgQwa53ALZCSSvmBaMu+aub8R
	xhMIb+F7TyzN4AmuCV1iQbLJ70QSFaOiAF493L8=
X-Google-Smtp-Source: ABdhPJyUAmYSRqyUMQkR2DPCTv/LEqWVUb7bWjDgrZMQ35aO1plLf4xcvTA3zyySB7lWt4luca1J9q2NsICNzsModDE=
X-Received: by 2002:a6b:8d4a:: with SMTP id p71mr25921383iod.16.1634077184387;
 Tue, 12 Oct 2021 15:19:44 -0700 (PDT)
MIME-Version: 1.0
References: <20210922161405.140018-1-damien.hedde@greensocs.com> <20210922161405.140018-4-damien.hedde@greensocs.com>
In-Reply-To: <20210922161405.140018-4-damien.hedde@greensocs.com>
From: Alistair Francis <alistair23@gmail.com>
Date: Wed, 13 Oct 2021 08:19:18 +1000
Message-ID: <CAKmqyKP-Na8=6cyL8kLNwkr8Hcb2cDgVYYqDrqO_g=tcqkO96A@mail.gmail.com>
Subject: Re: [RFC PATCH v2 03/16] qapi: Implement x-machine-init QMP command
To: Damien Hedde <damien.hedde@greensocs.com>
Cc: "qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>, Peter Maydell <peter.maydell@linaro.org>, 
	"Michael S. Tsirkin" <mst@redhat.com>, David Hildenbrand <david@redhat.com>, Peter Xu <peterx@redhat.com>, 
	mirela.grujic@greensocs.com, Alistair Francis <Alistair.Francis@wdc.com>, 
	Gerd Hoffmann <kraxel@redhat.com>, Ani Sinha <ani@anisinha.ca>, Eric Blake <eblake@redhat.com>, 
	Stefano Stabellini <sstabellini@kernel.org>, "open list:X86" <xen-devel@lists.xenproject.org>, 
	Paul Durrant <paul@xen.org>, Markus Armbruster <armbru@redhat.com>, 
	Anthony Perard <anthony.perard@citrix.com>, 
	=?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= <marcandre.lureau@redhat.com>, 
	Eduardo Habkost <ehabkost@redhat.com>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>, 
	Eric Auger <eric.auger@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, 
	"open list:RISC-V" <qemu-riscv@nongnu.org>, =?UTF-8?Q?Daniel_P=2E_Berrang=C3=A9?= <berrange@redhat.com>, 
	Mark Burton <mark.burton@greensocs.com>, Edgar Iglesias <edgari@xilinx.com>, 
	Igor Mammedov <imammedo@redhat.com>
Content-Type: text/plain; charset="UTF-8"

On Thu, Sep 23, 2021 at 2:17 AM Damien Hedde <damien.hedde@greensocs.com> wrote:
>
> From: Mirela Grujic <mirela.grujic@greensocs.com>
>
> The x-machine-init QMP command is available only if the -preconfig option
> is used and the current machine initialization phase is accel-created.
>
> The command triggers QEMU to enter machine initialized phase and wait
> for the QMP configuration. In future commits, we will add the possiblity
> to create devices at this point.
>
> To exit the initialized phase use the x-exit-preconfig QMP command.
>
> Signed-off-by: Mirela Grujic <mirela.grujic@greensocs.com>

Acked-by: Alistair Francis <alistair.francis@wdc.com>

Alistair

> ---
>  qapi/machine.json | 23 +++++++++++++++++++++++
>  softmmu/vl.c      | 19 +++++++++++++++----
>  2 files changed, 38 insertions(+), 4 deletions(-)
>
> diff --git a/qapi/machine.json b/qapi/machine.json
> index 969d37fb03..56330c0e8e 100644
> --- a/qapi/machine.json
> +++ b/qapi/machine.json
> @@ -1368,3 +1368,26 @@
>  ##
>  { 'command': 'query-machine-phase', 'returns': 'MachineInitPhaseStatus',
>               'allow-preconfig': true }
> +
> +##
> +# @x-machine-init:
> +#
> +# Enter machine initialized phase
> +#
> +# Since: 6.2
> +#
> +# Returns: If successful, nothing
> +#
> +# Notes: This command will trigger QEMU to execute initialization steps
> +#        that are required to enter the machine initialized phase. The command
> +#        is available only if the -preconfig command line option was passed and
> +#        if the machine is currently in the accel-created phase. To exit the
> +#        machine initialized phase use the x-exit-preconfig command.
> +#
> +# Example:
> +#
> +# -> { "execute": "x-machine-init" }
> +# <- { "return": {} }
> +#
> +##
> +{ 'command': 'x-machine-init', 'allow-preconfig': true }
> diff --git a/softmmu/vl.c b/softmmu/vl.c
> index d2552ba8ac..84c5132ad7 100644
> --- a/softmmu/vl.c
> +++ b/softmmu/vl.c
> @@ -123,6 +123,7 @@
>  #include "qapi/qapi-visit-qom.h"
>  #include "qapi/qapi-commands-ui.h"
>  #include "qapi/qmp/qdict.h"
> +#include "qapi/qapi-commands-machine.h"
>  #include "qapi/qmp/qerror.h"
>  #include "sysemu/iothread.h"
>  #include "qemu/guest-random.h"
> @@ -2610,10 +2611,16 @@ static void qemu_init_displays(void)
>      }
>  }
>
> -static void qemu_init_board(void)
> +void qmp_x_machine_init(Error **errp)
>  {
>      MachineClass *machine_class = MACHINE_GET_CLASS(current_machine);
>
> +    if (phase_check(MACHINE_INIT_PHASE_INITIALIZED)) {
> +        error_setg(errp, "The command is permitted only before "
> +                         "the machine is initialized");
> +        return;
> +    }
> +
>      if (machine_class->default_ram_id && current_machine->ram_size &&
>          numa_uses_legacy_mem() && !current_machine->ram_memdev_id) {
>          create_default_memdev(current_machine, mem_path);
> @@ -2692,12 +2699,16 @@ static void qemu_machine_creation_done(void)
>
>  void qmp_x_exit_preconfig(Error **errp)
>  {
> -    if (phase_check(MACHINE_INIT_PHASE_INITIALIZED)) {
> -        error_setg(errp, "The command is permitted only before machine initialization");
> +    if (phase_check(MACHINE_INIT_PHASE_READY)) {
> +        error_setg(errp, "The command is permitted only before "
> +                         "the machine is ready");
>          return;
>      }
>
> -    qemu_init_board();
> +    if (!phase_check(MACHINE_INIT_PHASE_INITIALIZED)) {
> +        qmp_x_machine_init(errp);
> +    }
> +
>      qemu_create_cli_devices();
>      qemu_machine_creation_done();
>
> --
> 2.33.0
>
>


From xen-devel-bounces@lists.xenproject.org Tue Oct 12 22:25:35 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 22:25:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.207740.363642 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maQDC-0006yq-St; Tue, 12 Oct 2021 22:25:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 207740.363642; Tue, 12 Oct 2021 22:25:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maQDC-0006yj-Ph; Tue, 12 Oct 2021 22:25:30 +0000
Received: by outflank-mailman (input) for mailman id 207740;
 Tue, 12 Oct 2021 22:25:30 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=quuu=PA=gmail.com=alistair23@srs-us1.protection.inumbo.net>)
 id 1maQDC-0006yd-22
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 22:25:30 +0000
Received: from mail-io1-xd33.google.com (unknown [2607:f8b0:4864:20::d33])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id a8ad821f-d38a-46ac-a8b8-c0467bcde297;
 Tue, 12 Oct 2021 22:25:29 +0000 (UTC)
Received: by mail-io1-xd33.google.com with SMTP id d125so607041iof.5
 for <xen-devel@lists.xenproject.org>; Tue, 12 Oct 2021 15:25:29 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a8ad821f-d38a-46ac-a8b8-c0467bcde297
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=XmXWcURKTPZbu8+vMykz0wo7aGuZpEedRj7aUcQW/64=;
        b=jXP0Q6BYUaRM1g/D3kGRJaogyDNoXsMFf191OtG8ORGfqlH0QuWlkt3HNBo9PJfjF4
         q2ALCcfrBgKjp5dmcOASInobV+9gI7eBewus6GQw3nWBj5c5zdAczLbIF9ag2oRnY3k3
         RlycwIS2PzEhnccX5VbLXkAHUOYdM3dNG2A8HiuqAZvd5DF+0cKddahq4bvJmfro3a/W
         ppTNvUpJ4NQ9CFScQXQZYKdytzv9whHQwpayRU2mny766/62FwzY+XmJ1E49HBjU64m2
         AiEhm+27VgvQ2twDTfkqlPacg+dTyANr6ImfQGjoEIINDrbsXKJPJs9Qjj3pB+KyBmf/
         V3Pg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=XmXWcURKTPZbu8+vMykz0wo7aGuZpEedRj7aUcQW/64=;
        b=iilpMPvQexeqcpW3wWnJySMO/W0sx5uo/NuRg1+i49qOlPijmmG7JwTT4yHKf25qwe
         4EJlrnUXM1HNBmnSXOlG4UVZ1RUiR6kbWP8/E2SMUG5w/B4HE8BOqkReif5nA31FGaDb
         r+uAjVZ8g5KDr7XuUt/NVl8aVNAyvo0dBkRwpV4u92zous8zIzcIXW6Lt/t2V1KeTUoF
         cpFbCU/emw6LqXJdHlRpK9OsuaNN9JnbUlPRjg9LL4Wu+2uG6/ICaClimrovjJu7hyqc
         LZMGcVN7DmJH2z3CFj4u3zZE0D3ZP5oBla9l7Xhvl/t+YVQGnmDDjTzA4IySzhW4lsWO
         Qfwg==
X-Gm-Message-State: AOAM532tjtlwq1LBOmS9RSo7B7SyaPUnwgWlcX149nRJJCBa9LePYcVl
	pMVagl5CqL7Y9X5dxZMbArkycZ/5ted8mkhklIQ=
X-Google-Smtp-Source: ABdhPJwY/7LCnJc4zrqz9k9AXZF5iV8jUexLQGaXC27y6KYjx+BhCMwCI+QO/p2VwL5gS3+DRS/txPkgBlsx8+654+g=
X-Received: by 2002:a05:6638:1483:: with SMTP id j3mr24996253jak.63.1634077528483;
 Tue, 12 Oct 2021 15:25:28 -0700 (PDT)
MIME-Version: 1.0
References: <20210922161405.140018-1-damien.hedde@greensocs.com> <20210922161405.140018-7-damien.hedde@greensocs.com>
In-Reply-To: <20210922161405.140018-7-damien.hedde@greensocs.com>
From: Alistair Francis <alistair23@gmail.com>
Date: Wed, 13 Oct 2021 08:25:02 +1000
Message-ID: <CAKmqyKNuOppuy2i=dF7SD0pZ0u_Us5J0CRGe8CJ-Zay-KMFBRA@mail.gmail.com>
Subject: Re: [RFC PATCH v2 06/16] qapi: Allow device_add to execute in machine
 initialized phase
To: Damien Hedde <damien.hedde@greensocs.com>
Cc: "qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>, Peter Maydell <peter.maydell@linaro.org>, 
	"Michael S. Tsirkin" <mst@redhat.com>, David Hildenbrand <david@redhat.com>, Peter Xu <peterx@redhat.com>, 
	mirela.grujic@greensocs.com, Alistair Francis <Alistair.Francis@wdc.com>, 
	Gerd Hoffmann <kraxel@redhat.com>, Ani Sinha <ani@anisinha.ca>, Eric Blake <eblake@redhat.com>, 
	Stefano Stabellini <sstabellini@kernel.org>, "open list:X86" <xen-devel@lists.xenproject.org>, 
	Paul Durrant <paul@xen.org>, Markus Armbruster <armbru@redhat.com>, 
	Anthony Perard <anthony.perard@citrix.com>, 
	=?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= <marcandre.lureau@redhat.com>, 
	Eduardo Habkost <ehabkost@redhat.com>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>, 
	Eric Auger <eric.auger@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, 
	"open list:RISC-V" <qemu-riscv@nongnu.org>, =?UTF-8?Q?Daniel_P=2E_Berrang=C3=A9?= <berrange@redhat.com>, 
	Mark Burton <mark.burton@greensocs.com>, Edgar Iglesias <edgari@xilinx.com>, 
	Igor Mammedov <imammedo@redhat.com>
Content-Type: text/plain; charset="UTF-8"

On Thu, Sep 23, 2021 at 2:26 AM Damien Hedde <damien.hedde@greensocs.com> wrote:
>
> From: Mirela Grujic <mirela.grujic@greensocs.com>
>
> To configure a machine using QMP we need the device_add command to
> execute at machine initialized phase.
>
> Note: for device_add command in qdev.json adding the 'allow-init-config'
> option has no effect because the command appears to bypass QAPI (see
> TODO at qapi/qdev.json:61). The option is added there solely to document
> the intent.
> For the same reason, the flags have to be explicitly set in
> monitor_init_qmp_commands() when the device_add command is registered.
>
> Signed-off-by: Mirela Grujic <mirela.grujic@greensocs.com>

Acked-by: Alistair Francis <alistair.francis@wdc.com>

Alistair

> ---
>
> The commit is fine, but we may add intermediate commits before this one
> in order to add or change the condition for a device type to be accepted
> in the 'initialized' state (see the cover-letter of the series).
> ---
>  qapi/qdev.json         | 3 ++-
>  monitor/misc.c         | 2 +-
>  softmmu/qdev-monitor.c | 6 ++++++
>  3 files changed, 9 insertions(+), 2 deletions(-)
>
> diff --git a/qapi/qdev.json b/qapi/qdev.json
> index b83178220b..ad669ae175 100644
> --- a/qapi/qdev.json
> +++ b/qapi/qdev.json
> @@ -67,7 +67,8 @@
>  ##
>  { 'command': 'device_add',
>    'data': {'driver': 'str', '*bus': 'str', '*id': 'str'},
> -  'gen': false } # so we can get the additional arguments
> +  'gen': false, # so we can get the additional arguments
> +  'allow-preconfig': true }
>
>  ##
>  # @device_del:
> diff --git a/monitor/misc.c b/monitor/misc.c
> index ffe7966870..2c476de316 100644
> --- a/monitor/misc.c
> +++ b/monitor/misc.c
> @@ -231,7 +231,7 @@ static void monitor_init_qmp_commands(void)
>      qmp_init_marshal(&qmp_commands);
>
>      qmp_register_command(&qmp_commands, "device_add", qmp_device_add,
> -                         QCO_NO_OPTIONS);
> +                         QCO_ALLOW_PRECONFIG);
>
>      QTAILQ_INIT(&qmp_cap_negotiation_commands);
>      qmp_register_command(&qmp_cap_negotiation_commands, "qmp_capabilities",
> diff --git a/softmmu/qdev-monitor.c b/softmmu/qdev-monitor.c
> index 834f2b56b5..47ccd90be8 100644
> --- a/softmmu/qdev-monitor.c
> +++ b/softmmu/qdev-monitor.c
> @@ -824,6 +824,12 @@ void qmp_device_add(QDict *qdict, QObject **ret_data, Error **errp)
>      QemuOpts *opts;
>      DeviceState *dev;
>
> +    if (!phase_check(MACHINE_INIT_PHASE_INITIALIZED)) {
> +        error_setg(errp, "The command is permitted only after "
> +                         "the machine is initialized");
> +        return;
> +    }
> +
>      opts = qemu_opts_from_qdict(qemu_find_opts("device"), qdict, errp);
>      if (!opts) {
>          return;
> --
> 2.33.0
>
>


From xen-devel-bounces@lists.xenproject.org Tue Oct 12 22:42:41 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 22:42:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.207749.363653 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maQTk-0000nk-6F; Tue, 12 Oct 2021 22:42:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 207749.363653; Tue, 12 Oct 2021 22:42:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maQTk-0000nd-2X; Tue, 12 Oct 2021 22:42:36 +0000
Received: by outflank-mailman (input) for mailman id 207749;
 Tue, 12 Oct 2021 22:42:34 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=quuu=PA=gmail.com=alistair23@srs-us1.protection.inumbo.net>)
 id 1maQTi-0000nX-DC
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 22:42:34 +0000
Received: from mail-io1-xd36.google.com (unknown [2607:f8b0:4864:20::d36])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id e5e37a6c-f23e-473d-a286-5ee9075092f5;
 Tue, 12 Oct 2021 22:42:33 +0000 (UTC)
Received: by mail-io1-xd36.google.com with SMTP id h196so656029iof.2
 for <xen-devel@lists.xenproject.org>; Tue, 12 Oct 2021 15:42:33 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e5e37a6c-f23e-473d-a286-5ee9075092f5
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=BRtEZaYJhOVpcGkgSpDYO/ypCHhDFLv2oKEs05gHoQc=;
        b=RCmgtzTgUEy+a7cJIc45CsMuD1If47Q9oDktbDKJqDqob74BYDXx4KVSyodWOMNDc7
         yYX4tIpeHcPvsUuder/+zgIGQPiv2kz+6nVZRYdAYI+f+tX5biFbDHu11M4vk5LqXiwt
         npKmeFTFlZzupoR+HSPmF8KIzAwGCSxYxGZld2ils+snabL5hh1YTfxQUc5eUyQwkrGi
         uFX5DHtCcqD299HLuhwDdyakhUgCziha8wj7edCopTlkkuIwh1iR+Up+Umwh4tlh8Yeu
         I70rd0fJ9IDd9riwFOIWtuAsQH4N04junuNk5mByMDAEskva2JRiVDTYEdVavubU1thB
         Ph9g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=BRtEZaYJhOVpcGkgSpDYO/ypCHhDFLv2oKEs05gHoQc=;
        b=SMuDjSsJrJB/hBybzhh2Hh2d4MEx152f+pb+P27egz+J9GlPhJ4HJAP2IHFCkUqTuP
         INUFsGSNMrYaiHTGgOxsmQsyF6BhDkPSVtCclDryZmlXkn7GFWB7SSnP3GRBHXquADmJ
         rs52VBnzCcO87esKPpUhzsyweyhP0JQkY8y1jmuG9mNzOFFcM78tAZKXnLQVtz76tDdV
         6WJHT67Q1L2/P7AEeF+Qe67gR/Db/3fHyOTCd97sZVbQLLaOdI5pGmsTUPOJO0rKg+iQ
         qGhucaSrk2VQaOtrg/D4GfPq/eH1wrVzBHrLRp/niCyZyK8FJxt+IZXIPpWlKky0csEi
         auPw==
X-Gm-Message-State: AOAM530+peOjFkppEb/0JHSzGduSViv/zEE5tr6OfFhmAvxIkhikwNhn
	TG0r7ysxa6SGN3gmOhS1t/KOTFk4xQhN7BppN70=
X-Google-Smtp-Source: ABdhPJyHZZiQyHCZV1hTTNLscSJMvVXjFaVEx8O6Ga1hxEzvHQyK8S4Y9MOxSN1G9r8u/cHpghuMkGCzgDoK3US2XHQ=
X-Received: by 2002:a05:6638:1483:: with SMTP id j3mr25041031jak.63.1634078553331;
 Tue, 12 Oct 2021 15:42:33 -0700 (PDT)
MIME-Version: 1.0
References: <20210922161405.140018-1-damien.hedde@greensocs.com> <20210922161405.140018-9-damien.hedde@greensocs.com>
In-Reply-To: <20210922161405.140018-9-damien.hedde@greensocs.com>
From: Alistair Francis <alistair23@gmail.com>
Date: Wed, 13 Oct 2021 08:42:07 +1000
Message-ID: <CAKmqyKMZFFNLLfBRUAe6Dg7U6BDX9zKJyWue_zQsSLrBbH56OA@mail.gmail.com>
Subject: Re: [RFC PATCH v2 08/16] qdev-monitor: Check sysbus device type
 before creating it
To: Damien Hedde <damien.hedde@greensocs.com>
Cc: "qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>, Peter Maydell <peter.maydell@linaro.org>, 
	"Michael S. Tsirkin" <mst@redhat.com>, David Hildenbrand <david@redhat.com>, Peter Xu <peterx@redhat.com>, 
	mirela.grujic@greensocs.com, Alistair Francis <Alistair.Francis@wdc.com>, 
	Gerd Hoffmann <kraxel@redhat.com>, Ani Sinha <ani@anisinha.ca>, Eric Blake <eblake@redhat.com>, 
	Stefano Stabellini <sstabellini@kernel.org>, "open list:X86" <xen-devel@lists.xenproject.org>, 
	Paul Durrant <paul@xen.org>, Markus Armbruster <armbru@redhat.com>, 
	Anthony Perard <anthony.perard@citrix.com>, 
	=?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= <marcandre.lureau@redhat.com>, 
	Eduardo Habkost <ehabkost@redhat.com>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>, 
	Eric Auger <eric.auger@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, 
	"open list:RISC-V" <qemu-riscv@nongnu.org>, =?UTF-8?Q?Daniel_P=2E_Berrang=C3=A9?= <berrange@redhat.com>, 
	Mark Burton <mark.burton@greensocs.com>, Edgar Iglesias <edgari@xilinx.com>, 
	Igor Mammedov <imammedo@redhat.com>
Content-Type: text/plain; charset="UTF-8"

On Thu, Sep 23, 2021 at 2:53 AM Damien Hedde <damien.hedde@greensocs.com> wrote:
>
> Add an early check to test if the requested sysbus device type
> is allowed by the current machine before creating the device. This
> impacts both -device cli option and device_add qmp command.
>
> Before this patch, the check was done well after the device has
> been created (in a machine init done notifier). We can now report
> the error right away.
>
> Signed-off-by: Damien Hedde <damien.hedde@greensocs.com>

Reviewed-by: Alistair Francis <alistair.francis@wdc.com>

Alistair

> ---
>  softmmu/qdev-monitor.c | 11 +++++++++++
>  1 file changed, 11 insertions(+)
>
> diff --git a/softmmu/qdev-monitor.c b/softmmu/qdev-monitor.c
> index 47ccd90be8..f1c9242855 100644
> --- a/softmmu/qdev-monitor.c
> +++ b/softmmu/qdev-monitor.c
> @@ -40,6 +40,7 @@
>  #include "qemu/cutils.h"
>  #include "hw/qdev-properties.h"
>  #include "hw/clock.h"
> +#include "hw/boards.h"
>
>  /*
>   * Aliases were a bad idea from the start.  Let's keep them
> @@ -268,6 +269,16 @@ static DeviceClass *qdev_get_device_class(const char **driver, Error **errp)
>          return NULL;
>      }
>
> +    if (object_class_dynamic_cast(oc, TYPE_SYS_BUS_DEVICE)) {
> +        /* sysbus devices need to be allowed by the machine */
> +        MachineClass *mc = MACHINE_CLASS(object_get_class(qdev_get_machine()));
> +        if (!machine_class_is_dynamic_sysbus_dev_allowed(mc, *driver)) {
> +            error_setg(errp, "'%s' is not an allowed pluggable sysbus device "
> +                             " type for the machine", *driver);
> +            return NULL;
> +        }
> +    }
> +
>      return dc;
>  }
>
> --
> 2.33.0
>
>


From xen-devel-bounces@lists.xenproject.org Tue Oct 12 22:43:29 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 22:43:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.207755.363664 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maQUa-0001MQ-Ge; Tue, 12 Oct 2021 22:43:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 207755.363664; Tue, 12 Oct 2021 22:43:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maQUa-0001MJ-Br; Tue, 12 Oct 2021 22:43:28 +0000
Received: by outflank-mailman (input) for mailman id 207755;
 Tue, 12 Oct 2021 22:43:26 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1maQUY-0001M3-Sc; Tue, 12 Oct 2021 22:43:26 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1maQUY-0003XF-I3; Tue, 12 Oct 2021 22:43:26 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1maQUY-0006xe-Am; Tue, 12 Oct 2021 22:43:26 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1maQUY-0002M4-AI; Tue, 12 Oct 2021 22:43:26 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=wRkXenp6BXiXoZ5Eh1FpvTo3xh3oxBnXmEv1OM2RYic=; b=TlSmIgVNJ4ZvGkwhkmyZ8FDRD1
	1gjuBSUhtpbAG2PiU5YFU+Ex+Z1xXlbaa/hphMbJ6+r0XO3V8px6eQ/XpnFuThnFg3xwuu/kHZ65F
	Ngb+WQIi5D8ENZhO7ltE0+a3S9VdZ1LoVSvdiOPgnuFxgJt9E4FKwqiN09vE1UFluPeg=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165482-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 165482: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=eb7518b89be6df874ec9b2bafadeaaa7c874ea6b
X-Osstest-Versions-That:
    xen=2faeb4213d9b412836fe80e5685bfcccc51feb92
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 12 Oct 2021 22:43:26 +0000

flight 165482 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165482/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  eb7518b89be6df874ec9b2bafadeaaa7c874ea6b
baseline version:
 xen                  2faeb4213d9b412836fe80e5685bfcccc51feb92

Last test of basis   165479  2021-10-12 14:00:26 Z    0 days
Testing same since   165482  2021-10-12 19:02:46 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   2faeb4213d..eb7518b89b  eb7518b89be6df874ec9b2bafadeaaa7c874ea6b -> smoke


From xen-devel-bounces@lists.xenproject.org Tue Oct 12 23:08:17 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 23:08:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.207767.363677 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maQsP-0003oI-Ex; Tue, 12 Oct 2021 23:08:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 207767.363677; Tue, 12 Oct 2021 23:08:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maQsP-0003oB-BV; Tue, 12 Oct 2021 23:08:05 +0000
Received: by outflank-mailman (input) for mailman id 207767;
 Tue, 12 Oct 2021 23:08:04 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=quuu=PA=gmail.com=alistair23@srs-us1.protection.inumbo.net>)
 id 1maQsO-0003o5-Qi
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 23:08:04 +0000
Received: from mail-io1-xd2d.google.com (unknown [2607:f8b0:4864:20::d2d])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 3303686c-96ed-483c-8441-e169d5e2b41b;
 Tue, 12 Oct 2021 23:08:03 +0000 (UTC)
Received: by mail-io1-xd2d.google.com with SMTP id i189so717168ioa.1
 for <xen-devel@lists.xenproject.org>; Tue, 12 Oct 2021 16:08:03 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3303686c-96ed-483c-8441-e169d5e2b41b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=D23sb8bFeCXI94xUkUzdKmg69G7zDAbwqduFczWfvKA=;
        b=Es3UE5dss4rZylCN7k44ApvHlCaGU4yXyfFXVgiwjK++fiVIj2AKyYlhX4iAoXUJOm
         CtSsoA4ibc2vMn9zCCRDTEOys3irqDNERLbvfsl8FtIskFvMfYPIxDmhYNrSBO6XV0hi
         FOvfleplF/JVnW1XO/X1GH23yuGwJN5Td7ReeJ5nhPGgxCrQwYOAJfV9mWo/s7aGoAHx
         hgwBiim7ZtjYHhe8Upjehw7vm9f6ONaDVoNk8y1ytrp2plFJEBsprIw21sUuNsYSYnwc
         B/NTXWA9gpi42gCU9Q//B3uCy6IkbzHo6gsWN7PflOKs4cmdY6C+GuFuof6yViEAJVIw
         0jpw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=D23sb8bFeCXI94xUkUzdKmg69G7zDAbwqduFczWfvKA=;
        b=PI6EXbWl1aAla2DouH81zCUw5PWGHXZPhsKLxK+5nwIiOXOnZrdDe68JZSY356KNNb
         0Qp+ivnMY1n7+0bBIH+wINzdxa6VjfZ307k3K7SGxVHGn3udOjO6a4l+QhssTWez+ZYY
         MXKepIjmBeHv3cCOqLdlB56CNwmMc6neKPFQQ6xun62rBgw2NToG5VvRMuGnbh7zdE1a
         sN25akHKAG1d9cOBBlcfKKe1SBRAsUiHyMEO6O7BP9fL+/PgRBAo/SpbYLOHa5CfKOo4
         a4GWHydU+UKk2W7c2uE19KefYoV3k5J2bxVR4HrKf2KlD3dTo6ygiyLyp7HFqHwzduDy
         vqkw==
X-Gm-Message-State: AOAM532zU5X0Ir78QYv+WmXlg8NCLOnJ91vrRYGSDYftzgOs4mMqySqR
	DK7BEoo+xzDfFIwnsIT9cWjgL4i2MnVq9zOQn0Y=
X-Google-Smtp-Source: ABdhPJxDPo9qtToO6ewaPjuNrBsi+QXGD1yiMTi37OJGplkSUxNlRnlVrO+pWqYJmSF5JUPbJAj3fBICmq3UUqxD/5U=
X-Received: by 2002:a05:6638:1483:: with SMTP id j3mr25110746jak.63.1634080083372;
 Tue, 12 Oct 2021 16:08:03 -0700 (PDT)
MIME-Version: 1.0
References: <20210922161405.140018-1-damien.hedde@greensocs.com> <20210922161405.140018-10-damien.hedde@greensocs.com>
In-Reply-To: <20210922161405.140018-10-damien.hedde@greensocs.com>
From: Alistair Francis <alistair23@gmail.com>
Date: Wed, 13 Oct 2021 09:07:37 +1000
Message-ID: <CAKmqyKNeUz7BTxhJTKnhTnEnONRJLJ8V-CaCZ3E5OA2G8eeP4A@mail.gmail.com>
Subject: Re: [RFC PATCH v2 09/16] hw/core/machine: Remove the dynamic sysbus
 devices type check
To: Damien Hedde <damien.hedde@greensocs.com>
Cc: "qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>, Peter Maydell <peter.maydell@linaro.org>, 
	"Michael S. Tsirkin" <mst@redhat.com>, David Hildenbrand <david@redhat.com>, Peter Xu <peterx@redhat.com>, 
	mirela.grujic@greensocs.com, Alistair Francis <Alistair.Francis@wdc.com>, 
	Gerd Hoffmann <kraxel@redhat.com>, Ani Sinha <ani@anisinha.ca>, Eric Blake <eblake@redhat.com>, 
	Stefano Stabellini <sstabellini@kernel.org>, "open list:X86" <xen-devel@lists.xenproject.org>, 
	Paul Durrant <paul@xen.org>, Markus Armbruster <armbru@redhat.com>, 
	Anthony Perard <anthony.perard@citrix.com>, 
	=?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= <marcandre.lureau@redhat.com>, 
	Eduardo Habkost <ehabkost@redhat.com>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>, 
	Eric Auger <eric.auger@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, 
	"open list:RISC-V" <qemu-riscv@nongnu.org>, =?UTF-8?Q?Daniel_P=2E_Berrang=C3=A9?= <berrange@redhat.com>, 
	Mark Burton <mark.burton@greensocs.com>, Edgar Iglesias <edgari@xilinx.com>, 
	Igor Mammedov <imammedo@redhat.com>
Content-Type: text/plain; charset="UTF-8"

On Thu, Sep 23, 2021 at 2:23 AM Damien Hedde <damien.hedde@greensocs.com> wrote:
>
> Now that we check sysbus device types during device creation, we
> can remove the check done in the machine init done notifier.
> This was the only thing done by this notifier, so we remove the
> whole sysbus_notifier structure of the MachineState.
>
> Note: This notifier was checking all /peripheral and /peripheral-anon
> sysbus devices. Now we only check those added by -device cli option or
> device_add qmp command when handling the command/option. So if there
> are some devices added in one of these containers manually (eg in
> machine C code), these will not be checked anymore.
> This use case does not seem to appear apart from
> hw/xen/xen-legacy-backend.c (it uses qdev_set_id() and in this case,
> not for a sysbus device, so it's ok).
>
> Signed-off-by: Damien Hedde <damien.hedde@greensocs.com>

Acked-by: Alistair Francis <alistair.francis@wdc.com>

Alistair

> ---
>  include/hw/boards.h |  1 -
>  hw/core/machine.c   | 27 ---------------------------
>  2 files changed, 28 deletions(-)
>
> diff --git a/include/hw/boards.h b/include/hw/boards.h
> index 934443c1cd..ccbc40355a 100644
> --- a/include/hw/boards.h
> +++ b/include/hw/boards.h
> @@ -311,7 +311,6 @@ typedef struct CpuTopology {
>  struct MachineState {
>      /*< private >*/
>      Object parent_obj;
> -    Notifier sysbus_notifier;
>
>      /*< public >*/
>
> diff --git a/hw/core/machine.c b/hw/core/machine.c
> index 1a18912dc8..521438e90a 100644
> --- a/hw/core/machine.c
> +++ b/hw/core/machine.c
> @@ -571,18 +571,6 @@ bool machine_class_is_dynamic_sysbus_dev_allowed(MachineClass *mc,
>      return allowed;
>  }
>
> -static void validate_sysbus_device(SysBusDevice *sbdev, void *opaque)
> -{
> -    MachineState *machine = opaque;
> -    MachineClass *mc = MACHINE_GET_CLASS(machine);
> -
> -    if (!device_is_dynamic_sysbus(mc, DEVICE(sbdev))) {
> -        error_report("Option '-device %s' cannot be handled by this machine",
> -                     object_class_get_name(object_get_class(OBJECT(sbdev))));
> -        exit(1);
> -    }
> -}
> -
>  static char *machine_get_memdev(Object *obj, Error **errp)
>  {
>      MachineState *ms = MACHINE(obj);
> @@ -598,17 +586,6 @@ static void machine_set_memdev(Object *obj, const char *value, Error **errp)
>      ms->ram_memdev_id = g_strdup(value);
>  }
>
> -static void machine_init_notify(Notifier *notifier, void *data)
> -{
> -    MachineState *machine = MACHINE(qdev_get_machine());
> -
> -    /*
> -     * Loop through all dynamically created sysbus devices and check if they are
> -     * all allowed.  If a device is not allowed, error out.
> -     */
> -    foreach_dynamic_sysbus_device(validate_sysbus_device, machine);
> -}
> -
>  HotpluggableCPUList *machine_query_hotpluggable_cpus(MachineState *machine)
>  {
>      int i;
> @@ -1030,10 +1007,6 @@ static void machine_initfn(Object *obj)
>                                          "Table (HMAT)");
>      }
>
> -    /* Register notifier when init is done for sysbus sanity checks */
> -    ms->sysbus_notifier.notify = machine_init_notify;
> -    qemu_add_machine_init_done_notifier(&ms->sysbus_notifier);
> -
>      /* default to mc->default_cpus */
>      ms->smp.cpus = mc->default_cpus;
>      ms->smp.max_cpus = mc->default_cpus;
> --
> 2.33.0
>
>


From xen-devel-bounces@lists.xenproject.org Tue Oct 12 23:32:24 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 12 Oct 2021 23:32:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.207775.363688 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maRFq-0006tD-FA; Tue, 12 Oct 2021 23:32:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 207775.363688; Tue, 12 Oct 2021 23:32:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maRFq-0006t6-Bt; Tue, 12 Oct 2021 23:32:18 +0000
Received: by outflank-mailman (input) for mailman id 207775;
 Tue, 12 Oct 2021 23:32:17 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=hb0k=PA=kernel.org=helgaas@srs-us1.protection.inumbo.net>)
 id 1maRFp-0006t0-ES
 for xen-devel@lists.xenproject.org; Tue, 12 Oct 2021 23:32:17 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 64cf22e2-1b35-46fe-ac07-6914bd0eb57f;
 Tue, 12 Oct 2021 23:32:15 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id A7F0960E0C;
 Tue, 12 Oct 2021 23:32:13 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 64cf22e2-1b35-46fe-ac07-6914bd0eb57f
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1634081534;
	bh=/npIVjxwllsU1MvqYG6qf+2Jsb2z0DMOJrkQH5LJfwo=;
	h=Date:From:To:Cc:Subject:In-Reply-To:From;
	b=X9EJE3R2xP4x4bVh2T0Pu0yz3q+/jn8+4ch5hF1hS+Tg6jJq+32djVm8KAazh4saE
	 +jPQGp0hdZ7/uvlWQktYqR/MGIMvcav1y2Pjf1ExGXg3nitnr7t1qpTq2t/eGRT4W/
	 OlSs8mhaylMclOfEZCeVTc6lQt/8x6AgMCxdfrJ/Cib++a9tXxYwZ/4QuVxwyjRm5M
	 S5ZuNwNzjSKHpixcaI7YxpLom8rWEURnTarOkuUwFQD3x3fIxZawRPON+EWGQDmEUc
	 a4tzG7fzwC6aWNb1/UlbEws/pv5qs7Kk9xRQWHj9QLRym9WYypMS9Wz+iAiaxuyBz+
	 nG6QlGYpJGxfQ==
Date: Tue, 12 Oct 2021 18:32:12 -0500
From: Bjorn Helgaas <helgaas@kernel.org>
To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= <u.kleine-koenig@pengutronix.de>
Cc: linux-pci@vger.kernel.org, kernel@pengutronix.de,
	Alexander Duyck <alexanderduyck@fb.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Andrew Donnellan <ajd@linux.ibm.com>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Arnd Bergmann <arnd@arndb.de>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Bjorn Helgaas <bhelgaas@google.com>, Borislav Petkov <bp@alien8.de>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	"David S. Miller" <davem@davemloft.net>,
	Fiona Trahe <fiona.trahe@intel.com>,
	Frederic Barrat <fbarrat@linux.ibm.com>,
	Giovanni Cabiddu <giovanni.cabiddu@intel.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	"H. Peter Anvin" <hpa@zytor.com>, Ido Schimmel <idosch@nvidia.com>,
	Ingo Molnar <mingo@redhat.com>, Jack Xu <jack.xu@intel.com>,
	Jakub Kicinski <kuba@kernel.org>,
	Jesse Brandeburg <jesse.brandeburg@intel.com>,
	Jiri Olsa <jolsa@redhat.com>, Jiri Pirko <jiri@nvidia.com>,
	Juergen Gross <jgross@suse.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Marco Chiappero <marco.chiappero@intel.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Mathias Nyman <mathias.nyman@intel.com>, Michael Buesch <m@bues.ch>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Namhyung Kim <namhyung@kernel.org>,
	Oliver O'Halloran <oohall@gmail.com>,
	Paul Mackerras <paulus@samba.org>,
	Peter Zijlstra <peterz@infradead.org>,
	=?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= <zajec5@gmail.com>,
	Russell Currey <ruscur@russell.cc>,
	Salil Mehta <salil.mehta@huawei.com>,
	Sathya Prakash <sathya.prakash@broadcom.com>,
	Simon Horman <simon.horman@corigine.com>,
	Sreekanth Reddy <sreekanth.reddy@broadcom.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Suganath Prabu Subramani <suganath-prabu.subramani@broadcom.com>,
	Taras Chornyi <tchornyi@marvell.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Tomaszx Kowalik <tomaszx.kowalik@intel.com>,
	Vadym Kochan <vkochan@marvell.com>,
	Wojciech Ziemba <wojciech.ziemba@intel.com>,
	Yisen Zhuang <yisen.zhuang@huawei.com>,
	Zhou Wang <wangzhou1@hisilicon.com>, linux-crypto@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org, linux-scsi@vger.kernel.org,
	linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org,
	MPT-FusionLinux.pdl@broadcom.com, netdev@vger.kernel.org,
	oss-drivers@corigine.com, qat-linux@intel.com, x86@kernel.org,
	xen-devel@lists.xenproject.org
Subject: Re: [PATCH v6 00/11] PCI: Drop duplicated tracking of a pci_dev's
 bound driver
Message-ID: <20211012233212.GA1806189@bhelgaas>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20211004125935.2300113-1-u.kleine-koenig@pengutronix.de>

On Mon, Oct 04, 2021 at 02:59:24PM +0200, Uwe Kleine-K�nig wrote:
> Hello,
> 
> this is v6 of the quest to drop the "driver" member from struct pci_dev
> which tracks the same data (apart from a constant offset) as dev.driver.

I like this a lot and applied it to pci/driver for v5.16, thanks!

I split some of the bigger patches apart so they only touched one
driver or subsystem at a time.  I also updated to_pci_driver() so it
returns NULL when given NULL, which makes some of the validations
quite a bit simpler, especially in the PM code in pci-driver.c.

Full interdiff from this v6 series:

diff --git a/arch/x86/kernel/probe_roms.c b/arch/x86/kernel/probe_roms.c
index deaaef6efe34..36e84d904260 100644
--- a/arch/x86/kernel/probe_roms.c
+++ b/arch/x86/kernel/probe_roms.c
@@ -80,17 +80,15 @@ static struct resource video_rom_resource = {
  */
 static bool match_id(struct pci_dev *pdev, unsigned short vendor, unsigned short device)
 {
+	struct pci_driver *drv = to_pci_driver(pdev->dev.driver);
 	const struct pci_device_id *id;
 
 	if (pdev->vendor == vendor && pdev->device == device)
 		return true;
 
-	if (pdev->dev.driver) {
-		struct pci_driver *drv = to_pci_driver(pdev->dev.driver);
-		for (id = drv->id_table; id && id->vendor; id++)
-			if (id->vendor == vendor && id->device == device)
-				break;
-	}
+	for (id = drv ? drv->id_table : NULL; id && id->vendor; id++)
+		if (id->vendor == vendor && id->device == device)
+			break;
 
 	return id && id->vendor;
 }
diff --git a/drivers/misc/cxl/guest.c b/drivers/misc/cxl/guest.c
index d997c9c3ebb5..7eb3706cf42d 100644
--- a/drivers/misc/cxl/guest.c
+++ b/drivers/misc/cxl/guest.c
@@ -20,38 +20,38 @@ static void pci_error_handlers(struct cxl_afu *afu,
 				pci_channel_state_t state)
 {
 	struct pci_dev *afu_dev;
+	struct pci_driver *afu_drv;
+	struct pci_error_handlers *err_handler;
 
 	if (afu->phb == NULL)
 		return;
 
 	list_for_each_entry(afu_dev, &afu->phb->bus->devices, bus_list) {
-		struct pci_driver *afu_drv;
-
-		if (!afu_dev->dev.driver)
-			continue;
-
 		afu_drv = to_pci_driver(afu_dev->dev.driver);
+		if (!afu_drv)
+			continue;
 
+		err_handler = afu_drv->err_handler;
 		switch (bus_error_event) {
 		case CXL_ERROR_DETECTED_EVENT:
 			afu_dev->error_state = state;
 
-			if (afu_drv->err_handler &&
-			    afu_drv->err_handler->error_detected)
-				afu_drv->err_handler->error_detected(afu_dev, state);
-		break;
+			if (err_handler &&
+			    err_handler->error_detected)
+				err_handler->error_detected(afu_dev, state);
+			break;
 		case CXL_SLOT_RESET_EVENT:
 			afu_dev->error_state = state;
 
-			if (afu_drv->err_handler &&
-			    afu_drv->err_handler->slot_reset)
-				afu_drv->err_handler->slot_reset(afu_dev);
-		break;
+			if (err_handler &&
+			    err_handler->slot_reset)
+				err_handler->slot_reset(afu_dev);
+			break;
 		case CXL_RESUME_EVENT:
-			if (afu_drv->err_handler &&
-			    afu_drv->err_handler->resume)
-				afu_drv->err_handler->resume(afu_dev);
-		break;
+			if (err_handler &&
+			    err_handler->resume)
+				err_handler->resume(afu_dev);
+			break;
 		}
 	}
 }
diff --git a/drivers/misc/cxl/pci.c b/drivers/misc/cxl/pci.c
index 7e7545d01e27..08bd81854101 100644
--- a/drivers/misc/cxl/pci.c
+++ b/drivers/misc/cxl/pci.c
@@ -1795,6 +1795,8 @@ static pci_ers_result_t cxl_vphb_error_detected(struct cxl_afu *afu,
 						pci_channel_state_t state)
 {
 	struct pci_dev *afu_dev;
+	struct pci_driver *afu_drv;
+	struct pci_error_handlers *err_handler;
 	pci_ers_result_t result = PCI_ERS_RESULT_NEED_RESET;
 	pci_ers_result_t afu_result = PCI_ERS_RESULT_NEED_RESET;
 
@@ -1805,16 +1807,16 @@ static pci_ers_result_t cxl_vphb_error_detected(struct cxl_afu *afu,
 		return result;
 
 	list_for_each_entry(afu_dev, &afu->phb->bus->devices, bus_list) {
-		struct pci_driver *afu_drv;
-		if (!afu_dev->dev.driver)
-			continue;
-
 		afu_drv = to_pci_driver(afu_dev->dev.driver);
+		if (!afu_drv)
+			continue;
 
 		afu_dev->error_state = state;
 
-		if (afu_drv->err_handler)
-			afu_result = afu_drv->err_handler->error_detected(afu_dev, state);
+		err_handler = afu_drv->err_handler;
+		if (err_handler)
+			afu_result = err_handler->error_detected(afu_dev,
+								 state);
 		/* Disconnect trumps all, NONE trumps NEED_RESET */
 		if (afu_result == PCI_ERS_RESULT_DISCONNECT)
 			result = PCI_ERS_RESULT_DISCONNECT;
@@ -1974,6 +1976,8 @@ static pci_ers_result_t cxl_pci_slot_reset(struct pci_dev *pdev)
 	struct cxl_afu *afu;
 	struct cxl_context *ctx;
 	struct pci_dev *afu_dev;
+	struct pci_driver *afu_drv;
+	struct pci_error_handlers *err_handler;
 	pci_ers_result_t afu_result = PCI_ERS_RESULT_RECOVERED;
 	pci_ers_result_t result = PCI_ERS_RESULT_RECOVERED;
 	int i;
@@ -2005,8 +2009,6 @@ static pci_ers_result_t cxl_pci_slot_reset(struct pci_dev *pdev)
 			continue;
 
 		list_for_each_entry(afu_dev, &afu->phb->bus->devices, bus_list) {
-			struct pci_driver *afu_drv;
-
 			/* Reset the device context.
 			 * TODO: make this less disruptive
 			 */
@@ -2032,14 +2034,13 @@ static pci_ers_result_t cxl_pci_slot_reset(struct pci_dev *pdev)
 			 * shouldn't start new work until we call
 			 * their resume function.
 			 */
-			if (!afu_dev->dev.driver)
-				continue;
-
 			afu_drv = to_pci_driver(afu_dev->dev.driver);
+			if (!afu_drv)
+				continue;
 
-			if (afu_drv->err_handler &&
-			    afu_drv->err_handler->slot_reset)
-				afu_result = afu_drv->err_handler->slot_reset(afu_dev);
+			err_handler = afu_drv->err_handler;
+			if (err_handler && err_handler->slot_reset)
+				afu_result = err_handler->slot_reset(afu_dev);
 
 			if (afu_result == PCI_ERS_RESULT_DISCONNECT)
 				result = PCI_ERS_RESULT_DISCONNECT;
@@ -2066,6 +2067,8 @@ static void cxl_pci_resume(struct pci_dev *pdev)
 	struct cxl *adapter = pci_get_drvdata(pdev);
 	struct cxl_afu *afu;
 	struct pci_dev *afu_dev;
+	struct pci_driver *afu_drv;
+	struct pci_error_handlers *err_handler;
 	int i;
 
 	/* Everything is back now. Drivers should restart work now.
@@ -2080,11 +2083,13 @@ static void cxl_pci_resume(struct pci_dev *pdev)
 			continue;
 
 		list_for_each_entry(afu_dev, &afu->phb->bus->devices, bus_list) {
-			struct pci_driver *afu_drv;
-			if (afu_dev->dev.driver &&
-			    (afu_drv = to_pci_driver(afu_dev->dev.driver))->err_handler &&
-			    afu_drv->err_handler->resume)
-				afu_drv->err_handler->resume(afu_dev);
+			afu_drv = to_pci_driver(afu_dev->dev.driver);
+			if (!afu_drv)
+				continue;
+
+			err_handler = afu_drv->err_handler;
+			if (err_handler && err_handler->resume)
+				err_handler->resume(afu_dev);
 		}
 	}
 	spin_unlock(&adapter->afu_list_lock);
diff --git a/drivers/pci/iov.c b/drivers/pci/iov.c
index 0d0a34347868..fa4b52bb1e05 100644
--- a/drivers/pci/iov.c
+++ b/drivers/pci/iov.c
@@ -168,11 +168,8 @@ static ssize_t sriov_vf_total_msix_show(struct device *dev,
 	u32 vf_total_msix = 0;
 
 	device_lock(dev);
-	if (!dev->driver)
-		goto unlock;
-
 	pdrv = to_pci_driver(dev->driver);
-	if (!pdrv->sriov_get_vf_total_msix)
+	if (!pdrv || !pdrv->sriov_get_vf_total_msix)
 		goto unlock;
 
 	vf_total_msix = pdrv->sriov_get_vf_total_msix(pdev);
@@ -199,19 +196,14 @@ static ssize_t sriov_vf_msix_count_store(struct device *dev,
 		return -EINVAL;
 
 	device_lock(&pdev->dev);
-	if (!pdev->dev.driver) {
-		ret = -EOPNOTSUPP;
-		goto err_pdev;
-	}
-
-	pdrv = to_pci_driver(pdev->dev.driver);
-	if (!pdrv->sriov_set_msix_vec_count) {
+	pdrv = to_pci_driver(dev->driver);
+	if (!pdrv || !pdrv->sriov_set_msix_vec_count) {
 		ret = -EOPNOTSUPP;
 		goto err_pdev;
 	}
 
 	device_lock(&vf_dev->dev);
-	if (vf_dev->dev.driver) {
+	if (to_pci_driver(vf_dev->dev.driver)) {
 		/*
 		 * A driver is already attached to this VF and has configured
 		 * itself based on the current MSI-X vector count. Changing
@@ -405,14 +397,13 @@ static ssize_t sriov_numvfs_store(struct device *dev,
 		goto exit;
 
 	/* is PF driver loaded */
-	if (!pdev->dev.driver) {
+	pdrv = to_pci_driver(dev->driver);
+	if (!pdrv) {
 		pci_info(pdev, "no driver bound to device; cannot configure SR-IOV\n");
 		ret = -ENOENT;
 		goto exit;
 	}
 
-	pdrv = to_pci_driver(pdev->dev.driver);
-
 	/* is PF driver loaded w/callback */
 	if (!pdrv->sriov_configure) {
 		pci_info(pdev, "driver does not support SR-IOV configuration via sysfs\n");
diff --git a/drivers/pci/pci-driver.c b/drivers/pci/pci-driver.c
index e94aa338bab4..3884a1542e86 100644
--- a/drivers/pci/pci-driver.c
+++ b/drivers/pci/pci-driver.c
@@ -454,7 +454,7 @@ static int pci_device_probe(struct device *dev)
 static void pci_device_remove(struct device *dev)
 {
 	struct pci_dev *pci_dev = to_pci_dev(dev);
-	struct pci_driver *drv = to_pci_driver(pci_dev->dev.driver);
+	struct pci_driver *drv = to_pci_driver(dev->driver);
 
 	if (drv->remove) {
 		pm_runtime_get_sync(dev);
@@ -489,15 +489,12 @@ static void pci_device_remove(struct device *dev)
 static void pci_device_shutdown(struct device *dev)
 {
 	struct pci_dev *pci_dev = to_pci_dev(dev);
+	struct pci_driver *drv = to_pci_driver(dev->driver);
 
 	pm_runtime_resume(dev);
 
-	if (pci_dev->dev.driver) {
-		struct pci_driver *drv = to_pci_driver(pci_dev->dev.driver);
-
-		if (drv->shutdown)
-			drv->shutdown(pci_dev);
-	}
+	if (drv && drv->shutdown)
+		drv->shutdown(pci_dev);
 
 	/*
 	 * If this is a kexec reboot, turn off Bus Master bit on the
@@ -588,25 +585,22 @@ static int pci_pm_reenable_device(struct pci_dev *pci_dev)
 static int pci_legacy_suspend(struct device *dev, pm_message_t state)
 {
 	struct pci_dev *pci_dev = to_pci_dev(dev);
+	struct pci_driver *drv = to_pci_driver(dev->driver);
 
-	if (dev->driver) {
-		struct pci_driver *drv = to_pci_driver(dev->driver);
+	if (drv && drv->suspend) {
+		pci_power_t prev = pci_dev->current_state;
+		int error;
 
-		if (drv->suspend) {
-			pci_power_t prev = pci_dev->current_state;
-			int error;
+		error = drv->suspend(pci_dev, state);
+		suspend_report_result(drv->suspend, error);
+		if (error)
+			return error;
 
-			error = drv->suspend(pci_dev, state);
-			suspend_report_result(drv->suspend, error);
-			if (error)
-				return error;
-
-			if (!pci_dev->state_saved && pci_dev->current_state != PCI_D0
-			    && pci_dev->current_state != PCI_UNKNOWN) {
-				pci_WARN_ONCE(pci_dev, pci_dev->current_state != prev,
-					      "PCI PM: Device state not saved by %pS\n",
-					      drv->suspend);
-			}
+		if (!pci_dev->state_saved && pci_dev->current_state != PCI_D0
+		    && pci_dev->current_state != PCI_UNKNOWN) {
+			pci_WARN_ONCE(pci_dev, pci_dev->current_state != prev,
+				      "PCI PM: Device state not saved by %pS\n",
+				      drv->suspend);
 		}
 	}
 
@@ -632,17 +626,12 @@ static int pci_legacy_suspend_late(struct device *dev, pm_message_t state)
 static int pci_legacy_resume(struct device *dev)
 {
 	struct pci_dev *pci_dev = to_pci_dev(dev);
+	struct pci_driver *drv = to_pci_driver(dev->driver);
 
 	pci_fixup_device(pci_fixup_resume, pci_dev);
 
-	if (pci_dev->dev.driver) {
-		struct pci_driver *drv = to_pci_driver(pci_dev->dev.driver);
-
-		if (drv->resume)
-			return drv->resume(pci_dev);
-	}
-
-	return pci_pm_reenable_device(pci_dev);
+	return drv && drv->resume ?
+			drv->resume(pci_dev) : pci_pm_reenable_device(pci_dev);
 }
 
 /* Auxiliary functions used by the new power management framework */
@@ -656,14 +645,8 @@ static void pci_pm_default_suspend(struct pci_dev *pci_dev)
 
 static bool pci_has_legacy_pm_support(struct pci_dev *pci_dev)
 {
-	struct pci_driver *drv;
-	bool ret;
-
-	if (!pci_dev->dev.driver)
-		return false;
-
-	drv = to_pci_driver(pci_dev->dev.driver);
-	ret = drv && (drv->suspend || drv->resume);
+	struct pci_driver *drv = to_pci_driver(pci_dev->dev.driver);
+	bool ret = drv && (drv->suspend || drv->resume);
 
 	/*
 	 * Legacy PM support is used by default, so warn if the new framework is
@@ -1255,11 +1238,11 @@ static int pci_pm_runtime_suspend(struct device *dev)
 	int error;
 
 	/*
-	 * If pci_dev->dev.driver is not set (unbound), we leave the device in D0,
-	 * but it may go to D3cold when the bridge above it runtime suspends.
-	 * Save its config space in case that happens.
+	 * If the device has no driver, we leave it in D0, but it may go to
+	 * D3cold when the bridge above it runtime suspends.  Save its
+	 * config space in case that happens.
 	 */
-	if (!pci_dev->dev.driver) {
+	if (!to_pci_driver(dev->driver)) {
 		pci_save_state(pci_dev);
 		return 0;
 	}
@@ -1316,7 +1299,7 @@ static int pci_pm_runtime_resume(struct device *dev)
 	 */
 	pci_restore_standard_config(pci_dev);
 
-	if (!dev->driver)
+	if (!to_pci_driver(dev->driver))
 		return 0;
 
 	pci_fixup_device(pci_fixup_resume_early, pci_dev);
@@ -1335,13 +1318,14 @@ static int pci_pm_runtime_resume(struct device *dev)
 
 static int pci_pm_runtime_idle(struct device *dev)
 {
+	struct pci_dev *pci_dev = to_pci_dev(dev);
 	const struct dev_pm_ops *pm = dev->driver ? dev->driver->pm : NULL;
 
 	/*
-	 * If dev->driver is not set (unbound), the device should
-	 * always remain in D0 regardless of the runtime PM status
+	 * If the device has no driver, it should always remain in D0
+	 * regardless of the runtime PM status
 	 */
-	if (!dev->driver)
+	if (!to_pci_driver(dev->driver))
 		return 0;
 
 	if (!pm)
@@ -1448,8 +1432,10 @@ static struct pci_driver pci_compat_driver = {
  */
 struct pci_driver *pci_dev_driver(const struct pci_dev *dev)
 {
-	if (dev->dev.driver)
-		return to_pci_driver(dev->dev.driver);
+	struct pci_driver *drv = to_pci_driver(dev->dev.driver);
+
+	if (drv)
+		return drv;
 	else {
 		int i;
 		for (i = 0; i <= PCI_ROM_RESOURCE; i++)
diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
index ccecf740de59..5298ce131f8c 100644
--- a/drivers/pci/pci.c
+++ b/drivers/pci/pci.c
@@ -5088,13 +5088,14 @@ EXPORT_SYMBOL_GPL(pci_dev_unlock);
 
 static void pci_dev_save_and_disable(struct pci_dev *dev)
 {
+	struct pci_driver *drv = to_pci_driver(dev->dev.driver);
 	const struct pci_error_handlers *err_handler =
-			dev->dev.driver ? to_pci_driver(dev->dev.driver)->err_handler : NULL;
+			drv ? drv->err_handler : NULL;
 
 	/*
-	 * dev->driver->err_handler->reset_prepare() is protected against
-	 * races with ->remove() by the device lock, which must be held by
-	 * the caller.
+	 * drv->err_handler->reset_prepare() is protected against races
+	 * with ->remove() by the device lock, which must be held by the
+	 * caller.
 	 */
 	if (err_handler && err_handler->reset_prepare)
 		err_handler->reset_prepare(dev);
@@ -5119,15 +5120,15 @@ static void pci_dev_save_and_disable(struct pci_dev *dev)
 
 static void pci_dev_restore(struct pci_dev *dev)
 {
+	struct pci_driver *drv = to_pci_driver(dev->dev.driver);
 	const struct pci_error_handlers *err_handler =
-			dev->dev.driver ? to_pci_driver(dev->dev.driver)->err_handler : NULL;
+			drv ? drv->err_handler : NULL;
 
 	pci_restore_state(dev);
 
 	/*
-	 * dev->driver->err_handler->reset_done() is protected against
-	 * races with ->remove() by the device lock, which must be held by
-	 * the caller.
+	 * drv->err_handler->reset_done() is protected against races with
+	 * ->remove() by the device lock, which must be held by the caller.
 	 */
 	if (err_handler && err_handler->reset_done)
 		err_handler->reset_done(dev);
diff --git a/drivers/pci/pcie/err.c b/drivers/pci/pcie/err.c
index b314b54f7821..42385fe6b7fa 100644
--- a/drivers/pci/pcie/err.c
+++ b/drivers/pci/pcie/err.c
@@ -54,9 +54,10 @@ static int report_error_detected(struct pci_dev *dev,
 	const struct pci_error_handlers *err_handler;
 
 	device_lock(&dev->dev);
+	pdrv = to_pci_driver(dev->dev.driver);
 	if (!pci_dev_set_io_state(dev, state) ||
-		!dev->dev.driver ||
-		!(pdrv = to_pci_driver(dev->dev.driver))->err_handler ||
+		!pdrv ||
+		!pdrv->err_handler ||
 		!pdrv->err_handler->error_detected) {
 		/*
 		 * If any device in the subtree does not have an error_detected
@@ -92,13 +93,14 @@ static int report_normal_detected(struct pci_dev *dev, void *data)
 
 static int report_mmio_enabled(struct pci_dev *dev, void *data)
 {
-	pci_ers_result_t vote, *result = data;
 	struct pci_driver *pdrv;
+	pci_ers_result_t vote, *result = data;
 	const struct pci_error_handlers *err_handler;
 
 	device_lock(&dev->dev);
-	if (!dev->dev.driver ||
-		!(pdrv = to_pci_driver(dev->dev.driver))->err_handler ||
+	pdrv = to_pci_driver(dev->dev.driver);
+	if (!pdrv ||
+		!pdrv->err_handler ||
 		!pdrv->err_handler->mmio_enabled)
 		goto out;
 
@@ -112,13 +114,14 @@ static int report_mmio_enabled(struct pci_dev *dev, void *data)
 
 static int report_slot_reset(struct pci_dev *dev, void *data)
 {
+	struct pci_driver *pdrv;
 	pci_ers_result_t vote, *result = data;
 	const struct pci_error_handlers *err_handler;
-	struct pci_driver *pdrv;
 
 	device_lock(&dev->dev);
-	if (!dev->dev.driver ||
-		!(pdrv = to_pci_driver(dev->dev.driver))->err_handler ||
+	pdrv = to_pci_driver(dev->dev.driver);
+	if (!pdrv ||
+		!pdrv->err_handler ||
 		!pdrv->err_handler->slot_reset)
 		goto out;
 
@@ -132,13 +135,14 @@ static int report_slot_reset(struct pci_dev *dev, void *data)
 
 static int report_resume(struct pci_dev *dev, void *data)
 {
-	const struct pci_error_handlers *err_handler;
 	struct pci_driver *pdrv;
+	const struct pci_error_handlers *err_handler;
 
 	device_lock(&dev->dev);
+	pdrv = dev->driver;
 	if (!pci_dev_set_io_state(dev, pci_channel_io_normal) ||
-		!dev->dev.driver ||
-		!(pdrv = to_pci_driver(dev->dev.driver))->err_handler ||
+		!pdrv ||
+		!pdrv->err_handler ||
 		!pdrv->err_handler->resume)
 		goto out;
 
diff --git a/drivers/pci/xen-pcifront.c b/drivers/pci/xen-pcifront.c
index 73831fb87a1e..0ec76b4af16f 100644
--- a/drivers/pci/xen-pcifront.c
+++ b/drivers/pci/xen-pcifront.c
@@ -588,7 +588,6 @@ static pci_ers_result_t pcifront_common_process(int cmd,
 						struct pcifront_device *pdev,
 						pci_channel_state_t state)
 {
-	pci_ers_result_t result;
 	struct pci_driver *pdrv;
 	int bus = pdev->sh_info->aer_op.bus;
 	int devfn = pdev->sh_info->aer_op.devfn;
@@ -598,13 +597,12 @@ static pci_ers_result_t pcifront_common_process(int cmd,
 	dev_dbg(&pdev->xdev->dev,
 		"pcifront AER process: cmd %x (bus:%x, devfn%x)",
 		cmd, bus, devfn);
-	result = PCI_ERS_RESULT_NONE;
 
 	pcidev = pci_get_domain_bus_and_slot(domain, bus, devfn);
 	if (!pcidev || !pcidev->dev.driver) {
 		dev_err(&pdev->xdev->dev, "device or AER driver is NULL\n");
 		pci_dev_put(pcidev);
-		return result;
+		return PCI_ERS_RESULT_NONE;
 	}
 	pdrv = to_pci_driver(pcidev->dev.driver);
 
@@ -612,27 +610,18 @@ static pci_ers_result_t pcifront_common_process(int cmd,
 		pci_dbg(pcidev, "trying to call AER service\n");
 		switch (cmd) {
 		case XEN_PCI_OP_aer_detected:
-			result = pdrv->err_handler->
-				 error_detected(pcidev, state);
-			break;
+			return pdrv->err_handler->error_detected(pcidev, state);
 		case XEN_PCI_OP_aer_mmio:
-			result = pdrv->err_handler->
-				 mmio_enabled(pcidev);
-			break;
+			return pdrv->err_handler->mmio_enabled(pcidev);
 		case XEN_PCI_OP_aer_slotreset:
-			result = pdrv->err_handler->
-				 slot_reset(pcidev);
-			break;
+			return pdrv->err_handler->slot_reset(pcidev);
 		case XEN_PCI_OP_aer_resume:
 			pdrv->err_handler->resume(pcidev);
-			break;
+			return PCI_ERS_RESULT_NONE;
 		default:
 			dev_err(&pdev->xdev->dev,
-				"bad request in aer recovery "
-				"operation!\n");
+				"bad request in AER recovery operation!\n");
 		}
-
-		return result;
 	}
 
 	return PCI_ERS_RESULT_NONE;
diff --git a/include/linux/pci.h b/include/linux/pci.h
index 7c1ceb39035c..03bfdb25a55c 100644
--- a/include/linux/pci.h
+++ b/include/linux/pci.h
@@ -899,7 +899,10 @@ struct pci_driver {
 	struct pci_dynids	dynids;
 };
 
-#define	to_pci_driver(drv) container_of(drv, struct pci_driver, driver)
+static inline struct pci_driver *to_pci_driver(struct device_driver *drv)
+{
+    return drv ? container_of(drv, struct pci_driver, driver) : NULL;
+}
 
 /**
  * PCI_DEVICE - macro used to describe a specific PCI device


From xen-devel-bounces@lists.xenproject.org Wed Oct 13 00:43:12 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 00:43:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.207785.363700 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maSMA-0005gi-Od; Wed, 13 Oct 2021 00:42:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 207785.363700; Wed, 13 Oct 2021 00:42:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maSMA-0005gb-LK; Wed, 13 Oct 2021 00:42:54 +0000
Received: by outflank-mailman (input) for mailman id 207785;
 Wed, 13 Oct 2021 00:42:52 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=XJnr=PB=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1maSM8-0005gV-Sl
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 00:42:52 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 7eb28fc6-2bbe-11ec-815a-12813bfff9fa;
 Wed, 13 Oct 2021 00:42:51 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id 4CAE860EB4;
 Wed, 13 Oct 2021 00:42:50 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7eb28fc6-2bbe-11ec-815a-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1634085770;
	bh=SRqyP5abr+ZRlPkyAgc4gyKINlzuiYnhlPALhAa8tpU=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=rVISt6iYBGfsIKDaWk7uYeZH0wvRkv3QK7lSUue2STE37LKG4hO4g4Szt9vRyYlra
	 U7HDz4kaq/S5YunEbZ15dtguuIugKnbudk0xrew4EteHzc8/Ronq3AFFPYyLyPi54X
	 DSQhP3lICgHqHDoy231GNejMpyuz3kqaQJwt97rus3nOALjxBsoIf0GKidxwVQ903x
	 6ypFY6NKkhuteNeuU64cKw6MatwCvkFCcebXTOurjhAK26dM24XRMRPtVZZc1uNU/Y
	 rpQFmncUOwkhh7CSdbqMh3pklf+rVMSOdCsRQKPiEDF38U5jbEkHBE2jlI9W5BBmt7
	 iQK1/VISu2maA==
Date: Tue, 12 Oct 2021 17:42:48 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Julien Grall <julien@xen.org>
cc: Hongda Deng <Hongda.Deng@arm.com>, xen-devel@lists.xenproject.org, 
    sstabellini@kernel.org, Bertrand.Marquis@arm.com, Wei.Chen@arm.com
Subject: Re: [PATCH v2] xen/arm: vgic to ignore GICD ICPENRn registers
 access
In-Reply-To: <2006f09d-25c3-af7a-cbea-dbc811fc8748@xen.org>
Message-ID: <alpine.DEB.2.21.2110121548060.9408@sstabellini-ThinkPad-T480s>
References: <20211012062449.30966-1-Hongda.Deng@arm.com> <2006f09d-25c3-af7a-cbea-dbc811fc8748@xen.org>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Tue, 12 Oct 2021, Julien Grall wrote:
> On 12/10/2021 07:24, Hongda Deng wrote:
> > Currently, Xen will return IO unhandled when guests access GICD ICPENRn
> > registers. This will raise a data abort inside guest. For Linux Guest,
> > these virtual registers will not be accessed. But for Zephyr, in its
> > GIC initialization code, these virtual registers will be accessed. And
> > zephyr guest will get an IO data abort in initilization stage and enter
> > fatal error. Emulating ICPENDR is not easy with the existing vGIC, so
> > we currently ignore these virtual registers access and print a message
> > about whether they are already pending instead of returning unhandled.
> > More details can be found at [1].
> 
> The link you provide only states that I am happy with the warning. This
> doesn't seem relevant for a future reader. Did you intend to point to
> something different?
> 
> > 
> > [1] https://lists.xenproject.org/archives/html/xen-devel/2021-09/
> > msg00744.html
> > 
> > Signed-off-by: Hongda Deng <hongda.deng@arm.com>
> > ---
> >   xen/arch/arm/vgic-v2.c | 26 +++++++++++++++++++++++++-
> >   xen/arch/arm/vgic-v3.c | 40 +++++++++++++++++++++++++++++++---------
> >   2 files changed, 56 insertions(+), 10 deletions(-)
> > 
> > diff --git a/xen/arch/arm/vgic-v2.c b/xen/arch/arm/vgic-v2.c
> > index b2da886adc..d7ffaeeb65 100644
> > --- a/xen/arch/arm/vgic-v2.c
> > +++ b/xen/arch/arm/vgic-v2.c
> > @@ -480,11 +480,35 @@ static int vgic_v2_distr_mmio_write(struct vcpu *v,
> > mmio_info_t *info,
> >           return 1;
> >         case VRANGE32(GICD_ICPENDR, GICD_ICPENDRN):
> > +    {
> > +        struct pending_irq *iter;
> > +        unsigned int irq_start;
> > +        unsigned int irq_end;
> > +        uint32_t irq_pending = 0;
> > +
> >           if ( dabt.size != DABT_WORD ) goto bad_width;
> >           printk(XENLOG_G_ERR
> >                  "%pv: vGICD: unhandled word write %#"PRIregister" to
> > ICPENDR%d\n",
> >                  v, r, gicd_reg - GICD_ICPENDR);
> 
> As I wrote in v1, we should avoid to print a message when we know there is no
> pending interrupts.
> 
> > -        return 0;
> > +
> > +        irq_start = (gicd_reg - GICD_ICPENDR) * 32;
> > +        irq_end = irq_start + 31;
> > +        /* go through inflight_irqs and print specified pending irqs */
> > +        list_for_each_entry(iter, &v->arch.vgic.inflight_irqs, inflight)
> You need to hold v->arch.vgic.lock (with interrupt disabled) to go through the
> list of inflight irqs. Otherwise, the list may be modified while you are
> walking it.
> 
> However, I am a little bit concerned with this approached (I noticed Stefano
> suggested). The list may in theory contains a few hundreds interrupts (a
> malicious OS May decide to never read IAR). So we are potentially doing more
> work than necessary (we need to think about the worse case scenario).
> 
> Instead, I think it would be better to go through the 32 interrupts and for
> each of them:
>   1) find the pending_irq() using irq_to_pending()
>   2) check if the IRQ in the inflight list with list_empty(&p->inflight)
> 
> In addition to that, you want to check that the rank exists so we don't do any
> extra work if the guest is trying to clear an interrupts above the number of
> interrupts we support.

This is a good approach and it should be fast.

In the normal case, iterating over inflight_irqs should be fine because
there are typically no more than 2-3 inflight interrupts. So in the
normal case iterating over inflight_irqs will be typically faster but in
the worst case it could be bad because the theoretical max is high: it
is only bounded by the total amount of interrupts assigned to the domU
and by the vgic IRQ limit. So theoretically it is possible that we could
have to walk a list with a hundred elements or more.

Your suggestion has the advantage that the compute time becomes
deterministic. Alternatively, we could #ifdef DEBUG the walk over the
inflight_irqs list. I am fine either way but I prefer your suggestion.


From xen-devel-bounces@lists.xenproject.org Wed Oct 13 00:49:14 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 00:49:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.207793.363711 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maSSE-0006Mb-Er; Wed, 13 Oct 2021 00:49:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 207793.363711; Wed, 13 Oct 2021 00:49:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maSSE-0006MU-BD; Wed, 13 Oct 2021 00:49:10 +0000
Received: by outflank-mailman (input) for mailman id 207793;
 Wed, 13 Oct 2021 00:49:09 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=XJnr=PB=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1maSSD-0006MN-0K
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 00:49:09 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 1c613319-ad0b-4b98-829b-fada0986ea40;
 Wed, 13 Oct 2021 00:49:08 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id F0D3F60EB4;
 Wed, 13 Oct 2021 00:49:06 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1c613319-ad0b-4b98-829b-fada0986ea40
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1634086147;
	bh=TZ/GUui+f3ggfKlva+yhsLjnNF7QP+vt/8AOsUzlM5I=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=A6bn4nc8M7stCNtD5UXjiy9HwUOg7OMISXQ4hLsqsJ/BuNHS02ADg1lhHd1FnbrDL
	 T00jqvKrhPJZzivd42JcaWKYLPuSpBnL0y7QDLCh+yuGNg55O9Nr2k/HuvE0aHw6Jh
	 eet/DfIB204C6ShY4TB/H3G9AE9v9EhO9jFPAZSs654O+eaATvzfONXLiXAgnGr+tD
	 lfZZ0R9TXprPmKL7ExzcqMYCpjmwQz5FKTEfz3mNq+kZTiy77sehTHvlz2h8dcvDSY
	 1Hc64+7CIBkFsIK4562arOFjpZzEwzKdQ7E3VvV97EgKic9V/SIXkGBKASI5TAmyIG
	 dbWK2xVOioNbA==
Date: Tue, 12 Oct 2021 17:49:06 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Luca Fancellu <luca.fancellu@arm.com>
cc: Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>, 
    xen-devel@lists.xenproject.org, 
    Bertrand Marquis <bertrand.marquis@arm.com>, wei.chen@arm.com, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, 
    Andrew Cooper <andrew.cooper3@citrix.com>, 
    George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>, 
    Jan Beulich <jbeulich@suse.com>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH v6 2/2] arm/efi: load dom0 modules from DT using UEFI
In-Reply-To: <81EA782B-762E-4B8A-8D33-EC79203439BC@arm.com>
Message-ID: <alpine.DEB.2.21.2110121309560.9408@sstabellini-ThinkPad-T480s>
References: <20211011181528.17367-1-luca.fancellu@arm.com> <20211011181528.17367-3-luca.fancellu@arm.com> <alpine.DEB.2.21.2110111243290.25528@sstabellini-ThinkPad-T480s> <EC7165F9-09CE-4001-93ED-FA637F5ED36C@arm.com> <alpine.DEB.2.21.2110111415350.25528@sstabellini-ThinkPad-T480s>
 <alpine.DEB.2.21.2110111423310.25528@sstabellini-ThinkPad-T480s> <29cc47f2-4727-0397-db0c-a6c1f5a52bf7@xen.org> <alpine.DEB.2.21.2110111813510.25528@sstabellini-ThinkPad-T480s> <81EA782B-762E-4B8A-8D33-EC79203439BC@arm.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: multipart/mixed; BOUNDARY="8323329-1765897762-1634069519=:9408"
Content-ID: <alpine.DEB.2.21.2110121312380.9408@sstabellini-ThinkPad-T480s>

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-1765897762-1634069519=:9408
Content-Type: text/plain; CHARSET=UTF-8
Content-Transfer-Encoding: 8BIT
Content-ID: <alpine.DEB.2.21.2110121312381.9408@sstabellini-ThinkPad-T480s>

On Tue, 12 Oct 2021, Luca Fancellu wrote:
> > On 12 Oct 2021, at 02:31, Stefano Stabellini <sstabellini@kernel.org> wrote:
> > 
> > On Mon, 11 Oct 2021, Julien Grall wrote:
> >> Hi Stefano,
> >> 
> >> On 11/10/2021 22:24, Stefano Stabellini wrote:
> >>>> diff --git a/xen/arch/arm/efi/efi-boot.h b/xen/arch/arm/efi/efi-boot.h
> >>>> index 840728d6c0..076b827bdd 100644
> >>>> --- a/xen/arch/arm/efi/efi-boot.h
> >>>> +++ b/xen/arch/arm/efi/efi-boot.h
> >>>> @@ -713,10 +713,12 @@ static int __init handle_module_node(EFI_FILE_HANDLE
> >>>> dir_handle,
> >>>>      char mod_string[24]; /* Placeholder for module@ + a 64-bit number +
> >>>> \0 */
> >>>>      int uefi_name_len, file_idx, module_compat;
> >>>>      module_name *file;
> >>>> +    const char *compat_string = is_domu_module ? "multiboot,module" :
> >>>> +                                "xen,multiboot-module";
> >>>>        /* Check if the node is a multiboot,module otherwise return */
> >>>>      module_compat = fdt_node_check_compatible(fdt, module_node_offset,
> >>>> -                                              "multiboot,module");
> >>>> +                                              compat_string);
> >>>>      if ( module_compat < 0 )
> >>>>          /* Error while checking the compatible string */
> >>>>          return ERROR_CHECK_MODULE_COMPAT;
> >>> 
> >>> 
> >>> Well... not exactly like this because this would stop a normal
> >>> "multiboot,module" dom0 kernel from being recognized.
> >>> 
> >>> So we need for domU: only "multiboot,module"
> >>> For Dom0, either "multiboot,module" or "xen,multiboot-module"
> >> 
> >> Looking at the history, xen,multiboot-module has been considered as a legacy
> >> binding since before UEFI was introduced. In fact, without this series, I
> >> believe, there is limited reasons for the compatible to be present in the DT
> >> as you would either use grub (which use the new compatible) or xen.cfg (the
> >> stub will create the node).
> >> 
> >> So I would argue that this compatible should not be used in combination with
> >> UEFI and therefore we should not handle it. This would make the code simpler
> >> :).
> > 
> 
> Hi Stefano,
> 
> > What you suggested is a viable option, however ImageBuilder is still
> > using the "xen,multiboot-module" format somehow today (no idea why) and
> > we have the following written in docs/misc/arm/device-tree/booting.txt:
> > 
> > 	Xen 4.4 supported a different set of legacy compatible strings
> > 	which remain supported such that systems supporting both 4.4
> > 	and later can use a single DTB.
> > 
> > 	- "xen,multiboot-module" equivalent to "multiboot,module"
> > 	- "xen,linux-zimage"     equivalent to "multiboot,kernel"
> > 	- "xen,linux-initrd"     equivalent to "multiboot,ramdisk"
> > 
> > 	For compatibility with Xen 4.4 the more specific "xen,linux-*"
> > 	names are non-optional and must be included.
> > 
> > My preference is to avoid breaking compatibility (even with UEFI
> > booting). The way I suggested above is one way to do it.
> > 
> > But I don't feel strongly about this at all, I am fine with ignoring
> > "xen,multiboot-module" in the EFI stub. I can get ImageBuilder fixed
> > very quickly (I should do that in any case). If we are going to ignore
> > "xen,multiboot-module" then we probably want to update the text in
> > docs/misc/arm/device-tree/booting.txt also.
> 
> The changes to support legacy compatible strings can be done but it will result in
> complex code, I would go for Julien suggestion to just drop it for UEFI.
> 
> I can add a note on docs/misc/arm/device-tree/booting.txt saying that for UEFI boot
> the legacy strings are not supported.
> 
> Something like:
> 
> --- a/docs/misc/arm/device-tree/booting.txt
> +++ b/docs/misc/arm/device-tree/booting.txt
> @@ -51,6 +51,8 @@ Each node contains the following properties:
>         Xen 4.4 supported a different set of legacy compatible strings
>         which remain supported such that systems supporting both 4.4
>         and later can use a single DTB.
> +       However when booting Xen using UEFI and Device Tree, the legacy compatible
> +       strings are not supported.
>  
>         - "xen,multiboot-module" equivalent to "multiboot,module"
>         - "xen,linux-zimage"     equivalent to "multiboot,kernel”
> 
> 
> What do you think about that?

Also reading Julien's reply, I am fine with a doc-only change in a
separate patch.

Yes, something along those lines is OK.

So for this patch:

Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
--8323329-1765897762-1634069519=:9408--


From xen-devel-bounces@lists.xenproject.org Wed Oct 13 00:49:27 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 00:49:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.207795.363721 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maSSV-0006pB-M6; Wed, 13 Oct 2021 00:49:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 207795.363721; Wed, 13 Oct 2021 00:49:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maSSV-0006p2-J2; Wed, 13 Oct 2021 00:49:27 +0000
Received: by outflank-mailman (input) for mailman id 207795;
 Wed, 13 Oct 2021 00:49:26 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=XJnr=PB=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1maSSU-0006m9-HM
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 00:49:26 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 697d1897-2bbf-11ec-815a-12813bfff9fa;
 Wed, 13 Oct 2021 00:49:25 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id 8259660EB4;
 Wed, 13 Oct 2021 00:49:24 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 697d1897-2bbf-11ec-815a-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1634086164;
	bh=SF+FKCJgQun6bUDgvz8eXpBwT2Ya/VNgYhLerIbtnnE=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=ZcUY+I3aylfYt83AtmkWiEtUOM3/O410J90/m+4n98akmEgygBABNoNGocFYGHqKI
	 pTSIBkyFe9VcMDtGR8rLFSVxGOoWYBqnPbOXYS7PlfeRETX2L+nsLd2qZQCPIRqxtY
	 MsVOd/N7nwpfZ5gS4tixlhba/rk1clXn/2hn5hCbvTw/PHqkcXOLwrMVfwHYcezJph
	 xTFNa5p6VRbimKiIr5yr6J6xwXkQYhgeUX4ZioJfibILKY5smkAGe7eNC+xnmeR6vK
	 bKTRlY5/MYgeV51CeQdHkwLuI7m8PELV4Shy/aJpc4TDe3UnWuuBcRJoUYDeaZqYow
	 dOLgI0S7jRfSg==
Date: Tue, 12 Oct 2021 17:49:24 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Jan Beulich <jbeulich@suse.com>
cc: Luca Fancellu <luca.fancellu@arm.com>, 
    Bertrand Marquis <bertrand.marquis@arm.com>, wei.chen@arm.com, 
    Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, 
    Andrew Cooper <andrew.cooper3@citrix.com>, 
    George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>, 
    Wei Liu <wl@xen.org>, xen-devel@lists.xenproject.org
Subject: Re: [PATCH v6 1/2] arm/efi: Use dom0less configuration when using
 EFI boot
In-Reply-To: <0bae71a5-4637-d2a6-ddcc-3497e22470f1@suse.com>
Message-ID: <alpine.DEB.2.21.2110121312070.9408@sstabellini-ThinkPad-T480s>
References: <20211011181528.17367-1-luca.fancellu@arm.com> <20211011181528.17367-2-luca.fancellu@arm.com> <f29c8062-8430-6e08-7d4b-02096a6b049f@suse.com> <4FFFB177-883F-44DE-BF7E-53137AA7F0CB@arm.com> <0bae71a5-4637-d2a6-ddcc-3497e22470f1@suse.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: multipart/mixed; BOUNDARY="8323329-1637701801-1634069552=:9408"
Content-ID: <alpine.DEB.2.21.2110121312340.9408@sstabellini-ThinkPad-T480s>

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-1637701801-1634069552=:9408
Content-Type: text/plain; CHARSET=UTF-8
Content-Transfer-Encoding: 8BIT
Content-ID: <alpine.DEB.2.21.2110121312341.9408@sstabellini-ThinkPad-T480s>

On Tue, 12 Oct 2021, Jan Beulich wrote:
> On 12.10.2021 11:05, Luca Fancellu wrote:
> >> On 12 Oct 2021, at 09:45, Jan Beulich <jbeulich@suse.com> wrote:
> >> On 11.10.2021 20:15, Luca Fancellu wrote:
> >>> --- a/xen/common/efi/boot.c
> >>> +++ b/xen/common/efi/boot.c
> >>> @@ -166,6 +166,13 @@ static void __init PrintErr(const CHAR16 *s)
> >>>     StdErr->OutputString(StdErr, (CHAR16 *)s );
> >>> }
> >>>
> >>> +#ifndef CONFIG_HAS_DEVICE_TREE
> >>> +static inline int __init efi_check_dt_boot(EFI_FILE_HANDLE dir_handle)
> >>
> >> Didn't we agree that you would drop "inline" from here?
> > 
> > Yes we did, really sorry I forgot to drop it, I’ll push another serie, given the inline
> > Dropped are you ok with the patch?
> 
> Well, yes - I had given my ack for it already.

I made this change on commit and added your ack.

FYI I gave my reviewed-by to patch #2. Patch #2 needs your ack as Luca
dropped it on v6.
--8323329-1637701801-1634069552=:9408--


From xen-devel-bounces@lists.xenproject.org Wed Oct 13 00:49:37 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 00:49:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.207800.363733 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maSSe-0007F8-Vk; Wed, 13 Oct 2021 00:49:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 207800.363733; Wed, 13 Oct 2021 00:49:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maSSe-0007Ev-SX; Wed, 13 Oct 2021 00:49:36 +0000
Received: by outflank-mailman (input) for mailman id 207800;
 Wed, 13 Oct 2021 00:49:35 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=XJnr=PB=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1maSSd-0007Df-GD
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 00:49:35 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id c9b7b038-96a2-40d5-9215-0f7840559761;
 Wed, 13 Oct 2021 00:49:34 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id E2FAE60EBB;
 Wed, 13 Oct 2021 00:49:33 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c9b7b038-96a2-40d5-9215-0f7840559761
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1634086174;
	bh=CO9TOBs1Oi47qCKKj5aVUPjZ/naSRD5F3CJr8EVo1oQ=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=G+qm9ZDczwZ+OkMS/bRtvMCTNaQtrdV+J5gzL5aL8Owr9cII34b0idiCULX624Vrv
	 Jx0xWGAY3ieWMbR6tfP4PCQz+T4h3SmAqk5TbTXlYVkf+uHiCkTrocugxaNiivls9f
	 WxmjDaRxg6nvcFtPQFoikE8NYbBYddD4swVwgJ5qIHprz5Uc77byQrby7/c5qek2JF
	 1CsBdA6qpuhZDj07xhqjZ/ENKKjf1Q4p7ZoLZkWJ/Y7ZI0S3HxD5gVji3z1epkcvfc
	 lyb/2PkSng6kBzqB8K2tFmWBnwQB3jw56698DERXqkRtXErW3xW3xvZEx6noOzDGfl
	 3HKujN1l4WqGw==
Date: Tue, 12 Oct 2021 17:49:32 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Julien Grall <julien@xen.org>
cc: Michal Orzel <michal.orzel@arm.com>, xen-devel@lists.xenproject.org, 
    Stefano Stabellini <sstabellini@kernel.org>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, bertrand.marquis@arm.com
Subject: Re: [PATCH v5 2/3] xen/arm: Check for PMU platform support
In-Reply-To: <6ea907cc-0e85-6d86-9219-837c2e98ec3d@xen.org>
Message-ID: <alpine.DEB.2.21.2110121527090.9408@sstabellini-ThinkPad-T480s>
References: <20211012081323.14141-1-michal.orzel@arm.com> <20211012081323.14141-3-michal.orzel@arm.com> <6ea907cc-0e85-6d86-9219-837c2e98ec3d@xen.org>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Tue, 12 Oct 2021, Julien Grall wrote:
> Hi Michal,
> 
> On 12/10/2021 09:13, Michal Orzel wrote:
> > ID_AA64DFR0_EL1/ID_DFR0_EL1 registers provide
> > information about PMU support. Replace structure
> > dbg64/dbg32 with a union and fill in all the
> > register fields according to document:
> > ARM Architecture Registers(DDI 0595, 2021-06).
> > 
> > Add macros boot_dbg_feature64/boot_dbg_feature32
> > to check for a debug feature. Add macro
> > cpu_has_pmu to check for PMU support.
> > Any value higher than 0 and less than 15 means
> > that PMU is supported (we do not care about its
> > version for now).
> > 
> > Signed-off-by: Michal Orzel <michal.orzel@arm.com>
> > Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
> > Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>
> > ---
> > Changes since v4:
> > -improve checks for PMU
> > Changes since v3:
> > -none
> > Changes since v2:
> > -none
> > Changes since v1:
> > -new in v2
> > ---
> >   xen/include/asm-arm/cpufeature.h | 51 ++++++++++++++++++++++++++++++--
> >   1 file changed, 49 insertions(+), 2 deletions(-)
> > 
> > diff --git a/xen/include/asm-arm/cpufeature.h
> > b/xen/include/asm-arm/cpufeature.h
> > index 5ca09b0bff..0ddf38858a 100644
> > --- a/xen/include/asm-arm/cpufeature.h
> > +++ b/xen/include/asm-arm/cpufeature.h
> > @@ -4,6 +4,7 @@
> >   #ifdef CONFIG_ARM_64
> >   #define cpu_feature64(c, feat)         ((c)->pfr64.feat)
> >   #define boot_cpu_feature64(feat)       (system_cpuinfo.pfr64.feat)
> > +#define boot_dbg_feature64(feat)       (system_cpuinfo.dbg64.feat)
> >     #define cpu_feature64_has_el0_32(c)    (cpu_feature64(c, el0) == 2)
> >   @@ -22,6 +23,7 @@
> >     #define cpu_feature32(c, feat)         ((c)->pfr32.feat)
> >   #define boot_cpu_feature32(feat)       (system_cpuinfo.pfr32.feat)
> > +#define boot_dbg_feature32(feat)       (system_cpuinfo.dbg32.feat)
> >     #define cpu_has_arm       (boot_cpu_feature32(arm) == 1)
> >   #define cpu_has_thumb     (boot_cpu_feature32(thumb) >= 1)
> > @@ -32,8 +34,12 @@
> >     #ifdef CONFIG_ARM_32
> >   #define cpu_has_gentimer  (boot_cpu_feature32(gentimer) == 1)
> > +#define cpu_has_pmu       ((boot_dbg_feature32(perfmon) >= 1) && \
> > +                           (boot_dbg_feature32(perfmon) < 15))
> 
> So I am happy with this check for arm32. But I would still like to have a
> comment explaining the fact that on Armv7 perfmon == 0 may mean PMUv1 is may
> be used. Something like:
> 
> "On Armv7, the value 0 is used to indicate that PMUv2 is not supported. IOW
> this doesn't tell us whether the PMU is not supported (a processor may
> implement PMUv1).
> 
> For convenience, we treat 0 as not supported which this match the meaning on
> Armv8".
> 
> The rest of the code looks fine to me.

I made the change on commit


From xen-devel-bounces@lists.xenproject.org Wed Oct 13 00:55:04 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 00:55:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.207819.363744 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maSXr-0000Vi-JV; Wed, 13 Oct 2021 00:54:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 207819.363744; Wed, 13 Oct 2021 00:54:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maSXr-0000Vb-GR; Wed, 13 Oct 2021 00:54:59 +0000
Received: by outflank-mailman (input) for mailman id 207819;
 Wed, 13 Oct 2021 00:54:57 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=/sAh=PB=kernel.org=sashal@srs-us1.protection.inumbo.net>)
 id 1maSXp-0000VV-TF
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 00:54:57 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 2f2b17dc-2bc0-11ec-815a-12813bfff9fa;
 Wed, 13 Oct 2021 00:54:57 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id 433E560FDA;
 Wed, 13 Oct 2021 00:54:55 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2f2b17dc-2bc0-11ec-815a-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1634086496;
	bh=rhCEe1YAL5L+0Vhv2XSfVCZXHV0jEo7p42ZhTme8rzA=;
	h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
	b=nacIF5CJW/Pbz0pqNMB+pqUzuXPi75sfwqYy7d7uMMph+VXFQdSFUGV4elxUiLzOH
	 suIcFT5xKKR8ukI/2FwtxiuOllro0L9RqtNyfFxLy0e9f7PJh5JFsArcMmfY32SJzi
	 tErlqd0WxJCV+lHAJ1YYg1zmuGWTwc8/W0J1i4K39gUXj/+Pc5nNQ2Vz4YZL2PHxCD
	 k1jhyaqIRjzGs0klBS3jFT1I9xuI1naGy5wIMW+PQU3MMNDk+TvFXVYCBnMCkuZBx2
	 q61zu1fJRekvgodNsdoR6vnKsB80AigiuCaMl5KmeeGPOEAWl6aU+oUTFRDT+1l+gx
	 GySAupZ5GiyWw==
From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org,
	stable@vger.kernel.org
Cc: Jan Beulich <jbeulich@suse.com>,
	Juergen Gross <jgross@suse.com>,
	Sasha Levin <sashal@kernel.org>,
	boris.ostrovsky@oracle.com,
	tglx@linutronix.de,
	mingo@redhat.com,
	bp@alien8.de,
	x86@kernel.org,
	xen-devel@lists.xenproject.org
Subject: [PATCH AUTOSEL 5.14 06/17] xen/x86: prevent PVH type from getting clobbered
Date: Tue, 12 Oct 2021 20:54:30 -0400
Message-Id: <20211013005441.699846-6-sashal@kernel.org>
X-Mailer: git-send-email 2.33.0
In-Reply-To: <20211013005441.699846-1-sashal@kernel.org>
References: <20211013005441.699846-1-sashal@kernel.org>
MIME-Version: 1.0
X-stable: review
X-Patchwork-Hint: Ignore
Content-Transfer-Encoding: 8bit

From: Jan Beulich <jbeulich@suse.com>

[ Upstream commit 9172b5c4a778da1f855b2e3780b1afabb3cfd523 ]

Like xen_start_flags, xen_domain_type gets set before .bss gets cleared.
Hence this variable also needs to be prevented from getting put in .bss,
which is possible because XEN_NATIVE is an enumerator evaluating to
zero. Any use prior to init_hvm_pv_info() setting the variable again
would lead to wrong decisions; one such case is xenboot_console_setup()
when called as a result of "earlyprintk=xen".

Use __ro_after_init as more applicable than either __section(".data") or
__read_mostly.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Juergen Gross <jgross@suse.com>

Link: https://lore.kernel.org/r/d301677b-6f22-5ae6-bd36-458e1f323d0b@suse.com
Signed-off-by: Juergen Gross <jgross@suse.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
 arch/x86/xen/enlighten.c | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/arch/x86/xen/enlighten.c b/arch/x86/xen/enlighten.c
index c79bd0af2e8c..f252faf5028f 100644
--- a/arch/x86/xen/enlighten.c
+++ b/arch/x86/xen/enlighten.c
@@ -52,9 +52,6 @@ DEFINE_PER_CPU(struct vcpu_info, xen_vcpu_info);
 DEFINE_PER_CPU(uint32_t, xen_vcpu_id);
 EXPORT_PER_CPU_SYMBOL(xen_vcpu_id);
 
-enum xen_domain_type xen_domain_type = XEN_NATIVE;
-EXPORT_SYMBOL_GPL(xen_domain_type);
-
 unsigned long *machine_to_phys_mapping = (void *)MACH2PHYS_VIRT_START;
 EXPORT_SYMBOL(machine_to_phys_mapping);
 unsigned long  machine_to_phys_nr;
@@ -69,9 +66,11 @@ __read_mostly int xen_have_vector_callback;
 EXPORT_SYMBOL_GPL(xen_have_vector_callback);
 
 /*
- * NB: needs to live in .data because it's used by xen_prepare_pvh which runs
- * before clearing the bss.
+ * NB: These need to live in .data or alike because they're used by
+ * xen_prepare_pvh() which runs before clearing the bss.
  */
+enum xen_domain_type __ro_after_init xen_domain_type = XEN_NATIVE;
+EXPORT_SYMBOL_GPL(xen_domain_type);
 uint32_t xen_start_flags __section(".data") = 0;
 EXPORT_SYMBOL(xen_start_flags);
 
-- 
2.33.0



From xen-devel-bounces@lists.xenproject.org Wed Oct 13 00:55:44 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 00:55:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.207828.363766 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maSYa-0001ET-1j; Wed, 13 Oct 2021 00:55:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 207828.363766; Wed, 13 Oct 2021 00:55:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maSYZ-0001EM-Uy; Wed, 13 Oct 2021 00:55:43 +0000
Received: by outflank-mailman (input) for mailman id 207828;
 Wed, 13 Oct 2021 00:55:43 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=/sAh=PB=kernel.org=sashal@srs-us1.protection.inumbo.net>)
 id 1maSYZ-0001EE-E1
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 00:55:43 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 89b1dc24-b5e2-463f-ba1c-53df36477a53;
 Wed, 13 Oct 2021 00:55:42 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id F226261039;
 Wed, 13 Oct 2021 00:55:40 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 89b1dc24-b5e2-463f-ba1c-53df36477a53
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1634086542;
	bh=n1tTSWQDnZCGccnS6zBfI+YWb3yAxp76XfmkA1dlrOQ=;
	h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
	b=GpFJDcVEH43iEE/AqkAslB9mWUnB+TepZtBYDlqP/usuJrQHekz0MlJVGq/KpgcI3
	 0qNu0NN8ObkJsCIBWri/KevJM4Nvr9oYxg32KQP0U6Xy9h+C+0B4t22fDPa/Z+CH8R
	 sdivdPIQuicTn//VNUGz/c8WDp+rPE66eWCSzbbfSHKAvU5n+MuukZbr/EShVOheWv
	 OtpxIjiRDLnXqxrnp69j7P1GD4qanhdV6cF3p/5gwCnYZt+OKxQAN0LzSgFzLMbGvd
	 HCvXuvxvdc83cN0hjlFJR/OlPTzPRiMPUdqKQSQJdZvVKb+O+aQgA843r1JVtvGtVS
	 9j6DrJ9G4yhfA==
From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org,
	stable@vger.kernel.org
Cc: Jan Beulich <jbeulich@suse.com>,
	Juergen Gross <jgross@suse.com>,
	Sasha Levin <sashal@kernel.org>,
	boris.ostrovsky@oracle.com,
	tglx@linutronix.de,
	mingo@redhat.com,
	bp@alien8.de,
	x86@kernel.org,
	xen-devel@lists.xenproject.org
Subject: [PATCH AUTOSEL 5.10 05/11] xen/x86: prevent PVH type from getting clobbered
Date: Tue, 12 Oct 2021 20:55:25 -0400
Message-Id: <20211013005532.700190-5-sashal@kernel.org>
X-Mailer: git-send-email 2.33.0
In-Reply-To: <20211013005532.700190-1-sashal@kernel.org>
References: <20211013005532.700190-1-sashal@kernel.org>
MIME-Version: 1.0
X-stable: review
X-Patchwork-Hint: Ignore
Content-Transfer-Encoding: 8bit

From: Jan Beulich <jbeulich@suse.com>

[ Upstream commit 9172b5c4a778da1f855b2e3780b1afabb3cfd523 ]

Like xen_start_flags, xen_domain_type gets set before .bss gets cleared.
Hence this variable also needs to be prevented from getting put in .bss,
which is possible because XEN_NATIVE is an enumerator evaluating to
zero. Any use prior to init_hvm_pv_info() setting the variable again
would lead to wrong decisions; one such case is xenboot_console_setup()
when called as a result of "earlyprintk=xen".

Use __ro_after_init as more applicable than either __section(".data") or
__read_mostly.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Juergen Gross <jgross@suse.com>

Link: https://lore.kernel.org/r/d301677b-6f22-5ae6-bd36-458e1f323d0b@suse.com
Signed-off-by: Juergen Gross <jgross@suse.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
 arch/x86/xen/enlighten.c | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/arch/x86/xen/enlighten.c b/arch/x86/xen/enlighten.c
index aa9f50fccc5d..0f68c6da7382 100644
--- a/arch/x86/xen/enlighten.c
+++ b/arch/x86/xen/enlighten.c
@@ -51,9 +51,6 @@ DEFINE_PER_CPU(struct vcpu_info, xen_vcpu_info);
 DEFINE_PER_CPU(uint32_t, xen_vcpu_id);
 EXPORT_PER_CPU_SYMBOL(xen_vcpu_id);
 
-enum xen_domain_type xen_domain_type = XEN_NATIVE;
-EXPORT_SYMBOL_GPL(xen_domain_type);
-
 unsigned long *machine_to_phys_mapping = (void *)MACH2PHYS_VIRT_START;
 EXPORT_SYMBOL(machine_to_phys_mapping);
 unsigned long  machine_to_phys_nr;
@@ -68,9 +65,11 @@ __read_mostly int xen_have_vector_callback;
 EXPORT_SYMBOL_GPL(xen_have_vector_callback);
 
 /*
- * NB: needs to live in .data because it's used by xen_prepare_pvh which runs
- * before clearing the bss.
+ * NB: These need to live in .data or alike because they're used by
+ * xen_prepare_pvh() which runs before clearing the bss.
  */
+enum xen_domain_type __ro_after_init xen_domain_type = XEN_NATIVE;
+EXPORT_SYMBOL_GPL(xen_domain_type);
 uint32_t xen_start_flags __section(".data") = 0;
 EXPORT_SYMBOL(xen_start_flags);
 
-- 
2.33.0



From xen-devel-bounces@lists.xenproject.org Wed Oct 13 01:21:03 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 01:21:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.207841.363777 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maSwp-0006Vm-2t; Wed, 13 Oct 2021 01:20:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 207841.363777; Wed, 13 Oct 2021 01:20:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maSwo-0006Vf-W7; Wed, 13 Oct 2021 01:20:46 +0000
Received: by outflank-mailman (input) for mailman id 207841;
 Wed, 13 Oct 2021 01:20:45 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1maSwn-0006VV-9U; Wed, 13 Oct 2021 01:20:45 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1maSwm-0008NP-VC; Wed, 13 Oct 2021 01:20:45 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1maSwm-0006Ks-KP; Wed, 13 Oct 2021 01:20:44 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1maSwm-00082D-Jr; Wed, 13 Oct 2021 01:20:44 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=07tvgJJf6kgwmYw5p8wug/uXfFRUqNek1WXRwjxJZqA=; b=GdrWIgD0Fe0kjXzcvCw5fbYYwA
	2qEB7HZp7aCHqI2QjyJZ1WmxNdMDBLz7hUYLcv+IQ6vkO+M8PH6/0F4jmII3vc1fD8J5/HYx8VoSO
	aDFJvYBCf0TTFNJ+9ZIClmVJfK+30VnNCqf3vE9JDb7FAu5VQRVWVoAm0IsbxrLHgvEE=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165476-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-5.4 test] 165476: regressions - FAIL
X-Osstest-Failures:
    linux-5.4:test-armhf-armhf-xl-credit1:guest-start:fail:regression
    linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=faaca480fd5cd1976b6db743c43ac1f8d583de72
X-Osstest-Versions-That:
    linux=e74e2950a0d6f800858e54860d7124c86e494f62
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 13 Oct 2021 01:20:44 +0000

flight 165476 linux-5.4 real [real]
flight 165484 linux-5.4 real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/165476/
http://logs.test-lab.xenproject.org/osstest/logs/165484/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-armhf-armhf-xl-credit1  14 guest-start              fail REGR. vs. 165206

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165206
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 165206
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 165206
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 165206
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165206
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165206
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 165206
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 165206
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 165206
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 165206
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 165206
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 165206
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 linux                faaca480fd5cd1976b6db743c43ac1f8d583de72
baseline version:
 linux                e74e2950a0d6f800858e54860d7124c86e494f62

Last test of basis   165206  2021-09-26 12:42:13 Z   16 days
Failing since        165346  2021-10-04 12:42:32 Z    8 days   12 attempts
Testing same since   165449  2021-10-09 23:12:14 Z    3 days    6 attempts

------------------------------------------------------------
People who touched revisions under test:
  Alan Stern <stern@rowland.harvard.edu>
  Alex Deucher <alexander.deucher@amd.com>
  Alexei Starovoitov <ast@kernel.org>
  Anand K Mistry <amistry@google.com>
  Anders Roxell <anders.roxell@linaro.org>
  Andrea Claudi <aclaudi@redhat.com>
  Andreas Larsson <andreas@gaisler.com>
  Andrej Shadura <andrew.shadura@collabora.co.uk>
  Andrew Morton <akpm@linux-foundation.org>
  Andy Shevchenko <andriy.shevchenko@linux.intel.com>
  Anirudh Rayabharam <mail@anirudhrb.com>
  Anson Jacob <Anson.Jacob@amd.com>
  Antoine Tenart <atenart@kernel.org>
  Anton Eidelman <anton.eidelman@gmail.com>
  Anton Eidelman <anton@lightbitslabs.com>
  Ariel Elior <aelior@marvell.com>
  Arnd Bergmann <arnd@arndb.de>
  Aswath Govindraju <a-govindraju@ti.com>
  Aya Levin <ayal@nvidia.com>
  Baokun Li <libaokun1@huawei.com>
  Bartosz Golaszewski <brgl@bgdev.pl>
  Bixuan Cui <cuibixuan@huawei.com>
  Bjorn Helgaas <bhelgaas@google.com>
  Borislav Petkov <bp@suse.de>
  Carlo Lobrano <c.lobrano@gmail.com>
  Catalin Marinas <catalin.marinas@arm.com>
  Changbin Du <changbin.du@gmail.com>
  Charlene Liu <Charlene.Liu@amd.com>
  Chen Jingwen <chenjingwen6@huawei.com>
  Chih-Kang Chang <gary.chang@realtek.com>
  Chris Chiu <chris.chiu@canonical.com>
  Christian Brauner <christian.brauner@ubuntu.com>
  Christoph Hellwig <hch@lst.de>
  Claudiu Manoil <claudiu.manoil@nxp.com>
  Cong Wang <cong.wang@bytedance.com>
  Dan Carpenter <dan.carpenter@oracle.com>
  Dan Li <ashimida@linux.alibaba.com>
  Dan Williams <dan.j.williams@intel.com>
  Daniel Borkmann <daniel@iogearbox.net>
  Daniel Lezcano <daniel.lezcano@linaro.org>
  Daniel Wheeler <daniel.wheeler@amd.com>
  David Howells <dhowells@redhat.com>
  David S. Miller <davem@davemloft.net>
  David Sterba <dsterba@suse.com>
  Dmitry Bogdanov <d.bogdanov@yadro.com>
  Dongliang Mu <mudongliangabcd@gmail.com>
  Eric Biggers <ebiggers@google.com>
  Eric Dumazet <edumazet@google.com>
  F.A. SULAIMAN <asha.16@itfac.mrt.ac.lk>
  F.A.Sulaiman <asha.16@itfac.mrt.ac.lk>
  Faizel K B <faizel.kb@dicortech.com>
  Fares Mehanna <faresx@amazon.de>
  Felipe Balbi <balbi@kernel.org>
  Florian Fainelli <f.fainelli@gmail.com>
  Gao Xiang <hsiangkao@linux.alibaba.com>
  Geert Uytterhoeven <geert@linux-m68k.org>
  Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  Gregory CLEMENT <gregory.clement@bootlin.com>
  Guangbin Huang <huangguangbin2@huawei.com>
  Guenter Roeck <linux@roeck-us.net>
  Hans de Goede <hdegoede@redhat.com>
  Helge Deller <deller@gmx.de>
  Herbert Xu <herbert@gondor.apana.org.au>
  Hulk Robot <hulkrobot@huawei.com>
  Igor Matheus Andrade Torrente <igormtorrente@gmail.com>
  J. Bruce Fields <bfields@redhat.com>
  Jacob Keller <jacob.e.keller@intel.com>
  James Morse <james.morse@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Jan Kara <jack@suse.cz>
  Jeffle Xu <jefflexu@linux.alibaba.com>
  Jens Axboe <axboe@kernel.dk>
  Jesper Nilsson <jesper.nilsson@axis.com>
  Jian Shen <shenjian15@huawei.com>
  Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
  Jiri Benc <jbenc@redhat.com>
  Jiri Kosina <jkosina@suse.cz>
  Jiri Slaby <jslaby@suse.cz>
  Johan Hovold <johan@kernel.org>
  Johannes Berg <johannes.berg@intel.com>
  Johannes Thumshirn <jth@kernel.org>
  John Allen <john.allen@amd.com>
  Jon Hunter <jonathanh@nvidia.com>
  Jonathan Hsu <jonathan.hsu@mediatek.com>
  Jozsef Kadlecsik <kadlec@netfilter.org>
  Juergen Gross <jgross@suse.com>
  Julian Anastasov <ja@ssi.bg>
  Julian Sikorski <belegdol+github@gmail.com>
  Julian Sikorski <belegdol@gmail.com>
  Kaige Fu <kaige.fu@linux.alibaba.com>
  Kan Liang <kan.liang@linux.intel.com>
  Karsten Graul <kgraul@linux.ibm.com>
  Kate Hsuan <hpa@redhat.com>
  Kevin Hao <haokexin@gmail.com>
  Kishon Vijay Abraham I <kishon@ti.com>
  Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
  Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
  Leon Yu <leoyu@nvidia.com>
  Li Jinlin <lijinlin3@huawei.com>
  Li Zhijian <lizhijian@cn.fujitsu.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Linux Kernel Functional Testing <lkft@linaro.org>
  Lorenzo Bianconi <lorenzo@kernel.org>
  Marc Zyngier <maz@kernel.org>
  Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
  Mark Rutland <mark.rutland@arm.com>
  Markus Suvanto <markus.suvanto@gmail.com>
  Martin K. Petersen <martin.petersen@oracle.com>
  Michael Chan <michael.chan@broadcom.com>
  Michael Chan <michael.chan@broadocm.com>
  Michal Kalderon <mkalderon@marvell.com>
  Minas Harutyunyan <Minas.Harutyunyan@synopsys.com>
  Ming Lei <ming.lei@redhat.com>
  Moritz Fischer <mdf@kernel.org>
  Nadezda Lutovinova <lutovinova@ispras.ru>
  Nicolas Ferre <nicolas.ferre@microchip.com>
  Nirmoy Das <nirmoy.das@amd.com>
  Oliver Neukum <oneukum@suse.com>
  Ondrej Zary <linux@zary.sk>
  Ovidiu Panait <ovidiu.panait@windriver.com>
  Pablo Neira Ayuso <pablo@netfilter.org>
  Pali Rohár <pali@kernel.org>
  Paolo Bonzini <pbonzini@redhat.com>
  Paul Fertser <fercerpav@gmail.com>
  Pawel Laszczak <pawell@cadence.com>
  Peter Zijlstra (Intel) <peterz@infradead.org>
  Ping-Ke Shih <pkshih@realtek.com>
  Qu Wenruo <wqu@suse.com>
  Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
  Randy Dunlap <rdunlap@infradead.org>
  Rik van Riel <riel@surriel.com>
  Ritesh Harjani <riteshh@linux.ibm.com>
  Rob Herring <robh@kernel.org>
  Ronnie Sahlberg <lsahlber@redhat.com>
  Sai Krishna Potthuri <lakshmi.sai.krishna.potthuri@xilinx.com>
  Samuel Iglesias Gonsalvez <siglesias@igalia.com>
  Sasha Levin <sashal@kernel.org>
  Sergey Senozhatsky <senozhatsky@chromium.org>
  Shai Malin <smalin@marvell.com>
  Shuah Khan <skhan@linuxfoundation.org>
  Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
  Simon Horman <horms@verge.net.au>
  Slark Xiao <slark_xiao@163.com>
  Song Liu <songliubraving@fb.com>
  Srinivas Pandruvada <srinivas.pI andruvada@linux.intel.com>
  Steve French <stfrench@microsoft.com>
  Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
  sumiyawang <sumiyawang@tencent.com>
  syzbot+47b26cd837ececfc666d@syzkaller.appspotmail.com
  syzbot+fadc0aaf497e6a493b9f@syzkaller.appspotmail.com
  Tariq Toukan <tariqt@nvidia.com>
  Tejun Heo <tj@kernel.org>
  Theodore Ts'o <tytso@mit.edu>
  Todd Kjos <tkjos@google.com>
  Tom Rix <trix@redhat.com>
  Tong Zhang <ztong0001@gmail.com>
  Tony Nguyen <anthony.l.nguyen@intel.com>
  Tyler Hicks <tyhicks@linux.microsoft.com>
  Uwe Brandt <uwe.brandt@gmail.com>
  Vadim Pasternak <vadimp@nvidia.com>
  Viresh Kumar <viresh.kumar@linaro.org>
  Vlad Buslov <vladbu@nvidia.com>
  Vladimir Oltean <vladimir.oltean@nxp.com>
  Wen Xiong <wenxiong@linux.ibm.com>
  Wengang Wang <wen.gang.wang@oracle.com>
  Xiao Liang <shaw.leon@gmail.com>
  Xin Long <lucien.xin@gmail.com>
  Yang Yingliang <yangyingliang@huawei.com>
  yangerkun <yangerkun@huawei.com>
  Yonghong Song <yhs@fb.com>
  Zelin Deng <zelin.deng@linux.alibaba.com>
  zhang kai <zhangkaiheb@126.com>
  Zhihao Cheng <chengzhihao1@huawei.com>
  Zong-Zhe Yang <kevin_yang@realtek.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 4201 lines long.)


From xen-devel-bounces@lists.xenproject.org Wed Oct 13 02:57:09 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 02:57:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.207852.363792 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maURp-0006ol-R3; Wed, 13 Oct 2021 02:56:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 207852.363792; Wed, 13 Oct 2021 02:56:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maURp-0006oe-M6; Wed, 13 Oct 2021 02:56:53 +0000
Received: by outflank-mailman (input) for mailman id 207852;
 Wed, 13 Oct 2021 02:56:52 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1maURo-0006oU-L6; Wed, 13 Oct 2021 02:56:52 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1maURo-0001vl-Gq; Wed, 13 Oct 2021 02:56:52 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1maURo-0003V3-8B; Wed, 13 Oct 2021 02:56:52 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1maURo-0005Eo-5h; Wed, 13 Oct 2021 02:56:52 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=vGwhKysWQEDkWG41o0SZkEIqFJg7kAZgHtWeAjXCoIY=; b=ePaA5TcRYRL3XuC7nYrp2/mJOk
	ff/NWtCvQ2coc4mj5e1ScVzsgwI4SKO9kMoFPp2v+yMiH0Uh9hFeUDiuxXJZG6tQC6mp3pj9IDDOs
	Ar/+rUdO1PPfgSzCsCRVv73DPcEBPt6N87/TupWD6WAq6wdYNoqlK6oTuQyc6w2hdt8M=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165477-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 165477: tolerable FAIL - PUSHED
X-Osstest-Failures:
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=81d8537cb297d57b0897797f1329e4d755a0eaf4
X-Osstest-Versions-That:
    qemuu=c09124dcb8401a0d635b4a52b295e9b3fc12392a
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 13 Oct 2021 02:56:52 +0000

flight 165477 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165477/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165468
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165468
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 165468
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 165468
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 165468
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 165468
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 165468
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165468
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 qemuu                81d8537cb297d57b0897797f1329e4d755a0eaf4
baseline version:
 qemuu                c09124dcb8401a0d635b4a52b295e9b3fc12392a

Last test of basis   165468  2021-10-11 18:37:55 Z    1 days
Testing same since   165477  2021-10-12 13:37:56 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Jeffery <andrew@aj.id.au>
  Cédric Le Goater <clg@kaod.org>
  Peter Delevoryas <pdel@fb.com>
  Richard Henderson <richard.henderson@linaro.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/qemu-xen.git
   c09124dcb8..81d8537cb2  81d8537cb297d57b0897797f1329e4d755a0eaf4 -> upstream-tested


From xen-devel-bounces@lists.xenproject.org Wed Oct 13 04:40:53 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 04:40:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.207863.363805 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maW4G-0000El-M8; Wed, 13 Oct 2021 04:40:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 207863.363805; Wed, 13 Oct 2021 04:40:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maW4G-0000Ee-JC; Wed, 13 Oct 2021 04:40:40 +0000
Received: by outflank-mailman (input) for mailman id 207863;
 Wed, 13 Oct 2021 04:40:39 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1maW4F-0000EU-AN; Wed, 13 Oct 2021 04:40:39 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1maW4F-0003me-2K; Wed, 13 Oct 2021 04:40:39 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1maW4E-0000wL-R2; Wed, 13 Oct 2021 04:40:38 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1maW4E-0005mr-QY; Wed, 13 Oct 2021 04:40:38 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=fyF1D4eM0sYkn4pp9UcwT03FKSraPrR1G+jWvkfu0+o=; b=icaOiYgL7lZtg9o9UGA/Zczb8T
	wAD7ahn56xk8eDukWrZfZWjQ2gHT6eli640t8I53VwobjAeJClspLrX1Cx9LjBE+tLE0DSi5JSLR9
	kpRfKhErcRmKpEcOMC/X+zUIzgw6eLnzBjvcLlXZ4rXO+nxvAULI8kFeIH3nmBFIF7jo=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165485-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 165485: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=f9294486926c865a3ef11cacd7cb6b26cce6f4a4
X-Osstest-Versions-That:
    xen=eb7518b89be6df874ec9b2bafadeaaa7c874ea6b
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 13 Oct 2021 04:40:38 +0000

flight 165485 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165485/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  f9294486926c865a3ef11cacd7cb6b26cce6f4a4
baseline version:
 xen                  eb7518b89be6df874ec9b2bafadeaaa7c874ea6b

Last test of basis   165482  2021-10-12 19:02:46 Z    0 days
Testing same since   165485  2021-10-13 01:00:28 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Christian Lindig <christian.lindig@citrix.com>
  Ian Jackson <iwj@xenproject.org>
  Jan Beulich <jbeulich@suse.com>
  Luca Fancellu <luca.fancellu@arm.com>
  Michal Orzel <michal.orzel@arm.com>
  Nick Rosbrook <rosbrookn@ainfosec.com>
  Stefano Stabellini <stefano.stabellini@xilinx.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   eb7518b89b..f929448692  f9294486926c865a3ef11cacd7cb6b26cce6f4a4 -> smoke


From xen-devel-bounces@lists.xenproject.org Wed Oct 13 06:03:37 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 06:03:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.207874.363819 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maXMK-00085c-P0; Wed, 13 Oct 2021 06:03:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 207874.363819; Wed, 13 Oct 2021 06:03:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maXMK-00085V-Ln; Wed, 13 Oct 2021 06:03:24 +0000
Received: by outflank-mailman (input) for mailman id 207874;
 Wed, 13 Oct 2021 06:03:23 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=bU9L=PB=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1maXMJ-00085P-64
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 06:03:23 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id c8969714-e079-4361-ab7c-1bd9c387001b;
 Wed, 13 Oct 2021 06:03:22 +0000 (UTC)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2058.outbound.protection.outlook.com [104.47.13.58]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-15-lh6TXUGeNJ-h6LtxJU51eQ-1; Wed, 13 Oct 2021 08:03:19 +0200
Received: from AM0PR04MB5587.eurprd04.prod.outlook.com (2603:10a6:208:125::12)
 by AM8PR04MB7827.eurprd04.prod.outlook.com (2603:10a6:20b:247::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15; Wed, 13 Oct
 2021 06:03:18 +0000
Received: from AM0PR04MB5587.eurprd04.prod.outlook.com
 ([fe80::79a1:1c43:93d3:d136]) by AM0PR04MB5587.eurprd04.prod.outlook.com
 ([fe80::79a1:1c43:93d3:d136%6]) with mapi id 15.20.4587.027; Wed, 13 Oct 2021
 06:03:18 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6PR0502CA0045.eurprd05.prod.outlook.com (2603:10a6:20b:56::22) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.14 via Frontend
 Transport; Wed, 13 Oct 2021 06:03:17 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c8969714-e079-4361-ab7c-1bd9c387001b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634105000;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=u4pG7VayPm+u5jMzBACF1Bm/9rJgUS4ItFuoNWrmdhY=;
	b=Dc7SLlYz22Oi4ZhKuZZa8n4GTa/tniU5bimT3mqhIXtgdHu7YrW1Sb+SSFitJcMn3XBZnl
	+YgtxyYdyvKPmeh1dhBROoVuKfKpho6HkDDxT4OvchzLQYbKqTwFt4UtHzZ+LzLaY3L/7w
	/k6euBwXQo4p+f+8Kz28tx4s3V5U9uU=
X-MC-Unique: lh6TXUGeNJ-h6LtxJU51eQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ExC+72lwj2KESJRAySfbV6fFmrVEJRSHGcs1ig/BSkzjUIr2CsA28jTogXdEpcwCMu5A5GMslWMNTcBRu2foar7fbUtlzoXCNRZW84BYh3w+8CSC6/v47zeRKgqR9tiDwEiBcindflpqL1ZGnDk7kOzBd+Jy4f64L5+zkGR+IGNgwcVLmVurcOa7A/jPerwoJtgXygTg51eVJEd0KX41NXtP+QaEfzKK2DNZiGNgGoTFwItFl+nfDnCyy9E4/TNRadcyGU7nF/0Jehvea8+SG6yZ1QvaCpFRnmX5GEpXNiT5Kf2E5RvRwRPb0cDGXGNZgAVj4ARWUC6RB7Or42tUZQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=u4pG7VayPm+u5jMzBACF1Bm/9rJgUS4ItFuoNWrmdhY=;
 b=Z08FmuNkp7deKuUwnsfeQAcQaHwXQgXwjiQ3zzaV28BIhGlAqyQtZDKazATfDMq2k1lvuSE7Wu7R58hgGDrAdjXuyFodvHpz0D8ARobfmwgYW2J6hF7znY0eYejVA63VHWgopT1x2N+I3J6xaPFcu00390FXS0Oq3GbjmAwW13iDoQLMACDWUALTmCdmJuDZvvbQIHgpl57nbKxdpMzqLtsfefnGaWshG0x/FPYtuWe5ZQBygDwsZxucoQNbB3EgOVslhwBS0nLmbVDTY6MO88U/rBS0hErgFZx4rck05QabCLk+2Yr0RPBRXvQy2YglsS2koJIGIX9K2gxvUEXcMg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [PATCH xen 2/2] xen: update system time immediately when
 VCPUOP_register_vcpu_info
To: Dongli Zhang <dongli.zhang@oracle.com>
Cc: sstabellini@kernel.org, andrew.cooper3@citrix.com,
 george.dunlap@citrix.com, iwj@xenproject.org, julien@xen.org, wl@xen.org,
 joe.jin@oracle.com, xen-devel@lists.xenproject.org
References: <20211012072428.2569-1-dongli.zhang@oracle.com>
 <20211012072428.2569-3-dongli.zhang@oracle.com>
 <317163fa-f736-ccfe-40d4-b918ce2834f9@suse.com>
 <3e16648f-088d-5f62-03d7-ca744e913cbb@oracle.com>
 <8b31045b-dbb0-3ca1-074e-a12107b09159@suse.com>
 <b9599319-0bbf-94b9-2a0a-405cd9a225a6@oracle.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <228730b4-cb49-25b2-0c87-7943f2f5a6de@suse.com>
Date: Wed, 13 Oct 2021 08:03:16 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <b9599319-0bbf-94b9-2a0a-405cd9a225a6@oracle.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR0502CA0045.eurprd05.prod.outlook.com
 (2603:10a6:20b:56::22) To AM0PR04MB5587.eurprd04.prod.outlook.com
 (2603:10a6:208:125::12)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 2689f4fc-053a-44a0-c2ee-08d98e0f2706
X-MS-TrafficTypeDiagnostic: AM8PR04MB7827:
X-Microsoft-Antispam-PRVS:
	<AM8PR04MB78270D0FECDE0D6BBC12E238B3B79@AM8PR04MB7827.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7691;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	OdoeIYOfO9xzQ676cwiCz2owdMKABs+0rC4pVxC/F3MeyuM2sPjbS4B727rPLEdnv9uzQzvDzbdIhBMnPDeiPpmKEMWRzJgzbn/6HNP/M5styDv9e3PVmggoqS1obun/t2T+OTqnQ6N7Q+ZUXT8EyNmn5mia2KS+Dygo/BIFRr7k/t4HgbMhYkc22IeRvsD+k8IWCwAyHR05MpT0CsmFz8LcjjqaC+QfTbSbgBzza9SQCnnkgI6wRSQ9aPvnNCBuLRNXlIx/vJ1Litq3xKCOFuATyH4egQyCV+XoaZExG2qEBvWxP2Avs6bm2xcyOyQN3rJ/vW1xsvuAcx3MXD4m/I8uzWMbxTIJDK6r58v41rZ2bhartxqaQGLSJ1Vs0q4AR6A5oT6HhHYvn3SpGfqTZ58UeLqXjyYSjyPA9IStIlqnBbAM3oA+6CRWVYLVckNsHUKYZSliSEK5wBMPCakNEQldhpdqUEXJmJ+ffmixHyhJPOCMEbWoCSpKe/uvlLwfaZmHUk/tsAQkYLt04ZVK4dKOtswvoCN5YDXxtw5K3DgVt1rScswNM/rh9lDihJGXVlQ0q5Ch+pKnhs08i4/E+qXaZ9V2B4dVLD8GH8LLfhRJM/teMyvDa4X3p0cPDjChqStImbq6JsvVR52typyuyhJIlRbb0ZSHYkXdzi5M1Z5FIf4uoJZsZ+HH9nFFi+uLdeRUEJwqWvaMK1Yp0gR6Rt7Tkqz75jy4P9IS4j0R/SKi1SgnXbjxcnCZ1SIvh0YqtvnurYfNYB5zyiGBno7EVBTEecsPyJUpamNHgWcDxY0=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR04MB5587.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(31686004)(36756003)(38100700002)(5660300002)(66556008)(6916009)(66476007)(66946007)(86362001)(316002)(31696002)(508600001)(2906002)(4326008)(2616005)(53546011)(16576012)(186003)(6486002)(956004)(83380400001)(8936002)(15650500001)(26005)(8676002)(14773001)(21314003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?bkVnNUVyQnZrdzJjejJ6WHVjM0tpWENwdExERXY5VE1BWDFIYjhMby9aenF2?=
 =?utf-8?B?SmlsMTRFaEpETjkxaFJncnkzY2tyNVNOZCtHRVR5Zk9FbzVualNFMnYwREpm?=
 =?utf-8?B?OEhRR1IxNWN5YzZJemQ4cllxS0l1cy9qTERERVNxQlZySzhvUEVUTWlnM2wr?=
 =?utf-8?B?M2w1N1JKM3hhRkRXNUFtZVRmZDRyTGpSSHkvc0FWeFBRMmh4QngrYUJMMDQ4?=
 =?utf-8?B?NWhrR21CbEZnalZqYnhFdk1nUWZXSCt4dEg5VHZ4d2JrMzE2ampBS0pTMWFC?=
 =?utf-8?B?RG4zeFNncW9mR2I1NXduNnJXNGkxSzlOMGsxVlprNVYxV2xoWnBSdnhRTjZu?=
 =?utf-8?B?bUFocW5mTkN6ZXJDcEYzV01veHh0VVZEUlh5WnROTzVmMnhEY2prMGE2Wndy?=
 =?utf-8?B?U2FlV1QxYUthT2xlTUE0S1VvUjhFd2dWUncwa0dJUDdMQkNmTmxYK05wTlpW?=
 =?utf-8?B?UVA1VnhZQ1ZnYnFzQ0NqYkx4RVBWY3dxMlJWRWNQN2g2bjYrdnRqcWRrTHpq?=
 =?utf-8?B?V3dENmY0SjdVbFloWTA0UTIrTE9kT2hUNkkxaWh4bHI5QkVvc1kwMlFjSE1S?=
 =?utf-8?B?RVd2ZnE5WG5sUVlpWE5YNmdYcUxhK2R0TWVLQjUyYXBkV3hvVEY2WmhoS0R0?=
 =?utf-8?B?TzZqUW5QMDFSMWwzMG9lNDU4b242eHRYSHVXdWdrVDR6SEZVZDVpWkFkN2RM?=
 =?utf-8?B?WTlSaHhVZzVxYk5kZlBWTDNTVXBjY0FrZDVja0Z3MnlpbWw0VlVtWXB5aWZz?=
 =?utf-8?B?UVN4cUdKVVlTZU95Wlg3ZGZPamN0VWNzM1loTXNGVVBFdjFNVGFsU0l1aUE0?=
 =?utf-8?B?LytLOU5XZmxnYWxoMU9Vd2tYSjhQNjBHNmROaEd5VTBzbzAyZjBhMTE3NEsr?=
 =?utf-8?B?QTdGb21VUTZMaEhiS25YL1pnWnFlMWZRbzVJRllrSGtTeVJpSjVaRDBLU3Rn?=
 =?utf-8?B?MDRnWHRtcUhiODFGUWxEdXEwQlVyWTBGeFZyTDB3Mk43aFJsQTd2TUZNMHBJ?=
 =?utf-8?B?elNZYTR3dXlaY0dxdUtGWFRUSEVrWVp2c1hWeXoyeVRLWjJkYW9QamdvWC9o?=
 =?utf-8?B?aVd6cGJXVmxXUWNKY1Jlc2dUWC9SMzdEZlZUU2ZERGd5Z0tNa21zMjFWL3N2?=
 =?utf-8?B?UDRzWWcxRVFHZ1NOOGVoSkJwZG1LTm4xZXdnN1hJK001QW5NREVyNkNXeDk1?=
 =?utf-8?B?d2J4WG9JT04wVGZFNzljc1ZkajJMK2hKVjZ4NVgwU3VhZjJGY0Naa053WHpS?=
 =?utf-8?B?SllLNXlwT0srdkpyM3hneFRXZE5YeTZsMTY0dmxNeWZ3NW9UVzl1N29lWjNM?=
 =?utf-8?B?eGlrUW50Y1dWSW1sMW9CT01OR3E1di93UFkxNWNkS2NBWkhFSUJ0cDVqU0h4?=
 =?utf-8?B?T1dXM0tWVHhlWHR5dngvSnQ5MWRMbW5zVTNKWWc3aGg0Uk9Md3JLa29BOXZG?=
 =?utf-8?B?a3RKSmhFVkc2SndRUnBwNXh2cnJJK0tIblkrRU03OTgrSHlIYUMwZm5JbE5K?=
 =?utf-8?B?WnliaElaMGkvMm1zY2lyY3BrM3d4ODRncWpCVmtuWlh0RldEWjI0S1YwVFpu?=
 =?utf-8?B?YkhhQ2JaZWgxL2tOMkY4QU5jOXpGR3RqSHBUbDhac3ZTTTVvTFRsYnEybEpP?=
 =?utf-8?B?b05UNHROYSt5SThUdytBNlR1akEvS0IvK3k0TEJUSGdkS3VmR2wzRzgrbWtj?=
 =?utf-8?B?MXl0and4UnZGVldnOGdRekNZSllCaWNaZlRkSFpZZ1QrVHB0SExmZklXZFdo?=
 =?utf-8?Q?xJfG8KkD9wHtsbYT8dUwjokHS1V70UOu8WyJsRy?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2689f4fc-053a-44a0-c2ee-08d98e0f2706
X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB5587.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2021 06:03:18.1073
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: iF3zEkQzMRxpAC1T7qHo6ZGI60ktxZfskNynzE0f42FFDhM+7m+Fb/WNlS86+gvoQIFVO0t7YCFgytlS9ZP0RQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7827

On 12.10.2021 18:15, Dongli Zhang wrote:
> Hi Jan,
> 
> On 10/12/21 8:49 AM, Jan Beulich wrote:
>> On 12.10.2021 17:43, Dongli Zhang wrote:
>>> Hi Jan,
>>>
>>> On 10/12/21 1:40 AM, Jan Beulich wrote:
>>>> On 12.10.2021 09:24, Dongli Zhang wrote:
>>>>> The guest may access the pv vcpu_time_info immediately after
>>>>> VCPUOP_register_vcpu_info. This is to borrow the idea of
>>>>> VCPUOP_register_vcpu_time_memory_area, where the
>>>>> force_update_vcpu_system_time() is called immediately when the new memory
>>>>> area is registered.
>>>>>
>>>>> Otherwise, we may observe clock drift at the VM side if the VM accesses
>>>>> the clocksource immediately after VCPUOP_register_vcpu_info().
>>>>>
>>>>> Cc: Joe Jin <joe.jin@oracle.com>
>>>>> Signed-off-by: Dongli Zhang <dongli.zhang@oracle.com>
>>>>
>>>> While I agree with the change in principle, ...
>>>>
>>>>> --- a/xen/common/domain.c
>>>>> +++ b/xen/common/domain.c
>>>>> @@ -1695,6 +1695,8 @@ long do_vcpu_op(int cmd, unsigned int vcpuid, XEN_GUEST_HANDLE_PARAM(void) arg)
>>>>>          rc = map_vcpu_info(v, info.mfn, info.offset);
>>>>>          domain_unlock(d);
>>>>>  
>>>>> +        force_update_vcpu_system_time(v);
>>>>
>>>> ... I'm afraid you're breaking the Arm build here. Arm will first need
>>>> to gain this function.
>>>>
>>>
>>> Since I am not familiar with the Xen ARM, would you please let me your
>>> suggestion if I just leave ARM as TODO to the ARM developers to verify
>>> and implement force_update_vcpu_system_time()?
>>
>> I'd much prefer to avoid this. I don't think the function can be that
>> difficult to introduce. And I'm sure the Arm maintainers will apply
>> extra care during review if you point out that you weren't able to
>> actually test this.
>>
> 
> I do not see pvclock used by arm/arm64 in linux kernel for xen.
> 
> In addition, the implementation at xen hypervisor side is empty.
> 
> 348 /* VCPU PV clock. */
> 349 void update_vcpu_system_time(struct vcpu *v)
> 350 {
> 351     /* XXX update shared_info->wc_* */
> 352 }
> 
> I will add a wrapper for it.
> 
> The bad thing is I see riscv is supported by xen and we may need to add the
> function for riscv as well.

There's not really any code for RISC-V yet, so that'll be of concern to
those who are working on adding actual code later on. I'm actually
wondering about the status of that effort - after the initial bits were
added over 3 months ago, no further activity has been visible.

Jan



From xen-devel-bounces@lists.xenproject.org Wed Oct 13 06:05:43 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 06:05:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.207872.363831 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maXOZ-0000Gh-5Y; Wed, 13 Oct 2021 06:05:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 207872.363831; Wed, 13 Oct 2021 06:05:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maXOZ-0000GZ-2l; Wed, 13 Oct 2021 06:05:43 +0000
Received: by outflank-mailman (input) for mailman id 207872;
 Wed, 13 Oct 2021 05:56:59 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Y9pJ=PB=greensocs.com=mark.burton@srs-us1.protection.inumbo.net>)
 id 1maXG6-0007CH-St
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 05:56:59 +0000
Received: from beetle.greensocs.com (unknown [5.135.226.135])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 633c6259-a640-4e30-a52d-1bfa3dca2c2a;
 Wed, 13 Oct 2021 05:56:55 +0000 (UTC)
Received: from smtpclient.apple (unknown [54.37.16.242])
 by beetle.greensocs.com (Postfix) with ESMTPSA id 0BDBE21A8F;
 Wed, 13 Oct 2021 05:56:51 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 633c6259-a640-4e30-a52d-1bfa3dca2c2a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=greensocs.com;
	s=mail; t=1634104613;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=NmENBHpmx11BFYuaIRMqtVJxSEZwgv5Rg+5FKo1F1EU=;
	b=n8qFCNPvW+tem6mfNDqDAmYlqDScNkjpLwuFa5/eMVeB897n3G/Iy6YDCjRDfpwRN+d8+N
	geHeGCltVaRzoIWe7y4h9fUXaxq7y7ZABps9lIectcz9ioLN7YvuhvnRpypSJHcMSU0Ycr
	c/GRrbwgYzaWkXZ+CyTPcRX2Q2M1tDI=
Content-Type: text/plain;
	charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.13\))
Subject: Re: [RFC PATCH v2 00/16] Initial support for machine creation via QMP
From: Mark Burton <mark.burton@greensocs.com>
In-Reply-To: <CAKmqyKMUvtRPCp=FJMHcMdsECfJ_fRHBi4dA2N3gtqmPHspNJA@mail.gmail.com>
Date: Wed, 13 Oct 2021 07:56:46 +0200
Cc: Damien Hedde <damien.hedde@greensocs.com>,
 "qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>,
 Peter Maydell <peter.maydell@linaro.org>,
 "Michael S. Tsirkin" <mst@redhat.com>,
 David Hildenbrand <david@redhat.com>,
 Peter Xu <peterx@redhat.com>,
 mirela.grujic@greensocs.com,
 Alistair Francis <Alistair.Francis@wdc.com>,
 Gerd Hoffmann <kraxel@redhat.com>,
 Ani Sinha <ani@anisinha.ca>,
 Eric Blake <eblake@redhat.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 "open list:X86" <xen-devel@lists.xenproject.org>,
 Paul Durrant <paul@xen.org>,
 Markus Armbruster <armbru@redhat.com>,
 Anthony Perard <anthony.perard@citrix.com>,
 =?utf-8?Q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>,
 Eduardo Habkost <ehabkost@redhat.com>,
 "Dr. David Alan Gilbert" <dgilbert@redhat.com>,
 Eric Auger <eric.auger@redhat.com>,
 Paolo Bonzini <pbonzini@redhat.com>,
 "open list:RISC-V" <qemu-riscv@nongnu.org>,
 =?utf-8?B?IkRhbmllbCBQLiBCZXJyYW5nw6ki?= <berrange@redhat.com>,
 Edgar Iglesias <edgari@xilinx.com>,
 Igor Mammedov <imammedo@redhat.com>
Content-Transfer-Encoding: quoted-printable
Message-Id: <D12EA69C-A1CC-4132-89F8-499D7F99F34C@greensocs.com>
References: <20210922161405.140018-1-damien.hedde@greensocs.com>
 <CAKmqyKMUvtRPCp=FJMHcMdsECfJ_fRHBi4dA2N3gtqmPHspNJA@mail.gmail.com>
To: Alistair Francis <alistair23@gmail.com>
X-Mailer: Apple Mail (2.3654.120.0.1.13)

Fixed
Cheers
Mark.


> On 13 Oct 2021, at 00:16, Alistair Francis <alistair23@gmail.com> =
wrote:
>=20
> On Thu, Sep 23, 2021 at 2:22 AM Damien Hedde =
<damien.hedde@greensocs.com> wrote:
>>=20
>> Hi,
>>=20
>> The goal of this work is to bring dynamic machine creation to QEMU:
>> we want to setup a machine without compiling a specific machine C
>> code. It would ease supporting highly configurable platforms (for
>> example resulting from an automated design flow). The requirements
>> for such configuration include begin able to specify the number of
>> cores, available peripherals, emmory mapping, IRQ mapping, etc.
>>=20
>> This series focuses on the first step: populating a machine with
>> devices during its creation. We propose patches to support this
>> using QMP commands. This is a working set of patches and improves
>> over the earlier rfc (posted in May):
>> https://lists.gnu.org/archive/html/qemu-devel/2021-05/msg03706.html
>>=20
>> Although it is working and could be merged, it is tag as an RFC:
>> we probably need to discuss the conditions for allowing a device to
>> be created at an early stage. Patches 6, 10 and 13, 15 and 16 depend
>> on such conditions and are subject to change. Other patches are
>> unrelated to this point.
>>=20
>> We address several issues in this series. They are detailed below.
>>=20
>> ## 1. Stoping QEMU to populate the machine with devices
>>=20
>> QEMU goes through several steps (called _machine phases_) when
>> creating the machine: 'no-machine', 'machine-created',
>> 'accel-created', 'initialized', and finally 'ready'. At 'ready'
>> phase, QEMU is ready to start (see Paolo's page
>> https://wiki.qemu.org/User:Paolo_Bonzini/Machine_init_sequence for
>> more details).
>>=20
>> Using the -preconfig CLI option, QEMU can be stopped today during
>> the 'accel-created' phase. Then the 'x-exit-preconfig' QMP command
>> triggers QEMU moving forwards to the completion of the machine
>> creation ('ready' phase).
>>=20
>> The devices are created during the 'initialized' phase.
>> In this phase the machine init() method has been executed and thus
>> machine properties have been handled. Although the sysbus exists and
>> the machine may have been populated by the init(),
>> _machine_init_done_ notifiers have not been called yet. At this point
>> we can add more devices to a machine.
>>=20
>> We propose to add 2 QMP commands:
>> + The 'query-machine-phase' command would return the current machine
>>  phase.
>> + The 'x-machine-init' command would advance the machine phase to
>>  'initialized'. 'x-exit-preconfig' could then still be used to
>>  advance to the last phase.
>>=20
>> ## 2. Adding devices
>>=20
>> Right now, the user can create devices in 2 ways: using '-device' CLI
>> option or 'device_add' QMP command. Both are executed after the
>> machine is ready: such devices are hot-plugged. We propose to allow
>> 'device_add' QMP command to be used during the 'initialized' phase.
>>=20
>> In this series, we keep the constraint that the device must be
>> 'user-creatable' (this is a device class flag). We do not see any
>> reason why a device the user can hot-plug could not be created at an
>> earlier stage.
>>=20
>> This part is still RFC because, as Peter mentioned it (in this thread
>> https://lists.gnu.org/archive/html/qemu-devel/2021-08/msg01933.html),
>> we may want additional or distinct conditions for:
>> + device we can hot-plug
>> + device we can add in '-preconfig' (cold-plug)
>> We are open to suggestions. We could for example add a
>> 'preconfig-creatable' or 'init-creatable' flag to device class, which
>> can identify a set of devices we can create this way.
>>=20
>> The main addition is how we handle the case of sysbus devices. Sysbus
>> devices are particular because unlike, for example, pci devices, you
>> have to manually handle the memory mapping and interrupts wiring. So
>> right now, a sysbus device is dynamically creatable (using -device
>> CLI option or device_add QMP command) only if:
>> + it is 'user_creatable' (like any other device),
>> + and it is in the current machine sysbus device allow list.
>>=20
>> In this series, we propose to relax the second constraint during the
>> earlier phases of machine creation so that when using -preconfig we
>> can create any 'user-creatable' sysbus device. When the machine
>> progresses to the 'ready' phase, sysbus devices creation will come
>> back to the legacy behavior: it will be possible only based on the
>> per-machine authorization basis.
>>=20
>> For sysbus devices, wiring interrupts is not a problem as we can use
>> the 'qom-set' QMP command, but memory mapping is.
>>=20
>> ## 3. Memory mapping
>>=20
>> There is no point allowing the creation sysbus devices if we cannot
>> map them onto the memory bus (the 'sysbus').
>>=20
>> As far as we know, right now, there is no way to add memory mapping
>> for sysbus device using QMP commands. We propose a =
'x-sysbus-mmio-map'
>> command to do this. This command would only be allowed during the
>> 'initialized' phase when using -preconfig.
>>=20
>> ## 4. Working example
>>=20
>> The last patches of the series add and modify devices in order to
>> build a working machine starting from the 'none' machine.
>>=20
>> We add a new sysbus device modeling a simple memory (ram or rom). We
>> also set 'user-creatable' flag of some sysbus devices. These are
>> trivial patches, but they depends on the conditions we choose to =
allow
>> creating devices with -preconfig. Therefore, there is really no need
>> to review them until we settled on the device conditions first.
>>=20
>> With these devices (memory, ibex_uart, ibex_plic) we can dynamically
>> configure a part (we did not add the timer, but we could) the
>> opentitan machine very easily and run firmwares which demonstrates
>> interrupts and memory-mapping are working.
>>=20
>> We use the existing qmp-shell script to issue machine devices
>> from a qmp commands script file which contains qmp commands listed in
>> a file.
>>=20
>> The following qmp commands add some memories, an interrupt controller
>> and an uart with an interrupt.
>>=20
>> cat > opentitan.qmp <<EOF
>> x-machine-init
>>=20
>> # ROM 0x00008000
>> device_add        driver=3Dsysbus-memory id=3Drom size=3D0x4000 =
readonly=3Dtrue
>> x-sysbus-mmio-map device=3Drom addr=3D32768
>>=20
>> # FLASH 0x20000000
>> device_add        driver=3Dsysbus-memory id=3Dflash size=3D0x80000 =
readonly=3Dtrue
>> x-sysbus-mmio-map device=3Dflash addr=3D536870912
>>=20
>> # RAM 0x10000000
>> device_add        driver=3Dsysbus-memory id=3Dram size=3D0x10000
>> x-sysbus-mmio-map device=3Dram addr=3D268435456
>>=20
>> # PLIC 0x41010000
>> device_add        driver=3Dibex-plic id=3Dplic
>> x-sysbus-mmio-map device=3Dplic addr=3D1090584576
>>=20
>> # UART 0x40000000
>> device_add        driver=3Dibex-uart id=3Duart chardev=3Dserial0
>> x-sysbus-mmio-map device=3Duart addr=3D1073741824
>> qom-set path=3Duart property=3Dsysbus-irq[1] =
value=3Dplic/unnamed-gpio-in[2]
>>=20
>> x-exit-preconfig
>> EOF
>>=20
>> We've put the opentitan.qmp and a firmware opentitan-echo.elf here
>> (among some other qmp machine files we are working on):
>> https://github.com/GreenSocs/qemu-qmp-machines
>=20
> I am unable to access this repo, maybe it's not public?
>=20
> Alistair



From xen-devel-bounces@lists.xenproject.org Wed Oct 13 06:10:44 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 06:10:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.207890.363842 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maXTM-0001hi-P5; Wed, 13 Oct 2021 06:10:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 207890.363842; Wed, 13 Oct 2021 06:10:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maXTM-0001hb-Lv; Wed, 13 Oct 2021 06:10:40 +0000
Received: by outflank-mailman (input) for mailman id 207890;
 Wed, 13 Oct 2021 06:10:39 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=bU9L=PB=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1maXTL-0001hV-Dz
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 06:10:39 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 48aba1fa-2bec-11ec-8160-12813bfff9fa;
 Wed, 13 Oct 2021 06:10:38 +0000 (UTC)
Received: from EUR02-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur02lp2057.outbound.protection.outlook.com [104.47.6.57]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-38-u_8kKY1pNV-ejMcavAC6Vw-1; Wed, 13 Oct 2021 08:10:34 +0200
Received: from AM0PR04MB5587.eurprd04.prod.outlook.com (2603:10a6:208:125::12)
 by AM0PR04MB5905.eurprd04.prod.outlook.com (2603:10a6:208:125::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.22; Wed, 13 Oct
 2021 06:10:32 +0000
Received: from AM0PR04MB5587.eurprd04.prod.outlook.com
 ([fe80::79a1:1c43:93d3:d136]) by AM0PR04MB5587.eurprd04.prod.outlook.com
 ([fe80::79a1:1c43:93d3:d136%6]) with mapi id 15.20.4587.027; Wed, 13 Oct 2021
 06:10:32 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS8PR04CA0062.eurprd04.prod.outlook.com (2603:10a6:20b:313::7) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4587.25 via Frontend Transport; Wed, 13 Oct 2021 06:10:31 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 48aba1fa-2bec-11ec-8160-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634105437;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=UPvW0alhaeN1fEesfffuVnvDNBcasXEl2o+PRj1zBn0=;
	b=h3/LY9xVoEERvocKYYOUILVWpiIAQc6VxfD0i/XIjnIqH8FF3R4CunP/LJgLu7zxgkpMOh
	uboQq94rkGBbgUH6vfdMPOjePSWx91qux6+fSiceTurn7TETviiRamxzapu95y3RuDNDwb
	5DoyiHGYd/fv0Hcz9WlD82IvAk/ruZ4=
X-MC-Unique: u_8kKY1pNV-ejMcavAC6Vw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=eRvtUz+3UkhjMmIWPFkIjvMD6QbBHaA4hPwsP4c9GrWJwMDUuNzejulnRBKykMZQML6ZCPJgT6IdcpWrfdROEnG8hAGBAGnk+4Mg0QdHgvbCAc3RHo81pb8Ov/b9Qhq4mhdsgBTtjPV4G17R3SF7W9TiickbnGg+ZS+ujnpnnLey0JyYidvjTprHoT2Rxd1cKgRJioRoLrOnMQY8S9dVrriaxVVbOYxuGE6hB89PkINTZodw84sFcviQd8qN/fR2sfhhzu72jbex9XDV33UxweMbH8luFMPIEA2rHopFIGB7ybO0vNGSecesR8OLD+CRHY7NJt3nKY29OjJrBDjTWA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=UPvW0alhaeN1fEesfffuVnvDNBcasXEl2o+PRj1zBn0=;
 b=QYzdPJHncT73gi7JLMsILAsobtf6rjrYFi/Y9Ti9Xi4vZu192jlVfRlgpF+j+FEahNMIxw1/qDiMXrOr+hLGY4YT9/Q0jKNpaeEfmF9woXaBZq3At4klOZRellLitJkX19nlZAEFBT/jHTy27V0Lu+Oc9l2uDYndF5H1iB346sc0M3zrR0vQqiURkU7HlR/rlzoW79h89BhISwniLG6HNHgTY4xa55lUjhLMfJbBmah53B1fQsW7qN8qEsJT2T9MR8q8DwbMaNnXEhNtacwc7Pn074DaN0fWi0forr/f8tSSiT5kTiV3kG6IdCIAhy0O/wWGv+S+eTfSFLYI9QuJyA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [PATCH v5 08/11] xen/arm: Enable the existing x86 virtual PCI
 support for ARM.
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: Bertrand Marquis <Bertrand.Marquis@arm.com>,
 Rahul Singh <Rahul.Singh@arm.com>, Andre Przywara <Andre.Przywara@arm.com>,
 Julien Grall <julien@xen.org>, Volodymyr Babchuk
 <Volodymyr_Babchuk@epam.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Wei Liu <wl@xen.org>, Paul Durrant <paul@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <cover.1633540842.git.rahul.singh@arm.com>
 <9bdca2cda5d2e83f94dc2423e55714273539760a.1633540842.git.rahul.singh@arm.com>
 <6752f2d3-171b-37f5-c809-82995a8f3f36@suse.com>
 <CEF7FFB0-779A-4F46-8667-6BCD9BA5CB6C@arm.com>
 <b735c2d3-1dbb-ce0a-c2fa-160d4c6938d3@suse.com>
 <A8DEBD07-FB45-4E4E-A2C3-7AF8B393B032@arm.com>
 <59c9e102-c710-64d3-2a1a-cc8dcbcceead@suse.com>
 <alpine.DEB.2.21.2110111105180.25528@sstabellini-ThinkPad-T480s>
 <2fa4d2e2-7daf-6d52-ff4c-38a482af1fb9@suse.com>
 <alpine.DEB.2.21.2110121436020.9408@sstabellini-ThinkPad-T480s>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <f15de716-4c4f-47b8-b6ba-ea549c61369c@suse.com>
Date: Wed, 13 Oct 2021 08:10:30 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <alpine.DEB.2.21.2110121436020.9408@sstabellini-ThinkPad-T480s>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8PR04CA0062.eurprd04.prod.outlook.com
 (2603:10a6:20b:313::7) To AM0PR04MB5587.eurprd04.prod.outlook.com
 (2603:10a6:208:125::12)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 0af34b8b-2bfb-4ee1-f24a-08d98e102a12
X-MS-TrafficTypeDiagnostic: AM0PR04MB5905:
X-Microsoft-Antispam-PRVS:
	<AM0PR04MB5905FFAD2E644624D6228435B3B79@AM0PR04MB5905.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	nGMv6r+CBDo0q/WCOUPULTGhfbjxAMMrc72Dm1booYrZuhibgj6uBlT27uv3ct5f9x5YYOOyDu/35xIg58tlNbiYOpZIDwTl2A3L4Iy6xLC+KqYw/x6eYG2JnU/IBw+M+jSphr8i2BPLtOU5M6lZUODYJ8lMEQ+JWfGlUkUbEwMivqOKpfvwzqWweHsUE7tsQnIv4P75jzdvXN82bbBFhmh1afUHs331aRmK65FUPhZzqPum3ZwxBGhWSfAmtR5MFUygJPHvXTicwa1vcu32s7GORrzNF6FvOzAIkMB/b1fEFPpbW6+0SjXLS1Ye+4qU+AwobhLyJyaBIhv8hPsS7dl8RTJKntP1atbIN7s/Q6o3c79E7H5S36K4MWmXz6fNMRf8sqb/GNPPBr0QKoM8NIDNI+EHQAnaLYb7J1qGIOANhkwxi4sjwaNR6J0ntXjB7dCdk8jHk7nU7O/V83F6oTkMFI2odKoT/tWTf6kgZ9feoj8+hYDvvzlXqUps4HbPTlIUBzqxUp+7wNIILplQLsiY7/lB0uHAp+VcE/QLKhBA21g0bdvMSEZLKmvuqdgqrMBB82YfrAT5GkRK7j5W8UkbYMXruhUiznQGFldd6OPgd0sjqcV0LfPX+dzZJtM25d3EW8H6ZfLpOnLcPDzfms4fjz9vYpkxsWgV5S074nmqixN8fF3SEoS5xMTOFbcK/1MRhZ2kncraltx7xbTLZGlwGbB9lAS9+YUl3AZwo6HAXkAgT8KhQZgUu1hWz6Ju
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR04MB5587.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(4326008)(186003)(8936002)(86362001)(956004)(6916009)(316002)(16576012)(31686004)(6486002)(7416002)(36756003)(54906003)(83380400001)(26005)(66946007)(31696002)(66556008)(66476007)(38100700002)(5660300002)(8676002)(508600001)(53546011)(2906002)(2616005)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?eTZ0cWxNRzgwR1h2MkR3dWNCRHc4RTJyNm5hVmlVVk1yVHZsdWlkUnJCZmZP?=
 =?utf-8?B?TWYrcUtXWUY5VG1iTVRucm5FRWRZQllNSGJLMTV3UjBBeVFLLzhzV2d1V3Z3?=
 =?utf-8?B?OVdtTFVrencyTGNjbm1KUFlGRXdhL29McjZKbS9NTUNzOTNPTitOMXZ3dVRK?=
 =?utf-8?B?cTkxTGZ0QytUcnN1alMxdkFPRVJEbjlXQzNOYVM2NmdFOE1wYWs0M0lHZjhK?=
 =?utf-8?B?YkNFVVBMcE11RE9vNzNOT01qTWdETVRXUC9EVDNVNWhIS3lDMk1hSVg3aUR0?=
 =?utf-8?B?VEVtSG83V2dZb2IwMW5MSnl6SWVwWjNma1NldGYrRE9zZWxjZlZxaVJPclB5?=
 =?utf-8?B?bzJGd3cyczY1L3czSVdmRENlWllmOUxVZjFiYnYwc0d5VGRwd2JaZDdTdUtQ?=
 =?utf-8?B?ejNuMVd6ZFRMT25Xc2ZHK3kyR20zMm1wblc4Si9vV21sOVVERytCUExTTmlV?=
 =?utf-8?B?ZTd0anNRaHkvQlJRU3V0NUcvRVRIK1dyUDdrK1BHU1VDNjFOV3VIdGxHbDFW?=
 =?utf-8?B?RmcwckE4ZFgvaXZ1SXdjVXZqaW5kc201bjY4OG9OdzVlcklFUlFiU2dFZTQz?=
 =?utf-8?B?VGl4U050V3BuVW9MekcxTTNuUE5DbXZtaUp5VGM0dWZZUUNTNGlRaFp5cHVU?=
 =?utf-8?B?cy81em1GZHFpMEZvaEtmazMrUmRwb1FFY0pBaW9Sbi9HUHQ2TTYydVhtQ0cz?=
 =?utf-8?B?TG1MMVdrSlF1VHlwanFlZkhTVnFsVFlLQWRQaXFad2RDSHJwcE43YmZ6S1I3?=
 =?utf-8?B?NWV3cE5TM2lGUmJtamZiQ2FibmJNNzhERHh2d0Jrd0s0UmpreFJhUFlHM1Vo?=
 =?utf-8?B?dkx5UlREZHZNZ3lQamM3b2tDTkRPN3cvVUpsUGhXbVIwNzkrQ1cwSTVrYytz?=
 =?utf-8?B?d0RlaVVaWkxORThEdWZDMFJ5RUdLL3NQT1VqZzlBRGdkMXI1UWNjUzJ0ZXV3?=
 =?utf-8?B?cEtGZ1lEN3Y5Nm9jeTFWVjRqdnBRdEhTTVplOW45Zld1QjU5eDVMSW1wVXV4?=
 =?utf-8?B?ZkRaK1hZTHQvbm9oWWdKUWhFV2s1MU1BbUZiVFdiTE9JRFh6TENnNWpZb2JG?=
 =?utf-8?B?azVxSkZaUStxTjYrOUdDL3dGODZPbFk4cDRpT0Q5YVg0cGlFTklNU3grSk5k?=
 =?utf-8?B?MERkbEZpWHF2RGNLVTM0R0JvcGpPcnYyM3IrZXBNT2dST0tVRHdIK0Y2V2Mz?=
 =?utf-8?B?ZXhJeEVUYVljTGtmV01BdUpra3FvMTh3K2FpSmJxbTZkL2VjZHA5WHQ1RlNJ?=
 =?utf-8?B?MEtUdW5TOTBMTVNvOElvRUtnOWJNNXdDQU1KeHpJekIwWnFScy9QZktpeFVk?=
 =?utf-8?B?ZS9OMkhUWUc5Q1pFSkxveHQzQzZvbHRCdHZUaUQ1OWtWT3lyZ3pYcVM4NHVG?=
 =?utf-8?B?ckhPTXhJNXFsYUQrN2JkNlR6M0tMN2dUN3ZVNXhLN2o3azIxYlFHcFpvYkpk?=
 =?utf-8?B?SEhTN3grRnhkZGlXL0ZJbzRCMVg0WFo1UkYvUkcyejhHZnJjbGIwMktZOVJV?=
 =?utf-8?B?L2RsaXlsSWJ2MW8vaFJoRmFQK3VCSGNJQ1lDUXhKc1RnclpGTm1JbEFDT1cx?=
 =?utf-8?B?VVUxT2JJdktDekl4T1FWVDI4MzdQVDFZQ29ZWmplZXhUQVFFVzQ1OG04WUtp?=
 =?utf-8?B?cGN6YWxpTVhkWmF6WTVkQkhlSnhYbkZkRG9OSVlyNzR3Rjh5dVB3NTlzbnZk?=
 =?utf-8?B?TFB5TlJtZXo5eWl4VFlvMUJOamlkYWFWZjRzeGxKVmJuRUt3K240V2JLUmJB?=
 =?utf-8?Q?kZIVEqDQOW0x1QKkYLuesbw+qUR+Gfv+/bXXC7G?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0af34b8b-2bfb-4ee1-f24a-08d98e102a12
X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB5587.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2021 06:10:32.7150
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 9BruSfMlj86zSlLa1Dr8a8xsmL8jwufpTccqDp1Vq1lE8sKg7JhRjHttOigYhREnyvdfD4GldIguG5fneveg0Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB5905

On 12.10.2021 23:37, Stefano Stabellini wrote:
> On Tue, 12 Oct 2021, Jan Beulich wrote:
>> On 11.10.2021 20:18, Stefano Stabellini wrote:
>>> On Mon, 11 Oct 2021, Jan Beulich wrote:
>>>> On 11.10.2021 15:34, Bertrand Marquis wrote:
>>>>>> On 11 Oct 2021, at 14:09, Jan Beulich <jbeulich@suse.com> wrote:
>>>>>> On 11.10.2021 14:41, Bertrand Marquis wrote:
>>>>>>> But digging deeper into this, I would have 2 questions:
>>>>>>>
>>>>>>> - msi_cleanup was done there after a request from Stefano, but is not
>>>>>>> done in case or iommu error, is there an issue to solve here ?
>>>>>>
>>>>>> Maybe, but I'm not sure. This very much depends on what a domain
>>>>>> could in principle do with a partly set-up device. Plus let's
>>>>>> not forget that we're talking of only Dom0 here (for now at least,
>>>>>> i.e. not considering the dom0less case).
>>>>>>
>>>>>> But I'd also like to further defer to Stefano.
>>>>>
>>>>> Ok, I must admit I do not really see at that stage why doing an MSI cleanup
>>>>> could be needed so I will wait for Stefano to know if I need to keep this when
>>>>> moving the block up (at the end it is theoretical right now as this is empty).
>>>
>>> I know that MSIs are not supported yet on ARM (pci_cleanup_msi does
>>> nothing). But I wanted to make sure that the pci_cleanup_msi() calls are
>>> present anywhere necessary, especially on the error paths. So that once
>>> we add MSI support, we don't need to search through the code to find all
>>> the error paths missing a pci_cleanup_msi() call.
>>>
>>> To answer your first question: you are right, we are also missing a
>>> pci_cleanup_msi() call in the case of IOMMU error. So it might be better
>>> to move the call to pci_cleanup_msi() under the "out" label so that we
>>> can do it once for both cases.
>>>
>>> To answer your second point about whether it is necessary at all: if
>>> MSIs and MSI-Xs cannot be already setup at this point at all (not even
>>> the enable bit), then we don't need any call to pci_cleanup_msi() in
>>> pci_add_device.
>>
>> Well, at the very least MSI can't be set up ahead of the traps getting
>> put in place. Whether partial success of putting traps in place may
>> allow a cunning guest to set up MSI may depend on further aspects.
> 
> Good point about MSIs not being setup before the traps. We should remove
> the call to pci_cleanup_msi() in the error path then.

Your reply makes me fear you didn't pay enough attention to the "partial"
in my earlier reply. The traps for the various registers can't all be set
up atomically, so there may be a transient period where enough traps are
already in place for a cunning guest to arrange for setup. Unless, as
said, there are further setup steps needed before a guest could succeed
in doing so.

But even if partial trap setup alone was sufficient, I think the cleaning
up of MSI then might still better go on the error path there than on that
of pci_add_device().

Jan



From xen-devel-bounces@lists.xenproject.org Wed Oct 13 06:19:03 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 06:19:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.207902.363852 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maXbO-0002Sl-O6; Wed, 13 Oct 2021 06:18:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 207902.363852; Wed, 13 Oct 2021 06:18:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maXbO-0002Se-LE; Wed, 13 Oct 2021 06:18:58 +0000
Received: by outflank-mailman (input) for mailman id 207902;
 Wed, 13 Oct 2021 06:18:56 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=bU9L=PB=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1maXbM-0002SY-R7
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 06:18:56 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 710cb944-2bed-11ec-8160-12813bfff9fa;
 Wed, 13 Oct 2021 06:18:55 +0000 (UTC)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2172.outbound.protection.outlook.com [104.47.17.172])
 (Using TLS) by relay.mimecast.com with ESMTP id
 de-mta-24-e9S8OCbtPNaEJs7DEAiQAw-2; Wed, 13 Oct 2021 08:18:53 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB6864.eurprd04.prod.outlook.com (2603:10a6:803:138::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.22; Wed, 13 Oct
 2021 06:18:51 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.016; Wed, 13 Oct 2021
 06:18:51 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS9PR06CA0168.eurprd06.prod.outlook.com (2603:10a6:20b:45c::20) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.14 via Frontend
 Transport; Wed, 13 Oct 2021 06:18:49 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 710cb944-2bed-11ec-8160-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634105934;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=WBG2AhPsSw/wGoQqBkcgFy1H6ahe2YGyvRRdFl47v9c=;
	b=HPpYZNA080aeGp9CcuS+mKAZw9hJqiQMBAWOOOIh+5Rrh8hzOd3Xret1gd3qs0ltAB5FwT
	3VEWLO2hgdszO6OWPSlUvv8xbyJ574l9zTkHl9HHhs72FqaW0ffq6SwT+Hlu+aibpFu1Ew
	Ut8xRGJdReqEFTWY+5i0cgvmBWp9Ljc=
X-MC-Unique: e9S8OCbtPNaEJs7DEAiQAw-2
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=AaQxwL8DvRLOH5SJ2P2roqGDq9z/+7LiurR5FYsUSOlMT71EaTtHdlbSiNDsPBZT3QELb18DUK0mA7RctaxY7wd+hcaxUUU4AzMPgDS8ukxIGDFWh8kcp+xMEKIQ4E0IitUmK+LSuF/MthY+C/dWKDov48lqXZIkuGzmB6rb3D+txN8YydHhx/DCHdAMA3o9vVv8UnCSDkN874LMe3GajLdFopX6trh/l7x5tA/ABkG4rqMecpmVrk4KBoT/RaS5u+CaytB/cjh8D90zK/8JZHQ6uJzPYB+RvgHDoYFM1kcMxfrjFghOP4RcvlX9zHM+mQaOivOMWw6ygWTN8mrSKQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=FJWFV56z5wpXuhni8G3GdSTKbqhWbOcPLQPkdQeET80=;
 b=gNavrNTQKrxLLZB/nBTBXwvPj+4KK6z85he0e1iPSiMgxF+ZI7ZrxcnJtWQ5kuTldR8mNdjJ54i617KdXsAs4h87NFuJ7iVlP3d+qh8UIs1b+HNyGVBiSWO2hPjL3o7DM20qq/Az5rRDCotyIFUO4RoNumbaJZV/C2KKqi+FhjSHU2B/4/FeKTZOm50FIHXl+5OZcK7IkL3d7ygRIj1HVvvK4nkmZTjJjZewZN7A70RSIdtQTXVsPe4ixiQ3mZnSE/oOEvn0jM1uU34Gf05X+UlHxoLdg+/IvvUK/u8KTM7zjKgLeqM8zpi9buMbS5zZ+qXnDRP1bMSGlyJ2M0iXmg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: citrix.com; dkim=none (message not signed)
 header.d=none;citrix.com; dmarc=none action=none header.from=suse.com;
Subject: Re: [PATCH v5 07/11] xen/domctl: Introduce XEN_DOMCTL_CDF_vpci flag
To: Stefano Stabellini <sstabellini@kernel.org>
CC: Rahul Singh <rahul.singh@arm.com>, xen-devel@lists.xenproject.org,
 bertrand.marquis@arm.com, Andre.Przywara@arm.com,
 Christian Lindig <christian.lindig@citrix.com>, David Scott
 <dave@recoil.org>, Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <cover.1633540842.git.rahul.singh@arm.com>
 <20d5b9d6a0d01a7b90711d28cbefb5701a88b438.1633540842.git.rahul.singh@arm.com>
 <YWQDguvmf/O4rDIs@MacBook-Air-de-Roger.local>
 <alpine.DEB.2.21.2110121439100.9408@sstabellini-ThinkPad-T480s>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <44eae5c0-28a0-590a-07c6-6b411b23ebc3@suse.com>
Date: Wed, 13 Oct 2021 08:18:48 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <alpine.DEB.2.21.2110121439100.9408@sstabellini-ThinkPad-T480s>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS9PR06CA0168.eurprd06.prod.outlook.com
 (2603:10a6:20b:45c::20) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: c696db9e-ea1d-4b6b-d640-08d98e11531b
X-MS-TrafficTypeDiagnostic: VI1PR04MB6864:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB68642E998AE8DAC4232FF3FBB3B79@VI1PR04MB6864.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	cWjOufo8rMyAQw6ET15ETJ+zKVbEqPbXlB5YsB7qt8V+xisiL1UL9b6NEJUQutGj6jcFGIvYJsi00Z5UAaKHcRZ+8+2+FKGZjFrbFhFsVBo+yGvUtA2gmfTRavpmpBXe1u537ctN3Qrc8u9MWnZ41gWBt1AL7XDl8mqebvgIF06cjGIrmH0gLwh/JoMubAAf80Spd+xU59MCO73C835JctTRTJCp3pczvqyKcnlsWqY24XHGD0Dlr2eTCy7qkzdLqtZzugEOuicPqlA/GYnuRHpEcKkrOfUkEicbswAUr2pHwkM11n3J63HZBsElxhMmVcTmXZtRk7ixDqIXDNZfZpTKDjtqRZ9z6zxJ1F6Dyyn6p+ikEMZAsXgFRZUvY0R2SVw826ghJfVFLxrSWJkB2ZXprBZQqlrraGcYygYp64O14LB9pt/79TL/CVh7BcQl3dPGYfy54NM5+D+VJUxjKJsyEMhj6eCoayYMeLkfIiJZmMW1xVuvdU2LeFsoQ0ccIUTVph1JKETienv1tTY+CDeJJ8HrLt6BpdKd5/L7JYpl4//xHmbLUjPOWz+V1mJvLDAbgoqni441eBojsSA+YrhQdJf1ofTZx/x6iy6xZ4XOfB2p00hYc7cu3II7nqovwBLm9dGRxvq0ZP/U4xHVwYtYEpaSE7jdCYgfVhx1nN07fW7NXM9I08Cq+LX1fJPjkVYpGR1u1R/Km7lnDdiS8KaqUdYYwtOTcJKeHYHbp6s=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(16576012)(31696002)(53546011)(8676002)(316002)(7416002)(8936002)(38100700002)(956004)(2616005)(508600001)(5660300002)(4326008)(54906003)(31686004)(6916009)(26005)(2906002)(186003)(6486002)(86362001)(36756003)(66476007)(66556008)(66946007)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?HQyZJ4q5fDDRe5WMIHKSbyE+o9CtYv5rvEPXbtFbiDeHZUUwvHuHJnyqOe47?=
 =?us-ascii?Q?b67t3Hl9IlZ4A0vmCfXf//DgB53De+7H3L/ecYdG0kl/HKWTxw+g/CgNqdC/?=
 =?us-ascii?Q?LjD6xK2WBRcZPraEveTVea5atQlv44mJAaMnMjkFyRMdGB6J2jqbYY4Z6xfB?=
 =?us-ascii?Q?MYm/DPSit7FnILjmKtG02dfqlJoCLlfnsH1DMBMKb2YiBh8IMJwgNJ2AfZx/?=
 =?us-ascii?Q?qI1fZ7+9udcwe9Tp43bZDnMqasCALzvFT4lqtEj3j6umuxWhqDTuaamqyG7G?=
 =?us-ascii?Q?aw/8Gg+wKCQDeoQhiKvSdFjJ+liatv5QaxKz1ivePuDdx6QqTLXBbd+EBu/d?=
 =?us-ascii?Q?lGGxUpZvtda1Y7qN1SDD+0PAZC5QjcpfpC0L6UPOddSJjPzQoveVsCsUbvlq?=
 =?us-ascii?Q?XTtHnk8RvMblmcDhmhoQESYGazvWM3OArqhJ8EEOiItmFEZU5nQbIqShUzZE?=
 =?us-ascii?Q?56xPDBM+YVWEtJ3xUlUwvqX2JO1KP8VplMj+EB1ACYpa8uTXPny6s1mvQsyb?=
 =?us-ascii?Q?p8jhfysj3+CY2HvkCywd9bv9bZjHpoIxBOqJiOWb3QhOBQIW+CsVwUQfQR2r?=
 =?us-ascii?Q?xEpqaEr6kYR4EkcCxzONTAMlDOceH3B7jXZG/ydXpuAfblkXwhWOlRmizlgd?=
 =?us-ascii?Q?ANnFynEyqjkQ2nhv4vReUzhCmE5BEEOvODjvTOvb7gbbynCUNKNAhJF8PDB5?=
 =?us-ascii?Q?zV+cx/S9lEWIcbMehjNp1thnB+9povft7uUPVcPDw3XMbzFkMaXbIeEaNdbs?=
 =?us-ascii?Q?GJoqvaGK/2ivE/OvVuxiBkZZc0BL5TdoPPbGLeMzqmCjJ8rua79W96kx52Ey?=
 =?us-ascii?Q?jbJNexjtfjyYWfO2vTSqbkUy+P/SJUregrtC1t3/9y4pUj4XlGhNjt/69vai?=
 =?us-ascii?Q?x1jZCqljfsK5ZidZbEdsHD8WWTlK0z7ct9PIFu/6x4J38AkASY3PUAoT8Liy?=
 =?us-ascii?Q?c7wEBAu4QVA6l5wVz73lYeDqh3rnDBm6XP7XIcQ/vDoO/a+CDECdlIiWTUlz?=
 =?us-ascii?Q?HlzlPe7lqs+9izk7SILAQYzZgsgPpIyJuD9jYtoWUD3a3JLvMDWtSsiwqgJj?=
 =?us-ascii?Q?H5d3WVXhAQixyS4CQAhLCl+VRc8hbzqmEsWeN7M5FF/XplmgEub8FuAiAF50?=
 =?us-ascii?Q?DNeVHkaGuDsSlvkulpKc9c6M3AMRzKJfobP8qRFVyZFLoUYIsqcYqRgPolCY?=
 =?us-ascii?Q?QVyfg7LGx1v8UzuvpXa2FyrcnxhlV7O3eZ2EYBn7hQCTed+Fu5lP1Bfjw+NP?=
 =?us-ascii?Q?iGHcoP8+hYvsm6Mdukgk6BS1CKEr/VF19rtpCsib6MKyALNwvKmr+uuO5LKM?=
 =?us-ascii?Q?T1sc3+FvvcwzlVRlF4tiITTg?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c696db9e-ea1d-4b6b-d640-08d98e11531b
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2021 06:18:51.1086
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: IbbECVFzrh9iwqFksvZ3khKrtfBKonPYF+UXOMCkERL581HcMZrdFxjSU8tbL49AEMUReJFFNT6OSbnCUSV3ug==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6864

On 12.10.2021 23:48, Stefano Stabellini wrote:
> On Mon, 11 Oct 2021, Roger Pau Monn=C3=A9 wrote:
>> On Wed, Oct 06, 2021 at 06:40:33PM +0100, Rahul Singh wrote:
>>> Introduce XEN_DOMCTL_CDF_vpci flag to enable VPCI support in XEN.
>>> Reject the use of this new flag for x86 as VPCI is not supported for
>>> DOMU guests for x86.
>>
>> I don't like this approach, XEN_DOMCTL_CDF_vpci should be set for x86
>> PVH dom0, like we do for any other CDF flags when Xen builds dom0.
>>
>> Things like PVH vs PV get translated into CDF flags by create_dom0,
>> and processed normally by the sanitise_domain_config logic, vPCI
>> should be handled that way.
>>
>> Do you think you could see about fixing this?
>=20
> Andrew suggested to use XEN_SYSCTL_PHYSCAP_vpci to check whether we can
> set XEN_DOMCTL_CDF_vpci in libxl and it looks like we have consensus on
> this approach. [1][2]
>=20
> So it makes sense that XEN_DOMCTL_CDF_vpci is only set when
> XEN_SYSCTL_PHYSCAP_vpci is also set, i.e. XEN_SYSCTL_PHYSCAP_vpci =3D=3D
> XEN_DOMCTL_CDF_vpci.
>=20
> From [2], XEN_SYSCTL_PHYSCAP_vpci is not going to be set on x86, so then
> XEN_DOMCTL_CDF_vpci should also be left unset?
>=20
> If you think XEN_DOMCTL_CDF_vpci should be set for x86 PVH Dom0, then
> XEN_SYSCTL_PHYSCAP_vpci should also be set for x86 PVH Dom0.

Except that XEN_SYSCTL_PHYSCAP_vpci is not a domain specific attribute,
but a host-wide one.

Jan



From xen-devel-bounces@lists.xenproject.org Wed Oct 13 06:25:58 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 06:25:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.207910.363863 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maXi6-0003t3-Fi; Wed, 13 Oct 2021 06:25:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 207910.363863; Wed, 13 Oct 2021 06:25:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maXi6-0003sw-Ch; Wed, 13 Oct 2021 06:25:54 +0000
Received: by outflank-mailman (input) for mailman id 207910;
 Wed, 13 Oct 2021 06:25:53 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=bU9L=PB=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1maXi5-0003sq-BE
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 06:25:53 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 02431695-1bae-4eb2-9eae-32b61bdafbae;
 Wed, 13 Oct 2021 06:25:52 +0000 (UTC)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2050.outbound.protection.outlook.com [104.47.13.50]) (Using
 TLS) by relay.mimecast.com with ESMTP id de-mta-1-7rD2pkzxMTOHLAe0BsMDcw-1;
 Wed, 13 Oct 2021 08:25:50 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB4384.eurprd04.prod.outlook.com (2603:10a6:803:6f::26)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18; Wed, 13 Oct
 2021 06:25:47 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.016; Wed, 13 Oct 2021
 06:25:47 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6P193CA0109.EURP193.PROD.OUTLOOK.COM (2603:10a6:209:85::14) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4587.26 via Frontend Transport; Wed, 13 Oct 2021 06:25:46 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 02431695-1bae-4eb2-9eae-32b61bdafbae
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634106351;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=B+3POFdvLpomAMBnS1eMcdROs83NeAIJ4igxp/T0uAI=;
	b=YChTGmTD6KAb4tJj1yOw8ds+19QmtI1agOpSpV75tThKzSVtUOrJSEM663iuXv3j47zr+Z
	kFYpwRn6v0MEvsQQDkd7twqqdey1yMkmx95yRgZFrJaU11rJz/8jaNFd1NXgcEJzn0CVW8
	z5B+DQa54eTJtm/cslH2WUcrjXSeL2w=
X-MC-Unique: 7rD2pkzxMTOHLAe0BsMDcw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=N6217I+/QyWdOI70kZGwiUo13I9omTOkXEoGeJKZZrVsNNnZUcHsmQxP1+OVl0UjMLHHHfho2d9jtCa7AKwSetDEwjdNkqn7scOp9yOPLAVFCJAekcGQZ+dlRmUuHNssbySZhXjE9PSgrAzm909Z0dp+dMKr0j3sL5JKC2cZF5XWBzgmuiE06GT43cJNFJ1lPuI1MamMUplrOWmuN/qX8y9bOj9zTRuSfsPjeXzH9kf/DpT2KrbbiRyBJl7B/JpJjvFTXDNXzcoVB0IpMLy/7xuYD6N0fBT8QHG8gfxsAHAHTaVrzGfsprhNpto6X8/msCNfgWGuFXp+wUHbaMG+Sw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=bFTbnsRyJEJZmCKxS7q1WoWNblkm/H5Qc3AIUBrn/NA=;
 b=iBijJkh/Jr2CAU/cxGWKbo3gyPgjR38ZlCYI47gojnlWv191Xg1TclZvB0Bdo8o1HKmLVIuzERTQqRHYsHOeXYx/9QjEh69y8WSXJsc5ZN4aYm7Ml+1q+4q8DSBro2X6IbRYG8pI5OkjxduGWZF4j8YOYFcn1zh1SH3qV5d791VPJUW/roSPfuR6YO4SCb2jv8wKNHwlje6YMzYrhy3rPPMYgckA7pxtq2fOuY3Lh3U7/C60iQaP9Xrn8NdPO7t4kbDdclKPJUqYMyewlMp3vgKn0bEfODbBzJ0SyUNqD8dpCkm+bS9I1PaGMbxEbvb+bMCW5UGJncO5GDTPlb88Yw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: xen.org; dkim=none (message not signed)
 header.d=none;xen.org; dmarc=none action=none header.from=suse.com;
Subject: Re: [PATCH v6 2/2] arm/efi: load dom0 modules from DT using UEFI
To: Stefano Stabellini <sstabellini@kernel.org>,
 Luca Fancellu <luca.fancellu@arm.com>
CC: Julien Grall <julien@xen.org>, xen-devel@lists.xenproject.org,
 Bertrand Marquis <bertrand.marquis@arm.com>, wei.chen@arm.com,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Wei Liu <wl@xen.org>
References: <20211011181528.17367-1-luca.fancellu@arm.com>
 <20211011181528.17367-3-luca.fancellu@arm.com>
 <alpine.DEB.2.21.2110111243290.25528@sstabellini-ThinkPad-T480s>
 <EC7165F9-09CE-4001-93ED-FA637F5ED36C@arm.com>
 <alpine.DEB.2.21.2110111415350.25528@sstabellini-ThinkPad-T480s>
 <alpine.DEB.2.21.2110111423310.25528@sstabellini-ThinkPad-T480s>
 <29cc47f2-4727-0397-db0c-a6c1f5a52bf7@xen.org>
 <alpine.DEB.2.21.2110111813510.25528@sstabellini-ThinkPad-T480s>
 <81EA782B-762E-4B8A-8D33-EC79203439BC@arm.com>
 <alpine.DEB.2.21.2110121309560.9408@sstabellini-ThinkPad-T480s>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <696b9cef-9f9a-6285-bcd8-372e505fbb15@suse.com>
Date: Wed, 13 Oct 2021 08:25:45 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <alpine.DEB.2.21.2110121309560.9408@sstabellini-ThinkPad-T480s>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6P193CA0109.EURP193.PROD.OUTLOOK.COM
 (2603:10a6:209:85::14) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: b583e36c-98d0-4d14-00a8-08d98e124b5d
X-MS-TrafficTypeDiagnostic: VI1PR04MB4384:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB438416E31D2D649447F3B23FB3B79@VI1PR04MB4384.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	pJBXRSe7zGEcvW1rQZF6augzKvUcqU40MQDBJi6sfr1unkIikvvfWSy4n5jT2yFfq9h318SFREfnqeLF3UnF6ophI+PlRJWYo5B3WAaIM5gouuNsUXwH6lZoPxttk/feZrh2as34ZOQ/YkPuwe9nypCj16v/g7d3pTvplOhZ3rwRJ6qG+xt2+2pmiE0E3UNQCy2QkyKh+bQ4v9eRpwDSXD1azc9OXM8sUifEe5VrOwDCcpH/1b/Esi1mfkgCQYMX4IvPIAwY9z2vfMlpxvM2vKtDBnn6wIaX8YRsKBuIgp5aVrpSuD2J2HMmgP6AzVvd3o6yfs/rsO+HYbFZcoEkqE6qA8nVym0GYdlNi56PeyO/Y2GbmLvxCetyK+4qi7xoeCaJMCl0UIq56Qx53eMTlP8C/pKuwXYGVZaXu8sIoAX2+B+kBmjGhOUGL0XPOVxFhU/Senu+6SeH1g/Mns647GSDKh1S9N9RbtnYwkla7zyMLtZctChpRZsCYnGeSqsqhJdnRVJ280hYs4kfszujMiPq7P+pAD+DG9blIsqyb6QyJJLe40HRGjLsryPl1DRce2nICsepRBpLM+zFfbDDkJEyNRtGC/RuCz1zSkBnKtgSFvteCglwS25QTURPbniGWE+44/ZkNHTdM+iKRln2ojiwbH5JExsZbEiEW+QvdbVWq+fIZ8wgHU6oCe6HpaI+1TQb9e/andkdSDw4W1Jzbu9herKoHdBJwmm/YUEDpnk=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(66946007)(8936002)(31696002)(4326008)(16576012)(8676002)(54906003)(316002)(110136005)(5660300002)(6486002)(2616005)(83380400001)(956004)(186003)(2906002)(26005)(53546011)(508600001)(66476007)(66556008)(7416002)(38100700002)(36756003)(86362001)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?Rcl/2MprdY9evAOcF9KkKDTrgjWFbBVGnJewDBQTCoYW1mXHXg6nvhEDnJzR?=
 =?us-ascii?Q?HHhgavO8+7KiZEuHRCjc83Uem9perp2wPz8IM/e45FZ5xLY6ZIJo5V4C5mqX?=
 =?us-ascii?Q?yipOPIM7/1ucOnYZQv0wrP8svI0S1YbFWdOrNt7HieV+xHLv1S5BJ237OdlE?=
 =?us-ascii?Q?vzikZ+iMcwQjuQVvMez9fgv45AYkDN3oPhr7VxFzkXhZ8dkeqfdEkmKSMGNA?=
 =?us-ascii?Q?5VnMid7O6CxreXESI+/HyXdqHQvPHCrIC1wTR1C+WDllok07jqnJFIsYepfY?=
 =?us-ascii?Q?g7uQbtquHT9PlaPeD9TIV2JdvdQx9PO/f38NAk5rmG4fScolVBIO9ic4SxDy?=
 =?us-ascii?Q?YGfxyCbvpOiW/xXW4gMSacSl0v3x7pPBd/WXptNeJmraEUFxR245VBkzsxOZ?=
 =?us-ascii?Q?nArWDbXyW1USDp2m9d7Gp/ZEeSum/rX4408za1M5YpKCuT+whAW2vD3gm1+e?=
 =?us-ascii?Q?ZIBpvyNQv9U0mMZK+cNAwM8Y5N0Zz0HIECHPSNDVkVVRTQteSZS8hppIKKHs?=
 =?us-ascii?Q?c74LKzTm7yPW9vne0/jnVKvoWTYr6C5yoJ0chcT9+zRZDEFT0vBXFUmTHu69?=
 =?us-ascii?Q?tQp5KuHCnJtvHYQbUnFLRxDKoA8QApXDGC7jMDCVUrx5k9ZBQgnPIwA/F4qo?=
 =?us-ascii?Q?N127CIT9a2PlCzriwWtopcFj4zLRwYA+AY+IHITOPBLVo/FbsNqRNEjkutlz?=
 =?us-ascii?Q?RePtDKCEpxSK3wXUivN619aTiBvvxyrMdBX2V5M2uIJ0mVpYkufjT93/ExSj?=
 =?us-ascii?Q?Mr0NXPcKPtLuKtd1hfGIE9o7G25sfdcHP3TeDK8IdpOpYrVEd4W8NAf7/GI3?=
 =?us-ascii?Q?mcJVEYN8RSCDgGV7KRMZmHRg8RNa/qYomIiOYn17EylFG/wK/pIDK2JgHXpK?=
 =?us-ascii?Q?1r+Q1jEbGT+Yq/Ttd+LcDjeOLo6Q5vSAc7qNlbZamR7jBpzMVCXZpSdgGtkj?=
 =?us-ascii?Q?YZ89iiK69jI0D3OssvSYmIQyS3h6VUimfLTxMLfDhWJzZk0ZXFJ90xkBkgBr?=
 =?us-ascii?Q?QN35xeYKPuTjXQqakLXbkYcEz6WwpolQJuThp8G801KaOhNGxZGW19rXT7Y/?=
 =?us-ascii?Q?8Oe1NfGvIhcGkPWKW+WvyPrw6uLOycsii0pBeXNp9YJaUK9/S9V9U15TdkRc?=
 =?us-ascii?Q?JXCopvOReMTyXwXC17jHoq1+nIaamNFJiXPjpANNMrTi7iHYsFJr0xMjC4Hz?=
 =?us-ascii?Q?mQN25OHuEqAlWF6DfVvtwa3OYdhxeKaPTq4clnKuER4LYAlD4YZkGuDduwS+?=
 =?us-ascii?Q?IKrKm/mczW9bcqO9NyeIT/PCQkvQtibNxJUSQnHmj4m1tKDE+Xvd03qVWJqi?=
 =?us-ascii?Q?ixa/aVcS1+k0A9RN2XPEqf54?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b583e36c-98d0-4d14-00a8-08d98e124b5d
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2021 06:25:47.5966
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: EU9TlOnMHPYIRLWTn44TGjex+K2zCpVGgy/q24ohDr3nbjj/Zfe3LCkhw0G02T/EkTpjgPHqh0FOa5/uIqKfpQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4384

On 13.10.2021 02:49, Stefano Stabellini wrote:
> On Tue, 12 Oct 2021, Luca Fancellu wrote:
>>> On 12 Oct 2021, at 02:31, Stefano Stabellini <sstabellini@kernel.org> w=
rote:
>>>
>>> On Mon, 11 Oct 2021, Julien Grall wrote:
>>>> Hi Stefano,
>>>>
>>>> On 11/10/2021 22:24, Stefano Stabellini wrote:
>>>>>> diff --git a/xen/arch/arm/efi/efi-boot.h b/xen/arch/arm/efi/efi-boot=
.h
>>>>>> index 840728d6c0..076b827bdd 100644
>>>>>> --- a/xen/arch/arm/efi/efi-boot.h
>>>>>> +++ b/xen/arch/arm/efi/efi-boot.h
>>>>>> @@ -713,10 +713,12 @@ static int __init handle_module_node(EFI_FILE_=
HANDLE
>>>>>> dir_handle,
>>>>>>      char mod_string[24]; /* Placeholder for module@ + a 64-bit numb=
er +
>>>>>> \0 */
>>>>>>      int uefi_name_len, file_idx, module_compat;
>>>>>>      module_name *file;
>>>>>> +    const char *compat_string =3D is_domu_module ? "multiboot,modul=
e" :
>>>>>> +                                "xen,multiboot-module";
>>>>>>        /* Check if the node is a multiboot,module otherwise return *=
/
>>>>>>      module_compat =3D fdt_node_check_compatible(fdt, module_node_of=
fset,
>>>>>> -                                              "multiboot,module");
>>>>>> +                                              compat_string);
>>>>>>      if ( module_compat < 0 )
>>>>>>          /* Error while checking the compatible string */
>>>>>>          return ERROR_CHECK_MODULE_COMPAT;
>>>>>
>>>>>
>>>>> Well... not exactly like this because this would stop a normal
>>>>> "multiboot,module" dom0 kernel from being recognized.
>>>>>
>>>>> So we need for domU: only "multiboot,module"
>>>>> For Dom0, either "multiboot,module" or "xen,multiboot-module"
>>>>
>>>> Looking at the history, xen,multiboot-module has been considered as a =
legacy
>>>> binding since before UEFI was introduced. In fact, without this series=
, I
>>>> believe, there is limited reasons for the compatible to be present in =
the DT
>>>> as you would either use grub (which use the new compatible) or xen.cfg=
 (the
>>>> stub will create the node).
>>>>
>>>> So I would argue that this compatible should not be used in combinatio=
n with
>>>> UEFI and therefore we should not handle it. This would make the code s=
impler
>>>> :).
>>>
>>
>> Hi Stefano,
>>
>>> What you suggested is a viable option, however ImageBuilder is still
>>> using the "xen,multiboot-module" format somehow today (no idea why) and
>>> we have the following written in docs/misc/arm/device-tree/booting.txt:
>>>
>>> 	Xen 4.4 supported a different set of legacy compatible strings
>>> 	which remain supported such that systems supporting both 4.4
>>> 	and later can use a single DTB.
>>>
>>> 	- "xen,multiboot-module" equivalent to "multiboot,module"
>>> 	- "xen,linux-zimage"     equivalent to "multiboot,kernel"
>>> 	- "xen,linux-initrd"     equivalent to "multiboot,ramdisk"
>>>
>>> 	For compatibility with Xen 4.4 the more specific "xen,linux-*"
>>> 	names are non-optional and must be included.
>>>
>>> My preference is to avoid breaking compatibility (even with UEFI
>>> booting). The way I suggested above is one way to do it.
>>>
>>> But I don't feel strongly about this at all, I am fine with ignoring
>>> "xen,multiboot-module" in the EFI stub. I can get ImageBuilder fixed
>>> very quickly (I should do that in any case). If we are going to ignore
>>> "xen,multiboot-module" then we probably want to update the text in
>>> docs/misc/arm/device-tree/booting.txt also.
>>
>> The changes to support legacy compatible strings can be done but it will=
 result in
>> complex code, I would go for Julien suggestion to just drop it for UEFI.
>>
>> I can add a note on docs/misc/arm/device-tree/booting.txt saying that fo=
r UEFI boot
>> the legacy strings are not supported.
>>
>> Something like:
>>
>> --- a/docs/misc/arm/device-tree/booting.txt
>> +++ b/docs/misc/arm/device-tree/booting.txt
>> @@ -51,6 +51,8 @@ Each node contains the following properties:
>>         Xen 4.4 supported a different set of legacy compatible strings
>>         which remain supported such that systems supporting both 4.4
>>         and later can use a single DTB.
>> +       However when booting Xen using UEFI and Device Tree, the legacy =
compatible
>> +       strings are not supported.
>> =20
>>         - "xen,multiboot-module" equivalent to "multiboot,module"
>>         - "xen,linux-zimage"     equivalent to "multiboot,kernel=E2=80=
=9D
>>
>>
>> What do you think about that?
>=20
> Also reading Julien's reply, I am fine with a doc-only change in a
> separate patch.
>=20
> Yes, something along those lines is OK.
>=20
> So for this patch:
>=20
> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>

Then applicable parts
Acked-by: Jan Beulich <jbeulich@suse.com>

Jan



From xen-devel-bounces@lists.xenproject.org Wed Oct 13 06:48:48 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 06:48:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.207919.363875 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maY4A-0006DW-7f; Wed, 13 Oct 2021 06:48:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 207919.363875; Wed, 13 Oct 2021 06:48:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maY4A-0006DP-4K; Wed, 13 Oct 2021 06:48:42 +0000
Received: by outflank-mailman (input) for mailman id 207919;
 Wed, 13 Oct 2021 06:48:40 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1maY48-0006DF-OJ; Wed, 13 Oct 2021 06:48:40 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1maY48-0006M9-GI; Wed, 13 Oct 2021 06:48:40 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1maY48-0007vV-5R; Wed, 13 Oct 2021 06:48:40 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1maY48-0007jX-4u; Wed, 13 Oct 2021 06:48:40 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=7pOl08MC83jE6SQo2+9LACLtD+HMR1XqeC8OhFM7JjY=; b=TM+rR8FDBPNAmUhZ3iaIKmKR/V
	eFIYzctVjV8XUX3gIP+MKdXwovtQyRuMNyw6Yp7qcNay9CuiJcWNmwmK3BhnaugJgwK4sIQv4YbGI
	KDOCcJxbJTBC2q5Qs/e/+YNDYk9JupokSGKyj92yMut1kgEBvYDxu3mRH1QUySYfkwdc=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165480-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 165480: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-unstable:test-armhf-armhf-xl:xen-boot:fail:heisenbug
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=d3b05f9b16d6ba9c550c3a35ac11ed292bf87f68
X-Osstest-Versions-That:
    xen=e8b42a4e8810844ccffd2eab072921b1e4e2ed79
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 13 Oct 2021 06:48:40 +0000

flight 165480 xen-unstable real [real]
flight 165490 xen-unstable real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/165480/
http://logs.test-lab.xenproject.org/osstest/logs/165490/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-armhf-armhf-xl           8 xen-boot            fail pass in 165490-retest

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-xl         15 migrate-support-check fail in 165490 never pass
 test-armhf-armhf-xl     16 saverestore-support-check fail in 165490 never pass
 test-amd64-amd64-xl-rtds     20 guest-localmigrate/x10       fail  like 165471
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 165471
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 165471
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165471
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165471
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 165471
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 165471
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 165471
 test-armhf-armhf-xl-rtds     18 guest-start/debian.repeat    fail  like 165471
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 165471
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 165471
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 165471
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165471
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 165471
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  d3b05f9b16d6ba9c550c3a35ac11ed292bf87f68
baseline version:
 xen                  e8b42a4e8810844ccffd2eab072921b1e4e2ed79

Last test of basis   165471  2021-10-12 01:38:53 Z    1 days
Testing same since   165480  2021-10-12 15:44:05 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Anthony PERARD <anthony.perard@citrix.com>
  Jan Beulich <jbeulich@suse.com>
  Julien Grall <jgrall@amazon.com>
  Luca Fancellu <luca.fancellu@arm.com>
  Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
  Rahul Singh <rahul.singh@arm.com>
  Stefano Stabellini <sstabellini@kernel.org>
  Stefano Stabellini <stefano.stabellini@xilinx.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          fail    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     fail    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   e8b42a4e88..d3b05f9b16  d3b05f9b16d6ba9c550c3a35ac11ed292bf87f68 -> master


From xen-devel-bounces@lists.xenproject.org Wed Oct 13 07:03:09 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 07:03:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.207943.363933 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maYI5-0000et-8g; Wed, 13 Oct 2021 07:03:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 207943.363933; Wed, 13 Oct 2021 07:03:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maYI5-0000em-4z; Wed, 13 Oct 2021 07:03:05 +0000
Received: by outflank-mailman (input) for mailman id 207943;
 Wed, 13 Oct 2021 07:03:03 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1maYI3-0000ec-De; Wed, 13 Oct 2021 07:03:03 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1maYI3-0006ed-5T; Wed, 13 Oct 2021 07:03:03 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1maYI2-0000JE-Qi; Wed, 13 Oct 2021 07:03:02 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1maYI2-0001Sv-QB; Wed, 13 Oct 2021 07:03:02 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=ivouugLmeZwiwCRoAJtwT9O2ALypolDJ4sWEK3MnO70=; b=uOwlZl2jLunfpyJa11x6Iu+OlP
	Al0GKdYSKWcgeAdU8vfALrYxyd8qyh1QxJ49lk9shi6dwygq+71f/jFB4dJn74fWkpLdtyyvxyDvV
	twHsG/YRumOd6mxQFrVnMq6bcNk9VD2VP2Aq8WQUBi/rS7yZFLC9FF48uABFyqK7GDj4=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165483-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 165483: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=f4d0cc426f77df6890aa868f96c2de89686aae8a
X-Osstest-Versions-That:
    linux=fa5878760579a9feaa1de3bb2396cd23beb439ca
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 13 Oct 2021 07:03:02 +0000

flight 165483 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165483/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 165470
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 165470
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165470
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165470
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 165470
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165470
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 165470
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 165470
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 linux                f4d0cc426f77df6890aa868f96c2de89686aae8a
baseline version:
 linux                fa5878760579a9feaa1de3bb2396cd23beb439ca

Last test of basis   165470  2021-10-12 00:40:45 Z    1 days
Testing same since   165483  2021-10-12 19:09:34 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Catalin Marinas <catalin.marinas@arm.com>
  Daniel Scally <djrscally@gmail.com>
  Hanjun Guo <guohanjun@huawei.com>
  Hans de Goede <hdegoede@redhat.com>
  Jackie Liu <liuyun01@kylinos.cn>
  Linus Torvalds <torvalds@linux-foundation.org>
  Mike Kravetz <mike.kravetz@oracle.com>
  Prashant Malani <pmalani@chromium.org>
  Sachi King <nakato@nakato.io>
  Shravan S <s.shravan@intel.com>
  Vadim Pasternak <vadimp@nvidia.com>
  Zephaniah E. Loss-Cutler-Hull <zephaniah@gmail.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   fa5878760579a..f4d0cc426f77d  f4d0cc426f77df6890aa868f96c2de89686aae8a -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Wed Oct 13 07:11:20 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 07:11:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.207953.363946 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maYPp-00027X-2b; Wed, 13 Oct 2021 07:11:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 207953.363946; Wed, 13 Oct 2021 07:11:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maYPo-00027Q-Vo; Wed, 13 Oct 2021 07:11:04 +0000
Received: by outflank-mailman (input) for mailman id 207953;
 Wed, 13 Oct 2021 07:11:03 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=bmSx=PB=gmail.com=alistair23@srs-us1.protection.inumbo.net>)
 id 1maYPn-00027K-6I
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 07:11:03 +0000
Received: from mail-io1-xd2c.google.com (unknown [2607:f8b0:4864:20::d2c])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id b076813f-9614-4a15-8cb7-a20874ef10d4;
 Wed, 13 Oct 2021 07:11:02 +0000 (UTC)
Received: by mail-io1-xd2c.google.com with SMTP id q205so1667133iod.8
 for <xen-devel@lists.xenproject.org>; Wed, 13 Oct 2021 00:11:01 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b076813f-9614-4a15-8cb7-a20874ef10d4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=PuD4x/quwdKwmCZMAPno27Mt5WkSyZcD2cupRATIQmA=;
        b=hUpeBm07ZhmU+R92qTIFSrBL14OeFHZ6uD4IZbV6GtgXTzhgOqStOEWSiPJEWuGj4t
         4zuWiSkqFTm3AGGU2NR38KTYSKWPxOtEcdS4Ai/3r1akHkT61Jp+XPc9Zl1qrzwNyPwA
         TnX/xusNsfu2j+x4p6dymMk+gwlKDmH0z9qb8RZ1yOpGX8JaH+u2u3i10cFfQzzpQZKA
         gzhXJSBzjJDyKX/O/RiXSwFRjlfOrTHayIFv4RaRpmQwTkqpQYJmnggmAwOE8fiqTWjc
         lItwI007UCAJqN+GP5GKmGAqMrKlXFHSwRjzOn5t6E5+kri8uC+0X+pm6KhlPDRrs3ON
         wktA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=PuD4x/quwdKwmCZMAPno27Mt5WkSyZcD2cupRATIQmA=;
        b=NcV3jJegfe6hKWDUMYA1LoS8Q11mPnQlRU8+p9Cty/g8HW9P51Sa+VUPMXcsG/SJVa
         1PPQ/45FkH4uKoyETD5OPawKG056GVhwoJNxpoVcJbUo+dIOMhTkZ0e4/cDEjuJkVsEP
         kFR+nR9M3pahRH6nqbqH04SVMabMYTc/eaomnTqTYh7rVLM3lzc04+VI9vmOX4xk506D
         NjwrC79a4w5oOigJKGMMqcjfhcRU9flG2UO9gmRIiVgnODfLLrK+Ri8Z9JGqP84h1sLB
         i43IBJbca5J45Aup5ejlMVIJ3zTY/Nov9VmLai9DeCzWky1VHuvEV7sSHyYMoYbBUr1J
         uj4A==
X-Gm-Message-State: AOAM530TcDmt4QutRZl9uBqITkLsFB3TQUxqXOKS4dN0d36/6oOvDv8j
	fxuIOoIxCISfZwF1uIxsIgiKdOk/kmw8Stz+MJmJv5jlhHNQPw==
X-Google-Smtp-Source: ABdhPJzyNaV6p60H1ka7FNoMSrAfpLbPjQqSVej3WyYM+u5LpMnq8d8d2K/hoKgv951cKI2obB3JFtyY4qhuLjUoOBw=
X-Received: by 2002:a05:6638:9a:: with SMTP id v26mr11895732jao.18.1634109061530;
 Wed, 13 Oct 2021 00:11:01 -0700 (PDT)
MIME-Version: 1.0
References: <20210922161405.140018-1-damien.hedde@greensocs.com> <20210922161405.140018-5-damien.hedde@greensocs.com>
In-Reply-To: <20210922161405.140018-5-damien.hedde@greensocs.com>
From: Alistair Francis <alistair23@gmail.com>
Date: Wed, 13 Oct 2021 17:10:35 +1000
Message-ID: <CAKmqyKNWBYpq8CbhtGyw9=1Gt_LujZZrtD7J_Ye2FyyVA6eqcw@mail.gmail.com>
Subject: Re: [RFC PATCH v2 04/16] softmmu/qdev-monitor: add error handling in qdev_set_id
To: Damien Hedde <damien.hedde@greensocs.com>
Cc: "qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>, Peter Maydell <peter.maydell@linaro.org>, 
	"Michael S. Tsirkin" <mst@redhat.com>, David Hildenbrand <david@redhat.com>, Peter Xu <peterx@redhat.com>, 
	mirela.grujic@greensocs.com, Alistair Francis <Alistair.Francis@wdc.com>, 
	Gerd Hoffmann <kraxel@redhat.com>, Ani Sinha <ani@anisinha.ca>, Eric Blake <eblake@redhat.com>, 
	Stefano Stabellini <sstabellini@kernel.org>, "open list:X86" <xen-devel@lists.xenproject.org>, 
	Paul Durrant <paul@xen.org>, Markus Armbruster <armbru@redhat.com>, 
	Anthony Perard <anthony.perard@citrix.com>, 
	=?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= <marcandre.lureau@redhat.com>, 
	Eduardo Habkost <ehabkost@redhat.com>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>, 
	Eric Auger <eric.auger@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, 
	"open list:RISC-V" <qemu-riscv@nongnu.org>, =?UTF-8?Q?Daniel_P=2E_Berrang=C3=A9?= <berrange@redhat.com>, 
	Mark Burton <mark.burton@greensocs.com>, Edgar Iglesias <edgari@xilinx.com>, 
	Igor Mammedov <imammedo@redhat.com>
Content-Type: text/plain; charset="UTF-8"

On Thu, Sep 23, 2021 at 2:29 AM Damien Hedde <damien.hedde@greensocs.com> wrote:
>
> qdev_set_id() is mostly used when the user adds a device (using
> -device cli option or device_add qmp command). This commit adds
> an error parameter to handle the case where the given id is
> already taken.
>
> Also document the function and add a return value in order to
> be able to capture success/failure: the function now returns the
> id in case of success, or NULL in case of failure.
>
> The commit modifies the 2 calling places (qdev-monitor and
> xen-legacy-backend) to add the error object parameter.
>
> Note that the id is, right now, guaranteed to be unique because
> all ids came from the "device" QemuOptsList where the id is used
> as key. This addition is a preparation for a future commit which
> will relax the uniqueness.
>
> Signed-off-by: Damien Hedde <damien.hedde@greensocs.com>

Reviewed-by: Alistair Francis <alistair.francis@wdc.com>

Alistair

> ---
>  include/monitor/qdev.h      | 25 +++++++++++++++++++++++-
>  hw/xen/xen-legacy-backend.c |  3 ++-
>  softmmu/qdev-monitor.c      | 38 +++++++++++++++++++++++++++----------
>  3 files changed, 54 insertions(+), 12 deletions(-)
>
> diff --git a/include/monitor/qdev.h b/include/monitor/qdev.h
> index eaa947d73a..23c31f5296 100644
> --- a/include/monitor/qdev.h
> +++ b/include/monitor/qdev.h
> @@ -9,6 +9,29 @@ void qmp_device_add(QDict *qdict, QObject **ret_data, Error **errp);
>
>  int qdev_device_help(QemuOpts *opts);
>  DeviceState *qdev_device_add(QemuOpts *opts, Error **errp);
> -void qdev_set_id(DeviceState *dev, const char *id);
> +
> +/**
> + * qdev_set_id: parent the device and set its id if provided.
> + * @dev: device to handle
> + * @id: id to be given to the device, or NULL.
> + *
> + * Returns: the id of the device in case of success; otherwise NULL.
> + *
> + * @dev must be unrealized, unparented and must not have an id.
> + *
> + * If @id is non-NULL, this function tries to setup @dev qom path as
> + * "/peripheral/id". If @id is already taken, it fails. If it succeeds,
> + * the id field of @dev is set to @id (@dev now owns the given @id
> + * parameter).
> + *
> + * If @id is NULL, this function generates a unique name and setups @dev
> + * qom path as "/peripheral-anon/name". This name is not set as the id
> + * of @dev.
> + *
> + * Upon success, it returns the id/name (generated or provided). The
> + * returned string is owned by the corresponding child property and must
> + * not be freed by the caller.
> + */
> +const char *qdev_set_id(DeviceState *dev, const char *id, Error **errp);
>
>  #endif
> diff --git a/hw/xen/xen-legacy-backend.c b/hw/xen/xen-legacy-backend.c
> index dd8ae1452d..f541cfa0e9 100644
> --- a/hw/xen/xen-legacy-backend.c
> +++ b/hw/xen/xen-legacy-backend.c
> @@ -276,7 +276,8 @@ static struct XenLegacyDevice *xen_be_get_xendev(const char *type, int dom,
>      xendev = g_malloc0(ops->size);
>      object_initialize(&xendev->qdev, ops->size, TYPE_XENBACKEND);
>      OBJECT(xendev)->free = g_free;
> -    qdev_set_id(DEVICE(xendev), g_strdup_printf("xen-%s-%d", type, dev));
> +    qdev_set_id(DEVICE(xendev), g_strdup_printf("xen-%s-%d", type, dev),
> +                &error_fatal);
>      qdev_realize(DEVICE(xendev), xen_sysbus, &error_fatal);
>      object_unref(OBJECT(xendev));
>
> diff --git a/softmmu/qdev-monitor.c b/softmmu/qdev-monitor.c
> index 25275984bd..0007698ff3 100644
> --- a/softmmu/qdev-monitor.c
> +++ b/softmmu/qdev-monitor.c
> @@ -578,22 +578,34 @@ static BusState *qbus_find(const char *path, Error **errp)
>      return bus;
>  }
>
> -void qdev_set_id(DeviceState *dev, const char *id)
> +const char *qdev_set_id(DeviceState *dev, const char *id, Error **errp)
>  {
> +    ObjectProperty *prop;
> +
> +    assert(!dev->id && !dev->realized);
> +
> +    /*
> +     * object_property_[try_]add_child() below will assert the device
> +     * has no parent
> +     */
>      if (id) {
> -        dev->id = id;
> -    }
> -
> -    if (dev->id) {
> -        object_property_add_child(qdev_get_peripheral(), dev->id,
> -                                  OBJECT(dev));
> +        prop = object_property_try_add_child(qdev_get_peripheral(), id,
> +                                             OBJECT(dev), NULL);
> +        if (prop) {
> +            dev->id = id;
> +        } else {
> +            error_setg(errp, "Duplicate device ID '%s'", id);
> +            return NULL;
> +        }
>      } else {
>          static int anon_count;
>          gchar *name = g_strdup_printf("device[%d]", anon_count++);
> -        object_property_add_child(qdev_get_peripheral_anon(), name,
> -                                  OBJECT(dev));
> +        prop = object_property_add_child(qdev_get_peripheral_anon(), name,
> +                                         OBJECT(dev));
>          g_free(name);
>      }
> +
> +    return prop->name;
>  }
>
>  DeviceState *qdev_device_add(QemuOpts *opts, Error **errp)
> @@ -677,7 +689,13 @@ DeviceState *qdev_device_add(QemuOpts *opts, Error **errp)
>          }
>      }
>
> -    qdev_set_id(dev, qemu_opts_id(opts));
> +    /*
> +     * set dev's parent and register its id.
> +     * If it fails it means the id is already taken.
> +     */
> +    if (!qdev_set_id(dev, qemu_opts_id(opts), errp)) {
> +        goto err_del_dev;
> +    }
>
>      /* set properties */
>      if (qemu_opt_foreach(opts, set_property, dev, errp)) {
> --
> 2.33.0
>
>


From xen-devel-bounces@lists.xenproject.org Wed Oct 13 07:11:48 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 07:11:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.207959.363958 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maYQW-0002f3-C9; Wed, 13 Oct 2021 07:11:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 207959.363958; Wed, 13 Oct 2021 07:11:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maYQW-0002ew-8p; Wed, 13 Oct 2021 07:11:48 +0000
Received: by outflank-mailman (input) for mailman id 207959;
 Wed, 13 Oct 2021 07:11:47 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=K823=PB=arm.com=michal.orzel@srs-us1.protection.inumbo.net>)
 id 1maYQV-0002dg-M9
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 07:11:47 +0000
Received: from foss.arm.com (unknown [217.140.110.172])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTP
 id 1f347d01-5b27-4c4a-85a5-76ba11e5a374;
 Wed, 13 Oct 2021 07:11:45 +0000 (UTC)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 53F131FB;
 Wed, 13 Oct 2021 00:11:45 -0700 (PDT)
Received: from [10.57.25.166] (unknown [10.57.25.166])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C8E173F66F;
 Wed, 13 Oct 2021 00:11:42 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1f347d01-5b27-4c4a-85a5-76ba11e5a374
Subject: Re: [PATCH v5 07/11] xen/domctl: Introduce XEN_DOMCTL_CDF_vpci flag
To: Jan Beulich <jbeulich@suse.com>,
 Stefano Stabellini <sstabellini@kernel.org>
Cc: Rahul Singh <rahul.singh@arm.com>, xen-devel@lists.xenproject.org,
 bertrand.marquis@arm.com, Andre.Przywara@arm.com,
 Christian Lindig <christian.lindig@citrix.com>, David Scott
 <dave@recoil.org>, Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <cover.1633540842.git.rahul.singh@arm.com>
 <20d5b9d6a0d01a7b90711d28cbefb5701a88b438.1633540842.git.rahul.singh@arm.com>
 <YWQDguvmf/O4rDIs@MacBook-Air-de-Roger.local>
 <alpine.DEB.2.21.2110121439100.9408@sstabellini-ThinkPad-T480s>
 <44eae5c0-28a0-590a-07c6-6b411b23ebc3@suse.com>
From: Michal Orzel <michal.orzel@arm.com>
Message-ID: <70fa9c08-4a5d-323a-a629-6471aeb76797@arm.com>
Date: Wed, 13 Oct 2021 09:11:27 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <44eae5c0-28a0-590a-07c6-6b411b23ebc3@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit



On 13.10.2021 08:18, Jan Beulich wrote:
> On 12.10.2021 23:48, Stefano Stabellini wrote:
>> On Mon, 11 Oct 2021, Roger Pau Monné wrote:
>>> On Wed, Oct 06, 2021 at 06:40:33PM +0100, Rahul Singh wrote:
>>>> Introduce XEN_DOMCTL_CDF_vpci flag to enable VPCI support in XEN.
>>>> Reject the use of this new flag for x86 as VPCI is not supported for
>>>> DOMU guests for x86.
>>>
>>> I don't like this approach, XEN_DOMCTL_CDF_vpci should be set for x86
>>> PVH dom0, like we do for any other CDF flags when Xen builds dom0.
>>>
>>> Things like PVH vs PV get translated into CDF flags by create_dom0,
>>> and processed normally by the sanitise_domain_config logic, vPCI
>>> should be handled that way.
>>>
>>> Do you think you could see about fixing this?
>>
>> Andrew suggested to use XEN_SYSCTL_PHYSCAP_vpci to check whether we can
>> set XEN_DOMCTL_CDF_vpci in libxl and it looks like we have consensus on
>> this approach. [1][2]
>>
>> So it makes sense that XEN_DOMCTL_CDF_vpci is only set when
>> XEN_SYSCTL_PHYSCAP_vpci is also set, i.e. XEN_SYSCTL_PHYSCAP_vpci ==
>> XEN_DOMCTL_CDF_vpci.
>>
>> From [2], XEN_SYSCTL_PHYSCAP_vpci is not going to be set on x86, so then
>> XEN_DOMCTL_CDF_vpci should also be left unset?
>>
>> If you think XEN_DOMCTL_CDF_vpci should be set for x86 PVH Dom0, then
>> XEN_SYSCTL_PHYSCAP_vpci should also be set for x86 PVH Dom0.
> 
> Except that XEN_SYSCTL_PHYSCAP_vpci is not a domain specific attribute,
> but a host-wide one.
> 
> Jan
> 
> 
I already prepared a patch introducing XEN_SYSCTL_PHYSCAP_vpci. We agreed
that the cap_vpci should not be set neither for x86 nor ARM. This means that
the flag vpci_is_available, which tells us about vPCI platform support (and is used
in condition to set cap_vpci) is set to false by default. Later on it should be set by vPCI driver.
For me it does not make sense for XEN_SYSCTL_PHYSCAP_vpci saying that platform does not support vPCI
but setting XEN_DOMCTL_CDF_vpci for dom0 pvh.
I would prefer not setting XEN_DOMCTL_CDF_vpci for now at all. This way we have a chance
to merge Rahul's series until friday.

Cheers,
Michal


From xen-devel-bounces@lists.xenproject.org Wed Oct 13 07:13:14 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 07:13:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.207971.363969 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maYRs-0003MF-S7; Wed, 13 Oct 2021 07:13:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 207971.363969; Wed, 13 Oct 2021 07:13:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maYRs-0003M8-Ol; Wed, 13 Oct 2021 07:13:12 +0000
Received: by outflank-mailman (input) for mailman id 207971;
 Wed, 13 Oct 2021 07:13:11 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=bmSx=PB=gmail.com=alistair23@srs-us1.protection.inumbo.net>)
 id 1maYRr-0003M2-Oy
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 07:13:11 +0000
Received: from mail-io1-xd2a.google.com (unknown [2607:f8b0:4864:20::d2a])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 7d21eafa-d5c4-4a84-a8c3-d535b795752b;
 Wed, 13 Oct 2021 07:13:10 +0000 (UTC)
Received: by mail-io1-xd2a.google.com with SMTP id x1so1681127iof.7
 for <xen-devel@lists.xenproject.org>; Wed, 13 Oct 2021 00:13:10 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7d21eafa-d5c4-4a84-a8c3-d535b795752b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=KHB4g6o0LeMzf6QhsqguIIRvH+olg3UnDhoJaR0aLNA=;
        b=avPTWRvD87X49NZcwlii0xdmVFI41b1HDJTeSUpV6LTstZj5FMBkZDEpcCnnV6wh09
         tkLv9db1x07e+t/oQyZn8p2e1N6gQiet1Pbm4ckl21olRRwSML+IJtPQ5J3XScYpq+mI
         JgiVbyQ7DFL7gdytixxEnQzk/i9FfuXjXfHvxwZBmRQWVR1ZzV+6Vgo4XssTxxUy0s6A
         MhZTjzoA5tZ8zJIWwjFjdo/7wfq4BkqVbsSWPrnHVJxA1rQCHHwxVPBYM9oKV14JGha3
         iZkQZGbR9s1yGyXVp/0KymzoP6LIaXMT1lzaITBayQAvzJwYyt4vLlVJlm4V3pmjWU+3
         dLog==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=KHB4g6o0LeMzf6QhsqguIIRvH+olg3UnDhoJaR0aLNA=;
        b=eGLItcLvMteAG0PlXhSqHhDhzq0xf8bpfdURggnynC3dnMQwpahGtFSgfPA/icggOg
         lw4vryaeGD/VQmh+A+N/uOJSv+RdLYBjSvM9DXUztEBzLMLZWhZb2mGjNwAGAzCJIMHV
         vf1LW5P+z97J8D3KMUBXrfCaguT8lH/8xFKgYCcYgMYrga8XJ+CP8rZGX39Lvp9hm8D/
         cqWkSGp0O5aI2R8ibtpYFT/iUBKWHsTATULz5zUxxAwAANAvQkL91ORUwJqctyqEMc4c
         G0FX0qr57xI/fgO4H3Y9IQZ5ooc8GJN0HdPtGvwQyOyRYhg+hy2TcpH4z1Ih14QYmzz5
         rDXQ==
X-Gm-Message-State: AOAM533GtM07t5kQ8W6Sai/HOqvoDdcH08eUfC0cM8KFQg5Qg4nJ0O0c
	SEqMhXVvRxdyEIvaT9wiwHXsWncPo46r0UNY7yM=
X-Google-Smtp-Source: ABdhPJwAerQBrE6h1mAcc8a9ejLtUsRNqYkv/iKjXq1q0SyzeWPOBrz+6jeH+TXpXPz1j01S6PDyDckoOD1oFZSZOyY=
X-Received: by 2002:a05:6602:2e8c:: with SMTP id m12mr8986722iow.91.1634109190435;
 Wed, 13 Oct 2021 00:13:10 -0700 (PDT)
MIME-Version: 1.0
References: <20210922161405.140018-1-damien.hedde@greensocs.com> <20210922161405.140018-12-damien.hedde@greensocs.com>
In-Reply-To: <20210922161405.140018-12-damien.hedde@greensocs.com>
From: Alistair Francis <alistair23@gmail.com>
Date: Wed, 13 Oct 2021 17:12:44 +1000
Message-ID: <CAKmqyKMP5-8wGY6vFEXeiCgrJQhZRQWcYvyqbEihjCkv1bYEhQ@mail.gmail.com>
Subject: Re: [RFC PATCH v2 11/16] softmmu/memory: add memory_region_try_add_subregion
 function
To: Damien Hedde <damien.hedde@greensocs.com>
Cc: "qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>, Peter Maydell <peter.maydell@linaro.org>, 
	"Michael S. Tsirkin" <mst@redhat.com>, David Hildenbrand <david@redhat.com>, Peter Xu <peterx@redhat.com>, 
	mirela.grujic@greensocs.com, Alistair Francis <Alistair.Francis@wdc.com>, 
	Gerd Hoffmann <kraxel@redhat.com>, Ani Sinha <ani@anisinha.ca>, Eric Blake <eblake@redhat.com>, 
	Stefano Stabellini <sstabellini@kernel.org>, "open list:X86" <xen-devel@lists.xenproject.org>, 
	Paul Durrant <paul@xen.org>, Markus Armbruster <armbru@redhat.com>, 
	Anthony Perard <anthony.perard@citrix.com>, 
	=?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= <marcandre.lureau@redhat.com>, 
	Eduardo Habkost <ehabkost@redhat.com>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>, 
	Eric Auger <eric.auger@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, 
	"open list:RISC-V" <qemu-riscv@nongnu.org>, =?UTF-8?Q?Daniel_P=2E_Berrang=C3=A9?= <berrange@redhat.com>, 
	Mark Burton <mark.burton@greensocs.com>, Edgar Iglesias <edgari@xilinx.com>, 
	Igor Mammedov <imammedo@redhat.com>
Content-Type: text/plain; charset="UTF-8"

On Thu, Sep 23, 2021 at 2:29 AM Damien Hedde <damien.hedde@greensocs.com> wrote:
>
> It allows to try to add a subregion to a memory region with error
> handling. Like memory_region_add_subregion_overlap, it handles
> priority as well.
> Apart the error handling, the behavior is the same. It can be used
> to do the simple memory_region_add_subregion() (with no overlap) by
> setting the priority parameter to 0.
>
> This commit is a preparation to further use this function in the
> context of qmp command which needs error handling support.
>
> Signed-off-by: Damien Hedde <damien.hedde@greensocs.com>

Reviewed-by: Alistair Francis <alistair.francis@wdc.com>

Alistair

> ---
>
> Adding a new function is obviously not ideal. But there is ~900
> occurrences of memory_region_add_subregion[_overlap] calls in the code
> base. We do not really see an alternative here.
> ---
>  include/exec/memory.h | 22 ++++++++++++++++++++++
>  softmmu/memory.c      | 22 ++++++++++++++--------
>  2 files changed, 36 insertions(+), 8 deletions(-)
>
> diff --git a/include/exec/memory.h b/include/exec/memory.h
> index c3d417d317..422e1eda67 100644
> --- a/include/exec/memory.h
> +++ b/include/exec/memory.h
> @@ -2162,6 +2162,28 @@ void memory_region_add_subregion_overlap(MemoryRegion *mr,
>                                           MemoryRegion *subregion,
>                                           int priority);
>
> +/**
> + * memory_region_try_add_subregion: Add a subregion to a container
> + *                                  with error handling.
> + *
> + * Behaves like memory_region_add_subregion_overlap(), but errors are
> + * reported if the subregion cannot be added.
> + *
> + * @mr: the region to contain the new subregion; must be a container
> + *      initialized with memory_region_init().
> + * @offset: the offset relative to @mr where @subregion is added.
> + * @subregion: the subregion to be added.
> + * @priority: used for resolving overlaps; highest priority wins.
> + * @errp: pointer to Error*, to store an error if it happens.
> + *
> + * Returns: True in case of success, false otherwise.
> + */
> +bool memory_region_try_add_subregion(MemoryRegion *mr,
> +                                     hwaddr offset,
> +                                     MemoryRegion *subregion,
> +                                     int priority,
> +                                     Error **errp);
> +
>  /**
>   * memory_region_get_ram_addr: Get the ram address associated with a memory
>   *                             region
> diff --git a/softmmu/memory.c b/softmmu/memory.c
> index bfedaf9c4d..eac61f8236 100644
> --- a/softmmu/memory.c
> +++ b/softmmu/memory.c
> @@ -2513,22 +2513,28 @@ done:
>      memory_region_transaction_commit();
>  }
>
> -static void memory_region_add_subregion_common(MemoryRegion *mr,
> -                                               hwaddr offset,
> -                                               MemoryRegion *subregion)
> +bool memory_region_try_add_subregion(MemoryRegion *mr,
> +                                     hwaddr offset,
> +                                     MemoryRegion *subregion,
> +                                     int priority,
> +                                     Error **errp)
>  {
> -    assert(!subregion->container);
> +    if (subregion->container) {
> +        error_setg(errp, "The memory region is already in another region");
> +        return false;
> +    }
> +    subregion->priority = priority;
>      subregion->container = mr;
>      subregion->addr = offset;
>      memory_region_update_container_subregions(subregion);
> +    return true;
>  }
>
>  void memory_region_add_subregion(MemoryRegion *mr,
>                                   hwaddr offset,
>                                   MemoryRegion *subregion)
>  {
> -    subregion->priority = 0;
> -    memory_region_add_subregion_common(mr, offset, subregion);
> +    memory_region_try_add_subregion(mr, offset, subregion, 0, &error_abort);
>  }
>
>  void memory_region_add_subregion_overlap(MemoryRegion *mr,
> @@ -2536,8 +2542,8 @@ void memory_region_add_subregion_overlap(MemoryRegion *mr,
>                                           MemoryRegion *subregion,
>                                           int priority)
>  {
> -    subregion->priority = priority;
> -    memory_region_add_subregion_common(mr, offset, subregion);
> +    memory_region_try_add_subregion(mr, offset, subregion, priority,
> +                                    &error_abort);
>  }
>
>  void memory_region_del_subregion(MemoryRegion *mr,
> --
> 2.33.0
>
>


From xen-devel-bounces@lists.xenproject.org Wed Oct 13 07:16:36 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 07:16:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.207980.363980 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maYV6-00042d-C3; Wed, 13 Oct 2021 07:16:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 207980.363980; Wed, 13 Oct 2021 07:16:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maYV6-00042W-7e; Wed, 13 Oct 2021 07:16:32 +0000
Received: by outflank-mailman (input) for mailman id 207980;
 Wed, 13 Oct 2021 07:16:30 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=bmSx=PB=gmail.com=alistair23@srs-us1.protection.inumbo.net>)
 id 1maYV4-00042P-Le
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 07:16:30 +0000
Received: from mail-il1-x135.google.com (unknown [2607:f8b0:4864:20::135])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id decbc151-6f16-4b9e-9522-a9304c19b24f;
 Wed, 13 Oct 2021 07:16:29 +0000 (UTC)
Received: by mail-il1-x135.google.com with SMTP id x1so1611815ilv.4
 for <xen-devel@lists.xenproject.org>; Wed, 13 Oct 2021 00:16:29 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: decbc151-6f16-4b9e-9522-a9304c19b24f
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=i3FI/4yg1UnUkR3eFfub07xRQFw994Re88ZbTuriDcs=;
        b=fnt6SAzQGyiPybQHEXVCM0uU97YZxcWzVopCBhCvr6XBbj2XR1Oi+WhDZSG1se8yr+
         04SpaO2W584eqSOk/6gpNgP0V+QKjmK7x0xh/jHlpvCJxi3QtM+CxH+eHM9+roXm6Yrf
         aR5fwEtuzHgwqaaywBAOafqgEg1HJbx316sbDaYt/cjwl4rqOzmZbJgkZ6eY8dFExCBt
         aCsEBowYbx5bbrtC4d1WmWmvmG9RJM/LY1F4xEUoWNsW0cWVxxpzB/7ki93VpFn8c1Qa
         j4Erspl8b7ZCU4qnGaoQvUqL9RecGA7d9SPvnJc4iEqUmqscFGsuk8CStKc5M6pxxHKa
         TRIg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=i3FI/4yg1UnUkR3eFfub07xRQFw994Re88ZbTuriDcs=;
        b=Pm17fkv3Z0rbmtHTC40p9Az4V1rNGvnw1XpEf6iJNHgknhpibOFJsdGn5xvPCF0xV3
         8W3yZWO+WEEUrqtoDUshPAugBwIwPFyL2bl9N0KHnUHnbtOpp9T16k9b6DQtRsain4L8
         Crsp6HAu344bQd6uAjJ4xx0FmPWXVPZADUVBWawOjompCrk4VlS5ErZyw8q7+TDtru9i
         PahhqSAN95FZaltR4mM5QGQ0GulD1hPf80mKosiYKScYPX4siyPHNKvJVq1nGbBLC4Dn
         l+9nzjFp3aOsx7mLRmD5T+HwRDvtHoPd65Kno4JIYH25FIkobQVrdZ+KIZQnZ+Ywgm8k
         KnAw==
X-Gm-Message-State: AOAM531MoJ1QIJHUiWlRuSaYcpAkFtQi5xLJ8hN3ufFboe33tW4jkEdg
	AwcqH/rgrbtCt6xtQNh0//qXxu9YLUTJ+FXoPe8=
X-Google-Smtp-Source: ABdhPJyzWNsJ7ScpHzJDMDmxpcmfJLbKNdWIIAodbqImc6KC0VK+oNgkRydrV8wTWOXm1+nOaURd7afR1ivOvcLqGT8=
X-Received: by 2002:a92:1a43:: with SMTP id z3mr27913757ill.46.1634109389213;
 Wed, 13 Oct 2021 00:16:29 -0700 (PDT)
MIME-Version: 1.0
References: <20210922161405.140018-1-damien.hedde@greensocs.com> <20210922161405.140018-13-damien.hedde@greensocs.com>
In-Reply-To: <20210922161405.140018-13-damien.hedde@greensocs.com>
From: Alistair Francis <alistair23@gmail.com>
Date: Wed, 13 Oct 2021 17:16:03 +1000
Message-ID: <CAKmqyKPWDL52kC23TgtpdEST_kvVjNWn3-j2YFORN457_cEwnw@mail.gmail.com>
Subject: Re: [RFC PATCH v2 12/16] add x-sysbus-mmio-map qmp command
To: Damien Hedde <damien.hedde@greensocs.com>
Cc: "qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>, Peter Maydell <peter.maydell@linaro.org>, 
	"Michael S. Tsirkin" <mst@redhat.com>, David Hildenbrand <david@redhat.com>, Peter Xu <peterx@redhat.com>, 
	mirela.grujic@greensocs.com, Alistair Francis <Alistair.Francis@wdc.com>, 
	Gerd Hoffmann <kraxel@redhat.com>, Ani Sinha <ani@anisinha.ca>, Eric Blake <eblake@redhat.com>, 
	Stefano Stabellini <sstabellini@kernel.org>, "open list:X86" <xen-devel@lists.xenproject.org>, 
	Paul Durrant <paul@xen.org>, Markus Armbruster <armbru@redhat.com>, 
	Anthony Perard <anthony.perard@citrix.com>, 
	=?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= <marcandre.lureau@redhat.com>, 
	Eduardo Habkost <ehabkost@redhat.com>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>, 
	Eric Auger <eric.auger@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, 
	"open list:RISC-V" <qemu-riscv@nongnu.org>, =?UTF-8?Q?Daniel_P=2E_Berrang=C3=A9?= <berrange@redhat.com>, 
	Mark Burton <mark.burton@greensocs.com>, Edgar Iglesias <edgari@xilinx.com>, 
	Igor Mammedov <imammedo@redhat.com>
Content-Type: text/plain; charset="UTF-8"

On Thu, Sep 23, 2021 at 2:26 AM Damien Hedde <damien.hedde@greensocs.com> wrote:
>
> This command allows to map an mmio region of sysbus device onto
> the system memory. Its behavior mimics the sysbus_mmio_map()
> function apart from the automatic unmap (the C function unmaps
> the region if it is already mapped).
> For the qmp function we consider it is an error to try to map
> an already mapped function. If unmapping is required, it is
> probably better to add a sysbus-mmip-unmap function.
>
> This command is still experimental (hence the x prefix), as it
> is related to the sysbus device creation through qmp commands.
>
> In future, we expect to have to handle the overlap/priority
> parameter but also multiple mapping of one mmio. For some
> devices, one mmio is mapped several times at different addresses on
> the bus (which is not supported by sysbus_mmio_map() function and
> requires the use of memory region aliases).

I think as is this is a good start. This is a useful feature!

>
> Signed-off-by: Damien Hedde <damien.hedde@greensocs.com>

Acked-by: Alistair Francis <alistair.francis@wdc.com>

> ---
>
> Note: this qmp command is required to be able to build a machine from
> scratch as there is no qmp-way of doing a memory mapping today.
>
> We've added the command into qapi/qdev.json section. It does not seem to
> have any really adequate section yet. Any idea ? should we create for
> example a new one: qapi/sysbus.json or qapi/memory.json ?

I would say leave it in qdev. We don't really want many more sysbus
commands, so qapi/sysbus.json doesn't need it's own file.

Alistair

> ---
>  qapi/qdev.json   | 21 +++++++++++++++++++++
>  hw/core/sysbus.c | 41 +++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 62 insertions(+)
>
> diff --git a/qapi/qdev.json b/qapi/qdev.json
> index ad669ae175..dfc1104197 100644
> --- a/qapi/qdev.json
> +++ b/qapi/qdev.json
> @@ -125,3 +125,24 @@
>  ##
>  { 'event': 'DEVICE_DELETED',
>    'data': { '*device': 'str', 'path': 'str' } }
> +
> +##
> +# @x-sysbus-mmio-map:
> +#
> +# Map a sysbus device mmio onto the main system bus.
> +#
> +# @device: the device's QOM path
> +#
> +# @mmio: The mmio number to be mapped (defaults to 0).
> +#
> +# @addr: The base address for the mapping.
> +#
> +# Since: 6.2
> +#
> +# Returns: Nothing on success
> +#
> +##
> +
> +{ 'command': 'x-sysbus-mmio-map',
> +  'data': {'device': 'str', '*mmio': 'uint8', 'addr': 'uint64'},
> +  'allow-preconfig' : true }
> diff --git a/hw/core/sysbus.c b/hw/core/sysbus.c
> index aaae8e23cc..b0891f37b6 100644
> --- a/hw/core/sysbus.c
> +++ b/hw/core/sysbus.c
> @@ -23,6 +23,7 @@
>  #include "hw/sysbus.h"
>  #include "monitor/monitor.h"
>  #include "exec/address-spaces.h"
> +#include "qapi/qapi-commands-qdev.h"
>
>  static void sysbus_dev_print(Monitor *mon, DeviceState *dev, int indent);
>  static char *sysbus_get_fw_dev_path(DeviceState *dev);
> @@ -154,6 +155,46 @@ static void sysbus_mmio_map_common(SysBusDevice *dev, int n, hwaddr addr,
>      }
>  }
>
> +void qmp_x_sysbus_mmio_map(const char *device, bool has_mmio, uint8_t mmio,
> +                           uint64_t addr, Error **errp)
> +{
> +    Object *obj = object_resolve_path_type(device, TYPE_SYS_BUS_DEVICE, NULL);
> +    SysBusDevice *dev;
> +
> +    if (phase_get() != MACHINE_INIT_PHASE_INITIALIZED) {
> +        error_setg(errp, "The command is permitted only when "
> +                         "the machine is in initialized phase");
> +        return;
> +    }
> +
> +    if (obj == NULL) {
> +        error_setg(errp, "Device '%s' not found", device);
> +        return;
> +    }
> +
> +    dev = SYS_BUS_DEVICE(obj);
> +    if (!has_mmio) {
> +        mmio = 0;
> +    }
> +    if (mmio >= dev->num_mmio) {
> +        error_setg(errp, "MMIO index '%u' is out of range", mmio);
> +        return;
> +    }
> +
> +    if (dev->mmio[mmio].addr != (hwaddr)-1) {
> +        error_setg(errp, "MMIO index '%u' is already mapped", mmio);
> +        return;
> +    }
> +
> +    if (!memory_region_try_add_subregion(get_system_memory(), addr,
> +                                         dev->mmio[mmio].memory, 0,
> +                                         errp)) {
> +        return;
> +    }
> +
> +    dev->mmio[mmio].addr = addr;
> +}
> +
>  void sysbus_mmio_unmap(SysBusDevice *dev, int n)
>  {
>      assert(n >= 0 && n < dev->num_mmio);
> --
> 2.33.0
>
>


From xen-devel-bounces@lists.xenproject.org Wed Oct 13 07:45:03 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 07:45:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.207989.363991 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maYwQ-0007HH-Ib; Wed, 13 Oct 2021 07:44:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 207989.363991; Wed, 13 Oct 2021 07:44:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maYwQ-0007HA-FZ; Wed, 13 Oct 2021 07:44:46 +0000
Received: by outflank-mailman (input) for mailman id 207989;
 Wed, 13 Oct 2021 07:44:45 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=K3Kx=PB=arm.com=Penny.Zheng@srs-us1.protection.inumbo.net>)
 id 1maYwP-0007H4-8j
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 07:44:45 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com (unknown
 [40.107.21.77]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 6d8d59ac-2bf9-11ec-8160-12813bfff9fa;
 Wed, 13 Oct 2021 07:44:43 +0000 (UTC)
Received: from DB7PR02CA0017.eurprd02.prod.outlook.com (2603:10a6:10:52::30)
 by AM9PR08MB6883.eurprd08.prod.outlook.com (2603:10a6:20b:30a::22) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.25; Wed, 13 Oct
 2021 07:44:40 +0000
Received: from DB5EUR03FT051.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:10:52:cafe::48) by DB7PR02CA0017.outlook.office365.com
 (2603:10a6:10:52::30) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15 via Frontend
 Transport; Wed, 13 Oct 2021 07:44:40 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT051.mail.protection.outlook.com (10.152.21.19) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.15 via Frontend Transport; Wed, 13 Oct 2021 07:44:39 +0000
Received: ("Tessian outbound 16951d3c485e:v103");
 Wed, 13 Oct 2021 07:44:39 +0000
Received: from 43f54b14a118.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 0B0CE3E2-984E-479E-8743-F4A1EC0F6723.1; 
 Wed, 13 Oct 2021 07:44:28 +0000
Received: from EUR03-AM5-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 43f54b14a118.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Wed, 13 Oct 2021 07:44:28 +0000
Received: from VE1PR08MB5215.eurprd08.prod.outlook.com (2603:10a6:803:10a::33)
 by VE1PR08MB4752.eurprd08.prod.outlook.com (2603:10a6:802:a4::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.19; Wed, 13 Oct
 2021 07:44:26 +0000
Received: from VE1PR08MB5215.eurprd08.prod.outlook.com
 ([fe80::41d6:b115:3b22:2cd]) by VE1PR08MB5215.eurprd08.prod.outlook.com
 ([fe80::41d6:b115:3b22:2cd%2]) with mapi id 15.20.4587.026; Wed, 13 Oct 2021
 07:44:25 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6d8d59ac-2bf9-11ec-8160-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=6nCitfPeSIuMzwV8uWO5jPCEfARcGi+gmpsQHMqOA/g=;
 b=CYk7I4D4fkEmONowdHmfwyvRlVYFyRbCHnd0KhS0h/ZIdcrQI/fkCT8EoaFiN9wiIvMtU4Bl84u9JDrz01Ji1jNazsnF8adr+dVF+jLdbR2fGTmwc7qpTP+d8pXaQDZ0JKP7+JEwWF+/cBvOzdFzZ68zYP8iS9UbJ+LC0K4MBzw=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Xlqkl3cLONmlvfBqaqpdnjbvjzJgushuky8gDU2hgHGq9c9WRbcxFdc5nwAryqdfPVjCWFsOU4l28pVOAJXPp1mnN6c/Rd7+1kuhxdzPqepwIV6MqQwX8isGK0fpj4GQjhn8amOsCj5So1Nf2Z2sR1K4oHv1poDrzZF8Cm20+a4aIPSSkbG58bG8GzLy+qUy7XCaNEXTwEMHX14G7StSvSbhAPJhfzN7hN0IVAvi5Y0a6dNkrVCHtdG5NQRjdo5OS/ydZCTbQ8KwEdoA4VF9RvQR9zuWuG4cVxl4+So0jIHiL7YWCxqKRWlX+YIfdX9jAZxoL89dIxmUq+rP44t89A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=6nCitfPeSIuMzwV8uWO5jPCEfARcGi+gmpsQHMqOA/g=;
 b=OfVkU2eQamCjGIG2j3RVcCcbNL25nQ+VAL3YaxAbp4IFqAwSxAEwiC1at8hSrPX651/S5Ofp6UkgW7BpWsoO2C/gEd+4gHllyzM05CV2efE5EmkmvdEOj25Eustfjw88kKtFeWwo3uPQKGAq5iND2kerICcXB/atBrYQXwICVv6as+4RyGbF0nRkRlQwCje4REBXYuqY/ZuPcGkvCyjC3wuUZ/vPgG1BHMIQPxw17V0MRE4uzFhqWdVEdrZwTcLiTjLfMA1AqdMYwZaM5IC0FDRjdh2MAtKkN3bfwrz045t+nGrVBH5gDq9UA+jdBjvNi7JAS88B0xRnLYpVY6KHEQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=6nCitfPeSIuMzwV8uWO5jPCEfARcGi+gmpsQHMqOA/g=;
 b=CYk7I4D4fkEmONowdHmfwyvRlVYFyRbCHnd0KhS0h/ZIdcrQI/fkCT8EoaFiN9wiIvMtU4Bl84u9JDrz01Ji1jNazsnF8adr+dVF+jLdbR2fGTmwc7qpTP+d8pXaQDZ0JKP7+JEwWF+/cBvOzdFzZ68zYP8iS9UbJ+LC0K4MBzw=
From: Penny Zheng <Penny.Zheng@arm.com>
To: Julien Grall <julien@xen.org>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, "sstabellini@kernel.org"
	<sstabellini@kernel.org>
CC: Bertrand Marquis <Bertrand.Marquis@arm.com>, Wei Chen <Wei.Chen@arm.com>
Subject: RE: [PATCH 10/11] xen/arm: device assignment on 1:1 direct-map domain
Thread-Topic: [PATCH 10/11] xen/arm: device assignment on 1:1 direct-map
 domain
Thread-Index: AQHXsCjEx0HGlBpA+Em1L92CXDXaB6uxe3AAgBj87fCAA0mcAIAC50BA
Date: Wed, 13 Oct 2021 07:44:25 +0000
Message-ID:
 <VE1PR08MB5215AAFF71A1A6CDE19A50EFF7B79@VE1PR08MB5215.eurprd08.prod.outlook.com>
References: <20210923031115.1429719-1-penny.zheng@arm.com>
 <20210923031115.1429719-11-penny.zheng@arm.com>
 <c6730ec5-53c7-9bf2-4620-eefbc7c7c4a3@xen.org>
 <VE1PR08MB5215A1D5695F388F17C367D4F7B39@VE1PR08MB5215.eurprd08.prod.outlook.com>
 <9237c85c-87d0-14ac-07ce-244958add7d3@xen.org>
In-Reply-To: <9237c85c-87d0-14ac-07ce-244958add7d3@xen.org>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: 917768E1A65C7045B6851957F5030F27.0
x-checkrecipientchecked: true
Authentication-Results-Original: xen.org; dkim=none (message not signed)
 header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: cc9335a8-36b5-4f77-7a85-08d98e1d502e
x-ms-traffictypediagnostic: VE1PR08MB4752:|AM9PR08MB6883:
x-ms-exchange-transport-forked: True
X-Microsoft-Antispam-PRVS:
	<AM9PR08MB68839106B778169B63C24CBDF7B79@AM9PR08MB6883.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:9508;OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 PEamti4gSrGagiq00Ot8S3iNXqGeo077h6DMgxg82j18Og9n8QjXOjmJRiDzLM420wV8053eXnwpVcR0yPqaBR9OvnPUM0vcSyNbEKnbyyKq45FMIxaSbkdEGlCLScpXR3TcD+xo6gOCuer71JICSmjxZGgPnso5fv5L94UtuupfY40X/jnkaetQS6vU+9AuH/qL4gjajr1dV5WgdvvR1ZLE0ord0bZamB9vKilp6dC2QXQjOCUMANCizbldyWkrygZT9NOh+tJj6LKrUlyMK5QzHVmXHU1Zm30TgIfnxCHe1MKTV92oK8BurAGSZKnp63ARxnR0cB++Gat+Q6pzvXwR6H72/HTZOxmF5k0PFVWp5rN0SnCHLzw00xXWm0tAySxM3Ga9eynyBjcTFin+ODGJ7WI1O/QzJf2RKszfcRaKHyxPGjNhNyYyyv1zXJKRemqNOlCaM+5D9Zdu9jLL/5bOqiOpL47EtwXvcW893TdO5lyfur2JkpRvo5vosXtEhKzqMadUpzJDsUEDGDa0sgpR+T+7T//rkW5WjC/xtjbMLMualKkOarnO3YYK8TgrNS9FJx37JmT7PNcplTtEa17+cuR6jAzQ47mwD/GVCQh2kBADCQK4RpKTdj9mSQinUtvTZKaZz1yYaR+84Fw3mdrqLga6jR91CWJraxJytts+Z+zoShezonIXucJczKWB8TNd7XcvjXl7/rfcSqnS2w==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR08MB5215.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(4326008)(53546011)(71200400001)(6506007)(64756008)(66476007)(66446008)(508600001)(66556008)(52536014)(76116006)(83380400001)(2906002)(38070700005)(9686003)(55016002)(8936002)(66946007)(33656002)(8676002)(86362001)(5660300002)(7696005)(122000001)(316002)(54906003)(38100700002)(110136005)(186003)(26005);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB4752
Original-Authentication-Results: xen.org; dkim=none (message not signed)
 header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT051.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	28a49529-314d-41a4-9c39-08d98e1d47bd
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	42+oUETwkdaZbA5F4xHHlMJDjDmh0iBFzgx92ykatd4W0KDeL7WtkBbhTBNXzQ+m1SY6REh34bI+YQF7gzaMgVIiQSy6Vp9H1GEyAR466WzUKBdIHLe2hMGCeDKVkf7RvbpF3Hbxg7BN9o9K6puFSsX2Q1Vfqcjk6ql43YNQPc6k9Y3U7zPyWZOGSJVFNZx5RsMXsroH6bETWVxr1z+Yu6sVU7z7M6xdtuKvkObC2otjXoKC7f5mNrMdPxN6JRIn3HGW9/D95StmuAGDPdgsAztQfUukwjoDxXN7z9hzp3tNI1ILV7JSTHUpE5CihGmSvh7DmQuAvb+TikYKJLSKaMERanCo3M5XE99ChXZbamoG8RTNMl2DArnokfJoChOK0YXAwzrk3IH/nymllj0Kcv7EVTNFpTHTZlzeXTttFUaMmaQBCua3yxLGug+kl1t8GMPVvJ5+n5uHhyGk/MdH31PEqfUcPjBqctYtpVVK9TZajgrte7QYi8wVzaL4muiMZwSoLioTZlHRvWwnNT/hvG5HV6sXrpUv//RU8rWO+QrsWWpcSLDt3UOw4IWNgIdj0AOGYJPy589hnhmWzvG6vfNGE720KJ95qK/BqKmMuyDJIxHdlUwVEkqVBZAzZyhGUe3WaHHMc5v/7Odl/fbHno285Dg75xvkhB242o2tYU6pcD3CWzA7SPjmDxfghC5U
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(53546011)(508600001)(2906002)(4326008)(26005)(33656002)(186003)(6506007)(8676002)(83380400001)(336012)(8936002)(70206006)(55016002)(7696005)(9686003)(82310400003)(70586007)(47076005)(81166007)(36860700001)(316002)(110136005)(54906003)(5660300002)(356005)(86362001)(52536014);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2021 07:44:39.9984
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: cc9335a8-36b5-4f77-7a85-08d98e1d502e
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT051.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB6883

SGkgSnVsaWVuDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogSnVsaWVu
IEdyYWxsIDxqdWxpZW5AeGVuLm9yZz4NCj4gU2VudDogTW9uZGF5LCBPY3RvYmVyIDExLCAyMDIx
IDc6MTQgUE0NCj4gVG86IFBlbm55IFpoZW5nIDxQZW5ueS5aaGVuZ0Bhcm0uY29tPjsgeGVuLWRl
dmVsQGxpc3RzLnhlbnByb2plY3Qub3JnOw0KPiBzc3RhYmVsbGluaUBrZXJuZWwub3JnDQo+IENj
OiBCZXJ0cmFuZCBNYXJxdWlzIDxCZXJ0cmFuZC5NYXJxdWlzQGFybS5jb20+OyBXZWkgQ2hlbg0K
PiA8V2VpLkNoZW5AYXJtLmNvbT4NCj4gU3ViamVjdDogUmU6IFtQQVRDSCAxMC8xMV0geGVuL2Fy
bTogZGV2aWNlIGFzc2lnbm1lbnQgb24gMToxIGRpcmVjdC1tYXANCj4gZG9tYWluDQo+IA0KPiAN
Cj4gDQo+IE9uIDA5LzEwLzIwMjEgMTA6NDAsIFBlbm55IFpoZW5nIHdyb3RlOg0KPiA+IEhpIEp1
bGllbg0KPiANCj4gSGkgUGVubnksDQo+IA0KPiA+DQo+ID4+IC0tLS0tT3JpZ2luYWwgTWVzc2Fn
ZS0tLS0tDQo+ID4+IEZyb206IEp1bGllbiBHcmFsbCA8anVsaWVuQHhlbi5vcmc+DQo+ID4+IFNl
bnQ6IFRodXJzZGF5LCBTZXB0ZW1iZXIgMjMsIDIwMjEgNzoyNyBQTQ0KPiA+PiBUbzogUGVubnkg
WmhlbmcgPFBlbm55LlpoZW5nQGFybS5jb20+Ow0KPiA+PiB4ZW4tZGV2ZWxAbGlzdHMueGVucHJv
amVjdC5vcmc7IHNzdGFiZWxsaW5pQGtlcm5lbC5vcmcNCj4gPj4gQ2M6IEJlcnRyYW5kIE1hcnF1
aXMgPEJlcnRyYW5kLk1hcnF1aXNAYXJtLmNvbT47IFdlaSBDaGVuDQo+ID4+IDxXZWkuQ2hlbkBh
cm0uY29tPg0KPiA+PiBTdWJqZWN0OiBSZTogW1BBVENIIDEwLzExXSB4ZW4vYXJtOiBkZXZpY2Ug
YXNzaWdubWVudCBvbiAxOjENCj4gPj4gZGlyZWN0LW1hcCBkb21haW4NCj4gPj4NCj4gPj4gSGks
DQo+ID4+DQo+ID4+IE9uIDIzLzA5LzIwMjEgMDg6MTEsIFBlbm55IFpoZW5nIHdyb3RlOg0KPiA+
Pj4gVXNlciBjb3VsZCBkbyBkZXZpY2UgcGFzc3Rocm91Z2gsIHdpdGgNCj4gPj4+ICJ4ZW4sZm9y
Y2UtYXNzaWduLXdpdGhvdXQtaW9tbXUiIGluIHRoZSBkZXZpY2UgdHJlZSBzbmlwcGV0LCBvbg0K
PiA+Pj4gdHJ1c3RlZCBndWVzdCB0aHJvdWdoIDE6MSBkaXJlY3QtbWFwLCBpZiBJT01NVSBhYnNl
bnQgb3IgZGlzYWJsZWQgb24NCj4gPj4gaGFyZHdhcmUuDQo+ID4+DQo+ID4+IEF0IHRoZSBtb21l
bnQsIGl0IHdvdWxkIGJlIHBvc3NpYmxlIHRvIHBhc3N0aHJvdWdoIGEgbm9uLURNQSBjYXBhYmxl
DQo+ID4+IGRldmljZSB3aXRoIGRpcmVjdC1tYXBwaW5nLiBBZnRlciB0aGlzIHBhdGNoLCB0aGlz
IGlzIGdvaW5nIHRvIGJlIGZvcmJpZGRlbi4NCj4gPj4NCj4gPj4+DQo+ID4+PiBJbiBvcmRlciB0
byBhY2hpZXZlIHRoYXQsIHRoaXMgcGF0Y2ggYWRkcyAxOjEgZGlyZWN0LW1hcCBjaGVjayBhbmQN
Cj4gPj4+IGRpc2FibGVzIGlvbW11LXJlbGF0ZWQgYWN0aW9uLg0KPiA+Pj4NCj4gPj4+IFNpZ25l
ZC1vZmYtYnk6IFBlbm55IFpoZW5nIDxwZW5ueS56aGVuZ0Bhcm0uY29tPg0KPiA+Pj4gLS0tDQo+
ID4+PiAgICB4ZW4vYXJjaC9hcm0vZG9tYWluX2J1aWxkLmMgfCAxMiArKysrKysrKy0tLS0NCj4g
Pj4+ICAgIDEgZmlsZSBjaGFuZ2VkLCA4IGluc2VydGlvbnMoKyksIDQgZGVsZXRpb25zKC0pDQo+
ID4+Pg0KPiA+Pj4gZGlmZiAtLWdpdCBhL3hlbi9hcmNoL2FybS9kb21haW5fYnVpbGQuYw0KPiA+
Pj4gYi94ZW4vYXJjaC9hcm0vZG9tYWluX2J1aWxkLmMgaW5kZXggYzkyZTUxMGFlNy4uOWE5ZDI1
MjJiNyAxMDA2NDQNCj4gPj4+IC0tLSBhL3hlbi9hcmNoL2FybS9kb21haW5fYnVpbGQuYw0KPiA+
Pj4gKysrIGIveGVuL2FyY2gvYXJtL2RvbWFpbl9idWlsZC5jDQo+ID4+PiBAQCAtMjA3MCwxNCAr
MjA3MCwxOCBAQCBzdGF0aWMgaW50IF9faW5pdA0KPiA+PiBoYW5kbGVfcGFzc3Rocm91Z2hfcHJv
cChzdHJ1Y3Qga2VybmVsX2luZm8gKmtpbmZvLA0KPiA+Pj4gICAgICAgIGlmICggcmVzIDwgMCAp
DQo+ID4+PiAgICAgICAgICAgIHJldHVybiByZXM7DQo+ID4+Pg0KPiA+Pj4gKyAgICAvKg0KPiA+
Pj4gKyAgICAgKiBJZiB4ZW5fZm9yY2UsIHdlIGFsbG93IGFzc2lnbm1lbnQgb2YgZGV2aWNlcyB3
aXRob3V0IElPTU1VDQo+ID4+IHByb3RlY3Rpb24uDQo+ID4+PiArICAgICAqIEFuZCBpZiBJT01N
VSBpcyBkaXNhYmxlZCBvciBhYnNlbnQsIDE6MSBkaXJlY3QtbWFwIGlzDQo+ID4+PiArIG5lY2Vz
c2FyeSA+ICsNCj4gPj4gKi8NCj4gPj4+ICsgICAgaWYgKCB4ZW5fZm9yY2UgJiYgaXNfZG9tYWlu
X2RpcmVjdF9tYXBwZWQoa2luZm8tPmQpICYmDQo+ID4+PiArICAgICAgICAgIWR0X2RldmljZV9p
c19wcm90ZWN0ZWQobm9kZSkgKQ0KPiA+Pg0KPiA+PiBkdF9kZXZpY2VfaXNfcHJvdGVjdGVkKCkg
d2lsbCBiZSBhbHdheXMgZmFsc2UgdW5sZXNzIHRoZSBkZXZpY2UgaXMNCj4gPj4gcHJvdGVjdGVk
IGJlaGluZyBhbiBTTU1VIHVzaW5nIHRoZSBsZWdhY3kgYmluZGluZy4gU28gSSBkb24ndCB0aGlu
aw0KPiA+PiB0aGlzIGlzIGNvcnJlY3QgdG8gbW92ZSB0aGlzIGNoZWNrIGFoZWFkLiBJbiBmYWN0
Li4NCj4gPj4NCj4gPj4+ICsgICAgICAgIHJldHVybiAwOw0KPiA+Pj4gKw0KPiA+Pj4gICAgICAg
IHJlcyA9IGlvbW11X2FkZF9kdF9kZXZpY2Uobm9kZSk7DQo+ID4+DQo+ID4+IC4uLiB0aGUgY2Fs
bCBzaG91bGQgYWxyZWFkeSBiZSBhIE5PUCB3aGVuIHRoZSBJT01NVSBpcyBkaXNhYmxlZCBvcg0K
PiA+PiB0aGUgZGV2aWNlIGlzIG5vdCBiZWhpbmQgYW4gSU9NTVUuIFNvIGNhbiB5b3UgZXhwbGFp
biB3aGF0IHlvdSBhcmUNCj4gPj4gdHJ5aW5nIHRvIHByZXZlbnQgaGVyZT8NCj4gPj4NCj4gPg0K
PiA+IElmIHRoZSBJT01NVSBpcyBkaXNhYmxlZCwgaW9tbXVfYWRkX2R0X2RldmljZSB3aWxsIHJl
dHVybiAxIGFzIGVycm5vLg0KPiA+IFNvIHdlIGNvdWxkIG5vdCBtYWtlIGl0IHRvIHRoZSB4ZW5f
Zm9yY2UgY2hlY2suLi4NCj4gDQo+IEkgZGlzYWdyZWUuIFRoZSBjaGVjayBpczoNCj4gDQo+IGlm
ICggcmVzIDwgMCApDQo+ICAgIHJldHVybiByZXM7DQo+IA0KPiBHaXZlbiB0aGF0IHJlcyBpcyAx
LCB3ZSB3b3VsZG4ndCByZXR1cm4gYW5kIG1vdmUgdG8gY2hlY2sgd2hldGhlciB0aGUNCj4gYXNz
aWdubWVudCBjYW4gYmUgZG9uZS4NCj4gDQo+ID4NCj4gPiBTbyBJIHRyaWVkIHRvIG1vdmUgYWxs
IElPTU1VIGFjdGlvbiBiZWhpbmQgeGVuX2ZvcmNlIGNoZWNrLg0KPiA+DQo+ID4gTm93LCBkZXZp
Y2UgYXNzaWdubWVudCB3aXRob3V0IElPTU1VIHByb3RlY3Rpb24gaXMgb25seSBhcHBsaWNhYmxl
IG9uDQo+ID4gZGlyZWN0LW1hcCBkb21haW5zLA0KPiANCj4gSXQgaXMgZmluZSB0byBhc3NpZ24g
YSBub24tRE1BIGNhcGFibGUgZGV2aWNlIHdpdGhvdXQgZGlyZWN0LW1hcHBpbmcuIFNvIHdoeQ0K
PiBkbyB5b3Ugd2FudCB0byBhZGQgdGhpcyByZXN0cmljdGlvbj8NCj4gDQoNCldoZW4gY29uc3Ry
dWN0aW5nIGRpcmVjdC1tYXAtdjIsIGZvdW5kIHRoYXQsIGluIHhlbi9hcmNoL2FybS9kb21haW5f
YnVpbGQuYw0KDQppZiAoIGR0X2ZpbmRfY29tcGF0aWJsZV9ub2RlKG5vZGUsIE5VTEwsICJtdWx0
aWJvb3QsZGV2aWNlLXRyZWUiKSApDQogICAgZF9jZmcuZmxhZ3MgfD0gWEVOX0RPTUNUTF9DREZf
aW9tbXU7DQoNCkFuZCB0aGlzIGZsYWcgWEVOX0RPTUNUTF9DREZfaW9tbXUgZGV0ZXJtaW5lcyB3
aGV0aGVyIGlvbW11IGlzIGVuYWJsZWQuDQoNCkluIC4veGVuL2luY2x1ZGUveGVuL3NjaGVkLmgN
Cg0Kc3RhdGljIGFsd2F5c19pbmxpbmUgYm9vbCBpc19pb21tdV9lbmFibGVkKGNvbnN0IHN0cnVj
dCBkb21haW4gKmQpDQp7DQogICAgcmV0dXJuIGV2YWx1YXRlX25vc3BlYyhkLT5vcHRpb25zICYg
WEVOX0RPTUNUTF9DREZfaW9tbXUpOw0KfQ0KDQpUaGF0IGlzLCBldmVuIGlmIHdlIGFzc2lnbiBh
IG5vbi1ETUEgY2FwYWJsZSBkZXZpY2UsIHdlIHJlcXVlc3QgdGhlIHBsYXRmb3JtIHRvIGJlDQpp
b21tdSBlbmFibGVkLg0KDQo+IENoZWVycywNCj4gDQo+IC0tDQo+IEp1bGllbiBHcmFsbA0K


From xen-devel-bounces@lists.xenproject.org Wed Oct 13 07:45:59 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 07:45:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.207996.364001 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maYxR-0007t4-0V; Wed, 13 Oct 2021 07:45:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 207996.364001; Wed, 13 Oct 2021 07:45:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maYxQ-0007sx-Tk; Wed, 13 Oct 2021 07:45:48 +0000
Received: by outflank-mailman (input) for mailman id 207996;
 Wed, 13 Oct 2021 07:45:47 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=K823=PB=arm.com=michal.orzel@srs-us1.protection.inumbo.net>)
 id 1maYxP-0007sl-R5
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 07:45:47 +0000
Received: from foss.arm.com (unknown [217.140.110.172])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTP
 id 931d35ca-2bf9-11ec-8160-12813bfff9fa;
 Wed, 13 Oct 2021 07:45:45 +0000 (UTC)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5257B1FB;
 Wed, 13 Oct 2021 00:45:45 -0700 (PDT)
Received: from e123311-lin.arm.com (unknown [10.57.25.166])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 8CAC33F66F;
 Wed, 13 Oct 2021 00:45:41 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 931d35ca-2bf9-11ec-8160-12813bfff9fa
From: Michal Orzel <michal.orzel@arm.com>
To: xen-devel@lists.xenproject.org
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Ian Jackson <iwj@xenproject.org>,
	Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wl@xen.org>,
	Nick Rosbrook <rosbrookn@ainfosec.com>,
	Anthony PERARD <anthony.perard@citrix.com>,
	Juergen Gross <jgross@suse.com>,
	Christian Lindig <christian.lindig@citrix.com>,
	David Scott <dave@recoil.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	bertrand.marquis@arm.com
Subject: [PATCH v6] xen: Expose the PMU to the guests
Date: Wed, 13 Oct 2021 09:45:28 +0200
Message-Id: <20211013074528.1396-1-michal.orzel@arm.com>
X-Mailer: git-send-email 2.29.0
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Add parameter vpmu to xl domain configuration syntax
to enable the access to PMU registers by disabling
the PMU traps(currently only for ARM).

The current status is that the PMU registers are not
virtualized and the physical registers are directly
accessible when this parameter is enabled. There is no
interrupt support and Xen will not save/restore the
register values on context switches.

According to Arm Arm, section D7.1:
"The Performance Monitors Extension is common
to AArch64 operation and AArch32 operation."
That means we have an ensurance that if PMU is
present in one exception state, it must also be
present in the other.

Please note that this feature is experimental.

Signed-off-by: Michal Orzel <michal.orzel@arm.com>
Signed-off-by: Julien Grall <julien@xen.org>
Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>
Acked-by: Anthony PERARD <anthony.perard@citrix.com>
---
Changes since v5:
-extracted from the series as other patches have been merged
-fold ARM vPMU feature status in SUPPORT.md into existing section for x86
-fix coding style in libxl
Changes since v4:
-update SUPPORT.md
-move vpmu_is_available assignment after the secondary
CPUs have been brought up
-introduce masks for flags that need to be set and
for flags that are optional
Changes since v3:
-fail if vpmu is set but not supported
Changes since v2:
-remove redundant check from x86 code
-do not define bit position and mask separately
Changes since v1:
-modify vpmu parameter to be common rather than arch specific
---
 SUPPORT.md                           | 12 ++++++++++--
 docs/man/xl.cfg.5.pod.in             | 17 +++++++++++++++++
 tools/golang/xenlight/helpers.gen.go |  6 ++++++
 tools/golang/xenlight/types.gen.go   |  1 +
 tools/include/libxl.h                |  6 ++++++
 tools/libs/light/libxl_create.c      | 10 ++++++++++
 tools/libs/light/libxl_types.idl     |  2 ++
 tools/ocaml/libs/xc/xenctrl.ml       |  1 +
 tools/ocaml/libs/xc/xenctrl.mli      |  1 +
 tools/xl/xl_parse.c                  |  2 ++
 xen/arch/arm/domain.c                | 13 ++++++++++---
 xen/arch/arm/setup.c                 |  3 +++
 xen/common/domain.c                  | 10 +++++++++-
 xen/include/asm-arm/domain.h         |  1 +
 xen/include/public/domctl.h          |  4 +++-
 15 files changed, 82 insertions(+), 7 deletions(-)

diff --git a/SUPPORT.md b/SUPPORT.md
index 317392d8f3..d0305abc0b 100644
--- a/SUPPORT.md
+++ b/SUPPORT.md
@@ -671,11 +671,19 @@ such as KVM, Hyper-V, Bromium, and so on as guests.
 
 ### vPMU
 
-Virtual Performance Management Unit for HVM guests
+Virtual Performance Management Unit
 
     Status, x86: Supported, Not security supported
+    Status, ARM: Experimental
+
+On ARM, support for accessing PMU registers from the guests.
+There is no interrupt support and Xen will not save/restore
+the register values on context switches.
+
+Disabled by default.
+On ARM, enable with guest parameter.
+On x86, enable with hypervisor command line option.
 
-Disabled by default (enable with hypervisor command line option).
 This feature is not security supported: see https://xenbits.xen.org/xsa/advisory-163.html
 
 ### Argo: Inter-domain message delivery by hypercall
diff --git a/docs/man/xl.cfg.5.pod.in b/docs/man/xl.cfg.5.pod.in
index 4b1e3028d2..55c4881205 100644
--- a/docs/man/xl.cfg.5.pod.in
+++ b/docs/man/xl.cfg.5.pod.in
@@ -690,6 +690,23 @@ default.
 B<NOTE>: Acceptable values are platform specific.  For Intel Processor
 Trace, this value must be a power of 2 between 4k and 16M.
 
+=item B<vpmu=BOOLEAN>
+
+Currently ARM only.
+
+Specifies whether to enable the access to PMU registers by disabling
+the PMU traps.
+
+The PMU registers are not virtualized and the physical registers are directly
+accessible when this parameter is enabled. There is no interrupt support and
+Xen will not save/restore the register values on context switches.
+
+vPMU, by design and purpose, exposes system level performance
+information to the guest. Only to be used by sufficiently privileged
+domains. This feature is currently in experimental state.
+
+If this option is not specified then it will default to B<false>.
+
 =back
 
 =head2 Devices
diff --git a/tools/golang/xenlight/helpers.gen.go b/tools/golang/xenlight/helpers.gen.go
index c8669837d8..2449580bad 100644
--- a/tools/golang/xenlight/helpers.gen.go
+++ b/tools/golang/xenlight/helpers.gen.go
@@ -1119,6 +1119,9 @@ return fmt.Errorf("converting field ArchX86.MsrRelaxed: %v", err)
 }
 x.Altp2M = Altp2MMode(xc.altp2m)
 x.VmtraceBufKb = int(xc.vmtrace_buf_kb)
+if err := x.Vpmu.fromC(&xc.vpmu);err != nil {
+return fmt.Errorf("converting field Vpmu: %v", err)
+}
 
  return nil}
 
@@ -1600,6 +1603,9 @@ return fmt.Errorf("converting field ArchX86.MsrRelaxed: %v", err)
 }
 xc.altp2m = C.libxl_altp2m_mode(x.Altp2M)
 xc.vmtrace_buf_kb = C.int(x.VmtraceBufKb)
+if err := x.Vpmu.toC(&xc.vpmu); err != nil {
+return fmt.Errorf("converting field Vpmu: %v", err)
+}
 
  return nil
  }
diff --git a/tools/golang/xenlight/types.gen.go b/tools/golang/xenlight/types.gen.go
index 45f2cba3d2..b2e8bd1a85 100644
--- a/tools/golang/xenlight/types.gen.go
+++ b/tools/golang/xenlight/types.gen.go
@@ -521,6 +521,7 @@ MsrRelaxed Defbool
 }
 Altp2M Altp2MMode
 VmtraceBufKb int
+Vpmu Defbool
 }
 
 type DomainBuildInfoTypeUnion interface {
diff --git a/tools/include/libxl.h b/tools/include/libxl.h
index ec5e3badae..ee73eb06f1 100644
--- a/tools/include/libxl.h
+++ b/tools/include/libxl.h
@@ -508,6 +508,12 @@
  */
 #define LIBXL_HAVE_PHYSINFO_CAP_VPMU 1
 
+/*
+ * LIBXL_HAVE_VPMU indicates that libxl_domain_build_info has a vpmu parameter,
+ * which allows to enable the access to PMU registers.
+ */
+#define LIBXL_HAVE_VPMU 1
+
 /*
  * libxl ABI compatibility
  *
diff --git a/tools/libs/light/libxl_create.c b/tools/libs/light/libxl_create.c
index e356b2106d..6ebb2bfc76 100644
--- a/tools/libs/light/libxl_create.c
+++ b/tools/libs/light/libxl_create.c
@@ -91,6 +91,7 @@ int libxl__domain_build_info_setdefault(libxl__gc *gc,
     }
 
     libxl_defbool_setdefault(&b_info->device_model_stubdomain, false);
+    libxl_defbool_setdefault(&b_info->vpmu, false);
 
     if (libxl_defbool_val(b_info->device_model_stubdomain) &&
         !b_info->device_model_ssidref)
@@ -622,6 +623,9 @@ int libxl__domain_make(libxl__gc *gc, libxl_domain_config *d_config,
                 create.flags |= XEN_DOMCTL_CDF_nested_virt;
         }
 
+        if (libxl_defbool_val(b_info->vpmu))
+            create.flags |= XEN_DOMCTL_CDF_vpmu;
+
         assert(info->passthrough != LIBXL_PASSTHROUGH_DEFAULT);
         LOG(DETAIL, "passthrough: %s",
             libxl_passthrough_to_string(info->passthrough));
@@ -1199,6 +1203,12 @@ int libxl__domain_config_setdefault(libxl__gc *gc,
         goto error_out;
     }
 
+    if (libxl_defbool_val(d_config->b_info.vpmu) && !physinfo.cap_vpmu) {
+        ret = ERROR_INVAL;
+        LOGD(ERROR, domid, "vPMU not supported on this platform");
+        goto error_out;
+    }
+
     ret = 0;
  error_out:
     return ret;
diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_types.idl
index 993e83acca..b96fb5c47e 100644
--- a/tools/libs/light/libxl_types.idl
+++ b/tools/libs/light/libxl_types.idl
@@ -655,6 +655,8 @@ libxl_domain_build_info = Struct("domain_build_info",[
     # Use zero value to disable this feature.
     ("vmtrace_buf_kb", integer),
 
+    ("vpmu", libxl_defbool),
+
     ], dir=DIR_IN,
        copy_deprecated_fn="libxl__domain_build_info_copy_deprecated",
 )
diff --git a/tools/ocaml/libs/xc/xenctrl.ml b/tools/ocaml/libs/xc/xenctrl.ml
index 7a4030a192..86758babb3 100644
--- a/tools/ocaml/libs/xc/xenctrl.ml
+++ b/tools/ocaml/libs/xc/xenctrl.ml
@@ -70,6 +70,7 @@ type domain_create_flag =
 	| CDF_IOMMU
 	| CDF_NESTED_VIRT
 	| CDF_VPCI
+	| CDF_VPMU
 
 type domain_create_iommu_opts =
 	| IOMMU_NO_SHAREPT
diff --git a/tools/ocaml/libs/xc/xenctrl.mli b/tools/ocaml/libs/xc/xenctrl.mli
index 6900513e7f..0fdb0cc169 100644
--- a/tools/ocaml/libs/xc/xenctrl.mli
+++ b/tools/ocaml/libs/xc/xenctrl.mli
@@ -63,6 +63,7 @@ type domain_create_flag =
   | CDF_IOMMU
   | CDF_NESTED_VIRT
   | CDF_VPCI
+  | CDF_VPMU
 
 type domain_create_iommu_opts =
   | IOMMU_NO_SHAREPT
diff --git a/tools/xl/xl_parse.c b/tools/xl/xl_parse.c
index 17dddb4cd5..c503b9be00 100644
--- a/tools/xl/xl_parse.c
+++ b/tools/xl/xl_parse.c
@@ -2750,6 +2750,8 @@ skip_usbdev:
                     "If it fixes an issue you are having please report to "
                     "xen-devel@lists.xenproject.org.\n");
 
+    xlu_cfg_get_defbool(config, "vpmu", &b_info->vpmu, 0);
+
     xlu_cfg_destroy(config);
 }
 
diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
index aae4472479..ad21c9b950 100644
--- a/xen/arch/arm/domain.c
+++ b/xen/arch/arm/domain.c
@@ -276,6 +276,8 @@ static void ctxt_switch_to(struct vcpu *n)
      * timer. The interrupt needs to be injected into the guest. */
     WRITE_SYSREG(n->arch.cntkctl, CNTKCTL_EL1);
     virt_timer_restore(n);
+
+    WRITE_SYSREG(n->arch.mdcr_el2, MDCR_EL2);
 }
 
 /* Update per-VCPU guest runstate shared memory area (if registered). */
@@ -586,6 +588,10 @@ int arch_vcpu_create(struct vcpu *v)
 
     v->arch.hcr_el2 = get_default_hcr_flags();
 
+    v->arch.mdcr_el2 = HDCR_TDRA | HDCR_TDOSA | HDCR_TDA;
+    if ( !(v->domain->options & XEN_DOMCTL_CDF_vpmu) )
+        v->arch.mdcr_el2 |= HDCR_TPM | HDCR_TPMCR;
+
     if ( (rc = vcpu_vgic_init(v)) != 0 )
         goto fail;
 
@@ -621,10 +627,11 @@ void vcpu_switch_to_aarch64_mode(struct vcpu *v)
 int arch_sanitise_domain_config(struct xen_domctl_createdomain *config)
 {
     unsigned int max_vcpus;
+    unsigned int flags_required = (XEN_DOMCTL_CDF_hvm | XEN_DOMCTL_CDF_hap);
+    unsigned int flags_optional = (XEN_DOMCTL_CDF_iommu | XEN_DOMCTL_CDF_vpci |
+                                   XEN_DOMCTL_CDF_vpmu);
 
-    /* HVM and HAP must be set. IOMMU and VPCI may or may not be */
-    if ( (config->flags & ~XEN_DOMCTL_CDF_iommu & ~XEN_DOMCTL_CDF_vpci) !=
-         (XEN_DOMCTL_CDF_hvm | XEN_DOMCTL_CDF_hap) )
+    if ( (config->flags & ~flags_optional) != flags_required )
     {
         dprintk(XENLOG_INFO, "Unsupported configuration %#x\n",
                 config->flags);
diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c
index 49dc90d198..d5d0792ed4 100644
--- a/xen/arch/arm/setup.c
+++ b/xen/arch/arm/setup.c
@@ -999,6 +999,9 @@ void __init start_xen(unsigned long boot_phys_offset,
     printk("Brought up %ld CPUs\n", (long)num_online_cpus());
     /* TODO: smp_cpus_done(); */
 
+    /* This should be done in a vpmu driver but we do not have one yet. */
+    vpmu_is_available = cpu_has_pmu;
+
     /*
      * The IOMMU subsystem must be initialized before P2M as we need
      * to gather requirements regarding the maximum IPA bits supported by
diff --git a/xen/common/domain.c b/xen/common/domain.c
index 262b6c0c3c..8543fb54fd 100644
--- a/xen/common/domain.c
+++ b/xen/common/domain.c
@@ -480,12 +480,14 @@ static int sanitise_domain_config(struct xen_domctl_createdomain *config)
     bool hvm = config->flags & XEN_DOMCTL_CDF_hvm;
     bool hap = config->flags & XEN_DOMCTL_CDF_hap;
     bool iommu = config->flags & XEN_DOMCTL_CDF_iommu;
+    bool vpmu = config->flags & XEN_DOMCTL_CDF_vpmu;
 
     if ( config->flags &
          ~(XEN_DOMCTL_CDF_hvm | XEN_DOMCTL_CDF_hap |
            XEN_DOMCTL_CDF_s3_integrity | XEN_DOMCTL_CDF_oos_off |
            XEN_DOMCTL_CDF_xs_domain | XEN_DOMCTL_CDF_iommu |
-           XEN_DOMCTL_CDF_nested_virt | XEN_DOMCTL_CDF_vpci) )
+           XEN_DOMCTL_CDF_nested_virt | XEN_DOMCTL_CDF_vpci |
+           XEN_DOMCTL_CDF_vpmu) )
     {
         dprintk(XENLOG_INFO, "Unknown CDF flags %#x\n", config->flags);
         return -EINVAL;
@@ -534,6 +536,12 @@ static int sanitise_domain_config(struct xen_domctl_createdomain *config)
         return -EINVAL;
     }
 
+    if ( vpmu && !vpmu_is_available )
+    {
+        dprintk(XENLOG_INFO, "vpmu requested but cannot be enabled this way\n");
+        return -EINVAL;
+    }
+
     return arch_sanitise_domain_config(config);
 }
 
diff --git a/xen/include/asm-arm/domain.h b/xen/include/asm-arm/domain.h
index c9277b5c6d..14e575288f 100644
--- a/xen/include/asm-arm/domain.h
+++ b/xen/include/asm-arm/domain.h
@@ -166,6 +166,7 @@ struct arch_vcpu
 
     /* HYP configuration */
     register_t hcr_el2;
+    register_t mdcr_el2;
 
     uint32_t teecr, teehbr; /* ThumbEE, 32-bit guests only */
 #ifdef CONFIG_ARM_32
diff --git a/xen/include/public/domctl.h b/xen/include/public/domctl.h
index 4cb3f662c2..a53cbd16f4 100644
--- a/xen/include/public/domctl.h
+++ b/xen/include/public/domctl.h
@@ -71,9 +71,11 @@ struct xen_domctl_createdomain {
 #define _XEN_DOMCTL_CDF_nested_virt   6
 #define XEN_DOMCTL_CDF_nested_virt    (1U << _XEN_DOMCTL_CDF_nested_virt)
 #define XEN_DOMCTL_CDF_vpci           (1U << 7)
+/* Should we expose the vPMU to the guest? */
+#define XEN_DOMCTL_CDF_vpmu           (1U << 8)
 
 /* Max XEN_DOMCTL_CDF_* constant.  Used for ABI checking. */
-#define XEN_DOMCTL_CDF_MAX XEN_DOMCTL_CDF_vpci
+#define XEN_DOMCTL_CDF_MAX XEN_DOMCTL_CDF_vpmu
 
     uint32_t flags;
 
-- 
2.29.0



From xen-devel-bounces@lists.xenproject.org Wed Oct 13 07:52:27 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 07:52:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.208008.364016 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maZ3d-0000y0-PG; Wed, 13 Oct 2021 07:52:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 208008.364016; Wed, 13 Oct 2021 07:52:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maZ3d-0000xt-LR; Wed, 13 Oct 2021 07:52:13 +0000
Received: by outflank-mailman (input) for mailman id 208008;
 Wed, 13 Oct 2021 07:52:12 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=K3Kx=PB=arm.com=Penny.Zheng@srs-us1.protection.inumbo.net>)
 id 1maZ3c-0000xn-Ff
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 07:52:12 +0000
Received: from EUR05-AM6-obe.outbound.protection.outlook.com (unknown
 [2a01:111:f400:7e1b::62f])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 406b65bb-7cd3-454b-b717-7c0da660af3a;
 Wed, 13 Oct 2021 07:52:09 +0000 (UTC)
Received: from DB6PR0501CA0035.eurprd05.prod.outlook.com (2603:10a6:4:67::21)
 by VI1PR0802MB2560.eurprd08.prod.outlook.com (2603:10a6:800:ad::8)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15; Wed, 13 Oct
 2021 07:52:07 +0000
Received: from DB5EUR03FT020.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:4:67:cafe::d8) by DB6PR0501CA0035.outlook.office365.com
 (2603:10a6:4:67::21) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.14 via Frontend
 Transport; Wed, 13 Oct 2021 07:52:07 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT020.mail.protection.outlook.com (10.152.20.134) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.15 via Frontend Transport; Wed, 13 Oct 2021 07:52:07 +0000
Received: ("Tessian outbound e27daf245730:v103");
 Wed, 13 Oct 2021 07:52:07 +0000
Received: from 4b8d9bb8ea07.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 B4069505-B476-4454-8746-7670F46B33CE.1; 
 Wed, 13 Oct 2021 07:52:01 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 4b8d9bb8ea07.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Wed, 13 Oct 2021 07:52:01 +0000
Received: from VE1PR08MB5215.eurprd08.prod.outlook.com (2603:10a6:803:10a::33)
 by VI1PR08MB4510.eurprd08.prod.outlook.com (2603:10a6:803:fc::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15; Wed, 13 Oct
 2021 07:51:57 +0000
Received: from VE1PR08MB5215.eurprd08.prod.outlook.com
 ([fe80::41d6:b115:3b22:2cd]) by VE1PR08MB5215.eurprd08.prod.outlook.com
 ([fe80::41d6:b115:3b22:2cd%2]) with mapi id 15.20.4587.026; Wed, 13 Oct 2021
 07:51:57 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 406b65bb-7cd3-454b-b717-7c0da660af3a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=8AaT4SztkR+AXQ/RcQng7S1Fo4t3+Vlyd953aPRlwGs=;
 b=JerfVfzSUtK4/rZH88MYVxFAUSkpMto2oVdRegFZIn7qJnkKSJpWNI5W5GmUnzR35cnECqDSj6HTDpDoDgf+MEShDZ21KMR9bNooIJjtL4W2VW9zOPSKeuaHVkPqZG//mNR4xMobCSHjjbfQNfNEJcpM+FURW8BRWrtVd3uQahI=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=gGUE5Wok7ij5/MHy7bd9ApXkuDLHSDtvEsb/i/y7YWX35X8GvLoic8IhVVscUn+5Zb7TNFmIM7i8pljBwvxoerOHPhg5lNgg4Dbv9JbDtGz/LGyy8WZXkeskvR+zC+/WQqtXpEQw0ktVGEgxPs71IAJ5R7gHDUxFwUvTF2JewGOfhWN5Dy0+uGjRSQ+pJIrTBp5ZQzkVDxcHc6Q05tBliL8iQKnv1GBIouGxQhJ/gpKvEaTRZh4Ucj3+AZwGs6sJIr9lE/tSX14rvjADe0SJEC/qI7PeU5I3ghJtssR5j9hoatOzhp/eesQ7ewiNP+dfW7abnwyBK6Cu2BQaW4EftA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=8AaT4SztkR+AXQ/RcQng7S1Fo4t3+Vlyd953aPRlwGs=;
 b=FcIMkGZszsadmHAUdFCiYNCIMvznxMrGWB6zqdzOwC6q5sOTCSy+f+EZteq2NfeaSK1Z4eLC6PG1BRFrKGgTQn+PPb0vtCLTZSN1hoCQdwcMojFsj91FeVdRSz6PLXmVqT9k2ZVv8AdTbQoVYPMrDHRUEwWHjXK+le5qOcVUbtV7z0Acy9meN5i9UdDdFfdPzkdGhTajHSctM07Vdn+q02dBK5KF9YkRgjLJnl9q20wTj/8IUTmNmFN8N/KA647u5a/z/gwc1L7aRjG//DIY444+SlNOPoFG34Ym/74Aa0I/bch64sbkLDWBSD6K79dYJf25BMtEx5xms1g4PMMVsw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=8AaT4SztkR+AXQ/RcQng7S1Fo4t3+Vlyd953aPRlwGs=;
 b=JerfVfzSUtK4/rZH88MYVxFAUSkpMto2oVdRegFZIn7qJnkKSJpWNI5W5GmUnzR35cnECqDSj6HTDpDoDgf+MEShDZ21KMR9bNooIJjtL4W2VW9zOPSKeuaHVkPqZG//mNR4xMobCSHjjbfQNfNEJcpM+FURW8BRWrtVd3uQahI=
From: Penny Zheng <Penny.Zheng@arm.com>
To: Julien Grall <julien@xen.org>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, "sstabellini@kernel.org"
	<sstabellini@kernel.org>
CC: Bertrand Marquis <Bertrand.Marquis@arm.com>, Wei Chen <Wei.Chen@arm.com>
Subject: RE: [PATCH 10/11] xen/arm: device assignment on 1:1 direct-map domain
Thread-Topic: [PATCH 10/11] xen/arm: device assignment on 1:1 direct-map
 domain
Thread-Index: AQHXsCjEx0HGlBpA+Em1L92CXDXaB6uxe3AAgBj87fCAA0mcAIAC50BAgAAD9KA=
Date: Wed, 13 Oct 2021 07:51:57 +0000
Message-ID:
 <VE1PR08MB5215D0769F05388F43B0F761F7B79@VE1PR08MB5215.eurprd08.prod.outlook.com>
References: <20210923031115.1429719-1-penny.zheng@arm.com>
 <20210923031115.1429719-11-penny.zheng@arm.com>
 <c6730ec5-53c7-9bf2-4620-eefbc7c7c4a3@xen.org>
 <VE1PR08MB5215A1D5695F388F17C367D4F7B39@VE1PR08MB5215.eurprd08.prod.outlook.com>
 <9237c85c-87d0-14ac-07ce-244958add7d3@xen.org>
 <VE1PR08MB5215AAFF71A1A6CDE19A50EFF7B79@VE1PR08MB5215.eurprd08.prod.outlook.com>
In-Reply-To:
 <VE1PR08MB5215AAFF71A1A6CDE19A50EFF7B79@VE1PR08MB5215.eurprd08.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: 317600F42BF9764F8DC3F30C0EFB7584.0
x-checkrecipientchecked: true
Authentication-Results-Original: xen.org; dkim=none (message not signed)
 header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: cd15b561-045e-4b69-76eb-08d98e1e5ac1
x-ms-traffictypediagnostic: VI1PR08MB4510:|VI1PR0802MB2560:
x-ms-exchange-transport-forked: True
X-Microsoft-Antispam-PRVS:
	<VI1PR0802MB25600C6D64785C8E9C59A8E7F7B79@VI1PR0802MB2560.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:9508;OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 3LsV7q80esrXy+rmCs+b8E7eleXfVrLAC+PR75WqedxDdWij1djeyhHjwQGxvsIJnExxQYRLoyIK1h+zSAlXRU890BeRQN9RFuOdhFbc1EWUY5b7KQL4Wi4fy5gI9a29W3bpFwJSxCCspz7pluf3SO9jVd8CdO8tPG/bU41m3qr7r/PcJ4Vs0qBIv9umviLwZ7g/fkrQePWzcGHbCIRWNttVWB7AVJlcxFB17RnTDpR/b/BcZtIQxNoZeCi++YEoMRFUE6HMKQ7arrDfoJQ4KL9KuRBAFU9dOCyqc/obPSPQS2uv/JJ6ImItR/6KiNuf3LaommiZElum9OF0eFdDot1SmMOvX0T64zy+kyKyLRXRnmXC3NBTGu22DqZuE+UKDYkFwj93jCdl08PqzWfzvTa6VBN3bTWbbJd4p7cdZQepKlQEYVqa4I0YBaaa6/6KEuLtnqHMqw6fesOt84tBOrfg0ouxXC3m0vKq24y+CH9BaVJG8YcKQEDYLp/DndM/tgLwjaJQOlUo20jhX7mGnCx7a2i1c7URPKwHWvjSUDbuhpM2BXLiEEVJgfdZ4YYcVgWzsf2wxvBF5CAgKWVBpSBfpCAlD+S9zi1PAht9T1tT5f0CCPyJxGWZtwE2kOME8rjYRypGesxannBTkSQc5Vu/fBePoTdTunltjpRQOvpINe1CxZU2P8j0IV7RBoKC0OcWevM8X9S3ScoLwT04fg==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR08MB5215.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(5660300002)(2940100002)(8936002)(2906002)(66946007)(8676002)(7696005)(4326008)(122000001)(64756008)(66476007)(66556008)(86362001)(38100700002)(76116006)(110136005)(54906003)(52536014)(38070700005)(55016002)(71200400001)(83380400001)(316002)(9686003)(186003)(26005)(508600001)(6506007)(53546011)(66446008)(33656002);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB4510
Original-Authentication-Results: xen.org; dkim=none (message not signed)
 header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT020.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	3f1d69d2-1dba-4da5-d1e7-08d98e1e5527
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	pMZ+jlySo9Ntx05zTR/TTsDE1wyz7KPFK++7ai0nUKAPrNe1ZM8z/b7J7CE6vBcRVyAjNRqN+mP/4TgmhWigLjTQNUbvBf8MhhSuPnSL4lMxg9mh0AFi5tFuWT8Tt6n8uyhBIP1crF4VGEOqI7LwOIlTFfJz3GuOsts645TOr5nx42u6LZrA0378kICl6BCBi6Cksu7L5CVkuTBvqNO5QbaWzq22Y38TprVu4O2uWN+4/N9H0Ys//6hr7QInDO0HHn9fF762sNOqY0RRmR9B7DsIlSzxn9a3k1LaG4Fb3UMKBkqpqGiFY4/DDDs6pssZ70a3f80CrHq9YN4dFHTpVf6QJxy8CvgnIeozoS2PtVZL6mHi9/mGYIQg5HmbJT3CTvqkOHAEEoFYLK/Dp3kIzy9jPxP/oXEAQqDOjCgPQQp1Kjrhn2reEgla6KlL40JKSeXwilgsDaqzg1RmPRCBU7COMPNMTtVd2aVqhrnRwgLrmr1xQdO4aAv7tJ+Vvm1g9H68097NFNFmbXjaACByvIhRLp/mKwfxOLph+RuZIcn5tXw+7rH+DLc4TOZI8rrAR8FVePBYSW9CvFGpQt4xSWHdpzjprYPkc4Z5hMBkJVMatUOtrXiI6p+4v8UxUEPaOMgKsBkTnhn5KmUEeXi8s+3Dz4qRWnjv7Sdn7qg+hj1QkI50F8udte2NqfNhI40e
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(8676002)(110136005)(55016002)(356005)(82310400003)(53546011)(508600001)(52536014)(316002)(2940100002)(47076005)(54906003)(186003)(6506007)(4326008)(5660300002)(70586007)(26005)(336012)(70206006)(86362001)(8936002)(81166007)(9686003)(36860700001)(33656002)(83380400001)(7696005)(2906002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2021 07:52:07.2347
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: cd15b561-045e-4b69-76eb-08d98e1e5ac1
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT020.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0802MB2560

DQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IFBlbm55IFpoZW5nDQo+IFNl
bnQ6IFdlZG5lc2RheSwgT2N0b2JlciAxMywgMjAyMSAzOjQ0IFBNDQo+IFRvOiBKdWxpZW4gR3Jh
bGwgPGp1bGllbkB4ZW4ub3JnPjsgeGVuLWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnOw0KPiBz
c3RhYmVsbGluaUBrZXJuZWwub3JnDQo+IENjOiBCZXJ0cmFuZCBNYXJxdWlzIDxCZXJ0cmFuZC5N
YXJxdWlzQGFybS5jb20+OyBXZWkgQ2hlbg0KPiA8V2VpLkNoZW5AYXJtLmNvbT4NCj4gU3ViamVj
dDogUkU6IFtQQVRDSCAxMC8xMV0geGVuL2FybTogZGV2aWNlIGFzc2lnbm1lbnQgb24gMToxIGRp
cmVjdC1tYXANCj4gZG9tYWluDQo+IA0KPiBIaSBKdWxpZW4NCj4gDQo+ID4gLS0tLS1PcmlnaW5h
bCBNZXNzYWdlLS0tLS0NCj4gPiBGcm9tOiBKdWxpZW4gR3JhbGwgPGp1bGllbkB4ZW4ub3JnPg0K
PiA+IFNlbnQ6IE1vbmRheSwgT2N0b2JlciAxMSwgMjAyMSA3OjE0IFBNDQo+ID4gVG86IFBlbm55
IFpoZW5nIDxQZW5ueS5aaGVuZ0Bhcm0uY29tPjsgeGVuLWRldmVsQGxpc3RzLnhlbnByb2plY3Qu
b3JnOw0KPiA+IHNzdGFiZWxsaW5pQGtlcm5lbC5vcmcNCj4gPiBDYzogQmVydHJhbmQgTWFycXVp
cyA8QmVydHJhbmQuTWFycXVpc0Bhcm0uY29tPjsgV2VpIENoZW4NCj4gPiA8V2VpLkNoZW5AYXJt
LmNvbT4NCj4gPiBTdWJqZWN0OiBSZTogW1BBVENIIDEwLzExXSB4ZW4vYXJtOiBkZXZpY2UgYXNz
aWdubWVudCBvbiAxOjENCj4gPiBkaXJlY3QtbWFwIGRvbWFpbg0KPiA+DQo+ID4NCj4gPg0KPiA+
IE9uIDA5LzEwLzIwMjEgMTA6NDAsIFBlbm55IFpoZW5nIHdyb3RlOg0KPiA+ID4gSGkgSnVsaWVu
DQo+ID4NCj4gPiBIaSBQZW5ueSwNCj4gPg0KPiA+ID4NCj4gPiA+PiAtLS0tLU9yaWdpbmFsIE1l
c3NhZ2UtLS0tLQ0KPiA+ID4+IEZyb206IEp1bGllbiBHcmFsbCA8anVsaWVuQHhlbi5vcmc+DQo+
ID4gPj4gU2VudDogVGh1cnNkYXksIFNlcHRlbWJlciAyMywgMjAyMSA3OjI3IFBNDQo+ID4gPj4g
VG86IFBlbm55IFpoZW5nIDxQZW5ueS5aaGVuZ0Bhcm0uY29tPjsNCj4gPiA+PiB4ZW4tZGV2ZWxA
bGlzdHMueGVucHJvamVjdC5vcmc7IHNzdGFiZWxsaW5pQGtlcm5lbC5vcmcNCj4gPiA+PiBDYzog
QmVydHJhbmQgTWFycXVpcyA8QmVydHJhbmQuTWFycXVpc0Bhcm0uY29tPjsgV2VpIENoZW4NCj4g
PiA+PiA8V2VpLkNoZW5AYXJtLmNvbT4NCj4gPiA+PiBTdWJqZWN0OiBSZTogW1BBVENIIDEwLzEx
XSB4ZW4vYXJtOiBkZXZpY2UgYXNzaWdubWVudCBvbiAxOjENCj4gPiA+PiBkaXJlY3QtbWFwIGRv
bWFpbg0KPiA+ID4+DQo+ID4gPj4gSGksDQo+ID4gPj4NCj4gPiA+PiBPbiAyMy8wOS8yMDIxIDA4
OjExLCBQZW5ueSBaaGVuZyB3cm90ZToNCj4gPiA+Pj4gVXNlciBjb3VsZCBkbyBkZXZpY2UgcGFz
c3Rocm91Z2gsIHdpdGgNCj4gPiA+Pj4gInhlbixmb3JjZS1hc3NpZ24td2l0aG91dC1pb21tdSIg
aW4gdGhlIGRldmljZSB0cmVlIHNuaXBwZXQsIG9uDQo+ID4gPj4+IHRydXN0ZWQgZ3Vlc3QgdGhy
b3VnaCAxOjEgZGlyZWN0LW1hcCwgaWYgSU9NTVUgYWJzZW50IG9yIGRpc2FibGVkDQo+ID4gPj4+
IG9uDQo+ID4gPj4gaGFyZHdhcmUuDQo+ID4gPj4NCj4gPiA+PiBBdCB0aGUgbW9tZW50LCBpdCB3
b3VsZCBiZSBwb3NzaWJsZSB0byBwYXNzdGhyb3VnaCBhIG5vbi1ETUENCj4gPiA+PiBjYXBhYmxl
IGRldmljZSB3aXRoIGRpcmVjdC1tYXBwaW5nLiBBZnRlciB0aGlzIHBhdGNoLCB0aGlzIGlzIGdv
aW5nIHRvIGJlDQo+IGZvcmJpZGRlbi4NCj4gPiA+Pg0KPiA+ID4+Pg0KPiA+ID4+PiBJbiBvcmRl
ciB0byBhY2hpZXZlIHRoYXQsIHRoaXMgcGF0Y2ggYWRkcyAxOjEgZGlyZWN0LW1hcCBjaGVjayBh
bmQNCj4gPiA+Pj4gZGlzYWJsZXMgaW9tbXUtcmVsYXRlZCBhY3Rpb24uDQo+ID4gPj4+DQo+ID4g
Pj4+IFNpZ25lZC1vZmYtYnk6IFBlbm55IFpoZW5nIDxwZW5ueS56aGVuZ0Bhcm0uY29tPg0KPiA+
ID4+PiAtLS0NCj4gPiA+Pj4gICAgeGVuL2FyY2gvYXJtL2RvbWFpbl9idWlsZC5jIHwgMTIgKysr
KysrKystLS0tDQo+ID4gPj4+ICAgIDEgZmlsZSBjaGFuZ2VkLCA4IGluc2VydGlvbnMoKyksIDQg
ZGVsZXRpb25zKC0pDQo+ID4gPj4+DQo+ID4gPj4+IGRpZmYgLS1naXQgYS94ZW4vYXJjaC9hcm0v
ZG9tYWluX2J1aWxkLmMNCj4gPiA+Pj4gYi94ZW4vYXJjaC9hcm0vZG9tYWluX2J1aWxkLmMgaW5k
ZXggYzkyZTUxMGFlNy4uOWE5ZDI1MjJiNyAxMDA2NDQNCj4gPiA+Pj4gLS0tIGEveGVuL2FyY2gv
YXJtL2RvbWFpbl9idWlsZC5jDQo+ID4gPj4+ICsrKyBiL3hlbi9hcmNoL2FybS9kb21haW5fYnVp
bGQuYw0KPiA+ID4+PiBAQCAtMjA3MCwxNCArMjA3MCwxOCBAQCBzdGF0aWMgaW50IF9faW5pdA0K
PiA+ID4+IGhhbmRsZV9wYXNzdGhyb3VnaF9wcm9wKHN0cnVjdCBrZXJuZWxfaW5mbyAqa2luZm8s
DQo+ID4gPj4+ICAgICAgICBpZiAoIHJlcyA8IDAgKQ0KPiA+ID4+PiAgICAgICAgICAgIHJldHVy
biByZXM7DQo+ID4gPj4+DQo+ID4gPj4+ICsgICAgLyoNCj4gPiA+Pj4gKyAgICAgKiBJZiB4ZW5f
Zm9yY2UsIHdlIGFsbG93IGFzc2lnbm1lbnQgb2YgZGV2aWNlcyB3aXRob3V0IElPTU1VDQo+ID4g
Pj4gcHJvdGVjdGlvbi4NCj4gPiA+Pj4gKyAgICAgKiBBbmQgaWYgSU9NTVUgaXMgZGlzYWJsZWQg
b3IgYWJzZW50LCAxOjEgZGlyZWN0LW1hcCBpcw0KPiA+ID4+PiArIG5lY2Vzc2FyeSA+ICsNCj4g
PiA+PiAqLw0KPiA+ID4+PiArICAgIGlmICggeGVuX2ZvcmNlICYmIGlzX2RvbWFpbl9kaXJlY3Rf
bWFwcGVkKGtpbmZvLT5kKSAmJg0KPiA+ID4+PiArICAgICAgICAgIWR0X2RldmljZV9pc19wcm90
ZWN0ZWQobm9kZSkgKQ0KPiA+ID4+DQo+ID4gPj4gZHRfZGV2aWNlX2lzX3Byb3RlY3RlZCgpIHdp
bGwgYmUgYWx3YXlzIGZhbHNlIHVubGVzcyB0aGUgZGV2aWNlIGlzDQo+ID4gPj4gcHJvdGVjdGVk
IGJlaGluZyBhbiBTTU1VIHVzaW5nIHRoZSBsZWdhY3kgYmluZGluZy4gU28gSSBkb24ndCB0aGlu
aw0KPiA+ID4+IHRoaXMgaXMgY29ycmVjdCB0byBtb3ZlIHRoaXMgY2hlY2sgYWhlYWQuIEluIGZh
Y3QuLg0KPiA+ID4+DQo+ID4gPj4+ICsgICAgICAgIHJldHVybiAwOw0KPiA+ID4+PiArDQo+ID4g
Pj4+ICAgICAgICByZXMgPSBpb21tdV9hZGRfZHRfZGV2aWNlKG5vZGUpOw0KPiA+ID4+DQo+ID4g
Pj4gLi4uIHRoZSBjYWxsIHNob3VsZCBhbHJlYWR5IGJlIGEgTk9QIHdoZW4gdGhlIElPTU1VIGlz
IGRpc2FibGVkIG9yDQo+ID4gPj4gdGhlIGRldmljZSBpcyBub3QgYmVoaW5kIGFuIElPTU1VLiBT
byBjYW4geW91IGV4cGxhaW4gd2hhdCB5b3UgYXJlDQo+ID4gPj4gdHJ5aW5nIHRvIHByZXZlbnQg
aGVyZT8NCj4gPiA+Pg0KPiA+ID4NCj4gPiA+IElmIHRoZSBJT01NVSBpcyBkaXNhYmxlZCwgaW9t
bXVfYWRkX2R0X2RldmljZSB3aWxsIHJldHVybiAxIGFzIGVycm5vLg0KPiA+ID4gU28gd2UgY291
bGQgbm90IG1ha2UgaXQgdG8gdGhlIHhlbl9mb3JjZSBjaGVjay4uLg0KPiA+DQo+ID4gSSBkaXNh
Z3JlZS4gVGhlIGNoZWNrIGlzOg0KPiA+DQo+ID4gaWYgKCByZXMgPCAwICkNCj4gPiAgICByZXR1
cm4gcmVzOw0KPiA+DQo+ID4gR2l2ZW4gdGhhdCByZXMgaXMgMSwgd2Ugd291bGRuJ3QgcmV0dXJu
IGFuZCBtb3ZlIHRvIGNoZWNrIHdoZXRoZXIgdGhlDQo+ID4gYXNzaWdubWVudCBjYW4gYmUgZG9u
ZS4NCj4gPg0KPiA+ID4NCj4gPiA+IFNvIEkgdHJpZWQgdG8gbW92ZSBhbGwgSU9NTVUgYWN0aW9u
IGJlaGluZCB4ZW5fZm9yY2UgY2hlY2suDQo+ID4gPg0KPiA+ID4gTm93LCBkZXZpY2UgYXNzaWdu
bWVudCB3aXRob3V0IElPTU1VIHByb3RlY3Rpb24gaXMgb25seSBhcHBsaWNhYmxlDQo+ID4gPiBv
biBkaXJlY3QtbWFwIGRvbWFpbnMsDQo+ID4NCj4gPiBJdCBpcyBmaW5lIHRvIGFzc2lnbiBhIG5v
bi1ETUEgY2FwYWJsZSBkZXZpY2Ugd2l0aG91dCBkaXJlY3QtbWFwcGluZy4NCj4gPiBTbyB3aHkg
ZG8geW91IHdhbnQgdG8gYWRkIHRoaXMgcmVzdHJpY3Rpb24/DQo+ID4NCj4gDQo+IFdoZW4gY29u
c3RydWN0aW5nIGRpcmVjdC1tYXAtdjIsIGZvdW5kIHRoYXQsIGluDQo+IHhlbi9hcmNoL2FybS9k
b21haW5fYnVpbGQuYw0KPiANCj4gaWYgKCBkdF9maW5kX2NvbXBhdGlibGVfbm9kZShub2RlLCBO
VUxMLCAibXVsdGlib290LGRldmljZS10cmVlIikgKQ0KPiAgICAgZF9jZmcuZmxhZ3MgfD0gWEVO
X0RPTUNUTF9DREZfaW9tbXU7DQo+IA0KPiBBbmQgdGhpcyBmbGFnIFhFTl9ET01DVExfQ0RGX2lv
bW11IGRldGVybWluZXMgd2hldGhlciBpb21tdSBpcw0KPiBlbmFibGVkLg0KPiANCj4gSW4gLi94
ZW4vaW5jbHVkZS94ZW4vc2NoZWQuaA0KPiANCj4gc3RhdGljIGFsd2F5c19pbmxpbmUgYm9vbCBp
c19pb21tdV9lbmFibGVkKGNvbnN0IHN0cnVjdCBkb21haW4gKmQpIHsNCj4gICAgIHJldHVybiBl
dmFsdWF0ZV9ub3NwZWMoZC0+b3B0aW9ucyAmIFhFTl9ET01DVExfQ0RGX2lvbW11KTsgfQ0KPiAN
Cj4gVGhhdCBpcywgZXZlbiBpZiB3ZSBhc3NpZ24gYSBub24tRE1BIGNhcGFibGUgZGV2aWNlLCB3
ZSByZXF1ZXN0IHRoZSBwbGF0Zm9ybQ0KPiB0byBiZSBpb21tdSBlbmFibGVkLg0KPg0KDQpJIGlu
dGVuZCB0byBjaGFuZ2UgaXQgdG8NCg0KICAgICAgICBpZiAoIGR0X2ZpbmRfY29tcGF0aWJsZV9u
b2RlKG5vZGUsIE5VTEwsICJtdWx0aWJvb3QsZGV2aWNlLXRyZWUiKSApDQogICAgICAgIHsNCiAg
ICAgICAgICAgIGlmICggaW9tbXVfZW5hYmxlZCApDQogICAgICAgICAgICAgICAgZF9jZmcuZmxh
Z3MgfD0gWEVOX0RPTUNUTF9DREZfaW9tbXU7DQogICAgICAgICAgICBlbHNlIGlmICggZF9jZmcu
ZmxhZ3MgJiBYRU5fRE9NQ1RMX0NERl9kaXJlY3RtYXAgKQ0KICAgICAgICAgICAgICAgIHdhcm5p
bmdfYWRkKCJQbGVhc2UgYmUgc3VyZSBvZiBoYXZpbmcgdHJ1c3RlZCBndWVzdHMsIHdoZW4gZG9p
bmcgZGV2aWNlIGFzc2lnbm1lbnQgd2l0aG91dCBJT01NVSBwcm90ZWN0aW9uXG4iKTsNCiAgICAg
ICAgfQ0KDQo+ID4gQ2hlZXJzLA0KPiA+DQo+ID4gLS0NCj4gPiBKdWxpZW4gR3JhbGwNCg==


From xen-devel-bounces@lists.xenproject.org Wed Oct 13 07:52:27 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 07:52:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.208009.364027 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maZ3h-0001FJ-42; Wed, 13 Oct 2021 07:52:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 208009.364027; Wed, 13 Oct 2021 07:52:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maZ3h-0001FC-01; Wed, 13 Oct 2021 07:52:17 +0000
Received: by outflank-mailman (input) for mailman id 208009;
 Wed, 13 Oct 2021 07:52:16 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=quvz=PB=suse.com=jgross@srs-us1.protection.inumbo.net>)
 id 1maZ3f-0001Eb-TX
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 07:52:15 +0000
Received: from smtp-out1.suse.de (unknown [195.135.220.28])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 7aa30fdc-2bfa-11ec-8160-12813bfff9fa;
 Wed, 13 Oct 2021 07:52:14 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id E5C88222C1;
 Wed, 13 Oct 2021 07:52:13 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id BD79513E64;
 Wed, 13 Oct 2021 07:52:13 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id 8HwkLS2QZmEjfwAAMHmgww
 (envelope-from <jgross@suse.com>); Wed, 13 Oct 2021 07:52:13 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7aa30fdc-2bfa-11ec-8160-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1634111533; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=po+hf+FNagQm6i1f8al0BNtylY1+PBG7DwkLS/oaAWs=;
	b=mddxD0CD/4UuclYtMsHxMsipqzzcIolby96n8sagPPPa1soKyWpYO0BVx1ufBskC7UUWWc
	4Th5pE9aLhfLjHDvK/lfrBXTpRp6qbLqyy5nRdScdU7wBrJCDej3KGBDE5M7YSxrbLkkAd
	ZjJQdUQyjRC3VV/+Avt8b7V+T8FugGY=
From: Juergen Gross <jgross@suse.com>
To: linux-usb@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	linux-kernel@vger.kernel.org
Cc: Juergen Gross <jgross@suse.com>,
	Konrad Rzeszutek Wilk <Konrad.wilk@oracle.com>
Subject: [PATCH v6 3/3] xen: add Xen pvUSB maintainer
Date: Wed, 13 Oct 2021 09:52:07 +0200
Message-Id: <20211013075207.13910-4-jgross@suse.com>
X-Mailer: git-send-email 2.26.2
In-Reply-To: <20211013075207.13910-1-jgross@suse.com>
References: <20211013075207.13910-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Add myself as maintainer for the Xen pvUSB stuff.

Signed-off-by: Juergen Gross <jgross@suse.com>
Acked-by: Konrad Rzeszutek Wilk <Konrad.wilk@oracle.com>
---
 MAINTAINERS | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index e0bca0de0df7..7c211195be7e 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -20535,6 +20535,14 @@ F:	drivers/scsi/xen-scsifront.c
 F:	drivers/xen/xen-scsiback.c
 F:	include/xen/interface/io/vscsiif.h
 
+XEN PVUSB DRIVER
+M:	Juergen Gross <jgross@suse.com>
+L:	xen-devel@lists.xenproject.org (moderated for non-subscribers)
+L:	linux-usb@vger.kernel.org
+S:	Supported
+F:	divers/usb/host/xen*
+F:	include/xen/interface/io/usbif.h
+
 XEN SOUND FRONTEND DRIVER
 M:	Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
 L:	xen-devel@lists.xenproject.org (moderated for non-subscribers)
-- 
2.26.2



From xen-devel-bounces@lists.xenproject.org Wed Oct 13 07:52:29 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 07:52:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.208010.364038 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maZ3j-0001Wz-BP; Wed, 13 Oct 2021 07:52:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 208010.364038; Wed, 13 Oct 2021 07:52:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maZ3j-0001Ws-7W; Wed, 13 Oct 2021 07:52:19 +0000
Received: by outflank-mailman (input) for mailman id 208010;
 Wed, 13 Oct 2021 07:52:17 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=quvz=PB=suse.com=jgross@srs-us1.protection.inumbo.net>)
 id 1maZ3h-0000xn-CL
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 07:52:17 +0000
Received: from smtp-out2.suse.de (unknown [195.135.220.29])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id e0399a54-7fa3-40ef-a650-0a6cd197c151;
 Wed, 13 Oct 2021 07:52:14 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 3CDD520104;
 Wed, 13 Oct 2021 07:52:13 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 0691713CBE;
 Wed, 13 Oct 2021 07:52:13 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id i8ZZAC2QZmEjfwAAMHmgww
 (envelope-from <jgross@suse.com>); Wed, 13 Oct 2021 07:52:13 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e0399a54-7fa3-40ef-a650-0a6cd197c151
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1634111533; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:  content-transfer-encoding:content-transfer-encoding;
	bh=PEhOZW6YBfE+O+k9kXIl887b/VhLwCZgp9E+NPxBIjg=;
	b=Kz4auS3jQ69eu7+hX8Q/K7L8FyQosbPqEgw0U2WNyiaFIzlZEFQsyFMuBd+gt/s94h6nez
	HegnFQBOVijkZ8mwijk9OI8p6yonPM2Z1dh6prNt2WCnIZSxOJFCTMH+624YRQ+3xYm8hl
	z6BF4zJ8wCVKl+pZJ6IQ1PsLr6tC2zE=
From: Juergen Gross <jgross@suse.com>
To: linux-usb@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	linux-kernel@vger.kernel.org
Cc: Juergen Gross <jgross@suse.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: [PATCH v6 0/3] xen, usb: support pvUSB frontend driver
Date: Wed, 13 Oct 2021 09:52:04 +0200
Message-Id: <20211013075207.13910-1-jgross@suse.com>
X-Mailer: git-send-email 2.26.2
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

This series adds XEN guest pvUSB support. With pvUSB it is possible to
use physical USB devices from a XEN domain.

Since V4 a lot of time (several years) has passed. This is a revived
attempt to get the frontend into the kernel.

The support consists of a frontend in form of a virtual hcd driver in
the unprivileged domU passing I/O-requests to the backend in a driver
domain (usually Dom0). The backend is not part of this patch series,
as it is supported via qemu.

The code is taken (and adapted) from the original pvUSB implementation
done for Linux 2.6 in 2008 by Fujitsu.

Normal operation of USB devices by adding and removing them dynamically
to/from a domain has been tested using various USB devices (USB 1.1,
2.0 and 3.0) using the qemu based backend.

Changes in V6:
- add SPDX line to driver

Changes in V5:
- added interface documentation to patch 1
- frontend no longer trusts backend to return only sane values

Changes in V4:
- remove sysfs file from frontend, as it violated the "one value per file"
  rule and didn't serve any real purpose.

Changes in V3:
- move frontend to drivers/usb/host and rename it to xen-hcd.
- changed name prefixes in patch 1 to "xenusb" as requested by Greg
- use __u<n> types rather than uint<n>_t as requested by Greg

Changes in V2:
- removed backend, as it can be implemented in user land
- added some access macros and definitions to the pvUSB interface
  description to make it independant from linux kernel USB internals
- adapted frontend to newer kernel version and use new pvUSB
  interface macros
- set port status in one chunk as suggested by Oliver Neukum

Juergen Gross (3):
  usb: Add Xen pvUSB protocol description
  usb: Introduce Xen pvUSB frontend (xen hcd)
  xen: add Xen pvUSB maintainer

 MAINTAINERS                      |    8 +
 drivers/usb/host/Kconfig         |   11 +
 drivers/usb/host/Makefile        |    1 +
 drivers/usb/host/xen-hcd.c       | 1606 ++++++++++++++++++++++++++++++
 include/xen/interface/io/usbif.h |  421 ++++++++
 5 files changed, 2047 insertions(+)
 create mode 100644 drivers/usb/host/xen-hcd.c
 create mode 100644 include/xen/interface/io/usbif.h

-- 
2.26.2



From xen-devel-bounces@lists.xenproject.org Wed Oct 13 07:52:31 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 07:52:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.208011.364049 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maZ3l-0001qk-Lb; Wed, 13 Oct 2021 07:52:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 208011.364049; Wed, 13 Oct 2021 07:52:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maZ3l-0001qX-Hc; Wed, 13 Oct 2021 07:52:21 +0000
Received: by outflank-mailman (input) for mailman id 208011;
 Wed, 13 Oct 2021 07:52:20 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=quvz=PB=suse.com=jgross@srs-us1.protection.inumbo.net>)
 id 1maZ3k-0001Eb-QK
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 07:52:20 +0000
Received: from smtp-out1.suse.de (unknown [195.135.220.28])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 7a6ba66e-2bfa-11ec-8160-12813bfff9fa;
 Wed, 13 Oct 2021 07:52:14 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 7D72022243;
 Wed, 13 Oct 2021 07:52:13 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 47B8613CBE;
 Wed, 13 Oct 2021 07:52:13 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id yOhSEC2QZmEjfwAAMHmgww
 (envelope-from <jgross@suse.com>); Wed, 13 Oct 2021 07:52:13 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7a6ba66e-2bfa-11ec-8160-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1634111533; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=zse2pNf3Nqq9ce0C5luvO4nVc/A6VAHCPFmY1kxIMr0=;
	b=tMfFTMvJgUugjH9Ns8NG0AXFOvMcxTfx0U50De6R5WNza2GxCp+a5sLuG2KGjaAy1m1GGk
	cqCr5uxOi3Gf6FLFTXrUPEnoNwB89CREhIz9uSm/v0s3hMZ9etlpTFvXUf0/AR+aeMLkpT
	2oiR5LvXs8BEJT2mnALuE1NfRKWmzPM=
From: Juergen Gross <jgross@suse.com>
To: linux-usb@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	linux-kernel@vger.kernel.org
Cc: Juergen Gross <jgross@suse.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>
Subject: [PATCH v6 1/3] usb: Add Xen pvUSB protocol description
Date: Wed, 13 Oct 2021 09:52:05 +0200
Message-Id: <20211013075207.13910-2-jgross@suse.com>
X-Mailer: git-send-email 2.26.2
In-Reply-To: <20211013075207.13910-1-jgross@suse.com>
References: <20211013075207.13910-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Add the definition of pvUSB protocol used between the pvUSB frontend in
a Xen domU and the pvUSB backend in a Xen driver domain (usually Dom0).

This header was originally provided by Fujitsu for Xen based on Linux
2.6.18.

Changes are:
- adapt to Linux kernel style guide
- use Xen namespace
- add lots of comments
- don't use kernel internal defines

Signed-off-by: Juergen Gross <jgross@suse.com>
Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
---
 include/xen/interface/io/usbif.h | 421 +++++++++++++++++++++++++++++++
 1 file changed, 421 insertions(+)
 create mode 100644 include/xen/interface/io/usbif.h

diff --git a/include/xen/interface/io/usbif.h b/include/xen/interface/io/usbif.h
new file mode 100644
index 000000000000..9494b1c9be99
--- /dev/null
+++ b/include/xen/interface/io/usbif.h
@@ -0,0 +1,421 @@
+/*
+ * usbif.h
+ *
+ * USB I/O interface for Xen guest OSes.
+ *
+ * Copyright (C) 2009, FUJITSU LABORATORIES LTD.
+ * Author: Noboru Iwamatsu <n_iwamatsu@jp.fujitsu.com>
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a copy
+ * of this software and associated documentation files (the "Software"), to
+ * deal in the Software without restriction, including without limitation the
+ * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or
+ * sell copies of the Software, and to permit persons to whom the Software is
+ * furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice shall be included in
+ * all copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+ * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
+ * DEALINGS IN THE SOFTWARE.
+ */
+
+#ifndef __XEN_PUBLIC_IO_USBIF_H__
+#define __XEN_PUBLIC_IO_USBIF_H__
+
+#include "ring.h"
+#include "../grant_table.h"
+
+/*
+ * Detailed Interface Description
+ * ==============================
+ * The pvUSB interface is using a split driver design: a frontend driver in
+ * the guest and a backend driver in a driver domain (normally dom0) having
+ * access to the physical USB device(s) being passed to the guest.
+ *
+ * The frontend and backend drivers use XenStore to initiate the connection
+ * between them, the I/O activity is handled via two shared ring pages and an
+ * event channel. As the interface between frontend and backend is at the USB
+ * host connector level, multiple (up to 31) physical USB devices can be
+ * handled by a single connection.
+ *
+ * The Xen pvUSB device name is "qusb", so the frontend's XenStore entries are
+ * to be found under "device/qusb", while the backend's XenStore entries are
+ * under "backend/<guest-dom-id>/qusb".
+ *
+ * When a new pvUSB connection is established, the frontend needs to setup the
+ * two shared ring pages for communication and the event channel. The ring
+ * pages need to be made available to the backend via the grant table
+ * interface.
+ *
+ * One of the shared ring pages is used by the backend to inform the frontend
+ * about USB device plug events (device to be added or removed). This is the
+ * "conn-ring".
+ *
+ * The other ring page is used for USB I/O communication (requests and
+ * responses). This is the "urb-ring".
+ *
+ * Feature and Parameter Negotiation
+ * =================================
+ * The two halves of a Xen pvUSB driver utilize nodes within the XenStore to
+ * communicate capabilities and to negotiate operating parameters. This
+ * section enumerates these nodes which reside in the respective front and
+ * backend portions of the XenStore, following the XenBus convention.
+ *
+ * Any specified default value is in effect if the corresponding XenBus node
+ * is not present in the XenStore.
+ *
+ * XenStore nodes in sections marked "PRIVATE" are solely for use by the
+ * driver side whose XenBus tree contains them.
+ *
+ *****************************************************************************
+ *                            Backend XenBus Nodes
+ *****************************************************************************
+ *
+ *------------------ Backend Device Identification (PRIVATE) ------------------
+ *
+ * num-ports
+ *      Values:         unsigned [1...31]
+ *
+ *      Number of ports for this (virtual) USB host connector.
+ *
+ * usb-ver
+ *      Values:         unsigned [1...2]
+ *
+ *      USB version of this host connector: 1 = USB 1.1, 2 = USB 2.0.
+ *
+ * port/[1...31]
+ *      Values:         string
+ *
+ *      Physical USB device connected to the given port, e.g. "3-1.5".
+ *
+ *****************************************************************************
+ *                            Frontend XenBus Nodes
+ *****************************************************************************
+ *
+ *----------------------- Request Transport Parameters -----------------------
+ *
+ * event-channel
+ *      Values:         unsigned
+ *
+ *      The identifier of the Xen event channel used to signal activity
+ *      in the ring buffer.
+ *
+ * urb-ring-ref
+ *      Values:         unsigned
+ *
+ *      The Xen grant reference granting permission for the backend to map
+ *      the sole page in a single page sized ring buffer. This is the ring
+ *      buffer for urb requests.
+ *
+ * conn-ring-ref
+ *      Values:         unsigned
+ *
+ *      The Xen grant reference granting permission for the backend to map
+ *      the sole page in a single page sized ring buffer. This is the ring
+ *      buffer for connection/disconnection requests.
+ *
+ * protocol
+ *      Values:         string (XEN_IO_PROTO_ABI_*)
+ *      Default Value:  XEN_IO_PROTO_ABI_NATIVE
+ *
+ *      The machine ABI rules governing the format of all ring request and
+ *      response structures.
+ *
+ * Protocol Description
+ * ====================
+ *
+ *-------------------------- USB device plug events --------------------------
+ *
+ * USB device plug events are send via the "conn-ring" shared page. As only
+ * events are being sent, the respective requests from the frontend to the
+ * backend are just dummy ones.
+ * The events sent to the frontend have the following layout:
+ *         0                1                 2               3        octet
+ * +----------------+----------------+----------------+----------------+
+ * |               id                |    portnum     |     speed      | 4
+ * +----------------+----------------+----------------+----------------+
+ *   id - uint16_t, event id (taken from the actual frontend dummy request)
+ *   portnum - uint8_t, port number (1 ... 31)
+ *   speed - uint8_t, device XENUSB_SPEED_*, XENUSB_SPEED_NONE == unplug
+ *
+ * The dummy request:
+ *         0                1        octet
+ * +----------------+----------------+
+ * |               id                | 2
+ * +----------------+----------------+
+ *   id - uint16_t, guest supplied value (no need for being unique)
+ *
+ *-------------------------- USB I/O request ---------------------------------
+ *
+ * A single USB I/O request on the "urb-ring" has the following layout:
+ *         0                1                 2               3        octet
+ * +----------------+----------------+----------------+----------------+
+ * |               id                |         nr_buffer_segs          | 4
+ * +----------------+----------------+----------------+----------------+
+ * |                               pipe                                | 8
+ * +----------------+----------------+----------------+----------------+
+ * |         transfer_flags          |          buffer_length          | 12
+ * +----------------+----------------+----------------+----------------+
+ * |                       request type specific                       | 16
+ * |                               data                                | 20
+ * +----------------+----------------+----------------+----------------+
+ * |                              seg[0]                               | 24
+ * |                               data                                | 28
+ * +----------------+----------------+----------------+----------------+
+ * |/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/|
+ * +----------------+----------------+----------------+----------------+
+ * |             seg[XENUSB_MAX_SEGMENTS_PER_REQUEST - 1]              | 144
+ * |                               data                                | 148
+ * +----------------+----------------+----------------+----------------+
+ * Bit field bit number 0 is always least significant bit, undefined bits must
+ * be zero.
+ *   id - uint16_t, guest supplied value
+ *   nr_buffer_segs - uint16_t, number of segment entries in seg[] array
+ *   pipe - uint32_t, bit field with multiple information:
+ *     bits 0-4: port request to send to
+ *     bit 5: unlink request with specified id (cancel I/O) if set (see below)
+ *     bit 7: direction (1 = read from device)
+ *     bits 8-14: device number on port
+ *     bits 15-18: endpoint of device
+ *     bits 30-31: request type: 00 = isochronous, 01 = interrupt,
+ *                               10 = control, 11 = bulk
+ *   transfer_flags - uint16_t, bit field with processing flags:
+ *     bit 0: less data than specified allowed
+ *   buffer_length - uint16_t, total length of data
+ *   request type specific data - 8 bytes, see below
+ *   seg[] - array with 8 byte elements, see below
+ *
+ * Request type specific data for isochronous request:
+ *         0                1                 2               3        octet
+ * +----------------+----------------+----------------+----------------+
+ * |            interval             |           start_frame           | 4
+ * +----------------+----------------+----------------+----------------+
+ * |       number_of_packets         |       nr_frame_desc_segs        | 8
+ * +----------------+----------------+----------------+----------------+
+ *   interval - uint16_t, time interval in msecs between frames
+ *   start_frame - uint16_t, start frame number
+ *   number_of_packets - uint16_t, number of packets to transfer
+ *   nr_frame_desc_segs - uint16_t number of seg[] frame descriptors elements
+ *
+ * Request type specific data for interrupt request:
+ *         0                1                 2               3        octet
+ * +----------------+----------------+----------------+----------------+
+ * |            interval             |                0                | 4
+ * +----------------+----------------+----------------+----------------+
+ * |                                 0                                 | 8
+ * +----------------+----------------+----------------+----------------+
+ *   interval - uint16_t, time in msecs until interruption
+ *
+ * Request type specific data for control request:
+ *         0                1                 2               3        octet
+ * +----------------+----------------+----------------+----------------+
+ * |                      data of setup packet                         | 4
+ * |                                                                   | 8
+ * +----------------+----------------+----------------+----------------+
+ *
+ * Request type specific data for bulk request:
+ *         0                1                 2               3        octet
+ * +----------------+----------------+----------------+----------------+
+ * |                                 0                                 | 4
+ * |                                 0                                 | 8
+ * +----------------+----------------+----------------+----------------+
+ *
+ * Request type specific data for unlink request:
+ *         0                1                 2               3        octet
+ * +----------------+----------------+----------------+----------------+
+ * |           unlink_id             |                0                | 4
+ * +----------------+----------------+----------------+----------------+
+ * |                                 0                                 | 8
+ * +----------------+----------------+----------------+----------------+
+ *   unlink_id - uint16_t, request id of request to terminate
+ *
+ * seg[] array element layout:
+ *         0                1                 2               3        octet
+ * +----------------+----------------+----------------+----------------+
+ * |                               gref                                | 4
+ * +----------------+----------------+----------------+----------------+
+ * |             offset              |             length              | 8
+ * +----------------+----------------+----------------+----------------+
+ *   gref - uint32_t, grant reference of buffer page
+ *   offset - uint16_t, offset of buffer start in page
+ *   length - uint16_t, length of buffer in page
+ *
+ *-------------------------- USB I/O response --------------------------------
+ *
+ *         0                1                 2               3        octet
+ * +----------------+----------------+----------------+----------------+
+ * |               id                |          start_frame            | 4
+ * +----------------+----------------+----------------+----------------+
+ * |                              status                               | 8
+ * +----------------+----------------+----------------+----------------+
+ * |                          actual_length                            | 12
+ * +----------------+----------------+----------------+----------------+
+ * |                           error_count                             | 16
+ * +----------------+----------------+----------------+----------------+
+ *   id - uint16_t, id of the request this response belongs to
+ *   start_frame - uint16_t, start_frame this response (iso requests only)
+ *   status - int32_t, XENUSB_STATUS_* (non-iso requests)
+ *   actual_length - uint32_t, actual size of data transferred
+ *   error_count - uint32_t, number of errors (iso requests)
+ */
+
+enum xenusb_spec_version {
+	XENUSB_VER_UNKNOWN = 0,
+	XENUSB_VER_USB11,
+	XENUSB_VER_USB20,
+	XENUSB_VER_USB30,	/* not supported yet */
+};
+
+/*
+ *  USB pipe in xenusb_request
+ *
+ *  - port number:      bits 0-4
+ *                              (USB_MAXCHILDREN is 31)
+ *
+ *  - operation flag:   bit 5
+ *                              (0 = submit urb,
+ *                               1 = unlink urb)
+ *
+ *  - direction:        bit 7
+ *                              (0 = Host-to-Device [Out]
+ *                               1 = Device-to-Host [In])
+ *
+ *  - device address:   bits 8-14
+ *
+ *  - endpoint:         bits 15-18
+ *
+ *  - pipe type:        bits 30-31
+ *                              (00 = isochronous, 01 = interrupt,
+ *                               10 = control, 11 = bulk)
+ */
+
+#define XENUSB_PIPE_PORT_MASK	0x0000001f
+#define XENUSB_PIPE_UNLINK	0x00000020
+#define XENUSB_PIPE_DIR		0x00000080
+#define XENUSB_PIPE_DEV_MASK	0x0000007f
+#define XENUSB_PIPE_DEV_SHIFT	8
+#define XENUSB_PIPE_EP_MASK	0x0000000f
+#define XENUSB_PIPE_EP_SHIFT	15
+#define XENUSB_PIPE_TYPE_MASK	0x00000003
+#define XENUSB_PIPE_TYPE_SHIFT	30
+#define XENUSB_PIPE_TYPE_ISOC	0
+#define XENUSB_PIPE_TYPE_INT	1
+#define XENUSB_PIPE_TYPE_CTRL	2
+#define XENUSB_PIPE_TYPE_BULK	3
+
+#define xenusb_pipeportnum(pipe)		((pipe) & XENUSB_PIPE_PORT_MASK)
+#define xenusb_setportnum_pipe(pipe, portnum)	((pipe) | (portnum))
+
+#define xenusb_pipeunlink(pipe)			((pipe) & XENUSB_PIPE_UNLINK)
+#define xenusb_pipesubmit(pipe)			(!xenusb_pipeunlink(pipe))
+#define xenusb_setunlink_pipe(pipe)		((pipe) | XENUSB_PIPE_UNLINK)
+
+#define xenusb_pipein(pipe)			((pipe) & XENUSB_PIPE_DIR)
+#define xenusb_pipeout(pipe)			(!xenusb_pipein(pipe))
+
+#define xenusb_pipedevice(pipe)			\
+	(((pipe) >> XENUSB_PIPE_DEV_SHIFT) & XENUSB_PIPE_DEV_MASK)
+
+#define xenusb_pipeendpoint(pipe)		\
+	(((pipe) >> XENUSB_PIPE_EP_SHIFT) & XENUSB_PIPE_EP_MASK)
+
+#define xenusb_pipetype(pipe)			\
+	(((pipe) >> XENUSB_PIPE_TYPE_SHIFT) & XENUSB_PIPE_TYPE_MASK)
+#define xenusb_pipeisoc(pipe)	(xenusb_pipetype(pipe) == XENUSB_PIPE_TYPE_ISOC)
+#define xenusb_pipeint(pipe)	(xenusb_pipetype(pipe) == XENUSB_PIPE_TYPE_INT)
+#define xenusb_pipectrl(pipe)	(xenusb_pipetype(pipe) == XENUSB_PIPE_TYPE_CTRL)
+#define xenusb_pipebulk(pipe)	(xenusb_pipetype(pipe) == XENUSB_PIPE_TYPE_BULK)
+
+#define XENUSB_MAX_SEGMENTS_PER_REQUEST (16)
+#define XENUSB_MAX_PORTNR		31
+#define XENUSB_RING_SIZE		4096
+
+/*
+ * RING for transferring urbs.
+ */
+struct xenusb_request_segment {
+	grant_ref_t gref;
+	uint16_t offset;
+	uint16_t length;
+};
+
+struct xenusb_urb_request {
+	uint16_t id;			/* request id */
+	uint16_t nr_buffer_segs;	/* number of urb->transfer_buffer segments */
+
+	/* basic urb parameter */
+	uint32_t pipe;
+	uint16_t transfer_flags;
+#define XENUSB_SHORT_NOT_OK	0x0001
+	uint16_t buffer_length;
+	union {
+		uint8_t ctrl[8];	/* setup_packet (Ctrl) */
+
+		struct {
+			uint16_t interval;	/* maximum (1024*8) in usb core */
+			uint16_t start_frame;	/* start frame */
+			uint16_t number_of_packets;	/* number of ISO packet */
+			uint16_t nr_frame_desc_segs;	/* number of iso_frame_desc segments */
+		} isoc;
+
+		struct {
+			uint16_t interval;	/* maximum (1024*8) in usb core */
+			uint16_t pad[3];
+		} intr;
+
+		struct {
+			uint16_t unlink_id;	/* unlink request id */
+			uint16_t pad[3];
+		} unlink;
+
+	} u;
+
+	/* urb data segments */
+	struct xenusb_request_segment seg[XENUSB_MAX_SEGMENTS_PER_REQUEST];
+};
+
+struct xenusb_urb_response {
+	uint16_t id;		/* request id */
+	uint16_t start_frame;	/* start frame (ISO) */
+	int32_t status;		/* status (non-ISO) */
+#define XENUSB_STATUS_OK	0
+#define XENUSB_STATUS_NODEV	(-19)
+#define XENUSB_STATUS_INVAL	(-22)
+#define XENUSB_STATUS_STALL	(-32)
+#define XENUSB_STATUS_IOERROR	(-71)
+#define XENUSB_STATUS_BABBLE	(-75)
+#define XENUSB_STATUS_SHUTDOWN	(-108)
+	int32_t actual_length;	/* actual transfer length */
+	int32_t error_count;	/* number of ISO errors */
+};
+
+DEFINE_RING_TYPES(xenusb_urb, struct xenusb_urb_request, struct xenusb_urb_response);
+#define XENUSB_URB_RING_SIZE __CONST_RING_SIZE(xenusb_urb, XENUSB_RING_SIZE)
+
+/*
+ * RING for notifying connect/disconnect events to frontend
+ */
+struct xenusb_conn_request {
+	uint16_t id;
+};
+
+struct xenusb_conn_response {
+	uint16_t id;		/* request id */
+	uint8_t portnum;	/* port number */
+	uint8_t speed;		/* usb_device_speed */
+#define XENUSB_SPEED_NONE	0
+#define XENUSB_SPEED_LOW	1
+#define XENUSB_SPEED_FULL	2
+#define XENUSB_SPEED_HIGH	3
+};
+
+DEFINE_RING_TYPES(xenusb_conn, struct xenusb_conn_request, struct xenusb_conn_response);
+#define XENUSB_CONN_RING_SIZE __CONST_RING_SIZE(xenusb_conn, XENUSB_RING_SIZE)
+
+#endif /* __XEN_PUBLIC_IO_USBIF_H__ */
-- 
2.26.2



From xen-devel-bounces@lists.xenproject.org Wed Oct 13 07:52:37 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 07:52:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.208012.364059 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maZ3r-0002Hh-4y; Wed, 13 Oct 2021 07:52:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 208012.364059; Wed, 13 Oct 2021 07:52:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maZ3r-0002HU-0W; Wed, 13 Oct 2021 07:52:27 +0000
Received: by outflank-mailman (input) for mailman id 208012;
 Wed, 13 Oct 2021 07:52:25 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=quvz=PB=suse.com=jgross@srs-us1.protection.inumbo.net>)
 id 1maZ3p-0001Eb-QY
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 07:52:25 +0000
Received: from smtp-out2.suse.de (unknown [195.135.220.29])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 7a6ba66f-2bfa-11ec-8160-12813bfff9fa;
 Wed, 13 Oct 2021 07:52:14 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id B8ED920106;
 Wed, 13 Oct 2021 07:52:13 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 8558113CBE;
 Wed, 13 Oct 2021 07:52:13 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id WMt2Hy2QZmEjfwAAMHmgww
 (envelope-from <jgross@suse.com>); Wed, 13 Oct 2021 07:52:13 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7a6ba66f-2bfa-11ec-8160-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1634111533; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=d/eSTT2AxRYa7ZAP4NgwwqIwkZd90o8OYMcT+I3l7bw=;
	b=rJ7kPyyGgCYZ9KXHYvlj5ONLKDmsP9K3uXB2UJtC4brXFONql0euM4uulEPpa9nuQ1jRX9
	rq6tXOVckqDIfgm0o313fFz9RyeYjeRtPsGz+EQl9JFOPR5tdFYhrvXx9E7cnKrjw18eyH
	AARjqpnfuGzsYChfRZNjMiE9S9D+NlU=
From: Juergen Gross <jgross@suse.com>
To: linux-usb@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	linux-kernel@vger.kernel.org
Cc: Juergen Gross <jgross@suse.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: [PATCH v6 2/3] usb: Introduce Xen pvUSB frontend (xen hcd)
Date: Wed, 13 Oct 2021 09:52:06 +0200
Message-Id: <20211013075207.13910-3-jgross@suse.com>
X-Mailer: git-send-email 2.26.2
In-Reply-To: <20211013075207.13910-1-jgross@suse.com>
References: <20211013075207.13910-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Introduces the Xen pvUSB frontend. With pvUSB it is possible for a Xen
domU to communicate with a USB device assigned to that domU. The
communication is all done via the pvUSB backend in a driver domain
(usually Dom0) which is owner of the physical device.

The pvUSB frontend is a USB hcd for a virtual USB host connector.

The code is taken from the pvUSB implementation in Xen done by Fujitsu
based on Linux kernel 2.6.18.

Changes from the original version are:
- port to upstream kernel
- put all code in just one source file
- move module to appropriate location in kernel tree
- adapt to Linux style guide
- minor code modifications to increase readability

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 drivers/usb/host/Kconfig   |   11 +
 drivers/usb/host/Makefile  |    1 +
 drivers/usb/host/xen-hcd.c | 1606 ++++++++++++++++++++++++++++++++++++
 3 files changed, 1618 insertions(+)
 create mode 100644 drivers/usb/host/xen-hcd.c

diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig
index c4736d1d020c..c0a398aeb7c6 100644
--- a/drivers/usb/host/Kconfig
+++ b/drivers/usb/host/Kconfig
@@ -770,3 +770,14 @@ config USB_HCD_TEST_MODE
 	  This option is of interest only to developers who need to validate
 	  their USB hardware designs.  It is not needed for normal use.  If
 	  unsure, say N.
+
+config USB_XEN_HCD
+	tristate "Xen usb virtual host driver"
+	depends on XEN
+	select XEN_XENBUS_FRONTEND
+	help
+	  The Xen usb virtual host driver serves as a frontend driver enabling
+	  a Xen guest system to access USB Devices passed through to the guest
+	  by the Xen host (usually Dom0).
+	  Only needed if the kernel is running in a Xen guest and generic
+	  access to a USB device is needed.
diff --git a/drivers/usb/host/Makefile b/drivers/usb/host/Makefile
index 171de4df50bd..2948983618fb 100644
--- a/drivers/usb/host/Makefile
+++ b/drivers/usb/host/Makefile
@@ -85,3 +85,4 @@ obj-$(CONFIG_USB_HCD_BCMA)	+= bcma-hcd.o
 obj-$(CONFIG_USB_HCD_SSB)	+= ssb-hcd.o
 obj-$(CONFIG_USB_FOTG210_HCD)	+= fotg210-hcd.o
 obj-$(CONFIG_USB_MAX3421_HCD)	+= max3421-hcd.o
+obj-$(CONFIG_USB_XEN_HCD)	+= xen-hcd.o
diff --git a/drivers/usb/host/xen-hcd.c b/drivers/usb/host/xen-hcd.c
new file mode 100644
index 000000000000..7801dde6f5ee
--- /dev/null
+++ b/drivers/usb/host/xen-hcd.c
@@ -0,0 +1,1606 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
+/*
+ * xen-hcd.c
+ *
+ * Xen USB Virtual Host Controller driver
+ *
+ * Copyright (C) 2009, FUJITSU LABORATORIES LTD.
+ * Author: Noboru Iwamatsu <n_iwamatsu@jp.fujitsu.com>
+ */
+
+#include <linux/module.h>
+#include <linux/usb.h>
+#include <linux/list.h>
+#include <linux/usb/hcd.h>
+#include <linux/io.h>
+
+#include <xen/xen.h>
+#include <xen/xenbus.h>
+#include <xen/grant_table.h>
+#include <xen/events.h>
+#include <xen/page.h>
+
+#include <xen/interface/io/usbif.h>
+
+/* Private per-URB data */
+struct urb_priv {
+	struct list_head list;
+	struct urb *urb;
+	int req_id;		/* RING_REQUEST id for submitting */
+	int unlink_req_id;	/* RING_REQUEST id for unlinking */
+	int status;
+	bool unlinked;		/* dequeued marker */
+};
+
+/* virtual roothub port status */
+struct rhport_status {
+	__u32 status;
+	bool resuming;		/* in resuming */
+	bool c_connection;	/* connection changed */
+	unsigned long timeout;
+};
+
+/* status of attached device */
+struct vdevice_status {
+	int devnum;
+	enum usb_device_state status;
+	enum usb_device_speed speed;
+};
+
+/* RING request shadow */
+struct usb_shadow {
+	struct xenusb_urb_request req;
+	struct urb *urb;
+};
+
+struct xenhcd_info {
+	/* Virtual Host Controller has 4 urb queues */
+	struct list_head pending_submit_list;
+	struct list_head pending_unlink_list;
+	struct list_head in_progress_list;
+	struct list_head giveback_waiting_list;
+
+	spinlock_t lock;
+
+	/* timer that kick pending and giveback waiting urbs */
+	struct timer_list watchdog;
+	unsigned long actions;
+
+	/* virtual root hub */
+	int rh_numports;
+	struct rhport_status ports[XENUSB_MAX_PORTNR];
+	struct vdevice_status devices[XENUSB_MAX_PORTNR];
+
+	/* Xen related staff */
+	struct xenbus_device *xbdev;
+	int urb_ring_ref;
+	int conn_ring_ref;
+	struct xenusb_urb_front_ring urb_ring;
+	struct xenusb_conn_front_ring conn_ring;
+
+	unsigned int evtchn;
+	unsigned int irq;
+	struct usb_shadow shadow[XENUSB_URB_RING_SIZE];
+	unsigned int shadow_free;
+
+	bool error;
+};
+
+#define GRANT_INVALID_REF 0
+
+#define XENHCD_RING_JIFFIES (HZ/200)
+#define XENHCD_SCAN_JIFFIES 1
+
+enum xenhcd_timer_action {
+	TIMER_RING_WATCHDOG,
+	TIMER_SCAN_PENDING_URBS,
+};
+
+static struct kmem_cache *xenhcd_urbp_cachep;
+
+static inline struct xenhcd_info *xenhcd_hcd_to_info(struct usb_hcd *hcd)
+{
+	return (struct xenhcd_info *)hcd->hcd_priv;
+}
+
+static inline struct usb_hcd *xenhcd_info_to_hcd(struct xenhcd_info *info)
+{
+	return container_of((void *)info, struct usb_hcd, hcd_priv);
+}
+
+static void xenhcd_set_error(struct xenhcd_info *info, const char *msg)
+{
+	info->error = true;
+
+	pr_alert("xen-hcd: protocol error: %s!\n", msg);
+}
+
+static inline void xenhcd_timer_action_done(struct xenhcd_info *info,
+					    enum xenhcd_timer_action action)
+{
+	clear_bit(action, &info->actions);
+}
+
+static void xenhcd_timer_action(struct xenhcd_info *info,
+				enum xenhcd_timer_action action)
+{
+	if (timer_pending(&info->watchdog) &&
+	    test_bit(TIMER_SCAN_PENDING_URBS, &info->actions))
+		return;
+
+	if (!test_and_set_bit(action, &info->actions)) {
+		unsigned long t;
+
+		switch (action) {
+		case TIMER_RING_WATCHDOG:
+			t = XENHCD_RING_JIFFIES;
+			break;
+		default:
+			t = XENHCD_SCAN_JIFFIES;
+			break;
+		}
+		mod_timer(&info->watchdog, t + jiffies);
+	}
+}
+
+/*
+ * set virtual port connection status
+ */
+static void xenhcd_set_connect_state(struct xenhcd_info *info, int portnum)
+{
+	int port;
+
+	port = portnum - 1;
+	if (info->ports[port].status & USB_PORT_STAT_POWER) {
+		switch (info->devices[port].speed) {
+		case XENUSB_SPEED_NONE:
+			info->ports[port].status &=
+				~(USB_PORT_STAT_CONNECTION |
+				  USB_PORT_STAT_ENABLE |
+				  USB_PORT_STAT_LOW_SPEED |
+				  USB_PORT_STAT_HIGH_SPEED |
+				  USB_PORT_STAT_SUSPEND);
+			break;
+		case XENUSB_SPEED_LOW:
+			info->ports[port].status |= USB_PORT_STAT_CONNECTION;
+			info->ports[port].status |= USB_PORT_STAT_LOW_SPEED;
+			break;
+		case XENUSB_SPEED_FULL:
+			info->ports[port].status |= USB_PORT_STAT_CONNECTION;
+			break;
+		case XENUSB_SPEED_HIGH:
+			info->ports[port].status |= USB_PORT_STAT_CONNECTION;
+			info->ports[port].status |= USB_PORT_STAT_HIGH_SPEED;
+			break;
+		default: /* error */
+			return;
+		}
+		info->ports[port].status |= (USB_PORT_STAT_C_CONNECTION << 16);
+	}
+}
+
+/*
+ * set virtual device connection status
+ */
+static int xenhcd_rhport_connect(struct xenhcd_info *info, __u8 portnum,
+				 __u8 speed)
+{
+	int port;
+
+	if (portnum < 1 || portnum > info->rh_numports)
+		return -EINVAL; /* invalid port number */
+
+	port = portnum - 1;
+	if (info->devices[port].speed != speed) {
+		switch (speed) {
+		case XENUSB_SPEED_NONE: /* disconnect */
+			info->devices[port].status = USB_STATE_NOTATTACHED;
+			break;
+		case XENUSB_SPEED_LOW:
+		case XENUSB_SPEED_FULL:
+		case XENUSB_SPEED_HIGH:
+			info->devices[port].status = USB_STATE_ATTACHED;
+			break;
+		default: /* error */
+			return -EINVAL;
+		}
+		info->devices[port].speed = speed;
+		info->ports[port].c_connection = true;
+
+		xenhcd_set_connect_state(info, portnum);
+	}
+
+	return 0;
+}
+
+/*
+ * SetPortFeature(PORT_SUSPENDED)
+ */
+static void xenhcd_rhport_suspend(struct xenhcd_info *info, int portnum)
+{
+	int port;
+
+	port = portnum - 1;
+	info->ports[port].status |= USB_PORT_STAT_SUSPEND;
+	info->devices[port].status = USB_STATE_SUSPENDED;
+}
+
+/*
+ * ClearPortFeature(PORT_SUSPENDED)
+ */
+static void xenhcd_rhport_resume(struct xenhcd_info *info, int portnum)
+{
+	int port;
+
+	port = portnum - 1;
+	if (info->ports[port].status & USB_PORT_STAT_SUSPEND) {
+		info->ports[port].resuming = true;
+		info->ports[port].timeout = jiffies + msecs_to_jiffies(20);
+	}
+}
+
+/*
+ * SetPortFeature(PORT_POWER)
+ */
+static void xenhcd_rhport_power_on(struct xenhcd_info *info, int portnum)
+{
+	int port;
+
+	port = portnum - 1;
+	if ((info->ports[port].status & USB_PORT_STAT_POWER) == 0) {
+		info->ports[port].status |= USB_PORT_STAT_POWER;
+		if (info->devices[port].status != USB_STATE_NOTATTACHED)
+			info->devices[port].status = USB_STATE_POWERED;
+		if (info->ports[port].c_connection)
+			xenhcd_set_connect_state(info, portnum);
+	}
+}
+
+/*
+ * ClearPortFeature(PORT_POWER)
+ * SetConfiguration(non-zero)
+ * Power_Source_Off
+ * Over-current
+ */
+static void xenhcd_rhport_power_off(struct xenhcd_info *info, int portnum)
+{
+	int port;
+
+	port = portnum - 1;
+	if (info->ports[port].status & USB_PORT_STAT_POWER) {
+		info->ports[port].status = 0;
+		if (info->devices[port].status != USB_STATE_NOTATTACHED)
+			info->devices[port].status = USB_STATE_ATTACHED;
+	}
+}
+
+/*
+ * ClearPortFeature(PORT_ENABLE)
+ */
+static void xenhcd_rhport_disable(struct xenhcd_info *info, int portnum)
+{
+	int port;
+
+	port = portnum - 1;
+	info->ports[port].status &= ~USB_PORT_STAT_ENABLE;
+	info->ports[port].status &= ~USB_PORT_STAT_SUSPEND;
+	info->ports[port].resuming = false;
+	if (info->devices[port].status != USB_STATE_NOTATTACHED)
+		info->devices[port].status = USB_STATE_POWERED;
+}
+
+/*
+ * SetPortFeature(PORT_RESET)
+ */
+static void xenhcd_rhport_reset(struct xenhcd_info *info, int portnum)
+{
+	int port;
+
+	port = portnum - 1;
+	info->ports[port].status &= ~(USB_PORT_STAT_ENABLE |
+				      USB_PORT_STAT_LOW_SPEED |
+				      USB_PORT_STAT_HIGH_SPEED);
+	info->ports[port].status |= USB_PORT_STAT_RESET;
+
+	if (info->devices[port].status != USB_STATE_NOTATTACHED)
+		info->devices[port].status = USB_STATE_ATTACHED;
+
+	/* 10msec reset signaling */
+	info->ports[port].timeout = jiffies + msecs_to_jiffies(10);
+}
+
+#ifdef CONFIG_PM
+static int xenhcd_bus_suspend(struct usb_hcd *hcd)
+{
+	struct xenhcd_info *info = xenhcd_hcd_to_info(hcd);
+	int ret = 0;
+	int i, ports;
+
+	ports = info->rh_numports;
+
+	spin_lock_irq(&info->lock);
+	if (!test_bit(HCD_FLAG_HW_ACCESSIBLE, &hcd->flags)) {
+		ret = -ESHUTDOWN;
+	} else {
+		/* suspend any active ports*/
+		for (i = 1; i <= ports; i++)
+			xenhcd_rhport_suspend(info, i);
+	}
+	spin_unlock_irq(&info->lock);
+
+	del_timer_sync(&info->watchdog);
+
+	return ret;
+}
+
+static int xenhcd_bus_resume(struct usb_hcd *hcd)
+{
+	struct xenhcd_info *info = xenhcd_hcd_to_info(hcd);
+	int ret = 0;
+	int i, ports;
+
+	ports = info->rh_numports;
+
+	spin_lock_irq(&info->lock);
+	if (!test_bit(HCD_FLAG_HW_ACCESSIBLE, &hcd->flags)) {
+		ret = -ESHUTDOWN;
+	} else {
+		/* resume any suspended ports*/
+		for (i = 1; i <= ports; i++)
+			xenhcd_rhport_resume(info, i);
+	}
+	spin_unlock_irq(&info->lock);
+
+	return ret;
+}
+#endif
+
+static void xenhcd_hub_descriptor(struct xenhcd_info *info,
+				  struct usb_hub_descriptor *desc)
+{
+	__u16 temp;
+	int ports = info->rh_numports;
+
+	desc->bDescriptorType = 0x29;
+	desc->bPwrOn2PwrGood = 10; /* EHCI says 20ms max */
+	desc->bHubContrCurrent = 0;
+	desc->bNbrPorts = ports;
+
+	/* size of DeviceRemovable and PortPwrCtrlMask fields */
+	temp = 1 + (ports / 8);
+	desc->bDescLength = 7 + 2 * temp;
+
+	/* bitmaps for DeviceRemovable and PortPwrCtrlMask */
+	memset(&desc->u.hs.DeviceRemovable[0], 0, temp);
+	memset(&desc->u.hs.DeviceRemovable[temp], 0xff, temp);
+
+	/* per-port over current reporting and no power switching */
+	temp = 0x000a;
+	desc->wHubCharacteristics = cpu_to_le16(temp);
+}
+
+/* port status change mask for hub_status_data */
+#define PORT_C_MASK	((USB_PORT_STAT_C_CONNECTION |		\
+			  USB_PORT_STAT_C_ENABLE |		\
+			  USB_PORT_STAT_C_SUSPEND |		\
+			  USB_PORT_STAT_C_OVERCURRENT |		\
+			  USB_PORT_STAT_C_RESET) << 16)
+
+/*
+ * See USB 2.0 Spec, 11.12.4 Hub and Port Status Change Bitmap.
+ * If port status changed, writes the bitmap to buf and return
+ * that length(number of bytes).
+ * If Nothing changed, return 0.
+ */
+static int xenhcd_hub_status_data(struct usb_hcd *hcd, char *buf)
+{
+	struct xenhcd_info *info = xenhcd_hcd_to_info(hcd);
+	int ports;
+	int i;
+	unsigned long flags;
+	int ret;
+	int changed = 0;
+
+	/* initialize the status to no-changes */
+	ports = info->rh_numports;
+	ret = 1 + (ports / 8);
+	memset(buf, 0, ret);
+
+	spin_lock_irqsave(&info->lock, flags);
+
+	for (i = 0; i < ports; i++) {
+		/* check status for each port */
+		if (info->ports[i].status & PORT_C_MASK) {
+			buf[(i + 1) / 8] |= 1 << (i + 1) % 8;
+			changed = 1;
+		}
+	}
+
+	if ((hcd->state == HC_STATE_SUSPENDED) && (changed == 1))
+		usb_hcd_resume_root_hub(hcd);
+
+	spin_unlock_irqrestore(&info->lock, flags);
+
+	return changed ? ret : 0;
+}
+
+static int xenhcd_hub_control(struct usb_hcd *hcd, __u16 typeReq, __u16 wValue,
+			      __u16 wIndex, char *buf, __u16 wLength)
+{
+	struct xenhcd_info *info = xenhcd_hcd_to_info(hcd);
+	int ports = info->rh_numports;
+	unsigned long flags;
+	int ret = 0;
+	int i;
+	int changed = 0;
+
+	spin_lock_irqsave(&info->lock, flags);
+	switch (typeReq) {
+	case ClearHubFeature:
+		/* ignore this request */
+		break;
+	case ClearPortFeature:
+		if (!wIndex || wIndex > ports)
+			goto error;
+
+		switch (wValue) {
+		case USB_PORT_FEAT_SUSPEND:
+			xenhcd_rhport_resume(info, wIndex);
+			break;
+		case USB_PORT_FEAT_POWER:
+			xenhcd_rhport_power_off(info, wIndex);
+			break;
+		case USB_PORT_FEAT_ENABLE:
+			xenhcd_rhport_disable(info, wIndex);
+			break;
+		case USB_PORT_FEAT_C_CONNECTION:
+			info->ports[wIndex - 1].c_connection = false;
+			fallthrough;
+		default:
+			info->ports[wIndex - 1].status &= ~(1 << wValue);
+			break;
+		}
+		break;
+	case GetHubDescriptor:
+		xenhcd_hub_descriptor(info, (struct usb_hub_descriptor *)buf);
+		break;
+	case GetHubStatus:
+		/* always local power supply good and no over-current exists. */
+		*(__le32 *)buf = cpu_to_le32(0);
+		break;
+	case GetPortStatus:
+		if (!wIndex || wIndex > ports)
+			goto error;
+
+		wIndex--;
+
+		/* resume completion */
+		if (info->ports[wIndex].resuming &&
+		    time_after_eq(jiffies, info->ports[wIndex].timeout)) {
+			info->ports[wIndex].status |=
+				USB_PORT_STAT_C_SUSPEND << 16;
+			info->ports[wIndex].status &= ~USB_PORT_STAT_SUSPEND;
+		}
+
+		/* reset completion */
+		if ((info->ports[wIndex].status & USB_PORT_STAT_RESET) != 0 &&
+		    time_after_eq(jiffies, info->ports[wIndex].timeout)) {
+			info->ports[wIndex].status |=
+				USB_PORT_STAT_C_RESET << 16;
+			info->ports[wIndex].status &= ~USB_PORT_STAT_RESET;
+
+			if (info->devices[wIndex].status !=
+			    USB_STATE_NOTATTACHED) {
+				info->ports[wIndex].status |=
+					USB_PORT_STAT_ENABLE;
+				info->devices[wIndex].status =
+					USB_STATE_DEFAULT;
+			}
+
+			switch (info->devices[wIndex].speed) {
+			case XENUSB_SPEED_LOW:
+				info->ports[wIndex].status |=
+					USB_PORT_STAT_LOW_SPEED;
+				break;
+			case XENUSB_SPEED_HIGH:
+				info->ports[wIndex].status |=
+					USB_PORT_STAT_HIGH_SPEED;
+				break;
+			default:
+				break;
+			}
+		}
+
+		*(__le32 *)buf = cpu_to_le32(info->ports[wIndex].status);
+		break;
+	case SetPortFeature:
+		if (!wIndex || wIndex > ports)
+			goto error;
+
+		switch (wValue) {
+		case USB_PORT_FEAT_POWER:
+			xenhcd_rhport_power_on(info, wIndex);
+			break;
+		case USB_PORT_FEAT_RESET:
+			xenhcd_rhport_reset(info, wIndex);
+			break;
+		case USB_PORT_FEAT_SUSPEND:
+			xenhcd_rhport_suspend(info, wIndex);
+			break;
+		default:
+			if (info->ports[wIndex-1].status & USB_PORT_STAT_POWER)
+				info->ports[wIndex-1].status |= (1 << wValue);
+		}
+		break;
+
+	case SetHubFeature:
+		/* not supported */
+	default:
+error:
+		ret = -EPIPE;
+	}
+	spin_unlock_irqrestore(&info->lock, flags);
+
+	/* check status for each port */
+	for (i = 0; i < ports; i++) {
+		if (info->ports[i].status & PORT_C_MASK)
+			changed = 1;
+	}
+	if (changed)
+		usb_hcd_poll_rh_status(hcd);
+
+	return ret;
+}
+
+static void xenhcd_free_urb_priv(struct urb_priv *urbp)
+{
+	urbp->urb->hcpriv = NULL;
+	kmem_cache_free(xenhcd_urbp_cachep, urbp);
+}
+
+static inline unsigned int xenhcd_get_id_from_freelist(struct xenhcd_info *info)
+{
+	unsigned int free;
+
+	free = info->shadow_free;
+	info->shadow_free = info->shadow[free].req.id;
+	info->shadow[free].req.id = 0x0fff; /* debug */
+	return free;
+}
+
+static inline void xenhcd_add_id_to_freelist(struct xenhcd_info *info,
+					     unsigned int id)
+{
+	info->shadow[id].req.id	= info->shadow_free;
+	info->shadow[id].urb = NULL;
+	info->shadow_free = id;
+}
+
+static inline int xenhcd_count_pages(void *addr, int length)
+{
+	unsigned long vaddr = (unsigned long)addr;
+
+	return PFN_UP(vaddr + length) - PFN_DOWN(vaddr);
+}
+
+static void xenhcd_gnttab_map(struct xenhcd_info *info, void *addr, int length,
+			      grant_ref_t *gref_head,
+			      struct xenusb_request_segment *seg,
+			      int nr_pages, int flags)
+{
+	grant_ref_t ref;
+	unsigned long buffer_mfn;
+	unsigned int offset;
+	unsigned int len = length;
+	unsigned int bytes;
+	int i;
+
+	for (i = 0; i < nr_pages; i++) {
+		buffer_mfn = PFN_DOWN(arbitrary_virt_to_machine(addr).maddr);
+		offset = offset_in_page(addr);
+
+		bytes = PAGE_SIZE - offset;
+		if (bytes > len)
+			bytes = len;
+
+		ref = gnttab_claim_grant_reference(gref_head);
+		gnttab_grant_foreign_access_ref(ref, info->xbdev->otherend_id,
+						buffer_mfn, flags);
+		seg[i].gref = ref;
+		seg[i].offset = (__u16)offset;
+		seg[i].length = (__u16)bytes;
+
+		addr += bytes;
+		len -= bytes;
+	}
+}
+
+static __u32 xenhcd_pipe_urb_to_xenusb(__u32 urb_pipe, __u8 port)
+{
+	static __u32 pipe;
+
+	pipe = usb_pipedevice(urb_pipe) << XENUSB_PIPE_DEV_SHIFT;
+	pipe |= usb_pipeendpoint(urb_pipe) << XENUSB_PIPE_EP_SHIFT;
+	if (usb_pipein(urb_pipe))
+		pipe |= XENUSB_PIPE_DIR;
+	switch (usb_pipetype(urb_pipe)) {
+	case PIPE_ISOCHRONOUS:
+		pipe |= XENUSB_PIPE_TYPE_ISOC << XENUSB_PIPE_TYPE_SHIFT;
+		break;
+	case PIPE_INTERRUPT:
+		pipe |= XENUSB_PIPE_TYPE_INT << XENUSB_PIPE_TYPE_SHIFT;
+		break;
+	case PIPE_CONTROL:
+		pipe |= XENUSB_PIPE_TYPE_CTRL << XENUSB_PIPE_TYPE_SHIFT;
+		break;
+	case PIPE_BULK:
+		pipe |= XENUSB_PIPE_TYPE_BULK << XENUSB_PIPE_TYPE_SHIFT;
+		break;
+	}
+	pipe = xenusb_setportnum_pipe(pipe, port);
+
+	return pipe;
+}
+
+static int xenhcd_map_urb_for_request(struct xenhcd_info *info, struct urb *urb,
+				      struct xenusb_urb_request *req)
+{
+	grant_ref_t gref_head;
+	int nr_buff_pages = 0;
+	int nr_isodesc_pages = 0;
+	int nr_grants = 0;
+
+	if (urb->transfer_buffer_length) {
+		nr_buff_pages = xenhcd_count_pages(urb->transfer_buffer,
+						urb->transfer_buffer_length);
+
+		if (usb_pipeisoc(urb->pipe))
+			nr_isodesc_pages = xenhcd_count_pages(
+				&urb->iso_frame_desc[0],
+				sizeof(struct usb_iso_packet_descriptor) *
+				urb->number_of_packets);
+
+		nr_grants = nr_buff_pages + nr_isodesc_pages;
+		if (nr_grants > XENUSB_MAX_SEGMENTS_PER_REQUEST) {
+			pr_err("xenhcd: error: %d grants\n", nr_grants);
+			return -E2BIG;
+		}
+
+		if (gnttab_alloc_grant_references(nr_grants, &gref_head)) {
+			pr_err("xenhcd: gnttab_alloc_grant_references() error\n");
+			return -ENOMEM;
+		}
+
+		xenhcd_gnttab_map(info, urb->transfer_buffer,
+				  urb->transfer_buffer_length, &gref_head,
+				  &req->seg[0], nr_buff_pages,
+				  usb_pipein(urb->pipe) ? 0 : GTF_readonly);
+	}
+
+	req->pipe = xenhcd_pipe_urb_to_xenusb(urb->pipe, urb->dev->portnum);
+	req->transfer_flags = 0;
+	if (urb->transfer_flags & URB_SHORT_NOT_OK)
+		req->transfer_flags |= XENUSB_SHORT_NOT_OK;
+	req->buffer_length = urb->transfer_buffer_length;
+	req->nr_buffer_segs = nr_buff_pages;
+
+	switch (usb_pipetype(urb->pipe)) {
+	case PIPE_ISOCHRONOUS:
+		req->u.isoc.interval = urb->interval;
+		req->u.isoc.start_frame = urb->start_frame;
+		req->u.isoc.number_of_packets = urb->number_of_packets;
+		req->u.isoc.nr_frame_desc_segs = nr_isodesc_pages;
+
+		xenhcd_gnttab_map(info, &urb->iso_frame_desc[0],
+				  sizeof(struct usb_iso_packet_descriptor) *
+				  urb->number_of_packets,
+				  &gref_head, &req->seg[nr_buff_pages],
+				  nr_isodesc_pages, 0);
+		break;
+	case PIPE_INTERRUPT:
+		req->u.intr.interval = urb->interval;
+		break;
+	case PIPE_CONTROL:
+		if (urb->setup_packet)
+			memcpy(req->u.ctrl, urb->setup_packet, 8);
+		break;
+	case PIPE_BULK:
+		break;
+	default:
+		break;
+	}
+
+	if (nr_grants)
+		gnttab_free_grant_references(gref_head);
+
+	return 0;
+}
+
+static void xenhcd_gnttab_done(struct usb_shadow *shadow)
+{
+	int nr_segs = 0;
+	int i;
+
+	nr_segs = shadow->req.nr_buffer_segs;
+
+	if (xenusb_pipeisoc(shadow->req.pipe))
+		nr_segs += shadow->req.u.isoc.nr_frame_desc_segs;
+
+	for (i = 0; i < nr_segs; i++)
+		gnttab_end_foreign_access(shadow->req.seg[i].gref, 0, 0UL);
+
+	shadow->req.nr_buffer_segs = 0;
+	shadow->req.u.isoc.nr_frame_desc_segs = 0;
+}
+
+static int xenhcd_translate_status(int status)
+{
+	switch (status) {
+	case XENUSB_STATUS_OK:
+		return 0;
+	case XENUSB_STATUS_NODEV:
+		return -ENODEV;
+	case XENUSB_STATUS_INVAL:
+		return -EINVAL;
+	case XENUSB_STATUS_STALL:
+		return -EPIPE;
+	case XENUSB_STATUS_IOERROR:
+		return -EPROTO;
+	case XENUSB_STATUS_BABBLE:
+		return -EOVERFLOW;
+	default:
+		return -ESHUTDOWN;
+	}
+}
+
+static void xenhcd_giveback_urb(struct xenhcd_info *info, struct urb *urb,
+				int status)
+{
+	struct urb_priv *urbp = (struct urb_priv *)urb->hcpriv;
+	int priv_status = urbp->status;
+
+	list_del_init(&urbp->list);
+	xenhcd_free_urb_priv(urbp);
+
+	if (urb->status == -EINPROGRESS)
+		urb->status = xenhcd_translate_status(status);
+
+	spin_unlock(&info->lock);
+	usb_hcd_giveback_urb(xenhcd_info_to_hcd(info), urb,
+			     priv_status <= 0 ? priv_status : urb->status);
+	spin_lock(&info->lock);
+}
+
+static int xenhcd_do_request(struct xenhcd_info *info, struct urb_priv *urbp)
+{
+	struct xenusb_urb_request *req;
+	struct urb *urb = urbp->urb;
+	unsigned int id;
+	int notify;
+	int ret;
+
+	id = xenhcd_get_id_from_freelist(info);
+	req = &info->shadow[id].req;
+	req->id = id;
+
+	if (unlikely(urbp->unlinked)) {
+		req->u.unlink.unlink_id = urbp->req_id;
+		req->pipe = xenusb_setunlink_pipe(xenhcd_pipe_urb_to_xenusb(
+						 urb->pipe, urb->dev->portnum));
+		urbp->unlink_req_id = id;
+	} else {
+		ret = xenhcd_map_urb_for_request(info, urb, req);
+		if (ret) {
+			xenhcd_add_id_to_freelist(info, id);
+			return ret;
+		}
+		urbp->req_id = id;
+	}
+
+	req = RING_GET_REQUEST(&info->urb_ring, info->urb_ring.req_prod_pvt);
+	*req = info->shadow[id].req;
+
+	info->urb_ring.req_prod_pvt++;
+	info->shadow[id].urb = urb;
+
+	RING_PUSH_REQUESTS_AND_CHECK_NOTIFY(&info->urb_ring, notify);
+	if (notify)
+		notify_remote_via_irq(info->irq);
+
+	return 0;
+}
+
+static void xenhcd_kick_pending_urbs(struct xenhcd_info *info)
+{
+	struct urb_priv *urbp;
+
+	while (!list_empty(&info->pending_submit_list)) {
+		if (RING_FULL(&info->urb_ring)) {
+			xenhcd_timer_action(info, TIMER_RING_WATCHDOG);
+			return;
+		}
+
+		urbp = list_entry(info->pending_submit_list.next,
+				  struct urb_priv, list);
+		if (!xenhcd_do_request(info, urbp))
+			list_move_tail(&urbp->list, &info->in_progress_list);
+		else
+			xenhcd_giveback_urb(info, urbp->urb, -ESHUTDOWN);
+	}
+	xenhcd_timer_action_done(info, TIMER_SCAN_PENDING_URBS);
+}
+
+/*
+ * caller must lock info->lock
+ */
+static void xenhcd_cancel_all_enqueued_urbs(struct xenhcd_info *info)
+{
+	struct urb_priv *urbp, *tmp;
+	int req_id;
+
+	list_for_each_entry_safe(urbp, tmp, &info->in_progress_list, list) {
+		req_id = urbp->req_id;
+		if (!urbp->unlinked) {
+			xenhcd_gnttab_done(&info->shadow[req_id]);
+			if (urbp->urb->status == -EINPROGRESS)
+				/* not dequeued */
+				xenhcd_giveback_urb(info, urbp->urb,
+						    -ESHUTDOWN);
+			else	/* dequeued */
+				xenhcd_giveback_urb(info, urbp->urb,
+						    urbp->urb->status);
+		}
+		info->shadow[req_id].urb = NULL;
+	}
+
+	list_for_each_entry_safe(urbp, tmp, &info->pending_submit_list, list)
+		xenhcd_giveback_urb(info, urbp->urb, -ESHUTDOWN);
+}
+
+/*
+ * caller must lock info->lock
+ */
+static void xenhcd_giveback_unlinked_urbs(struct xenhcd_info *info)
+{
+	struct urb_priv *urbp, *tmp;
+
+	list_for_each_entry_safe(urbp, tmp, &info->giveback_waiting_list, list)
+		xenhcd_giveback_urb(info, urbp->urb, urbp->urb->status);
+}
+
+static int xenhcd_submit_urb(struct xenhcd_info *info, struct urb_priv *urbp)
+{
+	int ret;
+
+	if (RING_FULL(&info->urb_ring)) {
+		list_add_tail(&urbp->list, &info->pending_submit_list);
+		xenhcd_timer_action(info, TIMER_RING_WATCHDOG);
+		return 0;
+	}
+
+	if (!list_empty(&info->pending_submit_list)) {
+		list_add_tail(&urbp->list, &info->pending_submit_list);
+		xenhcd_timer_action(info, TIMER_SCAN_PENDING_URBS);
+		return 0;
+	}
+
+	ret = xenhcd_do_request(info, urbp);
+	if (ret == 0)
+		list_add_tail(&urbp->list, &info->in_progress_list);
+
+	return ret;
+}
+
+static int xenhcd_unlink_urb(struct xenhcd_info *info, struct urb_priv *urbp)
+{
+	int ret;
+
+	/* already unlinked? */
+	if (urbp->unlinked)
+		return -EBUSY;
+
+	urbp->unlinked = true;
+
+	/* the urb is still in pending_submit queue */
+	if (urbp->req_id == ~0) {
+		list_move_tail(&urbp->list, &info->giveback_waiting_list);
+		xenhcd_timer_action(info, TIMER_SCAN_PENDING_URBS);
+		return 0;
+	}
+
+	/* send unlink request to backend */
+	if (RING_FULL(&info->urb_ring)) {
+		list_move_tail(&urbp->list, &info->pending_unlink_list);
+		xenhcd_timer_action(info, TIMER_RING_WATCHDOG);
+		return 0;
+	}
+
+	if (!list_empty(&info->pending_unlink_list)) {
+		list_move_tail(&urbp->list, &info->pending_unlink_list);
+		xenhcd_timer_action(info, TIMER_SCAN_PENDING_URBS);
+		return 0;
+	}
+
+	ret = xenhcd_do_request(info, urbp);
+	if (ret == 0)
+		list_move_tail(&urbp->list, &info->in_progress_list);
+
+	return ret;
+}
+
+static int xenhcd_urb_request_done(struct xenhcd_info *info)
+{
+	struct xenusb_urb_response res;
+	struct urb *urb;
+	RING_IDX i, rp;
+	__u16 id;
+	int more_to_do = 0;
+	unsigned long flags;
+
+	spin_lock_irqsave(&info->lock, flags);
+
+	rp = info->urb_ring.sring->rsp_prod;
+	if (RING_RESPONSE_PROD_OVERFLOW(&info->urb_ring, rp)) {
+		xenhcd_set_error(info, "Illegal index on urb-ring");
+		return 0;
+	}
+	rmb(); /* ensure we see queued responses up to "rp" */
+
+	for (i = info->urb_ring.rsp_cons; i != rp; i++) {
+		RING_COPY_RESPONSE(&info->urb_ring, i, &res);
+		id = res.id;
+		if (id >= XENUSB_URB_RING_SIZE) {
+			xenhcd_set_error(info, "Illegal data on urb-ring");
+			continue;
+		}
+
+		if (likely(xenusb_pipesubmit(info->shadow[id].req.pipe))) {
+			xenhcd_gnttab_done(&info->shadow[id]);
+			urb = info->shadow[id].urb;
+			if (likely(urb)) {
+				urb->actual_length = res.actual_length;
+				urb->error_count = res.error_count;
+				urb->start_frame = res.start_frame;
+				xenhcd_giveback_urb(info, urb, res.status);
+			}
+		}
+
+		xenhcd_add_id_to_freelist(info, id);
+	}
+	info->urb_ring.rsp_cons = i;
+
+	if (i != info->urb_ring.req_prod_pvt)
+		RING_FINAL_CHECK_FOR_RESPONSES(&info->urb_ring, more_to_do);
+	else
+		info->urb_ring.sring->rsp_event = i + 1;
+
+	spin_unlock_irqrestore(&info->lock, flags);
+
+	return more_to_do;
+}
+
+static int xenhcd_conn_notify(struct xenhcd_info *info)
+{
+	struct xenusb_conn_response res;
+	struct xenusb_conn_request *req;
+	RING_IDX rc, rp;
+	__u16 id;
+	__u8 portnum, speed;
+	int more_to_do = 0;
+	int notify;
+	int port_changed = 0;
+	unsigned long flags;
+
+	spin_lock_irqsave(&info->lock, flags);
+
+	rc = info->conn_ring.rsp_cons;
+	rp = info->conn_ring.sring->rsp_prod;
+	if (RING_RESPONSE_PROD_OVERFLOW(&info->conn_ring, rp)) {
+		xenhcd_set_error(info, "Illegal index on conn-ring");
+		return 0;
+	}
+	rmb(); /* ensure we see queued responses up to "rp" */
+
+	while (rc != rp) {
+		RING_COPY_RESPONSE(&info->conn_ring, rc, &res);
+		id = res.id;
+		portnum = res.portnum;
+		speed = res.speed;
+		info->conn_ring.rsp_cons = ++rc;
+
+		if (xenhcd_rhport_connect(info, portnum, speed)) {
+			xenhcd_set_error(info, "Illegal data on conn-ring");
+			return 0;
+		}
+
+		if (info->ports[portnum - 1].c_connection)
+			port_changed = 1;
+
+		barrier();
+
+		req = RING_GET_REQUEST(&info->conn_ring,
+				       info->conn_ring.req_prod_pvt);
+		req->id = id;
+		info->conn_ring.req_prod_pvt++;
+	}
+
+	if (rc != info->conn_ring.req_prod_pvt)
+		RING_FINAL_CHECK_FOR_RESPONSES(&info->conn_ring, more_to_do);
+	else
+		info->conn_ring.sring->rsp_event = rc + 1;
+
+	RING_PUSH_REQUESTS_AND_CHECK_NOTIFY(&info->conn_ring, notify);
+	if (notify)
+		notify_remote_via_irq(info->irq);
+
+	spin_unlock_irqrestore(&info->lock, flags);
+
+	if (port_changed)
+		usb_hcd_poll_rh_status(xenhcd_info_to_hcd(info));
+
+	return more_to_do;
+}
+
+static irqreturn_t xenhcd_int(int irq, void *dev_id)
+{
+	struct xenhcd_info *info = (struct xenhcd_info *)dev_id;
+
+	if (unlikely(info->error))
+		return IRQ_HANDLED;
+
+	while (xenhcd_urb_request_done(info) | xenhcd_conn_notify(info))
+		/* Yield point for this unbounded loop. */
+		cond_resched();
+
+	return IRQ_HANDLED;
+}
+
+static void xenhcd_destroy_rings(struct xenhcd_info *info)
+{
+	if (info->irq)
+		unbind_from_irqhandler(info->irq, info);
+	info->irq = 0;
+
+	if (info->urb_ring_ref != GRANT_INVALID_REF) {
+		gnttab_end_foreign_access(info->urb_ring_ref, 0,
+					  (unsigned long)info->urb_ring.sring);
+		info->urb_ring_ref = GRANT_INVALID_REF;
+	}
+	info->urb_ring.sring = NULL;
+
+	if (info->conn_ring_ref != GRANT_INVALID_REF) {
+		gnttab_end_foreign_access(info->conn_ring_ref, 0,
+					  (unsigned long)info->conn_ring.sring);
+		info->conn_ring_ref = GRANT_INVALID_REF;
+	}
+	info->conn_ring.sring = NULL;
+}
+
+static int xenhcd_setup_rings(struct xenbus_device *dev,
+			      struct xenhcd_info *info)
+{
+	struct xenusb_urb_sring *urb_sring;
+	struct xenusb_conn_sring *conn_sring;
+	grant_ref_t gref;
+	int err;
+
+	info->urb_ring_ref = GRANT_INVALID_REF;
+	info->conn_ring_ref = GRANT_INVALID_REF;
+
+	urb_sring = (struct xenusb_urb_sring *)get_zeroed_page(
+							GFP_NOIO | __GFP_HIGH);
+	if (!urb_sring) {
+		xenbus_dev_fatal(dev, -ENOMEM, "allocating urb ring");
+		return -ENOMEM;
+	}
+	SHARED_RING_INIT(urb_sring);
+	FRONT_RING_INIT(&info->urb_ring, urb_sring, PAGE_SIZE);
+
+	err = xenbus_grant_ring(dev, urb_sring, 1, &gref);
+	if (err < 0) {
+		free_page((unsigned long)urb_sring);
+		info->urb_ring.sring = NULL;
+		goto fail;
+	}
+	info->urb_ring_ref = gref;
+
+	conn_sring = (struct xenusb_conn_sring *)get_zeroed_page(
+							GFP_NOIO | __GFP_HIGH);
+	if (!conn_sring) {
+		xenbus_dev_fatal(dev, -ENOMEM, "allocating conn ring");
+		err = -ENOMEM;
+		goto fail;
+	}
+	SHARED_RING_INIT(conn_sring);
+	FRONT_RING_INIT(&info->conn_ring, conn_sring, PAGE_SIZE);
+
+	err = xenbus_grant_ring(dev, conn_sring, 1, &gref);
+	if (err < 0) {
+		free_page((unsigned long)conn_sring);
+		info->conn_ring.sring = NULL;
+		goto fail;
+	}
+	info->conn_ring_ref = gref;
+
+	err = xenbus_alloc_evtchn(dev, &info->evtchn);
+	if (err) {
+		xenbus_dev_fatal(dev, err, "xenbus_alloc_evtchn");
+		goto fail;
+	}
+
+	err = bind_evtchn_to_irq(info->evtchn);
+	if (err <= 0) {
+		xenbus_dev_fatal(dev, err, "bind_evtchn_to_irq");
+		goto fail;
+	}
+
+	info->irq = err;
+
+	err = request_threaded_irq(info->irq, NULL, xenhcd_int,
+				   IRQF_ONESHOT, "xenhcd", info);
+	if (err) {
+		xenbus_dev_fatal(dev, err, "request_threaded_irq");
+		goto free_irq;
+	}
+
+	return 0;
+
+free_irq:
+	unbind_from_irqhandler(info->irq, info);
+fail:
+	xenhcd_destroy_rings(info);
+	return err;
+}
+
+static int xenhcd_talk_to_backend(struct xenbus_device *dev,
+				  struct xenhcd_info *info)
+{
+	const char *message;
+	struct xenbus_transaction xbt;
+	int err;
+
+	err = xenhcd_setup_rings(dev, info);
+	if (err)
+		return err;
+
+again:
+	err = xenbus_transaction_start(&xbt);
+	if (err) {
+		xenbus_dev_fatal(dev, err, "starting transaction");
+		goto destroy_ring;
+	}
+
+	err = xenbus_printf(xbt, dev->nodename, "urb-ring-ref", "%u",
+			    info->urb_ring_ref);
+	if (err) {
+		message = "writing urb-ring-ref";
+		goto abort_transaction;
+	}
+
+	err = xenbus_printf(xbt, dev->nodename, "conn-ring-ref", "%u",
+			    info->conn_ring_ref);
+	if (err) {
+		message = "writing conn-ring-ref";
+		goto abort_transaction;
+	}
+
+	err = xenbus_printf(xbt, dev->nodename, "event-channel", "%u",
+			    info->evtchn);
+	if (err) {
+		message = "writing event-channel";
+		goto abort_transaction;
+	}
+
+	err = xenbus_transaction_end(xbt, 0);
+	if (err) {
+		if (err == -EAGAIN)
+			goto again;
+		xenbus_dev_fatal(dev, err, "completing transaction");
+		goto destroy_ring;
+	}
+
+	return 0;
+
+abort_transaction:
+	xenbus_transaction_end(xbt, 1);
+	xenbus_dev_fatal(dev, err, "%s", message);
+
+destroy_ring:
+	xenhcd_destroy_rings(info);
+
+	return err;
+}
+
+static int xenhcd_connect(struct xenbus_device *dev)
+{
+	struct xenhcd_info *info = dev_get_drvdata(&dev->dev);
+	struct xenusb_conn_request *req;
+	int idx, err;
+	int notify;
+	char name[TASK_COMM_LEN];
+	struct usb_hcd *hcd;
+
+	hcd = xenhcd_info_to_hcd(info);
+	snprintf(name, TASK_COMM_LEN, "xenhcd.%d", hcd->self.busnum);
+
+	err = xenhcd_talk_to_backend(dev, info);
+	if (err)
+		return err;
+
+	/* prepare ring for hotplug notification */
+	for (idx = 0; idx < XENUSB_CONN_RING_SIZE; idx++) {
+		req = RING_GET_REQUEST(&info->conn_ring, idx);
+		req->id = idx;
+	}
+	info->conn_ring.req_prod_pvt = idx;
+
+	RING_PUSH_REQUESTS_AND_CHECK_NOTIFY(&info->conn_ring, notify);
+	if (notify)
+		notify_remote_via_irq(info->irq);
+
+	return 0;
+}
+
+static void xenhcd_disconnect(struct xenbus_device *dev)
+{
+	struct xenhcd_info *info = dev_get_drvdata(&dev->dev);
+	struct usb_hcd *hcd = xenhcd_info_to_hcd(info);
+
+	usb_remove_hcd(hcd);
+	xenbus_frontend_closed(dev);
+}
+
+static void xenhcd_watchdog(struct timer_list *timer)
+{
+	struct xenhcd_info *info = from_timer(info, timer, watchdog);
+	unsigned long flags;
+
+	spin_lock_irqsave(&info->lock, flags);
+	if (likely(HC_IS_RUNNING(xenhcd_info_to_hcd(info)->state))) {
+		xenhcd_timer_action_done(info, TIMER_RING_WATCHDOG);
+		xenhcd_giveback_unlinked_urbs(info);
+		xenhcd_kick_pending_urbs(info);
+	}
+	spin_unlock_irqrestore(&info->lock, flags);
+}
+
+/*
+ * one-time HC init
+ */
+static int xenhcd_setup(struct usb_hcd *hcd)
+{
+	struct xenhcd_info *info = xenhcd_hcd_to_info(hcd);
+
+	spin_lock_init(&info->lock);
+	INIT_LIST_HEAD(&info->pending_submit_list);
+	INIT_LIST_HEAD(&info->pending_unlink_list);
+	INIT_LIST_HEAD(&info->in_progress_list);
+	INIT_LIST_HEAD(&info->giveback_waiting_list);
+	timer_setup(&info->watchdog, xenhcd_watchdog, 0);
+
+	hcd->has_tt = (hcd->driver->flags & HCD_MASK) != HCD_USB11;
+
+	return 0;
+}
+
+/*
+ * start HC running
+ */
+static int xenhcd_run(struct usb_hcd *hcd)
+{
+	hcd->uses_new_polling = 1;
+	clear_bit(HCD_FLAG_POLL_RH, &hcd->flags);
+	hcd->state = HC_STATE_RUNNING;
+	return 0;
+}
+
+/*
+ * stop running HC
+ */
+static void xenhcd_stop(struct usb_hcd *hcd)
+{
+	struct xenhcd_info *info = xenhcd_hcd_to_info(hcd);
+
+	del_timer_sync(&info->watchdog);
+	spin_lock_irq(&info->lock);
+	/* cancel all urbs */
+	hcd->state = HC_STATE_HALT;
+	xenhcd_cancel_all_enqueued_urbs(info);
+	xenhcd_giveback_unlinked_urbs(info);
+	spin_unlock_irq(&info->lock);
+}
+
+/*
+ * called as .urb_enqueue()
+ * non-error returns are promise to giveback the urb later
+ */
+static int xenhcd_urb_enqueue(struct usb_hcd *hcd, struct urb *urb,
+			      gfp_t mem_flags)
+{
+	struct xenhcd_info *info = xenhcd_hcd_to_info(hcd);
+	struct urb_priv *urbp;
+	unsigned long flags;
+	int ret;
+
+	if (unlikely(info->error))
+		return -ESHUTDOWN;
+
+	urbp = kmem_cache_zalloc(xenhcd_urbp_cachep, mem_flags);
+	if (!urbp)
+		return -ENOMEM;
+
+	spin_lock_irqsave(&info->lock, flags);
+
+	urbp->urb = urb;
+	urb->hcpriv = urbp;
+	urbp->req_id = ~0;
+	urbp->unlink_req_id = ~0;
+	INIT_LIST_HEAD(&urbp->list);
+	urbp->status = 1;
+	urb->unlinked = false;
+
+	ret = xenhcd_submit_urb(info, urbp);
+
+	if (ret)
+		xenhcd_free_urb_priv(urbp);
+
+	spin_unlock_irqrestore(&info->lock, flags);
+
+	return ret;
+}
+
+/*
+ * called as .urb_dequeue()
+ */
+static int xenhcd_urb_dequeue(struct usb_hcd *hcd, struct urb *urb, int status)
+{
+	struct xenhcd_info *info = xenhcd_hcd_to_info(hcd);
+	struct urb_priv *urbp;
+	unsigned long flags;
+	int ret = 0;
+
+	spin_lock_irqsave(&info->lock, flags);
+
+	urbp = urb->hcpriv;
+	if (urbp) {
+		urbp->status = status;
+		ret = xenhcd_unlink_urb(info, urbp);
+	}
+
+	spin_unlock_irqrestore(&info->lock, flags);
+
+	return ret;
+}
+
+/*
+ * called from usb_get_current_frame_number(),
+ * but, almost all drivers not use such function.
+ */
+static int xenhcd_get_frame(struct usb_hcd *hcd)
+{
+	/* it means error, but probably no problem :-) */
+	return 0;
+}
+
+static struct hc_driver xenhcd_usb20_hc_driver = {
+	.description = "xen-hcd",
+	.product_desc = "Xen USB2.0 Virtual Host Controller",
+	.hcd_priv_size = sizeof(struct xenhcd_info),
+	.flags = HCD_USB2,
+
+	/* basic HC lifecycle operations */
+	.reset = xenhcd_setup,
+	.start = xenhcd_run,
+	.stop = xenhcd_stop,
+
+	/* managing urb I/O */
+	.urb_enqueue = xenhcd_urb_enqueue,
+	.urb_dequeue = xenhcd_urb_dequeue,
+	.get_frame_number = xenhcd_get_frame,
+
+	/* root hub operations */
+	.hub_status_data = xenhcd_hub_status_data,
+	.hub_control = xenhcd_hub_control,
+#ifdef CONFIG_PM
+	.bus_suspend = xenhcd_bus_suspend,
+	.bus_resume = xenhcd_bus_resume,
+#endif
+};
+
+static struct hc_driver xenhcd_usb11_hc_driver = {
+	.description = "xen-hcd",
+	.product_desc = "Xen USB1.1 Virtual Host Controller",
+	.hcd_priv_size = sizeof(struct xenhcd_info),
+	.flags = HCD_USB11,
+
+	/* basic HC lifecycle operations */
+	.reset = xenhcd_setup,
+	.start = xenhcd_run,
+	.stop = xenhcd_stop,
+
+	/* managing urb I/O */
+	.urb_enqueue = xenhcd_urb_enqueue,
+	.urb_dequeue = xenhcd_urb_dequeue,
+	.get_frame_number = xenhcd_get_frame,
+
+	/* root hub operations */
+	.hub_status_data = xenhcd_hub_status_data,
+	.hub_control = xenhcd_hub_control,
+#ifdef CONFIG_PM
+	.bus_suspend = xenhcd_bus_suspend,
+	.bus_resume = xenhcd_bus_resume,
+#endif
+};
+
+static struct usb_hcd *xenhcd_create_hcd(struct xenbus_device *dev)
+{
+	int i;
+	int err = 0;
+	int num_ports;
+	int usb_ver;
+	struct usb_hcd *hcd = NULL;
+	struct xenhcd_info *info;
+
+	err = xenbus_scanf(XBT_NIL, dev->otherend, "num-ports", "%d",
+			   &num_ports);
+	if (err != 1) {
+		xenbus_dev_fatal(dev, err, "reading num-ports");
+		return ERR_PTR(-EINVAL);
+	}
+	if (num_ports < 1 || num_ports > XENUSB_MAX_PORTNR) {
+		xenbus_dev_fatal(dev, err, "invalid num-ports");
+		return ERR_PTR(-EINVAL);
+	}
+
+	err = xenbus_scanf(XBT_NIL, dev->otherend, "usb-ver", "%d", &usb_ver);
+	if (err != 1) {
+		xenbus_dev_fatal(dev, err, "reading usb-ver");
+		return ERR_PTR(-EINVAL);
+	}
+	switch (usb_ver) {
+	case XENUSB_VER_USB11:
+		hcd = usb_create_hcd(&xenhcd_usb11_hc_driver, &dev->dev,
+				     dev_name(&dev->dev));
+		break;
+	case XENUSB_VER_USB20:
+		hcd = usb_create_hcd(&xenhcd_usb20_hc_driver, &dev->dev,
+				     dev_name(&dev->dev));
+		break;
+	default:
+		xenbus_dev_fatal(dev, err, "invalid usb-ver");
+		return ERR_PTR(-EINVAL);
+	}
+	if (!hcd) {
+		xenbus_dev_fatal(dev, err,
+				 "fail to allocate USB host controller");
+		return ERR_PTR(-ENOMEM);
+	}
+
+	info = xenhcd_hcd_to_info(hcd);
+	info->xbdev = dev;
+	info->rh_numports = num_ports;
+
+	for (i = 0; i < XENUSB_URB_RING_SIZE; i++) {
+		info->shadow[i].req.id = i + 1;
+		info->shadow[i].urb = NULL;
+	}
+	info->shadow[XENUSB_URB_RING_SIZE - 1].req.id = 0x0fff;
+
+	return hcd;
+}
+
+static void xenhcd_backend_changed(struct xenbus_device *dev,
+				   enum xenbus_state backend_state)
+{
+	switch (backend_state) {
+	case XenbusStateInitialising:
+	case XenbusStateReconfiguring:
+	case XenbusStateReconfigured:
+	case XenbusStateUnknown:
+		break;
+
+	case XenbusStateInitWait:
+	case XenbusStateInitialised:
+	case XenbusStateConnected:
+		if (dev->state != XenbusStateInitialising)
+			break;
+		if (!xenhcd_connect(dev))
+			xenbus_switch_state(dev, XenbusStateConnected);
+		break;
+
+	case XenbusStateClosed:
+		if (dev->state == XenbusStateClosed)
+			break;
+		fallthrough;	/* Missed the backend's Closing state. */
+	case XenbusStateClosing:
+		xenhcd_disconnect(dev);
+		break;
+
+	default:
+		xenbus_dev_fatal(dev, -EINVAL, "saw state %d at frontend",
+				 backend_state);
+		break;
+	}
+}
+
+static int xenhcd_remove(struct xenbus_device *dev)
+{
+	struct xenhcd_info *info = dev_get_drvdata(&dev->dev);
+	struct usb_hcd *hcd = xenhcd_info_to_hcd(info);
+
+	xenhcd_destroy_rings(info);
+	usb_put_hcd(hcd);
+
+	return 0;
+}
+
+static int xenhcd_probe(struct xenbus_device *dev,
+			const struct xenbus_device_id *id)
+{
+	int err;
+	struct usb_hcd *hcd;
+	struct xenhcd_info *info;
+
+	if (usb_disabled())
+		return -ENODEV;
+
+	hcd = xenhcd_create_hcd(dev);
+	if (IS_ERR(hcd)) {
+		err = PTR_ERR(hcd);
+		xenbus_dev_fatal(dev, err,
+				 "fail to create usb host controller");
+		return err;
+	}
+
+	info = xenhcd_hcd_to_info(hcd);
+	dev_set_drvdata(&dev->dev, info);
+
+	err = usb_add_hcd(hcd, 0, 0);
+	if (err) {
+		xenbus_dev_fatal(dev, err, "fail to add USB host controller");
+		usb_put_hcd(hcd);
+		dev_set_drvdata(&dev->dev, NULL);
+	}
+
+	return err;
+}
+
+static const struct xenbus_device_id xenhcd_ids[] = {
+	{ "vusb" },
+	{ "" },
+};
+
+static struct xenbus_driver xenhcd_driver = {
+	.ids			= xenhcd_ids,
+	.probe			= xenhcd_probe,
+	.otherend_changed	= xenhcd_backend_changed,
+	.remove			= xenhcd_remove,
+};
+
+static int __init xenhcd_init(void)
+{
+	if (!xen_domain())
+		return -ENODEV;
+
+	xenhcd_urbp_cachep = kmem_cache_create("xenhcd_urb_priv",
+					sizeof(struct urb_priv), 0, 0, NULL);
+	if (!xenhcd_urbp_cachep) {
+		pr_err("xenhcd failed to create kmem cache\n");
+		return -ENOMEM;
+	}
+
+	return xenbus_register_frontend(&xenhcd_driver);
+}
+module_init(xenhcd_init);
+
+static void __exit xenhcd_exit(void)
+{
+	kmem_cache_destroy(xenhcd_urbp_cachep);
+	xenbus_unregister_driver(&xenhcd_driver);
+}
+module_exit(xenhcd_exit);
+
+MODULE_ALIAS("xen:vusb");
+MODULE_AUTHOR("Juergen Gross <jgross@suse.com>");
+MODULE_DESCRIPTION("Xen USB Virtual Host Controller driver (xen-hcd)");
+MODULE_LICENSE("Dual BSD/GPL");
-- 
2.26.2



From xen-devel-bounces@lists.xenproject.org Wed Oct 13 08:03:27 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 08:03:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.208054.364071 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maZEA-0005aA-Hg; Wed, 13 Oct 2021 08:03:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 208054.364071; Wed, 13 Oct 2021 08:03:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maZEA-0005a3-EZ; Wed, 13 Oct 2021 08:03:06 +0000
Received: by outflank-mailman (input) for mailman id 208054;
 Wed, 13 Oct 2021 08:03:05 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=EFKL=PB=citrix.com=roger.pau@srs-us1.protection.inumbo.net>)
 id 1maZE9-0005Zx-Gp
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 08:03:05 +0000
Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id ed4b5c4e-63c4-4b98-979c-6bd8a53790f9;
 Wed, 13 Oct 2021 08:03:04 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ed4b5c4e-63c4-4b98-979c-6bd8a53790f9
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1634112183;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=zqvRV5kQKDaBPi6oqAtCKIfidDg8nH+0iqL5oatu+T8=;
  b=P6MWkUpWQgBcjWOzprX1156SbkyrpKPFiCVyO4NpQY85aFxYXxvIcFMc
   gGmO1b4cONAieJsRby/b4iMiziI9ryJtFvp92WlNIpwl1X8caBzRMk8Jm
   XbW5AHno2AHGSY7cZYJ4Hps9JEDyCSaW1QmGPNeSDFZC2YulQP1Hnj117
   Y=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: gjfcgcDmispWOpgaQAJndpeUhXIVy7SXaKZlxk+rWsurBee6+uqFcIXXkvRqbl53RALRL50y9J
 GLM5q91j96QQ5vGe1HnNHVI9EXuE/9orzq79tlBSmyHf2Y9U9eZCCzu/2auyD3eaauKaQ4TIOX
 MxkljK08owTi5Ir1ZBVW3TWsyXQ78hVZems7J6ePJuwQRSHa4LYKUMecLt8lBSdrFRQO+uvYx4
 pE2Bh0vPKFlS6VlMSdX+qLGgyAKgzIMkx8LH3lRzY6VJV3sBdBmMgluC41WW8lDQuz0d320/q7
 zy9+8foOPpl31H1qedy74Ivl
X-SBRS: 5.1
X-MesageID: 56941193
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:d+5ALqAAOwkIOhVW/yjlw5YqxClBgxIJ4kV8jS/XYbTApDglhDxRm
 2QXXWmAafjeZWf2eIh2ao60ox8OsMPUxt8wQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA
 xA2M4GYRCwMo/u1Si6FatANl1ElvU2zbue6WLOs1hxZH1c+EX550Ek7wobVv6Yz6TSHK1LV0
 T/Ni5W31G+Ng1aY5UpNtspvADs21BjDkGtwUm4WPJinj3eH/5UhN7oNJLnZEpfNatI88thW5
 Qr05OrREmvxp3/BAz4++1rxWhVirrX6ZWBihpfKMkQLb9crSiEai84G2PQghUh/2jOgsM984
 ul0v5GqGCwYDojFxOUzXEwNe81+FfUuFL7vJHG+tYqYzlHccmuqyPJrZK00FdRGoKAtWzgIr
 KFGbmBWBvyAr7veLLaTUO5ji95lNMD2FIgepmth3XfSCvNOrZXrHvubuYYBjWxYasZmG+T8N
 5QeQzdVSwXbQgxDEFhOVo8dg7L97pX4W2IB8w/EzUYt2ED6ygBr3f7VKsjEZdWQTO1chEPer
 WXDl0zpDxdfONGBxD6t9nO3mvSJjS79QJgVFrCz6rhtmlL77nMXIA0bUx28u/bRolWlR9tVJ
 kgQ+ywvhas/7kqmSp/6RRLQiHyLpBkHQPJLDvY3rgqKz8L84hmbLngJSCZbb94rv9NwQiYlv
 nejksn1HzVpvPuwQGiE67aPhTqoPG4eKmpqTS0OQBYB4tLjiJoulR+JRdFmeIaPh93oHXfLw
 jaFrAA3nbBVhskOv42c+V3EmDuqqoL+Zwg5/BjMXmml4wV6Y6aof4Wtr1Pc6J59wJ2xFwfb+
 iJewo7Hsb5IXcrleDGxrPslTbeAyOmIGgHli1N1TrIQxxGkp3+NctUFiN1hH3tBPsEBcD7vR
 UbcvwJN+ZNeVEeXgb9Lj5GZUJtyk/CxfTjxfrWNNIAWO8kuHOOS1Hg2PRb44oz7rKQ7fUjT0
 7+gesGwEW1SN61jyDenLwv2+e52nn5grY8/qJaS8vhG7VZ8TCLLIVvmGAHXBgzc0E9iiF6Km
 zq4H5HboyizqMWkPkHqHXc7dDjm10QTC5HssNBwfeWeOAdgE2xJI6aPmu95JdA/x/4JzbugE
 pSBtqlwkwWXaZrvc1TiV5yeQOm3AcYXQYwTbETAwmpEK1B8ON3yvc/zhrM8fKU99fwL8BKHZ
 6JtRil0OdwWEm6v021ENfHV9dU+HDz21VPmF3f0O1AXIs8/LzElD/e5J2MDAgFVVXHp3Sb/y
 pX9vj7mrW0rHlw4UpmNMq7zljtcfxE1wYpPYqcBGfEKEG3E+4l2MS3hyPgxJsAHMxLYwTWGk
 Q2RBH8lSSPl+ufZKfHF2vKJqZmHCex7EhYIFmXX9+/uZyLb4nCi0clLV+PRJWLRU2b9+aODY
 +RJzq6jbK1bzQgS64csQax2ya8e5sf0o+MIxApTA3iWPU+gDaltIyfa0JAX5LFN3LJQpSC/R
 lmLpotBIbyMNc68SAwRKQMpY/6tz/YRnjWOv/05LF+jvH18/aadUFUUNB6J0XQPILxwOYIj4
 OEgpM9JtFDv1kt0ao6L13kG+X6NI3oMV7QcmqsbWIK72BA2zlxiYIDHDnOk6p+4dNgRYFIhJ
 SWZhfSeiu0ElFbCaXc6CVPEwfFZ2cYVoBlPwVIPewaJl97CiqNl1RFd621qHAFczxEB2ONvI
 Gl7cUZyIPzWrTtvgcFCWUGqGh1AW0LFqhCglQNRmT2LVVSsW0zMMHY5aLSE800u+m5BeiRWo
 eODw2H/XDe2JMz800Peg6K+RyAPmTCpyjD/pQ==
IronPort-HdrOrdr: A9a23:seXg9a7yes6KY2hYhQPXwMzXdLJyesId70hD6qkXc20zTiX4rb
 HLoB1/73TJYVkqNE3I9eruBEDiexPhHPxOj7X5VI3KNGOKhILCFuBfxLqn7zr8GzDvss5xvJ
 0QFpSW0eeAbmSSW/yKgjWFLw==
X-IronPort-AV: E=Sophos;i="5.85,370,1624334400"; 
   d="scan'208";a="56941193"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=H5CnKF1hhW21quagJEfmpcRabOLHhjVWuEFXSLHtHmTeDl7ppbik39qSPCpf5y2VPNkySMdzfbVYbdZI8GnyYmvXBuGmZRmImMpvdT7pW6zFEsCc/eRYS/PAHZ6m6EauSzQpeYfSA+/pz6QB2wppFidW9r3oxdNuuFjEGzj3l94BlCCnR/WXwdqkLy4GzGsiuSQQMdzKYPzi7vxtW04f0BgRQtCHnE2agKBOBAuM9bYetXlpe+P1vq3h/TRLAgytyKgozrcHuHwsMAHcwFFEt2137APK8n3Ltxi9xkdlIdrsprVH4IXUl2mun24/fbJFYC04ocb/CAMd4P0IID1Gnw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=E2SCPJSS9nMQfiNegwvoJ6bjoxoDS441F4wEAIsJ/2A=;
 b=BZOQVvk4mT0xvOhedT66NUaYHD59ttAijLyzOurC9ePV0vuuuQFa+hoM7QK+oamC5AsGsjdic9OjSTKQWQUtsG6D6+ubx/9yaow10oYyawk39NUdyCGuo0rM6CE9GGVOYbh7DTO8ecL89b1vXdWC5OEwfJbrGpqTVZH6U1v0hSvuvNEoETGz3eiFBBis0N0AZPwfiWWAWdNTnVRgQoj9gzyeolxg4FizSwG94H8znPZqjqEDMhiVJTyU3K+5v1uTyKE8vdDaw1hsIPFHcMkBFl689pC5dEk+UXtAW1NBxzqmxVSXbhbgvm7/BMF2zNM9ePRUO0QD/ONS7scUedpISg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=E2SCPJSS9nMQfiNegwvoJ6bjoxoDS441F4wEAIsJ/2A=;
 b=LIAJBofZ6DTAc+nidJFeGLbjt1N2OEPGVexoq9SQA/1v6fQKJ3fe0tlOEYsDVp3D/6D64I6uICOtUeiuSUVf5ZRmV0F14q4Wfo7laBsQCMu0X0RhEdy+SBSbAB0GA3BekEL1rroIcJV/SLLUesMzK2VXZeirWgQasnuO3TsDQzk=
Date: Wed, 13 Oct 2021 10:02:26 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Bertrand Marquis <Bertrand.Marquis@arm.com>
CC: Ian Jackson <iwj@xenproject.org>, Jan Beulich <jbeulich@suse.com>,
	Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>, Rahul Singh
	<Rahul.Singh@arm.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, Andre Przywara <Andre.Przywara@arm.com>,
	Wei Liu <wl@xen.org>, Juergen Gross <jgross@suse.com>, Stefano Stabellini
	<sstabellini@kernel.org>
Subject: Re: [PATCH v5 01/11] xen/arm: xc_domain_ioport_permission(..) not
 supported on ARM.
Message-ID: <YWaSkrqzXoysQkCz@MacBook-Air-de-Roger.local>
References: <ac6d4785-ac9a-4491-26bb-c66ffe82c55b@suse.com>
 <ED8FC92F-B5EF-4473-B4A9-641C7D44859F@arm.com>
 <0744b957-1832-dff2-9ae2-b8e8534f501b@suse.com>
 <c3952fd5-b893-4cb6-a9bc-325a89e859db@epam.com>
 <c125b447-53e8-7d13-3b08-af62fd3a9140@suse.com>
 <c6b6c22f-fb8a-f2d9-7735-f1ebc9809908@epam.com>
 <09656882-b297-7144-c291-1ee997edb119@suse.com>
 <69A83587-B7E0-4653-AF8C-AEE802922CE5@arm.com>
 <24933.41349.893363.203683@mariner.uk.xensource.com>
 <AB6D62B6-2ED2-4957-A933-08EC77A4DFD6@arm.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <AB6D62B6-2ED2-4957-A933-08EC77A4DFD6@arm.com>
X-ClientProxiedBy: LNXP265CA0044.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:5c::32) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 57226bc9-281e-4506-13d6-08d98e1fcecd
X-MS-TrafficTypeDiagnostic: DM6PR03MB4474:
X-Microsoft-Antispam-PRVS: <DM6PR03MB447405AC54113294C8EDD1698FB79@DM6PR03MB4474.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: Geq27QIDYOz+S1Q5Gun/iDhXO/vDV5oFdKw1ZquJXozqz0lXGp7uzGbozXMjIZctp+5QPH0EnZmIWRnNRdpuAFbesgp6crk5mzvs86QiCVCxkTYwx82QhD2U0p/C9Yw5Mgzyi2Iibpc4a9SlhRMGduhOkQGZtAz0pnVrdII3krPUuoAFCfPs5MYszZYprP1vdZ6UqGXe0KcuNN37xD0LlTtdMNxZEXpVNbMDkIe67K2RlFipEA9HxBJM6iWCzPxqZvZ9zxq2xMDwImJh49stgGzOkxsArVqD7IsQ3iOHM+2c4VG6fh40Qs+XiLGYYaoKmdabuuvQPybhKWSY/lvHTnZMqEyR18J/UA3y5CT/PAz3JXCF8e0drcuf0xDmkPlGWYNdsIuNbbNBoJOVH/OFxDPX5U1bUfbpDU18KgM61/eMKrZGXqnyxMDGu+Rd1Wh1Ic3xvBEqfEauwWX3xVu/NA7bvldFobJPDop623qKE6Ofd7vORbOJAg//vPS8OMO2RrdgLvp0D1UETUczFxFjtGsbgf5A716l9DYKdchG9IlFbx8sfafU2wnQYeJSfT+xGQ3hDuDaRH6qGUV4In+XptrkWbPP2WNEE9wBRi8bE/zMZwogreSMJGJNS7a25bO0ZE/bj5TJaaDAI/rOxhfYxw==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(6496006)(8936002)(66946007)(6486002)(7416002)(53546011)(508600001)(38100700002)(66476007)(9686003)(54906003)(316002)(66556008)(186003)(8676002)(5660300002)(6666004)(956004)(2906002)(6916009)(86362001)(85182001)(26005)(82960400001)(4326008)(83380400001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K0MzdlBiWUpXZmxybytzZXF0T0ZneEhhelJFWE9QZkhYT2hOYjVqYVpKVUt0?=
 =?utf-8?B?OGpyN0QxUTRwbHdsYlNkNHRCU3ZGajlBUVB1YlBSQmd0ZVMwa0M5b2RaTWIx?=
 =?utf-8?B?UU9XUVRXeVFEYzJLRVpEcVFCZFpyTEJvWlFvemZScFB3YmJNd29yNzVxaGtm?=
 =?utf-8?B?djhlZ1FnaTZiWk56cFBWem5rejJ3eURtaUJlNGRKSVVUdUViM3BxdHpiNFJJ?=
 =?utf-8?B?aUFmbVJHL1h2aitRUEY1bWpSdDczZjFYZWEzWXZxT2NFUlUzU3llV0VDdS9C?=
 =?utf-8?B?MFA1NXF6enBrT0dsSVFTNUY1RE80cjgyb1JWNmYvYzlHOWQ4OThBai8wVndR?=
 =?utf-8?B?bVBob0NGemlPekZ0czBXSUU1UVlpNjg1TS9SYkszYjgrVGVWNDZ1eVJZR291?=
 =?utf-8?B?NEdwWUNSS042bkR3T0s0RHFESFlvVmdCUmhEcVFySC9MNTdsc0VqNDNvTytk?=
 =?utf-8?B?cFJJbm1oT0FaWE5QWDZMa3NTMjJ4T0h2NzFDMnF1djU0NkxITDhZZzIrajhQ?=
 =?utf-8?B?K0VTZmhrcDk4Ni9FRUpRVFBud3NjS3ltZUNpT1ZYSWZOVHdKM0JCQlJrckRN?=
 =?utf-8?B?aERIeUxtcVNjVSswQ29TN0VxUmFBbmczVjQ5TkxRaTNkQzE5THE4cjdBTGxw?=
 =?utf-8?B?OUdXSTZqSjBhdzFmc0VHYW02NWJFSXdmamIzdDFEOHU0eDBaR00rQ0Ruek1X?=
 =?utf-8?B?Rk5NRUQrU3NyWWZEQ0RSWVJVc2szaHJoOERFd09RL09QcXRUQVFKT0dia0dR?=
 =?utf-8?B?YVViMjZVcnpUTXB3em0vSHh3YnVNU3FUZVFLNVhOTEdzbTcwam1GY1NDT09S?=
 =?utf-8?B?YmhqencvMUQ5bmIxMUF6WjYweFYrSUdpN0NVTXZvaFkzbnBEcjdxTFRyV1ps?=
 =?utf-8?B?eVhRRFNBenNqdHNMTCtWNHA4QTdyZUQ0bSt6RXlrbEQzR0tReWRRTmdlRCtD?=
 =?utf-8?B?UjdHL0xDdnY1YUJ4Ym93N2lwS0ZOZStvb1RRZ2phalVOZmlRcTRCQmRrQm1W?=
 =?utf-8?B?eUw0U2k1OFhwNE5kZnltdnRCZ3NUZnRFQ0YrMHlDZVhZbVVuQlZZQ2hBNTQr?=
 =?utf-8?B?SkdhU3d2NGoyVUFvTzB5NEwyaEVkL2VoYWg1bUJOeC9sTG9lL2xucmZSSlhK?=
 =?utf-8?B?NktOeEM0cFVRUkJ0QXBiUjAyWlR0eXk5eUE5V0ZHelE1ZWFEdlgvRS8yR3Q5?=
 =?utf-8?B?SVZNTDJjSFNMK3F4WjBOcjdWdXNIUmRMOTNsbGtFRG9JcDNZTGxoQStxN0g3?=
 =?utf-8?B?dlY2M3ZmWWVCNEVncFJYZy9MUnNrYXU2T0FLdCtaMHV1VXo5Y01zUGhUM013?=
 =?utf-8?B?ZlZ0dDJKMllZaEkydlhWNGIrSldFT3VxMm5kVWp0ZkRUeVlaWnUrejFQd0Vy?=
 =?utf-8?B?MzdJYzg5Tkh6U2Z2dC9BZEZFZjdOK3ZHTDNiYXR6eG1URjRLczVvdjg2Q0p5?=
 =?utf-8?B?dkJVNTlCVmNoa2hydlBja3Y5NWlYeHBHdCthbTBwYnV3a1B5R0pDZDFZWWVt?=
 =?utf-8?B?cjVMSXlBamU1blFzMHlrUFFXb2JEMlFoYWVkVGFOYSsyVVNCZldBZEZ5WEJI?=
 =?utf-8?B?ZFJBK3A1Ti8xV3ZscmF6L2JjRWFRbmhoT0dnNkdyYjJyNkNxVXJMbWFjaTVw?=
 =?utf-8?B?VnpuTHVLYzZ5d0RjZWV5OVpjVWdpZlNyMHZSN2h1MFpOVUU2eElTSjBNa243?=
 =?utf-8?B?cUdWN0VhYTBLM2Uwb1pZUWpCK1BSNzhaMHpLbmN4WkMxRFpWU3R3cWd2V0Fx?=
 =?utf-8?Q?OyyfdUSzbvldBJxwksdH7Y/g9eiOUqFMi1VzJnP?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 57226bc9-281e-4506-13d6-08d98e1fcecd
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2021 08:02:31.6791
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: k2PhHOxui/X/a8Z8t7XbxX3Quxeedes4r9OR9rDYc8MZCk71cXCoMeOtl2xO9p8fXrSAjUHwv8Q83v5sxpVRbQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4474
X-OriginatorOrg: citrix.com

On Tue, Oct 12, 2021 at 04:15:20PM +0000, Bertrand Marquis wrote:
> Hi Ian,
> 
> > On 12 Oct 2021, at 15:53, Ian Jackson <iwj@xenproject.org> wrote:
> > 
> > Bertrand Marquis writes ("Re: [PATCH v5 01/11] xen/arm: xc_domain_ioport_permission(..) not supported on ARM."):
> >> So there is no comment remaining on this patch ?
> > 
> > I have been following this thread.  I think I have a notion of why
> > this is needed but I'm not 100% clear on it.  The commit message says
> > this:
> > 
> >> ARM architecture does not implement I/O ports. Ignore this call on ARM
> >> to avoid the overhead of making a hypercall just for Xen to return
> >> -ENOSYS.
> > 
> > which implies it's a performance improvement.  But the change also
> > suppresses an error return, so this commit message is false.  I think
> > that the thread has concluded something different, but it should be
> > explained in the commit message.  The purpose of a commit message is
> > precisely to capture the kind of considerations and discussion that
> > occurred in this thread.
> 
> I can add something in the commit message about the fact that we improve
> performance and prevent to do a call that is and will not be supported in Xen.

IMO it would be good to modify the commit message so it covers the
fact that the emulated host bridge on Arm does not advertise IO port
support, so the guest is capable of realizing IO BARs are not
supported.

Otherwise it seems like the toolstack is ignoring a failure which
could cause a device to malfunction when passed though (which is still
the case, but the guest will be able to notice).

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Wed Oct 13 08:08:03 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 08:08:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.208061.364082 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maZIr-0006Ec-47; Wed, 13 Oct 2021 08:07:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 208061.364082; Wed, 13 Oct 2021 08:07:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maZIr-0006EV-0x; Wed, 13 Oct 2021 08:07:57 +0000
Received: by outflank-mailman (input) for mailman id 208061;
 Wed, 13 Oct 2021 08:07:55 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=EFKL=PB=citrix.com=roger.pau@srs-us1.protection.inumbo.net>)
 id 1maZIp-0006EP-Nu
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 08:07:55 +0000
Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id aaa0acec-2bfc-11ec-8160-12813bfff9fa;
 Wed, 13 Oct 2021 08:07:54 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: aaa0acec-2bfc-11ec-8160-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1634112473;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=g9tEQmdYHWvIlLrHwqoqUcTiY2wHmYOwzkXcxDWlnSg=;
  b=eGk5Mpp6Wqp5PRMDxQho+Xu+hZ1D1NMqwXU9yWUb8y0pcT0x3VLptLQa
   IMGaw2TRMNzbB+I1H052DW4764KGA5brqSF0jEGsI6vVu1FbQ5bWpW4bL
   V8gXw6tC2z6o802RJO9xz0c09X+d8pAOr9aXn7wUDrkTDwHQSbXl7wZWk
   c=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: 4qXifavkVp1dH4KObSaelwTEHb06ZciJcdhrqTrV0PY5J96puziGmZmIx1Fa5hrD4FjWY/1+kz
 F5I0C5xUuuUDSMvYqVu7bPPEQH2ySW2WoYAmoMoaRqCbR5z6SRAhaVDaharLMndou2uJQpCJIM
 IyWE+3UKGrabhClBOG/hKujQeHH1hghNMxuyiFlAYKPJ6srOXaLciFJcmRK45JrrBy9W+1wAdt
 GulM2jRQ3zLI+mEf+aQ5jv1P7oaIGppxbz/wlW6g7dHBHmH8zfhRa7IdObdz2B0RZKEwNUOvhH
 bA7DAgnA/mVTzYjpnelrPsaO
X-SBRS: 5.1
X-MesageID: 56941569
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:4j8pO66aP1/RmqNGedbUzgxRtDPBchMFZxGqfqrLsTDasY5as4F+v
 mYbXGqEPq6PMGvzc9p/PtiypE4Ou8Tcn4JkHVNr+CFjHi5G8cbLO4+Ufxz6V8+wwmwvb67FA
 +E2MISowBUcFyeEzvuV3zyIQUBUjclkfJKlYAL/En03FVIMpBsJ00o5wrdh29Uw2LBVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Zk
 NdLh7ebUSoSJpKTw8scCxQDITpwBPgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALNs7kMZlZonh95TrYEewnUdbIRKCiCdpwgWlh2pkTQ6e2i
 8wxTDF0KyaDUiFzIF4WJohiw8qX13D+WmgNwL6SjfVuuDWCpOBr65D9PdyQdtGUSMF9mkeDu
 nmA72n/GgsdNtGU1XyC6H3ErtXGnT7/HrkTErK43vdwhRuYwWl7IDQQWUG258GjmF+hUshWA
 0UO/2wlqq1a3E6kVN7mRDWjvWWJ+BUbXrJ4DOkS+AyLjK3O7G6xB3cGZi5MbsQ8s807TiBs0
 UWG9/vyHiBmurCRTXOb95+XoCm0NCxTKnUNDQcuQBEZ+dDlrMcWhwjWU9d4OKevi5v+HjSY6
 xeOoSsljrMfl/ki0amh4EvHiDKhoJvOZgMt7wCRVWWghit7boO4Y42j6XDA8O1Nao2eSzG8U
 GMswpbEqrpUVNfUyXLLEL5l8KyVC+itaD/as3VEB7Qa7wvyoFGiJY0L0ipwHRI8WiobQgPBb
 EjWsAJXwZZcOnq2cKN6C76M59QWIbvITou9CKiFBjZaSt0oLlXfpXAxDaKF9zm1yBBErE0pB
 XuMnS9A514hAqN70CH+ee4Z1bI6rszV7TKOHc6lp/hLPLz3WZJ0dVvnGAfQBgzaxPndyOkwz
 zq5H5DVo/m4eLevChQ7CaZJcTg3wYIHLZ73sddLUeWIPxBrHmosY9eIn+h9I9I5xfwPyryUl
 p1YZqO+4AGg7ZEgAV/bAk2PlZu1BcovxZ7FFX1E0amUN4gLPt/0sfZ3m2ofdrg77u1zpcOYv
 NFeE/hs9s9nE2ydkxxENMGVhNU7KHyD2FLfVwL4MWNXV8MxGGT0FirMI1KH3DMQFRC+qcZWi
 +Tmjms3t7JYHF88ZCsXAdryp26MUY81wbooARSTeIUPIS0BMuFCckTMsxP+GOlVQT3rzTqGz
 QeGRxAeoOjGuYgu99fVw6uDqu+U/yFWRxMy87Dz4enkOC/E0HCkxIMcAu+EcSqEDDH/+bm4Z
 PUTxPb5aaVVkFFPuot6MrBq0aNhuIe/++4EllxpTCfRclCmKrJ8OX3aj8NBgbJAm+1CsgysV
 0PRptQDYeeVONnoGUI6LRY+arjRzukdnzTftKxnIEjz6CJt0qCAVEFeY0uFhCBHdeMnO4I52
 +Yx/sUR7lXn2BYtN9+HiAFS9niNcSNcA/l26MlCDday2AQxy1xEbZjNMQPM4cmCO4dWL00nA
 j6In66e1b5S8VXPLigoHn/X0OsD2ZlX4EJWzEUPLkiik8begqNlxwVY9Dk6Q1gHzhhD1O4va
 GFnO1csePeL9jZswsNCQ3qtC0dKAxjAoh79zF4AlWv4SUi0VzOScD1haLjVpE1JoXhBejV7/
 a2DzDe3WDnnS8j9wy8uVBM3sPfkV9FwqlXPlc3P8x5pxHXmje4JWpOTWFc=
IronPort-HdrOrdr: A9a23:GqOklqo7o+tjkJRQeOwJRTQaV5vPL9V00zEX/kB9WHVpm5Oj+P
 xGzc526farslsssREb+OxpOMG7MBThHLpOkPMs1NaZLXLbUQ6TQr2KgrGSoQEIdxeOk9K1kJ
 0QDpSWa+eAc2SS7/yKmTVQeuxIqLLskNHK9JbjJjVWPHlXgslbnnhE422gYytLrWd9dP4E/M
 323Ls6m9PsQwVdUu2LQl0+G8TTrdzCk5zrJTYAGh4c8QGLyRel8qTzHRS01goXF2on+8ZuzU
 H11yjCoomzufCyzRHRk0fV8pRtgdPkjv9OHtaFhMQ5IijlziyoeINicbufuy1dmpDk1H8a1P
 335zswNcV67H3cOkmzvBvWwgHllA0j7nfzoGXo90fLkIjcfnYXGsBBjYVWfl/y8Ew7puxx16
 pNwiawq4dXJQmoplWy2/H4EzVR0makq3srluAey1ZFV5EFVbNXpYsDuGtIDZY7Gj7g4oxPKp
 ggMCjl3ocXTbqmVQGbgoE2q+bcHEjbXy32DnTqg/blkgS/xxtCvg4lLM92pAZ2yHtycegB2w
 3+CNUaqFh5dL5jUUtMPpZwfSKJMB2+ffvtChPaHb21LtBOB5ryw6SHlYndotvaP6A18A==
X-IronPort-AV: E=Sophos;i="5.85,370,1624334400"; 
   d="scan'208";a="56941569"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=bW9AV5JSLuQmjfxPxB8myAfGHVpLWO5hfPQWP+OBCS/Iqf+hIdP0Q00x1ZVF34oh+8m/kbun0iIRN1ANowDIroLGCni80rXead3wIpq9uUNRgISt3Invz27wMq9wxXZ9RWyJ8lOOolTVGFRwGAFPZMk3N6EK6VUi3gZ++BEmLVHebToR/ZPdhA5t6rK3uwvYZzSzOrwhSRd5yU9ZZiLTaPURC7G3ZPX4SoEkRqfXzoTa50RwowZmRu+omLGdd3NfQZNleF05h/DsT69xxK4LrGMIQSvLhgL8hZrb/ZofksdVHl3drBm3kpTttFAkJCL4CPH2d6JxtRbvH9htLr4YgA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=v00iuWyE2PiiAhGRykBLcgUdGpqke5WEwAcX9kekWpI=;
 b=bG/4eZqf1+S5q3DsX3C8T54tHbjeoEPcEQqr0xAq7oEs26qrWQ070Fv9fGmqgZuN7qZN33GX5HsA96XMihW4KJwzanC89lQevy6cFkgpQ9L4XTPGZkt78lLwvHPs72VE3tI6ACO32speDykO1ytEk131K44J2xMsU4SdFQENosl91gNilDgZ7ZaRGmWbrrAqr3mJddgtjiTf34Eqtka7i9ZF7HCTSDMtWbKE+sq/L2oYNd2e62C4Yyk/pOk92zJ32beVqTu+Ay+WXJkxZifjUEKkPQxHoHUk3BWIEpzNLNP1KZB4PLOGeKdSOK0d+Y71yt3VBbQLfB5VYfyMQD8pBQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=v00iuWyE2PiiAhGRykBLcgUdGpqke5WEwAcX9kekWpI=;
 b=G8JwYdS7hhe54ZUVCNf7+gzX3BWGQwclCN3JVRPhfpD6wXUz/PfQKbGXZnSNAiOVK2po05A0QgTJSI7ezS46RlIbU8Psuyfb7ORWfq0jyvdbcRAm6zrfme7+NDQIIM7DhJu54gybZqRYaDiDAujOoZKMitDEhtQRCbZbd7iles4=
Date: Wed, 13 Oct 2021 10:07:42 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Stefano Stabellini <sstabellini@kernel.org>
CC: Ian Jackson <iwj@xenproject.org>, Bertrand Marquis
	<Bertrand.Marquis@arm.com>, Jan Beulich <jbeulich@suse.com>, Oleksandr
 Andrushchenko <Oleksandr_Andrushchenko@epam.com>, Rahul Singh
	<Rahul.Singh@arm.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, Andre Przywara <Andre.Przywara@arm.com>,
	Wei Liu <wl@xen.org>, Juergen Gross <jgross@suse.com>
Subject: Re: [PATCH v5 01/11] xen/arm: xc_domain_ioport_permission(..) not
 supported on ARM.
Message-ID: <YWaTztHHHeghjxDR@MacBook-Air-de-Roger.local>
References: <0744b957-1832-dff2-9ae2-b8e8534f501b@suse.com>
 <c3952fd5-b893-4cb6-a9bc-325a89e859db@epam.com>
 <c125b447-53e8-7d13-3b08-af62fd3a9140@suse.com>
 <c6b6c22f-fb8a-f2d9-7735-f1ebc9809908@epam.com>
 <09656882-b297-7144-c291-1ee997edb119@suse.com>
 <69A83587-B7E0-4653-AF8C-AEE802922CE5@arm.com>
 <24933.41349.893363.203683@mariner.uk.xensource.com>
 <AB6D62B6-2ED2-4957-A933-08EC77A4DFD6@arm.com>
 <24933.47094.43672.782143@mariner.uk.xensource.com>
 <alpine.DEB.2.21.2110121319150.9408@sstabellini-ThinkPad-T480s>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <alpine.DEB.2.21.2110121319150.9408@sstabellini-ThinkPad-T480s>
X-ClientProxiedBy: LO2P265CA0181.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:a::25) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: ceec560f-5423-4b26-6c07-08d98e208b0c
X-MS-TrafficTypeDiagnostic: DM6PR03MB4298:
X-Microsoft-Antispam-PRVS: <DM6PR03MB42982956B331D5F8568A837E8FB79@DM6PR03MB4298.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: w0PmwcqtJpFI5vviAUAWMyR6aYeBlvSLhi1hAhRo5eTgzkO1Lj3ouonbdygXcSk1udakeG5m703d8KEbsEv/xvVq3Mu0ouO0tdn5s24zPqdaB0zhIljfsR1Y7Do3TwiPalvaAWuKGrxABBT077r2d5nLigmoFgMoL57qF2CNj8rWXCCGrmI6257fPC7umc14DCeAZ9DNQsPBIDZuQRxC0+UHVP2tgTe8q1u9pqFStuxs8sC68bWO7ioj9LjDMuFq97c5qpDesBn9PSR5LI4l27kaYvvaDeAXtiE4KXxV+fzfk57j6Gqp4yeXJfRSV0H1Cr1e7b2kb81LvkX+jjmSSESBaBCA6xCgR3L1ZhB+okmioUL5zA0M+ETyrBFFTamsS8evOdHWUtnl/bXYkzkQasebqtdT8gfXSvR1Q1NReImm/T4YAyIXC190bVsU4PQnXAKRqSXIOFKA0vJ9ULfnf/iyc5sv+iL31XfnWgmRkq/CnpFsdj+62ibZMQ2AvFmwNEUOaVKbpVD0TgOVJkbcKYXAFnZ3FnHFEjsi76r9OMgSvjJ6Rz2cwVIuxV2//emqn5crx6Uf7YsZjtC6K8vjgloguv1nlhz9+xr/xRe8w8eDuFTaBQ9Yc/7wAZKMP557ri7vP0Da8fDTSC/jALQZKw==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(38100700002)(26005)(54906003)(6496006)(186003)(8676002)(66556008)(316002)(85182001)(83380400001)(508600001)(8936002)(82960400001)(4326008)(86362001)(6666004)(5660300002)(956004)(7416002)(66946007)(6916009)(6486002)(66476007)(9686003)(2906002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TzFGVkNZNXRYMWlNM0M1OUVCNkVrZjVHa1NVYWhjaU9hcE5CaWhpNWJ5Nkpi?=
 =?utf-8?B?cXVuNEtObERCb0E1dlNmTUxhbmVWZktpcStUUWdpV0IveGVGcW44M3RjaU1x?=
 =?utf-8?B?Yk10c1U1TjBpdXRJUnFZd2taYnZJL0IxZDYwY0RrTS8xRXVYc1ZlaHdiVmh6?=
 =?utf-8?B?bDN3QzFOTERXdGlYS0NYSXRYK2JaOVVFTUhLZ0R2TE9xUWM0cDRmazdhbUVF?=
 =?utf-8?B?MHhhb25MSlpFKzIzRTBvK1cwbUdzb2JvYnFRTU8rR2FrV1l2Y0NHaWpBdTVE?=
 =?utf-8?B?N2NxK05Bcm81QnRaSVA1VmpVMDhVS1BoWWVMS1dwM2VSQW5BLzk5VlBxdGxq?=
 =?utf-8?B?VTBFV3VQL3JtQWhncTJpUnRVZW9uK2RFNWdwclBNcFpaMmxaWit3a1hHZHJS?=
 =?utf-8?B?NXFGU0ltN3h0NVUrRUtQazEyL0grV21rRVFyajlJRmd4K3JaRi9ac1haK0Rt?=
 =?utf-8?B?VUh3Wm93U3IyQ0RmMlpDY2RlUFhXSmdjN3p5cjZIN04rcU5XOHdSc2Z2UkFh?=
 =?utf-8?B?c1ZRQVlXYXpSTWkzaXRzeWM0QVRjU3BlNU5aTDBMU1VwOUphUFNybWtYcHg0?=
 =?utf-8?B?VEh5WjlmOEE3SEJ1U3Rvc1ZzWHhxNnFaY3V6R3B3SDdmbkFiaE1vU1l6Yjlv?=
 =?utf-8?B?c0pKemZiTFZ0dEo3dys2UTJQdUdIS2xoVUVhLzZzVE14WUl4MlduZGhBM2lt?=
 =?utf-8?B?MzNxNUx0T0NCSjJ4WldEUExHK0hPQldkUFRURU9uQjBIckpzckZ5MmhSMk1u?=
 =?utf-8?B?Z2JURkd3Z1piUE1DWGp3OHNvWFVNb2xPUDhvS29KQ2d2V3FGSTVyUnRYaEZj?=
 =?utf-8?B?Yys2UHNvcnJsTmZaL1A1MmkxNDlGOHJIdUVRODBWOEdjUEtKektjdEFiQjJO?=
 =?utf-8?B?Qm92SXV2U3E5NHZ5RDJ0WW9QdDh6ZDZkQlNTN2gxcWFoWi9BV3dsSlVNTXdm?=
 =?utf-8?B?NWt5TTZuekl5bG5nWk5VWjAvTlFjK3RhaHJkZ3pZb01sRTB6bCt3U2crMjFX?=
 =?utf-8?B?VWRTeS9xbzFKZFNHOWVJc05qNTNYQVk3RDRTQXdtK0psSFB1NG1DUjJjb2NQ?=
 =?utf-8?B?UGc2cXpvdXJmamVpN2lGbkRpMHY1NEtydjlZM3NiNGZjeDdjWHFydXF3Sllj?=
 =?utf-8?B?MXBRV1oxVVZZeXBkRW1BbnpSMXpmUzJGOENUUEdMTmJBSVNiWER2WFNZRVli?=
 =?utf-8?B?cHRmRGZUSTJLRDJZSGtVUHJQOVNjbjdkWFZWN04rNVUvbUpob3V6M1RHeWFv?=
 =?utf-8?B?WWtRVkFwZWJlVy9jSEhTNDA4dFBlUDZURUlIWW44TTlZcCs0TUtQd1NXK0w1?=
 =?utf-8?B?SnVMMkFxc1NRdmloRmw0ZldKY3dTL2tubzdJMU9kVUtGd1NvQTFXSTl3Yldn?=
 =?utf-8?B?WERUSDZqSWlCSnVmSWNYM0daN1VYN3BIUkFvcUg4VHIxeGlyVkJRZzhmQjgx?=
 =?utf-8?B?RFVQSUNEQ0RGSjBXUzdyTFpTUjQyYTBBbVUrUUVub3Y2elN0K3NtdmpmbHJZ?=
 =?utf-8?B?TG92MnV4SFRScGdMcVlJY2pzTnR0SVVFMlhvdzJKTHc0cjA3ZXUrdjY1NXNk?=
 =?utf-8?B?VnlsL3pQTUM0YlZyam1oU1hpdVllS3g2V3Z4d3V6YjRQN1ExS3E1QURsZGFS?=
 =?utf-8?B?ZzJsNE4zaG5vY1BSVXBRc1RTSm5pcXA3RDhORnZud2psTkxLQU02M3VPZ2hk?=
 =?utf-8?B?UG93TE5YTWk1dG5CRjR1ckxNOUlmMkJwanl1MDEwWDY0dFM3ajZGTm5WZFRO?=
 =?utf-8?Q?iyCsyE/POlJ08EXbA5vucgwMraHpWFeJoSfd8YE?=
X-MS-Exchange-CrossTenant-Network-Message-Id: ceec560f-5423-4b26-6c07-08d98e208b0c
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2021 08:07:47.3665
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jkL0Qub6qNQ+EXSJW0gFK0ZWsQjllCnAdjaR5uejRU+HIK79jo8IusU06z9PXVslZlOWRQjswQJ4WhQYO7r8ag==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4298
X-OriginatorOrg: citrix.com

On Tue, Oct 12, 2021 at 01:42:22PM -0700, Stefano Stabellini wrote:
> On Tue, 12 Oct 2021, Ian Jackson wrote:
> > Bertrand Marquis writes ("Re: [PATCH v5 01/11] xen/arm: xc_domain_ioport_permission(..) not supported on ARM."):
> > > I can add something in the commit message about the fact that we improve
> > > performance and prevent to do a call that is and will not be supported in Xen.
> > 
> > Thanks but I'm afraid I don't think that is a correct summary of the
> > thread.  Nor would it be an adequate justification for the change.  At
> > least, not unless you plan to write something considerably longer (and
> > more precise).
> > 
> > Firstly, I'm not convinced this change would be justified by the
> > performance impact.  This is a small number of hypercalls during
> > domain startup.  Usually none, I think ?  If someone wants to optimise
> > domain startup speed then I am very open to that but I think this
> > change will make negligible change in practice.  Unless someone wants
> > to tell me I'm wrong about that ?  And if I am wrong about that then
> > an explanation of why my suppositions are wrong ought to go in the
> > commit message.
> > 
> > Secondly, there is no justification there for the change in error
> > status.
> > 
> > Why is this change needed ?  (What goes wrong if it is omitted ?)
> > That is what the commit message ought to answer.
> > 
> > Plus, given that it stubs out a function to make it into a no-op, that
> > itself requires an explanation.  Why is it OK for this function which
> > is supposed to do a thing, to in fact not do anything at all and
> > return successfully saying "yes I did that" ?
> > 
> > I think (having read the thread) that I know the answers to these
> > questions but it needs to be clearly and explicitly written down.
> > 
> > > I saw your change in CODING_STYLE and I understand the request.
> > > I will try to see if we can handle this change before the feature freeze.
> > 
> > Thanks.  I doubt that this will be hard.  I am more worried about the
> > commit message.
> > 
> > Indeed, since we haven't had the rationale for this change explicitly
> > written down, there is a risk that when we do so, we will discover
> > some problem with the approach that we had previously overlooked.
> > 
> > Discovering that kind of thing is one reason to explicitly write down
> > why we are doing what we are doing, but this situation does mean we
> > shouldn't feel we've yet achieved confidence that this patch is right.
> 
> 
> I don't think it is about performance. From a performance point of view,
> we could make as many (unneeded) hypercalls as required. It is mostly
> about minimizing unwanted changes to common libxl code. Let me explain.
> 
> 
> IO ports on ARM don't exist so all IO ports related hypercalls are going
> to fail. This is expected. Today, a failure of
> xc_domain_ioport_permission would turn into a critical failure at domain
> creation. We need to avoid this outcome; instead we want to continue
> with domain creation as normal even if xc_domain_ioport_permission
> fails. (FYI the underlying hypercall XEN_DOMCTL_ioport_permission is not
> implemented on ARM so it would return -ENOSYS.)
> 
> 
> We have a few options to achieve this goal:
> 
> 
> 1) No xc_domain_ioport_permission calls on ARM
> 
>    Use #ifdefs or similar checks in libxl_pci.c to avoid calling
>    xc_domain_ioport_permission on ARM. This could be best but it would
>    cause some churn in arch-neutral libxl code.
> 
> 
> 2) Handle xc_domain_ioport_permission errors in libxl
> 
>    Introduce checks on the return value of xc_domain_ioport_permission
>    and ignore specific errors on ARM in libxl_pci.c.
>    For instance: if (ARM && rc == -ENOSYS) continue.
> 
>    This might cause less churn than 1) but still requires a few changes
>    in arch-neutral libxl code.
> 
> 
> 3) Force XEN_DOMCTL_ioport_permission to return zero on ARM
> 
>    Force the hypercall to return success even if it did nothing.
>    Currently it returns -ENOSYS.
> 
>    This is possible but it wasn't chosen for the implementation as we
>    felt that the hypercall should reflect what was actually done
>    (nothing) and it should be userspace to handle the error. I guess
>    this could be argued either way.
> 
> 
> 4) Force xc_domain_ioport_permission to return zero on ARM
> 
>    Force xc_domain_ioport_permission to return success even if the
>    hypercall would return -ENOSYS. This way there are no changes to
>    libxl.
>    
>    This is what the patch currently implements by using  #ifdef in
>    xc_domain_ioport_permission. It could also have achieved the same
>    goal by making the implementation of xc_domain_ioport_permission
>    arch-specific, and in the ARM implementation returning 0.
> 
> 
> All options above achieve the goal of a successful domain creation with
> PCI device assigned on ARM. You might be able to think of other options
> as well. I think noone here is really set on using one option over the
> other -- as long as xc_domain_ioport_permission failures don't turn into
> domain creation failures on ARM we are good.
> 

I think having a libxl_arch_io_ports_supported helper could be the
cleaner way to do this. For x86 it will unconditionally return true,
while for Arm you could consider poking at
XEN_DOMCTL_ioport_permission and see if it returns ENOSYS or
otherwise.

I guess it's possible that in the future we allow IO ports access on
Arm guests using some kind of emulated mechanism if the need arises,
at which point the hypercall will be implemented.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Wed Oct 13 08:30:08 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 08:30:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.208075.364092 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maZdu-0000Fz-14; Wed, 13 Oct 2021 08:29:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 208075.364092; Wed, 13 Oct 2021 08:29:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maZdt-0000Fs-US; Wed, 13 Oct 2021 08:29:41 +0000
Received: by outflank-mailman (input) for mailman id 208075;
 Wed, 13 Oct 2021 08:29:40 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1maZdr-0000Fg-Ti
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 08:29:40 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1maZdq-0000C0-3K; Wed, 13 Oct 2021 08:29:38 +0000
Received: from home.octic.net ([81.187.162.82] helo=[10.0.1.193])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1maZdp-00009Y-TP; Wed, 13 Oct 2021 08:29:38 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=TUR5mrIQCU20xsWR4ffR37NEH9gV0xnjoete01zkZ1M=; b=7BVNt2ps22uTDlCaVHx/zsBy3U
	amMb0pqJo5IAh/21c2I5tgFiiEpJrY3RptLYTgz5pYoSiwCp+SEuZsAczGfon42EYc4gyYnl0co85
	Un8h0JRRrRglVRuRB1rqbp2EaDHDj++H0MVLaAClcmzFvYt0lctVih0IKFaxU4bjqleI=;
Message-ID: <75e19429-49d2-c075-acb8-797c01364771@xen.org>
Date: Wed, 13 Oct 2021 09:29:35 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.2.0
Subject: Re: [PATCH v6] xen: Expose the PMU to the guests
To: Michal Orzel <michal.orzel@arm.com>, xen-devel@lists.xenproject.org
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Jan Beulich <jbeulich@suse.com>, Stefano Stabellini
 <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 Nick Rosbrook <rosbrookn@ainfosec.com>,
 Anthony PERARD <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>,
 Christian Lindig <christian.lindig@citrix.com>, David Scott
 <dave@recoil.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 bertrand.marquis@arm.com
References: <20211013074528.1396-1-michal.orzel@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20211013074528.1396-1-michal.orzel@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Michal,

On 13/10/2021 08:45, Michal Orzel wrote:
> Add parameter vpmu to xl domain configuration syntax
> to enable the access to PMU registers by disabling
> the PMU traps(currently only for ARM).
> 
> The current status is that the PMU registers are not
> virtualized and the physical registers are directly
> accessible when this parameter is enabled. There is no
> interrupt support and Xen will not save/restore the
> register values on context switches.
> 
> According to Arm Arm, section D7.1:
> "The Performance Monitors Extension is common
> to AArch64 operation and AArch32 operation."
> That means we have an ensurance that if PMU is
> present in one exception state, it must also be
> present in the other.
> 
> Please note that this feature is experimental.
> 
> Signed-off-by: Michal Orzel <michal.orzel@arm.com>
> Signed-off-by: Julien Grall <julien@xen.org>
> Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>
> Acked-by: Anthony PERARD <anthony.perard@citrix.com>
> ---
> Changes since v5:
> -extracted from the series as other patches have been merged
> -fold ARM vPMU feature status in SUPPORT.md into existing section for x86
> -fix coding style in libxl
> Changes since v4:
> -update SUPPORT.md
> -move vpmu_is_available assignment after the secondary
> CPUs have been brought up
> -introduce masks for flags that need to be set and
> for flags that are optional
> Changes since v3:
> -fail if vpmu is set but not supported
> Changes since v2:
> -remove redundant check from x86 code
> -do not define bit position and mask separately
> Changes since v1:
> -modify vpmu parameter to be common rather than arch specific
> ---
>   SUPPORT.md                           | 12 ++++++++++--
>   docs/man/xl.cfg.5.pod.in             | 17 +++++++++++++++++
>   tools/golang/xenlight/helpers.gen.go |  6 ++++++
>   tools/golang/xenlight/types.gen.go   |  1 +
>   tools/include/libxl.h                |  6 ++++++
>   tools/libs/light/libxl_create.c      | 10 ++++++++++
>   tools/libs/light/libxl_types.idl     |  2 ++
>   tools/ocaml/libs/xc/xenctrl.ml       |  1 +
>   tools/ocaml/libs/xc/xenctrl.mli      |  1 +
>   tools/xl/xl_parse.c                  |  2 ++
>   xen/arch/arm/domain.c                | 13 ++++++++++---
>   xen/arch/arm/setup.c                 |  3 +++
>   xen/common/domain.c                  | 10 +++++++++-
>   xen/include/asm-arm/domain.h         |  1 +
>   xen/include/public/domctl.h          |  4 +++-
>   15 files changed, 82 insertions(+), 7 deletions(-)
> 
> diff --git a/SUPPORT.md b/SUPPORT.md
> index 317392d8f3..d0305abc0b 100644
> --- a/SUPPORT.md
> +++ b/SUPPORT.md
> @@ -671,11 +671,19 @@ such as KVM, Hyper-V, Bromium, and so on as guests.
>   
>   ### vPMU
>   
> -Virtual Performance Management Unit for HVM guests
> +Virtual Performance Management Unit
While I agree that "HVM guests" doesn't make any sense on Arm, you are 
not adding back for x86. So this is changing the statement support to 
both HVM and PV guest.

I don't know why only HVM guests was previously mentionned. Jan, Andrew? 
Anyway, for this patch, I think we should add...

>   
>       Status, x86: Supported, Not security supported

... add HVM here. Looking at other section, we seem to use:

Status, x86 HVM: ...

One can send a follow-up patch if we want to mention the support status 
for PV guests.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Oct 13 08:31:06 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 08:31:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.208081.364104 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maZfG-0001YZ-D5; Wed, 13 Oct 2021 08:31:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 208081.364104; Wed, 13 Oct 2021 08:31:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maZfG-0001YS-9G; Wed, 13 Oct 2021 08:31:06 +0000
Received: by outflank-mailman (input) for mailman id 208081;
 Wed, 13 Oct 2021 08:31:05 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=EFKL=PB=citrix.com=roger.pau@srs-us1.protection.inumbo.net>)
 id 1maZfF-0001YK-FO
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 08:31:05 +0000
Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 82b9d2ed-76e2-4c19-8269-c402b462519b;
 Wed, 13 Oct 2021 08:31:02 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 82b9d2ed-76e2-4c19-8269-c402b462519b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1634113862;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=WFE4KQXhonEdwZ7JWnQcSz+WrCK/8dKZUzv3EMOJXqM=;
  b=PpfkuAAxk36GsXGdwuM0J0IILAEdpBV+KKNcqwVH+yvDBkdXUrM5ODxi
   If1aWpSAmLeeQeJEq1SyqXdKoFHfYA6Z72kDE/ulx49G2lMX2azapStta
   VCfYN78MxRTuA2M5zvMggMTigJ2WlOTv0F0gArHBn17HJ39Sq+JgxGOp6
   0=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: +v8hkxJdSeLGfaT50oqAtD3/F4HOhAnemFSvPZN3hBmN512ztjungcSRFwyi5waIZrGee4eVPF
 H8EnB9p2A+K7fhlOWplcI0ATcLMiTtswN7TrmtZmn0VcG8fUVW5/FTwL9BGw1DHcAKeU1ASMPf
 AkNV+rmgdnqsmF5Tz8HlW1+nTQrroK+cCkHeKNvk/NvhkXi1a6SASkjqMeBRvJ1/Jqf3wqK/Mg
 9ddebB/ScO6A4oIz+3cB3RyMUKxWR3VjNQJPuviW+/DG6BVF3jQbvEfnAoj6UDjbWGoGAu0ohO
 DXHu+zVUUGDawWPd6Wt3Qas3
X-SBRS: 5.1
X-MesageID: 55465959
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:AY/fe6JYaNp3NUOcFE+R8JMlxSXFcZb7ZxGr2PjKsXjdYENS3zUGz
 WIbDTzQPK6PYjH8L98lb4zjpEpQuZbUm4AyGQtlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s
 q3yv/GZdJhcokcxIn5BC5C5xZVG/fjgqoHUVaiUZ0ideSc+EH140Eo6wLZg6mJVqYPR7z2l6
 IuaT/L3YDdJ6xYsWo7Dw/vewP/HlK2aVAIw5jTSV9gS1LPtvyB94KYkDbOwNxPFrrx8RYZWc
 QphIIaRpQs19z91Yj+sfy2SnkciGtY+NiDW4pZatjTLbrGvaUXe345iXMfwZ3u7hB2KhMt34
 fZSnqWJUF90MfHFs+BHWhlHRnQW0a1uoNcrIFC6uM2XiUbHb2Ht07NlC0Re0Y8wo7gtRzsUr
 LpBdW5LPkvra+GemdpXTsF2gcsuNo/zNZ43sXB81zDJS/0hRPgvRo2XuIMGgWZt16iiG979e
 vgjRx1eYy3wTAV3BnkPI5csvOW30yyXnzpw9wvO+PtfD3Lo5A573aXpMdHVUseXXsgTlUGdz
 krZ+0zpDxdcM8aQoRKE7XCEluLJhTn8Wo8ZCPu/7PECqGOUwmsfGRgHT2yRqPOyilO9c99HI
 klS8S0rxYAp71CiRNT5Wxy+oVaHswQaVt4WFPc1gCmP167V7gCxFmUCCDlbZ7QOpMIwADAny
 FKNt9foHiB09q2YT2qH8bWZpi/0PjIaRUcYbC8ZSU0e4t/soKk6lBeJRdFmeIawj9b1EDW2x
 CqYoSwWjq8Wy8UM0s2T8VnZjhq2q5POTwpz4R/YNkqM6A9jacidfZ659lHB5N5JNoPfRV6E1
 FAOltKC9ukIAdeInTaUXeQWNLiz4rCONzi0vLJ0N8B/rXL3oSflJN0OpmElTKt0DioaUTzye
 0n6mhx63aZKZCalMaZcZ9i4C9t/mMAMCu/ZfvzTa9NPZL14ewmG4DxiaCas4oz9rKQ/ufpgY
 cnDIK5AGV5fUP49lGPnGI/xxJdynnhmrV4/U6wX2PhOPVC2X3WSVaseeGWHauQ0/ctoSy2Er
 o4BaaNmJ/hZOdASgxU7E6ZPczjmzlBhXPgaTvC7kMbYfWKK/0l7WpfsLUsJIdANokisvr6gE
 ouBckFZ0kHjonbMNB+HbHtuAJu2A80j9SxnZ3R2YQ30s5TGXWpJxPxAH3fQVeN2nNGPMNYuF
 6VVEyl+KqUnpsv7F8Q1MsCm8d0KmOWDjgOSJSu1CAXTjLY7LzElDuTMJ1O1nAFXV3LfnZJn/
 9WIi1OKKbJeFl8KJJuHN5qSI6aZ4CF1dBRaBBCTfLG+uSzEreBXFsAGpqZveZ9Tck+fmmLyO
 sT/KU5wmNQharQdqbHhrauFs52oA615GE9bFHPc9rG4KW/R+W/L/GOKeL/gken1WDym9aO8S
 /9Syv2gYvQLkEwT69h3EqpxzLJ47Nzq/ucIwgNhFXTNTlKqFrI/fSXWgZgR7vVAlu1DpA+7e
 kOT4d0Ga7+HD9zoTQwKLw0/Y+XdifxNwmvO7e44KVnR7TNs+ObVSl1bOhSB0XQPLLZ8PI4/7
 /0mvcoat162hhYwa47UhSFI7WWcaHcHVvx/5J0dBYbqjCsty01DPsOAWnOnvsnXZowVYEcwI
 zKSiK7TvJhmxxLPIygpCHzA/etBnpBS6hpE+0APegaSkd3fi/5pgBAIqWYrTh5Yxwls2v5oP
 jQ5LFV8IKiD8ms6hMVHWGzwSQhNCAfApx70wloN0mbYU1OpRirGK2hkYbSB+0UQ8mR9eDlH/
 e7HlDa5AGiyJMyhjDEvXUNFquD4SY0j/wLPr8mrAsCZEsRoejHimKKvOTIFphaP7RndX6EbS
 T2GJNpNVJA=
IronPort-HdrOrdr: A9a23:zaHqXaNdq6euTMBcT1L155DYdb4zR+YMi2TDiHoedfUFSKOlfp
 6V8MjztSWVtN4QMEtQ/+xoHJPwPE80kqQFnbX5XI3SJjUO3VHIEGgM1/qG/9SNIVybygcZ79
 YeT0EcMqyBMbEZt7eD3ODQKb9Jq7PrgcPY55as854ud3AQV0gJ1XYJNu/xKDwOeOApP+tfKH
 LKjfA32QZINE5nIviTNz0gZazuttfLnJXpbVovAAMm0hCHiXeN5KThGxaV8x8CW3cXqI1Sv1
 Ttokjc3OGOovu7whjT2yv66IlXosLozp9mCNaXgsYYBz3wgkKDZZhnWZeFoDcpydvfp2oCoZ
 3pmVMNLs5z43TeciWcpgbs4RDp1HIU53rr2Taj8DDeiP28YAh/J9tKhIpffBecwVEnpstA3K
 VC2H/cn4ZLDDvb9R6NpOTgZlVPrA6ZsHAimekcgzh0So0FcoJcqoQZ4Qd8DIoAJiTn84oqed
 MeTP003MwmNG9yUkqp+lWGmLeXLzMO91a9Mwk/U/WuonprdCsT9Tpf+CQd9k1wvK7VBaM0vt
 gtn8xT5cZzp/QtHNdA7dE6MIKK41z2MGDx2V2pUCDa/YE8SjjwQs3MkfgIDN/DQu1/8HJ1ou
 WYbG9l
X-IronPort-AV: E=Sophos;i="5.85,370,1624334400"; 
   d="scan'208";a="55465959"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=CyVdUYGZUnZv+gz3b8K6CEPVnNKR0eQp8B0qavRAn1B5OIiMfvSgN6LG40wRepakhV48XvGq2VCXe/ipc9hGBSbzS51hjkocrlBzIQs8oZWopQkSxKiHtysq79aYdR5hAIL6yCX8ForabLo4UmT3SltCI6f+DR65zpFnk3G4fhTsFXbWHXL9fxHTBcZI+pg6UFUGgRSpInpaLOrpfNu+CRQE21Dd8+ttqaw3w6Sb1SwQNduk5fKw4TsvNuhUWpXc1U2qsz37Uit3a97C4GmIJYANN3q5tsl6ALUutT+nmeC9OaWoN656VYAvFcNZNweRwkdacOoUsxHPAezJVkoMXA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=4d7SnycqOTjWlfVwndMpJ36JESroADFh+e51ulQjF4M=;
 b=bIWlth3fm0ncxiQTA8KgYmA2Qtl6NLuMgoESUKWWpn+80CiKV3P8h1anlfQsweFbUORns7+DCti1ya8hvKE/ndOQ1GUjS4Ft6oyL1/NNcRrTkg98XAmHa0IC/28FP4UuC/395P33MfCgIfpEBgSsL6xhhI1HQAdtnBlc73ms4shqJc0j1d+A1fTkNMC2IDzYuP58o1uyHC41PzPjequqWKrObMLveOEk0TGBY5lQSN7Qj8XdhgT0ClgCKtw4OgtyyP/MKJiPyn3WKLv6MYf1PGcBdRz+e87OMZKNIwx8SWl2cFLVDO7fj09jHugSlbWFWHATbZIeEf71jQN7TDix6g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=4d7SnycqOTjWlfVwndMpJ36JESroADFh+e51ulQjF4M=;
 b=om1sr34AA2Dgaumjj/iq/At7TLl7F9COJWaflCWOIM/0Bpn34elS2tw8p5ir4hO2S8lU5AkfCZxFAQACjmyFxV+mpGgFahKTDv51RlB+mCX7MzriexB64D6YeDKhkPCZHywPXrnlsYLgVAedqkIqVpBou2P2zJl6nUOIJFNNIlo=
Date: Wed, 13 Oct 2021 10:30:33 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Michal Orzel <michal.orzel@arm.com>
CC: Rahul Singh <rahul.singh@arm.com>, <xen-devel@lists.xenproject.org>,
	<bertrand.marquis@arm.com>, <Andre.Przywara@arm.com>, Christian Lindig
	<christian.lindig@citrix.com>, David Scott <dave@recoil.org>, Ian Jackson
	<iwj@xenproject.org>, Wei Liu <wl@xen.org>, Andrew Cooper
	<andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>, "Jan
 Beulich" <jbeulich@suse.com>, Julien Grall <julien@xen.org>, "Stefano
 Stabellini" <sstabellini@kernel.org>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH v5 07/11] xen/domctl: Introduce XEN_DOMCTL_CDF_vpci flag
Message-ID: <YWaZKX44IOfIBtX6@MacBook-Air-de-Roger.local>
References: <cover.1633540842.git.rahul.singh@arm.com>
 <20d5b9d6a0d01a7b90711d28cbefb5701a88b438.1633540842.git.rahul.singh@arm.com>
 <YWQDguvmf/O4rDIs@MacBook-Air-de-Roger.local>
 <9217a6b8-fc53-a049-7cd3-7458b574424b@arm.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <9217a6b8-fc53-a049-7cd3-7458b574424b@arm.com>
X-ClientProxiedBy: LO4P123CA0159.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:188::20) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 06ec72f6-e908-4de0-ff5e-08d98e23bccb
X-MS-TrafficTypeDiagnostic: DM6PR03MB5322:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <DM6PR03MB5322C85C324706FDACD92AF58FB79@DM6PR03MB5322.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: OKhSwAWgwf/+tYFdbJpLoQ6TnzgkENh3UvEwrcyk+sxFyug9RqXOA+b5fgxXYcxgMnp5o8iG+DhEKwFcvbmc9c0dFr+exJYUSJnCL+hEbHGYKxiEsEHt8dfs2MAmM/R1Q3SdYc5F7e2ohDbSWbH2+PXW0oYvYpBIe6T5npuhkv5OUA3JaqxiQYbPqa57KfqsMpYcT2agGy7fy9Zv0TH5uq/cKanSIvDsP0sh8kQqOuBxxw33OK7t2Hc/cD0Mwd5zAR27U2cAymbsc5HeNMrFYmnW/pdLBtCsni0zZrbmQqUTopsB7ksomqbfUVtxyEnz2wfmPwiAk1ifCnRjOmjPBZJ5jAi3o73KlOBLJk6BpfHutiC68R5lPDGhJrs8tA17mXZuTtgVgXD6rdEbwHIq1mYXrxrvrnb8LqdVtERAgSe68TXnqVUuVI9uEUxKlUMcRhp2TkRnmDRCIv08CKN3Na9Dwe5AFEYyoxDXepwAhPlP2GhYbx0H3DKsOHKh4PLAzY2oyLnKmgzh548o94ltlDnVfd+ORN2OY6eB8OsqBxbjzq5XRsgbrHFGmhtfUdp4JNbxDhaUlgqe4JY/7SR4d1kbZMhI8S5+79Fkx4FQRbj91KLr0jbtx53tWSYpsn/3XwXjEl+kCm2k/X4Tlb6DMA==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(5660300002)(85182001)(9686003)(53546011)(6486002)(54906003)(6916009)(66476007)(82960400001)(4326008)(956004)(38100700002)(186003)(26005)(86362001)(8676002)(2906002)(6666004)(66946007)(316002)(508600001)(83380400001)(7416002)(8936002)(6496006)(66556008);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YVI3ek5hVlFocTBmOHV5MXRpRVJReFdpeFFnOXZNY1psNDhXY1dSQmV5VTlz?=
 =?utf-8?B?bXdaWkJQcnVDREthU0RSWmNiTWxsMWJtUURtc3ZxMzlHZnc1QVJxV0J5bERh?=
 =?utf-8?B?ZEtvck9nRG01WTBzRkZ6RkNMK1lPd2M1QTZuRUNTellIS1duZDN1bFZRWWpZ?=
 =?utf-8?B?MXJ1THVIUm5IbWxwTmJBMUNOeXhQOGZUM2ttK1pxdzNWcjY0MWc5OGZPMHFt?=
 =?utf-8?B?eUJQSitrT0RSeTh2RGNIRk9sZ0tKQXAzQXNOczlJa24rSHZVajRKVkJOaEhT?=
 =?utf-8?B?REdSd2hSc0g2SGlMZU0xTzc3TFd4anNKQlpXdzhjU1Y0WW1kUGJ6L2pyaUM2?=
 =?utf-8?B?U0V0WUY2cTh4ME9NdmVkVWJvWkV6bnBCbUlFa0l4ZGtwWEpUNUU0V1psbk1v?=
 =?utf-8?B?L3RZTmR0TCtBNHhqZHhNN2VnWGR2OTFKY0R5Y2NzY21Ja3E3OWYzdXAvd214?=
 =?utf-8?B?S0pGWXpIZTRIWDkxM0Q3TnI1S0EwVjA0anJaNlNqZkxZSmk0b2JOczNEVWN6?=
 =?utf-8?B?RkZBcU8wNW41bDhtbnE3Vk8wRWJ1ZVh6aFBFdUlOM1Q0YTR2czhLd0tMWlBQ?=
 =?utf-8?B?eVE4UkRrS1FSYUFtTjVzMlg5MkZBTWRlZC9pR0E2OUdKdmloZ2QxSGxwVks4?=
 =?utf-8?B?bS8yUzNGZ1BhdjlrYnpDM3RhYnkxQmk0YTlKUDBlSlUyZ3ZabGpLZGk1OHhv?=
 =?utf-8?B?b1YxRmYvSU9xTWw0RUJOai84NVIyVUJvd09VVWMyNXpYYnhQaWNtRjYrckE5?=
 =?utf-8?B?M3hFS3A2cHI0cGgwSlN6MG02Z3Y0ZTNCMXN6RE1oK3dqclRDZVdSZDhFazJj?=
 =?utf-8?B?VnoxVFJQaGs2Vmtva2JpejVMMmR5ek85V1FDcFRGdW5XV1A2RWw0Skw3WFI0?=
 =?utf-8?B?UEVJb1JwU2V3OTVlVmtFc0JEOG5UWitrM2xuMThaNmhxT3RsVUUwMWhwcmJs?=
 =?utf-8?B?Zmo4eXRxa2pDczN2LzBhMk16M1ptdXlFSUJHcDFQUVVoamlBcnA1TjJWb2VB?=
 =?utf-8?B?SEhhV2h0bkQ1bnFjaFZQNGNvVi9KVkdKRjlYWVArVFFFNzBqY3hPMkhyLzFI?=
 =?utf-8?B?NWM2SVVDTDdsai8wRFlGVExoMHJvYnB6d2h6d00xKzRTOXhBTnJwU0U5cEZC?=
 =?utf-8?B?dkNld0ZOTlNIYlBKVlFURGNaVDFKSTB4UFFZem40RjZjN2ZEU3g5UlJFcVFF?=
 =?utf-8?B?V1VHam9hS09FRG90TzFUbU9VUHh4QXVVcnk1elNjMXVaa3hISy9Hck5ZNkc3?=
 =?utf-8?B?U2tYaVZJcU84Qy9YVldpSm82cWNmUjk4ZGtYZ0phSnZqYlQ2TzBhNE9EcG1N?=
 =?utf-8?B?dWJ3T2RWRkh2VXl1NXFSbFliL3RrdjJOZklkcVgybno1R3RoQi91VGIwYVpM?=
 =?utf-8?B?ZjZxdDJWSGVZOWRwbjU1aEhady9zZUphb2krTXFLa0JvUkNpd0pac2JwWkox?=
 =?utf-8?B?aFFaZnRiWE1IcGFQMnZyM1F2bXN6d0JpZGFuK0tTYVV4K2J4aUlMYXNFc1dO?=
 =?utf-8?B?am5OWjN0RGxjTFlFMUtmZ1dXZGtiMXpoL0gxREExcjJrUnI3L2ZlZTRBRkNv?=
 =?utf-8?B?UXhZSnFlT1FpTm9TTDBGMHFYLy9VY3hWQmFxdE93QitVMCtBUnhHaHV0TFNT?=
 =?utf-8?B?NEpGKzJ2RzJsMzRXUDhSWHR2c2wzYUExcTkrSC95YlFaZTN6SW43TGxwMkQ5?=
 =?utf-8?B?Q2I1dHg0bUpkTzdEZ3FkQVVlZ0JNQm5oc1pieExNclBkMUdmQ3JrYWNaZUtD?=
 =?utf-8?Q?3miWy7uCN3QcgTviatqa2RtZD/Gu45Dq6Msfs4Q?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 06ec72f6-e908-4de0-ff5e-08d98e23bccb
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2021 08:30:39.3863
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: pOcIHwdfTWRps0LXWL3kKVt6O58gHTASNGyzLwHNfTkNd+kW8KaEMxUPiepMT+QbJ4XvOD32S/JN0KFM5HQM1w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB5322
X-OriginatorOrg: citrix.com

On Tue, Oct 12, 2021 at 12:38:35PM +0200, Michal Orzel wrote:
> Hi Roger,
> 
> On 11.10.2021 11:27, Roger Pau Monné wrote:
> > On Wed, Oct 06, 2021 at 06:40:33PM +0100, Rahul Singh wrote:
> >> Introduce XEN_DOMCTL_CDF_vpci flag to enable VPCI support in XEN.
> >> Reject the use of this new flag for x86 as VPCI is not supported for
> >> DOMU guests for x86.
> > 
> > I don't like this approach, XEN_DOMCTL_CDF_vpci should be set for x86
> > PVH dom0, like we do for any other CDF flags when Xen builds dom0.
> > 
> > Things like PVH vs PV get translated into CDF flags by create_dom0,
> > and processed normally by the sanitise_domain_config logic, vPCI
> > should be handled that way.
> > 
> > Do you think you could see about fixing this?
> > 
> > Thanks, Roger.
> > 
> 
> I have one question about this fix.
> If I set XEN_DOMCTL_CDF_vpci for dom0 pvh in create_dom0, then in
> sanitise_domain_config or arch_sanitise_domain_config I have no
> knowledge on whether I am dom0 or not. I can check if I'm PVH but not if dom0.
> This would be needed to add a warning if this flag is set but we are not dom0 pvh.
> 
> Any ideas?

I've just realized this is more wrong that I thought. vPCI is
signaled on x86 in xen_arch_domainconfig.emulation_flags, so
introducing a top level option for it without removing the arch
specific one is wrong, as then on x86 we have a duplicated option.

Then I'm also not sure whether we want to move it from
emulation_flags, it seems like the more natural place for it to live
on x86.

If we really want to make vPCI a CDF option we must deal with the
removal of XEN_X86_EMU_VPCI, or else you could introduce an arch
specific flag for vPCI on Arm.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Wed Oct 13 08:34:07 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 08:34:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.208089.364114 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maZiA-0002Eu-Qa; Wed, 13 Oct 2021 08:34:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 208089.364114; Wed, 13 Oct 2021 08:34:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maZiA-0002En-NW; Wed, 13 Oct 2021 08:34:06 +0000
Received: by outflank-mailman (input) for mailman id 208089;
 Wed, 13 Oct 2021 08:34:05 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=K823=PB=arm.com=michal.orzel@srs-us1.protection.inumbo.net>)
 id 1maZi9-0002Eh-Gp
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 08:34:05 +0000
Received: from foss.arm.com (unknown [217.140.110.172])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTP
 id 526148ef-2c00-11ec-8165-12813bfff9fa;
 Wed, 13 Oct 2021 08:34:03 +0000 (UTC)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 431D71FB;
 Wed, 13 Oct 2021 01:34:03 -0700 (PDT)
Received: from [10.57.25.166] (unknown [10.57.25.166])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 9A51F3F66F;
 Wed, 13 Oct 2021 01:34:00 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 526148ef-2c00-11ec-8165-12813bfff9fa
Subject: Re: [PATCH v6] xen: Expose the PMU to the guests
To: Julien Grall <julien@xen.org>, xen-devel@lists.xenproject.org
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Jan Beulich <jbeulich@suse.com>, Stefano Stabellini
 <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 Nick Rosbrook <rosbrookn@ainfosec.com>,
 Anthony PERARD <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>,
 Christian Lindig <christian.lindig@citrix.com>, David Scott
 <dave@recoil.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 bertrand.marquis@arm.com
References: <20211013074528.1396-1-michal.orzel@arm.com>
 <75e19429-49d2-c075-acb8-797c01364771@xen.org>
From: Michal Orzel <michal.orzel@arm.com>
Message-ID: <a0618ea7-3c66-bfca-20fb-62855c8791e4@arm.com>
Date: Wed, 13 Oct 2021 10:33:48 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <75e19429-49d2-c075-acb8-797c01364771@xen.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit



On 13.10.2021 10:29, Julien Grall wrote:
> Hi Michal,
> 
> On 13/10/2021 08:45, Michal Orzel wrote:
>> Add parameter vpmu to xl domain configuration syntax
>> to enable the access to PMU registers by disabling
>> the PMU traps(currently only for ARM).
>>
>> The current status is that the PMU registers are not
>> virtualized and the physical registers are directly
>> accessible when this parameter is enabled. There is no
>> interrupt support and Xen will not save/restore the
>> register values on context switches.
>>
>> According to Arm Arm, section D7.1:
>> "The Performance Monitors Extension is common
>> to AArch64 operation and AArch32 operation."
>> That means we have an ensurance that if PMU is
>> present in one exception state, it must also be
>> present in the other.
>>
>> Please note that this feature is experimental.
>>
>> Signed-off-by: Michal Orzel <michal.orzel@arm.com>
>> Signed-off-by: Julien Grall <julien@xen.org>
>> Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>
>> Acked-by: Anthony PERARD <anthony.perard@citrix.com>
>> ---
>> Changes since v5:
>> -extracted from the series as other patches have been merged
>> -fold ARM vPMU feature status in SUPPORT.md into existing section for x86
>> -fix coding style in libxl
>> Changes since v4:
>> -update SUPPORT.md
>> -move vpmu_is_available assignment after the secondary
>> CPUs have been brought up
>> -introduce masks for flags that need to be set and
>> for flags that are optional
>> Changes since v3:
>> -fail if vpmu is set but not supported
>> Changes since v2:
>> -remove redundant check from x86 code
>> -do not define bit position and mask separately
>> Changes since v1:
>> -modify vpmu parameter to be common rather than arch specific
>> ---
>>   SUPPORT.md                           | 12 ++++++++++--
>>   docs/man/xl.cfg.5.pod.in             | 17 +++++++++++++++++
>>   tools/golang/xenlight/helpers.gen.go |  6 ++++++
>>   tools/golang/xenlight/types.gen.go   |  1 +
>>   tools/include/libxl.h                |  6 ++++++
>>   tools/libs/light/libxl_create.c      | 10 ++++++++++
>>   tools/libs/light/libxl_types.idl     |  2 ++
>>   tools/ocaml/libs/xc/xenctrl.ml       |  1 +
>>   tools/ocaml/libs/xc/xenctrl.mli      |  1 +
>>   tools/xl/xl_parse.c                  |  2 ++
>>   xen/arch/arm/domain.c                | 13 ++++++++++---
>>   xen/arch/arm/setup.c                 |  3 +++
>>   xen/common/domain.c                  | 10 +++++++++-
>>   xen/include/asm-arm/domain.h         |  1 +
>>   xen/include/public/domctl.h          |  4 +++-
>>   15 files changed, 82 insertions(+), 7 deletions(-)
>>
>> diff --git a/SUPPORT.md b/SUPPORT.md
>> index 317392d8f3..d0305abc0b 100644
>> --- a/SUPPORT.md
>> +++ b/SUPPORT.md
>> @@ -671,11 +671,19 @@ such as KVM, Hyper-V, Bromium, and so on as guests.
>>     ### vPMU
>>   -Virtual Performance Management Unit for HVM guests
>> +Virtual Performance Management Unit
> While I agree that "HVM guests" doesn't make any sense on Arm, you are not adding back for x86. So this is changing the statement support to both HVM and PV guest.
> 
> I don't know why only HVM guests was previously mentionned. Jan, Andrew? Anyway, for this patch, I think we should add...
> 
>>         Status, x86: Supported, Not security supported
> 
> ... add HVM here. Looking at other section, we seem to use:
> 
> Status, x86 HVM: ...
> 
> One can send a follow-up patch if we want to mention the support status for PV guests.
> 
> Cheers,
> 
Ok so it is the matter of adding "HVM" word into status for x86.
Is this something that can be done while committing?

Cheers,
Michal


From xen-devel-bounces@lists.xenproject.org Wed Oct 13 08:46:08 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 08:46:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.208097.364126 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maZtg-0003kJ-Uj; Wed, 13 Oct 2021 08:46:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 208097.364126; Wed, 13 Oct 2021 08:46:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maZtg-0003kC-RZ; Wed, 13 Oct 2021 08:46:00 +0000
Received: by outflank-mailman (input) for mailman id 208097;
 Wed, 13 Oct 2021 08:46:00 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=EFKL=PB=citrix.com=roger.pau@srs-us1.protection.inumbo.net>)
 id 1maZtf-0003k6-UD
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 08:45:59 +0000
Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id fbf7c2e2-2c01-11ec-8166-12813bfff9fa;
 Wed, 13 Oct 2021 08:45:58 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fbf7c2e2-2c01-11ec-8166-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1634114758;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=dfM0d+SNGqxSr3+c7gcrj/6BZNYcfAzXzRyROroyBNg=;
  b=EBGcWrOvMrnLDWfaQEGF0KYfYXCS18pCbkh8ruUWc/4fSqeOkIA8C4vB
   U0IamnKEtbry/DxsojnIelyNQYHlWUk9dznHp0NLGW0b5vxIkxCXkSz4z
   1g25othT+7mwwCexfNe08mzsqE3+ZKaiu3TrZ2f1UUNS/3a2HFnkPEpNu
   s=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: ja8r+H3BacIvJs3drW2WRb75Q5DeosQ/HLLiH84WbzOFi954djHRD7aRjGTEKrGvYvkt2mhZMs
 E46ARktmcSrlkH+K+3RXgz0x0Oldt84PBWhtVsNgHAmG9/RJ/nfWhWX9deqqEHk62e/FOcfsCM
 fxViE9jmWi3168Ucq9n9LA1/WwyIk+snS2r+owPQHYW17h/vYEGJD6ROnq3cXOice4xiZVuT7X
 RqznJVxPN7cnvodHV1PmYS3IGQvIosu1nVKPgVIPrbiz7roDlSSpWq6U46fzkrURWYcGy+IfIs
 xTuYlWw5vO3Ne3Llov09eClN
X-SBRS: 5.1
X-MesageID: 55466789
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:adMU/a0vXw9UKXYeqfbD5d13kn2cJEfYwER7XKvMYLTBsI5bpzwEy
 mIbXjrQOveONzDwctl+bNuz9hgC7cXWmNY1TVFupC1hF35El5HIVI+TRqvS04J+DSFhoGZPt
 Zh2hgzodZhsJpPkS5PE3oHJ9RGQ74nRLlbHILOCan0ZqTNMEn970Es7wrVh2+aEvPDia++zk
 YKqyyHgEAfNNw5cagr4PIra9XuDFNyr0N8plgRWicJj5TcypFFMZH4rHomjLmOQf2VhNrXSq
 9Avbl2O1jixEx8FUrtJm1tgG6EAaua60QOm0hK6V0U+6/TrS+NbPqsTbZIhhUlrZzqhk4xwk
 IpBsaCKdCgEMoH+w8kwQ0kEOnQrVUFG0OevzXmXtMWSywvNcmf2wuUoB0YzVWEa0r8pWycUr
 6VecW1TKEDY7w616OvTpu1EnMMsIdOtJIoCknph0SvYHbAtRpWrr6DiuIIEgmlv1pEm8fD2a
 OtaRRxyayT7bjJSKG8JS80FgNm6iSyqG9FfgA3M/vdmi4TJ9yRwz7rFINfTYsaNR8heggCfv
 G2u11r+BhYWJdmO0w2v+3inhvLMtS7jUYdUH7q9ntZoilCOwm0YCDUNSEC25/K+jyaWQ9tCL
 2QE9yxoqrI9nGS0SvHtUhv+p2SL1jYeRt5RHusS+AyLjK3O7G6xFmUCCzJMdtEinMs3XiAxk
 E+EmcvzAj5iu6HTTmiSnp+OpDOvPW4OLGkNZQcNVw5D6N7myKk5gwjTVN9lHOiwh8fsBDDr6
 zmQqW41gLB7pdUQy6yx8FTDgjStjpvEVAg44kPQRG3Nxip/aJSoIbSy+0nE5OxJBI+DSx+Ku
 31spiSFxLlQV9fXznXLGbhTWuHyjxqYDNHCqVIzHsF++zCRwUOMUIx80mpTCVc5bu9RLFcFf
 3TvkQ9W4ZZSOl6jYql2f5+9BqwW8ETwKTj2fquLNoQWM/CdYCfCpXs0PRfBgAgBhWB1yflnU
 ap3Z/pAGprz5U5P9zGxW/sGmYEiwiQz1As/rriqkkz5j9JyiJOTIIrp0WdijMhlsstoQy2Pq
 r6z0vdmLT0ED4UShQGNoOYuwagidyRTOHwPg5U/mhS/CgRnAno9LPTa3KksfYdo94wMyLyUp
 i/hABcClAGj7ZEiFelsQis8AF8IdcwuxU/XwAR2ZQr4s5TdSdfHAFgjm2sfIuB8qb0LIQ9cR
 PgZYcSQasmjuRyckwnxmaLV9dQ4HDzy3FrmF3P8PFAXIs4xLySUq4SMVla+q0Ez4t+f6JJWT
 0uIjViAH/Luhm1KUa7rVR5Y5wrp5yZCw7guAxKgzxs6UByEzbWG4hfZ15cfC8oNNQ/C1n2d0
 QOXCg0fvu7Dv8k+99yhuExOh9zB/zJWEhUIEm/Fw6yxMCWGrGOvzZUZCLSDfCzHVXOy86KnP
 L0Hw/b5OfwBvVBLr4sjTOo7kfNgv4Pi9+1A0wBpPHTXdFD3WLluFWaLgJtUvapXy74H5QbvA
 hCT+sNXMKmiMd/+FAJDPxIsa+mOjKlGmjTb4fkvDl/94St7oOiOXUlIZkHegy1BNrpldogix
 L556sIR7gW+jDssM8qH0X8IpzjdcCRYXvx+5J8AAYLthg468X14YMTRWn3s/ZWCS9RQKU12c
 DWas7XP2uZHzU3YfnttSXWUhbhBhY4DsQxhxUMZIwjbgcLMg/I60UED8TkzSQgJnBxL3/gqZ
 zpuPkxxY66P4y1plI5IWGX1Q1NNAxiQ+0rQzVoVlTKGExn0BzKVdGBta/yQ+E058n5HemkJ9
 b6V/2/pTDL2cZyjxSA1Q0Nk96TuQNEZGtcuQyx78xBpx6UHXAc=
IronPort-HdrOrdr: A9a23:1bfc+qEuxJ803n8spLqFe5HXdLJyesId70hD6qkvc3Jom52j+P
 xGws526faVslYssHFJo6HnBEClewKgyXcT2/hsAV7CZnidhILMFuBfBOTZsljd8kHFh4pgPO
 JbAtdD4b7LfChHZKTBkXGF+r8bqbHtms3Y5pa9vgRQpENRGtpdBm9Ce3em+yZNNXB77PQCZf
 2hDp0tnUvfRZ1bVLX2OlA1G8z44/HbnpPvZhALQzYh9Qm1lDutrJr3CQKR0BsyWy5Ghe5Kyx
 mKryXJooGY992rwB7V0GHeq7xQhdva09NGQOiBkNIcJDnAghuhIK5hR7qBljYop/zH0idkrP
 D85zMbe+hj4XLYeW+45TPrxgnbyT4rr0TvzFeJ6EGT6vDRdXYfMY5slIhZehzW5w4Lp9dnyp
 9G2Gqfqt5+EQ7AtD6V3amKazha0m6P5VYym+8aiHJSFaEEbqVKkIAZ9ERJVL8dASPB7pw9Gu
 UGNrCd2B9vSyLeU5nlhBgq/DT1NU5DWStuA3Jy+/B96gIm3kyQlCAjtYoidnRpzuN0d3AL3Z
 WcDkzE/Is+OfP+VpgNcdvpd/HHQ1AlcSi8Ql56Hm6XYJ3vG0i94aIfs49Fqd1DRvQzve0Pcd
 L6IQtliVI=
X-IronPort-AV: E=Sophos;i="5.85,370,1624334400"; 
   d="scan'208";a="55466789"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=hMxc7zXInWWlD0Vz0tTh8SYl8pQhqiE5girif0XsqUSR+33k2MM5xOCoVWCw83WYuTyPov5+dAvxPnfTYAlwJMuRPPpQqi0AusQqO2q1Z2uZsrt4NbsaFwgQO8G9tQH+SEpao3AACUECtFFfAW5KT8zJNzzWqfpdO6I05OBHBUnB/fJLWe3kXnycXMK6O56GSrNiz+7lyRROVeEwX1Xd0/IF5AHYLlL/BqwjDp1vhFdYLLJ7JfK7KXIJMJzzDlcTZ37p+SvRxL6S246tSFTMWrQMCtaK7sRnUIn6z+ywM9DZQk7j+zN9ID/nXTIbBwnpl1ZZUMWsZRSKu9JSqdi8Cg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=vUMhzYqbOOMsmZJ3Q4tne0O0Ea6RvZswLzLM+SzuoBU=;
 b=hxFLXNXg612NRGSc7ufsQO8OStvETCmjJAuSgl70oNMchiNIrYErcHauLk6xoReNqG9PhaOqdDHMnRBOxBbryFxgxTUdmMbAn1ocD0tGS8XRgcxyIiekQoYzyk1t+vXTdZ43qo8IFVuw1DYG8j+tFHa2wf6YYLuxrONJ7hGi4QyfboUSPMLw9C3RekInAvj481mPZE/A5INC8WA8d7y79SUjLOmK4CtI8QvfXl7DBKgEQ2vF5R8RiNMgn3BC+uBdFfS+c1OS5J+9gJSihDqHyv1EAflFmg5vwzCXTY/CndxmcnF1uqCLgyysGVWpNv5EcqL76YKyIHgTy1Ad+zKFag==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=vUMhzYqbOOMsmZJ3Q4tne0O0Ea6RvZswLzLM+SzuoBU=;
 b=Hk2gm+RFypXDv6xgAVbV4NcpdGgkND+o/JX+jSg3FcqONYoJwWqdEqeCO3uACi2mg5QUo+fGzUXRTceqQqsXkR1qeWfuknaikamW7t4n3wi3cDS0Uigkp8KCWon7iSRn2Sl2TAKvi25hJpChlUJyq2hc5EnQvK1N0UjkTd6qBRQ=
Date: Wed, 13 Oct 2021 10:45:23 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Rahul Singh <rahul.singh@arm.com>
CC: <xen-devel@lists.xenproject.org>, <bertrand.marquis@arm.com>,
	<Andre.Przywara@arm.com>, Stefano Stabellini <sstabellini@kernel.org>,
	"Julien Grall" <julien@xen.org>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
	Jan Beulich <jbeulich@suse.com>, Wei Liu <wl@xen.org>, Paul Durrant
	<paul@xen.org>
Subject: Re: [PATCH v5 08/11] xen/arm: Enable the existing x86 virtual PCI
 support for ARM.
Message-ID: <YWaco/UvA4xFE1xW@MacBook-Air-de-Roger.local>
References: <cover.1633540842.git.rahul.singh@arm.com>
 <9bdca2cda5d2e83f94dc2423e55714273539760a.1633540842.git.rahul.singh@arm.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <9bdca2cda5d2e83f94dc2423e55714273539760a.1633540842.git.rahul.singh@arm.com>
X-ClientProxiedBy: LO4P123CA0307.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:197::6) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 5f8c7d6a-d554-43be-fd68-08d98e25cf6b
X-MS-TrafficTypeDiagnostic: DM6PR03MB5082:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <DM6PR03MB5082292934AA678A2AF0F5A78FB79@DM6PR03MB5082.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: gRn9qbuW7xQW4Y8/I1qrogHqYOKu/h9Ox5ABQ7qte8znkspo/lMhv3lkcE+k8t6IYBEKNFOLHpv/CP+4IczroHnQVzzg4UNSrGefH/PoDinYfx7WsbWL8zXtErJx8nivWRsVeig/RD1aM1oMU7Nl9mnVTxh3+RH4sdCgl77bUK3+dfP09ouXIzqy1FmB5b0OzBbQAYWarfYuTxXVQkcHrXJwD6Ew7mTxqxmHOBoaDA77iqPJWR3StBSkKtp+JqV0/Onic5GTBHfjlfURlwvzfWcp9Nx/BZlBSKPH1FNu7D+auv7EzK+THxEjpO/MrRLCEQZ49vKd8MP8w1MdP4xRhmpVuGdC6L61Ji/1yg/I69ce56ykQX1Tj5fnUlJV+SB58ahi+HPGpKafKN647+IoNNM6bJ1CE1XCRgGExHCK8QUzqAsd0mufK0w7x7IHDSQzXTrpuvr9T93krpRi4hDtYFujAXYm1o04q1aQeEKtolIZpcMpRKzQaffLeEZ3NRymSwRArsQuyAV/jhDTmFJKk63PUVWJUCXU1Psv1Wm1E+cL0Q6hpd03kL5IKNzLuicxbt/iH+AVVyvBRzM7jmLRPv9mue5VIwZ0cf4cJXSrCotYJxPPYYYjI3CckCnWEbpMA0R/5+vgr5eNUJADJBUse/u1VpWZy/C9G1caZefoQ2rHFyDvG0GroZG8ZxevM+q9gW1OidZVqBB705c6MURIHg==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(5660300002)(956004)(6916009)(85182001)(8936002)(2906002)(6496006)(66946007)(8676002)(4326008)(82960400001)(66556008)(86362001)(66476007)(38100700002)(6486002)(7416002)(54906003)(83380400001)(316002)(186003)(6666004)(26005)(9686003)(508600001)(2004002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OUJFbVRCY1FVSm1XSndodWF3aytzYjhaa1VJL3hPQmVZQVlBMHJLMjRON3M3?=
 =?utf-8?B?WkR5VlVTSHNZSU5jNEVwUno5RnY0TW1RbTZJczcxdnQvRlhsZjVDVWxVcHlD?=
 =?utf-8?B?TlBBK2RGNWZYZW9Ydyt3ZTJmaHdRbS9IUzhWOFNkbVR4RE9EdWF6QjVQamVD?=
 =?utf-8?B?dnVzcnpXQmhYU3ZjdENBek5oYkpyZUtuSTY5dUxKM1AvVHlQQnNrbHdoU2xi?=
 =?utf-8?B?aGZqcTUxc2IyY0JPVmx4Vzc4c0RxMkNQaklvRXkrd0tTT3lDREordGtkeUNN?=
 =?utf-8?B?OEdpc1ptbjVqZkNsTENOTi9KQkhHTC9ib2VpWVlDeURpVW9MdTArclRVYUFr?=
 =?utf-8?B?RGtacXZGT1JMQStsRGJ5cDBkMGlIVnB6ZXE4Z05UWkhuUjVtOUhEbmZmdUlF?=
 =?utf-8?B?MTNFVEI0VTgrZ3VadCtHcm9Xa0hMT2Q2V0l1RnhmSW8rNmNlbWsrMUNwZGRK?=
 =?utf-8?B?REhvMy94MG9RRDZLMjJWUmcrWHg3OGhJTEM2aFFrYk16ZUhmRFRYdFlXTzlB?=
 =?utf-8?B?SkJzcDBoblVYYUtrTXRJaXlsRUt0eHJIL2tjRmdUUDRWTTFIMmJZeXlsZXRB?=
 =?utf-8?B?OFNxbXc0R0hhYkVMV2hsVWpaMEI1eFhiT2c4VHU0ZlkvMDdKWDhyYWR5Slgw?=
 =?utf-8?B?NnE3VTkyUVdqby9qVVhNenJOa2s2VHdoS0xvS2xFSFI3QlBVSUpBZFBoeU5D?=
 =?utf-8?B?RkYyR0VFNHd5eGdSck14V1FHN3lzWEhjMkFvdElvbjA4QkhYMysrQUhUbElP?=
 =?utf-8?B?UVQxMzIrMndFdERQUEd4QzlwMEdTVEcyUlJ0c2dwZ1N1cmI0eldUL05HelV2?=
 =?utf-8?B?UUhIWEJBa2NkeG8rT0xjcUpBM2lVOEZXZDdDa28vamk1b3pCSzhDcy9qOHdB?=
 =?utf-8?B?V2d2VUxDTDZnaGs2UTJMTnlNQzZpS2d1QVBMQzJzT0NtZHdqS2kxWDAvMlZQ?=
 =?utf-8?B?RHBPYmJQMWppZ1B3b1ZtN3JpRUFhTGpNanhkR2EzSHo4WitkNlUvREMwREZ2?=
 =?utf-8?B?Y3VYRVlCNHhIL3o4L2tEU29XRDVzT012SUwxR2pJM0lpRVNyTTFTV3pVaHdm?=
 =?utf-8?B?U2c3SnhDK0ZhUzA3UUdZYzUzQjh1d3k3VXpwYUN4UEx0YWNsK3FDQldyU2p0?=
 =?utf-8?B?YUFMUnEyY1RPcEowYzRyYWZSNC9mUGhVdm9LUHhmQ0xOdm9TN0locFE5a2Rl?=
 =?utf-8?B?M05ibFZTSkFXYkJUcGErWm55aWVvWTZUb3AxeDNwRGpqZ2g1RWwvdS9OSHJJ?=
 =?utf-8?B?ODVXeGcrc0ZGTkczblZUN1JDTzYxN055bmVjUlBXekl1b1phMXNYY0YxZHFt?=
 =?utf-8?B?Nm9aRFBmcGNSVk9HRlFaV01idXppdWZHRXR6cnZrWlY4RGhDQ2dweEF2Tytu?=
 =?utf-8?B?eGxFTklVOGRjaEFJNnNRdVVCNVg1UFd0N3hwL0V3RlVEOVluT1VGVVNXc3c5?=
 =?utf-8?B?NW5FQnVFTEFxOWZNMkUwNS9ZNi9HQ21LZzVjL2RMUWc5OVZuMk9icHRFbDk4?=
 =?utf-8?B?d1hESUhSejRnckN2S1k1RTlDcnpNNkJQcEFhVUhXL1hoK1lWajg5REIzVENL?=
 =?utf-8?B?QTdkaEhITStLQXRKOHd2c1k0Z015V3NkZUY0dmRlM3MzaGxuTUF3M3JTNHQ0?=
 =?utf-8?B?YU5DdENnN1BnVWZXRGFlSFc3bjdvQUJnQzEvQ2dMWGdOdEU4RXgrSy9nNnJ0?=
 =?utf-8?B?bExNZkpQeVpOa2RRSmV6cFdxbWI2Um00ZW01NGp4NmpvUWo1d1F1Mk9JTkx2?=
 =?utf-8?Q?eqC2DiUAholvudhbpbdLjbRn3hrOcOOjSa3B9QA?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 5f8c7d6a-d554-43be-fd68-08d98e25cf6b
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2021 08:45:29.5606
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1Joyt8gqTY/vDbsYeaxASA5BKWc7QO4iMY7WcCB8KA5y/Gm9q/aRBcrJLNS9skcPUmCJID3Na5KsOPp2J5l1Sw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB5082
X-OriginatorOrg: citrix.com

On Wed, Oct 06, 2021 at 06:40:34PM +0100, Rahul Singh wrote:
> The existing VPCI support available for X86 is adapted for Arm.
> When the device is added to XEN via the hyper call
> “PHYSDEVOP_pci_device_add”, VPCI handler for the config space
> access is added to the Xen to emulate the PCI devices config space.
> 
> A MMIO trap handler for the PCI ECAM space is registered in XEN
> so that when guest is trying to access the PCI config space,XEN
> will trap the access and emulate read/write using the VPCI and
> not the real PCI hardware.
> 
> For Dom0less systems scan_pci_devices() would be used to discover the
> PCI device in XEN and VPCI handler will be added during XEN boots.
> 
> Signed-off-by: Rahul Singh <rahul.singh@arm.com>
> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
> ---
> Change in v5:
> - Add pci_cleanup_msi(pdev) in cleanup part.
> - Added Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
> Change in v4:
> - Move addition of XEN_DOMCTL_CDF_vpci flag to separate patch
> Change in v3:
> - Use is_pci_passthrough_enabled() in place of pci_passthrough_enabled variable
> - Reject XEN_DOMCTL_CDF_vpci for x86 in arch_sanitise_domain_config()
> - Remove IS_ENABLED(CONFIG_HAS_VPCI) from has_vpci()
> Change in v2:
> - Add new XEN_DOMCTL_CDF_vpci flag
> - modify has_vpci() to include XEN_DOMCTL_CDF_vpci
> - enable vpci support when pci-passthough option is enabled.
> ---
> ---
>  xen/arch/arm/Makefile         |   1 +
>  xen/arch/arm/domain.c         |   4 ++
>  xen/arch/arm/domain_build.c   |   3 +
>  xen/arch/arm/vpci.c           | 102 ++++++++++++++++++++++++++++++++++
>  xen/arch/arm/vpci.h           |  36 ++++++++++++
>  xen/drivers/passthrough/pci.c |  18 ++++++
>  xen/include/asm-arm/domain.h  |   7 ++-
>  xen/include/asm-x86/pci.h     |   2 -
>  xen/include/public/arch-arm.h |   7 +++
>  xen/include/xen/pci.h         |   2 +
>  10 files changed, 179 insertions(+), 3 deletions(-)
>  create mode 100644 xen/arch/arm/vpci.c
>  create mode 100644 xen/arch/arm/vpci.h
> 
> diff --git a/xen/arch/arm/Makefile b/xen/arch/arm/Makefile
> index 44d7cc81fa..fb9c976ea2 100644
> --- a/xen/arch/arm/Makefile
> +++ b/xen/arch/arm/Makefile
> @@ -7,6 +7,7 @@ ifneq ($(CONFIG_NO_PLAT),y)
>  obj-y += platforms/
>  endif
>  obj-$(CONFIG_TEE) += tee/
> +obj-$(CONFIG_HAS_VPCI) += vpci.o
>  
>  obj-$(CONFIG_HAS_ALTERNATIVE) += alternative.o
>  obj-y += bootfdt.init.o
> diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
> index 36138c1b2e..fbb52f78f1 100644
> --- a/xen/arch/arm/domain.c
> +++ b/xen/arch/arm/domain.c
> @@ -39,6 +39,7 @@
>  #include <asm/vgic.h>
>  #include <asm/vtimer.h>
>  
> +#include "vpci.h"
>  #include "vuart.h"
>  
>  DEFINE_PER_CPU(struct vcpu *, curr_vcpu);
> @@ -767,6 +768,9 @@ int arch_domain_create(struct domain *d,
>      if ( is_hardware_domain(d) && (rc = domain_vuart_init(d)) )
>          goto fail;
>  
> +    if ( (rc = domain_vpci_init(d)) != 0 )
> +        goto fail;
> +
>      return 0;
>  
>  fail:
> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
> index c5afbe2e05..f4c89bde8c 100644
> --- a/xen/arch/arm/domain_build.c
> +++ b/xen/arch/arm/domain_build.c
> @@ -3053,6 +3053,9 @@ void __init create_dom0(void)
>      if ( iommu_enabled )
>          dom0_cfg.flags |= XEN_DOMCTL_CDF_iommu;
>  
> +    if ( is_pci_passthrough_enabled() )
> +        dom0_cfg.flags |= XEN_DOMCTL_CDF_vpci;
> +
>      dom0 = domain_create(0, &dom0_cfg, true);
>      if ( IS_ERR(dom0) || (alloc_dom0_vcpu0(dom0) == NULL) )
>          panic("Error creating domain 0\n");
> diff --git a/xen/arch/arm/vpci.c b/xen/arch/arm/vpci.c
> new file mode 100644
> index 0000000000..76c12b9281
> --- /dev/null
> +++ b/xen/arch/arm/vpci.c
> @@ -0,0 +1,102 @@
> +/*
> + * xen/arch/arm/vpci.c
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; either version 2 of the License, or
> + * (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + */
> +#include <xen/sched.h>
> +
> +#include <asm/mmio.h>
> +
> +#define REGISTER_OFFSET(addr)  ( (addr) & 0x00000fff)
> +
> +/* Do some sanity checks. */
> +static bool vpci_mmio_access_allowed(unsigned int reg, unsigned int len)
> +{
> +    /* Check access size. */
> +    if ( len > 8 )
> +        return false;
> +
> +    /* Check that access is size aligned. */
> +    if ( (reg & (len - 1)) )
> +        return false;
> +
> +    return true;
> +}
> +
> +static int vpci_mmio_read(struct vcpu *v, mmio_info_t *info,
> +                          register_t *r, void *p)
> +{
> +    unsigned int reg;
> +    pci_sbdf_t sbdf;
> +    unsigned long data = ~0UL;
> +    unsigned int size = 1U << info->dabt.size;
> +
> +    sbdf.sbdf = MMCFG_BDF(info->gpa);
> +    reg = REGISTER_OFFSET(info->gpa);
> +
> +    if ( !vpci_mmio_access_allowed(reg, size) )
> +        return 0;
> +
> +    data = vpci_read(sbdf, reg, min(4u, size));
> +    if ( size == 8 )
> +        data |= (uint64_t)vpci_read(sbdf, reg + 4, 4) << 32;
> +
> +    *r = data;
> +
> +    return 1;
> +}
> +
> +static int vpci_mmio_write(struct vcpu *v, mmio_info_t *info,
> +                           register_t r, void *p)
> +{
> +    unsigned int reg;
> +    pci_sbdf_t sbdf;
> +    unsigned long data = r;
> +    unsigned int size = 1U << info->dabt.size;
> +
> +    sbdf.sbdf = MMCFG_BDF(info->gpa);
> +    reg = REGISTER_OFFSET(info->gpa);
> +
> +    if ( !vpci_mmio_access_allowed(reg, size) )
> +        return 0;
> +
> +    vpci_write(sbdf, reg, min(4u, size), data);
> +    if ( size == 8 )
> +        vpci_write(sbdf, reg + 4, 4, data >> 32);

I think those two helpers (and vpci_mmio_access_allowed) are very
similar to the existing x86 ones (see vpci_mmcfg_{read,write}), up to
the point where I would consider moving the shared code to vpci.c as
vpci_ecam_{read,write} and call them from the arch specific trap
handlers.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Wed Oct 13 08:52:53 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 08:52:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.208109.364136 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maa0H-0005F4-Pq; Wed, 13 Oct 2021 08:52:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 208109.364136; Wed, 13 Oct 2021 08:52:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maa0H-0005Ex-Lw; Wed, 13 Oct 2021 08:52:49 +0000
Received: by outflank-mailman (input) for mailman id 208109;
 Wed, 13 Oct 2021 08:52:48 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=h1Wz=PB=pengutronix.de=ukl@srs-us1.protection.inumbo.net>)
 id 1maa0G-0005Eo-Ij
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 08:52:48 +0000
Received: from metis.ext.pengutronix.de (unknown
 [2001:67c:670:201:290:27ff:fe1d:cc33])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 7fb6a7e0-8b15-4d0a-b02d-75264d0a01b6;
 Wed, 13 Oct 2021 08:52:46 +0000 (UTC)
Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2])
 by metis.ext.pengutronix.de with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92)
 (envelope-from <ukl@pengutronix.de>)
 id 1maZzE-0007An-3c; Wed, 13 Oct 2021 10:51:44 +0200
Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de)
 by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.92)
 (envelope-from <ukl@pengutronix.de>)
 id 1maZz1-0005Il-VI; Wed, 13 Oct 2021 10:51:31 +0200
Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.92)
 (envelope-from <ukl@pengutronix.de>)
 id 1maZz1-0006zY-R9; Wed, 13 Oct 2021 10:51:31 +0200
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7fb6a7e0-8b15-4d0a-b02d-75264d0a01b6
Date: Wed, 13 Oct 2021 10:51:31 +0200
From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Giovanni Cabiddu <giovanni.cabiddu@intel.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Sathya Prakash <sathya.prakash@broadcom.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	linux-pci@vger.kernel.org, Alexander Duyck <alexanderduyck@fb.com>,
	Russell Currey <ruscur@russell.cc>, x86@kernel.org,
	qat-linux@intel.com, oss-drivers@corigine.com,
	Oliver O'Halloran <oohall@gmail.com>,
	"H. Peter Anvin" <hpa@zytor.com>, Jiri Olsa <jolsa@redhat.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Marco Chiappero <marco.chiappero@intel.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	linux-scsi@vger.kernel.org, Michael Ellerman <mpe@ellerman.id.au>,
	=?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= <zajec5@gmail.com>,
	Jesse Brandeburg <jesse.brandeburg@intel.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	linux-wireless@vger.kernel.org, Jakub Kicinski <kuba@kernel.org>,
	Yisen Zhuang <yisen.zhuang@huawei.com>,
	Suganath Prabu Subramani <suganath-prabu.subramani@broadcom.com>,
	Fiona Trahe <fiona.trahe@intel.com>,
	Andrew Donnellan <ajd@linux.ibm.com>, Arnd Bergmann <arnd@arndb.de>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Ido Schimmel <idosch@nvidia.com>,
	Simon Horman <simon.horman@corigine.com>,
	linuxppc-dev@lists.ozlabs.org,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Jack Xu <jack.xu@intel.com>, Borislav Petkov <bp@alien8.de>,
	Michael Buesch <m@bues.ch>, Jiri Pirko <jiri@nvidia.com>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Namhyung Kim <namhyung@kernel.org>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Juergen Gross <jgross@suse.com>,
	Salil Mehta <salil.mehta@huawei.com>,
	Sreekanth Reddy <sreekanth.reddy@broadcom.com>,
	xen-devel@lists.xenproject.org, Vadym Kochan <vkochan@marvell.com>,
	MPT-FusionLinux.pdl@broadcom.com,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-usb@vger.kernel.org,
	Wojciech Ziemba <wojciech.ziemba@intel.com>,
	linux-kernel@vger.kernel.org,
	Mathias Nyman <mathias.nyman@intel.com>,
	Zhou Wang <wangzhou1@hisilicon.com>, linux-crypto@vger.kernel.org,
	kernel@pengutronix.de, netdev@vger.kernel.org,
	Frederic Barrat <fbarrat@linux.ibm.com>,
	Paul Mackerras <paulus@samba.org>,
	Tomaszx Kowalik <tomaszx.kowalik@intel.com>,
	Taras Chornyi <tchornyi@marvell.com>,
	"David S. Miller" <davem@davemloft.net>,
	linux-perf-users@vger.kernel.org
Subject: Re: [PATCH v6 00/11] PCI: Drop duplicated tracking of a pci_dev's
 bound driver
Message-ID: <20211013085131.5htnch5p6zv46mzn@pengutronix.de>
References: <20211004125935.2300113-1-u.kleine-koenig@pengutronix.de>
 <20211012233212.GA1806189@bhelgaas>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="jgo3ssjhgqy54b4n"
Content-Disposition: inline
In-Reply-To: <20211012233212.GA1806189@bhelgaas>
X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2
X-SA-Exim-Mail-From: ukl@pengutronix.de
X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false
X-PTX-Original-Recipient: xen-devel@lists.xenproject.org


--jgo3ssjhgqy54b4n
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Oct 12, 2021 at 06:32:12PM -0500, Bjorn Helgaas wrote:
> On Mon, Oct 04, 2021 at 02:59:24PM +0200, Uwe Kleine-K=F6nig wrote:
> > Hello,
> >=20
> > this is v6 of the quest to drop the "driver" member from struct pci_dev
> > which tracks the same data (apart from a constant offset) as dev.driver.
>=20
> I like this a lot and applied it to pci/driver for v5.16, thanks!
>=20
> I split some of the bigger patches apart so they only touched one
> driver or subsystem at a time.  I also updated to_pci_driver() so it
> returns NULL when given NULL, which makes some of the validations
> quite a bit simpler, especially in the PM code in pci-driver.c.

OK.

> Full interdiff from this v6 series:
>=20
> diff --git a/arch/x86/kernel/probe_roms.c b/arch/x86/kernel/probe_roms.c
> index deaaef6efe34..36e84d904260 100644
> --- a/arch/x86/kernel/probe_roms.c
> +++ b/arch/x86/kernel/probe_roms.c
> @@ -80,17 +80,15 @@ static struct resource video_rom_resource =3D {
>   */
>  static bool match_id(struct pci_dev *pdev, unsigned short vendor, unsign=
ed short device)
>  {
> +	struct pci_driver *drv =3D to_pci_driver(pdev->dev.driver);
>  	const struct pci_device_id *id;
> =20
>  	if (pdev->vendor =3D=3D vendor && pdev->device =3D=3D device)
>  		return true;
> =20
> -	if (pdev->dev.driver) {
> -		struct pci_driver *drv =3D to_pci_driver(pdev->dev.driver);
> -		for (id =3D drv->id_table; id && id->vendor; id++)
> -			if (id->vendor =3D=3D vendor && id->device =3D=3D device)
> -				break;
> -	}
> +	for (id =3D drv ? drv->id_table : NULL; id && id->vendor; id++)
> +		if (id->vendor =3D=3D vendor && id->device =3D=3D device)
> +			break;
> =20
>  	return id && id->vendor;
>  }
> diff --git a/drivers/misc/cxl/guest.c b/drivers/misc/cxl/guest.c
> index d997c9c3ebb5..7eb3706cf42d 100644
> --- a/drivers/misc/cxl/guest.c
> +++ b/drivers/misc/cxl/guest.c
> @@ -20,38 +20,38 @@ static void pci_error_handlers(struct cxl_afu *afu,
>  				pci_channel_state_t state)
>  {
>  	struct pci_dev *afu_dev;
> +	struct pci_driver *afu_drv;
> +	struct pci_error_handlers *err_handler;

These two could be moved into the for loop (where afu_drv was with my
patch already). This is also possible in a few other drivers.

Best regards
Uwe

--=20
Pengutronix e.K.                           | Uwe Kleine-K=F6nig            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

--jgo3ssjhgqy54b4n
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEfnIqFpAYrP8+dKQLwfwUeK3K7AkFAmFmng8ACgkQwfwUeK3K
7AmPuQgAk6Dld3vvwdriW0ibspNDJTGfUcre3doNKax+JiXCiHbUthkO3jZ7kx1f
rTKn9F/GlIOEH1uZZZPonJEaOLwVQmJz3OF8+BKCx7g1+0AqtNe2WefCf4Jl6ajR
fuBtbNjjaCmBXFqToERlpAsB8kRfNy8Y5V7a/XqiX7ZDLiXle3V2AbuQVi5Ikmhp
S72E0TV74YTVv77LeVSAA8275wN0GVI3gVT9F7w9ja0BjrapAALEVsk/s9pAl3Zq
j9D63evuObSQ8ILnNmMOldPueBNZBIGCrXPD/EWKYWXjfstcmZUQtQqvyF6lK9ww
AubKoQZ72JnZiuJZzVyJCsmBBRo2Vw==
=Gp6y
-----END PGP SIGNATURE-----

--jgo3ssjhgqy54b4n--


From xen-devel-bounces@lists.xenproject.org Wed Oct 13 09:27:31 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 09:27:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.208118.364148 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maaXj-0000CE-FH; Wed, 13 Oct 2021 09:27:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 208118.364148; Wed, 13 Oct 2021 09:27:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maaXj-0000C7-C2; Wed, 13 Oct 2021 09:27:23 +0000
Received: by outflank-mailman (input) for mailman id 208118;
 Wed, 13 Oct 2021 09:27:22 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Wjg9=PB=gmail.com=andy.shevchenko@srs-us1.protection.inumbo.net>)
 id 1maaXh-0000Bz-SG
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 09:27:22 +0000
Received: from mail-ed1-x532.google.com (unknown [2a00:1450:4864:20::532])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id c8c60941-ca9a-48df-9e6a-b2144e60353a;
 Wed, 13 Oct 2021 09:27:20 +0000 (UTC)
Received: by mail-ed1-x532.google.com with SMTP id d3so7527321edp.3
 for <xen-devel@lists.xenproject.org>; Wed, 13 Oct 2021 02:27:20 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c8c60941-ca9a-48df-9e6a-b2144e60353a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc:content-transfer-encoding;
        bh=+/MfPZS60YJ0eap0AJdMs6gge+XO+BZUvon0pBTzNGA=;
        b=evc4kDT+QZNhO898nkNWsOvYd5uoHISP2WxjXfUrXPc/LAvzY9eu3qYsrzHLMiVRP3
         7ek8KrGpW83pP3+71f6NoTqJUNew57wgLSdZESolUuO3w3SjswV4oNuZrRCsx5d2Sz6Z
         U6Dil/exw/Z01VwoZLKDTI9+cXYT6HoMhvbPnOyg97B0PkHUENz49VLf5qJ3twBM3fy6
         bHXGjIYLA3Q6jVCBIp04R0UFvkX24frr6ijNGP3vuZmaos7c/PDqm98vd8l9QZ2VLZ00
         0EBJxe8ZaQK4AqNo/Rk1lDSww7yrEMjrcnUEwQvCtD2OBAhLhOYcZrSIMXdkiq7GrIG/
         lN/g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc:content-transfer-encoding;
        bh=+/MfPZS60YJ0eap0AJdMs6gge+XO+BZUvon0pBTzNGA=;
        b=Sfheb1MaaBRsv0863w8LCd+bJ52lJH6VDUGZUfPHwMNdFTGozpbVYrjYIWKYIvZDhR
         yPAyGlvlLD5RxxK3/ngavxl3ansT+eZq9cAPOV87yfOIOMf7XHGyj7Fy1LvQwvUb29HD
         o+sVh5Poi7GyckkwAFzTBngDNGOqhJ6Ke37hJPj6x8oJ+vr48FYm2eK498Bg6pIDFvUn
         z5vVHtlsW4mM78sK+PWNs1YTkUbij/LD38vXTW9sAInl7mW1T+nt3Lu4BZOHFKxi0Z3+
         0Pb6sJ5BW0OgdwR3+/r2zqI4J12sOFa2kYVK9SZwBq49Mhwl7KwIHEC8UVZ3rlNX+61v
         8/Ag==
X-Gm-Message-State: AOAM5311ge0vUf+gy0tc+hGrgF6Xz8eKO8NKELUinrniK462hp9P76qt
	sFwq41GcWQDEokZEVfZQRmvMc/JMW+F4G6FOEYo=
X-Google-Smtp-Source: ABdhPJzL0SqFZyZBLTfBNcE8CpMsywyY4boERpEcXyUfc9yUq7Z2mLOKk/hnon0PQ/WXXVk02NgEbEHqrWvW2H64g2s=
X-Received: by 2002:a17:907:7601:: with SMTP id jx1mr40092015ejc.69.1634117238956;
 Wed, 13 Oct 2021 02:27:18 -0700 (PDT)
MIME-Version: 1.0
References: <20211004125935.2300113-1-u.kleine-koenig@pengutronix.de> <20211012233212.GA1806189@bhelgaas>
In-Reply-To: <20211012233212.GA1806189@bhelgaas>
From: Andy Shevchenko <andy.shevchenko@gmail.com>
Date: Wed, 13 Oct 2021 12:26:42 +0300
Message-ID: <CAHp75Vd0uYEdfB0XaQuUV34V91qJdHR5ARku1hX_TCJLJHEjxQ@mail.gmail.com>
Subject: Re: [PATCH v6 00/11] PCI: Drop duplicated tracking of a pci_dev's
 bound driver
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= <u.kleine-koenig@pengutronix.de>, 
	linux-pci <linux-pci@vger.kernel.org>, Sascha Hauer <kernel@pengutronix.de>, 
	Alexander Duyck <alexanderduyck@fb.com>, 
	Alexander Shishkin <alexander.shishkin@linux.intel.com>, Andrew Donnellan <ajd@linux.ibm.com>, 
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>, 
	Arnaldo Carvalho de Melo <acme@kernel.org>, Arnd Bergmann <arnd@arndb.de>, 
	Benjamin Herrenschmidt <benh@kernel.crashing.org>, Bjorn Helgaas <bhelgaas@google.com>, 
	Borislav Petkov <bp@alien8.de>, Boris Ostrovsky <boris.ostrovsky@oracle.com>, 
	"David S. Miller" <davem@davemloft.net>, Fiona Trahe <fiona.trahe@intel.com>, 
	Frederic Barrat <fbarrat@linux.ibm.com>, Giovanni Cabiddu <giovanni.cabiddu@intel.com>, 
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Herbert Xu <herbert@gondor.apana.org.au>, 
	"H. Peter Anvin" <hpa@zytor.com>, Ido Schimmel <idosch@nvidia.com>, Ingo Molnar <mingo@redhat.com>, 
	Jack Xu <jack.xu@intel.com>, Jakub Kicinski <kuba@kernel.org>, 
	Jesse Brandeburg <jesse.brandeburg@intel.com>, Jiri Olsa <jolsa@redhat.com>, 
	Jiri Pirko <jiri@nvidia.com>, Juergen Gross <jgross@suse.com>, 
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>, Marco Chiappero <marco.chiappero@intel.com>, 
	Mark Rutland <mark.rutland@arm.com>, Mathias Nyman <mathias.nyman@intel.com>, 
	Michael Buesch <m@bues.ch>, Michael Ellerman <mpe@ellerman.id.au>, Namhyung Kim <namhyung@kernel.org>, 
	"Oliver O'Halloran" <oohall@gmail.com>, Paul Mackerras <paulus@samba.org>, 
	Peter Zijlstra <peterz@infradead.org>, =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= <zajec5@gmail.com>, 
	Russell Currey <ruscur@russell.cc>, Salil Mehta <salil.mehta@huawei.com>, 
	Sathya Prakash <sathya.prakash@broadcom.com>, Simon Horman <simon.horman@corigine.com>, 
	Sreekanth Reddy <sreekanth.reddy@broadcom.com>, Stefano Stabellini <sstabellini@kernel.org>, 
	Suganath Prabu Subramani <suganath-prabu.subramani@broadcom.com>, 
	Taras Chornyi <tchornyi@marvell.com>, Thomas Gleixner <tglx@linutronix.de>, 
	Tomaszx Kowalik <tomaszx.kowalik@intel.com>, Vadym Kochan <vkochan@marvell.com>, 
	Wojciech Ziemba <wojciech.ziemba@intel.com>, Yisen Zhuang <yisen.zhuang@huawei.com>, 
	Zhou Wang <wangzhou1@hisilicon.com>, linux-crypto <linux-crypto@vger.kernel.org>, 
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, linux-perf-users@vger.kernel.org, 
	"open list:LINUX FOR POWERPC PA SEMI PWRFICIENT" <linuxppc-dev@lists.ozlabs.org>, linux-scsi <linux-scsi@vger.kernel.org>, 
	USB <linux-usb@vger.kernel.org>, 
	"open list:TI WILINK WIRELES..." <linux-wireless@vger.kernel.org>, MPT-FusionLinux.pdl@broadcom.com, 
	netdev <netdev@vger.kernel.org>, oss-drivers@corigine.com, qat-linux@intel.com, 
	"maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" <x86@kernel.org>, xen-devel@lists.xenproject.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, Oct 13, 2021 at 2:33 AM Bjorn Helgaas <helgaas@kernel.org> wrote:
> On Mon, Oct 04, 2021 at 02:59:24PM +0200, Uwe Kleine-K=C3=B6nig wrote:

> I split some of the bigger patches apart so they only touched one
> driver or subsystem at a time.  I also updated to_pci_driver() so it
> returns NULL when given NULL, which makes some of the validations
> quite a bit simpler, especially in the PM code in pci-driver.c.

It's a bit unusual. Other to_*_dev() are not NULL-aware IIRC.

Below are some comments as well.

...

>  static bool match_id(struct pci_dev *pdev, unsigned short vendor, unsign=
ed short device)
>  {
> +       struct pci_driver *drv =3D to_pci_driver(pdev->dev.driver);
>         const struct pci_device_id *id;
>
>         if (pdev->vendor =3D=3D vendor && pdev->device =3D=3D device)
>                 return true;

> +       for (id =3D drv ? drv->id_table : NULL; id && id->vendor; id++)
> +               if (id->vendor =3D=3D vendor && id->device =3D=3D device)

> +                       break;

return true;

>         return id && id->vendor;

return false;

>  }

...

> +                       afu_result =3D err_handler->error_detected(afu_de=
v,
> +                                                                state);

One line?

...

>         device_lock(&vf_dev->dev);
> -       if (vf_dev->dev.driver) {
> +       if (to_pci_driver(vf_dev->dev.driver)) {

Hmm...

...

> +               if (!pci_dev->state_saved && pci_dev->current_state !=3D =
PCI_D0

> +                   && pci_dev->current_state !=3D PCI_UNKNOWN) {

Can we keep && on the previous line?

> +                       pci_WARN_ONCE(pci_dev, pci_dev->current_state !=
=3D prev,
> +                                     "PCI PM: Device state not saved by =
%pS\n",
> +                                     drv->suspend);
>                 }

...

> +       return drv && drv->resume ?
> +                       drv->resume(pci_dev) : pci_pm_reenable_device(pci=
_dev);

One line?

...

> +       struct pci_driver *drv =3D to_pci_driver(dev->dev.driver);
>         const struct pci_error_handlers *err_handler =3D
> -                       dev->dev.driver ? to_pci_driver(dev->dev.driver)-=
>err_handler : NULL;
> +                       drv ? drv->err_handler : NULL;

Isn't dev->driver =3D=3D to_pci_driver(dev->dev.driver)?

...

> +       struct pci_driver *drv =3D to_pci_driver(dev->dev.driver);
>         const struct pci_error_handlers *err_handler =3D
> -                       dev->dev.driver ? to_pci_driver(dev->dev.driver)-=
>err_handler : NULL;
> +                       drv ? drv->err_handler : NULL;

Ditto.

...

>         device_lock(&dev->dev);
> +       pdrv =3D to_pci_driver(dev->dev.driver);
>         if (!pci_dev_set_io_state(dev, state) ||
> -               !dev->dev.driver ||
> -               !(pdrv =3D to_pci_driver(dev->dev.driver))->err_handler |=
|

> +               !pdrv ||
> +               !pdrv->err_handler ||

One line now?

>                 !pdrv->err_handler->error_detected) {

Or this and the previous line?

...

> +       pdrv =3D to_pci_driver(dev->dev.driver);
> +       if (!pdrv ||
> +               !pdrv->err_handler ||
>                 !pdrv->err_handler->mmio_enabled)
>                 goto out;

Ditto.

...

> +       pdrv =3D to_pci_driver(dev->dev.driver);
> +       if (!pdrv ||
> +               !pdrv->err_handler ||
>                 !pdrv->err_handler->slot_reset)
>                 goto out;

Ditto.

...

>         if (!pci_dev_set_io_state(dev, pci_channel_io_normal) ||
> -               !dev->dev.driver ||
> -               !(pdrv =3D to_pci_driver(dev->dev.driver))->err_handler |=
|
> +               !pdrv ||
> +               !pdrv->err_handler ||
>                 !pdrv->err_handler->resume)
>                 goto out;

Ditto.

> -       result =3D PCI_ERS_RESULT_NONE;
>
>         pcidev =3D pci_get_domain_bus_and_slot(domain, bus, devfn);
>         if (!pcidev || !pcidev->dev.driver) {
>                 dev_err(&pdev->xdev->dev, "device or AER driver is NULL\n=
");
>                 pci_dev_put(pcidev);
> -               return result;
> +               return PCI_ERS_RESULT_NONE;
>         }
>         pdrv =3D to_pci_driver(pcidev->dev.driver);

What about splitting the conditional to two with clear error message
in each and use pci_err() in the second one?

...

>                 default:
>                         dev_err(&pdev->xdev->dev,
> -                               "bad request in aer recovery "
> -                               "operation!\n");
> +                               "bad request in AER recovery operation!\n=
");

Stray change? Or is it in a separate patch in your tree?

--=20
With Best Regards,
Andy Shevchenko


From xen-devel-bounces@lists.xenproject.org Wed Oct 13 09:36:25 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 09:36:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.208127.364158 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maagK-0001g7-94; Wed, 13 Oct 2021 09:36:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 208127.364158; Wed, 13 Oct 2021 09:36:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maagK-0001fr-60; Wed, 13 Oct 2021 09:36:16 +0000
Received: by outflank-mailman (input) for mailman id 208127;
 Wed, 13 Oct 2021 09:36:15 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=0M7b=PB=arm.com=Bertrand.Marquis@srs-us1.protection.inumbo.net>)
 id 1maagJ-0001fl-Fs
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 09:36:15 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com (unknown
 [40.107.20.65]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 275cf0a6-3c67-404f-b862-6c84931855ce;
 Wed, 13 Oct 2021 09:36:13 +0000 (UTC)
Received: from AM6P193CA0098.EURP193.PROD.OUTLOOK.COM (2603:10a6:209:88::39)
 by AM5PR0802MB2484.eurprd08.prod.outlook.com (2603:10a6:203:a1::22) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15; Wed, 13 Oct
 2021 09:36:10 +0000
Received: from VE1EUR03FT036.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:209:88:cafe::1d) by AM6P193CA0098.outlook.office365.com
 (2603:10a6:209:88::39) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.14 via Frontend
 Transport; Wed, 13 Oct 2021 09:36:10 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT036.mail.protection.outlook.com (10.152.19.204) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.15 via Frontend Transport; Wed, 13 Oct 2021 09:36:09 +0000
Received: ("Tessian outbound f1898412aff1:v103");
 Wed, 13 Oct 2021 09:36:09 +0000
Received: from 7fe779da9699.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 D78291B1-78A8-4E0C-8C38-9797000B114C.1; 
 Wed, 13 Oct 2021 09:36:03 +0000
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 7fe779da9699.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Wed, 13 Oct 2021 09:36:03 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com (2603:10a6:4:74::9)
 by DB8PR08MB5498.eurprd08.prod.outlook.com (2603:10a6:10:11c::24) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15; Wed, 13 Oct
 2021 09:36:01 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955]) by DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955%4]) with mapi id 15.20.4587.026; Wed, 13 Oct 2021
 09:36:01 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 275cf0a6-3c67-404f-b862-6c84931855ce
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=raRbqoRtl/8bp6k7UArUhXheVAvcHhHyfZT2zcMkpak=;
 b=qa98AzczCJPCrGJQxTGRHoXSeeN0Eqb8f3LfoQI96BGvS6W7wYgdXEj/pI1OyGMmLnT6ap3VLF0CSN7lkWrTMZ1U0H7AQ+N5CpVj9rnaAMSTRcutxJqPfAG6pKgFB79nWHIZ7IE1fZ8LnATwWbaeb44C7qE6sDZEyAH5Dx05ecE=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 8e4f8158cbb334bb
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ME+fXWM+d2UKijXHSJjmcFCr8cNVgrgkBRbbrSD5YncTXemca1YBxx7wy7sMB91OGapB7Bur2j855cqIKvHhrKlNrfDYQqWzLnmPRBqRfEM+40KpiMrFx17JoLP9hl5x8D5L3e3pqb7IT1lp5HuZLPSTUrNt3UDoSNc0lPXLovQXamMgl14/6BITyOyI+R4I8H4eo8I+rIT71197uVVKfUiQnyWgH8wpidrg2n5aJrrttLkm6SihZynf+cYa5z7dsh6KC61FispjMx04YopcNJH+qhVQVS6E4bA+ceGr+6e+PFIXIS6UG20RqrV29MoOqNYoITlFM8I0grubZMuL6A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=raRbqoRtl/8bp6k7UArUhXheVAvcHhHyfZT2zcMkpak=;
 b=FlDQav6QF/Pcw51AVz0vRXRQ0xOV+NKJ/4HWKFzATzKMAgWOtRsmzCboTzCtAJs3o8r4yXQ3a29+SxF5yPrwCZHCPf7agVdUCpwX6/UlLJviED4OSz7NPRvz6mNiclQefjtvD2ueYE/rsfTFWSZQ9lN/O8N8mnW3OxOFA2kTMOh1//fkjV/MsSgbIfpeDswSDKTL41hVqm3XNBQAO1PFgR0jqH9s1VCVSp+VTWW6dAX6COMABZrj2Vaf1bIulDONjkJBgKRApxZ3S1cqm8Jp/41YnYzg/8roMoIf4bcEa5fLsiNUPweo2gig3yk5HSzQlIWha89J8c9dG8JRzkgR/Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=raRbqoRtl/8bp6k7UArUhXheVAvcHhHyfZT2zcMkpak=;
 b=qa98AzczCJPCrGJQxTGRHoXSeeN0Eqb8f3LfoQI96BGvS6W7wYgdXEj/pI1OyGMmLnT6ap3VLF0CSN7lkWrTMZ1U0H7AQ+N5CpVj9rnaAMSTRcutxJqPfAG6pKgFB79nWHIZ7IE1fZ8LnATwWbaeb44C7qE6sDZEyAH5Dx05ecE=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>
CC: Michal Orzel <Michal.Orzel@arm.com>, Rahul Singh <Rahul.Singh@arm.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Andre
 Przywara <Andre.Przywara@arm.com>, Christian Lindig
	<christian.lindig@citrix.com>, David Scott <dave@recoil.org>, Ian Jackson
	<iwj@xenproject.org>, Wei Liu <wl@xen.org>, Andrew Cooper
	<andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>, Jan
 Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>, Stefano
 Stabellini <sstabellini@kernel.org>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH v5 07/11] xen/domctl: Introduce XEN_DOMCTL_CDF_vpci flag
Thread-Topic: [PATCH v5 07/11] xen/domctl: Introduce XEN_DOMCTL_CDF_vpci flag
Thread-Index: AQHXutmFlM61oLukkkqK7dSQSsVJ1qvNjrkAgAGmMoCAAW6PgIAAEkkA
Date: Wed, 13 Oct 2021 09:36:01 +0000
Message-ID: <8F9D6B9C-58CB-4000-995A-95517EE72A3B@arm.com>
References: <cover.1633540842.git.rahul.singh@arm.com>
 <20d5b9d6a0d01a7b90711d28cbefb5701a88b438.1633540842.git.rahul.singh@arm.com>
 <YWQDguvmf/O4rDIs@MacBook-Air-de-Roger.local>
 <9217a6b8-fc53-a049-7cd3-7458b574424b@arm.com>
 <YWaZKX44IOfIBtX6@MacBook-Air-de-Roger.local>
In-Reply-To: <YWaZKX44IOfIBtX6@MacBook-Air-de-Roger.local>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3654.120.0.1.13)
Authentication-Results-Original: citrix.com; dkim=none (message not signed)
 header.d=none;citrix.com; dmarc=none action=none header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: 66fd4687-db23-4e51-2506-08d98e2ce3ac
x-ms-traffictypediagnostic: DB8PR08MB5498:|AM5PR0802MB2484:
x-ms-exchange-transport-forked: True
X-Microsoft-Antispam-PRVS:
	<AM5PR0802MB248429723BD137459C4D54DF9DB79@AM5PR0802MB2484.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:10000;OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 F7g6wkn4G0EJSYjAHyDYbYSGJQj9JhvG9Dd5ZIvBwEGXzDcSYK7CIBzoryGD9/i2nC7BoJLa25prux/a2XGIQHzHabo6dY/Hcfr+84tBvUZs74JpSHDMrEadK37lMQjcX3EWxHqwLA664c/Zvv80fI7MoT1kApNOQCj3jzTva81FD6HhABSCOY4p3k/2QZJf4EtrV1V9efu3504UVik4SRuUZ5BCoxtlAkskt2XStl1Ugfs1qSO1E6keSg5aznVTVyYW9AFyE+ws1RC1fDA9iR1Y0HeeDDR3z4NSpYvfSc1SeXiAwe4oeS3fXS/twWKWA+M+Ff5mpgyRR2r1rnAjJhp1R3doY2A5LRwpHetk+xDAMwPCWgqKwQlDwjlsjwkQ60WBTpsI5vNlGbntemoqJfvJ7h1tczjYHWVUHc+dzZmn/KT9snns7YyDfhfWeVYYxwLtQCqymIM+kXEaS3jUXjQFua6o1TTzlKisakcHm39MVBveEBUvl2Ck5LDSIaJcoiNX+gggvM9K4c0OfU7WneOUHqzpS6AVZBEpNF3ZRLLRSEYD97c7wKmKhRvTM/WXNQ9bkZkTqLiQk2J4IAHlqxLLUeAlMfkK+ZDIJdSQyb9Vb6oeOFJLGqZmM0mUEq3nySc6v28cB+tdBKtIzQy/DnarIWHUlXE6SAjCbyDhNpJMDeNEL6qqVoxTiKVYhOTk4MBrz2LLsfIxmMJnpnXln7Gs9Ot2jAejc6z1ul+6z10PaEGtNIg6qCBNZmHT1/i6
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB6PR0801MB2024.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(66446008)(66946007)(64756008)(66556008)(66476007)(8676002)(53546011)(508600001)(91956017)(6486002)(36756003)(2906002)(83380400001)(122000001)(38100700002)(4326008)(6916009)(71200400001)(5660300002)(76116006)(33656002)(316002)(8936002)(54906003)(26005)(7416002)(6506007)(38070700005)(186003)(86362001)(2616005)(6512007)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-ID: <ECCCBE60E4886B4F811E862C4DF8CDE9@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB5498
Original-Authentication-Results: citrix.com; dkim=none (message not signed)
 header.d=none;citrix.com; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT036.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	fb16cd06-d26e-4481-43a7-08d98e2cded0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Cij4UHeoWEFvHx+6FJvIzTMkG5Qk4jeGo8SGqa2r+a4EqXejIYP56S26RC97NDcr1cktIjLZYRcbqTNpCjtOY0mxqNQ5i8WqTJHYdYN8L6VJYQtlBF+dp1He1cmV0SG+JkEj4dmOEq0D1Pey0M7xZgZXQZsCN9ifedaq0SgEZCJCQBKIdIeInlcMoGhRTtq89HoW4wJIgNdUQgwPleFb5LdkVz3e4DzjiEWhW0VU6pu+IhV0GIwXYpUI3avaRIJyiGLvAYJXGKNmGaH9PaCDg9HOuKHI1aeNDkLrYq42rwN64wKRa/AekHsqPLrEhnN/TtaBXLuUr0U7L6mhQVrqxbMoMKZBu7MREUEP89++eqpwE5mLc9wxOCHWsRQOzRHwUn7Rijs5KkidiMMUkZ60ScPNRY+4+h1p0mtsHjoUT3bk/CrcAuaQqxGsH1RylD6j00DROMG+llubMo44qn/XOBJPL5N2CVlP8jmtt4tJvlGe3ZAK29bcjIouFdK2TcfAOVuf+O42Ll2+jPa6hC8jvq7mrBnysieOHgBjC7GZ9zfdDF26E2Am9NjL/8dGJWIebUCW9i9+oa8VFOvIbEALMkDRsaCzZrr5MJy09hAhL2oU8ZhglX8Hx+w7LlgwPu10cxRFSZAYrtbt5aKe0CFaq2Y1qWdt94IjH+6oDgyIHm9vgkguiNZvWiQbuPZzpCqazXZUBg4i5PBgBY1yqsyVMA==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(82310400003)(316002)(6862004)(8936002)(5660300002)(81166007)(6512007)(70206006)(2616005)(356005)(26005)(4326008)(83380400001)(186003)(107886003)(54906003)(36756003)(508600001)(47076005)(8676002)(336012)(33656002)(6486002)(86362001)(6506007)(2906002)(70586007)(36860700001)(53546011);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2021 09:36:09.7951
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 66fd4687-db23-4e51-2506-08d98e2ce3ac
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT036.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0802MB2484

SGkgUm9nZXIsDQoNCj4gT24gMTMgT2N0IDIwMjEsIGF0IDA5OjMwLCBSb2dlciBQYXUgTW9ubsOp
IDxyb2dlci5wYXVAY2l0cml4LmNvbT4gd3JvdGU6DQo+IA0KPiBPbiBUdWUsIE9jdCAxMiwgMjAy
MSBhdCAxMjozODozNVBNICswMjAwLCBNaWNoYWwgT3J6ZWwgd3JvdGU6DQo+PiBIaSBSb2dlciwN
Cj4+IA0KPj4gT24gMTEuMTAuMjAyMSAxMToyNywgUm9nZXIgUGF1IE1vbm7DqSB3cm90ZToNCj4+
PiBPbiBXZWQsIE9jdCAwNiwgMjAyMSBhdCAwNjo0MDozM1BNICswMTAwLCBSYWh1bCBTaW5naCB3
cm90ZToNCj4+Pj4gSW50cm9kdWNlIFhFTl9ET01DVExfQ0RGX3ZwY2kgZmxhZyB0byBlbmFibGUg
VlBDSSBzdXBwb3J0IGluIFhFTi4NCj4+Pj4gUmVqZWN0IHRoZSB1c2Ugb2YgdGhpcyBuZXcgZmxh
ZyBmb3IgeDg2IGFzIFZQQ0kgaXMgbm90IHN1cHBvcnRlZCBmb3INCj4+Pj4gRE9NVSBndWVzdHMg
Zm9yIHg4Ni4NCj4+PiANCj4+PiBJIGRvbid0IGxpa2UgdGhpcyBhcHByb2FjaCwgWEVOX0RPTUNU
TF9DREZfdnBjaSBzaG91bGQgYmUgc2V0IGZvciB4ODYNCj4+PiBQVkggZG9tMCwgbGlrZSB3ZSBk
byBmb3IgYW55IG90aGVyIENERiBmbGFncyB3aGVuIFhlbiBidWlsZHMgZG9tMC4NCj4+PiANCj4+
PiBUaGluZ3MgbGlrZSBQVkggdnMgUFYgZ2V0IHRyYW5zbGF0ZWQgaW50byBDREYgZmxhZ3MgYnkg
Y3JlYXRlX2RvbTAsDQo+Pj4gYW5kIHByb2Nlc3NlZCBub3JtYWxseSBieSB0aGUgc2FuaXRpc2Vf
ZG9tYWluX2NvbmZpZyBsb2dpYywgdlBDSQ0KPj4+IHNob3VsZCBiZSBoYW5kbGVkIHRoYXQgd2F5
Lg0KPj4+IA0KPj4+IERvIHlvdSB0aGluayB5b3UgY291bGQgc2VlIGFib3V0IGZpeGluZyB0aGlz
Pw0KPj4+IA0KPj4+IFRoYW5rcywgUm9nZXIuDQo+Pj4gDQo+PiANCj4+IEkgaGF2ZSBvbmUgcXVl
c3Rpb24gYWJvdXQgdGhpcyBmaXguDQo+PiBJZiBJIHNldCBYRU5fRE9NQ1RMX0NERl92cGNpIGZv
ciBkb20wIHB2aCBpbiBjcmVhdGVfZG9tMCwgdGhlbiBpbg0KPj4gc2FuaXRpc2VfZG9tYWluX2Nv
bmZpZyBvciBhcmNoX3Nhbml0aXNlX2RvbWFpbl9jb25maWcgSSBoYXZlIG5vDQo+PiBrbm93bGVk
Z2Ugb24gd2hldGhlciBJIGFtIGRvbTAgb3Igbm90LiBJIGNhbiBjaGVjayBpZiBJJ20gUFZIIGJ1
dCBub3QgaWYgZG9tMC4NCj4+IFRoaXMgd291bGQgYmUgbmVlZGVkIHRvIGFkZCBhIHdhcm5pbmcg
aWYgdGhpcyBmbGFnIGlzIHNldCBidXQgd2UgYXJlIG5vdCBkb20wIHB2aC4NCj4+IA0KPj4gQW55
IGlkZWFzPw0KPiANCj4gSSd2ZSBqdXN0IHJlYWxpemVkIHRoaXMgaXMgbW9yZSB3cm9uZyB0aGF0
IEkgdGhvdWdodC4gdlBDSSBpcw0KPiBzaWduYWxlZCBvbiB4ODYgaW4geGVuX2FyY2hfZG9tYWlu
Y29uZmlnLmVtdWxhdGlvbl9mbGFncywgc28NCj4gaW50cm9kdWNpbmcgYSB0b3AgbGV2ZWwgb3B0
aW9uIGZvciBpdCB3aXRob3V0IHJlbW92aW5nIHRoZSBhcmNoDQo+IHNwZWNpZmljIG9uZSBpcyB3
cm9uZywgYXMgdGhlbiBvbiB4ODYgd2UgaGF2ZSBhIGR1cGxpY2F0ZWQgb3B0aW9uLg0KPiANCj4g
VGhlbiBJJ20gYWxzbyBub3Qgc3VyZSB3aGV0aGVyIHdlIHdhbnQgdG8gbW92ZSBpdCBmcm9tDQo+
IGVtdWxhdGlvbl9mbGFncywgaXQgc2VlbXMgbGlrZSB0aGUgbW9yZSBuYXR1cmFsIHBsYWNlIGZv
ciBpdCB0byBsaXZlDQo+IG9uIHg4Ni4NCj4gDQo+IElmIHdlIHJlYWxseSB3YW50IHRvIG1ha2Ug
dlBDSSBhIENERiBvcHRpb24gd2UgbXVzdCBkZWFsIHdpdGggdGhlDQo+IHJlbW92YWwgb2YgWEVO
X1g4Nl9FTVVfVlBDSSwgb3IgZWxzZSB5b3UgY291bGQgaW50cm9kdWNlIGFuIGFyY2gNCj4gc3Bl
Y2lmaWMgZmxhZyBmb3IgdlBDSSBvbiBBcm0uDQoNCkZpcnN0IGlzc3VlIHRoYXQgd2UgaGF2ZSBo
ZXJlIGlzIHRoYXQgdGhlcmUgaXMgbm8gZW11bGF0aW9uX2ZsYWdzIHJpZ2h0IG5vdyBvbiBhcm0u
DQoNClNvIEkgdGhpbmsgdGhlcmUgYXJlIDIgc29sdXRpb25zOg0KDQotIGludHJvZHVjZSBQSFlT
Q0FQLiBUaGUgcHJvYmxlbSBoZXJlIGlzIHRoYXQgaXQgaXMgbm90IGEgcGh5c2ljYWwgY2FwYWNp
dHkgYW5kDQpJIHRoaW5rIHRoYXQgd2lsbCBoaXQgdXMgaW4gdGhlIGZ1dHVyZSBmb3IgZXhhbXBs
ZSBpZiB3ZSB3YW50IHRvIHVzZSB2cGNpIGZvciBWSVJUSU8NCmV2ZW4gaWYgdGhlcmUgaXMgbm90
IHBoeXNpY2FsIFBDSSBvbiB0aGUgcGxhdGZvcm0uDQoNCi0gaW50cm9kdWNlIGFuIGVtdWxhdGlv
biBmbGFnIG9uIGFybS4gVGhlIHByb2JsZW0gaGVyZSBpcyB0aGF0IHRoZXJlIGlzIG5vIGVtdWxh
dGlvbg0KZmxhZyByaWdodCBub3cgb24gYXJtIHNvIGFkZGluZyB0aGlzIGZlYXR1cmUgd2lsbCBy
ZXF1aXJlIGEgY2hhbmdlIG9mIGludGVyZmFjZSBpbg0KYXJjaC1hcm0uaCBhbmQgaW4geGVuIGRv
bWN0bCBpbnRlcmZhY2UuIEJ1dCBpZiB3ZSBpbnRyb2R1Y2Ugb25lIG9uIEFybSwgaXQgd291bGQg
YWxsb3cNCnRoZSB0b29scyB0byBjaGVjayBpZiBDREZfdnBjaSBjYW4gYmUgc2V0IG9yIG5vdCB3
aGljaCB3b3VsZCBzb2x2ZSBjdXJyZW50IGlzc3Vlcy4NCg0KSSB0aGluayB0aGUgc2Vjb25kIHNv
bHV0aW9uIGlzIHRoZSByaWdodCBvbmUgYnV0IGl0IGNhbm5vdCBiZSBkb25lIHNvIG5lYXIgZnJv
bSB0aGUNCmZlYXR1cmUgZnJlZXplLg0KDQpUaGUgQ0RGIGZsYWcgYXMgaW50cm9kdWNlZCByaWdo
dCBub3cgaXMgbm90IGNyZWF0aW5nIGFueSBpc3N1ZSBhbmQgd2lsbCBiZSB1c2VkIG9uY2UNCnRo
ZSBlbXVsYXRpb24gZmxhZyB3aWxsIGJlIGludHJvZHVjZS4gV2Ugd2lsbCBiZSBhYmxlIGF0IHRo
aXMgc3RhZ2UgdG8gc2V0IHRoaXMgcHJvcGVybHkNCmFsc28gb24geDg2IChmb3IgZG9tMCBwdmgp
Lg0KTW9yZW92ZXIga2VlcGluZyBpdCB3aWxsIGFsbG93IHRvIGNvbnRpbnVlIHRvIG1lcmdlIHRo
ZSByZW1haW5pbmcgcGFydCBvZiB0aGUgUENJDQpwYXNzdGhyb3VnaCB3aGljaCBhcmUgb3RoZXJ3
aXNlIG5vdCBwb3NzaWJsZSB0byBiZSBkb25lIGFzIHRoZXkgYXJlIGRlcGVuZGVudCBvbiB0aGlz
IGZsYWcuDQoNCkNhbiB3ZSBhZ3JlZSBvbiBrZWVwIHRoZSBET01DVExfQ0RGX3ZwY2kgZmxhZyBh
bmQgaW50cm9kdWNlIHRoZSBlbXVsYXRpb24NCmZsYWcgb24gQXJtIGFmdGVyIDQuMTYgcmVsZWFz
ZSA/DQoNCkNoZWVycw0KQmVydHJhbmQNCg0K


From xen-devel-bounces@lists.xenproject.org Wed Oct 13 09:37:20 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 09:37:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.208135.364170 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maahL-0002Ic-N9; Wed, 13 Oct 2021 09:37:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 208135.364170; Wed, 13 Oct 2021 09:37:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maahL-0002IV-JB; Wed, 13 Oct 2021 09:37:19 +0000
Received: by outflank-mailman (input) for mailman id 208135;
 Wed, 13 Oct 2021 09:37:18 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=0JNW=PB=citrix.com=Kevin.Stefanov@srs-us1.protection.inumbo.net>)
 id 1maahJ-0002IL-Vh
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 09:37:18 +0000
Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 27164294-2c09-11ec-8168-12813bfff9fa;
 Wed, 13 Oct 2021 09:37:17 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 27164294-2c09-11ec-8168-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1634117836;
  h=from:to:cc:subject:date:message-id:mime-version:
   content-transfer-encoding;
  bh=X1d67tW3T1V+2UmPYFDEiBHGd9qhuZ4HF5AmEfApezE=;
  b=dEZHDN+jsF1ZffTSgL5+wjpNK/jC2/HukQoBJA5xPWx4A19a5IIT8ltw
   Rg4BiDW4S+fnbn4RPbrWxqFJHQvZ6VGOYqPHPyWG3GYxRrjTGRHGycXbQ
   7fmVCHI2BY7EvcEra33TDSGkQa3sySLvFcKPDA4g5tcopIXdfa1eZWLC8
   8=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: C8GaAYr0xpBO9Di5XEvpbEgmm/5uGNPwiTc3Yxzh6T53w+GSMW8sGDdv6ruYjoufL/N8mYCM7+
 RwVgYLHH7NVIsaYrPZUS4GC3sTls45X9AsO81Zb/ETidU6W+TQT0BpUUbbioS+j8qT3vg3jSKG
 wxPfvV2Th0t+RaanAVKZ7T/AvXGcZ1k5t0cNgxPnGR4DuEcmxsoSUL8Y0uCxbn5K6gVV2ZmiJF
 SdkT7D3nWRUFztR+VfxlF0wv2a9JILLK2ffpmDhw7ExmrogzuyQZddNl0r4EiGAFoOfmhcq5Wc
 NG6mxsv6nwlOJPjVE5DECEF0
X-SBRS: 5.1
X-MesageID: 55070596
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:Pn0lwK/6SvCMeNKLiLWzDrUDanmTJUtcMsCJ2f8bNWPcYEJGY0x3n
 TRKXjyEM/aDMzfxKN0la47l9EhS6JOBxt4xHlc9qX88E34SpcT7XtnIdU2Y0wF+jyHgoOCLy
 +1EN7Es+ehtFie0Si9AttENlFEkvU2ybuOU5NXsZ2YhGGeIdA970Ug6wrZg2dYx6TSEK1jlV
 e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH
 I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPhX5
 f8TrrCvWD04P4rdp6cyaTBYEnlhaPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us
 6ZCcXZUM07F17neLLGTE4GAguwAIdfqOsUkpnxuxDfeE94tQIzZQrWM7thdtNs1rp0TRamGO
 ptHAdZpRBrDbi0QZA43MZUjoLe6v37kYWN3pWvA8MLb5ECMlVcsgdABKuH9ZdiiVchT2EGCq
 Qru/Xn9AxwcHMySz3yC6H3Eru3AhyTgQ6oJCaa1sPVthTW71mEVTREbS1a/if24kVKlHcJSL
 VQO/SgjprR081akJvH8QB+QsHOCpgQbWddbD6s98g7l90bPy1/HXC5eFGcHMYF48p9tLdA36
 rOXt/XEL2J0nKKEc2Oc0aar7hyIECgUdXBXMEfoUjA5y9XkpYgyiDfGQdBiDLO5g7XJJN3g/
 9yZhHNh3+tL3Kbnw43+pAqd22v9+fAlWyZsvl2PNl9J+D+Vc2JMi2aA0lPc8epbZLiQSl2Mr
 RDocODPsbhQU/lheMGLKdjh/Y1FBd7ZblUwYnY1RvHNEghBHVb4Iui8BxkkdS9U3j4sI2OBX
 aMqkVo5CGVvFHWrd7RrRIm6Ft4ny6Ptffy8CKuINoQSOMArKFTblM2LWaJ29zuy+KTLuftuU
 ap3jO72VSpKYUiZ5GveqxghPU8DmXllmDK7qWHTxBW7y7uODEN5up9eWGZimtsRtfveyC2Mq
 o43H5LTl313Db2vCgGKoNV7BQ1bchAG6WXe9pU/mhireVE9RgnMypb5nNscRmCSt/0NzLmXp
 SvhBhYwJZiWrSSvFDhmo0tLMNvHNauTZ1pnbUTA5H6khCouZ5iB9qAae8dldLUr7rU7n/V1U
 +MEa4OLBfEWEmbL/DEUbJ/cqo1+dUv02VLSbnT9ODVvLYR9QwHp+8P/ele9/ic5ESfq59A1p
 Ket112HTMNbFRhiFsvfdNmm00i14SoGgOt3UkaReotTdUzg/ZJEMSv0ivNrccgAJQ+anmmR1
 hqMAAderu7I+tdn/N7MjKGCjoGoD+ohQRYKQziFte67bHCI8HCizIlMVPezUQrcDG6kqr+/Y
 eh1zu3nNKFVllh9rIchQa1gyrgz5oWzquYCnBhkBnjCc3+iFqhkfiudxcBKu6BAmu1ZtA+xV
 h7d89VWI+zUasbsEVpXLws5dOWTk/oTn2CKv/gyJUz74g5x/aaGDhoOb0Xd1nQFIesnKp4hz
 McgpNUSul62hRcdO9qbijxZqjaXJXsaXqR77pwXDecHUObwJo2utXAENhLL3Q==
IronPort-HdrOrdr: A9a23:BpM6OaC/gN9STQDlHemg55DYdb4zR+YMi2TC1yhKJyC9Ffbo8/
 xG/c5rsyMc5wxwZJhNo7y90cq7MBbhHPxOkOos1N6ZNWGM0gaVxelZnOzfKlbbehEWmNQz6U
 4ZSdkdNOHN
X-IronPort-AV: E=Sophos;i="5.85,370,1624334400"; 
   d="scan'208";a="55070596"
From: Kevin Stefanov <kevin.stefanov@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Kevin Stefanov <kevin.stefanov@citrix.com>, Ian Jackson
	<iwj@xenproject.org>, Wei Liu <wl@xen.org>, Juergen Gross <jgross@suse.com>,
	Julien Grall <julien@xen.org>, Andrew Cooper <andrew.cooper3@citrix.com>
Subject: [PATCH] tools/tests: Make E2BIG non-fatal to xenstore unit test
Date: Wed, 13 Oct 2021 10:35:46 +0100
Message-ID: <20211013093546.17203-1-kevin.stefanov@citrix.com>
X-Mailer: git-send-email 2.25.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

Xenstore's unit test fails on read and write of big numbers if
quota-maxsize is set to a lower number than those test cases use.

Output a special warning instead of a failure message in such cases
and make the error non-fatal to the unit test.

Signed-off-by: Kevin Stefanov <kevin.stefanov@citrix.com>
---
CC: Ian Jackson <iwj@xenproject.org>
CC: Wei Liu <wl@xen.org>
CC: Juergen Gross <jgross@suse.com>
CC: Julien Grall <julien@xen.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>
---
 tools/tests/xenstore/test-xenstore.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/tools/tests/xenstore/test-xenstore.c b/tools/tests/xenstore/test-xenstore.c
index d3574b3fa2..ec8c63a65d 100644
--- a/tools/tests/xenstore/test-xenstore.c
+++ b/tools/tests/xenstore/test-xenstore.c
@@ -110,8 +110,13 @@ static int call_test(struct test *tst, int iters, bool no_clock)
             break;
     }
 
-    if ( ret )
-        printf("%-10s: failed (ret = %d, stage %s)\n", tst->name, ret, stage);
+    /* Make E2BIG non-fatal to the test */
+    if ( ret ){
+	if( ret == 7 )
+            printf("%-10s: Not run - argument list too long\n", tst->name);
+        else      
+            printf("%-10s: failed (ret = %d, stage %s)\n", tst->name, ret, stage);
+    }
     else if ( !no_clock )
     {
         printf("%-10s:", tst->name);
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Wed Oct 13 09:49:03 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 09:49:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.208145.364180 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maasb-0003ra-Nz; Wed, 13 Oct 2021 09:48:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 208145.364180; Wed, 13 Oct 2021 09:48:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maasb-0003rT-L2; Wed, 13 Oct 2021 09:48:57 +0000
Received: by outflank-mailman (input) for mailman id 208145;
 Wed, 13 Oct 2021 09:48:56 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=0M7b=PB=arm.com=Bertrand.Marquis@srs-us1.protection.inumbo.net>)
 id 1maasa-0003rN-Lb
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 09:48:56 +0000
Received: from EUR01-VE1-obe.outbound.protection.outlook.com (unknown
 [2a01:111:f400:fe1f::60f])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 11609a78-5dcd-443c-8a1e-6065f8de0730;
 Wed, 13 Oct 2021 09:48:55 +0000 (UTC)
Received: from AM6P195CA0063.EURP195.PROD.OUTLOOK.COM (2603:10a6:209:87::40)
 by AM9PR08MB6929.eurprd08.prod.outlook.com (2603:10a6:20b:302::22) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.24; Wed, 13 Oct
 2021 09:48:51 +0000
Received: from AM5EUR03FT061.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:209:87:cafe::2) by AM6P195CA0063.outlook.office365.com
 (2603:10a6:209:87::40) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16 via Frontend
 Transport; Wed, 13 Oct 2021 09:48:51 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM5EUR03FT061.mail.protection.outlook.com (10.152.16.247) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4587.18 via Frontend Transport; Wed, 13 Oct 2021 09:48:50 +0000
Received: ("Tessian outbound b9598e0ead92:v103");
 Wed, 13 Oct 2021 09:48:50 +0000
Received: from 3432700502bc.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 409F5B34-10DE-41BE-BB7F-DEF3B8623BAE.1; 
 Wed, 13 Oct 2021 09:48:44 +0000
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 3432700502bc.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Wed, 13 Oct 2021 09:48:44 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com (2603:10a6:4:74::9)
 by DBBPR08MB5961.eurprd08.prod.outlook.com (2603:10a6:10:203::10) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.19; Wed, 13 Oct
 2021 09:48:42 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955]) by DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955%4]) with mapi id 15.20.4587.026; Wed, 13 Oct 2021
 09:48:42 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 11609a78-5dcd-443c-8a1e-6065f8de0730
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=175H1M8tup36RDH1O3KJZKlC+Kg+GCkSYn0C3TWzQhQ=;
 b=gHMueHHmJyOP0ijUOgGP2Fp0WsRxft80f0zfOr09c6jkA2fBonolr6MTBryuqKF29+nVSG33x+hJYFGypuWMTyT5ovIiQVrTlFl5qLNheDaOIK/lYIitW3Zm2NPXt6Mg2XYL43x9yh2CZdIqBKoza9HvT9Gtgp16SYO2eHRxd6U=
X-MS-Exchange-Authentication-Results: spf=temperror (sender IP is
 63.35.35.123) smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass
 (signature was verified) header.d=armh.onmicrosoft.com;lists.xenproject.org;
 dmarc=temperror action=none header.from=arm.com;
Received-SPF: TempError (protection.outlook.com: error in processing during
 lookup of arm.com: DNS Timeout)
X-CheckRecipientChecked: true
X-CR-MTA-CID: 34b67f7e699b2c08
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=PLvpLQMNkG493WMjCVF7EBsUcumpXD0jalhILxHKTSBkdl5F2JB1CEOcQ3XuH3skIAbN8VVPVF36fihZcEJW9Mm3BFNtI/NKZUKYMwmw9sAP4ijlLD7D96/qd8G1DoOLPVpV9uSxh9D6jnmotv2ACUPiB+u3gXFAfL9318b6SVxvLnHXZlQpQQdbA1JFzTHiBq68Noib4h6EV4bBhSsJ7Oz0A80V+errZSHqWRnV5k7Ji1zBOsDPa1IWaTL4EmXH9zJbQHIXOw6+v2szqn1cd4u93uuQuNHbbeLNlE15JvHuko7x4tFXhuOcMI2TYifjTJ2XJeV2OJZ60631/9E9dA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=175H1M8tup36RDH1O3KJZKlC+Kg+GCkSYn0C3TWzQhQ=;
 b=g5uGbTulPlAL7MN8qOacv53lTyonyzhnu/dM2mYJgyd0Yj9AFDWbbE0g9VTVS8To46pV6OHd9G1erIuyMbqeue4DNYzTb38JD/plIGI/sRJCL75S/4hqpD5tJzHA/MyQeCZHrqeDKAlVNgrSSqK632WzkSGwm6u2QftxtFAre2cr3ZmPhC4BLkkTd0DFda/AiVr9ODhsqWp8nbeqBLwbB2OZ+GK6x2so1Op5qeUE603gOA8O1hLayocQ33Yo0YWv/UQ5DF0vQ0DLMiISbRS9JinLQleu4DkJI6yKWiNH3vmEGVShSQY191EzbqnimWStxUIpdhF1X63+LZyD+x0kvg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=175H1M8tup36RDH1O3KJZKlC+Kg+GCkSYn0C3TWzQhQ=;
 b=gHMueHHmJyOP0ijUOgGP2Fp0WsRxft80f0zfOr09c6jkA2fBonolr6MTBryuqKF29+nVSG33x+hJYFGypuWMTyT5ovIiQVrTlFl5qLNheDaOIK/lYIitW3Zm2NPXt6Mg2XYL43x9yh2CZdIqBKoza9HvT9Gtgp16SYO2eHRxd6U=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>
CC: Rahul Singh <Rahul.Singh@arm.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, Andre Przywara <Andre.Przywara@arm.com>,
	Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, Andrew Cooper
	<andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>, Ian
 Jackson <iwj@xenproject.org>, Jan Beulich <jbeulich@suse.com>, Wei Liu
	<wl@xen.org>, Paul Durrant <paul@xen.org>
Subject: Re: [PATCH v5 08/11] xen/arm: Enable the existing x86 virtual PCI
 support for ARM.
Thread-Topic: [PATCH v5 08/11] xen/arm: Enable the existing x86 virtual PCI
 support for ARM.
Thread-Index: AQHXutl3YqS5dHXsYk6KpdKt4d14RavQp5+AgAARr4A=
Date: Wed, 13 Oct 2021 09:48:42 +0000
Message-ID: <7077F76D-37B0-45F6-9B0D-0D9436E23716@arm.com>
References: <cover.1633540842.git.rahul.singh@arm.com>
 <9bdca2cda5d2e83f94dc2423e55714273539760a.1633540842.git.rahul.singh@arm.com>
 <YWaco/UvA4xFE1xW@MacBook-Air-de-Roger.local>
In-Reply-To: <YWaco/UvA4xFE1xW@MacBook-Air-de-Roger.local>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3654.120.0.1.13)
Authentication-Results-Original: citrix.com; dkim=none (message not signed)
 header.d=none;citrix.com; dmarc=none action=none header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: e7d37081-3acc-4039-936f-08d98e2ea95a
x-ms-traffictypediagnostic: DBBPR08MB5961:|AM9PR08MB6929:
x-ms-exchange-transport-forked: True
X-Microsoft-Antispam-PRVS:
	<AM9PR08MB6929AF5DB1E392959C2505449DB79@AM9PR08MB6929.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:10000;OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 VEke3VJBeqzIuu3oJonnKHunaprNxP2dy4NEafoYTqNTSD7gGD2fuu5Om1eC7mS5x/Ha1HSYmU6LgeUJ0WuL94K/5uYLp2U3VA1n9wwvOZj4Kcc3IcoaTXKIjIwUwM2VAhMpqgKNg3vFzm8MtfK9EX8T/jwBtOiR9Z7qrvKxR0/5SUpA7jqMO+hWeKkKwjJv9HfGlzg+7PH4cCosQo1XJaroCpVM8CwQO59V0NJuWuPpenmLfze9eSMQGcgTi20VHv/uLip9mVD6kpxT5rWf2eCxCJvWupiSH9DFlh2qVOl2YVIyAqIWvO3hRu1mQZzx3A4CDSI3DG+lqVjorMy6bmbYHo9m1P7BLm724st9OygXGfParisiXuV89USWaDZd3Mh+b0poxy4QzZZmfhpRgBpHZu2MyAlBXbSPE9bPc8VtR39AazkRuv8uDdZwkcnxAmb0J0Mg1Bd1BHsJbH65y1hIsswVjF5uPk6iROkGF7Ydp/q9fSbru4/gjGLQppjy4VLYcbaIM3z3Rll+WohhwlmPM9LWmaXPG0jw3b0hsPweODcXbVs17yJzdK9STp5yamDb43m9xPlqyIPjrY+lmr1Ab7maf2NuBYMKJ91UXOsYWVo7tEEEHvuYA1TS1gE45KW9HPWqtMiFhj1SmTYA+agXdbwv8A0+KCk15nFX8t8MgjvqgGr+SJjDLBSai381I/0KmN30WSKtLcrbi6vtRTQWey9OXUPfUedf7/Qkfd3SZKuQQ+ZS+mLsY0nWXXlmVB8/4HmdObxLHdkzoYhc4Q==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB6PR0801MB2024.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(186003)(2616005)(66446008)(76116006)(508600001)(36756003)(8936002)(91956017)(86362001)(6512007)(66476007)(66556008)(6486002)(316002)(6506007)(33656002)(53546011)(54906003)(66946007)(64756008)(71200400001)(38070700005)(7416002)(2906002)(26005)(8676002)(4326008)(38100700002)(122000001)(5660300002)(83380400001)(6916009)(2004002)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-ID: <D9C4A83810998B4286A1BA366053CBA0@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB5961
Original-Authentication-Results: citrix.com; dkim=none (message not signed)
 header.d=none;citrix.com; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM5EUR03FT061.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	ec98b962-43d7-4c20-0092-08d98e2ea457
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	+I/0iDN54pG+AHyb3gstxXIE4x8H0VQREa2zZ0aGftMMHA62BvqepXKKevop2bOegQR79Zd6AIHcQYfqJhLuEMwzErl8aJ+O/R69erawEaCPDuHVhWCjE9hXi1zL/1JFq1VGMTw3zC8BIz0x5vKHuMfQIde50HQGj7dQph8rMxil7pynuJuaUV772JTt/VPqzmKdRVlNkKH9l+fEp6FpBTILSdwt4AVrKFA2sRgTiaBB3LKGYhdrEJJfg08nqNfCsflpUo6kcZLgTMqeGfs0Iq2ZaXwn+GtCeIO+qduelwf+sN/w8/S41+mPFp5VDuZAlx9Yk+O/pRCb34dBj41KpXt3kDo+/BpdTX2vpEOyx1OjV56BaxX+qyE4YbYKLG7Ed8J8hy2tOuGROyzHWYYs8pj73FbZvr5I5XKuyK/7CvpkT+avcvx+dnnAsJJ2v3c86dojut6dT8Ru5nR7WORuu+BDf54wRBZ9gs+hQ/UmqNvlOUui92mgZBpdkPnWn8yAEKXfiHyPBee7sqi2CsBtOrq+lnsCj2A57p9h3KpCqA5NXBY3mhJF3LwPEhXzF2X04f+x2piREoBbWNnrPx6H6o7HC8hjuyBNcPI2ZmGYI4nI5YuVR82F/5eswE14w6WcwrfK9LoThm6uWyCYrgVLh1BMwYo/OBXRR4rmWRXAd10rqbOawVO0Q4IyVz8++aeKhhj87VdZUuNBjNA6xfos4oScF+ZN+l2P6oJbabc4jDEgdq4yRf/b3X6dz4qY3IoN
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(83380400001)(36756003)(82310400003)(5660300002)(6512007)(2906002)(54906003)(186003)(316002)(508600001)(26005)(47076005)(70586007)(36860700001)(6506007)(86362001)(4326008)(8676002)(70206006)(6862004)(336012)(53546011)(356005)(33656002)(8936002)(81166007)(2616005)(6486002)(63350400001)(63370400001)(2004002)(45980500001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2021 09:48:50.9841
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: e7d37081-3acc-4039-936f-08d98e2ea95a
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM5EUR03FT061.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB6929

SGkgUm9nZXIsDQoNCj4gT24gMTMgT2N0IDIwMjEsIGF0IDA5OjQ1LCBSb2dlciBQYXUgTW9ubsOp
IDxyb2dlci5wYXVAY2l0cml4LmNvbT4gd3JvdGU6DQo+IA0KPiBPbiBXZWQsIE9jdCAwNiwgMjAy
MSBhdCAwNjo0MDozNFBNICswMTAwLCBSYWh1bCBTaW5naCB3cm90ZToNCj4+IFRoZSBleGlzdGlu
ZyBWUENJIHN1cHBvcnQgYXZhaWxhYmxlIGZvciBYODYgaXMgYWRhcHRlZCBmb3IgQXJtLg0KPj4g
V2hlbiB0aGUgZGV2aWNlIGlzIGFkZGVkIHRvIFhFTiB2aWEgdGhlIGh5cGVyIGNhbGwNCj4+IOKA
nFBIWVNERVZPUF9wY2lfZGV2aWNlX2FkZOKAnSwgVlBDSSBoYW5kbGVyIGZvciB0aGUgY29uZmln
IHNwYWNlDQo+PiBhY2Nlc3MgaXMgYWRkZWQgdG8gdGhlIFhlbiB0byBlbXVsYXRlIHRoZSBQQ0kg
ZGV2aWNlcyBjb25maWcgc3BhY2UuDQo+PiANCj4+IEEgTU1JTyB0cmFwIGhhbmRsZXIgZm9yIHRo
ZSBQQ0kgRUNBTSBzcGFjZSBpcyByZWdpc3RlcmVkIGluIFhFTg0KPj4gc28gdGhhdCB3aGVuIGd1
ZXN0IGlzIHRyeWluZyB0byBhY2Nlc3MgdGhlIFBDSSBjb25maWcgc3BhY2UsWEVODQo+PiB3aWxs
IHRyYXAgdGhlIGFjY2VzcyBhbmQgZW11bGF0ZSByZWFkL3dyaXRlIHVzaW5nIHRoZSBWUENJIGFu
ZA0KPj4gbm90IHRoZSByZWFsIFBDSSBoYXJkd2FyZS4NCj4+IA0KPj4gRm9yIERvbTBsZXNzIHN5
c3RlbXMgc2Nhbl9wY2lfZGV2aWNlcygpIHdvdWxkIGJlIHVzZWQgdG8gZGlzY292ZXIgdGhlDQo+
PiBQQ0kgZGV2aWNlIGluIFhFTiBhbmQgVlBDSSBoYW5kbGVyIHdpbGwgYmUgYWRkZWQgZHVyaW5n
IFhFTiBib290cy4NCj4+IA0KPj4gU2lnbmVkLW9mZi1ieTogUmFodWwgU2luZ2ggPHJhaHVsLnNp
bmdoQGFybS5jb20+DQo+PiBSZXZpZXdlZC1ieTogU3RlZmFubyBTdGFiZWxsaW5pIDxzc3RhYmVs
bGluaUBrZXJuZWwub3JnPg0KPj4gLS0tDQo+PiBDaGFuZ2UgaW4gdjU6DQo+PiAtIEFkZCBwY2lf
Y2xlYW51cF9tc2kocGRldikgaW4gY2xlYW51cCBwYXJ0Lg0KPj4gLSBBZGRlZCBSZXZpZXdlZC1i
eTogU3RlZmFubyBTdGFiZWxsaW5pIDxzc3RhYmVsbGluaUBrZXJuZWwub3JnPg0KPj4gQ2hhbmdl
IGluIHY0Og0KPj4gLSBNb3ZlIGFkZGl0aW9uIG9mIFhFTl9ET01DVExfQ0RGX3ZwY2kgZmxhZyB0
byBzZXBhcmF0ZSBwYXRjaA0KPj4gQ2hhbmdlIGluIHYzOg0KPj4gLSBVc2UgaXNfcGNpX3Bhc3N0
aHJvdWdoX2VuYWJsZWQoKSBpbiBwbGFjZSBvZiBwY2lfcGFzc3Rocm91Z2hfZW5hYmxlZCB2YXJp
YWJsZQ0KPj4gLSBSZWplY3QgWEVOX0RPTUNUTF9DREZfdnBjaSBmb3IgeDg2IGluIGFyY2hfc2Fu
aXRpc2VfZG9tYWluX2NvbmZpZygpDQo+PiAtIFJlbW92ZSBJU19FTkFCTEVEKENPTkZJR19IQVNf
VlBDSSkgZnJvbSBoYXNfdnBjaSgpDQo+PiBDaGFuZ2UgaW4gdjI6DQo+PiAtIEFkZCBuZXcgWEVO
X0RPTUNUTF9DREZfdnBjaSBmbGFnDQo+PiAtIG1vZGlmeSBoYXNfdnBjaSgpIHRvIGluY2x1ZGUg
WEVOX0RPTUNUTF9DREZfdnBjaQ0KPj4gLSBlbmFibGUgdnBjaSBzdXBwb3J0IHdoZW4gcGNpLXBh
c3N0aG91Z2ggb3B0aW9uIGlzIGVuYWJsZWQuDQo+PiAtLS0NCj4+IC0tLQ0KPj4geGVuL2FyY2gv
YXJtL01ha2VmaWxlICAgICAgICAgfCAgIDEgKw0KPj4geGVuL2FyY2gvYXJtL2RvbWFpbi5jICAg
ICAgICAgfCAgIDQgKysNCj4+IHhlbi9hcmNoL2FybS9kb21haW5fYnVpbGQuYyAgIHwgICAzICsN
Cj4+IHhlbi9hcmNoL2FybS92cGNpLmMgICAgICAgICAgIHwgMTAyICsrKysrKysrKysrKysrKysr
KysrKysrKysrKysrKysrKysNCj4+IHhlbi9hcmNoL2FybS92cGNpLmggICAgICAgICAgIHwgIDM2
ICsrKysrKysrKysrKw0KPj4geGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvcGNpLmMgfCAgMTggKysr
KysrDQo+PiB4ZW4vaW5jbHVkZS9hc20tYXJtL2RvbWFpbi5oICB8ICAgNyArKy0NCj4+IHhlbi9p
bmNsdWRlL2FzbS14ODYvcGNpLmggICAgIHwgICAyIC0NCj4+IHhlbi9pbmNsdWRlL3B1YmxpYy9h
cmNoLWFybS5oIHwgICA3ICsrKw0KPj4geGVuL2luY2x1ZGUveGVuL3BjaS5oICAgICAgICAgfCAg
IDIgKw0KPj4gMTAgZmlsZXMgY2hhbmdlZCwgMTc5IGluc2VydGlvbnMoKyksIDMgZGVsZXRpb25z
KC0pDQo+PiBjcmVhdGUgbW9kZSAxMDA2NDQgeGVuL2FyY2gvYXJtL3ZwY2kuYw0KPj4gY3JlYXRl
IG1vZGUgMTAwNjQ0IHhlbi9hcmNoL2FybS92cGNpLmgNCj4+IA0KPj4gZGlmZiAtLWdpdCBhL3hl
bi9hcmNoL2FybS9NYWtlZmlsZSBiL3hlbi9hcmNoL2FybS9NYWtlZmlsZQ0KPj4gaW5kZXggNDRk
N2NjODFmYS4uZmI5Yzk3NmVhMiAxMDA2NDQNCj4+IC0tLSBhL3hlbi9hcmNoL2FybS9NYWtlZmls
ZQ0KPj4gKysrIGIveGVuL2FyY2gvYXJtL01ha2VmaWxlDQo+PiBAQCAtNyw2ICs3LDcgQEAgaWZu
ZXEgKCQoQ09ORklHX05PX1BMQVQpLHkpDQo+PiBvYmoteSArPSBwbGF0Zm9ybXMvDQo+PiBlbmRp
Zg0KPj4gb2JqLSQoQ09ORklHX1RFRSkgKz0gdGVlLw0KPj4gK29iai0kKENPTkZJR19IQVNfVlBD
SSkgKz0gdnBjaS5vDQo+PiANCj4+IG9iai0kKENPTkZJR19IQVNfQUxURVJOQVRJVkUpICs9IGFs
dGVybmF0aXZlLm8NCj4+IG9iai15ICs9IGJvb3RmZHQuaW5pdC5vDQo+PiBkaWZmIC0tZ2l0IGEv
eGVuL2FyY2gvYXJtL2RvbWFpbi5jIGIveGVuL2FyY2gvYXJtL2RvbWFpbi5jDQo+PiBpbmRleCAz
NjEzOGMxYjJlLi5mYmI1MmY3OGYxIDEwMDY0NA0KPj4gLS0tIGEveGVuL2FyY2gvYXJtL2RvbWFp
bi5jDQo+PiArKysgYi94ZW4vYXJjaC9hcm0vZG9tYWluLmMNCj4+IEBAIC0zOSw2ICszOSw3IEBA
DQo+PiAjaW5jbHVkZSA8YXNtL3ZnaWMuaD4NCj4+ICNpbmNsdWRlIDxhc20vdnRpbWVyLmg+DQo+
PiANCj4+ICsjaW5jbHVkZSAidnBjaS5oIg0KPj4gI2luY2x1ZGUgInZ1YXJ0LmgiDQo+PiANCj4+
IERFRklORV9QRVJfQ1BVKHN0cnVjdCB2Y3B1ICosIGN1cnJfdmNwdSk7DQo+PiBAQCAtNzY3LDYg
Kzc2OCw5IEBAIGludCBhcmNoX2RvbWFpbl9jcmVhdGUoc3RydWN0IGRvbWFpbiAqZCwNCj4+ICAg
ICBpZiAoIGlzX2hhcmR3YXJlX2RvbWFpbihkKSAmJiAocmMgPSBkb21haW5fdnVhcnRfaW5pdChk
KSkgKQ0KPj4gICAgICAgICBnb3RvIGZhaWw7DQo+PiANCj4+ICsgICAgaWYgKCAocmMgPSBkb21h
aW5fdnBjaV9pbml0KGQpKSAhPSAwICkNCj4+ICsgICAgICAgIGdvdG8gZmFpbDsNCj4+ICsNCj4+
ICAgICByZXR1cm4gMDsNCj4+IA0KPj4gZmFpbDoNCj4+IGRpZmYgLS1naXQgYS94ZW4vYXJjaC9h
cm0vZG9tYWluX2J1aWxkLmMgYi94ZW4vYXJjaC9hcm0vZG9tYWluX2J1aWxkLmMNCj4+IGluZGV4
IGM1YWZiZTJlMDUuLmY0Yzg5YmRlOGMgMTAwNjQ0DQo+PiAtLS0gYS94ZW4vYXJjaC9hcm0vZG9t
YWluX2J1aWxkLmMNCj4+ICsrKyBiL3hlbi9hcmNoL2FybS9kb21haW5fYnVpbGQuYw0KPj4gQEAg
LTMwNTMsNiArMzA1Myw5IEBAIHZvaWQgX19pbml0IGNyZWF0ZV9kb20wKHZvaWQpDQo+PiAgICAg
aWYgKCBpb21tdV9lbmFibGVkICkNCj4+ICAgICAgICAgZG9tMF9jZmcuZmxhZ3MgfD0gWEVOX0RP
TUNUTF9DREZfaW9tbXU7DQo+PiANCj4+ICsgICAgaWYgKCBpc19wY2lfcGFzc3Rocm91Z2hfZW5h
YmxlZCgpICkNCj4+ICsgICAgICAgIGRvbTBfY2ZnLmZsYWdzIHw9IFhFTl9ET01DVExfQ0RGX3Zw
Y2k7DQo+PiArDQo+PiAgICAgZG9tMCA9IGRvbWFpbl9jcmVhdGUoMCwgJmRvbTBfY2ZnLCB0cnVl
KTsNCj4+ICAgICBpZiAoIElTX0VSUihkb20wKSB8fCAoYWxsb2NfZG9tMF92Y3B1MChkb20wKSA9
PSBOVUxMKSApDQo+PiAgICAgICAgIHBhbmljKCJFcnJvciBjcmVhdGluZyBkb21haW4gMFxuIik7
DQo+PiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gvYXJtL3ZwY2kuYyBiL3hlbi9hcmNoL2FybS92cGNp
LmMNCj4+IG5ldyBmaWxlIG1vZGUgMTAwNjQ0DQo+PiBpbmRleCAwMDAwMDAwMDAwLi43NmMxMmI5
MjgxDQo+PiAtLS0gL2Rldi9udWxsDQo+PiArKysgYi94ZW4vYXJjaC9hcm0vdnBjaS5jDQo+PiBA
QCAtMCwwICsxLDEwMiBAQA0KPj4gKy8qDQo+PiArICogeGVuL2FyY2gvYXJtL3ZwY2kuYw0KPj4g
KyAqDQo+PiArICogVGhpcyBwcm9ncmFtIGlzIGZyZWUgc29mdHdhcmU7IHlvdSBjYW4gcmVkaXN0
cmlidXRlIGl0IGFuZC9vciBtb2RpZnkNCj4+ICsgKiBpdCB1bmRlciB0aGUgdGVybXMgb2YgdGhl
IEdOVSBHZW5lcmFsIFB1YmxpYyBMaWNlbnNlIGFzIHB1Ymxpc2hlZCBieQ0KPj4gKyAqIHRoZSBG
cmVlIFNvZnR3YXJlIEZvdW5kYXRpb247IGVpdGhlciB2ZXJzaW9uIDIgb2YgdGhlIExpY2Vuc2Us
IG9yDQo+PiArICogKGF0IHlvdXIgb3B0aW9uKSBhbnkgbGF0ZXIgdmVyc2lvbi4NCj4+ICsgKg0K
Pj4gKyAqIFRoaXMgcHJvZ3JhbSBpcyBkaXN0cmlidXRlZCBpbiB0aGUgaG9wZSB0aGF0IGl0IHdp
bGwgYmUgdXNlZnVsLA0KPj4gKyAqIGJ1dCBXSVRIT1VUIEFOWSBXQVJSQU5UWTsgd2l0aG91dCBl
dmVuIHRoZSBpbXBsaWVkIHdhcnJhbnR5IG9mDQo+PiArICogTUVSQ0hBTlRBQklMSVRZIG9yIEZJ
VE5FU1MgRk9SIEEgUEFSVElDVUxBUiBQVVJQT1NFLiAgU2VlIHRoZQ0KPj4gKyAqIEdOVSBHZW5l
cmFsIFB1YmxpYyBMaWNlbnNlIGZvciBtb3JlIGRldGFpbHMuDQo+PiArICovDQo+PiArI2luY2x1
ZGUgPHhlbi9zY2hlZC5oPg0KPj4gKw0KPj4gKyNpbmNsdWRlIDxhc20vbW1pby5oPg0KPj4gKw0K
Pj4gKyNkZWZpbmUgUkVHSVNURVJfT0ZGU0VUKGFkZHIpICAoIChhZGRyKSAmIDB4MDAwMDBmZmYp
DQo+PiArDQo+PiArLyogRG8gc29tZSBzYW5pdHkgY2hlY2tzLiAqLw0KPj4gK3N0YXRpYyBib29s
IHZwY2lfbW1pb19hY2Nlc3NfYWxsb3dlZCh1bnNpZ25lZCBpbnQgcmVnLCB1bnNpZ25lZCBpbnQg
bGVuKQ0KPj4gK3sNCj4+ICsgICAgLyogQ2hlY2sgYWNjZXNzIHNpemUuICovDQo+PiArICAgIGlm
ICggbGVuID4gOCApDQo+PiArICAgICAgICByZXR1cm4gZmFsc2U7DQo+PiArDQo+PiArICAgIC8q
IENoZWNrIHRoYXQgYWNjZXNzIGlzIHNpemUgYWxpZ25lZC4gKi8NCj4+ICsgICAgaWYgKCAocmVn
ICYgKGxlbiAtIDEpKSApDQo+PiArICAgICAgICByZXR1cm4gZmFsc2U7DQo+PiArDQo+PiArICAg
IHJldHVybiB0cnVlOw0KPj4gK30NCj4+ICsNCj4+ICtzdGF0aWMgaW50IHZwY2lfbW1pb19yZWFk
KHN0cnVjdCB2Y3B1ICp2LCBtbWlvX2luZm9fdCAqaW5mbywNCj4+ICsgICAgICAgICAgICAgICAg
ICAgICAgICAgIHJlZ2lzdGVyX3QgKnIsIHZvaWQgKnApDQo+PiArew0KPj4gKyAgICB1bnNpZ25l
ZCBpbnQgcmVnOw0KPj4gKyAgICBwY2lfc2JkZl90IHNiZGY7DQo+PiArICAgIHVuc2lnbmVkIGxv
bmcgZGF0YSA9IH4wVUw7DQo+PiArICAgIHVuc2lnbmVkIGludCBzaXplID0gMVUgPDwgaW5mby0+
ZGFidC5zaXplOw0KPj4gKw0KPj4gKyAgICBzYmRmLnNiZGYgPSBNTUNGR19CREYoaW5mby0+Z3Bh
KTsNCj4+ICsgICAgcmVnID0gUkVHSVNURVJfT0ZGU0VUKGluZm8tPmdwYSk7DQo+PiArDQo+PiAr
ICAgIGlmICggIXZwY2lfbW1pb19hY2Nlc3NfYWxsb3dlZChyZWcsIHNpemUpICkNCj4+ICsgICAg
ICAgIHJldHVybiAwOw0KPj4gKw0KPj4gKyAgICBkYXRhID0gdnBjaV9yZWFkKHNiZGYsIHJlZywg
bWluKDR1LCBzaXplKSk7DQo+PiArICAgIGlmICggc2l6ZSA9PSA4ICkNCj4+ICsgICAgICAgIGRh
dGEgfD0gKHVpbnQ2NF90KXZwY2lfcmVhZChzYmRmLCByZWcgKyA0LCA0KSA8PCAzMjsNCj4+ICsN
Cj4+ICsgICAgKnIgPSBkYXRhOw0KPj4gKw0KPj4gKyAgICByZXR1cm4gMTsNCj4+ICt9DQo+PiAr
DQo+PiArc3RhdGljIGludCB2cGNpX21taW9fd3JpdGUoc3RydWN0IHZjcHUgKnYsIG1taW9faW5m
b190ICppbmZvLA0KPj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgIHJlZ2lzdGVyX3Qgciwg
dm9pZCAqcCkNCj4+ICt7DQo+PiArICAgIHVuc2lnbmVkIGludCByZWc7DQo+PiArICAgIHBjaV9z
YmRmX3Qgc2JkZjsNCj4+ICsgICAgdW5zaWduZWQgbG9uZyBkYXRhID0gcjsNCj4+ICsgICAgdW5z
aWduZWQgaW50IHNpemUgPSAxVSA8PCBpbmZvLT5kYWJ0LnNpemU7DQo+PiArDQo+PiArICAgIHNi
ZGYuc2JkZiA9IE1NQ0ZHX0JERihpbmZvLT5ncGEpOw0KPj4gKyAgICByZWcgPSBSRUdJU1RFUl9P
RkZTRVQoaW5mby0+Z3BhKTsNCj4+ICsNCj4+ICsgICAgaWYgKCAhdnBjaV9tbWlvX2FjY2Vzc19h
bGxvd2VkKHJlZywgc2l6ZSkgKQ0KPj4gKyAgICAgICAgcmV0dXJuIDA7DQo+PiArDQo+PiArICAg
IHZwY2lfd3JpdGUoc2JkZiwgcmVnLCBtaW4oNHUsIHNpemUpLCBkYXRhKTsNCj4+ICsgICAgaWYg
KCBzaXplID09IDggKQ0KPj4gKyAgICAgICAgdnBjaV93cml0ZShzYmRmLCByZWcgKyA0LCA0LCBk
YXRhID4+IDMyKTsNCj4gDQo+IEkgdGhpbmsgdGhvc2UgdHdvIGhlbHBlcnMgKGFuZCB2cGNpX21t
aW9fYWNjZXNzX2FsbG93ZWQpIGFyZSB2ZXJ5DQo+IHNpbWlsYXIgdG8gdGhlIGV4aXN0aW5nIHg4
NiBvbmVzIChzZWUgdnBjaV9tbWNmZ197cmVhZCx3cml0ZX0pLCB1cCB0bw0KPiB0aGUgcG9pbnQg
d2hlcmUgSSB3b3VsZCBjb25zaWRlciBtb3ZpbmcgdGhlIHNoYXJlZCBjb2RlIHRvIHZwY2kuYyBh
cw0KPiB2cGNpX2VjYW1fe3JlYWQsd3JpdGV9IGFuZCBjYWxsIHRoZW0gZnJvbSB0aGUgYXJjaCBz
cGVjaWZpYyB0cmFwDQo+IGhhbmRsZXJzLg0KDQpXb3VsZCBpdCBiZSBvayB0byBoYXZlIGVjYW0g
c3BlY2lmaWMgY29kZSBpbiB0aGUgdnBjaSBjb21tb24gY29kZSA/DQoNClRoaXMgaXMgYW4gb3B0
aW1pc2F0aW9uIGFuZCB3ZSBjb3VsZCBkbyB0aGF0IGxhdGVyIG9uIGFzIHRoaXMgaXMgYW4gb3Ro
ZXINCmNoYW5nZSB0byBiZSBkb25lIGFuZCB0ZXN0ZWQgd2hpY2ggd2lsbCBzdGFydCB0byBtYWtl
IHRoaW5ncyB2ZXJ5DQpjaGFsbGVuZ2luZyB3aXRoIHRoZSBmcmlkYXkgZGVhZGxpbmUuDQoNCkNo
ZWVycw0KQmVydHJhbmQNCg0K


From xen-devel-bounces@lists.xenproject.org Wed Oct 13 09:52:39 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 09:52:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.208153.364192 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maawA-0005EY-8f; Wed, 13 Oct 2021 09:52:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 208153.364192; Wed, 13 Oct 2021 09:52:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maawA-0005ER-5j; Wed, 13 Oct 2021 09:52:38 +0000
Received: by outflank-mailman (input) for mailman id 208153;
 Wed, 13 Oct 2021 09:52:36 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=quvz=PB=suse.com=jgross@srs-us1.protection.inumbo.net>)
 id 1maaw8-0005EL-HZ
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 09:52:36 +0000
Received: from smtp-out2.suse.de (unknown [195.135.220.29])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 8f4b697a-ab7b-46ba-bc8c-4c58ff06e7c9;
 Wed, 13 Oct 2021 09:52:35 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id CDA6E201CA;
 Wed, 13 Oct 2021 09:52:34 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 9F95D13CEC;
 Wed, 13 Oct 2021 09:52:34 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id VdEmJWKsZmE/OgAAMHmgww
 (envelope-from <jgross@suse.com>); Wed, 13 Oct 2021 09:52:34 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8f4b697a-ab7b-46ba-bc8c-4c58ff06e7c9
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1634118754; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=SZ63tRYxBuNCk5b65eKHthYeTyWErK25Bc1+cY1qj3o=;
	b=Vp80ZvD0ZT9eFXsmRa7WYzxIurfUadSpoFwi6SYVakaNvduHgsldTTClfxr3sNMItv5UQW
	T30S6TzcMXvjeZeDz9lvp4DvdFlCX2RL9zPwaEhpFVu/rL+8KBlx02kXVzfRemxNYpI9Th
	8TIZtiTSd5GAAC8JcsB/gbSxEEeunVA=
To: Kevin Stefanov <kevin.stefanov@citrix.com>,
 Xen-devel <xen-devel@lists.xenproject.org>
Cc: Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>,
 Julien Grall <julien@xen.org>, Andrew Cooper <andrew.cooper3@citrix.com>
References: <20211013093546.17203-1-kevin.stefanov@citrix.com>
From: Juergen Gross <jgross@suse.com>
Subject: Re: [PATCH] tools/tests: Make E2BIG non-fatal to xenstore unit test
Message-ID: <571c8595-d257-7a94-5d7c-282f00a9631c@suse.com>
Date: Wed, 13 Oct 2021 11:52:33 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <20211013093546.17203-1-kevin.stefanov@citrix.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="Szf9WSZJ6U48QBFpppDgzTu5ER8ZJMugo"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--Szf9WSZJ6U48QBFpppDgzTu5ER8ZJMugo
Content-Type: multipart/mixed; boundary="f1JPBAK5l97KMjA1UGfwYxbze3HCadrgW";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Kevin Stefanov <kevin.stefanov@citrix.com>,
 Xen-devel <xen-devel@lists.xenproject.org>
Cc: Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>,
 Julien Grall <julien@xen.org>, Andrew Cooper <andrew.cooper3@citrix.com>
Message-ID: <571c8595-d257-7a94-5d7c-282f00a9631c@suse.com>
Subject: Re: [PATCH] tools/tests: Make E2BIG non-fatal to xenstore unit test
References: <20211013093546.17203-1-kevin.stefanov@citrix.com>
In-Reply-To: <20211013093546.17203-1-kevin.stefanov@citrix.com>

--f1JPBAK5l97KMjA1UGfwYxbze3HCadrgW
Content-Type: multipart/mixed;
 boundary="------------20DDA9258F5517875FD5F554"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------20DDA9258F5517875FD5F554
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 13.10.21 11:35, Kevin Stefanov wrote:
> Xenstore's unit test fails on read and write of big numbers if
> quota-maxsize is set to a lower number than those test cases use.
>=20
> Output a special warning instead of a failure message in such cases
> and make the error non-fatal to the unit test.
>=20
> Signed-off-by: Kevin Stefanov <kevin.stefanov@citrix.com>
> ---
> CC: Ian Jackson <iwj@xenproject.org>
> CC: Wei Liu <wl@xen.org>
> CC: Juergen Gross <jgross@suse.com>
> CC: Julien Grall <julien@xen.org>
> CC: Andrew Cooper <andrew.cooper3@citrix.com>
> ---
>   tools/tests/xenstore/test-xenstore.c | 9 +++++++--
>   1 file changed, 7 insertions(+), 2 deletions(-)
>=20
> diff --git a/tools/tests/xenstore/test-xenstore.c b/tools/tests/xenstor=
e/test-xenstore.c
> index d3574b3fa2..ec8c63a65d 100644
> --- a/tools/tests/xenstore/test-xenstore.c
> +++ b/tools/tests/xenstore/test-xenstore.c
> @@ -110,8 +110,13 @@ static int call_test(struct test *tst, int iters, =
bool no_clock)
>               break;
>       }
>  =20
> -    if ( ret )
> -        printf("%-10s: failed (ret =3D %d, stage %s)\n", tst->name, re=
t, stage);
> +    /* Make E2BIG non-fatal to the test */
> +    if ( ret ){
> +	if( ret =3D=3D 7 )

Why not use E2BIG instead of the literal 7 here?

And please adhere to the coding style! There are some blanks missing and
the '{' wants to go into a separate line.

> +            printf("%-10s: Not run - argument list too long\n", tst->n=
ame);

Not setting ret to 0 here will result in Xenstore not being cleaned up
after the test.

> +        else
> +            printf("%-10s: failed (ret =3D %d, stage %s)\n", tst->name=
, ret, stage);
> +    }
>       else if ( !no_clock )
>       {
>           printf("%-10s:", tst->name);
>=20


Juergen

--------------20DDA9258F5517875FD5F554
Content-Type: application/pgp-keys;
 name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Transfer-Encoding: quoted-printable
Content-Description: OpenPGP public key
Content-Disposition: attachment;
 filename="OpenPGP_0xB0DE9DD628BF132F.asc"

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy=
cWx
w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O=
f8Z
d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y=
9bf
IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq=
G7/
377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR=
3Jv
c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA=
QIe
AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT=
hpw
dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0=
MbD
1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv=
oPH
Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v=
5QL
+qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ=
2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC=
QoL
BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr=
Wf0
teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC=
/nu
AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh=
ITT
d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm=
XBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz=
80h
SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC=
AcD
AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn=
FOX
gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1=
jnD
kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0=
N51
N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l=
otu
fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1=
tqS
EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA=
hsD
BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3=
g3O
ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5=
dM7
wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5=
D+j
LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm=
V2x
AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N=
Eaw
QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW=
nHI
s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR=
wgn
BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV=
bVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk=
pEd
IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA=
QAB
wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw=
Tbe
8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1=
vJz
Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8=
VGi
wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW=
svi
uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX=
zXs
ZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------20DDA9258F5517875FD5F554--

--f1JPBAK5l97KMjA1UGfwYxbze3HCadrgW--

--Szf9WSZJ6U48QBFpppDgzTu5ER8ZJMugo
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmFmrGEFAwAAAAAACgkQsN6d1ii/Ey8H
Mgf7BteRW4uSQDkLW+Hg1qLs5+2MjhMPe6qSkQInYoSukWnrRfqcviJcn5R/3NHYfu1+bRm6poP6
vFcqPIh6rfA9rUFEqgRDvyY9oaoKvQ1SHsLFKZ6cq4qIzAhKUl/ewtuAAkvlTsphI2ApIxyc7C+S
EHMqc7m+XKXTEHhVsYh2mGdG9j3C6+gr7UfjsXoetf3JeF1MO3YymggG38fY11jhxRt6i/hwRTJR
5r8QkE5uHBDuM9p37o9cliKs+atmDZ6iW+kQrrIPuVESi32YOl+tOLR38U5U+L+KKKzeTLGC5jpg
L/p0l39qtKZhowOYhlUDjPvYwqVb/yeD1WGYb12kHA==
=nuJp
-----END PGP SIGNATURE-----

--Szf9WSZJ6U48QBFpppDgzTu5ER8ZJMugo--


From xen-devel-bounces@lists.xenproject.org Wed Oct 13 09:53:52 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 09:53:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.208161.364202 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maaxL-0005s1-O0; Wed, 13 Oct 2021 09:53:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 208161.364202; Wed, 13 Oct 2021 09:53:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maaxL-0005ru-L6; Wed, 13 Oct 2021 09:53:51 +0000
Received: by outflank-mailman (input) for mailman id 208161;
 Wed, 13 Oct 2021 09:53:50 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1maaxK-0005ri-Oz; Wed, 13 Oct 2021 09:53:50 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1maaxK-0001fv-KM; Wed, 13 Oct 2021 09:53:50 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1maaxK-0002Ta-E8; Wed, 13 Oct 2021 09:53:50 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1maaxK-0005ql-De; Wed, 13 Oct 2021 09:53:50 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=PLAiH6vnY6DFnKqdANXhN9nmXNklGtMUr1hrUbnFSx4=; b=bq3HPOnt/g3bur8j3gW8QAhEGS
	obt9cyJcePG0IDZst6qToicjA2vEzchGSvwppZRVGspKcc54silroF713rjFMhK9GDc9cKZsExtd1
	bL6Iwx/vcC66lBmIn4QbhFfw1ZkqjbKKvcvUk+jH5k/P40MQIzhHXdcuqAtPm/kRXePI=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165493-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-coverity test] 165493: all pass - PUSHED
X-Osstest-Versions-This:
    xen=f9294486926c865a3ef11cacd7cb6b26cce6f4a4
X-Osstest-Versions-That:
    xen=664cc3c3d381e4f9a61dcb68cbd7a6a00070370e
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 13 Oct 2021 09:53:50 +0000

flight 165493 xen-unstable-coverity real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165493/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 xen                  f9294486926c865a3ef11cacd7cb6b26cce6f4a4
baseline version:
 xen                  664cc3c3d381e4f9a61dcb68cbd7a6a00070370e

Last test of basis   165453  2021-10-10 09:19:39 Z    3 days
Testing same since   165493  2021-10-13 09:20:53 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Anthony PERARD <anthony.perard@citrix.com>
  Christian Lindig <christian.lindig@citrix.com>
  Christopher Clark <christopher.w.clark@gmail.com>
  Dmitry Isaykin <isaikin-dmitry@yandex.ru>
  Ian Jackson <iwj@xenproject.org>
  Jan Beulich <jbeulich@suse.com>
  Julien Grall <jgrall@amazon.com>
  Luca Fancellu <luca.fancellu@arm.com>
  Michal Orzel <michal.orzel@arm.com>
  Nick Rosbrook <rosbrookn@ainfosec.com>
  Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
  Rahul Singh <rahul.singh@arm.com>
  Roger Pau Monne <roger.pau@citrix.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Stefano Stabellini <sstabellini@kernel.org>
  Stefano Stabellini <stefano.stabellini@xilinx.com>

jobs:
 coverity-amd64                                               pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   664cc3c3d3..f929448692  f9294486926c865a3ef11cacd7cb6b26cce6f4a4 -> coverity-tested/smoke


From xen-devel-bounces@lists.xenproject.org Wed Oct 13 10:02:24 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 10:02:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.208171.364217 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mab5X-0007R4-KV; Wed, 13 Oct 2021 10:02:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 208171.364217; Wed, 13 Oct 2021 10:02:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mab5X-0007Qx-Gy; Wed, 13 Oct 2021 10:02:19 +0000
Received: by outflank-mailman (input) for mailman id 208171;
 Wed, 13 Oct 2021 10:02:18 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=0M7b=PB=arm.com=Bertrand.Marquis@srs-us1.protection.inumbo.net>)
 id 1mab5W-0007Qr-Jn
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 10:02:18 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com (unknown
 [40.107.20.55]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id a5b6ef42-2c0c-11ec-8168-12813bfff9fa;
 Wed, 13 Oct 2021 10:02:17 +0000 (UTC)
Received: from AS8PR05CA0004.eurprd05.prod.outlook.com (2603:10a6:20b:311::9)
 by DBBPR08MB6300.eurprd08.prod.outlook.com (2603:10a6:10:209::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18; Wed, 13 Oct
 2021 10:02:16 +0000
Received: from VE1EUR03FT044.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:311:cafe::d) by AS8PR05CA0004.outlook.office365.com
 (2603:10a6:20b:311::9) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.26 via Frontend
 Transport; Wed, 13 Oct 2021 10:02:16 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT044.mail.protection.outlook.com (10.152.19.106) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4587.18 via Frontend Transport; Wed, 13 Oct 2021 10:02:15 +0000
Received: ("Tessian outbound d5def7722ff7:v103");
 Wed, 13 Oct 2021 10:02:15 +0000
Received: from cc36979be8e6.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 9B6FCC67-C7BC-49F8-B3B3-99B8BE93CCD1.1; 
 Wed, 13 Oct 2021 10:02:04 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id cc36979be8e6.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Wed, 13 Oct 2021 10:02:04 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com (2603:10a6:4:74::9)
 by DB7PR08MB3660.eurprd08.prod.outlook.com (2603:10a6:10:46::11) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.19; Wed, 13 Oct
 2021 10:02:01 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955]) by DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955%4]) with mapi id 15.20.4587.026; Wed, 13 Oct 2021
 10:02:01 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a5b6ef42-2c0c-11ec-8168-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=rDr41HcM0x0JwfgkdMC8DHHsRnkRZDVRMQ66f2DsX4g=;
 b=3soQacc6GsXiXfLwY8DywBtS3GiYeXldiOL10/GFI/AqrGfznwb2vlCYmcmapEF/KePtNFVJ2/A9bJ2r8RMkOfXGPSIkvez8SesbOhElyepQQ95fb0/CC01JfrpmBmExNXRMYf5/M6AAv2YBOShTzLCaOx924by+G9tBxJEYQzo=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: c52b391468107ede
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Zk53OGEMmGIG+uPtFcRzBzbp4fPDdK5iXTmyJdBkwF04T6/z861V9pw+vvJbBWf/eRY6x7OoZkaeY+uH4z938pBWmB1bk8s+dRVJSHiOTu/ePlz0eMJ8lNI6wJC2WbZ43CKzgE24KgqoIYRwml3ZGaVPWU430U1Fjk/vARSH1aOSfBU8CuIHWlZ/8pyEzb0qrFzqMTQGpeVrWierQxM3g1V52S4CDv9/dLeN4CpqfVhZ9QDclPBGKs0aseanGGiEc3gYxXzeN+gxDw30qcFctB7vg8spX3JRG8nvBMOQuUNiZdnx8tzyuLXihYhmqrubfJ5zn1bEK+0Awlx/jC3V5Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=rDr41HcM0x0JwfgkdMC8DHHsRnkRZDVRMQ66f2DsX4g=;
 b=LRNBa9nn6GaY4le8/LspPY+Ojuf9Q9th5tmRsfi2gcaABwAAeT7brJcrai4nAYeqVX9y6qLzSbiLWPIt8p0YwRGioayjNKTWAgR86+m6RSyk4cBjAZrFntUWJBgHUG3sgIPq/1neUXo0OlF6hMiANyFFAPWtRRFe7yrBcJwQP6uhc1Tj237j3EWae3at6FKfgTWLrqubPKIFRNH8CfjlBL9lrMvllpPpGa+JrLKzzEsYhpQ3RZU9K0xqa2QKX7DFCdFz2JR+g20OBgQiRdOPs3iwKDaw9yqVO0kGmZlE/IZ25ZWf7p87Ce2jh0pw9wE8RmDLzCPVMddIic6nR7e3lw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=rDr41HcM0x0JwfgkdMC8DHHsRnkRZDVRMQ66f2DsX4g=;
 b=3soQacc6GsXiXfLwY8DywBtS3GiYeXldiOL10/GFI/AqrGfznwb2vlCYmcmapEF/KePtNFVJ2/A9bJ2r8RMkOfXGPSIkvez8SesbOhElyepQQ95fb0/CC01JfrpmBmExNXRMYf5/M6AAv2YBOShTzLCaOx924by+G9tBxJEYQzo=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Stefano Stabellini <sstabellini@kernel.org>, Rahul Singh
	<Rahul.Singh@arm.com>, Andre Przywara <Andre.Przywara@arm.com>, Julien Grall
	<julien@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, Andrew
 Cooper <andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>,
	Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>, Paul Durrant
	<paul@xen.org>, =?iso-8859-1?Q?Roger_Pau_Monn=E9?= <roger.pau@citrix.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v5 08/11] xen/arm: Enable the existing x86 virtual PCI
 support for ARM.
Thread-Topic: [PATCH v5 08/11] xen/arm: Enable the existing x86 virtual PCI
 support for ARM.
Thread-Index:
 AQHXutl3YqS5dHXsYk6KpdKt4d14RavHjPqAgAY38oCAAAe6AIAAByIAgAAKAoCAAEVOAIAA5tqAgADjBgCAAI9hAIAAQK4A
Date: Wed, 13 Oct 2021 10:02:01 +0000
Message-ID: <DDD004E5-E8E7-485A-9FDE-298744C32DDE@arm.com>
References: <cover.1633540842.git.rahul.singh@arm.com>
 <9bdca2cda5d2e83f94dc2423e55714273539760a.1633540842.git.rahul.singh@arm.com>
 <6752f2d3-171b-37f5-c809-82995a8f3f36@suse.com>
 <CEF7FFB0-779A-4F46-8667-6BCD9BA5CB6C@arm.com>
 <b735c2d3-1dbb-ce0a-c2fa-160d4c6938d3@suse.com>
 <A8DEBD07-FB45-4E4E-A2C3-7AF8B393B032@arm.com>
 <59c9e102-c710-64d3-2a1a-cc8dcbcceead@suse.com>
 <alpine.DEB.2.21.2110111105180.25528@sstabellini-ThinkPad-T480s>
 <2fa4d2e2-7daf-6d52-ff4c-38a482af1fb9@suse.com>
 <alpine.DEB.2.21.2110121436020.9408@sstabellini-ThinkPad-T480s>
 <f15de716-4c4f-47b8-b6ba-ea549c61369c@suse.com>
In-Reply-To: <f15de716-4c4f-47b8-b6ba-ea549c61369c@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3654.120.0.1.13)
Authentication-Results-Original: suse.com; dkim=none (message not signed)
 header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: c90d4472-d947-4fbe-8975-08d98e308920
x-ms-traffictypediagnostic: DB7PR08MB3660:|DBBPR08MB6300:
x-ms-exchange-transport-forked: True
X-Microsoft-Antispam-PRVS:
	<DBBPR08MB6300D406F245943E0241AB389DB79@DBBPR08MB6300.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:10000;OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 ACl4Pm4JUoqtYb+4ha18Em+SGFFAWjMn9yfHRsemNJb82GFAH9yO9nATw3x9Q4fCiZOyn69gpH+VbeO06e57LOYxJKKGY8em+xSnTrDp5cINuax/q08hOuW4wZCVx6mto8D7x8k2QVXbl836H/4O/gnKS5pNMsMZ26pOH3ZM1U81CJJYDt2uHVOjIGcuDHCzCWHymSN1iEQzpcCSwyhlmjp7hKQ07Js9xpt4MUhCwg3u4s4+dSTN7G8EQ6QvF7ZrD4hWtO/A6rOI8OIypRqcoxAgD4eUa0zlObj5Cgdnaj3nd3fWVPnan1ys6zuMq328dY3XoMss1kBVvdNHmmlbBQz9tW/t6Qy3H8tnF6lHNqlb+F5DHWgy+YMr+KVkHf4fCoGFw6aeeP1yvh3dQBwpOXgdF/1sUJXP2Ei4m23sN+yaqb66zjTBdeU0mpHjGeIgBLsC12HOAiVLI+gNDZITSwD1gzsYiCoCDZJxq2BVhGUIgJc7c+4bbCNHOpmXS3wlbm2Bx2t8Zg9dRAQMnR1nmjS4d2t5qoqT1XP5GHaDel9nBnsBH7WxRDTT/q/rB6b+usnrAad9inruh6SixTY5SvD5U6A5J/uJcEZxCO/lM5PxdyT1gk5c8eoVvIjq05jtLOIaetu8SoP89yd4Hpcp9Y/W4MrmtpntycIISbiqdIjNFUNS89Z/wZQaPvk/pHbomL6iL6pTfw1BQyLfD4gvkLQkYZekpT+ZhI1+cKudCfBD89nYSIDDyFAsvXjr76Pk
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB6PR0801MB2024.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(5660300002)(76116006)(6512007)(71200400001)(54906003)(91956017)(66446008)(8676002)(83380400001)(64756008)(66556008)(66476007)(33656002)(6916009)(8936002)(66946007)(2616005)(86362001)(26005)(36756003)(38070700005)(122000001)(186003)(53546011)(6506007)(2906002)(7416002)(508600001)(38100700002)(6486002)(316002)(4326008)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="iso-8859-1"
Content-ID: <BC75DBF1445DED4C975C8FA1FD07BA21@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3660
Original-Authentication-Results: suse.com; dkim=none (message not signed)
 header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT044.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	971b6754-31e8-4adc-b093-08d98e308088
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	3yEjfGlOawvt1Zb73d/7MSKaYDleQP9TvA/snwnq+zym88741cEOBPPLEQ5SOMdbs5e8Eysl/hWvTp36+mMgzt2tfm8emfXmqx/Uzf4C++9rVE9ADGdRqL0/3+LXotjVLKOKVlkSdldClx65LysCgBA+ucyjPDXt2FmM0odXiduukQHPiHRPpnw0M2zYObrtwn1hf/NZ24f8oyj8F6G3L7HXZ6yAEoPJl18P1ui8GN/0dWyoun2r2aSskNvxnEcNGEDb5GGV7Cj4Wnsr7jU3+VO1ntHht3sceg6yLbKvCoa8fcjq7Kky5RIan2kQN7kW+qoc1Afh6HAZjesEbdURDnTPu0QdAqwE/Flw7nDVFfvNcBBHmXWuDxr2PD/PAP3xWuNWXaa/bMrZXsLpaUJIPSuPiq7vJ8i/3JiGRdoHPr6zVhSy3ENjx3TX6coHX6yDOnDV4ffv5JQU52pTfYz90w2rv6a0X8IbBt2HCuuS4M0fXakOOyWYl5gIQXWwDTF9QRF0UP+a93D5rcn85gv5vvRME1UbTFyIgAFy+duryjkUrzdmO82nlKPpg7BdXXuINno+XvrcuqSa7mfvl39edY55YpBJQuvV8HC6pL53gX1VtWGAS8kVLiCuQoVa1ualfX0/wDC2Pv2vvGfJ7UxqCSk4Cb93ZEONG5V4vbLtzfX2fZvNVdlox16LVD3mdu8nQN4S0iGMl9vDHMZvNE67BQ==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(6862004)(81166007)(33656002)(82310400003)(6506007)(6512007)(53546011)(8936002)(4326008)(508600001)(36756003)(2906002)(47076005)(83380400001)(36860700001)(186003)(336012)(8676002)(86362001)(2616005)(5660300002)(316002)(6486002)(54906003)(70206006)(26005)(70586007)(356005);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2021 10:02:15.8741
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: c90d4472-d947-4fbe-8975-08d98e308920
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT044.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB6300

Hi Jan,

> On 13 Oct 2021, at 07:10, Jan Beulich <jbeulich@suse.com> wrote:
>=20
> On 12.10.2021 23:37, Stefano Stabellini wrote:
>> On Tue, 12 Oct 2021, Jan Beulich wrote:
>>> On 11.10.2021 20:18, Stefano Stabellini wrote:
>>>> On Mon, 11 Oct 2021, Jan Beulich wrote:
>>>>> On 11.10.2021 15:34, Bertrand Marquis wrote:
>>>>>>> On 11 Oct 2021, at 14:09, Jan Beulich <jbeulich@suse.com> wrote:
>>>>>>> On 11.10.2021 14:41, Bertrand Marquis wrote:
>>>>>>>> But digging deeper into this, I would have 2 questions:
>>>>>>>>=20
>>>>>>>> - msi_cleanup was done there after a request from Stefano, but is =
not
>>>>>>>> done in case or iommu error, is there an issue to solve here ?
>>>>>>>=20
>>>>>>> Maybe, but I'm not sure. This very much depends on what a domain
>>>>>>> could in principle do with a partly set-up device. Plus let's
>>>>>>> not forget that we're talking of only Dom0 here (for now at least,
>>>>>>> i.e. not considering the dom0less case).
>>>>>>>=20
>>>>>>> But I'd also like to further defer to Stefano.
>>>>>>=20
>>>>>> Ok, I must admit I do not really see at that stage why doing an MSI =
cleanup
>>>>>> could be needed so I will wait for Stefano to know if I need to keep=
 this when
>>>>>> moving the block up (at the end it is theoretical right now as this =
is empty).
>>>>=20
>>>> I know that MSIs are not supported yet on ARM (pci_cleanup_msi does
>>>> nothing). But I wanted to make sure that the pci_cleanup_msi() calls a=
re
>>>> present anywhere necessary, especially on the error paths. So that onc=
e
>>>> we add MSI support, we don't need to search through the code to find a=
ll
>>>> the error paths missing a pci_cleanup_msi() call.
>>>>=20
>>>> To answer your first question: you are right, we are also missing a
>>>> pci_cleanup_msi() call in the case of IOMMU error. So it might be bett=
er
>>>> to move the call to pci_cleanup_msi() under the "out" label so that we
>>>> can do it once for both cases.
>>>>=20
>>>> To answer your second point about whether it is necessary at all: if
>>>> MSIs and MSI-Xs cannot be already setup at this point at all (not even
>>>> the enable bit), then we don't need any call to pci_cleanup_msi() in
>>>> pci_add_device.
>>>=20
>>> Well, at the very least MSI can't be set up ahead of the traps getting
>>> put in place. Whether partial success of putting traps in place may
>>> allow a cunning guest to set up MSI may depend on further aspects.
>>=20
>> Good point about MSIs not being setup before the traps. We should remove
>> the call to pci_cleanup_msi() in the error path then.
>=20
> Your reply makes me fear you didn't pay enough attention to the "partial"
> in my earlier reply. The traps for the various registers can't all be set
> up atomically, so there may be a transient period where enough traps are
> already in place for a cunning guest to arrange for setup. Unless, as
> said, there are further setup steps needed before a guest could succeed
> in doing so.
>=20
> But even if partial trap setup alone was sufficient, I think the cleaning
> up of MSI then might still better go on the error path there than on that
> of pci_add_device().

I think I should put the msi_cleanup in the exit path if pdev is not null b=
ut
we got a non null ret (in an else if ( pdev ) ).
This would cover all exit paths, especially as I will move the add_handler
before the iommu init.

Would that be ok for everyone ?

Cheers
Bertrand



From xen-devel-bounces@lists.xenproject.org Wed Oct 13 10:11:59 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 10:11:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.208188.364227 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mabEn-0000Va-Fs; Wed, 13 Oct 2021 10:11:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 208188.364227; Wed, 13 Oct 2021 10:11:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mabEn-0000VT-Cv; Wed, 13 Oct 2021 10:11:53 +0000
Received: by outflank-mailman (input) for mailman id 208188;
 Wed, 13 Oct 2021 10:11:52 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=EFKL=PB=citrix.com=roger.pau@srs-us1.protection.inumbo.net>)
 id 1mabEm-0000VN-D6
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 10:11:52 +0000
Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id fb5baf72-2c0d-11ec-816a-12813bfff9fa;
 Wed, 13 Oct 2021 10:11:51 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fb5baf72-2c0d-11ec-816a-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1634119911;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=8hcJ2xs+Xfc93ZRhdwvT7V0M7cKCwISdZpqvce68kYo=;
  b=H/WzhDuMdnY68DsNw8pDncXBa731hyrYb9WQSEY+ACkEBIHDNDuCMPKj
   Ac9ROI3pR3VUAKP77YC6mXleYIf1c63V1gc2cO8+sn+eFWGEwd/mrIViZ
   e+GjqcLTi0fmxkoH2qmpfH824eBshCazxsDW9iSbfAE7HqDD2QMZpaQ4V
   8=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: Vy+HU4zE2w0pf6sAMdphTcAZ6/7YIHPYJjT8Y4cq6oDOsrgJ7Ax8btiR3kS109nUqOroFlVRGB
 qrr4SSAr2R77X3dhUWOf7dXKdhegNUcpL+GEooz/39bVbkM6l51Q4kjeg5ratic7tTworCWe+j
 SB36x9lHtVJOq3rKm2DddVQDorskwl4m33f1hxEfP7r9uxqND+XsdPs7SizdulTSZNXSpWmFf6
 w93uu5EgcgxQnzjINepq124mntwdQZcIvPyj2EKrC41zihhOD8M5cSA5idCBCPA22BRlskOftJ
 FH/EzZPzl9fqpSgy8Yoiuay9
X-SBRS: 5.1
X-MesageID: 55103390
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:vN7BF65hituwjMI0xW0/bQxRtP3BchMFZxGqfqrLsTDasY5as4F+v
 jMZUWiCP6uMamGmc4x+bYWx/B8HsMXUnNFrHFZqrXhmHi5G8cbLO4+Ufxz6V8+wwmwvb67FA
 +E2MISowBUcFyeEzvuV3zyIQUBUjclkfJKlYAL/En03FVIMpBsJ00o5wrdh29Uw2LBVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Z+
 v8SnsC2ChYSOpbIkecZaF5YKi9BFPgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALNs7kMZlZonh95TrYEewnUdbIRKCiCdpwgWpp3psVTK62i
 8wxbjd2UTudUTp2M3Q3CZdlncungl7UbGgNwL6SjfVuuDWCpOBr65D1OcfRUsyHQ4NShEnwj
 mDM8nn9AxoaHMeC0jfD+XWp7sfmhz/2XbU3BbKx9/N0qFCLz2lVAxoTPXO8pfS6kUe4V8hoI
 koY4Dc1raMy+UqoSfHwRxS95nWDu3Y0QdNQDul88wCLxar86hycQGMDS1ZpYtE8qNU/QzBs0
 1aThs7oHhRmqrjTQnWYnp+WsDezNC49PWIEIygeQmMt89Tl5Y0+kB/LZtJiC7KuyM34Hynqx
 DKHpzR4gK8c5eYC0amhpwif2xqjo5HISkg+4QC/dnyi6gR1dYu0fbui4FLQ7etDBIuBR1zHt
 38B8+CZ6O0NFpiLmDa6XPQWHLqp6vCGNxXRmVdqWZIm8lyF4GW/dIpd5DV/IkZBMcsefzLtJ
 kjJtmtsCIR7ZSXwK/UtOsToVppsnfOI+cnZuu78XPARScR3Nx68+BpqbE2U5CftqUYTuPRqU
 XuESvqEAXEfAKVh6TO5QeYBzLMmrhwDKXPvqYPTlEv/j+LPDJKBYfJcagHWN7FmhE+RiFyNq
 443Ciec9/lIvAQSiAHs+okPMUtCE3E/AZ3nwyC8Xr/eelQ4cI3N5vm4/F/AR2CHt/gL/gsr1
 ivkMqO99LYZrSaYQeltQioyAI4Dpb4l8RoG0dUEZD5EIUQLb4e197s4fJAqZ7Qh/+EL5acqF
 KVdJZnaWq4TEWivF9EhgX/V99MKmPOD31PmAsZYSGJnI84Iq/Lhq7cIgTcDBAFRV3Hq5KPSU
 pWr1x/BQIpreuiRJJ2+VR5b9Hvo5SJ1sLsrByPge4APEG2xoNkCA3Gg1ZcffpBTQSgvMxPHj
 m569z9D/rKTy2L0mfGU7Z25Q3CBSrMkQBUBRTWHtN5b90DypwKe/GOJa87RFRj1X2Lo4qSyI
 +JTyvD3Kvocm1hW9YF7Ft5WIWgWuLMDfpdWkVZpGmvldVOuBu8yK3WKx5AX5KZM2qVYqU29X
 UfWootWPrCAOcXEFl8NJVV6MrTfhK9MwjSCv+4oJEja5TNs+ObVW0tlIBTR2jdWK6F4Md15z
 L556tIW8QG2ljEjLs2C0nJP722JI3FZC/cnu5gWDZXFkA0uzl0eM5XQBjWvuMOEaslWM1lsK
 TiR3fKQi7NZz0vEUnwyCXmSgrYN2cVQ4EhHlQZQKU6Il9zJgu4M8CdQqTlnHB5Iyhhn0v5oP
 jQ5PUNCOqjTrSxjg9JOXj7wFlgZVgGZ4EH413AAiHbdExuzTmXIIWAwZbSN8UQe/z4OdzRX5
 ujFmmPsUDKsd8DtxCoiH0VirqW7H9B28wTDnuGhHtiEQMZmMWa03Pf2aDpasQbjDOMwmFbD9
 Ltj8+tHYKHmMTId/v8gAI6A2LVMEB2JKQSumx26EH/lyY0ERAyP5A==
IronPort-HdrOrdr: A9a23:epU4rK5OScQVGsqqsgPXwVWBI+orL9Y04lQ7vn2ZFiY6TiXIra
 +TdaoguSMc6AxwZJkh8erwXpVoZUmsiKKdgLNhR4tKOTOGhILGFvAG0WKP+UyFJ8S6zJ8g6U
 4CSdkONDSTNykDsS+S2mDReLxMsbr3ktHZuQ6d9QYXcegDUdAf0+4TMHfjLqQZfnggOXJvf6
 Dsmfav6gDQNEg/X4CePD0oTuLDr9rEmNbPZgMHPQcu7E2rgSmz4LD3PhCE1lNGOgk/josKwC
 zgqUjU96+ju/a0xlv10HLS1Y1fnJ/ExsFYDMKBp8AJInHHixquZq5mR7qe1QpF7N2H2RIPqp
 3hsh0gN8N85zf4eXy0mwLk303a3DMn+xbZuBelqEqmhfa8aCMxCsJHi44cWADe8VAcsNZ117
 8O936FtrJMZCmw3BjV1pztbVVHh0C0qX0tnao4lHpES7YTb7dXsMg24F5VKpEdByj3gbpXUd
 WGNPuspsq+TGnqKkww5gJUsZiRtzUIb1m7q3E5y4+oO2M8pgE/86MarPZv10vouqhNDaWtSo
 z/Q9BVfYp1P70rhJRGdZE8qPuMex/wqC33QRevyHTcZeo60iH22tTKCItc3pDcRHVP9upqpK
 j8
X-IronPort-AV: E=Sophos;i="5.85,370,1624334400"; 
   d="scan'208";a="55103390"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ZfeOsFp3YLNGF1Pz7yTn+3ribuQkF90wsMQMshTuXYG0OEQskXQRQolxirPxO7aZqQVH04I7OYIxoEUXSGVKj/sOVI40IAPKQ95nEXzrSFdzDioujGi1bnbVtaHkGXEiyFgATd5QqdAYmakxLBmdPKvbt9M5mLT3J8CwW5YASOEwHuEx0ExaSaK3olo+lFWsLYJleRHiDH9kixX7rj6UEEMr6PPraOYBiCpm//aasOMakaG8OABXe9qgJOigPWKNhEqoYJ9QBkQ+7FaVMbARZOAcKnJgQ7bGi8bU2AS6zvegmx+sIQph7ZEI/yDxtJ7PeHXD8fJpXdK61nh3ts0RFw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=lq0ic0EKu9fMVWxvUOeXaI3hJ6HsrCauPoh96HDl8is=;
 b=cjhwmvSJLTfg7gxiEiB93+IItfSSfFW98kmB88utgjNKGwv+lWtZy41S4IYpddRB9Oq+dgWIvelHtYXfZpvBFdzy2Be4ycebYqyVXv4ynEBXWUHYNKTgCIoodkmJOm4JxTTprTPi9ipa6fbYx/AwMmgNUltJfEAKBo+nnsRSEj4RMRn6r0C3Zx06R3lqH3smojycHCBzeZ4KyELfv1sTBWl1DMuq8hUVm9HZMROC23LaTnG9nnRK1aMWdqO3Rjhktpvb97oWg/Vgsvb/ta6okfnvidmeaBhamRqSybz25aeySeREw7nLEJbzbY3t4xfbSUJHo5pzSl7zY973MUKjFA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=lq0ic0EKu9fMVWxvUOeXaI3hJ6HsrCauPoh96HDl8is=;
 b=XF8GdG9nAeFDJnziXNwIID1Sb/i0m53Ud6ovkZyV3hZC1PTsvjDekgiwhLY37+FGOMz9wPc91U2S9gca0AAbn3NVJcBtelNj8f/KmHk9D9KF4PqSCWXN/Jw2DnIVlKw9kXM7Jj0g4KbcucnUMKAmiLKITFGjUu7YwF3pnnxgFjU=
Date: Wed, 13 Oct 2021 12:11:09 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Oleksandr Andrushchenko <andr2000@gmail.com>
CC: <xen-devel@lists.xenproject.org>, <julien@xen.org>,
	<sstabellini@kernel.org>, <oleksandr_tyshchenko@epam.com>,
	<volodymyr_babchuk@epam.com>, <Artem_Mygaiev@epam.com>, <jbeulich@suse.com>,
	<andrew.cooper3@citrix.com>, <george.dunlap@citrix.com>, <paul@xen.org>,
	<bertrand.marquis@arm.com>, <rahul.singh@arm.com>, Oleksandr Andrushchenko
	<oleksandr_andrushchenko@epam.com>
Subject: Re: [PATCH v5 08/10] xen/arm: Setup MMIO range trap handlers for
 hardware domain
Message-ID: <YWawvYGqIe3DwZfI@MacBook-Air-de-Roger.local>
References: <20211008055535.337436-1-andr2000@gmail.com>
 <20211008055535.337436-9-andr2000@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20211008055535.337436-9-andr2000@gmail.com>
X-ClientProxiedBy: LO4P123CA0300.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:196::17) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 40ef440a-88f8-48ca-146e-08d98e31ca9f
X-MS-TrafficTypeDiagnostic: DM6PR03MB4604:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <DM6PR03MB4604841A21A86670C9A5CA218FB79@DM6PR03MB4604.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:2803;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: gowRp2aUrR7qvKe/hRQLlvCtAAsPE3G9HK3AUngYcLlZrd+3Wpc1ojzeM9k0N6FemlEEvudvNZ6FbC/rfIUwSjkX1dOrEOyObsPGWKrCkkTZNRvdCijVKaWAO/r0+O4XivX0GLSEcRLwwenW3i96RhwlJQ0+5l7bZBdlhBoNK/bAG+VhIlJ+TvRE9+ZD5S5S6mYfNRBCKLKu/CPhdiqVMsupOMKn1AKduqWi4Lcd71ujUfyL2oZRAl0IMo+fK7/D3XkIVel+XNAHJyzco4y0gTA0bn105VuJ2PDqWBXlBCmFOt3x731RW6uu+6fXW+CSz4P6RNEX4SMdm3YRS7xIrLpV1qrLsE7szCPdIixzE/ObeytkKP3SQWFydMfahyQX2fy3zkuT7Wxzqz+qySlOqo5+pHSFdyHxqPjsRGZpv1GFxDFn98q5mrcJEPe4u3SV85i25m2L//woe/7vkB8wbLIqThYJGjEmKIdF5bzYd9Y2ijL5QAmc1pB0QVPLCxzH0xKhLLhjpl0HCojXFzgNrW9do6XVLFRBj42MkCXA42E5a5MXkkahYAm/+4Cg47V6t3FRBZGmsLID58pCvo5L9SXyj8ta+biYYTtuWMypQHi6G+Tf7lYGRmIP/UT2opp28sSvOC/eOsQecoL9NCPOnA==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(4326008)(8936002)(6916009)(508600001)(6486002)(66476007)(66556008)(8676002)(6496006)(2906002)(316002)(85182001)(5660300002)(9686003)(82960400001)(83380400001)(66946007)(956004)(86362001)(7416002)(186003)(38100700002)(26005)(6666004);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?anlTU2tqYzdoTXhLM2hqalQ3U3h1TFd2VXJhejNzT2h2aFBMaTN5MlB4em5l?=
 =?utf-8?B?ZVp3M0pMa21oMm5IUmxpRXFUZHU2Yzl5bU1oRzRGL2dYdE5KLytVamFMVHVu?=
 =?utf-8?B?SGttSE44K0JCYytFTzRaY2Z5R0xiampSVm9aWVNsREhJTGdDVTRzVmNQRFM0?=
 =?utf-8?B?clhQLys2VThEQWQwZDgyelB4RmxaNWRKcmMzMEpqUXVkaHFqZkJOL1RiVWtM?=
 =?utf-8?B?UEo5OUI0RjZUVHZvOFphaWJtR2pic2MveGhGeGpXcXcyUGtjWDRWeEt3TDNs?=
 =?utf-8?B?OHNaNnRoRGEvMFFyVEJzQWJBeEx0akRGQ1hTRUMzWDVSYmdaaTN6dnJTVmJK?=
 =?utf-8?B?aXQxUlFYVWpKNEI1bUE0b3Z2WnVKVi9mTW5KZ0JLd1cxVW5qYmgxTlRRejNp?=
 =?utf-8?B?MjdhV1psN2YwZEZFWE4zb0owY3dmcU5vRHJ5ZFByYkNtekQ4MUFSamxwZjhV?=
 =?utf-8?B?UkxCTmdwS0dGWnhZVFI3Y1lDWnNQYkNSMVJnSEJDN1o1M3RtM2VEcG5PZ1Rz?=
 =?utf-8?B?dWhGMU9CTTFVRmFLZ3U1ajkxR25VUlFoQ0lwVVdqMFVCSU1PdEUxQzdvUnlH?=
 =?utf-8?B?WVJDcGFyeU94Rlh2ZkFpSUtOT0V0SkFBQWE5UFhybStCVVNkeWR6cTBWWEZ6?=
 =?utf-8?B?WWhXUW9CeWtVdkJmbEppZGpQUjQrQjRhTEg1LzQ3WG0wWjNtVndXeUI4ZlRi?=
 =?utf-8?B?b1dLQ1haQVBEOFlZRTBrTlJPWEFBc2EvSE1xdTNKbG5icCsyeG1jOHIyajVG?=
 =?utf-8?B?cEwxK1UyTjQvZFBjRDVBbkFwZkdCU2pVNUFNNlhmcnR6RDJjcXZGMmRPbmdu?=
 =?utf-8?B?a3BhL1lraHRETUpONjlYbjR3cm1lR2t1RldaTTFhMTRYYzcrUkQzejRwQUw0?=
 =?utf-8?B?a29XbzNuaGhMVktpVDhqVThrWlNITGdtSnNpSGhGL3pscWRGYzhmcndGRHBS?=
 =?utf-8?B?Sm42Sjg4cVVtbjJFQTJyT2tkK21ydm9XUnRZZk5HTGZXbHVFajFiNHhteVRE?=
 =?utf-8?B?UE5Fbnl4OG9VUktqRHpwbHdNMkVlTUdLSHBoeDlQeEFUTHpWMi9LM3VOWmVq?=
 =?utf-8?B?N2lmRzNXcTAzeFhBS09DUmFJUXQrUEg3amFnTXBpc2M0YWtxWk8wUjhwdkpZ?=
 =?utf-8?B?cWd3SEFGK1ExU3N6ZS9UbTN0cUVkK2NRcWRnSm1LeWIyZkh2Qk15QStUOGVG?=
 =?utf-8?B?UE5rdGU0R2NjWXJlT0ZxYlQ5UXpZR05KOUlSb1VpNXJrNzF4MGZrSnlKcFZa?=
 =?utf-8?B?NGp4OGwvVTE5eklnVHFBMlEvQVNDcTVOSjZqY3ZjY1djUHlWUk1HYWtHaTFs?=
 =?utf-8?B?RWFWd2RlTGlyUjh6ZGFhSlZxZzRUc00xM0NTYXdKdkgwcG9sRVZ3RHVjNXNN?=
 =?utf-8?B?WWJhNi9pM2hMYlVDYkZ1eVFQQ0crL3ZwaTNZS2trdTg2Ni9tVlhsVzdBREJy?=
 =?utf-8?B?RzIvRzJqSXZ2Nzc0SGliTzAwUEIrVk9xb2tBVUx2TWZkMnFsaWpUVVpiMmJr?=
 =?utf-8?B?WFRLdUQwZXpCMHk4TWg5NkRBL1pTd3RKbmM2ekNNcVRUTDg0SjBOeG42K0VD?=
 =?utf-8?B?MGZNWEFLSnIxM1JkR3JCdmFWN3VMQ2RIWDhhTmJFcGJrZXBhQnVUYjJRR0RH?=
 =?utf-8?B?ZWQzUUZDUEc4ZzNiNzZOSWk2TU9Obm9tQ2FzelNyai9EYmxOQkNsTWxmYXVt?=
 =?utf-8?B?UUVSVSt3V3ZPbEs3UVprbDhCakNFaW1ZZVErTktGbVAyUVR2aXRyWHZ2bUNm?=
 =?utf-8?Q?dMcxWjpuYIQqDct6713nFXBbNuv4iYGhZ/71UP2?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 40ef440a-88f8-48ca-146e-08d98e31ca9f
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2021 10:11:15.5193
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: oNz893k3Kx5QCSRtAUzrMdoCHOb6YFW4kK9hamrZcMZK8ek9e+uJtTeiwB/QP1lQWvxgcu5zO1K6bZW+NOBwWw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4604
X-OriginatorOrg: citrix.com

On Fri, Oct 08, 2021 at 08:55:33AM +0300, Oleksandr Andrushchenko wrote:
> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> 
> In order for vPCI to work it needs to maintain guest and hardware
> domain's views of the configuration space. For example, BARs and
> COMMAND registers require emulation for guests and the guest view
> of the registers needs to be in sync with the real contents of the
> relevant registers. For that ECAM address space needs to also be
> trapped for the hardware domain, so we need to implement PCI host
> bridge specific callbacks to properly setup MMIO handlers for those
> ranges depending on particular host bridge implementation.
> 
> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
> Reviewed-by: Rahul Singh <rahul.singh@arm.com>
> Tested-by: Rahul Singh <rahul.singh@arm.com>
> ---
> Since v3:
> - fixed comment formatting
> Since v2:
> - removed unneeded assignment (count = 0)
> - removed unneeded header inclusion
> - update commit message
> Since v1:
>  - Dynamically calculate the number of MMIO handlers required for vPCI
>    and update the total number accordingly
>  - s/clb/cb
>  - Do not introduce a new callback for MMIO handler setup
> ---
>  xen/arch/arm/domain.c              |  2 ++
>  xen/arch/arm/pci/pci-host-common.c | 28 ++++++++++++++++++++++++
>  xen/arch/arm/vpci.c                | 34 ++++++++++++++++++++++++++++++
>  xen/arch/arm/vpci.h                |  6 ++++++
>  xen/include/asm-arm/pci.h          |  5 +++++
>  5 files changed, 75 insertions(+)
> 
> diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
> index 79012bf77757..fa6fcc5e467c 100644
> --- a/xen/arch/arm/domain.c
> +++ b/xen/arch/arm/domain.c
> @@ -733,6 +733,8 @@ int arch_domain_create(struct domain *d,
>      if ( (rc = domain_vgic_register(d, &count)) != 0 )
>          goto fail;
>  
> +    count += domain_vpci_get_num_mmio_handlers(d);
> +
>      if ( (rc = domain_io_init(d, count + MAX_IO_HANDLER)) != 0 )

IMO it might be better to convert the fixed array into a linked list,
I guess this made sense when Arm had a very limited number of mmio
trap handlers, but having to do all this accounting seems quite
tedious every time you want to add new handlers.

>          goto fail;
>  
> diff --git a/xen/arch/arm/pci/pci-host-common.c b/xen/arch/arm/pci/pci-host-common.c
> index 592c01aae5bb..1eb4daa87365 100644
> --- a/xen/arch/arm/pci/pci-host-common.c
> +++ b/xen/arch/arm/pci/pci-host-common.c
> @@ -292,6 +292,34 @@ struct dt_device_node *pci_find_host_bridge_node(struct device *dev)
>      }
>      return bridge->dt_node;
>  }
> +
> +int pci_host_iterate_bridges(struct domain *d,
> +                             int (*cb)(struct domain *d,
> +                                       struct pci_host_bridge *bridge))
> +{
> +    struct pci_host_bridge *bridge;
> +    int err;
> +
> +    list_for_each_entry( bridge, &pci_host_bridges, node )
> +    {
> +        err = cb(d, bridge);
> +        if ( err )
> +            return err;
> +    }
> +    return 0;
> +}
> +
> +int pci_host_get_num_bridges(void)
> +{
> +    struct pci_host_bridge *bridge;
> +    int count = 0;

unsigned int for both the local variable and the return type.

> +
> +    list_for_each_entry( bridge, &pci_host_bridges, node )
> +        count++;
> +
> +    return count;
> +}
> +
>  /*
>   * Local variables:
>   * mode: C
> diff --git a/xen/arch/arm/vpci.c b/xen/arch/arm/vpci.c
> index 76c12b92814f..6e179cd3010b 100644
> --- a/xen/arch/arm/vpci.c
> +++ b/xen/arch/arm/vpci.c
> @@ -80,17 +80,51 @@ static const struct mmio_handler_ops vpci_mmio_handler = {
>      .write = vpci_mmio_write,
>  };
>  
> +static int vpci_setup_mmio_handler(struct domain *d,
> +                                   struct pci_host_bridge *bridge)
> +{
> +    struct pci_config_window *cfg = bridge->cfg;
> +
> +    register_mmio_handler(d, &vpci_mmio_handler,
> +                          cfg->phys_addr, cfg->size, NULL);

I'm confused here, don't you need to use a slightly different handler
for dom0 so that you can differentiate between the segments of the
host bridges?

AFAICT the translation done by vpci_mmio_handler using MMCFG_BDF
always assume segment 0.

> +    return 0;
> +}
> +
>  int domain_vpci_init(struct domain *d)
>  {
>      if ( !has_vpci(d) )
>          return 0;
>  
> +    if ( is_hardware_domain(d) )
> +        return pci_host_iterate_bridges(d, vpci_setup_mmio_handler);
> +
> +    /* Guest domains use what is programmed in their device tree. */
>      register_mmio_handler(d, &vpci_mmio_handler,
>                            GUEST_VPCI_ECAM_BASE, GUEST_VPCI_ECAM_SIZE, NULL);
>  
>      return 0;
>  }
>  
> +int domain_vpci_get_num_mmio_handlers(struct domain *d)
> +{
> +    int count;

unsigned for both types.

> +
> +    if ( is_hardware_domain(d) )
> +        /* For each PCI host bridge's configuration space. */
> +        count = pci_host_get_num_bridges();

There's no need to trap MSI-X Table/PBA accesses for dom0 I assume?

> +    else
> +        /*
> +         * VPCI_MSIX_MEM_NUM handlers for MSI-X tables per each PCI device
> +         * being passed through. Maximum number of supported devices
> +         * is 32 as virtual bus topology emulates the devices as embedded
> +         * endpoints.
> +         * +1 for a single emulated host bridge's configuration space.
> +         */
> +        count = VPCI_MSIX_MEM_NUM * 32 + 1;

There's a single MSI-X mmio handler that deals with both PBA and MSIX
tables, so I don't see the need to * VPCI_MSIX_MEM_NUM.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Wed Oct 13 10:34:05 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 10:34:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.208198.364239 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mabaB-00033u-FF; Wed, 13 Oct 2021 10:33:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 208198.364239; Wed, 13 Oct 2021 10:33:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mabaB-00033n-AQ; Wed, 13 Oct 2021 10:33:59 +0000
Received: by outflank-mailman (input) for mailman id 208198;
 Wed, 13 Oct 2021 10:33:58 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=EFKL=PB=citrix.com=roger.pau@srs-us1.protection.inumbo.net>)
 id 1mabaA-00033h-33
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 10:33:58 +0000
Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 7c09a2f3-1224-45a2-aff2-086cf54e8cbc;
 Wed, 13 Oct 2021 10:33:56 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7c09a2f3-1224-45a2-aff2-086cf54e8cbc
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1634121236;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=JzPXlcySnHh9ql7f5Tyo7E0amGUef8EBMAc0OSw6bgU=;
  b=eWym9N8t+4wdzLhMZeIrGv1KhIotPJlwTkTsLXd/PEtNSAqJDdTov+An
   46BgcWhFb4h0qXLqG+DBAoXyi2XF9+AQ2H85G35DCYDhmj4br8lCchl6E
   dn+9P7nxV5rpnAKIdEcgX07tHoUvlbtwU/rndldu/LgB6CPDvLwEZ2L7K
   c=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: NJwuhDS557qlyqg2P8PtVDxhoGClwSXjBZKY2figBweo6mYnOcGPDOWFAATIIe/z0jwlOU/JJh
 BDQkQLHYpXEI0tyIfvpwre0LxOLJrWfv6cQM9L4hx57mdDVgAC+Pci0RBZ8JbbgZZ99JpcfUe1
 xdoJFaiSZcYjAmsCLaBDVlLKx3OUkhcM8o9yrMeLSVkUtAkJbCSTHgdnVhAFo623F9E6oOdtib
 w9xlV5ajJ8O2/c4BvD09+OZ9MXeydgN1k++GroK1DF73hGHJ/YWHG7fmVjVrVjd/Q9DOkrB5hs
 Ct5WMfd8BQGXwNdsp9fw7CJ3
X-SBRS: 5.1
X-MesageID: 54642394
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:Ie2aMqOjCfzdP8XvrR2rkcFynXyQoLVcMsEvi/4bfWQNrUpz3zADy
 TYaXmzXaPePazTxKdwgao/ioEIC65WHm99iTQto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdpJYz/uUGuCJQUNUjMlkfZKhTr6ZUsxNbVU8En540Us4w7dRbrNA2rBVPSvc4
 bsenOWHULOV82Yc3rU8sv/rRLtH5ZweiRtA1rAMTakjUGz2zhH5OKk3N6CpR0YUd6EPdgKMq
 0Qv+5nilo/R109F5tpICd8XeGVSKlLZFVDmZna7x8FOK/WNz8A/+v9TCRYSVatYo2qSs49ui
 4tpjo69GQgXebKRyOZGbxYNRkmSPYUekFPGCX22sMjVxEzaaXr8hf5pCSnaP6VBpLwxWzsXs
 6VFdnZdNXhvhMrvqF6/YvNrick5atHiIasUu216zCGfBvEjKXzGa/iWu4MCh2Zs7ixINciHS
 c4yYH1NUAndfxtFGHlIWcIzh9790xETdBUH8QnI9MLb+VP7zRNz+KjgNsLPfd6HTtkTmVyXz
 kr4+GD+DgAfJcao4zOP+XKxhcfChSr+HokVEdWQ9PRnnVmSzWw7EwANWB2wpvzRola3RtZ3O
 0ESvC00osAa60iDXtT7GRqirxasvAMYWtdWO/037keK0KW8yzyQBnUACAVAbtMmnMYsQHoh0
 Vrht/nkHyB1ubuZD1eU7K6JrCiaMDIQa2QFYEcsXQYDptXuvow3phbOVcp4Vr64iMXvHjP9y
 CzMqzIx750IltIC3ai/+VHBghqvq4LPQwpz4R/YNkqM6A9jacidfZ659lHB5N5JNoPfRV6E1
 EXogODHsrpIV8vU0nXQHqNdR9lF+sppLhWDmnIwANp/0w+/9i6sQ8dPvWF8f3tmZ5NslSDSX
 GffvgZY5Zl2NXSsbLNqb4/ZN/nG3ZQMBvy+CaiKNosmjoxZMVbdpnk3NBH4M3XFyRB0yckC1
 YGnndFA5JrwIZ9syyaqXK8j2LsvyzFWKYj7FM2jkUrPPVZzYheopVY53LmmMr5RAECs+ly9H
 zNj2y2ikEo3vArWOHi/zGLrBQpWRUXX/LivwyCtSsaNIxB9BEYqAOLLzLUqduRNxvoOyr+Wo
 ivlABMDlDITYEErzy3RNRiPj5u1DP5CQY8TZ3RwbT5EJVByCWpQ0EvvX8RuJuR2nACS5fV1U
 +MEa6297gdnEVz6F8AmRcCl9uRKLU3z7SrXZnbNSGVvLvZIGl2Skve5L1SHycX7Jnfu3SfIi
 +b7jV2zrFtqb1kKMfs6n9r2lwnv4iNHxL4rN6YKS/EKEHjRHEFRA3WZptc8It0WKAWFwT2f1
 g2MBgwfq/WLqIgwmOQlT4jex2twO+chTEdcAUfB6rO6aXvT8ma5mNcSW+eUZzHNEmjz/fz6N
 +lSyvj9NtwBnUpL7NUgQ+o6k/pm6ou9vaJewyRlAG7PMwahBIR/LyTUxsJIrKBMmONU4FPkR
 kKV99BGEryVI8e5QkUJLQ8oY73bh/EZkzXf99ovJ0D+6HMl9baLSxwKbRKNlDZcPP1+N4Z8m
 bUtv8sf6gqejBs2M4nZ0nAIpjrUdnFZCvcprJAXBoPvmzEH8FAabMyOEDLy7bGOd85IbhsgL
 AiLifeQnL9b3EfDLSY+TCCfwepHiJ0SkxlW11tedU+Rk9/Ii/Jrjh1c9TM7ElZcwhldir8hP
 2FqMwt+JLmU/icuj89GBjj+FwZEDRyf20rw11pWyzGJExj2DjTAfD8nJOKA3EEF6GYNLDFU8
 YaRxHvhTTu3Ltr62TE/WBI9pvHuJTCrGtYuRCxz8xy5IqQH
IronPort-HdrOrdr: A9a23:a/eKDaoaVSAvS3j1rwAWin8aV5u6L9V00zEX/kB9WHVpm5Oj+P
 xGzc526farslsssREb+OxpOMG7MBThHLpOkPMs1NCZLXTbUQqTXfpfBO7ZrQEIdBeOlNK1uZ
 0QFpSWTeeAcWSS7vyKkTVQcexQueVvmZrA7Yy1rwYPPHFXguNbnn9E426gYzNLrWJ9dPwE/f
 Snl656T23KQwVpUi33PAhJY8Hz4/nw0L72ax8PABAqrCGIkDOT8bb/VzyVxA0XXT9jyaortT
 GtqX232oyT99WAjjPM3W7a6Jpb3PPn19t4HcSJzuwYMC/lhAqEbJloH5eCoDc2iuey70tCqq
 iBnz4Qe+BIr1/BdGC8phXgnyHmzTYV8nfnjWSVhHPyyPaJDA4SOo5kv8Z0YxHZ400vsJVXy6
 RQxV+UsJJREFfpgDn9z8KgbWArqmOE5V4Z1cIDhX1WVoUTLJVLq5YEwU9TGJAcWArn9YEcFv
 V0Bs203ocWTbqjVQGagoBT+q3oYpxqdS32BnTq+/blnQS+pUoJjHfxn6ck7zA9HJFUcegM2w
 2LCNUvqFniJvVmGZ6VP91xM/dfPFa9Ny4kAFjiUmgPK5t3Tk4li6SHq4ndt9vaMqDh8vMJ6e
 P8uRVjxDcPR34=
X-IronPort-AV: E=Sophos;i="5.85,370,1624334400"; 
   d="scan'208";a="54642394"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=i2fVI0JXAweA+HCyR7onWDcq3WG3acXLVnTXBw8Df2Cf7T0N6hvc6E6cN6Rw66nqnOCnd5FKx2VWfjSDp6DYTSdk5wx/c9cgFZ8F9RRLispQrt/ZRRjMPaiX2krq+R9tWR27lp9ToQc2GczwoaH7qtIN33VTYHpLNxuN7jDJO7kxoATPO9C8QbnCEVfcDKlR5ZTRopiL7osuTuIejPi+NE8zmKBX0ECCW2k5+95vSRrfnBUKD/yRiKrYOEGGB7pHDmFtPnMVzabUp5iIxYe6zXyEvuXMEN5GwGLpSzQ8lYh/gWmqGpyj1V1o5cjdrOd3JiHxbFcv8q8iZQJN9chLNw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=wVme+dt+GHnxXOGOyvRMjypqZzYv6JLcNENHaHfXkVg=;
 b=UweS1q1IkA0K/nksfAojAAiKltx3Mi3n5syl6sc92JO11ZsOGYO1uUnwg+vcBDiIeQ0W6hsMRKu0MMVm+dYaIrMuB5vhrG7ViIAoq+4jfS0nY/i1exMXLOysPeQ6Ijo1pw1ju0Koi6Emzr9cVW7zekwOhLKOZesD0ffW0KJmuCAQkkvBC1eDCqTqnbPcOKhT9Kx+fFfSlCCYo8ozpWOTf81VcCO/iIfmdO8w0EbmfnDFo3jJvZNrtU07UA1TNdMqFfh06cZRcPFejGwiXP0nrJCnvPsiV3HerCYi7KNpamCKKvmP6Q4nyc7sJVDwQsXslAyDbmAZ2kzkwODhwwRKHQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=wVme+dt+GHnxXOGOyvRMjypqZzYv6JLcNENHaHfXkVg=;
 b=BUkvvK5iKtb6MC+xF7HJj+xBL6OFK5WLU4aV26sosMOju1bfTjCoRcl49kByQt79ebBH5rrcg1LxjAtLVzDww42x+ozpdDBzptD7Ckpky6OQUaQqXJFAUODlMwBuodQibj4oZpVcmx6d1b7DAwVR+XkZdIH/NhsNTMv1b2bOYXY=
Date: Wed, 13 Oct 2021 12:33:17 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Bertrand Marquis <Bertrand.Marquis@arm.com>
CC: Rahul Singh <Rahul.Singh@arm.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, Andre Przywara <Andre.Przywara@arm.com>,
	Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, Andrew Cooper
	<andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>, Ian
 Jackson <iwj@xenproject.org>, Jan Beulich <jbeulich@suse.com>, Wei Liu
	<wl@xen.org>, Paul Durrant <paul@xen.org>
Subject: Re: [PATCH v5 08/11] xen/arm: Enable the existing x86 virtual PCI
 support for ARM.
Message-ID: <YWa17Y8siYOhf6fT@MacBook-Air-de-Roger.local>
References: <cover.1633540842.git.rahul.singh@arm.com>
 <9bdca2cda5d2e83f94dc2423e55714273539760a.1633540842.git.rahul.singh@arm.com>
 <YWaco/UvA4xFE1xW@MacBook-Air-de-Roger.local>
 <7077F76D-37B0-45F6-9B0D-0D9436E23716@arm.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <7077F76D-37B0-45F6-9B0D-0D9436E23716@arm.com>
X-ClientProxiedBy: LO4P123CA0395.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:18f::22) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 4411ce34-189c-4e70-2f42-08d98e34e119
X-MS-TrafficTypeDiagnostic: DM6PR03MB4539:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <DM6PR03MB4539D337A8B44C58BB09A4A48FB79@DM6PR03MB4539.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: FHVVwA1nopo+L/JKRUrfPjlg/cr2TqOPqc4FRKy+Krbrp5KFzvqEc94s62heR483HEyYs0lihokAHzsJgXRXbTbAYTHM2XcOfmEXpIk6D93nX92WkIPb8vKBXZ4Pb3b89ZCgVzwJQhk28L9cT1AJSh9TlkR0xDMQWxprOvFBvJeuST6Sc3tN9xdNl8CswYZXR+g9bmH2Uvh3LVojJ9W75MyWkfl9VT/bx2ISmvX+MvO2GVFhFLwn+oQWNJaWTERgdw/I4d0GFuoM1n5uq+WPR1Hcy6XsylBKZcfDieVkzVXEWwF2jLH35mJYQSe7a4bwor9B7TTnyBzO/vyF45zmKGrAaHFmXjkzYsZIBog9JyAT0gueWq2QBtA5gFiNIke93o1KseTDpuLmGx3PaftgXsHK4Ihq+eopYRtFamxmBUVdOOVfdZJhSBpoaerQUwinkheAxPdwnngmkWWgv8459iVTtFNIVj/5+qPvPtnYA2337CVhCwF1ALJq1boFw5ZZ9EmXAyUq3UYvr7nXyShJvaPYe4ToFs2jVvaIGDFbh0HFFtlx7Q6TU6Tnq/+cQYD8C3MuEtS6GLuIyxgdvmplbLxpQ/HpqfFvi66PJoxbPrzYwQad+cPzeAEkHlzOx/YreZFg39jOauHKslQzo0D5EcN5qpHN6A55+PMXcekat1UYWgMuyLQLOY4xn+voigmvErsacUqlpc8Pm8f4SlyFLQ==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(316002)(2906002)(6666004)(186003)(26005)(86362001)(82960400001)(5660300002)(85182001)(54906003)(66556008)(66476007)(66946007)(38100700002)(8936002)(6496006)(956004)(4326008)(8676002)(6916009)(6486002)(83380400001)(508600001)(7416002)(53546011)(9686003)(2004002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Nk5hN2hiWldERVhrSHRGSEFJa0N4dTM2Nm1yb01XdnBRNEFhQ2pYWHNIV3A2?=
 =?utf-8?B?dklINlFyN083c3BUeXE1eC8wQ1ltOUhvN1FITHd2WEJENk5nVUpwTEFLNXBH?=
 =?utf-8?B?azZCSjNuZDBqMmt4QXVnWEtOQWw0UHAwQnR2NTBIQ3FkUmd1bmFCZmVPVDZs?=
 =?utf-8?B?U1F0WVB3dmtmN0V0VitXOC9MMitXUnZraUpoODF3WVNrclI5OE1waDNYYS9M?=
 =?utf-8?B?ZlVocm02cENJUTlYZ2gzNFlyeTUvQWZKdmJuM002MExvd1IyTytDWmpTeGpu?=
 =?utf-8?B?N3h5N2Q4MHIxSDl0N0NsL2tWTzBRR1BiUlBHbjNxUnhrL1Zaa3RGcS9MOFQ1?=
 =?utf-8?B?TCtCVDVoUXBKSkJGODhIYXJkTHdCV1FIYTIvNjNKZHpCVndhSUIrYmRHUVlB?=
 =?utf-8?B?bXBjN1BmU1pCeU95NW1FajNlNURxRWNxUVhBNVdQRU9zN243YVM4QnpvZXBm?=
 =?utf-8?B?K29xSDlDaXA2NlYxUWpTYmJ4aUdkN25MRjhQbU9RajRHZnUweWszNmNYY2FR?=
 =?utf-8?B?TjlTeDBvUFh0LzZLc3VNbUlWeU9hS1NFNVJSRm12VUt6RWJ4clloYW5pcERE?=
 =?utf-8?B?Mko0T3RYVjE0SnA3RXZkdHFGc2pCOUJpMGZaMTdsbjVqdTRNbnpESXZVTU84?=
 =?utf-8?B?RjB6eXBQNXJRSnpJMTI1OVpYRlJ5NG9sT1FLYkdieHZIeFpvL055d2pTTHV3?=
 =?utf-8?B?REZyNHFjVjZiNFZ5OTZxa2lnMmRuU003SFNMMlhvSGp5SDBvZCt5UmJHOGtE?=
 =?utf-8?B?ZVV5MGlhdGlYb1dsNDY4NkpCK3dQdndNallTSnRvRWpDZmczZm1zbm5GMG1o?=
 =?utf-8?B?TzZja2tRbjRkTlk1b1lxQXNVTGtCV0xsOS8wL3BaNzZVeXMxME8rVlBNZmlF?=
 =?utf-8?B?TmU0dDB1SHFnbWxqSGcrcllDSGdFa3NEeENTbWpKdVh4Vk1Ua2ZTL2RSNUx0?=
 =?utf-8?B?ZEZuTko5bk5LQ2JVc1FVdzdSQ1JjNzhWWFAwY3luQ0NYVS9CN2lWY1FPcThr?=
 =?utf-8?B?Y1NOcHUrZ3NVVnN5UlNLWVJWV3BhTFZtVFpnRVlRVWdxYy9FcE9WZ0FILzJC?=
 =?utf-8?B?UlBTT1dRS2VNdnA1V0l2eStOZ0EwZU4xcW82SWxNRC9IOXg1MFJiTXduNDdP?=
 =?utf-8?B?V3IrdDlrUjdBNTZyOUtXNmZCeTQvSUdTMFdrY3pBTEl3NGZJYUwzQzE5NU40?=
 =?utf-8?B?ZVFPMXF3MkFqLzVCN1JUUzhoemlLUjZNRzlYKzdVNUZ6WFp5K2lhRkhBYlda?=
 =?utf-8?B?NW5nUEJJcWdyUnBoLzBlWWVyZUJqcDBxeHNyZGtnZitGRldKd3lTZUFRSUZa?=
 =?utf-8?B?YWpVSFBCa3YvcUdRQ3lYOVhHbmNTa3ZRRzdJR3NiOUNvbUhjQ2M3ZURCUTZr?=
 =?utf-8?B?S3FRcTJrc1UvZnhKR2U2Z0V0MElLUkU2UHNRTDdsMW53RFVEMVdtdjNOOHdX?=
 =?utf-8?B?U2h3ODhvZzhIZVZtMWdnbnIrK1lrR2o3Tld6NnM5UXdGQnViM3hxNm1iME5B?=
 =?utf-8?B?Tlc0ZEFxUjJYOENMRGRTdmhJUGM4dGpma3VSRFFTbkdjbDdGZTRMUGlMejZQ?=
 =?utf-8?B?UnVwaE9oUUdMSjZmRlByZjN6NTVIUkhEVlpqbmd4amwyYXE3OHR6VzZ4SW9k?=
 =?utf-8?B?VDluRnNLQkV2RzdRL056RzFRWWRmTnByeTdBVDQrMTZFUDQ3eE83KzRReGV4?=
 =?utf-8?B?dUQ5d0FhUEpxeXRVajBMWEZ3Wk9HaGpqRkQxYURIbzN3RVhtNjJ6VTdFQjdv?=
 =?utf-8?Q?D70xpHxU3rtjg+ZWWcgEI0sR1LfnhdUQY/VvQN6?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 4411ce34-189c-4e70-2f42-08d98e34e119
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2021 10:33:21.7773
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5rOTnnLEKGWE1hajP7eoP52cEdfX3EzfjnL6LQGSaU1nf5p9ONXUoUaIGgj4aS9kaTy6mRAlk7G9opVZmFRMiA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4539
X-OriginatorOrg: citrix.com

On Wed, Oct 13, 2021 at 09:48:42AM +0000, Bertrand Marquis wrote:
> Hi Roger,
> 
> > On 13 Oct 2021, at 09:45, Roger Pau Monné <roger.pau@citrix.com> wrote:
> > 
> > On Wed, Oct 06, 2021 at 06:40:34PM +0100, Rahul Singh wrote:
> >> The existing VPCI support available for X86 is adapted for Arm.
> >> When the device is added to XEN via the hyper call
> >> “PHYSDEVOP_pci_device_add”, VPCI handler for the config space
> >> access is added to the Xen to emulate the PCI devices config space.
> >> 
> >> A MMIO trap handler for the PCI ECAM space is registered in XEN
> >> so that when guest is trying to access the PCI config space,XEN
> >> will trap the access and emulate read/write using the VPCI and
> >> not the real PCI hardware.
> >> 
> >> For Dom0less systems scan_pci_devices() would be used to discover the
> >> PCI device in XEN and VPCI handler will be added during XEN boots.
> >> 
> >> Signed-off-by: Rahul Singh <rahul.singh@arm.com>
> >> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
> >> ---
> >> Change in v5:
> >> - Add pci_cleanup_msi(pdev) in cleanup part.
> >> - Added Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
> >> Change in v4:
> >> - Move addition of XEN_DOMCTL_CDF_vpci flag to separate patch
> >> Change in v3:
> >> - Use is_pci_passthrough_enabled() in place of pci_passthrough_enabled variable
> >> - Reject XEN_DOMCTL_CDF_vpci for x86 in arch_sanitise_domain_config()
> >> - Remove IS_ENABLED(CONFIG_HAS_VPCI) from has_vpci()
> >> Change in v2:
> >> - Add new XEN_DOMCTL_CDF_vpci flag
> >> - modify has_vpci() to include XEN_DOMCTL_CDF_vpci
> >> - enable vpci support when pci-passthough option is enabled.
> >> ---
> >> ---
> >> xen/arch/arm/Makefile         |   1 +
> >> xen/arch/arm/domain.c         |   4 ++
> >> xen/arch/arm/domain_build.c   |   3 +
> >> xen/arch/arm/vpci.c           | 102 ++++++++++++++++++++++++++++++++++
> >> xen/arch/arm/vpci.h           |  36 ++++++++++++
> >> xen/drivers/passthrough/pci.c |  18 ++++++
> >> xen/include/asm-arm/domain.h  |   7 ++-
> >> xen/include/asm-x86/pci.h     |   2 -
> >> xen/include/public/arch-arm.h |   7 +++
> >> xen/include/xen/pci.h         |   2 +
> >> 10 files changed, 179 insertions(+), 3 deletions(-)
> >> create mode 100644 xen/arch/arm/vpci.c
> >> create mode 100644 xen/arch/arm/vpci.h
> >> 
> >> diff --git a/xen/arch/arm/Makefile b/xen/arch/arm/Makefile
> >> index 44d7cc81fa..fb9c976ea2 100644
> >> --- a/xen/arch/arm/Makefile
> >> +++ b/xen/arch/arm/Makefile
> >> @@ -7,6 +7,7 @@ ifneq ($(CONFIG_NO_PLAT),y)
> >> obj-y += platforms/
> >> endif
> >> obj-$(CONFIG_TEE) += tee/
> >> +obj-$(CONFIG_HAS_VPCI) += vpci.o
> >> 
> >> obj-$(CONFIG_HAS_ALTERNATIVE) += alternative.o
> >> obj-y += bootfdt.init.o
> >> diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
> >> index 36138c1b2e..fbb52f78f1 100644
> >> --- a/xen/arch/arm/domain.c
> >> +++ b/xen/arch/arm/domain.c
> >> @@ -39,6 +39,7 @@
> >> #include <asm/vgic.h>
> >> #include <asm/vtimer.h>
> >> 
> >> +#include "vpci.h"
> >> #include "vuart.h"
> >> 
> >> DEFINE_PER_CPU(struct vcpu *, curr_vcpu);
> >> @@ -767,6 +768,9 @@ int arch_domain_create(struct domain *d,
> >>     if ( is_hardware_domain(d) && (rc = domain_vuart_init(d)) )
> >>         goto fail;
> >> 
> >> +    if ( (rc = domain_vpci_init(d)) != 0 )
> >> +        goto fail;
> >> +
> >>     return 0;
> >> 
> >> fail:
> >> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
> >> index c5afbe2e05..f4c89bde8c 100644
> >> --- a/xen/arch/arm/domain_build.c
> >> +++ b/xen/arch/arm/domain_build.c
> >> @@ -3053,6 +3053,9 @@ void __init create_dom0(void)
> >>     if ( iommu_enabled )
> >>         dom0_cfg.flags |= XEN_DOMCTL_CDF_iommu;
> >> 
> >> +    if ( is_pci_passthrough_enabled() )
> >> +        dom0_cfg.flags |= XEN_DOMCTL_CDF_vpci;
> >> +
> >>     dom0 = domain_create(0, &dom0_cfg, true);
> >>     if ( IS_ERR(dom0) || (alloc_dom0_vcpu0(dom0) == NULL) )
> >>         panic("Error creating domain 0\n");
> >> diff --git a/xen/arch/arm/vpci.c b/xen/arch/arm/vpci.c
> >> new file mode 100644
> >> index 0000000000..76c12b9281
> >> --- /dev/null
> >> +++ b/xen/arch/arm/vpci.c
> >> @@ -0,0 +1,102 @@
> >> +/*
> >> + * xen/arch/arm/vpci.c
> >> + *
> >> + * This program is free software; you can redistribute it and/or modify
> >> + * it under the terms of the GNU General Public License as published by
> >> + * the Free Software Foundation; either version 2 of the License, or
> >> + * (at your option) any later version.
> >> + *
> >> + * This program is distributed in the hope that it will be useful,
> >> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> >> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> >> + * GNU General Public License for more details.
> >> + */
> >> +#include <xen/sched.h>
> >> +
> >> +#include <asm/mmio.h>
> >> +
> >> +#define REGISTER_OFFSET(addr)  ( (addr) & 0x00000fff)
> >> +
> >> +/* Do some sanity checks. */
> >> +static bool vpci_mmio_access_allowed(unsigned int reg, unsigned int len)
> >> +{
> >> +    /* Check access size. */
> >> +    if ( len > 8 )
> >> +        return false;
> >> +
> >> +    /* Check that access is size aligned. */
> >> +    if ( (reg & (len - 1)) )
> >> +        return false;
> >> +
> >> +    return true;
> >> +}
> >> +
> >> +static int vpci_mmio_read(struct vcpu *v, mmio_info_t *info,
> >> +                          register_t *r, void *p)
> >> +{
> >> +    unsigned int reg;
> >> +    pci_sbdf_t sbdf;
> >> +    unsigned long data = ~0UL;
> >> +    unsigned int size = 1U << info->dabt.size;
> >> +
> >> +    sbdf.sbdf = MMCFG_BDF(info->gpa);
> >> +    reg = REGISTER_OFFSET(info->gpa);
> >> +
> >> +    if ( !vpci_mmio_access_allowed(reg, size) )
> >> +        return 0;
> >> +
> >> +    data = vpci_read(sbdf, reg, min(4u, size));
> >> +    if ( size == 8 )
> >> +        data |= (uint64_t)vpci_read(sbdf, reg + 4, 4) << 32;
> >> +
> >> +    *r = data;
> >> +
> >> +    return 1;
> >> +}
> >> +
> >> +static int vpci_mmio_write(struct vcpu *v, mmio_info_t *info,
> >> +                           register_t r, void *p)
> >> +{
> >> +    unsigned int reg;
> >> +    pci_sbdf_t sbdf;
> >> +    unsigned long data = r;
> >> +    unsigned int size = 1U << info->dabt.size;
> >> +
> >> +    sbdf.sbdf = MMCFG_BDF(info->gpa);
> >> +    reg = REGISTER_OFFSET(info->gpa);
> >> +
> >> +    if ( !vpci_mmio_access_allowed(reg, size) )
> >> +        return 0;
> >> +
> >> +    vpci_write(sbdf, reg, min(4u, size), data);
> >> +    if ( size == 8 )
> >> +        vpci_write(sbdf, reg + 4, 4, data >> 32);
> > 
> > I think those two helpers (and vpci_mmio_access_allowed) are very
> > similar to the existing x86 ones (see vpci_mmcfg_{read,write}), up to
> > the point where I would consider moving the shared code to vpci.c as
> > vpci_ecam_{read,write} and call them from the arch specific trap
> > handlers.
> 
> Would it be ok to have ecam specific code in the vpci common code ?

I think so, ECAM is part of the PCI specification and architecture
agnostic, so fine to place in common code.

> This is an optimisation and we could do that later on as this is an other
> change to be done and tested which will start to make things very
> challenging with the friday deadline.

I guess this could be done, by adding a TODO note that the handlers
should be unified with the x86 ones and placed in common code.

I however get the feeling that such work would ultimately be ignored,
as there's always more pressing stuff to be done, and people tend to
forget about those cleanups once things get committed.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Wed Oct 13 10:36:46 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 10:36:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.208207.364249 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mabcm-0003h7-RB; Wed, 13 Oct 2021 10:36:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 208207.364249; Wed, 13 Oct 2021 10:36:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mabcm-0003h0-O8; Wed, 13 Oct 2021 10:36:40 +0000
Received: by outflank-mailman (input) for mailman id 208207;
 Wed, 13 Oct 2021 10:36:39 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=iVjq=PB=citrix.com=anthony.perard@srs-us1.protection.inumbo.net>)
 id 1mabcl-0003gs-SQ
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 10:36:39 +0000
Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 71d17df0-2c11-11ec-816a-12813bfff9fa;
 Wed, 13 Oct 2021 10:36:38 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 71d17df0-2c11-11ec-816a-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1634121398;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=5u5BEcgaPBBpZnTc6KcywShDLysumq7kVv4GBGzllhE=;
  b=bmwlNxCKglcC/UnKCQz/QCKY4VieOqmZGJiHnSR8IvW9v5OyJjLkl/14
   WWJhSI4EdchurZNN7TuVw7INuUqa5GWHL8Mw6qOs0yjag9iqWmdpIeJVf
   ZDKEnLzE4H8OFMk0I41VikCJG4ydkAdiZk5WuSruAHz04DaUAegdfs+gu
   8=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: xOFO/qPGQcgcxIx7jQQQM1Q5hFk0xET3o7oYDMGAOueRU96O0gHsYMtxhbVJsCq6rrd4IbZIel
 8QejCeUHimKb/7f2U/4Dn8Dcu5+dA90M/4oRJcGSjs6lMX6EcoCha3iz7zMU13Ps0/QIo4Twg4
 XTq/OA/46BJA27OyGrl51XAXc92OeXUcHLj7PllQrkSGyDU4C+sWUHD+wMIAWgZ3WPTkps1bpH
 hxqmg2++j8uBTS/gM9o9W+PYRoGc3tIB/EoLeu721bKMJ6U5GKLeDARVG0yVTnZqEjl0+p2KNN
 vh+MBdaX7wChLiugObx77mGm
X-SBRS: 5.1
X-MesageID: 55058912
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:wTjlW6qiThC7sGEke7XN0n24dt9eBmKVYhIvgKrLsJaIsI4StFCzt
 garIBmAM/qIZjb8L98nbo2390tQuZPcx4NqSAM+pHo0FyNA85uZCYyVIHmrMnLJJKUvbq7GA
 +byyDXkBJppJpMJjk71atANlZT4vE2xbuKU5NTsY0idfic5Dnd84f5fs7Rh2Ncx2YHiW1rlV
 e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL
 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9
 DlCnbe7Rzp5BI6Qo9o+diZ3PxtMZfEc3oaSdBBTseTLp6HHW37lwvEoB0AqJ4wIvO1wBAmi9
 9RBdmpLNErawbvrnvTrEYGAhex6RCXvFIoZpnFnyyCfFfs8SIrPa67L+cVZzHE7gcUm8fP2O
 pdBNGo+NU6ojxtnZVtLWc88ke6UrVbdSxRYkRGKm5h02j2GpOB2+Oe0a4eEEjCQfu1OhVqRr
 G/C+2X/AzkZOcaZxD7D9Wij7sfQmQvrVYRUE6e3ntZ6jVvWymENBRk+UVqgveL/mkO4Q8hYK
 UEf5mwpt6da3E6hQ8T5Xha4iGWZpRNaUN1Ve8U79wOl2qfS+xyeBGUPUnhGctNOnM0rQT0n0
 HeZktWvAiZg2IB5UlrEqO3S92nrf3FIcylSPkfoUDfp/fHIq48O3ijsEu1dM4uKofHPK2msm
 Raz+X1Wa6ooseYH0KCy/Fbiij2qp4TUQgNd2jg7Tl5J/SsiO9b7P93ABUzzqK8adt7AHwbpU
 G0swpDGtIgz4YexeDthqQnnNIqi4OqZK3XiiFprEohJG9+FqiP7I944DN2TIi5U3ic4ld3BP
 BG7VeB5vsY70J6WgUlfON3Z5yMCl/mIKDgdfqqIBueim7AoHON9wAlgZFSLw0fmm1U2nKc0N
 P+zKJj3US5EVf4/lmbtG4/xNIPHIAhlmgs/orihnnyaPUe2PibJGd/pznPfBgzG0E90iFqMq
 IsOXyd74x5eTPf/ckHqHX07djg3wYwALcmu8aR/L7fbSiI/QT1JI6KBkNsJJt0+94wIx7igw
 51IchIBoLYJrSacclvih7EKQO6HYKuTWlpiZXZyYg3yhyR6CWtthY9GH6YKkXAc3LQL5ZZJo
 zMtJa1s29xDFWbK/Sozd574oNAwfRinn1vWbSGkfCI+b9hrQAmQoo3oeQ7m9S8vCCurtJRh/
 +38h12DGZdTFR5/CMv2ae60yw/jt3Yqh+8vDVDDJcNeeRuw/dEyeTDxlPI+P+oFNQ7HmmmBz
 w+TDBpB/bvNroY5/cPnn6eBq4v1QeJyElADRzvQ7KqsNDmc9W2mmNcSXOGNdDHbdWX15KT9O
 rkFk6CiaKUKxQ8YvZB9HrBnybMFy+Hu/7IKnB55GHjrbkiwDu8yKHexwsQS5LZGwaVUuFXqV
 xvXqMVaI7iAJOjsDEUVeFg+du2G2PwZxmvS4PAyLBmo7SN75uPaA0BbPh3Kgy1BNrpldogix
 L556sIR7gW+jDssM8qH0X8IpzjdcCRYXvV1rIweDa/qlhEvmwNLbpHrAyPr5I2CNodXOU4wL
 z7I3KfPitywHKYZn6bfwZQV4ddguA==
IronPort-HdrOrdr: A9a23:a9eIE631wSiFxpBpzwZ6QAqjBLIkLtp133Aq2lEZdPRUGvb3qy
 mLpoV+6faUskd1ZJhOo7290cW7LU80sKQFhrX5Xo3SPjUO2lHJEGgK1+KLqFfd8m/Fh41gPM
 9bAs5D4bbLbGSS4/yU3DWF
X-IronPort-AV: E=Sophos;i="5.85,370,1624334400"; 
   d="scan'208";a="55058912"
Date: Wed, 13 Oct 2021 11:36:13 +0100
From: Anthony PERARD <anthony.perard@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, George Dunlap
	<george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>, Julien Grall
	<julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>, Wei Liu
	<wl@xen.org>, <xen-devel@lists.xenproject.org>
Subject: Re: [XEN PATCH v7 22/51] build: clean common temporary files from
 root makefile
Message-ID: <YWa2neA0zQSvkqn2@perard>
References: <20210824105038.1257926-1-anthony.perard@citrix.com>
 <20210824105038.1257926-23-anthony.perard@citrix.com>
 <dd760c79-e761-3547-726a-4d7ee092d10f@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <dd760c79-e761-3547-726a-4d7ee092d10f@suse.com>

On Mon, Oct 11, 2021 at 01:41:16PM +0200, Jan Beulich wrote:
> On 24.08.2021 12:50, Anthony PERARD wrote:
> > Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
> 
> Trying to synthesize a description:
> 
> > --- a/xen/Makefile
> > +++ b/xen/Makefile
> > @@ -382,6 +382,7 @@ _clean:
> >  	$(MAKE) $(clean) test
> >  	$(MAKE) $(kconfig) clean
> >  	find . \( -name "*.o" -o -name ".*.d" -o -name ".*.d2" \
> 
> This was effectively redundant with ...
> 
> > +		-o -name ".*.o.tmp" -o -name "*~" -o -name "core" \
> >  		-o -name "*.gcno" -o -name ".*.cmd" -o -name "lib.a" \) -exec rm -f {} \;
> >  	rm -f include/asm $(TARGET) $(TARGET).gz $(TARGET).efi $(TARGET).efi.map $(TARGET)-syms $(TARGET)-syms.map *~ core
> >  	rm -f asm-offsets.s arch/*/include/asm/asm-offsets.h
> > diff --git a/xen/scripts/Makefile.clean b/xen/scripts/Makefile.clean
> > index 027c200c0efc..b6df9e861e6e 100644
> > --- a/xen/scripts/Makefile.clean
> > +++ b/xen/scripts/Makefile.clean
> > @@ -14,10 +14,8 @@ include Makefile
> >  subdir-all := $(subdir-y) $(subdir-n) $(subdir-) \
> >                $(patsubst %/,%, $(filter %/, $(obj-y) $(obj-n) $(obj-)))
> >  
> > -DEPS_RM = $(DEPS) $(DEPS_INCLUDE)
> 
> ... this and its use below.
> 
> >  .PHONY: clean
> >  clean:: $(subdir-all)
> > -	rm -f *.o .*.o.tmp *~ core $(DEPS_RM)
> 
> With the command gone, I think the :: should also be converted (back) to
> just : then. Then

"clean" has been a double-column rule for a long time. If we convert
this rule to a single-column we need to convert all "clean" target to
use single-column which would make this patch more complicated. So I
don't think we should make this change.

> Reviewed-by: Jan Beulich <jbeulich@suse.com>
> 
> Assuming the patch is independent of the earlier still uncommitted ones
> (please confirm), I'd be happy to make the adjustment while committing
> - as long as you agree, of course.

The patch is independent of earlier one, although the context is changed
in one patch so wouldn't apply cleaning without git helps.
(context is changed in "xen: move include/asm-* to arch/*/include/asm")

Thanks,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Wed Oct 13 10:54:40 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 10:54:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.208215.364260 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mabu5-0005zC-9W; Wed, 13 Oct 2021 10:54:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 208215.364260; Wed, 13 Oct 2021 10:54:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mabu5-0005z5-6e; Wed, 13 Oct 2021 10:54:33 +0000
Received: by outflank-mailman (input) for mailman id 208215;
 Wed, 13 Oct 2021 10:54:32 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=0zCU=PB=kernel.org=helgaas@srs-us1.protection.inumbo.net>)
 id 1mabu4-0005yz-8b
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 10:54:32 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 964b750b-01f7-4d62-a3a0-1f50a6dfba9f;
 Wed, 13 Oct 2021 10:54:31 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id 85F6E60ED4;
 Wed, 13 Oct 2021 10:54:29 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 964b750b-01f7-4d62-a3a0-1f50a6dfba9f
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1634122469;
	bh=7iHTFHMgD8tHMQJ8um3MWnq2WmS30AxI0TP6/V1BtV4=;
	h=Date:From:To:Cc:Subject:In-Reply-To:From;
	b=OqtFMqGMGFV4K9yVj94P1PdYhryA/CdqOslHcpNhaQ08AmoURmbWpdbwgGLpBRtvv
	 GOsgbbkXEnNemfGxenULuEuLWhQSBLZDlcXtsIPUtWRz0Xquu4nM3on/FjIIYLKVym
	 bnMheTYnvnPKKCMeJmHy92kqkk6lJLUVe2jWrwP9ZfoZxr9KzicovqTES+nvgUJrgd
	 CW5TCOmBqfvu1ALAWILVarLhtB0Ty7o6Te/0Wlj3D4Ep4xDYZe5KxmPTRIsD28cE8M
	 U3L0ny1u+JWyxeAAoH7731EvVOLTcEPfK9OIXkjw0dh6LOeY9oV0Ng9JEnXKuTIMCX
	 IWg5mdhv7zLQg==
Date: Wed, 13 Oct 2021 05:54:28 -0500
From: Bjorn Helgaas <helgaas@kernel.org>
To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= <u.kleine-koenig@pengutronix.de>
Cc: Giovanni Cabiddu <giovanni.cabiddu@intel.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Sathya Prakash <sathya.prakash@broadcom.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	linux-pci@vger.kernel.org, Alexander Duyck <alexanderduyck@fb.com>,
	Russell Currey <ruscur@russell.cc>, x86@kernel.org,
	qat-linux@intel.com, oss-drivers@corigine.com,
	Oliver O'Halloran <oohall@gmail.com>,
	"H. Peter Anvin" <hpa@zytor.com>, Jiri Olsa <jolsa@redhat.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Marco Chiappero <marco.chiappero@intel.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	linux-scsi@vger.kernel.org, Michael Ellerman <mpe@ellerman.id.au>,
	=?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= <zajec5@gmail.com>,
	Jesse Brandeburg <jesse.brandeburg@intel.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	linux-wireless@vger.kernel.org, Jakub Kicinski <kuba@kernel.org>,
	Yisen Zhuang <yisen.zhuang@huawei.com>,
	Suganath Prabu Subramani <suganath-prabu.subramani@broadcom.com>,
	Fiona Trahe <fiona.trahe@intel.com>,
	Andrew Donnellan <ajd@linux.ibm.com>, Arnd Bergmann <arnd@arndb.de>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Ido Schimmel <idosch@nvidia.com>,
	Simon Horman <simon.horman@corigine.com>,
	linuxppc-dev@lists.ozlabs.org,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Jack Xu <jack.xu@intel.com>, Borislav Petkov <bp@alien8.de>,
	Michael Buesch <m@bues.ch>, Jiri Pirko <jiri@nvidia.com>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Namhyung Kim <namhyung@kernel.org>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Juergen Gross <jgross@suse.com>,
	Salil Mehta <salil.mehta@huawei.com>,
	Sreekanth Reddy <sreekanth.reddy@broadcom.com>,
	xen-devel@lists.xenproject.org, Vadym Kochan <vkochan@marvell.com>,
	MPT-FusionLinux.pdl@broadcom.com,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-usb@vger.kernel.org,
	Wojciech Ziemba <wojciech.ziemba@intel.com>,
	linux-kernel@vger.kernel.org,
	Mathias Nyman <mathias.nyman@intel.com>,
	Zhou Wang <wangzhou1@hisilicon.com>, linux-crypto@vger.kernel.org,
	kernel@pengutronix.de, netdev@vger.kernel.org,
	Frederic Barrat <fbarrat@linux.ibm.com>,
	Paul Mackerras <paulus@samba.org>,
	Tomaszx Kowalik <tomaszx.kowalik@intel.com>,
	Taras Chornyi <tchornyi@marvell.com>,
	"David S. Miller" <davem@davemloft.net>,
	linux-perf-users@vger.kernel.org
Subject: Re: [PATCH v6 00/11] PCI: Drop duplicated tracking of a pci_dev's
 bound driver
Message-ID: <20211013105428.GA1890798@bhelgaas>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20211013085131.5htnch5p6zv46mzn@pengutronix.de>

On Wed, Oct 13, 2021 at 10:51:31AM +0200, Uwe Kleine-K�nig wrote:
> On Tue, Oct 12, 2021 at 06:32:12PM -0500, Bjorn Helgaas wrote:
> > On Mon, Oct 04, 2021 at 02:59:24PM +0200, Uwe Kleine-K�nig wrote:
> > > Hello,
> > > 
> > > this is v6 of the quest to drop the "driver" member from struct pci_dev
> > > which tracks the same data (apart from a constant offset) as dev.driver.
> > 
> > I like this a lot and applied it to pci/driver for v5.16, thanks!
> > 
> > I split some of the bigger patches apart so they only touched one
> > driver or subsystem at a time.  I also updated to_pci_driver() so it
> > returns NULL when given NULL, which makes some of the validations
> > quite a bit simpler, especially in the PM code in pci-driver.c.
> 
> OK.
> 
> > Full interdiff from this v6 series:
> > 
> > diff --git a/arch/x86/kernel/probe_roms.c b/arch/x86/kernel/probe_roms.c
> > index deaaef6efe34..36e84d904260 100644
> > --- a/arch/x86/kernel/probe_roms.c
> > +++ b/arch/x86/kernel/probe_roms.c
> > @@ -80,17 +80,15 @@ static struct resource video_rom_resource = {
> >   */
> >  static bool match_id(struct pci_dev *pdev, unsigned short vendor, unsigned short device)
> >  {
> > +	struct pci_driver *drv = to_pci_driver(pdev->dev.driver);
> >  	const struct pci_device_id *id;
> >  
> >  	if (pdev->vendor == vendor && pdev->device == device)
> >  		return true;
> >  
> > -	if (pdev->dev.driver) {
> > -		struct pci_driver *drv = to_pci_driver(pdev->dev.driver);
> > -		for (id = drv->id_table; id && id->vendor; id++)
> > -			if (id->vendor == vendor && id->device == device)
> > -				break;
> > -	}
> > +	for (id = drv ? drv->id_table : NULL; id && id->vendor; id++)
> > +		if (id->vendor == vendor && id->device == device)
> > +			break;
> >  
> >  	return id && id->vendor;
> >  }
> > diff --git a/drivers/misc/cxl/guest.c b/drivers/misc/cxl/guest.c
> > index d997c9c3ebb5..7eb3706cf42d 100644
> > --- a/drivers/misc/cxl/guest.c
> > +++ b/drivers/misc/cxl/guest.c
> > @@ -20,38 +20,38 @@ static void pci_error_handlers(struct cxl_afu *afu,
> >  				pci_channel_state_t state)
> >  {
> >  	struct pci_dev *afu_dev;
> > +	struct pci_driver *afu_drv;
> > +	struct pci_error_handlers *err_handler;
> 
> These two could be moved into the for loop (where afu_drv was with my
> patch already). This is also possible in a few other drivers.

That's true, they could.  I tried to follow the prevailing style in
the file.  At least in cxl, I didn't see any other cases of
declarations being in the minimal scope like that.

Bjorn


From xen-devel-bounces@lists.xenproject.org Wed Oct 13 10:57:17 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 10:57:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.208225.364271 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mabwh-0006fj-Ra; Wed, 13 Oct 2021 10:57:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 208225.364271; Wed, 13 Oct 2021 10:57:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mabwh-0006fc-OW; Wed, 13 Oct 2021 10:57:15 +0000
Received: by outflank-mailman (input) for mailman id 208225;
 Wed, 13 Oct 2021 10:57:14 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=EFKL=PB=citrix.com=roger.pau@srs-us1.protection.inumbo.net>)
 id 1mabwf-0006fW-Sv
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 10:57:13 +0000
Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 51131954-2c14-11ec-816a-12813bfff9fa;
 Wed, 13 Oct 2021 10:57:12 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 51131954-2c14-11ec-816a-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1634122632;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=jSnIfmTwQlqawmP3GbudmeyDWMWAOIgm5IAeDQ5vZow=;
  b=FfDfwT9hSDTqbDbh5UPZHHVLKEu9ssAjygvrNh32nX4OBRnYAGs5Tht0
   XwHQcRtYZlUfg4F5YAfwQRuvozpsL1GYqD427AY/Ylc39+VCUo6hF8g6m
   kyhj/7PGdxsr9aDPL5QKJnuY/nWS87CCzqbH/UOyvD5d6DNJLeSDntjd8
   c=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: 0gDI79CFDBd+4qoRcS9QaPJyk/YbMofaatRAqNVd5oIphtCdsjXcGyhWeLR2TGsWspbXtBqh6O
 f25zGmEqyapmkFf0YOVZgtBo2n8+gJcm6qSxsEoaUJMCdibwgeQi1B+v2T8xfUiZk87OdloJgC
 ofbBbUVzXwmRvV/J0OvIaFLjJkyhbv/CKNsan37jM2W+qye2oGkawotgLYLkQ4TZNavWctWDjI
 vi2wXGqarOq3tNutRNsOr56k5vvfNcRSPnG5d1tDACWTqAgHNQsuhPt4ytEHQ2cacaHQxIGs+d
 3N4S56Xg5ZiPyeo2e/pVKeb4
X-SBRS: 5.1
X-MesageID: 55474993
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:4vOXWq14Y4BbNP4j/vbD5fJ3kn2cJEfYwER7XKvMYLTBsI5bp2ZTx
 msbDTqDPq2JYmD8e90jb9m/8UIEu8fdmoU2HgI6pC1hF35El5HIVI+TRqvS04J+DSFhoGZPt
 Zh2hgzodZhsJpPkS5PE3oHJ9RGQ74nRLlbHILOCan0ZqTNMEn970Es7wrVh2+aEvPDia++zk
 YKqyyHgEAfNNw5cagr4PIra9XuDFNyr0N8plgRWicJj5TcypFFMZH4rHomjLmOQf2VhNrXSq
 9Avbl2O1jixEx8FUrtJm1tgG6EAaua60QOm0hK6V0U+6/TrS+NbPqsTbZIhhUlrZzqhtukg8
 OhprIKLbCwzIoKd38ZCThlKOnQrVUFG0OevzXmXtMWSywvNcmf2wuUoB0YzVWEa0r8pWycUr
 6VecW1TKEDY7w616OvTpu1EnMMsIdOtJIoCknph0SvYHbAtRpWrr6DiuIIEg2th15sm8fD2f
 +o4dzRoMUX5ZzpyKkgKC6kRuO6sryyqG9FfgA3M/vdmi4TJ9yRz2rXwNNveevSRWN5Y2E2fo
 wru4GDREhwcctuFxlKt822urv/CmzvhX4AfH6H+8eRl6HWtwWgUBAwTREGMi/CzgU6jWPpSM
 0URvCEpqMAa71e3R9PwWxm5pn+svRMGXddUVeog52mlyLfQ4gufLngJSHhGctNOnPU/RSEuk
 GSImdzpLTV1tfueTnf13pKVpjO7PW4yN30PYQcNVw5D6N7myKkZgwjTVN9lHOiQh8fsBDDr6
 zmQqW41gLB7pcICyaiT513MhDOo4J/TQWYdzwPbRG/j1hlrdZGsfYWA4ELeq/1HKe6xXlSH+
 XQJhcWaxOQPFo2W0jyARv0XG7Ok7OrDNyfT6WODBLF4qW7roST6O9kNvncufy+FL/roZxfAW
 R7rhCdI+qR2F2G2Qv4wQd2sC9YDmP2I+cveatjYad9HY55UfQCB/T1zaUP4410BgHTAgolkZ
 s/FKZfE4WIyTP09lmLvFrh1PaoDn3hmnQvuqYbHIwNLOFZ0TEWeTqsZKxOwZ+Q94bLsTO79o
 osHaZXiJ/myVoTDjsjrHWw7cQ5iwZsTX8meRylrmgireVUO9IYJUa65/F/ZU9Y595m5b8+Rl
 p1HZmdWyUDkmVrMIhiQZ3ZoZdvHBMgk8SplYXZ0ZwrzhxDPhLpDCo9EKPPbmpF9pYReIQNcF
 aFZK61s/NweItg4x9jtRcak99EzHPharQmPIzCkcFACk21IHGT0FivfVlK3rkEmV3Pv3eNn+
 uHI/l6LEPIrGlU5ZO6LOa3H8r9ElSVE8A6EdxCTeYc7lYSF2NUCFhEdeddue5tSdk6ZmmfDv
 +tUaD9BzdTwT0YO2IChrYiPrpuzEvs4GUxfHmLB6q2xOzWc9W2mqbKsms7RFdwEfG+rqqike
 8tPyPTwbK8OkFpQ6tIuGLd316MuodDoouYCnAhjGXzKaXWtC69hfSbajZUe6PUVy+8LoxayV
 2KO5sJeZeeDNvT6HQNDPwEidOmCi60Zw2GA8fQvLUzmzyZr577bA15KNhyBhXUFfrt4OY8o2
 8k7v8sS51DtgxYmKI/e3CtV636NPjoLVKB+7sMWB4riiwwKzFBeYMODVn+qsc/XM9gVaxskO
 D6ZgqbGlo9w/EuafiphD2XJ0MpcmY8K5EJAwmgdKgnbgdHCnPI2gkFcqGxlUgRPwxxb+OtvI
 Ww3ZVZtLKCD8jo01shOW2egR1NICBGDoxGjzlIIkCvSTlWyV3yLJ2o4YL7f8Ecc+mNaXz5a4
 LDHlzq1DWe0JJn8jnkoREpoi/3/VtggpATNlfeuE9mBA5RnMyHuhbWjZDZQphbqaS/raJYre
 QW+ED5MVJDG
IronPort-HdrOrdr: A9a23:0r8WAKsZT9uI//kFC+CV40F97skD5tV00zEX/kB9WHVpW+SEko
 SVkPMHkSD1gF8qKRcdsPicPaGbW3PV8rp84YxUGbu+VE3Bs3GvKY1+4c/D7lTbak7D38ZB0K
 97aah3D/n5DV0/qcrm6E2ECN4m2tGM7aCvgqP/4h5WLT2CCpsQlzuRbzzwLqQYfmR77PYCeK
 Z0o/A3xQZIGk5nF/hTZENlYwGZnaytqHuOW3dvO/dk0njqsdrC0tDH+najsSs2YndtwawrtU
 fElAL0/by5s/anoyWss1M7v648pOfc
X-IronPort-AV: E=Sophos;i="5.85,370,1624334400"; 
   d="scan'208";a="55474993"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=U+f4JKblnrUOGsvn84ggUMOwGMelGJQl9BGpOYPC0nzJ0FRXazy9f6cSHpWEz/nW19sliKjOQoPBR3vULD+aXAF5THKSRZdh5UEKbCZeKWQ0rlZYbJZ2ytYlnLYkP3F4gz/+G/QjjpUixCINLKMaJ3bI4knZCO5J4D7hFs1ErboE38Wtdhfy4f5MLLV0eoYLqg/Z5uYRf29ES4jJKgcKvRi9IERSGvMCsvgSK5620pShRPGN0GSouRzneW/eXzU+cfV1VtAFLO9LQC2YOizT0jvuk/fLv7RiYUXzNAQN3jqolCqBlfAqM0qeAcEzfa532HHWuY474U1z/ATxo1rC3Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=qvWUaTLlMhlBbjgpRAozt5nGpRv63Sd4mitQamEdmLU=;
 b=Z0VA1xK1qohwFrBaSVvIhsLRYBUbdHO00JuzJlmO+MPEtf8LQuy4+Hd8wACL+8KcUTXyFFuPEemNOGtlXzzAdr/t4x7ZYNRwMhdRVf2z9zzDjOsYOXHbKYjgi4gQgxlIFgwh8AhDjM+sUsKA+xQ7PR/9NYK4C7NA3FrcYLmVoJGnDieV+rCDa9HtlmnU3NHp6MUPDiq8CaiCnzWJ2Tu6iD/jCvSCgnJIGWRvVipiefxNLPOvw+2YEGM3DaguMNI7qXbC50Hi60+0g5pYV8EbOpRA6byJ/FQCcJLxdrJcAVal0lyheHTnX5Ivh5NtomhC2kz/ZBtc8ugUcjHquMC9Kw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=qvWUaTLlMhlBbjgpRAozt5nGpRv63Sd4mitQamEdmLU=;
 b=JhFvFM+OGFV/KhmvgB7JxiLx/KJkeDoNfj2ZEhZ1PbnqSu+4TI2V1KW/LskSgUhwwjy2keyhNQorxSgv+Zmd9kMR1uRNjjtG3teYRmsAAdBgXUJZZznOookI/GuA37iuAMT0ATzVCQzMrdxILWfldVzcfuu52q1iCljKe6PPc3Q=
Date: Wed, 13 Oct 2021 12:56:56 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Bertrand Marquis <Bertrand.Marquis@arm.com>
CC: Michal Orzel <Michal.Orzel@arm.com>, Rahul Singh <Rahul.Singh@arm.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Andre
 Przywara <Andre.Przywara@arm.com>, Christian Lindig
	<christian.lindig@citrix.com>, David Scott <dave@recoil.org>, Ian Jackson
	<iwj@xenproject.org>, Wei Liu <wl@xen.org>, Andrew Cooper
	<andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>, Jan
 Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>, Stefano
 Stabellini <sstabellini@kernel.org>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH v5 07/11] xen/domctl: Introduce XEN_DOMCTL_CDF_vpci flag
Message-ID: <YWa7eGr3D8Ax8VUX@MacBook-Air-de-Roger.local>
References: <cover.1633540842.git.rahul.singh@arm.com>
 <20d5b9d6a0d01a7b90711d28cbefb5701a88b438.1633540842.git.rahul.singh@arm.com>
 <YWQDguvmf/O4rDIs@MacBook-Air-de-Roger.local>
 <9217a6b8-fc53-a049-7cd3-7458b574424b@arm.com>
 <YWaZKX44IOfIBtX6@MacBook-Air-de-Roger.local>
 <8F9D6B9C-58CB-4000-995A-95517EE72A3B@arm.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <8F9D6B9C-58CB-4000-995A-95517EE72A3B@arm.com>
X-ClientProxiedBy: LO2P123CA0081.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:138::14) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 5303ccd0-a81f-4934-9c88-08d98e382eaf
X-MS-TrafficTypeDiagnostic: DM6PR03MB3673:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <DM6PR03MB367363ABA6F0AB746EF45FD38FB79@DM6PR03MB3673.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: +pLKdcKpgynlg0U8OGrsH4s6XHGnrz5lD+3qvE2U/1FMTUdOONhSPGAsM/ZpdlN5YAWyTt7oljF6Zw1GH4xCFbqdmhqsef9ft9gEIdl0xTj/zEQSiv5XOmFEmtomwwZj1xjh11q/MUD4htgpjaYyFCDGwPRSA1kc9Jze0GWY29QVMw0+knMZLGjSVMIZtveuz1Xbdzaghm2aJoO6o1vXAJmJhIuW2BZT+8pi6c+LP9Pt7oMclbr8aHeHtvnGZvXFmZkVVB/n5jv+eQhuFRQUm54kK7xLWIjP/ekHTr/nKaUvTsj0Kw6JWBuiH2ZSBlH/Z746/83n00N6uGbXkGjOqvP/FSMl/ICGvC1SyhxntVfFZzveK1p6TIG/BjWEGWC1Jb0xQxlEuC4Rh0Sd7PC7pthxti2pTnKMsprXY67AUA/Pq5w3eC5rQG9ClBc8hJ59VyCFsYgLE1lyrY8fRzOtP245CuBcEnHEhk5p3O+wxDNEVGV2zLglAdv8rUeINxbDpGv6oauYQLUqPIUUPeeI16vvan92reAT9dD4dfuw7GS3tD6luYAAnBT6L7VmVryHUPFj7iBSExCRbPyqNCl41LejJr9ydySc5vBw2USEFVpBL3Yq6iWtEbYcwju4O5K1uCTwIwaX+4o/nPJulRVG1A==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(2906002)(8676002)(83380400001)(85182001)(53546011)(6666004)(82960400001)(6916009)(8936002)(38100700002)(26005)(7416002)(66946007)(66556008)(4326008)(508600001)(86362001)(5660300002)(316002)(186003)(6496006)(66476007)(6486002)(956004)(54906003)(9686003);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YzdNVTZaSkdhcjNrOXVwbzZ3amU0K1htbVozYVh6WGozbXZXOXZYbGtKajhp?=
 =?utf-8?B?ekErZlhrRFJjRk5RL2NxTFl2K2gzNEJoejdPVmd6enpNNkliK2xxVkJibW5q?=
 =?utf-8?B?dXRMaVNIWnAxem1iOFBIOHRDbVh3eExWQ21pL2hJYVdlY1BqTGVZRTIvWVc4?=
 =?utf-8?B?bGdIcmRaTTlpbzFUN0k1ZTYvUXBvUUhCNVJJUUJxNlRaU2lYcldwczZKOFBn?=
 =?utf-8?B?QnRkOFpkblFvMVROMTUyTmljUnNVcUIvamNqVmVsQmVaZ0E3Q2xvZGVaSjlt?=
 =?utf-8?B?c2ZkelBlNVgxUFVOWlVGWXZxdDVtTW1NVWx3UVdQMWpSc3FVbHltZ2dva1hl?=
 =?utf-8?B?SUthS2R1OFJmUUVRS0g1NzI0bGJVdFlOOTdQK2NWSE02SnplMUQ5blZtTU5N?=
 =?utf-8?B?QXI3QmNzVEZqb05VRzlMM1hGRFV2OHBJQjFVNUpJeXhtdjB2K3BSWWxET0dj?=
 =?utf-8?B?V2NDNnVSUTlVUFpOTG9nUXY2ajZpQlNLNk5SUzhGNDdQamd0ZENuRE94YVBH?=
 =?utf-8?B?NGJiVUE4L0lnNzljY0Q0OVh3WFluTHlvbGhSVzU4R2lLR09XOGRxVjVUK0VP?=
 =?utf-8?B?d3lDYUtYeGlSSm1peFhVZ1NaeDJ1RlJqYU5XRWdlQ2NWOEpVNW0xcytnZW16?=
 =?utf-8?B?dGpwTCtGRTlzWU1ra1Bsa0Vsc1pZaVhSelBBN1lRUXUvUTlDb0FpdVRWMG1y?=
 =?utf-8?B?N0hORGFVOVQvb3BQUXZNL0RYcjNBeUZvR1ZreXdPc2VCWWU1QjNzMHVmZjhY?=
 =?utf-8?B?eHluTUJIZ25xRXdHUjdUeERiN082VDBhTGQzTTZXVVBiNzJuSXpjamxqNjZP?=
 =?utf-8?B?UmoydHVHdC9iS0R6dkZRelBTMFpXYldQNHZYcTNJczRJRTdNOG1qd1pFZjdy?=
 =?utf-8?B?TTdHam9qNG1OTGZtUzVwa0F2bGxUa1NCajJMV2RYYTVCMWJDTVdOdmlqS0sz?=
 =?utf-8?B?bGhBMXg1R2hUWUx6RXB1VXcrTFRXMTVIdXJSbW5iYXN4KzhpT2dHRXFSSC9X?=
 =?utf-8?B?ZHkyWVVBNFZFK1JLaXJiSHRjUDNMNUl6Tms5TTFXK1pPSThlNTRsZkZMWUkv?=
 =?utf-8?B?bmZOWEFNeXdYbFI5bzdVcFBIamhBWEhFdkNrN0dhRVJFZFhNb1FRTEdVL0tS?=
 =?utf-8?B?RURoL1N5clUycWpzNzc1cmNEUlhIYmZsNzdnKzJ5UTlJaEozYitiZ3N3MTBy?=
 =?utf-8?B?cTZ3THdEMXd5SG5RNEEyRnVwbUhYNTNPMmw0VXZXeGtqaFBadVdwMUFpWDBr?=
 =?utf-8?B?cS9sa3R1ZEw0VGZvcHpDQWJMUXA2UWpLdk5tUTN6LzI1TUlpd1BFK1k3SThn?=
 =?utf-8?B?T2llc3ROTzF3OGxJUTR1ZGRQRGQydTZCSEdpckNSUnZBSmNGREtnYjdlclU4?=
 =?utf-8?B?NEI1UzFOM2Z2b3QwUzFrQlkyYk5scVlkaC9IcGZpMEpZQUdZbFgwNFcxc01u?=
 =?utf-8?B?M2tnQ2o5WnZRbk5mQm1Ta0pxbkJrWGR1OWl4Wnc1S0oxNDZJVVRsK1dxVE1M?=
 =?utf-8?B?S1J1dHRJVWszTTVKUVluckhVRzFSYjZEeW5DUlN2MjNNZDYxcytMZ3ZSRzB1?=
 =?utf-8?B?TVNDY3F2Zk5MdmNxbnQ2bFZTZjZNRlJLTXUrd2V4eVUzdVR4YVNaZm55SENz?=
 =?utf-8?B?UHhycHVxMWNtZWhEOW9WUkc1NTQrdGlEbUdGN3p1UFFBU0w4RnRsb3pBWGto?=
 =?utf-8?B?OW0vRi9tRTdlZWREOEJCTVN1NzBUUk5yRlJwNjRwZzN3bHhBdHlKNmxOMjA5?=
 =?utf-8?Q?Cqu62ih5Gcv1M7qLZuIcg6G0ukmt+Ke3W5k/eVP?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 5303ccd0-a81f-4934-9c88-08d98e382eaf
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2021 10:57:00.3882
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: eruS107mmmDiZFtyoHe5OaJyDSLoPGyUHINqXgKhr8q8fLoXJXVLgU1gKbKFvLvtl93mERXI4Xac+pEEKqSFJg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB3673
X-OriginatorOrg: citrix.com

On Wed, Oct 13, 2021 at 09:36:01AM +0000, Bertrand Marquis wrote:
> Hi Roger,
> 
> > On 13 Oct 2021, at 09:30, Roger Pau Monné <roger.pau@citrix.com> wrote:
> > 
> > On Tue, Oct 12, 2021 at 12:38:35PM +0200, Michal Orzel wrote:
> >> Hi Roger,
> >> 
> >> On 11.10.2021 11:27, Roger Pau Monné wrote:
> >>> On Wed, Oct 06, 2021 at 06:40:33PM +0100, Rahul Singh wrote:
> >>>> Introduce XEN_DOMCTL_CDF_vpci flag to enable VPCI support in XEN.
> >>>> Reject the use of this new flag for x86 as VPCI is not supported for
> >>>> DOMU guests for x86.
> >>> 
> >>> I don't like this approach, XEN_DOMCTL_CDF_vpci should be set for x86
> >>> PVH dom0, like we do for any other CDF flags when Xen builds dom0.
> >>> 
> >>> Things like PVH vs PV get translated into CDF flags by create_dom0,
> >>> and processed normally by the sanitise_domain_config logic, vPCI
> >>> should be handled that way.
> >>> 
> >>> Do you think you could see about fixing this?
> >>> 
> >>> Thanks, Roger.
> >>> 
> >> 
> >> I have one question about this fix.
> >> If I set XEN_DOMCTL_CDF_vpci for dom0 pvh in create_dom0, then in
> >> sanitise_domain_config or arch_sanitise_domain_config I have no
> >> knowledge on whether I am dom0 or not. I can check if I'm PVH but not if dom0.
> >> This would be needed to add a warning if this flag is set but we are not dom0 pvh.
> >> 
> >> Any ideas?
> > 
> > I've just realized this is more wrong that I thought. vPCI is
> > signaled on x86 in xen_arch_domainconfig.emulation_flags, so
> > introducing a top level option for it without removing the arch
> > specific one is wrong, as then on x86 we have a duplicated option.
> > 
> > Then I'm also not sure whether we want to move it from
> > emulation_flags, it seems like the more natural place for it to live
> > on x86.
> > 
> > If we really want to make vPCI a CDF option we must deal with the
> > removal of XEN_X86_EMU_VPCI, or else you could introduce an arch
> > specific flag for vPCI on Arm.
> 
> First issue that we have here is that there is no emulation_flags right now on arm.

You don't explicitly need an emulation_flags field, you could add a
uint8_t vpci or some such to xen_arch_domainconfig for Arm if you
don't think there's a need to select more emulation. That's up to Arm
folks.

> So I think there are 2 solutions:
> 
> - introduce PHYSCAP. The problem here is that it is not a physical capacity and
> I think that will hit us in the future for example if we want to use vpci for VIRTIO
> even if there is not physical PCI on the platform.

Hm, PHYSCAP is a bit weird, for example Xen signals shadow paging
support using PHYSCAP which doesn't depend on any hardware feature.

I think you could signal vPCI regardless of whether the underlying
platform has PCI devices or not, as vPCI is purely a software
component.

Regarding VirtIO, won't it be implemented using ioreqs in user-space,
and thus won't depend on vPCI?

> - introduce an emulation flag on arm. The problem here is that there is no emulation
> flag right now on arm so adding this feature will require a change of interface in
> arch-arm.h and in xen domctl interface. But if we introduce one on Arm, it would allow
> the tools to check if CDF_vpci can be set or not which would solve current issues.

I'm not sure I follow. If we go the emulation flags route this will all
be set in xen_arch_domainconfig, and CDF_vpci will completely go away.

> I think the second solution is the right one but it cannot be done so near from the
> feature freeze.
> 
> The CDF flag as introduced right now is not creating any issue and will be used once
> the emulation flag will be introduce. We will be able at this stage to set this properly
> also on x86 (for dom0 pvh).
> Moreover keeping it will allow to continue to merge the remaining part of the PCI
> passthrough which are otherwise not possible to be done as they are dependent on this flag.
> 
> Can we agree on keep the DOMCTL_CDF_vpci flag and introduce the emulation
> flag on Arm after 4.16 release ?

If vPCI for Arm on 4.16 is not going to be functional, why so much
pressure in pushing those patches so fast? I understand the need to
remove stuff from the queue, but I don't think it's worth the cost of
introducing a broken interface deliberately on a release.

I think we need to at least settle on whether we want to keep
CDF_vpci or use an arch specific signal mechanism in order to decide
what to do regarding the release.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Wed Oct 13 10:58:02 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 10:58:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.208230.364282 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mabxS-0007FF-63; Wed, 13 Oct 2021 10:58:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 208230.364282; Wed, 13 Oct 2021 10:58:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mabxS-0007F8-3D; Wed, 13 Oct 2021 10:58:02 +0000
Received: by outflank-mailman (input) for mailman id 208230;
 Wed, 13 Oct 2021 10:58:00 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=iVjq=PB=citrix.com=anthony.perard@srs-us1.protection.inumbo.net>)
 id 1mabxQ-0007F0-DG
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 10:58:00 +0000
Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 6cef16f0-2c14-11ec-816a-12813bfff9fa;
 Wed, 13 Oct 2021 10:57:58 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6cef16f0-2c14-11ec-816a-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1634122679;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=rrsB4Jhdti/bqz7YcnGxLIbD/QKw3Vi96aH8IulGzpQ=;
  b=NQUZ8NHTkFK2g9qsYEcObzUuMXuPkxcIr4zmQSA0WIcNr14xVuKs0nTt
   O96p6SHJJBTpCE8ZPbWi1gH59din2J68Dk7kuvs+dLmvyfzZIUi2Ri4W/
   RTSys0YUIWQFLjpi9BEe8PpaldnsoEJqySkf9AcVsifPo9VbyE5RPgMaL
   c=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: 9aw6QF7gd3EGIj02fAF/tqqup6WIU9pNfpN8wkAqF5WtwgVflP6pHAtk+gE9Dmf6GA3zdz/c7Z
 b/eER/f473kLZ7gUIsvyR9hHZjavIEyEwfTsW33cDS2z+pWkVhBnjeJ17WR7Pdd7qgc2Yjbewi
 Ck/lgLQq9g9nNBYaSgx13McUT9P5yV2oEXezsrGPC/UbCa4DJc7F9ljHgqGJvwM2veTRl+H+KN
 TO1X3nwTFiyg1Y5G4hySFDMZU4ZVp9Fyo4Udxeke621TeEQpZVca7jjRS0rTONvIclsM8RC0EA
 acGjFaTNkGN+jWcW4VqkDA4d
X-SBRS: 5.1
X-MesageID: 55475035
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:zxZJPKwuugFiJ2tdgo56t+drwCrEfRIJ4+MujC+fZmUNrF6WrkVRz
 2YcWG2GMq6PNmH2f4wiPIS1o0JS6pfRy4drGQE5qyAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx
 59DAjUVBJlsFhcwnvopW1TYhSEUOZugH9IQM8aZfHAsLeNYYH1500s6w7di2tcAbeWRWGthh
 /uj+6UzB3f9s9JEGjp8B3Wr8U4HUFza4Vv0j3RmDRx5lAa2e0o9VfrzEZqZPXrgKrS4K8bhL
 wr1IBNVyUuCl/slIovNfr8W6STmSJaKVeSFoiI+t6RPHnGuD8H9u0o2HKN0VKtZt9mGt9Zxx
 Y5ilpyidSsCMPLGt/wiTRthED4raMWq+JefSZS+mcmazkmAeHrw2fR+SkoxOOX0+M4uXzsIr
 6ZBbmlQMFbT3Ipaw5riIgVors0lMMnsOpJZonx6xCvVJf0nXYrCU+PB4towMDIY250SQquGP
 JdxhTxHYVP6ORNsFkgsI6ksmumohSbZVixhkQfAzUYwyzeKl1EguFT3C/LZddCHSt9ctlqJr
 WLBuWLiC1cVM8L34QSC9nWgl+rehxTRUYgZFKC73vNyiVjVzWsWYDUGWF3+rfSnh0qWX9NEN
 1dS6icotbI19kGgUp/6RRLQiHKcpRsdR9p4GvU38h2Q0bHT5xuFB28CVXhKb9lOnNAybSwn0
 BmOhdyBLT1wspWFRHSF7LCWoDiufy8PIgcqZyUJUA8E6NnLu5wog1TESdMLOLWuktT/FDX0w
 jaLhCsznbMeiYgMzarT1VLahzOhoLDZQwhz4R/YNl9J9SsgOtTjPdbxrwGGs7AQd+51U2Vto
 lACm8XFw8MOH62hvyLSSsoVI6+r3vWaZWi0bUFUI7Et8DGk+niGdI9W4S1jKEoBDvvoaQMFc
 2eI5lsPvM470G+CKPYtOdroWptCIb3ITIy9Dpjpgsxyjo+dneNt1BplYlKMxCjTmUwonLBX1
 XyzIJv0Uyhy5UiKylOLqwYhPV0Dmn5WKYD7H8mTI/GbPVy2PyH9pVAtagrmUwzBxPnYyDg5C
 v4GXydw9z1RUfflfg7c+pMJIFYBIBATXM6t95QJKrTbeFY9RAnN7sM9J5t6JOSJeIwPx4/1E
 oyVABcEmDITe1WWQel1VpyTQOy2BssuxZ7KFSctIUypyxAejXWHt88im28MVeB/roRLlKcsJ
 9FcIpnoKqkfG1zvpmVGBbGg/dMKSfherV/XV8ZTSGNkJMAIqs2g0oKMQzYDAwFXVnDp6pBk/
 +H5vu4ZKLJaLzlf4A/tQKrH5zuMUbI1woqehmPEfYteflvC6o9vJ3Cjh/M7OZhUex7C2iGbx
 0CdBhJB/bvBpIo88d/og6GYrtj2T7siTxQCR2SLv6yrMST6/3a4xdMSWui/Yj2ABnj//7+vZ
 LsJwqikYuEHhltDr6F1D61vkfAl/9LqqrIDllZkEXzHYk6FELRlJnXaj8BDurcUnu1SuBesW
 1LJ8d5fYO3bNMTgGV8XBQwkcuXciq1ExmiMtaw4eRyo6jV28byLVVRpEyON0CENfqFoNI4Fw
 Ps6vJJE4QKIlRd3YM2NiTpZ9jrQIyVYAbknrJwTHKTilhEvlgNZeZXZByL7vMOPZtFLPhV4K
 zOYnvOf1bFVx06EeHsvD3ndm+FagM1W6hxNyVYDIXWPm8bE2aBrjEEAr2xvQ1QH1AhD3sJyJ
 nNvZh98Kqi59jt1gNROAjK3EAZbCRzFokH8xjPlToECo5VEgoAVEFAABA==
IronPort-HdrOrdr: A9a23:m0qQ/aADBMoBFhnlHems55DYdb4zR+YMi2TC1yhKJyC9Vvbo8/
 xG/c5rsCMc5wx9ZJhNo7y90ey7MBThHP1OkOss1NWZPDUO0VHAROoJ0WKh+UyCJ8SXzJ866U
 4KSclD4bPLYmRHsQ==
X-IronPort-AV: E=Sophos;i="5.85,370,1624334400"; 
   d="scan'208";a="55475035"
Date: Wed, 13 Oct 2021 11:57:30 +0100
From: Anthony PERARD <anthony.perard@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, George Dunlap
	<george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>, Julien Grall
	<julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>, Wei Liu
	<wl@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, Roger Pau
 =?iso-8859-1?Q?Monn=E9?= <roger.pau@citrix.com>, Daniel De Graaf
	<dgdegra@tycho.nsa.gov>, "Daniel P. Smith" <dpsmith@apertussolutions.com>,
	<xen-devel@lists.xenproject.org>
Subject: Re: [XEN PATCH v7 24/51] build: prepare to always invoke $(MAKE)
 from xen/, use $(obj)
Message-ID: <YWa7ms9QIV4szv9x@perard>
References: <20210824105038.1257926-1-anthony.perard@citrix.com>
 <20210824105038.1257926-25-anthony.perard@citrix.com>
 <430f6b64-e255-1250-1afb-a596a57ed1a9@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <430f6b64-e255-1250-1afb-a596a57ed1a9@suse.com>

On Mon, Oct 11, 2021 at 02:39:26PM +0200, Jan Beulich wrote:
> On 24.08.2021 12:50, Anthony PERARD wrote:
> > In a future patch, when building a subdirectory, we will set
> > "obj=$subdir" rather than change directory.
> > 
> > Before that, we add "$(obj)" and "$(src)" in as many places as
> > possible where we will need to know which subdirectory is been built.
> > "$(obj)" is for files been generated during the build, and "$(src)" is
> > for files present in the source tree.
> > 
> > For now, we set both to "." in Rules.mk and Makefile.clean.
> > 
> > A few places don't tolerate the addition of "./", this is because make
> > remove the leading "./" in targets and dependencies in rules, so these
> > will be change later.
> > 
> > Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
> 
> Acked-by: Jan Beulich <jbeulich@suse.com>
> 
> Nevertheless a couple of remarks:
> 
> > --- a/xen/arch/x86/Makefile
> > +++ b/xen/arch/x86/Makefile
> >[...]
> > @@ -192,25 +192,25 @@ note_file_option ?= $(note_file)
> >  
> >  ifeq ($(XEN_BUILD_PE),y)
> >  extra-y += efi.lds
> 
> What about this? Does this for some reason also fall into the "cannot
> be converted yet" group?

$(extra-y) is treated the same way as $(obj-y), it is used to list item
to build in the current subdirectory. So there is no need to add $(obj)/

> > @@ -222,14 +222,14 @@ $(TARGET).efi: FORCE
> >  endif
> >  
> >  # These should already have been rebuilt when building the prerequisite of "prelink.o"
> > -efi/buildid.o efi/relocs-dummy.o: ;
> > +$(obj)/efi/buildid.o $(obj)/efi/relocs-dummy.o: ;
> >  
> >  .PHONY: include
> >  include: $(BASEDIR)/arch/x86/include/asm/asm-macros.h
> >  
> > -asm-macros.i: CFLAGS-y += -D__ASSEMBLY__ -P
> > +$(obj)/asm-macros.i: CFLAGS-y += -D__ASSEMBLY__ -P
> >  
> > -$(BASEDIR)/arch/x86/include/asm/asm-macros.h: asm-macros.i Makefile
> > +$(BASEDIR)/arch/x86/include/asm/asm-macros.h: $(obj)/asm-macros.i $(src)/Makefile
> 
> Isn't this $(obj)/include/asm/asm-macros.h ? And in general doesn't
> use of $(BASEDIR) need to go away then, e.g. ...

I've limited this patch to add $(obj)/ and $(src)/ were needed, I think.

And yes, BASEDIR will need to go away.

> > --- a/xen/arch/x86/boot/Makefile
> > +++ b/xen/arch/x86/boot/Makefile
> > @@ -1,8 +1,8 @@
> >  obj-bin-y += head.o
> >  
> > -DEFS_H_DEPS = defs.h $(BASEDIR)/include/xen/stdbool.h
> > +DEFS_H_DEPS = $(src)/defs.h $(BASEDIR)/include/xen/stdbool.h
> 
> ... here needing to become $(src)/../../../include/xen/stdbool.h ?

BASEDIR will be dealt with later.

> > --- a/xen/scripts/Makefile.clean
> > +++ b/xen/scripts/Makefile.clean
> > @@ -3,11 +3,14 @@
> >  # Cleaning up
> >  # ==========================================================================
> >  
> > +obj := .
> > +src := $(obj)
> 
> This repeats what is also getting added to Rules.mk. To prevent
> the two going out of sync, wouldn't they better live in a central
> place (e.g. scripts/defs.mk)?

It looks like they are the same but they are not, it doesn't matter if
they go out of sync, and they actually do in my patch series.

Thanks,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Wed Oct 13 11:00:13 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 11:00:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.208239.364293 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mabzV-0000Dd-J6; Wed, 13 Oct 2021 11:00:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 208239.364293; Wed, 13 Oct 2021 11:00:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mabzV-0000DW-Fk; Wed, 13 Oct 2021 11:00:09 +0000
Received: by outflank-mailman (input) for mailman id 208239;
 Wed, 13 Oct 2021 11:00:08 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=h1Wz=PB=pengutronix.de=ukl@srs-us1.protection.inumbo.net>)
 id 1mabzU-0000Cf-QW
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 11:00:08 +0000
Received: from metis.ext.pengutronix.de (unknown
 [2001:67c:670:201:290:27ff:fe1d:cc33])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 6c707909-7517-4868-b47c-f214dba21344;
 Wed, 13 Oct 2021 11:00:06 +0000 (UTC)
Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2])
 by metis.ext.pengutronix.de with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92)
 (envelope-from <ukl@pengutronix.de>)
 id 1mabyZ-0005e3-LW; Wed, 13 Oct 2021 12:59:11 +0200
Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de)
 by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.92)
 (envelope-from <ukl@pengutronix.de>)
 id 1mabyL-0005Lr-7I; Wed, 13 Oct 2021 12:58:57 +0200
Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.92)
 (envelope-from <ukl@pengutronix.de>)
 id 1mabyL-0007HS-2y; Wed, 13 Oct 2021 12:58:57 +0200
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6c707909-7517-4868-b47c-f214dba21344
Date: Wed, 13 Oct 2021 12:58:56 +0200
From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Giovanni Cabiddu <giovanni.cabiddu@intel.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Sathya Prakash <sathya.prakash@broadcom.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	linux-pci@vger.kernel.org, Alexander Duyck <alexanderduyck@fb.com>,
	Russell Currey <ruscur@russell.cc>,
	Jesse Brandeburg <jesse.brandeburg@intel.com>,
	oss-drivers@corigine.com, netdev@vger.kernel.org,
	Oliver O'Halloran <oohall@gmail.com>,
	"H. Peter Anvin" <hpa@zytor.com>, Jiri Olsa <jolsa@redhat.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Paul Mackerras <paulus@samba.org>,
	Marco Chiappero <marco.chiappero@intel.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	linux-scsi@vger.kernel.org, Michael Ellerman <mpe@ellerman.id.au>,
	Ido Schimmel <idosch@nvidia.com>, x86@kernel.org,
	qat-linux@intel.com, Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	=?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= <zajec5@gmail.com>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Jakub Kicinski <kuba@kernel.org>,
	Yisen Zhuang <yisen.zhuang@huawei.com>,
	Frederic Barrat <fbarrat@linux.ibm.com>,
	Fiona Trahe <fiona.trahe@intel.com>,
	Andrew Donnellan <ajd@linux.ibm.com>, Arnd Bergmann <arnd@arndb.de>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Suganath Prabu Subramani <suganath-prabu.subramani@broadcom.com>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Jack Xu <jack.xu@intel.com>, Borislav Petkov <bp@alien8.de>,
	Michael Buesch <m@bues.ch>, Jiri Pirko <jiri@nvidia.com>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Namhyung Kim <namhyung@kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Juergen Gross <jgross@suse.com>,
	Salil Mehta <salil.mehta@huawei.com>,
	Sreekanth Reddy <sreekanth.reddy@broadcom.com>,
	xen-devel@lists.xenproject.org, Vadym Kochan <vkochan@marvell.com>,
	MPT-FusionLinux.pdl@broadcom.com, linux-usb@vger.kernel.org,
	linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
	"David S. Miller" <davem@davemloft.net>,
	Mathias Nyman <mathias.nyman@intel.com>,
	Zhou Wang <wangzhou1@hisilicon.com>, linux-crypto@vger.kernel.org,
	kernel@pengutronix.de,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Simon Horman <simon.horman@corigine.com>,
	Wojciech Ziemba <wojciech.ziemba@intel.com>,
	Tomaszx Kowalik <tomaszx.kowalik@intel.com>,
	linuxppc-dev@lists.ozlabs.org, Taras Chornyi <tchornyi@marvell.com>,
	linux-perf-users@vger.kernel.org
Subject: Re: [PATCH v6 00/11] PCI: Drop duplicated tracking of a pci_dev's
 bound driver
Message-ID: <20211013105856.yve6n5zu625im5fo@pengutronix.de>
References: <20211013085131.5htnch5p6zv46mzn@pengutronix.de>
 <20211013105428.GA1890798@bhelgaas>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="52e44hxpwffbx22b"
Content-Disposition: inline
In-Reply-To: <20211013105428.GA1890798@bhelgaas>
X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2
X-SA-Exim-Mail-From: ukl@pengutronix.de
X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false
X-PTX-Original-Recipient: xen-devel@lists.xenproject.org


--52e44hxpwffbx22b
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hello,

On Wed, Oct 13, 2021 at 05:54:28AM -0500, Bjorn Helgaas wrote:
> On Wed, Oct 13, 2021 at 10:51:31AM +0200, Uwe Kleine-K=F6nig wrote:
> > On Tue, Oct 12, 2021 at 06:32:12PM -0500, Bjorn Helgaas wrote:
> > > diff --git a/drivers/misc/cxl/guest.c b/drivers/misc/cxl/guest.c
> > > index d997c9c3ebb5..7eb3706cf42d 100644
> > > --- a/drivers/misc/cxl/guest.c
> > > +++ b/drivers/misc/cxl/guest.c
> > > @@ -20,38 +20,38 @@ static void pci_error_handlers(struct cxl_afu *af=
u,
> > >  				pci_channel_state_t state)
> > >  {
> > >  	struct pci_dev *afu_dev;
> > > +	struct pci_driver *afu_drv;
> > > +	struct pci_error_handlers *err_handler;
> >=20
> > These two could be moved into the for loop (where afu_drv was with my
> > patch already). This is also possible in a few other drivers.
>=20
> That's true, they could.  I tried to follow the prevailing style in
> the file.  At least in cxl, I didn't see any other cases of
> declarations being in the minimal scope like that.

I don't care much, do whatever you consider nice. I'm happy you liked
the cleanup and that you took it.

Best regards
Uwe

--=20
Pengutronix e.K.                           | Uwe Kleine-K=F6nig            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

--52e44hxpwffbx22b
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEfnIqFpAYrP8+dKQLwfwUeK3K7AkFAmFmu+0ACgkQwfwUeK3K
7AnoGgf+Org0o7CctF9VMJ1cRL0/n994P0Xf4J0pVgDihRJKx2m6225saLIOfR9c
tezswS1SpHGF0jh6VVcc26om68F6diINTuhV9HjdShrJ3OqoifBqUQ+ggPRWVaT5
KB06t/1umM6bzcXmVvhwDX4+amPeFwfSPynHBfhudbA6DLwhCVuJk+109EvvuLlm
u79Qp7+p4PyMwo699ubwQFekrSsf72gzSOfuRBPqHqx0SWbSUPlUyLyolxtsUD22
7/ex/TOt2JrmP7lFEfLhrONg7BvlEBUokQ5MGQqxdyP/djPUVbtDoM3iX0kC7x2A
Fa44dFbWF/D3+K4X5Cesu+BfzXP+rA==
=xGeM
-----END PGP SIGNATURE-----

--52e44hxpwffbx22b--


From xen-devel-bounces@lists.xenproject.org Wed Oct 13 11:12:11 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 11:12:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.208248.364305 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1macB1-0001pE-Pg; Wed, 13 Oct 2021 11:12:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 208248.364305; Wed, 13 Oct 2021 11:12:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1macB1-0001p7-Lz; Wed, 13 Oct 2021 11:12:03 +0000
Received: by outflank-mailman (input) for mailman id 208248;
 Wed, 13 Oct 2021 11:12:02 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=EFKL=PB=citrix.com=roger.pau@srs-us1.protection.inumbo.net>)
 id 1macB0-0001p1-1A
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 11:12:02 +0000
Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 627386fa-2c16-11ec-816b-12813bfff9fa;
 Wed, 13 Oct 2021 11:12:00 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 627386fa-2c16-11ec-816b-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1634123519;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=GBE5d2K/zjOBjfvTSkFIyrLUsnp5VAa23PxNGKDpGVE=;
  b=Sk9/SYE94LShZ3Y/+XEkKv5PQQ4IOCaAQD1fCIV9/myebpOWFg5FGJvi
   ytUYkoZHg7NNCkG5Fg+u59tvUO3Aw5+HyM8bSjjLkMvddwT0sWzCtY6Kh
   ydffqI9JZfXkHlC0S6EUf68PYOC2Rx9+CZ6s7JXypyXrHP6S8oyo/38fh
   E=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: dx/HC7w/qIsp5F7+hx8aUqRQH3Ka1swsBAdkskY4Oq13s4Az6LrB/1dW5P8/vOxkwSDb1mqi0p
 WmiMsWQj7sJqtF8D7B9jO3/t/1FJ0IeLFZuXNHcn3q2X0LJ/dUy7xob7zgX3H+AQDgrx3KUFp8
 647FDpslMZtkE/M2SmqlLG1HbQMtgut7WmD6CYjGCHRDpaQCr0aNaJsPRSeiSU4aiq2qilmodh
 OtNVE545f5c6hgn+YarLHI4yEKhjJt5f4tBp6EDf4jfND57/0oMzaEstqliS/B8FDlhinqrfq/
 mjQjLNULZ15W3gE7WWIl6JKM
X-SBRS: 5.1
X-MesageID: 56953482
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:Xp/oRaJBTYwPHGMUFE+RHJMlxSXFcZb7ZxGr2PjKsXjdYENS1TZSz
 zdMCmnUaP+MN2X9edh0YIuz/UkDu5/Rz98yT1NlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s
 q3yv/GZdJhcokcxIn5BC5C5xZVG/fjgqoHUVaiUZ0ideSc+EH140Eo6wLZg6mJVqYPR7z2l6
 IuaT/L3YDdJ6xYsWo7Dw/vewP/HlK2aVAIw5jTSV9gS1LPtvyB94KYkDbOwNxPFrrx8RYZWc
 QphIIaRpQs19z91Yj+sfy2SnkciGtY+NiDW4pZatjTLbrGvaUXe345iXMfwZ3u7hB27p+x09
 vJy66b3biUCGqqVgtYXCylxRnQW0a1uoNcrIFC6uM2XiUbHb2Ht07NlC0Re0Y8wo7gtRzsUr
 LpBdW5LPkvra+GemdpXTsF2gcsuNo/zNZ43sXB81zDJS/0hRPgvRo2Xu44Fh2tg3KiiG97ad
 /c1OAdPYijtIEYfOQc2Jch5ltmB0yyXnzpw9wvO+PtfD3Lo5AZ8yqT3OdzZPNmDX9xIn12wr
 3jDuW/+B3kyNtaS1D6E+XKEnfLUkGXwX4d6PJSi6vNvt3iCyWUSBQM+WEOypL+yjUvWc9deI
 Ewd/mwpt7o/8GSiVNy7VBq9yFaDuhMfQNNWH/cN4QeB0LfP4w2ZC24HSRZMcNUj8sQxQFQCz
 FaJgtevHj1pv729QGiYsLyTqFuaOzURLGIETT8JS00C+daLiJE+iFfDQ8huFIaxj8bpAnfgz
 jaSti88ir4Py8kR2M2T9FbLmWj0/sDhQQs85wGRVWWghitnY4qia52t+ELs5/9KJ4aETXGMp
 HEB3cOZ6YgmCpWAlzeERukXK624/PaOMDDagllHEoEo8nKm/HvLVZtL/Dh0KUNtM8AFUTzke
 knevUVW/pA7AZexRfYpOcTrUZ1slPW+U4S+PhzJUjZQSqpJSAq52x4wXwm3/UvJlxE2o6tnC
 b7OJK5AEk0mIahgyTO3QcIU3rkq2j0yyAvveHzr8/i0+eHBPCDNGN/pJHPLN7pjtPrV/2055
 v4Gb5PSoyizRtESdcU+HWQ7FlsNMWQgTa7/r8haZ4ZvySI3RTl/VZc9LV4nErGJfpi5dM+Uo
 BlRuWcCkTITYEErzy3RNRiPj5u1DP5CQYoTZ3BEALpR8yFLjXyTxKkebYArWrIs6fZuy/V5J
 9FcJZ7cWqoTEGydp29BBXUYkGCEXE/07e5pF3D0CAXTgrY6H1CZkjMaVlqHGNYy4tqf6pJl/
 uzIOvLzSpsfXQVyZPs6m9r0p25dSUM1wbooN2ORe4E7UBy1rOBCdnyg5tdqcppkAUiSmVOnO
 /O+XE5wSR/l+NRurrEkRMms8u+ULgeJNhMCRTeEtuzqaXCyE6jK6dYobdtktAv1DQvc0K6je
 f9U37f7NvgGl0xNqI1yD/BgyqdW2jclj+IyIt1MECqZYlK1JKlnJ3Xaj8BDurcUnu1SuBesW
 1LJ8d5fYO3bNMTgGV8XBQwkcuXciq1ExmiMtaw4cBfg+St63LubSkEObROCvzNQceluO4Q/z
 OZ/5MNPs16jigAnO8qthzxP8zjeNWQJVqgq78lIAILihgcx5EtFZJjQVn3/7J2VMo0eOUg2O
 D6EwqHFgu0ElEbFdnMyE1nL3PZc2stS6EwbkgdaKg3QyNTfh/Ix0BlAyhgNT1xYnkddzuZ+G
 ml3LEkpd6+AyChl2ZpYVGe2FgAfWBDAoh7ty0EEnXHyRlWzUjCfN3U0POuA8RxL829YeTQHr
 riUxHy8DGTvdcD1mCAzRVRku7roStkorl/On8WuHsKkGZgmYGW63v/yNDRQ8xa3U9ksgEDnp
 PVx+LciYKL2AiccvqknBtTIzr8XUh2FeDRPTPwJEHnlxo0AlOVeAQSzFn0=
IronPort-HdrOrdr: A9a23:BIT84agjL9DrFRog5I4qbB0cf3BQXzx13DAbv31ZSRFFG/FwyP
 rBoB1L73DJYWgqNE3I+erhBEGBKUmsk6KdxbNhQItKPTOWwldASbsC0WKM+UyEJ8STzJ846U
 4kSdkDNDSSNykKsS+Z2njBLz9I+rDum8rE9ISurQYccegpUdAa0+4QMHfkLqQcfng+OXNWLu
 v62iIRzADQBkj/I/7LTEUtbqzmnZnmhZjmaRkJC1oO7xSPtyqh7PrfHwKD1hkTfjtTyfN6mF
 K13zDR1+GGibWW2xXc32jc49B/n8bg8MJKAIiphtIOIjvhpw60bMBKWqGEvhoyvOazgWxa3e
 XkklMFBYBe+nnRdma6rV/E3BTh6i8n7zvYxVqRkRLY0IXEbQN/L/AEqZNScxPf5UZllsp7yr
 h302WQsIcSJQ/cnQzmjuK4Fi1Cpw6Rmz4PgOQTh3tQXc81c7lKt7ES+0tTDdMpAD/60oY6C+
 NjZfusqsq+SWnqLEwxg1MfguBFBh8Ib1K7qwk5y4OoOgFt7TBEJxBy/r1aop8CnKhNPaWsqd
 60dZiAr4s+PPP+W5gNc9vpcfHHeVAlfii8RV56AW6XXJ3vaEi94KIe3t0OlZWXkdozvd0PpK
 g=
X-IronPort-AV: E=Sophos;i="5.85,370,1624334400"; 
   d="scan'208";a="56953482"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=bfGYgkozpzMVVPTEfNc8aNzNN9Qn+Xfjr8a+zCNUdaAWOlJh7XnOer/t8vkAKtHweBMUE430ij1wp/AzZ5V2qSuQNDPE79EtMT5TK7Bw74n4JaWlKrKKQ1fqm1DOUClUMWlPTpEcMJyOtnjqoy5Sa9V7OYnVj2HrOB35alog3tsDX5L2z7wFC3QHa5PgVaylYCCLm3cAlVLNgU2pFfQGpmml6a6MkhVOurCPZaxxLh8rsCdrDna+e1cYyylWkW8nh4FG8IXIs1sm0K0pMq+xgunTo3mdenC7D/Hiq6Yvv4x/GahJsMkQFuTUtr/xiOs8M2DVgztwYfKhkXnS6NwlLg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=h7OQN7BI/Pam2ZgJKQI4eQX42gLcyydSXTJrvLWaQEY=;
 b=T98yJItHVzeVRboQoqbpg0UfzDuYJ9OL3rF3M+pWXDu+jqvKeCrMLGW7LbcjrjIZkeU5kDgFE8+oS2RVWqLQwD+4D1Z03mYRI7KCoBR6wcb2CHniznUS5rn6LUfnvba9xNBAEj3mHn9q6cFXR9gHOKWWP3rU5lsG1wrzP12WMz+FQejzaVOpGU0bTkCsyv1RqJ29nfIs33HnE/C/HUp+e+1uQzxcGuXwV5pJvGpaImKECX5oJfRFXckvS8GwTA4pxhJFn3l9FGYvK7yTCrztqGHLgd9ITfiSITVk7VSGGhJtbgfFn5OijwEUbDLC6WHISEk3PPna1wUqliP4HGUhKA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=h7OQN7BI/Pam2ZgJKQI4eQX42gLcyydSXTJrvLWaQEY=;
 b=ac6UwGUjHa64Q4DWUyDlohmEWM5Rp4V8IO/ftMZoXhaNAOWtVdQtJgb+LCTN7NQ8WVA7yVuXbPnwDfItD7ubkMhlNentOjgI2RI18becnXMjP9Vxrmw0zDPOCmiirMKLGRaxjEL6Ek+3pyji5RWQWvXZSlPobLLLDTMyEpdGDRE=
Date: Wed, 13 Oct 2021 13:11:30 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Oleksandr Andrushchenko <andr2000@gmail.com>
CC: <xen-devel@lists.xenproject.org>, <julien@xen.org>,
	<sstabellini@kernel.org>, <oleksandr_tyshchenko@epam.com>,
	<volodymyr_babchuk@epam.com>, <Artem_Mygaiev@epam.com>, <jbeulich@suse.com>,
	<bertrand.marquis@arm.com>, <rahul.singh@arm.com>, Oleksandr Andrushchenko
	<oleksandr_andrushchenko@epam.com>, Michal Orzel <michal.orzel@arm.com>
Subject: Re: [PATCH v3 01/11] vpci: Make vpci registers removal a dedicated
 function
Message-ID: <YWa+4hsaOxuX4tWJ@MacBook-Air-de-Roger.local>
References: <20210930075223.860329-1-andr2000@gmail.com>
 <20210930075223.860329-2-andr2000@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20210930075223.860329-2-andr2000@gmail.com>
X-ClientProxiedBy: LO4P123CA0379.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:18f::6) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 71e51602-4e99-4119-36cd-08d98e3a3817
X-MS-TrafficTypeDiagnostic: DM6PR03MB5273:
X-Microsoft-Antispam-PRVS: <DM6PR03MB52735BB6A240413D9FFBFB018FB79@DM6PR03MB5273.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:3173;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: ArjVHeH0qheoi/uWNDwL439KzxiAQV05rQk8fsXVIH18VoUdfxi4+BmjEld7BmHXeIt2CAkTeehxOLP5THgSMG75pKof/xRlWroWpPEyanlRLubrq9FKw8FI9ekr8CL49g3Yt/Fv4pIRv95JFdVdLHkjy0EWvU6GY09B87B/uZI+vUmNzrEvooPDcdHjJfu/3jGw8+JDm4WsFlRSGklFQpBOtCNgbgt33jnUZyxZT++Q/VbktwVSD34KD0m07F5SOy4omHgCKypo6877iUu8m1zO4ZjaVfNQHa130HSJUjmvaNniunnQdlNbvjx35Jr/uf0ss2lLUn86JhMchz3/LyhX3rtLOuMkUjWXed9pHI1BIj9WYcvKHozrtDWlrN0wdutXJ1qMyeBxe85RNhGK5AgVcymgqotb1DRGUx/EliESMeV3hUt/2c1OYR5/4SPw3FhASa7lxfu+tU71t/Y2ac1gWTRAcO/EFc4e8ORPddIxP7Pe+Nimr+y1DKnDcymWaVMzv+Y+Rbj5nTlA4/xw2cEXgB9OrbggRAh2LvTAE0j+PwmALbG9yDYebqBreeFKHnKINURqOHxT8VdGGW1PiJ9g6lnxaDQAett3appkVqeqrd9rWin5e4Jnz+0Kjb8srH19tlYIeTqRaYpLSM4wgStS/bg7qWL/cMVs1z77Akqp0HQz5EkITFvejfXKc2OTmn4R2WZRDwq147WbLAfcIw==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(5660300002)(6496006)(54906003)(26005)(4326008)(86362001)(186003)(85182001)(2906002)(6916009)(316002)(7416002)(83380400001)(508600001)(956004)(8676002)(66476007)(66556008)(6486002)(8936002)(38100700002)(82960400001)(9686003)(6666004)(66946007)(67856001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VFI0alJ5c3k1Ni9jUVQzemJZRzZBd2h3b1E2WWp2NlpFVTFTclg0K0FHM1BM?=
 =?utf-8?B?dVBaRkorckZaM0kxa2VSQzgrd3JlL01hZGdlREcxOHVaU2s4UUhVZCt1U1lv?=
 =?utf-8?B?ZStvMU1vU2xRTVViaTRoa01SSCtaMnhIcTZmWFJSVE5HWDd0SHNCUlVWeHdv?=
 =?utf-8?B?S3RvM1BONy9DY3hReSsrcHB1OE0zR25mYU9oY0IyTStEVUlQbG1CSTBTTzM0?=
 =?utf-8?B?MVFEYUZyUlY4Ky9nZnVpK2VReUtEUHFMbkFJQ0Q4WHZ6THJsSVBKN3BVSFdy?=
 =?utf-8?B?QmYrSEh4ckQ5WU9vbFpxc0s4NkVVNjlWYjNpTHZCeXBzWklNNHNpT0I4SDZ5?=
 =?utf-8?B?VGlMS3oycFZhL1EybGhiYUY3OURXamhoQzEzUllGeDV2ZXRGM0UyRnV0bmxM?=
 =?utf-8?B?VkFnck5jeWFWTG12ZUVqdjFXWHJ6bHpMUWw2Q3JSWkZiZURmV1g5aTlBbHpz?=
 =?utf-8?B?Z2FhdkNkSVBYa1lPNjlZUHkvVzRHMG1uU0tGTGwxV1dYMmNhZ00zYW1CYWVj?=
 =?utf-8?B?Szc5S2pyaVZPTDIvOC8vMXAzRVpaM1dlUXRLUDhqNHUxNGVQeE5lQkRoMmR1?=
 =?utf-8?B?SVIvdGhicnQwZGkvMXRRdlc5OU1GZVlSMmMvNXFXVjdueG1LLytiZ0VER3Ru?=
 =?utf-8?B?b09CanM0UStyRXJOZ01sU3lWV1dXM1ZrNnExY29xL3dSNmUrYlZoZjZKVGVQ?=
 =?utf-8?B?c0N3Wk5xTmV5bUJaSmdyeGFDZVIzT2FjYjVlU25vdkZQSkhXaVVJNytQdGRw?=
 =?utf-8?B?eUV0VzNEMC9LZ3N5S0QzSE9yMXFUUTNOZkRJUFRGckluR1lDRUJ6a3J3WmRp?=
 =?utf-8?B?MUR5OWZLdHN6RlBMUmhIU2NrbTluTVU0c29hSmNzYmZZYnFLd0Y3VXdwbmJG?=
 =?utf-8?B?UWJVTVZqZkZ4NVdKZFBjRlFiRnFaSW83OVNCZ0RVeThhNDVud3hHVVV3MnpT?=
 =?utf-8?B?NnJCMGpNQURjZkkrS3V0ZERpeWF2a2hPSms5dzkrbm1yYmRCd3V2TXdFUWUr?=
 =?utf-8?B?TVRsOGZ5czNMMi8xSlNSaDkwOHM2MVU2blI4UkpGMVZXbjRhR29lSWhmaG5D?=
 =?utf-8?B?ZEI0Y1N0LzhDVnZMa25HL2kwY0pCakFPSkxqMGpjRVk0TWh3b081eG1rdTZQ?=
 =?utf-8?B?RUVnN3hvQWxoeW05TUZiY29Na1ZmK2d6QW1FQWVOS04vMHRXcWUvems1ZzBB?=
 =?utf-8?B?UEpqbFRoU3NOUmhMUjIzL0lmWG1kZ3ZYUThic2owMjJwdjM5bmtod2xLL3A2?=
 =?utf-8?B?NXhLQzdyNTJZUHY1SXJnU1lsVlRRWGxzejc3cExpS2RiQXZORURJbkVEcjR1?=
 =?utf-8?B?d0VVK1loZmJiSUhSUXJMd2xLMHhKbk9nWnVkbGYwblFqV0RmcytXSlVDV3E4?=
 =?utf-8?B?ZmJlR2thQXFjbE0vWjBBd3hJYWxPQ2lvWDJTWU52dWJONHhhUW9nellpOURO?=
 =?utf-8?B?K3hLOXBFU2YrcERQZlQyU0t0NUpySTA0b2lxYU84cnZOWWpva2x3akxNQW44?=
 =?utf-8?B?aW1CUDVSTHZDMmxZU1k4SXZ2aDJhUERXb3ZCQnVvTXE3Q0RiREJzNGlrK1JM?=
 =?utf-8?B?ZlV5bEtwYkpieGRmMWM3YlFOOW1qbmwwWjFlZVAzRWVxUEFNbGtBaXYwNFMr?=
 =?utf-8?B?M1c1OVJUcWl6bU5ISFM1MS9DVTBzRmY5MjVkSFg3OFlZNzJzRmJMV1N4TDVZ?=
 =?utf-8?B?RXpXeGdCc21mZk8xMWxMZ3BDK2ZidjlXVFgrNk5TQUgxMlNIczZ2SDRnbEg4?=
 =?utf-8?Q?MTsfdgOQhFKMlM2HqK6VXqFKW6SmiooZHQ22rL/?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 71e51602-4e99-4119-36cd-08d98e3a3817
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2021 11:11:35.1252
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6jofsfhuQJ8LV/CB7xx1SHH4y3db++1ZJ38uuV3BmPEeqcR6qAb1vfJJ3rH8W6wf11eLt5Itr+LY4vm+oz1rew==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB5273
X-OriginatorOrg: citrix.com

On Thu, Sep 30, 2021 at 10:52:13AM +0300, Oleksandr Andrushchenko wrote:
> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> 
> This is in preparation for dynamic assignment of the vpci register
> handlers depending on the domain: hwdom or guest.
> 
> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> Reviewed-by: Michal Orzel <michal.orzel@arm.com>
> ---
> Since v1:
>  - constify struct pci_dev where possible
> ---
>  xen/drivers/vpci/vpci.c | 7 ++++++-
>  xen/include/xen/vpci.h  | 2 ++
>  2 files changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/xen/drivers/vpci/vpci.c b/xen/drivers/vpci/vpci.c
> index cbd1bac7fc33..1666402d55b8 100644
> --- a/xen/drivers/vpci/vpci.c
> +++ b/xen/drivers/vpci/vpci.c
> @@ -35,7 +35,7 @@ extern vpci_register_init_t *const __start_vpci_array[];
>  extern vpci_register_init_t *const __end_vpci_array[];
>  #define NUM_VPCI_INIT (__end_vpci_array - __start_vpci_array)
>  
> -void vpci_remove_device(struct pci_dev *pdev)
> +void vpci_remove_device_registers(const struct pci_dev *pdev)

Making this const is kind of misleading, as you end up modifying
contents of the pdev, is just that vpci data is stored as a pointer
inside the struct so you avoid the effects of the constification.

>  {
>      spin_lock(&pdev->vpci->lock);
>      while ( !list_empty(&pdev->vpci->handlers) )
> @@ -48,6 +48,11 @@ void vpci_remove_device(struct pci_dev *pdev)
>          xfree(r);
>      }
>      spin_unlock(&pdev->vpci->lock);
> +}
> +
> +void vpci_remove_device(struct pci_dev *pdev)
> +{
> +    vpci_remove_device_registers(pdev);
>      xfree(pdev->vpci->msix);
>      xfree(pdev->vpci->msi);
>      xfree(pdev->vpci);
> diff --git a/xen/include/xen/vpci.h b/xen/include/xen/vpci.h
> index 9f5b5d52e159..2e910d0b1f90 100644
> --- a/xen/include/xen/vpci.h
> +++ b/xen/include/xen/vpci.h
> @@ -28,6 +28,8 @@ int __must_check vpci_add_handlers(struct pci_dev *dev);
>  
>  /* Remove all handlers and free vpci related structures. */
>  void vpci_remove_device(struct pci_dev *pdev);
> +/* Remove all handlers for the device given. */

I would drop the 'given' form the end of the sentence...

> +void vpci_remove_device_registers(const struct pci_dev *pdev);

...and maybe name this vpci_remove_device_handlers as it's clearer
IMO.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Wed Oct 13 11:30:28 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 11:30:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.208259.364316 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1macSl-0004AU-AN; Wed, 13 Oct 2021 11:30:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 208259.364316; Wed, 13 Oct 2021 11:30:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1macSl-0004AN-77; Wed, 13 Oct 2021 11:30:23 +0000
Received: by outflank-mailman (input) for mailman id 208259;
 Wed, 13 Oct 2021 11:30:21 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=EFKL=PB=citrix.com=roger.pau@srs-us1.protection.inumbo.net>)
 id 1macSj-0004AH-Jj
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 11:30:21 +0000
Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 65dad2ca-42c3-445b-a7cb-57c499c23457;
 Wed, 13 Oct 2021 11:30:19 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 65dad2ca-42c3-445b-a7cb-57c499c23457
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1634124619;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=hepfCb6IOMzF5/6eeMYgNkwjUmiMZsGwPw6WDhyR/Ko=;
  b=bM31l9NvVhfEeUJdleJ5cZGacthV9TJAJAECXGI/W/5YfRX2u7TuvLvv
   Q+gUWpB1+/7yrBUhWhhioQUrc6txtmhfyhZDr+g2YPlQvOJmvIJ1RtYFY
   gsr9mN1BeP2pJPsa7ZaFYv3nx2TKeBbrxLEqrvNAfhKjeV+pjAe3lb0wa
   Y=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: GXeTiB2SgyDvJm3fPzDtkzy0g6gT0dKMvnX2obLRZhe0olS2wK8UJZwxWJJm+lJGd/mQgQvjm1
 7tMik9700+oYOztd/ScvLYDlT3Q8D4u9TzGf0o8HQNcbYUb+3sXBewCVAOlC0MyDfjddcvoQQA
 6KRCC7uCaV8Dcd98w3LKMjM+QecTUNABLfZEmo2HXBwErztugCYaj3zJK2TEjrNiI/x8vH3hVF
 7nwmiHfxbwMLBtnMykvV7XznN4MNvSZYqaXNG7p4Fn/c8oBCJ4E5ib3mgl1PPvStQLTcuP22K0
 Nmd7ZinQbvHnhHwMG040ELMn
X-SBRS: 5.1
X-MesageID: 56954599
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:+YSsh6wmWtlzEcfpu4p6t+cAwCrEfRIJ4+MujC+fZmUNrF6WrkUHm
 DNJX2iFa/6PY2ShcoxwPNuy9RsHusPTxtJrGwY/pCAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx
 59DAjUVBJlsFhcwnvopW1TYhSEUOZugH9IQM8aZfHAsLeNYYH1500s6w7di2tcAbeWRWGthh
 /uj+6UzB3f9s9JEGjp8B3Wr8U4HUFza4Vv0j3RmDRx5lAa2e0o9VfrzEZqZPXrgKrS4K8bhL
 wr1IBNVyUuCl/slIovNfr8W6STmSJaKVeSFoiI+t6RPHnGuD8H9u0o2HKN0VKtZt9mGt/9d5
 vVOn6a/cxl3Gq7Pkr8WaV5AOj4raMWq+JefSZS+mcmazkmAeHrw2fR+SkoxOOX0+M4uXzsIr
 6ZBbmlQMFbT3Ipaw5riIgVort4kI8TxepsWp1lrzC3DDOZgSpfGK0nPzYIGjWps25EfdRrYT
 +swVzFzcj3cXztoMW00U7QgxMOqqFCqJlW0r3rK/PFqsgA/1jdZ0rLgLd7UcdyiXthOkwCTo
 Weu103jHhwfA/mOxjOE/2yEi/fGmGXwX4d6PLe17OJwiVufgGkaEgQLVECTqOO8zEW5Xrp3L
 EgZ+TEnq6Qow0WtQsPgRB2zoHOCvRk0VsJZFqsx7wTl4rDd4xudQHMFSDFBQNU8sYk9QjlC/
 kGOm9TlFDl+qoqfQHiW9qqXhT6qMC1TJmgHDQcUQA1A79T9rYUbihPUUs0lAKOzlsfyGzz73
 3aNtidWr7wVgdRRj/3j1V/CijOo4JPOS2Yd5BjTX2+jxhN0YsiifYPAwV/f4PVbJYCVVG6dr
 WMEkMiT6uMJJZyVnSnLS+IIdJmy/OqMOjDYhV9pHrEi+i6r9nrleppfiAySP28wbJxCI2WwJ
 haO50UBv/e/IUdGc4dYT6yRCO4QwpL+S/DmVfqPZeAJerFuIVrvED5VWWac2GXkkU4JmK45O
 IuGfcvEMUv2GZiL3xLtGL9Die5DKjQWgDqJH8iinkvPPa+2PSbNEd843E2ygvfVBU9uiD7e9
 MpDLIO0whFbXfyWjsL/oNNLcw5iwZTWA/nLRy1rmgyrflQO9IIJUaa5LVYdl2pNxPs9egDgp
 CDVZ6Og4ACj7UAr0C3TApyZVJvhXIxksVUwNjE2MFCj1hALONj0sP9BK8FvJ+V8qISPKMKYq
 dFeJK1s5dwVG1z6F8k1N8Gh/OSOijz67e5xA8ZVSGdmJMMxL+A40tTlYhHu5EEz4tmf7qMDT
 0mb/lqDG/IrHl06ZO6PMa7H5w7h7BA1xbMpN2OVc4Y7RakZ2NUzQ8AHpqRseJ9kxNSq7mby6
 jt69j9B/bOT/NRvrIWQ7U1Gxq/we9ZD8oNhNzCzxZ69NDXA/3rlxolFUe2SeivaWn+y86KnD
 di5BdmnWBHetFoV4Yd6DZhxyqcyu4nmq7NAl1w2F3TXdVW7TLhnJyDej8VIs6RMwJ5fuBe3B
 R3TqoULZ+3RNZO3CkMVKSokcv+HiaMelA7N4KlnO079/iJ2ouaKCB0AIxmWhSVBB7JpK4d5k
 /w5scsb5lXn2BonO9qLlA5O8GGIIiBSWqkrrMhCUoTqlhAq2hdJZpmFUn3655SGatNtNEg2I
 2DL2Pqe1uoEnkebKig9D3nA2+ZZlK8ighESwQ9QPUmNl/rEmuQzgE9b/wMoQ1kH1R5Aye9yZ
 DRmbhUnOaWU8j50r8FfRGTwSRpZDRiU90GtmVsEkGrVExuhWmDXdTBvPO+M+AYS8n5Gfygd9
 7adkT63XTHvdcD3/y0zRU869KCzEY0vrlXPyJK9AsCIP5gmej600KahaF0BpwbjHc5s1lbMo
 vNn/booZKD2XcLKT3bX12VOOWwsdS25
IronPort-HdrOrdr: A9a23:rRUdoKtTgif8e4Ucrf1zJbJt7skCkoMji2hC6mlwRA09TyXGra
 +TdaUguSMc1gx9ZJhBo7G90KnpewK6yXdQ2/hqAV7CZnichILMFu9fBOTZsl/d8kHFh4tgPO
 JbAtVD4b7LfCZHZKTBkXCF+r8bqbHtmsDY5pau854ud3ATV0gJ1XYHNu/xKDwReOApP+tcKH
 LKjfA32wZINE5nJfiTNz0gZazuttfLnJXpbVovAAMm0hCHiXeN5KThGxaV8x8CW3cXqI1SvF
 Ttokjc3OGOovu7whjT2yv66IlXosLozp9mCNaXgsYYBz3wgkKDZZhnWZeFoDcpydvfomoCoZ
 3pmVMNLs5z43TeciWcpgbs4RDp1HIU53rr2Taj8A3eiP28YAh/J9tKhIpffBecwVEnpstA3K
 VC2H/cn4ZLDDvb9R6NqeTgZlVPrA6ZsHAimekcgzh0So0FcoJcqoQZ4Qd8DIoAJiTn84oqed
 MeQ/003MwmMW9yUkqp/VWGmLeXLzYO91a9MwQ/U/WuonlrdCsT9Tpc+CQd9k1wg67VBaM0o9
 gsCZ4Y542mePVmGZ6VNN1xMfdfNVa9My4kEFjiaGgPR5t3c04klfbMkcAIDaeRCds18Kc=
X-IronPort-AV: E=Sophos;i="5.85,370,1624334400"; 
   d="scan'208";a="56954599"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=bH0uIt9Hzp73WU3OlxPwDSI5uxWYFIBOiXP+0c1rbotHMVcjBVq2jAGXPhPmUg4ZsBxMilWvMtQXb4DgjSY7XzbKN9cvE/piLvV1DfD443sd5EdIzYHm/HoiQ1T+LxDffZomyvZab8/L54EIIbjR88SJ8BTpVqLnfT6Xk4OQpf3aUQohcAmV0k4N4qtiySjct5VhVmCLyf912USqUCfNtrgyncREyaeB8u40U6JG2lSlmTCMvzxeasR4dUYoCWnJq8b7dQwFTO+Au0pkFKthiyiugvZYEb6PX8OIjuLUGKOfjfff4xThBysBR+fHdem4FU8TcFkmrobICpC3LKSiuQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=TA/FmPNRk0cZoku0olp3BhDSjnZ2hhtSB3jGX+fnJq0=;
 b=oZ7fcSPVel/1Uann8c3UuPT9LrX5WA/o7p2aNUxT+8SATd5AD5igfbwDipm6kpdDE1vKAg19cyYmZe0E/cRfYCvBpPidYuFWlECpQOoO6ibSZCb0pbcOOFQ0zXTMOcNSQzhmrBOI3C5jfMuLPyXxaJbxnP3LKg2mZYNa2t7hUDw5Jr36jzdEYL0QEJ1hY+tWxUkaJgMvxbLZQosfRhGoqv/eLtIDlh0ANNH+sAT5CgTFAm7q+BoUYgh20eEAgaAo6pH7w1zpAwSkhTJ1HeHT9gLU8c/BD9dmzPY8YBIb3gCCqkJaUfkhW0bAoNYiwkhzIjVAcC/+EU8WzDDNOCut1Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=TA/FmPNRk0cZoku0olp3BhDSjnZ2hhtSB3jGX+fnJq0=;
 b=KJ6uF11gydZpVesouTZWDYl64U4oByfBMnvFX+S215JuLOcxUNEBXqzgfS+74pSNnjdJPWvJBPx0JMYRkXzkix46kFJKLFX3UTbNj9aic7aJHUi+jwLEqGSC5jbfCU5ajagGhTp14bUTRdG99M17GnXTI+XwmpWCWUEf8vd5FqI=
Date: Wed, 13 Oct 2021 13:29:55 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Oleksandr Andrushchenko <andr2000@gmail.com>
CC: <xen-devel@lists.xenproject.org>, <julien@xen.org>,
	<sstabellini@kernel.org>, <oleksandr_tyshchenko@epam.com>,
	<volodymyr_babchuk@epam.com>, <Artem_Mygaiev@epam.com>, <jbeulich@suse.com>,
	<bertrand.marquis@arm.com>, <rahul.singh@arm.com>, Oleksandr Andrushchenko
	<oleksandr_andrushchenko@epam.com>
Subject: Re: [PATCH v3 02/11] vpci: Add hooks for PCI device assign/de-assign
Message-ID: <YWbDMwC+6ehmGurS@MacBook-Air-de-Roger.local>
References: <20210930075223.860329-1-andr2000@gmail.com>
 <20210930075223.860329-3-andr2000@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20210930075223.860329-3-andr2000@gmail.com>
X-ClientProxiedBy: LO4P123CA0409.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:189::18) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: b4450ff1-cfed-48c7-d747-08d98e3ccb21
X-MS-TrafficTypeDiagnostic: DM6PR03MB5324:
X-Microsoft-Antispam-PRVS: <DM6PR03MB5324DD0DF300EC0E1005EDEA8FB79@DM6PR03MB5324.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8273;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: o7ULoj2PnXtYLm9USTe91V3QqsXUKfmYJSpDVwJGsQ1+ioiBQaaOfmRMaCeCYrDzW1norMAF4ONu3vk+GuUe/vo47rCU/KRRFyuOmjjbzSjmIsNeWHximnqgzq4nJ2/KdHyY8fcCelhx7IeoKtOvHdVG6ZsWlieWyWNVkJm5y+3LH3OYm45EJK9yHIa1gYMVtzaiCbI5VywL/2cph5Lg2jWxQZFij8L8fHtCndS+c3yTqPuU8iSkWCaEAH8n582seEARnpcRLfWz4imICjoXiIeeUBIeHVoT8jfPCslkOHUsN3KBocMvZ9vOIlHtXGUQN0xxtiJ8LKNwWRdAEOi57yrIUsH3df+QrgviONutTmXoFkSq+R0AsodRfccoXM0QtMAt3ThBdeIGuWptKwUuEsFD36OZ6NiBP/l4ComExUkQYmTPk+5akAMYMEhvhjWnDTZfmP90Cl7SdKTsWbLRVLybHtYcBHSmBC2JKniKb2XI5G4xmQwEJ2QaLqCToIviEALcwN1NytYFCccbN8sOVm8N5qkmf8w21qS0d7Xv8+MuWLJsnukZgT2e06RD9sW6veiGsJs+J28+TkdQhnTPeAG9RWt6lpwYvmRvmHVy/IaeLN9bXZLms1TLgkUSklo6jDiiKC8d0pGUOkIpwOtA8HXr4XLGp3MCR8If1bKD0nMEMx1PUNf+Q3fqf28wFp5MuCpK4+U5C1UECL1D+bl9NA==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(956004)(6666004)(508600001)(85182001)(26005)(82960400001)(38100700002)(5660300002)(186003)(8936002)(2906002)(86362001)(316002)(6916009)(66946007)(66476007)(7416002)(66556008)(6496006)(6486002)(9686003)(4326008)(83380400001)(8676002)(67856001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WEpMMEh2TnRjSUJ5MWMrdzBVMnllNGxGRzJnbmk2VmRGQzFzSkRuY2wvVzh4?=
 =?utf-8?B?WTVBME5lMm9IdkgveXRYMWp3U2cyQ0xxelVsS0o1b05za2s1Zmo0UE9TcUlm?=
 =?utf-8?B?RHZjUjFwOEJ6bHNaSXFsZjg0NGtqOFlQWk02UEdXZ1UrdnZYbTIyRll6djJ4?=
 =?utf-8?B?b2M4cWFtZitqcDd5aU1pbkpEbTdjSDNpRWwyaVduTWM0emw5WS9QZGR0VzdN?=
 =?utf-8?B?ajNaWWRsYlloWGF3bFdidHgzRVhxSEd6RW9mZjdBREJzN0tPZHFFdUh4ODBD?=
 =?utf-8?B?cXpQZTRHWXc0eTZpNFpOZHJLNkp0ZTZGYVhidmRFY2lYUk5LenE2bXlMc0l4?=
 =?utf-8?B?TmxUTm1LUDcvZlRNV08ybVpKci8zMkNMWDF4RnBuWHk4RkFDSXlrRzR3b0ps?=
 =?utf-8?B?enl4dytLSXJ1YkJZOTdxdkJIVnFaUXpJL2lTamJsd2syK21xQlpRZ2Q0TVJE?=
 =?utf-8?B?Zit6M0hzTUJOUk5Ya0ZIWWVQWFh5RkdLSnlSSFhZOGpjU1g1Wk40Y2ZBaVdP?=
 =?utf-8?B?ekt1c0t4QW5reWxUY00wYzVOQjlEaGtCT0dmOXZ3TmFoRzlzalVhaG11N0xY?=
 =?utf-8?B?UG9MWEZHR3BpNEJQOExrMXRNb0NFV0VxRkhUUkhYbkRmeHhuaDVKT29paFF5?=
 =?utf-8?B?eVJySmZ0Q3ZZS2VrY3k5UlVsM3VqeitTZ1NmcFpjc3NFQk90L05SNHc0MFM3?=
 =?utf-8?B?QXpSMWlETkFydDVGN0tMMm1xb25vWm8yQlM5VExDQnh1OTMwSUtOQUtOWmVF?=
 =?utf-8?B?eWRWL0VuRTRua3EzUXpnby9hQWIvckJvT1gwcHJPbEFQNkt5ellvZ1VCS3cr?=
 =?utf-8?B?WmVMZlJEaG1BZ0pnSUQ5NHBRSTdTUjRlUEJPQ0RFdGVua0xSUWxibk83MFNV?=
 =?utf-8?B?dVhFaWxrSmsxdDA5Q3Rsa1ZKd0tSNHNmV3kyNmtOaDdDejhXcXBzMGZ2SGZU?=
 =?utf-8?B?OWUxcjd1aEJwSk10OUNOWkVRZURUdWg4eWJaM0JFTmNpL1R3N1huTmYrWHli?=
 =?utf-8?B?Rmc1cXluZUhWdnVXRDRFd2c2ZklVaGVQempacjUwYjZjYzFSa09yZzNOSktG?=
 =?utf-8?B?RkZEU3NKcHNzRnYvbFpiamN2MFdCSzM5a3F1MktkNkM2THBMQnRqVkVHSWdv?=
 =?utf-8?B?MmxIWFR4OERwZzNsVEVPWmg3SHYxU0xwd2s0ZjlFRGpHUm5SMTJ5TDVyVWlq?=
 =?utf-8?B?dlp4T0s1RUs1bTAzZEFESkJORWNPc2kwVE9yZmV4RzFLWFpPM3RLRE5LSC9Z?=
 =?utf-8?B?NHAvUE5LSG9TcWFlUmJOeExDYmlVMzR0UGVLNHNmM2F1dGxGdyt5b1RHU2lM?=
 =?utf-8?B?VHBmaVdWOHVVZEZxVUZIRDdOc0t1M1A5MnNacDVwSmFIM2RZQnV1VFA5VDI3?=
 =?utf-8?B?ZEwwQnJsWStPeEhFbjdLaXVlN2NMekNUWE9rOUNYWlJEYnV1Yld0dlVIK2ZJ?=
 =?utf-8?B?azMwRGpvS0tRUDF4eUlzUEl6SEFsa2F4WmJaeUhtaWhQSFd0TXhkS2xFSktw?=
 =?utf-8?B?NHVWd3E5emQ0NnFGOGFVUXkyNDRicU5Wb0hGaVd1WjFwOHVWdVBHZThGaEZy?=
 =?utf-8?B?enA3MlNsbmU5d1JiOWZpR0tQY1R6M3B2S2RacllZam5iUGVlQTlqNEo1aGRv?=
 =?utf-8?B?OWQ2Q0Ixb21mV3kyZVk5MG9WdU00WjBXUjhIRHoyRWozMnZNTzRGL2RJK0Vq?=
 =?utf-8?B?L2RBdGhRRXNabWpRZitsbXdjT3RJNVNsOGRWa1R2SGdLY3dZajgrczFYTjU5?=
 =?utf-8?Q?zSLEwW7D5/iGHAnm0l/L5o0e9eT2IOODOOFdV97?=
X-MS-Exchange-CrossTenant-Network-Message-Id: b4450ff1-cfed-48c7-d747-08d98e3ccb21
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2021 11:30:00.7865
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Y+8zLKj68qHWlikkDyaFcQlsShhIicHZspEbiBLQBK1PzAN1Uj+77r08U51/LkAn8CFLs9cDuMR3bHgpq9QY0A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB5324
X-OriginatorOrg: citrix.com

On Thu, Sep 30, 2021 at 10:52:14AM +0300, Oleksandr Andrushchenko wrote:
> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> 
> When a PCI device gets assigned/de-assigned some work on vPCI side needs
> to be done for that device. Introduce a pair of hooks so vPCI can handle
> that.
> 
> Please note, that in the current design the error path is handled by
> the toolstack via XEN_DOMCTL_assign_device/XEN_DOMCTL_deassign_device,
> so this is why it is acceptable not to de-assign devices if vPCI's
> assign fails, e.g. the roll back will be handled on deassign_device when
> it is called by the toolstack.

It's kind of hard to see what would need to be rolled back, as the
functions are just dummies right now that don't perform any actions.

I don't think the toolstack should be the one to deal with the
fallout, as it could leave Xen in a broken state. The current commit
message doesn't provide any information about why it has been designed
this way.

> 
> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> ---
> Since v2:
> - define CONFIG_HAS_VPCI_GUEST_SUPPORT so dead code is not compiled
>   for x86
> Since v1:
>  - constify struct pci_dev where possible
>  - do not open code is_system_domain()
>  - extended the commit message
> ---
>  xen/drivers/Kconfig           |  4 ++++
>  xen/drivers/passthrough/pci.c |  9 +++++++++
>  xen/drivers/vpci/vpci.c       | 23 +++++++++++++++++++++++
>  xen/include/xen/vpci.h        | 20 ++++++++++++++++++++
>  4 files changed, 56 insertions(+)
> 
> diff --git a/xen/drivers/Kconfig b/xen/drivers/Kconfig
> index db94393f47a6..780490cf8e39 100644
> --- a/xen/drivers/Kconfig
> +++ b/xen/drivers/Kconfig
> @@ -15,4 +15,8 @@ source "drivers/video/Kconfig"
>  config HAS_VPCI
>  	bool
>  
> +config HAS_VPCI_GUEST_SUPPORT
> +	bool
> +	depends on HAS_VPCI

I would assume this is to go away once the work is finished? I don't
think it makes sense to split vPCI code between domU/dom0 on a build
time basis.

> +
>  endmenu
> diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci.c
> index 9f804a50e780..805ab86ed555 100644
> --- a/xen/drivers/passthrough/pci.c
> +++ b/xen/drivers/passthrough/pci.c
> @@ -870,6 +870,10 @@ static int deassign_device(struct domain *d, uint16_t seg, uint8_t bus,
>      if ( ret )
>          goto out;
>  
> +    ret = vpci_deassign_device(d, pdev);
> +    if ( ret )
> +        goto out;
> +
>      if ( pdev->domain == hardware_domain  )
>          pdev->quarantine = false;
>  
> @@ -1429,6 +1433,11 @@ static int assign_device(struct domain *d, u16 seg, u8 bus, u8 devfn, u32 flag)
>          rc = hd->platform_ops->assign_device(d, devfn, pci_to_dev(pdev), flag);
>      }
>  
> +    if ( rc )
> +        goto done;
> +
> +    rc = vpci_assign_device(d, pdev);
> +
>   done:
>      if ( rc )
>          printk(XENLOG_G_WARNING "%pd: assign (%pp) failed (%d)\n",
> diff --git a/xen/drivers/vpci/vpci.c b/xen/drivers/vpci/vpci.c
> index 1666402d55b8..0fe86cb30d23 100644
> --- a/xen/drivers/vpci/vpci.c
> +++ b/xen/drivers/vpci/vpci.c
> @@ -86,6 +86,29 @@ int __hwdom_init vpci_add_handlers(struct pci_dev *pdev)
>  
>      return rc;
>  }
> +
> +#ifdef CONFIG_HAS_VPCI_GUEST_SUPPORT
> +/* Notify vPCI that device is assigned to guest. */
> +int vpci_assign_device(struct domain *d, const struct pci_dev *dev)
> +{
> +    /* It only makes sense to assign for hwdom or guest domain. */
> +    if ( is_system_domain(d) || !has_vpci(d) )
> +        return 0;
> +
> +    return 0;
> +}
> +
> +/* Notify vPCI that device is de-assigned from guest. */
> +int vpci_deassign_device(struct domain *d, const struct pci_dev *dev)
> +{
> +    /* It only makes sense to de-assign from hwdom or guest domain. */
> +    if ( is_system_domain(d) || !has_vpci(d) )
> +        return 0;
> +
> +    return 0;
> +}
> +#endif /* CONFIG_HAS_VPCI_GUEST_SUPPORT */
> +
>  #endif /* __XEN__ */
>  
>  static int vpci_register_cmp(const struct vpci_register *r1,
> diff --git a/xen/include/xen/vpci.h b/xen/include/xen/vpci.h
> index 2e910d0b1f90..ecc08f2c0f65 100644
> --- a/xen/include/xen/vpci.h
> +++ b/xen/include/xen/vpci.h
> @@ -242,6 +242,26 @@ static inline bool vpci_process_pending(struct vcpu *v)
>  }
>  #endif
>  
> +#if defined(CONFIG_HAS_VPCI) && defined(CONFIG_HAS_VPCI_GUEST_SUPPORT)

You don't need to check for CONFIG_HAS_VPCI, as
CONFIG_HAS_VPCI_GUEST_SUPPORT already depends on CONFIG_HAS_VPCI being
set.

> +/* Notify vPCI that device is assigned/de-assigned to/from guest. */
> +int __must_check vpci_assign_device(struct domain *d,
> +                                    const struct pci_dev *dev);
> +int __must_check vpci_deassign_device(struct domain *d,
> +                                      const struct pci_dev *dev);
> +#else
> +static inline int vpci_assign_device(struct domain *d,
> +                                     const struct pci_dev *dev)
> +{
> +    return 0;
> +};
> +
> +static inline int vpci_deassign_device(struct domain *d,
> +                                       const struct pci_dev *dev)
> +{
> +    return 0;
> +};

You need the __must_check attributes here also to match the prototypes
above.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Wed Oct 13 11:34:03 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 11:34:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.208268.364327 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1macWH-0004qa-Uz; Wed, 13 Oct 2021 11:34:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 208268.364327; Wed, 13 Oct 2021 11:34:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1macWH-0004qT-Rg; Wed, 13 Oct 2021 11:34:01 +0000
Received: by outflank-mailman (input) for mailman id 208268;
 Wed, 13 Oct 2021 11:34:00 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=0zCU=PB=kernel.org=helgaas@srs-us1.protection.inumbo.net>)
 id 1macWG-0004qN-Fd
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 11:34:00 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 74c10a8c-2c19-11ec-816c-12813bfff9fa;
 Wed, 13 Oct 2021 11:33:59 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id A11E861056;
 Wed, 13 Oct 2021 11:33:57 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 74c10a8c-2c19-11ec-816c-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1634124838;
	bh=HQKsM5+JxN3z7fyOH4PY/6KtY66RH98iqwIkPpr7pp4=;
	h=Date:From:To:Cc:Subject:In-Reply-To:From;
	b=UShiO4p2ZNEqVxTuBk6kFbR2B00UaMlAvlLYQnZahYzzR2pWxODYirJ55Ppvc4wcb
	 TbsHJjV6yBuou71KQ85auBUjZSwjeGda875UjLN7pwgf34k/EH2knu8OabkXl897I6
	 d38KzzByzeedoIWV/dOugDUDl6DilZq//3uEMWjKd9CwvbS4Qozhkn8DshWNKQBTv1
	 2O/FPQuHxfdQqcncfqcRRrj5kN+rqJ+5UArlW1uDTv4ePzGur9CO7NwFRq4T1/KEQq
	 aWFCcH5AR4qBg0rsV6uekaLWSPeuu9SbuPW4oDnE1b1kYx2Q3hiZfUMs5RsbVbgQOk
	 /xhQrHdqpvXyQ==
Date: Wed, 13 Oct 2021 06:33:56 -0500
From: Bjorn Helgaas <helgaas@kernel.org>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= <u.kleine-koenig@pengutronix.de>,
	linux-pci <linux-pci@vger.kernel.org>,
	Sascha Hauer <kernel@pengutronix.de>,
	Alexander Duyck <alexanderduyck@fb.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Andrew Donnellan <ajd@linux.ibm.com>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Arnd Bergmann <arnd@arndb.de>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Bjorn Helgaas <bhelgaas@google.com>, Borislav Petkov <bp@alien8.de>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	"David S. Miller" <davem@davemloft.net>,
	Fiona Trahe <fiona.trahe@intel.com>,
	Frederic Barrat <fbarrat@linux.ibm.com>,
	Giovanni Cabiddu <giovanni.cabiddu@intel.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	"H. Peter Anvin" <hpa@zytor.com>, Ido Schimmel <idosch@nvidia.com>,
	Ingo Molnar <mingo@redhat.com>, Jack Xu <jack.xu@intel.com>,
	Jakub Kicinski <kuba@kernel.org>,
	Jesse Brandeburg <jesse.brandeburg@intel.com>,
	Jiri Olsa <jolsa@redhat.com>, Jiri Pirko <jiri@nvidia.com>,
	Juergen Gross <jgross@suse.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Marco Chiappero <marco.chiappero@intel.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Mathias Nyman <mathias.nyman@intel.com>, Michael Buesch <m@bues.ch>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Namhyung Kim <namhyung@kernel.org>,
	Oliver O'Halloran <oohall@gmail.com>,
	Paul Mackerras <paulus@samba.org>,
	Peter Zijlstra <peterz@infradead.org>,
	=?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= <zajec5@gmail.com>,
	Russell Currey <ruscur@russell.cc>,
	Salil Mehta <salil.mehta@huawei.com>,
	Sathya Prakash <sathya.prakash@broadcom.com>,
	Simon Horman <simon.horman@corigine.com>,
	Sreekanth Reddy <sreekanth.reddy@broadcom.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Suganath Prabu Subramani <suganath-prabu.subramani@broadcom.com>,
	Taras Chornyi <tchornyi@marvell.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Tomaszx Kowalik <tomaszx.kowalik@intel.com>,
	Vadym Kochan <vkochan@marvell.com>,
	Wojciech Ziemba <wojciech.ziemba@intel.com>,
	Yisen Zhuang <yisen.zhuang@huawei.com>,
	Zhou Wang <wangzhou1@hisilicon.com>,
	linux-crypto <linux-crypto@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-perf-users@vger.kernel.org,
	"open list:LINUX FOR POWERPC PA SEMI PWRFICIENT" <linuxppc-dev@lists.ozlabs.org>,
	linux-scsi <linux-scsi@vger.kernel.org>,
	USB <linux-usb@vger.kernel.org>,
	"open list:TI WILINK WIRELES..." <linux-wireless@vger.kernel.org>,
	MPT-FusionLinux.pdl@broadcom.com, netdev <netdev@vger.kernel.org>,
	oss-drivers@corigine.com, qat-linux@intel.com,
	"maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" <x86@kernel.org>,
	xen-devel@lists.xenproject.org
Subject: Re: [PATCH v6 00/11] PCI: Drop duplicated tracking of a pci_dev's
 bound driver
Message-ID: <20211013113356.GA1891412@bhelgaas>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAHp75Vd0uYEdfB0XaQuUV34V91qJdHR5ARku1hX_TCJLJHEjxQ@mail.gmail.com>

On Wed, Oct 13, 2021 at 12:26:42PM +0300, Andy Shevchenko wrote:
> On Wed, Oct 13, 2021 at 2:33 AM Bjorn Helgaas <helgaas@kernel.org> wrote:
> > On Mon, Oct 04, 2021 at 02:59:24PM +0200, Uwe Kleine-K�nig wrote:
> 
> > I split some of the bigger patches apart so they only touched one
> > driver or subsystem at a time.  I also updated to_pci_driver() so it
> > returns NULL when given NULL, which makes some of the validations
> > quite a bit simpler, especially in the PM code in pci-driver.c.
> 
> It's a bit unusual. Other to_*_dev() are not NULL-aware IIRC.

It is a little unusual.  I only found three of 77 that are NULL-aware:

  to_moxtet_driver()
  to_siox_driver()
  to_spi_driver()

It seems worthwhile to me because it makes the patch and the resulting
code significantly cleaner.  Here's one example without the NULL
check:

  @@ -493,12 +493,15 @@ static void pci_device_remove(struct device *dev)
   static void pci_device_shutdown(struct device *dev)
   {
          struct pci_dev *pci_dev = to_pci_dev(dev);
  -       struct pci_driver *drv = pci_dev->driver;

          pm_runtime_resume(dev);

  -       if (drv && drv->shutdown)
  -               drv->shutdown(pci_dev);
  +       if (pci_dev->dev.driver) {
  +               struct pci_driver *drv = to_pci_driver(pci_dev->dev.driver);
  +
  +               if (drv->shutdown)
  +                       drv->shutdown(pci_dev);
  +       }

  static void pci_device_shutdown(struct device *dev)
  {
    struct pci_dev *pci_dev = to_pci_dev(dev);

    pm_runtime_resume(dev);

    if (pci_dev->dev.driver) {
      struct pci_driver *drv = to_pci_driver(pci_dev->dev.driver);

      if (drv->shutdown)
        drv->shutdown(pci_dev);
    }

and here's the same thing with the NULL check:

  @@ -493,7 +493,7 @@ static void pci_device_remove(struct device *dev)
   static void pci_device_shutdown(struct device *dev)
   {
          struct pci_dev *pci_dev = to_pci_dev(dev);
  -       struct pci_driver *drv = pci_dev->driver;
  +       struct pci_driver *drv = to_pci_driver(dev->driver);

  static void pci_device_shutdown(struct device *dev)
  {
    struct pci_dev *pci_dev = to_pci_dev(dev);
    struct pci_driver *drv = to_pci_driver(dev->driver);

    pm_runtime_resume(dev);

    if (drv && drv->shutdown)
      drv->shutdown(pci_dev);

> >  static bool match_id(struct pci_dev *pdev, unsigned short vendor, unsigned short device)
> >  {
> > +       struct pci_driver *drv = to_pci_driver(pdev->dev.driver);
> >         const struct pci_device_id *id;
> >
> >         if (pdev->vendor == vendor && pdev->device == device)
> >                 return true;
> 
> > +       for (id = drv ? drv->id_table : NULL; id && id->vendor; id++)
> > +               if (id->vendor == vendor && id->device == device)
> 
> > +                       break;
> 
> return true;
> 
> >         return id && id->vendor;
> 
> return false;

Good cleanup for a follow-up patch, but doesn't seem directly related
to the objective here.  The current patch is:

  @@ -80,7 +80,7 @@ static struct resource video_rom_resource = {
    */
   static bool match_id(struct pci_dev *pdev, unsigned short vendor, unsigned short device)
   {
  -       struct pci_driver *drv = pdev->driver;
  +       struct pci_driver *drv = to_pci_driver(pdev->dev.driver);
          const struct pci_device_id *id;

          if (pdev->vendor == vendor && pdev->device == device)

> >         device_lock(&vf_dev->dev);
> > -       if (vf_dev->dev.driver) {
> > +       if (to_pci_driver(vf_dev->dev.driver)) {
> 
> Hmm...

Yeah, it could be either of:

  if (to_pci_driver(vf_dev->dev.driver))
  if (vf_dev->dev.driver)

I went back and forth on that and went with to_pci_driver() on the
theory that we were testing the pci_driver * before and the patch is
more of a mechanical change and easier to review if we test the
pci_driver * after.

> > +               if (!pci_dev->state_saved && pci_dev->current_state != PCI_D0
> 
> > +                   && pci_dev->current_state != PCI_UNKNOWN) {
> 
> Can we keep && on the previous line?

I think this is in pci_legacy_suspend(), and I didn't touch that line.
It shows up in the interdiff because without the NULL check in
to_pci_driver(), we had to indent this code another level.  With the
NULL check, we don't need that extra indentation.

> > +                       pci_WARN_ONCE(pci_dev, pci_dev->current_state != prev,
> > +                                     "PCI PM: Device state not saved by %pS\n",
> > +                                     drv->suspend);
> >                 }
> 
> ...
> 
> > +       return drv && drv->resume ?
> > +                       drv->resume(pci_dev) : pci_pm_reenable_device(pci_dev);
> 
> One line?

I don't think I touched that line.

> > +       struct pci_driver *drv = to_pci_driver(dev->dev.driver);
> >         const struct pci_error_handlers *err_handler =
> > -                       dev->dev.driver ? to_pci_driver(dev->dev.driver)->err_handler : NULL;
> > +                       drv ? drv->err_handler : NULL;
> 
> Isn't dev->driver == to_pci_driver(dev->dev.driver)?

Yes, I think so, but not sure what you're getting at here, can you
elaborate?

> >         device_lock(&dev->dev);
> > +       pdrv = to_pci_driver(dev->dev.driver);
> >         if (!pci_dev_set_io_state(dev, state) ||
> > -               !dev->dev.driver ||
> > -               !(pdrv = to_pci_driver(dev->dev.driver))->err_handler ||
> 
> > +               !pdrv ||
> > +               !pdrv->err_handler ||
> 
> One line now?
> 
> >                 !pdrv->err_handler->error_detected) {
> 
> Or this and the previous line?

Could, but the "dev->driver" to "to_pci_driver(dev->dev.driver)"
changes are the heart of this patch, and I don't like to clutter it
with unrelated changes.

> > -       result = PCI_ERS_RESULT_NONE;
> >
> >         pcidev = pci_get_domain_bus_and_slot(domain, bus, devfn);
> >         if (!pcidev || !pcidev->dev.driver) {
> >                 dev_err(&pdev->xdev->dev, "device or AER driver is NULL\n");
> >                 pci_dev_put(pcidev);
> > -               return result;
> > +               return PCI_ERS_RESULT_NONE;
> >         }
> >         pdrv = to_pci_driver(pcidev->dev.driver);
> 
> What about splitting the conditional to two with clear error message
> in each and use pci_err() in the second one?

Could possibly be cleaned up.  Felt like feature creep so I didn't.

> >                 default:
> >                         dev_err(&pdev->xdev->dev,
> > -                               "bad request in aer recovery "
> > -                               "operation!\n");
> > +                               "bad request in AER recovery operation!\n");
> 
> Stray change? Or is it in a separate patch in your tree?

Could be skipped.  The string now fits on one line so I combined it to
make it more greppable.

Bjorn


From xen-devel-bounces@lists.xenproject.org Wed Oct 13 11:53:07 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 11:53:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.208277.364338 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1macoY-0007Bf-HN; Wed, 13 Oct 2021 11:52:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 208277.364338; Wed, 13 Oct 2021 11:52:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1macoY-0007BY-EH; Wed, 13 Oct 2021 11:52:54 +0000
Received: by outflank-mailman (input) for mailman id 208277;
 Wed, 13 Oct 2021 11:52:53 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1macoX-0007BS-Lk
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 11:52:53 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1macoX-0003lF-Fp
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 11:52:53 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1macoX-0000tV-Er
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 11:52:53 +0000
Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89)
 (envelope-from <iwj@xenproject.org>)
 id 1macoK-0007S5-Mc; Wed, 13 Oct 2021 12:52:40 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date
	:Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From;
	bh=2WT0kmTFC401nOY6M3W3ge4h8W9JrHrW5ZPpi0UGoSk=; b=sP5GiQbNM2L8mqQTBYSkou6WQC
	drzvEmYIy+NCdOHZcp6IrweYv5EWDMF4WSee/+1u0KdiPRVJbvrxI4oNR27nnHntXywX+M+cUvXpU
	DPme82L4ftb1mWRCCPrZ8b3FYRNeg14k0Mlz7+89K4Jn/VGTH1Vsaj/T7Ar65wW3e+Z4=;
From: Ian Jackson <iwj@xenproject.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
Message-ID: <24934.51335.791795.638185@mariner.uk.xensource.com>
Date: Wed, 13 Oct 2021 12:52:39 +0100
To: Roger Pau =?iso-8859-1?Q?Monn=E9?= <roger.pau@citrix.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
    Bertrand Marquis <Bertrand.Marquis@arm.com>,
    Jan Beulich <jbeulich@suse.com>,
    Oleksandr  Andrushchenko <Oleksandr_Andrushchenko@epam.com>,
    Rahul Singh <Rahul.Singh@arm.com>,
    "xen-devel\@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
    Andre Przywara <Andre.Przywara@arm.com>,
    Wei Liu <wl@xen.org>,
    Juergen Gross <jgross@suse.com>
Subject: Re: [PATCH v5 01/11] xen/arm: xc_domain_ioport_permission(..) not
 supported on ARM.
In-Reply-To: <YWaTztHHHeghjxDR@MacBook-Air-de-Roger.local>
References: <0744b957-1832-dff2-9ae2-b8e8534f501b@suse.com>
	<c3952fd5-b893-4cb6-a9bc-325a89e859db@epam.com>
	<c125b447-53e8-7d13-3b08-af62fd3a9140@suse.com>
	<c6b6c22f-fb8a-f2d9-7735-f1ebc9809908@epam.com>
	<09656882-b297-7144-c291-1ee997edb119@suse.com>
	<69A83587-B7E0-4653-AF8C-AEE802922CE5@arm.com>
	<24933.41349.893363.203683@mariner.uk.xensource.com>
	<AB6D62B6-2ED2-4957-A933-08EC77A4DFD6@arm.com>
	<24933.47094.43672.782143@mariner.uk.xensource.com>
	<alpine.DEB.2.21.2110121319150.9408@sstabellini-ThinkPad-T480s>
	<YWaTztHHHeghjxDR@MacBook-Air-de-Roger.local>
X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu)

Roger Pau Monn� writes ("Re: [PATCH v5 01/11] xen/arm: xc_domain_ioport_permission(..) not supported on ARM."):
> On Tue, Oct 12, 2021 at 01:42:22PM -0700, Stefano Stabellini wrote:
> > I don't think it is about performance. From a performance point of view,
> > we could make as many (unneeded) hypercalls as required. It is mostly
> > about minimizing unwanted changes to common libxl code. Let me explain.

Thanks.  This summary is helpful  And, pleasingly, it matches what I
had thought I had gleaned from the thread.

> > All options above achieve the goal of a successful domain creation with
> > PCI device assigned on ARM. You might be able to think of other options
> > as well. I think noone here is really set on using one option over the
> > other -- as long as xc_domain_ioport_permission failures don't turn into
> > domain creation failures on ARM we are good.
> 
> I think having a libxl_arch_io_ports_supported helper could be the
> cleaner way to do this. For x86 it will unconditionally return true,
> while for Arm you could consider poking at
> XEN_DOMCTL_ioport_permission and see if it returns ENOSYS or
> otherwise.

> I guess it's possible that in the future we allow IO ports access on
> Arm guests using some kind of emulated mechanism if the need arises,
> at which point the hypercall will be implemented.

I agree with Roger.

So I think I would like to see a version of this patch which

  * Introduces libxl_arch_io_ports_supported.  (I am fine with it just
    returning false, unconditionally on Arm, ie in libxl_arm.c.)

  * Has a commit message explaining what is actually going on.
    Cutting and pasting liberally from your email seems like it would
    be a very good starting point.  Even discussion of rejected
    alternatives is fine, if it seems like it fits.  I'm quite
    unlikely to object to a commit message on grounds that it's too
    long.

Thanks,
Ian.


From xen-devel-bounces@lists.xenproject.org Wed Oct 13 11:58:27 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 11:58:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.208285.364349 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1macts-0007rZ-5E; Wed, 13 Oct 2021 11:58:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 208285.364349; Wed, 13 Oct 2021 11:58:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1macts-0007rS-1b; Wed, 13 Oct 2021 11:58:24 +0000
Received: by outflank-mailman (input) for mailman id 208285;
 Wed, 13 Oct 2021 11:58:22 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mactq-0007rM-Fe
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 11:58:22 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mactq-0003qq-EC
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 11:58:22 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mactq-0001RU-DB
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 11:58:22 +0000
Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89)
 (envelope-from <iwj@xenproject.org>)
 id 1mactk-0007UY-V6; Wed, 13 Oct 2021 12:58:17 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date
	:Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From;
	bh=/GdvLPWcAUtEB4bzfuuBdEs9TFr49hN2q029JtHzLmo=; b=4bza8iByaLHiUV3Qb0rFoDxLmH
	cdTA2Z+CvJT/rz1Z88BJ+yeoEJhJIoy2mhgQmT/4L9RBl+Y4OjWGWRjVuuLUcTxweot4awYeIT8Ee
	QSlsY2txLko8mPahIVIvly1/eHKPMl25O0ZL7z1ajlVLsQxlJ3Nd4d64dRmlwUaOPQMw=;
From: Ian Jackson <iwj@xenproject.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <24934.51672.609742.454355@mariner.uk.xensource.com>
Date: Wed, 13 Oct 2021 12:58:16 +0100
To: Michal Orzel <michal.orzel@arm.com>
Cc: Julien Grall <julien@xen.org>,
    xen-devel@lists.xenproject.org,
    Andrew Cooper <andrew.cooper3@citrix.com>,
    George Dunlap <george.dunlap@citrix.com>,
    Jan Beulich <jbeulich@suse.com>,
    Stefano Stabellini  <sstabellini@kernel.org>,
    Wei Liu <wl@xen.org>,
    Nick Rosbrook <rosbrookn@ainfosec.com>,
    Anthony PERARD <anthony.perard@citrix.com>,
    Juergen Gross <jgross@suse.com>,
    Christian Lindig <christian.lindig@citrix.com>,
    David Scott  <dave@recoil.org>,
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
    bertrand.marquis@arm.com
Subject: Re: [PATCH v6] xen: Expose the PMU to the guests
In-Reply-To: <a0618ea7-3c66-bfca-20fb-62855c8791e4@arm.com>
References: <20211013074528.1396-1-michal.orzel@arm.com>
	<75e19429-49d2-c075-acb8-797c01364771@xen.org>
	<a0618ea7-3c66-bfca-20fb-62855c8791e4@arm.com>
X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu)

Michal Orzel writes ("Re: [PATCH v6] xen: Expose the PMU to the guests"):
> Ok so it is the matter of adding "HVM" word into status for x86.
> Is this something that can be done while committing?

Making changes while committing is risky because they don't get
properly reviewed.  When I am the committer, I prefer not to do it at
all.

Also committers are going to be very busy now.  Please don't ask them
to do extra work.

Thanks,
Ian.


From xen-devel-bounces@lists.xenproject.org Wed Oct 13 12:01:30 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 12:01:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.208297.364360 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1macwr-0000vl-T3; Wed, 13 Oct 2021 12:01:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 208297.364360; Wed, 13 Oct 2021 12:01:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1macwr-0000ve-Oq; Wed, 13 Oct 2021 12:01:29 +0000
Received: by outflank-mailman (input) for mailman id 208297;
 Wed, 13 Oct 2021 12:01:28 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1macwq-0000vY-0K
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 12:01:28 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1macwp-0003xk-Vq
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 12:01:27 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1macwp-0001u0-Ux
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 12:01:27 +0000
Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89)
 (envelope-from <iwj@xenproject.org>)
 id 1macwm-0007W1-79; Wed, 13 Oct 2021 13:01:24 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date
	:Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From;
	bh=nQU6TI2PtWNBs/i68t8H3oeT0PBEvEJ8oUIdbu6WNwA=; b=payHZ7gAk4ADGf3o7+zxYONoi8
	9XHM94kSXJeLWJex17mDG8UXfKslWKgG9IKqv6ryled+rF/hNmhOVClK7vw/ObYm0EsKortOTdaZE
	kUO9+DvUs5P32hu8BFvIfuAll/0TAWIEPe5ekvVhwgvXY6oSflrjjxX8N9Bn2WkWIZoY=;
From: Ian Jackson <iwj@xenproject.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <24934.51859.927952.290897@mariner.uk.xensource.com>
Date: Wed, 13 Oct 2021 13:01:23 +0100
To: Michal Orzel <michal.orzel@arm.com>
Cc: xen-devel@lists.xenproject.org,
    Andrew Cooper <andrew.cooper3@citrix.com>,
    George Dunlap <george.dunlap@citrix.com>,
    Ian Jackson <iwj@xenproject.org>,
    Jan Beulich <jbeulich@suse.com>,
    Julien Grall <julien@xen.org>,
    Stefano Stabellini <sstabellini@kernel.org>,
    Wei Liu <wl@xen.org>,
    Nick Rosbrook <rosbrookn@ainfosec.com>,
    Anthony PERARD <anthony.perard@citrix.com>,
    Juergen Gross <jgross@suse.com>,
    Christian Lindig <christian.lindig@citrix.com>,
    David Scott <dave@recoil.org>,
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
    bertrand.marquis@arm.com
Subject: Re: [PATCH v6] xen: Expose the PMU to the guests
In-Reply-To: <20211013074528.1396-1-michal.orzel@arm.com>
References: <20211013074528.1396-1-michal.orzel@arm.com>
X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu)

Michal Orzel writes ("[PATCH v6] xen: Expose the PMU to the guests"):
> Add parameter vpmu to xl domain configuration syntax
> to enable the access to PMU registers by disabling
> the PMU traps(currently only for ARM).
...
> Signed-off-by: Michal Orzel <michal.orzel@arm.com>
> Signed-off-by: Julien Grall <julien@xen.org>
> Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>
> Acked-by: Anthony PERARD <anthony.perard@citrix.com>

I have looked at the tools parts of this and I am fine with them,
especially since Anthony has given his ack for the libxl parts
specifically.

So, for tools:

Acked-by: Ian Jackson <iwj@xenproject.org>

However, this still needs a REST ack, especially, for the SUPPORT.md
change.  There's an update needed there, so I think we should look
forward to a respin.

Ian.


From xen-devel-bounces@lists.xenproject.org Wed Oct 13 12:01:40 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 12:01:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.208298.364370 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1macx2-0001Fg-3m; Wed, 13 Oct 2021 12:01:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 208298.364370; Wed, 13 Oct 2021 12:01:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1macx2-0001FZ-0m; Wed, 13 Oct 2021 12:01:40 +0000
Received: by outflank-mailman (input) for mailman id 208298;
 Wed, 13 Oct 2021 12:01:38 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=YJ5V=PB=kroah.com=greg@srs-us1.protection.inumbo.net>)
 id 1macx0-0001Ei-5S
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 12:01:38 +0000
Received: from wnew1-smtp.messagingengine.com (unknown [64.147.123.26])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 49500883-60dd-4a07-b8b7-08b14723f1de;
 Wed, 13 Oct 2021 12:01:37 +0000 (UTC)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailnew.west.internal (Postfix) with ESMTP id 576D32B01147;
 Wed, 13 Oct 2021 08:01:35 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
 by compute1.internal (MEProxy); Wed, 13 Oct 2021 08:01:36 -0400
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed,
 13 Oct 2021 08:01:34 -0400 (EDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 49500883-60dd-4a07-b8b7-08b14723f1de
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kroah.com; h=
	date:from:to:cc:subject:message-id:references:mime-version
	:content-type:in-reply-to; s=fm2; bh=rWSTPfUE7TPFJmRSRxhKh167/BF
	9qamvvLkRCh+xraU=; b=BnSLwvl8etPnKDZMDCwGFruLeZkA4E0sTOIckHlIQcE
	iHOFRIWF7hYdfjsHi6Cno+mPXAEHvaejeZXrhex5ZTKTrYPAe0+juEwn/3KqgU0c
	2UxnIWfBiwMd4fV1w0dvuA+U3AW/lD+NWzcfpQ6SL5TCkbQgqRUBO/KgA8fa5M+E
	DB8AQ40sQMusqn75Mpya7tFXp62c+G6twWvpXWfA8bZyllWYAF8oZ8c6/AF8vxLw
	MaUqtQr4zPuy4bqifhli/0JLwDVZMV4yf3eShY8h/p/ro6w66yuYz+z+F0cSNXOy
	tyQxngCkycA/UJ18RWUc5LdwbEXXE/QFeGrbhOy8nhg==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:content-type:date:from:in-reply-to
	:message-id:mime-version:references:subject:to:x-me-proxy
	:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=rWSTPf
	UE7TPFJmRSRxhKh167/BF9qamvvLkRCh+xraU=; b=leJQVqYOo3MK1AKg8I93W9
	poDakF5UaXQBBF2bHZWXF+os/St+iXLxvzMPssyxVES2wmBwPiSz75/y/1xLRtRb
	WawJH0zPEjTvIDfiGTHlF+ef6DzPODmwIoT1QHiyD3uhOzzwqtci4nFgV+zR8Mb/
	ypRbTHoT0/xTNGO+OTeJYIF055130iF6xceJNEwX9pnLXVd4cK7bJozZRu/nHVLO
	QkJwXVs80hzb6mHbfEesObZ2DfQRsiV8322FZ4bkts+rDnjN6p1s5IZCliZe41/X
	y8n6mNHXuORGbgj+jdySTGrKMHCx9W8a1+hpgkQ/gbjDJL4LFC0kYL/BVuwRUZyg
	==
X-ME-Sender: <xms:nspmYVGYX69udfCGH8GMeoaBVhTzR-qQPyLl5uyX2BIOyOuhybvcIA>
    <xme:nspmYaW8Ln-UPe5UVhb7JJ3w0lAV-ecJaDTjakLbE9CXXRPZnM0ki5XdQszyAXtiP
    DFlTQfr_D1RgA>
X-ME-Received: <xmr:nspmYXLo3hk2RSvPCnEtgPHi1fqREDQT7kXmz2jYIygKkau9nkd8pDc1z7TiiO84awA12_n_DaoUJPhJ_uE7FE7UrNr_aetz>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrvddutddggeehucetufdoteggodetrfdotf
    fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
    uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
    cujfgurhepfffhvffukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpefirhgvghcu
    mffjuceoghhrvghgsehkrhhorghhrdgtohhmqeenucggtffrrghtthgvrhhnpeevueehje
    fgfffgiedvudekvdektdelleelgefhleejieeugeegveeuuddukedvteenucevlhhushht
    vghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehgrhgvgheskhhrohgrhh
    drtghomh
X-ME-Proxy: <xmx:nspmYbHQurJsJju3UTcqVrn7HlgeoGN0KHK-VEWT273tWVLbQFkBbA>
    <xmx:nspmYbWleQ4P5mlKqbAQhWNU66AAqX2bkVMsfgIyyhTmOrycQRVuPA>
    <xmx:nspmYWPIbq72nnLU_PyUxHK9F_UYfqipSYRNXXmSikdMtb0zxFf2Dw>
    <xmx:nspmYUMPmSZrp79yZ1_Yi3EqFcYq0HUkh_YVJQnbbqsQmR4r8WLBhOBiovY>
Date: Wed, 13 Oct 2021 14:01:32 +0200
From: Greg KH <greg@kroah.com>
To: Juergen Gross <jgross@suse.com>
Cc: linux-usb@vger.kernel.org, xen-devel@lists.xenproject.org,
	linux-kernel@vger.kernel.org,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>
Subject: Re: [PATCH v6 1/3] usb: Add Xen pvUSB protocol description
Message-ID: <YWbKnEMvHGU/rv96@kroah.com>
References: <20211013075207.13910-1-jgross@suse.com>
 <20211013075207.13910-2-jgross@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211013075207.13910-2-jgross@suse.com>

On Wed, Oct 13, 2021 at 09:52:05AM +0200, Juergen Gross wrote:
> Add the definition of pvUSB protocol used between the pvUSB frontend in
> a Xen domU and the pvUSB backend in a Xen driver domain (usually Dom0).
> 
> This header was originally provided by Fujitsu for Xen based on Linux
> 2.6.18.
> 
> Changes are:
> - adapt to Linux kernel style guide
> - use Xen namespace
> - add lots of comments
> - don't use kernel internal defines
> 
> Signed-off-by: Juergen Gross <jgross@suse.com>
> Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> ---
>  include/xen/interface/io/usbif.h | 421 +++++++++++++++++++++++++++++++
>  1 file changed, 421 insertions(+)
>  create mode 100644 include/xen/interface/io/usbif.h
> 
> diff --git a/include/xen/interface/io/usbif.h b/include/xen/interface/io/usbif.h
> new file mode 100644
> index 000000000000..9494b1c9be99
> --- /dev/null
> +++ b/include/xen/interface/io/usbif.h
> @@ -0,0 +1,421 @@
> +/*
> + * usbif.h
> + *
> + * USB I/O interface for Xen guest OSes.
> + *
> + * Copyright (C) 2009, FUJITSU LABORATORIES LTD.
> + * Author: Noboru Iwamatsu <n_iwamatsu@jp.fujitsu.com>
> + *
> + * Permission is hereby granted, free of charge, to any person obtaining a copy
> + * of this software and associated documentation files (the "Software"), to
> + * deal in the Software without restriction, including without limitation the
> + * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or
> + * sell copies of the Software, and to permit persons to whom the Software is
> + * furnished to do so, subject to the following conditions:
> + *
> + * The above copyright notice and this permission notice shall be included in
> + * all copies or substantial portions of the Software.
> + *
> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
> + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
> + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
> + * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
> + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
> + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
> + * DEALINGS IN THE SOFTWARE.
> + */

Please use a SPDX line and not license "boilerplate" text like this :(

thanks,

greg k-h


From xen-devel-bounces@lists.xenproject.org Wed Oct 13 12:02:35 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 12:02:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.208309.364382 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1macxu-00024g-Dv; Wed, 13 Oct 2021 12:02:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 208309.364382; Wed, 13 Oct 2021 12:02:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1macxu-00024Z-AM; Wed, 13 Oct 2021 12:02:34 +0000
Received: by outflank-mailman (input) for mailman id 208309;
 Wed, 13 Oct 2021 12:02:33 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1macxt-00024L-TL
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 12:02:33 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1macxt-0003ze-Sa
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 12:02:33 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1macxt-00023r-Rs
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 12:02:33 +0000
Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89)
 (envelope-from <iwj@xenproject.org>)
 id 1macxj-0007XH-Rm; Wed, 13 Oct 2021 13:02:23 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date
	:Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From;
	bh=jdxMlChK8o9c2/GnMMmZzLHnp9pzrQP2ZAhudAXxbIQ=; b=rbkeL2mtQbiyRiyYDlQcoLCoI7
	3Sxbeyqn03OkHYGrjcnxZplKE/oajs/aVjeNi5+NfVHDP2K3AjlAZEJSEJSHyhmxvtHv1qN30dyL9
	x2Lf376HFwwcCquC2aV0nWyvFJncvGMjMTZRIsllHW2nRqYuup0jTieu4scnPPivTydY=;
From: Ian Jackson <iwj@xenproject.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
Message-ID: <24934.51918.994290.825524@mariner.uk.xensource.com>
Date: Wed, 13 Oct 2021 13:02:22 +0100
To: Roger Pau =?iso-8859-1?Q?Monn=E9?= <roger.pau@citrix.com>
Cc: Bertrand Marquis <Bertrand.Marquis@arm.com>,
    Jan Beulich <jbeulich@suse.com>,
    Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>,
    Rahul Singh <Rahul.Singh@arm.com>,
    "xen-devel\@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
    Andre Przywara <Andre.Przywara@arm.com>,
    Wei Liu <wl@xen.org>,
    Juergen Gross <jgross@suse.com>,
    Stefano Stabellini <sstabellini@kernel.org>
Subject: Re: [PATCH v5 01/11] xen/arm: xc_domain_ioport_permission(..) not
 supported on ARM.
In-Reply-To: <YWaSkrqzXoysQkCz@MacBook-Air-de-Roger.local>
References: <ac6d4785-ac9a-4491-26bb-c66ffe82c55b@suse.com>
	<ED8FC92F-B5EF-4473-B4A9-641C7D44859F@arm.com>
	<0744b957-1832-dff2-9ae2-b8e8534f501b@suse.com>
	<c3952fd5-b893-4cb6-a9bc-325a89e859db@epam.com>
	<c125b447-53e8-7d13-3b08-af62fd3a9140@suse.com>
	<c6b6c22f-fb8a-f2d9-7735-f1ebc9809908@epam.com>
	<09656882-b297-7144-c291-1ee997edb119@suse.com>
	<69A83587-B7E0-4653-AF8C-AEE802922CE5@arm.com>
	<24933.41349.893363.203683@mariner.uk.xensource.com>
	<AB6D62B6-2ED2-4957-A933-08EC77A4DFD6@arm.com>
	<YWaSkrqzXoysQkCz@MacBook-Air-de-Roger.local>
X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu)

Roger Pau Monn� writes ("Re: [PATCH v5 01/11] xen/arm: xc_domain_ioport_permission(..) not supported on ARM."):
> IMO it would be good to modify the commit message so it covers the
> fact that the emulated host bridge on Arm does not advertise IO port
> support, so the guest is capable of realizing IO BARs are not
> supported.

Yes.

> Otherwise it seems like the toolstack is ignoring a failure which
> could cause a device to malfunction when passed though (which is still
> the case, but the guest will be able to notice).

Quite.

Thanks,
Ian.


From xen-devel-bounces@lists.xenproject.org Wed Oct 13 12:12:17 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 12:12:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.208318.364393 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mad7A-0003bR-C8; Wed, 13 Oct 2021 12:12:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 208318.364393; Wed, 13 Oct 2021 12:12:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mad7A-0003bK-8h; Wed, 13 Oct 2021 12:12:08 +0000
Received: by outflank-mailman (input) for mailman id 208318;
 Wed, 13 Oct 2021 12:12:07 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=0M7b=PB=arm.com=Bertrand.Marquis@srs-us1.protection.inumbo.net>)
 id 1mad78-0003bE-R0
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 12:12:06 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com (unknown
 [40.107.20.69]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id c79e70e6-2c1e-11ec-816d-12813bfff9fa;
 Wed, 13 Oct 2021 12:12:05 +0000 (UTC)
Received: from AM6P193CA0047.EURP193.PROD.OUTLOOK.COM (2603:10a6:209:8e::24)
 by AS8PR08MB7046.eurprd08.prod.outlook.com (2603:10a6:20b:346::23) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.19; Wed, 13 Oct
 2021 12:11:46 +0000
Received: from VE1EUR03FT058.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:209:8e:cafe::3) by AM6P193CA0047.outlook.office365.com
 (2603:10a6:209:8e::24) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15 via Frontend
 Transport; Wed, 13 Oct 2021 12:11:46 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT058.mail.protection.outlook.com (10.152.19.86) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.15 via Frontend Transport; Wed, 13 Oct 2021 12:11:46 +0000
Received: ("Tessian outbound e27daf245730:v103");
 Wed, 13 Oct 2021 12:11:45 +0000
Received: from a25a82c6b005.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 A966DB8F-59DD-4F8F-B3C5-AB7463EF4464.1; 
 Wed, 13 Oct 2021 12:11:35 +0000
Received: from EUR03-VE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id a25a82c6b005.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Wed, 13 Oct 2021 12:11:35 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com (2603:10a6:4:74::9)
 by DB7PR08MB4601.eurprd08.prod.outlook.com (2603:10a6:10:30::24) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15; Wed, 13 Oct
 2021 12:11:31 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955]) by DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955%4]) with mapi id 15.20.4587.026; Wed, 13 Oct 2021
 12:11:30 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c79e70e6-2c1e-11ec-816d-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=vwMYQ1g5ZE8bVRXL4ibtdUpb6Os9usTBYPvK82x2kCc=;
 b=tsCHNGvl3ZoJb9aylZU4vjxIeBjLtQX3XaPTCtsVc14fz5thsHJZrVv7asalbrhh6akeVVbzf1+edq4w8gGUt0cb3+yMX263PSa/P37xyGuX0mkzPIOfbGYPuWvuH8bkASNed07VuL2SBxNlFyZjum1ZiLx1AgINZeP9hDh6C04=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: f5f2d82d7c7cfd2b
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=JeIYqpBQk3WM0z9GML25L6xUei/8zxsX8NNx0oNKrrtW2zaTi6mb9yE3Do2yjq9jxYj1rmnbu7Uy9X+stuRMfAKfo8GSAlDTBegWwqU60EQAjhGNgItiU4YWx7AVCyoSN1oAG7mtobaFKXAPGpn8+HsYptw+oSyAOpcDJNm7IzYqR/6LtDKlJ8J4lg3Yg6GBxqfgC0E/7GVdFLr9Gq6YWUqTK4FZoy1AFZX3FtQiW4s9IWrI0TNcSGDReJlBBWTEuP/dtRssHMM2xFinGVJHY87FhfzaQythPvSAtl11HaTgf7j1D+/8sk72x8juXeGOBAltjvTmc5JFpzBQyC2Biw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=vwMYQ1g5ZE8bVRXL4ibtdUpb6Os9usTBYPvK82x2kCc=;
 b=KwYdSbBk7q38YzZrwSnscbhuBaj4g80bzwb5b5S9rZWSWxJG+K9OjlgYFCO8OMEb3chgUSFxdq7ZF2iEKi3XPcAE/sHQtLG+/BjltLH0JKMEKCJv2mGobGW3oqVshRdMmfiazf9q0gyaCKs5FMM1QdvLNuohGHunUk/ZlouYmpc27bEYuIBvzNuYJItll3n0OSRrhbQh0j13csQDz78A6cBr0R0dpJ2zY9aBxKXgc3oMFwF2TNYY7YZRyFVuIe+bYZG3ZZomP8mt/47jcps0ji5CQS1GRxFL4JdxefjdsygSApmZ/eV5mDkQYXy2wsG4HHIiAv3IZDHNCAM9DvxpTg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=vwMYQ1g5ZE8bVRXL4ibtdUpb6Os9usTBYPvK82x2kCc=;
 b=tsCHNGvl3ZoJb9aylZU4vjxIeBjLtQX3XaPTCtsVc14fz5thsHJZrVv7asalbrhh6akeVVbzf1+edq4w8gGUt0cb3+yMX263PSa/P37xyGuX0mkzPIOfbGYPuWvuH8bkASNed07VuL2SBxNlFyZjum1ZiLx1AgINZeP9hDh6C04=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>
CC: Michal Orzel <Michal.Orzel@arm.com>, Rahul Singh <Rahul.Singh@arm.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Andre
 Przywara <Andre.Przywara@arm.com>, Christian Lindig
	<christian.lindig@citrix.com>, David Scott <dave@recoil.org>, Ian Jackson
	<iwj@xenproject.org>, Wei Liu <wl@xen.org>, Andrew Cooper
	<andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>, Jan
 Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>, Stefano
 Stabellini <sstabellini@kernel.org>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH v5 07/11] xen/domctl: Introduce XEN_DOMCTL_CDF_vpci flag
Thread-Topic: [PATCH v5 07/11] xen/domctl: Introduce XEN_DOMCTL_CDF_vpci flag
Thread-Index:
 AQHXutmFlM61oLukkkqK7dSQSsVJ1qvNjrkAgAGmMoCAAW6PgIAAEkkAgAAWnQCAABTUgA==
Date: Wed, 13 Oct 2021 12:11:30 +0000
Message-ID: <9C5C0FE2-67EA-4CD7-893B-82C156F5F77A@arm.com>
References: <cover.1633540842.git.rahul.singh@arm.com>
 <20d5b9d6a0d01a7b90711d28cbefb5701a88b438.1633540842.git.rahul.singh@arm.com>
 <YWQDguvmf/O4rDIs@MacBook-Air-de-Roger.local>
 <9217a6b8-fc53-a049-7cd3-7458b574424b@arm.com>
 <YWaZKX44IOfIBtX6@MacBook-Air-de-Roger.local>
 <8F9D6B9C-58CB-4000-995A-95517EE72A3B@arm.com>
 <YWa7eGr3D8Ax8VUX@MacBook-Air-de-Roger.local>
In-Reply-To: <YWa7eGr3D8Ax8VUX@MacBook-Air-de-Roger.local>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3654.120.0.1.13)
Authentication-Results-Original: citrix.com; dkim=none (message not signed)
 header.d=none;citrix.com; dmarc=none action=none header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: 51405a69-2da6-4625-df82-08d98e42a0a4
x-ms-traffictypediagnostic: DB7PR08MB4601:|AS8PR08MB7046:
x-ms-exchange-transport-forked: True
X-Microsoft-Antispam-PRVS:
	<AS8PR08MB704638BD7CAC23368F5802D99DB79@AS8PR08MB7046.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:9508;OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 eYXzt1ZDEK+T6eLtzBSlorMHiFPN7shzz5F9hSDIU6G8gYmUg6+rzrzztEpsUbNnr2kkFQ/7eDTGod1sxblkTQ6XrHYGkpnNLCrMQigTQlSrSxLH6jiIPNxzIBca24l++U3Zcr+sp4fieEAI5YST99CO5Qf341tWSc8SrycnTKd2n4EUxU3wja9vqLy24Q1iLKqO04bFDaMKVR0liUsCDYSeLP2LpoECHtqZAzZGS31wQzoyTJDYjecyWlmUWxaa3QOGnWE9rZ1qOSuvv4rrPFH0ZOC1DY3YgdipSF0NsAg2wyPVUBtcbhaFyun222SM2r2gqpz7t8RR6C7s8b/fSZViR1p9gSQhSIh0Qq1iNmC5Fz7siZYxdqRDapXx5afFw1iqbz2MimMy5F6x2hCyUv+jy89sWEMXNcI2A/2S2WaJa3bs+P//B55eFGBHLHDW1KGYAJ72q0DCzQJ4Sg3Gb92pL9V+7MSxWH+aAhV1Zqc8/qw5mWZFvXE8m3pX5EthaQrtl0IW6VU9CEa5FhGJNmUC/cs1hG3GQpnYfBU8oZKu5VDepTMxwSi9hrmdCUqwbyfdxajqZN08eeCmEGTcuw+rMhzo+g3Cg/y+mUAF7HD65pWKRmQR4VJBFuyov9sGejNTDZa9GbnMqgSn85645UZKixI2o/+BwWvHD3LRHKzrhfa3qIazB+BvdIDGkNmJNRcMmTbxU9MD9bI4i4yc9WJatK+3v41F2pLXfVMCwlEmYr2NZMT2+zwUo/JeiTfA
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB6PR0801MB2024.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(71200400001)(33656002)(64756008)(5660300002)(38100700002)(66446008)(38070700005)(2906002)(53546011)(6506007)(91956017)(4326008)(6916009)(66556008)(122000001)(86362001)(8936002)(83380400001)(2616005)(508600001)(6512007)(316002)(66476007)(186003)(26005)(66946007)(6486002)(7416002)(36756003)(76116006)(8676002)(54906003)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-ID: <37BF04DAAE1FA24489DCA4B3F39FDF0E@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB4601
Original-Authentication-Results: citrix.com; dkim=none (message not signed)
 header.d=none;citrix.com; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT058.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	7adf50b3-7af4-4701-915f-08d98e429752
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	slYgyZfXKyFv3j9X8k6WlB4qOEiei18RnOoQgfzJTqheCphhcVZgSITKNJyYQiDyASkkDnR9U0Rtx9fMbKUDH7WZthSkbkpK9kQcKzGfoMzon+CQQ896naQqyGBFLNMRvlIJaTkWqWYHmnd+PxL/5taXIBTxi6fFIF5F49oObJ8o7I/9BdUtEJI6hfyQvB9fm/O2EWRa9fctZcbXZXzjPOijcq7hf0+1X80GfD89TO7o3VEIJ39joLLBDkx+mFOJj4GZufRorITkk8wCAbLPuC5lVyVTnWgMoIkGVfVK37WqPm/LlcSk0sNig9Tk6GuosFJhwfJVzXr/reQ5QjJ94yowLtlznBWOp2q401FnlpzMzDTwQ6TfpNQEhi0eYHjEWeSs9kiiFpQOxthU01xmGKfDnkehSN932nJIN6nQkhqS8SXF94KOJmFp2XYNe2HrntNnY00O96l7/MBGu0NJ5C67vf9DQeAFkZIIzR4skUGS7a5KLEkbrP9VakU5GWjlcArVXBkz0P86SEfIakRT62Nbr7lAs4r+4vnqrWIaY08ME4+DXij34zL4wKxZ6emgBfjI5SDIMnhCEP4eBy4hbUvMLm7bu6oC8ErqvWvo8kEa+dPO6pcah1DFZjX/dPTyLGbVOSDkIshYR3rePNh50lv2X1fAs3hxzlslCiAOeH4mKVsWpK4hmIwowt6tHrPmwgeon3GswKifCDd5SNRvYA==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(70586007)(186003)(47076005)(81166007)(70206006)(6486002)(54906003)(6862004)(2616005)(508600001)(83380400001)(86362001)(33656002)(36860700001)(53546011)(336012)(8936002)(6512007)(6506007)(107886003)(316002)(8676002)(36756003)(26005)(82310400003)(356005)(2906002)(5660300002)(4326008);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2021 12:11:46.2251
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 51405a69-2da6-4625-df82-08d98e42a0a4
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT058.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB7046

SGkgUm9nZXIsDQoNCj4gT24gMTMgT2N0IDIwMjEsIGF0IDExOjU2LCBSb2dlciBQYXUgTW9ubsOp
IDxyb2dlci5wYXVAY2l0cml4LmNvbT4gd3JvdGU6DQo+IA0KPiBPbiBXZWQsIE9jdCAxMywgMjAy
MSBhdCAwOTozNjowMUFNICswMDAwLCBCZXJ0cmFuZCBNYXJxdWlzIHdyb3RlOg0KPj4gSGkgUm9n
ZXIsDQo+PiANCj4+PiBPbiAxMyBPY3QgMjAyMSwgYXQgMDk6MzAsIFJvZ2VyIFBhdSBNb25uw6kg
PHJvZ2VyLnBhdUBjaXRyaXguY29tPiB3cm90ZToNCj4+PiANCj4+PiBPbiBUdWUsIE9jdCAxMiwg
MjAyMSBhdCAxMjozODozNVBNICswMjAwLCBNaWNoYWwgT3J6ZWwgd3JvdGU6DQo+Pj4+IEhpIFJv
Z2VyLA0KPj4+PiANCj4+Pj4gT24gMTEuMTAuMjAyMSAxMToyNywgUm9nZXIgUGF1IE1vbm7DqSB3
cm90ZToNCj4+Pj4+IE9uIFdlZCwgT2N0IDA2LCAyMDIxIGF0IDA2OjQwOjMzUE0gKzAxMDAsIFJh
aHVsIFNpbmdoIHdyb3RlOg0KPj4+Pj4+IEludHJvZHVjZSBYRU5fRE9NQ1RMX0NERl92cGNpIGZs
YWcgdG8gZW5hYmxlIFZQQ0kgc3VwcG9ydCBpbiBYRU4uDQo+Pj4+Pj4gUmVqZWN0IHRoZSB1c2Ug
b2YgdGhpcyBuZXcgZmxhZyBmb3IgeDg2IGFzIFZQQ0kgaXMgbm90IHN1cHBvcnRlZCBmb3INCj4+
Pj4+PiBET01VIGd1ZXN0cyBmb3IgeDg2Lg0KPj4+Pj4gDQo+Pj4+PiBJIGRvbid0IGxpa2UgdGhp
cyBhcHByb2FjaCwgWEVOX0RPTUNUTF9DREZfdnBjaSBzaG91bGQgYmUgc2V0IGZvciB4ODYNCj4+
Pj4+IFBWSCBkb20wLCBsaWtlIHdlIGRvIGZvciBhbnkgb3RoZXIgQ0RGIGZsYWdzIHdoZW4gWGVu
IGJ1aWxkcyBkb20wLg0KPj4+Pj4gDQo+Pj4+PiBUaGluZ3MgbGlrZSBQVkggdnMgUFYgZ2V0IHRy
YW5zbGF0ZWQgaW50byBDREYgZmxhZ3MgYnkgY3JlYXRlX2RvbTAsDQo+Pj4+PiBhbmQgcHJvY2Vz
c2VkIG5vcm1hbGx5IGJ5IHRoZSBzYW5pdGlzZV9kb21haW5fY29uZmlnIGxvZ2ljLCB2UENJDQo+
Pj4+PiBzaG91bGQgYmUgaGFuZGxlZCB0aGF0IHdheS4NCj4+Pj4+IA0KPj4+Pj4gRG8geW91IHRo
aW5rIHlvdSBjb3VsZCBzZWUgYWJvdXQgZml4aW5nIHRoaXM/DQo+Pj4+PiANCj4+Pj4+IFRoYW5r
cywgUm9nZXIuDQo+Pj4+PiANCj4+Pj4gDQo+Pj4+IEkgaGF2ZSBvbmUgcXVlc3Rpb24gYWJvdXQg
dGhpcyBmaXguDQo+Pj4+IElmIEkgc2V0IFhFTl9ET01DVExfQ0RGX3ZwY2kgZm9yIGRvbTAgcHZo
IGluIGNyZWF0ZV9kb20wLCB0aGVuIGluDQo+Pj4+IHNhbml0aXNlX2RvbWFpbl9jb25maWcgb3Ig
YXJjaF9zYW5pdGlzZV9kb21haW5fY29uZmlnIEkgaGF2ZSBubw0KPj4+PiBrbm93bGVkZ2Ugb24g
d2hldGhlciBJIGFtIGRvbTAgb3Igbm90LiBJIGNhbiBjaGVjayBpZiBJJ20gUFZIIGJ1dCBub3Qg
aWYgZG9tMC4NCj4+Pj4gVGhpcyB3b3VsZCBiZSBuZWVkZWQgdG8gYWRkIGEgd2FybmluZyBpZiB0
aGlzIGZsYWcgaXMgc2V0IGJ1dCB3ZSBhcmUgbm90IGRvbTAgcHZoLg0KPj4+PiANCj4+Pj4gQW55
IGlkZWFzPw0KPj4+IA0KPj4+IEkndmUganVzdCByZWFsaXplZCB0aGlzIGlzIG1vcmUgd3Jvbmcg
dGhhdCBJIHRob3VnaHQuIHZQQ0kgaXMNCj4+PiBzaWduYWxlZCBvbiB4ODYgaW4geGVuX2FyY2hf
ZG9tYWluY29uZmlnLmVtdWxhdGlvbl9mbGFncywgc28NCj4+PiBpbnRyb2R1Y2luZyBhIHRvcCBs
ZXZlbCBvcHRpb24gZm9yIGl0IHdpdGhvdXQgcmVtb3ZpbmcgdGhlIGFyY2gNCj4+PiBzcGVjaWZp
YyBvbmUgaXMgd3JvbmcsIGFzIHRoZW4gb24geDg2IHdlIGhhdmUgYSBkdXBsaWNhdGVkIG9wdGlv
bi4NCj4+PiANCj4+PiBUaGVuIEknbSBhbHNvIG5vdCBzdXJlIHdoZXRoZXIgd2Ugd2FudCB0byBt
b3ZlIGl0IGZyb20NCj4+PiBlbXVsYXRpb25fZmxhZ3MsIGl0IHNlZW1zIGxpa2UgdGhlIG1vcmUg
bmF0dXJhbCBwbGFjZSBmb3IgaXQgdG8gbGl2ZQ0KPj4+IG9uIHg4Ni4NCj4+PiANCj4+PiBJZiB3
ZSByZWFsbHkgd2FudCB0byBtYWtlIHZQQ0kgYSBDREYgb3B0aW9uIHdlIG11c3QgZGVhbCB3aXRo
IHRoZQ0KPj4+IHJlbW92YWwgb2YgWEVOX1g4Nl9FTVVfVlBDSSwgb3IgZWxzZSB5b3UgY291bGQg
aW50cm9kdWNlIGFuIGFyY2gNCj4+PiBzcGVjaWZpYyBmbGFnIGZvciB2UENJIG9uIEFybS4NCj4+
IA0KPj4gRmlyc3QgaXNzdWUgdGhhdCB3ZSBoYXZlIGhlcmUgaXMgdGhhdCB0aGVyZSBpcyBubyBl
bXVsYXRpb25fZmxhZ3MgcmlnaHQgbm93IG9uIGFybS4NCj4gDQo+IFlvdSBkb24ndCBleHBsaWNp
dGx5IG5lZWQgYW4gZW11bGF0aW9uX2ZsYWdzIGZpZWxkLCB5b3UgY291bGQgYWRkIGENCj4gdWlu
dDhfdCB2cGNpIG9yIHNvbWUgc3VjaCB0byB4ZW5fYXJjaF9kb21haW5jb25maWcgZm9yIEFybSBp
ZiB5b3UNCj4gZG9uJ3QgdGhpbmsgdGhlcmUncyBhIG5lZWQgdG8gc2VsZWN0IG1vcmUgZW11bGF0
aW9uLiBUaGF0J3MgdXAgdG8gQXJtDQo+IGZvbGtzLg0KDQpPbmUgd2F5IG9yIGFuIG90aGVyIGl0
IGlzIHN0aWxsIGNoYW5naW5nIHRoZSBpbnRlcmZhY2UuDQoNCj4gDQo+PiBTbyBJIHRoaW5rIHRo
ZXJlIGFyZSAyIHNvbHV0aW9uczoNCj4+IA0KPj4gLSBpbnRyb2R1Y2UgUEhZU0NBUC4gVGhlIHBy
b2JsZW0gaGVyZSBpcyB0aGF0IGl0IGlzIG5vdCBhIHBoeXNpY2FsIGNhcGFjaXR5IGFuZA0KPj4g
SSB0aGluayB0aGF0IHdpbGwgaGl0IHVzIGluIHRoZSBmdXR1cmUgZm9yIGV4YW1wbGUgaWYgd2Ug
d2FudCB0byB1c2UgdnBjaSBmb3IgVklSVElPDQo+PiBldmVuIGlmIHRoZXJlIGlzIG5vdCBwaHlz
aWNhbCBQQ0kgb24gdGhlIHBsYXRmb3JtLg0KPiANCj4gSG0sIFBIWVNDQVAgaXMgYSBiaXQgd2Vp
cmQsIGZvciBleGFtcGxlIFhlbiBzaWduYWxzIHNoYWRvdyBwYWdpbmcNCj4gc3VwcG9ydCB1c2lu
ZyBQSFlTQ0FQIHdoaWNoIGRvZXNuJ3QgZGVwZW5kIG9uIGFueSBoYXJkd2FyZSBmZWF0dXJlLg0K
PiANCj4gSSB0aGluayB5b3UgY291bGQgc2lnbmFsIHZQQ0kgcmVnYXJkbGVzcyBvZiB3aGV0aGVy
IHRoZSB1bmRlcmx5aW5nDQo+IHBsYXRmb3JtIGhhcyBQQ0kgZGV2aWNlcyBvciBub3QsIGFzIHZQ
Q0kgaXMgcHVyZWx5IGEgc29mdHdhcmUNCj4gY29tcG9uZW50Lg0KDQpCdXQgaW4gdGhlIHg4NiBj
YXNlIHRoaXMgaXMgc29tZXRoaW5nIG5vdCBzdXBwb3J0ZWQgaW4gYWxsIGNhc2VzIGFuZCBhY3R1
YWxseSBvbmx5IGJ5IGRvbTAgcHZoLg0KU28gaGF2aW5nIHNvbWV0aGluZyBsaWtlIHRoYXQgZGVm
aW5lZCBhcyBhIFBIWVNDQVAgaXMgYSBiaXQgd2VpcmQuDQoNCj4gDQo+IFJlZ2FyZGluZyBWaXJ0
SU8sIHdvbid0IGl0IGJlIGltcGxlbWVudGVkIHVzaW5nIGlvcmVxcyBpbiB1c2VyLXNwYWNlLA0K
PiBhbmQgdGh1cyB3b24ndCBkZXBlbmQgb24gdlBDST8NCg0KWWVzIHRoYXTigJlzIGEgc29sdXRp
b24gYnV0IHlvdSBjYW4gbGlzdCB0aGVtIHRocm91Z2ggYSBQQ0kgaW50ZXJmYWNlIHRvIGxldCBh
IGd1ZXN0IGRpc2NvdmVyIHRoZW0uDQpJIGFtIG5vdCBzYXlpbmcgdGhhdCB3ZSB3aWxsIGRvIHRo
YXQgYnV0IHRoYXQgd2FzIGFuIGV4YW1wbGUgb2YgY2FzZSB3aGVyZSB3ZSBjb3VsZCB1c2UgdlBD
SSB3aXRob3V0IGhhcmR3YXJlIFBDSSBwcmVzZW50Lg0KDQo+IA0KPj4gLSBpbnRyb2R1Y2UgYW4g
ZW11bGF0aW9uIGZsYWcgb24gYXJtLiBUaGUgcHJvYmxlbSBoZXJlIGlzIHRoYXQgdGhlcmUgaXMg
bm8gZW11bGF0aW9uDQo+PiBmbGFnIHJpZ2h0IG5vdyBvbiBhcm0gc28gYWRkaW5nIHRoaXMgZmVh
dHVyZSB3aWxsIHJlcXVpcmUgYSBjaGFuZ2Ugb2YgaW50ZXJmYWNlIGluDQo+PiBhcmNoLWFybS5o
IGFuZCBpbiB4ZW4gZG9tY3RsIGludGVyZmFjZS4gQnV0IGlmIHdlIGludHJvZHVjZSBvbmUgb24g
QXJtLCBpdCB3b3VsZCBhbGxvdw0KPj4gdGhlIHRvb2xzIHRvIGNoZWNrIGlmIENERl92cGNpIGNh
biBiZSBzZXQgb3Igbm90IHdoaWNoIHdvdWxkIHNvbHZlIGN1cnJlbnQgaXNzdWVzLg0KPiANCj4g
SSdtIG5vdCBzdXJlIEkgZm9sbG93LiBJZiB3ZSBnbyB0aGUgZW11bGF0aW9uIGZsYWdzIHJvdXRl
IHRoaXMgd2lsbCBhbGwNCj4gYmUgc2V0IGluIHhlbl9hcmNoX2RvbWFpbmNvbmZpZywgYW5kIENE
Rl92cGNpIHdpbGwgY29tcGxldGVseSBnbyBhd2F5Lg0KDQpUaGlzIGlzIGEgbWlzdGFrZSBvbiBt
eSBzaWRlLiBZb3UgYXJlIHJpZ2h0IHVzaW5nIGVtdWxhdGlvbiBmbGFncyB3aWxsIHJlcXVpcmUg
dG8gcmVtb3ZlIENERl92cGNpLg0KDQo+IA0KPj4gSSB0aGluayB0aGUgc2Vjb25kIHNvbHV0aW9u
IGlzIHRoZSByaWdodCBvbmUgYnV0IGl0IGNhbm5vdCBiZSBkb25lIHNvIG5lYXIgZnJvbSB0aGUN
Cj4+IGZlYXR1cmUgZnJlZXplLg0KPj4gDQo+PiBUaGUgQ0RGIGZsYWcgYXMgaW50cm9kdWNlZCBy
aWdodCBub3cgaXMgbm90IGNyZWF0aW5nIGFueSBpc3N1ZSBhbmQgd2lsbCBiZSB1c2VkIG9uY2UN
Cj4+IHRoZSBlbXVsYXRpb24gZmxhZyB3aWxsIGJlIGludHJvZHVjZS4gV2Ugd2lsbCBiZSBhYmxl
IGF0IHRoaXMgc3RhZ2UgdG8gc2V0IHRoaXMgcHJvcGVybHkNCj4+IGFsc28gb24geDg2IChmb3Ig
ZG9tMCBwdmgpLg0KPj4gTW9yZW92ZXIga2VlcGluZyBpdCB3aWxsIGFsbG93IHRvIGNvbnRpbnVl
IHRvIG1lcmdlIHRoZSByZW1haW5pbmcgcGFydCBvZiB0aGUgUENJDQo+PiBwYXNzdGhyb3VnaCB3
aGljaCBhcmUgb3RoZXJ3aXNlIG5vdCBwb3NzaWJsZSB0byBiZSBkb25lIGFzIHRoZXkgYXJlIGRl
cGVuZGVudCBvbiB0aGlzIGZsYWcuDQo+PiANCj4+IENhbiB3ZSBhZ3JlZSBvbiBrZWVwIHRoZSBE
T01DVExfQ0RGX3ZwY2kgZmxhZyBhbmQgaW50cm9kdWNlIHRoZSBlbXVsYXRpb24NCj4+IGZsYWcg
b24gQXJtIGFmdGVyIDQuMTYgcmVsZWFzZSA/DQo+IA0KPiBJZiB2UENJIGZvciBBcm0gb24gNC4x
NiBpcyBub3QgZ29pbmcgdG8gYmUgZnVuY3Rpb25hbCwgd2h5IHNvIG11Y2gNCj4gcHJlc3N1cmUg
aW4gcHVzaGluZyB0aG9zZSBwYXRjaGVzIHNvIGZhc3Q/IEkgdW5kZXJzdGFuZCB0aGUgbmVlZCB0
bw0KPiByZW1vdmUgc3R1ZmYgZnJvbSB0aGUgcXVldWUsIGJ1dCBJIGRvbid0IHRoaW5rIGl0J3Mg
d29ydGggdGhlIGNvc3Qgb2YNCj4gaW50cm9kdWNpbmcgYSBicm9rZW4gaW50ZXJmYWNlIGRlbGli
ZXJhdGVseSBvbiBhIHJlbGVhc2UuDQoNCldlIGRpZCBub3QgcHVzaCB0aGF0IGZhc3QsIHRob3Nl
IGhhdmUgYmVlbiBvbiB0aGUgbWFpbGluZyBsaXN0IGZvciBhIHdoaWxlICh0aGlzIGlzIHRoZSA1
dGggdmVyc2lvbiBvZiB0aGUgc2VyaWUpLg0KUENJIHBhc3N0aHJvdWdoIGlzIGEgYmlnIGNoYW5n
ZSByZXF1aXJpbmcgbG90cyBvZiBwYXRjaGVzIGFuZCB3ZSBkZWNpZGVkIHRvIHB1c2ggaXQgcGll
Y2UgYnkgcGllY2UgdG8gbWFrZQ0KdGhlIHJldmlldyBlYXNpZXIuDQoNCj4gDQo+IEkgdGhpbmsg
d2UgbmVlZCB0byBhdCBsZWFzdCBzZXR0bGUgb24gd2hldGhlciB3ZSB3YW50IHRvIGtlZXANCj4g
Q0RGX3ZwY2kgb3IgdXNlIGFuIGFyY2ggc3BlY2lmaWMgc2lnbmFsIG1lY2hhbmlzbSBpbiBvcmRl
ciB0byBkZWNpZGUNCj4gd2hhdCB0byBkbyByZWdhcmRpbmcgdGhlIHJlbGVhc2UuDQoNCkFncmVl
IGFuZCBJIGhhdmUgbm8gZGVmaW5pdGl2ZSBpZGVhIG9uIHRoaXMgc28gYnV0IHN3aXRjaGluZyB3
aWxsIHJlcXVpcmUgdG8gcmV2ZXJ0IHRoZSBwYXRjaCBhZGRpbmcgQ0RGX3ZwY2kNCmFuZCBjaGFu
Z2UgdGhlIHN1YnNlcXVlbnQgcGF0Y2hlcy4NCg0KUmVnYXJkcw0KQmVydHJhbmQNCg0KPiANCj4g
VGhhbmtzLCBSb2dlci4NCg0K


From xen-devel-bounces@lists.xenproject.org Wed Oct 13 12:12:42 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 12:12:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.208324.364404 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mad7h-0004BX-QR; Wed, 13 Oct 2021 12:12:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 208324.364404; Wed, 13 Oct 2021 12:12:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mad7h-0004BQ-NJ; Wed, 13 Oct 2021 12:12:41 +0000
Received: by outflank-mailman (input) for mailman id 208324;
 Wed, 13 Oct 2021 12:12:40 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mad7g-00049q-75; Wed, 13 Oct 2021 12:12:40 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mad7g-0004B5-1g; Wed, 13 Oct 2021 12:12:40 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mad7f-0008HB-SU; Wed, 13 Oct 2021 12:12:39 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mad7f-0003uQ-S0; Wed, 13 Oct 2021 12:12:39 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=AZFXsOC9RIXkl78Tscc/sfIvzARrDoisvZm5kxgrBh0=; b=iL09CI7tpZDe1XA/9+z1uA5Hh7
	j2WgknyZ0VDpjhmBkzSgEQm2S4FkPLdCjMnOgWdcbVBOhDuAPVMNVKm3XFvfyCIDcpVHBxuvTNBwb
	r4zZ8ZmnLfo2LVA4X2owf6HkcobXYhye85JoM0bthfvaP6t/PXP6aSQt+zTF+xUqXZUY=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165487-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 165487: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=f22feb0e3b3f08b95201b258b104c45a2acef71f
X-Osstest-Versions-That:
    ovmf=ba4ae92234b1985a89b3abed221d825b8d9ef9e2
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 13 Oct 2021 12:12:39 +0000

flight 165487 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165487/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 f22feb0e3b3f08b95201b258b104c45a2acef71f
baseline version:
 ovmf                 ba4ae92234b1985a89b3abed221d825b8d9ef9e2

Last test of basis   165474  2021-10-12 06:12:32 Z    1 days
Testing same since   165487  2021-10-13 01:56:13 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Bob Morgan <bobm@nvidia.com>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   ba4ae92234..f22feb0e3b  f22feb0e3b3f08b95201b258b104c45a2acef71f -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Wed Oct 13 12:20:22 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 12:20:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.208337.364418 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1madF3-0005je-LP; Wed, 13 Oct 2021 12:20:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 208337.364418; Wed, 13 Oct 2021 12:20:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1madF3-0005jX-Ge; Wed, 13 Oct 2021 12:20:17 +0000
Received: by outflank-mailman (input) for mailman id 208337;
 Wed, 13 Oct 2021 12:20:15 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=K823=PB=arm.com=michal.orzel@srs-us1.protection.inumbo.net>)
 id 1madF1-0005jR-O9
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 12:20:15 +0000
Received: from foss.arm.com (unknown [217.140.110.172])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTP
 id f4d307e6-b2bb-408a-ba26-67017d52117f;
 Wed, 13 Oct 2021 12:20:14 +0000 (UTC)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C4AC7D6E;
 Wed, 13 Oct 2021 05:20:13 -0700 (PDT)
Received: from [10.57.25.166] (unknown [10.57.25.166])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A20263F70D;
 Wed, 13 Oct 2021 05:20:09 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f4d307e6-b2bb-408a-ba26-67017d52117f
Subject: Re: [PATCH v6] xen: Expose the PMU to the guests
To: Ian Jackson <iwj@xenproject.org>
Cc: Julien Grall <julien@xen.org>, xen-devel@lists.xenproject.org,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 Nick Rosbrook <rosbrookn@ainfosec.com>,
 Anthony PERARD <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>,
 Christian Lindig <christian.lindig@citrix.com>, David Scott
 <dave@recoil.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 bertrand.marquis@arm.com
References: <20211013074528.1396-1-michal.orzel@arm.com>
 <75e19429-49d2-c075-acb8-797c01364771@xen.org>
 <a0618ea7-3c66-bfca-20fb-62855c8791e4@arm.com>
 <24934.51672.609742.454355@mariner.uk.xensource.com>
From: Michal Orzel <michal.orzel@arm.com>
Message-ID: <ebd69458-55e9-5ee5-6f8f-1fbb6ce62175@arm.com>
Date: Wed, 13 Oct 2021 14:19:59 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <24934.51672.609742.454355@mariner.uk.xensource.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit



On 13.10.2021 13:58, Ian Jackson wrote:
> Michal Orzel writes ("Re: [PATCH v6] xen: Expose the PMU to the guests"):
>> Ok so it is the matter of adding "HVM" word into status for x86.
>> Is this something that can be done while committing?
> 
> Making changes while committing is risky because they don't get
> properly reviewed.  When I am the committer, I prefer not to do it at
> all.
> 
I fully understand but this is just adding a word "HVM".
It's ok i will push v7
> Also committers are going to be very busy now.  Please don't ask them
> to do extra work.
> 
> Thanks,
> Ian.
> 

Cheers,
Michal


From xen-devel-bounces@lists.xenproject.org Wed Oct 13 12:20:29 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 12:20:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.208338.364428 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1madFF-00065z-Rg; Wed, 13 Oct 2021 12:20:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 208338.364428; Wed, 13 Oct 2021 12:20:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1madFF-00065s-Ol; Wed, 13 Oct 2021 12:20:29 +0000
Received: by outflank-mailman (input) for mailman id 208338;
 Wed, 13 Oct 2021 12:20:28 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Kt2p=PB=arm.com=luca.fancellu@srs-us1.protection.inumbo.net>)
 id 1madFE-000649-KQ
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 12:20:28 +0000
Received: from foss.arm.com (unknown [217.140.110.172])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTP
 id 6c87281f-582c-4b85-ae17-24c6f53c5e19;
 Wed, 13 Oct 2021 12:20:27 +0000 (UTC)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6A5451FB;
 Wed, 13 Oct 2021 05:20:27 -0700 (PDT)
Received: from e125770.cambridge.arm.com (e125770.cambridge.arm.com
 [10.1.195.16])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 80BD43F70D;
 Wed, 13 Oct 2021 05:20:26 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6c87281f-582c-4b85-ae17-24c6f53c5e19
From: Luca Fancellu <luca.fancellu@arm.com>
To: xen-devel@lists.xenproject.org
Cc: bertrand.marquis@arm.com,
	wei.chen@arm.com,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: [PATCH] arm/docs: Clarify legacy DT bindings on UEFI
Date: Wed, 13 Oct 2021 13:19:29 +0100
Message-Id: <20211013121929.30784-1-luca.fancellu@arm.com>
X-Mailer: git-send-email 2.17.1

Legacy compatible strings for dom0 modules are not
supported when booting using UEFI, the documentation
doesn't mention that.

Add a phrase to docs/misc/arm/device-tree/booting.txt
to clarify it.

Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>
---
 docs/misc/arm/device-tree/booting.txt | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/docs/misc/arm/device-tree/booting.txt b/docs/misc/arm/device-tree/booting.txt
index c6a775f4e8..017c0f13eb 100644
--- a/docs/misc/arm/device-tree/booting.txt
+++ b/docs/misc/arm/device-tree/booting.txt
@@ -51,6 +51,8 @@ Each node contains the following properties:
 	Xen 4.4 supported a different set of legacy compatible strings
 	which remain supported such that systems supporting both 4.4
 	and later can use a single DTB.
+	However when booting Xen using UEFI and Device Tree, the legacy
+	compatible strings are not supported.
 
 	- "xen,multiboot-module" equivalent to "multiboot,module"
 	- "xen,linux-zimage"     equivalent to "multiboot,kernel"
-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Wed Oct 13 12:21:32 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 12:21:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.208349.364440 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1madGG-0006rI-6R; Wed, 13 Oct 2021 12:21:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 208349.364440; Wed, 13 Oct 2021 12:21:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1madGG-0006rB-2j; Wed, 13 Oct 2021 12:21:32 +0000
Received: by outflank-mailman (input) for mailman id 208349;
 Wed, 13 Oct 2021 12:21:30 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=bU9L=PB=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1madGE-0006r0-Q1
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 12:21:30 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 5c9740a5-8900-4060-b814-16501f450c43;
 Wed, 13 Oct 2021 12:21:29 +0000 (UTC)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2051.outbound.protection.outlook.com [104.47.13.51]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-25-IdhWJ55CMWK9aXVS3JGELw-1; Wed, 13 Oct 2021 14:21:27 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB5328.eurprd04.prod.outlook.com (2603:10a6:803:59::25)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18; Wed, 13 Oct
 2021 12:21:25 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.016; Wed, 13 Oct 2021
 12:21:25 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6P192CA0086.EURP192.PROD.OUTLOOK.COM (2603:10a6:209:8d::27) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4587.26 via Frontend Transport; Wed, 13 Oct 2021 12:21:23 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5c9740a5-8900-4060-b814-16501f450c43
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634127688;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=/syMxzoUxIqbyCmc8IhtwqOjBQKNvck9LFDbtkJdXQA=;
	b=lhE0Dh0WkUBqBin6hLGVVHKVSlIK0rtz5gUgHyz4h6m2fc21Ju3+Qbhe2xk92DqgmURqJQ
	1EfLn7mPeDe/XrY8r16dHyXTEZeo4bXBmZ5Rcd2dAA4XOFQBEhFMZtIrZZn8HCed2YqBhM
	71d75B5ZYM6SY1AtuztlhTZK09mY0KQ=
X-MC-Unique: IdhWJ55CMWK9aXVS3JGELw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Nv4w+qSi7g2ktbymsPj29PlrbphbKpMjhN8KE8lfdLzwPHjwu4o3OUVY3GRWU/PfLI/cjbyq/834wznP7ju4a+zk12jENeQhUkFmSFbooZR/quSxC0K0EcMOBZsjgqH0vrO+0UufCGjvRUDjNZjYL9rbH2cIcb/9JAs/QL5zOHLbTFTyaKbn6kYu08jf4Jkw3QQ/2KtLafchXwI/glV/QKJmPj8X5HA9Rx2Nsn6Vl+TctCacASDagXhr9wI3fQ2KadrCk/SSCE/4E6EtZ+8jNNGZvb8OxKLccov/ql+qRjTctPaot7lYbsGcK8RKYMxBoEbh3nv0AyIOOGhwea1k6Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=/syMxzoUxIqbyCmc8IhtwqOjBQKNvck9LFDbtkJdXQA=;
 b=LB5XJeHTNp37c8Lt8Ckhk4W0J4yJ6frmp/uiNell0rkuvaSg7+FDvjz5VCwl8MzQ4BByUmfPyc+QeTcVjal1g0Kc5/lgEdCEX4T9Kv2/fIz3F9oQjGB4Ll4QB8TEyi8PNNQOuSGFWQ7NspUpzhv5aXkw0tGjC48gvrKqAhs6LddscFf3JDXdcT5rSP6aHmVEM6Ft0ywgdr0QLaKTPaleVXeRaWs99L73iUMMkv0OZNNERFJN4mSjW4OPX9YF80mBHCb6hRnXfLyAXVA3EE0VvYDMx+p56jIR5c+mDdlKKnA9ZKeC1gxnaSZd8fmW7JEAqa1ufuy862e96WDfjiEx5g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [PATCH v5 08/11] xen/arm: Enable the existing x86 virtual PCI
 support for ARM.
To: Bertrand Marquis <Bertrand.Marquis@arm.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Rahul Singh <Rahul.Singh@arm.com>, Andre Przywara <Andre.Przywara@arm.com>,
 Julien Grall <julien@xen.org>, Volodymyr Babchuk
 <Volodymyr_Babchuk@epam.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Wei Liu <wl@xen.org>, Paul Durrant <paul@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <cover.1633540842.git.rahul.singh@arm.com>
 <9bdca2cda5d2e83f94dc2423e55714273539760a.1633540842.git.rahul.singh@arm.com>
 <6752f2d3-171b-37f5-c809-82995a8f3f36@suse.com>
 <CEF7FFB0-779A-4F46-8667-6BCD9BA5CB6C@arm.com>
 <b735c2d3-1dbb-ce0a-c2fa-160d4c6938d3@suse.com>
 <A8DEBD07-FB45-4E4E-A2C3-7AF8B393B032@arm.com>
 <59c9e102-c710-64d3-2a1a-cc8dcbcceead@suse.com>
 <alpine.DEB.2.21.2110111105180.25528@sstabellini-ThinkPad-T480s>
 <2fa4d2e2-7daf-6d52-ff4c-38a482af1fb9@suse.com>
 <alpine.DEB.2.21.2110121436020.9408@sstabellini-ThinkPad-T480s>
 <f15de716-4c4f-47b8-b6ba-ea549c61369c@suse.com>
 <DDD004E5-E8E7-485A-9FDE-298744C32DDE@arm.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <0f86ad1d-040d-230c-14cd-25f606a47bca@suse.com>
Date: Wed, 13 Oct 2021 14:21:22 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <DDD004E5-E8E7-485A-9FDE-298744C32DDE@arm.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P192CA0086.EURP192.PROD.OUTLOOK.COM
 (2603:10a6:209:8d::27) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 99e329b0-3d70-4485-9484-08d98e43f983
X-MS-TrafficTypeDiagnostic: VI1PR04MB5328:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB53280934AAE6C84FC2AC0BF7B3B79@VI1PR04MB5328.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	EFcqFeXEYCq2BIhbD6fEF0B5n7RXiu1CwUWZYMT4F7lICuRJRfYVsrjUB2vDqLeZCgNQgv5+/7TcmzoXBK63j2CBB3JG5d2zam7gCFK+BqoLDRSKTRgKpYqE815/otyQvm6EB8qFLHJkwvpWMpzuQeezpJmP6DBEtvJ3bb2fAcspCQElbFcHVFV2l+87AkiDV/WoxCrLrWkoqYOsU8HTJ9Q0XzpXCrJ9V/oWVWWP6bqye5riiCngdymAj0h4d4eB8GjdJvodwEF8RNUQxvhqO9B/3Q2dJolAXPRHSI2KCT3PBjBtJLD7y2y1+mKVF43kEx4cq2grqUf4CQCGPro7Fuc9BBs7GenfmbAo2UCKE7M6VFKwQqzqrRJ8DgortypG7bnljNXtTFUy4a2FJ/oL9/KzxmDApqIKpSLRwgB+5RvvSeeR1Kc/kkip2VsCMB4ZwKSHEX6zhToL2fy2/S4QhbyQNK3lAmh5bWGSPF9PELKOgiutCVSq2mOfCFlShA9YnIzhRACT76ZGUL4PNIqBGBk1xJEU8JCmDmmpfpo/kD+MieRjtsX4I9gtlLBBcWVD08905gKV6oMmsevqyi5N2gLPOD1pKPmIS0s2ITNE3kJAjpm7uhqh49wIgDYrTweVPUBCq6QUITg3Ymm1b78/g+L0shpaYZ2KdSlfoopaK5oK6Edk/gQl5s+FMnkmgO9P/7jJOike31JQwdKKILJsvYRvZ1NH8FDzWErTEJeuoEo=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(66476007)(66556008)(2616005)(956004)(8676002)(186003)(31696002)(7416002)(86362001)(5660300002)(31686004)(66946007)(53546011)(36756003)(26005)(8936002)(38100700002)(316002)(4326008)(6916009)(2906002)(16576012)(508600001)(6486002)(54906003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?VmVZSmRwQWxwZitYYXVSVW1wYVdyNlhmdG1yZ2JvZVFJeWdhYlB0YTMyZUQr?=
 =?utf-8?B?Y2xTYTNlUlppMVozWWdmbjNBSStZUHpwNDdiUHdCdVM0TVNhTytwQXBkQWNv?=
 =?utf-8?B?dlhIRER4MUhrQ24rVGFSNm43amc1dHFYd096K0tnMWVOb3cyMkdUUkFpZlpR?=
 =?utf-8?B?KzZNeDRvU3VPcjh3b29tM0g3OHVXSDlJdmxpbTZtNkFTUEx6aThJRG1zM3pn?=
 =?utf-8?B?SkJuMTV5cVVEWDlJblRQaFNRV0xldVg1bWNVZEQyUTJaR1lKQ29HOWw1Qlh3?=
 =?utf-8?B?VjBxeXBEWC9zU2xRZ1lzTGlqU0ZaZEtDTDRyVkxIWHNCVTBUREx0QUh2a0JT?=
 =?utf-8?B?UHZ3VUdHcmJSSW1WK1NDTDV2RXdzWU5oRzZxd1JoTmdVaXMrdE5IU3BEcEp0?=
 =?utf-8?B?Z2JadGVXYkdLSmIzL2pVa0xMcGNKVlpuc0s0Q2h6Q0YxSDhKLzVLNnlyeXYx?=
 =?utf-8?B?WGlXQU1oc1VHK2o4c1R4S2M3RUdSN1BBYkRqR095bm81dURrSUExcVYrdFFl?=
 =?utf-8?B?R2o2VW1mS2lCVGVJYU90WHlUMkQvUENwMVdvUGhSUnRmSitJdTRsRHovdVhE?=
 =?utf-8?B?TUdiSEZ6bmU1Q2krQmhETG83L3N3WllTOWdWK2YraDczcm14NlVOVW9halpm?=
 =?utf-8?B?L2NoaTh4dXhiL1R0VzdYRmZ0c2ZTcS8xM3pOc091cWEyaXpCMnZGN0dnY1F0?=
 =?utf-8?B?c3JmWVpLTjZ1ME0rSUVWT09ndlpOZ2hHL002UWUyeU9JV1pnZzRZTUszRHda?=
 =?utf-8?B?Qmg2QnA0Z2hTWjRVSzNrb2VnTWFGbmN5djdIWmoyWUpkdWJFcnhQTmhhVkNM?=
 =?utf-8?B?YkYvaFBSZk1lQXNKc0ZzZFN0MjAvdEpNNS9TQkVwU3BVaEE1TkQyenA0aEha?=
 =?utf-8?B?S1Z1RWVLa1NmV1pOT0pEMVUydklxUjJjL2FuQTNEU3dZZGlYQUpwZVVXTXFv?=
 =?utf-8?B?WENlM0ZNU1Q4TlV1bUt1Z2I2T2FuMmg3Rm9JK1oraXBBUFBNTG4vd0svV0hB?=
 =?utf-8?B?MzhQeEdFR21XTXByenM5c3RLcEorWmNvNWcyRTVSUXJDcXpSc1B6NzVNbGVz?=
 =?utf-8?B?VnpRN3FQZXpycGUzTGJ3dTBISlo0dStUWXk5cXdiY3lPd1ZQdy95ckVTRDZ5?=
 =?utf-8?B?aVBlVjdGNUphaFB3cDJUeUphdXpkbU52cHkyRHRGNVp1VUF2S2dDbGVLMi92?=
 =?utf-8?B?YUxDOUlHbVc3WVpSN1VuRm50NFlqYTJQZE1GZkZFdkdBdCt2MEprZURHY2Nv?=
 =?utf-8?B?VnAzcGJyNGtkeEhJUm56TjZsQllsRWJUR0lxR3kzVTNFdnhETmdYUmZrVHFY?=
 =?utf-8?B?VERLVHhodlQ0TVRzVGJyVzNoVGVlMXl4TFJ1dG9jYW9SaVJQZ0pLLzFQRG5S?=
 =?utf-8?B?dFpBZkV2WFFQT3QvaFZTREpGZkoxaGVMUjU4YmE5UUY5YktvZHFpUEUzdytN?=
 =?utf-8?B?NGxSMXRSdCtaOCtVOWVXK01wLzQ1cTdacE94aDdCRnRnck1NdC9IaWxZTm56?=
 =?utf-8?B?cXk3WmJxNTZqSDJ5TlZqNmdYVmpIWVRyU1RzdGZXVE5WSkxvS3pId20wY094?=
 =?utf-8?B?bWU5Wkx5SEtFMG5nbThaNld5eDhKSVNwNTVFTUNWNVcxaHF2K0dmSEx2c2Uv?=
 =?utf-8?B?YzdDa1MyN2lIMkI5cDlmMEkvM1poZnFIRFA1VE96UEkzd3VsR1NMQ1dmbkZK?=
 =?utf-8?B?WExyODE1eVJHNzVFeVljTWQ0R0EvUDBnRE9DTVZnNUlmSHpmM0ZpeTJWVDJB?=
 =?utf-8?Q?CSqHbVSLY4gIE15SzMPoFszriRlM/vl9bCpWr9l?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 99e329b0-3d70-4485-9484-08d98e43f983
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2021 12:21:25.1258
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1ayssO1JBjqnDTdfWTDD+VFhb21pHWZRSXNO8/0oMt5lU/4qIw0MCWcOapjIg8SpNoK/rQpggcTegp62PDC8Pw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5328

On 13.10.2021 12:02, Bertrand Marquis wrote:
>> On 13 Oct 2021, at 07:10, Jan Beulich <jbeulich@suse.com> wrote:
>> On 12.10.2021 23:37, Stefano Stabellini wrote:
>>> Good point about MSIs not being setup before the traps. We should remove
>>> the call to pci_cleanup_msi() in the error path then.
>>
>> Your reply makes me fear you didn't pay enough attention to the "partial"
>> in my earlier reply. The traps for the various registers can't all be set
>> up atomically, so there may be a transient period where enough traps are
>> already in place for a cunning guest to arrange for setup. Unless, as
>> said, there are further setup steps needed before a guest could succeed
>> in doing so.
>>
>> But even if partial trap setup alone was sufficient, I think the cleaning
>> up of MSI then might still better go on the error path there than on that
>> of pci_add_device().
> 
> I think I should put the msi_cleanup in the exit path if pdev is not null but
> we got a non null ret (in an else if ( pdev ) ).
> This would cover all exit paths, especially as I will move the add_handler
> before the iommu init.
> 
> Would that be ok for everyone ?

Sounds reasonable at the first glance.

Jan



From xen-devel-bounces@lists.xenproject.org Wed Oct 13 12:30:27 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 12:30:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.208360.364451 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1madOl-0008NU-1O; Wed, 13 Oct 2021 12:30:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 208360.364451; Wed, 13 Oct 2021 12:30:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1madOk-0008NN-Up; Wed, 13 Oct 2021 12:30:18 +0000
Received: by outflank-mailman (input) for mailman id 208360;
 Wed, 13 Oct 2021 12:30:17 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=iVjq=PB=citrix.com=anthony.perard@srs-us1.protection.inumbo.net>)
 id 1madOj-0008My-6W
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 12:30:17 +0000
Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 517debbe-2c21-11ec-816d-12813bfff9fa;
 Wed, 13 Oct 2021 12:30:15 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 517debbe-2c21-11ec-816d-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1634128215;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=yXmZjJWva5u9xyCcMFIPDhgpQZW0f8qL3F2nN8fTqN8=;
  b=doXXi0Ziv3M2Dh64Ymo9lzb1a/B+/AOxNlKom4tCGEOIz9VgRDKphGOn
   MuH2d7Zs7WK1nwBm6n3Z+o9D1mytiLzeCSy37rrUYdn2MtAXp1B4RJj+k
   QlTcA7Gc0eCk/TKA9tiVyhIECkwWOThsLpWqX7rNylPwfdJAiBloKzao3
   U=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: 3AoUv4QfdVr3gH5shJGdABR29/cCW2Eqiamj8IOv3MnAknhoqj6fTOPSzE/h5jUplpjCxAu4G1
 oeevbfH3EGkwVmsecwySOClbXyDKUtz0zVQsyiI3kXWMUSxModsPvMjEBTiS/856O2u7nmBr2C
 Sdbb0G+S+kQVCkr6XFaF3mBLV3QNEnYIDZ2+LQJK1fNseOYoA60IPbOx0/BNKnNNSLee5b2yBH
 auPosBlfHA9OfL+g9k04I/c33ApHKe/E4OTy/vNnlczVmTEFx9Al7ix0VbiCsiQ5fl28FZGOTW
 PJiKDXfkjHjuSpd+25lBMZ1A
X-SBRS: 5.1
X-MesageID: 54649964
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:+QbTeqy8nUrCO+mZ6sx6t+eWwSrEfRIJ4+MujC+fZmUNrF6WrkUHz
 jcWDGmDM/zfa2f8f4ojPoi39RtVuZSBmtRrGlQ/+SAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx
 59DAjUVBJlsFhcwnvopW1TYhSEUOZugH9IQM8aZfHAsLeNYYH1500s6w7di2tcAbeWRWGthh
 /uj+6UzB3f9s9JEGjp8B3Wr8U4HUFza4Vv0j3RmDRx5lAa2e0o9VfrzEZqZPXrgKrS4K8bhL
 wr1IBNVyUuCl/slIovNfr8W6STmSJaKVeSFoiI+t6RPHnGuD8H9u0o2HKN0VKtZt9mGt99b4
 4thq8GVcCMkNauVpuUPXggJNRgraMWq+JefSZS+mcmazkmAeHrw2fR+SkoxOOX0+M4uXzsIr
 6ZBbmlQMFbT3Ipaw5riIgVors0lMMnsOpJZonx6xCvVJf0nXYrCU+PB4towMDIY25wQQaePO
 ZZxhTxHbQTdPx8ROmouGb0ggdeponzfMABltwfAzUYwyzeKl1EguFT3C/LKfvSaSMMTmVyXz
 kr4+GD+DgAfJcao4zOP+XKxhcfChSr+HokVEdWQ5vNsxVGe2GEXIBkXTkeg5+m0jFakXNBSI
 FBS/TAhxYAp71CiRNT5Wxy+oVaHswQaVt4WFPc1gCmPwKfJ5weSBkAfUyVMLtchsaceRCMo/
 k+EmcvzAj5iu6HTTmiSnp+WsDezNC49PWIEIygeQmM4D8LL+d9pyEiVF5A6TfDz3oad9SzML
 y6iowIV2ZkN0Osy86iw+wn5giCht8nvd1tgjunIZV6N4gR8bY+jQoWn71nH8PpNRLqkokm9U
 GsswJfGsrhfZX2ZvGnUGr9VReD2jxqQGGSE2QYHInU3y9i6F5dPl6hr6zZiOFwhDM8AfTL4C
 KM4kVIMvMENVJdGgKkeXm5QNyjI5fS+fTgGfqqNBjarXnSXXFTYlM2JTRTBt10BaGB2zckC1
 W6zKK5A90oyB6V91yaRTOwAy7ItzS1W7TqNHsyjkUj9ieDCPyL9pVI53L2mNb9RAESs+lS9z
 jqiH5HSl0U3vBPWM0E7DrL/3XhVdCNmVPgaWuRcd/KZIxoOJY3SI6S5/F/VQKQ8x/49vr6Rp
 hmVAxYEoHKi1SyvAVjbMRhLNeKwNauTWFpmZETAy37zgCN9CWtuhY9CH6YKkU4PrbQ5k6EvF
 aVZIq1twJ1nE1z6xtjUVrGlxKQKSfhhrVPm0/ONbGdtcph+aRbO/9O4LALj+DNXVni8tNcko
 q3m3QTeGMJRSwNnBcfQSfSu01Lu4iRNxLMsBxPFcotJZUHh0Il2MCit3PU5FN4BdEfYzTyA2
 gfIXRpB/bvRo5U4+cXijLyfq9v7CPN3G0dXRjGJ7bu/OSTA0HCkxItMDLSBcTzHDTum86S+f
 +RFifr7NaRfzlpNtoN9FZdtzL4/uISz9+MLkFw8ESySPVqxC75mLn2X5uV1t/VAlu1DpA+7e
 kOT4d0Ga7+HD9zoTQwKLw0/Y+XdifxNwmvO7e44KVnR7TNs+ObVSl1bOhSBhXAPLLZxN495k
 +4ttNRPtl66gxsudN2HkjpV5yKHKXlZC/crsZQTAYnKjAs3yw4dPcyAW3GuuJzfOc9RNkQKI
 yOPgPuQjrtR8UPObn4vGCWfxuFan5kP5EhHwVJqy45lQTYZaivbBCFszAk=
IronPort-HdrOrdr: A9a23:RnbaMaM0umTQk8BcTsOjsMiBIKoaSvp037Eqv3oRdfVwSL3+qy
 nOpoV+6faaslossR0b9uxofZPwJ080lqQFhLX5X43SPzUO0VHAROoJgLcKgQeQeREWntQtrJ
 uIGJIfNDSfNzZHsfo=
X-IronPort-AV: E=Sophos;i="5.85,370,1624334400"; 
   d="scan'208";a="54649964"
Date: Wed, 13 Oct 2021 13:30:08 +0100
From: Anthony PERARD <anthony.perard@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, George Dunlap
	<george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>, Julien Grall
	<julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>, Wei Liu
	<wl@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, Roger Pau
 =?iso-8859-1?Q?Monn=E9?= <roger.pau@citrix.com>,
	<xen-devel@lists.xenproject.org>
Subject: Re: [XEN PATCH v7 21/51] build: set ALL_OBJS to main Makefile; move
 prelink.o to main Makefile
Message-ID: <YWbRUNgGX0sEHMUo@perard>
References: <20210824105038.1257926-1-anthony.perard@citrix.com>
 <20210824105038.1257926-22-anthony.perard@citrix.com>
 <304c1ddc-7bbc-e942-4c5a-8395a750b13d@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <304c1ddc-7bbc-e942-4c5a-8395a750b13d@suse.com>

On Mon, Oct 11, 2021 at 01:31:59PM +0200, Jan Beulich wrote:
> On 24.08.2021 12:50, Anthony PERARD wrote:
> > --- a/xen/Makefile
> > +++ b/xen/Makefile
> > @@ -271,8 +271,21 @@ CFLAGS += -flto
> >  LDFLAGS-$(CONFIG_CC_IS_CLANG) += -plugin LLVMgold.so
> >  endif
> >  
> > +# Note that link order matters!
> > +ALL_OBJS-y                := common/built_in.o
> > +ALL_OBJS-y                += drivers/built_in.o
> > +ALL_OBJS-y                += lib/built_in.o
> > +ALL_OBJS-y                += xsm/built_in.o
> > +ALL_OBJS-y                += arch/$(TARGET_ARCH)/built_in.o
> > +ALL_OBJS-$(CONFIG_CRYPTO) += crypto/built_in.o
> > +
> > +ALL_LIBS-y                := lib/lib.a
> > +
> >  include $(BASEDIR)/arch/$(TARGET_ARCH)/arch.mk
> >  
> > +export ALL_OBJS := $(ALL_OBJS-y)
> > +export ALL_LIBS := $(ALL_LIBS-y)
> > +
> >  # define new variables to avoid the ones defined in Config.mk
> >  export XEN_CFLAGS := $(CFLAGS)
> >  export XEN_AFLAGS := $(AFLAGS)
> > @@ -393,7 +406,7 @@ $(TARGET): FORCE
> >  	$(MAKE) -f $(BASEDIR)/Rules.mk -C include
> >  	$(MAKE) -f $(BASEDIR)/Rules.mk -C arch/$(TARGET_ARCH) include
> >  	$(MAKE) -f $(BASEDIR)/Rules.mk arch/$(TARGET_ARCH)/include/asm/asm-offsets.h
> > -	$(MAKE) -f $(BASEDIR)/Rules.mk -C arch/$(TARGET_ARCH) $@
> > +	$(MAKE) -f $(BASEDIR)/Rules.mk $@
> 
> This merely results in what was previously invoked from here now getting
> invoked from the very bottom of build.mk. I'm afraid I don't see why this
> is a useful change to make.

Would you rather have this following change?

    @@ -393,7 +406,8 @@ $(TARGET): FORCE
     	$(MAKE) -f $(BASEDIR)/Rules.mk -C include
     	$(MAKE) -f $(BASEDIR)/Rules.mk -C arch/$(TARGET_ARCH) include
     	$(MAKE) -f $(BASEDIR)/Rules.mk arch/$(TARGET_ARCH)/include/asm/asm-offsets.h
    +	$(MAKE) -f $(BASEDIR)/Rules.mk prelink.o
     	$(MAKE) -f $(BASEDIR)/Rules.mk -C arch/$(TARGET_ARCH) $@

That would probably be fine.

> > --- a/xen/build.mk
> > +++ b/xen/build.mk
> > @@ -56,3 +56,27 @@ arch/$(TARGET_ARCH)/include/asm/asm-offsets.h: asm-offsets.s
> >  	  sed -rne "/^[^#].*==>/{s:.*==>(.*)<==.*:\1:; s: [\$$#]: :; p;}"; \
> >  	  echo ""; \
> >  	  echo "#endif") <$< >$@
> > +
> > +# head.o is built by descending into arch/arm/$(TARGET_SUBARCH), depends on the
> > +# part of $(ALL_OBJS) that will eventually recurse into $(TARGET_SUBARCH)/ and
> > +# build head.o
> > +arch/arm/$(TARGET_SUBARCH)/head.o: arch/arm/built_in.o
> > +arch/arm/$(TARGET_SUBARCH)/head.o: ;
> 
> This previously lived in an Arm-specific file. Moving this here in the
> given, still Arm-specific form is imo a no-go when done alongside all
> the other good changes you're making. Is there a reason this can't go
> into xen/arch/arm/arch.mk?

This is temporary and it is removed in patch
    "build: build everything from the root dir, use obj=$subdir"
but I could move it to "arch/arm/Rules.mk" I think.

Thanks,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Wed Oct 13 12:33:03 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 12:33:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.208369.364462 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1madRO-0000e2-JL; Wed, 13 Oct 2021 12:33:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 208369.364462; Wed, 13 Oct 2021 12:33:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1madRO-0000dv-G5; Wed, 13 Oct 2021 12:33:02 +0000
Received: by outflank-mailman (input) for mailman id 208369;
 Wed, 13 Oct 2021 12:33:00 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=bU9L=PB=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1madRM-0000dn-Rb
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 12:33:00 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 800a22cd-6d00-460f-9155-fb58a41ee96d;
 Wed, 13 Oct 2021 12:32:59 +0000 (UTC)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2169.outbound.protection.outlook.com [104.47.17.169])
 (Using TLS) by relay.mimecast.com with ESMTP id
 de-mta-22-XAW3I7VUPbmS-9rt4rVLdA-1; Wed, 13 Oct 2021 14:32:58 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB3119.eurprd04.prod.outlook.com (2603:10a6:802:10::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18; Wed, 13 Oct
 2021 12:32:57 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.016; Wed, 13 Oct 2021
 12:32:56 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 FR3P281CA0024.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1c::15) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.4 via Frontend Transport; Wed, 13 Oct 2021 12:32:56 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 800a22cd-6d00-460f-9155-fb58a41ee96d
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634128378;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=6LcfsVzGfqweLmR9KasgBs8D6g6eEOMQesVKB7VTk9o=;
	b=DpaXAO8RSrf5UkcpbiSygcdb6NBGv6FvDT2ZCd+o00Ax2lacvBSedh7JEQPYCCt5oYHviH
	Or+F+DCccM9xxUk3xki45qOIvPbhKfG7OAR3M5utE/zpS2qNtXqKkTJaDgrCh6ylNz71Gj
	w5j/VNmiSYY6U6cLGKyZfPTbM6IxHyU=
X-MC-Unique: XAW3I7VUPbmS-9rt4rVLdA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=AZOgNkKz9GLZnsTqwQt5wBXwsYgvLgaS5VEGHPpm0Xg0ZYCdBNvSrTEWs2CEOELTJIxxjn6tIQvNDcugpTLP6ldqnTm/+R4A5ONxDuICbhT/rYItxXGRVIkkSd5QSapfHxxMk69YUbZF3fEXdLOlGlh0Bz7Pr6fzK/Ntgpk2UclNJtGCYgTHAlMP5ema7pNo8YmXGTv0PwcSRNIMKQJ67L20KZwVuqUq0B35uQUTlLk4jK7emm85a7y2c7VfbJIpdEz/X8K2YvHbwTQAzAulrXhYOFXGd4GfGK3jmR5x2wvfYn9hbaogFWwVTo3Vu+UkUbVJuAgv9qIHuOyG5ZaX1w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=6LcfsVzGfqweLmR9KasgBs8D6g6eEOMQesVKB7VTk9o=;
 b=GG2WCIied82y6nZPh1CRurNn9Q5eYNF0OSbTjPzTzON5Dtb9tZxo9JBTuzmncBDpbn4rn6GUzTpK/cFA3QtOqCkDRPcFGszfXaGTgVDv6MtaD8z83EOhNw1oaYpnpiG/waJ9Eh/XC4vWAvVLKSG5YvXVsZqtKKrr4e7isw6gyApyDjYHc399jh0cPxhRchqaDHc54FG3n675U1cuzwv3S0NRLYKmKEMmCBsdAZN4LCrfALMSz5itGJqdS12QFFQdL7IVNA0/E4yMcnVXxSo55758u9mj3NBPeJfVxF89/oUciZUtOXbzZBIPKMKvOMt0+LDC8G5HT3c3ZYJPGEzgrA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [XEN PATCH v7 22/51] build: clean common temporary files from
 root makefile
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>, xen-devel@lists.xenproject.org
References: <20210824105038.1257926-1-anthony.perard@citrix.com>
 <20210824105038.1257926-23-anthony.perard@citrix.com>
 <dd760c79-e761-3547-726a-4d7ee092d10f@suse.com> <YWa2neA0zQSvkqn2@perard>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <16d19699-8ebb-9352-dff5-83147aee9ffc@suse.com>
Date: Wed, 13 Oct 2021 14:32:55 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <YWa2neA0zQSvkqn2@perard>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR3P281CA0024.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:1c::15) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: a65caf90-c3e2-467a-6375-08d98e4595e1
X-MS-TrafficTypeDiagnostic: VI1PR04MB3119:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB3119D872CC0C4448EF517FA2B3B79@VI1PR04MB3119.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7219;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	i2nYws1oUdkPu3fYTZTeQn+IzRLj3VmLl6Zta1OrGSG3YGfVpUaseeIchNJPh0gOg2262Jyk22K+HGAsYq37kGjGzttj1CznWpe7+WEGyCQe0VYq/JojBuCpyhYKqYHR/Cg+W3UXVNkIqcq374R/fVw+Bp+q84BCwmqsIsHceQmm+gqz1iioRvvDMsgTHiZYUywIRpVgTPB6A0FJ90cWotRfXeJJ11yLgDWUO1WE8qac9m3rsOQpaex7PYP0knQxoMZsqhPwmvxUjVvK97/YKhxATmYMKncO2WZc5VCY8nh66sd5WYcibnYwP6aV1X8Z4WKdAkgMq0wHV96iLzfsP0Dc/GqLW3BTwkps6ZwENKvcXS1GaJTrwUauf008p6zO3r2fVIeOyu0PPu6Gvo3r/5ZyUkIPGsaP2rdggLbq5Wg7sPnRGX+wFItApTgBkWjQmf4RjD96HUfcU38WC4/GuchR7gTv3rvgeeemh2OuSz2NMcLOMWUsSaYZZM3rskTm2cCHX8XjwtFsZ8ykCul+Nu30WOO6/FLxo7GGXj0wALE0BGa2BASAlO1EE1r0jR34ZF1+51IZJeukNOII8EAGYemyDyLuYN1IvUHycZ++7V1frhdibVt20TK52hXQT3oJ//votoLVM9KMZHMJaQeK6D9jq0vR0NYoF3rgLyXQ3jlGKa6mow1TzE9nIutDwaprcvCVz8fk6kQq03wF9+PN155LRl6TXLDKybjUDrE3YgI=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(31696002)(83380400001)(38100700002)(86362001)(6486002)(316002)(8936002)(54906003)(16576012)(31686004)(66476007)(6916009)(36756003)(4326008)(2906002)(5660300002)(508600001)(66556008)(26005)(66946007)(8676002)(53546011)(2616005)(186003)(956004)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?OFZwSkV6ZGx1Y29nN0RYWHhPS0V4SEcxM1NCV0lMNGtWbTVnTnJEdVQ2TXdY?=
 =?utf-8?B?WExVMmIxUjd6b1c0V3Y1NlRXU2x4WTFjUllxcGh3VTZnZmkzS2s4YmIvNGhR?=
 =?utf-8?B?M3B0V2tORG1HR3ZtYVM5TUs5cGlCeXNQSk5veEl3Wm13Y05wOFhvb0I0Mno1?=
 =?utf-8?B?YVg2K3VsOU9teGczR3NSYXVaOGc1enBDaC9qcG53RUZTUlFaazRtNXJkWE52?=
 =?utf-8?B?L2gwR0hFWXJNWmM5cU10SXgrbWRRQzM2QWM4RW9Oamc2MU5hUnVyRTFKQVRH?=
 =?utf-8?B?Wm9zeGxqL2M1aU0zVVJLWjJObno1N25wbGJKeDAzdE9QOG5UZ2FHcFpPSENE?=
 =?utf-8?B?YWVHaDRIbFN5Y0V5WVFmYUR6QWo2ZGJPUHJjKzB5TlE1NHZxdUhQaUk1ZmJx?=
 =?utf-8?B?ckw2ZVVPL0lJUkNJSHVPT2s5TEdCRzlkbG9ZTjh1S2lNd244RzNmek55cGVQ?=
 =?utf-8?B?eDdYeTFYWU92RzB6N3cyZmhXTXRtblVvVzM0eUhzS2Z1STZVOWlQTkxDZXdB?=
 =?utf-8?B?R2JvU3BBbjUwNUlTRUgyTXdOYWZWZU9nMG14aUtpOWRDUTRaOFgzWm44a25n?=
 =?utf-8?B?ai94Wko5d2FPRmxHY2lHdzVjWTFicnJmT0Vsbk1HMGNKK0FVNFRGSWZwV1A2?=
 =?utf-8?B?TW5qUmNGaFFTTk5uL2dja3dzQm1EV1oyb3EvV0loeDJqd2ZrUzFBOXhiOTZS?=
 =?utf-8?B?am1rM1hBYWFSbFowaWRObnRaOGwvYVJld2lMTHM2dnlTU21iU1NPcEFxWVRk?=
 =?utf-8?B?c2tyeGJiU1paVlU3cXJHN0tqRmlSV05kemxqaTB4SllMWVR2bmYzNXdiU3lT?=
 =?utf-8?B?S3d1UmlHMFZ5SG5yVVZVN093RmRXbXVPR2ZsQzI2Tk5Sak1VOFZrLzFRZlNB?=
 =?utf-8?B?OCttcVphdWdPVkg3VENqdXVyZ1pidWZoMVpEQVZNNzUvM1hxTXU0Zms3bVNx?=
 =?utf-8?B?NUR2d21hQ0M4MWJmR1BOckxIbGJzRGpBTlB0S0VMUDBIR214YUFqQzlNYmIv?=
 =?utf-8?B?REZ5OHp4SStTYVFiQUlMenBuWjQyNkFEVy9mOUxYdEhOZTJjQzhxVnJwMDlB?=
 =?utf-8?B?aWk0bzhGUDVEa29MeVhURktWazFWVFhheHVUTTlMYlg0d2dmaHpzSjIyUWs5?=
 =?utf-8?B?SnVjcEJlNlRiUWoyT3lEWHVSSldOSVFPQ0pYcEIwYytoL1RrZmg5MmpPclNp?=
 =?utf-8?B?S1NIZ2V6UitHekJTMGsyWXE4WWt6aG9zRStDSjVRK0VMK2FHT1ZvV3owd3VS?=
 =?utf-8?B?L0NJSzVaVmRHQlhiSndCdE1PZjlVWGlubnFHTXlCZWRpcWc1cFBLVmZIVk13?=
 =?utf-8?B?Vmg0L3JqV3pjQkVkREdxY0VaaXRJQkt0cVIwQ3F5NGVlNHdxdXhCOHljcm1v?=
 =?utf-8?B?UllUSUluUlh1WDB0RSs2OWRHQk5YVkFEY01tYy9MOXo0RWpRY1kxNlprR3B1?=
 =?utf-8?B?K0MzY2svcnluM2NoY0taSnVoVk9ZL1J3RWJyK0tHU1NrMERoQVBtQUNJR0py?=
 =?utf-8?B?Ulo3T01UQVpNMEcybkJkWFlyMHkrc0lTL3FBN3oyRzJ3aHdDMFFaMlhHaDJM?=
 =?utf-8?B?cHhNYlQrNFFLbFhEeWMzMEM5b1hnK1FFVjNobkxhKzVRbWNGUGVaUjlSRUlG?=
 =?utf-8?B?Wk9yTndKVG1sdmx4cUlEUU5MajBYMTFVZUg0L24va2Y5TUdRSFVsUkxGQ2JL?=
 =?utf-8?B?ZFowKzNGd3pKWWNpbGNZUEVpZVdwRTZqdmtibld0WVh6c1grOGIrajE2RWt0?=
 =?utf-8?Q?7dpqhbJiAN4c1UvfTViz2VQEPUG5gpyhfrpP6a8?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a65caf90-c3e2-467a-6375-08d98e4595e1
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2021 12:32:56.9448
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: LzJ8EiltrmFwKwEj4yB9ZF7idcHxPcHJ43LthJZzjq5nj60vldIXX7lGjMbnafh3MG+gfH3Kjut/mHkWwIOOlw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB3119

On 13.10.2021 12:36, Anthony PERARD wrote:
> On Mon, Oct 11, 2021 at 01:41:16PM +0200, Jan Beulich wrote:
>> On 24.08.2021 12:50, Anthony PERARD wrote:
>>> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
>>
>> Trying to synthesize a description:
>>
>>> --- a/xen/Makefile
>>> +++ b/xen/Makefile
>>> @@ -382,6 +382,7 @@ _clean:
>>>  	$(MAKE) $(clean) test
>>>  	$(MAKE) $(kconfig) clean
>>>  	find . \( -name "*.o" -o -name ".*.d" -o -name ".*.d2" \
>>
>> This was effectively redundant with ...
>>
>>> +		-o -name ".*.o.tmp" -o -name "*~" -o -name "core" \
>>>  		-o -name "*.gcno" -o -name ".*.cmd" -o -name "lib.a" \) -exec rm -f {} \;
>>>  	rm -f include/asm $(TARGET) $(TARGET).gz $(TARGET).efi $(TARGET).efi.map $(TARGET)-syms $(TARGET)-syms.map *~ core
>>>  	rm -f asm-offsets.s arch/*/include/asm/asm-offsets.h
>>> diff --git a/xen/scripts/Makefile.clean b/xen/scripts/Makefile.clean
>>> index 027c200c0efc..b6df9e861e6e 100644
>>> --- a/xen/scripts/Makefile.clean
>>> +++ b/xen/scripts/Makefile.clean
>>> @@ -14,10 +14,8 @@ include Makefile
>>>  subdir-all := $(subdir-y) $(subdir-n) $(subdir-) \
>>>                $(patsubst %/,%, $(filter %/, $(obj-y) $(obj-n) $(obj-)))
>>>  
>>> -DEPS_RM = $(DEPS) $(DEPS_INCLUDE)
>>
>> ... this and its use below.
>>
>>>  .PHONY: clean
>>>  clean:: $(subdir-all)
>>> -	rm -f *.o .*.o.tmp *~ core $(DEPS_RM)
>>
>> With the command gone, I think the :: should also be converted (back) to
>> just : then. Then
> 
> "clean" has been a double-column rule for a long time. If we convert
> this rule to a single-column we need to convert all "clean" target to
> use single-column which would make this patch more complicated. So I
> don't think we should make this change.

Hmm, indeed make would complain in that case (I didn't mean to suggest
to convert all clean-s to single-colon rules, but I was instead under
the wrong impression that spelling out merely dependencies would be
okay with single-colon rule). But then make's doc also says "Each
double-colon rule should specify a recipe; if it does not, an implicit
rule will be used if one applies." So perhaps, to avoid depending on
the latter, an empty recipe should be added here (by adding a
semicolon)?

>> Reviewed-by: Jan Beulich <jbeulich@suse.com>
>>
>> Assuming the patch is independent of the earlier still uncommitted ones
>> (please confirm), I'd be happy to make the adjustment while committing
>> - as long as you agree, of course.
> 
> The patch is independent of earlier one, although the context is changed
> in one patch so wouldn't apply cleaning without git helps.
> (context is changed in "xen: move include/asm-* to arch/*/include/asm")

That would be easy enough to adjust, I guess. But first we need to settle
on the above.

Jan



From xen-devel-bounces@lists.xenproject.org Wed Oct 13 12:34:19 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 12:34:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.208375.364472 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1madSb-0001EO-Tj; Wed, 13 Oct 2021 12:34:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 208375.364472; Wed, 13 Oct 2021 12:34:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1madSb-0001EH-Ql; Wed, 13 Oct 2021 12:34:17 +0000
Received: by outflank-mailman (input) for mailman id 208375;
 Wed, 13 Oct 2021 12:34:15 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=K823=PB=arm.com=michal.orzel@srs-us1.protection.inumbo.net>)
 id 1madSZ-0001E5-Sa
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 12:34:15 +0000
Received: from foss.arm.com (unknown [217.140.110.172])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTP
 id df5d87ac-2c21-11ec-816d-12813bfff9fa;
 Wed, 13 Oct 2021 12:34:13 +0000 (UTC)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6DEB61FB;
 Wed, 13 Oct 2021 05:34:13 -0700 (PDT)
Received: from e123311-lin.arm.com (unknown [10.57.25.166])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7DF8A3F70D;
 Wed, 13 Oct 2021 05:34:08 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: df5d87ac-2c21-11ec-816d-12813bfff9fa
From: Michal Orzel <michal.orzel@arm.com>
To: xen-devel@lists.xenproject.org
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Ian Jackson <iwj@xenproject.org>,
	Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wl@xen.org>,
	Nick Rosbrook <rosbrookn@ainfosec.com>,
	Anthony PERARD <anthony.perard@citrix.com>,
	Juergen Gross <jgross@suse.com>,
	Christian Lindig <christian.lindig@citrix.com>,
	David Scott <dave@recoil.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	bertrand.marquis@arm.com
Subject: [PATCH v7] xen: Expose the PMU to the guests
Date: Wed, 13 Oct 2021 14:33:52 +0200
Message-Id: <20211013123352.6625-1-michal.orzel@arm.com>
X-Mailer: git-send-email 2.29.0
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Add parameter vpmu to xl domain configuration syntax
to enable the access to PMU registers by disabling
the PMU traps(currently only for ARM).

The current status is that the PMU registers are not
virtualized and the physical registers are directly
accessible when this parameter is enabled. There is no
interrupt support and Xen will not save/restore the
register values on context switches.

According to Arm Arm, section D7.1:
"The Performance Monitors Extension is common
to AArch64 operation and AArch32 operation."
That means we have an ensurance that if PMU is
present in one exception state, it must also be
present in the other.

Please note that this feature is experimental.

Signed-off-by: Michal Orzel <michal.orzel@arm.com>
Signed-off-by: Julien Grall <julien@xen.org>
Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>
Acked-by: Anthony PERARD <anthony.perard@citrix.com>
Acked-by: Ian Jackson <iwj@xenproject.org>
---
Changes since v6:
-fix missing "HVM" for vPMU entry in SUPPORT.md
Changes since v5:
-extracted from the series as other patches have been merged
-fold ARM vPMU feature status into existing section for x86
-fix coding style in libxl
Changes since v4:
-update SUPPORT.md
-move vpmu_is_available assignment after the secondary
CPUs have been brought up
-introduce masks for flags that need to be set and
for flags that are optional
Changes since v3:
-fail if vpmu is set but not supported
Changes since v2:
-remove redundant check from x86 code
-do not define bit position and mask separately
Changes since v1:
-modify vpmu parameter to be common rather than arch specific
---
 SUPPORT.md                           | 14 +++++++++++---
 docs/man/xl.cfg.5.pod.in             | 17 +++++++++++++++++
 tools/golang/xenlight/helpers.gen.go |  6 ++++++
 tools/golang/xenlight/types.gen.go   |  1 +
 tools/include/libxl.h                |  6 ++++++
 tools/libs/light/libxl_create.c      | 10 ++++++++++
 tools/libs/light/libxl_types.idl     |  2 ++
 tools/ocaml/libs/xc/xenctrl.ml       |  1 +
 tools/ocaml/libs/xc/xenctrl.mli      |  1 +
 tools/xl/xl_parse.c                  |  2 ++
 xen/arch/arm/domain.c                | 13 ++++++++++---
 xen/arch/arm/setup.c                 |  3 +++
 xen/common/domain.c                  | 10 +++++++++-
 xen/include/asm-arm/domain.h         |  1 +
 xen/include/public/domctl.h          |  4 +++-
 15 files changed, 83 insertions(+), 8 deletions(-)

diff --git a/SUPPORT.md b/SUPPORT.md
index 317392d8f3..3a34933c89 100644
--- a/SUPPORT.md
+++ b/SUPPORT.md
@@ -671,11 +671,19 @@ such as KVM, Hyper-V, Bromium, and so on as guests.
 
 ### vPMU
 
-Virtual Performance Management Unit for HVM guests
+Virtual Performance Management Unit
 
-    Status, x86: Supported, Not security supported
+    Status, x86 HVM: Supported, Not security supported
+    Status, ARM: Experimental
+
+On ARM, support for accessing PMU registers from the guests.
+There is no interrupt support and Xen will not save/restore
+the register values on context switches.
+
+Disabled by default.
+On ARM, enable with guest parameter.
+On x86, enable with hypervisor command line option.
 
-Disabled by default (enable with hypervisor command line option).
 This feature is not security supported: see https://xenbits.xen.org/xsa/advisory-163.html
 
 ### Argo: Inter-domain message delivery by hypercall
diff --git a/docs/man/xl.cfg.5.pod.in b/docs/man/xl.cfg.5.pod.in
index 4b1e3028d2..55c4881205 100644
--- a/docs/man/xl.cfg.5.pod.in
+++ b/docs/man/xl.cfg.5.pod.in
@@ -690,6 +690,23 @@ default.
 B<NOTE>: Acceptable values are platform specific.  For Intel Processor
 Trace, this value must be a power of 2 between 4k and 16M.
 
+=item B<vpmu=BOOLEAN>
+
+Currently ARM only.
+
+Specifies whether to enable the access to PMU registers by disabling
+the PMU traps.
+
+The PMU registers are not virtualized and the physical registers are directly
+accessible when this parameter is enabled. There is no interrupt support and
+Xen will not save/restore the register values on context switches.
+
+vPMU, by design and purpose, exposes system level performance
+information to the guest. Only to be used by sufficiently privileged
+domains. This feature is currently in experimental state.
+
+If this option is not specified then it will default to B<false>.
+
 =back
 
 =head2 Devices
diff --git a/tools/golang/xenlight/helpers.gen.go b/tools/golang/xenlight/helpers.gen.go
index c8669837d8..2449580bad 100644
--- a/tools/golang/xenlight/helpers.gen.go
+++ b/tools/golang/xenlight/helpers.gen.go
@@ -1119,6 +1119,9 @@ return fmt.Errorf("converting field ArchX86.MsrRelaxed: %v", err)
 }
 x.Altp2M = Altp2MMode(xc.altp2m)
 x.VmtraceBufKb = int(xc.vmtrace_buf_kb)
+if err := x.Vpmu.fromC(&xc.vpmu);err != nil {
+return fmt.Errorf("converting field Vpmu: %v", err)
+}
 
  return nil}
 
@@ -1600,6 +1603,9 @@ return fmt.Errorf("converting field ArchX86.MsrRelaxed: %v", err)
 }
 xc.altp2m = C.libxl_altp2m_mode(x.Altp2M)
 xc.vmtrace_buf_kb = C.int(x.VmtraceBufKb)
+if err := x.Vpmu.toC(&xc.vpmu); err != nil {
+return fmt.Errorf("converting field Vpmu: %v", err)
+}
 
  return nil
  }
diff --git a/tools/golang/xenlight/types.gen.go b/tools/golang/xenlight/types.gen.go
index 45f2cba3d2..b2e8bd1a85 100644
--- a/tools/golang/xenlight/types.gen.go
+++ b/tools/golang/xenlight/types.gen.go
@@ -521,6 +521,7 @@ MsrRelaxed Defbool
 }
 Altp2M Altp2MMode
 VmtraceBufKb int
+Vpmu Defbool
 }
 
 type DomainBuildInfoTypeUnion interface {
diff --git a/tools/include/libxl.h b/tools/include/libxl.h
index ec5e3badae..ee73eb06f1 100644
--- a/tools/include/libxl.h
+++ b/tools/include/libxl.h
@@ -508,6 +508,12 @@
  */
 #define LIBXL_HAVE_PHYSINFO_CAP_VPMU 1
 
+/*
+ * LIBXL_HAVE_VPMU indicates that libxl_domain_build_info has a vpmu parameter,
+ * which allows to enable the access to PMU registers.
+ */
+#define LIBXL_HAVE_VPMU 1
+
 /*
  * libxl ABI compatibility
  *
diff --git a/tools/libs/light/libxl_create.c b/tools/libs/light/libxl_create.c
index e356b2106d..6ebb2bfc76 100644
--- a/tools/libs/light/libxl_create.c
+++ b/tools/libs/light/libxl_create.c
@@ -91,6 +91,7 @@ int libxl__domain_build_info_setdefault(libxl__gc *gc,
     }
 
     libxl_defbool_setdefault(&b_info->device_model_stubdomain, false);
+    libxl_defbool_setdefault(&b_info->vpmu, false);
 
     if (libxl_defbool_val(b_info->device_model_stubdomain) &&
         !b_info->device_model_ssidref)
@@ -622,6 +623,9 @@ int libxl__domain_make(libxl__gc *gc, libxl_domain_config *d_config,
                 create.flags |= XEN_DOMCTL_CDF_nested_virt;
         }
 
+        if (libxl_defbool_val(b_info->vpmu))
+            create.flags |= XEN_DOMCTL_CDF_vpmu;
+
         assert(info->passthrough != LIBXL_PASSTHROUGH_DEFAULT);
         LOG(DETAIL, "passthrough: %s",
             libxl_passthrough_to_string(info->passthrough));
@@ -1199,6 +1203,12 @@ int libxl__domain_config_setdefault(libxl__gc *gc,
         goto error_out;
     }
 
+    if (libxl_defbool_val(d_config->b_info.vpmu) && !physinfo.cap_vpmu) {
+        ret = ERROR_INVAL;
+        LOGD(ERROR, domid, "vPMU not supported on this platform");
+        goto error_out;
+    }
+
     ret = 0;
  error_out:
     return ret;
diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_types.idl
index 993e83acca..b96fb5c47e 100644
--- a/tools/libs/light/libxl_types.idl
+++ b/tools/libs/light/libxl_types.idl
@@ -655,6 +655,8 @@ libxl_domain_build_info = Struct("domain_build_info",[
     # Use zero value to disable this feature.
     ("vmtrace_buf_kb", integer),
 
+    ("vpmu", libxl_defbool),
+
     ], dir=DIR_IN,
        copy_deprecated_fn="libxl__domain_build_info_copy_deprecated",
 )
diff --git a/tools/ocaml/libs/xc/xenctrl.ml b/tools/ocaml/libs/xc/xenctrl.ml
index 7a4030a192..86758babb3 100644
--- a/tools/ocaml/libs/xc/xenctrl.ml
+++ b/tools/ocaml/libs/xc/xenctrl.ml
@@ -70,6 +70,7 @@ type domain_create_flag =
 	| CDF_IOMMU
 	| CDF_NESTED_VIRT
 	| CDF_VPCI
+	| CDF_VPMU
 
 type domain_create_iommu_opts =
 	| IOMMU_NO_SHAREPT
diff --git a/tools/ocaml/libs/xc/xenctrl.mli b/tools/ocaml/libs/xc/xenctrl.mli
index 6900513e7f..0fdb0cc169 100644
--- a/tools/ocaml/libs/xc/xenctrl.mli
+++ b/tools/ocaml/libs/xc/xenctrl.mli
@@ -63,6 +63,7 @@ type domain_create_flag =
   | CDF_IOMMU
   | CDF_NESTED_VIRT
   | CDF_VPCI
+  | CDF_VPMU
 
 type domain_create_iommu_opts =
   | IOMMU_NO_SHAREPT
diff --git a/tools/xl/xl_parse.c b/tools/xl/xl_parse.c
index 17dddb4cd5..c503b9be00 100644
--- a/tools/xl/xl_parse.c
+++ b/tools/xl/xl_parse.c
@@ -2750,6 +2750,8 @@ skip_usbdev:
                     "If it fixes an issue you are having please report to "
                     "xen-devel@lists.xenproject.org.\n");
 
+    xlu_cfg_get_defbool(config, "vpmu", &b_info->vpmu, 0);
+
     xlu_cfg_destroy(config);
 }
 
diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
index aae4472479..ad21c9b950 100644
--- a/xen/arch/arm/domain.c
+++ b/xen/arch/arm/domain.c
@@ -276,6 +276,8 @@ static void ctxt_switch_to(struct vcpu *n)
      * timer. The interrupt needs to be injected into the guest. */
     WRITE_SYSREG(n->arch.cntkctl, CNTKCTL_EL1);
     virt_timer_restore(n);
+
+    WRITE_SYSREG(n->arch.mdcr_el2, MDCR_EL2);
 }
 
 /* Update per-VCPU guest runstate shared memory area (if registered). */
@@ -586,6 +588,10 @@ int arch_vcpu_create(struct vcpu *v)
 
     v->arch.hcr_el2 = get_default_hcr_flags();
 
+    v->arch.mdcr_el2 = HDCR_TDRA | HDCR_TDOSA | HDCR_TDA;
+    if ( !(v->domain->options & XEN_DOMCTL_CDF_vpmu) )
+        v->arch.mdcr_el2 |= HDCR_TPM | HDCR_TPMCR;
+
     if ( (rc = vcpu_vgic_init(v)) != 0 )
         goto fail;
 
@@ -621,10 +627,11 @@ void vcpu_switch_to_aarch64_mode(struct vcpu *v)
 int arch_sanitise_domain_config(struct xen_domctl_createdomain *config)
 {
     unsigned int max_vcpus;
+    unsigned int flags_required = (XEN_DOMCTL_CDF_hvm | XEN_DOMCTL_CDF_hap);
+    unsigned int flags_optional = (XEN_DOMCTL_CDF_iommu | XEN_DOMCTL_CDF_vpci |
+                                   XEN_DOMCTL_CDF_vpmu);
 
-    /* HVM and HAP must be set. IOMMU and VPCI may or may not be */
-    if ( (config->flags & ~XEN_DOMCTL_CDF_iommu & ~XEN_DOMCTL_CDF_vpci) !=
-         (XEN_DOMCTL_CDF_hvm | XEN_DOMCTL_CDF_hap) )
+    if ( (config->flags & ~flags_optional) != flags_required )
     {
         dprintk(XENLOG_INFO, "Unsupported configuration %#x\n",
                 config->flags);
diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c
index 49dc90d198..d5d0792ed4 100644
--- a/xen/arch/arm/setup.c
+++ b/xen/arch/arm/setup.c
@@ -999,6 +999,9 @@ void __init start_xen(unsigned long boot_phys_offset,
     printk("Brought up %ld CPUs\n", (long)num_online_cpus());
     /* TODO: smp_cpus_done(); */
 
+    /* This should be done in a vpmu driver but we do not have one yet. */
+    vpmu_is_available = cpu_has_pmu;
+
     /*
      * The IOMMU subsystem must be initialized before P2M as we need
      * to gather requirements regarding the maximum IPA bits supported by
diff --git a/xen/common/domain.c b/xen/common/domain.c
index 262b6c0c3c..8543fb54fd 100644
--- a/xen/common/domain.c
+++ b/xen/common/domain.c
@@ -480,12 +480,14 @@ static int sanitise_domain_config(struct xen_domctl_createdomain *config)
     bool hvm = config->flags & XEN_DOMCTL_CDF_hvm;
     bool hap = config->flags & XEN_DOMCTL_CDF_hap;
     bool iommu = config->flags & XEN_DOMCTL_CDF_iommu;
+    bool vpmu = config->flags & XEN_DOMCTL_CDF_vpmu;
 
     if ( config->flags &
          ~(XEN_DOMCTL_CDF_hvm | XEN_DOMCTL_CDF_hap |
            XEN_DOMCTL_CDF_s3_integrity | XEN_DOMCTL_CDF_oos_off |
            XEN_DOMCTL_CDF_xs_domain | XEN_DOMCTL_CDF_iommu |
-           XEN_DOMCTL_CDF_nested_virt | XEN_DOMCTL_CDF_vpci) )
+           XEN_DOMCTL_CDF_nested_virt | XEN_DOMCTL_CDF_vpci |
+           XEN_DOMCTL_CDF_vpmu) )
     {
         dprintk(XENLOG_INFO, "Unknown CDF flags %#x\n", config->flags);
         return -EINVAL;
@@ -534,6 +536,12 @@ static int sanitise_domain_config(struct xen_domctl_createdomain *config)
         return -EINVAL;
     }
 
+    if ( vpmu && !vpmu_is_available )
+    {
+        dprintk(XENLOG_INFO, "vpmu requested but cannot be enabled this way\n");
+        return -EINVAL;
+    }
+
     return arch_sanitise_domain_config(config);
 }
 
diff --git a/xen/include/asm-arm/domain.h b/xen/include/asm-arm/domain.h
index c9277b5c6d..14e575288f 100644
--- a/xen/include/asm-arm/domain.h
+++ b/xen/include/asm-arm/domain.h
@@ -166,6 +166,7 @@ struct arch_vcpu
 
     /* HYP configuration */
     register_t hcr_el2;
+    register_t mdcr_el2;
 
     uint32_t teecr, teehbr; /* ThumbEE, 32-bit guests only */
 #ifdef CONFIG_ARM_32
diff --git a/xen/include/public/domctl.h b/xen/include/public/domctl.h
index 4cb3f662c2..a53cbd16f4 100644
--- a/xen/include/public/domctl.h
+++ b/xen/include/public/domctl.h
@@ -71,9 +71,11 @@ struct xen_domctl_createdomain {
 #define _XEN_DOMCTL_CDF_nested_virt   6
 #define XEN_DOMCTL_CDF_nested_virt    (1U << _XEN_DOMCTL_CDF_nested_virt)
 #define XEN_DOMCTL_CDF_vpci           (1U << 7)
+/* Should we expose the vPMU to the guest? */
+#define XEN_DOMCTL_CDF_vpmu           (1U << 8)
 
 /* Max XEN_DOMCTL_CDF_* constant.  Used for ABI checking. */
-#define XEN_DOMCTL_CDF_MAX XEN_DOMCTL_CDF_vpci
+#define XEN_DOMCTL_CDF_MAX XEN_DOMCTL_CDF_vpmu
 
     uint32_t flags;
 
-- 
2.29.0



From xen-devel-bounces@lists.xenproject.org Wed Oct 13 12:35:25 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 12:35:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.208382.364484 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1madTf-0001rM-7P; Wed, 13 Oct 2021 12:35:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 208382.364484; Wed, 13 Oct 2021 12:35:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1madTf-0001rF-4U; Wed, 13 Oct 2021 12:35:23 +0000
Received: by outflank-mailman (input) for mailman id 208382;
 Wed, 13 Oct 2021 12:35:22 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=bU9L=PB=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1madTe-0001r7-6V
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 12:35:22 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 0722c2a0-2c22-11ec-816d-12813bfff9fa;
 Wed, 13 Oct 2021 12:35:20 +0000 (UTC)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2107.outbound.protection.outlook.com [104.47.18.107])
 (Using TLS) by relay.mimecast.com with ESMTP id
 de-mta-15-X1IE8JBHO-ejKUAP8P32jg-1; Wed, 13 Oct 2021 14:35:18 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB4349.eurprd04.prod.outlook.com (2603:10a6:803:40::27)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.19; Wed, 13 Oct
 2021 12:35:14 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.016; Wed, 13 Oct 2021
 12:35:14 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM5PR0502CA0018.eurprd05.prod.outlook.com (2603:10a6:203:91::28) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.26 via Frontend
 Transport; Wed, 13 Oct 2021 12:35:13 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0722c2a0-2c22-11ec-816d-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634128520;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=z0H9+WKjmlmsm9ExH6rOGGW7jztCS6kGe4pQCjtAIGc=;
	b=EMAsrsudUUV094KL9JQ5DKcqrUgyB46g2LoZ4HLLECv14DnNZLy5R7LTClDcmk61ZYnDgF
	SpXsxNm13ZFkTrg+vnO4HDhX4hO5TVt/5eBMWGr00mctDGb8xKGY83OEFSXAp6zeAZBMXA
	4KH+A4gH92knRjnVejtZnenQ5Y65qMc=
X-MC-Unique: X1IE8JBHO-ejKUAP8P32jg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=cAL4Vg6pg1idZ0+dQEcpJqenNPYJ2nY6xKzUy9JkQsAIihAf6b/hc1ILa0J5tRgKyBbnz1DhNV2nhmkg3zxyd88cKN/KtJyPiDPnFucON6eEh8pMEcgQcsDJeLk3G4/2DQPjYgNIoyfCRUqGG03zN+J4FM41VVN10R1HeWgJAoOAhXDs0EMDHGPVuxuoagb4p1JCCBQ/a6AShdkz2ngUDINoEQILbCq4B1J5gtz3z4Vbc1iDVT+1z+LqU97M1BGFfqEvmn3Kv+n1AAfhxGVxtqC5tlLErT8i3DnTXWi5UlksdkxQCKzqNFwyGqCVkyikIKT52qIy4/fQy79VqoL5qA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=z0H9+WKjmlmsm9ExH6rOGGW7jztCS6kGe4pQCjtAIGc=;
 b=UYLLNUzCeXmzrMvx+iT/615xoSuv2jw7tA28Q4fZfsptPvZHLNPkwTfYsj6xV4I05aV+S4VgIU+usVm8XrraufdDbGgsBFm48J9GWW/aOV8jzUEd8TuFG3RsNEfBiVpHqchMpAIomt4qKay8VBm8Yno/VDZBwlGF7RMSCNE7an+BG4kTaRy70unPBAgLegPmybIAlQgiugpXZH/ygcuMNpIr02KSWgl1J/9BeYr0XHYgM1x5ADdFT+Awp+csH0UZF7gK+Ulzrwy8edtWHEf9oY92spgJ0yk4LwcpuMvgCnGiClc14+d9LOjryigtayOY6xfOJIHNLL2YIIjHYL6QJQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [XEN PATCH v7 24/51] build: prepare to always invoke $(MAKE) from
 xen/, use $(obj)
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Daniel De Graaf <dgdegra@tycho.nsa.gov>,
 "Daniel P. Smith" <dpsmith@apertussolutions.com>,
 xen-devel@lists.xenproject.org
References: <20210824105038.1257926-1-anthony.perard@citrix.com>
 <20210824105038.1257926-25-anthony.perard@citrix.com>
 <430f6b64-e255-1250-1afb-a596a57ed1a9@suse.com> <YWa7ms9QIV4szv9x@perard>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <47358db3-8108-5a28-1b00-6d206800294a@suse.com>
Date: Wed, 13 Oct 2021 14:35:12 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <YWa7ms9QIV4szv9x@perard>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM5PR0502CA0018.eurprd05.prod.outlook.com
 (2603:10a6:203:91::28) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 09571bee-94bb-49aa-1d78-08d98e45e7d1
X-MS-TrafficTypeDiagnostic: VI1PR04MB4349:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB4349E7B1689FC942650DF8AFB3B79@VI1PR04MB4349.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	05L+yKR/4SHawFufj3ImrdzruDpT0CENKoWbC82bYL+6CtnOBKC6+L9mOCbEgk/I1D1jIQSxldDWeEfN/SF5FGR3XdDgkemSEpCPnsDfI6dVTyZGmlzp/rGe12SFZEcAtRWH11xlT5fY7wCsRFDypaa77L+W1GXj3od5k+VVIhs6LhBbg0zd9WA8PyIGI/0CII7d9LwT8o+xvPHfFUIx3v1KEVp6NmfZdiG8cZ/XJ9Dkzy/dp6GCHFcgcpQxmeQStTP1NMEaFF7CxDdieWDDFreOstWIT+V9kjOSeKyfczN4Op0LS9p9KLoM6fqwPsGYvcEJSI3YR8bWCcd3j1PAqPxqB9UJK7YBdfYd95b3NskyzDe26Wioj21yo4OnZSH90F2q1vVR9uzEzfTDTe50m3c2kSgRW3xA6zes8Cid7SsAHllAwH7BmICpEL+NTov7U3dfDqInLyt9BrjCaAgPsh5HgeQg4nRi7/UbeyPlutAwLpksjqCKrrbTLuNUo9nyzGpL/EjiyMRvvcc5lfNXvm1MIB4zla9W0yCnqGKNsNDZNYQIZLHbgXD8ma7WNTE8OQZMElFQXnkAO0F8Sd93BxxXkrBJFr9+8b2rgEYX6oH8BELtDigEZANm786y6RzjCetNTW4JjOpcoLYzPS4EP8fR1ZnaghHT+K8PLmNuBm/qb16rttNTZKMNFFWDEBhCr4xOYKNQM3bXyWxQEz6LM7OZpVSP7aUH6H8U6UX19q4DOb83okIXdKfGlf+xjzcp
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(186003)(53546011)(5660300002)(31686004)(26005)(66946007)(4326008)(8936002)(38100700002)(7416002)(2906002)(86362001)(8676002)(66476007)(83380400001)(66556008)(956004)(36756003)(508600001)(316002)(16576012)(31696002)(6916009)(54906003)(6486002)(2616005)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?U2FNdDYyMnQ3Y3J4My9LekgwUVEyNGs0UUJjK1NvcUJYcy9DM3diYXRiVlFP?=
 =?utf-8?B?M1d3VGQxSUZBa09mU2huL1pCemJ0MzlTZEN0aXQvZHNQeW9qaCtzRzlUY3Zy?=
 =?utf-8?B?ektTcm5wZkxseHNsOVZFN0NUZC9TRGh0cFBTemxzdDd5TTdUci9VdThKQTRW?=
 =?utf-8?B?SURZbzZRVjdsaS9FL1RsTU5MR2RwWjhWN2ZFNFp0R0dSUDd0Ui9NMVRWYmdy?=
 =?utf-8?B?bGVOR21qL3RWbnZlb01Mc0czZTh3T3FMNXRjeDNoeGY1WVlVVHJER2FjV0NW?=
 =?utf-8?B?UnpTcWlJRk45QW1ObE9hWktPSGZ6VnpUcjFvVVFXcUU4VVpVdi84aWs3Z3hj?=
 =?utf-8?B?U0kzY2pTZzJsVjNlOG5iZS85Tm5aazJNbWN3b2NHblh4ckxVVWZyT3VHcUs4?=
 =?utf-8?B?eVNuejg5NjZnazJFNFE3eDhzOENiRUsvdXFrak5uSnNDUGo0aU8xZkh2cnpJ?=
 =?utf-8?B?SmlhWmR2UTczaXp2MWNveFBXelA2eTJyVFNjOEEyQ096d3RIcEJhcFIyTjdh?=
 =?utf-8?B?UUgxQ2FQRkhmaWlya1UvN0ZVaUNpWWZza2UwTERTMEtGRG9UMCtyVzNOd1d2?=
 =?utf-8?B?dnZXTnpEWUJra2s3SHFXaHJVdWpmdzNpYnp3VWtyL0E1UjZIaDNkYWZqMmtX?=
 =?utf-8?B?Z2pDaW1kMVpSWXVwa3NqcjJaSURCUURaWUNaZkVmSSsxWDRsUDNleVV1NmxU?=
 =?utf-8?B?REdWMkJ1M3RLUUxJcGFoV0ZGMTN5L05idzZHVVpiSGdOdDhNeTk4bmI1RG05?=
 =?utf-8?B?cW9FNFRySlJlTlo3SFBYYXV3eW0wNXpld0tsQUg3MDdrUHl5Zit0ZVRXWW9I?=
 =?utf-8?B?VjVGMndnQktGL0ZiVmVZejFWWmpMVEdyalZaMEoxakRudzlubW1YMlhITnc0?=
 =?utf-8?B?TU9DUTk4MTA2ZVh1RzRVcTlrVEFaOHc1WHJIdHpqeFArYk8xTlE4RlJTTk0x?=
 =?utf-8?B?SVN6SVZPK0Z2WjNQSHI3NytyRUt1N1dNd2tGZkpvTzl6NGtrWFBzQnFkK3dY?=
 =?utf-8?B?YlZvcUJ6MlhDQVc1MTlGYTZxUFAzQjJnSk9QcFdZUnZwZ2d3VXhGeWVKT1pG?=
 =?utf-8?B?eTIydUhyVlVTQlVpcEZtb1NmbG1tcHhYa0x2WFNjNXRDeVlDNkpnRVFGeXgz?=
 =?utf-8?B?Wm1mSWtIZ3BBcGNDcHJjV044eXZuOEJPZ1NUR2xzZHZwclhONkJIY3NTaEQy?=
 =?utf-8?B?WloxL2dnVGsrZ243ckhxWGJEN3gwZ0ZqeHNuSURFTW9jY01UelI2V2dnSlJN?=
 =?utf-8?B?Wm9aM25kZGREZmgwUlA0SEl0NjZIMTBTWUVsOW5sSGJVRVZoUTYvSmFZY2Vq?=
 =?utf-8?B?WVY3R1BFOTdxWTlhNkF2VlpKUVBVL3EyWTdBQjdiWUl3NGd5NDZYZGpqRlNT?=
 =?utf-8?B?azFOMHMyeWI1TnYxbUpMOCtIbkYvSUQvRmNQVkFPcHI5cEtrZStFNlg4RHJi?=
 =?utf-8?B?TW8xOWV0WGhwVXZUUlpDNzJ6WUo5N3JOOWxpQ3E5NVByaE9xNWF5QkhtQk9W?=
 =?utf-8?B?UXJlalFUUjVTQWhMYmUzN0k4dUVvdUFtTDhTdE8rMUpzM0lOZUpEcmFpM1Zp?=
 =?utf-8?B?dFcrOTBlL2owUCtXT1BFaExDNzJBN2Y4QStjeG1JNDlsZWZ1Zm1Ub0VNQUtv?=
 =?utf-8?B?bHZTY0xWbGpWSW9ZUzVoRm9RaVhvcjVpUXRuWUp5VmwzRDVpQlJlK1lMTEdG?=
 =?utf-8?B?YStFSnZPSkRSZmppK05EVEpKZU9kcnVTd2g4UUdMd1FpdVA4TUlBaGp1NHVu?=
 =?utf-8?Q?JDVr7C46L/3XAXDxYZsL9P689Ql52JJz+IJBawK?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 09571bee-94bb-49aa-1d78-08d98e45e7d1
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2021 12:35:14.4084
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: PW0NALyC+UPs3xv/AqLELsBKgo2lfjtPEGIC3mEWhkp4PeEXQvh+8tw2N3CmJ9KnVkFQ0Ze8GkKLvW3Kt5MSDw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4349

On 13.10.2021 12:57, Anthony PERARD wrote:
> On Mon, Oct 11, 2021 at 02:39:26PM +0200, Jan Beulich wrote:
>> On 24.08.2021 12:50, Anthony PERARD wrote:
>>> @@ -222,14 +222,14 @@ $(TARGET).efi: FORCE
>>>  endif
>>>  
>>>  # These should already have been rebuilt when building the prerequisite of "prelink.o"
>>> -efi/buildid.o efi/relocs-dummy.o: ;
>>> +$(obj)/efi/buildid.o $(obj)/efi/relocs-dummy.o: ;
>>>  
>>>  .PHONY: include
>>>  include: $(BASEDIR)/arch/x86/include/asm/asm-macros.h
>>>  
>>> -asm-macros.i: CFLAGS-y += -D__ASSEMBLY__ -P
>>> +$(obj)/asm-macros.i: CFLAGS-y += -D__ASSEMBLY__ -P
>>>  
>>> -$(BASEDIR)/arch/x86/include/asm/asm-macros.h: asm-macros.i Makefile
>>> +$(BASEDIR)/arch/x86/include/asm/asm-macros.h: $(obj)/asm-macros.i $(src)/Makefile
>>
>> Isn't this $(obj)/include/asm/asm-macros.h ? And in general doesn't
>> use of $(BASEDIR) need to go away then, e.g. ...
> 
> I've limited this patch to add $(obj)/ and $(src)/ were needed, I think.
> 
> And yes, BASEDIR will need to go away.

And replacing it here while you're touching the line anyway is not an
option?

>>> --- a/xen/scripts/Makefile.clean
>>> +++ b/xen/scripts/Makefile.clean
>>> @@ -3,11 +3,14 @@
>>>  # Cleaning up
>>>  # ==========================================================================
>>>  
>>> +obj := .
>>> +src := $(obj)
>>
>> This repeats what is also getting added to Rules.mk. To prevent
>> the two going out of sync, wouldn't they better live in a central
>> place (e.g. scripts/defs.mk)?
> 
> It looks like they are the same but they are not, it doesn't matter if
> they go out of sync, and they actually do in my patch series.

How can them going out of sync be correct?

Jan



From xen-devel-bounces@lists.xenproject.org Wed Oct 13 12:36:41 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 12:36:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.208392.364494 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1madUt-0002Vq-Lc; Wed, 13 Oct 2021 12:36:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 208392.364494; Wed, 13 Oct 2021 12:36:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1madUt-0002Vj-IY; Wed, 13 Oct 2021 12:36:39 +0000
Received: by outflank-mailman (input) for mailman id 208392;
 Wed, 13 Oct 2021 12:36:38 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=cLgy=PB=gmail.com=ysaikiran1997@srs-us1.protection.inumbo.net>)
 id 1madUr-0002VZ-SK
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 12:36:37 +0000
Received: from mail-yb1-xb31.google.com (unknown [2607:f8b0:4864:20::b31])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 14ce58b4-38e1-4ec8-9807-e86b9205a59c;
 Wed, 13 Oct 2021 12:36:36 +0000 (UTC)
Received: by mail-yb1-xb31.google.com with SMTP id h2so5914865ybi.13
 for <xen-devel@lists.xenproject.org>; Wed, 13 Oct 2021 05:36:36 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 14ce58b4-38e1-4ec8-9807-e86b9205a59c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=LIEnGOipm0AE4dO+LlG8N5/ABREeO/sIeAK3UEXXBcI=;
        b=KC4ZHxopr+UHpgl8R+Ea30JQnUJWIS5P/RcMKCvM/CRgiEXOQCCW0Wh34pjRC+QIzw
         A/qC8MxMXf5BIcfgQJWWzTK49GUNDi9evOagcOZ8XJSh+3gecBsbqKcW4s/Lgc4Wf/70
         gRSkR46cAzxmNN1CLlNkoLfR7SMwyeFAf78em/SV5iDa76R4Eb6kZ48CdkV1HUJZZ6PO
         rfxs7Rbi5IUkZZ/yDnOKR5GpUxe+1EUHn6hUsRvdMMEjzBwFCngqzizhdwTf1FAL/bQj
         pe+lYl7unzO6YTOEqyrGUtb4C2yLps9M7JAWfl2AGYn+A5bgxupsJfnKTuGaWF4aGt0l
         Fmqg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=LIEnGOipm0AE4dO+LlG8N5/ABREeO/sIeAK3UEXXBcI=;
        b=K03O/Jqm6IDF8zW+db1d59YMT9NPZLoFpzjFGEldDNEa5FYDhJE176MolvNfVI/Phw
         MD4zuJRiHvdaW3KBzPpgUAZTqYT455Mb1+FWiYuY7/WW4ixh/+l3eqiM8M5GqMyVTZty
         XaIzSplWZTfCdc+0DR0vIlB6V/yQqkP+dK6g64ZTj5pVbU2v+pnnXK5p9pCwrT7H+297
         F0UYylo64evrbZ0zcqlI2R7YDdTSSzJ9TCODVFilTQHifMbEHqzftz4HIAoKQ7qziBem
         cbz21M0XgmJyNPV3eQtdHm/+J8wAAhsSw0X5YuuQcp4znhvmNVAGAJVcEqQv0B+rzKQk
         nYYg==
X-Gm-Message-State: AOAM530S69rS2S+xYZA29gl7HZP1nWo/B9ATiWT31c3gL5arPvhmHbHO
	EkxB2PH+RfWAm8+VS0JbGcJWeEqW7U+S/bu+Ud4=
X-Google-Smtp-Source: ABdhPJzryrZtoVEU4hTta+mm78BMnzH687i5c9d3wErCt9yJqElXTcxTuLxRkMPIs6Zz2zCskJtG1aPNzz0mIfk/7Cc=
X-Received: by 2002:a25:cb03:: with SMTP id b3mr34803792ybg.138.1634128595571;
 Wed, 13 Oct 2021 05:36:35 -0700 (PDT)
MIME-Version: 1.0
References: <33C29853-D896-4E4E-91D3-4D2FA89A9B91@hxcore.ol>
 <eb5fd47b-6bc9-2eec-7f46-9ab9a42c9f1f@xen.org> <CAEsO4uzsCnsTtTmYHAT4NN6=girCY2NHHdAHbH6GG33D7jwe_A@mail.gmail.com>
 <alpine.DEB.2.21.2109131437030.10523@sstabellini-ThinkPad-T480s>
 <CAEsO4uwpiDO2QoqLRTOxpsYM9YSPAsbX0P=gagdEy21pk1VsPQ@mail.gmail.com>
 <alpine.DEB.2.21.2109141825330.21985@sstabellini-ThinkPad-T480s>
 <CAEsO4uyjNs97Cx8n2owDk4kKTVCycji377pm7aXHcPWzeszUTw@mail.gmail.com>
 <alpine.DEB.2.21.2109301942370.3209@sstabellini-ThinkPad-T480s> <CAEsO4ux_AqXBeCtbwnPAdnBnVYHTur_2EfcZBTuN4QKCq4ko8Q@mail.gmail.com>
In-Reply-To: <CAEsO4ux_AqXBeCtbwnPAdnBnVYHTur_2EfcZBTuN4QKCq4ko8Q@mail.gmail.com>
From: Sai Kiran Kumar Reddy Y <ysaikiran1997@gmail.com>
Date: Wed, 13 Oct 2021 18:06:23 +0530
Message-ID: <CAEsO4uxRMzTbdfLZY2MQ=e12NRC6AG4_oYKGMwhZOq4a6su-9w@mail.gmail.com>
Subject: Re: Xen Booting Problem on ARM Machine
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: Julien Grall <julien@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>, 
	Jan Beulich <jbeulich@suse.com>, Luca Fancellu <luca.fancellu@arm.com>, 
	xen-devel@lists.xenproject.org, kannan@cimware.in
Content-Type: multipart/alternative; boundary="00000000000074d75105ce3b3661"

--00000000000074d75105ce3b3661
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi,

I am resending the mail as the attachment size is more. Here is the link to
the attachments:
https://drive.google.com/drive/folders/1daloarRFaopg8vf-6Uwq-pRd9ki0EXm8?us=
p=3Dsharing


On Wed, Oct 13, 2021 at 5:30 PM Sai Kiran Kumar Reddy Y <
ysaikiran1997@gmail.com> wrote:

>
>
> On Fri, Oct 1, 2021 at 8:17 AM Stefano Stabellini <sstabellini@kernel.org=
>
> wrote:
>
>> Yes there are other ways but without serial is going to be difficult
>> because you are not going to see anything until everything works.
>>
>> How do you boot Xen and Dom0 exactly from EDK2? Are you using GRUB or
>> loading Xen directly from the EDK2 prompt? Please provide as many
>> details as possible so that I might be able to spot any errors.
>>
>  I am using GRUB to load Xen. In the GRUB menu, I see two options.
Option 1: Debian 11 with latest Linux Kernel
Option 2: Debian 11(with Xen hypervisor) with latest Kernel

>
>
>> Can you provide the Device Tree you are using? If you are not passing
>> any Device Tree  binary explicitely, then it might be passed
>> automatically from EDK2 to Linux/Xen. In that case, just boot from Linux
>> then do the following to retrieve the Device Tree:
>>
>> dtc -I fs -O dts /proc/device-tree > host.dts
>>
>> Then please attach host.dts to this email thread.
>>
>> Yeah, you are right. It looks like LInux is booting from ACPI. In the
bootloader menu, "Automatic ACPI configuration" is disabled. So, I thought
that Linux may be booting from Device Tree. I have tried the "dtc" command
you mentioned. But it looks like there's no device-tree under "/proc". I
also tried to get DT info, from "/sys/firmware/devicetree/base" . But,
there's no info. under devicetree folder. I am not quite sure how to get
the DT info, if the Linux is booting from ACPI. I am attaching .dsl files,
that contain the acpi info.

>
>> Also for your information it looks like Linux actually booted from ACPI,
>> not from Device Tree, as you can see from all the "ACPI" messages in the
>> kernel logs.
>>
>> If you need to boot from ACPI, then you need to enable ACPI support in
>> Xen, which is disabled by default. You can do that using make
>> menuconfig.
>>
>>  In the make menuconfig of Xen, I do not see any option to enable ACPI.

>
>> On Thu, 30 Sep 2021, Sai Kiran Kumar Reddy Y wrote:
>> > Hi,
>> > Sorry about the delay. We have been trying to access the serial of the
>> machine. Tried with couple of JTAG connectors. There's still no
>> > debug messages on the serial. Is there any other way of figuring this
>> out?
>> >
>> > On Wed, Sep 15, 2021, 7:02 AM Stefano Stabellini <
>> sstabellini@kernel.org> wrote:
>> >       Something is off. When you enabled earlyprintk in Xen, you shoul=
d
>> see
>> >       something like this at boot time:
>> >       https://marc.info/?l=3Dxen-devel&m=3D158829968025334
>> >
>> >       All the Xen logs starting with "(XEN)" on the serial. Do you hav=
e
>> access
>> >       to the serial of the machine? Without it, it is going to be hard
>> to
>> >       debug.
>> >
>> >
>> >       On Tue, 14 Sep 2021, Sai Kiran Kumar Reddy Y wrote:
>> >       > In the folder "/var/log", there's a file called "xen", which i=
s
>> empty. As far as the boot logs are concerned, I don't see any
>> >       debug
>> >       > messages related to xen. I am attaching the log files,
>> "kern.txt" and "boot.txt"
>> >       >
>> >       > On Tue, Sep 14, 2021 at 3:08 AM Stefano Stabellini <
>> sstabellini@kernel.org> wrote:
>> >       >       On Mon, 13 Sep 2021, Sai Kiran Kumar Reddy Y wrote:
>> >       >       > On Fri, Sep 10, 2021 at 7:30 PM Julien Grall <
>> julien@xen.org> wrote:
>> >       >       >
>> >       >       >
>> >       >       >       On 08/09/2021 11:43, Sai Kiran wrote:
>> >       >       >       > Hello,
>> >       >       >
>> >       >       >       Hi,
>> >       >       >
>> >       >       >       Thank you for the report. Moving the discussion
>> back to xen-devel
>> >       >       >       because this looks like a potential issue in the
>> UEFI stub in Xen.
>> >       >       >
>> >       >       >       > I have Xen-4.15.0 on an ARM Machine, with
>> Debian 11 installed on it.
>> >       >       >
>> >       >       >       Would you be able to give more details on the Ar=
m
>> machine you are using?
>> >       >       >       Also, are you using ACPI or DT to boot?
>> >       >       >
>> >       >       >
>> >       >       >    Sai >> DT . ACPI configuration is disabled in Boot
>> settings
>> >       >       >
>> >       >       >       >  I
>> >       >       >       > am able to do =E2=80=9Cmake world=E2=80=9D and=
 =E2=80=9Cmake install=E2=80=9D,
>> after =E2=80=9C./configure=E2=80=9D, as
>> >       >       >       > specified in README file. When I reboot the
>> system, I get the following
>> >       >       >       > message:
>> >       >       >       >
>> >       >       >       > Warning: All 128 bootinfo mem banks exhausted.
>> >       >       >       >
>> >       >       >       > Warning: All 128 bootinfo mem banks exhausted.
>> >       >       >
>> >       >       >       Hmmm... This means that you have more than 128
>> memory regions described
>> >       >       >       in the EFI memory map. That's quite a lot.
>> >       >       >
>> >       >       >       Although, this should be harmless as it means Xe=
n
>> will not use the extra
>> >       >       >       memory banks.
>> >       >       >
>> >       >       >       >
>> >       >       >       > Cannot exit boot services: ErrCode:
>> 0x8000000000000002
>> >       >       >
>> >       >       >       This means EFI_INVALID_PARAMETER. We have code t=
o
>> retry because AFAICT
>> >       >       >       ExitBootServices() may sometime fails (I have
>> CCed Jan may have more
>> >       >       >       idea what's happening).
>> >       >       >
>> >       >       >       Would you be able to provide more details on the
>> UEFI firmware you are
>> >       >       >       using? Is it EDK2 or U-boot?
>> >       >       >
>> >       >       > Sai >>  EDK2
>> >       >       >       Also, do you know if Linux is boot on the same
>> system?
>> >       >       >
>> >       >       > Sai >> Yes
>> >       >       >       However, AFAICT, the error message would not
>> prevent Xen to continue
>> >       >       >       booting. So you may get stuck later in the boot
>> process.
>> >       >       >
>> >       >       >       My suggestion would be to enable earlyprintk for
>> your platform. You can
>> >       >       >       setup it up from the menuconfig in "Debugging
>> Options".
>> >       >       >
>> >       >       > Sai >> Yes, I have enabled earlyprintk.
>> >       >       > I tried changing NR_MEM_BANKS(in
>> xen/include/asm-arm/setup.h) value to 256, from 128. The error message i=
s
>> no longer
>> >       seen,
>> >       >       but the device
>> >       >       > is stuck in the boot process.
>> >       >
>> >       >       Could you please post the boot logs now that you enabled
>> earlyprintk?
>> >       >       Ideally not a camera picture but a textual copy/paste
>> from the target
>> >       >       serial?
>> >       >
>> >       >       Earlyprintk is pretty verbose, we should be able to
>> figure out where it
>> >       >       gets stuck.
>> >       >
>> >       >
>> >       >
>> >
>> >
>> >
>
>

--00000000000074d75105ce3b3661
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div>Hi,</div><div><br></div><div>I am resending the mail =
as the attachment size is more. Here is the link to the attachments: <a hre=
f=3D"https://drive.google.com/drive/folders/1daloarRFaopg8vf-6Uwq-pRd9ki0EX=
m8?usp=3Dsharing">https://drive.google.com/drive/folders/1daloarRFaopg8vf-6=
Uwq-pRd9ki0EXm8?usp=3Dsharing</a></div><div><br></div><br><div class=3D"gma=
il_quote"><div dir=3D"ltr" class=3D"gmail_attr">On Wed, Oct 13, 2021 at 5:3=
0 PM Sai Kiran Kumar Reddy Y &lt;<a href=3D"mailto:ysaikiran1997@gmail.com"=
>ysaikiran1997@gmail.com</a>&gt; wrote:<br></div><blockquote class=3D"gmail=
_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204=
,204);padding-left:1ex"><div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><di=
v class=3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail_attr">On Fri, Oct 1=
, 2021 at 8:17 AM Stefano Stabellini &lt;<a href=3D"mailto:sstabellini@kern=
el.org" target=3D"_blank">sstabellini@kernel.org</a>&gt; wrote:<br></div><b=
lockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-le=
ft:1px solid rgb(204,204,204);padding-left:1ex">Yes there are other ways bu=
t without serial is going to be difficult<br>
because you are not going to see anything until everything works.<br>
<br>
How do you boot Xen and Dom0 exactly from EDK2? Are you using GRUB or<br>
loading Xen directly from the EDK2 prompt? Please provide as many<br>
details as possible so that I might be able to spot any errors.<br></blockq=
uote><div></div></div></div></blockquote><div>=C2=A0I am using GRUB to load=
 Xen. In the GRUB menu, I see two options. <br></div><div>Option 1: Debian =
11 with latest Linux Kernel</div><div>Option 2: Debian 11(with Xen hypervis=
or) with latest Kernel</div><blockquote class=3D"gmail_quote" style=3D"marg=
in:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1e=
x"><div dir=3D"ltr"><div class=3D"gmail_quote"><div>=C2=A0</div><blockquote=
 class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px so=
lid rgb(204,204,204);padding-left:1ex">
Can you provide the Device Tree you are using? If you are not passing<br>
any Device Tree=C2=A0 binary explicitely, then it might be passed<br>
automatically from EDK2 to Linux/Xen. In that case, just boot from Linux<br=
>
then do the following to retrieve the Device Tree:<br>
<br>
dtc -I fs -O dts /proc/device-tree &gt; host.dts<br>
<br>
Then please attach host.dts to this email thread.<br>
<br></blockquote><div></div></div></div></blockquote><div>Yeah, you are rig=
ht. It looks like LInux is booting from ACPI. In the bootloader menu, &quot=
;Automatic ACPI configuration&quot; is disabled. So, I thought that Linux m=
ay be booting from Device Tree. I have tried the &quot;dtc&quot; command yo=
u mentioned. But it looks like there&#39;s no device-tree under &quot;/proc=
&quot;. I also tried to get DT info, from &quot;/sys/firmware/devicetree/ba=
se&quot; . But, there&#39;s no info. under devicetree folder. I am not quit=
e sure how to get the DT info, if the Linux is booting from ACPI. I am atta=
ching .dsl files, that contain the acpi info.<br></div><blockquote class=3D=
"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(2=
04,204,204);padding-left:1ex"><div dir=3D"ltr"><div class=3D"gmail_quote"><=
blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-l=
eft:1px solid rgb(204,204,204);padding-left:1ex">
<br>
Also for your information it looks like Linux actually booted from ACPI,<br=
>
not from Device Tree, as you can see from all the &quot;ACPI&quot; messages=
 in the<br>
kernel logs.<br>
<br>
If you need to boot from ACPI, then you need to enable ACPI support in<br>
Xen, which is disabled by default. You can do that using make<br>
menuconfig.<br>
<br></blockquote><div></div></div></div></blockquote><div>=C2=A0In the make=
 menuconfig of Xen, I do not see any option to enable ACPI.=C2=A0=C2=A0</di=
v><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;borde=
r-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir=3D"ltr"><div c=
lass=3D"gmail_quote"><blockquote class=3D"gmail_quote" style=3D"margin:0px =
0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
On Thu, 30 Sep 2021, Sai Kiran Kumar Reddy Y wrote:<br>
&gt; Hi,<br>
&gt; Sorry about the delay. We have been trying to access the serial of the=
 machine. Tried with couple of JTAG connectors. There&#39;s still no<br>
&gt; debug messages on the serial. Is there any other way of figuring this =
out?<br>
&gt; <br>
&gt; On Wed, Sep 15, 2021, 7:02 AM Stefano Stabellini &lt;<a href=3D"mailto=
:sstabellini@kernel.org" target=3D"_blank">sstabellini@kernel.org</a>&gt; w=
rote:<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0Something is off. When you enabled earlyprin=
tk in Xen, you should see<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0something like this at boot time:<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0<a href=3D"https://marc.info/?l=3Dxen-devel&=
amp;m=3D158829968025334" rel=3D"noreferrer" target=3D"_blank">https://marc.=
info/?l=3Dxen-devel&amp;m=3D158829968025334</a><br>
&gt; <br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0All the Xen logs starting with &quot;(XEN)&q=
uot; on the serial. Do you have access<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0to the serial of the machine? Without it, it=
 is going to be hard to<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0debug.<br>
&gt; <br>
&gt; <br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0On Tue, 14 Sep 2021, Sai Kiran Kumar Reddy Y=
 wrote:<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt; In the folder &quot;/var/log&quot;, the=
re&#39;s a file called &quot;xen&quot;, which is empty. As far as the boot =
logs are=C2=A0concerned, I don&#39;t see any<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0debug<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt; messages related to xen. I am attaching=
 the log files, &quot;kern.txt&quot; and &quot;boot.txt&quot;<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt; On Tue, Sep 14, 2021 at 3:08 AM Stefano=
 Stabellini &lt;<a href=3D"mailto:sstabellini@kernel.org" target=3D"_blank"=
>sstabellini@kernel.org</a>&gt; wrote:<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0On Mon, 13 Se=
p 2021, Sai Kiran Kumar Reddy Y wrote:<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt; On Fri, =
Sep 10, 2021 at 7:30 PM Julien Grall &lt;<a href=3D"mailto:julien@xen.org" =
target=3D"_blank">julien@xen.org</a>&gt; wrote:<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =
=C2=A0 =C2=A0 =C2=A0On 08/09/2021 11:43, Sai Kiran wrote:<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =
=C2=A0 =C2=A0 =C2=A0&gt; Hello,<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =
=C2=A0 =C2=A0 =C2=A0Hi,<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =
=C2=A0 =C2=A0 =C2=A0Thank you for the report. Moving the discussion back to=
 xen-devel<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =
=C2=A0 =C2=A0 =C2=A0because this looks like a potential issue in the UEFI s=
tub in Xen.<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =
=C2=A0 =C2=A0 =C2=A0&gt; I have Xen-4.15.0 on an ARM Machine, with Debian 1=
1 installed on it.<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =
=C2=A0 =C2=A0 =C2=A0Would you be able to give more details on the Arm machi=
ne you are using?<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =
=C2=A0 =C2=A0 =C2=A0Also, are you using ACPI or DT to boot?<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt; =C2=A0 =
=C2=A0Sai &gt;&gt; DT . ACPI configuration is disabled in Boot settings=C2=
=A0 =C2=A0=C2=A0<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =
=C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 I<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =
=C2=A0 =C2=A0 =C2=A0&gt; am able to do =E2=80=9Cmake world=E2=80=9D and =E2=
=80=9Cmake install=E2=80=9D, after =E2=80=9C./configure=E2=80=9D, as<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =
=C2=A0 =C2=A0 =C2=A0&gt; specified in README file. When I reboot the system=
, I get the following<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =
=C2=A0 =C2=A0 =C2=A0&gt; message:<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =
=C2=A0 =C2=A0 =C2=A0&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =
=C2=A0 =C2=A0 =C2=A0&gt; Warning: All 128 bootinfo mem banks exhausted.<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =
=C2=A0 =C2=A0 =C2=A0&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =
=C2=A0 =C2=A0 =C2=A0&gt; Warning: All 128 bootinfo mem banks exhausted.<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =
=C2=A0 =C2=A0 =C2=A0Hmmm... This means that you have more than 128 memory r=
egions described<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =
=C2=A0 =C2=A0 =C2=A0in the EFI memory map. That&#39;s quite a lot.<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =
=C2=A0 =C2=A0 =C2=A0Although, this should be harmless as it means Xen will =
not use the extra<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =
=C2=A0 =C2=A0 =C2=A0memory banks.<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =
=C2=A0 =C2=A0 =C2=A0&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =
=C2=A0 =C2=A0 =C2=A0&gt; Cannot exit boot services: ErrCode: 0x800000000000=
0002<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =
=C2=A0 =C2=A0 =C2=A0This means EFI_INVALID_PARAMETER. We have code to retry=
 because AFAICT<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =
=C2=A0 =C2=A0 =C2=A0ExitBootServices() may sometime fails (I have CCed Jan =
may have more<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =
=C2=A0 =C2=A0 =C2=A0idea what&#39;s happening).<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =
=C2=A0 =C2=A0 =C2=A0Would you be able to provide more details on the UEFI f=
irmware you are<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =
=C2=A0 =C2=A0 =C2=A0using? Is it EDK2 or U-boot?<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt; Sai &gt;=
&gt;=C2=A0 EDK2=C2=A0<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =
=C2=A0 =C2=A0 =C2=A0Also, do you know if Linux is boot on the same system?<=
br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt; Sai &gt;=
&gt; Yes=C2=A0<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =
=C2=A0 =C2=A0 =C2=A0However, AFAICT, the error message would not prevent Xe=
n to continue<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =
=C2=A0 =C2=A0 =C2=A0booting. So you may get stuck later in the boot process=
.<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =
=C2=A0 =C2=A0 =C2=A0My suggestion would be to enable earlyprintk for your p=
latform. You can<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =
=C2=A0 =C2=A0 =C2=A0setup it up from the menuconfig in &quot;Debugging Opti=
ons&quot;.<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt; Sai &gt;=
&gt; Yes, I have enabled earlyprintk.<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt; I tried =
changing NR_MEM_BANKS(in xen/include/asm-arm/setup.h) value to 256, from 12=
8. The error message is no longer<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0seen,<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0but the devic=
e<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt; is stuck=
 in the boot process.<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0Could you ple=
ase post the boot logs now that you enabled earlyprintk?<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0Ideally not a=
 camera picture but a textual copy/paste from the target<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0serial?<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0Earlyprintk i=
s pretty verbose, we should be able to figure out where it<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0gets stuck.<b=
r>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;<br>
&gt; <br>
&gt; <br>
&gt; </blockquote></div></div>
</blockquote></div></div>

--00000000000074d75105ce3b3661--


From xen-devel-bounces@lists.xenproject.org Wed Oct 13 12:41:55 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 12:41:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.208401.364505 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1madZv-0003zA-8a; Wed, 13 Oct 2021 12:41:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 208401.364505; Wed, 13 Oct 2021 12:41:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1madZv-0003z3-5f; Wed, 13 Oct 2021 12:41:51 +0000
Received: by outflank-mailman (input) for mailman id 208401;
 Wed, 13 Oct 2021 12:41:49 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=bU9L=PB=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1madZt-0003yx-7y
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 12:41:49 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 7bba4426-6096-4c68-a898-54ff7d123c4e;
 Wed, 13 Oct 2021 12:41:48 +0000 (UTC)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2053.outbound.protection.outlook.com [104.47.12.53]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-40-zcaSWsxlOT-4IsphOj98kA-1; Wed, 13 Oct 2021 14:41:46 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0402MB3776.eurprd04.prod.outlook.com (2603:10a6:803:18::23)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.25; Wed, 13 Oct
 2021 12:41:43 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.016; Wed, 13 Oct 2021
 12:41:43 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS9PR05CA0034.eurprd05.prod.outlook.com (2603:10a6:20b:489::7) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4587.26 via Frontend Transport; Wed, 13 Oct 2021 12:41:42 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7bba4426-6096-4c68-a898-54ff7d123c4e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634128907;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=EXJy3Yc0VlLtKDC1/od/Qu3vi8h1dQ6pxGZx4yZk6FQ=;
	b=g3FM8eFYei1vBKpiSFjrBdu11eVbZ0TSTKiNlB800Cb5xBYdrZRpuWzbeI4ko4fUQPiFp/
	mkOq6mfdCSZ1Pyoo4BByQ42hqYfC13WHlO7XtnHiSNTX01JC+XbQxy8vcDNEpBfDiQ3UpU
	jTMKlFvtn0uIaMiO7lZ5/rVhi4jJeVY=
X-MC-Unique: zcaSWsxlOT-4IsphOj98kA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=lmUIgWgdUUbs/EWPXHfQ3FPfSo8ibT+DjfqNz0pxV5NhmZ0TBK3tBt12trCND25YVfZxckjPPQ2XytgMV+Q3qvgPx84TEP4G+s8zcScaEf0SuQ9Dm/Bwa/vNDODemGn1sUT/XAmsW8I7fHU40eMQUcTeI1/bb3I5gYoktmgS6hCIp4LISUQOEpGontgRNND+XfAeZYJw6Nr8PpCv2x+j2rMX9jf3og4lGlbm0X/UkU7PSBftLNpil1hv42CzDVY460kbAXKTu1AauuMNqEXu7U4ZsTuk3BIsKzop5WVMWd3Ct4Qrthdn6DQm4GM2/vdTLYrM3NygHYYVoRJHhr5/Ug==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=EXJy3Yc0VlLtKDC1/od/Qu3vi8h1dQ6pxGZx4yZk6FQ=;
 b=NspsEGnEhzek9pNN196TpMBxuYpqGzcd3k6h7I7eCRdbtEP+E350IR+UYhhwGKomyI8J4mPK5Ak/Vli3/5i6QvmURrowyk2ofqFmdFXPtjgL5h/DppBUYZn3tjkjPXFS4TzVpl0DAHaGtzRk2tzVzH49N4boPCgp3oVGKnKSakbuch3XVfBGTyJ9zqgcZpTwc6vh4YcmezzBcB8Y8sfgUahM2jeFDVrcRtAOdntA46M1hrjQWS8CLUi1Hvm8l0+vAuimdGmC9DHC6+ds0rkUqNDgNECUjxf/39EPDzhzFD/dFrhh0fOwoM/E9iFx7a6Xk7o+RUvv75emPg8jwSb2GQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [XEN PATCH v7 21/51] build: set ALL_OBJS to main Makefile; move
 prelink.o to main Makefile
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 xen-devel@lists.xenproject.org
References: <20210824105038.1257926-1-anthony.perard@citrix.com>
 <20210824105038.1257926-22-anthony.perard@citrix.com>
 <304c1ddc-7bbc-e942-4c5a-8395a750b13d@suse.com> <YWbRUNgGX0sEHMUo@perard>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <1b7b6c03-3de8-ea9e-986f-d999665012bc@suse.com>
Date: Wed, 13 Oct 2021 14:41:41 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <YWbRUNgGX0sEHMUo@perard>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR05CA0034.eurprd05.prod.outlook.com
 (2603:10a6:20b:489::7) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 3612e1cb-5fbe-443f-757c-08d98e46cfd2
X-MS-TrafficTypeDiagnostic: VI1PR0402MB3776:
X-Microsoft-Antispam-PRVS:
	<VI1PR0402MB3776042A9BFBD09EC62C6E48B3B79@VI1PR0402MB3776.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:2201;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	w2xqt6re1O5CkNrxd22zrk0IvM4CqW+VSuwmXL/zzSD76Fr9b+k3KBcrCy5Fdwuh3SvsopqEaU7IrJBCuF+Ny2EO6Xy2r46xTcOq7xtx9h7zYimNnvkRE3ErKDFSMyGJIq8vUBeg8mac2wwLmYYiFzi7rrpjJAhnwd99iEKMjy26ObxvYLc/tVVj+sR/5O8rSxIj3PRG5ab/JXitOmpUbx6cS7hdLe8LhcVh80dp8IZQJHiA1prU9QFj8zaFuUiGcH36GX0ocbA2yvD/ajr1zg/at53HpuohcPJ1B+XA63H0Rsz5eaqov9gHHTLR0t4QSXyq4l6yY1mPVxPHm6yYEvaWBPbuNNJZkEAiNzOWLbs77bvCRcDPulvyDUmHr5YVVuC7NmiS2sCaQVnTnE8I9UVwnVcE+5Mg6BzK4cWc5AlG5/yasJiKPH1lyh4TYpUU8zfk24nhpPZ/0WuI+YJ683dTCTwVN1+5Ia5r0lE/x+ibN2yifstN6TtdyEt86zM4QNnsqLPdAZv65flczkHrFbaP5Du85MDlg2V2IQ8Mx6XrYAG5fp04+2mJtJdL2LgM1hJ6dpcoovBSV/wSuiEEBqwaeqxI20JhulQgZTfzZjEmatUsauP4Rgpk/g3AxDRuh/CEMHSPjXXoVWK/PZfETjvX7sFlkACbPgqC9EbzBzsCGcTPrMbxocFiUw9YsClZcLxLXQhC7FydZaDYVDb0KuQNtEnz8GlWob+4tjHI5c8=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(2906002)(5660300002)(186003)(6916009)(4326008)(66476007)(26005)(7416002)(8676002)(38100700002)(54906003)(2616005)(508600001)(316002)(956004)(53546011)(8936002)(6486002)(31686004)(86362001)(16576012)(36756003)(66946007)(66556008)(31696002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?L0ZWSXB3eno0Y3V3eEZxQTJnOFlIMy83RG4yVDRjdXVjQkhZdnBSU1JROGVu?=
 =?utf-8?B?cVNNRjBsSFN0QjlBU25PMDNPVmVoSG1jOTc0Qy9MczhjNEdOQmh0QU9GQ2pI?=
 =?utf-8?B?TzRvUnUrcTNOT0tHaXFCSnVzZnZmTkVMR21CYXpuNmVjdktrK3BmMU5ELy8w?=
 =?utf-8?B?QlBzYXljV25TTXVKUDNKd3R1YlMxR21INHg0dkdOQUEyTDczUGxrUlEyeUNF?=
 =?utf-8?B?M3k2ZFdESStEN3dkYjhMdDFvZmlRajFOKzZsdkN3TFJGS2dERENWMFkzZzFS?=
 =?utf-8?B?ZTlGdnovMU82N2owKzZ3OHVhMVkyeVhKMWZXS21hL2t5SUpNK09ERkJUMVpn?=
 =?utf-8?B?WG82UUx2c2ZjcTMvOUVza1gzeWpJcGtZdVVVOTE5Y0I4UGpMRXNKVmZSMDRr?=
 =?utf-8?B?QTQydlZHM240NVEwem9BZmQyM0d1WnM2REZrczlPTFRjM1R1bnRDaE9sWlJ4?=
 =?utf-8?B?ZHBuOTFSc2gxNDdlMHFkZnk4bWlhZU1YdnNuVWNaSlJLZk5rU0tvZ1p3TnF5?=
 =?utf-8?B?Uko0S3lTR2JPMExUUjhTM3cyczVseXEyUVU4eWNGRTNVNkovT09rZFl0OGZJ?=
 =?utf-8?B?dHFXNGpncHlQaXBxYytBOUFvMXpnSlA2N3Y3MVhSZHd5eXFEK2dneWdOMGVU?=
 =?utf-8?B?aS9NRGRSY0QzMHBGT3ZsVmRiZTkwVExoY09DaFdjTXJvbzQwajRHVGxoVXBN?=
 =?utf-8?B?eldEZ0x2cTZwd0toVE5iUGpRaVIvdWZzeXJlcUpoNU8zQS9aMXhIU2pJYUpV?=
 =?utf-8?B?TlNKbWtDbkdhOTBzTEhvRTNwRVJhNzZjdmpjRXNGYzdqWFU3b3FsOUxYQSt5?=
 =?utf-8?B?Y2tXSERmbCt4VTVkT0FId2hiOExFdno5cU1LM3F0TDZSTVBoaWgxWXk5SWh0?=
 =?utf-8?B?YUJPVnA3UDFNWld5WVBEUGFhTWFNSWZ5ZW5NWTVhaDFHejROTlZ1SmNwdm5o?=
 =?utf-8?B?QVdUdEF5WFJxd3VqVFRKL2xmZUU3TUtTUWMvVlg4dm1FYk01VXoreHdGL1Nk?=
 =?utf-8?B?WWhKS3p2VHB0ZTZoVkdsdDUxNyttNFpCQUJiRG9DSXFRVHMxMHNMVS81YllT?=
 =?utf-8?B?MjFxV3J4MSt4bms2V2xPNHhaeS8vMzM5VGRXOFpMSDRXOWY4bHMzajFJdldR?=
 =?utf-8?B?WE9SUGxzcUxxLzlnTW8rMWZLOTVvVFJNSS9XRDFhSm5TWTh4dmY3RmJDQm1j?=
 =?utf-8?B?NDhHSmZhbEVrejV2RGI1VDQ2WDY1TTBId2ZCeWNwdlh2ZTArS003SUJRSjl6?=
 =?utf-8?B?NnFaRDRCUktjQ25SWWg1WDNOYkE2YXUvT0sxL2JNSHVtZjBBei9adUhMM0JS?=
 =?utf-8?B?U3UvRlJLL2pUMEtOc2c3Ylh2MytVRmFSQm52dnYzTW9hRU5ybENLV0ZqMmpF?=
 =?utf-8?B?d0cveFlBZHJwYnB5U2Y2MXMrRW8xTSswbkY5TUVLYUxqMXBDbVdzajBzK3lP?=
 =?utf-8?B?VzRFZHA4QlFoTk15dTI5bGZpSk1vTVhNdklwUFpMMS8zQ3NuVWpnSzZMbW9I?=
 =?utf-8?B?dWQ4Znk5WXprS2ZpNU5DcFhkT1lEUkdFNjJWSm44R01mMU5OTndRWk8xSElo?=
 =?utf-8?B?bHRtTGtuWmxMNnM1NWxoWWdaOXpISG5iZUxRbzNiQjA1NjZ5NWpoQnVTTTB5?=
 =?utf-8?B?TkxacXY4Zk56NkxBcUo3TUYzTFB6NEJtZC9WcFlQQWhZYlJOZWt5cHJ0VlM5?=
 =?utf-8?B?cUdMMHBiM1ljd2xLZnVtWVAza3BCaFdMMzU5Z2l0a25aN0E5SXFUcmdUcWZN?=
 =?utf-8?Q?P4NQ0W4uJOAcf9RQYkGlx9O9AZeqZEEpuGg9EbT?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3612e1cb-5fbe-443f-757c-08d98e46cfd2
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2021 12:41:43.6336
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: qqqUkbbDPy7PyRV1c+AXTl7/B7kCSa49TTGnCIJwh+C5muy2XOPI7XskoeteNgeF13R2R+K98p3xhjUbfp2brA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3776

On 13.10.2021 14:30, Anthony PERARD wrote:
> On Mon, Oct 11, 2021 at 01:31:59PM +0200, Jan Beulich wrote:
>> On 24.08.2021 12:50, Anthony PERARD wrote:
>>> @@ -393,7 +406,7 @@ $(TARGET): FORCE
>>>  	$(MAKE) -f $(BASEDIR)/Rules.mk -C include
>>>  	$(MAKE) -f $(BASEDIR)/Rules.mk -C arch/$(TARGET_ARCH) include
>>>  	$(MAKE) -f $(BASEDIR)/Rules.mk arch/$(TARGET_ARCH)/include/asm/asm-offsets.h
>>> -	$(MAKE) -f $(BASEDIR)/Rules.mk -C arch/$(TARGET_ARCH) $@
>>> +	$(MAKE) -f $(BASEDIR)/Rules.mk $@
>>
>> This merely results in what was previously invoked from here now getting
>> invoked from the very bottom of build.mk. I'm afraid I don't see why this
>> is a useful change to make.
> 
> Would you rather have this following change?
> 
>     @@ -393,7 +406,8 @@ $(TARGET): FORCE
>      	$(MAKE) -f $(BASEDIR)/Rules.mk -C include
>      	$(MAKE) -f $(BASEDIR)/Rules.mk -C arch/$(TARGET_ARCH) include
>      	$(MAKE) -f $(BASEDIR)/Rules.mk arch/$(TARGET_ARCH)/include/asm/asm-offsets.h
>     +	$(MAKE) -f $(BASEDIR)/Rules.mk prelink.o
>      	$(MAKE) -f $(BASEDIR)/Rules.mk -C arch/$(TARGET_ARCH) $@
> 
> That would probably be fine.

Hmm, perhaps I'd prefer to avoid yet another $(MAKE) invocation. But
your reply made me understand why you make the change: You need to add
the prelink.o dependency to $(TARGET). That wasn't obvious to me when
first reviewing the change.

>>> --- a/xen/build.mk
>>> +++ b/xen/build.mk
>>> @@ -56,3 +56,27 @@ arch/$(TARGET_ARCH)/include/asm/asm-offsets.h: asm-offsets.s
>>>  	  sed -rne "/^[^#].*==>/{s:.*==>(.*)<==.*:\1:; s: [\$$#]: :; p;}"; \
>>>  	  echo ""; \
>>>  	  echo "#endif") <$< >$@
>>> +
>>> +# head.o is built by descending into arch/arm/$(TARGET_SUBARCH), depends on the
>>> +# part of $(ALL_OBJS) that will eventually recurse into $(TARGET_SUBARCH)/ and
>>> +# build head.o
>>> +arch/arm/$(TARGET_SUBARCH)/head.o: arch/arm/built_in.o
>>> +arch/arm/$(TARGET_SUBARCH)/head.o: ;
>>
>> This previously lived in an Arm-specific file. Moving this here in the
>> given, still Arm-specific form is imo a no-go when done alongside all
>> the other good changes you're making. Is there a reason this can't go
>> into xen/arch/arm/arch.mk?
> 
> This is temporary and it is removed in patch
>     "build: build everything from the root dir, use obj=$subdir"
> but I could move it to "arch/arm/Rules.mk" I think.

Moving there would be preferred; if that somehow doesn't work out, please
mention the temporary nature in the description, or else I (or perhaps
others) would ask the same question again on a future version of the
series.

Jan



From xen-devel-bounces@lists.xenproject.org Wed Oct 13 12:47:50 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 12:47:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.208409.364516 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1madfc-0004hr-W1; Wed, 13 Oct 2021 12:47:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 208409.364516; Wed, 13 Oct 2021 12:47:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1madfc-0004hk-T1; Wed, 13 Oct 2021 12:47:44 +0000
Received: by outflank-mailman (input) for mailman id 208409;
 Wed, 13 Oct 2021 12:47:42 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=bU9L=PB=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1madfa-0004he-Tq
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 12:47:42 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id e284e242-dd6d-4167-b31d-ef71a34819f4;
 Wed, 13 Oct 2021 12:47:42 +0000 (UTC)
Received: from EUR02-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur02lp2054.outbound.protection.outlook.com [104.47.5.54]) (Using
 TLS) by relay.mimecast.com with ESMTP id de-mta-2-bUkD4En0NxiCPVXff0aUSg-1;
 Wed, 13 Oct 2021 14:47:40 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VE1PR04MB6480.eurprd04.prod.outlook.com (2603:10a6:803:11d::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18; Wed, 13 Oct
 2021 12:47:37 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.016; Wed, 13 Oct 2021
 12:47:37 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS9PR06CA0137.eurprd06.prod.outlook.com (2603:10a6:20b:467::29) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.25 via Frontend
 Transport; Wed, 13 Oct 2021 12:47:36 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e284e242-dd6d-4167-b31d-ef71a34819f4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634129261;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=+L3dsp3QwdNKQRhFD+xf4aDzkPFA8A9ojwp1dX9GwVQ=;
	b=VeJg9H9/rfveH3tGgpHjInKcXxkA+yQpvqyvEP4K+IHsjiGu12uFr8VNiyt7kygk682TUn
	uehzZzPNPjEazGqwgOd2ou+5YUxfBC5wavovTJiUvI3KhONIAVoDuXblzPUgXBdsLhSHRV
	N1S7VvFTKBNg7HMolQSya5r0QodF/Co=
X-MC-Unique: bUkD4En0NxiCPVXff0aUSg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=TI2KWgcu7UqKZtylJrH2GQsX6k56sKYjipF3YwknoBnCs0qctWQMRD7MHo6ApipXUD6VMkETajo9QabOyA6DQ2lqLGkUVvSvRTM+E8N7hoINWD7E5zZDZ03hdW4g3Yu/fTeqQ+tEP6fHNVGpG5jK0yGCuQwobc/qX9v9hQt2haCodIugnZKtY3BY1v4IFI7Yto9jjyPBZDCEyQOHpiheZfMgbun1ckzeOAeXA8sQptQ+f357spKptI+ouUNenRNjJ6H8wYzQ6V5oHU6fYVqrYThB+fMJQ5aIkXF7uTmQc/fMKSqLiJYUeED4MfmkEEJ4/5rvxRKIzY7qNCLbcnh5OQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=jXj+/mJ+8Se/pxVKgWm8ElQM5M0xznuinDGSYgOirrU=;
 b=UHPTOVSrKd/Wx5uii8ed/c3jJTCVtscPkcQi64hbhctFw4YVQUppZeFAiQN0aQM46gu78wrp3+JMs12mJi2XW602oxET9sUoV9zH8oc2WR2GTCXibWYMSASwcff5TLEFrGp2apZAKGszpQe/s0DfDaQJlWYdlpuw21bQ/nk9X+bYC91DMLJHaGAXaHrXlWSq4u+oqlyeFmfPBTADNzzonDUI9OI+X8surONXowXZSzmzVRd4Zy/RvDBvP3iaj/wWQZw+a0rQ120tRFMM0Z266RihrIm5CZabjUwbeKlrp5eduJdtQyDNRPegZReZ8V/jMqaj/S8AQXJHIXF2HJ4HMQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: gmail.com; dkim=none (message not signed)
 header.d=none;gmail.com; dmarc=none action=none header.from=suse.com;
Subject: Re: [PATCH v3 02/11] vpci: Add hooks for PCI device assign/de-assign
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: xen-devel@lists.xenproject.org, julien@xen.org, sstabellini@kernel.org,
 oleksandr_tyshchenko@epam.com, volodymyr_babchuk@epam.com,
 Artem_Mygaiev@epam.com, bertrand.marquis@arm.com, rahul.singh@arm.com,
 Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>,
 Oleksandr Andrushchenko <andr2000@gmail.com>
References: <20210930075223.860329-1-andr2000@gmail.com>
 <20210930075223.860329-3-andr2000@gmail.com>
 <YWbDMwC+6ehmGurS@MacBook-Air-de-Roger.local>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <590e18ba-e68f-1db7-db6b-68d547387ef8@suse.com>
Date: Wed, 13 Oct 2021 14:47:34 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <YWbDMwC+6ehmGurS@MacBook-Air-de-Roger.local>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS9PR06CA0137.eurprd06.prod.outlook.com
 (2603:10a6:20b:467::29) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 97574ab2-3971-4a87-fc5d-08d98e47a28a
X-MS-TrafficTypeDiagnostic: VE1PR04MB6480:
X-Microsoft-Antispam-PRVS:
	<VE1PR04MB648029541C6F63B3DEC41B4EB3B79@VE1PR04MB6480.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:4303;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Z7jr9l3FsHX5dfy4nBM6dykfVkHfs/x/25itX7GDH+X4IX+ih4EAjTJ7kEIpajgGkJSE28rC++wPdZoLifu4TeKZ6uCTZflQNW8Oc0pvB/LT7TVaKAcG5IRzvNLnr8c/tOIQzGQXC5lp77uy4dXlk+DP66J70qQUCrQNvEy9XpNDySZ4sC/jbHd8u5T+g2Y/M1qvjBQvYBqCwAvCgK7P+42gkOPQM1JnHofY7lE3VwJeo48tIRyWDSJC6XZZ+kSOwOGpbGva9E1iSeJBPnTSQtXMmHqamUQcIGHIwQzSVuJYdVgfyi1yOcEOySonJu5RF6tPbTpRX9q0MOvtXuxNGMVBpHEMDDEVcX2Lo9kzHVSMKtxowDz867h4ckxwxWwoHpXVPLNp3rANWRSHHMNnxjHs2Wwoj0O9sZLsGh9/syA7MxpT3pLNHjKukTmVSmPQ/ZtcAxEJmJ25pw2Gcff43lQfLCo4UEUgq8rV0/NrAAcjymMVG/n6oKg1Ox7J82n3ZO1jVQ7fEVbaKuchSsmOGDGnLtEs5P5K3bm16zmvn6rdltpi/ybk54TpeKv76pPisl6nfPISPr/IxBHzyoWxB1zbBMI+fundtLySu/fSTk0QOhvQIlTgz5kJg5UQe3D3lYi3r8qxv02K5eKy5AZJhz6E+poMuB2471lBZrrpC3VM3y/bj35A2QiwA1foVX4xzNK02VkfOEFyBqlRtV8yg1oRwtgMhYyIRJi8GFx8c74=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(956004)(38100700002)(26005)(2616005)(8676002)(8936002)(7416002)(186003)(4326008)(5660300002)(53546011)(31696002)(4744005)(508600001)(86362001)(66556008)(66946007)(36756003)(2906002)(6486002)(66476007)(16576012)(54906003)(6916009)(316002)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?zTBC1KCLHAgEKf9X3Y3kOLHtDlnVZzVvuLAIXhQe5SJiF5LJQ54Vaw+DDDxX?=
 =?us-ascii?Q?QQJPLcam42hiQJCViquRL/eQ+CFM38FgjQisWVngsa6EPFvQqWtfJMtTrklE?=
 =?us-ascii?Q?lXWFlRCNBfziu1vl9Zk+q4g15r8VGwe10IqTLvytT5zdXK2NWF1XjTCTXW6I?=
 =?us-ascii?Q?NFSpqeRPKKfsN4cvV+3EhWenoU/vkHDRyTCbe7L9NMMlPDDeWcZLCnqCu94d?=
 =?us-ascii?Q?C7S9bxm+gcruCaUdcxfDR6XAYs9BQodkdgRjTLmGWJkHNrBNlp+GH9WV8MFG?=
 =?us-ascii?Q?gAn7n6Ahsw8fubXRmPNfZfPpSiDI1X5BSIUVG2r7P8hW695Fjo/z6uLljaxy?=
 =?us-ascii?Q?Z2tyTXYSApT/VaJS1wweufVNi6VqLLGgVojPhyadY4BoVZXJ6EFAlfShQknf?=
 =?us-ascii?Q?M141gGvmjWEJqa6Csy0gavqXISCGJbcy4YAolpXfO0wlYQq6w6VJCCn8+LT7?=
 =?us-ascii?Q?HJNZ+qwmiY19/S+7MQN8dCoLAl+DJ4pQi+/uh0uaRpFbjlApy2JthkG2HEbI?=
 =?us-ascii?Q?Z2mipOZLkh1f3tId0d+bHYVNk+tFdaVm4iKY2qYmkitLOjT1Mc5weQrT9QnJ?=
 =?us-ascii?Q?WBjjAjdUw8vVdQA6GsZd1/Ynf/KdDrmveZ9KLWa7ZVZSsDdtHJqXIny7h/nM?=
 =?us-ascii?Q?C5n/rFojHrD/1x+dfRhClfSUxhh2gEnKeeZX4gyAPDyA0x2CesgDeBjhd0Lk?=
 =?us-ascii?Q?Ux76ZLcUsK1PbYfXDwtJGcYvXvWyQuBLin8PZjQLFi+HEZfGW9onRPo+StCd?=
 =?us-ascii?Q?NEuJYLsPyQjrLjHLXZFFX1zIRf6ZvPsd4w6PPUP8b31U+Wg+buNCS7pKvZYd?=
 =?us-ascii?Q?IRa9QsqE5lwip0EstGzvMokllzyMjxQMyTF5xx9svLWQwWVghnsTdv0uYaw8?=
 =?us-ascii?Q?JBRe2Je+5ixZ67m+2pzOc8vXdznf0mxaNlTIE8FSqjPtk0eK4UhDuUlOOY8V?=
 =?us-ascii?Q?Bka2qcjwokHy9novXH7CpbEs3tknjGP2JFQcl/36KHtkQNXFNKL9TbvvCUJt?=
 =?us-ascii?Q?/t0wdqjFg1yECUKoohk7RM4cZ0cxL5VxuuVcP5fisK+dJUTixdsL6OfoDrST?=
 =?us-ascii?Q?7Z6nlRhGWJYRNlkqqbmSNNIua1ct0JAh9Q5zvZ6BvPwz/LqEhG0+BeE4epVm?=
 =?us-ascii?Q?NnLdaj/L0E2vyaA+cgec4Gafv23lQEzL5KX4C5GF3eucd2ZhWDs/RH2ptwFc?=
 =?us-ascii?Q?gqHAi0zmO8sx+4LFU48Ot2Vwjo3N/k+oe6oOInej2xT5HeMsZDu29N6Orq5L?=
 =?us-ascii?Q?a4Wp8Ad5k4+jkXmE186S23CSf3mqAH+7MJdP7uKpRuUZsr+oyg0NPTgUG55l?=
 =?us-ascii?Q?FS8uoyQ3L9V+YowDDhS+TSq2?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 97574ab2-3971-4a87-fc5d-08d98e47a28a
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2021 12:47:37.1594
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 7KRtuH1FmK1xai1h1WreS3BLsyEFaw55U7yFk1L6FLBC//i/Lt+MyI2A/46JGEE0YqT4oY77MpejGEhT/WMYJQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6480

On 13.10.2021 13:29, Roger Pau Monn=C3=A9 wrote:
> On Thu, Sep 30, 2021 at 10:52:14AM +0300, Oleksandr Andrushchenko wrote:
>> --- a/xen/drivers/Kconfig
>> +++ b/xen/drivers/Kconfig
>> @@ -15,4 +15,8 @@ source "drivers/video/Kconfig"
>>  config HAS_VPCI
>>  	bool
>> =20
>> +config HAS_VPCI_GUEST_SUPPORT
>> +	bool
>> +	depends on HAS_VPCI
>=20
> I would assume this is to go away once the work is finished? I don't
> think it makes sense to split vPCI code between domU/dom0 on a build
> time basis.

If by that you mean x86 side work, then maybe. I did ask for this so
that x86 wouldn't carry quite a bit of presently dead code.

Jan



From xen-devel-bounces@lists.xenproject.org Wed Oct 13 12:49:34 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 12:49:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.208416.364528 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1madhO-0005ML-Ck; Wed, 13 Oct 2021 12:49:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 208416.364528; Wed, 13 Oct 2021 12:49:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1madhO-0005ME-8s; Wed, 13 Oct 2021 12:49:34 +0000
Received: by outflank-mailman (input) for mailman id 208416;
 Wed, 13 Oct 2021 12:49:33 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1madhN-0005M8-3O
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 12:49:33 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1madhN-0004pt-1p
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 12:49:33 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1madhN-0006Ne-0r
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 12:49:33 +0000
Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89)
 (envelope-from <iwj@xenproject.org>)
 id 1madhI-0007gi-9J; Wed, 13 Oct 2021 13:49:28 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date
	:Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From;
	bh=cczmQ1mdfK2YQZDQi5HdMefgwm5HH5ryDA437dBLUpM=; b=Z+d11hUSTD5NehwNU1B9U3LKq8
	OoRPK/YeDCSaDbvYPNle883urD+ngjgYBubb1D9bNMilkM/Sp4dR63FGFd2rNqXTyct1FgWnqYb3j
	+R3Twk9rCYjCD04MXi4Nj+bj91L0AwAftl9k/0DPihFk0O3g8yXb9HiD+nHr/h1v8Lgc=;
From: Ian Jackson <iwj@xenproject.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <24934.54743.853232.853726@mariner.uk.xensource.com>
Date: Wed, 13 Oct 2021 13:49:27 +0100
To: Michal Orzel <michal.orzel@arm.com>
Cc: xen-devel@lists.xenproject.org,
    Andrew Cooper <andrew.cooper3@citrix.com>,
    George Dunlap <george.dunlap@citrix.com>,
    Jan Beulich <jbeulich@suse.com>,
    Julien Grall <julien@xen.org>,
    Stefano Stabellini <sstabellini@kernel.org>,
    Wei Liu <wl@xen.org>,
    Nick Rosbrook <rosbrookn@ainfosec.com>,
    Anthony PERARD <anthony.perard@citrix.com>,
    Juergen Gross <jgross@suse.com>,
    Christian Lindig <christian.lindig@citrix.com>,
    David Scott <dave@recoil.org>,
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
    bertrand.marquis@arm.com
Subject: Re: [PATCH v7] xen: Expose the PMU to the guests
In-Reply-To: <20211013123352.6625-1-michal.orzel@arm.com>
References: <20211013123352.6625-1-michal.orzel@arm.com>
X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu)

Michal Orzel writes ("[PATCH v7] xen: Expose the PMU to the guests"):
> Add parameter vpmu to xl domain configuration syntax
> to enable the access to PMU registers by disabling
> the PMU traps(currently only for ARM).
> 
> The current status is that the PMU registers are not
> virtualized and the physical registers are directly
> accessible when this parameter is enabled. There is no
> interrupt support and Xen will not save/restore the
> register values on context switches.
> 
> According to Arm Arm, section D7.1:
> "The Performance Monitors Extension is common
> to AArch64 operation and AArch32 operation."
> That means we have an ensurance that if PMU is
> present in one exception state, it must also be
> present in the other.
> 
> Please note that this feature is experimental.
...
> Changes since v6:
> -fix missing "HVM" for vPMU entry in SUPPORT.md

The SUPPORT.md changes LGTM, thanks.

> -Virtual Performance Management Unit for HVM guests
> +Virtual Performance Management Unit
>  
> -    Status, x86: Supported, Not security supported
> +    Status, x86 HVM: Supported, Not security supported
> +    Status, ARM: Experimental
> +
> +On ARM, support for accessing PMU registers from the guests.
> +There is no interrupt support and Xen will not save/restore
> +the register values on context switches.

FTAOD ISTM that this limitation makes the feature very hard to use
successfully on ARM.  You would need to pin vcpus to dedicated
pcpus ?

I think this is fine for an experimental feature.

I think this patch needs a ARM/hypervisor acks still.

Ian.


From xen-devel-bounces@lists.xenproject.org Wed Oct 13 12:57:36 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 12:57:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.208425.364539 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1madp0-0006nD-6u; Wed, 13 Oct 2021 12:57:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 208425.364539; Wed, 13 Oct 2021 12:57:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1madp0-0006n6-2v; Wed, 13 Oct 2021 12:57:26 +0000
Received: by outflank-mailman (input) for mailman id 208425;
 Wed, 13 Oct 2021 12:57:25 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=bU9L=PB=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1madoz-0006n0-5K
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 12:57:25 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 1bd06a75-2c25-11ec-816d-12813bfff9fa;
 Wed, 13 Oct 2021 12:57:24 +0000 (UTC)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2105.outbound.protection.outlook.com [104.47.18.105])
 (Using TLS) by relay.mimecast.com with ESMTP id
 de-mta-2-CidXsJLlPRujiVMWsFMH4g-1; Wed, 13 Oct 2021 14:57:21 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB5744.eurprd04.prod.outlook.com (2603:10a6:803:e4::24)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.19; Wed, 13 Oct
 2021 12:57:20 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.016; Wed, 13 Oct 2021
 12:57:20 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6P192CA0002.EURP192.PROD.OUTLOOK.COM (2603:10a6:209:83::15) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.16 via Frontend Transport; Wed, 13 Oct 2021 12:57:18 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1bd06a75-2c25-11ec-816d-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634129843;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=C1ayQ1zM+oi7NUlTKdU0l/k7yJ1WA71GzDRZNkrE9UQ=;
	b=YfVENhGi0NRLamhF73iIMdV1LGQNqfZtpcR42S4COLHn+kX6Wed7u2IAh1B98bfgCKUIIk
	WFv50crPqQ6iNHiMPUuiwKkfdXQQbO9v/A6P0domZOTozD6Eja0lz8jSVm72H5NxQ8OzTe
	OxQH51siZJErxpzYu+5fgvHVUaJXuLo=
X-MC-Unique: CidXsJLlPRujiVMWsFMH4g-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Vkt3SoiHp0josD+lvCUasQvfyNHmNjsTNXQYSodocRqC0DZW9s3kzTLh4ny2kC7bZLm1GVVDiC7vdpMiVrg3196LXgBbkLd+G7OvTnpDZOuAHYH86rdvCBU1zMZCpyNB9gu/CewJOaAY1QbK5qi6p/bzO8SSDXc2sxsbPYV8RXR+JXdBynUZxcDTKEGd05tJ1LEFcaheJ/spfS2hWyI/1R7NgpS0eoZkYVOHXtvtjW/ZQxUhhokEC7Eyioy/pcxavK44zLqYpjvjaT35dqCRY7B4kV5WhDqAyUrtGnOQAAhWEIU8eozAlHN9yai88/NTcTwCfJRnOxrTIjxG2nZYwg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=e2bam5u5imnGIthGQgK70v8PPO+Edd0xse5xWM6RM94=;
 b=WFFQm9maTzEmTrDFhqAq+Kdio3w8bMUT3Oy2ZigkyNUEPwmI+zUZpyvQxLBq1GvvM0zhvHNGkmdlNBYqbLn7YYQDQdU60VWTCQk9F2OA2ADmUTb7zTJ1AEnT/azwflfHmG6V/ny3uJhGPONdklnP4VO9e/PF0v3LoQYrK7+RJplLt9YmRx5QaBxF2JAfFeoTPqX45cJz0y0IP4IIDJoKqXcwbpgqH0OM+Kq/aH7r+vuELlw6u0NWhoUYUgX/WeiZLm6Vnii2kWicjGCj7r5mhZ5DMk2mTUnZlMaC/5YgYL84MuHL1Jx5JST1OUaNCchijK6TpQwfqQ/FVHZdbrsagw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: citrix.com; dkim=none (message not signed)
 header.d=none;citrix.com; dmarc=none action=none header.from=suse.com;
Subject: Re: [PATCH v5 07/11] xen/domctl: Introduce XEN_DOMCTL_CDF_vpci flag
To: Bertrand Marquis <Bertrand.Marquis@arm.com>
CC: Michal Orzel <Michal.Orzel@arm.com>, Rahul Singh <Rahul.Singh@arm.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andre Przywara <Andre.Przywara@arm.com>,
 Christian Lindig <christian.lindig@citrix.com>, David Scott
 <dave@recoil.org>, Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <cover.1633540842.git.rahul.singh@arm.com>
 <20d5b9d6a0d01a7b90711d28cbefb5701a88b438.1633540842.git.rahul.singh@arm.com>
 <YWQDguvmf/O4rDIs@MacBook-Air-de-Roger.local>
 <9217a6b8-fc53-a049-7cd3-7458b574424b@arm.com>
 <YWaZKX44IOfIBtX6@MacBook-Air-de-Roger.local>
 <8F9D6B9C-58CB-4000-995A-95517EE72A3B@arm.com>
 <YWa7eGr3D8Ax8VUX@MacBook-Air-de-Roger.local>
 <9C5C0FE2-67EA-4CD7-893B-82C156F5F77A@arm.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <e88892cf-e0c3-c39c-dce8-bfe2d25a5b53@suse.com>
Date: Wed, 13 Oct 2021 14:57:17 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <9C5C0FE2-67EA-4CD7-893B-82C156F5F77A@arm.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6P192CA0002.EURP192.PROD.OUTLOOK.COM
 (2603:10a6:209:83::15) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 5dc0b660-ac8e-4ab0-ce19-08d98e48fdff
X-MS-TrafficTypeDiagnostic: VI1PR04MB5744:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB574448723CBCC3ACEF6D0DF3B3B79@VI1PR04MB5744.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	+B/oWbBPLAhj0gMHpw3e2AsZXLJ3Q9tS/Z2P5Hf6GIc5vqllynwO4zTdE6gfG1wTjmkqfTw/64+/151GwQCRFgcGGeT0Zw2esaPBZ6N0xBbe/9IBCuPp3iMZFuvXBXpTIOLA1EB7br10XFRAGJQX9P4PD2+wQBfGH2PBitDDEM3XlHlyAb5hSguIrEMdcYUAgopaNdpYbZWUZzk/1Qq0RHwpDdsUFh+4EL2x6SuEHdrtGFXbHPcTiQLPRCEe+0Z1wxg8egk6JyZeBFaNusRWbsoqhDG+B30R7SIXqYW9OTIsAPJpB1FVUY5iRhOcC+5zvUXKeVZbGTtTq60Ac3402SwZzm30ktZl9Jg6vwTgDAJ56LQZgGAi6wIRStXd2mLUYahEWyO4FaUobBNrOpU8dgj9hZDsBWuvbTzwTo3ufLVktltzMbD1EU73ZlJcV9Tvx9N23hziC8VERQgNzEEcmFbydRp3XW9h4KIHvU+N+TGUQC9ppreDZ5u3+bw4rJulrccS3AmW2c+f90eAKDvvmTlaNFI89uUH1uMvRpUm79OkYCvLOOIHQnIMSdksjNBCJM8psDrcGeuIQQZGM6pETEyaiiiDZsbC2fL4zzvLqhRGRUNPdjiXXZ5ZsKqKOVJITpnmPS3ho1ly1NvnDxdcZRDNsczhJhM1BfH+wZBq44SCzFKkYWdD+Kk8Sd3wnfvHszHnBUvt99sMJFeDquVtiItat+5DjXR2Nc2yJmZjIis=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(86362001)(66476007)(2906002)(38100700002)(66946007)(36756003)(66556008)(6486002)(956004)(2616005)(31696002)(53546011)(8936002)(7416002)(83380400001)(26005)(508600001)(5660300002)(186003)(8676002)(316002)(54906003)(6916009)(4326008)(16576012)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?XupZCMsYGCQEYmkgzFvjJPzxKB8yDE8qrlQ2jfWx5iE8B+o2E4Xc9H3CzuED?=
 =?us-ascii?Q?GBGTmzrUmHWl61ZO4xZNDxKVHgShofaDMdczl86RmOp/XDJXWa1xJqMfsM+C?=
 =?us-ascii?Q?ME7SzKYegteOjFdzNO4zU0ah40u1GiWGcC80FIZr7Elw/jCLP4Ou5Dkhp8cf?=
 =?us-ascii?Q?+6eEXl4kOs6f2eBFp7/jxyWX8sIhf0vBI5OpzxHgOOOMllUj/RGcjNAUCIae?=
 =?us-ascii?Q?lqbDN4yintjo1layOuNKrgZEyEbnZedGAPqt8Lm8KpE1ssYxwbscpoUoePMZ?=
 =?us-ascii?Q?Shh5iNEGRn7YFxpWX99cYbJcBweFtUgbOQfGz9M8NmJwl1y2JKn+OIn0viYb?=
 =?us-ascii?Q?9H1i/noNWzFHzL9oD8GM3uaNvxsGOoeWSvbT1VxhCt9orglg1Ii+R/qG+yp4?=
 =?us-ascii?Q?mrPRBBGMpIjKrig/BLpz3Qy69/k/1NqjmS7r4/Rc6etwOUWReZqud9X7AfR3?=
 =?us-ascii?Q?JWgHDEPCv2FwTkL0Y7CM4bIU+I+k7SYcMVveCVHbuwN7Oye6sYa5xcqf5+gq?=
 =?us-ascii?Q?cnIHXpJNnX63+/+iE82KCI/m+C5E7G8MIFoUH08L5Gt432NXJ441BnZuojg/?=
 =?us-ascii?Q?Vbw5qui9PEqCdnIkvTzCH//dAEbU5QtiLgolTpu3ktY2pqMNx8uIuAqN8rFH?=
 =?us-ascii?Q?ImOC8pVxeibdI2dsbE4NvhZNdQSY3veHjBGw7M+/Ig1TO6wSvgoqZiQP0HkF?=
 =?us-ascii?Q?nY2oMt1wfnSsGzr/rMrTihvelSkTD/wuz35EmvfkLTlqomh1JoxPMw2BM3UF?=
 =?us-ascii?Q?C2IYKPuTMrK28Si3cixZKQaqFXavJx5L02jQXj3JlVM+/dV4YjJvy5yYf2Xd?=
 =?us-ascii?Q?ihvYYK7lHJEgyHsm595erYgZuBzsjUh6IKu46OVKTCtLJZeHWUMUqQUf1gvI?=
 =?us-ascii?Q?0J29KFoaxoquyolZiz3VlPgVQdRmdx4ueF4s2TyC+NcZ9GeFSoSXzrPmC2i/?=
 =?us-ascii?Q?LeN8A75GjHJgaY3UMqcpw2dyOhrWNKH3oq8hG7DLfHrBqiK6bjARo1fXfmS6?=
 =?us-ascii?Q?MmV89Kymr3vv26b5XfjZ0re7DWNcdPkMRzMUXtBCqk/vQpoBKAJ+0GDHRVx7?=
 =?us-ascii?Q?xYdMDA3N92+Z2C8tIk7YI7jx7582j14A3Lg5da/KEv8jaG3Eut7YdBDPTcke?=
 =?us-ascii?Q?R1MoGmcAASGs4yl07K4dGeyjZ+l0XylUGEvidoB6zot+ZlHlhPfdf8cyoHqs?=
 =?us-ascii?Q?CmKQ6lNiEoC7PaBwQcc43Ozrl2r1NLsZG2s1U+8NV9LQopcN41JnnZYk9Xqt?=
 =?us-ascii?Q?UPsywzCQp5dMYI3teBEJKqoAPD+i+xOt6rHcOdj1GnbHcF12JHMY1ohDjZ1u?=
 =?us-ascii?Q?v/RHhi92D1qI2l1guR1yOtnY?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5dc0b660-ac8e-4ab0-ce19-08d98e48fdff
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2021 12:57:20.1044
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: aUmhfZJgO8kdhllY7/BaEEbRLuW/rHG0rLUD5Yh/4DpwZ9CJF8QQc5Z7nFSa0fJImN0gM90cWhY/8yPYj8qa/Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5744

On 13.10.2021 14:11, Bertrand Marquis wrote:
>> On 13 Oct 2021, at 11:56, Roger Pau Monn=C3=A9 <roger.pau@citrix.com> wr=
ote:
>> If vPCI for Arm on 4.16 is not going to be functional, why so much
>> pressure in pushing those patches so fast? I understand the need to
>> remove stuff from the queue, but I don't think it's worth the cost of
>> introducing a broken interface deliberately on a release.

+1

> We did not push that fast, those have been on the mailing list for a whil=
e (this is the 5th version of the serie).
> PCI passthrough is a big change requiring lots of patches and we decided =
to push it piece by piece to make
> the review easier.

5 versions for a series like this one was to be expected. Imo it has
been wrong in the past to rush in new features (even if experimental
ones) very close to the freeze, and it has mislead people to think
they can delay work until very (too?) late a point in time.

In fact I'm getting somewhat angry seeing how much effort is put into
getting this work in (including myself doing reviews there), when at
the same time far older series of mine aren't given any chance to
make any progress. Not your fault, sure, but an observation.

Jan



From xen-devel-bounces@lists.xenproject.org Wed Oct 13 12:57:40 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 12:57:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.208426.364550 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1madpE-00077q-F4; Wed, 13 Oct 2021 12:57:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 208426.364550; Wed, 13 Oct 2021 12:57:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1madpE-00077b-C2; Wed, 13 Oct 2021 12:57:40 +0000
Received: by outflank-mailman (input) for mailman id 208426;
 Wed, 13 Oct 2021 12:57:39 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1madpC-00076t-Vn; Wed, 13 Oct 2021 12:57:38 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1madpC-0004zP-P3; Wed, 13 Oct 2021 12:57:38 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1madpC-00026t-Fi; Wed, 13 Oct 2021 12:57:38 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1madpC-0007dd-FB; Wed, 13 Oct 2021 12:57:38 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=0w0OwA5uyXKBs7qQKf3DsxnHRSKVJ2mVHAuHMXR8wpw=; b=GlVZggZJbGdoghWoNmp8NHiRrv
	Ci933wTeIBzXQQqFWsIoSYbP8zU/4mZbfgYP3W0ahuONazuGNd79/FMWlodE8WzyBphrhdvv6PMq3
	EPcXleWI4rxelzSPOcjkpdr4XymNt285+lbACP44aK3oxtLyjEaXGTWmKW6Ck9RtEvTg=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165489-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 165489: regressions - FAIL
X-Osstest-Failures:
    libvirt:build-armhf-libvirt:libvirt-build:fail:regression
    libvirt:build-amd64-libvirt:libvirt-build:fail:regression
    libvirt:build-arm64-libvirt:libvirt-build:fail:regression
    libvirt:build-i386-libvirt:libvirt-build:fail:regression
    libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    libvirt=926864ba453b23286f4a90c5ed57c74ce95d97dc
X-Osstest-Versions-That:
    libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 13 Oct 2021 12:57:38 +0000

flight 165489 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165489/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-armhf-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-amd64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-arm64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-i386-libvirt            6 libvirt-build            fail REGR. vs. 151777

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-libvirt-vhd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a

version targeted for testing:
 libvirt              926864ba453b23286f4a90c5ed57c74ce95d97dc
baseline version:
 libvirt              2c846fa6bcc11929c9fb857a22430fb9945654ad

Last test of basis   151777  2020-07-10 04:19:19 Z  460 days
Failing since        151818  2020-07-11 04:18:52 Z  459 days  445 attempts
Testing same since   165489  2021-10-13 04:20:11 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
    Adolfo Jayme Barrientos <fitoschido@gmail.com>
  Aleksandr Alekseev <alexander.alekseev@virtuozzo.com>
  Aleksei Zakharov <zaharov@selectel.ru>
  Andika Triwidada <andika@gmail.com>
  Andrea Bolognani <abologna@redhat.com>
  Ani Sinha <ani@anisinha.ca>
  Balázs Meskó <meskobalazs@mailbox.org>
  Barrett Schonefeld <bschoney@utexas.edu>
  Bastian Germann <bastiangermann@fishpost.de>
  Bastien Orivel <bastien.orivel@diateam.net>
  BiaoXiang Ye <yebiaoxiang@huawei.com>
  Bihong Yu <yubihong@huawei.com>
  Binfeng Wu <wubinfeng@huawei.com>
  Bjoern Walk <bwalk@linux.ibm.com>
  Boris Fiuczynski <fiuczy@linux.ibm.com>
  Brian Turek <brian.turek@gmail.com>
  Bruno Haible <bruno@clisp.org>
  Chris Mayo <aklhfex@gmail.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Ehrhardt <christian.ehrhardt@canonical.com>
  Christian Kirbach <christian.kirbach@gmail.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Cole Robinson <crobinso@redhat.com>
  Collin Walling <walling@linux.ibm.com>
  Cornelia Huck <cohuck@redhat.com>
  Cédric Bosdonnat <cbosdonnat@suse.com>
  Côme Borsoi <fedora@borsoi.fr>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniel Letai <dani@letai.org.il>
  Daniel P. Berrange <berrange@redhat.com>
  Daniel P. Berrangé <berrange@redhat.com>
  Didik Supriadi <didiksupriadi41@gmail.com>
  dinglimin <dinglimin@cmss.chinamobile.com>
  Dmytro Linkin <dlinkin@nvidia.com>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Eric Farman <farman@linux.ibm.com>
  Erik Skultety <eskultet@redhat.com>
  Fabian Affolter <mail@fabian-affolter.ch>
  Fabian Freyer <fabian.freyer@physik.tu-berlin.de>
  Fabiano Fidêncio <fabiano@fidencio.org>
  Fangge Jin <fjin@redhat.com>
  Farhan Ali <alifm@linux.ibm.com>
  Fedora Weblate Translation <i18n@lists.fedoraproject.org>
  gongwei <gongwei@smartx.com>
  Guoyi Tu<tu.guoyi@h3c.com>
  Göran Uddeborg <goeran@uddeborg.se>
  Halil Pasic <pasic@linux.ibm.com>
  Han Han <hhan@redhat.com>
  Hao Wang <wanghao232@huawei.com>
  Hela Basa <r45xveza@pm.me>
  Helmut Grohne <helmut@subdivi.de>
  Hiroki Narukawa <hnarukaw@yahoo-corp.jp>
  Ian Wienand <iwienand@redhat.com>
  Jakob Meng <jakobmeng@web.de>
  Jamie Strandboge <jamie@canonical.com>
  Jamie Strandboge <jamie@ubuntu.com>
  Jan Kuparinen <copper_fin@hotmail.com>
  jason lee <ppark5237@gmail.com>
  Jean-Baptiste Holcroft <jean-baptiste@holcroft.fr>
  Jia Zhou <zhou.jia2@zte.com.cn>
  Jianan Gao <jgao@redhat.com>
  Jim Fehlig <jfehlig@suse.com>
  Jin Yan <jinyan12@huawei.com>
  Jinsheng Zhang <zhangjl02@inspur.com>
  Jiri Denemark <jdenemar@redhat.com>
  John Ferlan <jferlan@redhat.com>
  Jonathan Watt <jwatt@jwatt.org>
  Jonathon Jongsma <jjongsma@redhat.com>
  Julio Faracco <jcfaracco@gmail.com>
  Justin Gatzen <justin.gatzen@gmail.com>
  Ján Tomko <jtomko@redhat.com>
  Kashyap Chamarthy <kchamart@redhat.com>
  Kevin Locke <kevin@kevinlocke.name>
  Kristina Hanicova <khanicov@redhat.com>
  Laine Stump <laine@redhat.com>
  Laszlo Ersek <lersek@redhat.com>
  Lee Yarwood <lyarwood@redhat.com>
  Lei Yang <yanglei209@huawei.com>
  Liao Pingfang <liao.pingfang@zte.com.cn>
  Lin Ma <lma@suse.com>
  Lin Ma <lma@suse.de>
  Lin Ma <morecache@gmail.com>
  Liu Yiding <liuyd.fnst@fujitsu.com>
  Luke Yue <lukedyue@gmail.com>
  Luyao Zhong <luyao.zhong@intel.com>
  Marc Hartmayer <mhartmay@linux.ibm.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Markus Schade <markus.schade@hetzner.com>
  Martin Kletzander <mkletzan@redhat.com>
  Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
  Matej Cepl <mcepl@cepl.eu>
  Matt Coleman <matt@datto.com>
  Matt Coleman <mcoleman@datto.com>
  Mauro Matteo Cascella <mcascell@redhat.com>
  Meina Li <meili@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Michał Smyk <fedora@smyk.it>
  Milo Casagrande <milo@milo.name>
  Moshe Levi <moshele@nvidia.com>
  Muha Aliss <muhaaliss@gmail.com>
  Nathan <nathan95@live.it>
  Neal Gompa <ngompa13@gmail.com>
  Nick Chevsky <nchevsky@gmail.com>
  Nick Shyrokovskiy <nshyrokovskiy@gmail.com>
  Nickys Music Group <nickys.music.group@gmail.com>
  Nico Pache <npache@redhat.com>
  Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
  Olaf Hering <olaf@aepfle.de>
  Olesya Gerasimenko <gammaray@basealt.ru>
  Orion Poplawski <orion@nwra.com>
  Pany <geekpany@gmail.com>
  Patrick Magauran <patmagauran.j@gmail.com>
  Paulo de Rezende Pinatti <ppinatti@linux.ibm.com>
  Pavel Hrdina <phrdina@redhat.com>
  Peng Liang <liangpeng10@huawei.com>
  Peter Krempa <pkrempa@redhat.com>
  Pino Toscano <ptoscano@redhat.com>
  Pino Toscano <toscano.pino@tiscali.it>
  Piotr Drąg <piotrdrag@gmail.com>
  Prathamesh Chavan <pc44800@gmail.com>
  Praveen K Paladugu <prapal@linux.microsoft.com>
  Richard W.M. Jones <rjones@redhat.com>
  Ricky Tigg <ricky.tigg@gmail.com>
  Robin Lee <cheeselee@fedoraproject.org>
  Roman Bogorodskiy <bogorodskiy@gmail.com>
  Roman Bolshakov <r.bolshakov@yadro.com>
  Ryan Gahagan <rgahagan@cs.utexas.edu>
  Ryan Schmidt <git@ryandesign.com>
  Sam Hartman <hartmans@debian.org>
  Scott Shambarger <scott-libvirt@shambarger.net>
  Sebastian Mitterle <smitterl@redhat.com>
  SeongHyun Jo <caelus9536@gmail.com>
  Shalini Chellathurai Saroja <shalini@linux.ibm.com>
  Shaojun Yang <yangshaojun@phytium.com.cn>
  Shi Lei <shi_lei@massclouds.com>
  simmon <simmon@nplob.com>
  Simon Chopin <chopin.simon@gmail.com>
  Simon Gaiser <simon@invisiblethingslab.com>
  Simon Rowe <simon.rowe@nutanix.com>
  Stefan Bader <stefan.bader@canonical.com>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Berger <stefanb@linux.vnet.ibm.com>
  Stefan Hajnoczi <stefanha@gmail.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Szymon Scholz <szymonscholz@gmail.com>
  Thomas Huth <thuth@redhat.com>
  Tim Wiederhake <twiederh@redhat.com>
  Tomáš Golembiovský <tgolembi@redhat.com>
  Tomáš Janoušek <tomi@nomi.cz>
  Tuguoyi <tu.guoyi@h3c.com>
  Victor Toso <victortoso@redhat.com>
  Ville Skyttä <ville.skytta@iki.fi>
  Vinayak Kale <vkale@nvidia.com>
  Wang Xin <wangxinxin.wang@huawei.com>
  WangJian <wangjian161@huawei.com>
  Weblate <noreply@weblate.org>
  Wei Liu <liuwe@microsoft.com>
  Wei Liu <wei.liu@kernel.org>
  Wei-Chen Chen <weicche@microsoft.com>
  William Douglas <william.douglas@intel.com>
  Yalei Li <274268859@qq.com>
  Yalei Li <liyl43@chinatelecom.cn>
  Yang Fei <yangfei85@huawei.com>
  Yang Hang <yanghang44@huawei.com>
  Yanqiu Zhang <yanqzhan@redhat.com>
  Yaroslav Kargin <ykargin@virtuozzo.com>
  Yi Li <yili@winhong.com>
  Yi Wang <wang.yi59@zte.com.cn>
  Yuri Chornoivan <yurchor@ukr.net>
  Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
  zhangjl02 <zhangjl02@inspur.com>
  Zheng Chuan <zhengchuan@huawei.com>
  zhenwei pi <pizhenwei@bytedance.com>
  Zhenyu Ye <yezhenyu2@huawei.com>
  Zhenyu Zheng <zheng.zhenyu@outlook.com>
  Zhenzhong Duan <zhenzhong.duan@intel.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          fail    
 build-arm64-libvirt                                          fail    
 build-armhf-libvirt                                          fail    
 build-i386-libvirt                                           fail    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           blocked 
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-libvirt-xsm                                 blocked 
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-libvirt                                     blocked 
 test-arm64-arm64-libvirt                                     blocked 
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-libvirt-pair                                blocked 
 test-amd64-i386-libvirt-pair                                 blocked 
 test-arm64-arm64-libvirt-qcow2                               blocked 
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-libvirt-vhd                                 blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 79424 lines long.)


From xen-devel-bounces@lists.xenproject.org Wed Oct 13 13:00:43 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 13:00:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.208442.364564 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1madsA-0000Sq-6d; Wed, 13 Oct 2021 13:00:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 208442.364564; Wed, 13 Oct 2021 13:00:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1madsA-0000Sj-2x; Wed, 13 Oct 2021 13:00:42 +0000
Received: by outflank-mailman (input) for mailman id 208442;
 Wed, 13 Oct 2021 13:00:41 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=bU9L=PB=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mads9-0000Sb-5O
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 13:00:41 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id cfc8b3e0-f958-4c2f-b927-e5914da911e6;
 Wed, 13 Oct 2021 13:00:39 +0000 (UTC)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2176.outbound.protection.outlook.com [104.47.17.176])
 (Using TLS) by relay.mimecast.com with ESMTP id
 de-mta-34-N1_L9VSXP3i7-xaJRHG7wg-1; Wed, 13 Oct 2021 15:00:36 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0402MB2829.eurprd04.prod.outlook.com (2603:10a6:800:bb::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.22; Wed, 13 Oct
 2021 13:00:34 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.016; Wed, 13 Oct 2021
 13:00:34 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM5PR0502CA0020.eurprd05.prod.outlook.com (2603:10a6:203:91::30) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.14 via Frontend
 Transport; Wed, 13 Oct 2021 13:00:33 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: cfc8b3e0-f958-4c2f-b927-e5914da911e6
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634130038;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=4VyVluTRqKT14ELS2y4ZMpGkwITEoVGr2e9Bb4p9iX8=;
	b=f0/YYjrwINCdx7NWuurRA0AtUA6hOGpcAFSCv8vPyXbgdJjHis1K0JMIGJxQytvyd77fcd
	bU3DzpCqH1g+OysCiJhoYNTCY8UCnQHMTkycgDqxS3ZeW1z8gESCgLf3gNi8o9VykORYyI
	s7WqIZV23bKmUl/dJORB1PTzIbXSRCo=
X-MC-Unique: N1_L9VSXP3i7-xaJRHG7wg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=XEYPlEgi/NSuOpQZmKTeCOkwt6oaeVobp+JO1RdvePbIQ0+CK8ddEEY+IaCPXiy38ocfbrXYrPJ5FXWqtfKvPwjhigjnbGsvWaGb6oLtB7n4NhWIeUiGkVseuKgTzBSzZjo4ha4F+knixltFs2B6tI/es9EgSRk4Ump8RHHM2KHzUq1hAOE4ar3z+gwNlzw1mIV9koFFBxO4D3/cq31+DtwxuGv9b7fCcPyInlFjxP7QvWJWMGCGh5en1RU9UNT+aldoAqYpuCmqb7pBqY9zj8WsJlFdO9mJR+1iNzmMG7fdnzTocCLLnWKvkCDyLIHocNKBGYfsk72onczYetMBcQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=N8EvZXJdYVCFlihcUAfhn7/osXbmXyMtmYK83JD1Gm4=;
 b=QhrmVhgWFl90ouN/Xc6bZH089zkilAU7C4KTMC6MCLfo7FNGgbJpW+ZXEryLsr0SOfH+nEgeBALaLa20o6302WGRtv+290OGmi1YdV+uGFTWilsAs2AK50EFwDEEkgeLaqMaz5DNPdYbvBKJsOfbxXmu1LjtSCJJKgyv9ZgYGHKJzXURcI3muRuyXxLm1qxJ6dCqlYPTPU557pQlfuZGodCXwHWsw2wYqr+DDB/6PqD9hugCuV8lHdPo96AilKxBlt1jgXj+Rw9ZDZq0l+Mxdl/1c6b67jVXMzcEFs77CuvhB7tBCg8mAD+rf9uegz27e86BBg/G0kAKAVv0U1tvXA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: xen.org; dkim=none (message not signed)
 header.d=none;xen.org; dmarc=none action=none header.from=suse.com;
Subject: Re: [PATCH v5 08/11] xen/arm: Enable the existing x86 virtual PCI
 support for ARM.
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Rahul Singh <rahul.singh@arm.com>
CC: xen-devel@lists.xenproject.org, bertrand.marquis@arm.com,
 Andre.Przywara@arm.com, Stefano Stabellini <sstabellini@kernel.org>,
 Julien Grall <julien@xen.org>, Volodymyr Babchuk
 <Volodymyr_Babchuk@epam.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Wei Liu <wl@xen.org>, Paul Durrant <paul@xen.org>
References: <cover.1633540842.git.rahul.singh@arm.com>
 <9bdca2cda5d2e83f94dc2423e55714273539760a.1633540842.git.rahul.singh@arm.com>
 <YWaco/UvA4xFE1xW@MacBook-Air-de-Roger.local>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <6d75f604-6938-b185-61e1-a6684d9fca14@suse.com>
Date: Wed, 13 Oct 2021 15:00:31 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <YWaco/UvA4xFE1xW@MacBook-Air-de-Roger.local>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM5PR0502CA0020.eurprd05.prod.outlook.com
 (2603:10a6:203:91::30) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 85de10c3-ea5e-4515-59d8-08d98e49718e
X-MS-TrafficTypeDiagnostic: VI1PR0402MB2829:
X-Microsoft-Antispam-PRVS:
	<VI1PR0402MB28299DC54FDEB3EA99CE1C88B3B79@VI1PR0402MB2829.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	NkU2xCyC56dTuqEoHKKw7AG9NSBBR4ewPpAmMy5AJo71aZvDViJzXNCTKMrAHr45ZpJwgPshWyWBYS9NaG1WVMf75GI8PjHymX2eMhn2jOAt7FaEi24WMcOi/oxti9EyNrPkMx0VEBb/a7za5dq1gZnd1nf3dvgJi3R5fcvEfctZKdRQ/pxHb8HuCU3cpEpQULkHTVTZN1txu6xfGajgDELnXEB0y2spQmI47i34E4cWJTslkHqqCtmc1SDjUUk/ypf/LVQ9raHVxpRqQJJRtrXt2rSy3bqbifHWyOS8f73iToBOoe+YFe6qiwEvI9x8RWrTm/3GJULbHISbkXzkpI2YMmUzqMQ+9HboqzVg4uDr+fQ0gIwm3Rz/YaMcmUxtiMSNtQ1ZTpqkCf5TD8clO9wD6m0DWB31x1nr9F+xK4PKp2j/l+bdrf4mLywxMMKcenHIT1dxYQNWplcx3YkTbS2ZWlnCTxDtfki3MEcLC4TKfrzEd0SVUYOsRNviVAdI5bhWnXW76K3OI7mNBXFToO2l3EN7ML8csoCNhKam5PqHl9zp78UQQ5PTfI5Itt2uaHOAImErAhopQju0ClkDyL2wdoKy3I/8/LHr/v+0eLFMcb6/G+8OJHqvhzHnDY3scy8WcXS9GYYU8nIdlbDP+fz/wRGENzvr3Gqj+aWocmfwkD2JLDtpmuaYHFRheUFhKzkQlnDYP84lLF+QwzOmA5krxdo+Xq5m/iZkHrgMgPVOBdFSrHXoJVCyWD1aGkEd
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(36756003)(110136005)(8676002)(16576012)(7416002)(4326008)(54906003)(66476007)(5660300002)(316002)(2616005)(31686004)(2906002)(6486002)(66556008)(66946007)(956004)(26005)(8936002)(508600001)(83380400001)(186003)(53546011)(31696002)(38100700002)(86362001)(2004002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?mOnSReIFiXGdQ8z22Pec6qAKbGCJER7Ca5gW74BG3Hj9/n5MHhexWxNOYmd5?=
 =?us-ascii?Q?XGl/zBFLSVDtxFZ+7X0zW/nOESCBZdsHgoKurFIuDeifl8rK9jIav5GDFCWY?=
 =?us-ascii?Q?2b97Hii497QPmpvLm/uPfw2DxNetn3MWu4QroxdySWjuVvVL5G9to533grSy?=
 =?us-ascii?Q?OkVLHd/yBjYk8pQ6N/jSD+AgNd5Cb8synO8Ud6OLzYrIXYHWqiDupQrn8Vl9?=
 =?us-ascii?Q?e7k47bQn5uiBWKlvCcCQidCqXDRXiJPYXLqRSN2ej0ubbgZs9bJHqkq/YbSY?=
 =?us-ascii?Q?U5vZApYtmCJlsmumNt2zZ3gvkBQrn6RXywYgMieFygZxNvOWzWuXkgq5K8Yz?=
 =?us-ascii?Q?obcBQFlmH/NF255jY0yHLk0yKPJm3+3UBFMWLG2my6FSPUHmVGhAK6Td4ob/?=
 =?us-ascii?Q?kcKaw089PzU95UiEPJjUG3nTonOdNLRyk3JVvL4nhwhBsfNT5yTsyFhADcYF?=
 =?us-ascii?Q?/uvSVQ+UDCPMnmGnzr6UFYWJKMQGQijvYIx+/RzeUTp3QdmozOLibhGhqNH8?=
 =?us-ascii?Q?VVjtTBIbTNzKFvh9BoR7pxujDANIwmrWVJJ2EEQgxSEEygccQAngbtYXU8Ta?=
 =?us-ascii?Q?1sSlwx0gSORq003K/emUDBICVjspN5NQ/7dcZ2JtGPtE1/qiJfopPVpTVOQA?=
 =?us-ascii?Q?qZ3EdEaH8+WU/8imHuciHQ9LsbfQtx5yDenm1Vd9At4wiuFxOcab5tOetVnA?=
 =?us-ascii?Q?YHlILg3BpOevKJfmFBZTXcohZRTNgLWk3d3s2mZ9vib6FIgyErjmHGa8a9gS?=
 =?us-ascii?Q?rsurQHHzap8uHJR04Yl0wAgQ8jGNb4mt5ZvISLvedM682BJmPkDZhlqfR9AQ?=
 =?us-ascii?Q?3V7Qp1jCL5O8X0kVuusA8e5stU2Hy/CqeAwtGLsqyHb4yhnjKav6VD/yOf4T?=
 =?us-ascii?Q?kx2Exe1ohJusP9A3zhfow8K/LiYt3UIJdaoesecFqzE/FTJIx7I8oXjt/x1s?=
 =?us-ascii?Q?H33Urnv7QDL1YM9WItYE9aLeuS2qKQ30/AJz3bV6NXR2ECg+OJFTsUQ8oJ2W?=
 =?us-ascii?Q?2RUXXxBBuv48lmT9W4eYnGP0I+2J0a5ZvKvZtzDBZah3gDYW4Fxuj4Utp22W?=
 =?us-ascii?Q?QGdiZGG/6M+pk67W5NbicO8aHmzffj4b7qYXs+iUHCex44LXgPQH/e8O/Ix7?=
 =?us-ascii?Q?DdALaQjHekJD+WpkjzQA/Y667QRuWn59iwHXUavJK1hWM8Emg4A4CDMoJvpr?=
 =?us-ascii?Q?O04Ahp3YzVz201UaVbR1HfeLwFoM3wAK7NUpDIQI9oMiBhPwgjZXxKBBJLHr?=
 =?us-ascii?Q?+OWukg9z5mvZ/rq+Keex9Xk4gtaKv6+dVsWtPH+kgB9Lq0+Vfj67MqwvIVGv?=
 =?us-ascii?Q?nqybS3TQxRMnhbUX2tXbku/L?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 85de10c3-ea5e-4515-59d8-08d98e49718e
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2021 13:00:33.9626
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kCYH/NoONCCTGSst4eqkUBRBuHgAj0szLOTwTpIyNj51HmsKKaw4hl78jF+mUap+iEgWbkhAUe2F/50i9wgaeQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB2829

On 13.10.2021 10:45, Roger Pau Monn=C3=A9 wrote:
> On Wed, Oct 06, 2021 at 06:40:34PM +0100, Rahul Singh wrote:
>> The existing VPCI support available for X86 is adapted for Arm.
>> When the device is added to XEN via the hyper call
>> =E2=80=9CPHYSDEVOP_pci_device_add=E2=80=9D, VPCI handler for the config =
space
>> access is added to the Xen to emulate the PCI devices config space.
>>
>> A MMIO trap handler for the PCI ECAM space is registered in XEN
>> so that when guest is trying to access the PCI config space,XEN
>> will trap the access and emulate read/write using the VPCI and
>> not the real PCI hardware.
>>
>> For Dom0less systems scan_pci_devices() would be used to discover the
>> PCI device in XEN and VPCI handler will be added during XEN boots.
>>
>> Signed-off-by: Rahul Singh <rahul.singh@arm.com>
>> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
>> ---
>> Change in v5:
>> - Add pci_cleanup_msi(pdev) in cleanup part.
>> - Added Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
>> Change in v4:
>> - Move addition of XEN_DOMCTL_CDF_vpci flag to separate patch
>> Change in v3:
>> - Use is_pci_passthrough_enabled() in place of pci_passthrough_enabled v=
ariable
>> - Reject XEN_DOMCTL_CDF_vpci for x86 in arch_sanitise_domain_config()
>> - Remove IS_ENABLED(CONFIG_HAS_VPCI) from has_vpci()
>> Change in v2:
>> - Add new XEN_DOMCTL_CDF_vpci flag
>> - modify has_vpci() to include XEN_DOMCTL_CDF_vpci
>> - enable vpci support when pci-passthough option is enabled.
>> ---
>> ---
>>  xen/arch/arm/Makefile         |   1 +
>>  xen/arch/arm/domain.c         |   4 ++
>>  xen/arch/arm/domain_build.c   |   3 +
>>  xen/arch/arm/vpci.c           | 102 ++++++++++++++++++++++++++++++++++
>>  xen/arch/arm/vpci.h           |  36 ++++++++++++
>>  xen/drivers/passthrough/pci.c |  18 ++++++
>>  xen/include/asm-arm/domain.h  |   7 ++-
>>  xen/include/asm-x86/pci.h     |   2 -
>>  xen/include/public/arch-arm.h |   7 +++
>>  xen/include/xen/pci.h         |   2 +
>>  10 files changed, 179 insertions(+), 3 deletions(-)
>>  create mode 100644 xen/arch/arm/vpci.c
>>  create mode 100644 xen/arch/arm/vpci.h
>>
>> diff --git a/xen/arch/arm/Makefile b/xen/arch/arm/Makefile
>> index 44d7cc81fa..fb9c976ea2 100644
>> --- a/xen/arch/arm/Makefile
>> +++ b/xen/arch/arm/Makefile
>> @@ -7,6 +7,7 @@ ifneq ($(CONFIG_NO_PLAT),y)
>>  obj-y +=3D platforms/
>>  endif
>>  obj-$(CONFIG_TEE) +=3D tee/
>> +obj-$(CONFIG_HAS_VPCI) +=3D vpci.o
>> =20
>>  obj-$(CONFIG_HAS_ALTERNATIVE) +=3D alternative.o
>>  obj-y +=3D bootfdt.init.o
>> diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
>> index 36138c1b2e..fbb52f78f1 100644
>> --- a/xen/arch/arm/domain.c
>> +++ b/xen/arch/arm/domain.c
>> @@ -39,6 +39,7 @@
>>  #include <asm/vgic.h>
>>  #include <asm/vtimer.h>
>> =20
>> +#include "vpci.h"
>>  #include "vuart.h"
>> =20
>>  DEFINE_PER_CPU(struct vcpu *, curr_vcpu);
>> @@ -767,6 +768,9 @@ int arch_domain_create(struct domain *d,
>>      if ( is_hardware_domain(d) && (rc =3D domain_vuart_init(d)) )
>>          goto fail;
>> =20
>> +    if ( (rc =3D domain_vpci_init(d)) !=3D 0 )
>> +        goto fail;
>> +
>>      return 0;
>> =20
>>  fail:
>> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
>> index c5afbe2e05..f4c89bde8c 100644
>> --- a/xen/arch/arm/domain_build.c
>> +++ b/xen/arch/arm/domain_build.c
>> @@ -3053,6 +3053,9 @@ void __init create_dom0(void)
>>      if ( iommu_enabled )
>>          dom0_cfg.flags |=3D XEN_DOMCTL_CDF_iommu;
>> =20
>> +    if ( is_pci_passthrough_enabled() )
>> +        dom0_cfg.flags |=3D XEN_DOMCTL_CDF_vpci;
>> +
>>      dom0 =3D domain_create(0, &dom0_cfg, true);
>>      if ( IS_ERR(dom0) || (alloc_dom0_vcpu0(dom0) =3D=3D NULL) )
>>          panic("Error creating domain 0\n");
>> diff --git a/xen/arch/arm/vpci.c b/xen/arch/arm/vpci.c
>> new file mode 100644
>> index 0000000000..76c12b9281
>> --- /dev/null
>> +++ b/xen/arch/arm/vpci.c
>> @@ -0,0 +1,102 @@
>> +/*
>> + * xen/arch/arm/vpci.c
>> + *
>> + * This program is free software; you can redistribute it and/or modify
>> + * it under the terms of the GNU General Public License as published by
>> + * the Free Software Foundation; either version 2 of the License, or
>> + * (at your option) any later version.
>> + *
>> + * This program is distributed in the hope that it will be useful,
>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>> + * GNU General Public License for more details.
>> + */
>> +#include <xen/sched.h>
>> +
>> +#include <asm/mmio.h>
>> +
>> +#define REGISTER_OFFSET(addr)  ( (addr) & 0x00000fff)
>> +
>> +/* Do some sanity checks. */
>> +static bool vpci_mmio_access_allowed(unsigned int reg, unsigned int len=
)
>> +{
>> +    /* Check access size. */
>> +    if ( len > 8 )
>> +        return false;
>> +
>> +    /* Check that access is size aligned. */
>> +    if ( (reg & (len - 1)) )
>> +        return false;
>> +
>> +    return true;
>> +}
>> +
>> +static int vpci_mmio_read(struct vcpu *v, mmio_info_t *info,
>> +                          register_t *r, void *p)
>> +{
>> +    unsigned int reg;
>> +    pci_sbdf_t sbdf;
>> +    unsigned long data =3D ~0UL;
>> +    unsigned int size =3D 1U << info->dabt.size;
>> +
>> +    sbdf.sbdf =3D MMCFG_BDF(info->gpa);
>> +    reg =3D REGISTER_OFFSET(info->gpa);
>> +
>> +    if ( !vpci_mmio_access_allowed(reg, size) )
>> +        return 0;
>> +
>> +    data =3D vpci_read(sbdf, reg, min(4u, size));
>> +    if ( size =3D=3D 8 )
>> +        data |=3D (uint64_t)vpci_read(sbdf, reg + 4, 4) << 32;
>> +
>> +    *r =3D data;
>> +
>> +    return 1;
>> +}
>> +
>> +static int vpci_mmio_write(struct vcpu *v, mmio_info_t *info,
>> +                           register_t r, void *p)
>> +{
>> +    unsigned int reg;
>> +    pci_sbdf_t sbdf;
>> +    unsigned long data =3D r;
>> +    unsigned int size =3D 1U << info->dabt.size;
>> +
>> +    sbdf.sbdf =3D MMCFG_BDF(info->gpa);
>> +    reg =3D REGISTER_OFFSET(info->gpa);
>> +
>> +    if ( !vpci_mmio_access_allowed(reg, size) )
>> +        return 0;
>> +
>> +    vpci_write(sbdf, reg, min(4u, size), data);
>> +    if ( size =3D=3D 8 )
>> +        vpci_write(sbdf, reg + 4, 4, data >> 32);
>=20
> I think those two helpers (and vpci_mmio_access_allowed) are very
> similar to the existing x86 ones (see vpci_mmcfg_{read,write}), up to
> the point where I would consider moving the shared code to vpci.c as
> vpci_ecam_{read,write} and call them from the arch specific trap
> handlers.

Except that please can we stick to mcfg or mmcfg instead of ecam
in names, as that's how the thing has been named in Xen from its
introduction? I've just grep-ed the code base (case insensitively)
and found no mention of ECAM. There are only a few "became".

Jan



From xen-devel-bounces@lists.xenproject.org Wed Oct 13 13:12:12 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 13:12:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.208451.364574 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mae3C-0001yg-98; Wed, 13 Oct 2021 13:12:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 208451.364574; Wed, 13 Oct 2021 13:12:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mae3C-0001yZ-5t; Wed, 13 Oct 2021 13:12:06 +0000
Received: by outflank-mailman (input) for mailman id 208451;
 Wed, 13 Oct 2021 13:12:05 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mae3B-0001yT-3B
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 13:12:05 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mae39-0005Hy-7k; Wed, 13 Oct 2021 13:12:03 +0000
Received: from 54-240-197-234.amazon.com ([54.240.197.234]
 helo=[192.168.17.188]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mae39-0000C8-0o; Wed, 13 Oct 2021 13:12:03 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=5PJWoDUK/Rr0ZsQ7XsqDOWVB68fWASA5VWj02ABvHVU=; b=2zu0C0Y79w2m+dYQGCYPVV7blL
	HyMemfBlE0aNXgo5y7A0fp+Jz8/GiU80YMyxt0iYteQS/bpkOnf+tGQwYLkh5VzxX3vI8265laXwS
	UE7pklT7PKIE/u1pdSiKh7t2D49azAVxoKSIz/E+KOr8A6USiA1oDq7a2N/3wYSgcvrw=;
Message-ID: <bcdf096c-aeaa-5d5f-fffc-95719c7b4038@xen.org>
Date: Wed, 13 Oct 2021 14:11:59 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.2.0
Subject: Re: [PATCH v7] xen: Expose the PMU to the guests
To: Ian Jackson <iwj@xenproject.org>, Michal Orzel <michal.orzel@arm.com>
Cc: xen-devel@lists.xenproject.org, Andrew Cooper
 <andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>,
 Jan Beulich <jbeulich@suse.com>, Stefano Stabellini
 <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 Nick Rosbrook <rosbrookn@ainfosec.com>,
 Anthony PERARD <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>,
 Christian Lindig <christian.lindig@citrix.com>, David Scott
 <dave@recoil.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 bertrand.marquis@arm.com
References: <20211013123352.6625-1-michal.orzel@arm.com>
 <24934.54743.853232.853726@mariner.uk.xensource.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <24934.54743.853232.853726@mariner.uk.xensource.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Ian,

On 13/10/2021 13:49, Ian Jackson wrote:
> Michal Orzel writes ("[PATCH v7] xen: Expose the PMU to the guests"):
>> Add parameter vpmu to xl domain configuration syntax
>> to enable the access to PMU registers by disabling
>> the PMU traps(currently only for ARM).
>>
>> The current status is that the PMU registers are not
>> virtualized and the physical registers are directly
>> accessible when this parameter is enabled. There is no
>> interrupt support and Xen will not save/restore the
>> register values on context switches.
>>
>> According to Arm Arm, section D7.1:
>> "The Performance Monitors Extension is common
>> to AArch64 operation and AArch32 operation."
>> That means we have an ensurance that if PMU is
>> present in one exception state, it must also be
>> present in the other.
>>
>> Please note that this feature is experimental.
> ...
>> Changes since v6:
>> -fix missing "HVM" for vPMU entry in SUPPORT.md
> 
> The SUPPORT.md changes LGTM, thanks.
> 
>> -Virtual Performance Management Unit for HVM guests
>> +Virtual Performance Management Unit
>>   
>> -    Status, x86: Supported, Not security supported
>> +    Status, x86 HVM: Supported, Not security supported
>> +    Status, ARM: Experimental
>> +
>> +On ARM, support for accessing PMU registers from the guests.
>> +There is no interrupt support and Xen will not save/restore
>> +the register values on context switches.
> 
> FTAOD ISTM that this limitation makes the feature very hard to use
> successfully on ARM.  You would need to pin vcpus to dedicated
> pcpus ?

Yes and this is not really the only restriction for the feature. You 
can't even use the PMU properly with an out-of-box domain... But a few 
stakeholders seem to be happy with this hackyness for now.

> 
> I think this is fine for an experimental feature.
> 
> I think this patch needs a ARM/hypervisor acks still.

I am in the signed-off-by list. Even if the patch has changed compare 
the original, I feel it is odd to ack my own patch.

 From my understanding, my signed-off-by is sufficient serve as an 
approval for the maintainer part. We also have a review form a person of 
a suitable stature in the community (Bertrand). So I think in term of 
approval we are good.

Additionally, from a discussion yesterday on IRC, Stefano was happy with 
this patch (I was the one requesting the resend for SUPPORT.MD). So I 
think we can commit it now.

Let me know if you prefer to wait for a formal Ack from Stefano.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Oct 13 13:13:56 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 13:13:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.208458.364585 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mae4x-0002Z5-LL; Wed, 13 Oct 2021 13:13:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 208458.364585; Wed, 13 Oct 2021 13:13:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mae4x-0002Yy-Ho; Wed, 13 Oct 2021 13:13:55 +0000
Received: by outflank-mailman (input) for mailman id 208458;
 Wed, 13 Oct 2021 13:13:54 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=K823=PB=arm.com=michal.orzel@srs-us1.protection.inumbo.net>)
 id 1mae4w-0002Yq-D1
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 13:13:54 +0000
Received: from foss.arm.com (unknown [217.140.110.172])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTP
 id c125cf3a-97b4-4e29-823c-120e8613e152;
 Wed, 13 Oct 2021 13:13:53 +0000 (UTC)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 947361FB;
 Wed, 13 Oct 2021 06:13:52 -0700 (PDT)
Received: from [10.57.25.166] (unknown [10.57.25.166])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 16F6E3F66F;
 Wed, 13 Oct 2021 06:13:49 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c125cf3a-97b4-4e29-823c-120e8613e152
Subject: Re: [PATCH v7] xen: Expose the PMU to the guests
To: Ian Jackson <iwj@xenproject.org>
Cc: xen-devel@lists.xenproject.org, Andrew Cooper
 <andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>,
 Jan Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 Nick Rosbrook <rosbrookn@ainfosec.com>,
 Anthony PERARD <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>,
 Christian Lindig <christian.lindig@citrix.com>, David Scott
 <dave@recoil.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 bertrand.marquis@arm.com
References: <20211013123352.6625-1-michal.orzel@arm.com>
 <24934.54743.853232.853726@mariner.uk.xensource.com>
From: Michal Orzel <michal.orzel@arm.com>
Message-ID: <3d414cd9-2cb7-3a26-eada-e75fa0fe05a2@arm.com>
Date: Wed, 13 Oct 2021 15:13:41 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <24934.54743.853232.853726@mariner.uk.xensource.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

Hi Ian,

On 13.10.2021 14:49, Ian Jackson wrote:
> Michal Orzel writes ("[PATCH v7] xen: Expose the PMU to the guests"):
>> Add parameter vpmu to xl domain configuration syntax
>> to enable the access to PMU registers by disabling
>> the PMU traps(currently only for ARM).
>>
>> The current status is that the PMU registers are not
>> virtualized and the physical registers are directly
>> accessible when this parameter is enabled. There is no
>> interrupt support and Xen will not save/restore the
>> register values on context switches.
>>
>> According to Arm Arm, section D7.1:
>> "The Performance Monitors Extension is common
>> to AArch64 operation and AArch32 operation."
>> That means we have an ensurance that if PMU is
>> present in one exception state, it must also be
>> present in the other.
>>
>> Please note that this feature is experimental.
> ...
>> Changes since v6:
>> -fix missing "HVM" for vPMU entry in SUPPORT.md
> 
> The SUPPORT.md changes LGTM, thanks.
> 
>> -Virtual Performance Management Unit for HVM guests
>> +Virtual Performance Management Unit
>>  
>> -    Status, x86: Supported, Not security supported
>> +    Status, x86 HVM: Supported, Not security supported
>> +    Status, ARM: Experimental
>> +
>> +On ARM, support for accessing PMU registers from the guests.
>> +There is no interrupt support and Xen will not save/restore
>> +the register values on context switches.
> 
> FTAOD ISTM that this limitation makes the feature very hard to use
> successfully on ARM.  You would need to pin vcpus to dedicated
> pcpus ?
> 
Yes, there are some limitations but even with them it is really useful.
We are making use of vPMU in our tests successfuly.
FWIK Stefano also had to provide a patch enabling pmu in the past.
It was agreed that we will expose only part of vPMU.
The rest needs to be done in the future.
PMU interrupt is only used to signal overflow which would occur
in a very long tests.

> I think this is fine for an experimental feature.
> 
> I think this patch needs a ARM/hypervisor acks still.
>
Agree. Probably Stefano will do this today.

> Ian.
> Cheers,
Michal


From xen-devel-bounces@lists.xenproject.org Wed Oct 13 13:15:53 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 13:15:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.208465.364597 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mae6r-0003DS-1P; Wed, 13 Oct 2021 13:15:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 208465.364597; Wed, 13 Oct 2021 13:15:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mae6q-0003DL-UF; Wed, 13 Oct 2021 13:15:52 +0000
Received: by outflank-mailman (input) for mailman id 208465;
 Wed, 13 Oct 2021 13:15:51 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mae6p-0003D9-Ow; Wed, 13 Oct 2021 13:15:51 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mae6p-0005Lk-Ia; Wed, 13 Oct 2021 13:15:51 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mae6p-0003H1-B4; Wed, 13 Oct 2021 13:15:51 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mae6p-0005rk-AX; Wed, 13 Oct 2021 13:15:51 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=ciz6OD8R4FN2WHWryxf0AsK3NKZVZdnAUsA8OPRK3Tg=; b=tTFqHuL2zvfAoZn3vbQmXigCsT
	mbAzvLAp6eIQ5ufn+TUH0jQ3GrVMnpHkQBeWzDklP5U/ZDp0XVErv6vRFyShKt3P8L2cC5+2X/zY5
	5qzT7q3R5n2nRLgNvVl02cDgs0F1GuDL72iUfN0or0ic6uuzMDsvEZDMHdS38OXDD4+M=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165486-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-5.4 test] 165486: regressions - FAIL
X-Osstest-Failures:
    linux-5.4:test-armhf-armhf-xl-credit1:guest-start:fail:regression
    linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:heisenbug
    linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:guest-start/debian.repeat:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=faaca480fd5cd1976b6db743c43ac1f8d583de72
X-Osstest-Versions-That:
    linux=e74e2950a0d6f800858e54860d7124c86e494f62
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 13 Oct 2021 13:15:51 +0000

flight 165486 linux-5.4 real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165486/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-armhf-armhf-xl-credit1  14 guest-start              fail REGR. vs. 165206

Tests which are failing intermittently (not blocking):
 test-armhf-armhf-xl-rtds     18 guest-start/debian.repeat  fail pass in 165476

Tests which did not succeed, but are not blocking:
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 165206
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 165206
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165206
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 165206
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165206
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165206
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 165206
 test-arm64-arm64-libvirt-raw 17 guest-start/debian.repeat    fail  like 165206
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 165206
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 165206
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 165206
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 165206
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 165206
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 linux                faaca480fd5cd1976b6db743c43ac1f8d583de72
baseline version:
 linux                e74e2950a0d6f800858e54860d7124c86e494f62

Last test of basis   165206  2021-09-26 12:42:13 Z   17 days
Failing since        165346  2021-10-04 12:42:32 Z    9 days   13 attempts
Testing same since   165449  2021-10-09 23:12:14 Z    3 days    7 attempts

------------------------------------------------------------
People who touched revisions under test:
  Alan Stern <stern@rowland.harvard.edu>
  Alex Deucher <alexander.deucher@amd.com>
  Alexei Starovoitov <ast@kernel.org>
  Anand K Mistry <amistry@google.com>
  Anders Roxell <anders.roxell@linaro.org>
  Andrea Claudi <aclaudi@redhat.com>
  Andreas Larsson <andreas@gaisler.com>
  Andrej Shadura <andrew.shadura@collabora.co.uk>
  Andrew Morton <akpm@linux-foundation.org>
  Andy Shevchenko <andriy.shevchenko@linux.intel.com>
  Anirudh Rayabharam <mail@anirudhrb.com>
  Anson Jacob <Anson.Jacob@amd.com>
  Antoine Tenart <atenart@kernel.org>
  Anton Eidelman <anton.eidelman@gmail.com>
  Anton Eidelman <anton@lightbitslabs.com>
  Ariel Elior <aelior@marvell.com>
  Arnd Bergmann <arnd@arndb.de>
  Aswath Govindraju <a-govindraju@ti.com>
  Aya Levin <ayal@nvidia.com>
  Baokun Li <libaokun1@huawei.com>
  Bartosz Golaszewski <brgl@bgdev.pl>
  Bixuan Cui <cuibixuan@huawei.com>
  Bjorn Helgaas <bhelgaas@google.com>
  Borislav Petkov <bp@suse.de>
  Carlo Lobrano <c.lobrano@gmail.com>
  Catalin Marinas <catalin.marinas@arm.com>
  Changbin Du <changbin.du@gmail.com>
  Charlene Liu <Charlene.Liu@amd.com>
  Chen Jingwen <chenjingwen6@huawei.com>
  Chih-Kang Chang <gary.chang@realtek.com>
  Chris Chiu <chris.chiu@canonical.com>
  Christian Brauner <christian.brauner@ubuntu.com>
  Christoph Hellwig <hch@lst.de>
  Claudiu Manoil <claudiu.manoil@nxp.com>
  Cong Wang <cong.wang@bytedance.com>
  Dan Carpenter <dan.carpenter@oracle.com>
  Dan Li <ashimida@linux.alibaba.com>
  Dan Williams <dan.j.williams@intel.com>
  Daniel Borkmann <daniel@iogearbox.net>
  Daniel Lezcano <daniel.lezcano@linaro.org>
  Daniel Wheeler <daniel.wheeler@amd.com>
  David Howells <dhowells@redhat.com>
  David S. Miller <davem@davemloft.net>
  David Sterba <dsterba@suse.com>
  Dmitry Bogdanov <d.bogdanov@yadro.com>
  Dongliang Mu <mudongliangabcd@gmail.com>
  Eric Biggers <ebiggers@google.com>
  Eric Dumazet <edumazet@google.com>
  F.A. SULAIMAN <asha.16@itfac.mrt.ac.lk>
  F.A.Sulaiman <asha.16@itfac.mrt.ac.lk>
  Faizel K B <faizel.kb@dicortech.com>
  Fares Mehanna <faresx@amazon.de>
  Felipe Balbi <balbi@kernel.org>
  Florian Fainelli <f.fainelli@gmail.com>
  Gao Xiang <hsiangkao@linux.alibaba.com>
  Geert Uytterhoeven <geert@linux-m68k.org>
  Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  Gregory CLEMENT <gregory.clement@bootlin.com>
  Guangbin Huang <huangguangbin2@huawei.com>
  Guenter Roeck <linux@roeck-us.net>
  Hans de Goede <hdegoede@redhat.com>
  Helge Deller <deller@gmx.de>
  Herbert Xu <herbert@gondor.apana.org.au>
  Hulk Robot <hulkrobot@huawei.com>
  Igor Matheus Andrade Torrente <igormtorrente@gmail.com>
  J. Bruce Fields <bfields@redhat.com>
  Jacob Keller <jacob.e.keller@intel.com>
  James Morse <james.morse@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Jan Kara <jack@suse.cz>
  Jeffle Xu <jefflexu@linux.alibaba.com>
  Jens Axboe <axboe@kernel.dk>
  Jesper Nilsson <jesper.nilsson@axis.com>
  Jian Shen <shenjian15@huawei.com>
  Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
  Jiri Benc <jbenc@redhat.com>
  Jiri Kosina <jkosina@suse.cz>
  Jiri Slaby <jslaby@suse.cz>
  Johan Hovold <johan@kernel.org>
  Johannes Berg <johannes.berg@intel.com>
  Johannes Thumshirn <jth@kernel.org>
  John Allen <john.allen@amd.com>
  Jon Hunter <jonathanh@nvidia.com>
  Jonathan Hsu <jonathan.hsu@mediatek.com>
  Jozsef Kadlecsik <kadlec@netfilter.org>
  Juergen Gross <jgross@suse.com>
  Julian Anastasov <ja@ssi.bg>
  Julian Sikorski <belegdol+github@gmail.com>
  Julian Sikorski <belegdol@gmail.com>
  Kaige Fu <kaige.fu@linux.alibaba.com>
  Kan Liang <kan.liang@linux.intel.com>
  Karsten Graul <kgraul@linux.ibm.com>
  Kate Hsuan <hpa@redhat.com>
  Kevin Hao <haokexin@gmail.com>
  Kishon Vijay Abraham I <kishon@ti.com>
  Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
  Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
  Leon Yu <leoyu@nvidia.com>
  Li Jinlin <lijinlin3@huawei.com>
  Li Zhijian <lizhijian@cn.fujitsu.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Linux Kernel Functional Testing <lkft@linaro.org>
  Lorenzo Bianconi <lorenzo@kernel.org>
  Marc Zyngier <maz@kernel.org>
  Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
  Mark Rutland <mark.rutland@arm.com>
  Markus Suvanto <markus.suvanto@gmail.com>
  Martin K. Petersen <martin.petersen@oracle.com>
  Michael Chan <michael.chan@broadcom.com>
  Michael Chan <michael.chan@broadocm.com>
  Michal Kalderon <mkalderon@marvell.com>
  Minas Harutyunyan <Minas.Harutyunyan@synopsys.com>
  Ming Lei <ming.lei@redhat.com>
  Moritz Fischer <mdf@kernel.org>
  Nadezda Lutovinova <lutovinova@ispras.ru>
  Nicolas Ferre <nicolas.ferre@microchip.com>
  Nirmoy Das <nirmoy.das@amd.com>
  Oliver Neukum <oneukum@suse.com>
  Ondrej Zary <linux@zary.sk>
  Ovidiu Panait <ovidiu.panait@windriver.com>
  Pablo Neira Ayuso <pablo@netfilter.org>
  Pali Rohár <pali@kernel.org>
  Paolo Bonzini <pbonzini@redhat.com>
  Paul Fertser <fercerpav@gmail.com>
  Pawel Laszczak <pawell@cadence.com>
  Peter Zijlstra (Intel) <peterz@infradead.org>
  Ping-Ke Shih <pkshih@realtek.com>
  Qu Wenruo <wqu@suse.com>
  Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
  Randy Dunlap <rdunlap@infradead.org>
  Rik van Riel <riel@surriel.com>
  Ritesh Harjani <riteshh@linux.ibm.com>
  Rob Herring <robh@kernel.org>
  Ronnie Sahlberg <lsahlber@redhat.com>
  Sai Krishna Potthuri <lakshmi.sai.krishna.potthuri@xilinx.com>
  Samuel Iglesias Gonsalvez <siglesias@igalia.com>
  Sasha Levin <sashal@kernel.org>
  Sergey Senozhatsky <senozhatsky@chromium.org>
  Shai Malin <smalin@marvell.com>
  Shuah Khan <skhan@linuxfoundation.org>
  Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
  Simon Horman <horms@verge.net.au>
  Slark Xiao <slark_xiao@163.com>
  Song Liu <songliubraving@fb.com>
  Srinivas Pandruvada <srinivas.pI andruvada@linux.intel.com>
  Steve French <stfrench@microsoft.com>
  Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
  sumiyawang <sumiyawang@tencent.com>
  syzbot+47b26cd837ececfc666d@syzkaller.appspotmail.com
  syzbot+fadc0aaf497e6a493b9f@syzkaller.appspotmail.com
  Tariq Toukan <tariqt@nvidia.com>
  Tejun Heo <tj@kernel.org>
  Theodore Ts'o <tytso@mit.edu>
  Todd Kjos <tkjos@google.com>
  Tom Rix <trix@redhat.com>
  Tong Zhang <ztong0001@gmail.com>
  Tony Nguyen <anthony.l.nguyen@intel.com>
  Tyler Hicks <tyhicks@linux.microsoft.com>
  Uwe Brandt <uwe.brandt@gmail.com>
  Vadim Pasternak <vadimp@nvidia.com>
  Viresh Kumar <viresh.kumar@linaro.org>
  Vlad Buslov <vladbu@nvidia.com>
  Vladimir Oltean <vladimir.oltean@nxp.com>
  Wen Xiong <wenxiong@linux.ibm.com>
  Wengang Wang <wen.gang.wang@oracle.com>
  Xiao Liang <shaw.leon@gmail.com>
  Xin Long <lucien.xin@gmail.com>
  Yang Yingliang <yangyingliang@huawei.com>
  yangerkun <yangerkun@huawei.com>
  Yonghong Song <yhs@fb.com>
  Zelin Deng <zelin.deng@linux.alibaba.com>
  zhang kai <zhangkaiheb@126.com>
  Zhihao Cheng <chengzhihao1@huawei.com>
  Zong-Zhe Yang <kevin_yang@realtek.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 fail    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 4201 lines long.)


From xen-devel-bounces@lists.xenproject.org Wed Oct 13 13:23:39 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 13:23:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.208476.364610 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maeEG-0004jf-4s; Wed, 13 Oct 2021 13:23:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 208476.364610; Wed, 13 Oct 2021 13:23:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maeEG-0004jY-1H; Wed, 13 Oct 2021 13:23:32 +0000
Received: by outflank-mailman (input) for mailman id 208476;
 Wed, 13 Oct 2021 13:23:31 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Wjg9=PB=gmail.com=andy.shevchenko@srs-us1.protection.inumbo.net>)
 id 1maeEF-0004jS-8X
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 13:23:31 +0000
Received: from mga03.intel.com (unknown [134.134.136.65])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id c1491cc8-2c28-11ec-816d-12813bfff9fa;
 Wed, 13 Oct 2021 13:23:30 +0000 (UTC)
Received: from fmsmga001.fm.intel.com ([10.253.24.23])
 by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 13 Oct 2021 06:23:29 -0700
Received: from smile.fi.intel.com (HELO smile) ([10.237.72.159])
 by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 13 Oct 2021 06:23:15 -0700
Received: from andy by smile with local (Exim 4.95)
 (envelope-from <andy.shevchenko@gmail.com>) id 1maeDt-000LPO-Od;
 Wed, 13 Oct 2021 16:23:09 +0300
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c1491cc8-2c28-11ec-816d-12813bfff9fa
X-IronPort-AV: E=McAfee;i="6200,9189,10135"; a="227383036"
X-IronPort-AV: E=Sophos;i="5.85,371,1624345200"; 
   d="scan'208";a="227383036"
X-IronPort-AV: E=Sophos;i="5.85,371,1624345200"; 
   d="scan'208";a="626341116"
Date: Wed, 13 Oct 2021 16:23:09 +0300
From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= <u.kleine-koenig@pengutronix.de>,
	linux-pci <linux-pci@vger.kernel.org>,
	Sascha Hauer <kernel@pengutronix.de>,
	Alexander Duyck <alexanderduyck@fb.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Andrew Donnellan <ajd@linux.ibm.com>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Arnd Bergmann <arnd@arndb.de>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Bjorn Helgaas <bhelgaas@google.com>, Borislav Petkov <bp@alien8.de>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	"David S. Miller" <davem@davemloft.net>,
	Fiona Trahe <fiona.trahe@intel.com>,
	Frederic Barrat <fbarrat@linux.ibm.com>,
	Giovanni Cabiddu <giovanni.cabiddu@intel.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	"H. Peter Anvin" <hpa@zytor.com>, Ido Schimmel <idosch@nvidia.com>,
	Ingo Molnar <mingo@redhat.com>, Jack Xu <jack.xu@intel.com>,
	Jakub Kicinski <kuba@kernel.org>,
	Jesse Brandeburg <jesse.brandeburg@intel.com>,
	Jiri Olsa <jolsa@redhat.com>, Jiri Pirko <jiri@nvidia.com>,
	Juergen Gross <jgross@suse.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Marco Chiappero <marco.chiappero@intel.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Mathias Nyman <mathias.nyman@intel.com>, Michael Buesch <m@bues.ch>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Namhyung Kim <namhyung@kernel.org>,
	Oliver O'Halloran <oohall@gmail.com>,
	Paul Mackerras <paulus@samba.org>,
	Peter Zijlstra <peterz@infradead.org>,
	=?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= <zajec5@gmail.com>,
	Russell Currey <ruscur@russell.cc>,
	Salil Mehta <salil.mehta@huawei.com>,
	Sathya Prakash <sathya.prakash@broadcom.com>,
	Simon Horman <simon.horman@corigine.com>,
	Sreekanth Reddy <sreekanth.reddy@broadcom.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Suganath Prabu Subramani <suganath-prabu.subramani@broadcom.com>,
	Taras Chornyi <tchornyi@marvell.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Tomaszx Kowalik <tomaszx.kowalik@intel.com>,
	Vadym Kochan <vkochan@marvell.com>,
	Wojciech Ziemba <wojciech.ziemba@intel.com>,
	Yisen Zhuang <yisen.zhuang@huawei.com>,
	Zhou Wang <wangzhou1@hisilicon.com>,
	linux-crypto <linux-crypto@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-perf-users@vger.kernel.org,
	"open list:LINUX FOR POWERPC PA SEMI PWRFICIENT" <linuxppc-dev@lists.ozlabs.org>,
	linux-scsi <linux-scsi@vger.kernel.org>,
	USB <linux-usb@vger.kernel.org>,
	"open list:TI WILINK WIRELES..." <linux-wireless@vger.kernel.org>,
	MPT-FusionLinux.pdl@broadcom.com, netdev <netdev@vger.kernel.org>,
	oss-drivers@corigine.com, qat-linux@intel.com,
	"maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" <x86@kernel.org>,
	xen-devel@lists.xenproject.org
Subject: Re: [PATCH v6 00/11] PCI: Drop duplicated tracking of a pci_dev's
 bound driver
Message-ID: <YWbdvc7EWEZLVTHM@smile.fi.intel.com>
References: <CAHp75Vd0uYEdfB0XaQuUV34V91qJdHR5ARku1hX_TCJLJHEjxQ@mail.gmail.com>
 <20211013113356.GA1891412@bhelgaas>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20211013113356.GA1891412@bhelgaas>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo

On Wed, Oct 13, 2021 at 06:33:56AM -0500, Bjorn Helgaas wrote:
> On Wed, Oct 13, 2021 at 12:26:42PM +0300, Andy Shevchenko wrote:
> > On Wed, Oct 13, 2021 at 2:33 AM Bjorn Helgaas <helgaas@kernel.org> wrote:
> > > On Mon, Oct 04, 2021 at 02:59:24PM +0200, Uwe Kleine-K�nig wrote:

...

> > It's a bit unusual. Other to_*_dev() are not NULL-aware IIRC.
> 
> It is a little unusual.  I only found three of 77 that are NULL-aware:
> 
>   to_moxtet_driver()
>   to_siox_driver()
>   to_spi_driver()
> 
> It seems worthwhile to me because it makes the patch and the resulting
> code significantly cleaner.

I'm not objecting the change, just a remark.

...

> > > +       for (id = drv ? drv->id_table : NULL; id && id->vendor; id++)
> > > +               if (id->vendor == vendor && id->device == device)
> > 
> > > +                       break;
> > 
> > return true;
> > 
> > >         return id && id->vendor;
> > 
> > return false;
> 
> Good cleanup for a follow-up patch, but doesn't seem directly related
> to the objective here.

True. Maybe you can bake one while not forgotten?

...

> > > +       return drv && drv->resume ?
> > > +                       drv->resume(pci_dev) : pci_pm_reenable_device(pci_dev);
> > 
> > One line?
> 
> I don't think I touched that line.

Then why they are both in + section?

...

> > > +       struct pci_driver *drv = to_pci_driver(dev->dev.driver);
> > >         const struct pci_error_handlers *err_handler =
> > > -                       dev->dev.driver ? to_pci_driver(dev->dev.driver)->err_handler : NULL;
> > > +                       drv ? drv->err_handler : NULL;
> > 
> > Isn't dev->driver == to_pci_driver(dev->dev.driver)?
> 
> Yes, I think so, but not sure what you're getting at here, can you
> elaborate?

Getting pointer from another pointer seems waste of resources, why we
can't simply

	struct pci_driver *drv = dev->driver;

?

...

> > Stray change? Or is it in a separate patch in your tree?
> 
> Could be skipped.  The string now fits on one line so I combined it to
> make it more greppable.

This is inconsistency in your changes, in one case you are objecting of
doing something close to the changed lines, in the other you are doing
unrelated change.

-- 
With Best Regards,
Andy Shevchenko




From xen-devel-bounces@lists.xenproject.org Wed Oct 13 13:27:58 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 13:27:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.208484.364622 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maeIX-0005P1-Ml; Wed, 13 Oct 2021 13:27:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 208484.364622; Wed, 13 Oct 2021 13:27:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maeIX-0005Ou-JC; Wed, 13 Oct 2021 13:27:57 +0000
Received: by outflank-mailman (input) for mailman id 208484;
 Wed, 13 Oct 2021 13:27:56 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1maeIW-0005Oo-7G
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 13:27:56 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1maeIW-0005Zd-0Q; Wed, 13 Oct 2021 13:27:56 +0000
Received: from 54-240-197-234.amazon.com ([54.240.197.234]
 helo=[192.168.17.188]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1maeIV-0001YY-Qv; Wed, 13 Oct 2021 13:27:55 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=76tvdcAKL6FjWgYAzG29HONM2nDBGwCFuwtndCll6zM=; b=Yl53v2ZFx3gWlTnFAM6arvbznr
	WZZHnrWXqduEL0KEkZLYGGX+Gs8e2GqOnAoj6996Rsu2zSOez6D8SuJ8CGqQ8D+vBXc6oM4do9HsM
	Rc+ujLuAQBoLmHMZn+07s2e07tcNj32im/YG8iDLohR3WPEk1+9pdxKrB0IzrYVAOS2I=;
Message-ID: <a31231e3-a1eb-0e1f-59b8-75677d5db51b@xen.org>
Date: Wed, 13 Oct 2021 14:27:54 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.2.0
Subject: Re: [PATCH] arm/docs: Clarify legacy DT bindings on UEFI
To: Luca Fancellu <luca.fancellu@arm.com>, xen-devel@lists.xenproject.org
Cc: bertrand.marquis@arm.com, wei.chen@arm.com,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <20211013121929.30784-1-luca.fancellu@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20211013121929.30784-1-luca.fancellu@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Luca,

On 13/10/2021 13:19, Luca Fancellu wrote:
> Legacy compatible strings for dom0 modules are not
> supported when booting using UEFI, the documentation
> doesn't mention that.

Can you add a summary in the commit message why we consider the legacy 
binding is not supported?

> 
> Add a phrase to docs/misc/arm/device-tree/booting.txt
> to clarify it.
> 
> Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>
> ---
>   docs/misc/arm/device-tree/booting.txt | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/docs/misc/arm/device-tree/booting.txt b/docs/misc/arm/device-tree/booting.txt
> index c6a775f4e8..017c0f13eb 100644
> --- a/docs/misc/arm/device-tree/booting.txt
> +++ b/docs/misc/arm/device-tree/booting.txt
> @@ -51,6 +51,8 @@ Each node contains the following properties:
>   	Xen 4.4 supported a different set of legacy compatible strings
>   	which remain supported such that systems supporting both 4.4
>   	and later can use a single DTB.
> +	However when booting Xen using UEFI and Device Tree, the legacy

NIT: I would drop "and Device Tree" because this feels a bit redundant 
as this compatible can only be used in the Device-Tree.

> +	compatible strings are not supported.
>   
>   	- "xen,multiboot-module" equivalent to "multiboot,module"
>   	- "xen,linux-zimage"     equivalent to "multiboot,kernel"
> 

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Oct 13 13:47:04 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 13:47:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.208493.364632 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maeas-0007kn-77; Wed, 13 Oct 2021 13:46:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 208493.364632; Wed, 13 Oct 2021 13:46:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maeas-0007kg-4A; Wed, 13 Oct 2021 13:46:54 +0000
Received: by outflank-mailman (input) for mailman id 208493;
 Wed, 13 Oct 2021 13:46:52 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=dUCo=PB=gmail.com=olekstysh@srs-us1.protection.inumbo.net>)
 id 1maeaq-0007ka-QA
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 13:46:52 +0000
Received: from mail-lf1-x134.google.com (unknown [2a00:1450:4864:20::134])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id cfcce0b3-80bc-4a72-9a77-61d18aa69cd2;
 Wed, 13 Oct 2021 13:46:50 +0000 (UTC)
Received: by mail-lf1-x134.google.com with SMTP id t9so12192791lfd.1
 for <xen-devel@lists.xenproject.org>; Wed, 13 Oct 2021 06:46:50 -0700 (PDT)
Received: from [192.168.1.7] ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id k21sm1156943ljn.126.2021.10.13.06.46.47
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Wed, 13 Oct 2021 06:46:47 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: cfcce0b3-80bc-4a72-9a77-61d18aa69cd2
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:from:to:cc:references:message-id:date:user-agent
         :mime-version:in-reply-to:content-transfer-encoding:content-language;
        bh=Os35FbdnbdUgpTybXhUEC4erjKfVe6PfmHwS0DsZLmQ=;
        b=MpCA+eH4lw5wiU4p/WVZB0kehEnlW4BgYr6umCCBsrOaDhAfop5xWB9ISoa9Hh7X02
         tf5Ie+9enejl640aoLKoo9LKElKyleWkuuUqtyetffX+oi+kW5BIaCMO377QMhz90dE5
         2XYi/ThIDlQCFFkrDWrQdt6JjeekQVFjoPZSjZOyZq8q6K7LAiIcPv5vZwo6fl/Jmwc7
         dCxW8tpOu+W9rctszJK7+mmHR1lLy/CxjqnkUWx8D3dLP27uIgq51dyNKHGO5jOnHpxc
         ZnxklVuBZkfIptZuDLtsswLUU1LCAqhj/ZW+TNkI0JsiHRs1nlZnMdfEL1bmxoYhM3b9
         JAIw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:from:to:cc:references:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding
         :content-language;
        bh=Os35FbdnbdUgpTybXhUEC4erjKfVe6PfmHwS0DsZLmQ=;
        b=m8+DUEAeASLxyHZVsL9X9vzg4zJgf8U9f4OILyKKJGT/myXdvSdflEoMgZKXQoPa+I
         jt9O3bZctmZjugokzVuYkRUJ+5dL7G2l4furXcEtpuTKK5c1bZ7Q8MwKBja+J2pEqh4v
         VLpzGAoWIUS/A2vg4JsyMX5eff4eO//qq0CvIFrR0QoIJ6ottL27b+tcwqTfkZC8gfVS
         R7eanBrlDpa+ab+ABoSDBS3a5WMZKNgXYScXI3GmwfmB/rYEpn4cob1UrX5KosoUyKyF
         Mh33ztSBEkqH+i4JkWTUk4p1/ydWeMDi3oOCVKAP+YywEbSNm3yM/aAsNiAL1vaBJFxM
         kPUw==
X-Gm-Message-State: AOAM532oev/Sd0JyFqxbZ+nu3zZb1mylPFqBI3/DQWVNjiZdr1hLfVli
	bd1pRgEGf0aK4ArBqS34WbE=
X-Google-Smtp-Source: ABdhPJxeBZMlYDT1YAWM/iowRj1hPV7e9oTDwpjr8FYhPoIsvfzuRHA69swREjciyJZeVdUH2Jb5Dg==
X-Received: by 2002:ac2:518a:: with SMTP id u10mr8455677lfi.367.1634132808281;
        Wed, 13 Oct 2021 06:46:48 -0700 (PDT)
Subject: Re: [PATCH V6 2/2] libxl/arm: Add handling of extended regions for
 DomU
From: Oleksandr <olekstysh@gmail.com>
To: Julien Grall <julien@xen.org>
Cc: Ian Jackson <iwj@xenproject.org>, xen-devel@lists.xenproject.org,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, Wei Liu <wl@xen.org>,
 Anthony PERARD <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <1633974539-7380-1-git-send-email-olekstysh@gmail.com>
 <1633974539-7380-3-git-send-email-olekstysh@gmail.com>
 <c98c1acd-86c0-f556-643e-e472b696644f@xen.org>
 <51f9154f-3b65-c7c0-cd93-cecdc2a0975e@gmail.com>
 <641173d4-2629-e4b6-d4ec-06bd629141cc@xen.org>
 <acc06366-b381-daa0-8e2a-54c2761019af@gmail.com>
Message-ID: <dea074a1-fad2-9b25-5b44-8de23eee83d7@gmail.com>
Date: Wed, 13 Oct 2021 16:46:46 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <acc06366-b381-daa0-8e2a-54c2761019af@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US


Hi Julien


On 13.10.21 00:43, Oleksandr wrote:
>
> On 13.10.21 00:22, Julien Grall wrote:
>> Hi Oleksandr,
>
> Hi Julien, Ian.
>
>
> Julien, thank you for the detailed answer, I will analyze it tomorrow.

Already analyzed, please see comments below.


>
> Ian, I think, there is no reason in providing git branch with the acks 
> folded in + my minor fix for the debug message as it was discussed 
> before, it sounds like there is more work to do, so it is going to be 
> a new version anyway.
>
>
>
>
>>
>> On 12/10/2021 18:42, Oleksandr wrote:
>>> On 12.10.21 19:05, Julien Grall wrote:
>>>> On 11/10/2021 18:48, Oleksandr Tyshchenko wrote:
>>>>> ---
>>>>>   tools/libs/light/libxl_arm.c  | 76 
>>>>> ++++++++++++++++++++++++++++++++++++++++---
>>>>>   xen/include/public/arch-arm.h |  2 ++
>>>>>   2 files changed, 73 insertions(+), 5 deletions(-)
>>>>>
>>>>> diff --git a/tools/libs/light/libxl_arm.c 
>>>>> b/tools/libs/light/libxl_arm.c
>>>>> index e3140a6..c0e8415 100644
>>>>> --- a/tools/libs/light/libxl_arm.c
>>>>> +++ b/tools/libs/light/libxl_arm.c
>>>>> @@ -598,9 +598,20 @@ static int make_timer_node(libxl__gc *gc, 
>>>>> void *fdt,
>>>>>       return 0;
>>>>>   }
>>>>>   +#define ALIGN_UP_TO_2MB(x)   (((x) + MB(2) - 1) & (~(MB(2) - 1)))
>>>>> +
>>>>>   static int make_hypervisor_node(libxl__gc *gc, void *fdt,
>>>>> -                                const libxl_version_info *vers)
>>>>> +                                const libxl_version_info *vers,
>>>>> +                                const libxl_domain_build_info 
>>>>> *b_info,
>>>>> +                                const struct xc_dom_image *dom)
>>>>>   {
>>>>> +    uint64_t region_size[GUEST_RAM_BANKS] = {0}, 
>>>>> region_base[GUEST_RAM_BANKS],
>>>>> +        bank1end, ramsize;
>>>>> +    uint32_t regs[(GUEST_ROOT_ADDRESS_CELLS + 
>>>>> GUEST_ROOT_SIZE_CELLS) *
>>>>> +                  (GUEST_RAM_BANKS + 1)];
>>>>> +    be32 *cells = &regs[0];
>>>>> +    unsigned int i, len, nr_regions = 0;
>>>>> +    libxl_dominfo info;
>>>>>       int res;
>>>>>       gic_interrupt intr;
>>>>>   @@ -615,9 +626,64 @@ static int make_hypervisor_node(libxl__gc 
>>>>> *gc, void *fdt,
>>>>>                                 "xen,xen");
>>>>>       if (res) return res;
>>>>>   -    /* reg 0 is grant table space */
>>>>> -    res = fdt_property_regs(gc, fdt, GUEST_ROOT_ADDRESS_CELLS, 
>>>>> GUEST_ROOT_SIZE_CELLS,
>>>>> -                            1,GUEST_GNTTAB_BASE, GUEST_GNTTAB_SIZE);
>>>>> +    if (strcmp(dom->guest_type, "xen-3.0-aarch64")) {
>>>>> +        LOG(WARN, "The extended regions are only supported for 
>>>>> 64-bit guest currently");
>>>>> +        goto out;
>>>>> +    }
>>>>
>>>> I understand why we want to limit to 64-bit domain for dom0. But I 
>>>> am not sure this is warrant for 32-bit domain. At worse, the guest 
>>>> will ignore the bank because it is not usable. So could we drop the 
>>>> check?
>>>
>>> Yes.
>>>
>>>
>>>>
>>>>
>>>>> +
>>>>> +    res = libxl_domain_info(CTX, &info, dom->guest_domid);
>>>>> +    if (res) return res;
>>>>> +
>>>>> +    assert(info.gpaddr_bits >= 32 && info.gpaddr_bits <= 48);
>>>> What could go wrong below if gpaddr_bits is not within this range?
>>>
>>> if info.gpaddr_bits is less than 64, then nothing bad, otherwise, I 
>>> assume we will get shift count overflow.
>>
>> So I think the assert() is not suitable here because even if the 
>> gpaddr_bits is provided by the hypervisor (and therefore should be 
>> trusted), this is a different component so hardening the code is a 
>> good practice.
>>
>> In this case, I would check that info.gpaddr_bits <= 64 and return an 
>> error. The reason I am suggesting <= 64 and not 48 is because Arm 
>> already supports 52 bits address space. Yet, I still like to avoid 
>> this assumption in the code. Something like below should work:
>>
>> bank1end = GUEST_RAM1_BASE + GUEST_RAM1_SIZE - 1;
>> bank1end = min(bank1end, ~(0ULL) >> (64 - info.gpaddr_bits);

ok, makes sense.


>>
>>
>>>>> +
>>>>> +    /*
>>>>> +     * Try to allocate separate 2MB-aligned extended regions from 
>>>>> the first
>>>>> +     * (below 4GB) and second (above 4GB) RAM banks taking into 
>>>>> the account
>>>>> +     * the maximum supported guest physical address space size 
>>>>> and the amount
>>>>> +     * of memory assigned to the guest.
>>>>> +     * As the guest memory layout is not populated yet we cannot 
>>>>> rely on
>>>>> +     * dom->rambank_size[], so calculate the actual size of both 
>>>>> banks using
>>>>> +     * "max_memkb" value.
>>>>> +     */
>>>>
>>>> At the moment, libxl doesn't know how libxc will allocate the 
>>>> memory. We may decide in the future to have only a small amount of 
>>>> memory below 4GB and then the rest above 4GB. With this approach it 
>>>> would be more difficult to modify the memory layout. Instead, I 
>>>> think we should create a placeholder that is updated once we know 
>>>> the banks in libxl__arch_domain_finalise_hw_description.
>>>
>>> If I got your point correctly, this is close to how it was done from 
>>> the beginning. Yes, we can create placeholder(s) here and then 
>>> update them once the memory layout is populated. The problem is that 
>>> we won't be able to remove the placeholder(s) if we fail to allocate 
>>> region(s) for some reasons. So, we should know for sure in advance 
>>> how many region(s) we will be able to allocate later on in order to 
>>> create the required number of placeholders right now... Please, look 
>>> at the TODO I wrote in finalise_ext_region() [1]. Or I misread your 
>>> point?
>>
>> You read correctly my point. However, I disagree that it is a problem 
>> to remove the placeholder if we fail to allocate the amount of 
>> regions expected.
>>
>> Looking at libfdt, I can see two ways to deal with it:
>>   1) Use fdt_setprop()
>>   2) Delete the property using fdt_delprop() and then recreate it 
>> with fdt_appendprop()
>>
>> The first solution is ideal and I think can work here to downsize the 
>> property. At worse, the second solution should work as the FDT blob 
>> will not increase.

Indeed, fdt_setprop() will work in our case, thank you. When I looked at 
it, I only experimented with two high-level functions: 
fdt_setprop_inplace() and fdt_nop_node() used in libxl_arm.c and no one 
wasn't suitable.


>>
>>
>>>> We also probably want to mention in the memory layout in 
>>>> public/arch-arm.h this decision as the suggested way to find 
>>>> extended regions will definitely impact our decision to re-order 
>>>> the memory layout or shrink some regions in the future (I have in 
>>>> mind the PCI Passthrough work).
>>>
>>> Sorry, I couldn't parse.
>>
>> So this patch is relying on the fact that the regions reserved for 
>> the RAM are big enough to also accommodate the extended regions.
>>
>> I am happy with this approach. However, I would like the approach to 
>> be documented in arch-arm.h because this is the first place one would 
>> look to understand the memory layout. This will be helpful if/when we 
>> need to modify the guest memory layout.

Thank you for the clarification, it is clear now.


>>
>>
>>>
>>>
>>>>
>>>>
>>>>> +    ramsize = b_info->max_memkb * 1024;
>>>>> +    if (ramsize <= GUEST_RAM0_SIZE) {
>>>>> +        region_base[0] = GUEST_RAM0_BASE + ALIGN_UP_TO_2MB(ramsize);
>>>>> +        region_size[0] = GUEST_RAM0_SIZE - ALIGN_UP_TO_2MB(ramsize);
>>>>> +        region_base[1] = GUEST_RAM1_BASE;
>>>>> +    } else
>>>>> +        region_base[1] = GUEST_RAM1_BASE +
>>>>> +            ALIGN_UP_TO_2MB(ramsize - GUEST_RAM0_SIZE);
>>>>> +
>>>>> +    bank1end = min(1ULL << info.gpaddr_bits, GUEST_RAM1_BASE + 
>>>>> GUEST_RAM1_SIZE);
>>>>> +    if (bank1end > region_base[1])
>>>>> +        region_size[1] = bank1end - region_base[1];
>>>>
>>>> It would be best to not rely on the fact that Bank on is always 
>>>> below 4GB. If the code is too complex then we should look to add a 
>>>> BUILD_BUG_ON() to avoid any surprise.
>>>
>>> Yes, I can add:
>>>
>>> BUILD_BUG_ON((GUEST_RAM0_BASE + GUEST_RAM0_SIZE) > GB(4));
>>
>> I am OK with that. But I wonder if we could simply use min(..., ) to 
>> avoid the BUILD_BUG_ON().

I think, we could. And probably we could avoid relying on the fact that 
Bank 0 is always below 4GB.

Below, the changes based on my understanding of the whole request. Would 
you be OK with them?


diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c
index e3140a6..53ae0f3 100644
--- a/tools/libs/light/libxl_arm.c
+++ b/tools/libs/light/libxl_arm.c
@@ -615,9 +615,12 @@ static int make_hypervisor_node(libxl__gc *gc, void 
*fdt,
                                "xen,xen");
      if (res) return res;

-    /* reg 0 is grant table space */
+    /*
+     * reg 0 is a placeholder for grant table space, reg 1...N are
+     * the placeholders for extended regions.
+     */
      res = fdt_property_regs(gc, fdt, GUEST_ROOT_ADDRESS_CELLS, 
GUEST_ROOT_SIZE_CELLS,
-                            1,GUEST_GNTTAB_BASE, GUEST_GNTTAB_SIZE);
+                            GUEST_RAM_BANKS + 1, 0, 0, 0, 0, 0, 0);
      if (res) return res;

      /*
@@ -1069,6 +1072,74 @@ static void finalise_one_node(libxl__gc *gc, void 
*fdt, const char *uname,
      }
  }

+#define ALIGN_UP_TO_2MB(x)   (((x) + MB(2) - 1) & (~(MB(2) - 1)))
+
+static void finalise_ext_region(libxl__gc *gc, struct xc_dom_image *dom)
+{
+    void *fdt = dom->devicetree_blob;
+    uint64_t region_size[GUEST_RAM_BANKS] = {0}, 
region_base[GUEST_RAM_BANKS],
+        bankend[GUEST_RAM_BANKS];
+    uint32_t regs[(GUEST_ROOT_ADDRESS_CELLS + GUEST_ROOT_SIZE_CELLS) *
+                  (GUEST_RAM_BANKS + 1)];
+    be32 *cells = &regs[0];
+    const uint64_t bankbase[] = GUEST_RAM_BANK_BASES;
+    const uint64_t banksize[] = GUEST_RAM_BANK_SIZES;
+    unsigned int i, len, nr_regions = 0;
+    libxl_dominfo info;
+    int offset, rc;
+
+    offset = fdt_path_offset(fdt, "/hypervisor");
+    assert(offset > 0);
+
+    rc = libxl_domain_info(CTX, &info, dom->guest_domid);
+    assert(!rc);
+
+    assert(info.gpaddr_bits <= 64);
+
+    /*
+     * Try to allocate separate 2MB-aligned extended regions from the first
+     * and second RAM banks taking into the account the maximum supported
+     * guest physical address space size and the amount of memory assigned
+     * to the guest.
+     */
+    for (i = 0; i < GUEST_RAM_BANKS; i++) {
+        region_base[i] = bankbase[i] +
+            ALIGN_UP_TO_2MB((uint64_t)dom->rambank_size[i] << 
XC_PAGE_SHIFT);
+
+        bankend[i] = ~0ULL >> (64 - info.gpaddr_bits);
+        bankend[i] = min(bankend[i], bankbase[i] + banksize[i] - 1);
+        if (bankend[i] > region_base[i])
+            region_size[i] = bankend[i] - region_base[i] + 1;
+    }
+
+    /*
+     * The region 0 for grant table space must be always present. If we 
managed
+     * to allocate the extended regions then insert them as regions 1...N.
+     */
+    set_range(&cells, GUEST_ROOT_ADDRESS_CELLS, GUEST_ROOT_SIZE_CELLS,
+              GUEST_GNTTAB_BASE, GUEST_GNTTAB_SIZE);
+
+    for (i = 0; i < GUEST_RAM_BANKS; i++) {
+        if (region_size[i] < GUEST_EXT_REGION_MIN_SIZE)
+            continue;
+
+        LOG(DEBUG, "Extended region %u: %#"PRIx64"->%#"PRIx64"",
+            nr_regions, region_base[i], region_base[i] + region_size[i]);
+
+        set_range(&cells, GUEST_ROOT_ADDRESS_CELLS, GUEST_ROOT_SIZE_CELLS,
+                  region_base[i], region_size[i]);
+        nr_regions++;
+    }
+
+    if (!nr_regions)
+        LOG(WARN, "The extended regions cannot be allocated, not enough 
space");
+
+    len = sizeof(regs[0]) * (GUEST_ROOT_ADDRESS_CELLS + 
GUEST_ROOT_SIZE_CELLS) *
+        (nr_regions + 1);
+    rc = fdt_setprop(fdt, offset, "reg", regs, len);
+    assert(!rc);
+}
+
  int libxl__arch_domain_finalise_hw_description(libxl__gc *gc,
                                                 uint32_t domid,
libxl_domain_config *d_config,
@@ -1109,6 +1180,8 @@ int 
libxl__arch_domain_finalise_hw_description(libxl__gc *gc,

      }

+    finalise_ext_region(gc, dom);
+
      for (i = 0; i < GUEST_RAM_BANKS; i++) {
          const uint64_t size = (uint64_t)dom->rambank_size[i] << 
XC_PAGE_SHIFT;

diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h
index d46c61f..7425a78 100644
--- a/xen/include/public/arch-arm.h
+++ b/xen/include/public/arch-arm.h
@@ -438,6 +438,11 @@ typedef uint64_t xen_callback_t;

  #define GUEST_RAM_BANKS   2

+/*
+ * The way to find the extended regions (to be exposed to the guest as 
unused
+ * address space) relies on the fact that the regions reserved for the RAM
+ * below are big enough to also accommodate such regions.
+ */
  #define GUEST_RAM0_BASE   xen_mk_ullong(0x40000000) /* 3GB of low RAM 
@ 1GB */
  #define GUEST_RAM0_SIZE   xen_mk_ullong(0xc0000000)

@@ -451,6 +456,8 @@ typedef uint64_t xen_callback_t;
  #define GUEST_RAM_BANK_BASES   { GUEST_RAM0_BASE, GUEST_RAM1_BASE }
  #define GUEST_RAM_BANK_SIZES   { GUEST_RAM0_SIZE, GUEST_RAM1_SIZE }

+#define GUEST_EXT_REGION_MIN_SIZE   xen_mk_ullong(0x0004000000) /* 64MB */
+
  /* Current supported guest VCPUs */
  #define GUEST_MAX_VCPUS 128

(END)





-- 
Regards,

Oleksandr Tyshchenko



From xen-devel-bounces@lists.xenproject.org Wed Oct 13 13:50:45 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 13:50:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.208500.364644 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maeeZ-0000jK-PU; Wed, 13 Oct 2021 13:50:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 208500.364644; Wed, 13 Oct 2021 13:50:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maeeZ-0000jD-M2; Wed, 13 Oct 2021 13:50:43 +0000
Received: by outflank-mailman (input) for mailman id 208500;
 Wed, 13 Oct 2021 13:50:42 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=dUCo=PB=gmail.com=olekstysh@srs-us1.protection.inumbo.net>)
 id 1maeeX-0000j5-Vu
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 13:50:42 +0000
Received: from mail-lf1-x12e.google.com (unknown [2a00:1450:4864:20::12e])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 526e0d2f-3966-48be-9db4-b072b00475ea;
 Wed, 13 Oct 2021 13:50:40 +0000 (UTC)
Received: by mail-lf1-x12e.google.com with SMTP id z11so11869402lfj.4
 for <xen-devel@lists.xenproject.org>; Wed, 13 Oct 2021 06:50:40 -0700 (PDT)
Received: from [192.168.1.7] ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id p9sm1335732lfe.3.2021.10.13.06.50.29
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Wed, 13 Oct 2021 06:50:29 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 526e0d2f-3966-48be-9db4-b072b00475ea
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:from:to:cc:references:message-id:date:user-agent
         :mime-version:in-reply-to:content-transfer-encoding:content-language;
        bh=NSV/K9ePwjVIZfFs78yQ3l0wA286NpS0XFWxQbT0C4E=;
        b=Skrfz1Q1YGyYdb3znOEMI0EbnlOH00fXYJ5Fle3seXfn/GVjkCJCrythYp/wHq2ybH
         4VbQ3oj5VZl/AqRBSGcCYs9ONor3ssR5dnuCZ4bVzMwM2hlFX8VfIWfyuf5XPVOe01R6
         jbQWzR0osgOxUCHH33re0MG/YtQpCX59+mg7/UGnZ1SGVZvdQlH1QL3DjLI8MMZMqEcN
         djygrgcrScZjYj5kcgxG/IQA/PK7LVfkidUjtAfti6WeHf9BmvY2r3rWapbvPF1xyc2T
         0PFTUJ9tLR0II2pIUT7Nh2V7SGxNEECBnONqjFf3k0xRTCBnfSPTSePTnK/WKbmtsM5u
         hVeg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:from:to:cc:references:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding
         :content-language;
        bh=NSV/K9ePwjVIZfFs78yQ3l0wA286NpS0XFWxQbT0C4E=;
        b=cYtBygB6zRponP4rmfVhjeSZVwf82q17P6wggxS4Y5VAYgr4Bt+yhZyLHlBfF7bzEO
         XJbxvdE6x/cDST2I/b4gKvfPNAbEJksCtyciUxt5nQwOdaNo9LlaS1tBefehrAucEJhq
         QclF0URBJ8nOk6/GWg+2XkvZ/uERg1t0nV/ut335T2JHIbZVfpxIVSbsByUKFF1ad29u
         Rm4dldLE9CR1Gl3fNw76mrdcctMTW9VyVzj7ytdoWGd7RzGn04GjWgZqUVFb18nKvWEg
         Oc8tOSNi8VxpgE8Q5FCpvsg7il41T4AiIh0TAB33DvCvOlaWtOQVzzC65qVLgHGhdDJk
         vbjg==
X-Gm-Message-State: AOAM533NlZuJITXwog/ntmqqdEW45wfEYQm1WAvP6C0Ajd4Zhu0nyryA
	xZJtxBhuZlShnsdikIIVOjU=
X-Google-Smtp-Source: ABdhPJwBlfPA5wjugLKdl9W8pjFeJrLXeWdjjnx/Jc1/LmH++1zYWA1p+gsByZvoqFbM7t3svANU4g==
X-Received: by 2002:ac2:5edd:: with SMTP id d29mr3776403lfq.511.1634133030232;
        Wed, 13 Oct 2021 06:50:30 -0700 (PDT)
Subject: Re: [PATCH V6 1/2] xen/arm: Introduce gpaddr_bits field to struct
 xen_domctl_getdomaininfo
From: Oleksandr <olekstysh@gmail.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: xen-devel@lists.xenproject.org,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>,
 Anthony PERARD <anthony.perard@citrix.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Juergen Gross
 <jgross@suse.com>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <9e6e1378-7ee3-b692-b57d-29b597160661@gmail.com>
 <1634073720-27901-1-git-send-email-olekstysh@gmail.com>
Message-ID: <7ec7e2c5-3b45-c6f5-fabd-0b399cc1229f@gmail.com>
Date: Wed, 13 Oct 2021 16:50:28 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <1634073720-27901-1-git-send-email-olekstysh@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US


Hi Jan.


May I please ask, are you OK with the proposed changes?


On 13.10.21 00:22, Oleksandr Tyshchenko wrote:
> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>
> We need to pass info about maximum supported guest physical
> address space size to the toolstack on Arm in order to properly
> calculate the base and size of the extended region (safe range)
> for the guest. The extended region is unused address space which
> could be safely used by domain for foreign/grant mappings on Arm.
> The extended region itself will be handled by the subsequent
> patch.
>
> Currently the same guest physical address space size is used
> for all guests (p2m_ipa_bits variable on Arm, the x86 equivalent
> is hap_paddr_bits).
>
> Add an explicit padding after "gpaddr_bits" field and also
> (while at it) after "domain" field.
>
> Also make sure that full structure is cleared in all cases by
> moving the clearing into getdomaininfo(). Currently it is only
> cleared by the sysctl caller (and only once).
>
> Please note, we do not need to bump XEN_DOMCTL_INTERFACE_VERSION
> as a bump has already occurred in this release cycle. But we do
> need to bump XEN_SYSCTL_INTERFACE_VERSION as the structure is
> re-used in a sysctl.
>
> Suggested-by: Julien Grall <jgrall@amazon.com>
> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> Reviewed-by: Ian Jackson <iwj@xenproject.org>
> ---
> Changes RFC -> V2:
>     - update patch subject/description
>     - replace arch-specific sub-struct with common gpaddr_bits
>       field and update code to reflect that
>
> Changes V2 -> V3:
>     - make the field uint8_t and add uint8_t pad[7] after
>     - remove leading blanks in libxl.h
>
> Changes V3 -> V4:
>     - also print gpaddr_bits from output_physinfo()
>     - add Michal's R-b
>
> Changes V4 -> V5:
>     - update patch subject and description
>     - drop Michal's R-b
>     - pass gpaddr_bits via createdomain domctl
>       (struct xen_arch_domainconfig)
>
> Changes V5 -> V6:
>     - update patch subject and description
>     - pass gpaddr_bits via getdomaininfo domctl
>       (struct xen_domctl_getdomaininfo)
>
> Changes V6 -> V7:
>     - update patch description
>     - do not bump XEN_DOMCTL_INTERFACE_VERSION
>     - bump XEN_SYSCTL_INTERFACE_VERSION
>     - add explicit paddings
>     - clear the full structure in getdomaininfo()
>     - add Ian's R-b
> ---
>   tools/include/libxl.h            | 8 ++++++++
>   tools/include/xenctrl.h          | 1 +
>   tools/libs/ctrl/xc_domain.c      | 1 +
>   tools/libs/light/libxl_domain.c  | 1 +
>   tools/libs/light/libxl_types.idl | 1 +
>   xen/arch/arm/domctl.c            | 2 ++
>   xen/arch/x86/domctl.c            | 1 +
>   xen/common/domctl.c              | 6 +++---
>   xen/common/sysctl.c              | 2 +-
>   xen/include/public/domctl.h      | 3 +++
>   xen/include/public/sysctl.h      | 2 +-
>   11 files changed, 23 insertions(+), 5 deletions(-)
>
> diff --git a/tools/include/libxl.h b/tools/include/libxl.h
> index b9ba16d..deb5022 100644
> --- a/tools/include/libxl.h
> +++ b/tools/include/libxl.h
> @@ -874,6 +874,14 @@ typedef struct libxl__ctx libxl_ctx;
>   #define LIBXL_HAVE_DOMINFO_NEVER_STOP 1
>   
>   /*
> + * LIBXL_HAVE_DOMINFO_GPADDR_BITS
> + *
> + * If this is defined, libxl_dominfo will contain an uint8 field called
> + * gpaddr_bits, containing the guest physical address space size.
> + */
> +#define LIBXL_HAVE_DOMINFO_GPADDR_BITS 1
> +
> +/*
>    * LIBXL_HAVE_QXL
>    *
>    * If defined, then the libxl_vga_interface_type will contain another value:
> diff --git a/tools/include/xenctrl.h b/tools/include/xenctrl.h
> index a306399..07b96e6 100644
> --- a/tools/include/xenctrl.h
> +++ b/tools/include/xenctrl.h
> @@ -462,6 +462,7 @@ typedef struct xc_dominfo {
>       unsigned int  max_vcpu_id;
>       xen_domain_handle_t handle;
>       unsigned int  cpupool;
> +    uint8_t       gpaddr_bits;
>       struct xen_arch_domainconfig arch_config;
>   } xc_dominfo_t;
>   
> diff --git a/tools/libs/ctrl/xc_domain.c b/tools/libs/ctrl/xc_domain.c
> index 23322b7..b155d6a 100644
> --- a/tools/libs/ctrl/xc_domain.c
> +++ b/tools/libs/ctrl/xc_domain.c
> @@ -396,6 +396,7 @@ int xc_domain_getinfo(xc_interface *xch,
>           info->nr_online_vcpus = domctl.u.getdomaininfo.nr_online_vcpus;
>           info->max_vcpu_id = domctl.u.getdomaininfo.max_vcpu_id;
>           info->cpupool = domctl.u.getdomaininfo.cpupool;
> +        info->gpaddr_bits = domctl.u.getdomaininfo.gpaddr_bits;
>           info->arch_config = domctl.u.getdomaininfo.arch_config;
>   
>           memcpy(info->handle, domctl.u.getdomaininfo.handle,
> diff --git a/tools/libs/light/libxl_domain.c b/tools/libs/light/libxl_domain.c
> index 51a6127..544a9bf 100644
> --- a/tools/libs/light/libxl_domain.c
> +++ b/tools/libs/light/libxl_domain.c
> @@ -306,6 +306,7 @@ void libxl__xcinfo2xlinfo(libxl_ctx *ctx,
>       xlinfo->vcpu_max_id = xcinfo->max_vcpu_id;
>       xlinfo->vcpu_online = xcinfo->nr_online_vcpus;
>       xlinfo->cpupool = xcinfo->cpupool;
> +    xlinfo->gpaddr_bits = xcinfo->gpaddr_bits;
>       xlinfo->domain_type = (xcinfo->flags & XEN_DOMINF_hvm_guest) ?
>           LIBXL_DOMAIN_TYPE_HVM : LIBXL_DOMAIN_TYPE_PV;
>   }
> diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_types.idl
> index 3f9fff6..2df7258 100644
> --- a/tools/libs/light/libxl_types.idl
> +++ b/tools/libs/light/libxl_types.idl
> @@ -357,6 +357,7 @@ libxl_dominfo = Struct("dominfo",[
>       ("vcpu_max_id", uint32),
>       ("vcpu_online", uint32),
>       ("cpupool",     uint32),
> +    ("gpaddr_bits", uint8),
>       ("domain_type", libxl_domain_type),
>       ], dir=DIR_OUT)
>   
> diff --git a/xen/arch/arm/domctl.c b/xen/arch/arm/domctl.c
> index b7d27f3..6245af6 100644
> --- a/xen/arch/arm/domctl.c
> +++ b/xen/arch/arm/domctl.c
> @@ -20,6 +20,8 @@ void arch_get_domain_info(const struct domain *d,
>   {
>       /* All ARM domains use hardware assisted paging. */
>       info->flags |= XEN_DOMINF_hap;
> +
> +    info->gpaddr_bits = p2m_ipa_bits;
>   }
>   
>   static int handle_vuart_init(struct domain *d,
> diff --git a/xen/arch/x86/domctl.c b/xen/arch/x86/domctl.c
> index 26a76d2..7d102e0 100644
> --- a/xen/arch/x86/domctl.c
> +++ b/xen/arch/x86/domctl.c
> @@ -151,6 +151,7 @@ void arch_get_domain_info(const struct domain *d,
>           info->flags |= XEN_DOMINF_hap;
>   
>       info->arch_config.emulation_flags = d->arch.emulation_flags;
> +    info->gpaddr_bits = hap_paddr_bits;
>   }
>   
>   static int do_vmtrace_op(struct domain *d, struct xen_domctl_vmtrace_op *op,
> diff --git a/xen/common/domctl.c b/xen/common/domctl.c
> index 12d6144..2d07a12 100644
> --- a/xen/common/domctl.c
> +++ b/xen/common/domctl.c
> @@ -69,10 +69,10 @@ void getdomaininfo(struct domain *d, struct xen_domctl_getdomaininfo *info)
>       int flags = XEN_DOMINF_blocked;
>       struct vcpu_runstate_info runstate;
>   
> +    memset(info, 0, sizeof(*info));
> +
>       info->domain = d->domain_id;
>       info->max_vcpu_id = XEN_INVALID_MAX_VCPU_ID;
> -    info->nr_online_vcpus = 0;
> -    info->ssidref = 0;
>   
>       /*
>        * - domain is marked as blocked only if all its vcpus are blocked
> @@ -95,7 +95,7 @@ void getdomaininfo(struct domain *d, struct xen_domctl_getdomaininfo *info)
>   
>       info->cpu_time = cpu_time;
>   
> -    info->flags = (info->nr_online_vcpus ? flags : 0) |
> +    info->flags |= (info->nr_online_vcpus ? flags : 0) |
>           ((d->is_dying == DOMDYING_dead) ? XEN_DOMINF_dying     : 0) |
>           (d->is_shut_down                ? XEN_DOMINF_shutdown  : 0) |
>           (d->controller_pause_count > 0  ? XEN_DOMINF_paused    : 0) |
> diff --git a/xen/common/sysctl.c b/xen/common/sysctl.c
> index 3558641..a7ab95d 100644
> --- a/xen/common/sysctl.c
> +++ b/xen/common/sysctl.c
> @@ -76,7 +76,7 @@ long do_sysctl(XEN_GUEST_HANDLE_PARAM(xen_sysctl_t) u_sysctl)
>       case XEN_SYSCTL_getdomaininfolist:
>       {
>           struct domain *d;
> -        struct xen_domctl_getdomaininfo info = { 0 };
> +        struct xen_domctl_getdomaininfo info;
>           u32 num_domains = 0;
>   
>           rcu_read_lock(&domlist_read_lock);
> diff --git a/xen/include/public/domctl.h b/xen/include/public/domctl.h
> index 4cb3f66..46acc8f 100644
> --- a/xen/include/public/domctl.h
> +++ b/xen/include/public/domctl.h
> @@ -106,6 +106,7 @@ struct xen_domctl_createdomain {
>   struct xen_domctl_getdomaininfo {
>       /* OUT variables. */
>       domid_t  domain;              /* Also echoed in domctl.domain */
> +    uint16_t pad1;
>    /* Domain is scheduled to die. */
>   #define _XEN_DOMINF_dying     0
>   #define XEN_DOMINF_dying      (1U<<_XEN_DOMINF_dying)
> @@ -150,6 +151,8 @@ struct xen_domctl_getdomaininfo {
>       uint32_t ssidref;
>       xen_domain_handle_t handle;
>       uint32_t cpupool;
> +    uint8_t gpaddr_bits; /* Guest physical address space size. */
> +    uint8_t pad2[7];
>       struct xen_arch_domainconfig arch_config;
>   };
>   typedef struct xen_domctl_getdomaininfo xen_domctl_getdomaininfo_t;
> diff --git a/xen/include/public/sysctl.h b/xen/include/public/sysctl.h
> index 039ccf8..41ef7a2 100644
> --- a/xen/include/public/sysctl.h
> +++ b/xen/include/public/sysctl.h
> @@ -35,7 +35,7 @@
>   #include "domctl.h"
>   #include "physdev.h"
>   
> -#define XEN_SYSCTL_INTERFACE_VERSION 0x00000013
> +#define XEN_SYSCTL_INTERFACE_VERSION 0x00000014
>   
>   /*
>    * Read console content from Xen buffer ring.

-- 
Regards,

Oleksandr Tyshchenko



From xen-devel-bounces@lists.xenproject.org Wed Oct 13 13:52:20 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 13:52:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.208511.364655 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maeg4-0001Nb-AN; Wed, 13 Oct 2021 13:52:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 208511.364655; Wed, 13 Oct 2021 13:52:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maeg4-0001NU-6i; Wed, 13 Oct 2021 13:52:16 +0000
Received: by outflank-mailman (input) for mailman id 208511;
 Wed, 13 Oct 2021 13:52:15 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=EFKL=PB=citrix.com=roger.pau@srs-us1.protection.inumbo.net>)
 id 1maeg2-0001NO-NE
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 13:52:14 +0000
Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id c445a604-2c2c-11ec-8171-12813bfff9fa;
 Wed, 13 Oct 2021 13:52:13 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c445a604-2c2c-11ec-8171-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1634133132;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=qMEyeyi2uAwQCL5PyU4dXpnf9gqe9XEjVYdD7fEJQb8=;
  b=PciBmR6hKwvX9Wg1uvN3/cjybFnQ6ItcaFvE8WOAT14OGBdugsOyK0Lb
   cojJzbR0V97vNq2h6V9oq92nRCcP30PDvuSZUSsoNKjtDPu2agE95vJnG
   N5DOCE5wUykOoyO7JqXp0ayw90VcWmjDkWXcsDIuATm3g8MAxnw4M/toK
   o=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: KNDd8LRWFeTJSxstTAsw0ADtxOlLfRUfZPR/4Cgr1P6nuuCFJsTM38LQVI7pyTGl03DHAqUIcK
 BSY2RtxJjVg5wbGTrqnRQMyXrNPW3B1o8/uGycf8xIG8NQzkMnHW4NOF/gQBVzVUmMZN5d66dr
 yUYDoVEkZ/NKvVHyl03cyoBIgPeyHSdd7p6OVzxZaX0TUIZzNMkp2p8CKn4lqRPSoRq3KZlSzu
 edtJKNUPX1pB69xJfkE01aCOMNsSwQPPOBYqg6jmoBp4d1tjsLwQkztydVcinJgc2QOVr7lBSg
 AWhd4GHpxlR60gnuqY319EfA
X-SBRS: 5.1
X-MesageID: 55121596
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:c+86J6p9N4JDdzFYVQCcNgxbM7ZeBmIhYxIvgKrLsJaIsI4StFCzt
 garIBmPb66LMGr9e98gaN6x9ktS75HXz9Q2QVdqrCBhHi4b9JuZCYyVIHmrMnLJJKUvbq7GA
 +byyDXkBJppJpMJjk71atANlZT4vE2xbuKU5NTsY0idfic5Dnd84f5fs7Rh2Ncx2YHiW1jlV
 e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL
 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9
 DlCnZH3dT0gAPLmor8AD0hhInFAJJxg6paSdBBTseTLp6HHW37lwvEoB0AqJ4wIvO1wBAmi9
 9RBdmpLNErawbvrnvTrEYGAhex6RCXvFJkYtXx6iynQEN4tQIzZQrWM7thdtNs1rp0TRKyHO
 ptHAdZpRDf5WEYIM34VMoMRpriFglfbaw1jonvA8MLb5ECMlVcsgdABKuH9eNaHWMFUlUawv
 X/d8iLyBRRyHPWF1TeAxVe9iebOkD3TVZobEfuz8fsCqFee3HAJARsaE16yu+Cki1WWUshab
 UcT/0IGqqw/91eiSNXnaBS+rGSZpR4XW9dWEOoS5RmEz+zf5APxLnINTiNFLscnssA2bTUw0
 xmCmNaBLSJotLqZWHeM7ICepDm5OTUWBWIabCpCRgwAi/HzrYd2gh/RQ9JLFK+uksazCTz22
 yqNriU1m/MUl8Fj/6y98Uqd22r0jpfMRw8xoA7QWwqN7B59ZYOjT5yl7x7c9/koBIGdQ1qat
 X4Igf+C/fsOBpGAki+KaOgVFbTv7PGAWBXHmkJmFZQl8zWr+lagcJpW7TU4I11mWvvoYhewP
 hWV41kIosYOYj36Nsebfr5dFewnipTaHOq6fMqPc4YfW6khSha22jNHMBv4M3/WrGAglqQ2O
 JG+eMmqDGoHBakP8AdaV9vxwpdwmXhgnTK7qYTTik39i+LHNSH9paItaQPWNogEALW4TBI5G
 jq1H/CBzAlDS6XAay3T/J97wbsifCVjW86eRyC6cIe+zuta9IMJV6G5LVAJIdUNc0FpegHgp
 S7VtqhwkguXuJE/AV/WAk2Pko/HU5dltm4cNicxJ1uu0HVLSd/xt/tHKcdtJeN7r7ALIRtIo
 x8tIJro7hNnEGWvxtjgRcOl8NwKmOqD1GpiwBZJkBBgJsU9FmQlC/fvfxf19TlmM8ZEnZBWn
 lFU7SuCGcBrb107VK7+Mavzp3vs7Sl1sL8jBCPgf4gMEHgABaA3ckTZlOEsGcgQJH3rn33Cv
 +pgKUxD/relTk5c2IShuJ1oWK/wS7EgQREAQzWChVt0XAGDlleeLUZ7eL/gVRjWVX/u+bXkY
 uNQzvrmN+YAkkoMuI15e4uHB4pnurMDfpdWkVZpGmvldVOuBu8yK3WKx5AX5KZM2qVYqU29X
 UfWootWPrCAOcXEFl8NJVV6MrTfhK9MwjSCv+4oJEja5TNs+ObVW0tlIBTR2jdWK6F4Md15z
 L556tIW8QG2ljEjLs2C0nJP722JI3FZC/cnu5gWDZXFkA0uzl0eM5XQBjWvuMOEaslWM1lsK
 TiR3fKQi7NZz0vEUnwyCXmSgrYN2cVQ4EhHlQZQKU6Il9zJgu4M8CdQqTlnHB5Iyhhn0v5oP
 jQ5PUNCOqjTrSxjg9JOXj7wFlgZVgGZ4EH413AAiHbdExuzTmXIIWAwZbSN8UQe/z4OdzRX5
 ujFmmPsUDKsd8DtxCoiH0VirqW7H9B28wTDnuGhHtiEQMZmMWa03Pf2aDpasQbjDOMwmFbD9
 Ltj8+tHYKHmMTId/v8gAI6A2LVMEB2JKQSumx26EH/lyY0ERAyP5A==
IronPort-HdrOrdr: A9a23:XqL/66prpDORU8F+9ynnUQAaV5vNL9V00zEX/kB9WHVpm5Oj+f
 xGzc516farslossREb+expOMG7MBXhHLpOkPQs1NaZLXPbUQ6TTb2KgrGSpgEIdxeOktK1kJ
 0QD5SWa+eAfGSS7/yKmDVQeuxIqLLsndHK9IWuv0uFDzsaEJ2Ihz0JdDpzeXcGPTWua6BJc6
 Z1saF81kWdkDksH46GL0hAe9KGi8zAlZrgbxJDLxk76DOWhTftzLLhCRCX0joXTjsKmN4ZgC
 T4uj28wp/mn+Cwyxfa2WOWx5NKmOH5wt8GIMCXkMAaJhjllw7tToV8XL+puiwzvYiUmRsXue
 iJhy1lE9V46nvXcG3wiRzx2zP42DJr0HPmwU/wuwqrneXJABYBT+ZRj4NQdRXUr2A6ustn7a
 5N12WF87JKEBLphk3Glpn1fiAvsnDxjWspkOYVgXAae5AZcqVtoYsW+14QOIscHRj99JssHI
 BVfY/hDc5tABCnhk3izytSKITGZAV3Iv7GeDlMhiWt6UkXoJgjpHFogPD2nR87heQAotd/lq
 P5259T5cNzp/ktHNVA7dc6MLiK41P2MGfx2UKpUBza/fI8SjnwQ6Ce2sRA2AjtQu1P8KcP
X-IronPort-AV: E=Sophos;i="5.85,371,1624334400"; 
   d="scan'208";a="55121596"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Y/qfGyglmEfZT2H/28720Iy6WnnDs5i59pZezPDGwlB7FV77chE8iK7FO6KP0TxbQ1brQIXoM8lhZ2+2dysF0Vics+1OLwRcePlYYtgJ5MTlq+mzPacrLhCE+eQ3Vq70m1FnS7njliXy20raCN7THgghTqCKA+WYYeaGYFjsfBk7wXxs0deVDrXE/QT+z+4gXofQXN6egYX5auUShK3zlM/A6K/OYMNCC2FZdSn46D7W0pAQ6vjqK5TiwCiKI4jM+HbL4sRIvZRlZFMPCDtRVkPMpSwgyx5IERNDC+/qeH/rKnhNcQMf+IHXkWH5yVnoiEEkC7kpWrV8nUbSjeJkLQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=znmL2VsZyswrFXo+HvBQ3H9BhIB3br/XyfI/1dG6drc=;
 b=iDNk6DIBinD8rjD0rnISProp39A6t/TzBKPe5YmlYSHMX7UxFSftdUJzjRh9Ns8MIgTk5Rqk9Q1PryAVMkHu1drsZ0tUMGdErxlZa0uWqoJk3W/5o0kxPZJXkLm6M8CD181cdGiiYlfSToEE8OMiEthajeozcckamdVhFW9hZ/ebzHdbWiR9Dsqj+D8NH0crfqS5iF/XNR0Xj2qgrVpTLlooIhLBV8QDOtdiJATx+oDLJafMLdZE4VD6Bqoq01ldTcPTfZVl3sZkiL+nFGYa10U5oWUBtG5bCT/0k0cP2RiWx84QoHafHtgpWcSoweAV5v3OToawLgQbS5LO5+SEBQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=znmL2VsZyswrFXo+HvBQ3H9BhIB3br/XyfI/1dG6drc=;
 b=xXZGgqbMJKffZ304P+biu0O/IlPFv6aOWqpflrHcRUqZkMW2UvQSFANuPeKArdwWLEWoDD0iQITUVbOkwhKwp+vmXqQFsDAQrpWCothjKUgBU6YLgnezqDlkOOe+7m/Y//qPo73wjc1VEI7BDu/bXSW0I83TBY1ssaxpRtMYfmE=
Date: Wed, 13 Oct 2021 15:51:35 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Oleksandr Andrushchenko <andr2000@gmail.com>
CC: <xen-devel@lists.xenproject.org>, <julien@xen.org>,
	<sstabellini@kernel.org>, <oleksandr_tyshchenko@epam.com>,
	<volodymyr_babchuk@epam.com>, <Artem_Mygaiev@epam.com>, <jbeulich@suse.com>,
	<bertrand.marquis@arm.com>, <rahul.singh@arm.com>, Oleksandr Andrushchenko
	<oleksandr_andrushchenko@epam.com>
Subject: Re: [PATCH v3 03/11] vpci/header: Move register assignments from
 init_bars
Message-ID: <YWbkZ216FbV8lBns@MacBook-Air-de-Roger.local>
References: <20210930075223.860329-1-andr2000@gmail.com>
 <20210930075223.860329-4-andr2000@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20210930075223.860329-4-andr2000@gmail.com>
X-ClientProxiedBy: LNXP123CA0014.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:d2::26) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 6c34bf8a-b6eb-48d2-8719-08d98e509509
X-MS-TrafficTypeDiagnostic: DM6PR03MB4476:
X-Microsoft-Antispam-PRVS: <DM6PR03MB44763D5AC8E8DDE88678AA658FB79@DM6PR03MB4476.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8273;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: l2z/6x9IUhkz7qzNQ8nxhcOmWZcvlFVZ+dDBf6ljDzgFKf2uqS0Lz4UMk+APvoyGeaG0YGeZ1YrZKdgt7pmZ30WPv89QYnIJRzqpo9Np2DF0wDEFC8teBx3H36rdZAd62y44QsKS5hGcr/zpIUOCpcM6Sx3UCadl8nyi8EW3Y1IZuWTL6WQ+xNqLHXbvDzE462tEPLoKqOFuke3Zowc5znOARAhO8wcvAqtd6/aAyKSmVHp6NX03msm7TO/T3GCGP0mO2EHr/vWqD4QCzdxOg3R2OPHVQon0Mhg8DyQtcnD9qeerm3UDRmeoyaD5AsXINnFCgQaQhrY2C0c4nTKwaLXWPANmPvZT7lORcCRbW70tH97oo/dcdkoTJfdrkRyJXYrvP/ukh0BePyxLyLQSGgsw1pe8crfXH4YF64xV78wx7+D5ROOYdVZ1r1PUhqN9zGGKfidyFF9ZSxwdV1LhfQoewzcUeOz7f3xtceHzUEqu+yiqulg2H4nCSVA8CHbSahlHorhlqDowVbrn+MJvujaMcpt5d0H6Hu2Dknkf66x5XdfcfoRqkCoczsGOPkK3PDJTO+q/aupdK7x3LGIXlDt9ym/eDRfJlcsB9xGHap9aLcHmESA65PgLiXowJNniwRQfU6a0mIRst3TaTbIdVw==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(82960400001)(186003)(7416002)(8676002)(5660300002)(4326008)(6486002)(26005)(8936002)(9686003)(83380400001)(956004)(85182001)(6916009)(66946007)(66556008)(86362001)(508600001)(66476007)(6496006)(2906002)(316002)(6666004)(38100700002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cG1VSEx3WWNZbzBTcTBLcGUwNGxHeGxOSG94WDhhTnFtWlVZUDh2eEJvSnNU?=
 =?utf-8?B?bXNCaXNQRmQvaGFOQzFFSStUWWNkZEZWV1ljcitzVTVuTlpsUW5hVmRtTS8r?=
 =?utf-8?B?WGFqblBWMHVFenFnZk4wNExzT01CN2dyaTVKanRaSkVING1uLzFzUk8vVWVr?=
 =?utf-8?B?UXNtMStRU0hYQjZlSHI1dW5GTXd0OW5VaWRjNHpvWndMWlQyUVZjcFFFTmFn?=
 =?utf-8?B?d2g2VnJlV2hRbW5oWG8wa1hhQVNJenFKSnhFem5wRitLNnJrckJWd2pvUDNN?=
 =?utf-8?B?ZmpEN0JYRzNSdnNzSXRrUWVCQmV0R2VHK2NWYnUrWVB0amVrYVJkUUZqOUJ6?=
 =?utf-8?B?WVI2OWNzbUlPWGNaTm5HWFRSR1ZjY3hCckJtOVBjWWNpQlZTMHIxWGVrbHhR?=
 =?utf-8?B?L2d4TGs5aG9sdy9TYURJNHc5QVM5c0h5R2hHY3ErOXEvbmEyNG5lYSsybFN4?=
 =?utf-8?B?UHNiaGNpNXpKK09rUWpJb3poZVlyRjZ2VDA4K29rS0hhTnBYTlN2eEd4VWFM?=
 =?utf-8?B?Tmp3OHhHRW1kdHZPMitBRFZFUGE3YlpML05lQk42TGVRUGx1K09Ea2YvNGlm?=
 =?utf-8?B?azVUdGl1MndGcUcvemFQTWhON25hWUtYWHVESkl2UERyc0h5c3ltZG9NM1RJ?=
 =?utf-8?B?MlV2Z2IwTnU5RmZobmtSNXVVWnhZTjNDUTJFa0Y5aXA2RmhDdTd6bGdoNHRw?=
 =?utf-8?B?dlVWZi8zeGt6UWN0dE1WOU1HOHQ5azgzVHVhRGZPWVFsNVhvcnVGMUFMcW5M?=
 =?utf-8?B?MVRRY1RmakNETUpWdjJjY3IrU0lqSk9PM2xGQ2JpL3JWY0JkaVEyNWQ1R2xX?=
 =?utf-8?B?aEFxUjArdlpaTGpaclR5TzNGMXlsMU1YUlp4SFJUR2kxVjBTTXFJMDJGdFZi?=
 =?utf-8?B?bkVZaUpveE54RWt1T0tHbHhEQ3ZXOVZ3YVdiMEtKN1lJaS93YXI2WWlxbkVV?=
 =?utf-8?B?L1pxMWM5Q0hvUEREeXI0aFg4MFpXTUg5bEhaU3g0SUtCRVVXbGxjWHFWaFN2?=
 =?utf-8?B?VHdJWUJIUUhTa1Byc2xsQlpFVGUrdUZHNG5oMGFvYnl5ekJiQzBpYWpRSTUw?=
 =?utf-8?B?VVFKYUxReTBINTdhMnZ5SXIySGxKcTVWcXo3WXZoeEVzYXJub2loWXZCYlJz?=
 =?utf-8?B?aVVMN3VVMTBFMXlnOVQ2Z3dValVLckhJUyt4SG5IbVBlVU1GTldrTE1aUDJs?=
 =?utf-8?B?WlF1NUtFckRvMWp2NnlER3lrNmU1TTlNaTYyaXFnWVVpVFBxdlhSRE1aTHJE?=
 =?utf-8?B?Z2F6K3BpcG0yUExJYmpWVXBwSXRTMFdyOFo1TTgxWDYzS05NWmliU00yNDdk?=
 =?utf-8?B?UmFtcG1uay9JZjJUbzdKZGhiWkVzeG9ndUd6VFVQSDZ5WTZmNGZxYU43VCsy?=
 =?utf-8?B?YUo0cG8rTk1aMk5yNExNTlBhMzFhV0JrZmlqcHRpZzZ2eElpallvMXBXS0NT?=
 =?utf-8?B?bTNYclMvREF0endyMXJRa2dyeXBZVkhITmQ2djd4V2Y0S1VYekt6aFFVQWRW?=
 =?utf-8?B?WDBZT04xSHlrNmxzOXpWZjNubFYvc2gxeTByakxuWGdQaStMeGpUeHlzOFlS?=
 =?utf-8?B?ZzBPT21rT1g0QWtoelA0SHBCOGdxVC9ITnIvQ3dENytiSkozUFRSVFZGRnhj?=
 =?utf-8?B?OGpkcDJVWVVRbm90U20xNUNJaXhTcUVjZ093MGF3QTRtcUVGM0I0STZxYWUr?=
 =?utf-8?B?RmpSQWRROEVMOTROT1laZzVzajZSSHMyeUpvaWxUUS9CSElZQ1RkaWlpTnlD?=
 =?utf-8?Q?9sLZBaDMfWIfr2vO/V54Q69rI1zGHv2mVvvpmGs?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 6c34bf8a-b6eb-48d2-8719-08d98e509509
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2021 13:51:39.9648
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Fwuhb0HR7XSZS14h9N5pzTP8x4IRRI6YxE0IznmoJrWQCnOaN9w//ONBB2skV3XgUR82wgkNUirRplRrlutcjw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4476
X-OriginatorOrg: citrix.com

On Thu, Sep 30, 2021 at 10:52:15AM +0300, Oleksandr Andrushchenko wrote:
> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> 
> This is in preparation for dynamic assignment of the vPCI register
> handlers depending on the domain: hwdom or guest.
> The need for this step is that it is easier to have all related functionality
> put at one place. When the subsequent patches add decisions on which
> handlers to install, e.g. hwdom or guest handlers, then this is easily
> achievable.

Won't it be possible to select the handlers to install in init_bars
itself?

Splitting it like that means you need to iterate over the numbers of
BARs twice (one in add_bar_handlers and one in init_bars), which makes
it more likely to introduce errors or divergences.

Decoupling the filling of vpci_bar data with setting the handlers
seems slightly confusing.

> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> 
> ---
> Since v1:
>  - constify struct pci_dev where possible
>  - extend patch description
> ---
>  xen/drivers/vpci/header.c | 83 ++++++++++++++++++++++++++-------------
>  1 file changed, 56 insertions(+), 27 deletions(-)
> 
> diff --git a/xen/drivers/vpci/header.c b/xen/drivers/vpci/header.c
> index f8cd55e7c024..3d571356397a 100644
> --- a/xen/drivers/vpci/header.c
> +++ b/xen/drivers/vpci/header.c
> @@ -445,6 +445,55 @@ static void rom_write(const struct pci_dev *pdev, unsigned int reg,
>          rom->addr = val & PCI_ROM_ADDRESS_MASK;
>  }
>  
> +static int add_bar_handlers(const struct pci_dev *pdev)

Making this const is again misleading IMO, as you end up modifying
fields inside the pdev, you get away with it because vpci data is
stored in a pointer.

> +{
> +    unsigned int i;
> +    struct vpci_header *header = &pdev->vpci->header;
> +    struct vpci_bar *bars = header->bars;
> +    int rc;
> +
> +    /* Setup a handler for the command register. */
> +    rc = vpci_add_register(pdev->vpci, vpci_hw_read16, cmd_write, PCI_COMMAND,
> +                           2, header);
> +    if ( rc )
> +        return rc;
> +
> +    if ( pdev->ignore_bars )
> +        return 0;

You can join both ifs above:

if ( rc || pdev->ignore_bars )
    return rc;

> +
> +    for ( i = 0; i < PCI_HEADER_NORMAL_NR_BARS + 1; i++ )

init_bars deals with both TYPE_NORMAL and TYPE_BRIDGE classes, yet you
seem to unconditionally assume PCI_HEADER_NORMAL_NR_BARS here (even
when below you take into account the different ROM BAR position).

> +    {
> +        if ( (bars[i].type == VPCI_BAR_IO) || (bars[i].type == VPCI_BAR_EMPTY) )
> +            continue;
> +
> +        if ( bars[i].type == VPCI_BAR_ROM )
> +        {
> +            unsigned int rom_reg;
> +            uint8_t header_type = pci_conf_read8(pdev->sbdf,
> +                                                 PCI_HEADER_TYPE) & 0x7f;

Missing newline, and unsigned int preferably for header_type.

> +            if ( header_type == PCI_HEADER_TYPE_NORMAL )
> +                rom_reg = PCI_ROM_ADDRESS;
> +            else
> +                rom_reg = PCI_ROM_ADDRESS1;
> +            rc = vpci_add_register(pdev->vpci, vpci_hw_read32, rom_write,
> +                                   rom_reg, 4, &bars[i]);
> +            if ( rc )
> +                return rc;
> +        }
> +        else
> +        {
> +            uint8_t reg = PCI_BASE_ADDRESS_0 + i * 4;

unsigned int please, we try to avoid using explicitly sized types
unless strictly necessary (ie: when dealing with hardware values for
example).

> +
> +            /* This is either VPCI_BAR_MEM32 or VPCI_BAR_MEM64_{LO|HI}. */
> +            rc = vpci_add_register(pdev->vpci, vpci_hw_read32, bar_write, reg,
> +                                   4, &bars[i]);
> +            if ( rc )
> +                return rc;
> +        }
> +    }
> +    return 0;
> +}
> +
>  static int init_bars(struct pci_dev *pdev)
>  {
>      uint16_t cmd;
> @@ -470,14 +519,8 @@ static int init_bars(struct pci_dev *pdev)
>          return -EOPNOTSUPP;
>      }
>  
> -    /* Setup a handler for the command register. */
> -    rc = vpci_add_register(pdev->vpci, vpci_hw_read16, cmd_write, PCI_COMMAND,
> -                           2, header);
> -    if ( rc )
> -        return rc;

I don't think you need to move the handler for the command register
inside add_bar_handlers: for once it makes the function name not
reflect what it actually does (as it then deals with both BARs and the
command register), and it would also prevent you from having to call
add_bar_handlers in if ignore_bars is set.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Wed Oct 13 13:56:12 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 13:56:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.208518.364666 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maejr-00023p-Pb; Wed, 13 Oct 2021 13:56:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 208518.364666; Wed, 13 Oct 2021 13:56:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maejr-00023i-Md; Wed, 13 Oct 2021 13:56:11 +0000
Received: by outflank-mailman (input) for mailman id 208518;
 Wed, 13 Oct 2021 13:56:10 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=bU9L=PB=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1maejq-00023c-28
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 13:56:10 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id c4b39c73-850e-465b-a57a-820f93968d1e;
 Wed, 13 Oct 2021 13:56:08 +0000 (UTC)
Received: from EUR01-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur01lp2054.outbound.protection.outlook.com [104.47.1.54]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-39-a5gHvHENMTWfTT_a33Db5Q-1; Wed, 13 Oct 2021 15:56:06 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB7039.eurprd04.prod.outlook.com (2603:10a6:800:12b::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.19; Wed, 13 Oct
 2021 13:56:03 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.016; Wed, 13 Oct 2021
 13:56:03 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6P195CA0090.EURP195.PROD.OUTLOOK.COM (2603:10a6:209:86::31) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.14 via Frontend Transport; Wed, 13 Oct 2021 13:56:02 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c4b39c73-850e-465b-a57a-820f93968d1e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634133367;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=yoXwDMfAOlFdy+y2EbMVV9zGinpkXLN3E04ealKOO20=;
	b=Alw2oIldSVe2XJkc/lHUxLeZhHCR0C/bfkQ6BHO/fv9btRY06rLRh9kY2ROQlPsdRb5eu+
	vhzMyyqxOlONWXngSkXMEJ+4cmqAhyxQx5PJcZ+fyFfl7LonpyDYRaVBjUSo7JgupjgkvR
	KOL42UnNwjXgmicrvWssNrxXHuUmyR4=
X-MC-Unique: a5gHvHENMTWfTT_a33Db5Q-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=H0j/36qbgZe2OiwSj7T3bMX6UdTh/UeJ9nUPWld1svkww+7bD5/9yju8MAyF8KIo4OQtzH7ahrwk0NBc3/ZnL36LFeQnQQF73u2S/K7/FbYwY4rOFpEmrU5PiQlafagBi7BuZ2GMaa8DtxGH0jAsVtZBhVFE+l4xi0LgrrNphxIp4ehSE5hVK9ehuefhxVglwP/kH6cr5DIPfqJAK3dj1sPyY2/1hRIOwrxKhfozdg6p6mEMmVYWU/+9+zWcna0ILKKrb6dNvdNWI/UUkXMCteiseGZvmEOy1Lv9e/Mo12Uo2WVGWjTQW1XUR7dhIXYLH0QVFP5G13VF57P4xbl8iA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=yoXwDMfAOlFdy+y2EbMVV9zGinpkXLN3E04ealKOO20=;
 b=gI6IiRbeDeGjV0BiKpHoBuo1UZzpLY6C0s2DEW3uzGwmJQqRFBgsRvX1lfqc9/pXyQYFYNLQJ/t3z6+MlMHQwo8l4PA1cYmlxN2pkSOSCxxYt4R9QfYq7P0k63OemR66m4o2IFT46Q87J58lvesieP3AefHhx4XjO3MqlLiH+Oy5LSaLuemJsaa+VCwQYQX4YV8evqu7g91zEMD2WwimiW1gnK/HdFNe6ijjLLXgblVO2BuuxQXwk0vP26Erlm2sSSmskMBxEyp3kDvYGiUMX007jA5iEb3u/BrnTjjlOY9YtOyO7Wn1KBP4QYyg1aYvzacfXQtfALGgO9ovmdlypQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: citrix.com; dkim=none (message not signed)
 header.d=none;citrix.com; dmarc=none action=none header.from=suse.com;
Subject: Re: [PATCH V6 1/2] xen/arm: Introduce gpaddr_bits field to struct
 xen_domctl_getdomaininfo
To: Oleksandr Tyshchenko <olekstysh@gmail.com>
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>,
 Anthony PERARD <anthony.perard@citrix.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Juergen Gross
 <jgross@suse.com>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 xen-devel@lists.xenproject.org, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>
References: <9e6e1378-7ee3-b692-b57d-29b597160661@gmail.com>
 <1634073720-27901-1-git-send-email-olekstysh@gmail.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <f9b8b55b-cfe4-2bfa-44db-e898800def72@suse.com>
Date: Wed, 13 Oct 2021 15:56:00 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <1634073720-27901-1-git-send-email-olekstysh@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P195CA0090.EURP195.PROD.OUTLOOK.COM
 (2603:10a6:209:86::31) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: ee9f86a7-1080-41a7-be0a-08d98e5131e2
X-MS-TrafficTypeDiagnostic: VI1PR04MB7039:
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB7039884AFCD13085A67C13C7B3B79@VI1PR04MB7039.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:5797;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Q2QgqOgLarFodQ7nKiG8Km/GLePtlfPa2+aa6xuiM6GBwD86rwOcAFGVOPf+7sLyYM6QCg18CNAgpTTBE2Eg/uFRgdCqRVT7N4hO9dPndD7EOhq+PMOD5YclcX1ruEOgvd7WkTUXRw2Eg/cXH2UmffLYjZh8ufVKctg8OtTUqUVCb/3/12VuRu9X+ZhkyEoEQ1hajnkbf7b0ZURAepMCcIRCKlPrvRFob5ew+fvsJQQh7CY9AsPLFI2/DF32/HVg85xPFa2Mk3rjKxmXk3mbHViVO4gPZGMhT+inHNRp/zTJFJdU5BBZ8y4OmLKwRoCWGeYM8zemQ784AVaP6WgnZ0mpOKjfF6YgJcZTYFfqaDCdUgxh40iBpQSny+yV7Ft2XTXqZpDVCyUvy7TujxFO1TrqMW8O9S5JgeIJcWMi8vg20hUJw2mJNTOprGDsgZjgxzmmUVWK1W5C49SGUrcZwETwy9ZTDWlBZDhTnAg2eDU1w7Cj4uDuMhKHAWubtUdH2eY3M4hvlwnP7twmvMy0pUqOKqiRYJWvrw07sJM33/UmgwbpZdtOdTU0in8Wa1yUEtzXQjGEj9FSUxQLZEVd0QMGqTp+4a1z4VF1jPjq3EtBkm2/CleKI5MNJ9bFbf85tT8zpQp/RWhbdXdrdm5xLjknvhYb9kkIeqznWk0UcL2u+eyakjfh8pOx+lZNhgbkoMmle0bCMnRMmsEHijlWFA5lIQkhnBXEJsupYEE8u6Mhmrl4NBiMxI6dek0KJZaK
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(7416002)(8676002)(38100700002)(2906002)(956004)(6916009)(66476007)(508600001)(186003)(5660300002)(16576012)(54906003)(26005)(31686004)(316002)(6486002)(31696002)(36756003)(86362001)(83380400001)(4744005)(4326008)(66946007)(8936002)(53546011)(66556008)(2616005)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?cFo1dWJCU0JpN3djc0VwRWh3SEdRTVJ3c0I4MHdNbHJJSW5IaFlFOU1uaDZJ?=
 =?utf-8?B?ME0vd0RKWHpnM2FyK2xiNDBka1VvQ1YrekRLN3NLWmZIZUZrTWp0aEttY2Z3?=
 =?utf-8?B?L0poYmJQTitlWklRZFdodDJhdENuNlBGNTRvYUlFVFhBTUsvSFZsWGFkRVRS?=
 =?utf-8?B?dUtXQndudTNqWnVYcFE0aG8yM216bm5tVDBMUVdqcU1seHprdmo2ZmpVSTZJ?=
 =?utf-8?B?ako2N3FDRFFjMWpxSTF2U3g4YUZOa1JvcG9XMisrbGNkazZVZUduZEZvYzhC?=
 =?utf-8?B?SXpaeklXRzN5Y09YZ2ZEQ0FQazVHbGk2WEZiSlJsbXdqOVZVWmRPZWxsRlJs?=
 =?utf-8?B?UGtQcFNJZlJDY1FqOHJDTmtsU1RIbUNjcnhmK1dtYXU2NlZJZU9JNDhtMHJT?=
 =?utf-8?B?WkhIcXR0YnhHdzBHVW82V2ZaKzVkVzVJWDkvbTNRcGQzSk5OK3ZSaUdqVk4v?=
 =?utf-8?B?dWl6RTRWR2RpNDVocmtvSHUyWDVRZW9JbWNpalE5SGs4L3lZYTJHQ09OamFh?=
 =?utf-8?B?WVdRMWw0WXBQOW5zSW82VHJNY250cXhQQW5WOW90QlpUaHptMURrV244Ym5u?=
 =?utf-8?B?VlpMalpDTE0rSFRvaC9JV21OQmZtZXBBYWdVMlI2anFoNFJaWnZabm55aXJs?=
 =?utf-8?B?MzBNT0NQcXRINGhORjhJZW1ZdC9sc3QyWC9JS0RnbFBoUmpwaWpKbmxDcU1Y?=
 =?utf-8?B?S3VaS2MwUEg3cHhJZ0t6TUN4Z3FDMXU5UzdzYlpUWFJWMU9RZWVVQVZEZEVG?=
 =?utf-8?B?UzQwMjNkWlk3NjZiZVFMcHlOTjhrN0xlbWNOQ1YzMXVubVYwY3NjL3F5Y3hh?=
 =?utf-8?B?M25BMjZYaGREaFhVcEZaVjNXeVRJazcvenN1djlPMXMxd1R0VENMaTU1dk5m?=
 =?utf-8?B?M3ZLR3JTYXMvRUQ2VDlpd1BVNFVKTVh6bU52QWJtOEV6UDNtai8vMW81ZmRa?=
 =?utf-8?B?Zm5BME02QUZ5aEMyL2tHbEFTWnNGdUtWQm1FbDJ0R0tkSlRjRlZCaWtBbzZC?=
 =?utf-8?B?WTZ0UXBodzVUZVhHWlFxV2VDTEU0MHB4V29KME1iQ2V6WU1RWndLaSsvN1gv?=
 =?utf-8?B?UWpkZWJNcTNnSnQ1Q2liRjZsTVNUbnZMNVBDR3h4SlBwREdFYXJseHBKdGQ2?=
 =?utf-8?B?VXlMT3lUbWJxUE10bWRRaTJTYTNkZDRjMncrOWZpcm9wNGthNHJ4OTV2anVN?=
 =?utf-8?B?SGtSa2JLY0Z4QmdSSVhSc2ZBdFVHeTVYY0tvSU9Bb1dIR2dteTNWVkhQdito?=
 =?utf-8?B?T0tmZ3ZhZnZrVHpzZVdsU0RubXZpbUo0dVhHWnFzMXZFTkJjY2RudnFhbjlj?=
 =?utf-8?B?ZXVycGRFYjUzVzh6dWxKclRENGVFY0VXKzlZRWY0djVjbGxITi9nU1lrcDkx?=
 =?utf-8?B?anB5TXhlOE01SkJhUFVqVmROa1dmcWRHamFZZ1Y5bjFzN00ybktLSjhON0Qx?=
 =?utf-8?B?RTFqRGZobmZjaGx0akxGd1FQb1BzZzNaOXpOZnBnbVNaemxvY2tZSWI4YW5a?=
 =?utf-8?B?eWxSQStqMkhnZm5HMTNXcFBteFRSSFdvVmh3dkJVczV1bEwyQzJIQzJmM3NY?=
 =?utf-8?B?emxma2dudHduTHFuWEhNc1FJR0ZMeFhUNG4xYmE4ZTEvNHNCUHljL2R5WWNt?=
 =?utf-8?B?OXpDVXlnOStwS2l2YmQ0WWhmZ3JJd0pMdkxHbTUvSTF4OUVUdWZjaVl0OUFw?=
 =?utf-8?B?VWE4Qkd1NmF0aVdVWXhVd2IvRzZaZStRUHVTaDMwN2pjSHhHV3A0UXRMbVpx?=
 =?utf-8?Q?x7kZuTQrzrxicYe+KFurrWfIEtk/HhS1p7PhQ7S?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ee9f86a7-1080-41a7-be0a-08d98e5131e2
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2021 13:56:03.1253
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: c7k+fhw7TONY6Xga2n2NiY5wpapJ8jK40BxE0k33a3uhge3X+Do17yygt19FiUWPlc0gBM3siop+VKpMUvdHWA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7039

On 12.10.2021 23:22, Oleksandr Tyshchenko wrote:
> @@ -95,7 +95,7 @@ void getdomaininfo(struct domain *d, struct xen_domctl_getdomaininfo *info)
>  
>      info->cpu_time = cpu_time;
>  
> -    info->flags = (info->nr_online_vcpus ? flags : 0) |
> +    info->flags |= (info->nr_online_vcpus ? flags : 0) |
>          ((d->is_dying == DOMDYING_dead) ? XEN_DOMINF_dying     : 0) |
>          (d->is_shut_down                ? XEN_DOMINF_shutdown  : 0) |
>          (d->controller_pause_count > 0  ? XEN_DOMINF_paused    : 0) |

I don't think this is a useful change - you move from a simple write
to a read-modify-write operation. With this dropped again, hypervisor
parts:
Reviewed-by: Jan Beulich <jbeulich@suse.com>

While this has meanwhile moved quite far from the original proposal,
I still wonder in how far Andrew may have remaining concerns. Did
you check with him, perhaps on irc? But of course catching his
attention may be difficult, so no (further) feedback by him should
probably not keep this from getting committed (if no other open
issues remain).

Jan



From xen-devel-bounces@lists.xenproject.org Wed Oct 13 14:07:36 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 14:07:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.208526.364676 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maeuh-0003c2-Na; Wed, 13 Oct 2021 14:07:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 208526.364676; Wed, 13 Oct 2021 14:07:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maeuh-0003bv-KP; Wed, 13 Oct 2021 14:07:23 +0000
Received: by outflank-mailman (input) for mailman id 208526;
 Wed, 13 Oct 2021 14:07:22 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Kt2p=PB=arm.com=Luca.Fancellu@srs-us1.protection.inumbo.net>)
 id 1maeuf-0003bp-QZ
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 14:07:21 +0000
Received: from EUR01-DB5-obe.outbound.protection.outlook.com (unknown
 [40.107.15.40]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 08c68fa6-b936-4fdb-add1-891e8b6575cd;
 Wed, 13 Oct 2021 14:07:20 +0000 (UTC)
Received: from DB6PR0801CA0043.eurprd08.prod.outlook.com (2603:10a6:4:2b::11)
 by AM6PR08MB4641.eurprd08.prod.outlook.com (2603:10a6:20b:d1::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.22; Wed, 13 Oct
 2021 14:07:16 +0000
Received: from DB5EUR03FT004.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:4:2b:cafe::8c) by DB6PR0801CA0043.outlook.office365.com
 (2603:10a6:4:2b::11) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.14 via Frontend
 Transport; Wed, 13 Oct 2021 14:07:16 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT004.mail.protection.outlook.com (10.152.20.128) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.15 via Frontend Transport; Wed, 13 Oct 2021 14:07:16 +0000
Received: ("Tessian outbound 8e26f7114b75:v103");
 Wed, 13 Oct 2021 14:07:16 +0000
Received: from 228b45dae248.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 81B96E6B-5DC7-4DD4-BBD2-FC23BA1BAEA8.1; 
 Wed, 13 Oct 2021 14:07:07 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 228b45dae248.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Wed, 13 Oct 2021 14:07:07 +0000
Received: from PAXPR08MB6816.eurprd08.prod.outlook.com (2603:10a6:102:130::10)
 by PAXPR08MB6576.eurprd08.prod.outlook.com (2603:10a6:102:15a::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15; Wed, 13 Oct
 2021 14:07:03 +0000
Received: from PAXPR08MB6816.eurprd08.prod.outlook.com
 ([fe80::c1b4:db1c:376f:b697]) by PAXPR08MB6816.eurprd08.prod.outlook.com
 ([fe80::c1b4:db1c:376f:b697%8]) with mapi id 15.20.4587.030; Wed, 13 Oct 2021
 14:07:03 +0000
Received: from smtpclient.apple (82.8.129.65) by
 LO4P123CA0255.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:194::8) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.15 via Frontend Transport; Wed, 13 Oct 2021 14:07:02 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 08c68fa6-b936-4fdb-add1-891e8b6575cd
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=sfA6gMJ2c8wdENhSn5Nh0dqlqb1eWZfxEowzKo86LGI=;
 b=klK4fGWMTwUbN+ONriM/syqDyIYvlrZQ+fnyQz07NUv0qU3DmpwU8EZHeAQokbAYfsTpCwPTNRYQiFQabJDB0EGUSWV492fOVOaQ4S96cZrL83XSFTlyEj2B1bhA3Qd3/qL80dhIycIzV012ecjnWBJG1N4SAWjo+6IJP+cC0A0=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 83c91f2ae6ef9177
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=LJtCoyGtWE6yIr9GyQ/4ajeoX8a68FDY1izUyMFy9oAVUuLJ6GuTudS/QP8OHH5Ck6jGsKk+VNhJ+eHQ6i5WSPfHMtehDtTjsd/UPkf2pQljmA9vW0RnrvshGCRdiJNr/tTx35M3u6VFX5ALSZiMF9tV+1d+whBM+Y7oRUJapO6PonLB/T64Siye38XsJGE5bHMr3rWIBD/g/Y1k3vvaN+Nm7U6n+8AWzLRYiXpWvLC1oRRlMSNAj9UynM/oKF1hdW6jlQRnrfYaLpihIuF5ykp8fSOS5180lw4smBwoNtqPDH5Gm0T0qPXgKKcTqqTFwgaxcWOFpcm3lkXmki/tRw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=sfA6gMJ2c8wdENhSn5Nh0dqlqb1eWZfxEowzKo86LGI=;
 b=b495Yd03x5Wez0DW+4/XExLJ2BZC3EnfIdVz2lCsHJBGw83pB1BaAb3QZ+4AGco7iZBjzGdRIrTMwDJ/m8nu617dk5yBdoKt2S9HUaweB9HCtr6rw112JdfOYsnB2mECCd2VrZ7T3JKIpIejjFHJDs+6HOJ2zNWP0JRBKxkolZGTN+oBLVaE/S1RK0w3vlD3mRf8bJsKNxZBTxfVTjQUINnNDlmLfNV6/6VVHA96/LKyPZNwA+E7OmvhyyEHQVRFEbJiD9YV1ZVKXZywzvhFIRmL5ogX22T2LiycIDVDhzHttAXpYuwexWD70VK8mbmLMI82/5jklXOtNRF4v4l9tg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=sfA6gMJ2c8wdENhSn5Nh0dqlqb1eWZfxEowzKo86LGI=;
 b=klK4fGWMTwUbN+ONriM/syqDyIYvlrZQ+fnyQz07NUv0qU3DmpwU8EZHeAQokbAYfsTpCwPTNRYQiFQabJDB0EGUSWV492fOVOaQ4S96cZrL83XSFTlyEj2B1bhA3Qd3/qL80dhIycIzV012ecjnWBJG1N4SAWjo+6IJP+cC0A0=
Authentication-Results-Original: xen.org; dkim=none (message not signed)
 header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
Content-Type: text/plain;
	charset=utf-8
Subject: Re: [PATCH] arm/docs: Clarify legacy DT bindings on UEFI
From: Luca Fancellu <luca.fancellu@arm.com>
In-Reply-To: <a31231e3-a1eb-0e1f-59b8-75677d5db51b@xen.org>
Date: Wed, 13 Oct 2021 15:06:56 +0100
Cc: xen-devel@lists.xenproject.org,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 wei.chen@arm.com,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Content-Transfer-Encoding: quoted-printable
Message-Id: <363EAF93-1165-4515-A582-B40B6115FA71@arm.com>
References: <20211013121929.30784-1-luca.fancellu@arm.com>
 <a31231e3-a1eb-0e1f-59b8-75677d5db51b@xen.org>
To: Julien Grall <julien@xen.org>
X-Mailer: Apple Mail (2.3654.120.0.1.13)
X-ClientProxiedBy: LO4P123CA0255.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:194::8) To PAXPR08MB6816.eurprd08.prod.outlook.com
 (2603:10a6:102:130::10)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 9cd52801-dda9-4c10-275d-08d98e52c349
X-MS-TrafficTypeDiagnostic: PAXPR08MB6576:|AM6PR08MB4641:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS:
	<AM6PR08MB464180E957B65B8DA4D7707AE4B79@AM6PR08MB4641.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 TGBD57ODc+uF43Ign5rJP03T3SgkSZczIP+/jHBFb7SbgXLSNS4mU+NVhpgna/rHOcubp7wWPUqyoZUUh2VSzfuAh4cChqTSpm+IXO52xFSTt07VSlgouydAN0q3+YRQkbpVLWTmdLSHo98VPOuDpMKSTqCTdhn7b5RpTaXdFuTgyhf1knH0O/qxne2MoBdA5+Oq1pR4qLFDWTFGWCWvW2ruKxf+P2eaDX8gxHf5K3X0U22yzPlDbvnOCnFaIR6C3AJ5NYGJXKE4yjUkKwYJLbUNDaJhdblIpfKARB2Tk22eGK5f6DmdiyP/bh3XP8qv9sRJmW9u/PsXDQwSjV9gtugDCISkbvgvs8nx95+nBM0Gx/vDjq3voyEYJzi1b8BjX72oA/d3HN6ifNG00T+YNeVVaspBBBodRxoaaFY1Wwl6/f/G/Hf/6ze8dtc7TjFiDZk3O2JI9OMIaf9nBZawWbPSZbr9NoaY8byTGot1YIpqF4ole4DGVj98rmV+Kl0qINpbPvkvzaV5194amAmCg2dkF0Sm3ionL2r0lCI0TvU9KEhLO5JbwqhBB/myWi0vBSzL1eDXmPDdaws4CSPyx5bwCKrCxO837kFVhG9oyjRuKoLr7cTGeiANuYj8mUAO6xoOzD39u7qNXwNuwmMIPq2oM3G3Fjct8dqQ2jt03nepVKrFBMyjopdrdQFarCW8cVi2oqEkw78DqBymJ9QzMN4+MHpT73MOjSpiDvUS9zc=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB6816.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(4326008)(5660300002)(33656002)(36756003)(6916009)(38100700002)(38350700002)(6666004)(2906002)(66476007)(66556008)(316002)(6512007)(2616005)(66946007)(8676002)(44832011)(508600001)(53546011)(6506007)(83380400001)(86362001)(54906003)(8936002)(6486002)(26005)(52116002)(956004)(186003)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6576
Original-Authentication-Results: xen.org; dkim=none (message not signed)
 header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT004.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	f33acf6e-59d4-4bc9-9b93-08d98e52bb24
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	A+JUhCurm8eOJiDr3aS3MHtK0vC07XRz5c/zFRAgnLV/yBIqGpxz2yzkI/hHf8DuXKthSu7zPSKZfoNhzyIslNKAfhOzi80gfCShrwFLaYPuA8ZR9s3yKd3mHAoSz0els0qe/wtAdgqd0AqYOsfz+5DLPULfm5bw/4X/EedeWx0hGH7i3ABOcFSzxsRuYJlXVLjALVHhvzCsOYyzPVhVIASWfTcqP+RIlFUFZaKVafNxYovKbV18wRbDPBPdSM5uoZT8Vd/Nbt5A+jRkdeKGMk8TkEswr0EZZ1xM5yC3y5zqh7B8jkrim1YpSgKMnJ0mEV25RgsWghGLa89nYIRWmapu+xLreOgjCTfqIFeaBWF3fVkl4zkWtXJh/HrIRgBkD+1NWC2JIftKrMx1vfwhV79kXEEezH8cNORuSM89rlBt5N0Px1U5eMJbL3VuLFKbz/kkBB9+tygHh0waMIANF7NOEDlhoIhJFd6Dto8BMAmEZhqMnNZaxnmpvGIOIxoOmZLo/jqgUKcbCAIYBDMxqZMvwaqr0YNjkCJ7NjSzLTnV38p4YRzV62dORzNW1S5mQfPqamJrvh8MRLXTC3hhxS3UgTRxLvQuV5x4XnsS9VfFdcRwt3i4XXL2W/Dpl9o4MpxHFUs0Cd6qN4yRT+KQVyAaPRJi3NcWW6gR90aRWI0G+qo0qjzWzCSRUzvqH4iP48Ma4UogqMp6bGrIJSVgJg==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(8936002)(36756003)(5660300002)(186003)(8676002)(36860700001)(6512007)(83380400001)(44832011)(53546011)(6506007)(356005)(33656002)(508600001)(107886003)(6862004)(6666004)(336012)(81166007)(82310400003)(2616005)(86362001)(956004)(4326008)(54906003)(2906002)(70586007)(70206006)(316002)(47076005)(6486002)(26005);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2021 14:07:16.4369
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 9cd52801-dda9-4c10-275d-08d98e52c349
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT004.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB4641



> On 13 Oct 2021, at 14:27, Julien Grall <julien@xen.org> wrote:
>=20
> Hi Luca,
>=20
> On 13/10/2021 13:19, Luca Fancellu wrote:
>> Legacy compatible strings for dom0 modules are not
>> supported when booting using UEFI, the documentation
>> doesn't mention that.
>=20
> Can you add a summary in the commit message why we consider the legacy bi=
nding is not supported?

Yes what about:

Since the introduction of UEFI boot for Xen, the legacy
compatible strings were not supported and the stub code
was checking only the presence of =E2=80=9Cmultiboot,module=E2=80=9D to
require the Xen UEFI configuration file or not.
The documentation was not updated to specify that behavior.

Add a phrase to docs/misc/arm/device-tree/booting.txt
to clarify it.

>=20
>> Add a phrase to docs/misc/arm/device-tree/booting.txt
>> to clarify it.
>> Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>
>> ---
>>  docs/misc/arm/device-tree/booting.txt | 2 ++
>>  1 file changed, 2 insertions(+)
>> diff --git a/docs/misc/arm/device-tree/booting.txt b/docs/misc/arm/devic=
e-tree/booting.txt
>> index c6a775f4e8..017c0f13eb 100644
>> --- a/docs/misc/arm/device-tree/booting.txt
>> +++ b/docs/misc/arm/device-tree/booting.txt
>> @@ -51,6 +51,8 @@ Each node contains the following properties:
>>  	Xen 4.4 supported a different set of legacy compatible strings
>>  	which remain supported such that systems supporting both 4.4
>>  	and later can use a single DTB.
>> +	However when booting Xen using UEFI and Device Tree, the legacy
>=20
> NIT: I would drop "and Device Tree" because this feels a bit redundant as=
 this compatible can only be used in the Device-Tree.

I will drop it

>=20
>> +	compatible strings are not supported.
>>    	- "xen,multiboot-module" equivalent to "multiboot,module"
>>  	- "xen,linux-zimage"     equivalent to "multiboot,kernel"
>=20
> Cheers,
>=20
> --=20
> Julien Grall



From xen-devel-bounces@lists.xenproject.org Wed Oct 13 14:09:23 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 14:09:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.208536.364687 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maewd-0004Ir-91; Wed, 13 Oct 2021 14:09:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 208536.364687; Wed, 13 Oct 2021 14:09:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maewd-0004Ik-5r; Wed, 13 Oct 2021 14:09:23 +0000
Received: by outflank-mailman (input) for mailman id 208536;
 Wed, 13 Oct 2021 14:09:22 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1maewc-0004Ic-Na
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 14:09:22 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1maewc-0006O3-Mg
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 14:09:22 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1maewc-0005HE-LY
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 14:09:22 +0000
Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89)
 (envelope-from <iwj@xenproject.org>)
 id 1maewW-0007tT-7m; Wed, 13 Oct 2021 15:09:16 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date
	:Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From;
	bh=HAYUOhxuXurrAdWRAMOoG0IbWwuug4xwZ+N0E1eVPW8=; b=HIlV9XcTn+81vkv8vgEqxUy6tI
	HAkGoj8lvIVkvzOFQpdz20K8iWuLV115qdUW8OkO4A5Ob07qoG9y9mtCWwwQwfdmvEOBS/vqDjPge
	PJN5KIaBuZfm3jjEkYiRHrFHCHUeZN+5jZuZJJCoiTGTyOGePmREnrnI2MzICi9efTWc=;
From: Ian Jackson <iwj@xenproject.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <24934.59531.966204.631618@mariner.uk.xensource.com>
Date: Wed, 13 Oct 2021 15:09:15 +0100
To: Julien Grall <julien@xen.org>
Cc: Ian Jackson <iwj@xenproject.org>,
    Michal Orzel <michal.orzel@arm.com>,
    xen-devel@lists.xenproject.org,
    Andrew Cooper  <andrew.cooper3@citrix.com>,
    George Dunlap <george.dunlap@citrix.com>,
    Jan Beulich <jbeulich@suse.com>,
    Stefano Stabellini  <sstabellini@kernel.org>,
    Wei Liu <wl@xen.org>,
    Nick Rosbrook <rosbrookn@ainfosec.com>,
    Anthony PERARD <anthony.perard@citrix.com>,
    Juergen Gross <jgross@suse.com>,
    Christian Lindig <christian.lindig@citrix.com>,
    David Scott  <dave@recoil.org>,
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
    bertrand.marquis@arm.com
Subject: Re: [PATCH v7] xen: Expose the PMU to the guests
In-Reply-To: <bcdf096c-aeaa-5d5f-fffc-95719c7b4038@xen.org>
References: <20211013123352.6625-1-michal.orzel@arm.com>
	<24934.54743.853232.853726@mariner.uk.xensource.com>
	<bcdf096c-aeaa-5d5f-fffc-95719c7b4038@xen.org>
X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu)

Julien Grall writes ("Re: [PATCH v7] xen: Expose the PMU to the guests"):
> I am in the signed-off-by list. Even if the patch has changed compare 
> the original, I feel it is odd to ack my own patch.
> 
>  From my understanding, my signed-off-by is sufficient serve as an 
> approval for the maintainer part. We also have a review form a person of 
> a suitable stature in the community (Bertrand). So I think in term of 
> approval we are good.
> 
> Additionally, from a discussion yesterday on IRC, Stefano was happy with 
> this patch (I was the one requesting the resend for SUPPORT.MD). So I 
> think we can commit it now.
> 
> Let me know if you prefer to wait for a formal Ack from Stefano.

Ah.  I see, no that's fine.  I am committing it now.

Thanks,
Ian.


From xen-devel-bounces@lists.xenproject.org Wed Oct 13 14:11:18 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 14:11:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.208544.364706 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maeyT-0005jG-NO; Wed, 13 Oct 2021 14:11:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 208544.364706; Wed, 13 Oct 2021 14:11:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maeyT-0005j9-KW; Wed, 13 Oct 2021 14:11:17 +0000
Received: by outflank-mailman (input) for mailman id 208544;
 Wed, 13 Oct 2021 14:11:16 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1maeyS-0005iv-PG
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 14:11:16 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1maeyS-0006SJ-OU
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 14:11:16 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1maeyS-0005bY-Nd
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 14:11:16 +0000
Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89)
 (envelope-from <iwj@xenproject.org>)
 id 1maeyM-0007uv-4r; Wed, 13 Oct 2021 15:11:10 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date
	:Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From;
	bh=Z+FYk51/rySBF1l/fElIWpeSrHVagHHAaVbNft1wPv8=; b=jJ1Z2f3oFN82dloq9csDjcScUW
	y24+IqCFIJ2IMMwzg9qwud3Z6PZwH9cD9dQjIc9mWHlkXJtDx/fqxeq1ZUt4YX6H+6B0lZ9mbLeOn
	p3op7mWNmWR2LvV1IZG8mv1tT1525hsJ0rnKIEaTyLisZLTDf0s8wn0cBnmyzilQTLvQ=;
From: Ian Jackson <iwj@xenproject.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <24934.59645.908389.768333@mariner.uk.xensource.com>
Date: Wed, 13 Oct 2021 15:11:09 +0100
To: Juergen Gross <jgross@suse.com>,
    Anthony PERARD <anthony.perard@citrix.com>
Cc: Ian Jackson <iwj@xenproject.org>,
    <xen-devel@lists.xenproject.org>,
    Wei Liu <wl@xen.org>
Subject: Re: [PATCH] libxl: CODING_STYLE: Explicitly deprecate #ifdef [and 1 more messages]
In-Reply-To: <YWWjnAhkMGbct5Ii@perard>,
	<2d9bcfc7-e7a4-1612-92e5-f584c45894fd@suse.com>
References: <20211012145226.6065-1-iwj@xenproject.org>
	<2d9bcfc7-e7a4-1612-92e5-f584c45894fd@suse.com>
	<YWWjnAhkMGbct5Ii@perard>
X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu)

Anthony PERARD writes ("Re: [PATCH] libxl: CODING_STYLE: Explicitly deprecate #ifdef"):
> On Tue, Oct 12, 2021 at 03:52:26PM +0100, Ian Jackson wrote:
> > +Architecture-specific code should be isolated in libxl_<arch>.c,
> > +with a function call interface, whereever possible.
> 
> s/whereever/wherever/ ?

Fixed, thanks.

> Acked-by: Anthony PERARD <anthony.perard@citrix.com>

Juergen Gross writes ("Re: [PATCH] libxl: CODING_STYLE: Explicitly deprecate #ifdef"):
> Reviewed-by: Juergen Gross <jgross@suse.com>

And committed.

Thanks,
Ian.


From xen-devel-bounces@lists.xenproject.org Wed Oct 13 14:25:12 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 14:25:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.208551.364718 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mafBo-0007I9-Sw; Wed, 13 Oct 2021 14:25:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 208551.364718; Wed, 13 Oct 2021 14:25:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mafBo-0007I2-OY; Wed, 13 Oct 2021 14:25:04 +0000
Received: by outflank-mailman (input) for mailman id 208551;
 Wed, 13 Oct 2021 14:25:04 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=iVjq=PB=citrix.com=anthony.perard@srs-us1.protection.inumbo.net>)
 id 1mafBo-0007Hw-4F
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 14:25:04 +0000
Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 5a3a0cc8-2c31-11ec-8179-12813bfff9fa;
 Wed, 13 Oct 2021 14:25:02 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5a3a0cc8-2c31-11ec-8179-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1634135102;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=5VMgU++AcV1NSou5mqA5ZYMDczNw6Z6uZespVrkwy4I=;
  b=ZnMXQHGKWFNUfq4+pEbpuhE1Cn9RMkfzIPDEdLLleM+IQ4UFyPB1O6jF
   eUJ0P82HLZ/nGlrubBpbaNNJFs1FrC/WBR3GxeM1HpqvLuXFRYu3IoTUq
   T7IDpxTTXOgBriZpq8yP4ZjhXJtPkMm8DxhvqJE+PbGfecJb0Nv1HSwWG
   4=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: 8MSeASiiazzLHz1KZn5ph61EQpSSrFniqXEDOd1Wh87snfxyfXxXvdvfIRhfOxybEOtMpVygKV
 yILu8luaGBeVaG9WEGHRPuMewrGMIR6nii7yMHomN32IiUzfMSR/ZmyEBNfi4cPebw4+BSviZV
 Gyi9np3qG0zaaUwb+eYnyXOcQRVlXMkTrAQrK2yloKDiEJKWCOwFPnHep8ef6obvjhJcredkyK
 6WBnxvmlqe2IWtUO4sCYJEN6+1Bw0DCGYHxYiIudW5UqrErgkKI5PETJ/rOhhJJYK6bI0BJBol
 67t2sBlp+5K1S9VJR0M6oc//
X-SBRS: 5.1
X-MesageID: 54665630
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:Tw/P7qPZ+uSDGj/vrR2bkcFynXyQoLVcMsEvi/4bfWQNrUoigWRUn
 TYeWmCAPv7bN2GnLd52Oom3oxsCvZGEztZkGQto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdpJYz/uUGuCJQUNUjMlkfZKhTr6ZUsxNbVU8En540Us4w7VRbrNA2rBVPSvc4
 bsenOWHULOV82Yc3rU8sv/rRLtH5ZweiRtA1rAMTakjUGz2zhH5OKk3N6CpR0YUd6EPdgKMq
 0Qv+5nilo/R109F5tpICd8XeGVSKlLZFVDmZna7x8FOK/WNz8A/+v9TCRYSVatYozWCvv9a4
 Y1Uj4KxdwAxG6bo2+4kWAYNRkmSPYUekFPGCX22sMjVxEzaaXr8hf5pCSnaP6VBpLwxWzsXs
 6VFdnZdNXhvhMrvqF6/YuBqmsQkKtitJI4Fs2ts5TrYEewnUdbIRKCiCdpwgWtu2J0QRq62i
 8wxTjtSUhnAQUB1JXQRDYknm7/2iienSmgNwL6SjfVuuDWCpOBr65DsL9j9atGMXd9SnEuTu
 iTB5WuRKhMHMN2SzxKV/3TqgfXA9QvgQ54bHrC88v9sgXWQy3YVBRlQUkG0ydGph0j7V99BJ
 kg8/is1sbN05EGtVsP6XRCzvDiDpBF0c8VUO/037keK0KW8ywyeDGIVQyVBbNEjvckeSjkj1
 1vPlNTsbRRRt7mSRWOY562jhzq4MigILkcPfSYBCwAC5rHLo4Y1lBvDCMliFK2dicf8EjX9h
 TuNqUAWi7ofgMER3o2n7FvHhHSqvZGPQQkrji3VVG+46gJyZKa+epelr1Pc6J5oIJ6CS1idv
 FANg8WE8P0VFpaJiTCMR+MWWrqu4p6tOTndmkJmHoNn+S6k/XWiZqhP7Do4L0BsWu4PfjnvZ
 03fsB1Q/7dcOXKrael8ZIfZNigx5fG+T5K/DKmSN4cQJMgqHOOawM1wTU6b/k/GuRA1q78+B
 5CDVM2ITnwjArsymVJaWNwh+bMswyk/w0baSpb60wmr3NKiWZKFdVsWGADRNr5hvctotC2Qq
 owFb5LblH2zRcWnOnGPmbP/O2zmOpTS6XrekMdQavKYajRvHGUsGpc9KptwJtQ7wcy5egrOl
 0xRu3O0KnKj2xUryi3QMxiPjY8Du74k8hrX2gR2bD6VN4ALO9rH0UvmX8JfkUMb3OJi1+Voa
 PIOZt+NBP9CIhyepW9BNceh9tQ4KE/37e5rA8ZDSGNgF3KHb1aYkuIIgyO1rHVeZsZJnZpWT
 0KcOvPzHsNYGlUK4Df+Y/Oz1VKh1UXxa8opN3Yk1uJ7IR22mKAzcnSZpqZuf6kkdEWSrhPHh
 l3+KUpJ+oHwT3odrYChaVas9NzyTYOT3yNyQgHm0FpBHXCCpDT8mtUcDL/gkPK0fDqcxZhOr
 N59l5nUWMDrVn4T22alO7o0n684+fX1oLpWklZtEHnRNgz5AbJ8OHiWm8JIs/QVlLNevAK3X
 GOJ+8VbZurVaJ+0TgZJKVp3dPmH2NEVhiLWsaY/LnLl6XIl57GAS0hTYUWB0XQPMLtvPYo56
 u49o8pKuRengx8nP4/e3CBZ/miBNFIaVKAjus1ICYPnkFNzmFpDfYbdGmn955TWM4dANUwjI
 zm1gqvehusDmhqeIiRrTXWUhLhTn5UDvhxO3WQuHVXRl4qXnOIz0T1Q7S8zElZfwCJY3r8hI
 WNsLUB0e/mDpm86mMhZUmmwMAhdHxnFqFfpwl4EmWCFHUmlUmvBcD80NeqXpR1L9mtden5Q/
 a2CyXajWjHvJZmj0iw3UE9jivriUd0uqVGSxJH5R5yIT8sgfD7ooq6yfm5Z+RLoDPQ4iFDDu
 eQ3rv17brf2NHJIrqA2Y2VAOW/8lPxQyLR+fMxc
IronPort-HdrOrdr: A9a23:dTcFn6ipxPhaHQ4t/K1pNh7cHHBQXtgji2hC6mlwRA09TySZ//
 rOoB0+726StN9xYgBFpTnuAsW9qB/nmqKdpLNhW4tKPzOW3VdATrsSjrcKqgeIc0aVm9K1l5
 0QEZSWYOeAdGSS5vyb3ODXKbgd/OU=
X-IronPort-AV: E=Sophos;i="5.85,371,1624334400"; 
   d="scan'208";a="54665630"
Date: Wed, 13 Oct 2021 15:24:26 +0100
From: Anthony PERARD <anthony.perard@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Bob Eshleman <bobbyeshleman@gmail.com>, Andrew Cooper
	<andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>, "Ian
 Jackson" <iwj@xenproject.org>, Julien Grall <julien@xen.org>, "Stefano
 Stabellini" <sstabellini@kernel.org>, Wei Liu <wl@xen.org>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Alistair Francis <alistair.francis@wdc.com>,
	Connor Davis <connojdavis@gmail.com>, Roger Pau =?iso-8859-1?Q?Monn=E9?=
	<roger.pau@citrix.com>, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>, "Ross
 Lagerwall" <ross.lagerwall@citrix.com>, Daniel De Graaf
	<dgdegra@tycho.nsa.gov>, "Daniel P. Smith" <dpsmith@apertussolutions.com>,
	<xen-devel@lists.xenproject.org>
Subject: Re: [XEN PATCH v7 26/51] build: build everything from the root dir,
 use obj=$subdir
Message-ID: <YWbsGlcDZSSXsJlx@perard>
References: <20210824105038.1257926-1-anthony.perard@citrix.com>
 <20210824105038.1257926-27-anthony.perard@citrix.com>
 <eca3f533-9841-e4a8-dfde-840451ed8aef@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <eca3f533-9841-e4a8-dfde-840451ed8aef@suse.com>

On Mon, Oct 11, 2021 at 04:02:22PM +0200, Jan Beulich wrote:
> On 24.08.2021 12:50, Anthony PERARD wrote:
> > A subdirectory is now built by setting "$(obj)" instead of changing
> > directory. "$(obj)" should always be set when using "Rules.mk" and
> > thus a shortcut "$(build)" is introduced and should be used.
> > 
> > A new variable "$(need-builtin)" is introduce. It is to be used
> > whenever a "built_in.o" is wanted from a subdirectory. "built_in.o"
> > isn't the main target anymore, and thus only needs to depends on the
> > objects that should be part of "built_in.o".
> 
> How "good" are our chances that we hit a need-builtin variable from
> the environment? Its uses are simply using "ifdef".

I think it would be low as Linux is using the same one. If it were
define, I think that would mean building a few more object than
expected which would not be used.

> > --- a/xen/Rules.mk
> > +++ b/xen/Rules.mk
> > @@ -3,19 +3,29 @@
> >  # Makefile and are consumed by Rules.mk
> >  #
> >  
> > -obj := .
> >  src := $(obj)
> >  
> > +PHONY := __build
> > +__build:
> > +
> >  -include $(BASEDIR)/include/config/auto.conf
> >  
> >  include $(XEN_ROOT)/Config.mk
> >  include $(BASEDIR)/scripts/Kbuild.include
> >  
> > +ifndef obj
> > +$(warning kbuild: Rules.mk is included improperly)
> > +endif
> 
> Is there a particular reason for this to come only here, rather than
> before the include-s (e.g. right at where the assignment to the
> variable lived)?

Probably not, Linux's Kbuild does check it quite late but I don't know the
reason. I can move the check earlier.

> > @@ -51,27 +61,54 @@ cmd_objcopy = $(OBJCOPY) $(OBJCOPYFLAGS) $< $@
> >  quiet_cmd_binfile = BINFILE $@
> >  cmd_binfile = $(SHELL) $(BASEDIR)/tools/binfile $(BINFILE_FLAGS) $@ $(2)
> >  
> > -define gendep
> > -    ifneq ($(1),$(subst /,:,$(1)))
> > -        DEPS += $(dir $(1)).$(notdir $(1)).d
> > -    endif
> > -endef
> > -$(foreach o,$(filter-out %/,$(obj-y) $(obj-bin-y) $(extra-y)),$(eval $(call gendep,$(o))))
> > +# Figure out what we need to build from the various variables
> > +# ===========================================================================
> > +
> > +# Libraries are always collected in one lib file.
> > +# Filter out objects already built-in
> > +lib-y := $(filter-out $(obj-y), $(sort $(lib-y)))
> > +
> > +# Subdirectories we need to descend into
> > +subdir-y := $(subdir-y) $(patsubst %/,%,$(filter %/, $(obj-y)))
> 
> Deliberately or accidentally not += ?

Seems to be accidentally. Kbuild does a $(sort ) here, I should probably
do the same, just to get rid of duplicates if they are any.

> > @@ -156,21 +192,13 @@ endif
> >  PHONY += FORCE
> >  FORCE:
> >  
> > -%/built_in.o %/lib.a: FORCE
> > -	$(MAKE) -f $(BASEDIR)/Rules.mk -C $* built_in.o
> > -
> > -%/built_in_bin.o: FORCE
> > -	$(MAKE) -f $(BASEDIR)/Rules.mk -C $* built_in_bin.o
> > -
> > -SRCPATH := $(patsubst $(BASEDIR)/%,%,$(CURDIR))
> > -
> >  quiet_cmd_cc_o_c = CC      $@
> >  ifeq ($(CONFIG_ENFORCE_UNIQUE_SYMBOLS),y)
> >      cmd_cc_o_c = $(CC) $(c_flags) -c $< -o $(dot-target).tmp -MQ $@
> >      ifeq ($(CONFIG_CC_IS_CLANG),y)
> > -        cmd_objcopy_fix_sym = $(OBJCOPY) --redefine-sym $<=$(SRCPATH)/$< $(dot-target).tmp $@
> > +        cmd_objcopy_fix_sym = $(OBJCOPY) --redefine-sym $(<F)=$< $(dot-target).tmp $@
> 
> Are you sure about the $< => $(<F) transformation here? Previoiusly it
> was present only ...

I have to check again. Maybe $< didn't work and it's more obvious with
this patch. Or maybe that depends on the version of clang.

> >      else
> > -        cmd_objcopy_fix_sym = $(OBJCOPY) --redefine-sym $(<F)=$(SRCPATH)/$< $(dot-target).tmp $@
> > +        cmd_objcopy_fix_sym = $(OBJCOPY) --redefine-sym $(<F)=$< $(dot-target).tmp $@
> 
> ... here.
> 
> > @@ -251,6 +292,9 @@ existing-targets := $(wildcard $(sort $(targets)))
> >  
> >  -include $(foreach f,$(existing-targets),$(dir $(f)).$(notdir $(f)).cmd)
> >  
> > +DEPS:= $(foreach f,$(existing-targets),$(dir $(f)).$(notdir $(f)).d)
> 
> Nit: Preferably blanks on both sides of := or none at all, please.

Will fix.

> > --- a/xen/arch/x86/Makefile
> > +++ b/xen/arch/x86/Makefile
> > @@ -81,6 +81,9 @@ endif
> >  extra-y += asm-macros.i
> >  extra-y += xen.lds
> >  
> > +# Allows usercopy.c to includes itself
> 
> Nit: include

Indeed.

> > +$(obj)/usercopy.o: CFLAGS-y += -I.
> 
> This is ugly, but presumably unavoidable. Preferably I would see us
> the more specific -iquote though, assuming clang also supports it.

clang does have -iquote, so I guess it could be used. That would be the
first use of -iquote so I hope nothing would break with it.

> > --- a/xen/arch/x86/boot/Makefile
> > +++ b/xen/arch/x86/boot/Makefile
> > @@ -1,8 +1,8 @@
> >  obj-bin-y += head.o
> >  
> > -DEFS_H_DEPS = $(src)/defs.h $(BASEDIR)/include/xen/stdbool.h
> > +DEFS_H_DEPS = $(BASEDIR)/$(src)/defs.h $(BASEDIR)/include/xen/stdbool.h
> >  
> > -CMDLINE_DEPS = $(DEFS_H_DEPS) $(src)/video.h
> > +CMDLINE_DEPS = $(DEFS_H_DEPS) $(BASEDIR)/$(src)/video.h
> 
> Hmm, new uses of $(BASEDIR) (a few more further down). Why not
> $(srctree)?

I think I haven't introduce $(abs_srctree) yet, and this needs to be an
absolute path (the path is also used by a make which run from a
different current directory).

Thanks,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Wed Oct 13 14:27:08 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 14:27:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.208559.364729 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mafDo-0007u4-83; Wed, 13 Oct 2021 14:27:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 208559.364729; Wed, 13 Oct 2021 14:27:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mafDo-0007tx-4y; Wed, 13 Oct 2021 14:27:08 +0000
Received: by outflank-mailman (input) for mailman id 208559;
 Wed, 13 Oct 2021 14:27:06 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=iVjq=PB=citrix.com=anthony.perard@srs-us1.protection.inumbo.net>)
 id 1mafDm-0007tr-QX
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 14:27:06 +0000
Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id a394ce12-2c31-11ec-8179-12813bfff9fa;
 Wed, 13 Oct 2021 14:27:05 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a394ce12-2c31-11ec-8179-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1634135225;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=VWfF5b+yHwyyQ5m1UWkgFlWZUR0Pmn/m9glp0ubmhDo=;
  b=GG7Tmq5GQbvs+MrH4Bjjx3R6UwmVnR+lCJ4Lzti49r9hpmEKwGQZCo+1
   lARoCQvGDtnZom8g7rpcMSURmUjji3aKpZJ4HlICZ1ldncVb6jKTgepg2
   95sydI9eTwDlvfkJUhtUcN+nk8iWbkxbfOE1jDdkEqWkc4qkxWEhxMt/9
   E=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: bpbR6ArYKxIEu9NiiH5EgTt5zyjKj3KoY+aRcPFTCM4rJ4TECRl/HBEble6LsFd1JNaBma5xEV
 XFbvlVT5TLSQ8Jm6oIpaa53tkYdpTJVH9ZOlMyOHDBpweWYgD4RslhdZAEZfPpb9yhsxdKKAfa
 Oi5QjwjPk5zT8FipzMGNGsjbnzZr2PRc9gVhFUhr+MTWZh0jINsXEuGQ4Q4oAIIGFPH+v7HENn
 ZrLBpQokLAPym58ud8neJtoglZwF5x8WM/rXNyxRp2xi5+fuqn+aXVQItROIxvE74G+OyzgMD6
 UEJ4rfqvFgyPhDINQNGGk8UF
X-SBRS: 5.1
X-MesageID: 55098980
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:hdJMyaLtgu7SZyo9FE+RXJIlxSXFcZb7ZxGr2PjKsXjdYENSgjMBn
 DRKWWnVOaqMY2P9LYxxa4S+phxVuZfTnYI1GQRlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s
 q3yv/GZdJhcokcxIn5BC5C5xZVG/fjgqoHUVaiUZ0ideSc+EH140Eo6wLZi6mJVqYPR7z2l6
 IuaT/L3YDdJ6xYsWo7Dw/vewP/HlK2aVAIw5jTSV9gS1LPtvyB94KYkDbOwNxPFrrx8RYZWc
 QphIIaRpQs19z91Yj+sfy2SnkciGtY+NiDW4pZatjTLbrGvaUXe345iXMfwZ3u7hB25hfRvk
 NBgsqWqUBp0boz3wscCEBNhRnQW0a1uoNcrIFC6uM2XiUbHb2Ht07NlC0Re0Y8wo7gtRzsUr
 LpBdW5LPkvra+GemdpXTsFlgNgjK8/6epsSoHh6wRnSDOo8QICFSKLPjTNd9Gpt3pEeTKaGD
 yYfQRdkXA3laB1lAwkKKaglh9akmljGdDIN/Tp5ooJoujOOnWSdyoPFK8HJc9aHQcFUmEewp
 W/c+Wn9RBYAO7S31j6t4n+qwOjVkkvTSI8UUbG16PNuqFmS3XAITg0bU0Ohpvu0gVL4XMhQQ
 2QW8Cczqak59GSwU8LwGRa/pRasvwEec8pdFfUg7wOAwbaS5ByWbkAGUzpAZdoOpMIwAzsw2
 Te0c8jBXGI19ufPEDTEq+nS/Wja1TUpwXEqVTUgU1MAzt7aupgu00LudYxAD+2/t4igcd3v+
 AyioC87jrQVqMcE0aSn4FzK6w6RSoj1oh0dvVqPADr0hu9tTMv8PdbwsAmEhRpVBN/BFgHpg
 ZQSpySJAAni57m2nyuRXP5FIrit4/uUWNE3qQ8yR8d/n9hBFnjKQGyx3N2cDBs3WirnUWWwC
 KM2he+3zMQMVJdNRfUmC79d8+xwkcDd+S3ND5g4lOZmbJlrbxOg9ypzf0OW1G2FuBFyyv1nZ
 8vBKZzwVipy5UFbINyeHLh1PVgDnHFW+I8ubcqjk0TPPUS2NRZ5tovpwHPRN7tkvctoUS3e8
 spFNtvi9vmseLaWX8UjyqZKdQpiBSFiXfje8pULHsbeclsOMDxwUJf5nOJ+E7GJaowIz48kC
 FnmARQGoLc+7FWaQTi3hodLMeu1A8kk9y5nZETB/z+AghAeXGpm149HH7NfQFXt3LULISdcQ
 6ZXdsOeLO5ITzibqT0RYYOk9N5pdQixhBLINC2gOWBtc5llTg3P29nlYgqwq3VeUnvp7ZMz8
 ++6ywfWYZsfXAA+XszYX+2ikgGqtn8HleMsA0aReotPeF/h+ZRBIjDqiqNlONkFLBjOn2PI1
 wufDRoCi/PKpos5rIvAiaye9t/7GOpiBEtKWWLc6O/uZyXd+2Oix65GUfqJIm+BBD+lpv36a
 LwMnf/mMfABkFJbiKZGEu5mnfAk+t/ih75G1QA4Tn/FWEumV+F7KX6c0MgR6qAUnu1FuRG7U
 16k88VBPenbI9vsFVMcKVZ3bumH0v1IyDDe4e5sfRf/7S5zurGGTV9TL1+HjykEdOl5N4Ysw
 OEAvs8K6lPg1kp2Y4je1i0EpX6RKnEgUrk8ssBICYDmvQMn11VebMGOESTx+pyON41BP0RCz
 uV4X0Yea2CwHnb/Tkc=
IronPort-HdrOrdr: A9a23:okhYg6DSZ1a2yqvlHemi55DYdb4zR+YMi2TDtnocdfUxSKelfq
 +V88jzuSWbtN9yYhEdcKG7WZVoKEm0nfQZ3WB7B8bAYOCJghrMEKhSqafk3j38C2nf24dmpM
 NdmnFFeb/NMWQ=
X-IronPort-AV: E=Sophos;i="5.85,371,1624334400"; 
   d="scan'208";a="55098980"
Date: Wed, 13 Oct 2021 15:26:45 +0100
From: Anthony PERARD <anthony.perard@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, George Dunlap
	<george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>, Julien Grall
	<julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>, Wei Liu
	<wl@xen.org>, <xen-devel@lists.xenproject.org>
Subject: Re: [XEN PATCH v7 22/51] build: clean common temporary files from
 root makefile
Message-ID: <YWbspfv86oEVFMap@perard>
References: <20210824105038.1257926-1-anthony.perard@citrix.com>
 <20210824105038.1257926-23-anthony.perard@citrix.com>
 <dd760c79-e761-3547-726a-4d7ee092d10f@suse.com>
 <YWa2neA0zQSvkqn2@perard>
 <16d19699-8ebb-9352-dff5-83147aee9ffc@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <16d19699-8ebb-9352-dff5-83147aee9ffc@suse.com>

On Wed, Oct 13, 2021 at 02:32:55PM +0200, Jan Beulich wrote:
> On 13.10.2021 12:36, Anthony PERARD wrote:
> > On Mon, Oct 11, 2021 at 01:41:16PM +0200, Jan Beulich wrote:
> >> On 24.08.2021 12:50, Anthony PERARD wrote:
> >>> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
> >>
> >> Trying to synthesize a description:
> >>
> >>> --- a/xen/Makefile
> >>> +++ b/xen/Makefile
> >>> @@ -382,6 +382,7 @@ _clean:
> >>>  	$(MAKE) $(clean) test
> >>>  	$(MAKE) $(kconfig) clean
> >>>  	find . \( -name "*.o" -o -name ".*.d" -o -name ".*.d2" \
> >>
> >> This was effectively redundant with ...
> >>
> >>> +		-o -name ".*.o.tmp" -o -name "*~" -o -name "core" \
> >>>  		-o -name "*.gcno" -o -name ".*.cmd" -o -name "lib.a" \) -exec rm -f {} \;
> >>>  	rm -f include/asm $(TARGET) $(TARGET).gz $(TARGET).efi $(TARGET).efi.map $(TARGET)-syms $(TARGET)-syms.map *~ core
> >>>  	rm -f asm-offsets.s arch/*/include/asm/asm-offsets.h
> >>> diff --git a/xen/scripts/Makefile.clean b/xen/scripts/Makefile.clean
> >>> index 027c200c0efc..b6df9e861e6e 100644
> >>> --- a/xen/scripts/Makefile.clean
> >>> +++ b/xen/scripts/Makefile.clean
> >>> @@ -14,10 +14,8 @@ include Makefile
> >>>  subdir-all := $(subdir-y) $(subdir-n) $(subdir-) \
> >>>                $(patsubst %/,%, $(filter %/, $(obj-y) $(obj-n) $(obj-)))
> >>>  
> >>> -DEPS_RM = $(DEPS) $(DEPS_INCLUDE)
> >>
> >> ... this and its use below.
> >>
> >>>  .PHONY: clean
> >>>  clean:: $(subdir-all)
> >>> -	rm -f *.o .*.o.tmp *~ core $(DEPS_RM)
> >>
> >> With the command gone, I think the :: should also be converted (back) to
> >> just : then. Then
> > 
> > "clean" has been a double-column rule for a long time. If we convert
> > this rule to a single-column we need to convert all "clean" target to
> > use single-column which would make this patch more complicated. So I
> > don't think we should make this change.
> 
> Hmm, indeed make would complain in that case (I didn't mean to suggest
> to convert all clean-s to single-colon rules, but I was instead under
> the wrong impression that spelling out merely dependencies would be
> okay with single-colon rule). But then make's doc also says "Each
> double-colon rule should specify a recipe; if it does not, an implicit
> rule will be used if one applies." So perhaps, to avoid depending on
> the latter, an empty recipe should be added here (by adding a
> semicolon)?

That sounds fine.

> >> Reviewed-by: Jan Beulich <jbeulich@suse.com>
> >>
> >> Assuming the patch is independent of the earlier still uncommitted ones
> >> (please confirm), I'd be happy to make the adjustment while committing
> >> - as long as you agree, of course.
> > 
> > The patch is independent of earlier one, although the context is changed
> > in one patch so wouldn't apply cleaning without git helps.
> > (context is changed in "xen: move include/asm-* to arch/*/include/asm")
> 
> That would be easy enough to adjust, I guess. But first we need to settle
> on the above.

Thanks,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Wed Oct 13 14:29:24 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 14:29:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.208566.364739 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mafFz-00007J-Kk; Wed, 13 Oct 2021 14:29:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 208566.364739; Wed, 13 Oct 2021 14:29:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mafFz-00007A-Hr; Wed, 13 Oct 2021 14:29:23 +0000
Received: by outflank-mailman (input) for mailman id 208566;
 Wed, 13 Oct 2021 14:29:22 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=EFKL=PB=citrix.com=roger.pau@srs-us1.protection.inumbo.net>)
 id 1mafFy-000071-FJ
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 14:29:22 +0000
Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id f4203c0e-2c31-11ec-8179-12813bfff9fa;
 Wed, 13 Oct 2021 14:29:21 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f4203c0e-2c31-11ec-8179-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1634135360;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=APPtn0PA9geCxnfhp/tb14JXWyxnXBs6x7cKbOxRASY=;
  b=dRY7b++IOwT1s45twa/b7G5uIq+f3fSEU7fUmxxQ1kG5VY5jtea+fFSg
   lcRCy65fsRu3XR1PWm8QSaVj5BotrHy/dnFUjwhw0lnp3D30ETVxx9ZIr
   arW6R0CqQhEcTuzlzCKNuaSeanl3jrK1rNwdBCHufHkjDAUQs96+8WGgZ
   4=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: hjuuT9gSa05fYbgWkD3sZ4Use2JKatNkzPCs5Cs6TZZtqyT3hSi+ETg/5S+Xjkx1oEGDIey/WU
 Un/SzQV88MrWFYUEC35HnEMGnEql4h4W+ej3/ytbQgXU7NA36EFtYV4Masa2iAToJ1T4Fs+s7N
 ayXEZlcMhoq29MHYbLQlFJtx2pbzHijghPQu9O9i5JnR/w8gClsZZ+PPDlDUrR900zaZyiEDEW
 P8ERgmVlVWSz9uqWb6XoiJ/5+lcqeV18sotGjdlvgZVD06/n9DF16OBMPHAi0OV7Fuum06TBuU
 rH1LeGVBieKIlEh47EkfVylA
X-SBRS: 5.1
X-MesageID: 56976528
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:LCGMLqin/kHsWBewSXj0WE5kX161QBYKZh0ujC45NGQN5FlHY01je
 htvC2/XbKuKZTHzf4hxbNvloRtQvZPQyIIyG1ZrrH8xH38b9cadCdqndUqhZCn6wu8v7a5EA
 2fyTvGacajYm1eF/k/F3oAMKRCQ7InQLlbGILes1htZGEk0FU/NtTo5w7Rg29Yx2oDia++wk
 YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq
 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx
 /1x743oFltuOJaP28QXCUB1GCB3L59/reqvzXiX6aR/zmXDenrohf5vEFs3LcsT/eMf7WNmr
 KJCbmpXN1ba2rzwkOnTpupE36zPKOHxO4wSoDd4xCzxBvc6W5HTBa7N4Le02R9t2JERQ6uEN
 6L1bxJANivtezhBAW5ON4syg+WZg2n/biRh/Qf9Sa0fvDGIkV0ZPKLWGNjfd8GORM5Vtl2Fv
 W+A9GP8ajkFMPSPxDzD9Wij7sfOgiHTSI8UDKe/9PNhnBuU3GN7ICMRUVy3sPyokHmUUthUK
 1EX0ic2pK10/0uuJvHmRAGxqnOAuh8aWvJTHvc85QXLzbDbiy6bG2wFQzhpeNEg8sgsSlQC7
 FaJgtevPj1pv729QGiYsLyTqFuaHCkeLWYGIwgeXwYBy9D5pcc4iRenZvxuCrKvh9v5XxT52
 SmXrTMWjq8Wy8UM0s2T8VnZjhq2q5POTwpz4R/YNkqM6A9jacidfZ659lHB5N5JNoPfRV6E1
 FAUls7b4O0QAJWlkC2WXP5LDLyv/+yCMjDXnRhoBZZJyti20yf9J8YKumg4fRo3dJZfEdP0X
 KPNkT8L9ccMYDysVuw0Q4jrUukhzKHyJ+2wA5g4ceFySpR2cQaG+gRnakiRw33hnSAQrE0vB
 XuIWZ3zVShCWMyL2BLzHr1HieZ6mUjS0EuKHcijpylLx4Zyc5J8pV0tC1CJcvwipJ2NpAHY4
 r6z3OPblk0BDoUSjsTRmLP/zGzmz1BnW/gaSOQNL4ZvxzaK/kl6VJc9Jpt7KuRYc1x9zLugw
 51EchYwJKDDrXPGMx6WTXtodaniW51yxVpiY3dwZQj0gSB5Pd3zhEv6S3fRVeJ4nACE5aQlJ
 8Tphu3aWqgfItg502V1gWbBQHxKK03w2FPm09uNazkjZZ9wLzElCfe/FjYDABImV3Lt3eNn+
 uXI/lqCHfIrGlQzZO6LOanH5w7g4hAgdBdaAhKgzi97Ix63ruCH6kXZ05cKHi37AUybnGXFj
 FzKXU5wSCuki9ZdzeQlTJus9u+BO+B/AlBbDy/c67O3PjPd5W2t3clLV+PgQNwXfDikkEl7T
 ekKnfz6LtMdm1NG79h1H7pxlPps7Nrzvb5KiA9jGSyTPVisD7phJFiA3NVO6fIRluMI51PuV
 xLd4MReNJWIJNjhTAwbKj06Y7nRzvoTgDTTs6g4eR2o+C9t8bObekxOJB3Q2jdFJb54Pdp9k
 +csscIb8SKljR8uPorUhyxY7T3UfHcBT78mptcRB4qy0lgnzVRLYJr9DC7q4c7QN4UQYxdye
 jLN3fjMnbVRwEbGYkEfL3mV0LoPn4kKtTBL0EQGewaDlO3ai6JlxxZW6zk2EFhYl00Vz+JpN
 2F3HERpPqHSrSxwjc1OUm3wSQFMABqVph74x1cTzTCLSkCpUirGLXEnOPbL90ccqjoOcj9e9
 bCe6WDkTTe1I52hgnpsARZo+675UNh81gzeg8T2Tc2KEq4zbSfhnqLzN3EDrAHqAJ9piUDKz
 QWwED2ctUEv2fYsnpAG
IronPort-HdrOrdr: A9a23:MA/UdqiqutDLi9w5/eOypzO80XBQX0t13DAbv31ZSRFFG/FwyP
 rAoB1L73PJYWgqNU3I+ergBEGBKUmskqKdxbNhR4tKOzOWxVdATbsSlrcKpgePJ8SQzJ8+6U
 4NSdkaNDS0NykHsS+Y2njILz9D+qj/zEnAv463pB0MPGIaG52IrT0JcjpzencGOjWubqBJcq
 Z0iPA3wwZJLh8sH7uG7zQ+LqX+juyOsKijTQ8NBhYh5gXLpTS06ITiGxzd+hsFSTtAzZor7G
 CAymXCl+qemsD+7iWZ+37Y7pxQltek4txfBPaUgsxQDjn3kA6naKloRrXHljEop+OE7kosjb
 D30lsdFvU2z0mUUnC+oBPr1QWl+DEy60X6wVvdunfnqdyRfkNzN+NxwaZiNjfJ4Uspu99xlI
 hR2XiCipZRBRTc2Azg+tnhTXhR5wqJiEtntdRWo21UUIMYZrMUh5cY5llpHJAJGz+/wJw7Ed
 NpENrX6J9tABKnhkjizytSKeGXLzEO9k/seDlHhiXV6UkZoJlB9Tpa+CRF9U1ws67USPF/lq
 352+pT5fdzpmJ/V9MIOA47e7rENoX6e2O7DIujGyWVKEg5AQO5l3fW2sR/2Aj4Qu1D8HMN8K
 6xJ2+w81RCIn7TNQ==
X-IronPort-AV: E=Sophos;i="5.85,371,1624334400"; 
   d="scan'208";a="56976528"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Bv3Opd7tNsgM1g3kNhLqHxsUKTcycMer0Lb2ZmZWD9t/fC6nmQ8Kb9mxDxVhayoaoI6cft71Jobj4fAi4Jp90cxKhtqBolCDFd93W3nu0+tavMOY1JeKSitHdjy/TrYaLfK1g0SBhpVjHVRuC8R+i5/6q/D5bvnToQ4+uNF+U0xohVpWMpBmRDOmHYHJLPTJ5Ng8FKo3jJ54itdWbU1md95UJEzJEWrZs7Pll4VULloVzj5icbiQUUqANaRJH34DzjHtBtJ1oGhbHDM0q6NyN0h9S4sSaeHa09FYAIfYTmTRGmTEXjyvuV697RbOCW0bzPCPNSZQdXEcXRA78FlSxA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=u3lueVMk3OR7O4L8bxtNPd6WkVa3YP6XSnKGi/uvWbo=;
 b=JVaqFuoZkgak+kQvj5bNA9n7C7cO5qGTq+efy9LG/tVbdKPDdkNndijrlrG1JWv070S7QeKGfqUoDeWjZGgyVmk2CT3wZooLOOtgJxMR9WfyFi7ioDpXQrXO+0DcpzbHpDyG+4p0cgGYwWsXuqAbgG6jLdjidJzRSRVHZmNOMW6DzUHHrlrLb8FIOyXD3Q9A7nhue8FX8qV/IBsssdK9GO498Mn6H0Gfe+k5rCTMCY+fJXvfIsD4tDqlt38gDz03e/NzvZeBhXVQcEaBya6wxj1QzWNDGmfxGbewUawDXIFYkger5StFtMXWv5SL7Ip2EiyAVmM51Gseuk0hc6VKsw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=u3lueVMk3OR7O4L8bxtNPd6WkVa3YP6XSnKGi/uvWbo=;
 b=kuf2hTKwxQ1V4F/N6VnCI2xyyPBXxkokiqTDJ7Q9V5G5IiIH13kkkF5f0iOtYHfB5BLMLM9Hqp6SCQ5TnzMpkPSFuyHBsMeIzW/mczk3TmB2BidhncW4m4fzqH089O4FIHafObKW+hOYc1pJyJGqfXrfUoKX/wTRSFw8UAHvpOM=
Date: Wed, 13 Oct 2021 16:28:49 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Bertrand Marquis <Bertrand.Marquis@arm.com>
CC: Michal Orzel <Michal.Orzel@arm.com>, Rahul Singh <Rahul.Singh@arm.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Andre
 Przywara <Andre.Przywara@arm.com>, Christian Lindig
	<christian.lindig@citrix.com>, David Scott <dave@recoil.org>, Ian Jackson
	<iwj@xenproject.org>, Wei Liu <wl@xen.org>, Andrew Cooper
	<andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>, Jan
 Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>, Stefano
 Stabellini <sstabellini@kernel.org>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH v5 07/11] xen/domctl: Introduce XEN_DOMCTL_CDF_vpci flag
Message-ID: <YWbtIfMZYWR/3hnT@MacBook-Air-de-Roger.local>
References: <cover.1633540842.git.rahul.singh@arm.com>
 <20d5b9d6a0d01a7b90711d28cbefb5701a88b438.1633540842.git.rahul.singh@arm.com>
 <YWQDguvmf/O4rDIs@MacBook-Air-de-Roger.local>
 <9217a6b8-fc53-a049-7cd3-7458b574424b@arm.com>
 <YWaZKX44IOfIBtX6@MacBook-Air-de-Roger.local>
 <8F9D6B9C-58CB-4000-995A-95517EE72A3B@arm.com>
 <YWa7eGr3D8Ax8VUX@MacBook-Air-de-Roger.local>
 <9C5C0FE2-67EA-4CD7-893B-82C156F5F77A@arm.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <9C5C0FE2-67EA-4CD7-893B-82C156F5F77A@arm.com>
X-ClientProxiedBy: LNXP265CA0063.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:5d::27) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 7ea051ab-615c-4aa9-485c-08d98e55c991
X-MS-TrafficTypeDiagnostic: DM6PR03MB3484:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <DM6PR03MB34840778C458D5E62B2071978FB79@DM6PR03MB3484.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: Rljk98Jj1Q8H4xwB7oEm1Fzxhkl/AIl7kSplpXkbovRSy27xrV2+e20V9AQ3w69l+zvnMV8j+STiWgetLRgvL+QeIOePdTgCVK/gyLycnT/Py/Ey5pMzD81U2mjOp1B0d7LETk8B6TvNY3DTC8ae099oeH2JX5ltimWEwr2b3MytoF+a7y5XTS6CCg1tMa30Y/a121p8siAFlVL+HDDF2O5fL0IqrSGrHX36gYOInPDvzHXtgdbJYGGBapmzHB8zNfbKAKwfBaCcub09IjB6HChkHMSmvlOaDiVpiboUKYmyMprCzAEcZYc2qfWrWTJxr7g3yCdL6gI1G3hQnxmecEdPjY7/VnwBHur3XflXo5g+iUlH2q2I3TmjUAUwn/tVRkRmmVPte4RU8jdKxAlOR91wLoueCPwO39hf1hR/iASqHm15EGeqqsaT+r9zbZHvpqeknCfTEVc3JEH7T+t2aOvYngsNLRQHLwGb5q16ne7f2syaT9SIIUeLRCT/UodmrMTeL9aI+1D8LPIq6u0Bt3Vtx8BhWIm8jm27ZAbG/PxdbFdh8JlBC034t33pJ/psZNF93H1xRfjmlUFBBOJrXgYLhKkMSUYgXFmle3mN0hjNOFA9H3iu7DyqlJoKOra8g7nBAp1vzaUQxtYgckNeA6a4YHbo8ygozEoAiUGWQBNmuyaBf6l5LtxiYETEyc+iThE6n5liKDarTcimqNXdJw==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(85182001)(508600001)(5660300002)(54906003)(9686003)(82960400001)(186003)(316002)(26005)(38100700002)(8936002)(83380400001)(4326008)(6496006)(956004)(2906002)(86362001)(66476007)(8676002)(6666004)(6916009)(66556008)(66946007)(6486002)(53546011)(7416002)(76454003);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NlNXdkhZU3oxeGhXa2kwVW4xZzMzeGhldlQxU3VpaWoycXlibWlCZTNhZEk4?=
 =?utf-8?B?SUtuZ2s2cVNnbXRORGsva2VGbnRmYjNraDk0dDZnV05PSWxMWDlXZU55MlNt?=
 =?utf-8?B?YXAxMjYvOHU2Z2xPeG5PMFRVd1QrOHFBMVpwTks5S3FCT3pOR1d3VFpYT3po?=
 =?utf-8?B?aGNRaFRZY0poNFRoaFZKb2VzT1cvZXJ6cHNKTS9xU05yWHhVTGVpNnM4U0VW?=
 =?utf-8?B?T2JaRThVZkJWcE9ta1JXelhxek5xQ0dCbGdOUXNERktYOU81RG1NV2ZOYUov?=
 =?utf-8?B?dTlMVkhoTzBlRUxhY2hZQ1RGaXVteVhLdTY0Nkw5UXZ5K2NVYWEwTmhnem5w?=
 =?utf-8?B?VlJtSExJSjVjcU5CM3ExTGg1eTRTMkd3ZVdOOWoraUZ3VkJPM3doK2RhTnhP?=
 =?utf-8?B?QXo5RHgxdjZmVUlFaXNHWTcyUlYzUEtzWTZHQ3dUS3VRU2tXdWcyVjBPK2pS?=
 =?utf-8?B?M1pTSlpKSkZjaEN2UnhjczhRMjJkZDBGa29iaWhETWJVOEwrZUtGUTc3Y1Nr?=
 =?utf-8?B?SDNMM1BjbkpXamZuOFdLdzRZS3ppNEZIaW5HZ3pwZmsxUHRuOUJ5WHU5b3JI?=
 =?utf-8?B?UnhKZWl6SkhPRUkrSE5DWUhybkNTQUxYTjF2OEoyQVFqTklvTGYzUlZhcDln?=
 =?utf-8?B?cExIZEJjYkJWbW5wVnpNZld4UVRlTFVVZmY4RFZHYkdhK1c4UWxwbUlRVUlk?=
 =?utf-8?B?djAxME1kR2pGV1RocEpqZ2VHb0NlbmhtdzNlMkd3eWlGazJMYUZHTTZTbGhq?=
 =?utf-8?B?WHpieG5hVHdGK2Z2V01sZFhVQndWOGszdzNKZnlSL1daZnY5OHRqUWZvN3I1?=
 =?utf-8?B?eE1SaERpMFJ2ZFpEVXViU1VKN2gvQW9vZVpUSWc3Q1NUQXdla1ZhRjBnelhU?=
 =?utf-8?B?MEd6ZzdHaDY3dmUxcVdkT0pQSzVFYlkvSXc4dWFmZGZhYk5Rd3lDOWhaWVRJ?=
 =?utf-8?B?d0hqV1ZhOHJJN3JUcDhrTG5XdGhEN3NCWXJOLzFwVE1QZnpGMTZYVEx4aTV0?=
 =?utf-8?B?eHNtb01UVjBJSUFLMm8xbTA0UlBLaHcwNHBuRmk2eU55V3VyckVQV2pkdE1H?=
 =?utf-8?B?WFZjNlBxaVdNNUdrVzRYblFtWWl5TFZUL3Vrb0FPdkdsNEpBTGRSVklQcS9a?=
 =?utf-8?B?N1BVY0JzWm9ia2V6NGFMeXA5WU5lYmtYcnJ0Wnc3UDdzYm1Vb1pQVzFreERi?=
 =?utf-8?B?MHNaNWpxZ2IvSndjS3VQS29FaUlRZytUem1BTVFLZzBGU09MQ2VUZ20vVWF3?=
 =?utf-8?B?bnZwU01KSnMrd29PTncvYWxNakxDMlNNZEREY3VISUxWU0xpWThsemNmdW91?=
 =?utf-8?B?cXdTVWRaN0VMMVAxMThjRDI2bmxtRnk4TlUwcWQ3WnNSYXAvR0dVa1ptQzBT?=
 =?utf-8?B?NVdnK3M2NEUySDlMcmtucmZwUllTYnc1elJEZitiekYzamV5Zk14cG5DdWta?=
 =?utf-8?B?bnlMSkFsMXp3aU12WTFtYXBmRE53bUJYeGFlT0dRNTVzUytrZ3RyWUE0NFdS?=
 =?utf-8?B?dGNvRGR0RnQ3aUVwdjNBcWNmbU9INStVdUxzZ0t0SUFhdVlRR1NGdFk0dlF1?=
 =?utf-8?B?ajJoRkFwZGFtaGRkTFh2TWs2UVdmNVBTODlaTVNZZ2s4NWsxcmxlQ29FeGhL?=
 =?utf-8?B?MTFsdjJUYTBzRnNwQXBRNDI3bDdDcW1FVnRUbXRzV21peG5uU2Qwd2xJOUp0?=
 =?utf-8?B?YVgwNDhMQ0NJQVplN0tZWWJqOEtxSmlhNlZkNjh4L0EvazFDS296ZlVDQnFH?=
 =?utf-8?Q?KHlG7ZEFQBbV27oDufT6r4aXSEl6MLbVa0QKAYf?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 7ea051ab-615c-4aa9-485c-08d98e55c991
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2021 14:28:55.6026
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: PNoQvdbVOnYfwut2FoWFI8YG8UchDSQwV4czglhb4e4OhbpaxGWdM+jBAPSq8QN37mLJ1GwCRmV2/tlUpObi3g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB3484
X-OriginatorOrg: citrix.com

On Wed, Oct 13, 2021 at 12:11:30PM +0000, Bertrand Marquis wrote:
> Hi Roger,
> 
> > On 13 Oct 2021, at 11:56, Roger Pau Monné <roger.pau@citrix.com> wrote:
> > 
> > On Wed, Oct 13, 2021 at 09:36:01AM +0000, Bertrand Marquis wrote:
> >> Hi Roger,
> >> 
> >>> On 13 Oct 2021, at 09:30, Roger Pau Monné <roger.pau@citrix.com> wrote:
> >>> 
> >>> On Tue, Oct 12, 2021 at 12:38:35PM +0200, Michal Orzel wrote:
> >>>> Hi Roger,
> >>>> 
> >>>> On 11.10.2021 11:27, Roger Pau Monné wrote:
> >>>>> On Wed, Oct 06, 2021 at 06:40:33PM +0100, Rahul Singh wrote:
> >>>>>> Introduce XEN_DOMCTL_CDF_vpci flag to enable VPCI support in XEN.
> >>>>>> Reject the use of this new flag for x86 as VPCI is not supported for
> >>>>>> DOMU guests for x86.
> >>>>> 
> >>>>> I don't like this approach, XEN_DOMCTL_CDF_vpci should be set for x86
> >>>>> PVH dom0, like we do for any other CDF flags when Xen builds dom0.
> >>>>> 
> >>>>> Things like PVH vs PV get translated into CDF flags by create_dom0,
> >>>>> and processed normally by the sanitise_domain_config logic, vPCI
> >>>>> should be handled that way.
> >>>>> 
> >>>>> Do you think you could see about fixing this?
> >>>>> 
> >>>>> Thanks, Roger.
> >>>>> 
> >>>> 
> >>>> I have one question about this fix.
> >>>> If I set XEN_DOMCTL_CDF_vpci for dom0 pvh in create_dom0, then in
> >>>> sanitise_domain_config or arch_sanitise_domain_config I have no
> >>>> knowledge on whether I am dom0 or not. I can check if I'm PVH but not if dom0.
> >>>> This would be needed to add a warning if this flag is set but we are not dom0 pvh.
> >>>> 
> >>>> Any ideas?
> >>> 
> >>> I've just realized this is more wrong that I thought. vPCI is
> >>> signaled on x86 in xen_arch_domainconfig.emulation_flags, so
> >>> introducing a top level option for it without removing the arch
> >>> specific one is wrong, as then on x86 we have a duplicated option.
> >>> 
> >>> Then I'm also not sure whether we want to move it from
> >>> emulation_flags, it seems like the more natural place for it to live
> >>> on x86.
> >>> 
> >>> If we really want to make vPCI a CDF option we must deal with the
> >>> removal of XEN_X86_EMU_VPCI, or else you could introduce an arch
> >>> specific flag for vPCI on Arm.
> >> 
> >> First issue that we have here is that there is no emulation_flags right now on arm.
> > 
> > You don't explicitly need an emulation_flags field, you could add a
> > uint8_t vpci or some such to xen_arch_domainconfig for Arm if you
> > don't think there's a need to select more emulation. That's up to Arm
> > folks.
> 
> One way or an other it is still changing the interface.

Well, I don't want to sound rude, but you already changed the
interface first and very recently by introducing CDF_vpci. Complaining
that you don't want to change it anymore just after that seems
slightly weird.

> > 
> >> So I think there are 2 solutions:
> >> 
> >> - introduce PHYSCAP. The problem here is that it is not a physical capacity and
> >> I think that will hit us in the future for example if we want to use vpci for VIRTIO
> >> even if there is not physical PCI on the platform.
> > 
> > Hm, PHYSCAP is a bit weird, for example Xen signals shadow paging
> > support using PHYSCAP which doesn't depend on any hardware feature.
> > 
> > I think you could signal vPCI regardless of whether the underlying
> > platform has PCI devices or not, as vPCI is purely a software
> > component.
> 
> But in the x86 case this is something not supported in all cases and actually only by dom0 pvh.
> So having something like that defined as a PHYSCAP is a bit weird.

Well, even if vPCI was fully supported on x86 for both domU and dom0
it would only apply to PVH and maybe HVM guests, but classic PV will
never get vPCI. It's kind of trying to create a PV guest with HAP
support.

One option would be to defer the introduction of the CDF_vpci flag
until the vpci work has been finished - then we could decide if the
current code can also be used by x86 so maybe it could be enabled for
both arches, and there would be no problem in setting the PHYSCAP.

> >> I think the second solution is the right one but it cannot be done so near from the
> >> feature freeze.
> >> 
> >> The CDF flag as introduced right now is not creating any issue and will be used once
> >> the emulation flag will be introduce. We will be able at this stage to set this properly
> >> also on x86 (for dom0 pvh).
> >> Moreover keeping it will allow to continue to merge the remaining part of the PCI
> >> passthrough which are otherwise not possible to be done as they are dependent on this flag.
> >> 
> >> Can we agree on keep the DOMCTL_CDF_vpci flag and introduce the emulation
> >> flag on Arm after 4.16 release ?
> > 
> > If vPCI for Arm on 4.16 is not going to be functional, why so much
> > pressure in pushing those patches so fast? I understand the need to
> > remove stuff from the queue, but I don't think it's worth the cost of
> > introducing a broken interface deliberately on a release.
> 
> We did not push that fast, those have been on the mailing list for a while (this is the 5th version of the serie).
> PCI passthrough is a big change requiring lots of patches and we decided to push it piece by piece to make
> the review easier.

First version of this patch I have on my inbox is from 23rd of
September, that's less than 3 weeks ago.

> > 
> > I think we need to at least settle on whether we want to keep
> > CDF_vpci or use an arch specific signal mechanism in order to decide
> > what to do regarding the release.
> 
> Agree and I have no definitive idea on this so but switching will require to revert the patch adding CDF_vpci
> and change the subsequent patches.

I think it's fair to expect changes to the interface when things are
reviewed, that's part of the review process, changes to subsequent
patches can be painful, but we have all been there and dealt with
them.

I'm not saying we must remove the CDF_vpci flag. I have to admit I was
fine using emulation_flags, but I could also be fine using CDF_vpci if
the x86 side is fixed and XEN_X86_EMU_VPCI is removed.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Wed Oct 13 14:30:15 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 14:30:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.208572.364750 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mafGl-0001Wl-1c; Wed, 13 Oct 2021 14:30:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 208572.364750; Wed, 13 Oct 2021 14:30:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mafGk-0001We-Uv; Wed, 13 Oct 2021 14:30:10 +0000
Received: by outflank-mailman (input) for mailman id 208572;
 Wed, 13 Oct 2021 14:30:10 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=nKHt=PB=greensocs.com=damien.hedde@srs-us1.protection.inumbo.net>)
 id 1mafGj-0001Tw-Jm
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 14:30:10 +0000
Received: from beetle.greensocs.com (unknown [5.135.226.135])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 28e2b0bc-891c-47e7-a1d7-fe1a1f44caf8;
 Wed, 13 Oct 2021 14:30:08 +0000 (UTC)
Received: from [192.168.15.165] (unknown [195.68.53.70])
 by beetle.greensocs.com (Postfix) with ESMTPSA id D0C2721C32;
 Wed, 13 Oct 2021 14:30:05 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 28e2b0bc-891c-47e7-a1d7-fe1a1f44caf8
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=greensocs.com;
	s=mail; t=1634135406;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=z6HgMh5IMSwLEmZN5256moVuZUZTLWR6X/E7D989GAM=;
	b=1v5ahRx7kFy03JQEDgOMnsn6lCXMTvv/S4+cDS/eYY03VM2Fab7wi/9CaK/uJ+1vtCgm0H
	djgb9bc2m613XpLeGkEmpMC45AEY450QTrKfNQkbp7R8rGkXeXJIUrvGXVoFt5dFaeY82p
	KtyNyCsawGqJgUOc6OJpIm0RPipPZhg=
Message-ID: <11aa7a10-62ec-ebde-030c-5919e36ec34d@greensocs.com>
Date: Wed, 13 Oct 2021 16:30:05 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.1.2
Subject: Re: [RFC PATCH v2 04/16] softmmu/qdev-monitor: add error handling in
 qdev_set_id
Content-Language: en-US-large
To: Alistair Francis <alistair23@gmail.com>
Cc: "qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>,
 Peter Maydell <peter.maydell@linaro.org>, "Michael S. Tsirkin"
 <mst@redhat.com>, David Hildenbrand <david@redhat.com>,
 Peter Xu <peterx@redhat.com>, mirela.grujic@greensocs.com,
 Alistair Francis <Alistair.Francis@wdc.com>,
 Gerd Hoffmann <kraxel@redhat.com>, Ani Sinha <ani@anisinha.ca>,
 Eric Blake <eblake@redhat.com>, Stefano Stabellini <sstabellini@kernel.org>,
 "open list:X86" <xen-devel@lists.xenproject.org>, Paul Durrant
 <paul@xen.org>, Markus Armbruster <armbru@redhat.com>,
 Anthony Perard <anthony.perard@citrix.com>,
 =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= <marcandre.lureau@redhat.com>,
 Eduardo Habkost <ehabkost@redhat.com>,
 "Dr. David Alan Gilbert" <dgilbert@redhat.com>,
 Eric Auger <eric.auger@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>,
 "open list:RISC-V" <qemu-riscv@nongnu.org>,
 =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= <berrange@redhat.com>,
 Mark Burton <mark.burton@greensocs.com>, Edgar Iglesias <edgari@xilinx.com>,
 Igor Mammedov <imammedo@redhat.com>, Kevin Wolf <kwolf@redhat.com>
References: <20210922161405.140018-1-damien.hedde@greensocs.com>
 <20210922161405.140018-5-damien.hedde@greensocs.com>
 <CAKmqyKNWBYpq8CbhtGyw9=1Gt_LujZZrtD7J_Ye2FyyVA6eqcw@mail.gmail.com>
From: Damien Hedde <damien.hedde@greensocs.com>
In-Reply-To: <CAKmqyKNWBYpq8CbhtGyw9=1Gt_LujZZrtD7J_Ye2FyyVA6eqcw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit



On 10/13/21 09:10, Alistair Francis wrote:
> On Thu, Sep 23, 2021 at 2:29 AM Damien Hedde <damien.hedde@greensocs.com> wrote:
>>
>> qdev_set_id() is mostly used when the user adds a device (using
>> -device cli option or device_add qmp command). This commit adds
>> an error parameter to handle the case where the given id is
>> already taken.
>>
>> Also document the function and add a return value in order to
>> be able to capture success/failure: the function now returns the
>> id in case of success, or NULL in case of failure.
>>
>> The commit modifies the 2 calling places (qdev-monitor and
>> xen-legacy-backend) to add the error object parameter.
>>
>> Note that the id is, right now, guaranteed to be unique because
>> all ids came from the "device" QemuOptsList where the id is used
>> as key. This addition is a preparation for a future commit which
>> will relax the uniqueness.
>>
>> Signed-off-by: Damien Hedde <damien.hedde@greensocs.com>
> 
> Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
> 
> Alistair
> 

CC'ing Kevin who integrated this patch into his series about
"qdev: Add JSON -device"
https://lists.gnu.org/archive/html/qemu-devel/2021-10/msg01826.html

Thanks,
--
Damien


From xen-devel-bounces@lists.xenproject.org Wed Oct 13 14:30:27 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 14:30:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.208575.364762 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mafH1-0001vE-Al; Wed, 13 Oct 2021 14:30:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 208575.364762; Wed, 13 Oct 2021 14:30:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mafH1-0001v7-7Y; Wed, 13 Oct 2021 14:30:27 +0000
Received: by outflank-mailman (input) for mailman id 208575;
 Wed, 13 Oct 2021 14:30:25 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mafGz-0001uY-PT
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 14:30:25 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mafGz-0006nJ-ID; Wed, 13 Oct 2021 14:30:25 +0000
Received: from 54-240-197-234.amazon.com ([54.240.197.234]
 helo=[192.168.17.188]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mafGz-0006iK-CS; Wed, 13 Oct 2021 14:30:25 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=88LjASR2hZDtKWukyTX0ylkB0cMo0H54f498CUDaKhE=; b=3UpnZ4Wrmy3A7zayKAOP0t6LAP
	FHCm4TzVgbuL8sZEnXHthZaJseeV39jQWuJebj43jSRnadS0jjbrTAUozayNeQqMzu1ZrNDLwhyIs
	59qJ5sEbXz/TElaP/GxSJEN5GBpvicJRnDiD3biXltYRmGq3UVBHSRrG4rhTSEut61iQ=;
Message-ID: <ea6fa013-809b-f946-76d8-5314b45d6f17@xen.org>
Date: Wed, 13 Oct 2021 15:30:23 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.2.0
Subject: Re: [PATCH] arm/docs: Clarify legacy DT bindings on UEFI
To: Luca Fancellu <luca.fancellu@arm.com>
Cc: xen-devel@lists.xenproject.org,
 Bertrand Marquis <bertrand.marquis@arm.com>, wei.chen@arm.com,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <20211013121929.30784-1-luca.fancellu@arm.com>
 <a31231e3-a1eb-0e1f-59b8-75677d5db51b@xen.org>
 <363EAF93-1165-4515-A582-B40B6115FA71@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <363EAF93-1165-4515-A582-B40B6115FA71@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi Luca,

On 13/10/2021 15:06, Luca Fancellu wrote:
> 
> 
>> On 13 Oct 2021, at 14:27, Julien Grall <julien@xen.org> wrote:
>>
>> Hi Luca,
>>
>> On 13/10/2021 13:19, Luca Fancellu wrote:
>>> Legacy compatible strings for dom0 modules are not
>>> supported when booting using UEFI, the documentation
>>> doesn't mention that.
>>
>> Can you add a summary in the commit message why we consider the legacy binding is not supported?
> 
> Yes what about:
> 
> Since the introduction of UEFI boot for Xen, the legacy
> compatible strings were not supported and the stub code
> was checking only the presence of “multiboot,module” to
> require the Xen UEFI configuration file or not.
> The documentation was not updated to specify that behavior.
> 
> Add a phrase to docs/misc/arm/device-tree/booting.txt
> to clarify it.

Sounds good to me. You can add my ack on it:

Acked-by: Julien Grall <jgrall@amazon.com>

Would you be able to respin the patch with the two changes?

> 
>>
>>> Add a phrase to docs/misc/arm/device-tree/booting.txt
>>> to clarify it.
>>> Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>
>>> ---
>>>   docs/misc/arm/device-tree/booting.txt | 2 ++
>>>   1 file changed, 2 insertions(+)
>>> diff --git a/docs/misc/arm/device-tree/booting.txt b/docs/misc/arm/device-tree/booting.txt
>>> index c6a775f4e8..017c0f13eb 100644
>>> --- a/docs/misc/arm/device-tree/booting.txt
>>> +++ b/docs/misc/arm/device-tree/booting.txt
>>> @@ -51,6 +51,8 @@ Each node contains the following properties:
>>>   	Xen 4.4 supported a different set of legacy compatible strings
>>>   	which remain supported such that systems supporting both 4.4
>>>   	and later can use a single DTB.
>>> +	However when booting Xen using UEFI and Device Tree, the legacy
>>
>> NIT: I would drop "and Device Tree" because this feels a bit redundant as this compatible can only be used in the Device-Tree.
> 
> I will drop it
> 
>>
>>> +	compatible strings are not supported.
>>>     	- "xen,multiboot-module" equivalent to "multiboot,module"
>>>   	- "xen,linux-zimage"     equivalent to "multiboot,kernel"
>>
>> Cheers,
>>
>> -- 
>> Julien Grall
> 

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Oct 13 14:50:52 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 14:50:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.208590.364773 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mafaf-0004aF-W3; Wed, 13 Oct 2021 14:50:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 208590.364773; Wed, 13 Oct 2021 14:50:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mafaf-0004a8-Sk; Wed, 13 Oct 2021 14:50:45 +0000
Received: by outflank-mailman (input) for mailman id 208590;
 Wed, 13 Oct 2021 14:50:44 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Kt2p=PB=arm.com=Luca.Fancellu@srs-us1.protection.inumbo.net>)
 id 1mafae-0004a2-O3
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 14:50:44 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com (unknown
 [40.107.7.43]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id f015d2d8-2c34-11ec-817c-12813bfff9fa;
 Wed, 13 Oct 2021 14:50:42 +0000 (UTC)
Received: from AM6P191CA0005.EURP191.PROD.OUTLOOK.COM (2603:10a6:209:8b::18)
 by PAXPR08MB7317.eurprd08.prod.outlook.com (2603:10a6:102:230::9) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.24; Wed, 13 Oct
 2021 14:50:40 +0000
Received: from VE1EUR03FT017.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:209:8b:cafe::c8) by AM6P191CA0005.outlook.office365.com
 (2603:10a6:209:8b::18) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.14 via Frontend
 Transport; Wed, 13 Oct 2021 14:50:39 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT017.mail.protection.outlook.com (10.152.18.90) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4587.18 via Frontend Transport; Wed, 13 Oct 2021 14:50:39 +0000
Received: ("Tessian outbound b9598e0ead92:v103");
 Wed, 13 Oct 2021 14:50:39 +0000
Received: from bcdf1e605cd0.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 B6AC65D4-3B75-44B0-A6C9-E8DB2C72BB6C.1; 
 Wed, 13 Oct 2021 14:50:32 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id bcdf1e605cd0.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Wed, 13 Oct 2021 14:50:32 +0000
Received: from PAXPR08MB6816.eurprd08.prod.outlook.com (2603:10a6:102:130::10)
 by PR3PR08MB5820.eurprd08.prod.outlook.com (2603:10a6:102:90::6) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15; Wed, 13 Oct
 2021 14:50:30 +0000
Received: from PAXPR08MB6816.eurprd08.prod.outlook.com
 ([fe80::c1b4:db1c:376f:b697]) by PAXPR08MB6816.eurprd08.prod.outlook.com
 ([fe80::c1b4:db1c:376f:b697%8]) with mapi id 15.20.4587.030; Wed, 13 Oct 2021
 14:50:29 +0000
Received: from smtpclient.apple (82.8.129.65) by
 LO4P123CA0394.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18f::21) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.14 via Frontend Transport; Wed, 13 Oct 2021 14:50:28 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f015d2d8-2c34-11ec-817c-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=xwcp5+e+B8k35c/ETyIx9NvW5bJ/wHOu5HUy3PMic94=;
 b=MhLhMKndFEBNaJOUezXlZrv7jQuyf9GGsVuE7fs3HAXlLtMhKAmdL2M7cqOVP2ehJJJBojXM4GejzIAYowkh21IHWsktFDNklQkBWnKLQ/EvfK44+YNnWNoXM4lmlD7/CBkc/ktsrcSyDxFXnl4Igx5boxFf5ZIlyOBkx23Q6cI=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: ea3d25e5a4ea05fa
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=fim+ZR+Q3Ci1YWurGQpKapEikkMdtbTPkVakNdb7/s3aZY53dJ8j5wVpx7rANvLQN3RkrHRUHgIahE41koz97+peaGVnoggw8XdvftYSjCS185ldT3Ahx/ZZ/7Xr1dqBSioieus05fRTD3h0e5xiq6wgCcTcxXJJLmT7X1jb7N5KNRPXrR/Pc0IubWtEL57wgWe8Tx0/bTzv/QFJ+9uvunnwNaJsav6LMmTGJhXOrKPdW7yt8h8YO64yPvsgMwwdV2UaWf0di/nXa5hJUtoZEKrzuIT6Mob90zGY58gvlGRP8FewkFBnRkblcoChx7nHwVwuorv1bVFGzunSiiWgjw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=xwcp5+e+B8k35c/ETyIx9NvW5bJ/wHOu5HUy3PMic94=;
 b=kwBcse/qsjN3aiXtXMp/nvOswKVZrXrg8G5toKic7OAlR8nY3k4hHxoMYAlFukfdI8h41+VLU+I2GRSf3DFRra6fsVQiFToHZsP54ufbcKUEs4G3VNPKeJjSM+tD/EejoFRIXwrJjcz6E9qDsTzAKOXe5/fnuX+rIFdJox7zQmP08AZU1LmdiMLJMpppyfYh8j1abRp9gRgfYqlWwQ0V8RbHRSXmMCUxqlFd41BFAa8kymePNakWTiDdBOH3ZWX0CjBTlCtI9QJlk8nKqWjPyr7Y1p5lVrbU7p3k734nLutK7EvWZg3xJPOeJBWwg6dXv5ZoVleGMM0iKVxu2HFkLg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=xwcp5+e+B8k35c/ETyIx9NvW5bJ/wHOu5HUy3PMic94=;
 b=MhLhMKndFEBNaJOUezXlZrv7jQuyf9GGsVuE7fs3HAXlLtMhKAmdL2M7cqOVP2ehJJJBojXM4GejzIAYowkh21IHWsktFDNklQkBWnKLQ/EvfK44+YNnWNoXM4lmlD7/CBkc/ktsrcSyDxFXnl4Igx5boxFf5ZIlyOBkx23Q6cI=
Authentication-Results-Original: xen.org; dkim=none (message not signed)
 header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
Content-Type: text/plain;
	charset=utf-8
Subject: Re: [PATCH] arm/docs: Clarify legacy DT bindings on UEFI
From: Luca Fancellu <luca.fancellu@arm.com>
In-Reply-To: <ea6fa013-809b-f946-76d8-5314b45d6f17@xen.org>
Date: Wed, 13 Oct 2021 15:50:22 +0100
Cc: xen-devel@lists.xenproject.org,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 wei.chen@arm.com,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Content-Transfer-Encoding: quoted-printable
Message-Id: <E1D36194-81AC-41A6-8EC7-E599DB8D4C5A@arm.com>
References: <20211013121929.30784-1-luca.fancellu@arm.com>
 <a31231e3-a1eb-0e1f-59b8-75677d5db51b@xen.org>
 <363EAF93-1165-4515-A582-B40B6115FA71@arm.com>
 <ea6fa013-809b-f946-76d8-5314b45d6f17@xen.org>
To: Julien Grall <julien@xen.org>
X-Mailer: Apple Mail (2.3654.120.0.1.13)
X-ClientProxiedBy: LO4P123CA0394.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:18f::21) To PAXPR08MB6816.eurprd08.prod.outlook.com
 (2603:10a6:102:130::10)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 89fd115b-1d4b-4b19-14a7-08d98e58d2e9
X-MS-TrafficTypeDiagnostic: PR3PR08MB5820:|PAXPR08MB7317:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS:
	<PAXPR08MB73171E5315F5ABB4A978DD6CE4B79@PAXPR08MB7317.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 NfZ85cXXWcnCBAONwQYyUJohaioAeHrM90iy+r2TMJQ5iLgbLxwcjziT4yx8pDUqjoNUgGK8TW/tdpqS3qBtWKYzP9aP/Nz3wiUubolgWUZu+EV5CdcsqSzp0cXMZC296pD1HdTBdIeKNtFR+uc8NvFf3dN17TgGyLbKtv97OLm36sAgcu4vwydfWHBxi3AW2Vm/jeV9EbR4ioDbqwIQj8eeumnvmneM3JSoIyt0d7NYwatcsGZ6dLDSaRt8pr+wd/YFliMk2cb/MaAnYD/FZJkeXujYKdvqGz8yhVLj7fGWyTBh5euFH+t36q9L5S1DrusSsTQqkCIsK0ABVawbocCMaNzoNMLCfRX0vrswX0rgntgXiCQ76QOaNXXsNJaVDaLUSQqffAhANYOobBdrQm9ZZ3eBfduKoNQxh2y5AVXFDxfceHOIPPH84nrYTmH4aCgG9HM5s2FkNLbx0m+WAOIZT/ZM2H9LRfOiK+DtUE9oUgTdLmtPKAXaxLj0TRVyfrpeDEDBetPfSQbRuSZu6SXM2awADinCZLL0tsx3T3ud5XaI1vFYZQPJJaI+ZIlKoHDnyv30Zb2wI1cFhJR8cYrwA2mauGknEhQcPEycpQx5/GOScmlX2A16VV558dgwIr5gfHxMFjFQakk6bGe4yuWRWTNI7HXLr61Rlaf/PTgR7OvK1avd1Zsmq+38zYTD5HR+ZAed1ma303HgeO+gEjkOeEywZKuUF/NgWPm5B2Ijx/7FS08itEnfTFkZSN46
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB6816.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(4326008)(6666004)(6916009)(2906002)(5660300002)(66946007)(6506007)(53546011)(44832011)(6512007)(52116002)(8936002)(66476007)(66556008)(186003)(26005)(8676002)(316002)(54906003)(33656002)(86362001)(38100700002)(38350700002)(508600001)(956004)(2616005)(36756003)(83380400001)(6486002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR08MB5820
Original-Authentication-Results: xen.org; dkim=none (message not signed)
 header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT017.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	77f17a76-f9d0-4c35-11cb-08d98e58cca1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	GRG00jnphMiyEpleeuRRzQ3HE2CVdqKkLotoxfIxJniDhSiAq60qDz522I8Ycgrf8kMZpFn03scIsjkFkWxq/sJp7OBcawzK8xjfAOGn+YH/FCUKyvez4zKovUcEol4Irhpao/P0fXbAaBJtpL+g7GSRwva4BalXzIyHahSJD8PS6MAcgpZIoYPXCiXu5MVb/V2MTzAYMejPNcVQg2UwyxuFMtW9RVt4RPsSkzj3cfz1jzYqPN2PaRq9UioVLRu7YnS9WwThIRmPDtB/nbIcbFRBSDLhiAJRq0GGK7NOm/j0kPjw2dFGFeHxJ6v+7/KAOupIEUGagzeCzAUPWg+sAFZovJnBpJld2a3/oDLPWgyFzXO8jxrJYEuRpYRfEDkVm5wrMwwAr2Mq+t9+Cb8amk4/ZNFZ6X2HVlEhv8ENE6d3LTmeh3QBkbFsV+/YyfgTIdUrxR4dLKOgUjFmGVD4+DlFdi+ja7FR7zTu0rW0UkMjIdVdWp3kraxzjBRHOM3BNmOJPRUH3ihIaZVFgwthXzIBEnH4c6XE6NAXNcwDNLTInL2Dy3cQKUQ5n27gXoR/JmY6miwox5Btf3mNRN3XbKK3ErkZMDt/MRwOfOlgm+89qhJm01Q2JNKTR3Spo9TvDgdhIcG27XDefT0GgL7+5PVOER1zW1+xTUELDTyxzAuLbIt5NwrYGLVQm+amUmE1X2xQHYoSQOAERFKD+kJXag==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(26005)(8936002)(956004)(83380400001)(186003)(82310400003)(36860700001)(8676002)(5660300002)(6666004)(107886003)(6506007)(508600001)(36756003)(53546011)(2616005)(47076005)(2906002)(86362001)(33656002)(54906003)(6486002)(6512007)(44832011)(316002)(336012)(70206006)(356005)(4326008)(6862004)(81166007)(70586007);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2021 14:50:39.5003
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 89fd115b-1d4b-4b19-14a7-08d98e58d2e9
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT017.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB7317



> On 13 Oct 2021, at 15:30, Julien Grall <julien@xen.org> wrote:
>=20
> Hi Luca,
>=20
> On 13/10/2021 15:06, Luca Fancellu wrote:
>>> On 13 Oct 2021, at 14:27, Julien Grall <julien@xen.org> wrote:
>>>=20
>>> Hi Luca,
>>>=20
>>> On 13/10/2021 13:19, Luca Fancellu wrote:
>>>> Legacy compatible strings for dom0 modules are not
>>>> supported when booting using UEFI, the documentation
>>>> doesn't mention that.
>>>=20
>>> Can you add a summary in the commit message why we consider the legacy =
binding is not supported?
>> Yes what about:
>> Since the introduction of UEFI boot for Xen, the legacy
>> compatible strings were not supported and the stub code
>> was checking only the presence of =E2=80=9Cmultiboot,module=E2=80=9D to
>> require the Xen UEFI configuration file or not.
>> The documentation was not updated to specify that behavior.
>> Add a phrase to docs/misc/arm/device-tree/booting.txt
>> to clarify it.
>=20
> Sounds good to me. You can add my ack on it:
>=20
> Acked-by: Julien Grall <jgrall@amazon.com>
>=20
> Would you be able to respin the patch with the two changes?

Yes I will, thank you.

Cheers,
Luca

>=20
>>>=20
>>>> Add a phrase to docs/misc/arm/device-tree/booting.txt
>>>> to clarify it.
>>>> Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>
>>>> ---
>>>>  docs/misc/arm/device-tree/booting.txt | 2 ++
>>>>  1 file changed, 2 insertions(+)
>>>> diff --git a/docs/misc/arm/device-tree/booting.txt b/docs/misc/arm/dev=
ice-tree/booting.txt
>>>> index c6a775f4e8..017c0f13eb 100644
>>>> --- a/docs/misc/arm/device-tree/booting.txt
>>>> +++ b/docs/misc/arm/device-tree/booting.txt
>>>> @@ -51,6 +51,8 @@ Each node contains the following properties:
>>>>  	Xen 4.4 supported a different set of legacy compatible strings
>>>>  	which remain supported such that systems supporting both 4.4
>>>>  	and later can use a single DTB.
>>>> +	However when booting Xen using UEFI and Device Tree, the legacy
>>>=20
>>> NIT: I would drop "and Device Tree" because this feels a bit redundant =
as this compatible can only be used in the Device-Tree.
>> I will drop it
>>>=20
>>>> +	compatible strings are not supported.
>>>>    	- "xen,multiboot-module" equivalent to "multiboot,module"
>>>>  	- "xen,linux-zimage"     equivalent to "multiboot,kernel"
>>>=20
>>> Cheers,
>>>=20
>>> --=20
>>> Julien Grall
>=20
> Cheers,
>=20
> --=20
> Julien Grall



From xen-devel-bounces@lists.xenproject.org Wed Oct 13 14:51:31 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 14:51:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.208595.364784 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mafbP-00058J-AP; Wed, 13 Oct 2021 14:51:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 208595.364784; Wed, 13 Oct 2021 14:51:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mafbP-00058C-5s; Wed, 13 Oct 2021 14:51:31 +0000
Received: by outflank-mailman (input) for mailman id 208595;
 Wed, 13 Oct 2021 14:51:29 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=GwvX=PB=epam.com=prvs=09201fb8eb=oleksandr_andrushchenko@srs-us1.protection.inumbo.net>)
 id 1mafbN-000582-Cg
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 14:51:29 +0000
Received: from mx0a-0039f301.pphosted.com (unknown [148.163.133.242])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 0b1dc929-2c35-11ec-817c-12813bfff9fa;
 Wed, 13 Oct 2021 14:51:28 +0000 (UTC)
Received: from pps.filterd (m0174676.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 19DE3D87005342; 
 Wed, 13 Oct 2021 14:51:22 GMT
Received: from eur01-he1-obe.outbound.protection.outlook.com
 (mail-he1eur01lp2057.outbound.protection.outlook.com [104.47.0.57])
 by mx0a-0039f301.pphosted.com with ESMTP id 3bntyka1m7-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Wed, 13 Oct 2021 14:51:22 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by AM0PR03MB6068.eurprd03.prod.outlook.com (2603:10a6:208:166::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.19; Wed, 13 Oct
 2021 14:51:17 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::b034:334a:abf5:223c]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::b034:334a:abf5:223c%7]) with mapi id 15.20.4587.029; Wed, 13 Oct 2021
 14:51:17 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0b1dc929-2c35-11ec-817c-12813bfff9fa
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=XJcGPZb8zGXKYr1ykDL0SXegzhtuZfP2QDJiqAl1gnCJvzQvZsxFAv3+ERPUvCNqCgiFBLTAs9TofnbaRNddsPVkP2F+LghbBnkHCLDJxH9N1IIDzUmr3kq6VeVqYh8KPPD5qLLXubkYf5d3jH0tdwO+qsrgv0kEvPHkvYX1qzsyHUkwew2BihEmt9hKiOdZZ270w+LbfvF5RGOGGTPdppOlOBXDyLdk89EXfEM2VORzdvlkkGVwySKOmFojsmY9Pe/J1ZL6K2GQkO9PULM3VwWu6FLEPHtLXKOUZVdE4XMvnws7d9kfmv54smJpVI6Z0gdBOdDr+HToULAGj5Dkpg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=oGeBbWoqVYOkNmFbkteVlod7g6FVWoiF5XzTLae9/gg=;
 b=f6eUk0LE6mz3Moqujr8i43r/JWGMUaGrl26xRjnQqmayce8vtvCuz/KI5bMOs7rFH6Lm1DGOiRoVnAUA8hRhBbHMHt8wh3JJVVf53GZwEt23eWUA3FRKG0OJRjsSr2bznvQbIbU/5AYEt02qPvBsLn1JCkeIWjd/4bF9X775Y54i6pYO+MkvbxS1XTQ+ML30zIggQ04tXOYIjO6n0sKkLvcStBDsTrcxJ0YfMNm4ba7Uz5bimPaQ5u2D8K87VlEUbPkmIlx3sZ0aq9kEu0J6KTd+tDgYEi7YwbrVlNh1F+Il5STI5eVX+LZDITbcXawdp9TaiBo3xmUNPSmSA0AaHA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=oGeBbWoqVYOkNmFbkteVlod7g6FVWoiF5XzTLae9/gg=;
 b=mYtDeDXvGwdHcYwb6f30kODXdtaPb3wUz8B6GvNW2fHyL4YWpYMiGi6/q3l7aJp1Sqo57QwmBCjG2kp3tVqk7PaarTpgsXkdmWF2Izf60g0bz8TlzZTDgODEvarHQ58R9YooUrFyNqdvvscNnyhXU8v8OCKCeq9JF60phYtRMTiYMIf54j8WfaWBH1z0QLV922MRVAcbzX3eo9yuFUYcCotIAKKZ0Hyd9/llYWJJJh5B3lpocDWzf0WXuaVemKLeM4pTXpSstfPO5qvNIAEcJ1mqNHpZQHrPoFdbGBw0Uwo+1L7U2YTy9kKbAZvH30W/OLmVVDFK7TEJSzTAolB6Fw==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Jan Beulich <jbeulich@suse.com>,
        =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?=
	<roger.pau@citrix.com>,
        Rahul Singh <rahul.singh@arm.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        "Andre.Przywara@arm.com"
	<Andre.Przywara@arm.com>,
        Stefano Stabellini <sstabellini@kernel.org>,
        Julien
 Grall <julien@xen.org>,
        Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
        Andrew Cooper <andrew.cooper3@citrix.com>,
        George Dunlap
	<george.dunlap@citrix.com>,
        Ian Jackson <iwj@xenproject.org>, Wei Liu
	<wl@xen.org>,
        Paul Durrant <paul@xen.org>,
        Oleksandr Andrushchenko
	<Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH v5 08/11] xen/arm: Enable the existing x86 virtual PCI
 support for ARM.
Thread-Topic: [PATCH v5 08/11] xen/arm: Enable the existing x86 virtual PCI
 support for ARM.
Thread-Index: AQHXwEHGYqS5dHXsYk6KpdKt4d14RQ==
Date: Wed, 13 Oct 2021 14:51:16 +0000
Message-ID: <2b943774-072e-20a1-b97c-d88b24adf340@epam.com>
References: <cover.1633540842.git.rahul.singh@arm.com>
 <9bdca2cda5d2e83f94dc2423e55714273539760a.1633540842.git.rahul.singh@arm.com>
 <YWaco/UvA4xFE1xW@MacBook-Air-de-Roger.local>
 <6d75f604-6938-b185-61e1-a6684d9fca14@suse.com>
In-Reply-To: <6d75f604-6938-b185-61e1-a6684d9fca14@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
authentication-results: suse.com; dkim=none (message not signed)
 header.d=none;suse.com; dmarc=none action=none header.from=epam.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 4958c33e-38c6-49f4-ee4c-08d98e58e946
x-ms-traffictypediagnostic: AM0PR03MB6068:
x-ms-exchange-transport-forked: True
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <AM0PR03MB6068C4BDFD0BAE6152D3E70FE7B79@AM0PR03MB6068.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:9508;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 dkcmmppYS3LvQh/FHO4j2QpSflLOI3w4sHDRRrGUGmsYboJTFnZ9505MHV3JmrB+enNWuXLvgu09c9A+8zaI49G4BMh8scUW4LuTI/DkhILquFkHRw8hgdNM0zTU/2MnScB8eenWP4LCSYl58rxt/r+jFCGApD4QQdCilmsQy85a8yxWUnBgzGY8X+LDUh6tmGjDHUCUYkeGVPbb3y3ME9o7W8LgQnaUYhSAXzpNeu59Ql0pFsCKOOAD6EnaRGfhPXktEyxt+r1a3Te2xI7UEWO4hLyaBu1nTvxh3ShfPRnBOEUS9tVqgQ3lZktcNDkOpzqrURoCmSgODSyvNNtGrnUVywAZ/eMn/RlYDqaq9HRhhU2Tkxa7BAbvJK/z7fuYkwCyGuZpqmZJ74lRxwnwy3tj1M+Bebbp5Oz7hl0t8NOm0bPM/7J+NK4N9RYVrm90PkJxq5rZtEbVtyPNDMmtDBTAa+iiakLdfaIMf1QaEGbf0MCSUKuszV84zVlltHj/LEsILd3F0AFoUhr1fOAgWlcwX64WvFEJDJ+k6EPHn78Xev9IMg4JeAdMA0fAd9NKx/HgbriVYTmwNdnbnKyRs33OD8NOGz9t71R+vyNRx6PABbgfu7e/Uc8psjZPW1xRAxUr/qkNYyyM4UiFubSrxDnqLHY/jqUunBywm8aJnHXGWSI8vOqnQ48A4zznMoso7sKcjYxJXVVd4rTGYvE1z17C+QQnl+XeC03sHQo/OzuqMZi+nbPxzjY4qfhZefUbVbeD4XpbCexi5tdLefLmjg==
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(53546011)(6506007)(8676002)(71200400001)(508600001)(2616005)(38070700005)(76116006)(91956017)(6486002)(4326008)(83380400001)(5660300002)(316002)(110136005)(54906003)(122000001)(31686004)(7416002)(36756003)(186003)(64756008)(66476007)(2906002)(8936002)(107886003)(86362001)(38100700002)(6512007)(66446008)(26005)(31696002)(66946007)(66556008)(2004002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?NkZxeW5taHdGQ3RScE55OWU5ZmRsU0dqN2ZHTFFqNHUrU2E5WWRvSEExcTlt?=
 =?utf-8?B?QUpBdW9GSU9Tdm1taVVxL29aenh4S0xWRWZCU0NESUF1Z2xnL24zYk1SeUd3?=
 =?utf-8?B?VzE3UjIxU0ovSkYrZkw3dDZSMFB5blArTEcyNkhmR1JIZXM5ZmxTeS94bmxj?=
 =?utf-8?B?NjlSeUtnSkdpNWRNcWYvVzhzdWVHVk9sNU5SZFVHaWJkcThqUXVtNUw1TUVu?=
 =?utf-8?B?OEMvcnhPM2dJT1dQdi84YWdBQ1Q1THdwSTMrbmZLMCtFTjVXOE5jWEJQWWt2?=
 =?utf-8?B?bmpqVUZOUXVabC9MWWFJaXltTDY4UjFsZmdOMzIzR2xZLytNL0pERjJpSStE?=
 =?utf-8?B?ekZzZTJDbkJGY3ZMUGdTRUw2ZkUzQWNLTjJLL3FubnhhT1JQNVhuUHkrVDFK?=
 =?utf-8?B?S0dMbmRlYWVQb3Bvb3VwVXRrckd2ZmI4RVZLYlovL01xREFRMEM2YytWcWlh?=
 =?utf-8?B?VlBTK1NHWmpaL3pIUGF5c0t6cncwYjl6b1Nib0RJTTlhMzQzUWRaTU1LUTBX?=
 =?utf-8?B?UG8rZ040QWR1dXdzekFqL2RQd3RXWVRYM0RYWkxwT2lLQWI3ZDVrS2RmQnoy?=
 =?utf-8?B?OWVnS0tEeE53Q2hYcnNYQSs2SnluakRkTmpsUERkZTRMaldBSHdNRVMvdXFz?=
 =?utf-8?B?UXJiSklxOVFXWFNiSVIrWGFnTmsyb01QZkhGSFAwM3VZQzlvUHRUcExVck5D?=
 =?utf-8?B?cktKaTlwWERqaG5UaDFidk9kUHNwNEorOTlmK0dVOTZsOWNRSWloQkZCRTB0?=
 =?utf-8?B?VkcvYkVWQ0xHZWp1QkpaVVhMNUg4ck9zODB0ZGUrTlR0THM2YisvVCt5dEVE?=
 =?utf-8?B?ay9Sd0d2aExqTUxOTnp0Wm9ZWTZ1Mm1aMzA4TmsrV0h0ZGR2UTd0c040YmVX?=
 =?utf-8?B?NWVERytXTm0vc01EZU5ZUUdUd05BakJDc2xycFlPZEFwZmtyNDNFQklhRDE2?=
 =?utf-8?B?aHRHcldaSTVMbHpJcFI5UUhlMEdvRVh1N3BBQVRrVWtqVjF2Ty9RUmN3ZkRK?=
 =?utf-8?B?NW13N3F5TGIvTVdUSm1sajczbTJybmphTi9aRy9vZjBYYTZlWDA4bWdaYlp6?=
 =?utf-8?B?S3hhczYvNGdncDVmZnZKR2xLeWE3VFhFV3phTDZGOThMcEl2YjRPU0MwYnk5?=
 =?utf-8?B?c2dUYmxIUHBaT044VFJDekVTTE04TmpCQm1pZGtnTTdXV1I1YmxuSkFjYVdX?=
 =?utf-8?B?Y08xdlZLVFhjV1VRTU9FQW9UaUlCbkVYaWxLanhxd2lkYjhGRXBZajFPenR5?=
 =?utf-8?B?dXlXK2xzREIvQkx6cHVWVVF0dmxCWUxTaFR0Z3ZXc21iYXl3eHNhekRZbVV2?=
 =?utf-8?B?Nm5rYXlzYkJPTVA5S1FKWU1ndUptWmpHbUQzYlpwaDZpRzJrMlJvRU1kK0pW?=
 =?utf-8?B?bWoxeVZMNWNLMWYxNWVFZXZlcHJjdnZ3N29udTVMTld5SkVSWWFiZVlXMjF1?=
 =?utf-8?B?TTBjVjgvM3F0dFBhRjhkaE1KdEpGNE1uUFJyd0loZnErVjhOVWJ1ZFh3RHRp?=
 =?utf-8?B?RTJIekRiSjRTN3pJdnVtMmFGVXVBczVRY1g0OE1LQWt5cmFuRzF3RFBXb2xF?=
 =?utf-8?B?REdLWWFodUEwaUNsMnM0KzlhcktjR3ppTU0vblRIWlJLeEVvYlFjQk9HTXNw?=
 =?utf-8?B?OVI3MnNPYTNRclJzSDN6ZGx5TkF1Y2M5V0d1czArSmljRHcwOVNmMGk4WnRr?=
 =?utf-8?B?cTgySEg0RHNUWXpxSFR3eThxeEdHMzQ3SVpFRDZlQ2NsSE1HQkVyMzY5cWxI?=
 =?utf-8?Q?bcrgygBFFkMr95kvBKjLLODfHLzeQhPbliDChk7?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <B102ABC94CF4824592521D4C43EA9666@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4958c33e-38c6-49f4-ee4c-08d98e58e946
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Oct 2021 14:51:16.9969
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: jtDud21HdJrYTjEITIZ4RsGHItYGk3fy+Re3LAva+CdZc4p8F0EYSF4rnCp/0xFT+AD/E+UnWPqr+MIUG/86vGgjpq+APUgk6E5SpJT+za1dWebYg0e+UwvlyO5tcTzN
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR03MB6068
X-Proofpoint-GUID: iClcanzWIKpTTDpyJflY4jMy84W5ZHRY
X-Proofpoint-ORIG-GUID: iClcanzWIKpTTDpyJflY4jMy84W5ZHRY
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475
 definitions=2021-10-13_05,2021-10-13_02,2020-04-07_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 phishscore=0
 adultscore=0 priorityscore=1501 suspectscore=0 clxscore=1015 bulkscore=0
 mlxlogscore=999 malwarescore=0 impostorscore=0 mlxscore=0
 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2109230001 definitions=main-2110130098

DQoNCk9uIDEzLjEwLjIxIDE2OjAwLCBKYW4gQmV1bGljaCB3cm90ZToNCj4gT24gMTMuMTAuMjAy
MSAxMDo0NSwgUm9nZXIgUGF1IE1vbm7DqSB3cm90ZToNCj4+IE9uIFdlZCwgT2N0IDA2LCAyMDIx
IGF0IDA2OjQwOjM0UE0gKzAxMDAsIFJhaHVsIFNpbmdoIHdyb3RlOg0KPj4+IFRoZSBleGlzdGlu
ZyBWUENJIHN1cHBvcnQgYXZhaWxhYmxlIGZvciBYODYgaXMgYWRhcHRlZCBmb3IgQXJtLg0KPj4+
IFdoZW4gdGhlIGRldmljZSBpcyBhZGRlZCB0byBYRU4gdmlhIHRoZSBoeXBlciBjYWxsDQo+Pj4g
4oCcUEhZU0RFVk9QX3BjaV9kZXZpY2VfYWRk4oCdLCBWUENJIGhhbmRsZXIgZm9yIHRoZSBjb25m
aWcgc3BhY2UNCj4+PiBhY2Nlc3MgaXMgYWRkZWQgdG8gdGhlIFhlbiB0byBlbXVsYXRlIHRoZSBQ
Q0kgZGV2aWNlcyBjb25maWcgc3BhY2UuDQo+Pj4NCj4+PiBBIE1NSU8gdHJhcCBoYW5kbGVyIGZv
ciB0aGUgUENJIEVDQU0gc3BhY2UgaXMgcmVnaXN0ZXJlZCBpbiBYRU4NCj4+PiBzbyB0aGF0IHdo
ZW4gZ3Vlc3QgaXMgdHJ5aW5nIHRvIGFjY2VzcyB0aGUgUENJIGNvbmZpZyBzcGFjZSxYRU4NCj4+
PiB3aWxsIHRyYXAgdGhlIGFjY2VzcyBhbmQgZW11bGF0ZSByZWFkL3dyaXRlIHVzaW5nIHRoZSBW
UENJIGFuZA0KPj4+IG5vdCB0aGUgcmVhbCBQQ0kgaGFyZHdhcmUuDQo+Pj4NCj4+PiBGb3IgRG9t
MGxlc3Mgc3lzdGVtcyBzY2FuX3BjaV9kZXZpY2VzKCkgd291bGQgYmUgdXNlZCB0byBkaXNjb3Zl
ciB0aGUNCj4+PiBQQ0kgZGV2aWNlIGluIFhFTiBhbmQgVlBDSSBoYW5kbGVyIHdpbGwgYmUgYWRk
ZWQgZHVyaW5nIFhFTiBib290cy4NCj4+Pg0KPj4+IFNpZ25lZC1vZmYtYnk6IFJhaHVsIFNpbmdo
IDxyYWh1bC5zaW5naEBhcm0uY29tPg0KPj4+IFJldmlld2VkLWJ5OiBTdGVmYW5vIFN0YWJlbGxp
bmkgPHNzdGFiZWxsaW5pQGtlcm5lbC5vcmc+DQo+Pj4gLS0tDQo+Pj4gQ2hhbmdlIGluIHY1Og0K
Pj4+IC0gQWRkIHBjaV9jbGVhbnVwX21zaShwZGV2KSBpbiBjbGVhbnVwIHBhcnQuDQo+Pj4gLSBB
ZGRlZCBSZXZpZXdlZC1ieTogU3RlZmFubyBTdGFiZWxsaW5pIDxzc3RhYmVsbGluaUBrZXJuZWwu
b3JnPg0KPj4+IENoYW5nZSBpbiB2NDoNCj4+PiAtIE1vdmUgYWRkaXRpb24gb2YgWEVOX0RPTUNU
TF9DREZfdnBjaSBmbGFnIHRvIHNlcGFyYXRlIHBhdGNoDQo+Pj4gQ2hhbmdlIGluIHYzOg0KPj4+
IC0gVXNlIGlzX3BjaV9wYXNzdGhyb3VnaF9lbmFibGVkKCkgaW4gcGxhY2Ugb2YgcGNpX3Bhc3N0
aHJvdWdoX2VuYWJsZWQgdmFyaWFibGUNCj4+PiAtIFJlamVjdCBYRU5fRE9NQ1RMX0NERl92cGNp
IGZvciB4ODYgaW4gYXJjaF9zYW5pdGlzZV9kb21haW5fY29uZmlnKCkNCj4+PiAtIFJlbW92ZSBJ
U19FTkFCTEVEKENPTkZJR19IQVNfVlBDSSkgZnJvbSBoYXNfdnBjaSgpDQo+Pj4gQ2hhbmdlIGlu
IHYyOg0KPj4+IC0gQWRkIG5ldyBYRU5fRE9NQ1RMX0NERl92cGNpIGZsYWcNCj4+PiAtIG1vZGlm
eSBoYXNfdnBjaSgpIHRvIGluY2x1ZGUgWEVOX0RPTUNUTF9DREZfdnBjaQ0KPj4+IC0gZW5hYmxl
IHZwY2kgc3VwcG9ydCB3aGVuIHBjaS1wYXNzdGhvdWdoIG9wdGlvbiBpcyBlbmFibGVkLg0KPj4+
IC0tLQ0KPj4+IC0tLQ0KPj4+ICAgeGVuL2FyY2gvYXJtL01ha2VmaWxlICAgICAgICAgfCAgIDEg
Kw0KPj4+ICAgeGVuL2FyY2gvYXJtL2RvbWFpbi5jICAgICAgICAgfCAgIDQgKysNCj4+PiAgIHhl
bi9hcmNoL2FybS9kb21haW5fYnVpbGQuYyAgIHwgICAzICsNCj4+PiAgIHhlbi9hcmNoL2FybS92
cGNpLmMgICAgICAgICAgIHwgMTAyICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysN
Cj4+PiAgIHhlbi9hcmNoL2FybS92cGNpLmggICAgICAgICAgIHwgIDM2ICsrKysrKysrKysrKw0K
Pj4+ICAgeGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvcGNpLmMgfCAgMTggKysrKysrDQo+Pj4gICB4
ZW4vaW5jbHVkZS9hc20tYXJtL2RvbWFpbi5oICB8ICAgNyArKy0NCj4+PiAgIHhlbi9pbmNsdWRl
L2FzbS14ODYvcGNpLmggICAgIHwgICAyIC0NCj4+PiAgIHhlbi9pbmNsdWRlL3B1YmxpYy9hcmNo
LWFybS5oIHwgICA3ICsrKw0KPj4+ICAgeGVuL2luY2x1ZGUveGVuL3BjaS5oICAgICAgICAgfCAg
IDIgKw0KPj4+ICAgMTAgZmlsZXMgY2hhbmdlZCwgMTc5IGluc2VydGlvbnMoKyksIDMgZGVsZXRp
b25zKC0pDQo+Pj4gICBjcmVhdGUgbW9kZSAxMDA2NDQgeGVuL2FyY2gvYXJtL3ZwY2kuYw0KPj4+
ICAgY3JlYXRlIG1vZGUgMTAwNjQ0IHhlbi9hcmNoL2FybS92cGNpLmgNCj4+Pg0KPj4+IGRpZmYg
LS1naXQgYS94ZW4vYXJjaC9hcm0vTWFrZWZpbGUgYi94ZW4vYXJjaC9hcm0vTWFrZWZpbGUNCj4+
PiBpbmRleCA0NGQ3Y2M4MWZhLi5mYjljOTc2ZWEyIDEwMDY0NA0KPj4+IC0tLSBhL3hlbi9hcmNo
L2FybS9NYWtlZmlsZQ0KPj4+ICsrKyBiL3hlbi9hcmNoL2FybS9NYWtlZmlsZQ0KPj4+IEBAIC03
LDYgKzcsNyBAQCBpZm5lcSAoJChDT05GSUdfTk9fUExBVCkseSkNCj4+PiAgIG9iai15ICs9IHBs
YXRmb3Jtcy8NCj4+PiAgIGVuZGlmDQo+Pj4gICBvYmotJChDT05GSUdfVEVFKSArPSB0ZWUvDQo+
Pj4gK29iai0kKENPTkZJR19IQVNfVlBDSSkgKz0gdnBjaS5vDQo+Pj4gICANCj4+PiAgIG9iai0k
KENPTkZJR19IQVNfQUxURVJOQVRJVkUpICs9IGFsdGVybmF0aXZlLm8NCj4+PiAgIG9iai15ICs9
IGJvb3RmZHQuaW5pdC5vDQo+Pj4gZGlmZiAtLWdpdCBhL3hlbi9hcmNoL2FybS9kb21haW4uYyBi
L3hlbi9hcmNoL2FybS9kb21haW4uYw0KPj4+IGluZGV4IDM2MTM4YzFiMmUuLmZiYjUyZjc4ZjEg
MTAwNjQ0DQo+Pj4gLS0tIGEveGVuL2FyY2gvYXJtL2RvbWFpbi5jDQo+Pj4gKysrIGIveGVuL2Fy
Y2gvYXJtL2RvbWFpbi5jDQo+Pj4gQEAgLTM5LDYgKzM5LDcgQEANCj4+PiAgICNpbmNsdWRlIDxh
c20vdmdpYy5oPg0KPj4+ICAgI2luY2x1ZGUgPGFzbS92dGltZXIuaD4NCj4+PiAgIA0KPj4+ICsj
aW5jbHVkZSAidnBjaS5oIg0KPj4+ICAgI2luY2x1ZGUgInZ1YXJ0LmgiDQo+Pj4gICANCj4+PiAg
IERFRklORV9QRVJfQ1BVKHN0cnVjdCB2Y3B1ICosIGN1cnJfdmNwdSk7DQo+Pj4gQEAgLTc2Nyw2
ICs3NjgsOSBAQCBpbnQgYXJjaF9kb21haW5fY3JlYXRlKHN0cnVjdCBkb21haW4gKmQsDQo+Pj4g
ICAgICAgaWYgKCBpc19oYXJkd2FyZV9kb21haW4oZCkgJiYgKHJjID0gZG9tYWluX3Z1YXJ0X2lu
aXQoZCkpICkNCj4+PiAgICAgICAgICAgZ290byBmYWlsOw0KPj4+ICAgDQo+Pj4gKyAgICBpZiAo
IChyYyA9IGRvbWFpbl92cGNpX2luaXQoZCkpICE9IDAgKQ0KPj4+ICsgICAgICAgIGdvdG8gZmFp
bDsNCj4+PiArDQo+Pj4gICAgICAgcmV0dXJuIDA7DQo+Pj4gICANCj4+PiAgIGZhaWw6DQo+Pj4g
ZGlmZiAtLWdpdCBhL3hlbi9hcmNoL2FybS9kb21haW5fYnVpbGQuYyBiL3hlbi9hcmNoL2FybS9k
b21haW5fYnVpbGQuYw0KPj4+IGluZGV4IGM1YWZiZTJlMDUuLmY0Yzg5YmRlOGMgMTAwNjQ0DQo+
Pj4gLS0tIGEveGVuL2FyY2gvYXJtL2RvbWFpbl9idWlsZC5jDQo+Pj4gKysrIGIveGVuL2FyY2gv
YXJtL2RvbWFpbl9idWlsZC5jDQo+Pj4gQEAgLTMwNTMsNiArMzA1Myw5IEBAIHZvaWQgX19pbml0
IGNyZWF0ZV9kb20wKHZvaWQpDQo+Pj4gICAgICAgaWYgKCBpb21tdV9lbmFibGVkICkNCj4+PiAg
ICAgICAgICAgZG9tMF9jZmcuZmxhZ3MgfD0gWEVOX0RPTUNUTF9DREZfaW9tbXU7DQo+Pj4gICAN
Cj4+PiArICAgIGlmICggaXNfcGNpX3Bhc3N0aHJvdWdoX2VuYWJsZWQoKSApDQo+Pj4gKyAgICAg
ICAgZG9tMF9jZmcuZmxhZ3MgfD0gWEVOX0RPTUNUTF9DREZfdnBjaTsNCj4+PiArDQo+Pj4gICAg
ICAgZG9tMCA9IGRvbWFpbl9jcmVhdGUoMCwgJmRvbTBfY2ZnLCB0cnVlKTsNCj4+PiAgICAgICBp
ZiAoIElTX0VSUihkb20wKSB8fCAoYWxsb2NfZG9tMF92Y3B1MChkb20wKSA9PSBOVUxMKSApDQo+
Pj4gICAgICAgICAgIHBhbmljKCJFcnJvciBjcmVhdGluZyBkb21haW4gMFxuIik7DQo+Pj4gZGlm
ZiAtLWdpdCBhL3hlbi9hcmNoL2FybS92cGNpLmMgYi94ZW4vYXJjaC9hcm0vdnBjaS5jDQo+Pj4g
bmV3IGZpbGUgbW9kZSAxMDA2NDQNCj4+PiBpbmRleCAwMDAwMDAwMDAwLi43NmMxMmI5MjgxDQo+
Pj4gLS0tIC9kZXYvbnVsbA0KPj4+ICsrKyBiL3hlbi9hcmNoL2FybS92cGNpLmMNCj4+PiBAQCAt
MCwwICsxLDEwMiBAQA0KPj4+ICsvKg0KPj4+ICsgKiB4ZW4vYXJjaC9hcm0vdnBjaS5jDQo+Pj4g
KyAqDQo+Pj4gKyAqIFRoaXMgcHJvZ3JhbSBpcyBmcmVlIHNvZnR3YXJlOyB5b3UgY2FuIHJlZGlz
dHJpYnV0ZSBpdCBhbmQvb3IgbW9kaWZ5DQo+Pj4gKyAqIGl0IHVuZGVyIHRoZSB0ZXJtcyBvZiB0
aGUgR05VIEdlbmVyYWwgUHVibGljIExpY2Vuc2UgYXMgcHVibGlzaGVkIGJ5DQo+Pj4gKyAqIHRo
ZSBGcmVlIFNvZnR3YXJlIEZvdW5kYXRpb247IGVpdGhlciB2ZXJzaW9uIDIgb2YgdGhlIExpY2Vu
c2UsIG9yDQo+Pj4gKyAqIChhdCB5b3VyIG9wdGlvbikgYW55IGxhdGVyIHZlcnNpb24uDQo+Pj4g
KyAqDQo+Pj4gKyAqIFRoaXMgcHJvZ3JhbSBpcyBkaXN0cmlidXRlZCBpbiB0aGUgaG9wZSB0aGF0
IGl0IHdpbGwgYmUgdXNlZnVsLA0KPj4+ICsgKiBidXQgV0lUSE9VVCBBTlkgV0FSUkFOVFk7IHdp
dGhvdXQgZXZlbiB0aGUgaW1wbGllZCB3YXJyYW50eSBvZg0KPj4+ICsgKiBNRVJDSEFOVEFCSUxJ
VFkgb3IgRklUTkVTUyBGT1IgQSBQQVJUSUNVTEFSIFBVUlBPU0UuICBTZWUgdGhlDQo+Pj4gKyAq
IEdOVSBHZW5lcmFsIFB1YmxpYyBMaWNlbnNlIGZvciBtb3JlIGRldGFpbHMuDQo+Pj4gKyAqLw0K
Pj4+ICsjaW5jbHVkZSA8eGVuL3NjaGVkLmg+DQo+Pj4gKw0KPj4+ICsjaW5jbHVkZSA8YXNtL21t
aW8uaD4NCj4+PiArDQo+Pj4gKyNkZWZpbmUgUkVHSVNURVJfT0ZGU0VUKGFkZHIpICAoIChhZGRy
KSAmIDB4MDAwMDBmZmYpDQo+Pj4gKw0KPj4+ICsvKiBEbyBzb21lIHNhbml0eSBjaGVja3MuICov
DQo+Pj4gK3N0YXRpYyBib29sIHZwY2lfbW1pb19hY2Nlc3NfYWxsb3dlZCh1bnNpZ25lZCBpbnQg
cmVnLCB1bnNpZ25lZCBpbnQgbGVuKQ0KPj4+ICt7DQo+Pj4gKyAgICAvKiBDaGVjayBhY2Nlc3Mg
c2l6ZS4gKi8NCj4+PiArICAgIGlmICggbGVuID4gOCApDQo+Pj4gKyAgICAgICAgcmV0dXJuIGZh
bHNlOw0KPj4+ICsNCj4+PiArICAgIC8qIENoZWNrIHRoYXQgYWNjZXNzIGlzIHNpemUgYWxpZ25l
ZC4gKi8NCj4+PiArICAgIGlmICggKHJlZyAmIChsZW4gLSAxKSkgKQ0KPj4+ICsgICAgICAgIHJl
dHVybiBmYWxzZTsNCj4+PiArDQo+Pj4gKyAgICByZXR1cm4gdHJ1ZTsNCj4+PiArfQ0KPj4+ICsN
Cj4+PiArc3RhdGljIGludCB2cGNpX21taW9fcmVhZChzdHJ1Y3QgdmNwdSAqdiwgbW1pb19pbmZv
X3QgKmluZm8sDQo+Pj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgcmVnaXN0ZXJfdCAqciwg
dm9pZCAqcCkNCj4+PiArew0KPj4+ICsgICAgdW5zaWduZWQgaW50IHJlZzsNCj4+PiArICAgIHBj
aV9zYmRmX3Qgc2JkZjsNCj4+PiArICAgIHVuc2lnbmVkIGxvbmcgZGF0YSA9IH4wVUw7DQo+Pj4g
KyAgICB1bnNpZ25lZCBpbnQgc2l6ZSA9IDFVIDw8IGluZm8tPmRhYnQuc2l6ZTsNCj4+PiArDQo+
Pj4gKyAgICBzYmRmLnNiZGYgPSBNTUNGR19CREYoaW5mby0+Z3BhKTsNCj4+PiArICAgIHJlZyA9
IFJFR0lTVEVSX09GRlNFVChpbmZvLT5ncGEpOw0KPj4+ICsNCj4+PiArICAgIGlmICggIXZwY2lf
bW1pb19hY2Nlc3NfYWxsb3dlZChyZWcsIHNpemUpICkNCj4+PiArICAgICAgICByZXR1cm4gMDsN
Cj4+PiArDQo+Pj4gKyAgICBkYXRhID0gdnBjaV9yZWFkKHNiZGYsIHJlZywgbWluKDR1LCBzaXpl
KSk7DQo+Pj4gKyAgICBpZiAoIHNpemUgPT0gOCApDQo+Pj4gKyAgICAgICAgZGF0YSB8PSAodWlu
dDY0X3QpdnBjaV9yZWFkKHNiZGYsIHJlZyArIDQsIDQpIDw8IDMyOw0KPj4+ICsNCj4+PiArICAg
ICpyID0gZGF0YTsNCj4+PiArDQo+Pj4gKyAgICByZXR1cm4gMTsNCj4+PiArfQ0KPj4+ICsNCj4+
PiArc3RhdGljIGludCB2cGNpX21taW9fd3JpdGUoc3RydWN0IHZjcHUgKnYsIG1taW9faW5mb190
ICppbmZvLA0KPj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICByZWdpc3Rlcl90IHIsIHZv
aWQgKnApDQo+Pj4gK3sNCj4+PiArICAgIHVuc2lnbmVkIGludCByZWc7DQo+Pj4gKyAgICBwY2lf
c2JkZl90IHNiZGY7DQo+Pj4gKyAgICB1bnNpZ25lZCBsb25nIGRhdGEgPSByOw0KPj4+ICsgICAg
dW5zaWduZWQgaW50IHNpemUgPSAxVSA8PCBpbmZvLT5kYWJ0LnNpemU7DQo+Pj4gKw0KPj4+ICsg
ICAgc2JkZi5zYmRmID0gTU1DRkdfQkRGKGluZm8tPmdwYSk7DQo+Pj4gKyAgICByZWcgPSBSRUdJ
U1RFUl9PRkZTRVQoaW5mby0+Z3BhKTsNCj4+PiArDQo+Pj4gKyAgICBpZiAoICF2cGNpX21taW9f
YWNjZXNzX2FsbG93ZWQocmVnLCBzaXplKSApDQo+Pj4gKyAgICAgICAgcmV0dXJuIDA7DQo+Pj4g
Kw0KPj4+ICsgICAgdnBjaV93cml0ZShzYmRmLCByZWcsIG1pbig0dSwgc2l6ZSksIGRhdGEpOw0K
Pj4+ICsgICAgaWYgKCBzaXplID09IDggKQ0KPj4+ICsgICAgICAgIHZwY2lfd3JpdGUoc2JkZiwg
cmVnICsgNCwgNCwgZGF0YSA+PiAzMik7DQo+PiBJIHRoaW5rIHRob3NlIHR3byBoZWxwZXJzIChh
bmQgdnBjaV9tbWlvX2FjY2Vzc19hbGxvd2VkKSBhcmUgdmVyeQ0KPj4gc2ltaWxhciB0byB0aGUg
ZXhpc3RpbmcgeDg2IG9uZXMgKHNlZSB2cGNpX21tY2ZnX3tyZWFkLHdyaXRlfSksIHVwIHRvDQo+
PiB0aGUgcG9pbnQgd2hlcmUgSSB3b3VsZCBjb25zaWRlciBtb3ZpbmcgdGhlIHNoYXJlZCBjb2Rl
IHRvIHZwY2kuYyBhcw0KPj4gdnBjaV9lY2FtX3tyZWFkLHdyaXRlfSBhbmQgY2FsbCB0aGVtIGZy
b20gdGhlIGFyY2ggc3BlY2lmaWMgdHJhcA0KPj4gaGFuZGxlcnMuDQo+IEV4Y2VwdCB0aGF0IHBs
ZWFzZSBjYW4gd2Ugc3RpY2sgdG8gbWNmZyBvciBtbWNmZyBpbnN0ZWFkIG9mIGVjYW0NCj4gaW4g
bmFtZXMsIGFzIHRoYXQncyBob3cgdGhlIHRoaW5nIGhhcyBiZWVuIG5hbWVkIGluIFhlbiBmcm9t
IGl0cw0KPiBpbnRyb2R1Y3Rpb24/IEkndmUganVzdCBncmVwLWVkIHRoZSBjb2RlIGJhc2UgKGNh
c2UgaW5zZW5zaXRpdmVseSkNCj4gYW5kIGZvdW5kIG5vIG1lbnRpb24gb2YgRUNBTS4gVGhlcmUg
YXJlIG9ubHkgYSBmZXcgImJlY2FtZSIuDQpJIGRvIHVuZGVyc3RhbmQgdGhhdCB0aGlzIGlzIGhp
c3RvcmljYWxseSB0aGF0IHdlIGRvIG5vdCBoYXZlIEVDQU0gaW4gWGVuLA0KYnV0IFBDSSBpcyBu
b3QgYWJvdXQgWGVuLiBUaHVzLCBJIHRoaW5rIGl0IGlzIGFsc28gYWNjZXB0YWJsZSB0byB1c2UN
CmEgY29tbW9ubHkga25vd24gRUNBTSBmb3IgdGhlIGNvZGUgdGhhdCB3b3JrcyB3aXRoIEVDQU0u
DQpBdCBsZWFzdCBmb3IgdGhlIG5ldyBjb2RlDQo+IEphbg0KPg0KPg0K


From xen-devel-bounces@lists.xenproject.org Wed Oct 13 14:52:26 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 14:52:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.208605.364795 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mafcH-0005nN-Pb; Wed, 13 Oct 2021 14:52:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 208605.364795; Wed, 13 Oct 2021 14:52:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mafcH-0005nG-LB; Wed, 13 Oct 2021 14:52:25 +0000
Received: by outflank-mailman (input) for mailman id 208605;
 Wed, 13 Oct 2021 14:52:24 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Kt2p=PB=arm.com=luca.fancellu@srs-us1.protection.inumbo.net>)
 id 1mafcG-0005n4-Rv
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 14:52:24 +0000
Received: from foss.arm.com (unknown [217.140.110.172])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTP
 id df58f88a-674a-4e9c-870f-c1e3967f021c;
 Wed, 13 Oct 2021 14:52:23 +0000 (UTC)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 76BC5D6E;
 Wed, 13 Oct 2021 07:52:23 -0700 (PDT)
Received: from e125770.cambridge.arm.com (e125770.cambridge.arm.com
 [10.1.195.16])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 915683F694;
 Wed, 13 Oct 2021 07:52:22 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: df58f88a-674a-4e9c-870f-c1e3967f021c
From: Luca Fancellu <luca.fancellu@arm.com>
To: xen-devel@lists.xenproject.org
Cc: bertrand.marquis@arm.com,
	wei.chen@arm.com,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: [PATCH v2] arm/docs: Clarify legacy DT bindings on UEFI
Date: Wed, 13 Oct 2021 15:52:02 +0100
Message-Id: <20211013145202.53070-1-luca.fancellu@arm.com>
X-Mailer: git-send-email 2.17.1
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Since the introduction of UEFI boot for Xen, the legacy
compatible strings were not supported and the stub code
was checking only the presence of “multiboot,module” to
require the Xen UEFI configuration file or not.
The documentation was not updated to specify that behavior.

Add a phrase to docs/misc/arm/device-tree/booting.txt
to clarify it.

Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>
Acked-by: Julien Grall <jgrall@amazon.com>
---
Changes in v2:
- dropped redundant wording in docs/misc/arm/device-tree/booting.txt
- Add more details to the commit message
---
 docs/misc/arm/device-tree/booting.txt | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/docs/misc/arm/device-tree/booting.txt b/docs/misc/arm/device-tree/booting.txt
index c6a775f4e8..71895663a4 100644
--- a/docs/misc/arm/device-tree/booting.txt
+++ b/docs/misc/arm/device-tree/booting.txt
@@ -51,6 +51,8 @@ Each node contains the following properties:
 	Xen 4.4 supported a different set of legacy compatible strings
 	which remain supported such that systems supporting both 4.4
 	and later can use a single DTB.
+	However when booting Xen using UEFI, the legacy compatible
+	strings are not supported.
 
 	- "xen,multiboot-module" equivalent to "multiboot,module"
 	- "xen,linux-zimage"     equivalent to "multiboot,kernel"
-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Wed Oct 13 15:05:56 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 15:05:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.208614.364805 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mafpG-0007Qi-Us; Wed, 13 Oct 2021 15:05:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 208614.364805; Wed, 13 Oct 2021 15:05:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mafpG-0007Qb-Rv; Wed, 13 Oct 2021 15:05:50 +0000
Received: by outflank-mailman (input) for mailman id 208614;
 Wed, 13 Oct 2021 15:05:50 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=dUCo=PB=gmail.com=olekstysh@srs-us1.protection.inumbo.net>)
 id 1mafpG-0007QV-5b
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 15:05:50 +0000
Received: from mail-wr1-x42d.google.com (unknown [2a00:1450:4864:20::42d])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 03b2cd67-4eae-486f-a546-a264529d4ed5;
 Wed, 13 Oct 2021 15:05:49 +0000 (UTC)
Received: by mail-wr1-x42d.google.com with SMTP id u18so9511437wrg.5
 for <xen-devel@lists.xenproject.org>; Wed, 13 Oct 2021 08:05:49 -0700 (PDT)
Received: from [192.168.1.7] ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id m36sm6529717wms.6.2021.10.13.08.05.46
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Wed, 13 Oct 2021 08:05:47 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 03b2cd67-4eae-486f-a546-a264529d4ed5
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-transfer-encoding:content-language;
        bh=zJOBhlYMSYleHwtQe85+9w/XLjPZ59ZgHkB5p8AjHqg=;
        b=PB5gou64VDJEdNOHBLPaZXOtqYju7+eXNThBxQk8E+mWakLVSTvLcMqPXUBFfQe/Sg
         c45ABIKKrWnOl/KcjkwmMIFENi8VlvKfrjie5uUXrQcK4nWadENyYM17PGZLvsGBf7Rn
         RGqAHF/oVjLPH+odzy8t7KX+gEcBDic1e1DRrF0ppxByuW9N6TivoMqd3yMe8KCnVfCQ
         k4ZUiEo/0a/zG87mu5p7j5deHE73yugJroywCc3vruJ5irn4cK/dLgZRjRenlW0eFqjW
         sTP1I+E0Zs4b/MVZu5Qbs0oIK7s4D1owYxnoJjcD3ZZKgVwv3v5BwlZzxXeI650OGITh
         cUEw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding
         :content-language;
        bh=zJOBhlYMSYleHwtQe85+9w/XLjPZ59ZgHkB5p8AjHqg=;
        b=r8ThM7P7Ap2jtHaLrKBtWXn58Wb0t/3Xob83XPA4pasFvnC+0zVhMXC+/WDx5kBHw7
         uwkfQoh3k9HhZKSFVO6gwmvOJZ8gOOzl+Jehn8ru4B7wS2id6L7PVobRu7wqFP5UGFx1
         pUCgNz1sQJk0R6+L0GKbBUZFIwx57zg1opWvt+Qol6t+7xRqrQJb6mO/x52OExbegiB4
         LDKK/INIQP50tcR0EvAIHyMxHB46+4BzSQ0W9u2JGbmmSqdHUNVumSgb8jq0E4OBeZ1k
         Fu1JFiOOQSashd6DwnV9W5GgY6YcnzGaPwdcx9DfywFQc00pvTcEx+1LgNHLIq6MsdbM
         zQ1Q==
X-Gm-Message-State: AOAM531Tm+eBLrfguzZ3FN7K86W9r8qZ4uugT7R00W3kzadcKB8vygS+
	0UZRxgsgLCovIlFTUWgMSRQ=
X-Google-Smtp-Source: ABdhPJwXaayRM6TCF7lUuU37k/KPj6vRiL4BML/ay5d+FJaoibNyrgaKMxOUYjgNWm+aApMqktrSrw==
X-Received: by 2002:a5d:59a3:: with SMTP id p3mr7552165wrr.146.1634137548128;
        Wed, 13 Oct 2021 08:05:48 -0700 (PDT)
Subject: Re: [PATCH V6 1/2] xen/arm: Introduce gpaddr_bits field to struct
 xen_domctl_getdomaininfo
To: Jan Beulich <jbeulich@suse.com>
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>,
 Anthony PERARD <anthony.perard@citrix.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Juergen Gross
 <jgross@suse.com>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 xen-devel@lists.xenproject.org, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>
References: <9e6e1378-7ee3-b692-b57d-29b597160661@gmail.com>
 <1634073720-27901-1-git-send-email-olekstysh@gmail.com>
 <f9b8b55b-cfe4-2bfa-44db-e898800def72@suse.com>
From: Oleksandr <olekstysh@gmail.com>
Message-ID: <f51ec1a9-f265-cd18-792b-017224b8667c@gmail.com>
Date: Wed, 13 Oct 2021 18:05:46 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <f9b8b55b-cfe4-2bfa-44db-e898800def72@suse.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US


On 13.10.21 16:56, Jan Beulich wrote:

Hi Jan

> On 12.10.2021 23:22, Oleksandr Tyshchenko wrote:
>> @@ -95,7 +95,7 @@ void getdomaininfo(struct domain *d, struct xen_domctl_getdomaininfo *info)
>>   
>>       info->cpu_time = cpu_time;
>>   
>> -    info->flags = (info->nr_online_vcpus ? flags : 0) |
>> +    info->flags |= (info->nr_online_vcpus ? flags : 0) |
>>           ((d->is_dying == DOMDYING_dead) ? XEN_DOMINF_dying     : 0) |
>>           (d->is_shut_down                ? XEN_DOMINF_shutdown  : 0) |
>>           (d->controller_pause_count > 0  ? XEN_DOMINF_paused    : 0) |
> I don't think this is a useful change - you move from a simple write
> to a read-modify-write operation. With this dropped again, hypervisor
> parts:
> Reviewed-by: Jan Beulich <jbeulich@suse.com>

Thanks!

Will drop.


>
> While this has meanwhile moved quite far from the original proposal,
> I still wonder in how far Andrew may have remaining concerns. Did
> you check with him, perhaps on irc?
> But of course catching his
> attention may be difficult, so no (further) feedback by him should
> probably not keep this from getting committed (if no other open
> issues remain).

If I remember correctly, I made several attempts to clarify in the 
initial thread. But, I have to admit, not via IRC (I am expecting some 
troubles with my IRC client last time and I haven't figured out yet 
why). Of course, it would be correct to get a feedback to make sure that 
there would be no remaining concerns (as the main concern to use domctl 
was addressed) or otherwise.


>
> Jan
>
-- 
Regards,

Oleksandr Tyshchenko



From xen-devel-bounces@lists.xenproject.org Wed Oct 13 15:15:23 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 15:15:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.208623.364817 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mafyH-0000Tk-V8; Wed, 13 Oct 2021 15:15:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 208623.364817; Wed, 13 Oct 2021 15:15:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mafyH-0000Td-QD; Wed, 13 Oct 2021 15:15:09 +0000
Received: by outflank-mailman (input) for mailman id 208623;
 Wed, 13 Oct 2021 15:15:09 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mafyG-0000Sm-Sk
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 15:15:09 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mafyF-0007cE-17; Wed, 13 Oct 2021 15:15:07 +0000
Received: from 54-240-197-234.amazon.com ([54.240.197.234]
 helo=[192.168.17.188]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mafyE-0001Pl-Qb; Wed, 13 Oct 2021 15:15:06 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=p0NTIthwzg4fLyeSq/oiRRGmFQWHTU3rVQ40+G/ZVbo=; b=nyLOCgUwdX0G34o9+k9VOhyy8W
	zT2JoSyRSgWU+aM0tDjW5Vz8S/KHg3mUiUDull1/tsCCivnMgJp3BHkWAImdKxhimsZJ1PuJPWPLx
	a8bR1WmkLrzyvNK/mqirOKfTY2HCV8+4z/RR14VkcLQx7XzByrLVXqRJdW6YKCvTZCSs=;
Message-ID: <d076afcc-5fde-e83e-1632-371406bdd387@xen.org>
Date: Wed, 13 Oct 2021 16:15:03 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.2.0
Subject: Re: [PATCH V6 2/2] libxl/arm: Add handling of extended regions for
 DomU
To: Oleksandr <olekstysh@gmail.com>
Cc: Ian Jackson <iwj@xenproject.org>, xen-devel@lists.xenproject.org,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, Wei Liu <wl@xen.org>,
 Anthony PERARD <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <1633974539-7380-1-git-send-email-olekstysh@gmail.com>
 <1633974539-7380-3-git-send-email-olekstysh@gmail.com>
 <c98c1acd-86c0-f556-643e-e472b696644f@xen.org>
 <51f9154f-3b65-c7c0-cd93-cecdc2a0975e@gmail.com>
 <641173d4-2629-e4b6-d4ec-06bd629141cc@xen.org>
 <acc06366-b381-daa0-8e2a-54c2761019af@gmail.com>
 <dea074a1-fad2-9b25-5b44-8de23eee83d7@gmail.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <dea074a1-fad2-9b25-5b44-8de23eee83d7@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

On 13/10/2021 14:46, Oleksandr wrote:
> 
> Hi Julien

Hi Oleksandr,

> On 13.10.21 00:43, Oleksandr wrote:
> diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c
> index e3140a6..53ae0f3 100644
> --- a/tools/libs/light/libxl_arm.c
> +++ b/tools/libs/light/libxl_arm.c
> @@ -615,9 +615,12 @@ static int make_hypervisor_node(libxl__gc *gc, void 
> *fdt,
>                                 "xen,xen");
>       if (res) return res;
> 
> -    /* reg 0 is grant table space */
> +    /*
> +     * reg 0 is a placeholder for grant table space, reg 1...N are
> +     * the placeholders for extended regions.
> +     */
>       res = fdt_property_regs(gc, fdt, GUEST_ROOT_ADDRESS_CELLS, 
> GUEST_ROOT_SIZE_CELLS,
> -                            1,GUEST_GNTTAB_BASE, GUEST_GNTTAB_SIZE);
> +                            GUEST_RAM_BANKS + 1, 0, 0, 0, 0, 0, 0);

Here you are relying on GUEST_RAM_BANKS == 2. I think this is pretty 
fragile as this may change in the future.

fdt_property_regs() is not really suitable for here. I would suggest to 
create a new helper fdt_property_placeholder() which takes the address 
cells, size cells and the number of ranges. The function will then 
create N range that are zeroed.

>       if (res) return res;
> 
>       /*
> @@ -1069,6 +1072,74 @@ static void finalise_one_node(libxl__gc *gc, void 
> *fdt, const char *uname,
>       }
>   }
> 
> +#define ALIGN_UP_TO_2MB(x)   (((x) + MB(2) - 1) & (~(MB(2) - 1)))
> +
> +static void finalise_ext_region(libxl__gc *gc, struct xc_dom_image *dom)

The function is doing more than finalizing extend regions, it also 
create the grant table regs. So how about naming it: 
finalize_hypervisor_node()?

> +{
> +    void *fdt = dom->devicetree_blob;
> +    uint64_t region_size[GUEST_RAM_BANKS] = {0}, 
> region_base[GUEST_RAM_BANKS],
> +        bankend[GUEST_RAM_BANKS];
> +    uint32_t regs[(GUEST_ROOT_ADDRESS_CELLS + GUEST_ROOT_SIZE_CELLS) *
> +                  (GUEST_RAM_BANKS + 1)];
> +    be32 *cells = &regs[0];
> +    const uint64_t bankbase[] = GUEST_RAM_BANK_BASES;
> +    const uint64_t banksize[] = GUEST_RAM_BANK_SIZES;
> +    unsigned int i, len, nr_regions = 0;
> +    libxl_dominfo info;
> +    int offset, rc;
> +
> +    offset = fdt_path_offset(fdt, "/hypervisor");
> +    assert(offset > 0);
> +
> +    rc = libxl_domain_info(CTX, &info, dom->guest_domid);
> +    assert(!rc);
> +
> +    assert(info.gpaddr_bits <= 64);

Neither of the two should be assert(). They should be proper check so we 
don't end up with a disaster (in particularly for the former) if there 
is a problem.

> +
> +    /*
> +     * Try to allocate separate 2MB-aligned extended regions from the 
> first
> +     * and second RAM banks taking into the account the maximum supported
> +     * guest physical address space size and the amount of memory assigned
> +     * to the guest.
> +     */
> +    for (i = 0; i < GUEST_RAM_BANKS; i++) {
> +        region_base[i] = bankbase[i] +
> +            ALIGN_UP_TO_2MB((uint64_t)dom->rambank_size[i] << 
> XC_PAGE_SHIFT);
> +
> +        bankend[i] = ~0ULL >> (64 - info.gpaddr_bits);
> +        bankend[i] = min(bankend[i], bankbase[i] + banksize[i] - 1);
> +        if (bankend[i] > region_base[i])
> +            region_size[i] = bankend[i] - region_base[i] + 1;
> +    } > +
> +    /*
> +     * The region 0 for grant table space must be always present. If we 
> managed
> +     * to allocate the extended regions then insert them as regions 1...N.
> +     */
> +    set_range(&cells, GUEST_ROOT_ADDRESS_CELLS, GUEST_ROOT_SIZE_CELLS,
> +              GUEST_GNTTAB_BASE, GUEST_GNTTAB_SIZE);
> +
> +    for (i = 0; i < GUEST_RAM_BANKS; i++) {
> +        if (region_size[i] < GUEST_EXT_REGION_MIN_SIZE)
> +            continue;
> +
> +        LOG(DEBUG, "Extended region %u: %#"PRIx64"->%#"PRIx64"",
> +            nr_regions, region_base[i], region_base[i] + region_size[i]);
> +
> +        set_range(&cells, GUEST_ROOT_ADDRESS_CELLS, GUEST_ROOT_SIZE_CELLS,
> +                  region_base[i], region_size[i]);
> +        nr_regions++;
> +    }
> +
> +    if (!nr_regions)
> +        LOG(WARN, "The extended regions cannot be allocated, not enough 
> space");
> +
> +    len = sizeof(regs[0]) * (GUEST_ROOT_ADDRESS_CELLS + 
> GUEST_ROOT_SIZE_CELLS) *
> +        (nr_regions + 1);
> +    rc = fdt_setprop(fdt, offset, "reg", regs, len);
> +    assert(!rc);

We should propagate the error.

> +}
> +
>   int libxl__arch_domain_finalise_hw_description(libxl__gc *gc,
>                                                  uint32_t domid,
> libxl_domain_config *d_config,
> @@ -1109,6 +1180,8 @@ int 
> libxl__arch_domain_finalise_hw_description(libxl__gc *gc,
> 
>       }
> 
> +    finalise_ext_region(gc, dom);
> +
>       for (i = 0; i < GUEST_RAM_BANKS; i++) {
>           const uint64_t size = (uint64_t)dom->rambank_size[i] << 
> XC_PAGE_SHIFT;
> 
> diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h
> index d46c61f..7425a78 100644
> --- a/xen/include/public/arch-arm.h
> +++ b/xen/include/public/arch-arm.h
> @@ -438,6 +438,11 @@ typedef uint64_t xen_callback_t;
> 
>   #define GUEST_RAM_BANKS   2
> 
> +/*
> + * The way to find the extended regions (to be exposed to the guest as 
> unused
> + * address space) relies on the fact that the regions reserved for the RAM
> + * below are big enough to also accommodate such regions.
> + */
>   #define GUEST_RAM0_BASE   xen_mk_ullong(0x40000000) /* 3GB of low RAM 
> @ 1GB */
>   #define GUEST_RAM0_SIZE   xen_mk_ullong(0xc0000000)
> 
> @@ -451,6 +456,8 @@ typedef uint64_t xen_callback_t;
>   #define GUEST_RAM_BANK_BASES   { GUEST_RAM0_BASE, GUEST_RAM1_BASE }
>   #define GUEST_RAM_BANK_SIZES   { GUEST_RAM0_SIZE, GUEST_RAM1_SIZE }
> 
> +#define GUEST_EXT_REGION_MIN_SIZE   xen_mk_ullong(0x0004000000) /* 64MB */

I would prefer if this value is not part of the public header because 
this is not a value that the hypervisor needs to know. So it is better 
to restrict it to the libxl_arm.c

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Oct 13 15:16:06 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 15:16:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.208628.364828 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mafzB-00011q-7S; Wed, 13 Oct 2021 15:16:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 208628.364828; Wed, 13 Oct 2021 15:16:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mafzB-00011j-3b; Wed, 13 Oct 2021 15:16:05 +0000
Received: by outflank-mailman (input) for mailman id 208628;
 Wed, 13 Oct 2021 15:16:03 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=bU9L=PB=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mafz9-00011S-El
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 15:16:03 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 5c055cbf-3f3a-4337-b4cc-3f6583754b92;
 Wed, 13 Oct 2021 15:16:02 +0000 (UTC)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2111.outbound.protection.outlook.com [104.47.18.111])
 (Using TLS) by relay.mimecast.com with ESMTP id
 de-mta-38--hVHb6j9Pvuoe63MsEgpzg-1; Wed, 13 Oct 2021 17:16:00 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB5744.eurprd04.prod.outlook.com (2603:10a6:803:e4::24)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.19; Wed, 13 Oct
 2021 15:15:58 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.016; Wed, 13 Oct 2021
 15:15:58 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS8PR04CA0058.eurprd04.prod.outlook.com (2603:10a6:20b:312::33) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.14 via Frontend
 Transport; Wed, 13 Oct 2021 15:15:57 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5c055cbf-3f3a-4337-b4cc-3f6583754b92
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634138161;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=m9Bk3hyQ6WFv8b7AKpENlbOMGd3Xcuist44c9GqXli0=;
	b=FjpzwHdsQrfEaFB9UkIyXhtKBrooWGzNMLloT8sc21VoXLRx8GZDdBHrluYXCHYIPTgrOT
	HRlPqc9FZxD8BVTlpi987SWrY3KmLm6RQQqw1WHQyAAeEDx7hvZtVgRLSfB/I/lCaWtblV
	y26mWwflE+LNMJovBRydMzjVv0KBhSY=
X-MC-Unique: -hVHb6j9Pvuoe63MsEgpzg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=LddIhw9tVGrhiRL9WT9JQm/cgZO1v2pUvFKUgBQaiwQHsGAQ7s8L+YtsfooB4TAIPKkFBS+C6WfvjLfuj1xIcCJ5EpyWXK1rx7YkGHZaJ80LHME/xiH/VC5Y0AchzlYWnanfIQwutZ0KUEqIgmr6ovJVi35lQo3BXXxPVEq84ZLcBnPKpbym6qHCdcCkIZRZmdORHfejeom0kD7mR/VUZ3aV8gA+OktUTAm+OJB4oju6p4pd/EMinui3Exsk8hHop2HHJd8W5hRIMPPy1oqRAbk37K45adpUdwI2IG3EF0oO8azg186cm+sui76m+bibJEOfNlK2CaV2I6V/4DCE6w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ChPBkOokExfNpSi4eQBrlEMriU6D8fnaAJGFLqliShY=;
 b=JudbGF+KKpKHjbciWzh1rZfTD546IhHhbtud36r25cvl1TblL0iCTizFQUrHz8I7n1hNaYbLeulIFEIJYbb9ULDhoNH0y/YSzTjm5bwm1ttBwqhEPkuMBfLlqj7hzZDI/dCLrXAa7AHxqf+4jH2t05WJVaAylsSftOVffzhpEMTNd2WsvMLstFuvUFvyvcXET3d6Sey4m9RXF93U2ejJg/Mt7PPE+Z0D6oVMD77L96dmzzHCpZtpEOafNayYMnGO5OiRq3uyi1rmlcdyd6Ob8wKHRU8pZV82oArZw3dP+kG2DC7lKou5dc9Gasp3hnpbbHLn5zPzWQ3wraGrhEegoQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: citrix.com; dkim=none (message not signed)
 header.d=none;citrix.com; dmarc=none action=none header.from=suse.com;
Subject: Re: [PATCH v5 08/11] xen/arm: Enable the existing x86 virtual PCI
 support for ARM.
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 "Andre.Przywara@arm.com" <Andre.Przywara@arm.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Rahul Singh
 <rahul.singh@arm.com>, George Dunlap <george.dunlap@citrix.com>,
 Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>,
 Paul Durrant <paul@xen.org>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>
References: <cover.1633540842.git.rahul.singh@arm.com>
 <9bdca2cda5d2e83f94dc2423e55714273539760a.1633540842.git.rahul.singh@arm.com>
 <YWaco/UvA4xFE1xW@MacBook-Air-de-Roger.local>
 <6d75f604-6938-b185-61e1-a6684d9fca14@suse.com>
 <2b943774-072e-20a1-b97c-d88b24adf340@epam.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <ed4876ca-7384-42a8-6fba-e73c1840402a@suse.com>
Date: Wed, 13 Oct 2021 17:15:55 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <2b943774-072e-20a1-b97c-d88b24adf340@epam.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS8PR04CA0058.eurprd04.prod.outlook.com
 (2603:10a6:20b:312::33) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: da8ee173-008f-497e-f000-08d98e5c5c09
X-MS-TrafficTypeDiagnostic: VI1PR04MB5744:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB5744E712FC7F1145D264E1C0B3B79@VI1PR04MB5744.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	NJsZJvVEp4s60IRVc1yxqzhjdLc0CCnBn9XfDXGkTc3VHOJWyQF3t7wup4k7iTQ/7z4gN7ghY9yRoc4KiI/wS++n/L+zW7jqx9iD2GzXg2mQE+T3R6j9fg+gy9TPo+mQ0RgOnQb39cOKJnx9sRmLN9c8RXFZlIJGqWIBq2ONz6HCng4Dk++YDym16Kvl2zUfkNztvFVvx2Xjbm0GzkDWOHJiLHwmCrrMDIcJ6HH7m4cZf58iyXrZHgBspv1RKJysRAsIYXlucHOSrkEV58B8vIe+hmLDRw7MQEbLG7vQRRhhdGvLluo/OqhSLyo+UwBFJpExwRRdew1lImEL70Aehh+AIukAuuSZJU8zZbnMtXl+hVOHdJign3t5XZCIwgu54Y474HJx304+4wUFzEM27gSgkGK4t2BoDUS+7w7nemBZatjNVThGSN+YVsBVxK7mulRASGCylygO59/lXOp5SfLOZVJ72Sl5USpGSTOIcpCN5YbxawONIVQkXTShBtCn6bHVLoRNtj8mmnX6EFtbxtI3+7lCVSmjjpN8icMpe7sxJHVeee1n7O7IJJcAEEzt42aW/XmYPJepgJGkOAzhi4Gtu4JUicqv0Yy0bunCe17AKhMWGX1cfjoJHxFz2T6x5a2ONUSOp5EC14PPdvhveXja5Scx8rAaAP4y/re7H+5ZEl+N2q15eqZWXBs9TQMmPS7LwzGy8zJUJ+dZre1JbtKvCc9ZqvsKLyJX5EqbdKd6P5rV8sz+BXYIZuGFVHPN
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(53546011)(83380400001)(8936002)(7416002)(26005)(31696002)(2616005)(956004)(54906003)(8676002)(31686004)(6916009)(4326008)(16576012)(316002)(508600001)(5660300002)(186003)(66476007)(2906002)(86362001)(66556008)(6486002)(36756003)(38100700002)(66946007)(2004002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?ijOj/CfqGBInFAZ1zB8w69MCRrBbDXfmTiymeoqR1RiYx0HTLX6u8y7tfNsj?=
 =?us-ascii?Q?u8J6UBvIxkdi/o5HYor3MT2aP42SYu79VX6uv0fktK9Pw2O1Ydiy64HbXlmg?=
 =?us-ascii?Q?3C6j0irtca0kmTFMgcrcA2L4ieWOceOiFGyu/kVZ4sAYaPuG/mVEDUZIUyan?=
 =?us-ascii?Q?EdwSYzP3Tkuk3TNK/yn7PBYgyNiGFJIwoZYBKHvngPyM3XlAB3l7hCPPWLzk?=
 =?us-ascii?Q?6wQK/hwDw3+M2UEBrpKf/LcZ5H0Kuzy6N1vEGo+yEqqbiPoN/ZkQbcNcZloG?=
 =?us-ascii?Q?QMZzqgle9fbdAWAIQ8CWOLxeu7egOHz0eZiwFTV5oGtHLgV+xa4JHXQVxLS7?=
 =?us-ascii?Q?kR1H4nXsUF0+lf7IzU4iRzjPNqXQo9osUvTIA4nEzWUlxRAXF8QgajIiZzeQ?=
 =?us-ascii?Q?ipY78kWiMYS+h3VF0ccQDoS4W4JFmOwrYwsdMrGn/8CttPvSKBZ2IOfT9YpE?=
 =?us-ascii?Q?iVapS9wilmth5gJMvdFWqwIN+jBMIv0T0t7vjQT+6LtxrOf3+QY7zaQ6Qi/m?=
 =?us-ascii?Q?gilw5UHz1E/CiZaWwX0sscX3Vx3Ts+3vLouvEkDHiXz1Q4N3ecvfdSZCiB2u?=
 =?us-ascii?Q?iGxIOemiH1yzAwBoRkM52rycJsKu7ulN83Uylpa+QW7YHODnLdrJ8o/CUYr9?=
 =?us-ascii?Q?0hfsCjK5dgNBSoREuJJsdo9vvGNzazNN+SVl9L88g8EBfAEFULKAWXhN0VIP?=
 =?us-ascii?Q?xFrCUbgZN1d2sX9NKILJbIDO1ROfXYw1FUUA88QtMZ0wMjG9db4RGfUzrkxV?=
 =?us-ascii?Q?R07UaAtwQB3w46Hv050dXweXH7eBa2IFaUzfJuIqAi9JjbO6arheR2Gh9eTX?=
 =?us-ascii?Q?gmBIyTkT1Gxqk03dFoUqBQ3pehGD3zREcqaGqIUx27xEP4RRGE44emOkmPmc?=
 =?us-ascii?Q?ElueIAw0WLzLygaUbF3cJDtS470QVnFVg+xQ0Lu0lv5qcO/RAzMK4vd4Q2FS?=
 =?us-ascii?Q?59zhrow6xPNAg9QtBaqhw2jDVTerbhcS7cUjJdvy8sy4rHKjaDyfrK5iKETH?=
 =?us-ascii?Q?wUPoCjY8C1Nn7OvaiHKX/m82rUH3roYIP51l3PRfcN00WeCZNJgmYEMvpuoz?=
 =?us-ascii?Q?JibnURJjRYQGQ0Q9wwKsyBfT1dGSE87hyeD/H8ZkBdw3xUjaYO+9zt5Ct/HL?=
 =?us-ascii?Q?ggW3zYvYml9wHTgfFbXQFr2y0SDDRfrrNP5weU+DpCGvro+eIY0fPiyEeNRN?=
 =?us-ascii?Q?AvQuDnPVo5oAOAXSf+s8qniNjRgZMsGt8UnDeI14vZTO+e2Ok9AYBOkOJIwR?=
 =?us-ascii?Q?7eiPA2/SOlLgBi+h4GdblZNxTP0Li/k14XILOl7PJ7iaV4VFI6Eh9uC9vrsA?=
 =?us-ascii?Q?Vja6st+qI+yTVM24rRhs8uVz?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: da8ee173-008f-497e-f000-08d98e5c5c09
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2021 15:15:58.2845
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: BPmR8Bja5rU8eYcFk4KGPkORo+M4xdcjxkOgfSdIxSRq+eAQR9rwB4GJe1KfU6U+EplHFgsZoJyTNfKefmX7KA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5744

On 13.10.2021 16:51, Oleksandr Andrushchenko wrote:
> On 13.10.21 16:00, Jan Beulich wrote:
>> On 13.10.2021 10:45, Roger Pau Monn=C3=A9 wrote:
>>> On Wed, Oct 06, 2021 at 06:40:34PM +0100, Rahul Singh wrote:
>>>> --- /dev/null
>>>> +++ b/xen/arch/arm/vpci.c
>>>> @@ -0,0 +1,102 @@
>>>> +/*
>>>> + * xen/arch/arm/vpci.c
>>>> + *
>>>> + * This program is free software; you can redistribute it and/or modi=
fy
>>>> + * it under the terms of the GNU General Public License as published =
by
>>>> + * the Free Software Foundation; either version 2 of the License, or
>>>> + * (at your option) any later version.
>>>> + *
>>>> + * This program is distributed in the hope that it will be useful,
>>>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
>>>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>>>> + * GNU General Public License for more details.
>>>> + */
>>>> +#include <xen/sched.h>
>>>> +
>>>> +#include <asm/mmio.h>
>>>> +
>>>> +#define REGISTER_OFFSET(addr)  ( (addr) & 0x00000fff)
>>>> +
>>>> +/* Do some sanity checks. */
>>>> +static bool vpci_mmio_access_allowed(unsigned int reg, unsigned int l=
en)
>>>> +{
>>>> +    /* Check access size. */
>>>> +    if ( len > 8 )
>>>> +        return false;
>>>> +
>>>> +    /* Check that access is size aligned. */
>>>> +    if ( (reg & (len - 1)) )
>>>> +        return false;
>>>> +
>>>> +    return true;
>>>> +}
>>>> +
>>>> +static int vpci_mmio_read(struct vcpu *v, mmio_info_t *info,
>>>> +                          register_t *r, void *p)
>>>> +{
>>>> +    unsigned int reg;
>>>> +    pci_sbdf_t sbdf;
>>>> +    unsigned long data =3D ~0UL;
>>>> +    unsigned int size =3D 1U << info->dabt.size;
>>>> +
>>>> +    sbdf.sbdf =3D MMCFG_BDF(info->gpa);
>>>> +    reg =3D REGISTER_OFFSET(info->gpa);
>>>> +
>>>> +    if ( !vpci_mmio_access_allowed(reg, size) )
>>>> +        return 0;
>>>> +
>>>> +    data =3D vpci_read(sbdf, reg, min(4u, size));
>>>> +    if ( size =3D=3D 8 )
>>>> +        data |=3D (uint64_t)vpci_read(sbdf, reg + 4, 4) << 32;
>>>> +
>>>> +    *r =3D data;
>>>> +
>>>> +    return 1;
>>>> +}
>>>> +
>>>> +static int vpci_mmio_write(struct vcpu *v, mmio_info_t *info,
>>>> +                           register_t r, void *p)
>>>> +{
>>>> +    unsigned int reg;
>>>> +    pci_sbdf_t sbdf;
>>>> +    unsigned long data =3D r;
>>>> +    unsigned int size =3D 1U << info->dabt.size;
>>>> +
>>>> +    sbdf.sbdf =3D MMCFG_BDF(info->gpa);
>>>> +    reg =3D REGISTER_OFFSET(info->gpa);
>>>> +
>>>> +    if ( !vpci_mmio_access_allowed(reg, size) )
>>>> +        return 0;
>>>> +
>>>> +    vpci_write(sbdf, reg, min(4u, size), data);
>>>> +    if ( size =3D=3D 8 )
>>>> +        vpci_write(sbdf, reg + 4, 4, data >> 32);
>>> I think those two helpers (and vpci_mmio_access_allowed) are very
>>> similar to the existing x86 ones (see vpci_mmcfg_{read,write}), up to
>>> the point where I would consider moving the shared code to vpci.c as
>>> vpci_ecam_{read,write} and call them from the arch specific trap
>>> handlers.
>> Except that please can we stick to mcfg or mmcfg instead of ecam
>> in names, as that's how the thing has been named in Xen from its
>> introduction? I've just grep-ed the code base (case insensitively)
>> and found no mention of ECAM. There are only a few "became".
> I do understand that this is historically that we do not have ECAM in Xen=
,
> but PCI is not about Xen. Thus, I think it is also acceptable to use
> a commonly known ECAM for the code that works with ECAM.

ACPI, afaik, also doesn't call this ECAM. That's where MCFG / MMCFG
actually come from, I believe.

Jan



From xen-devel-bounces@lists.xenproject.org Wed Oct 13 15:17:56 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 15:17:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.208637.364838 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mag0x-0001k1-OA; Wed, 13 Oct 2021 15:17:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 208637.364838; Wed, 13 Oct 2021 15:17:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mag0x-0001ju-Ky; Wed, 13 Oct 2021 15:17:55 +0000
Received: by outflank-mailman (input) for mailman id 208637;
 Wed, 13 Oct 2021 15:17:55 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mag0x-0001jm-6G
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 15:17:55 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mag0u-0007gu-LL; Wed, 13 Oct 2021 15:17:52 +0000
Received: from 54-240-197-234.amazon.com ([54.240.197.234]
 helo=[192.168.17.188]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mag0u-0001X8-Ef; Wed, 13 Oct 2021 15:17:52 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=8J/91wewnMA2Y3fyhWSALq6PmEYIGfgdYNGNAeemffs=; b=wgKQTkPyPTz4VFIClYFp3a6OR9
	LkSBkCSy8VOE/25kROMCzE4Wx19gk2I6Qg3BOEEK4BI9gqSKFUAVrYtdCdl20ZZ7Ey992OaGCoYjM
	yfcMGPg4E2Lfs4kMUMhz4Kh3WnV+/f36OYg7wVKTqDLMhYZHOpMChFq6Bwi+AnkDYGHs=;
Message-ID: <e614a4a4-ec65-1bbc-4e25-c838b9ebeeb8@xen.org>
Date: Wed, 13 Oct 2021 16:17:49 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.2.0
Subject: Re: [PATCH V6 1/2] xen/arm: Introduce gpaddr_bits field to struct
 xen_domctl_getdomaininfo
To: Oleksandr <olekstysh@gmail.com>, Jan Beulich <jbeulich@suse.com>
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>,
 Anthony PERARD <anthony.perard@citrix.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Juergen Gross
 <jgross@suse.com>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 xen-devel@lists.xenproject.org, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>
References: <9e6e1378-7ee3-b692-b57d-29b597160661@gmail.com>
 <1634073720-27901-1-git-send-email-olekstysh@gmail.com>
 <f9b8b55b-cfe4-2bfa-44db-e898800def72@suse.com>
 <f51ec1a9-f265-cd18-792b-017224b8667c@gmail.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <f51ec1a9-f265-cd18-792b-017224b8667c@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Oleksandr,

On 13/10/2021 16:05, Oleksandr wrote:
> On 13.10.21 16:56, Jan Beulich wrote:
>> While this has meanwhile moved quite far from the original proposal,
>> I still wonder in how far Andrew may have remaining concerns. Did
>> you check with him, perhaps on irc?
>> But of course catching his
>> attention may be difficult, so no (further) feedback by him should
>> probably not keep this from getting committed (if no other open
>> issues remain).
> 
> If I remember correctly, I made several attempts to clarify in the 
> initial thread. But, I have to admit, not via IRC (I am expecting some 
> troubles with my IRC client last time and I haven't figured out yet 
> why). Of course, it would be correct to get a feedback to make sure that 
> there would be no remaining concerns (as the main concern to use domctl 
> was addressed) or otherwise.

I have pinged Andrew on IRC for you.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Oct 13 15:25:03 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 15:25:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.208644.364850 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mag7n-0003D7-FO; Wed, 13 Oct 2021 15:24:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 208644.364850; Wed, 13 Oct 2021 15:24:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mag7n-0003D0-CG; Wed, 13 Oct 2021 15:24:59 +0000
Received: by outflank-mailman (input) for mailman id 208644;
 Wed, 13 Oct 2021 15:24:58 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=dUCo=PB=gmail.com=olekstysh@srs-us1.protection.inumbo.net>)
 id 1mag7m-0003Cu-Cw
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 15:24:58 +0000
Received: from mail-wr1-x42e.google.com (unknown [2a00:1450:4864:20::42e])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 61194f6b-4583-4129-87cd-3d5509812401;
 Wed, 13 Oct 2021 15:24:57 +0000 (UTC)
Received: by mail-wr1-x42e.google.com with SMTP id e3so9505151wrc.11
 for <xen-devel@lists.xenproject.org>; Wed, 13 Oct 2021 08:24:57 -0700 (PDT)
Received: from [192.168.1.7] ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id v18sm12518142wrm.63.2021.10.13.08.24.55
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Wed, 13 Oct 2021 08:24:56 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 61194f6b-4583-4129-87cd-3d5509812401
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-transfer-encoding:content-language;
        bh=J5aUVxO0eIAhj+4p9MTABA7TYyilub1rlXaps2e4Fa4=;
        b=pKmVrKRAtp75xo4U18sWDNGaKTB7uQbNOAVrySNQU/o+D6TeVBtlapzct9fVrQ750V
         z7RYVi3xwYWi/v0yayiq/c7vTZzi05Hr8z28Dzo+81yfSSVWmEfwuFVHl+5x2u/RLt8b
         USX51BdjboipQsvAoWN339RPcpdtlCReVd0zOOkVlFhjBsLk107+RL8gD1xfFvPpsj3C
         wyEE2v2HfP3Sp+6A7fQju0EZTUBoiCYmD9Xz5zDzEp4zGReW5QEKdJG/jqpkQnftlC0h
         TrExqk8OT2RppdAMvSikue03T2B5fjZvKSkpb0gUHuVQ054hQEazeZBBgEMuPfgqx3KB
         ERuw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding
         :content-language;
        bh=J5aUVxO0eIAhj+4p9MTABA7TYyilub1rlXaps2e4Fa4=;
        b=Ka4bggXtpdZjDay5Cg7MqAEav/8547jlgc57ut5pfw1Zg+tbXUY8b/WBJOU31AoBgT
         l/DKAKYKnU/6sTeAZ2fU6kg8+k2av6gG+yVnZ2GxT9wDmWqQDMResK1VRByjzSXF2O5/
         q805UpihKRz9TSjAA7juN/OfepKZxGXiwISygoHVZJyBK4oGOGfa83EjKmYcg5sD2lGj
         /cHhMICHSUfdXq7r4TaVy91Mz67j2Bykrvex2M9X9R4s7Jxn+pkNXuShXAzBGYrphnPH
         siDDmUQCPB/NqSaVm7T93GH9dGDWNgSFwKZOOcjW7eKEmEaxdJSvVbFxa6CkbIedoNND
         9ODg==
X-Gm-Message-State: AOAM530KqI4t8u+rvvclf3ppI7JQChLgsYAUENLdzDS4BbLA+32O576P
	4Jo6HJ1AQ6WHcHVD/wfKFS0=
X-Google-Smtp-Source: ABdhPJzJn1QO0tsrqxVS3nYjGTO3wPhIEa+F98Imkgm7XKYQe7F9SLRqLzoLiRsE1vEZLK/u8IQ9KQ==
X-Received: by 2002:a05:600c:a08:: with SMTP id z8mr13490996wmp.165.1634138696271;
        Wed, 13 Oct 2021 08:24:56 -0700 (PDT)
Subject: Re: [PATCH V6 1/2] xen/arm: Introduce gpaddr_bits field to struct
 xen_domctl_getdomaininfo
To: Julien Grall <julien@xen.org>
Cc: Jan Beulich <jbeulich@suse.com>,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>,
 Anthony PERARD <anthony.perard@citrix.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Juergen Gross
 <jgross@suse.com>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 xen-devel@lists.xenproject.org, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>
References: <9e6e1378-7ee3-b692-b57d-29b597160661@gmail.com>
 <1634073720-27901-1-git-send-email-olekstysh@gmail.com>
 <f9b8b55b-cfe4-2bfa-44db-e898800def72@suse.com>
 <f51ec1a9-f265-cd18-792b-017224b8667c@gmail.com>
 <e614a4a4-ec65-1bbc-4e25-c838b9ebeeb8@xen.org>
From: Oleksandr <olekstysh@gmail.com>
Message-ID: <f3d19160-af62-cbe3-7bc3-28dab7bcf4a5@gmail.com>
Date: Wed, 13 Oct 2021 18:24:55 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <e614a4a4-ec65-1bbc-4e25-c838b9ebeeb8@xen.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US


On 13.10.21 18:17, Julien Grall wrote:
> Hi Oleksandr,

Hi Julien


>
> On 13/10/2021 16:05, Oleksandr wrote:
>> On 13.10.21 16:56, Jan Beulich wrote:
>>> While this has meanwhile moved quite far from the original proposal,
>>> I still wonder in how far Andrew may have remaining concerns. Did
>>> you check with him, perhaps on irc?
>>> But of course catching his
>>> attention may be difficult, so no (further) feedback by him should
>>> probably not keep this from getting committed (if no other open
>>> issues remain).
>>
>> If I remember correctly, I made several attempts to clarify in the 
>> initial thread. But, I have to admit, not via IRC (I am expecting 
>> some troubles with my IRC client last time and I haven't figured out 
>> yet why). Of course, it would be correct to get a feedback to make 
>> sure that there would be no remaining concerns (as the main concern 
>> to use domctl was addressed) or otherwise.
>
> I have pinged Andrew on IRC for you.

Thank you for the help.


>
> Cheers,
>
-- 
Regards,

Oleksandr Tyshchenko



From xen-devel-bounces@lists.xenproject.org Wed Oct 13 15:30:43 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 15:30:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.208655.364861 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1magDG-0004g1-4Z; Wed, 13 Oct 2021 15:30:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 208655.364861; Wed, 13 Oct 2021 15:30:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1magDG-0004fu-1B; Wed, 13 Oct 2021 15:30:38 +0000
Received: by outflank-mailman (input) for mailman id 208655;
 Wed, 13 Oct 2021 15:30:36 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1magDE-0004fo-Me
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 15:30:36 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1magDD-0007uo-Pu; Wed, 13 Oct 2021 15:30:35 +0000
Received: from 54-240-197-234.amazon.com ([54.240.197.234]
 helo=[192.168.17.188]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1magDD-0002Lq-It; Wed, 13 Oct 2021 15:30:35 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=wfrUX3y0MWqfEcm8fsOYiMydNXVmNJpktqj374DVFf4=; b=KXv2+XvsfqUXRHBrem0jZ+JlZ4
	u7iENoBVd5hnbwYIfxAkCM8FuCSia9KFkqekKr0MM1BNA9OHLHiXh76KV0/WbW2B7wTmDToUNY1ec
	MpEEY7zIqmUX0jbfynzg0d9wdet3jsxtL2lWn93E2fyoyMEPHfJz8VMevWZb5nNJA5BE=;
Message-ID: <35cd8909-1d9b-842f-62e6-7544dcd3da4b@xen.org>
Date: Wed, 13 Oct 2021 16:30:32 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.2.0
Subject: Re: [PATCH v5 10/10] xen/arm: Process pending vPCI map/unmap
 operations
To: Oleksandr Andrushchenko <andr2000@gmail.com>,
 xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org, oleksandr_tyshchenko@epam.com,
 volodymyr_babchuk@epam.com, Artem_Mygaiev@epam.com, roger.pau@citrix.com,
 jbeulich@suse.com, andrew.cooper3@citrix.com, george.dunlap@citrix.com,
 paul@xen.org, bertrand.marquis@arm.com, rahul.singh@arm.com,
 Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
References: <20211008055535.337436-1-andr2000@gmail.com>
 <20211008055535.337436-11-andr2000@gmail.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20211008055535.337436-11-andr2000@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Oleksandr,

On 08/10/2021 06:55, Oleksandr Andrushchenko wrote:
> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> 
> vPCI may map and unmap PCI device memory (BARs) being passed through which
> may take a lot of time. For this those operations may be deferred to be
> performed later, so that they can be safely preempted.
> 
> Currently this deferred processing is happening in common IOREQ code
> which doesn't seem to be the right place for x86 and is even more
> doubtful because IOREQ may not be enabled for Arm at all.
> So, for Arm the pending vPCI work may have no chance to be executed
> if the processing is left as is in the common IOREQ code only.
> For that reason make vPCI processing happen in arch specific code.
> 
> Please be aware that there are a few outstanding TODOs affecting this
> code path, see xen/drivers/vpci/header.c:map_range and
> xen/drivers/vpci/header.c:vpci_process_pending.
> 
> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> [x86 changes]
> Acked-by: Jan Beulich <jbeulich@suse.com>
> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
> Reviewed-by: Rahul Singh <rahul.singh@arm.com>
> Tested-by: Rahul Singh <rahul.singh@arm.com>
> ---
> Cc: Andrew Cooper <andrew.cooper3@citrix.com>
> Cc: Paul Durrant <paul@xen.org>
> 
> Since v2:
>   - update commit message with more insight on x86, IOREQ and Arm
>   - restored order of invocation for IOREQ and vPCI processing (Jan)
> Since v1:
>   - Moved the check for pending vpci work from the common IOREQ code
>     to hvm_do_resume on x86
>   - Re-worked the code for Arm to ensure we don't miss pending vPCI work
> ---
>   xen/arch/arm/traps.c   | 13 +++++++++++++
>   xen/arch/x86/hvm/hvm.c |  6 ++++++
>   xen/common/ioreq.c     |  9 ---------
>   3 files changed, 19 insertions(+), 9 deletions(-)
> 
> diff --git a/xen/arch/arm/traps.c b/xen/arch/arm/traps.c
> index 219ab3c3fbde..b246f51086e3 100644
> --- a/xen/arch/arm/traps.c
> +++ b/xen/arch/arm/traps.c
> @@ -34,6 +34,7 @@
>   #include <xen/symbols.h>
>   #include <xen/version.h>
>   #include <xen/virtual_region.h>
> +#include <xen/vpci.h>
>   
>   #include <public/sched.h>
>   #include <public/xen.h>
> @@ -2304,6 +2305,18 @@ static bool check_for_vcpu_work(void)
>       }
>   #endif
>   
> +    if ( has_vpci(v->domain) )
> +    {
> +        bool pending;
> +
> +        local_irq_enable();
> +        pending = vpci_process_pending(v);
> +        local_irq_disable();
> +
> +        if ( pending )
> +            return true;
> +    }
> +

I would prefer if this addition is moved before the 
vcpu_ioreq__handle_completion(v). This is to avoid differences with the 
x86 version.

>       if ( likely(!v->arch.need_flush_to_ram) )
>           return false;
>   
> diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c
> index aa418a3ca1b7..c491242e4b8b 100644
> --- a/xen/arch/x86/hvm/hvm.c
> +++ b/xen/arch/x86/hvm/hvm.c
> @@ -546,6 +546,12 @@ void hvm_do_resume(struct vcpu *v)
>   
>       pt_restore_timer(v);
>   
> +    if ( has_vpci(v->domain) && vpci_process_pending(v) )
> +    {
> +        raise_softirq(SCHEDULE_SOFTIRQ);
> +        return;
> +    }
> +
>       if ( !vcpu_ioreq_handle_completion(v) )
>           return;
>   
> diff --git a/xen/common/ioreq.c b/xen/common/ioreq.c
> index d732dc045df9..689d256544c8 100644
> --- a/xen/common/ioreq.c
> +++ b/xen/common/ioreq.c
> @@ -25,9 +25,7 @@
>   #include <xen/lib.h>
>   #include <xen/paging.h>
>   #include <xen/sched.h>
> -#include <xen/softirq.h>
>   #include <xen/trace.h>
> -#include <xen/vpci.h>
>   
>   #include <asm/guest_atomics.h>
>   #include <asm/ioreq.h>
> @@ -212,19 +210,12 @@ static bool wait_for_io(struct ioreq_vcpu *sv, ioreq_t *p)
>   
>   bool vcpu_ioreq_handle_completion(struct vcpu *v)
>   {
> -    struct domain *d = v->domain;
>       struct vcpu_io *vio = &v->io;
>       struct ioreq_server *s;
>       struct ioreq_vcpu *sv;
>       enum vio_completion completion;
>       bool res = true;
>   
> -    if ( has_vpci(d) && vpci_process_pending(v) )
> -    {
> -        raise_softirq(SCHEDULE_SOFTIRQ);
> -        return false;
> -    }
> -
>       while ( (sv = get_pending_vcpu(v, &s)) != NULL )
>           if ( !wait_for_io(sv, get_ioreq(s, v)) )
>               return false;
> 

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Oct 13 15:37:00 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 15:37:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.208664.364872 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1magJM-0005LW-RK; Wed, 13 Oct 2021 15:36:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 208664.364872; Wed, 13 Oct 2021 15:36:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1magJM-0005LP-O2; Wed, 13 Oct 2021 15:36:56 +0000
Received: by outflank-mailman (input) for mailman id 208664;
 Wed, 13 Oct 2021 15:36:55 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=bU9L=PB=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1magJL-0005LJ-Bi
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 15:36:55 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 6425bb2e-2c3b-11ec-8181-12813bfff9fa;
 Wed, 13 Oct 2021 15:36:54 +0000 (UTC)
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur01lp2056.outbound.protection.outlook.com [104.47.2.56]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-32-yorydFhJOF-YQNTEAxsUlg-1; Wed, 13 Oct 2021 17:36:52 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0402MB3391.eurprd04.prod.outlook.com (2603:10a6:803:3::23)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.19; Wed, 13 Oct
 2021 15:36:51 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.016; Wed, 13 Oct 2021
 15:36:50 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS8PR04CA0032.eurprd04.prod.outlook.com (2603:10a6:20b:312::7) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.14 via Frontend Transport; Wed, 13 Oct 2021 15:36:50 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6425bb2e-2c3b-11ec-8181-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634139413;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding;
	bh=Y9BIJQobaTZEoekm+P0iAA572KdUtOghT3sS1h6RJGc=;
	b=H9oweS7HXPhuf9LdXIbAc0Yg7XUgyX+zE9LBmlWEFEDh5c9hRirw70fzMwq0aH3oivnrhm
	GN3+3jnMiZEkb4HYHkhLzHuQVQVMKxV3GhzGWyzMG8RZwbOf+rPg39KIF8eWrLSvexy4ly
	hNcqTcClz87XFcSh8CWT6NOlJcz5p+Y=
X-MC-Unique: yorydFhJOF-YQNTEAxsUlg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=fwCpDHyMBfEi1tgf+KwCHOAoz+pituqrb4HyLjC23oJnJPOY12u7xHtNJytesSGxphWkoISq54Jlq2ZxNjfcM9fyv9Fa3roXd+zzz/67K+r+nLhIxSmOK7CT051W+QI6XB0UG0VGIx3WhYoRkYDW3THvmZHV+peC4d6JhoUB4DjfPEpCCb/mIga/KjAahLgV9aq0WfFVR1IrOQpeBupdO/Lg4S4/SAO7sSn2N6feZi523dFSBfFNPO1b0M/X8mAkxb+3WCdSZ2ymsUvHbk60lE8qdL2yE/GBltM7rwLu3RiVV3ghDQmGFxrrI14Cf/umde8SmZIA3s9SlZRflBZYwQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Y9BIJQobaTZEoekm+P0iAA572KdUtOghT3sS1h6RJGc=;
 b=EQvDwfawRCkll3BiN48nbSDTDahQf2nrGEKr/Skl+3S3OxzvxomyWAYWFsWJsfJLK+lHHeMJ4wuBYt9UPSPAyGEj6E518cMoAblAFaKUX1bE3YUoVfklDUkjoMHMyfpuuMiGeAaFqq5ntyYmeFBqtaSD/zCbrl0a3iYDrY9qrZGQSalpc6mMzw/DxUF2U55OKiYNYnsD59lVm+Jn5P1IEcAAKsIfQ1gLfns4M1JMdWW8k7YaA2Pf+ZvfVo3US+Pzd0ZXsbyvk+ot9ypya+McJHG+F0JpCodSbmSsaDJHV2ikgyO2a2jtMOstm/9IrVp5IP5DZfRtNJibAlZkTF4rQA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: citrix.com; dkim=none (message not signed)
 header.d=none;citrix.com; dmarc=none action=none header.from=suse.com;
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Tim Deegan <tim@xen.org>, George Dunlap <george.dunlap@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
Subject: [PATCH 0/2] x86/shadow: address two Coverity issues
Message-ID: <24329000-06d7-2047-b0a1-51b149d19189@suse.com>
Date: Wed, 13 Oct 2021 17:36:48 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8PR04CA0032.eurprd04.prod.outlook.com
 (2603:10a6:20b:312::7) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: ad855273-f906-471e-77c1-08d98e5f46a7
X-MS-TrafficTypeDiagnostic: VI1PR0402MB3391:
X-Microsoft-Antispam-PRVS:
	<VI1PR0402MB33916544BFB72A30E832B881B3B79@VI1PR0402MB3391.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6430;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	bB9HyhEBzY9o4X3iuvqDtdHek08ZeGdEIr0PpRL6+jCqxoFhvUMveyFp1fxrKVegFA9L4mYgNVpeFG+wNbAwqhMpnRoePxtjl2w4lFaqWVx+XfASJXZHAxNsWUY4EGSPXo5NT26MNY8SlNAnWKkhvnLjqu95sjw/WqzUM7jhEmXw5f3WPaQrriSnt97h8M0p4ovshxauNpJ4bhiAv1lI85eyUZz7XDNkGxKwhzC53K5oCIk3nUcHIX9oGyb2vATb686Y637yOWeu6A05BzVNJkmXtHS387iLKk6o0vumnARQdcFH364/fp8ECEkw36fjs9zQhy8rUx46Abnj3s3oliS2/TW139bSrVyywk2+rmi0vEXvBN2JzlIPL3FqYFP1EmlCeJUH/sYx2kYb4fswCPUU4uhKyeibf7sEN46zYWCX/zDuK0ZcREfvxXPkET5g9HZox3grEC8HMZVPZgBYssYyCI/DKHa/3nmWUDfQIwdvCAZKvCNiW7QczTf57xCVpQ2I5mSEjzzPfKXInJ1LbvUEOQ0M5JH87h/vd+CCEnwxwqiQcs9E+HZ35d2rp98D/R5KBjCDbQ5yVjhoDCZrTn6wnXMQxrqrqmL9P5+XYlzaby6sNxH65eTSDEvDq80Xq3/plhlWwkqYhHcTa0NjuLl4sw+pRPdsFGLyXvm8syQz+RTHV0kLq9EgXOWf5dyrDdExhY8oWtSlzF9UNMujA7N77qxXma+TJXJhJh30yNdTtZoE90HkVYkBCZV04J9J
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(66476007)(66556008)(4744005)(8676002)(31696002)(8936002)(38100700002)(66946007)(2906002)(6916009)(508600001)(54906003)(26005)(4326008)(31686004)(5660300002)(6486002)(956004)(16576012)(2616005)(316002)(36756003)(86362001)(186003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?eVllODdJcHBiNnRTc1lHdnlTMUFCRkZpZVQ4MHRYYTJpc1lRNmIxenhhTTJP?=
 =?utf-8?B?bHBxUHJTVVh3NXJDZ08rK0tlTlBub2RTMnY1WTRwTDhXV0laamxWNk51RHZ6?=
 =?utf-8?B?WVZES3lBS3MvdXRmRE4yTElIUjVBNXpLL2hoWEpnNDQ3YWkrVVJjTFdwdTQ2?=
 =?utf-8?B?Mk90TTBnbUhMM3FuWG5jbGFDNUhVN3h4MUdONTcwMjNmdDZOU3pDRElZLzdP?=
 =?utf-8?B?ZlNDQ1hlZmJ6SVB1TndyTXdudXliVXRsTU9WQkFHcjloalAvM3k0OXh1NDBZ?=
 =?utf-8?B?UTJEN3NiSFpJTDBjRnV0RXFTSERPU3NXNGt6Z2ZzOGNPWWZBQ1RVMkNsZk1v?=
 =?utf-8?B?cnliMktpSEFKQk1tUGVobENVQ3owK0tqZVZlMGVVTExOeUc3QzByczBvZk82?=
 =?utf-8?B?RHV5SE83bi9ra2pXRzkwSzZHUWVrc2dQNm9jenZwc3JvSWU0VXJBTURPeWVB?=
 =?utf-8?B?Vmk2SmdwQ0JwckNaUXp4WEZtRjJyaUZkNkxuYkp2ZFBJT25scmM1NnlwZjJo?=
 =?utf-8?B?RnYrTk51RWVLMHM3Q202ZUgwZXc2R01SWUZGNGUxckM2TWFSWkxhd3NVQkhR?=
 =?utf-8?B?T1l1SXlmUFRjWHNsTmRYNDdrWlFMNnFST1A2aWNvQmRTZlllQ0RGMFdOSUk1?=
 =?utf-8?B?Q2RCVjBSNW5JQ3o5YjQ2S25oWDJ5SGdkMGc2Rmk0T1pEMzNScWtnMVNPTkJz?=
 =?utf-8?B?RlY3VnFqNWxLd2YvM0VmYXZUVVQyRWxxckpNdEwrYTc1ajlCS29KektKTGVC?=
 =?utf-8?B?QzBOdm8yZ3RCK0hUK2huWDJJa090MkZHd0xLbFI1RHlZODBlUURKVjV1QzRM?=
 =?utf-8?B?SlptR0YwejRQdVpSZjREdG0vazcvSnRGM3d3YlloaXdIYm5BUXBHV1czc1lp?=
 =?utf-8?B?Y2N3L3k0OXJ1RUxUSmJsU0ZBbEhZQWd1VjlZKzBGWENOSnVQMWJrQlRjQ1Np?=
 =?utf-8?B?YkFHSkw2cGFkQmFyZFhlOEo3bmY5TXgzYXlvd1hrYlNGSzlLcjlmSHNyVlpu?=
 =?utf-8?B?Y2pOK3htT1VJbUM1YWh0WlZZL1pnZGIwZCtPRUlZeXpNVVpzaVJTUjJKdERM?=
 =?utf-8?B?cm5zeU4ramFMMFBjNlEwd2hFUjZYajdHeHpUOWxxb2FaeVIyL1RmQXNDTW1C?=
 =?utf-8?B?L1hUMkxpckQzNmx1QlBVeExHQTE3NjdtbEZyN0M2OUtpRzhZTkR5ZVlFR21G?=
 =?utf-8?B?RGlUbDBBRURxeU9JallqRE9yc3I4MGx5aXdSa3NlUUhoazZ0Q1RLUXRJaVgy?=
 =?utf-8?B?SGozVjRlYjdWRHVWU1laQ21pcFdaWnFLS2NRV0RJbVFhQnBZT0dkaFJTM2pw?=
 =?utf-8?B?MlF5cmZjb2NNSEowY08rN0h2ZDFkY3dPVnJici94UmFHQ2NBUFkxZS83eUhM?=
 =?utf-8?B?bFBXbVJoNnpEWkV3Qzk2QnRsVjQ3OE91V20zbFZXbHRyRllPRFZWZ2RJWWtL?=
 =?utf-8?B?L2JiZTkycHFLQ3psdVJCazVnSnBacFdkVlFCS0JmUW1jK1hNQlg0N280eDZW?=
 =?utf-8?B?N1RIMFNEM2RFVnJvUGZ2di8rOEQ2ZTdTam1vVVJ2NlNlYXVvVnh4VU90aklJ?=
 =?utf-8?B?U3hpK1ZUWkl5aStoOEt5VS8wc2NHR0hycGRtbmp6bHQzMzVHc3lDSTI3NUxE?=
 =?utf-8?B?ek8yWjcvNFR0MURPNGlOckhYQnk0RjNVb0U3ZEtzYWZIeCtjaU11TlBxTnZp?=
 =?utf-8?B?OXhOMkphakV6bS81WFFEUzhwVnhuM1BMenZ4WmRDV1N6TUhNTEJ0R3pKWFJY?=
 =?utf-8?Q?rfSICx4U1HPLoAoSPnbbep+ObWP6EPa7/+lz/Qo?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ad855273-f906-471e-77c1-08d98e5f46a7
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2021 15:36:50.8693
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1txSfnlVSkAkWxm1hBw2ZAOjyThGTjPyLlXbRGuEF3fNw7VvqY41Y9AW6/7SDfpMSE9SRWcKXyK62Jl75fCBTg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3391

It's not clear to me why the tool spotted them now and not before,
but this has got to be a subtle side effect of introducing the tiny
wrapper stubs. Anyway, the "fixes" (perhaps rather workarounds) are
pretty straightforward.

1: adjust some shadow_set_l<N>e() callers
2: adjust 2-level case of SHADOW_FOREACH_L2E()

Jan



From xen-devel-bounces@lists.xenproject.org Wed Oct 13 15:37:58 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 15:37:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.208669.364882 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1magKM-0005ui-4J; Wed, 13 Oct 2021 15:37:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 208669.364882; Wed, 13 Oct 2021 15:37:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1magKM-0005ub-1K; Wed, 13 Oct 2021 15:37:58 +0000
Received: by outflank-mailman (input) for mailman id 208669;
 Wed, 13 Oct 2021 15:37:56 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=bU9L=PB=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1magKK-0005uN-D9
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 15:37:56 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 610c2b07-3b8b-419e-a6a8-f5cac45dfb6c;
 Wed, 13 Oct 2021 15:37:55 +0000 (UTC)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2112.outbound.protection.outlook.com [104.47.18.112])
 (Using TLS) by relay.mimecast.com with ESMTP id
 de-mta-28-g2Kj25PoMdCTSB8bfLJOxQ-1; Wed, 13 Oct 2021 17:37:53 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VE1PR04MB6381.eurprd04.prod.outlook.com (2603:10a6:803:119::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15; Wed, 13 Oct
 2021 15:37:51 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.016; Wed, 13 Oct 2021
 15:37:51 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS8PR04CA0093.eurprd04.prod.outlook.com (2603:10a6:20b:31e::8) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.16 via Frontend Transport; Wed, 13 Oct 2021 15:37:51 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 610c2b07-3b8b-419e-a6a8-f5cac45dfb6c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634139474;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=Jy7HwRHaNovftUjQsJ1pQLTkbsHkl1IkKdFl9OaItS4=;
	b=HBGgT+C/+KIp2hjN1negr2d8kzNcCn1yMOOBXFWVqpEpVMNYcB6ZXJIKPEe/8shnt5EfSk
	PfZCMwZB912HDAVFNP/WVU2Zf69mPyJDqRSIvBrIXDd/4Q7liIHAcMjcOKOCDt23syaBeV
	YM8nUCJLF5AN8GpykRS408UFB2DcJCc=
X-MC-Unique: g2Kj25PoMdCTSB8bfLJOxQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=cC4UdQ3/QTEhlmKT+TbGN/O2aw53lOhVuou2XEF2TY4Ez8/VTZF0qkU1bwG2SDUBdKn1FrQ72oX+rzZZ9/ZjQJk+TiU5LTLPZTVdaINRNLVOjxD/EZ8zkSEBVq8x16jYb2s/tHW1FEWCppHJKzvaDiJAStAHKoUAynQcWjNnd40j5GGGE/yXZ/6wRMEoo1/a69CfWHEFtN+YlQmIntIo45IypsBm0CrYdGcAZyZnspF1s/e8AsheLg7X41fCI8GvlQlDdVenUh5T0PZ5+YNTmTQHhm5/yXFN5rZBqnI1MxlZEgeUPVDQf7bxd1aD78mux+3xzrd7xINGPTYtQ29DVg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Jy7HwRHaNovftUjQsJ1pQLTkbsHkl1IkKdFl9OaItS4=;
 b=HOw/hlGPPLjsPzFpwXS878Gvwu9pmOu+zbuh3QKfM4OBrBb2YlcN+KS+e/l88I4QVbZ9i5LI35jGkHBi4I165cJ/lqrh2CSr5AZNrfaK8ABm3CE3ZK2A1IZeA0w7111yaJmIuji7oQ5DU+VGCTWuIjLReQZTU1DapQA/hSK94ANqyqMGV/7tAS9FW0Ofp2Fww5tVwsywXJ1IizwMX/xlkhr+CqMqwGCcopbwxZe6RX8WU/6lmYSsMVK2tbqZbIG10OGPeHwBP3UNYzATPThuxVrcu5n6nc+HMu3kvz6fRAeuO+s1idkOzhVxNeMgWaU5c//seOyjTiWIbevlJF9QYA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: citrix.com; dkim=none (message not signed)
 header.d=none;citrix.com; dmarc=none action=none header.from=suse.com;
Subject: [PATCH 1/2] x86/shadow: adjust some shadow_set_l<N>e() callers
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Tim Deegan <tim@xen.org>, George Dunlap <george.dunlap@citrix.com>
References: <24329000-06d7-2047-b0a1-51b149d19189@suse.com>
Message-ID: <298846aa-f93f-4564-dbf4-4f893df8f328@suse.com>
Date: Wed, 13 Oct 2021 17:37:49 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <24329000-06d7-2047-b0a1-51b149d19189@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8PR04CA0093.eurprd04.prod.outlook.com
 (2603:10a6:20b:31e::8) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 613915a8-42d4-4ddd-b58e-08d98e5f6acb
X-MS-TrafficTypeDiagnostic: VE1PR04MB6381:
X-Microsoft-Antispam-PRVS:
	<VE1PR04MB6381689C141276F35DAA3AF4B3B79@VE1PR04MB6381.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:1227;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	7T7Hh5zlBBYz/uyRwWQ+a5QcQIpeIjicHMIhv3CHC9lKLTYx6GamO/7dkstnK3r8up364tUkFAA15K1pt4nN9TAOcGz5nHfxL3G/Lidm+JjCw/fEC6zQjv2OU0v7KTShBV1bqPrM4PXB5g+Ip8mDRA4O08oJ+G5NE7rBBE0GfQmo0gVcdQFkSIKTkoR9GPeFxu1GoLKcvRXewn+Fw+VfSxtydnwfvnEA8vnc+4K0BKfw++ozPm1T2wWIvxu7YJIAVexecPYtTFfmwkMfcPa/YKLpW1K2J1+sVHTA06EGn1oYkF//eGtSkkqHt4pyLk5nwy0drdd3I8mRRkYc+JehhS6YJpJs/3b+Ye34OGXiO2HJgIgzbFjNubgqA5NgIXPjWHhBi8bi3tXIjpvd+HHt0D7icWb0iktqp3pOjKJVBupyJyhIB53JyDOsYzs2eSRTVJI3DWojJ48w7Ei9aFcCpM85thQTV4jcZcKCJj26SFBPizQjFt7C2py85CWdsCPLe7SjiyurxEktvoyPosPZo2VMZoZC5K149ZH1ysMMxyYnmv5A8DE7NO1Poo8GswmetM4ErhT3Gpr0bsIZYTP65M8aUQOLO9lPRb5QDAmQrI/t0l/CXP8x4kOFEtK0vUxE74dc70U9NpSfM7P/lQmW+j6+3y+MOKg5YJiq3+/+MU13HofPMRBrH+cBrbZfLfZJw73tu+RxVH7Aat7zFZIdVAwokEPjDk2Cugw0E7V3zKAj0LX4T1+Iijamq++26J9AClR+idlLYIRij+7GKfoMRXhBC2ksdspVLJRt5flD9PU=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(956004)(38100700002)(6916009)(8676002)(36756003)(16576012)(2616005)(6486002)(54906003)(2906002)(26005)(316002)(31686004)(66556008)(508600001)(8936002)(66946007)(4326008)(66476007)(86362001)(5660300002)(83380400001)(186003)(31696002)(43740500002)(45980500001)(473944003)(357404004);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?V29KRUlEck02N01LcWJPZkZTaWVZSkpvT1ZCM0Vjbzd0TkJXaU02WEdRMWh4?=
 =?utf-8?B?RHVybElWUDNBM09TcHlHZ09GS0FyNDh2QStuaXNkUUZpM2NMNjgrVGEyaDVH?=
 =?utf-8?B?NDNkcGV5bTZqY2Urc2YzMXJsblZGaDVEekNQZ013ZDlGKytLTXdOWlpEUGtO?=
 =?utf-8?B?UDR6dWZIOXpuT1RKbU9xemFHK21xNldNNFp0TVNIMThLUVU5WDZCZkNaNC9x?=
 =?utf-8?B?TDVOZnpESXBUMFFjcDlHQUdsRnJ6NFkyOEk0elNFSk5nNFFEeWRYVnh5Y0Nn?=
 =?utf-8?B?eGVaUlFGSGRHdGNHMmg1QjVjMU51c2tmMGxGTWFiZnJQVzRrWWl4YS9lMEc1?=
 =?utf-8?B?VHNSN2szSERHNW0vYVByamVWSXRPUFJZN0syN3VyZEhMNy9BM0pBaHhscGVs?=
 =?utf-8?B?NFIwOXBxM3VlM3RqeVdhUWVCWE8wN3lQd3EvZUdoelZVOWhMZENWdU5tUEJ3?=
 =?utf-8?B?REhXTDZaakltUTgvNVhxUmVsUStubW9qWGVnazErakNBRUIwbU5XRTN1K045?=
 =?utf-8?B?SThHY3FNSkRyTVN4QytNYVE1Ry9ub2hGQWlDYU5rQnZyeVV0ZEdoSGVNcDN3?=
 =?utf-8?B?QlQxZE0ya1JzdVpIYzdaanhsU1hRTGw1Mkt6TjFybitCSkZEZ1QwZStSWnVu?=
 =?utf-8?B?SHlqV1pxZ2s5WHBlc1hmdzZCemZ6aXNFRFhZN3lXR2tjZFMwNGcweVpBR0pJ?=
 =?utf-8?B?TnZOd20xWFo0bTNxcnEwK2dFQXNQbEl6UVU0SDB3bUhiS1pNaHNTaE8ydmJy?=
 =?utf-8?B?cW5Lc0dzU1lmUFRlM0hhei8wYlpxdmJMc1B4ZENXQ0pRRXp4bklONzl2Zndy?=
 =?utf-8?B?Mm9xSG1iRUZLajgxZlB5T1l5TTUvRlNtWlFDVmIwZ0w1c3hveG1FcHUwMyth?=
 =?utf-8?B?UG9abm94YXV5QzVkWWJ1bHNMMXRiQ1hTbVFTT2VYdTc1M21SSGlhcjdtV0lQ?=
 =?utf-8?B?MW5HY0dHVVltdWRGSEdyb0xBc1NiWmxScjhjK2xVTk5WeUJmNmFycW1Na3lE?=
 =?utf-8?B?TStEVVBhN3p4a1pHRm9lZWQ4LzdjM0dQNnpYNXB2L29wcEN5dC8yZjd5elNz?=
 =?utf-8?B?SCsrMW1QaHluMmltdVZvZDZkUk9GMi94NitCRmxUNTQrSlRZTWxFcWZ0cmRx?=
 =?utf-8?B?dWlLc1oxQ1NPYlJSSnFnQi82NlF6MXpXanAyclp2OE80MEVidkZvWTdxdmFI?=
 =?utf-8?B?K1ozYnB5ajJ5cW4xN09ScklnRzY5ZDF6UUg5ci9OU3M5L2Irc002Vm40VE5p?=
 =?utf-8?B?WXcrNTY4bC9HSTEwQnNDM2xTeTREd2IwcGxnM01senRHdXhjb01jVldVYklY?=
 =?utf-8?B?dXF2cUFzb2tCeXRLamdQRWFkSzJlREUwSzZRUEhuTVJ2TjdUcXo3RlUvU1Jt?=
 =?utf-8?B?YVlpT24vc2RXZHFZSFFJQWlCeXB2QTNtWG4wOHZIMU84RzFLbU5FZzBzRHlI?=
 =?utf-8?B?UGJ0clZaWUtsMXZZMS9XU2drN1BRcW0xRE9iUUJJWk1qWXc2cXFYKzViWWpz?=
 =?utf-8?B?dUVsc0xIeFpSV3RYZzFJZUU1SDE4d3FjZE1HUmFyNWswb1ZhT0UxcHFQSWMr?=
 =?utf-8?B?a25xRjFVVmVEL0ZvbTJQci9MV1RLQmk3ZkxDQ3V1U3FCeUpuNkZST1pyeGFN?=
 =?utf-8?B?YmhDNnlsV3NaaE1QZ1liZWdnWEZrVkdrZDY3c3JGYldFdVAyTXhIVno0czRS?=
 =?utf-8?B?cHhOcERDWjBrUGtWbnJnSlJubTR6VzhYeFJpdDhseG8yeHBjb0trVk9va0x2?=
 =?utf-8?Q?BHqTpn+Mone+eAJh1vuAngLmGBdR0kH9V5kATyF?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 613915a8-42d4-4ddd-b58e-08d98e5f6acb
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2021 15:37:51.5077
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: gCmOuB6nIblPWp2vhRvj3ScCHVuswm3f/39nmH8SVjxhRec4YEZquhDvNz2u2k++iPKny2FVAg9deu2gaQvhRQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6381

Coverity dislikes sh_page_fault() storing the return value into a local
variable but then never using the value (and oddly enough spots this in
the 2- and 3-level cases, but not in the 4-level one). Instead of adding
yet another cast to void as replacement, take the opportunity and drop a
bunch of such casts at the same time - not using function return values
is a common thing to do. (It of course is an independent question
whether ignoring errors like this is a good idea.)

Coverity-ID: 1492856
Coverity-ID: 1492858
Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/arch/x86/mm/shadow/multi.c
+++ b/xen/arch/x86/mm/shadow/multi.c
@@ -1416,7 +1416,7 @@ void sh_unhook_32b_mappings(struct domai
     shadow_l2e_t *sl2e;
     SHADOW_FOREACH_L2E(sl2mfn, sl2e, 0, 0, d, {
         if ( !user_only || (sl2e->l2 & _PAGE_USER) )
-            (void) shadow_set_l2e(d, sl2e, shadow_l2e_empty(), sl2mfn);
+            shadow_set_l2e(d, sl2e, shadow_l2e_empty(), sl2mfn);
     });
 }
 
@@ -1428,7 +1428,7 @@ void sh_unhook_pae_mappings(struct domai
     shadow_l2e_t *sl2e;
     SHADOW_FOREACH_L2E(sl2mfn, sl2e, 0, 0, d, {
         if ( !user_only || (sl2e->l2 & _PAGE_USER) )
-            (void) shadow_set_l2e(d, sl2e, shadow_l2e_empty(), sl2mfn);
+            shadow_set_l2e(d, sl2e, shadow_l2e_empty(), sl2mfn);
     });
 }
 
@@ -1439,7 +1439,7 @@ void sh_unhook_64b_mappings(struct domai
     shadow_l4e_t *sl4e;
     SHADOW_FOREACH_L4E(sl4mfn, sl4e, 0, 0, d, {
         if ( !user_only || (sl4e->l4 & _PAGE_USER) )
-            (void) shadow_set_l4e(d, sl4e, shadow_l4e_empty(), sl4mfn);
+            shadow_set_l4e(d, sl4e, shadow_l4e_empty(), sl4mfn);
     });
 }
 
@@ -1969,7 +1969,7 @@ static void sh_prefetch(struct vcpu *v,
 
         /* Propagate the entry.  */
         l1e_propagate_from_guest(v, gl1e, gmfn, &sl1e, ft_prefetch, p2mt);
-        (void) shadow_set_l1e(d, ptr_sl1e + i, sl1e, p2mt, sl1mfn);
+        shadow_set_l1e(d, ptr_sl1e + i, sl1e, p2mt, sl1mfn);
 
 #if (SHADOW_OPTIMIZATIONS & SHOPT_OUT_OF_SYNC)
         if ( snpl1p != NULL )
@@ -2534,7 +2534,7 @@ static int sh_page_fault(struct vcpu *v,
 
     /* Calculate the shadow entry and write it */
     l1e_propagate_from_guest(v, gw.l1e, gmfn, &sl1e, ft, p2mt);
-    r = shadow_set_l1e(d, ptr_sl1e, sl1e, p2mt, sl1mfn);
+    shadow_set_l1e(d, ptr_sl1e, sl1e, p2mt, sl1mfn);
 
 #if (SHADOW_OPTIMIZATIONS & SHOPT_OUT_OF_SYNC)
     if ( mfn_valid(gw.l1mfn)
@@ -3014,8 +3014,7 @@ static bool sh_invlpg(struct vcpu *v, un
                 shadow_l1e_t *sl1;
                 sl1 = sh_linear_l1_table(v) + shadow_l1_linear_offset(linear);
                 /* Remove the shadow entry that maps this VA */
-                (void) shadow_set_l1e(d, sl1, shadow_l1e_empty(),
-                                      p2m_invalid, sl1mfn);
+                shadow_set_l1e(d, sl1, shadow_l1e_empty(), p2m_invalid, sl1mfn);
             }
             paging_unlock(d);
             /* Need the invlpg, to pick up the disappeareance of the sl1e */
@@ -3608,7 +3607,8 @@ int sh_rm_write_access_from_l1(struct do
              && (mfn_x(shadow_l1e_get_mfn(*sl1e)) == mfn_x(readonly_mfn)) )
         {
             shadow_l1e_t ro_sl1e = shadow_l1e_remove_flags(*sl1e, _PAGE_RW);
-            (void) shadow_set_l1e(d, sl1e, ro_sl1e, p2m_ram_rw, sl1mfn);
+
+            shadow_set_l1e(d, sl1e, ro_sl1e, p2m_ram_rw, sl1mfn);
 #if SHADOW_OPTIMIZATIONS & SHOPT_WRITABLE_HEURISTIC
             /* Remember the last shadow that we shot a writeable mapping in */
             if ( curr->domain == d )
@@ -3637,8 +3637,7 @@ int sh_rm_mappings_from_l1(struct domain
         if ( (flags & _PAGE_PRESENT)
              && (mfn_x(shadow_l1e_get_mfn(*sl1e)) == mfn_x(target_mfn)) )
         {
-            (void) shadow_set_l1e(d, sl1e, shadow_l1e_empty(),
-                                  p2m_invalid, sl1mfn);
+            shadow_set_l1e(d, sl1e, shadow_l1e_empty(), p2m_invalid, sl1mfn);
             if ( sh_check_page_has_no_refs(mfn_to_page(target_mfn)) )
                 /* This breaks us cleanly out of the FOREACH macro */
                 done = 1;
@@ -3656,20 +3655,20 @@ void sh_clear_shadow_entry(struct domain
     switch ( mfn_to_page(smfn)->u.sh.type )
     {
     case SH_type_l1_shadow:
-        (void) shadow_set_l1e(d, ep, shadow_l1e_empty(), p2m_invalid, smfn);
+        shadow_set_l1e(d, ep, shadow_l1e_empty(), p2m_invalid, smfn);
         break;
     case SH_type_l2_shadow:
 #if GUEST_PAGING_LEVELS >= 4
     case SH_type_l2h_shadow:
 #endif
-        (void) shadow_set_l2e(d, ep, shadow_l2e_empty(), smfn);
+        shadow_set_l2e(d, ep, shadow_l2e_empty(), smfn);
         break;
 #if GUEST_PAGING_LEVELS >= 4
     case SH_type_l3_shadow:
-        (void) shadow_set_l3e(d, ep, shadow_l3e_empty(), smfn);
+        shadow_set_l3e(d, ep, shadow_l3e_empty(), smfn);
         break;
     case SH_type_l4_shadow:
-        (void) shadow_set_l4e(d, ep, shadow_l4e_empty(), smfn);
+        shadow_set_l4e(d, ep, shadow_l4e_empty(), smfn);
         break;
 #endif
     default: BUG(); /* Called with the wrong kind of shadow. */
@@ -3689,7 +3688,7 @@ int sh_remove_l1_shadow(struct domain *d
         if ( (flags & _PAGE_PRESENT)
              && (mfn_x(shadow_l2e_get_mfn(*sl2e)) == mfn_x(sl1mfn)) )
         {
-            (void) shadow_set_l2e(d, sl2e, shadow_l2e_empty(), sl2mfn);
+            shadow_set_l2e(d, sl2e, shadow_l2e_empty(), sl2mfn);
             if ( mfn_to_page(sl1mfn)->u.sh.type == 0 )
                 /* This breaks us cleanly out of the FOREACH macro */
                 done = 1;
@@ -3712,7 +3711,7 @@ int sh_remove_l2_shadow(struct domain *d
         if ( (flags & _PAGE_PRESENT)
              && (mfn_x(shadow_l3e_get_mfn(*sl3e)) == mfn_x(sl2mfn)) )
         {
-            (void) shadow_set_l3e(d, sl3e, shadow_l3e_empty(), sl3mfn);
+            shadow_set_l3e(d, sl3e, shadow_l3e_empty(), sl3mfn);
             if ( mfn_to_page(sl2mfn)->u.sh.type == 0 )
                 /* This breaks us cleanly out of the FOREACH macro */
                 done = 1;
@@ -3734,7 +3733,7 @@ int sh_remove_l3_shadow(struct domain *d
         if ( (flags & _PAGE_PRESENT)
              && (mfn_x(shadow_l4e_get_mfn(*sl4e)) == mfn_x(sl3mfn)) )
         {
-            (void) shadow_set_l4e(d, sl4e, shadow_l4e_empty(), sl4mfn);
+            shadow_set_l4e(d, sl4e, shadow_l4e_empty(), sl4mfn);
             if ( mfn_to_page(sl3mfn)->u.sh.type == 0 )
                 /* This breaks us cleanly out of the FOREACH macro */
                 done = 1;



From xen-devel-bounces@lists.xenproject.org Wed Oct 13 15:38:44 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 15:38:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.208676.364894 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1magL5-0006YJ-Iy; Wed, 13 Oct 2021 15:38:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 208676.364894; Wed, 13 Oct 2021 15:38:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1magL5-0006YA-Eh; Wed, 13 Oct 2021 15:38:43 +0000
Received: by outflank-mailman (input) for mailman id 208676;
 Wed, 13 Oct 2021 15:38:42 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=bU9L=PB=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1magL4-0006Xw-7e
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 15:38:42 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id a3b9f566-2c3b-11ec-8181-12813bfff9fa;
 Wed, 13 Oct 2021 15:38:41 +0000 (UTC)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2106.outbound.protection.outlook.com [104.47.18.106])
 (Using TLS) by relay.mimecast.com with ESMTP id
 de-mta-25-7T0q3v30OQCzmBEYKn62Lw-1; Wed, 13 Oct 2021 17:38:38 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VE1PR04MB6381.eurprd04.prod.outlook.com (2603:10a6:803:119::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15; Wed, 13 Oct
 2021 15:38:37 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.016; Wed, 13 Oct 2021
 15:38:37 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS8PR04CA0102.eurprd04.prod.outlook.com (2603:10a6:20b:31e::17) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.25 via Frontend
 Transport; Wed, 13 Oct 2021 15:38:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a3b9f566-2c3b-11ec-8181-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634139520;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=ukLUF7Im/PJ2Z8SrCJMh3Wvu3vUEqtNNwX8+b+BQm0A=;
	b=Yl0pOEqGeBlnq4zfp+va1W8bNOdEJUQozYdURXu+djwKCVAEEfwgPL+PaXJ+aMlJ43MXBj
	+K77DNgZHC7XuxjKkGPTrIDdmQYyHB2uY9WLWpOFSfiEpKWDuitLotQHBCIyxx2GFricBL
	xk0ngIaldVbg3PY0nue8+DIJS15sq10=
X-MC-Unique: 7T0q3v30OQCzmBEYKn62Lw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ha/w4ryFwYX8WRBRSyWxVH2PsFE8/Chr6ilYGYBn0xGun/M/pvmhaUnYX9JqEryrg2aNN8sZ2owEMpWEFTm00hF/sVB9V7n6Rp6Jw1WisZibqLQsyWq9IE84Bmi5CUGip4iJ8yatEtVrMoWhYFyzPy527DTRIE7q7nNbuotoqIKwud7L9F84E2PJLPVtO1ERrs8Og+yaO29eWaV25wERiGzj3VPbV1DHJ/zliPdAzgBdMIzq+xRBk0gZyd0EITNkIEsDHpXTL0VaZ0r5ZIn8oaVVH1oCvySHdkkluZIvJtJ8F08xv0vH8mF1zBoapXw9+umoL3fPbtN+PTnHjagpCw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ukLUF7Im/PJ2Z8SrCJMh3Wvu3vUEqtNNwX8+b+BQm0A=;
 b=gbchrw8qOtYgi5z8sgjNgo9T21aMoVC4pdJBkVpRZRBMdmDeeBRbCfEx3UoAiOSKshPhAECRqdSMp4ODAgNO3bogrEYj8DxIT6NoWb0TAXrgElwQ3++/vZkejVlwcVVccylPh5IRyAH1Eek16O5NwmQdT4yJohsfltFLFQqvxoe/bSqtLZKu3T2NUw1uHVaw57c8Cns8Fkuz9q3NZXRaD/a4IrYtkQ2ZpjWdkI7eR+zP0iTm/RJcOrqMhL8dumSSbZrH0Ne9H/C5K4YxEviqNO5h1HCoHSMzuiHMrRts33IQ1q/83g0xKoV2RyLq5hOghV3/nZSg6GBLjIdl8h9PUA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: citrix.com; dkim=none (message not signed)
 header.d=none;citrix.com; dmarc=none action=none header.from=suse.com;
Subject: [PATCH 2/2] x86/shadow: adjust 2-level case of SHADOW_FOREACH_L2E()
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Tim Deegan <tim@xen.org>, George Dunlap <george.dunlap@citrix.com>
References: <24329000-06d7-2047-b0a1-51b149d19189@suse.com>
Message-ID: <b2f750c4-3aa3-e560-626a-c7fa921cf4df@suse.com>
Date: Wed, 13 Oct 2021 17:38:36 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <24329000-06d7-2047-b0a1-51b149d19189@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8PR04CA0102.eurprd04.prod.outlook.com
 (2603:10a6:20b:31e::17) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 97c07bbc-f418-4007-8c3f-08d98e5f8653
X-MS-TrafficTypeDiagnostic: VE1PR04MB6381:
X-Microsoft-Antispam-PRVS:
	<VE1PR04MB638174D21CB028FD9AF25CDAB3B79@VE1PR04MB6381.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:2733;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	nQSZ3NaqL0K43AsbQYzkGL+uI3hXhSD9yL6iqE4SA2Ee9pa6DaGCYTYsWYCgXtc1w4L30DSinGg7U9F5Q5veBYtcvHj6xQD/biNpyY60sJwLTGw3A/4DdbCwYRkDnpr9QEYtk6FQ0CUqhN08Y97YtDC5T0ZGNaNC+nDykGyouKecEiQPuH5GgCasSw7tfK4RH50ESivglzkcTPKymrGppqoZu+YTVwY30aoyxhMlJBETzXruR0naGELQE6ZIf5dGBUmZXemhx3Tbu9TvxR9k6zHqd9KdF8m/WZoV6R4uItbaFIXkx5oHoMh9pzQZDWOuvgNzvTtAHeEod1GMYT+rt+T7G6/8jPBTDBG6WAurNl7i1QTWpm8et+Bsy4jRqT8PC+LNh4v1byrtS3bOYm55SyJjwCV+/OM7+YFMeGItx3UcvYnRbTDYj/+Y7gOt698R4SLzunp/+mQiWmO4Zv8oYtnipE/zYDo9ZXGqYRaUL4y92xYJiyB34liFshCKKu3tlz2YExR14Of2s5WWekodbRxEE8j01yf8vvomO9QA80q2I0CS+QG94+0n5AxgBu7tiUExm2x/VA7Ejr5YaHltoriiEfsYq+VXhxW+dTjdNTX5OTqK+TejF7uFiz4qjzxA9dfpMjIDxyARE6KiWHSAOfmML7+DGu16q5WmSuy+Vr0walYVMrtZxHM+NmbI3tE1X9a/+YPlLQbLyhmHHJs0UP7z787dYWZJjmFU8ccPxWo=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(956004)(38100700002)(6916009)(8676002)(36756003)(16576012)(2616005)(6486002)(54906003)(2906002)(26005)(316002)(31686004)(66556008)(508600001)(8936002)(66946007)(4326008)(66476007)(86362001)(5660300002)(186003)(31696002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Z2F3ZGRJaDJ4ZVFnQ2pkZVpMM1Zydys5TlI0L0loOU83UzdzZmJMcUZsQm9O?=
 =?utf-8?B?M3d3N1VGQzdUckhTa3EvYjNMSU02YyszZ3EwM2ZYRkI5dU9OVXVhZVk0QkFC?=
 =?utf-8?B?b2ZqU0gxNlJVaDk3OVQ4U2Q4SUNNOVJFYmFtRFlpTzduTzBQdnZKUzNMNGls?=
 =?utf-8?B?VGJ1UTkweStIN2VlM21PVU1yMWNCRmtKdWR5QmhGeE8vWDlIMklTZ21Cdllp?=
 =?utf-8?B?Q1dXZ1dLMFZkK2ZKNVNJcGNWcERJT2JYbllkMFpuODlDeVhybXlWajZ2KzV4?=
 =?utf-8?B?YnFjaEM4bmY5ZWw3TFQ4YitBQnh0Qk5aZWNJdGtBZEVoc1NlYit5V1VweW1R?=
 =?utf-8?B?ZUhWb2VJU1ovb1V1eHF0dk02OG5aMTVwVWNqdktVTGhSSWRIdm96TDArTWxX?=
 =?utf-8?B?QkJ6VUo2VUdPV3h2Rk9FK0JBRkZydkhuVTZmVElkWFk0QzhycC8zUkppWXE3?=
 =?utf-8?B?R2ZwQ3lwZEZZRFAvbnk2YUdyK1hhcFBBemwxNGNtSU1OUWR3QVp6b21URmI2?=
 =?utf-8?B?NFJKQzhicFZlQ2VsaVVVZVdDblpUNXRiVEpOc1FzL1RqTkVSN1JwV0lxcjJR?=
 =?utf-8?B?OEZKRXlsMWk0UUpUS2F3bFhZNjFLR3hJOTgrcVdvNUh6NWJLRzg1Sjg3ZGhW?=
 =?utf-8?B?VmVyWVcrT0taMEVYUnQ3dDJlMWpmZCsvb1ptOGVYVEFvYVpaM210VlNock82?=
 =?utf-8?B?Q0VRKzhFYlIzVGtKM2gxa0FpcDl6S0UzaHp6U2xaZ1owNllmeXZ4ajQ0TUpH?=
 =?utf-8?B?a1FqRDVIMTVaUmNMTURUVGhlSzl2UEJGSnFBTnVGaitrNEk1cFl1UTJvK1po?=
 =?utf-8?B?L3UzdW9weVA0b1ZpR2dpdlZSMHdwWlRkcTJia0VKemk1SG9WdlAvV0dxY0Zm?=
 =?utf-8?B?ek1nZW9TR0tkd0JWUExKYnlBYTJCazlxTjhQZ0xtejdpNE9tQWVQRjhCV2lo?=
 =?utf-8?B?QjZLVmhtRStuSW5GZ3FtVG9HcUEyOEM3RitTTlQ3dlliRnVMa2F3SGRKRjdv?=
 =?utf-8?B?K0p4K0NRdVVtcW5LRE54R1UwYWZLVitYNGtvSlQ4R2NwVE91RHliVEswZDBE?=
 =?utf-8?B?ajM0ZUNJSzhqN3lQYWxhWnpzVEpITG0xMk1oUFo3N1cxRWwxb2pHeWd5NExW?=
 =?utf-8?B?cmtvWmpGeWpLeWlnWTA3TjQ4NGxyRi81Tk9PNk1TTHppTE15a2t1OEJWNjdI?=
 =?utf-8?B?RXlaM2IrZTZSU2M4TXFWSmpIK0RZNVNYSU5zT0JwWGpFaXpYdzNPMGxvZmkr?=
 =?utf-8?B?OE1SQ3FQaUFrZ2gwTFN2V1c4WU9wOHdVRmlpR2VmWjdrRjRxekg4Q2xJTThk?=
 =?utf-8?B?NW02VVhFcFJJUWhWc21wY0hNdTRRd3RuVitUOVllZm1Sbjg4R1NEU0hmSGFa?=
 =?utf-8?B?bFd5aDFlS1ZPT0lVU1BpTGVvQzhlSW9iUkpFK1VGa2hYaEprRU5BNjNXU0Jn?=
 =?utf-8?B?RWRLakUxT3R6MUlDcXdrdm9vTWF2ZmFEczFVNkxVZkJMUFRjT3FBbGNxdU1v?=
 =?utf-8?B?d0tDYXdIMXNzbWJPRWE3c2FBT2tFQWthR2xHTk5vUGg5L2UyR3UzNlFYOVZt?=
 =?utf-8?B?bFloaldBbkptQkNIa1YvWU1kR3FUUTJodG16cEhaU3VDbVQ1RFRTekZ5M1ZV?=
 =?utf-8?B?V0ZYV0dwS1grcnZEUzNFNmlxUWoyMHhFVjduMUh1cU9NVENvOG1CV2ErbnRw?=
 =?utf-8?B?Y2VvYXY0ZWhtb2FiUFp0aTBiK0lDbzZxQk5sVTNoMWRWcXNyMTBrbzJ0MnBF?=
 =?utf-8?Q?XYNOENZdVy1J3SQREw7CghK5QZwczwf1MpMysuy?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 97c07bbc-f418-4007-8c3f-08d98e5f8653
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2021 15:38:37.7085
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: tI6VZJry/Y+7Iz2shnDJ+/Py+V74tgSKpq7koLBTzd6sqUmNwa3iN2phe2YjKSTcFfu0t7khbHxs7N5S1HgUVA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6381

Coverity apparently takes issue with the assignment inside an if(), but
then only in two of the cases (sh_destroy_l2_shadow() and
sh_unhook_32b_mappings()). As it's pretty simple to break out of the
outer loop without the need for a local helper variable, adjust the code
that way.

While there, with the other "unused value" reports also in mind, further
drop a dead assignment from SHADOW_FOREACH_L1E().

Coverity-ID: 1492857
Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
Looking over other SHADOW_FOREACH_L<N>E() invocations wrt their uses of
"done", I find the audit ones particularly odd: The respective variables
get set only from AUDIT_FAIL() and AUDIT_FAIL_MIN(), but in both cases
after invoking BUG(), i.e. in an unreachable position.

--- a/xen/arch/x86/mm/shadow/multi.c
+++ b/xen/arch/x86/mm/shadow/multi.c
@@ -794,8 +794,7 @@ do {
                          ({ (__done = _done); }), _code);               \
     _sl1mfn = sh_next_page(_sl1mfn);                                    \
     if ( !__done )                                                      \
-        _SHADOW_FOREACH_L1E(_sl1mfn, _sl1e, _gl1p,                      \
-                             ({ (__done = _done); }), _code);           \
+        _SHADOW_FOREACH_L1E(_sl1mfn, _sl1e, _gl1p, _done, _code);       \
 } while (0)
 #else /* Everything else; l1 shadows are only one page */
 #define SHADOW_FOREACH_L1E(_sl1mfn, _sl1e, _gl1p, _done, _code)         \
@@ -808,10 +807,10 @@ do {
 /* 32-bit l2 on PAE/64: four pages, touch every second entry */
 #define SHADOW_FOREACH_L2E(_sl2mfn, _sl2e, _gl2p, _done, _dom, _code)     \
 do {                                                                      \
-    int _i, _j, __done = 0;                                               \
+    int _i, _j;                                                           \
     ASSERT(shadow_mode_external(_dom));                                   \
     ASSERT(mfn_to_page(_sl2mfn)->u.sh.type == SH_type_l2_32_shadow);      \
-    for ( _j = 0; _j < 4 && !__done; _j++ )                               \
+    for ( _j = 0; _j < 4; _j++ )                                          \
     {                                                                     \
         shadow_l2e_t *_sp = map_domain_page(_sl2mfn);                     \
         for ( _i = 0; _i < SHADOW_L2_PAGETABLE_ENTRIES; _i += 2 )         \
@@ -819,11 +818,12 @@ do {
             (_sl2e) = _sp + _i;                                           \
             if ( shadow_l2e_get_flags(*(_sl2e)) & _PAGE_PRESENT )         \
                 {_code}                                                   \
-            if ( (__done = (_done)) ) break;                              \
+            if ( _done ) break;                                           \
             increment_ptr_to_guest_entry(_gl2p);                          \
         }                                                                 \
         unmap_domain_page(_sp);                                           \
         if ( _j < 3 ) _sl2mfn = sh_next_page(_sl2mfn);                    \
+        if ( _i < SHADOW_L2_PAGETABLE_ENTRIES ) break;                    \
     }                                                                     \
 } while (0)
 



From xen-devel-bounces@lists.xenproject.org Wed Oct 13 15:39:29 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 15:39:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.208682.364905 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1magLo-0007CA-TC; Wed, 13 Oct 2021 15:39:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 208682.364905; Wed, 13 Oct 2021 15:39:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1magLo-0007C3-PL; Wed, 13 Oct 2021 15:39:28 +0000
Received: by outflank-mailman (input) for mailman id 208682;
 Wed, 13 Oct 2021 15:39:28 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=EFKL=PB=citrix.com=roger.pau@srs-us1.protection.inumbo.net>)
 id 1magLn-0007Bf-KS
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 15:39:27 +0000
Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 2d1d6b57-631c-46c8-b9d0-9425c95999ff;
 Wed, 13 Oct 2021 15:39:26 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2d1d6b57-631c-46c8-b9d0-9425c95999ff
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1634139566;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=CmtLkR6rkul89lMj6oQLuOyrvDamw+xd+ZeK+D6SyZ0=;
  b=SJ3mluirVeRwFvkiyZ4AldhyW4prci1ocIX4UiFXpYMVuq06iD7TQazA
   4EPjpk7S1NtGYKF8cCC4xKHokU/1FSXmefNptMySdpivp++ySVh90oGN8
   kMqhcToCE1bhkcQxH1hbuJq3qJad2ryGahbRTDXrpm5g6OeSAkTpO10MV
   w=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: 749edZJFVCMxSqJndnrlsAS047YU1nHiDVQ0gu8chpxkYe0EP+6owse4lSsiMj9PQS5Y1ww+vw
 zP5ochPcsHdaKa3Jw/SCDgJch5xEuqRL+lfFY6TiU7dTpaPJfLhRknqmjllUKtGGwq6YdwTCLj
 tLJXR/TG/16y/pq94cxhijUeYnGODaF0fVfaGaa9dVPEfYlo8rDqqPo/uAm1Zntt/rksDu+mDM
 eqSFH4XUUZMtBCFY7MYIg5ZlNP+yvVDq3Oexmd1Q1FIlKtnEY1DysQ5a6qZtm6lokwwfKw4bJx
 YEA2QfehrbIEe2GxUeEBzoS2
X-SBRS: 5.1
X-MesageID: 54674701
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:XWyCRKommodg7Md2FH3N7lSOBwNeBmIDYxIvgKrLsJaIsI4StFCzt
 garIBnSMvmKajejfdl+YIiz80kB6pHSnN9gHlQ+qyxmRilD8puZCYyVIHmrMnLJJKUvbq7GA
 +byyDXkBJppJpMJjk71atANlZT4vE2xbuKU5NTsY0idfic5Dnd84f5fs7Rh2Ncx2YHiW1jlV
 e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL
 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9
 DlCnbfqSlksOfDApOY6fBxGQxtjA7Z/wbCSdBBTseTLp6HHW37lwvEoB0AqJ4wIvO1wBAmi9
 9RBdmpLNErawbvrnvTrEYGAhex6RCXvFJkYtXx6iynQEN4tQIzZQrWM7thdtNs1rp0SQ6mCO
 JJAAdZpRASRRkVMKw04NIknrsaKplPeMGMCiGvA8MLb5ECMlVcsgdABKuH9U8aWSMBiu1eXr
 2PL4Uz0GhgfcteYzFKtzHWogePemDLhb6gbHra46/1CjUWawyoYDxh+fVG2u+Wjg0iyHddWM
 VUJ+zEGpLI3skesS7HVTxC+5XKJoBMYc95RCPEhrhGAzLLO5ASUDXRCSSROAPQ8vc8rQXox1
 1mGn/vgHzkpu7qQIVq68rqXtjq0NTIiBGkOfzIfTQAF7t/gp6k+lhvKCN1kFcadjNf4BDXxy
 DCitzUlivMYistj/6em+VHKhRq8q56PSRQ6ji3wWm+m9Qp/aJSSW52z6VPb4PBDK66UVlCE+
 nMDnqC29/sSBJuAkCiMRuQlH7yz4fuBdjrGjjZS84IJrmr3vST5JMYJvW84dBwB3ts4lSHBS
 xXQ5wZWuZNvPlyFaLEnWZ+PEP0Twv21fTj6bcz8Yt1La5l3UQaI+iByeEKdt1zQfFgQfbIXY
 sjDL579ZZoOIeE+lmDuHrZCuVM+7nlmnTu7eHzt8/iwPVNyjlauQrAZLEDGUOk96K6VyOk+2
 4cCb5XUo/mzveuXX8U2zWLxBQxURZTYLcqvwyCySgJlClE5cI3GI6WAqY7Ng6Q/w8xoeh7gp
 xlRoHNwxlvlnmHgIg6XcH1lY76Hdc8h9i5jY3B2ZQz0gCRLjWOTAEE3LMRfkV4Prr0L8BKJZ
 6NdJ5Xo7gpnG1wrBAjxnbGi9dc/JXxHdCqFPja/YShXQnKTb1ehxzMQRSO2rHNmJnPu7aMW+
 uT8viuGEctrb1kzV67+NaPwp25dSFBAwYqeqWOTeYINEKgtmaA3QxHMYggfeplWd0qYnGfGj
 m57w34w/IHwnmP8y/GQ7YispIa1CepuWE1cGmjQ97GtMifGuGGkxOd9vCygIFgxjUv4p/evY
 /t71fb5PKFVlVpGqdMkQb1q0bg/953koLoDllZoG3DCblKKDLJ8IybZgZkT5/MVnrIJ6xGrX
 k+v+8VBPenbMs3SD1NMdhEuaf6O1K9Il2CKv+g1Okjz+AR+4KGDDRdJJxCJhSEEdOl1PYopz
 P0PoskT7wDj2BMmPszf1nJf9niWL2xGWKIi78lIDIjugwst61dDfZ2DVXOmvMDRM41BaxB4L
 CWViazOg6Vn6nDDK3djR2LQ2ed9hIgVvEwYxlE1OFnUyMHOgeU63UMN/G1vHBhV1BhOz8l6J
 nNvax9uPayL8jpl2JpDUmSrF10TDRGV4BWsmV4AlWmfREi0TG3damY6PL/Vrkwe9mtdeBld/
 a2Zlzm5AWq7Ipmp03tgQ1NhptziUcd1p1/Ll82QFsiYG4U3PGj+iai0aGtU8xbqDKvdXqEcS
 TWGKAqoVZDGCA==
IronPort-HdrOrdr: A9a23:FB71s6op569/akxIEM6IDBEaV5u3L9V00zEX/kB9WHVpm5Oj+f
 xGzc516farslossREb+expOMG7MBXhHLpOkPQs1NCZLXXbUQqTXftfBO7ZogEIdBeOk9K1uZ
 0QF5SWTeeAcmSS7vyKkDVQcexQuOVvmZrA7Yy1ogYPPGMaGJ2IrT0JcTpzencGNTWubqBJba
 Z0iPA3wAZJLh8sH7qG7zQ+LqX+juyOsKijTQ8NBhYh5gXLpTS06ITiGxzd+hsFSTtAzZor7G
 CAymXCl+qemsD+7iWZ+37Y7pxQltek4txfBPaUgsxQDjn3kA6naKloRrXHljEop+OE7kosjb
 D30lsdFvU2z0mUUnC+oBPr1QWl+DEy60X6wVvdunfnqdyRfkNzN+NxwaZiNjfJ4Uspu99xlI
 hR2XiCipZRBRTc2Azg+tnhTXhR5wqJiEtntdRWo21UUIMYZrMUh5cY5llpHJAJGz+/wJw7Ed
 NpENrX6J9tABKnhkjizytSKeGXLzEO9k/seDlHhiXV6UkZoJlB9Tpa+CRF9U1ws67USPF/lq
 352+pT5fdzp/QtHNdA7dE6ML2K41z2MGDx2V2pUCDa/YE8SjnwQs3Mkf8IDN/DQu1+8HJ1ou
 WZbG9l
X-IronPort-AV: E=Sophos;i="5.85,371,1624334400"; 
   d="scan'208";a="54674701"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=So2Prlqsh+zUHHG9R41Pu3tA1zJk5EShub5uH8QarMVNgHdKak4aZT+DXHka8LRFhtDbzdpZsPNv9l9Z7CoxhVpirdGnKlYSIwbcuz7Uhpxpt2YtKe38j9KWY2Wy0DhOZ48p4zuyCI2c+EufdhW3lUWDDwsHr4v7fec7eYLQeAOpQRAV6D+cEUsQ/xyVwKdY843cX3tpTlAGXP26fZEQzvce1dDaDf9ohs6mGC4ZdOcHo2iCR75C6JR1mazKFyFpQqnpv/dGm84zoOjcwYPv06DE/gfofZj+UqB1hNOgTmtOkuO4v8AAC3Dolb548/0XYgZwl9CO+zXXgfJ4oNpHAA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=R+JNnufgiK5AL08zA4CP6OX/9w2Or/DdvDM7ylSGL20=;
 b=GmrgI6zMyIuHjAWggYi0NuKK0ycWm8S5uh/uqS7TtiBxkZlD3WN6kb70JM0f2QAvk9bO0ielNNCa4R97eyZTC3+U6vhDBHV2zzVr/eA8VZnaVcnw7Rd+ATHCaeaOw6KdtlftlFMYSasm3zBr1moasgN7eYO81jTl78PnmF/x+GV0h8ciLOLrr6S3adzfe5FRhTTT9uJC+gXj0o3KhYr8T+3Hws/LWLf1el5ZHOCAq/ldbS+k640dSq1IBSJKIrfVd8vtOSGlU8Y5NlvI2c5dcsm1II7pHWgA3KsHpSiAEDD9v3DDFICydAU5P1d4/3c2VV9n7pMjqzYjCbNqi0Sxbw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=R+JNnufgiK5AL08zA4CP6OX/9w2Or/DdvDM7ylSGL20=;
 b=K15QLjP3Yrp/VtNSfOqPee0VSxMfeUQ+tNXxmQzZJMi1WP+7NBO5dndZWsNdvJ9LE2efQv1Z+4aAHeqgtfOYtwRkAmiyn8mP3uJ5b+3eJ7U1TtUfTNDNS7Zd+4NxriwO0s4J2a3N5iMznOlSmTqfJkG7PdbkVqdvKUOdpNkQ6uE=
Date: Wed, 13 Oct 2021 17:38:58 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>,
	"julien@xen.org" <julien@xen.org>, "sstabellini@kernel.org"
	<sstabellini@kernel.org>, Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Artem Mygaiev <Artem_Mygaiev@epam.com>,
	Bertrand Marquis <bertrand.marquis@arm.com>, Rahul Singh
	<rahul.singh@arm.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v3 04/11] vpci/header: Add and remove register handlers
 dynamically
Message-ID: <YWb9kgON0krr5lp9@MacBook-Air-de-Roger.local>
References: <20210930075223.860329-1-andr2000@gmail.com>
 <20210930075223.860329-5-andr2000@gmail.com>
 <2b575750-83a5-588e-fd6b-dd9cdb9500dd@suse.com>
 <e3730616-c51f-c453-3f74-584473313e54@epam.com>
 <672f00b2-3065-34f1-3dda-430edd8eb463@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <672f00b2-3065-34f1-3dda-430edd8eb463@suse.com>
X-ClientProxiedBy: LO2P265CA0438.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:e::18) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: d2cd4f7f-c06f-43e0-5782-08d98e5f9612
X-MS-TrafficTypeDiagnostic: DM4PR03MB5997:
X-Microsoft-Antispam-PRVS: <DM4PR03MB59977E3A3F43716AD2F5B18C8FB79@DM4PR03MB5997.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7691;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: T9TuqtVHr+qngnaAw9v+MWWs8G/O4TQP72pRU7HUupW/0zJ5tGsNS4Sbz7x46nPpguB7ybiKk6FAV0E6bJsPPAC4zPmc/0pXVRup/pC1VsoYxZbNliwEHJ1onCLfbIKwMngoj9cCCVzUwLiZuVYJZp1it9ER5nynSQWJsmnMLG/zvn394iStslEF6c475sSqGtCRNn7R3vIoe4wahVw8a8gUUwFZFNYLrcAFWvbcN2Ye7Shgi+qpIJR8jqS3In4uysP1RnqKDBIrT3Eb1CLjM4Vb4OPEM+zNG87wCYzcGLHU+0t8rM16j8YJbeI2F7aL1Nmechl0Qut9HYTa92RkP5faK6556eSUp1Io+lb8Km5dZivHWjckDCR+H/e652GSZ+7BoJd4qgTt3umuxuGMJ7Ryzdl67BDZ/z+8U6d3J0KKY2og+NxTms2967BVe4Bfw6mvei4c7uNmme5getZIFOJW9kReZacD6I8L5cPJ3Vz8uDRy3G8naNbgNs2gskFuYhsY8eHGDSMnJ8Cj7bQ2rkelcshzgx+A9I+TL/QOi3EJEY0Lh0EOD2HSk79WdQ89/EZHyXeZXys0GXQ+yLXxVhwLtG1XuM/RgCwpXWJmNDxBaE1J5PzOVKqfHk8tx9iuAoVSnsgLvo/R6G+u3OWeXA==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(316002)(8936002)(9686003)(186003)(8676002)(2906002)(82960400001)(54906003)(86362001)(38100700002)(4326008)(6496006)(85182001)(6666004)(66556008)(5660300002)(66476007)(508600001)(7416002)(66946007)(6916009)(26005)(6486002)(956004)(53546011);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TjFhTkFZLy96OWJUSk5tazhyZWQxVFEwTWFlT1lacTZmZEVrZGU5enpBUVVp?=
 =?utf-8?B?VHdLNW9lMDExZmp3OFdqOWpkTVNOa1lhc3lNUFlFVFpvNDJmK1ZTM2dtcG9v?=
 =?utf-8?B?S051Rm9lWXpWM0gxdWhNSzRLTmFSbWxmMTNHTkIrVG4vTFpTYVJydTRhZEFu?=
 =?utf-8?B?Y3JyOFVwcWlxeml0Wm1xTHRiazhnOXVJUnpPZlludHJ5MURDK0l0ZUk1Zjh5?=
 =?utf-8?B?V0FZeWpwNzlONVBPZzhVWUlDZUpPN2gzL3RsV0NRejdac1F6dGczKzRRSXl0?=
 =?utf-8?B?a28zZ01kQTlOU0FKWHRPSlpPMEo5aEZnSU5ja1VHbzhOVlU4WDlMaVdPN09u?=
 =?utf-8?B?L094WUhEVUVHYi9ZQ0xFeEUzaXJpZGpab3gvTXNFL2NlSnRqS1ordGkvQzgw?=
 =?utf-8?B?NmNqd3lpM3NidVFtVkxZMmUySVdscENsQmVjU2pFWExvVW0xaE9jOE9PZGkz?=
 =?utf-8?B?UC9wQVRXcitDOVBSMi8zaEdQMVBXYWVicWZ6SFUxK0NhZlgzOFR4YzFoQXJw?=
 =?utf-8?B?LzJlSjRHbk90eUswVVh3d1QyVkpUWkVzNVQ1Y1Z3N1dGb0hOcVhEWSt4dXVv?=
 =?utf-8?B?NVZscVcvWG5IdGpQSFdqUWtaMXRpQjR1bkhrRCtCMUx1TWtTdTZ6T0VkVUw5?=
 =?utf-8?B?NHZuNGFmKzA0VUtyVHNkeFM1NFUzS0lhWUNYTU1rOFBFWHhIeStuTWVSRndu?=
 =?utf-8?B?TElwODR5SlFXbzF3ajh4Y25LN0E3RDlhb1RmYVNDcDhGY1BSR2szNGxROVVL?=
 =?utf-8?B?dFI4anRhdWVKUFRNR0ZtU2hPOHh4bkZXTHJxOUJERGtHaW4rWXg0OElZRmdR?=
 =?utf-8?B?NGx4Z2hzQ3ozc21McUFhbWhyOTBmekdDTlRHY2FKb1pOSHkyZzRraGRxaXl2?=
 =?utf-8?B?dGVZRG9helIyTWxYUmd0SU5PZloxdmxTdmNOenFqaEgrZnVKUW01eUlBa296?=
 =?utf-8?B?bW9zQjFhOWhFWHdHWVlEbFBKRnBEQ0RWVzV2N1grcGp6bUpkdHEwZmxuSTFw?=
 =?utf-8?B?Wmx4aU9KWlJkOVFoYUhsNnFFdXpEUHc3RXlUeitJN0hNb3J4TUN3b1l6SDJN?=
 =?utf-8?B?cjZMTmlCWWpOOHB2OW05QlA5T0l3ejNXQ1NVSzhiOWlneXJNb3ZnMXlKN2s2?=
 =?utf-8?B?VnVLUkFnMjRUanJXdHFwQW9aKzgyWk5DU25JUUU5MlluNmFVa2VwYmVrbnBT?=
 =?utf-8?B?M2FlZjdiN0gvUEVLMHlJRWJYTVdVR3FtNnBFZjhaZ3pqWHF1M2pUUi9vdmU0?=
 =?utf-8?B?NVBKQmwvUzhocE92eVlwZ1VPWlYydE1rTU1zWGpYSUtjMkpKL1M3Y2dwazJu?=
 =?utf-8?B?YjRoOWhOd1dtNVZYMHdjdFFrdFk5TDdoZnpjSHAyTnVtUjFOUWoyWUpac0cy?=
 =?utf-8?B?cGdVeHpkY2Z3UTdheUFKRHAwMzBJdzhTSVo3bjhiMHlmbWlWajFBQUxUenlG?=
 =?utf-8?B?SXlVU3M5RytNbWo5L0dUTk5SdmdzL1phc0xneitEL0EzWnZ4Ymo0dzB3TWsz?=
 =?utf-8?B?OFlDVHdHb0dNbURIWEFSdW5jVk1reEJBT1BnbGtKYmhaTGpqeWZETjd0TkIr?=
 =?utf-8?B?L1BhejNUMjVzTGlWRlNsdmwwTGJGSURwM0drQi9oakxibnBWYlVqZTN6dmhi?=
 =?utf-8?B?YkJqQ2QyTW9JaUNVMlZ4RWNWaEdVWE9PMTB2WWZCWktoV0wyYjRhSmMvNUdo?=
 =?utf-8?B?anQzemJXVy8yUjh5azZ4dW5jYVhxY3hMc0I4aXBWc2ZUQ1RzUnJMeUhWTUZr?=
 =?utf-8?Q?zwh+YnbZ3ajl+D64CCRxW5S3z9dYs/xpI2nBMHk?=
X-MS-Exchange-CrossTenant-Network-Message-Id: d2cd4f7f-c06f-43e0-5782-08d98e5f9612
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2021 15:39:04.2608
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Bc0ltS8rAndrQRWV89qtr/CUUMoThqYUG3L4gIR5Zw/qWPy1NHL0ssmf0rs4DNtW9pJou0QpukhAPbF1aU7OJA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR03MB5997
X-OriginatorOrg: citrix.com

On Thu, Oct 07, 2021 at 09:22:36AM +0200, Jan Beulich wrote:
> On 04.10.2021 07:58, Oleksandr Andrushchenko wrote:
> > 
> > 
> > On 01.10.21 16:26, Jan Beulich wrote:
> >> On 30.09.2021 09:52, Oleksandr Andrushchenko wrote:
> >>> @@ -445,14 +456,25 @@ static void rom_write(const struct pci_dev *pdev, unsigned int reg,
> >>>           rom->addr = val & PCI_ROM_ADDRESS_MASK;
> >>>   }
> >>>   
> >>> -static int add_bar_handlers(const struct pci_dev *pdev)
> >>> +static void guest_rom_write(const struct pci_dev *pdev, unsigned int reg,
> >>> +                            uint32_t val, void *data)
> >>> +{
> >>> +}
> >>> +
> >>> +static uint32_t guest_rom_read(const struct pci_dev *pdev, unsigned int reg,
> >>> +                               void *data)
> >>> +{
> >>> +    return 0xffffffff;
> >>> +}
> >>> +
> >>> +static int add_bar_handlers(const struct pci_dev *pdev, bool is_hwdom)
> >> I remain unconvinced that this boolean is the best way to go here,
> > I can remove "bool is_hwdom" and have the checks like:
> > 
> > static int add_bar_handlers(const struct pci_dev *pdev)
> > {
> > ...
> >      if ( is_hardware_domain(pdev->domain) )
> >          rc = vpci_add_register(pdev->vpci, vpci_hw_read16, cmd_write,
> >                                 PCI_COMMAND, 2, header);
> >      else
> >          rc = vpci_add_register(pdev->vpci, vpci_hw_read16, guest_cmd_write,
> >                                 PCI_COMMAND, 2, header);
> > Is this going to be better?
> 
> Marginally (plus you'd need to prove that pdev->domain can never be NULL
> when making it here).

I think it would an anomaly to try to setup vPCI handlers for a device
without pdev->domain being set. I'm quite sure other vPCI code already
relies on pdev->domain being set.

As I said in another reply I'm not convinced though that splitting
add_bar_handlers is the right thing to do.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Wed Oct 13 15:48:35 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 15:48:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.208691.364916 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1magUX-0000GI-Py; Wed, 13 Oct 2021 15:48:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 208691.364916; Wed, 13 Oct 2021 15:48:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1magUX-0000GB-M6; Wed, 13 Oct 2021 15:48:29 +0000
Received: by outflank-mailman (input) for mailman id 208691;
 Wed, 13 Oct 2021 15:48:28 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=bU9L=PB=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1magUW-0000G5-IK
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 15:48:28 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 0116058d-2c3d-11ec-8183-12813bfff9fa;
 Wed, 13 Oct 2021 15:48:27 +0000 (UTC)
Received: from EUR03-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur03lp2052.outbound.protection.outlook.com [104.47.9.52]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-27-cXRigUsKOTuE2UQm4gsH6Q-1; Wed, 13 Oct 2021 17:48:25 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB5327.eurprd04.prod.outlook.com (2603:10a6:803:5c::23)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18; Wed, 13 Oct
 2021 15:48:24 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.016; Wed, 13 Oct 2021
 15:48:24 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6P195CA0099.EURP195.PROD.OUTLOOK.COM (2603:10a6:209:86::40) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.14 via Frontend Transport; Wed, 13 Oct 2021 15:48:23 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0116058d-2c3d-11ec-8183-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634140106;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=tDu+Xsy6PHEycPNm1o5bLYDgOz/PTFwtVGm4wTu1riY=;
	b=bszy191jY/bU+qjtdGIo4Yax1aU31aEtN6uS7cdXVQoVzhWhxeUcE9Vm/qhAohjFgn5Apc
	QJt4dm39JTWVr6H5tyPvBnc3nCQoJ8jCLfzwQ+zKai+iLvR/4w0D+tdeQe2morAXHRM3pM
	IBdag7BpbucxZX5O++96OIeu7k8I9AQ=
X-MC-Unique: cXRigUsKOTuE2UQm4gsH6Q-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=UxOlNCnDISd0g1n4N6nMvESiHdceBMvBRM9F5TP5cOa9l8dMbJKxdo63TY9tve9iTVhIWCGjImYcZU9ZcakwraWIA3RCAz3DXBTjj2LFJ61trOQfAi+05C6uvzHQOcR3AsT8xvmaaRVEqzRA2SNxhqqCMkdBq7l49TH6F2RPxreaZU6eI8hJ+YRp41u42JJyWBhmjzc9KtrytnqT7BxiE9GsB/1XTDFRGkJ0TVOIp++MA7/bYJpbeU5aw4suhNaD1gIEvurUH5hAlVuPCfCEF5tCZbt3MJNXgWtT3n12KqTqmbzSiDWksppgRJ83ZMXvkApNafhuOsxkAYzSJE+Njw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=tDu+Xsy6PHEycPNm1o5bLYDgOz/PTFwtVGm4wTu1riY=;
 b=grjuJ5r83ITNGrSZHqJV0dAUhtTrLs9WVXUpoPcyZYcregl3Z9j94+XInQ6s/iJxF7hdTore5IHHaQu1jbHdOj6ePSjJb9eSEK2FACHkpmircf/n8rzLHnyFZ7y/ZVsVO5cPbaVJHO8ULdL/jmlzp4n2HXzkfUnatAKYAT7lYxlOJnevS2urqXD6a3Hr/HnU05uKSazM9l9spWpTJRmGZ6PmcwOTRjWhtZAXcESP+ngrnwlW/szbwN3jReVR+BUUIBYb6qTuXpdB2Nvupy+h0wrVdlJztby74mjLcW2nuANb4J6wwNMHGEX0IaRO4vvlTdgkNVEXNcquuis7lGCCGA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [XEN PATCH v7 51/51] build: add %.E targets
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>, xen-devel@lists.xenproject.org
References: <20210824105038.1257926-1-anthony.perard@citrix.com>
 <20210824105038.1257926-52-anthony.perard@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <377d9a27-e09e-38f2-9009-64c0b9e6ace2@suse.com>
Date: Wed, 13 Oct 2021 17:48:22 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <20210824105038.1257926-52-anthony.perard@citrix.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P195CA0099.EURP195.PROD.OUTLOOK.COM
 (2603:10a6:209:86::40) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 9ae0c7fa-ccbe-4dbb-3974-08d98e60e3d7
X-MS-TrafficTypeDiagnostic: VI1PR04MB5327:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB53276F0C159CC3018A4934FAB3B79@VI1PR04MB5327.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:416;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	sK42hc69Z1nk6NdIzIVb51g9M3zjDoH56t+mJn+4oUpx9tVyIT5oB3yDsUPKYpj3Lc2LtRrN3+ti5juolqjhhKyHBzWsy7lpX1D2p3HSXU+Xf0IW8f7F5xw74nHSctyDuzQvbO+qSOTXeb7CljzIiaoW22wrZRZc1lOauYlDdASwzpHbjsAWgw/kjPJRPp18Bvr17fTkPbwJO4K7F7wrFcxh/4zsQGbQ1oY3ccNo0qAHum7Groc4K5Vci6cztc2jO/h7pwssXxcHFeoCPj3T5uMuav5eNItqmCm1Gb7uDwcQqmXG3KeByUc7eAoH2eGV/1XSeEE9AzJzp2w6dY01Xekj6fZYYumt/vZGHXz8il26BMl+UqqYTwu6rN65U5ixwMKkNtAJomB5grEGpPlSBRZlT/VEpsE6YpsOE5mj+Wi3wWm3i0dnVnbdRioNEgeTYTy2lKbi6LP2QlNWaGdWlVs1igbIOl2iYW8JnECzJqxFxJSXoZDW8hpPBioZJ/QnmKAfpXjIQSN+e5/0BbNsyQuLUmTri1FVVvi2ef71kmyFCFbckjiM+nLUe7jiYQwLeoLWq7Zf4+AUR0PHvfmJYnJ2peskoODUwPQ4P/F+tb0M4PtBvzeit2AcP9XfifYIWWsY8UUb2DAUq1MveQKADup783RyyuG26+/4NTBPtMXbJbgkxUGk2OgZktMpVceHh+Z7967cShRtKRVP6BH5toKnTEw8HCqUMZnBXK/eKlOCm27JQUPaFczZ6bSdsuGz
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(4744005)(4326008)(186003)(38100700002)(26005)(31686004)(956004)(8936002)(316002)(6916009)(2616005)(16576012)(53546011)(36756003)(31696002)(6486002)(86362001)(8676002)(54906003)(66946007)(5660300002)(66476007)(66556008)(508600001)(2906002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?dWJtRVRtUlRkVHB6WlNmcVovUUZ5YU9CL1JYcUJNZXI1dkdObXFVK0VRNGxZ?=
 =?utf-8?B?LzNyOFBoY0tiUnlMQTNaalI5THlMWG1xVzloYXNCSFBuZjZJSXJJRkJKc3dE?=
 =?utf-8?B?TlVwanZuc0dvRHgvSlpPcDh2TStqb0JEVjFwMUhjMFFRc3VuMWtPSXlOSU9r?=
 =?utf-8?B?ZFhNaENQSDE4M3NycHdZbUZTZXZUTmF0TmtWbVdWdHdtaENIOU1qNHZhcVFN?=
 =?utf-8?B?V3h4bWNRZkRLNjc3M0lNQTRVaGxVcmlUc2NNVHJjUHNFWHZrR2l4cE5CcDhJ?=
 =?utf-8?B?dURwYWVPeEVCSUZCWWZycS8rRG05SEZBRktEUFRCYytpL0l1dlB5VTMyc25D?=
 =?utf-8?B?RmV4UGN0SXZwRW9sbXJvMyszQitIY01LeCtTcy9jcWtPWXZPaVo5Q0gvQ2tS?=
 =?utf-8?B?UEw4M3lEMnliaWRocXhtVkNVcmxMRkhXcU1iNCtIT21FQ1BrZ1ZxbWlMbW5S?=
 =?utf-8?B?S2cxZFFrWk5tQVpvYlp1cHJZc0ZtUGhGaVk1VGRrRmh2d24rNjBzSFpkVk96?=
 =?utf-8?B?L2srTzRqSDFzVnEvQmV5UXlIN1RBemNKZzJic2lnSW5KdDJ3blB3WHMrUXdD?=
 =?utf-8?B?U2JQSS9IcVM5UkdTL21nL3JoV0ZVOC9OZmJCelRYVFk0T0Mva2N4UjZFWkJy?=
 =?utf-8?B?eElLWCtGYk5QS1JESjMreXlqUTdrZ3ZaNUhoZEpndytMRFVjYXFPcW1oNDZ2?=
 =?utf-8?B?U0xDTXgySnVUNWx1L1B6YTJTNm00QmhqeDlnbDJxdC9uZHN6dnJCUTlWZmty?=
 =?utf-8?B?bGtqUDI4UmhaV1ZXVm44VE1DWWVuNFBHazlvMFlQYUtJMEdpV3VlQklCc1pL?=
 =?utf-8?B?YXQ4dk14VkJrckVGL0NkUHAyRExudjdvVC8wV1oydFd3dWxBOVkwY2dncjAv?=
 =?utf-8?B?MThLTS9WTk1NOWxnNWtRdFF6L2RmVUpyaXhaWWxxbVRqclZCV0szWm84MlZZ?=
 =?utf-8?B?RjMrcVk5MDFDVHB5aWt3TGRlOHJSTlo5T2p5ZzY0dkxUeTU5NUZqRmh3c0tG?=
 =?utf-8?B?cWp2Yk9tWU41SWhHbGlLYUZCNDVmYzZ0WjMvdFBTNTg2dTA2SDFjcWlCbTBB?=
 =?utf-8?B?WDJ3ZFV3b09HQTl2VVlDUVFnSFA2NmdsTE1PM21HdkRGd0JzeWV2WThkdW0z?=
 =?utf-8?B?ZS8yTU5MeDhUalNhd1VueE1UcDlEaE5pQ0hSWWNBRUxEM1o2d2ZtK3AzaXlr?=
 =?utf-8?B?TldLMTFBaVNvMTFUMktRdGc2UER1Qm9KZlV1a1dxTkxWUkpDTWxvMHcybXY3?=
 =?utf-8?B?akJGbjFhb3dQZGM3Z2MxcjhtNms4a3VVV1lNYTlJYlcwS2h4Q0xoMTlCTUNP?=
 =?utf-8?B?RlkzMWhheFVQeGV3dllrdUtQZHdVZjZzYk40UjNOK1JIZHV2Wk5hWC9kZnZN?=
 =?utf-8?B?bXMwMk1yWitRblAyb2JieEZ6ckNyWHpqRmlNaVo2TnNqaCs5WWRralE3eTdQ?=
 =?utf-8?B?dnI2WWhmelVvVmdvcjRxVG5Hdm8veHZGb0tTTGtFMEtTcC9xTnBKNk8rOGZr?=
 =?utf-8?B?bkRxVUtOV0F5cVVjT2hrR2QrMnNHbVVSSEpaTVE0aWpkVjBvYUdQaUtxYVVN?=
 =?utf-8?B?TmNDZC9KUERzeVpsUlVRZnh4cTZ3T1RDK1NJcUdaQVNGck9FTkpFaWFoYy9K?=
 =?utf-8?B?b0h3L3M1MEVpUzBmQzlLWHY5UldvS3FOWkF3dE4zSEN0bFR2NmVKc2ZVdnE5?=
 =?utf-8?B?K1dGSE5XMWhmQU1kZVhWWVNvVTZnU0RwV2FYWkdLazhOenJVMTc5SG5ZNnJR?=
 =?utf-8?Q?+vVNV4351WUUFp9sfmTjLE9X8WtkC7aBy/c8UAd?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9ae0c7fa-ccbe-4dbb-3974-08d98e60e3d7
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2021 15:48:24.1002
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: lQhhL388Jcvn00bWbx1eH8lEkVbfXcHsc0Tnj8L2sw+bXHl6PBtb1bqPhw8hVxpjLQ9hRSHq1XsmQ4+rgSiCsQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5327

On 24.08.2021 12:50, Anthony PERARD wrote:
> I guess it's easier to remember that %.E does "$(CC) -E" or "$(CPP)".

I've never seen any *.E. I'm puzzled (and hence have reservations, but
then again don't care enough to object).

> --- a/xen/Rules.mk
> +++ b/xen/Rules.mk
> @@ -289,6 +289,11 @@ $(obj)/%.s: $(src)/%.c FORCE
>  $(obj)/%.s: $(src)/%.S FORCE
>  	$(call if_changed_dep,cpp_s_S)
>  
> +$(obj)/%.E: $(src)/%.c FORCE
> +	$(call if_changed_dep,cpp_i_c)
> +$(obj)/%.E: $(src)/%.S FORCE
> +	$(call if_changed_dep,cpp_s_S)

It's kind of sad in this case that you can't fold these with the %.i
rules.

Besides the changes you make, don't you also need to adjust some
"clean" rule?

Jan



From xen-devel-bounces@lists.xenproject.org Wed Oct 13 15:49:20 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 15:49:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.208699.364927 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1magVM-0000u0-64; Wed, 13 Oct 2021 15:49:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 208699.364927; Wed, 13 Oct 2021 15:49:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1magVM-0000tt-2t; Wed, 13 Oct 2021 15:49:20 +0000
Received: by outflank-mailman (input) for mailman id 208699;
 Wed, 13 Oct 2021 15:49:19 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=dUCo=PB=gmail.com=olekstysh@srs-us1.protection.inumbo.net>)
 id 1magVL-0000tn-GN
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 15:49:19 +0000
Received: from mail-wr1-x42c.google.com (unknown [2a00:1450:4864:20::42c])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 519353ed-b22e-465c-8b28-b9d4e1e62ede;
 Wed, 13 Oct 2021 15:49:18 +0000 (UTC)
Received: by mail-wr1-x42c.google.com with SMTP id r18so9918904wrg.6
 for <xen-devel@lists.xenproject.org>; Wed, 13 Oct 2021 08:49:18 -0700 (PDT)
Received: from [192.168.1.7] ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id h1sm5599968wmb.7.2021.10.13.08.49.16
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Wed, 13 Oct 2021 08:49:16 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 519353ed-b22e-465c-8b28-b9d4e1e62ede
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-transfer-encoding:content-language;
        bh=7qGKNmUK5wRhgrPP2YOqtUvOXnh7juTN6K4uUXJPHtI=;
        b=lPgdm2K/+OvSPiWXvX1QlQaBCKzPlEfcmc+ET1pvzdP3/L2zY0HQb9C3xAHUec97Oq
         WFXN1dmxeyA8Vnwsq2t956m9T2DOe3UWsRwY05RKXtOzClClTLOVxdHuikOnEdJ3Pj7+
         iMvx0cdKP3rcliQtCOuKqZMZMSevrQo1lGei3laaVbKmwm4ij9Lq6M8ofd3iutaSWZDj
         fmOCFst1Gg/Tn8/Rc0/EEaqVg6HXGAMBAzjZv2282o5LF7RAIz7eiCuFE2OZUCAb5ihD
         lOPDyqiJLKBBtMjTioVsv/eCZLrGuwcSxGQqPJtbLf/uJN86znjXvVSxHugZPtLjq9ud
         9R5Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding
         :content-language;
        bh=7qGKNmUK5wRhgrPP2YOqtUvOXnh7juTN6K4uUXJPHtI=;
        b=3B3ATBdi7mdt0ge0ZsnPCbcDPFmODkyt2fHatXcvxJFVQzm6NUsdTSSIDShj4RopVM
         Yi74m6ZxWnJqlcnGKhVY4NbhVWFbd2ywvbqVfC2OSe/6DvqMJMVQ/pm+/TCvclZ37JOS
         sNuhECNc22PrnUg0GmLrAgCN+HicXc6BP2u1pY5sx/DqXG8m8JI790c5759ea6f9F+A7
         surBrtW0XkkXPoAL0z6pVRtpk/zbvLXcMvWwUI6IkEJA53T4JayAyeE99RfX9H8TJayp
         Vu3cvzhhzfRLjOJWkvnNF1ooliY3zOdSXfneNv9Jb7TZy3sw3qFDEhMGWu8PrOgKnXzq
         V+og==
X-Gm-Message-State: AOAM532C/jzUIvgeK+8lbZ6XWUqDQPaMhm5gZeeH4G4lln5/fDMftLl1
	vPqMlBrbO16or3jjLEQ07uw=
X-Google-Smtp-Source: ABdhPJzfHoqzyzG6pSIKGyb6cJgH1cuuxKSwsl1Hi19313K4OYnlCNNXpRPXbTTlPykaSPhNxzy7lA==
X-Received: by 2002:a1c:e90a:: with SMTP id q10mr51089wmc.108.1634140157395;
        Wed, 13 Oct 2021 08:49:17 -0700 (PDT)
Subject: Re: [PATCH V6 2/2] libxl/arm: Add handling of extended regions for
 DomU
To: Julien Grall <julien@xen.org>
Cc: Ian Jackson <iwj@xenproject.org>, xen-devel@lists.xenproject.org,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, Wei Liu <wl@xen.org>,
 Anthony PERARD <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <1633974539-7380-1-git-send-email-olekstysh@gmail.com>
 <1633974539-7380-3-git-send-email-olekstysh@gmail.com>
 <c98c1acd-86c0-f556-643e-e472b696644f@xen.org>
 <51f9154f-3b65-c7c0-cd93-cecdc2a0975e@gmail.com>
 <641173d4-2629-e4b6-d4ec-06bd629141cc@xen.org>
 <acc06366-b381-daa0-8e2a-54c2761019af@gmail.com>
 <dea074a1-fad2-9b25-5b44-8de23eee83d7@gmail.com>
 <d076afcc-5fde-e83e-1632-371406bdd387@xen.org>
From: Oleksandr <olekstysh@gmail.com>
Message-ID: <1fc5d4ae-1426-0061-a1e8-dd939de30cc3@gmail.com>
Date: Wed, 13 Oct 2021 18:49:16 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <d076afcc-5fde-e83e-1632-371406bdd387@xen.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US


On 13.10.21 18:15, Julien Grall wrote:
> On 13/10/2021 14:46, Oleksandr wrote:
>>
>> Hi Julien
>
> Hi Oleksandr,

Hi Julien


Thank you for the prompt response.


>
>> On 13.10.21 00:43, Oleksandr wrote:
>> diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c
>> index e3140a6..53ae0f3 100644
>> --- a/tools/libs/light/libxl_arm.c
>> +++ b/tools/libs/light/libxl_arm.c
>> @@ -615,9 +615,12 @@ static int make_hypervisor_node(libxl__gc *gc, 
>> void *fdt,
>>                                 "xen,xen");
>>       if (res) return res;
>>
>> -    /* reg 0 is grant table space */
>> +    /*
>> +     * reg 0 is a placeholder for grant table space, reg 1...N are
>> +     * the placeholders for extended regions.
>> +     */
>>       res = fdt_property_regs(gc, fdt, GUEST_ROOT_ADDRESS_CELLS, 
>> GUEST_ROOT_SIZE_CELLS,
>> -                            1,GUEST_GNTTAB_BASE, GUEST_GNTTAB_SIZE);
>> +                            GUEST_RAM_BANKS + 1, 0, 0, 0, 0, 0, 0);
>
> Here you are relying on GUEST_RAM_BANKS == 2. I think this is pretty 
> fragile as this may change in the future.
>
> fdt_property_regs() is not really suitable for here. I would suggest 
> to create a new helper fdt_property_placeholder() which takes the 
> address cells, size cells and the number of ranges. The function will 
> then create N range that are zeroed.

You are right. Probably, we could add an assert here for now to be 
triggered if "GUEST_RAM_BANKS != 2"?
But, if you still think we need to make it with the helper right now, I 
will. However, I don't know how long this will take.


>
>
>>       if (res) return res;
>>
>>       /*
>> @@ -1069,6 +1072,74 @@ static void finalise_one_node(libxl__gc *gc, 
>> void *fdt, const char *uname,
>>       }
>>   }
>>
>> +#define ALIGN_UP_TO_2MB(x)   (((x) + MB(2) - 1) & (~(MB(2) - 1)))
>> +
>> +static void finalise_ext_region(libxl__gc *gc, struct xc_dom_image 
>> *dom)
>
> The function is doing more than finalizing extend regions, it also 
> create the grant table regs. So how about naming it: 
> finalize_hypervisor_node()?

ok, I don't mind.


>
>
>> +{
>> +    void *fdt = dom->devicetree_blob;
>> +    uint64_t region_size[GUEST_RAM_BANKS] = {0}, 
>> region_base[GUEST_RAM_BANKS],
>> +        bankend[GUEST_RAM_BANKS];
>> +    uint32_t regs[(GUEST_ROOT_ADDRESS_CELLS + GUEST_ROOT_SIZE_CELLS) *
>> +                  (GUEST_RAM_BANKS + 1)];
>> +    be32 *cells = &regs[0];
>> +    const uint64_t bankbase[] = GUEST_RAM_BANK_BASES;
>> +    const uint64_t banksize[] = GUEST_RAM_BANK_SIZES;
>> +    unsigned int i, len, nr_regions = 0;
>> +    libxl_dominfo info;
>> +    int offset, rc;
>> +
>> +    offset = fdt_path_offset(fdt, "/hypervisor");
>> +    assert(offset > 0);
>> +
>> +    rc = libxl_domain_info(CTX, &info, dom->guest_domid);
>> +    assert(!rc);
>> +
>> +    assert(info.gpaddr_bits <= 64);
>
> Neither of the two should be assert(). They should be proper check so 
> we don't end up with a disaster (in particularly for the former) if 
> there is a problem.

I looked at the similar finalise_*(), and it looks like no one bothers 
with returning an error. Of course, this is not an excuse, will add a 
proper check.


>
>
>> +
>> +    /*
>> +     * Try to allocate separate 2MB-aligned extended regions from 
>> the first
>> +     * and second RAM banks taking into the account the maximum 
>> supported
>> +     * guest physical address space size and the amount of memory 
>> assigned
>> +     * to the guest.
>> +     */
>> +    for (i = 0; i < GUEST_RAM_BANKS; i++) {
>> +        region_base[i] = bankbase[i] +
>> +            ALIGN_UP_TO_2MB((uint64_t)dom->rambank_size[i] << 
>> XC_PAGE_SHIFT);
>> +
>> +        bankend[i] = ~0ULL >> (64 - info.gpaddr_bits);
>> +        bankend[i] = min(bankend[i], bankbase[i] + banksize[i] - 1);
>> +        if (bankend[i] > region_base[i])
>> +            region_size[i] = bankend[i] - region_base[i] + 1;
>> +    } > +
>> +    /*
>> +     * The region 0 for grant table space must be always present. If 
>> we managed
>> +     * to allocate the extended regions then insert them as regions 
>> 1...N.
>> +     */
>> +    set_range(&cells, GUEST_ROOT_ADDRESS_CELLS, GUEST_ROOT_SIZE_CELLS,
>> +              GUEST_GNTTAB_BASE, GUEST_GNTTAB_SIZE);
>> +
>> +    for (i = 0; i < GUEST_RAM_BANKS; i++) {
>> +        if (region_size[i] < GUEST_EXT_REGION_MIN_SIZE)
>> +            continue;
>> +
>> +        LOG(DEBUG, "Extended region %u: %#"PRIx64"->%#"PRIx64"",
>> +            nr_regions, region_base[i], region_base[i] + 
>> region_size[i]);
>> +
>> +        set_range(&cells, GUEST_ROOT_ADDRESS_CELLS, 
>> GUEST_ROOT_SIZE_CELLS,
>> +                  region_base[i], region_size[i]);
>> +        nr_regions++;
>> +    }
>> +
>> +    if (!nr_regions)
>> +        LOG(WARN, "The extended regions cannot be allocated, not 
>> enough space");
>> +
>> +    len = sizeof(regs[0]) * (GUEST_ROOT_ADDRESS_CELLS + 
>> GUEST_ROOT_SIZE_CELLS) *
>> +        (nr_regions + 1);
>> +    rc = fdt_setprop(fdt, offset, "reg", regs, len);
>> +    assert(!rc);
>
> We should propagate the error.

ok, will propagate, it looks like an upper layer 
libxl__arch_domain_finalise_hw_description() also needs to propagate it.


>
>
>> +}
>> +
>>   int libxl__arch_domain_finalise_hw_description(libxl__gc *gc,
>>                                                  uint32_t domid,
>> libxl_domain_config *d_config,
>> @@ -1109,6 +1180,8 @@ int 
>> libxl__arch_domain_finalise_hw_description(libxl__gc *gc,
>>
>>       }
>>
>> +    finalise_ext_region(gc, dom);
>> +
>>       for (i = 0; i < GUEST_RAM_BANKS; i++) {
>>           const uint64_t size = (uint64_t)dom->rambank_size[i] << 
>> XC_PAGE_SHIFT;
>>
>> diff --git a/xen/include/public/arch-arm.h 
>> b/xen/include/public/arch-arm.h
>> index d46c61f..7425a78 100644
>> --- a/xen/include/public/arch-arm.h
>> +++ b/xen/include/public/arch-arm.h
>> @@ -438,6 +438,11 @@ typedef uint64_t xen_callback_t;
>>
>>   #define GUEST_RAM_BANKS   2
>>
>> +/*
>> + * The way to find the extended regions (to be exposed to the guest 
>> as unused
>> + * address space) relies on the fact that the regions reserved for 
>> the RAM
>> + * below are big enough to also accommodate such regions.
>> + */
>>   #define GUEST_RAM0_BASE   xen_mk_ullong(0x40000000) /* 3GB of low 
>> RAM @ 1GB */
>>   #define GUEST_RAM0_SIZE   xen_mk_ullong(0xc0000000)
>>
>> @@ -451,6 +456,8 @@ typedef uint64_t xen_callback_t;
>>   #define GUEST_RAM_BANK_BASES   { GUEST_RAM0_BASE, GUEST_RAM1_BASE }
>>   #define GUEST_RAM_BANK_SIZES   { GUEST_RAM0_SIZE, GUEST_RAM1_SIZE }
>>
>> +#define GUEST_EXT_REGION_MIN_SIZE   xen_mk_ullong(0x0004000000) /* 
>> 64MB */
>
> I would prefer if this value is not part of the public header because 
> this is not a value that the hypervisor needs to know. So it is better 
> to restrict it to the libxl_arm.c

ok, will do.


-- 
Regards,

Oleksandr Tyshchenko



From xen-devel-bounces@lists.xenproject.org Wed Oct 13 16:10:21 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 16:10:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.208715.364941 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1magpb-0004jI-Vv; Wed, 13 Oct 2021 16:10:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 208715.364941; Wed, 13 Oct 2021 16:10:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1magpb-0004jB-Sh; Wed, 13 Oct 2021 16:10:15 +0000
Received: by outflank-mailman (input) for mailman id 208715;
 Wed, 13 Oct 2021 16:10:14 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=YGme=PB=citrix.com=Andrew.Cooper3@srs-us1.protection.inumbo.net>)
 id 1magpa-0004j5-EJ
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 16:10:14 +0000
Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 0bbf3ec4-2c40-11ec-8185-12813bfff9fa;
 Wed, 13 Oct 2021 16:10:13 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0bbf3ec4-2c40-11ec-8185-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1634141413;
  h=to:cc:references:from:subject:message-id:date:
   in-reply-to:content-transfer-encoding:mime-version;
  bh=5SJhYvrNHs8dPsPRlxElO3xnHWog/XPr6Eh8WvaODZs=;
  b=E7I1oBmYwXEs01V0ayPOHIMiGBPGTlNPSd4qy/b5NUUphkpoSyJiSBjO
   iCfm8hfpiXBQ7y6bCkrBBBWLjsLSYv9JKf1xB6VdN7BFDLgGFjDCjaIQc
   6l9bx8qc8ixVln4tpC3Zuo6o1wD6PGCCWi/yyrB4ImfvROQSE2fcBkCsW
   8=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: q5sgOQAfnF16F1JTc6xesCf3GMydb42NEj2NXliG4LttCOrzEI/rmpcBsYNsT79i38rWdZ21ST
 cIYLQSzPl1bnl6TQOGSz41N/e6q/NXLLl5IybxukVBsNkEJmf31NMT0HatebcaMVbqUC0zliO2
 7MwJoXhNL6Wi3EfpM1kgq5kTxiyRZPt6h3jUUpLzUjwcf2mQ+RtYLCKh6futCuZvmOiBaKFocs
 Q9CaTbmVWkcBfOi6KUHEGOX63YHPniYAqnjR7Bn4mULUpaFHP4STT+l68g/cTLcKsR8AZhnoKI
 cKJkMNQobCbWulZh6nz+ZYjm
X-SBRS: 5.1
X-MesageID: 56989076
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:l0AkDquhcfNmryWX4Bjs4B1WAOfnVKNZMUV32f8akzHdYApBsoF/q
 tZmKWmAMvmDNGr9LtpxOYuwoxgDuJ/QxtU3GVRr/Hw2RihB+JbJXdiXEBz9bniYRiHhoOOLz
 Cm8hv3odp1coqr0/0/1WlTZQP0VOZigHtIQMsadUsxKbVIiGHpJZS5LwbZj29cw2IPhWGthh
 PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe
 gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ
 Npli5KuET9qYJD3nMtaVxhKMnhcHoMB0eqSSZS/mZT7I0zudnLtx7NlDV0sPJ1e8eFyaY1M3
 aVGcnZXNEnF3r/ohuLgIgVvrp1LwM3DFYUToHx/ixreCu4rW8vrSKTW/95Imjw3g6iiGN6DO
 ZtJOGIwMnwsZTUeJwpLAooGzdykl1DkeGxqlkCEh7Uotj27IAtZj+G2bYu9lsaxbdVYmAOUq
 3zL+0z9AwoGL5qPxDyd6HWui+TT2yThV+o6Fre16/pri1273XEIBVsdUl7TieW4j2auVtQZL
 FYbkgIxqYAi+UrtScPyNyBUu1bd4ERaAYAJVbRntkfdkcI4/jp1GEA6QCAZUJ94ifQyansu1
 02oxvHKK3tG5ej9pW2myp+Yqja7OC4wJGAEZDMZQQZt3+QPsL3fnTqUEY49SP/dYsndXGiqm
 WjT/XdWa6A71JZTj82GEUb7byVAT3QjZjU+4RnLRSqb5wd9aZ/Ni2eAuAWDs6gowGp0SDC8U
 Jk4dyq2sL5m4XKlznXlrAAx8FeBvKnt3Nr02w8HInXZ327xk0NPhKgJiN2EGG9nM9wfZRjia
 1LJtAVa6fd7ZSXxMfcpP9jpUZhxkcAM8OgJsNiPMbKihbArJWe6ENxGPxbMjwgBbmB9+U3AB
 XtrWZn1VitLYUiW5DG3W/0cwdcWKtMWngvuqWTA503/i9K2PSfNIZ9caQfmRr1pvcus/VSOm
 /4CZpTi9vmqeLCnCsUh2dVIdg5iwLlSLc2elvG7gcbaelA4Rzp7V6OIqV7jEqQ895loei7z1
 ijVcmdTyUblhG2BLgOPa3t5b6joU4o5pnU+VRHA9370s5T6SYrwvqoZabUterwrqL5qwfJuF
 qFXcMScGPVfDD/A/m1FP5X6qYVjcjWthB6PYHX5MGRuIcY4Slyb4MLgcyvu6DIKUni9u/whr
 uDyzQjcW5cCGVhvVZ6EdPK1wlqtlnEBg+YuDVDQK9xedRy0oohnIiD8lNEtJMQIJUmRzzeWz
 V/OUxwZufPMs8k+99yQ3fKIqIKgEu1fGEtGHjaEsebqZHeCpmf6mN1OSueFezzZRVjYwqT6a
 LUH1ez4Pd0GgE1O79h2HYF0wP9s/NDovbJbkFhpRS2Zc1SxB7p8CXCaxs0T5LZVz7pUtAbqC
 EKC/t5WZeeANM//SQNDIQMkaqKI1O0OmymU5vMweR2o6Chy9buBcENTIxjT13ANcOoraNsok
 bU7pcobyw2jkR57YN+Jgxdd+3mIMnFdAb4ssYsXAdOzhwcmor2YjUcw1sMiDEmzVuhx
IronPort-HdrOrdr: A9a23:wTb1n6gOCQcbZnd5fQcn3vRReXBQX1R13DAbv31ZSRFFG/FwyP
 rAoB1L73PJYWgqNU3I+ergBEGBKUmskKKdkrNhQotKOzOWxFdATbsSkLcKpgePJ8SQzJ8k6U
 4NSdkYNDS0NykBsS+Y2njJLz9D+qj/zEnAv463pB0MPGIaGJ2IrT0JbjpzencGNTWubqBJcq
 Z0iPA3xQZINU5nFfhSURI+Lpb+TpDw5d3biVlsPW9R1CC+yReTrJLqGRmR2RkTFxtJ3LcZ6G
 DA1yj0/L+qvf2XwgLVkza71eUWpPLRjv94QOCcgMkcLTvhzi6ueYRaQrWH+BQ4uvum5loGmM
 TF5z0gI8NwwXXMeXzdm2qi5yDQlBIVr1Pyw16RhnXu5eT/WTIBEsJEwblUdxPIgnBQ9u1U4e
 Zu5Sa0ppBXBRTPkGDW/N7TTSxnkUKyvD4LjfMTp2Y3a/pdVJZh6agkuG9FGpYJGyz3rKo9Fv
 N1Mc3a7PFKNXuHcnHiuHV1ytDEZAVxIv6/eDlHhiWp6UkQoJggpHFogvD3301wtK7VcqM0ot
 gtac9T5ehzpsx/V9M3OA5Oe7ruNoRhKSi8Rl56Gm6XYZ3vDUi946If0I9Flt1CR6Z4uKfauK
 6xHW+w5lRCN34HN6W1rdR2G1b2MT6AYQg=
X-IronPort-AV: E=Sophos;i="5.85,371,1624334400"; 
   d="scan'208";a="56989076"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=KFxEi8dR0syeaJpPNwymdHeWOLnZVr91O2t2xM7pXxDR9l6jT5Ot6+8WqsL2DiJIC18l3lhNQrh7pfQwUJwP+nct8sVLUze08GX2zXfaUaH1s8MhHmfBtzzo4eoz1KlKOb/4mxYPIm3fb6rUiadGwjSmeAiUnFX6veL24/1dkDly4i0NTblKSLbWxzo9ji46wfPPCmYRtxB1q6cFsu1Fet99PmHIBdZ0OdXFNq/2TJh+MYKtYXdGuSotMjmp7cpmclvEB9iE55GeGdkix8BTv1hovJHZEJnP3wLImeqXArOk+cujOKCv2QcOzcjeTaZ62xt7dwu3sfs2ZYckr1d0CA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=5SJhYvrNHs8dPsPRlxElO3xnHWog/XPr6Eh8WvaODZs=;
 b=SQ2n9oXkXrCRXqmdnSRr7g/zGCM4/oZoBydAdt5j8Fw0406GDvpDehFnczm6KAlm8sF4pyW73sXtXFgNLc4kV+MS4q1og/2thr1VFeyxTSYT+l0TtkWdQpT8XfNwRzN/MDbEDMuCapPIrzREqLgvEx/oW4aVT9Wu5r0dnXMufzD52V8uJA8Wb0TAlEjyxhX5oDJ2E216sGWFm9+2QfSSp+9em+jtI5iwTc5oYwxPUjdyxUNyc0ueDVuB1rlBQxAOibp/mrXLNXlgheRj7/qc3vrM4qvUPB5S7qSAdzQxJ/GZQpXodOIGq8aaWTpzNwtJYU2ERTrMUbRgsf7a3PtvGQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=5SJhYvrNHs8dPsPRlxElO3xnHWog/XPr6Eh8WvaODZs=;
 b=cqKJ7StVV3Yo7UGgZDwWllwGAMBujQ/GIEFl8AbJOi3ct454glRCnqJ1JDE7Oy36AOVxHsK5H/TVlgA/ZwG41yRB4TmEb9A3UKCpSNh7+JS6niJ9Jd5hM/e7vawEsACEgLdUfD8SCyPGJJ230FZ9X59xRVaq0hPPSyevVilcyvk=
To: Jan Beulich <jbeulich@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Wei Liu <wl@xen.org>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
	<roger.pau@citrix.com>, Tim Deegan <tim@xen.org>, George Dunlap
	<george.dunlap@citrix.com>
References: <24329000-06d7-2047-b0a1-51b149d19189@suse.com>
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH 0/2] x86/shadow: address two Coverity issues
Message-ID: <ff9639f7-a853-7755-0d5b-5ccf21877cda@citrix.com>
Date: Wed, 13 Oct 2021 17:10:00 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <24329000-06d7-2047-b0a1-51b149d19189@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Content-Language: en-GB
X-ClientProxiedBy: LO4P123CA0486.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:1a8::23) To BYAPR03MB3623.namprd03.prod.outlook.com
 (2603:10b6:a02:aa::12)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: bbcfbd80-9c80-4047-a672-08d98e63ec84
X-MS-TrafficTypeDiagnostic: BYAPR03MB4296:
X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <BYAPR03MB4296609B7BC31C8CEC42F4B1BAB79@BYAPR03MB4296.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: l5fMIxp9wD7p8HuWkBKO7b6Ys4LZc6IBFfwrxWhBzAE8gYxay/OL9WdKB+letfl/H75m4a7QvIeFPmv/fTi6nQRXrgS+aoUbK5/Uf00zmyG+IKVg1Zp/QjVr0jKttqVbnveVeh0jqmiLJQILkMmI6LK14/YnT/1anCs7K7V96zhe8shr6UG5gq/+PJDPgFhhzhAYg80Pwnb+Tl2DyMpGpJIFTgJ8mvMY2M4c/U6Ks5UI8OclkxZSdfA6jOEYpis0m+8SMUVUJCb6UzyL2X3jE1l04LaHGWcfjuwHcfDgiE1K9S+nW+9GtNVvO0OM5N3CrCwPaY7NCkV7aTCxcYLDmCC+GA6lVSgrWlAtex9rH93q9OjyVVF/OpqwzyOfWw6iAAtmcj0Pqqn703GcCNUUhDfuU4CvyAtaz3qEzatKicS8SHlJpEvqMUd+auEAosuNrDUZwaFovWOkyQzCtqgUq0l1Ue6rbN9RuOiIAI1MESYi8vgEoH0mIKqA/p+nb+DP4z4i+bunHfqP0pUDKzyQgWD/x3zog6T5Q1ClU/KtcFaiAxkdttpZ9dB+QLMN9AGtuALSSIyQ339ObPtLOl8tmQHXZfTQeS2GizyY1G6PMHL/Iw+iDis6we/I8vbdbTUR7apRwUD7SA1Ijy657eRaGpDll6i2xQoYg5Lz5cvu04hbYTraRprlD1JV0uIDYt96RU+IE913KmWN5GdD/KtYOq60aQcx3DH4RGh64qexy+U=
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(54906003)(4326008)(8676002)(2906002)(5660300002)(6486002)(38100700002)(53546011)(110136005)(66556008)(66476007)(6666004)(31686004)(66946007)(36756003)(82960400001)(8936002)(16576012)(316002)(508600001)(31696002)(956004)(2616005)(186003)(107886003)(26005)(86362001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cGNtdURCWmJFZTB6enJEREZkSHhVQ1kzY1YvTUIxQzh2eDgxdjd1bzdUQ3Zt?=
 =?utf-8?B?aG5EUTN2Vnp1RTNWb0g3NHBxSVZLTlJ0dTdsWVY3REt4Zkl6Z0xvdFFCSzAy?=
 =?utf-8?B?U2JOUUE4RmF5MnpDM3lpOEJJS1BjbzJTUC9XQlJ6WGYzZEswMDB5ZTdJSGov?=
 =?utf-8?B?VERIWUM4Tm9STDVCRXBFYTg5L0pxaENtU2NEYUE0eFNoUjVlQW01c0JuQzNx?=
 =?utf-8?B?MG44Zm9xTG9zVXc5THErZ3hxTytKa2w5QVkzOW5jZGlmSHZ5R1E4UXBpYUNJ?=
 =?utf-8?B?RmsvNGxBczJ5MWdIWlFwdFpKUEpVTlFPdm4vRmpOMkV0aThuenk3YlJKUEZ2?=
 =?utf-8?B?VktpY0dTeVM5bVNneVhXR09ldkxHODZQdXc0ejdyMFFXanRBRW9KcmR0Z3JR?=
 =?utf-8?B?VW9qVDRadDJlMXJ6REF0bElnWHlwSTdZKzZoQjgwa2c2QVBUaTIrTVNjN3NK?=
 =?utf-8?B?WVpJZFpqenhmejhuRm9aWkdvVnIvVHZzaXNlMklDTHRpTnd0OTZpY1NWeCsy?=
 =?utf-8?B?aGRMUUNFNXFZdlFQVitqdWtGWHRjVm5GUWswT3pJMzZ2dDQvZzMwcTlpSjhF?=
 =?utf-8?B?d085N0R0aUp1eThJdllqcG9pUGQ4dEgvZ0NTaEpwM3dveklsRFBpUHpwMitE?=
 =?utf-8?B?YW1tVi9sWnJuaUZUU0NqaWw5YUV3bDM4Vm9Gd01zL2NIVlZGQ3U0UkpUdWZK?=
 =?utf-8?B?endiYzR0U2NXNVpQdlNOTU8rZll5dHJJTytDUTIwYS84ZXJxd09IeW5xUGtm?=
 =?utf-8?B?UEhTaE02Nk9RNjBGc212YWx2VlBDYUV0M3E1ODYydE1xY0RSMTNxbDhqNUVS?=
 =?utf-8?B?Tmg0VUg2c2ZGQVRTZXpidm56TWNTZUdWZEtRWHhFd2FNV21weWhDbGU3Tzkw?=
 =?utf-8?B?akZpREU5MXpkS2gxM3pZeGhtY2t0NVFzM21HY2lWVmRsR2IxdDY0VGlKSkNM?=
 =?utf-8?B?WWtKMWFqNTQyb2sycWdHOGRmcUUrQWtLUDBkbmV2REtRU3NjaEdwRnBQL3pK?=
 =?utf-8?B?WnlISVdrSHpsakhoOHdPS0hxQWs2ZU5YUE41em1UaWpHVGRXZ0F5U3B1dFZS?=
 =?utf-8?B?YWlERExpNjRrdGFSd1ZJWmZJN3dPV1Ayb011bHF1ZWg1aDNKdE1LSGZrN3Jj?=
 =?utf-8?B?blliTEVsWDRQYkNCcDN3VGRFSnVLbmFvU0hKZ0dGejhlclJVVkJlVW8zSWFG?=
 =?utf-8?B?ajhoblc1S1h0c3Zwb3I3eFRwb2g1YTcvRTZIRU5vRktnd3ZZWUVCeGZLRHly?=
 =?utf-8?B?TGovYTN6TGpoSnV3ZUxUbzA1Qis0SDJtclRlMjdwKzFaRmJEemFkWUNUTjZk?=
 =?utf-8?B?YjEwVjVjS2liT00vQ0ZUWFJVSUZYeStic2FXV0VRNkhxc2NrZk83dmVsMEZu?=
 =?utf-8?B?ZTE2VzNKY2I4bGhPSkJoN2JqLzZJOS9TaWxndzNKTXJGdlYrcjJkVlBPbEFM?=
 =?utf-8?B?Qmh3cUJCUE9iQkZxNVM1aWhEeS9CbGswTXR0YzVVZDZ6a254dktxN2Fnazk1?=
 =?utf-8?B?eXJPOGRtcDd4dFFtMWpqQnN1bzhaeUxRQWR6TmdwZmw1OXI5SkY4RkZmdWtl?=
 =?utf-8?B?c25naTkydmRYQzRHUU1TbS9XNVFpZnJkeEtUUDltNFh6Y1ZuSzF4cUhQVjJk?=
 =?utf-8?B?Mk9YMlVkdlgwbUl6dGJNM3pjenE1RmhKMlZyYklNbWJXTG9JaEp3N09LRVd2?=
 =?utf-8?B?VkpMQjIwNWxGUXVJbkRUejRVMHI1Wjk2bXc5ZU5VYmhVTDlxVFR5c0hkSVU3?=
 =?utf-8?Q?T6nQt0xe4tQLq0/qJ7H2iL2dFoSeGmHdnPBj2gC?=
X-MS-Exchange-CrossTenant-Network-Message-Id: bbcfbd80-9c80-4047-a672-08d98e63ec84
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2021 16:10:07.1778
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: y9Irfyziy5LWWIHqv4HvER8QcE+AlwGr0oCpaVyBnPsYu+Jq4Q8DDZGnjNt5ptJ9RXb6s70Z/fTAFiNlratJO65ml0deK8GE12CqfoGqHyQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB4296
X-OriginatorOrg: citrix.com

On 13/10/2021 16:36, Jan Beulich wrote:
> It's not clear to me why the tool spotted them now and not before,

Several reasons.

The Coverity backend is a software product just like everything else.=C2=A0
IIRC, it releases quarterly.

"If something's free, then you are the product".=C2=A0 The value of offerin=
g
free scanning of open source codebases comes from us (the free users)
integrating a massive corpus of code into Coverity's system, upon which
they can evaluate the effectiveness of new heuristics.


Second, and far more likely in this case, "x86/mm: avoid building
multiple .o from a single .c file".=C2=A0 Coverity has always choked on tha=
t
in Xen, because it's intermediate database is keyed on source file with
latest takes precedent, so we were only seeing the 4-level case previously.


And to also answer your question from patch 1 here, there are upper time
and complexity bounds on all analysis, because scanning is an
exponential problem with the size of the source file.=C2=A0 I don't know
exactly where the cutoffs are, and I fear that some of our larger files
never have later functions looked at.

~Andrew



From xen-devel-bounces@lists.xenproject.org Wed Oct 13 16:17:18 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 16:17:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.208721.364953 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1magwE-0005Om-NP; Wed, 13 Oct 2021 16:17:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 208721.364953; Wed, 13 Oct 2021 16:17:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1magwE-0005Of-Jo; Wed, 13 Oct 2021 16:17:06 +0000
Received: by outflank-mailman (input) for mailman id 208721;
 Wed, 13 Oct 2021 16:17:05 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1magwD-0005OZ-JX
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 16:17:05 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1magwC-0000tF-G9; Wed, 13 Oct 2021 16:17:04 +0000
Received: from 54-240-197-234.amazon.com ([54.240.197.234]
 helo=[192.168.17.188]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1magwC-0005eR-5f; Wed, 13 Oct 2021 16:17:04 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=gO8TnwiFUo07IlO+zqwlumuepsm+ENhZRiA7zthjD44=; b=bjh1lTnUmH97t05PnnTjF4PBKB
	GAw8QUJBveUoX+8ke7YwNuybLdDlOCTqOVqGqFytEp3ewbLwFX1PPNh+SaAqO2v5MgnVn4yEB4ejn
	LzXGN5OMRs40LUq9aLKxORVNHOMAok1xQXeoxaSzscPW8038amizdB5kbczRzIKuQ7IE=;
Message-ID: <f5767857-a80a-fcc2-e70e-ce59ce19c8c9@xen.org>
Date: Wed, 13 Oct 2021 17:17:00 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.2.0
Subject: Re: [PATCH v5 09/10] xen/arm: Do not map PCI ECAM and MMIO space to
 Domain-0's p2m
To: Oleksandr Andrushchenko <andr2000@gmail.com>,
 xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org, oleksandr_tyshchenko@epam.com,
 volodymyr_babchuk@epam.com, Artem_Mygaiev@epam.com, roger.pau@citrix.com,
 jbeulich@suse.com, andrew.cooper3@citrix.com, george.dunlap@citrix.com,
 paul@xen.org, bertrand.marquis@arm.com, rahul.singh@arm.com,
 Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
References: <20211008055535.337436-1-andr2000@gmail.com>
 <20211008055535.337436-10-andr2000@gmail.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20211008055535.337436-10-andr2000@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Oleksandr,

On 08/10/2021 06:55, Oleksandr Andrushchenko wrote:
> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> 
> PCI host bridges are special devices in terms of implementing PCI
> passthrough. According to [1] the current implementation depends on
> Domain-0 to perform the initialization of the relevant PCI host
> bridge hardware and perform PCI device enumeration. In order to
> achieve that one of the required changes is to not map all the memory
> ranges in map_range_to_domain as we traverse the device tree on startup
> and perform some additional checks if the range needs to be mapped to
> Domain-0.
> 
> The generic PCI host controller device tree binding says [2]:
> - ranges: As described in IEEE Std 1275-1994, but must provide
>            at least a definition of non-prefetchable memory. One
>            or both of prefetchable Memory and IO Space may also
>            be provided.
> 
> - reg   : The Configuration Space base address and size, as accessed
>            from the parent bus.  The base address corresponds to
>            the first bus in the "bus-range" property.  If no
>            "bus-range" is specified, this will be bus 0 (the default).
> 
>  From the above none of the memory ranges from the "ranges" property

NIT: The space before "From" looks odd.

> needs to be mapped to Domain-0 at startup as MMIO mapping is going to
> be handled dynamically by vPCI as we assign PCI devices, e.g. each
> device assigned to Domain-0/guest will have its MMIOs mapped/unmapped
> as needed by Xen.
> 
> The "reg" property covers not only ECAM space, but may also have other
> then the configuration memory ranges described, for example [3]:
> - reg: Should contain rc_dbi, config registers location and length.
> - reg-names: Must include the following entries:
>     "rc_dbi": controller configuration registers;
>     "config": PCIe configuration space registers.
> 
> This patch makes it possible to not map all the ranges from the
> "ranges" property and also ECAM from the "reg". All the rest from the
> "reg" property still needs to be mapped to Domain-0, so the PCI
> host bridge remains functional in Domain-0.
> 
> [1] https://lists.xenproject.org/archives/html/xen-devel/2020-07/msg00777.html
> [2] https://www.kernel.org/doc/Documentation/devicetree/bindings/pci/host-generic-pci.txt
> [3] https://www.kernel.org/doc/Documentation/devicetree/bindings/pci/hisilicon-pcie.txt
> 
> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> ---
> Since v4:
> - update skip_mapping comment
> - add comment why we need to map interrupts to Dom0
> Since v3:
>   - pass struct map_range_data to map_dt_irq_to_domain
>   - remove redundant check from map_range_to_domain
>   - fix handle_device's .skip_mapping
> Since v2:
>   - removed check in map_range_to_domain for PCI_DEV
>     and moved it to handle_device, so the code is
>     simpler
>   - s/map_pci_bridge/skip_mapping
>   - extended comment in pci_host_bridge_mappings
>   - minor code restructure in construct_dom0
>   - s/.need_p2m_mapping/.need_p2m_hwdom_mapping and related
>     callbacks
>   - unsigned int i; in pci_host_bridge_mappings
> Since v1:
>   - Added better description of why and what needs to be mapped into
>     Domain-0's p2m and what doesn't
>   - Do not do any mappings for PCI devices while traversing the DT
>   - Walk all the bridges and make required mappings in one go
> ---
>   xen/arch/arm/domain_build.c        | 57 ++++++++++++++++++------------
>   xen/arch/arm/pci/ecam.c            | 14 ++++++++
>   xen/arch/arm/pci/pci-host-common.c | 49 +++++++++++++++++++++++++
>   xen/arch/arm/pci/pci-host-zynqmp.c |  1 +
>   xen/include/asm-arm/pci.h          | 10 ++++++
>   xen/include/asm-arm/setup.h        | 13 +++++++
>   6 files changed, 121 insertions(+), 23 deletions(-)
> 
> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
> index b51176b31bef..0d673b06a2f3 100644
> --- a/xen/arch/arm/domain_build.c
> +++ b/xen/arch/arm/domain_build.c
> @@ -10,7 +10,6 @@
>   #include <asm/regs.h>
>   #include <xen/errno.h>
>   #include <xen/err.h>
> -#include <xen/device_tree.h>
>   #include <xen/libfdt/libfdt.h>
>   #include <xen/guest_access.h>
>   #include <xen/iocap.h>
> @@ -51,12 +50,6 @@ static int __init parse_dom0_mem(const char *s)
>   }
>   custom_param("dom0_mem", parse_dom0_mem);
>   
> -struct map_range_data
> -{
> -    struct domain *d;
> -    p2m_type_t p2mt;
> -};
> -
>   /* Override macros from asm/page.h to make them work with mfn_t */
>   #undef virt_to_mfn
>   #define virt_to_mfn(va) _mfn(__virt_to_mfn(va))
> @@ -1663,10 +1656,11 @@ static int __init map_dt_irq_to_domain(const struct dt_device_node *dev,
>                                          const struct dt_irq *dt_irq,
>                                          void *data)
>   {
> -    struct domain *d = data;
> +    struct map_range_data *mr_data = data;
> +    struct domain *d = mr_data->d;
>       unsigned int irq = dt_irq->irq;
>       int res;
> -    bool need_mapping = !dt_device_for_passthrough(dev);
> +    bool need_mapping = !mr_data->skip_mapping;

Before, the variable 'need_mapping' was helpful to understand what 
!dt_device_for_passthrough(). Now it feels odd to read. There is only 
one user, so can the local variable be dropped?

>   
>       if ( irq < NR_LOCAL_IRQS )
>       {
> @@ -1690,13 +1684,12 @@ static int __init map_dt_irq_to_domain(const struct dt_device_node *dev,
>       return 0;
>   }
>   
> -static int __init map_range_to_domain(const struct dt_device_node *dev,
> -                                      u64 addr, u64 len,
> -                                      void *data)
> +int __init map_range_to_domain(const struct dt_device_node *dev,
> +                               u64 addr, u64 len, void *data)
>   {
>       struct map_range_data *mr_data = data;
>       struct domain *d = mr_data->d;
> -    bool need_mapping = !dt_device_for_passthrough(dev);
> +    bool need_mapping = !mr_data->skip_mapping;

Same here.

>       int res;
>   
>       /*
> @@ -1748,23 +1741,21 @@ static int __init map_range_to_domain(const struct dt_device_node *dev,
>    * then we may need to perform additional mappings in order to make
>    * the child resources available to domain 0.
>    */
> -static int __init map_device_children(struct domain *d,
> -                                      const struct dt_device_node *dev,
> -                                      p2m_type_t p2mt)
> +static int __init map_device_children(const struct dt_device_node *dev,
> +                                      struct map_range_data *mr_data)
>   {
> -    struct map_range_data mr_data = { .d = d, .p2mt = p2mt };
> -    int ret;
> -
>       if ( dt_device_type_is_equal(dev, "pci") )
>       {
> +        int ret;
> +
>           dt_dprintk("Mapping children of %s to guest\n",
>                      dt_node_full_name(dev));
>   
> -        ret = dt_for_each_irq_map(dev, &map_dt_irq_to_domain, d);
> +        ret = dt_for_each_irq_map(dev, &map_dt_irq_to_domain, mr_data);
>           if ( ret < 0 )
>               return ret;
>   
> -        ret = dt_for_each_range(dev, &map_range_to_domain, &mr_data);
> +        ret = dt_for_each_range(dev, &map_range_to_domain, mr_data);
>           if ( ret < 0 )
>               return ret;
>       }
> @@ -1845,6 +1836,20 @@ static int __init handle_device(struct domain *d, struct dt_device_node *dev,
>       int res;
>       u64 addr, size;
>       bool need_mapping = !dt_device_for_passthrough(dev);

I find the difference between .skip_mapping and the local variable 
need_mapping quite puzzling. We are likely going to misuse them in the 
future.

I think it would be clearer if the local variable is renamed to 
'own_device' or similar.

> +    /*
> +     * For PCI passthrough we only need to remap to Dom0 the interrupts
> +     * and memory ranges from "reg" property which cover controller's
> +     * configuration registers and such. PCIe configuration space registers
> +     * of the PCIe Root Complex and PCIe aperture should not be mapped
> +     * automatically to Dom0.
> +     */
> +    struct map_range_data mr_data = {
> +        .d = d,
> +        .p2mt = p2mt,
> +        .skip_mapping = !need_mapping ||
> +                        (is_pci_passthrough_enabled() &&
> +                         (device_get_class(dev) == DEVICE_PCI))

The device class is confusing. When I see DEVICE_PCI, I think this is a 
PCI device whereas here you are referring to the hostbridge.

Unfortunate, I wasn't able to comment on the original patch before it 
was committed. But I would like this to be renamed to 
DEVICE_PCI_HOSTBRIDGE for Xen 4.16. Can you send a patch?

> +    };
>   
>       naddr = dt_number_of_address(dev);
>   
> @@ -1884,7 +1889,6 @@ static int __init handle_device(struct domain *d, struct dt_device_node *dev,
>       /* Give permission and map MMIOs */
>       for ( i = 0; i < naddr; i++ )
>       {
> -        struct map_range_data mr_data = { .d = d, .p2mt = p2mt };
>           res = dt_device_get_address(dev, i, &addr, &size);
>           if ( res )
>           {
> @@ -1898,7 +1902,7 @@ static int __init handle_device(struct domain *d, struct dt_device_node *dev,
>               return res;
>       }
>   
> -    res = map_device_children(d, dev, p2mt);
> +    res = map_device_children(dev, &mr_data);
>       if ( res )
>           return res;
>   
> @@ -3056,7 +3060,14 @@ static int __init construct_dom0(struct domain *d)
>           return rc;
>   
>       if ( acpi_disabled )
> +    {
>           rc = prepare_dtb_hwdom(d, &kinfo);
> +        if ( rc < 0 )
> +            return rc;
> +#ifdef CONFIG_HAS_PCI
> +        rc = pci_host_bridge_mappings(d, p2m_mmio_direct_c);

It is not clear to me why you are passing p2m_mmio_direct_c and not p2mt 
here? If you really want to force a type, then I think it should be 
p2m_mmio_direct.

But then why is it a parameter of pci_host_bridge_mappings? Do you 
expect someone else to modify it?

> +#endif
> +    }
>       else
>           rc = prepare_acpi(d, &kinfo);
>   
> diff --git a/xen/arch/arm/pci/ecam.c b/xen/arch/arm/pci/ecam.c
> index 602d00799c8d..b81620074a91 100644
> --- a/xen/arch/arm/pci/ecam.c
> +++ b/xen/arch/arm/pci/ecam.c
> @@ -40,6 +40,19 @@ void __iomem *pci_ecam_map_bus(struct pci_host_bridge *bridge,
>       return base + (PCI_DEVFN2(sbdf.bdf) << devfn_shift) + where;
>   }
>   
> +bool pci_ecam_need_p2m_hwdom_mapping(struct domain *d,

AFAICT, this is only used by boot code. So you want to do add __init.

This is also exported but not used. I would prefer if we only exposed 
when the first external user will be introduced.

> +                                     struct pci_host_bridge *bridge,
> +                                     uint64_t addr)
> +{
> +    struct pci_config_window *cfg = bridge->cfg;
> +
> +    /*
> +     * We do not want ECAM address space to be mapped in Domain-0's p2m,
> +     * so we can trap access to it.
> +     */
> +    return cfg->phys_addr != addr;
> +}
> +
>   /* ECAM ops */
>   const struct pci_ecam_ops pci_generic_ecam_ops = {
>       .bus_shift  = 20,
> @@ -47,6 +60,7 @@ const struct pci_ecam_ops pci_generic_ecam_ops = {
>           .map_bus                = pci_ecam_map_bus,
>           .read                   = pci_generic_config_read,
>           .write                  = pci_generic_config_write,
> +        .need_p2m_hwdom_mapping = pci_ecam_need_p2m_hwdom_mapping,
>       }
>   };
>   
> diff --git a/xen/arch/arm/pci/pci-host-common.c b/xen/arch/arm/pci/pci-host-common.c
> index 1eb4daa87365..085f08e23e0c 100644
> --- a/xen/arch/arm/pci/pci-host-common.c
> +++ b/xen/arch/arm/pci/pci-host-common.c
> @@ -18,6 +18,7 @@
>   
>   #include <xen/init.h>
>   #include <xen/pci.h>
> +#include <asm/setup.h>

For new code, we usually include xen/*.h first and then asm/*.h. They 
are then order alphabetically within themselves.

>   #include <xen/rwlock.h>
>   #include <xen/sched.h>
>   #include <xen/vmap.h>
> @@ -320,6 +321,54 @@ int pci_host_get_num_bridges(void)
>       return count;
>   }
>   
> +int __init pci_host_bridge_mappings(struct domain *d, p2m_type_t p2mt)
> +{
> +    struct pci_host_bridge *bridge;
> +    struct map_range_data mr_data = {
> +        .d = d,
> +        .p2mt = p2mt,
> +        .skip_mapping = false
> +    };
> +
> +    /*
> +     * For each PCI host bridge we need to only map those ranges
> +     * which are used by Domain-0 to properly initialize the bridge,
> +     * e.g. we do not want to map ECAM configuration space which lives in
> +     * "reg" or "assigned-addresses" device tree property, but we want to

AFAIU, "assigned-addresses" is only relevant for the child of nodes with 
type="pci". This is not the case for the hostbridges. So I think you 
want to drop the mention of "assigned-addresses".


> +     * map other regions of the host bridge. The PCI aperture defined by
> +     * the "ranges" device tree property should also be skipped.
> +     */
> +    list_for_each_entry( bridge, &pci_host_bridges, node )
> +    {
> +        const struct dt_device_node *dev = bridge->dt_node;
> +        unsigned int i;
> +
> +        for ( i = 0; i < dt_number_of_address(dev); i++ )
> +        {
> +            uint64_t addr, size;
> +            int err;
> +
> +            err = dt_device_get_address(dev, i, &addr, &size);
> +            if ( err )
> +            {
> +                printk(XENLOG_ERR
> +                       "Unable to retrieve address range index=%u for %s\n",
> +                       i, dt_node_full_name(dev));
> +                return err;
> +            }
> +
> +            if ( bridge->ops->need_p2m_hwdom_mapping(d, bridge, addr) )
> +            {
> +                err = map_range_to_domain(dev, addr, size, &mr_data);
> +                if ( err )
> +                    return err;
> +            }
> +        }
> +    }
> +
> +    return 0;
> +}
> +
>   /*
>    * Local variables:
>    * mode: C
> diff --git a/xen/arch/arm/pci/pci-host-zynqmp.c b/xen/arch/arm/pci/pci-host-zynqmp.c
> index 61a9807d3d58..6ad2b31e810d 100644
> --- a/xen/arch/arm/pci/pci-host-zynqmp.c
> +++ b/xen/arch/arm/pci/pci-host-zynqmp.c
> @@ -34,6 +34,7 @@ const struct pci_ecam_ops nwl_pcie_ops = {
>           .map_bus                = pci_ecam_map_bus,
>           .read                   = pci_generic_config_read,
>           .write                  = pci_generic_config_write,
> +        .need_p2m_hwdom_mapping = pci_ecam_need_p2m_hwdom_mapping,
>       }
>   };
>   
> diff --git a/xen/include/asm-arm/pci.h b/xen/include/asm-arm/pci.h
> index a71b0eea8cb9..b5b85ccd0937 100644
> --- a/xen/include/asm-arm/pci.h
> +++ b/xen/include/asm-arm/pci.h
> @@ -17,6 +17,8 @@
>   
>   #ifdef CONFIG_HAS_PCI
>   
> +#include <asm/p2m.h>
> +
>   #define pci_to_dev(pcidev) (&(pcidev)->arch.dev)
>   
>   extern bool pci_passthrough_enabled;
> @@ -73,6 +75,9 @@ struct pci_ops {
>                   uint32_t reg, uint32_t len, uint32_t *value);
>       int (*write)(struct pci_host_bridge *bridge, pci_sbdf_t sbdf,
>                    uint32_t reg, uint32_t len, uint32_t value);
> +    bool (*need_p2m_hwdom_mapping)(struct domain *d,
> +                                   struct pci_host_bridge *bridge,
> +                                   uint64_t addr);
>   };
>   
>   /*
> @@ -96,6 +101,9 @@ int pci_generic_config_write(struct pci_host_bridge *bridge, pci_sbdf_t sbdf,
>                                uint32_t reg, uint32_t len, uint32_t value);
>   void __iomem *pci_ecam_map_bus(struct pci_host_bridge *bridge,
>                                  pci_sbdf_t sbdf, uint32_t where);
> +bool pci_ecam_need_p2m_hwdom_mapping(struct domain *d,
> +                                     struct pci_host_bridge *bridge,
> +                                     uint64_t addr);
>   struct pci_host_bridge *pci_find_host_bridge(uint16_t segment, uint8_t bus);
>   int pci_get_host_bridge_segment(const struct dt_device_node *node,
>                                   uint16_t *segment);
> @@ -113,6 +121,8 @@ int pci_host_iterate_bridges(struct domain *d,
>                                           struct pci_host_bridge *bridge));
>   int pci_host_get_num_bridges(void);
>   
> +int pci_host_bridge_mappings(struct domain *d, p2m_type_t p2mt);
> +
>   #else   /*!CONFIG_HAS_PCI*/
>   
>   struct arch_pci_dev { };
> diff --git a/xen/include/asm-arm/setup.h b/xen/include/asm-arm/setup.h
> index 95da0b7ab9cd..88d9673db817 100644
> --- a/xen/include/asm-arm/setup.h
> +++ b/xen/include/asm-arm/setup.h
> @@ -2,6 +2,8 @@
>   #define __ARM_SETUP_H_
>   
>   #include <public/version.h>
> +#include <asm/p2m.h>
> +#include <xen/device_tree.h>
>   
>   #define MIN_FDT_ALIGN 8
>   #define MAX_FDT_SIZE SZ_2M
> @@ -77,6 +79,14 @@ struct bootinfo {
>   #endif
>   };
>   
> +struct map_range_data
> +{
> +    struct domain *d;
> +    p2m_type_t p2mt;
> +    /* Set if mapping of the memory ranges must be skipped. */
> +    bool skip_mapping;
> +};
> +
>   extern struct bootinfo bootinfo;
>   
>   extern domid_t max_init_domid;
> @@ -124,6 +134,9 @@ void device_tree_get_reg(const __be32 **cell, u32 address_cells,
>   u32 device_tree_get_u32(const void *fdt, int node,
>                           const char *prop_name, u32 dflt);
>   
> +int map_range_to_domain(const struct dt_device_node *dev,
> +                        u64 addr, u64 len, void *data);
> +
>   #endif
>   /*
>    * Local variables:
> 

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Oct 13 16:24:25 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 16:24:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.208732.364964 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mah3E-0006uB-Jt; Wed, 13 Oct 2021 16:24:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 208732.364964; Wed, 13 Oct 2021 16:24:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mah3E-0006u4-Fe; Wed, 13 Oct 2021 16:24:20 +0000
Received: by outflank-mailman (input) for mailman id 208732;
 Wed, 13 Oct 2021 16:24:18 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mah3C-0006ty-Ph
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 16:24:18 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mah3B-00011H-G2; Wed, 13 Oct 2021 16:24:17 +0000
Received: from 54-240-197-234.amazon.com ([54.240.197.234]
 helo=[192.168.17.188]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mah3B-0006Fn-9T; Wed, 13 Oct 2021 16:24:17 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=FIghc/byeRq6nh2ely+xot5BXxzU5yD8Ffz37IcjTVc=; b=ITScO1pR94kD7fl+SD7tjRpS2e
	dc9LMVyVigPUf5oBjtlJ5YPUOYK+DnAP2k6I3NC+uDn0Y1av1v3VugdVSA2cWzCGHv30ScCn7IbOf
	tSz4u1K3V4RpIoZKvwSIV9BPpB2jIHev2dyeKY7MNkBt8ACXzKvj3bww+DQp4Cz14fUo=;
Message-ID: <2faf58fa-2e06-635f-27fe-9ba642db27b0@xen.org>
Date: Wed, 13 Oct 2021 17:24:15 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.2.0
Subject: Re: [PATCH V6 2/2] libxl/arm: Add handling of extended regions for
 DomU
To: Oleksandr <olekstysh@gmail.com>
Cc: Ian Jackson <iwj@xenproject.org>, xen-devel@lists.xenproject.org,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, Wei Liu <wl@xen.org>,
 Anthony PERARD <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <1633974539-7380-1-git-send-email-olekstysh@gmail.com>
 <1633974539-7380-3-git-send-email-olekstysh@gmail.com>
 <c98c1acd-86c0-f556-643e-e472b696644f@xen.org>
 <51f9154f-3b65-c7c0-cd93-cecdc2a0975e@gmail.com>
 <641173d4-2629-e4b6-d4ec-06bd629141cc@xen.org>
 <acc06366-b381-daa0-8e2a-54c2761019af@gmail.com>
 <dea074a1-fad2-9b25-5b44-8de23eee83d7@gmail.com>
 <d076afcc-5fde-e83e-1632-371406bdd387@xen.org>
 <1fc5d4ae-1426-0061-a1e8-dd939de30cc3@gmail.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <1fc5d4ae-1426-0061-a1e8-dd939de30cc3@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi Oleksandr,

On 13/10/2021 16:49, Oleksandr wrote:
> 
> On 13.10.21 18:15, Julien Grall wrote:
>> On 13/10/2021 14:46, Oleksandr wrote:
>>>
>>> Hi Julien
>>
>> Hi Oleksandr,
> 
> Hi Julien
> 
> 
> Thank you for the prompt response.
> 
> 
>>
>>> On 13.10.21 00:43, Oleksandr wrote:
>>> diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c
>>> index e3140a6..53ae0f3 100644
>>> --- a/tools/libs/light/libxl_arm.c
>>> +++ b/tools/libs/light/libxl_arm.c
>>> @@ -615,9 +615,12 @@ static int make_hypervisor_node(libxl__gc *gc, 
>>> void *fdt,
>>>                                 "xen,xen");
>>>       if (res) return res;
>>>
>>> -    /* reg 0 is grant table space */
>>> +    /*
>>> +     * reg 0 is a placeholder for grant table space, reg 1...N are
>>> +     * the placeholders for extended regions.
>>> +     */
>>>       res = fdt_property_regs(gc, fdt, GUEST_ROOT_ADDRESS_CELLS, 
>>> GUEST_ROOT_SIZE_CELLS,
>>> -                            1,GUEST_GNTTAB_BASE, GUEST_GNTTAB_SIZE);
>>> +                            GUEST_RAM_BANKS + 1, 0, 0, 0, 0, 0, 0);
>>
>> Here you are relying on GUEST_RAM_BANKS == 2. I think this is pretty 
>> fragile as this may change in the future.
>>
>> fdt_property_regs() is not really suitable for here. I would suggest 
>> to create a new helper fdt_property_placeholder() which takes the 
>> address cells, size cells and the number of ranges. The function will 
>> then create N range that are zeroed.
> 
> You are right. Probably, we could add an assert here for now to be 
> triggered if "GUEST_RAM_BANKS != 2"?
> But, if you still think we need to make it with the helper right now, I 
> will. However, I don't know how long this will take.

I would prefer if we introduce the helper now. Below a potential version 
(not compiled):

diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c
index e3140a6e0039..df59a0521412 100644
--- a/tools/libs/light/libxl_arm.c
+++ b/tools/libs/light/libxl_arm.c
@@ -269,6 +269,20 @@ static int fdt_property_regs(libxl__gc *gc, void *fdt,
      return fdt_property(fdt, "reg", regs, sizeof(regs));
  }

+static int fdt_property_reg_placeholder(libxl__gc *gc, void *fdt,
+                                        unsigned int addr_cells,
+                                        unsigned int size_cells,
+                                        unsigned int num_regs)
+{
+    uint32_t regs[num_regs * (addr_cells + size_cells)];
+
+    for (i = 0 ; i < num_regs; i++) {
+        set_range(&cells, addr_cells, size_cells, 0, 0);
+    }
+
+    return fdt_property(fdt, "reg", regs, sizeof(regs));
+}
+
  static int make_root_properties(libxl__gc *gc,
                                  const libxl_version_info *vers,

>>> +{
>>> +    void *fdt = dom->devicetree_blob;
>>> +    uint64_t region_size[GUEST_RAM_BANKS] = {0}, 
>>> region_base[GUEST_RAM_BANKS],
>>> +        bankend[GUEST_RAM_BANKS];
>>> +    uint32_t regs[(GUEST_ROOT_ADDRESS_CELLS + GUEST_ROOT_SIZE_CELLS) *
>>> +                  (GUEST_RAM_BANKS + 1)];
>>> +    be32 *cells = &regs[0];
>>> +    const uint64_t bankbase[] = GUEST_RAM_BANK_BASES;
>>> +    const uint64_t banksize[] = GUEST_RAM_BANK_SIZES;
>>> +    unsigned int i, len, nr_regions = 0;
>>> +    libxl_dominfo info;
>>> +    int offset, rc;
>>> +
>>> +    offset = fdt_path_offset(fdt, "/hypervisor");
>>> +    assert(offset > 0);
>>> +
>>> +    rc = libxl_domain_info(CTX, &info, dom->guest_domid);
>>> +    assert(!rc);
>>> +
>>> +    assert(info.gpaddr_bits <= 64);
>>
>> Neither of the two should be assert(). They should be proper check so 
>> we don't end up with a disaster (in particularly for the former) if 
>> there is a problem.
> 
> I looked at the similar finalise_*(), and it looks like no one bothers 
> with returning an error. Of course, this is not an excuse, will add a 
> proper check.

This is a bit unfortunate. I would prefer if this can be avoided for new 
code (the more libxl__arch_domain_finalise_hw_description() can already 
propagate the error).

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Oct 13 16:34:52 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 16:34:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.208740.364974 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mahDJ-0008PE-HP; Wed, 13 Oct 2021 16:34:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 208740.364974; Wed, 13 Oct 2021 16:34:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mahDJ-0008P7-EK; Wed, 13 Oct 2021 16:34:45 +0000
Received: by outflank-mailman (input) for mailman id 208740;
 Wed, 13 Oct 2021 16:34:44 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mahDI-0008P1-Jf
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 16:34:44 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mahDI-0001Be-En; Wed, 13 Oct 2021 16:34:44 +0000
Received: from 54-240-197-234.amazon.com ([54.240.197.234]
 helo=[192.168.17.188]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mahDI-0006uG-94; Wed, 13 Oct 2021 16:34:44 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=HbO7PDLIkTbCZEB9v8bz00odlAq8gLSqvLKuSR0uEo8=; b=zsjdmhB9GIUIw1ZIyj3gcbx4Fu
	tJNZLHMUhJfAZveuM1FXYEb0K5lxHvLxVC9nXcKV412goEVxovAIVBvL98yCZHcGiRYfs6zPwyH1e
	gISANVhVJxWMh9AUkjNYVP0GLTA3X95jLVWZWVJe1JalfENdcZr8yUt5XwKTvf++AdZc=;
Message-ID: <61df6501-64a9-1543-5536-aa67e2300863@xen.org>
Date: Wed, 13 Oct 2021 17:34:42 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.2.0
Subject: Re: [PATCH 10/11] xen/arm: device assignment on 1:1 direct-map domain
To: Penny Zheng <Penny.Zheng@arm.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 "sstabellini@kernel.org" <sstabellini@kernel.org>
Cc: Bertrand Marquis <Bertrand.Marquis@arm.com>, Wei Chen <Wei.Chen@arm.com>
References: <20210923031115.1429719-1-penny.zheng@arm.com>
 <20210923031115.1429719-11-penny.zheng@arm.com>
 <c6730ec5-53c7-9bf2-4620-eefbc7c7c4a3@xen.org>
 <VE1PR08MB5215A1D5695F388F17C367D4F7B39@VE1PR08MB5215.eurprd08.prod.outlook.com>
 <9237c85c-87d0-14ac-07ce-244958add7d3@xen.org>
 <VE1PR08MB5215AAFF71A1A6CDE19A50EFF7B79@VE1PR08MB5215.eurprd08.prod.outlook.com>
 <VE1PR08MB5215D0769F05388F43B0F761F7B79@VE1PR08MB5215.eurprd08.prod.outlook.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <VE1PR08MB5215D0769F05388F43B0F761F7B79@VE1PR08MB5215.eurprd08.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Penny,

On 13/10/2021 08:51, Penny Zheng wrote:
> 
>> -----Original Message-----
>> From: Penny Zheng
>> Sent: Wednesday, October 13, 2021 3:44 PM
>> To: Julien Grall <julien@xen.org>; xen-devel@lists.xenproject.org;
>> sstabellini@kernel.org
>> Cc: Bertrand Marquis <Bertrand.Marquis@arm.com>; Wei Chen
>> <Wei.Chen@arm.com>
>> Subject: RE: [PATCH 10/11] xen/arm: device assignment on 1:1 direct-map
>> domain
>>
>> Hi Julien
>>
>>> -----Original Message-----
>>> From: Julien Grall <julien@xen.org>
>>> Sent: Monday, October 11, 2021 7:14 PM
>>> To: Penny Zheng <Penny.Zheng@arm.com>; xen-devel@lists.xenproject.org;
>>> sstabellini@kernel.org
>>> Cc: Bertrand Marquis <Bertrand.Marquis@arm.com>; Wei Chen
>>> <Wei.Chen@arm.com>
>>> Subject: Re: [PATCH 10/11] xen/arm: device assignment on 1:1
>>> direct-map domain
>>>
>>>
>>>
>>> On 09/10/2021 10:40, Penny Zheng wrote:
>>>> Hi Julien
>>>
>>> Hi Penny,
>>>
>>>>
>>>>> -----Original Message-----
>>>>> From: Julien Grall <julien@xen.org>
>>>>> Sent: Thursday, September 23, 2021 7:27 PM
>>>>> To: Penny Zheng <Penny.Zheng@arm.com>;
>>>>> xen-devel@lists.xenproject.org; sstabellini@kernel.org
>>>>> Cc: Bertrand Marquis <Bertrand.Marquis@arm.com>; Wei Chen
>>>>> <Wei.Chen@arm.com>
>>>>> Subject: Re: [PATCH 10/11] xen/arm: device assignment on 1:1
>>>>> direct-map domain
>>>>>
>>>>> Hi,
>>>>>
>>>>> On 23/09/2021 08:11, Penny Zheng wrote:
>>>>>> User could do device passthrough, with
>>>>>> "xen,force-assign-without-iommu" in the device tree snippet, on
>>>>>> trusted guest through 1:1 direct-map, if IOMMU absent or disabled
>>>>>> on
>>>>> hardware.
>>>>>
>>>>> At the moment, it would be possible to passthrough a non-DMA
>>>>> capable device with direct-mapping. After this patch, this is going to be
>> forbidden.
>>>>>
>>>>>>
>>>>>> In order to achieve that, this patch adds 1:1 direct-map check and
>>>>>> disables iommu-related action.
>>>>>>
>>>>>> Signed-off-by: Penny Zheng <penny.zheng@arm.com>
>>>>>> ---
>>>>>>     xen/arch/arm/domain_build.c | 12 ++++++++----
>>>>>>     1 file changed, 8 insertions(+), 4 deletions(-)
>>>>>>
>>>>>> diff --git a/xen/arch/arm/domain_build.c
>>>>>> b/xen/arch/arm/domain_build.c index c92e510ae7..9a9d2522b7 100644
>>>>>> --- a/xen/arch/arm/domain_build.c
>>>>>> +++ b/xen/arch/arm/domain_build.c
>>>>>> @@ -2070,14 +2070,18 @@ static int __init
>>>>> handle_passthrough_prop(struct kernel_info *kinfo,
>>>>>>         if ( res < 0 )
>>>>>>             return res;
>>>>>>
>>>>>> +    /*
>>>>>> +     * If xen_force, we allow assignment of devices without IOMMU
>>>>> protection.
>>>>>> +     * And if IOMMU is disabled or absent, 1:1 direct-map is
>>>>>> + necessary > +
>>>>> */
>>>>>> +    if ( xen_force && is_domain_direct_mapped(kinfo->d) &&
>>>>>> +         !dt_device_is_protected(node) )
>>>>>
>>>>> dt_device_is_protected() will be always false unless the device is
>>>>> protected behing an SMMU using the legacy binding. So I don't think
>>>>> this is correct to move this check ahead. In fact..
>>>>>
>>>>>> +        return 0;
>>>>>> +
>>>>>>         res = iommu_add_dt_device(node);
>>>>>
>>>>> ... the call should already be a NOP when the IOMMU is disabled or
>>>>> the device is not behind an IOMMU. So can you explain what you are
>>>>> trying to prevent here?
>>>>>
>>>>
>>>> If the IOMMU is disabled, iommu_add_dt_device will return 1 as errno.
>>>> So we could not make it to the xen_force check...
>>>
>>> I disagree. The check is:
>>>
>>> if ( res < 0 )
>>>     return res;
>>>
>>> Given that res is 1, we wouldn't return and move to check whether the
>>> assignment can be done.
>>>
>>>>
>>>> So I tried to move all IOMMU action behind xen_force check.
>>>>
>>>> Now, device assignment without IOMMU protection is only applicable
>>>> on direct-map domains,
>>>
>>> It is fine to assign a non-DMA capable device without direct-mapping.
>>> So why do you want to add this restriction?
>>>
>>
>> When constructing direct-map-v2, found that, in
>> xen/arch/arm/domain_build.c
>>
>> if ( dt_find_compatible_node(node, NULL, "multiboot,device-tree") )
>>      d_cfg.flags |= XEN_DOMCTL_CDF_iommu;
>>
>> And this flag XEN_DOMCTL_CDF_iommu determines whether iommu is
>> enabled.
>>
>> In ./xen/include/xen/sched.h
>>
>> static always_inline bool is_iommu_enabled(const struct domain *d) {
>>      return evaluate_nospec(d->options & XEN_DOMCTL_CDF_iommu); }
>>
>> That is, even if we assign a non-DMA capable device, we request the platform
>> to be iommu enabled.
>>
> 
> I intend to change it to
> 
>          if ( dt_find_compatible_node(node, NULL, "multiboot,device-tree") )
>          {
>              if ( iommu_enabled )
>                  d_cfg.flags |= XEN_DOMCTL_CDF_iommu;
>              else if ( d_cfg.flags & XEN_DOMCTL_CDF_directmap )
>                  warning_add("Please be sure of having trusted guests, when doing device assignment without IOMMU protection\n");
>          }

I think the warning is misleading. You don't need to trust a guest in 
order to assign non-DMA capable device.

But, I think the message is not necessary because from my understanding, 
an admin would need to add the property xen,force-assign-without-iommu 
in order to passthrough. So they should be fully aware of the 
consequence to do the passthrough.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Oct 13 16:44:36 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 16:44:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.208748.364985 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mahMm-0001Sj-Fl; Wed, 13 Oct 2021 16:44:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 208748.364985; Wed, 13 Oct 2021 16:44:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mahMm-0001Sc-CU; Wed, 13 Oct 2021 16:44:32 +0000
Received: by outflank-mailman (input) for mailman id 208748;
 Wed, 13 Oct 2021 16:44:31 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=dUCo=PB=gmail.com=olekstysh@srs-us1.protection.inumbo.net>)
 id 1mahMl-0001ST-B9
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 16:44:31 +0000
Received: from mail-wr1-x434.google.com (unknown [2a00:1450:4864:20::434])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id c307d30a-1a34-483b-a6ab-3ab4613b0446;
 Wed, 13 Oct 2021 16:44:29 +0000 (UTC)
Received: by mail-wr1-x434.google.com with SMTP id k7so10308877wrd.13
 for <xen-devel@lists.xenproject.org>; Wed, 13 Oct 2021 09:44:29 -0700 (PDT)
Received: from [192.168.1.7] ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id r9sm71881wrn.95.2021.10.13.09.44.27
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Wed, 13 Oct 2021 09:44:28 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c307d30a-1a34-483b-a6ab-3ab4613b0446
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-transfer-encoding:content-language;
        bh=HQsgPcpNwkbVXghJLqSPvgc74dSDApj4VkUHeZxQA/o=;
        b=Ivzq3d0T+lA7C4Q5hD6UtOqepEFzu6g884JU3pzhMbIniarKeNjrkBMjWZ8hkfwtAp
         sGc5Inut5awDe7/rrCTb6tSr0xsxtQ6V7F51hIZHYupkqSqr4uI5TWVfoiVTXpD1sWeC
         1N9wbBO3IWDN8zOI5uTx93Ar+HByq85N0YTaxW6cIqbBYWEJ6gWrQY1nUMgSNjl6bMDs
         aYRQ88gPKVTtLzF1prLg0HTF7MYn7FnabRoF+xlTP7MBUXPRl6Z7NrwIO8l9kLvqU0Bn
         7LUjjtk/xkflviXFnjIECYvYFVkTR/dGAqFYI+BbCNKMoOK+HQOL83u7kCjRx7yLVvMp
         Cu1w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding
         :content-language;
        bh=HQsgPcpNwkbVXghJLqSPvgc74dSDApj4VkUHeZxQA/o=;
        b=POaXZdvyrXhowyCKohqJ8V+sMdihhrsGzNcjNbQwVSQ9/ZnXQAmmbfcVn5hIPyrAB4
         jpnXIxeBc1Kuz3MCmmKzCjj5tQON0X4X4zJ+q6J7Oc+nK/7p+5JfPapqIFQuinr6faeo
         nzrHxjteMd3J5fwdX/q9EQX6qufY0nMCpZghhNHOgD7RSZCnQdAhY7najpN46hp0EjDy
         DGpSuBRA+YGC0jEhnyG4/xaq17Ikcn3OX1OMVr+NdHU9Z09dHIti5awwHeN8XnWaP+Bn
         Fie/ZrcTvwXqoMn2Dgkffv1I9UdUdNmhbE3FwtRV7sufdfc+Gd7JZZHj7+fOHM93vl2Y
         bdCA==
X-Gm-Message-State: AOAM5313bOWbz0vLRDiWdbuEQ/SGepQCs8NmzWqCZvi5jUslhlbnOdEh
	XyLak9JIJHXC3P3J2hzBqJ0=
X-Google-Smtp-Source: ABdhPJygHK8nZzKTmZHNXlX7FLJyqvslmSQs9TzRPDsxKxipTPyapAc42OtVioEI015/612D8BR9Aw==
X-Received: by 2002:a7b:c393:: with SMTP id s19mr337467wmj.13.1634143468346;
        Wed, 13 Oct 2021 09:44:28 -0700 (PDT)
Subject: Re: [PATCH V6 2/2] libxl/arm: Add handling of extended regions for
 DomU
To: Julien Grall <julien@xen.org>
Cc: Ian Jackson <iwj@xenproject.org>, xen-devel@lists.xenproject.org,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, Wei Liu <wl@xen.org>,
 Anthony PERARD <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <1633974539-7380-1-git-send-email-olekstysh@gmail.com>
 <1633974539-7380-3-git-send-email-olekstysh@gmail.com>
 <c98c1acd-86c0-f556-643e-e472b696644f@xen.org>
 <51f9154f-3b65-c7c0-cd93-cecdc2a0975e@gmail.com>
 <641173d4-2629-e4b6-d4ec-06bd629141cc@xen.org>
 <acc06366-b381-daa0-8e2a-54c2761019af@gmail.com>
 <dea074a1-fad2-9b25-5b44-8de23eee83d7@gmail.com>
 <d076afcc-5fde-e83e-1632-371406bdd387@xen.org>
 <1fc5d4ae-1426-0061-a1e8-dd939de30cc3@gmail.com>
 <2faf58fa-2e06-635f-27fe-9ba642db27b0@xen.org>
From: Oleksandr <olekstysh@gmail.com>
Message-ID: <0125116e-1e8a-8e68-62fb-dfc868ea76d4@gmail.com>
Date: Wed, 13 Oct 2021 19:44:27 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <2faf58fa-2e06-635f-27fe-9ba642db27b0@xen.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US


On 13.10.21 19:24, Julien Grall wrote:
> Hi Oleksandr,

Hi Julien



>
> On 13/10/2021 16:49, Oleksandr wrote:
>>
>> On 13.10.21 18:15, Julien Grall wrote:
>>> On 13/10/2021 14:46, Oleksandr wrote:
>>>>
>>>> Hi Julien
>>>
>>> Hi Oleksandr,
>>
>> Hi Julien
>>
>>
>> Thank you for the prompt response.
>>
>>
>>>
>>>> On 13.10.21 00:43, Oleksandr wrote:
>>>> diff --git a/tools/libs/light/libxl_arm.c 
>>>> b/tools/libs/light/libxl_arm.c
>>>> index e3140a6..53ae0f3 100644
>>>> --- a/tools/libs/light/libxl_arm.c
>>>> +++ b/tools/libs/light/libxl_arm.c
>>>> @@ -615,9 +615,12 @@ static int make_hypervisor_node(libxl__gc *gc, 
>>>> void *fdt,
>>>>                                 "xen,xen");
>>>>       if (res) return res;
>>>>
>>>> -    /* reg 0 is grant table space */
>>>> +    /*
>>>> +     * reg 0 is a placeholder for grant table space, reg 1...N are
>>>> +     * the placeholders for extended regions.
>>>> +     */
>>>>       res = fdt_property_regs(gc, fdt, GUEST_ROOT_ADDRESS_CELLS, 
>>>> GUEST_ROOT_SIZE_CELLS,
>>>> -                            1,GUEST_GNTTAB_BASE, GUEST_GNTTAB_SIZE);
>>>> +                            GUEST_RAM_BANKS + 1, 0, 0, 0, 0, 0, 0);
>>>
>>> Here you are relying on GUEST_RAM_BANKS == 2. I think this is pretty 
>>> fragile as this may change in the future.
>>>
>>> fdt_property_regs() is not really suitable for here. I would suggest 
>>> to create a new helper fdt_property_placeholder() which takes the 
>>> address cells, size cells and the number of ranges. The function 
>>> will then create N range that are zeroed.
>>
>> You are right. Probably, we could add an assert here for now to be 
>> triggered if "GUEST_RAM_BANKS != 2"?
>> But, if you still think we need to make it with the helper right now, 
>> I will. However, I don't know how long this will take.
>
> I would prefer if we introduce the helper now. Below a potential 
> version (not compiled):


You wouldn't believe)))
I decided to not wait for the answer and re-check. So, I ended up with 
the similar to what you suggested below. Thank you.
Yes, it will work if add missing locals. However, I initially named it 
exactly as was suggested (fdt_property_placeholder) and got a 
compilation error, since fdt_property_placeholder is already present.
So, I was thinking to choose another name or to even open-code it, but I 
see you already proposed new name fdt_property_reg_placeholder.

...

libxl_arm.c:366:12: error: conflicting types for 'fdt_property_placeholder'
   366 | static int fdt_property_placeholder(libxl__gc *gc, void *fdt,
       |            ^~~~~~~~~~~~~~~~~~~~~~~~
In file included from libxl_libfdt_compat.h:64,
                  from libxl_arm.c:3:

...


>
> diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c
> index e3140a6e0039..df59a0521412 100644
> --- a/tools/libs/light/libxl_arm.c
> +++ b/tools/libs/light/libxl_arm.c
> @@ -269,6 +269,20 @@ static int fdt_property_regs(libxl__gc *gc, void 
> *fdt,
>      return fdt_property(fdt, "reg", regs, sizeof(regs));
>  }
>
> +static int fdt_property_reg_placeholder(libxl__gc *gc, void *fdt,
> +                                        unsigned int addr_cells,
> +                                        unsigned int size_cells,
> +                                        unsigned int num_regs)
> +{
> +    uint32_t regs[num_regs * (addr_cells + size_cells)];
> +
> +    for (i = 0 ; i < num_regs; i++) {
> +        set_range(&cells, addr_cells, size_cells, 0, 0);
> +    }
> +
> +    return fdt_property(fdt, "reg", regs, sizeof(regs));
> +}
> +
>  static int make_root_properties(libxl__gc *gc,
>                                  const libxl_version_info *vers,
>
>>>> +{
>>>> +    void *fdt = dom->devicetree_blob;
>>>> +    uint64_t region_size[GUEST_RAM_BANKS] = {0}, 
>>>> region_base[GUEST_RAM_BANKS],
>>>> +        bankend[GUEST_RAM_BANKS];
>>>> +    uint32_t regs[(GUEST_ROOT_ADDRESS_CELLS + 
>>>> GUEST_ROOT_SIZE_CELLS) *
>>>> +                  (GUEST_RAM_BANKS + 1)];
>>>> +    be32 *cells = &regs[0];
>>>> +    const uint64_t bankbase[] = GUEST_RAM_BANK_BASES;
>>>> +    const uint64_t banksize[] = GUEST_RAM_BANK_SIZES;
>>>> +    unsigned int i, len, nr_regions = 0;
>>>> +    libxl_dominfo info;
>>>> +    int offset, rc;
>>>> +
>>>> +    offset = fdt_path_offset(fdt, "/hypervisor");
>>>> +    assert(offset > 0);
>>>> +
>>>> +    rc = libxl_domain_info(CTX, &info, dom->guest_domid);
>>>> +    assert(!rc);
>>>> +
>>>> +    assert(info.gpaddr_bits <= 64);
>>>
>>> Neither of the two should be assert(). They should be proper check 
>>> so we don't end up with a disaster (in particularly for the former) 
>>> if there is a problem.
>>
>> I looked at the similar finalise_*(), and it looks like no one 
>> bothers with returning an error. Of course, this is not an excuse, 
>> will add a proper check.
>
> This is a bit unfortunate. I would prefer if this can be avoided for 
> new code (the more libxl__arch_domain_finalise_hw_description() can 
> already propagate the error).
>
> Cheers,
>
-- 
Regards,

Oleksandr Tyshchenko



From xen-devel-bounces@lists.xenproject.org Wed Oct 13 16:51:58 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 16:51:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.208757.364997 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mahTr-0002xH-85; Wed, 13 Oct 2021 16:51:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 208757.364997; Wed, 13 Oct 2021 16:51:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mahTr-0002xA-4k; Wed, 13 Oct 2021 16:51:51 +0000
Received: by outflank-mailman (input) for mailman id 208757;
 Wed, 13 Oct 2021 16:51:49 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=nO85=PB=canonical.com=colin.king@srs-us1.protection.inumbo.net>)
 id 1mahTp-0002x4-KZ
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 16:51:49 +0000
Received: from smtp-relay-canonical-0.canonical.com (unknown [185.125.188.120])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id a4c81883-5fa5-43b7-8664-926cbe58f904;
 Wed, 13 Oct 2021 16:51:48 +0000 (UTC)
Received: from localhost (1.general.cking.uk.vpn [10.172.193.212])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest
 SHA256) (No client certificate requested)
 by smtp-relay-canonical-0.canonical.com (Postfix) with ESMTPSA id F11133FFDC; 
 Wed, 13 Oct 2021 16:51:42 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a4c81883-5fa5-43b7-8664-926cbe58f904
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com;
	s=20210705; t=1634143903;
	bh=nspxtz40p65DZu4TYJBabtEkFf22gqNZfGTLya7Yrd8=;
	h=From:To:Cc:Subject:Date:Message-Id:MIME-Version:Content-Type;
	b=jHQ+xQpZT3ySNZvfc7Mv2IO5uEBq9duWF1MlPWpGZvYeJHiVcz9A7rRAAkuRwsAWD
	 L0aC8QkbNLM/Ovd66WAmrejidVQGrzhN/CM3WyfiuZ67P2/G4AsejdKw/iNfhdcvLf
	 r8uEJeG5anV0ARNJ+4MVgIKMi6VYnOWCUlnwC6OShxeUQqiw8abRiFgcNeSpyHUHCF
	 a0MLlhJasei7LHS5hQPlNdEOtLCQ/Fpytil4ruNAnNd2LOKPm8bLRwLRwztOhSb6zl
	 7fo6dG70HRDukksIb7Qk8FDlv02QO//kgN80AcJNgMvrord248FTEehqNUeiLyynrG
	 vcou6qPyVlE6A==
From: Colin King <colin.king@canonical.com>
To: Wei Liu <wei.liu@kernel.org>,
	Paul Durrant <paul@xen.org>,
	"David S . Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	xen-devel@lists.xenproject.org,
	netdev@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH] xen-netback: Remove redundant initialization of variable err
Date: Wed, 13 Oct 2021 17:51:42 +0100
Message-Id: <20211013165142.135795-1-colin.king@canonical.com>
X-Mailer: git-send-email 2.32.0
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

From: Colin Ian King <colin.king@canonical.com>

The variable err is being initialized with a value that is never read, it
is being updated immediately afterwards. The assignment is redundant and
can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/net/xen-netback/netback.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-netback/netback.c
index 32d5bc4919d8..0f7fd159f0f2 100644
--- a/drivers/net/xen-netback/netback.c
+++ b/drivers/net/xen-netback/netback.c
@@ -1474,7 +1474,7 @@ int xenvif_map_frontend_data_rings(struct xenvif_queue *queue,
 	struct xen_netif_tx_sring *txs;
 	struct xen_netif_rx_sring *rxs;
 	RING_IDX rsp_prod, req_prod;
-	int err = -ENOMEM;
+	int err;
 
 	err = xenbus_map_ring_valloc(xenvif_to_xenbus_device(queue->vif),
 				     &tx_ring_ref, 1, &addr);
-- 
2.32.0



From xen-devel-bounces@lists.xenproject.org Wed Oct 13 17:07:39 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 17:07:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.208766.365008 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mahj2-0004Wy-K8; Wed, 13 Oct 2021 17:07:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 208766.365008; Wed, 13 Oct 2021 17:07:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mahj2-0004Wr-Go; Wed, 13 Oct 2021 17:07:32 +0000
Received: by outflank-mailman (input) for mailman id 208766;
 Wed, 13 Oct 2021 17:07:30 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mahj0-0004Wl-RX
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 17:07:30 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mahiz-0001nr-4S; Wed, 13 Oct 2021 17:07:29 +0000
Received: from 54-240-197-234.amazon.com ([54.240.197.234]
 helo=[192.168.17.188]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mahiy-0005Gc-U2; Wed, 13 Oct 2021 17:07:29 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=hcst5olqKlbj5q+lgEd584L2nOXouMWBWYcaGSZnuqk=; b=PxQpc71aMvgusj6TeN3/zl55TI
	z+Se5cJTS7nX3SWetc6UumSeSHLb7Q9wP+F1aaTZG5YK5N8Gmr3zJJy6kW07X61ZAgiQ3qG4cbugx
	cDCvYPr5WAGqwsbLaMTzklvJ+gB0g3Zzkd77i0UBuJvN8BRYCdCgW9YfiKcTsFO7QNRY=;
Message-ID: <a9b9b16d-daf0-0bd3-cc1b-f3812f670e69@xen.org>
Date: Wed, 13 Oct 2021 18:07:26 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.2.0
Subject: Re: [PATCH V6 2/2] libxl/arm: Add handling of extended regions for
 DomU
To: Oleksandr <olekstysh@gmail.com>
Cc: Ian Jackson <iwj@xenproject.org>, xen-devel@lists.xenproject.org,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, Wei Liu <wl@xen.org>,
 Anthony PERARD <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <1633974539-7380-1-git-send-email-olekstysh@gmail.com>
 <1633974539-7380-3-git-send-email-olekstysh@gmail.com>
 <c98c1acd-86c0-f556-643e-e472b696644f@xen.org>
 <51f9154f-3b65-c7c0-cd93-cecdc2a0975e@gmail.com>
 <641173d4-2629-e4b6-d4ec-06bd629141cc@xen.org>
 <acc06366-b381-daa0-8e2a-54c2761019af@gmail.com>
 <dea074a1-fad2-9b25-5b44-8de23eee83d7@gmail.com>
 <d076afcc-5fde-e83e-1632-371406bdd387@xen.org>
 <1fc5d4ae-1426-0061-a1e8-dd939de30cc3@gmail.com>
 <2faf58fa-2e06-635f-27fe-9ba642db27b0@xen.org>
 <0125116e-1e8a-8e68-62fb-dfc868ea76d4@gmail.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <0125116e-1e8a-8e68-62fb-dfc868ea76d4@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi,

On 13/10/2021 17:44, Oleksandr wrote:
> On 13.10.21 19:24, Julien Grall wrote:
>> On 13/10/2021 16:49, Oleksandr wrote:
>>>
>>> On 13.10.21 18:15, Julien Grall wrote:
>>>> On 13/10/2021 14:46, Oleksandr wrote:
>>>>>
>>>>> Hi Julien
>>>>
>>>> Hi Oleksandr,
>>>
>>> Hi Julien
>>>
>>>
>>> Thank you for the prompt response.
>>>
>>>
>>>>
>>>>> On 13.10.21 00:43, Oleksandr wrote:
>>>>> diff --git a/tools/libs/light/libxl_arm.c 
>>>>> b/tools/libs/light/libxl_arm.c
>>>>> index e3140a6..53ae0f3 100644
>>>>> --- a/tools/libs/light/libxl_arm.c
>>>>> +++ b/tools/libs/light/libxl_arm.c
>>>>> @@ -615,9 +615,12 @@ static int make_hypervisor_node(libxl__gc *gc, 
>>>>> void *fdt,
>>>>>                                 "xen,xen");
>>>>>       if (res) return res;
>>>>>
>>>>> -    /* reg 0 is grant table space */
>>>>> +    /*
>>>>> +     * reg 0 is a placeholder for grant table space, reg 1...N are
>>>>> +     * the placeholders for extended regions.
>>>>> +     */
>>>>>       res = fdt_property_regs(gc, fdt, GUEST_ROOT_ADDRESS_CELLS, 
>>>>> GUEST_ROOT_SIZE_CELLS,
>>>>> -                            1,GUEST_GNTTAB_BASE, GUEST_GNTTAB_SIZE);
>>>>> +                            GUEST_RAM_BANKS + 1, 0, 0, 0, 0, 0, 0);
>>>>
>>>> Here you are relying on GUEST_RAM_BANKS == 2. I think this is pretty 
>>>> fragile as this may change in the future.
>>>>
>>>> fdt_property_regs() is not really suitable for here. I would suggest 
>>>> to create a new helper fdt_property_placeholder() which takes the 
>>>> address cells, size cells and the number of ranges. The function 
>>>> will then create N range that are zeroed.
>>>
>>> You are right. Probably, we could add an assert here for now to be 
>>> triggered if "GUEST_RAM_BANKS != 2"?
>>> But, if you still think we need to make it with the helper right now, 
>>> I will. However, I don't know how long this will take.
>>
>> I would prefer if we introduce the helper now. Below a potential 
>> version (not compiled):
> 
> 
> You wouldn't believe)))
> I decided to not wait for the answer and re-check. So, I ended up with 
> the similar to what you suggested below. Thank you.
> Yes, it will work if add missing locals. However, I initially named it 
> exactly as was suggested (fdt_property_placeholder) and got a 
> compilation error, since fdt_property_placeholder is already present.
> So, I was thinking to choose another name or to even open-code it, but I 
> see you already proposed new name fdt_property_reg_placeholder.

Ah I didn't realize that libfdt already implemented 
fdt_property_placeholder(). The function sounds perfect for us (and the 
code is nicer :)), but unfortunately this was introdcued only in 2017. 
So it is possible that some distros may not ship the last libfdt.

So for now, I think we need to implement our own. In a follow-up we 
could try to provide a compat layer as we did for other missing fdt_* 
helpers.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Oct 13 17:22:50 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 17:22:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.208776.365019 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mahxb-0006vp-39; Wed, 13 Oct 2021 17:22:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 208776.365019; Wed, 13 Oct 2021 17:22:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mahxa-0006vi-Vb; Wed, 13 Oct 2021 17:22:34 +0000
Received: by outflank-mailman (input) for mailman id 208776;
 Wed, 13 Oct 2021 17:22:34 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mahxa-0006vY-Fb; Wed, 13 Oct 2021 17:22:34 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mahxa-00024N-6X; Wed, 13 Oct 2021 17:22:34 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mahxZ-0007qx-TJ; Wed, 13 Oct 2021 17:22:33 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mahxZ-0005Ba-Sm; Wed, 13 Oct 2021 17:22:33 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=sIw3TMXVgYpUJHeMnZ1i3mS+DjbvDxgp0AY9QX8QdoY=; b=lNQ9TRH9ofHtIpK0IVe3J0nm4Q
	ruyYbV661/+Mv0rlVWr6o6IO1Ay3VGkS54ueJKmF/mbtEroDKwd6Ti3zdltADHZfciWvOfS/vUtUf
	LOdY38MjfzoK9KIKcE+b4iitt1z0rXQlr8KYZcm755bVR2B7Q8yyHrOAiTP5oglLrTtU=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165488-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 165488: tolerable FAIL - PUSHED
X-Osstest-Failures:
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=ee26ce674a93c824713542cec3b6a9ca85459165
X-Osstest-Versions-That:
    qemuu=81d8537cb297d57b0897797f1329e4d755a0eaf4
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 13 Oct 2021 17:22:33 +0000

flight 165488 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165488/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165477
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165477
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 165477
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 165477
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 165477
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 165477
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 165477
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165477
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 qemuu                ee26ce674a93c824713542cec3b6a9ca85459165
baseline version:
 qemuu                81d8537cb297d57b0897797f1329e4d755a0eaf4

Last test of basis   165477  2021-10-12 13:37:56 Z    1 days
Testing same since   165488  2021-10-13 02:58:54 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Alex Bennée <alex.bennee@linaro.org>
  Anders Roxell <anders.roxell@linaro.org>
  Daniel P. Berrangé <berrange@redhat.com>
  Helge Deller <deller@gmx.de>
  John Snow <jsnow@redhat.com>
  Lukas Jünger <lukas.junger@greensocs.com>
  Philippe Mathieu-Daudé <f4bug@amsat.org>
  Richard Henderson <richard.henderson@linaro.org>
  Thomas Huth <thuth@redhat.com>
  Willian Rampazzo <willianr@redhat.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/qemu-xen.git
   81d8537cb2..ee26ce674a  ee26ce674a93c824713542cec3b6a9ca85459165 -> upstream-tested


From xen-devel-bounces@lists.xenproject.org Wed Oct 13 18:01:10 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 18:01:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.208789.365033 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maiYq-0002lQ-3u; Wed, 13 Oct 2021 18:01:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 208789.365033; Wed, 13 Oct 2021 18:01:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maiYq-0002lJ-0V; Wed, 13 Oct 2021 18:01:04 +0000
Received: by outflank-mailman (input) for mailman id 208789;
 Wed, 13 Oct 2021 18:01:02 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1maiYo-0002lD-Lo
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 18:01:02 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1maiYo-0002ll-G5; Wed, 13 Oct 2021 18:01:02 +0000
Received: from 54-240-197-234.amazon.com ([54.240.197.234]
 helo=[192.168.17.188]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1maiYo-0000js-2q; Wed, 13 Oct 2021 18:01:02 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=/zE0e0IjBxMOigdiIlk/veYeiEoiG6eV7sf3dDoi1DU=; b=aFQ8p6zn/Tpn4LdgJb16joZS75
	zGPJW1BByBS+xnO9V1BHgah6nBGyMrS7pO3qChCdUeh448SKZ6jYZiTEJepB6wmRNHnjF6yF2nULF
	GAyC9lxCn4cZihfzMsFhDNobZFycz4hVPu4+VH266Un74lBrCN8duI5RUSvvm/QZvFaI=;
Message-ID: <dc216ec4-1aa9-609d-c492-a60c59606c56@xen.org>
Date: Wed, 13 Oct 2021 19:00:59 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.2.0
Subject: Re: [PATCH 09/11] xen/arm: if 1:1 direct-map domain use native UART
 address and IRQ number for vPL011
To: Penny Zheng <Penny.Zheng@arm.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 "sstabellini@kernel.org" <sstabellini@kernel.org>
Cc: Bertrand Marquis <Bertrand.Marquis@arm.com>, Wei Chen <Wei.Chen@arm.com>
References: <20210923031115.1429719-1-penny.zheng@arm.com>
 <20210923031115.1429719-10-penny.zheng@arm.com>
 <db752d34-fc23-04b3-3c84-12d4de6859e0@xen.org>
 <VE1PR08MB5215F07156273D0822515E92F7B39@VE1PR08MB5215.eurprd08.prod.outlook.com>
 <45f31ced-f011-a8fd-5c80-822b9c731adb@xen.org>
 <VE1PR08MB5215C5883D3913F14C6F246AF7B69@VE1PR08MB5215.eurprd08.prod.outlook.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <VE1PR08MB5215C5883D3913F14C6F246AF7B69@VE1PR08MB5215.eurprd08.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 12/10/2021 03:42, Penny Zheng wrote:
> Hi Julien

Hi Penny,

>> -----Original Message-----
>> From: Julien Grall <julien@xen.org>
>> Sent: Monday, October 11, 2021 6:49 PM
>> To: Penny Zheng <Penny.Zheng@arm.com>; xen-devel@lists.xenproject.org;
>> sstabellini@kernel.org
>> Cc: Bertrand Marquis <Bertrand.Marquis@arm.com>; Wei Chen
>> <Wei.Chen@arm.com>
>> Subject: Re: [PATCH 09/11] xen/arm: if 1:1 direct-map domain use native UART
>> address and IRQ number for vPL011
>>
>> On 09/10/2021 09:47, Penny Zheng wrote:
>>> Hi Julien
>>
>> Hi Penny,
>>
>>>> -----Original Message-----
>>>> From: Julien Grall <julien@xen.org>
>>>> Sent: Thursday, September 23, 2021 7:14 PM
>>>> To: Penny Zheng <Penny.Zheng@arm.com>;
>>>> xen-devel@lists.xenproject.org; sstabellini@kernel.org
>>>> Cc: Bertrand Marquis <Bertrand.Marquis@arm.com>; Wei Chen
>>>> <Wei.Chen@arm.com>
>>>> Subject: Re: [PATCH 09/11] xen/arm: if 1:1 direct-map domain use
>>>> native UART address and IRQ number for vPL011
>>>>
>>>>
>>>>
>>>> On 23/09/2021 08:11, Penny Zheng wrote:
>>>>> From: Stefano Stabellini <stefano.stabellini@xilinx.com>
>>>>>
>>>>> We always use a fix address to map the vPL011 to domains. The
>>>>> address could be a problem for domains that are directly mapped.
>>>>>
>>>>> So, for domains that are directly mapped, reuse the address of the
>>>>> physical UART on the platform to avoid potential clashes.
>>>>>
>>>>> Do the same for the virtual IRQ number: instead of always using
>>>>> GUEST_VPL011_SPI, try to reuse the physical SPI number if possible.
>>>>>
>>>>> Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>
>>>>> Signed-off-by: Penny Zheng <penny.zheng@arm.com>
>>>>> ---
>>>>>     xen/arch/arm/domain_build.c  | 34 +++++++++++++++++++++++++++-----
>> --
>>>>>     xen/arch/arm/vpl011.c        | 34 +++++++++++++++++++++++++++-------
>>>>>     xen/include/asm-arm/vpl011.h |  2 ++
>>>>>     3 files changed, 56 insertions(+), 14 deletions(-)
>>>>>
>>>>> diff --git a/xen/arch/arm/domain_build.c
>>>>> b/xen/arch/arm/domain_build.c index 120f1ae575..c92e510ae7 100644
>>>>> --- a/xen/arch/arm/domain_build.c
>>>>> +++ b/xen/arch/arm/domain_build.c
>>>>> @@ -30,6 +30,7 @@
>>>>>
>>>>>     #include <xen/irq.h>
>>>>>     #include <xen/grant_table.h>
>>>>> +#include <xen/serial.h>
>>>>>
>>>>>     static unsigned int __initdata opt_dom0_max_vcpus;
>>>>>     integer_param("dom0_max_vcpus", opt_dom0_max_vcpus); @@ -
>> 1942,8
>>>>> +1943,11 @@ static int __init make_vpl011_uart_node(struct
>>>>> +kernel_info
>>>> *kinfo)
>>>>>         gic_interrupt_t intr;
>>>>>         __be32 reg[GUEST_ROOT_ADDRESS_CELLS +
>> GUEST_ROOT_SIZE_CELLS];
>>>>>         __be32 *cells;
>>>>> +    struct domain *d = kinfo->d;
>>>>> +    char buf[27];
>>>>>
>>>>> -    res = fdt_begin_node(fdt, "sbsa-
>> uart@"__stringify(GUEST_PL011_BASE));
>>>>> +    snprintf(buf, sizeof(buf), "sbsa-uart@%"PRIx64, d-
>>>>> arch.vpl011.base_addr);
>>>>> +    res = fdt_begin_node(fdt, buf);
>>>>>         if ( res )
>>>>>             return res;
>>>>>
>>>>> @@ -1953,14 +1957,14 @@ static int __init
>>>>> make_vpl011_uart_node(struct kernel_info *kinfo)
>>>>>
>>>>>         cells = &reg[0];
>>>>>         dt_child_set_range(&cells, GUEST_ROOT_ADDRESS_CELLS,
>>>>> -                       GUEST_ROOT_SIZE_CELLS, GUEST_PL011_BASE,
>>>>> +                       GUEST_ROOT_SIZE_CELLS,
>>>>> + d->arch.vpl011.base_addr,
>>>>>                            GUEST_PL011_SIZE);
>>>>>
>>>>>         res = fdt_property(fdt, "reg", reg, sizeof(reg));
>>>>>         if ( res )
>>>>>             return res;
>>>>>
>>>>> -    set_interrupt(intr, GUEST_VPL011_SPI, 0xf, DT_IRQ_TYPE_LEVEL_HIGH);
>>>>> +    set_interrupt(intr, d->arch.vpl011.virq, 0xf,
>>>>> + DT_IRQ_TYPE_LEVEL_HIGH);
>>>>>
>>>>>         res = fdt_property(fdt, "interrupts", intr, sizeof (intr));
>>>>>         if ( res )
>>>>> @@ -2670,6 +2674,13 @@ static int __init construct_domU(struct
>>>>> domain
>>>> *d,
>>>>>         else
>>>>>             allocate_static_memory(d, &kinfo, node);
>>>>>
>>>>> +    /*
>>>>> +     * Initialization before creating its device
>>>>> +     * tree node in prepare_dtb_domU.
>>>>> +     */
>>>>
>>>> I think it would be better to explain *why* this needs to be done before.
>>>>
>>>>> +    if ( kinfo.vpl011 )
>>>>> +        rc = domain_vpl011_init(d, NULL);
>>>>> +
>>>>>         rc = prepare_dtb_domU(d, &kinfo);
>>>>>         if ( rc < 0 )
>>>>>             return rc;
>>>>> @@ -2678,9 +2689,6 @@ static int __init construct_domU(struct domain
>>>> *d,
>>>>>         if ( rc < 0 )
>>>>>             return rc;
>>>>>
>>>>> -    if ( kinfo.vpl011 )
>>>>> -        rc = domain_vpl011_init(d, NULL);
>>>>> -
>>>>>         return rc;
>>>>>     }
>>>>>
>>>>> @@ -2723,15 +2731,27 @@ void __init create_domUs(void)
>>>>>
>>>>>             if ( !dt_property_read_u32(node, "nr_spis", &d_cfg.arch.nr_spis) )
>>>>>             {
>>>>> +            unsigned int vpl011_virq = GUEST_VPL011_SPI;
>>>>
>>>> Coding style: Add a newline here.
>>>>
>>>>>                 d_cfg.arch.nr_spis = gic_number_lines() - 32;
>>>>>
>>>>> +            /*
>>>>> +             * The VPL011 virq is GUEST_VPL011_SPI, unless direct-map in
>>>>> +             * set, in which case we'll try to match the hardware.
>>>>> +             *
>>>>> +             * Typically, d->arch.vpl011.virq has the vpl011 irq number
>>>>> +             * but at this point of the boot sequence it is not
>>>>> +             * initialized yet.
>>>>> +             */
>>>>> +            if ( direct_map && serial_irq(SERHND_DTUART) > 0 )
>>>>> +                vpl011_virq = serial_irq(SERHND_DTUART);
>>>>
>>>> I think we should not continue if the domain is direct-mapped *and*
>>>> the IRQ is not found. Otherwise, this will may just result to
>>>> potential breakage if GUEST_VPL011_SPI happens to be used for an HW
>> device.
>>>>
>>>>> +
>>>>>                 /*
>>>>>                  * vpl011 uses one emulated SPI. If vpl011 is requested, make
>>>>>                  * sure that we allocate enough SPIs for it.
>>>>>                  */
>>>>>                 if ( dt_property_read_bool(node, "vpl011") )
>>>>>                     d_cfg.arch.nr_spis = MAX(d_cfg.arch.nr_spis,
>>>>> -                                         GUEST_VPL011_SPI - 32 + 1);
>>>>> +                                         vpl011_virq - 32 + 1);
>>>>>             }
>>>>>
>>>>>             /*
>>>>> diff --git a/xen/arch/arm/vpl011.c b/xen/arch/arm/vpl011.c index
>>>>> 895f436cc4..10df25f098 100644
>>>>> --- a/xen/arch/arm/vpl011.c
>>>>> +++ b/xen/arch/arm/vpl011.c
>>>>> @@ -29,6 +29,7 @@
>>>>>     #include <xen/mm.h>
>>>>>     #include <xen/sched.h>
>>>>>     #include <xen/console.h>
>>>>> +#include <xen/serial.h>
>>>>>     #include <public/domctl.h>
>>>>>     #include <public/io/console.h>
>>>>>     #include <asm/pl011-uart.h>
>>>>> @@ -71,11 +72,11 @@ static void
>>>>> vpl011_update_interrupt_status(struct
>>>> domain *d)
>>>>>          * status bit has been set since the last time.
>>>>>          */
>>>>>         if ( uartmis & ~vpl011->shadow_uartmis )
>>>>> -        vgic_inject_irq(d, NULL, GUEST_VPL011_SPI, true);
>>>>> +        vgic_inject_irq(d, NULL, vpl011->virq, true);
>>>>>
>>>>>         vpl011->shadow_uartmis = uartmis;
>>>>>     #else
>>>>> -    vgic_inject_irq(d, NULL, GUEST_VPL011_SPI, uartmis);
>>>>> +    vgic_inject_irq(d, NULL, vpl011->virq, uartmis);
>>>>>     #endif
>>>>>     }
>>>>>
>>>>> @@ -347,7 +348,8 @@ static int vpl011_mmio_read(struct vcpu *v,
>>>>>                                 void *priv)
>>>>>     {
>>>>>         struct hsr_dabt dabt = info->dabt;
>>>>> -    uint32_t vpl011_reg = (uint32_t)(info->gpa - GUEST_PL011_BASE);
>>>>> +    uint32_t vpl011_reg = (uint32_t)(info->gpa -
>>>>> +
>>>>> + v->domain->arch.vpl011.base_addr);
>>>>>         struct vpl011 *vpl011 = &v->domain->arch.vpl011;
>>>>>         struct domain *d = v->domain;
>>>>>         unsigned long flags;
>>>>> @@ -430,7 +432,8 @@ static int vpl011_mmio_write(struct vcpu *v,
>>>>>                                  void *priv)
>>>>>     {
>>>>>         struct hsr_dabt dabt = info->dabt;
>>>>> -    uint32_t vpl011_reg = (uint32_t)(info->gpa - GUEST_PL011_BASE);
>>>>> +    uint32_t vpl011_reg = (uint32_t)(info->gpa -
>>>>> +
>>>>> + v->domain->arch.vpl011.base_addr);
>>>>>         struct vpl011 *vpl011 = &v->domain->arch.vpl011;
>>>>>         struct domain *d = v->domain;
>>>>>         unsigned long flags;
>>>>> @@ -622,10 +625,27 @@ int domain_vpl011_init(struct domain *d,
>>>>> struct
>>>> vpl011_init_info *info)
>>>>>     {
>>>>>         int rc;
>>>>>         struct vpl011 *vpl011 = &d->arch.vpl011;
>>>>> +    const struct vuart_info *uart =
>>>>> + serial_vuart_info(SERHND_DTUART);
>>>>>
>>>>>         if ( vpl011->backend.dom.ring_buf )
>>>>>             return -EINVAL;
>>>>>
>>>>> +    vpl011->base_addr = GUEST_PL011_BASE;
>>>>> +    vpl011->virq = GUEST_VPL011_SPI;
>>>>> +    if ( is_domain_direct_mapped(d) )
>>>>> +    {
>>>>> +        if ( uart != NULL && serial_irq(SERHND_DTUART) > 0 )
>>>>> +        {
>>>>> +            vpl011->base_addr = uart->base_addr;
>>>>> +            vpl011->virq = serial_irq(SERHND_DTUART);
>>>>
>>>> This seems a bit pointless to call serial_irq() twice. How about add
>>>> a field in vuart_info to return the interrupt number?
>>>>
>>>>> +        }
>>>>> +        else
>>>>> +            printk(XENLOG_ERR
>>>>> +                   "Unable to reuse physical UART address and irq for vPL011.\n"
>>>>> +                   "Defaulting to addr %#"PRIpaddr" and IRQ %u\n",
>>>>> +                   vpl011->base_addr, vpl011->virq);
>>>>> +    }
>>>>> +
>>>>>         /*
>>>>>          * info is NULL when the backend is in Xen.
>>>>>          * info is != NULL when the backend is in a domain.
>>>>> @@ -661,7 +681,7 @@ int domain_vpl011_init(struct domain *d, struct
>>>> vpl011_init_info *info)
>>>>>             }
>>>>>         }
>>>>>
>>>>> -    rc = vgic_reserve_virq(d, GUEST_VPL011_SPI);
>>>>> +    rc = vgic_reserve_virq(d, vpl011->virq);
>>>>>         if ( !rc )
>>>>>         {
>>>>>             rc = -EINVAL;
>>>>> @@ -673,12 +693,12 @@ int domain_vpl011_init(struct domain *d,
>>>>> struct
>>>> vpl011_init_info *info)
>>>>>         spin_lock_init(&vpl011->lock);
>>>>>
>>>>>         register_mmio_handler(d, &vpl011_mmio_handler,
>>>>> -                          GUEST_PL011_BASE, GUEST_PL011_SIZE, NULL);
>>>>> +                          vpl011->base_addr, GUEST_PL011_SIZE,
>>>>> + NULL);
>>>>
>>>> So you are making the assumpption that the UART region will be equal
>>>> to (or
>>>> bigger) than GUEST_PL011_SIZE. There are definitely UART out where
>>>> the MMIO region is smaller than 4K.
>>>>
>>>
>>> Sorry. I got a few confused here, since I am not very familiar with pl011/UART
>> knowledge.
>>>
>>> Problems will occur when UART region is bigger than GUEST_PL011_SIZE,
>>> since we are only considering MMIO region of [vpl011->base_addr, vpl011-
>>> base_addr + GUEST_PL011_SIZE], right?
>>
>> It is in fact the other way around. The problem will appear if the host UART
>> MMIO region is smaller than the one we will emulate for the guest PL011.
>>
> 
> Sorry to keep bothering.
> Is it that because when the UART MMIO region is smaller than the one we emulated,
> register(DR, RSR, FR, ...) will not be at the place where we emulated?

Let me give an example to clarify my point. On some Hardware (IIRC 
pine64), the UART MMIO region is less than 4KB. In fact, there are 
multiple device within the same 4KB region.

At the moment, we are removing those devices because we can't assign to 
a domain a region that is not page aligned (4KB today). But I can see 
some benefits to be able to assign such devices to different domain/xen. 
To support them, we would need to trap the region and then forward only 
access to address the domain can access.

The PL011 we emulate for the guest require a 4KB region. So this would 
overlap with other device in the same region we may want to trap.

For is not an issue for the reasons I mentionned above. However, I think 
it is a good idea to harden the code and add a check/comment when we 
know potential pitfalls.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Oct 13 18:27:02 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 18:27:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.208800.365044 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maixp-0005Fm-AC; Wed, 13 Oct 2021 18:26:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 208800.365044; Wed, 13 Oct 2021 18:26:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maixp-0005Ff-70; Wed, 13 Oct 2021 18:26:53 +0000
Received: by outflank-mailman (input) for mailman id 208800;
 Wed, 13 Oct 2021 18:26:51 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=dUCo=PB=gmail.com=olekstysh@srs-us1.protection.inumbo.net>)
 id 1maixn-0005FX-91
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 18:26:51 +0000
Received: from mail-wr1-x435.google.com (unknown [2a00:1450:4864:20::435])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 9bcd2b88-df8c-47b9-9187-89007cbe67c7;
 Wed, 13 Oct 2021 18:26:49 +0000 (UTC)
Received: by mail-wr1-x435.google.com with SMTP id k7so11209234wrd.13
 for <xen-devel@lists.xenproject.org>; Wed, 13 Oct 2021 11:26:49 -0700 (PDT)
Received: from [192.168.1.7] ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id b10sm272867wrf.68.2021.10.13.11.26.47
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Wed, 13 Oct 2021 11:26:47 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9bcd2b88-df8c-47b9-9187-89007cbe67c7
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-transfer-encoding:content-language;
        bh=FSXYfW7vbL0TfoMez0kWDc82rFZ6EANyRgZZY0ujE7Q=;
        b=XNrutYiC+70bblwdiOSDUHARwoc4ZP7TnS7jIFTt+UtZEIfX6O3UEvAoU4yRBOECsd
         zu+5aXre/uhoL4Gb/K+sj4z1lwRWw/IzXR1ICO6mfjfJIoNOy/iub5Oj9qQg/6SYdGwU
         DygXjsLbifkhFs7her298PM8tyujJW5Om1haFmCFW3+w3ucb8pvszPf9FcnXBrgiA/oR
         a/kcjamKIAl9Iu79O7BVuuRy2hV5X7D1vbPo+ouA1kvWgrtb/DzVhxcejC+303vFsxif
         EId8jFy8GasDH6FaaEH3Uhva9NpHyYlCkutaXDVv6+fAe5V7gn8mkTXDMpDBOEthK04C
         8yQQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding
         :content-language;
        bh=FSXYfW7vbL0TfoMez0kWDc82rFZ6EANyRgZZY0ujE7Q=;
        b=JbnFOYmsAHKaiU+TRtUWJLrunlF9JbvWltDQOEo989qMFhxL3+nqS95Jv33ivO7OnL
         t02NAseOcapQxqBIATio1BktZNBKUSrnPWIxaePjqGwFdmYMokLDECfwGOgHA3f7mBmI
         MG8vyx6svixhkh2CUENaSxAdv4VC7CJIzrV5myhyb5QpXf84rD6Sql0Tg51SVsrmIX21
         9MC8p7jG/dXTXa2fe2uvelBcVgt+FSPaT1AxFBynRVk1diebcGdtxndWde5JIoNsETfe
         YZyEMsvA275Mz1056MhUTRIU21scDXFZ0YK+SWSyEoN5dKMw2Bl3H5yQH6H6R5d1XzeZ
         Apzw==
X-Gm-Message-State: AOAM532jNkukPQG+D0ZaviQAzjXjDGq81yLefsGV7ZQHg0Xt7fznZ5/1
	+EuWNQD55DAi6Y9kkbPEwPw=
X-Google-Smtp-Source: ABdhPJzrEL2Ywa/QkRlzTvgxy1WZwHPjL0xIdhUqM7ZYpQqczbxECIYDDxlfZp0pGt+Q+H7kYbt1Ow==
X-Received: by 2002:a7b:c76b:: with SMTP id x11mr873969wmk.83.1634149608524;
        Wed, 13 Oct 2021 11:26:48 -0700 (PDT)
Subject: Re: [PATCH V6 2/2] libxl/arm: Add handling of extended regions for
 DomU
To: Julien Grall <julien@xen.org>
Cc: Ian Jackson <iwj@xenproject.org>, xen-devel@lists.xenproject.org,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, Wei Liu <wl@xen.org>,
 Anthony PERARD <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <1633974539-7380-1-git-send-email-olekstysh@gmail.com>
 <1633974539-7380-3-git-send-email-olekstysh@gmail.com>
 <c98c1acd-86c0-f556-643e-e472b696644f@xen.org>
 <51f9154f-3b65-c7c0-cd93-cecdc2a0975e@gmail.com>
 <641173d4-2629-e4b6-d4ec-06bd629141cc@xen.org>
 <acc06366-b381-daa0-8e2a-54c2761019af@gmail.com>
 <dea074a1-fad2-9b25-5b44-8de23eee83d7@gmail.com>
 <d076afcc-5fde-e83e-1632-371406bdd387@xen.org>
 <1fc5d4ae-1426-0061-a1e8-dd939de30cc3@gmail.com>
 <2faf58fa-2e06-635f-27fe-9ba642db27b0@xen.org>
 <0125116e-1e8a-8e68-62fb-dfc868ea76d4@gmail.com>
 <a9b9b16d-daf0-0bd3-cc1b-f3812f670e69@xen.org>
From: Oleksandr <olekstysh@gmail.com>
Message-ID: <b2285058-360d-ebef-836e-5b87658e8847@gmail.com>
Date: Wed, 13 Oct 2021 21:26:46 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <a9b9b16d-daf0-0bd3-cc1b-f3812f670e69@xen.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US


On 13.10.21 20:07, Julien Grall wrote:

Hi Julien

> Hi,
>
> On 13/10/2021 17:44, Oleksandr wrote:
>> On 13.10.21 19:24, Julien Grall wrote:
>>> On 13/10/2021 16:49, Oleksandr wrote:
>>>>
>>>> On 13.10.21 18:15, Julien Grall wrote:
>>>>> On 13/10/2021 14:46, Oleksandr wrote:
>>>>>>
>>>>>> Hi Julien
>>>>>
>>>>> Hi Oleksandr,
>>>>
>>>> Hi Julien
>>>>
>>>>
>>>> Thank you for the prompt response.
>>>>
>>>>
>>>>>
>>>>>> On 13.10.21 00:43, Oleksandr wrote:
>>>>>> diff --git a/tools/libs/light/libxl_arm.c 
>>>>>> b/tools/libs/light/libxl_arm.c
>>>>>> index e3140a6..53ae0f3 100644
>>>>>> --- a/tools/libs/light/libxl_arm.c
>>>>>> +++ b/tools/libs/light/libxl_arm.c
>>>>>> @@ -615,9 +615,12 @@ static int make_hypervisor_node(libxl__gc 
>>>>>> *gc, void *fdt,
>>>>>>                                 "xen,xen");
>>>>>>       if (res) return res;
>>>>>>
>>>>>> -    /* reg 0 is grant table space */
>>>>>> +    /*
>>>>>> +     * reg 0 is a placeholder for grant table space, reg 1...N are
>>>>>> +     * the placeholders for extended regions.
>>>>>> +     */
>>>>>>       res = fdt_property_regs(gc, fdt, GUEST_ROOT_ADDRESS_CELLS, 
>>>>>> GUEST_ROOT_SIZE_CELLS,
>>>>>> -                            1,GUEST_GNTTAB_BASE, 
>>>>>> GUEST_GNTTAB_SIZE);
>>>>>> +                            GUEST_RAM_BANKS + 1, 0, 0, 0, 0, 0, 0);
>>>>>
>>>>> Here you are relying on GUEST_RAM_BANKS == 2. I think this is 
>>>>> pretty fragile as this may change in the future.
>>>>>
>>>>> fdt_property_regs() is not really suitable for here. I would 
>>>>> suggest to create a new helper fdt_property_placeholder() which 
>>>>> takes the address cells, size cells and the number of ranges. The 
>>>>> function will then create N range that are zeroed.
>>>>
>>>> You are right. Probably, we could add an assert here for now to be 
>>>> triggered if "GUEST_RAM_BANKS != 2"?
>>>> But, if you still think we need to make it with the helper right 
>>>> now, I will. However, I don't know how long this will take.
>>>
>>> I would prefer if we introduce the helper now. Below a potential 
>>> version (not compiled):
>>
>>
>> You wouldn't believe)))
>> I decided to not wait for the answer and re-check. So, I ended up 
>> with the similar to what you suggested below. Thank you.
>> Yes, it will work if add missing locals. However, I initially named 
>> it exactly as was suggested (fdt_property_placeholder) and got a 
>> compilation error, since fdt_property_placeholder is already present.
>> So, I was thinking to choose another name or to even open-code it, 
>> but I see you already proposed new name fdt_property_reg_placeholder.
>
> Ah I didn't realize that libfdt already implemented 
> fdt_property_placeholder(). The function sounds perfect for us (and 
> the code is nicer :)), but unfortunately this was introdcued only in 
> 2017. So it is possible that some distros may not ship the last libfdt.
>
> So for now, I think we need to implement our own. In a follow-up we 
> could try to provide a compat layer as we did for other missing fdt_* 
> helpers.
>
> Cheers,


Well, I hope that I addressed all your comments. If so, I will prepare V7.


diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c
index e3140a6..a780155 100644
--- a/tools/libs/light/libxl_arm.c
+++ b/tools/libs/light/libxl_arm.c
@@ -269,6 +269,21 @@ static int fdt_property_regs(libxl__gc *gc, void *fdt,
      return fdt_property(fdt, "reg", regs, sizeof(regs));
  }

+static int fdt_property_reg_placeholder(libxl__gc *gc, void *fdt,
+                                        unsigned int addr_cells,
+                                        unsigned int size_cells,
+                                        unsigned int num_regs)
+{
+    uint32_t regs[num_regs * (addr_cells + size_cells)];
+    be32 *cells = &regs[0];
+    unsigned int i;
+
+    for (i = 0; i < num_regs; i++)
+        set_range(&cells, addr_cells, size_cells, 0, 0);
+
+    return fdt_property(fdt, "reg", regs, sizeof(regs));
+}
+
  static int make_root_properties(libxl__gc *gc,
                                  const libxl_version_info *vers,
                                  void *fdt)
@@ -615,9 +630,13 @@ static int make_hypervisor_node(libxl__gc *gc, void 
*fdt,
                                "xen,xen");
      if (res) return res;

-    /* reg 0 is grant table space */
-    res = fdt_property_regs(gc, fdt, GUEST_ROOT_ADDRESS_CELLS, 
GUEST_ROOT_SIZE_CELLS,
-                            1,GUEST_GNTTAB_BASE, GUEST_GNTTAB_SIZE);
+    /*
+     * reg 0 is a placeholder for grant table space, reg 1...N are
+     * the placeholders for extended regions.
+     */
+    res = fdt_property_reg_placeholder(gc, fdt, GUEST_ROOT_ADDRESS_CELLS,
+                                       GUEST_ROOT_SIZE_CELLS,
+                                       GUEST_RAM_BANKS + 1);
      if (res) return res;

      /*
@@ -1069,20 +1088,93 @@ static void finalise_one_node(libxl__gc *gc, 
void *fdt, const char *uname,
      }
  }

+#define ALIGN_UP_TO_2MB(x)   (((x) + MB(2) - 1) & (~(MB(2) - 1)))
+
+#define EXT_REGION_MIN_SIZE   xen_mk_ullong(0x0004000000) /* 64MB */
+
+static int finalize_hypervisor_node(libxl__gc *gc, struct xc_dom_image 
*dom)
+{
+    void *fdt = dom->devicetree_blob;
+    uint64_t region_size[GUEST_RAM_BANKS] = {0}, 
region_base[GUEST_RAM_BANKS],
+        bankend[GUEST_RAM_BANKS];
+    uint32_t regs[(GUEST_ROOT_ADDRESS_CELLS + GUEST_ROOT_SIZE_CELLS) *
+                  (GUEST_RAM_BANKS + 1)];
+    be32 *cells = &regs[0];
+    const uint64_t bankbase[] = GUEST_RAM_BANK_BASES;
+    const uint64_t banksize[] = GUEST_RAM_BANK_SIZES;
+    unsigned int i, len, nr_regions = 0;
+    libxl_dominfo info;
+    int offset, rc;
+
+    offset = fdt_path_offset(fdt, "/hypervisor");
+    if (offset < 0)
+        return offset;
+
+    rc = libxl_domain_info(CTX, &info, dom->guest_domid);
+    if (rc)
+        return rc;
+
+    if (info.gpaddr_bits > 64)
+        return ERROR_INVAL;
+
+    /*
+     * Try to allocate separate 2MB-aligned extended regions from the first
+     * and second RAM banks taking into the account the maximum supported
+     * guest physical address space size and the amount of memory assigned
+     * to the guest.
+     */
+    for (i = 0; i < GUEST_RAM_BANKS; i++) {
+        region_base[i] = bankbase[i] +
+            ALIGN_UP_TO_2MB((uint64_t)dom->rambank_size[i] << 
XC_PAGE_SHIFT);
+
+        bankend[i] = ~0ULL >> (64 - info.gpaddr_bits);
+        bankend[i] = min(bankend[i], bankbase[i] + banksize[i] - 1);
+        if (bankend[i] > region_base[i])
+            region_size[i] = bankend[i] - region_base[i] + 1;
+    }
+
+    /*
+     * The region 0 for grant table space must be always present. If we 
managed
+     * to allocate the extended regions then insert them as regions 1...N.
+     */
+    set_range(&cells, GUEST_ROOT_ADDRESS_CELLS, GUEST_ROOT_SIZE_CELLS,
+              GUEST_GNTTAB_BASE, GUEST_GNTTAB_SIZE);
+
+    for (i = 0; i < GUEST_RAM_BANKS; i++) {
+        if (region_size[i] < EXT_REGION_MIN_SIZE)
+            continue;
+
+        LOG(DEBUG, "Extended region %u: %#"PRIx64"->%#"PRIx64"",
+            nr_regions, region_base[i], region_base[i] + region_size[i]);
+
+        set_range(&cells, GUEST_ROOT_ADDRESS_CELLS, GUEST_ROOT_SIZE_CELLS,
+                  region_base[i], region_size[i]);
+        nr_regions++;
+    }
+
+    if (!nr_regions)
+        LOG(WARN, "The extended regions cannot be allocated, not enough 
space");
+
+    len = sizeof(regs[0]) * (GUEST_ROOT_ADDRESS_CELLS + 
GUEST_ROOT_SIZE_CELLS) *
+        (nr_regions + 1);
+
+    return fdt_setprop(fdt, offset, "reg", regs, len);
+}
+
  int libxl__arch_domain_finalise_hw_description(libxl__gc *gc,
                                                 uint32_t domid,
libxl_domain_config *d_config,
                                                 struct xc_dom_image *dom)
  {
      void *fdt = dom->devicetree_blob;
-    int i;
+    int i, res;
      const uint64_t bankbase[] = GUEST_RAM_BANK_BASES;

      const struct xc_dom_seg *ramdisk = dom->modules[0].blob ?
          &dom->modules[0].seg : NULL;

      if (ramdisk) {
-        int chosen, res;
+        int chosen;
          uint64_t val;

          /* Neither the fdt_path_offset() nor either of the
@@ -1109,6 +1201,10 @@ int 
libxl__arch_domain_finalise_hw_description(libxl__gc *gc,

      }

+    res = finalize_hypervisor_node(gc, dom);
+    if (res)
+        return res;
+
      for (i = 0; i < GUEST_RAM_BANKS; i++) {
          const uint64_t size = (uint64_t)dom->rambank_size[i] << 
XC_PAGE_SHIFT;

diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h
index d46c61f..96ead3d 100644
--- a/xen/include/public/arch-arm.h
+++ b/xen/include/public/arch-arm.h
@@ -438,6 +438,11 @@ typedef uint64_t xen_callback_t;

  #define GUEST_RAM_BANKS   2

+/*
+ * The way to find the extended regions (to be exposed to the guest as 
unused
+ * address space) relies on the fact that the regions reserved for the RAM
+ * below are big enough to also accommodate such regions.
+ */
  #define GUEST_RAM0_BASE   xen_mk_ullong(0x40000000) /* 3GB of low RAM 
@ 1GB */
  #define GUEST_RAM0_SIZE   xen_mk_ullong(0xc0000000)

(END)


-- 
Regards,

Oleksandr Tyshchenko



From xen-devel-bounces@lists.xenproject.org Wed Oct 13 18:28:30 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 18:28:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.208806.365055 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maizN-0005pz-Ma; Wed, 13 Oct 2021 18:28:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 208806.365055; Wed, 13 Oct 2021 18:28:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maizN-0005ps-IQ; Wed, 13 Oct 2021 18:28:29 +0000
Received: by outflank-mailman (input) for mailman id 208806;
 Wed, 13 Oct 2021 18:28:29 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1maizN-0005pf-0j; Wed, 13 Oct 2021 18:28:29 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1maizM-0003Dp-Pp; Wed, 13 Oct 2021 18:28:28 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1maizM-0003aa-Fr; Wed, 13 Oct 2021 18:28:28 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1maizM-0004DB-FN; Wed, 13 Oct 2021 18:28:28 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=Q6DJ3M4lg7c2E18B+oLkqGyUigoi9TxcDuOJwHhvE4A=; b=Kjjhl5J4m2yvi59h/oMcZ5nWM8
	eAqAZRF+uuoOIb31l4En2GomjPwtTih0gp6LV2927sg/uFCPikS51f0kAAtdjKedST8MO8iLnMKEQ
	t4zllEGVMzKmmCAAMtrqc6uHdI/+tTG+8iEY9nsFtv/oBFWYNDEphNuDQXfwT/USGbdA=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165496-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 165496: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=dbb948110a0e23a8081882a980038e9c0f6aab88
X-Osstest-Versions-That:
    xen=f9294486926c865a3ef11cacd7cb6b26cce6f4a4
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 13 Oct 2021 18:28:28 +0000

flight 165496 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165496/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  dbb948110a0e23a8081882a980038e9c0f6aab88
baseline version:
 xen                  f9294486926c865a3ef11cacd7cb6b26cce6f4a4

Last test of basis   165485  2021-10-13 01:00:28 Z    0 days
Testing same since   165496  2021-10-13 15:01:39 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Anthony PERARD <anthony.perard@citrix.com>
  Ian Jackson <iwj@xenproject.org>
  Julien Grall <julien@xen.org>
  Michal Orzel <michal.orzel@arm.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   f929448692..dbb948110a  dbb948110a0e23a8081882a980038e9c0f6aab88 -> smoke


From xen-devel-bounces@lists.xenproject.org Wed Oct 13 19:27:47 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 19:27:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.208823.365069 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1majuW-0003Ju-7P; Wed, 13 Oct 2021 19:27:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 208823.365069; Wed, 13 Oct 2021 19:27:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1majuW-0003Jn-3z; Wed, 13 Oct 2021 19:27:32 +0000
Received: by outflank-mailman (input) for mailman id 208823;
 Wed, 13 Oct 2021 19:27:31 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=XJnr=PB=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1majuV-0003Jh-G2
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 19:27:31 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 844925be-f2ed-4ee5-a332-b8fcd1ff0c48;
 Wed, 13 Oct 2021 19:27:30 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id 23FBB61152;
 Wed, 13 Oct 2021 19:27:29 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 844925be-f2ed-4ee5-a332-b8fcd1ff0c48
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1634153249;
	bh=ZurS1cYABhJbXnEz3J5+JCyzwtXpx6moM7PtHgEHXgE=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=Hbfm3R7KGYCvzLuFsc5XREdtPNmxbfis6ajusXmMR6z3Z3h24F3WBHGj/l692tj+z
	 C47wraXgwVwRxZ2LaxLtCLA7rcZgHH8TiRUHWQrck3Tdr9Hw+/KPNolIGExczOHk2W
	 BKTpktRy+Xxts38wge3IfXOGULmyoXn8FjvXejpDq+jJjqsFLrU25OYo8Ii9LjOHB0
	 2ahMjV3DVrfDAgRf8K6ZL/eSpwlHt4Msug12R70pPG5f0aPuO00Ljo3bPbi+nI2LJ3
	 W4DBmUuGRefeXaE/bvCAbkeqSfdcGnbN3E1LEa3cw7k67bZD9+1U+Eabg8/ZCK6mBp
	 o1sN9+6+Yk3gQ==
Date: Wed, 13 Oct 2021 12:27:28 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Jan Beulich <jbeulich@suse.com>
cc: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>, 
    "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, 
    Bertrand Marquis <bertrand.marquis@arm.com>, 
    "Andre.Przywara@arm.com" <Andre.Przywara@arm.com>, 
    Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, 
    Andrew Cooper <andrew.cooper3@citrix.com>, 
    Rahul Singh <rahul.singh@arm.com>, 
    George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>, 
    Wei Liu <wl@xen.org>, Paul Durrant <paul@xen.org>, 
    =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= <roger.pau@citrix.com>
Subject: Re: [PATCH v5 08/11] xen/arm: Enable the existing x86 virtual PCI
 support for ARM.
In-Reply-To: <ed4876ca-7384-42a8-6fba-e73c1840402a@suse.com>
Message-ID: <alpine.DEB.2.21.2110131223210.9408@sstabellini-ThinkPad-T480s>
References: <cover.1633540842.git.rahul.singh@arm.com> <9bdca2cda5d2e83f94dc2423e55714273539760a.1633540842.git.rahul.singh@arm.com> <YWaco/UvA4xFE1xW@MacBook-Air-de-Roger.local> <6d75f604-6938-b185-61e1-a6684d9fca14@suse.com> <2b943774-072e-20a1-b97c-d88b24adf340@epam.com>
 <ed4876ca-7384-42a8-6fba-e73c1840402a@suse.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="8323329-1563365647-1634153249=:9408"

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-1563365647-1634153249=:9408
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT

On Wed, 13 Oct 2021, Jan Beulich wrote:
> On 13.10.2021 16:51, Oleksandr Andrushchenko wrote:
> > On 13.10.21 16:00, Jan Beulich wrote:
> >> On 13.10.2021 10:45, Roger Pau Monné wrote:
> >>> On Wed, Oct 06, 2021 at 06:40:34PM +0100, Rahul Singh wrote:
> >>>> --- /dev/null
> >>>> +++ b/xen/arch/arm/vpci.c
> >>>> @@ -0,0 +1,102 @@
> >>>> +/*
> >>>> + * xen/arch/arm/vpci.c
> >>>> + *
> >>>> + * This program is free software; you can redistribute it and/or modify
> >>>> + * it under the terms of the GNU General Public License as published by
> >>>> + * the Free Software Foundation; either version 2 of the License, or
> >>>> + * (at your option) any later version.
> >>>> + *
> >>>> + * This program is distributed in the hope that it will be useful,
> >>>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> >>>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> >>>> + * GNU General Public License for more details.
> >>>> + */
> >>>> +#include <xen/sched.h>
> >>>> +
> >>>> +#include <asm/mmio.h>
> >>>> +
> >>>> +#define REGISTER_OFFSET(addr)  ( (addr) & 0x00000fff)
> >>>> +
> >>>> +/* Do some sanity checks. */
> >>>> +static bool vpci_mmio_access_allowed(unsigned int reg, unsigned int len)
> >>>> +{
> >>>> +    /* Check access size. */
> >>>> +    if ( len > 8 )
> >>>> +        return false;
> >>>> +
> >>>> +    /* Check that access is size aligned. */
> >>>> +    if ( (reg & (len - 1)) )
> >>>> +        return false;
> >>>> +
> >>>> +    return true;
> >>>> +}
> >>>> +
> >>>> +static int vpci_mmio_read(struct vcpu *v, mmio_info_t *info,
> >>>> +                          register_t *r, void *p)
> >>>> +{
> >>>> +    unsigned int reg;
> >>>> +    pci_sbdf_t sbdf;
> >>>> +    unsigned long data = ~0UL;
> >>>> +    unsigned int size = 1U << info->dabt.size;
> >>>> +
> >>>> +    sbdf.sbdf = MMCFG_BDF(info->gpa);
> >>>> +    reg = REGISTER_OFFSET(info->gpa);
> >>>> +
> >>>> +    if ( !vpci_mmio_access_allowed(reg, size) )
> >>>> +        return 0;
> >>>> +
> >>>> +    data = vpci_read(sbdf, reg, min(4u, size));
> >>>> +    if ( size == 8 )
> >>>> +        data |= (uint64_t)vpci_read(sbdf, reg + 4, 4) << 32;
> >>>> +
> >>>> +    *r = data;
> >>>> +
> >>>> +    return 1;
> >>>> +}
> >>>> +
> >>>> +static int vpci_mmio_write(struct vcpu *v, mmio_info_t *info,
> >>>> +                           register_t r, void *p)
> >>>> +{
> >>>> +    unsigned int reg;
> >>>> +    pci_sbdf_t sbdf;
> >>>> +    unsigned long data = r;
> >>>> +    unsigned int size = 1U << info->dabt.size;
> >>>> +
> >>>> +    sbdf.sbdf = MMCFG_BDF(info->gpa);
> >>>> +    reg = REGISTER_OFFSET(info->gpa);
> >>>> +
> >>>> +    if ( !vpci_mmio_access_allowed(reg, size) )
> >>>> +        return 0;
> >>>> +
> >>>> +    vpci_write(sbdf, reg, min(4u, size), data);
> >>>> +    if ( size == 8 )
> >>>> +        vpci_write(sbdf, reg + 4, 4, data >> 32);
> >>> I think those two helpers (and vpci_mmio_access_allowed) are very
> >>> similar to the existing x86 ones (see vpci_mmcfg_{read,write}), up to
> >>> the point where I would consider moving the shared code to vpci.c as
> >>> vpci_ecam_{read,write} and call them from the arch specific trap
> >>> handlers.
> >> Except that please can we stick to mcfg or mmcfg instead of ecam
> >> in names, as that's how the thing has been named in Xen from its
> >> introduction? I've just grep-ed the code base (case insensitively)
> >> and found no mention of ECAM. There are only a few "became".
> > I do understand that this is historically that we do not have ECAM in Xen,
> > but PCI is not about Xen. Thus, I think it is also acceptable to use
> > a commonly known ECAM for the code that works with ECAM.
> 
> ACPI, afaik, also doesn't call this ECAM. That's where MCFG / MMCFG
> actually come from, I believe.

My understanding is that "MCFG" is the name of the ACPI table that
describes the PCI config space [1]. The underlying PCI standard for the
memory mapped layout of the PCI config space is called ECAM. Here, it
makes sense to call it ECAM as it is firmware independent.

[1] https://wiki.osdev.org/PCI_Express
--8323329-1563365647-1634153249=:9408--


From xen-devel-bounces@lists.xenproject.org Wed Oct 13 20:19:57 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 20:19:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.208835.365079 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1makj8-0008OM-5Z; Wed, 13 Oct 2021 20:19:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 208835.365079; Wed, 13 Oct 2021 20:19:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1makj8-0008OF-2K; Wed, 13 Oct 2021 20:19:50 +0000
Received: by outflank-mailman (input) for mailman id 208835;
 Wed, 13 Oct 2021 20:19:49 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=dUCo=PB=gmail.com=olekstysh@srs-us1.protection.inumbo.net>)
 id 1makj7-0008O9-77
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 20:19:49 +0000
Received: from mail-wr1-x42d.google.com (unknown [2a00:1450:4864:20::42d])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id e8f87377-b07c-45e5-a8a4-d7012d66b1dc;
 Wed, 13 Oct 2021 20:19:47 +0000 (UTC)
Received: by mail-wr1-x42d.google.com with SMTP id o20so12323442wro.3
 for <xen-devel@lists.xenproject.org>; Wed, 13 Oct 2021 13:19:47 -0700 (PDT)
Received: from [192.168.1.7] ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id l16sm397364wmj.33.2021.10.13.13.19.45
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Wed, 13 Oct 2021 13:19:46 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e8f87377-b07c-45e5-a8a4-d7012d66b1dc
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:from:to:cc:references:message-id:date:user-agent
         :mime-version:in-reply-to:content-transfer-encoding:content-language;
        bh=tGC+9rHO3gnHvq9Yw1yYEgAt89VMye/5SsNdEzya0Yw=;
        b=c2vqZ/+0I2Spxg5KJRE2LIUrJ1xv9t4sZwqDLE6cLmFv58m6QJvPVuzDVourLtptl5
         0AVKHUyDGhwIfkEF1pt2BFpLMpLBw7IMKILLNLIdjEk0CkVJSUgKCks9TufxiCgyAN8a
         kjrFqxJ65qtbF8GhXVaS4oCUmhxQPweiixDoRZiUhr3Ej8obI+uwGc6QYBGmRnSTBHBx
         fhe/HLdGbCXVTSfKWmfLN+FKhryV/5WwLM77oR9+U3CEz/hNIla6fSHrPwIbc3+2QsHb
         SvS/RQ901hQMV7IsA5ePgnCECprKPJPq9tv+BOTvkR03vHLpgSSXLD5tUX+4253kfdN3
         5NMA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:from:to:cc:references:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding
         :content-language;
        bh=tGC+9rHO3gnHvq9Yw1yYEgAt89VMye/5SsNdEzya0Yw=;
        b=3QQP48VsbTSkVRTMqSf//Dvvfi8g0Vcdmloq/U4218V1xcJEuzgNTbXqG2lXSOLXpS
         IfKd+X8eAol6fnYMazB/OYDTlsX0nWSzF1nHNE2TxBsxF47+qS8DRoOzL0+44awDRqbL
         CgogA66x9XEUJKFPKq5wgG1fNhh722jp10Xg3XnAXJ0zsakt6ZQDl7WZyRG6DSICMObO
         XUopnkRhUXCDb5hjdd3wFd1sN2of5RhZj5FwcMaRB0rwRvYSksmSVgkwsCOeklb+pt+P
         okpLVl86Y7kzWp0bBebTk6e4r2FxRd3m9CzNMgYcjE2vISquP0xh8DXw3MnuQUaZLl2b
         1Daw==
X-Gm-Message-State: AOAM532wnPFiL/SPRUYTak6wG3VPsht1z2CbDLAtiTu5D0ciHVxn5Xn2
	tKY3O8TLacV1gyI3bwx88MM=
X-Google-Smtp-Source: ABdhPJwpmrCvjseFR2nYvloCUE6smGZftJtgZmR11r0qlWrOg+1dG/SZJKQfvI0EnkrBMaZnyyCUoA==
X-Received: by 2002:adf:a30b:: with SMTP id c11mr1492934wrb.289.1634156386382;
        Wed, 13 Oct 2021 13:19:46 -0700 (PDT)
Subject: Re: [PATCH V6 2/2] libxl/arm: Add handling of extended regions for
 DomU
From: Oleksandr <olekstysh@gmail.com>
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: Julien Grall <julien@xen.org>, Ian Jackson <iwj@xenproject.org>,
 xen-devel@lists.xenproject.org,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, Wei Liu <wl@xen.org>,
 Anthony PERARD <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <1633974539-7380-1-git-send-email-olekstysh@gmail.com>
 <1633974539-7380-3-git-send-email-olekstysh@gmail.com>
 <c98c1acd-86c0-f556-643e-e472b696644f@xen.org>
 <51f9154f-3b65-c7c0-cd93-cecdc2a0975e@gmail.com>
 <641173d4-2629-e4b6-d4ec-06bd629141cc@xen.org>
 <acc06366-b381-daa0-8e2a-54c2761019af@gmail.com>
 <dea074a1-fad2-9b25-5b44-8de23eee83d7@gmail.com>
 <d076afcc-5fde-e83e-1632-371406bdd387@xen.org>
 <1fc5d4ae-1426-0061-a1e8-dd939de30cc3@gmail.com>
 <2faf58fa-2e06-635f-27fe-9ba642db27b0@xen.org>
 <0125116e-1e8a-8e68-62fb-dfc868ea76d4@gmail.com>
 <a9b9b16d-daf0-0bd3-cc1b-f3812f670e69@xen.org>
 <b2285058-360d-ebef-836e-5b87658e8847@gmail.com>
Message-ID: <510cdb07-3702-4c96-d0be-d1916e36c697@gmail.com>
Date: Wed, 13 Oct 2021 23:19:45 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <b2285058-360d-ebef-836e-5b87658e8847@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US


Hi Stefano,


On 13.10.21 21:26, Oleksandr wrote:
>
> On 13.10.21 20:07, Julien Grall wrote:
>
> Hi Julien
>
>> Hi,
>>
>> On 13/10/2021 17:44, Oleksandr wrote:
>>> On 13.10.21 19:24, Julien Grall wrote:
>>>> On 13/10/2021 16:49, Oleksandr wrote:
>>>>>
>>>>> On 13.10.21 18:15, Julien Grall wrote:
>>>>>> On 13/10/2021 14:46, Oleksandr wrote:
>>>>>>>
>>>>>>> Hi Julien
>>>>>>
>>>>>> Hi Oleksandr,
>>>>>
>>>>> Hi Julien
>>>>>
>>>>>
>>>>> Thank you for the prompt response.
>>>>>
>>>>>
>>>>>>
>>>>>>> On 13.10.21 00:43, Oleksandr wrote:
>>>>>>> diff --git a/tools/libs/light/libxl_arm.c 
>>>>>>> b/tools/libs/light/libxl_arm.c
>>>>>>> index e3140a6..53ae0f3 100644
>>>>>>> --- a/tools/libs/light/libxl_arm.c
>>>>>>> +++ b/tools/libs/light/libxl_arm.c
>>>>>>> @@ -615,9 +615,12 @@ static int make_hypervisor_node(libxl__gc 
>>>>>>> *gc, void *fdt,
>>>>>>>                                 "xen,xen");
>>>>>>>       if (res) return res;
>>>>>>>
>>>>>>> -    /* reg 0 is grant table space */
>>>>>>> +    /*
>>>>>>> +     * reg 0 is a placeholder for grant table space, reg 1...N are
>>>>>>> +     * the placeholders for extended regions.
>>>>>>> +     */
>>>>>>>       res = fdt_property_regs(gc, fdt, GUEST_ROOT_ADDRESS_CELLS, 
>>>>>>> GUEST_ROOT_SIZE_CELLS,
>>>>>>> -                            1,GUEST_GNTTAB_BASE, 
>>>>>>> GUEST_GNTTAB_SIZE);
>>>>>>> +                            GUEST_RAM_BANKS + 1, 0, 0, 0, 0, 0, 
>>>>>>> 0);
>>>>>>
>>>>>> Here you are relying on GUEST_RAM_BANKS == 2. I think this is 
>>>>>> pretty fragile as this may change in the future.
>>>>>>
>>>>>> fdt_property_regs() is not really suitable for here. I would 
>>>>>> suggest to create a new helper fdt_property_placeholder() which 
>>>>>> takes the address cells, size cells and the number of ranges. The 
>>>>>> function will then create N range that are zeroed.
>>>>>
>>>>> You are right. Probably, we could add an assert here for now to be 
>>>>> triggered if "GUEST_RAM_BANKS != 2"?
>>>>> But, if you still think we need to make it with the helper right 
>>>>> now, I will. However, I don't know how long this will take.
>>>>
>>>> I would prefer if we introduce the helper now. Below a potential 
>>>> version (not compiled):
>>>
>>>
>>> You wouldn't believe)))
>>> I decided to not wait for the answer and re-check. So, I ended up 
>>> with the similar to what you suggested below. Thank you.
>>> Yes, it will work if add missing locals. However, I initially named 
>>> it exactly as was suggested (fdt_property_placeholder) and got a 
>>> compilation error, since fdt_property_placeholder is already present.
>>> So, I was thinking to choose another name or to even open-code it, 
>>> but I see you already proposed new name fdt_property_reg_placeholder.
>>
>> Ah I didn't realize that libfdt already implemented 
>> fdt_property_placeholder(). The function sounds perfect for us (and 
>> the code is nicer :)), but unfortunately this was introdcued only in 
>> 2017. So it is possible that some distros may not ship the last libfdt.
>>
>> So for now, I think we need to implement our own. In a follow-up we 
>> could try to provide a compat layer as we did for other missing fdt_* 
>> helpers.
>>
>> Cheers,
>
>
> Well, I hope that I addressed all your comments. If so, I will prepare V7.


May I please ask, are you *preliminary* OK with new changes requested by 
Julien? The main changes are to bring finalize_*() back (hopefully there 
is a way how to downsize a placeholder), avoid relying on the fact that 
Bank 0 is always below 4GB, adding a convenient helper to create a 
placeholder for N ranges plus some code hardening, etc.


>
>
>
> diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c
> index e3140a6..a780155 100644
> --- a/tools/libs/light/libxl_arm.c
> +++ b/tools/libs/light/libxl_arm.c
> @@ -269,6 +269,21 @@ static int fdt_property_regs(libxl__gc *gc, void 
> *fdt,
>      return fdt_property(fdt, "reg", regs, sizeof(regs));
>  }
>
> +static int fdt_property_reg_placeholder(libxl__gc *gc, void *fdt,
> +                                        unsigned int addr_cells,
> +                                        unsigned int size_cells,
> +                                        unsigned int num_regs)
> +{
> +    uint32_t regs[num_regs * (addr_cells + size_cells)];
> +    be32 *cells = &regs[0];
> +    unsigned int i;
> +
> +    for (i = 0; i < num_regs; i++)
> +        set_range(&cells, addr_cells, size_cells, 0, 0);
> +
> +    return fdt_property(fdt, "reg", regs, sizeof(regs));
> +}
> +
>  static int make_root_properties(libxl__gc *gc,
>                                  const libxl_version_info *vers,
>                                  void *fdt)
> @@ -615,9 +630,13 @@ static int make_hypervisor_node(libxl__gc *gc, 
> void *fdt,
>                                "xen,xen");
>      if (res) return res;
>
> -    /* reg 0 is grant table space */
> -    res = fdt_property_regs(gc, fdt, GUEST_ROOT_ADDRESS_CELLS, 
> GUEST_ROOT_SIZE_CELLS,
> -                            1,GUEST_GNTTAB_BASE, GUEST_GNTTAB_SIZE);
> +    /*
> +     * reg 0 is a placeholder for grant table space, reg 1...N are
> +     * the placeholders for extended regions.
> +     */
> +    res = fdt_property_reg_placeholder(gc, fdt, 
> GUEST_ROOT_ADDRESS_CELLS,
> +                                       GUEST_ROOT_SIZE_CELLS,
> +                                       GUEST_RAM_BANKS + 1);
>      if (res) return res;
>
>      /*
> @@ -1069,20 +1088,93 @@ static void finalise_one_node(libxl__gc *gc, 
> void *fdt, const char *uname,
>      }
>  }
>
> +#define ALIGN_UP_TO_2MB(x)   (((x) + MB(2) - 1) & (~(MB(2) - 1)))
> +
> +#define EXT_REGION_MIN_SIZE   xen_mk_ullong(0x0004000000) /* 64MB */
> +
> +static int finalize_hypervisor_node(libxl__gc *gc, struct 
> xc_dom_image *dom)
> +{
> +    void *fdt = dom->devicetree_blob;
> +    uint64_t region_size[GUEST_RAM_BANKS] = {0}, 
> region_base[GUEST_RAM_BANKS],
> +        bankend[GUEST_RAM_BANKS];
> +    uint32_t regs[(GUEST_ROOT_ADDRESS_CELLS + GUEST_ROOT_SIZE_CELLS) *
> +                  (GUEST_RAM_BANKS + 1)];
> +    be32 *cells = &regs[0];
> +    const uint64_t bankbase[] = GUEST_RAM_BANK_BASES;
> +    const uint64_t banksize[] = GUEST_RAM_BANK_SIZES;
> +    unsigned int i, len, nr_regions = 0;
> +    libxl_dominfo info;
> +    int offset, rc;
> +
> +    offset = fdt_path_offset(fdt, "/hypervisor");
> +    if (offset < 0)
> +        return offset;
> +
> +    rc = libxl_domain_info(CTX, &info, dom->guest_domid);
> +    if (rc)
> +        return rc;
> +
> +    if (info.gpaddr_bits > 64)
> +        return ERROR_INVAL;
> +
> +    /*
> +     * Try to allocate separate 2MB-aligned extended regions from the 
> first
> +     * and second RAM banks taking into the account the maximum 
> supported
> +     * guest physical address space size and the amount of memory 
> assigned
> +     * to the guest.
> +     */
> +    for (i = 0; i < GUEST_RAM_BANKS; i++) {
> +        region_base[i] = bankbase[i] +
> +            ALIGN_UP_TO_2MB((uint64_t)dom->rambank_size[i] << 
> XC_PAGE_SHIFT);
> +
> +        bankend[i] = ~0ULL >> (64 - info.gpaddr_bits);
> +        bankend[i] = min(bankend[i], bankbase[i] + banksize[i] - 1);
> +        if (bankend[i] > region_base[i])
> +            region_size[i] = bankend[i] - region_base[i] + 1;
> +    }
> +
> +    /*
> +     * The region 0 for grant table space must be always present. If 
> we managed
> +     * to allocate the extended regions then insert them as regions 
> 1...N.
> +     */
> +    set_range(&cells, GUEST_ROOT_ADDRESS_CELLS, GUEST_ROOT_SIZE_CELLS,
> +              GUEST_GNTTAB_BASE, GUEST_GNTTAB_SIZE);
> +
> +    for (i = 0; i < GUEST_RAM_BANKS; i++) {
> +        if (region_size[i] < EXT_REGION_MIN_SIZE)
> +            continue;
> +
> +        LOG(DEBUG, "Extended region %u: %#"PRIx64"->%#"PRIx64"",
> +            nr_regions, region_base[i], region_base[i] + 
> region_size[i]);
> +
> +        set_range(&cells, GUEST_ROOT_ADDRESS_CELLS, 
> GUEST_ROOT_SIZE_CELLS,
> +                  region_base[i], region_size[i]);
> +        nr_regions++;
> +    }
> +
> +    if (!nr_regions)
> +        LOG(WARN, "The extended regions cannot be allocated, not 
> enough space");
> +
> +    len = sizeof(regs[0]) * (GUEST_ROOT_ADDRESS_CELLS + 
> GUEST_ROOT_SIZE_CELLS) *
> +        (nr_regions + 1);
> +
> +    return fdt_setprop(fdt, offset, "reg", regs, len);
> +}
> +
>  int libxl__arch_domain_finalise_hw_description(libxl__gc *gc,
>                                                 uint32_t domid,
> libxl_domain_config *d_config,
>                                                 struct xc_dom_image *dom)
>  {
>      void *fdt = dom->devicetree_blob;
> -    int i;
> +    int i, res;
>      const uint64_t bankbase[] = GUEST_RAM_BANK_BASES;
>
>      const struct xc_dom_seg *ramdisk = dom->modules[0].blob ?
>          &dom->modules[0].seg : NULL;
>
>      if (ramdisk) {
> -        int chosen, res;
> +        int chosen;
>          uint64_t val;
>
>          /* Neither the fdt_path_offset() nor either of the
> @@ -1109,6 +1201,10 @@ int 
> libxl__arch_domain_finalise_hw_description(libxl__gc *gc,
>
>      }
>
> +    res = finalize_hypervisor_node(gc, dom);
> +    if (res)
> +        return res;
> +
>      for (i = 0; i < GUEST_RAM_BANKS; i++) {
>          const uint64_t size = (uint64_t)dom->rambank_size[i] << 
> XC_PAGE_SHIFT;
>
> diff --git a/xen/include/public/arch-arm.h 
> b/xen/include/public/arch-arm.h
> index d46c61f..96ead3d 100644
> --- a/xen/include/public/arch-arm.h
> +++ b/xen/include/public/arch-arm.h
> @@ -438,6 +438,11 @@ typedef uint64_t xen_callback_t;
>
>  #define GUEST_RAM_BANKS   2
>
> +/*
> + * The way to find the extended regions (to be exposed to the guest 
> as unused
> + * address space) relies on the fact that the regions reserved for 
> the RAM
> + * below are big enough to also accommodate such regions.
> + */
>  #define GUEST_RAM0_BASE   xen_mk_ullong(0x40000000) /* 3GB of low RAM 
> @ 1GB */
>  #define GUEST_RAM0_SIZE   xen_mk_ullong(0xc0000000)
>
> (END)
>
>
-- 
Regards,

Oleksandr Tyshchenko



From xen-devel-bounces@lists.xenproject.org Wed Oct 13 20:24:42 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 20:24:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.208845.365090 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maknp-0001P6-QN; Wed, 13 Oct 2021 20:24:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 208845.365090; Wed, 13 Oct 2021 20:24:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maknp-0001Oz-NE; Wed, 13 Oct 2021 20:24:41 +0000
Received: by outflank-mailman (input) for mailman id 208845;
 Wed, 13 Oct 2021 20:24:40 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=XJnr=PB=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1makno-0001On-1s
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 20:24:40 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id eaed5955-ce29-4a96-9686-1a7970222053;
 Wed, 13 Oct 2021 20:24:37 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id 23AAF60E54;
 Wed, 13 Oct 2021 20:24:36 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: eaed5955-ce29-4a96-9686-1a7970222053
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1634156676;
	bh=+UMjMy2IemJd35i1rYj5WcYDueKIDEFnLy41UpgHX38=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=DANJF70636w/wve/nf0/RyRcsVD8V/mG3B+WXoUAksBLdn9m2IHW47nNuLgbHO47w
	 RS0vcIqkRrfVyG6Cakp/kk2HwV3Jx09Nhvf1nwssayWEAkFO+KOoNJKtdny3EQMKg/
	 qvfpU6TKASBhwt+vz1BX15HOt4kDNkrPAhdxMlaBIatS8SfZVF+78zxpMoY1boIQKH
	 zyBerc5JxSgNwg1YYN5ZEIIxkVYKC2tdBfkbYylrUXfbtw0NI0pq2jqy/Lxjjq54hY
	 hjicUL2WQN0j1cGlSISTCCG9Mk1BdThWP+MJiOr/A4iALwCxUWgCTy2MEagZo0gQob
	 Zb7eTA4ekGVLg==
Date: Wed, 13 Oct 2021 13:24:35 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Oleksandr <olekstysh@gmail.com>
cc: Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>, 
    Ian Jackson <iwj@xenproject.org>, xen-devel@lists.xenproject.org, 
    Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, Wei Liu <wl@xen.org>, 
    Anthony PERARD <anthony.perard@citrix.com>, 
    Juergen Gross <jgross@suse.com>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH V6 2/2] libxl/arm: Add handling of extended regions for
 DomU
In-Reply-To: <510cdb07-3702-4c96-d0be-d1916e36c697@gmail.com>
Message-ID: <alpine.DEB.2.21.2110131324180.9408@sstabellini-ThinkPad-T480s>
References: <1633974539-7380-1-git-send-email-olekstysh@gmail.com> <1633974539-7380-3-git-send-email-olekstysh@gmail.com> <c98c1acd-86c0-f556-643e-e472b696644f@xen.org> <51f9154f-3b65-c7c0-cd93-cecdc2a0975e@gmail.com> <641173d4-2629-e4b6-d4ec-06bd629141cc@xen.org>
 <acc06366-b381-daa0-8e2a-54c2761019af@gmail.com> <dea074a1-fad2-9b25-5b44-8de23eee83d7@gmail.com> <d076afcc-5fde-e83e-1632-371406bdd387@xen.org> <1fc5d4ae-1426-0061-a1e8-dd939de30cc3@gmail.com> <2faf58fa-2e06-635f-27fe-9ba642db27b0@xen.org>
 <0125116e-1e8a-8e68-62fb-dfc868ea76d4@gmail.com> <a9b9b16d-daf0-0bd3-cc1b-f3812f670e69@xen.org> <b2285058-360d-ebef-836e-5b87658e8847@gmail.com> <510cdb07-3702-4c96-d0be-d1916e36c697@gmail.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="8323329-1500327332-1634156676=:9408"

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-1500327332-1634156676=:9408
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT

On Wed, 13 Oct 2021, Oleksandr wrote:
> On 13.10.21 21:26, Oleksandr wrote:
> > 
> > On 13.10.21 20:07, Julien Grall wrote:
> > 
> > Hi Julien
> > 
> > > Hi,
> > > 
> > > On 13/10/2021 17:44, Oleksandr wrote:
> > > > On 13.10.21 19:24, Julien Grall wrote:
> > > > > On 13/10/2021 16:49, Oleksandr wrote:
> > > > > > 
> > > > > > On 13.10.21 18:15, Julien Grall wrote:
> > > > > > > On 13/10/2021 14:46, Oleksandr wrote:
> > > > > > > > 
> > > > > > > > Hi Julien
> > > > > > > 
> > > > > > > Hi Oleksandr,
> > > > > > 
> > > > > > Hi Julien
> > > > > > 
> > > > > > 
> > > > > > Thank you for the prompt response.
> > > > > > 
> > > > > > 
> > > > > > > 
> > > > > > > > On 13.10.21 00:43, Oleksandr wrote:
> > > > > > > > diff --git a/tools/libs/light/libxl_arm.c
> > > > > > > > b/tools/libs/light/libxl_arm.c
> > > > > > > > index e3140a6..53ae0f3 100644
> > > > > > > > --- a/tools/libs/light/libxl_arm.c
> > > > > > > > +++ b/tools/libs/light/libxl_arm.c
> > > > > > > > @@ -615,9 +615,12 @@ static int make_hypervisor_node(libxl__gc
> > > > > > > > *gc, void *fdt,
> > > > > > > >                                 "xen,xen");
> > > > > > > >       if (res) return res;
> > > > > > > > 
> > > > > > > > -    /* reg 0 is grant table space */
> > > > > > > > +    /*
> > > > > > > > +     * reg 0 is a placeholder for grant table space, reg 1...N
> > > > > > > > are
> > > > > > > > +     * the placeholders for extended regions.
> > > > > > > > +     */
> > > > > > > >       res = fdt_property_regs(gc, fdt, GUEST_ROOT_ADDRESS_CELLS,
> > > > > > > > GUEST_ROOT_SIZE_CELLS,
> > > > > > > > -                            1,GUEST_GNTTAB_BASE,
> > > > > > > > GUEST_GNTTAB_SIZE);
> > > > > > > > +                            GUEST_RAM_BANKS + 1, 0, 0, 0, 0, 0,
> > > > > > > > 0);
> > > > > > > 
> > > > > > > Here you are relying on GUEST_RAM_BANKS == 2. I think this is
> > > > > > > pretty fragile as this may change in the future.
> > > > > > > 
> > > > > > > fdt_property_regs() is not really suitable for here. I would
> > > > > > > suggest to create a new helper fdt_property_placeholder() which
> > > > > > > takes the address cells, size cells and the number of ranges. The
> > > > > > > function will then create N range that are zeroed.
> > > > > > 
> > > > > > You are right. Probably, we could add an assert here for now to be
> > > > > > triggered if "GUEST_RAM_BANKS != 2"?
> > > > > > But, if you still think we need to make it with the helper right
> > > > > > now, I will. However, I don't know how long this will take.
> > > > > 
> > > > > I would prefer if we introduce the helper now. Below a potential
> > > > > version (not compiled):
> > > > 
> > > > 
> > > > You wouldn't believe)))
> > > > I decided to not wait for the answer and re-check. So, I ended up with
> > > > the similar to what you suggested below. Thank you.
> > > > Yes, it will work if add missing locals. However, I initially named it
> > > > exactly as was suggested (fdt_property_placeholder) and got a
> > > > compilation error, since fdt_property_placeholder is already present.
> > > > So, I was thinking to choose another name or to even open-code it, but I
> > > > see you already proposed new name fdt_property_reg_placeholder.
> > > 
> > > Ah I didn't realize that libfdt already implemented
> > > fdt_property_placeholder(). The function sounds perfect for us (and the
> > > code is nicer :)), but unfortunately this was introdcued only in 2017. So
> > > it is possible that some distros may not ship the last libfdt.
> > > 
> > > So for now, I think we need to implement our own. In a follow-up we could
> > > try to provide a compat layer as we did for other missing fdt_* helpers.
> > > 
> > > Cheers,
> > 
> > 
> > Well, I hope that I addressed all your comments. If so, I will prepare V7.
> 
> 
> May I please ask, are you *preliminary* OK with new changes requested by
> Julien? The main changes are to bring finalize_*() back (hopefully there is a
> way how to downsize a placeholder), avoid relying on the fact that Bank 0 is
> always below 4GB, adding a convenient helper to create a placeholder for N
> ranges plus some code hardening, etc.

Yes, I am OK with it


> > diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c
> > index e3140a6..a780155 100644
> > --- a/tools/libs/light/libxl_arm.c
> > +++ b/tools/libs/light/libxl_arm.c
> > @@ -269,6 +269,21 @@ static int fdt_property_regs(libxl__gc *gc, void *fdt,
> >      return fdt_property(fdt, "reg", regs, sizeof(regs));
> >  }
> > 
> > +static int fdt_property_reg_placeholder(libxl__gc *gc, void *fdt,
> > +                                        unsigned int addr_cells,
> > +                                        unsigned int size_cells,
> > +                                        unsigned int num_regs)
> > +{
> > +    uint32_t regs[num_regs * (addr_cells + size_cells)];
> > +    be32 *cells = &regs[0];
> > +    unsigned int i;
> > +
> > +    for (i = 0; i < num_regs; i++)
> > +        set_range(&cells, addr_cells, size_cells, 0, 0);
> > +
> > +    return fdt_property(fdt, "reg", regs, sizeof(regs));
> > +}
> > +
> >  static int make_root_properties(libxl__gc *gc,
> >                                  const libxl_version_info *vers,
> >                                  void *fdt)
> > @@ -615,9 +630,13 @@ static int make_hypervisor_node(libxl__gc *gc, void
> > *fdt,
> >                                "xen,xen");
> >      if (res) return res;
> > 
> > -    /* reg 0 is grant table space */
> > -    res = fdt_property_regs(gc, fdt, GUEST_ROOT_ADDRESS_CELLS,
> > GUEST_ROOT_SIZE_CELLS,
> > -                            1,GUEST_GNTTAB_BASE, GUEST_GNTTAB_SIZE);
> > +    /*
> > +     * reg 0 is a placeholder for grant table space, reg 1...N are
> > +     * the placeholders for extended regions.
> > +     */
> > +    res = fdt_property_reg_placeholder(gc, fdt, GUEST_ROOT_ADDRESS_CELLS,
> > +                                       GUEST_ROOT_SIZE_CELLS,
> > +                                       GUEST_RAM_BANKS + 1);
> >      if (res) return res;
> > 
> >      /*
> > @@ -1069,20 +1088,93 @@ static void finalise_one_node(libxl__gc *gc, void
> > *fdt, const char *uname,
> >      }
> >  }
> > 
> > +#define ALIGN_UP_TO_2MB(x)   (((x) + MB(2) - 1) & (~(MB(2) - 1)))
> > +
> > +#define EXT_REGION_MIN_SIZE   xen_mk_ullong(0x0004000000) /* 64MB */
> > +
> > +static int finalize_hypervisor_node(libxl__gc *gc, struct xc_dom_image
> > *dom)
> > +{
> > +    void *fdt = dom->devicetree_blob;
> > +    uint64_t region_size[GUEST_RAM_BANKS] = {0},
> > region_base[GUEST_RAM_BANKS],
> > +        bankend[GUEST_RAM_BANKS];
> > +    uint32_t regs[(GUEST_ROOT_ADDRESS_CELLS + GUEST_ROOT_SIZE_CELLS) *
> > +                  (GUEST_RAM_BANKS + 1)];
> > +    be32 *cells = &regs[0];
> > +    const uint64_t bankbase[] = GUEST_RAM_BANK_BASES;
> > +    const uint64_t banksize[] = GUEST_RAM_BANK_SIZES;
> > +    unsigned int i, len, nr_regions = 0;
> > +    libxl_dominfo info;
> > +    int offset, rc;
> > +
> > +    offset = fdt_path_offset(fdt, "/hypervisor");
> > +    if (offset < 0)
> > +        return offset;
> > +
> > +    rc = libxl_domain_info(CTX, &info, dom->guest_domid);
> > +    if (rc)
> > +        return rc;
> > +
> > +    if (info.gpaddr_bits > 64)
> > +        return ERROR_INVAL;
> > +
> > +    /*
> > +     * Try to allocate separate 2MB-aligned extended regions from the first
> > +     * and second RAM banks taking into the account the maximum supported
> > +     * guest physical address space size and the amount of memory assigned
> > +     * to the guest.
> > +     */
> > +    for (i = 0; i < GUEST_RAM_BANKS; i++) {
> > +        region_base[i] = bankbase[i] +
> > +            ALIGN_UP_TO_2MB((uint64_t)dom->rambank_size[i] <<
> > XC_PAGE_SHIFT);
> > +
> > +        bankend[i] = ~0ULL >> (64 - info.gpaddr_bits);
> > +        bankend[i] = min(bankend[i], bankbase[i] + banksize[i] - 1);
> > +        if (bankend[i] > region_base[i])
> > +            region_size[i] = bankend[i] - region_base[i] + 1;
> > +    }
> > +
> > +    /*
> > +     * The region 0 for grant table space must be always present. If we
> > managed
> > +     * to allocate the extended regions then insert them as regions 1...N.
> > +     */
> > +    set_range(&cells, GUEST_ROOT_ADDRESS_CELLS, GUEST_ROOT_SIZE_CELLS,
> > +              GUEST_GNTTAB_BASE, GUEST_GNTTAB_SIZE);
> > +
> > +    for (i = 0; i < GUEST_RAM_BANKS; i++) {
> > +        if (region_size[i] < EXT_REGION_MIN_SIZE)
> > +            continue;
> > +
> > +        LOG(DEBUG, "Extended region %u: %#"PRIx64"->%#"PRIx64"",
> > +            nr_regions, region_base[i], region_base[i] + region_size[i]);
> > +
> > +        set_range(&cells, GUEST_ROOT_ADDRESS_CELLS, GUEST_ROOT_SIZE_CELLS,
> > +                  region_base[i], region_size[i]);
> > +        nr_regions++;
> > +    }
> > +
> > +    if (!nr_regions)
> > +        LOG(WARN, "The extended regions cannot be allocated, not enough
> > space");
> > +
> > +    len = sizeof(regs[0]) * (GUEST_ROOT_ADDRESS_CELLS +
> > GUEST_ROOT_SIZE_CELLS) *
> > +        (nr_regions + 1);
> > +
> > +    return fdt_setprop(fdt, offset, "reg", regs, len);
> > +}
> > +
> >  int libxl__arch_domain_finalise_hw_description(libxl__gc *gc,
> >                                                 uint32_t domid,
> > libxl_domain_config *d_config,
> >                                                 struct xc_dom_image *dom)
> >  {
> >      void *fdt = dom->devicetree_blob;
> > -    int i;
> > +    int i, res;
> >      const uint64_t bankbase[] = GUEST_RAM_BANK_BASES;
> > 
> >      const struct xc_dom_seg *ramdisk = dom->modules[0].blob ?
> >          &dom->modules[0].seg : NULL;
> > 
> >      if (ramdisk) {
> > -        int chosen, res;
> > +        int chosen;
> >          uint64_t val;
> > 
> >          /* Neither the fdt_path_offset() nor either of the
> > @@ -1109,6 +1201,10 @@ int
> > libxl__arch_domain_finalise_hw_description(libxl__gc *gc,
> > 
> >      }
> > 
> > +    res = finalize_hypervisor_node(gc, dom);
> > +    if (res)
> > +        return res;
> > +
> >      for (i = 0; i < GUEST_RAM_BANKS; i++) {
> >          const uint64_t size = (uint64_t)dom->rambank_size[i] <<
> > XC_PAGE_SHIFT;
> > 
> > diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h
> > index d46c61f..96ead3d 100644
> > --- a/xen/include/public/arch-arm.h
> > +++ b/xen/include/public/arch-arm.h
> > @@ -438,6 +438,11 @@ typedef uint64_t xen_callback_t;
> > 
> >  #define GUEST_RAM_BANKS   2
> > 
> > +/*
> > + * The way to find the extended regions (to be exposed to the guest as
> > unused
> > + * address space) relies on the fact that the regions reserved for the RAM
> > + * below are big enough to also accommodate such regions.
> > + */
> >  #define GUEST_RAM0_BASE   xen_mk_ullong(0x40000000) /* 3GB of low RAM @ 1GB
> > */
> >  #define GUEST_RAM0_SIZE   xen_mk_ullong(0xc0000000)
> > 
> > (END)
> > 
> > 
> -- 
> Regards,
> 
> Oleksandr Tyshchenko
> 
--8323329-1500327332-1634156676=:9408--


From xen-devel-bounces@lists.xenproject.org Wed Oct 13 20:41:37 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 20:41:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.208852.365102 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mal3w-0003jF-8W; Wed, 13 Oct 2021 20:41:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 208852.365102; Wed, 13 Oct 2021 20:41:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mal3w-0003j8-5M; Wed, 13 Oct 2021 20:41:20 +0000
Received: by outflank-mailman (input) for mailman id 208852;
 Wed, 13 Oct 2021 20:41:18 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=XJnr=PB=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1mal3u-0003j1-Hj
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 20:41:18 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id e9ed8f29-2c65-11ec-8197-12813bfff9fa;
 Wed, 13 Oct 2021 20:41:17 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id 2869B610EA;
 Wed, 13 Oct 2021 20:41:16 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e9ed8f29-2c65-11ec-8197-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1634157676;
	bh=VS/ZWtlQY5x3BiVp5nUMCc80qzGBYz4TOkGlTiebOXI=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=Coqo9vQtDYkb7uOJ0iK9yo2/Z52CndQOBzM9lAAATNwSlUQtHEWNypTOZjGfsKGID
	 vRm+a8Wo/6DIeZ2tC+viq1qFTkh9tk9Qj13jVKFGLiirdLCyCGM8fxc1s7ab8NZ7it
	 45m1AQfXrUAwlO6YsbPawsZ4QODwfgSJh81f0gwJ7o+krQH0UCj5PMDSfhqAEx/8cQ
	 p5sAdO1jEX67ToLLTJWZA7v+xelr0QOJxeZgo2sn+rMfONfzCBnqIKQRheZLSgEPlJ
	 NyUuLW9OlQJ/DaRGzBgAwiOUimRh5flG3RJim2/d7Mzo94Htp4fockkHYtUXQWuKyu
	 qahJe/D6Iaaqg==
Date: Wed, 13 Oct 2021 13:41:15 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Jan Beulich <jbeulich@suse.com>
cc: Bertrand Marquis <Bertrand.Marquis@arm.com>, 
    Michal Orzel <Michal.Orzel@arm.com>, Rahul Singh <Rahul.Singh@arm.com>, 
    "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, 
    Andre Przywara <Andre.Przywara@arm.com>, 
    Christian Lindig <christian.lindig@citrix.com>, 
    David Scott <dave@recoil.org>, Ian Jackson <iwj@xenproject.org>, 
    Wei Liu <wl@xen.org>, Andrew Cooper <andrew.cooper3@citrix.com>, 
    George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>, 
    Stefano Stabellini <sstabellini@kernel.org>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, 
    =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= <roger.pau@citrix.com>
Subject: Re: [PATCH v5 07/11] xen/domctl: Introduce XEN_DOMCTL_CDF_vpci
 flag
In-Reply-To: <e88892cf-e0c3-c39c-dce8-bfe2d25a5b53@suse.com>
Message-ID: <alpine.DEB.2.21.2110131113212.9408@sstabellini-ThinkPad-T480s>
References: <cover.1633540842.git.rahul.singh@arm.com> <20d5b9d6a0d01a7b90711d28cbefb5701a88b438.1633540842.git.rahul.singh@arm.com> <YWQDguvmf/O4rDIs@MacBook-Air-de-Roger.local> <9217a6b8-fc53-a049-7cd3-7458b574424b@arm.com> <YWaZKX44IOfIBtX6@MacBook-Air-de-Roger.local>
 <8F9D6B9C-58CB-4000-995A-95517EE72A3B@arm.com> <YWa7eGr3D8Ax8VUX@MacBook-Air-de-Roger.local> <9C5C0FE2-67EA-4CD7-893B-82C156F5F77A@arm.com> <e88892cf-e0c3-c39c-dce8-bfe2d25a5b53@suse.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: multipart/mixed; BOUNDARY="8323329-1357370391-1634148958=:9408"
Content-ID: <alpine.DEB.2.21.2110131116240.9408@sstabellini-ThinkPad-T480s>

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-1357370391-1634148958=:9408
Content-Type: text/plain; CHARSET=UTF-8
Content-Transfer-Encoding: 8BIT
Content-ID: <alpine.DEB.2.21.2110131116241.9408@sstabellini-ThinkPad-T480s>

On Wed, 13 Oct 2021, Jan Beulich wrote:
> On 13.10.2021 14:11, Bertrand Marquis wrote:
> >> On 13 Oct 2021, at 11:56, Roger Pau Monné <roger.pau@citrix.com> wrote:
> >> If vPCI for Arm on 4.16 is not going to be functional, why so much
> >> pressure in pushing those patches so fast? I understand the need to
> >> remove stuff from the queue, but I don't think it's worth the cost of
> >> introducing a broken interface deliberately on a release.
> 
> +1
> 
> > We did not push that fast, those have been on the mailing list for a while (this is the 5th version of the serie).
> > PCI passthrough is a big change requiring lots of patches and we decided to push it piece by piece to make
> > the review easier.
> 
> 5 versions for a series like this one was to be expected. Imo it has
> been wrong in the past to rush in new features (even if experimental
> ones) very close to the freeze, and it has mislead people to think
> they can delay work until very (too?) late a point in time.


Hi Roger, Jan,

Let me take a few minutes to clarify and provide context for this work.


I don't think anyone "pushed hard" any of the ARM series close to the
release. I sent "one" email in public as a reminder of things that need
reviewing:
https://marc.info/?l=xen-devel&m=163373776611154

I did send a couple of private emails to Jan but they were to synchronize
ourselves rather than push; Jan, I hope you didn't take them the wrong
way.


At the same time it is certainly true that all the people involved here
worked very hard to get these series ready for 4.16. Oct 15 is the Xen
Project feature freeze. It is also the deadline for many of us working
with upstream Xen Project to upstream features and report back to our
management. I know it doesn't affect you guys directly, but you can
imagine that as employees of our respective companies we feel pressure
to complete our objectives in the given timeframe. Of course we need to
make sure to do that without compromising quality and without
overextending upstream review capacity.


The ARM PCI series are public since Dec 2020, pushed to a gitlab branch
for testing: https://gitlab.com/xen-project/fusa/xen-integration/-/tree/integration/pci-passthrough
I helped creating, managing and testing the branch.

So, I can see why Bertrand feels like they have been around for a while:
we have been dealing with these patches for almost a year, even if from
a xen-devel perspective we are "only" at version 5.


In the past there have been contributors dropping a large half-broken
series at the last minute before the code freeze, asking for it to be
committed, promising it will be improved later, and then disappearing
right after the release, leaving the code half-broken forever.

It is easy to draw comparisons between that kind of behavior and what is
happening in this thread. We have all been burned by it at some point.

However, that is really *not* what is happening this week.

PCI Passthrough for ARM is a difficult feature to implement. We have
been discussing it for 5+ years, close to 10 years. I know it sounds
unbelievable but it is true. For one reason or the other it never
materialized. Until now.

Even with all the outstanding series committed, PCI Passthrough for ARM
is not fully functional, but it is a lot closer to the objective.
Rahul, Oleksandr and their teams have been already "sticking around" for
almost a year making improvements and without their help going forward
it is not going to get finished anyway. We still don't have MSI support.

Given that Rahul, Oleksandr and the others are required to finish the
work anyway, and they are not at risk of disappearing, I think we can
deal with one or two TODO left by Oct 15 [1].

My suggestion is to accept the TODO for patch #8 [1] but I agree with
Roger that we shouldn't introduce bad interfaces, especially as they
impact x86 which is not "tech preview". So I think we should revert
patch #7 (this patch.) I'll reply with more details in separate shorter
email.

[1] https://marc.info/?l=xen-devel&m=163412120531248


> In fact I'm getting somewhat angry seeing how much effort is put into
> getting this work in (including myself doing reviews there), when at
> the same time far older series of mine aren't given any chance to
> make any progress. Not your fault, sure, but an observation.


Jan,

Let me start by pointing out that without your help we would never have
managed to get so many ARM patches committed for 4.16. Not just PCI
related, but also EFI too. You should really get credit for that.

I can imagine it is frustrating helping so much somebody else but not
getting help for your own series. In a way it happened to me too as the
only Xilinx series outstanding didn't make any progress:
https://marc.info/?l=xen-devel&m=163056545414965

The only way to solve this problem is by growing the review capacity of
the community. You'll be happy to know that (without naming names) I
have heard from multiple people, new members of the community, that they
are going to commit time to do reviews during the next months. We are
growing the community again and some of the new contributors will become
good reviewers and maintainers over time. I am positive that the next 12
months will be a lot better than the last 12 months from that
perspective.


Thanks Jan, Roger, the two Oleksandr, Rahul, Michal, Bertrand, Luca and
everyone else that stayed up late these last few weeks to push Xen
forward with new groundbreaking features and pushing the project forward
in new directions. I do think 4.16 is going to be a great release and
the both CI-loops are still fully working with staging very close to
master, further proof of the great work of this community.

Cheers,

Stefano
--8323329-1357370391-1634148958=:9408--


From xen-devel-bounces@lists.xenproject.org Wed Oct 13 20:53:43 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 20:53:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.208860.365113 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1malFq-0005DO-Cv; Wed, 13 Oct 2021 20:53:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 208860.365113; Wed, 13 Oct 2021 20:53:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1malFq-0005DH-9A; Wed, 13 Oct 2021 20:53:38 +0000
Received: by outflank-mailman (input) for mailman id 208860;
 Wed, 13 Oct 2021 20:53:37 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=XJnr=PB=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1malFp-0005DB-9D
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 20:53:37 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 14ffbdc5-08b4-496a-b4ff-6f7f40720dbb;
 Wed, 13 Oct 2021 20:53:36 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id 618D061152;
 Wed, 13 Oct 2021 20:53:34 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 14ffbdc5-08b4-496a-b4ff-6f7f40720dbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1634158415;
	bh=4j/pbEyjS/pwpNumw3o26zquVKCWrgEEszXmjNxHzM0=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=VXiO48iiK+2PzFes5eC/WgZFsu9oTT/SuODLuxwXWAwM7EJcJXkz6FF7Gx4XBaSQQ
	 c0xuWMDQrKio28HCEwtJVuw6yoFzkCtqkKFzR/3vPIUL2+x36kluJRGmbqrpnpZKDw
	 uRejHTtNTABI/4nhU8/9WD2Efqf3rEPSSfrh2GnOPQyfEcKbFeqezIPHllA6AW6L43
	 rrFTjQuxBVLOZz3KzAr5W8ccdKrbAbUQf39iSt0q04WwqAxzz77OBbaUMeeA4smgEa
	 MUPFIUdaUVH7VWgO/aozou3KMLQwQG+NwVZhxmju4IKs2YmCICWQdanl9uo4P8Czb7
	 E3lwK9TIStgyw==
Date: Wed, 13 Oct 2021 13:53:33 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= <roger.pau@citrix.com>
cc: Bertrand Marquis <Bertrand.Marquis@arm.com>, 
    Michal Orzel <Michal.Orzel@arm.com>, Rahul Singh <Rahul.Singh@arm.com>, 
    "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, 
    Andre Przywara <Andre.Przywara@arm.com>, 
    Christian Lindig <christian.lindig@citrix.com>, 
    David Scott <dave@recoil.org>, Ian Jackson <iwj@xenproject.org>, 
    Wei Liu <wl@xen.org>, Andrew Cooper <andrew.cooper3@citrix.com>, 
    George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>, 
    Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH v5 07/11] xen/domctl: Introduce XEN_DOMCTL_CDF_vpci
 flag
In-Reply-To: <YWa7eGr3D8Ax8VUX@MacBook-Air-de-Roger.local>
Message-ID: <alpine.DEB.2.21.2110131205410.9408@sstabellini-ThinkPad-T480s>
References: <cover.1633540842.git.rahul.singh@arm.com> <20d5b9d6a0d01a7b90711d28cbefb5701a88b438.1633540842.git.rahul.singh@arm.com> <YWQDguvmf/O4rDIs@MacBook-Air-de-Roger.local> <9217a6b8-fc53-a049-7cd3-7458b574424b@arm.com> <YWaZKX44IOfIBtX6@MacBook-Air-de-Roger.local>
 <8F9D6B9C-58CB-4000-995A-95517EE72A3B@arm.com> <YWa7eGr3D8Ax8VUX@MacBook-Air-de-Roger.local>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: multipart/mixed; BOUNDARY="8323329-1296413107-1634152015=:9408"
Content-ID: <alpine.DEB.2.21.2110131207020.9408@sstabellini-ThinkPad-T480s>

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-1296413107-1634152015=:9408
Content-Type: text/plain; CHARSET=UTF-8
Content-Transfer-Encoding: 8BIT
Content-ID: <alpine.DEB.2.21.2110131207021.9408@sstabellini-ThinkPad-T480s>

On Wed, 13 Oct 2021, Roger Pau Monné wrote:
> > I think the second solution is the right one but it cannot be done so near from the
> > feature freeze.
> > 
> > The CDF flag as introduced right now is not creating any issue and will be used once
> > the emulation flag will be introduce. We will be able at this stage to set this properly
> > also on x86 (for dom0 pvh).
> > Moreover keeping it will allow to continue to merge the remaining part of the PCI
> > passthrough which are otherwise not possible to be done as they are dependent on this flag.
> > 
> > Can we agree on keep the DOMCTL_CDF_vpci flag and introduce the emulation
> > flag on Arm after 4.16 release ?
> 
> If vPCI for Arm on 4.16 is not going to be functional, why so much
> pressure in pushing those patches so fast? I understand the need to
> remove stuff from the queue, but I don't think it's worth the cost of
> introducing a broken interface deliberately on a release.
> 
> I think we need to at least settle on whether we want to keep
> CDF_vpci or use an arch specific signal mechanism in order to decide
> what to do regarding the release.

I wrote a longer separate email to provide more context about the
"pushing fast" comment.

I agree that we don't want to introduce a bad interface.

In regards to a way forward for 4.16, my suggestion is the following:

- revert this patch: do not change the interface in this series
    - do not change anything related to CDF_vpci for x86
    - for ARM, leave has_vpci(d) to { false } and do not set
      XEN_DOMCTL_CDF_vpci
    - we can discuss it in depth later on, no rush

- in patch #10, in libxl_arm.c:libxl__arch_domain_prepare_config
    - do not set XEN_DOMCTL_CDF_vpci
    - do not set b_info.arch_arm.vpci
    - do not define LIBXL_HAVE_BUILDINFO_ARM_VPCI in libxl.h
    - keep make_vpci_node and arch_arm.vpci


The other patches (#1, #8, #10), which don't change any interfaces, can
still make it for 4.16 if the review feedback is addressed on time, with
one open TODO item [1].

This way, we get all the essential infrastructure we are trying to
introduce without making any compromises on the external interfaces.
Still it is good to have patches #1 #8 #10 so that with a trival
oneliner patch on top of 4.16 we can enable PCI for ARM and do testing
in the community, in gitlab-ci, and OSSTest too. (We have been
discussing special OSSTest flights to valide PCI passthrough as we
complete development.)


If we think we need a snap decision on this topic, I am available for a
quick sync-up call or IRC meeting between 8AM and 10AM tomorrow (Oct
14).

[1] https://marc.info/?l=xen-devel&m=163412120531248
--8323329-1296413107-1634152015=:9408--


From xen-devel-bounces@lists.xenproject.org Wed Oct 13 20:54:21 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 20:54:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.208867.365124 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1malGW-0005p1-QN; Wed, 13 Oct 2021 20:54:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 208867.365124; Wed, 13 Oct 2021 20:54:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1malGW-0005ot-MJ; Wed, 13 Oct 2021 20:54:20 +0000
Received: by outflank-mailman (input) for mailman id 208867;
 Wed, 13 Oct 2021 20:54:19 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=XJnr=PB=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1malGV-0005oj-P7
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 20:54:19 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 6314625d-56a7-4e92-b61e-ea5edb7912f1;
 Wed, 13 Oct 2021 20:54:18 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id 14D3C61139;
 Wed, 13 Oct 2021 20:54:18 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6314625d-56a7-4e92-b61e-ea5edb7912f1
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1634158458;
	bh=DJ5O9xaU3KyiNEtsTusVehr3cdzALi4I2qFO3t2I5Tk=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=CHsHoBvb/tNH6OALLYNkBB0ZdpYcuF+cJQItIIO7YoESvYseN3CEQxUVVytIEXbjQ
	 gcVytRGdaPIWQVuI8JOWgL5k2qJ3eQfI35f2eeOyGdbZ5+7VRZLEcp6WHV6rU9sxXz
	 MYp5gPOqoDEorj7A6hPWt1E+klkUrRLFp8Ekclp3k993OG68eEl3AAK+U5ehEAqDhD
	 r5ejd8g0fYvgEu1z95ggh9r6mgp0drYrapkuZ+CWKoHAciGVIjDRd/VkdkBYUj/lDn
	 f4AZQg2iguBQEQo1EbVMvFS9+no9hUdStgNenGuInd63nUGUOTUosavfrzf+q9Sn+W
	 q5wLqWctg6Jdw==
Date: Wed, 13 Oct 2021 13:54:17 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Rahul Singh <rahul.singh@arm.com>
cc: xen-devel@lists.xenproject.org, bertrand.marquis@arm.com, 
    Andre.Przywara@arm.com, Stefano Stabellini <sstabellini@kernel.org>, 
    Julien Grall <julien@xen.org>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH v5 11/11] xen/arm: Add linux,pci-domain property for
 hwdom if not available.
In-Reply-To: <dcf40709a3397c07c769a4fd0e55bbe3557730ec.1633540842.git.rahul.singh@arm.com>
Message-ID: <alpine.DEB.2.21.2110131354090.9408@sstabellini-ThinkPad-T480s>
References: <cover.1633540842.git.rahul.singh@arm.com> <dcf40709a3397c07c769a4fd0e55bbe3557730ec.1633540842.git.rahul.singh@arm.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Wed, 6 Oct 2021, Rahul Singh wrote:
> If the property is not present in the device tree node for host bridge,
> XEN while creating the dtb for hwdom will create this property and
> assigns the already allocated segment to the host bridge
> so that XEN and linux will have the same segment for the host bridges.
> 
> Signed-off-by: Rahul Singh <rahul.singh@arm.com>
> Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>
> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>

I committed this patch


> ---
> Change in v5: none
> Change in v4:
> - Added Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
> - Added Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>
> Change in v3:
> - Use is_pci_passthrough_enabled()
> Change in v2:
> - Add linux,pci-domain only when pci-passthrough command line option is enabeld
> ---
> ---
>  xen/arch/arm/domain_build.c        | 16 ++++++++++++++++
>  xen/arch/arm/pci/pci-host-common.c | 21 +++++++++++++++++++++
>  xen/include/asm-arm/pci.h          |  9 +++++++++
>  3 files changed, 46 insertions(+)
> 
> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
> index f4c89bde8c..8739e3285e 100644
> --- a/xen/arch/arm/domain_build.c
> +++ b/xen/arch/arm/domain_build.c
> @@ -747,6 +747,22 @@ static int __init write_properties(struct domain *d, struct kernel_info *kinfo,
>              return res;
>      }
>  
> +    if ( is_pci_passthrough_enabled() && dt_device_type_is_equal(node, "pci") )
> +    {
> +        if ( !dt_find_property(node, "linux,pci-domain", NULL) )
> +        {
> +            uint16_t segment;
> +
> +            res = pci_get_host_bridge_segment(node, &segment);
> +            if ( res < 0 )
> +                return res;
> +
> +            res = fdt_property_cell(kinfo->fdt, "linux,pci-domain", segment);
> +            if ( res )
> +                return res;
> +        }
> +    }
> +
>      /*
>       * Override the property "status" to disable the device when it's
>       * marked for passthrough.
> diff --git a/xen/arch/arm/pci/pci-host-common.c b/xen/arch/arm/pci/pci-host-common.c
> index c5941b10e9..593beeb48c 100644
> --- a/xen/arch/arm/pci/pci-host-common.c
> +++ b/xen/arch/arm/pci/pci-host-common.c
> @@ -255,6 +255,27 @@ struct pci_host_bridge *pci_find_host_bridge(uint16_t segment, uint8_t bus)
>  
>      return NULL;
>  }
> +
> +/*
> + * This function will lookup an hostbridge based on config space address.
> + */
> +int pci_get_host_bridge_segment(const struct dt_device_node *node,
> +                                uint16_t *segment)
> +{
> +    struct pci_host_bridge *bridge;
> +
> +    list_for_each_entry( bridge, &pci_host_bridges, node )
> +    {
> +        if ( bridge->dt_node != node )
> +            continue;
> +
> +        *segment = bridge->segment;
> +        return 0;
> +    }
> +
> +    return -EINVAL;
> +}
> +
>  /*
>   * Local variables:
>   * mode: C
> diff --git a/xen/include/asm-arm/pci.h b/xen/include/asm-arm/pci.h
> index 5532ce3977..7cb2e2f1ed 100644
> --- a/xen/include/asm-arm/pci.h
> +++ b/xen/include/asm-arm/pci.h
> @@ -90,6 +90,8 @@ int pci_generic_config_write(struct pci_host_bridge *bridge, pci_sbdf_t sbdf,
>  void __iomem *pci_ecam_map_bus(struct pci_host_bridge *bridge,
>                                 pci_sbdf_t sbdf, uint32_t where);
>  struct pci_host_bridge *pci_find_host_bridge(uint16_t segment, uint8_t bus);
> +int pci_get_host_bridge_segment(const struct dt_device_node *node,
> +                                uint16_t *segment);
>  
>  static always_inline bool is_pci_passthrough_enabled(void)
>  {
> @@ -104,5 +106,12 @@ static always_inline bool is_pci_passthrough_enabled(void)
>      return false;
>  }
>  
> +static inline int pci_get_host_bridge_segment(const struct dt_device_node *node,
> +                                              uint16_t *segment)
> +{
> +    ASSERT_UNREACHABLE();
> +    return -EINVAL;
> +}
> +
>  #endif  /*!CONFIG_HAS_PCI*/
>  #endif /* __ARM_PCI_H__ */
> -- 
> 2.25.1
> 


From xen-devel-bounces@lists.xenproject.org Wed Oct 13 20:54:55 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 20:54:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.208871.365135 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1malH5-0006O5-2o; Wed, 13 Oct 2021 20:54:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 208871.365135; Wed, 13 Oct 2021 20:54:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1malH4-0006Ny-Vd; Wed, 13 Oct 2021 20:54:54 +0000
Received: by outflank-mailman (input) for mailman id 208871;
 Wed, 13 Oct 2021 20:54:53 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=XJnr=PB=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1malH3-0006Nm-4v
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 20:54:53 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id d3c5eb78-c983-4efc-8cd5-08b348a54516;
 Wed, 13 Oct 2021 20:54:52 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id 0959661139;
 Wed, 13 Oct 2021 20:54:51 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d3c5eb78-c983-4efc-8cd5-08b348a54516
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1634158491;
	bh=6XAwD7fJVOhBvmRdjPQd/C92AijiPUGTCW7HfqdlakU=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=RYJdkyd1okA3F+VWJ7LrfwrEN0MfaL+7KYPMGS9En0804Eoz2NDWXhMHqMprha4/s
	 zrVntv5l+11BqC3CoQB98RT3PGv+94Ok1DAHVkqzT8Rkz7kLwpmFM5d7/bN6vbbLc7
	 SyXLeNUg8kp2yhUQtk1nVF2hoznLzv0RekAwFY1pm8VHohz0fOPAAONSI/kwjYLM7h
	 PiC2XKTeoeScimq2Qt5sGJhTOOs+atZrnHeOw7Rn1jtbeYOlppLlLPpEWj9+tcZp++
	 qZ/ZEBDZCsQLSBPyYygUXOBKujlEWx9ToQd+ESbQ5OSkGBHahrS576Mgesb1hY9sCd
	 SmZqLe6FgYGvg==
Date: Wed, 13 Oct 2021 13:54:50 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Luca Fancellu <luca.fancellu@arm.com>
cc: xen-devel@lists.xenproject.org, bertrand.marquis@arm.com, wei.chen@arm.com, 
    Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH v2] arm/docs: Clarify legacy DT bindings on UEFI
In-Reply-To: <20211013145202.53070-1-luca.fancellu@arm.com>
Message-ID: <alpine.DEB.2.21.2110131354410.9408@sstabellini-ThinkPad-T480s>
References: <20211013145202.53070-1-luca.fancellu@arm.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="8323329-1518877962-1634158491=:9408"

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-1518877962-1634158491=:9408
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT

On Wed, 13 Oct 2021, Luca Fancellu wrote:
> Since the introduction of UEFI boot for Xen, the legacy
> compatible strings were not supported and the stub code
> was checking only the presence of “multiboot,module” to
> require the Xen UEFI configuration file or not.
> The documentation was not updated to specify that behavior.
> 
> Add a phrase to docs/misc/arm/device-tree/booting.txt
> to clarify it.
> 
> Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>
> Acked-by: Julien Grall <jgrall@amazon.com>

Committed


> ---
> Changes in v2:
> - dropped redundant wording in docs/misc/arm/device-tree/booting.txt
> - Add more details to the commit message
> ---
>  docs/misc/arm/device-tree/booting.txt | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/docs/misc/arm/device-tree/booting.txt b/docs/misc/arm/device-tree/booting.txt
> index c6a775f4e8..71895663a4 100644
> --- a/docs/misc/arm/device-tree/booting.txt
> +++ b/docs/misc/arm/device-tree/booting.txt
> @@ -51,6 +51,8 @@ Each node contains the following properties:
>  	Xen 4.4 supported a different set of legacy compatible strings
>  	which remain supported such that systems supporting both 4.4
>  	and later can use a single DTB.
> +	However when booting Xen using UEFI, the legacy compatible
> +	strings are not supported.
>  
>  	- "xen,multiboot-module" equivalent to "multiboot,module"
>  	- "xen,linux-zimage"     equivalent to "multiboot,kernel"
> -- 
> 2.17.1
> 
--8323329-1518877962-1634158491=:9408--


From xen-devel-bounces@lists.xenproject.org Wed Oct 13 20:55:22 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 20:55:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.208879.365154 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1malHW-00073v-GK; Wed, 13 Oct 2021 20:55:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 208879.365154; Wed, 13 Oct 2021 20:55:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1malHW-00073o-D6; Wed, 13 Oct 2021 20:55:22 +0000
Received: by outflank-mailman (input) for mailman id 208879;
 Wed, 13 Oct 2021 20:55:21 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=XJnr=PB=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1malHV-00073X-1D
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 20:55:21 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id dfa87256-2c67-11ec-8197-12813bfff9fa;
 Wed, 13 Oct 2021 20:55:19 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id 0B47561152;
 Wed, 13 Oct 2021 20:55:18 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: dfa87256-2c67-11ec-8197-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1634158518;
	bh=TKfpbSxxvXuESa7jyc5yKFzwAPpNATCHTNr0JO4++mQ=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=gLO5dJN45/i3hKMPZokVcCwOWBJUlW9UJsb3/lEfvlg6vIp9/pSVMQXLJP2jgjqOz
	 wisWjDbUe+gi+4PH/uWWoATAI9b+Zcn04MKuVWdi+cwCE/RRcBB1BWYD/dPIiYCdbj
	 +4/YWEg244N1X+AzwE1nP70xdS7JJy8W3baEPtqD6tGrJ1kXv6oyXt4y+GQxxrUatA
	 Ff1YNHHWoGQaAzUFEBtm68oFWRiETxtVmD8+MetBNJVb3vMvK89KJnWhZ67YZw5v9q
	 dWTqfVs+TdMS0Rs9/laIG+sulV+86zfakXzLTos2uSzPfKZzZgSkA1swh4UXt3nXqF
	 d1BOZxt8nD//g==
Date: Wed, 13 Oct 2021 13:55:16 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Jan Beulich <jbeulich@suse.com>
cc: Stefano Stabellini <sstabellini@kernel.org>, 
    Luca Fancellu <luca.fancellu@arm.com>, Julien Grall <julien@xen.org>, 
    xen-devel@lists.xenproject.org, 
    Bertrand Marquis <bertrand.marquis@arm.com>, wei.chen@arm.com, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, 
    Andrew Cooper <andrew.cooper3@citrix.com>, 
    George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>, 
    Wei Liu <wl@xen.org>
Subject: Re: [PATCH v6 2/2] arm/efi: load dom0 modules from DT using UEFI
In-Reply-To: <696b9cef-9f9a-6285-bcd8-372e505fbb15@suse.com>
Message-ID: <alpine.DEB.2.21.2110131355080.9408@sstabellini-ThinkPad-T480s>
References: <20211011181528.17367-1-luca.fancellu@arm.com> <20211011181528.17367-3-luca.fancellu@arm.com> <alpine.DEB.2.21.2110111243290.25528@sstabellini-ThinkPad-T480s> <EC7165F9-09CE-4001-93ED-FA637F5ED36C@arm.com> <alpine.DEB.2.21.2110111415350.25528@sstabellini-ThinkPad-T480s>
 <alpine.DEB.2.21.2110111423310.25528@sstabellini-ThinkPad-T480s> <29cc47f2-4727-0397-db0c-a6c1f5a52bf7@xen.org> <alpine.DEB.2.21.2110111813510.25528@sstabellini-ThinkPad-T480s> <81EA782B-762E-4B8A-8D33-EC79203439BC@arm.com>
 <alpine.DEB.2.21.2110121309560.9408@sstabellini-ThinkPad-T480s> <696b9cef-9f9a-6285-bcd8-372e505fbb15@suse.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="8323329-176724746-1634158518=:9408"

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-176724746-1634158518=:9408
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT

On Wed, 13 Oct 2021, Jan Beulich wrote:
> On 13.10.2021 02:49, Stefano Stabellini wrote:
> > On Tue, 12 Oct 2021, Luca Fancellu wrote:
> >>> On 12 Oct 2021, at 02:31, Stefano Stabellini <sstabellini@kernel.org> wrote:
> >>>
> >>> On Mon, 11 Oct 2021, Julien Grall wrote:
> >>>> Hi Stefano,
> >>>>
> >>>> On 11/10/2021 22:24, Stefano Stabellini wrote:
> >>>>>> diff --git a/xen/arch/arm/efi/efi-boot.h b/xen/arch/arm/efi/efi-boot.h
> >>>>>> index 840728d6c0..076b827bdd 100644
> >>>>>> --- a/xen/arch/arm/efi/efi-boot.h
> >>>>>> +++ b/xen/arch/arm/efi/efi-boot.h
> >>>>>> @@ -713,10 +713,12 @@ static int __init handle_module_node(EFI_FILE_HANDLE
> >>>>>> dir_handle,
> >>>>>>      char mod_string[24]; /* Placeholder for module@ + a 64-bit number +
> >>>>>> \0 */
> >>>>>>      int uefi_name_len, file_idx, module_compat;
> >>>>>>      module_name *file;
> >>>>>> +    const char *compat_string = is_domu_module ? "multiboot,module" :
> >>>>>> +                                "xen,multiboot-module";
> >>>>>>        /* Check if the node is a multiboot,module otherwise return */
> >>>>>>      module_compat = fdt_node_check_compatible(fdt, module_node_offset,
> >>>>>> -                                              "multiboot,module");
> >>>>>> +                                              compat_string);
> >>>>>>      if ( module_compat < 0 )
> >>>>>>          /* Error while checking the compatible string */
> >>>>>>          return ERROR_CHECK_MODULE_COMPAT;
> >>>>>
> >>>>>
> >>>>> Well... not exactly like this because this would stop a normal
> >>>>> "multiboot,module" dom0 kernel from being recognized.
> >>>>>
> >>>>> So we need for domU: only "multiboot,module"
> >>>>> For Dom0, either "multiboot,module" or "xen,multiboot-module"
> >>>>
> >>>> Looking at the history, xen,multiboot-module has been considered as a legacy
> >>>> binding since before UEFI was introduced. In fact, without this series, I
> >>>> believe, there is limited reasons for the compatible to be present in the DT
> >>>> as you would either use grub (which use the new compatible) or xen.cfg (the
> >>>> stub will create the node).
> >>>>
> >>>> So I would argue that this compatible should not be used in combination with
> >>>> UEFI and therefore we should not handle it. This would make the code simpler
> >>>> :).
> >>>
> >>
> >> Hi Stefano,
> >>
> >>> What you suggested is a viable option, however ImageBuilder is still
> >>> using the "xen,multiboot-module" format somehow today (no idea why) and
> >>> we have the following written in docs/misc/arm/device-tree/booting.txt:
> >>>
> >>> 	Xen 4.4 supported a different set of legacy compatible strings
> >>> 	which remain supported such that systems supporting both 4.4
> >>> 	and later can use a single DTB.
> >>>
> >>> 	- "xen,multiboot-module" equivalent to "multiboot,module"
> >>> 	- "xen,linux-zimage"     equivalent to "multiboot,kernel"
> >>> 	- "xen,linux-initrd"     equivalent to "multiboot,ramdisk"
> >>>
> >>> 	For compatibility with Xen 4.4 the more specific "xen,linux-*"
> >>> 	names are non-optional and must be included.
> >>>
> >>> My preference is to avoid breaking compatibility (even with UEFI
> >>> booting). The way I suggested above is one way to do it.
> >>>
> >>> But I don't feel strongly about this at all, I am fine with ignoring
> >>> "xen,multiboot-module" in the EFI stub. I can get ImageBuilder fixed
> >>> very quickly (I should do that in any case). If we are going to ignore
> >>> "xen,multiboot-module" then we probably want to update the text in
> >>> docs/misc/arm/device-tree/booting.txt also.
> >>
> >> The changes to support legacy compatible strings can be done but it will result in
> >> complex code, I would go for Julien suggestion to just drop it for UEFI.
> >>
> >> I can add a note on docs/misc/arm/device-tree/booting.txt saying that for UEFI boot
> >> the legacy strings are not supported.
> >>
> >> Something like:
> >>
> >> --- a/docs/misc/arm/device-tree/booting.txt
> >> +++ b/docs/misc/arm/device-tree/booting.txt
> >> @@ -51,6 +51,8 @@ Each node contains the following properties:
> >>         Xen 4.4 supported a different set of legacy compatible strings
> >>         which remain supported such that systems supporting both 4.4
> >>         and later can use a single DTB.
> >> +       However when booting Xen using UEFI and Device Tree, the legacy compatible
> >> +       strings are not supported.
> >>  
> >>         - "xen,multiboot-module" equivalent to "multiboot,module"
> >>         - "xen,linux-zimage"     equivalent to "multiboot,kernel”
> >>
> >>
> >> What do you think about that?
> > 
> > Also reading Julien's reply, I am fine with a doc-only change in a
> > separate patch.
> > 
> > Yes, something along those lines is OK.
> > 
> > So for this patch:
> > 
> > Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
> 
> Then applicable parts
> Acked-by: Jan Beulich <jbeulich@suse.com>

Thanks! Patch committed.
--8323329-176724746-1634158518=:9408--


From xen-devel-bounces@lists.xenproject.org Wed Oct 13 22:31:46 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 22:31:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.208899.365169 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mammY-00081s-PF; Wed, 13 Oct 2021 22:31:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 208899.365169; Wed, 13 Oct 2021 22:31:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mammY-00081l-La; Wed, 13 Oct 2021 22:31:30 +0000
Received: by outflank-mailman (input) for mailman id 208899;
 Wed, 13 Oct 2021 22:31:29 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mammX-00081b-Ib; Wed, 13 Oct 2021 22:31:29 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mammX-0007Km-FE; Wed, 13 Oct 2021 22:31:29 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mammX-0000Xs-2M; Wed, 13 Oct 2021 22:31:29 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mammX-0007vW-1p; Wed, 13 Oct 2021 22:31:29 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=96kFtMZ0ZV/Jyq1oWhOXUTbFeL9KUFWOoZoA1voCoh0=; b=w9q7EdLSV/FE++8RE7grbzx6Xf
	Z4HEqWEap21nnBhVtMm0q7F3MxgX5lkexxfAf9v1urXacHwMcvtlMyV5sdA3ZzESmQ7VJG63xeuxK
	Li2tSVPSHrQtcHQ8QwSq44ExVU6MSHPxzpjt4jtXyExb0qpu5CfsozGsqhtuZtgsAn4c=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165494-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 165494: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=6ed6abd6c116e8599876a2876b77e172e800b13e
X-Osstest-Versions-That:
    ovmf=f22feb0e3b3f08b95201b258b104c45a2acef71f
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 13 Oct 2021 22:31:29 +0000

flight 165494 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165494/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 6ed6abd6c116e8599876a2876b77e172e800b13e
baseline version:
 ovmf                 f22feb0e3b3f08b95201b258b104c45a2acef71f

Last test of basis   165487  2021-10-13 01:56:13 Z    0 days
Testing same since   165494  2021-10-13 12:41:14 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Chen, Christine <Yuwei.Chen@intel.com>
  IanX Kuo <ianx.kuo@intel.com>
  Yuwei Chen <yuwei.chen@intel.com>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   f22feb0e3b..6ed6abd6c1  6ed6abd6c116e8599876a2876b77e172e800b13e -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Wed Oct 13 22:46:45 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 22:46:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.208908.365182 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1man1D-000179-UN; Wed, 13 Oct 2021 22:46:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 208908.365182; Wed, 13 Oct 2021 22:46:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1man1D-000172-RF; Wed, 13 Oct 2021 22:46:39 +0000
Received: by outflank-mailman (input) for mailman id 208908;
 Wed, 13 Oct 2021 22:46:38 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1man1C-00016s-3Q; Wed, 13 Oct 2021 22:46:38 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1man1B-0007Zi-TU; Wed, 13 Oct 2021 22:46:37 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1man1B-00014u-MT; Wed, 13 Oct 2021 22:46:37 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1man1B-0006Er-Ly; Wed, 13 Oct 2021 22:46:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=u7nJp5np+Zrf1ToKM6gOsxiu5YF/jfNpfG3/z/KUEec=; b=vHIeaFgyES/jly+7In5WRW9YSZ
	88cz+fWyeEeANagDVL/6j3eAOerfU2kwez7WXudO4IywrOidaJL+yJ0Q234LlmYgAE0iynEL+PQRY
	fy4+2Gp7JTYNc1wkzdwC+9M5LfwPDtoGgyj9W75HCrShCceqgXxyZadMZdcq0zUUutVo=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165499-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 165499: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=9e319e5258d0274c15da2ea9355dc1569a0fa832
X-Osstest-Versions-That:
    xen=dbb948110a0e23a8081882a980038e9c0f6aab88
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 13 Oct 2021 22:46:37 +0000

flight 165499 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165499/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  9e319e5258d0274c15da2ea9355dc1569a0fa832
baseline version:
 xen                  dbb948110a0e23a8081882a980038e9c0f6aab88

Last test of basis   165496  2021-10-13 15:01:39 Z    0 days
Testing same since   165499  2021-10-13 19:00:29 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Anthony PERARD <anthony.perard@citrix.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   dbb948110a..9e319e5258  9e319e5258d0274c15da2ea9355dc1569a0fa832 -> smoke


From xen-devel-bounces@lists.xenproject.org Wed Oct 13 23:20:18 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 23:20:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.208917.365197 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1manXf-00056F-B1; Wed, 13 Oct 2021 23:20:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 208917.365197; Wed, 13 Oct 2021 23:20:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1manXf-000568-6e; Wed, 13 Oct 2021 23:20:11 +0000
Received: by outflank-mailman (input) for mailman id 208917;
 Wed, 13 Oct 2021 23:20:09 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1manXd-00054c-AJ; Wed, 13 Oct 2021 23:20:09 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1manXd-00087W-1O; Wed, 13 Oct 2021 23:20:09 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1manXc-0002jj-Le; Wed, 13 Oct 2021 23:20:08 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1manXc-0003Ml-Kh; Wed, 13 Oct 2021 23:20:08 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=I04pToB0xVdiXZ4FuqyeDnYxx6U46p8KgJE0gUYObm8=; b=zsPDS7KvJv9F7Ps0RkPhg6friY
	TVjGXnFqBLk77I5XvyYB68lAB5geKdKhgd/7wWwRelGUkqkYyPDCezpvvbk2GIqsk4KJYj+2fcCks
	Nqo9U3cRcqVVzLCol+/F/1C/VexpECd5WlBq3AIah7sFOn+Os72W3YpncBUz771feBQ4=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165491-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 165491: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:guest-start/debianhvm.repeat:fail:heisenbug
    xen-unstable:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=f9294486926c865a3ef11cacd7cb6b26cce6f4a4
X-Osstest-Versions-That:
    xen=d3b05f9b16d6ba9c550c3a35ac11ed292bf87f68
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 13 Oct 2021 23:20:08 +0000

flight 165491 xen-unstable real [real]
flight 165500 xen-unstable real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/165491/
http://logs.test-lab.xenproject.org/osstest/logs/165500/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 18 guest-start/debianhvm.repeat fail pass in 165500-retest
 test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail pass in 165500-retest

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-rtds     20 guest-localmigrate/x10       fail  like 165480
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 165480
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 165480
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165480
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165480
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 165480
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 165480
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 165480
 test-armhf-armhf-xl-rtds     18 guest-start/debian.repeat    fail  like 165480
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 165480
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 165480
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 165480
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165480
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 165480
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  f9294486926c865a3ef11cacd7cb6b26cce6f4a4
baseline version:
 xen                  d3b05f9b16d6ba9c550c3a35ac11ed292bf87f68

Last test of basis   165480  2021-10-12 15:44:05 Z    1 days
Testing same since   165491  2021-10-13 06:50:37 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Christian Lindig <christian.lindig@citrix.com>
  Dmitry Isaykin <isaikin-dmitry@yandex.ru>
  Ian Jackson <iwj@xenproject.org>
  Jan Beulich <jbeulich@suse.com>
  Luca Fancellu <luca.fancellu@arm.com>
  Michal Orzel <michal.orzel@arm.com>
  Nick Rosbrook <rosbrookn@ainfosec.com>
  Stefano Stabellini <stefano.stabellini@xilinx.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            fail    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     fail    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 fail    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   d3b05f9b16..f929448692  f9294486926c865a3ef11cacd7cb6b26cce6f4a4 -> master


From xen-devel-bounces@lists.xenproject.org Wed Oct 13 23:21:37 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 13 Oct 2021 23:21:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.208926.365210 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1manZ2-0005j6-QV; Wed, 13 Oct 2021 23:21:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 208926.365210; Wed, 13 Oct 2021 23:21:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1manZ2-0005iz-Ni; Wed, 13 Oct 2021 23:21:36 +0000
Received: by outflank-mailman (input) for mailman id 208926;
 Wed, 13 Oct 2021 23:21:35 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=XJnr=PB=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1manZ1-0005ir-L1
 for xen-devel@lists.xenproject.org; Wed, 13 Oct 2021 23:21:35 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id aff0e915-ab70-4087-9319-710dcd45e10d;
 Wed, 13 Oct 2021 23:21:34 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id C64C7610CE;
 Wed, 13 Oct 2021 23:21:32 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: aff0e915-ab70-4087-9319-710dcd45e10d
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1634167294;
	bh=Giumvu8A0ghOTFjjW7M5l+fqk+HGcfj12+AMFZXd0B0=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=VM+P1wTBlQX7dSUvEcyRuoZios0xsb5YXzU+ysLzquvBgfgIacBHSvC1lJa46NXmL
	 qIz/O8zkPuwXTB51n3Z3XTHFtvXLr4za1Fx5u99dMpSSBZbXZHJRmGBbmRQcAQ0ag3
	 TTdOV8+NWF78XjLMZwb84NEI609/W/fE8EvHovB+etrbi9URxEqSKq4rfAySk7KgNN
	 IkMO6TM8HL6KKs18XZUunqgdSSXG0glkxpKZXp/JFSG4m07CuMeEU2CUScCnFmz8RK
	 7Z3wNwXRpUFZiR6SP1wnnqydIbDnsFIOhenWKb6VFUoV8w/phjXlSFkEgNqWpzgT5j
	 8Fxmev0DVpazw==
Date: Wed, 13 Oct 2021 16:21:30 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Stefano Stabellini <sstabellini@kernel.org>
cc: =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= <roger.pau@citrix.com>, 
    Bertrand Marquis <Bertrand.Marquis@arm.com>, 
    Michal Orzel <Michal.Orzel@arm.com>, Rahul Singh <Rahul.Singh@arm.com>, 
    "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, 
    Andre Przywara <Andre.Przywara@arm.com>, 
    Christian Lindig <christian.lindig@citrix.com>, 
    David Scott <dave@recoil.org>, Ian Jackson <iwj@xenproject.org>, 
    Wei Liu <wl@xen.org>, Andrew Cooper <andrew.cooper3@citrix.com>, 
    George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>, 
    Julien Grall <julien@xen.org>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH v5 07/11] xen/domctl: Introduce XEN_DOMCTL_CDF_vpci
 flag
In-Reply-To: <alpine.DEB.2.21.2110131205410.9408@sstabellini-ThinkPad-T480s>
Message-ID: <alpine.DEB.2.21.2110131510120.9408@sstabellini-ThinkPad-T480s>
References: <cover.1633540842.git.rahul.singh@arm.com> <20d5b9d6a0d01a7b90711d28cbefb5701a88b438.1633540842.git.rahul.singh@arm.com> <YWQDguvmf/O4rDIs@MacBook-Air-de-Roger.local> <9217a6b8-fc53-a049-7cd3-7458b574424b@arm.com> <YWaZKX44IOfIBtX6@MacBook-Air-de-Roger.local>
 <8F9D6B9C-58CB-4000-995A-95517EE72A3B@arm.com> <YWa7eGr3D8Ax8VUX@MacBook-Air-de-Roger.local> <alpine.DEB.2.21.2110131205410.9408@sstabellini-ThinkPad-T480s>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: multipart/mixed; BOUNDARY="8323329-800336767-1634163118=:9408"
Content-ID: <alpine.DEB.2.21.2110131621100.9408@sstabellini-ThinkPad-T480s>

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-800336767-1634163118=:9408
Content-Type: text/plain; CHARSET=UTF-8
Content-Transfer-Encoding: 8BIT
Content-ID: <alpine.DEB.2.21.2110131621101.9408@sstabellini-ThinkPad-T480s>

On Wed, 13 Oct 2021, Stefano Stabellini wrote:
> On Wed, 13 Oct 2021, Roger Pau Monné wrote:
> > > I think the second solution is the right one but it cannot be done so near from the
> > > feature freeze.
> > > 
> > > The CDF flag as introduced right now is not creating any issue and will be used once
> > > the emulation flag will be introduce. We will be able at this stage to set this properly
> > > also on x86 (for dom0 pvh).
> > > Moreover keeping it will allow to continue to merge the remaining part of the PCI
> > > passthrough which are otherwise not possible to be done as they are dependent on this flag.
> > > 
> > > Can we agree on keep the DOMCTL_CDF_vpci flag and introduce the emulation
> > > flag on Arm after 4.16 release ?
> > 
> > If vPCI for Arm on 4.16 is not going to be functional, why so much
> > pressure in pushing those patches so fast? I understand the need to
> > remove stuff from the queue, but I don't think it's worth the cost of
> > introducing a broken interface deliberately on a release.
> > 
> > I think we need to at least settle on whether we want to keep
> > CDF_vpci or use an arch specific signal mechanism in order to decide
> > what to do regarding the release.
> 
> I wrote a longer separate email to provide more context about the
> "pushing fast" comment.
> 
> I agree that we don't want to introduce a bad interface.
> 
> In regards to a way forward for 4.16, my suggestion is the following:
> 
> - revert this patch: do not change the interface in this series
>     - do not change anything related to CDF_vpci for x86
>     - for ARM, leave has_vpci(d) to { false } and do not set
>       XEN_DOMCTL_CDF_vpci
>     - we can discuss it in depth later on, no rush
> 
> - in patch #10, in libxl_arm.c:libxl__arch_domain_prepare_config
>     - do not set XEN_DOMCTL_CDF_vpci
>     - do not set b_info.arch_arm.vpci
>     - do not define LIBXL_HAVE_BUILDINFO_ARM_VPCI in libxl.h
>     - keep make_vpci_node and arch_arm.vpci
> 
> 
> The other patches (#1, #8, #10), which don't change any interfaces, can
> still make it for 4.16 if the review feedback is addressed on time, with
> one open TODO item [1].
> 
> This way, we get all the essential infrastructure we are trying to
> introduce without making any compromises on the external interfaces.
> Still it is good to have patches #1 #8 #10 so that with a trival
> oneliner patch on top of 4.16 we can enable PCI for ARM and do testing
> in the community, in gitlab-ci, and OSSTest too. (We have been
> discussing special OSSTest flights to valide PCI passthrough as we
> complete development.)

One more thing: I would really like to get at least patch #8 committed
because it would help with making progress with part 2 and part 3 of the
PCI enablement series. My preference would also be to get #1 and #10
in as well but I feel less strongly about it.
--8323329-800336767-1634163118=:9408--


From xen-devel-bounces@lists.xenproject.org Thu Oct 14 00:15:41 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Oct 2021 00:15:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.208941.365241 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maoP7-00033y-KC; Thu, 14 Oct 2021 00:15:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 208941.365241; Thu, 14 Oct 2021 00:15:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maoP7-00033r-H7; Thu, 14 Oct 2021 00:15:25 +0000
Received: by outflank-mailman (input) for mailman id 208941;
 Thu, 14 Oct 2021 00:15:23 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=kGop=PC=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1maoP5-00033l-JF
 for xen-devel@lists.xenproject.org; Thu, 14 Oct 2021 00:15:23 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id d1c37819-2c83-11ec-81a8-12813bfff9fa;
 Thu, 14 Oct 2021 00:15:21 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id A87D960BD3;
 Thu, 14 Oct 2021 00:15:20 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d1c37819-2c83-11ec-81a8-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1634170521;
	bh=q/2rCXwVxItexwfdQYgpAXhHnpYqj8SipO3MuGQbEiA=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=E6BRVkaa2u5Tfz9eSmrOSr6g/ZeKECXOhjqWsG6qjjpN/gw2aDrSMhWwmdSQV4tqI
	 QnBLN7Rux3Lvv6hPH1y2pOl3VX04Tyh1DyUlyNlTKC8RWtjcwhM+oX/qQpx99C7cn5
	 QH4HGmIgsJ4Lme5OpktFjzUttfqgyj7bH+AiDjFkTFgwN0eKZjUtyq9u9wNz30Bjwa
	 +U1YPZU7D3EW0REuza5Px7T0JhqjGaNVqEuOZXr4GDZ6UQHZRPJdhv7ly2dwB7yaXM
	 u/y2h6wIr9GSdCXEV2evOrrHx0zF7jJ/6Vu/hdJ7lqiPVEGLuHeagYX5Yw2RHUyXDG
	 5CuWHCl15AR5Q==
Date: Wed, 13 Oct 2021 17:15:19 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Sai Kiran Kumar Reddy Y <ysaikiran1997@gmail.com>
cc: Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>, 
    Bertrand Marquis <bertrand.marquis@arm.com>, 
    Jan Beulich <jbeulich@suse.com>, Luca Fancellu <luca.fancellu@arm.com>, 
    xen-devel@lists.xenproject.org, kannan@cimware.in
Subject: Re: Xen Booting Problem on ARM Machine
In-Reply-To: <CAEsO4ux_AqXBeCtbwnPAdnBnVYHTur_2EfcZBTuN4QKCq4ko8Q@mail.gmail.com>
Message-ID: <alpine.DEB.2.21.2110131711280.9408@sstabellini-ThinkPad-T480s>
References: <33C29853-D896-4E4E-91D3-4D2FA89A9B91@hxcore.ol> <eb5fd47b-6bc9-2eec-7f46-9ab9a42c9f1f@xen.org> <CAEsO4uzsCnsTtTmYHAT4NN6=girCY2NHHdAHbH6GG33D7jwe_A@mail.gmail.com> <alpine.DEB.2.21.2109131437030.10523@sstabellini-ThinkPad-T480s>
 <CAEsO4uwpiDO2QoqLRTOxpsYM9YSPAsbX0P=gagdEy21pk1VsPQ@mail.gmail.com> <alpine.DEB.2.21.2109141825330.21985@sstabellini-ThinkPad-T480s> <CAEsO4uyjNs97Cx8n2owDk4kKTVCycji377pm7aXHcPWzeszUTw@mail.gmail.com> <alpine.DEB.2.21.2109301942370.3209@sstabellini-ThinkPad-T480s>
 <CAEsO4ux_AqXBeCtbwnPAdnBnVYHTur_2EfcZBTuN4QKCq4ko8Q@mail.gmail.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="8323329-1922990394-1634170520=:9408"

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-1922990394-1634170520=:9408
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT

On Wed, 13 Oct 2021, Sai Kiran Kumar Reddy Y wrote:
> On Fri, Oct 1, 2021 at 8:17 AM Stefano Stabellini <sstabellini@kernel.org> wrote:
>       Yes there are other ways but without serial is going to be difficult
>       because you are not going to see anything until everything works.
> 
>       How do you boot Xen and Dom0 exactly from EDK2? Are you using GRUB or
>       loading Xen directly from the EDK2 prompt? Please provide as many
>       details as possible so that I might be able to spot any errors.
> 
> I am using GRUB to load Xen. In the GRUB menu, I see two options. 
> Option 1: Debian 11 with latest Linux Kernel
> Option 2: Debian 11(with Xen hypervisor) with latest Kernel
>  
>       Can you provide the Device Tree you are using? If you are not passing
>       any Device Tree  binary explicitely, then it might be passed
>       automatically from EDK2 to Linux/Xen. In that case, just boot from Linux
>       then do the following to retrieve the Device Tree:
> 
>       dtc -I fs -O dts /proc/device-tree > host.dts
> 
>       Then please attach host.dts to this email thread.
> 
> Yeah, you are right. It looks like LInux is booting from ACPI. In the bootloader menu, "Automatic ACPI configuration" is disabled. So, I
> thought that Linux may be booting from Device Tree. I have tried the "dtc" command you mentioned. But it looks like there's no device-tree
> under "/proc". I also tried to get DT info, from "/sys/firmware/devicetree/base" . But, there's no info. under devicetree folder. I am not
> quite sure how to get the DT info, if the Linux is booting from ACPI. I am attaching .dsl files, that contain the acpi info.

OK, so it is pretty clear that even if "Automatic ACPI configuration" is
disabled, it is still booting with ACPI.


>       Also for your information it looks like Linux actually booted from ACPI,
>       not from Device Tree, as you can see from all the "ACPI" messages in the
>       kernel logs.
> 
>       If you need to boot from ACPI, then you need to enable ACPI support in
>       Xen, which is disabled by default. You can do that using make
>       menuconfig.
> 
> In the make menuconfig of Xen, I do not see any option to enable ACPI.  

You definitely need to enable ACPI support in Xen, if you are booting
from ACPI, otherwise nothing is going to work.

On the latest staging (https://gitlab.com/xen-project/xen) you can
enable ACPI as follows:


# export CROSS_COMPILE=/path/to/cross-compiler
# export XEN_TARGET_ARCH=arm64
# cd xen.git/xen
# make menuconfig
#   --> Configure UNSUPPORTED features
#   --> Architecture Features --> ACPI
# make


Cheers,

Stefano


>       On Thu, 30 Sep 2021, Sai Kiran Kumar Reddy Y wrote:
>       > Hi,
>       > Sorry about the delay. We have been trying to access the serial of the machine. Tried with couple of JTAG connectors. There's
>       still no
>       > debug messages on the serial. Is there any other way of figuring this out?
>       >
>       > On Wed, Sep 15, 2021, 7:02 AM Stefano Stabellini <sstabellini@kernel.org> wrote:
>       >       Something is off. When you enabled earlyprintk in Xen, you should see
>       >       something like this at boot time:
>       >       https://marc.info/?l=xen-devel&m=158829968025334
>       >
>       >       All the Xen logs starting with "(XEN)" on the serial. Do you have access
>       >       to the serial of the machine? Without it, it is going to be hard to
>       >       debug.
>       >
>       >
>       >       On Tue, 14 Sep 2021, Sai Kiran Kumar Reddy Y wrote:
>       >       > In the folder "/var/log", there's a file called "xen", which is empty. As far as the boot logs are concerned, I don't
>       see any
>       >       debug
>       >       > messages related to xen. I am attaching the log files, "kern.txt" and "boot.txt"
>       >       >
>       >       > On Tue, Sep 14, 2021 at 3:08 AM Stefano Stabellini <sstabellini@kernel.org> wrote:
>       >       >       On Mon, 13 Sep 2021, Sai Kiran Kumar Reddy Y wrote:
>       >       >       > On Fri, Sep 10, 2021 at 7:30 PM Julien Grall <julien@xen.org> wrote:
>       >       >       >
>       >       >       >
>       >       >       >       On 08/09/2021 11:43, Sai Kiran wrote:
>       >       >       >       > Hello,
>       >       >       >
>       >       >       >       Hi,
>       >       >       >
>       >       >       >       Thank you for the report. Moving the discussion back to xen-devel
>       >       >       >       because this looks like a potential issue in the UEFI stub in Xen.
>       >       >       >
>       >       >       >       > I have Xen-4.15.0 on an ARM Machine, with Debian 11 installed on it.
>       >       >       >
>       >       >       >       Would you be able to give more details on the Arm machine you are using?
>       >       >       >       Also, are you using ACPI or DT to boot?
>       >       >       >
>       >       >       >
>       >       >       >    Sai >> DT . ACPI configuration is disabled in Boot settings    
>       >       >       >
>       >       >       >       >  I
>       >       >       >       > am able to do “make world” and “make install”, after “./configure”, as
>       >       >       >       > specified in README file. When I reboot the system, I get the following
>       >       >       >       > message:
>       >       >       >       >
>       >       >       >       > Warning: All 128 bootinfo mem banks exhausted.
>       >       >       >       >
>       >       >       >       > Warning: All 128 bootinfo mem banks exhausted.
>       >       >       >
>       >       >       >       Hmmm... This means that you have more than 128 memory regions described
>       >       >       >       in the EFI memory map. That's quite a lot.
>       >       >       >
>       >       >       >       Although, this should be harmless as it means Xen will not use the extra
>       >       >       >       memory banks.
>       >       >       >
>       >       >       >       >
>       >       >       >       > Cannot exit boot services: ErrCode: 0x8000000000000002
>       >       >       >
>       >       >       >       This means EFI_INVALID_PARAMETER. We have code to retry because AFAICT
>       >       >       >       ExitBootServices() may sometime fails (I have CCed Jan may have more
>       >       >       >       idea what's happening).
>       >       >       >
>       >       >       >       Would you be able to provide more details on the UEFI firmware you are
>       >       >       >       using? Is it EDK2 or U-boot?
>       >       >       >
>       >       >       > Sai >>  EDK2 
>       >       >       >       Also, do you know if Linux is boot on the same system?
>       >       >       >
>       >       >       > Sai >> Yes 
>       >       >       >       However, AFAICT, the error message would not prevent Xen to continue
>       >       >       >       booting. So you may get stuck later in the boot process.
>       >       >       >
>       >       >       >       My suggestion would be to enable earlyprintk for your platform. You can
>       >       >       >       setup it up from the menuconfig in "Debugging Options".
>       >       >       >
>       >       >       > Sai >> Yes, I have enabled earlyprintk.
>       >       >       > I tried changing NR_MEM_BANKS(in xen/include/asm-arm/setup.h) value to 256, from 128. The error message is no
>       longer
>       >       seen,
>       >       >       but the device
>       >       >       > is stuck in the boot process.
>       >       >
>       >       >       Could you please post the boot logs now that you enabled earlyprintk?
>       >       >       Ideally not a camera picture but a textual copy/paste from the target
>       >       >       serial?
>       >       >
>       >       >       Earlyprintk is pretty verbose, we should be able to figure out where it
>       >       >       gets stuck.
>       >       >
>       >       >
>       >       >
>       >
>       >
>       >
> 
> 
> 
--8323329-1922990394-1634170520=:9408--


From xen-devel-bounces@lists.xenproject.org Thu Oct 14 02:18:18 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Oct 2021 02:18:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.208949.365253 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maqJl-0007ih-GN; Thu, 14 Oct 2021 02:18:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 208949.365253; Thu, 14 Oct 2021 02:18:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maqJl-0007iZ-AF; Thu, 14 Oct 2021 02:18:01 +0000
Received: by outflank-mailman (input) for mailman id 208949;
 Thu, 14 Oct 2021 02:18:00 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1maqJk-0007iP-PY; Thu, 14 Oct 2021 02:18:00 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1maqJk-0005I6-At; Thu, 14 Oct 2021 02:18:00 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1maqJk-0002aW-0Z; Thu, 14 Oct 2021 02:18:00 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1maqJk-0000aG-07; Thu, 14 Oct 2021 02:18:00 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=Llv7f3bWxZZ95yhCuyQEDKngqK1r8A5dTw6vbEm8YUg=; b=3KK/depQYIUxzGI3odcN8YUFG/
	PANtqdV8zDo5huH9FYFqRLHPa7SDsQDNfRgUciSRSd9jYnH6vhKZX/+0VPA64ILsOCEvPxmKw61EK
	LNXX6MrZqFeanUQ52i01ZQLJUKiJWEnVR3n/jVdmRPjJyKZpeZNDuDmDaqY2IvAU+Jv0=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165501-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 165501: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=4cfab4425d39f76660b4e76ba6ee4cbf0f92e7e5
X-Osstest-Versions-That:
    xen=9e319e5258d0274c15da2ea9355dc1569a0fa832
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 14 Oct 2021 02:18:00 +0000

flight 165501 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165501/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  4cfab4425d39f76660b4e76ba6ee4cbf0f92e7e5
baseline version:
 xen                  9e319e5258d0274c15da2ea9355dc1569a0fa832

Last test of basis   165499  2021-10-13 19:00:29 Z    0 days
Testing same since   165501  2021-10-13 23:01:33 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Jan Beulich <jbeulich@suse.com>
  Julien Grall <jgrall@amazon.com>
  Luca Fancellu <luca.fancellu@arm.com>
  Rahul Singh <rahul.singh@arm.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   9e319e5258..4cfab4425d  4cfab4425d39f76660b4e76ba6ee4cbf0f92e7e5 -> smoke


From xen-devel-bounces@lists.xenproject.org Thu Oct 14 02:31:29 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Oct 2021 02:31:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.208958.365267 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maqWj-0001Vu-LW; Thu, 14 Oct 2021 02:31:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 208958.365267; Thu, 14 Oct 2021 02:31:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maqWj-0001Vn-IE; Thu, 14 Oct 2021 02:31:25 +0000
Received: by outflank-mailman (input) for mailman id 208958;
 Thu, 14 Oct 2021 02:31:24 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=X8q0=PC=arm.com=Penny.Zheng@srs-us1.protection.inumbo.net>)
 id 1maqWi-0001Vh-K4
 for xen-devel@lists.xenproject.org; Thu, 14 Oct 2021 02:31:24 +0000
Received: from EUR02-AM5-obe.outbound.protection.outlook.com (unknown
 [40.107.0.68]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id d17e60e4-2c96-11ec-81aa-12813bfff9fa;
 Thu, 14 Oct 2021 02:31:21 +0000 (UTC)
Received: from AM5PR1001CA0064.EURPRD10.PROD.OUTLOOK.COM
 (2603:10a6:206:15::41) by AS8PR08MB7308.eurprd08.prod.outlook.com
 (2603:10a6:20b:443::22) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.22; Thu, 14 Oct
 2021 02:31:20 +0000
Received: from AM5EUR03FT050.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:206:15:cafe::78) by AM5PR1001CA0064.outlook.office365.com
 (2603:10a6:206:15::41) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15 via Frontend
 Transport; Thu, 14 Oct 2021 02:31:20 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM5EUR03FT050.mail.protection.outlook.com (10.152.17.47) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.15 via Frontend Transport; Thu, 14 Oct 2021 02:31:18 +0000
Received: ("Tessian outbound 8e26f7114b75:v103");
 Thu, 14 Oct 2021 02:31:18 +0000
Received: from 09f25a91c7c8.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 00A1F934-E200-495E-B0B1-4463BDA1FCAB.1; 
 Thu, 14 Oct 2021 02:31:11 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 09f25a91c7c8.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Thu, 14 Oct 2021 02:31:11 +0000
Received: from VE1PR08MB5215.eurprd08.prod.outlook.com (2603:10a6:803:10a::33)
 by VE1PR08MB4751.eurprd08.prod.outlook.com (2603:10a6:802:a8::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15; Thu, 14 Oct
 2021 02:31:09 +0000
Received: from VE1PR08MB5215.eurprd08.prod.outlook.com
 ([fe80::41d6:b115:3b22:2cd]) by VE1PR08MB5215.eurprd08.prod.outlook.com
 ([fe80::41d6:b115:3b22:2cd%2]) with mapi id 15.20.4587.026; Thu, 14 Oct 2021
 02:31:09 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d17e60e4-2c96-11ec-81aa-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=bn7mgLhrkjaj2MX4ESAAL70QPY3DVpoN4RiYkiqh4/U=;
 b=nRzqAQ8saYHauQqgn5/2keaetYuzGz34rCSOkCMGJSzNy6gl269bhUgOBdKLLuhLvGbgXnZ0C0QvOk0OmojvTSU6UCJUlFtX8+fZRhjOHq/+SS4BumI3nFJ6d1eLyztEHtuk/eKLhUsKzOvHIjuwbGbrgWrwy3sCeuJtjzwOeDk=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=K0hKFvpOttzGNPDG2W6wM2bGQUraaekskAvQ0bBaACHJQZ+QmKL81N2yaQhHGHFrXOc9AKgLs9u26N6AC9C3F05EBdS8C/GlEeJEVJHj0cePcqhG5BgPSbNFC+EarZA2tKP+YBX+/M/ctO3mQjE4cbdi+MWLoiL0iCOYIw5XG5pXfZdAG6ip059vYGg1Cot2d28r2NJrIrHDLsBo2iXZiMAOOFbNAolLuVmj0Jj9ZlFvMe2dZDLAO35xspkedxSF0wJnkcUjhQZOPSN451OqYxsaU4MaIYGTP0KnW1IXNc10pwD+Q6fxotiQFDgv0UMVO7bYVHIyjsPf0VgRMjW8Iw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=bn7mgLhrkjaj2MX4ESAAL70QPY3DVpoN4RiYkiqh4/U=;
 b=SXSO3vPkujobg3figrWsCDLBnqCnL6TGnXv54+lb2+7Hatf30d5/3+oilqNI0byI3a5PAZoZaSu4TgER7wTQP7os2WpISkZt8E+EimPqsNBm3XMgy1CtCbRujfihQbMNLycXofdxicczzNc/c4ft6cjAAiYPdkCZQDPSYPKeeVXgotndsGVTb/Ze7873oJwLlVAYL64BnkFc/nXkKiI7KD9HaEm2+ISW5eMyKUDmZ5TVlITEiJJ10jt7gVtOTuELd6L/6ys2gGCXjt10p0NC71AiIKp6Cs6A9SzsumX1XwZ/lkDrhHfWIyOdJOuHnLZb5YZaZLpgUIjR2RlB786KjA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=bn7mgLhrkjaj2MX4ESAAL70QPY3DVpoN4RiYkiqh4/U=;
 b=nRzqAQ8saYHauQqgn5/2keaetYuzGz34rCSOkCMGJSzNy6gl269bhUgOBdKLLuhLvGbgXnZ0C0QvOk0OmojvTSU6UCJUlFtX8+fZRhjOHq/+SS4BumI3nFJ6d1eLyztEHtuk/eKLhUsKzOvHIjuwbGbrgWrwy3sCeuJtjzwOeDk=
From: Penny Zheng <Penny.Zheng@arm.com>
To: Julien Grall <julien@xen.org>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, "sstabellini@kernel.org"
	<sstabellini@kernel.org>
CC: Bertrand Marquis <Bertrand.Marquis@arm.com>, Wei Chen <Wei.Chen@arm.com>
Subject: RE: [PATCH 09/11] xen/arm: if 1:1 direct-map domain use native UART
 address and IRQ number for vPL011
Thread-Topic: [PATCH 09/11] xen/arm: if 1:1 direct-map domain use native UART
 address and IRQ number for vPL011
Thread-Index:
 AQHXsCjCE2lhlSGmBkKIt8npCa4pm6uxd+8AgBj2EFCAA0z5AIABBw7QgAKWNoCAAI4/YA==
Date: Thu, 14 Oct 2021 02:31:08 +0000
Message-ID:
 <VE1PR08MB5215AA3DFF87B05D7C058C53F7B89@VE1PR08MB5215.eurprd08.prod.outlook.com>
References: <20210923031115.1429719-1-penny.zheng@arm.com>
 <20210923031115.1429719-10-penny.zheng@arm.com>
 <db752d34-fc23-04b3-3c84-12d4de6859e0@xen.org>
 <VE1PR08MB5215F07156273D0822515E92F7B39@VE1PR08MB5215.eurprd08.prod.outlook.com>
 <45f31ced-f011-a8fd-5c80-822b9c731adb@xen.org>
 <VE1PR08MB5215C5883D3913F14C6F246AF7B69@VE1PR08MB5215.eurprd08.prod.outlook.com>
 <dc216ec4-1aa9-609d-c492-a60c59606c56@xen.org>
In-Reply-To: <dc216ec4-1aa9-609d-c492-a60c59606c56@xen.org>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: 0A0253575333B74093CDF0B9D106AFF7.0
x-checkrecipientchecked: true
Authentication-Results-Original: xen.org; dkim=none (message not signed)
 header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: 3e1a5fc0-6c0c-4a5d-3fdc-08d98ebab44b
x-ms-traffictypediagnostic: VE1PR08MB4751:|AS8PR08MB7308:
x-ms-exchange-transport-forked: True
X-Microsoft-Antispam-PRVS:
	<AS8PR08MB73080837B628BA3D3BEF53DEF7B89@AS8PR08MB7308.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:8273;OLM:8273;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 kSSy8u1Hk5vdcG79qVqt/yTuHOHyyKoKl9lWBkkorYZCsa8jSwjhMbu/Ynb0eVbQz8RK+VYIB5Pl0LHzJGGpkLN9sN5VR+dmMY0C0wze05b9ryngBOL3uTmnM3oRPQBQrpmH6xfGgWVxloLs0oZlpeaP8/KMsNVhHUN+XEPOHHFj7541kach/LS900q6gvFQWvCeYWVZs8oNne2uTqEPF+9NJ0kjyy//UhgLYwmnTzRWn5FL9Q/o5R1dECcBN5KJz+XxnvNeSDynYlvJDf7TSLW34edR8Mgt8IAUwVfpGEvrnqDfkh4+cinwCT6IRLGdoN5MmO91ZK6jneyy6lP0TOiLu+MrEdmoJYXD4hw9KII6sq2WTD8d97O+bPcztyM4Honb5ZnvYRwZmjYW6gf10FDPgCX9wSG4blPKyiVmh9fpJxqqcH3Y0eoWzWmSdn+mUW5PcrmmfNG2qvNls/064Dn9fwsKYXroRxYnbEiJocP8eE9X35nya/fUC6/XinpRY+2GoJy9iGAq9PzEOQWjVtTIpu6TBd7NCI9yiM0dEHrPIIGHFR2zHx7UEGdbWYx7XwAHGW9QvY1VJ1AIAI391NmjOicRHWyIWKscAvnozt2mgTWS+iWtOVp9I/ZIP2MN3co48YvBwa160cbzqdgv/Gl5oggiZjMMEaEpxyQ1SEGZIDV+ipmb3OhOK4RUOG2PQizU7s7vGKDxgKk2R3w3hQ==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR08MB5215.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(8676002)(64756008)(6506007)(2906002)(30864003)(38100700002)(122000001)(110136005)(33656002)(66946007)(66556008)(86362001)(38070700005)(508600001)(76116006)(7696005)(53546011)(316002)(5660300002)(66446008)(66476007)(71200400001)(52536014)(54906003)(9686003)(8936002)(55016002)(26005)(4326008)(83380400001)(186003);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB4751
Original-Authentication-Results: xen.org; dkim=none (message not signed)
 header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM5EUR03FT050.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	ad000eff-caba-4438-3dc5-08d98ebaae6a
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	FRke3YhH0gOZ6wVbBRPWofuzvcCVJGRphiSXf//4lEigfzWsJZL6MBhgpjCFY0TzkW37L98q1+a0NxlV5+b4zny5GbzLpz66nadCaPR/20iRXYWWG72PlsnckIZVbP6R/zBipujLYv9dUty5D7ivfk7EZGnO4vxe7I3eBI9QG2Vp/nFs8tAnPNVx6RZ1upCWy2WCSWJP/8fNoET0vMw34N680HoWQ0So/PpufNYC7E9nELeoohx4Q0nLX6dUGY4e6uIAD4l7D2pNurOjxN4C2AbEFdXFWyTqFiehu8DQEt7pLBvgdu0S7scroleUUP8ape/r8iYhSJ5NrSiifoH0Esf+mE3ILXVa232C25pI+g9KkOzKYOsrMTuFTJxrT3V2mThKaDYPxEhxnkjaUSTN7GIbAklkjIeYkVhhcqaqa8prryGOpMpIr5rJxqsV/XHmP2BFQ47Ewy/NBOBWONtsAfkj/qpcThULpZtHwLH2ZwP5btS1LvbvLHNjUQUC9gC2Va3I0xWg5GyWK8y8R2ptDGR9GdCZjsz2DJBmShryMycGL7HBRD944T06klGgnNESH9Afj+cNBjcs52Z8O9VaCe64Be1YChcJYOEPrF4JgeEYwF+1MWS1akmgpXgzj5CThLzTO7UCu8FV2ofv7KubkUq0wPoRaYXx9ZN4jfwu7t23ytE/UKtqGPSbVdTyiveYBqUOxPDddl0MZD4Zq7W5sQ==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(81166007)(186003)(8936002)(47076005)(4326008)(82310400003)(6506007)(7696005)(336012)(9686003)(316002)(83380400001)(110136005)(54906003)(53546011)(52536014)(26005)(356005)(8676002)(30864003)(70206006)(55016002)(2906002)(508600001)(70586007)(36860700001)(33656002)(5660300002)(86362001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2021 02:31:18.8737
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 3e1a5fc0-6c0c-4a5d-3fdc-08d98ebab44b
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM5EUR03FT050.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB7308

SGkgSnVsaWVuDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogSnVsaWVu
IEdyYWxsIDxqdWxpZW5AeGVuLm9yZz4NCj4gU2VudDogVGh1cnNkYXksIE9jdG9iZXIgMTQsIDIw
MjEgMjowMSBBTQ0KPiBUbzogUGVubnkgWmhlbmcgPFBlbm55LlpoZW5nQGFybS5jb20+OyB4ZW4t
ZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmc7DQo+IHNzdGFiZWxsaW5pQGtlcm5lbC5vcmcNCj4g
Q2M6IEJlcnRyYW5kIE1hcnF1aXMgPEJlcnRyYW5kLk1hcnF1aXNAYXJtLmNvbT47IFdlaSBDaGVu
DQo+IDxXZWkuQ2hlbkBhcm0uY29tPg0KPiBTdWJqZWN0OiBSZTogW1BBVENIIDA5LzExXSB4ZW4v
YXJtOiBpZiAxOjEgZGlyZWN0LW1hcCBkb21haW4gdXNlIG5hdGl2ZSBVQVJUDQo+IGFkZHJlc3Mg
YW5kIElSUSBudW1iZXIgZm9yIHZQTDAxMQ0KPiANCj4gT24gMTIvMTAvMjAyMSAwMzo0MiwgUGVu
bnkgWmhlbmcgd3JvdGU6DQo+ID4gSGkgSnVsaWVuDQo+IA0KPiBIaSBQZW5ueSwNCj4gDQo+ID4+
IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+ID4+IEZyb206IEp1bGllbiBHcmFsbCA8anVs
aWVuQHhlbi5vcmc+DQo+ID4+IFNlbnQ6IE1vbmRheSwgT2N0b2JlciAxMSwgMjAyMSA2OjQ5IFBN
DQo+ID4+IFRvOiBQZW5ueSBaaGVuZyA8UGVubnkuWmhlbmdAYXJtLmNvbT47DQo+ID4+IHhlbi1k
ZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZzsgc3N0YWJlbGxpbmlAa2VybmVsLm9yZw0KPiA+PiBD
YzogQmVydHJhbmQgTWFycXVpcyA8QmVydHJhbmQuTWFycXVpc0Bhcm0uY29tPjsgV2VpIENoZW4N
Cj4gPj4gPFdlaS5DaGVuQGFybS5jb20+DQo+ID4+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggMDkvMTFd
IHhlbi9hcm06IGlmIDE6MSBkaXJlY3QtbWFwIGRvbWFpbiB1c2UNCj4gPj4gbmF0aXZlIFVBUlQg
YWRkcmVzcyBhbmQgSVJRIG51bWJlciBmb3IgdlBMMDExDQo+ID4+DQo+ID4+IE9uIDA5LzEwLzIw
MjEgMDk6NDcsIFBlbm55IFpoZW5nIHdyb3RlOg0KPiA+Pj4gSGkgSnVsaWVuDQo+ID4+DQo+ID4+
IEhpIFBlbm55LA0KPiA+Pg0KPiA+Pj4+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+ID4+
Pj4gRnJvbTogSnVsaWVuIEdyYWxsIDxqdWxpZW5AeGVuLm9yZz4NCj4gPj4+PiBTZW50OiBUaHVy
c2RheSwgU2VwdGVtYmVyIDIzLCAyMDIxIDc6MTQgUE0NCj4gPj4+PiBUbzogUGVubnkgWmhlbmcg
PFBlbm55LlpoZW5nQGFybS5jb20+Ow0KPiA+Pj4+IHhlbi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0
Lm9yZzsgc3N0YWJlbGxpbmlAa2VybmVsLm9yZw0KPiA+Pj4+IENjOiBCZXJ0cmFuZCBNYXJxdWlz
IDxCZXJ0cmFuZC5NYXJxdWlzQGFybS5jb20+OyBXZWkgQ2hlbg0KPiA+Pj4+IDxXZWkuQ2hlbkBh
cm0uY29tPg0KPiA+Pj4+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggMDkvMTFdIHhlbi9hcm06IGlmIDE6
MSBkaXJlY3QtbWFwIGRvbWFpbiB1c2UNCj4gPj4+PiBuYXRpdmUgVUFSVCBhZGRyZXNzIGFuZCBJ
UlEgbnVtYmVyIGZvciB2UEwwMTENCj4gPj4+Pg0KPiA+Pj4+DQo+ID4+Pj4NCj4gPj4+PiBPbiAy
My8wOS8yMDIxIDA4OjExLCBQZW5ueSBaaGVuZyB3cm90ZToNCj4gPj4+Pj4gRnJvbTogU3RlZmFu
byBTdGFiZWxsaW5pIDxzdGVmYW5vLnN0YWJlbGxpbmlAeGlsaW54LmNvbT4NCj4gPj4+Pj4NCj4g
Pj4+Pj4gV2UgYWx3YXlzIHVzZSBhIGZpeCBhZGRyZXNzIHRvIG1hcCB0aGUgdlBMMDExIHRvIGRv
bWFpbnMuIFRoZQ0KPiA+Pj4+PiBhZGRyZXNzIGNvdWxkIGJlIGEgcHJvYmxlbSBmb3IgZG9tYWlu
cyB0aGF0IGFyZSBkaXJlY3RseSBtYXBwZWQuDQo+ID4+Pj4+DQo+ID4+Pj4+IFNvLCBmb3IgZG9t
YWlucyB0aGF0IGFyZSBkaXJlY3RseSBtYXBwZWQsIHJldXNlIHRoZSBhZGRyZXNzIG9mIHRoZQ0K
PiA+Pj4+PiBwaHlzaWNhbCBVQVJUIG9uIHRoZSBwbGF0Zm9ybSB0byBhdm9pZCBwb3RlbnRpYWwg
Y2xhc2hlcy4NCj4gPj4+Pj4NCj4gPj4+Pj4gRG8gdGhlIHNhbWUgZm9yIHRoZSB2aXJ0dWFsIElS
USBudW1iZXI6IGluc3RlYWQgb2YgYWx3YXlzIHVzaW5nDQo+ID4+Pj4+IEdVRVNUX1ZQTDAxMV9T
UEksIHRyeSB0byByZXVzZSB0aGUgcGh5c2ljYWwgU1BJIG51bWJlciBpZiBwb3NzaWJsZS4NCj4g
Pj4+Pj4NCj4gPj4+Pj4gU2lnbmVkLW9mZi1ieTogU3RlZmFubyBTdGFiZWxsaW5pIDxzdGVmYW5v
LnN0YWJlbGxpbmlAeGlsaW54LmNvbT4NCj4gPj4+Pj4gU2lnbmVkLW9mZi1ieTogUGVubnkgWmhl
bmcgPHBlbm55LnpoZW5nQGFybS5jb20+DQo+ID4+Pj4+IC0tLQ0KPiA+Pj4+PiAgICAgeGVuL2Fy
Y2gvYXJtL2RvbWFpbl9idWlsZC5jICB8IDM0DQo+ID4+Pj4+ICsrKysrKysrKysrKysrKysrKysr
KysrKysrKy0tLS0tDQo+ID4+IC0tDQo+ID4+Pj4+ICAgICB4ZW4vYXJjaC9hcm0vdnBsMDExLmMg
ICAgICAgIHwgMzQgKysrKysrKysrKysrKysrKysrKysrKysrKysrLS0tLS0tLQ0KPiA+Pj4+PiAg
ICAgeGVuL2luY2x1ZGUvYXNtLWFybS92cGwwMTEuaCB8ICAyICsrDQo+ID4+Pj4+ICAgICAzIGZp
bGVzIGNoYW5nZWQsIDU2IGluc2VydGlvbnMoKyksIDE0IGRlbGV0aW9ucygtKQ0KPiA+Pj4+Pg0K
PiA+Pj4+PiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gvYXJtL2RvbWFpbl9idWlsZC5jDQo+ID4+Pj4+
IGIveGVuL2FyY2gvYXJtL2RvbWFpbl9idWlsZC5jIGluZGV4IDEyMGYxYWU1NzUuLmM5MmU1MTBh
ZTcgMTAwNjQ0DQo+ID4+Pj4+IC0tLSBhL3hlbi9hcmNoL2FybS9kb21haW5fYnVpbGQuYw0KPiA+
Pj4+PiArKysgYi94ZW4vYXJjaC9hcm0vZG9tYWluX2J1aWxkLmMNCj4gPj4+Pj4gQEAgLTMwLDYg
KzMwLDcgQEANCj4gPj4+Pj4NCj4gPj4+Pj4gICAgICNpbmNsdWRlIDx4ZW4vaXJxLmg+DQo+ID4+
Pj4+ICAgICAjaW5jbHVkZSA8eGVuL2dyYW50X3RhYmxlLmg+DQo+ID4+Pj4+ICsjaW5jbHVkZSA8
eGVuL3NlcmlhbC5oPg0KPiA+Pj4+Pg0KPiA+Pj4+PiAgICAgc3RhdGljIHVuc2lnbmVkIGludCBf
X2luaXRkYXRhIG9wdF9kb20wX21heF92Y3B1czsNCj4gPj4+Pj4gICAgIGludGVnZXJfcGFyYW0o
ImRvbTBfbWF4X3ZjcHVzIiwgb3B0X2RvbTBfbWF4X3ZjcHVzKTsgQEAgLQ0KPiA+PiAxOTQyLDgN
Cj4gPj4+Pj4gKzE5NDMsMTEgQEAgc3RhdGljIGludCBfX2luaXQgbWFrZV92cGwwMTFfdWFydF9u
b2RlKHN0cnVjdA0KPiA+Pj4+PiAra2VybmVsX2luZm8NCj4gPj4+PiAqa2luZm8pDQo+ID4+Pj4+
ICAgICAgICAgZ2ljX2ludGVycnVwdF90IGludHI7DQo+ID4+Pj4+ICAgICAgICAgX19iZTMyIHJl
Z1tHVUVTVF9ST09UX0FERFJFU1NfQ0VMTFMgKw0KPiA+PiBHVUVTVF9ST09UX1NJWkVfQ0VMTFNd
Ow0KPiA+Pj4+PiAgICAgICAgIF9fYmUzMiAqY2VsbHM7DQo+ID4+Pj4+ICsgICAgc3RydWN0IGRv
bWFpbiAqZCA9IGtpbmZvLT5kOw0KPiA+Pj4+PiArICAgIGNoYXIgYnVmWzI3XTsNCj4gPj4+Pj4N
Cj4gPj4+Pj4gLSAgICByZXMgPSBmZHRfYmVnaW5fbm9kZShmZHQsICJzYnNhLQ0KPiA+PiB1YXJ0
QCJfX3N0cmluZ2lmeShHVUVTVF9QTDAxMV9CQVNFKSk7DQo+ID4+Pj4+ICsgICAgc25wcmludGYo
YnVmLCBzaXplb2YoYnVmKSwgInNic2EtdWFydEAlIlBSSXg2NCwgZC0NCj4gPj4+Pj4gYXJjaC52
cGwwMTEuYmFzZV9hZGRyKTsNCj4gPj4+Pj4gKyAgICByZXMgPSBmZHRfYmVnaW5fbm9kZShmZHQs
IGJ1Zik7DQo+ID4+Pj4+ICAgICAgICAgaWYgKCByZXMgKQ0KPiA+Pj4+PiAgICAgICAgICAgICBy
ZXR1cm4gcmVzOw0KPiA+Pj4+Pg0KPiA+Pj4+PiBAQCAtMTk1MywxNCArMTk1NywxNCBAQCBzdGF0
aWMgaW50IF9faW5pdA0KPiA+Pj4+PiBtYWtlX3ZwbDAxMV91YXJ0X25vZGUoc3RydWN0IGtlcm5l
bF9pbmZvICpraW5mbykNCj4gPj4+Pj4NCj4gPj4+Pj4gICAgICAgICBjZWxscyA9ICZyZWdbMF07
DQo+ID4+Pj4+ICAgICAgICAgZHRfY2hpbGRfc2V0X3JhbmdlKCZjZWxscywgR1VFU1RfUk9PVF9B
RERSRVNTX0NFTExTLA0KPiA+Pj4+PiAtICAgICAgICAgICAgICAgICAgICAgICBHVUVTVF9ST09U
X1NJWkVfQ0VMTFMsIEdVRVNUX1BMMDExX0JBU0UsDQo+ID4+Pj4+ICsgICAgICAgICAgICAgICAg
ICAgICAgIEdVRVNUX1JPT1RfU0laRV9DRUxMUywNCj4gPj4+Pj4gKyBkLT5hcmNoLnZwbDAxMS5i
YXNlX2FkZHIsDQo+ID4+Pj4+ICAgICAgICAgICAgICAgICAgICAgICAgICAgIEdVRVNUX1BMMDEx
X1NJWkUpOw0KPiA+Pj4+Pg0KPiA+Pj4+PiAgICAgICAgIHJlcyA9IGZkdF9wcm9wZXJ0eShmZHQs
ICJyZWciLCByZWcsIHNpemVvZihyZWcpKTsNCj4gPj4+Pj4gICAgICAgICBpZiAoIHJlcyApDQo+
ID4+Pj4+ICAgICAgICAgICAgIHJldHVybiByZXM7DQo+ID4+Pj4+DQo+ID4+Pj4+IC0gICAgc2V0
X2ludGVycnVwdChpbnRyLCBHVUVTVF9WUEwwMTFfU1BJLCAweGYsDQo+IERUX0lSUV9UWVBFX0xF
VkVMX0hJR0gpOw0KPiA+Pj4+PiArICAgIHNldF9pbnRlcnJ1cHQoaW50ciwgZC0+YXJjaC52cGww
MTEudmlycSwgMHhmLA0KPiA+Pj4+PiArIERUX0lSUV9UWVBFX0xFVkVMX0hJR0gpOw0KPiA+Pj4+
Pg0KPiA+Pj4+PiAgICAgICAgIHJlcyA9IGZkdF9wcm9wZXJ0eShmZHQsICJpbnRlcnJ1cHRzIiwg
aW50ciwgc2l6ZW9mIChpbnRyKSk7DQo+ID4+Pj4+ICAgICAgICAgaWYgKCByZXMgKQ0KPiA+Pj4+
PiBAQCAtMjY3MCw2ICsyNjc0LDEzIEBAIHN0YXRpYyBpbnQgX19pbml0IGNvbnN0cnVjdF9kb21V
KHN0cnVjdA0KPiA+Pj4+PiBkb21haW4NCj4gPj4+PiAqZCwNCj4gPj4+Pj4gICAgICAgICBlbHNl
DQo+ID4+Pj4+ICAgICAgICAgICAgIGFsbG9jYXRlX3N0YXRpY19tZW1vcnkoZCwgJmtpbmZvLCBu
b2RlKTsNCj4gPj4+Pj4NCj4gPj4+Pj4gKyAgICAvKg0KPiA+Pj4+PiArICAgICAqIEluaXRpYWxp
emF0aW9uIGJlZm9yZSBjcmVhdGluZyBpdHMgZGV2aWNlDQo+ID4+Pj4+ICsgICAgICogdHJlZSBu
b2RlIGluIHByZXBhcmVfZHRiX2RvbVUuDQo+ID4+Pj4+ICsgICAgICovDQo+ID4+Pj4NCj4gPj4+
PiBJIHRoaW5rIGl0IHdvdWxkIGJlIGJldHRlciB0byBleHBsYWluICp3aHkqIHRoaXMgbmVlZHMg
dG8gYmUgZG9uZSBiZWZvcmUuDQo+ID4+Pj4NCj4gPj4+Pj4gKyAgICBpZiAoIGtpbmZvLnZwbDAx
MSApDQo+ID4+Pj4+ICsgICAgICAgIHJjID0gZG9tYWluX3ZwbDAxMV9pbml0KGQsIE5VTEwpOw0K
PiA+Pj4+PiArDQo+ID4+Pj4+ICAgICAgICAgcmMgPSBwcmVwYXJlX2R0Yl9kb21VKGQsICZraW5m
byk7DQo+ID4+Pj4+ICAgICAgICAgaWYgKCByYyA8IDAgKQ0KPiA+Pj4+PiAgICAgICAgICAgICBy
ZXR1cm4gcmM7DQo+ID4+Pj4+IEBAIC0yNjc4LDkgKzI2ODksNiBAQCBzdGF0aWMgaW50IF9faW5p
dCBjb25zdHJ1Y3RfZG9tVShzdHJ1Y3QNCj4gPj4+Pj4gZG9tYWluDQo+ID4+Pj4gKmQsDQo+ID4+
Pj4+ICAgICAgICAgaWYgKCByYyA8IDAgKQ0KPiA+Pj4+PiAgICAgICAgICAgICByZXR1cm4gcmM7
DQo+ID4+Pj4+DQo+ID4+Pj4+IC0gICAgaWYgKCBraW5mby52cGwwMTEgKQ0KPiA+Pj4+PiAtICAg
ICAgICByYyA9IGRvbWFpbl92cGwwMTFfaW5pdChkLCBOVUxMKTsNCj4gPj4+Pj4gLQ0KPiA+Pj4+
PiAgICAgICAgIHJldHVybiByYzsNCj4gPj4+Pj4gICAgIH0NCj4gPj4+Pj4NCj4gPj4+Pj4gQEAg
LTI3MjMsMTUgKzI3MzEsMjcgQEAgdm9pZCBfX2luaXQgY3JlYXRlX2RvbVVzKHZvaWQpDQo+ID4+
Pj4+DQo+ID4+Pj4+ICAgICAgICAgICAgIGlmICggIWR0X3Byb3BlcnR5X3JlYWRfdTMyKG5vZGUs
ICJucl9zcGlzIiwgJmRfY2ZnLmFyY2gubnJfc3BpcykgKQ0KPiA+Pj4+PiAgICAgICAgICAgICB7
DQo+ID4+Pj4+ICsgICAgICAgICAgICB1bnNpZ25lZCBpbnQgdnBsMDExX3ZpcnEgPSBHVUVTVF9W
UEwwMTFfU1BJOw0KPiA+Pj4+DQo+ID4+Pj4gQ29kaW5nIHN0eWxlOiBBZGQgYSBuZXdsaW5lIGhl
cmUuDQo+ID4+Pj4NCj4gPj4+Pj4gICAgICAgICAgICAgICAgIGRfY2ZnLmFyY2gubnJfc3BpcyA9
IGdpY19udW1iZXJfbGluZXMoKSAtIDMyOw0KPiA+Pj4+Pg0KPiA+Pj4+PiArICAgICAgICAgICAg
LyoNCj4gPj4+Pj4gKyAgICAgICAgICAgICAqIFRoZSBWUEwwMTEgdmlycSBpcyBHVUVTVF9WUEww
MTFfU1BJLCB1bmxlc3MgZGlyZWN0LW1hcCBpbg0KPiA+Pj4+PiArICAgICAgICAgICAgICogc2V0
LCBpbiB3aGljaCBjYXNlIHdlJ2xsIHRyeSB0byBtYXRjaCB0aGUgaGFyZHdhcmUuDQo+ID4+Pj4+
ICsgICAgICAgICAgICAgKg0KPiA+Pj4+PiArICAgICAgICAgICAgICogVHlwaWNhbGx5LCBkLT5h
cmNoLnZwbDAxMS52aXJxIGhhcyB0aGUgdnBsMDExIGlycSBudW1iZXINCj4gPj4+Pj4gKyAgICAg
ICAgICAgICAqIGJ1dCBhdCB0aGlzIHBvaW50IG9mIHRoZSBib290IHNlcXVlbmNlIGl0IGlzIG5v
dA0KPiA+Pj4+PiArICAgICAgICAgICAgICogaW5pdGlhbGl6ZWQgeWV0Lg0KPiA+Pj4+PiArICAg
ICAgICAgICAgICovDQo+ID4+Pj4+ICsgICAgICAgICAgICBpZiAoIGRpcmVjdF9tYXAgJiYgc2Vy
aWFsX2lycShTRVJITkRfRFRVQVJUKSA+IDAgKQ0KPiA+Pj4+PiArICAgICAgICAgICAgICAgIHZw
bDAxMV92aXJxID0gc2VyaWFsX2lycShTRVJITkRfRFRVQVJUKTsNCj4gPj4+Pg0KPiA+Pj4+IEkg
dGhpbmsgd2Ugc2hvdWxkIG5vdCBjb250aW51ZSBpZiB0aGUgZG9tYWluIGlzIGRpcmVjdC1tYXBw
ZWQgKmFuZCoNCj4gPj4+PiB0aGUgSVJRIGlzIG5vdCBmb3VuZC4gT3RoZXJ3aXNlLCB0aGlzIHdp
bGwgbWF5IGp1c3QgcmVzdWx0IHRvDQo+ID4+Pj4gcG90ZW50aWFsIGJyZWFrYWdlIGlmIEdVRVNU
X1ZQTDAxMV9TUEkgaGFwcGVucyB0byBiZSB1c2VkIGZvciBhbiBIVw0KPiA+PiBkZXZpY2UuDQo+
ID4+Pj4NCj4gPj4+Pj4gKw0KPiA+Pj4+PiAgICAgICAgICAgICAgICAgLyoNCj4gPj4+Pj4gICAg
ICAgICAgICAgICAgICAqIHZwbDAxMSB1c2VzIG9uZSBlbXVsYXRlZCBTUEkuIElmIHZwbDAxMSBp
cyByZXF1ZXN0ZWQsIG1ha2UNCj4gPj4+Pj4gICAgICAgICAgICAgICAgICAqIHN1cmUgdGhhdCB3
ZSBhbGxvY2F0ZSBlbm91Z2ggU1BJcyBmb3IgaXQuDQo+ID4+Pj4+ICAgICAgICAgICAgICAgICAg
Ki8NCj4gPj4+Pj4gICAgICAgICAgICAgICAgIGlmICggZHRfcHJvcGVydHlfcmVhZF9ib29sKG5v
ZGUsICJ2cGwwMTEiKSApDQo+ID4+Pj4+ICAgICAgICAgICAgICAgICAgICAgZF9jZmcuYXJjaC5u
cl9zcGlzID0gTUFYKGRfY2ZnLmFyY2gubnJfc3BpcywNCj4gPj4+Pj4gLSAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgR1VFU1RfVlBMMDExX1NQSSAtIDMyICsgMSk7DQo+
ID4+Pj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHZwbDAxMV92
aXJxIC0gMzIgKyAxKTsNCj4gPj4+Pj4gICAgICAgICAgICAgfQ0KPiA+Pj4+Pg0KPiA+Pj4+PiAg
ICAgICAgICAgICAvKg0KPiA+Pj4+PiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gvYXJtL3ZwbDAxMS5j
IGIveGVuL2FyY2gvYXJtL3ZwbDAxMS5jIGluZGV4DQo+ID4+Pj4+IDg5NWY0MzZjYzQuLjEwZGYy
NWYwOTggMTAwNjQ0DQo+ID4+Pj4+IC0tLSBhL3hlbi9hcmNoL2FybS92cGwwMTEuYw0KPiA+Pj4+
PiArKysgYi94ZW4vYXJjaC9hcm0vdnBsMDExLmMNCj4gPj4+Pj4gQEAgLTI5LDYgKzI5LDcgQEAN
Cj4gPj4+Pj4gICAgICNpbmNsdWRlIDx4ZW4vbW0uaD4NCj4gPj4+Pj4gICAgICNpbmNsdWRlIDx4
ZW4vc2NoZWQuaD4NCj4gPj4+Pj4gICAgICNpbmNsdWRlIDx4ZW4vY29uc29sZS5oPg0KPiA+Pj4+
PiArI2luY2x1ZGUgPHhlbi9zZXJpYWwuaD4NCj4gPj4+Pj4gICAgICNpbmNsdWRlIDxwdWJsaWMv
ZG9tY3RsLmg+DQo+ID4+Pj4+ICAgICAjaW5jbHVkZSA8cHVibGljL2lvL2NvbnNvbGUuaD4NCj4g
Pj4+Pj4gICAgICNpbmNsdWRlIDxhc20vcGwwMTEtdWFydC5oPg0KPiA+Pj4+PiBAQCAtNzEsMTEg
KzcyLDExIEBAIHN0YXRpYyB2b2lkDQo+ID4+Pj4+IHZwbDAxMV91cGRhdGVfaW50ZXJydXB0X3N0
YXR1cyhzdHJ1Y3QNCj4gPj4+PiBkb21haW4gKmQpDQo+ID4+Pj4+ICAgICAgICAgICogc3RhdHVz
IGJpdCBoYXMgYmVlbiBzZXQgc2luY2UgdGhlIGxhc3QgdGltZS4NCj4gPj4+Pj4gICAgICAgICAg
Ki8NCj4gPj4+Pj4gICAgICAgICBpZiAoIHVhcnRtaXMgJiB+dnBsMDExLT5zaGFkb3dfdWFydG1p
cyApDQo+ID4+Pj4+IC0gICAgICAgIHZnaWNfaW5qZWN0X2lycShkLCBOVUxMLCBHVUVTVF9WUEww
MTFfU1BJLCB0cnVlKTsNCj4gPj4+Pj4gKyAgICAgICAgdmdpY19pbmplY3RfaXJxKGQsIE5VTEws
IHZwbDAxMS0+dmlycSwgdHJ1ZSk7DQo+ID4+Pj4+DQo+ID4+Pj4+ICAgICAgICAgdnBsMDExLT5z
aGFkb3dfdWFydG1pcyA9IHVhcnRtaXM7DQo+ID4+Pj4+ICAgICAjZWxzZQ0KPiA+Pj4+PiAtICAg
IHZnaWNfaW5qZWN0X2lycShkLCBOVUxMLCBHVUVTVF9WUEwwMTFfU1BJLCB1YXJ0bWlzKTsNCj4g
Pj4+Pj4gKyAgICB2Z2ljX2luamVjdF9pcnEoZCwgTlVMTCwgdnBsMDExLT52aXJxLCB1YXJ0bWlz
KTsNCj4gPj4+Pj4gICAgICNlbmRpZg0KPiA+Pj4+PiAgICAgfQ0KPiA+Pj4+Pg0KPiA+Pj4+PiBA
QCAtMzQ3LDcgKzM0OCw4IEBAIHN0YXRpYyBpbnQgdnBsMDExX21taW9fcmVhZChzdHJ1Y3QgdmNw
dSAqdiwNCj4gPj4+Pj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB2b2lkICpwcml2
KQ0KPiA+Pj4+PiAgICAgew0KPiA+Pj4+PiAgICAgICAgIHN0cnVjdCBoc3JfZGFidCBkYWJ0ID0g
aW5mby0+ZGFidDsNCj4gPj4+Pj4gLSAgICB1aW50MzJfdCB2cGwwMTFfcmVnID0gKHVpbnQzMl90
KShpbmZvLT5ncGEgLSBHVUVTVF9QTDAxMV9CQVNFKTsNCj4gPj4+Pj4gKyAgICB1aW50MzJfdCB2
cGwwMTFfcmVnID0gKHVpbnQzMl90KShpbmZvLT5ncGEgLQ0KPiA+Pj4+PiArDQo+ID4+Pj4+ICsg
di0+ZG9tYWluLT5hcmNoLnZwbDAxMS5iYXNlX2FkZHIpOw0KPiA+Pj4+PiAgICAgICAgIHN0cnVj
dCB2cGwwMTEgKnZwbDAxMSA9ICZ2LT5kb21haW4tPmFyY2gudnBsMDExOw0KPiA+Pj4+PiAgICAg
ICAgIHN0cnVjdCBkb21haW4gKmQgPSB2LT5kb21haW47DQo+ID4+Pj4+ICAgICAgICAgdW5zaWdu
ZWQgbG9uZyBmbGFnczsNCj4gPj4+Pj4gQEAgLTQzMCw3ICs0MzIsOCBAQCBzdGF0aWMgaW50IHZw
bDAxMV9tbWlvX3dyaXRlKHN0cnVjdCB2Y3B1ICp2LA0KPiA+Pj4+PiAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICB2b2lkICpwcml2KQ0KPiA+Pj4+PiAgICAgew0KPiA+Pj4+PiAgICAg
ICAgIHN0cnVjdCBoc3JfZGFidCBkYWJ0ID0gaW5mby0+ZGFidDsNCj4gPj4+Pj4gLSAgICB1aW50
MzJfdCB2cGwwMTFfcmVnID0gKHVpbnQzMl90KShpbmZvLT5ncGEgLSBHVUVTVF9QTDAxMV9CQVNF
KTsNCj4gPj4+Pj4gKyAgICB1aW50MzJfdCB2cGwwMTFfcmVnID0gKHVpbnQzMl90KShpbmZvLT5n
cGEgLQ0KPiA+Pj4+PiArDQo+ID4+Pj4+ICsgdi0+ZG9tYWluLT5hcmNoLnZwbDAxMS5iYXNlX2Fk
ZHIpOw0KPiA+Pj4+PiAgICAgICAgIHN0cnVjdCB2cGwwMTEgKnZwbDAxMSA9ICZ2LT5kb21haW4t
PmFyY2gudnBsMDExOw0KPiA+Pj4+PiAgICAgICAgIHN0cnVjdCBkb21haW4gKmQgPSB2LT5kb21h
aW47DQo+ID4+Pj4+ICAgICAgICAgdW5zaWduZWQgbG9uZyBmbGFnczsNCj4gPj4+Pj4gQEAgLTYy
MiwxMCArNjI1LDI3IEBAIGludCBkb21haW5fdnBsMDExX2luaXQoc3RydWN0IGRvbWFpbiAqZCwN
Cj4gPj4+Pj4gc3RydWN0DQo+ID4+Pj4gdnBsMDExX2luaXRfaW5mbyAqaW5mbykNCj4gPj4+Pj4g
ICAgIHsNCj4gPj4+Pj4gICAgICAgICBpbnQgcmM7DQo+ID4+Pj4+ICAgICAgICAgc3RydWN0IHZw
bDAxMSAqdnBsMDExID0gJmQtPmFyY2gudnBsMDExOw0KPiA+Pj4+PiArICAgIGNvbnN0IHN0cnVj
dCB2dWFydF9pbmZvICp1YXJ0ID0NCj4gPj4+Pj4gKyBzZXJpYWxfdnVhcnRfaW5mbyhTRVJITkRf
RFRVQVJUKTsNCj4gPj4+Pj4NCj4gPj4+Pj4gICAgICAgICBpZiAoIHZwbDAxMS0+YmFja2VuZC5k
b20ucmluZ19idWYgKQ0KPiA+Pj4+PiAgICAgICAgICAgICByZXR1cm4gLUVJTlZBTDsNCj4gPj4+
Pj4NCj4gPj4+Pj4gKyAgICB2cGwwMTEtPmJhc2VfYWRkciA9IEdVRVNUX1BMMDExX0JBU0U7DQo+
ID4+Pj4+ICsgICAgdnBsMDExLT52aXJxID0gR1VFU1RfVlBMMDExX1NQSTsNCj4gPj4+Pj4gKyAg
ICBpZiAoIGlzX2RvbWFpbl9kaXJlY3RfbWFwcGVkKGQpICkNCj4gPj4+Pj4gKyAgICB7DQo+ID4+
Pj4+ICsgICAgICAgIGlmICggdWFydCAhPSBOVUxMICYmIHNlcmlhbF9pcnEoU0VSSE5EX0RUVUFS
VCkgPiAwICkNCj4gPj4+Pj4gKyAgICAgICAgew0KPiA+Pj4+PiArICAgICAgICAgICAgdnBsMDEx
LT5iYXNlX2FkZHIgPSB1YXJ0LT5iYXNlX2FkZHI7DQo+ID4+Pj4+ICsgICAgICAgICAgICB2cGww
MTEtPnZpcnEgPSBzZXJpYWxfaXJxKFNFUkhORF9EVFVBUlQpOw0KPiA+Pj4+DQo+ID4+Pj4gVGhp
cyBzZWVtcyBhIGJpdCBwb2ludGxlc3MgdG8gY2FsbCBzZXJpYWxfaXJxKCkgdHdpY2UuIEhvdyBh
Ym91dA0KPiA+Pj4+IGFkZCBhIGZpZWxkIGluIHZ1YXJ0X2luZm8gdG8gcmV0dXJuIHRoZSBpbnRl
cnJ1cHQgbnVtYmVyPw0KPiA+Pj4+DQo+ID4+Pj4+ICsgICAgICAgIH0NCj4gPj4+Pj4gKyAgICAg
ICAgZWxzZQ0KPiA+Pj4+PiArICAgICAgICAgICAgcHJpbnRrKFhFTkxPR19FUlINCj4gPj4+Pj4g
KyAgICAgICAgICAgICAgICAgICAiVW5hYmxlIHRvIHJldXNlIHBoeXNpY2FsIFVBUlQgYWRkcmVz
cyBhbmQgaXJxIGZvcg0KPiB2UEwwMTEuXG4iDQo+ID4+Pj4+ICsgICAgICAgICAgICAgICAgICAg
IkRlZmF1bHRpbmcgdG8gYWRkciAlIyJQUklwYWRkciIgYW5kIElSUSAldVxuIiwNCj4gPj4+Pj4g
KyAgICAgICAgICAgICAgICAgICB2cGwwMTEtPmJhc2VfYWRkciwgdnBsMDExLT52aXJxKTsNCj4g
Pj4+Pj4gKyAgICB9DQo+ID4+Pj4+ICsNCj4gPj4+Pj4gICAgICAgICAvKg0KPiA+Pj4+PiAgICAg
ICAgICAqIGluZm8gaXMgTlVMTCB3aGVuIHRoZSBiYWNrZW5kIGlzIGluIFhlbi4NCj4gPj4+Pj4g
ICAgICAgICAgKiBpbmZvIGlzICE9IE5VTEwgd2hlbiB0aGUgYmFja2VuZCBpcyBpbiBhIGRvbWFp
bi4NCj4gPj4+Pj4gQEAgLTY2MSw3ICs2ODEsNyBAQCBpbnQgZG9tYWluX3ZwbDAxMV9pbml0KHN0
cnVjdCBkb21haW4gKmQsDQo+ID4+Pj4+IHN0cnVjdA0KPiA+Pj4+IHZwbDAxMV9pbml0X2luZm8g
KmluZm8pDQo+ID4+Pj4+ICAgICAgICAgICAgIH0NCj4gPj4+Pj4gICAgICAgICB9DQo+ID4+Pj4+
DQo+ID4+Pj4+IC0gICAgcmMgPSB2Z2ljX3Jlc2VydmVfdmlycShkLCBHVUVTVF9WUEwwMTFfU1BJ
KTsNCj4gPj4+Pj4gKyAgICByYyA9IHZnaWNfcmVzZXJ2ZV92aXJxKGQsIHZwbDAxMS0+dmlycSk7
DQo+ID4+Pj4+ICAgICAgICAgaWYgKCAhcmMgKQ0KPiA+Pj4+PiAgICAgICAgIHsNCj4gPj4+Pj4g
ICAgICAgICAgICAgcmMgPSAtRUlOVkFMOw0KPiA+Pj4+PiBAQCAtNjczLDEyICs2OTMsMTIgQEAg
aW50IGRvbWFpbl92cGwwMTFfaW5pdChzdHJ1Y3QgZG9tYWluICpkLA0KPiA+Pj4+PiBzdHJ1Y3QN
Cj4gPj4+PiB2cGwwMTFfaW5pdF9pbmZvICppbmZvKQ0KPiA+Pj4+PiAgICAgICAgIHNwaW5fbG9j
a19pbml0KCZ2cGwwMTEtPmxvY2spOw0KPiA+Pj4+Pg0KPiA+Pj4+PiAgICAgICAgIHJlZ2lzdGVy
X21taW9faGFuZGxlcihkLCAmdnBsMDExX21taW9faGFuZGxlciwNCj4gPj4+Pj4gLSAgICAgICAg
ICAgICAgICAgICAgICAgICAgR1VFU1RfUEwwMTFfQkFTRSwgR1VFU1RfUEwwMTFfU0laRSwgTlVM
TCk7DQo+ID4+Pj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgIHZwbDAxMS0+YmFzZV9hZGRy
LCBHVUVTVF9QTDAxMV9TSVpFLA0KPiA+Pj4+PiArIE5VTEwpOw0KPiA+Pj4+DQo+ID4+Pj4gU28g
eW91IGFyZSBtYWtpbmcgdGhlIGFzc3VtcHB0aW9uIHRoYXQgdGhlIFVBUlQgcmVnaW9uIHdpbGwg
YmUNCj4gPj4+PiBlcXVhbCB0byAob3INCj4gPj4+PiBiaWdnZXIpIHRoYW4gR1VFU1RfUEwwMTFf
U0laRS4gVGhlcmUgYXJlIGRlZmluaXRlbHkgVUFSVCBvdXQgd2hlcmUNCj4gPj4+PiB0aGUgTU1J
TyByZWdpb24gaXMgc21hbGxlciB0aGFuIDRLLg0KPiA+Pj4+DQo+ID4+Pg0KPiA+Pj4gU29ycnku
IEkgZ290IGEgZmV3IGNvbmZ1c2VkIGhlcmUsIHNpbmNlIEkgYW0gbm90IHZlcnkgZmFtaWxpYXIg
d2l0aA0KPiA+Pj4gcGwwMTEvVUFSVA0KPiA+PiBrbm93bGVkZ2UuDQo+ID4+Pg0KPiA+Pj4gUHJv
YmxlbXMgd2lsbCBvY2N1ciB3aGVuIFVBUlQgcmVnaW9uIGlzIGJpZ2dlciB0aGFuDQo+ID4+PiBH
VUVTVF9QTDAxMV9TSVpFLCBzaW5jZSB3ZSBhcmUgb25seSBjb25zaWRlcmluZyBNTUlPIHJlZ2lv
biBvZg0KPiA+Pj4gW3ZwbDAxMS0+YmFzZV9hZGRyLCB2cGwwMTEtIGJhc2VfYWRkciArIEdVRVNU
X1BMMDExX1NJWkVdLCByaWdodD8NCj4gPj4NCj4gPj4gSXQgaXMgaW4gZmFjdCB0aGUgb3RoZXIg
d2F5IGFyb3VuZC4gVGhlIHByb2JsZW0gd2lsbCBhcHBlYXIgaWYgdGhlDQo+ID4+IGhvc3QgVUFS
VCBNTUlPIHJlZ2lvbiBpcyBzbWFsbGVyIHRoYW4gdGhlIG9uZSB3ZSB3aWxsIGVtdWxhdGUgZm9y
IHRoZQ0KPiBndWVzdCBQTDAxMS4NCj4gPj4NCj4gPg0KPiA+IFNvcnJ5IHRvIGtlZXAgYm90aGVy
aW5nLg0KPiA+IElzIGl0IHRoYXQgYmVjYXVzZSB3aGVuIHRoZSBVQVJUIE1NSU8gcmVnaW9uIGlz
IHNtYWxsZXIgdGhhbiB0aGUgb25lDQo+ID4gd2UgZW11bGF0ZWQsIHJlZ2lzdGVyKERSLCBSU1Is
IEZSLCAuLi4pIHdpbGwgbm90IGJlIGF0IHRoZSBwbGFjZSB3aGVyZSB3ZQ0KPiBlbXVsYXRlZD8N
Cj4gDQo+IExldCBtZSBnaXZlIGFuIGV4YW1wbGUgdG8gY2xhcmlmeSBteSBwb2ludC4gT24gc29t
ZSBIYXJkd2FyZSAoSUlSQyBwaW5lNjQpLA0KPiB0aGUgVUFSVCBNTUlPIHJlZ2lvbiBpcyBsZXNz
IHRoYW4gNEtCLiBJbiBmYWN0LCB0aGVyZSBhcmUgbXVsdGlwbGUgZGV2aWNlDQo+IHdpdGhpbiB0
aGUgc2FtZSA0S0IgcmVnaW9uLg0KPiANCj4gQXQgdGhlIG1vbWVudCwgd2UgYXJlIHJlbW92aW5n
IHRob3NlIGRldmljZXMgYmVjYXVzZSB3ZSBjYW4ndCBhc3NpZ24gdG8gYQ0KPiBkb21haW4gYSBy
ZWdpb24gdGhhdCBpcyBub3QgcGFnZSBhbGlnbmVkICg0S0IgdG9kYXkpLiBCdXQgSSBjYW4gc2Vl
IHNvbWUNCj4gYmVuZWZpdHMgdG8gYmUgYWJsZSB0byBhc3NpZ24gc3VjaCBkZXZpY2VzIHRvIGRp
ZmZlcmVudCBkb21haW4veGVuLg0KPiBUbyBzdXBwb3J0IHRoZW0sIHdlIHdvdWxkIG5lZWQgdG8g
dHJhcCB0aGUgcmVnaW9uIGFuZCB0aGVuIGZvcndhcmQgb25seQ0KPiBhY2Nlc3MgdG8gYWRkcmVz
cyB0aGUgZG9tYWluIGNhbiBhY2Nlc3MuDQo+IA0KPiBUaGUgUEwwMTEgd2UgZW11bGF0ZSBmb3Ig
dGhlIGd1ZXN0IHJlcXVpcmUgYSA0S0IgcmVnaW9uLiBTbyB0aGlzIHdvdWxkDQo+IG92ZXJsYXAg
d2l0aCBvdGhlciBkZXZpY2UgaW4gdGhlIHNhbWUgcmVnaW9uIHdlIG1heSB3YW50IHRvIHRyYXAu
DQo+IA0KPiBGb3IgaXMgbm90IGFuIGlzc3VlIGZvciB0aGUgcmVhc29ucyBJIG1lbnRpb25uZWQg
YWJvdmUuIEhvd2V2ZXIsIEkgdGhpbmsgaXQgaXMgYQ0KPiBnb29kIGlkZWEgdG8gaGFyZGVuIHRo
ZSBjb2RlIGFuZCBhZGQgYSBjaGVjay9jb21tZW50IHdoZW4gd2Uga25vdw0KPiBwb3RlbnRpYWwg
cGl0ZmFsbHMuDQo+IA0KDQpVbmRlcnN0b29kLCBhIHRob3VzYW5kIHRoYW5rcyBmb3IgdGhlIGRl
dGFpbGVkIGV4cGxhbmF0aW9uISA7KQ0KDQo+IENoZWVycywNCj4gDQo+IC0tDQo+IEp1bGllbiBH
cmFsbA0K


From xen-devel-bounces@lists.xenproject.org Thu Oct 14 03:06:24 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Oct 2021 03:06:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.208968.365278 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mar4U-0004md-Hk; Thu, 14 Oct 2021 03:06:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 208968.365278; Thu, 14 Oct 2021 03:06:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mar4U-0004mW-D1; Thu, 14 Oct 2021 03:06:18 +0000
Received: by outflank-mailman (input) for mailman id 208968;
 Thu, 14 Oct 2021 03:06:17 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mar4T-0004mM-Cg; Thu, 14 Oct 2021 03:06:17 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mar4T-000659-0s; Thu, 14 Oct 2021 03:06:17 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mar4S-0004K0-Lv; Thu, 14 Oct 2021 03:06:16 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mar4S-0000F8-LO; Thu, 14 Oct 2021 03:06:16 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=hEhsC/MyrmUsRoxtyBlA07LO+4GuJ7kxL4jt801H548=; b=NrfWLJEuLqnQ+1xDeYSPqFLWHW
	BZiPH5VndFOoPw1GMeCBwh4KEcc5ngG7+WV54pRZLUC4UdfjvPIw0nKQyNDetTcPMyrkxOFKjHAaS
	FRtvuHZzY9Svf+rcFjPHlXd47YoYeyAC30klcbqxx9F8Z8+tL2Hx34Ho+hJo9LcR8Kw4=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165495-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-5.4 test] 165495: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable
    linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=940a14a7d844386c72f449045080dbbd86d1d244
X-Osstest-Versions-That:
    linux=e74e2950a0d6f800858e54860d7124c86e494f62
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 14 Oct 2021 03:06:16 +0000

flight 165495 linux-5.4 real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165495/

Failures :-/ but no regressions.

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds    18 guest-start/debian.repeat fail REGR. vs. 165206

Tests which did not succeed, but are not blocking:
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 165206
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 165206
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165206
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 165206
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165206
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165206
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 165206
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 165206
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 165206
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 165206
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 165206
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 165206
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 linux                940a14a7d844386c72f449045080dbbd86d1d244
baseline version:
 linux                e74e2950a0d6f800858e54860d7124c86e494f62

Last test of basis   165206  2021-09-26 12:42:13 Z   17 days
Failing since        165346  2021-10-04 12:42:32 Z    9 days   14 attempts
Testing same since   165495  2021-10-13 13:22:26 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Alan Stern <stern@rowland.harvard.edu>
  Alex Deucher <alexander.deucher@amd.com>
  Alexei Starovoitov <ast@kernel.org>
  Amit Pundir <amit.pundir@linaro.org>
  Anand K Mistry <amistry@google.com>
  Anders Roxell <anders.roxell@linaro.org>
  Andre Przywara <andre.przywara@arm.com>
  Andrea Claudi <aclaudi@redhat.com>
  Andreas Larsson <andreas@gaisler.com>
  Andrej Shadura <andrew.shadura@collabora.co.uk>
  Andrew Morton <akpm@linux-foundation.org>
  Andy Shevchenko <andriy.shevchenko@linux.intel.com>
  Anirudh Rayabharam <mail@anirudhrb.com>
  Anson Jacob <Anson.Jacob@amd.com>
  Antoine Tenart <atenart@kernel.org>
  Anton Eidelman <anton.eidelman@gmail.com>
  Anton Eidelman <anton@lightbitslabs.com>
  Antonio Martorana <amartora@codeaurora.org>
  Ariel Elior <aelior@marvell.com>
  Arnd Bergmann <arnd@arndb.de>
  Aswath Govindraju <a-govindraju@ti.com>
  Aya Levin <ayal@nvidia.com>
  Baokun Li <libaokun1@huawei.com>
  Bartosz Golaszewski <brgl@bgdev.pl>
  Ben Hutchings <ben@decadent.org.uk>
  Bixuan Cui <cuibixuan@huawei.com>
  Bjorn Andersson <bjorn.andersson@linaro.org>
  Bjorn Helgaas <bhelgaas@google.com>
  Borislav Petkov <bp@suse.de>
  Carlo Lobrano <c.lobrano@gmail.com>
  Catalin Marinas <catalin.marinas@arm.com>
  Catherine Sullivan <csully@google.com>
  Changbin Du <changbin.du@gmail.com>
  Charlene Liu <Charlene.Liu@amd.com>
  Chen Jingwen <chenjingwen6@huawei.com>
  Chih-Kang Chang <gary.chang@realtek.com>
  Chris Chiu <chris.chiu@canonical.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Brauner <christian.brauner@ubuntu.com>
  Christoph Hellwig <hch@lst.de>
  Chuck Lever <chuck.lever@oracle.com>
  Claudiu Manoil <claudiu.manoil@nxp.com>
  Cong Wang <cong.wang@bytedance.com>
  Dan Carpenter <dan.carpenter@oracle.com>
  Dan Li <ashimida@linux.alibaba.com>
  Dan Williams <dan.j.williams@intel.com>
  Daniel Borkmann <daniel@iogearbox.net>
  Daniel Lezcano <daniel.lezcano@linaro.org>
  Daniel Vetter <daniel.vetter@ffwll.ch>
  Daniel Wheeler <daniel.wheeler@amd.com>
  Dave Switzer <david.switzer@intel.com>
  David Heidelberg <david@ixit.cz>
  David Howells <dhowells@redhat.com>
  David S. Miller <davem@davemloft.net>
  David Sterba <dsterba@suse.com>
  Davide Caratti <dcaratti@redhat.com>
  Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
  Dmitry Bogdanov <d.bogdanov@yadro.com>
  Dongliang Mu <mudongliangabcd@gmail.com>
  Eric Biggers <ebiggers@google.com>
  Eric Dumazet <edumazet@google.com>
  F.A. SULAIMAN <asha.16@itfac.mrt.ac.lk>
  F.A.Sulaiman <asha.16@itfac.mrt.ac.lk>
  Faizel K B <faizel.kb@dicortech.com>
  Fares Mehanna <faresx@amazon.de>
  Felipe Balbi <balbi@kernel.org>
  Florian Fainelli <f.fainelli@gmail.com>
  Gao Xiang <hsiangkao@linux.alibaba.com>
  Geert Uytterhoeven <geert@linux-m68k.org>
  Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  Gregory CLEMENT <gregory.clement@bootlin.com>
  Guangbin Huang <huangguangbin2@huawei.com>
  Guenter Roeck <linux@roeck-us.net>
  Hans de Goede <hdegoede@redhat.com>
  Heikki Krogerus <heikki.krogerus@linux.intel.com>
  Helge Deller <deller@gmx.de>
  Herbert Xu <herbert@gondor.apana.org.au>
  Hulk Robot <hulkrobot@huawei.com>
  Igor Matheus Andrade Torrente <igormtorrente@gmail.com>
  Ilya Leoshkevich <iii@linux.ibm.com>
  J. Bruce Fields <bfields@redhat.com>
  Jacob Keller <jacob.e.keller@intel.com>
  Jakub Kicinski <kuba@kernel.org>
  James Morse <james.morse@arm.com>
  Jamie Iles <quic_jiles@quicinc.com>
  Jan Beulich <jbeulich@suse.com>
  Jan Kara <jack@suse.cz>
  Jason Andryuk <jandryuk@gmail.com>
  Jeffle Xu <jefflexu@linux.alibaba.com>
  Jens Axboe <axboe@kernel.dk>
  Jeroen de Borst <jeroendb@google.com>
  Jesper Nilsson <jesper.nilsson@axis.com>
  Jian Shen <shenjian15@huawei.com>
  Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
  Jiri Benc <jbenc@redhat.com>
  Jiri Kosina <jkosina@suse.cz>
  Jiri Slaby <jslaby@suse.cz>
  Johan Almbladh <johan.almbladh@anyfinetworks.com>
  Johan Hovold <johan@kernel.org>
  Johannes Berg <johannes.berg@intel.com>
  Johannes Thumshirn <jth@kernel.org>
  John Allen <john.allen@amd.com>
  Jon Hunter <jonathanh@nvidia.com>
  Jonathan Hsu <jonathan.hsu@mediatek.com>
  Jozsef Kadlecsik <kadlec@netfilter.org>
  Juergen Gross <jgross@suse.com>
  Julian Anastasov <ja@ssi.bg>
  Julian Sikorski <belegdol+github@gmail.com>
  Julian Sikorski <belegdol@gmail.com>
  Kaige Fu <kaige.fu@linux.alibaba.com>
  Kan Liang <kan.liang@linux.intel.com>
  Karol Herbst <kherbst@redhat.com>
  Karsten Graul <kgraul@linux.ibm.com>
  Kate Hsuan <hpa@redhat.com>
  Kevin Hao <haokexin@gmail.com>
  Kishon Vijay Abraham I <kishon@ti.com>
  Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
  Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
  Leon Yu <leoyu@nvidia.com>
  Li Jinlin <lijinlin3@huawei.com>
  Li Zhijian <lizhijian@cn.fujitsu.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Linux Kernel Functional Testing <lkft@linaro.org>
  Lorenzo Bianconi <lorenzo@kernel.org>
  Lukas Bulwahn <lukas.bulwahn@gmail.com>
  Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
  Marc Zyngier <maz@kernel.org>
  Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
  Marek Vasut <marex@denx.de>
  Marijn Suijten <marijn.suijten@somainline.org>
  Mark Brown <broonie@kernel.org>
  Mark Rutland <mark.rutland@arm.com>
  Markus Suvanto <markus.suvanto@gmail.com>
  Martin Blumenstingl <martin.blumenstingl@googlemail.com>
  Martin K. Petersen <martin.petersen@oracle.com>
  Mateusz Palczewski <mateusz.palczewski@intel.com>
  Max Filippov <jcmvbkbc@gmail.com>
  Michael Chan <michael.chan@broadcom.com>
  Michael Chan <michael.chan@broadocm.com>
  Michael Walle <michael@walle.cc>
  Michal Kalderon <mkalderon@marvell.com>
  Mika Westerberg <mika.westerberg@linux.intel.com>
  Mike Manning <mmanning@vyatta.att-mail.com>
  Mike Manning <mvrmanning@gmail.com>
  Miklos Szeredi <mszeredi@redhat.com>
  Minas Harutyunyan <Minas.Harutyunyan@synopsys.com>
  Ming Lei <ming.lei@redhat.com>
  Moritz Fischer <mdf@kernel.org>
  Nadezda Lutovinova <lutovinova@ispras.ru>
  Neil Armstrong <narmstrong@baylibre.com>
  Nicolas Ferre <nicolas.ferre@microchip.com>
  Nikolay Aleksandrov <nikolay@nvidia.com>
  Nirmoy Das <nirmoy.das@amd.com>
  Oleksij Rempel <o.rempel@pengutronix.de>
  Oliver Neukum <oneukum@suse.com>
  Ondrej Zary <linux@zary.sk>
  Ovidiu Panait <ovidiu.panait@windriver.com>
  Pablo Neira Ayuso <pablo@netfilter.org>
  Pali Rohár <pali@kernel.org>
  Palmer Dabbelt <palmerdabbelt@google.com>
  Paolo Bonzini <pbonzini@redhat.com>
  Patrick Ho <Patrick.Ho@netapp.com>
  Paul Burton <paulburton@kernel.org>
  Paul Fertser <fercerpav@gmail.com>
  Pavel Skripkin <paskripkin@gmail.com>
  Pawel Laszczak <pawell@cadence.com>
  Peter Zijlstra (Intel) <peterz@infradead.org>
  Ping-Ke Shih <pkshih@realtek.com>
  Piotr Krysiuk <piotras@gmail.com>
  Qu Wenruo <wqu@suse.com>
  Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
  Randy Dunlap <rdunlap@infradead.org>
  Rik van Riel <riel@surriel.com>
  Ritesh Harjani <riteshh@linux.ibm.com>
  Rob Herring <robh@kernel.org>
  Roger Quadros <rogerq@kernel.org>
  Ronnie Sahlberg <lsahlber@redhat.com>
  Roopa Prabhu <roopa@nvidia.com>
  Sai Krishna Potthuri <lakshmi.sai.krishna.potthuri@xilinx.com>
  Salvatore Bonaccorso <carnil@debian.org>
  Samuel Iglesias Gonsalvez <siglesias@igalia.com>
  Sasha Levin <sashal@kernel.org>
  Scott Wood <oss@buserror.net>
  Sean Anderson <sean.anderson@seco.com>
  Sergey Senozhatsky <senozhatsky@chromium.org>
  Shai Malin <smalin@marvell.com>
  Shawn Guo <shawn.guo@linaro.org>
  Shawn Guo <shawnguo@kernel.org>
  Shuah Khan <skhan@linuxfoundation.org>
  Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
  Simon Horman <horms@verge.net.au>
  Slark Xiao <slark_xiao@163.com>
  Song Liu <songliubraving@fb.com>
  Srinivas Pandruvada <srinivas.pI andruvada@linux.intel.com>
  Stefan Assmann <sassmann@redhat.com>
  Steve French <stfrench@microsoft.com>
  Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
  sumiyawang <sumiyawang@tencent.com>
  Sylwester Dziedziuch <sylwesterx.dziedziuch@intel.com>
  syzbot+47b26cd837ececfc666d@syzkaller.appspotmail.com
  syzbot+fadc0aaf497e6a493b9f@syzkaller.appspotmail.com
  Tariq Toukan <tariqt@nvidia.com>
  Tatsuhiko Yasumatsu <th.yasumatsu@gmail.com>
  Tejun Heo <tj@kernel.org>
  Theodore Ts'o <tytso@mit.edu>
  Thomas Gleixner <tglx@linutronix.de>
  Tiezhu Yang <yangtiezhu@loongson.cn>
  Todd Kjos <tkjos@google.com>
  Tom Rix <trix@redhat.com>
  Tong Zhang <ztong0001@gmail.com>
  Tony Lindgren <tony@atomide.com>
  Tony Nguyen <anthony.l.nguyen@intel.com>
  Trond Myklebust <trond.myklebust@hammerspace.com>
  Tyler Hicks <tyhicks@linux.microsoft.com>
  Ulf Hansson <ulf.hansson@linaro.org>
  Uwe Brandt <uwe.brandt@gmail.com>
  Vadim Pasternak <vadimp@nvidia.com>
  Vasily Gorbik <gor@linux.ibm.com>
  Vinicius Costa Gomes <vinicius.gomes@intel.com>
  Viresh Kumar <viresh.kumar@linaro.org>
  Vlad Buslov <vladbu@nvidia.com>
  Vladimir Oltean <vladimir.oltean@nxp.com>
  Wen Xiong <wenxiong@linux.ibm.com>
  Wengang Wang <wen.gang.wang@oracle.com>
  Wolfram Sang <wsa@kernel.org>
  Xiao Liang <shaw.leon@gmail.com>
  Xin Long <lucien.xin@gmail.com>
  Xu Yang <xu.yang_2@nxp.com>
  Yang Yingliang <yangyingliang@huawei.com>
  yangerkun <yangerkun@huawei.com>
  Yonghong Song <yhs@fb.com>
  Zelin Deng <zelin.deng@linux.alibaba.com>
  zhang kai <zhangkaiheb@126.com>
  Zheng Liang <zhengliang6@huawei.com>
  Zhihao Cheng <chengzhihao1@huawei.com>
  Zong-Zhe Yang <kevin_yang@realtek.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   e74e2950a0d6..940a14a7d844  940a14a7d844386c72f449045080dbbd86d1d244 -> tested/linux-5.4


From xen-devel-bounces@lists.xenproject.org Thu Oct 14 03:15:01 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Oct 2021 03:15:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.208978.365292 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1marCs-0006GT-It; Thu, 14 Oct 2021 03:14:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 208978.365292; Thu, 14 Oct 2021 03:14:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1marCs-0006GM-Fk; Thu, 14 Oct 2021 03:14:58 +0000
Received: by outflank-mailman (input) for mailman id 208978;
 Thu, 14 Oct 2021 03:14:57 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=UXqQ=PC=gmail.com=jiangshanlai@srs-us1.protection.inumbo.net>)
 id 1marCr-0006GG-MO
 for xen-devel@lists.xenproject.org; Thu, 14 Oct 2021 03:14:57 +0000
Received: from mail-pj1-x1031.google.com (unknown [2607:f8b0:4864:20::1031])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 334e81b3-187c-4192-a6a1-e48b0f5a26f6;
 Thu, 14 Oct 2021 03:14:56 +0000 (UTC)
Received: by mail-pj1-x1031.google.com with SMTP id
 nn3-20020a17090b38c300b001a03bb6c4ebso3778585pjb.1
 for <xen-devel@lists.xenproject.org>; Wed, 13 Oct 2021 20:14:56 -0700 (PDT)
Received: from localhost ([198.11.178.15])
 by smtp.gmail.com with ESMTPSA id k22sm7642008pji.2.2021.10.13.20.14.54
 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
 Wed, 13 Oct 2021 20:14:55 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 334e81b3-187c-4192-a6a1-e48b0f5a26f6
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=ziZjbhk8BT0M+YtJUf8+KJKDTqKEqXLQXXRoPitasKI=;
        b=iWuXzaQWCMhU5v19VMpnlWp/Jum8n4MoQtULYxxJagOYZObl+bVS3CEPLl2rzQ6vVN
         eDVOVVEjcuu9jqTAUCmrq6SYz1tytz37yyjDnRXIhlY/r4QGegWVd7f6unmtKmxOYf9D
         aO5a+oJU8AlBuBcE3jibd6ItG4Hk4M1Q8gzFXdrGvgI1G+xArTZSVhrxkkG0NXDXhz8P
         xNwqNW0c9vM7JXMGH1L3OefuH8/opsYc9SYyvnVu+GFGz4Iwbj88Cq3x51w9pDKxQzG5
         goZ0hDwJgNPfmrw0Q9lQGZD1ChQ4myvSogoV5jze0Yrp4aJ9jg1fiBhcgXvAsnaNclTN
         m0Fw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=ziZjbhk8BT0M+YtJUf8+KJKDTqKEqXLQXXRoPitasKI=;
        b=2mJ7VPJ3Jk2bMK4JzGXEeg/il5pzBSBYCd0/eFBxqQ9Zsd86BrFSNXtwY3FnhNprWd
         RaRKdDf2DMzE8uKgQFDW1F4wk3FOR+K5v+jP3smdS3BzCc1AJhcMl4ZcBpUhp5Onen6s
         6zgNSNHksQPjSr7F27RJ009bS5cbivkDwZNK2hNwxC/RCS4dbb1khjYhhbYshEPdRsGC
         XZ+/lBGfGt1wbOWVnB3RS0M47dDXaSC8XqniTb14bTr8XFo51Gr8aKzyy0z8wpLZxj/t
         wNVusrAzM6/ULKeYGwsGDuSzJrxYy0GMFX2G3GpEiGy37o0DHaZdrBQTtbwWNo2i4YOq
         XKGw==
X-Gm-Message-State: AOAM533BlOlZkn3h97rmsUQDh4Z95/IsEsAssP1PQ890LT0jU5k3wXSS
	UkAJVgOjd3zCtpWnnUuzbNI=
X-Google-Smtp-Source: ABdhPJzpkAN6dWN7KdDgWgpczxPhJkz1xZ6tOUDKx0cpvgpNGxI52fkzkbxcU59sU3BkgbKJoHIyPg==
X-Received: by 2002:a17:902:8494:b0:13b:9365:6f12 with SMTP id c20-20020a170902849400b0013b93656f12mr2783213plo.19.1634181295802;
        Wed, 13 Oct 2021 20:14:55 -0700 (PDT)
From: Lai Jiangshan <jiangshanlai@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: x86@kernel.org,
	Lai Jiangshan <laijs@linux.alibaba.com>,
	Jan Beulich <jbeulich@suse.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Juergen Gross <jgross@suse.com>,
	Peter Anvin <hpa@zytor.com>,
	xen-devel@lists.xenproject.org,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Andy Lutomirski <luto@kernel.org>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Stefano Stabellini <sstabellini@kernel.org>
Subject: [PATCH V3 04/49] x86/xen: Add xenpv_restore_regs_and_return_to_usermode()
Date: Thu, 14 Oct 2021 11:13:27 +0800
Message-Id: <20211014031413.14471-5-jiangshanlai@gmail.com>
X-Mailer: git-send-email 2.19.1.6.gb485710b
In-Reply-To: <20211014031413.14471-1-jiangshanlai@gmail.com>
References: <20211014031413.14471-1-jiangshanlai@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Lai Jiangshan <laijs@linux.alibaba.com>

While in the native case, PER_CPU_VAR(cpu_tss_rw + TSS_sp0) is the
trampoline stack.  But XEN pv doesn't use trampoline stack, so
PER_CPU_VAR(cpu_tss_rw + TSS_sp0) is also the kernel stack.  Hence source
and destination stacks are identical in that case, which means reusing
swapgs_restore_regs_and_return_to_usermode() in XEN pv would cause %rsp
to move up to the top of the kernel stack and leave the IRET frame below
%rsp, which is dangerous to be corrupted if #NMI / #MC hit as either of
these events occurring in the middle of the stack pushing would clobber
data on the (original) stack.

And swapgs_restore_regs_and_return_to_usermode() pushing the IRET frame
on to the original address is useless and error-prone when there is any
future attempt to modify the code.

Fixes: 7f2590a110b8 ("x86/entry/64: Use a per-CPU trampoline stack for IDT entries")
Cc: Jan Beulich <jbeulich@suse.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Juergen Gross <jgross@suse.com>
Cc: Peter Anvin <hpa@zytor.com>
Cc: xen-devel@lists.xenproject.org>
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Signed-off-by: Lai Jiangshan <laijs@linux.alibaba.com>
---
 arch/x86/entry/entry_64.S        |  9 ++++++---
 arch/x86/entry/entry_64_compat.S |  7 ++++---
 arch/x86/xen/xen-asm.S           | 27 +++++++++++++++++++++++++++
 3 files changed, 37 insertions(+), 6 deletions(-)

diff --git a/arch/x86/entry/entry_64.S b/arch/x86/entry/entry_64.S
index 9d468c8877e2..0dde5a253dda 100644
--- a/arch/x86/entry/entry_64.S
+++ b/arch/x86/entry/entry_64.S
@@ -119,7 +119,7 @@ SYM_INNER_LABEL(entry_SYSCALL_64_after_hwframe, SYM_L_GLOBAL)
 	 * In the Xen PV case we must use iret anyway.
 	 */
 
-	ALTERNATIVE "", "jmp	swapgs_restore_regs_and_return_to_usermode", \
+	ALTERNATIVE "", "jmp xenpv_restore_regs_and_return_to_usermode", \
 		X86_FEATURE_XENPV
 
 	movq	RCX(%rsp), %rcx
@@ -286,7 +286,8 @@ SYM_CODE_START(ret_from_fork)
 	UNWIND_HINT_REGS
 	movq	%rsp, %rdi
 	call	syscall_exit_to_user_mode	/* returns with IRQs disabled */
-	jmp	swapgs_restore_regs_and_return_to_usermode
+	ALTERNATIVE "jmp swapgs_restore_regs_and_return_to_usermode",	\
+		"jmp xenpv_restore_regs_and_return_to_usermode", X86_FEATURE_XENPV
 
 1:
 	/* kernel thread */
@@ -566,6 +567,7 @@ __irqentry_text_start:
 __irqentry_text_end:
 
 SYM_CODE_START_LOCAL(common_interrupt_return)
+SYM_INNER_LABEL(xenpv_restore_regs_and_return_to_usermode, SYM_L_WEAK) /* placeholder */
 SYM_INNER_LABEL(swapgs_restore_regs_and_return_to_usermode, SYM_L_GLOBAL)
 #ifdef CONFIG_DEBUG_ENTRY
 	/* Assert that pt_regs indicates user mode. */
@@ -1055,7 +1057,8 @@ SYM_CODE_START_LOCAL(error_return)
 	DEBUG_ENTRY_ASSERT_IRQS_OFF
 	testb	$3, CS(%rsp)
 	jz	restore_regs_and_return_to_kernel
-	jmp	swapgs_restore_regs_and_return_to_usermode
+	ALTERNATIVE "jmp swapgs_restore_regs_and_return_to_usermode",	\
+		"jmp xenpv_restore_regs_and_return_to_usermode", X86_FEATURE_XENPV
 SYM_CODE_END(error_return)
 
 /*
diff --git a/arch/x86/entry/entry_64_compat.S b/arch/x86/entry/entry_64_compat.S
index 0051cf5c792d..2a4d9532dfd5 100644
--- a/arch/x86/entry/entry_64_compat.S
+++ b/arch/x86/entry/entry_64_compat.S
@@ -139,7 +139,7 @@ SYM_INNER_LABEL(entry_SYSENTER_compat_after_hwframe, SYM_L_GLOBAL)
 	call	do_SYSENTER_32
 	/* XEN PV guests always use IRET path */
 	ALTERNATIVE "testl %eax, %eax; jz swapgs_restore_regs_and_return_to_usermode", \
-		    "jmp swapgs_restore_regs_and_return_to_usermode", X86_FEATURE_XENPV
+		    "jmp xenpv_restore_regs_and_return_to_usermode", X86_FEATURE_XENPV
 	jmp	sysret32_from_system_call
 
 .Lsysenter_fix_flags:
@@ -256,7 +256,7 @@ SYM_INNER_LABEL(entry_SYSCALL_compat_after_hwframe, SYM_L_GLOBAL)
 	call	do_fast_syscall_32
 	/* XEN PV guests always use IRET path */
 	ALTERNATIVE "testl %eax, %eax; jz swapgs_restore_regs_and_return_to_usermode", \
-		    "jmp swapgs_restore_regs_and_return_to_usermode", X86_FEATURE_XENPV
+		    "jmp xenpv_restore_regs_and_return_to_usermode", X86_FEATURE_XENPV
 
 	/* Opportunistic SYSRET */
 sysret32_from_system_call:
@@ -411,5 +411,6 @@ SYM_CODE_START(entry_INT80_compat)
 
 	movq	%rsp, %rdi
 	call	do_int80_syscall_32
-	jmp	swapgs_restore_regs_and_return_to_usermode
+	ALTERNATIVE "jmp swapgs_restore_regs_and_return_to_usermode",	\
+		"jmp xenpv_restore_regs_and_return_to_usermode", X86_FEATURE_XENPV
 SYM_CODE_END(entry_INT80_compat)
diff --git a/arch/x86/xen/xen-asm.S b/arch/x86/xen/xen-asm.S
index 220dd9678494..032be1bab113 100644
--- a/arch/x86/xen/xen-asm.S
+++ b/arch/x86/xen/xen-asm.S
@@ -20,6 +20,7 @@
 
 #include <linux/init.h>
 #include <linux/linkage.h>
+#include <../entry/calling.h>
 
 .pushsection .noinstr.text, "ax"
 /*
@@ -192,6 +193,32 @@ SYM_CODE_START(xen_iret)
 	jmp hypercall_iret
 SYM_CODE_END(xen_iret)
 
+/*
+ * XEN pv doesn't use trampoline stack, PER_CPU_VAR(cpu_tss_rw + TSS_sp0) is
+ * also the kernel stack.  Reusing swapgs_restore_regs_and_return_to_usermode()
+ * in XEN pv would cause %rsp to move up to the top of the kernel stack and
+ * leave the IRET frame below %rsp, which is dangerous to be corrupted if #NMI
+ * interrupts. And swapgs_restore_regs_and_return_to_usermode() pushing the IRET
+ * frame at the same address is useless.
+ */
+SYM_CODE_START(xenpv_restore_regs_and_return_to_usermode)
+	UNWIND_HINT_REGS
+#ifdef CONFIG_DEBUG_ENTRY
+	/* Assert that pt_regs indicates user mode. */
+	testb	$3, CS(%rsp)
+	jnz	1f
+	ud2
+1:
+#endif
+	POP_REGS
+
+	/* stackleak_erase() can work safely on the kernel stack. */
+	STACKLEAK_ERASE_NOCLOBBER
+
+	addq	$8, %rsp	/* skip regs->orig_ax */
+	jmp xen_iret
+SYM_CODE_END(xenpv_restore_regs_and_return_to_usermode)
+
 /*
  * Xen handles syscall callbacks much like ordinary exceptions, which
  * means we have:
-- 
2.19.1.6.gb485710b



From xen-devel-bounces@lists.xenproject.org Thu Oct 14 04:31:23 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Oct 2021 04:31:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.208988.365303 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1masOX-0005EP-8z; Thu, 14 Oct 2021 04:31:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 208988.365303; Thu, 14 Oct 2021 04:31:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1masOX-0005EI-5s; Thu, 14 Oct 2021 04:31:05 +0000
Received: by outflank-mailman (input) for mailman id 208988;
 Thu, 14 Oct 2021 04:31:04 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1masOW-0005E8-82; Thu, 14 Oct 2021 04:31:04 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1masOV-0007UO-WA; Thu, 14 Oct 2021 04:31:04 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1masOV-0007qT-Ln; Thu, 14 Oct 2021 04:31:03 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1masOV-0003rk-LF; Thu, 14 Oct 2021 04:31:03 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=66k23NQfbHc6tfUpo7h0J2r7/pudJ5fRReN3tSVA6kM=; b=hs1PJbrrtkw+xUzivqdLHeG+ud
	z/a+fQ2PgRvd3LB/F+dPrbaffxvvOHnansBPMXRIQ573/syYRwEVePcT/7Ds0uG1p0/WIiZWf/q4A
	gucS2rU12DOgPP3H799bfQ5Ur4HW+6qDJYRYrIK92D6plwSmc3L8ndVCxRouP+E3kOQw=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165497-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 165497: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=348949d9a4440abdab3b1dc99a9bb660e8c7da7c
X-Osstest-Versions-That:
    linux=f4d0cc426f77df6890aa868f96c2de89686aae8a
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 14 Oct 2021 04:31:03 +0000

flight 165497 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165497/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 165483
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 165483
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165483
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165483
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 165483
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165483
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 165483
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 165483
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 linux                348949d9a4440abdab3b1dc99a9bb660e8c7da7c
baseline version:
 linux                f4d0cc426f77df6890aa868f96c2de89686aae8a

Last test of basis   165483  2021-10-12 19:09:34 Z    1 days
Testing same since   165497  2021-10-13 15:09:28 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Arnd Bergmann <arnd@arndb.de>
  Jessica Yu <jeyu@kernel.org>
  Kees Cook <keescook@chromium.org>
  Linus Torvalds <torvalds@linux-foundation.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   f4d0cc426f77..348949d9a444  348949d9a4440abdab3b1dc99a9bb660e8c7da7c -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Thu Oct 14 06:23:52 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Oct 2021 06:23:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.208997.365316 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mau9S-0007DQ-CY; Thu, 14 Oct 2021 06:23:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 208997.365316; Thu, 14 Oct 2021 06:23:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mau9S-0007DJ-9J; Thu, 14 Oct 2021 06:23:38 +0000
Received: by outflank-mailman (input) for mailman id 208997;
 Thu, 14 Oct 2021 06:23:36 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Xl23=PC=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mau9Q-0007DD-Kg
 for xen-devel@lists.xenproject.org; Thu, 14 Oct 2021 06:23:36 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 4239f1ca-2cb7-11ec-81ad-12813bfff9fa;
 Thu, 14 Oct 2021 06:23:35 +0000 (UTC)
Received: from EUR03-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur03lp2054.outbound.protection.outlook.com [104.47.9.54]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-29-0oQXwG44M46ia-Rd5p31rw-1; Thu, 14 Oct 2021 08:23:32 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB5902.eurprd04.prod.outlook.com (2603:10a6:803:ed::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16; Thu, 14 Oct
 2021 06:23:31 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.016; Thu, 14 Oct 2021
 06:23:31 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM5PR0101CA0032.eurprd01.prod.exchangelabs.com (2603:10a6:206:16::45) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.14 via Frontend
 Transport; Thu, 14 Oct 2021 06:23:29 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4239f1ca-2cb7-11ec-81ad-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634192614;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=nUWzsmsy7qodbHa1J9ZOYegQeH7WMfsiYxysA5X4aqU=;
	b=mT6uhcaClTSCvl044S0rGRZPbO9+ndldTWrSe4fAfb6Q3U0PFWRptW2SGRdt0UgMt4jXXr
	MSIUyouA2Ycr8495gxOZ7vZv2MZSIi7Csoq5YIWFbEPJUYVygkGyHutzk/hS/tWlIbRFYC
	NV4BJiou8tq4JbU8bJP/SxBYMjAb0Os=
X-MC-Unique: 0oQXwG44M46ia-Rd5p31rw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=hdhpFIIJduNtKQMhbTasOv8bowLGQg5Iw2qLRJngeMteuhQKvCHgj3Etum3EUdVvYQMpKJ/cdc55UWOgGTzO/unNqYEhUf4O91P7hB2iVZ7UxgbrdqVEc5t6SWkdAAbaxPsH4Jg3CN8wQJF9QsVSnnjRkGDQrXuUm6Wk2s0RN4JGVAYg0l3osA29f+hshMgwM8xvajgUNVCsF90f9NsqBmCuagLsiOFOzMhf3fAZfXUPfu1p29Z5ZLaiUtg+qdqUgYAzIOiNJf7eBWS403yAH13uGe5TDkmCHmwKve3WuPNMhcEoMN7ZIfKkt5EzrSMdw65u289iyI7Ji5SK+qzsXg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=oPXr0b8YbwCUDxSUanIoirkFFYAi4vkLFc0dNSKGKRE=;
 b=YPPOtcuE1KX7S1tz4Sur10UTfn1MFdVVvQ/vMoWEL7O6z/BrMbfr3k3j9aMSf2W+cSk8lBri1LrUZGVI4rotBTTtIILpgUeaojQjnYOizhbD0X4d75C+DM9KpInaJrpRiYMjd4Z2HvR1CnvBvegiAmXTOIbDJdA+QDwYNQhrxtRj/rWsvyeiI7F/kTioB6xoek8WI6ys4yzonsWRo1mgOtsYRtwEJSSpolVzvJ8nmHSBPGRr2RRdaXQroqPGuOqV3Iknq3/tmqttrR08bEvJfqRpKP0jZtwjf/ccb2hoClGB0IGiU8l7lEP5LwNH0MnCWQyIDa2GGD7u9eYwBqTZoA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: citrix.com; dkim=none (message not signed)
 header.d=none;citrix.com; dmarc=none action=none header.from=suse.com;
Subject: Re: [PATCH v5 07/11] xen/domctl: Introduce XEN_DOMCTL_CDF_vpci flag
To: Stefano Stabellini <sstabellini@kernel.org>
CC: Bertrand Marquis <Bertrand.Marquis@arm.com>,
 Michal Orzel <Michal.Orzel@arm.com>, Rahul Singh <Rahul.Singh@arm.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andre Przywara <Andre.Przywara@arm.com>,
 Christian Lindig <christian.lindig@citrix.com>, David Scott
 <dave@recoil.org>, Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <cover.1633540842.git.rahul.singh@arm.com>
 <20d5b9d6a0d01a7b90711d28cbefb5701a88b438.1633540842.git.rahul.singh@arm.com>
 <YWQDguvmf/O4rDIs@MacBook-Air-de-Roger.local>
 <9217a6b8-fc53-a049-7cd3-7458b574424b@arm.com>
 <YWaZKX44IOfIBtX6@MacBook-Air-de-Roger.local>
 <8F9D6B9C-58CB-4000-995A-95517EE72A3B@arm.com>
 <YWa7eGr3D8Ax8VUX@MacBook-Air-de-Roger.local>
 <9C5C0FE2-67EA-4CD7-893B-82C156F5F77A@arm.com>
 <e88892cf-e0c3-c39c-dce8-bfe2d25a5b53@suse.com>
 <alpine.DEB.2.21.2110131113212.9408@sstabellini-ThinkPad-T480s>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <291330d4-73c4-7893-7735-23c21ba04ccb@suse.com>
Date: Thu, 14 Oct 2021 08:23:28 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <alpine.DEB.2.21.2110131113212.9408@sstabellini-ThinkPad-T480s>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM5PR0101CA0032.eurprd01.prod.exchangelabs.com
 (2603:10a6:206:16::45) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: b1eeddaf-c1fa-4161-6fe7-08d98edb244d
X-MS-TrafficTypeDiagnostic: VI1PR04MB5902:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB5902043053EF4B23576E5DC2B3B89@VI1PR04MB5902.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	u/ke90tNqoOiVn5xiGdL2VyI43MwwQjLkQzH/I4sN6ccDQg7Od+YiFYDG71KElSfsIwHbNDLCM0B2fK9dphCo2WJeTfIoHv8na3fVnPLQjZ/n+v9/Quoifyq/MV/j+KeKBrX8Ii48XTk7XHv8HirPH3x5/3fqK0tRpW/Ump1MTvOptJwiQdVY2uk5xGGo+zhuvrq9P2K7n/zLMab8iu5nPeAVZwbjNwSLdtXGItH8wJ6t/zhKgRs5HQK3ptPiBVxrt7WwyZKq4iz83u28wTFS54qRIkMwRoo/2dDwsrFLxayzGkAGyk/7JoKrva+tSwhew3Z5zF3JucVM+5+VaTcZiRfNmGqg+or6D0jYkp1m83cC/QSQlzRqqlyJBjl9yPDzEhpmpMqP9JspzvYO27gJAYqAcFrtCnzI3zFdyyPg2VkDsf5MYlrdug1P/SpRF/RxghRsvAKqdBM8m7rkIS6HNZQTHL0ZwQ6E/DMHU0QU8PBttm39HQ54QSWWHOOiBuAM1lJ39C2xAhl6Z0giGyYm4VHVkT1uKstvAfLrx7hWKIhR6uobA4S4RCB0eQOcyWVYg7qSzx8FM2n+Ladgt42DAyoa5eCnspy89eSsWW5/IfdnWYxoRkdnTBft9tFCKVy9qAQZIkedbg4E2Sjp8EUYd2QH4Qa6ENkcSbOHdUCE5i6p+jIzD2P5LXEVcUJrEVhkNLCwv8HaQaY9jGzk93P+gLL9SBu44zS+84NNkh8jNxci47h2HDymglHy3KLQdZ3wvSI1NZpGU80J/WS8LDajByuEhpanFgId/1eScc9Ay36p+0jDLgbMc3IF8o4IWGQ
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(38100700002)(966005)(186003)(36756003)(66476007)(66946007)(66556008)(31686004)(6486002)(4326008)(83380400001)(508600001)(6916009)(53546011)(7416002)(2906002)(26005)(31696002)(8676002)(54906003)(5660300002)(956004)(2616005)(8936002)(86362001)(316002)(16576012)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?34gj4gEqZeKCWeoaYbiGMKLHlLCjl+2MFYZmKUkEUHx9kFwD8V5qfSdka+FV?=
 =?us-ascii?Q?3tCOG4LKU279AbkZ39RSSt17Pwi1CjuoFkU0JaLT4xD4bMkzdTwLMB/ocVyh?=
 =?us-ascii?Q?v5/NrbaGzIncejNY4vHL+5PvyAclfS2jTsk890LHYSVIFV95m+zNi41b9SU+?=
 =?us-ascii?Q?zSsc4ba4J4lnnoRTyU7d7ddxDZ5svV1cnAs0XdpKaOaUX11CWgcDIp6iP0J5?=
 =?us-ascii?Q?D/JE4sR5H8qzZtHICc/KSfFtQVfEbTE2VNTA7JTbPQjp+JYanFLMEOSRsLmb?=
 =?us-ascii?Q?nc2Zud+UWKGyP8dLd2MKDL/E7vp25zG8i80pv1v4pZsX6DewMI7hKdyxpScn?=
 =?us-ascii?Q?+4+J79/pl2pH9CYsdlskz7zFhJauuUi2xU33pzLMaAZsNpsLipDWeuY5n/RL?=
 =?us-ascii?Q?SSKVRs+UHRX1tauQUqpg7QyMgX7FBqf2CbJR5TYEOpGWLIj1pWY7OW0qxyT/?=
 =?us-ascii?Q?DZPc8EF1uqHcKoHcgFmjY9r4denNp6DwCDsvyfns0/ruyfcbmYdjGwVyzn/6?=
 =?us-ascii?Q?kdmHBVlhhvdkteNaSAItnBzMmww04S0uk2HiDM0iP1a6YLHvv9kQwKBatKC7?=
 =?us-ascii?Q?swysrJwhmkFKWsVvRgDKNDheyxPrp/0NqyRVK4+vwVzv7Q0oxjpO+eS9cKn0?=
 =?us-ascii?Q?/cjR+9tRAjXjD3TcYq+Wz0suKCalidslQdoQKVsyVbqUmuctttnngaEkUjfE?=
 =?us-ascii?Q?wI9doUmIkiSgKg2Cmu/TnBZgN+pz4VEK/003i4m1EbGS+LKeyyEDYMFLV9c3?=
 =?us-ascii?Q?fVuL59aztXv/D8s0JJvXtoXjMHYZyv5QZSzXHw701LFYTO1J6ZOtLJ/JrSI3?=
 =?us-ascii?Q?yZANUZqvAagtHkrIbXyZ7G4jej28qeDs91q+dGypWMa3vx1MreAwXMorJO/s?=
 =?us-ascii?Q?cFLvfH/Qmn4ktHOc2WmMqCao6fsMyR7dGhpSBdFu0M9skHpIwaau298sUo6u?=
 =?us-ascii?Q?YCqp6/ox6c03meokOkCPkIJ1U5HvfERGLy9s1PYt99y7q5LXpRhM+2MpCGXS?=
 =?us-ascii?Q?QXMzJVyTQVGhd6eCvujqHesz4v5R/kkOk66S1xMJBK1F8PDTh/2E1l6ssyfX?=
 =?us-ascii?Q?kMOo8hsa9W00JK+FI3aT7L6GHSDCjHyf8+ZRDiYELqN9egdA+ijfwWW3h0pL?=
 =?us-ascii?Q?oIh/eQD2K4rcQvo7l6Bz/UL53glDxexRD+ng2A8L8acvRtZrZSiNyI/raMqS?=
 =?us-ascii?Q?nbDu688qlK8Y68GVNpDw5+WWmaBz6ZBWzcfoQ5FmcsZ08uJujIOz2Y9kDtw0?=
 =?us-ascii?Q?l90mH4/MGG+jShI4dOAR3xWRDp/hIM7EuwicdnqYb99o5f7AcuMLIi9enCxa?=
 =?us-ascii?Q?W9A0EduNnWHSIjMvcV2qhqju?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b1eeddaf-c1fa-4161-6fe7-08d98edb244d
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2021 06:23:31.2179
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: f+WzxVkUdbf6njaWl8S/th/SxkOTqQIXakVJHk7bemEr9JVy8e7l8RFx+PIUVZF23PkUIVEAeWCoMZuYDsQugw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5902

On 13.10.2021 22:41, Stefano Stabellini wrote:
> On Wed, 13 Oct 2021, Jan Beulich wrote:
>> On 13.10.2021 14:11, Bertrand Marquis wrote:
>>>> On 13 Oct 2021, at 11:56, Roger Pau Monn=C3=A9 <roger.pau@citrix.com> =
wrote:
>>>> If vPCI for Arm on 4.16 is not going to be functional, why so much
>>>> pressure in pushing those patches so fast? I understand the need to
>>>> remove stuff from the queue, but I don't think it's worth the cost of
>>>> introducing a broken interface deliberately on a release.
>>
>> +1
>>
>>> We did not push that fast, those have been on the mailing list for a wh=
ile (this is the 5th version of the serie).
>>> PCI passthrough is a big change requiring lots of patches and we decide=
d to push it piece by piece to make
>>> the review easier.
>>
>> 5 versions for a series like this one was to be expected. Imo it has
>> been wrong in the past to rush in new features (even if experimental
>> ones) very close to the freeze, and it has mislead people to think
>> they can delay work until very (too?) late a point in time.
>=20
>=20
> Hi Roger, Jan,
>=20
> Let me take a few minutes to clarify and provide context for this work.
>=20
>=20
> I don't think anyone "pushed hard" any of the ARM series close to the
> release. I sent "one" email in public as a reminder of things that need
> reviewing:
> https://marc.info/?l=3Dxen-devel&m=3D163373776611154
>=20
> I did send a couple of private emails to Jan but they were to synchronize
> ourselves rather than push; Jan, I hope you didn't take them the wrong
> way.

Definitely not, no worries.

> At the same time it is certainly true that all the people involved here
> worked very hard to get these series ready for 4.16. Oct 15 is the Xen
> Project feature freeze. It is also the deadline for many of us working
> with upstream Xen Project to upstream features and report back to our
> management. I know it doesn't affect you guys directly, but you can
> imagine that as employees of our respective companies we feel pressure
> to complete our objectives in the given timeframe. Of course we need to
> make sure to do that without compromising quality and without
> overextending upstream review capacity.
>=20
>=20
> The ARM PCI series are public since Dec 2020, pushed to a gitlab branch
> for testing: https://gitlab.com/xen-project/fusa/xen-integration/-/tree/i=
ntegration/pci-passthrough
> I helped creating, managing and testing the branch.
>=20
> So, I can see why Bertrand feels like they have been around for a while:
> we have been dealing with these patches for almost a year, even if from
> a xen-devel perspective we are "only" at version 5.

I'm afraid that anything not on xen-devel doesn't really count; the list
is the only "official" channel. ISTR that for certain aspects there's a
plan George has to make this more pronounced / formal in some of the docs
we have.

Making internally set deadlines is a fully understandable aspect. But
starting to post in September for a mid-October deadline is putting
oneself at risk, I would say, for a (set of) series this involved. I see
no problem with anyone doing so, as long as they accept that risk rather
than expecting to get away by either extraordinary efforts by others
(reviewers) or relaxation of what is permitted to go in.

Of course there's the opposite problem of feedback taking unusually (I'm
inclined to say unduly) long to arrive, like with the gpaddr_bits
addition still facing vague / unclear opposition by Andrew.

> My suggestion is to accept the TODO for patch #8 [1] but I agree with
> Roger that we shouldn't introduce bad interfaces, especially as they
> impact x86 which is not "tech preview". So I think we should revert
> patch #7 (this patch.) I'll reply with more details in separate shorter
> email.
>=20
> [1] https://marc.info/?l=3Dxen-devel&m=3D163412120531248

FWIW I agree with both proposals (acceptance of TODO and revert).

Jan



From xen-devel-bounces@lists.xenproject.org Thu Oct 14 06:33:51 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Oct 2021 06:33:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.209007.365327 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mauJH-0000HY-Fd; Thu, 14 Oct 2021 06:33:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 209007.365327; Thu, 14 Oct 2021 06:33:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mauJH-0000HQ-Cd; Thu, 14 Oct 2021 06:33:47 +0000
Received: by outflank-mailman (input) for mailman id 209007;
 Thu, 14 Oct 2021 06:33:46 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Xl23=PC=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mauJG-0000HC-2K
 for xen-devel@lists.xenproject.org; Thu, 14 Oct 2021 06:33:46 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id a56a6897-5383-478e-85a8-7c55052c78da;
 Thu, 14 Oct 2021 06:33:44 +0000 (UTC)
Received: from EUR03-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur03lp2050.outbound.protection.outlook.com [104.47.10.50]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-22-f6blBYJHM-CsWXqRncd5aQ-1; Thu, 14 Oct 2021 08:33:42 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0402MB2704.eurprd04.prod.outlook.com (2603:10a6:800:b5::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18; Thu, 14 Oct
 2021 06:33:40 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.016; Thu, 14 Oct 2021
 06:33:40 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS9PR06CA0395.eurprd06.prod.outlook.com (2603:10a6:20b:461::30) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.14 via Frontend
 Transport; Thu, 14 Oct 2021 06:33:39 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a56a6897-5383-478e-85a8-7c55052c78da
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634193223;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=a3k18KUY7Mn8P5CtXXSuSc7R5hcBANkGDL8fbmqL+iw=;
	b=P94ScAkvBrEOw70SM6ieoDtVNh1tVABsosO1FF/AdsFjMoJNZn5sm/uq0JSOULhgp0DDnE
	OHob+y7RRWpXV5vOt00vP7u/AkDbwXpsupH1OX7bFw0tKx0DBph+E5cIOYrcMPLkBRfjGl
	pK/+ksqLW/SoxVNXv9dLKlG1g+sXA2I=
X-MC-Unique: f6blBYJHM-CsWXqRncd5aQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=QaoPtkfmOh7bkH2YLwSIIt5XFR1IDM+hUN6FuOfY3t5Mmg0gCdu5XbS9Wlixns5r7AeZtJf5K5VtmVveFyIeTkybJaRr64Q+ixQaIQRnHoZ5pKB9ihEQc5bQ+pXFkfh4V1a+Pso09riuywT0fSUtLCjs1fQVH83GTv050JPqOeMhOy/oUybVdlUk8w0CENEAPjhk76vjSNukdC/9Z6KzzlBT1bAo3zAuBE5tzSMtfDhbK4bhKgtwNGzIE7e1hTYhQ3XPGlNK76Qx1OrY/abGdRHiCJhCh9sMOUW4SIu1WBLzvXJWU5l/JPU1Z7zESelrWSyWXbt6pHkdyuPq5ZwB5A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=DF1riM5pNfGR8+fE8PW3t6daVf0J6gApoTEvMQazbi8=;
 b=TNoAgH9Tmcx/Zi22/pgshbK1/kbLLVIgPAwrESdpIZjCnYxBHcbypC0ocOjVQJNInYeudmFzHbRJm3M9xdv/cfLVh2G7+6DiNmKUvO4kPqdpU/9s6zCiRvcDh0mFeikueLtd75ORcBT8ko3H2frWShbfGWZXmRG9qZpeVEGCHS95qnCVNpVky3CkU7gNaeKVudIuuB7uxDZ1UZb7jXGcgTeNQBa7AIyxPKdVcvUQVL1uBgvMUpFDZmKJKrPhaIu/nAaU1PNRGAIHAihXFenBaVh/HuEVYbromfNEKEyY2Fv7tMKz26Dxl2n/WgyJZdytGDWBNoDUTQqrgImpyWA/aQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: citrix.com; dkim=none (message not signed)
 header.d=none;citrix.com; dmarc=none action=none header.from=suse.com;
Subject: Re: [PATCH v5 08/11] xen/arm: Enable the existing x86 virtual PCI
 support for ARM.
To: Stefano Stabellini <sstabellini@kernel.org>
CC: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 "Andre.Przywara@arm.com" <Andre.Przywara@arm.com>,
 Julien Grall <julien@xen.org>, Volodymyr Babchuk
 <Volodymyr_Babchuk@epam.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
 Rahul Singh <rahul.singh@arm.com>, George Dunlap <george.dunlap@citrix.com>,
 Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>,
 Paul Durrant <paul@xen.org>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>
References: <cover.1633540842.git.rahul.singh@arm.com>
 <9bdca2cda5d2e83f94dc2423e55714273539760a.1633540842.git.rahul.singh@arm.com>
 <YWaco/UvA4xFE1xW@MacBook-Air-de-Roger.local>
 <6d75f604-6938-b185-61e1-a6684d9fca14@suse.com>
 <2b943774-072e-20a1-b97c-d88b24adf340@epam.com>
 <ed4876ca-7384-42a8-6fba-e73c1840402a@suse.com>
 <alpine.DEB.2.21.2110131223210.9408@sstabellini-ThinkPad-T480s>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <fa345819-068d-0049-f0e8-8b96379b4247@suse.com>
Date: Thu, 14 Oct 2021 08:33:38 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <alpine.DEB.2.21.2110131223210.9408@sstabellini-ThinkPad-T480s>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS9PR06CA0395.eurprd06.prod.outlook.com
 (2603:10a6:20b:461::30) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 9534a67f-b820-42a9-7fe8-08d98edc8fb4
X-MS-TrafficTypeDiagnostic: VI1PR0402MB2704:
X-Microsoft-Antispam-PRVS:
	<VI1PR0402MB270452FB50F543219B729F70B3B89@VI1PR0402MB2704.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	8GL/kK9JFreNnKbJrts9HW1K9/fSv+xsh8vEz8XqyXwiUXPzSRxMphA9pZ1nfqY4um4RzTLXMQSUdQMzy1MTpNYL0dnyz+2+8qjosr2GFDBmf+G3fN26Kv0GSZWNjxkUXA//HA8GaAXex52BFSimGAaFNoQV8ep16qMCNturYNaFx7tU4ufM67CTgvm3WeVD6ZVB9Yj3nUcplfS0ECChYsuydbmKYqVPGZXAw5cg4U70SI/Br+gWlwGf3WD4JA4IQGGC1JvN7s7hdYHPNli31EE2mY28WO6Qi/G8uETjb7PbJYYh4Vz7J0cpopk9W9sxyqCVejS373vIAaGhup4byOuB9cK3uE2dvGc9yrMDVHzbAhipwles/A1sBlZ9fWBY33mQDL43qNwECD+gIgST/1F7flLkuD2iDiJihQ6IxKInTKQ6e6Acg1/llomRZXM9KRsZZ33RjxgPpPLRw5tKg670JmlyZnofAkXO3IKxLPQmr2k9/poxU+bnqa70jM9QvXsLPUbXNf93FwYoBHj/v6w/KJIPgUfmkBH6dCwtSDNlHvGBJb/fBI3AQ+frB8flr8kMbAPl4TC49tQ9TSBm05bBRC+x8M4fPx+f7dOMDZ6yiBKzUxbxnmPP9k9Xg8v0BScuZkQVunw9t0WzY3vVW4MEMvvUUaI/UhIPJAv6xva5D5mC13AFl6SMLdgyIjSA4EoZaFVDImEqtEgpDq5yvg3EgQ/CsRU25ghGvlRGUiokY2RN1o2ffdsG7yk606fh64PZ2yFa+XuXi8KVKGiYkF9s2+na7otSEogVAkdtHja8wpeHBNR2ls0833sST8m+vDqll3919AJJQqmXDDInZg==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(6916009)(956004)(31686004)(54906003)(16576012)(2616005)(508600001)(4326008)(966005)(8936002)(38100700002)(8676002)(316002)(66946007)(83380400001)(66556008)(66476007)(7416002)(31696002)(186003)(26005)(36756003)(2906002)(53546011)(86362001)(5660300002)(6486002)(2004002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?znL4basyEOc0kfTiU9REtX3itGpAkVFfxr1R51RarFWDWnz2lVw7FSW5QauH?=
 =?us-ascii?Q?7uSwllCBrwFr6eQRwFK1vODOpb4P487mB6o02/WH3Tf9ZRVWpqmofCQp8b67?=
 =?us-ascii?Q?ThOnjx4VXawxp9gh8LDO8iOxlFcB8InfP0Jz1/fl/Liy3DpJX5iYGVKwba3S?=
 =?us-ascii?Q?pTYq2J6WxES6U2cXPQEqFrpfvd2kc3pyclE8zaelniYInDgpi3HYwykHqjht?=
 =?us-ascii?Q?25M/MyAJPsJXTH1TkNm7uNOHbaqYDJ//z2jY8kfnFV2U9YTaji9epJjY3UPs?=
 =?us-ascii?Q?r86Gv7IPCbvh7qHub1uSXYnslH+Sh1iVlNf7LN5euAc0TbhQZ8PgW8KgeNMl?=
 =?us-ascii?Q?PJIhupwrkEv4mHIVFknbWRQ+lwgzK8qamTuNVi+DTHuMV7CM08HRcpMDCfWS?=
 =?us-ascii?Q?7LG2qQH5WKw7bmcEfOUFq65FtqiUPx9sBZphI9mO0bAnx0eH/19aEI7pFtkc?=
 =?us-ascii?Q?1KJHyk9R4Xk+hyJYONBBwjbOdlDVoLvPQBQA73N++fcg5AvUg3ZWQuzz6P9J?=
 =?us-ascii?Q?ZhJG0HXOGaNl7VGFKc85yAPN0ZfhZDfri/eTV6KzN3g7TAvMcBda2YmiESHd?=
 =?us-ascii?Q?Bg7fHyXNP0Cuifh+iwdmgyIQMmmYP60kMoZ+DcsHy0CzMJgdgYjdVyOsoEWX?=
 =?us-ascii?Q?Z4n54vAnY5dVSp798QQCk7dcQINN+GnMKCy+nwYlOkV6J642ZTaFlqpVFR5e?=
 =?us-ascii?Q?2jNPax29EzIkqF8hbIChUumgfrXnQgLamOLAsyxBmdsm67IGwx+hjk8eYOZG?=
 =?us-ascii?Q?nQXF7tGnMroWyjfiu5PHfOGUD1MhgrXcR3XCyziACmP8t+wmwaYejWfBPvvU?=
 =?us-ascii?Q?gPG1gm2zqzFniKGwbEK38Yv8zGaONzyKIz1z9jIefEs+El5Ot29/a8OWGC9Y?=
 =?us-ascii?Q?LOJZswyRVNheFCjx0apSzSRZur8y2yPh4jXpnzPC7pn7cwqFkDlU4FYN+bZg?=
 =?us-ascii?Q?Df8lkPa0EqljTYNTtlxvJgM01BfcudL4Du2MBMwZcxTDxDBDkti0AVwBXj2G?=
 =?us-ascii?Q?HaDiS45PnSBs8/cHKQ08t1ZTTFCqLuCEBEgGVQR1OAHkvTnz0FprDPHElCpR?=
 =?us-ascii?Q?Bqkx82L8/hXBHfdAD3SSNGmWQo02Gb1VXrSzxr5Zp1ONwT85IzZMf3nu7ppy?=
 =?us-ascii?Q?xLSZ0AnY4WMHIUfIUFaczv7z52Qn8mpJSXHCOS3yLWo+av3n/ixQ+ew2idPv?=
 =?us-ascii?Q?BbI9yUCM1fdeJ7WUibNVRrqZo7BKG+6e9zMxyedvg/0lU8LpwpP1rq5BauLE?=
 =?us-ascii?Q?g3i28OrQ3ziOvPZimmDpuF5D9ss5iWcf9prGeZ2kUkBuViTWqxw7zDBc5U6J?=
 =?us-ascii?Q?3Cq4y/B0ImKYikFXUYP4dkts?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9534a67f-b820-42a9-7fe8-08d98edc8fb4
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2021 06:33:40.7794
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: npCqxm72KoJ6FTjmj+vbVnNkI45xRL/cNak7GiDjkZANa/NdxYGmAPaiU/J9PG+GXrg6oVJrCpxOZy5RD82RuQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB2704

On 13.10.2021 21:27, Stefano Stabellini wrote:
> On Wed, 13 Oct 2021, Jan Beulich wrote:
>> On 13.10.2021 16:51, Oleksandr Andrushchenko wrote:
>>> On 13.10.21 16:00, Jan Beulich wrote:
>>>> On 13.10.2021 10:45, Roger Pau Monn=C3=A9 wrote:
>>>>> On Wed, Oct 06, 2021 at 06:40:34PM +0100, Rahul Singh wrote:
>>>>>> --- /dev/null
>>>>>> +++ b/xen/arch/arm/vpci.c
>>>>>> @@ -0,0 +1,102 @@
>>>>>> +/*
>>>>>> + * xen/arch/arm/vpci.c
>>>>>> + *
>>>>>> + * This program is free software; you can redistribute it and/or mo=
dify
>>>>>> + * it under the terms of the GNU General Public License as publishe=
d by
>>>>>> + * the Free Software Foundation; either version 2 of the License, o=
r
>>>>>> + * (at your option) any later version.
>>>>>> + *
>>>>>> + * This program is distributed in the hope that it will be useful,
>>>>>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
>>>>>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>>>>>> + * GNU General Public License for more details.
>>>>>> + */
>>>>>> +#include <xen/sched.h>
>>>>>> +
>>>>>> +#include <asm/mmio.h>
>>>>>> +
>>>>>> +#define REGISTER_OFFSET(addr)  ( (addr) & 0x00000fff)
>>>>>> +
>>>>>> +/* Do some sanity checks. */
>>>>>> +static bool vpci_mmio_access_allowed(unsigned int reg, unsigned int=
 len)
>>>>>> +{
>>>>>> +    /* Check access size. */
>>>>>> +    if ( len > 8 )
>>>>>> +        return false;
>>>>>> +
>>>>>> +    /* Check that access is size aligned. */
>>>>>> +    if ( (reg & (len - 1)) )
>>>>>> +        return false;
>>>>>> +
>>>>>> +    return true;
>>>>>> +}
>>>>>> +
>>>>>> +static int vpci_mmio_read(struct vcpu *v, mmio_info_t *info,
>>>>>> +                          register_t *r, void *p)
>>>>>> +{
>>>>>> +    unsigned int reg;
>>>>>> +    pci_sbdf_t sbdf;
>>>>>> +    unsigned long data =3D ~0UL;
>>>>>> +    unsigned int size =3D 1U << info->dabt.size;
>>>>>> +
>>>>>> +    sbdf.sbdf =3D MMCFG_BDF(info->gpa);
>>>>>> +    reg =3D REGISTER_OFFSET(info->gpa);
>>>>>> +
>>>>>> +    if ( !vpci_mmio_access_allowed(reg, size) )
>>>>>> +        return 0;
>>>>>> +
>>>>>> +    data =3D vpci_read(sbdf, reg, min(4u, size));
>>>>>> +    if ( size =3D=3D 8 )
>>>>>> +        data |=3D (uint64_t)vpci_read(sbdf, reg + 4, 4) << 32;
>>>>>> +
>>>>>> +    *r =3D data;
>>>>>> +
>>>>>> +    return 1;
>>>>>> +}
>>>>>> +
>>>>>> +static int vpci_mmio_write(struct vcpu *v, mmio_info_t *info,
>>>>>> +                           register_t r, void *p)
>>>>>> +{
>>>>>> +    unsigned int reg;
>>>>>> +    pci_sbdf_t sbdf;
>>>>>> +    unsigned long data =3D r;
>>>>>> +    unsigned int size =3D 1U << info->dabt.size;
>>>>>> +
>>>>>> +    sbdf.sbdf =3D MMCFG_BDF(info->gpa);
>>>>>> +    reg =3D REGISTER_OFFSET(info->gpa);
>>>>>> +
>>>>>> +    if ( !vpci_mmio_access_allowed(reg, size) )
>>>>>> +        return 0;
>>>>>> +
>>>>>> +    vpci_write(sbdf, reg, min(4u, size), data);
>>>>>> +    if ( size =3D=3D 8 )
>>>>>> +        vpci_write(sbdf, reg + 4, 4, data >> 32);
>>>>> I think those two helpers (and vpci_mmio_access_allowed) are very
>>>>> similar to the existing x86 ones (see vpci_mmcfg_{read,write}), up to
>>>>> the point where I would consider moving the shared code to vpci.c as
>>>>> vpci_ecam_{read,write} and call them from the arch specific trap
>>>>> handlers.
>>>> Except that please can we stick to mcfg or mmcfg instead of ecam
>>>> in names, as that's how the thing has been named in Xen from its
>>>> introduction? I've just grep-ed the code base (case insensitively)
>>>> and found no mention of ECAM. There are only a few "became".
>>> I do understand that this is historically that we do not have ECAM in X=
en,
>>> but PCI is not about Xen. Thus, I think it is also acceptable to use
>>> a commonly known ECAM for the code that works with ECAM.
>>
>> ACPI, afaik, also doesn't call this ECAM. That's where MCFG / MMCFG
>> actually come from, I believe.
>=20
> My understanding is that "MCFG" is the name of the ACPI table that
> describes the PCI config space [1]. The underlying PCI standard for the
> memory mapped layout of the PCI config space is called ECAM. Here, it
> makes sense to call it ECAM as it is firmware independent.
>=20
> [1] https://wiki.osdev.org/PCI_Express

Okay, I can accept this, but then I'd expect all existing uses of
MCFG / MMCFG in the code which aren't directly ACPI-related to get
replaced. Otherwise it's needlessly harder to identify that one
piece of code relates to certain other pieces.

Jan



From xen-devel-bounces@lists.xenproject.org Thu Oct 14 06:52:28 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Oct 2021 06:52:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.209015.365339 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maubG-0002a8-31; Thu, 14 Oct 2021 06:52:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 209015.365339; Thu, 14 Oct 2021 06:52:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maubF-0002a1-Vu; Thu, 14 Oct 2021 06:52:21 +0000
Received: by outflank-mailman (input) for mailman id 209015;
 Thu, 14 Oct 2021 06:52:20 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Xl23=PC=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1maubE-0002Zv-Nm
 for xen-devel@lists.xenproject.org; Thu, 14 Oct 2021 06:52:20 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 45ea0162-2cbb-11ec-81ad-12813bfff9fa;
 Thu, 14 Oct 2021 06:52:19 +0000 (UTC)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2113.outbound.protection.outlook.com [104.47.18.113])
 (Using TLS) by relay.mimecast.com with ESMTP id
 de-mta-34-vzWg9o4FMuOCGyNx_D-0pg-1; Thu, 14 Oct 2021 08:52:17 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB4848.eurprd04.prod.outlook.com (2603:10a6:803:55::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18; Thu, 14 Oct
 2021 06:52:16 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.016; Thu, 14 Oct 2021
 06:52:16 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6P194CA0037.EURP194.PROD.OUTLOOK.COM (2603:10a6:209:84::14) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.16 via Frontend Transport; Thu, 14 Oct 2021 06:52:15 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 45ea0162-2cbb-11ec-81ad-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634194338;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=SzzeDl+H1gQVuU0hMZFZK8q4ohVAMzKWic/c6ljoL48=;
	b=Zbw0e9y+9vgtCUIlz+msBJyzf6hfbBm0Ex+xBBFYed848ID22vu/HrOQ6nsbfjKz4wsVi4
	TbCQljdpifsC7ucVzvopWF8Tpem/nDI4rBgOGz27sg4yOYFtzJS2ckgtPu+x1k2TxXuNc/
	Zuk/uxpwWr4ZQHcJGGb/1Jgx/toLJ7A=
X-MC-Unique: vzWg9o4FMuOCGyNx_D-0pg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=X+RcqvZc3n5nrtwCJL4IBHo+rDChEQ5J7XE1FzNQCvhwjNyiS9fo+xdEVshLdtV5R7dm3Hx74LWQPWZiQJJUIOe8g/fVSfhRl6jQoUWM1tJbjW66ZtKndGRmUO/KdaBvcvn5rhl6ClJ9c1Kh4If/PgrIoTnBkJTSGUxEAFTw90sVhf02o85SRdlnTCYDRjXjNxBhptinqWV0188L3z5lW7i1/VTvorKF1twLtt7TMZnTd75lVz8zehXSOmFVEgEEOW3YznrHgips905yZcTM0TGInSCdTeiVLp0Q7Dli7Trc74FwhoxMPpQMvE/0FBYxX9Tdj0E7o1NU0AP/IQMHlQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=SzzeDl+H1gQVuU0hMZFZK8q4ohVAMzKWic/c6ljoL48=;
 b=NMrzAJYTTif+fKry/YxVg563GVmJhEb7PRAdZtRm3CO5rQgUr4oJMZZe07raaZYR0dmQIQh2qrmzCDD1R5+S4jJPIoG81vzodB8MWegmNBqSbXcBMAq96yktG9opwzAFttLJu/cE/xqkVwrZ6j1Dq378jHYlXYcuXYX3dxuJ8X/LBzITcQ7eV1/hFzFtEs6XvgEHqsOir7Oo2aW/+cUeduA8qhgJDWr0YKzQle1j4uOYGUaCsEX/1S0wtuFSV18gFHQZqPehXqlZowH1uUynFJQHxaO1JJdAwMZY81nqqDqHZVuIpeDuxoOCu8dMduf0wXEeJYxZRCNuIXS4AY7UCg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [XEN PATCH v7 51/51] build: add %.E targets
From: Jan Beulich <jbeulich@suse.com>
To: Anthony PERARD <anthony.perard@citrix.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>
Cc: George Dunlap <george.dunlap@citrix.com>, Ian Jackson
 <iwj@xenproject.org>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
References: <20210824105038.1257926-1-anthony.perard@citrix.com>
 <20210824105038.1257926-52-anthony.perard@citrix.com>
 <377d9a27-e09e-38f2-9009-64c0b9e6ace2@suse.com>
Message-ID: <21a448d8-448c-262e-9d1b-dbf7de159209@suse.com>
Date: Thu, 14 Oct 2021 08:52:14 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <377d9a27-e09e-38f2-9009-64c0b9e6ace2@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P194CA0037.EURP194.PROD.OUTLOOK.COM
 (2603:10a6:209:84::14) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: a63cebe3-2e63-44b5-14dd-08d98edf28c7
X-MS-TrafficTypeDiagnostic: VI1PR04MB4848:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB4848D9ADA5BD24976A3A7AF1B3B89@VI1PR04MB4848.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6790;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	7Q+BbbagqcEtPQQkobvmSVJ/Br8Ogo1vavL6A84pZscclVR6+B/i4eKV4T++lB+xBjDJy8LsOxyUjCl1R9M29tn/HR6rAS40dlSH5EpE7rGFgOPcg+g9EbdRaZZbX7J8yrGNCGJ7uxirLJqb5aBUCCDCSgks7hGlYJ0AV9f5BrRY2wVULdUErx7ssSaM47VwNWzrbfBLBlY++rZ7wvaUlzr6kvvaWlPbZi7kh8CrY89MNH2QPPY7On857uaPPMGfRCeP7YKKpvKLqa0fs8QikTVyLyG33ivoQ9vQzV4A4bTHO4CIXxiIs54xBP1zphrIg3jPkeUVbNMpDyxK2gSEjFdT8rJ7hiKPDGds6/NT8JETYBb19sM30wiSdpyLc+eUo75M4gezqGzE/rOhFpj+7+ShgrLCatCNvlIV4SQiseyYLegu2jHFnkP8ffwlgNTZQ7T4Pbfk6yrl2HGcO8kD3C7/N0t0DizyQw+TtcPuXAescdWgL/xm4eVhLGesQ0Nwo/OmJ2owur55evG6OX+COIAyVokbH/mztcaaCb7X8xr1i7UwpGf3ryKhC6fKVb4M4z1nk+HS27cbpviletJzvemWJ27lwYZWyyz35nBIJPR/Rl8bclp5INNlLOj0YnHftA/FOtPZe1fIEYa7DEcPdtECHeauZ5loLOt8y403JjzvwWjvTY3cmDZhD/MhBOU/xcqiMCaz+LxcjodR+qU397oIa8nnGBrOed74Z7EV+fM=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(316002)(86362001)(2906002)(16576012)(186003)(31696002)(36756003)(508600001)(54906003)(110136005)(5660300002)(38100700002)(83380400001)(66946007)(956004)(8676002)(4744005)(6486002)(66476007)(4326008)(66556008)(26005)(8936002)(31686004)(2616005)(53546011)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?TzMwR2JiemFhRDY3dGFNQ2p0ZVR3ZUo4bGp0RXpVeExERWFJOVJldEY1b1kx?=
 =?utf-8?B?OHAwTEY1RVVzTElCRDZOUlRlOGUvbXpKbW1kLy8zRUEzSnU0TjhKdlZHNnBN?=
 =?utf-8?B?dUJCTFROS25RTkNGYnFZSzcweDR2YlRnUEg0dGNrU1NlemI2NTNtQU5kOWoz?=
 =?utf-8?B?MDlGNnJqTUp2RHpkWFRMdEVIMEZ6NXFHY3BWMGNEMXl2OW1EMUJwcXJlZ3hn?=
 =?utf-8?B?bStoZVZHK2FaZDlEU1JNNEplMHlDS1ZiK3Q4UEtDV3JjTXNFZTMyTWQzMWRt?=
 =?utf-8?B?QU13U1B5RzJacnQvVUVxY2JWRVQ5STV4cytWak9QNFhITmhMQkFCNER5a2d6?=
 =?utf-8?B?OXQ3R0pRaFM4UFVDZWttM2drRHQvYXQ4WUV5Zm9oSG54TGRPcmlQM3VTWTlX?=
 =?utf-8?B?Q0dBczZyV0lWdFc3eldtcnE0ekhMZWlnVi90dlNDVlM3dnlQc2JpRXNtK1RD?=
 =?utf-8?B?U1V2YnNxM3Z5UnNwWEdGUGZReDlqc1hJK2Yra1hqQmRHcllZelVUY3FVTUpw?=
 =?utf-8?B?aWxDS2Z1aVJsY3RrZDVKRHJCTXVwcDdQalVBWHhJMHpmWXFJd1IxQUtJR1Rv?=
 =?utf-8?B?ZDEwZEcyWG5xTUorbmNXQmpYUmd2eGZqeDh2RWhQcFYvTE1hdkJ0ZUI1UERq?=
 =?utf-8?B?ODJ3VytDVTlyMW1UK1JyUWJsWE1zckJGcGRTL1I3ZlhEeGdHWmFONUlyU3Bx?=
 =?utf-8?B?bUowbGRhMmtFK2JIQitZejJ6TEVwUGl3OUhuOFZPZExZdWRUdGV3N3UyUDhF?=
 =?utf-8?B?aS9YeEdKVjR0OEpsTDc1bkhJQnVuc0k3R2JQcVpEd3kraGNJZXJ5MzcwempM?=
 =?utf-8?B?ZVc2cWQ4MGJHcFlCSGVWbWcvTzhBWXBIWThnMnVuVVMwd1BEb2g5cGhQcHo3?=
 =?utf-8?B?VzJ3NlVNUHNwdUdLcUNYanlyNGE0eitNREcvSXZ1TWdEYUc2ZmI4Y2NuVmJt?=
 =?utf-8?B?SU5tMGJRUktnanNpVy9RTkl0bkhOTXpKSW9WUE9nNnlWbTJ0VTQydXpSTlBu?=
 =?utf-8?B?ME9OUDVOQ0JBZWhZSnVPUUhMYTJTMmd1eElhK1pUSHF2M1pjV09kV0k4Zmsz?=
 =?utf-8?B?ZFdUMTc1ZjE4em4rdWRIcjRxY1RjUG5iNmxpSXZNRmw3K3BLcWFWWjFQQngy?=
 =?utf-8?B?cURzelIvYjBOY3BZM2c3a2ZQcklFbXhBYUJRM0pNS3JEYmxUdDVIL2IrMDVp?=
 =?utf-8?B?TkFGTHV3cHo3U0RoRFNkSXNYK0NWYXF6eU9lMFRCa255NVhaUnpCNWUxZG94?=
 =?utf-8?B?RDJsTU81VDFTL3JsQkZLNjBKbnA4aWpjWE16aHhPMVM0dU9Bck1QQ28xZ0tY?=
 =?utf-8?B?SzBNY3I0aWg1ZnZDVDllNEVnMFk3MjByY0RxVkEzTHg3a3pveVVZeFJRRUky?=
 =?utf-8?B?Q25ubDlFRG80Z0JLN3V5V3gxc1FwUVo1VnFpNnFMbmZDSEpYK1hmUWRoZUZR?=
 =?utf-8?B?V0RZOVo2djlaSU4rZWJKeVFPVDlkT05LNVZ2QlhWdFNWNkFydDBsYUNISzkx?=
 =?utf-8?B?Vk4zbllEWklZNVg0WDVObHU2S1pwbFI5VGlORkY0Snk0YUtMV2pMcXorcVNo?=
 =?utf-8?B?WmdWMzVPTWJlS25mdG43VnFUQlZ6NjZ1MXhYa3ZTVkdSWWdmY1V3Mmw0R1ds?=
 =?utf-8?B?WFFKcXZtb2MxcnplaE9rSGRtRFBBVFNZVU9ndS8vUzFlM2tqbUpFRkNsdGNn?=
 =?utf-8?B?Z1BLQTZZTHBSdlZVdC9qQXlFWEJLRFFzWkR0ZXplSENHRTRycXpkWmRqQWdj?=
 =?utf-8?Q?rcGubvo1rd2QpsHKhsBApjzF2Oovm6sjzwP/MO4?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a63cebe3-2e63-44b5-14dd-08d98edf28c7
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2021 06:52:16.3482
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ftrGkzhuUcX22CXck+cVd22NXYGoMd9lDPaI+BYUiBeczsqaWvs615wqQDcXOaxBArfRmOA8alyk3NFMvM6nAQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4848

On 13.10.2021 17:48, Jan Beulich wrote:
> On 24.08.2021 12:50, Anthony PERARD wrote:
>> I guess it's easier to remember that %.E does "$(CC) -E" or "$(CPP)".
> 
> I've never seen any *.E. I'm puzzled (and hence have reservations, but
> then again don't care enough to object).

Actually I've checked gcc, and it wouldn't know what to do with a *.E
file. Hence I'd like to ask that you add a reasonable reference to a
pre-existing use of this naming. Without such reference I'd feel the
addition would have more risk of confusion than possible value.

Jan



From xen-devel-bounces@lists.xenproject.org Thu Oct 14 06:56:09 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Oct 2021 06:56:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.209023.365350 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maueu-0003Es-LB; Thu, 14 Oct 2021 06:56:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 209023.365350; Thu, 14 Oct 2021 06:56:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maueu-0003El-HO; Thu, 14 Oct 2021 06:56:08 +0000
Received: by outflank-mailman (input) for mailman id 209023;
 Thu, 14 Oct 2021 06:56:06 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=KYrt=PC=arm.com=Hongda.Deng@srs-us1.protection.inumbo.net>)
 id 1maues-0003Ee-Mi
 for xen-devel@lists.xenproject.org; Thu, 14 Oct 2021 06:56:06 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com (unknown
 [2a01:111:f400:7d00::606])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 7f9dcdbc-4b60-4f98-939b-3e01f701a8df;
 Thu, 14 Oct 2021 06:56:00 +0000 (UTC)
Received: from DB6PR0202CA0043.eurprd02.prod.outlook.com (2603:10a6:4:a5::29)
 by AS8PR08MB7337.eurprd08.prod.outlook.com (2603:10a6:20b:444::5)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15; Thu, 14 Oct
 2021 06:55:58 +0000
Received: from DB5EUR03FT063.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:4:a5:cafe::28) by DB6PR0202CA0043.outlook.office365.com
 (2603:10a6:4:a5::29) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.14 via Frontend
 Transport; Thu, 14 Oct 2021 06:55:58 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT063.mail.protection.outlook.com (10.152.20.209) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.15 via Frontend Transport; Thu, 14 Oct 2021 06:55:57 +0000
Received: ("Tessian outbound 2e7020cc8961:v103");
 Thu, 14 Oct 2021 06:55:57 +0000
Received: from a4bb49d3b0ac.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 7C8ADDED-9B97-43C1-A3C2-2E53B4818794.1; 
 Thu, 14 Oct 2021 06:55:47 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id a4bb49d3b0ac.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Thu, 14 Oct 2021 06:55:47 +0000
Received: from VE1PR08MB5677.eurprd08.prod.outlook.com (2603:10a6:800:1ab::17)
 by VI1PR0801MB2030.eurprd08.prod.outlook.com (2603:10a6:800:81::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.20; Thu, 14 Oct
 2021 06:55:43 +0000
Received: from VE1PR08MB5677.eurprd08.prod.outlook.com
 ([fe80::d810:52a3:dce3:4d06]) by VE1PR08MB5677.eurprd08.prod.outlook.com
 ([fe80::d810:52a3:dce3:4d06%7]) with mapi id 15.20.4608.016; Thu, 14 Oct 2021
 06:55:43 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7f9dcdbc-4b60-4f98-939b-3e01f701a8df
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=uGt+aFRr8axg3U9HwZPmhivk/4rt849liFuZx3QDj/U=;
 b=WUC7qse6haxG6D9JhqCm97j5882/gKufh2UxB/MYMFsqWN7GDEb1sh2l/rHru/ta6X0yZaGIm0MF4S/CrixxFQpPI+RJ4YNdD2WnB/LbJ2NMPB2IvYNRvezHxoAPbUX0/z0I0ECl/xZQ7s2F/iPM7xLK4rU+n2LklOdi6f93Ijg=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=k4J0DXfjcG9dE7aXgElb9vCbmdc1pPXe0bhDcH/rT/V3qfwEA9SYXIDLhOW29tU1nsg8PX7OpJCBDHrKV/JBvULV+f45CWBtjpL6LxxJD2JBmxe1+rV0vT7ixljUqHdluPIutqHS1FglZOHhgaDW4TpAGWVD7Aav2wA/8CNI5gSKlWRW/m1qOsT3U1J20Zd0GSw+ydACcdTlCnzKUfziLWDA5CPw37f54F8StxGLCEgc4wE5pvdUK4j+l7N0WdkYU8dwTOqrCybW8cw4l1u8SPjaXNqkA5wnp1ZwgrgeUZJ5M/VOzWJ5R37R0cuE84nvvPSE05j/AK32uLvAnYRTsA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=uGt+aFRr8axg3U9HwZPmhivk/4rt849liFuZx3QDj/U=;
 b=XuKNtr6MLk9JZfNy2TXlGlS1reZj5zqHNalB9CmMLqf5gndJHAXeKILO+PYtIeDO0PhS+EIA/KLoZjTGHEXbQ1qyyiu39fFQrbsn4m8bUBiP23F+rV7mqYb7nnMYxMVUBDo9g/LSAgolLP8mIldDrhpLf/3chs6St2tvPo750diAMbbOUX+l9utd3cN8Uqn6DVMmyVq85WU1jKQVZK1Pe5YTS6Cua5wBz3DWrCvmTScyEDOCuPCCD3qudSS52d/rAD4dyB6HqgOCl23dv58zWt/AKFlw3SYkI4pieKSk0PjspL5D3Yrj1cKAXOBmPlMg4OoXV/R7W+rc7dpl5EsZJw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=uGt+aFRr8axg3U9HwZPmhivk/4rt849liFuZx3QDj/U=;
 b=WUC7qse6haxG6D9JhqCm97j5882/gKufh2UxB/MYMFsqWN7GDEb1sh2l/rHru/ta6X0yZaGIm0MF4S/CrixxFQpPI+RJ4YNdD2WnB/LbJ2NMPB2IvYNRvezHxoAPbUX0/z0I0ECl/xZQ7s2F/iPM7xLK4rU+n2LklOdi6f93Ijg=
From: Hongda Deng <Hongda.Deng@arm.com>
To: Julien Grall <julien@xen.org>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, "sstabellini@kernel.org"
	<sstabellini@kernel.org>
CC: Bertrand Marquis <Bertrand.Marquis@arm.com>, Wei Chen <Wei.Chen@arm.com>
Subject: RE: [PATCH v2] xen/arm: vgic to ignore GICD ICPENRn registers access
Thread-Topic: [PATCH v2] xen/arm: vgic to ignore GICD ICPENRn registers access
Thread-Index: AQHXvzHlijaP4Y1NK0CFHMPF7AWOSqvP6giAgAIRRIA=
Date: Thu, 14 Oct 2021 06:55:43 +0000
Message-ID:
 <VE1PR08MB5677670DF19601441701380FE6B89@VE1PR08MB5677.eurprd08.prod.outlook.com>
References: <20211012062449.30966-1-Hongda.Deng@arm.com>
 <2006f09d-25c3-af7a-cbea-dbc811fc8748@xen.org>
In-Reply-To: <2006f09d-25c3-af7a-cbea-dbc811fc8748@xen.org>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: 57EC84F09B2DA54AA8AE13A48D410F44.0
x-checkrecipientchecked: true
Authentication-Results-Original: xen.org; dkim=none (message not signed)
 header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: 81a110ce-f02f-4e49-f18f-08d98edfacd9
x-ms-traffictypediagnostic: VI1PR0801MB2030:|AS8PR08MB7337:
x-ms-exchange-transport-forked: True
X-Microsoft-Antispam-PRVS:
	<AS8PR08MB7337EA6D543FAE2BD26C4BC5E6B89@AS8PR08MB7337.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:3513;OLM:3513;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 V2OJuDsQVnw2MZzG2taZaT7zW5GkY3pL7/u5y2OF+QmEKeMdzVYK7x1TX78mIGujJeCqot/EcBG9Sq62HfNYK47ShjuRaN3rvItQg9kW5X7YyQE1AgPWGp3kcK+ZhDnAex4m42DRsDxtfWHKGXieUWYmMO4MguJrXX9XIzQgIY9owujIyL/7rGfixThoankU7p3xDqRJWZ5RfmSgjzwrk6yS15e2DOCZEqEdzrtb4w53Aa4vpbPQ7biH05whAqE7Ki3CNzSMlVvFpXDBVPastvspSrQf/RGM6BFESvDkox5LGdTrIFfIzqWtjuYWPRrAa+CTOrd7w1/ZV+rAWKvQnO+sNxk61shO0526bHzdq62+EGoSE3Ej0up0xYupcUtziwFrLUkJW86s+mTkgQ/+MFgecP8jTcG8oM6f/cay6LCCxoEOWkD53fMMx0/CfK5heljsIiTewIo07mgugtANXRPuUC7FiZON4gzsNQqTgdvl+akt484HSCsewK0gsp1LGcAm79BZRq1PtjNaGlgIDS5lgm6FjNgiFN78dl51p8tuTVt8fueJMlp0PqpEbVWXZqhGeCIiBSg6MkeFD+ruqgcd94YGIOVElIJguDVgV3y26GTV9Ndk9XrD7Xj72idUuYEJIhnaJEsQtSNCG9XfkGIUeLASAlS7PUla6BOk5g/iDFHzb7h26Xck/MfZ/gKTY9cuOJW5a1Jhm9iM+xJJuUrzDOMWddNHYBTSuvq89ptHaJO5Bdy8LxxVfO3YIwcIO4QWwS/tVCjAQORFOKQ5N3eb6mHIba2yaAjAa7pCWV+xsynL2S6jxppiI+ygipUxI2ePOQd7Hz3B1dC6PyRYUg==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR08MB5677.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(33656002)(71200400001)(966005)(122000001)(508600001)(66476007)(54906003)(38100700002)(8936002)(5660300002)(83380400001)(2906002)(6506007)(4326008)(53546011)(110136005)(9686003)(316002)(38070700005)(52536014)(26005)(8676002)(55016002)(76116006)(7696005)(86362001)(64756008)(66446008)(66946007)(186003)(66556008);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0801MB2030
Original-Authentication-Results: xen.org; dkim=none (message not signed)
 header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT063.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	f6ffac7e-39d3-4b7b-d095-08d98edfa43a
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	pTWQeT0Y5HzlaoBrmxEgq8kR/6tRlycaik8tJ3RUpF0XfEzCgjBmj+ydnrLhiO1pFJktN+uQxKFYtcIwqPdxJnO5eEchGWND5mlylPn3yG2SPWD8Xw2AgV492O7W44eeQodyabCFVuNxZ2U5aH6m63GJ0P4ud6LhOKfFPh0J6NfKQt1tUKFmMRCQxLKU/Lxm6Nl1uQjbEp+o6dv/Nsfho8SuzuMws2GpiDjrZvbsSeg2olXmJqQUjuWbSG4PU3h9kDdMmcTiyPf7bv+k/VlMSYROTVSsmoIcr5DhJYHXTWB3gjOH8t0AJ6kVikRPXIvycbDfzbemgGaiY6N2d7I3WFM1iTMHMCCM4VWjhR5LSkM/7qnD+I0u+l7ODovY3IMAKkg2fZuI3m+mVlTyeo3FE35DsSm94Cs94o6j04jOAplEkhhM6klEzAypWwGR2FxWPCihydNCp8alJy6/Wr49TjBD+UofjkZcQTLgot/1qm85JLoRom02JnK4gIyExDq/pvGW6/Qj+NZDg4+Y1Eju2UZGp9WHj7B/4E5cQTQPBjTUySZwTJIklTJLIg6Mhx/rSmmYVCgVVpK7wth8VCVSX7RbGHB5Aq/BVKMZtxiLDx9y9gBtKAW5EcGMLcIZdA5IRUz0ubmV0500z85IR+ed6hzrtu/FTVkrSdDkrC/Sbtmbit5VfUjSI6sO/YE4g6iAm2wu27Volr2Y/75meI8Rez4UkNST63y20FCRiafatP7qphSIj1Ltk9GwtmU2JJMeE1cSu65/N8NeSlWXb7sdXbnbJy4Wjgr1RaBCZlknEHX/6lIKdnk2UhPqEtf9vWYpsSjZsR6WkfNLNSK5oSXSgg==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(33656002)(70206006)(55016002)(8676002)(82310400003)(2906002)(36860700001)(4326008)(70586007)(47076005)(8936002)(86362001)(356005)(54906003)(26005)(966005)(7696005)(186003)(5660300002)(110136005)(508600001)(53546011)(81166007)(52536014)(6506007)(9686003)(316002)(336012)(83380400001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2021 06:55:57.8361
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 81a110ce-f02f-4e49-f18f-08d98edfacd9
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT063.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB7337

SGksDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogSnVsaWVuIEdyYWxs
IDxqdWxpZW5AeGVuLm9yZz4NCj4gU2VudDogMjAyMeW5tDEw5pyIMTPml6UgNTo1OA0KPiBUbzog
SG9uZ2RhIERlbmcgPEhvbmdkYS5EZW5nQGFybS5jb20+OyB4ZW4tZGV2ZWxAbGlzdHMueGVucHJv
amVjdC5vcmc7DQo+IHNzdGFiZWxsaW5pQGtlcm5lbC5vcmcNCj4gQ2M6IEJlcnRyYW5kIE1hcnF1
aXMgPEJlcnRyYW5kLk1hcnF1aXNAYXJtLmNvbT47IFdlaSBDaGVuDQo+IDxXZWkuQ2hlbkBhcm0u
Y29tPg0KPiBTdWJqZWN0OiBSZTogW1BBVENIIHYyXSB4ZW4vYXJtOiB2Z2ljIHRvIGlnbm9yZSBH
SUNEIElDUEVOUm4gcmVnaXN0ZXJzIGFjY2Vzcw0KPiANCj4gSGksDQo+IA0KPiBPbiAxMi8xMC8y
MDIxIDA3OjI0LCBIb25nZGEgRGVuZyB3cm90ZToNCj4gPiBDdXJyZW50bHksIFhlbiB3aWxsIHJl
dHVybiBJTyB1bmhhbmRsZWQgd2hlbiBndWVzdHMgYWNjZXNzIEdJQ0QgSUNQRU5Sbg0KPiA+IHJl
Z2lzdGVycy4gVGhpcyB3aWxsIHJhaXNlIGEgZGF0YSBhYm9ydCBpbnNpZGUgZ3Vlc3QuIEZvciBM
aW51eCBHdWVzdCwNCj4gPiB0aGVzZSB2aXJ0dWFsIHJlZ2lzdGVycyB3aWxsIG5vdCBiZSBhY2Nl
c3NlZC4gQnV0IGZvciBaZXBoeXIsIGluIGl0cw0KPiA+IEdJQyBpbml0aWFsaXphdGlvbiBjb2Rl
LCB0aGVzZSB2aXJ0dWFsIHJlZ2lzdGVycyB3aWxsIGJlIGFjY2Vzc2VkLiBBbmQNCj4gPiB6ZXBo
eXIgZ3Vlc3Qgd2lsbCBnZXQgYW4gSU8gZGF0YSBhYm9ydCBpbiBpbml0aWxpemF0aW9uIHN0YWdl
IGFuZCBlbnRlcg0KPiA+IGZhdGFsIGVycm9yLiBFbXVsYXRpbmcgSUNQRU5EUiBpcyBub3QgZWFz
eSB3aXRoIHRoZSBleGlzdGluZyB2R0lDLCBzbw0KPiA+IHdlIGN1cnJlbnRseSBpZ25vcmUgdGhl
c2UgdmlydHVhbCByZWdpc3RlcnMgYWNjZXNzIGFuZCBwcmludCBhIG1lc3NhZ2UNCj4gPiBhYm91
dCB3aGV0aGVyIHRoZXkgYXJlIGFscmVhZHkgcGVuZGluZyBpbnN0ZWFkIG9mIHJldHVybmluZyB1
bmhhbmRsZWQuDQo+ID4gTW9yZSBkZXRhaWxzIGNhbiBiZSBmb3VuZCBhdCBbMV0uDQo+IA0KPiBU
aGUgbGluayB5b3UgcHJvdmlkZSBvbmx5IHN0YXRlcyB0aGF0IEkgYW0gaGFwcHkgd2l0aCB0aGUg
d2FybmluZy4gVGhpcw0KPiBkb2Vzbid0IHNlZW0gcmVsZXZhbnQgZm9yIGEgZnV0dXJlIHJlYWRl
ci4gRGlkIHlvdSBpbnRlbmQgdG8gcG9pbnQgdG8NCj4gc29tZXRoaW5nIGRpZmZlcmVudD8NCj4g
DQoNClllcywgSSB3b3VsZCBhdHRhY2ggdGhpcyBsaW5rIFsxXSB0aGVuLCB3aGljaCBleHBsYWlu
cyBob3cgemVwaHlyIGFjY2Vzc2VzIA0KSUNQRU5EUiBhdCBpdHMgaW5pdGlhbGl6YXRpb24uICgg
VGhvdWdoIEkgc3RpbGwgZG9uJ3QgdW5kZXJzdGFuZCB3aHkgemVwaHlyIA0Kd291bGQgY2xlYXIg
dGhpcyByZWdpc3RlciBhdCBpbml0aWFsaXphdGlvbiB3aGlsZSBsaW51eCB3b3VsZG4ndCApDQoN
Cj4gPg0KPiA+IFsxXSBodHRwczovL2xpc3RzLnhlbnByb2plY3Qub3JnL2FyY2hpdmVzL2h0bWwv
eGVuLWRldmVsLzIwMjEtMDkvDQo+ID4gbXNnMDA3NDQuaHRtbA0KPiA+DQo+ID4gU2lnbmVkLW9m
Zi1ieTogSG9uZ2RhIERlbmcgPGhvbmdkYS5kZW5nQGFybS5jb20+DQo+ID4gLS0tDQo+ID4gICB4
ZW4vYXJjaC9hcm0vdmdpYy12Mi5jIHwgMjYgKysrKysrKysrKysrKysrKysrKysrKysrKy0NCj4g
PiAgIHhlbi9hcmNoL2FybS92Z2ljLXYzLmMgfCA0MCArKysrKysrKysrKysrKysrKysrKysrKysr
KysrKysrLS0tLS0tLS0tDQo+ID4gICAyIGZpbGVzIGNoYW5nZWQsIDU2IGluc2VydGlvbnMoKyks
IDEwIGRlbGV0aW9ucygtKQ0KPiA+DQo+ID4gZGlmZiAtLWdpdCBhL3hlbi9hcmNoL2FybS92Z2lj
LXYyLmMgYi94ZW4vYXJjaC9hcm0vdmdpYy12Mi5jDQo+ID4gaW5kZXggYjJkYTg4NmFkYy4uZDdm
ZmFlZWI2NSAxMDA2NDQNCj4gPiAtLS0gYS94ZW4vYXJjaC9hcm0vdmdpYy12Mi5jDQo+ID4gKysr
IGIveGVuL2FyY2gvYXJtL3ZnaWMtdjIuYw0KPiA+IEBAIC00ODAsMTEgKzQ4MCwzNSBAQCBzdGF0
aWMgaW50IHZnaWNfdjJfZGlzdHJfbW1pb193cml0ZShzdHJ1Y3QgdmNwdSAqdiwNCj4gbW1pb19p
bmZvX3QgKmluZm8sDQo+ID4gICAgICAgICAgIHJldHVybiAxOw0KPiA+DQo+ID4gICAgICAgY2Fz
ZSBWUkFOR0UzMihHSUNEX0lDUEVORFIsIEdJQ0RfSUNQRU5EUk4pOg0KPiA+ICsgICAgew0KPiA+
ICsgICAgICAgIHN0cnVjdCBwZW5kaW5nX2lycSAqaXRlcjsNCj4gPiArICAgICAgICB1bnNpZ25l
ZCBpbnQgaXJxX3N0YXJ0Ow0KPiA+ICsgICAgICAgIHVuc2lnbmVkIGludCBpcnFfZW5kOw0KPiA+
ICsgICAgICAgIHVpbnQzMl90IGlycV9wZW5kaW5nID0gMDsNCj4gPiArDQo+ID4gICAgICAgICAg
IGlmICggZGFidC5zaXplICE9IERBQlRfV09SRCApIGdvdG8gYmFkX3dpZHRoOw0KPiA+ICAgICAg
ICAgICBwcmludGsoWEVOTE9HX0dfRVJSDQo+ID4gICAgICAgICAgICAgICAgICAiJXB2OiB2R0lD
RDogdW5oYW5kbGVkIHdvcmQgd3JpdGUgJSMiUFJJcmVnaXN0ZXIiIHRvDQo+IElDUEVORFIlZFxu
IiwNCj4gPiAgICAgICAgICAgICAgICAgIHYsIHIsIGdpY2RfcmVnIC0gR0lDRF9JQ1BFTkRSKTsN
Cj4gDQo+IEFzIEkgd3JvdGUgaW4gdjEsIHdlIHNob3VsZCBhdm9pZCB0byBwcmludCBhIG1lc3Nh
Z2Ugd2hlbiB3ZSBrbm93IHRoZXJlDQo+IGlzIG5vIHBlbmRpbmcgaW50ZXJydXB0cy4NCj4gDQoN
ClRoZXNlIGFyZSBub3QgdGhlIG1vZGlmaWNhdGlvbnMgbWFkZSBpbiB0aGlzIHBhdGNoLCBhbmQg
c2FtZSBjb2RlcyBhbHNvIGV4aXN0DQpmb3IgSUNBQ1RJVkVSLiBJIGRpZG4ndCBkZWxldGUgdGhl
bSBmb3IgdGhhdCBJIHRoaW5rIHRoZXkgYXJlIHVzZWQgdG8gZ2l2ZSBzb21lDQp1c2VmdWwgYW5k
IGNvaGVyZW50IG1lc3NhZ2VzIHRvIHVzZXIgZm9yIHJlZmVyZW5jZS4gU2hvdWxkIHdlIGRlbGV0
ZSBpdCBmb3IgYm90aA0Kb3Igb25seSBmb3IgSUNQRU5EUj8NCg0KPiA+IC0gICAgICAgIHJldHVy
biAwOw0KPiA+ICsNCj4gPiArICAgICAgICBpcnFfc3RhcnQgPSAoZ2ljZF9yZWcgLSBHSUNEX0lD
UEVORFIpICogMzI7DQo+ID4gKyAgICAgICAgaXJxX2VuZCA9IGlycV9zdGFydCArIDMxOw0KPiA+
ICsgICAgICAgIC8qIGdvIHRocm91Z2ggaW5mbGlnaHRfaXJxcyBhbmQgcHJpbnQgc3BlY2lmaWVk
IHBlbmRpbmcgaXJxcyAqLw0KPiA+ICsgICAgICAgIGxpc3RfZm9yX2VhY2hfZW50cnkoaXRlciwg
JnYtPmFyY2gudmdpYy5pbmZsaWdodF9pcnFzLCBpbmZsaWdodCkNCj4gWW91IG5lZWQgdG8gaG9s
ZCB2LT5hcmNoLnZnaWMubG9jayAod2l0aCBpbnRlcnJ1cHQgZGlzYWJsZWQpIHRvIGdvDQo+IHRo
cm91Z2ggdGhlIGxpc3Qgb2YgaW5mbGlnaHQgaXJxcy4gT3RoZXJ3aXNlLCB0aGUgbGlzdCBtYXkg
YmUgbW9kaWZpZWQNCj4gd2hpbGUgeW91IGFyZSB3YWxraW5nIGl0Lg0KPiANCg0KQWNrLg0KDQo+
IEhvd2V2ZXIsIEkgYW0gYSBsaXR0bGUgYml0IGNvbmNlcm5lZCB3aXRoIHRoaXMgYXBwcm9hY2hl
ZCAoSSBub3RpY2VkDQo+IFN0ZWZhbm8gc3VnZ2VzdGVkKS4gVGhlIGxpc3QgbWF5IGluIHRoZW9y
eSBjb250YWlucyBhIGZldyBodW5kcmVkcw0KPiBpbnRlcnJ1cHRzIChhIG1hbGljaW91cyBPUyBN
YXkgZGVjaWRlIHRvIG5ldmVyIHJlYWQgSUFSKS4gU28gd2UgYXJlDQo+IHBvdGVudGlhbGx5IGRv
aW5nIG1vcmUgd29yayB0aGFuIG5lY2Vzc2FyeSAod2UgbmVlZCB0byB0aGluayBhYm91dCB0aGUN
Cj4gd29yc2UgY2FzZSBzY2VuYXJpbykuDQo+IA0KPiBJbnN0ZWFkLCBJIHRoaW5rIGl0IHdvdWxk
IGJlIGJldHRlciB0byBnbyB0aHJvdWdoIHRoZSAzMiBpbnRlcnJ1cHRzIGFuZA0KPiBmb3IgZWFj
aCBvZiB0aGVtOg0KPiAgICAxKSBmaW5kIHRoZSBwZW5kaW5nX2lycSgpIHVzaW5nIGlycV90b19w
ZW5kaW5nKCkNCj4gICAgMikgY2hlY2sgaWYgdGhlIElSUSBpbiB0aGUgaW5mbGlnaHQgbGlzdCB3
aXRoIGxpc3RfZW1wdHkoJnAtPmluZmxpZ2h0KQ0KPiANCj4gSW4gYWRkaXRpb24gdG8gdGhhdCwg
eW91IHdhbnQgdG8gY2hlY2sgdGhhdCB0aGUgcmFuayBleGlzdHMgc28gd2UgZG9uJ3QNCj4gZG8g
YW55IGV4dHJhIHdvcmsgaWYgdGhlIGd1ZXN0IGlzIHRyeWluZyB0byBjbGVhciBhbiBpbnRlcnJ1
cHRzIGFib3ZlDQo+IHRoZSBudW1iZXIgb2YgaW50ZXJydXB0cyB3ZSBzdXBwb3J0Lg0KPiANCg0K
QWdyZWVkLCBhbmQgdGhhdCdzIHF1aXRlIGhlbHBmdWwuDQoNCj4gPiArICAgICAgICB7DQo+ID4g
KyAgICAgICAgICAgIGlmICggaXRlci0+aXJxIDwgaXJxX3N0YXJ0IHx8IGlycV9lbmQgPCBpdGVy
LT5pcnEgKQ0KPiA+ICsgICAgICAgICAgICAgICAgY29udGludWU7DQo+ID4gKw0KPiA+ICsgICAg
ICAgICAgICBpZiAoIHRlc3RfYml0KEdJQ19JUlFfR1VFU1RfUVVFVUVELCAmaXRlci0+c3RhdHVz
KSApDQo+ID4gKyAgICAgICAgICAgICAgICBpcnFfcGVuZGluZyA9IGlycV9wZW5kaW5nIHwgKDEg
PDwgKGl0ZXItPmlycSAtIGlycV9zdGFydCkpOw0KPiA+ICsgICAgICAgIH0NCj4gPiArDQo+ID4g
KyAgICAgICAgaWYgKCBpcnFfcGVuZGluZyAhPSAwICkNCj4gPiArICAgICAgICAgICAgcHJpbnRr
KFhFTkxPR19HX0VSUg0KPiA+ICsgICAgICAgICAgICAgICAgICAgIiVwdjogdkdJQ0Q6IElDUEVO
RFIlZD0weCUwOHhcbiIsDQo+ID4gKyAgICAgICAgICAgICAgICAgICB2LCBnaWNkX3JlZyAtIEdJ
Q0RfSUNQRU5EUiwgaXJxX3BlbmRpbmcpOw0KPiANCj4gVGhpcyBtZXNzYWdlIGlzIGEgYml0IGNv
bmZ1c2luZy4gSSB0aGluayBpdCB3b3VsZCBiZSB3b3J0aCB0byBwcmludCBhDQo+IG1lc3NhZ2Ug
Zm9yIGV2ZXJ5IGludGVycnVwdCBub3QgY2xlYXJlZC4gTWF5YmUgc29tZXRoaW5nIGxpa2U6DQo+
IA0KPiAiJXB2IHRyeWluZyB0byBjbGVhciBwZW5kaW5nIGludGVycnVwdCAldS4iDQo+IA0KDQpJ
IHdhcyB0aGlua2luZyB0aGF0IHRoZXJlIG1heSBiZSB0b28gbWFueSBpbnRlcnJ1cHRzIHRoZXJl
LCB0byBwcmludCBlYWNoIHdpdGgNCm9uZSBtZXNzYWdlIGxpbmUgd291bGQgYmUgdG9vIHN1cGVy
Zmx1b3VzLiANCkJ1dCB0aGF0IHdvcnN0IGNhc2Ugc2NlbmFyaW8gc2hvdWxkIG5vdCBiZSB1c3Vh
bCwgYW5kIHByaW50IGEgbWVzc2FnZSBmb3IgZWFjaCANCmludGVycnVwdCB3b3VsZCBiZSBtdWNo
IGNsZWFyZXIuDQoNCkFjay4NCg0KPiA+ICsgICAgICAgIGdvdG8gd3JpdGVfaWdub3JlXzMyOw0K
PiA+ICsgICAgfQ0KPiA+DQo+ID4gICAgICAgY2FzZSBWUkFOR0UzMihHSUNEX0lTQUNUSVZFUiwg
R0lDRF9JU0FDVElWRVJOKToNCj4gPiAgICAgICAgICAgaWYgKCBkYWJ0LnNpemUgIT0gREFCVF9X
T1JEICkgZ290byBiYWRfd2lkdGg7DQo+ID4gZGlmZiAtLWdpdCBhL3hlbi9hcmNoL2FybS92Z2lj
LXYzLmMgYi94ZW4vYXJjaC9hcm0vdmdpYy12My5jDQo+ID4gaW5kZXggY2I1YTcwYzQyZS4uMjQz
YjI0ZTQ5NiAxMDA2NDQNCj4gPiAtLS0gYS94ZW4vYXJjaC9hcm0vdmdpYy12My5jDQo+ID4gKysr
IGIveGVuL2FyY2gvYXJtL3ZnaWMtdjMuYw0KPiA+IEBAIC04MTYsMTEgKzgxNiwzNSBAQCBzdGF0
aWMgaW50DQo+IF9fdmdpY192M19kaXN0cl9jb21tb25fbW1pb193cml0ZShjb25zdCBjaGFyICpu
YW1lLCBzdHJ1Y3QgdmNwdSAqdiwNCj4gPiAgICAgICAgICAgcmV0dXJuIDE7DQo+ID4NCj4gPiAg
ICAgICBjYXNlIFZSQU5HRTMyKEdJQ0RfSUNQRU5EUiwgR0lDRF9JQ1BFTkRSTik6DQo+ID4gKyAg
ICB7DQo+ID4gKyAgICAgICAgc3RydWN0IHBlbmRpbmdfaXJxICppdGVyOw0KPiA+ICsgICAgICAg
IHVuc2lnbmVkIGludCBpcnFfc3RhcnQ7DQo+ID4gKyAgICAgICAgdW5zaWduZWQgaW50IGlycV9l
bmQ7DQo+ID4gKyAgICAgICAgdWludDMyX3QgaXJxX3BlbmRpbmcgPSAwOw0KPiA+ICsNCj4gPiAg
ICAgICAgICAgaWYgKCBkYWJ0LnNpemUgIT0gREFCVF9XT1JEICkgZ290byBiYWRfd2lkdGg7DQo+
ID4gICAgICAgICAgIHByaW50ayhYRU5MT0dfR19FUlINCj4gPiAgICAgICAgICAgICAgICAgICIl
cHY6ICVzOiB1bmhhbmRsZWQgd29yZCB3cml0ZSAlIyJQUklyZWdpc3RlciIgdG8gSUNQRU5EUiVk
XG4iLA0KPiA+ICAgICAgICAgICAgICAgICAgdiwgbmFtZSwgciwgcmVnIC0gR0lDRF9JQ1BFTkRS
KTsNCj4gPiAtICAgICAgICByZXR1cm4gMDsNCj4gPiArDQo+ID4gKyAgICAgICAgaXJxX3N0YXJ0
ID0gKHJlZyAtIEdJQ0RfSUNQRU5EUikgKiAzMjsNCj4gPiArICAgICAgICBpcnFfZW5kID0gaXJx
X3N0YXJ0ICsgMzE7DQo+ID4gKyAgICAgICAgLyogZ28gdGhyb3VnaCBpbmZsaWdodF9pcnFzIGFu
ZCBwcmludCBzcGVjaWZpZWQgcGVuZGluZyBpcnFzICovDQo+ID4gKyAgICAgICAgbGlzdF9mb3Jf
ZWFjaF9lbnRyeShpdGVyLCAmdi0+YXJjaC52Z2ljLmluZmxpZ2h0X2lycXMsIGluZmxpZ2h0KQ0K
PiA+ICsgICAgICAgIHsNCj4gPiArICAgICAgICAgICAgaWYgKCBpdGVyLT5pcnEgPCBpcnFfc3Rh
cnQgfHwgaXJxX2VuZCA8IGl0ZXItPmlycSApDQo+ID4gKyAgICAgICAgICAgICAgICBjb250aW51
ZTsNCj4gPiArDQo+ID4gKyAgICAgICAgICAgIGlmICggdGVzdF9iaXQoR0lDX0lSUV9HVUVTVF9R
VUVVRUQsICZpdGVyLT5zdGF0dXMpICkNCj4gPiArICAgICAgICAgICAgICAgIGlycV9wZW5kaW5n
ID0gaXJxX3BlbmRpbmcgfCAoMSA8PCAoaXRlci0+aXJxIC0gaXJxX3N0YXJ0KSk7DQo+ID4gKyAg
ICAgICAgfQ0KPiA+ICsNCj4gPiArICAgICAgICBpZiAoIGlycV9wZW5kaW5nICE9IDAgKQ0KPiA+
ICsgICAgICAgICAgICBwcmludGsoWEVOTE9HX0dfRVJSDQo+ID4gKyAgICAgICAgICAgICAgICAg
ICAiJXB2OiAlczogSUNQRU5EUiVkPTB4JTA4eFxuIiwNCj4gPiArICAgICAgICAgICAgICAgICAg
IHYsIG5hbWUsIHJlZyAtIEdJQ0RfSUNQRU5EUiwgaXJxX3BlbmRpbmcpOw0KPiANCj4gTXkgcmVt
YXJrcyBhcHBseSBmb3IgR0lDdjMgYXMgd2VsbC4gTm90ZSB0aGF0IGluIHRoZSBjYXNlIG9mIEdJ
Q3YzIHYgbWF5DQo+IG5vdCBiZSBjdXJyZW50Lg0KPiANCg0KSSBhbSBhIGJpdCBjb25mdXNlZCB3
aHkgdiBtYXkgbm90IGJlIGN1cnJlbnQgZm9yIEdJQ3YzPyBEb2VzIHRoYXQgbWVhbiANCnRoYXQg
Zm9yIFNQSSB3ZSBzaG91bGQgdXNlIHZnaWNfZ2V0X3RhcmdldF92Y3B1KCkgdG8gZ2V0IGl0cyBj
b3JyZWN0IHZjcHUNCm9uIEdJQ3YzIGFuZCBtdWx0aSBjb3Jlcz8NCg0KPiBUaGF0IHNhaWQsIHRo
ZSBjb2RlIGlzIHF1aXRlIHNpbWlsYXIgYW5kIG5vdCB0cml2aWFsLiBDYW4gd2UgcHJvdmlkZSBh
bg0KPiBoZWxwZXIgdGhhdCBjYW4gYmUgdXNlZCBmb3IgdGhlIHR3byBHSUNzPw0KPiANCg0KWWVz
LCB0byBwcm92aWRlIGEgaGVscGVyIGZ1bmN0aW9uIGluIHZnaWMuYyB3b3VsZCBiZSBtb3JlIGhl
bHBmdWwuDQoNCj4gPiArICAgICAgICBnb3RvIHdyaXRlX2lnbm9yZV8zMjsNCj4gPiArICAgIH0N
Cj4gPg0KPiA+ICAgICAgIGNhc2UgVlJBTkdFMzIoR0lDRF9JU0FDVElWRVIsIEdJQ0RfSVNBQ1RJ
VkVSTik6DQo+ID4gICAgICAgICAgIGlmICggZGFidC5zaXplICE9IERBQlRfV09SRCApIGdvdG8g
YmFkX3dpZHRoOw0KPiA+IEBAIC05NzgsMTkgKzEwMDIsMTcgQEAgc3RhdGljIGludCB2Z2ljX3Yz
X3JkaXN0cl9zZ2lfbW1pb193cml0ZShzdHJ1Y3QNCj4gdmNwdSAqdiwgbW1pb19pbmZvX3QgKmlu
Zm8sDQo+ID4gICAgICAgY2FzZSBWUkVHMzIoR0lDUl9JQ0ZHUjEpOg0KPiA+ICAgICAgIGNhc2Ug
VlJBTkdFMzIoR0lDUl9JUFJJT1JJVFlSMCwgR0lDUl9JUFJJT1JJVFlSNyk6DQo+ID4gICAgICAg
Y2FzZSBWUkVHMzIoR0lDUl9JU1BFTkRSMCk6DQo+ID4gLSAgICAgICAgIC8qDQo+ID4gLSAgICAg
ICAgICAqIEFib3ZlIHJlZ2lzdGVycyBvZmZzZXQgYXJlIGNvbW1vbiB3aXRoIEdJQ0QuDQo+ID4g
LSAgICAgICAgICAqIFNvIGhhbmRsZSBjb21tb24gd2l0aCBHSUNEIGhhbmRsaW5nDQo+ID4gLSAg
ICAgICAgICAqLw0KPiA+ICsgICAgICAgIC8qDQo+ID4gKyAgICAgICAgKiBBYm92ZSByZWdpc3Rl
cnMgb2Zmc2V0IGFyZSBjb21tb24gd2l0aCBHSUNELg0KPiA+ICsgICAgICAgICogU28gaGFuZGxl
IGNvbW1vbiB3aXRoIEdJQ0QgaGFuZGxpbmcNCj4gPiArICAgICAgICAqLw0KPiANCj4gVGhpcyBs
b29rcyBsaWtlIGEgc3B1cmlvdXMgY2hhbmdlLg0KPiANCg0KSSBtb3ZlZCB0aGlzIGNvbW1lbnQg
dG8gdGhlIGxlZnQgYnkgb25lIHNwYWNlIHRvIGFwcGx5IGZvcm1hdCBzdHlsZQ0KdG8gYmUgY29o
ZXJlbnQgd2l0aCBvdGhlcnMuDQpJIHdpbGwgdW5kbyB0aGlzIG1vZGlmaWNhdGlvbiBhbmQgd3Jp
dGUgYW5vdGhlciBwYXRjaCB0byBmaXggaXQgaWYgbmVlZGVkLg0KDQo+ID4gICAgICAgICAgIHJl
dHVybiBfX3ZnaWNfdjNfZGlzdHJfY29tbW9uX21taW9fd3JpdGUoInZHSUNSOiBTR0kiLCB2LA0K
PiA+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGlu
Zm8sIGdpY3JfcmVnLCByKTsNCj4gPg0KPiA+ICAgICAgIGNhc2UgVlJFRzMyKEdJQ1JfSUNQRU5E
UjApOg0KPiA+ICAgICAgICAgICBpZiAoIGRhYnQuc2l6ZSAhPSBEQUJUX1dPUkQgKSBnb3RvIGJh
ZF93aWR0aDsNCj4gPiAtICAgICAgICBwcmludGsoWEVOTE9HX0dfRVJSDQo+ID4gLSAgICAgICAg
ICAgICAgICIlcHY6IHZHSUNSOiBTR0k6IHVuaGFuZGxlZCB3b3JkIHdyaXRlICUjIlBSSXJlZ2lz
dGVyIiB0bw0KPiBJQ1BFTkRSMFxuIiwNCj4gPiAtICAgICAgICAgICAgICAgdiwgcik7DQo+ID4g
LSAgICAgICAgcmV0dXJuIDA7DQo+ID4gKyAgICAgICAgcmV0dXJuIF9fdmdpY192M19kaXN0cl9j
b21tb25fbW1pb193cml0ZSgidkdJQ1I6IFNHSSIsIHYsDQo+ID4gKyAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBpbmZvLCBnaWNyX3JlZywgcik7DQo+ID4N
Cj4gPiAgICAgICBjYXNlIFZSRUczMihHSUNSX0lHUlBNT0RSMCk6DQo+ID4gICAgICAgICAgIC8q
IFdlIGRvIG5vdCBpbXBsZW1lbnQgc2VjdXJpdHkgZXh0ZW5zaW9ucyBmb3IgZ3Vlc3RzLCB3cml0
ZSBpZ25vcmUgKi8NCj4gPg0KPiANCj4gQ2hlZXJzLA0KPiANCj4gLS0NCj4gSnVsaWVuIEdyYWxs
DQoNClRoaXMgaXMgcXVpdGUgYSBnb29kIGFwcHJvYWNoIGFzIFN0ZWZhbm8gc2FpZCBhbmQgaGVs
cHMgYSBsb3QgdG8gbWUuDQoNCkJ1dCBJIGFtIHN0aWxsIGNvbmZ1c2VkIGFib3V0IHRoZSBkaWZm
ZXJlbmNlIGJldHdlZW4gdkdJQ3YyIGFuZA0KdkdJQ3YzIG9uIGNoZWNraW5nIGluZmxpZ2h0IGly
cXMuDQpJIHdpbGwgc2VuZCBwYXRjaCB2ZXJzaW9uMyBBU0FQLg0KDQpbMV0gaHR0cHM6Ly9naXRo
dWIuY29tL3plcGh5cnByb2plY3QtcnRvcy96ZXBoeXIvYmxvYi9lYWY2Y2Y3NDVkZjM4MDdlNmUN
CmNjOTQxYzNhMzBkZTZjMTc5YWUzNTkvZHJpdmVycy9pbnRlcnJ1cHRfY29udHJvbGxlci9pbnRj
X2dpY3YzLmMjTDI3NA0KDQpDaGVlcnMsDQpIb25nZGENCg0K


From xen-devel-bounces@lists.xenproject.org Thu Oct 14 07:08:16 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Oct 2021 07:08:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.209033.365360 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mauqV-0004oT-T5; Thu, 14 Oct 2021 07:08:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 209033.365360; Thu, 14 Oct 2021 07:08:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mauqV-0004oM-Pu; Thu, 14 Oct 2021 07:08:07 +0000
Received: by outflank-mailman (input) for mailman id 209033;
 Thu, 14 Oct 2021 07:08:06 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mauqU-0004oC-DQ; Thu, 14 Oct 2021 07:08:06 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mauqU-0002Do-8d; Thu, 14 Oct 2021 07:08:06 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mauqU-0005i0-0s; Thu, 14 Oct 2021 07:08:06 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mauqU-0007Ka-0O; Thu, 14 Oct 2021 07:08:06 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=oGgK8Q4+lMpDwiQWPtLy/lyunKyssYlXsMUELvrTNfM=; b=lhNqtX/wCtuMI8W58TkDg5R0qQ
	ZTyIsuoF8EdQr7Uk8rYOft4YuUxdmCpkhfccAYO+4Kd48wZSMtBppl2zje6s7J1VqChn8N6xZd1ho
	S95j44tbmwJhRxPPGiE0z+1aC9glCnFPgdeDbG3HEv76gSVC0XNz8rLwi4B8LIThKOew=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165502-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 165502: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=978d428ec3ca2520c217819901c8465235c45c5e
X-Osstest-Versions-That:
    ovmf=6ed6abd6c116e8599876a2876b77e172e800b13e
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 14 Oct 2021 07:08:06 +0000

flight 165502 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165502/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 978d428ec3ca2520c217819901c8465235c45c5e
baseline version:
 ovmf                 6ed6abd6c116e8599876a2876b77e172e800b13e

Last test of basis   165494  2021-10-13 12:41:14 Z    0 days
Testing same since   165502  2021-10-13 23:10:03 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Ma, Maurice <maurice.ma@intel.com>
  Maurice Ma <maurice.ma@intel.com>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   6ed6abd6c1..978d428ec3  978d428ec3ca2520c217819901c8465235c45c5e -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Thu Oct 14 07:53:42 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Oct 2021 07:53:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.209043.365386 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mavYT-0001No-OG; Thu, 14 Oct 2021 07:53:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 209043.365386; Thu, 14 Oct 2021 07:53:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mavYT-0001Nh-L6; Thu, 14 Oct 2021 07:53:33 +0000
Received: by outflank-mailman (input) for mailman id 209043;
 Thu, 14 Oct 2021 07:53:31 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=iCUr=PC=arm.com=Bertrand.Marquis@srs-us1.protection.inumbo.net>)
 id 1mavYR-00019b-P0
 for xen-devel@lists.xenproject.org; Thu, 14 Oct 2021 07:53:31 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com (unknown
 [40.107.7.47]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id d261dbda-2cc3-11ec-81b3-12813bfff9fa;
 Thu, 14 Oct 2021 07:53:30 +0000 (UTC)
Received: from AM6P193CA0096.EURP193.PROD.OUTLOOK.COM (2603:10a6:209:88::37)
 by PAXPR08MB6624.eurprd08.prod.outlook.com (2603:10a6:102:dd::12) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16; Thu, 14 Oct
 2021 07:53:26 +0000
Received: from VE1EUR03FT008.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:209:88:cafe::a0) by AM6P193CA0096.outlook.office365.com
 (2603:10a6:209:88::37) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16 via Frontend
 Transport; Thu, 14 Oct 2021 07:53:26 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT008.mail.protection.outlook.com (10.152.18.75) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.15 via Frontend Transport; Thu, 14 Oct 2021 07:53:26 +0000
Received: ("Tessian outbound 16951d3c485e:v103");
 Thu, 14 Oct 2021 07:53:26 +0000
Received: from 1c877b85bad2.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 DEB1E27D-77BC-44B6-AE78-8E09361C4E14.1; 
 Thu, 14 Oct 2021 07:53:15 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 1c877b85bad2.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Thu, 14 Oct 2021 07:53:15 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com (2603:10a6:4:74::9)
 by DB6PR08MB2822.eurprd08.prod.outlook.com (2603:10a6:6:1d::25) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.22; Thu, 14 Oct
 2021 07:53:13 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955]) by DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955%4]) with mapi id 15.20.4587.030; Thu, 14 Oct 2021
 07:53:12 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d261dbda-2cc3-11ec-81b3-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=J79vioLckscLcM6JqhblayZZ63O2BK/HjMKwlN2DRDU=;
 b=D7V6mvmO3d8GBlcxbCaquv3i3xY7SUrcSCQzml5YANA7QierbiMokvFeX5wWu2H2UJIO1kiaB9o4eyikUDORfMH+hOdOIEECpb/zsytthGjxBlI3EtCUTFf0WwLlo0TCKR8ZY1OeBxLV57BU+JoVmy+4r4ftSdj9BlRXdXWeBiA=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: bd5f277f30b3a19e
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=TcTfA52+CX08PPq3mdWBiyPD50WiGcOE+SeDnCInwArTMuE4QieOMbbon5yWWTFn/YqfLSjmEzBbOti8hdbYho+KG5tp3KLfjn8/9PdRrV/EY0Yp0uTjqc5dqf9QLA9jdVZbORHZdhHRDePUPI1YFQsmXxnGb+CnJFflrWyG2pBgJZWf9I1btmZnvCsxTY/RNs5vAmecijaFFWEXVsJNtXRufpQv+R7NwfqAgLSPlK8OjS6tRO9M8ysbKcn9U/aYFqfWEaWT2HXXTuH4wNJj3Dhi6VikkUpAARK/epB6qxtdJ4x5F+wZ2QK0jt1jAzjC2QHoTg4qT9Rt38l36redDA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=J79vioLckscLcM6JqhblayZZ63O2BK/HjMKwlN2DRDU=;
 b=mAZSluxuYRAIKLV0lyjTLARDCkAk3jA0y8KbvWkSXAp1WlqF9XC9QHVbQqnvEU4Ji13QSzb7GAYdBk3Is89sGA90Po7BrOZwfjTFBkqp/D7Li+YbVpctHjkpMCgPAhhiLVw+LbRkbfs6Q0xDbddZrJ9+SD8o6Mjj6CjceyeMnpdFx4qSWrlsMRNDp7p+dFEG5nCRb/1RH7X9IKhR5teQcG7knbiDButlfU55Zk4/Wk0dwb2o4jkAwpZqY2X/qKkf+chLyCWHKSJdOMfiY5AKAE5GlYjjiuEP6kiucwO8vc6lsRUgqHA2U4+oC1mNhtYC9yFE3DEY8gvQPg1wAYjAiA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=J79vioLckscLcM6JqhblayZZ63O2BK/HjMKwlN2DRDU=;
 b=D7V6mvmO3d8GBlcxbCaquv3i3xY7SUrcSCQzml5YANA7QierbiMokvFeX5wWu2H2UJIO1kiaB9o4eyikUDORfMH+hOdOIEECpb/zsytthGjxBlI3EtCUTFf0WwLlo0TCKR8ZY1OeBxLV57BU+JoVmy+4r4ftSdj9BlRXdXWeBiA=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Stefano Stabellini <sstabellini@kernel.org>, Oleksandr Andrushchenko
	<Oleksandr_Andrushchenko@epam.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, Andre Przywara <Andre.Przywara@arm.com>,
	Julien Grall <julien@xen.org>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
	Rahul Singh <Rahul.Singh@arm.com>, George Dunlap <george.dunlap@citrix.com>,
	Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>, Paul Durrant
	<paul@xen.org>, =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>
Subject: Re: [PATCH v5 08/11] xen/arm: Enable the existing x86 virtual PCI
 support for ARM.
Thread-Topic: [PATCH v5 08/11] xen/arm: Enable the existing x86 virtual PCI
 support for ARM.
Thread-Index:
 AQHXutl3YqS5dHXsYk6KpdKt4d14RavQp5+AgABHSICAAB7yAIAABuOAgABGSACAALogAIAAFjsA
Date: Thu, 14 Oct 2021 07:53:12 +0000
Message-ID: <0209BA09-920C-4505-BA91-27254F1AE891@arm.com>
References: <cover.1633540842.git.rahul.singh@arm.com>
 <9bdca2cda5d2e83f94dc2423e55714273539760a.1633540842.git.rahul.singh@arm.com>
 <YWaco/UvA4xFE1xW@MacBook-Air-de-Roger.local>
 <6d75f604-6938-b185-61e1-a6684d9fca14@suse.com>
 <2b943774-072e-20a1-b97c-d88b24adf340@epam.com>
 <ed4876ca-7384-42a8-6fba-e73c1840402a@suse.com>
 <alpine.DEB.2.21.2110131223210.9408@sstabellini-ThinkPad-T480s>
 <fa345819-068d-0049-f0e8-8b96379b4247@suse.com>
In-Reply-To: <fa345819-068d-0049-f0e8-8b96379b4247@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3654.120.0.1.13)
Authentication-Results-Original: suse.com; dkim=none (message not signed)
 header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: c7f63154-b2fa-4ce0-af8d-08d98ee7b47c
x-ms-traffictypediagnostic: DB6PR08MB2822:|PAXPR08MB6624:
x-ms-exchange-transport-forked: True
X-Microsoft-Antispam-PRVS:
	<PAXPR08MB66244F0DDEDB0615E602C8739DB89@PAXPR08MB6624.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:9508;OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 7Lhj9DI7qoAVCXqQpQCfTSHTkFDPytj0Tl53juY4HSdVu8D0PBJjme5+5dQJfOT7m++yMn3fAgP2BYPmPY6gwEB8E/0qhQChqsZt+KgVETNvef3mvO/UWg8x1ZEgIwSgXiuzBFVerIZ+bm4LtYRlSAckjpp73L3pBRezi1ClBPHRiYFxv2eD74gskO8mWrfIxPKpPefhso/lMsDhKeg+qaVwvjsvzeJozaCTLPDUOcIzN9Een5fW95gLpyNFkYck0NTb4XcJ25LVkMBAjcoHgX1e4GW4TA/T40VZl4L49cNRrE/EbmRXDraYE8FGIPl5QL92DxyWCXsdYPKR94bl1yxpAiLaQxW8Z8fSRix3XPx3YDAm1Mjtjq0Q3O5gRXQ64SxFQ7gJ8DqB/cU863GIHj8Yq08fh7PwFLyuD8KwmE631WVzIpBIRUE1OVlkefWg2+NB+z4eXZc+c+RV43bR6wgYwODX4so4w4BnxLV5RsX1tM6U2Sfpq/L9FkTsI3oTDB3qT7cMhSYO4RbxaX41lhDnFVJYVphb8sSkRVQ6BadyvZnxSqp9tQ1CV9UF3FTotLMDErb4Z8FYryhHG7S37Djn5ufwAh4HmV5k7FzACOcewF18HJrPe6wvrIn84t992hzH515MmlDphhy7dQbWvczju89JSImQRlCPdxM++6TJJlUCr6lVHNtI+QeD7dkxzJIdJhx8ZeSd5oU+/PDFC6jEmhlCcl6swL3gzCw9Hw2FpDVJmHcgFbO+3Hgjca84bulNwUq/GfDInZbGLGYbb7yG8Njtzwu3fJB+eUnvVyQnRrguNlPUL7RNoA3BS79a75wGEYkQ/M+xSnjgloj7KA==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB6PR0801MB2024.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(5660300002)(33656002)(2906002)(6512007)(122000001)(71200400001)(86362001)(38100700002)(7416002)(4326008)(186003)(91956017)(64756008)(66446008)(36756003)(66946007)(2616005)(26005)(316002)(54906003)(76116006)(66556008)(66476007)(8676002)(53546011)(6506007)(8936002)(83380400001)(6486002)(38070700005)(6916009)(508600001)(966005)(2004002)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-ID: <2A06ECD37E84E24E89C31E4376A96B60@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR08MB2822
Original-Authentication-Results: suse.com; dkim=none (message not signed)
 header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT008.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	ed74bc46-9933-468c-540e-08d98ee7ac5c
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	/ABtoxPiPQsOeti7WEeWM54+N4OLavPFdUB1Ugv/oZ90CdyXzn3BPjfUSm+XGg/7SLoERq8BVcFJZ5BtWYwbnFUATcw8cVKpGrlOSz8uvvte2R1M/QeP9IhUcO3PQUpoZmrqnQrH5LWYmcin4Lu10iwf7K9Ml3PBNxzktcfu5GcXeGntODsz7PAcd1jNqH6Iqbb+FvlIPV5AC77eGDaC5gVO8r4fBMKjZK1nBq+Wafq6ba71e37g+ZnVD9fbli7OMPBiqaiHEEV+U7+keZVD69gCCtupn/ZkmdEAcRVyL0f5btIt/1jDFZGmCCmtkDHTwWGZpRyo06R/ZU6uXvidjpvy37EjCVukl1H3OSmzloKEpibak/8wG+uWGCAS27ChTeo7UPPOOQ/R/GbSQL4ZItYHmPiFAf024Uf36rW8A/LRKLyqDhMYeCNpWjhhDU+GMmVzr470rNWoFK3/J6fvnGHfkVJd/1vz8ivqHmyQ4KYESIpR7wcFu3EZMYIqq8U1ISy8UYbloj3YS26G8iJuPER7V8bQs9kt0fViLvUczWzxiQuV/esoEPGzlsJ84w3Brc98TIL0Eo5nCu9tc8Yex8OP2V5+FMRqo3nu4yVSkwxU+IWmgYg895mgslb4955Rl8L9WhzyC05tW8oNeG1cmqZmBoScXwFmgWrAyKJqQcMfSM7NhudKOXIrqG67AmnR5CWSciIo8/lm6Dm2ZBbHrNNzFSl6xc90KB9ZFs7rCG0OWlWeWR2J2QVOTzTZHNQAlyokygnPikWlf7/a69QU+ILFYXLfOui4jnesX3DKV3zGpYzD8Q/XYSyq0/306JKR
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(81166007)(4326008)(54906003)(6486002)(26005)(8936002)(8676002)(356005)(316002)(508600001)(36860700001)(966005)(36756003)(47076005)(2906002)(6862004)(82310400003)(83380400001)(86362001)(70206006)(53546011)(6506007)(2616005)(107886003)(6512007)(33656002)(186003)(70586007)(336012)(5660300002)(2004002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2021 07:53:26.4916
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: c7f63154-b2fa-4ce0-af8d-08d98ee7b47c
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT008.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6624

SGksDQoNCj4gT24gMTQgT2N0IDIwMjEsIGF0IDA3OjMzLCBKYW4gQmV1bGljaCA8amJldWxpY2hA
c3VzZS5jb20+IHdyb3RlOg0KPiANCj4gT24gMTMuMTAuMjAyMSAyMToyNywgU3RlZmFubyBTdGFi
ZWxsaW5pIHdyb3RlOg0KPj4gT24gV2VkLCAxMyBPY3QgMjAyMSwgSmFuIEJldWxpY2ggd3JvdGU6
DQo+Pj4gT24gMTMuMTAuMjAyMSAxNjo1MSwgT2xla3NhbmRyIEFuZHJ1c2hjaGVua28gd3JvdGU6
DQo+Pj4+IE9uIDEzLjEwLjIxIDE2OjAwLCBKYW4gQmV1bGljaCB3cm90ZToNCj4+Pj4+IE9uIDEz
LjEwLjIwMjEgMTA6NDUsIFJvZ2VyIFBhdSBNb25uw6kgd3JvdGU6DQo+Pj4+Pj4gT24gV2VkLCBP
Y3QgMDYsIDIwMjEgYXQgMDY6NDA6MzRQTSArMDEwMCwgUmFodWwgU2luZ2ggd3JvdGU6DQo+Pj4+
Pj4+IC0tLSAvZGV2L251bGwNCj4+Pj4+Pj4gKysrIGIveGVuL2FyY2gvYXJtL3ZwY2kuYw0KPj4+
Pj4+PiBAQCAtMCwwICsxLDEwMiBAQA0KPj4+Pj4+PiArLyoNCj4+Pj4+Pj4gKyAqIHhlbi9hcmNo
L2FybS92cGNpLmMNCj4+Pj4+Pj4gKyAqDQo+Pj4+Pj4+ICsgKiBUaGlzIHByb2dyYW0gaXMgZnJl
ZSBzb2Z0d2FyZTsgeW91IGNhbiByZWRpc3RyaWJ1dGUgaXQgYW5kL29yIG1vZGlmeQ0KPj4+Pj4+
PiArICogaXQgdW5kZXIgdGhlIHRlcm1zIG9mIHRoZSBHTlUgR2VuZXJhbCBQdWJsaWMgTGljZW5z
ZSBhcyBwdWJsaXNoZWQgYnkNCj4+Pj4+Pj4gKyAqIHRoZSBGcmVlIFNvZnR3YXJlIEZvdW5kYXRp
b247IGVpdGhlciB2ZXJzaW9uIDIgb2YgdGhlIExpY2Vuc2UsIG9yDQo+Pj4+Pj4+ICsgKiAoYXQg
eW91ciBvcHRpb24pIGFueSBsYXRlciB2ZXJzaW9uLg0KPj4+Pj4+PiArICoNCj4+Pj4+Pj4gKyAq
IFRoaXMgcHJvZ3JhbSBpcyBkaXN0cmlidXRlZCBpbiB0aGUgaG9wZSB0aGF0IGl0IHdpbGwgYmUg
dXNlZnVsLA0KPj4+Pj4+PiArICogYnV0IFdJVEhPVVQgQU5ZIFdBUlJBTlRZOyB3aXRob3V0IGV2
ZW4gdGhlIGltcGxpZWQgd2FycmFudHkgb2YNCj4+Pj4+Pj4gKyAqIE1FUkNIQU5UQUJJTElUWSBv
ciBGSVRORVNTIEZPUiBBIFBBUlRJQ1VMQVIgUFVSUE9TRS4gIFNlZSB0aGUNCj4+Pj4+Pj4gKyAq
IEdOVSBHZW5lcmFsIFB1YmxpYyBMaWNlbnNlIGZvciBtb3JlIGRldGFpbHMuDQo+Pj4+Pj4+ICsg
Ki8NCj4+Pj4+Pj4gKyNpbmNsdWRlIDx4ZW4vc2NoZWQuaD4NCj4+Pj4+Pj4gKw0KPj4+Pj4+PiAr
I2luY2x1ZGUgPGFzbS9tbWlvLmg+DQo+Pj4+Pj4+ICsNCj4+Pj4+Pj4gKyNkZWZpbmUgUkVHSVNU
RVJfT0ZGU0VUKGFkZHIpICAoIChhZGRyKSAmIDB4MDAwMDBmZmYpDQo+Pj4+Pj4+ICsNCj4+Pj4+
Pj4gKy8qIERvIHNvbWUgc2FuaXR5IGNoZWNrcy4gKi8NCj4+Pj4+Pj4gK3N0YXRpYyBib29sIHZw
Y2lfbW1pb19hY2Nlc3NfYWxsb3dlZCh1bnNpZ25lZCBpbnQgcmVnLCB1bnNpZ25lZCBpbnQgbGVu
KQ0KPj4+Pj4+PiArew0KPj4+Pj4+PiArICAgIC8qIENoZWNrIGFjY2VzcyBzaXplLiAqLw0KPj4+
Pj4+PiArICAgIGlmICggbGVuID4gOCApDQo+Pj4+Pj4+ICsgICAgICAgIHJldHVybiBmYWxzZTsN
Cj4+Pj4+Pj4gKw0KPj4+Pj4+PiArICAgIC8qIENoZWNrIHRoYXQgYWNjZXNzIGlzIHNpemUgYWxp
Z25lZC4gKi8NCj4+Pj4+Pj4gKyAgICBpZiAoIChyZWcgJiAobGVuIC0gMSkpICkNCj4+Pj4+Pj4g
KyAgICAgICAgcmV0dXJuIGZhbHNlOw0KPj4+Pj4+PiArDQo+Pj4+Pj4+ICsgICAgcmV0dXJuIHRy
dWU7DQo+Pj4+Pj4+ICt9DQo+Pj4+Pj4+ICsNCj4+Pj4+Pj4gK3N0YXRpYyBpbnQgdnBjaV9tbWlv
X3JlYWQoc3RydWN0IHZjcHUgKnYsIG1taW9faW5mb190ICppbmZvLA0KPj4+Pj4+PiArICAgICAg
ICAgICAgICAgICAgICAgICAgICByZWdpc3Rlcl90ICpyLCB2b2lkICpwKQ0KPj4+Pj4+PiArew0K
Pj4+Pj4+PiArICAgIHVuc2lnbmVkIGludCByZWc7DQo+Pj4+Pj4+ICsgICAgcGNpX3NiZGZfdCBz
YmRmOw0KPj4+Pj4+PiArICAgIHVuc2lnbmVkIGxvbmcgZGF0YSA9IH4wVUw7DQo+Pj4+Pj4+ICsg
ICAgdW5zaWduZWQgaW50IHNpemUgPSAxVSA8PCBpbmZvLT5kYWJ0LnNpemU7DQo+Pj4+Pj4+ICsN
Cj4+Pj4+Pj4gKyAgICBzYmRmLnNiZGYgPSBNTUNGR19CREYoaW5mby0+Z3BhKTsNCj4+Pj4+Pj4g
KyAgICByZWcgPSBSRUdJU1RFUl9PRkZTRVQoaW5mby0+Z3BhKTsNCj4+Pj4+Pj4gKw0KPj4+Pj4+
PiArICAgIGlmICggIXZwY2lfbW1pb19hY2Nlc3NfYWxsb3dlZChyZWcsIHNpemUpICkNCj4+Pj4+
Pj4gKyAgICAgICAgcmV0dXJuIDA7DQo+Pj4+Pj4+ICsNCj4+Pj4+Pj4gKyAgICBkYXRhID0gdnBj
aV9yZWFkKHNiZGYsIHJlZywgbWluKDR1LCBzaXplKSk7DQo+Pj4+Pj4+ICsgICAgaWYgKCBzaXpl
ID09IDggKQ0KPj4+Pj4+PiArICAgICAgICBkYXRhIHw9ICh1aW50NjRfdCl2cGNpX3JlYWQoc2Jk
ZiwgcmVnICsgNCwgNCkgPDwgMzI7DQo+Pj4+Pj4+ICsNCj4+Pj4+Pj4gKyAgICAqciA9IGRhdGE7
DQo+Pj4+Pj4+ICsNCj4+Pj4+Pj4gKyAgICByZXR1cm4gMTsNCj4+Pj4+Pj4gK30NCj4+Pj4+Pj4g
Kw0KPj4+Pj4+PiArc3RhdGljIGludCB2cGNpX21taW9fd3JpdGUoc3RydWN0IHZjcHUgKnYsIG1t
aW9faW5mb190ICppbmZvLA0KPj4+Pj4+PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgcmVn
aXN0ZXJfdCByLCB2b2lkICpwKQ0KPj4+Pj4+PiArew0KPj4+Pj4+PiArICAgIHVuc2lnbmVkIGlu
dCByZWc7DQo+Pj4+Pj4+ICsgICAgcGNpX3NiZGZfdCBzYmRmOw0KPj4+Pj4+PiArICAgIHVuc2ln
bmVkIGxvbmcgZGF0YSA9IHI7DQo+Pj4+Pj4+ICsgICAgdW5zaWduZWQgaW50IHNpemUgPSAxVSA8
PCBpbmZvLT5kYWJ0LnNpemU7DQo+Pj4+Pj4+ICsNCj4+Pj4+Pj4gKyAgICBzYmRmLnNiZGYgPSBN
TUNGR19CREYoaW5mby0+Z3BhKTsNCj4+Pj4+Pj4gKyAgICByZWcgPSBSRUdJU1RFUl9PRkZTRVQo
aW5mby0+Z3BhKTsNCj4+Pj4+Pj4gKw0KPj4+Pj4+PiArICAgIGlmICggIXZwY2lfbW1pb19hY2Nl
c3NfYWxsb3dlZChyZWcsIHNpemUpICkNCj4+Pj4+Pj4gKyAgICAgICAgcmV0dXJuIDA7DQo+Pj4+
Pj4+ICsNCj4+Pj4+Pj4gKyAgICB2cGNpX3dyaXRlKHNiZGYsIHJlZywgbWluKDR1LCBzaXplKSwg
ZGF0YSk7DQo+Pj4+Pj4+ICsgICAgaWYgKCBzaXplID09IDggKQ0KPj4+Pj4+PiArICAgICAgICB2
cGNpX3dyaXRlKHNiZGYsIHJlZyArIDQsIDQsIGRhdGEgPj4gMzIpOw0KPj4+Pj4+IEkgdGhpbmsg
dGhvc2UgdHdvIGhlbHBlcnMgKGFuZCB2cGNpX21taW9fYWNjZXNzX2FsbG93ZWQpIGFyZSB2ZXJ5
DQo+Pj4+Pj4gc2ltaWxhciB0byB0aGUgZXhpc3RpbmcgeDg2IG9uZXMgKHNlZSB2cGNpX21tY2Zn
X3tyZWFkLHdyaXRlfSksIHVwIHRvDQo+Pj4+Pj4gdGhlIHBvaW50IHdoZXJlIEkgd291bGQgY29u
c2lkZXIgbW92aW5nIHRoZSBzaGFyZWQgY29kZSB0byB2cGNpLmMgYXMNCj4+Pj4+PiB2cGNpX2Vj
YW1fe3JlYWQsd3JpdGV9IGFuZCBjYWxsIHRoZW0gZnJvbSB0aGUgYXJjaCBzcGVjaWZpYyB0cmFw
DQo+Pj4+Pj4gaGFuZGxlcnMuDQo+Pj4+PiBFeGNlcHQgdGhhdCBwbGVhc2UgY2FuIHdlIHN0aWNr
IHRvIG1jZmcgb3IgbW1jZmcgaW5zdGVhZCBvZiBlY2FtDQo+Pj4+PiBpbiBuYW1lcywgYXMgdGhh
dCdzIGhvdyB0aGUgdGhpbmcgaGFzIGJlZW4gbmFtZWQgaW4gWGVuIGZyb20gaXRzDQo+Pj4+PiBp
bnRyb2R1Y3Rpb24/IEkndmUganVzdCBncmVwLWVkIHRoZSBjb2RlIGJhc2UgKGNhc2UgaW5zZW5z
aXRpdmVseSkNCj4+Pj4+IGFuZCBmb3VuZCBubyBtZW50aW9uIG9mIEVDQU0uIFRoZXJlIGFyZSBv
bmx5IGEgZmV3ICJiZWNhbWUiLg0KPj4+PiBJIGRvIHVuZGVyc3RhbmQgdGhhdCB0aGlzIGlzIGhp
c3RvcmljYWxseSB0aGF0IHdlIGRvIG5vdCBoYXZlIEVDQU0gaW4gWGVuLA0KPj4+PiBidXQgUENJ
IGlzIG5vdCBhYm91dCBYZW4uIFRodXMsIEkgdGhpbmsgaXQgaXMgYWxzbyBhY2NlcHRhYmxlIHRv
IHVzZQ0KPj4+PiBhIGNvbW1vbmx5IGtub3duIEVDQU0gZm9yIHRoZSBjb2RlIHRoYXQgd29ya3Mg
d2l0aCBFQ0FNLg0KPj4+IA0KPj4+IEFDUEksIGFmYWlrLCBhbHNvIGRvZXNuJ3QgY2FsbCB0aGlz
IEVDQU0uIFRoYXQncyB3aGVyZSBNQ0ZHIC8gTU1DRkcNCj4+PiBhY3R1YWxseSBjb21lIGZyb20s
IEkgYmVsaWV2ZS4NCj4+IA0KPj4gTXkgdW5kZXJzdGFuZGluZyBpcyB0aGF0ICJNQ0ZHIiBpcyB0
aGUgbmFtZSBvZiB0aGUgQUNQSSB0YWJsZSB0aGF0DQo+PiBkZXNjcmliZXMgdGhlIFBDSSBjb25m
aWcgc3BhY2UgWzFdLiBUaGUgdW5kZXJseWluZyBQQ0kgc3RhbmRhcmQgZm9yIHRoZQ0KPj4gbWVt
b3J5IG1hcHBlZCBsYXlvdXQgb2YgdGhlIFBDSSBjb25maWcgc3BhY2UgaXMgY2FsbGVkIEVDQU0u
IEhlcmUsIGl0DQo+PiBtYWtlcyBzZW5zZSB0byBjYWxsIGl0IEVDQU0gYXMgaXQgaXMgZmlybXdh
cmUgaW5kZXBlbmRlbnQuDQo+PiANCj4+IFsxXSBodHRwczovL3dpa2kub3NkZXYub3JnL1BDSV9F
eHByZXNzDQo+IA0KPiBPa2F5LCBJIGNhbiBhY2NlcHQgdGhpcywgYnV0IHRoZW4gSSdkIGV4cGVj
dCBhbGwgZXhpc3RpbmcgdXNlcyBvZg0KPiBNQ0ZHIC8gTU1DRkcgaW4gdGhlIGNvZGUgd2hpY2gg
YXJlbid0IGRpcmVjdGx5IEFDUEktcmVsYXRlZCB0byBnZXQNCj4gcmVwbGFjZWQuIE90aGVyd2lz
ZSBpdCdzIG5lZWRsZXNzbHkgaGFyZGVyIHRvIGlkZW50aWZ5IHRoYXQgb25lDQo+IHBpZWNlIG9m
IGNvZGUgcmVsYXRlcyB0byBjZXJ0YWluIG90aGVyIHBpZWNlcy4NCg0KVG8gc3VtIHVwIG9uIHRo
aXMgc3ViamVjdCwgaGVyZSB3aGF0IEkgd2lsbCBkbyBpbiB2ZXJzaW9uIDY6DQotIG1vdmUgdnBj
aV9lY2FtX3tyZWFkL3dyaXRlfSB0byB2cGNpLmMgYW5kIHJlbmFtZSB0aGVtDQotIHNhbWUgZm9y
IGFjY2VzcyBhbGxvd2VkIGFuZCBJIHdpbGwgcmVuYW1lIGl0IHRvIHZwY2lfZWNhbV9hY2Nlc3Nf
YWxsb3dlZA0KDQpJIHdpbGwgd29yayBvbiB0aGlzIGFuZCB0cnkgdG8gcHVzaCB2NiBiZWZvcmUg
dGhlIGVuZCBvZiB0aGUgZGF5IChhbHNvIGhhbmRsaW5nIG90aGVyIHJlbWFya3Mgb24gdGhpcyBw
YXRjaCkuDQoNCkNoZWVycw0KQmVydHJhbmQNCg0KPiANCj4gSmFuDQo+IA0KDQo=


From xen-devel-bounces@lists.xenproject.org Thu Oct 14 07:53:44 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Oct 2021 07:53:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.209042.365375 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mavYR-00017x-Fh; Thu, 14 Oct 2021 07:53:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 209042.365375; Thu, 14 Oct 2021 07:53:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mavYR-00017q-CG; Thu, 14 Oct 2021 07:53:31 +0000
Received: by outflank-mailman (input) for mailman id 209042;
 Thu, 14 Oct 2021 07:53:29 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=iCUr=PC=arm.com=Bertrand.Marquis@srs-us1.protection.inumbo.net>)
 id 1mavYP-00017U-Fz
 for xen-devel@lists.xenproject.org; Thu, 14 Oct 2021 07:53:29 +0000
Received: from EUR02-VE1-obe.outbound.protection.outlook.com (unknown
 [2a01:111:f400:fe06::631])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id b95ed533-64e9-43ac-9fb3-edc97d29aac3;
 Thu, 14 Oct 2021 07:53:28 +0000 (UTC)
Received: from DB7PR03CA0103.eurprd03.prod.outlook.com (2603:10a6:10:72::44)
 by VI1PR08MB3632.eurprd08.prod.outlook.com (2603:10a6:803:79::16) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.24; Thu, 14 Oct
 2021 07:53:24 +0000
Received: from DB5EUR03FT033.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:10:72:cafe::fc) by DB7PR03CA0103.outlook.office365.com
 (2603:10a6:10:72::44) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15 via Frontend
 Transport; Thu, 14 Oct 2021 07:53:24 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT033.mail.protection.outlook.com (10.152.20.76) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.15 via Frontend Transport; Thu, 14 Oct 2021 07:53:24 +0000
Received: ("Tessian outbound 8e26f7114b75:v103");
 Thu, 14 Oct 2021 07:53:23 +0000
Received: from 75f9ea936d07.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 E9E109EE-7488-44BA-AEE2-9E84F1E65DEA.1; 
 Thu, 14 Oct 2021 07:53:13 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 75f9ea936d07.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Thu, 14 Oct 2021 07:53:13 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com (2603:10a6:4:74::9)
 by DB6PR08MB2822.eurprd08.prod.outlook.com (2603:10a6:6:1d::25) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.22; Thu, 14 Oct
 2021 07:53:09 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955]) by DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955%4]) with mapi id 15.20.4587.030; Thu, 14 Oct 2021
 07:53:08 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b95ed533-64e9-43ac-9fb3-edc97d29aac3
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=D3hniK8TgyhjX7ZotJXolx+f+dUXjT+7XaYxcvNbHb8=;
 b=Ku/yMFiBZbQvNcRpcP9x+zXbG07yC/cw/j28V+/D6/FNAf+Xrj7GAyvSa55kcSwcIVZu0mrHggQZKCf+ZiQa5hLEL2HTAt41LUR6AmHkUBm+oKm2fHpGV2zuc5wpm+bJI7NvUqt+aang5ECsejebR6uZYenUMXnIOdgKzqtnFDM=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: f53ed9ee73b09798
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=DJZoMH4s6vV/A4CJYHwolLLbBYoNu5I9lcIoAh/XzEdshSFYES1nW1HBoKlUpoIhbgxLwxZKCjKkQS2bfRKYxHExG5OE8KRNRhBVdvT0qVLAHPUlqRCNJWHyHS25sE4boz6Tdf0XguSPpeHieLMXNOxP79nxpx9oeZl/IY+Z514rIS/ciOLOQwH5dLp57XFrrVULwyO0mClDy8u+5NhNMkMzp1tuflfT1WBK1uvS5JxJw/0RAhB/B4OogXH+G5POcGgwNqoPW2iT7P0g1s8OV44UkFZRqggP71JWKntQi9sLUITF3JsZOQ8MIERO58j3eK0bk6psRLRMbrTCcT7YwA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=D3hniK8TgyhjX7ZotJXolx+f+dUXjT+7XaYxcvNbHb8=;
 b=CI+16kZUFJnnwoO8w/DD9QQWXmQ/QEBwrL/plza/Z2jaa9YelEfa/QB1lYfAz7/GmhhL/8B1Hg2DmrI9cb5YWdDbWs5Un/giMYZAjHCPCadKrGHGGT4dkDggewPeNZttcMsjyc4Odw4pBYC2PGgeT6miQ+j3nZU/NO0CtX6NKAur87bYP3EBzGBEoKaB1pwK0FwdKcw5AKXidlrV2/dBQCjIxzzMJkoltf/x1S81+uXgIBNXDysVELhmqyUEN8hm9Fm5XnMUZO7yLTZYZjS6wYg1ldJ/9+8Lq1/BTDbuEo5Z91eDqMjzn/6xWkR6eBTabMPW9hhWYjGUDe9gcKHr0A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=D3hniK8TgyhjX7ZotJXolx+f+dUXjT+7XaYxcvNbHb8=;
 b=Ku/yMFiBZbQvNcRpcP9x+zXbG07yC/cw/j28V+/D6/FNAf+Xrj7GAyvSa55kcSwcIVZu0mrHggQZKCf+ZiQa5hLEL2HTAt41LUR6AmHkUBm+oKm2fHpGV2zuc5wpm+bJI7NvUqt+aang5ECsejebR6uZYenUMXnIOdgKzqtnFDM=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Stefano Stabellini <sstabellini@kernel.org>, Michal Orzel
	<Michal.Orzel@arm.com>, Rahul Singh <Rahul.Singh@arm.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Andre
 Przywara <Andre.Przywara@arm.com>, Christian Lindig
	<christian.lindig@citrix.com>, David Scott <dave@recoil.org>, Ian Jackson
	<iwj@xenproject.org>, Wei Liu <wl@xen.org>, Andrew Cooper
	<andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>, Julien
 Grall <julien@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	=?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>
Subject: Re: [PATCH v5 07/11] xen/domctl: Introduce XEN_DOMCTL_CDF_vpci flag
Thread-Topic: [PATCH v5 07/11] xen/domctl: Introduce XEN_DOMCTL_CDF_vpci flag
Thread-Index:
 AQHXutmFlM61oLukkkqK7dSQSsVJ1qvNjrkAgAGmMoCAAW6PgIAAEkkAgAAWnQCAABTUgIAADMyAgACBoYCAAKKsAIAAGQ0A
Date: Thu, 14 Oct 2021 07:53:08 +0000
Message-ID: <2E52D99F-7980-483E-A9B7-643C93BE3E2E@arm.com>
References: <cover.1633540842.git.rahul.singh@arm.com>
 <20d5b9d6a0d01a7b90711d28cbefb5701a88b438.1633540842.git.rahul.singh@arm.com>
 <YWQDguvmf/O4rDIs@MacBook-Air-de-Roger.local>
 <9217a6b8-fc53-a049-7cd3-7458b574424b@arm.com>
 <YWaZKX44IOfIBtX6@MacBook-Air-de-Roger.local>
 <8F9D6B9C-58CB-4000-995A-95517EE72A3B@arm.com>
 <YWa7eGr3D8Ax8VUX@MacBook-Air-de-Roger.local>
 <9C5C0FE2-67EA-4CD7-893B-82C156F5F77A@arm.com>
 <e88892cf-e0c3-c39c-dce8-bfe2d25a5b53@suse.com>
 <alpine.DEB.2.21.2110131113212.9408@sstabellini-ThinkPad-T480s>
 <291330d4-73c4-7893-7735-23c21ba04ccb@suse.com>
In-Reply-To: <291330d4-73c4-7893-7735-23c21ba04ccb@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3654.120.0.1.13)
Authentication-Results-Original: suse.com; dkim=none (message not signed)
 header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: d9f73750-f54d-4022-91ae-08d98ee7b2f2
x-ms-traffictypediagnostic: DB6PR08MB2822:|VI1PR08MB3632:
x-ms-exchange-transport-forked: True
X-Microsoft-Antispam-PRVS:
	<VI1PR08MB36325A50527A322121AAA8E99DB89@VI1PR08MB3632.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:10000;OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 zpcJJ0zUMXuwC8JwKAJVYtxxlXswqbQGWeKtp5E1dNOjFANyTVyPVaSitMz9RhztWSA2ODieL4SRm4wF7dQNUOWnSCLFiAYTdERyDx2+Zzq6ktikJR4XKGvTkKv3B1iwOV66oXVcbQYrJ+DO+q35ZpH9bOpJQOoxbGQP1EVi6UbRTnllMJuMl65I+sbNscekLRb57ki4sN62ftyGNWZmKdOCXireFm3Ac6FX4R/SaUYzwbOSjxqFizHodQhMPBkNNWhRINS492fGCjT/7IXUUpTh6JjyIYoZGA7+jWYB+n5gcV91J0WIgXLu4+pUcg/849FCxDaBJlIoAS3bQVXNkhRdFOfaodPr0mOIqtUIYkfQAQG5LSrudb7CFiz2Bp07bB3KJzDwlQgIFYDFxq9jjQg+KSDcOzrznGnPnHtIvQoxC0ETxoKzLFuv4Y09lr2UrcSob1F5R/15blid/v49+AFBPAz0HIOkx8S5iUhTX6WuGXdpZxmkxARltshLnH/1LM/xtOa0ineGdQjoYpCZqXf0LMUVqDh9l6QGycqLzhd/KMIR8APvGFfTxlJI9xgj5VBY8m9Jzxrp1MKOqbemqAp2FZElPMrnRmdmzKuoiPSyl9BIHr6B2SUKjmyZgIoPsqej9k2vgZlFc5aZB48NeUaRqLMYbrg2W4KPNR7M9SjqpD2yuS/2ZdwF7bSwkojGs7uC5NJpkMbQikJxEdVtYHzsow1zri/1ecu4Lt3UTsNcght1LlO9EUsaGNzKvR581CAjLJ3rH+BBEfD2vSGlSteFGix7lGKYOmf7u6SMN1TpWccxq2/xhnd8rltn9BJHXxjgHOU/lwJMGkNzbAsWrNCHFeCNzxATp69UGIAFi7g=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB6PR0801MB2024.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(5660300002)(33656002)(2906002)(6512007)(122000001)(71200400001)(86362001)(38100700002)(7416002)(4326008)(186003)(91956017)(64756008)(66446008)(36756003)(66946007)(2616005)(26005)(316002)(54906003)(76116006)(66556008)(66476007)(8676002)(53546011)(6506007)(8936002)(83380400001)(6486002)(38070700005)(6916009)(508600001)(966005)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-ID: <4C5F1E288DB03D479308C702D21F6B12@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR08MB2822
Original-Authentication-Results: suse.com; dkim=none (message not signed)
 header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT033.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	5ee88600-fec9-44fe-99c8-08d98ee7a9f4
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	FlXmOja18m28a00DITXjTNplve98OX0RDE3KvDtPiF1lbplw+8ZDCMViwyM6a0Pr8PikTeGOJGWQPpn5GOKvas7+BTsh9/yN5U6aBBT+Pug5N3stDGUbVyq5FF4sonkM1/SFLagrqlsuz/CeLKMe/T/3IC7eP4r1UhjzIKDj0Clv6/BcB0R+7zoh1L1svphy6va05vLmGKcV+qgvEwv28yzUnq4iClQQErfs1YwXZtoQlMBlpNi0GzFnqxCPUCEIKYKpof6QQ2pdHA6QY7iTSKCQh5DQbWO0cLj8P/GrC3lZiyEQQleemAZxcN6IAB+4iJ5bQY6SoYdI/lTjFn4rxdzvfCno98uaCW6duU/NeNlon9z516vgtk6cSafY69wdxFqHJaUItwKfRiWz8nkgupZSqCoKt1+9QzQKwsQ2+TVyOK/kRkNEcuovdWaUzCw20k7eIfvFRHpJvI6Xci0CGvjN/2zwTRnsL5T0I5En15XTCNmf8AYhd536ou6eVpUK/ON643WrBXXX82AIuSOfIYqeXvmkIPZmMBGnz3pQYmvHyyhXOa3iedjtey+LAe/JCKDeGbPLF/Py01qYZHZf4LcDyeY5OO6PoWgNdCnUqD8EE8BnIFdpOtJdSmTKyJo6HzFL8I/V7vqRlTq+xq9xInhyf81rQDaa+Ii9GQHL0HUfmMv2HfMzudkQITGBf1cxRxq2/ef9gK3A4+JLIz1sBhFmUQ5HQr5glsAlO0MBUqGudqgccT8mQh3c6RXZtoXGY6yhTpEpD33uayJyx7MstmMAzaa5nXk+Y/UgJBbDJJOXOJVEyyAXRjp81pLSBIcp
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(26005)(33656002)(53546011)(8676002)(8936002)(6506007)(107886003)(6512007)(186003)(316002)(336012)(36756003)(81166007)(47076005)(6486002)(5660300002)(356005)(70206006)(36860700001)(70586007)(82310400003)(2616005)(2906002)(83380400001)(4326008)(966005)(508600001)(6862004)(86362001)(54906003);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2021 07:53:24.0396
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: d9f73750-f54d-4022-91ae-08d98ee7b2f2
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT033.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3632

SGksDQoNCj4gT24gMTQgT2N0IDIwMjEsIGF0IDA3OjIzLCBKYW4gQmV1bGljaCA8amJldWxpY2hA
c3VzZS5jb20+IHdyb3RlOg0KPiANCj4gT24gMTMuMTAuMjAyMSAyMjo0MSwgU3RlZmFubyBTdGFi
ZWxsaW5pIHdyb3RlOg0KPj4gT24gV2VkLCAxMyBPY3QgMjAyMSwgSmFuIEJldWxpY2ggd3JvdGU6
DQo+Pj4gT24gMTMuMTAuMjAyMSAxNDoxMSwgQmVydHJhbmQgTWFycXVpcyB3cm90ZToNCj4+Pj4+
IE9uIDEzIE9jdCAyMDIxLCBhdCAxMTo1NiwgUm9nZXIgUGF1IE1vbm7DqSA8cm9nZXIucGF1QGNp
dHJpeC5jb20+IHdyb3RlOg0KPj4+Pj4gSWYgdlBDSSBmb3IgQXJtIG9uIDQuMTYgaXMgbm90IGdv
aW5nIHRvIGJlIGZ1bmN0aW9uYWwsIHdoeSBzbyBtdWNoDQo+Pj4+PiBwcmVzc3VyZSBpbiBwdXNo
aW5nIHRob3NlIHBhdGNoZXMgc28gZmFzdD8gSSB1bmRlcnN0YW5kIHRoZSBuZWVkIHRvDQo+Pj4+
PiByZW1vdmUgc3R1ZmYgZnJvbSB0aGUgcXVldWUsIGJ1dCBJIGRvbid0IHRoaW5rIGl0J3Mgd29y
dGggdGhlIGNvc3Qgb2YNCj4+Pj4+IGludHJvZHVjaW5nIGEgYnJva2VuIGludGVyZmFjZSBkZWxp
YmVyYXRlbHkgb24gYSByZWxlYXNlLg0KPj4+IA0KPj4+ICsxDQo+Pj4gDQo+Pj4+IFdlIGRpZCBu
b3QgcHVzaCB0aGF0IGZhc3QsIHRob3NlIGhhdmUgYmVlbiBvbiB0aGUgbWFpbGluZyBsaXN0IGZv
ciBhIHdoaWxlICh0aGlzIGlzIHRoZSA1dGggdmVyc2lvbiBvZiB0aGUgc2VyaWUpLg0KPj4+PiBQ
Q0kgcGFzc3Rocm91Z2ggaXMgYSBiaWcgY2hhbmdlIHJlcXVpcmluZyBsb3RzIG9mIHBhdGNoZXMg
YW5kIHdlIGRlY2lkZWQgdG8gcHVzaCBpdCBwaWVjZSBieSBwaWVjZSB0byBtYWtlDQo+Pj4+IHRo
ZSByZXZpZXcgZWFzaWVyLg0KPj4+IA0KPj4+IDUgdmVyc2lvbnMgZm9yIGEgc2VyaWVzIGxpa2Ug
dGhpcyBvbmUgd2FzIHRvIGJlIGV4cGVjdGVkLiBJbW8gaXQgaGFzDQo+Pj4gYmVlbiB3cm9uZyBp
biB0aGUgcGFzdCB0byBydXNoIGluIG5ldyBmZWF0dXJlcyAoZXZlbiBpZiBleHBlcmltZW50YWwN
Cj4+PiBvbmVzKSB2ZXJ5IGNsb3NlIHRvIHRoZSBmcmVlemUsIGFuZCBpdCBoYXMgbWlzbGVhZCBw
ZW9wbGUgdG8gdGhpbmsNCj4+PiB0aGV5IGNhbiBkZWxheSB3b3JrIHVudGlsIHZlcnkgKHRvbz8p
IGxhdGUgYSBwb2ludCBpbiB0aW1lLg0KPj4gDQo+PiANCj4+IEhpIFJvZ2VyLCBKYW4sDQo+PiAN
Cj4+IExldCBtZSB0YWtlIGEgZmV3IG1pbnV0ZXMgdG8gY2xhcmlmeSBhbmQgcHJvdmlkZSBjb250
ZXh0IGZvciB0aGlzIHdvcmsuDQo+PiANCj4+IA0KPj4gSSBkb24ndCB0aGluayBhbnlvbmUgInB1
c2hlZCBoYXJkIiBhbnkgb2YgdGhlIEFSTSBzZXJpZXMgY2xvc2UgdG8gdGhlDQo+PiByZWxlYXNl
LiBJIHNlbnQgIm9uZSIgZW1haWwgaW4gcHVibGljIGFzIGEgcmVtaW5kZXIgb2YgdGhpbmdzIHRo
YXQgbmVlZA0KPj4gcmV2aWV3aW5nOg0KPj4gaHR0cHM6Ly9tYXJjLmluZm8vP2w9eGVuLWRldmVs
Jm09MTYzMzczNzc2NjExMTU0DQo+PiANCj4+IEkgZGlkIHNlbmQgYSBjb3VwbGUgb2YgcHJpdmF0
ZSBlbWFpbHMgdG8gSmFuIGJ1dCB0aGV5IHdlcmUgdG8gc3luY2hyb25pemUNCj4+IG91cnNlbHZl
cyByYXRoZXIgdGhhbiBwdXNoOyBKYW4sIEkgaG9wZSB5b3UgZGlkbid0IHRha2UgdGhlbSB0aGUg
d3JvbmcNCj4+IHdheS4NCj4gDQo+IERlZmluaXRlbHkgbm90LCBubyB3b3JyaWVzLg0KPiANCj4+
IEF0IHRoZSBzYW1lIHRpbWUgaXQgaXMgY2VydGFpbmx5IHRydWUgdGhhdCBhbGwgdGhlIHBlb3Bs
ZSBpbnZvbHZlZCBoZXJlDQo+PiB3b3JrZWQgdmVyeSBoYXJkIHRvIGdldCB0aGVzZSBzZXJpZXMg
cmVhZHkgZm9yIDQuMTYuIE9jdCAxNSBpcyB0aGUgWGVuDQo+PiBQcm9qZWN0IGZlYXR1cmUgZnJl
ZXplLiBJdCBpcyBhbHNvIHRoZSBkZWFkbGluZSBmb3IgbWFueSBvZiB1cyB3b3JraW5nDQo+PiB3
aXRoIHVwc3RyZWFtIFhlbiBQcm9qZWN0IHRvIHVwc3RyZWFtIGZlYXR1cmVzIGFuZCByZXBvcnQg
YmFjayB0byBvdXINCj4+IG1hbmFnZW1lbnQuIEkga25vdyBpdCBkb2Vzbid0IGFmZmVjdCB5b3Ug
Z3V5cyBkaXJlY3RseSwgYnV0IHlvdSBjYW4NCj4+IGltYWdpbmUgdGhhdCBhcyBlbXBsb3llZXMg
b2Ygb3VyIHJlc3BlY3RpdmUgY29tcGFuaWVzIHdlIGZlZWwgcHJlc3N1cmUNCj4+IHRvIGNvbXBs
ZXRlIG91ciBvYmplY3RpdmVzIGluIHRoZSBnaXZlbiB0aW1lZnJhbWUuIE9mIGNvdXJzZSB3ZSBu
ZWVkIHRvDQo+PiBtYWtlIHN1cmUgdG8gZG8gdGhhdCB3aXRob3V0IGNvbXByb21pc2luZyBxdWFs
aXR5IGFuZCB3aXRob3V0DQo+PiBvdmVyZXh0ZW5kaW5nIHVwc3RyZWFtIHJldmlldyBjYXBhY2l0
eS4NCj4+IA0KPj4gDQo+PiBUaGUgQVJNIFBDSSBzZXJpZXMgYXJlIHB1YmxpYyBzaW5jZSBEZWMg
MjAyMCwgcHVzaGVkIHRvIGEgZ2l0bGFiIGJyYW5jaA0KPj4gZm9yIHRlc3Rpbmc6IGh0dHBzOi8v
Z2l0bGFiLmNvbS94ZW4tcHJvamVjdC9mdXNhL3hlbi1pbnRlZ3JhdGlvbi8tL3RyZWUvaW50ZWdy
YXRpb24vcGNpLXBhc3N0aHJvdWdoDQo+PiBJIGhlbHBlZCBjcmVhdGluZywgbWFuYWdpbmcgYW5k
IHRlc3RpbmcgdGhlIGJyYW5jaC4NCj4+IA0KPj4gU28sIEkgY2FuIHNlZSB3aHkgQmVydHJhbmQg
ZmVlbHMgbGlrZSB0aGV5IGhhdmUgYmVlbiBhcm91bmQgZm9yIGEgd2hpbGU6DQo+PiB3ZSBoYXZl
IGJlZW4gZGVhbGluZyB3aXRoIHRoZXNlIHBhdGNoZXMgZm9yIGFsbW9zdCBhIHllYXIsIGV2ZW4g
aWYgZnJvbQ0KPj4gYSB4ZW4tZGV2ZWwgcGVyc3BlY3RpdmUgd2UgYXJlICJvbmx5IiBhdCB2ZXJz
aW9uIDUuDQo+IA0KPiBJJ20gYWZyYWlkIHRoYXQgYW55dGhpbmcgbm90IG9uIHhlbi1kZXZlbCBk
b2Vzbid0IHJlYWxseSBjb3VudDsgdGhlIGxpc3QNCj4gaXMgdGhlIG9ubHkgIm9mZmljaWFsIiBj
aGFubmVsLiBJU1RSIHRoYXQgZm9yIGNlcnRhaW4gYXNwZWN0cyB0aGVyZSdzIGENCj4gcGxhbiBH
ZW9yZ2UgaGFzIHRvIG1ha2UgdGhpcyBtb3JlIHByb25vdW5jZWQgLyBmb3JtYWwgaW4gc29tZSBv
ZiB0aGUgZG9jcw0KPiB3ZSBoYXZlLg0KPiANCj4gTWFraW5nIGludGVybmFsbHkgc2V0IGRlYWRs
aW5lcyBpcyBhIGZ1bGx5IHVuZGVyc3RhbmRhYmxlIGFzcGVjdC4gQnV0DQo+IHN0YXJ0aW5nIHRv
IHBvc3QgaW4gU2VwdGVtYmVyIGZvciBhIG1pZC1PY3RvYmVyIGRlYWRsaW5lIGlzIHB1dHRpbmcN
Cj4gb25lc2VsZiBhdCByaXNrLCBJIHdvdWxkIHNheSwgZm9yIGEgKHNldCBvZikgc2VyaWVzIHRo
aXMgaW52b2x2ZWQuIEkgc2VlDQo+IG5vIHByb2JsZW0gd2l0aCBhbnlvbmUgZG9pbmcgc28sIGFz
IGxvbmcgYXMgdGhleSBhY2NlcHQgdGhhdCByaXNrIHJhdGhlcg0KPiB0aGFuIGV4cGVjdGluZyB0
byBnZXQgYXdheSBieSBlaXRoZXIgZXh0cmFvcmRpbmFyeSBlZmZvcnRzIGJ5IG90aGVycw0KPiAo
cmV2aWV3ZXJzKSBvciByZWxheGF0aW9uIG9mIHdoYXQgaXMgcGVybWl0dGVkIHRvIGdvIGluLg0K
PiANCj4gT2YgY291cnNlIHRoZXJlJ3MgdGhlIG9wcG9zaXRlIHByb2JsZW0gb2YgZmVlZGJhY2sg
dGFraW5nIHVudXN1YWxseSAoSSdtDQo+IGluY2xpbmVkIHRvIHNheSB1bmR1bHkpIGxvbmcgdG8g
YXJyaXZlLCBsaWtlIHdpdGggdGhlIGdwYWRkcl9iaXRzDQo+IGFkZGl0aW9uIHN0aWxsIGZhY2lu
ZyB2YWd1ZSAvIHVuY2xlYXIgb3Bwb3NpdGlvbiBieSBBbmRyZXcuDQo+IA0KPj4gTXkgc3VnZ2Vz
dGlvbiBpcyB0byBhY2NlcHQgdGhlIFRPRE8gZm9yIHBhdGNoICM4IFsxXSBidXQgSSBhZ3JlZSB3
aXRoDQo+PiBSb2dlciB0aGF0IHdlIHNob3VsZG4ndCBpbnRyb2R1Y2UgYmFkIGludGVyZmFjZXMs
IGVzcGVjaWFsbHkgYXMgdGhleQ0KPj4gaW1wYWN0IHg4NiB3aGljaCBpcyBub3QgInRlY2ggcHJl
dmlldyIuIFNvIEkgdGhpbmsgd2Ugc2hvdWxkIHJldmVydA0KPj4gcGF0Y2ggIzcgKHRoaXMgcGF0
Y2guKSBJJ2xsIHJlcGx5IHdpdGggbW9yZSBkZXRhaWxzIGluIHNlcGFyYXRlIHNob3J0ZXINCj4+
IGVtYWlsLg0KPj4gDQo+PiBbMV0gaHR0cHM6Ly9tYXJjLmluZm8vP2w9eGVuLWRldmVsJm09MTYz
NDEyMTIwNTMxMjQ4DQo+IA0KPiBGV0lXIEkgYWdyZWUgd2l0aCBib3RoIHByb3Bvc2FscyAoYWNj
ZXB0YW5jZSBvZiBUT0RPIGFuZCByZXZlcnQpLg0KDQpJIHdhbnQgdG8gc2F5IGFnYWluIHRoYXQg
bm90aGluZyBJIHNhaWQgd2FzIG1lYW50IGFzIGEgY3JpdGljIGFuZCBJIGFtIHZlcnkNCmdyYXRl
ZnVsIG9mIGFsbCByZXZpZXdzIGFuZCBjb21tZW50cyB0aGF0IHdlIGhhdmUgKGV2ZW4gaWYgc29t
ZSBvZiB0aGVtDQphcmUgaW1wbHlpbmcgd29yayBvciBwdXNoaW5nIHN0dWZmIGluIHRoZSBmdXR1
cmUpIGFzIHdlIHdhbnQgdG8gZG8gdGhpcyByaWdodC4NCg0KV2Ugd2lsbCBkbyB0aGUgZm9sbG93
aW5nIGJlZm9yZSB0aGUgZW5kIG9mIHRoZSBkYXkgdG9kYXk6DQotIHNlbmQgYSByZXZlcnRpbmcg
cGF0Y2ggZm9yIHBhdGNoIDcNCi0gc2VuZCB1cGRhdGVkIHZlcnNpb24gb2YgcGF0Y2ggOCBoYW5k
bGluZyBhbGwgcGVuZGluZyBjb21tZW50cw0KDQpXZSB3aWxsIHRyeSB0byAobm90IHN1cmUgYXMg
c29tZSBjaGFuZ2VzIG1pZ2h0IGJlIG1vcmUgY29tcGxleCkNCi0gc2VuZCBhbiB1cGRhdGVkIHZl
cnNpb24gb2YgcGF0Y2ggMTANCi0gdHJ5IHRvIGZpbmQgYSBzb2x1dGlvbiBhY2NlcHRhYmxlIGZv
ciBwYXRjaCAxDQoNClRoYW5rcyBldmVyeW9uZSBmb3IgdGhlIHN1cHBvcnQgaGVyZSBhbmQgdGhl
IGh1Z2UgYW1vdW50IG9mIHRpbWUNCnNwZW50IG9uIHJldmlld2luZyBhbGwgcGF0Y2hlcyB0aGF0
IHdhcyBwdXNoZWQgKGFuZCB0aGVyZSB3YXMgYSBsb3Qgb2YgdGhlbSkuDQoNCk92ZXIgdGhlIG5l
eHQgbW9udGggQXJtIGlzIGNvbW1pdHRlZCB0byBwdXQgYSBsb3QgbW9yZSBlZmZvcnQgaW4gcmV2
aWV3aW5nIGFuZA0KdGVzdGluZyBwYXRjaGVzIHB1c2hlZCB0byB4ZW4tZGV2ZWwuIFdlIG5vdyBo
YXZlIGFuIGludGVybmFsIENJIHRoYXQgd2lsbCBoZWxwDQp1cyBhIGxvdCBhbmQgYWxsIHBlb3Bs
ZSBpbiBBcm0gWGVuIHRlYW0gd2lsbCBzdGFydCB0byBoYXZlIGRlZGljYXRlZCB0aW1lIHRvIHJl
dmlldw0KdXBzdHJlYW0gcGF0Y2hlcyBhbmQgaGVscCB0aGUgY29tbXVuaXR5Lg0KWGVuIGlzIGEg
YmlnIHBhcnQgb2YgQXJtIHN0cmF0ZWd5IGFyb3VuZCBhdXRvbW90aXZlIGFzIHRoZSByZWZlcmVu
Y2UgVHlwZSAxDQpoeXBlcnZpc29yIGFuZCB3ZSB3aWxsIG5vdCBkaXNhcHBlYXIgc29vbiA6LSkN
Cg0KSWYgdGhlcmUgYXJlIGFueSBvdXRzdGFuZGluZyBzZXJpZSBvciBwYXRjaGVzIGZvciB3aGlj
aCB5b3Ugd291bGQgbGlrZSB1cyB0byBoZWxwDQpPbiByZXZpZXcsIHBsZWFzZSBkbyBub3QgaGVz
aXRhdGUgdG8gcGluZyBtZSBhbmQgSSB3aWxsIHNlZSBob3cgd2UgY2FuIGhlbHAgKGV2ZW4NCmlm
IGl0IGlzIG9ubHkgdG8gZG8gc29tZSB0ZXN0aW5nKS4NCg0KVGhhbmtzIGFnYWluIGV2ZXJ5b25l
IGZvciB0aGUgaGVscC4NCg0KQ2hlZXJzDQpCZXJ0cmFuZA0KDQpQUzogSSB3aWxsIHN0YXkgY29u
bmVjdGVkIG9uIElSQyBpZiBzb21lb25lIG5lZWRzIHRvIGNvbnRhY3QgbWUuDQoNCj4gDQo+IEph
bg0KDQo=


From xen-devel-bounces@lists.xenproject.org Thu Oct 14 08:08:56 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Oct 2021 08:08:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.209064.365397 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mavnG-0003ty-GH; Thu, 14 Oct 2021 08:08:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 209064.365397; Thu, 14 Oct 2021 08:08:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mavnG-0003tr-CD; Thu, 14 Oct 2021 08:08:50 +0000
Received: by outflank-mailman (input) for mailman id 209064;
 Thu, 14 Oct 2021 08:08:49 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Xl23=PC=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mavnF-0003tl-AG
 for xen-devel@lists.xenproject.org; Thu, 14 Oct 2021 08:08:49 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 3f5fb9ea-36a2-4de8-af4d-164fba92f45d;
 Thu, 14 Oct 2021 08:08:48 +0000 (UTC)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2052.outbound.protection.outlook.com [104.47.12.52]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-21-kRjNosiFOsOv2kiZ4rq5gw-1; Thu, 14 Oct 2021 10:08:46 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0401MB2448.eurprd04.prod.outlook.com (2603:10a6:800:52::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16; Thu, 14 Oct
 2021 08:08:44 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.016; Thu, 14 Oct 2021
 08:08:44 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6P192CA0030.EURP192.PROD.OUTLOOK.COM (2603:10a6:209:83::43) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.14 via Frontend Transport; Thu, 14 Oct 2021 08:08:43 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3f5fb9ea-36a2-4de8-af4d-164fba92f45d
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634198927;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=GW9Cbua5oZ362cbCXIdYE06fuKD9FywCuCQTgiWmguA=;
	b=OmGieRRQh2aNbD9DFWRqeynfuaEIfzMCFubxnPCh9++zDVdhQN2sHEZoYk0VGnfgmzDNBh
	55vy5WlHCUDgiauO/ydbfjxHzhd1vWi0cb6qbBV2GGwt5HuLdxyfP5DggEwZ3Qo0JuaXa+
	v+34+bFFEu3wBlZ7Sz0Nyf4FfNrXq8E=
X-MC-Unique: kRjNosiFOsOv2kiZ4rq5gw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Cg4C/voBt2yikgn2Ex4SnHyRznAwb6QktcgP3wlFQimyYKPpBCWmzp4ON7Q2nD9u5m3lw251Qb1QzSCFf8QAcdA9wyj8y8bbhWu6I/amUVs8RthF6SoicNMG0xuACjU/PD9SwuyF1dxe/eS/q+9ic+fA0/FZ6T9mLCT3dth5c7TIgjnjVKXZtAwN+q1RrcTGGu0PF+BvoiuVrP17rbfMx1HlbawWqfro598mt+xLEcJV5U1SosnXc3fRffDHadNbXkXcCpDdyH4R+TMHnw3YOyDSFyWLEU3k9R+m4vP7ErvlZoNHQumrCzjpd4wp6vsUb2Q/VQ3y+5IuygxVILGmEA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=GW9Cbua5oZ362cbCXIdYE06fuKD9FywCuCQTgiWmguA=;
 b=a9S5hX7rs3RxLJGyAxcswMP2qM/+1KyvZUrh+sYq8rKINBSNhPmazkl9YsGsflOFqK4dzir//MXaMWD5y5TXmureEOdZgQwBJfCg+TcadJtn3AjkBO4+sIYtOZAR9Ajmv6VJuuwvwEn7tFAM4t1VrTlmQqm0nnzqyJCEWI0DEUn93C7tSAYU/v8s7QEvUsQ8V2x1S3Tm1feZL2hg1nudheAWLJHP+p2a1q3m8PA3GrGdkJ9GTUyWx2Wd6plw0L6xzYTRV3mNmQ5XFLA5FIWuGkvxbOygIXyQ6+lEjTK+5cErJnzNrMCv+5eRMg/xlGl6fg9plw+AK2fEQUbQkXIvqg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [XEN PATCH v7 40/51] build: fix dependencies in arch/x86/boot
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>, Wei Liu
 <wl@xen.org>, xen-devel@lists.xenproject.org
References: <20210824105038.1257926-1-anthony.perard@citrix.com>
 <20210824105038.1257926-41-anthony.perard@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <9fbe1805-3d56-1146-c19f-3be2f8e949be@suse.com>
Date: Thu, 14 Oct 2021 10:08:42 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <20210824105038.1257926-41-anthony.perard@citrix.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P192CA0030.EURP192.PROD.OUTLOOK.COM
 (2603:10a6:209:83::43) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 3a2665f9-241c-4268-d8e2-08d98ee9d769
X-MS-TrafficTypeDiagnostic: VI1PR0401MB2448:
X-Microsoft-Antispam-PRVS:
	<VI1PR0401MB2448942930B0E3CFF4E6B0ADB3B89@VI1PR0401MB2448.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6430;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	TkaR6M5BdzG3Km+N+jEsImH/aIlwfa5YkLWOvVONly26IAznH/z0l5+9tRLTd4h5xvN83NUZcvHzNWRDyD8iaOU4btXZBmJAmiEovXxbS+8DtNj+Jk32P6He5qAMrNOnAvGqhPOk708z3VTDkpBbaVgzuiUynvMVyU1eZcVCC/Ltl6PfKn7hBuzyVQb+jPzARWpdddnTilKgcfUSF4gs3kod5oV3foMdwA0G8HdOE5436XJE6Cmc0AbzJQAL1QGo4tDQL5dXXXNVqlnAIhNKVMBd2UMGq8yB4AD4CV0w+Nvplwusj+WY2JqN0y5WremVzFKh0y2uTEsSbv51JaNE6DNdgMGUyWywd+tCzqchexcBMD7XCSvQFYFhlA/IaNT2wy6KdflN4BoiLDKdK7+M0hC4cti/+/Pwo8wn9Ano3TJqLFC7jqWmo7hNAP0U6E7Jun6eNX0v7AJjRyR0ywJvfv+DJJO1ose7I9L6V8u/JkiQr0FuxdWtyKmvIxuYB090ZpsagC6+hQaY+v+q9szPg9zkDCjw+2Kyb/bgisrhxOYkS0gttkGmOQAfkjBEUOo2oJGKZ+4YlL+6vlSgZl80jPnBcTaYecfLSiHBCXpEEbRH8MBjJUhNcvmNPdcEgI6TACMB75o7n1c3S1oP8C/qahEMhLx73ajMCHH+qVYS7nqFf9Iq/b5fsmkCVOkwTgYcJrQYr0s3ghxXyK4XzvAT2eDrYcykLgotavsh4FUpFaw=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(66946007)(8936002)(26005)(53546011)(5660300002)(508600001)(186003)(38100700002)(316002)(66476007)(66556008)(16576012)(54906003)(8676002)(6916009)(2616005)(4326008)(86362001)(31686004)(36756003)(956004)(6486002)(2906002)(31696002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?NDBCRThFS2VtUk4zRFB5SHpQRjVCUkFUcHNQQlhFK2VKWTc3TGtBWFRKTHds?=
 =?utf-8?B?azNFMjlaU3Z5NGZwM1pUQUdiRFFiTnR3dkFDWGl5QnErUWYySnNQQ1o0a1Nl?=
 =?utf-8?B?aTVPTXRVYWhUbHdKYVFmQ3pWcUVZU3VsaHY5U2dMcU92RGRMaWN1c05nVDRw?=
 =?utf-8?B?RGY5bDZVZFl3cC9RWC9KQnB0R25pZk9WR3lkcHl6eitDQ3M5ZHpsemx3b2h2?=
 =?utf-8?B?Y0hVSVZNakRPOGswaERVL3VsOVg2WjhYZGlNNG9YdUIxMXNnTFNwRm9PLzhQ?=
 =?utf-8?B?UlNVWFlzNnZLNmE4aCtaSncxSnpmSk5qVG1XVGdTclZPTUdXRTJhNGl4bFNQ?=
 =?utf-8?B?b0NoZ1dNbGVjMUFMUkFvOGlGRDNoZEpFQUtQeUFCTkZRdER3amQvVGhDQTZz?=
 =?utf-8?B?S2dPMnhHNHNEcFdGekFMeTU3OFlxeUFGdjhrM2JBZWpjWkFCeWNSRzFiUlcw?=
 =?utf-8?B?dVpuNmNNd1kzMTBSYTJ6QlA4UmcwaTNkWlVobzBEZHdxTFVOYmlITFowd2xq?=
 =?utf-8?B?QWlQaHRDZEVTQ2JQZUUxTCtZQy9WN3JobWc5QWpua2JzM1cwVVcwK1k5ay9u?=
 =?utf-8?B?a2c2aEZtQXBsMGMyOTBSckRPS09pY0NUcHJKMGpjY1hDT0NRdTVFWmdyRGIz?=
 =?utf-8?B?Ni84Mm1zZkxQclMrY01vNC8xNUxaRW4vazNRdTI5QnlIdnpBOXliYzljOGp1?=
 =?utf-8?B?azUvV0Z0MmN4WStlVFZiSzhoMXR2c3dLaFdWd3F2bDZDYlRFM2tWczRLNUow?=
 =?utf-8?B?ZzRKbkx3aE83QVZjTWh4U0NpUUgvTDRWckI3Snp0d0hheUZFNThvNkFicTBG?=
 =?utf-8?B?dXJ4VDlJNE16cUhIOGkzNUNVc0N1Y0VRck13T1lQZ1hNR052QWFiSjV4aFg3?=
 =?utf-8?B?ckkzSytMQVNiNnZHckVFL0hrRDlvNkk1VE9KUU9BTVQyZU1CL1Q5ZFlaUHFl?=
 =?utf-8?B?MTgraXp0cm95dVprMFYvYS8xcjBUbWF3WGNYNldERVFJUDdVSGpZOTg4WXEx?=
 =?utf-8?B?Y09IV3F4WUFqR1VTYVgrSG9TMmVUSmJuOFNOVk53MGhkVmpPM1JYbk4yTjQy?=
 =?utf-8?B?SWh4VkZ3bndDMnZQSGt6WXAreklUb1lZbWsydnN3WkxVWlprQ2ptVU1VWHFa?=
 =?utf-8?B?SUZHU1oxN2REazQwNk9IbzZaOGsvSzQrVmpmNWYzNTV0TFFpdXpqV2VYREhO?=
 =?utf-8?B?d1F2QWozN2FnMW9zazVkR0h2WTkzUDZIVVM4VHhXRTE5N1N6TXhtUlFWY1dX?=
 =?utf-8?B?N3Q1Zk85TklBK0d4QndHVm14bnVEMDQ2MGRTYnNReE9ya2RzbmphUmUxaHZD?=
 =?utf-8?B?L1FXN2g2dklsNmtJOUo4MGdXeWNPTUZYNUtNeG1LM2FjemVYZmo0WXlGeUlx?=
 =?utf-8?B?SWJVcHRnUUltTlNvOTluci94NFpoVSt3SExwTlJTN0d2VkxtQlQzQkV1UVhV?=
 =?utf-8?B?bkhCRWdIRlRqODNxQVdqL0NnUWwvOWgxZ2lXQU5YNUJUK1F3d2F1MUJzbWl4?=
 =?utf-8?B?d1haa1dUTmFabjJ1M2NScUg3UkQzK1BKU0o4TEkxTDlXVnJva2pYVG5BVTZa?=
 =?utf-8?B?WFhQWnZ0MEowdTNEdHR4cytVbDcvdk94NjdUUk82MTBxR0M4VjRYblpPRFBT?=
 =?utf-8?B?Qnp1NFFFNDJSR21zWXVDN3VDUmJ2SC9WaXhzcVJZWGtNc0xQSEhTRWg0L3VR?=
 =?utf-8?B?MFBEUTNzdk1zbGZqd1JHVGdGemtHSzRpWFBqbUtpQ2luSEcxZ3RWQlBhU1JN?=
 =?utf-8?Q?2+36mAWOzeHZOBTAQRwnlPwvyEYbrm6EzzCFr8B?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3a2665f9-241c-4268-d8e2-08d98ee9d769
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2021 08:08:44.3457
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jsId+KFAMD8OM7HVc5q6g45O+VGf6E2vh0BGGgCKlOt662tIFxCH2zwG8oQLifcJ0Kyce/TdZCdi/0FuVxRBkA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2448

On 24.08.2021 12:50, Anthony PERARD wrote:
> Temporary fix the list of headers that cmdline.c and reloc.c depends
> on, until the next time the list is out of sync again.
> 
> Also, add the linker script to the list.
> 
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>

Reviewed-by: Jan Beulich <jbeulich@suse.com>

Afaict this is independent of all earlier patches, so I'll make an
attempt at committing this soon.

> --- a/xen/arch/x86/boot/Makefile
> +++ b/xen/arch/x86/boot/Makefile
> @@ -2,19 +2,22 @@ obj-bin-y += head.o
>  
>  DEFS_H_DEPS = $(BASEDIR)/$(src)/defs.h $(BASEDIR)/include/xen/stdbool.h
>  
> -CMDLINE_DEPS = $(DEFS_H_DEPS) $(BASEDIR)/$(src)/video.h
> +CMDLINE_DEPS = $(DEFS_H_DEPS) $(BASEDIR)/$(src)/video.h \
> +	       $(BASEDIR)/include/xen/kconfig.h \
> +	       $(BASEDIR)/include/generated/autoconf.h

Especially with this now needed in two places, I think down the road
(unless we'll get dependency tracking automated here, which a part of
your description suggests is not going to happen soon) we want

kconfig.h := $(BASEDIR)/include/xen/kconfig.h \
             $(BASEDIR)/include/generated/autoconf.h

and then similarly ...

>  RELOC_DEPS = $(DEFS_H_DEPS) \
>  	     $(BASEDIR)/include/generated/autoconf.h \
>  	     $(BASEDIR)/include/xen/kconfig.h \
>  	     $(BASEDIR)/include/xen/multiboot.h \
>  	     $(BASEDIR)/include/xen/multiboot2.h \
> +	     $(BASEDIR)/include/xen/const.h \

multiboot.h := $(BASEDIR)/include/xen/multiboot.h \
               $(BASEDIR)/include/xen/const.h \

(and by implication I think DEFS_H_DEPS would better be renamed to
deps.h as well).

Jan



From xen-devel-bounces@lists.xenproject.org Thu Oct 14 08:32:30 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Oct 2021 08:32:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.209072.365408 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maw9v-0006wT-A6; Thu, 14 Oct 2021 08:32:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 209072.365408; Thu, 14 Oct 2021 08:32:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maw9v-0006wM-5m; Thu, 14 Oct 2021 08:32:15 +0000
Received: by outflank-mailman (input) for mailman id 209072;
 Thu, 14 Oct 2021 08:32:13 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Xl23=PC=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1maw9t-0006wG-Hn
 for xen-devel@lists.xenproject.org; Thu, 14 Oct 2021 08:32:13 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 39985ca2-2cc9-11ec-81b5-12813bfff9fa;
 Thu, 14 Oct 2021 08:32:11 +0000 (UTC)
Received: from EUR01-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur01lp2052.outbound.protection.outlook.com [104.47.1.52]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-24-VFDt4exlNDuEJrMwTN_zeQ-1; Thu, 14 Oct 2021 10:32:09 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB6301.eurprd04.prod.outlook.com (2603:10a6:803:f1::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.21; Thu, 14 Oct
 2021 08:32:08 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.016; Thu, 14 Oct 2021
 08:32:07 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS9PR04CA0055.eurprd04.prod.outlook.com (2603:10a6:20b:46a::11) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16 via Frontend
 Transport; Thu, 14 Oct 2021 08:32:07 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 39985ca2-2cc9-11ec-81b5-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634200330;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=z43p2Ltsw1hT3c2nivnepNJi1ZV1Za1fMWgGQFYRb9s=;
	b=Ved+S5Vkp5F42LhlZmJYaNw3NhlR6ABemnD43Sp9QwwfX9dWxpyhjUU9C7xrs94mY46ggz
	uTCbzYJY7Ga3We7ZZkB4Ijnt7f1J+d16UX7fEDMFMrf0BmmmlkqxvgNK2cugrEIF+E4wZ7
	13Lzv+gcLeABMYP7ZHRVd2NkFbTi85k=
X-MC-Unique: VFDt4exlNDuEJrMwTN_zeQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=mnSKOQGM7EmfQjHGw8jPCnuKGGXB/cfFHGtJJEi1jpH+ux3yP+ZHFOpxoIvRyhiCIdcZ6nC39SHDW+M9GYpSRyBW72/+njvvOdj6YbnYnJwYe/c6xWEYJELfUSRTHVdVZMc59LYrunCLCcx/+9lYdciezQvW2Bmz+fqHwlx50thoxAo45bg7NgXOKR/aPcaGHBnoChQEIeE4YjDQn9QGukKSeVeKYlpNNx5Tw5nkPEQNCQkERW6Vuc6bkrpoXHflotARmVGPu0pSS0ihIwFinC7Wu+y+z8wc7MwaAKUXLxEZQQWkxxxRgh+4EXab+596GpIgDvWi2BIyjQdspwGv/A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=z43p2Ltsw1hT3c2nivnepNJi1ZV1Za1fMWgGQFYRb9s=;
 b=MgxXAtQnRpALbHjqQKHt5RlId0+ql+VJWmg3/TYwAZqPD4cocyFMiLyUcEhVtrycOy+P+/yAgRmzLS/VXBWb+1Ro+RsdmT8sxKsuYGgJzxZegA0SsiGpIKlQfqw6rAAhAI+7Co781cpPtK3NF/SV6btmTM5MWn55sgAAHfA5nJtJMyfZy6itGKwH8mSkij83F1S1NVQqiPitKhbaVSRtUWFdwltMI51sU14pPKy5vTwK7/K4I9afHJYW02Mc66a4q6kbKVMyc9zdP1iDAUsKz0+oMMhp0g/e4xOrHpp8vChRu51byJw3t4cFH4IUURPs+YaAiEuxmjA9CGKfzHIkgg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [XEN PATCH v7 41/51] build,x86: remove the need for build32.mk
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>, Wei Liu
 <wl@xen.org>, xen-devel@lists.xenproject.org
References: <20210824105038.1257926-1-anthony.perard@citrix.com>
 <20210824105038.1257926-42-anthony.perard@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <c99f2bc5-b1dc-7647-4199-a6a731730967@suse.com>
Date: Thu, 14 Oct 2021 10:32:05 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <20210824105038.1257926-42-anthony.perard@citrix.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR04CA0055.eurprd04.prod.outlook.com
 (2603:10a6:20b:46a::11) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: d6d2244f-4a45-4116-c346-08d98eed1bf4
X-MS-TrafficTypeDiagnostic: VI1PR04MB6301:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB63019D88BA681484EFAD36D0B3B89@VI1PR04MB6301.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:3826;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	1ylwFPJj/dDt7mzNFbY/XTH7uJAcZYDo6laLaFrvrv9boVKJLEojr+7zQZ74yykR/zAOmKm9wbya2BD1+BUWT4wnKqoq66ay25kO+/XuzXGQ/d41TywYn+FZEipKCZtc2oqK+lg6KH06lRyvnJwA9Jqdv6t00Bqd9IjYprqKyRlcASZdhQDbRDCLYKK5LXbL9xJf5G9pb+VubOG6E6+DY1Df+T17ZDeLDjsKwV0Y6DnWh77Kdw3lgdJuK0zBpT/lp2O2KYu40wVOM1G/rAQNgJwAa/Tdx4x+lnsnXxZBNhR5lrSQefBs3XU0xilm9szz5BWfgt+Kz9b1owA/rx32TZxrwfMMIp2FMGm8OBs73jiyg6XmMonX5hlUCbCSwWLWRqNtvdhEKe44vIuL54Rqf4azHkIAyRvH7nfNz6yvxGI4G3PCecGqaYT/83UJDUHQO3fAC3mHzXnfvzwN8rOE+Ok/mm0mOas1FRr81OyTWqnG2P2aLPJX5nirDymHUSTeojPzj1yoAMd/UcgjHDhFF3Oom5ROtFozTG3J9wLJnnDjyUbx0DA35ttUZU+NlBv3X/raQxgWqT1codxO2yhapbyImkvNJIdGHfxxaapeiQs2MZBs1fvhahgNstIpcpVTpk43eN6IYDjgmnSsDmYQCjXrm7PwQ4S1fDiGhnr1UQPNJPr54Cj7zrWlZ/ACwyfmnfQvxIURDfp0f2FSgLMyeAneeAidS+V543w9SXwMzAIJhg54uU/VnpbhHw9KTtwY
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(5660300002)(4326008)(956004)(186003)(31696002)(2906002)(54906003)(86362001)(36756003)(38100700002)(508600001)(31686004)(16576012)(316002)(66946007)(66476007)(6916009)(8676002)(66556008)(26005)(53546011)(2616005)(6486002)(8936002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?R3o0Tjd4b0RQaCtkbzZENG9pWCtHNno1ejZVam5SQW9VOWhMN1BLTWgydDNt?=
 =?utf-8?B?enJsQjNweEt4N1gramRoTmRtK2w0UTd3cGl5Y2NEK1VIaWdoaURaeTN6aXVG?=
 =?utf-8?B?TjVpai9BcFc2MC9yLytpRXBiYkhGWkRyZmNUOWRwOStRVng4ZlBHWmhqTEx3?=
 =?utf-8?B?aEk3VzQ0RmpuZVRpbkd1a3RVL1RoQVlacGxGcVpCMHlQWVFNT25RWG1YdUxj?=
 =?utf-8?B?ak5OUEs4U0p2TEFjek5Wc0dva3IzZ3dYK25sWUxiZ0UwYWg4YlQ3alhZUGxy?=
 =?utf-8?B?cXk4aEVFSlRwQnFPNXJ2MUZJMVlCdlNBWVBhOU0xOXBYWWZJMy9Oam9hWVJ2?=
 =?utf-8?B?MXc2a3hnQWFReTM2N1liZjZCbVZjS21XcEpSQ3B3c1VzcjdWRGZnSVVvV2hi?=
 =?utf-8?B?WjZmbzM5TitrVEhlNTl2Mkx0MVVRdXN3NVBybmJ5YWdqcHB3YmhHd01HUm1r?=
 =?utf-8?B?T1diVWlGZld5MU5kLzNvL1JRNURNam04dkJCUVg3d3dHTyt6cSszekU3REZ6?=
 =?utf-8?B?SkN2T3Z0Q1NOUjVkb1FVYjBCc2FhZWMvUTNmYWZrelI2Z3lJMm1RRG1QZUFn?=
 =?utf-8?B?SUJLVFhHeEQ1WHc1cTI3MFpVYWErUXpzTVVOTXo4TkJFa2czb1h4NFRGUUJB?=
 =?utf-8?B?ODhIVnNmZ3hyVThab3dyNWlvNXQ1cER1WWJGZ3NLcHhsWEtVdkZQL210TVhZ?=
 =?utf-8?B?Z2NoeU1FRXhPT2ZpMnh0ZHgySmdObG1HekZkTC8zOHdGam9JVHIrSnFmck1T?=
 =?utf-8?B?RzBlbE5qNStvWFgwRnQvTzhQV1JucDg0c25GSXBEcGtLOUZyN3VEUnd2eGlS?=
 =?utf-8?B?T1ZYRU51alQ2TE5ibDF5ZTVtZ0p2VnRkRzVMSkE2ZVp6M1dqYW5wcXptcXN4?=
 =?utf-8?B?MlBsbFdzRGZ2dmZvb2FlYUFUU3JNdDVjK0FyOW9JdXNwUDd4MndSK01yejYv?=
 =?utf-8?B?Z2xFWDhRM0RVQkhsQUZveWlIdHAySVQyRzlZMTloaVNkWDNjRXd3QzZ1NVh3?=
 =?utf-8?B?VUg0aGdmRDA3cmo2c2tNeW91Y3BFcFd4WjUxUEZjZFZVZUEvYTZVdlFNMVRw?=
 =?utf-8?B?RGU2bS9Wamc1c0JpWGFMUGpwdWF6UUxFM2hEbXVVbzZ6cFdyUW9OamdjQjh1?=
 =?utf-8?B?eGlFREZYNEFlZi8xeklGN215Ris1Mm0zQ1A0bWgvQ0orSTRMam01ekUydno5?=
 =?utf-8?B?cnRSMEJmc2Z0SWp4T0F4VzY2N2x1UkswQk1HSGxLNERNS1VadnBBaThaK2Rw?=
 =?utf-8?B?bEk5MlExWURtb2QrRmEvSVlpMTI2Znk2bWVMNGFycHRzOWFPeHJqclVLSUJ2?=
 =?utf-8?B?QWcrV29jcm9TWElmMnRXTVRWWkRBNFBNNzh0SnNaV01CZkxqZ3pxb3ljT0pD?=
 =?utf-8?B?S24yT29MMHFUdDN1ZStqbVB4b1FmUDVFN3dGTXdTL05FUGZ2WU5KQTFBQUlM?=
 =?utf-8?B?eFJSa0p3NUxiV0VOTENQY3lTODRFejdtZXNuZTA2SCtxb1FjOUlVN2tkeWdn?=
 =?utf-8?B?WHF0eUVrMkpGQnNxckNjaUJNSFRIQ1EwZmsvNFhnVCtnMEJwbmVmejB2RFJ5?=
 =?utf-8?B?SG5HU2pKOVUvbjArUTJCWnFPMjgreTVxdnBacm5wbllLVjZXaFNpaUxDcE10?=
 =?utf-8?B?aS9BeVQ3dHJLQWwvWlR5clcxaklOeGE0MnNudU1oREt5Uk91emVScmd4bStI?=
 =?utf-8?B?dndmYlNsaTFMc054NU9panVGYmUwdWNMbTRDaDhSYWRxUm1xNjNqblkyVHNW?=
 =?utf-8?Q?imx5MmwW8m3Nc6FHv74OpQjwhDVaPEc9rt4V/QK?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d6d2244f-4a45-4116-c346-08d98eed1bf4
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2021 08:32:07.8344
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: o9AMAi5WqOIUd83Gd46pvGdVR6Mv+AcaRuf41Tux1mfccLMGuBGKQ7zNZZYZI75W/QqjjmeXNs+++3yNxEfxYQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6301

On 24.08.2021 12:50, Anthony PERARD wrote:
> --- a/xen/arch/x86/boot/Makefile
> +++ b/xen/arch/x86/boot/Makefile
> @@ -1,23 +1,51 @@
>  obj-bin-y += head.o
> +head-objs := cmdline.S reloc.S
>  
> -DEFS_H_DEPS = $(BASEDIR)/$(src)/defs.h $(BASEDIR)/include/xen/stdbool.h
> +nocov-y += $(head-objs:.S=.o)
> +noubsan-y += $(head-objs:.S=.o)
> +targets += $(head-objs:.S=.o)

This working right depends on targets initially getting set with := ,
because of ...

> -CMDLINE_DEPS = $(DEFS_H_DEPS) $(BASEDIR)/$(src)/video.h \
> -	       $(BASEDIR)/include/xen/kconfig.h \
> -	       $(BASEDIR)/include/generated/autoconf.h
> +head-objs := $(addprefix $(obj)/, $(head-objs))

... this subsequent adjustment to the variable. Might it be more future
proof for start with

head-srcs := cmdline.S reloc.S

and then derive head-objs only here?

> -RELOC_DEPS = $(DEFS_H_DEPS) \
> -	     $(BASEDIR)/include/generated/autoconf.h \
> -	     $(BASEDIR)/include/xen/kconfig.h \
> -	     $(BASEDIR)/include/xen/multiboot.h \
> -	     $(BASEDIR)/include/xen/multiboot2.h \
> -	     $(BASEDIR)/include/xen/const.h \
> -	     $(BASEDIR)/include/public/arch-x86/hvm/start_info.h
> +$(obj)/head.o: $(head-objs)
>  
> -$(obj)/head.o: $(obj)/cmdline.S $(obj)/reloc.S
> +LDFLAGS_DIRECT_OpenBSD = _obsd
> +LDFLAGS_DIRECT_FreeBSD = _fbsd

This is somewhat ugly - it means needing to change things in two places
when config/x86_32.mk would change (e.g. to add another build OS). How
about ...

> +$(head-objs:.S=.lnk): LDFLAGS_DIRECT := -melf_i386$(LDFLAGS_DIRECT_$(XEN_OS))

... instead:

$(head-objs:.S=.lnk): LDFLAGS_DIRECT := $(subst x86_64,i386,$(LDFLAGS_DIRECT))

? Or if deemed still too broad

$(head-objs:.S=.lnk): LDFLAGS_DIRECT := $(subst elf_x86_64,elf_i386,$(LDFLAGS_DIRECT))

?

> -$(obj)/cmdline.S: $(src)/cmdline.c $(CMDLINE_DEPS) $(src)/build32.lds
> -	$(MAKE) -f $(BASEDIR)/$(src)/build32.mk -C $(obj) $(@F) CMDLINE_DEPS="$(CMDLINE_DEPS)"
> +CFLAGS_x86_32 := -m32 -march=i686
> +CFLAGS_x86_32 += -fno-strict-aliasing
> +CFLAGS_x86_32 += -std=gnu99
> +CFLAGS_x86_32 += -Wall -Wstrict-prototypes
> +$(call cc-option-add,CFLAGS_x86_32,CC,-Wdeclaration-after-statement)
> +$(call cc-option-add,CFLAGS_x86_32,CC,-Wno-unused-but-set-variable)
> +$(call cc-option-add,CFLAGS_x86_32,CC,-Wno-unused-local-typedefs)
> +$(call cc-options-add,CFLAGS_x86_32,CC,$(EMBEDDED_EXTRA_CFLAGS))
> +CFLAGS_x86_32 += -Werror -fno-builtin -g0 -msoft-float
> +CFLAGS_x86_32 += -I$(srctree)/include

I'm afraid I'm not convinced that having to keep this in sync with the
original is in fair balance with the removal of build32.mk.

Jan



From xen-devel-bounces@lists.xenproject.org Thu Oct 14 08:40:13 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Oct 2021 08:40:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.209080.365419 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mawHZ-0008LD-1y; Thu, 14 Oct 2021 08:40:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 209080.365419; Thu, 14 Oct 2021 08:40:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mawHY-0008L6-Uy; Thu, 14 Oct 2021 08:40:08 +0000
Received: by outflank-mailman (input) for mailman id 209080;
 Thu, 14 Oct 2021 08:40:07 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=/nGJ=PC=gmail.com=ysaikiran1997@srs-us1.protection.inumbo.net>)
 id 1mawHX-0008L0-Fz
 for xen-devel@lists.xenproject.org; Thu, 14 Oct 2021 08:40:07 +0000
Received: from mail-yb1-xb36.google.com (unknown [2607:f8b0:4864:20::b36])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 22bb5427-aed9-456e-912d-4b6dc3dbc337;
 Thu, 14 Oct 2021 08:40:05 +0000 (UTC)
Received: by mail-yb1-xb36.google.com with SMTP id a7so12861473yba.6
 for <xen-devel@lists.xenproject.org>; Thu, 14 Oct 2021 01:40:05 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 22bb5427-aed9-456e-912d-4b6dc3dbc337
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=YtsxOh8d/WhChlp/Vvmhv2Ybki6Kg8BaVdg7lTTh+N8=;
        b=Tj+FQMSG+GZVtyd3QFOcXtBpXk/G1ujmuIB98ex5YBgU4eUrOwszi6e/AAAKYnOyBR
         z/78gOBlrcP0BHv12xAhEz3IXw2xVwmt9KnBRMPYhAfRZGe9g9d4UyAGBMBibuoab1K+
         pHeSPuV/FdoK7eluEN9eUP0tg4j4K/N5lV2yZgO8KA+HqZWk4w5fhHsI/pXw3RkOiTHT
         4tQ7t8IxUkEEEIaumuhTcvhFyCFu4wicmmucCyi8AKcmhK2uPzrJArNYJFoDFMkxCcva
         b5SMB5DnrUqLbL2+plArdIcSB+OzTye7hIZ7PR5IEq8bFxy8Gv/ut7n5/SLKmZMDD5dm
         dgmg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=YtsxOh8d/WhChlp/Vvmhv2Ybki6Kg8BaVdg7lTTh+N8=;
        b=6HeG2tDqm+Nx8ew/NV1XnWtDiP1Wg7cdIjiCeHbpv+nu3Erw5Se9242F4csLrUz9me
         Gh/OW4w53Wq8h/6jPoM0MN27sFlCkz1j9DrXL0dsajGALTAvXHtZ9bHW9c6IkQEVQ5Dd
         qr09iyA6TuDTklec4VwDP2gZHzo3OHFXtuoMODsMPR1KZuuV3nIOQ+SU0OdV6j4nIX8k
         O/sI3mhzLYUs7/XgQHBDljKaRGTXI3P4LWf/542ZqrLqnM/bjSzTr2D19iynq+hv/o7/
         pbXC6e1m3yTECekdhBOLPUGKnfh9OIoUEXUoXz9XJH90cFhFnryAnQ/lPhZCJvOrDEA7
         ZLYA==
X-Gm-Message-State: AOAM533rSqPMr5SvZsd6ij4qZYXa2RASaZqW4jJBv4tBzIQ/WHJw1itC
	++6n16JPz0hPSK4R0U5ueNUV384hlMSjFBm/Mak=
X-Google-Smtp-Source: ABdhPJzsuAqoULsbim9Nm8wel/diGFhLbhy00aMM3CQFw4dkK+DgajGeRhLXciFVC67idXlDXvV/75JLywC5ZdpMfkc=
X-Received: by 2002:a25:2610:: with SMTP id m16mr4792175ybm.508.1634200805017;
 Thu, 14 Oct 2021 01:40:05 -0700 (PDT)
MIME-Version: 1.0
References: <33C29853-D896-4E4E-91D3-4D2FA89A9B91@hxcore.ol>
 <eb5fd47b-6bc9-2eec-7f46-9ab9a42c9f1f@xen.org> <CAEsO4uzsCnsTtTmYHAT4NN6=girCY2NHHdAHbH6GG33D7jwe_A@mail.gmail.com>
 <alpine.DEB.2.21.2109131437030.10523@sstabellini-ThinkPad-T480s>
 <CAEsO4uwpiDO2QoqLRTOxpsYM9YSPAsbX0P=gagdEy21pk1VsPQ@mail.gmail.com>
 <alpine.DEB.2.21.2109141825330.21985@sstabellini-ThinkPad-T480s>
 <CAEsO4uyjNs97Cx8n2owDk4kKTVCycji377pm7aXHcPWzeszUTw@mail.gmail.com>
 <alpine.DEB.2.21.2109301942370.3209@sstabellini-ThinkPad-T480s>
 <CAEsO4ux_AqXBeCtbwnPAdnBnVYHTur_2EfcZBTuN4QKCq4ko8Q@mail.gmail.com> <alpine.DEB.2.21.2110131711280.9408@sstabellini-ThinkPad-T480s>
In-Reply-To: <alpine.DEB.2.21.2110131711280.9408@sstabellini-ThinkPad-T480s>
From: Sai Kiran Kumar Reddy Y <ysaikiran1997@gmail.com>
Date: Thu, 14 Oct 2021 14:09:53 +0530
Message-ID: <CAEsO4uxo_A4pEwP6dHK8kvYtKcbSr-ewqX1v-KLsEkyHNLFyUA@mail.gmail.com>
Subject: Re: Xen Booting Problem on ARM Machine
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: Julien Grall <julien@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>, 
	Jan Beulich <jbeulich@suse.com>, Luca Fancellu <luca.fancellu@arm.com>, 
	xen-devel@lists.xenproject.org, kannan@cimware.in
Content-Type: multipart/alternative; boundary="000000000000798b7005ce4c0616"

--000000000000798b7005ce4c0616
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, Oct 14, 2021 at 5:45 AM Stefano Stabellini <sstabellini@kernel.org>
wrote:

> On Wed, 13 Oct 2021, Sai Kiran Kumar Reddy Y wrote:
> > On Fri, Oct 1, 2021 at 8:17 AM Stefano Stabellini <
> sstabellini@kernel.org> wrote:
> >       Yes there are other ways but without serial is going to be
> difficult
> >       because you are not going to see anything until everything works.
> >
> >       How do you boot Xen and Dom0 exactly from EDK2? Are you using GRU=
B
> or
> >       loading Xen directly from the EDK2 prompt? Please provide as many
> >       details as possible so that I might be able to spot any errors.
> >
> > I am using GRUB to load Xen. In the GRUB menu, I see two options.
> > Option 1: Debian 11 with latest Linux Kernel
> > Option 2: Debian 11(with Xen hypervisor) with latest Kernel
> >
> >       Can you provide the Device Tree you are using? If you are not
> passing
> >       any Device Tree  binary explicitely, then it might be passed
> >       automatically from EDK2 to Linux/Xen. In that case, just boot fro=
m
> Linux
> >       then do the following to retrieve the Device Tree:
> >
> >       dtc -I fs -O dts /proc/device-tree > host.dts
> >
> >       Then please attach host.dts to this email thread.
> >
> > Yeah, you are right. It looks like LInux is booting from ACPI. In the
> bootloader menu, "Automatic ACPI configuration" is disabled. So, I
> > thought that Linux may be booting from Device Tree. I have tried the
> "dtc" command you mentioned. But it looks like there's no device-tree
> > under "/proc". I also tried to get DT info, from
> "/sys/firmware/devicetree/base" . But, there's no info. under devicetree
> folder. I am not
> > quite sure how to get the DT info, if the Linux is booting from ACPI. I
> am attaching .dsl files, that contain the acpi info.
>
> OK, so it is pretty clear that even if "Automatic ACPI configuration" is
> disabled, it is still booting with ACPI.
>
>
> >       Also for your information it looks like Linux actually booted fro=
m
> ACPI,
> >       not from Device Tree, as you can see from all the "ACPI" messages
> in the
> >       kernel logs.
> >
> >       If you need to boot from ACPI, then you need to enable ACPI
> support in
> >       Xen, which is disabled by default. You can do that using make
> >       menuconfig.
> >
> > In the make menuconfig of Xen, I do not see any option to enable ACPI.
>
> You definitely need to enable ACPI support in Xen, if you are booting
> from ACPI, otherwise nothing is going to work.
>
> On the latest staging (https://gitlab.com/xen-project/xen) you can
> enable ACPI as follows:
>
>
> # export CROSS_COMPILE=3D/path/to/cross-compiler
> # export XEN_TARGET_ARCH=3Darm64
> # cd xen.git/xen
> # make menuconfig
> #   --> Configure UNSUPPORTED features
> #   --> Architecture Features --> ACPI
> # make
>

Hi

I got the code from Gitlab and installed it, enabling ACPI support in Xen.
As I reboot the system, I am able to see 2 options like before.
Option 1: Debian with latest kernel
Option 2 : Debian with Xen

I have selected Option 2. I did not see any bootinfo membanks error.
However, there is the following error in GRUB(just for a fraction of a
second).

"Using modules provided by boot loader in FDT
  Xen 4.16-unstable (c/s Wed Oct 13 13 13:28:43 2021 -0700 git:4cfab4425d)
EFI Loader
  Couldn't obtain the File System Protocol Interface: ErrCode:
0x8000000000000002"

I have enabled earlyprintk. I do not see any messages in the Serial. There
seems to be some problem with the gitlab version of Xen.



> Cheers,
>
> Stefano
>
>
> >       On Thu, 30 Sep 2021, Sai Kiran Kumar Reddy Y wrote:
> >       > Hi,
> >       > Sorry about the delay. We have been trying to access the serial
> of the machine. Tried with couple of JTAG connectors. There's
> >       still no
> >       > debug messages on the serial. Is there any other way of figurin=
g
> this out?
> >       >
> >       > On Wed, Sep 15, 2021, 7:02 AM Stefano Stabellini <
> sstabellini@kernel.org> wrote:
> >       >       Something is off. When you enabled earlyprintk in Xen, yo=
u
> should see
> >       >       something like this at boot time:
> >       >       https://marc.info/?l=3Dxen-devel&m=3D158829968025334
> >       >
> >       >       All the Xen logs starting with "(XEN)" on the serial. Do
> you have access
> >       >       to the serial of the machine? Without it, it is going to
> be hard to
> >       >       debug.
> >       >
> >       >
> >       >       On Tue, 14 Sep 2021, Sai Kiran Kumar Reddy Y wrote:
> >       >       > In the folder "/var/log", there's a file called "xen",
> which is empty. As far as the boot logs are concerned, I don't
> >       see any
> >       >       debug
> >       >       > messages related to xen. I am attaching the log files,
> "kern.txt" and "boot.txt"
> >       >       >
> >       >       > On Tue, Sep 14, 2021 at 3:08 AM Stefano Stabellini <
> sstabellini@kernel.org> wrote:
> >       >       >       On Mon, 13 Sep 2021, Sai Kiran Kumar Reddy Y wrot=
e:
> >       >       >       > On Fri, Sep 10, 2021 at 7:30 PM Julien Grall <
> julien@xen.org> wrote:
> >       >       >       >
> >       >       >       >
> >       >       >       >       On 08/09/2021 11:43, Sai Kiran wrote:
> >       >       >       >       > Hello,
> >       >       >       >
> >       >       >       >       Hi,
> >       >       >       >
> >       >       >       >       Thank you for the report. Moving the
> discussion back to xen-devel
> >       >       >       >       because this looks like a potential issue
> in the UEFI stub in Xen.
> >       >       >       >
> >       >       >       >       > I have Xen-4.15.0 on an ARM Machine,
> with Debian 11 installed on it.
> >       >       >       >
> >       >       >       >       Would you be able to give more details on
> the Arm machine you are using?
> >       >       >       >       Also, are you using ACPI or DT to boot?
> >       >       >       >
> >       >       >       >
> >       >       >       >    Sai >> DT . ACPI configuration is disabled i=
n
> Boot settings
> >       >       >       >
> >       >       >       >       >  I
> >       >       >       >       > am able to do =E2=80=9Cmake world=E2=80=
=9D and =E2=80=9Cmake
> install=E2=80=9D, after =E2=80=9C./configure=E2=80=9D, as
> >       >       >       >       > specified in README file. When I reboot
> the system, I get the following
> >       >       >       >       > message:
> >       >       >       >       >
> >       >       >       >       > Warning: All 128 bootinfo mem banks
> exhausted.
> >       >       >       >       >
> >       >       >       >       > Warning: All 128 bootinfo mem banks
> exhausted.
> >       >       >       >
> >       >       >       >       Hmmm... This means that you have more tha=
n
> 128 memory regions described
> >       >       >       >       in the EFI memory map. That's quite a lot=
.
> >       >       >       >
> >       >       >       >       Although, this should be harmless as it
> means Xen will not use the extra
> >       >       >       >       memory banks.
> >       >       >       >
> >       >       >       >       >
> >       >       >       >       > Cannot exit boot services: ErrCode:
> 0x8000000000000002
> >       >       >       >
> >       >       >       >       This means EFI_INVALID_PARAMETER. We have
> code to retry because AFAICT
> >       >       >       >       ExitBootServices() may sometime fails (I
> have CCed Jan may have more
> >       >       >       >       idea what's happening).
> >       >       >       >
> >       >       >       >       Would you be able to provide more details
> on the UEFI firmware you are
> >       >       >       >       using? Is it EDK2 or U-boot?
> >       >       >       >
> >       >       >       > Sai >>  EDK2
> >       >       >       >       Also, do you know if Linux is boot on the
> same system?
> >       >       >       >
> >       >       >       > Sai >> Yes
> >       >       >       >       However, AFAICT, the error message would
> not prevent Xen to continue
> >       >       >       >       booting. So you may get stuck later in th=
e
> boot process.
> >       >       >       >
> >       >       >       >       My suggestion would be to enable
> earlyprintk for your platform. You can
> >       >       >       >       setup it up from the menuconfig in
> "Debugging Options".
> >       >       >       >
> >       >       >       > Sai >> Yes, I have enabled earlyprintk.
> >       >       >       > I tried changing NR_MEM_BANKS(in
> xen/include/asm-arm/setup.h) value to 256, from 128. The error message is=
 no
> >       longer
> >       >       seen,
> >       >       >       but the device
> >       >       >       > is stuck in the boot process.
> >       >       >
> >       >       >       Could you please post the boot logs now that you
> enabled earlyprintk?
> >       >       >       Ideally not a camera picture but a textual
> copy/paste from the target
> >       >       >       serial?
> >       >       >
> >       >       >       Earlyprintk is pretty verbose, we should be able
> to figure out where it
> >       >       >       gets stuck.
> >       >       >
> >       >       >
> >       >       >
> >       >
> >       >
> >       >
> >
> >
> >


Thanks & Regards,
Sai Kiran.

--000000000000798b7005ce4c0616
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote">=
<div dir=3D"ltr" class=3D"gmail_attr">On Thu, Oct 14, 2021 at 5:45 AM Stefa=
no Stabellini &lt;<a href=3D"mailto:sstabellini@kernel.org">sstabellini@ker=
nel.org</a>&gt; wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"=
margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-lef=
t:1ex">On Wed, 13 Oct 2021, Sai Kiran Kumar Reddy Y wrote:<br>
&gt; On Fri, Oct 1, 2021 at 8:17 AM Stefano Stabellini &lt;<a href=3D"mailt=
o:sstabellini@kernel.org" target=3D"_blank">sstabellini@kernel.org</a>&gt; =
wrote:<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0Yes there are other ways but without serial =
is going to be difficult<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0because you are not going to see anything un=
til everything works.<br>
&gt; <br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0How do you boot Xen and Dom0 exactly from ED=
K2? Are you using GRUB or<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0loading Xen directly from the EDK2 prompt? P=
lease provide as many<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0details as possible so that I might be able =
to spot any errors.<br>
&gt; <br>
&gt; I am using GRUB to load Xen. In the GRUB menu, I see two options.=C2=
=A0<br>
&gt; Option 1: Debian 11 with latest Linux Kernel<br>
&gt; Option 2: Debian 11(with Xen hypervisor) with latest Kernel<br>
&gt; =C2=A0<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0Can you provide the Device Tree you are usin=
g? If you are not passing<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0any Device Tree=C2=A0 binary explicitely, th=
en it might be passed<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0automatically from EDK2 to Linux/Xen. In tha=
t case, just boot from Linux<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0then do the following to retrieve the Device=
 Tree:<br>
&gt; <br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0dtc -I fs -O dts /proc/device-tree &gt; host=
.dts<br>
&gt; <br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0Then please attach host.dts to this email th=
read.<br>
&gt; <br>
&gt; Yeah, you are right. It looks like LInux is booting from ACPI. In the =
bootloader menu, &quot;Automatic ACPI configuration&quot; is disabled. So, =
I<br>
&gt; thought that Linux may be booting from Device Tree. I have tried the &=
quot;dtc&quot; command you mentioned. But it looks like there&#39;s no devi=
ce-tree<br>
&gt; under &quot;/proc&quot;. I also tried to get DT info, from &quot;/sys/=
firmware/devicetree/base&quot; . But, there&#39;s no info. under devicetree=
 folder. I am not<br>
&gt; quite sure how to get the DT info, if the Linux is booting from ACPI. =
I am attaching .dsl files, that contain the acpi info.<br>
<br>
OK, so it is pretty clear that even if &quot;Automatic ACPI configuration&q=
uot; is<br>
disabled, it is still booting with ACPI.<br>
<br>
<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0Also for your information it looks like Linu=
x actually booted from ACPI,<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0not from Device Tree, as you can see from al=
l the &quot;ACPI&quot; messages in the<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0kernel logs.<br>
&gt; <br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0If you need to boot from ACPI, then you need=
 to enable ACPI support in<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0Xen, which is disabled by default. You can d=
o that using make<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0menuconfig.<br>
&gt; <br>
&gt; In the make menuconfig of Xen, I do not see any option to enable ACPI.=
=C2=A0=C2=A0<br>
<br>
You definitely need to enable ACPI support in Xen, if you are booting<br>
from ACPI, otherwise nothing is going to work.<br>
<br>
On the latest staging (<a href=3D"https://gitlab.com/xen-project/xen" rel=
=3D"noreferrer" target=3D"_blank">https://gitlab.com/xen-project/xen</a>) y=
ou can<br>
enable ACPI as follows:<br>
<br>
<br>
# export CROSS_COMPILE=3D/path/to/cross-compiler<br>
# export XEN_TARGET_ARCH=3Darm64<br>
# cd xen.git/xen<br>
# make menuconfig<br>
#=C2=A0 =C2=A0--&gt; Configure UNSUPPORTED features<br>
#=C2=A0 =C2=A0--&gt; Architecture Features --&gt; ACPI<br>
# make<br></blockquote><div><br></div><div>Hi</div><div><br></div><div>I go=
t the code from Gitlab and installed it, enabling ACPI support in Xen. As I=
 reboot the system, I am able to see 2 options like before.=C2=A0</div><div=
>Option 1: Debian with latest kernel</div><div>Option 2 : Debian with Xen</=
div><div><br></div><div>I have selected Option 2. I did not see any bootinf=
o membanks=C2=A0error. However, there is the following error in GRUB(just f=
or a fraction of a second).=C2=A0</div><div><br></div><div>&quot;Using modu=
les provided by boot loader in FDT</div><div>=C2=A0 Xen 4.16-unstable (c/s =
Wed Oct 13 13 13:28:43 2021 -0700 git:4cfab4425d) EFI Loader</div><div>=C2=
=A0 Couldn&#39;t obtain the File System Protocol Interface: ErrCode: 0x8000=
000000000002&quot;</div><div><br></div><div>I have enabled earlyprintk. I d=
o not see any messages in the Serial. There seems to be some problem with t=
he gitlab version of Xen.</div><div><br></div><div><br></div><blockquote cl=
ass=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid=
 rgb(204,204,204);padding-left:1ex">
<br>
Cheers,<br>
<br>
Stefano<br>
<br>
<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0On Thu, 30 Sep 2021, Sai Kiran Kumar Reddy Y=
 wrote:<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt; Hi,<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt; Sorry about the delay. We have been try=
ing to access the serial of the machine. Tried with couple of JTAG connecto=
rs. There&#39;s<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0still no<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt; debug messages on the serial. Is there =
any other way of figuring this out?<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt; On Wed, Sep 15, 2021, 7:02 AM Stefano S=
tabellini &lt;<a href=3D"mailto:sstabellini@kernel.org" target=3D"_blank">s=
stabellini@kernel.org</a>&gt; wrote:<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0Something is =
off. When you enabled earlyprintk in Xen, you should see<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0something lik=
e this at boot time:<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0<a href=3D"ht=
tps://marc.info/?l=3Dxen-devel&amp;m=3D158829968025334" rel=3D"noreferrer" =
target=3D"_blank">https://marc.info/?l=3Dxen-devel&amp;m=3D158829968025334<=
/a><br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0All the Xen l=
ogs starting with &quot;(XEN)&quot; on the serial. Do you have access<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0to the serial=
 of the machine? Without it, it is going to be hard to<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0debug.<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0On Tue, 14 Se=
p 2021, Sai Kiran Kumar Reddy Y wrote:<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt; In the f=
older &quot;/var/log&quot;, there&#39;s a file called &quot;xen&quot;, whic=
h is empty. As far as the boot logs are=C2=A0concerned, I don&#39;t<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0see any<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0debug<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt; messages=
 related to xen. I am attaching the log files, &quot;kern.txt&quot; and &qu=
ot;boot.txt&quot;<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt; On Tue, =
Sep 14, 2021 at 3:08 AM Stefano Stabellini &lt;<a href=3D"mailto:sstabellin=
i@kernel.org" target=3D"_blank">sstabellini@kernel.org</a>&gt; wrote:<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =
=C2=A0 =C2=A0 =C2=A0On Mon, 13 Sep 2021, Sai Kiran Kumar Reddy Y wrote:<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =
=C2=A0 =C2=A0 =C2=A0&gt; On Fri, Sep 10, 2021 at 7:30 PM Julien Grall &lt;<=
a href=3D"mailto:julien@xen.org" target=3D"_blank">julien@xen.org</a>&gt; w=
rote:<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =
=C2=A0 =C2=A0 =C2=A0&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =
=C2=A0 =C2=A0 =C2=A0&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =
=C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0On 08/09/2021 11:43, Sai=
 Kiran wrote:<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =
=C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt; Hello,<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =
=C2=A0 =C2=A0 =C2=A0&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =
=C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0Hi,<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =
=C2=A0 =C2=A0 =C2=A0&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =
=C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0Thank you for the report=
. Moving the discussion back to xen-devel<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =
=C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0because this looks like =
a potential issue in the UEFI stub in Xen.<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =
=C2=A0 =C2=A0 =C2=A0&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =
=C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt; I have Xen-4.15.0 o=
n an ARM Machine, with Debian 11 installed on it.<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =
=C2=A0 =C2=A0 =C2=A0&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =
=C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0Would you be able to giv=
e more details on the Arm machine you are using?<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =
=C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0Also, are you using ACPI=
 or DT to boot?<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =
=C2=A0 =C2=A0 =C2=A0&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =
=C2=A0 =C2=A0 =C2=A0&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =
=C2=A0 =C2=A0 =C2=A0&gt; =C2=A0 =C2=A0Sai &gt;&gt; DT . ACPI configuration =
is disabled in Boot settings=C2=A0 =C2=A0=C2=A0<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =
=C2=A0 =C2=A0 =C2=A0&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =
=C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 I<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =
=C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt; am able to do =E2=
=80=9Cmake world=E2=80=9D and =E2=80=9Cmake install=E2=80=9D, after =E2=80=
=9C./configure=E2=80=9D, as<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =
=C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt; specified in README=
 file. When I reboot the system, I get the following<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =
=C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt; message:<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =
=C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =
=C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt; Warning: All 128 bo=
otinfo mem banks exhausted.<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =
=C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =
=C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt; Warning: All 128 bo=
otinfo mem banks exhausted.<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =
=C2=A0 =C2=A0 =C2=A0&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =
=C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0Hmmm... This means that =
you have more than 128 memory regions described<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =
=C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0in the EFI memory map. T=
hat&#39;s quite a lot.<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =
=C2=A0 =C2=A0 =C2=A0&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =
=C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0Although, this should be=
 harmless as it means Xen will not use the extra<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =
=C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0memory banks.<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =
=C2=A0 =C2=A0 =C2=A0&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =
=C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =
=C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt; Cannot exit boot se=
rvices: ErrCode: 0x8000000000000002<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =
=C2=A0 =C2=A0 =C2=A0&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =
=C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0This means EFI_INVALID_P=
ARAMETER. We have code to retry because AFAICT<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =
=C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0ExitBootServices() may s=
ometime fails (I have CCed Jan may have more<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =
=C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0idea what&#39;s happenin=
g).<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =
=C2=A0 =C2=A0 =C2=A0&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =
=C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0Would you be able to pro=
vide more details on the UEFI firmware you are<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =
=C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0using? Is it EDK2 or U-b=
oot?<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =
=C2=A0 =C2=A0 =C2=A0&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =
=C2=A0 =C2=A0 =C2=A0&gt; Sai &gt;&gt;=C2=A0 EDK2=C2=A0<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =
=C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0Also, do you know if Lin=
ux is boot on the same system?<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =
=C2=A0 =C2=A0 =C2=A0&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =
=C2=A0 =C2=A0 =C2=A0&gt; Sai &gt;&gt; Yes=C2=A0<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =
=C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0However, AFAICT, the err=
or message would not prevent Xen to continue<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =
=C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0booting. So you may get =
stuck later in the boot process.<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =
=C2=A0 =C2=A0 =C2=A0&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =
=C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0My suggestion would be t=
o enable earlyprintk for your platform. You can<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =
=C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0setup it up from the men=
uconfig in &quot;Debugging Options&quot;.<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =
=C2=A0 =C2=A0 =C2=A0&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =
=C2=A0 =C2=A0 =C2=A0&gt; Sai &gt;&gt; Yes, I have enabled earlyprintk.<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =
=C2=A0 =C2=A0 =C2=A0&gt; I tried changing NR_MEM_BANKS(in xen/include/asm-a=
rm/setup.h) value to 256, from 128. The error message is no<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0longer<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0seen,<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =
=C2=A0 =C2=A0 =C2=A0but the device<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =
=C2=A0 =C2=A0 =C2=A0&gt; is stuck in the boot process.<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =
=C2=A0 =C2=A0 =C2=A0Could you please post the boot logs now that you enable=
d earlyprintk?<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =
=C2=A0 =C2=A0 =C2=A0Ideally not a camera picture but a textual copy/paste f=
rom the target<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =
=C2=A0 =C2=A0 =C2=A0serial?<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =
=C2=A0 =C2=A0 =C2=A0Earlyprintk is pretty verbose, we should be able to fig=
ure out where it<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =
=C2=A0 =C2=A0 =C2=A0gets stuck.<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;<br>
&gt; <br>
&gt; <br>
&gt;</blockquote><div><br></div><div>Thanks &amp; Regards,</div><div>Sai Ki=
ran.=C2=A0</div></div></div>

--000000000000798b7005ce4c0616--


From xen-devel-bounces@lists.xenproject.org Thu Oct 14 08:47:47 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Oct 2021 08:47:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.209090.365429 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mawOp-0000fh-TI; Thu, 14 Oct 2021 08:47:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 209090.365429; Thu, 14 Oct 2021 08:47:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mawOp-0000fa-QJ; Thu, 14 Oct 2021 08:47:39 +0000
Received: by outflank-mailman (input) for mailman id 209090;
 Thu, 14 Oct 2021 08:47:37 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=9UJu=PC=arm.com=michal.orzel@srs-us1.protection.inumbo.net>)
 id 1mawOn-0000fU-QA
 for xen-devel@lists.xenproject.org; Thu, 14 Oct 2021 08:47:37 +0000
Received: from foss.arm.com (unknown [217.140.110.172])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTP
 id 615f2174-2ccb-11ec-81b5-12813bfff9fa;
 Thu, 14 Oct 2021 08:47:36 +0000 (UTC)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3994611D4;
 Thu, 14 Oct 2021 01:47:36 -0700 (PDT)
Received: from e123311-lin.arm.com (unknown [10.57.24.225])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 34EE33F66F;
 Thu, 14 Oct 2021 01:47:31 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 615f2174-2ccb-11ec-81b5-12813bfff9fa
From: Michal Orzel <michal.orzel@arm.com>
To: xen-devel@lists.xenproject.org
Cc: Christian Lindig <christian.lindig@citrix.com>,
	David Scott <dave@recoil.org>,
	Ian Jackson <iwj@xenproject.org>,
	Wei Liu <wl@xen.org>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	bertrand.marquis@arm.com
Subject: [PATCH] Revert "xen/domctl: Introduce XEN_DOMCTL_CDF_vpci flag"
Date: Thu, 14 Oct 2021 10:47:18 +0200
Message-Id: <20211014084718.21733-1-michal.orzel@arm.com>
X-Mailer: git-send-email 2.29.0
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

This reverts commit 2075b410ee8087662c880213c3aca196fb7ade22.

During the discussion [1] that took place after
the patch was merged it was agreed that it should
be reverted to avoid introducing a bad interface.

Furthermore, the patch rejected usage of flag
XEN_DOMCTL_CDF_vpci for x86 which is not true
as it should be set for dom0 PVH.

Due to XEN_DOMCTL_CDF_vpmu being introduced after
XEN_DOMCTL_CDF_vpci, modify its bit position
from 8 to 7.

[1] https://marc.info/?t=163354215300039&r=1&w=2

Signed-off-by: Michal Orzel <michal.orzel@arm.com>
---
 tools/ocaml/libs/xc/xenctrl.ml  | 1 -
 tools/ocaml/libs/xc/xenctrl.mli | 1 -
 xen/arch/arm/domain.c           | 3 +--
 xen/arch/x86/domain.c           | 6 ------
 xen/common/domain.c             | 3 +--
 xen/include/public/domctl.h     | 3 +--
 6 files changed, 3 insertions(+), 14 deletions(-)

diff --git a/tools/ocaml/libs/xc/xenctrl.ml b/tools/ocaml/libs/xc/xenctrl.ml
index 86758babb3..addcf4cc59 100644
--- a/tools/ocaml/libs/xc/xenctrl.ml
+++ b/tools/ocaml/libs/xc/xenctrl.ml
@@ -69,7 +69,6 @@ type domain_create_flag =
 	| CDF_XS_DOMAIN
 	| CDF_IOMMU
 	| CDF_NESTED_VIRT
-	| CDF_VPCI
 	| CDF_VPMU
 
 type domain_create_iommu_opts =
diff --git a/tools/ocaml/libs/xc/xenctrl.mli b/tools/ocaml/libs/xc/xenctrl.mli
index 0fdb0cc169..0a5ce529e9 100644
--- a/tools/ocaml/libs/xc/xenctrl.mli
+++ b/tools/ocaml/libs/xc/xenctrl.mli
@@ -62,7 +62,6 @@ type domain_create_flag =
   | CDF_XS_DOMAIN
   | CDF_IOMMU
   | CDF_NESTED_VIRT
-  | CDF_VPCI
   | CDF_VPMU
 
 type domain_create_iommu_opts =
diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
index ad21c9b950..eef0661beb 100644
--- a/xen/arch/arm/domain.c
+++ b/xen/arch/arm/domain.c
@@ -628,8 +628,7 @@ int arch_sanitise_domain_config(struct xen_domctl_createdomain *config)
 {
     unsigned int max_vcpus;
     unsigned int flags_required = (XEN_DOMCTL_CDF_hvm | XEN_DOMCTL_CDF_hap);
-    unsigned int flags_optional = (XEN_DOMCTL_CDF_iommu | XEN_DOMCTL_CDF_vpci |
-                                   XEN_DOMCTL_CDF_vpmu);
+    unsigned int flags_optional = (XEN_DOMCTL_CDF_iommu | XEN_DOMCTL_CDF_vpmu);
 
     if ( (config->flags & ~flags_optional) != flags_required )
     {
diff --git a/xen/arch/x86/domain.c b/xen/arch/x86/domain.c
index 79c2aa4636..ef1812dc14 100644
--- a/xen/arch/x86/domain.c
+++ b/xen/arch/x86/domain.c
@@ -662,12 +662,6 @@ int arch_sanitise_domain_config(struct xen_domctl_createdomain *config)
         return -EINVAL;
     }
 
-    if ( config->flags & XEN_DOMCTL_CDF_vpci )
-    {
-        dprintk(XENLOG_INFO, "vPCI cannot be enabled yet\n");
-        return -EINVAL;
-    }
-
     if ( config->vmtrace_size )
     {
         unsigned int size = config->vmtrace_size;
diff --git a/xen/common/domain.c b/xen/common/domain.c
index 8543fb54fd..8b53c49d1e 100644
--- a/xen/common/domain.c
+++ b/xen/common/domain.c
@@ -486,8 +486,7 @@ static int sanitise_domain_config(struct xen_domctl_createdomain *config)
          ~(XEN_DOMCTL_CDF_hvm | XEN_DOMCTL_CDF_hap |
            XEN_DOMCTL_CDF_s3_integrity | XEN_DOMCTL_CDF_oos_off |
            XEN_DOMCTL_CDF_xs_domain | XEN_DOMCTL_CDF_iommu |
-           XEN_DOMCTL_CDF_nested_virt | XEN_DOMCTL_CDF_vpci |
-           XEN_DOMCTL_CDF_vpmu) )
+           XEN_DOMCTL_CDF_nested_virt | XEN_DOMCTL_CDF_vpmu) )
     {
         dprintk(XENLOG_INFO, "Unknown CDF flags %#x\n", config->flags);
         return -EINVAL;
diff --git a/xen/include/public/domctl.h b/xen/include/public/domctl.h
index a53cbd16f4..238384b5ae 100644
--- a/xen/include/public/domctl.h
+++ b/xen/include/public/domctl.h
@@ -70,9 +70,8 @@ struct xen_domctl_createdomain {
 #define XEN_DOMCTL_CDF_iommu          (1U<<_XEN_DOMCTL_CDF_iommu)
 #define _XEN_DOMCTL_CDF_nested_virt   6
 #define XEN_DOMCTL_CDF_nested_virt    (1U << _XEN_DOMCTL_CDF_nested_virt)
-#define XEN_DOMCTL_CDF_vpci           (1U << 7)
 /* Should we expose the vPMU to the guest? */
-#define XEN_DOMCTL_CDF_vpmu           (1U << 8)
+#define XEN_DOMCTL_CDF_vpmu           (1U << 7)
 
 /* Max XEN_DOMCTL_CDF_* constant.  Used for ABI checking. */
 #define XEN_DOMCTL_CDF_MAX XEN_DOMCTL_CDF_vpmu
-- 
2.29.0



From xen-devel-bounces@lists.xenproject.org Thu Oct 14 08:51:52 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Oct 2021 08:51:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.209098.365441 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mawSt-00023w-EX; Thu, 14 Oct 2021 08:51:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 209098.365441; Thu, 14 Oct 2021 08:51:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mawSt-00023p-BB; Thu, 14 Oct 2021 08:51:51 +0000
Received: by outflank-mailman (input) for mailman id 209098;
 Thu, 14 Oct 2021 08:51:50 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Xl23=PC=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mawSs-00023j-Ng
 for xen-devel@lists.xenproject.org; Thu, 14 Oct 2021 08:51:50 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id f7d09b1a-2ccb-11ec-81b5-12813bfff9fa;
 Thu, 14 Oct 2021 08:51:49 +0000 (UTC)
Received: from EUR03-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur03lp2052.outbound.protection.outlook.com [104.47.8.52]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-16-vlg5aydsNQGqIDPBc3EvlQ-1; Thu, 14 Oct 2021 10:51:47 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB4943.eurprd04.prod.outlook.com (2603:10a6:803:51::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.22; Thu, 14 Oct
 2021 08:51:46 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.016; Thu, 14 Oct 2021
 08:51:46 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM5PR1001CA0008.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:206:2::21) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15 via Frontend
 Transport; Thu, 14 Oct 2021 08:51:45 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f7d09b1a-2ccb-11ec-81b5-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634201508;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=8ad7+q8AoTrQdO1jeRZH1euZa6JslHRFbQaEbpMjJv8=;
	b=bnBuLu5eRMMulkP4CTAizqrXOxIWVq0aNF2IRKqhVszv7XVGopqB6Byy1AtMo6RZBZbMSq
	H4xbWIruMAQGuP6UhhwaFtgZsHSVWU6uRRHNiAhwOdmF8RMI2t9DakohPfSjpgOz6H6RWW
	fy6g1uUpSFFyANragGzzSB3RaEvYNH0=
X-MC-Unique: vlg5aydsNQGqIDPBc3EvlQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Aemzji6Rph7MEUM8U4OsAk5LNYivHUUhD0yJBizK9n5Ng3r9/gf1gsnEMfeGY92PAxckmrfqbJRKyYEtoqtl4aIOCFy52+e2ZzBGzXzb/3RVdkGF1RAws5mZYdsVC9TTtzi3pvTSOr/GvPzVTVEA0FF94Qxx7K59fs5CmSEsHJqck78XliK+ANLbwg6wHLGZr9Y5HToHNiMFV/zv+7OmDWL5h3sgdZuFhmAA78Acj+vFx2XUtsyerdZcSjKLOzmRyAhi405+h/F/H/Ssnu2sLwckHqNW5aCoI1GYJ2hiFggUBuBEekR4Rm+xgPXk3Trs41GSCXNmia1g3ph/KQW8CA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=8ad7+q8AoTrQdO1jeRZH1euZa6JslHRFbQaEbpMjJv8=;
 b=WT7cwjIxYcRB3mMeT87revGmckVQV8n3YDlPJG2jRM8nGYyzwDs1MK9zt7JF50UJ6QqTgcJp+SYG+N9YDgpqbE6LVaBwrDukQF1qWVtgo6emT1FP4EWojRMJ+0kd8yLnDQJBjzkosu7H3C9OHCuDpsdFL6If5vWlyMqpOJ3j9q8LmEePtyZsO0Gwju9fWNvNu9Db6i2vdqxszX4kGgf4QFcsR4P5+ZkP9ScBwFvr+s5hxQCRbI/4GX6/oqw03OexbuSOxXEqYYCQDNE1DncQZ6A8e/ag19ZnnE7vKmBR1tZ8srexTtzQwsQv1YOYFiLkh8oPvZ9DMQn7ZzeXiggQ+A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [XEN PATCH v7 42/51] build: grab common EFI source files in arch
 specific dir
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 xen-devel@lists.xenproject.org
References: <20210824105038.1257926-1-anthony.perard@citrix.com>
 <20210824105038.1257926-43-anthony.perard@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <43684fcc-f6ca-86f2-9fb1-d3d5d9dbc20d@suse.com>
Date: Thu, 14 Oct 2021 10:51:44 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <20210824105038.1257926-43-anthony.perard@citrix.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM5PR1001CA0008.EURPRD10.PROD.OUTLOOK.COM
 (2603:10a6:206:2::21) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: cc336640-e6f1-4aef-d5a9-08d98eefda73
X-MS-TrafficTypeDiagnostic: VI1PR04MB4943:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB4943D18708E8C1545980DF51B3B89@VI1PR04MB4943.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	1jL9rctlLwnzAbt6cgibnivqTAvbUME9LvdLNHaNesngGPdYxDvFGH0l0pnYu1G/ZYtdKflYLMNTAZDBjdtXuN8fXzsq3j2/oXpxYhJftkoUMY3ln/CgT3wj/QSYyDpRPZB7pp6qsNyw9q7fPdxfu1SnxIus5l8Pu7/rb3irHFMbholexG/EKvf1sU/rCrr5c21gLHGfoIZR4hPmEyWumhmOcokv8qM6X0c9wmDZc7vaqGsBWOjVEtn+Vy67h68NNnn+5qLdgDwdB8W6uVYNcFTUUGf4FBn46q3U2flU8v0tpu106x863V2plpx/xPk2BdJ2kahIg63lP2JbHhme0225imFGjdUTV0H2ezQFWi1u6+2CnJMRogSar/Bjuw6oMtcqwwZP3SgVGwFLAYuwRKD29rCI4gSRLKjODC8WVj61F7Oj968gmZ8RFLN43acsUQv/sojHnMNEfgqtuTwB30ppFt9l7rjDHl3FEz5N286f32OOO6qSKCz1q2W1FgfUPNVv/DFkkdS+7TsljlIva5F/jwiTVtXr8808YHPIcl2SnDSTCFGX9v1omUkvJjzxUM7voEGAOK/Ma3nNsSS5eN+FxIL2BusdXMf2NZCbArTdEiyAtAJvgf787OF5nHRIHFvhjTDe/AVCgQpjV9EaO+StZI4zfrI2yn55SL/QKOYvWvIa92dgaLixL2NT/WGa9c0msODo/mg5kklFzk97Gcm09i72tgbdsIUVOzjsa4d3NqiwmG/lhoMAKmrcmUv9Qwz6BhSPDm9KeDFX7ORHCdCHsbeYJJRMHmJkzgCZaEEXcOnGtKPLiGq0zBGPMB6G
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(38100700002)(8936002)(7416002)(6916009)(2906002)(966005)(6486002)(186003)(66476007)(66556008)(54906003)(2616005)(956004)(66946007)(8676002)(53546011)(5660300002)(4326008)(36756003)(16576012)(26005)(508600001)(31696002)(86362001)(31686004)(316002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?VVVtNVMvTGNGSCt3Y2NtTWg2ZTFpSStobEFyVHJFMm9FTHBWOCtqTys5Y1RN?=
 =?utf-8?B?SEtBKzZpaEhld2xKNjd0N1hWNDVmeG9ES1o0bVppQk96bStOYlJxb3Y1R3BC?=
 =?utf-8?B?dVMzWUEyUnhnSW9VQ0hoUUsyQ09tSWphelNYVWRNQ0p6RE12bVdXUU10T0hY?=
 =?utf-8?B?SEJSMXpPME55SjNtSUJoMGZjemFEV0JhUUpWcUlIT01PRjFWY3NUb0U3Ympz?=
 =?utf-8?B?V0VqUEJJVGhUWmVoTlJnT0xPVmVHRHg5R0JQL1ViOW9XTGwvTFg1ekF0aTVW?=
 =?utf-8?B?ajZ4MjAyeC9haGdxa1BCdmFHak5BdHY4TFBjcW9qWmlCL3pNWTZSck5NMEZO?=
 =?utf-8?B?SG5KclVXbktLN2lxMFRzNHZnVzlCQjBldTlKN1htSUdZcVBPaWhucDN6MWNR?=
 =?utf-8?B?SEVYbnoxREptd25xV1NSMDFUQ21uZmxnSmc2ekJ2VUtNMHB4VzZCWktGSzZO?=
 =?utf-8?B?bEtJa3BsZDBTV2RzUG16c3p5R3ZFVXp1Z1EvakE2cVhlL0RWWVdqSU5xM0h1?=
 =?utf-8?B?eU1oNXVsaHpYTERSZlRRajUrTlc4aE1rbVcwNFh4WTFTWktTSForNVkzQVdZ?=
 =?utf-8?B?RHhPLzRFVzhvTC9rZmxyTWFGYXpIazVza2lxbi9jcGc2MlRXY3lvd3FvV0lD?=
 =?utf-8?B?eUIwTVlHZk9wMzVzbkdaV2dmaUoybXpMZFZySU9TTmtiZ3JkdW9nZkdrdjZL?=
 =?utf-8?B?M2VSVTFxUDZlWmxiaDVQeDhQdnhjUyt0RXNHTzdEM2duWkVRUTdIU2xMdXNr?=
 =?utf-8?B?ZEE1OFV4c1F0ZkU0TS9kRWNQajFEVlFCN1hMOC9BK3hDcnJMOGhhaXhJaWFn?=
 =?utf-8?B?MWtVdXMySlo2Q0lnazVkR000OG80V1ZJOG5URUNicGpWU1lRTW1SV29rZDZp?=
 =?utf-8?B?UDkzUGlMajlBLy9PZ2EzWG1NYXYyQjJHcUN2eHRaeU55bG91Z2tsN21CcjhV?=
 =?utf-8?B?SW5IdG9EbGhrbnJzNzdFV0hHNnhKc2kwYzJUMGYvSEhObzBaeXY4Y3dqejFj?=
 =?utf-8?B?Q20zOEZuQnQ1ZXdCZG0xZ3VReDZzTGtaMlR4dDVsMTRpam11bFpoRTJ1em80?=
 =?utf-8?B?RHdIWmwxS1pFVVFlZHh3ckM3QzZUVStZMUhOOHZBTEp1Q01CRndLMVZJcWJQ?=
 =?utf-8?B?dS9aMnRIZkM0b2JIUlQzZXB0TUNsOEsrSjhEV3M4QUdPNlY1ZVhuRU1JbW9y?=
 =?utf-8?B?TEpUZWRMK3JzVWVtVWxDTzNpQTNyWU41SVZETHNnYy9Hb0ZZSlZGZDVveExs?=
 =?utf-8?B?TndReStCZkYydlN4RVN1SmZ4RjVzd2pOYkttMTRkZW9DeWt4RjJZMktYL3lK?=
 =?utf-8?B?ZmYwQ2FlMTdPUWZuMEN3bkdFMUNvSW82ZlJVd1BTSkErbG9UZ3Y3b01ORERp?=
 =?utf-8?B?dzc4RndIbGNKTU9PY09yQjBBRDIySXJnOEZla0hIYThoZk1mUnBGUWphVmVj?=
 =?utf-8?B?YVE3SFdUbEdJY2JaUHlUUW9zWlR6azBuUUcvb2lyRk9mVTQ5MHdxSmJ6UTJi?=
 =?utf-8?B?QVFmQnh1Tnp6cnBlWHBoL0F3Nm40aHR3QlBSa2lHRmM5bThzeTZmM1BpOWQ5?=
 =?utf-8?B?Rlk2WTlnMm5zamhoblFPbHhwQzRBVXVtZEd2S0RabldxbkFxc3VubWlKTHdN?=
 =?utf-8?B?dTdNSG5rdFczR3FGZTFsNlN6elhvNXFJelZ4blF4bFZVSGR4SWlZRm4yZE8y?=
 =?utf-8?B?Q0p3SGw5cE9nRWYyOXlKRGVDeFFnSHJUR2RYemY3M3BBMGpJM0pyeUQ5TVR3?=
 =?utf-8?Q?U7ABw0qJ8FTAE7UBj0q82Hlo5FFVmB7DG8w5ShI?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cc336640-e6f1-4aef-d5a9-08d98eefda73
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2021 08:51:46.4447
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: e2U5BfY4JfHpB26l8xzm9RGesFQVbzQ8/l435CYyFvviPaQipbpGP0RX2e/FjZtdZceYJnW+98GU3IX+xGeoZQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4943

On 24.08.2021 12:50, Anthony PERARD wrote:
> Rather than preparing the efi source file, we will copy them as needed
> from the build location.
> 
> Avoid the links as they seems fragile in out-of-tree builds. Also by
> making a copy, we don't need to figure out the relative path or we
> don't need to use absolute path.

I agree that symlinks wouldn't be nice for the out-of-tree build case.
Otoh please see
https://sourceware.org/git/?p=binutils-gdb.git;a=commitdiff;h=8c6740616cd244e5763e974cb737affbe71db385
albeit I'll admit the situation was a little different there because
it's pre-built files which get populated into the build tree.

> --- a/xen/arch/arm/efi/Makefile
> +++ b/xen/arch/arm/efi/Makefile
> @@ -1,4 +1,10 @@
>  CFLAGS-y += -fshort-wchar
> +CFLAGS-y += -I$(srctree)/common/efi

Perhaps another opportunity for -iquote?

>  obj-y += boot.init.o pe.init.o ebmalloc.o runtime.o
>  obj-$(CONFIG_ACPI) +=  efi-dom0.init.o
> +
> +$(obj)/%.c: common/efi/%.c
> +	$(Q)cp -f $< $@

In case both trees are on the same file system, trying to hardlink first
would seem desirable. When copying, I think you should also pass -p.

> --- a/xen/arch/x86/efi/Makefile
> +++ b/xen/arch/x86/efi/Makefile
> @@ -1,4 +1,5 @@
>  CFLAGS-y += -fshort-wchar
> +CFLAGS-y += -I$(srctree)/common/efi
>  
>  quiet_cmd_objcopy_o_ihex = OBJCOPY $@
>  cmd_objcopy_o_ihex = $(OBJCOPY) -I ihex -O binary $< $@
> @@ -19,3 +20,8 @@ obj-$(XEN_BUILD_EFI) := $(filter-out %.init.o,$(EFIOBJ-y))
>  obj-bin-$(XEN_BUILD_EFI) := $(filter %.init.o,$(EFIOBJ-y))
>  extra-$(XEN_BUILD_EFI) += buildid.o relocs-dummy.o
>  nocov-$(XEN_BUILD_EFI) += stub.o
> +
> +$(obj)/%.c: common/efi/%.c
> +	$(Q)cp -f $< $@
> +
> +.PRECIOUS: $(obj)/%.c

Seeing you repeat everything here, despite it not being all this much I
wonder if there wouldn't better be a makefile fragment in common/efi/
which all interested architectures' arch/<arch>/efi/Makefile would then
include. This could then also subsume -fshort-wchar.

Jan



From xen-devel-bounces@lists.xenproject.org Thu Oct 14 08:53:30 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Oct 2021 08:53:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.209106.365452 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mawUQ-0002eK-QZ; Thu, 14 Oct 2021 08:53:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 209106.365452; Thu, 14 Oct 2021 08:53:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mawUQ-0002eD-MP; Thu, 14 Oct 2021 08:53:26 +0000
Received: by outflank-mailman (input) for mailman id 209106;
 Thu, 14 Oct 2021 08:53:25 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Xl23=PC=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mawUP-0002e5-9t
 for xen-devel@lists.xenproject.org; Thu, 14 Oct 2021 08:53:25 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id f363c36c-a6cc-43f6-8131-9443b2642550;
 Thu, 14 Oct 2021 08:53:24 +0000 (UTC)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2052.outbound.protection.outlook.com [104.47.13.52]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-35-1tyXVwfBOciNOZwktg7hFg-1; Thu, 14 Oct 2021 10:53:22 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0401MB2447.eurprd04.prod.outlook.com (2603:10a6:800:53::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15; Thu, 14 Oct
 2021 08:53:20 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.016; Thu, 14 Oct 2021
 08:53:20 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6P193CA0116.EURP193.PROD.OUTLOOK.COM (2603:10a6:209:85::21) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.15 via Frontend Transport; Thu, 14 Oct 2021 08:53:19 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f363c36c-a6cc-43f6-8131-9443b2642550
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634201603;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=9lDL5J4suLmGGcmf7KGrdWh7Ht3QbfuMeeRREq/BDAA=;
	b=BW+Rz69x6Gu/pM8l0Re63YD+HKNRLtrQdp9IRoR6AQdvO1PNPogFOb+fI+bBZ4sHHTIWCg
	cDUxIH4Fq+dc9sOwVeWjFjeHbnYYqEopRLyOv6HJEUGX6oqxlYNZ2SnWj9igpu9JV1e0VP
	aF6t//bfSjC+9SWCYQfCJiiW/C74A0c=
X-MC-Unique: 1tyXVwfBOciNOZwktg7hFg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ZuAeh15X7nHiLqHk3TSmIDPc/v0PlFFZ/LkZlARHmeXoofX/6lgq14cHWgM0KvbBtIATaPoPQoZGDo4A18rphC8VuZI3T7DRG/1XR8zIzM+3PQNYwzSC+DMbdYc1JP1mfSuqrcKI49fidR2HaM0SPlzEcgC6KbM+3n2ojcLgbwkozqgA8CueQaXNvfiCZJXCCvVsWdqG9S7jTm0/L0sYf5x+Fs1aR288/705Z3vG0GcsQUY7UXa+8YyMk2WMIb0p06I1qRxbfCnwT63w0UeWH7CKxOMSkoyqMRC3HwdN8XVdjn7MYM2QoJ/vvs6FbFUSRt/GAt6D4XmsME44BNDLXQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=9lDL5J4suLmGGcmf7KGrdWh7Ht3QbfuMeeRREq/BDAA=;
 b=M38FxTKjc5RbzZJke4H5Zg4ojwjYbrplksaH9OtTdCFeePqrgJvFV4FVkvY7pnuWLmhoIZjHet0AGOmPrboqZobe5OekDrNQZZcGErhoG7xBYPtm0r10qCcia9/LT/7EGgBB93I+1WNKagdQg0ZUfnB2ry8oOR4jJXFqEXLEzSTGMg6ZDmELiKXO7xbN9MQB89aSCGxXX5TJEP8CQ1D2GNwSWpMNxcNcZ9h4nR0oFve3Y4JkgofkhGDbDoPdITLcyljU9THCdzsRJx2Ta9ZnmZzYWCGgMxZtVJfmSgYBELzA87PLPAtFgctesVd44SCPaPsoOAXhNJ1YGvCaB5E7Lw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [PATCH] Revert "xen/domctl: Introduce XEN_DOMCTL_CDF_vpci flag"
To: Michal Orzel <michal.orzel@arm.com>
Cc: Christian Lindig <christian.lindig@citrix.com>,
 David Scott <dave@recoil.org>, Ian Jackson <iwj@xenproject.org>,
 Wei Liu <wl@xen.org>, Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 bertrand.marquis@arm.com, xen-devel@lists.xenproject.org
References: <20211014084718.21733-1-michal.orzel@arm.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <fd36ef73-c227-1ad1-b8bc-7004b98c5996@suse.com>
Date: Thu, 14 Oct 2021 10:53:18 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <20211014084718.21733-1-michal.orzel@arm.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P193CA0116.EURP193.PROD.OUTLOOK.COM
 (2603:10a6:209:85::21) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 9b2d0471-ee5e-4013-f88d-08d98ef0128d
X-MS-TrafficTypeDiagnostic: VI1PR0401MB2447:
X-Microsoft-Antispam-PRVS:
	<VI1PR0401MB2447D56310B62605B000A504B3B89@VI1PR0401MB2447.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:1122;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	hDeMuEb4SCtTKPp37wCUoSDnRl7Oa1X/f/T3y3FmfsMkTYAlNIC+PHyBve7pE0dYhghxXIA8NZ8iWmI9/r4z/9dCoK4MXLWDvRHXWycDdI0yQ9zOTKGR6jgef18oNbVhq8tFg4Y9f+MkpO0xPjr4dsAI1uLLRl01wvUQAXpOlaFJQQRY6VIlCb/DY4qVeuwiIxmz4vLE1eHsu5jXUWqKsZZmZEs8VjhEwcANlG2x9XIeubqYr+KCf71dhUJQWRCMPKmWYvYGjsg9MhHN4+mxrjJXoxZ4egFNdSXrahc6Yzmo9X5c3LwxEQIw+ZJhU4Eqy+URzdJShJV9xQYM0JCARjYejbBSgJAgfNQ6lU2Ma3UegUVcvg6pyXW0SjPb27P8b4JrHAKxjSdTKBsVTgcP8Zzr/0ozOWN9mBYgs4W/5mJdYyHqO2UB3IHTq3o/V2F2qVdYTZ49QEjef/M+f9kJdiJLSkgKZaHGTVDz3ze/pLFNHeS+KwhBBt9TYRAiqzGBVzNjps9D5R0djx4e7BRyuCfcn5jZjTTkeBFL8VBi2+lk82smDBNM2NrJU06LeIBkQFi+CTjlUcyG7hELYXnaCsnU/HEMWPmyt+SK0+fm35r0aCRgFIK9fcaumPC64cyxnBWXaioAqFYCZcNJWIEWmrprD69nL6WcKC6H13IRuhK1HiBSDa8uWC3JPa0a1l3QeHiVAG+pGVpiRdoNCEWgFnVEd5jZqHB/5FPNiY3qg+YNw/aZM6jCEU/9Cmkfmb7q7drZRBmkAWNlL9yWv0fnUL5M06DybdmsYFCJ67WQ9s6iPI6nl9YuOmdsblSnW75C
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(6486002)(83380400001)(36756003)(86362001)(5660300002)(956004)(31696002)(7416002)(186003)(53546011)(54906003)(6916009)(508600001)(2616005)(16576012)(66556008)(316002)(66476007)(66946007)(31686004)(966005)(4326008)(26005)(8676002)(8936002)(2906002)(38100700002)(4744005)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Sm0zYWJ2ZmRYblYyTm5nUVJ4L1I3TU9JZ3BPVmd4VFFGOEY2Y3g3L2lJd1RN?=
 =?utf-8?B?b2IvQmZGMjJhVWVmVlltYUkxUFRDaVhHNzNZRVY4OTZyZU5oaVVQMHhQSFQz?=
 =?utf-8?B?dUg1WkpNUWtkT3FRci9zQ096UTV5MnBEdVF4bHowaDVhVFBxRjh4b24xQkp0?=
 =?utf-8?B?dDBMeVk5QkR5bHFFT0hoL0tvekduaDFtZE1wYzlzZnBzdk9IU0UwbEE5MzBN?=
 =?utf-8?B?TmJzc1liMzJqdHFLMWllSC8rOUhkNXNzUmNaOHpXdjZnY1oxNmZ1c0V3Ymxa?=
 =?utf-8?B?cUs0QTZWRDFkc0IzZGNDTGI1d2pmL0xNT3BwOTB3MGpWSGtIL0YrTlNQdHhN?=
 =?utf-8?B?NnVJdnRHcHdSdndsVG11VFZjYW1RT1krZTVaZ0pISi85RUI2YUZ0LzRGNWVm?=
 =?utf-8?B?OEYxampROU5NUXJndExNc2kzdXE2Z1JSRjZaaDhObGkxT1RZdlF5dTUxQzJB?=
 =?utf-8?B?NHlkcUJRdklVM3FhbWptcGZ6ODEyRWpjRm1rdm44T0VZMTdnV3BLR3M5NmY5?=
 =?utf-8?B?RnQ4YmZIV3Q4ckxvQ0FsS1hBNUxIK1gxUDdVOVk4WEwvdTJ0NEFHQVFraFh4?=
 =?utf-8?B?eEdyZUMvSkpOZ1lobk1xQUxlTVV3MFoxbGIvazQxcGlobGU5cTVaTDl3N1dT?=
 =?utf-8?B?QkFkN3NtOXRVbjA2WjNBbEZOOUt3TzR2ajJpVTE2eDl3V1phKzNDS2ZkWCtm?=
 =?utf-8?B?Szl5L1B4ZVg5RXhVM2U3M2oyZlJ0UThVYWZyR0Y2VjJjRnAxSjBKbmUrZzFS?=
 =?utf-8?B?aFFYb2svSnBheHh6dXp4U0p5VzE2TzhCeEg2aEZhaUdyQ1o4c1RsaDNoL3p1?=
 =?utf-8?B?ZDlmbWxNSVFXQkgwa2hXaEFrazJ3b2JuSGpwYkxralExY21BOUFQQUcwSnls?=
 =?utf-8?B?SWIwRzRPaExZN0ZvdUw4NEEyRDZQcjZiYzBzZ0xmZTlaZWpLcnNFL3dnVjNQ?=
 =?utf-8?B?cVR2OTJ5ZE5WTVZ4Q1I2Z1Z3Yk9jVExScitPWVhnZ0QvOHhVK1d3a0pXellD?=
 =?utf-8?B?aXZhbWpqSDdQR0NFQUJmNVhPK1FodURCelVWMktTblcrdFpBaU5ZME9meWVS?=
 =?utf-8?B?ZnR3R3ZHYTUvTFdNMVdpYjU1MkV6bGtDaWN2bDFsRzQ1SHlWUWsxUXhNS2Zi?=
 =?utf-8?B?anFDMXFHdVVNb1NMRGFxYW9zKzVoSXFkME9odFBPTGFibUdtbnppVVhrWXhl?=
 =?utf-8?B?YzdOdlREcUJrNUM2Ull5ZFZ2QzI0YmVxYXprdUJGVjVVdHRGcUFVOVZaM0tD?=
 =?utf-8?B?SHV0SHF4a1I5akI3RXo4SnN0aVUxRkNGWFByVmh5RU1wM3VpK09aU296L2FU?=
 =?utf-8?B?UGk1Vmg0NU03Vit2VmFzSkRmbCtoWUZRUWFBR0NyejNSK1NCdVR4bGU1NjRT?=
 =?utf-8?B?K3RsZ0dyV2wranRPaUxPQTFnMWUxNWhPMzBKVHI0ZTBPNHA4Umh0ZzJZSGFl?=
 =?utf-8?B?WDU4Ui8rUnB3Z1cvRUFndGtEYituUEg4dmhYVjV0cnhCZVFHa3NxOHQveGZn?=
 =?utf-8?B?L2V3UVBQMDREV0ZxYjVZYjlXdmhYeWVCb0t4ZU54bVVCYjlmZGpzUlNyTVpF?=
 =?utf-8?B?RC9vSE1pN2plYUFjaWRmQ29CNDNhUFRmNUZoTlNZZ1BFbG5sU1d6NDFTMWlK?=
 =?utf-8?B?ZXNSditzRzFpY0JSTjd4a3JJVFdMRFVTNnVjeXc0VURvdzN3bHJDUzJ2cEpL?=
 =?utf-8?B?SWlUUXd5Uk9CckRKT0Y5N01uNFI3MFhGbHVpeHNBYnlYSlFXbW1CM0NqMlAz?=
 =?utf-8?Q?ooGPDFqXuN0cJkI/hVe7VXpmO8vQGd1sTTVCLOB?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9b2d0471-ee5e-4013-f88d-08d98ef0128d
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2021 08:53:20.5304
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ZZhyBz0ieIv4xQsccGQmAxVsBZXc6joXSlM2LJx36LF6Fkiln2Q4H9yoC3GyYxIRXNfsODlDJ4S8JlrlZofcRA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2447

On 14.10.2021 10:47, Michal Orzel wrote:
> This reverts commit 2075b410ee8087662c880213c3aca196fb7ade22.
> 
> During the discussion [1] that took place after
> the patch was merged it was agreed that it should
> be reverted to avoid introducing a bad interface.
> 
> Furthermore, the patch rejected usage of flag
> XEN_DOMCTL_CDF_vpci for x86 which is not true
> as it should be set for dom0 PVH.
> 
> Due to XEN_DOMCTL_CDF_vpmu being introduced after
> XEN_DOMCTL_CDF_vpci, modify its bit position
> from 8 to 7.
> 
> [1] https://marc.info/?t=163354215300039&r=1&w=2
> 
> Signed-off-by: Michal Orzel <michal.orzel@arm.com>
> ---
>  tools/ocaml/libs/xc/xenctrl.ml  | 1 -
>  tools/ocaml/libs/xc/xenctrl.mli | 1 -
>  xen/arch/arm/domain.c           | 3 +--
>  xen/arch/x86/domain.c           | 6 ------
>  xen/common/domain.c             | 3 +--
>  xen/include/public/domctl.h     | 3 +--
>  6 files changed, 3 insertions(+), 14 deletions(-)

Applicable parts
Acked-by: Jan Beulich <jbeulich@suse.com>

Jan



From xen-devel-bounces@lists.xenproject.org Thu Oct 14 08:55:10 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Oct 2021 08:55:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.209113.365463 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mawVw-0003Fv-4q; Thu, 14 Oct 2021 08:55:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 209113.365463; Thu, 14 Oct 2021 08:55:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mawVw-0003Fo-1A; Thu, 14 Oct 2021 08:55:00 +0000
Received: by outflank-mailman (input) for mailman id 209113;
 Thu, 14 Oct 2021 08:54:59 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=iCUr=PC=arm.com=Bertrand.Marquis@srs-us1.protection.inumbo.net>)
 id 1mawVu-0003Fi-Un
 for xen-devel@lists.xenproject.org; Thu, 14 Oct 2021 08:54:59 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com (unknown
 [40.107.20.48]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 7e0483cd-dfe2-4dd7-ad3b-563fccc69656;
 Thu, 14 Oct 2021 08:54:57 +0000 (UTC)
Received: from AS9PR0301CA0017.eurprd03.prod.outlook.com
 (2603:10a6:20b:468::33) by VI1PR08MB3760.eurprd08.prod.outlook.com
 (2603:10a6:803:c1::27) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.25; Thu, 14 Oct
 2021 08:54:53 +0000
Received: from VE1EUR03FT033.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:468:cafe::60) by AS9PR0301CA0017.outlook.office365.com
 (2603:10a6:20b:468::33) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15 via Frontend
 Transport; Thu, 14 Oct 2021 08:54:53 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT033.mail.protection.outlook.com (10.152.18.147) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.15 via Frontend Transport; Thu, 14 Oct 2021 08:54:52 +0000
Received: ("Tessian outbound 16951d3c485e:v103");
 Thu, 14 Oct 2021 08:54:52 +0000
Received: from b09a8326ebd7.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 4AA6DCFF-20FB-47B1-B3CB-6CEADEA446AB.1; 
 Thu, 14 Oct 2021 08:54:41 +0000
Received: from EUR03-VE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id b09a8326ebd7.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Thu, 14 Oct 2021 08:54:41 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com (2603:10a6:4:74::9)
 by DB8PR08MB5258.eurprd08.prod.outlook.com (2603:10a6:10:e0::32) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.24; Thu, 14 Oct
 2021 08:54:38 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955]) by DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955%4]) with mapi id 15.20.4587.030; Thu, 14 Oct 2021
 08:54:38 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7e0483cd-dfe2-4dd7-ad3b-563fccc69656
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=UYJXEF5xZIle0JkB7WDknxafdr4nqw1UdyEtRkQhDzo=;
 b=jmAW8VsjRixwyjkNxg9kvQbChhY9VaR0UDFJvtRJHWg144GHhp58vZwb5fSe7DyOGiGmzWWJw9wDUHt85PHFnCjLeQ1yiY3XNjNsBo3VvKyud3E8vil2e2nl+k2s6+QVQ8SSKnN89ZsOm/OqLSSNVG703Gn8o7m7RsgkfHwv4Ps=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 4fe785c23b252a91
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=WXSY1ZXC7LLWcdZTBrG1WbRXCUqpgR2+n/stYbZ9hvW22mNLipCcwH4bEHpCTktPu84uLTMeIOkK7glF4UxVvi8OKRb4X7VzANkEkky8PTNhvIpibPNpsWqpie/8VjkXeNWGLawAht7R6oeMt14Cyd0y2wSzkpcE+jxjWc89CrFrTubhxZOklZRs6aQD95xK8CRq08FtMdvvOViggU7qmxMtml0d1q9M4D9nUKHA6e8+sVpmFYhWVrnuuLLYfrxiRL+co1LT3gBaU7TI67WbGtOsiR7iW2qVSMXB8SXkSKnsOarPC+S5qUG2koXtDs3rHXMFVWNBS9kBf7n8E2jrpg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=UYJXEF5xZIle0JkB7WDknxafdr4nqw1UdyEtRkQhDzo=;
 b=gKIjWrCnRGQOl6RePbg2v+LmXWitdnZ60vXJ7GVtPYGqFXrOxKMOcCIqCSt0u/0/0wgGLLXi+SaQrYcEJbZvW8OBGWtXMK9nJVqOJOlm52IYMGWjX8fG+ovFpxFi+a5RjScXHg8DnUB2WFEn6AkwN2jKOwiCfTzXn5vdA9WJYEf3wiFbbzdvIehMiwvBNMRim86eW9Alv3gZ1gPRV1JWgEjd+6WBHd/YukNjdovpx5us2QTI9KsR0kksQdlUseED43+YfjY3frI9Tmc/l0jHs/PcZXM9aXU9ViCKj/f2aIgXlhZKlRES9MejqAfqq7x5rTgqBa0/6W61vE271I88JQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=UYJXEF5xZIle0JkB7WDknxafdr4nqw1UdyEtRkQhDzo=;
 b=jmAW8VsjRixwyjkNxg9kvQbChhY9VaR0UDFJvtRJHWg144GHhp58vZwb5fSe7DyOGiGmzWWJw9wDUHt85PHFnCjLeQ1yiY3XNjNsBo3VvKyud3E8vil2e2nl+k2s6+QVQ8SSKnN89ZsOm/OqLSSNVG703Gn8o7m7RsgkfHwv4Ps=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Michal Orzel <Michal.Orzel@arm.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>, Christian Lindig
	<christian.lindig@citrix.com>, David Scott <dave@recoil.org>, Ian Jackson
	<iwj@xenproject.org>, Wei Liu <wl@xen.org>, Andrew Cooper
	<andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>, Jan
 Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>, Stefano
 Stabellini <sstabellini@kernel.org>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, =?iso-8859-1?Q?Roger_Pau_Monn=E9?=
	<roger.pau@citrix.com>
Subject: Re: [PATCH] Revert "xen/domctl: Introduce XEN_DOMCTL_CDF_vpci flag"
Thread-Topic: [PATCH] Revert "xen/domctl: Introduce XEN_DOMCTL_CDF_vpci flag"
Thread-Index: AQHXwNgx8NpL0VHy4UKLU+O7ZFIg1avSMIwA
Date: Thu, 14 Oct 2021 08:54:38 +0000
Message-ID: <3294EDDF-FA64-4CC1-B47E-D7924B382ED7@arm.com>
References: <20211014084718.21733-1-michal.orzel@arm.com>
In-Reply-To: <20211014084718.21733-1-michal.orzel@arm.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3654.120.0.1.13)
Authentication-Results-Original: arm.com; dkim=none (message not signed)
 header.d=none;arm.com; dmarc=none action=none header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: 85b40ecf-9a4b-4b91-b6b9-08d98ef049c6
x-ms-traffictypediagnostic: DB8PR08MB5258:|VI1PR08MB3760:
x-ms-exchange-transport-forked: True
X-Microsoft-Antispam-PRVS:
	<VI1PR08MB3760728EEDB9556979C940499DB89@VI1PR08MB3760.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:6430;OLM:6430;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 hZEOIneND+he98AXMS225hvceZPg8zcxJd2CrTSUpUmmd/VgP9ESumjQCOpiuHrEFvbHWnlQml6JqP7N51GLrFR9bu7vhb4LR55fm91Zb2RlGL5Ud3g8A8tmJTkwiZktxPx1KuJkJIY3b5JtHHklY0JgeBz43BklK6QXlQVBhCOv5vePujVNu45PAbkZLwTo5gbYDZuqjJyDCCUaN4+dqS5y3gN32eirCgrEk2fylKV2cniLtNs0DOEqrSusP+PHxviN1R4A/3QBBhyoiFUNbI5bEJeYRKKMzxg2OKF7yIFvDoUSzaRlDWEbWP42886MQJVy0yTAW/5xXui9+ENV1YpNwxkPrzqtl8rU0o3RRVsGp2RIV8ooLt1BWxSHeEkRllTlfdzqF3WxwOHZ6V7gkHZ5Vr0N6qHV34FhuzKLXuM8snqE+V1ay/BBvVOUQfnEg0KgDwH4Qt8cr7JW50RbeB+QY1hbtAM713WplB0gOx5BWViPBQrD4XVNYzfozOBcsohc9Wb7ZIHR3wlUqudKI0FuLW9id0jEQ6kbM2+Bq0E1uwggj1lUGuHV60NSI1lCOi9fZPiUaQC09fvZKFeRZQJ9VtaVnqph8OErzoykrEyEN/oCh2Ujv50gP3yezge44/0+JzcvHco1lRgD+DWT6yHkQcZNfkr0JYx3OJYaQ0dJkpwvDmZr6NEp/cT+aeGkdF5jTe4ncTXThQVxvOwEcRxi/0nw5llZPQQruPxPGkxVKe70wsXlsvQjpDw0UFXo72avjPnLYS2KvWDZs/KiB0W5+CnRoP7KnGhKNQ0YqpWJ/AlbTCbT/psRrqh0BLZR
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB6PR0801MB2024.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(6506007)(26005)(37006003)(316002)(36756003)(54906003)(6862004)(8936002)(2616005)(83380400001)(4326008)(8676002)(53546011)(86362001)(7416002)(33656002)(186003)(6636002)(6512007)(122000001)(64756008)(71200400001)(66556008)(508600001)(66946007)(66476007)(91956017)(966005)(66446008)(38100700002)(2906002)(5660300002)(76116006)(6486002)(38070700005)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="iso-8859-1"
Content-ID: <8A0780232C378441B049A0627FFAD4AC@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB5258
Original-Authentication-Results: arm.com; dkim=none (message not signed)
 header.d=none;arm.com; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT033.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	856acf03-af16-4325-fb27-08d98ef04150
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	pb2D/rwQIN+EvRJGhJVJGJg9NNrdlsUV/hHdmLwi3LylXUciEL4heKGgQZW6q91a0n7YurIu3dnFKdEhyiOvoguJB69vqI3NwzEX69v/ENtaE20DWtLSdzuNnj29kCwy4s+IRbAIakr/ZUeZjLsIvMIaAlJGrBdZI6Ej7HgQBlXhnxs7X8uBmHQY0N/i4QuC29LMnGoSy/d1XyEjOANrKBQnTTi95fWSzUEhVS4xcDaAAWNvWrzsfKyoFeWUUFBMf0NH9kv80lmniGHmLw8A7suQB0zr3ApQsPwLF+jrWVyraNmkAdeo0WdKLHqo9dluEVPD5JL/XCJRvmak92pdiXDbPAdjK1k7iZUl74CFqg+XzKlhnpFXnglxxZho3QbX1kqemZIr2WaNr5JZ9Ht2Wfw4jy3XKpKlnjUtSgOI4qBdzWEdZcuFPYiIEkWc01TV2NQgu67MaUws4LRoaRz3ns92z6teHcHp3zqVJ9BI9DdS2d4hZ+4QKdWaf3L7G4lP2ttHumEISBswTm4FKKkUsP/O0L6i4xTU2bGhNQ+GxMgimZiHTb4ZNP8yryrQuxnSYghoa9LPmCj5sFBF/QVZUQw0RlHqnCrrYo+Ls0bCqaiy1RZWiUMygKTdGPf61jlQ8+hdxMANx+ZVCdv01xgxmt5CEKIohEH8A0P+iZOVHRHl1pop5vZMlYlOeFi7ZlU0SmeSSuVMJGMzaUW68HnM/QLX3hgSHJFw3vdU16jb2qim3ru6Mku3zwuT6yqEqSS2O4iB2aG8xEWj6IkBst0GtKyN0iWYNbz3Q5Yz2nRNwcU=
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(70206006)(86362001)(53546011)(6512007)(6862004)(6506007)(26005)(83380400001)(6636002)(508600001)(107886003)(6486002)(33656002)(2906002)(70586007)(36756003)(4326008)(966005)(186003)(47076005)(316002)(37006003)(54906003)(336012)(8936002)(5660300002)(2616005)(356005)(8676002)(81166007)(36860700001)(82310400003);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2021 08:54:52.9651
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 85b40ecf-9a4b-4b91-b6b9-08d98ef049c6
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT033.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3760

Hi Michal,

> On 14 Oct 2021, at 09:47, Michal Orzel <Michal.Orzel@arm.com> wrote:
>=20
> This reverts commit 2075b410ee8087662c880213c3aca196fb7ade22.
>=20
> During the discussion [1] that took place after
> the patch was merged it was agreed that it should
> be reverted to avoid introducing a bad interface.
>=20
> Furthermore, the patch rejected usage of flag
> XEN_DOMCTL_CDF_vpci for x86 which is not true
> as it should be set for dom0 PVH.
>=20
> Due to XEN_DOMCTL_CDF_vpmu being introduced after
> XEN_DOMCTL_CDF_vpci, modify its bit position
> from 8 to 7.
>=20
> [1] https://marc.info/?t=3D163354215300039&r=3D1&w=3D2
>=20
> Signed-off-by: Michal Orzel <michal.orzel@arm.com>
Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>

Cheers
Bertrand

> ---
> tools/ocaml/libs/xc/xenctrl.ml  | 1 -
> tools/ocaml/libs/xc/xenctrl.mli | 1 -
> xen/arch/arm/domain.c           | 3 +--
> xen/arch/x86/domain.c           | 6 ------
> xen/common/domain.c             | 3 +--
> xen/include/public/domctl.h     | 3 +--
> 6 files changed, 3 insertions(+), 14 deletions(-)
>=20
> diff --git a/tools/ocaml/libs/xc/xenctrl.ml b/tools/ocaml/libs/xc/xenctrl=
.ml
> index 86758babb3..addcf4cc59 100644
> --- a/tools/ocaml/libs/xc/xenctrl.ml
> +++ b/tools/ocaml/libs/xc/xenctrl.ml
> @@ -69,7 +69,6 @@ type domain_create_flag =3D
> 	| CDF_XS_DOMAIN
> 	| CDF_IOMMU
> 	| CDF_NESTED_VIRT
> -	| CDF_VPCI
> 	| CDF_VPMU
>=20
> type domain_create_iommu_opts =3D
> diff --git a/tools/ocaml/libs/xc/xenctrl.mli b/tools/ocaml/libs/xc/xenctr=
l.mli
> index 0fdb0cc169..0a5ce529e9 100644
> --- a/tools/ocaml/libs/xc/xenctrl.mli
> +++ b/tools/ocaml/libs/xc/xenctrl.mli
> @@ -62,7 +62,6 @@ type domain_create_flag =3D
>   | CDF_XS_DOMAIN
>   | CDF_IOMMU
>   | CDF_NESTED_VIRT
> -  | CDF_VPCI
>   | CDF_VPMU
>=20
> type domain_create_iommu_opts =3D
> diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
> index ad21c9b950..eef0661beb 100644
> --- a/xen/arch/arm/domain.c
> +++ b/xen/arch/arm/domain.c
> @@ -628,8 +628,7 @@ int arch_sanitise_domain_config(struct xen_domctl_cre=
atedomain *config)
> {
>     unsigned int max_vcpus;
>     unsigned int flags_required =3D (XEN_DOMCTL_CDF_hvm | XEN_DOMCTL_CDF_=
hap);
> -    unsigned int flags_optional =3D (XEN_DOMCTL_CDF_iommu | XEN_DOMCTL_C=
DF_vpci |
> -                                   XEN_DOMCTL_CDF_vpmu);
> +    unsigned int flags_optional =3D (XEN_DOMCTL_CDF_iommu | XEN_DOMCTL_C=
DF_vpmu);
>=20
>     if ( (config->flags & ~flags_optional) !=3D flags_required )
>     {
> diff --git a/xen/arch/x86/domain.c b/xen/arch/x86/domain.c
> index 79c2aa4636..ef1812dc14 100644
> --- a/xen/arch/x86/domain.c
> +++ b/xen/arch/x86/domain.c
> @@ -662,12 +662,6 @@ int arch_sanitise_domain_config(struct xen_domctl_cr=
eatedomain *config)
>         return -EINVAL;
>     }
>=20
> -    if ( config->flags & XEN_DOMCTL_CDF_vpci )
> -    {
> -        dprintk(XENLOG_INFO, "vPCI cannot be enabled yet\n");
> -        return -EINVAL;
> -    }
> -
>     if ( config->vmtrace_size )
>     {
>         unsigned int size =3D config->vmtrace_size;
> diff --git a/xen/common/domain.c b/xen/common/domain.c
> index 8543fb54fd..8b53c49d1e 100644
> --- a/xen/common/domain.c
> +++ b/xen/common/domain.c
> @@ -486,8 +486,7 @@ static int sanitise_domain_config(struct xen_domctl_c=
reatedomain *config)
>          ~(XEN_DOMCTL_CDF_hvm | XEN_DOMCTL_CDF_hap |
>            XEN_DOMCTL_CDF_s3_integrity | XEN_DOMCTL_CDF_oos_off |
>            XEN_DOMCTL_CDF_xs_domain | XEN_DOMCTL_CDF_iommu |
> -           XEN_DOMCTL_CDF_nested_virt | XEN_DOMCTL_CDF_vpci |
> -           XEN_DOMCTL_CDF_vpmu) )
> +           XEN_DOMCTL_CDF_nested_virt | XEN_DOMCTL_CDF_vpmu) )
>     {
>         dprintk(XENLOG_INFO, "Unknown CDF flags %#x\n", config->flags);
>         return -EINVAL;
> diff --git a/xen/include/public/domctl.h b/xen/include/public/domctl.h
> index a53cbd16f4..238384b5ae 100644
> --- a/xen/include/public/domctl.h
> +++ b/xen/include/public/domctl.h
> @@ -70,9 +70,8 @@ struct xen_domctl_createdomain {
> #define XEN_DOMCTL_CDF_iommu          (1U<<_XEN_DOMCTL_CDF_iommu)
> #define _XEN_DOMCTL_CDF_nested_virt   6
> #define XEN_DOMCTL_CDF_nested_virt    (1U << _XEN_DOMCTL_CDF_nested_virt)
> -#define XEN_DOMCTL_CDF_vpci           (1U << 7)
> /* Should we expose the vPMU to the guest? */
> -#define XEN_DOMCTL_CDF_vpmu           (1U << 8)
> +#define XEN_DOMCTL_CDF_vpmu           (1U << 7)
>=20
> /* Max XEN_DOMCTL_CDF_* constant.  Used for ABI checking. */
> #define XEN_DOMCTL_CDF_MAX XEN_DOMCTL_CDF_vpmu
> --=20
> 2.29.0
>=20
>=20



From xen-devel-bounces@lists.xenproject.org Thu Oct 14 09:04:16 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Oct 2021 09:04:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.209124.365474 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mawep-0004oC-6X; Thu, 14 Oct 2021 09:04:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 209124.365474; Thu, 14 Oct 2021 09:04:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mawep-0004o5-3A; Thu, 14 Oct 2021 09:04:11 +0000
Received: by outflank-mailman (input) for mailman id 209124;
 Thu, 14 Oct 2021 09:04:09 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=iCUr=PC=arm.com=Bertrand.Marquis@srs-us1.protection.inumbo.net>)
 id 1mawen-0004ny-BJ
 for xen-devel@lists.xenproject.org; Thu, 14 Oct 2021 09:04:09 +0000
Received: from EUR01-DB5-obe.outbound.protection.outlook.com (unknown
 [2a01:111:f400:fe02::61e])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id e57da790-d7b6-4c25-a7d2-3e8125ef714d;
 Thu, 14 Oct 2021 09:04:08 +0000 (UTC)
Received: from DB6P18901CA0018.EURP189.PROD.OUTLOOK.COM (2603:10a6:4:16::28)
 by HE1PR08MB2779.eurprd08.prod.outlook.com (2603:10a6:7:35::13) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.25; Thu, 14 Oct
 2021 09:03:51 +0000
Received: from DB5EUR03FT029.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:4:16:cafe::19) by DB6P18901CA0018.outlook.office365.com
 (2603:10a6:4:16::28) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15 via Frontend
 Transport; Thu, 14 Oct 2021 09:03:51 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT029.mail.protection.outlook.com (10.152.20.131) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.15 via Frontend Transport; Thu, 14 Oct 2021 09:03:51 +0000
Received: ("Tessian outbound 8e26f7114b75:v103");
 Thu, 14 Oct 2021 09:03:51 +0000
Received: from ed3cea30973c.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 A0DC61AA-F500-43FE-AB16-C4DA868C2A1F.1; 
 Thu, 14 Oct 2021 09:03:40 +0000
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id ed3cea30973c.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Thu, 14 Oct 2021 09:03:40 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com (2603:10a6:4:74::9)
 by DB6PR0801MB1863.eurprd08.prod.outlook.com (2603:10a6:4:76::17) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.25; Thu, 14 Oct
 2021 09:03:38 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955]) by DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955%4]) with mapi id 15.20.4587.030; Thu, 14 Oct 2021
 09:03:38 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e57da790-d7b6-4c25-a7d2-3e8125ef714d
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=XLGDjAc3JFjg+hdZbpcgepDYy0QyW8sv7eG82AXkwws=;
 b=gjwWO2ClpTM097XPoupAVbplALEffaFqX3ZJvTiDnxsEnddfSETU9+6336EVBaf7yMyICRSOMeFpzcTqZumB1adrcuVmI+1M2o8Jf3Mwrv5QNV5cfnCfzm6jFJf0cv3vX9PGKup1T5Pkgyq6C6hwcwSV/y/VUeM5yWyIoc8e91I=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 28fcb08830d55b90
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=C2J7sioixSCxYNv4VXENMDxvkhIntPhTl4t5tDTa129nqBkZth1kj1z5VZoVul9qZObhFFP+8ChEVeNY4UTFUKPLvuu3i5mP6BHXWLVHzgmCCY3t8fPS8JF2qpF46MJWmOLZgTIx0VcnzT9/w7Rej09bzGaymd1v8Dlu71YIjTIplHYpuq+z8j/Q7+aXPTcXgJW/u1hh0DvjgUu21XWpun3kPKtCkj7pd0CZ+mhUFLDVgQcf1g+kJZpfdemyvhuq+rfmGFmRB3AAs4eqQLn7cCAes8iGQxmndiyWyembZyND+iZYLFuiMyoS4mk8VRABPFA9IQP6jXjnd80PuR08Hw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=XLGDjAc3JFjg+hdZbpcgepDYy0QyW8sv7eG82AXkwws=;
 b=mhFg3pxSZG1gP+uElGUKNWiAcMdn+CseZwV2qw2VRlQOamQGVa1H4qM0+5kEmrGjNxI1yxJtiodJsmAyw+nBSmdMCP+k3mb44ukV7+5mMRL1ZZ3o91EfyhOMepP7fdIw7kcg6VE0hmfcrbuKn3U42dlyiJir6wExg56n/he80zt4xpBH7aecy74GF1k42/BUpurU9N3bI0LxzqZHR59D4pc32a4jXJJQUk5ryQRMT6jJDcFzb7pkrPT9ruGEc5LcLAx6L+ZWvMOdEgIdp8p/e82Rp6ZmSKSy+Mg9e2pWw2NO6TCi5n5eJGR9BZWz8QSBAeWwAY4w1gHBoEhFxLPjCA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=XLGDjAc3JFjg+hdZbpcgepDYy0QyW8sv7eG82AXkwws=;
 b=gjwWO2ClpTM097XPoupAVbplALEffaFqX3ZJvTiDnxsEnddfSETU9+6336EVBaf7yMyICRSOMeFpzcTqZumB1adrcuVmI+1M2o8Jf3Mwrv5QNV5cfnCfzm6jFJf0cv3vX9PGKup1T5Pkgyq6C6hwcwSV/y/VUeM5yWyIoc8e91I=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Stefano Stabellini <sstabellini@kernel.org>, Oleksandr Andrushchenko
	<Oleksandr_Andrushchenko@epam.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, Andre Przywara <Andre.Przywara@arm.com>,
	Julien Grall <julien@xen.org>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
	Rahul Singh <Rahul.Singh@arm.com>, George Dunlap <george.dunlap@citrix.com>,
	Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>, Paul Durrant
	<paul@xen.org>, =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>
Subject: Re: [PATCH v5 08/11] xen/arm: Enable the existing x86 virtual PCI
 support for ARM.
Thread-Topic: [PATCH v5 08/11] xen/arm: Enable the existing x86 virtual PCI
 support for ARM.
Thread-Index:
 AQHXutl3YqS5dHXsYk6KpdKt4d14RavQp5+AgABHSICAAB7yAIAABuOAgABGSACAALogAIAAKekA
Date: Thu, 14 Oct 2021 09:03:38 +0000
Message-ID: <72660561-2D8C-4D02-831B-E446A55B82F7@arm.com>
References: <cover.1633540842.git.rahul.singh@arm.com>
 <9bdca2cda5d2e83f94dc2423e55714273539760a.1633540842.git.rahul.singh@arm.com>
 <YWaco/UvA4xFE1xW@MacBook-Air-de-Roger.local>
 <6d75f604-6938-b185-61e1-a6684d9fca14@suse.com>
 <2b943774-072e-20a1-b97c-d88b24adf340@epam.com>
 <ed4876ca-7384-42a8-6fba-e73c1840402a@suse.com>
 <alpine.DEB.2.21.2110131223210.9408@sstabellini-ThinkPad-T480s>
 <fa345819-068d-0049-f0e8-8b96379b4247@suse.com>
In-Reply-To: <fa345819-068d-0049-f0e8-8b96379b4247@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3654.120.0.1.13)
Authentication-Results-Original: suse.com; dkim=none (message not signed)
 header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: 3b46f26a-06c0-4599-8bac-08d98ef18aa6
x-ms-traffictypediagnostic: DB6PR0801MB1863:|HE1PR08MB2779:
x-ms-exchange-transport-forked: True
X-Microsoft-Antispam-PRVS:
	<HE1PR08MB2779D1A1032F97CC946D6E649DB89@HE1PR08MB2779.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:9508;OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 ZcK79Iu02M1pz80nRkzIWT8J2CvdBgcyfPQ+yGt4GHW2aoKBHa7VJZOYUvMzgm+yRCffiNhd1iWYxzC86b9OpgOjMNAo6QtFGCwR4QrscKSpZi+ocIwT800Ut+m02nON4pYj+VoWFrFl1DHZCtBf6BZGJo95GJkbAJsm3bHORmKmM8sEKDd9loTadQmaF5gKyfWW0u3Y5HDsmWGNXqvELF8dgU0/ByTr85PNh3NBvUoRfgLjfP6OMHE6Orm4D5oYfK2nCOrQyMTC8ezmSzPC9tca9SukXYsX2keGstJXH1s1hf4ZQtvyPQp90IvRbv9EbcvT2N6cQU5iaF100gr8aiBaVH/aieeZBl4PlCmfBoytM9KLXFTcQHZQMc+bnYNr/COU6yYxTNeG7tVFmt9X7ABt0SVu7fiddKLrMFtZaJQWItSOcY/m8qzSEDgZRqkBeYjfQlOh05D3rwc/AGeEW/oP6fGRwGQs9ohX2MqEds+sYyLBNms5vYacdLLvcBT/9nAJZqT0Wr1wmtdMFxg9nteIKOc60FAY2gsr4TIhG12kPj0FkT9eqHbtvBOhCaKyn/HiQgE3bIlxVihVWv6wAqDoE2mbhEa5VePIEKJJeBK+a2c+phscwQ+329JE1Xu+MvBIE+YxnWJf4wryrjVkyuZwKooz0wo80ljib/HRmJQg75MIVyRuqoAuhgA8doomS7Alg9FYi10CP2e/FleNsBDR7BCaoNOuH1a8APpIDeVjRUzsFpP6ZPZIH2rk6den8qWHqHnS134ePnie4Gw5c9ZBlFLdGAB6RVTzWbGyUDWYy7A3bnshycPoTl8Y89H+wqPOz16Yv+tlfdZHbSIsYg==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB6PR0801MB2024.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(38070700005)(53546011)(66446008)(966005)(508600001)(86362001)(6506007)(66476007)(6512007)(66556008)(91956017)(8676002)(66946007)(76116006)(26005)(36756003)(54906003)(64756008)(6486002)(83380400001)(8936002)(33656002)(4326008)(6916009)(316002)(186003)(2906002)(7416002)(2616005)(71200400001)(122000001)(38100700002)(5660300002)(2004002)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-ID: <1AB0C09E1C757C4CA2FB86567794039E@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0801MB1863
Original-Authentication-Results: suse.com; dkim=none (message not signed)
 header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT029.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	e60852fb-0179-40ca-3cde-08d98ef18321
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Fl3elmZY3h6CM8ebusSnqU9xuIcdNDwzzqaB/BHT5D69nkcoxwEeNY+y5LNa4e0t7emmZP26vYA/DzfGK7tsfAOfbqo3MI/OPBALAi6+HABGeWOAQjxxuRsk6s0B6/7a/gslbm+CxihMv99+i/TKiiGOUYyLOIzrQCFjQpDDId00iBKArZAln09GyKlXvm5/TEoSXCNNNI+I3/tj56gEAr8EsDKlGViTvN5Zl5f90qBqnJp2mcKcCDx4BByA0LmdIXA5lCikgGyonn92gVNwFRqbPVk1rLUQ32flvrEAWxPNPMiTlax6mI0UBP/LAB6Rxl3rCQivUGB/LeP/CAx+f0AqGo42/BweMdiNn/QLcS/xRrT1DlV1RR4j59TlcM8W6js5hrUiHFwsml7F9xEwKQiCc9xQgXnDxYvd1lxoUiXYIgKDlrd0IwMcP9ofsIpKoUye4CQX/e5RZz8FPSspYeOcQLtv35EEb8+/yJ6AF1glyV8zzrVxiOn5E6HBb16EUCTesCd+2zmVwkqgdNcBgkrTuEvlEZXhCgrKVYQ7EXaRML5RaRfezK6GWlEyPNL1VImQE3Ar6yWHhDnt8tIYcVzv1ulM1hwRybXz6peIE34k967lF9gc/+ZCscD5tXsfI8ZrrTSXy9t9AT3KuzQNiaILzBGrmtgzuhB6DQSJMn2Fd8InwQsZhilnh8l2YOR7K/Bkvj3rRPD6Ce5CTg0TcIEhvVL7kA6Ni/HF0qvWZr+y2qxnY/N0xNigGsBlb2q8JksTEM6ZhnVxe4A8RFNYsRBhtDx/pKFFAUa0CZaS2HTi864MACYbb9yih43+rbRa
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(26005)(8936002)(316002)(82310400003)(186003)(336012)(107886003)(2906002)(70586007)(5660300002)(36860700001)(33656002)(54906003)(508600001)(6512007)(36756003)(6506007)(4326008)(2616005)(53546011)(966005)(8676002)(6486002)(47076005)(81166007)(70206006)(83380400001)(356005)(6862004)(86362001)(2004002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2021 09:03:51.3978
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 3b46f26a-06c0-4599-8bac-08d98ef18aa6
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT029.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR08MB2779

SGkgSmFuLA0KDQo+IE9uIDE0IE9jdCAyMDIxLCBhdCAwNzozMywgSmFuIEJldWxpY2ggPGpiZXVs
aWNoQHN1c2UuY29tPiB3cm90ZToNCj4gDQo+IE9uIDEzLjEwLjIwMjEgMjE6MjcsIFN0ZWZhbm8g
U3RhYmVsbGluaSB3cm90ZToNCj4+IE9uIFdlZCwgMTMgT2N0IDIwMjEsIEphbiBCZXVsaWNoIHdy
b3RlOg0KPj4+IE9uIDEzLjEwLjIwMjEgMTY6NTEsIE9sZWtzYW5kciBBbmRydXNoY2hlbmtvIHdy
b3RlOg0KPj4+PiBPbiAxMy4xMC4yMSAxNjowMCwgSmFuIEJldWxpY2ggd3JvdGU6DQo+Pj4+PiBP
biAxMy4xMC4yMDIxIDEwOjQ1LCBSb2dlciBQYXUgTW9ubsOpIHdyb3RlOg0KPj4+Pj4+IE9uIFdl
ZCwgT2N0IDA2LCAyMDIxIGF0IDA2OjQwOjM0UE0gKzAxMDAsIFJhaHVsIFNpbmdoIHdyb3RlOg0K
Pj4+Pj4+PiAtLS0gL2Rldi9udWxsDQo+Pj4+Pj4+ICsrKyBiL3hlbi9hcmNoL2FybS92cGNpLmMN
Cj4+Pj4+Pj4gQEAgLTAsMCArMSwxMDIgQEANCj4+Pj4+Pj4gKy8qDQo+Pj4+Pj4+ICsgKiB4ZW4v
YXJjaC9hcm0vdnBjaS5jDQo+Pj4+Pj4+ICsgKg0KPj4+Pj4+PiArICogVGhpcyBwcm9ncmFtIGlz
IGZyZWUgc29mdHdhcmU7IHlvdSBjYW4gcmVkaXN0cmlidXRlIGl0IGFuZC9vciBtb2RpZnkNCj4+
Pj4+Pj4gKyAqIGl0IHVuZGVyIHRoZSB0ZXJtcyBvZiB0aGUgR05VIEdlbmVyYWwgUHVibGljIExp
Y2Vuc2UgYXMgcHVibGlzaGVkIGJ5DQo+Pj4+Pj4+ICsgKiB0aGUgRnJlZSBTb2Z0d2FyZSBGb3Vu
ZGF0aW9uOyBlaXRoZXIgdmVyc2lvbiAyIG9mIHRoZSBMaWNlbnNlLCBvcg0KPj4+Pj4+PiArICog
KGF0IHlvdXIgb3B0aW9uKSBhbnkgbGF0ZXIgdmVyc2lvbi4NCj4+Pj4+Pj4gKyAqDQo+Pj4+Pj4+
ICsgKiBUaGlzIHByb2dyYW0gaXMgZGlzdHJpYnV0ZWQgaW4gdGhlIGhvcGUgdGhhdCBpdCB3aWxs
IGJlIHVzZWZ1bCwNCj4+Pj4+Pj4gKyAqIGJ1dCBXSVRIT1VUIEFOWSBXQVJSQU5UWTsgd2l0aG91
dCBldmVuIHRoZSBpbXBsaWVkIHdhcnJhbnR5IG9mDQo+Pj4+Pj4+ICsgKiBNRVJDSEFOVEFCSUxJ
VFkgb3IgRklUTkVTUyBGT1IgQSBQQVJUSUNVTEFSIFBVUlBPU0UuICBTZWUgdGhlDQo+Pj4+Pj4+
ICsgKiBHTlUgR2VuZXJhbCBQdWJsaWMgTGljZW5zZSBmb3IgbW9yZSBkZXRhaWxzLg0KPj4+Pj4+
PiArICovDQo+Pj4+Pj4+ICsjaW5jbHVkZSA8eGVuL3NjaGVkLmg+DQo+Pj4+Pj4+ICsNCj4+Pj4+
Pj4gKyNpbmNsdWRlIDxhc20vbW1pby5oPg0KPj4+Pj4+PiArDQo+Pj4+Pj4+ICsjZGVmaW5lIFJF
R0lTVEVSX09GRlNFVChhZGRyKSAgKCAoYWRkcikgJiAweDAwMDAwZmZmKQ0KPj4+Pj4+PiArDQo+
Pj4+Pj4+ICsvKiBEbyBzb21lIHNhbml0eSBjaGVja3MuICovDQo+Pj4+Pj4+ICtzdGF0aWMgYm9v
bCB2cGNpX21taW9fYWNjZXNzX2FsbG93ZWQodW5zaWduZWQgaW50IHJlZywgdW5zaWduZWQgaW50
IGxlbikNCj4+Pj4+Pj4gK3sNCj4+Pj4+Pj4gKyAgICAvKiBDaGVjayBhY2Nlc3Mgc2l6ZS4gKi8N
Cj4+Pj4+Pj4gKyAgICBpZiAoIGxlbiA+IDggKQ0KPj4+Pj4+PiArICAgICAgICByZXR1cm4gZmFs
c2U7DQo+Pj4+Pj4+ICsNCj4+Pj4+Pj4gKyAgICAvKiBDaGVjayB0aGF0IGFjY2VzcyBpcyBzaXpl
IGFsaWduZWQuICovDQo+Pj4+Pj4+ICsgICAgaWYgKCAocmVnICYgKGxlbiAtIDEpKSApDQo+Pj4+
Pj4+ICsgICAgICAgIHJldHVybiBmYWxzZTsNCj4+Pj4+Pj4gKw0KPj4+Pj4+PiArICAgIHJldHVy
biB0cnVlOw0KPj4+Pj4+PiArfQ0KPj4+Pj4+PiArDQo+Pj4+Pj4+ICtzdGF0aWMgaW50IHZwY2lf
bW1pb19yZWFkKHN0cnVjdCB2Y3B1ICp2LCBtbWlvX2luZm9fdCAqaW5mbywNCj4+Pj4+Pj4gKyAg
ICAgICAgICAgICAgICAgICAgICAgICAgcmVnaXN0ZXJfdCAqciwgdm9pZCAqcCkNCj4+Pj4+Pj4g
K3sNCj4+Pj4+Pj4gKyAgICB1bnNpZ25lZCBpbnQgcmVnOw0KPj4+Pj4+PiArICAgIHBjaV9zYmRm
X3Qgc2JkZjsNCj4+Pj4+Pj4gKyAgICB1bnNpZ25lZCBsb25nIGRhdGEgPSB+MFVMOw0KPj4+Pj4+
PiArICAgIHVuc2lnbmVkIGludCBzaXplID0gMVUgPDwgaW5mby0+ZGFidC5zaXplOw0KPj4+Pj4+
PiArDQo+Pj4+Pj4+ICsgICAgc2JkZi5zYmRmID0gTU1DRkdfQkRGKGluZm8tPmdwYSk7DQo+Pj4+
Pj4+ICsgICAgcmVnID0gUkVHSVNURVJfT0ZGU0VUKGluZm8tPmdwYSk7DQo+Pj4+Pj4+ICsNCj4+
Pj4+Pj4gKyAgICBpZiAoICF2cGNpX21taW9fYWNjZXNzX2FsbG93ZWQocmVnLCBzaXplKSApDQo+
Pj4+Pj4+ICsgICAgICAgIHJldHVybiAwOw0KPj4+Pj4+PiArDQo+Pj4+Pj4+ICsgICAgZGF0YSA9
IHZwY2lfcmVhZChzYmRmLCByZWcsIG1pbig0dSwgc2l6ZSkpOw0KPj4+Pj4+PiArICAgIGlmICgg
c2l6ZSA9PSA4ICkNCj4+Pj4+Pj4gKyAgICAgICAgZGF0YSB8PSAodWludDY0X3QpdnBjaV9yZWFk
KHNiZGYsIHJlZyArIDQsIDQpIDw8IDMyOw0KPj4+Pj4+PiArDQo+Pj4+Pj4+ICsgICAgKnIgPSBk
YXRhOw0KPj4+Pj4+PiArDQo+Pj4+Pj4+ICsgICAgcmV0dXJuIDE7DQo+Pj4+Pj4+ICt9DQo+Pj4+
Pj4+ICsNCj4+Pj4+Pj4gK3N0YXRpYyBpbnQgdnBjaV9tbWlvX3dyaXRlKHN0cnVjdCB2Y3B1ICp2
LCBtbWlvX2luZm9fdCAqaW5mbywNCj4+Pj4+Pj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAg
IHJlZ2lzdGVyX3Qgciwgdm9pZCAqcCkNCj4+Pj4+Pj4gK3sNCj4+Pj4+Pj4gKyAgICB1bnNpZ25l
ZCBpbnQgcmVnOw0KPj4+Pj4+PiArICAgIHBjaV9zYmRmX3Qgc2JkZjsNCj4+Pj4+Pj4gKyAgICB1
bnNpZ25lZCBsb25nIGRhdGEgPSByOw0KPj4+Pj4+PiArICAgIHVuc2lnbmVkIGludCBzaXplID0g
MVUgPDwgaW5mby0+ZGFidC5zaXplOw0KPj4+Pj4+PiArDQo+Pj4+Pj4+ICsgICAgc2JkZi5zYmRm
ID0gTU1DRkdfQkRGKGluZm8tPmdwYSk7DQo+Pj4+Pj4+ICsgICAgcmVnID0gUkVHSVNURVJfT0ZG
U0VUKGluZm8tPmdwYSk7DQo+Pj4+Pj4+ICsNCj4+Pj4+Pj4gKyAgICBpZiAoICF2cGNpX21taW9f
YWNjZXNzX2FsbG93ZWQocmVnLCBzaXplKSApDQo+Pj4+Pj4+ICsgICAgICAgIHJldHVybiAwOw0K
Pj4+Pj4+PiArDQo+Pj4+Pj4+ICsgICAgdnBjaV93cml0ZShzYmRmLCByZWcsIG1pbig0dSwgc2l6
ZSksIGRhdGEpOw0KPj4+Pj4+PiArICAgIGlmICggc2l6ZSA9PSA4ICkNCj4+Pj4+Pj4gKyAgICAg
ICAgdnBjaV93cml0ZShzYmRmLCByZWcgKyA0LCA0LCBkYXRhID4+IDMyKTsNCj4+Pj4+PiBJIHRo
aW5rIHRob3NlIHR3byBoZWxwZXJzIChhbmQgdnBjaV9tbWlvX2FjY2Vzc19hbGxvd2VkKSBhcmUg
dmVyeQ0KPj4+Pj4+IHNpbWlsYXIgdG8gdGhlIGV4aXN0aW5nIHg4NiBvbmVzIChzZWUgdnBjaV9t
bWNmZ197cmVhZCx3cml0ZX0pLCB1cCB0bw0KPj4+Pj4+IHRoZSBwb2ludCB3aGVyZSBJIHdvdWxk
IGNvbnNpZGVyIG1vdmluZyB0aGUgc2hhcmVkIGNvZGUgdG8gdnBjaS5jIGFzDQo+Pj4+Pj4gdnBj
aV9lY2FtX3tyZWFkLHdyaXRlfSBhbmQgY2FsbCB0aGVtIGZyb20gdGhlIGFyY2ggc3BlY2lmaWMg
dHJhcA0KPj4+Pj4+IGhhbmRsZXJzLg0KPj4+Pj4gRXhjZXB0IHRoYXQgcGxlYXNlIGNhbiB3ZSBz
dGljayB0byBtY2ZnIG9yIG1tY2ZnIGluc3RlYWQgb2YgZWNhbQ0KPj4+Pj4gaW4gbmFtZXMsIGFz
IHRoYXQncyBob3cgdGhlIHRoaW5nIGhhcyBiZWVuIG5hbWVkIGluIFhlbiBmcm9tIGl0cw0KPj4+
Pj4gaW50cm9kdWN0aW9uPyBJJ3ZlIGp1c3QgZ3JlcC1lZCB0aGUgY29kZSBiYXNlIChjYXNlIGlu
c2Vuc2l0aXZlbHkpDQo+Pj4+PiBhbmQgZm91bmQgbm8gbWVudGlvbiBvZiBFQ0FNLiBUaGVyZSBh
cmUgb25seSBhIGZldyAiYmVjYW1lIi4NCj4+Pj4gSSBkbyB1bmRlcnN0YW5kIHRoYXQgdGhpcyBp
cyBoaXN0b3JpY2FsbHkgdGhhdCB3ZSBkbyBub3QgaGF2ZSBFQ0FNIGluIFhlbiwNCj4+Pj4gYnV0
IFBDSSBpcyBub3QgYWJvdXQgWGVuLiBUaHVzLCBJIHRoaW5rIGl0IGlzIGFsc28gYWNjZXB0YWJs
ZSB0byB1c2UNCj4+Pj4gYSBjb21tb25seSBrbm93biBFQ0FNIGZvciB0aGUgY29kZSB0aGF0IHdv
cmtzIHdpdGggRUNBTS4NCj4+PiANCj4+PiBBQ1BJLCBhZmFpaywgYWxzbyBkb2Vzbid0IGNhbGwg
dGhpcyBFQ0FNLiBUaGF0J3Mgd2hlcmUgTUNGRyAvIE1NQ0ZHDQo+Pj4gYWN0dWFsbHkgY29tZSBm
cm9tLCBJIGJlbGlldmUuDQo+PiANCj4+IE15IHVuZGVyc3RhbmRpbmcgaXMgdGhhdCAiTUNGRyIg
aXMgdGhlIG5hbWUgb2YgdGhlIEFDUEkgdGFibGUgdGhhdA0KPj4gZGVzY3JpYmVzIHRoZSBQQ0kg
Y29uZmlnIHNwYWNlIFsxXS4gVGhlIHVuZGVybHlpbmcgUENJIHN0YW5kYXJkIGZvciB0aGUNCj4+
IG1lbW9yeSBtYXBwZWQgbGF5b3V0IG9mIHRoZSBQQ0kgY29uZmlnIHNwYWNlIGlzIGNhbGxlZCBF
Q0FNLiBIZXJlLCBpdA0KPj4gbWFrZXMgc2Vuc2UgdG8gY2FsbCBpdCBFQ0FNIGFzIGl0IGlzIGZp
cm13YXJlIGluZGVwZW5kZW50Lg0KPj4gDQo+PiBbMV0gaHR0cHM6Ly93aWtpLm9zZGV2Lm9yZy9Q
Q0lfRXhwcmVzcw0KPiANCj4gT2theSwgSSBjYW4gYWNjZXB0IHRoaXMsIGJ1dCB0aGVuIEknZCBl
eHBlY3QgYWxsIGV4aXN0aW5nIHVzZXMgb2YNCj4gTUNGRyAvIE1NQ0ZHIGluIHRoZSBjb2RlIHdo
aWNoIGFyZW4ndCBkaXJlY3RseSBBQ1BJLXJlbGF0ZWQgdG8gZ2V0DQo+IHJlcGxhY2VkLiBPdGhl
cndpc2UgaXQncyBuZWVkbGVzc2x5IGhhcmRlciB0byBpZGVudGlmeSB0aGF0IG9uZQ0KPiBwaWVj
ZSBvZiBjb2RlIHJlbGF0ZXMgdG8gY2VydGFpbiBvdGhlciBwaWVjZXMuDQoNCklmIHRoYXQgaXMg
b2sgd2l0aCBJIHdpbGw6DQotIG1vdmUgZnVuY3Rpb24gZnJvbSB4ODYvaHcvaW8uYyB0byB2cGNp
LmMgcmVuYW1pbmcgdGhlbSB0byBFQ0FNDQotIHJlbmFtZSBNTUNGR197QkRGL1JFR19PRkZTRVQp
IHRvIEVDQU1fe0JERi9SRUdfT0ZGU0VUfQ0KDQpGb3IgdGhlIHJlc3Qgb2YgdGhlIG9jY3VycmVu
Y2VzIGluIHg4NiBJIHdpbGwgbm90IG1vZGlmeSBhbnkgb2YgdGhlbSBhcyBzb21lDQphcmUgcmVs
YXRlZCB0byBBQ1BJIHNvIHVzaW5nIChNKU1DRkcgaXMgcmlnaHQgYW5kIGZvciB0aGUgb3RoZXJz
IEkgYW0gbm90IDEwMCUNCnN1cmUuDQoNCkRvIHlvdSBhZ3JlZSA/DQoNCkNoZWVycw0KQmVydHJh
bmQNCg0KPiANCj4gSmFuDQo+IA0KDQo=


From xen-devel-bounces@lists.xenproject.org Thu Oct 14 09:21:45 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Oct 2021 09:21:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.209135.365484 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mawvj-00074i-K3; Thu, 14 Oct 2021 09:21:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 209135.365484; Thu, 14 Oct 2021 09:21:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mawvj-00074b-H0; Thu, 14 Oct 2021 09:21:39 +0000
Received: by outflank-mailman (input) for mailman id 209135;
 Thu, 14 Oct 2021 09:21:39 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Xl23=PC=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mawvj-00074V-16
 for xen-devel@lists.xenproject.org; Thu, 14 Oct 2021 09:21:39 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 17131bab-b7f6-4744-bd6b-a5225be04f3e;
 Thu, 14 Oct 2021 09:21:38 +0000 (UTC)
Received: from EUR02-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur02lp2058.outbound.protection.outlook.com [104.47.4.58]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-14-8mQL9q-ZMAuZdcgQIbk3ag-1; Thu, 14 Oct 2021 11:21:36 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0401MB2607.eurprd04.prod.outlook.com (2603:10a6:800:58::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16; Thu, 14 Oct
 2021 09:21:35 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.016; Thu, 14 Oct 2021
 09:21:35 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS9PR06CA0360.eurprd06.prod.outlook.com (2603:10a6:20b:466::16) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15 via Frontend
 Transport; Thu, 14 Oct 2021 09:21:33 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 17131bab-b7f6-4744-bd6b-a5225be04f3e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634203297;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=Z3bck/rJCyy0kh/AKYB/Mhw0+Rt313zEVP2i6+Gm0bM=;
	b=WlGqzcuR8/qdg57p/12bdDQAt/xPJXj77MYfTGOGRVVoKsJwnR4zcY76Jdj35QGdEdmjNW
	lrXmvZCA4DsChVXzzlI1F5zTW5YiZbQlYh1jyXYIj5yDrl/8x8YTPKZAV+s/ahcB4+fzWP
	NoNjUvtLdg0cMYW5pfAqPhdQoCjtd2w=
X-MC-Unique: 8mQL9q-ZMAuZdcgQIbk3ag-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=icq/JSjqQCzvJ5DQYVHXJhu+jOnoTXBVmpljMQwqmHyLDEKIMdL51fe+PIw7TmiSamFmH9HSBuuhnjz0yDV326+kEGrdH9BdJGxNtAMIMBzA5/Qewp4BqjjJolpEq+3LFlnPtgJ/xxSojb80Zwv0MNJS40lJf6pLQbYmzsldpmWZQNalIqC1zEUaLLvKIsd2Dbf+/9foMk6APfpjDxuToc1Kd3u1Vpx8MeIDYDNngfeaPO5g/SKoS/T+DOor2RFvzib7x3zn0oX1OwBADGgGwzYyELl4y5az3iCXo6nl2GMwmg6/MFSZ70lwgVibqcDK4/3y9e5UuYqIQnyf78GHCA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Z3bck/rJCyy0kh/AKYB/Mhw0+Rt313zEVP2i6+Gm0bM=;
 b=oS2flVuBhuFKfSa5iyY43tzkdWDBUWfEA537hlrxbZCbDJGhn9hUdgkNyF2jMP5FxQxrRIE6km8JoBnqN9BfSOmLWQofBUkzfvZtKKNJpRaR6iI8rxILwyRNBDu8f34ApctZzlnlgc9Bn6q3lQ6qEtT7XdxEFCqHnfCryWoaAPJtkVeAfF5TflSYuQCjm1pnoKfCnDeHUPr46VkXhKZ35E/c+ZCC1qJL7mGC1LM42n280xHeROXEg9BHPWeKa6G8LU1pA3MW7MWR68wO+TqqUXMyCl0TMgOmHgYQ3dXkljNW69euuAgYT0RHQlMuyDWAh9RJgCPVrrglrqyUchfM7g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [XEN PATCH v7 43/51] build: replace $(BASEDIR) by $(objtree)
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
 Ross Lagerwall <ross.lagerwall@citrix.com>,
 Daniel De Graaf <dgdegra@tycho.nsa.gov>,
 "Daniel P. Smith" <dpsmith@apertussolutions.com>,
 xen-devel@lists.xenproject.org
References: <20210824105038.1257926-1-anthony.perard@citrix.com>
 <20210824105038.1257926-44-anthony.perard@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <0724e47f-09d5-ec35-a22e-428cefb9d9b5@suse.com>
Date: Thu, 14 Oct 2021 11:21:32 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <20210824105038.1257926-44-anthony.perard@citrix.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0360.eurprd06.prod.outlook.com
 (2603:10a6:20b:466::16) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 32cb99cb-b49e-4a98-f973-08d98ef40472
X-MS-TrafficTypeDiagnostic: VI1PR0401MB2607:
X-Microsoft-Antispam-PRVS:
	<VI1PR0401MB2607445745D8FA844F72032AB3B89@VI1PR0401MB2607.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	qc2ZdDgq6jvPWJOGwV5141Y+VPsWfyE+jrQ8ab1RzpZwf+jUOm/nN/aP9BhFEl10cnBl6JTANMsXsBk0eQpVQGIOdYvgcxqwn4U1gDq1uFE6eGvZ7xlgAleK3KF94msRAnomuJ4ebk493c17XGvroLfiVixBZRs+sjBPqZr7I9h0YKETrOJ31rvGLCJdcUfGHOWUlxZ5fQUpo4TRh1EheJ0mcpI+9395HGdOlRxz+mtXJIoI2WIGG3FrnOJL2T45FGQuYBVH4U2INVrTdZ0Pyo2Z90BkqBAlfXUkklG6wkNvbkYYCsTdVDXr5KuqTTICi2V4gt6VRZekxAhAlEiU60OBmEpDo0Eltu+JCsEyvL13INditgalniN/s5xkUFaTZFAs81Y7/RlZ6Lr0MP7mfTABeSbI/WVyJ/YGgSrxzwLaqQKkSMq2tZONfyZEOvh7wVWNRucG9iWLCK29YkIooYcPsIcgvqtlpKqYl27k7P+rbeczBAjaG0c9eMQEnXX2xSMMHy/SAtG8+3QqBfioa/tPhUUviJVFwHNqEdu2x+JE4DhsG9BX1+fTRI85nV0whMXGtG8qEkyFIzcZGPvPJUZvj06gCmNANpgQSiBqWo5yFDz+XV/g1CKQqiNgPznsRcQ4krZUxfgzEPuxygAmEYDNGvhQKGbS3f2dOtPdZoyvj+dNTp9WnYxvgIoSdaEIYPvYmLX8yyLnVo3XoEApg4jr/b6JK03XQ8Fh/DJ4/nTNlwBkwLHkh2yAEechNMzJ
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(54906003)(6486002)(16576012)(36756003)(26005)(5660300002)(53546011)(86362001)(2906002)(4744005)(316002)(31686004)(7416002)(508600001)(8936002)(6916009)(2616005)(38100700002)(66946007)(4326008)(66556008)(8676002)(66476007)(186003)(956004)(31696002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?S29LRHFyMy8xYUZQYzQrVzNoWkM1WHkrOGY4OFQwUjhhdzV6SUZtQ056Rm9o?=
 =?utf-8?B?eFByS0JHNmFUdnBJUEVxdnJEYlhSQWVBVDZzSTFySjRRZWVrZldoaGVXUU1t?=
 =?utf-8?B?bUt1R0x3MThCajVhMVloSG5vd0pySVByYStFNG1rRDlsMVF1MEZmUU9xQkJX?=
 =?utf-8?B?NFF2eWNsZC9aNzZuZFYyWTB0MWo2ay9kQXFzV1BrcDkvMEJhSXdTbDhjT2NR?=
 =?utf-8?B?VG9DOXVHbTlaWXNWaVJRa2hqaWRSZEZ0UjNhTnpBM012cTA1VlFtSnpHdjRH?=
 =?utf-8?B?NnFtdFRBT1FvUWM4TURaUXd0K1NRRE8vVzNobFFZd0FiVEd5VDNWeFpFeEYr?=
 =?utf-8?B?RC9mUW5rVWtiU0h2K1NzUFZWbFBrVGxpN2RLQmxXdmZuSXMxMWoyWEw2RVVr?=
 =?utf-8?B?amxOVUE0eVkwQmRocE5WcG1IVXFvblVFR3lrN1BYMFVjaHQvRmh4ZTRzSjJk?=
 =?utf-8?B?QXNTSWlBd0g3WTJjVTliUXNJZzg5cjd5V01LeHFoYlVpS0kxUmRYeGxka1Qw?=
 =?utf-8?B?ZzE3K1U3Ujc2dHc3ZmRSUlZjSHJwekxwQ0FEL3UxVHBVcU1UWTJMcTdkdEph?=
 =?utf-8?B?dDhXc0VJZ0xnMUkrZDNBNy9ubEk0QUpmNE93SFY4WnJvZTRyVVdGSTZwWCsw?=
 =?utf-8?B?MGQzYXk5bUc2MDlBV0VmUVZiUE1hc2tudEc5T3A2SENCNUxWSWpTMnBoNmhT?=
 =?utf-8?B?bWJKQ3AzcG1ZRmJ6aXRnUEtMWGdDMERuejlyWDYraXpBTEcxanVJM2ExZ0Vm?=
 =?utf-8?B?ZlA0Yzd3Z1FXMHNsbXdWUitydFJvK05lcm5ua3lmOWtHVHZaNmIwSjdHVWIy?=
 =?utf-8?B?bXJQcVR4OEhlTGcxdi9RckJ0aXJnU0VXeUk1YUpicnVDK3FUOHU2Zm5OM1pH?=
 =?utf-8?B?QTRVRFNJcDNzb1pydm8vdEIxTzdPR2ZoRExjcTlPZDRtdTJFYkxwcXc1Q1lH?=
 =?utf-8?B?ZXhuNnp3U2FaRHBoNXc3UzI5K2lOa2VCR1h0WE9vZERnMks2NG5ZRE9GZWlT?=
 =?utf-8?B?aVRxZ3JZOHRoc0s2TWZGYjRJZ0ViMGhxZVJxaEc4Qkp3NldWb0hKVFc2eGhY?=
 =?utf-8?B?RS95a1dBN2p5RHRjZVUyeTIrK2p0WlFhdk1CdU5VczV6N3cvT1VIUEpaVWQ3?=
 =?utf-8?B?d0ZINDJxQVZKeGxhWEhNSkVPV3dOYzRPbTVmcXJLUityZWFFaXFVVE40QzBO?=
 =?utf-8?B?Z0JqcFdZekxJSnlLTGhOU0NUZ2R0Rm92SHd5U2RCTGZJc2hoU2RBNytuZ0xH?=
 =?utf-8?B?elBpMUkzMVRkZTZYREsrSEIyK24wN0I5bzhsdTFoaThrRFRNRzRvWXllaS90?=
 =?utf-8?B?cWRzcGtuZHUxQ1d4WjNtcUpKMjdPeUpSeU9EZ1RrSWl0dlRLS0FvT1JXemZp?=
 =?utf-8?B?Tm5ic3J1MVgvaUQvVzhEMk0yQ0dMa2xKbTZmdDhOODVicFF6NWhIM1YyMFY0?=
 =?utf-8?B?MVRTdkU1aFh4VTMzRlAvQlJFMDdINTgxdW9IeU4wMi9hWVRyb3pzdE85TkNQ?=
 =?utf-8?B?NkNqWllEcnFDdUxtcWRoMGNnMVdMY25yUWJ6NWI3ZEJ5NTNDWUlxMzkyL2Vj?=
 =?utf-8?B?bTMwSDNqMEN4bXZnTXY5SXVIZndVNUJQR1Eva1dqTVRMeVFjRnZTMnFHZ2Zq?=
 =?utf-8?B?Z3kxam95dWdFdjA3cGwvRU01dUI4YUJnS3E5R04zMEFtYlc5UVpjZ3dkdkxZ?=
 =?utf-8?B?VlcrVjVlZ0FyV3FVdHpKdUN3NlFFSElJeXFwem1HYW1xSzQwRW9KdkNmaTRQ?=
 =?utf-8?Q?BYACqFFb8UolspnSe2eqT3A/Uwz6yOjOIU/u5+R?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 32cb99cb-b49e-4a98-f973-08d98ef40472
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2021 09:21:34.8473
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Za5AolrCWg6zCpdxdOPTULXCpthdAwyHl9Tya9uZW/rd4zyZ8+0q2FX2XrdSROp16a4q4dVjZw/7QALhWdmZQw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2607

On 24.08.2021 12:50, Anthony PERARD wrote:
> We need to differentiate between source files and generated/built
> files. We will be replacing $(BASEDIR) by $(objtree) for files that
> are generated, and $(abs_objtree) in cases where an absolute path is
> necessary.
> 
> The "clean" target is still changing to the subdir been cleaned, to
> remove file in the root we need to use $(abs_objtree).

Vaguely related more general question: How useful is "clean" for an
out-of-tree build? That ought to effectively remove the entire build
tree, which may not be overly sensible to do via "make clean-xen",
but instead simply "rm -rf ...".

> @@ -117,4 +117,4 @@ $(obj)/dtb.o: $(patsubst "%",%,$(CONFIG_DTB_FILE))
>  .PHONY: clean
>  clean::
>  	rm -f $(obj)/xen.lds
> -	rm -f $(BASEDIR)/.xen-syms.[0-9]*
> +	rm -f $(abs_objtree)/.xen-syms.[0-9]*

This part is common - would it make sense to move to xen/Makefile, thus
- aiui - eliminating the need for using $(abs_objtree) here / there?

Jan



From xen-devel-bounces@lists.xenproject.org Thu Oct 14 09:24:34 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Oct 2021 09:24:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.209143.365496 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mawyY-0007gp-38; Thu, 14 Oct 2021 09:24:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 209143.365496; Thu, 14 Oct 2021 09:24:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mawyX-0007gi-WF; Thu, 14 Oct 2021 09:24:34 +0000
Received: by outflank-mailman (input) for mailman id 209143;
 Thu, 14 Oct 2021 09:24:32 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Xl23=PC=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mawyW-0007ga-Do
 for xen-devel@lists.xenproject.org; Thu, 14 Oct 2021 09:24:32 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 8902089a-2cd0-11ec-81b7-12813bfff9fa;
 Thu, 14 Oct 2021 09:24:31 +0000 (UTC)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2104.outbound.protection.outlook.com [104.47.18.104])
 (Using TLS) by relay.mimecast.com with ESMTP id
 de-mta-28-aYdKigpaM5u0gBcgs7VH7g-1; Thu, 14 Oct 2021 11:24:29 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0401MB2608.eurprd04.prod.outlook.com (2603:10a6:800:4f::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15; Thu, 14 Oct
 2021 09:24:27 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.016; Thu, 14 Oct 2021
 09:24:27 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM5PR1001CA0063.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:206:15::40) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15 via Frontend
 Transport; Thu, 14 Oct 2021 09:24:26 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8902089a-2cd0-11ec-81b7-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634203470;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=GZLj66i6hGY5I84DeWR3QtUUvJ/2qUv2IIcOobyKT/k=;
	b=jM1mmNIb0nhets2pBZAg4oUvJV87TeNsFShYNJSo5PHf2gnkB5h9tTBz0s1fe5HWWtOpfs
	w5v9IfOCaO9Z7unrU2gni4AOERUjifiAoRw3EHye2/b1G3NaJa/9dhzFYCc+usAP5jcgn4
	xkq1eRDIKUooCXtcSk343czXgx+YCmI=
X-MC-Unique: aYdKigpaM5u0gBcgs7VH7g-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=RjfjxoaiPJdTQGPsZGauXT3Dv2RtnD3iS2hdMlkIm7MpboXhZQotplAO0g8ZBhFV1QpABOSBdfsUW9/F9Zj94J6/iZOkhxDxsXYW4zAG8NyjJPFPsVRuM6AywT2yh0jv/ayDutrS7ugcfvuVwEZXrtRyMS/AtYxex4CCtPLxvGJAHt+9x1gKqlSjQy2dS6RxfB4d6Yy3MBecOLm61IX+GgstUSZKA7QXcsd4+lyPAeBF8B9nl5IsFoQLlCi3HrTE1ejcOrlyqpkKcrntnlqPlo0sQ/0vgX8kY4zYPE/7nBxJVA0KifSRMRnc/jdR+VopKuaNab1QNGkdfiLjIDOdMw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=+9rrDq5Fv2o9T1u0FTRQ51evMDzS1qw2OXOKETvbK+U=;
 b=ijW0WSVtpGGixKkz1QV0H5ag65xqx6aNLt92NpNWB1nSkgznh+uqUTGCNo62JvpVFREj2f0XTwfWle6hRh5du8V8MkZe3n5l8PjDKpBRtIpefXnC2IP9mNar42iGCQGLAmPVVeQWucKVQfcEMjjwWb86uk4Ptlqmi41u/CFmysTdXjFd2aKoxmjxc4jl9JbL9mOuBxeMB9smuEWTxvN5Bau8FJfAWOuqxc4xpU5SYEaFGd6cxKFtYF44MIEPnAlBFVO2blMj1zKJyHlXZURyRTE/PaDXpj8SNbxRpZuxJpvbceofhzo+8bugOPEfti8JGwbpgm4PJ+jCqeWGGkhXFA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: citrix.com; dkim=none (message not signed)
 header.d=none;citrix.com; dmarc=none action=none header.from=suse.com;
Subject: Re: [PATCH v5 08/11] xen/arm: Enable the existing x86 virtual PCI
 support for ARM.
To: Bertrand Marquis <Bertrand.Marquis@arm.com>
CC: Stefano Stabellini <sstabellini@kernel.org>,
 Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andre Przywara <Andre.Przywara@arm.com>, Julien Grall <julien@xen.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Rahul Singh
 <Rahul.Singh@arm.com>, George Dunlap <george.dunlap@citrix.com>,
 Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>,
 Paul Durrant <paul@xen.org>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>
References: <cover.1633540842.git.rahul.singh@arm.com>
 <9bdca2cda5d2e83f94dc2423e55714273539760a.1633540842.git.rahul.singh@arm.com>
 <YWaco/UvA4xFE1xW@MacBook-Air-de-Roger.local>
 <6d75f604-6938-b185-61e1-a6684d9fca14@suse.com>
 <2b943774-072e-20a1-b97c-d88b24adf340@epam.com>
 <ed4876ca-7384-42a8-6fba-e73c1840402a@suse.com>
 <alpine.DEB.2.21.2110131223210.9408@sstabellini-ThinkPad-T480s>
 <fa345819-068d-0049-f0e8-8b96379b4247@suse.com>
 <72660561-2D8C-4D02-831B-E446A55B82F7@arm.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <8394bf58-5778-83f3-b23c-25f69a545c78@suse.com>
Date: Thu, 14 Oct 2021 11:24:24 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <72660561-2D8C-4D02-831B-E446A55B82F7@arm.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM5PR1001CA0063.EURPRD10.PROD.OUTLOOK.COM
 (2603:10a6:206:15::40) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: cde39c09-8013-446a-73b2-08d98ef46b1e
X-MS-TrafficTypeDiagnostic: VI1PR0401MB2608:
X-Microsoft-Antispam-PRVS:
	<VI1PR0401MB2608DFD373F281FFA9BDF1AEB3B89@VI1PR0401MB2608.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Az49k7xSU9OuPC9f4aUStAgeqZ8FcJte0VxYYpe+6tlXtOEpI+fqhbtcG27uRYlHFmGXa0wb/yijlrHtKpVxZGeRMKBhqf05SZeLEpE5LXdA4LhOOOCgucV2Eqc5T96U6rOh1odN0lV5L7RVQPfLnHHp55y16IgkKyXNvwkvFVOltK5VZ/C3UYdCgbIqW/nl/WFQ8ogGtBY4HZTBMdTHn8jK6C4vmaWNHr8yp3iB/DydfLhoQKPK29Mb3dc1a3OJFXVsfZdfHJAw7GprrL9pBUAYV1PB8N6g4I5L/HytZnEXB5Ckc8plT0/12fn9h9OYMiXvqCXABNdej/7SnEE7sUBcEy3TAfgrAuR8SYIoaI5qQRcnVYn0+nkubBFFUV1pThKM/yMrFJPFAeCSG68cREjMJ7gTmiSCkWZ4FDS7qTcEXb/i3HbUxYsCSNT0VjSyyuwelFGDslj7TCQnWEPY18D6m4v1PcND4xaUjMdDRwlNiVGlowCjgQT8GmwqCGlxvWfRecHGcV4auPsnWfzCek7p20Q3AO3keI5xR5GK/ptP4vRxH/2hEUQdujYokBXJMFKD7oSt/c0brQL/E32C2Y3DD+uYPSRQBqx/PcmOpF6DhToAZ3jgpJVwEmJlfZkDxCtOCecR64Wvneo2J+D+AejfwpKN1tNKSe96a5nWxUh+tEPGX5uBOdnJSr+HoHaQuzpgQJL9f0Z6O9KtiR6zFqna7INRUs6cRNnAayZqENK8j2Pq7xSKjEp6yOp09ZJdBJg4C6MDcM4zYpfkWwamlqWdjP81p/OOwCAbPyy5tm12cGGLc0VQ/SRzxyFuIK6HUtN8Bw1OgbuNn/LINV8FJg==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(36756003)(966005)(31686004)(54906003)(16576012)(508600001)(2616005)(2906002)(5660300002)(6486002)(316002)(956004)(31696002)(66946007)(66476007)(86362001)(66556008)(186003)(53546011)(38100700002)(4326008)(8676002)(6916009)(8936002)(26005)(7416002)(83380400001)(2004002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?EbEkEr5ecpUNKbeNNwQPe/0y309ilwdyB2H+TyNzCIWEsqLc5049veye7afm?=
 =?us-ascii?Q?vGm5HU0gw5Osp+It94aix1jmv1lRbtHmpaC1YW3CaXWoIdx4MOUZCkLdwNqS?=
 =?us-ascii?Q?kkfO/Y3hSERFcY6o0IOxuTMlQnaZgIWp/XqENRwBXjumST9xbNoDQUtcenUz?=
 =?us-ascii?Q?QjxC3xNAj+VwNI6N6oWQgwp/1YXglbK3fMj0oyB8XaCEK+xAqtZ9mEbg3F9j?=
 =?us-ascii?Q?YT7mDEOdgAqrliGt2U9E6kZv8BPLD/atVAe3TOX+znzBbjprCy7AD1NLpIrY?=
 =?us-ascii?Q?VWCbSJFAP+jk1u2R6m7WZfl1y93K6rJJXiNT3+XFDR8+rTpgMV84jbCEiEFV?=
 =?us-ascii?Q?9+1Wzyvnriu8LCBwTZ4FLYKfgTH6uheq84gQRST39AMWBS7zeKf3cza55Dyl?=
 =?us-ascii?Q?52R+sMWfQ25z3fyHmOlzs2elNbfg60m0sXOSbleBWy5Ix/sgkW7DChAPa8fw?=
 =?us-ascii?Q?dWUEhsKqhKDvA6xo6Ed5yW2Cn7tnktidS324qEe9/EEYwb4MROnAcHPzqCdC?=
 =?us-ascii?Q?TAoY72I8e9yZ6j/X02IbrZsK4nn1NIFmXWbDkoyvyzGNY93/OtWthmndeY7G?=
 =?us-ascii?Q?eYJUmrGHkGIniob805L43Fjd+iNf/casUjLOFWoLsC66hNNp8xxmwVYo1ZHZ?=
 =?us-ascii?Q?n2wQG7ekJFf3d9VAyztMNeDrFJKnGh3DNIFRDObtEgTdyW3PAh4MvsVzElz5?=
 =?us-ascii?Q?Q4T0p3e7oxJkb3jAEAd9tMeo67BYRIgZboAog3HOCBoC2XCpSYJv3WvZTguu?=
 =?us-ascii?Q?oKVACa1TKqR48mvrvt6sVueiYI8V+4KT/EuQljt/1wBfrgl4glmHoOfTVKU2?=
 =?us-ascii?Q?w874Dsdauklu0sWVWQ3nt02842Xx/7Cz7hZDDiOsbliQXaM/vDhjfyBCyJ2U?=
 =?us-ascii?Q?eEew130CKz3tGe9hCUPxasOoYvykKf7ZVcg7xG+AGdmVhjFT8yrO4xjvDdlI?=
 =?us-ascii?Q?QRqUqz4+Yd7qe/8Ye4nW3F2AG6LUbXNdpPBN+SCWvI37R+U9DjdL/FZCYGHj?=
 =?us-ascii?Q?HnEVhq0up/WaUUa4UbVvJ6PmHAJjaAHczO3MozLePTRgagTS3eEHyz3ebzhk?=
 =?us-ascii?Q?4F1SeSdHKNwKfNHqQHuRIyS2NPrRyFvtp/X8dj+FwUJg0waC0c0rdoWS4Roe?=
 =?us-ascii?Q?6McoqW0yFMDjhm1cJvxPGfSZVUdD+yDpe5Ws+PQcTHcxtCP4TUge0+27txvJ?=
 =?us-ascii?Q?bvLWOIQLzC6YMWx97NPTtdu5X+y48tlEfDdv8J3vNhRfLn8DtGTEAXbFP9rs?=
 =?us-ascii?Q?WNPFYLHMBK7VclsAGifBmtoKUihfcBBH5bdAKhHaPX2mrVLI+hxp5MPd4n3w?=
 =?us-ascii?Q?1zmN9NovBTzyRtFk2Eh61fwP?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cde39c09-8013-446a-73b2-08d98ef46b1e
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2021 09:24:27.1557
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ShGQ1iTFOLvWRfnZN/WQO/Lfv7sg7at0oaGRQUZhpjuGRCffdnuGlDXohF3A55tWjiNZjnkvl784SmO+/UHAdA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2608

On 14.10.2021 11:03, Bertrand Marquis wrote:
> Hi Jan,
>=20
>> On 14 Oct 2021, at 07:33, Jan Beulich <jbeulich@suse.com> wrote:
>>
>> On 13.10.2021 21:27, Stefano Stabellini wrote:
>>> On Wed, 13 Oct 2021, Jan Beulich wrote:
>>>> On 13.10.2021 16:51, Oleksandr Andrushchenko wrote:
>>>>> On 13.10.21 16:00, Jan Beulich wrote:
>>>>>> On 13.10.2021 10:45, Roger Pau Monn=C3=A9 wrote:
>>>>>>> On Wed, Oct 06, 2021 at 06:40:34PM +0100, Rahul Singh wrote:
>>>>>>>> --- /dev/null
>>>>>>>> +++ b/xen/arch/arm/vpci.c
>>>>>>>> @@ -0,0 +1,102 @@
>>>>>>>> +/*
>>>>>>>> + * xen/arch/arm/vpci.c
>>>>>>>> + *
>>>>>>>> + * This program is free software; you can redistribute it and/or =
modify
>>>>>>>> + * it under the terms of the GNU General Public License as publis=
hed by
>>>>>>>> + * the Free Software Foundation; either version 2 of the License,=
 or
>>>>>>>> + * (at your option) any later version.
>>>>>>>> + *
>>>>>>>> + * This program is distributed in the hope that it will be useful=
,
>>>>>>>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
>>>>>>>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>>>>>>>> + * GNU General Public License for more details.
>>>>>>>> + */
>>>>>>>> +#include <xen/sched.h>
>>>>>>>> +
>>>>>>>> +#include <asm/mmio.h>
>>>>>>>> +
>>>>>>>> +#define REGISTER_OFFSET(addr)  ( (addr) & 0x00000fff)
>>>>>>>> +
>>>>>>>> +/* Do some sanity checks. */
>>>>>>>> +static bool vpci_mmio_access_allowed(unsigned int reg, unsigned i=
nt len)
>>>>>>>> +{
>>>>>>>> +    /* Check access size. */
>>>>>>>> +    if ( len > 8 )
>>>>>>>> +        return false;
>>>>>>>> +
>>>>>>>> +    /* Check that access is size aligned. */
>>>>>>>> +    if ( (reg & (len - 1)) )
>>>>>>>> +        return false;
>>>>>>>> +
>>>>>>>> +    return true;
>>>>>>>> +}
>>>>>>>> +
>>>>>>>> +static int vpci_mmio_read(struct vcpu *v, mmio_info_t *info,
>>>>>>>> +                          register_t *r, void *p)
>>>>>>>> +{
>>>>>>>> +    unsigned int reg;
>>>>>>>> +    pci_sbdf_t sbdf;
>>>>>>>> +    unsigned long data =3D ~0UL;
>>>>>>>> +    unsigned int size =3D 1U << info->dabt.size;
>>>>>>>> +
>>>>>>>> +    sbdf.sbdf =3D MMCFG_BDF(info->gpa);
>>>>>>>> +    reg =3D REGISTER_OFFSET(info->gpa);
>>>>>>>> +
>>>>>>>> +    if ( !vpci_mmio_access_allowed(reg, size) )
>>>>>>>> +        return 0;
>>>>>>>> +
>>>>>>>> +    data =3D vpci_read(sbdf, reg, min(4u, size));
>>>>>>>> +    if ( size =3D=3D 8 )
>>>>>>>> +        data |=3D (uint64_t)vpci_read(sbdf, reg + 4, 4) << 32;
>>>>>>>> +
>>>>>>>> +    *r =3D data;
>>>>>>>> +
>>>>>>>> +    return 1;
>>>>>>>> +}
>>>>>>>> +
>>>>>>>> +static int vpci_mmio_write(struct vcpu *v, mmio_info_t *info,
>>>>>>>> +                           register_t r, void *p)
>>>>>>>> +{
>>>>>>>> +    unsigned int reg;
>>>>>>>> +    pci_sbdf_t sbdf;
>>>>>>>> +    unsigned long data =3D r;
>>>>>>>> +    unsigned int size =3D 1U << info->dabt.size;
>>>>>>>> +
>>>>>>>> +    sbdf.sbdf =3D MMCFG_BDF(info->gpa);
>>>>>>>> +    reg =3D REGISTER_OFFSET(info->gpa);
>>>>>>>> +
>>>>>>>> +    if ( !vpci_mmio_access_allowed(reg, size) )
>>>>>>>> +        return 0;
>>>>>>>> +
>>>>>>>> +    vpci_write(sbdf, reg, min(4u, size), data);
>>>>>>>> +    if ( size =3D=3D 8 )
>>>>>>>> +        vpci_write(sbdf, reg + 4, 4, data >> 32);
>>>>>>> I think those two helpers (and vpci_mmio_access_allowed) are very
>>>>>>> similar to the existing x86 ones (see vpci_mmcfg_{read,write}), up =
to
>>>>>>> the point where I would consider moving the shared code to vpci.c a=
s
>>>>>>> vpci_ecam_{read,write} and call them from the arch specific trap
>>>>>>> handlers.
>>>>>> Except that please can we stick to mcfg or mmcfg instead of ecam
>>>>>> in names, as that's how the thing has been named in Xen from its
>>>>>> introduction? I've just grep-ed the code base (case insensitively)
>>>>>> and found no mention of ECAM. There are only a few "became".
>>>>> I do understand that this is historically that we do not have ECAM in=
 Xen,
>>>>> but PCI is not about Xen. Thus, I think it is also acceptable to use
>>>>> a commonly known ECAM for the code that works with ECAM.
>>>>
>>>> ACPI, afaik, also doesn't call this ECAM. That's where MCFG / MMCFG
>>>> actually come from, I believe.
>>>
>>> My understanding is that "MCFG" is the name of the ACPI table that
>>> describes the PCI config space [1]. The underlying PCI standard for the
>>> memory mapped layout of the PCI config space is called ECAM. Here, it
>>> makes sense to call it ECAM as it is firmware independent.
>>>
>>> [1] https://wiki.osdev.org/PCI_Express
>>
>> Okay, I can accept this, but then I'd expect all existing uses of
>> MCFG / MMCFG in the code which aren't directly ACPI-related to get
>> replaced. Otherwise it's needlessly harder to identify that one
>> piece of code relates to certain other pieces.
>=20
> If that is ok with I will:
> - move function from x86/hw/io.c to vpci.c renaming them to ECAM
> - rename MMCFG_{BDF/REG_OFFSET) to ECAM_{BDF/REG_OFFSET}
>=20
> For the rest of the occurrences in x86 I will not modify any of them as s=
ome
> are related to ACPI so using (M)MCFG is right and for the others I am not=
 100%
> sure.
>=20
> Do you agree ?

Probably not, but I don't want to put time into checking existing
names right now. Yet I'm getting the impression that I'm being
overruled here anyway, so there may be little point in investing any
time here in the first place.

Jan



From xen-devel-bounces@lists.xenproject.org Thu Oct 14 09:26:13 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Oct 2021 09:26:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.209151.365507 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1max09-0008MX-JM; Thu, 14 Oct 2021 09:26:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 209151.365507; Thu, 14 Oct 2021 09:26:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1max09-0008MQ-G3; Thu, 14 Oct 2021 09:26:13 +0000
Received: by outflank-mailman (input) for mailman id 209151;
 Thu, 14 Oct 2021 09:26:11 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Xl23=PC=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1max07-0008MK-QO
 for xen-devel@lists.xenproject.org; Thu, 14 Oct 2021 09:26:11 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 7eb561c5-09eb-4c32-aca1-273e167621cd;
 Thu, 14 Oct 2021 09:26:11 +0000 (UTC)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2110.outbound.protection.outlook.com [104.47.18.110])
 (Using TLS) by relay.mimecast.com with ESMTP id
 de-mta-21-VCD5haOkMICCyBN2iuL37A-1; Thu, 14 Oct 2021 11:26:09 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0401MB2608.eurprd04.prod.outlook.com (2603:10a6:800:4f::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15; Thu, 14 Oct
 2021 09:26:08 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.016; Thu, 14 Oct 2021
 09:26:08 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6PR05CA0024.eurprd05.prod.outlook.com (2603:10a6:20b:2e::37) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.16 via Frontend Transport; Thu, 14 Oct 2021 09:26:07 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7eb561c5-09eb-4c32-aca1-273e167621cd
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634203570;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=OSayV8mUzZhvPOGzXRpilHnq89NQN7lboAV7GkhCB9Y=;
	b=deqYxYE0m3VppC0rKxRqxrAo2o0qDoq+AOBR4Q2hhsygJcdK6H/nmcbKC56/5BWIzmwYTo
	H9xU4J6kxCIC/6V3VlEQKD2UvQwsiUEbzhVBrJ0aMQpdeGgxdeVX+pcexLoguaiyUaw4ri
	BxQI6PWGvBi4sWiy63RLgq+ZBQcEq9Y=
X-MC-Unique: VCD5haOkMICCyBN2iuL37A-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=DEVnPywkeF476qBiYey+9sq00hQydJXf7DlBNbmL6QRxtdGvB2NEZ8qAMY0uka8M6ZIjyc1fuGZHIx0LQfcZWGoEYmPCQBZxHUtgzNU5EfzeAZVZmFrNTJ1YAPb3bHRm4QH+965FPG0IJUlPpAZJvMH1USMNKKwKvUtxR69AL9ySmuveadjl7U7tQY2t/CZjrdAG7RR+jbrZX8OQ7528qCqGcqmT0abjVJS7cfCtny140BPNqCyA8LRTjWgeqvcYK1f+P+fXR0USALnHTnesjhUebKhRbg09zrUrG9FsOJzVlbM9x7TsvbqVTA7ykT7TnvCBIifYfwgUBW25NvH35w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=OSayV8mUzZhvPOGzXRpilHnq89NQN7lboAV7GkhCB9Y=;
 b=GF0NDUbtPUgehk9jfaIsjGSNP2CWvOSxqCo4spAQ7wyWidS0IbolLFsran4oMUs755aiy4z6AVXJR54ZLd4lmc34LkfkBr13MIRNTIs10XN/tnbspJzS2U3wyqsD3DUyyFCSDgIYOAOX3S7luLIvuVaX7cEVZQuZzkLq/DU7msOabp1NVybQ7xHVfjZSoLzWfoWV3+lhnljVR3cToKtu4pvLdiIktRVeW1hcTOrK0paPSYizKFJz0Lnpgo+oA6lYqHrDCNkvUHKC/USnkI5PUEiwnGZ/wSdtx7bn9Nz8nKtDASagGV3gFv1wzcUyNK6MAiP0AxlTLrnjpGlEdLJeQg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [XEN PATCH v7 44/51] build: add $(srctree) in few key places
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>, Wei Liu
 <wl@xen.org>, George Dunlap <george.dunlap@citrix.com>,
 Ian Jackson <iwj@xenproject.org>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Daniel De Graaf <dgdegra@tycho.nsa.gov>,
 "Daniel P. Smith" <dpsmith@apertussolutions.com>,
 xen-devel@lists.xenproject.org
References: <20210824105038.1257926-1-anthony.perard@citrix.com>
 <20210824105038.1257926-45-anthony.perard@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <187631b9-923f-9710-2c3e-208c464a3202@suse.com>
Date: Thu, 14 Oct 2021 11:26:05 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <20210824105038.1257926-45-anthony.perard@citrix.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR05CA0024.eurprd05.prod.outlook.com
 (2603:10a6:20b:2e::37) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: f0ffebae-abf9-4af3-75e0-08d98ef4a73d
X-MS-TrafficTypeDiagnostic: VI1PR0401MB2608:
X-Microsoft-Antispam-PRVS:
	<VI1PR0401MB260833580F53296E11A21F94B3B89@VI1PR0401MB2608.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:361;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Zcb7zo9niT0GJ7s3Y2oPDZD2qhiFB7iZl0DfHFByae32FvFRb/5lHEPJ+k4jq1MnzpmKpN8A8SxYpUkwM0m+wEmUTEAWQGA59EWXhQd59wCijtsB7iCLVlbIuQaeJ+pFH1j206Gh6/VOw3M1JBipqYYxwqfJVeOlTpljC8sMVtjewfFVe/NqMB7AZMF6pZ1ixEKIASGK8fbAy8jUw4KYluGcAMIcnWH1+kRIJwZJKTbCtE/B2pau5PhbljQJ9wKOU1z6ORu9MP6BKJwlZ8lsmFnmgs2nfavdISaZKyu4hEdZ4OaZOxzlsoAmHWxbRS/dIkTRNCqfoEKFTUcxG0Uy4y1FFAXv1UuQj6tIFd8c5EGg0X4cuLuhDVZXTEMhUPBhFK1WY7JTFzFlwp2NtfvI2Mw91biip4Gaaq6BkmpyNYvyYjfJnFQZgLwphEAgGUnYE1cFVzOTuMwyxDKxZpiY8XafBnq81g6eNPqTqI4ODbuj1MSJnRXvE7y/NtMth4XdA4YoAfDkYtplv8q57EcsjmZlTPeKX4RY7/DARMmqeUBC3WbiG/uX9hnLvjoNSelqEdb4Qft7atwtznbUIJAC0Z6FMghLX8xmjGNbaby9D7qNEF2GdwPdnkqV2TI0zmqNZFPBKdzcacPXWVHh/kbNvJc0cSO7tdmZZSVFlhFrdUUgTEfhhjcWd/AEqp3kI2cx2H/soA5I4L167psFXblPAJNT+ZQoYZxAGUOyqtZkcATQt9kithGMESSiH/Xh/3dz
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(36756003)(31686004)(54906003)(16576012)(508600001)(2616005)(2906002)(5660300002)(6486002)(316002)(956004)(31696002)(558084003)(66946007)(66476007)(86362001)(66556008)(186003)(53546011)(38100700002)(4326008)(8676002)(6916009)(8936002)(26005)(7416002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?bkZtWnhuajFSa1RNa0pReFhRSjRGU1M4SWx2QVZ6eG5OU3JmeUtwcC8wU2RK?=
 =?utf-8?B?VXdNVVc3NGlRY0ZpLytKTS9IQk1FVFBxRWJ6WU5jcXlab2VTWWRXUmdnOHdM?=
 =?utf-8?B?RkkzZHBFU0FLaFh4VFh4OG5MTHFIN3AvMjdIRVpic2thTXdoTG5yOTN1NlU3?=
 =?utf-8?B?VlpEYXM0OW5XUDlEcFRZdEJjR08rZ1lvRHNpVHRBYmFUdkNJaXpuM3ZZRk9h?=
 =?utf-8?B?NVQ3K296a0pnaE9NckpMVVBsM3RHdUh0LzViR3lzdzAydFEvODJHaGRxY2pP?=
 =?utf-8?B?QlJtTldjbzRNQXhVeDV3ME9XdEZWeXJCTi8xUWZ1eWlGMGhsenU0cDlEdVhM?=
 =?utf-8?B?U1ZnenZJeXpzbGRtZkVWN1JJTUhtMGN5VlhlWXVIbElWQ3U1QmFldUk4c3dt?=
 =?utf-8?B?aWdvbmZ1R0dCQytFK2x3MGYxazY4RFBzNnAwT2lFNi9zZTl4UnNFaXB2Y1d2?=
 =?utf-8?B?TjhjeXNLT3daVTFkMHFJZnQzMTBnODd5U3lMRWoxY2t4WGRWTXlHdHk5NGZH?=
 =?utf-8?B?MmozZjNkeHBrL1IwSXdZUXVXUTdPRzV2TGwxdkhxVmdGS2dGSE0zUytHMEdm?=
 =?utf-8?B?T1FRUTBaWGNYNS8zUmZkRllwWmpUY3ZjaCswM2o5VFEzTHpwekJDUVFZWDBC?=
 =?utf-8?B?MzMyWGoxbi8ydjh5VjdPOUVzYWRPbU8yYWZYcTRMWnNNMjl6N3dCa1F4OVlr?=
 =?utf-8?B?b1FHaEUxTVZsQktkVDhtajJQUHpsR0wrWnFCZ1ZqcThkaEU1WFVQMWJUVlRE?=
 =?utf-8?B?NEVNK1VDWExMazZ4aWF2QkgwUCtqUjBUZGVQek5YRWFVb3JEM3RpcG0xYzdU?=
 =?utf-8?B?a01vaVlwTzBPc2VBaWRiUUxzVUV4MDMwaTlzdXczOWE4QkQ5M2VFTDdQUy9X?=
 =?utf-8?B?WlZlaVpRTlU0VW5pbDh6QUJpYTFYR1U4RlRLeG5RTzIzbkZyTllCVWViS2Jt?=
 =?utf-8?B?SHdSODNFakVLQW5hdmZyYkN2dWZUYWFRdDkrVVN1dXNWVldHYVc4SmVnSEZB?=
 =?utf-8?B?QjloUjdyei9uWXAxamtsYnBjQUxWaXU0UzZ1T0dKVmhwNGFyOENPMzhUOXlW?=
 =?utf-8?B?N2NhZTJrTHdtRWx3SnlmTkZNN2hQZy9jSzVDWHNvUjh1c0ZhWmZpa2M3eEYy?=
 =?utf-8?B?Yk42amQ3WktaK1I0Ui9kNHZqd1ZGN2dSNXVuL2JqZnhzOWFKS0g1clUzL3pC?=
 =?utf-8?B?NGFET3drR1psRFFEZmRsdUFBTDJLbmxwd1M5VmdtKzNiSVNrQjBGOXA4YVZQ?=
 =?utf-8?B?bUx2RkhaZXVsMERHMEsrWlAzR0g0M3hKajlUT0Y5Z1ZURXl6NXN2OTVXVnBw?=
 =?utf-8?B?VnRFaEl2Sm05dUpJYk5YWEVGd2FEeTAzNGI0QWsrTVFzOXJDR3dqeFhtRUdy?=
 =?utf-8?B?NnVPMXppUndBdjBnZnJBeGlEQkpVTkl4ZWMweUFBaTFvRFIzWVFRamNOQVc5?=
 =?utf-8?B?VU5kMW5yMXk5ODMrOHk1N3hjRkEyaFlwSEtsV21XeHNma0ltQTluSEg0d2tR?=
 =?utf-8?B?aU02c2x6WXN1cENzaUVySHdIRnRWTnBmdFpyTmtLMmRyRlF2M2o1Zzk1alFD?=
 =?utf-8?B?eDg2RWZxSmRBdkFGdUZCcU9DQzJQTThIRHo3NlV2cmYvVk9FQnFoekpXcU9Z?=
 =?utf-8?B?dGh1Y3BtRVh3eS9IMHErWlJtNEVkNnc0Y1FGK0dGblNocjF0U3NiK1hwaVlu?=
 =?utf-8?B?by9za2tqYzNibEVRV3p4b0Fld3BKR0tCNmI0RVpobVJEUXNETUFKSWc5RWRQ?=
 =?utf-8?Q?x2+/PViEDsf4slVBVE5QO7SA4uSmztBXnKYWin7?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f0ffebae-abf9-4af3-75e0-08d98ef4a73d
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2021 09:26:07.9752
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: GoIy68QW3GRlqv7qOgJdpLUXfdcH0mmCFNhROhYzVcdV+Ok8Ph848MrCNVtUIuJbsMW/g8YOHx1wewn9AnaLxA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2608

On 24.08.2021 12:50, Anthony PERARD wrote:
> This adds $(srctree) to a few path where make's VPATH=$(srctree) won't
> apply.
> 
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>

Acked-by: Jan Beulich <jbeulich@suse.com>



From xen-devel-bounces@lists.xenproject.org Thu Oct 14 09:30:02 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Oct 2021 09:30:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.209158.365518 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1max3n-0000Zx-3j; Thu, 14 Oct 2021 09:29:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 209158.365518; Thu, 14 Oct 2021 09:29:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1max3n-0000Zq-0k; Thu, 14 Oct 2021 09:29:59 +0000
Received: by outflank-mailman (input) for mailman id 209158;
 Thu, 14 Oct 2021 09:29:57 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1max3l-0000Zk-9t
 for xen-devel@lists.xenproject.org; Thu, 14 Oct 2021 09:29:57 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1max3l-00059L-1w; Thu, 14 Oct 2021 09:29:57 +0000
Received: from 54-240-197-239.amazon.com ([54.240.197.239]
 helo=[192.168.16.43]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1max3k-00083d-S4; Thu, 14 Oct 2021 09:29:57 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=2YeLQNtlnDAXgtXAupsk5ew1Qx3B8vZI/VgNN/c19Zw=; b=65lEBNyEFaAa96InwpS0ae4lhX
	/5UmrlWPwtVLtXj6lVrG2e0m24rM9j62OsEQW1OIUYE7To+jiBl85FQrO2pIqmi/wn5RnfvsHhRaQ
	gK/cfyxSot/pklbKQhDHxjwT2TxsHsKIT0vEiboLv+mqXQausIdS6cNZNQzdciTA/CSc=;
Message-ID: <e56e0ee0-2675-a746-3880-b6af48c7054b@xen.org>
Date: Thu, 14 Oct 2021 10:29:55 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.2.0
Subject: Re: [PATCH v2] xen/arm: vgic to ignore GICD ICPENRn registers access
To: Hongda Deng <Hongda.Deng@arm.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 "sstabellini@kernel.org" <sstabellini@kernel.org>
Cc: Bertrand Marquis <Bertrand.Marquis@arm.com>, Wei Chen <Wei.Chen@arm.com>
References: <20211012062449.30966-1-Hongda.Deng@arm.com>
 <2006f09d-25c3-af7a-cbea-dbc811fc8748@xen.org>
 <VE1PR08MB5677670DF19601441701380FE6B89@VE1PR08MB5677.eurprd08.prod.outlook.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <VE1PR08MB5677670DF19601441701380FE6B89@VE1PR08MB5677.eurprd08.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

On 14/10/2021 07:55, Hongda Deng wrote:
> Hi,
Hi,

>> -----Original Message-----
>> From: Julien Grall <julien@xen.org>
>> Sent: 2021年10月13日 5:58
>> To: Hongda Deng <Hongda.Deng@arm.com>; xen-devel@lists.xenproject.org;
>> sstabellini@kernel.org
>> Cc: Bertrand Marquis <Bertrand.Marquis@arm.com>; Wei Chen
>> <Wei.Chen@arm.com>
>> Subject: Re: [PATCH v2] xen/arm: vgic to ignore GICD ICPENRn registers access
>>
>> Hi,
>>
>> On 12/10/2021 07:24, Hongda Deng wrote:
>>> Currently, Xen will return IO unhandled when guests access GICD ICPENRn
>>> registers. This will raise a data abort inside guest. For Linux Guest,
>>> these virtual registers will not be accessed. But for Zephyr, in its
>>> GIC initialization code, these virtual registers will be accessed. And
>>> zephyr guest will get an IO data abort in initilization stage and enter
>>> fatal error. Emulating ICPENDR is not easy with the existing vGIC, so
>>> we currently ignore these virtual registers access and print a message
>>> about whether they are already pending instead of returning unhandled.
>>> More details can be found at [1].
>>
>> The link you provide only states that I am happy with the warning. This
>> doesn't seem relevant for a future reader. Did you intend to point to
>> something different?
>>
> 
> Yes, I would attach this link [1] then, which explains how zephyr accesses
> ICPENDR at its initialization. ( Though I still don't understand why zephyr
> would clear this register at initialization while linux wouldn't )

I am confused as well. From my understanding, clearing ICPENDR at 
initialization is pointless for level interrupts if you didn't quiesce 
the device beforehand.

The git history doesn't seem to give much details on the reason. But 
looking at the code, I am wondering if the intention was to clear the 
active bit rather than the pending bit.

> 
>>>
>>> [1] https://lists.xenproject.org/archives/html/xen-devel/2021-09/
>>> msg00744.html
>>>
>>> Signed-off-by: Hongda Deng <hongda.deng@arm.com>
>>> ---
>>>    xen/arch/arm/vgic-v2.c | 26 +++++++++++++++++++++++++-
>>>    xen/arch/arm/vgic-v3.c | 40 +++++++++++++++++++++++++++++++---------
>>>    2 files changed, 56 insertions(+), 10 deletions(-)
>>>
>>> diff --git a/xen/arch/arm/vgic-v2.c b/xen/arch/arm/vgic-v2.c
>>> index b2da886adc..d7ffaeeb65 100644
>>> --- a/xen/arch/arm/vgic-v2.c
>>> +++ b/xen/arch/arm/vgic-v2.c
>>> @@ -480,11 +480,35 @@ static int vgic_v2_distr_mmio_write(struct vcpu *v,
>> mmio_info_t *info,
>>>            return 1;
>>>
>>>        case VRANGE32(GICD_ICPENDR, GICD_ICPENDRN):
>>> +    {
>>> +        struct pending_irq *iter;
>>> +        unsigned int irq_start;
>>> +        unsigned int irq_end;
>>> +        uint32_t irq_pending = 0;
>>> +
>>>            if ( dabt.size != DABT_WORD ) goto bad_width;
>>>            printk(XENLOG_G_ERR
>>>                   "%pv: vGICD: unhandled word write %#"PRIregister" to
>> ICPENDR%d\n",
>>>                   v, r, gicd_reg - GICD_ICPENDR);
>>
>> As I wrote in v1, we should avoid to print a message when we know there
>> is no pending interrupts.
>>
> 
> These are not the modifications made in this patch, and same codes also exist
> for ICACTIVER. I didn't delete them for that I think they are used to give some
> useful and coherent messages to user for reference. Should we delete it for both
> or only for ICPENDR?

Looking at the implementation ICACTIVER, we simply ignore the write so 
it makes sense to print a message everytime.

This is quite different to the implementation of ICPENDR as we will 
partially emulate it. We technically emulated the register correctly 
when there is no pending interrupts, so I think it is wrong to print a 
message state this wasn't handled properly.

Therefore, I would like this message to only appear when we know the 
write wasn't handled properly.

>>> -        return 0;
>>> +
>>> +        irq_start = (gicd_reg - GICD_ICPENDR) * 32;
>>> +        irq_end = irq_start + 31;
>>> +        /* go through inflight_irqs and print specified pending irqs */
>>> +        list_for_each_entry(iter, &v->arch.vgic.inflight_irqs, inflight)
>> You need to hold v->arch.vgic.lock (with interrupt disabled) to go
>> through the list of inflight irqs. Otherwise, the list may be modified
>> while you are walking it.
>>
> 
> Ack.
> 
>> However, I am a little bit concerned with this approached (I noticed
>> Stefano suggested). The list may in theory contains a few hundreds
>> interrupts (a malicious OS May decide to never read IAR). So we are
>> potentially doing more work than necessary (we need to think about the
>> worse case scenario).
>>
>> Instead, I think it would be better to go through the 32 interrupts and
>> for each of them:
>>     1) find the pending_irq() using irq_to_pending()
>>     2) check if the IRQ in the inflight list with list_empty(&p->inflight)
>>
>> In addition to that, you want to check that the rank exists so we don't
>> do any extra work if the guest is trying to clear an interrupts above
>> the number of interrupts we support.
>>
> 
> Agreed, and that's quite helpful.

I forgot to mention that you may need to be careful with the locking. If 
I am not mistaken, "inflight" is protected with the arch.vgic.lock of 
vgic_get_target_vcpu();

>>> +        {
>>> +            if ( iter->irq < irq_start || irq_end < iter->irq )
>>> +                continue;
>>> +
>>> +            if ( test_bit(GIC_IRQ_GUEST_QUEUED, &iter->status) )
>>> +                irq_pending = irq_pending | (1 << (iter->irq - irq_start));

Looking at this code again. You want to check whether the guest 
requested to clear the interrupt. Otherwise, we may get spurious warning.

>>> +        }
>>> +
>>> +        if ( irq_pending != 0 )
>>> +            printk(XENLOG_G_ERR
>>> +                   "%pv: vGICD: ICPENDR%d=0x%08x\n",
>>> +                   v, gicd_reg - GICD_ICPENDR, irq_pending);
>>
>> This message is a bit confusing. I think it would be worth to print a
>> message for every interrupt not cleared. Maybe something like:
>>
>> "%pv trying to clear pending interrupt %u."
>>
> 
> I was thinking that there may be too many interrupts there, to print each with
> one message line would be too superfluous.
> But that worst case scenario should not be usual, and print a message for each
> interrupt would be much clearer.

In the worst case scenario, we would print 32 messages. We could 
possibly optimize to print all the interrupts on one line, but I don't 
think it is worth it. In most of the cases, you will have at most a 
couple of interrupts pending. If you have more, the XENLOG_G_ERR 
messages are ratelimited so there is no risk to flood the console.

>>> +        goto write_ignore_32;
>>> +    }
>>>
>>>        case VRANGE32(GICD_ISACTIVER, GICD_ISACTIVERN):
>>>            if ( dabt.size != DABT_WORD ) goto bad_width;
>>> diff --git a/xen/arch/arm/vgic-v3.c b/xen/arch/arm/vgic-v3.c
>>> index cb5a70c42e..243b24e496 100644
>>> --- a/xen/arch/arm/vgic-v3.c
>>> +++ b/xen/arch/arm/vgic-v3.c
>>> @@ -816,11 +816,35 @@ static int
>> __vgic_v3_distr_common_mmio_write(const char *name, struct vcpu *v,
>>>            return 1;
>>>
>>>        case VRANGE32(GICD_ICPENDR, GICD_ICPENDRN):
>>> +    {
>>> +        struct pending_irq *iter;
>>> +        unsigned int irq_start;
>>> +        unsigned int irq_end;
>>> +        uint32_t irq_pending = 0;
>>> +
>>>            if ( dabt.size != DABT_WORD ) goto bad_width;
>>>            printk(XENLOG_G_ERR
>>>                   "%pv: %s: unhandled word write %#"PRIregister" to ICPENDR%d\n",
>>>                   v, name, r, reg - GICD_ICPENDR);
>>> -        return 0;
>>> +
>>> +        irq_start = (reg - GICD_ICPENDR) * 32;
>>> +        irq_end = irq_start + 31;
>>> +        /* go through inflight_irqs and print specified pending irqs */
>>> +        list_for_each_entry(iter, &v->arch.vgic.inflight_irqs, inflight)
>>> +        {
>>> +            if ( iter->irq < irq_start || irq_end < iter->irq )
>>> +                continue;
>>> +
>>> +            if ( test_bit(GIC_IRQ_GUEST_QUEUED, &iter->status) )
>>> +                irq_pending = irq_pending | (1 << (iter->irq - irq_start));
>>> +        }
>>> +
>>> +        if ( irq_pending != 0 )
>>> +            printk(XENLOG_G_ERR
>>> +                   "%pv: %s: ICPENDR%d=0x%08x\n",
>>> +                   v, name, reg - GICD_ICPENDR, irq_pending);
>>
>> My remarks apply for GICv3 as well. Note that in the case of GICv3 v may
>> not be current.
>>
> 
> I am a bit confused why v may not be current for GICv3?

Unlike on GICv2, the ICPENDR0 is not banked. Instead, they are part of 
the re-distributor. So vCPU A could write into vCPU B re-distributor.

> Does that mean
> that for SPI we should use vgic_get_target_vcpu() to get its correct vcpu
> on GICv3 and multi cores?

You should do that for both GICv2 and GICv3 when dealing with SPIs.

>>> @@ -978,19 +1002,17 @@ static int vgic_v3_rdistr_sgi_mmio_write(struct
>> vcpu *v, mmio_info_t *info,
>>>        case VREG32(GICR_ICFGR1):
>>>        case VRANGE32(GICR_IPRIORITYR0, GICR_IPRIORITYR7):
>>>        case VREG32(GICR_ISPENDR0):
>>> -         /*
>>> -          * Above registers offset are common with GICD.
>>> -          * So handle common with GICD handling
>>> -          */
>>> +        /*
>>> +        * Above registers offset are common with GICD.
>>> +        * So handle common with GICD handling
>>> +        */
>>
>> This looks like a spurious change.
>>
> 
> I moved this comment to the left by one space to apply format style
> to be coherent with others.

Ah yes, there is one more space. But all the * should be aligned like below:

/*
  * Foo
  * Bar
  */


> I will undo this modification and write another patch to fix it if needed.
I am usually OK with coding style change within a functional patch if 
they are around the code modified. This is not the case here, so please 
send it separately.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Thu Oct 14 09:33:27 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Oct 2021 09:33:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.209165.365529 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1max76-0001wp-Ja; Thu, 14 Oct 2021 09:33:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 209165.365529; Thu, 14 Oct 2021 09:33:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1max76-0001wi-Fz; Thu, 14 Oct 2021 09:33:24 +0000
Received: by outflank-mailman (input) for mailman id 209165;
 Thu, 14 Oct 2021 09:33:23 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Xl23=PC=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1max75-0001wc-8V
 for xen-devel@lists.xenproject.org; Thu, 14 Oct 2021 09:33:23 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 3177714c-d756-441e-a3aa-527f7eb6e002;
 Thu, 14 Oct 2021 09:33:22 +0000 (UTC)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2054.outbound.protection.outlook.com [104.47.13.54]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-15-imHxwpxcMRukbdHObBO4aA-1; Thu, 14 Oct 2021 11:33:20 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB7151.eurprd04.prod.outlook.com (2603:10a6:800:129::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.19; Thu, 14 Oct
 2021 09:33:18 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.016; Thu, 14 Oct 2021
 09:33:18 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 FR0P281CA0054.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:48::16) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.14 via Frontend Transport; Thu, 14 Oct 2021 09:33:17 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3177714c-d756-441e-a3aa-527f7eb6e002
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634204001;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=yfAWO0mgGXRLRjSdL+G/R1lOhK/9ZNYPNz6qqMV3IHk=;
	b=e/BvTYTaDl64vNYloN9fyWpQRQK99dT46eFrqPOkRKAZsjGAXMCw0mQ4ualD9saSV/187d
	pgf1mioxu72hpTrf4YslIA6eCMCXoazEX/DIc850C1s6GrJS0oYg6+wm4G19etsmrD9gRQ
	cHsvN3Mkzer7U9Uc4aR0j3d2HWi9rIM=
X-MC-Unique: imHxwpxcMRukbdHObBO4aA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Ftls8K9lDhuvFWRZ/0oIcoDDpNXLDOhAYXO5N1M58BaCUhUaEV1Sn8WlZVcSZskG9QGjymYUMdgr5EY8Sg3hD/sBSMQqQ0Ypd/giWelVcLahCMHfVVLEYPaxsZStOz8pJlIR3iTyRXIP3PwNFe6GHeFYPA+AkU5pGsj93snFKdOtpV8DOa+Hij7S2RrHvvLVbz1TW76AAQoJ8gHuY8JrAPbbp/P1CTP4aQCaHJVuGPY5R2xbSxVGoXigWKPIA+5WqlNhzxHDJvv2fO4QBM2l9ugeUcwoaw4Vb546kHxzuZzcgy1K9eo5sV+wAJ788Vgwz9KY+o8jeOumeDAnFUOL6A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=yfAWO0mgGXRLRjSdL+G/R1lOhK/9ZNYPNz6qqMV3IHk=;
 b=V6S480btlv1koPQSSJq16EO6Q9crTc6OWyySRVxrVx1QoGhF+k5/SX1PAu5+IUpakXiaEiNKn00ppneOiHSCH7jImQAQnZu44hqYBUUAg7hbPb8f5Rb3DViA21Y4ukJ5RPiZiTa7hz9wxiHccvz5itB0sgx1wSmJa43ELz/hIWLF8d6NBtrg2MXC8KozWw2EwuGZQlfm0/8uGaX57chYX0hcsB+oiUaWkQYwYUvAfru7x9aUTaCw/SoiepHKAGGXqnmoF9J/ShHAz4qo8HIAzWb0UAwluOqslvurErpbftY0hC7QNW1dzffAzFVTOMQdgmM+EHXVynXv8b5s9ynX1Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [XEN PATCH v7 45/51] build: rework cloc recipe
To: Anthony PERARD <anthony.perard@citrix.com>,
 Stefano Stabellini <sstabellini@kernel.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Julien Grall <julien@xen.org>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
References: <20210824105038.1257926-1-anthony.perard@citrix.com>
 <20210824105038.1257926-46-anthony.perard@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <be6b4b2d-2b18-820b-43ba-e8e800d97517@suse.com>
Date: Thu, 14 Oct 2021 11:33:16 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <20210824105038.1257926-46-anthony.perard@citrix.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR0P281CA0054.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:48::16) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 52b28439-593d-4dff-8f31-08d98ef5a764
X-MS-TrafficTypeDiagnostic: VI1PR04MB7151:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB71519601F435418669961645B3B89@VI1PR04MB7151.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	SmzqLbWAIa37Pmhe7cTckQmM0s2Bsn7QXQD0cGBnNsqW7OCWPImpGYUeS+kxfq1xpN8gpjWygV02spN2q/k/C3HZrIHHd0hK1OE+27PIkVpc5leyriisBwEXmwz2pfIxsczo+pMjMQwTXv3PVFF0KRd8ciIthKeM8X1DW+7QZRIp887IHTsDObIPGePrKdaRYSjmISvzo5TLMmfRiaBya5neVpQqFwCgn7fIaOlXPBsbsv8KRBsqU8QxFeigMaLDfwXDHKwpGqdaGr4VHvM10qpWpu7dpIbiCoA6RYGFxr0pEcR89pNNnasCbmE+XRSyE/zzbWqLDlHO2A+fYCvmuRUy8oi4r0w2C1ON9mEtFkbfWzY8Ub1GGfV6M+7OPSbh3CxGRHfONSrW+hFQSuB/fgIzTMdnx2PS9OlRh01ArFLWvMyReaBXAOeukf00LFQrnEzTw4cZNIQbiDi8BEPJka1Z4hZF0gM0Kg4liDEqM1m4fc92n2K7vYTNajmiRj+wR3+HpTVoOf6ROWJs90FQZ2MDbQ2HXDhz2R3vQKVHoMEvE2D6OGfr+NbjMxMoOuFjx0oq9Azkr752grRGVy4kzthibE4fdH2XBP6YNCD9IDpLH7VpBro5O2ZD+TgBap3OgBEoBqm/k8xLIgjgkh0s24U7UFbWp9hyMhqHXT3qlmrg2ZpCDFCa0hifiI8jNLY73bcFi5Ropg3CJL1PYb2Wim1S/U3wQyQdx29ejzB3YT+ukmbXUIXPdw+wbHfmcjnH
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(6486002)(54906003)(4326008)(110136005)(2616005)(16576012)(31686004)(36756003)(8676002)(86362001)(66556008)(66946007)(66476007)(53546011)(956004)(2906002)(31696002)(8936002)(38100700002)(5660300002)(316002)(508600001)(26005)(4744005)(186003)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?eDZsYmxoamFFQ0xxalNDVTBvWldkUkJreXF1Q0djL3Rqajgvam4vaDhiMG43?=
 =?utf-8?B?MTJsZmpieEVwNms3SHFybGlYSGdXTzFLdjhiR0cyd3pWTHNxUzlnYlVHcU5J?=
 =?utf-8?B?c05uQUZZbk1wbzN3RWc0ZWZOTW9ua0hsTThTb3NMSGcweE5KZ2U1RUpsNjFk?=
 =?utf-8?B?RFUyUEE4SUQzc0gvdGhNQ0F4aDBMTlMyVGJYRUJKemFrelNmSlhKM0QxVDVy?=
 =?utf-8?B?T3RlYUEybU1wZ2ZXVUo5OG9oSXBqK3FCUjc2dHFXYmlvNjB3QVNVS3JvOEMz?=
 =?utf-8?B?TmtXUXA3bnkzQW1RVDV6dy9qVk5uRnJNcXJ5OHU0R29VbU8waGpJWXg0L1pl?=
 =?utf-8?B?MVQxUE1vOGxkYzBnQmlKSXpkUUM3N0JjNnRCOTNYRHlmemI0NUQ3N0pESFZE?=
 =?utf-8?B?SUhQZExhT2VwTXVUMlBPTnZCaHoybTcvRytWeXRvaUNSdjU4Q0NJUlY0cFFh?=
 =?utf-8?B?b0dQVnVkR1A0VzVsMVhCaXlLVDY4M3pIa1JNUUdqQ0RSRVpjSVc5d1pYd1N4?=
 =?utf-8?B?YUpZSkhOVnQySHJNU0VwVkJHTlVwMnFjMnpjTWgycFhaenJPNDhiN2ZNVHJa?=
 =?utf-8?B?dEpjTHhDVFMya3VKYnE0WGo4WkJWVWlXYnh6b1I5a3RNeUF3SnBKNzVUdW8x?=
 =?utf-8?B?M09kZ1V6VTFDdTU4aXluS1FUQzdjRVVSWWt3VXF4UG5iMEJuVUdGSmd3TzhX?=
 =?utf-8?B?U3ZZaUdxajBvRzlDWUlYbGtiUTlZUHprcTdVSXhuakxIZlN6WllGSkxDOUs1?=
 =?utf-8?B?S3RDTnRZb2dOMGo4OUR0ZWdsUjBqNjBIdmtPOGlOQkttSk1sL3pWNFpMRUV4?=
 =?utf-8?B?d1JBUEI1eEJoTlMvTkhjeUk4ZEdFTSt1YjNOVlZDeVMyWkpWWVVnRmEvQVQx?=
 =?utf-8?B?YjVFOG5Sd1dNZFdiU3ZNckZkUmpheW5jUHd3b0phK0kydVNFaGJQV1NUeFJ2?=
 =?utf-8?B?WXN5Wm5pZzVjeDYrN3hBUzhiYzViVEJCRkpWbW9VTmhSekNaejNjNWQ0SWlk?=
 =?utf-8?B?ZkxRVWpXVEVuTm5aWlpBUEZwODRkNjYrQjFCcERvTm5OSFV0SmhPNnd2VzNU?=
 =?utf-8?B?ZmxBdXJ6d3NReWVjTGNWTy9TaFJXRi9yZ2RaT3pXaEJBVEVwRGF2K3JYOS9L?=
 =?utf-8?B?MjVDaG11UkczUFhYNTNtejhhalZCV0hQUW1NMmZjd3VKLyszZWRmb2VCdVlL?=
 =?utf-8?B?N0R3eGpIR0JNQkJldVZERktPSHQ5QjRXMm9tVVNZVjh3alAxNEZ4V2Y0QjR0?=
 =?utf-8?B?OGxVU1ZMTjhQY3RNYWNvL2NEaDgrcHN1M3RGYWFQKzNWUE1hcERnTTZhWkhj?=
 =?utf-8?B?Z1RaMzRxWit1NU1xMXlHTzEwSTRGSExwQ09KQ2NadEtuT01BeG1IdGFxR2dF?=
 =?utf-8?B?MkV2RDV1cXRrbFRTU20zT2NYM1VFUWZ5M3JZWEVRb0lzelRDU2RLa0JRTDRI?=
 =?utf-8?B?TXpqUitINGdhdVdLcmhLT3RObklia0FydjhWdU9rYUN0d1BkL01PR0hZSFVB?=
 =?utf-8?B?MkZOV1J3SitqMG5BcFpDbFdWd2pveFdnUnJ4K0VqekpqZ0hlYkVFamtwdkU5?=
 =?utf-8?B?RE5lN2RYWGRtNk9GS0RsL0ovc1dMYzZvYTkzTmFaRVlHb053OENMMXJ3bDA4?=
 =?utf-8?B?em5OYjkwNyt1ZmJxa05CVElrYUNZWFA5dEdkMk5MdWtMQVpkUW9ZODdmcHhG?=
 =?utf-8?B?dUFGeWdsTGhQUWhsN0dPWGJBRnREN1F3OStTUWcwVnNQbHJ3Sk9rdDk5QU0v?=
 =?utf-8?Q?9qhewY+Ws0XDIB+slf82jUiXknjyeO9mabaofQe?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 52b28439-593d-4dff-8f31-08d98ef5a764
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2021 09:33:17.7572
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: I0B9rXHB6dDFpbawbXRA8LRObkX8V6thol/3ktpSBEp61w9DLMkgUQNHxb5+b2Q6TBuaRVZLVZygDGabYycnYw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7151

On 24.08.2021 12:50, Anthony PERARD wrote:
> After folowing patches, the recipe doesn't work anymore.
>     - build: build everything from the root dir, use obj=$subdir
>     - build: introduce if_changed_deps

That was some 20 patches ago - shouldn't all make goals continue to
work at every step?

> First patch mean that $(names) already have $(path), and the second
> one, the .*.d files are replaced by .*.cmd files which are much
> simpler to parse here.
> 
> Also replace the makefile programming by a much simpler shell command.
> 
> This doesn't check anymore if the source file exist, but that can be
> fixed by running `make clean`, and probably doesn't impact the
> calculation. `cloc` just complain that some files don't exist.

Not sure whether that's acceptable - Stefano, iirc it was you who
introduced this goal.

Jan



From xen-devel-bounces@lists.xenproject.org Thu Oct 14 09:33:32 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Oct 2021 09:33:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.209166.365540 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1max7D-0002GK-VM; Thu, 14 Oct 2021 09:33:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 209166.365540; Thu, 14 Oct 2021 09:33:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1max7D-0002GD-SO; Thu, 14 Oct 2021 09:33:31 +0000
Received: by outflank-mailman (input) for mailman id 209166;
 Thu, 14 Oct 2021 09:33:30 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1max7C-0002FM-B6
 for xen-devel@lists.xenproject.org; Thu, 14 Oct 2021 09:33:30 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1max7B-0005EB-5t; Thu, 14 Oct 2021 09:33:29 +0000
Received: from 54-240-197-239.amazon.com ([54.240.197.239]
 helo=[192.168.16.43]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1max7A-0008Py-W4; Thu, 14 Oct 2021 09:33:29 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=dIfbK4SVYRibsDHNURyklg1n0+pQI3CZoHclS4pA1QY=; b=TGvlKklnSa/2BDPvCrTSwc+I1V
	cCub3D5edR8YWtEJcUlYwYzX3VTjgw/fPJhm/yF4uTGrhyuQxyQHW221UbpZbR/7clVDOAmzibon/
	D1w9jr7iJSmAvEfbuj73kJsYHG3aJxRcHzIM+VQqA41A7B39Hn8BJwZ2kiRE1WbQKVkA=;
Message-ID: <26a54c0f-7177-20d6-9186-08df5ebe852a@xen.org>
Date: Thu, 14 Oct 2021 10:33:26 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.2.0
Subject: Re: [PATCH] Revert "xen/domctl: Introduce XEN_DOMCTL_CDF_vpci flag"
To: Michal Orzel <michal.orzel@arm.com>, xen-devel@lists.xenproject.org
Cc: Christian Lindig <christian.lindig@citrix.com>,
 David Scott <dave@recoil.org>, Ian Jackson <iwj@xenproject.org>,
 Wei Liu <wl@xen.org>, Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 bertrand.marquis@arm.com
References: <20211014084718.21733-1-michal.orzel@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20211014084718.21733-1-michal.orzel@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Michal,

On 14/10/2021 09:47, Michal Orzel wrote:
> This reverts commit 2075b410ee8087662c880213c3aca196fb7ade22.
> 
> During the discussion [1] that took place after
> the patch was merged it was agreed that it should
> be reverted to avoid introducing a bad interface.
> 
> Furthermore, the patch rejected usage of flag
> XEN_DOMCTL_CDF_vpci for x86 which is not true
> as it should be set for dom0 PVH.
> 
> Due to XEN_DOMCTL_CDF_vpmu being introduced after
> XEN_DOMCTL_CDF_vpci, modify its bit position
> from 8 to 7.
> 
> [1] https://marc.info/?t=163354215300039&r=1&w=2
> 
> Signed-off-by: Michal Orzel <michal.orzel@arm.com>

Acked-by: Julien Grall <jgrall@amazon.com>

Looking at the thread, we are only missing an ack for...

> ---
>   tools/ocaml/libs/xc/xenctrl.ml  | 1 - >   tools/ocaml/libs/xc/xenctrl.mli | 1 -

the OCAML part. I can commit it once this is done.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Thu Oct 14 09:35:35 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Oct 2021 09:35:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.209180.365551 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1max9A-0003EK-Ct; Thu, 14 Oct 2021 09:35:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 209180.365551; Thu, 14 Oct 2021 09:35:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1max9A-0003ED-9r; Thu, 14 Oct 2021 09:35:32 +0000
Received: by outflank-mailman (input) for mailman id 209180;
 Thu, 14 Oct 2021 09:35:30 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1max98-0003Dj-Jo; Thu, 14 Oct 2021 09:35:30 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1max97-0005GF-61; Thu, 14 Oct 2021 09:35:29 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1max96-0005iI-PV; Thu, 14 Oct 2021 09:35:28 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1max96-00089F-P1; Thu, 14 Oct 2021 09:35:28 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=javEy5OCKj+JRNgH+o8ibUaWFPPSyvkJpITcZDBw4MQ=; b=fHrhLxjfOII1s2bQu50cRzVeTV
	ZmFonMj2TSR9UoQAnrOLWd8URXtEbq4QfcZHtuDm+QYWeYGb9eUcD6o0Yj1gQZ6aVAtd6GTgvWjpI
	ckGIedbqCOsM3JH1nReVRw9ZjBq+lfUPfK/8aU+c8V6sjdhSjZ8do3lFN/vNSShj/Y6s=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165498-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 165498: tolerable FAIL - PUSHED
X-Osstest-Failures:
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=946de558354c99e1989621abe053f2ab87dc8de9
X-Osstest-Versions-That:
    qemuu=ee26ce674a93c824713542cec3b6a9ca85459165
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 14 Oct 2021 09:35:28 +0000

flight 165498 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165498/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165488
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165488
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 165488
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 165488
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 165488
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 165488
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 165488
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165488
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 qemuu                946de558354c99e1989621abe053f2ab87dc8de9
baseline version:
 qemuu                ee26ce674a93c824713542cec3b6a9ca85459165

Last test of basis   165488  2021-10-13 02:58:54 Z    1 days
Testing same since   165498  2021-10-13 17:39:31 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Alexander Graf <agraf@csgraf.de>
  Cole Robinson <crobinso@redhat.com>
  David Hildenbrand <david@redhat.com>
  Dov Murik <dovmurik@linux.ibm.com>
  Dr. David Alan Gilbert <dgilbert@redhat.com>
  Kacper Słomiński <kacper.slominski72@gmail.com>
  Markus Armbruster <armbru@redhat.com>
  Paolo Bonzini <pbonzini@redhat.com>
  Philippe Mathieu-Daudé <philmd@redhat.com>
  Richard Henderson <richard.henderson@linaro.org>
  Thomas Huth <thuth@redhat.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/qemu-xen.git
   ee26ce674a..946de55835  946de558354c99e1989621abe053f2ab87dc8de9 -> upstream-tested


From xen-devel-bounces@lists.xenproject.org Thu Oct 14 09:36:45 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Oct 2021 09:36:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.209188.365564 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maxAK-0003pZ-On; Thu, 14 Oct 2021 09:36:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 209188.365564; Thu, 14 Oct 2021 09:36:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maxAK-0003pS-Lc; Thu, 14 Oct 2021 09:36:44 +0000
Received: by outflank-mailman (input) for mailman id 209188;
 Thu, 14 Oct 2021 09:36:43 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Xl23=PC=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1maxAJ-0003pH-HX
 for xen-devel@lists.xenproject.org; Thu, 14 Oct 2021 09:36:43 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 3c9f9cb9-2cd2-11ec-81b8-12813bfff9fa;
 Thu, 14 Oct 2021 09:36:42 +0000 (UTC)
Received: from EUR03-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur03lp2051.outbound.protection.outlook.com [104.47.10.51]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-13-1FgFa47IOaOpFTv1HxVXtA-1; Thu, 14 Oct 2021 11:36:39 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB5165.eurprd04.prod.outlook.com (2603:10a6:803:54::25)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16; Thu, 14 Oct
 2021 09:36:37 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.016; Thu, 14 Oct 2021
 09:36:37 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS8PR04CA0105.eurprd04.prod.outlook.com (2603:10a6:20b:31e::20) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15 via Frontend
 Transport; Thu, 14 Oct 2021 09:36:36 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3c9f9cb9-2cd2-11ec-81b8-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634204201;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=JpEfSN4rLnshqbeqpiXp5hdq02H1BC/zqMK216bXNMc=;
	b=RAqOKPiufecFbwD7CqnY96IQ59HO/hS3hGPIp3LnmHRxILHIB0haH+Wcz9dEZxROq6/it/
	KeXTmIHYrywn0AfhzOt777l4v6BI9eku2jZdkkhgf38I1XaC3OAk1laD0blb/1YrBM7qf9
	dn0zVQEzwoMksZSON3U64gLIByE7+8o=
X-MC-Unique: 1FgFa47IOaOpFTv1HxVXtA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=gItKd5CCWtfafsvGuTyW9UvtAXXvxnec/xVjTI/AwlvyDXTU+RSfkKt6dZjI/Ue1OvrgsgGgeoL7pSbRbCVleyCMtbGMu/SS8wuXmZlnhlWGXSjePT2gGEBnwLrnvPyGYJ7TumqW9xGXsElX38Tvzxp8hdhT7CslitQB6LQ+jsDaytm/EEsCqfaGUKruyH////NmgT6PqcCO1ob9mDMh03YJjfwRY7kYKzCLNhjZpMuY9Aal9DffCKzcuL0lkmPVzfewzk7mBOWHk0Vw89I9PaGgLLKM7Gkr/ghsQUnZJ4F8mF51iwseKFD1wgZteCs1IYiQ334zdMqgtAEo3q5E/w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=JpEfSN4rLnshqbeqpiXp5hdq02H1BC/zqMK216bXNMc=;
 b=EiyR/yEKrtBw89a4opO4H/3zQ25uT7RBV7mv4bwAvkZKSl0X+IqNOnz4ij5jJsVDN5F6XuSeMhqfzFKztTFUreTFYv4iUPi1f//qfQoF/B7Alw43p2uD+Jl4XrRZSgI+qoQL5mse2QB5J/V2K9QQjM6YprHZGvtXsty9lQegRoQi8ns99topfy/Ql9Q6thfTmxp750dO+IyKo7LmBlqlRtGvnqfTp8Zrc+pCqDlrIYdL5WRn+leKmg/bzMnzpCqT+1U/6UWfofqg6u4xFCcD4xPX4TRSfslmNnMcUr3ZrfnNHGAC1Wy/uHp90n3vJ1L0ooxbz0SNDBUwoa5nyL4CHw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [XEN PATCH v7 46/51] build: replace $(BASEDIR) by $(srctree)
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>, Daniel De Graaf <dgdegra@tycho.nsa.gov>,
 "Daniel P. Smith" <dpsmith@apertussolutions.com>,
 xen-devel@lists.xenproject.org
References: <20210824105038.1257926-1-anthony.perard@citrix.com>
 <20210824105038.1257926-47-anthony.perard@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <84ab3325-3615-f4e2-1151-7b1ce96716cb@suse.com>
Date: Thu, 14 Oct 2021 11:36:35 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <20210824105038.1257926-47-anthony.perard@citrix.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8PR04CA0105.eurprd04.prod.outlook.com
 (2603:10a6:20b:31e::20) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 4e9f1268-a6a3-4b2d-5e18-08d98ef61e20
X-MS-TrafficTypeDiagnostic: VI1PR04MB5165:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB5165B1015D7D0482B3110DC6B3B89@VI1PR04MB5165.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7691;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Li2s9vAqrHkxbOW8pcV0oS6zs6DDTzmWgcEkUCRfACJgulJWAVhf1hQa0g+GY9F8TwjrEYGJrRKEULEQpCPsm5ixsAHCiRx/+Rf4XcLmFb/aeV5/N+zeZQ0dFULnI6wo5oFqFQFPweZwTgQKlPBTkPyhQHPhJpGG3OXs9kF9aNfykmc+TCjM9QAxMw3GdMaEIr0FGJ9T1VMqRl+QOKx0mv1/dEv1CcKzkNt2A3JSo7oAbG8h6FQc5D6qWpISP5Ra2Sp3TP3d8cNIPPD2a+tiyR/UjYkCRrhlcTqtqp+IF21PY/dRgA4rPqPlHoI+Mu23drvMmjXRW4ffX06tg/CbyEabzzht5Lt3Xg0OBNfyrbrWSYwMkHVK4GFn8GqmAS9Im8OUDMIXoYuKmdkcJhuww07z/0Fk997tMhENzFO7Wvz6A86jHVjs6IH7vAsrczQUAj4Js+wSoBXYQwwzEjMBDQg5LpQTYkAJPXuRFb9rVfqalsKaVlFKULiifwjqdPNXj+0HEtrE4pHIUgIe1k7ym6+KXfznXXlLQGfllR1sOIE4dLRjiYWv36s5fzJHbzu5+DK5jSEerCeYbICt3Dbw/cDPEjHVo4MXc5IcwGrJVhtCBGlZ43QIvuRjCVQ8qhoy6CjQijHqepJYN4WYj/itTdI82Oeiy7wazqPCJHsO7sCaTpKSyGaBWESTvPDiC285QOS2ll/h8grxIOlbIRC1iBW0doRt8of26tS0vEdBWrg=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(6486002)(31696002)(31686004)(86362001)(8936002)(4326008)(508600001)(26005)(53546011)(6916009)(186003)(956004)(2616005)(2906002)(54906003)(5660300002)(16576012)(316002)(4744005)(8676002)(66556008)(7416002)(66476007)(66946007)(36756003)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?SXFtdlhGSUxMVFlPUFpKTVJ6QVh6UENXeTVCT0R1b2Ftb3ZqblJxTVBXMGZF?=
 =?utf-8?B?eXRXY05MQkNnNzZ5UUhPK2FuTHJ3TDRlKzFpN21oK3FWbmVFYTBvZVlNUmda?=
 =?utf-8?B?bXlBZHlwNE1wYWtrb2g2M3dxaXRVNTZZeVJBUldNVnFMTmE2UWpQUGtOYmdR?=
 =?utf-8?B?M3ZkcmNzc1RiYWliRmhad01PT3hRWVNpVnArWWtKa0ZuTkt5ZGtwM2lZUEtU?=
 =?utf-8?B?L0dVQ2Y2MEZzRzZlR1NQSlMraDNaMnZUU0p4a3ZnL1FsVjdxNUhFeEtNeitO?=
 =?utf-8?B?VW1qckZkRVZaUFNZQnlMMHVjTzVVWWluLzBzbWFRdTRudEFwaFFlYmdkT3o0?=
 =?utf-8?B?TnRMT2RDc1NBaUVrZit3RXdldU00bUFJOXFzam1KWkdJa1EwdjBsMXRvZFpx?=
 =?utf-8?B?WW5XSU9WTS9PNFlKbGlpeVJBdlhIazZ2N1hvQi9LQnZpZHBYRE1rREgxSTk2?=
 =?utf-8?B?ckkwZHlJN01Ha2poUXQ3QW53OGVsT21wYUFBNDZJNFhwbGFTd2pnY3JmRHZa?=
 =?utf-8?B?RzBBNVcvRU1jZkdvalplZ2lVODBOVlUvRWFZbmhzVlFGRHlLVmF4QjFISDdU?=
 =?utf-8?B?WktNR3FoNk5qRzV0UlJtYzB2cFA0VjNnTHltd3puL21VU1pRMWFrUlhOWUth?=
 =?utf-8?B?OVZsUGNnZGpZOTc2T0h5WW9EYWNqQno0eE84d25HNzk4aFExOHFKU2FmOXZL?=
 =?utf-8?B?S044bnMxcElxaVIxdXQzR2dyT3lhVkF1NlU2d1RjeWFMay9TUkxZRlpKUGZ4?=
 =?utf-8?B?blFrczYwMGpqN3JjZkk5cmwrU3ZCcVhSWTRJZ2VoYk5PYUF4bS9RSDVCUE1P?=
 =?utf-8?B?MlFyVFdsWE9VczZuWkV5NjY2MFUyNUkzWjI3ZXdEQjF4RTF4RVFBWHdscXFC?=
 =?utf-8?B?RWJwejFoc0dyNzFmS0plTy8zRTBYTUFKdEF5Y25yZ2VTRitBSjIwMW1xTml5?=
 =?utf-8?B?Z1RFRzZYYmFDSzN3M2xpN2g2Q1J3cm5XV0pWQ2NkUTJGNnByczFIOXFnVDJV?=
 =?utf-8?B?MFRVc0NCK3hOZWZLeTNiZ0dIeE9QMS9WRFRyUWtRSkxhMzdGdllrR0ZRRjB0?=
 =?utf-8?B?cmZtUEc0eXdPekZMYTZQaitzUjI1R2gwWTdQSEhzOTRleEh1bXNVNjZuT21z?=
 =?utf-8?B?UGZhS2tzdytEeUdVUmlZV0RBK0hlZHd3MWFzdnMyL1ZiaWhBdzhMU0wzL0tF?=
 =?utf-8?B?WDVDV25FcnpJWVhLRWUxYkx0Um8yV0FRNHVjSC9pVmxOSXlMV2VEd21KS01F?=
 =?utf-8?B?dDVaNzRWTTkrckE1eEM3WFlzNjlqTVRCSXBkQUoyNDMrZGZ4N2N2bU5jWCtF?=
 =?utf-8?B?WTZndmlkZkxBajN1WG51a085MlV1c2NJNmN4NEtGdnhURTdSYjFNd3lRcVZD?=
 =?utf-8?B?Q2FuTzR4VmdBVHVSbm14OHpScUVuaXM5Qm1COHdqTzJpOE1lU255QlZ3SDZo?=
 =?utf-8?B?QjBqMDgyWFB1VnZUMmZXSFZsb2UxZE94ckhwRXp3cWx0QTJUclZpVU8yUW5H?=
 =?utf-8?B?NFltZW1EVGFoeTEyR2hMTmhORllyRDJoODdpNU5RYWlDcFgxNDFkZnhUazA5?=
 =?utf-8?B?TFcvbHBZUDBoRGxURVVEakpDMjF5T2h3aC9ybVF0Rmp5SWRucXN1T1NMTW03?=
 =?utf-8?B?UytKLytDamcrcytQQnFNdkNMVFhCYjNTRzdsWGxvQWIwWTY5c0x2dUZQTnlH?=
 =?utf-8?B?QW14NGJoZjQyK2YyanVJV0tGeDlRckRFNVdPZVNTNWtzbWpBRkhvL0NlZDMr?=
 =?utf-8?Q?dYaydbEM8oauoX03po0EiK1RQsRjT58rTv4TmLC?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4e9f1268-a6a3-4b2d-5e18-08d98ef61e20
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2021 09:36:36.9521
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: p/Uv4ukOJz3mTqwUkhudoAxY/Z3rVetznVWfaGi2ZOxPoGxQSXnA0x/rpEU0DgsrNLbkRVPh2NfFatxvdszk5A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5165

On 24.08.2021 12:50, Anthony PERARD wrote:
> $(srctree) is a better description for the source directory than
> $(BASEDIR) that has been used for both source and build directory
> (which where the same).
> 
> "clean" is still changing directory, so we need to use absolute path
> for it.
> 
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>

Acked-by: Jan Beulich <jbeulich@suse.com>

I'm curious though why this was split from patch 44. It doesn't look
to me as if patch 45 would have changed anything that's related here.

Jan



From xen-devel-bounces@lists.xenproject.org Thu Oct 14 09:43:02 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Oct 2021 09:43:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.209199.365576 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maxGM-0005KJ-Ji; Thu, 14 Oct 2021 09:42:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 209199.365576; Thu, 14 Oct 2021 09:42:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maxGM-0005KC-Ff; Thu, 14 Oct 2021 09:42:58 +0000
Received: by outflank-mailman (input) for mailman id 209199;
 Thu, 14 Oct 2021 09:42:57 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=PYUk=PC=citrix.com=christian.lindig@srs-us1.protection.inumbo.net>)
 id 1maxGL-0005K6-L5
 for xen-devel@lists.xenproject.org; Thu, 14 Oct 2021 09:42:57 +0000
Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 58e02220-d3f8-4e12-9610-8eef4e082e6a;
 Thu, 14 Oct 2021 09:42:55 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 58e02220-d3f8-4e12-9610-8eef4e082e6a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1634204575;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:mime-version;
  bh=yAMoMvCk/cp04il8oTNSW2uU/i394SMSgVAijOKhQUA=;
  b=Lzq6zX++yX73DNfPpCt+D3NFmjN6oPHeJFZ3szx5bJoxATUjKg+UgN4D
   k7H815hBoTLNFWaXDp6WdhmvA6vO6f4J/WoSCASHFoamsc5KPq5zptiZP
   OjAXY8qX5/3L0tRNhYdDFRnpiQTM1w3q/D0Ni9o2RPe4e224hqhG7GNFD
   4=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: Xxy3rW54EEPtpAO4VTckU6L7ipttINo5xrYHDGN1wK6cyFoCiJdW1b8R3gelmVVPPev5FxYJx+
 BNH2W0UQ41bc9Hav7s7WFRY83AsW7NM5Uzfibnv0fUcahYrnISGiXbw+0HDo+LpVsQ6bhA6ZO4
 L8lH98GEBSGOYATA7sDt1GBxEYzHEfE/KrJCCOEhgv7spcNevy3hHtqVNV29loxo0mc34om1NT
 yCXWmmRIMBPWUowSbGn/wV93HGamKrCkbdsmIPKuR9o/NjpC9RXHI/4C/ckPfANkb4MMdwlx8x
 y6emjdHr+sqBbmsBICsVn6kJ
X-SBRS: 5.1
X-MesageID: 55157498
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:CxlUJ61qQM26cZwcD/bD5ah3kn2cJEfYwER7XKvMYLTBsI5bpz0Gz
 2pNX27QPP7ZZWb1fYggOozlpk1Tu8fUy9c2SFA5pC1hF35El5HIVI+TRqvS04J+DSFhoGZPt
 Zh2hgzodZhsJpPkS5PE3oHJ9RGQ74nRLlbHILOCan0ZqTNMEn970Es7wrJh2+aEvPDia++zk
 YKqyyHgEAfNNw5cagr4PIra9XuDFNyr0N8plgRWicJj5TcypFFMZH4rHomjLmOQf2VhNrXSq
 9Avbl2O1jixEx8FUrtJm1tgG6EAaua60QOm0hK6V0U+6/TrS+NbPqsTbZIhhUlrZzqhgcBqz
 slGmJeJEyAvDI79hacbChZJHHQrVUFG0OevzXmXtMWSywvNcmf2wuUoB0YzVWEa0r8pWycUr
 6VecW1TKEDY7w616OvTpu1EjcQ5LdL3PYoZ/HVhyz3YAt4tQIzZQrWM7thdtNs1rp0TRKuBO
 5tJAdZpRC6cPUEXFn0nMrE7vqSjhFLZI2Naml3A8MLb5ECMlVcsgdABKuH9eNaHWMFUlUawv
 X/d8iLyBRRyHMOb4SqI9DSrnOCntTjgRIsYGbm89/hrqF6e3GoeDFsRT1TTifO0kFKkUtRTb
 Ukd4DMzrLMa/VauCNL6WnWQnnmAuRINXstKJMcz4gqN16n87h6QAy4PSTspQNknv88/QXotz
 E2Em/vgHzkpu7qQIVqf67OVoDWaKSUTa2gYakcsXQYDptXuvow3phbOVcp4Vr64iMXvHjP9y
 CzMqzIx750Skswjx6i95UrAgT+nut7OVAFdzgneQG+N9A5yY4+hIYuy5jDmAe1oddjDCAPb5
 T5dxpbYvLtm4YyxeDKlXvUWGq2iyv28ahras31eAtonrju89Cv2FWxP2w1WKEBsO8cCXDbmZ
 k7PpA9cjKNu0GuWgbxfON3pVZx7pUT0PZG8DKqMN4sRCnRkXFbfpHkGWKKG44z6fKHAe4kEM
 pCHbd3kM38eDal2pNZdb7ZAieF1rszSKGW6eHwa8/hF+ebBDJJ2Ye1cWLdrUgzfxPjZyOky2
 4wOX/ZmMz0FDIXDjtD/qOb/12wiI3khHozRoMdKbOOFKQcOMDh/UKOInOt/JN07wfw9egL0E
 peVARIwJL3X3yyvFOl3Qio7NOOHsWhX/BrXwhDAzX73giN+MO5DHY8UdoctfKlPyQCQ5aUcc
 hXxQO3ZWq4nYm2eo1w1NMChxKQ/JEXDrV/fZEKNPWlgF6OMsiSUo7cIiCO0r3JQZsd23ONjy
 4CdOvTzGsFaHF44UpaIOJpCDTqZ5BAgpQ67ZGORSvF7c0Tw6ol6bSv3i/48OcYXLhvfgDCd0
 m6r7d0w/4Eheqc5r4vEg76qtYCsH7csF0ZWBTCDv723KTPb7iyoxooZCLSEejXUVWXV/qS+Z
 LoKk6GgYaNfxFsa4ZBhF7tLzL4l44e9rbFt0Qk5Tm7AaE6mC+08LyDej9VPrKBE2pRQpRCyB
 hCU4tBfNLjQYJHlHVcdKRALdOOG0f1IyDDe4e5seBfx5TNt/arBWkJXZkHehCtYJbpzEYUk3
 eZ+55JGt13h0kIna4/UgDpV+mKAKm07f58m7pxKUpX2jgcLy01ZZcCOACHB/5zSOc5HNVMnI
 2HIifOa1ahc3EfLb1E6CWPJgbhGnZ0LtR1HkA0CKlCOloaXj/M7xkQMozE+TwATxRRbyeNjf
 GNsMhQtd6mJ+j5pgulFXnytRF4dVEHIpBSpxgtbjnDdQmmpSnfJfT80Nuu69UwE935RI2pA9
 7aCxWe5CTvncakdBMfptZKJfxA7ceFMyw==
IronPort-HdrOrdr: A9a23:hmUI5KGI7PJpkvBBpLqE7MeALOsnbusQ8zAXPidKOHtom62j5q
 STdZEgviMc5wx8ZJhNo7+90cq7IU80l6Qa3WB5B97LNmTbUQCTTb1K3M/PxCDhBj271sM179
 YET0GmMqySMbGtt7eZ3DWF
X-IronPort-AV: E=Sophos;i="5.85,372,1624334400"; 
   d="scan'208,217";a="55157498"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=bqMgwYihwfc7A4AxzvmfpfcJZ4GnbdgWI3HyVPT4ttR+WdfzhQbU6QtZxwqw7eg0UvEqwmO4F8Ju4kgDtr56Avgr6HvrS04Dzjqt5FgupBNdtqxK+l96m5CAx7pYqHktQE0TSV2dbyxaPMK5NmnhDk5tWAvj2tz7y6aOVkWLT+8LstNHqphidv9ynR0GWTNOYI97TF8wPN1DV9qQIbx4c825+dzBYNJbVdelaMt9eWcceqeI072z8XzLqLIbWlyKVsHaaFrcvqG7hF1B5XOw+BLTmZItNF7hy+m1Yh7FFqGn7PoR5+WnaAwvzjmVSyariqEeWUPpL97DiWe39/ovIw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=buiBblhjlh+8I1QqTkz3NZo9EzlJNOtGiEbAjKuWzfs=;
 b=L7+mJzamXBXvKXaJ93VPElAJq19NOLsgiQptUg5yi3d6cR3xYvVjOapjdySvVjci0EE8MZDN8swOE5KZFNPnv6k3dgtetcHXO8QUyScY2s0KhY9vcFQtOvgJ02zc1uEPzarycofet3cidosQB9oyuhKkzJALgetcTJnr9bcWsmP3DR6g2JYYQGa2fKYOY98xL8GDSMOOFXUjScMkRN7tuE7uNuEHIix6HDxbHPitSuSpcGx/pUsb8IsgtpJo8m/q+ZNXt3I2h0FNH+EdfSAfsrxSuS++2mhz7HZ/7iR+bfGUj18fRJEOBQQS8CrUSb/egPcTbH4wk3TtGx5LBOpzQA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=buiBblhjlh+8I1QqTkz3NZo9EzlJNOtGiEbAjKuWzfs=;
 b=ItoCEfz/TWh4IHw6jUcFyhzu9bH48YBdtpwAt2oKcu0Bh4eCfWFLVIvVAdZL9Pmtnh6bKYYwa2I8UIVN5njBLqr/ELSQ9ksjjRSw8t3o3i8Qepbie+W7ZferLaTyf0AvM2xyhnTHPgS7OpdUdCs8vh89x+J+ud5QZnOmhbJpS1c=
From: Christian Lindig <christian.lindig@citrix.com>
To: Julien Grall <julien@xen.org>
CC: Michal Orzel <michal.orzel@arm.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, David Scott <dave@recoil.org>, Ian Jackson
	<iwj@xenproject.org>, Wei Liu <wl@xen.org>, Andrew Cooper
	<Andrew.Cooper3@citrix.com>, George Dunlap <George.Dunlap@citrix.com>, "Jan
 Beulich" <jbeulich@suse.com>, Stefano Stabellini <sstabellini@kernel.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, Roger Pau Monne
	<roger.pau@citrix.com>, "bertrand.marquis@arm.com" <bertrand.marquis@arm.com>
Subject: Re: [PATCH] Revert "xen/domctl: Introduce XEN_DOMCTL_CDF_vpci flag"
Thread-Topic: [PATCH] Revert "xen/domctl: Introduce XEN_DOMCTL_CDF_vpci flag"
Thread-Index: AQHXwNg3UVaE90Gwpk2gRfKr74wLf6vSO2MAgAACmQA=
Date: Thu, 14 Oct 2021 09:42:45 +0000
Message-ID: <5C594BB0-FDF2-47B0-8E54-CEB154579F47@citrix.com>
References: <20211014084718.21733-1-michal.orzel@arm.com>
 <26a54c0f-7177-20d6-9186-08df5ebe852a@xen.org>
In-Reply-To: <26a54c0f-7177-20d6-9186-08df5ebe852a@xen.org>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3608.120.23.2.4)
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 04d7ed69-f34d-4eb3-f644-08d98ef6f9b8
x-ms-traffictypediagnostic: MWHPR03MB2526:
x-ms-exchange-transport-forked: True
x-microsoft-antispam-prvs: <MWHPR03MB25261A82C9CF721CAC8F77C9F6B89@MWHPR03MB2526.namprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:4941;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: TahUvf+w/u8+SAE7j71UyKJJ7ko2IzfUTkuyO9GHhmhMiCbukl3JlIrGXAIybKDP9jEZUb7jZcwZEdUsf0HbsjEPYUhrAdM9YjoT2sE4h1iNxGmsH8x3Tq8D8vkro19FOEX3vSHolWSPnazmDuUiRLLdkY6yTu0gp1rdBIH8J7x9vm8aQGdJddo/h/L7FOmDmkre1hkeg0Kzup2Da/S0xOs96G8XiXCb6XgRmEaHjBt6ed3pKYPqMkJKY1GNtfI7H3p0Jcp/YZTNCyznxoofA64L1JaXs3gH3xX7ruUcLOQ3s8X/TESf04F08CVyFIhwa8cyO8EXtu8v8+pWAxiCKMtlYQpLuAJK1f4JFzSr6Tjo4z8pE9p0d/TuuOY77vcu/d3iHTmjv6hbqWOUfsvevscwz7TTMvvtSFkB/7pdzCp5NExk7CupEk/jfbWSZIyfloduuGLEoZomYXwyFzQZmlq5xoVupOCXv8h+HbXxMhexme04+lWNOUT8q58MZ3pFbWXlMtTkqNkq6Ir+sLKE2CNEHMIpaOCWMfb8VEGb7QlRX667rhke3YB3Vgi741g4P+nsjUXtSdIAlKM+RYeBiLMx5xp19AGmPQweLZwDQaC25AVZrjQAmuDvp5wYVd6Zkh5S/FMKUm21D0nxeOOEZ2giJcut2bx0W7d2hNb1emkhPE/47zAE44nd0AxAK7UIQXbgRf9ezeHtf1s2BeAKeHOaRY0y1xz7ImISwQJE4bKmGVmZDrOUjkU/+HUiD3RR
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR03MB6380.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(8936002)(38070700005)(122000001)(66946007)(91956017)(71200400001)(26005)(53546011)(186003)(33656002)(5660300002)(508600001)(38100700002)(6506007)(316002)(66446008)(66556008)(66476007)(54906003)(7416002)(76116006)(8676002)(6916009)(2616005)(64756008)(86362001)(4326008)(44832011)(82960400001)(36756003)(2906002)(6512007)(6486002)(558084003)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?pol9ZoPnW07XEIfz/v1I6cvBhn8NkX4kFlc/iS2jwOKRdRTfX5zZw1j9nz7b?=
 =?us-ascii?Q?F/luqbSzBpy9z95iZaxEnE54/9BYCTIJkS2SZC9cr+9rcfKl/Sl8HcuNG3X+?=
 =?us-ascii?Q?cefgL6wknOYc68l7BwURSzl5t41eNPjmD1v2LY4rrb9iiRBVENE2ylId5kaz?=
 =?us-ascii?Q?KgNNMeJpSSv3OhV2GYtDA8EkLAqDwZDTigV2QeRbevKW9g9WVXgx0kGijDHt?=
 =?us-ascii?Q?iTcd+d9T25lix3+tNAYfQ0+R2W58w9pIxEUZa+jEin6E0Y1BY7KqhMxlYDXL?=
 =?us-ascii?Q?HpYImx6FmWGRk/VsDVIKSgx+fUGWd8hp5oiUvzzbju/t8YmpWHeTCPbdhTSv?=
 =?us-ascii?Q?J/QrVO7/fortRnIlkrsmMgLWPOcc0PeZ3fPmAstCOXJY7xJa7FkDrVLmREvd?=
 =?us-ascii?Q?Rgmgz6knG4dSx+uxdmP+XUVz4FJ8/WH9N428RdNAiKzK5Gl9ylQlGKqH0NUX?=
 =?us-ascii?Q?5KeqgdT8qwBnthyeYtC3Rsdq2I18LybOGBMyZXFyUys76u/5mnFIp6SUtoPp?=
 =?us-ascii?Q?nJD9yvnny1JMCnCRgLQjh6iq4H7BlSZU/NH6i+s4i8t/sbwUpfM8CDhUC0X0?=
 =?us-ascii?Q?UGl2rkwloFK5469MuKJ5j3lcbf6u5qepfLKzaswXDKEhgt2/e6SCEwj2mBZt?=
 =?us-ascii?Q?LUnbKxBAHOhEYtihoxlo7YK8X9FZ61JJKLmPzObBoBGonDombvV8jFtRIgMg?=
 =?us-ascii?Q?K3z3J/NX9lMvYY4qm/Sg1KG+ec/GVyzgUl3/PdrsjlhidySuTjOktdOmSLnl?=
 =?us-ascii?Q?JSxOfCt6kY8FQZ7Fh44R2wLhOAHBZ1skqMqVtJ70OgiShkn91xMPdzwrTPNI?=
 =?us-ascii?Q?ea+fT92s/bDIIfIC6CWgR7eVFlt0dVSM0VlsgW7t201m02EoP7SVwRqrQVEi?=
 =?us-ascii?Q?+11SE0Q9cAv3Du3q0d94VB8mPUk75Zd6glUZHhEByYoj9Zi95USCxI4pUXLh?=
 =?us-ascii?Q?ICc6KLHZ3qePNj6ylpxp+IOMz7XIXfzoNY5efHHV5d01VD9r/gxXl2IX/J8X?=
 =?us-ascii?Q?z0xx8+ahXtkSpNo6ajUJes0TcFwjeGiz8Z3Zoni8JmaRpMZqhcCyNmlE3oYs?=
 =?us-ascii?Q?W5Ebk+b2jaPqGnnPeJ10JgRkrSJp9zrBJBT/Gq8XwRdsKSH0i+fm77+LFbma?=
 =?us-ascii?Q?jgzQbh7UQKeiyZ/1EB0G1ooTPG/YcgIe061bC/N5A++n1vTuk9f2HiTPFv04?=
 =?us-ascii?Q?jWqpU/wkhikqwCRN/HngMM+aU7/zvixQR6ZCgtqvqsQ5nNUd6+UL3zXd6qDF?=
 =?us-ascii?Q?OS9bhq4jJa/xEntTtlZTJ33s5FcHWUpHlkShOrRcUhuT8FG8cCcDiiVQ1B7F?=
 =?us-ascii?Q?DN8M/liePaqup+I5C6XU2j7QcG5BzligQFQfrJQiahPS3w=3D=3D?=
Content-Type: multipart/alternative;
	boundary="_000_5C594BB0FDF247B08E54CEB154579F47citrixcom_"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MW4PR03MB6380.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 04d7ed69-f34d-4eb3-f644-08d98ef6f9b8
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Oct 2021 09:42:45.1437
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: iACiqq7GwyIl+dHO8oP3ghKDL3fzzXw6Ziz4J3jI2as67tR07Ut0IaXHV3WdGSY+oZK03Rts1p9f3zRBbfj52HM9wimwsFu/m8unsB9vY5w=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR03MB2526
X-OriginatorOrg: citrix.com

--_000_5C594BB0FDF247B08E54CEB154579F47citrixcom_
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable



On 14 Oct 2021, at 10:33, Julien Grall <julien@xen.org<mailto:julien@xen.or=
g>> wrote:

Looking at the thread, we are only missing an ack for...

---
 tools/ocaml/libs/xc/xenctrl.ml  | 1 - >   tools/ocaml/libs/xc/xenctrl.mli =
| 1 -

Acked-by: Christian Lindig <christian.lindig@citrix.com<mailto:christian.li=
ndig@citrix.com>>

--_000_5C594BB0FDF247B08E54CEB154579F47citrixcom_
Content-Type: text/html; charset="us-ascii"
Content-ID: <AD11CCD166969A47B3C138F0E6CC38EA@namprd03.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable

<html>
<head>
<meta http-equiv=3D"Content-Type" content=3D"text/html; charset=3Dus-ascii"=
>
</head>
<body style=3D"word-wrap: break-word; -webkit-nbsp-mode: space; line-break:=
 after-white-space;" class=3D"">
<br class=3D"">
<div><br class=3D"">
<blockquote type=3D"cite" class=3D"">
<div class=3D"">On 14 Oct 2021, at 10:33, Julien Grall &lt;<a href=3D"mailt=
o:julien@xen.org" class=3D"">julien@xen.org</a>&gt; wrote:</div>
<br class=3D"Apple-interchange-newline">
<div class=3D""><span style=3D"caret-color: rgb(0, 0, 0); font-family: Helv=
etica; font-size: 12px; font-style: normal; font-variant-caps: normal; font=
-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0p=
x; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-te=
xt-stroke-width: 0px; text-decoration: none; float: none; display: inline !=
important;" class=3D"">Looking
 at the thread, we are only missing an ack for...</span><br style=3D"caret-=
color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: n=
ormal; font-variant-caps: normal; font-weight: normal; letter-spacing: norm=
al; text-align: start; text-indent: 0px; text-transform: none; white-space:=
 normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration=
: none;" class=3D"">
<br style=3D"caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: =
12px; font-style: normal; font-variant-caps: normal; font-weight: normal; l=
etter-spacing: normal; text-align: start; text-indent: 0px; text-transform:=
 none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0=
px; text-decoration: none;" class=3D"">
<blockquote type=3D"cite" style=3D"font-family: Helvetica; font-size: 12px;=
 font-style: normal; font-variant-caps: normal; font-weight: normal; letter=
-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-=
transform: none; white-space: normal; widows: auto; word-spacing: 0px; -web=
kit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; text-decoration=
: none;" class=3D"">
---<br class=3D"">
&nbsp;tools/ocaml/libs/xc/xenctrl.ml &nbsp;| 1 - &gt; &nbsp;&nbsp;tools/oca=
ml/libs/xc/xenctrl.mli | 1 -</blockquote>
</div>
</blockquote>
</div>
<br class=3D"">
<div class=3D"">Acked-by: Christian Lindig &lt;<a href=3D"mailto:christian.=
lindig@citrix.com" class=3D"">christian.lindig@citrix.com</a>&gt;</div>
</body>
</html>

--_000_5C594BB0FDF247B08E54CEB154579F47citrixcom_--


From xen-devel-bounces@lists.xenproject.org Thu Oct 14 09:44:11 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Oct 2021 09:44:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.209205.365586 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maxHV-0005tG-Tp; Thu, 14 Oct 2021 09:44:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 209205.365586; Thu, 14 Oct 2021 09:44:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maxHV-0005t9-Qp; Thu, 14 Oct 2021 09:44:09 +0000
Received: by outflank-mailman (input) for mailman id 209205;
 Thu, 14 Oct 2021 09:44:09 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Xl23=PC=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1maxHV-0005t3-0b
 for xen-devel@lists.xenproject.org; Thu, 14 Oct 2021 09:44:09 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id ce8b989a-b8b6-4ba9-a94b-cf906ac11810;
 Thu, 14 Oct 2021 09:44:07 +0000 (UTC)
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur01lp2056.outbound.protection.outlook.com [104.47.2.56]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-25-0qWV6ImgOWSfkH08245eoA-1; Thu, 14 Oct 2021 11:44:05 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB4606.eurprd04.prod.outlook.com (2603:10a6:803:70::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.21; Thu, 14 Oct
 2021 09:44:03 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.016; Thu, 14 Oct 2021
 09:44:03 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS9PR06CA0088.eurprd06.prod.outlook.com (2603:10a6:20b:464::33) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.14 via Frontend
 Transport; Thu, 14 Oct 2021 09:44:02 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ce8b989a-b8b6-4ba9-a94b-cf906ac11810
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634204647;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=MTirFEo+vHGxZZn50utoGMoRAfbsSSvVAfED9B9MsZo=;
	b=APuqMmvjupbGzXebek6uMH+eiZkP2LP752VJmFJr/z//tSbVjYMWgmvp7U2x53jioDo2Uh
	78wIRp5Nd9r8ynGok/s4pOBDMwl/pNr2w6uEyLhpKST83vAXeQu9I27b5JQ80QXU2h1ZQx
	SCTXuBcCGAx1YiyUQyCN+kDZ6w2I7vE=
X-MC-Unique: 0qWV6ImgOWSfkH08245eoA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=mVMyuVT/fHsPGlf+sGLMLYcVn52ONQ+Ih4nD7JZm5gGeEiPHe9O5zK6oSoCdg/OLHJpjNRGQXMn1L58qKx3TvrqwqZP5j0zadAqal3boOKAGwH+A1JvOmvPA3hjmZWCTkldgw+ED6BxBq2IN0tA3kOAXukbpM1yS3T+UKCemMdrnb7vMzIKfQuAzDCmgBmiqQ16/Rtn3EXpecLKcMIlqyxcQoYVGKo16DAtwgBA0PmQxxNfnR+ppjOzeP6k3AYRU9BfZYYL1WXcXLXSns6qexWtp8CkGzZEgp/CjhvldgnGnAFsBdPVavwneMxJW04otEl2X87jV0Tyk0hpto3D87w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=MTirFEo+vHGxZZn50utoGMoRAfbsSSvVAfED9B9MsZo=;
 b=Q6Pm27ckF2y2U2HkcZ5oDr7ljEAHga2qnMukriIg/XRYpBGBmStxYAnhqcHSqY7HN8SF5ZNOAYM3MKMUyCTBJM+TD+98P8ZDbNRDdln9+Q2yBIVUqFouQS8VfY6drvSLy8zfYCd2lDg9OT50/6RTSU45QNwni0xJI26IDfH8BJBnQ8gRKvq/zLuRELZhgGklPQu5ujV2yMtBmKNmXGx9rQxWWH0IwrEpahuE38bwg2q4k2Q6AFF4MBvzTsPWj5dt+vjr7MuH7Iyc/d1XJW+H7M1NYyHPUrVvk2eyCgpR5nK8E8Ko0pfso3uA/7U8NKDACPqaOnMtpqDp2t3CaVdCfQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [XEN PATCH v7 47/51] build: Rework "clean" to clean from the root
 dir
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
 Ross Lagerwall <ross.lagerwall@citrix.com>,
 Daniel De Graaf <dgdegra@tycho.nsa.gov>,
 "Daniel P. Smith" <dpsmith@apertussolutions.com>,
 xen-devel@lists.xenproject.org
References: <20210824105038.1257926-1-anthony.perard@citrix.com>
 <20210824105038.1257926-48-anthony.perard@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <f29750b5-7028-3ec5-5bef-4c4480032a18@suse.com>
Date: Thu, 14 Oct 2021 11:44:00 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <20210824105038.1257926-48-anthony.perard@citrix.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0088.eurprd06.prod.outlook.com
 (2603:10a6:20b:464::33) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 1efb58f7-9f1c-40b6-d546-08d98ef72857
X-MS-TrafficTypeDiagnostic: VI1PR04MB4606:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB4606D80591BFF8C3C328283DB3B89@VI1PR04MB4606.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8273;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	befVZ2yBHwcJcMY/QYiptxru13u2+0MWSyPvHhcD56uvvm5PXmOlzC444U+zgZvOolJs3nG0hYJ+UDqX7k+1GnJo9HYGB3SuqK3IvX4nE4Lg8xZ4ns94G1ms8N6GoOKSMYIeLXmtv7wseHq3g0HaSL+Tv1WEszr02oQd8SvzKxgEThZnLQmicTODAFEJuMvTtJng7WRWcxaDIKYXQCmWFtZy7BixtP/iZT0qX9bcpsfcVPucAB0kvwkU+JfMjt1R765U0/iwGxQxvmHYqQi3q7PZW2cWlAacunWSGr+xohMXTZalucGcxyCbDQxmbpJKzT4feX2tVxiVZEmq8gfGUhxkw9ZTnM5OI1XtqTGmiI9j1TerulShDPDiH9itH82UzyMoLn+3a40pG/FqnXwF4/WNbWJziTdUoNxjA4xcTRdf2nIFPHfBjKATJDOYxi/qjCHBLDJQNXfDE13akStMd7R5PHdDCnFDo0jH2CfftBqdpJm/TTv/kJ44efjoB5Fo9yQ4oob4cJoVlhS1crFtCkBBvYOB80hMYnU2Z1894xODrU1zGjx2gHUAtgIv1PL4vmu11qMxtyF9knSeC4cPP0PhCZtJYmrbuS592GYb0JUvvIRl7hPARvAEa2Csx2POJUssqZq5AqFMQ0mtcXGAXHD+Zqt3D9xEq5UuA/wfdfeaf6wHu33SzpW7yU3dhlIjnqL0j3G3v2Uoj6am1p++76KXXjFBnTcMU+JsRvI7+EA=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(66476007)(66556008)(6486002)(2906002)(38100700002)(53546011)(7416002)(956004)(54906003)(4744005)(6916009)(8676002)(26005)(186003)(31696002)(16576012)(86362001)(4326008)(36756003)(508600001)(66946007)(31686004)(8936002)(2616005)(5660300002)(316002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?NGhUV2VvVklaTTB6N2c1bVZCblJ1cy84UXAwR2pEUnBiOGNqTEs2TGsrcDJK?=
 =?utf-8?B?RUwxSEtNSFQ3RmtSUzV6blpwUDg5eStiYnk5K1lxNjlzMW4ydThXTmQrTGpX?=
 =?utf-8?B?UjArY2Y3RTZjbkk0b1U4Y045QlREQjNCMUt4QXBVWkRES1JpYnJpaWMreE83?=
 =?utf-8?B?UlI0UWxXVmRrTS91ZjBmcW5abWkvVzFseHBsL29DR0h5M0FlTTE5SjdJaGxl?=
 =?utf-8?B?aWx4MVpTUDFTdk15S1VWdTBLZFFpd3p6a1JqYk9LdzJqbllIWWFSbW1rb3lU?=
 =?utf-8?B?eVFxVUNZcTcva2tiejg0YmtDYy9xRnFma0dCTStlVHpvRG5UNDNHck5BUTMy?=
 =?utf-8?B?MTRoVGdma1FQcGM3aDR0Yld4bUVoVTRTWDQ1cUpkMk1qWjJXSTUxdGlrU1Bu?=
 =?utf-8?B?b0RUNlVwblEzS0htcEFDUC9Bd2VNaUU1RVNaNTdIVno4RkVJM3VwbElPRGJr?=
 =?utf-8?B?dWF0TVVLTUw1T2pSWS9XeDJxNzVFNXdyNE5xNWdxTmYrbzJMRzEyV0lkbmxw?=
 =?utf-8?B?UVZFSlE0aWVtTVBxUXNWZkw0TXR0L0xXN1hkSGtjRWcvTVVVY0xHcWNQdUJD?=
 =?utf-8?B?SlhwQlhlcnJGTDU3YTlQT1JlNFlPUlRDeUU0NVhSbDZnTys5Y043L2NWMUdi?=
 =?utf-8?B?L1FOcHF0anlsQXg5d29yd0dadDg1aldWY0tJVjJQYTZBSnhkU3NNRitaZUxm?=
 =?utf-8?B?YTF3dm1DRnl0bEl5Ulllei9qRmM3cnhTOHEzbGFEVUxKZ0VQMGt3VmNKclRw?=
 =?utf-8?B?M3dvNVBENm9Sc0k5MFIydG1wdFJFaHlneEdaWjliUS9KRU9pVUJtUmhLOGVr?=
 =?utf-8?B?OGtFU285cHdqN2hOdHU2YjRkbXRaVXFRYXVyZENiS3I4NHRmOEVYY2ROeU43?=
 =?utf-8?B?cE1BWjVNYTIrR2RaTjFHMVNwYXBwWXg0alV4SnNRY3kra2NOazUxOHZpL3la?=
 =?utf-8?B?a0hFU09YVnVmY2tVWFVQV2RJRUgzc0RiT0h1T1VqSkhsa2c0OUEvMVl1VC9u?=
 =?utf-8?B?bm9SS3ZwdW9oQVBGcXdjd2lScUl5MUF1WWl3RnN3U3BBU2VBQU1yVm8zYmhn?=
 =?utf-8?B?a1FvNGFJTzg4YkhPK2JGTzVSeHoram05SGQ3UFIvU1NsUEo3SnhOMFpzWkQz?=
 =?utf-8?B?bkcrMXFyVDg3NHczT21nOWZ3Q2lQcXlKL3dxYSt6VHkzQ2s1UnZsRWhiMmt2?=
 =?utf-8?B?aXBCcGhteWs1QlByd0NCN3Qyd0VJSmpIcHdnSkZvNlV0dGRzdjZUMUhXd2Vs?=
 =?utf-8?B?TTA0RkpJS2lkNlVEVjF4NFJGcW5Pck95dzJYSERSRUk3TXBoWTM2M0VKRzlx?=
 =?utf-8?B?dWExNVFWSWYybTRYWkVDZ1VWYjU2MFNxdXNqaDRKZE9mYVFIUGN1OGJQc2lY?=
 =?utf-8?B?bnBOazV3cCtpVkhLZzQxVEtnRTRBQStrV0Y4cGxCcGR2WGIwUUFsWFFxN1Iv?=
 =?utf-8?B?M1NGV0dnck1YZTJPbUVLR0MzNjVXYm80NTd1ZTY0UGI2dStLTzc4c3E5NG0r?=
 =?utf-8?B?MGh3UU9wNFhMRTQzQTZyUlVwT25CbW1NamFGZ2I0Zy9VaThiMnFUV3JXa002?=
 =?utf-8?B?cXNLNUFPVVMvaGw3ajZJbHIvQU8wRVh2dXowdU5vVkhJUjJSM2NCcnpYRkc3?=
 =?utf-8?B?Q2FueWdjd2lGTkEwRE1vc0oxUnpEbk8yTEFIL09raU5UK09xNzd4SVNwckxF?=
 =?utf-8?B?UkZYSjlpQ1hvVkJjazRTWHl6Z3NUWFZmZHRmL01tVm0zWnZJaXordDhrRVhL?=
 =?utf-8?Q?2nQK+6TZvNZugFcOUZ++AVHy1+MWDtCKIVYBQjB?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1efb58f7-9f1c-40b6-d546-08d98ef72857
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2021 09:44:03.5556
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: nnO6+l4+fapuWRP+UsAE7JBPlY3sQBqLXVIlkqV3z9dc4pVBGXitn6589KRECeVEAstsL/bZQtYXz6wSCyK/sg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4606

On 24.08.2021 12:50, Anthony PERARD wrote:
> This will allow "clean" to work from an out-of-tree build when
> it will be available.
> 
> Some of the file been removed in current "clean" target aren't added
> to $(clean-files) because they are already listed in $(extra-) or
> $(extra-y).
> 
> Also clean files in "arch/x86/boot" from that directory by allowing
> "clean" to descend into the subdir by adding "boot" into $(subdir-).

"descend into" (also used in a respective comment) looks contrary to
doing everything from the root now, at least to me.

> --- a/xen/scripts/Kbuild.include
> +++ b/xen/scripts/Kbuild.include
> @@ -98,7 +98,7 @@ build := -f $(srctree)/Rules.mk obj
>  # Shorthand for $(MAKE) clean
>  # Usage:
>  # $(MAKE) $(clean) dir
> -clean := -f $(abs_srctree)/scripts/Makefile.clean clean -C
> +clean := -f $(srctree)/scripts/Makefile.clean obj

Doesn't the comment want changing as well?

Jan



From xen-devel-bounces@lists.xenproject.org Thu Oct 14 09:49:08 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Oct 2021 09:49:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.209214.365598 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maxMH-0006bt-HB; Thu, 14 Oct 2021 09:49:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 209214.365598; Thu, 14 Oct 2021 09:49:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maxMH-0006bm-DV; Thu, 14 Oct 2021 09:49:05 +0000
Received: by outflank-mailman (input) for mailman id 209214;
 Thu, 14 Oct 2021 09:49:04 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Xl23=PC=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1maxMG-0006bg-9Z
 for xen-devel@lists.xenproject.org; Thu, 14 Oct 2021 09:49:04 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 7c285b14-a8a7-4640-89dd-0426cc17685c;
 Thu, 14 Oct 2021 09:49:03 +0000 (UTC)
Received: from EUR02-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur02lp2052.outbound.protection.outlook.com [104.47.5.52]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-29-CXqRQz18PUSETECD8c0FOg-1; Thu, 14 Oct 2021 11:49:00 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB4848.eurprd04.prod.outlook.com (2603:10a6:803:55::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18; Thu, 14 Oct
 2021 09:48:58 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.016; Thu, 14 Oct 2021
 09:48:58 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM5PR0301CA0036.eurprd03.prod.outlook.com (2603:10a6:206:14::49) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.15 via Frontend
 Transport; Thu, 14 Oct 2021 09:48:57 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7c285b14-a8a7-4640-89dd-0426cc17685c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634204942;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=xGvy/QwWcMZ/OSmXbLZbPXm4xLrBPsrCLiFUyztBCc4=;
	b=JSlcWFKYZPyPTccwK8+TbIMt/NxKVqM4tyLMWJ/MwOHbwVAouZ1EDNZSGr25v3eweh3W70
	6WhEUji7Zie9dxOPuBxLCxAbtm11KnS++Pqk+BBRw6Qf42Ti43P5Ed9i6Z1ULpy11MUxcW
	HriEfy5TQi1DpIIHcOMnkolgcJEHesk=
X-MC-Unique: CXqRQz18PUSETECD8c0FOg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=X7qe/hBuF3Dddkv2XECbEz56I1kU9MqdMcIOM/pHHahbFDbt8GaWnWSAQ3XaMUofcBseuDWqmjdf447NG2ceKB0/YrJaJeOCkudO4uOWkbIp108QQr9uvXRAwijVQDINDndi556THe24HjRMnBTnS1g9X2xWrIp9ZyANHleFW4P5JuMIPlmJQwxOkCUUjCocgJe7HECTDpFBzXQ6Qyls5PzsOCe4wW7Jf8spaf5Jv5UTh8tiav9fDhIpqkiEyaw2mOE3AAeyC8Qm6lLdAmK7zhE3nJ+s+TUAmKD90PUe81OIJhk4QToD9Dw/+52ZuBlOAheDn5QsYIOgZu6DFQK7cg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=xGvy/QwWcMZ/OSmXbLZbPXm4xLrBPsrCLiFUyztBCc4=;
 b=e+1mV3gq1lNuBYHVwMFEa01O7+KLU7ktUzVyRBJpJiDXblwiB9OOnGt+rHCoiC6AR5R/5Hs7kYUIbMqKW1QVnpAjzLJ4DUc18Cmx2zWzZSbnoeOTOqaUsbpof3xwRpHtIXJFijU31fAKIDed3ZbC6GRAtnNlW3+ExAdioa5P1eXxP3n5pJM9CAeg7ekR5xUSDjwjbTU+nD61v3WmINpzcqKmy8dvOOrh3+pqYW0Fbu0+Dcb3vQQGHkh/zIJSnm/O31e9+zKp2Jjb+6SVc7S/Zr3O+PnroaZiNzkQ0HxphCckJTW4kpRZgOGvbC6gB12POIluiZZtVpN/QPfnsqS73g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [XEN PATCH v7 48/51] build: Rework "headers*.chk" prerequisite in
 include/
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>, xen-devel@lists.xenproject.org
References: <20210824105038.1257926-1-anthony.perard@citrix.com>
 <20210824105038.1257926-49-anthony.perard@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <a86769b9-1a93-0b81-5d95-89697c99b386@suse.com>
Date: Thu, 14 Oct 2021 11:48:56 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <20210824105038.1257926-49-anthony.perard@citrix.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM5PR0301CA0036.eurprd03.prod.outlook.com
 (2603:10a6:206:14::49) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 09604d33-863c-495b-7f92-08d98ef7d7fd
X-MS-TrafficTypeDiagnostic: VI1PR04MB4848:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB4848BE84647CE4040F0F125CB3B89@VI1PR04MB4848.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:3044;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	vd2UheSnpCkICm8qoCfeNsDOsloGX5yoPonWVK71l6QhTZ3kWAoCdFRuxK/myqqINzbi20yfJEQWx1ekCIu6AFyo4gSvSJdkjUrcqMf6kmbc3cHAFqb41HuGPnvye9udA3uKyoG1UoLedqVd3yrOT+UdoWFh6AFNbLvra2xYYzXMfWqLQXpisC+aBjrUoxBZb4IB0eDcWaC/r5e8SwDQQ+vviX//nWQfVjceRlKskJMrAEfhkRbCHjVnQW8zRgGflrYM8ssu+ldinlYKQQZ6clDhiU3vkqIpyFFZkB3kBTjhKQ285j3AGuS8fBUQDal4Q5DGBUxDI+RVjCDri/ODmTfzIllKMde9Xtxp6vkDKLF8Eusd8bWcqnqn4BHem0OOnXeDLIQ3YPDhiBJ0bi2WfgE0/MjdvBrhWIfkTEJPZwOOJWhBYU3iGaYkcF1OK8naoQAo3UAuGBPkIYmhzLJMWn23t785B3vGqE11LqKR+485mkNwWxmd5vNiI0/t3ecu3+MWUCEe0yLhmb2Epv+jFAsCaYow58oGlj00KaYPGFwBCL+Uo6wIvfwIlpbFal6dhkJCEsc1T8S6KyiwKQfxrz/BnXiu8IOjk2BVw5XDStv7rGmDODmQvai1jGqn+IEJBlo1npAwAtPaqsH+S9iVtwH+QFZmuZyA0tG3qiXDefdcHQdTXIc+Xq/x5VLXYMpUGIKbIXVLpws1pBoSR17AUNEQiRRNtx9VBDad706vQik=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(6486002)(8676002)(66476007)(956004)(66946007)(53546011)(2616005)(4326008)(66556008)(26005)(8936002)(31686004)(36756003)(186003)(508600001)(31696002)(86362001)(316002)(16576012)(2906002)(5660300002)(38100700002)(54906003)(6916009)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?WklsZUNORjNVYXQ1NDBHU01Temo3bk9OUHhuOUJzc2tHcmRheDc5dmNHcGpp?=
 =?utf-8?B?dlNFZGdYREpKandrM2l5SUZPVm5LaGJYK09hV3VpWWtwQ3Q1Y3RYcXJSbDFE?=
 =?utf-8?B?LzlrQ1VKZlBseVlaNDQvakNUTDFPYi85NjlpRElISU5yaEVMaEd1TUpFM2pY?=
 =?utf-8?B?TWg0d3hQM29pWlpob0diTkt5cEpkZDUxbThwUTJ6Tm9wdmkvVGlCQVFENjd6?=
 =?utf-8?B?YXI5ZEhIOE1OZ0NiTzNvTU5Vb3haOHNCcllsMXBrMWkxYXRROHltYXcxUlFH?=
 =?utf-8?B?L1RmMDk0MjNQYStYZUJrM29XSEM5TjVENmJiZ0ZXd005TjhYaFAwc3ZJVFZv?=
 =?utf-8?B?TEN2SHpOdjdLMXIxYzFhdnpSazhkT0dtZTRHbnE0SEtFczQ3WHF2akpyRVkv?=
 =?utf-8?B?MzZDeXVYTUk2VUZOTjlZTEhDdTdYQU5uSXpxeHVlQk5UNTYxdG01L1RQRDVC?=
 =?utf-8?B?S3pZbXgrb3huRThqTDJMUDhua09TeFhUd0JDem1mbXYvSGsvN1VQaU5McDlL?=
 =?utf-8?B?dkVhakZBdzE2cmY0RGRNSTNWR0d6T3VMc3lleG5DNjQwazMxcXJWN2pPdUZB?=
 =?utf-8?B?RTIyUCsxUVVrMklLalB4eitBdHpwV0FoUll0K0NVY1NkU2Z1Yms1WkoySWZQ?=
 =?utf-8?B?MWgreWRaSStvQ1IxbTNsRVZXVWVMOUZCWjBmYVpDOEE3MDdlbGxvSWpPWnln?=
 =?utf-8?B?YkpGZ3A2ZkVGd0Yyc2w1ckJVSHdpdTVlWG1XQ2hPNElqY1JjTnBlL0MwOTB0?=
 =?utf-8?B?VVdEOXRkVVIzT3g2cEVzbHJFb0ZzY0VvcEFuK1N1dkNWU1dndUdEWUhab1ho?=
 =?utf-8?B?ZzN5Y3Rta051a21HSHBoYmFzaDZxQjZZNkt6NWNSSTBtNHNzNXJxQzMwQUNv?=
 =?utf-8?B?OFFGUEJuNUU1cUtGcjA3bjcxQmZLN2VOeWlOQSttTmRhQ0VGSE1SMjBiRkZP?=
 =?utf-8?B?d05ka0hzdFZqczBwbDlmRFlzd1h4SFZuRVJjZkdNYlJwaWdMQkl6RFZuR1pv?=
 =?utf-8?B?SURSSG8zSzdnODVHY2NQQXlOdy9zR1U0M3ZmNFdQWFlUajRkc2RVNUNXZjR1?=
 =?utf-8?B?dnU4Q2xUZC9pbkRXcG1yNy8xU3gxS3JqS09UMUdkZ2YyL3l0L0RXYkVieGZK?=
 =?utf-8?B?eXdtU3RvYUtGSld3dmRtMys4N3JpdDZmeU0xMXA3T0lkMHY0T0tySjRJZGxV?=
 =?utf-8?B?dFZTWW85MExHL1d2UnY3ZjZDQkdVUVdHKzlYc253N3JSeHhSc2NnTnlKVmlP?=
 =?utf-8?B?VjRyZlYrQk5uZGhGU1p6cnRnemhNMzRsbXdOcTlOQW1qR0xkM0xTR3JxdG9N?=
 =?utf-8?B?ZStGeHZsS1ZqcmM2ekUrM05lVitnNHpyejJUejlzZHVaVEo4cS8xVi9GTHFB?=
 =?utf-8?B?SU9Wd1FoSlFMZzJoSUFHc2UrdkxnRTVzR0JsOXJrOUE1MCs4cFFidUw1eko1?=
 =?utf-8?B?ZzZxYWxLZVNIOWZaRUp3TzRLYWVKUEtJNzEyaHA5cytDLzVlZlE0SDUxTHJr?=
 =?utf-8?B?V2VtWnFvd1lkNm9US0t3NUMzbktERStNSWYrQzJHeFZYR3U4c3o3S05CVWVS?=
 =?utf-8?B?T3Qzd0RMRTJjYVo5TU5oYmVsdXg2cHpheWhiTHNNYnNCT043elhMd2hWeWFN?=
 =?utf-8?B?bG5hTFhrSkc1UG8rUWo4U3Y5NVJJQWZjR0lFL0lTcEw4WHUvQmUvaG5RVGZy?=
 =?utf-8?B?amJESXBMQ1FVcjZtMTNoZnNMUXA5b0Q5TjVOYmdTTW5GcE9HRjFmM3MzSVpi?=
 =?utf-8?Q?DR+iuPlFOIcn4u7yYBWNDMGzB/efAPQvAohOvxK?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 09604d33-863c-495b-7f92-08d98ef7d7fd
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2021 09:48:58.2326
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: VhzqSrRNWeQoAxQtXTbVb0uQO/UEa+pcj2TO2V++UwLDT+Iv3Y+nhjfud7q0QkCNJgQ/P/g7hIPf6k3FC1GYMA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4848

On 24.08.2021 12:50, Anthony PERARD wrote:
> Listing public headers when out-of-tree build are involved becomes
> more annoying where every path to every headers needs to start with
> "$(srctree)/$(src)", or $(wildcard ) will not work. This means more
> repetition.
> 
> This patch attempt to reduce the amount of duplication and make better
> use of make's meta programming capability. The filters are now listed
> in a variable and don't have to repeat the path to the headers files
> as this is added later as needed.
> 
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>

Sorry, just one nit here:

> --- a/xen/include/Makefile
> +++ b/xen/include/Makefile
> @@ -78,10 +78,21 @@ ifeq ($(XEN_TARGET_ARCH),$(XEN_COMPILE_ARCH))
>  
>  all: $(obj)/headers.chk $(obj)/headers99.chk $(obj)/headers++.chk
>  
> -PUBLIC_HEADERS := $(filter-out $(src)/public/arch-% $(src)/public/dom0_ops.h, $(wildcard $(src)/public/*.h $(src)/public/*/*.h))
> +hdrs-path := $(srctree)/$(src)/public
>  
> -PUBLIC_C99_HEADERS := $(src)/public/io/9pfs.h $(src)/public/io/pvcalls.h
> -PUBLIC_ANSI_HEADERS := $(filter-out $(src)/public/%ctl.h $(src)/public/xsm/% $(src)/public/%hvm/save.h $(PUBLIC_C99_HEADERS), $(PUBLIC_HEADERS))

These all had / have "PUBLIC" in their names because the makefile doesn't
live in public/. I'd prefer if you could stick to this for all the new
variables/macros you add (lower case then of course).

Jan

> +list-headers = $(wildcard $1/*.h $1/*/*.h)
> +filter-headers = $(filter-out $(addprefix $(hdrs-path)/,$($1-filter)), $($1))
> +
> +c99-headers := io/9pfs.h io/pvcalls.h
> +public-headers := $(call list-headers,$(hdrs-path))
> +ansi-headers := $(public-headers)
> +
> +public-headers-filter := dom0_ops.h arch-%
> +ansi-headers-filter := %ctl.h xsm/% %hvm/save.h $(public-headers-filter) $(c99-headers)
> +
> +PUBLIC_HEADERS := $(call filter-headers,public-headers)
> +PUBLIC_ANSI_HEADERS := $(call filter-headers,ansi-headers)
> +PUBLIC_C99_HEADERS := $(addprefix $(hdrs-path)/, $(c99-headers))
>  
>  $(src)/public/io/9pfs.h-prereq := string
>  $(src)/public/io/pvcalls.h-prereq := string
> 



From xen-devel-bounces@lists.xenproject.org Thu Oct 14 10:14:59 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Oct 2021 10:14:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.209226.365608 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maxl1-0001Rb-Mk; Thu, 14 Oct 2021 10:14:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 209226.365608; Thu, 14 Oct 2021 10:14:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maxl1-0001RU-Jf; Thu, 14 Oct 2021 10:14:39 +0000
Received: by outflank-mailman (input) for mailman id 209226;
 Thu, 14 Oct 2021 10:14:38 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Xl23=PC=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1maxkz-0001RO-Ut
 for xen-devel@lists.xenproject.org; Thu, 14 Oct 2021 10:14:37 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 0647970b-16b9-4bc1-8370-c650caf72088;
 Thu, 14 Oct 2021 10:14:36 +0000 (UTC)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2111.outbound.protection.outlook.com [104.47.17.111])
 (Using TLS) by relay.mimecast.com with ESMTP id
 de-mta-40-3KhCfHXoNjacIPxfU8VPKw-1; Thu, 14 Oct 2021 12:14:34 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VE1PR04MB7375.eurprd04.prod.outlook.com (2603:10a6:800:1a8::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18; Thu, 14 Oct
 2021 10:14:32 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.016; Thu, 14 Oct 2021
 10:14:32 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS8PR04CA0043.eurprd04.prod.outlook.com (2603:10a6:20b:312::18) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15 via Frontend
 Transport; Thu, 14 Oct 2021 10:14:31 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0647970b-16b9-4bc1-8370-c650caf72088
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634206475;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=F1w/wcdwqVVfnml3Ug9BPNlOAB72tYYCv1Qc0qqfq1Y=;
	b=MZF9jglv0CDWSI+ihrB9ld8w5qpqN8nIww3nccIYFG5/P/a8GHVU1MYn+aVwmeoTw8xJhS
	a3G4+ZdX8jI1xcFCszJpH2WcNOLr8Hy+DzP36uvVCWCqwFmq8wJVblBP5QyqKD5fNKTg5P
	6oGpchelMpYLY7WisnfNy3sAL7Z2spE=
X-MC-Unique: 3KhCfHXoNjacIPxfU8VPKw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=XY6O6dFHVHIJ5ABhphh1AH69515SRNBWgyUSmoA1Cfhq9/JZ9LAzdNN+OMqrgddnHDtpBrSAjQoJIOI+UMGqB97rTIyvA68KvaODuLUUAlTU3LTrfxFQct+NZPChHsRdZ52IZnnCaQW3JF3QTkJPM2U1x286S2uA3HCKJJpP24QlJwbkAmM7ImiD/3edPHW5fVr7uvAf2n+ydzIygIzeljCF5x98hNbbqYqqR35FIpQ1Qx8UYQ6ZejX8reUiEVKs2ug4tNBnwtrgxgfeVBtqxqWOuCfnSXEg+rZ0cjsCK1cKXEL6ZC9Uf/itS1mOwmeeqqq16AhxOgbSt4vaBQQTbQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=F1w/wcdwqVVfnml3Ug9BPNlOAB72tYYCv1Qc0qqfq1Y=;
 b=dyVavzGSohGVSBVGSYSQravthB1eVSAp/3m9Lw/StiFOs95BcLYY5Go7K0F5QonZmSoOKpzhtDpIHWT7zbwJtwVA+asR/UyOw9feZmknI7b6PMoqlsLIWOIgVrzl1hmAerk1ClpCh+2n+TaE249i9iHiqNx96VoPmUyJ5lnKYlfjdQARSxAQgKWhUVbcuHKX0e9S5bHKdpraW1WVFKqv1HB0NumVJresw1tu7VoJ1ien91lt7xpHJluvcSiO3mEOfPkiWjqR9ELZNpGuFpgW6+utjNvud5W+h+snzC0M0CQaKIcIFlm1tudJ1ro5rUzRSuEC/pR4TkwUSvLhpi9T8w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [XEN PATCH v7 49/51] build: adding out-of-tree support to the xen
 build
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
 Ross Lagerwall <ross.lagerwall@citrix.com>,
 Daniel De Graaf <dgdegra@tycho.nsa.gov>,
 "Daniel P. Smith" <dpsmith@apertussolutions.com>,
 xen-devel@lists.xenproject.org
References: <20210824105038.1257926-1-anthony.perard@citrix.com>
 <20210824105038.1257926-50-anthony.perard@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <2aaf0858-1602-be5c-77e4-2daa7fddc534@suse.com>
Date: Thu, 14 Oct 2021 12:14:29 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <20210824105038.1257926-50-anthony.perard@citrix.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8PR04CA0043.eurprd04.prod.outlook.com
 (2603:10a6:20b:312::18) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 293a0898-028f-4c46-21d7-08d98efb6a77
X-MS-TrafficTypeDiagnostic: VE1PR04MB7375:
X-Microsoft-Antispam-PRVS:
	<VE1PR04MB73751D7C38D6DC23E8BFF9E3B3B89@VE1PR04MB7375.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:5516;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	8tPU3tZ+iJSjdkOh55cfHXp2InUwHVsqlbTogdnsDOprUN/ra08DJHeDv0gnm9kGTl/Tm1zJ5/VuLUg2nXP/Lv5bBhkFqa8m+FD02ksOfGAY59h6/2qEpPccyAi0TCI0TLI00VjHbcNXrFwLm3iGOK1oOeFlirrzO4/o9NUbwYh5pUR6nA9/Sq13LS+PTmppovAdaVRNy0oRKR37p/ha1lg5M1NOQAKdH8RvgQO+Epeh/uJWlJKhFW4BRd56qhjL8/GyBAEpBBlqOmkhdJkscwXbYkfiAao4JhssKWFvZMBTjryrIjjdgju7shI6ZyPwPFBQk/KrddJckN7/9yjXV89DYjw3RLel1REMab40dD7kLid1CeDhk9jxY4ztr/ivXAhrfGi4pii4t6EJZhxwq8rvdw6uMHOndgblox2x+Uu1G/hWy9QdRQxCCenILNGyGzYUkgrdCZZGykThEiQHNcKVYj1nwgzfy31Kf08pihUTbwuHoc5U2OkuPVFeVpfqczT51w+aoYP+bXlDrEQ0OCj0//dVoFvCFoVaXunt3rA4ijDdrqlP+sCDt49BTkXYeCs90ZWyxbFwOKAZNlIzvYoCoJ5XiJHj0Ae1WJHBYbcBvRyP1vORTOCuDnFQPg2FDEKNq4UL8Mhg4BVIiUvEgcgMnrJwrNXI+txeVd6XlrdCTMB3jGXHAJZMce+iyYQfNkbdVTcuh9U7zbeTrETNOYASRTFuiWGD7wN2BlWtF20=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(66556008)(66476007)(86362001)(31686004)(53546011)(26005)(2906002)(36756003)(5660300002)(8676002)(7416002)(38100700002)(508600001)(186003)(8936002)(2616005)(6916009)(66946007)(83380400001)(956004)(6486002)(4326008)(31696002)(16576012)(316002)(54906003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Tk1nRms0emJ2VFdmb3k3RHpjV1BuRVhTelVUVm1jd1BpMW9ZekdRTDNBWTZp?=
 =?utf-8?B?OGlKTU1xQWpjdERJTGM0d3M1OW03WWxsOHVUcGtFOEk3QU9OcmV3N250NjBX?=
 =?utf-8?B?Mm9ZeDJmbm0weGtjNHRwbUFyMUpwS0J0N3Q0MjNxK3pWRGtuSC8va3JRaEZC?=
 =?utf-8?B?dlc5R1Njck4yajZhUVFZU29OS0Q0N1I0NWdGb0VlYVZTdnZERUVZUFNvYmJK?=
 =?utf-8?B?UzVyZU1ZcXpxUWRmcHRhZlRFZlM1UlBnR0tYMjRMSEpKQ2J3OE9Vc1dtT2x4?=
 =?utf-8?B?d3ZOdHBoQVVQSjZZQlFUcWMyVW1iLzNVUzhGdXBPT0s3RmNuU1JobkpwSkd2?=
 =?utf-8?B?NzBldEQ5R01ZRjEraDMyelpXazNOMkJYS0orOEtESFdZcDFWVEZUTG1QSG92?=
 =?utf-8?B?Wk04NUoreWtPYWFMZFkwV1ZjaktiK0Z0U0JsMVlRcEl6WGtWZUtMREFHU0Nm?=
 =?utf-8?B?bnIzTk5JSzlvWUJVRi9kajFYbEFxbjU5NUdQeDBJN0pTN1VYakFSWmhpZWpt?=
 =?utf-8?B?cUVjY0JYaEgxUjdEdFZndUdOUDVibmVrR3lNQW5mOXZBR3pmWU9WclpENmNF?=
 =?utf-8?B?WHlUMHBxR1hvbmtqR20ycXc2bmhqOGFtREFPTTFhalIwM0pFOG9yZmk5QmVG?=
 =?utf-8?B?dnZLTVRvc1Z1WW8veDJPeDFHLzRrOHloaDJmd1UzU1pSNnpLUUJObGtVYmxt?=
 =?utf-8?B?ZmVaaWxQS3puQ3d6Sy9BU2pMd0MzVFV0YnloZW1meTZ0anYzT2l5ZnpmK3ZN?=
 =?utf-8?B?Z2REOGVYNVpxWUFOOUQzWEh3bW1KMUhiek93N0JVTkNhZlMzcy9DNTBEUkkx?=
 =?utf-8?B?Tng4d0wxdnBNL0c0UFR2dmJSdmJNNDQ0Z3pnVzZpMVlJOGMyQnpSNFBkSksy?=
 =?utf-8?B?YlJrd3dVWXVuM08vSitURkNaN1JuR285U2VndWd1UFJMU0dTMk5RMm5QMGNn?=
 =?utf-8?B?d3NZczMzWVN0VTc4ZlhueDJSOHBtbGFySVlsMFZvZ1VvSEhEWTdhQTYxdDRm?=
 =?utf-8?B?QUNmU1g2WThxYXVTSUg3SHVIdDZBQVV4eFZ6YTJsUVdOOXk2dllRY1M0dGhO?=
 =?utf-8?B?NUJKT0RuVVE4Y3FWNWJKZXNXWHdyUkhDWmp2aDRJZVNNTnRhYzQyeXE4dzQ4?=
 =?utf-8?B?UXErcUJJNG1PR0hyUUlnNFYyWWczZmQrUTRaOTZYSGdtSkFtNksrdi9MNDVs?=
 =?utf-8?B?WThSelZaWlpPci85SGZhZjlNZ0xRQzlDRi8zdEJyc3FLdjV2YWlRWGhNSkU4?=
 =?utf-8?B?ZE5kRC8zVG5YOGQ5WjRTREFDb0s0YkVMb0dXUWJURnBDVkZJb053bEoxcUZp?=
 =?utf-8?B?Z1NkOGY1ZCtHeUxLZ0tzSGlOeWlML0ZMSnozVWdwNzZuMndWdm8xUUlid3B0?=
 =?utf-8?B?bDhVYTMvYmRPMWJnM1Bpclo2cmk3cTNQSDEzMTloZ0JpVzQ0TlZqd084MnZ3?=
 =?utf-8?B?WGtpY2kzdy9WR05QUGkvTjhacVZjb2ROaVN2S1JXb0cxemI4ci92L2E3cXJu?=
 =?utf-8?B?TlRISldCNFVHcWdFa0djYmpVSSthZnNhZm1jUTVHRzhEL1Z5cUZmRlVPNEc3?=
 =?utf-8?B?cDdHNDBzdk4rMEpTS2N1Y3I0c2pEcG0rQkJaT2F3MHJDNXpEMVhBOUVrTXVU?=
 =?utf-8?B?YTdScUFvMmFuT09mKytEYjBHeEkvUnZLUUREQkJ4NHIrc0oxbklubWdmUGMy?=
 =?utf-8?B?YWRRYmlzTXlFemhIbFAzdWk5V1pqeG05WXg0N2dIdEhJbXkrOWd4U0hBQTll?=
 =?utf-8?Q?r+MtLCfgiNJoDJhBnVG5qauwtk3z48pBwEkj0jb?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 293a0898-028f-4c46-21d7-08d98efb6a77
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2021 10:14:32.4992
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: eCzUBnwwHRBLau/syfUMUHP7AReENwUB/wzjqWseSpuMReaJRn1K7O17iRgRCCQzrpm7leS8JDAggz3tXDa13A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB7375

On 24.08.2021 12:50, Anthony PERARD wrote:
> This implement out-of-tree support, there's two ways to create an
> out-of-tree build tree (after that, `make` in that new directory
> works):
>     make O=build
>     mkdir build; cd build; make -f ../Makefile
> also works with an absolute path for both.
> 
> This implementation only works if the source tree is clean, as we use
> VPATH.
> 
> This patch copies most new code with handling out-of-tree build from
> Linux v5.12.
> 
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
> ---
>  xen/Makefile                | 173 +++++++++++++++++++++++++++++-------
>  xen/Rules.mk                |  11 ++-
>  xen/arch/arm/efi/Makefile   |   3 +
>  xen/arch/x86/arch.mk        |   3 +
>  xen/arch/x86/boot/Makefile  |   5 +-
>  xen/arch/x86/efi/Makefile   |   3 +
>  xen/include/Makefile        |   9 +-
>  xen/scripts/mkmakefile      |  17 ++++
>  xen/test/livepatch/Makefile |   2 +
>  xen/xsm/flask/Makefile      |   3 +
>  xen/xsm/flask/ss/Makefile   |   3 +
>  11 files changed, 194 insertions(+), 38 deletions(-)
>  create mode 100755 xen/scripts/mkmakefile

Linux have done away with this script just recently; I don't think we
should introduce it.

> --- a/xen/Makefile
> +++ b/xen/Makefile
> @@ -1,3 +1,7 @@
> +# $(lastword,) for GNU Make older than 0.81

DYM 3.81?

> +lastword = $(word $(words $(1)),$(1))
> +this-makefile := $(call lastword,$(MAKEFILE_LIST))

Oh - is it documented somewhere that this would always be last?

> @@ -17,33 +21,18 @@ export XEN_BUILD_HOST	?= $(shell hostname)
>  PYTHON_INTERPRETER	:= $(word 1,$(shell which python3 python python2 2>/dev/null) python)
>  export PYTHON		?= $(PYTHON_INTERPRETER)
>  
> -export XEN_ROOT := $(CURDIR)/..
> +$(if $(filter __%, $(MAKECMDGOALS)), \
> +	$(error targets prefixed with '__' are only for internal use))
>  
> -srctree := .
> -objtree := .
> -export srctree objtree
> +# That's our default target when none is given on the command line
> +PHONY := __all
> +__all:
>  
>  # Do not use make's built-in rules and variables
>  MAKEFLAGS += -rR
>  
>  EFI_MOUNTPOINT ?= $(BOOT_DIR)/efi
>  
> -ARCH=$(XEN_TARGET_ARCH)
> -SRCARCH=$(shell echo $(ARCH) | \
> -          sed -e 's/x86.*/x86/' -e s'/arm\(32\|64\)/arm/g' \
> -              -e s'/riscv.*/riscv/g')
> -export ARCH SRCARCH
> -
> -# Don't break if the build process wasn't called from the top level
> -# we need XEN_TARGET_ARCH to generate the proper config
> -include $(XEN_ROOT)/Config.mk
> -
> -# Set ARCH/SUBARCH appropriately.
> -export TARGET_SUBARCH  := $(XEN_TARGET_ARCH)
> -export TARGET_ARCH     := $(shell echo $(XEN_TARGET_ARCH) | \
> -                            sed -e 's/x86.*/x86/' -e s'/arm\(32\|64\)/arm/g' \
> -                                -e s'/riscv.*/riscv/g')
> -
>  # Allow someone to change their config file
>  export KCONFIG_CONFIG ?= .config

Would it be possible to split off some of the pure movement of pieces,
to make it easier to see what (if anything) is actually changed at the
same time as getting moved?

> @@ -51,14 +40,9 @@ export CC CXX LD
>  
>  export TARGET := xen
>  
> -.PHONY: default
> -default: build
> -
>  .PHONY: dist
>  dist: install
>  
> -include scripts/Kbuild.include
> -
>  ifneq ($(root-make-done),y)
>  # section to run before calling Rules.mk, but only once.
>  
> @@ -130,14 +114,93 @@ endif
>  
>  ifneq ($(findstring s,$(filter-out --%,$(MAKEFLAGS))),)
>      quiet := silent_
> +    KBUILD_VERBOSE = 0
>  endif

In how far is this related here? Doesn't this belong in an earlier patch?

>  export quiet Q KBUILD_VERBOSE
>  
> +# $(realpath,) for GNU Make older than 0.81

Again - 3.81?

> +ifeq ($(abs_srctree),$(abs_objtree))
> +        # building in the source tree
> +        srctree := .
> +	building_out_of_srctree :=
> +else
> +        ifeq ($(abs_srctree)/,$(dir $(abs_objtree)))
> +                # building in a subdirectory of the source tree
> +                srctree := ..
> +        else
> +                srctree := $(abs_srctree)
> +        endif
> +	building_out_of_srctree := 1
> +endif
> +
> +objtree		:= .
> +VPATH		:= $(srctree)

Would you mind using blank padding here, and perhaps fewer blanks than
the tabs are worth?

> --- a/xen/Rules.mk
> +++ b/xen/Rules.mk
> @@ -38,7 +38,7 @@ SPECIAL_DATA_SECTIONS := rodata $(foreach a,1 2 4 8 16, \
>                           $(foreach r,rel rel.ro,data.$(r).local)
>  
>  # The filename build.mk has precedence over Makefile
> -mk-dir := $(src)
> +mk-dir := $(srctree)/$(src)
>  include $(if $(wildcard $(mk-dir)/build.mk),$(mk-dir)/build.mk,$(mk-dir)/Makefile)

Perhaps already when it was changed to $(src) the name has become
slightly misleading, at least imo: I would rather expect a variable
with this name to refer to the build dir/tree. Maybe "srcdir" or
even shorted "sd" right from the start? (Reaching here I can finally
see why having a shorthand is helpful.)

> --- a/xen/arch/x86/efi/Makefile
> +++ b/xen/arch/x86/efi/Makefile
> @@ -1,5 +1,8 @@
>  CFLAGS-y += -fshort-wchar
>  CFLAGS-y += -I$(srctree)/common/efi
> +ifdef building_out_of_srctree
> +CFLAGS-y += -I$(srctree)/$(src)
> +endif

At the example of this (where perhaps -iquote could be used again) - is
it strictly necessary to have the ifdef-s around such? I.e. would things
fail to work for an in-tree build without them?

> --- a/xen/include/Makefile
> +++ b/xen/include/Makefile
> @@ -110,7 +110,7 @@ $(obj)/headers99.chk: $(PUBLIC_C99_HEADERS) $(src)/Makefile
>  	$(foreach i, $(filter %.h,$^),                                        \
>  	    echo "#include "\"$(i)\"                                          \
>  	    | $(CC) -x c -std=c99 -Wall -Werror                               \
> -	      -include stdint.h $(foreach j, $($(i)-prereq), -include $(j).h) \
> +	      -include stdint.h $(foreach j, $($(patsubst $(srctree)/%,%,$i)-prereq), -include $(j).h) \

Please split the $(foreach ...) from the earlier -include.

> @@ -124,8 +124,8 @@ $(obj)/headers++.chk: $(PUBLIC_HEADERS) $(src)/Makefile
>  	$(foreach i, $(filter %.h,$^),                                        \
>  	    echo "#include "\"$(i)\"                                          \
>  	    | $(CXX) -x c++ -std=gnu++98 -Wall -Werror -D__XEN_TOOLS__        \
> -	      -include stdint.h -include $(src)/public/xen.h                  \
> -	      $(foreach j, $($(i)-prereq), -include c$(j)) -S -o /dev/null -  \
> +	      -include stdint.h -include $(srctree)/$(src)/public/xen.h       \
> +	      $(foreach j, $($(patsubst $(srctree)/%,%,$i)-prereq), -include c$(j)) -S -o /dev/null -  \

Similarly here please split -S ... onto the next line.

> --- a/xen/xsm/flask/ss/Makefile
> +++ b/xen/xsm/flask/ss/Makefile
> @@ -9,3 +9,6 @@ obj-y += conditional.o
>  obj-y += mls.o
>  
>  CFLAGS-y += -I$(srctree)/xsm/flask/include
> +ifdef building_out_of_srctree
> +    CFLAGS-y += -I$(objtree)/xsm/flask/include

There's no header in $(srctree)/xsm/flask/include in this case, so if you
use "ifdef" here, shouldn't that other part move into an "else"?

Jan



From xen-devel-bounces@lists.xenproject.org Thu Oct 14 10:17:02 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Oct 2021 10:17:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.209233.365620 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maxnK-00024b-3M; Thu, 14 Oct 2021 10:17:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 209233.365620; Thu, 14 Oct 2021 10:17:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maxnK-00024U-0D; Thu, 14 Oct 2021 10:17:02 +0000
Received: by outflank-mailman (input) for mailman id 209233;
 Thu, 14 Oct 2021 10:17:00 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1maxnI-00024L-Pf
 for xen-devel@lists.xenproject.org; Thu, 14 Oct 2021 10:17:00 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1maxnH-00064S-Ct; Thu, 14 Oct 2021 10:16:59 +0000
Received: from 54-240-197-239.amazon.com ([54.240.197.239]
 helo=[192.168.16.43]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1maxnH-00039L-6E; Thu, 14 Oct 2021 10:16:59 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=GY10fllVgq55HqLtUE9e1EBLbt2kE/rasoKtHXXYd0o=; b=GTTnJb32v1wjFH/82OGehE2gVx
	tFedkFgSfue09xHwkpbjA/fVLq+rfmZ1rNOga2BI1i+fL/H0R/x5lfgI2j6hftR4uMx+wGxO2g3tx
	64ASDuN9gdZ9INFbahIvNGvEROWNOAJuOH1AWGqeCu39SGjRSiMmPfiu/NTXA0D4Ze3Q=;
Message-ID: <e786f0dd-dfa3-d45c-1fa4-1497efedc7ec@xen.org>
Date: Thu, 14 Oct 2021 11:16:56 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.2.0
Subject: Re: [PATCH] Revert "xen/domctl: Introduce XEN_DOMCTL_CDF_vpci flag"
To: Christian Lindig <christian.lindig@citrix.com>
Cc: Michal Orzel <michal.orzel@arm.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 David Scott <dave@recoil.org>, Ian Jackson <iwj@xenproject.org>,
 Wei Liu <wl@xen.org>, Andrew Cooper <Andrew.Cooper3@citrix.com>,
 George Dunlap <George.Dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Roger Pau Monne <roger.pau@citrix.com>,
 "bertrand.marquis@arm.com" <bertrand.marquis@arm.com>
References: <20211014084718.21733-1-michal.orzel@arm.com>
 <26a54c0f-7177-20d6-9186-08df5ebe852a@xen.org>
 <5C594BB0-FDF2-47B0-8E54-CEB154579F47@citrix.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <5C594BB0-FDF2-47B0-8E54-CEB154579F47@citrix.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit



On 14/10/2021 10:42, Christian Lindig wrote:
> 
> 
>> On 14 Oct 2021, at 10:33, Julien Grall <julien@xen.org 
>> <mailto:julien@xen.org>> wrote:
>>
>> Looking at the thread, we are only missing an ack for...
>>
>>> ---
>>>  tools/ocaml/libs/xc/xenctrl.ml  | 1 - > 
>>>   tools/ocaml/libs/xc/xenctrl.mli | 1 -
> 
> Acked-by: Christian Lindig <christian.lindig@citrix.com 
> <mailto:christian.lindig@citrix.com>>

Committed. Thank you!

Cheers,


-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Thu Oct 14 10:19:15 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Oct 2021 10:19:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.209240.365631 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maxpS-0002hY-Ft; Thu, 14 Oct 2021 10:19:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 209240.365631; Thu, 14 Oct 2021 10:19:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maxpS-0002hR-CV; Thu, 14 Oct 2021 10:19:14 +0000
Received: by outflank-mailman (input) for mailman id 209240;
 Thu, 14 Oct 2021 10:19:13 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Xl23=PC=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1maxpR-0002hJ-Pa
 for xen-devel@lists.xenproject.org; Thu, 14 Oct 2021 10:19:13 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 2cf4b8bb-2cd8-11ec-81b8-12813bfff9fa;
 Thu, 14 Oct 2021 10:19:12 +0000 (UTC)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2053.outbound.protection.outlook.com [104.47.12.53]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-20-s2Izz4m-MbaI65iAWeDn4Q-1; Thu, 14 Oct 2021 12:19:10 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB4381.eurprd04.prod.outlook.com (2603:10a6:803:6d::30)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16; Thu, 14 Oct
 2021 10:19:08 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.016; Thu, 14 Oct 2021
 10:19:08 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 FR3P281CA0051.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4a::9) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4628.10 via Frontend Transport; Thu, 14 Oct 2021 10:19:08 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2cf4b8bb-2cd8-11ec-81b8-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634206751;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=EOltcsqOZE+T2oTztPvYOhVv8pEFKs+NzKQA4A7f/Cs=;
	b=RRsL1aKw637/6IM7cdwmR+3Y4ONuANh4ABvL3efR2IqjwyWSXohKSGbrYUjQeHHwBqOr7Y
	pE6FmX97TfxeI0Lps0xWUZDWpoPU3xeFd8QQmiOpIYvfj+thaRD6N7LvDDhVUyD+0to2qH
	H9972jeYMzXdu5+3c+yR1b66FhF4PNc=
X-MC-Unique: s2Izz4m-MbaI65iAWeDn4Q-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=XEZaRnJbxHBB7AacaWMlSq3c+9D5wtJ5aN0CiADOzv0j6luP0gefN4vlzrCVUATAlRtgIcuyEphw2udO9cHfpJ9Um38tT/OE503W5nA13J5RMN+OvyV5IMaavBGL+ionxYszUFBzN6ySRwUB2sy+lK7ol8Zuw1H8wnz0+NzlTTSnOoLUxgmTSJh6mCByIETneR+Leg3qJdIR8YN6mNuaPTJmVPGajZkGbQZhLyRFZEiCH2ix4Nj31/anE3/Xi1U8PgfXV5L9PWURx7U+6MEVNJCGBCgRC1VpFyDLLlQLAZu/LTnoAgKJJ/qJ2CRpeOJp+UM6wHjrNkhbPJH8Tb0fpA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=EOltcsqOZE+T2oTztPvYOhVv8pEFKs+NzKQA4A7f/Cs=;
 b=hDcEb8+i620hr9JIculwAbB/Sl5Qj9BqJue3myhAjWKsBuvVcH/L1KuS5EvHd3Tx3boH3PUUd+JUbDZGm5xZYUqoaF6V+yE+LJQAvv0Wf5+FO4652nZJzRBMKLQw9z3bX73VY/tOZQpb70OsdA2OZqcx2WqbrTMQ6KAMdIxTuxizGKLgJrTcz+IgQgQcGxj3pQpYrmf7rgvCmP2i2eWe06tNaoMQLwMOKvzExTDXl/ui0cUW/vGFaD8a3DJs1sOY4ZcN/Pg/16Nq3r73Z0VHQgw9Vbllb9jw9MCyienTFHMd8Q8JyCyPQcEk135Lcl3eMyQCFShUstOV6tFpXL82hw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [XEN PATCH v7 50/51] build: specify source tree in include/ for
 prerequisite
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>, xen-devel@lists.xenproject.org
References: <20210824105038.1257926-1-anthony.perard@citrix.com>
 <20210824105038.1257926-51-anthony.perard@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <d9591c5f-9cff-e135-1d1e-c79a82095da7@suse.com>
Date: Thu, 14 Oct 2021 12:19:06 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <20210824105038.1257926-51-anthony.perard@citrix.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR3P281CA0051.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:4a::9) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: b204bb77-caca-4c0e-8a0c-08d98efc0f00
X-MS-TrafficTypeDiagnostic: VI1PR04MB4381:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB4381269E9EEFDC066611A09DB3B89@VI1PR04MB4381.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:4502;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	jwDsdfpUe33Qt+lQyn5H4XkgEIaWAh3yYPmwqhYhGmp1KCHa1Dp/MLWAYp11LCAXP/d7RhWU1op0Z/HzZ71u2P3jvLvMIvlBMZPEqEYXRuHkMbG3wu0Y5t+6Y0q7dtAv0SWVVbsYLvyyErQRjQh8EWK5QEzb9Yyf+ttmE/Fub1CiisIefSG9JPqsDScfi+vDkXXTt8/XyB/2b4cByyZOOqfTIA1HLVFkDaVjWHtIBqq6SAlrtnMf70rkgBlvYm2SlGy1pK17uf4HKyMKIzo4Yknpx17Sj/13qV4gxBjK8rNziSt58vBFKW6UYPwn1ABSIRzUNg/SaPQTSTowzx7mGYIxARmM/k5q0zuF2OLf+DarArQTnLtgAH9RRQCiyGAJ9/+aQq6wIa77nVNfiI9BGlvKEz7IStBGRUE83Psr/nsNruNPVsMZhWM/wLS+1ZPEST7ox7HCrkFndK+dnwnjxlf7wGAlYyYPt8TAim4bRcOwUGtjDfvJQeec1ec2zb4WpoJj6jqrbjjYyzLLTIuw7sgpXlAK52dRJrNF2L+YVkNWEAWNAw13TpT5+K0Zq/7nRfZ8JKALrvvam0lFVIw40W2Pmtwrr1BFjQMwHj8o9BhbvRDqZwhwMetdLAFhP3xXaHLtD2TgFe6EC12P+yB4h49YV4bx42LtXuMiqSji2DtvOIcbOvSOYuFXeBH36jI2UBvu6pFcbmq1W+U4uMjJVoVONHgLGZLcy64+E+UdwE8=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(4326008)(53546011)(26005)(66556008)(31686004)(36756003)(956004)(508600001)(5660300002)(2616005)(6486002)(38100700002)(86362001)(16576012)(316002)(6916009)(8936002)(186003)(66946007)(4744005)(8676002)(2906002)(54906003)(66476007)(31696002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?QkFrK0dGK2gwek1lRndGUnMrRTQ2NUt6bVN1YW9PbUw4Rjl6ZzlGK2FnbUw4?=
 =?utf-8?B?R1kxVzBlenlDM01GSG5UV2srd2l1VTJBYjBzTFV1RDF6azF0b21vMGY4YTV2?=
 =?utf-8?B?MVBaNmU0RlkweHF3SnVVV3dXWEkvc0llSEhKY2hteXA3ZjNBd3JGdU4wc29p?=
 =?utf-8?B?dTFYemxzd1ZuZjl2S0RzTXBVb1hOLzJ1ZmdianBrRnY2Z3paK29kTHkrZFpV?=
 =?utf-8?B?eERTT3RvZW84UDFhcG5hM0lTSDJkZVVZMmVTV2dHcUNFU2FvdloxVUo0MUtO?=
 =?utf-8?B?RFNlcklDaXRwdnNEWi9FeFY5RUt3d0lYd3JQQXBkTmZocXQ4ZGVXRFkwVkdN?=
 =?utf-8?B?b0lHdGVOSWI3TElsVGdFRnNDL0Roc1ZJQUd4YWszbTJ2akVGUFAzeDFlQXpt?=
 =?utf-8?B?S1RXRlFpeG5zMkZQdThiK1krcEZGMFIzaVJ1R3pxNWd5aFh5Vi8xeWRaVVZw?=
 =?utf-8?B?czN4YXhRS0o3MTlxSmoxWlB5c25CdDJnVjdhem12UEx4R096RUxRbjQyY2dz?=
 =?utf-8?B?L0FHT2NvQUF4aks2cUNjcXk2Zko3bG9UZ21TYmU1UFltWFdDUWlYNkVpVFhS?=
 =?utf-8?B?dEVqK0NWU3N6c0tDck5UK3IzVXgxSFhmczBIcHhYNEdKR2NESHU1TVVoUU9p?=
 =?utf-8?B?dVlwQ1QzN3hlZmovbDliWFg5MG1pRzdodlhvOHNkcEpiQytvekdPVXlWYjV5?=
 =?utf-8?B?cWN6ek1LRitjMEQxa3NQTzlXWmNQYkhJaDF1QnEyNGxHMThLaFEyUVIyVU5w?=
 =?utf-8?B?QW1nTnJZeGliUEY0czdmRWVaM3Z3bUs1Wjh3SEttelZ6RHhGRVVibnUzSWNj?=
 =?utf-8?B?NUltWVNxYldERlhZWFpEK256NmpRYXQrUFV1dnFoUjFkWlN1dGFrN25KR1lI?=
 =?utf-8?B?YVN4MFdlRG9yRXJOUmRsTHkrUjlvQzNxU3UxZFJKcTJFTEpBZHRnbVRFclQr?=
 =?utf-8?B?akxGTHE5dFI2ZHgyYi8zU0F5dEZaUnFWSmFiTHAwRFRtcGVvckEyaEQyV0hu?=
 =?utf-8?B?YTl0MFJqamVtVFo1c0loQlcvcnVkRXJ2SXVLM3dia1RXd1o3U1drSkk2YjAw?=
 =?utf-8?B?VWFoanpMYmNqZkVGWFp6NmlNQnpZQWlWOUV5MjQ5TG5sNjhhdmkzUWNOaGEy?=
 =?utf-8?B?MFhZaTFwNmJ0VjRPaXJOYnVYWDYxd284YjFpQlJWcDJRSmluTm01Qk9US2lm?=
 =?utf-8?B?ait2WDhPSEtFWThmMmU0K2RjOElSdVhnWXhBQUNLd1g3ZkFOT3RqVFk2b2Mr?=
 =?utf-8?B?a3ZqcnJQN2lERjRaV3NKM3ZRMUdHUXlEK012c3prNzFiOVk2WGw1dHVMQ25O?=
 =?utf-8?B?NDRtUmoyZmtkQmdTYTRMdUxTYnpUaEJaKzF0M0lnMEY0dm1aYmswUGM3bmN2?=
 =?utf-8?B?aUJhU09OM3k0a1pBdVdKZE11VU9hRnNCSmpsWTFvaFYzWE0zRS9nZzdDQXV4?=
 =?utf-8?B?S0MvMkdiSXhBU3pValhTRG5DYjl6S25seHNhdzNLeXpySzNYQ1dCQTJheHR3?=
 =?utf-8?B?MTlOV2pIVjFSMkxhTkQzbnBwNnJaVmMvNTVKZnJsRWREVEtkUGRZZVlKMXE3?=
 =?utf-8?B?RjA5NDY2UDJSQm9penpVcS9RVWVuYkhxcVJDK3MvOEdCRnU4MXRBdk5JMVdt?=
 =?utf-8?B?aFJRRnRIakNHbnFDbmR2NFd2dy92eGJ2NDkrN1E4YnBVZlgwWkVJOEZ6Y2J5?=
 =?utf-8?B?OEJpVlhhKzVjN2dBRkJhY3k0Rzl0YnBDMkNybU14UFZnVDhtRzJFcGFxU1lL?=
 =?utf-8?Q?+/ChC9ZxrJETPYmqim/j5DHRR5W6koMcxx55hN9?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b204bb77-caca-4c0e-8a0c-08d98efc0f00
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2021 10:19:08.5291
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: NVyct1LNuJV3nr+n3nMoUobWiw6nYaGwucWz0dgpNChZDMHTMbAfpB0OSyrzQ/dY8cXBnBWJwKG4u797QGWqAA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4381

On 24.08.2021 12:50, Anthony PERARD wrote:
> When doing an out-of-tree build, and thus setting VPATH,
> GNU Make 0.81 on Ubuntu Trusty complains about Circular dependency of
> include/Makefile and include/xlat.lst and drop them. The build fails
> later due to headers malformed.

Doesn't this change need to come ahead of the one enabling out-of-tree
builds then? Also do you again mean 3.81?

Jan



From xen-devel-bounces@lists.xenproject.org Thu Oct 14 11:29:28 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Oct 2021 11:29:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.209256.365649 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mayvC-000140-1c; Thu, 14 Oct 2021 11:29:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 209256.365649; Thu, 14 Oct 2021 11:29:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mayvB-00013t-Us; Thu, 14 Oct 2021 11:29:13 +0000
Received: by outflank-mailman (input) for mailman id 209256;
 Thu, 14 Oct 2021 11:29:12 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mayvA-00013n-Jy
 for xen-devel@lists.xenproject.org; Thu, 14 Oct 2021 11:29:12 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mayv8-0007FB-Fw; Thu, 14 Oct 2021 11:29:10 +0000
Received: from 54-240-197-239.amazon.com ([54.240.197.239]
 helo=[192.168.16.43]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mayv8-00083n-A6; Thu, 14 Oct 2021 11:29:10 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=q1KyYt4EdZVP4UDyrC5nCFv/2ZeCUGGzkQu5Ue7ucE0=; b=gBObF8ia5gFib5epUpWnoU7CwQ
	wbLF6oBidknLb2pare9iZjk7KIy9p+nf95gi/zXUeeP66ZASwhNY6EYD8/FC0lij9ssyi7tf3fnk0
	cFCxvRs76USQYiJRbww58i9stZZ9lN5HcNmbdAULvbZJIjTYkZMNVmxmhNZWsmNmGjmo=;
Message-ID: <561dcb90-7b6d-4dd6-2ca7-a4a5ec1c5e35@xen.org>
Date: Thu, 14 Oct 2021 12:29:08 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.2.0
Subject: Re: [PATCH 2/2] memory: XENMEM_add_to_physmap (almost) wrapping
 checks
To: Jan Beulich <jbeulich@suse.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
References: <4f54456b-e8da-f67f-b6a0-b5ce2cf12cae@suse.com>
 <f78f8a30-39b7-cec2-2af0-27ebab28cedd@suse.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <f78f8a30-39b7-cec2-2af0-27ebab28cedd@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Jan,

On 13/09/2021 07:42, Jan Beulich wrote:
> Determining that behavior is correct (i.e. results in failure) for a
> passed in GFN equaling INVALID_GFN is non-trivial. Make this quite a
> bit more obvious by checking input in generic code - both for singular
> requests to not match the value and for range ones to not pass / wrap
> through it.
> 
> For Arm similarly make more obvious that no wrapping of MFNs passed
> for XENMAPSPACE_dev_mmio and thus to map_dev_mmio_region() can occur:
> Drop the "nr" parameter of the function to avoid future callers
> appearing which might not themselves check for wrapping. Otherwise
> the respective ASSERT() in rangeset_contains_range() could trigger.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> ---
> I find it odd that map_dev_mmio_region() returns success upon
> iomem_access_permitted() indicating failure - is this really intended?

AFAIR yes. The hypercall is not used as "Map the region" but instead 
"Make sure the region is mapped if the IOMEM region is accessible".

It is necessary to return 0 because dom0 OS cannot distinguished between 
emulated and non-emulated. So we may report error when there is none.

> As per commit 102984bb1987 introducing it this also was added for ACPI
> only - any reason XENMAPSPACE_dev_mmio isn't restricted to CONFIG_ACPI
> builds?

There is nothing specific to ACPI in the implementation. So I don't 
really see the reason to restrict to CONFIG_ACPI.

However, it is still possible to boot using DT when Xen is built with 
CONFIG_ACPI. So if the restriction was desirable, then I think it should 
be using !acpi_disabled.

> 
> I'd be happy to take suggestions towards avoiding the need to #define
> _gfn() around the BUILD_BUG_ON() being added. I couldn't think of
> anything prettier.
> 
> --- a/xen/arch/arm/mm.c
> +++ b/xen/arch/arm/mm.c
> @@ -1479,7 +1479,7 @@ int xenmem_add_to_physmap_one(
>           break;
>       }
>       case XENMAPSPACE_dev_mmio:
> -        rc = map_dev_mmio_region(d, gfn, 1, _mfn(idx));
> +        rc = map_dev_mmio_region(d, gfn, _mfn(idx));
>           return rc;
>   
>       default:
> --- a/xen/arch/arm/p2m.c
> +++ b/xen/arch/arm/p2m.c
> @@ -1360,19 +1360,18 @@ int unmap_mmio_regions(struct domain *d,
>   
>   int map_dev_mmio_region(struct domain *d,
>                           gfn_t gfn,
> -                        unsigned long nr,
>                           mfn_t mfn)
>   {
>       int res;
>   
> -    if ( !(nr && iomem_access_permitted(d, mfn_x(mfn), mfn_x(mfn) + nr - 1)) )
> +    if ( !iomem_access_permitted(d, mfn_x(mfn), mfn_x(mfn)) )
>           return 0;
>   
> -    res = p2m_insert_mapping(d, gfn, nr, mfn, p2m_mmio_direct_c);
> +    res = p2m_insert_mapping(d, gfn, 1, mfn, p2m_mmio_direct_c);
>       if ( res < 0 )
>       {
> -        printk(XENLOG_G_ERR "Unable to map MFNs [%#"PRI_mfn" - %#"PRI_mfn" in Dom%d\n",
> -               mfn_x(mfn), mfn_x(mfn) + nr - 1, d->domain_id);
> +        printk(XENLOG_G_ERR "Unable to map MFN %#"PRI_mfn" in %pd\n",
> +               mfn_x(mfn), d);
>           return res;
>       }
>   
> --- a/xen/common/grant_table.c
> +++ b/xen/common/grant_table.c
> @@ -4132,7 +4132,10 @@ int gnttab_map_frame(struct domain *d, u
>       bool status = false;
>   
>       if ( gfn_eq(gfn, INVALID_GFN) )
> +    {
> +        ASSERT_UNREACHABLE();
>           return -EINVAL;
> +    }
>   
>       grant_write_lock(gt);
>   
> --- a/xen/common/memory.c
> +++ b/xen/common/memory.c
> @@ -831,6 +831,9 @@ int xenmem_add_to_physmap(struct domain
>           return -EACCES;
>       }
>   
> +    if ( gfn_eq(_gfn(xatp->gpfn), INVALID_GFN) )
> +        return -EINVAL;
> +
>       if ( xatp->space == XENMAPSPACE_gmfn_foreign )
>           extra.foreign_domid = DOMID_INVALID;
>   
> @@ -841,6 +844,15 @@ int xenmem_add_to_physmap(struct domain
>       if ( xatp->size < start )
>           return -EILSEQ;
>   
> +    if ( xatp->gpfn + xatp->size < xatp->gpfn ||
> +         xatp->idx + xatp->size < xatp->idx )
> +    {
> +#define _gfn(x) (x)

AFAICT, _gfn() will already be defined. So some compiler may complain 
because will be defined differently on debug build. However...

> +        BUILD_BUG_ON(INVALID_GFN + 1);

... I might be missing something... but why can't use gfn_x(INVALID_GFN) 
+ 1 here?

In fact, I am not entirely sure what's the purpose of this 
BUILD_BUG_ON(). Could you give more details?

> +#undef _gfn
> +        return -EOVERFLOW;
> +    }
> +
>       xatp->idx += start;
>       xatp->gpfn += start;
>       xatp->size -= start;
> @@ -961,6 +973,9 @@ static int xenmem_add_to_physmap_batch(s
>                                                  extent, 1)) )
>               return -EFAULT;
>   
> +        if ( gfn_eq(_gfn(gpfn), INVALID_GFN) )
> +            return -EINVAL;
> +
>           rc = xenmem_add_to_physmap_one(d, xatpb->space, extra,
>                                          idx, _gfn(gpfn));
>   
> --- a/xen/include/asm-arm/p2m.h
> +++ b/xen/include/asm-arm/p2m.h
> @@ -297,7 +297,6 @@ int unmap_regions_p2mt(struct domain *d,
>   
>   int map_dev_mmio_region(struct domain *d,
>                           gfn_t gfn,
> -                        unsigned long nr,
>                           mfn_t mfn);
>   
>   int guest_physmap_add_entry(struct domain *d,
> 

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Thu Oct 14 11:35:01 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Oct 2021 11:35:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.209263.365660 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maz0j-0002SO-MN; Thu, 14 Oct 2021 11:34:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 209263.365660; Thu, 14 Oct 2021 11:34:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maz0j-0002SH-JZ; Thu, 14 Oct 2021 11:34:57 +0000
Received: by outflank-mailman (input) for mailman id 209263;
 Thu, 14 Oct 2021 11:34:56 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1maz0i-0002SB-NU
 for xen-devel@lists.xenproject.org; Thu, 14 Oct 2021 11:34:56 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1maz0i-0007Kl-JB
 for xen-devel@lists.xenproject.org; Thu, 14 Oct 2021 11:34:56 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1maz0i-0008WI-I7
 for xen-devel@lists.xenproject.org; Thu, 14 Oct 2021 11:34:56 +0000
Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89)
 (envelope-from <iwj@xenproject.org>)
 id 1maz0e-0002Fd-Ue; Thu, 14 Oct 2021 12:34:53 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date
	:Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From;
	bh=khhwplVHTvRXCWsE6AjUAL0Z2TBNR2tQRRP7dR9X7Oc=; b=sGDy88FxuJ6e9vmgZX+uIkqmjh
	ukqTM9DB0hga9eKWmqaBNUiKO6NXqU24F9Ycn3pv9/UDIB7hL0roSTbTOdVFecBIiRSpporVzhJrq
	3mlOWaWMTd2jtLm6OuJrUr+ClQNWM/7si4G0YS7ose7sBPLoIxe96u2QR1Qepj5FsC9Q=;
From: Ian Jackson <iwj@xenproject.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <24936.5596.598869.471516@mariner.uk.xensource.com>
Date: Thu, 14 Oct 2021 12:34:52 +0100
To: Michal Orzel <michal.orzel@arm.com>
Cc: xen-devel@lists.xenproject.org,
    Christian Lindig <christian.lindig@citrix.com>,
    David Scott <dave@recoil.org>,
    Wei Liu <wl@xen.org>,
    Andrew Cooper <andrew.cooper3@citrix.com>,
    George Dunlap <george.dunlap@citrix.com>,
    Jan Beulich <jbeulich@suse.com>,
    Julien Grall <julien@xen.org>,
    Stefano Stabellini <sstabellini@kernel.org>,
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
    Roger Pau =?iso-8859-1?Q?Monn=E9?= <roger.pau@citrix.com>,
    bertrand.marquis@arm.com
Subject: Re: [PATCH] Revert "xen/domctl: Introduce XEN_DOMCTL_CDF_vpci flag"
In-Reply-To: <20211014084718.21733-1-michal.orzel@arm.com>
References: <20211014084718.21733-1-michal.orzel@arm.com>
X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu)

Michal Orzel writes ("[PATCH] Revert "xen/domctl: Introduce XEN_DOMCTL_CDF_vpci flag""):
> This reverts commit 2075b410ee8087662c880213c3aca196fb7ade22.
> 
> During the discussion [1] that took place after
> the patch was merged it was agreed that it should
> be reverted to avoid introducing a bad interface.
> 
> Furthermore, the patch rejected usage of flag
> XEN_DOMCTL_CDF_vpci for x86 which is not true
> as it should be set for dom0 PVH.
> 
> Due to XEN_DOMCTL_CDF_vpmu being introduced after
> XEN_DOMCTL_CDF_vpci, modify its bit position
> from 8 to 7.
> 
> [1] https://marc.info/?t=163354215300039&r=1&w=2

FTAOD, I don't think this will be necessary, but preemptively,

Release-Acked-by: Ian Jackson <iwj@xenproject.org>


From xen-devel-bounces@lists.xenproject.org Thu Oct 14 11:41:01 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Oct 2021 11:41:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.209270.365672 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maz6W-0003sN-C6; Thu, 14 Oct 2021 11:40:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 209270.365672; Thu, 14 Oct 2021 11:40:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maz6W-0003sG-8j; Thu, 14 Oct 2021 11:40:56 +0000
Received: by outflank-mailman (input) for mailman id 209270;
 Thu, 14 Oct 2021 11:40:55 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+gDO=PC=gmail.com=olekstysh@srs-us1.protection.inumbo.net>)
 id 1maz6V-0003sA-Gd
 for xen-devel@lists.xenproject.org; Thu, 14 Oct 2021 11:40:55 +0000
Received: from mail-wr1-x433.google.com (unknown [2a00:1450:4864:20::433])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id aae84a1f-e9be-42bc-88db-1b916233777e;
 Thu, 14 Oct 2021 11:40:54 +0000 (UTC)
Received: by mail-wr1-x433.google.com with SMTP id y3so18596244wrl.1
 for <xen-devel@lists.xenproject.org>; Thu, 14 Oct 2021 04:40:54 -0700 (PDT)
Received: from otyshchenko.router ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id g16sm2151359wrs.90.2021.10.14.04.40.52
 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
 Thu, 14 Oct 2021 04:40:53 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: aae84a1f-e9be-42bc-88db-1b916233777e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id;
        bh=2B6ffoE1T+Ba8jSZoqM2d9GfJE5GrmzdiCnzToqEBN4=;
        b=WSDnXXR7zArz4AlakF7fvJlWYyoGyeZyPPnujPwDjIPb8DqgXYg0LQfhgJE26GXQ/V
         1LQWTVMeNDJdYHbkATPNrsXDWg7pxHhpDY7DYtsGejPnBbB670CiMnvYZaCUEw2gfn5G
         jyC/0l9iSuSGsS+9X75f+DSK6OD+AhrVCzKN8+s51mO7hgGCfjQHiJMAiT85JnjNPQf4
         EzveZHf5ULJJpKE4baZpIc9RgvpIk1YEUs5tUJ+sGJK4nupZABnbNvMqvXemG0fsGLGM
         pQHeHsxIytpxt45ciVDHImUMCdqw1IKrWeRE7QLd5K0qLuiGWwtlWDol0i4eDaJTspnW
         ix+A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id;
        bh=2B6ffoE1T+Ba8jSZoqM2d9GfJE5GrmzdiCnzToqEBN4=;
        b=xGLBEcfLq1BrUFXis4snoeqQhLf2izGQfkvA1plst8m4ALAkW+8AQYgJ47/WglHgRh
         fsPaUospeNSt+FL7Ctgp6uwQXoHetJWsIlS5vurkxJ58s7XprNg1YWze0mnTmWWl6QM4
         CE5f+nCZj3c0vSdN61mxV6JM64f5eza2Dn3V2gTBweK3Aw2CYCiIZLF0rswyF+aaKcP+
         jXNT3i3+n5WnoAjvoptanc79GNnJ320QXH9TeOpyoGyb2judX7wdfzO1QiVOXN94xB3+
         CJHlmBgf25XOXf2uVOPhYmAvPa+qcjbEo5dWGkmbeS9YGsjCDBhjfg9hPqzZNilTcira
         K3SA==
X-Gm-Message-State: AOAM531rYK8WHB9mNYijm9T++roK6ZhMVJfEOocoZc2s5mVczxgjHc2c
	75iTica/GTGx4jvsUNhccN5/qrUsWKM=
X-Google-Smtp-Source: ABdhPJxKVZhpO01Gpygyoo1zIaFZvKuAXjU73lrB+UDLxee/mfTyrggtPUkb1Oo8ZDhBi/6zza9YeQ==
X-Received: by 2002:adf:a1cc:: with SMTP id v12mr6229915wrv.48.1634211653404;
        Thu, 14 Oct 2021 04:40:53 -0700 (PDT)
From: Oleksandr Tyshchenko <olekstysh@gmail.com>
To: xen-devel@lists.xenproject.org
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Ian Jackson <iwj@xenproject.org>,
	Wei Liu <wl@xen.org>,
	Anthony PERARD <anthony.perard@citrix.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Juergen Gross <jgross@suse.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	Henry Wang <Henry.Wang@arm.com>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Wei Chen <Wei.Chen@arm.com>
Subject: [PATCH V7 0/2] Add handling of extended regions (safe ranges) on Arm (Was "xen/memory: Introduce a hypercall to provide unallocated space")
Date: Thu, 14 Oct 2021 14:40:43 +0300
Message-Id: <1634211645-26912-1-git-send-email-olekstysh@gmail.com>
X-Mailer: git-send-email 2.7.4

From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>

You can find an initial discussion at [1]-[7].

The extended region (safe range) is a region of guest physical address space
which is unused and could be safely used to create grant/foreign mappings instead
of wasting real RAM pages from the domain memory for establishing these mappings.

The extended regions are chosen at the domain creation time and advertised
to it via "reg" property under hypervisor node in the guest device-tree
(the indexes for extended regions are 1...N).
No device tree bindings update is needed, guest infers the presense of extended
regions from the number of regions in "reg" property.
New compatible/property will be needed (but only after this patch [8] or alternative
goes in) to indicate that "region 0 is safe to use". Until this patch is merged it is
not safe to use extended regions for the grant table space.

The extended regions are calculated differently for direct mapped Dom0 (with and without
IOMMU) and non-direct mapped DomUs.

Please note the following limitations:
- The extended region feature is only supported for 64-bit domain currently.
- The ACPI case is not covered.

Please note that support for Dom0 was already committed, so these patches are remaining DomU bits.

Xen patch series is also available at [9]. The corresponding Linux patch series is at [10]
for now (last 4 patches).

Tested on Renesas Salvator-X board + H3 ES3.0 SoC (Arm64) with updated virtio-disk backend [11]
running in Dom0 (256MB RAM) and DomD (2GB RAM). In both cases the backend pre-maps DomU memory
which is 3GB. All foreign memory gets mapped into extended regions (so the amount of RAM in
the backend domain is not reduced). No issues were observed.

[1] https://lore.kernel.org/xen-devel/1627489110-25633-1-git-send-email-olekstysh@gmail.com/
[2] https://lore.kernel.org/xen-devel/1631034578-12598-1-git-send-email-olekstysh@gmail.com/
[3] https://lore.kernel.org/xen-devel/1631297924-8658-1-git-send-email-olekstysh@gmail.com/
[4] https://lore.kernel.org/xen-devel/1632437334-12015-1-git-send-email-olekstysh@gmail.com/
[5] https://lore.kernel.org/xen-devel/1632955927-27911-1-git-send-email-olekstysh@gmail.com/
[6] https://lore.kernel.org/xen-devel/1633519346-3686-1-git-send-email-olekstysh@gmail.com/
[7] https://lore.kernel.org/xen-devel/1633974539-7380-1-git-send-email-olekstysh@gmail.com/
[8] https://lore.kernel.org/xen-devel/1632425551-18910-1-git-send-email-olekstysh@gmail.com/
[9] https://github.com/otyshchenko1/xen/commits/map_opt_ml8
[10] https://github.com/otyshchenko1/linux/commits/map_opt_ml4
[11] https://github.com/otyshchenko1/virtio-disk/commits/map_opt_next

Oleksandr Tyshchenko (2):
  xen/arm: Introduce gpaddr_bits field to struct
    xen_domctl_getdomaininfo
  libxl/arm: Add handling of extended regions for DomU

 tools/include/libxl.h            |   8 +++
 tools/include/xenctrl.h          |   1 +
 tools/libs/ctrl/xc_domain.c      |   1 +
 tools/libs/light/libxl_arm.c     | 106 +++++++++++++++++++++++++++++++++++++--
 tools/libs/light/libxl_domain.c  |   1 +
 tools/libs/light/libxl_types.idl |   1 +
 xen/arch/arm/domctl.c            |   2 +
 xen/arch/x86/domctl.c            |   1 +
 xen/common/domctl.c              |   4 +-
 xen/common/sysctl.c              |   2 +-
 xen/include/public/arch-arm.h    |   5 ++
 xen/include/public/domctl.h      |   3 ++
 xen/include/public/sysctl.h      |   2 +-
 13 files changed, 128 insertions(+), 9 deletions(-)

-- 
2.7.4



From xen-devel-bounces@lists.xenproject.org Thu Oct 14 11:41:01 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Oct 2021 11:41:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.209271.365683 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maz6b-00049x-L1; Thu, 14 Oct 2021 11:41:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 209271.365683; Thu, 14 Oct 2021 11:41:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maz6b-00049q-GI; Thu, 14 Oct 2021 11:41:01 +0000
Received: by outflank-mailman (input) for mailman id 209271;
 Thu, 14 Oct 2021 11:41:00 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+gDO=PC=gmail.com=olekstysh@srs-us1.protection.inumbo.net>)
 id 1maz6a-0003sA-DB
 for xen-devel@lists.xenproject.org; Thu, 14 Oct 2021 11:41:00 +0000
Received: from mail-wr1-x436.google.com (unknown [2a00:1450:4864:20::436])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id c2b3fd70-c0e9-40c5-a209-0f42a45a465b;
 Thu, 14 Oct 2021 11:40:55 +0000 (UTC)
Received: by mail-wr1-x436.google.com with SMTP id m22so18673363wrb.0
 for <xen-devel@lists.xenproject.org>; Thu, 14 Oct 2021 04:40:55 -0700 (PDT)
Received: from otyshchenko.router ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id g16sm2151359wrs.90.2021.10.14.04.40.53
 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
 Thu, 14 Oct 2021 04:40:54 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c2b3fd70-c0e9-40c5-a209-0f42a45a465b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references;
        bh=Svlz/0Yb6tw+86OBsJrg6OP0a5Eri0NBAH2C09SaqC0=;
        b=oks9Er860d2+4A7aHFIIpKoQz6/W3vEn4gWpxVqBsled2mJXaMGLG4/cpos2vs8LuX
         s7n5LfDcHswweI048uQqdOCwVNy6ULv1bwQSmMsLMJLXuMWTmdj2XcyUTjRcOdQdSauC
         jCeSd6zprrJSnA+DCaLD0Vgm5FD8iRiNtIb2w9aI2mSM73QpSAzcohh91p11jl9h9MAE
         Rpn550vwH5Xifis/YiSJWo5y0rCNg3eigNwahC2MqpnklA7xLMKbKx7H7QhIIcEmMJyT
         ZNharcrl+9K2m2b99f6zwBG/je9ILVl/QclBVXYU/H8Z0RZwQvzl7DEo1GMP3Iitr0Nc
         ic+g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references;
        bh=Svlz/0Yb6tw+86OBsJrg6OP0a5Eri0NBAH2C09SaqC0=;
        b=FrhttsaXQ24oeRhM0F3WEZUOEDlcQDJ0lcMaiVAqgSQNdvmWeZCOS7JblqVRvFnKh3
         V6nw0/sNomdCTJ7SbHXJZQ6q/sCGjXu7NHtJ9mfuY/+Tt2yauVC1Ws5pUA4ZRVv3oRB9
         0kw1hD2vkRobPrY7VIV1OLpJLePajaPaEyDufhfvsQFJoJtv1bzBrV/fvMBM1zJqRqCp
         BiAXXPLlYwyamcfgb16IwxMt9hzFYaNdu+rlpObkv+FLoGSNfXM0K1AyKlQ0GwxQnjjW
         4aPARiYn9orLDqPG27i/GHVmerotb+bBakKtYS81BCE9rkwZ2zH5ntAfbo/g5WLlWa3r
         3BWQ==
X-Gm-Message-State: AOAM5331aJ6pPrN7aKil1EZ/dGS2PnXYMvIohIKnEVQgV8Bu1GFd4F6p
	bwVz8NpjYFOPnA7+xmvEA0X9SUBZG6M=
X-Google-Smtp-Source: ABdhPJxOvDsNjqWp7O21x29E+3d1JC4DGADWgcqQD2Bl4wukSFbOY+TyQMwDmj7pFg3awbER7g/RUw==
X-Received: by 2002:adf:a34c:: with SMTP id d12mr6211652wrb.267.1634211654333;
        Thu, 14 Oct 2021 04:40:54 -0700 (PDT)
From: Oleksandr Tyshchenko <olekstysh@gmail.com>
To: xen-devel@lists.xenproject.org
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Ian Jackson <iwj@xenproject.org>,
	Wei Liu <wl@xen.org>,
	Anthony PERARD <anthony.perard@citrix.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Juergen Gross <jgross@suse.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>
Subject: [PATCH V7 1/2] xen/arm: Introduce gpaddr_bits field to struct xen_domctl_getdomaininfo
Date: Thu, 14 Oct 2021 14:40:44 +0300
Message-Id: <1634211645-26912-2-git-send-email-olekstysh@gmail.com>
X-Mailer: git-send-email 2.7.4
In-Reply-To: <1634211645-26912-1-git-send-email-olekstysh@gmail.com>
References: <1634211645-26912-1-git-send-email-olekstysh@gmail.com>

From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>

We need to pass info about maximum supported guest physical
address space size to the toolstack on Arm in order to properly
calculate the base and size of the extended region (safe range)
for the guest. The extended region is unused address space which
could be safely used by domain for foreign/grant mappings on Arm.
The extended region itself will be handled by the subsequent
patch.

Currently the same guest physical address space size is used
for all guests (p2m_ipa_bits variable on Arm, the x86 equivalent
is hap_paddr_bits).

Add an explicit padding after "gpaddr_bits" field and also
(while at it) after "domain" field.

Also make sure that full structure is cleared in all cases by
moving the clearing into getdomaininfo(). Currently it is only
cleared by the sysctl caller (and only once).

Please note, we do not need to bump XEN_DOMCTL_INTERFACE_VERSION
as a bump has already occurred in this release cycle. But we do
need to bump XEN_SYSCTL_INTERFACE_VERSION as the structure is
re-used in a sysctl.

Suggested-by: Julien Grall <jgrall@amazon.com>
Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
Reviewed-by: Ian Jackson <iwj@xenproject.org>
[hypervisor parts]
Reviewed-by: Jan Beulich <jbeulich@suse.com>
---
Changes RFC -> V2:
   - update patch subject/description
   - replace arch-specific sub-struct with common gpaddr_bits
     field and update code to reflect that

Changes V2 -> V3:
   - make the field uint8_t and add uint8_t pad[7] after
   - remove leading blanks in libxl.h

Changes V3 -> V4:
   - also print gpaddr_bits from output_physinfo()
   - add Michal's R-b

Changes V4 -> V5:
   - update patch subject and description
   - drop Michal's R-b
   - pass gpaddr_bits via createdomain domctl
     (struct xen_arch_domainconfig)

Changes V5 -> V6:
   - update patch subject and description
   - pass gpaddr_bits via getdomaininfo domctl
     (struct xen_domctl_getdomaininfo)

Changes V6 -> V7:
   - update patch description
   - do not bump XEN_DOMCTL_INTERFACE_VERSION
   - bump XEN_SYSCTL_INTERFACE_VERSION
   - add explicit paddings
   - clear the full structure in getdomaininfo()

Changes V7 -> V7.1:
   - add Jan's R-b
   - drop non-useful change (info->flags |= ...) in getdomaininfo()
---
 tools/include/libxl.h            | 8 ++++++++
 tools/include/xenctrl.h          | 1 +
 tools/libs/ctrl/xc_domain.c      | 1 +
 tools/libs/light/libxl_domain.c  | 1 +
 tools/libs/light/libxl_types.idl | 1 +
 xen/arch/arm/domctl.c            | 2 ++
 xen/arch/x86/domctl.c            | 1 +
 xen/common/domctl.c              | 4 ++--
 xen/common/sysctl.c              | 2 +-
 xen/include/public/domctl.h      | 3 +++
 xen/include/public/sysctl.h      | 2 +-
 11 files changed, 22 insertions(+), 4 deletions(-)

diff --git a/tools/include/libxl.h b/tools/include/libxl.h
index ee73eb0..2e8679d 100644
--- a/tools/include/libxl.h
+++ b/tools/include/libxl.h
@@ -886,6 +886,14 @@ typedef struct libxl__ctx libxl_ctx;
 #define LIBXL_HAVE_DOMINFO_NEVER_STOP 1
 
 /*
+ * LIBXL_HAVE_DOMINFO_GPADDR_BITS
+ *
+ * If this is defined, libxl_dominfo will contain an uint8 field called
+ * gpaddr_bits, containing the guest physical address space size.
+ */
+#define LIBXL_HAVE_DOMINFO_GPADDR_BITS 1
+
+/*
  * LIBXL_HAVE_QXL
  *
  * If defined, then the libxl_vga_interface_type will contain another value:
diff --git a/tools/include/xenctrl.h b/tools/include/xenctrl.h
index a306399..07b96e6 100644
--- a/tools/include/xenctrl.h
+++ b/tools/include/xenctrl.h
@@ -462,6 +462,7 @@ typedef struct xc_dominfo {
     unsigned int  max_vcpu_id;
     xen_domain_handle_t handle;
     unsigned int  cpupool;
+    uint8_t       gpaddr_bits;
     struct xen_arch_domainconfig arch_config;
 } xc_dominfo_t;
 
diff --git a/tools/libs/ctrl/xc_domain.c b/tools/libs/ctrl/xc_domain.c
index 23322b7..b155d6a 100644
--- a/tools/libs/ctrl/xc_domain.c
+++ b/tools/libs/ctrl/xc_domain.c
@@ -396,6 +396,7 @@ int xc_domain_getinfo(xc_interface *xch,
         info->nr_online_vcpus = domctl.u.getdomaininfo.nr_online_vcpus;
         info->max_vcpu_id = domctl.u.getdomaininfo.max_vcpu_id;
         info->cpupool = domctl.u.getdomaininfo.cpupool;
+        info->gpaddr_bits = domctl.u.getdomaininfo.gpaddr_bits;
         info->arch_config = domctl.u.getdomaininfo.arch_config;
 
         memcpy(info->handle, domctl.u.getdomaininfo.handle,
diff --git a/tools/libs/light/libxl_domain.c b/tools/libs/light/libxl_domain.c
index 51a6127..544a9bf 100644
--- a/tools/libs/light/libxl_domain.c
+++ b/tools/libs/light/libxl_domain.c
@@ -306,6 +306,7 @@ void libxl__xcinfo2xlinfo(libxl_ctx *ctx,
     xlinfo->vcpu_max_id = xcinfo->max_vcpu_id;
     xlinfo->vcpu_online = xcinfo->nr_online_vcpus;
     xlinfo->cpupool = xcinfo->cpupool;
+    xlinfo->gpaddr_bits = xcinfo->gpaddr_bits;
     xlinfo->domain_type = (xcinfo->flags & XEN_DOMINF_hvm_guest) ?
         LIBXL_DOMAIN_TYPE_HVM : LIBXL_DOMAIN_TYPE_PV;
 }
diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_types.idl
index b96fb5c..608d55a 100644
--- a/tools/libs/light/libxl_types.idl
+++ b/tools/libs/light/libxl_types.idl
@@ -357,6 +357,7 @@ libxl_dominfo = Struct("dominfo",[
     ("vcpu_max_id", uint32),
     ("vcpu_online", uint32),
     ("cpupool",     uint32),
+    ("gpaddr_bits", uint8),
     ("domain_type", libxl_domain_type),
     ], dir=DIR_OUT)
 
diff --git a/xen/arch/arm/domctl.c b/xen/arch/arm/domctl.c
index b7d27f3..6245af6 100644
--- a/xen/arch/arm/domctl.c
+++ b/xen/arch/arm/domctl.c
@@ -20,6 +20,8 @@ void arch_get_domain_info(const struct domain *d,
 {
     /* All ARM domains use hardware assisted paging. */
     info->flags |= XEN_DOMINF_hap;
+
+    info->gpaddr_bits = p2m_ipa_bits;
 }
 
 static int handle_vuart_init(struct domain *d, 
diff --git a/xen/arch/x86/domctl.c b/xen/arch/x86/domctl.c
index 26a76d2..7d102e0 100644
--- a/xen/arch/x86/domctl.c
+++ b/xen/arch/x86/domctl.c
@@ -151,6 +151,7 @@ void arch_get_domain_info(const struct domain *d,
         info->flags |= XEN_DOMINF_hap;
 
     info->arch_config.emulation_flags = d->arch.emulation_flags;
+    info->gpaddr_bits = hap_paddr_bits;
 }
 
 static int do_vmtrace_op(struct domain *d, struct xen_domctl_vmtrace_op *op,
diff --git a/xen/common/domctl.c b/xen/common/domctl.c
index 12d6144..271862a 100644
--- a/xen/common/domctl.c
+++ b/xen/common/domctl.c
@@ -69,10 +69,10 @@ void getdomaininfo(struct domain *d, struct xen_domctl_getdomaininfo *info)
     int flags = XEN_DOMINF_blocked;
     struct vcpu_runstate_info runstate;
 
+    memset(info, 0, sizeof(*info));
+
     info->domain = d->domain_id;
     info->max_vcpu_id = XEN_INVALID_MAX_VCPU_ID;
-    info->nr_online_vcpus = 0;
-    info->ssidref = 0;
 
     /*
      * - domain is marked as blocked only if all its vcpus are blocked
diff --git a/xen/common/sysctl.c b/xen/common/sysctl.c
index 6e7189b..f2dab72 100644
--- a/xen/common/sysctl.c
+++ b/xen/common/sysctl.c
@@ -76,7 +76,7 @@ long do_sysctl(XEN_GUEST_HANDLE_PARAM(xen_sysctl_t) u_sysctl)
     case XEN_SYSCTL_getdomaininfolist:
     { 
         struct domain *d;
-        struct xen_domctl_getdomaininfo info = { 0 };
+        struct xen_domctl_getdomaininfo info;
         u32 num_domains = 0;
 
         rcu_read_lock(&domlist_read_lock);
diff --git a/xen/include/public/domctl.h b/xen/include/public/domctl.h
index a53cbd1..9099dc1 100644
--- a/xen/include/public/domctl.h
+++ b/xen/include/public/domctl.h
@@ -108,6 +108,7 @@ struct xen_domctl_createdomain {
 struct xen_domctl_getdomaininfo {
     /* OUT variables. */
     domid_t  domain;              /* Also echoed in domctl.domain */
+    uint16_t pad1;
  /* Domain is scheduled to die. */
 #define _XEN_DOMINF_dying     0
 #define XEN_DOMINF_dying      (1U<<_XEN_DOMINF_dying)
@@ -152,6 +153,8 @@ struct xen_domctl_getdomaininfo {
     uint32_t ssidref;
     xen_domain_handle_t handle;
     uint32_t cpupool;
+    uint8_t gpaddr_bits; /* Guest physical address space size. */
+    uint8_t pad2[7];
     struct xen_arch_domainconfig arch_config;
 };
 typedef struct xen_domctl_getdomaininfo xen_domctl_getdomaininfo_t;
diff --git a/xen/include/public/sysctl.h b/xen/include/public/sysctl.h
index fead0e5..3e53681 100644
--- a/xen/include/public/sysctl.h
+++ b/xen/include/public/sysctl.h
@@ -35,7 +35,7 @@
 #include "domctl.h"
 #include "physdev.h"
 
-#define XEN_SYSCTL_INTERFACE_VERSION 0x00000013
+#define XEN_SYSCTL_INTERFACE_VERSION 0x00000014
 
 /*
  * Read console content from Xen buffer ring.
-- 
2.7.4



From xen-devel-bounces@lists.xenproject.org Thu Oct 14 11:41:06 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Oct 2021 11:41:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.209272.365694 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maz6g-0004US-5X; Thu, 14 Oct 2021 11:41:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 209272.365694; Thu, 14 Oct 2021 11:41:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1maz6g-0004UI-1P; Thu, 14 Oct 2021 11:41:06 +0000
Received: by outflank-mailman (input) for mailman id 209272;
 Thu, 14 Oct 2021 11:41:05 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+gDO=PC=gmail.com=olekstysh@srs-us1.protection.inumbo.net>)
 id 1maz6f-0003sA-DJ
 for xen-devel@lists.xenproject.org; Thu, 14 Oct 2021 11:41:05 +0000
Received: from mail-wr1-x435.google.com (unknown [2a00:1450:4864:20::435])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id f9551d57-bc7a-46de-8928-39baa3a9b465;
 Thu, 14 Oct 2021 11:40:56 +0000 (UTC)
Received: by mail-wr1-x435.google.com with SMTP id v17so18451044wrv.9
 for <xen-devel@lists.xenproject.org>; Thu, 14 Oct 2021 04:40:56 -0700 (PDT)
Received: from otyshchenko.router ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id g16sm2151359wrs.90.2021.10.14.04.40.54
 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
 Thu, 14 Oct 2021 04:40:54 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f9551d57-bc7a-46de-8928-39baa3a9b465
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references;
        bh=Yln6hFneHIgQFQr2b5P60hP5dg/JMVV2z46PXzpOS0o=;
        b=pUkBeqkbJ+eMhj8JY/S1b8V+nnJBQ+6i+EDDceXOeM2MAcoXNmU9A6+1dHo3KJDCIh
         s6zUNDoE3LXMcZ/alCtY2UT0vPeCL0TUNMfKvrXeje3QLuKsBh/PCnZAzuohwMKcxU5Q
         QaFFCE7Hlo9gJLSSWMwW5C+WiXBCi7qSIgnCIJLNwXkY6qBFkH2a0FJza1LrPZbcjAUv
         2oMFSnbd0nYBP5A1x8sPAYOoy9uTo/m2yMwcW3yCvZkCBZDXxVGWhI0USbVxxV5r3Lbz
         NMVCmVv5Xut/fn3CsSr0d6ZKubw+VBeu49Vs4gi8mUCrNPFX8JLmoo4d8F5fFnTNqBGO
         ZN+g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references;
        bh=Yln6hFneHIgQFQr2b5P60hP5dg/JMVV2z46PXzpOS0o=;
        b=vJhk1+nMM4Qyqsdekzl8lGZQzxXsZRNhkIrf3CdCFvQygsFCFRmwfxEt7J1gONa29c
         M5votEOOKFLheTtMnzC2qTVOZEwXl5eHuhCKJJ+AReJEAHVrk8eMgpsB83fQMU7FkX/C
         i9H3pvsDPiWhcdp/PsMRo0ssC5PEJTVoXgYAIZ8b1CnTwBJH6RQ2cT+MGybha85SCiNz
         gvd7CV9qpxII0OVK3xZxD2s0Di2VaDjMgos0pi1voUVQaaeK29JQlDvFsvCXs23NjoLJ
         mVJ0LG8JvUr8NQsKKA9nJEIK38P6qeqoz9zWDeYYb13kT7czrEGyi3tc0WWlNqmOTy6w
         w53w==
X-Gm-Message-State: AOAM531JH7x0LFt2CeNhJ5B5cBqGoQR1dj9SAab8D+A/QFjWJ+prupuX
	lPYj+NlQ9sYVZOv5c7eMSBZzXXRHSio=
X-Google-Smtp-Source: ABdhPJwY0ei55WTSDmfM4KYpGUJU3eL2E3JZen741BVb8G77S6AhSAxyDcMpOH29/YHetO5xLb04vw==
X-Received: by 2002:a5d:64c9:: with SMTP id f9mr6006399wri.284.1634211655280;
        Thu, 14 Oct 2021 04:40:55 -0700 (PDT)
From: Oleksandr Tyshchenko <olekstysh@gmail.com>
To: xen-devel@lists.xenproject.org
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Ian Jackson <iwj@xenproject.org>,
	Wei Liu <wl@xen.org>,
	Anthony PERARD <anthony.perard@citrix.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: [PATCH V7 2/2] libxl/arm: Add handling of extended regions for DomU
Date: Thu, 14 Oct 2021 14:40:45 +0300
Message-Id: <1634211645-26912-3-git-send-email-olekstysh@gmail.com>
X-Mailer: git-send-email 2.7.4
In-Reply-To: <1634211645-26912-1-git-send-email-olekstysh@gmail.com>
References: <1634211645-26912-1-git-send-email-olekstysh@gmail.com>

From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>

The extended region (safe range) is a region of guest physical
address space which is unused and could be safely used to create
grant/foreign mappings instead of wasting real RAM pages from
the domain memory for establishing these mappings.

The extended regions are chosen at the domain creation time and
advertised to it via "reg" property under hypervisor node in
the guest device-tree. As region 0 is reserved for grant table
space (always present), the indexes for extended regions are 1...N.
If extended regions could not be allocated for some reason,
Xen doesn't fail and behaves as usual, so only inserts region 0.

Please note the following limitations:
- The extended region feature is only supported for 64-bit domain
  currently.
- The ACPI case is not covered.

***

The algorithm to choose extended regions for non-direct mapped
DomU is simpler in comparison with the algorithm for direct mapped
Dom0. We usually have a lot of unused space above 4GB, and might
have some unused space below 4GB (depends on guest memory size).
Try to allocate separate 2MB-aligned extended regions from the first
(below 4GB) and second (above 4GB) RAM banks taking into the account
the maximum supported guest physical address space size and the amount
of memory assigned to the guest. The minimum size of extended region
the same as for Dom0 (64MB).

Please note, we introduce fdt_property_reg_placeholder helper which
purpose is to create N ranges that are zeroed. The interesting fact
is that libfdt already has fdt_property_placeholder(). But this was
introduced only in 2017, so there is a risk that some distros may not
ship the last libfdt version. This is why we implement our own light
variant for now.

Suggested-by: Julien Grall <jgrall@amazon.com>
Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
---
! Stefano, Ian I dropped your A-b/R-b again as the patch has changed
significantly !

Changes RFC -> V2:
   - update patch description
   - drop uneeded "extended-region" DT property
   - clear reg array in finalise_ext_region() and add a TODO

Changes V2 -> V3:
   - update patch description, comments in code
   - only pick up regions with size >= 64MB
   - move the region calculation to make_hypervisor_node() and drop
     finalise_ext_region()
   - extend the list of arguments for make_hypervisor_node()
   - do not show warning for 32-bit domain
   - change the region alignment from 1GB to 2MB
   - move EXT_REGION_SIZE to public/arch-arm.h

Changes V3 -> V4:
   - add R-b, A-b and T-b

Changes V4 -> V5:
   - update patch description and comments in code
   - reflect changes done in previous patch to pass gpaddr_bits
     via createdomain domctl (struct xen_arch_domainconfig)
   - drop R-b, A-b and T-b
   - drop limit for maximum extended region size (128GB)
   - try to also allocate region below 4GB, optimize code
     for calculating extended regions

Change V5 -> V6:
   - reflect changes done in previous patch to pass gpaddr_bits
     via getdomaininfo domctl (struct xen_domctl_getdomaininfo)
   - reduce the number of local variables, rework calculations

Change V6 -> V7:
   - return finalize_*() back and put all logic there with re-using
     fdt_setprop() to update placeholders
   - introduce fdt_property_reg_placeholder() helper
   - rework regions calculation to not rely on the fact that Bank 0
     is always below 4GB
   - drop check for 32-bit domain and assert for invalid gpaddr_bits
   - change a formula to calculate bankend value
   - move EXT_REGION_MIN_SIZE definition from the public header to
     libxl_arm.c
   - do not use asserts for the return values, propagate errors to
     the callers
   - add a comment in public header
---
 tools/libs/light/libxl_arm.c  | 106 ++++++++++++++++++++++++++++++++++++++++--
 xen/include/public/arch-arm.h |   5 ++
 2 files changed, 106 insertions(+), 5 deletions(-)

diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c
index e3140a6..a780155 100644
--- a/tools/libs/light/libxl_arm.c
+++ b/tools/libs/light/libxl_arm.c
@@ -269,6 +269,21 @@ static int fdt_property_regs(libxl__gc *gc, void *fdt,
     return fdt_property(fdt, "reg", regs, sizeof(regs));
 }
 
+static int fdt_property_reg_placeholder(libxl__gc *gc, void *fdt,
+                                        unsigned int addr_cells,
+                                        unsigned int size_cells,
+                                        unsigned int num_regs)
+{
+    uint32_t regs[num_regs * (addr_cells + size_cells)];
+    be32 *cells = &regs[0];
+    unsigned int i;
+
+    for (i = 0; i < num_regs; i++)
+        set_range(&cells, addr_cells, size_cells, 0, 0);
+
+    return fdt_property(fdt, "reg", regs, sizeof(regs));
+}
+
 static int make_root_properties(libxl__gc *gc,
                                 const libxl_version_info *vers,
                                 void *fdt)
@@ -615,9 +630,13 @@ static int make_hypervisor_node(libxl__gc *gc, void *fdt,
                               "xen,xen");
     if (res) return res;
 
-    /* reg 0 is grant table space */
-    res = fdt_property_regs(gc, fdt, GUEST_ROOT_ADDRESS_CELLS, GUEST_ROOT_SIZE_CELLS,
-                            1,GUEST_GNTTAB_BASE, GUEST_GNTTAB_SIZE);
+    /*
+     * reg 0 is a placeholder for grant table space, reg 1...N are
+     * the placeholders for extended regions.
+     */
+    res = fdt_property_reg_placeholder(gc, fdt, GUEST_ROOT_ADDRESS_CELLS,
+                                       GUEST_ROOT_SIZE_CELLS,
+                                       GUEST_RAM_BANKS + 1);
     if (res) return res;
 
     /*
@@ -1069,20 +1088,93 @@ static void finalise_one_node(libxl__gc *gc, void *fdt, const char *uname,
     }
 }
 
+#define ALIGN_UP_TO_2MB(x)   (((x) + MB(2) - 1) & (~(MB(2) - 1)))
+
+#define EXT_REGION_MIN_SIZE   xen_mk_ullong(0x0004000000) /* 64MB */
+
+static int finalize_hypervisor_node(libxl__gc *gc, struct xc_dom_image *dom)
+{
+    void *fdt = dom->devicetree_blob;
+    uint64_t region_size[GUEST_RAM_BANKS] = {0}, region_base[GUEST_RAM_BANKS],
+        bankend[GUEST_RAM_BANKS];
+    uint32_t regs[(GUEST_ROOT_ADDRESS_CELLS + GUEST_ROOT_SIZE_CELLS) *
+                  (GUEST_RAM_BANKS + 1)];
+    be32 *cells = &regs[0];
+    const uint64_t bankbase[] = GUEST_RAM_BANK_BASES;
+    const uint64_t banksize[] = GUEST_RAM_BANK_SIZES;
+    unsigned int i, len, nr_regions = 0;
+    libxl_dominfo info;
+    int offset, rc;
+
+    offset = fdt_path_offset(fdt, "/hypervisor");
+    if (offset < 0)
+        return offset;
+
+    rc = libxl_domain_info(CTX, &info, dom->guest_domid);
+    if (rc)
+        return rc;
+
+    if (info.gpaddr_bits > 64)
+        return ERROR_INVAL;
+
+    /*
+     * Try to allocate separate 2MB-aligned extended regions from the first
+     * and second RAM banks taking into the account the maximum supported
+     * guest physical address space size and the amount of memory assigned
+     * to the guest.
+     */
+    for (i = 0; i < GUEST_RAM_BANKS; i++) {
+        region_base[i] = bankbase[i] +
+            ALIGN_UP_TO_2MB((uint64_t)dom->rambank_size[i] << XC_PAGE_SHIFT);
+
+        bankend[i] = ~0ULL >> (64 - info.gpaddr_bits);
+        bankend[i] = min(bankend[i], bankbase[i] + banksize[i] - 1);
+        if (bankend[i] > region_base[i])
+            region_size[i] = bankend[i] - region_base[i] + 1;
+    }
+
+    /*
+     * The region 0 for grant table space must be always present. If we managed
+     * to allocate the extended regions then insert them as regions 1...N.
+     */
+    set_range(&cells, GUEST_ROOT_ADDRESS_CELLS, GUEST_ROOT_SIZE_CELLS,
+              GUEST_GNTTAB_BASE, GUEST_GNTTAB_SIZE);
+
+    for (i = 0; i < GUEST_RAM_BANKS; i++) {
+        if (region_size[i] < EXT_REGION_MIN_SIZE)
+            continue;
+
+        LOG(DEBUG, "Extended region %u: %#"PRIx64"->%#"PRIx64"",
+            nr_regions, region_base[i], region_base[i] + region_size[i]);
+
+        set_range(&cells, GUEST_ROOT_ADDRESS_CELLS, GUEST_ROOT_SIZE_CELLS,
+                  region_base[i], region_size[i]);
+        nr_regions++;
+    }
+
+    if (!nr_regions)
+        LOG(WARN, "The extended regions cannot be allocated, not enough space");
+
+    len = sizeof(regs[0]) * (GUEST_ROOT_ADDRESS_CELLS + GUEST_ROOT_SIZE_CELLS) *
+        (nr_regions + 1);
+
+    return fdt_setprop(fdt, offset, "reg", regs, len);
+}
+
 int libxl__arch_domain_finalise_hw_description(libxl__gc *gc,
                                                uint32_t domid,
                                                libxl_domain_config *d_config,
                                                struct xc_dom_image *dom)
 {
     void *fdt = dom->devicetree_blob;
-    int i;
+    int i, res;
     const uint64_t bankbase[] = GUEST_RAM_BANK_BASES;
 
     const struct xc_dom_seg *ramdisk = dom->modules[0].blob ?
         &dom->modules[0].seg : NULL;
 
     if (ramdisk) {
-        int chosen, res;
+        int chosen;
         uint64_t val;
 
         /* Neither the fdt_path_offset() nor either of the
@@ -1109,6 +1201,10 @@ int libxl__arch_domain_finalise_hw_description(libxl__gc *gc,
 
     }
 
+    res = finalize_hypervisor_node(gc, dom);
+    if (res)
+        return res;
+
     for (i = 0; i < GUEST_RAM_BANKS; i++) {
         const uint64_t size = (uint64_t)dom->rambank_size[i] << XC_PAGE_SHIFT;
 
diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h
index d46c61f..96ead3d 100644
--- a/xen/include/public/arch-arm.h
+++ b/xen/include/public/arch-arm.h
@@ -438,6 +438,11 @@ typedef uint64_t xen_callback_t;
 
 #define GUEST_RAM_BANKS   2
 
+/*
+ * The way to find the extended regions (to be exposed to the guest as unused
+ * address space) relies on the fact that the regions reserved for the RAM
+ * below are big enough to also accommodate such regions.
+ */
 #define GUEST_RAM0_BASE   xen_mk_ullong(0x40000000) /* 3GB of low RAM @ 1GB */
 #define GUEST_RAM0_SIZE   xen_mk_ullong(0xc0000000)
 
-- 
2.7.4



From xen-devel-bounces@lists.xenproject.org Thu Oct 14 11:44:59 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Oct 2021 11:44:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.209293.365705 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mazAO-0005ka-Oi; Thu, 14 Oct 2021 11:44:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 209293.365705; Thu, 14 Oct 2021 11:44:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mazAO-0005kT-L7; Thu, 14 Oct 2021 11:44:56 +0000
Received: by outflank-mailman (input) for mailman id 209293;
 Thu, 14 Oct 2021 11:44:55 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+gDO=PC=gmail.com=olekstysh@srs-us1.protection.inumbo.net>)
 id 1mazAN-0005kJ-Cx
 for xen-devel@lists.xenproject.org; Thu, 14 Oct 2021 11:44:55 +0000
Received: from mail-wr1-x432.google.com (unknown [2a00:1450:4864:20::432])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id c8345b63-ce03-4c98-a77f-5357605fa593;
 Thu, 14 Oct 2021 11:44:53 +0000 (UTC)
Received: by mail-wr1-x432.google.com with SMTP id m22so18706764wrb.0
 for <xen-devel@lists.xenproject.org>; Thu, 14 Oct 2021 04:44:53 -0700 (PDT)
Received: from [192.168.1.7] ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id f3sm7691917wmb.12.2021.10.14.04.44.52
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Thu, 14 Oct 2021 04:44:52 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c8345b63-ce03-4c98-a77f-5357605fa593
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-transfer-encoding:content-language;
        bh=lDe74hVzo/wHydJM285y6hCakhd1zCbzNEpL7gTsAyk=;
        b=BKP9fpBM8WiN7oEUqIxR/tafK4zi7AhGFQj1soMP8PwUfHARjx6IjqGdBGM3RSh3q8
         4JQL2PE1KHG2XLDZNogu1jvXLLdylth029r/7pF7ZtY4vz4r4rpujtgXqnDw/+1PeRnq
         yCIEbr/Hy3UIiW2ExW3F3iIs3tAYV1mWkiqqdlYWJHqzkcmlbZZz6CbqGYLvgxH3gk0V
         m4yCBM/MQ7wFDQJDlCU7TFVKxqYsu4GQoRUCu3etb7u7+gUwu3eTHV8I7HXTAnXe0cjV
         8Yz3Skfeiqbjzdvk/XQDJrxHKiUHNccs7ZPoLqPCsFq9WpA/1kaUNm1MnPZeYAXvfU6I
         xpmQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding
         :content-language;
        bh=lDe74hVzo/wHydJM285y6hCakhd1zCbzNEpL7gTsAyk=;
        b=TRkLLQpm9xlYCXEvXYJ39SY1lwAuk61lv2uMyoUPBS3hu7nBLPQ6pJnNkNHy8ilpvb
         f/of5v5T5vA4SFcOm799aIK9C9SRXHh+OpvXwhEsijGSdQnNGGFnkG6LZS9bWwvDBJz7
         LqvWTyntXZb7GqBACVMCCZ0xtxOc9lQ8VQu2Rtgf0mDBnCPpkNl0hFzfO9Jggcu51tHd
         Ufkr+VkDpVHnJU+hDJJGcX6lwlKunPf4xYBhhKUz+682bTdDZP0S18aUFftALTTdL/AE
         MQTkoR9SHqLtqdQ7dFdLJ1HTMda15i+xxmWhJ6zVarBaDw7DsB2tYAqv7OksVTYz7z3j
         LSkg==
X-Gm-Message-State: AOAM530H/DAfIPfXp7m7Qj3mBymDmsTKOMpeSFUer8cqJdvoHe4wsnv2
	3A6pD2qYgnRpwsZL4884yCM=
X-Google-Smtp-Source: ABdhPJyqIm+t2sjUspgwO/+eBM9eaqI6mQgNuBy65UwBGQot35kEQMmAfRyAWNeN6EWCdDPIp2GxWg==
X-Received: by 2002:a7b:c0d5:: with SMTP id s21mr18936535wmh.57.1634211892891;
        Thu, 14 Oct 2021 04:44:52 -0700 (PDT)
Subject: Re: [PATCH V6 2/2] libxl/arm: Add handling of extended regions for
 DomU
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: Julien Grall <julien@xen.org>, Ian Jackson <iwj@xenproject.org>,
 xen-devel@lists.xenproject.org,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, Wei Liu <wl@xen.org>,
 Anthony PERARD <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <1633974539-7380-1-git-send-email-olekstysh@gmail.com>
 <1633974539-7380-3-git-send-email-olekstysh@gmail.com>
 <c98c1acd-86c0-f556-643e-e472b696644f@xen.org>
 <51f9154f-3b65-c7c0-cd93-cecdc2a0975e@gmail.com>
 <641173d4-2629-e4b6-d4ec-06bd629141cc@xen.org>
 <acc06366-b381-daa0-8e2a-54c2761019af@gmail.com>
 <dea074a1-fad2-9b25-5b44-8de23eee83d7@gmail.com>
 <d076afcc-5fde-e83e-1632-371406bdd387@xen.org>
 <1fc5d4ae-1426-0061-a1e8-dd939de30cc3@gmail.com>
 <2faf58fa-2e06-635f-27fe-9ba642db27b0@xen.org>
 <0125116e-1e8a-8e68-62fb-dfc868ea76d4@gmail.com>
 <a9b9b16d-daf0-0bd3-cc1b-f3812f670e69@xen.org>
 <b2285058-360d-ebef-836e-5b87658e8847@gmail.com>
 <510cdb07-3702-4c96-d0be-d1916e36c697@gmail.com>
 <alpine.DEB.2.21.2110131324180.9408@sstabellini-ThinkPad-T480s>
From: Oleksandr <olekstysh@gmail.com>
Message-ID: <595d72b2-b3bd-8aa0-9f3d-e3341a3afe4d@gmail.com>
Date: Thu, 14 Oct 2021 14:44:51 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.21.2110131324180.9408@sstabellini-ThinkPad-T480s>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US


Hi Stefano


On 13.10.21 23:24, Stefano Stabellini wrote:
> On Wed, 13 Oct 2021, Oleksandr wrote:
>> On 13.10.21 21:26, Oleksandr wrote:
>>> On 13.10.21 20:07, Julien Grall wrote:
>>>
>>> Hi Julien
>>>
>>>> Hi,
>>>>
>>>> On 13/10/2021 17:44, Oleksandr wrote:
>>>>> On 13.10.21 19:24, Julien Grall wrote:
>>>>>> On 13/10/2021 16:49, Oleksandr wrote:
>>>>>>> On 13.10.21 18:15, Julien Grall wrote:
>>>>>>>> On 13/10/2021 14:46, Oleksandr wrote:
>>>>>>>>> Hi Julien
>>>>>>>> Hi Oleksandr,
>>>>>>> Hi Julien
>>>>>>>
>>>>>>>
>>>>>>> Thank you for the prompt response.
>>>>>>>
>>>>>>>
>>>>>>>>> On 13.10.21 00:43, Oleksandr wrote:
>>>>>>>>> diff --git a/tools/libs/light/libxl_arm.c
>>>>>>>>> b/tools/libs/light/libxl_arm.c
>>>>>>>>> index e3140a6..53ae0f3 100644
>>>>>>>>> --- a/tools/libs/light/libxl_arm.c
>>>>>>>>> +++ b/tools/libs/light/libxl_arm.c
>>>>>>>>> @@ -615,9 +615,12 @@ static int make_hypervisor_node(libxl__gc
>>>>>>>>> *gc, void *fdt,
>>>>>>>>>                                  "xen,xen");
>>>>>>>>>        if (res) return res;
>>>>>>>>>
>>>>>>>>> -    /* reg 0 is grant table space */
>>>>>>>>> +    /*
>>>>>>>>> +     * reg 0 is a placeholder for grant table space, reg 1...N
>>>>>>>>> are
>>>>>>>>> +     * the placeholders for extended regions.
>>>>>>>>> +     */
>>>>>>>>>        res = fdt_property_regs(gc, fdt, GUEST_ROOT_ADDRESS_CELLS,
>>>>>>>>> GUEST_ROOT_SIZE_CELLS,
>>>>>>>>> -                            1,GUEST_GNTTAB_BASE,
>>>>>>>>> GUEST_GNTTAB_SIZE);
>>>>>>>>> +                            GUEST_RAM_BANKS + 1, 0, 0, 0, 0, 0,
>>>>>>>>> 0);
>>>>>>>> Here you are relying on GUEST_RAM_BANKS == 2. I think this is
>>>>>>>> pretty fragile as this may change in the future.
>>>>>>>>
>>>>>>>> fdt_property_regs() is not really suitable for here. I would
>>>>>>>> suggest to create a new helper fdt_property_placeholder() which
>>>>>>>> takes the address cells, size cells and the number of ranges. The
>>>>>>>> function will then create N range that are zeroed.
>>>>>>> You are right. Probably, we could add an assert here for now to be
>>>>>>> triggered if "GUEST_RAM_BANKS != 2"?
>>>>>>> But, if you still think we need to make it with the helper right
>>>>>>> now, I will. However, I don't know how long this will take.
>>>>>> I would prefer if we introduce the helper now. Below a potential
>>>>>> version (not compiled):
>>>>>
>>>>> You wouldn't believe)))
>>>>> I decided to not wait for the answer and re-check. So, I ended up with
>>>>> the similar to what you suggested below. Thank you.
>>>>> Yes, it will work if add missing locals. However, I initially named it
>>>>> exactly as was suggested (fdt_property_placeholder) and got a
>>>>> compilation error, since fdt_property_placeholder is already present.
>>>>> So, I was thinking to choose another name or to even open-code it, but I
>>>>> see you already proposed new name fdt_property_reg_placeholder.
>>>> Ah I didn't realize that libfdt already implemented
>>>> fdt_property_placeholder(). The function sounds perfect for us (and the
>>>> code is nicer :)), but unfortunately this was introdcued only in 2017. So
>>>> it is possible that some distros may not ship the last libfdt.
>>>>
>>>> So for now, I think we need to implement our own. In a follow-up we could
>>>> try to provide a compat layer as we did for other missing fdt_* helpers.
>>>>
>>>> Cheers,
>>>
>>> Well, I hope that I addressed all your comments. If so, I will prepare V7.
>>
>> May I please ask, are you *preliminary* OK with new changes requested by
>> Julien? The main changes are to bring finalize_*() back (hopefully there is a
>> way how to downsize a placeholder), avoid relying on the fact that Bank 0 is
>> always below 4GB, adding a convenient helper to create a placeholder for N
>> ranges plus some code hardening, etc.
> Yes, I am OK with it

Thank you for confirming. I have just pushed V7:

https://lore.kernel.org/xen-devel/1634211645-26912-1-git-send-email-olekstysh@gmail.com/


>
>
>>> diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c
>>> index e3140a6..a780155 100644
>>> --- a/tools/libs/light/libxl_arm.c
>>> +++ b/tools/libs/light/libxl_arm.c
>>> @@ -269,6 +269,21 @@ static int fdt_property_regs(libxl__gc *gc, void *fdt,
>>>       return fdt_property(fdt, "reg", regs, sizeof(regs));
>>>   }
>>>
>>> +static int fdt_property_reg_placeholder(libxl__gc *gc, void *fdt,
>>> +                                        unsigned int addr_cells,
>>> +                                        unsigned int size_cells,
>>> +                                        unsigned int num_regs)
>>> +{
>>> +    uint32_t regs[num_regs * (addr_cells + size_cells)];
>>> +    be32 *cells = &regs[0];
>>> +    unsigned int i;
>>> +
>>> +    for (i = 0; i < num_regs; i++)
>>> +        set_range(&cells, addr_cells, size_cells, 0, 0);
>>> +
>>> +    return fdt_property(fdt, "reg", regs, sizeof(regs));
>>> +}
>>> +
>>>   static int make_root_properties(libxl__gc *gc,
>>>                                   const libxl_version_info *vers,
>>>                                   void *fdt)
>>> @@ -615,9 +630,13 @@ static int make_hypervisor_node(libxl__gc *gc, void
>>> *fdt,
>>>                                 "xen,xen");
>>>       if (res) return res;
>>>
>>> -    /* reg 0 is grant table space */
>>> -    res = fdt_property_regs(gc, fdt, GUEST_ROOT_ADDRESS_CELLS,
>>> GUEST_ROOT_SIZE_CELLS,
>>> -                            1,GUEST_GNTTAB_BASE, GUEST_GNTTAB_SIZE);
>>> +    /*
>>> +     * reg 0 is a placeholder for grant table space, reg 1...N are
>>> +     * the placeholders for extended regions.
>>> +     */
>>> +    res = fdt_property_reg_placeholder(gc, fdt, GUEST_ROOT_ADDRESS_CELLS,
>>> +                                       GUEST_ROOT_SIZE_CELLS,
>>> +                                       GUEST_RAM_BANKS + 1);
>>>       if (res) return res;
>>>
>>>       /*
>>> @@ -1069,20 +1088,93 @@ static void finalise_one_node(libxl__gc *gc, void
>>> *fdt, const char *uname,
>>>       }
>>>   }
>>>
>>> +#define ALIGN_UP_TO_2MB(x)   (((x) + MB(2) - 1) & (~(MB(2) - 1)))
>>> +
>>> +#define EXT_REGION_MIN_SIZE   xen_mk_ullong(0x0004000000) /* 64MB */
>>> +
>>> +static int finalize_hypervisor_node(libxl__gc *gc, struct xc_dom_image
>>> *dom)
>>> +{
>>> +    void *fdt = dom->devicetree_blob;
>>> +    uint64_t region_size[GUEST_RAM_BANKS] = {0},
>>> region_base[GUEST_RAM_BANKS],
>>> +        bankend[GUEST_RAM_BANKS];
>>> +    uint32_t regs[(GUEST_ROOT_ADDRESS_CELLS + GUEST_ROOT_SIZE_CELLS) *
>>> +                  (GUEST_RAM_BANKS + 1)];
>>> +    be32 *cells = &regs[0];
>>> +    const uint64_t bankbase[] = GUEST_RAM_BANK_BASES;
>>> +    const uint64_t banksize[] = GUEST_RAM_BANK_SIZES;
>>> +    unsigned int i, len, nr_regions = 0;
>>> +    libxl_dominfo info;
>>> +    int offset, rc;
>>> +
>>> +    offset = fdt_path_offset(fdt, "/hypervisor");
>>> +    if (offset < 0)
>>> +        return offset;
>>> +
>>> +    rc = libxl_domain_info(CTX, &info, dom->guest_domid);
>>> +    if (rc)
>>> +        return rc;
>>> +
>>> +    if (info.gpaddr_bits > 64)
>>> +        return ERROR_INVAL;
>>> +
>>> +    /*
>>> +     * Try to allocate separate 2MB-aligned extended regions from the first
>>> +     * and second RAM banks taking into the account the maximum supported
>>> +     * guest physical address space size and the amount of memory assigned
>>> +     * to the guest.
>>> +     */
>>> +    for (i = 0; i < GUEST_RAM_BANKS; i++) {
>>> +        region_base[i] = bankbase[i] +
>>> +            ALIGN_UP_TO_2MB((uint64_t)dom->rambank_size[i] <<
>>> XC_PAGE_SHIFT);
>>> +
>>> +        bankend[i] = ~0ULL >> (64 - info.gpaddr_bits);
>>> +        bankend[i] = min(bankend[i], bankbase[i] + banksize[i] - 1);
>>> +        if (bankend[i] > region_base[i])
>>> +            region_size[i] = bankend[i] - region_base[i] + 1;
>>> +    }
>>> +
>>> +    /*
>>> +     * The region 0 for grant table space must be always present. If we
>>> managed
>>> +     * to allocate the extended regions then insert them as regions 1...N.
>>> +     */
>>> +    set_range(&cells, GUEST_ROOT_ADDRESS_CELLS, GUEST_ROOT_SIZE_CELLS,
>>> +              GUEST_GNTTAB_BASE, GUEST_GNTTAB_SIZE);
>>> +
>>> +    for (i = 0; i < GUEST_RAM_BANKS; i++) {
>>> +        if (region_size[i] < EXT_REGION_MIN_SIZE)
>>> +            continue;
>>> +
>>> +        LOG(DEBUG, "Extended region %u: %#"PRIx64"->%#"PRIx64"",
>>> +            nr_regions, region_base[i], region_base[i] + region_size[i]);
>>> +
>>> +        set_range(&cells, GUEST_ROOT_ADDRESS_CELLS, GUEST_ROOT_SIZE_CELLS,
>>> +                  region_base[i], region_size[i]);
>>> +        nr_regions++;
>>> +    }
>>> +
>>> +    if (!nr_regions)
>>> +        LOG(WARN, "The extended regions cannot be allocated, not enough
>>> space");
>>> +
>>> +    len = sizeof(regs[0]) * (GUEST_ROOT_ADDRESS_CELLS +
>>> GUEST_ROOT_SIZE_CELLS) *
>>> +        (nr_regions + 1);
>>> +
>>> +    return fdt_setprop(fdt, offset, "reg", regs, len);
>>> +}
>>> +
>>>   int libxl__arch_domain_finalise_hw_description(libxl__gc *gc,
>>>                                                  uint32_t domid,
>>> libxl_domain_config *d_config,
>>>                                                  struct xc_dom_image *dom)
>>>   {
>>>       void *fdt = dom->devicetree_blob;
>>> -    int i;
>>> +    int i, res;
>>>       const uint64_t bankbase[] = GUEST_RAM_BANK_BASES;
>>>
>>>       const struct xc_dom_seg *ramdisk = dom->modules[0].blob ?
>>>           &dom->modules[0].seg : NULL;
>>>
>>>       if (ramdisk) {
>>> -        int chosen, res;
>>> +        int chosen;
>>>           uint64_t val;
>>>
>>>           /* Neither the fdt_path_offset() nor either of the
>>> @@ -1109,6 +1201,10 @@ int
>>> libxl__arch_domain_finalise_hw_description(libxl__gc *gc,
>>>
>>>       }
>>>
>>> +    res = finalize_hypervisor_node(gc, dom);
>>> +    if (res)
>>> +        return res;
>>> +
>>>       for (i = 0; i < GUEST_RAM_BANKS; i++) {
>>>           const uint64_t size = (uint64_t)dom->rambank_size[i] <<
>>> XC_PAGE_SHIFT;
>>>
>>> diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h
>>> index d46c61f..96ead3d 100644
>>> --- a/xen/include/public/arch-arm.h
>>> +++ b/xen/include/public/arch-arm.h
>>> @@ -438,6 +438,11 @@ typedef uint64_t xen_callback_t;
>>>
>>>   #define GUEST_RAM_BANKS   2
>>>
>>> +/*
>>> + * The way to find the extended regions (to be exposed to the guest as
>>> unused
>>> + * address space) relies on the fact that the regions reserved for the RAM
>>> + * below are big enough to also accommodate such regions.
>>> + */
>>>   #define GUEST_RAM0_BASE   xen_mk_ullong(0x40000000) /* 3GB of low RAM @ 1GB
>>> */
>>>   #define GUEST_RAM0_SIZE   xen_mk_ullong(0xc0000000)
>>>
>>> (END)
>>>
>>>
>> -- 
>> Regards,
>>
>> Oleksandr Tyshchenko

-- 
Regards,

Oleksandr Tyshchenko



From xen-devel-bounces@lists.xenproject.org Thu Oct 14 12:03:06 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Oct 2021 12:03:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.209303.365716 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mazRs-00088S-FD; Thu, 14 Oct 2021 12:03:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 209303.365716; Thu, 14 Oct 2021 12:03:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mazRs-00088L-Bq; Thu, 14 Oct 2021 12:03:00 +0000
Received: by outflank-mailman (input) for mailman id 209303;
 Thu, 14 Oct 2021 12:02:58 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mazRq-00088A-NY; Thu, 14 Oct 2021 12:02:58 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mazRq-0007s6-HN; Thu, 14 Oct 2021 12:02:58 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mazRq-00055u-A9; Thu, 14 Oct 2021 12:02:58 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mazRq-0007qT-9a; Thu, 14 Oct 2021 12:02:58 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=P7eDuRZp+6RcnynDzy23ap0pfF+/+lBsK0kU9u2Iajk=; b=S1mZ0gIuHk5Q1qQmG0sTzKVy8D
	0nFcDLBoUzIWC3OOH7livjqultUOJGfmrXS+ecrXQ0f1sLNKgD5dwwUyB7IRORlZFgkH4/qCHzHov
	tna7fOCpxk1qJbBcWD8ba6MkEpTvjdoWNX3lNj49KqXhode/yiCEu+dT49//ITpHBB50=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165505-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 165505: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=e0c23cba5eaeb6c934a10ecdabcb235ef5d63799
X-Osstest-Versions-That:
    ovmf=978d428ec3ca2520c217819901c8465235c45c5e
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 14 Oct 2021 12:02:58 +0000

flight 165505 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165505/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 e0c23cba5eaeb6c934a10ecdabcb235ef5d63799
baseline version:
 ovmf                 978d428ec3ca2520c217819901c8465235c45c5e

Last test of basis   165502  2021-10-13 23:10:03 Z    0 days
Testing same since   165505  2021-10-14 07:10:13 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abner Chang <abner.chang@hpe.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Hua Ma <hua.ma@intel.com>
  Jiewen Yao <jiewen.yao@intel.com>
  Konstantin Aladyshev <aladyshev22@gmail.com>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   978d428ec3..e0c23cba5e  e0c23cba5eaeb6c934a10ecdabcb235ef5d63799 -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Thu Oct 14 12:13:16 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Oct 2021 12:13:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.209314.365729 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mazbj-0001AI-Ef; Thu, 14 Oct 2021 12:13:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 209314.365729; Thu, 14 Oct 2021 12:13:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mazbj-0001AB-Bk; Thu, 14 Oct 2021 12:13:11 +0000
Received: by outflank-mailman (input) for mailman id 209314;
 Thu, 14 Oct 2021 12:13:09 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mazbh-0001A5-5v
 for xen-devel@lists.xenproject.org; Thu, 14 Oct 2021 12:13:09 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mazbf-00083J-Bm; Thu, 14 Oct 2021 12:13:07 +0000
Received: from 54-240-197-239.amazon.com ([54.240.197.239]
 helo=[192.168.16.43]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mazbf-0003FM-4x; Thu, 14 Oct 2021 12:13:07 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=6FZd1SsUlYA1pGxoaK+DECh8ID1duzmB2zRLjp+5SBw=; b=ulbELcr3DXKdfDi5p7TgWYTbVj
	3/i8c3qVr+JYR18uvRLxDTFHalRj80DTYjVTXYWIvDamCbC4Kg4DF7qX1e3VGnDwdRRIL5ijPS5Kz
	ZpyYQRkrPmolxqQICk5BWH2iS3XJi3maT1asVgn3QWLsH4lU9KNGTGPRVPlZUwAoPme0=;
Message-ID: <321a7bc4-f39e-bead-3837-c2ec640741b6@xen.org>
Date: Thu, 14 Oct 2021 13:13:04 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.2.0
Subject: Re: [PATCH V7 2/2] libxl/arm: Add handling of extended regions for
 DomU
To: Oleksandr Tyshchenko <olekstysh@gmail.com>, xen-devel@lists.xenproject.org
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>,
 Anthony PERARD <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <1634211645-26912-1-git-send-email-olekstysh@gmail.com>
 <1634211645-26912-3-git-send-email-olekstysh@gmail.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <1634211645-26912-3-git-send-email-olekstysh@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Oleksandr,

On 14/10/2021 12:40, Oleksandr Tyshchenko wrote:
> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> 
> The extended region (safe range) is a region of guest physical
> address space which is unused and could be safely used to create
> grant/foreign mappings instead of wasting real RAM pages from
> the domain memory for establishing these mappings.
> 
> The extended regions are chosen at the domain creation time and
> advertised to it via "reg" property under hypervisor node in
> the guest device-tree. As region 0 is reserved for grant table
> space (always present), the indexes for extended regions are 1...N.
> If extended regions could not be allocated for some reason,
> Xen doesn't fail and behaves as usual, so only inserts region 0.
> 
> Please note the following limitations:
> - The extended region feature is only supported for 64-bit domain
>    currently.
> - The ACPI case is not covered.
> 
> ***
> 
> The algorithm to choose extended regions for non-direct mapped
> DomU is simpler in comparison with the algorithm for direct mapped
> Dom0. We usually have a lot of unused space above 4GB, and might
> have some unused space below 4GB (depends on guest memory size).
> Try to allocate separate 2MB-aligned extended regions from the first
> (below 4GB) and second (above 4GB) RAM banks taking into the account
> the maximum supported guest physical address space size and the amount
> of memory assigned to the guest. The minimum size of extended region
> the same as for Dom0 (64MB).
> 
> Please note, we introduce fdt_property_reg_placeholder helper which
> purpose is to create N ranges that are zeroed. The interesting fact
> is that libfdt already has fdt_property_placeholder(). But this was
> introduced only in 2017, so there is a risk that some distros may not
> ship the last libfdt version. This is why we implement our own light
> variant for now.
> 
> Suggested-by: Julien Grall <jgrall@amazon.com>
> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>

Reviewed-by: Julien Grall <jgrall@amazon.com>

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Thu Oct 14 13:07:09 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Oct 2021 13:07:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.209327.365741 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mb0Rg-00063Y-F5; Thu, 14 Oct 2021 13:06:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 209327.365741; Thu, 14 Oct 2021 13:06:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mb0Rg-00063R-C7; Thu, 14 Oct 2021 13:06:52 +0000
Received: by outflank-mailman (input) for mailman id 209327;
 Thu, 14 Oct 2021 13:06:51 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mb0Rf-00063H-25; Thu, 14 Oct 2021 13:06:51 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mb0Re-0000XF-Rx; Thu, 14 Oct 2021 13:06:50 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mb0Re-0007Em-Fd; Thu, 14 Oct 2021 13:06:50 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mb0Re-000246-F2; Thu, 14 Oct 2021 13:06:50 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=Anx2WJLhLUfMhz3sz4f48OIOyNezghzBoMu8f75o8pA=; b=w9HArMYB4Y8XK0BZPXYqBPD1je
	qlpQpQwnbIszN0L5tyk5sUqrX5mCvAfKowEa2ovUyR02vx8MtxHUDMzzYbKRCCP6WF7wRtnNheujv
	6fhjwgz3g8ZoTB/CSht+G2Ig+o8NMM6dMRPWLbzkG4uYEX4etwZ7keulO1u+M2KeZSC4=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165503-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 165503: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-unstable:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=9e319e5258d0274c15da2ea9355dc1569a0fa832
X-Osstest-Versions-That:
    xen=f9294486926c865a3ef11cacd7cb6b26cce6f4a4
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 14 Oct 2021 13:06:50 +0000

flight 165503 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165503/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-rtds     20 guest-localmigrate/x10       fail  like 165491
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 165491
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 165491
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165491
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165491
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 165491
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 165491
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 165491
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 165491
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 165491
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 165491
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165491
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 165491
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  9e319e5258d0274c15da2ea9355dc1569a0fa832
baseline version:
 xen                  f9294486926c865a3ef11cacd7cb6b26cce6f4a4

Last test of basis   165491  2021-10-13 06:50:37 Z    1 days
Testing same since   165503  2021-10-13 23:38:04 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Anthony PERARD <anthony.perard@citrix.com>
  Ian Jackson <iwj@xenproject.org>
  Julien Grall <julien@xen.org>
  Michal Orzel <michal.orzel@arm.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     fail    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   f929448692..9e319e5258  9e319e5258d0274c15da2ea9355dc1569a0fa832 -> master


From xen-devel-bounces@lists.xenproject.org Thu Oct 14 13:11:35 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Oct 2021 13:11:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.209342.365766 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mb0WE-0007dQ-AT; Thu, 14 Oct 2021 13:11:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 209342.365766; Thu, 14 Oct 2021 13:11:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mb0WE-0007dJ-77; Thu, 14 Oct 2021 13:11:34 +0000
Received: by outflank-mailman (input) for mailman id 209342;
 Thu, 14 Oct 2021 13:11:32 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mb0WC-0007d0-MD; Thu, 14 Oct 2021 13:11:32 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mb0WC-0000dH-IF; Thu, 14 Oct 2021 13:11:32 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mb0WC-0007PD-6j; Thu, 14 Oct 2021 13:11:32 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mb0WC-0001EY-6E; Thu, 14 Oct 2021 13:11:32 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=s0ngBd04pkzMBrPUrSmgKjz9YTgqAM3NPdf5HhbTEgo=; b=4vVBCYbc18/paGBu4P+LVkBKjZ
	qEoSVHDngmNWy30iMHDaSjJRfJfom3QcKXXTt1hym+25j3qyYVkO8Ep/b6LNBwJvwh/gEKP8ScY2M
	ydX7kKMWmaV7EKpLOXMyI9FzpPp/iuNRMfQdguVVaCqsjy2v9vctNAxWwCFpHcSfeokc=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165504-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 165504: regressions - FAIL
X-Osstest-Failures:
    libvirt:build-armhf-libvirt:libvirt-build:fail:regression
    libvirt:build-amd64-libvirt:libvirt-build:fail:regression
    libvirt:build-arm64-libvirt:libvirt-build:fail:regression
    libvirt:build-i386-libvirt:libvirt-build:fail:regression
    libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    libvirt=61cb54e3cbefc389d64357d9c479750593855383
X-Osstest-Versions-That:
    libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 14 Oct 2021 13:11:32 +0000

flight 165504 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165504/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-armhf-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-amd64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-arm64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-i386-libvirt            6 libvirt-build            fail REGR. vs. 151777

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-libvirt-vhd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a

version targeted for testing:
 libvirt              61cb54e3cbefc389d64357d9c479750593855383
baseline version:
 libvirt              2c846fa6bcc11929c9fb857a22430fb9945654ad

Last test of basis   151777  2020-07-10 04:19:19 Z  461 days
Failing since        151818  2020-07-11 04:18:52 Z  460 days  446 attempts
Testing same since   165504  2021-10-14 04:21:19 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
    Adolfo Jayme Barrientos <fitoschido@gmail.com>
  Aleksandr Alekseev <alexander.alekseev@virtuozzo.com>
  Aleksei Zakharov <zaharov@selectel.ru>
  Andika Triwidada <andika@gmail.com>
  Andrea Bolognani <abologna@redhat.com>
  Ani Sinha <ani@anisinha.ca>
  Balázs Meskó <meskobalazs@mailbox.org>
  Barrett Schonefeld <bschoney@utexas.edu>
  Bastian Germann <bastiangermann@fishpost.de>
  Bastien Orivel <bastien.orivel@diateam.net>
  BiaoXiang Ye <yebiaoxiang@huawei.com>
  Bihong Yu <yubihong@huawei.com>
  Binfeng Wu <wubinfeng@huawei.com>
  Bjoern Walk <bwalk@linux.ibm.com>
  Boris Fiuczynski <fiuczy@linux.ibm.com>
  Brian Turek <brian.turek@gmail.com>
  Bruno Haible <bruno@clisp.org>
  Chris Mayo <aklhfex@gmail.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Ehrhardt <christian.ehrhardt@canonical.com>
  Christian Kirbach <christian.kirbach@gmail.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Cole Robinson <crobinso@redhat.com>
  Collin Walling <walling@linux.ibm.com>
  Cornelia Huck <cohuck@redhat.com>
  Cédric Bosdonnat <cbosdonnat@suse.com>
  Côme Borsoi <fedora@borsoi.fr>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniel Letai <dani@letai.org.il>
  Daniel P. Berrange <berrange@redhat.com>
  Daniel P. Berrangé <berrange@redhat.com>
  Didik Supriadi <didiksupriadi41@gmail.com>
  dinglimin <dinglimin@cmss.chinamobile.com>
  Dmytro Linkin <dlinkin@nvidia.com>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Eric Farman <farman@linux.ibm.com>
  Erik Skultety <eskultet@redhat.com>
  Fabian Affolter <mail@fabian-affolter.ch>
  Fabian Freyer <fabian.freyer@physik.tu-berlin.de>
  Fabiano Fidêncio <fabiano@fidencio.org>
  Fangge Jin <fjin@redhat.com>
  Farhan Ali <alifm@linux.ibm.com>
  Fedora Weblate Translation <i18n@lists.fedoraproject.org>
  gongwei <gongwei@smartx.com>
  Guoyi Tu<tu.guoyi@h3c.com>
  Göran Uddeborg <goeran@uddeborg.se>
  Halil Pasic <pasic@linux.ibm.com>
  Han Han <hhan@redhat.com>
  Hao Wang <wanghao232@huawei.com>
  Hela Basa <r45xveza@pm.me>
  Helmut Grohne <helmut@subdivi.de>
  Hiroki Narukawa <hnarukaw@yahoo-corp.jp>
  Ian Wienand <iwienand@redhat.com>
  Jakob Meng <jakobmeng@web.de>
  Jamie Strandboge <jamie@canonical.com>
  Jamie Strandboge <jamie@ubuntu.com>
  Jan Kuparinen <copper_fin@hotmail.com>
  jason lee <ppark5237@gmail.com>
  Jean-Baptiste Holcroft <jean-baptiste@holcroft.fr>
  Jia Zhou <zhou.jia2@zte.com.cn>
  Jianan Gao <jgao@redhat.com>
  Jim Fehlig <jfehlig@suse.com>
  Jin Yan <jinyan12@huawei.com>
  Jinsheng Zhang <zhangjl02@inspur.com>
  Jiri Denemark <jdenemar@redhat.com>
  John Ferlan <jferlan@redhat.com>
  Jonathan Watt <jwatt@jwatt.org>
  Jonathon Jongsma <jjongsma@redhat.com>
  Julio Faracco <jcfaracco@gmail.com>
  Justin Gatzen <justin.gatzen@gmail.com>
  Ján Tomko <jtomko@redhat.com>
  Kashyap Chamarthy <kchamart@redhat.com>
  Kevin Locke <kevin@kevinlocke.name>
  Kristina Hanicova <khanicov@redhat.com>
  Laine Stump <laine@redhat.com>
  Laszlo Ersek <lersek@redhat.com>
  Lee Yarwood <lyarwood@redhat.com>
  Lei Yang <yanglei209@huawei.com>
  Liao Pingfang <liao.pingfang@zte.com.cn>
  Lin Ma <lma@suse.com>
  Lin Ma <lma@suse.de>
  Lin Ma <morecache@gmail.com>
  Liu Yiding <liuyd.fnst@fujitsu.com>
  Luke Yue <lukedyue@gmail.com>
  Luyao Zhong <luyao.zhong@intel.com>
  Marc Hartmayer <mhartmay@linux.ibm.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Markus Schade <markus.schade@hetzner.com>
  Martin Kletzander <mkletzan@redhat.com>
  Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
  Matej Cepl <mcepl@cepl.eu>
  Matt Coleman <matt@datto.com>
  Matt Coleman <mcoleman@datto.com>
  Mauro Matteo Cascella <mcascell@redhat.com>
  Meina Li <meili@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Michał Smyk <fedora@smyk.it>
  Milo Casagrande <milo@milo.name>
  Moshe Levi <moshele@nvidia.com>
  Muha Aliss <muhaaliss@gmail.com>
  Nathan <nathan95@live.it>
  Neal Gompa <ngompa13@gmail.com>
  Nick Chevsky <nchevsky@gmail.com>
  Nick Shyrokovskiy <nshyrokovskiy@gmail.com>
  Nickys Music Group <nickys.music.group@gmail.com>
  Nico Pache <npache@redhat.com>
  Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
  Olaf Hering <olaf@aepfle.de>
  Olesya Gerasimenko <gammaray@basealt.ru>
  Orion Poplawski <orion@nwra.com>
  Pany <geekpany@gmail.com>
  Patrick Magauran <patmagauran.j@gmail.com>
  Paulo de Rezende Pinatti <ppinatti@linux.ibm.com>
  Pavel Hrdina <phrdina@redhat.com>
  Peng Liang <liangpeng10@huawei.com>
  Peter Krempa <pkrempa@redhat.com>
  Pino Toscano <ptoscano@redhat.com>
  Pino Toscano <toscano.pino@tiscali.it>
  Piotr Drąg <piotrdrag@gmail.com>
  Prathamesh Chavan <pc44800@gmail.com>
  Praveen K Paladugu <prapal@linux.microsoft.com>
  Richard W.M. Jones <rjones@redhat.com>
  Ricky Tigg <ricky.tigg@gmail.com>
  Robin Lee <cheeselee@fedoraproject.org>
  Roman Bogorodskiy <bogorodskiy@gmail.com>
  Roman Bolshakov <r.bolshakov@yadro.com>
  Ryan Gahagan <rgahagan@cs.utexas.edu>
  Ryan Schmidt <git@ryandesign.com>
  Sam Hartman <hartmans@debian.org>
  Scott Shambarger <scott-libvirt@shambarger.net>
  Sebastian Mitterle <smitterl@redhat.com>
  SeongHyun Jo <caelus9536@gmail.com>
  Shalini Chellathurai Saroja <shalini@linux.ibm.com>
  Shaojun Yang <yangshaojun@phytium.com.cn>
  Shi Lei <shi_lei@massclouds.com>
  simmon <simmon@nplob.com>
  Simon Chopin <chopin.simon@gmail.com>
  Simon Gaiser <simon@invisiblethingslab.com>
  Simon Rowe <simon.rowe@nutanix.com>
  Stefan Bader <stefan.bader@canonical.com>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Berger <stefanb@linux.vnet.ibm.com>
  Stefan Hajnoczi <stefanha@gmail.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Szymon Scholz <szymonscholz@gmail.com>
  Thomas Huth <thuth@redhat.com>
  Tim Wiederhake <twiederh@redhat.com>
  Tomáš Golembiovský <tgolembi@redhat.com>
  Tomáš Janoušek <tomi@nomi.cz>
  Tuguoyi <tu.guoyi@h3c.com>
  Victor Toso <victortoso@redhat.com>
  Ville Skyttä <ville.skytta@iki.fi>
  Vinayak Kale <vkale@nvidia.com>
  Wang Xin <wangxinxin.wang@huawei.com>
  WangJian <wangjian161@huawei.com>
  Weblate <noreply@weblate.org>
  Wei Liu <liuwe@microsoft.com>
  Wei Liu <wei.liu@kernel.org>
  Wei-Chen Chen <weicche@microsoft.com>
  William Douglas <william.douglas@intel.com>
  Yalei Li <274268859@qq.com>
  Yalei Li <liyl43@chinatelecom.cn>
  Yang Fei <yangfei85@huawei.com>
  Yang Hang <yanghang44@huawei.com>
  Yanqiu Zhang <yanqzhan@redhat.com>
  Yaroslav Kargin <ykargin@virtuozzo.com>
  Yi Li <yili@winhong.com>
  Yi Wang <wang.yi59@zte.com.cn>
  Yuri Chornoivan <yurchor@ukr.net>
  Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
  zhangjl02 <zhangjl02@inspur.com>
  Zheng Chuan <zhengchuan@huawei.com>
  zhenwei pi <pizhenwei@bytedance.com>
  Zhenyu Ye <yezhenyu2@huawei.com>
  Zhenyu Zheng <zheng.zhenyu@outlook.com>
  Zhenzhong Duan <zhenzhong.duan@intel.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          fail    
 build-arm64-libvirt                                          fail    
 build-armhf-libvirt                                          fail    
 build-i386-libvirt                                           fail    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           blocked 
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-libvirt-xsm                                 blocked 
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-libvirt                                     blocked 
 test-arm64-arm64-libvirt                                     blocked 
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-libvirt-pair                                blocked 
 test-amd64-i386-libvirt-pair                                 blocked 
 test-arm64-arm64-libvirt-qcow2                               blocked 
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-libvirt-vhd                                 blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 79452 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Oct 14 13:34:36 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Oct 2021 13:34:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.209352.365781 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mb0sQ-0001Y9-7b; Thu, 14 Oct 2021 13:34:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 209352.365781; Thu, 14 Oct 2021 13:34:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mb0sQ-0001Y2-4B; Thu, 14 Oct 2021 13:34:30 +0000
Received: by outflank-mailman (input) for mailman id 209352;
 Thu, 14 Oct 2021 13:34:28 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=i4ou=PC=citrix.com=anthony.perard@srs-us1.protection.inumbo.net>)
 id 1mb0sO-0001Xw-Eg
 for xen-devel@lists.xenproject.org; Thu, 14 Oct 2021 13:34:28 +0000
Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 97a55bdf-5cb6-4cd3-9c0a-3ac2e48e688c;
 Thu, 14 Oct 2021 13:34:26 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 97a55bdf-5cb6-4cd3-9c0a-3ac2e48e688c
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1634218466;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=MhXyq+Rzyyhop89gfzQKPj624c38hqTaXr9TnqT1qRM=;
  b=aGxfPV1uDu5GXRPFUj4+02GVbv4pFTpWurKa7RHqy/p7g5UYjz6d0blZ
   PvWhTbW9WnFGecA635xitNUjQb9hORjP9+tz+Kbl3Mp2HEyhiaOXNqWB8
   TVO8jHr3OIpk9KXCy8U5hOdoarCn83D4gOEWvD6xWeSFbgLFahPBPBeDq
   U=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: DjcxAUayJnJEou+aQN4yeHHnz01yliQ1tilWzEqc9HxnJKquo+6Q0rMqWqdIuM4VMQ28lZwEQE
 yY7OCNYXL8F0JPP9ig+eL3PjyDxDcual8Pe+Rj8cteR80BWAX5y+7CMJm1GP+Ye+I97KxD18y5
 4Zh7efSn7N41nJ8A1yjSZCcLW5i2l0+6a+F95v2Ywqk4bBwBRrmY1UtH6j2qzAEMuRWlm9HdbM
 dQwl/vgY0pygf7V0nZEduBJE4W3rc2y1+Gr3S8i+ivzbiIVmu8wQESbl8aUiLV53E9V2Q08pBp
 70jJpEAGMs5amiZ8fxV66Vd7
X-SBRS: 5.1
X-MesageID: 55221597
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:76SV/60IdpsO9Te7j/bD5e13kn2cJEfYwER7XKvMYLTBsI5bp2QFy
 2EeXj+Ca//fM2r0LYtyPdiyoR4C6JGHndVmTAFopC1hF35El5HIVI+TRqvS04J+DSFhoGZPt
 Zh2hgzodZhsJpPkS5PE3oHJ9RGQ74nRLlbHILOCan0ZqTNMEn970Es7wrJh2+aEvPDia++zk
 YKqyyHgEAfNNw5cagr4PIra9XuDFNyr0N8plgRWicJj5TcypFFMZH4rHomjLmOQf2VhNrXSq
 9Avbl2O1jixEx8FUrtJm1tgG6EAaua60QOm0hK6V0U+6/TrS+NbPqsTbZIhhUlrZzqhs+hey
 4Rs75OKQiwwYILhx80NYiV8HHQrVUFG0OevzXmXtMWSywvNcmf2wuUoB0YzVWEa0r8pWycUr
 6VecW1TKEDY7w616OvTpu1Ej8I/LM7tLcUHt2tp1z3xBvc6W5HTBa7N4Le02R9t25oURKuPO
 KL1bxJuSCrJWDd9IW4xUqISpdWxgl3HcwRh/Qf9Sa0fvDGIkV0ZPKLWGNnSfMaDSYNKn0Kbj
 mXc9m/9D1cRM9n34TGC9HSrhOPGgyLgcI0XHby8sPVthTW7z2gSEwEfVEH9r+OwjEW/QPpAJ
 0dS8S0rxYAi+UruQtTjUhmQpH+fogVaS9dWC/c96gyG1uzT+QnxLmQcVTtAdNwOvdc7XyA3z
 USOm871BDtpq/ueTnf13ruboT69IyE9MX4JZShCSxAMpdbkvukbsBXLSdpyFb+vuff8Ezrw3
 jOioTA3gvMYistj/6Sk/3jXjjS0vJ/LQwUpoALNUQqN5ARzbp+ofIys5F3S695PKY+YSh+Ku
 31ss8qU4f0KDJqNvDeQW+hLF7asj96aNBXMjFgpGIMunxy24GKqd41U5DB4JW9qP9wCdDuvZ
 1Xc0StT+ZtSMX2CfaJxJYWrBKwXIbPITIq/EKqON5wXP8Y3JFTvEDxSiVC481jCkxkNy64FM
 ryCL+mBUl8KOJhDw2/jLwsC6oMDyic7zGLVYJn0yRW7zLaTDEKopac53EimNb9hsvvVyOnB2
 5MGbZHSkkQAOAHrSnCPqdZ7ELwcEZQs6XkaQeRsfemfPhEuJmglD/LAqV/KU904x/oL/gskE
 3fUZ6O59LYdrSGYQelpQio6AF8KYXqZhSlmVcDLFQz5s0XPma71sM8im2IfJNHLDtBLw/9uV
 OUicM6dGPlJQTmv021DNsWk8dQ8K0X121rm08+ZjN4XJMMIq+vhoI6MQ+cS3HNWUnrfWTUW8
 tVMKT83sbJcHl8/Xa46mdqkzk+rvGh1pQ6BdxCgHzWnQ221qNICA3Wo1pcfephQQT2elmry/
 1vHWn8w+LiSy7LZBfGU3MhoWa/ySLAgdqebdkGGhYuL2d7ypTH6mtUaDrbWLVgwlgrcoc2fW
 Amc9NmkWNVvobqAm9YU/29Dwf1s6t3xiaVdywg4TnzHY07yUuFrI2Wc3NkJvapIn+cLtQyzU
 0OJ299bJbTWZ5+1TA9PfFIoPraZyPUZujjO9vBpck/00zB6oeicWkJIMhjS1CEEdOlpMJkoy
 PsKsdIN71DtkQIjN9uL13gG92mFInEafb8gs5UWXN3ihgYxkwkQap3AEC7mppqIbowUYEUtJ
 zaVgovEhqhdmRWeIyZiSyCV0LME15oUuR1MwFsTHHizm4LI1q0twRlc0TUrVQAJnB9J5P1+Z
 zpwPEpvKKTQozox3JpfX3qhEh1qDQGC/hCj0EMAkWDUQhX6VmHJK2Fha++B8FpArjBZdzlfu
 rqZ1HzkQXDhe8Sohnk+XktsqvrCS91t91KdxJD7TprdR5RqMyD4hqKOZHYTr0q1CMw8s0TLu
 O128bsicqb8LyMR//U2BoTyOW78k/xYyLiumc1cwZ4=
IronPort-HdrOrdr: A9a23:DvHEtK0eeTwa/KvjGOTRdQqjBL4kLtp133Aq2lEZdPUCSL39qy
 ncppUmPH7P5wr5N0tNpTntAsO9qDbnhP1ICOoqVotKPjOHhILAFugL0WKh+UyDJ8SUzJ856U
 4PScVD4JSbNzZHsfo=
X-IronPort-AV: E=Sophos;i="5.85,372,1624334400"; 
   d="scan'208";a="55221597"
Date: Thu, 14 Oct 2021 14:33:54 +0100
From: Anthony PERARD <anthony.perard@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Bob Eshleman <bobbyeshleman@gmail.com>, Andrew Cooper
	<andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>, "Ian
 Jackson" <iwj@xenproject.org>, Julien Grall <julien@xen.org>, "Stefano
 Stabellini" <sstabellini@kernel.org>, Wei Liu <wl@xen.org>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Alistair Francis <alistair.francis@wdc.com>,
	Connor Davis <connojdavis@gmail.com>, Roger Pau =?iso-8859-1?Q?Monn=E9?=
	<roger.pau@citrix.com>, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>, "Ross
 Lagerwall" <ross.lagerwall@citrix.com>, Daniel De Graaf
	<dgdegra@tycho.nsa.gov>, "Daniel P. Smith" <dpsmith@apertussolutions.com>,
	<xen-devel@lists.xenproject.org>
Subject: Re: [XEN PATCH v7 26/51] build: build everything from the root dir,
 use obj=$subdir
Message-ID: <YWgxwszDto5E9aoO@perard>
References: <20210824105038.1257926-1-anthony.perard@citrix.com>
 <20210824105038.1257926-27-anthony.perard@citrix.com>
 <eca3f533-9841-e4a8-dfde-840451ed8aef@suse.com>
 <YWbsGlcDZSSXsJlx@perard>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <YWbsGlcDZSSXsJlx@perard>

On Wed, Oct 13, 2021 at 03:24:31PM +0100, Anthony PERARD wrote:
> On Mon, Oct 11, 2021 at 04:02:22PM +0200, Jan Beulich wrote:
> > On 24.08.2021 12:50, Anthony PERARD wrote:
> > >  ifeq ($(CONFIG_ENFORCE_UNIQUE_SYMBOLS),y)
> > >      cmd_cc_o_c = $(CC) $(c_flags) -c $< -o $(dot-target).tmp -MQ $@
> > >      ifeq ($(CONFIG_CC_IS_CLANG),y)
> > > -        cmd_objcopy_fix_sym = $(OBJCOPY) --redefine-sym $<=$(SRCPATH)/$< $(dot-target).tmp $@
> > > +        cmd_objcopy_fix_sym = $(OBJCOPY) --redefine-sym $(<F)=$< $(dot-target).tmp $@
> > 
> > Are you sure about the $< => $(<F) transformation here? Previoiusly it
> > was present only ...
> 
> I have to check again. Maybe $< didn't work and it's more obvious with
> this patch. Or maybe that depends on the version of clang.

With clang 12, the original line doesn't work for the few objects that
are built from "subdir/source.c". I guess it is just by luck that they
aren't any duplicated symbols.

> > >      else
> > > -        cmd_objcopy_fix_sym = $(OBJCOPY) --redefine-sym $(<F)=$(SRCPATH)/$< $(dot-target).tmp $@
> > > +        cmd_objcopy_fix_sym = $(OBJCOPY) --redefine-sym $(<F)=$< $(dot-target).tmp $@
> > 
> > ... here.

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Thu Oct 14 13:54:55 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Oct 2021 13:54:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.209361.365792 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mb1C3-0003sC-Uv; Thu, 14 Oct 2021 13:54:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 209361.365792; Thu, 14 Oct 2021 13:54:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mb1C3-0003s5-QH; Thu, 14 Oct 2021 13:54:47 +0000
Received: by outflank-mailman (input) for mailman id 209361;
 Thu, 14 Oct 2021 13:54:47 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mb1C3-0003rz-Aj
 for xen-devel@lists.xenproject.org; Thu, 14 Oct 2021 13:54:47 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mb1C3-0001Jl-8F
 for xen-devel@lists.xenproject.org; Thu, 14 Oct 2021 13:54:47 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mb1C3-00021V-79
 for xen-devel@lists.xenproject.org; Thu, 14 Oct 2021 13:54:47 +0000
Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89)
 (envelope-from <iwj@xenproject.org>)
 id 1mb1By-0002bt-8V; Thu, 14 Oct 2021 14:54:42 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date
	:Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From;
	bh=c7P4q8TpdljOv2xbOLZyvFln737ck8V3V/O4SKHnCis=; b=Hc72Cioq3oRpROe4oejq5xT1rL
	qsshwSJJjNH1Sna7kN5Q629tjXkOIB/Nm7rZSNfecdAQYjmJDfUC40B1juKLWggjdmtcw6Wsf//8L
	5YahT3EbQH1os16JAG8F7y9RG/rY71CUQlN1O3eoD7AnjMY0X6VfByE+ox2vk9oQxfuA=;
From: Ian Jackson <iwj@xenproject.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <24936.13986.18506.868837@mariner.uk.xensource.com>
Date: Thu, 14 Oct 2021 14:54:42 +0100
To: Julien Grall <julien@xen.org>
Cc: Oleksandr Tyshchenko <olekstysh@gmail.com>,
    xen-devel@lists.xenproject.org,
    Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
    Wei Liu <wl@xen.org>,
    Anthony PERARD <anthony.perard@citrix.com>,
    Juergen Gross <jgross@suse.com>,
    Stefano Stabellini <sstabellini@kernel.org>,
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH V7 2/2] libxl/arm: Add handling of extended regions for
 DomU
In-Reply-To: <321a7bc4-f39e-bead-3837-c2ec640741b6@xen.org>
References: <1634211645-26912-1-git-send-email-olekstysh@gmail.com>
	<1634211645-26912-3-git-send-email-olekstysh@gmail.com>
	<321a7bc4-f39e-bead-3837-c2ec640741b6@xen.org>
X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu)

Julien Grall writes ("Re: [PATCH V7 2/2] libxl/arm: Add handling of extended regions for DomU"):
> On 14/10/2021 12:40, Oleksandr Tyshchenko wrote:
> > From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
...
> > Suggested-by: Julien Grall <jgrall@amazon.com>
> > Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> 
> Reviewed-by: Julien Grall <jgrall@amazon.com>

Again, on that basis,

Acked-by: Ian Jackson <iwj@xenproject.org>

Thanks all.

Ian.


From xen-devel-bounces@lists.xenproject.org Thu Oct 14 13:54:58 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Oct 2021 13:54:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.209362.365803 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mb1CE-0004Ay-5d; Thu, 14 Oct 2021 13:54:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 209362.365803; Thu, 14 Oct 2021 13:54:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mb1CE-0004Ap-1r; Thu, 14 Oct 2021 13:54:58 +0000
Received: by outflank-mailman (input) for mailman id 209362;
 Thu, 14 Oct 2021 13:54:56 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Xl23=PC=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mb1CC-0004A6-Kc
 for xen-devel@lists.xenproject.org; Thu, 14 Oct 2021 13:54:56 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 4f592896-2cf6-11ec-81c2-12813bfff9fa;
 Thu, 14 Oct 2021 13:54:55 +0000 (UTC)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2055.outbound.protection.outlook.com [104.47.14.55]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-10-Abi1ZGXPPvijgR-RibTANQ-1; Thu, 14 Oct 2021 15:54:53 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0402MB2829.eurprd04.prod.outlook.com (2603:10a6:800:bb::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.22; Thu, 14 Oct
 2021 13:54:51 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.016; Thu, 14 Oct 2021
 13:54:51 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS9PR06CA0012.eurprd06.prod.outlook.com (2603:10a6:20b:462::34) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16 via Frontend
 Transport; Thu, 14 Oct 2021 13:54:49 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4f592896-2cf6-11ec-81c2-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634219694;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=Au4/intUNt1F1RcZPZkdcG/pzO04E91WYBj/x6LLBs4=;
	b=XGbu7y+Ichq7pwDGY8dhDaWnfMVuVGuSIrH5+L0CLxejup2Y/HCsUqHtAJ0F7k7+Rk+r2W
	5G2rIOTjHO0wUCLm1JObM2PIj4HwwLWKEuQ1Bl2sTGcsxtiRCjD23Lmp/26XWnvYuuHOSo
	hX2TRwpGehb8JxlttH67pu9tsqOwO60=
X-MC-Unique: Abi1ZGXPPvijgR-RibTANQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=mxZeJbcxnjugx7NpTTTxo/6ytnpR4b8MjmkTtlKEOB2wgZAYVoskYdWi4zcbm8ZuMD4XSghPH12IWo+/1sc5lyoJ61jWiIITRNjQxwdRmdTU5PDaN2NCd/lifWotXDsR2ZFmCoNuPLkPx0EPLiYVuXSS3XFeOkMJpxw0qhTfHJUdz2zTMIoxkHPUEUaJw5QIZiyeTUyrAxFMFPUjEBEbUlOwTWzZH760qMTEau7Qxg/SQ5V3d4uQ2rkjOJOj5k+qLEPh9CYemZ9zZnsQxvZD/xM9BIiYyV1NkQP5uwEMtJhp6wVtili3HQ4e+UyW+xYUeLZcZ4DhCxYEqU9JqCCmqg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Au4/intUNt1F1RcZPZkdcG/pzO04E91WYBj/x6LLBs4=;
 b=YWUUlp9NlABgAa2IY6lbcS82MXGHg3sbewSpuj+77Lq2TSxoQD+6gC/1J+q8CO8Y2imuaLeEpOl27QwEDhD+5eczk8AMMiKS7ekUl+K6W3t3af6nDTCqtUI/vgq26zmf0ZvGhTsltyNBk5DpxUGEFqqYr+y/gsMF+Cx2F6WdVsk7gigt0y5FffTBsMPTqZ4nJPhiB8ixyIzSNnj628MgjNU686oaApluCm1eepLt9L1tDx/+ODLdZvtM0/bWzNe0A5mkIZmapiUZVt4ZutTpJLcx/wHus84//DlEPgQzGf97Pde6ZyneXDV7WGJuAkdxobYbzIU6Ef19eUNk3fSLDQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [XEN PATCH v7 26/51] build: build everything from the root dir,
 use obj=$subdir
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: Bob Eshleman <bobbyeshleman@gmail.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Alistair Francis <alistair.francis@wdc.com>,
 Connor Davis <connojdavis@gmail.com>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
 Ross Lagerwall <ross.lagerwall@citrix.com>,
 Daniel De Graaf <dgdegra@tycho.nsa.gov>,
 "Daniel P. Smith" <dpsmith@apertussolutions.com>,
 xen-devel@lists.xenproject.org
References: <20210824105038.1257926-1-anthony.perard@citrix.com>
 <20210824105038.1257926-27-anthony.perard@citrix.com>
 <eca3f533-9841-e4a8-dfde-840451ed8aef@suse.com> <YWbsGlcDZSSXsJlx@perard>
 <YWgxwszDto5E9aoO@perard>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <940a9939-079c-16ca-46bc-63ba0a10d5b5@suse.com>
Date: Thu, 14 Oct 2021 15:54:48 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <YWgxwszDto5E9aoO@perard>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0012.eurprd06.prod.outlook.com
 (2603:10a6:20b:462::34) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 8906127c-d068-4942-f748-08d98f1a316e
X-MS-TrafficTypeDiagnostic: VI1PR0402MB2829:
X-Microsoft-Antispam-PRVS:
	<VI1PR0402MB282993929406D7BEE1D602D1B3B89@VI1PR0402MB2829.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8273;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	zQdPwcKC6TnP8to4VVnpIwxZr3OVic3mvwXwpctpUqLMFKNsr0w2djJc5O8TiCbf6Vae+rnIaqVdgn/uWPptYshH9hzRPiNfEnh4owFVspwGeJYNEQS+dd+XjNU1QTtXF+obQASqaXYCaQlAZHQKzgON2l61eqUK/DRUUOlJ2IuEjztjDn3V3YYixKFEBfSLHrXvj1Lqmw7Dug7CUbMIvZtW4n43ghEUKiGIuyC5FPA9S3QwXDy914fMcPJBixa3BxHw40qqRMhhUOwkxQGspTpT7oUoxFm2aT3WsyDaVi6nzFia/g6Cb+lfBHho0WhAxLNICTBTzDMzlJXgZU1GY/LoFTA15H8w6FScSfkRhr/pzdfnjCCOFoTYIarsF+ppq5eJIt2QBSPY8jFKtElygmWfmWqRe5X/gEtWF1KbaaLOz0S9der9t86qXJiP2L+i746PKEIECgxQLe/gSyKaI+pGobddg4Uzdb7XvWnM0o/RkbaXlZWeHl+/0AOwjSmWRPMh14oMrFy8qIRBXuvXDI3tpt8I28Ct9FTyQ4R0ngdgOglYN4D0Rb4tgS3u5QvsqEE9qnELWhpjF3dxq8ALQCPLKKb2BrwjhdyUZ49TwsH8WXxJ6OdYXV4veCMtot8mrWF5zq2Yq06wQX485/wR0jXIkWqC/yofOLAEljgTzd4j2YZWtcJKi4V4WwCQULk49vBXelG0kxIodhZZeyXUzZx/robwgSXRpn7ym3HvxgkeqexnzlTNJb7tbi68/iB4
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(36756003)(8676002)(66556008)(956004)(86362001)(4326008)(5660300002)(7416002)(316002)(2616005)(31686004)(2906002)(6916009)(66946007)(16576012)(508600001)(6486002)(54906003)(66476007)(8936002)(53546011)(186003)(26005)(38100700002)(31696002)(155303001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?NUVRbGpNdEdpdnZ3Unh3WDBkZFc0ZjhEanRLUThoc3IvMzVwR2U3dFYxQ1BV?=
 =?utf-8?B?RGVOVjNsZHMvZjVCWlR1VzhybUt2cnVZeldwbytzay8vaHNJTm1HTDROTWFp?=
 =?utf-8?B?R3JwWENsUjRub1NpK2RxcHB2Z2JwRlYybmhrMEFXQ0Y3ZVd6NUU5SnY5MXND?=
 =?utf-8?B?MVY1STVuSjAxRnNlNDZQbWNDY1IreW1hYSs2Z08vWU9LUFcrT3Z4Lzg4Smhk?=
 =?utf-8?B?UjlYNGhubVRad0x1TUx0aXVzMTI5OGkrL1RKTXhOQ1YzMFlMVlYxMU96VjEx?=
 =?utf-8?B?TWZtcW5Zd1VPVXVPZnRiWDZKOEYwcEN1czBvTnRqRmoxY3V0Y2QzNEM1eXEx?=
 =?utf-8?B?WkJkdVl2SUsyYTVrRE5yVlNEZUJXWXh3d2J4d1BYQlgydkFmOWJQK2xSQVRh?=
 =?utf-8?B?eDdIb3k3ZGRKb2VySDJ5SmowWC95RTlQbDJ6b3FTd2xTVXlJeFZIWDRGUGVD?=
 =?utf-8?B?bDJTRXowOWs5bUVUK3FXd2kvY05hejlRTU1GOXV1S2l6cmpvT0VMYVZ3b3ZT?=
 =?utf-8?B?SDAycmNqUldVYUxxaW5rTHhFVDlUTFVnTWsrY2k1TDBQWU5aQXpwTWc0emJG?=
 =?utf-8?B?SDNGOEVaYkJ0OUNaaG9xd0ErWjFRTHdiNWRJbGIwK3JOTVhnalBUREEvVGM5?=
 =?utf-8?B?WGRBb0hTcEQrWkNlcHNXcnV1THFMMEVxbGI2MFVPNkxFV1lWQkROcFA5V1ND?=
 =?utf-8?B?M0ZmU2VGWDdEWGlYN2lHMUw4SklKWU45WFhwWDRzTkJpeTNpTEJNRk9rQ3dZ?=
 =?utf-8?B?TXVrYXU5ZGV1R0VkeDJnRFYzeVJqaDJPK2cwUE43aUFod0xLbTA4QWRoYzJ6?=
 =?utf-8?B?eUFBbWJtN0hWVGtRTEZhL2tWakVndWhMNHg5Y2pjczk5ZFI4R1dCSlkySmJl?=
 =?utf-8?B?M0JGcDFYZkJQVlVEYTRXakN2TXZsRFlQN0lpaVFCWmRsZjMxOTRFckQyZFpO?=
 =?utf-8?B?cVlhdFY0NnJQWTdjbFJpdHErcWt5Q2FwZmlaMkNBanJrSXdQd040bTl4MVJN?=
 =?utf-8?B?WFhHRCs0N1pqK25nOGZiVGp3TzI5Z1BOaEwvblI1RXJrZG90UE85eG5jZWxO?=
 =?utf-8?B?V1owTi85RXFaczFHSm84ejFubUtDdkdUTHBnVXBpRW8vYUs1Z3dIY2JJd1lG?=
 =?utf-8?B?VU5DMWhtUkRyZmhVZHZPTHljWE1qcFZRUkVHckYwNUI5UzBEUVI2SHhrNmpZ?=
 =?utf-8?B?dnQrOWJpNk5GeWxoUncrM3U3OW5GKzNvYkVETVBQUHV3Mld6cGh2YXpsaFh4?=
 =?utf-8?B?NGRCQjRXbm5ibGRsYmlmdjRJcWliM20xTDJqWGZSQi9WdFlDK0g3K3FmanRt?=
 =?utf-8?B?TWFZcVUxMHVVRTRzVkJuZkNlQUJkTjlEejYveForYnQxbDcybWl4eXZOZEJI?=
 =?utf-8?B?a2NJSzRpWjYvbFdpYkMvN2RmWkJqaURKU3huVTEzWjIrNEc2QVBQZVo0YVZt?=
 =?utf-8?B?OEtTTGluM3ZIMVQ3VXhUcG9LTVVhd2p0QWFkR3dRRGhrOHg4VEFyR2tVdkIw?=
 =?utf-8?B?V2xaNmNkOWc0OGpuWENyYkdvcjBPMnZKVlhPMzBIQ01HL0dWODBUbjVWWHlS?=
 =?utf-8?B?UVNTa2VvamZhdWNCWklzOGlZWnNVWkh4cWRxd0hkcUZyTWtnUERudFJlWm1s?=
 =?utf-8?B?V1lYZUFEbzBZcXl3Y1JaUm10UE5jdGNJenJTSitGQnFzVitFM002UFkvSUkr?=
 =?utf-8?B?R1FudVhFNnAyVjgvNUtrNTYvYUZRZWpsWDhObVVWZkVVTmtTSzdLL1AyUHhF?=
 =?utf-8?Q?QDaH+Ikf0F3O2YObffzth2JcaBN7fdne797HW4L?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8906127c-d068-4942-f748-08d98f1a316e
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2021 13:54:51.3212
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Jtz/j9UsL6exFWjyI/Ckatq4e3gAL2E9V+AFvnvaMtxIKNMSXVAMqehSzkd4cZvOY26+FpQ/WpoEfGTRgif7zA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB2829

On 14.10.2021 15:33, Anthony PERARD wrote:
> On Wed, Oct 13, 2021 at 03:24:31PM +0100, Anthony PERARD wrote:
>> On Mon, Oct 11, 2021 at 04:02:22PM +0200, Jan Beulich wrote:
>>> On 24.08.2021 12:50, Anthony PERARD wrote:
>>>>  ifeq ($(CONFIG_ENFORCE_UNIQUE_SYMBOLS),y)
>>>>      cmd_cc_o_c = $(CC) $(c_flags) -c $< -o $(dot-target).tmp -MQ $@
>>>>      ifeq ($(CONFIG_CC_IS_CLANG),y)
>>>> -        cmd_objcopy_fix_sym = $(OBJCOPY) --redefine-sym $<=$(SRCPATH)/$< $(dot-target).tmp $@
>>>> +        cmd_objcopy_fix_sym = $(OBJCOPY) --redefine-sym $(<F)=$< $(dot-target).tmp $@
>>>
>>> Are you sure about the $< => $(<F) transformation here? Previoiusly it
>>> was present only ...
>>
>> I have to check again. Maybe $< didn't work and it's more obvious with
>> this patch. Or maybe that depends on the version of clang.
> 
> With clang 12, the original line doesn't work for the few objects that
> are built from "subdir/source.c". I guess it is just by luck that they
> aren't any duplicated symbols.

Well, I recall that there was different behavior and hence different
treatment was needed. If that's no longer the case with your changes,
then that's certainly fine, but will want explaining in the description.

Jan



From xen-devel-bounces@lists.xenproject.org Thu Oct 14 13:57:23 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Oct 2021 13:57:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.209379.365813 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mb1EY-0005A9-Mq; Thu, 14 Oct 2021 13:57:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 209379.365813; Thu, 14 Oct 2021 13:57:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mb1EY-0005A2-Je; Thu, 14 Oct 2021 13:57:22 +0000
Received: by outflank-mailman (input) for mailman id 209379;
 Thu, 14 Oct 2021 13:57:21 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=i4ou=PC=citrix.com=anthony.perard@srs-us1.protection.inumbo.net>)
 id 1mb1EX-00059w-KY
 for xen-devel@lists.xenproject.org; Thu, 14 Oct 2021 13:57:21 +0000
Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id a5c34330-2cf6-11ec-81c3-12813bfff9fa;
 Thu, 14 Oct 2021 13:57:20 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a5c34330-2cf6-11ec-81c3-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1634219840;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=SobMgfbFqDHgF5S1k7yQoTAmQrOd9zZNrSDAWuk7E4g=;
  b=QOOZwz4MyZkWcSBEb14LJnnh/kqF5dcYkoucuxcj33c+J68YlEV58fUF
   Nv6eagBG+yA2R+awsigu+vlm9HdSTIGoSTgSn8hHLSUWXNUuxPDquXMG3
   wGV+rkvT5cafe2Bl2QDW4DnE0n2a3t0PMbjoK8IL2DFRwmV+jlbrVrGPX
   M=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: E9yhL4SXmmwIacL4V16UWfqVkEZ1Kc6EKPVaJ37cboxbuZVJfTicpTu5PM5ZHmTgWMAIDya07O
 1HPocQkoOw9Rjhad+ueYukiKWwYmOm0RXAE/r1Yc8YD4VfISe8AOs5A6Hs/+sISz9vQbsjUo+X
 F8wPKzIsn69ddRSnDV4qOYBEv1hlLjdbxsXeKsAft7mqn/y+bYjrxBjpZz8j4EH1u54+4uOKT+
 xZicCi72E9wPK+Oetnxti14KDH+qyZrsQhvjtO/69XigT+RVfYVVRHXkmEjrY3xql4DGXQxerb
 As9u5+KlmKKZi7AvdUaB60Fg
X-SBRS: 5.1
X-MesageID: 55178428
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:wSMxVKwhLQDoLbcTCvF6t+e6wSrEfRIJ4+MujC+fZmUNrF6WrkUFz
 TNMX2zXOKnfMGKjfNgjO42+o0JV6pSBx4JjHFM5/iAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx
 59DAjUVBJlsFhcwnvopW1TYhSEUOZugH9IQM8aZfHAsLeNYYH1500s6w7dl2tcAbeWRWGthh
 /uj+6UzB3f9s9JEGjp8B3Wr8U4HUFza4Vv0j3RmDRx5lAa2e0o9VfrzEZqZPXrgKrS4K8bhL
 wr1IBNVyUuCl/slIovNfr8W6STmSJaKVeSFoiI+t6RPHnGuD8H9u0o2HKN0VKtZt9mGt+Bx1
 NhdtJOIcyZ3A/yQnMIzQQhhARgraMWq+JefSZS+mcmazkmAeHrw2fR+SkoxOOX0+M4uXzsIr
 6ZBbmlQMFbT3Ipaw5riIgVors0lMMnsOpJZonx6xCvVJf0nXYrCU+PB4towMDIY250XQqaCP
 ZpxhTxHbybmfgV0ClYrIrkkgtqo2GfxTxR1gQfAzUYwyzeKl1EguFT3C/LOYcCDT8hRmkeep
 0rF8n7/DxVcM8aQoRKa9lq8i+mJmjn0MKoCGbv9+vN0jVm7wm0IFAZQRVa9ueO+iEO1R5RYM
 UN80igkoLU29UerZsLgRBD+q3mB1jYdRNh4A+A88BuKyKff/0CeHGdsZjxcbN0rsucmSDps0
 UWG9+4FHhQ27ufTEyjEsO7J83XiYkD5MFPuewc0TRcI89jsmLsS0C+eEtJFPrykt8/MTGSYL
 y+xkAAygLAajMgu3qq9/Ezajz/EmqUlXjLZ9S2MATr7tlIRiJqNItXyswCCvKkowJOxFwHZ5
 BA5d96iAPfi5H1nvBeGR/kRB/mX7vKBPSy0bbVHTsR5qWrFF5JOe+ltDNBCyKVBbplsldzBO
 ha7VeZtCHl7ZybCgUhfOdPZNijS5fK8fekJr9iNBja0XrB/dRWc4AZlblOK0mbmnSAEyP9kZ
 c7GKZjzXChEUcyLKQZaoc9GjNfHIQhklAvuqW3TlUz7gdJymlbEIVv6DLd+Rr9gt/7VyOkk2
 91eK9GL231ivB7WOUHqHXooBQlSdxATXMmuw+QOL7LrClc2SQkJVq6KqZt8KtMNokigvrqRl
 p1LchQDkwSXaLyuAVjiV02Pn5u0Bs8k9yhlbXJ8VbtqslB6CbuSAG4kX8NfVdEaGCZLl5aYl
 tEJJJeNBOphUDPC92hPZJXxttU6Jh+qmRiPL2yuZz1mJ8xsQAnA+9nFeArz9XZRUnrr5JVm+
 7DwhBnGRZcjRhh5CJqEYvyY0F7s72MWn/h/XhWUL4ALKlns6oVjNwf4kuQzf5MXMRzGyzbDj
 1SWDB4UqPPjuYgw9NWV16mIo53wS7l1H1ZAHnmd5rGzbHGI8m2myI5GceCJYTGCCz+kpPT8P
 b1YlqiuPucGkVBGt5tHP4xqla9utcHyo7J6zxh/GCmZZVqcFb49cGKN2tNCt/MRy+YB6xe2Q
 E+G5vJTJa6NZJH+CFcUKQcoMraD2PUTlmWA5Pg5Ohyntip+/b7BWkROJRiczidaKeItYo8ix
 O4gvu8Q6hC+1UV2YorX0HgM+jTeNGEEXoUmqooeUd3ihQccw11fZYDRV33t65aVZtQQakQnL
 1d4XkYZa2iwEqYaT0cOKA==
IronPort-HdrOrdr: A9a23:QBmQuK1KeGS8Mh7WPxni0QqjBL4kLtp133Aq2lEZdPUCSL39qy
 ncppUmPH7P5wr5N0tNpTntAsO9qDbnhP1ICOoqVotKPjOHhILAFugL0WKh+UyDJ8SUzJ856U
 4PScVD4JSbNzZHsfo=
X-IronPort-AV: E=Sophos;i="5.85,372,1624334400"; 
   d="scan'208";a="55178428"
Date: Thu, 14 Oct 2021 14:56:58 +0100
From: Anthony PERARD <anthony.perard@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, George Dunlap
	<george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>, Julien Grall
	<julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>, Wei Liu
	<wl@xen.org>, Roger Pau =?iso-8859-1?Q?Monn=E9?= <roger.pau@citrix.com>,
	<xen-devel@lists.xenproject.org>
Subject: Re: [XEN PATCH v7 27/51] build: introduce if_changed_deps
Message-ID: <YWg3KuoqXBuSHoxz@perard>
References: <20210824105038.1257926-1-anthony.perard@citrix.com>
 <20210824105038.1257926-28-anthony.perard@citrix.com>
 <4a1fc8b7-b915-2092-19bd-89a58cf3f232@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <4a1fc8b7-b915-2092-19bd-89a58cf3f232@suse.com>

On Mon, Oct 11, 2021 at 04:20:36PM +0200, Jan Beulich wrote:
> On 24.08.2021 12:50, Anthony PERARD wrote:
> > @@ -400,7 +407,7 @@ $(TARGET).gz: $(TARGET)
> >  	gzip -n -f -9 < $< > $@.new
> >  	mv $@.new $@
> >  
> > -$(TARGET): FORCE
> > +$(TARGET): tools_fixdep FORCE
> >  	$(MAKE) -C tools
> 
> Shouldn't this include building fixdep, in which case the extra dependency
> here is unnecessary? I can see that it's needed ...

Indeed, we don't really needs "tools_fixdep" prerequisite because the
first command of the recipe is going to build fixdep.

Thanks,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Thu Oct 14 14:01:21 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Oct 2021 14:01:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.209386.365824 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mb1IM-0006cS-6T; Thu, 14 Oct 2021 14:01:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 209386.365824; Thu, 14 Oct 2021 14:01:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mb1IM-0006cL-3d; Thu, 14 Oct 2021 14:01:18 +0000
Received: by outflank-mailman (input) for mailman id 209386;
 Thu, 14 Oct 2021 14:01:16 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mb1IK-0006cB-Mz; Thu, 14 Oct 2021 14:01:16 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mb1IK-0001ZD-JX; Thu, 14 Oct 2021 14:01:16 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mb1IK-0000Zn-Ap; Thu, 14 Oct 2021 14:01:16 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mb1IK-0003bY-AO; Thu, 14 Oct 2021 14:01:16 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=ExoEom13uB6IqznPI6z/XcO0A4ek/CEMvXOJrh5uRNA=; b=4GaxFrZw93bVb9vRubb60nw58P
	+t/AoMq4a4uCfn5ghODn572UCN4Ms8zaCY09SI0guFQd2de0EMEngz3aEPFXi2CP+kPB6LBysdoG4
	AKLHqS03RkLqRQ5BFsqQBbN0fJ73CF+bBUML2eey5lGO18R4xvmYm/JNYWPzzHwBqJ9E=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165507-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 165507: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=2f5f0a1b77161993c16c4cc243467d75e5b7633b
X-Osstest-Versions-That:
    xen=4cfab4425d39f76660b4e76ba6ee4cbf0f92e7e5
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 14 Oct 2021 14:01:16 +0000

flight 165507 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165507/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  2f5f0a1b77161993c16c4cc243467d75e5b7633b
baseline version:
 xen                  4cfab4425d39f76660b4e76ba6ee4cbf0f92e7e5

Last test of basis   165501  2021-10-13 23:01:33 Z    0 days
Testing same since   165507  2021-10-14 11:01:35 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Anthony PERARD <anthony.perard@citrix.com>
  Christian Lindig <christian.lindig@citrix.com<mailto:christian.lindig@citrix.com>>
  Jan Beulich <jbeulich@suse.com>
  Julien Grall <jgrall@amazon.com>
  Michal Orzel <michal.orzel@arm.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   4cfab4425d..2f5f0a1b77  2f5f0a1b77161993c16c4cc243467d75e5b7633b -> smoke


From xen-devel-bounces@lists.xenproject.org Thu Oct 14 14:10:35 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Oct 2021 14:10:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.209394.365839 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mb1R7-00083U-3G; Thu, 14 Oct 2021 14:10:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 209394.365839; Thu, 14 Oct 2021 14:10:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mb1R6-00083N-WF; Thu, 14 Oct 2021 14:10:21 +0000
Received: by outflank-mailman (input) for mailman id 209394;
 Thu, 14 Oct 2021 14:10:20 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Xl23=PC=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mb1R6-00083H-6t
 for xen-devel@lists.xenproject.org; Thu, 14 Oct 2021 14:10:20 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 8c551044-d61f-443a-a5d4-d496519f6eb8;
 Thu, 14 Oct 2021 14:10:19 +0000 (UTC)
Received: from EUR02-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur02lp2053.outbound.protection.outlook.com [104.47.6.53]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-27-l7kgciG_MCC3Vs_32HQfxA-1; Thu, 14 Oct 2021 16:10:16 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB5742.eurprd04.prod.outlook.com (2603:10a6:803:e5::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.19; Thu, 14 Oct
 2021 14:10:15 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.016; Thu, 14 Oct 2021
 14:10:15 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM7PR03CA0009.eurprd03.prod.outlook.com (2603:10a6:20b:130::19) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.14 via Frontend
 Transport; Thu, 14 Oct 2021 14:10:14 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8c551044-d61f-443a-a5d4-d496519f6eb8
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634220618;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=4l639VDLbiZkVv389eesn61ZpL3id56pUiOhfW4T4v4=;
	b=NTlfm+lxjMNkv386et568NVVmO+W5cPGLWzlpjJZOSLDGmHf0NAtpRAKc+GocL+H+vw5EB
	T3RuACegk1UXoTZaFya56HdPTkZceeqNM3/CVBM4fTFkqMgIoKIte3swC5tww0AMFE9HhP
	PhDbpbMvQf6+AGfOO0U8O6EGCfBLYg0=
X-MC-Unique: l7kgciG_MCC3Vs_32HQfxA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=lSv9SyuBD+OwAlmKzXngWWg1VtrOHGucRaNfV5s6BYmsws4yeMrkY2Rt1Xqc4ThVD0ok5bxRdXH85dBiYclInalZHL5H6xzmfqENzT9hPv1LrW57k//d5ntnU7IpIIFra62a1YjpFXZ9R6B2WA91DihyyGa3fXthXtQK50mBWWLQhb8sIfvBdzaAKuhJ3lUH4el1xS8ZJWj7HCJdqhWc+2gQcXX6Sxo27zogpnLm8VcQnzxrZN4Lk8+rGSw3N1qgDCR1Z5/Qf5Hj6uO7oA5kB1ujpcWOttt4zKZIdvU9+v0+Olyq/DpIrz9TLiXCw4YoJbq+0oETYAi+CwETtxi1Ww==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=4l639VDLbiZkVv389eesn61ZpL3id56pUiOhfW4T4v4=;
 b=elvNPAnR8ZVdQpd1rrdHAxUW/U/bAzVbvIQ0icfUc/WBFNcdRZE82BvV4yDMDw7kcvAyMkkmQfRXNQP/ScRx3mlBHXk87uElH8BSiFbAURQo0sjiuHB8A/OG5U5vVPx9mYfx4AX0eojB3igXRPtX0ORqV7OVy83bKGhP+wNCYIElQTYCued4XLB6goLS8AMqoCtqAnRTS0Ch+5r1uRapyYUqFDtaLoRew75/nWJu0e19HBLmPCtO7y2TRmF1GF9i0vE/mX+Y5wNYeBDkfmzyYmBWvZ6VoEw4qRVgaNbJnZn0bdUzFHc5xWJYWoCgW9Sk6HTKOevA9ztcQd1ZQ7SCow==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [PATCH 2/2] memory: XENMEM_add_to_physmap (almost) wrapping
 checks
To: Julien Grall <julien@xen.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <4f54456b-e8da-f67f-b6a0-b5ce2cf12cae@suse.com>
 <f78f8a30-39b7-cec2-2af0-27ebab28cedd@suse.com>
 <561dcb90-7b6d-4dd6-2ca7-a4a5ec1c5e35@xen.org>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <5e829583-d593-3b19-ea54-acb31ee8eec9@suse.com>
Date: Thu, 14 Oct 2021 16:10:12 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <561dcb90-7b6d-4dd6-2ca7-a4a5ec1c5e35@xen.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM7PR03CA0009.eurprd03.prod.outlook.com
 (2603:10a6:20b:130::19) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 106193ee-e61a-438b-1ad9-08d98f1c580b
X-MS-TrafficTypeDiagnostic: VI1PR04MB5742:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB57420A73E277DEF8E6B17F2DB3B89@VI1PR04MB5742.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	ARquG3QGZPHksLb+wD0RKnaVIwFvVvkUggLn2gyv2Wh9wWcwNt4ZZ0pgMYltOwC3/N41s1+iQg3ghmqFaVx54r3G4H6fg7OMHKC128ygzUtLjgjmBVaFbwkAKiSJu2lpvpuWB7B2d9DAvYt+rKG4c8hbFvokdfFm5sVP+Zyaj5fXly1vNcS2cP/3qLo1p/X/1j2UDhth2SOo0Ido+V/Y03q7VdfZMfzWBgnnI3eTC34TwUeU60rukRlfb6DYCrmwXHvjVXYkT9SO4iqkbbUJuQd0QaaHwJ00Syf0MD6g2xBWpbFkeasaxyz/F+H5tmI1gY0d9+mNC01jKz37CEKXcRcH8js9Wz9sdBRWEhM3LawnKeJOlmFzezr0JfoTCr2vFwmEPYsBTKRChnE5nyQ+aAxQAY645r8w1PCUljyO6ZVNb22VVxFIRgApuo82m2mnqwEGz0iE8GMHdOrE+bh0CAzKQsSZsZv24sTleFJjYmZZk25kz/ZD9Uqf2jb6gcZ0wsa1XdsIHIzZuRXfOpJ5WHn3NpIf3Kwpnha2Txf6gsaLFQIptEJXKmOpNrFyQih7gT1hkFStcf6ukl2JV1ngh48/tm9kzEkhPYbqOrP0VEPDZzkO/2A+0QGT+lbEqhmzSUMYKPKpe8+q8VPrDjRbgkiakpcD+wT/ZsIRppMe8UYtOEBMd9HSD89A9BbGHGmz0OBBTTbjaZZN2SHIfdpAJBaoiGKjV/LdoE8KfRYXmCXBTb6IyRg13SQ02quF7OWZ
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(316002)(8676002)(186003)(31686004)(8936002)(16576012)(83380400001)(86362001)(6486002)(26005)(53546011)(36756003)(5660300002)(4326008)(31696002)(508600001)(38100700002)(66476007)(66556008)(66946007)(54906003)(2906002)(6916009)(956004)(2616005)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?UVFFNEVLMmgxVjdlTmo3Ynl0QW5yQzBRV3hwaUh3d3hTYXVRcld1d3lHbThQ?=
 =?utf-8?B?TmhKdDFmMWJGV1c3Y1p1bkltMGl0eDVoS3BYTG92RFAxWGZESXo0eXpLTWZR?=
 =?utf-8?B?KzBkQVR1Ni9RSEpCeCtBeVlEdTJGc3RYS1AwNU5OWUU0UzNjMVlWemJ6b1pL?=
 =?utf-8?B?Y1kxendIZElIckdiUitEODhXNkFSYTFXL2thZVY0aXdHSE9lUzVRcnlZcktO?=
 =?utf-8?B?djJYY0tVSHlWbmtzQ2NPcjhQRjVGMnJ0M0VIaEFDdCtTUUxOOGhOaTJQMVdI?=
 =?utf-8?B?VFE3RTJURVhjdFo3OWp1NWhPR2lTdVQwdjFOOWdycCt5bnNVaTg5ZGxwYktr?=
 =?utf-8?B?ME5jRlZBQzh4ZUVIdnJDTS9rV09BNjhNNWZBZW5TdTFwc0RaaXpiWVdrSHYw?=
 =?utf-8?B?aEFlSVM0bXJNeGdISlppeU9ObU16bTlWSlV1cW9OdTF6bjhNK1QvUEZsWGZB?=
 =?utf-8?B?Z0gwelJQWDFGYThiQ2lVQjU2My9lNEUvc2t4THdURGNKZ0VxdGQxV29SQ0xN?=
 =?utf-8?B?VjluQ2QvWHg3ZWxYaVk3QUVEempSUVZ1Ry9iNWQ4UFhKaG83czl4QXF2T1gw?=
 =?utf-8?B?SC85azk3SGlDWG04TlRFUkVPWXhuRkdvRUhDNjZrL0JMeWlNZnN1VW83U0ph?=
 =?utf-8?B?Z09oNklVNVhISHdWLy9Ra2FJVDJZS0xNeXlkSW1LZ1hlSGI2cll5M3AzU1lu?=
 =?utf-8?B?NmwzNUNVbkhycm1aRzRuYzAya1pLM3pWNFpSbFMvbEQyOXhpb3g4eVBVQTR6?=
 =?utf-8?B?T1l4dk8zZnNwNWNrZHliekZyZVZEREhMYzFWQ3FrTnhUcXZoblVJa3RzU3JP?=
 =?utf-8?B?cUl2andmVlRtVDdsbU9BVlNqZkNRM1V4eUNtWXJSUjFSR201MElxWnF0TC84?=
 =?utf-8?B?aTBQZWdtbjQrMmYyek95VDRGQS9JU1dISlNnd2tKNzBKYXhrV3pJOWg2cmFL?=
 =?utf-8?B?QnVsQ0FMbmRSV1dzNVJGTUkrN1o0dzVwdE9PcmU2TGhzZkpaTWk3M1Y2L1lo?=
 =?utf-8?B?aEtCYXlIdTJhU05VRFNnMm95SmJtZ1BDMDlWSlF3bEl3YnY3cHdFWXd3N016?=
 =?utf-8?B?VnBSTnlLQ0hOYzErdVdhR0wzRmt3SnkwMERmL29seWdXU3krQ2RMa0tYdHJ3?=
 =?utf-8?B?dnd2SGREL0prdG15d2tWMlh1RWNzYkZqT0MzVCs0Q0lZaEpQMWtrS2lMbHBr?=
 =?utf-8?B?eFlVWXd5RFptWEt0TitlZGFyVTlwWjNjMUh0YWdtaGxQWk1OTjFpdlROU1l6?=
 =?utf-8?B?REFlSjN2T2pQVXNjYS9qZ3FiVFdPc3pQRjV6VkZFa2FIclJoZk9yY3hqMkNt?=
 =?utf-8?B?UlR1dkpyRndYelBRcEtQa3hiaTN0L2tCeGxoQ2RoNVdKU3hDcVp2TUhGWXNX?=
 =?utf-8?B?eUo1dEVtelRCY1pDeTY5MGJUSnhKSU5xSEMvblp4eUp0c1hURFZkbDNrVGpZ?=
 =?utf-8?B?ODVFRjJHZVdrR1JsMjRuMGlPRGR4VEkxNjZ0KzJNSmdWTWQxTUpDQTFVcTI2?=
 =?utf-8?B?MTVJdU15cUtUVXlVZEhyd1Z3NFQraldGSDN1dnB2N0F1WXRnTDdZdUdKVEdB?=
 =?utf-8?B?d0UxZ0c2U1d6NWZOdnRiMTZLOWpka3RJWmVOV09ZUm5qamZLZW82WE8yTERr?=
 =?utf-8?B?WkdFeTROdm1rR1lwTWY2dGFOY0w1NitCUnlUVkhrcVZyaS9hOHlwTHl4NlpI?=
 =?utf-8?B?VHR1bHlNRjlFb3Q2L2pFNUhjK09nejg0SkdBSlhnZWVqZ1puR2FiRFYyaVov?=
 =?utf-8?Q?XClGeEb2P1YxFqTpQEJ7edp9p8hRvi+S70Bs1K+?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 106193ee-e61a-438b-1ad9-08d98f1c580b
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2021 14:10:14.9954
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ZPT6cnPYjY21EqYGQiRvgrJosvqZuVqyZ4SJDPjBoQ0KRAMRMqARA1tKuXrEvpjk2OWfV3kuJEib3ddaf0tlXQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5742

On 14.10.2021 13:29, Julien Grall wrote:
> On 13/09/2021 07:42, Jan Beulich wrote:
>> Determining that behavior is correct (i.e. results in failure) for a
>> passed in GFN equaling INVALID_GFN is non-trivial. Make this quite a
>> bit more obvious by checking input in generic code - both for singular
>> requests to not match the value and for range ones to not pass / wrap
>> through it.
>>
>> For Arm similarly make more obvious that no wrapping of MFNs passed
>> for XENMAPSPACE_dev_mmio and thus to map_dev_mmio_region() can occur:
>> Drop the "nr" parameter of the function to avoid future callers
>> appearing which might not themselves check for wrapping. Otherwise
>> the respective ASSERT() in rangeset_contains_range() could trigger.
>>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>> ---
>> I find it odd that map_dev_mmio_region() returns success upon
>> iomem_access_permitted() indicating failure - is this really intended?
> 
> AFAIR yes. The hypercall is not used as "Map the region" but instead 
> "Make sure the region is mapped if the IOMEM region is accessible".
> 
> It is necessary to return 0 because dom0 OS cannot distinguished between 
> emulated and non-emulated. So we may report error when there is none.

Odd, but I clearly don't understand all the aspects here.

>> As per commit 102984bb1987 introducing it this also was added for ACPI
>> only - any reason XENMAPSPACE_dev_mmio isn't restricted to CONFIG_ACPI
>> builds?
> 
> There is nothing specific to ACPI in the implementation. So I don't 
> really see the reason to restrict to CONFIG_ACPI.
> 
> However, it is still possible to boot using DT when Xen is built with 
> CONFIG_ACPI. So if the restriction was desirable, then I think it should 
> be using !acpi_disabled.

My point was rather about this potentially being dead code in non-ACPI
builds (i.e. in particular uniformly on 32-bit).

>> @@ -841,6 +844,15 @@ int xenmem_add_to_physmap(struct domain
>>       if ( xatp->size < start )
>>           return -EILSEQ;
>>   
>> +    if ( xatp->gpfn + xatp->size < xatp->gpfn ||
>> +         xatp->idx + xatp->size < xatp->idx )
>> +    {
>> +#define _gfn(x) (x)
> 
> AFAICT, _gfn() will already be defined. So some compiler may complain 
> because will be defined differently on debug build.

No - _gfn() is an inline function as per typesafe.h. (Or else it
wouldn't be just "some" compiler, but gcc at least would have
complained to me.)

> However...
> 
>> +        BUILD_BUG_ON(INVALID_GFN + 1);
> 
> ... I might be missing something... but why can't use gfn_x(INVALID_GFN) 
> + 1 here?

Because gfn_x() also is an inline function, and that's not suitable
for a compile-time constant expression.

> In fact, I am not entirely sure what's the purpose of this 
> BUILD_BUG_ON(). Could you give more details?

The expression in the surrounding if() relies on INVALID_GFN being the
largest representable value, i.e. this ensures that INVALID_GFN doesn't
sit anywhere in [xatp->gpfn, xatp->gpfn + xatp->size).

Jan



From xen-devel-bounces@lists.xenproject.org Thu Oct 14 14:19:29 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Oct 2021 14:19:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.209403.365849 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mb1Zr-0000JN-Vi; Thu, 14 Oct 2021 14:19:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 209403.365849; Thu, 14 Oct 2021 14:19:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mb1Zr-0000JG-St; Thu, 14 Oct 2021 14:19:23 +0000
Received: by outflank-mailman (input) for mailman id 209403;
 Thu, 14 Oct 2021 14:19:23 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=i4ou=PC=citrix.com=anthony.perard@srs-us1.protection.inumbo.net>)
 id 1mb1Zr-0000JA-9B
 for xen-devel@lists.xenproject.org; Thu, 14 Oct 2021 14:19:23 +0000
Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id b9bc168c-2cf9-11ec-81c4-12813bfff9fa;
 Thu, 14 Oct 2021 14:19:22 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b9bc168c-2cf9-11ec-81c4-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1634221161;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=r3pfHY/13FEq43u1gQO09W8tsI3hlUFY01vkjJETQjk=;
  b=HPCmYGux+CumDzjIxYf/iY+FEVPcOi2GZBgqQRhZXsxn9cjPsuwu08Dl
   mXFGKy5G0HFayUmb4O2zArG36sgKO8Fo0nPP/MBqVWCVbfMgZnDsXpNfW
   w0GTVPzYS+JZJQleA/41z23YgYv6Qz6Lq5PfjNgFyLJkqBTZlQPJuN6Ci
   8=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: bko/flN8xlLEW1VlFnKSOPjIuBt74HoOMoWHBST6ItBMu7xwaqQvaDrwmCKuIIRccDuc85H4A1
 3qRjmFjiZyaGJTrIENcbadb554eDWFxlIVJ+dL1a/Q4/jTfOkkeF9GvK0P7qh5PIuBB5n8NOlQ
 YSShk1hLAnWPaLtdWfMr+c3Kqx+PJ0dLh0TtWBYyeK6UNnob6t61Dhvjqw8KHnc/HLXKr7IFB3
 +SH4CBHI0SP3Gd7nL8IES0HQ6iL91TABWMDM7k8g2bUeAvTFCqG8BWFA0krWEMIo4sxDotZ8Gy
 czKjdxHZZXRF0yF+4LP8vpg6
X-SBRS: 5.1
X-MesageID: 55182001
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:0DMFK6x0+HJKvmOmCBV6t+e6wSrEfRIJ4+MujC+fZmUNrF6WrkUOm
 zQfUGyBPPqJYWL3KIglYNy3/EsP7JPRmtJiGgI+rCAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx
 59DAjUVBJlsFhcwnvopW1TYhSEUOZugH9IQM8aZfHAsLeNYYH1500s6w7dl2tcAbeWRWGthh
 /uj+6UzB3f9s9JEGjp8B3Wr8U4HUFza4Vv0j3RmDRx5lAa2e0o9VfrzEZqZPXrgKrS4K8bhL
 wr1IBNVyUuCl/slIovNfr8W6STmSJaKVeSFoiI+t6RPHnGuD8H9u0o2HKN0VKtZt9mGt8l1y
 pZIkZmRcBkkHqDQu6NASxMHTj4raMWq+JefSZS+mcmazkmAeHrw2fR+SkoxOOX0+M4uXzsIr
 6ZBbmlQMFbT3Ipaw5riIgVors0lMMnsOpJZonx6xCvVJf0nXYrCU+PB4towMDIY250XTayGP
 5NxhTxHMCmfbi10Hk4uDrExlealhHWjLyNakQfAzUYwyzeKl1EguFT3C/LOYcCDT8hRmkeep
 0rF8n7/DxVcM8aQoRKa9lq8i+mJmjn0MKoCGbv9+vN0jVm7wm0IFAZQRVa9ueO+iEO1R5RYM
 UN80igkoLU29UerZsLgRBD+q3mB1jYdRNh4A+A88BuKyKff/0CeHGdsZjxcbN0rsucmSDps0
 UWG9+4FHhQ27ufTEyjEsO7J83XiYkD5MFPuewcdSQlG5v3mgbgtgzLCUvUkTba/0YDqTGSYL
 y+xkAAygLAajMgu3qq9/Ezajz/EmqUlXjLZ9S2MATr7tlIRiJqNItXyswCCvKkowJOxFwHZ5
 BA5d96iAPfi5H1nvBeGR/kRB/mX7vKBPSy0bbVHTsR5qWrFF5JOe+ltDNBCyKVBbplsldzBO
 ha7VeZtCHl7ZybCgUhfOdPZNijS5fK8fekJr9iNBja0XrB/dRWc4AZlblOK0mbmnSAEyP9kZ
 c7GKZjzXChEUcyLKQZaoc9GjNfHIQhklAvuqW3TlUz7gdJymlbEIVv6DLd+Rr9gt/7VyOkk2
 91eK9GL231ivB7WOUHqHXooBQlSdxATXMmuw+QOL7LrClc2SQkJVq6KqZt8KtMNokigvrqRl
 p1LchQDkwSXaLyuAVjiV02Pn5u0Bs8k9yhlbXJ8VbtqslB6CbuSAG4kX8NfVdEaGCZLlpaYl
 tEJJJeNBOphUDPC92hPZJXxttU6Jh+qmRiPL2yuZz1mJ8xsQAnA+9nFeArz9XZRUnrr5JVm+
 7DwhBnGRZcjRhh5CJqEYvyY0F7s72MWn/h/XhWUL4ALKlns6oVjNwf4kuQzf5MXMRzGyzbDj
 1SWDB4UqPPjuYgw9NWV16mIo53wS7l1H1ZAHnmd5rGzbHGI8m2myI5GceCJYTGCCz+kpPT8P
 b1YlqiuPucGkVBGt5tHP4xqla9utcHyo7J6zxh/GCmZZVqcFb49cGKN2tNCt/MRy+YB6xe2Q
 E+G5vJTJa6NZJH+CFcUKQcoMraD2PUTlmWA5Pg5Ohyntip+/b7BWkROJRiczidaKeItYo8ix
 O4gvu8Q6hC+1UV2YorX0HgM+jTeNGEEXoUmqooeUd3ihQccw11fZYDRV33t65aVZtQQakQnL
 1d4XkYZa2iwEqYaT0cOKA==
IronPort-HdrOrdr: A9a23:xwOlGKn8hg/e8nZvorJZdIZ8wCDpDfIs3DAbv31ZSRFFG/Fxl6
 iV8sjz8SWE7Ar5OUtQ/OxoV5PsfZqxz/JICMwqTNCftWrdyQmVxeNZjbcKqgeIc0aVygce79
 YCT0EXMqyXMbEQt6fHCWeDfOod/A==
X-IronPort-AV: E=Sophos;i="5.85,372,1624334400"; 
   d="scan'208";a="55182001"
Date: Thu, 14 Oct 2021 15:18:50 +0100
From: Anthony PERARD <anthony.perard@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, George Dunlap
	<george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>, Julien Grall
	<julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>, Wei Liu
	<wl@xen.org>, <xen-devel@lists.xenproject.org>
Subject: Re: [XEN PATCH v7 32/51] build: Remove KBUILD_ specific from
 Makefile.host
Message-ID: <YWg8Stdk2sybDuf4@perard>
References: <20210824105038.1257926-1-anthony.perard@citrix.com>
 <20210824105038.1257926-33-anthony.perard@citrix.com>
 <d61fa6ad-6a05-6ad4-4ce0-711b55e0827c@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <d61fa6ad-6a05-6ad4-4ce0-711b55e0827c@suse.com>

On Mon, Oct 11, 2021 at 05:47:29PM +0200, Jan Beulich wrote:
> On 24.08.2021 12:50, Anthony PERARD wrote:
> > This will allow $(HOSTCFLAGS) to actually be used when building
> > programmes for the build-host.
> > 
> > The other variable don't exist in our build system.
> > 
> > Also remove $(KBUILD_EXTMOD) since it should always be empty.
> > 
> > Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
> 
> Acked-by: Jan Beulich <jbeulich@suse.com>
> 
> I wonder though whether their use of KBUILD_ prefixes doesn't match
> our XEN_ ones (e.g. KBUILD_CFLAGS vs XEN_CFLAGS), in which case
> replacing rather than stripping might be the way to go.

Well, at the moment, HOSTCFLAGS is defined in Config.mk, and xen/ makes
use of it. I don't think the other variable that I strip KBUILD_ from
exist, so maybe for those, changing prefix for XEN_ would be fine.
But for HOSTCFLAGS, I think we would want a new patch to set it in
xen/Makefile, and use it in xen/. But I don't think we need to spend
time on it at the moment.

Thanks,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Thu Oct 14 14:21:09 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Oct 2021 14:21:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.209411.365861 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mb1bY-0001fK-BE; Thu, 14 Oct 2021 14:21:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 209411.365861; Thu, 14 Oct 2021 14:21:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mb1bY-0001fD-7e; Thu, 14 Oct 2021 14:21:08 +0000
Received: by outflank-mailman (input) for mailman id 209411;
 Thu, 14 Oct 2021 14:21:06 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=i4ou=PC=citrix.com=anthony.perard@srs-us1.protection.inumbo.net>)
 id 1mb1bW-0001f7-Td
 for xen-devel@lists.xenproject.org; Thu, 14 Oct 2021 14:21:06 +0000
Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id c5970070-cf64-4e81-9acd-b0c171b3d50b;
 Thu, 14 Oct 2021 14:21:06 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c5970070-cf64-4e81-9acd-b0c171b3d50b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1634221265;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=09b5qrfjwDGI2WO4AfAp6k6QZvt7V4OgG/lmt7+2qp4=;
  b=QnG40JIHEeY2f4fiyLFircXM1dAyi7d9pHrknG2RIH//LRuEHe7zXEyw
   GIaRYP28u5HvixlCxldw5mk5Czo9naJ7duFJLFB49jTKnXl0NAVi4/Vca
   OINnsq0t8UjMOh1ha3fTYX+AzR/tve6DJ+BxgTvVPjthFpv8hFSQB/hBQ
   Y=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: JuCsNfQigaac7Ooa7EsQVDGFZZyOl7hjqppRoLa2KHzvlntuld6XO8bHduNNCY/qLrIUDeQ1/L
 Mi50rwlqfygvVr8lHwPhsfYf2jheTDX5mjCuXp+MgKE4gtRgsciZYtWOpkst275M3V88RqM7V9
 8CatogefCoNJAZunck3YGEIXmzPa5uVTa8g0guCaM1//D1AvxqLWxhOAjmzrQ10Ob09nN4GJOC
 6VCN3+jKyJVNWEggy5N54P+weOjThQ2UuaoLMxngupXGuiHQ5kdkZKbeuSrwSXasLwXlh45Fq0
 eFxIaTwMjOqWhMSv2/FSzdum
X-SBRS: 5.1
X-MesageID: 54761289
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:QKECFqI1DX+huBYTFE+RGJIlxSXFcZb7ZxGr2PjKsXjdYENS0TYHm
 GcfCjjXO6mLamD1c4pxPYm3oEgEsJKBytUyQFZlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s
 q3yv/GZdJhcokcxIn5BC5C5xZVG/fjgqoHUVaiUZ0ideSc+EH140Eo6x7Zg6mJVqYPR7z2l6
 IuaT/L3YDdJ6xYsWo7Dw/vewP/HlK2aVAIw5jTSV9gS1LPtvyB94KYkDbOwNxPFrrx8RYZWc
 QphIIaRpQs19z91Yj+sfy2SnkciGtY+NiDW4pZatjTLbrGvaUXe345iXMfwZ3u7hB3Ur98g4
 +oU9qCCYiAgYqidtrQTDghHRnQW0a1uoNcrIFC6uM2XiUbHb2Ht07NlC0Re0Y8wo7gtRzsUr
 LpBdW5LPkvra+GemdpXTsFlgNgjK8/6epsSoHh6wRnSDOo8QICFSKLPjTNd9Gps2Z4XR6aPD
 yYfQT4xUBXfUz4MAFkGIq04uLuZxVSubAQN/Tp5ooJoujOOnWSdyoPFINfTP9CHW8hRtkKZv
 X7duXT0BAkAM96SwibD9Wij7sfQmQvrVYRUE6e3ntZoilCOwm0YCDUNSEC25/K+jyaDt8l3c
 hJOvHB09O5rqRLtHoKVswCETGCs4y4TCvFvSq4G2iqqw/bRsijJCDUVUWsUADA5j/MeSTsv3
 16PutrmAz1zrbGYIU6gGqeoQSCaYndNczdTDcMQZU5cuYO7+dBs5v7aZo87SPbdszHjJd3nL
 9lmRgAFjLIPkdVD6ay/+V3W695HjsmUFlBrjuk7s2TM0++YWGJHT9D3gbQ4xawZRGp8crVnl
 CNZ8yR5xLpfZaxhbATXHI0w8EiBvp5pygH0j191BIUG/D+w4XOldo04yGggfxswb55aJm63P
 he7VeZtCHl7ZybCgUhfOdPZNijX5fK4SYSNug78P7KinaSdhCfYpXozNCZ8LkjmkVQ2kLFXB
 HtoWZ3EMJruMow+lGDeb75EidcDn3lirUuOFcGT50n2itK2OS/KIYrpxXPTN4jVGovf+16Lm
 zueXuPXoyhivBrWOXKOqtRJcwBUfRDWx/ne8qRqSwJKGSI+cElJNhMb6e9Jl1VNk/sHm+HW0
 Gu6X0MEmlPziWeecVeBa2x5aaOpVpF69CppMSspNFeu+n4ifYfws/tPK8ppJeEqpL550Pp5b
 /gZYMHcUP5BfSvKpmYGZp7noY08KBny3VCSPzCoaSQUdoJ7Q1Cb4cftewbirXFcDie+ucYkj
 aen0wfXHcgKSwh4VZ6EY/Oz1VKh+3ManbsqDUfPJ9BSfmTq8ZRrdHOt3qNmfZlUJEyalDWA1
 guQDRMJnsX3otc4oIvTmKSJj4a1CO8iTEBUKHbWsOStPi7A82v9nYIZCLSUfSrQXX/f8bm5Y
 bkH1On1NfAKkQoYs4d4FLo3n6sy68G2+u1fxwVgWn7Kc06qGvVrJXzfhZtDsahEx7l4vwqqW
 x3QpokGaOvRYM61QkQMIAcFb/iY0aBGkzbf2v05PUHm6XIl57GAS0hTY0GBhSE1wGGZ62/5L
 TPNYPIr1jE=
IronPort-HdrOrdr: A9a23:VzW046kLs6+SEeDj5w6m3JqHVHHpDfIo3DAbv31ZSRFFG/Fw8P
 re+8jztCWE7Ar5PUtKpTnuAsW9qB/nmqKdgrNwAV7BZmfbUQKTRekJgLcKqAeAJwTOssJbyK
 d8Y+xfJbTLfD1HZB/BkWqF+gAbsbu6zJw=
X-IronPort-AV: E=Sophos;i="5.85,372,1624334400"; 
   d="scan'208";a="54761289"
Date: Thu, 14 Oct 2021 15:20:35 +0100
From: Anthony PERARD <anthony.perard@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Roger Pau
 =?iso-8859-1?Q?Monn=E9?= <roger.pau@citrix.com>, Wei Liu <wl@xen.org>,
	<xen-devel@lists.xenproject.org>
Subject: Re: [XEN PATCH v7 38/51] build: use main rune to build host binary
 x86's mkelf32 and mkreloc
Message-ID: <YWg8s3e1WiR5QuQN@perard>
References: <20210824105038.1257926-1-anthony.perard@citrix.com>
 <20210824105038.1257926-39-anthony.perard@citrix.com>
 <e2d9d545-4529-fe1d-652d-8f8828838452@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <e2d9d545-4529-fe1d-652d-8f8828838452@suse.com>

On Mon, Oct 11, 2021 at 05:56:06PM +0200, Jan Beulich wrote:
> On 24.08.2021 12:50, Anthony PERARD wrote:
> > Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
> 
> Acked-by: Jan Beulich <jbeulich@suse.com>
> 
> > --- a/xen/arch/x86/Makefile
> > +++ b/xen/arch/x86/Makefile
> > @@ -81,6 +81,10 @@ endif
> >  extra-y += asm-macros.i
> >  extra-y += xen.lds
> >  
> > +hostprogs-y += boot/mkelf32
> > +HOSTCFLAGS_efi/mkreloc.o := -g
> 
> To be honest I don't think this extra option would have been necessary
> to retain.

Probably not, I'll remove it.

Thanks,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Thu Oct 14 14:28:17 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Oct 2021 14:28:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.209421.365872 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mb1iO-0002Pb-8e; Thu, 14 Oct 2021 14:28:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 209421.365872; Thu, 14 Oct 2021 14:28:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mb1iO-0002PU-53; Thu, 14 Oct 2021 14:28:12 +0000
Received: by outflank-mailman (input) for mailman id 209421;
 Thu, 14 Oct 2021 14:28:10 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mb1iM-0002PN-TB
 for xen-devel@lists.xenproject.org; Thu, 14 Oct 2021 14:28:10 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mb1iM-000206-L5
 for xen-devel@lists.xenproject.org; Thu, 14 Oct 2021 14:28:10 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mb1iM-0004Vo-JQ
 for xen-devel@lists.xenproject.org; Thu, 14 Oct 2021 14:28:10 +0000
Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89)
 (envelope-from <iwj@xenproject.org>)
 id 1mb1iJ-0002jr-C7; Thu, 14 Oct 2021 15:28:07 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date
	:Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From;
	bh=8csriymb1MT05IHAml9zw9rjJ21uAc5yaIKGUg4e2/I=; b=1aZ9hRRuAlAAGTYmlb/1sp/Y/o
	EVASouprwmFghfBWOcwYxyPBqgz4EVpftvITUlpV1qVrFRXWF/Kgv9EAEa5NbhdWuXh1VypvWmDpO
	BplaHTqSxPdxwdZrHNGyt7i8X9Pv6FkhI4kv2d2GdpGSnQ59npnfCUoFHlUOX7DK1zzU=;
From: Ian Jackson <iwj@xenproject.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <24936.15991.111241.918070@mariner.uk.xensource.com>
Date: Thu, 14 Oct 2021 15:28:07 +0100
To: Oleksandr Tyshchenko <olekstysh@gmail.com>
Cc: xen-devel@lists.xenproject.org,
    Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
    Ian Jackson <iwj@xenproject.org>,
    Wei Liu <wl@xen.org>,
    Anthony PERARD <anthony.perard@citrix.com>,
    Andrew Cooper <andrew.cooper3@citrix.com>,
    George Dunlap <george.dunlap@citrix.com>,
    Jan Beulich <jbeulich@suse.com>,
    Julien Grall <julien@xen.org>,
    Stefano Stabellini <sstabellini@kernel.org>,
    Juergen Gross <jgross@suse.com>,
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
    Roger Pau =?iso-8859-1?Q?Monn=E9?= <roger.pau@citrix.com>,
    Henry Wang <Henry.Wang@arm.com>,
    Bertrand Marquis <bertrand.marquis@arm.com>,
    Wei Chen <Wei.Chen@arm.com>
Subject: Re: [PATCH V7 0/2] Add handling of extended regions (safe ranges) on Arm (Was "xen/memory: Introduce a hypercall to provide unallocated space")
In-Reply-To: <1634211645-26912-1-git-send-email-olekstysh@gmail.com>
References: <1634211645-26912-1-git-send-email-olekstysh@gmail.com>
X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu)

Oleksandr Tyshchenko writes ("[PATCH V7 0/2] Add handling of extended regions (safe ranges) on Arm (Was "xen/memory: Introduce a hypercall to provide unallocated space")"):
> You can find an initial discussion at [1]-[7].
> 
> The extended region (safe range) is a region of guest physical address space
> which is unused and could be safely used to create grant/foreign mappings instead
> of wasting real RAM pages from the domain memory for establishing these mappings.

Thanks.

This patch has all the required acks, but I was aware of an
outstanding concern from Andrew, as set out in his most
recent mail on the subject:
  Subject: Re: [RFC PATCH 1/3] xen: Introduce "gpaddr_bits" field to XEN_SYSCTL_physinfo
  Date: Tue, 7 Sep 2021 18:35:47 +0100
  Message-ID: <973f5344-aa10-3ad6-ff02-ad5f358ad279@citrix.com>

I think it would be within the process to just commit the patch now,
but I thought it best to check as best I could that we weren't missing
anything.  The process is supposed to support our continuing
development and also our quality, so I aim to do those things.

I reviewed that mail and had a conversation with Julien about it on
irc.  My understanding is that Julien and Oleksandr's intent is that
Andrew's concerns have been addressed, although we don't have a
confirmation of that from Andrew.

In particular, I wanted to convince myself that if in fact there was
still a problem, we hadn't made a problem for ourselves with the API
here.

The new hypercalls are in unstable interfaces, so if we need to change
them in a future version (eg to make ARM migration work) that's OK.
Julien tells me that he doesn't believe there to be any impact on the
(x86) migration stream right now.

There is a new libxl stable interface.  But I think it is
inoffensive.  In particular, basically any mechanism to do this would
have that API.  And that doesn't seem to touch on the implementation
issues described by Andrew.

Therefore, I think (i) we have tried to address the issues (ii) any
reminaing problems can be dealt with as followups, without trouble.

So I have just pushed these two.

Thanks,
Ian.


From xen-devel-bounces@lists.xenproject.org Thu Oct 14 14:50:17 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Oct 2021 14:50:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.209433.365891 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mb23g-0005YR-5Q; Thu, 14 Oct 2021 14:50:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 209433.365891; Thu, 14 Oct 2021 14:50:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mb23g-0005YK-2G; Thu, 14 Oct 2021 14:50:12 +0000
Received: by outflank-mailman (input) for mailman id 209433;
 Thu, 14 Oct 2021 14:50:10 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=iCUr=PC=arm.com=bertrand.marquis@srs-us1.protection.inumbo.net>)
 id 1mb23e-0005YC-Ju
 for xen-devel@lists.xenproject.org; Thu, 14 Oct 2021 14:50:10 +0000
Received: from foss.arm.com (unknown [217.140.110.172])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTP
 id 5268b51a-28d4-418a-a4ee-cd0b07e9521b;
 Thu, 14 Oct 2021 14:50:09 +0000 (UTC)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C5889D6E;
 Thu, 14 Oct 2021 07:50:08 -0700 (PDT)
Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com
 [10.1.199.62])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 225A23F694;
 Thu, 14 Oct 2021 07:50:07 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5268b51a-28d4-418a-a4ee-cd0b07e9521b
From: Bertrand Marquis <bertrand.marquis@arm.com>
To: xen-devel@lists.xenproject.org
Cc: iwj@xenproject.org,
	Paul Durrant <paul@xen.org>,
	Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	Wei Liu <wl@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Anthony PERARD <anthony.perard@citrix.com>,
	Juergen Gross <jgross@suse.com>
Subject: [PATCH v6 0/3] PCI devices passthrough on Arm
Date: Thu, 14 Oct 2021 15:49:48 +0100
Message-Id: <cover.1634221830.git.bertrand.marquis@arm.com>
X-Mailer: git-send-email 2.25.1
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Hello All,

This serie is a follow up on Rahul serie where we included various fixes
required after review on the mailing list and a new patch to move some
of the x86 ecam related code to the common vpci code.

Most of the patches of the original serie have been merged and this
serie includes only 2 of the original patches reworked and 1 new patch:

Move some ECAM related functions from x86 to generic vpci
implementation:
- move vcpi mmcfg_{read/write} and vpci_access_allowed to common vpci.c.
- use ecam instead of mmcfg in common code.

Enable the existing x86 virtual PCI support for ARM:
- Add VPCI trap handler for each of the PCI device added for config
  space access.
- Register the trap handler in XEN for each of the host bridge PCI ECAM
  config space access.

Emulated PCI device tree node in libxl:
- Create a virtual PCI device tree node in libxl to enable the guest OS
  to discover the virtual PCI during guest boot.

The patch modifying xc_domain_ioport_permission has been removed from
the serie.

Bertrand Marquis (1):
  xen/vpci: Move ecam access functions to common code

Rahul Singh (2):
  xen/arm: Enable the existing x86 virtual PCI support for ARM.
  arm/libxl: Emulated PCI device tree node in libxl

 tools/libs/light/libxl_arm.c     | 105 +++++++++++++++++++++++++++++++
 tools/libs/light/libxl_types.idl |   1 +
 xen/arch/arm/Makefile            |   1 +
 xen/arch/arm/domain.c            |   4 ++
 xen/arch/arm/vpci.c              |  74 ++++++++++++++++++++++
 xen/arch/arm/vpci.h              |  36 +++++++++++
 xen/arch/x86/hvm/io.c            |  50 +++------------
 xen/drivers/passthrough/pci.c    |  18 +++++-
 xen/drivers/vpci/header.c        |   3 +-
 xen/drivers/vpci/vpci.c          |  60 ++++++++++++++++++
 xen/include/asm-arm/domain.h     |   1 +
 xen/include/asm-x86/pci.h        |   2 -
 xen/include/public/arch-arm.h    |  17 +++++
 xen/include/xen/pci.h            |   3 +
 xen/include/xen/vpci.h           |  10 +++
 15 files changed, 338 insertions(+), 47 deletions(-)
 create mode 100644 xen/arch/arm/vpci.c
 create mode 100644 xen/arch/arm/vpci.h

-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Thu Oct 14 14:50:17 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Oct 2021 14:50:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.209434.365902 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mb23l-0005pV-EY; Thu, 14 Oct 2021 14:50:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 209434.365902; Thu, 14 Oct 2021 14:50:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mb23l-0005pM-BM; Thu, 14 Oct 2021 14:50:17 +0000
Received: by outflank-mailman (input) for mailman id 209434;
 Thu, 14 Oct 2021 14:50:16 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=iCUr=PC=arm.com=bertrand.marquis@srs-us1.protection.inumbo.net>)
 id 1mb23k-0005ov-Ar
 for xen-devel@lists.xenproject.org; Thu, 14 Oct 2021 14:50:16 +0000
Received: from foss.arm.com (unknown [217.140.110.172])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTP
 id 8da1b29e-5231-433d-9283-254277e46922;
 Thu, 14 Oct 2021 14:50:15 +0000 (UTC)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 34787D6E;
 Thu, 14 Oct 2021 07:50:15 -0700 (PDT)
Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com
 [10.1.199.62])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 326763F694;
 Thu, 14 Oct 2021 07:50:14 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8da1b29e-5231-433d-9283-254277e46922
From: Bertrand Marquis <bertrand.marquis@arm.com>
To: xen-devel@lists.xenproject.org
Cc: iwj@xenproject.org,
	Paul Durrant <paul@xen.org>,
	Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	Wei Liu <wl@xen.org>
Subject: [PATCH v6 1/3] xen/vpci: Move ecam access functions to common code
Date: Thu, 14 Oct 2021 15:49:49 +0100
Message-Id: <ced6f870dbfabcfe8584555cc80f9a37a0655a0c.1634221830.git.bertrand.marquis@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <cover.1634221830.git.bertrand.marquis@arm.com>
References: <cover.1634221830.git.bertrand.marquis@arm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

PCI standard is using ECAM and not MCFG which is coming from ACPI[1].
Use ECAM/ecam instead of MCFG in common code and in new functions added
in common vpci code by this patch.

Rename vpci_access_allowed to vpci_ecam_access_allowed and move it
from arch/x86/hvm/io.c to drivers/vpci/vpci.c.

Create vpci_ecam_mmio_{read,write} in drivers/vpci/vpci.c that
contains the common code to perform these operations, changed
vpci_mmcfg_{read,write} accordingly to make use of these functions.

The vpci_ecam_mmio_{read,write} functions are returning 0 on error and 1
on success. As the x86 code was previously always returning X86EMUL_OKAY
the return code is ignored. A comment has been added in the code to show
that this is intentional.

Those functions will be used in a following patch inside by arm vpci
implementation.

Rename MMCFG_SBDF to ECAM_SBDF.

Not functional change intended with this patch.

[1] https://wiki.osdev.org/PCI_Express

Suggested-by: Roger Pau Monné <roger.pau@citrix.com>
Signed-off-by: Bertrand Marquis <bertrand.marquis@arm.com>
---
Changes in v6: Patch added
---
 xen/arch/x86/hvm/io.c     | 50 +++++---------------------------
 xen/drivers/vpci/vpci.c   | 60 +++++++++++++++++++++++++++++++++++++++
 xen/include/asm-x86/pci.h |  2 +-
 xen/include/xen/vpci.h    | 10 +++++++
 4 files changed, 78 insertions(+), 44 deletions(-)

diff --git a/xen/arch/x86/hvm/io.c b/xen/arch/x86/hvm/io.c
index 046a8eb4ed..340b8c8b0e 100644
--- a/xen/arch/x86/hvm/io.c
+++ b/xen/arch/x86/hvm/io.c
@@ -260,20 +260,6 @@ unsigned int hvm_pci_decode_addr(unsigned int cf8, unsigned int addr,
     return CF8_ADDR_LO(cf8) | (addr & 3);
 }
 
-/* Do some sanity checks. */
-static bool vpci_access_allowed(unsigned int reg, unsigned int len)
-{
-    /* Check access size. */
-    if ( len != 1 && len != 2 && len != 4 && len != 8 )
-        return false;
-
-    /* Check that access is size aligned. */
-    if ( (reg & (len - 1)) )
-        return false;
-
-    return true;
-}
-
 /* vPCI config space IO ports handlers (0xcf8/0xcfc). */
 static bool vpci_portio_accept(const struct hvm_io_handler *handler,
                                const ioreq_t *p)
@@ -305,7 +291,7 @@ static int vpci_portio_read(const struct hvm_io_handler *handler,
 
     reg = hvm_pci_decode_addr(cf8, addr, &sbdf);
 
-    if ( !vpci_access_allowed(reg, size) )
+    if ( !vpci_ecam_access_allowed(reg, size) )
         return X86EMUL_OKAY;
 
     *data = vpci_read(sbdf, reg, size);
@@ -335,7 +321,7 @@ static int vpci_portio_write(const struct hvm_io_handler *handler,
 
     reg = hvm_pci_decode_addr(cf8, addr, &sbdf);
 
-    if ( !vpci_access_allowed(reg, size) )
+    if ( !vpci_ecam_access_allowed(reg, size) )
         return X86EMUL_OKAY;
 
     vpci_write(sbdf, reg, size, data);
@@ -394,7 +380,7 @@ static unsigned int vpci_mmcfg_decode_addr(const struct hvm_mmcfg *mmcfg,
                                            paddr_t addr, pci_sbdf_t *sbdf)
 {
     addr -= mmcfg->addr;
-    sbdf->bdf = MMCFG_BDF(addr);
+    sbdf->bdf = ECAM_BDF(addr);
     sbdf->bus += mmcfg->start_bus;
     sbdf->seg = mmcfg->segment;
 
@@ -434,25 +420,8 @@ static int vpci_mmcfg_read(struct vcpu *v, unsigned long addr,
     reg = vpci_mmcfg_decode_addr(mmcfg, addr, &sbdf);
     read_unlock(&d->arch.hvm.mmcfg_lock);
 
-    if ( !vpci_access_allowed(reg, len) ||
-         (reg + len) > PCI_CFG_SPACE_EXP_SIZE )
-        return X86EMUL_OKAY;
-
-    /*
-     * According to the PCIe 3.1A specification:
-     *  - Configuration Reads and Writes must usually be DWORD or smaller
-     *    in size.
-     *  - Because Root Complex implementations are not required to support
-     *    accesses to a RCRB that cross DW boundaries [...] software
-     *    should take care not to cause the generation of such accesses
-     *    when accessing a RCRB unless the Root Complex will support the
-     *    access.
-     *  Xen however supports 8byte accesses by splitting them into two
-     *  4byte accesses.
-     */
-    *data = vpci_read(sbdf, reg, min(4u, len));
-    if ( len == 8 )
-        *data |= (uint64_t)vpci_read(sbdf, reg + 4, 4) << 32;
+    /* Ignore return code */
+    vpci_ecam_mmio_read(sbdf, reg, len, data);
 
     return X86EMUL_OKAY;
 }
@@ -476,13 +445,8 @@ static int vpci_mmcfg_write(struct vcpu *v, unsigned long addr,
     reg = vpci_mmcfg_decode_addr(mmcfg, addr, &sbdf);
     read_unlock(&d->arch.hvm.mmcfg_lock);
 
-    if ( !vpci_access_allowed(reg, len) ||
-         (reg + len) > PCI_CFG_SPACE_EXP_SIZE )
-        return X86EMUL_OKAY;
-
-    vpci_write(sbdf, reg, min(4u, len), data);
-    if ( len == 8 )
-        vpci_write(sbdf, reg + 4, 4, data >> 32);
+    /* Ignore return code */
+    vpci_ecam_mmio_write(sbdf, reg, len, data);
 
     return X86EMUL_OKAY;
 }
diff --git a/xen/drivers/vpci/vpci.c b/xen/drivers/vpci/vpci.c
index cbd1bac7fc..c0853176d7 100644
--- a/xen/drivers/vpci/vpci.c
+++ b/xen/drivers/vpci/vpci.c
@@ -478,6 +478,66 @@ void vpci_write(pci_sbdf_t sbdf, unsigned int reg, unsigned int size,
     spin_unlock(&pdev->vpci->lock);
 }
 
+/* Helper function to check an access size and alignment on vpci space. */
+bool vpci_ecam_access_allowed(unsigned int reg, unsigned int len)
+{
+    /*
+     * Check access size.
+     *
+     * On arm32 or for 32bit guests on arm, 64bit accesses should be forbidden
+     * but as for those platform ISV register, which gives the access size,
+     * cannot have a value 3, checking this would just harden the code.
+     */
+    if ( len != 1 && len != 2 && len != 4 && len != 8 )
+        return false;
+
+    /* Check that access is size aligned. */
+    if ( (reg & (len - 1)) )
+        return false;
+
+    return true;
+}
+
+int vpci_ecam_mmio_write(pci_sbdf_t sbdf, unsigned int reg, unsigned int len,
+                         unsigned long data)
+{
+    if ( !vpci_ecam_access_allowed(reg, len) ||
+         (reg + len) > PCI_CFG_SPACE_EXP_SIZE )
+        return 0;
+
+    vpci_write(sbdf, reg, min(4u, len), data);
+    if ( len == 8 )
+        vpci_write(sbdf, reg + 4, 4, data >> 32);
+
+    return 1;
+}
+
+int vpci_ecam_mmio_read(pci_sbdf_t sbdf, unsigned int reg, unsigned int len,
+                        unsigned long *data)
+{
+    if ( !vpci_ecam_access_allowed(reg, len) ||
+         (reg + len) > PCI_CFG_SPACE_EXP_SIZE )
+        return 0;
+
+    /*
+     * According to the PCIe 3.1A specification:
+     *  - Configuration Reads and Writes must usually be DWORD or smaller
+     *    in size.
+     *  - Because Root Complex implementations are not required to support
+     *    accesses to a RCRB that cross DW boundaries [...] software
+     *    should take care not to cause the generation of such accesses
+     *    when accessing a RCRB unless the Root Complex will support the
+     *    access.
+     *  Xen however supports 8byte accesses by splitting them into two
+     *  4byte accesses.
+     */
+    *data = vpci_read(sbdf, reg, min(4u, len));
+    if ( len == 8 )
+        *data |= (uint64_t)vpci_read(sbdf, reg + 4, 4) << 32;
+
+    return 1;
+}
+
 /*
  * Local variables:
  * mode: C
diff --git a/xen/include/asm-x86/pci.h b/xen/include/asm-x86/pci.h
index edd7c3e71a..a0df5c1279 100644
--- a/xen/include/asm-x86/pci.h
+++ b/xen/include/asm-x86/pci.h
@@ -6,7 +6,7 @@
 #define CF8_ADDR_HI(cf8) (  ((cf8) & 0x0f000000) >> 16)
 #define CF8_ENABLED(cf8) (!!((cf8) & 0x80000000))
 
-#define MMCFG_BDF(addr)  ( ((addr) & 0x0ffff000) >> 12)
+#define ECAM_BDF(addr)   ( ((addr) & 0x0ffff000) >> 12)
 
 #define IS_SNB_GFX(id) (id == 0x01068086 || id == 0x01168086 \
                         || id == 0x01268086 || id == 0x01028086 \
diff --git a/xen/include/xen/vpci.h b/xen/include/xen/vpci.h
index 9f5b5d52e1..4a0c3d77c9 100644
--- a/xen/include/xen/vpci.h
+++ b/xen/include/xen/vpci.h
@@ -208,6 +208,16 @@ static inline unsigned int vmsix_entry_nr(const struct vpci_msix *msix,
 {
     return entry - msix->entries;
 }
+
+/* ECAM mmio read/write helpers */
+bool vpci_ecam_access_allowed(unsigned int reg, unsigned int len);
+
+int vpci_ecam_mmio_write(pci_sbdf_t sbdf, unsigned int reg, unsigned int len,
+                         unsigned long data);
+
+int vpci_ecam_mmio_read(pci_sbdf_t sbdf, unsigned int reg, unsigned int len,
+                        unsigned long *data);
+
 #endif /* __XEN__ */
 
 #else /* !CONFIG_HAS_VPCI */
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Thu Oct 14 14:50:19 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Oct 2021 14:50:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.209435.365913 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mb23n-00067V-NK; Thu, 14 Oct 2021 14:50:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 209435.365913; Thu, 14 Oct 2021 14:50:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mb23n-00067M-Jl; Thu, 14 Oct 2021 14:50:19 +0000
Received: by outflank-mailman (input) for mailman id 209435;
 Thu, 14 Oct 2021 14:50:18 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=iCUr=PC=arm.com=bertrand.marquis@srs-us1.protection.inumbo.net>)
 id 1mb23m-000615-3q
 for xen-devel@lists.xenproject.org; Thu, 14 Oct 2021 14:50:18 +0000
Received: from foss.arm.com (unknown [217.140.110.172])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTP
 id 0bd4d608-2cfe-11ec-81c4-12813bfff9fa;
 Thu, 14 Oct 2021 14:50:17 +0000 (UTC)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1472C1480;
 Thu, 14 Oct 2021 07:50:17 -0700 (PDT)
Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com
 [10.1.199.62])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 67C553F694;
 Thu, 14 Oct 2021 07:50:15 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0bd4d608-2cfe-11ec-81c4-12813bfff9fa
From: Bertrand Marquis <bertrand.marquis@arm.com>
To: xen-devel@lists.xenproject.org
Cc: iwj@xenproject.org,
	Rahul Singh <rahul.singh@arm.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Wei Liu <wl@xen.org>,
	Paul Durrant <paul@xen.org>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>
Subject: [PATCH v6 2/3] xen/arm: Enable the existing x86 virtual PCI support for ARM.
Date: Thu, 14 Oct 2021 15:49:50 +0100
Message-Id: <396b08e2598cf0338e0c7f4ad3cd5cb66db89224.1634221830.git.bertrand.marquis@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <cover.1634221830.git.bertrand.marquis@arm.com>
References: <cover.1634221830.git.bertrand.marquis@arm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

From: Rahul Singh <rahul.singh@arm.com>

The existing VPCI support available for X86 is adapted for Arm.
When the device is added to XEN via the hyper call
“PHYSDEVOP_pci_device_add”, VPCI handler for the config space
access is added to the Xen to emulate the PCI devices config space.

A MMIO trap handler for the PCI ECAM space is registered in XEN
so that when guest is trying to access the PCI config space,XEN
will trap the access and emulate read/write using the VPCI and
not the real PCI hardware.

For Dom0less systems scan_pci_devices() would be used to discover the
PCI device in XEN and VPCI handler will be added during XEN boots.

This patch is also doing some small fixes to fix compilation errors on
arm32 of vpci:
- add a cast to unsigned long in print in header.c
- add a cast to uint64_t in vpci_ecam_mmio_write

Signed-off-by: Rahul Singh <rahul.singh@arm.com>
Signed-off-by: Bertrand Marquis <bertrand.marquis@arm.com>
---
Changes in v6:
- Use new vpci_ecam_ helpers for PCI access
- Do not set XEN_DOMCTL_CDF_vpci for dom0 for now (will be done in a
future patch once everything is ready)
- rename REGISTER_OFFSET to ECAM_REG_OFFSET and move it to pci.h
- remove not needed local variables in vpci_mmio_write, the one in read
has been kept to ensure proper compilation on arm32
- move call to vpci_add_handlers before iommu init to simplify exit path
- move call to pci_cleanup_msi in the out section of pci_add_device if
pdev is not NULL and on error
- initialize pdev to NULL to handle properly exit path call of
pci_cleanup_msi
- keep has_vpci to return false for now as CFG_vpci has been removed.
Added a comment on top of the definition.
- fix compilation errors on arm32 (print in header.c, cast missing in
mmio_write.
- local variable was kept in vpci_mmio_read on arm to prevent a cast
error in arm32.
Change in v5:
- Add pci_cleanup_msi(pdev) incleanup part.
- Added Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
Change in v4:
- Move addition of XEN_DOMCTL_CDF_vpci flag to separate patch
Change in v3:
- Use is_pci_passthrough_enabled() in place of pci_passthrough_enabled variable
- Reject XEN_DOMCTL_CDF_vpci for x86 in arch_sanitise_domain_config()
- Remove IS_ENABLED(CONFIG_HAS_VPCI) from has_vpci()
Change in v2:
- Add new XEN_DOMCTL_CDF_vpci flag
- modify has_vpci() to include XEN_DOMCTL_CDF_vpci
- enable vpci support when pci-passthough option is enabled.
---
---
 xen/arch/arm/Makefile         |  1 +
 xen/arch/arm/domain.c         |  4 ++
 xen/arch/arm/vpci.c           | 74 +++++++++++++++++++++++++++++++++++
 xen/arch/arm/vpci.h           | 36 +++++++++++++++++
 xen/drivers/passthrough/pci.c | 18 ++++++++-
 xen/drivers/vpci/header.c     |  3 +-
 xen/drivers/vpci/vpci.c       |  2 +-
 xen/include/asm-arm/domain.h  |  1 +
 xen/include/asm-x86/pci.h     |  2 -
 xen/include/public/arch-arm.h |  7 ++++
 xen/include/xen/pci.h         |  3 ++
 11 files changed, 146 insertions(+), 5 deletions(-)
 create mode 100644 xen/arch/arm/vpci.c
 create mode 100644 xen/arch/arm/vpci.h

diff --git a/xen/arch/arm/Makefile b/xen/arch/arm/Makefile
index 64518848b2..07f634508e 100644
--- a/xen/arch/arm/Makefile
+++ b/xen/arch/arm/Makefile
@@ -7,6 +7,7 @@ ifneq ($(CONFIG_NO_PLAT),y)
 obj-y += platforms/
 endif
 obj-$(CONFIG_TEE) += tee/
+obj-$(CONFIG_HAS_VPCI) += vpci.o
 
 obj-$(CONFIG_HAS_ALTERNATIVE) += alternative.o
 obj-y += bootfdt.init.o
diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
index eef0661beb..96e1b23550 100644
--- a/xen/arch/arm/domain.c
+++ b/xen/arch/arm/domain.c
@@ -39,6 +39,7 @@
 #include <asm/vgic.h>
 #include <asm/vtimer.h>
 
+#include "vpci.h"
 #include "vuart.h"
 
 DEFINE_PER_CPU(struct vcpu *, curr_vcpu);
@@ -773,6 +774,9 @@ int arch_domain_create(struct domain *d,
     if ( is_hardware_domain(d) && (rc = domain_vuart_init(d)) )
         goto fail;
 
+    if ( (rc = domain_vpci_init(d)) != 0 )
+        goto fail;
+
     return 0;
 
 fail:
diff --git a/xen/arch/arm/vpci.c b/xen/arch/arm/vpci.c
new file mode 100644
index 0000000000..7c3552b65d
--- /dev/null
+++ b/xen/arch/arm/vpci.c
@@ -0,0 +1,74 @@
+/*
+ * xen/arch/arm/vpci.c
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+#include <xen/sched.h>
+#include <xen/vpci.h>
+
+#include <asm/mmio.h>
+
+static int vpci_mmio_read(struct vcpu *v, mmio_info_t *info,
+                          register_t *r, void *p)
+{
+    pci_sbdf_t sbdf;
+    /* data is needed to prevent a pointer cast on 32bit */
+    unsigned long data = ~0ul;
+    int ret;
+
+    /* We ignore segment part and always handle segment 0 */
+    sbdf.sbdf = ECAM_BDF(info->gpa);
+
+    ret = vpci_ecam_mmio_read(sbdf, ECAM_REG_OFFSET(info->gpa),
+                              1U << info->dabt.size, &data);
+
+    *r = data;
+
+    return ret;
+}
+
+static int vpci_mmio_write(struct vcpu *v, mmio_info_t *info,
+                           register_t r, void *p)
+{
+    pci_sbdf_t sbdf;
+
+    /* We ignore segment part and always handle segment 0 */
+    sbdf.sbdf = ECAM_BDF(info->gpa);
+
+    return vpci_ecam_mmio_write(sbdf, ECAM_REG_OFFSET(info->gpa),
+                                1U << info->dabt.size, r);
+}
+
+static const struct mmio_handler_ops vpci_mmio_handler = {
+    .read  = vpci_mmio_read,
+    .write = vpci_mmio_write,
+};
+
+int domain_vpci_init(struct domain *d)
+{
+    if ( !has_vpci(d) )
+        return 0;
+
+    register_mmio_handler(d, &vpci_mmio_handler,
+                          GUEST_VPCI_ECAM_BASE, GUEST_VPCI_ECAM_SIZE, NULL);
+
+    return 0;
+}
+
+/*
+ * Local variables:
+ * mode: C
+ * c-file-style: "BSD"
+ * c-basic-offset: 4
+ * indent-tabs-mode: nil
+ * End:
+ */
+
diff --git a/xen/arch/arm/vpci.h b/xen/arch/arm/vpci.h
new file mode 100644
index 0000000000..d8a7b0e3e8
--- /dev/null
+++ b/xen/arch/arm/vpci.h
@@ -0,0 +1,36 @@
+/*
+ * xen/arch/arm/vpci.h
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+
+#ifndef __ARCH_ARM_VPCI_H__
+#define __ARCH_ARM_VPCI_H__
+
+#ifdef CONFIG_HAS_VPCI
+int domain_vpci_init(struct domain *d);
+#else
+static inline int domain_vpci_init(struct domain *d)
+{
+    return 0;
+}
+#endif
+
+#endif /* __ARCH_ARM_VPCI_H__ */
+
+/*
+ * Local variables:
+ * mode: C
+ * c-file-style: "BSD"
+ * c-basic-offset: 4
+ * indent-tabs-mode: nil
+ * End:
+ */
diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci.c
index 3aa8c3175f..8cc529ecec 100644
--- a/xen/drivers/passthrough/pci.c
+++ b/xen/drivers/passthrough/pci.c
@@ -658,7 +658,7 @@ int pci_add_device(u16 seg, u8 bus, u8 devfn,
                    const struct pci_dev_info *info, nodeid_t node)
 {
     struct pci_seg *pseg;
-    struct pci_dev *pdev;
+    struct pci_dev *pdev = NULL;
     unsigned int slot = PCI_SLOT(devfn), func = PCI_FUNC(devfn);
     const char *pdev_type;
     int ret;
@@ -752,6 +752,19 @@ int pci_add_device(u16 seg, u8 bus, u8 devfn,
 
     check_pdev(pdev);
 
+#ifdef CONFIG_ARM
+    /*
+     * On ARM PCI devices discovery will be done by Dom0. Add vpci handler when
+     * Dom0 inform XEN to add the PCI devices in XEN.
+     */
+    ret = vpci_add_handlers(pdev);
+    if ( ret )
+    {
+        printk(XENLOG_ERR "Setup of vPCI failed: %d\n", ret);
+        goto out;
+    }
+#endif
+
     ret = 0;
     if ( !pdev->domain )
     {
@@ -784,6 +797,9 @@ out:
                    &PCI_SBDF(seg, bus, slot, func));
         }
     }
+    else if ( pdev )
+        pci_cleanup_msi(pdev);
+
     return ret;
 }
 
diff --git a/xen/drivers/vpci/header.c b/xen/drivers/vpci/header.c
index f8cd55e7c0..c5b025b88b 100644
--- a/xen/drivers/vpci/header.c
+++ b/xen/drivers/vpci/header.c
@@ -374,7 +374,8 @@ static void bar_write(const struct pci_dev *pdev, unsigned int reg,
         if ( val != (uint32_t)(bar->addr >> (hi ? 32 : 0)) )
             gprintk(XENLOG_WARNING,
                     "%pp: ignored BAR %lu write with memory decoding enabled\n",
-                    &pdev->sbdf, bar - pdev->vpci->header.bars + hi);
+                    &pdev->sbdf,
+                    (unsigned long)(bar - pdev->vpci->header.bars + hi));
         return;
     }
 
diff --git a/xen/drivers/vpci/vpci.c b/xen/drivers/vpci/vpci.c
index c0853176d7..2bd67fc27a 100644
--- a/xen/drivers/vpci/vpci.c
+++ b/xen/drivers/vpci/vpci.c
@@ -507,7 +507,7 @@ int vpci_ecam_mmio_write(pci_sbdf_t sbdf, unsigned int reg, unsigned int len,
 
     vpci_write(sbdf, reg, min(4u, len), data);
     if ( len == 8 )
-        vpci_write(sbdf, reg + 4, 4, data >> 32);
+        vpci_write(sbdf, reg + 4, 4, (uint64_t)data >> 32);
 
     return 1;
 }
diff --git a/xen/include/asm-arm/domain.h b/xen/include/asm-arm/domain.h
index 14e575288f..9b3647587a 100644
--- a/xen/include/asm-arm/domain.h
+++ b/xen/include/asm-arm/domain.h
@@ -263,6 +263,7 @@ static inline void arch_vcpu_block(struct vcpu *v) {}
 
 #define arch_vm_assist_valid_mask(d) (1UL << VMASST_TYPE_runstate_update_flag)
 
+/* vPCI is not available on Arm */
 #define has_vpci(d)    ({ (void)(d); false; })
 
 #endif /* __ASM_DOMAIN_H__ */
diff --git a/xen/include/asm-x86/pci.h b/xen/include/asm-x86/pci.h
index a0df5c1279..443f25347d 100644
--- a/xen/include/asm-x86/pci.h
+++ b/xen/include/asm-x86/pci.h
@@ -6,8 +6,6 @@
 #define CF8_ADDR_HI(cf8) (  ((cf8) & 0x0f000000) >> 16)
 #define CF8_ENABLED(cf8) (!!((cf8) & 0x80000000))
 
-#define ECAM_BDF(addr)   ( ((addr) & 0x0ffff000) >> 12)
-
 #define IS_SNB_GFX(id) (id == 0x01068086 || id == 0x01168086 \
                         || id == 0x01268086 || id == 0x01028086 \
                         || id == 0x01128086 || id == 0x01228086 \
diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h
index d46c61fca9..44be337dec 100644
--- a/xen/include/public/arch-arm.h
+++ b/xen/include/public/arch-arm.h
@@ -418,6 +418,13 @@ typedef uint64_t xen_callback_t;
 #define GUEST_GICV3_GICR0_BASE     xen_mk_ullong(0x03020000) /* vCPU0..127 */
 #define GUEST_GICV3_GICR0_SIZE     xen_mk_ullong(0x01000000)
 
+/*
+ * 256 MB is reserved for VPCI configuration space based on calculation
+ * 256 buses × 32 devices × 8 functions × 4 KB = 256 MB
+ */
+#define GUEST_VPCI_ECAM_BASE    xen_mk_ullong(0x10000000)
+#define GUEST_VPCI_ECAM_SIZE    xen_mk_ullong(0x10000000)
+
 /* ACPI tables physical address */
 #define GUEST_ACPI_BASE xen_mk_ullong(0x20000000)
 #define GUEST_ACPI_SIZE xen_mk_ullong(0x02000000)
diff --git a/xen/include/xen/pci.h b/xen/include/xen/pci.h
index 70ac25345c..db18cb7639 100644
--- a/xen/include/xen/pci.h
+++ b/xen/include/xen/pci.h
@@ -40,6 +40,9 @@
 #define PCI_SBDF3(s,b,df) \
     ((pci_sbdf_t){ .sbdf = (((s) & 0xffff) << 16) | PCI_BDF2(b, df) })
 
+#define ECAM_BDF(addr)         ( ((addr) & 0x0ffff000) >> 12)
+#define ECAM_REG_OFFSET(addr)  ((addr) & 0x00000fff)
+
 typedef union {
     uint32_t sbdf;
     struct {
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Thu Oct 14 14:50:21 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Oct 2021 14:50:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.209436.365924 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mb23p-0006Px-5x; Thu, 14 Oct 2021 14:50:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 209436.365924; Thu, 14 Oct 2021 14:50:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mb23p-0006Po-2G; Thu, 14 Oct 2021 14:50:21 +0000
Received: by outflank-mailman (input) for mailman id 209436;
 Thu, 14 Oct 2021 14:50:20 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=iCUr=PC=arm.com=bertrand.marquis@srs-us1.protection.inumbo.net>)
 id 1mb23o-0005ov-Jd
 for xen-devel@lists.xenproject.org; Thu, 14 Oct 2021 14:50:20 +0000
Received: from foss.arm.com (unknown [217.140.110.172])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTP
 id f5207465-5608-40ae-a030-19d7c318afbc;
 Thu, 14 Oct 2021 14:50:18 +0000 (UTC)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 99A6AD6E;
 Thu, 14 Oct 2021 07:50:18 -0700 (PDT)
Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com
 [10.1.199.62])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 493633F694;
 Thu, 14 Oct 2021 07:50:17 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f5207465-5608-40ae-a030-19d7c318afbc
From: Bertrand Marquis <bertrand.marquis@arm.com>
To: xen-devel@lists.xenproject.org
Cc: iwj@xenproject.org,
	Rahul Singh <rahul.singh@arm.com>,
	Wei Liu <wl@xen.org>,
	Anthony PERARD <anthony.perard@citrix.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Michal Orzel <michal.orzel@arm.com>
Subject: [PATCH v6 3/3] arm/libxl: Emulated PCI device tree node in libxl
Date: Thu, 14 Oct 2021 15:49:51 +0100
Message-Id: <fd9c54a381daa52436b0a1b27cf1bba8e7ff9af9.1634221830.git.bertrand.marquis@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <cover.1634221830.git.bertrand.marquis@arm.com>
References: <cover.1634221830.git.bertrand.marquis@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Rahul Singh <rahul.singh@arm.com>

libxl will create an emulated PCI device tree node in the device tree to
enable the guest OS to discover the virtual PCI during guest boot.
Emulated PCI device tree node will only be created when there is any
device assigned to guest.

A new area has been reserved in the arm guest physical map at
which the VPCI bus is declared in the device tree (reg and ranges
parameters of the node).

b_info.arch_arm.vpci is set by default to false
and it is not set to true anywhere. This way the
vpci node is not going to be created and we are only
introducing functions to create vpci DT node to be used
in the future.

Signed-off-by: Rahul Singh <rahul.singh@arm.com>
Signed-off-by: Michal Orzel <michal.orzel@arm.com>
---
Changes in v6:
According to https://marc.info/?l=xen-devel&m=163415838129479&w=2:
-do not set XEN_DOMCTL_CDF_vpci
-do not enable VPCI support (by setting b_info.arch_arm.vpci)
-do not define LIBXL_HAVE_BUILDINFO_ARM_VPCI
-keep b_info.arch_arm.vpci, make_vpci_node and its helpers
Change in v5:
- Move setting the arch_arm.vpci and XEN_DOMCTL_CDF_vpci to libxl_arm.c
Change in v4:
- Gate code for x86 for setting the XEN_DOMCTL_CDF_vpci for x86.
Change in v3:
- Make GUEST_VPCI_MEM_ADDR address 2MB aligned
Change in v2:
- enable doamin_vpci_init() when XEN_DOMCTL_CDF_vpci is set for domain.
---
 tools/libs/light/libxl_arm.c     | 105 +++++++++++++++++++++++++++++++
 tools/libs/light/libxl_types.idl |   1 +
 xen/include/public/arch-arm.h    |  10 +++
 3 files changed, 116 insertions(+)

diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c
index e3140a6e00..52f1ddce48 100644
--- a/tools/libs/light/libxl_arm.c
+++ b/tools/libs/light/libxl_arm.c
@@ -269,6 +269,58 @@ static int fdt_property_regs(libxl__gc *gc, void *fdt,
     return fdt_property(fdt, "reg", regs, sizeof(regs));
 }
 
+static int fdt_property_values(libxl__gc *gc, void *fdt,
+        const char *name, unsigned num_cells, ...)
+{
+    uint32_t prop[num_cells];
+    be32 *cells = &prop[0];
+    int i;
+    va_list ap;
+    uint32_t arg;
+
+    va_start(ap, num_cells);
+    for (i = 0 ; i < num_cells; i++) {
+        arg = va_arg(ap, uint32_t);
+        set_cell(&cells, 1, arg);
+    }
+    va_end(ap);
+
+    return fdt_property(fdt, name, prop, sizeof(prop));
+}
+
+static int fdt_property_vpci_ranges(libxl__gc *gc, void *fdt,
+                                    unsigned addr_cells,
+                                    unsigned size_cells,
+                                    unsigned num_regs, ...)
+{
+    uint32_t regs[num_regs*((addr_cells*2)+size_cells+1)];
+    be32 *cells = &regs[0];
+    int i;
+    va_list ap;
+    uint64_t arg;
+
+    va_start(ap, num_regs);
+    for (i = 0 ; i < num_regs; i++) {
+        /* Set the memory bit field */
+        arg = va_arg(ap, uint32_t);
+        set_cell(&cells, 1, arg);
+
+        /* Set the vpci bus address */
+        arg = addr_cells ? va_arg(ap, uint64_t) : 0;
+        set_cell(&cells, addr_cells , arg);
+
+        /* Set the cpu bus address where vpci address is mapped */
+        set_cell(&cells, addr_cells, arg);
+
+        /* Set the vpci size requested */
+        arg = size_cells ? va_arg(ap, uint64_t) : 0;
+        set_cell(&cells, size_cells, arg);
+    }
+    va_end(ap);
+
+    return fdt_property(fdt, "ranges", regs, sizeof(regs));
+}
+
 static int make_root_properties(libxl__gc *gc,
                                 const libxl_version_info *vers,
                                 void *fdt)
@@ -668,6 +720,53 @@ static int make_vpl011_uart_node(libxl__gc *gc, void *fdt,
     return 0;
 }
 
+static int make_vpci_node(libxl__gc *gc, void *fdt,
+        const struct arch_info *ainfo,
+        struct xc_dom_image *dom)
+{
+    int res;
+    const uint64_t vpci_ecam_base = GUEST_VPCI_ECAM_BASE;
+    const uint64_t vpci_ecam_size = GUEST_VPCI_ECAM_SIZE;
+    const char *name = GCSPRINTF("pcie@%"PRIx64, vpci_ecam_base);
+
+    res = fdt_begin_node(fdt, name);
+    if (res) return res;
+
+    res = fdt_property_compat(gc, fdt, 1, "pci-host-ecam-generic");
+    if (res) return res;
+
+    res = fdt_property_string(fdt, "device_type", "pci");
+    if (res) return res;
+
+    res = fdt_property_regs(gc, fdt, GUEST_ROOT_ADDRESS_CELLS,
+            GUEST_ROOT_SIZE_CELLS, 1, vpci_ecam_base, vpci_ecam_size);
+    if (res) return res;
+
+    res = fdt_property_values(gc, fdt, "bus-range", 2, 0, 255);
+    if (res) return res;
+
+    res = fdt_property_cell(fdt, "#address-cells", 3);
+    if (res) return res;
+
+    res = fdt_property_cell(fdt, "#size-cells", 2);
+    if (res) return res;
+
+    res = fdt_property_string(fdt, "status", "okay");
+    if (res) return res;
+
+    res = fdt_property_vpci_ranges(gc, fdt, GUEST_ROOT_ADDRESS_CELLS,
+        GUEST_ROOT_SIZE_CELLS, 2,
+        GUEST_VPCI_ADDR_TYPE_MEM, GUEST_VPCI_MEM_ADDR, GUEST_VPCI_MEM_SIZE,
+        GUEST_VPCI_ADDR_TYPE_PREFETCH_MEM, GUEST_VPCI_PREFETCH_MEM_ADDR,
+        GUEST_VPCI_PREFETCH_MEM_SIZE);
+    if (res) return res;
+
+    res = fdt_end_node(fdt);
+    if (res) return res;
+
+    return 0;
+}
+
 static const struct arch_info *get_arch_info(libxl__gc *gc,
                                              const struct xc_dom_image *dom)
 {
@@ -971,6 +1070,9 @@ next_resize:
         if (info->tee == LIBXL_TEE_TYPE_OPTEE)
             FDT( make_optee_node(gc, fdt) );
 
+        if (libxl_defbool_val(info->arch_arm.vpci))
+            FDT( make_vpci_node(gc, fdt, ainfo, dom) );
+
         if (pfdt)
             FDT( copy_partial_fdt(gc, fdt, pfdt) );
 
@@ -1189,6 +1291,9 @@ void libxl__arch_domain_build_info_setdefault(libxl__gc *gc,
     /* ACPI is disabled by default */
     libxl_defbool_setdefault(&b_info->acpi, false);
 
+    /* VPCI is disabled by default */
+    libxl_defbool_setdefault(&b_info->arch_arm.vpci, false);
+
     if (b_info->type != LIBXL_DOMAIN_TYPE_PV)
         return;
 
diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_types.idl
index b96fb5c47e..61418ef6eb 100644
--- a/tools/libs/light/libxl_types.idl
+++ b/tools/libs/light/libxl_types.idl
@@ -644,6 +644,7 @@ libxl_domain_build_info = Struct("domain_build_info",[
 
     ("arch_arm", Struct(None, [("gic_version", libxl_gic_version),
                                ("vuart", libxl_vuart_type),
+                               ("vpci", libxl_defbool),
                               ])),
     ("arch_x86", Struct(None, [("msr_relaxed", libxl_defbool),
                               ])),
diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h
index 44be337dec..45aac5d18f 100644
--- a/xen/include/public/arch-arm.h
+++ b/xen/include/public/arch-arm.h
@@ -433,6 +433,11 @@ typedef uint64_t xen_callback_t;
 #define GUEST_PL011_BASE    xen_mk_ullong(0x22000000)
 #define GUEST_PL011_SIZE    xen_mk_ullong(0x00001000)
 
+/* Guest PCI-PCIe memory space where config space and BAR will be available.*/
+#define GUEST_VPCI_ADDR_TYPE_MEM            xen_mk_ullong(0x02000000)
+#define GUEST_VPCI_MEM_ADDR                 xen_mk_ullong(0x23000000)
+#define GUEST_VPCI_MEM_SIZE                 xen_mk_ullong(0x10000000)
+
 /*
  * 16MB == 4096 pages reserved for guest to use as a region to map its
  * grant table in.
@@ -448,6 +453,11 @@ typedef uint64_t xen_callback_t;
 #define GUEST_RAM0_BASE   xen_mk_ullong(0x40000000) /* 3GB of low RAM @ 1GB */
 #define GUEST_RAM0_SIZE   xen_mk_ullong(0xc0000000)
 
+/* 4GB @ 4GB Prefetch Memory for VPCI */
+#define GUEST_VPCI_ADDR_TYPE_PREFETCH_MEM   xen_mk_ullong(0x42000000)
+#define GUEST_VPCI_PREFETCH_MEM_ADDR        xen_mk_ullong(0x100000000)
+#define GUEST_VPCI_PREFETCH_MEM_SIZE        xen_mk_ullong(0x100000000)
+
 #define GUEST_RAM1_BASE   xen_mk_ullong(0x0200000000) /* 1016GB of RAM @ 8GB */
 #define GUEST_RAM1_SIZE   xen_mk_ullong(0xfe00000000)
 
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Thu Oct 14 15:09:56 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Oct 2021 15:09:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.209467.365935 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mb2Mg-0000Zk-S7; Thu, 14 Oct 2021 15:09:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 209467.365935; Thu, 14 Oct 2021 15:09:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mb2Mg-0000Zc-ON; Thu, 14 Oct 2021 15:09:50 +0000
Received: by outflank-mailman (input) for mailman id 209467;
 Thu, 14 Oct 2021 15:09:49 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=i4ou=PC=citrix.com=anthony.perard@srs-us1.protection.inumbo.net>)
 id 1mb2Mf-0000ZW-Nc
 for xen-devel@lists.xenproject.org; Thu, 14 Oct 2021 15:09:49 +0000
Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 25b35b83-6a18-48fd-8c18-dbc197d65505;
 Thu, 14 Oct 2021 15:09:48 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 25b35b83-6a18-48fd-8c18-dbc197d65505
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1634224188;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=A/eVLzCfFUVyQdqeKwlKTmaRG8eA9V1d03EtCCfE+1Y=;
  b=CVkQl/qZKlBDP9QGVtBWgFHMEGWhyMs+VFbWkBBh78NqzOKRt4VoTKWn
   nRhwbvY09s9d6Gg6idaiUcTrIaFgy2MDM/nepv9l/rlATbGmDgR4P8RuU
   5OFnlTvE537gdvVDI9if5U3Ggnij+HL20zH/YlkjRmM4OM0Hm9PucbKXq
   A=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: k54B7eE9/mhGK8OVivIzBoQxxrj+tWBs2DcJ5RYoxWodEgNhGRXYulbL8uWff7m85Ta/0niy6m
 HkfH5vvTkiZvxBSA3SnxYk5ffjL3ttvNRmoQYvDhjAn4wumqQvLqz4CtS0KAa5CU1f5i5yWEt0
 EFlGnQdD03vLoLx4Kc0ky8mARiBqmSGaiDMMm0OQT058NLB2Y3P985FYTPaEYO5c7CbzOjYqgu
 G51A2bEuEaVITBPYoUZTHj2Gp4jMVHS/+pQlw8LbrOgcRZJYxfibXLXJDMX9tGfij9lQLKtM6A
 OdprsSN1qDzqJAUBrPhirPff
X-SBRS: 5.1
X-MesageID: 57086575
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:6cQswath8izBG7Fvj5H2dv2po+fnVMhZMUV32f8akzHdYApBsoF/q
 tZmKTvQO/rfM2HxeYh1OYuw9hwHv5CBn9FgTwpu+yo1RitE+JbJXdiXEBz9bniYRiHhoOOLz
 Cm8hv3odp1coqr0/0/1WlTZQP0VOZigHtIQMsadUsxKbVIiGHpJZS5LwbZj29cw2IThWmthh
 PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe
 gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ
 Npl7JebRFdwJJDwx+00aEEIMT5vfvd5weqSSZS/mZT7I0zudnLtx7NlDV0sPJ1e8eFyaY1M3
 aVGcnZXNEnF3r/ohuLgIgVvrp1LwM3DNYUDunZm3HfBAOwvW5zrSKTW/95Imjw3g6iiGN6DO
 JJJN2cwMXwsZTUMJ3UyDspks96CpVDgSTQbo1G8u7Qotj27IAtZj+G2bYu9lsaxbdpRtlaVo
 CTB5WuRKhoTLtCYxBKO+2iggeKJliT+MKoCGbv9+vN0jVm7wm0IFAZQRVa9ueO+iEO1R5RYM
 UN80jE1saE4+UivT9/8dx61uniJulgbQdU4O+8w5RyJy6HUyx2EHWVCRTlEAPQnq80eVTEsz
 kWOnd7iGXpoqrL9YXCA8raZqxuiNC5TKnUNDRLoViNcvYOl+ttqyEuSEJAzS8ZZk+EZBxmpy
 BuH/HEkuolMhOcwj/WZ4kGE2Q2V882hohEO2i3bWWes7wVcbYGjZpC15VWz0cusPLp1XXHa4
 yBaw5n2APQmSMjXznTUEbpl8KSBvq7daFXhbUhT847NHthH00WoepxM+3lALUNtP9dsldTBM
 RKL5105CHO+OhKXgU5Lj2CZV5tCIUvIT42NuhXogjxmOcUZmOivpnAGWKJo9zqx+HXAaIlmU
 XthTe6iDGwBFYNsxyesSuEW3NcDn35lmTqOHc6knkr5idJygUJ5r59ebTNiichjvcu5TPj9q
 Y4DZ6NmNT0OOAEBXsUn2dFKdg1bRZTKLZv3t9ZWZoa+zvlOQwkc5wvq6ep5IeRNxv0N/s+Rp
 y3VchIImTLX2CycQS3XOy8LVV8adcsmxZ7NFXd3ZgjANrlKSdvH0ZrzgLNsJuB8rrY9naAkJ
 xTHEu3Zaslypv3802x1RfHAQEZKJXxHXCqCYHioZiYRZZllS1Cb89PoZFK3piIPEjC2pY01p
 Lj5jlHXRp8KRgJDCsfKaa3wkwPt7CZFwO8iDVHVJtRzeVn39NQ4ISLGkfJqcdoHLg/Ox2XG2
 l/OUwsYv+TEv6Q87MLN2fKft46sHuYnRhhaEmDX4KyYLy7f+mb/k4ZMXPzRJWLWVX/u+bXkb
 uJQlqmuPPoClVdMkox9D7c0kv5uu4qx/+dXl102Em/KYlKnDqJbDkOHhcQf5LdQwrJ5uBetX
 h7d8NdtJrjUatjuF0QcJVR5Y73bh+0UgDTb8d88PF7+uH1s5LOCXEhfY0uMhShaIOcnOY8p2
 7586ssf6gj5gRs2KNeWyCtT8j3UfHAHVqwmsLAcAZPq1VV3mg0TP8SEB3+k+oyLZvVNLlIuc
 22di6f1jrhBwlbPLigoHn/X0OsB3ZkDtXimFrPZy4hlTjYdusIK4Q==
IronPort-HdrOrdr: A9a23:O8atVqPV/end7cBcTsGjsMiBIKoaSvp037Eqv3oedfVwSL39qy
 nOpoV/6faaslsssR0b9exofZPwJk80lqQFg7X5X43DYOCOggLBR+tfBMnZsl7d8kXFh4hgPM
 xbEpSWZueeMWRH
X-IronPort-AV: E=Sophos;i="5.85,372,1624334400"; 
   d="scan'208";a="57086575"
Date: Thu, 14 Oct 2021 16:09:33 +0100
From: Anthony PERARD <anthony.perard@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, George Dunlap
	<george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>, Julien Grall
	<julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>, Wei Liu
	<wl@xen.org>, Doug Goldstein <cardoe@cardoe.com>,
	<xen-devel@lists.xenproject.org>
Subject: Re: [XEN PATCH v7 30/51] build: hook kconfig into xen build system
Message-ID: <YWhILTCeiQ363rhy@perard>
References: <20210824105038.1257926-1-anthony.perard@citrix.com>
 <20210824105038.1257926-31-anthony.perard@citrix.com>
 <eb7accc1-f46f-51c3-6610-4c6afbc40507@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <eb7accc1-f46f-51c3-6610-4c6afbc40507@suse.com>

On Mon, Oct 11, 2021 at 05:38:47PM +0200, Jan Beulich wrote:
> On 24.08.2021 12:50, Anthony PERARD wrote:
> > Now that xen's build system is very close to Linux's ones, we can hook
> > "Makefile.host" into Xen's build system, and we can build Kconfig with
> > that.
> > 
> > Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
> 
> Reviewed-by: Jan Beulich <jbeulich@suse.com>

Thanks.

I'll be squashing the previous patch into this one i.e. adding
"$(XEN_ROOT)/.config: ;" into tools/kconfig/Makefile (the previous patch
was adding it into Rules.mk).

And will be adding the following into the commit message:

    "tools/kconfig/Makefile" now needs a workaround to not rebuild
    "$(XEN_ROOT)/.config", as `make` tries the rules "%.config" which
    fails with:
        tools/kconfig/Makefile:95: *** No configuration exists for this target on this architecture.  Stop.

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Thu Oct 14 15:15:10 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Oct 2021 15:15:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.209474.365946 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mb2Rg-0001xv-G7; Thu, 14 Oct 2021 15:15:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 209474.365946; Thu, 14 Oct 2021 15:15:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mb2Rg-0001xo-DB; Thu, 14 Oct 2021 15:15:00 +0000
Received: by outflank-mailman (input) for mailman id 209474;
 Thu, 14 Oct 2021 15:14:59 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mb2Rf-0001xi-D4
 for xen-devel@lists.xenproject.org; Thu, 14 Oct 2021 15:14:59 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mb2Re-0002pm-F3; Thu, 14 Oct 2021 15:14:58 +0000
Received: from 54-240-197-239.amazon.com ([54.240.197.239]
 helo=[192.168.16.43]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mb2Re-0008IA-4f; Thu, 14 Oct 2021 15:14:58 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=cUKgf4nZWygc3rCRqdx0nkeVr+/3sIAO7Vx7dp8csps=; b=IO2RE/PMB27U3f1z7Q53iHrk5g
	DFQ6EGTWjY9LEPwx95qP0sRAnC05/fM7ZS827+UAIgZAgYbDu/B51iOuoqYaC06gjybU7mU9Nlkq3
	WLBnltgsLm8xxxEbjJqtONMdKFiPea0/DjIw25FE5zJXBXyavPZ1swxm+WMbnaL5wODI=;
Message-ID: <8696bffb-14f2-5ce4-ffa4-ea49fc2ca141@xen.org>
Date: Thu, 14 Oct 2021 16:14:56 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.2.0
Subject: Re: [PING] Re: [PATCH] xen/arm: optee: Allocate anonymous domheap
 pages
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Oleksandr <olekstysh@gmail.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>,
 Julien Grall <jgrall@amazon.com>
References: <1630935741-17088-1-git-send-email-olekstysh@gmail.com>
 <alpine.DEB.2.21.2109231308200.17979@sstabellini-ThinkPad-T480s>
 <87bl4jrovq.fsf@epam.com> <81f7699b-69c1-da52-a1a7-5000343bf872@gmail.com>
 <alpine.DEB.2.21.2110061639050.3209@sstabellini-ThinkPad-T480s>
 <87r1cwra4t.fsf@epam.com>
 <alpine.DEB.2.21.2110071357160.414@sstabellini-ThinkPad-T480s>
 <b9443cac-36ff-79b0-89d5-b96e8fc11d11@xen.org>
 <alpine.DEB.2.21.2110081236580.414@sstabellini-ThinkPad-T480s>
From: Julien Grall <julien@xen.org>
In-Reply-To: <alpine.DEB.2.21.2110081236580.414@sstabellini-ThinkPad-T480s>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Stefano,

On 08/10/2021 22:49, Stefano Stabellini wrote:
> On Fri, 8 Oct 2021, Julien Grall wrote:
>> On 07/10/2021 23:14, Stefano Stabellini wrote:
>>> On Thu, 7 Oct 2021, Volodymyr Babchuk wrote:
>>>> Hi Stefano,
>>>>
>>>> Stefano Stabellini <sstabellini@kernel.org> writes:
>>>>
>>>>> On Wed, 6 Oct 2021, Oleksandr wrote:
>>>>>> Hello all
>>>>>>
>>>>>> Gentle reminder.
>>>>>    Many thanks for the ping, this patch fell off my radar.
>>>>>
>>>>>
>>>>>    
>>>>>> On 23.09.21 23:57, Volodymyr Babchuk wrote:
>>>>>>> Hi Stefano,
>>>>>>>
>>>>>>> Stefano Stabellini <sstabellini@kernel.org> writes:
>>>>>>>
>>>>>>>> On Mon, 6 Sep 2021, Oleksandr Tyshchenko wrote:
>>>>>>>>> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>>>>>>>>>
>>>>>>>>> Allocate anonymous domheap pages as there is no strict need to
>>>>>>>>> account them to a particular domain.
>>>>>>>>>
>>>>>>>>> Since XSA-383 "xen/arm: Restrict the amount of memory that
>>>>>>>>> dom0less
>>>>>>>>> domU and dom0 can allocate" the dom0 cannot allocate memory
>>>>>>>>> outside
>>>>>>>>> of the pre-allocated region. This means if we try to allocate
>>>>>>>>> non-anonymous page to be accounted to dom0 we will get an
>>>>>>>>> over-allocation issue when assigning that page to the domain.
>>>>>>>>> The anonymous page, in turn, is not assigned to any domain.
>>>>>>>>>
>>>>>>>>> CC: Julien Grall <jgrall@amazon.com>
>>>>>>>>> Signed-off-by: Oleksandr Tyshchenko
>>>>>>>>> <oleksandr_tyshchenko@epam.com>
>>>>>>>>> Acked-by: Volodymyr Babchuk <volodymyr_babchuk@epam.com>
>>>>>>>> Only one question, which is more architectural: given that these
>>>>>>>> pages
>>>>>>>> are "unlimited", could the guest exploit the interface somehow to
>>>>>>>> force
>>>>>>>> Xen to allocate an very high number of anonymous pages?
>>>>>>>>
>>>>>>>> E.g. could a domain call OPTEE_SMC_RPC_FUNC_ALLOC in a loop to
>>>>>>>> force Xen
>>>>>>>> to exaust all memory pages?
>>>>>>> Generally, OP-TEE mediator tracks all resources allocated and
>>>>>>> imposes
>>>>>>> limits on them.
>>>>>>>
>>>>>>> OPTEE_SMC_RPC_FUNC_ALLOC case is a bit different, because it is
>>>>>>> issued
>>>>>>> not by domain, but by OP-TEE itself. As OP-TEE is more trusted piece
>>>>>>> of
>>>>>>> system we allow it to request as many buffers as it wants. Also, we
>>>>>>> know
>>>>>>> that OP-TEE asks only for one such buffer per every standard call.
>>>>>>> And
>>>>>>> number of simultaneous calls is limited by number of OP-TEE threads,
>>>>>>> which is quite low: typically only two.
>>>>>
>>>>> So let me repeat it differently to see if I understood correctly:
>>>>>
>>>>> - OPTEE_SMC_RPC_FUNC_ALLOC is only called by OP-TEE, not by the domain
>>>>> - OPTEE is trusted and only call it twice anyway
>>>>
>>>> Correct.
>>>>
>>>>> I am OK with this argument, but do we have a check to make sure a domU
>>>>> cannot issue OPTEE_SMC_RPC_FUNC_ALLOC?
>>>>
>>>> domU can't issue any RPC, because all RPCs are issued from OP-TEE
>>>> side. This is the nature of RPC - OP-TEE requests Normal World for some
>>>> service. But of course, Normal World can perform certain actions that
>>>> will make OP-TEE to issue a RPC. I discuss this in depth below.
>>>>
>>>>>
>>>>> Looking at the patch, there are other two places, in addition to
>>>>> OPTEE_SMC_RPC_FUNC_ALLOC, where the anonymous memory pages can be
>>>>> allocated:
>>>>>
>>>>> 1) copy_std_request
>>>>> 2) translate_noncontig
>>>>>
>>>>> We need to prove that neither 1) or 2) can result in a domU exausting
>>>>> Xen memory.
>>>>>
>>>>> In the case of 1), it looks like the memory is freed before returning to
>>>>> the DomU, right? If so, it should be no problem?
>>>>
>>>> Yes, mediator makes shadow copy of every request buffer to hide
>>>> translated addresses from the guest. Number of requests is limited by
>>>> number of OP-TEE threads.
>>>>
>>>>> In the case of 2), it looks like the memory could outlive the call where
>>>>> it is allocated. Is there any kind of protection against issuing
>>>>> something like OPTEE_MSG_ATTR_TYPE_TMEM_INOUT in a loop? Is it OP-TEE
>>>>> itself that would refuse the attempt? Thus, the idea is that
>>>>> do_call_with_arg will return error and we'll just free the memory there?
>>>>
>>>> Well, translate_noncontig() calls allocate_optee_shm_buf() which counts
>>>> all allocated buffers. So you can't call it more than
>>>> MAX_SHM_BUFFER_COUNT times, without de-allocating previous memory. But,
>>>> thanks to your question, I have found a bug there: memory is not freed
>>>> if allocate_optee_shm_buf() fails. I'll prepare patch later today.
>>>>
>>>>> I cannot see a check for errors returned by do_call_with_arg and memory
>>>>> freeing done because of that. Sorry I am not super familiar with the
>>>>> code, I am just trying to make sure we are not offering to DomUs an easy
>>>>> way to crash the system.
>>>>
>>>> I tried to eliminate all possibilities for a guest to crash the
>>>> system. Of course, this does not mean that there are none of them.
>>>>
>>>> And yes, code is a bit hard to understand, because calls to OP-TEE are
>>>> stateful and you need to account for that state. From NW and SW this
>>>> looks quite fine, because state is handled naturally. But mediator sits
>>>> in a middle, so it's implementation is a bit messy.
>>>>
>>>> I'll try to explain what is going on, so you it will be easier to
>>>> understand logic in the mediator.
>>>>
>>>> There are two types of OP-TEE calls: fast calls and standard calls. Fast
>>>> call is simple: call SMC and get result. It does not allocate thread
>>>> context in OP-TEE and is non-preemptive. So yes, it should be fast. It
>>>> is used for simple things like "get OP-TEE version" or "exchange
>>>> capabilities". It is easy to handle them in mediator: just forward
>>>> the call, check result, return it back to a guest.
>>>>
>>>> Standard calls are stateful. OP-TEE allocates thread for each call. This
>>>> call can be preempted either by IRQ or by RPC. For consistency IRQ
>>>> return is also considered as special type of RPC. So, in general one
>>>> standard call can consist of series of SMCs:
>>>>
>>>> --> SMC with request
>>>> <-- RPC return (like IRQ)
>>>> --> SMC "resume call"
>>>> <-- RPC return (like "read disk")
>>>> --> SMC "resume call"
>>>> <-- RPC return (like "send network packet")
>>>> --> SMC "resume call"
>>>> ...
>>>> <-- Final return
>>>>
>>>> There are many types of RPCs: "handle IRQ", additional shared buffer
>>>> allocation/de-allocation, RPMB access, disks access, network access,
>>>> synchronization primitives (when OP-TEE thread is gets blocked on a
>>>> mutex), etc.
>>>>
>>>> Two more things that makes all this worse: Normal World can register
>>>> shared buffer with OP-TEE. Such buffer can live indefinitely
>>>> long. Also, Normal World decides when to resume call. For example,
>>>> calling process can be preempted and then resumed seconds
>>>> later. Misbehaving guest can decide to not resume call at all.
>>>>
>>>> As I said, I tried to take all this things into account. There are
>>>> basically 3 types of objects that can lead to memory allocation on Xen
>>>> side:
>>>>
>>>> 1. Standard call context. Besides memory space for struct optee_std_call
>>>> itself it allocates page for a shadow buffer, where argument addresses
>>>> are translated by Xen. Number of this objects is limited by number of
>>>> OP-TEE threads:
>>>>
>>>>       count = atomic_add_unless(&ctx->call_count, 1, max_optee_threads);
>>>>       if ( count == max_optee_threads )
>>>>           return ERR_PTR(-ENOSPC);
>>>>
>>>> 2. Shared buffer. This is a buffer shared by guest with OP-TEE. It can
>>>> be either temporary buffer which is shared for one standard call
>>>> duration, or registered shared buffer, which is remains active until it
>>>> is de-registered. This is where translate_noncontig() comes into play.
>>>> Number of this buffers is limited in allocate_optee_shm_buf():
>>>>
>>>>       count = atomic_add_unless(&ctx->optee_shm_buf_count, 1,
>>>>                                 MAX_SHM_BUFFER_COUNT);
>>>>       if ( count == MAX_SHM_BUFFER_COUNT )
>>>>           return ERR_PTR(-ENOMEM);
>>>>
>>>> 3. Shared RPC buffer. This is very special kind of buffer. Basically,
>>>> OP-TEE needs some shared memory to provide RPC call parameters. So it
>>>> requests buffer from Normal World. There is no hard limit on this from
>>>> mediator side, because, as I told earlier, OP-TEE itself limits number
>>>> of this buffers. There is no cases when more that one buffer will be
>>>> allocated per OP-TEE thread. This type of buffer is used only to process
>>>> RPC requests themselves. OP-TEE can request more buffers via RPC, but
>>>> they will fall to p.2: NW uses separate request to register buffer and
>>>> then returns its handle in the preempted call.
>>>>
>>>>
>>>> Apart from those two limits, there is a limit on total number of pages
>>>> which is shared between guest and OP-TEE: MAX_TOTAL_SMH_BUF_PG. This
>>>> limit is for a case when guest tries to allocate few really BIG buffers.
>>>>
>>>>
>>>>> It looks like they could be called from one of the OPTEE operations that
>>>>> a domU could request? Is there a limit for them?
>>>>
>>>> Yes, there are limits, as I described above.
>>>>
>>>> Also, bear in mind that resources available to OP-TEE are also quite
>>>> limited. So, in case of some breach in mediator, OP-TEE will give up
>>>> first. This of course is not an excuse to have bugs in the mediator...
>>>
>>> OK, thanks for the explanation. The reasons for my questions is that if
>>> the allocations are using the memory of DomU, then at worst DomU can run
>>> out of memory.
>>
>> Not really. The worst outcome is still a DoS of the host because we don't
>> pre-allocate memory or even check that the total allocation will not exhaust
>> the memory.
>>
>> The only difference is I would argue this would be a misconfiguration of the
>> system.
>>
>>> But if the allocations are using anonymous memory, then
>>> the whole platform might run out of memory. We have issued XSAs for
>>> things like that in the past.
>>>
>>> This is why I am worried about this patch: if we apply it we really
>>> become reliant on these limits being implemented correctly. A bug can
>>> have much more severe consequences.
>>
>> This is not a problem specific to OP-TEE. Any anymous allocation (xmalloc,...)
>> done in Xen on behalf of the guest has, in theory, the same problem (see more
>> below).
>>
>>>
>>> As you are the maintainer for this code, and this code is not security
>>> supported, I'll leave it up to you (also see the other email about
>>> moving optee to "supported, not security supported").
>>>
>>> However, maybe a different solution would be to increase max_pages for a
>>> domain when optee is enabled? Maybe just by a few pages (as many as
>>> needed by the optee mediator)? Because if we did that, we wouldn't risk
>>> exposing DOS attack vectors for every bug in the mediator limits checks.
>> I think we need to differentiate two sorts of allocation:
>>    1) Memory used by Xen on behalf of the guest
>>    2) Memory used by the guest itself
>>
>> d->max_pages is only meant to refer to the latter (in fact, a guest can
>> balloon memory up to d->max_pages). In this case, we are discussing about the
>> latter and therefore I think the should be accounted differently as the memory
>> is not exposed to the guest.
> 
> Yeah, I was thinking the same thing yesterday but I didn't suggest it
> because we don't have a way to specify it today. I thought that rather
> than using anonymous memory it would still be preferable from a security
> standpoint to use d->max_pages, although I was aware of issues such as
> the guest able to balloon up to d->max_pages.
> 
> BTW do you know on top of your head of other things that can cause
> anonymous xmalloc (that lives longer than a single trap or hypercall) in
> Xen on ARM today? I'll try to keep an eye on them.

The biggest user on Arm is the P2M code today. The ITS code is probably 
going to be another one long term.

There are other example on x86 (shadow pool, IOMMU pool).

>>> The below adds a 10 pages slack.
>>>
>>>
>>> diff --git a/xen/arch/arm/tee/tee.c b/xen/arch/arm/tee/tee.c
>>> index 3964a8a5cd..a3105f1a9a 100644
>>> --- a/xen/arch/arm/tee/tee.c
>>> +++ b/xen/arch/arm/tee/tee.c
>>> @@ -38,8 +38,11 @@ bool tee_handle_call(struct cpu_user_regs *regs)
>>>        return cur_mediator->ops->handle_call(regs);
>>>    }
>>>    +#define TEE_SLACK (10)
>>>    int tee_domain_init(struct domain *d, uint16_t tee_type)
>>>    {
>>> +    int ret;
>>> +
>>>        if ( tee_type == XEN_DOMCTL_CONFIG_TEE_NONE )
>>>            return 0;
>>>    @@ -49,7 +52,15 @@ int tee_domain_init(struct domain *d, uint16_t
>>> tee_type)
>>>        if ( cur_mediator->tee_type != tee_type )
>>>            return -EINVAL;
>>>    -    return cur_mediator->ops->domain_init(d);
>>> +    ret = cur_mediator->ops->domain_init(d);
>>> +    if ( ret < 0 )
>>> +        return ret;
>>> +
>>> +    /*
>>> +     * Increase maxmem for domains with TEE, the extra pages are used by
>>> +     * the mediator
>>> +     */
>>> +    d->max_pages += TEE_SLACK;
>>
>> Regardless what I wrote above, this change would be incorrect because TEE is
>> initialized the when domain is created. However, d->max_pages is set
>> afterwards via DOMCTL_max_mem, so the value will get overridden.
>>
>> However, I don't think OP-TEE code should modify d->max_pages. Instead, this
>> should be accounted by the toolstack (or domain_build for dom0/domU created by
>> Xen).
> 
> Good point, and I can see that libxl has already a slack_memkb concept
> for PV x86 used to increase the memmap limit.
> 
> 
> The best solution would be to introduce a generic framework for
> accounting memory that Xen allocates on behalf of the guest. But of
> course we don't want to ask Oleksandr to do that now 1 week from the
> release and in response to a simple 3 lines patch. >
> With the best option not being available, we have to pick one of the
> following:
> 
> 1) current patch that uses anonymous memory
> 2) slack but done right (the toolstack and domain_build apply the slack
>     to d->max_pages)
> 
> My preference is 2) for security reasons but it is a bit more work.
> Taking into account that Julien, Volodymyr, and Bertrand all think that
> 1) is acceptable as is, then I will not insist. Option 1) is OK.

I will commit this patch then.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Thu Oct 14 15:22:22 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Oct 2021 15:22:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.209483.365957 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mb2Yj-0003Rn-CV; Thu, 14 Oct 2021 15:22:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 209483.365957; Thu, 14 Oct 2021 15:22:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mb2Yj-0003Rg-91; Thu, 14 Oct 2021 15:22:17 +0000
Received: by outflank-mailman (input) for mailman id 209483;
 Thu, 14 Oct 2021 15:22:15 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+gDO=PC=gmail.com=olekstysh@srs-us1.protection.inumbo.net>)
 id 1mb2Yh-0003Ra-PJ
 for xen-devel@lists.xenproject.org; Thu, 14 Oct 2021 15:22:15 +0000
Received: from mail-wr1-x434.google.com (unknown [2a00:1450:4864:20::434])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id e34b9c89-5d90-4fd7-b942-0a4a7aee5e5a;
 Thu, 14 Oct 2021 15:22:14 +0000 (UTC)
Received: by mail-wr1-x434.google.com with SMTP id m22so20827026wrb.0
 for <xen-devel@lists.xenproject.org>; Thu, 14 Oct 2021 08:22:14 -0700 (PDT)
Received: from [192.168.1.7] ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id d7sm2646811wrh.13.2021.10.14.08.22.09
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Thu, 14 Oct 2021 08:22:10 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e34b9c89-5d90-4fd7-b942-0a4a7aee5e5a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-transfer-encoding:content-language;
        bh=dqSLLvhZp69OmPrYjuRR+7D7GYlMIQw17eSTDghAnwk=;
        b=YkNSUxp8xL25cgNTnx5vejPh0E1sdnbKBMVXbx7bnaHvp3v1LKTASWkgrOCNlZPzaD
         ypOIvgfzBwKsANd8Iy4vlEHNdW/d+IvOq0AzSnEfGEMgDVXfoDfY1h+J+lq/mWlBAfs/
         HHeOTiGW83cKFX8H9MmEvYzzFoh7LjLjCKibN/peZ12GoNJdVBGRk8BcSF0KnzP5P2iT
         8MmMRVWsBmh7sjKm15cQOW376XTazH7cA7SE9r4PPKFQ/hjv6WasAQzkwdbIx+0y1D6Q
         Czf+K5oiggvNocNy5B3FJO1lrNinUzYv+qVcEHQJW8Jv4qZl3KOOf2dl8eBC3eFXJBxe
         Dq3w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding
         :content-language;
        bh=dqSLLvhZp69OmPrYjuRR+7D7GYlMIQw17eSTDghAnwk=;
        b=b+qJzjQ7dNFTtra1KPS013bTJZzRgVnDivaIL4yWyVV08LC2FWZuzAzZpnvTOSJDZD
         W+0ktcmhjBwrsCxpnZ5j0RYqwJK+ytSmv0yluC6YoJWukSKzQQnCdkBZ4buDbiRdcrGK
         Sw+vPd7HD4ldsYHi9DSUB5JPxLlN3oiZzE+vDBgO5fYNy3Azqxqq8uVTR61/Rnll/+5x
         bmOOqSuvi1w3WzsF91pMxvk6oZ/pMoEdcDx16/kmppmIcd+KIdPlYCbzzqMAqV2COlF/
         s81qfsUD6k0O+WP2+fiKAi0uPpYxHJNoz29bBXmR9qb5svr82CuEUnYIqzM0TwWjpYsX
         G0bA==
X-Gm-Message-State: AOAM530xrnlvosvcetoD5GxMAil0eFR9I79/v7KmIRftal2fJs9vjdfz
	yM+uLRwyf1X9XVGiBg3fPrk=
X-Google-Smtp-Source: ABdhPJw2GLJxV5kNbGV97rp2/ylreu5S4VmJXyD8Gu3UUjsulONiOD5c2rMdqhVkuZzQmmG82C6Rxw==
X-Received: by 2002:adf:b1c5:: with SMTP id r5mr7263004wra.357.1634224933654;
        Thu, 14 Oct 2021 08:22:13 -0700 (PDT)
Subject: Re: [PATCH V7 0/2] Add handling of extended regions (safe ranges) on
 Arm (Was "xen/memory: Introduce a hypercall to provide unallocated space")
To: Ian Jackson <iwj@xenproject.org>
Cc: xen-devel@lists.xenproject.org,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, Wei Liu <wl@xen.org>,
 Anthony PERARD <anthony.perard@citrix.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Juergen Gross <jgross@suse.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Henry Wang <Henry.Wang@arm.com>, Bertrand Marquis
 <bertrand.marquis@arm.com>, Wei Chen <Wei.Chen@arm.com>
References: <1634211645-26912-1-git-send-email-olekstysh@gmail.com>
 <24936.15991.111241.918070@mariner.uk.xensource.com>
From: Oleksandr <olekstysh@gmail.com>
Message-ID: <f533253f-1b8d-a0ba-bd4d-e1f85cb2968c@gmail.com>
Date: Thu, 14 Oct 2021 18:22:08 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <24936.15991.111241.918070@mariner.uk.xensource.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US


On 14.10.21 17:28, Ian Jackson wrote:

Hi Ian

> Oleksandr Tyshchenko writes ("[PATCH V7 0/2] Add handling of extended regions (safe ranges) on Arm (Was "xen/memory: Introduce a hypercall to provide unallocated space")"):
>> You can find an initial discussion at [1]-[7].
>>
>> The extended region (safe range) is a region of guest physical address space
>> which is unused and could be safely used to create grant/foreign mappings instead
>> of wasting real RAM pages from the domain memory for establishing these mappings.
> Thanks.
>
> This patch has all the required acks, but I was aware of an
> outstanding concern from Andrew, as set out in his most
> recent mail on the subject:
>    Subject: Re: [RFC PATCH 1/3] xen: Introduce "gpaddr_bits" field to XEN_SYSCTL_physinfo
>    Date: Tue, 7 Sep 2021 18:35:47 +0100
>    Message-ID: <973f5344-aa10-3ad6-ff02-ad5f358ad279@citrix.com>
>
> I think it would be within the process to just commit the patch now,
> but I thought it best to check as best I could that we weren't missing
> anything.  The process is supposed to support our continuing
> development and also our quality, so I aim to do those things.
>
> I reviewed that mail and had a conversation with Julien about it on
> irc.  My understanding is that Julien and Oleksandr's intent is that
> Andrew's concerns have been addressed, although we don't have a
> confirmation of that from Andrew.
>
> In particular, I wanted to convince myself that if in fact there was
> still a problem, we hadn't made a problem for ourselves with the API
> here.
>
> The new hypercalls are in unstable interfaces, so if we need to change
> them in a future version (eg to make ARM migration work) that's OK.
> Julien tells me that he doesn't believe there to be any impact on the
> (x86) migration stream right now.
>
> There is a new libxl stable interface.  But I think it is
> inoffensive.  In particular, basically any mechanism to do this would
> have that API.  And that doesn't seem to touch on the implementation
> issues described by Andrew.
>
> Therefore, I think (i) we have tried to address the issues (ii) any
> reminaing problems can be dealt with as followups, without trouble.

Completely agree with both statements.


>
> So I have just pushed these two.

Thanks!


> Thanks,
> Ian.

-- 
Regards,

Oleksandr Tyshchenko



From xen-devel-bounces@lists.xenproject.org Thu Oct 14 16:01:16 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Oct 2021 16:01:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.209493.365968 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mb3AM-0007vj-Bk; Thu, 14 Oct 2021 16:01:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 209493.365968; Thu, 14 Oct 2021 16:01:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mb3AM-0007vc-72; Thu, 14 Oct 2021 16:01:10 +0000
Received: by outflank-mailman (input) for mailman id 209493;
 Thu, 14 Oct 2021 16:01:09 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mb3AL-0007vS-3K; Thu, 14 Oct 2021 16:01:09 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mb3AK-0004AM-Uu; Thu, 14 Oct 2021 16:01:08 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mb3AK-0007Q7-ND; Thu, 14 Oct 2021 16:01:08 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mb3AK-0000Bx-MR; Thu, 14 Oct 2021 16:01:08 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=Tg/bXOR3Quy1WKtWhbgLdhOcYej3KuxggLuu/KQtfxg=; b=ttPFxejdE8Jg3KY8M6DGgCkrt7
	jgc7GSYcHlCORpE8qhqWl3LP17BGs3o2vBBRhYqv7FGDDpN4uROmd0xZwMiDXoTw6xnLlJhCTjObL
	3I7bue6Y4K4+oUaxEp3/V/PQQT75e1Kt9IlVxqt2Hmftuugulr562In/Cm/yXHDJQYqw=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165508-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 165508: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=785cfd33053f506d4a1c17100356a63f24e98f45
X-Osstest-Versions-That:
    ovmf=e0c23cba5eaeb6c934a10ecdabcb235ef5d63799
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 14 Oct 2021 16:01:08 +0000

flight 165508 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165508/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 785cfd33053f506d4a1c17100356a63f24e98f45
baseline version:
 ovmf                 e0c23cba5eaeb6c934a10ecdabcb235ef5d63799

Last test of basis   165505  2021-10-14 07:10:13 Z    0 days
Testing same since   165508  2021-10-14 12:11:12 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Heinrich Schuchardt <xypron.glpk@gmx.de>
  Liu, Zhiguang <Zhiguang.Liu@intel.com>
  Zhiguang Liu <zhiguang.liu@intel.com>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   e0c23cba5e..785cfd3305  785cfd33053f506d4a1c17100356a63f24e98f45 -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Thu Oct 14 16:06:23 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Oct 2021 16:06:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.209502.365982 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mb3FK-00009R-V7; Thu, 14 Oct 2021 16:06:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 209502.365982; Thu, 14 Oct 2021 16:06:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mb3FK-00009K-Qv; Thu, 14 Oct 2021 16:06:18 +0000
Received: by outflank-mailman (input) for mailman id 209502;
 Thu, 14 Oct 2021 16:06:18 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Xl23=PC=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mb3FJ-00009D-Ub
 for xen-devel@lists.xenproject.org; Thu, 14 Oct 2021 16:06:18 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 8184e60c-16d6-46f9-a890-76f9ac238602;
 Thu, 14 Oct 2021 16:06:16 +0000 (UTC)
Received: from EUR02-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur02lp2053.outbound.protection.outlook.com [104.47.6.53]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-14-_60D_4KhOZ2SuHj3OGy79A-1; Thu, 14 Oct 2021 18:06:14 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB4606.eurprd04.prod.outlook.com (2603:10a6:803:70::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.21; Thu, 14 Oct
 2021 16:06:12 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.016; Thu, 14 Oct 2021
 16:06:12 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS9PR0301CA0050.eurprd03.prod.outlook.com (2603:10a6:20b:469::19) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15 via Frontend
 Transport; Thu, 14 Oct 2021 16:06:12 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8184e60c-16d6-46f9-a890-76f9ac238602
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634227575;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=RlA0inKH5ZR5TLQoghmdZ7ymt7NJrHc0t+FKcbdTdMU=;
	b=ACWwhX7KN5eInWD0wvS4W1wis43cvO2+dRFOG028+q9WaMEAXoI4ntoOg/xlcw9rCAwWKf
	Ze7LRpMHil0B8/GLFA/oxh6QkCJxC/DLZcypWdU/hIEofRXWIai7j6HSBXsAXZCYdRNz45
	udmI78HBbQYkGwmqNY9e35JEx6QAyII=
X-MC-Unique: _60D_4KhOZ2SuHj3OGy79A-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=WPmI0kZa8MbNUZucmpuFyvpcwamc2INZANqlJKOd7p6tEabOGQe1W/yeOl3ffJbgzEdf3WHKPH592fM/0AYsb+BqS5iWQULP6aKWc4TNwFUltsQDA5nWeYkkLEnBxqeTgKiLX4f1M9rNoB+itD+tImaQADYRDs0HWvGEDck0cFBbr0cfIv4vGtqQYsXPPxCwNJyzjo/VB7wTNZii9PNf5wpwz845gLn0418nJQQxeC+mxfL2mgfoz3kfb9VnglVt+UwT4QL1Lvdy9Ziyhe8Ujw0GtBxzviTNaGvAMj8zRpoGJPafwFK8WA0bh18LPR0ujVYoN/CqJ9tcOL29J1UoQQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=RlA0inKH5ZR5TLQoghmdZ7ymt7NJrHc0t+FKcbdTdMU=;
 b=A2COEWrl78MFyi+AHLMCVpD8jW9T4v7SzHzPcc8i72EYmDXww/z+abFyFApO9SPU7rb6ByLbUFuNhAZ4SUXg+y+yGqOz/H/wZ8Lcg6Pd/4SQpPvtuLnMB26qIY7Cba+loq8EJQb2ia0Y+XMYRPldFHjItP9ItC1Ci8eZJhnxM3neS1wJEL96x8DFH1uf2yd5Uo9QKw+jMXtK9w4cBVvqlvg2/DZc6U1gepXp/TzNIg+HZF71Zl7XGcrqhpKwH93mNpnXXKb7KFV0YT4Pgno5zgQt+9f2MTOxYzxDRsv8MMMJnZLQXo+Csvbv++K7lqoBbR+/Dq+FKKRB9G4lp+k0Cw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [PATCH v6 1/3] xen/vpci: Move ecam access functions to common
 code
To: Bertrand Marquis <bertrand.marquis@arm.com>
Cc: iwj@xenproject.org, Paul Durrant <paul@xen.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>, Wei Liu
 <wl@xen.org>, xen-devel@lists.xenproject.org
References: <cover.1634221830.git.bertrand.marquis@arm.com>
 <ced6f870dbfabcfe8584555cc80f9a37a0655a0c.1634221830.git.bertrand.marquis@arm.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <20c73f4e-5a8b-c127-f3a7-b841f50b1a4a@suse.com>
Date: Thu, 14 Oct 2021 18:06:10 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <ced6f870dbfabcfe8584555cc80f9a37a0655a0c.1634221830.git.bertrand.marquis@arm.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR0301CA0050.eurprd03.prod.outlook.com
 (2603:10a6:20b:469::19) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 9e647b40-124d-4c81-473a-08d98f2c8b14
X-MS-TrafficTypeDiagnostic: VI1PR04MB4606:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB46062E96B6CA6F81B1C536A4B3B89@VI1PR04MB4606.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	aick6tYq9wt/oX3gHKj6+H+Zqis+64LRcabg8+/Af7AkuN+M6nMnsHYKOoM7U6eY7AKwDtASl8sYnoFTDXfIFMwLURrGd9in8Ji5z3IPXCQgCR5/D8On2A+l+jJO9mOLQy8Ye35dpW+/NpC8724/WrewaNBZlWA1X9bPRS/mBQsDcz5tONrcekIaOTr6wlV/d/SbtFelPHDZ+ACf8dBls7i3NIy85Rjqz7IMCuv3iBaVAizXqQ+t2jklNmBUzbPFuugym4FKp8zSQNMzbB5tagGjMw5UvGrSVSjGtIDu2Vykcn6YYkCKfzVLghi8vU0i8i7zSfseSr3lVNMq2naiZdric6ICToy4r81aNq4QkDtct3HEhrvBgaMZ+6lvdQ9kmKWP6g99hMg1ylg7J1wsYUvCsXrmObSQeQEDwabJSm+8MecJIiAZnuPK71Jup2Nivnov9CrdVLuA3eSKIm8HLpX1wWfHMGxyghqAfwfTzhJLA8V3PhzMscdCIPHaS+U33aPY6QI3B+e56XCY96Lvh9WG8sphwUBgIi3xkMKDNqo0HdcXKL42x+oAPFj+U47f1rRXG/pf81ymHUs/WEO/fzMdo1HWDoo1Zff97BSQk02byn/k5+4kViQQKo0IDyoSOoOebJkulSICzW2Ti1WgyQBXur7YlT2RWRbiz49LyTzVUs5vR4w7nGulGfpx1ppLqqpJxQILjDpCDiICjTeZIx/ZCF+JGrO/GRxn1kLF7HQ=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(8936002)(31686004)(4326008)(66946007)(508600001)(83380400001)(2616005)(5660300002)(36756003)(316002)(6486002)(2906002)(53546011)(38100700002)(66476007)(66556008)(8676002)(86362001)(6916009)(16576012)(26005)(186003)(31696002)(956004)(54906003)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?VDdUZDBVaDZHRCthRmdaK0lSbzdGSUNaSi9sd2RJOEdsRHNIcE94ZEpWb2x0?=
 =?utf-8?B?cXZ0ckU3dllybElyM2paVTNkUFU2QS9oVlFqeEhyeENmZWFJVUt4Qk9VTm1q?=
 =?utf-8?B?czhpVTZHZDNmMXpVVTZjTENOeGVrUEU1S2haOVVDbWRrYVdSUjJWNkZDSTZt?=
 =?utf-8?B?VkR5MXJPZnJtbjg0VzlNWTVKSnJKd0tFOFphQ1pQcnlqT200U2dDNjBLZCt3?=
 =?utf-8?B?aFpvcEp0RGZNRzV3YmhWQy8yUGtCT0FmS2FuTXJJdFFMTTY1dDZyNzV0TWR4?=
 =?utf-8?B?dmdnMVJuVzBHdnh1QUNGRkhQTVFMTktYajR1WkZSclpMaHJYdU1kRTRteXNC?=
 =?utf-8?B?S0RGcXQyVmNyZzJtRDJ6ZjFLeGtaQWdvRFdXTUY2MWpMRzVydFIxVDJJVGMy?=
 =?utf-8?B?ZG84eC9BQ2VVcXRFVkIwV0dIcUNRa0pvY0s2VWlsYnFaTFFIMi9JRjVSTzJy?=
 =?utf-8?B?NmZpenEwNEZZNnhWdmlkbkFEZ0FxRUZ5Snh1RzBRSk4xZUtHSjFPckt3dlg5?=
 =?utf-8?B?ckw0Tlh0K1M5Zm94ZzdEVUxMeTl0Y3dQUkdmUFJyNVlwcWJtSUhyQ04vR2gv?=
 =?utf-8?B?a0hqTGJmck9oekJ3WnVlTUY2VE1OQnVZK09KMXZ0c2d1MGw2QUhDYjVycEtD?=
 =?utf-8?B?S1FrVG1FSy9aeVlrMTdyMGZvL0c2cVVtZDEyWVVnM003Wk5XMHRnOGZLRm9B?=
 =?utf-8?B?ZXNoQ0hJcWptVngwWkpSbHgrMXVYWktPZkg1eFp4blZ5czFRaHFYeWRGNjRW?=
 =?utf-8?B?QVVQdUpaSXNXUlNLS2p1WCtjMEYybWZYUTBWZjB3VmcwWDh2UHlYaTJSS1JD?=
 =?utf-8?B?NjNJOVlhSm9mYVpoMXVvbHp1NE1sSUpXZkR2N2V6T2hVVFJ5NWdBRXByRUh5?=
 =?utf-8?B?Qmx5bTk3WFVVNTd4aFd6aE1YbHlhNUpuUEpuS2FpTXVTdXZLZU8vTzlMd3Iz?=
 =?utf-8?B?NzQxbjF0b0RQeWhZNVRBRnBTUzl1UXk2QWR4SlFGdk9lWk5vVXJ2NTgydjJj?=
 =?utf-8?B?Y0JxZmpJbFlOcHJQYytkQklYL2ROSnlIU3lzeEtzUGxFL3lJc25KN0R6WVlu?=
 =?utf-8?B?VzdJLy81R20rU0xmZEN2YmJqYWt2V1NHampLdlphM3NxK2JVSGpLbHhSaEJr?=
 =?utf-8?B?OTI0ek53L0h5NEFrMmhNMytycjNpNXBtMFF3c2NpOE50L3dJRVhVOGpaem9p?=
 =?utf-8?B?dENpS3hLM1RobDFyYlplcVRCSExKTXVGdUZmV3B3cXdZQm1rQ040bnpmMXgw?=
 =?utf-8?B?RFJyRVdlQmdMdmliSHlta3NzK2g2dXVRTzVKRGM1OE5ja25OVTVNNU9HaXky?=
 =?utf-8?B?L0Y0WWhxZmtta0hzMUttei92Qkh6Tlhmb2U2NWg5bnpXR3hSTjN0Qk81Tm5v?=
 =?utf-8?B?WUVFZnB6VkdpT3ptM1lSOStpTjhBaEtTVmVVZkFUYW1CcFlKK2pjS0FmZURy?=
 =?utf-8?B?cDZmYjMyYVlkcTNFQ0lROVVpcUcvVEFvWWRxVHlHUHFPNkZwVTFWRDRiUDBY?=
 =?utf-8?B?eDJjWEhNMGhLdVpHeGpPR3dRcXRnR1BaRU8rVXg1akRXUFFTUzFlbE43Rjc2?=
 =?utf-8?B?ZHFSN3RidG8zb0dEaWEvYkJkU0VQZUZHV2MwazRreHZMdkY1MFFMMGE4N1FR?=
 =?utf-8?B?TTdvRXFJeEZ1N2tjVFgxaFZiNzJVaWhrdEFIUkRvV3h4SW4vS2Y1MlMvUHF1?=
 =?utf-8?B?Z0toSEJlZWY5QVdSTkdVcGloSzRPVG5VcitJbWU4RDBYME42VjdhUGhkMU1w?=
 =?utf-8?Q?WTCFpGzOwC+syj8qeugZcwlOFMTQ/wChW7yx+Lo?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9e647b40-124d-4c81-473a-08d98f2c8b14
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2021 16:06:12.5570
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 7MNtAXNq4AHe6SMmsJErXNWjYr9ppn7044ZACBFZ5K0/DAGVoQ6QKYQDuIk3sdIi76kWZimw3BOEJtRuOGQXUw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4606

On 14.10.2021 16:49, Bertrand Marquis wrote:
> @@ -305,7 +291,7 @@ static int vpci_portio_read(const struct hvm_io_handler *handler,
>  
>      reg = hvm_pci_decode_addr(cf8, addr, &sbdf);
>  
> -    if ( !vpci_access_allowed(reg, size) )
> +    if ( !vpci_ecam_access_allowed(reg, size) )
>          return X86EMUL_OKAY;
>  
>      *data = vpci_read(sbdf, reg, size);
> @@ -335,7 +321,7 @@ static int vpci_portio_write(const struct hvm_io_handler *handler,
>  
>      reg = hvm_pci_decode_addr(cf8, addr, &sbdf);
>  
> -    if ( !vpci_access_allowed(reg, size) )
> +    if ( !vpci_ecam_access_allowed(reg, size) )
>          return X86EMUL_OKAY;
>  
>      vpci_write(sbdf, reg, size, data);

Why would port I/O functions call an ECAM helper? And in how far is
that helper actually ECAM-specific?

> @@ -434,25 +420,8 @@ static int vpci_mmcfg_read(struct vcpu *v, unsigned long addr,
>      reg = vpci_mmcfg_decode_addr(mmcfg, addr, &sbdf);
>      read_unlock(&d->arch.hvm.mmcfg_lock);
>  
> -    if ( !vpci_access_allowed(reg, len) ||
> -         (reg + len) > PCI_CFG_SPACE_EXP_SIZE )
> -        return X86EMUL_OKAY;

While I assume this earlier behavior is the reason for ...

> -    /*
> -     * According to the PCIe 3.1A specification:
> -     *  - Configuration Reads and Writes must usually be DWORD or smaller
> -     *    in size.
> -     *  - Because Root Complex implementations are not required to support
> -     *    accesses to a RCRB that cross DW boundaries [...] software
> -     *    should take care not to cause the generation of such accesses
> -     *    when accessing a RCRB unless the Root Complex will support the
> -     *    access.
> -     *  Xen however supports 8byte accesses by splitting them into two
> -     *  4byte accesses.
> -     */
> -    *data = vpci_read(sbdf, reg, min(4u, len));
> -    if ( len == 8 )
> -        *data |= (uint64_t)vpci_read(sbdf, reg + 4, 4) << 32;
> +    /* Ignore return code */
> +    vpci_ecam_mmio_read(sbdf, reg, len, data);

... the commented-upon ignoring of the return value, I don't think
that's a good way to deal with things anymore. Instead I think
*data should be written to ~0 upon failure, unless it is intended
for vpci_ecam_mmio_read() to take care of that case (in which case
I'm not sure I would see why it needs to return an error indicator
in the first place).

> @@ -476,13 +445,8 @@ static int vpci_mmcfg_write(struct vcpu *v, unsigned long addr,
>      reg = vpci_mmcfg_decode_addr(mmcfg, addr, &sbdf);
>      read_unlock(&d->arch.hvm.mmcfg_lock);
>  
> -    if ( !vpci_access_allowed(reg, len) ||
> -         (reg + len) > PCI_CFG_SPACE_EXP_SIZE )
> -        return X86EMUL_OKAY;
> -
> -    vpci_write(sbdf, reg, min(4u, len), data);
> -    if ( len == 8 )
> -        vpci_write(sbdf, reg + 4, 4, data >> 32);
> +    /* Ignore return code */
> +    vpci_ecam_mmio_write(sbdf, reg, len, data);

Here ignoring is fine imo, but if you feel it is important to
comment on this, then I think you need to prefer "why" over "what".

> --- a/xen/drivers/vpci/vpci.c
> +++ b/xen/drivers/vpci/vpci.c
> @@ -478,6 +478,66 @@ void vpci_write(pci_sbdf_t sbdf, unsigned int reg, unsigned int size,
>      spin_unlock(&pdev->vpci->lock);
>  }
>  
> +/* Helper function to check an access size and alignment on vpci space. */
> +bool vpci_ecam_access_allowed(unsigned int reg, unsigned int len)
> +{
> +    /*
> +     * Check access size.
> +     *
> +     * On arm32 or for 32bit guests on arm, 64bit accesses should be forbidden
> +     * but as for those platform ISV register, which gives the access size,
> +     * cannot have a value 3, checking this would just harden the code.
> +     */
> +    if ( len != 1 && len != 2 && len != 4 && len != 8 )
> +        return false;

I'm not convinced talking about Arm specifically here is
warranted, unless there's something there that's clearly
different from all other architectures. Otherwise the comment
should imo be written in more general terms.

> +int vpci_ecam_mmio_write(pci_sbdf_t sbdf, unsigned int reg, unsigned int len,
> +                         unsigned long data)
> +{
> +    if ( !vpci_ecam_access_allowed(reg, len) ||
> +         (reg + len) > PCI_CFG_SPACE_EXP_SIZE )
> +        return 0;
> +
> +    vpci_write(sbdf, reg, min(4u, len), data);
> +    if ( len == 8 )
> +        vpci_write(sbdf, reg + 4, 4, data >> 32);
> +
> +    return 1;
> +}
> +
> +int vpci_ecam_mmio_read(pci_sbdf_t sbdf, unsigned int reg, unsigned int len,
> +                        unsigned long *data)
> +{
> +    if ( !vpci_ecam_access_allowed(reg, len) ||
> +         (reg + len) > PCI_CFG_SPACE_EXP_SIZE )
> +        return 0;
> +
> +    /*
> +     * According to the PCIe 3.1A specification:
> +     *  - Configuration Reads and Writes must usually be DWORD or smaller
> +     *    in size.
> +     *  - Because Root Complex implementations are not required to support
> +     *    accesses to a RCRB that cross DW boundaries [...] software
> +     *    should take care not to cause the generation of such accesses
> +     *    when accessing a RCRB unless the Root Complex will support the
> +     *    access.
> +     *  Xen however supports 8byte accesses by splitting them into two
> +     *  4byte accesses.
> +     */
> +    *data = vpci_read(sbdf, reg, min(4u, len));
> +    if ( len == 8 )
> +        *data |= (uint64_t)vpci_read(sbdf, reg + 4, 4) << 32;
> +
> +    return 1;
> +}

Why do these two functions return int/0/1 instead of
bool/false/true (assuming, as per above, that them returning non-
void is warranted at all)?

Also both of these functions will silently misbehave on 32-bit due to
the use of unsigned long in the parameter types. I think you want e.g.
CONFIG_64BIT conditionals here as well as in vpci_access_allowed()
(omitting the questionable "ecam" part of the name) to reject len == 8
there in that case.

Finally, to me, having both "ecam" and "mmio" in the names feels
redundant - the PCI spec doesn't mention any non-MMIO mechanism there
afaics.

Jan



From xen-devel-bounces@lists.xenproject.org Thu Oct 14 16:22:38 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Oct 2021 16:22:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.209514.365997 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mb3Ux-0002U6-BX; Thu, 14 Oct 2021 16:22:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 209514.365997; Thu, 14 Oct 2021 16:22:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mb3Ux-0002Tz-8b; Thu, 14 Oct 2021 16:22:27 +0000
Received: by outflank-mailman (input) for mailman id 209514;
 Thu, 14 Oct 2021 16:22:26 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+gDO=PC=gmail.com=olekstysh@srs-us1.protection.inumbo.net>)
 id 1mb3Uw-0002To-0Q
 for xen-devel@lists.xenproject.org; Thu, 14 Oct 2021 16:22:26 +0000
Received: from mail-wr1-x42e.google.com (unknown [2a00:1450:4864:20::42e])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 47b42570-a71b-4e33-a24b-ac10ddf1490b;
 Thu, 14 Oct 2021 16:22:25 +0000 (UTC)
Received: by mail-wr1-x42e.google.com with SMTP id u18so21323793wrg.5
 for <xen-devel@lists.xenproject.org>; Thu, 14 Oct 2021 09:22:25 -0700 (PDT)
Received: from [192.168.1.7] ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id f127sm7992096wmf.16.2021.10.14.09.22.22
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Thu, 14 Oct 2021 09:22:23 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 47b42570-a71b-4e33-a24b-ac10ddf1490b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-transfer-encoding:content-language;
        bh=S7yyp2qFQz4XjR6Xg0wRYG3/mZcFGWBVQXaug5nBNX4=;
        b=iuUkkMlBv93ZOz65zAc2aAX4vGAVVxDMPtS0dGi3k1AJtQnt5iyuo+i/EB6cF+f0t+
         yd/kxAkNaj3RkHmJgYVoaOuasDgTXxdgNn7M1WthxZnLZ2JzmZpzJpIVT49gdJ1l/SAK
         s00PqmKdk+20iqmCUCKXdAAdDUVRsBDTLdNnjl1ewnrdqTFFDQZifzC219dSKR8S+bxK
         +rpeRoeBSWa/3grguCjFCXtsZ1XqcrkKMbRIQeQ47bhftZ/8b1jD32i6gBXeqzQwGr9m
         tgfBLsDP3JUjwaskm8Wj3REyw8yme9YjMcisnz03SCBFZDMJkFEpyqMGdnQAzUDF5ce2
         qPyA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding
         :content-language;
        bh=S7yyp2qFQz4XjR6Xg0wRYG3/mZcFGWBVQXaug5nBNX4=;
        b=qiPqzHqN7A4ZvsKVXZOYoanHvETrpwm/X4IzeKrIAjhgJQZwgf/1YlSqIqNFUEiqcx
         CscOnAXjZpifz3V6GNY6lJGVV5MspXskYLypHEhGCQBem6YfMG/A5eTTH9O8hC+rFihZ
         N0sPqL+mbw7pTRBHx4MsOgYg4wMolKDL2gskEI48W6qDgAqBYtN0BUJLBIX68ZGsyq0C
         srU7vpS/sQaudAYmhNNVKiHjSeElPgYqLjePHBWVr2MfLL4lF+rjNaplnuHT0ZaEKF0l
         lQe4Mx/V6zFA94mGR+ex9mz9xNX+LnHcdwpyNTEAo2cNRk8hyaQ6NxA7q7UW5raXWBDB
         oW1w==
X-Gm-Message-State: AOAM530+1wv+uPK+RfcEL+06ujdreOEiBPknR6LjUepsTacqq0UWYnzw
	OCP4P9YTg9l6lTon6wV464g=
X-Google-Smtp-Source: ABdhPJxXEvEM8nX4MPC9HnpMO/o5QPZqVVKtAZAWjjMOnBSEbPvZXUZCaQCoLdtzHOS05VSvg89LhQ==
X-Received: by 2002:a05:6000:1885:: with SMTP id a5mr7632935wri.64.1634228544151;
        Thu, 14 Oct 2021 09:22:24 -0700 (PDT)
Subject: Re: [future abi] [RFC PATCH V3] xen/gnttab: Store frame GFN in struct
 page_info on Arm
To: xen-devel@lists.xenproject.org
Cc: Julien Grall <julien@xen.org>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Jan Beulich <jbeulich@suse.com>, Wei Liu <wl@xen.org>
References: <1632425551-18910-1-git-send-email-olekstysh@gmail.com>
 <de92ab24-a9f0-8f3b-e721-e0465e4dc065@citrix.com>
 <YU2PT4rUts8KljKe@MacBook-Air-de-Roger.local>
 <04400e18-dde2-4b90-4056-f56c5d7937af@xen.org>
 <YU34dsl4cSCBbfrk@MacBook-Air-de-Roger.local>
 <547aff1d-d9dd-c7a5-bfeb-fb6aaa011051@xen.org>
From: Oleksandr <olekstysh@gmail.com>
Message-ID: <c596c58d-4ff3-0313-9ec2-7fe1acb37502@gmail.com>
Date: Thu, 14 Oct 2021 19:22:22 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <547aff1d-d9dd-c7a5-bfeb-fb6aaa011051@xen.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US


Hello, all.

The potential issue on Arm (which might happen when remapping 
grant-table frame) is still present, it hasn't disappeared.
Some effort was put in trying to fix that by current patch. Although I 
have addressed (I hope) all review comments received for this patch, I 
realize this patch (in its current form) cannot go in without resolving 
locking issue I described in a post-commit message (we don't want to 
make things worse than the current state). I would appreciate any 
thoughts regarding that.


On 25.09.21 04:48, Julien Grall wrote:
> Hi Roger,
>
> On 24/09/2021 21:10, Roger Pau Monné wrote:
>> On Fri, Sep 24, 2021 at 07:52:24PM +0500, Julien Grall wrote:
>>> Hi Roger,
>>>
>>> On 24/09/2021 13:41, Roger Pau Monné wrote:
>>>> On Thu, Sep 23, 2021 at 09:59:26PM +0100, Andrew Cooper wrote:
>>>>> On 23/09/2021 20:32, Oleksandr Tyshchenko wrote:
>>>>>> Suggested-by: Julien Grall <jgrall@amazon.com>
>>>>>> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>>>>>> ---
>>>>>> You can find the related discussions at:
>>>>>> https://lore.kernel.org/xen-devel/93d0df14-2c8a-c2e3-8c51-54412190171c@xen.org/ 
>>>>>>
>>>>>> https://lore.kernel.org/xen-devel/1628890077-12545-1-git-send-email-olekstysh@gmail.com/ 
>>>>>>
>>>>>> https://lore.kernel.org/xen-devel/1631652245-30746-1-git-send-email-olekstysh@gmail.com/ 
>>>>>>
>>>>>>
>>>>>> ! Please note, there is still unresolved locking question here 
>>>>>> for which
>>>>>> I failed to find a suitable solution. So, it is still an RFC !
>>>>>
>>>>> Just FYI, I thought I'd share some of the plans for ABI v2.  
>>>>> Obviously
>>>>> these plans are future work and don't solve the current problem.
>>>>>
>>>>> Guests mapping Xen pages is backwards.  There are reasons why it was
>>>>> used for x86 PV guests, but the entire interface should have been 
>>>>> design
>>>>> differently for x86 HVM.
>>>>>
>>>>> In particular, Xen should be mapping guest RAM, rather than the guest
>>>>> manipulating the 2nd stage tables to map Xen RAM.  Amongst other 
>>>>> things,
>>>>> its far far lower overhead.
>>>>>
>>>>>
>>>>> A much better design is one where the grant table looks like an MMIO
>>>>> device.  The domain builder decides the ABI (v1 vs v2 - none of this
>>>>> dynamic switch at runtime nonsense), and picks a block of guest 
>>>>> physical
>>>>> addresses, which are registered with Xen.  This forms the grant 
>>>>> table,
>>>>> status table (v2 only), and holes to map into.
>>>>
>>>> I think this could be problematic for identity mapped Arm dom0, as
>>>> IIRC in that case grants are mapped so that gfn == mfn in order to
>>>> account for the lack of an IOMMU. You could use a bounce buffer, but
>>>> that would introduce a big performance penalty.
>>>
>>> Or you could find a hole that is outside of the RAM regions. This is 
>>> not
>>> trivial but not impossible (see [1]).
>>
>> I certainly not familiar with the Arm identity map.
>>
>> If you map them at random areas (so no longer identity mapped), how do
>> you pass the addresses to the physical devices for DMA operations? I
>> assume there must be some kind of translation then that converts from
>> gfn to mfn in order to cope with the lack of an IOMMU, 
>
> For grant mapping, the hypercall will return the machine address in 
> dev_bus_addr. Dom0, will keep the conversion dom0 GFN <-> MFN for 
> later use in the swiotlb.
>
> For foreign mapping, AFAICT, we are expecting them to bounce 
> everytime. But DMA into a foreign mapping should be rarer.
>
>> and because
>> dom0 doesn't know the mfn of the grant reference in order to map it at
>> the same gfn.
>
> IIRC, we tried an approach where the grant mapping would be direct 
> mapped in dom0. However, this was an issue on arm32 because Debian was 
> (is?) using short descriptor page tables. This didn't allow dom0 to 
> cover all the mappings and therefore some mappings would not be 
> accessible.
>
-- 
Regards,

Oleksandr Tyshchenko



From xen-devel-bounces@lists.xenproject.org Thu Oct 14 17:09:46 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Oct 2021 17:09:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.209524.366007 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mb4ES-0006bL-Tf; Thu, 14 Oct 2021 17:09:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 209524.366007; Thu, 14 Oct 2021 17:09:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mb4ES-0006bE-Qc; Thu, 14 Oct 2021 17:09:28 +0000
Received: by outflank-mailman (input) for mailman id 209524;
 Thu, 14 Oct 2021 17:09:27 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=iCUr=PC=arm.com=Bertrand.Marquis@srs-us1.protection.inumbo.net>)
 id 1mb4EQ-0006b8-RO
 for xen-devel@lists.xenproject.org; Thu, 14 Oct 2021 17:09:27 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com (unknown
 [2a01:111:f400:7d00::618])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 47b437a1-8a99-42f4-a886-2ecd74e4c965;
 Thu, 14 Oct 2021 17:09:24 +0000 (UTC)
Received: from DU2PR04CA0257.eurprd04.prod.outlook.com (2603:10a6:10:28e::22)
 by PR2PR08MB4668.eurprd08.prod.outlook.com (2603:10a6:101:1e::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16; Thu, 14 Oct
 2021 17:09:21 +0000
Received: from DB5EUR03FT030.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:10:28e:cafe::7c) by DU2PR04CA0257.outlook.office365.com
 (2603:10a6:10:28e::22) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15 via Frontend
 Transport; Thu, 14 Oct 2021 17:09:21 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT030.mail.protection.outlook.com (10.152.20.144) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.15 via Frontend Transport; Thu, 14 Oct 2021 17:09:21 +0000
Received: ("Tessian outbound 16951d3c485e:v103");
 Thu, 14 Oct 2021 17:09:21 +0000
Received: from 1861f38ef180.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 D166E6F2-03F4-481B-822F-9EC77E4B953D.1; 
 Thu, 14 Oct 2021 17:09:15 +0000
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 1861f38ef180.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Thu, 14 Oct 2021 17:09:15 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com (2603:10a6:4:74::9)
 by DBBPR08MB5964.eurprd08.prod.outlook.com (2603:10a6:10:20c::21) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.14; Thu, 14 Oct
 2021 17:09:13 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955]) by DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955%4]) with mapi id 15.20.4587.030; Thu, 14 Oct 2021
 17:09:13 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 47b437a1-8a99-42f4-a886-2ecd74e4c965
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=FmhQBTVvUuyxXV7WXVw/cvM6vkj3esMFCHh/mnXRJis=;
 b=jKzO4aCvyi+4EisriUD3NOIeNDjvvyohNL5HppUjg6qz+ofXsqa3RZeeCOmFBJgwEacpOjzzedB10vfYHuR85YbaYylxguP97DBlIqIBjcFXfL3W7i4pVHr8NBH53cxtA1L5fWrVwMYp2SY3ADrQUXOIN9orOmx5mU6Hsow5K3s=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: fea2fa26f0415de6
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=PzEJYANeVw391c3efRAmOo1eTaq4WWXTh2hQQikgF9GWEtSPLMo4z78K4jSf3c8lMocd11bXghDsdrEoh0FPRn+0X5pT6WNmSX2G4QF8+8tThuDpNs3A9whP/n416ND3Nx+jVwfN1WyDS/3hvqCpworCmDdYWU47SbwipkrIVgLSvEe5SJ9ky7CzwBAJC3lKu20l5Af4fOElFjAMh7212ASQg9LgxtajgA55xLx78VLOJDcCa9NhBCMVWCSrMi9f2HpdgadsC05L6h5LLeElV6T/MmSPWTvKe56xD5wfGxcaO7UGNVna3Ef0qPSmIAnipQL9mvCD5qxLgnMi2MJwCA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=FmhQBTVvUuyxXV7WXVw/cvM6vkj3esMFCHh/mnXRJis=;
 b=dP3BGXSxmuzXLSHTJecwjh0ZIvmMJFMi1/eDxfhYstFTDjY+ojYd2kidFv7Bn+DQv6DXf8T7nZeD4K+2ut6B1+tOhNfFoUB2YUj13gJ8DY6SQs6hAmf/RJC3MokR9gJ1tu6KC8QKG5LlKI9i+Gd0oRqPZjwlcLJlqOKfDB74LAZk7L5qGMc1T4TmqZX2TusDhdxpHUNj58LhNdE6yaTPfcz8RNVH8MK/qpD6zfToHVWp85sQKHaabrCNNoNutbhu9JLVD6RyrSloxhmvaXVfPATIUVxixwbR8Qgph5uyWpOwPah9lc+zx/3p/sJTNoFHdhSuqhvmZRa/KNNQDqcV6g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=FmhQBTVvUuyxXV7WXVw/cvM6vkj3esMFCHh/mnXRJis=;
 b=jKzO4aCvyi+4EisriUD3NOIeNDjvvyohNL5HppUjg6qz+ofXsqa3RZeeCOmFBJgwEacpOjzzedB10vfYHuR85YbaYylxguP97DBlIqIBjcFXfL3W7i4pVHr8NBH53cxtA1L5fWrVwMYp2SY3ADrQUXOIN9orOmx5mU6Hsow5K3s=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Ian Jackson <iwj@xenproject.org>, Paul Durrant <paul@xen.org>, Andrew
 Cooper <andrew.cooper3@citrix.com>, =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?=
	<roger.pau@citrix.com>, Wei Liu <wl@xen.org>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v6 1/3] xen/vpci: Move ecam access functions to common
 code
Thread-Topic: [PATCH v6 1/3] xen/vpci: Move ecam access functions to common
 code
Thread-Index: AQHXwQraA42SZeh0QUGI/xX7keuWA6vSqLgAgAARnQA=
Date: Thu, 14 Oct 2021 17:09:13 +0000
Message-ID: <6C71E132-0A78-4DA4-AA52-E62833912145@arm.com>
References: <cover.1634221830.git.bertrand.marquis@arm.com>
 <ced6f870dbfabcfe8584555cc80f9a37a0655a0c.1634221830.git.bertrand.marquis@arm.com>
 <20c73f4e-5a8b-c127-f3a7-b841f50b1a4a@suse.com>
In-Reply-To: <20c73f4e-5a8b-c127-f3a7-b841f50b1a4a@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3654.120.0.1.13)
Authentication-Results-Original: suse.com; dkim=none (message not signed)
 header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: 376e9490-87fd-45e5-da00-08d98f355d94
x-ms-traffictypediagnostic: DBBPR08MB5964:|PR2PR08MB4668:
X-Microsoft-Antispam-PRVS:
	<PR2PR08MB4668342325EF4E02222C5E259DB89@PR2PR08MB4668.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:10000;OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 ZgY3JtzxnW/1O+m6Oef0T6oCDHFMnvnOIMq7SyFbLPstkyXXILN6PfXJGKyTvLS59jdPUqnayiAE2xB7Jb8fQ1gh2474NVla7fGoDoMw5FzEMVnX9E4bOzNkxzKpkbGzt9dr3yxDJ3DjI0FrsYBxUHfPSDsCY9XghRAYrYy06hL8xTzHIlfJCqyC7rHNEgU6nQG8wXlLf58tMFz7PN3VYooYja+9TSBA2QiXKN+9imn5lHNTRuPProObLQ2vloWIzMv5GgK4cil1W7Zg7PcHG/xhYq97He/df/uMHACCzkiXoWGEia1bPRXQzLAgPZNywrUMNMDtIDj8Z6Ozt0jxwIz9N/azbg1+ohYYjbZhUj23nMbUm/iLg18MlSy51XT10RKhl+Dp0yVe8LeJ9Z/jTGHSG+dfPqA13rqfJIp7S/c8kd8RMPbI+xWEUfYe2FhtrgIjux8kXfZUWAcK0OtV1xlEE7E0uyk72NIYNN/tglNfak6ww1ruhuSDD06+RXxU8bNrsP1sAw9Rq6EYRfyIfn6QNa/2zepT1oixyQrUnmfdDvOEQeuoejUb2KqLgRley9StLEB4w4YNJW9TBAjHqjmtVXs526cdWMVeB8sOOnZcCuB+mvbA7OO1MWHOaJ+AhhhqtdUS5jr5s24O7JYPAtzwVlTbLE1+E9dF/5qh1bn/qiDMIY40FEBfa+6K/hBCFTxEkaq3HR8R7aVQxI6667FXY8y2D0htGsc2jC5lgWmxmsejc94R9qCZnOtz8vC9
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB6PR0801MB2024.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(5660300002)(186003)(64756008)(66556008)(6512007)(26005)(66446008)(66476007)(83380400001)(122000001)(91956017)(2616005)(71200400001)(76116006)(66946007)(6486002)(508600001)(2906002)(4326008)(33656002)(86362001)(38100700002)(316002)(6916009)(36756003)(54906003)(53546011)(8676002)(6506007)(8936002)(38070700005)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="utf-8"
Content-ID: <80053813B4DE8A44936E959605BC24DD@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB5964
Original-Authentication-Results: suse.com; dkim=none (message not signed)
 header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT030.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	50fb1412-8416-4673-6b18-08d98f3558d5
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	KxdNZeE6m59fAHHMOCz1aCC3gC2KxPDGLbwTgIHEn/EimcgLCL5pAxc+mVxK/xo1t4/pgZ9qP8URG9JScZzrs61ESO3p++yxt2QxoeZG/PQOi+Iw1Cdf+DzGNNaEZzkyiBfZY6zu0LX2hurWSPWMk8RucpFPeBj3Y30YYcOXHUdgJXpreW/kVbrlQFg0qKJGunhge7cI/yO3P6jyMJKn1XTzxfEGi+NkonY3+yDlw4Hvh6+lrHIbp0wNvCSowtr3+gEloXNAtwW6D1C/FMj0MicJIz4Ps59HBrc9hcbhj8SkxxVEdadG19B+JcheQf30RirXHeEZ59CI7ldylDrIPDM1zWh3ORrE5eNGgB5xa3/Xlx3TQLK+nclhWXEW/mifgISnRc0gJ+MwPcltwlqaUsWUaRlNHkaqr468M5dbuokfzApQe6/mfzyvhloBwW1y36ob3wCQaFwkz5yCp3QoUPgfOKfV2dJlZE4XYvyz7xPHOVqAUlwd4PtimgeFlpn1VQpYF36ucmEH7hka709dpRAjo8Bxviu15AyX0xG4NofPEfER+Rz3pPb05Kyar0OnQ9wfAnlZOdkqikOBRPcQfl82EFrZb08IyQjgovVTMtx+7JwKihA+lyd2bLv7bBPMbphb8IwkZfj8vZLjWshVN/qdwUAoTr5VYzHRZ54bzKQkAe28/DWKYJ0+aIM/t9f0G3mkww2SvmAugS8mP44zMg==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(8676002)(2906002)(5660300002)(2616005)(53546011)(54906003)(26005)(508600001)(316002)(8936002)(47076005)(33656002)(6506007)(83380400001)(82310400003)(86362001)(70206006)(36860700001)(186003)(81166007)(336012)(70586007)(6862004)(6512007)(356005)(4326008)(6486002)(36756003);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2021 17:09:21.5630
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 376e9490-87fd-45e5-da00-08d98f355d94
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT030.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR2PR08MB4668

SGkgSmFuLA0KDQo+IE9uIDE0IE9jdCAyMDIxLCBhdCAxNzowNiwgSmFuIEJldWxpY2ggPGpiZXVs
aWNoQHN1c2UuY29tPiB3cm90ZToNCj4gDQo+IE9uIDE0LjEwLjIwMjEgMTY6NDksIEJlcnRyYW5k
IE1hcnF1aXMgd3JvdGU6DQo+PiBAQCAtMzA1LDcgKzI5MSw3IEBAIHN0YXRpYyBpbnQgdnBjaV9w
b3J0aW9fcmVhZChjb25zdCBzdHJ1Y3QgaHZtX2lvX2hhbmRsZXIgKmhhbmRsZXIsDQo+PiANCj4+
ICAgICByZWcgPSBodm1fcGNpX2RlY29kZV9hZGRyKGNmOCwgYWRkciwgJnNiZGYpOw0KPj4gDQo+
PiAtICAgIGlmICggIXZwY2lfYWNjZXNzX2FsbG93ZWQocmVnLCBzaXplKSApDQo+PiArICAgIGlm
ICggIXZwY2lfZWNhbV9hY2Nlc3NfYWxsb3dlZChyZWcsIHNpemUpICkNCj4+ICAgICAgICAgcmV0
dXJuIFg4NkVNVUxfT0tBWTsNCj4+IA0KPj4gICAgICpkYXRhID0gdnBjaV9yZWFkKHNiZGYsIHJl
Zywgc2l6ZSk7DQo+PiBAQCAtMzM1LDcgKzMyMSw3IEBAIHN0YXRpYyBpbnQgdnBjaV9wb3J0aW9f
d3JpdGUoY29uc3Qgc3RydWN0IGh2bV9pb19oYW5kbGVyICpoYW5kbGVyLA0KPj4gDQo+PiAgICAg
cmVnID0gaHZtX3BjaV9kZWNvZGVfYWRkcihjZjgsIGFkZHIsICZzYmRmKTsNCj4+IA0KPj4gLSAg
ICBpZiAoICF2cGNpX2FjY2Vzc19hbGxvd2VkKHJlZywgc2l6ZSkgKQ0KPj4gKyAgICBpZiAoICF2
cGNpX2VjYW1fYWNjZXNzX2FsbG93ZWQocmVnLCBzaXplKSApDQo+PiAgICAgICAgIHJldHVybiBY
ODZFTVVMX09LQVk7DQo+PiANCj4+ICAgICB2cGNpX3dyaXRlKHNiZGYsIHJlZywgc2l6ZSwgZGF0
YSk7DQo+IA0KPiBXaHkgd291bGQgcG9ydCBJL08gZnVuY3Rpb25zIGNhbGwgYW4gRUNBTSBoZWxw
ZXI/IEFuZCBpbiBob3cgZmFyIGlzDQo+IHRoYXQgaGVscGVyIGFjdHVhbGx5IEVDQU0tc3BlY2lm
aWM/DQoNClRoZSBmdW5jdGlvbiB3YXMgZ2xvYmFsIGJlZm9yZS4NCg0KPiANCj4+IEBAIC00MzQs
MjUgKzQyMCw4IEBAIHN0YXRpYyBpbnQgdnBjaV9tbWNmZ19yZWFkKHN0cnVjdCB2Y3B1ICp2LCB1
bnNpZ25lZCBsb25nIGFkZHIsDQo+PiAgICAgcmVnID0gdnBjaV9tbWNmZ19kZWNvZGVfYWRkciht
bWNmZywgYWRkciwgJnNiZGYpOw0KPj4gICAgIHJlYWRfdW5sb2NrKCZkLT5hcmNoLmh2bS5tbWNm
Z19sb2NrKTsNCj4+IA0KPj4gLSAgICBpZiAoICF2cGNpX2FjY2Vzc19hbGxvd2VkKHJlZywgbGVu
KSB8fA0KPj4gLSAgICAgICAgIChyZWcgKyBsZW4pID4gUENJX0NGR19TUEFDRV9FWFBfU0laRSAp
DQo+PiAtICAgICAgICByZXR1cm4gWDg2RU1VTF9PS0FZOw0KPiANCj4gV2hpbGUgSSBhc3N1bWUg
dGhpcyBlYXJsaWVyIGJlaGF2aW9yIGlzIHRoZSByZWFzb24gZm9yIC4uLg0KDQpZZXMgOi0pDQoN
Cj4gDQo+PiAtICAgIC8qDQo+PiAtICAgICAqIEFjY29yZGluZyB0byB0aGUgUENJZSAzLjFBIHNw
ZWNpZmljYXRpb246DQo+PiAtICAgICAqICAtIENvbmZpZ3VyYXRpb24gUmVhZHMgYW5kIFdyaXRl
cyBtdXN0IHVzdWFsbHkgYmUgRFdPUkQgb3Igc21hbGxlcg0KPj4gLSAgICAgKiAgICBpbiBzaXpl
Lg0KPj4gLSAgICAgKiAgLSBCZWNhdXNlIFJvb3QgQ29tcGxleCBpbXBsZW1lbnRhdGlvbnMgYXJl
IG5vdCByZXF1aXJlZCB0byBzdXBwb3J0DQo+PiAtICAgICAqICAgIGFjY2Vzc2VzIHRvIGEgUkNS
QiB0aGF0IGNyb3NzIERXIGJvdW5kYXJpZXMgWy4uLl0gc29mdHdhcmUNCj4+IC0gICAgICogICAg
c2hvdWxkIHRha2UgY2FyZSBub3QgdG8gY2F1c2UgdGhlIGdlbmVyYXRpb24gb2Ygc3VjaCBhY2Nl
c3Nlcw0KPj4gLSAgICAgKiAgICB3aGVuIGFjY2Vzc2luZyBhIFJDUkIgdW5sZXNzIHRoZSBSb290
IENvbXBsZXggd2lsbCBzdXBwb3J0IHRoZQ0KPj4gLSAgICAgKiAgICBhY2Nlc3MuDQo+PiAtICAg
ICAqICBYZW4gaG93ZXZlciBzdXBwb3J0cyA4Ynl0ZSBhY2Nlc3NlcyBieSBzcGxpdHRpbmcgdGhl
bSBpbnRvIHR3bw0KPj4gLSAgICAgKiAgNGJ5dGUgYWNjZXNzZXMuDQo+PiAtICAgICAqLw0KPj4g
LSAgICAqZGF0YSA9IHZwY2lfcmVhZChzYmRmLCByZWcsIG1pbig0dSwgbGVuKSk7DQo+PiAtICAg
IGlmICggbGVuID09IDggKQ0KPj4gLSAgICAgICAgKmRhdGEgfD0gKHVpbnQ2NF90KXZwY2lfcmVh
ZChzYmRmLCByZWcgKyA0LCA0KSA8PCAzMjsNCj4+ICsgICAgLyogSWdub3JlIHJldHVybiBjb2Rl
ICovDQo+PiArICAgIHZwY2lfZWNhbV9tbWlvX3JlYWQoc2JkZiwgcmVnLCBsZW4sIGRhdGEpOw0K
PiANCj4gLi4uIHRoZSBjb21tZW50ZWQtdXBvbiBpZ25vcmluZyBvZiB0aGUgcmV0dXJuIHZhbHVl
LCBJIGRvbid0IHRoaW5rDQo+IHRoYXQncyBhIGdvb2Qgd2F5IHRvIGRlYWwgd2l0aCB0aGluZ3Mg
YW55bW9yZS4gSW5zdGVhZCBJIHRoaW5rDQo+ICpkYXRhIHNob3VsZCBiZSB3cml0dGVuIHRvIH4w
IHVwb24gZmFpbHVyZSwgdW5sZXNzIGl0IGlzIGludGVuZGVkDQo+IGZvciB2cGNpX2VjYW1fbW1p
b19yZWFkKCkgdG8gdGFrZSBjYXJlIG9mIHRoYXQgY2FzZSAoaW4gd2hpY2ggY2FzZQ0KPiBJJ20g
bm90IHN1cmUgSSB3b3VsZCBzZWUgd2h5IGl0IG5lZWRzIHRvIHJldHVybiBhbiBlcnJvciBpbmRp
Y2F0b3INCj4gaW4gdGhlIGZpcnN0IHBsYWNlKS4NCg0KSSBhbSBub3Qgc3VyZSBpbiB0aGUgZmly
c3QgcGxhY2Ugd2h5IHRoaXMgaXMgYWN0dWFsbHkgaWdub3JlZCBhbmQganVzdA0KcmV0dXJuaW5n
IGEgLTEgdmFsdWUuDQpJZiBhbiBhY2Nlc3MgaXMgbm90IHJpZ2h0LCBhbiBleGNlcHRpb24gc2hv
dWxkIGJlIGdlbmVyYXRlZCB0byB0aGUNCkd1ZXN0IGluc3RlYWQuDQpXaGVuIHdlIGRvIHRoYXQg
b24gYXJtIHRoZSBmdW5jdGlvbiBpcyByZXR1cm5pbmcgYW4gZXJyb3IgdG8gdGhlIHVwcGVyDQps
YXllciBpbiB0aGF0IGNhc2UsIHRoYXTigJlzIHdoeSBJIGRpZCBrZWVwIGEgZ2VuZXJpYyBmdW5j
dGlvbiBpbmZvcm1pbmcgdGhlDQpjYWxsZXIuDQoNClNvIEkgdGhpbmsgaXQgaXMgcmlnaHQgZm9y
IHRoZSBmdW5jdGlvbiB0byByZXR1cm4gYW4gZXJyb3IgaWYgdGhlIGFjY2VzcyBpcyBub3QgYWxs
b3dlZCBidXQgSSBhZ3JlZSB0aGUgY29tbWVudCBvbiB4ODYgY291bGQgZ2V0IGEgYmV0dGVyIGp1
c3RpZmljYXRpb24uDQpAUm9nZXI6IGNvdWxkIHlvdSBoZWxwIGZpbmRpbmcgb25lIGhlcmUgYXMg
SSBkbyBub3QgcXVpdGUgdW5kZXJzdGFuZCB3aHkgaXQgaXMgb2sgdG8gaWdub3JlIHRoaXMgY2Fz
ZSA/DQoNCj4gDQo+PiBAQCAtNDc2LDEzICs0NDUsOCBAQCBzdGF0aWMgaW50IHZwY2lfbW1jZmdf
d3JpdGUoc3RydWN0IHZjcHUgKnYsIHVuc2lnbmVkIGxvbmcgYWRkciwNCj4+ICAgICByZWcgPSB2
cGNpX21tY2ZnX2RlY29kZV9hZGRyKG1tY2ZnLCBhZGRyLCAmc2JkZik7DQo+PiAgICAgcmVhZF91
bmxvY2soJmQtPmFyY2guaHZtLm1tY2ZnX2xvY2spOw0KPj4gDQo+PiAtICAgIGlmICggIXZwY2lf
YWNjZXNzX2FsbG93ZWQocmVnLCBsZW4pIHx8DQo+PiAtICAgICAgICAgKHJlZyArIGxlbikgPiBQ
Q0lfQ0ZHX1NQQUNFX0VYUF9TSVpFICkNCj4+IC0gICAgICAgIHJldHVybiBYODZFTVVMX09LQVk7
DQo+PiAtDQo+PiAtICAgIHZwY2lfd3JpdGUoc2JkZiwgcmVnLCBtaW4oNHUsIGxlbiksIGRhdGEp
Ow0KPj4gLSAgICBpZiAoIGxlbiA9PSA4ICkNCj4+IC0gICAgICAgIHZwY2lfd3JpdGUoc2JkZiwg
cmVnICsgNCwgNCwgZGF0YSA+PiAzMik7DQo+PiArICAgIC8qIElnbm9yZSByZXR1cm4gY29kZSAq
Lw0KPj4gKyAgICB2cGNpX2VjYW1fbW1pb193cml0ZShzYmRmLCByZWcsIGxlbiwgZGF0YSk7DQo+
IA0KPiBIZXJlIGlnbm9yaW5nIGlzIGZpbmUgaW1vLCBidXQgaWYgeW91IGZlZWwgaXQgaXMgaW1w
b3J0YW50IHRvDQo+IGNvbW1lbnQgb24gdGhpcywgdGhlbiBJIHRoaW5rIHlvdSBuZWVkIHRvIHBy
ZWZlciAid2h5IiBvdmVyICJ3aGF0Ii4NCg0KQWdyZWUgSSB3b3VsZCBqdXN0IG5lZWQgc29tZSBo
ZWxwIG9uIHRoZSB3aHkuDQpOb3cgdGhlcmUgd2FzIG5vIGNvbW1lbnQgYmVmb3JlIHRvIGV4cGxh
aW4gd2h5IHNvIEkgY291bGQgYWxzbw0KcmVtb3ZlIHRoZSBjb21tZW50IGFsdG9nZXRoZXIuDQoN
Cj4gDQo+PiAtLS0gYS94ZW4vZHJpdmVycy92cGNpL3ZwY2kuYw0KPj4gKysrIGIveGVuL2RyaXZl
cnMvdnBjaS92cGNpLmMNCj4+IEBAIC00NzgsNiArNDc4LDY2IEBAIHZvaWQgdnBjaV93cml0ZShw
Y2lfc2JkZl90IHNiZGYsIHVuc2lnbmVkIGludCByZWcsIHVuc2lnbmVkIGludCBzaXplLA0KPj4g
ICAgIHNwaW5fdW5sb2NrKCZwZGV2LT52cGNpLT5sb2NrKTsNCj4+IH0NCj4+IA0KPj4gKy8qIEhl
bHBlciBmdW5jdGlvbiB0byBjaGVjayBhbiBhY2Nlc3Mgc2l6ZSBhbmQgYWxpZ25tZW50IG9uIHZw
Y2kgc3BhY2UuICovDQo+PiArYm9vbCB2cGNpX2VjYW1fYWNjZXNzX2FsbG93ZWQodW5zaWduZWQg
aW50IHJlZywgdW5zaWduZWQgaW50IGxlbikNCj4+ICt7DQo+PiArICAgIC8qDQo+PiArICAgICAq
IENoZWNrIGFjY2VzcyBzaXplLg0KPj4gKyAgICAgKg0KPj4gKyAgICAgKiBPbiBhcm0zMiBvciBm
b3IgMzJiaXQgZ3Vlc3RzIG9uIGFybSwgNjRiaXQgYWNjZXNzZXMgc2hvdWxkIGJlIGZvcmJpZGRl
bg0KPj4gKyAgICAgKiBidXQgYXMgZm9yIHRob3NlIHBsYXRmb3JtIElTViByZWdpc3Rlciwgd2hp
Y2ggZ2l2ZXMgdGhlIGFjY2VzcyBzaXplLA0KPj4gKyAgICAgKiBjYW5ub3QgaGF2ZSBhIHZhbHVl
IDMsIGNoZWNraW5nIHRoaXMgd291bGQganVzdCBoYXJkZW4gdGhlIGNvZGUuDQo+PiArICAgICAq
Lw0KPj4gKyAgICBpZiAoIGxlbiAhPSAxICYmIGxlbiAhPSAyICYmIGxlbiAhPSA0ICYmIGxlbiAh
PSA4ICkNCj4+ICsgICAgICAgIHJldHVybiBmYWxzZTsNCj4gDQo+IEknbSBub3QgY29udmluY2Vk
IHRhbGtpbmcgYWJvdXQgQXJtIHNwZWNpZmljYWxseSBoZXJlIGlzDQo+IHdhcnJhbnRlZCwgdW5s
ZXNzIHRoZXJlJ3Mgc29tZXRoaW5nIHRoZXJlIHRoYXQncyBjbGVhcmx5DQo+IGRpZmZlcmVudCBm
cm9tIGFsbCBvdGhlciBhcmNoaXRlY3R1cmVzLiBPdGhlcndpc2UgdGhlIGNvbW1lbnQNCj4gc2hv
dWxkIGltbyBiZSB3cml0dGVuIGluIG1vcmUgZ2VuZXJhbCB0ZXJtcy4NCg0KT3RoZXIgYXJjaGl0
ZWN0dXJlcyBtaWdodCBhbGxvdyB0aGlzIGNhc2UuIFNvIHRoaXMgaXMgc3BlY2lmaWMgdG8gQXJt
Lg0KDQo+IA0KPj4gK2ludCB2cGNpX2VjYW1fbW1pb193cml0ZShwY2lfc2JkZl90IHNiZGYsIHVu
c2lnbmVkIGludCByZWcsIHVuc2lnbmVkIGludCBsZW4sDQo+PiArICAgICAgICAgICAgICAgICAg
ICAgICAgIHVuc2lnbmVkIGxvbmcgZGF0YSkNCj4+ICt7DQo+PiArICAgIGlmICggIXZwY2lfZWNh
bV9hY2Nlc3NfYWxsb3dlZChyZWcsIGxlbikgfHwNCj4+ICsgICAgICAgICAocmVnICsgbGVuKSA+
IFBDSV9DRkdfU1BBQ0VfRVhQX1NJWkUgKQ0KPj4gKyAgICAgICAgcmV0dXJuIDA7DQo+PiArDQo+
PiArICAgIHZwY2lfd3JpdGUoc2JkZiwgcmVnLCBtaW4oNHUsIGxlbiksIGRhdGEpOw0KPj4gKyAg
ICBpZiAoIGxlbiA9PSA4ICkNCj4+ICsgICAgICAgIHZwY2lfd3JpdGUoc2JkZiwgcmVnICsgNCwg
NCwgZGF0YSA+PiAzMik7DQo+PiArDQo+PiArICAgIHJldHVybiAxOw0KPj4gK30NCj4+ICsNCj4+
ICtpbnQgdnBjaV9lY2FtX21taW9fcmVhZChwY2lfc2JkZl90IHNiZGYsIHVuc2lnbmVkIGludCBy
ZWcsIHVuc2lnbmVkIGludCBsZW4sDQo+PiArICAgICAgICAgICAgICAgICAgICAgICAgdW5zaWdu
ZWQgbG9uZyAqZGF0YSkNCj4+ICt7DQo+PiArICAgIGlmICggIXZwY2lfZWNhbV9hY2Nlc3NfYWxs
b3dlZChyZWcsIGxlbikgfHwNCj4+ICsgICAgICAgICAocmVnICsgbGVuKSA+IFBDSV9DRkdfU1BB
Q0VfRVhQX1NJWkUgKQ0KPj4gKyAgICAgICAgcmV0dXJuIDA7DQo+PiArDQo+PiArICAgIC8qDQo+
PiArICAgICAqIEFjY29yZGluZyB0byB0aGUgUENJZSAzLjFBIHNwZWNpZmljYXRpb246DQo+PiAr
ICAgICAqICAtIENvbmZpZ3VyYXRpb24gUmVhZHMgYW5kIFdyaXRlcyBtdXN0IHVzdWFsbHkgYmUg
RFdPUkQgb3Igc21hbGxlcg0KPj4gKyAgICAgKiAgICBpbiBzaXplLg0KPj4gKyAgICAgKiAgLSBC
ZWNhdXNlIFJvb3QgQ29tcGxleCBpbXBsZW1lbnRhdGlvbnMgYXJlIG5vdCByZXF1aXJlZCB0byBz
dXBwb3J0DQo+PiArICAgICAqICAgIGFjY2Vzc2VzIHRvIGEgUkNSQiB0aGF0IGNyb3NzIERXIGJv
dW5kYXJpZXMgWy4uLl0gc29mdHdhcmUNCj4+ICsgICAgICogICAgc2hvdWxkIHRha2UgY2FyZSBu
b3QgdG8gY2F1c2UgdGhlIGdlbmVyYXRpb24gb2Ygc3VjaCBhY2Nlc3Nlcw0KPj4gKyAgICAgKiAg
ICB3aGVuIGFjY2Vzc2luZyBhIFJDUkIgdW5sZXNzIHRoZSBSb290IENvbXBsZXggd2lsbCBzdXBw
b3J0IHRoZQ0KPj4gKyAgICAgKiAgICBhY2Nlc3MuDQo+PiArICAgICAqICBYZW4gaG93ZXZlciBz
dXBwb3J0cyA4Ynl0ZSBhY2Nlc3NlcyBieSBzcGxpdHRpbmcgdGhlbSBpbnRvIHR3bw0KPj4gKyAg
ICAgKiAgNGJ5dGUgYWNjZXNzZXMuDQo+PiArICAgICAqLw0KPj4gKyAgICAqZGF0YSA9IHZwY2lf
cmVhZChzYmRmLCByZWcsIG1pbig0dSwgbGVuKSk7DQo+PiArICAgIGlmICggbGVuID09IDggKQ0K
Pj4gKyAgICAgICAgKmRhdGEgfD0gKHVpbnQ2NF90KXZwY2lfcmVhZChzYmRmLCByZWcgKyA0LCA0
KSA8PCAzMjsNCj4+ICsNCj4+ICsgICAgcmV0dXJuIDE7DQo+PiArfQ0KPiANCj4gV2h5IGRvIHRo
ZXNlIHR3byBmdW5jdGlvbnMgcmV0dXJuIGludC8wLzEgaW5zdGVhZCBvZg0KPiBib29sL2ZhbHNl
L3RydWUgKGFzc3VtaW5nLCBhcyBwZXIgYWJvdmUsIHRoYXQgdGhlbSByZXR1cm5pbmcgbm9uLQ0K
PiB2b2lkIGlzIHdhcnJhbnRlZCBhdCBhbGwpPw0KDQpUaGlzIGlzIHdoYXQgdGhlIG1taW8gaGFu
ZGxlcnMgc2hvdWxkIHJldHVybiB0byBzYXkgdGhhdCBhbiBhY2Nlc3MNCndhcyBvayBvciBub3Qg
c28gdGhlIGZ1bmN0aW9uIHN0aWNrIHRvIHRoaXMgc3RhbmRhcmQuDQoNCj4gDQo+IEFsc28gYm90
aCBvZiB0aGVzZSBmdW5jdGlvbnMgd2lsbCBzaWxlbnRseSBtaXNiZWhhdmUgb24gMzItYml0IGR1
ZSB0bw0KPiB0aGUgdXNlIG9mIHVuc2lnbmVkIGxvbmcgaW4gdGhlIHBhcmFtZXRlciB0eXBlcy4g
SSB0aGluayB5b3Ugd2FudCBlLmcuDQo+IENPTkZJR182NEJJVCBjb25kaXRpb25hbHMgaGVyZSBh
cyB3ZWxsIGFzIGluIHZwY2lfYWNjZXNzX2FsbG93ZWQoKQ0KPiAob21pdHRpbmcgdGhlIHF1ZXN0
aW9uYWJsZSAiZWNhbSIgcGFydCBvZiB0aGUgbmFtZSkgdG8gcmVqZWN0IGxlbiA9PSA4DQo+IHRo
ZXJlIGluIHRoYXQgY2FzZS4NCg0KUmlnaHQgdXNpbmcgQ09ORklHXzY0QklUIGlzIGEgZ29vZCBp
ZGVhIGhlcmUgaW4gZmFjdC4NCkkgY2FuIGRvIHRoYXQgaW4gdGhlIG5leHQgdmVyc2lvbi4NCg0K
PiANCj4gRmluYWxseSwgdG8gbWUsIGhhdmluZyBib3RoICJlY2FtIiBhbmQgIm1taW8iIGluIHRo
ZSBuYW1lcyBmZWVscw0KPiByZWR1bmRhbnQgLSB0aGUgUENJIHNwZWMgZG9lc24ndCBtZW50aW9u
IGFueSBub24tTU1JTyBtZWNoYW5pc20gdGhlcmUNCj4gYWZhaWNzLg0KDQpJIHdhcyB0aGlua2lu
ZyB0aGUgbW1pbyBoZXJlIHN0YW5kcyBtb3JlIGZvciDigJxtbWlvIGhhbmRsZXLigJ0gYXMgdG8g
ZnVuY3Rpb24NCmhhbmRsaW5nIGVtdWxhdGlvbiB0aHJvdWdoIG1taW8gYWNjZXNzLg0KSSBoYXZl
IG5vIG9iamVjdGlvbiB0byByZW1vdmUgdGhlIG1taW8gcGFydCB0aG91Z2guDQoNClJlZ2FyZHMN
CkJlcnRyYW5kDQoNCj4gDQo+IEphbg0KPiANCg0K


From xen-devel-bounces@lists.xenproject.org Thu Oct 14 17:17:13 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Oct 2021 17:17:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.209531.366019 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mb4Lu-000818-PJ; Thu, 14 Oct 2021 17:17:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 209531.366019; Thu, 14 Oct 2021 17:17:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mb4Lu-000811-LX; Thu, 14 Oct 2021 17:17:10 +0000
Received: by outflank-mailman (input) for mailman id 209531;
 Thu, 14 Oct 2021 17:17:09 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=iCUr=PC=arm.com=Bertrand.Marquis@srs-us1.protection.inumbo.net>)
 id 1mb4Lt-00080v-AK
 for xen-devel@lists.xenproject.org; Thu, 14 Oct 2021 17:17:09 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com (unknown
 [2a01:111:f400:fe0e::60f])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id f294c3bb-be5a-4641-ad18-f0cfebacf4d2;
 Thu, 14 Oct 2021 17:17:07 +0000 (UTC)
Received: from AM6PR02CA0009.eurprd02.prod.outlook.com (2603:10a6:20b:6e::22)
 by PAXPR08MB6558.eurprd08.prod.outlook.com (2603:10a6:102:151::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15; Thu, 14 Oct
 2021 17:17:03 +0000
Received: from VE1EUR03FT024.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:6e:cafe::a) by AM6PR02CA0009.outlook.office365.com
 (2603:10a6:20b:6e::22) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.14 via Frontend
 Transport; Thu, 14 Oct 2021 17:17:03 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT024.mail.protection.outlook.com (10.152.18.87) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.15 via Frontend Transport; Thu, 14 Oct 2021 17:17:03 +0000
Received: ("Tessian outbound 8e26f7114b75:v103");
 Thu, 14 Oct 2021 17:17:02 +0000
Received: from 15b934ca11ec.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 D4FBD704-2403-4376-8D0F-6EBFB79A1DB8.1; 
 Thu, 14 Oct 2021 17:16:52 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 15b934ca11ec.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Thu, 14 Oct 2021 17:16:52 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com (2603:10a6:4:74::9)
 by DBBPR08MB5964.eurprd08.prod.outlook.com (2603:10a6:10:20c::21) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.14; Thu, 14 Oct
 2021 17:16:49 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955]) by DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955%4]) with mapi id 15.20.4587.030; Thu, 14 Oct 2021
 17:16:49 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f294c3bb-be5a-4641-ad18-f0cfebacf4d2
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=/PEFSmnXKbM2ASjGXD+a4EcDbofFNB851yvFrkyBjOw=;
 b=AiGFM0IP5MSB0LoGdnJSnwn4Dej4BnRMmHhYrbJT5AroiLMZODruIbPbMV8dbraDoqNnlaKlx5pzhzG9TzZ0srpLZ77luuxz8uOKjs9d/zbQBYNNzN5vPyyLIptAWgf/LaDuibpDkzwhHOSIfXEzekEWFRrw00jsu85vt0rorx4=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 90775082a3286655
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=XYJKfRX9XqICC5ZNhHHXhL9fNdZOpYEdQN28mSi/tdEqJcWo+A8L3kt6oAjN3RpvtjBHTcEeFx7k6HwBjNxMZ1zpK5AU9psBlKiH5OC6GVjXYQhx3kvKxLx3EG/3AuhhJF9ig+nXb8La2++Tlh0gM03exKjGUDy3nvoFVmZg0xb8IQTSUrDLt5Ov6IaUc33bsqjZUBRsN+T6iyJVmTSPgCK2/MJhRehTC7L3Od+cnMyTUy/apv/0X6CqrR+D5KOjRyZ6tLg58VPGSmitadZaBdNSPhyiQrWlVSbh8cZv+jKt/pQnhreZqHQQnvTbef2LcRGAMpr1o36PXTqx4NDclA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=/PEFSmnXKbM2ASjGXD+a4EcDbofFNB851yvFrkyBjOw=;
 b=KgyP+4Yluds7/a92yry6HOdsB0tEYlw4ZEqfRMqBChxAA8oeME4CwNwfF0tXC8ceFViWg0CB5xytoxJjsupDH+Rk5vZ/VJKep+soTlp3gWoo4w4H8qfR6r8VArC+GD4ul8Ruf9gOjETRf+xjijy8erKQz17yFPhPtMOsJTBrIE6Jaa9yj5hnC9UrgJ+zjlk/Hzt61cCAKZCTYM3JB/cR1QoTuotUiOotW95Sl2TFi2lgxzj2bM0ndR3IBL6yJg+fxkwi1iSzrOeBel7u0UTSOSty7gaCM3VNvZLLv28Lrzp/AM74xiohax87YJUrHhombor1HxzHRR7/A8X7Pf0Uew==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=/PEFSmnXKbM2ASjGXD+a4EcDbofFNB851yvFrkyBjOw=;
 b=AiGFM0IP5MSB0LoGdnJSnwn4Dej4BnRMmHhYrbJT5AroiLMZODruIbPbMV8dbraDoqNnlaKlx5pzhzG9TzZ0srpLZ77luuxz8uOKjs9d/zbQBYNNzN5vPyyLIptAWgf/LaDuibpDkzwhHOSIfXEzekEWFRrw00jsu85vt0rorx4=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Ian Jackson <iwj@xenproject.org>
CC: Rahul Singh <Rahul.Singh@arm.com>, Julien Grall <julien@xen.org>,
	xen-devel <xen-devel@lists.xenproject.org>, Andre Przywara
	<Andre.Przywara@arm.com>, Wei Liu <wl@xen.org>, Anthony PERARD
	<anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>, Stefano
 Stabellini <sstabellini@kernel.org>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH v5 10/11] arm/libxl: Emulated PCI device tree node in
 libxl
Thread-Topic: [PATCH v5 10/11] arm/libxl: Emulated PCI device tree node in
 libxl
Thread-Index: AQHXutl6ulaF6M0fM0eW19BgA1BbHavGQpyAgAEa5QCAAE0egIAAC7yAgAsSfAA=
Date: Thu, 14 Oct 2021 17:16:49 +0000
Message-ID: <8A04B9B2-E816-425E-BF1B-5A8B89F8836C@arm.com>
References: <cover.1633540842.git.rahul.singh@arm.com>
 <b81b5dea800c8fe47071f3dbd20588b1e472fb99.1633540842.git.rahul.singh@arm.com>
 <7bdac405-a889-15e1-be19-5876f7253855@xen.org>
 <24926.53690.621007.507249@mariner.uk.xensource.com>
 <294BE20A-7E45-405C-BC19-C292295E85E3@arm.com>
 <24927.7235.736221.270358@mariner.uk.xensource.com>
In-Reply-To: <24927.7235.736221.270358@mariner.uk.xensource.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3654.120.0.1.13)
Authentication-Results-Original: xenproject.org; dkim=none (message not
 signed) header.d=none;xenproject.org; dmarc=none action=none
 header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: 40c99755-c85e-4599-6a50-08d98f3670d6
x-ms-traffictypediagnostic: DBBPR08MB5964:|PAXPR08MB6558:
x-ms-exchange-transport-forked: True
X-Microsoft-Antispam-PRVS:
	<PAXPR08MB65580A799B30BAD4E473EBDB9DB89@PAXPR08MB6558.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:8273;OLM:8273;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 s6IyIYRcPfN9MCH0sRGGaVhOE4vYxpxTvTzaRJisFZbeeb5iBXyVXlaRbQ1W4BXs+oYOAUkypwb12WFgbGgmh0sqMZ4S6RivG6FCuaAz2ahMVPkCfwlSAcbSOq0p+ieNdrf1LQCq1VLMu86l6I5xrNruaW3XzF/bytNGXqaQygvNIA8Et4lf005S3CZzB1Ujgy/eybQmmSdz6gdCFdzXZFc/+vfHCBa47+iqxkf7GupOvuFSGbXV7syJYAhcXe1gSkMgylvV5Pwi4TFuvAnbWCaloYvvwz6Xk0Z3qWXVwsJQSqtUm800VXVoPqTSjsKyiFYis+W3viXBO3nAcRDjcSp6pLb49U+BBU4ifaG2UyMI+N/nVLlMJs8hLXSacQXGdq5qOEA0fofckKOMCN+HxTJbP0kibxCJhU0R9Xp20YJG+e5VmoX6nwT2B1GoT0iCT2+Qqh9GqZS8t/SF3+xB5bbeyl4C4uO94C+V/6czSqAq0IPOFP0EASneR8qHbHEu9/ixc4FCZLhbnfXBP30fiOKLGJzBVHQl2RPJpOubhd62kZcC+mRq7JfDFNGZ2pVOHPUB5CrdN+dhzq7UmR+a0lOH6GKNOy4yK/Sx+d2++/GxiXY2b2x9yBU1wM0b2qcOP7cKskGEXHAjxKlWDS16pMdUwhU/CzT0Ha4juuhiNXbsZmuG17rk04/QXXVyrPScA/ixOSe/mkqr4O5xSprgx7vs302la8ejdBy2dqqrFW80QHLzB1m73bwxO7iVNPFG
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB6PR0801MB2024.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(36756003)(53546011)(8676002)(54906003)(4326008)(2906002)(316002)(6916009)(33656002)(86362001)(38100700002)(8936002)(38070700005)(6506007)(66446008)(26005)(66476007)(186003)(5660300002)(64756008)(66556008)(6512007)(66946007)(508600001)(6486002)(83380400001)(122000001)(71200400001)(76116006)(2616005)(91956017)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="us-ascii"
Content-ID: <B35C0DD0E9908944AAA22077CA50055D@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB5964
Original-Authentication-Results: xenproject.org; dkim=none (message not signed)
 header.d=none;xenproject.org; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT024.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	5c0dc025-a473-4bde-8822-08d98f3668bc
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	CEy9zSmwoPXvlcjQ08fYb0zO40lguEyPPDX2U0ISJq4V/5gSqEVF6hhIRzkC0l4zqvqC5fArzsI3m7s8MmLgr8rhQLQ+sy6FwYjaE5fEdbBpGliAYIFh4AdYprOcox+2yN8vK3cHWdAuiQkP8Ai84/U5SYhH2dhtiPKwEUzjZc1fCDH4Zm31kByklVi0eKHKg6rgjNTzma5qizX1uQkVaYWw7NmIzFYrwoIfxnvqfJR4KroE4/C7xCKGGoTxj3snzZ6Ac4IIZ5X4c1q4zDrc26f9OBYSLuuY0EmfJomm+batdFvJndc7EcvyGdc8naoYyOE8zYe8KeOWe+VzqpNyq3qHlStbIQUuJ+UzMrRVp3fr7QSemPQGj1xqx3OMxIVIOcqYX3dNlr3BV8okV9eIJK6QqJhpGU9paK0erieuBKIRUyEa3tcVdBtBG5YNMZiIyMS1oUh+gAJCm7JlLoEvGMPl1LG8eT738jp0S0PDp4+Ky6KJtui/pPpDPhScVndGWhLWEdgYmvcT/9yGkFZnZoEdAj27veH/Gpp9Ie5dzUllsl6NDQDGRjPV7170Qg483vR5uFebZerUukLutC62HWmw5TVU1XyB4glV7ft2VD1tpCCFnshJR1n7tty9tV4i7fXRbgy1auQdiMLHBA7kbqKR7SpBI9YGji23DJ5pU32uzAU1xeVNIx7+aE1CO6fm6TQ9bz/ugCH49TJpVe5iEQ==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(107886003)(86362001)(33656002)(36860700001)(26005)(54906003)(6512007)(82310400003)(186003)(316002)(6506007)(8936002)(508600001)(53546011)(81166007)(70586007)(70206006)(336012)(5660300002)(8676002)(6862004)(47076005)(4326008)(2906002)(6486002)(356005)(36756003)(83380400001)(2616005);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2021 17:17:03.2642
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 40c99755-c85e-4599-6a50-08d98f3670d6
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT024.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6558

Hi Ian,

> On 7 Oct 2021, at 17:11, Ian Jackson <iwj@xenproject.org> wrote:
>=20
> Rahul Singh writes ("Re: [PATCH v5 10/11] arm/libxl: Emulated PCI device =
tree node in libxl"):
>> As Stefano suggested in another email that we can remove the vpci
>> option, if we reach to conclusion that we need vpci option I will
>> move it to internal structure.
> ...
>> Yes I agree with you VPCI is necessary for hot plugged PCI device
>> and once we implement the hotplug in future we will use the
>> passthrough=3D option to enable VPCI.
>=20
> So, to summarise, I think the situation is:
>=20
> * VCPI is necessry for passthrough on ARM, whether coldplug or
>   hotplug.  It's part of the way that PCI-PT works on ARM.
>=20
> * Hotplug is not yet implemented.
>=20
> * VPCI is not necessary on x86 (evidently, since we don't have it
>   there but we do have passthrough).
>=20
> So when hotplug is added, vpci will need to be turned on when
> passthrough=3Dyes is selected.  I don't fully understand the other
> possible values for passthrough=3D but maybe we can defer the question
> of whether they apply to ARM ?
>=20
> I think that means that yes, this should be an internal variable.
> Probably in libxl__domain_create_state.  We don't currently arrange to
> elide arch-specific state in there, so perhaps it's fine just to
> invent a member called `arm_vpci`.
>=20
> Maybe you could leave a comment somewhere so that if and when PCI PT
> hotplug is implemented for ARM, the implementor remembers to wire this
> up.

Sorry for missing this on the v6 serie.

Now you suggest to add a new field arm_vpci in libxl__domain_create_state.

Once we have done that I will need to access this structure to know if I ne=
ed
to add the DT part and somehow to give it a value depending something which
for now would the number of pcidevs as there will be no user parameter anym=
ore.

I had quite an understanding of the solution using libxl_domain_config and =
changing
The arguments of libxl__arch_domain_init_hw_description and libxl__prepare_=
dtb
Suggested by Stefano but I am a bit lost in this solution.

The following might be a stupid question but I did not dig a lot in libxl s=
o:
If we add a parameter in the state structure how should we access it ?

Thank
Bertrand



>=20
> Ian.



From xen-devel-bounces@lists.xenproject.org Thu Oct 14 17:28:43 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Oct 2021 17:28:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.209540.366030 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mb4Wt-00015h-Rg; Thu, 14 Oct 2021 17:28:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 209540.366030; Thu, 14 Oct 2021 17:28:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mb4Wt-00015a-Ok; Thu, 14 Oct 2021 17:28:31 +0000
Received: by outflank-mailman (input) for mailman id 209540;
 Thu, 14 Oct 2021 17:28:30 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+gDO=PC=gmail.com=olekstysh@srs-us1.protection.inumbo.net>)
 id 1mb4Ws-00015U-Nw
 for xen-devel@lists.xenproject.org; Thu, 14 Oct 2021 17:28:30 +0000
Received: from mail-wm1-x32b.google.com (unknown [2a00:1450:4864:20::32b])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 76aef145-c873-46ee-bcc6-0b3b28cdc913;
 Thu, 14 Oct 2021 17:28:29 +0000 (UTC)
Received: by mail-wm1-x32b.google.com with SMTP id
 g193-20020a1c20ca000000b0030d55f1d984so111308wmg.3
 for <xen-devel@lists.xenproject.org>; Thu, 14 Oct 2021 10:28:29 -0700 (PDT)
Received: from [192.168.1.7] ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id z5sm10953396wmp.26.2021.10.14.10.28.27
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Thu, 14 Oct 2021 10:28:28 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 76aef145-c873-46ee-bcc6-0b3b28cdc913
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:from:to:cc:references:message-id:date:user-agent
         :mime-version:in-reply-to:content-transfer-encoding:content-language;
        bh=gAGtEVKf7GWsYXUW7cE1B9HVpmvwdcPM1sZU82VR1og=;
        b=ZK3xIzSKcvHjb4ICgwwzyruswECIF6r5orWOqhAa+JAAi+RKdV/g16WdDBeDDypk0c
         Gzk5U7VtEqIOwmM0Tp7JNBOh7ukGGsYJ8E6Y9JcEWKYk4jLhRXCUsgBRUl9IzI95i4m5
         O8QXM7gWp/dHqmkLLajJsZKR+mIGL4PwHRGCjA72RWwLag93X3eHhUhRrj4Y8i7JWgB9
         5m+WUtQHH4Wub5dkk0uDPYgLM2I5OSkq1TLF+8cnRJi8xwm8fXm/6DUYQAs3c+UVd1vR
         sTZaSlhJnX4a1N1y8ASCR4yK21hpMDvt/Yl18s+Avf2NBJLw+j/GfHWycQdMxK7ABImX
         k4QA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:from:to:cc:references:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding
         :content-language;
        bh=gAGtEVKf7GWsYXUW7cE1B9HVpmvwdcPM1sZU82VR1og=;
        b=kERH9h/wNfgt3foV3sexvGhPIN4JXZ8BLadpCqUC6Fq33L5D8eEEJHwGYGA5nGqEwl
         voGnonIaxvqdbAZC+AV6CotchYZPnzFH9QC0sxIu8VSoKsuVxa7Zo11NQO6zHTuQMoHn
         GC1PAzltrthSZj6A8EO6JbrmXnQdyBtn9xXhG0gVApfsuB5xFb870J+GIDsoEBmISTcO
         WygXWBPlQ41dIWWbThuyKXV/YS1y5epBMULsA55c+q2nFoWPeOP5cZUFV/eZPb7zg1Ls
         EUti1vuflZ+ZSZ4qdKF3b+kzP8uDpNyOihm7L189NPJhf691fa45Ue/yyagrBkCEIFYD
         90sw==
X-Gm-Message-State: AOAM530JCHpMYHojh2dj3KnFVLHYhfKGtFGyAW4mlwCBLQw+EnOhqz73
	I5il43TzUWNTbe9bPgwG+F0=
X-Google-Smtp-Source: ABdhPJyWSWSNFbtArumOSt9dgz0emAKAqqJP50xQxTIhYXFVlaEfaWJdOQIRJo8STOjuV6oBf7zchg==
X-Received: by 2002:a7b:c744:: with SMTP id w4mr20892891wmk.51.1634232508753;
        Thu, 14 Oct 2021 10:28:28 -0700 (PDT)
Subject: Re: [PATCH V7 0/2] Add handling of extended regions (safe ranges) on
 Arm (Was "xen/memory: Introduce a hypercall to provide unallocated space")
From: Oleksandr <olekstysh@gmail.com>
To: xen-devel@lists.xenproject.org
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>,
 Anthony PERARD <anthony.perard@citrix.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Juergen Gross <jgross@suse.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Henry Wang <Henry.Wang@arm.com>, Bertrand Marquis
 <bertrand.marquis@arm.com>, Wei Chen <Wei.Chen@arm.com>
References: <1634211645-26912-1-git-send-email-olekstysh@gmail.com>
Message-ID: <52c9dea0-24cb-ae6f-1f74-2a41ca8fc6f2@gmail.com>
Date: Thu, 14 Oct 2021 20:28:27 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <1634211645-26912-1-git-send-email-olekstysh@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US


Hello all


On 14.10.21 14:40, Oleksandr Tyshchenko wrote:
> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>
> You can find an initial discussion at [1]-[7].
>
> The extended region (safe range) is a region of guest physical address space
> which is unused and could be safely used to create grant/foreign mappings instead
> of wasting real RAM pages from the domain memory for establishing these mappings.
>
> The extended regions are chosen at the domain creation time and advertised
> to it via "reg" property under hypervisor node in the guest device-tree
> (the indexes for extended regions are 1...N).
> No device tree bindings update is needed, guest infers the presense of extended
> regions from the number of regions in "reg" property.
> New compatible/property will be needed (but only after this patch [8] or alternative
> goes in) to indicate that "region 0 is safe to use". Until this patch is merged it is
> not safe to use extended regions for the grant table space.
>
> The extended regions are calculated differently for direct mapped Dom0 (with and without
> IOMMU) and non-direct mapped DomUs.
>
> Please note the following limitations:
> - The extended region feature is only supported for 64-bit domain currently.
> - The ACPI case is not covered.
>
> Please note that support for Dom0 was already committed, so these patches are remaining DomU bits.
>
> Xen patch series is also available at [9]. The corresponding Linux patch series is at [10]
> for now (last 4 patches).

So, all Xen changes are already committed (thanks!) and I will start 
trying to push Linux changes. I believe that with your help in review, 
it will be possible to finish this enabling work.


[snip]

-- 
Regards,

Oleksandr Tyshchenko



From xen-devel-bounces@lists.xenproject.org Thu Oct 14 17:54:53 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Oct 2021 17:54:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.209547.366040 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mb4wI-0004CN-V4; Thu, 14 Oct 2021 17:54:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 209547.366040; Thu, 14 Oct 2021 17:54:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mb4wI-0004CG-SE; Thu, 14 Oct 2021 17:54:46 +0000
Received: by outflank-mailman (input) for mailman id 209547;
 Thu, 14 Oct 2021 17:54:45 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mb4wH-0004CA-JS
 for xen-devel@lists.xenproject.org; Thu, 14 Oct 2021 17:54:45 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mb4wH-00061A-Hp
 for xen-devel@lists.xenproject.org; Thu, 14 Oct 2021 17:54:45 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mb4wH-0007JS-Gh
 for xen-devel@lists.xenproject.org; Thu, 14 Oct 2021 17:54:45 +0000
Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89)
 (envelope-from <iwj@xenproject.org>)
 id 1mb4wE-0003Cz-1Z; Thu, 14 Oct 2021 18:54:42 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date
	:Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From;
	bh=l4tMhdQIoo18JTQnGlQ7alZlztQ+JfYLH6wKG7Yyazg=; b=YCGesVV6NasQ9BB8+zN2ZuFqQ3
	o1bEBGrVT806GcLyeMVRaiYn0uLu3+mgRwNR046ipYekJojLUtvpgz9ZS62XtSmlgGUv6beovEeYr
	8XdotjxdlDZe3g7tMTPIfr6V5dHIpEZF/CNne+SHee+QF5hAMgm12O7xxWhR/bvI9gQ8=;
From: Ian Jackson <iwj@xenproject.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <24936.28385.679884.535704@mariner.uk.xensource.com>
Date: Thu, 14 Oct 2021 18:54:41 +0100
To: Bertrand Marquis <Bertrand.Marquis@arm.com>
Cc: xen-devel@lists.xenproject.org,
    iwj@xenproject.org,
    Rahul Singh <rahul.singh@arm.com>,
    Wei Liu <wl@xen.org>,
    Anthony PERARD <anthony.perard@citrix.com>,
    Juergen Gross <jgross@suse.com>,
    Stefano Stabellini <sstabellini@kernel.org>,
    Julien Grall <julien@xen.org>,
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
    Michal Orzel <michal.orzel@arm.com>,
    Andre Przywara <Andre.Przywara@arm.com>
Subject: Re: [PATCH v6 3/3] arm/libxl: Emulated PCI device tree node in libxl [and 1 more messages]
In-Reply-To: <fd9c54a381daa52436b0a1b27cf1bba8e7ff9af9.1634221830.git.bertrand.marquis@arm.com>,
	<8A04B9B2-E816-425E-BF1B-5A8B89F8836C@arm.com>
References: <cover.1633540842.git.rahul.singh@arm.com>
	<b81b5dea800c8fe47071f3dbd20588b1e472fb99.1633540842.git.rahul.singh@arm.com>
	<7bdac405-a889-15e1-be19-5876f7253855@xen.org>
	<24926.53690.621007.507249@mariner.uk.xensource.com>
	<294BE20A-7E45-405C-BC19-C292295E85E3@arm.com>
	<24927.7235.736221.270358@mariner.uk.xensource.com>
	<8A04B9B2-E816-425E-BF1B-5A8B89F8836C@arm.com>
	<cover.1634221830.git.bertrand.marquis@arm.com>
	<fd9c54a381daa52436b0a1b27cf1bba8e7ff9af9.1634221830.git.bertrand.marquis@arm.com>
X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu)

(Replying to both the earlier subthread on v5 and to the new v6
patch.)

Bertrand Marquis writes ("Re: [PATCH v5 10/11] arm/libxl: Emulated PCI device tree node in libxl"):
> Now you suggest to add a new field arm_vpci in libxl__domain_create_state.

Hi.  I was handwaving, hence "probably" :-).  I hadn't actually looked
at the existing code to see precisely how it would fit.

> Once we have done that I will need to access this structure to know if I need
> to add the DT part and somehow to give it a value depending something which
> for now would the number of pcidevs as there will be no user parameter anymore.

Right.

I looked at libxl_arm.c again:

It seems that the main entrypoint to all this is libxl__prepare_dtb,
and it is that function you want to do new stuff.  That gets
libxl_domain_build_info (which is specified by the IDL and comes from
outside libxl, subject to libxl's default-filling machinery) and
libxl__domain_build_state (which is the general state struct).

The information you need is is libxl_domain_create_info.
libxl__domain_config_setdefault already arranges to set
c_info->passthrough based on the number of PCI PT devices
(search for `need_pt` in libxl_create.c).

That is, as I understand it on ARM vpci should be enabled if
passthrough is enabled and not otherwise.  That is precisely what
the variable c_info->passthrough is.

There is a slight issue because of the distinction between create_info
and build_info and domain_config (and, the corresponding _state)
structs.  Currently the DT code ony gets b_info, not the whole
libxl_domain_config.  These distinctions largely historical nowadays.
Certainly there is no reason not to pass a pointer to the whole
libxl_domain_config, rather than just libxl_domain_build_info, into
libxl__arch_domain_init_hw_description.

So I think the right approach for this looks something like this:

1. Change libxl__arch_domain_init_hw_description to take
   libxl_domain_config* rather than libxl_domain_build_info*.
   libxl_domain_config contains libxl_domain_build_info so
   this is easy.

   If you put in a convenience alias variable for the
   libxl_domain_build_info* you can avoid extra typing in the function
   body.  (If you call the convenience alias `info` you won't need to
   change the body at all, but maybe `info` isn't the best name so you
   could rename it to `b_info` maybe; up to you.)

2. Make the same change to libxl__prepare_dtb.

3. Now you can use d_config->c_info.passthrough to gate the addition
   of the additional stuff to the DT.  Ie, that is a respin of this
   patch 3/3.

1 and 2 need to be separated out from 3, in a different patch (or two
different patches) added to this series before what is now 3/3.  Ie
1+2, or 1 and 2 separately, should be pure plumbing changes with no
functional change.

I hope this is helpful.

Thanks,
Ian.


From xen-devel-bounces@lists.xenproject.org Thu Oct 14 18:34:23 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Oct 2021 18:34:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.209558.366051 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mb5YR-0008FM-Rb; Thu, 14 Oct 2021 18:34:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 209558.366051; Thu, 14 Oct 2021 18:34:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mb5YR-0008FF-Oh; Thu, 14 Oct 2021 18:34:11 +0000
Received: by outflank-mailman (input) for mailman id 209558;
 Thu, 14 Oct 2021 18:34:10 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mb5YP-0008F4-VR; Thu, 14 Oct 2021 18:34:09 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mb5YP-0006lm-OV; Thu, 14 Oct 2021 18:34:09 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mb5YP-00070L-CF; Thu, 14 Oct 2021 18:34:09 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mb5YP-0003Sk-Bm; Thu, 14 Oct 2021 18:34:09 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=7+wuTH2TkX5GVEM+X1Ol5e5hUVubmBX9IKXcnuks8Ho=; b=sb9+7g3vwrqOmh/J6O+T8YTukQ
	TEC6XQucmyOpVU/7SayJ5HOxUUVYJ2elGjafIDYB7On6rjsdInRWjg++A3t8CYwG9s/wgi3VXXOgr
	g0o8c4pwweegLiw8nvCth2DhBSir0tVeAexvRzuCz38bWeTQf+OmbLLlsDQn7tGsSsTU=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165511-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 165511: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=57f87857dc2de452a796d6bad4f476510efd2aba
X-Osstest-Versions-That:
    xen=2f5f0a1b77161993c16c4cc243467d75e5b7633b
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 14 Oct 2021 18:34:09 +0000

flight 165511 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165511/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  57f87857dc2de452a796d6bad4f476510efd2aba
baseline version:
 xen                  2f5f0a1b77161993c16c4cc243467d75e5b7633b

Last test of basis   165507  2021-10-14 11:01:35 Z    0 days
Testing same since   165511  2021-10-14 15:00:25 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Ian Jackson <iwj@xenproject.org>
  Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   2f5f0a1b77..57f87857dc  57f87857dc2de452a796d6bad4f476510efd2aba -> smoke


From xen-devel-bounces@lists.xenproject.org Thu Oct 14 19:43:08 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Oct 2021 19:43:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.209590.366084 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mb6cp-0007OQ-Dp; Thu, 14 Oct 2021 19:42:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 209590.366084; Thu, 14 Oct 2021 19:42:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mb6cp-0007OJ-9n; Thu, 14 Oct 2021 19:42:47 +0000
Received: by outflank-mailman (input) for mailman id 209590;
 Thu, 14 Oct 2021 19:42:45 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=kGop=PC=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1mb6cn-0007OD-Rn
 for xen-devel@lists.xenproject.org; Thu, 14 Oct 2021 19:42:45 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 2b47d026-5986-4549-87dd-497263c02a48;
 Thu, 14 Oct 2021 19:42:44 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id AEC83604E9;
 Thu, 14 Oct 2021 19:42:43 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2b47d026-5986-4549-87dd-497263c02a48
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1634240564;
	bh=iIBZIhtkSWMQj1WgKcPeCr6QjVpWAQIm6lxiwng6KCY=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=rgqbekksfExbJEHdzFLOFsKIqA8ZbZjDH6BNQZsGElAUs82NMm2bly1+roOhodLbl
	 w+3Zf7f0N56dYq38pi+kEIebY7iMdINqvD4iA8+HwVdYisDtSVk1Mr6GFFr/nyS3lA
	 1Xvus4nFp7wprCBRh8RrX6qiq64URaagwqhWHzDzyWgVsVw1NjhEG1KOw8C4Wnc21R
	 nFJUkQWExuMS3G1js3L1NDpy0nqoX2mkt/hDyrmVQlO5/C6vkKuIAD8Fv1QKa+xPTD
	 7p0qpjrp5uhGgNG8Dvwrpybwrd36G0iw5FuMgh41eJprELL+WBpKa0WYwWmjMRbiQ7
	 qMA3MjPPXMA5A==
Date: Thu, 14 Oct 2021 12:42:42 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
cc: boris.ostrovsky@oracle.com, jgross@suse.com, sstabellini@kernel.org, 
    xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, 
    kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] xen/pvcalls-back: Remove redundant 'flush_workqueue()'
 calls
In-Reply-To: <2d6c2e031e4aa2acf2ac4e0bbbc17cfdcc8dbee2.1634236560.git.christophe.jaillet@wanadoo.fr>
Message-ID: <alpine.DEB.2.21.2110141242320.9408@sstabellini-ThinkPad-T480s>
References: <2d6c2e031e4aa2acf2ac4e0bbbc17cfdcc8dbee2.1634236560.git.christophe.jaillet@wanadoo.fr>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Thu, 14 Oct 2021, Christophe JAILLET wrote:
> 'destroy_workqueue()' already drains the queue before destroying it, so
> there is no need to flush it explicitly.
> 
> Remove the redundant 'flush_workqueue()' calls.
> 
> This was generated with coccinelle:
> 
> @@
> expression E;
> @@
> - 	flush_workqueue(E);
> 	destroy_workqueue(E);
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>

Acked-by: Stefano Stabellini <sstabellini@kernel.org>


> ---
>  drivers/xen/pvcalls-back.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/xen/pvcalls-back.c b/drivers/xen/pvcalls-back.c
> index b47fd8435061..d6f945fd4147 100644
> --- a/drivers/xen/pvcalls-back.c
> +++ b/drivers/xen/pvcalls-back.c
> @@ -465,7 +465,6 @@ static int pvcalls_back_release_passive(struct xenbus_device *dev,
>  		write_unlock_bh(&mappass->sock->sk->sk_callback_lock);
>  	}
>  	sock_release(mappass->sock);
> -	flush_workqueue(mappass->wq);
>  	destroy_workqueue(mappass->wq);
>  	kfree(mappass);
>  
> -- 
> 2.30.2
> 


From xen-devel-bounces@lists.xenproject.org Thu Oct 14 20:19:33 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Oct 2021 20:19:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.209598.366095 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mb7CJ-0002F3-6m; Thu, 14 Oct 2021 20:19:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 209598.366095; Thu, 14 Oct 2021 20:19:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mb7CJ-0002Ew-2s; Thu, 14 Oct 2021 20:19:27 +0000
Received: by outflank-mailman (input) for mailman id 209598;
 Thu, 14 Oct 2021 20:19:25 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mb7CH-0002Em-8w; Thu, 14 Oct 2021 20:19:25 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mb7CG-000072-S8; Thu, 14 Oct 2021 20:19:24 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mb7CG-0004IX-Gd; Thu, 14 Oct 2021 20:19:24 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mb7CG-0002ZF-GA; Thu, 14 Oct 2021 20:19:24 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=kpOmc4oBje4iJgnStpJu1gKt98VPjLwhRzvlyWIw/Ag=; b=YisgHckQ+7NsqWMGOwurHMRa6W
	Is0YK8vovhgO9o+fliMsJhtYhFQfKEDycpGfRtUhAbxf91PbbtuQFJGVIBDPy5ufOfVhqoyz6R5VZ
	UwkYMuIA4m5dx12l58mBESMAP89EBWcnUd3y89U3VGlQIM8qRQfrIj5onfapxd8T6y38=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165506-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 165506: tolerable FAIL - PUSHED
X-Osstest-Failures:
    qemu-mainline:test-armhf-armhf-xl-arndale:host-ping-check-xen:fail:heisenbug
    qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=e5b2333f24ff207f08cf96e73d2e11438c985801
X-Osstest-Versions-That:
    qemuu=946de558354c99e1989621abe053f2ab87dc8de9
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 14 Oct 2021 20:19:24 +0000

flight 165506 qemu-mainline real [real]
flight 165513 qemu-mainline real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/165506/
http://logs.test-lab.xenproject.org/osstest/logs/165513/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-armhf-armhf-xl-arndale  10 host-ping-check-xen fail pass in 165513-retest

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-xl-arndale 15 migrate-support-check fail in 165513 never pass
 test-armhf-armhf-xl-arndale 16 saverestore-support-check fail in 165513 never pass
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165498
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165498
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 165498
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 165498
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 165498
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 165498
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 165498
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165498
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 qemuu                e5b2333f24ff207f08cf96e73d2e11438c985801
baseline version:
 qemuu                946de558354c99e1989621abe053f2ab87dc8de9

Last test of basis   165498  2021-10-13 17:39:31 Z    1 days
Testing same since   165506  2021-10-14 09:38:59 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  BALATON Zoltan <balaton@eik.bme.hu>
  Richard Henderson <richard.henderson@linaro.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  fail    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/qemu-xen.git
   946de55835..e5b2333f24  e5b2333f24ff207f08cf96e73d2e11438c985801 -> upstream-tested


From xen-devel-bounces@lists.xenproject.org Thu Oct 14 22:50:08 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Oct 2021 22:50:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.209609.366109 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mb9Xu-00079G-MR; Thu, 14 Oct 2021 22:49:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 209609.366109; Thu, 14 Oct 2021 22:49:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mb9Xu-000799-It; Thu, 14 Oct 2021 22:49:54 +0000
Received: by outflank-mailman (input) for mailman id 209609;
 Thu, 14 Oct 2021 22:49:53 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=kGop=PC=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1mb9Xt-000793-0J
 for xen-devel@lists.xenproject.org; Thu, 14 Oct 2021 22:49:53 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 0a3245e0-2d41-11ec-8210-12813bfff9fa;
 Thu, 14 Oct 2021 22:49:51 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id 2BEF060FC3;
 Thu, 14 Oct 2021 22:49:50 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0a3245e0-2d41-11ec-8210-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1634251790;
	bh=/0jjFKANFU393DZmQmirwpayih0KQPPBnBUF75m4D6s=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=EE4LAmSPAq9C9u2lzPZ6fsZeTMdsS6BuGmn7iLlv4U/vlYrDosK4p/qw3m09sATBp
	 AkJlC568WpUK6bSHTJYcWbB1TRcQSgGyIrqkVJo+pRn8iBwrK8Bm9yBBGThLXgKb0g
	 6GoETHMO3HNR56bAgZ6vBRpo4PCaA5t2QBW0Sg+0ozsEN+2fj35yqXIsp0P80qHw5e
	 qx4CJayNu6Kpbs0wwDwwqvWVOUEi4xhexUzj9X/1KlugNqt730Stfoywn2r7e8pjAg
	 mk21jDYORoK3XWffUo3uxl6oR/CrP/RsWMrfvrSWoGy1UpPhPBvZfCzHCmQrxcU1Lu
	 u2qs//+B7JjaQ==
Date: Thu, 14 Oct 2021 15:49:49 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Sai Kiran Kumar Reddy Y <ysaikiran1997@gmail.com>
cc: Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>, 
    Bertrand Marquis <bertrand.marquis@arm.com>, 
    Jan Beulich <jbeulich@suse.com>, Luca Fancellu <luca.fancellu@arm.com>, 
    xen-devel@lists.xenproject.org, kannan@cimware.in
Subject: Re: Xen Booting Problem on ARM Machine
In-Reply-To: <CAEsO4uxo_A4pEwP6dHK8kvYtKcbSr-ewqX1v-KLsEkyHNLFyUA@mail.gmail.com>
Message-ID: <alpine.DEB.2.21.2110141536090.9408@sstabellini-ThinkPad-T480s>
References: <33C29853-D896-4E4E-91D3-4D2FA89A9B91@hxcore.ol> <eb5fd47b-6bc9-2eec-7f46-9ab9a42c9f1f@xen.org> <CAEsO4uzsCnsTtTmYHAT4NN6=girCY2NHHdAHbH6GG33D7jwe_A@mail.gmail.com> <alpine.DEB.2.21.2109131437030.10523@sstabellini-ThinkPad-T480s>
 <CAEsO4uwpiDO2QoqLRTOxpsYM9YSPAsbX0P=gagdEy21pk1VsPQ@mail.gmail.com> <alpine.DEB.2.21.2109141825330.21985@sstabellini-ThinkPad-T480s> <CAEsO4uyjNs97Cx8n2owDk4kKTVCycji377pm7aXHcPWzeszUTw@mail.gmail.com> <alpine.DEB.2.21.2109301942370.3209@sstabellini-ThinkPad-T480s>
 <CAEsO4ux_AqXBeCtbwnPAdnBnVYHTur_2EfcZBTuN4QKCq4ko8Q@mail.gmail.com> <alpine.DEB.2.21.2110131711280.9408@sstabellini-ThinkPad-T480s> <CAEsO4uxo_A4pEwP6dHK8kvYtKcbSr-ewqX1v-KLsEkyHNLFyUA@mail.gmail.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: multipart/mixed; BOUNDARY="8323329-1095502565-1634251193=:9408"
Content-ID: <alpine.DEB.2.21.2110141540560.9408@sstabellini-ThinkPad-T480s>

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-1095502565-1634251193=:9408
Content-Type: text/plain; CHARSET=UTF-8
Content-Transfer-Encoding: 8BIT
Content-ID: <alpine.DEB.2.21.2110141540561.9408@sstabellini-ThinkPad-T480s>

On Thu, 14 Oct 2021, Sai Kiran Kumar Reddy Y wrote:
> On Thu, Oct 14, 2021 at 5:45 AM Stefano Stabellini <sstabellini@kernel.org> wrote:
>       On Wed, 13 Oct 2021, Sai Kiran Kumar Reddy Y wrote:
>       > On Fri, Oct 1, 2021 at 8:17 AM Stefano Stabellini <sstabellini@kernel.org> wrote:
>       >       Yes there are other ways but without serial is going to be difficult
>       >       because you are not going to see anything until everything works.
>       >
>       >       How do you boot Xen and Dom0 exactly from EDK2? Are you using GRUB or
>       >       loading Xen directly from the EDK2 prompt? Please provide as many
>       >       details as possible so that I might be able to spot any errors.
>       >
>       > I am using GRUB to load Xen. In the GRUB menu, I see two options. 
>       > Option 1: Debian 11 with latest Linux Kernel
>       > Option 2: Debian 11(with Xen hypervisor) with latest Kernel
>       >  
>       >       Can you provide the Device Tree you are using? If you are not passing
>       >       any Device Tree  binary explicitely, then it might be passed
>       >       automatically from EDK2 to Linux/Xen. In that case, just boot from Linux
>       >       then do the following to retrieve the Device Tree:
>       >
>       >       dtc -I fs -O dts /proc/device-tree > host.dts
>       >
>       >       Then please attach host.dts to this email thread.
>       >
>       > Yeah, you are right. It looks like LInux is booting from ACPI. In the bootloader menu, "Automatic ACPI configuration" is
>       disabled. So, I
>       > thought that Linux may be booting from Device Tree. I have tried the "dtc" command you mentioned. But it looks like there's
>       no device-tree
>       > under "/proc". I also tried to get DT info, from "/sys/firmware/devicetree/base" . But, there's no info. under devicetree
>       folder. I am not
>       > quite sure how to get the DT info, if the Linux is booting from ACPI. I am attaching .dsl files, that contain the acpi info.
> 
>       OK, so it is pretty clear that even if "Automatic ACPI configuration" is
>       disabled, it is still booting with ACPI.
> 
> 
>       >       Also for your information it looks like Linux actually booted from ACPI,
>       >       not from Device Tree, as you can see from all the "ACPI" messages in the
>       >       kernel logs.
>       >
>       >       If you need to boot from ACPI, then you need to enable ACPI support in
>       >       Xen, which is disabled by default. You can do that using make
>       >       menuconfig.
>       >
>       > In the make menuconfig of Xen, I do not see any option to enable ACPI.  
> 
>       You definitely need to enable ACPI support in Xen, if you are booting
>       from ACPI, otherwise nothing is going to work.
> 
>       On the latest staging (https://gitlab.com/xen-project/xen) you can
>       enable ACPI as follows:
> 
> 
>       # export CROSS_COMPILE=/path/to/cross-compiler
>       # export XEN_TARGET_ARCH=arm64
>       # cd xen.git/xen
>       # make menuconfig
>       #   --> Configure UNSUPPORTED features
>       #   --> Architecture Features --> ACPI
>       # make
> 
> 
> Hi
> 
> I got the code from Gitlab and installed it, enabling ACPI support in Xen. As I reboot the system, I am able to see 2 options like before. 
> Option 1: Debian with latest kernel
> Option 2 : Debian with Xen
> 
> I have selected Option 2. I did not see any bootinfo membanks error. However, there is the following error in GRUB(just for a fraction of a
> second). 
> 
> "Using modules provided by boot loader in FDT
>   Xen 4.16-unstable (c/s Wed Oct 13 13 13:28:43 2021 -0700 git:4cfab4425d) EFI Loader
>   Couldn't obtain the File System Protocol Interface: ErrCode: 0x8000000000000002"
> 
> I have enabled earlyprintk. I do not see any messages in the Serial. There seems to be some problem with the gitlab version of Xen.

The error comes from xen/common/efi/boot.c:get_parent_handle

Xen is booted as EFI binary and it is trying to load other binaries
using the EFI File System Protocol Interface which is one of the EFI
Boot Services.

A wild guess is that somehow Grub is calling ExitBootServices, which
closes all Boot Services interfaces, before executing Xen. It should not
happen if Grub is executing Xen as EFI binary. I cannot explain how it
is possible. It looks like a bug in Grub.

Can you post the Grub config file that you are using?


Usually before Grub there is the proper EFI bootloader, tipically EDK2.
You should be able to boot Xen directly from the EFI bootloader too,
from its prompt, just by executing "xen". You need to place the xen
binary in the first FAT partition together with a xen.cfg config file as
follows:

---
options=console=com1 com1=115200 loglvl=all noreboot
kernel=vmlinuz-3.0.31-0.4-xen [domain 0 command line options]
ramdisk=initrd-3.0.31-0.4-xen
---

options is to specify the Xen command line.
kernel is to specify the Linux kernel to use and its command line.
ramdisk is to specify the Linux ramdisk.

Both kernel and ramdisk needs to be on the FAT partition too.


That way you skip Grub and you might be able to skip any related
problems with ExitBootServices.
--8323329-1095502565-1634251193=:9408--


From xen-devel-bounces@lists.xenproject.org Thu Oct 14 23:23:22 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Oct 2021 23:23:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.209617.366120 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbA4B-0002gI-C3; Thu, 14 Oct 2021 23:23:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 209617.366120; Thu, 14 Oct 2021 23:23:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbA4B-0002gB-7R; Thu, 14 Oct 2021 23:23:15 +0000
Received: by outflank-mailman (input) for mailman id 209617;
 Thu, 14 Oct 2021 23:23:13 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mbA49-0002g1-6V; Thu, 14 Oct 2021 23:23:13 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mbA48-0003AO-Tf; Thu, 14 Oct 2021 23:23:12 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mbA48-00056D-KS; Thu, 14 Oct 2021 23:23:12 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mbA48-0007h9-K1; Thu, 14 Oct 2021 23:23:12 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=FLQnPgDkYW21/OsCS4u3w1b06JLdLstwIFBdHyF1Mt8=; b=IKsfyHETJDAcR8MuNfzHOkjyv8
	lQoJ/2yxKPy8iJX6GV5lIOoCZlX1xaPPqs0Bo3Ef9hyp2oo5Y9oicAoyyg6d8LWwRRUPtKQ5QzwQh
	Vnboafzd8DFZp9LZyzG0IbwokfwX/mgMf1C6B8sjCGAvg4KruqXDlETejBQe/Z0shKb4=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165512-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 165512: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=b75838ad6c4f42c93efee83fc2508c78641e1b57
X-Osstest-Versions-That:
    xen=57f87857dc2de452a796d6bad4f476510efd2aba
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 14 Oct 2021 23:23:12 +0000

flight 165512 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165512/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  b75838ad6c4f42c93efee83fc2508c78641e1b57
baseline version:
 xen                  57f87857dc2de452a796d6bad4f476510efd2aba

Last test of basis   165511  2021-10-14 15:00:25 Z    0 days
Testing same since   165512  2021-10-14 19:01:36 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Julien Grall <jgrall@amazon.com>
  Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
  Volodymyr Babchuk <volodymyr_babchuk@epam.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   57f87857dc..b75838ad6c  b75838ad6c4f42c93efee83fc2508c78641e1b57 -> smoke


From xen-devel-bounces@lists.xenproject.org Thu Oct 14 23:47:54 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Oct 2021 23:47:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.209626.366133 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbARu-00053n-Ac; Thu, 14 Oct 2021 23:47:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 209626.366133; Thu, 14 Oct 2021 23:47:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbARu-00053g-7m; Thu, 14 Oct 2021 23:47:46 +0000
Received: by outflank-mailman (input) for mailman id 209626;
 Thu, 14 Oct 2021 23:47:45 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=kGop=PC=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1mbARt-00053a-9U
 for xen-devel@lists.xenproject.org; Thu, 14 Oct 2021 23:47:45 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id ca75063f-9c2b-4c31-9e9c-3406885dba09;
 Thu, 14 Oct 2021 23:47:43 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id 0382460FDA;
 Thu, 14 Oct 2021 23:47:42 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ca75063f-9c2b-4c31-9e9c-3406885dba09
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1634255263;
	bh=Zc5v0CCY2XBkmc+G5mLnF8FCEl7IEblL6r3/QCRBbu8=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=LCiZYh9/N5ykOZwrw0qx4tuaPKx/ujlFPF7s9J1nP0InechSd5LxGs2Qui12mrU3G
	 mFTjprYi01X6GY2fQf0pC9+9K+49sJXl/An4slgipkLwxAY66F4/nF8YeCyIHD1/ts
	 QdEmyG/fBIRKHTL+SV1Whp3R7PVD7WkiXzs03ZGZ/8b7cCD4ekHOuFHDhz+ES+g+30
	 LH0j9Sa7LKeDZNWQNtMDRqQmLoyk76wuy5AqBIwOzW1C//6v9Z6qK7gVXQEy75nSY1
	 FOHGmikg/P9VGFulux/jNGbG8i6HmxMChXySTdm7LqnyFl9TDHFLskDjElpHSwIfjs
	 EzLiC33r3MF+g==
Date: Thu, 14 Oct 2021 16:47:42 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Bertrand Marquis <bertrand.marquis@arm.com>
cc: xen-devel@lists.xenproject.org, iwj@xenproject.org, 
    Paul Durrant <paul@xen.org>, Jan Beulich <jbeulich@suse.com>, 
    Andrew Cooper <andrew.cooper3@citrix.com>, 
    =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= <roger.pau@citrix.com>, 
    Wei Liu <wl@xen.org>
Subject: Re: [PATCH v6 1/3] xen/vpci: Move ecam access functions to common
 code
In-Reply-To: <ced6f870dbfabcfe8584555cc80f9a37a0655a0c.1634221830.git.bertrand.marquis@arm.com>
Message-ID: <alpine.DEB.2.21.2110141306290.9408@sstabellini-ThinkPad-T480s>
References: <cover.1634221830.git.bertrand.marquis@arm.com> <ced6f870dbfabcfe8584555cc80f9a37a0655a0c.1634221830.git.bertrand.marquis@arm.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: multipart/mixed; BOUNDARY="8323329-474416638-1634242050=:9408"
Content-ID: <alpine.DEB.2.21.2110141314360.9408@sstabellini-ThinkPad-T480s>

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-474416638-1634242050=:9408
Content-Type: text/plain; CHARSET=UTF-8
Content-Transfer-Encoding: 8BIT
Content-ID: <alpine.DEB.2.21.2110141314361.9408@sstabellini-ThinkPad-T480s>

On Thu, 14 Oct 2021, Bertrand Marquis wrote:
> PCI standard is using ECAM and not MCFG which is coming from ACPI[1].
> Use ECAM/ecam instead of MCFG in common code and in new functions added
> in common vpci code by this patch.
> 
> Rename vpci_access_allowed to vpci_ecam_access_allowed and move it
> from arch/x86/hvm/io.c to drivers/vpci/vpci.c.
> 
> Create vpci_ecam_mmio_{read,write} in drivers/vpci/vpci.c that
> contains the common code to perform these operations, changed
> vpci_mmcfg_{read,write} accordingly to make use of these functions.
> 
> The vpci_ecam_mmio_{read,write} functions are returning 0 on error and 1
> on success. As the x86 code was previously always returning X86EMUL_OKAY
> the return code is ignored. A comment has been added in the code to show
> that this is intentional.
>
> Those functions will be used in a following patch inside by arm vpci
> implementation.
> 
> Rename MMCFG_SBDF to ECAM_SBDF.
> 
> Not functional change intended with this patch.
> 
> [1] https://wiki.osdev.org/PCI_Express
> 
> Suggested-by: Roger Pau Monné <roger.pau@citrix.com>
> Signed-off-by: Bertrand Marquis <bertrand.marquis@arm.com>

Everything checks out:

Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>


FYI I like the new naming scheme and I think it is the right one for us
to use, but either way for me it wouldn't be a blocker for acceptance.


> ---
> Changes in v6: Patch added
> ---
>  xen/arch/x86/hvm/io.c     | 50 +++++---------------------------
>  xen/drivers/vpci/vpci.c   | 60 +++++++++++++++++++++++++++++++++++++++
>  xen/include/asm-x86/pci.h |  2 +-
>  xen/include/xen/vpci.h    | 10 +++++++
>  4 files changed, 78 insertions(+), 44 deletions(-)
> 
> diff --git a/xen/arch/x86/hvm/io.c b/xen/arch/x86/hvm/io.c
> index 046a8eb4ed..340b8c8b0e 100644
> --- a/xen/arch/x86/hvm/io.c
> +++ b/xen/arch/x86/hvm/io.c
> @@ -260,20 +260,6 @@ unsigned int hvm_pci_decode_addr(unsigned int cf8, unsigned int addr,
>      return CF8_ADDR_LO(cf8) | (addr & 3);
>  }
>  
> -/* Do some sanity checks. */
> -static bool vpci_access_allowed(unsigned int reg, unsigned int len)
> -{
> -    /* Check access size. */
> -    if ( len != 1 && len != 2 && len != 4 && len != 8 )
> -        return false;
> -
> -    /* Check that access is size aligned. */
> -    if ( (reg & (len - 1)) )
> -        return false;
> -
> -    return true;
> -}
> -
>  /* vPCI config space IO ports handlers (0xcf8/0xcfc). */
>  static bool vpci_portio_accept(const struct hvm_io_handler *handler,
>                                 const ioreq_t *p)
> @@ -305,7 +291,7 @@ static int vpci_portio_read(const struct hvm_io_handler *handler,
>  
>      reg = hvm_pci_decode_addr(cf8, addr, &sbdf);
>  
> -    if ( !vpci_access_allowed(reg, size) )
> +    if ( !vpci_ecam_access_allowed(reg, size) )
>          return X86EMUL_OKAY;
>  
>      *data = vpci_read(sbdf, reg, size);
> @@ -335,7 +321,7 @@ static int vpci_portio_write(const struct hvm_io_handler *handler,
>  
>      reg = hvm_pci_decode_addr(cf8, addr, &sbdf);
>  
> -    if ( !vpci_access_allowed(reg, size) )
> +    if ( !vpci_ecam_access_allowed(reg, size) )
>          return X86EMUL_OKAY;
>  
>      vpci_write(sbdf, reg, size, data);
> @@ -394,7 +380,7 @@ static unsigned int vpci_mmcfg_decode_addr(const struct hvm_mmcfg *mmcfg,
>                                             paddr_t addr, pci_sbdf_t *sbdf)
>  {
>      addr -= mmcfg->addr;
> -    sbdf->bdf = MMCFG_BDF(addr);
> +    sbdf->bdf = ECAM_BDF(addr);
>      sbdf->bus += mmcfg->start_bus;
>      sbdf->seg = mmcfg->segment;
>  
> @@ -434,25 +420,8 @@ static int vpci_mmcfg_read(struct vcpu *v, unsigned long addr,
>      reg = vpci_mmcfg_decode_addr(mmcfg, addr, &sbdf);
>      read_unlock(&d->arch.hvm.mmcfg_lock);
>  
> -    if ( !vpci_access_allowed(reg, len) ||
> -         (reg + len) > PCI_CFG_SPACE_EXP_SIZE )
> -        return X86EMUL_OKAY;
> -
> -    /*
> -     * According to the PCIe 3.1A specification:
> -     *  - Configuration Reads and Writes must usually be DWORD or smaller
> -     *    in size.
> -     *  - Because Root Complex implementations are not required to support
> -     *    accesses to a RCRB that cross DW boundaries [...] software
> -     *    should take care not to cause the generation of such accesses
> -     *    when accessing a RCRB unless the Root Complex will support the
> -     *    access.
> -     *  Xen however supports 8byte accesses by splitting them into two
> -     *  4byte accesses.
> -     */
> -    *data = vpci_read(sbdf, reg, min(4u, len));
> -    if ( len == 8 )
> -        *data |= (uint64_t)vpci_read(sbdf, reg + 4, 4) << 32;
> +    /* Ignore return code */
> +    vpci_ecam_mmio_read(sbdf, reg, len, data);
>  
>      return X86EMUL_OKAY;
>  }
> @@ -476,13 +445,8 @@ static int vpci_mmcfg_write(struct vcpu *v, unsigned long addr,
>      reg = vpci_mmcfg_decode_addr(mmcfg, addr, &sbdf);
>      read_unlock(&d->arch.hvm.mmcfg_lock);
>  
> -    if ( !vpci_access_allowed(reg, len) ||
> -         (reg + len) > PCI_CFG_SPACE_EXP_SIZE )
> -        return X86EMUL_OKAY;
> -
> -    vpci_write(sbdf, reg, min(4u, len), data);
> -    if ( len == 8 )
> -        vpci_write(sbdf, reg + 4, 4, data >> 32);
> +    /* Ignore return code */
> +    vpci_ecam_mmio_write(sbdf, reg, len, data);
>  
>      return X86EMUL_OKAY;
>  }
> diff --git a/xen/drivers/vpci/vpci.c b/xen/drivers/vpci/vpci.c
> index cbd1bac7fc..c0853176d7 100644
> --- a/xen/drivers/vpci/vpci.c
> +++ b/xen/drivers/vpci/vpci.c
> @@ -478,6 +478,66 @@ void vpci_write(pci_sbdf_t sbdf, unsigned int reg, unsigned int size,
>      spin_unlock(&pdev->vpci->lock);
>  }
>  
> +/* Helper function to check an access size and alignment on vpci space. */
> +bool vpci_ecam_access_allowed(unsigned int reg, unsigned int len)
> +{
> +    /*
> +     * Check access size.
> +     *
> +     * On arm32 or for 32bit guests on arm, 64bit accesses should be forbidden
> +     * but as for those platform ISV register, which gives the access size,
> +     * cannot have a value 3, checking this would just harden the code.
> +     */
> +    if ( len != 1 && len != 2 && len != 4 && len != 8 )
> +        return false;
> +
> +    /* Check that access is size aligned. */
> +    if ( (reg & (len - 1)) )
> +        return false;
> +
> +    return true;
> +}
> +
> +int vpci_ecam_mmio_write(pci_sbdf_t sbdf, unsigned int reg, unsigned int len,
> +                         unsigned long data)
> +{
> +    if ( !vpci_ecam_access_allowed(reg, len) ||
> +         (reg + len) > PCI_CFG_SPACE_EXP_SIZE )
> +        return 0;
> +
> +    vpci_write(sbdf, reg, min(4u, len), data);
> +    if ( len == 8 )
> +        vpci_write(sbdf, reg + 4, 4, data >> 32);
> +
> +    return 1;
> +}
> +
> +int vpci_ecam_mmio_read(pci_sbdf_t sbdf, unsigned int reg, unsigned int len,
> +                        unsigned long *data)
> +{
> +    if ( !vpci_ecam_access_allowed(reg, len) ||
> +         (reg + len) > PCI_CFG_SPACE_EXP_SIZE )
> +        return 0;
> +
> +    /*
> +     * According to the PCIe 3.1A specification:
> +     *  - Configuration Reads and Writes must usually be DWORD or smaller
> +     *    in size.
> +     *  - Because Root Complex implementations are not required to support
> +     *    accesses to a RCRB that cross DW boundaries [...] software
> +     *    should take care not to cause the generation of such accesses
> +     *    when accessing a RCRB unless the Root Complex will support the
> +     *    access.
> +     *  Xen however supports 8byte accesses by splitting them into two
> +     *  4byte accesses.
> +     */
> +    *data = vpci_read(sbdf, reg, min(4u, len));
> +    if ( len == 8 )
> +        *data |= (uint64_t)vpci_read(sbdf, reg + 4, 4) << 32;
> +
> +    return 1;
> +}
> +
>  /*
>   * Local variables:
>   * mode: C
> diff --git a/xen/include/asm-x86/pci.h b/xen/include/asm-x86/pci.h
> index edd7c3e71a..a0df5c1279 100644
> --- a/xen/include/asm-x86/pci.h
> +++ b/xen/include/asm-x86/pci.h
> @@ -6,7 +6,7 @@
>  #define CF8_ADDR_HI(cf8) (  ((cf8) & 0x0f000000) >> 16)
>  #define CF8_ENABLED(cf8) (!!((cf8) & 0x80000000))
>  
> -#define MMCFG_BDF(addr)  ( ((addr) & 0x0ffff000) >> 12)
> +#define ECAM_BDF(addr)   ( ((addr) & 0x0ffff000) >> 12)
>  
>  #define IS_SNB_GFX(id) (id == 0x01068086 || id == 0x01168086 \
>                          || id == 0x01268086 || id == 0x01028086 \
> diff --git a/xen/include/xen/vpci.h b/xen/include/xen/vpci.h
> index 9f5b5d52e1..4a0c3d77c9 100644
> --- a/xen/include/xen/vpci.h
> +++ b/xen/include/xen/vpci.h
> @@ -208,6 +208,16 @@ static inline unsigned int vmsix_entry_nr(const struct vpci_msix *msix,
>  {
>      return entry - msix->entries;
>  }
> +
> +/* ECAM mmio read/write helpers */
> +bool vpci_ecam_access_allowed(unsigned int reg, unsigned int len);
> +
> +int vpci_ecam_mmio_write(pci_sbdf_t sbdf, unsigned int reg, unsigned int len,
> +                         unsigned long data);
> +
> +int vpci_ecam_mmio_read(pci_sbdf_t sbdf, unsigned int reg, unsigned int len,
> +                        unsigned long *data);
> +
>  #endif /* __XEN__ */
>  
>  #else /* !CONFIG_HAS_VPCI */
> -- 
> 2.25.1
> 
> 
--8323329-474416638-1634242050=:9408--


From xen-devel-bounces@lists.xenproject.org Thu Oct 14 23:49:19 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Oct 2021 23:49:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.209632.366145 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbATO-0005e1-NC; Thu, 14 Oct 2021 23:49:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 209632.366145; Thu, 14 Oct 2021 23:49:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbATO-0005du-JR; Thu, 14 Oct 2021 23:49:18 +0000
Received: by outflank-mailman (input) for mailman id 209632;
 Thu, 14 Oct 2021 23:49:17 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=kGop=PC=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1mbATN-0005dm-57
 for xen-devel@lists.xenproject.org; Thu, 14 Oct 2021 23:49:17 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 56a0a63a-2d49-11ec-8211-12813bfff9fa;
 Thu, 14 Oct 2021 23:49:15 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id 5B8EA610F9;
 Thu, 14 Oct 2021 23:49:14 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 56a0a63a-2d49-11ec-8211-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1634255354;
	bh=Sj7og8kHDcDF2pFW/YETFtKnbaRmY7+05DrA1J8TffI=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=TMAPl0yXStn4elAUdxsPuO09qUHGm9jfq8DYRWKCc9N4m8b8pH/05g1tsklxlbH31
	 xnqi83pI7N/jA7ViA02B0yAewWTHlbGPwAkt2DbbBqwI3p/tb3lOLi5ffK/W/+PzCq
	 n7Qtwgibif7j7xrHKJ4Q82wD2nWLreS1WZ2LJn9GugLaCg2YGyQ6E3xeUVlzmJbuNE
	 +hvsTIaQipZwpE7sihYMvF/uUPbB+gMFNvJJinCo+EXLmZWPaJzP7QtgCwsYGxzXzX
	 Be/BJd2cf1YYbD1cXFCPoQyEI6uk8H2kd1orYD8WC09uO5/LQfKgcJVojhm5AJRVSE
	 XT93eZZwCD5sw==
Date: Thu, 14 Oct 2021 16:49:13 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Bertrand Marquis <bertrand.marquis@arm.com>
cc: xen-devel@lists.xenproject.org, iwj@xenproject.org, 
    Rahul Singh <rahul.singh@arm.com>, 
    Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, 
    Andrew Cooper <andrew.cooper3@citrix.com>, 
    George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>, 
    Wei Liu <wl@xen.org>, Paul Durrant <paul@xen.org>, 
    =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= <roger.pau@citrix.com>
Subject: Re: [PATCH v6 2/3] xen/arm: Enable the existing x86 virtual PCI
 support for ARM.
In-Reply-To: <396b08e2598cf0338e0c7f4ad3cd5cb66db89224.1634221830.git.bertrand.marquis@arm.com>
Message-ID: <alpine.DEB.2.21.2110141331310.9408@sstabellini-ThinkPad-T480s>
References: <cover.1634221830.git.bertrand.marquis@arm.com> <396b08e2598cf0338e0c7f4ad3cd5cb66db89224.1634221830.git.bertrand.marquis@arm.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: multipart/mixed; BOUNDARY="8323329-609136478-1634244065=:9408"
Content-ID: <alpine.DEB.2.21.2110141347510.9408@sstabellini-ThinkPad-T480s>

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-609136478-1634244065=:9408
Content-Type: text/plain; CHARSET=UTF-8
Content-Transfer-Encoding: 8BIT
Content-ID: <alpine.DEB.2.21.2110141347511.9408@sstabellini-ThinkPad-T480s>

On Thu, 14 Oct 2021, Bertrand Marquis wrote:
> From: Rahul Singh <rahul.singh@arm.com>
> 
> The existing VPCI support available for X86 is adapted for Arm.
> When the device is added to XEN via the hyper call
> “PHYSDEVOP_pci_device_add”, VPCI handler for the config space
> access is added to the Xen to emulate the PCI devices config space.
> 
> A MMIO trap handler for the PCI ECAM space is registered in XEN
> so that when guest is trying to access the PCI config space,XEN
> will trap the access and emulate read/write using the VPCI and
> not the real PCI hardware.
> 
> For Dom0less systems scan_pci_devices() would be used to discover the
> PCI device in XEN and VPCI handler will be added during XEN boots.
> 
> This patch is also doing some small fixes to fix compilation errors on
> arm32 of vpci:
> - add a cast to unsigned long in print in header.c
> - add a cast to uint64_t in vpci_ecam_mmio_write

Thank you for these! Strictly speaking they are not required now but
they are welcome. I would also be OK if they were removed from this
patch but it is fine to have them in here.

There is an issues with this patch, see below at the bottom


> Signed-off-by: Rahul Singh <rahul.singh@arm.com>
> Signed-off-by: Bertrand Marquis <bertrand.marquis@arm.com>
>
> ---
> Changes in v6:
> - Use new vpci_ecam_ helpers for PCI access
> - Do not set XEN_DOMCTL_CDF_vpci for dom0 for now (will be done in a
> future patch once everything is ready)
> - rename REGISTER_OFFSET to ECAM_REG_OFFSET and move it to pci.h
> - remove not needed local variables in vpci_mmio_write, the one in read
> has been kept to ensure proper compilation on arm32
> - move call to vpci_add_handlers before iommu init to simplify exit path
> - move call to pci_cleanup_msi in the out section of pci_add_device if
> pdev is not NULL and on error
> - initialize pdev to NULL to handle properly exit path call of
> pci_cleanup_msi
> - keep has_vpci to return false for now as CFG_vpci has been removed.
> Added a comment on top of the definition.
> - fix compilation errors on arm32 (print in header.c, cast missing in
> mmio_write.
> - local variable was kept in vpci_mmio_read on arm to prevent a cast
> error in arm32.
> Change in v5:
> - Add pci_cleanup_msi(pdev) incleanup part.
> - Added Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
> Change in v4:
> - Move addition of XEN_DOMCTL_CDF_vpci flag to separate patch
> Change in v3:
> - Use is_pci_passthrough_enabled() in place of pci_passthrough_enabled variable
> - Reject XEN_DOMCTL_CDF_vpci for x86 in arch_sanitise_domain_config()
> - Remove IS_ENABLED(CONFIG_HAS_VPCI) from has_vpci()
> Change in v2:
> - Add new XEN_DOMCTL_CDF_vpci flag
> - modify has_vpci() to include XEN_DOMCTL_CDF_vpci
> - enable vpci support when pci-passthough option is enabled.
> ---
> ---
>  xen/arch/arm/Makefile         |  1 +
>  xen/arch/arm/domain.c         |  4 ++
>  xen/arch/arm/vpci.c           | 74 +++++++++++++++++++++++++++++++++++
>  xen/arch/arm/vpci.h           | 36 +++++++++++++++++
>  xen/drivers/passthrough/pci.c | 18 ++++++++-
>  xen/drivers/vpci/header.c     |  3 +-
>  xen/drivers/vpci/vpci.c       |  2 +-
>  xen/include/asm-arm/domain.h  |  1 +
>  xen/include/asm-x86/pci.h     |  2 -
>  xen/include/public/arch-arm.h |  7 ++++
>  xen/include/xen/pci.h         |  3 ++
>  11 files changed, 146 insertions(+), 5 deletions(-)
>  create mode 100644 xen/arch/arm/vpci.c
>  create mode 100644 xen/arch/arm/vpci.h
> 
> diff --git a/xen/arch/arm/Makefile b/xen/arch/arm/Makefile
> index 64518848b2..07f634508e 100644
> --- a/xen/arch/arm/Makefile
> +++ b/xen/arch/arm/Makefile
> @@ -7,6 +7,7 @@ ifneq ($(CONFIG_NO_PLAT),y)
>  obj-y += platforms/
>  endif
>  obj-$(CONFIG_TEE) += tee/
> +obj-$(CONFIG_HAS_VPCI) += vpci.o
>  
>  obj-$(CONFIG_HAS_ALTERNATIVE) += alternative.o
>  obj-y += bootfdt.init.o
> diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
> index eef0661beb..96e1b23550 100644
> --- a/xen/arch/arm/domain.c
> +++ b/xen/arch/arm/domain.c
> @@ -39,6 +39,7 @@
>  #include <asm/vgic.h>
>  #include <asm/vtimer.h>
>  
> +#include "vpci.h"
>  #include "vuart.h"
>  
>  DEFINE_PER_CPU(struct vcpu *, curr_vcpu);
> @@ -773,6 +774,9 @@ int arch_domain_create(struct domain *d,
>      if ( is_hardware_domain(d) && (rc = domain_vuart_init(d)) )
>          goto fail;
>  
> +    if ( (rc = domain_vpci_init(d)) != 0 )
> +        goto fail;
> +
>      return 0;
>  
>  fail:
> diff --git a/xen/arch/arm/vpci.c b/xen/arch/arm/vpci.c
> new file mode 100644
> index 0000000000..7c3552b65d
> --- /dev/null
> +++ b/xen/arch/arm/vpci.c
> @@ -0,0 +1,74 @@
> +/*
> + * xen/arch/arm/vpci.c
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; either version 2 of the License, or
> + * (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + */
> +#include <xen/sched.h>
> +#include <xen/vpci.h>
> +
> +#include <asm/mmio.h>
> +
> +static int vpci_mmio_read(struct vcpu *v, mmio_info_t *info,
> +                          register_t *r, void *p)
> +{
> +    pci_sbdf_t sbdf;
> +    /* data is needed to prevent a pointer cast on 32bit */
> +    unsigned long data = ~0ul;
> +    int ret;
> +
> +    /* We ignore segment part and always handle segment 0 */
> +    sbdf.sbdf = ECAM_BDF(info->gpa);
> +
> +    ret = vpci_ecam_mmio_read(sbdf, ECAM_REG_OFFSET(info->gpa),
> +                              1U << info->dabt.size, &data);
> +
> +    *r = data;
> +
> +    return ret;
> +}
> +
> +static int vpci_mmio_write(struct vcpu *v, mmio_info_t *info,
> +                           register_t r, void *p)
> +{
> +    pci_sbdf_t sbdf;
> +
> +    /* We ignore segment part and always handle segment 0 */
> +    sbdf.sbdf = ECAM_BDF(info->gpa);
> +
> +    return vpci_ecam_mmio_write(sbdf, ECAM_REG_OFFSET(info->gpa),
> +                                1U << info->dabt.size, r);
> +}
> +
> +static const struct mmio_handler_ops vpci_mmio_handler = {
> +    .read  = vpci_mmio_read,
> +    .write = vpci_mmio_write,
> +};
> +
> +int domain_vpci_init(struct domain *d)
> +{
> +    if ( !has_vpci(d) )
> +        return 0;
> +
> +    register_mmio_handler(d, &vpci_mmio_handler,
> +                          GUEST_VPCI_ECAM_BASE, GUEST_VPCI_ECAM_SIZE, NULL);
> +
> +    return 0;
> +}
> +
> +/*
> + * Local variables:
> + * mode: C
> + * c-file-style: "BSD"
> + * c-basic-offset: 4
> + * indent-tabs-mode: nil
> + * End:
> + */
> +
> diff --git a/xen/arch/arm/vpci.h b/xen/arch/arm/vpci.h
> new file mode 100644
> index 0000000000..d8a7b0e3e8
> --- /dev/null
> +++ b/xen/arch/arm/vpci.h
> @@ -0,0 +1,36 @@
> +/*
> + * xen/arch/arm/vpci.h
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; either version 2 of the License, or
> + * (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + */
> +
> +#ifndef __ARCH_ARM_VPCI_H__
> +#define __ARCH_ARM_VPCI_H__
> +
> +#ifdef CONFIG_HAS_VPCI
> +int domain_vpci_init(struct domain *d);
> +#else
> +static inline int domain_vpci_init(struct domain *d)
> +{
> +    return 0;
> +}
> +#endif
> +
> +#endif /* __ARCH_ARM_VPCI_H__ */
> +
> +/*
> + * Local variables:
> + * mode: C
> + * c-file-style: "BSD"
> + * c-basic-offset: 4
> + * indent-tabs-mode: nil
> + * End:
> + */
> diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci.c
> index 3aa8c3175f..8cc529ecec 100644
> --- a/xen/drivers/passthrough/pci.c
> +++ b/xen/drivers/passthrough/pci.c
> @@ -658,7 +658,7 @@ int pci_add_device(u16 seg, u8 bus, u8 devfn,
>                     const struct pci_dev_info *info, nodeid_t node)
>  {
>      struct pci_seg *pseg;
> -    struct pci_dev *pdev;
> +    struct pci_dev *pdev = NULL;
>      unsigned int slot = PCI_SLOT(devfn), func = PCI_FUNC(devfn);
>      const char *pdev_type;
>      int ret;
> @@ -752,6 +752,19 @@ int pci_add_device(u16 seg, u8 bus, u8 devfn,
>  
>      check_pdev(pdev);
>  
> +#ifdef CONFIG_ARM
> +    /*
> +     * On ARM PCI devices discovery will be done by Dom0. Add vpci handler when
> +     * Dom0 inform XEN to add the PCI devices in XEN.
> +     */
> +    ret = vpci_add_handlers(pdev);
> +    if ( ret )
> +    {
> +        printk(XENLOG_ERR "Setup of vPCI failed: %d\n", ret);
> +        goto out;
> +    }
> +#endif
> +
>      ret = 0;
>      if ( !pdev->domain )
>      {
> @@ -784,6 +797,9 @@ out:
>                     &PCI_SBDF(seg, bus, slot, func));
>          }
>      }
> +    else if ( pdev )
> +        pci_cleanup_msi(pdev);
> +
>      return ret;
>  }
>  
> diff --git a/xen/drivers/vpci/header.c b/xen/drivers/vpci/header.c
> index f8cd55e7c0..c5b025b88b 100644
> --- a/xen/drivers/vpci/header.c
> +++ b/xen/drivers/vpci/header.c
> @@ -374,7 +374,8 @@ static void bar_write(const struct pci_dev *pdev, unsigned int reg,
>          if ( val != (uint32_t)(bar->addr >> (hi ? 32 : 0)) )
>              gprintk(XENLOG_WARNING,
>                      "%pp: ignored BAR %lu write with memory decoding enabled\n",
> -                    &pdev->sbdf, bar - pdev->vpci->header.bars + hi);
> +                    &pdev->sbdf,
> +                    (unsigned long)(bar - pdev->vpci->header.bars + hi));
>          return;
>      }
>  
> diff --git a/xen/drivers/vpci/vpci.c b/xen/drivers/vpci/vpci.c
> index c0853176d7..2bd67fc27a 100644
> --- a/xen/drivers/vpci/vpci.c
> +++ b/xen/drivers/vpci/vpci.c
> @@ -507,7 +507,7 @@ int vpci_ecam_mmio_write(pci_sbdf_t sbdf, unsigned int reg, unsigned int len,
>  
>      vpci_write(sbdf, reg, min(4u, len), data);
>      if ( len == 8 )
> -        vpci_write(sbdf, reg + 4, 4, data >> 32);
> +        vpci_write(sbdf, reg + 4, 4, (uint64_t)data >> 32);
>  
>      return 1;
>  }
> diff --git a/xen/include/asm-arm/domain.h b/xen/include/asm-arm/domain.h
> index 14e575288f..9b3647587a 100644
> --- a/xen/include/asm-arm/domain.h
> +++ b/xen/include/asm-arm/domain.h
> @@ -263,6 +263,7 @@ static inline void arch_vcpu_block(struct vcpu *v) {}
>  
>  #define arch_vm_assist_valid_mask(d) (1UL << VMASST_TYPE_runstate_update_flag)
>  
> +/* vPCI is not available on Arm */
>  #define has_vpci(d)    ({ (void)(d); false; })
>  
>  #endif /* __ASM_DOMAIN_H__ */
> diff --git a/xen/include/asm-x86/pci.h b/xen/include/asm-x86/pci.h
> index a0df5c1279..443f25347d 100644
> --- a/xen/include/asm-x86/pci.h
> +++ b/xen/include/asm-x86/pci.h
> @@ -6,8 +6,6 @@
>  #define CF8_ADDR_HI(cf8) (  ((cf8) & 0x0f000000) >> 16)
>  #define CF8_ENABLED(cf8) (!!((cf8) & 0x80000000))
>  
> -#define ECAM_BDF(addr)   ( ((addr) & 0x0ffff000) >> 12)
> -
>  #define IS_SNB_GFX(id) (id == 0x01068086 || id == 0x01168086 \
>                          || id == 0x01268086 || id == 0x01028086 \
>                          || id == 0x01128086 || id == 0x01228086 \
> diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h
> index d46c61fca9..44be337dec 100644
> --- a/xen/include/public/arch-arm.h
> +++ b/xen/include/public/arch-arm.h
> @@ -418,6 +418,13 @@ typedef uint64_t xen_callback_t;
>  #define GUEST_GICV3_GICR0_BASE     xen_mk_ullong(0x03020000) /* vCPU0..127 */
>  #define GUEST_GICV3_GICR0_SIZE     xen_mk_ullong(0x01000000)
>  
> +/*
> + * 256 MB is reserved for VPCI configuration space based on calculation
> + * 256 buses × 32 devices × 8 functions × 4 KB = 256 MB
> + */

Somehow 3 non-ascii characters sneaked into this patch. The 'x' are not
'x' but are 0xc3 and cause the following errors in a few gitlab-ci
builds:

python3 mkheader.py arm32 arm32.h.tmp /builds/xen-project/people/sstabellini/xen/tools/include/xen-foreign/../../../xen/include/public/arch-arm.h /builds/xen-project/people/sstabellini/xen/tools/include/xen-foreign/../../../xen/include/public/xen.h
Traceback (most recent call last):
  File "mkheader.py", line 120, in <module>
    input += f.read();
  File "/usr/lib/python3.5/encodings/ascii.py", line 26, in decode
    return codecs.ascii_decode(input, self.errors)[0]
UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 14641: ordinal not in range(128)
Makefile:28: recipe for target 'arm32.h' failed
make[2]: *** [arm32.h] Error 1

Full logs here:
https://gitlab.com/xen-project/people/sstabellini/xen/-/pipelines/38855078
https://gitlab.com/xen-project/people/sstabellini/xen/-/jobs/16810108756


Replacing the 3 characters with 'x' solves the problem.
https://gitlab.com/xen-project/people/sstabellini/xen/-/pipelines/388721262


With the three 'x' changed to ascii:

Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>



> +#define GUEST_VPCI_ECAM_BASE    xen_mk_ullong(0x10000000)
> +#define GUEST_VPCI_ECAM_SIZE    xen_mk_ullong(0x10000000)
> +
>  /* ACPI tables physical address */
>  #define GUEST_ACPI_BASE xen_mk_ullong(0x20000000)
>  #define GUEST_ACPI_SIZE xen_mk_ullong(0x02000000)
> diff --git a/xen/include/xen/pci.h b/xen/include/xen/pci.h
> index 70ac25345c..db18cb7639 100644
> --- a/xen/include/xen/pci.h
> +++ b/xen/include/xen/pci.h
> @@ -40,6 +40,9 @@
>  #define PCI_SBDF3(s,b,df) \
>      ((pci_sbdf_t){ .sbdf = (((s) & 0xffff) << 16) | PCI_BDF2(b, df) })
>  
> +#define ECAM_BDF(addr)         ( ((addr) & 0x0ffff000) >> 12)
> +#define ECAM_REG_OFFSET(addr)  ((addr) & 0x00000fff)
> +
>  typedef union {
>      uint32_t sbdf;
>      struct {
> -- 
> 2.25.1
> 
--8323329-609136478-1634244065=:9408--


From xen-devel-bounces@lists.xenproject.org Thu Oct 14 23:50:43 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 14 Oct 2021 23:50:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.209643.366156 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbAUd-00073x-5i; Thu, 14 Oct 2021 23:50:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 209643.366156; Thu, 14 Oct 2021 23:50:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbAUd-00073q-1w; Thu, 14 Oct 2021 23:50:35 +0000
Received: by outflank-mailman (input) for mailman id 209643;
 Thu, 14 Oct 2021 23:50:33 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=kGop=PC=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1mbAUb-00073i-M2
 for xen-devel@lists.xenproject.org; Thu, 14 Oct 2021 23:50:33 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 8452c0d6-2d49-11ec-8211-12813bfff9fa;
 Thu, 14 Oct 2021 23:50:32 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id D456B60FDA;
 Thu, 14 Oct 2021 23:50:30 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8452c0d6-2d49-11ec-8211-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1634255431;
	bh=RKNmVoYNxdnpzMYxxYcm4flnvFopG/Vk/BaBEJLew54=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=F0ONuDybnF3lQl/6CmixV7atdro/iWAqkg4TlCjkqxdC629KDwWDLzcP98vraShY5
	 57RVsEEJVGOwu3ngH915QhNvvcDxvvg0U4kClHhiF68O5029L1awHLXLtuaTJEIoyP
	 3aFzDBOJ4iijRvsf+eZ3RtLJG5DwfgQuNcKm3juTvOeDPo4BX6OknhRnnsDXOAIwEn
	 gfn+73PEynoU3aOhUMMpSnJp2G4s+9j8tCuUsbIs/rwzdXruhxpey4qE0n7Omj7Gdr
	 K2Qn0Xs3exWcrCkz8VHQ2mrMnG1d5MUx+kAQdkZ6apLQ3GSOvDcqzOzq3S0KNzUjgE
	 jcqshmEEo5XIg==
Date: Thu, 14 Oct 2021 16:50:29 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Ian Jackson <iwj@xenproject.org>
cc: Bertrand Marquis <Bertrand.Marquis@arm.com>, 
    xen-devel@lists.xenproject.org, Rahul Singh <rahul.singh@arm.com>, 
    Wei Liu <wl@xen.org>, Anthony PERARD <anthony.perard@citrix.com>, 
    Juergen Gross <jgross@suse.com>, 
    Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, 
    Michal Orzel <michal.orzel@arm.com>, 
    Andre Przywara <Andre.Przywara@arm.com>
Subject: Re: [PATCH v6 3/3] arm/libxl: Emulated PCI device tree node in libxl
 [and 1 more messages]
In-Reply-To: <24936.28385.679884.535704@mariner.uk.xensource.com>
Message-ID: <alpine.DEB.2.21.2110141343450.9408@sstabellini-ThinkPad-T480s>
References: <cover.1633540842.git.rahul.singh@arm.com> <b81b5dea800c8fe47071f3dbd20588b1e472fb99.1633540842.git.rahul.singh@arm.com> <7bdac405-a889-15e1-be19-5876f7253855@xen.org> <24926.53690.621007.507249@mariner.uk.xensource.com> <294BE20A-7E45-405C-BC19-C292295E85E3@arm.com>
 <24927.7235.736221.270358@mariner.uk.xensource.com> <8A04B9B2-E816-425E-BF1B-5A8B89F8836C@arm.com> <cover.1634221830.git.bertrand.marquis@arm.com> <fd9c54a381daa52436b0a1b27cf1bba8e7ff9af9.1634221830.git.bertrand.marquis@arm.com>
 <24936.28385.679884.535704@mariner.uk.xensource.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Thu, 14 Oct 2021, Ian Jackson wrote:
> (Replying to both the earlier subthread on v5 and to the new v6
> patch.)
> 
> Bertrand Marquis writes ("Re: [PATCH v5 10/11] arm/libxl: Emulated PCI device tree node in libxl"):
> > Now you suggest to add a new field arm_vpci in libxl__domain_create_state.
> 
> Hi.  I was handwaving, hence "probably" :-).  I hadn't actually looked
> at the existing code to see precisely how it would fit.
> 
> > Once we have done that I will need to access this structure to know if I need
> > to add the DT part and somehow to give it a value depending something which
> > for now would the number of pcidevs as there will be no user parameter anymore.
> 
> Right.
> 
> I looked at libxl_arm.c again:
> 
> It seems that the main entrypoint to all this is libxl__prepare_dtb,
> and it is that function you want to do new stuff.  That gets
> libxl_domain_build_info (which is specified by the IDL and comes from
> outside libxl, subject to libxl's default-filling machinery) and
> libxl__domain_build_state (which is the general state struct).
> 
> The information you need is is libxl_domain_create_info.
> libxl__domain_config_setdefault already arranges to set
> c_info->passthrough based on the number of PCI PT devices
> (search for `need_pt` in libxl_create.c).
> 
> That is, as I understand it on ARM vpci should be enabled if
> passthrough is enabled and not otherwise.  That is precisely what
> the variable c_info->passthrough is.
> 
> There is a slight issue because of the distinction between create_info
> and build_info and domain_config (and, the corresponding _state)
> structs.  Currently the DT code ony gets b_info, not the whole
> libxl_domain_config.  These distinctions largely historical nowadays.
> Certainly there is no reason not to pass a pointer to the whole
> libxl_domain_config, rather than just libxl_domain_build_info, into
> libxl__arch_domain_init_hw_description.
> 
> So I think the right approach for this looks something like this:
> 
> 1. Change libxl__arch_domain_init_hw_description to take
>    libxl_domain_config* rather than libxl_domain_build_info*.
>    libxl_domain_config contains libxl_domain_build_info so
>    this is easy.
> 
>    If you put in a convenience alias variable for the
>    libxl_domain_build_info* you can avoid extra typing in the function
>    body.  (If you call the convenience alias `info` you won't need to
>    change the body at all, but maybe `info` isn't the best name so you
>    could rename it to `b_info` maybe; up to you.)
> 
> 2. Make the same change to libxl__prepare_dtb.
> 
> 3. Now you can use d_config->c_info.passthrough to gate the addition
>    of the additional stuff to the DT.  Ie, that is a respin of this
>    patch 3/3.
> 
> 1 and 2 need to be separated out from 3, in a different patch (or two
> different patches) added to this series before what is now 3/3.  Ie
> 1+2, or 1 and 2 separately, should be pure plumbing changes with no
> functional change.
> 
> I hope this is helpful.

The explanation is clear and makes sense to me too.

FYI I suggested something similar and Rahul agreed on it; in fact, he
seemed to have already made the change and tested it:
https://marc.info/?l=xen-devel&m=163362066215155

I am just mentioning it in case Bertrand might be able to find Rahul's
updated patch somewhere and it might be useful as a base for his work.

The rest looks good, including the new changes.


From xen-devel-bounces@lists.xenproject.org Fri Oct 15 01:27:27 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 01:27:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.209654.366167 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbC09-00014p-Ts; Fri, 15 Oct 2021 01:27:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 209654.366167; Fri, 15 Oct 2021 01:27:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbC09-00014i-Qn; Fri, 15 Oct 2021 01:27:13 +0000
Received: by outflank-mailman (input) for mailman id 209654;
 Fri, 15 Oct 2021 01:27:13 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mbC09-00014Y-3I; Fri, 15 Oct 2021 01:27:13 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mbC08-0007QH-PE; Fri, 15 Oct 2021 01:27:12 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mbC08-0002Bm-8Q; Fri, 15 Oct 2021 01:27:12 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mbC08-0005n8-7r; Fri, 15 Oct 2021 01:27:12 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=GXLt9sC1EUeJLy6/ZLsGvK7V9Gu4bdsJgDJY4F9HrFc=; b=tqejeZQDZLrByNN6PlMu2PmUjZ
	dkhZ5qin0g8r2mpCHVFC9GAyYiUVZU4UKLDt5Lo2/+hByuejWrKzPKU2TbNkQ/rOytwyk6lLvHogJ
	DYzynpVyNfnyv579Upzf4g2149GWPEos6Tt58BcbsiH5UYicNwyLBJxiLHH6t4LC09WA=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165509-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 165509: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-unstable:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=4cfab4425d39f76660b4e76ba6ee4cbf0f92e7e5
X-Osstest-Versions-That:
    xen=9e319e5258d0274c15da2ea9355dc1569a0fa832
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 15 Oct 2021 01:27:12 +0000

flight 165509 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165509/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-rtds     20 guest-localmigrate/x10       fail  like 165503
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 165503
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 165503
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165503
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165503
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 165503
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 165503
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 165503
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 165503
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 165503
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 165503
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165503
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 165503
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  4cfab4425d39f76660b4e76ba6ee4cbf0f92e7e5
baseline version:
 xen                  9e319e5258d0274c15da2ea9355dc1569a0fa832

Last test of basis   165503  2021-10-13 23:38:04 Z    1 days
Testing same since   165509  2021-10-14 13:09:36 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Jan Beulich <jbeulich@suse.com>
  Julien Grall <jgrall@amazon.com>
  Luca Fancellu <luca.fancellu@arm.com>
  Rahul Singh <rahul.singh@arm.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     fail    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   9e319e5258..4cfab4425d  4cfab4425d39f76660b4e76ba6ee4cbf0f92e7e5 -> master


From xen-devel-bounces@lists.xenproject.org Fri Oct 15 03:10:30 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 03:10:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.209667.366203 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbDbz-0003IL-6m; Fri, 15 Oct 2021 03:10:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 209667.366203; Fri, 15 Oct 2021 03:10:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbDbz-0003IE-3g; Fri, 15 Oct 2021 03:10:23 +0000
Received: by outflank-mailman (input) for mailman id 209667;
 Fri, 15 Oct 2021 03:10:22 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=lHOs=PD=arm.com=Penny.Zheng@srs-us1.protection.inumbo.net>)
 id 1mbDby-00031m-HR
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 03:10:22 +0000
Received: from EUR05-AM6-obe.outbound.protection.outlook.com (unknown
 [2a01:111:f400:7e1b::621])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id b63b6b2c-76f8-4417-a6f8-a227120815dc;
 Fri, 15 Oct 2021 03:10:18 +0000 (UTC)
Received: from DB6PR0601CA0043.eurprd06.prod.outlook.com (2603:10a6:4:17::29)
 by DB6PR0801MB1765.eurprd08.prod.outlook.com (2603:10a6:4:38::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.17; Fri, 15 Oct
 2021 03:10:16 +0000
Received: from DB5EUR03FT053.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:4:17:cafe::8d) by DB6PR0601CA0043.outlook.office365.com
 (2603:10a6:4:17::29) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15 via Frontend
 Transport; Fri, 15 Oct 2021 03:10:16 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT053.mail.protection.outlook.com (10.152.21.119) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.15 via Frontend Transport; Fri, 15 Oct 2021 03:10:16 +0000
Received: ("Tessian outbound b9598e0ead92:v103");
 Fri, 15 Oct 2021 03:10:16 +0000
Received: from abdff308bcca.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 4655ED72-7ECA-4A4D-B635-EDAD75685562.1; 
 Fri, 15 Oct 2021 03:10:08 +0000
Received: from EUR02-AM5-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id abdff308bcca.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 15 Oct 2021 03:10:08 +0000
Received: from AM6P193CA0114.EURP193.PROD.OUTLOOK.COM (2603:10a6:209:85::19)
 by HE1PR0802MB2508.eurprd08.prod.outlook.com (2603:10a6:3:da::9) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.20; Fri, 15 Oct
 2021 03:10:06 +0000
Received: from VE1EUR03FT009.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:209:85:cafe::9e) by AM6P193CA0114.outlook.office365.com
 (2603:10a6:209:85::19) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16 via Frontend
 Transport; Fri, 15 Oct 2021 03:10:06 +0000
Received: from nebula.arm.com (40.67.248.234) by
 VE1EUR03FT009.mail.protection.outlook.com (10.152.18.92) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.4608.15 via Frontend Transport; Fri, 15 Oct 2021 03:10:06 +0000
Received: from AZ-NEU-EX01.Emea.Arm.com (10.251.26.4) by AZ-NEU-EX04.Arm.com
 (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2308.14; Fri, 15 Oct
 2021 03:10:13 +0000
Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX01.Emea.Arm.com
 (10.251.26.4) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14; Fri, 15
 Oct 2021 03:10:02 +0000
Received: from penny.shanghai.arm.com (10.169.190.66) by mail.arm.com
 (10.251.24.32) with Microsoft SMTP Server id 15.1.2308.14 via Frontend
 Transport; Fri, 15 Oct 2021 03:10:10 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b63b6b2c-76f8-4417-a6f8-a227120815dc
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=UxQzaj8bxDJrQZPGe9E3dFpGC2GbrG4KgFstgpHsfm8=;
 b=3GbRs4RNhe3nKnZi7wFAY4qlFTF8G9Tr0qgDqoS+E3q3PYufQsSlNVjhCHXpe8mb0JY3LWpCBSenXt/sT6NaasvXFyCSgjMmqA954boPTcpJ+H+DkI+IL9iVhMtTtf8RwKr6OPJQMZxmPJtlHYP/FlANtL9zF5yJ0oOZEqEsa6M=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: afbeba64a31eb55c
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=mwPUvxzo4rmFYgBHlmdHhqsqAuUpCIFNZRDMBOq7Fm3h0XbBurTJhhClN9uFrfj+rQJO3USDaCIEZsKKW2i1EOdAjOzkj76hP3emRqBvDmKRIc7/kZjR+TxckUNrdGEIzp68PbwJjT9vx1bfip0MTyyh0txLyQsM5Xr5v0NhBCePLctOTMXzO3TaX56dTLpOKxe/1gCis2qRmPBW8zrs5UdpoiZF15iDHaUom8axKW8xrJuXUadmOMniHRaTwDABHMBiJLT7TTfYn6DzFDHtKL1LjZCy1IcGwi0lMO84VTsC2IbFNP9DhxAv2gpw9Ly2Y1mND+ieFUckF4dxk+Jz/Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=UxQzaj8bxDJrQZPGe9E3dFpGC2GbrG4KgFstgpHsfm8=;
 b=SuAtWNzbyGWEBvWr6AA2iRNvu3M1uv3zN/pjlKCPcXFJC6D/cOJO+LUmhy5HBm4pW8sCV8yIuQFn1fu/O4PN48wpZ6v/SgqkisyN+XF/95/5k+QqH9TKNCX8glU8nSZFnE4+NiXz7ME9KztU4AANsif/B37f1UIboKeSsPkR0bxL2rFOvxj+pm+AHi00frAMzRYK0K0zvAfQ9S39BBRpFkTc/N8Z31zvKONevaWLktDGYLcfRfrxMYcz9a2iIAlbGcBblu5BxSsWFOmiYhsqYy90Yb+evGvHo9TGvxRwsQZab+Q5I9XerLNZpMW9ulk5fsICdfkXJgEbval/wVCgFA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=UxQzaj8bxDJrQZPGe9E3dFpGC2GbrG4KgFstgpHsfm8=;
 b=3GbRs4RNhe3nKnZi7wFAY4qlFTF8G9Tr0qgDqoS+E3q3PYufQsSlNVjhCHXpe8mb0JY3LWpCBSenXt/sT6NaasvXFyCSgjMmqA954boPTcpJ+H+DkI+IL9iVhMtTtf8RwKr6OPJQMZxmPJtlHYP/FlANtL9zF5yJ0oOZEqEsa6M=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=pass action=none
 header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 40.67.248.234 as permitted sender) receiver=protection.outlook.com;
 client-ip=40.67.248.234; helo=nebula.arm.com;
From: Penny Zheng <penny.zheng@arm.com>
To: <xen-devel@lists.xenproject.org>, <sstabellini@kernel.org>,
	<julien@xen.org>
CC: <Wei.Chen@arm.com>, <Bertrand.Marquis@arm.com>
Subject: [PATCH v2 1/6] xen: introduce XEN_DOMCTL_CDF_directmap
Date: Fri, 15 Oct 2021 03:09:40 +0000
Message-ID: <20211015030945.2082898-2-penny.zheng@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20211015030945.2082898-1-penny.zheng@arm.com>
References: <20211015030945.2082898-1-penny.zheng@arm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
X-EOPAttributedMessage: 1
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 6d86e9e0-ace6-43ae-bcbb-08d98f894ffb
X-MS-TrafficTypeDiagnostic: HE1PR0802MB2508:|DB6PR0801MB1765:
X-Microsoft-Antispam-PRVS:
	<DB6PR0801MB1765D66EC0DBF355BD205423F7B99@DB6PR0801MB1765.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Oob-TLC-OOBClassifiers: OLM:3631;OLM:3631;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 U1ty+ibemTCbIeGMwF4OAHVZDsAsc2PYbhSfnRSCutv4EBvjdP0WQpaLtns1eAwkSbnvy9acf5/afkzc25Jc7/Ra4XOZ4F+vruchFuq7o8qMuPMQsmEJBdiIzFU8yhzKCh0vU7Rm+mSknpVdGfOsPNfK3y/TBgKbjWm3QU25PSMIMmIyjJ3G25dcaefVtmHX2ovy+ykkVCJRCKXa6lQVo8elLcuMjiZRAFa2JwxMY7Hcydukco4nvbbxk2gbEzSc9YoBjf/iq2xLRb8k08IfB/3l0UYHB3Lj8X3gBCCTwz9joBSlESUKBrxccDXpWqKO9ihcBAVd5VaGQV2UUKrudmSeMEf1POPg2SJBpTrmTEd41zW6W6r+YSRbc+oPT3coVR0FrKavWLwPbUrQvLMbB9toAM5RZsgEqREQPzWpgd0kGZViuhnQeikV6p7lnP3k5O/4zN58OrmFmOqzMcopRNGXWtpreOjFTTOWj1OQIhAj08p+bhhmCB8j0pCqsWeyFE1WTjzQosTH3RPG6jaVKx9g0/4ovH4gWapdF+PLMJPgUsTduU2OkqKDL8eSwf7NVMea1qPRgw1ub2Wgj2x8GVi8HwEnfpoRXcv0QlNHsJbPU+tAWUfAPkqtTckm6XGT3a5ZNBAjZV6y5TnlWYWF1C5CTLeDkwZxSgR/5R5N9YivJbaCxtWOmJbgmlp63BMHKRNH37YAOc57ORooREyNKtv+CrhAzOBJZ4NfNAD4Xwo=
X-Forefront-Antispam-Report-Untrusted:
 CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(316002)(26005)(2616005)(426003)(110136005)(47076005)(36756003)(44832011)(70586007)(83380400001)(86362001)(6666004)(4326008)(8676002)(7696005)(336012)(2906002)(186003)(1076003)(356005)(81166007)(54906003)(8936002)(5660300002)(70206006)(36860700001)(508600001)(82310400003)(36900700001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0802MB2508
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT053.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	ba3333e1-8569-4fa4-ae78-08d98f894a09
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	dRjO+6ZTK7qq6ELIgj8p/EuVggXWBRKIxbCXoTlgyXpNCExEDXaQp7p4YwIXuEhmcVBb0uP8bAfsytT0i0+C86oH8u61J44yTUbyPCFKg1yUEr0Y78fdb9us1LDTd/0kuPWGSH1Y/NZCaYUjQ1M2R76wRiFlDHV1AkxmBbhv47qKtReaXoX6vrvn/K6df8J5C0xrQ4kjM43GbOEsFjYmaY/iOixcoiRjntC4TQIYToJ2BxlYjGXCZLl3qWkg/7VMGdiRrS8vaWVLK2iEfJW6jHW5uFVrpDgVBNso6EYj/mGcgcrflNsGg9At3LBHdzeW+JNi5WOteb4Yn/aD/95p7GlIU1FUu4zepnbY5SIvB8t7XLwCTO8oWGMhHVp8Dpn9j43c4Fg2QE8f0A7Hgj436cZklQB5sdNyCmmdIVXye/SBB4Ha9ALTCxYPNDq8Z9QVPFUfCFNQT8MPLRkyFDyJFklbivxeYUhBDUcsazLXCJeT1U984wvpVIBk8r9vNilATdUnH/7bTLwheCDCr/qx9lNUuzx6yKy0aua+MC3fHhc+PvRQP/kjy7wr/OpPSJeeo82n5eo+pyDS5Wtb8nSzKMDasuV0J1iYmGzbMwFgYv+vCsZaT89qeiFLbbxNHRs+La0+svOAa6ECx2sWis7/3Xu0K2IIhaXVvg2P27LxnuY2OREtZpJMYFluVmzqxdOdjvjicxBYvB6U+7TYsR+kmw==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(2906002)(6666004)(336012)(82310400003)(36860700001)(2616005)(426003)(70586007)(1076003)(70206006)(44832011)(110136005)(5660300002)(7696005)(47076005)(54906003)(8936002)(86362001)(36756003)(316002)(508600001)(83380400001)(186003)(8676002)(4326008)(26005)(81166007);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2021 03:10:16.4755
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 6d86e9e0-ace6-43ae-bcbb-08d98f894ffb
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT053.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0801MB1765

From: Stefano Stabellini <stefano.stabellini@xilinx.com>

This commit introduces a new arm-specific flag XEN_DOMCTL_CDF_directmap to
specify that this domain should have its memory directly mapped
(guest physical address == physical address) at domain creation.

Refine is_domain_direct_mapped to check whether the flag
XEN_DOMCTL_CDF_directmap is set.

Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>
Signed-off-by: Penny Zheng <penny.zheng@arm.com>
---
CC: andrew.cooper3@citrix.com
CC: jbeulich@suse.com
CC: George Dunlap <George.Dunlap@eu.citrix.com>
CC: Ian Jackson <ian.jackson@eu.citrix.com>
CC: Wei Liu <wl@xen.org>
CC: "Roger Pau Monné" <roger.pau@citrix.com>
---
 xen/arch/arm/domain.c        | 3 ++-
 xen/arch/arm/domain_build.c  | 4 +++-
 xen/common/domain.c          | 3 ++-
 xen/include/asm-arm/domain.h | 4 ++--
 xen/include/public/domctl.h  | 4 +++-
 5 files changed, 12 insertions(+), 6 deletions(-)

diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
index eef0661beb..8cee1c6349 100644
--- a/xen/arch/arm/domain.c
+++ b/xen/arch/arm/domain.c
@@ -628,7 +628,8 @@ int arch_sanitise_domain_config(struct xen_domctl_createdomain *config)
 {
     unsigned int max_vcpus;
     unsigned int flags_required = (XEN_DOMCTL_CDF_hvm | XEN_DOMCTL_CDF_hap);
-    unsigned int flags_optional = (XEN_DOMCTL_CDF_iommu | XEN_DOMCTL_CDF_vpmu);
+    unsigned int flags_optional = (XEN_DOMCTL_CDF_iommu | XEN_DOMCTL_CDF_vpmu |
+                                   XEN_DOMCTL_CDF_directmap);
 
     if ( (config->flags & ~flags_optional) != flags_required )
     {
diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
index 0167731ab0..37e2d62d47 100644
--- a/xen/arch/arm/domain_build.c
+++ b/xen/arch/arm/domain_build.c
@@ -3069,8 +3069,10 @@ static int __init construct_dom0(struct domain *d)
 void __init create_dom0(void)
 {
     struct domain *dom0;
+    /* DOM0 has always its memory directly mapped. */
     struct xen_domctl_createdomain dom0_cfg = {
-        .flags = XEN_DOMCTL_CDF_hvm | XEN_DOMCTL_CDF_hap,
+        .flags = XEN_DOMCTL_CDF_hvm | XEN_DOMCTL_CDF_hap |
+                 XEN_DOMCTL_CDF_directmap,
         .max_evtchn_port = -1,
         .max_grant_frames = gnttab_dom0_frames(),
         .max_maptrack_frames = -1,
diff --git a/xen/common/domain.c b/xen/common/domain.c
index 8b53c49d1e..7a6131db74 100644
--- a/xen/common/domain.c
+++ b/xen/common/domain.c
@@ -486,7 +486,8 @@ static int sanitise_domain_config(struct xen_domctl_createdomain *config)
          ~(XEN_DOMCTL_CDF_hvm | XEN_DOMCTL_CDF_hap |
            XEN_DOMCTL_CDF_s3_integrity | XEN_DOMCTL_CDF_oos_off |
            XEN_DOMCTL_CDF_xs_domain | XEN_DOMCTL_CDF_iommu |
-           XEN_DOMCTL_CDF_nested_virt | XEN_DOMCTL_CDF_vpmu) )
+           XEN_DOMCTL_CDF_nested_virt | XEN_DOMCTL_CDF_vpmu |
+           XEN_DOMCTL_CDF_directmap) )
     {
         dprintk(XENLOG_INFO, "Unknown CDF flags %#x\n", config->flags);
         return -EINVAL;
diff --git a/xen/include/asm-arm/domain.h b/xen/include/asm-arm/domain.h
index 14e575288f..fc42c6a310 100644
--- a/xen/include/asm-arm/domain.h
+++ b/xen/include/asm-arm/domain.h
@@ -29,8 +29,8 @@ enum domain_type {
 #define is_64bit_domain(d) (0)
 #endif
 
-/* The hardware domain has always its memory direct mapped. */
-#define is_domain_direct_mapped(d) is_hardware_domain(d)
+/* Check if domain is direct-map memory map. */
+#define is_domain_direct_mapped(d) (d->options & XEN_DOMCTL_CDF_directmap)
 
 struct vtimer {
     struct vcpu *v;
diff --git a/xen/include/public/domctl.h b/xen/include/public/domctl.h
index 238384b5ae..b505a0db51 100644
--- a/xen/include/public/domctl.h
+++ b/xen/include/public/domctl.h
@@ -72,9 +72,11 @@ struct xen_domctl_createdomain {
 #define XEN_DOMCTL_CDF_nested_virt    (1U << _XEN_DOMCTL_CDF_nested_virt)
 /* Should we expose the vPMU to the guest? */
 #define XEN_DOMCTL_CDF_vpmu           (1U << 7)
+/* If this domain has its memory directly mapped? (ARM only) */
+#define XEN_DOMCTL_CDF_directmap      (1U << 8)
 
 /* Max XEN_DOMCTL_CDF_* constant.  Used for ABI checking. */
-#define XEN_DOMCTL_CDF_MAX XEN_DOMCTL_CDF_vpmu
+#define XEN_DOMCTL_CDF_MAX XEN_DOMCTL_CDF_directmap
 
     uint32_t flags;
 
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Fri Oct 15 03:10:30 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 03:10:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.209668.366214 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbDc4-0003bM-G2; Fri, 15 Oct 2021 03:10:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 209668.366214; Fri, 15 Oct 2021 03:10:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbDc4-0003bF-Cj; Fri, 15 Oct 2021 03:10:28 +0000
Received: by outflank-mailman (input) for mailman id 209668;
 Fri, 15 Oct 2021 03:10:27 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=lHOs=PD=arm.com=Penny.Zheng@srs-us1.protection.inumbo.net>)
 id 1mbDc3-00031m-HZ
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 03:10:27 +0000
Received: from EUR05-AM6-obe.outbound.protection.outlook.com (unknown
 [2a01:111:f400:7e1b::615])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 478e79c3-3b59-4c9c-ab95-54e4fa51142d;
 Fri, 15 Oct 2021 03:10:23 +0000 (UTC)
Received: from AM5PR0602CA0006.eurprd06.prod.outlook.com
 (2603:10a6:203:a3::16) by VI1PR0801MB2094.eurprd08.prod.outlook.com
 (2603:10a6:800:8f::18) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.19; Fri, 15 Oct
 2021 03:10:17 +0000
Received: from AM5EUR03FT020.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:203:a3:cafe::bf) by AM5PR0602CA0006.outlook.office365.com
 (2603:10a6:203:a3::16) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.14 via Frontend
 Transport; Fri, 15 Oct 2021 03:10:17 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM5EUR03FT020.mail.protection.outlook.com (10.152.16.116) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.15 via Frontend Transport; Fri, 15 Oct 2021 03:10:17 +0000
Received: ("Tessian outbound 16951d3c485e:v103");
 Fri, 15 Oct 2021 03:10:16 +0000
Received: from b4fc1aacf8d5.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 8527F6A6-7927-4526-A454-593505795FBC.1; 
 Fri, 15 Oct 2021 03:10:10 +0000
Received: from EUR02-AM5-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id b4fc1aacf8d5.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 15 Oct 2021 03:10:10 +0000
Received: from AM6P193CA0133.EURP193.PROD.OUTLOOK.COM (2603:10a6:209:85::38)
 by VI1PR0802MB2493.eurprd08.prod.outlook.com (2603:10a6:800:b3::20) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.19; Fri, 15 Oct
 2021 03:10:09 +0000
Received: from VE1EUR03FT009.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:209:85:cafe::4b) by AM6P193CA0133.outlook.office365.com
 (2603:10a6:209:85::38) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16 via Frontend
 Transport; Fri, 15 Oct 2021 03:10:08 +0000
Received: from nebula.arm.com (40.67.248.234) by
 VE1EUR03FT009.mail.protection.outlook.com (10.152.18.92) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.4608.15 via Frontend Transport; Fri, 15 Oct 2021 03:10:08 +0000
Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX04.Arm.com
 (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.14; Fri, 15 Oct
 2021 03:10:14 +0000
Received: from penny.shanghai.arm.com (10.169.190.66) by mail.arm.com
 (10.251.24.32) with Microsoft SMTP Server id 15.1.2308.14 via Frontend
 Transport; Fri, 15 Oct 2021 03:10:12 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 478e79c3-3b59-4c9c-ab95-54e4fa51142d
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=eA93ev71jjsQB5bD/Q4KXU6rMKPVBWXpRQqghqNRYuk=;
 b=A0YwAEDoKcoO/0kegpd9NoB30Qrcaxd05VYFQQECycJKOYy4dB71hWlko5Fcl5ud3lv0f6Q2vGL2//sQEq0pd+jC0KHqLZNA/DbBZwTieMC2aM/bggFuj1FJ7O6ejzLstqh+I6ORhmzbYaLxxXmLsiSM1+YE7Z0BbwgO6JnlqFI=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: c7f61cf881b5bfb6
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=XBGFasJdHTeoNAUWibNZsrpRAH6dI2edm+1LOXVqFLx4Iro6FZhnEv9sTGJUni4pYDFOjB6lqFGDrRQH+ehlpu6jG991xD6cMWrd2Qt7+/WlfzHFE9az7rIZogIXkHveDcbw2RImI3AL3/JBZ9VUkFAWfpRnas1eHoOomZ0E4wYQ5xdKl9fTTSHrL2YAh8qAfxCkgiprJWRngx/wIdS7g8EWWeLgqcr85FJT19HpNhyTupJoOCeGtblsH3DuCdNClVL8nYi69oNOSnopHRB6ZUJbyKepvEakHYp+u7N3rb7kCo0o8LeXC4Y60/Rx86J8msDS5uJmn0/ViwTaFVIjkQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=eA93ev71jjsQB5bD/Q4KXU6rMKPVBWXpRQqghqNRYuk=;
 b=bsodUXocBRVGcnOoZHXz0HL4gE5SPHK8QDa+xEFApVUWhChW5PEg9hbmVokYhXr9sXnFKH6dzXcVm+WNfZ2yHKzktmZg6TOjG76rQA+RQgQvgpPW7MMv2wg90/FVdoCaX1naq3RIIe8+CTSo9X5mgd/z91vn5B6hlfvr6zcQ+SlNpqZnZsT8K5Pxs4VHndQFCE3osAvwGYbE/ip8uN7WKW3r36dysZ7AzGGddvS5JCkJtr7kDiWLMB5w0xJQSZAZGYYzcDoRHEam58dHT1vczRkvDIsS7bDSU3J4lEmjzkhvYy1FkhMnN+lfgiFzgZeXBolTOl+UtZrXZSyyIVoEHw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=eA93ev71jjsQB5bD/Q4KXU6rMKPVBWXpRQqghqNRYuk=;
 b=A0YwAEDoKcoO/0kegpd9NoB30Qrcaxd05VYFQQECycJKOYy4dB71hWlko5Fcl5ud3lv0f6Q2vGL2//sQEq0pd+jC0KHqLZNA/DbBZwTieMC2aM/bggFuj1FJ7O6ejzLstqh+I6ORhmzbYaLxxXmLsiSM1+YE7Z0BbwgO6JnlqFI=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=pass action=none
 header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 40.67.248.234 as permitted sender) receiver=protection.outlook.com;
 client-ip=40.67.248.234; helo=nebula.arm.com;
From: Penny Zheng <penny.zheng@arm.com>
To: <xen-devel@lists.xenproject.org>, <sstabellini@kernel.org>,
	<julien@xen.org>
CC: <Wei.Chen@arm.com>, <Bertrand.Marquis@arm.com>
Subject: [PATCH v2 2/6] xen/arm: introduce direct-map for domUs
Date: Fri, 15 Oct 2021 03:09:41 +0000
Message-ID: <20211015030945.2082898-3-penny.zheng@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20211015030945.2082898-1-penny.zheng@arm.com>
References: <20211015030945.2082898-1-penny.zheng@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-EOPAttributedMessage: 1
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: b49a3d1b-72ab-41b6-792a-08d98f895064
X-MS-TrafficTypeDiagnostic: VI1PR0802MB2493:|VI1PR0801MB2094:
X-Microsoft-Antispam-PRVS:
	<VI1PR0801MB209419E9C6DA8BC06E6C42FEF7B99@VI1PR0801MB2094.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Oob-TLC-OOBClassifiers: OLM:758;OLM:758;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 hfQkLJSxiWRx3p7LVMfI9H56F6vN1B12Z1VcSqAtXXwciwErU79/kA19r2SLOLD6FzeMt9KBG5wCYHhAfmdWchf99wDTCFd/p+T0sPD9/gDgnbVO17kgYHDPzx1MNkmIFLIMZ+XwNqNgwArrABJvxPwiu+xUsvu1VpsJY/Z+MbHh3Jx7CzF2Ur713ZUn4+ipi5+6z8+c1ekQG451qRVGUfDX3z/poXNa2j54pwWWca1zYtQeDlZxKFFp5ERpeyrqRHwrxg6Adg60XXnFJgwLOzsNa2RwlIz6B3mC8PSRdiQHYmZbDXt8DSOZDZtn1CFKuebcBuL/Q4m3SIRDjySc8UYxnrbI5vaJtgleOjYDtDbslGL0tqgy13nrGen1qsinMd0u3ptJL5FESnwQ6vNrm5ydGVOs/7LCU09ng5V08yxVYBasmx6yivzFNqbjOLvBfCqcQ2mbnw0zau6fT6cTNTXbFVpOiSowxtdYInWjeK2vmTcaUjNT360NliijPke4/P09PXhm+P+juz1cj/UhWZyCHNvUIyDGeT1CaJzCelwYisbX3yZysHuLGjiQmrBAupbJn0TPw2wggW7Z7ZH7TC7OWfJIeUUx3tUtkAvl34hIt2RNYtH0SkdmvoztnA1CiN6WBOZSD9jBhtXd279eRN+waIPvzmA0Cjtoo3f5kINUWe8SW8CZkXxSc8LwvyfYyMDH33zHU1qhWH3sD++JoQlkRmOhMelTUDNiVUUuXbE=
X-Forefront-Antispam-Report-Untrusted:
 CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(1076003)(81166007)(2616005)(82310400003)(110136005)(6666004)(86362001)(2906002)(316002)(54906003)(47076005)(508600001)(44832011)(83380400001)(356005)(186003)(4326008)(7696005)(8936002)(8676002)(336012)(5660300002)(426003)(70206006)(30864003)(70586007)(36756003)(26005)(36860700001)(36900700001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0802MB2493
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM5EUR03FT020.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	4b9fc805-f6ca-4aec-5bd0-08d98f894b25
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	9uXFreIAbpys7NN/1RdbF9sQMW7DCW9rbxnRCbXJdq8K1QAiCs1RD8RmKFN/xQohV4ho1QF0CaOp+KCur8VX8kFqrWJXLyS6bjK/GGsrmeP2TFJOhitSF0Mf7g636+tZKkJQLqKOD0AvZfoiaEBslpl0nyCyyDTryJ+veOW1yaCDTl3RRkd+nqd+K2h+lXr8ib4b8wk3RS0datyyw/JkbsrWElXl9JR81fk87nj2ytlQYvGrkC3CNid9u2xs8a3iJXFJPGsS8uD/PrxVvd2MFQqu6tR013pfVTyKruJ5s0qUli45sj0dnfd+Q9wbl/QEN7b3CyKsvVgQWyjJFy5Q8Rbq/RF/zMA2rhwbNpoW5URqq9laF2jY9697HpQLwL/gS+HiRDW7tvCFSqXj5/z61ono4bFPq6LaANX2PdsFV/IrMk4zJNeDaIggFBdozspQNKPws1bxAshd6MhDLnpLi0ho6zLtxDVgC00k5H3abTv6vY5pV264JcjKp4//qekUuMO0QxhgkbbEo/80d8cHXibMngxI+2GEYlFIpnH3+gA5IRhsIfdvNJtFdnZ+NiZtkAzqJB0M9ymBJOzG8NcoX+RXh8W2DkU+rIGIgNT97VzfEXVNdocpqQQ2YmKECYR1zEy5duMX61mKWlc/XO5zAJoNJCsNLjZ1IveVEU4W9Q+M3rqj3zL73obRrP8aKqbcXo8YGRtACwynO6e+BlucPg==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(186003)(8936002)(2906002)(1076003)(2616005)(336012)(36756003)(81166007)(82310400003)(83380400001)(316002)(30864003)(508600001)(7696005)(4326008)(26005)(36860700001)(70586007)(110136005)(5660300002)(8676002)(44832011)(86362001)(6666004)(426003)(70206006)(54906003)(47076005);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2021 03:10:17.1019
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: b49a3d1b-72ab-41b6-792a-08d98f895064
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM5EUR03FT020.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0801MB2094

From: Stefano Stabellini <stefano.stabellini@xilinx.com>

Cases where domU needs direct-map memory map:
  * IOMMU not present in the system.
  * IOMMU disabled if it doesn't cover a specific device and all the guests
are trusted. Thinking a mixed scenario, where a few devices with IOMMU and
a few without, then guest DMA security still could not be totally guaranteed.
So users may want to disable the IOMMU, to at least gain some performance
improvement from IOMMU disabled.
  * IOMMU disabled as a workaround when it doesn't have enough bandwidth.
To be specific, in a few extreme situation, when multiple devices do DMA
concurrently, these requests may exceed IOMMU's transmission capacity.
  * IOMMU disabled when it adds too much latency on DMA. For example,
TLB may be missing in some IOMMU hardware, which may bring latency in DMA
progress, so users may want to disable it in some realtime scenario.
  * Guest OS relies on the host memory layout-capablei

*WARNING:
Users should be aware that it is not always secure to assign a DMA-capable
device without IOMMU protection.
The administrator should make sure that:
 1. The device is assigned to a trusted guest.
 2. Users have additional security mechanism on the platform.

This commit also avoids setting XEN_DOMCTL_CDF_iommu when the IOMMU is
absent/disabled.

For now, direct-map is only supported when domain on Static Allocation, that is,
"xen.static-mem" must be also defined in the domain configuration.

This commit also introduces a new helper allocate_static_memory_11 to allocate
static memory as guest RAM for direct-map domain.

Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>
Signed-off-by: Penny Zheng <penny.zheng@arm.com>
---
 docs/misc/arm/device-tree/booting.txt |  10 ++
 xen/arch/arm/domain_build.c           | 215 ++++++++++++++++++++------
 2 files changed, 179 insertions(+), 46 deletions(-)

diff --git a/docs/misc/arm/device-tree/booting.txt b/docs/misc/arm/device-tree/booting.txt
index 71895663a4..297f8fa0c8 100644
--- a/docs/misc/arm/device-tree/booting.txt
+++ b/docs/misc/arm/device-tree/booting.txt
@@ -182,6 +182,16 @@ with the following properties:
     Both #address-cells and #size-cells need to be specified because
     both sub-nodes (described shortly) have reg properties.
 
+- direct-map
+
+    Optional for Domain on Static Allocation.
+    An empty property to request the memory of the domain to be
+    direct-map (guest physical address == physical address).
+    WARNING:
+    Users must be aware of this risk, when doing DMA-capable device assignment,
+    direct-map guest must be trusted or have additional security mechanism,
+    otherwise it could use the DMA engine to access any other memory area.
+
 Under the "xen,domain" compatible node, one or more sub-nodes are present
 for the DomU kernel and ramdisk.
 
diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
index 37e2d62d47..d9118e5bc1 100644
--- a/xen/arch/arm/domain_build.c
+++ b/xen/arch/arm/domain_build.c
@@ -492,8 +492,14 @@ static bool __init append_static_memory_to_bank(struct domain *d,
 {
     int res;
     unsigned int nr_pages = PFN_DOWN(size);
-    /* Infer next GFN. */
-    gfn_t sgfn = gaddr_to_gfn(bank->start + bank->size);
+    gfn_t sgfn;
+
+    if ( !is_domain_direct_mapped(d) )
+        /* Infer next GFN when GFN != MFN. */
+        sgfn = gaddr_to_gfn(bank->start + bank->size);
+    else
+        sgfn = gaddr_to_gfn(mfn_to_maddr(smfn));
+
 
     res = guest_physmap_add_pages(d, sgfn, smfn, nr_pages);
     if ( res )
@@ -507,12 +513,69 @@ static bool __init append_static_memory_to_bank(struct domain *d,
     return true;
 }
 
-/* Allocate memory from static memory as RAM for one specific domain d. */
+static int __init acquire_static_memory_bank(struct domain *d,
+                                             const __be32 **cell,
+                                             u32 addr_cells, u32 size_cells,
+                                             paddr_t *pbase, paddr_t *psize)
+{
+    int res = 0;
+
+    device_tree_get_reg(cell, addr_cells, size_cells, pbase, psize);
+    ASSERT(IS_ALIGNED(*pbase, PAGE_SIZE) && IS_ALIGNED(*psize, PAGE_SIZE));
+    if ( PFN_DOWN(*psize) > UINT_MAX )
+    {
+        printk(XENLOG_ERR "%pd: static memory size too large: %#"PRIpaddr,
+               d, *psize);
+        return -EINVAL;
+    }
+
+    res = acquire_domstatic_pages(d, maddr_to_mfn(*pbase), PFN_DOWN(*psize), 0);
+    if ( res )
+        printk(XENLOG_ERR
+               "%pd: failed to acquire static memory: %d.\n", d, res);
+
+    return res;
+}
+
+static int __init parse_static_mem_prop(const struct dt_device_node *node,
+                                        u32 *addr_cells, u32 *size_cells,
+                                        int *length, const __be32 **cell)
+{
+    const struct dt_property *prop;
+
+    prop = dt_find_property(node, "xen,static-mem", NULL);
+    if ( !dt_property_read_u32(node, "#xen,static-mem-address-cells",
+                               addr_cells) )
+    {
+        printk(XENLOG_ERR
+               "failed to read \"#xen,static-mem-address-cells\".\n");
+        return -EINVAL;
+    }
+
+    if ( !dt_property_read_u32(node, "#xen,static-mem-size-cells",
+                               size_cells) )
+    {
+        printk(XENLOG_ERR
+               "failed to read \"#xen,static-mem-size-cells\".\n");
+        return -EINVAL;
+    }
+
+    *cell = (const __be32 *)prop->value;
+    *length = prop->length;
+
+    return 0;
+}
+
+/*
+ * Allocate static memory as RAM for one specific domain d.
+ * The static memory will be mapped in the guest at the usual guest
+ * memory addresses (GUEST_RAM0_BASE, GUEST_RAM1_BASE) defined by
+ * xen/include/public/arch-arm.h.
+ */
 static void __init allocate_static_memory(struct domain *d,
                                           struct kernel_info *kinfo,
                                           const struct dt_device_node *node)
 {
-    const struct dt_property *prop;
     u32 addr_cells, size_cells, reg_cells;
     unsigned int nr_banks, gbank, bank = 0;
     const uint64_t rambase[] = GUEST_RAM_BANK_BASES;
@@ -521,61 +584,31 @@ static void __init allocate_static_memory(struct domain *d,
     u64 tot_size = 0;
     paddr_t pbase, psize, gsize;
     mfn_t smfn;
-    int res;
+    int length;
 
-    prop = dt_find_property(node, "xen,static-mem", NULL);
-    if ( !dt_property_read_u32(node, "#xen,static-mem-address-cells",
-                               &addr_cells) )
-    {
-        printk(XENLOG_ERR
-               "%pd: failed to read \"#xen,static-mem-address-cells\".\n", d);
-        goto fail;
-    }
+    gbank = 0;
+    gsize = ramsize[gbank];
+    kinfo->mem.bank[gbank].start = rambase[gbank];
 
-    if ( !dt_property_read_u32(node, "#xen,static-mem-size-cells",
-                               &size_cells) )
+    if ( parse_static_mem_prop(node, &addr_cells, &size_cells, &length, &cell) )
     {
         printk(XENLOG_ERR
-               "%pd: failed to read \"#xen,static-mem-size-cells\".\n", d);
+               "%pd: failed to parse \"xen,static-mem\" property.\n", d);
         goto fail;
     }
     reg_cells = addr_cells + size_cells;
-
-    /*
-     * The static memory will be mapped in the guest at the usual guest memory
-     * addresses (GUEST_RAM0_BASE, GUEST_RAM1_BASE) defined by
-     * xen/include/public/arch-arm.h.
-     */
-    gbank = 0;
-    gsize = ramsize[gbank];
-    kinfo->mem.bank[gbank].start = rambase[gbank];
-
-    cell = (const __be32 *)prop->value;
-    nr_banks = (prop->length) / (reg_cells * sizeof (u32));
+    nr_banks = length / (reg_cells * sizeof (u32));
 
     for ( ; bank < nr_banks; bank++ )
     {
-        device_tree_get_reg(&cell, addr_cells, size_cells, &pbase, &psize);
-        ASSERT(IS_ALIGNED(pbase, PAGE_SIZE) && IS_ALIGNED(psize, PAGE_SIZE));
-
-        if ( PFN_DOWN(psize) > UINT_MAX )
-        {
-            printk(XENLOG_ERR "%pd: static memory size too large: %#"PRIpaddr,
-                   d, psize);
+        if ( acquire_static_memory_bank(d, &cell, addr_cells, size_cells,
+                                        &pbase, &psize) )
             goto fail;
-        }
-        smfn = maddr_to_mfn(pbase);
-        res = acquire_domstatic_pages(d, smfn, PFN_DOWN(psize), 0);
-        if ( res )
-        {
-            printk(XENLOG_ERR
-                   "%pd: failed to acquire static memory: %d.\n", d, res);
-            goto fail;
-        }
 
         printk(XENLOG_INFO "%pd: STATIC BANK[%u] %#"PRIpaddr"-%#"PRIpaddr"\n",
                d, bank, pbase, pbase + psize);
 
+        smfn = maddr_to_mfn(pbase);
         while ( 1 )
         {
             /* Map as much as possible the static range to the guest bank */
@@ -638,12 +671,91 @@ static void __init allocate_static_memory(struct domain *d,
  fail:
     panic("Failed to allocate requested static memory for domain %pd.", d);
 }
+
+/*
+ * Allocate static memory as RAM for one specific domain d.
+ * The static memory will be directly mapped in the guest(Guest Physical
+ * Address == Physical Address).
+ */
+static void __init allocate_static_memory_11(struct domain *d,
+                                             struct kernel_info *kinfo,
+                                             const struct dt_device_node *node)
+{
+    u32 addr_cells, size_cells, reg_cells;
+    unsigned int nr_banks, gbank = 0, bank = 0;
+    const __be32 *cell;
+    u64 tot_size = 0;
+    paddr_t pbase, psize;
+    mfn_t smfn;
+    int length;
+
+    if ( parse_static_mem_prop(node, &addr_cells, &size_cells, &length, &cell) )
+    {
+        printk(XENLOG_ERR
+               "%pd: failed to parse \"xen,static-mem\" property.\n", d);
+        goto fail;
+    }
+    reg_cells = addr_cells + size_cells;
+    nr_banks = length / (reg_cells * sizeof (u32));
+
+    for ( ; bank < nr_banks; bank++ )
+    {
+        if ( acquire_static_memory_bank(d, &cell, addr_cells, size_cells,
+                                        &pbase, &psize) )
+            goto fail;
+
+        printk(XENLOG_INFO "%pd: STATIC BANK[%u] %#"PRIpaddr"-%#"PRIpaddr"\n",
+               d, bank, pbase, pbase + psize);
+
+        /*
+         * One guest memory bank is matched with one physical
+         * memory bank.
+         */
+        smfn = maddr_to_mfn(pbase);
+        gbank = bank;
+        kinfo->mem.bank[gbank].start = pbase;
+
+        if ( !append_static_memory_to_bank(d, &kinfo->mem.bank[gbank],
+                                           smfn, psize) )
+            goto fail;
+
+        tot_size += psize;
+    }
+
+    kinfo->mem.nr_banks = ++gbank;
+
+    kinfo->unassigned_mem -= tot_size;
+    /*
+     * The property 'memory' should match the amount of memory given to the
+     * guest.
+     * Currently, it is only possible to either acquire static memory or let
+     * Xen allocate. *Mixing* is not supported.
+     */
+    if ( kinfo->unassigned_mem )
+    {
+        printk(XENLOG_ERR
+               "Size of \"memory\" property doesn't match up with the sum-up of \"xen,static-mem\". Unsupported configuration.\n");
+        goto fail;
+    }
+
+    return;
+
+ fail:
+    panic("Failed to allocate requested static memory for direct-map domain %pd.",
+          d);
+}
 #else
 static void __init allocate_static_memory(struct domain *d,
                                           struct kernel_info *kinfo,
                                           const struct dt_device_node *node)
 {
 }
+
+static void __init allocate_static_memory_11(struct domain *d,
+                                             struct kernel_info *kinfo,
+                                             const struct dt_device_node *node)
+{
+}
 #endif
 
 static int __init write_properties(struct domain *d, struct kernel_info *kinfo,
@@ -2936,7 +3048,12 @@ static int __init construct_domU(struct domain *d,
     if ( !dt_find_property(node, "xen,static-mem", NULL) )
         allocate_memory(d, &kinfo);
     else
-        allocate_static_memory(d, &kinfo, node);
+    {
+        if ( is_domain_direct_mapped(d) )
+            allocate_static_memory_11(d, &kinfo, node);
+        else
+            allocate_static_memory(d, &kinfo, node);
+    }
 
     rc = prepare_dtb_domU(d, &kinfo);
     if ( rc < 0 )
@@ -2976,8 +3093,14 @@ void __init create_domUs(void)
             panic("Missing property 'cpus' for domain %s\n",
                   dt_node_name(node));
 
+        if ( dt_property_read_bool(node, "direct-map") )
+            d_cfg.flags |= XEN_DOMCTL_CDF_directmap;
+
         if ( dt_find_compatible_node(node, NULL, "multiboot,device-tree") )
-            d_cfg.flags |= XEN_DOMCTL_CDF_iommu;
+        {
+            if ( iommu_enabled )
+                d_cfg.flags |= XEN_DOMCTL_CDF_iommu;
+        }
 
         if ( !dt_property_read_u32(node, "nr_spis", &d_cfg.arch.nr_spis) )
         {
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Fri Oct 15 03:10:31 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 03:10:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.209666.366193 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbDbv-00031z-SF; Fri, 15 Oct 2021 03:10:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 209666.366193; Fri, 15 Oct 2021 03:10:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbDbv-00031s-OH; Fri, 15 Oct 2021 03:10:19 +0000
Received: by outflank-mailman (input) for mailman id 209666;
 Fri, 15 Oct 2021 03:10:17 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=lHOs=PD=arm.com=Penny.Zheng@srs-us1.protection.inumbo.net>)
 id 1mbDbt-00031m-N9
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 03:10:17 +0000
Received: from EUR02-AM5-obe.outbound.protection.outlook.com (unknown
 [2a01:111:f400:fe07::60f])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 4df48ce2-e5af-461f-9ad0-efc45ad7a94c;
 Fri, 15 Oct 2021 03:10:14 +0000 (UTC)
Received: from AS8P250CA0019.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:330::24)
 by DB7PR08MB4588.eurprd08.prod.outlook.com (2603:10a6:10:75::27) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.17; Fri, 15 Oct
 2021 03:10:12 +0000
Received: from VE1EUR03FT054.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:330:cafe::b7) by AS8P250CA0019.outlook.office365.com
 (2603:10a6:20b:330::24) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16 via Frontend
 Transport; Fri, 15 Oct 2021 03:10:11 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT054.mail.protection.outlook.com (10.152.19.64) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.15 via Frontend Transport; Fri, 15 Oct 2021 03:10:11 +0000
Received: ("Tessian outbound f1898412aff1:v103");
 Fri, 15 Oct 2021 03:10:11 +0000
Received: from 15e1fc9dc923.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 A70C9E0B-4206-43F7-8817-F5545D433722.1; 
 Fri, 15 Oct 2021 03:10:04 +0000
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 15e1fc9dc923.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 15 Oct 2021 03:10:04 +0000
Received: from AM6P193CA0130.EURP193.PROD.OUTLOOK.COM (2603:10a6:209:85::35)
 by DB9PR08MB6857.eurprd08.prod.outlook.com (2603:10a6:10:2a2::7) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15; Fri, 15 Oct
 2021 03:10:03 +0000
Received: from VE1EUR03FT009.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:209:85:cafe::2d) by AM6P193CA0130.outlook.office365.com
 (2603:10a6:209:85::35) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16 via Frontend
 Transport; Fri, 15 Oct 2021 03:10:03 +0000
Received: from nebula.arm.com (40.67.248.234) by
 VE1EUR03FT009.mail.protection.outlook.com (10.152.18.92) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.4608.15 via Frontend Transport; Fri, 15 Oct 2021 03:10:02 +0000
Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX04.Arm.com
 (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.14; Fri, 15 Oct
 2021 03:10:10 +0000
Received: from penny.shanghai.arm.com (10.169.190.66) by mail.arm.com
 (10.251.24.32) with Microsoft SMTP Server id 15.1.2308.14 via Frontend
 Transport; Fri, 15 Oct 2021 03:10:08 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4df48ce2-e5af-461f-9ad0-efc45ad7a94c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=BBYPsV10Pj0YiSpLBJG2gkfU1JF6UmqHwHsJEG2dSnE=;
 b=9/IQHDAQ2/65X8zkD5HRpqevcFyN+aEBCJh59ZL1O0bRbgfYNm7wVBHhvUtkgNfpCO4am6cwqyesUWeVT9546QN+kK/MFSISs2dOvxU+dZyF2LaDyW0TGY+DnG9a34oK3TUh6EQZVW5fpGuWTRTtL2TzInsxRCE06z3/rGB8rBU=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 56f31b58c5c0ad3c
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ExZIgGj0J7GndyddY97s09t8TxJoeQAUFPE6uwlJ9viwS5DnPPTLlKi+XTT+qe0k86ye+Ym9NnTe3DUhVeGtvb+9rIKAcOOnF+nEMU+fSxUz5k8mDtPr24+e8W6etg5qQBDugkGHplaBrGMzGk+3SeCcg4Bk30n5TQMABtCsdGo/ejhR/y1PWaBhUXQZLxNs7fOrXnu4BplXlfPLiwVLPzy9TFOEvs92aSzPfz8LgXi8jbYzmdKrJ7X5mhcAWe9IGhu4HsakVOvAkpKEMZ42h3A5gUl5BW+s+o4ItzQ3/pfrztF9O9PLjX1n8xlZyHCJMZMGeIn0WJcD2Cwto8ChCw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=BBYPsV10Pj0YiSpLBJG2gkfU1JF6UmqHwHsJEG2dSnE=;
 b=I9QZRU0X2kso3zaJABqhlyH006eYgSc/AxB4KCu8Tqm4hPtH44TIhGrcesitArU11xCt19DlQ0+4hwXL95hxJs/zAkmgu4wF8JoUOJipdQanKvRV6v5iCbSLo/frLg9j37Q5r+P1HdbyHmERSWJahKeKG3jdglmVX9rBqwKkHysJ2MFf66ShcMhzD8GWAI5oTaK3SG7RpokrW8KNuaPK8OeidUwXAjb+Hz6efQPV0mOtGMVNdTBtUKrZwodsxDzN+DcfUmmAkFlwGMOSGnX1RgEtDCQRnBfeM7CcPFJS29yd0AMXLVftrkU+u7lKMGRJn6+iMiQMlIc7l7Wx3cTJJw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=BBYPsV10Pj0YiSpLBJG2gkfU1JF6UmqHwHsJEG2dSnE=;
 b=9/IQHDAQ2/65X8zkD5HRpqevcFyN+aEBCJh59ZL1O0bRbgfYNm7wVBHhvUtkgNfpCO4am6cwqyesUWeVT9546QN+kK/MFSISs2dOvxU+dZyF2LaDyW0TGY+DnG9a34oK3TUh6EQZVW5fpGuWTRTtL2TzInsxRCE06z3/rGB8rBU=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=pass action=none
 header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 40.67.248.234 as permitted sender) receiver=protection.outlook.com;
 client-ip=40.67.248.234; helo=nebula.arm.com;
From: Penny Zheng <penny.zheng@arm.com>
To: <xen-devel@lists.xenproject.org>, <sstabellini@kernel.org>,
	<julien@xen.org>
CC: <Wei.Chen@arm.com>, <Bertrand.Marquis@arm.com>
Subject: [PATCH v2 0/6] direct-map memory map
Date: Fri, 15 Oct 2021 03:09:39 +0000
Message-ID: <20211015030945.2082898-1-penny.zheng@arm.com>
X-Mailer: git-send-email 2.25.1
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
X-EOPAttributedMessage: 1
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: eb88ae11-c27c-47f2-f486-08d98f894d04
X-MS-TrafficTypeDiagnostic: DB9PR08MB6857:|DB7PR08MB4588:
X-Microsoft-Antispam-PRVS:
	<DB7PR08MB4588DE507E33FAB09A764F45F7B99@DB7PR08MB4588.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 S4e32w94XA3ORPvlg+s0QisE69/1Lcg2VxNP/iCgTilXMl3Tkb74lsANOm1bXVaC8GWXJd8dbf9DKECAIY5w6KlJet5J6VjQYS127vW0c3a1dTala/GBZbGbI+f8FGk0BJWO6WXvwUTdhiUEcKWOfZAtIPKLgEbEiazEmFUadL9/vN5pi8reWBn/5+3VRzKkvB8BN1pJNEcTSLDE1AFMzbJWwi0DK1cTJUZZyP+xS4nO6jzjMVdySyj2d742fSM6RM0NI3tRGQN7Ts9uxSuw5BZToAnoqE1+KdP1ZZG39wUzsGWBka6vA2FxbJzmfXEzG0IQ86KjB+yGCETBc2djy2KsUBCNRC5Yi/MVK+EYaCLyM9wU/yVv9Pnq9or6N/w1bYqeyOIrAzqWqy6IeavHK9gfFzrymJ/Ir5OdMXvafbKyicL6m7yLjnYKbHFTO3hvTI9X2Pfw9zqfFC8XXhL9aUnkkUib7SPAcAR4Cz5pERk5k48IC5wdgUjcb/WVq7vN3wzS76lZUK9fV6t+Df7eoWejzqYcNaZ1wL1NCusKIDUrEf3Kie/M7mMhlckTBW9ya3g7C3T9uB/sKUM3knDmAt2YSCcyICEawwWOwTWCNEu2LgcB1j5qKxCksDVWmn+V4VAhbWJ/EdcK9dF0KigLm9oJgor76k6hn+MSCyWsQ0VdG4v6aj3tM3Mdt2fO9JeGGM2kuik2dXIgyQPm3O4mikPMnpkWC1SFotxwpInXRf7MPsc8HrutHi5f7r2Cq3OhopAUxeztMiG783OLc7EBb0mnsRF/15VB1LXozoJtvsKJBrWpvjfUz8h34K+JnEIVbcPm2XE/sT0+3GN/oL0U3YUhdFdDjr0BA5wgYThHq6E=
X-Forefront-Antispam-Report-Untrusted:
 CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(70206006)(36860700001)(54906003)(1076003)(6666004)(4326008)(86362001)(47076005)(70586007)(36756003)(110136005)(2616005)(336012)(8676002)(316002)(508600001)(186003)(7696005)(44832011)(8936002)(5660300002)(83380400001)(82310400003)(426003)(26005)(356005)(81166007)(2906002)(966005)(36900700001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB6857
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT054.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	d96c6363-9f45-4c43-24bb-08d98f8947c4
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	uE+WUx6uHPeY/tEu3usnKN2yB/NrozNDAO81PzhxifpenFZZm02WhwXdsl+Z3UwSOkYgKKAsPcGncD0Gf7VahFfz+2CMvg4fpv8MKnB7JW8YMsEzmOzIzwF+oEMonI89TRGXy2+oGaZya/KNZAiBBswoq8uN3XF9h/MSGc/t0B+doyp3huvc8ZGZ0vP6uaJt9lHNKsUjDOjV4nl7iu+xBBQUccxwylVdOfrviDPogs0bO5C7uvUDr857EzS4z+udJMMruKt18JxnYbz5DUMWS7Am/zIDUuDCF9DF81AiUZ4EmHm2ct4wsAVXewUub3R7Ls+bFVpT6oaDFqvZBFQsRqD7GY+Y1zn6oW7fbyIgQcv+lcEUy8ufc4fVSQJpZi3b58cdsin1m5JRiXVd9djkHKlcFGDBr3+0y8mA2rtqfFAlYgWiPPx5v3S19m8NPG0Un3AYtZOZS/V0tRLpIlkZxCGjobvm8AkxWc9TZeSnhKc1vzwEcGTg8fmGsFRQ23nOtbsaYkc2byUB823PzSB8RYlmn/q5j9PAqroYV6sqiqR5rtMpCJ47FHuvEm9xnfg5FjzkTvgx+TanqrEPMwaPXRMxmF0NRHmhAa7KNN9M0Fi5r8geh5AdzTL7kEzkTofBAPuOUooy2vWprlwwVx6CyDyOWkMV74vVLJuNplTNJu2pPlIdVZ95WyOgjjpGmWji+MUr8MsS9fxPuJoesf1ENKVpsFQDWydfoe75IldAAr2Pz1/nOLPYQrjiJ+igGhtGi6R9ZUnDsNqNoejR8tTOeGWJMS46lhJmw9GfF2S7jKdXnwk0ovmaaIA7+PiJqlOPgehxauaKUXrc01A1O6CEMw==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(47076005)(82310400003)(8936002)(6666004)(1076003)(508600001)(4326008)(7696005)(2906002)(36756003)(70586007)(2616005)(70206006)(186003)(83380400001)(5660300002)(966005)(316002)(54906003)(44832011)(110136005)(8676002)(26005)(86362001)(336012)(81166007)(426003)(36860700001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2021 03:10:11.4008
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: eb88ae11-c27c-47f2-f486-08d98f894d04
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT054.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB4588

Cases where domU needs direct-map memory map:
  * IOMMU not present in the system.
  * IOMMU disabled if it doesn't cover a specific device and all the guests
are trusted. Thinking a mixed scenario, where a few devices with IOMMU and
a few without, then guest DMA security still could not be totally guaranteed.
So users may want to disable the IOMMU, to at least gain some performance
improvement from IOMMU disabled.
  * IOMMU disabled as a workaround when it doesn't have enough bandwidth.
To be specific, in a few extreme situation, when multiple devices do DMA
concurrently, these requests may exceed IOMMU's transmission capacity.
  * IOMMU disabled when it adds too much latency on DMA. For example,
TLB may be missing in some IOMMU hardware, which may bring latency in DMA
progress, so users may want to disable it in some realtime scenario.

*WARNING:
Users should be aware that it is not always secure to assign a DMA-capable
device without IOMMU protection.
When the device is not protected by the IOMMU, the administrator should make
sure that:
 1. The device is assigned to a trusted guest.
 2. Users have additional security mechanism on the platform.

Requesting direct-map memory mapping for the domain, when IOMMU is absent from
the system or it is disabled (status = "disabled" in device tree), In which
case, "direct-map" property is added under the appropriate domain node.

Right now, direct-map is only supported when domain on Static Allocation,
that is, "xen,static-mem" is also necessary in the domain configuration.

Looking into related [design link](
https://lists.xenproject.org/archives/html/xen-devel/2021-05/msg00882.html)
for more details.

The whole design is about Static Allocation and direct-map, and this
Patch Serie only covers parts of it, which are direct-map memory map.
Other features will be delievered through different patch series.

See https://lists.xenproject.org/archives/html/xen-devel/2021-09/msg00855.html
for Domain on Static Allocation.

This patch serie is based on
https://lists.xenproject.org/archives/html/xen-devel/2021-10/msg00822.html

---
v2 changes:
- remove the introduce of internal flag
- Refine is_domain_direct_mapped to check whether the flag
XEN_DOMCTL_CDF_directmap is set
- reword "1:1 direct-map" to just "direct-map"
- split the common codes into two helpers: parse_static_mem_prop and
acquire_static_memory_bank to deduce complexity.
- introduce a new helper allocate_static_memory_11 for allocating static
memory for direct-map guests
- remove panic action since it is fine to assign a non-DMA capable device when
IOMMU and direct-map both off
- remove redistributor accessor
- introduce new helper "is_domain_use_host_layout()"
- explain why vpl011 initialization before creating its device tree node
- error out if the domain is direct-mapped and the IRQ is not found
- harden the code and add a check/comment when the hardware UART region
is smaller than CUEST_VPL011_SIZE.

Stefano Stabellini (6):
  xen: introduce XEN_DOMCTL_CDF_directmap
  xen/arm: introduce direct-map for domUs
  xen/arm: if direct-map domain use native addresses for GICv2
  xen/arm: if direct-map domain use native addresses for GICv3
  xen/arm: if direct-map domain use native UART address and IRQ number
    for vPL011
  xen/docs: add a document to explain how to do passthrough without
    IOMMU

 docs/misc/arm/device-tree/booting.txt |  10 +
 docs/misc/arm/passthrough-noiommu.txt |  54 +++++
 xen/arch/arm/domain.c                 |   3 +-
 xen/arch/arm/domain_build.c           | 316 ++++++++++++++++++++------
 xen/arch/arm/vgic-v2.c                |  26 ++-
 xen/arch/arm/vgic-v3.c                |  20 +-
 xen/arch/arm/vgic/vgic-v2.c           |  27 ++-
 xen/arch/arm/vpl011.c                 |  54 ++++-
 xen/common/domain.c                   |   3 +-
 xen/include/asm-arm/domain.h          |   7 +-
 xen/include/asm-arm/new_vgic.h        |  10 +
 xen/include/asm-arm/vgic.h            |  12 +-
 xen/include/asm-arm/vpl011.h          |   2 +
 xen/include/public/domctl.h           |   4 +-
 14 files changed, 449 insertions(+), 99 deletions(-)
 create mode 100644 docs/misc/arm/passthrough-noiommu.txt

-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Fri Oct 15 03:10:34 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 03:10:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.209669.366226 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbDc9-0003yh-UR; Fri, 15 Oct 2021 03:10:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 209669.366226; Fri, 15 Oct 2021 03:10:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbDc9-0003yY-Q9; Fri, 15 Oct 2021 03:10:33 +0000
Received: by outflank-mailman (input) for mailman id 209669;
 Fri, 15 Oct 2021 03:10:32 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=lHOs=PD=arm.com=Penny.Zheng@srs-us1.protection.inumbo.net>)
 id 1mbDc8-00031m-Ho
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 03:10:32 +0000
Received: from EUR01-HE1-obe.outbound.protection.outlook.com (unknown
 [40.107.13.50]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 395ce30f-5fe7-405e-845d-6938379d9c0d;
 Fri, 15 Oct 2021 03:10:26 +0000 (UTC)
Received: from DB6PR07CA0160.eurprd07.prod.outlook.com (2603:10a6:6:43::14) by
 AM9PR08MB7181.eurprd08.prod.outlook.com (2603:10a6:20b:3dc::19) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.17; Fri, 15 Oct
 2021 03:10:24 +0000
Received: from DB5EUR03FT014.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:6:43:cafe::f1) by DB6PR07CA0160.outlook.office365.com
 (2603:10a6:6:43::14) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.10 via Frontend
 Transport; Fri, 15 Oct 2021 03:10:24 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT014.mail.protection.outlook.com (10.152.20.102) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.15 via Frontend Transport; Fri, 15 Oct 2021 03:10:24 +0000
Received: ("Tessian outbound d5def7722ff7:v103");
 Fri, 15 Oct 2021 03:10:24 +0000
Received: from ffe3fb46b1ec.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 B4BACB67-B6D9-4344-A018-674E412F48F7.1; 
 Fri, 15 Oct 2021 03:10:18 +0000
Received: from EUR02-VE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id ffe3fb46b1ec.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 15 Oct 2021 03:10:18 +0000
Received: from AS9PR06CA0401.eurprd06.prod.outlook.com (2603:10a6:20b:461::11)
 by PA4PR08MB6046.eurprd08.prod.outlook.com (2603:10a6:102:e4::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16; Fri, 15 Oct
 2021 03:10:17 +0000
Received: from VE1EUR03FT042.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:461:cafe::14) by AS9PR06CA0401.outlook.office365.com
 (2603:10a6:20b:461::11) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.14 via Frontend
 Transport; Fri, 15 Oct 2021 03:10:17 +0000
Received: from nebula.arm.com (40.67.248.234) by
 VE1EUR03FT042.mail.protection.outlook.com (10.152.19.62) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.4608.15 via Frontend Transport; Fri, 15 Oct 2021 03:10:16 +0000
Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX04.Arm.com
 (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.14; Fri, 15 Oct
 2021 03:10:16 +0000
Received: from penny.shanghai.arm.com (10.169.190.66) by mail.arm.com
 (10.251.24.32) with Microsoft SMTP Server id 15.1.2308.14 via Frontend
 Transport; Fri, 15 Oct 2021 03:10:15 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 395ce30f-5fe7-405e-845d-6938379d9c0d
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=iEsr4bkhs7W4ATHTkk+2qiqGbJjeKmz0+jICjq2cJtM=;
 b=se+Fsm/rlr2iGnZ0jz/7J23DSxaDhbSNqsngOBiKrM7NU6Vr2CXmarGtlBXVCmAoNlegQ0Jnoz2J75RsPrAK1BUu/yXP1hx7Qj8/nvsiGCQHWceHnWsVbA8cLjTifYWhBYqETOpBUCsNtK4/iZ9DSQ5AUTe0WNjP3Uq5UTkWJUg=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 53ddc38c1662d605
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=FGrSBwJjWc/1WNHIzhck/57wvhvWUhiLTI56rJtX3Qg38Zj8ag8KoSce+oqfC6ALs1WMNilpRbJp/MIute7YGhO0lGWK3/KwAwa+8nO2woHnpRKFWg61HaMuLM6J1/IVNAoNM9kHnBaCXPZ5ihQFwfqPn8x6wLf3oRPeWqPAWjw6JcjgjNbpoWrNgP7BjZxvqFY4UtcrwDs8LZpVTT6yafgR/BqypKj/FRWYjQf2js/91wGTVuc6pMcq6/QV2FPaRvtNWwBlULKPKWPylIQMmvSKak8oY9EUGzbGPrWvQKyqyLnjmMK5m5X6W/xCNoenoLTTwbDdR0UApsKCgpPxhw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=iEsr4bkhs7W4ATHTkk+2qiqGbJjeKmz0+jICjq2cJtM=;
 b=NZ0dK1Phnlat+hBiXIYvG5VUprixcKAb9ge6TTyWa2Mj3NsL9QtmRhUpLwIwAXHH3cmgeTF8pJq43GMVdjNK04dNCjpavzlaaQipe5+zJnNN8u85rFzWkdAibIrd8GZJEUFpiO+epEGdc5pxiiwMRLiDAGAdZYwRJZlgPR5IhX3WysLJNv94SEioQxzSwpLgeN/YQhdtIxzjeM3CdXZiqEi6g/DKrCHeUzgi/rsb4T5Va6n4fEFyDZrDF1CmkhV4QCtpXDOCyObCHPh60w0RoMJVvZoBjn4lPrFyGOoX5OUf/QQ28apBIxk9HGLRzTcNSfsr5A0pWyupikA66jV/pQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=iEsr4bkhs7W4ATHTkk+2qiqGbJjeKmz0+jICjq2cJtM=;
 b=se+Fsm/rlr2iGnZ0jz/7J23DSxaDhbSNqsngOBiKrM7NU6Vr2CXmarGtlBXVCmAoNlegQ0Jnoz2J75RsPrAK1BUu/yXP1hx7Qj8/nvsiGCQHWceHnWsVbA8cLjTifYWhBYqETOpBUCsNtK4/iZ9DSQ5AUTe0WNjP3Uq5UTkWJUg=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=pass action=none
 header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 40.67.248.234 as permitted sender) receiver=protection.outlook.com;
 client-ip=40.67.248.234; helo=nebula.arm.com;
From: Penny Zheng <penny.zheng@arm.com>
To: <xen-devel@lists.xenproject.org>, <sstabellini@kernel.org>,
	<julien@xen.org>
CC: <Wei.Chen@arm.com>, <Bertrand.Marquis@arm.com>
Subject: [PATCH v2 3/6] xen/arm: if direct-map domain use native addresses for GICv2
Date: Fri, 15 Oct 2021 03:09:42 +0000
Message-ID: <20211015030945.2082898-4-penny.zheng@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20211015030945.2082898-1-penny.zheng@arm.com>
References: <20211015030945.2082898-1-penny.zheng@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-EOPAttributedMessage: 1
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 7d8afc69-c804-4b0e-b64d-08d98f8954e7
X-MS-TrafficTypeDiagnostic: PA4PR08MB6046:|AM9PR08MB7181:
X-Microsoft-Antispam-PRVS:
	<AM9PR08MB7181FB4FD7152E9F975EDC6CF7B99@AM9PR08MB7181.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Oob-TLC-OOBClassifiers: OLM:4125;OLM:4125;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 PNJ/67xkCIWFpb4KOY1KM16O5bPBFu0aG51Vw9J9hEPbVXYWxO+xyez4pIfsZVtXPrhlWMO6ntHcwLJRw9jNKqdYN+SrCoaAtLI97M00AgtLYhYTw/zu9E6CGduEpT3e/pZKu5Y5+oMDyYMKpEU/ldA2nILSQkcyXJfHjSRCjhEkOFQnrb4xThUOje+MGnT8dRxeCn88jPgV2dFtTVBjLEb1im+YidqiLPvC8CoYOkgNFzXZz4zlP6JJdgndJ2KDbc1LZtoumHet1SEfQG3oTiIUMpd1s+cJqt7ryK0pmRiJdXYctCzGjqzl5pvouaVYVENESnvjidoSS0lC+Cx9d4vmSymSwdBb/dGY4cZ6nWUBPdamRcRtUjGcSERGU2oYRBkYe4IlTxsG+y/t2TuWVNwcXCLns2QWEpRgwLosT+zYd5HBMAAz/0I/95IMmsFG4RJ4WxHoFikaQsHgNV05yPn5fHZPKubQ2SF2YacR+1hPB87cgbxI/jzAGvKtyxh9iR154CNm+ce6y/ocAdlfSotO5KA13txxcfKYD2HyFcIPvwWdRIch6SgnjFAd6YoFqhvk2Ir03l4CqQMAwO2Ung0eyZeZPjc1L3U4PcRBZlaZZjOLbw53F48NT8NwnrGPCnXRtva1inpZTHSbAd7rRKUQRdnn1gAXw4yoCD1OckAkvQRKMtKzzIioJrXzkOico1WIUzNp6dU6EHwnwQbthjSM46w4GAPwoCUNCcwiUWo=
X-Forefront-Antispam-Report-Untrusted:
 CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(86362001)(8936002)(186003)(36860700001)(54906003)(6666004)(508600001)(36756003)(26005)(44832011)(1076003)(336012)(2616005)(426003)(70586007)(70206006)(83380400001)(5660300002)(2906002)(82310400003)(47076005)(316002)(110136005)(4326008)(7696005)(81166007)(356005)(8676002)(36900700001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB6046
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT014.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	971efdad-6d15-4ec7-7a81-08d98f895024
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	AGlGs6QQ2pNmQ5tHqYMx33ZnW9g9ZNgRbZFwtYVq8sXVn9UIwEWBUVhXqyeSTrO0I2u6GrBXF3zZL917LqKHd7pWHrEaTSQXr6+yKLa8fw1BLsid9eSWH8HiUc08LwFllw1UZ/AbYYVfuS6SatFLz88KPO1fsXcoV9v3ET0eujOtr1SmpieltgSxpLaSHCtMt3mjXRgiO3nGhpahfYi8n72XqBdEi9FeFzZQh6ZKShm6PLI75qKVHq3pIHRcrkD1cskK9V8xDIrom4ltx90epwA5CZmng6HydokdiqGCLolR4xOTXxxZkOLaknfyKErMPpkEi228sPqRFSL03IN/64QoMpJ1w84wmtYNkL6CrdhWmeggGpfG6G9FcG324ASgjW8u/HpWcKD4dUo7FfY/bfTmfY0xBK0mus6XUKtI0YQYLT89uD9eZUg8mOk+3tffihB94g+FUNROUHYanzIIOIodFxKwvcwOrEx+4v5Mg61Slm9kcOSacENlt4hazGI9JLzHeUjZ3R33n0bL8RZQjwdzVgGHCpCPC0PD1RL9cXLz4obw5RDEYHxWoQztM5tL12l2CNKn2tCMKMg28qPnH+ZrozRqEIwVtn0I2ZqJjplFHyKcZ/BCVm8qVV7LCUZY/4wNI/83AW5+MupCISOKajmNYtUXjxADgB/UohA9QjI1i0p8U3KFocN0ScE9WDTkiaXQX9HKaKsMdly/yEcJzQ==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(316002)(8676002)(36860700001)(508600001)(2616005)(4326008)(44832011)(81166007)(83380400001)(110136005)(54906003)(8936002)(47076005)(7696005)(70206006)(186003)(336012)(36756003)(70586007)(2906002)(86362001)(6666004)(82310400003)(5660300002)(1076003)(26005)(426003);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2021 03:10:24.7319
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 7d8afc69-c804-4b0e-b64d-08d98f8954e7
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT014.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB7181

From: Stefano Stabellini <stefano.stabellini@xilinx.com>

Today we use native addresses to map the GICv2 for Dom0 and fixed
addresses for DomUs.

This patch changes the behavior so that native addresses are used for
all domains that are direct-map memory map.

NEW VGIC has different naming schemes, like referring distributor base
address as vgic_dist_base, other than the dbase. So this patch also introduces
vgic_dist_base/vgic_cpu_base accessor to access correct distributor base
address/cpu interface base address on varied scenarios,

Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>
Signed-off-by: Penny Zheng <penny.zheng@arm.com>
---
 xen/arch/arm/domain_build.c    | 10 +++++++---
 xen/arch/arm/vgic-v2.c         | 26 +++++++++++++++++++++-----
 xen/arch/arm/vgic/vgic-v2.c    | 27 ++++++++++++++++++++++-----
 xen/include/asm-arm/new_vgic.h | 10 ++++++++++
 xen/include/asm-arm/vgic.h     | 12 +++++++++++-
 5 files changed, 71 insertions(+), 14 deletions(-)

diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
index d9118e5bc1..6cd03e4d0f 100644
--- a/xen/arch/arm/domain_build.c
+++ b/xen/arch/arm/domain_build.c
@@ -2207,8 +2207,12 @@ static int __init make_gicv2_domU_node(struct kernel_info *kinfo)
     int res = 0;
     __be32 reg[(GUEST_ROOT_ADDRESS_CELLS + GUEST_ROOT_SIZE_CELLS) * 2];
     __be32 *cells;
+    struct domain *d = kinfo->d;
+    char buf[38];
 
-    res = fdt_begin_node(fdt, "interrupt-controller@"__stringify(GUEST_GICD_BASE));
+    snprintf(buf, sizeof(buf), "interrupt-controller@%"PRIx64,
+             vgic_dist_base(&d->arch.vgic));
+    res = fdt_begin_node(fdt, buf);
     if ( res )
         return res;
 
@@ -2230,9 +2234,9 @@ static int __init make_gicv2_domU_node(struct kernel_info *kinfo)
 
     cells = &reg[0];
     dt_child_set_range(&cells, GUEST_ROOT_ADDRESS_CELLS, GUEST_ROOT_SIZE_CELLS,
-                       GUEST_GICD_BASE, GUEST_GICD_SIZE);
+                       vgic_dist_base(&d->arch.vgic), GUEST_GICD_SIZE);
     dt_child_set_range(&cells, GUEST_ROOT_ADDRESS_CELLS, GUEST_ROOT_SIZE_CELLS,
-                       GUEST_GICC_BASE, GUEST_GICC_SIZE);
+                       vgic_cpu_base(&d->arch.vgic), GUEST_GICC_SIZE);
 
     res = fdt_property(fdt, "reg", reg, sizeof(reg));
     if (res)
diff --git a/xen/arch/arm/vgic-v2.c b/xen/arch/arm/vgic-v2.c
index b2da886adc..a8cf8173d0 100644
--- a/xen/arch/arm/vgic-v2.c
+++ b/xen/arch/arm/vgic-v2.c
@@ -652,7 +652,7 @@ static int vgic_v2_vcpu_init(struct vcpu *v)
 static int vgic_v2_domain_init(struct domain *d)
 {
     int ret;
-    paddr_t cbase, csize;
+    paddr_t csize;
     paddr_t vbase;
 
     /*
@@ -669,10 +669,26 @@ static int vgic_v2_domain_init(struct domain *d)
          * Note that we assume the size of the CPU interface is always
          * aligned to PAGE_SIZE.
          */
-        cbase = vgic_v2_hw.cbase;
+        d->arch.vgic.cbase = vgic_v2_hw.cbase;
         csize = vgic_v2_hw.csize;
         vbase = vgic_v2_hw.vbase;
     }
+    else if ( is_domain_direct_mapped(d) )
+    {
+        /*
+         * For non-dom0 direct_mapped guests we only map a 8kB CPU
+         * interface but we make sure it is at a location occupied by
+         * the physical GIC in the host device tree.
+         *
+         * We need to add an offset to the virtual CPU interface base
+         * address when the GIC is aliased to get a 8kB contiguous
+         * region.
+         */
+        d->arch.vgic.dbase = vgic_v2_hw.dbase;
+        d->arch.vgic.cbase = vgic_v2_hw.cbase + vgic_v2_hw.aliased_offset;
+        csize = GUEST_GICC_SIZE;
+        vbase = vgic_v2_hw.vbase + vgic_v2_hw.aliased_offset;
+    }
     else
     {
         d->arch.vgic.dbase = GUEST_GICD_BASE;
@@ -683,7 +699,7 @@ static int vgic_v2_domain_init(struct domain *d)
          * region.
          */
         BUILD_BUG_ON(GUEST_GICC_SIZE != SZ_8K);
-        cbase = GUEST_GICC_BASE;
+        d->arch.vgic.cbase = GUEST_GICC_BASE;
         csize = GUEST_GICC_SIZE;
         vbase = vgic_v2_hw.vbase + vgic_v2_hw.aliased_offset;
     }
@@ -692,8 +708,8 @@ static int vgic_v2_domain_init(struct domain *d)
      * Map the gic virtual cpu interface in the gic cpu interface
      * region of the guest.
      */
-    ret = map_mmio_regions(d, gaddr_to_gfn(cbase), csize / PAGE_SIZE,
-                           maddr_to_mfn(vbase));
+    ret = map_mmio_regions(d, gaddr_to_gfn(d->arch.vgic.cbase),
+                           csize / PAGE_SIZE, maddr_to_mfn(vbase));
     if ( ret )
         return ret;
 
diff --git a/xen/arch/arm/vgic/vgic-v2.c b/xen/arch/arm/vgic/vgic-v2.c
index b5ba4ace87..ce1f6e4373 100644
--- a/xen/arch/arm/vgic/vgic-v2.c
+++ b/xen/arch/arm/vgic/vgic-v2.c
@@ -258,7 +258,7 @@ void vgic_v2_enable(struct vcpu *vcpu)
 int vgic_v2_map_resources(struct domain *d)
 {
     struct vgic_dist *dist = &d->arch.vgic;
-    paddr_t cbase, csize;
+    paddr_t csize;
     paddr_t vbase;
     int ret;
 
@@ -276,10 +276,27 @@ int vgic_v2_map_resources(struct domain *d)
          * Note that we assume the size of the CPU interface is always
          * aligned to PAGE_SIZE.
          */
-        cbase = gic_v2_hw_data.cbase;
+        d->arch.vgic.vgic_cpu_base = gic_v2_hw_data.cbase;
         csize = gic_v2_hw_data.csize;
         vbase = gic_v2_hw_data.vbase;
     }
+    else if ( is_domain_direct_mapped(d) )
+    {
+        d->arch.vgic.vgic_dist_base = gic_v2_hw_data.dbase;
+        /*
+         * For non-dom0 direct_mapped guests we only map a 8kB CPU
+         * interface but we make sure it is at a location occupied by
+         * the physical GIC in the host device tree.
+         *
+         * We need to add an offset to the virtual CPU interface base
+         * address when the GIC is aliased to get a 8kB contiguous
+         * region.
+         */
+        d->arch.vgic.vgic_cpu_base = gic_v2_hw_data.cbase +
+                                     gic_v2_hw_data.aliased_offset;
+        csize = GUEST_GICC_SIZE;
+        vbase = gic_v2_hw_data.vbase + gic_v2_hw_data.aliased_offset;
+    }
     else
     {
         d->arch.vgic.vgic_dist_base = GUEST_GICD_BASE;
@@ -290,7 +307,7 @@ int vgic_v2_map_resources(struct domain *d)
          * region.
          */
         BUILD_BUG_ON(GUEST_GICC_SIZE != SZ_8K);
-        cbase = GUEST_GICC_BASE;
+        d->arch.vgic.vgic_cpu_base = GUEST_GICC_BASE;
         csize = GUEST_GICC_SIZE;
         vbase = gic_v2_hw_data.vbase + gic_v2_hw_data.aliased_offset;
     }
@@ -308,8 +325,8 @@ int vgic_v2_map_resources(struct domain *d)
      * Map the gic virtual cpu interface in the gic cpu interface
      * region of the guest.
      */
-    ret = map_mmio_regions(d, gaddr_to_gfn(cbase), csize / PAGE_SIZE,
-                           maddr_to_mfn(vbase));
+    ret = map_mmio_regions(d, gaddr_to_gfn(d->arch.vgic.vgic_cpu_base),
+                           csize / PAGE_SIZE, maddr_to_mfn(vbase));
     if ( ret )
     {
         gdprintk(XENLOG_ERR, "Unable to remap VGIC CPU to VCPU\n");
diff --git a/xen/include/asm-arm/new_vgic.h b/xen/include/asm-arm/new_vgic.h
index 97d622bff6..28b0882798 100644
--- a/xen/include/asm-arm/new_vgic.h
+++ b/xen/include/asm-arm/new_vgic.h
@@ -186,6 +186,16 @@ struct vgic_cpu {
     uint32_t num_id_bits;
 };
 
+static inline paddr_t vgic_cpu_base(struct vgic_dist *vgic)
+{
+    return vgic->vgic_cpu_base;
+}
+
+static inline paddr_t vgic_dist_base(struct vgic_dist *vgic)
+{
+    return vgic->vgic_dist_base;
+}
+
 #endif /* __ASM_ARM_NEW_VGIC_H */
 
 /*
diff --git a/xen/include/asm-arm/vgic.h b/xen/include/asm-arm/vgic.h
index 62c2ae538d..3167bbb68b 100644
--- a/xen/include/asm-arm/vgic.h
+++ b/xen/include/asm-arm/vgic.h
@@ -152,6 +152,7 @@ struct vgic_dist {
     struct pending_irq *pending_irqs;
     /* Base address for guest GIC */
     paddr_t dbase; /* Distributor base address */
+    paddr_t cbase; /* CPU interface base address */
 #ifdef CONFIG_GICV3
     /* GIC V3 addressing */
     /* List of contiguous occupied by the redistributors */
@@ -271,13 +272,22 @@ static inline int REG_RANK_NR(int b, uint32_t n)
 
 enum gic_sgi_mode;
 
+static inline paddr_t vgic_cpu_base(struct vgic_dist *vgic)
+{
+    return vgic->cbase;
+}
+
+static inline paddr_t vgic_dist_base(struct vgic_dist *vgic)
+{
+    return vgic->dbase;
+}
+
 /*
  * Offset of GICD_<FOO><n> with its rank, for GICD_<FOO> size <s> with
  * <b>-bits-per-interrupt.
  */
 #define REG_RANK_INDEX(b, n, s) ((((n) >> s) & ((b)-1)) % 32)
 
-
 extern struct vcpu *vgic_get_target_vcpu(struct vcpu *v, unsigned int virq);
 extern void vgic_remove_irq_from_queues(struct vcpu *v, struct pending_irq *p);
 extern void gic_remove_from_lr_pending(struct vcpu *v, struct pending_irq *p);
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Fri Oct 15 03:10:37 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 03:10:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.209670.366236 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbDcD-0004Kr-8e; Fri, 15 Oct 2021 03:10:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 209670.366236; Fri, 15 Oct 2021 03:10:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbDcD-0004Kg-4L; Fri, 15 Oct 2021 03:10:37 +0000
Received: by outflank-mailman (input) for mailman id 209670;
 Fri, 15 Oct 2021 03:10:35 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=lHOs=PD=arm.com=Penny.Zheng@srs-us1.protection.inumbo.net>)
 id 1mbDcB-0004HS-Gf
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 03:10:35 +0000
Received: from EUR05-AM6-obe.outbound.protection.outlook.com (unknown
 [40.107.22.42]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 752004af-2d65-11ec-821f-12813bfff9fa;
 Fri, 15 Oct 2021 03:10:33 +0000 (UTC)
Received: from AM6P194CA0103.EURP194.PROD.OUTLOOK.COM (2603:10a6:209:8f::44)
 by PA4PR08MB6254.eurprd08.prod.outlook.com (2603:10a6:102:f3::11) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.17; Fri, 15 Oct
 2021 03:10:30 +0000
Received: from AM5EUR03FT023.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:209:8f:cafe::b2) by AM6P194CA0103.outlook.office365.com
 (2603:10a6:209:8f::44) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.14 via Frontend
 Transport; Fri, 15 Oct 2021 03:10:30 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM5EUR03FT023.mail.protection.outlook.com (10.152.16.169) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.15 via Frontend Transport; Fri, 15 Oct 2021 03:10:30 +0000
Received: ("Tessian outbound e27daf245730:v103");
 Fri, 15 Oct 2021 03:10:30 +0000
Received: from 1892b2dd4137.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 7A85FFAB-1DFF-4C36-95B7-A78E8F997131.1; 
 Fri, 15 Oct 2021 03:10:24 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 1892b2dd4137.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 15 Oct 2021 03:10:24 +0000
Received: from AS9PR06CA0415.eurprd06.prod.outlook.com (2603:10a6:20b:461::19)
 by AM9PR08MB7118.eurprd08.prod.outlook.com (2603:10a6:20b:41e::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15; Fri, 15 Oct
 2021 03:10:22 +0000
Received: from VE1EUR03FT042.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:461:cafe::78) by AS9PR06CA0415.outlook.office365.com
 (2603:10a6:20b:461::19) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16 via Frontend
 Transport; Fri, 15 Oct 2021 03:10:22 +0000
Received: from nebula.arm.com (40.67.248.234) by
 VE1EUR03FT042.mail.protection.outlook.com (10.152.19.62) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.4608.15 via Frontend Transport; Fri, 15 Oct 2021 03:10:22 +0000
Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX04.Arm.com
 (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.14; Fri, 15 Oct
 2021 03:10:21 +0000
Received: from penny.shanghai.arm.com (10.169.190.66) by mail.arm.com
 (10.251.24.32) with Microsoft SMTP Server id 15.1.2308.14 via Frontend
 Transport; Fri, 15 Oct 2021 03:10:19 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 752004af-2d65-11ec-821f-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Vz58lP2uAUPeaLDiq8X99/gL5SOx543GcdmK5jCjJBQ=;
 b=V/O85K8GRDCTb7UjAMZrxP02Gsilok1P1XPrsUwSbamhWumAvu6QdX2Xqdr9oo69T0LDwA1Rk9RfjVM//8whtwVnQWTMZTy6lj87EG2UhohvmbgKMtH4yNdIRdOllgZF2Hs6xT406+9u5eNwWX31tJ6UGPQcJeBAubvlO1/CBBk=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: c1c1336286f31a8c
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=XSJzBIYNW2oQ6MErBnEETmjSpkWdW2XQPSNwH98bqGkpRXtBNfSkeATh8jAyRVMWeP67vnxfsrUJL2h2BI5bt4dk4bWu6RaSfPXrL+jQxTltM3ES5wJGpMhwD2Li3TuET26Aal+y93u8UlsIJcLl6xDl8/Mj3gwHH3jjWS9yKJ6LtsYmxp1PLgORl2FtcK6iOS1f0ZCU38dSeq6CMCM5loP4aepC8NGYeYmcJLMBhRZrLTtdzh/OBb7Ee0UJuLEqO4EzEfFGl/v1c+nO/4IyveN6vf1qCEQoMF1aCoLktmVf3nA6cuFXAQwsQF0/offpgMx/sn3iGcLpR+jUOBd/2Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Vz58lP2uAUPeaLDiq8X99/gL5SOx543GcdmK5jCjJBQ=;
 b=cxSKBtxeATY7zrZ5uyxUkEyhWc4VCcxJIUVtyTaHO8jnkzogiFY7bS0WdiA2ojP0wHP3cjghUJx+sRZvpzqGEdMLeucT1NblUuLyDfQIrz7rHNgg1Bfrs7UJ3TiN7nH8+nI/0ukp84ZvJTWiyQ/qrU/tzTpASb69LY+sN0x1m/MRuup4ny+vwQHaMXucQv+PSDUfIaq0r3Uv3kELNYUWzRopn8HWo7N25d9FSArfR02HbnrTYVux0pt+61Cr5U7T1RCPIR7LVpOuzXE6zW5eaDtvxcJdY1D+NOUamK7ydk9HUfS1Fi5POuFGix2xoHcWtrDjnxINEvwoAnOE4aFXhA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Vz58lP2uAUPeaLDiq8X99/gL5SOx543GcdmK5jCjJBQ=;
 b=V/O85K8GRDCTb7UjAMZrxP02Gsilok1P1XPrsUwSbamhWumAvu6QdX2Xqdr9oo69T0LDwA1Rk9RfjVM//8whtwVnQWTMZTy6lj87EG2UhohvmbgKMtH4yNdIRdOllgZF2Hs6xT406+9u5eNwWX31tJ6UGPQcJeBAubvlO1/CBBk=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=pass action=none
 header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 40.67.248.234 as permitted sender) receiver=protection.outlook.com;
 client-ip=40.67.248.234; helo=nebula.arm.com;
From: Penny Zheng <penny.zheng@arm.com>
To: <xen-devel@lists.xenproject.org>, <sstabellini@kernel.org>,
	<julien@xen.org>
CC: <Wei.Chen@arm.com>, <Bertrand.Marquis@arm.com>
Subject: [PATCH v2 5/6] xen/arm: if direct-map domain use native UART address and IRQ number for vPL011
Date: Fri, 15 Oct 2021 03:09:44 +0000
Message-ID: <20211015030945.2082898-6-penny.zheng@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20211015030945.2082898-1-penny.zheng@arm.com>
References: <20211015030945.2082898-1-penny.zheng@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-EOPAttributedMessage: 1
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: e7fb8f1a-1b73-4273-4ad6-08d98f895864
X-MS-TrafficTypeDiagnostic: AM9PR08MB7118:|PA4PR08MB6254:
X-Microsoft-Antispam-PRVS:
	<PA4PR08MB62546D3BEB191DB925CD535EF7B99@PA4PR08MB6254.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 mZTk7GJ/OXb7lJCHStCxSUhves0syM1xZVWF8rNGgBN2UpRVuNt/btG4A6cnj29rZPHc/32KWzOMIbBA19+2vk6efucYWdYQpqThDaSQdavSNrwYp9MvzKmWG31zfVqaaM6MW0/DYL3BalWJH0/AA68X10eN9a7wrCjwPV6ucT8KcaDAXtMqRBTnIahLQ+C1B+/JTHB1Zs1GgbxqSkKXDeyU7GwZSrvo8zLeuePOZ8lyDCIptcXacNBmRntulwASjgxXc1vKK6sPxJm1GYt/Ns77pRC6ar/dKvs1dC3H5DkqVrzJ9Lb1tQk6YRUAjT9n31RDdzenqu3Po7zNFi3fEHGLf0BiMAbxR8Uch3XrcLJUv88L2UMNOnAk9IlFzDVUcsHBUaCcCgZuExeztBBiz4SBml+7noVFrZGWPbwmqSfzEcj2kVv+a5is6Zqwq7sh6EIxDIOFsN7Xai48aOinn3PTfK+Lt+gPPPFcMOu9xl8Gwm5Bdjv83MIroNik2+9pmyReY4WOi63eLXi4adiav27w3YKvqIj2g9xqLx3WeD8UVc9uY4eItX4t7RhSJG56rQ7xLLOGS92GswpxBUPqt2zRGlZ3t4MboFGFr0u/vG4t3T691fVKbaTwNv4ZmUqEUqYEsxlOKGjhanqGWHzhDo2JgXJOa1EuZD1i3V52ua1jyV1JM2HETJLY2S5oH3V/OEXO6lP+6JT8UeZ6wCyt3D/Fqg72fmi8ImQa5EPn7L8=
X-Forefront-Antispam-Report-Untrusted:
 CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(83380400001)(8936002)(426003)(8676002)(86362001)(82310400003)(336012)(70586007)(186003)(26005)(70206006)(1076003)(47076005)(2616005)(36860700001)(36756003)(356005)(508600001)(44832011)(7696005)(54906003)(4326008)(6666004)(110136005)(316002)(81166007)(5660300002)(2906002)(36900700001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB7118
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM5EUR03FT023.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	4e454218-ecbf-4d35-cff3-08d98f8953b6
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	xJVMe2D0bDU38cKa61JOOZVGa1nJXLQRd7wCqOoOoiSO10mTXZpz9v2ADuoR/ixzDx/2y6ZEgO36KtoE/tdhY4/S75CVZk6seNq5K6qWM4LaC2gBnPoZ/nvh3j32xN2oMpyKotTqhckVy5EdnNbcVOlYqBmRh+ANFB9DA5vPKsKE8uIjcPiVnUlKu4Fxd9OgpKAwDwzYXg/TdR4YEF6xZwvPSbDZL5/6n2T4oDd4OyJj3r6T28a/TqJxFyuX8Kp34SPSV8NEmvU5Cll+R5cLOMmyDm3uITz9yEB09+NCnqKbWeyWTbKK6Ko/emZDPNsrMKweu7r59uAyLjIUaTPZivmWhyAEBlIB1prfCkC0k4hndtpe7OvPwURWD/ncQgl+659765EWj6OxTmQX8HGBo0b1Fvuz4pZmRxSFUuuUgyC8Bh2eS1mGJLNsplWcOrVroN1EH63eZcgR53Yp+PB1NJskDNL0TTgYp9r5uh8YmkEQb6VIqYAx3Y3Vqs6+JmbXJoWYjcPTR/B3LjdTJpljnrjoVsNFAUNsgZXm+U2lzScytsDUByExlvI6nqvYUL0qN89OyieejroKyBOKZG1rX47/728fwI1jKlHTJIhrBO5Y0NXLcg5BNjXazbeOTHFMJ1qaB4v2XimNEpXmD7BJp/gp+0P6JUWv/xmn5+N3ZEOy4pEMeUzjxd4nR3lwu90VbCoTAy8RKDlgrHlhTVpXrg==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(70586007)(36756003)(47076005)(8936002)(336012)(7696005)(70206006)(186003)(1076003)(26005)(426003)(86362001)(2906002)(6666004)(82310400003)(5660300002)(36860700001)(8676002)(508600001)(316002)(81166007)(83380400001)(44832011)(54906003)(110136005)(2616005)(4326008);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2021 03:10:30.5131
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: e7fb8f1a-1b73-4273-4ad6-08d98f895864
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM5EUR03FT023.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB6254

From: Stefano Stabellini <stefano.stabellini@xilinx.com>

We always use a fix address to map the vPL011 to domains. The address
could be a problem for direct-map domains.

So, for domains that are directly mapped, reuse the address of the
physical UART on the platform to avoid potential clashes.

Do the same for the virtual IRQ number: instead of always using
GUEST_VPL011_SPI, try to reuse the physical SPI number if possible.

Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>
Signed-off-by: Penny Zheng <penny.zheng@arm.com>
---
 xen/arch/arm/domain_build.c  | 41 ++++++++++++++++++++++-----
 xen/arch/arm/vpl011.c        | 54 +++++++++++++++++++++++++++++++-----
 xen/include/asm-arm/vpl011.h |  2 ++
 3 files changed, 83 insertions(+), 14 deletions(-)

diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
index 7e0ee07e06..f3e87709f6 100644
--- a/xen/arch/arm/domain_build.c
+++ b/xen/arch/arm/domain_build.c
@@ -30,6 +30,7 @@
 
 #include <xen/irq.h>
 #include <xen/grant_table.h>
+#include <xen/serial.h>
 
 static unsigned int __initdata opt_dom0_max_vcpus;
 integer_param("dom0_max_vcpus", opt_dom0_max_vcpus);
@@ -2350,8 +2351,11 @@ static int __init make_vpl011_uart_node(struct kernel_info *kinfo)
     gic_interrupt_t intr;
     __be32 reg[GUEST_ROOT_ADDRESS_CELLS + GUEST_ROOT_SIZE_CELLS];
     __be32 *cells;
+    struct domain *d = kinfo->d;
+    char buf[27];
 
-    res = fdt_begin_node(fdt, "sbsa-uart@"__stringify(GUEST_PL011_BASE));
+    snprintf(buf, sizeof(buf), "sbsa-uart@%"PRIx64, d->arch.vpl011.base_addr);
+    res = fdt_begin_node(fdt, buf);
     if ( res )
         return res;
 
@@ -2361,14 +2365,14 @@ static int __init make_vpl011_uart_node(struct kernel_info *kinfo)
 
     cells = &reg[0];
     dt_child_set_range(&cells, GUEST_ROOT_ADDRESS_CELLS,
-                       GUEST_ROOT_SIZE_CELLS, GUEST_PL011_BASE,
+                       GUEST_ROOT_SIZE_CELLS, d->arch.vpl011.base_addr,
                        GUEST_PL011_SIZE);
 
     res = fdt_property(fdt, "reg", reg, sizeof(reg));
     if ( res )
         return res;
 
-    set_interrupt(intr, GUEST_VPL011_SPI, 0xf, DT_IRQ_TYPE_LEVEL_HIGH);
+    set_interrupt(intr, d->arch.vpl011.virq, 0xf, DT_IRQ_TYPE_LEVEL_HIGH);
 
     res = fdt_property(fdt, "interrupts", intr, sizeof (intr));
     if ( res )
@@ -3083,6 +3087,14 @@ static int __init construct_domU(struct domain *d,
             allocate_static_memory(d, &kinfo, node);
     }
 
+    /*
+     * Base address and irq number are needed when creating vpl011 device
+     * tree node in prepare_dtb_domU, so initialization on related variables
+     * shall be dealt firstly.
+     */
+    if ( kinfo.vpl011 )
+        rc = domain_vpl011_init(d, NULL);
+
     rc = prepare_dtb_domU(d, &kinfo);
     if ( rc < 0 )
         return rc;
@@ -3091,9 +3103,6 @@ static int __init construct_domU(struct domain *d,
     if ( rc < 0 )
         return rc;
 
-    if ( kinfo.vpl011 )
-        rc = domain_vpl011_init(d, NULL);
-
     return rc;
 }
 
@@ -3132,15 +3141,33 @@ void __init create_domUs(void)
 
         if ( !dt_property_read_u32(node, "nr_spis", &d_cfg.arch.nr_spis) )
         {
+            unsigned int vpl011_virq = GUEST_VPL011_SPI;
+
             d_cfg.arch.nr_spis = gic_number_lines() - 32;
 
+            /*
+             * The VPL011 virq is GUEST_VPL011_SPI, unless direct-map in
+             * set, in which case we'll try to match the hardware.
+             *
+             * Typically, d->arch.vpl011.virq has the vpl011 irq number
+             * but at this point of the boot sequence it is not
+             * initialized yet.
+             */
+            if ( d_cfg.flags & XEN_DOMCTL_CDF_directmap )
+            {
+                vpl011_virq = serial_irq(SERHND_DTUART);
+                if ( vpl011_virq < 0 )
+                    panic("Error getting IRQ number for this serial port %d\n",
+                          SERHND_DTUART);
+            }
+
             /*
              * vpl011 uses one emulated SPI. If vpl011 is requested, make
              * sure that we allocate enough SPIs for it.
              */
             if ( dt_property_read_bool(node, "vpl011") )
                 d_cfg.arch.nr_spis = MAX(d_cfg.arch.nr_spis,
-                                         GUEST_VPL011_SPI - 32 + 1);
+                                         vpl011_virq - 32 + 1);
         }
 
         /*
diff --git a/xen/arch/arm/vpl011.c b/xen/arch/arm/vpl011.c
index 895f436cc4..2de59e584d 100644
--- a/xen/arch/arm/vpl011.c
+++ b/xen/arch/arm/vpl011.c
@@ -29,6 +29,7 @@
 #include <xen/mm.h>
 #include <xen/sched.h>
 #include <xen/console.h>
+#include <xen/serial.h>
 #include <public/domctl.h>
 #include <public/io/console.h>
 #include <asm/pl011-uart.h>
@@ -71,11 +72,11 @@ static void vpl011_update_interrupt_status(struct domain *d)
      * status bit has been set since the last time.
      */
     if ( uartmis & ~vpl011->shadow_uartmis )
-        vgic_inject_irq(d, NULL, GUEST_VPL011_SPI, true);
+        vgic_inject_irq(d, NULL, vpl011->virq, true);
 
     vpl011->shadow_uartmis = uartmis;
 #else
-    vgic_inject_irq(d, NULL, GUEST_VPL011_SPI, uartmis);
+    vgic_inject_irq(d, NULL, vpl011->virq, uartmis);
 #endif
 }
 
@@ -347,7 +348,8 @@ static int vpl011_mmio_read(struct vcpu *v,
                             void *priv)
 {
     struct hsr_dabt dabt = info->dabt;
-    uint32_t vpl011_reg = (uint32_t)(info->gpa - GUEST_PL011_BASE);
+    uint32_t vpl011_reg = (uint32_t)(info->gpa -
+                                     v->domain->arch.vpl011.base_addr);
     struct vpl011 *vpl011 = &v->domain->arch.vpl011;
     struct domain *d = v->domain;
     unsigned long flags;
@@ -430,7 +432,8 @@ static int vpl011_mmio_write(struct vcpu *v,
                              void *priv)
 {
     struct hsr_dabt dabt = info->dabt;
-    uint32_t vpl011_reg = (uint32_t)(info->gpa - GUEST_PL011_BASE);
+    uint32_t vpl011_reg = (uint32_t)(info->gpa -
+                                     v->domain->arch.vpl011.base_addr);
     struct vpl011 *vpl011 = &v->domain->arch.vpl011;
     struct domain *d = v->domain;
     unsigned long flags;
@@ -626,6 +629,43 @@ int domain_vpl011_init(struct domain *d, struct vpl011_init_info *info)
     if ( vpl011->backend.dom.ring_buf )
         return -EINVAL;
 
+    if ( is_domain_direct_mapped(d) )
+    {
+        const struct vuart_info *uart = serial_vuart_info(SERHND_DTUART);
+        int vpl011_irq = serial_irq(SERHND_DTUART);
+
+        /*
+         * Since the PL011 we emulate for the guest requires a 4KB region,
+         * and on some Hardware (IIRC pine64), the UART MMIO region is
+         * less than 4KB, in which case, there may exist multiple devices
+         * within the same 4KB region, here adds the following check to
+         * prevent potential known pitfalls
+         */
+        if ( uart->size < GUEST_PL011_SIZE )
+        {
+            printk(XENLOG_ERR
+                   "The hardware UART region is smaller than GUEST_PL011_SIZE, impossible to emulate on direct-map guests.\n");
+            return -EINVAL;
+        }
+
+        if ( uart != NULL && vpl011_irq > 0 )
+        {
+            vpl011->base_addr = uart->base_addr;
+            vpl011->virq = vpl011_irq;
+        }
+        else
+        {
+            printk(XENLOG_ERR
+                   "Unable to reuse physical UART address and irq for vPL011 on direct-mapped domain.\n");
+            return -EINVAL;
+        }
+    }
+    else
+    {
+        vpl011->base_addr = GUEST_PL011_BASE;
+        vpl011->virq = GUEST_VPL011_SPI;
+    }
+
     /*
      * info is NULL when the backend is in Xen.
      * info is != NULL when the backend is in a domain.
@@ -661,7 +701,7 @@ int domain_vpl011_init(struct domain *d, struct vpl011_init_info *info)
         }
     }
 
-    rc = vgic_reserve_virq(d, GUEST_VPL011_SPI);
+    rc = vgic_reserve_virq(d, vpl011->virq);
     if ( !rc )
     {
         rc = -EINVAL;
@@ -673,12 +713,12 @@ int domain_vpl011_init(struct domain *d, struct vpl011_init_info *info)
     spin_lock_init(&vpl011->lock);
 
     register_mmio_handler(d, &vpl011_mmio_handler,
-                          GUEST_PL011_BASE, GUEST_PL011_SIZE, NULL);
+                          vpl011->base_addr, GUEST_PL011_SIZE, NULL);
 
     return 0;
 
 out2:
-    vgic_free_virq(d, GUEST_VPL011_SPI);
+    vgic_free_virq(d, vpl011->virq);
 
 out1:
     if ( vpl011->backend_in_domain )
diff --git a/xen/include/asm-arm/vpl011.h b/xen/include/asm-arm/vpl011.h
index e6c7ab7381..c09abcd7a9 100644
--- a/xen/include/asm-arm/vpl011.h
+++ b/xen/include/asm-arm/vpl011.h
@@ -53,6 +53,8 @@ struct vpl011 {
     uint32_t    uarticr;        /* Interrupt clear register */
     uint32_t    uartris;        /* Raw interrupt status register */
     uint32_t    shadow_uartmis; /* shadow masked interrupt register */
+    paddr_t     base_addr;
+    unsigned int virq;
     spinlock_t  lock;
     evtchn_port_t evtchn;
 };
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Fri Oct 15 03:10:38 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 03:10:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.209671.366247 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbDcE-0004dF-R8; Fri, 15 Oct 2021 03:10:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 209671.366247; Fri, 15 Oct 2021 03:10:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbDcE-0004cP-Lb; Fri, 15 Oct 2021 03:10:38 +0000
Received: by outflank-mailman (input) for mailman id 209671;
 Fri, 15 Oct 2021 03:10:37 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=lHOs=PD=arm.com=Penny.Zheng@srs-us1.protection.inumbo.net>)
 id 1mbDcD-00031m-Hp
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 03:10:37 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com (unknown
 [2a01:111:f400:fe0e::620])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id b76fa7e3-50da-4fd5-8d0a-a9be13ad0605;
 Fri, 15 Oct 2021 03:10:34 +0000 (UTC)
Received: from AS9PR06CA0008.eurprd06.prod.outlook.com (2603:10a6:20b:462::22)
 by VI1PR08MB4046.eurprd08.prod.outlook.com (2603:10a6:803:e4::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.17; Fri, 15 Oct
 2021 03:10:32 +0000
Received: from VE1EUR03FT024.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:462:cafe::be) by AS9PR06CA0008.outlook.office365.com
 (2603:10a6:20b:462::22) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16 via Frontend
 Transport; Fri, 15 Oct 2021 03:10:32 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT024.mail.protection.outlook.com (10.152.18.87) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.15 via Frontend Transport; Fri, 15 Oct 2021 03:10:31 +0000
Received: ("Tessian outbound a8bfe25d7364:v103");
 Fri, 15 Oct 2021 03:10:31 +0000
Received: from efea9ca5927b.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 AC475658-FDCE-4757-B107-C3B05D98B7EF.1; 
 Fri, 15 Oct 2021 03:10:25 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id efea9ca5927b.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 15 Oct 2021 03:10:25 +0000
Received: from AS9PR06CA0398.eurprd06.prod.outlook.com (2603:10a6:20b:461::17)
 by DBAPR08MB5639.eurprd08.prod.outlook.com (2603:10a6:10:1a2::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15; Fri, 15 Oct
 2021 03:10:24 +0000
Received: from VE1EUR03FT042.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:461:cafe::89) by AS9PR06CA0398.outlook.office365.com
 (2603:10a6:20b:461::17) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16 via Frontend
 Transport; Fri, 15 Oct 2021 03:10:23 +0000
Received: from nebula.arm.com (40.67.248.234) by
 VE1EUR03FT042.mail.protection.outlook.com (10.152.19.62) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.4608.15 via Frontend Transport; Fri, 15 Oct 2021 03:10:23 +0000
Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX04.Arm.com
 (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.14; Fri, 15 Oct
 2021 03:10:23 +0000
Received: from penny.shanghai.arm.com (10.169.190.66) by mail.arm.com
 (10.251.24.32) with Microsoft SMTP Server id 15.1.2308.14 via Frontend
 Transport; Fri, 15 Oct 2021 03:10:21 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b76fa7e3-50da-4fd5-8d0a-a9be13ad0605
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=RUJuKpAtpsPU2vd6yUZACXFm8wINo0vkIbxoIx5eFVM=;
 b=KEVRmGYC0T2TTQplNAlzGBfiygHJmkOyRIev7IzJNNbEhh+ipIWpDbQ2R0D3znn87aMIvbIL/IP6/rZsy3qCUjwXOBgTaqWj68yo9r4RVTXCsIgy5yK/0T09k/2/1xWyUBs7WDXscI7TkEpOXe6gI+iEtHdpAyJvb9uS2qdDOoc=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 6692223e128db74c
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=RTil/ROeOmMLOH5a1lRAnlSp5rPpVYsB31Y0sGMCldDxYNHOhVDXwvlhhMFbsXoQYrliXpE8YkS6XC9fLCdxIYnfW8answvxRG4/99IkufxK+wd3y+vdMGXPuEeB54p+/UufGVpJ+ILlzq3q/ZcZNCh7bTM2/4MFeUmjSHtFrfYQ+8srQOt7xxCAkVh5a29Q6gqNEv3zmCkA7XoftsxLdsnf2ePBQ6vIF+XOc59zPKzH7NVyywQnOi/ayXPOP7zA/0XnOChV3FO/41ZThw5k1VQ8IL/PIJ9TgfjktdeNK5gHgGRHgS65SXgtHd7vyTKMe7mfrXqJ2KXnDJa1fXoS+g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=RUJuKpAtpsPU2vd6yUZACXFm8wINo0vkIbxoIx5eFVM=;
 b=Rjy6QoCV3pDCu5gpmG9yF+GWjaKwaStinPyOgojDWpLE1Y+nhnounzUsUTJJ4DFljhR6MzZG5p+fJ633yIlBrEClucHfh4V15Q/5qJ8ba8UiETjih8QJ/Fq5JGhNxxnfskdsaNqLtdEezERfxdavQjEIr9CZcDdcsYekpwVfBn6fsn7BG86Xr5hpSVo1CeTja08h1jt+N/fjw+dVdkVq6rvzhmm2WFvodCh5ryV8pue0bBLx3lWHEJHM0NkF1dPkLal8V4UH+wG8fodEBc3T4/jmm/Ht4xG+UZZJzCj2cr42H2zGu7dCFfDNpK3ezb8yy6glIwRkVQkS/yeokJQdfQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=RUJuKpAtpsPU2vd6yUZACXFm8wINo0vkIbxoIx5eFVM=;
 b=KEVRmGYC0T2TTQplNAlzGBfiygHJmkOyRIev7IzJNNbEhh+ipIWpDbQ2R0D3znn87aMIvbIL/IP6/rZsy3qCUjwXOBgTaqWj68yo9r4RVTXCsIgy5yK/0T09k/2/1xWyUBs7WDXscI7TkEpOXe6gI+iEtHdpAyJvb9uS2qdDOoc=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=pass action=none
 header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 40.67.248.234 as permitted sender) receiver=protection.outlook.com;
 client-ip=40.67.248.234; helo=nebula.arm.com;
From: Penny Zheng <penny.zheng@arm.com>
To: <xen-devel@lists.xenproject.org>, <sstabellini@kernel.org>,
	<julien@xen.org>
CC: <Wei.Chen@arm.com>, <Bertrand.Marquis@arm.com>
Subject: [PATCH v2 6/6] xen/docs: add a document to explain how to do passthrough without IOMMU
Date: Fri, 15 Oct 2021 03:09:45 +0000
Message-ID: <20211015030945.2082898-7-penny.zheng@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20211015030945.2082898-1-penny.zheng@arm.com>
References: <20211015030945.2082898-1-penny.zheng@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-EOPAttributedMessage: 1
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 3c4ff210-081e-4742-c1b2-08d98f895936
X-MS-TrafficTypeDiagnostic: DBAPR08MB5639:|VI1PR08MB4046:
X-Microsoft-Antispam-PRVS:
	<VI1PR08MB40462940A03EF099B0E386ECF7B99@VI1PR08MB4046.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Oob-TLC-OOBClassifiers: OLM:8273;OLM:8273;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 xGxNC2DHMncS/Qs/Df9vCMt3AyEJKiPpGWu9lW8mAYrWPr9WvAsOFFh0yty+J6KRA7NRSssXQQPDRgv6hzA03t82+34eR/uBy+dEVv8K2tTsi6Tpnq+MgjoB6FJ4lqjv/whuJbEDLW2RGDi2BpRlt1wOLUCNHxiA9X9rMPdGwbulyaI4Dfu3wFsPfq8RIwW//ODO+LYL/9X/AZ4z9XriiOh/lY6FoPOI+r2WQTs/wfUp69khLRt/TJDDNlnYIdypPqLs4N0WxgJF+aD7cgTyUZ1IrxUuoEeCt3MLtz9u9PmcvLRjQT2GO88TfVQgeVbDBofB00jhHdxpEAs8WNM3cpef+xAz+xKxC2HG4Jsy2TAYX1z8LJWegmjfKkulbVP3HKW1jpxl3giJ2USE1j1aHSN7sdFdKJuk8mLScbhaJI5wSbQrwz9WqoBx9aZgw41eqx9q+GdtlS7zUYr9OndWMK6d4XmYqs+cPL2nGoYr+7kleuolN9PoFg2B7b9dVZUCxuRFZMc1OEoaEZhM5PJ81HhoTlNiD5ADj6y6AGx2S6CX1Z6K3QU1pEsBKRp6fOrlwnHOFxkfYDuOXaoNlV3tCwf9aQ190T11AqDYfPLvUb8cHE0k7f28ziC33wp3KD3ggyOEAyfKeH7fiHcjU5Vbq5ROEQ9/0c1Zo3+WW0GmJsXA7LvxlsjKbOd00dUa4JAgfVGczDFtvJIp2tBbCTyf0hj97TaAahlO0xOo64KhdwE=
X-Forefront-Antispam-Report-Untrusted:
 CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(82310400003)(70586007)(2616005)(44832011)(8676002)(7696005)(508600001)(426003)(356005)(8936002)(70206006)(86362001)(110136005)(54906003)(81166007)(4326008)(47076005)(26005)(186003)(83380400001)(5660300002)(336012)(6666004)(36860700001)(1076003)(36756003)(316002)(2906002)(36900700001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR08MB5639
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT024.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	a6655f12-dc00-441c-39e5-08d98f895452
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	4tbHAxVfjTbBSah5PNe2tzrMUHCo5+sp+q/7wIZw9IVgDCqbWkowcQzCx4xRZqbjrPdiHM8uezETB7+5qgb6xP3AW2UH7ulRJtAfNiaVoKVDTsh6FR9sHLn3gfIaSo5Y2cy5Znbxbw6/1HdHsXQ3CITV8wWySPCXsXGGMWah6S7qSCoCZIe1QrgfJfFW/y6DLCUOSaL+I5JYQq6GchszE2ZXChkhqISCc9R7SN9vy08m514UjSGYm+0WMoIPnhaUPZb4RxhRXmtkdyDY7qIkzWtL0ka/s7DRfyEAzqB/lwL1syN3fQIBrKB0moGF/vn9BhiX2D+cq+VXko4pIwJJVtdcxz7YyMnISkOvo2ekc5SWeV2M+XOJojn5iNEiYYvwW8O0xpNrinegycoKhbOtSqhkPqCVkKE/Y2VqAp1VojKLjud1vMxaWE7VfVsKBMnHMYNm3Hzz1SkUuOs+CEsGkbl2m+WTNe6neYOR23H4Nh7t33VbXYGu3QFMKCg0ONKopCfxcWPGLLSp+nX8XpsDhCGGdnihZIZ6A6GqQRedwXV8dk5e9p5ullgPMO2J4n/AiR9KUaZSTACc2jXnz6OulHWNPhD7r2J49ptkrG11b2+j9waKD7RwVjnDbZPEz6uH9ScBPnlavG/eUnL+gZw0aBw8EnIrFVl18e3rSUbKHbnfI75TI8fuquGG1Dx631sIsIhhOaaVbArU2jIBujWV5g==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(47076005)(82310400003)(8936002)(6666004)(1076003)(508600001)(70206006)(4326008)(2906002)(7696005)(36756003)(70586007)(2616005)(186003)(83380400001)(5660300002)(316002)(54906003)(44832011)(110136005)(8676002)(26005)(86362001)(336012)(81166007)(426003)(36860700001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2021 03:10:31.8638
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 3c4ff210-081e-4742-c1b2-08d98f895936
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT024.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB4046

From: Stefano Stabellini <stefano.stabellini@xilinx.com>

Make sure to start with a WARNING about security.

Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>
Signed-off-by: Penny Zheng <penny.zheng@arm.com>
---
 docs/misc/arm/passthrough-noiommu.txt | 54 +++++++++++++++++++++++++++
 1 file changed, 54 insertions(+)
 create mode 100644 docs/misc/arm/passthrough-noiommu.txt

diff --git a/docs/misc/arm/passthrough-noiommu.txt b/docs/misc/arm/passthrough-noiommu.txt
new file mode 100644
index 0000000000..61aeb8a5cd
--- /dev/null
+++ b/docs/misc/arm/passthrough-noiommu.txt
@@ -0,0 +1,54 @@
+Request Device Assignment without IOMMU support
+===============================================
+
+*WARNING:
+Users should be aware that it is not always secure to assign a device without
+IOMMU protection.
+When the device is not protected by the IOMMU, the administrator should make
+sure that:
+ 1. The device is assigned to a trusted guest.
+ 2. Users have additional security mechanism on the platform.
+
+
+This document assumes that the IOMMU is absent from the system or it is
+disabled (status = "disabled" in device tree).
+
+
+Add xen,force-assign-without-iommu; to the device tree snippet:
+
+ethernet: ethernet@ff0e0000 {
+	compatible = "cdns,zynqmp-gem";
+	xen,path = "/amba/ethernet@ff0e0000";
+	xen,reg = <0x0 0xff0e0000 0x1000 0x0 0xff0e0000>;
+	xen,force-assign-without-iommu;
+};
+
+Request 1:1 memory mapping for the domain on static allocation
+==============================================================
+
+Add a direct-map property under the appropriate /chosen/domU node which
+is also statically allocated with physical memory ranges through
+xen,static-mem property as its guest RAM.
+
+Below is an example on how to specify the 1:1 memory mapping for the domain
+on static allocation in the device-tree:
+
+/ {
+	chosen {
+		domU1 {
+			compatible = "xen,domain";
+			#address-cells = <0x2>;
+			#size-cells = <0x2>;
+			cpus = <2>;
+			memory = <0x0 0x80000>;
+			#xen,static-mem-address-cells = <0x1>;
+			#xen,static-mem-size-cells = <0x1>;
+			xen,static-mem = <0x30000000 0x20000000>;
+			direct-map;
+			...
+		};
+	};
+};
+
+Besides reserving a 512MB region starting at the host physical address
+0x30000000 to DomU1, it also requests 1:1 memory mapping.
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Fri Oct 15 03:10:57 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 03:10:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.209685.366259 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbDcX-0005jF-7e; Fri, 15 Oct 2021 03:10:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 209685.366259; Fri, 15 Oct 2021 03:10:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbDcX-0005j8-2z; Fri, 15 Oct 2021 03:10:57 +0000
Received: by outflank-mailman (input) for mailman id 209685;
 Fri, 15 Oct 2021 03:10:55 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=lHOs=PD=arm.com=Penny.Zheng@srs-us1.protection.inumbo.net>)
 id 1mbDcV-0004HS-CC
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 03:10:55 +0000
Received: from EUR02-HE1-obe.outbound.protection.outlook.com (unknown
 [40.107.1.75]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 799bfe36-2d65-11ec-821f-12813bfff9fa;
 Fri, 15 Oct 2021 03:10:40 +0000 (UTC)
Received: from AS9PR06CA0338.eurprd06.prod.outlook.com (2603:10a6:20b:466::32)
 by VE1PR08MB5648.eurprd08.prod.outlook.com (2603:10a6:800:1af::24)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16; Fri, 15 Oct
 2021 03:10:30 +0000
Received: from VE1EUR03FT043.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:466:cafe::31) by AS9PR06CA0338.outlook.office365.com
 (2603:10a6:20b:466::32) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16 via Frontend
 Transport; Fri, 15 Oct 2021 03:10:29 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT043.mail.protection.outlook.com (10.152.19.122) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.15 via Frontend Transport; Fri, 15 Oct 2021 03:10:29 +0000
Received: ("Tessian outbound e27daf245730:v103");
 Fri, 15 Oct 2021 03:10:29 +0000
Received: from 4e1d6899786e.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 E8751317-415A-43BB-B316-49CF04254EDE.1; 
 Fri, 15 Oct 2021 03:10:22 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 4e1d6899786e.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 15 Oct 2021 03:10:22 +0000
Received: from AS9PR06CA0398.eurprd06.prod.outlook.com (2603:10a6:20b:461::17)
 by DBAPR08MB5639.eurprd08.prod.outlook.com (2603:10a6:10:1a2::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15; Fri, 15 Oct
 2021 03:10:20 +0000
Received: from VE1EUR03FT042.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:461:cafe::89) by AS9PR06CA0398.outlook.office365.com
 (2603:10a6:20b:461::17) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16 via Frontend
 Transport; Fri, 15 Oct 2021 03:10:20 +0000
Received: from nebula.arm.com (40.67.248.234) by
 VE1EUR03FT042.mail.protection.outlook.com (10.152.19.62) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.4608.15 via Frontend Transport; Fri, 15 Oct 2021 03:10:20 +0000
Received: from AZ-NEU-EX01.Emea.Arm.com (10.251.26.4) by AZ-NEU-EX04.Arm.com
 (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2308.14; Fri, 15 Oct
 2021 03:10:19 +0000
Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX01.Emea.Arm.com
 (10.251.26.4) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14; Fri, 15
 Oct 2021 03:10:09 +0000
Received: from penny.shanghai.arm.com (10.169.190.66) by mail.arm.com
 (10.251.24.32) with Microsoft SMTP Server id 15.1.2308.14 via Frontend
 Transport; Fri, 15 Oct 2021 03:10:17 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 799bfe36-2d65-11ec-821f-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=imPNKA0H7eYyeIQsMpyGnIIqmigQJ3jDrzkFsH2EPao=;
 b=kEVIc37F96phUFViCOuJNrFF/1K1GuwA022WH4KZ3V2Uei2snOVK21lNSXG2qwo9JVL/t55l0GZjP6OI7KbhqanL+XwhUogX8OaKh13Ctf+CzHltFYwHW0DPwbgsOK9yJ4XM163rOmeJvCtOMBv2N86fI9adXQJqggQAMQU8pfg=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 18f086eb5cd28944
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=X8VERSv3mkuqj0stD7mknQBK8A/QbWmTv+6KlzkX4nlLmntcDQgrRyUt9chE5o0+uEQAe7Ky3BknBfdIM8wbxbITmEU1Uz8dxrSpsXM25qNA+WAgEq37AhcGB/xuVj6F0VwA4BM8+yFOT6k2q5cWnTHFwqJAoywxQp6qkEzSbt4C6U7aYvoz6tFPqLuapPmxidrx3WuafEO1+SKOGNon3qtJJ5wj4ntET6pSjkQ3OMYxH1/F7FhfmXttPl8QJIji0k1v3VjBZeZfSTinW/BG7qJ8O4E5eNyQVxvC7t1MlL0YBnFbH4eZD0HQDdr5+Y+jsTf2W9LyOdACpM/96PopPA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=imPNKA0H7eYyeIQsMpyGnIIqmigQJ3jDrzkFsH2EPao=;
 b=jJvH7hlXphoMRa3RkgoD7n868B19GPiEygSu/0QUJ2Xa5ddsxjEEvjcplMyiMIvBkSQxUKa3U2WNb7wwhlnVqv9ZWqfybz0SxeBVJWlfs74KGtJEIo/TxfeiybczpNGyDE7WAxrOkBaWvbRkKSrbFCnt0J+WJhivSFHn3HjlHrzs33hMIoIDw/3J9XIWutk6nVL+viLjAvl90i+EXJ3HCoRWcSoyZp0yX9K8+a3D92GUAlJOEJGQ66FYqDLCcNqTdbPsD/Yoc9qyCxaGZOItA/I9WmkGYclSGgvfEOuMsppUUwiA7bX+WQNhmgDnE6O8dluSS7DDAZJK2T2JM+W9mg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=imPNKA0H7eYyeIQsMpyGnIIqmigQJ3jDrzkFsH2EPao=;
 b=kEVIc37F96phUFViCOuJNrFF/1K1GuwA022WH4KZ3V2Uei2snOVK21lNSXG2qwo9JVL/t55l0GZjP6OI7KbhqanL+XwhUogX8OaKh13Ctf+CzHltFYwHW0DPwbgsOK9yJ4XM163rOmeJvCtOMBv2N86fI9adXQJqggQAMQU8pfg=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=pass action=none
 header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 40.67.248.234 as permitted sender) receiver=protection.outlook.com;
 client-ip=40.67.248.234; helo=nebula.arm.com;
From: Penny Zheng <penny.zheng@arm.com>
To: <xen-devel@lists.xenproject.org>, <sstabellini@kernel.org>,
	<julien@xen.org>
CC: <Wei.Chen@arm.com>, <Bertrand.Marquis@arm.com>
Subject: [PATCH v2 4/6] xen/arm: if direct-map domain use native addresses for GICv3
Date: Fri, 15 Oct 2021 03:09:43 +0000
Message-ID: <20211015030945.2082898-5-penny.zheng@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20211015030945.2082898-1-penny.zheng@arm.com>
References: <20211015030945.2082898-1-penny.zheng@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-EOPAttributedMessage: 1
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 1b0e14b7-1853-4a51-c54d-08d98f8957d3
X-MS-TrafficTypeDiagnostic: DBAPR08MB5639:|VE1PR08MB5648:
X-Microsoft-Antispam-PRVS:
	<VE1PR08MB5648A6AC25A09CFFE85B4426F7B99@VE1PR08MB5648.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Oob-TLC-OOBClassifiers: OLM:5516;OLM:5516;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 NDozGu6S7ZOrgIBvkIn1ccJ5NjUg80/i3GDFQso6RUr0/TW4Q2/n2BbVt/B2VSVzCPhUfvXbM6uWblLf2RGwor9kMNZ9DTIPg/2n3zv2+ARPYiiZODLnsdBOlyfTajLhEfbwWIjKSKut1jQdO5O/z6d983Iij85gTSt1R6CoSSFLqQu/NUuxKuNY+OEL/SEoQoq8b8IImXonDPziHtFmNBoFNEnOkLsyO8xhuG/H7QosKhOfwi1ji/1nZEDb2iKFken92G6Nl4G27C75bqokck2idvvsomKbacEO8Zqh1UzCHe8kbSPr1xH0b1yFZff1fe2bDYffu26jYyimEPEKyldBTTRCCRpnsQiuLBE8LQUF1NNWTdk3surLfQL361Bl3SjXhWhrPcfV0+UATalnDCNs7sxv/POM+fbTMwk/U3mhpcXjM+mQ6xCtdh8URP2EffUPkD0IYgmh2Taam9KDGMX2OtMsGlqm3oBh3NJzETUZAFgC5IhJka8fpF4C6Rc/lLPHHB6LMQxAwKgRTqofCqTLP30db3tpYkL1Untz4lD/GDgBjeJMZmHRol0DMQneptVz6UDHflWqJQHwZp/LNwqWnsx/bEDawpVdmQ/mCB142NEQwqRSkdjX1qJcPL0OK9Do6UlxTNRUQHGsli9dZx1uZFDU7motXkAHZIj9CAc2rPaF//WjujlLV+aGcVNdydnpqjW2DpkXIQIxouP74rlFPx3c6CXHpFmhsBGleZo=
X-Forefront-Antispam-Report-Untrusted:
 CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(82310400003)(70586007)(2616005)(44832011)(8676002)(7696005)(508600001)(426003)(356005)(8936002)(70206006)(86362001)(110136005)(54906003)(81166007)(4326008)(47076005)(26005)(186003)(83380400001)(5660300002)(336012)(6666004)(36860700001)(1076003)(36756003)(316002)(2906002)(36900700001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR08MB5639
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT043.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	f97f0dc6-6be6-4887-e2b3-08d98f895270
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	nHl6mVwcN0gSxhu26QdTNBh+UEblMFIQCVEgiB5bv3f7v4NuTkOFuS8piuRPNvpVRDIE42oTtOAyOLZza/AzkePf9AHRK9UTfNtWm0GvSGWjQEJ7+2WnPKzJ2OR3WzuyOa4ge7tw7uObkfrkDblbOoAo4Dhz9EajiaXR7ltO8PkeVn9Dq+VMZ3UMVNqX7yzqll8nXQ3MN3AwaauZnzM4P1x4uxnGMh9GRTW8SLANn8qRIfV0dB9bZ0Nbdd+3ubwyB0fFZeDC2Fjl4+WXR2VnCiYs2FFCBG/QZ6c/mYOXWMuEWXJ2c+aGLp01t2enJAR282OuIqR279QkQyo0Bal1S+bwlSassAvILqsfnj0saZFGVaqccnSU4sJLN222L+f4Z5DOHwmPBi8LeUXkMbqx2Hygp4w6gBJaIT3YXdxlA4hdmMeQNZDpnH7YRU9v9LCN3Fx82Rjkc6ghpjXuXoEVdYFtKvOgqzERaY278ghXBwewySkJCNQWWmrdCgR5Yj7VTo+Dpus0etm/lhX1pvSBw4uFKbnYi+1olilv6s3S+9TQjU2P/P/qbBbN+vpCJuTI++jbfZiBvsQMhpWB9oABWEUK3hIdeArRgcSKJSj6mXcoqQsfYTWCoFafJjTAuNQNdX2UEOu17r0PAdOTTxfVEescQaN0u4xzlOUeTJzKaMUSr+zegw4yZV0rqPm2pvA9PtFAdh93KH8zUOgjpQKv+w==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(47076005)(1076003)(82310400003)(110136005)(54906003)(8676002)(36756003)(86362001)(2906002)(7696005)(83380400001)(4326008)(2616005)(6666004)(508600001)(316002)(36860700001)(44832011)(336012)(70206006)(26005)(5660300002)(426003)(186003)(70586007)(81166007)(8936002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2021 03:10:29.5334
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 1b0e14b7-1853-4a51-c54d-08d98f8957d3
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT043.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5648

From: Stefano Stabellini <stefano.stabellini@xilinx.com>

Today we use native addresses to map the GICv3 for Dom0 and fixed
addresses for DomUs.

This patch changes the behavior so that native addresses are used for
all direct-map domains(including Dom0).

Considering that dom0 may not always be directly mapped in the future,
this patch introduces a new helper "is_domain_use_host_layout()" that
wraps both two check "is_domain_direct_mapped(d) || is_hardware_domain(d)"
for more flexible useage.

Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>
Signed-off-by: Penny Zheng <penny.zheng@arm.com>
---
 xen/arch/arm/domain_build.c  | 46 +++++++++++++++++++++++++++---------
 xen/arch/arm/vgic-v3.c       | 20 +++++++++-------
 xen/include/asm-arm/domain.h |  3 +++
 3 files changed, 50 insertions(+), 19 deletions(-)

diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
index 6cd03e4d0f..7e0ee07e06 100644
--- a/xen/arch/arm/domain_build.c
+++ b/xen/arch/arm/domain_build.c
@@ -2255,16 +2255,20 @@ static int __init make_gicv2_domU_node(struct kernel_info *kinfo)
     return res;
 }
 
+#ifdef CONFIG_ARM_64
 static int __init make_gicv3_domU_node(struct kernel_info *kinfo)
 {
     void *fdt = kinfo->fdt;
     int res = 0;
-    __be32 reg[(GUEST_ROOT_ADDRESS_CELLS + GUEST_ROOT_SIZE_CELLS) * 2];
+    __be32 *reg;
     __be32 *cells;
+    struct domain *d = kinfo->d;
+    char buf[38];
+    unsigned int i, len = 0;
 
-    res = fdt_begin_node(fdt, "interrupt-controller@"__stringify(GUEST_GICV3_GICD_BASE));
-    if ( res )
-        return res;
+    snprintf(buf, sizeof(buf), "interrupt-controller@%"PRIx64,
+             vgic_dist_base(&d->arch.vgic));
+    res = fdt_begin_node(fdt, buf);
 
     res = fdt_property_cell(fdt, "#address-cells", 0);
     if ( res )
@@ -2282,35 +2286,55 @@ static int __init make_gicv3_domU_node(struct kernel_info *kinfo)
     if ( res )
         return res;
 
+    /* reg specifies all re-distributors and Distributor. */
+    len = (GUEST_ROOT_ADDRESS_CELLS + GUEST_ROOT_SIZE_CELLS) *
+          (d->arch.vgic.nr_regions + 1) * sizeof(__be32);
+    reg = xmalloc_bytes(len);
+    if ( reg == NULL )
+        return -ENOMEM;
+
     cells = &reg[0];
     dt_child_set_range(&cells, GUEST_ROOT_ADDRESS_CELLS, GUEST_ROOT_SIZE_CELLS,
-                       GUEST_GICV3_GICD_BASE, GUEST_GICV3_GICD_SIZE);
-    dt_child_set_range(&cells, GUEST_ROOT_ADDRESS_CELLS, GUEST_ROOT_SIZE_CELLS,
-                       GUEST_GICV3_GICR0_BASE, GUEST_GICV3_GICR0_SIZE);
+                       vgic_dist_base(&d->arch.vgic), GUEST_GICV3_GICD_SIZE);
 
-    res = fdt_property(fdt, "reg", reg, sizeof(reg));
+    for ( i = 0;
+          i < d->arch.vgic.nr_regions;
+          i++, cells += (GUEST_ROOT_ADDRESS_CELLS + GUEST_ROOT_SIZE_CELLS) )
+    {
+        dt_child_set_range(&cells,
+                           GUEST_ROOT_ADDRESS_CELLS, GUEST_ROOT_SIZE_CELLS,
+                           d->arch.vgic.rdist_regions[i].base,
+                           d->arch.vgic.rdist_regions[i].size);
+    }
+
+    res = fdt_property(fdt, "reg", reg, len);
     if (res)
-        return res;
+        goto out;
 
     res = fdt_property_cell(fdt, "linux,phandle", kinfo->phandle_gic);
     if (res)
-        return res;
+        goto out;
 
     res = fdt_property_cell(fdt, "phandle", kinfo->phandle_gic);
     if (res)
-        return res;
+        goto out;
 
     res = fdt_end_node(fdt);
 
+ out:
+    xfree(reg);
     return res;
 }
+#endif
 
 static int __init make_gic_domU_node(struct kernel_info *kinfo)
 {
     switch ( kinfo->d->arch.vgic.version )
     {
+#ifdef CONFIG_ARM_64
     case GIC_V3:
         return make_gicv3_domU_node(kinfo);
+#endif
     case GIC_V2:
         return make_gicv2_domU_node(kinfo);
     default:
diff --git a/xen/arch/arm/vgic-v3.c b/xen/arch/arm/vgic-v3.c
index cb5a70c42e..70168ca1ac 100644
--- a/xen/arch/arm/vgic-v3.c
+++ b/xen/arch/arm/vgic-v3.c
@@ -1641,14 +1641,15 @@ static inline unsigned int vgic_v3_max_rdist_count(struct domain *d)
      * Normally there is only one GICv3 redistributor region.
      * The GICv3 DT binding provisions for multiple regions, since there are
      * platforms out there which need those (multi-socket systems).
-     * For Dom0 we have to live with the MMIO layout the hardware provides,
-     * so we have to copy the multiple regions - as the first region may not
-     * provide enough space to hold all redistributors we need.
+     * For direct-map domain(including dom0), we have to live with the MMIO
+     * layout the hardware provides, so we have to copy the multiple regions
+     * - as the first region may not provide enough space to hold all
+     * redistributors we need.
      * However DomU get a constructed memory map, so we can go with
      * the architected single redistributor region.
      */
-    return is_hardware_domain(d) ? vgic_v3_hw.nr_rdist_regions :
-               GUEST_GICV3_RDIST_REGIONS;
+    return is_domain_use_host_layout(d) ? vgic_v3_hw.nr_rdist_regions :
+                                          GUEST_GICV3_RDIST_REGIONS;
 }
 
 static int vgic_v3_domain_init(struct domain *d)
@@ -1670,10 +1671,13 @@ static int vgic_v3_domain_init(struct domain *d)
     radix_tree_init(&d->arch.vgic.pend_lpi_tree);
 
     /*
-     * Domain 0 gets the hardware address.
-     * Guests get the virtual platform layout.
+     * Since we map the whole GICv3 register memory map(64KB) for
+     * all guests(including DOM0), DOM0 and direct-map guests could be
+     * treated the same way here.
+     * direct-map domain (including Dom0) gets the hardware address.
+     * Other guests get the virtual platform layout.
      */
-    if ( is_hardware_domain(d) )
+    if ( is_domain_use_host_layout(d) )
     {
         unsigned int first_cpu = 0;
 
diff --git a/xen/include/asm-arm/domain.h b/xen/include/asm-arm/domain.h
index fc42c6a310..e8ce3ac8d2 100644
--- a/xen/include/asm-arm/domain.h
+++ b/xen/include/asm-arm/domain.h
@@ -32,6 +32,9 @@ enum domain_type {
 /* Check if domain is direct-map memory map. */
 #define is_domain_direct_mapped(d) (d->options & XEN_DOMCTL_CDF_directmap)
 
+#define is_domain_use_host_layout(d) (is_domain_direct_mapped(d) || \
+                                      is_hardware_domain(d))
+
 struct vtimer {
     struct vcpu *v;
     int irq;
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Fri Oct 15 04:15:37 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 04:15:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.209568.366270 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbEcr-0004LI-B7; Fri, 15 Oct 2021 04:15:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 209568.366270; Fri, 15 Oct 2021 04:15:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbEcr-0004LB-7d; Fri, 15 Oct 2021 04:15:21 +0000
Received: by outflank-mailman (input) for mailman id 209568;
 Thu, 14 Oct 2021 18:37:06 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=awOS=PC=wanadoo.fr=christophe.jaillet@srs-us1.protection.inumbo.net>)
 id 1mb5bG-0000vF-CY
 for xen-devel@lists.xenproject.org; Thu, 14 Oct 2021 18:37:06 +0000
Received: from smtp.smtpout.orange.fr (unknown [80.12.242.124])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 360ae674-1aab-47f9-a5d9-c8b0b5d976cd;
 Thu, 14 Oct 2021 18:37:05 +0000 (UTC)
Received: from pop-os.home ([92.140.161.106]) by smtp.orange.fr with ESMTPA
 id b5bCmBF2MBazob5bDmY8O8; Thu, 14 Oct 2021 20:37:04 +0200
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 360ae674-1aab-47f9-a5d9-c8b0b5d976cd
X-ME-Helo: pop-os.home
X-ME-Auth: YWZlNiIxYWMyZDliZWIzOTcwYTEyYzlhMmU3ZiQ1M2U2MzfzZDfyZTMxZTBkMTYyNDBjNDJlZmQ3ZQ==
X-ME-Date: Thu, 14 Oct 2021 20:37:04 +0200
X-ME-IP: 92.140.161.106
From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
To: boris.ostrovsky@oracle.com,
	jgross@suse.com,
	sstabellini@kernel.org
Cc: xen-devel@lists.xenproject.org,
	linux-kernel@vger.kernel.org,
	kernel-janitors@vger.kernel.org,
	Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Subject: [PATCH] xen/pvcalls-back: Remove redundant 'flush_workqueue()' calls
Date: Thu, 14 Oct 2021 20:37:01 +0200
Message-Id: <2d6c2e031e4aa2acf2ac4e0bbbc17cfdcc8dbee2.1634236560.git.christophe.jaillet@wanadoo.fr>
X-Mailer: git-send-email 2.30.2
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

'destroy_workqueue()' already drains the queue before destroying it, so
there is no need to flush it explicitly.

Remove the redundant 'flush_workqueue()' calls.

This was generated with coccinelle:

@@
expression E;
@@
- 	flush_workqueue(E);
	destroy_workqueue(E);

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
 drivers/xen/pvcalls-back.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/xen/pvcalls-back.c b/drivers/xen/pvcalls-back.c
index b47fd8435061..d6f945fd4147 100644
--- a/drivers/xen/pvcalls-back.c
+++ b/drivers/xen/pvcalls-back.c
@@ -465,7 +465,6 @@ static int pvcalls_back_release_passive(struct xenbus_device *dev,
 		write_unlock_bh(&mappass->sock->sk->sk_callback_lock);
 	}
 	sock_release(mappass->sock);
-	flush_workqueue(mappass->wq);
 	destroy_workqueue(mappass->wq);
 	kfree(mappass);
 
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Fri Oct 15 05:55:06 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 05:55:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.209745.366280 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbGB8-0005Q1-Gl; Fri, 15 Oct 2021 05:54:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 209745.366280; Fri, 15 Oct 2021 05:54:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbGB8-0005Pu-DP; Fri, 15 Oct 2021 05:54:50 +0000
Received: by outflank-mailman (input) for mailman id 209745;
 Fri, 15 Oct 2021 05:54:49 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mbGB7-0005Pk-DC; Fri, 15 Oct 2021 05:54:49 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mbGB7-0004Lw-2U; Fri, 15 Oct 2021 05:54:49 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mbGB6-00076A-Nh; Fri, 15 Oct 2021 05:54:48 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mbGB6-00068d-ML; Fri, 15 Oct 2021 05:54:48 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=AIbY5iO7o6RLOoCjzOKUW7bYN/oJrpUc1X+PKKbxPO4=; b=txkgqA9CCnMyekV7t5KbZfZh/B
	69eZSiXzHAiCM9aeZ5/+UeeI1k9W+NIoYqfecxxr119boBDeOBpUxRZntCoFcKUcZA6TqJ/6qn1B8
	vHpf/XiqsfenzzMZrPbS9XhG63C3+XeRl4N2TfRHUE4Q9nRto6VsudeiztPqVKt3f7Dg=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165510-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 165510: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:guest-start/debianhvm.repeat:fail:heisenbug
    linux-linus:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:allowable
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=26d6574109838b8fa40a8261421693015bab0579
X-Osstest-Versions-That:
    linux=348949d9a4440abdab3b1dc99a9bb660e8c7da7c
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 15 Oct 2021 05:54:48 +0000

flight 165510 linux-linus real [real]
flight 165517 linux-linus real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/165510/
http://logs.test-lab.xenproject.org/osstest/logs/165517/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 20 guest-start/debianhvm.repeat fail pass in 165517-retest

Regressions which are regarded as allowable (not blocking):
 test-amd64-amd64-xl-rtds     20 guest-localmigrate/x10   fail REGR. vs. 165497

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 165497
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 165497
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165497
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165497
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 165497
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165497
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 165497
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 165497
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 linux                26d6574109838b8fa40a8261421693015bab0579
baseline version:
 linux                348949d9a4440abdab3b1dc99a9bb660e8c7da7c

Last test of basis   165497  2021-10-13 15:09:28 Z    1 days
Testing same since   165510  2021-10-14 14:42:03 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Cameron Berkenpas <cam@neo-zeon.de>
  Chris Chiu <chris.chiu@canonical.com>
  Dinh Nguyen <dinguyen@kernel.org>
  Hui Wang <hui.wang@canonical.com>
  John Liu <johnliu55tw@gmail.com>
  Jonas Hahnfeld <hahnjo@hahnjo.de>
  Kai Vehmanen <kai.vehmanen@linux.intel.com>
  Kai-Heng Feng <kai.heng.feng@canonical.com>
  Kailang Yang <kailang@realtek.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Takashi Iwai <tiwai@suse.de>
  Werner Sembach <wse@tuxedocomputers.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 fail    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     fail    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   348949d9a444..26d657410983  26d6574109838b8fa40a8261421693015bab0579 -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Fri Oct 15 06:05:10 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 06:05:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.209754.366295 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbGL3-0006xm-GY; Fri, 15 Oct 2021 06:05:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 209754.366295; Fri, 15 Oct 2021 06:05:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbGL3-0006xf-DI; Fri, 15 Oct 2021 06:05:05 +0000
Received: by outflank-mailman (input) for mailman id 209754;
 Fri, 15 Oct 2021 06:05:03 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=FGCa=PD=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mbGL1-0006xZ-JM
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 06:05:03 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id d7430c45-b872-4972-a42b-331609279f76;
 Fri, 15 Oct 2021 06:05:02 +0000 (UTC)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2172.outbound.protection.outlook.com [104.47.17.172])
 (Using TLS) by relay.mimecast.com with ESMTP id
 de-mta-12-Wom85rs_O6-lp0sPlJ3euw-1; Fri, 15 Oct 2021 08:05:00 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0402MB3935.eurprd04.prod.outlook.com (2603:10a6:803:1f::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16; Fri, 15 Oct
 2021 06:04:59 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.017; Fri, 15 Oct 2021
 06:04:58 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS9PR06CA0349.eurprd06.prod.outlook.com (2603:10a6:20b:466::24) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15 via Frontend
 Transport; Fri, 15 Oct 2021 06:04:57 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d7430c45-b872-4972-a42b-331609279f76
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634277901;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=BnKhTDzgIutueOxd2mLKdRAqxYiNLRUN8boDLvtgmbg=;
	b=cdAoctuHRoAu3XXPbbGgnbc0d4neEJX65i+sWmnkvaO89T0LiNPV60PZQ0wlYLEgYbQam1
	DY3xJYqNlgfmtJgMeddJOeGvB13/P4tf1/P1RwjMt31ug7yPFofdHeXkUkNLkKIC3rDHwR
	Te2QgNr+edzSpdvZecKXL1FcXdOUZuU=
X-MC-Unique: Wom85rs_O6-lp0sPlJ3euw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Jm86GlhG3iHfcYNeIDPek9SyntzxFLe5IMS/NsUOoY09n1VM5yz6b0ArOykCI0DHKB4oPyLyW6tTeMzMO5hN+qKLIeEsZL0uehwb/aoepWs7RWBPv4hX1MKgn5DsMEhwlDpEHJ3Al/Xt6bdHvAAypOrXNa1DvlKxFhfN2B4qzEjWqZprTl2DoWfru7aoguoR/kl2M0A4zImbjl1HD+u0xN0KvNHWr0+8zl2Z1GDrJfw+C7qhsj886D5bsbfG3414r3rk153YyiPLX/7UjdFVW8cq2VMMxraswqV5QifdiJOoRMVAOviSYkzbGXucNk3AdbZPfHHoR6+XkVnHDUmeKQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=OLRHXPXXr566Gt+/J//2Bwutf5X9i5kKPwveis5k6dQ=;
 b=MW/1ldwaX9J8Wa3TuRAPLYpYeXPreAcbk0g8HoJCCNLhKc6PY1Uh4Uz+IuM46fDnutXTAygopp1+0mn5tvlQQhVLJZ9SO2pHeYmN68QrfpMtPXdOXRreLlZwba4VWjFOsG7BAwyR35jZ4ZJKjYF/3QyPoJk1ABvGhheUcpL7xH/6U+D36lDb7JjpvP/ybHq/h+Soknfg76jVAHLvHSrfw4PYTsaAY9u+RNDW0yoTFo11V/OQmhK6lVBSDT5y1j86ziJhudhjXXw19I1KqLI7Gpthw9vpHIcKC5oHwvTnZtS+pkIemCGSFc1pyaADL2w3jWpfiYTPzb/hvdwuXL+b/w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: gmail.com; dkim=none (message not signed)
 header.d=none;gmail.com; dmarc=none action=none header.from=suse.com;
Subject: Re: [PATCH v3 03/11] vpci/header: Move register assignments from
 init_bars
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: xen-devel@lists.xenproject.org, julien@xen.org, sstabellini@kernel.org,
 oleksandr_tyshchenko@epam.com, volodymyr_babchuk@epam.com,
 Artem_Mygaiev@epam.com, bertrand.marquis@arm.com, rahul.singh@arm.com,
 Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>,
 Oleksandr Andrushchenko <andr2000@gmail.com>
References: <20210930075223.860329-1-andr2000@gmail.com>
 <20210930075223.860329-4-andr2000@gmail.com>
 <YWbkZ216FbV8lBns@MacBook-Air-de-Roger.local>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <01ce921f-cbc1-9524-0edd-47665b5db82c@suse.com>
Date: Fri, 15 Oct 2021 08:04:56 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <YWbkZ216FbV8lBns@MacBook-Air-de-Roger.local>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS9PR06CA0349.eurprd06.prod.outlook.com
 (2603:10a6:20b:466::24) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: cea6cbf8-1659-4b2a-9b54-08d98fa1b7ca
X-MS-TrafficTypeDiagnostic: VI1PR0402MB3935:
X-Microsoft-Antispam-PRVS:
	<VI1PR0402MB39357995E7D3F332732FB8D4B3B99@VI1PR0402MB3935.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7691;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	zw/QvkblnkHQJlDUTBQ219/EHMfhm8jaVyKkLVmGuJ77VlfoRZKc/CqADH2YKSo17J9tiSkGI584jlth1wQE1JyNV3moe4DuGQ1bvD23YeJt/uUA0ODHFGHas/pTsi34pV7FRJF8qUIWwoWo5nFMhcy4jvqBYxvUoi7Fc4rIOek5JeSluQg8zVh677NkIC4Brk9w6dHucudgySVomid7DbfhbRBVJGz8cbrlQPI4lKTbpc/sts9mPmNpUsfhXSjpkTvlyYkSZIRemww8MMLWk1+DtBZXgd5tVEf1ttVfZUsEU+SOF1oLt+1+2hcAi/LQK11hNFHxxJ+WihEIJXlkVJrcnbE3HkPak5hI3TiZkBEZag1wag+P26jFP41GJu5/UlNEL3SR7ZKvZdAVsDTlLBrPlPsHG0oOUlzdMEmiaUxmkQUoQOgrVGBltq5HDDTUUDBMfxd8sXMlJjXQNhSS6iZXRZER811kMUFfO2bdzfrz5odGppgyaxMIRXMBF/rn9Ofjcoeh/J0d58rBXMxucwY60hd29qz1L0aup6lC6w8OqX7gDIq4QQp2lsORX7Dd+yMM217mH7p8kP6XNcn5Q2Go+SY9HbL/KcviwelgEnCiBmbHjsbhv1G0JYHk/wSkqEXsvX1vyXW7z9+eh7gv3qtj7s8+meCNBguxwZmIBW1uN25bjaGEATQVO6QKZ1BErIL0WH7rIZjty7ccnn9tLn+ZGxsUp3WB9Z5bmduoWR4=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(26005)(16576012)(316002)(54906003)(6916009)(7416002)(31696002)(4326008)(6486002)(2906002)(4744005)(508600001)(86362001)(5660300002)(186003)(956004)(8676002)(38100700002)(66946007)(66556008)(66476007)(8936002)(36756003)(2616005)(53546011)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?hfy2RG1BWj9ezOUPjza7hdlLau3wO7xzYJJkx4/CZwX3zZC971BqKgV17vs9?=
 =?us-ascii?Q?M8RKK7HR+SbElYaf7Wt8Yr8pbGsDCB+HhG6BgkW4hUPqm/3Xpv2Ht7zd6h3m?=
 =?us-ascii?Q?CXZzSOhulsk9UHFpbzyliE5/tkVVru4BC789/f9/QIvmm5py8Qvcxi6ioBRs?=
 =?us-ascii?Q?awO1IVDGLRIP4VChnqvS8l9aIaTSalxfqfv7cPSoqUEkzUEnX0eF9GjTZnDT?=
 =?us-ascii?Q?fdoiKaLi9rQk+q7ynjczjnfs0GOW/alEIFedYvqJwUsy9lRuAAHFOwGB6HSF?=
 =?us-ascii?Q?GWPGBPW9iaxlNxq3Kx6cpJKN0Ug4t3yFRbGKygQfnzLEtUAhBF0tundYloJb?=
 =?us-ascii?Q?e6nnobjd/CwA/YQ5DP2EXo1xiF5paLodXr1DysCYUfBPm8XqIt7MSsdmzo/n?=
 =?us-ascii?Q?FpWFZY6JWYX98vlhpsREb/5N/2AtP4eqBVnZkmfTS1NElAniY/Y5HHDX6kzx?=
 =?us-ascii?Q?NakkSycBKtDuZP2sW1eugbS9+epknzlSOooCNaUYggeRlDBCouTJwbBw5g8m?=
 =?us-ascii?Q?sG799Uikl3MJCDi3j6l56qIzx++9in1B+MOxGL5W945zD1Jhdxp6kgifwsaw?=
 =?us-ascii?Q?29xsQFz+23NO3n7DsE9BnMT/+Y/V0GwL0G0kapGO3IRy9otLFwNdBbOTCKD2?=
 =?us-ascii?Q?X4BM0AR6V0Prt9Yziv6hlCiGz1tdf8yPTCME4kVzo5UAzw4BuGR+csCPRudH?=
 =?us-ascii?Q?oSVE672g9bain6+kW5TSGYpcLTOMSsK2mAsd3NLWHvDO4t7C0NQHBrIkQ9Oq?=
 =?us-ascii?Q?y/itiZ4VfK9PN/LqBAhtKhW9SKGERHqdyMkW3d/SDqRp2uqQGfAbGDE/kFo2?=
 =?us-ascii?Q?Ws8qtMzKFIYplg+q2RBXKDEMImOoFFZzdNsxnPv4Uje6UW80CI/5fIwXEur5?=
 =?us-ascii?Q?OMto7YB0SN0Y5jowiyCE9VFg49KAwmPN2wDhtOqWPY3lIOFy429upNlfjPjy?=
 =?us-ascii?Q?wCmOhvmmH640QFjoaexocYfJiLvHC1D9VmYe8nij502T9Gn4OxlDkxXe3vi4?=
 =?us-ascii?Q?mSRjP4bjAwbReHQviR2npmnb1jYTH8agIObZPGUQjeJ/14xzH9iLFhVhVyhF?=
 =?us-ascii?Q?uA7803pMEC+v52reQ95RSWdN8VFY818MS0d8QjyozK9AOiI9MR36p/+3rrxS?=
 =?us-ascii?Q?BEyo+STMixSGpM/aErPwM86Wfitd1BHnXbmWH6cr/y4wK65nizPv7A1Wqojl?=
 =?us-ascii?Q?4FS3C15UTdDbQ+xXou7FI0oKssawUyIe4ZxLcG3nAFy/Jh++HkmgM9gyGWUw?=
 =?us-ascii?Q?N0oiby+TKai/u5BhRB4v2ghK6g9PouTEZ5Lq/MElYAUS/xmnv41roi4yroue?=
 =?us-ascii?Q?oIOUddaLSadcI9e6h0SmQ5zb?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cea6cbf8-1659-4b2a-9b54-08d98fa1b7ca
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2021 06:04:58.8569
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: GPNME5KqISYS5nrZNY2snJpa9RbnMQzFi0KOMC5BIuvvWemHgPwohE/w7r9J2KARGVrjvu2h3+NRWiKZwmedhA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3935

On 13.10.2021 15:51, Roger Pau Monn=C3=A9 wrote:
> On Thu, Sep 30, 2021 at 10:52:15AM +0300, Oleksandr Andrushchenko wrote:
>> --- a/xen/drivers/vpci/header.c
>> +++ b/xen/drivers/vpci/header.c
>> @@ -445,6 +445,55 @@ static void rom_write(const struct pci_dev *pdev, u=
nsigned int reg,
>>          rom->addr =3D val & PCI_ROM_ADDRESS_MASK;
>>  }
>> =20
>> +static int add_bar_handlers(const struct pci_dev *pdev)
>=20
> Making this const is again misleading IMO, as you end up modifying
> fields inside the pdev, you get away with it because vpci data is
> stored in a pointer.

I think it was me who asked for const to be added in places like this
one. vpci data hanging off of struct pci_dev is an implementation
artifact imo, not an unavoidable connection. In principle the vpci
data corresponding to a physical device could also be looked up using
e.g. SBDF.

Here the intention really is to leave the physical device unchanged;
that's what the const documents (apart from enforcing).

Jan



From xen-devel-bounces@lists.xenproject.org Fri Oct 15 06:09:24 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 06:09:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.209763.366306 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbGPD-0007g7-4P; Fri, 15 Oct 2021 06:09:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 209763.366306; Fri, 15 Oct 2021 06:09:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbGPD-0007g0-1V; Fri, 15 Oct 2021 06:09:23 +0000
Received: by outflank-mailman (input) for mailman id 209763;
 Fri, 15 Oct 2021 06:09:22 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=FGCa=PD=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mbGPC-0007fu-7d
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 06:09:22 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 6fc463ce-2d7e-11ec-8226-12813bfff9fa;
 Fri, 15 Oct 2021 06:09:21 +0000 (UTC)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2112.outbound.protection.outlook.com [104.47.17.112])
 (Using TLS) by relay.mimecast.com with ESMTP id
 de-mta-7-Dzg7oErtPMWryuWbAPwlAA-1; Fri, 15 Oct 2021 08:09:19 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0402MB3390.eurprd04.prod.outlook.com (2603:10a6:803:9::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.17; Fri, 15 Oct
 2021 06:09:17 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.017; Fri, 15 Oct 2021
 06:09:17 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6P195CA0031.EURP195.PROD.OUTLOOK.COM (2603:10a6:209:81::44) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.15 via Frontend Transport; Fri, 15 Oct 2021 06:09:16 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6fc463ce-2d7e-11ec-8226-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634278160;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=nPUb9jvRPqyK0S5YoaKCobbSkiq3DPaI+B+6lX+vndY=;
	b=MSGm2xokQtus+Ra2s5siOOsKtw+qSwyiTh+iiM39InguI8HQsLbUwb1/HyLIgI4goii84s
	vpX9LTYXKrsgWpModNLxam5z7Z5vxr4/HLdXs+Z6cBQ0jkNlB4+LF6q3PA/fe2K/5T96lP
	R2Sk0CgBdQyZa8XyFzggVIuaetLyhvU=
X-MC-Unique: Dzg7oErtPMWryuWbAPwlAA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=dZSOaAIhthL/isJkV3fiZbK8AAbxdXwkiZKJsu2ZxbVn2Znj/BzTwP3hA+PV/WEeCcBZn5jQTAUqRWi5lLRshBzFw0+otsXG85OopJeruXNn3/z+s/8PCuloQv9vnb1hE3FOa9g0Glnrdri4TjNiO63QHCeAC1DTJ0k5FrRPAbr7I5Xq5ZU4Spbd2ZzJ4nj6TcS4BSl3PSgVXxp3CnIBSIaLAa7e+DxWL0LHABZWV26XYU2yf9uat8Q9nGD2zJKI+2tdhJSdtBa6aRgM1WNFAhLEM0DyvuMNX6OeDt+o+xQ53lhULR3kIeC38K2ALWJEaq5VpWpvRQN4HRhl0uVVOQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=P81iuYHAEvwo4SeNKa2gGDWhOgyHbGZ7OWd73gL/9yE=;
 b=Fxa9QeOnfIW/Q3Ze1+Xah9jhH1LuBbeFz3e5QHDebT8FIqNRDVkgDJ4aVD13mMOkTtziDEk7SPVu0T3T8JF0UInbPDqXx8JvE9YOcOhI+h6eP4Nu4qJ1LHgb15nu1yAPg2D9ffYDsMjVJqCV7iFopObq9YktT9NspjANgvo1rxa/48aZ7mngOlIeLvFwZgU/MI6zdhmp6HaICrnPNK3dtzP5Z/fKc8b3SrFnjMtETeE1mXaRcbh7ACQq8NyPCQXM1lYr10S3xFYNsb10eQNgbui3nJAajVENNSJhk18aSvj0TRpUpkfcDdDkchJhDTw1Jvhja8McznYDX8dMaElE1w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [PATCH v3 04/11] vpci/header: Add and remove register handlers
 dynamically
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>,
 "julien@xen.org" <julien@xen.org>,
 "sstabellini@kernel.org" <sstabellini@kernel.org>,
 Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Artem Mygaiev <Artem_Mygaiev@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Rahul Singh <rahul.singh@arm.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <20210930075223.860329-1-andr2000@gmail.com>
 <20210930075223.860329-5-andr2000@gmail.com>
 <2b575750-83a5-588e-fd6b-dd9cdb9500dd@suse.com>
 <e3730616-c51f-c453-3f74-584473313e54@epam.com>
 <672f00b2-3065-34f1-3dda-430edd8eb463@suse.com>
 <YWb9kgON0krr5lp9@MacBook-Air-de-Roger.local>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <d1cd62ed-2cf1-5a66-e0cf-af30326e3730@suse.com>
Date: Fri, 15 Oct 2021 08:09:14 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <YWb9kgON0krr5lp9@MacBook-Air-de-Roger.local>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6P195CA0031.EURP195.PROD.OUTLOOK.COM
 (2603:10a6:209:81::44) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 38a2ad87-e2ec-4cfd-b874-08d98fa251d3
X-MS-TrafficTypeDiagnostic: VI1PR0402MB3390:
X-Microsoft-Antispam-PRVS:
	<VI1PR0402MB33906DB19482A50210F9D393B3B99@VI1PR0402MB3390.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7691;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	9gKkwqSxoj0o1fryZkIBrUV8+wGNtEp8EeKqKJAI+C7hnMtukI9FrT+au1UG84420xRnBLKPQfZm0MHW5A3cN56CF5pKHkXm9DOI0t84yleJkn8DqthvX8fgv3whUExyAyqceCr5khI22YuQrNikw5efv6v9zM63SDfz+3QobBypi9l7gppdBGHrxIx7FgZ/4gcmgbsHQKcVuj/dmvWzAWp2v1oDyKTRea7u5QZHlJNyyuPYLFqxMwgjhwW9jB9eaJ/Heurgfbp8rzewWoVr/WwyIS/wuHA8EpsCNmeRMD3G/wbXIiJKni/DZf7vtNjKUxFRadjC/nKwDcwzqebcPR98L0XVtDOd4Lv/1VgnsftHwKBK/B/UlqLBjg1I+1In7W3WyjzwkPvv9rB6eSd5Dd+Ye3fP/+iRnqu8Gl0ylZHjY5xCeZJ3uIdo3LkGNNt51H5Vs4jNWNOG13fw+7YIP6Bl54S+xB3XKGB9rCsjR9W5FZJimGcZaPsmTZebJcrUGxxuhdpWzoCjfYLPP+b5eoSvJeV1bjx8cPnKLYiH5g1iIgXpMX2TyxiVK3uFGqmd/cYhH/atEG3YzMZD6R4hOcFTrA2MrvaZYI6gJZIlf/AFsg3yJh5j+JaQ+LnUsXBb67F4kOKt0PX89bNeqMd7YTvYh1CoaBeQilnUO4/3a6wFmm8lbXZ8yz0a7aOZuUuEMLRF3iIq4P52EMOcrsQDHHJ8tzwKMXbwtEDfq8TkcDP2+LsuqM5AQSI5u/OGaYoE
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(2906002)(66556008)(66476007)(956004)(2616005)(66946007)(38100700002)(31686004)(5660300002)(7416002)(31696002)(6486002)(53546011)(54906003)(8936002)(86362001)(16576012)(36756003)(6916009)(508600001)(316002)(83380400001)(186003)(8676002)(4326008)(26005)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?pMn9aJhzfKct3DIe+n5m7vug+0O/2wAC+fbsaiAS3pARe0QSGvo/dxbbheWF?=
 =?us-ascii?Q?j4Lmm79TlZm5WH9asSbXYKQRJmb9Xe4s/TR0lbM9TZrjIDBWImgRYYxCv8uQ?=
 =?us-ascii?Q?1C3evCWxkcSYpE43z0tGBrlsk797T6Litrbo3gWD7s3Nq74geqABhMKkizp1?=
 =?us-ascii?Q?vvnTKNr5QygECWsYpuTd2jjsPyWaevDwj85cIQcgDGaNgIBo7Nh/0cgv0rTv?=
 =?us-ascii?Q?qSwWmzvscWrCrr1RPiPaErAQqqWcgCYl/thgh+gwVPGRJUBgkoE0TFMA+fSn?=
 =?us-ascii?Q?1GGttPXSq+F5KOgu8TdpdH1+Jj3mmvgZNeQYZyCuKNLLWrNmCgXDPbT8vQGy?=
 =?us-ascii?Q?GuOydfgXuUzT3ONLZspF5C83vRKbN5GOEmDMr49c1kFLVcMZHDWVYwCmauKS?=
 =?us-ascii?Q?FY++ZXz/BVxDzsxcz2Dicv3NO0EBTvuW7v2tDbEngsn4sKLaSwN4y1N+2k8K?=
 =?us-ascii?Q?j98Av2sTVzyOaeriNtJSzc0CRcJ7gml9LJrmjI4v6Tgm/g1mi6+hKjS2XUcT?=
 =?us-ascii?Q?I7y9d8ZvQKJFgIhYyrSxgCPCR17hc9sQccZBgrg8MJNPlvBpWwnUifpkbn3I?=
 =?us-ascii?Q?96YA7XbnhhIKiFrSCvHTjn0k4jbCD8g0b17kvD9Av5WhTVKgHXf0OBhYqSA7?=
 =?us-ascii?Q?KP2SZ60G5H3WSjYVDSy/tEJR3wDmkstNfe2q2esPiZPQXER7gU+QYr9qIB08?=
 =?us-ascii?Q?entyYUW0rmX5ifMw6u7ZJ/t04qKhKfk47r9Y6H1Zq6sRlwINgXPZFiBJq0y7?=
 =?us-ascii?Q?rvdtv7aAeyIwPn7yV/vx0TVitIosmopDEhBUgGB+qXLDwGQYb1U5jQEV4Ppt?=
 =?us-ascii?Q?d5QnuRzriNZM6VXN6GgbDSuvXNOqy44XbL9hq64PGhstE1SAAzT1/llYwxsl?=
 =?us-ascii?Q?drYRD4lfKf5v1sQ8bRbl+hI7PRpEDLov3E/3FPgWzCiLcegGEagnRrlG2qBv?=
 =?us-ascii?Q?IQldG1uWABuSZWDlVdDgu/Z74KK38GHMypOhHllBKSAD94bkQdjvsCjlxks8?=
 =?us-ascii?Q?PYvMLzoysV/ySHzi4jCO3N22IKlOdzWm9wCaAoTLMjKLjRtLvgNYfLsILrqO?=
 =?us-ascii?Q?0JaUSm11BRGM6jXQ83XOsspiJEgmzF5iqgu1Urrka3HPUB8yPXAF6aYgQ8Rb?=
 =?us-ascii?Q?nz3tvULpNPsLLrLFW+DA5T5OP74VDiwlTkjzzXV3uelj1cAOT8RE43dN5VWG?=
 =?us-ascii?Q?a91vjLteYmXxYJeIETfTpKIpSZT0b4yWTW2w6WrRbqulTX7lr1wC/oym92pY?=
 =?us-ascii?Q?dCFae24dnBAaEhCv3kmhz3aaopaYuiwvGtUZpeJVFXwDMmM5TufwlXca7Bpw?=
 =?us-ascii?Q?91ETgIrkP3JDZfsiEfqX1uba?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 38a2ad87-e2ec-4cfd-b874-08d98fa251d3
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2021 06:09:17.1278
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ahrWBidMjn0TcYp3wHUqqdoWfBTcsA6Tv+PZHOxcphX6feNyMpC4Kk/tBlzcgNRCosGCOKBT2dB1/5IrcilIzQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3390

On 13.10.2021 17:38, Roger Pau Monn=C3=A9 wrote:
> On Thu, Oct 07, 2021 at 09:22:36AM +0200, Jan Beulich wrote:
>> On 04.10.2021 07:58, Oleksandr Andrushchenko wrote:
>>>
>>>
>>> On 01.10.21 16:26, Jan Beulich wrote:
>>>> On 30.09.2021 09:52, Oleksandr Andrushchenko wrote:
>>>>> @@ -445,14 +456,25 @@ static void rom_write(const struct pci_dev *pde=
v, unsigned int reg,
>>>>>           rom->addr =3D val & PCI_ROM_ADDRESS_MASK;
>>>>>   }
>>>>>  =20
>>>>> -static int add_bar_handlers(const struct pci_dev *pdev)
>>>>> +static void guest_rom_write(const struct pci_dev *pdev, unsigned int=
 reg,
>>>>> +                            uint32_t val, void *data)
>>>>> +{
>>>>> +}
>>>>> +
>>>>> +static uint32_t guest_rom_read(const struct pci_dev *pdev, unsigned =
int reg,
>>>>> +                               void *data)
>>>>> +{
>>>>> +    return 0xffffffff;
>>>>> +}
>>>>> +
>>>>> +static int add_bar_handlers(const struct pci_dev *pdev, bool is_hwdo=
m)
>>>> I remain unconvinced that this boolean is the best way to go here,
>>> I can remove "bool is_hwdom" and have the checks like:
>>>
>>> static int add_bar_handlers(const struct pci_dev *pdev)
>>> {
>>> ...
>>>  =C2=A0=C2=A0=C2=A0 if ( is_hardware_domain(pdev->domain) )
>>>  =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 rc =3D vpci_add_register(pd=
ev->vpci, vpci_hw_read16, cmd_write,
>>>  =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 PCI_COMMAND, 2, header);
>>>  =C2=A0=C2=A0=C2=A0 else
>>>  =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 rc =3D vpci_add_register(pd=
ev->vpci, vpci_hw_read16, guest_cmd_write,
>>>  =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 PCI_COMMAND, 2, header);
>>> Is this going to be better?
>>
>> Marginally (plus you'd need to prove that pdev->domain can never be NULL
>> when making it here).
>=20
> I think it would an anomaly to try to setup vPCI handlers for a device
> without pdev->domain being set. I'm quite sure other vPCI code already
> relies on pdev->domain being set.

Quite likely, and my point wasn't to request dealing with the NULL case
by adding a check here. I really meant "prove", mainly recalling that
another patch (in another related series?) altered code around the
setting of pdev->domain in pci_add_device(). It would need to be assured
that whatever goes on there guarantees pdev->domain to have got set.

Jan



From xen-devel-bounces@lists.xenproject.org Fri Oct 15 06:29:59 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 06:29:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.209772.366317 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbGj0-0001dc-P0; Fri, 15 Oct 2021 06:29:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 209772.366317; Fri, 15 Oct 2021 06:29:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbGj0-0001dV-Lx; Fri, 15 Oct 2021 06:29:50 +0000
Received: by outflank-mailman (input) for mailman id 209772;
 Fri, 15 Oct 2021 06:29:49 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=FGCa=PD=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mbGiz-0001dP-8t
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 06:29:49 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 4ab0741c-2d81-11ec-8226-12813bfff9fa;
 Fri, 15 Oct 2021 06:29:47 +0000 (UTC)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2108.outbound.protection.outlook.com [104.47.18.108])
 (Using TLS) by relay.mimecast.com with ESMTP id
 de-mta-16-cT0T7Iy9MVKrYo8nZYx2Aw-1; Fri, 15 Oct 2021 08:29:45 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0401MB2336.eurprd04.prod.outlook.com (2603:10a6:800:27::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.25; Fri, 15 Oct
 2021 06:29:43 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.017; Fri, 15 Oct 2021
 06:29:43 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6P192CA0028.EURP192.PROD.OUTLOOK.COM (2603:10a6:209:83::41) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.16 via Frontend Transport; Fri, 15 Oct 2021 06:29:42 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4ab0741c-2d81-11ec-8226-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634279386;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=kk9aqE7Hf6K+1dwDB8q1G1Au5NoFvIB2rHxG7TTE2B0=;
	b=Q89SUEVwXwgvXMrNE1L5qP3oYTYYHueO4r9D9qVyWVPzJMY3edWkYigNJjOukIOzMW220a
	gtdyPTuBW6yfylzcmxF1z148lYKN2SVzZh71FtiSESsGuFQmF8U1H6et5fk4GiozOtTjjs
	4yo16Rk7Pv1tQ7I/Vcg1xjD4AfWgrNA=
X-MC-Unique: cT0T7Iy9MVKrYo8nZYx2Aw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=fdOOZIQXu13Fa8k72R+FA2bmBs6mI1AuJT7z/RFtesgsQgO4IfCBobDUGfw12aSzuTatyCh6UevXCASp0lgZSq6xNfIseI2hL3F3H9wIc1+Kohqlw0ozw+M7Qk6kl09986Eb1A9Xzje9dRktWJdBzhr6ZmN2fyMW9kXcis1k+6xBc4B6CW8zhf48LSZe+yErRCHUDEeAeYYF5s/W9BNiV2klETxMcRlCCKO1YMF/SD5NYldJ6qfn93s8GY0IgkkoscPy1VtJpMsZVZMtlmtPzWLB5kE6zLJjJRlwfxmtmtwpe2NkZNGgw3Swj1B9ahIA+kcQ7OA0AbELIuJjewN9Ig==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=NheZX20MwZBm0N64iNBm3OmW9KxSWXOPiPSjl6uZdME=;
 b=W41U220tGazdZYqKMmgpQ5Yq+qa4/y9kRXoKYeJ0TxpGNHdCgxyR878zL6FyU0N3eY7wp69LPZX6cxvRpLUSLYNKhfwmHCciUPBn3vOIlVkuYr96yBQzR+A/8UX09YbpdMFzbWz/jdbClsr7v/aHiWhoVfaJWeOGHjIqyDkiPh9aM/5tUf5KwFyFkp1Xa6b3cX/tTEI2JM9/T7QwquD9cPF1wX8kZuuHvUCzdFhjy6THEJfGs2YiceIU0B/qK7nxA9B41X7dC0pzE+iQW5ZEDqKZeK1NrLkzj0YTjSAlODYyFYmKN88FNJFioXnfYPxgKnz0Dgnf1gOTIejaGidWdA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [PATCH v6 1/3] xen/vpci: Move ecam access functions to common
 code
To: Bertrand Marquis <Bertrand.Marquis@arm.com>
CC: Ian Jackson <iwj@xenproject.org>, Paul Durrant <paul@xen.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>, Wei Liu
 <wl@xen.org>, "xen-devel@lists.xenproject.org"
 <xen-devel@lists.xenproject.org>
References: <cover.1634221830.git.bertrand.marquis@arm.com>
 <ced6f870dbfabcfe8584555cc80f9a37a0655a0c.1634221830.git.bertrand.marquis@arm.com>
 <20c73f4e-5a8b-c127-f3a7-b841f50b1a4a@suse.com>
 <6C71E132-0A78-4DA4-AA52-E62833912145@arm.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <8a7d1370-ee58-8e95-efea-8e4162e1e5f7@suse.com>
Date: Fri, 15 Oct 2021 08:29:41 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <6C71E132-0A78-4DA4-AA52-E62833912145@arm.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6P192CA0028.EURP192.PROD.OUTLOOK.COM
 (2603:10a6:209:83::41) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: f1350ac5-66e8-45df-ad5a-08d98fa52c7e
X-MS-TrafficTypeDiagnostic: VI1PR0401MB2336:
X-Microsoft-Antispam-PRVS:
	<VI1PR0401MB2336C84715BF70DF633B48CAB3B99@VI1PR0401MB2336.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	mDDnq6jcnqnURyP/A2CuzloG8SFcMIC+OdKmY9yVrzditEMZuHxvzaNC+ugrk8djFBNB+ibsnsmKdbodKSVjVccgi1dmB97YWEvM5pijB+cFt9ybE8xkQGQKF1aq5Hlv1VZPfXgSK8S30S+7ZipgiMYQi0NT2ZffQJ3evQtWNFXvRuRhG2b8qubF6hKaEtczHvRbUiBSGCAPYL1QIfEuWe7BceZnWbBCq2XuclXKHsfNdGuLQovg2S8zjV9ODdjLvhXYz/fkFBe+BNojpSMhhvcLF/fVNuyX7GjtVixcIn8hRvV0c2dFisMwfBdcjFsiP9r8yHkRTV83YM5t3Rls7xQCWTke7F8z9ILR4Z9UOzD/MhAo7WdGIPbYh916LRtuBaP0HPC2FEgOR0RZ8fCnfhASVJb6wX6L5IA/FO1j0+ZCd2RHkMgfc997U3Gs37sWaWXZvKnGH/jW2+ZStDmkW7XeXL8YvENJ/RLnfBX6AnKb/4awkwRK4oPjG4g0lbnO9QZqER0WwYMkt/wE87f02p0GPNS8wCH5/ZloSQYKZbNXvpMOkeSrZiEjguiQvhQ5p1pvWRCkAcFidLmVr9eAdH4xwB+8xrnfRPLApLadJGeMztxDuO1QP5QkgXsprLTbImWLIDkFyvB54poMqm7jj/iqUZnkS+T39Gq1btxvRDymHgeQf1/JbsNg2DkGqv0kgiD2Le5YRsSB7En4OOOa7jUXfhGNAij9Vfz/A6LJhPpmJSMwRlz4XrnKyk+vJJre
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(66476007)(31686004)(5660300002)(508600001)(6486002)(86362001)(16576012)(2906002)(54906003)(36756003)(66946007)(6916009)(66556008)(53546011)(31696002)(26005)(316002)(186003)(956004)(8676002)(2616005)(4326008)(38100700002)(8936002)(83380400001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?PEImCTex7FF0yY0wCMUsNk0itQ84K2STILNTNaFsWb+0SFXxlWXhBGieLy0A?=
 =?us-ascii?Q?OwZuvRaAeZjajDxsKoN7Kf/vUZXgchdj4X6nRsmyyS47F7TsZ0oH1Qw5QMLv?=
 =?us-ascii?Q?7eb62tfmn8Q1jZWywZid9vgqE5B6TzsAqAdqVzOLyhLIm52qoG1sVYKaa9ZB?=
 =?us-ascii?Q?P6v49JcobIzd2LN7wLbSjHo1ngs9BP+qFo33J5oerviBNzsBH5fZ+z86rrsp?=
 =?us-ascii?Q?isX8cYQjmCCic8rVZXkZ7mUk2p57mnOjAvY8dkIXEyQAixQ1TNlzJuArT1hF?=
 =?us-ascii?Q?l4HBP3XC53Xf36qyw4fFjSj8Rth433at3DSQg/8dLXiE5KBGxnixFxBwVHfm?=
 =?us-ascii?Q?gtvu6w4btJpn3rbkKwCWnhPe3Aj/W70tgwTXLDpYvp1viNFc/bHg2ra41DSj?=
 =?us-ascii?Q?8FjDtgwSOFGlGBIY1iRzzwzckzxPbeHmTYns4iraHEZv42gOXruvVVw62Wjf?=
 =?us-ascii?Q?hxf7FLTYOy9IIRYk4iKQo3iBvA3JAn/xQxtcBU59HRYaw7e502BOZczLu37U?=
 =?us-ascii?Q?mzzpxpmrVlFlUmeM2NkNTirYJAFXhZien7vhPlnf77H0mb7o2k9kBiRlWK85?=
 =?us-ascii?Q?p+m/66EpexfsBdr6Z9xVF+BoVnSE+3ZjXzE5n61n4AJAGy7d8+NrmYQNtzJ6?=
 =?us-ascii?Q?HlEULpdfCMrLSrlWXocHKF/kUN5k0SNtd0uc2FyQkcwEtKnbXk+vuHUQScqS?=
 =?us-ascii?Q?fM3WuVqgfPCxukMDcHoizBdc55q/1xwfRijSvvFlYKEQPc65jX4pfMuBgXv2?=
 =?us-ascii?Q?zX50HuGD/zOPgamHNFlCr8bjlJAO9YEjv9mHIHCBYu8y1p5Wq8p1zc4S5SR7?=
 =?us-ascii?Q?eE9kys9uHdelgWVKOKqOBa72A5uBcBbY3jJQz3Tf9Amrur0jy8Ls5z2LBfwL?=
 =?us-ascii?Q?Xij+pRRoWPAIZcn1RJGXiGE4isR8FVHQNotsV7NVZf2yy8zng138affhTjYj?=
 =?us-ascii?Q?ZVc9az1BvFA3jfKTjTFdpE3vSzHr9bwbVthjiVoZ9U3OrAEdyTHRRPPa4nYI?=
 =?us-ascii?Q?RwX8QkkVQNr9xNmtH6k7SnLMejpn/p6xHn3JdFRa9j8JScDyu/6y6P7o7G2k?=
 =?us-ascii?Q?rmIx+wiFFOi/wm0wIfbxGsAhVf12XBJmM9nBZUPGDSca+4i6Cbxu41gtU7cC?=
 =?us-ascii?Q?RyVrbeG439CSmyBb5HbifG1ukEatc5Fy4w4o19HJwWetaH4PN2kD9q8JSHjT?=
 =?us-ascii?Q?liHX0uGY/ZL3Z7Fz7yJYilCk8dhMR0GbE+i1/f1vQMamEMaIH5KMVLi4hxJn?=
 =?us-ascii?Q?SehikSnUtdlZEjJ8ZXfLl/LKTUnDybfMNF/lz1uw/Ss6WCS5devCo2Ng6puw?=
 =?us-ascii?Q?zA85sTCgz/RnGigvxqhUTS9V?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f1350ac5-66e8-45df-ad5a-08d98fa52c7e
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2021 06:29:42.9620
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +vKogTSvvM4PcpmEH+szltJFCo0R8SnnrjYNxsWY1Th//GwqPhZBP713qPZ4VfC0VyTvqDar+a7m0UnFz8P15w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2336

On 14.10.2021 19:09, Bertrand Marquis wrote:
>> On 14 Oct 2021, at 17:06, Jan Beulich <jbeulich@suse.com> wrote:
>> On 14.10.2021 16:49, Bertrand Marquis wrote:
>>> @@ -305,7 +291,7 @@ static int vpci_portio_read(const struct hvm_io_han=
dler *handler,
>>>
>>>     reg =3D hvm_pci_decode_addr(cf8, addr, &sbdf);
>>>
>>> -    if ( !vpci_access_allowed(reg, size) )
>>> +    if ( !vpci_ecam_access_allowed(reg, size) )
>>>         return X86EMUL_OKAY;
>>>
>>>     *data =3D vpci_read(sbdf, reg, size);
>>> @@ -335,7 +321,7 @@ static int vpci_portio_write(const struct hvm_io_ha=
ndler *handler,
>>>
>>>     reg =3D hvm_pci_decode_addr(cf8, addr, &sbdf);
>>>
>>> -    if ( !vpci_access_allowed(reg, size) )
>>> +    if ( !vpci_ecam_access_allowed(reg, size) )
>>>         return X86EMUL_OKAY;
>>>
>>>     vpci_write(sbdf, reg, size, data);
>>
>> Why would port I/O functions call an ECAM helper? And in how far is
>> that helper actually ECAM-specific?
>=20
> The function was global before.

I'm not objecting to the function being global, but to the "ecam" in
its name.

>>> @@ -434,25 +420,8 @@ static int vpci_mmcfg_read(struct vcpu *v, unsigne=
d long addr,
>>>     reg =3D vpci_mmcfg_decode_addr(mmcfg, addr, &sbdf);
>>>     read_unlock(&d->arch.hvm.mmcfg_lock);
>>>
>>> -    if ( !vpci_access_allowed(reg, len) ||
>>> -         (reg + len) > PCI_CFG_SPACE_EXP_SIZE )
>>> -        return X86EMUL_OKAY;
>>
>> While I assume this earlier behavior is the reason for ...
>=20
> Yes :-)
>=20
>>
>>> -    /*
>>> -     * According to the PCIe 3.1A specification:
>>> -     *  - Configuration Reads and Writes must usually be DWORD or smal=
ler
>>> -     *    in size.
>>> -     *  - Because Root Complex implementations are not required to sup=
port
>>> -     *    accesses to a RCRB that cross DW boundaries [...] software
>>> -     *    should take care not to cause the generation of such accesse=
s
>>> -     *    when accessing a RCRB unless the Root Complex will support t=
he
>>> -     *    access.
>>> -     *  Xen however supports 8byte accesses by splitting them into two
>>> -     *  4byte accesses.
>>> -     */
>>> -    *data =3D vpci_read(sbdf, reg, min(4u, len));
>>> -    if ( len =3D=3D 8 )
>>> -        *data |=3D (uint64_t)vpci_read(sbdf, reg + 4, 4) << 32;
>>> +    /* Ignore return code */
>>> +    vpci_ecam_mmio_read(sbdf, reg, len, data);
>>
>> ... the commented-upon ignoring of the return value, I don't think
>> that's a good way to deal with things anymore. Instead I think
>> *data should be written to ~0 upon failure, unless it is intended
>> for vpci_ecam_mmio_read() to take care of that case (in which case
>> I'm not sure I would see why it needs to return an error indicator
>> in the first place).
>=20
> I am not sure in the first place why this is actually ignored and just
> returning a -1 value.
> If an access is not right, an exception should be generated to the
> Guest instead.

No. That's also not what happens on bare metal, at least not on x86.
Faults cannot be raised for reasons outside of the CPU; such errors
(if these are errors in the first place) need to be dealt with
differently. Signaling an error on the PCI bus would be possible,
but would leave open how that's actually to be dealt with. Instead
bad reads return all ones, while bad writes simply get dropped.

> When we do that on arm the function is returning an error to the upper
> layer in that case, that=E2=80=99s why I did keep a generic function info=
rming the
> caller.

While you're the Arm expert, with the above in mind I wonder what
the actual action in that case ought to be there. Would you explain
to me how, say, a misaligned 2-byte read that the CPU permits but
the PCI subsystem doesn't like would be dealt with by bare metal?

>>> @@ -476,13 +445,8 @@ static int vpci_mmcfg_write(struct vcpu *v, unsign=
ed long addr,
>>>     reg =3D vpci_mmcfg_decode_addr(mmcfg, addr, &sbdf);
>>>     read_unlock(&d->arch.hvm.mmcfg_lock);
>>>
>>> -    if ( !vpci_access_allowed(reg, len) ||
>>> -         (reg + len) > PCI_CFG_SPACE_EXP_SIZE )
>>> -        return X86EMUL_OKAY;
>>> -
>>> -    vpci_write(sbdf, reg, min(4u, len), data);
>>> -    if ( len =3D=3D 8 )
>>> -        vpci_write(sbdf, reg + 4, 4, data >> 32);
>>> +    /* Ignore return code */
>>> +    vpci_ecam_mmio_write(sbdf, reg, len, data);
>>
>> Here ignoring is fine imo, but if you feel it is important to
>> comment on this, then I think you need to prefer "why" over "what".
>=20
> Agree I would just need some help on the why.
> Now there was no comment before to explain why so I could also
> remove the comment altogether.

The latter would be my preference.

>>> --- a/xen/drivers/vpci/vpci.c
>>> +++ b/xen/drivers/vpci/vpci.c
>>> @@ -478,6 +478,66 @@ void vpci_write(pci_sbdf_t sbdf, unsigned int reg,=
 unsigned int size,
>>>     spin_unlock(&pdev->vpci->lock);
>>> }
>>>
>>> +/* Helper function to check an access size and alignment on vpci space=
. */
>>> +bool vpci_ecam_access_allowed(unsigned int reg, unsigned int len)
>>> +{
>>> +    /*
>>> +     * Check access size.
>>> +     *
>>> +     * On arm32 or for 32bit guests on arm, 64bit accesses should be f=
orbidden
>>> +     * but as for those platform ISV register, which gives the access =
size,
>>> +     * cannot have a value 3, checking this would just harden the code=
.
>>> +     */
>>> +    if ( len !=3D 1 && len !=3D 2 && len !=3D 4 && len !=3D 8 )
>>> +        return false;
>>
>> I'm not convinced talking about Arm specifically here is
>> warranted, unless there's something there that's clearly
>> different from all other architectures. Otherwise the comment
>> should imo be written in more general terms.
>=20
> Other architectures might allow this case. So this is specific to Arm.

If it really is, I consider it wrong to live in common code. If
per-arch tweaking is necessary, and if earlier handling of the
intercepted access doesn't already exclude "bad" cases, then a
per-arch hook would imo be the way to go here. Given the size
of the function I would then wonder why it doesn't remain per-
arch in the first place.

>>> +int vpci_ecam_mmio_write(pci_sbdf_t sbdf, unsigned int reg, unsigned i=
nt len,
>>> +                         unsigned long data)
>>> +{
>>> +    if ( !vpci_ecam_access_allowed(reg, len) ||
>>> +         (reg + len) > PCI_CFG_SPACE_EXP_SIZE )
>>> +        return 0;
>>> +
>>> +    vpci_write(sbdf, reg, min(4u, len), data);
>>> +    if ( len =3D=3D 8 )
>>> +        vpci_write(sbdf, reg + 4, 4, data >> 32);
>>> +
>>> +    return 1;
>>> +}
>>> +
>>> +int vpci_ecam_mmio_read(pci_sbdf_t sbdf, unsigned int reg, unsigned in=
t len,
>>> +                        unsigned long *data)
>>> +{
>>> +    if ( !vpci_ecam_access_allowed(reg, len) ||
>>> +         (reg + len) > PCI_CFG_SPACE_EXP_SIZE )
>>> +        return 0;
>>> +
>>> +    /*
>>> +     * According to the PCIe 3.1A specification:
>>> +     *  - Configuration Reads and Writes must usually be DWORD or smal=
ler
>>> +     *    in size.
>>> +     *  - Because Root Complex implementations are not required to sup=
port
>>> +     *    accesses to a RCRB that cross DW boundaries [...] software
>>> +     *    should take care not to cause the generation of such accesse=
s
>>> +     *    when accessing a RCRB unless the Root Complex will support t=
he
>>> +     *    access.
>>> +     *  Xen however supports 8byte accesses by splitting them into two
>>> +     *  4byte accesses.
>>> +     */
>>> +    *data =3D vpci_read(sbdf, reg, min(4u, len));
>>> +    if ( len =3D=3D 8 )
>>> +        *data |=3D (uint64_t)vpci_read(sbdf, reg + 4, 4) << 32;
>>> +
>>> +    return 1;
>>> +}
>>
>> Why do these two functions return int/0/1 instead of
>> bool/false/true (assuming, as per above, that them returning non-
>> void is warranted at all)?
>=20
> This is what the mmio handlers should return to say that an access
> was ok or not so the function stick to this standard.

Sticking to this would be okay if the functions here needed their
address taken, such that they can be installed as hooks for a
more general framework to invoke. The functions, however, only get
called directly. Hence there's no reason to mirror what is in need
of cleaning up elsewhere. I'm sure you're aware there we're in the
(slow going) process of improving which types get used where.
While the functions you refer to may not have undergone such
cleanup yet, we generally expect new code to conform to the new
model.

Jan



From xen-devel-bounces@lists.xenproject.org Fri Oct 15 06:38:59 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 06:38:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.209782.366327 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbGrm-00038I-Ou; Fri, 15 Oct 2021 06:38:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 209782.366327; Fri, 15 Oct 2021 06:38:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbGrm-00038B-Ls; Fri, 15 Oct 2021 06:38:54 +0000
Received: by outflank-mailman (input) for mailman id 209782;
 Fri, 15 Oct 2021 06:38:53 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mbGrk-000381-Uy; Fri, 15 Oct 2021 06:38:52 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mbGrk-0005Fa-MV; Fri, 15 Oct 2021 06:38:52 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mbGrk-0000bF-88; Fri, 15 Oct 2021 06:38:52 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mbGrk-0000iO-7e; Fri, 15 Oct 2021 06:38:52 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=XgaPTw3ngmvZUy403b2Nn2t8PByyeEEyuWCP/Qi0dlM=; b=ZnqeHlj5E/taMATNW6p2flVWwR
	SishllIUn4D1i2kNDvjEcoOVp6H2ak4L9ImaQ2+k19K436PtCXxGpHG6X6O2oB55/NfBlcPaIXlJJ
	P+p1sjtvIbhRPJrB/FbuY1KozvarCBlKW/nmzc2g2VmkPUjAoqJ1qR7fnTTZwn89P7fE=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165514-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 165514: tolerable FAIL - PUSHED
X-Osstest-Failures:
    qemu-mainline:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=4d1a525dfafe995a98bb486e702da09e31b68b9c
X-Osstest-Versions-That:
    qemuu=e5b2333f24ff207f08cf96e73d2e11438c985801
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 15 Oct 2021 06:38:52 +0000

flight 165514 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165514/

Failures :-/ but no regressions.

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds    18 guest-start/debian.repeat fail REGR. vs. 165506

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165506
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165506
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 165506
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 165506
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 165506
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 165506
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 165506
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165506
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 qemuu                4d1a525dfafe995a98bb486e702da09e31b68b9c
baseline version:
 qemuu                e5b2333f24ff207f08cf96e73d2e11438c985801

Last test of basis   165506  2021-10-14 09:38:59 Z    0 days
Testing same since   165514  2021-10-14 20:38:00 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Alexander Bulekov <alxndr@bu.edu>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Paolo Bonzini <pbonzini@redhat.com>
  Richard Henderson <richard.henderson@linaro.org>
  Thomas Huth <thuth@redhat.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/qemu-xen.git
   e5b2333f24..4d1a525dfa  4d1a525dfafe995a98bb486e702da09e31b68b9c -> upstream-tested


From xen-devel-bounces@lists.xenproject.org Fri Oct 15 06:41:08 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 06:41:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.209791.366342 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbGtv-0004UH-8R; Fri, 15 Oct 2021 06:41:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 209791.366342; Fri, 15 Oct 2021 06:41:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbGtv-0004UA-49; Fri, 15 Oct 2021 06:41:07 +0000
Received: by outflank-mailman (input) for mailman id 209791;
 Fri, 15 Oct 2021 06:41:05 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=FGCa=PD=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mbGtt-0004U0-EB
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 06:41:05 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id dc7a16ce-2d82-11ec-8226-12813bfff9fa;
 Fri, 15 Oct 2021 06:41:01 +0000 (UTC)
Received: from EUR01-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur01lp2056.outbound.protection.outlook.com [104.47.1.56]) (Using
 TLS) by relay.mimecast.com with ESMTP id de-mta-3-dzKrSfWINja0GfQv6o4EXw-1;
 Fri, 15 Oct 2021 08:40:59 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB4608.eurprd04.prod.outlook.com (2603:10a6:803:72::24)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.25; Fri, 15 Oct
 2021 06:40:57 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.017; Fri, 15 Oct 2021
 06:40:57 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6P194CA0072.EURP194.PROD.OUTLOOK.COM (2603:10a6:209:84::49) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.14 via Frontend Transport; Fri, 15 Oct 2021 06:40:56 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: dc7a16ce-2d82-11ec-8226-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634280060;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=hgMMJNs0GTVRfukQOqWZQTjZup3I7othJ/wIT93TQDo=;
	b=NN81QGpve14lkzaRiWLeNtJbzLTFRgl3bIsKFP7m+Re60rjWKbLXVL3d7VQp8BaQx20GfM
	HmsyCdlNjmTr3Riq4hrkc3cb87OO4GYBWGGHLJOjp8DzbDFyqYFAa4/cz0C8zl9CoI136E
	nEMD9n699mmw/oId0WwLfCqmYw8+b0g=
X-MC-Unique: dzKrSfWINja0GfQv6o4EXw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=erb5Ha5yzNrxIZMV+laHi2xcWciEUS5td3AjVyd084PMds03lX8MZBR8sIHVpClhTAPYm//ZkjtbnKnMnpYpgWS+o3PaEh+iOOGm0jyNXkiGRES++pic7Uu2FBJ6tsFXE7rdmCIDUS7w8nrJBjDksRmqGzFHe1j6Vrao1vAG39/kFMo37vNXyxWN8vj+gpuwX19c3T7mQUA79G7rbF5MMsS+yvtLZ/k/ZVsy+KZZ/Fa+qqth7s8otCfJpFBIbx0nLPfH3EkBxezqPVVoMVTB+AA+6U19W/SQKWgil1zomGhZtJONxX7jiterubZXGPXjFWEyd0IpnOo0UtLFa/kzwA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=COrLCkccvjn5+XaZKD1zCErafRGmq5lTaIPv7sxOq2Q=;
 b=gV/ph0/mwufEnsvshxHq7K7qEjuqKtJT2eNfNXQZQRdoDuJ8vP0UkBc9v42tlFaLj2Hd6tCSS4TKcwgPF8sjtKN/+zcYEEfOwbeQpPIJWT3bfaNsL0Iijg2hl1JYD7MRjkjL5ZvjElTsMFxxRWq5QD4b0d6J4ZIUBJOeLtleYY1pGkSGEgt9lCgM73sF4+m80mwod4k4t3TBIqey6HvqXyu+1+6O6XGvDQzlepY1n84CVT/8emjCJDGchx8JsAM8RgcnN2GujJaAteOwHX4jluWaCK53e9ziff86IfvqO6mJOqtDBH3SuQlB045ss3AtnHB+0/LIeTcrMmFhqgP7cw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: citrix.com; dkim=none (message not signed)
 header.d=none;citrix.com; dmarc=none action=none header.from=suse.com;
Subject: Re: [PATCH v6 2/3] xen/arm: Enable the existing x86 virtual PCI
 support for ARM.
To: Stefano Stabellini <sstabellini@kernel.org>,
 Bertrand Marquis <bertrand.marquis@arm.com>
CC: xen-devel@lists.xenproject.org, iwj@xenproject.org,
 Rahul Singh <rahul.singh@arm.com>, Julien Grall <julien@xen.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
 Paul Durrant <paul@xen.org>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>
References: <cover.1634221830.git.bertrand.marquis@arm.com>
 <396b08e2598cf0338e0c7f4ad3cd5cb66db89224.1634221830.git.bertrand.marquis@arm.com>
 <alpine.DEB.2.21.2110141331310.9408@sstabellini-ThinkPad-T480s>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <e4eeaa45-e473-9cb1-a65e-70cb0fdfc443@suse.com>
Date: Fri, 15 Oct 2021 08:40:55 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <alpine.DEB.2.21.2110141331310.9408@sstabellini-ThinkPad-T480s>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6P194CA0072.EURP194.PROD.OUTLOOK.COM
 (2603:10a6:209:84::49) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 1db8cd95-8c15-403a-8ffa-08d98fa6beb4
X-MS-TrafficTypeDiagnostic: VI1PR04MB4608:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB4608CC343E51ABBF501A74C2B3B99@VI1PR04MB4608.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	UFCr0WGHjQQUKsZWnjaVNSuZO7DppWhur0ltjSJx3J4gfrRkF4GfOYhEWv+P0I0g1lKi13QKmeNEbGRe4ukSUfas7fTBBy1qiuuqnT3Tm7WcZniIBjr07KHrQqEvh3Gx0/UE8dWCVOMb11+uW7krMWi1CvTEggVHQFdHj06ezV7xdLUkUkcPANGIYNOtKY69czPSLYovFGM6OS/h8A8Us/qFGzZfWp8ITv2TKwhKgIfehDHKfgiYAZgXZJ7ancHy/1GJHEiDyWbMTVEg7WBQ0dPBHbWTfnZJV8crvboW8tLqsYCCUTspQPQv6iUYmG5shEsXKMmsUkAl2kvE3ON4yaZ09qCTlWNErKsmTxteRDrW8uJlg9HbzZwYcsj4REOJ86pTU0Pp9W0Nr1jUjLR7M/Y/mKzGu8og/wmAx8o5lY5e3B8lhAHVoDT6VqbRXgEch8HTmVMBo9SP3ilp74TcZj9Jc9WD01waXxpP+bRyiX6N2kqBsDFQlaJfwpsRe+q/2ppn/vbIe/RDHTWIJVgDLAuAp6hsJh/pDCspAtd8rHC4yJ92/wd/sAJ/2canXsbTs95JS0XyzRzNnQDx8Oxbl55l2i3iorcR+bQ0egbxUepN+20HoYeJkUgcD01G99ZDVVw/umsNaL2TVQ6DFkIYUxGllckZ+hZ4AccMyKnzTSpFTxTI7qtB8Rc1XOcPvD5lpZPhY0vJ7kPVvg1WVFe8ppjpyr1nRHYGeg1hOsr3rMIRgNcxZevQb7SGkG/CZSmLk7XrU355wBPBP5LbVmgP1JvgC0Cx8v6KZvz3DfFXeZGlMZcjPbz8X2VEph91Ik0SFRGMOdI0JfTKHjmBFbd9nwC0vcSubkg1isP7NOCrwqq1XEho+cD5cIykWJQ0FX8z
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(8676002)(31686004)(8936002)(31696002)(6486002)(2906002)(508600001)(110136005)(316002)(966005)(16576012)(38100700002)(54906003)(186003)(4326008)(36756003)(956004)(86362001)(2616005)(66556008)(53546011)(66946007)(66476007)(7416002)(26005)(5660300002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?65tN12bfFzLA48F9NExsuIYvwYpt39bqDxTil+cO+IIZxXV7twnEYPXp1nbJ?=
 =?us-ascii?Q?Bi2/OjtJtnQ1YScUs6/H63ga5ffQH8qnFeui+ib0lZ46cewLx1DlQAahoye3?=
 =?us-ascii?Q?q6a702drCPfnj7+LhA0dDTpo98iY6i+AQU5VttEJU28B7wUlE6x9ABKZTQVD?=
 =?us-ascii?Q?gdRbWcQtiud0xkym/4/Rx/MFeSgd6LHJ/ofYhVslFFOuAZTYyINkVjTqaOAu?=
 =?us-ascii?Q?sgwBLcHYKLq/S1agxcud1u2doJUx7WNUg/1OOLzFLwDVtlROgsrbwJvZiPDl?=
 =?us-ascii?Q?JgLJFgocBoUjhiA6D2QxFi5HKjKw3qp9nLZXU/aWjzr1MQYjn+o9owdszinH?=
 =?us-ascii?Q?QBomLC3guj1ErIyIhL0lvK1vWRaSYFpAHoltuHoR/1I+QanmHnXqzPNS0nii?=
 =?us-ascii?Q?K592EFqi035sVOkLevc5Dq16+KOi4v7U0rg5AcHgEGWUXYkeppJhLJjLTr4Z?=
 =?us-ascii?Q?ffRANYFyrCCv5faM3b4q0WjKyoR6ij9q+lLe056cceF1g8W5ndSMhex9kC2y?=
 =?us-ascii?Q?+dXlVaKb8Xla09MM5PDz2U2pUjAZNWKvN0QXf92qndX+77gzY8D+2yEXKhM2?=
 =?us-ascii?Q?Z2C+merVV+U+/b32UzBlj02LoiYEp+PYPPHk/ezdW88UEXdK43kxmfGIGz5N?=
 =?us-ascii?Q?irIhyhILnjpZqzQ9HR8dy+KVOUnekHytoTlCbnKIbnGF0pieylRrcEtlgzI1?=
 =?us-ascii?Q?s1zRu+BnzsdMT24Q0NceETt7sILUlR4kjfdSG/+UGiRnIIL4k1ECF6lnscPV?=
 =?us-ascii?Q?0brIrIYYcQFEzlkIRcaSo9QWZXq+Ie1404F0XPMn3qNEjrFp+AoUcGEsBuXi?=
 =?us-ascii?Q?CkmiUkktsQo0aZx9pet8Zn3Sp9TPs8e8g70sjj5n5OP1Yk9j9dJ4FF5jw/HD?=
 =?us-ascii?Q?Bgt2dFR0/KC/sSln07YVJDX8NoFnI8wRgGNXjQrZ/cquJ7GCkj3UjOa8mFB0?=
 =?us-ascii?Q?bXshf7jVIltnlkA0U/LfYGeoivjcqLUMMMFdaisldhgHoY/iEm38DwFEg/8B?=
 =?us-ascii?Q?J0JDSvrzLjFq7eAK3cN9RzW9mhy+QxH0tcYee7Ie11WoxznOjG+28bIACqVQ?=
 =?us-ascii?Q?j5H1RKX5q7lVZqPWT5hG8tzuRxdHdmoP9smNnIFae9ONz8EJLC9tkARR8j/I?=
 =?us-ascii?Q?452yljRM1YHRRDICXxb0VnTn7MtwejL0S+EKg9/LyKUSuFrHK73DKGaAIIvn?=
 =?us-ascii?Q?eQC+cAqLy3E1HzwBSpCvZ98YF9vB8laVU7O3hu5aIo+RA0zfUMLJ5iE6+DBu?=
 =?us-ascii?Q?aA7C4MPZcPpt61TeOf3k3qiYu1CUjV/dlWQGSReQ5AAJGAzTeJGxe0srfMPm?=
 =?us-ascii?Q?+Tl0muITU8sviJIkWPwJDnzX?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1db8cd95-8c15-403a-8ffa-08d98fa6beb4
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2021 06:40:57.7462
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: gMfKk/iIEcE//ZGoLvUxy+ActpcezyDkm3hPh/lXLqss4zxmNqsMDJw9NVZrgKyUenCufItkLXxmlP9H2VdoIw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4608

On 15.10.2021 01:49, Stefano Stabellini wrote:
> On Thu, 14 Oct 2021, Bertrand Marquis wrote:
>> --- a/xen/include/public/arch-arm.h
>> +++ b/xen/include/public/arch-arm.h
>> @@ -418,6 +418,13 @@ typedef uint64_t xen_callback_t;
>>  #define GUEST_GICV3_GICR0_BASE     xen_mk_ullong(0x03020000) /* vCPU0..=
127 */
>>  #define GUEST_GICV3_GICR0_SIZE     xen_mk_ullong(0x01000000)
>> =20
>> +/*
>> + * 256 MB is reserved for VPCI configuration space based on calculation
>> + * 256 buses =C3=97 32 devices =C3=97 8 functions =C3=97 4 KB =3D 256 M=
B
>> + */
>=20
> Somehow 3 non-ascii characters sneaked into this patch. The 'x' are not
> 'x' but are 0xc3 and cause the following errors in a few gitlab-ci
> builds:
>=20
> python3 mkheader.py arm32 arm32.h.tmp /builds/xen-project/people/sstabell=
ini/xen/tools/include/xen-foreign/../../../xen/include/public/arch-arm.h /b=
uilds/xen-project/people/sstabellini/xen/tools/include/xen-foreign/../../..=
/xen/include/public/xen.h
> Traceback (most recent call last):
>   File "mkheader.py", line 120, in <module>
>     input +=3D f.read();
>   File "/usr/lib/python3.5/encodings/ascii.py", line 26, in decode
>     return codecs.ascii_decode(input, self.errors)[0]
> UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 1464=
1: ordinal not in range(128)
> Makefile:28: recipe for target 'arm32.h' failed
> make[2]: *** [arm32.h] Error 1
>=20
> Full logs here:
> https://gitlab.com/xen-project/people/sstabellini/xen/-/pipelines/3885507=
8
> https://gitlab.com/xen-project/people/sstabellini/xen/-/jobs/16810108756
>=20
>=20
> Replacing the 3 characters with 'x' solves the problem.
> https://gitlab.com/xen-project/people/sstabellini/xen/-/pipelines/3887212=
62

Interesting. I thought we permit UTF-8 in the sources; see e.g.
tools/tests/x86_emulator/simd-sha.c using =CE=A3. Is mkheader.py in need
of adjustment? Of course I can see that right now the easiest is to
use ASCII x, but I think it was deliberate to use =C3=97 here.

Then again, with the goal of the public headers being usable with
pretty old compilers as well (C89 being the assumed baseline),
excluding them from the permission to use UTF-8 may also be quite
reasonable.

Jan



From xen-devel-bounces@lists.xenproject.org Fri Oct 15 07:27:49 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 07:27:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.209801.366352 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbHcr-0000G0-KR; Fri, 15 Oct 2021 07:27:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 209801.366352; Fri, 15 Oct 2021 07:27:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbHcr-0000Ft-Hb; Fri, 15 Oct 2021 07:27:33 +0000
Received: by outflank-mailman (input) for mailman id 209801;
 Fri, 15 Oct 2021 07:27:33 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=qCqZ=PD=citrix.com=lin.liu@srs-us1.protection.inumbo.net>)
 id 1mbHcr-0000Fn-1U
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 07:27:33 +0000
Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 12563e6c-b76b-44f5-b486-98341f19b5b9;
 Fri, 15 Oct 2021 07:27:30 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 12563e6c-b76b-44f5-b486-98341f19b5b9
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1634282850;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=G17h/67QdOusbfGQ+sz1UjeNH3vHEsbkQv5h0AgCDVo=;
  b=dLKXlI7b4kkc/zohWYIvkUqulCEg19PW7GsJUVsS23DMkK+DgXcqZ/H3
   Sj1QwHaX6lSQr4oRR4tQ3QwWk77RGrQ6AFkZu3DWse0yE2T1RaehVfh4j
   tZnwItgi/6c+WMFzcd++kOlLhvASZ9m0lz29doYXMr2WIZIDBxRzAttm1
   s=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: 2rii4GPjgz2KYojilzVWsjmYgpchkTqBq3ssPa/EXXXVQ4lieqFDqlJpZcxgepz2H/Sf+GCmJw
 LU+TzuGNyXy0/ob4q7zRh4547ClC/YwlR1G8naGs7q60KVLDYWVCuwkU+fvWLu3OlHqNc68iOo
 N2ZtvrLl/ycAkFPin9IKYpZOQI12EoMnokGiHCgOkKJawSwr3Jagh/t80Q6T06usiO7zg02NWN
 1R6JUrWzkTkPiXcuoYCR+IGaOLn1VpUp+uCnoDYk4+dKD6bkK9g5dORG7W4J0YdCI5fbza1qIB
 IkVVsVf1ZxdhzeLPQlhgV9bl
X-SBRS: 5.1
X-MesageID: 55294408
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:vZkcJKksef0+p8jPt1pajGvo5gwlIURdPkR7XQ2eYbSJt1+Wr1Gzt
 xJNDG/Xbv2PYzGkeYt0YIi+oR5Q7Z+Gz9dkTVds/3s8ECMWpZLJC+rCIxarNUt+DCFioGGLT
 Sk6QoOdRCzhZiaE/n9BClVlxJVF/fngqoDUUYYoAQgsA185IMsdoUg7wbdg2tc12YHR7z6l4
 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc
 s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4
 NYcpIebeVwWBL3j3+05UEVfCg11H6ITrdcrIVDn2SCS50jPcn+qyPRyFkAme4Yf/46bA0kXq
 6ZecmpUKEne2aTmm9pXScE17ignBM3qOsUbu2xIxjDFF/c2B5vERs0m4PcFgW1h2pwWTZ4yY
 eI+OAJqa0zyXiFsPwk9L80vsNuBpUDWJmgwRFW9+vNsvjm7IBZK+LvqNsDcdpqVRMFWtkGCr
 2nC8iLyBRRyHN6CzTuI9Fq8i+mJmjn0MKoNEJWo+/gsh0ecrkQRAhALUVqwodGil1WzHdlYL
 iQ86ico6KQ/6kGvZt38RAGj5m6JuAYGXNhdGPF87xuCooLP+BqQDGUASj9HafQludUwSDhs0
 UWG9/vXAjhovKyQWGiq3L6epjOvOgAYNWYHIyQDSGM4D8LL+d9pyEiVF5A6TfDz3oad9SzML
 y6ir3kvnJ4j1vExx4r89HTE3zW1ipPrQVtgjunIZV6N4gR8bY+jQoWn71nH8PpNRLqkokm9U
 GsswJfGsrhfZX2ZvGnUGr9VReD2jxqQGGSE2QYHInU3y9i6F5dPl6hr6zZiOFwhDM8AfTL4C
 KM4kVIMvMENVJdGgKkeXm5QNyjI5fS/fTgGfqqNBjarXnSXXFTalM2JTRTBt10BaGB2zckC1
 W6zKK5A90oyB6V91yaRTOwAy7ItzS1W7TqNHsyhlE78jOPOPiD9pVI53L2mNb1RAESs+129z
 jqiH5HSl0U3vBPWM0E7DrL/3XhVdCNmVPgaWuRcd/KZIxoOJY3SI6S5/F/VQKQ8x/49vr6Rp
 hmVAxYEoHKi1SyvAVjbMRhLNeKwNauTWFpmZETAy37zgCN9CWtuhY9CH6YKkU4Pr7I+k6QtF
 KdYIq1twJ1nE1z6xtjUVrGlxKQKSfhhrV7m0/ONbGdtcph+aRbO/9O4LALj+DNXVni8tNcko
 q3m3QTeGMJRSwNnBcfQSfSu01Lu4iRNxLMsBxPFcotJZUHh0Il2MCit3PU5FN4BdEfYzTyA2
 gfIXRpB/bvRo5U4+cXijLyfq9v7CPN3G0dXRjGJ7bu/OSTA0HCkxItMDLSBcTzHDTum86S+f
 +RFifr7NaRfzlpNtoN9FZdtzL4/uISz9+MLkFw8ESySPVqxC75mLn2X5uV1t/VAlu1DpA+7e
 kOT4d0Ga7+HD9zoTQwKLw0/Y+XdifxNwmvO7e44KVnR7TNs+ObVSl1bOhSBhXAPLLZxN495k
 +4ttNRPtl66gxsudN2HkjpV5yKHKXlZC/crsZQTAYnKjAs3yw4dPcyAW3GuuJzfOc9RNkQKI
 yOPgPuQjrtR8UPObn4vGCWfxuFan5kP5EhHwVJqy45lQTYZaivbBCFszAk=
IronPort-HdrOrdr: A9a23:nyS6E6qx96seHCkZA94/1IkaV5oTeYIsimQD101hICG8cqSj+f
 xG+85rsyMc6QxhIE3I9urhBEDtex/hHNtOkOws1NSZLW7bUQmTXeJfBOLZqlWKcUDDH6xmpM
 NdmsBFeaTN5DNB7PoSjjPWLz9Z+qjkzJyV
X-IronPort-AV: E=Sophos;i="5.85,375,1624334400"; 
   d="scan'208";a="55294408"
From: Lin Liu <lin.liu@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: <sstabellini@kernel.org>, <julien@xen.org>, <Volodymyr_Babchuk@epam.com>,
	<andrew.cooper3@citrix.com>, <George.Dunlap@eu.citrix.com>,
	<ian.jackson@eu.citrix.com>, <jbeulich@suse.com>, <konrad.wilk@oracle.com>,
	<wl@xen.org>, <roger.pau@citrix.com>, Lin Liu <lin.liu@citrix.com>
Subject: [PATCH 1/1] xen/include/xen/byteorder: Re-implement bswap/swab with compiler builtin functions
Date: Fri, 15 Oct 2021 07:26:17 +0000
Message-ID: <ed4f3f82cc2989ebf52425aead420014fbe00bf7.1634282259.git.lin.liu@citrix.com>
X-Mailer: git-send-email 2.27.0
In-Reply-To: <cover.1634282259.git.lin.liu@citrix.com>
References: <cover.1634282259.git.lin.liu@citrix.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

Current implementation of bswap/swab is overhaul which involves
byte operations, compilers has builtin functions can help to
simply the implementation
* GCC: https://gcc.gnu.org/onlinedocs/gcc/Other-Builtins.html
* Clang: https://clang.llvm.org/docs/LanguageExtensions.html

This commit replace the implementation with compiler builtins

Signed-off-by: Lin Liu <lin.liu@citrix.com>
---
 xen/arch/arm/arm64/lib/find_next_bit.c    |   8 +-
 xen/include/asm-x86/byteorder.h           |  25 ----
 xen/include/xen/byteorder/big_endian.h    |  12 --
 xen/include/xen/byteorder/little_endian.h |  12 --
 xen/include/xen/byteorder/swab.h          | 164 ++--------------------
 5 files changed, 19 insertions(+), 202 deletions(-)

diff --git a/xen/arch/arm/arm64/lib/find_next_bit.c b/xen/arch/arm/arm64/lib/find_next_bit.c
index 17cb176266..c03eb9d175 100644
--- a/xen/arch/arm/arm64/lib/find_next_bit.c
+++ b/xen/arch/arm/arm64/lib/find_next_bit.c
@@ -167,9 +167,9 @@ EXPORT_SYMBOL(find_first_zero_bit);
 static inline unsigned long ext2_swabp(const unsigned long * x)
 {
 #if BITS_PER_LONG == 64
-	return (unsigned long) __swab64p((u64 *) x);
+	return (unsigned long) swab64p((u64 *) x);
 #elif BITS_PER_LONG == 32
-	return (unsigned long) __swab32p((u32 *) x);
+	return (unsigned long) swab32p((u32 *) x);
 #else
 #error BITS_PER_LONG not defined
 #endif
@@ -179,9 +179,9 @@ static inline unsigned long ext2_swabp(const unsigned long * x)
 static inline unsigned long ext2_swab(const unsigned long y)
 {
 #if BITS_PER_LONG == 64
-	return (unsigned long) __swab64((u64) y);
+	return (unsigned long) swab64((u64) y);
 #elif BITS_PER_LONG == 32
-	return (unsigned long) __swab32((u32) y);
+	return (unsigned long) swab32((u32) y);
 #else
 #error BITS_PER_LONG not defined
 #endif
diff --git a/xen/include/asm-x86/byteorder.h b/xen/include/asm-x86/byteorder.h
index 1f77e502a5..9c26b815b9 100644
--- a/xen/include/asm-x86/byteorder.h
+++ b/xen/include/asm-x86/byteorder.h
@@ -4,31 +4,6 @@
 #include <asm/types.h>
 #include <xen/compiler.h>
 
-static inline __attribute_const__ __u32 ___arch__swab32(__u32 x)
-{
-    asm("bswap %0" : "=r" (x) : "0" (x));
-    return x;
-}
-
-static inline __attribute_const__ __u64 ___arch__swab64(__u64 val)
-{ 
-    union { 
-        struct { __u32 a,b; } s;
-        __u64 u;
-    } v;
-    v.u = val;
-    asm("bswapl %0 ; bswapl %1 ; xchgl %0,%1" 
-        : "=r" (v.s.a), "=r" (v.s.b) 
-        : "0" (v.s.a), "1" (v.s.b)); 
-    return v.u;
-} 
-
-/* Do not define swab16.  Gcc is smart enough to recognize "C" version and
-   convert it into rotation or exhange.  */
-
-#define __arch__swab64(x) ___arch__swab64(x)
-#define __arch__swab32(x) ___arch__swab32(x)
-
 #define __BYTEORDER_HAS_U64__
 
 #include <xen/byteorder/little_endian.h>
diff --git a/xen/include/xen/byteorder/big_endian.h b/xen/include/xen/byteorder/big_endian.h
index 40eb80a390..4d43d9b7b8 100644
--- a/xen/include/xen/byteorder/big_endian.h
+++ b/xen/include/xen/byteorder/big_endian.h
@@ -11,18 +11,6 @@
 #include <xen/types.h>
 #include <xen/byteorder/swab.h>
 
-#define __constant_cpu_to_le64(x) ((__force __le64)___constant_swab64((x)))
-#define __constant_le64_to_cpu(x) ___constant_swab64((__force __u64)(__le64)(x))
-#define __constant_cpu_to_le32(x) ((__force __le32)___constant_swab32((x)))
-#define __constant_le32_to_cpu(x) ___constant_swab32((__force __u32)(__le32)(x))
-#define __constant_cpu_to_le16(x) ((__force __le16)___constant_swab16((x)))
-#define __constant_le16_to_cpu(x) ___constant_swab16((__force __u16)(__le16)(x))
-#define __constant_cpu_to_be64(x) ((__force __be64)(__u64)(x))
-#define __constant_be64_to_cpu(x) ((__force __u64)(__be64)(x))
-#define __constant_cpu_to_be32(x) ((__force __be32)(__u32)(x))
-#define __constant_be32_to_cpu(x) ((__force __u32)(__be32)(x))
-#define __constant_cpu_to_be16(x) ((__force __be16)(__u16)(x))
-#define __constant_be16_to_cpu(x) ((__force __u16)(__be16)(x))
 #define __cpu_to_le64(x) ((__force __le64)__swab64((x)))
 #define __le64_to_cpu(x) __swab64((__force __u64)(__le64)(x))
 #define __cpu_to_le32(x) ((__force __le32)__swab32((x)))
diff --git a/xen/include/xen/byteorder/little_endian.h b/xen/include/xen/byteorder/little_endian.h
index 4955632793..29b0bd2d5c 100644
--- a/xen/include/xen/byteorder/little_endian.h
+++ b/xen/include/xen/byteorder/little_endian.h
@@ -11,18 +11,6 @@
 #include <xen/types.h>
 #include <xen/byteorder/swab.h>
 
-#define __constant_cpu_to_le64(x) ((__force __le64)(__u64)(x))
-#define __constant_le64_to_cpu(x) ((__force __u64)(__le64)(x))
-#define __constant_cpu_to_le32(x) ((__force __le32)(__u32)(x))
-#define __constant_le32_to_cpu(x) ((__force __u32)(__le32)(x))
-#define __constant_cpu_to_le16(x) ((__force __le16)(__u16)(x))
-#define __constant_le16_to_cpu(x) ((__force __u16)(__le16)(x))
-#define __constant_cpu_to_be64(x) ((__force __be64)___constant_swab64((x)))
-#define __constant_be64_to_cpu(x) ___constant_swab64((__force __u64)(__be64)(x))
-#define __constant_cpu_to_be32(x) ((__force __be32)___constant_swab32((x)))
-#define __constant_be32_to_cpu(x) ___constant_swab32((__force __u32)(__be32)(x))
-#define __constant_cpu_to_be16(x) ((__force __be16)___constant_swab16((x)))
-#define __constant_be16_to_cpu(x) ___constant_swab16((__force __u16)(__be16)(x))
 #define __cpu_to_le64(x) ((__force __le64)(__u64)(x))
 #define __le64_to_cpu(x) ((__force __u64)(__le64)(x))
 #define __cpu_to_le32(x) ((__force __le32)(__u32)(x))
diff --git a/xen/include/xen/byteorder/swab.h b/xen/include/xen/byteorder/swab.h
index b7e30f0503..babdbe2387 100644
--- a/xen/include/xen/byteorder/swab.h
+++ b/xen/include/xen/byteorder/swab.h
@@ -10,166 +10,32 @@
  *    to clean up support for bizarre-endian architectures.
  */
 
-/* casts are necessary for constants, because we never know how for sure
- * how U/UL/ULL map to __u16, __u32, __u64. At least not in a portable way.
- */
-#define ___swab16(x)                                    \
-({                                                      \
-    __u16 __x = (x);                                    \
-    ((__u16)(                                           \
-        (((__u16)(__x) & (__u16)0x00ffU) << 8) |        \
-        (((__u16)(__x) & (__u16)0xff00U) >> 8) ));      \
-})
-
-#define ___swab32(x)                                            \
-({                                                              \
-    __u32 __x = (x);                                            \
-    ((__u32)(                                                   \
-        (((__u32)(__x) & (__u32)0x000000ffUL) << 24) |          \
-        (((__u32)(__x) & (__u32)0x0000ff00UL) <<  8) |          \
-        (((__u32)(__x) & (__u32)0x00ff0000UL) >>  8) |          \
-        (((__u32)(__x) & (__u32)0xff000000UL) >> 24) ));        \
-})
+#define __swab16(x)  (__builtin_bswap16(x))
 
-#define ___swab64(x)                                                       \
-({                                                                         \
-    __u64 __x = (x);                                                       \
-    ((__u64)(                                                              \
-        (__u64)(((__u64)(__x) & (__u64)0x00000000000000ffULL) << 56) |     \
-        (__u64)(((__u64)(__x) & (__u64)0x000000000000ff00ULL) << 40) |     \
-        (__u64)(((__u64)(__x) & (__u64)0x0000000000ff0000ULL) << 24) |     \
-        (__u64)(((__u64)(__x) & (__u64)0x00000000ff000000ULL) <<  8) |     \
-            (__u64)(((__u64)(__x) & (__u64)0x000000ff00000000ULL) >>  8) | \
-        (__u64)(((__u64)(__x) & (__u64)0x0000ff0000000000ULL) >> 24) |     \
-        (__u64)(((__u64)(__x) & (__u64)0x00ff000000000000ULL) >> 40) |     \
-        (__u64)(((__u64)(__x) & (__u64)0xff00000000000000ULL) >> 56) ));   \
-})
+#define __swab32(x)  (__builtin_bswap32(x))                                         \
 
-#define ___constant_swab16(x)                   \
-    ((__u16)(                                   \
-        (((__u16)(x) & (__u16)0x00ffU) << 8) |  \
-        (((__u16)(x) & (__u16)0xff00U) >> 8) ))
-#define ___constant_swab32(x)                           \
-    ((__u32)(                                           \
-        (((__u32)(x) & (__u32)0x000000ffUL) << 24) |    \
-        (((__u32)(x) & (__u32)0x0000ff00UL) <<  8) |    \
-        (((__u32)(x) & (__u32)0x00ff0000UL) >>  8) |    \
-        (((__u32)(x) & (__u32)0xff000000UL) >> 24) ))
-#define ___constant_swab64(x)                                            \
-    ((__u64)(                                                            \
-        (__u64)(((__u64)(x) & (__u64)0x00000000000000ffULL) << 56) |     \
-        (__u64)(((__u64)(x) & (__u64)0x000000000000ff00ULL) << 40) |     \
-        (__u64)(((__u64)(x) & (__u64)0x0000000000ff0000ULL) << 24) |     \
-        (__u64)(((__u64)(x) & (__u64)0x00000000ff000000ULL) <<  8) |     \
-            (__u64)(((__u64)(x) & (__u64)0x000000ff00000000ULL) >>  8) | \
-        (__u64)(((__u64)(x) & (__u64)0x0000ff0000000000ULL) >> 24) |     \
-        (__u64)(((__u64)(x) & (__u64)0x00ff000000000000ULL) >> 40) |     \
-        (__u64)(((__u64)(x) & (__u64)0xff00000000000000ULL) >> 56) ))
-
-/*
- * provide defaults when no architecture-specific optimization is detected
- */
-#ifndef __arch__swab16
-#  define __arch__swab16(x) ({ __u16 __tmp = (x) ; ___swab16(__tmp); })
-#endif
-#ifndef __arch__swab32
-#  define __arch__swab32(x) ({ __u32 __tmp = (x) ; ___swab32(__tmp); })
-#endif
-#ifndef __arch__swab64
-#  define __arch__swab64(x) ({ __u64 __tmp = (x) ; ___swab64(__tmp); })
-#endif
+#define __swab64(x)  (__builtin_bswap64(x))                                                     \
 
-#ifndef __arch__swab16p
-#  define __arch__swab16p(x) __arch__swab16(*(x))
+#ifndef __swab16p
+#  define __swab16p(x) __swab16(*(x))
 #endif
-#ifndef __arch__swab32p
-#  define __arch__swab32p(x) __arch__swab32(*(x))
+#ifndef __swab32p
+#  define __swab32p(x) __swab32(*(x))
 #endif
-#ifndef __arch__swab64p
-#  define __arch__swab64p(x) __arch__swab64(*(x))
+#ifndef __swab64p
+#  define __swab64p(x) __swab64(*(x))
 #endif
 
-#ifndef __arch__swab16s
-#  define __arch__swab16s(x) do { *(x) = __arch__swab16p((x)); } while (0)
+#ifndef __swab16s
+#  define __swab16s(x) do { *(x) = __swab16p((x)); } while (0)
 #endif
-#ifndef __arch__swab32s
-#  define __arch__swab32s(x) do { *(x) = __arch__swab32p((x)); } while (0)
+#ifndef __swab32s
+#  define __swab32s(x) do { *(x) = __swab32p((x)); } while (0)
 #endif
-#ifndef __arch__swab64s
-#  define __arch__swab64s(x) do { *(x) = __arch__swab64p((x)); } while (0)
+#ifndef __swab64s
+#  define __swab64s(x) do { *(x) = __swab64p((x)); } while (0)
 #endif
 
-
-/*
- * Allow constant folding
- */
-#if defined(__GNUC__) && defined(__OPTIMIZE__)
-#  define __swab16(x) \
-(__builtin_constant_p((__u16)(x)) ? \
- ___swab16((x)) : \
- __fswab16((x)))
-#  define __swab32(x) \
-(__builtin_constant_p((__u32)(x)) ? \
- ___swab32((x)) : \
- __fswab32((x)))
-#  define __swab64(x) \
-(__builtin_constant_p((__u64)(x)) ? \
- ___swab64((x)) : \
- __fswab64((x)))
-#else
-#  define __swab16(x) __fswab16(x)
-#  define __swab32(x) __fswab32(x)
-#  define __swab64(x) __fswab64(x)
-#endif /* OPTIMIZE */
-
-
-static inline __attribute_const__ __u16 __fswab16(__u16 x)
-{
-    return __arch__swab16(x);
-}
-static inline __u16 __swab16p(const __u16 *x)
-{
-    return __arch__swab16p(x);
-}
-static inline void __swab16s(__u16 *addr)
-{
-    __arch__swab16s(addr);
-}
-
-static inline __attribute_const__ __u32 __fswab32(__u32 x)
-{
-    return __arch__swab32(x);
-}
-static inline __u32 __swab32p(const __u32 *x)
-{
-    return __arch__swab32p(x);
-}
-static inline void __swab32s(__u32 *addr)
-{
-    __arch__swab32s(addr);
-}
-
-#ifdef __BYTEORDER_HAS_U64__
-static inline __attribute_const__ __u64 __fswab64(__u64 x)
-{
-#  ifdef __SWAB_64_THRU_32__
-    __u32 h = x >> 32;
-        __u32 l = x & ((1ULL<<32)-1);
-        return (((__u64)__swab32(l)) << 32) | ((__u64)(__swab32(h)));
-#  else
-    return __arch__swab64(x);
-#  endif
-}
-static inline __u64 __swab64p(const __u64 *x)
-{
-    return __arch__swab64p(x);
-}
-static inline void __swab64s(__u64 *addr)
-{
-    __arch__swab64s(addr);
-}
-#endif /* __BYTEORDER_HAS_U64__ */
-
 #define swab16 __swab16
 #define swab32 __swab32
 #define swab64 __swab64
-- 
2.27.0



From xen-devel-bounces@lists.xenproject.org Fri Oct 15 07:28:17 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 07:28:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.209806.366363 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbHdY-0000nE-Tw; Fri, 15 Oct 2021 07:28:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 209806.366363; Fri, 15 Oct 2021 07:28:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbHdY-0000n7-Qm; Fri, 15 Oct 2021 07:28:16 +0000
Received: by outflank-mailman (input) for mailman id 209806;
 Fri, 15 Oct 2021 07:28:16 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mbHdY-0000mz-0R
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 07:28:16 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mbHdW-00064c-Io; Fri, 15 Oct 2021 07:28:14 +0000
Received: from [54.239.6.185] (helo=[192.168.0.140])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mbHdW-00044C-CE; Fri, 15 Oct 2021 07:28:14 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=aVbNQ2Xos+phCJl4b+tjmV/GubKei39SKO+4D10YkWM=; b=TBPR0hJTsMDrjQT4+Aqj4+Nu0x
	5LiOXjXlJLhezYy3qqOOO2mgHkjzoJXzB1CYLT9niVcIME5KbXlpkqIQvceYMMvfl60kNEemuQm6c
	hg3jCVV5MWNeL97qcVdz0Tc8QXiO8H9+luaG//ARvvqjq21PpgHUsckj9P4HZAq3zJbo=;
Message-ID: <6f82141c-8a0b-1e30-a996-223f7c0c508d@xen.org>
Date: Fri, 15 Oct 2021 08:28:11 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.2.0
Subject: Re: [PATCH v6 3/3] arm/libxl: Emulated PCI device tree node in libxl
 [and 1 more messages]
To: Ian Jackson <iwj@xenproject.org>,
 Bertrand Marquis <Bertrand.Marquis@arm.com>
Cc: xen-devel@lists.xenproject.org, Rahul Singh <rahul.singh@arm.com>,
 Wei Liu <wl@xen.org>, Anthony PERARD <anthony.perard@citrix.com>,
 Juergen Gross <jgross@suse.com>, Stefano Stabellini
 <sstabellini@kernel.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Michal Orzel <michal.orzel@arm.com>, Andre Przywara <Andre.Przywara@arm.com>
References: <cover.1633540842.git.rahul.singh@arm.com>
 <b81b5dea800c8fe47071f3dbd20588b1e472fb99.1633540842.git.rahul.singh@arm.com>
 <7bdac405-a889-15e1-be19-5876f7253855@xen.org>
 <24926.53690.621007.507249@mariner.uk.xensource.com>
 <294BE20A-7E45-405C-BC19-C292295E85E3@arm.com>
 <24927.7235.736221.270358@mariner.uk.xensource.com>
 <8A04B9B2-E816-425E-BF1B-5A8B89F8836C@arm.com>
 <cover.1634221830.git.bertrand.marquis@arm.com>
 <fd9c54a381daa52436b0a1b27cf1bba8e7ff9af9.1634221830.git.bertrand.marquis@arm.com>
 <24936.28385.679884.535704@mariner.uk.xensource.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <24936.28385.679884.535704@mariner.uk.xensource.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Ian,

On 14/10/2021 18:54, Ian Jackson wrote:
> (Replying to both the earlier subthread on v5 and to the new v6
> patch.)
> 
> Bertrand Marquis writes ("Re: [PATCH v5 10/11] arm/libxl: Emulated PCI device tree node in libxl"):
>> Now you suggest to add a new field arm_vpci in libxl__domain_create_state.
> 
> Hi.  I was handwaving, hence "probably" :-).  I hadn't actually looked
> at the existing code to see precisely how it would fit.
> 
>> Once we have done that I will need to access this structure to know if I need
>> to add the DT part and somehow to give it a value depending something which
>> for now would the number of pcidevs as there will be no user parameter anymore.
> 
> Right.
> 
> I looked at libxl_arm.c again:
> 
> It seems that the main entrypoint to all this is libxl__prepare_dtb,
> and it is that function you want to do new stuff.  That gets
> libxl_domain_build_info (which is specified by the IDL and comes from
> outside libxl, subject to libxl's default-filling machinery) and
> libxl__domain_build_state (which is the general state struct).
> 
> The information you need is is libxl_domain_create_info.
> libxl__domain_config_setdefault already arranges to set
> c_info->passthrough based on the number of PCI PT devices
> (search for `need_pt` in libxl_create.c).
> 
> That is, as I understand it on ARM vpci should be enabled if
> passthrough is enabled and not otherwise.  That is precisely what
> the variable c_info->passthrough is.

On Arm, c_info->passthrough is also set when assigning platform devives 
(e.g. a non-PCI network card). At least for now, we don't want to create 
a node for vCPI in the Device-Tree because we don't enable the 
emulation. So...

> 
> There is a slight issue because of the distinction between create_info
> and build_info and domain_config (and, the corresponding _state)
> structs.  Currently the DT code ony gets b_info, not the whole
> libxl_domain_config.  These distinctions largely historical nowadays.
> Certainly there is no reason not to pass a pointer to the whole
> libxl_domain_config, rather than just libxl_domain_build_info, into
> libxl__arch_domain_init_hw_description.
> 
> So I think the right approach for this looks something like this:
> 
> 1. Change libxl__arch_domain_init_hw_description to take
>     libxl_domain_config* rather than libxl_domain_build_info*.
>     libxl_domain_config contains libxl_domain_build_info so
>     this is easy.
> 
>     If you put in a convenience alias variable for the
>     libxl_domain_build_info* you can avoid extra typing in the function
>     body.  (If you call the convenience alias `info` you won't need to
>     change the body at all, but maybe `info` isn't the best name so you
>     could rename it to `b_info` maybe; up to you.)
> 
> 2. Make the same change to libxl__prepare_dtb.
> 
> 3. Now you can use d_config->c_info.passthrough to gate the addition
>     of the additional stuff to the DT.  Ie, that is a respin of this
>     patch 3/3.

... we will need to check d_config->num_pcidevs for the time being.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Oct 15 07:37:27 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 07:37:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.209817.366375 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbHmO-0002J5-PV; Fri, 15 Oct 2021 07:37:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 209817.366375; Fri, 15 Oct 2021 07:37:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbHmO-0002Iy-MQ; Fri, 15 Oct 2021 07:37:24 +0000
Received: by outflank-mailman (input) for mailman id 209817;
 Fri, 15 Oct 2021 07:37:23 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Fqmt=PD=arm.com=Bertrand.Marquis@srs-us1.protection.inumbo.net>)
 id 1mbHmN-0002Is-6a
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 07:37:23 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com (unknown
 [40.107.8.43]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 267f1e6c-7047-4b0a-8f19-5756a44f13c9;
 Fri, 15 Oct 2021 07:37:20 +0000 (UTC)
Received: from AM6P194CA0025.EURP194.PROD.OUTLOOK.COM (2603:10a6:209:90::38)
 by AS8PR08MB5911.eurprd08.prod.outlook.com (2603:10a6:20b:292::17) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16; Fri, 15 Oct
 2021 07:37:19 +0000
Received: from VE1EUR03FT027.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:209:90:cafe::b) by AM6P194CA0025.outlook.office365.com
 (2603:10a6:209:90::38) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15 via Frontend
 Transport; Fri, 15 Oct 2021 07:37:19 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT027.mail.protection.outlook.com (10.152.18.154) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.15 via Frontend Transport; Fri, 15 Oct 2021 07:37:18 +0000
Received: ("Tessian outbound 16951d3c485e:v103");
 Fri, 15 Oct 2021 07:37:18 +0000
Received: from 9903171d10be.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 ED378D35-F64A-446C-B4D3-8FDD70252514.1; 
 Fri, 15 Oct 2021 07:37:11 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 9903171d10be.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 15 Oct 2021 07:37:11 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com (2603:10a6:4:74::9)
 by DB9PR08MB6714.eurprd08.prod.outlook.com (2603:10a6:10:2a4::18) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16; Fri, 15 Oct
 2021 07:37:10 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955]) by DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955%4]) with mapi id 15.20.4587.031; Fri, 15 Oct 2021
 07:37:10 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 267f1e6c-7047-4b0a-8f19-5756a44f13c9
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=8oIQyPXfJivnZ1dnrFTnqt8GoLhD7FLWCK9WSsvURTM=;
 b=QrNcigs8sgR+GvBFUlQSw8aEmyrZHRqD5YpfQiEBQjQeTEAVN9gSwTY3HhQZvJgiyrmRh0D2oapaR8FcGeSXWQyMWYkI+qiEtKIUTIfz2ovAOqGyLIQv8b5xo/8OBEjLDQYCYaDkgzd9BtsZFKqIKbkK9ZBfNDqgFarZV4Q9Q8o=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: f107c22a5169b342
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=E6v1ARB+j8HFeIk0mZY5s3YMdhudOvZeCpnh9sTxEeKteyfmMsF3KhnHgfQUVksyX+xwrkyId49anViRkcEUEfrqzBkpun0H60lZj33iuO/wFxqEdrhF7Cu93AJBQYBvFyOe/3+nMinR7Ilc5s+1KSkDyAAAMQXKYciQHuTg/A3GijK2M+DXAu6v4BcrVftcsG3xg2n1NdixSb6G2J1sU4/ya697t7N30LocU2IWkB8myMu0TOSKAlhqRi9aK+3xQplgdYFmd40tsTYmcc06rH3H2OIH2fQkQAWFaTGhlL5bBtAf65kTFc0A9UpgjIJ0TkTCdiCl78PWR09EyQwKvw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=8oIQyPXfJivnZ1dnrFTnqt8GoLhD7FLWCK9WSsvURTM=;
 b=nGdN2r/W7K6dES864SRJvCMiIMHV31+Apn6tVfDPejqGjxE33DFneX6ec4gE3LcnnBr9zhublbA+Ql9gyMfnhWhgenD/2ivrwZsw2xUyeNskUFOtkAAM37DBEPXPjQnTwmZ1RFhXaoGM7GHL7knyotqLfge4Nc4InKw1QUhmqHzYr6mX93vD0eXs+1kolPnAYFp9YAAhITTIAkNjD9T1zXjAemeHgIAmEJIuajMSRLVT9IN7O18SidWVm1EzRu06Crot/5XTyXzqCDzVO9clelqaMMPbijUApRwqfBoCdjrg93fLpUTt0fwwEr4khLRLFWxdi5odlCksu2SxgU+1UA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=8oIQyPXfJivnZ1dnrFTnqt8GoLhD7FLWCK9WSsvURTM=;
 b=QrNcigs8sgR+GvBFUlQSw8aEmyrZHRqD5YpfQiEBQjQeTEAVN9gSwTY3HhQZvJgiyrmRh0D2oapaR8FcGeSXWQyMWYkI+qiEtKIUTIfz2ovAOqGyLIQv8b5xo/8OBEjLDQYCYaDkgzd9BtsZFKqIKbkK9ZBfNDqgFarZV4Q9Q8o=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Ian Jackson <iwj@xenproject.org>, Paul Durrant <paul@xen.org>, Andrew
 Cooper <andrew.cooper3@citrix.com>, =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?=
	<roger.pau@citrix.com>, Wei Liu <wl@xen.org>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Julien
 Grall <julien@xen.org>
Subject: Re: [PATCH v6 1/3] xen/vpci: Move ecam access functions to common
 code
Thread-Topic: [PATCH v6 1/3] xen/vpci: Move ecam access functions to common
 code
Thread-Index: AQHXwQraA42SZeh0QUGI/xX7keuWA6vSqLgAgAARnQCAAN+ngIAAEtoA
Date: Fri, 15 Oct 2021 07:37:10 +0000
Message-ID: <152124C4-9A34-4F5B-B6C5-CBCC6A175665@arm.com>
References: <cover.1634221830.git.bertrand.marquis@arm.com>
 <ced6f870dbfabcfe8584555cc80f9a37a0655a0c.1634221830.git.bertrand.marquis@arm.com>
 <20c73f4e-5a8b-c127-f3a7-b841f50b1a4a@suse.com>
 <6C71E132-0A78-4DA4-AA52-E62833912145@arm.com>
 <8a7d1370-ee58-8e95-efea-8e4162e1e5f7@suse.com>
In-Reply-To: <8a7d1370-ee58-8e95-efea-8e4162e1e5f7@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3654.120.0.1.13)
Authentication-Results-Original: suse.com; dkim=none (message not signed)
 header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: a737e4a7-583b-4de1-c245-08d98fae9e1b
x-ms-traffictypediagnostic: DB9PR08MB6714:|AS8PR08MB5911:
X-Microsoft-Antispam-PRVS:
	<AS8PR08MB5911CD58DD554C11B42EC3829DB99@AS8PR08MB5911.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:10000;OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 N4khH6ZKb3X2FxpcNN2QoNxmdJ3TkIkTgsRwPgs9w5XWI1Qda9CtC5vc7AhIQvKgT6sKgDEz5+aIYeDuc0qNe1U1rK7+3i3UbVP78a0P2X9StwI0+wk2jeny1PM4JgJaSgZaoCb4JGzHD+cqhvmT2d7Hseu1u1uo8ohxqg4XQVNcW0dSHYEI9SQxLXaS4kWXk5Zgk324fCpjSUcOFXa0E+dS6p6I3EDl0panC7RTN414bPNrTVY+grsS4kX9OOsTsU2eGZsxLQ/mxmLuDcNFxZQS2elwTt2ObVb0pUfLh1AmlsthXcV5+zAKIDiW9aNe748I+Q0NGV2SYNKf2zPCWdrGimk7D2wRBFtWWHtt6NL0Ofy0AXF+M9m4CqS+PHRKRTAiFdZqIGFvqiYFu8I8tkgMuSLcEaATePOKHaiGLmPRoPORFWgW5S7liSIxKNSu+yo5QMV468olTNcVcFXwKJmS6Cc2vZsbUL2joksbL4lvCQ0z01C10krZEfvrsq4wv4um9YsbMe+ldi7dzkHpIlKRh6GfTbpSQfAPqBtFGLGzaHVPPAVVp5hNl7b401HRlkp+Mrs/88lckwu78CLO3m3K3WC8fXIH3wPep4xYtiBHPCa3Gc1epyAYCnxCdiXXbJcaR6DwqGTc/IhW8ji5dgBky9BSa587uzu1chiuzPwO0LTYbWPG/RVeSlPzL35GQb39m46rJ6MuCzI9KIVmC61D164T2mcFpkgO4dGRZACEMc4bZM8/jSyD9yxzzRDs
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB6PR0801MB2024.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(26005)(6916009)(64756008)(71200400001)(66446008)(2616005)(66556008)(8936002)(8676002)(66476007)(66946007)(91956017)(76116006)(6512007)(6486002)(83380400001)(186003)(36756003)(508600001)(33656002)(38070700005)(4326008)(122000001)(38100700002)(53546011)(6506007)(86362001)(5660300002)(2906002)(316002)(54906003)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="utf-8"
Content-ID: <FBB84D16667FEA458E088FF39C2B19D6@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB6714
Original-Authentication-Results: suse.com; dkim=none (message not signed)
 header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT027.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	9b74dac2-c93f-4c54-1ca4-08d98fae9955
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	lRyUhyZI7zrz5w/SRye/AUP+/lbMyTdjEd3aQ79h5FgvnZWgIRMndIivXBpKALMW5vWslYSNNPG84WSWEgFSZyuKk/Q+457cOBDW220PO50jzt+bQNn5czUl9SaDDTx/5JC4ECpYXl8kuDyCZ69+zgYm/rWkXwPl/+juljIC+x/ANLh2sJpPGejVWi56LMN2xWF2Rynsu+1Cor7WpaKFwyRA1NoBNA9ZJpVFWp/ez2SpR5N6ievk7PHc00CqWwdmPYjaSnaW94OwK4YSJjKgzZHABvxwR7oXW/9PscocJpkH3S6Y3rP+rXmKZVyNJGuE/jRYMwe4iwWQV8SV6KQ9FtCXsccX9y8frLbooOh5FVFfkqr3qykUqYEmDC7WEJar5JzfVtzfHZ8DKTIWZjOLxJutyjqXRENGbttfu/vhx2YxDQHzVJer6kMAE39RLkOsfZxL24+RzBBWdYop91IB4UcvudZZKthDWmtzEzYUOxi98zroNGzJXqrg2iVSXnXcQx4wbzeq+yOCj9x+qRIZjyclWP/71+ixPPP/zguRq3XWE6Cy5Ggb0FwC4SYFYqJ7MS7hVi65qTkPoWV4vSWR8E2l1CkVr+aq+SRrl/Gw3qcpLv1X8vE38Xmz82+AbuiAqQ/gB2ZZ8DPJmiUjQrPPUT2MC//G2IV4oaSy3Xthc13Y+ncTaLO272yYFZWGWL6Rzx2qLzJLoebtQ+Byz4g0BQ==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(36860700001)(6512007)(5660300002)(36756003)(6862004)(54906003)(336012)(186003)(316002)(82310400003)(8676002)(70586007)(2906002)(70206006)(86362001)(83380400001)(4326008)(508600001)(8936002)(26005)(81166007)(6506007)(47076005)(356005)(2616005)(33656002)(6486002)(53546011);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2021 07:37:18.7867
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: a737e4a7-583b-4de1-c245-08d98fae9e1b
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT027.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB5911

SGkgSmFuLA0KDQo+IE9uIDE1IE9jdCAyMDIxLCBhdCAwNzoyOSwgSmFuIEJldWxpY2ggPGpiZXVs
aWNoQHN1c2UuY29tPiB3cm90ZToNCj4gDQo+IE9uIDE0LjEwLjIwMjEgMTk6MDksIEJlcnRyYW5k
IE1hcnF1aXMgd3JvdGU6DQo+Pj4gT24gMTQgT2N0IDIwMjEsIGF0IDE3OjA2LCBKYW4gQmV1bGlj
aCA8amJldWxpY2hAc3VzZS5jb20+IHdyb3RlOg0KPj4+IE9uIDE0LjEwLjIwMjEgMTY6NDksIEJl
cnRyYW5kIE1hcnF1aXMgd3JvdGU6DQo+Pj4+IEBAIC0zMDUsNyArMjkxLDcgQEAgc3RhdGljIGlu
dCB2cGNpX3BvcnRpb19yZWFkKGNvbnN0IHN0cnVjdCBodm1faW9faGFuZGxlciAqaGFuZGxlciwN
Cj4+Pj4gDQo+Pj4+ICAgIHJlZyA9IGh2bV9wY2lfZGVjb2RlX2FkZHIoY2Y4LCBhZGRyLCAmc2Jk
Zik7DQo+Pj4+IA0KPj4+PiAtICAgIGlmICggIXZwY2lfYWNjZXNzX2FsbG93ZWQocmVnLCBzaXpl
KSApDQo+Pj4+ICsgICAgaWYgKCAhdnBjaV9lY2FtX2FjY2Vzc19hbGxvd2VkKHJlZywgc2l6ZSkg
KQ0KPj4+PiAgICAgICAgcmV0dXJuIFg4NkVNVUxfT0tBWTsNCj4+Pj4gDQo+Pj4+ICAgICpkYXRh
ID0gdnBjaV9yZWFkKHNiZGYsIHJlZywgc2l6ZSk7DQo+Pj4+IEBAIC0zMzUsNyArMzIxLDcgQEAg
c3RhdGljIGludCB2cGNpX3BvcnRpb193cml0ZShjb25zdCBzdHJ1Y3QgaHZtX2lvX2hhbmRsZXIg
KmhhbmRsZXIsDQo+Pj4+IA0KPj4+PiAgICByZWcgPSBodm1fcGNpX2RlY29kZV9hZGRyKGNmOCwg
YWRkciwgJnNiZGYpOw0KPj4+PiANCj4+Pj4gLSAgICBpZiAoICF2cGNpX2FjY2Vzc19hbGxvd2Vk
KHJlZywgc2l6ZSkgKQ0KPj4+PiArICAgIGlmICggIXZwY2lfZWNhbV9hY2Nlc3NfYWxsb3dlZChy
ZWcsIHNpemUpICkNCj4+Pj4gICAgICAgIHJldHVybiBYODZFTVVMX09LQVk7DQo+Pj4+IA0KPj4+
PiAgICB2cGNpX3dyaXRlKHNiZGYsIHJlZywgc2l6ZSwgZGF0YSk7DQo+Pj4gDQo+Pj4gV2h5IHdv
dWxkIHBvcnQgSS9PIGZ1bmN0aW9ucyBjYWxsIGFuIEVDQU0gaGVscGVyPyBBbmQgaW4gaG93IGZh
ciBpcw0KPj4+IHRoYXQgaGVscGVyIGFjdHVhbGx5IEVDQU0tc3BlY2lmaWM/DQo+PiANCj4+IFRo
ZSBmdW5jdGlvbiB3YXMgZ2xvYmFsIGJlZm9yZS4NCj4gDQo+IEknbSBub3Qgb2JqZWN0aW5nIHRv
IHRoZSBmdW5jdGlvbiBiZWluZyBnbG9iYWwsIGJ1dCB0byB0aGUgImVjYW0iIGluDQo+IGl0cyBu
YW1lLg0KDQpBZGRpbmcgZWNhbSBpbiB0aGUgbmFtZSB3YXMgYSByZXF1ZXN0IGZyb20gUm9nZXIu
DQpUaGlzIGlzIGp1c3QgYSBjb25zZXF1ZW5jZSBvZiB0aGlzLg0KDQpPbmUgc3VnZ2VzdGlvbiBo
ZXJlIGNvdWxkIGJlIHRvIHR1cm4gdnBjaV9lY2FtX2FjY2Vzc19hbGxvd2VkIGludG8gdnBjaV9h
Y2Nlc3NfYWxsb3dlZCBhbmQgbWF5YmUgcHV0IHRoaXMgaW50byB2cGNpLmggYXMgYSBzdGF0aWMg
aW5saW5lID8NCg0KPiANCj4+Pj4gQEAgLTQzNCwyNSArNDIwLDggQEAgc3RhdGljIGludCB2cGNp
X21tY2ZnX3JlYWQoc3RydWN0IHZjcHUgKnYsIHVuc2lnbmVkIGxvbmcgYWRkciwNCj4+Pj4gICAg
cmVnID0gdnBjaV9tbWNmZ19kZWNvZGVfYWRkcihtbWNmZywgYWRkciwgJnNiZGYpOw0KPj4+PiAg
ICByZWFkX3VubG9jaygmZC0+YXJjaC5odm0ubW1jZmdfbG9jayk7DQo+Pj4+IA0KPj4+PiAtICAg
IGlmICggIXZwY2lfYWNjZXNzX2FsbG93ZWQocmVnLCBsZW4pIHx8DQo+Pj4+IC0gICAgICAgICAo
cmVnICsgbGVuKSA+IFBDSV9DRkdfU1BBQ0VfRVhQX1NJWkUgKQ0KPj4+PiAtICAgICAgICByZXR1
cm4gWDg2RU1VTF9PS0FZOw0KPj4+IA0KPj4+IFdoaWxlIEkgYXNzdW1lIHRoaXMgZWFybGllciBi
ZWhhdmlvciBpcyB0aGUgcmVhc29uIGZvciAuLi4NCj4+IA0KPj4gWWVzIDotKQ0KPj4gDQo+Pj4g
DQo+Pj4+IC0gICAgLyoNCj4+Pj4gLSAgICAgKiBBY2NvcmRpbmcgdG8gdGhlIFBDSWUgMy4xQSBz
cGVjaWZpY2F0aW9uOg0KPj4+PiAtICAgICAqICAtIENvbmZpZ3VyYXRpb24gUmVhZHMgYW5kIFdy
aXRlcyBtdXN0IHVzdWFsbHkgYmUgRFdPUkQgb3Igc21hbGxlcg0KPj4+PiAtICAgICAqICAgIGlu
IHNpemUuDQo+Pj4+IC0gICAgICogIC0gQmVjYXVzZSBSb290IENvbXBsZXggaW1wbGVtZW50YXRp
b25zIGFyZSBub3QgcmVxdWlyZWQgdG8gc3VwcG9ydA0KPj4+PiAtICAgICAqICAgIGFjY2Vzc2Vz
IHRvIGEgUkNSQiB0aGF0IGNyb3NzIERXIGJvdW5kYXJpZXMgWy4uLl0gc29mdHdhcmUNCj4+Pj4g
LSAgICAgKiAgICBzaG91bGQgdGFrZSBjYXJlIG5vdCB0byBjYXVzZSB0aGUgZ2VuZXJhdGlvbiBv
ZiBzdWNoIGFjY2Vzc2VzDQo+Pj4+IC0gICAgICogICAgd2hlbiBhY2Nlc3NpbmcgYSBSQ1JCIHVu
bGVzcyB0aGUgUm9vdCBDb21wbGV4IHdpbGwgc3VwcG9ydCB0aGUNCj4+Pj4gLSAgICAgKiAgICBh
Y2Nlc3MuDQo+Pj4+IC0gICAgICogIFhlbiBob3dldmVyIHN1cHBvcnRzIDhieXRlIGFjY2Vzc2Vz
IGJ5IHNwbGl0dGluZyB0aGVtIGludG8gdHdvDQo+Pj4+IC0gICAgICogIDRieXRlIGFjY2Vzc2Vz
Lg0KPj4+PiAtICAgICAqLw0KPj4+PiAtICAgICpkYXRhID0gdnBjaV9yZWFkKHNiZGYsIHJlZywg
bWluKDR1LCBsZW4pKTsNCj4+Pj4gLSAgICBpZiAoIGxlbiA9PSA4ICkNCj4+Pj4gLSAgICAgICAg
KmRhdGEgfD0gKHVpbnQ2NF90KXZwY2lfcmVhZChzYmRmLCByZWcgKyA0LCA0KSA8PCAzMjsNCj4+
Pj4gKyAgICAvKiBJZ25vcmUgcmV0dXJuIGNvZGUgKi8NCj4+Pj4gKyAgICB2cGNpX2VjYW1fbW1p
b19yZWFkKHNiZGYsIHJlZywgbGVuLCBkYXRhKTsNCj4+PiANCj4+PiAuLi4gdGhlIGNvbW1lbnRl
ZC11cG9uIGlnbm9yaW5nIG9mIHRoZSByZXR1cm4gdmFsdWUsIEkgZG9uJ3QgdGhpbmsNCj4+PiB0
aGF0J3MgYSBnb29kIHdheSB0byBkZWFsIHdpdGggdGhpbmdzIGFueW1vcmUuIEluc3RlYWQgSSB0
aGluaw0KPj4+ICpkYXRhIHNob3VsZCBiZSB3cml0dGVuIHRvIH4wIHVwb24gZmFpbHVyZSwgdW5s
ZXNzIGl0IGlzIGludGVuZGVkDQo+Pj4gZm9yIHZwY2lfZWNhbV9tbWlvX3JlYWQoKSB0byB0YWtl
IGNhcmUgb2YgdGhhdCBjYXNlIChpbiB3aGljaCBjYXNlDQo+Pj4gSSdtIG5vdCBzdXJlIEkgd291
bGQgc2VlIHdoeSBpdCBuZWVkcyB0byByZXR1cm4gYW4gZXJyb3IgaW5kaWNhdG9yDQo+Pj4gaW4g
dGhlIGZpcnN0IHBsYWNlKS4NCj4+IA0KPj4gSSBhbSBub3Qgc3VyZSBpbiB0aGUgZmlyc3QgcGxh
Y2Ugd2h5IHRoaXMgaXMgYWN0dWFsbHkgaWdub3JlZCBhbmQganVzdA0KPj4gcmV0dXJuaW5nIGEg
LTEgdmFsdWUuDQo+PiBJZiBhbiBhY2Nlc3MgaXMgbm90IHJpZ2h0LCBhbiBleGNlcHRpb24gc2hv
dWxkIGJlIGdlbmVyYXRlZCB0byB0aGUNCj4+IEd1ZXN0IGluc3RlYWQuDQo+IA0KPiBOby4gVGhh
dCdzIGFsc28gbm90IHdoYXQgaGFwcGVucyBvbiBiYXJlIG1ldGFsLCBhdCBsZWFzdCBub3Qgb24g
eDg2Lg0KPiBGYXVsdHMgY2Fubm90IGJlIHJhaXNlZCBmb3IgcmVhc29ucyBvdXRzaWRlIG9mIHRo
ZSBDUFU7IHN1Y2ggZXJyb3JzDQo+IChpZiB0aGVzZSBhcmUgZXJyb3JzIGluIHRoZSBmaXJzdCBw
bGFjZSkgbmVlZCB0byBiZSBkZWFsdCB3aXRoDQo+IGRpZmZlcmVudGx5LiBTaWduYWxpbmcgYW4g
ZXJyb3Igb24gdGhlIFBDSSBidXMgd291bGQgYmUgcG9zc2libGUsDQo+IGJ1dCB3b3VsZCBsZWF2
ZSBvcGVuIGhvdyB0aGF0J3MgYWN0dWFsbHkgdG8gYmUgZGVhbHQgd2l0aC4gSW5zdGVhZA0KPiBi
YWQgcmVhZHMgcmV0dXJuIGFsbCBvbmVzLCB3aGlsZSBiYWQgd3JpdGVzIHNpbXBseSBnZXQgZHJv
cHBlZC4NCg0KU28gdGhhdCBiZWhhdmlvdXIgaXMga2VwdCBoZXJlIG9uIHg4NiBhbmQgSSB0aGlu
ayBhcyB0aGUgZnVuY3Rpb24gaXMNCmdlbmVyaWMgaXQgaXMgcmlnaHQgZm9yIGl0IHRvIHJldHVy
biBhbiBlcnJvciBoZXJlLiBJdCBpcyB1cCB0byB0aGUgY2FsbGVyIHRvDQppZ25vcmUgaXQgb3Ig
bm90Lg0KVG8gbWFrZSB0aGlzIG1vcmUgZ2VuZXJpYyBJIGNvdWxkIHJldHVybiAwIG9uIHN1Y2Nl
c3MgYW5kIC1FQUNDRVNTLA0KdGhlIGNhbGxlciB3b3VsZCB0aGVuIGhhbmRsZSBpdCBhcyBoZSB3
YW50cy4NCg0KPiANCj4+IFdoZW4gd2UgZG8gdGhhdCBvbiBhcm0gdGhlIGZ1bmN0aW9uIGlzIHJl
dHVybmluZyBhbiBlcnJvciB0byB0aGUgdXBwZXINCj4+IGxheWVyIGluIHRoYXQgY2FzZSwgdGhh
dOKAmXMgd2h5IEkgZGlkIGtlZXAgYSBnZW5lcmljIGZ1bmN0aW9uIGluZm9ybWluZyB0aGUNCj4+
IGNhbGxlci4NCj4gDQo+IFdoaWxlIHlvdSdyZSB0aGUgQXJtIGV4cGVydCwgd2l0aCB0aGUgYWJv
dmUgaW4gbWluZCBJIHdvbmRlciB3aGF0DQo+IHRoZSBhY3R1YWwgYWN0aW9uIGluIHRoYXQgY2Fz
ZSBvdWdodCB0byBiZSB0aGVyZS4gV291bGQgeW91IGV4cGxhaW4NCj4gdG8gbWUgaG93LCBzYXks
IGEgbWlzYWxpZ25lZCAyLWJ5dGUgcmVhZCB0aGF0IHRoZSBDUFUgcGVybWl0cyBidXQNCj4gdGhl
IFBDSSBzdWJzeXN0ZW0gZG9lc24ndCBsaWtlIHdvdWxkIGJlIGRlYWx0IHdpdGggYnkgYmFyZSBt
ZXRhbD8NCg0KVGhlIGhhcmR3YXJlIHdpbGwgcHJvYmFibHkgcmV0dXJuIGEgQlVTIGVycm9yIGFz
IHRoZSBhY2Nlc3MgZGlkIG5vdA0Kd29yay4gQnV0IHRoZSBDUFUgbWlnaHQganVzdCBwcmV2ZW50
IHVuYWxpZ25lZCBtbWlvIGFjY2VzcyBvbiB0aGUNCmZpcnN0IHBsYWNlLg0KQGp1bGllbjogTWF5
YmUgeW91IGtub3cgdGhhdCBvbmUgPyBPdGhlcndpc2UgSSBjYW4gZGlnIHRvIG1ha2Ugc3VyZQ0K
SSBhbnN3ZXIgdGhhdCByaWdodC4NCg0KPiANCj4+Pj4gQEAgLTQ3NiwxMyArNDQ1LDggQEAgc3Rh
dGljIGludCB2cGNpX21tY2ZnX3dyaXRlKHN0cnVjdCB2Y3B1ICp2LCB1bnNpZ25lZCBsb25nIGFk
ZHIsDQo+Pj4+ICAgIHJlZyA9IHZwY2lfbW1jZmdfZGVjb2RlX2FkZHIobW1jZmcsIGFkZHIsICZz
YmRmKTsNCj4+Pj4gICAgcmVhZF91bmxvY2soJmQtPmFyY2guaHZtLm1tY2ZnX2xvY2spOw0KPj4+
PiANCj4+Pj4gLSAgICBpZiAoICF2cGNpX2FjY2Vzc19hbGxvd2VkKHJlZywgbGVuKSB8fA0KPj4+
PiAtICAgICAgICAgKHJlZyArIGxlbikgPiBQQ0lfQ0ZHX1NQQUNFX0VYUF9TSVpFICkNCj4+Pj4g
LSAgICAgICAgcmV0dXJuIFg4NkVNVUxfT0tBWTsNCj4+Pj4gLQ0KPj4+PiAtICAgIHZwY2lfd3Jp
dGUoc2JkZiwgcmVnLCBtaW4oNHUsIGxlbiksIGRhdGEpOw0KPj4+PiAtICAgIGlmICggbGVuID09
IDggKQ0KPj4+PiAtICAgICAgICB2cGNpX3dyaXRlKHNiZGYsIHJlZyArIDQsIDQsIGRhdGEgPj4g
MzIpOw0KPj4+PiArICAgIC8qIElnbm9yZSByZXR1cm4gY29kZSAqLw0KPj4+PiArICAgIHZwY2lf
ZWNhbV9tbWlvX3dyaXRlKHNiZGYsIHJlZywgbGVuLCBkYXRhKTsNCj4+PiANCj4+PiBIZXJlIGln
bm9yaW5nIGlzIGZpbmUgaW1vLCBidXQgaWYgeW91IGZlZWwgaXQgaXMgaW1wb3J0YW50IHRvDQo+
Pj4gY29tbWVudCBvbiB0aGlzLCB0aGVuIEkgdGhpbmsgeW91IG5lZWQgdG8gcHJlZmVyICJ3aHki
IG92ZXIgIndoYXQiLg0KPj4gDQo+PiBBZ3JlZSBJIHdvdWxkIGp1c3QgbmVlZCBzb21lIGhlbHAg
b24gdGhlIHdoeS4NCj4+IE5vdyB0aGVyZSB3YXMgbm8gY29tbWVudCBiZWZvcmUgdG8gZXhwbGFp
biB3aHkgc28gSSBjb3VsZCBhbHNvDQo+PiByZW1vdmUgdGhlIGNvbW1lbnQgYWx0b2dldGhlci4N
Cj4gDQo+IFRoZSBsYXR0ZXIgd291bGQgYmUgbXkgcHJlZmVyZW5jZS4NCg0KT2sgSSB3aWxsIGRv
IHRoYXQuDQoNCj4gDQo+Pj4+IC0tLSBhL3hlbi9kcml2ZXJzL3ZwY2kvdnBjaS5jDQo+Pj4+ICsr
KyBiL3hlbi9kcml2ZXJzL3ZwY2kvdnBjaS5jDQo+Pj4+IEBAIC00NzgsNiArNDc4LDY2IEBAIHZv
aWQgdnBjaV93cml0ZShwY2lfc2JkZl90IHNiZGYsIHVuc2lnbmVkIGludCByZWcsIHVuc2lnbmVk
IGludCBzaXplLA0KPj4+PiAgICBzcGluX3VubG9jaygmcGRldi0+dnBjaS0+bG9jayk7DQo+Pj4+
IH0NCj4+Pj4gDQo+Pj4+ICsvKiBIZWxwZXIgZnVuY3Rpb24gdG8gY2hlY2sgYW4gYWNjZXNzIHNp
emUgYW5kIGFsaWdubWVudCBvbiB2cGNpIHNwYWNlLiAqLw0KPj4+PiArYm9vbCB2cGNpX2VjYW1f
YWNjZXNzX2FsbG93ZWQodW5zaWduZWQgaW50IHJlZywgdW5zaWduZWQgaW50IGxlbikNCj4+Pj4g
K3sNCj4+Pj4gKyAgICAvKg0KPj4+PiArICAgICAqIENoZWNrIGFjY2VzcyBzaXplLg0KPj4+PiAr
ICAgICAqDQo+Pj4+ICsgICAgICogT24gYXJtMzIgb3IgZm9yIDMyYml0IGd1ZXN0cyBvbiBhcm0s
IDY0Yml0IGFjY2Vzc2VzIHNob3VsZCBiZSBmb3JiaWRkZW4NCj4+Pj4gKyAgICAgKiBidXQgYXMg
Zm9yIHRob3NlIHBsYXRmb3JtIElTViByZWdpc3Rlciwgd2hpY2ggZ2l2ZXMgdGhlIGFjY2VzcyBz
aXplLA0KPj4+PiArICAgICAqIGNhbm5vdCBoYXZlIGEgdmFsdWUgMywgY2hlY2tpbmcgdGhpcyB3
b3VsZCBqdXN0IGhhcmRlbiB0aGUgY29kZS4NCj4+Pj4gKyAgICAgKi8NCj4+Pj4gKyAgICBpZiAo
IGxlbiAhPSAxICYmIGxlbiAhPSAyICYmIGxlbiAhPSA0ICYmIGxlbiAhPSA4ICkNCj4+Pj4gKyAg
ICAgICAgcmV0dXJuIGZhbHNlOw0KPj4+IA0KPj4+IEknbSBub3QgY29udmluY2VkIHRhbGtpbmcg
YWJvdXQgQXJtIHNwZWNpZmljYWxseSBoZXJlIGlzDQo+Pj4gd2FycmFudGVkLCB1bmxlc3MgdGhl
cmUncyBzb21ldGhpbmcgdGhlcmUgdGhhdCdzIGNsZWFybHkNCj4+PiBkaWZmZXJlbnQgZnJvbSBh
bGwgb3RoZXIgYXJjaGl0ZWN0dXJlcy4gT3RoZXJ3aXNlIHRoZSBjb21tZW50DQo+Pj4gc2hvdWxk
IGltbyBiZSB3cml0dGVuIGluIG1vcmUgZ2VuZXJhbCB0ZXJtcy4NCj4+IA0KPj4gT3RoZXIgYXJj
aGl0ZWN0dXJlcyBtaWdodCBhbGxvdyB0aGlzIGNhc2UuIFNvIHRoaXMgaXMgc3BlY2lmaWMgdG8g
QXJtLg0KPiANCj4gSWYgaXQgcmVhbGx5IGlzLCBJIGNvbnNpZGVyIGl0IHdyb25nIHRvIGxpdmUg
aW4gY29tbW9uIGNvZGUuIElmDQo+IHBlci1hcmNoIHR3ZWFraW5nIGlzIG5lY2Vzc2FyeSwgYW5k
IGlmIGVhcmxpZXIgaGFuZGxpbmcgb2YgdGhlDQo+IGludGVyY2VwdGVkIGFjY2VzcyBkb2Vzbid0
IGFscmVhZHkgZXhjbHVkZSAiYmFkIiBjYXNlcywgdGhlbiBhDQo+IHBlci1hcmNoIGhvb2sgd291
bGQgaW1vIGJlIHRoZSB3YXkgdG8gZ28gaGVyZS4gR2l2ZW4gdGhlIHNpemUNCj4gb2YgdGhlIGZ1
bmN0aW9uIEkgd291bGQgdGhlbiB3b25kZXIgd2h5IGl0IGRvZXNuJ3QgcmVtYWluIHBlci0NCj4g
YXJjaCBpbiB0aGUgZmlyc3QgcGxhY2UuDQoNClRvIGhhdmUgdGhpcyBpbiBjb21tb24gY29kZSB3
YXMgYSByZXF1ZXN0IGZyb20gUm9nZXIgYW5kIGFzDQpUaGUgY29kZSBpcyB0aGUgc2FtZSBJIHRo
aW5rIHRoYXQgaXMgb2suDQpJIHN1Z2dlc3RlZCBiZWZvcmUgdG8gdHVybiB0aGlzIGludG8gYSBz
dGF0aWMgaW5saW5lIGFuZCByZW1vdmUg4oCcZWNhbeKAnQ0KZnJvbSB0aGUgbmFtZS4NCkZvciB0
aGUgY29tbWVudCB0aGlzIHdhcyBhIHJlcXVlc3QgZnJvbSBKdWxpZW4gaW4gdGhlIGZpcnN0IHBs
YWNlIGJ1dA0KYmVmb3JlIHRoaXMgd2FzIG1vdmVkIHRvIHRoZSBjb21tb24gY29kZS4NCkkgY2Fu
IHJlbW92ZSB0aGUgY29tbWVudCBmcm9tIHRoZSBjb21tb24gY29kZSBhbmQgcHV0IGl0IGluIHRo
ZQ0KQXJtIHZwY2kgY29kZSBpbnN0ZWFkLg0KQEp1bGllbjogd291bGQgdGhhdCBiZSBhY2NlcHRh
YmxlIGZvciB5b3Ugbm93ID8NCk90aGVyd2lzZSBJIGNhbiByZW1vdmUgaXQgYWxsIHRvZ2V0aGVy
Lg0KDQo+IA0KPj4+PiAraW50IHZwY2lfZWNhbV9tbWlvX3dyaXRlKHBjaV9zYmRmX3Qgc2JkZiwg
dW5zaWduZWQgaW50IHJlZywgdW5zaWduZWQgaW50IGxlbiwNCj4+Pj4gKyAgICAgICAgICAgICAg
ICAgICAgICAgICB1bnNpZ25lZCBsb25nIGRhdGEpDQo+Pj4+ICt7DQo+Pj4+ICsgICAgaWYgKCAh
dnBjaV9lY2FtX2FjY2Vzc19hbGxvd2VkKHJlZywgbGVuKSB8fA0KPj4+PiArICAgICAgICAgKHJl
ZyArIGxlbikgPiBQQ0lfQ0ZHX1NQQUNFX0VYUF9TSVpFICkNCj4+Pj4gKyAgICAgICAgcmV0dXJu
IDA7DQo+Pj4+ICsNCj4+Pj4gKyAgICB2cGNpX3dyaXRlKHNiZGYsIHJlZywgbWluKDR1LCBsZW4p
LCBkYXRhKTsNCj4+Pj4gKyAgICBpZiAoIGxlbiA9PSA4ICkNCj4+Pj4gKyAgICAgICAgdnBjaV93
cml0ZShzYmRmLCByZWcgKyA0LCA0LCBkYXRhID4+IDMyKTsNCj4+Pj4gKw0KPj4+PiArICAgIHJl
dHVybiAxOw0KPj4+PiArfQ0KPj4+PiArDQo+Pj4+ICtpbnQgdnBjaV9lY2FtX21taW9fcmVhZChw
Y2lfc2JkZl90IHNiZGYsIHVuc2lnbmVkIGludCByZWcsIHVuc2lnbmVkIGludCBsZW4sDQo+Pj4+
ICsgICAgICAgICAgICAgICAgICAgICAgICB1bnNpZ25lZCBsb25nICpkYXRhKQ0KPj4+PiArew0K
Pj4+PiArICAgIGlmICggIXZwY2lfZWNhbV9hY2Nlc3NfYWxsb3dlZChyZWcsIGxlbikgfHwNCj4+
Pj4gKyAgICAgICAgIChyZWcgKyBsZW4pID4gUENJX0NGR19TUEFDRV9FWFBfU0laRSApDQo+Pj4+
ICsgICAgICAgIHJldHVybiAwOw0KPj4+PiArDQo+Pj4+ICsgICAgLyoNCj4+Pj4gKyAgICAgKiBB
Y2NvcmRpbmcgdG8gdGhlIFBDSWUgMy4xQSBzcGVjaWZpY2F0aW9uOg0KPj4+PiArICAgICAqICAt
IENvbmZpZ3VyYXRpb24gUmVhZHMgYW5kIFdyaXRlcyBtdXN0IHVzdWFsbHkgYmUgRFdPUkQgb3Ig
c21hbGxlcg0KPj4+PiArICAgICAqICAgIGluIHNpemUuDQo+Pj4+ICsgICAgICogIC0gQmVjYXVz
ZSBSb290IENvbXBsZXggaW1wbGVtZW50YXRpb25zIGFyZSBub3QgcmVxdWlyZWQgdG8gc3VwcG9y
dA0KPj4+PiArICAgICAqICAgIGFjY2Vzc2VzIHRvIGEgUkNSQiB0aGF0IGNyb3NzIERXIGJvdW5k
YXJpZXMgWy4uLl0gc29mdHdhcmUNCj4+Pj4gKyAgICAgKiAgICBzaG91bGQgdGFrZSBjYXJlIG5v
dCB0byBjYXVzZSB0aGUgZ2VuZXJhdGlvbiBvZiBzdWNoIGFjY2Vzc2VzDQo+Pj4+ICsgICAgICog
ICAgd2hlbiBhY2Nlc3NpbmcgYSBSQ1JCIHVubGVzcyB0aGUgUm9vdCBDb21wbGV4IHdpbGwgc3Vw
cG9ydCB0aGUNCj4+Pj4gKyAgICAgKiAgICBhY2Nlc3MuDQo+Pj4+ICsgICAgICogIFhlbiBob3dl
dmVyIHN1cHBvcnRzIDhieXRlIGFjY2Vzc2VzIGJ5IHNwbGl0dGluZyB0aGVtIGludG8gdHdvDQo+
Pj4+ICsgICAgICogIDRieXRlIGFjY2Vzc2VzLg0KPj4+PiArICAgICAqLw0KPj4+PiArICAgICpk
YXRhID0gdnBjaV9yZWFkKHNiZGYsIHJlZywgbWluKDR1LCBsZW4pKTsNCj4+Pj4gKyAgICBpZiAo
IGxlbiA9PSA4ICkNCj4+Pj4gKyAgICAgICAgKmRhdGEgfD0gKHVpbnQ2NF90KXZwY2lfcmVhZChz
YmRmLCByZWcgKyA0LCA0KSA8PCAzMjsNCj4+Pj4gKw0KPj4+PiArICAgIHJldHVybiAxOw0KPj4+
PiArfQ0KPj4+IA0KPj4+IFdoeSBkbyB0aGVzZSB0d28gZnVuY3Rpb25zIHJldHVybiBpbnQvMC8x
IGluc3RlYWQgb2YNCj4+PiBib29sL2ZhbHNlL3RydWUgKGFzc3VtaW5nLCBhcyBwZXIgYWJvdmUs
IHRoYXQgdGhlbSByZXR1cm5pbmcgbm9uLQ0KPj4+IHZvaWQgaXMgd2FycmFudGVkIGF0IGFsbCk/
DQo+PiANCj4+IFRoaXMgaXMgd2hhdCB0aGUgbW1pbyBoYW5kbGVycyBzaG91bGQgcmV0dXJuIHRv
IHNheSB0aGF0IGFuIGFjY2Vzcw0KPj4gd2FzIG9rIG9yIG5vdCBzbyB0aGUgZnVuY3Rpb24gc3Rp
Y2sgdG8gdGhpcyBzdGFuZGFyZC4NCj4gDQo+IFN0aWNraW5nIHRvIHRoaXMgd291bGQgYmUgb2th
eSBpZiB0aGUgZnVuY3Rpb25zIGhlcmUgbmVlZGVkIHRoZWlyDQo+IGFkZHJlc3MgdGFrZW4sIHN1
Y2ggdGhhdCB0aGV5IGNhbiBiZSBpbnN0YWxsZWQgYXMgaG9va3MgZm9yIGENCj4gbW9yZSBnZW5l
cmFsIGZyYW1ld29yayB0byBpbnZva2UuIFRoZSBmdW5jdGlvbnMsIGhvd2V2ZXIsIG9ubHkgZ2V0
DQo+IGNhbGxlZCBkaXJlY3RseS4gSGVuY2UgdGhlcmUncyBubyByZWFzb24gdG8gbWlycm9yIHdo
YXQgaXMgaW4gbmVlZA0KPiBvZiBjbGVhbmluZyB1cCBlbHNld2hlcmUuIEknbSBzdXJlIHlvdSdy
ZSBhd2FyZSB0aGVyZSB3ZSdyZSBpbiB0aGUNCj4gKHNsb3cgZ29pbmcpIHByb2Nlc3Mgb2YgaW1w
cm92aW5nIHdoaWNoIHR5cGVzIGdldCB1c2VkIHdoZXJlLg0KPiBXaGlsZSB0aGUgZnVuY3Rpb25z
IHlvdSByZWZlciB0byBtYXkgbm90IGhhdmUgdW5kZXJnb25lIHN1Y2gNCj4gY2xlYW51cCB5ZXQs
IHdlIGdlbmVyYWxseSBleHBlY3QgbmV3IGNvZGUgdG8gY29uZm9ybSB0byB0aGUgbmV3DQo+IG1v
ZGVsLg0KDQpJIGFtIG9rIHRvIHJlbmFtZSB0aG9zZSB0byB2cGNpX2VjYW1fe3JlYWQvd3JpdGV9
Lg0KSXMgaXQgd2hhdCB5b3Ugd2FudCA/DQoNClJlZ2FyZHMNCkJlcnRyYW5kDQoNCj4gDQo+IEph
bg0KPiANCg0K


From xen-devel-bounces@lists.xenproject.org Fri Oct 15 07:41:04 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 07:41:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.209827.366386 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbHpu-0003kP-GK; Fri, 15 Oct 2021 07:41:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 209827.366386; Fri, 15 Oct 2021 07:41:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbHpu-0003kI-BR; Fri, 15 Oct 2021 07:41:02 +0000
Received: by outflank-mailman (input) for mailman id 209827;
 Fri, 15 Oct 2021 07:41:01 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=esao=PD=suse.com=jgross@srs-us1.protection.inumbo.net>)
 id 1mbHps-0003kC-Ty
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 07:41:00 +0000
Received: from smtp-out1.suse.de (unknown [195.135.220.28])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 3d1c6522-2d8b-11ec-8227-12813bfff9fa;
 Fri, 15 Oct 2021 07:40:59 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id C3B7021A61;
 Fri, 15 Oct 2021 07:40:58 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 73B3A13B53;
 Fri, 15 Oct 2021 07:40:58 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id gjU9GoowaWF1cQAAMHmgww
 (envelope-from <jgross@suse.com>); Fri, 15 Oct 2021 07:40:58 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3d1c6522-2d8b-11ec-8227-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1634283658; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=AT4i5Ejsr8QbrMkBnB9rNrtIqMDH0QDXSpdxLwxBZmM=;
	b=k8Dknr5Mi/Z3yUrBI/k1iw37+xpjLcCn+5rbV5zVATLOWDbah/85lLa5ZSrkvXE/JG7Z3J
	ZycQyv9MCiDsPn6HnFYNhveJ2FSsEeWv/VMx9AP8gWpo7+/u+JlI7ZW6UDTnsAcwuat647
	FBx7GXyi+pxroITqlRy8IhHoidCHIZA=
Subject: Re: [PATCH v3 0/3] disable building of pv-grub and qemu-trad per
 default
To: Ian Jackson <iwj@xenproject.org>
Cc: xen-devel@lists.xenproject.org, Andrew Cooper
 <andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>,
 Jan Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 Samuel Thibault <samuel.thibault@ens-lyon.org>,
 Community Manager <community.manager@xenproject.org>
References: <20210910055518.562-1-jgross@suse.com>
 <24891.31480.165445.521062@mariner.uk.xensource.com>
 <d894799e-27c6-bbbd-8d65-3e32c1aff843@suse.com>
 <24913.55427.402592.660538@mariner.uk.xensource.com>
From: Juergen Gross <jgross@suse.com>
Message-ID: <2037c30a-5ac4-caf6-b47b-f2574422151f@suse.com>
Date: Fri, 15 Oct 2021 09:40:57 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <24913.55427.402592.660538@mariner.uk.xensource.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="vHVEXBkxDczzS8VPTCAyiUr5Es6C56WLj"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--vHVEXBkxDczzS8VPTCAyiUr5Es6C56WLj
Content-Type: multipart/mixed; boundary="3ea7AzP9CrZeVth7fnpS9BtP3QRTpLb2e";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Ian Jackson <iwj@xenproject.org>
Cc: xen-devel@lists.xenproject.org, Andrew Cooper
 <andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>,
 Jan Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 Samuel Thibault <samuel.thibault@ens-lyon.org>,
 Community Manager <community.manager@xenproject.org>
Message-ID: <2037c30a-5ac4-caf6-b47b-f2574422151f@suse.com>
Subject: Re: [PATCH v3 0/3] disable building of pv-grub and qemu-trad per
 default
References: <20210910055518.562-1-jgross@suse.com>
 <24891.31480.165445.521062@mariner.uk.xensource.com>
 <d894799e-27c6-bbbd-8d65-3e32c1aff843@suse.com>
 <24913.55427.402592.660538@mariner.uk.xensource.com>
In-Reply-To: <24913.55427.402592.660538@mariner.uk.xensource.com>

--3ea7AzP9CrZeVth7fnpS9BtP3QRTpLb2e
Content-Type: multipart/mixed;
 boundary="------------3C497BEA82F202F663087340"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------3C497BEA82F202F663087340
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 27.09.21 16:43, Ian Jackson wrote:
> Juergen Gross writes ("Re: [PATCH v3 0/3] disable building of pv-grub a=
nd qemu-trad per default"):
>> On 10.09.21 17:34, Ian Jackson wrote:
>>> Juergen Gross writes ("[PATCH v3 0/3] disable building of pv-grub and=
 qemu-trad per default"):
>>>> This is a first step of deprecating pv-grub and qemu-trad including
>>>> ioemu-stubdom. Switch the default to not building it.
>>>
>>> This is now fully acked.  But can we wait with committing it until we=

>>> have a decision about whether to (a) have osstest explicitly enable
>>> the pv-grub and qemu-trad builds (b) have osstest stop testing these
>>> configurations ?
>>
>> Any decisions made?
>=20
> No-one seems to have had any opinions.   I'll take ...
>=20
>> FWIW I'd be fine dropping pv-grub builds and tests in OSStets, but I'd=

>> rather keep testing qemu-trad stubdom tests.
>=20
> ... that as a proposal :-).  think that is probably the right tradeoff.=

>=20
> I think that means that means we need osstest patches to edit
> make-flight and ts-xen-build which
>=20
>   * Explictly enables stubdom qemu build
>   * Drops the pv-grub tests
>=20
> and those need to go in first.

I believe patch 1 of my series could go in at any time, as it is just
fixing a bug.


Juergen


--------------3C497BEA82F202F663087340
Content-Type: application/pgp-keys;
 name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Transfer-Encoding: quoted-printable
Content-Description: OpenPGP public key
Content-Disposition: attachment;
 filename="OpenPGP_0xB0DE9DD628BF132F.asc"

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy=
cWx
w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O=
f8Z
d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y=
9bf
IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq=
G7/
377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR=
3Jv
c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA=
QIe
AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT=
hpw
dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0=
MbD
1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv=
oPH
Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v=
5QL
+qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ=
2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC=
QoL
BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr=
Wf0
teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC=
/nu
AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh=
ITT
d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm=
XBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz=
80h
SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC=
AcD
AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn=
FOX
gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1=
jnD
kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0=
N51
N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l=
otu
fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1=
tqS
EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA=
hsD
BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3=
g3O
ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5=
dM7
wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5=
D+j
LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm=
V2x
AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N=
Eaw
QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW=
nHI
s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR=
wgn
BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV=
bVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk=
pEd
IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA=
QAB
wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw=
Tbe
8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1=
vJz
Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8=
VGi
wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW=
svi
uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX=
zXs
ZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------3C497BEA82F202F663087340--

--3ea7AzP9CrZeVth7fnpS9BtP3QRTpLb2e--

--vHVEXBkxDczzS8VPTCAyiUr5Es6C56WLj
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmFpMIkFAwAAAAAACgkQsN6d1ii/Ey/3
qgf+MBUgWAGr29R4Z+vzACsyU1nq7S+yqX6roAcwghmdzWu+kGbFM1k6hG/b4/igeUadNgcwnTan
B9kzXUfRtoWNLKOQgf8XdoZPPt/66yIqN5HQKl/MbyDUShTBdKeLafT/XfDCy0Ds2VFh5r2g1kbU
RES1kWpT2RK58IjBdj389bY1yddxdh2DQN/kvNQsFC0O+qxO2L2Xx2Y8QZwIKL+xjEwLHisQR4dB
ErleTzWnG8ZHTY0yp4ey/F6g0xo2q4fN983DVEnReARowiTH/Cm49FG4xMBWVI5csssKkLsPUEHu
4LtvHiD8/HBTUUhoSnU9/d4RMATk98sEKXwjkBB9+A==
=CCsG
-----END PGP SIGNATURE-----

--vHVEXBkxDczzS8VPTCAyiUr5Es6C56WLj--


From xen-devel-bounces@lists.xenproject.org Fri Oct 15 07:41:18 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 07:41:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.209829.366397 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbHqA-00047V-Nl; Fri, 15 Oct 2021 07:41:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 209829.366397; Fri, 15 Oct 2021 07:41:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbHqA-00047M-JJ; Fri, 15 Oct 2021 07:41:18 +0000
Received: by outflank-mailman (input) for mailman id 209829;
 Fri, 15 Oct 2021 07:41:16 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=KdBF=PD=arm.com=michal.orzel@srs-us1.protection.inumbo.net>)
 id 1mbHq8-00045i-Bw
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 07:41:16 +0000
Received: from foss.arm.com (unknown [217.140.110.172])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTP
 id 46bfe1bc-2d8b-11ec-8227-12813bfff9fa;
 Fri, 15 Oct 2021 07:41:15 +0000 (UTC)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id ED330D6E;
 Fri, 15 Oct 2021 00:41:14 -0700 (PDT)
Received: from [10.57.25.205] (unknown [10.57.25.205])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 844553F694;
 Fri, 15 Oct 2021 00:41:12 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 46bfe1bc-2d8b-11ec-8227-12813bfff9fa
Subject: Re: [PATCH v6 3/3] arm/libxl: Emulated PCI device tree node in libxl
 [and 1 more messages]
To: Julien Grall <julien@xen.org>, Ian Jackson <iwj@xenproject.org>,
 Bertrand Marquis <Bertrand.Marquis@arm.com>
Cc: xen-devel@lists.xenproject.org, Rahul Singh <rahul.singh@arm.com>,
 Wei Liu <wl@xen.org>, Anthony PERARD <anthony.perard@citrix.com>,
 Juergen Gross <jgross@suse.com>, Stefano Stabellini
 <sstabellini@kernel.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andre Przywara <Andre.Przywara@arm.com>
References: <cover.1633540842.git.rahul.singh@arm.com>
 <b81b5dea800c8fe47071f3dbd20588b1e472fb99.1633540842.git.rahul.singh@arm.com>
 <7bdac405-a889-15e1-be19-5876f7253855@xen.org>
 <24926.53690.621007.507249@mariner.uk.xensource.com>
 <294BE20A-7E45-405C-BC19-C292295E85E3@arm.com>
 <24927.7235.736221.270358@mariner.uk.xensource.com>
 <8A04B9B2-E816-425E-BF1B-5A8B89F8836C@arm.com>
 <cover.1634221830.git.bertrand.marquis@arm.com>
 <fd9c54a381daa52436b0a1b27cf1bba8e7ff9af9.1634221830.git.bertrand.marquis@arm.com>
 <24936.28385.679884.535704@mariner.uk.xensource.com>
 <6f82141c-8a0b-1e30-a996-223f7c0c508d@xen.org>
From: Michal Orzel <michal.orzel@arm.com>
Message-ID: <623814d1-a40d-df93-34f4-c1dd3eef60f6@arm.com>
Date: Fri, 15 Oct 2021 09:41:00 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <6f82141c-8a0b-1e30-a996-223f7c0c508d@xen.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit

Hi guys,

On 15.10.2021 09:28, Julien Grall wrote:
> Hi Ian,
> 
> On 14/10/2021 18:54, Ian Jackson wrote:
>> (Replying to both the earlier subthread on v5 and to the new v6
>> patch.)
>>
>> Bertrand Marquis writes ("Re: [PATCH v5 10/11] arm/libxl: Emulated PCI device tree node in libxl"):
>>> Now you suggest to add a new field arm_vpci in libxl__domain_create_state.
>>
>> Hi.  I was handwaving, hence "probably" :-).  I hadn't actually looked
>> at the existing code to see precisely how it would fit.
>>
>>> Once we have done that I will need to access this structure to know if I need
>>> to add the DT part and somehow to give it a value depending something which
>>> for now would the number of pcidevs as there will be no user parameter anymore.
>>
>> Right.
>>
>> I looked at libxl_arm.c again:
>>
>> It seems that the main entrypoint to all this is libxl__prepare_dtb,
>> and it is that function you want to do new stuff.  That gets
>> libxl_domain_build_info (which is specified by the IDL and comes from
>> outside libxl, subject to libxl's default-filling machinery) and
>> libxl__domain_build_state (which is the general state struct).
>>
>> The information you need is is libxl_domain_create_info.
>> libxl__domain_config_setdefault already arranges to set
>> c_info->passthrough based on the number of PCI PT devices
>> (search for `need_pt` in libxl_create.c).
>>
>> That is, as I understand it on ARM vpci should be enabled if
>> passthrough is enabled and not otherwise.  That is precisely what
>> the variable c_info->passthrough is.
> 
> On Arm, c_info->passthrough is also set when assigning platform devives (e.g. a non-PCI network card). At least for now, we don't want to create a node for vCPI in the Device-Tree because we don't enable the emulation. So...
> 
>>
>> There is a slight issue because of the distinction between create_info
>> and build_info and domain_config (and, the corresponding _state)
>> structs.  Currently the DT code ony gets b_info, not the whole
>> libxl_domain_config.  These distinctions largely historical nowadays.
>> Certainly there is no reason not to pass a pointer to the whole
>> libxl_domain_config, rather than just libxl_domain_build_info, into
>> libxl__arch_domain_init_hw_description.
>>
>> So I think the right approach for this looks something like this:
>>
>> 1. Change libxl__arch_domain_init_hw_description to take
>>     libxl_domain_config* rather than libxl_domain_build_info*.
>>     libxl_domain_config contains libxl_domain_build_info so
>>     this is easy.
>>
>>     If you put in a convenience alias variable for the
>>     libxl_domain_build_info* you can avoid extra typing in the function
>>     body.  (If you call the convenience alias `info` you won't need to
>>     change the body at all, but maybe `info` isn't the best name so you
>>     could rename it to `b_info` maybe; up to you.)
>>
>> 2. Make the same change to libxl__prepare_dtb.
>>
>> 3. Now you can use d_config->c_info.passthrough to gate the addition
>>     of the additional stuff to the DT.  Ie, that is a respin of this
>>     patch 3/3.
> 
> ... we will need to check d_config->num_pcidevs for the time being.
> 
> Cheers,
> 

Thanks Julien for a good catch.

Do you agree on the following approach:
1. Modify argument of libxl__arch_domain_init_hw_description to libxl_domain_config (patch 1)
2. Modify argument of libxl__prepare_dtb to libxl_domain_config (patch 2)
3. Remove arch_arm.vpci completely and in libxl__prepare_dtb add a check (patch 3):
if (d_config->num_pcidevs)
    FDT( make_vpci_node(gc, fdt, ainfo, dom) );
+ make_vpci_node implementation

Does it sound ok for you?

Cheers,
Michal


From xen-devel-bounces@lists.xenproject.org Fri Oct 15 07:44:37 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 07:44:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.209842.366407 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbHtI-0004xm-7o; Fri, 15 Oct 2021 07:44:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 209842.366407; Fri, 15 Oct 2021 07:44:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbHtI-0004xf-4s; Fri, 15 Oct 2021 07:44:32 +0000
Received: by outflank-mailman (input) for mailman id 209842;
 Fri, 15 Oct 2021 07:44:31 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=UM5E=PD=citrix.com=roger.pau@srs-us1.protection.inumbo.net>)
 id 1mbHtH-0004xW-6x
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 07:44:31 +0000
Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 87b2d8ce-807a-49ce-8233-cf187e761840;
 Fri, 15 Oct 2021 07:44:29 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 87b2d8ce-807a-49ce-8233-cf187e761840
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1634283869;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=EG8lU7/OqN3Qa7fW1GhfdyUiiRkq2bMNKgEK6RdjGbo=;
  b=GkOVIRqND1Gwcwa7DS8o6hcaAw+fgaSkIw8wTJlfZQLmT0XjSoYPHHqw
   IHjEC8z7LQpkQ4iTiZdouyKOZpBr0nF8++u+mBjWH4DcvN78uM2Qnq10N
   as8Xuh3TE1+g2lxe2vpW1qfzB0ScoyH+mAx3oVEOg2io1Ip7Zrv4v19o+
   M=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: IomCdoLKltLV3CGcFUfzTT8IlRrO2YEy+DLlB7H1OGQUVaisc02mQO5sTFIYGLjh9MauMIrGE/
 YHadXS6nSQ935tQQuCv9vfBRdT3Er/NNbzc1qFbaO9Cvcorg7Ty+l2JCRnEQvqDXSwNHvhnWL/
 Pe34haCn9nGk4t5MvulbTPETqPfCm3QGVDzS8754+A8Kxb2gLkFMP+cO2RMfjRUS7yWgi1ItAT
 gNeLsSSnB9S/nK1mDZlECY1DDcEeY6Z1LAOhQq8XBOuZ+78Iu1fWTDJu023augk2qZGCDHGPEr
 5Sr1/tF4zTs9WsyhQ8mS004y
X-SBRS: 5.1
X-MesageID: 54828236
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:yKI2AK2n/EEclmLbWPbD5Ux2kn2cJEfYwER7XKvMYLTBsI5bpzwPm
 zBMDD+Abv6ONmLwe9x0a4Sxo0wGscWAmNdnGgM+pC1hF35El5HIVI+TRqvS04J+DSFhoGZPt
 Zh2hgzodZhsJpPkS5PE3oHJ9RGQ74nRLlbHILOCan0ZqTNMEn970Es7wrNh2+aEvPDia++zk
 YKqyyHgEAfNNw5cagr4PIra9XuDFNyr0N8plgRWicJj5TcypFFMZH4rHomjLmOQf2VhNrXSq
 9Avbl2O1jixEx8FUrtJm1tgG6EAaua60QOm0hK6V0U+6/TrS+NbPqsTbZIhhUlrZzqhhulA0
 tpskKyLQyhyEanos7oHcgtRDHQrVUFG0OevzXmXtMWSywvNcmf2wuUoB0YzVWEa0r8pWycUr
 6VecW1TKEDY7w616OvTpu1EnMMsIdOtJIoCknph0SvYHbAtRpWrr6DiuIMIhmdq3Z4m8fD2S
 MklRjppbUn6XTZ2HUo3CJgajef0ryyqG9FfgA3M/vdmi4TJ9yRp2aXpGMrYfJqNX8o9tkSSq
 3/C/m/5KgoHL9HZwj2AmlqzgsffkCW9X5gdfJWy++R2mlSVyioWAQcPSFqgifCjjwi1XNc3A
 1wZ/G8ioLY/8GSvT8LhRFuorXicpBkeVtFMVeog52mly7XWyxaUAHAeSTxMY8Bgs9U5LQHGz
 XfQwYmvX2Y29uTIFzTNrd94sA9eJwAMFF4Yag4hfTAPzILMpKUY0AjuXN98RfvdYsLOJRn8x
 DWDrS4bjroVjNIW26jTwW0rkw5AtbCSEVZrvlS/snaNq1ojPtb8NtPABU3ztK4YdO6kok+9U
 G/ociR0xNsFCo2Rj2SzSeEJEaDBCx2tYWCE3wAH83XM8V2QF5+fkWJ4vG4WyKRBaJ9sldrVj
 Kn74l45CHh7ZirCUEOPS9jtY/nGNIC5fTgfatjab8BVfr96fxKd8SdlaCa4hj62zBJ3y/piY
 MfBL65A6Er274w8kVJaoM9GidcWKt0WnzuPFfgXMTz2uVZhWJJlYehcawbfBgzIxKiFvB/U4
 75i2ziikH1ivBnFSnCPq+Y7dAlSRVBiXMyeg5EHJ4arf1s9cEl8WqC5/F/UU9E890ijvryTp
 S/Vt44x4AeXuEAr3i3RNC09Muq0A8smxZ/5VAR1VWuVN7EYSd/HxI8UdoctfKlh8+pmzPVuS
 OICddnGCfNKIgkrMRxGBXUkhIA9JhmtmyyUOC+pPGo2c5J6HlSb8d74ZAr/siIJC3Pv58c5p
 rSh0CLdQIYCGFs+XJqHNqr3wgPjp2UZlcJzQ1DMfotZdnLz/dU4MCf2lPI2fZ0BcE2R2juA2
 g+KKh4Evu2R8ZQt+dzEiPnc/YekGudzBGRAGGzf4erkPCXW5DP7k4RBTPyJbXbWU2atoPeuY
 uBczvfdNvwbnQkV79ogQugzla9nvonhvb5XyAhgDU7nVVXzB+MyOGSC0OlOqrZJmu1TtzypV
 x/d4dJdI7iIZp/oSQZDOAo/Y+2f/vgIgT2Ov+8tKUD36SIrrrqKVUJeY0uFhCBHdeYnNYokx
 aEqudIM6hz5gR0va47UgidR/mWKD3oBT6R46c1KXN610lImmgNYfJjRKi7q+5XeOdxDP34jL
 iKQmKef1a9XwVDPciZrGHXAtQaHaU/iZPyeIIc+Gmm0
IronPort-HdrOrdr: A9a23:PK0FwaBKXP5F3PjlHeg/sceALOsnbusQ8zAXPh9KJyC9I/b2qy
 nxppgmPH/P6Ar4WBkb6La90Y27MA7hHPlOkPUs1NaZLXPbUQ6TTb2KgrGSpgEIdxeOktK1kJ
 0QDJSWa+eAfWSS7/yKmDVQeuxIqLLsndHK9IWuvEuFDzsaEJ2Ihz0JezpzeXcGPTWua6BJc6
 Z1saF81kSdkDksH4iGL0hAe9KGi8zAlZrgbxJDLxk76DOWhTftzLLhCRCX0joXTjsKmN4ZgC
 b4uj28wp/mn+Cwyxfa2WOWx5NKmOH5wt8GIMCXkMAaJhjllw7tToV8XL+puiwzvYiUmRkXue
 iJhy1lE9V46nvXcG3wiRzx2zP42DJr0HPmwU/wuwqpneXJABYBT+ZRj4NQdRXUr2A6ustn7a
 5N12WF87JKEBLphk3Glpv1fiAvsnDxjWspkOYVgXAae5AZcqVtoYsW+14QOIscHRj99JssHI
 BVfYHhDc5tABanhk3izy1SKITGZAV1Iv7GeDlChiWt6UkVoJgjpHFogvD2nR87hdoAotd/lr
 352gkBrsA4ciYsV9MJOA42e7r/NoX8e2O/DIusGyWSKEgmAQOGl3el2sR52AmVEKZ4uqfa3q
 6xCG9liQ==
X-IronPort-AV: E=Sophos;i="5.85,375,1624334400"; 
   d="scan'208";a="54828236"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=n72N+TlMaaqXkpQ12Hme72DlgejgFUxKBBTs7rnDGzA+DNz/yKXdU3R96GlSmLuLwDlSXJYPe1xd7W0bJmTKX7nozGs0rJiPprrePQEEPI+oKEi36aW1BGLfgHU4TSnGeMCsBp6ViwleVcL3Pu+AuP5Sh3HarmSX43D0v4gKcR/xRjLh54kyzEyerbLg5cE9pgNKPzonE8aIChlNht6UyBp8rckC9W/QhMnUQjSLcbV3n00+eMndRAnZU9n1D1am412vfPvRPHAzvNw92K2LkOqhkUywNE+Mu+aMO6t8kMKa7llSWAQFjKOCxD9FfqFEadXG4o4PzyQIV1gkro20Aw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=9oz72RjvQ9vrbnCPu8D3PXpkuwlk0cM7YjOj52B/hkg=;
 b=bKDTbhF1Z4X4CRCRxUhFrN2mx8LXDS74jRnyACdHhiDm0zWVcdfzohvCEk9Br3vbprmHKpMfC1PbueBbjvp7ekxzVtjqU2n0LaGsmeWI1rNfjcRRvwuCTSE3qNU51i5M2qP/fVfIQNx6vB5K133BFNZJFFoeXNUMFg21HVjzFwgJs143fyM8KKXNUX6U/56DnZzb+36DVlh6JwIc6gfxtr2FdTNJHCzOAkpdkI+KW00O9OUeaMK39s78Zy3j/1LZ4/G8VBO1UweNqO50VMcLqwRJuZOfrvIGhu0i1Vj4uyi1sfEFwkyK4hYG6yk6UuR12qhhiB/ZcPsF3p/PsBohZQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=9oz72RjvQ9vrbnCPu8D3PXpkuwlk0cM7YjOj52B/hkg=;
 b=BlIxv9yn/qF62DVEUjzEi5M01Tg7rY6uk72Zl0r/s3GwSpwkz8jAWQXxbzfa/zdejizczwwwhGXhHsSLYrvLwR1xFZK0h8A4crpufRphlZodS5gvd0DMBoTYZkQR+34nbqDLCGKk0Tugl7MginhbsPyq9Z2IIPs88WDa9lMyKZk=
Date: Fri, 15 Oct 2021 09:44:15 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Bertrand Marquis <bertrand.marquis@arm.com>
CC: <xen-devel@lists.xenproject.org>, <iwj@xenproject.org>, Paul Durrant
	<paul@xen.org>, Jan Beulich <jbeulich@suse.com>, Andrew Cooper
	<andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH v6 1/3] xen/vpci: Move ecam access functions to common
 code
Message-ID: <YWkxT1bVmBT7Av43@MacBook-Air-de-Roger.local>
References: <cover.1634221830.git.bertrand.marquis@arm.com>
 <ced6f870dbfabcfe8584555cc80f9a37a0655a0c.1634221830.git.bertrand.marquis@arm.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <ced6f870dbfabcfe8584555cc80f9a37a0655a0c.1634221830.git.bertrand.marquis@arm.com>
X-ClientProxiedBy: LO2P265CA0508.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:13b::15) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: f72e0116-a02c-4bd1-124b-08d98faf986e
X-MS-TrafficTypeDiagnostic: DM5PR03MB2969:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <DM5PR03MB2969247ADCB004CE1F39B0C88FB99@DM5PR03MB2969.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: Yo3c6kbEHvZji793o97aYzwUp+W5SaWG+bQjZsO5dK51vA2TX33SgS+ZFSwpn6mpyMFzJFazkOYS4FvzB1gAWeNbnuFj8LR4P1lkvA8KuKr+Lh0knA1KqPzHp2RUQJ4j/L+WQnGslDFxofxycthEzE8Fbi5xjs5yz/UPGOAkILGc8Tkwn4VMTAWc6zd92R1Abf8aYAREExjelxsRJtoTC6vmUyLVY7suqPIb5r5I3L4F6EiZWmgNhSZQOv2m7j+uOniorMKQ54F8+ZrwJJuRtwPWZysiklOISPmsX7GriC3mr++Einw6nJ3wUAPle8kuEW0UfnNkIHEw8IRuNMJ+48M8jdi6N7r/7U0r0gq+R5cFVT787MUOF0hESJB3sacHGS341lnN5aF60DuEq5HrL2747VcEZFfjSYmvde75S17wi1NqJ/YJLjS3g7c50oheSbyuJ1Y6OsPFPCMKD/neyPzgexuMLuZgVCeoPAzzf401A/DbFrJFkiuhU9vG9nN4hq4DtqZC5TAgUHNAzhLn59OM5W5m4U7sJ1Vpe/wHUuWiZTY3FLEqD0dlGliWRmXZnMdE/jlxQTp2Pg1Q1spN9a4C6Ox96A6ShmJbjSIaetGSht4oybeFuwlcYPMPWkyKLNN5z0TwPejmBWeY2sj4CHHZy1KBVtptws9vG6aiRsdgBbBX0Pa7N/K28h0y3nC1tpDaK8tLOc/9yjSECvyq0QTQF4JAl5CtXGNIRAMrrPk=
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(54906003)(6486002)(82960400001)(83380400001)(316002)(5660300002)(966005)(8936002)(956004)(66556008)(6666004)(86362001)(85182001)(4326008)(66476007)(38100700002)(8676002)(26005)(2906002)(6496006)(508600001)(186003)(9686003)(6916009)(66946007);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RTZqSnYrK3JQbWZIYnpMMDB2L0d5M09kc3NLV251VUVvYkwvdnUvdEhsR2pS?=
 =?utf-8?B?djRVZWJiVzF3RG41RTBXNFUzbVVadDhaTGNPY0hKaWh0OVk2OXN3eWVvdnlz?=
 =?utf-8?B?VEdsMzFZdUMxTDdUZEJPQjU0THp4d3VoekprVG5mYU9QcndRQmdPTlZTamh0?=
 =?utf-8?B?dmo2UCtZbGtEeC9BYzFQZEMzZnhRekNVS1pQb2g0ckxKNkhoeTkvUDMyWkJ3?=
 =?utf-8?B?L3NXY0JWbUc3WWlEbnBIVWNqYlU0dy91anVwK0VKQ1RCbEVVSFRvTUt4dkd2?=
 =?utf-8?B?TmlDMFE5dHp5bmpsUWdoSTh1Q0ZTaFBmaWtzY211ZzdQdW1ERUY3djN2a3Zo?=
 =?utf-8?B?cVEwK2hQV2Q3NEo0NVRMMTJKdXJLZ0VXSmZqOEhteUk0Y1JOQ0xWdGp3Zktj?=
 =?utf-8?B?NzhnZGlXYXBRNGpna25kSENSSWloMEZwN2Y4dVo3eU1TR2JQRkJPUWFmNWNG?=
 =?utf-8?B?MUN0bXRWZ1dSYlFFQTN3eksxWldLM3JXUUJ3ckEwdEZmWDBDTlBRRHdPM2N5?=
 =?utf-8?B?TTRzMGFjV1J0T2plL1J4MHNUNTlsTGRHc1VyTklzNTRRa09XRjNVUzdZbFpr?=
 =?utf-8?B?enZRdm9rZHRiKzlMcFZock9IUDlaZmkxS3BvL0V4NTdPSFF0RTloNXBsOUpC?=
 =?utf-8?B?NElFS3U3WUJTN2QxT2lmMjdCbzRlcE5OV1BhcDBGQ3o2Vk9MT09GTXhlbzlt?=
 =?utf-8?B?MURaKzk0OHhDVzlsd0p3VEFNRUJpWTNUOXRhdTBqVHNMazNDOFNRNVRjZmpQ?=
 =?utf-8?B?TDJ1YktGSXFjc3h2ZTFROERKcEtqbTMrTXFvNkk3ZmhNWStWRjVQUVZtMmFW?=
 =?utf-8?B?Sml2Um50cSsvOHNnbEhnK0hvd2p2UGFSQ2NJbDNEQTFJRm9HelFhS1RFMXhI?=
 =?utf-8?B?U0c0SVRSVVU3VzMwb2R5S2lXV3FYUWVHalhnbjVRMjRYdWtxWkpYVm9QS2gy?=
 =?utf-8?B?eUQ4SFN4UGlXVStCc0NHKzUybEVKdHUwdStQK2F3bmRYcHZPblA4bW41R0Rn?=
 =?utf-8?B?THBYYnNtRlVSZkNweTZUSk05b0dNODdIMnRocnJ0R25idEpobGNrdzB0NkRN?=
 =?utf-8?B?dUo1dzB4U3dCVUhQZkordmhiVUFxOU9kVHNPR21wME9XUmRZQjdlNS9na3ZB?=
 =?utf-8?B?YzhZZmxxZUFoU2tUT0R2VW9DajhiMUYwR2wyME1ZaklkT3ltM21RN1hlSmY0?=
 =?utf-8?B?Y1VtWm9JWnhsemttbnZmS3N1RUNFMDhxUW8rZUloZFZzbGdScmZndG9mZFRw?=
 =?utf-8?B?QjJsVjRuckNEaFVNU0FFOE1mM3RJQkxMb1RDUTQvUXV3T2xEMmMxaFdJWGxM?=
 =?utf-8?B?U1MyZzU0ZWhaU2RpOStmdUFSK2lrMzRkVlRRQ1J0OWs2WUpwcVh6ellwZW1X?=
 =?utf-8?B?dFVEcnlQRWlWMFpjMDBXS29MOTBJV2JXR2FKbnhhWE91L3VBOWpTT1JHYVdR?=
 =?utf-8?B?alh6MGpGcXg0LzJ4aEdWMFZZNjZsVzFyY1doaE1tVUVuUDc4UmkvZ2lwVDNv?=
 =?utf-8?B?N2RtOVByUmQ5OUE4LzJhbWhtVWlGREFCUXFjQlR3T3B4Y1l5QmM3MFhXbFgz?=
 =?utf-8?B?L2pXVXJOeXAwSHNmNWtBcEJ1R3RqeS9VOUE4NVN0Rm5iMTBpZTN0bUNseGNX?=
 =?utf-8?B?cC9jdUt5b09IeElENnJHKzVuYU4xMHlSMXc0akJBbEZSNm1mTVFoa0YvM250?=
 =?utf-8?B?K1VIS0pnSkxKMzVVaFQ2TkNmOFAzSGdydUZRc3dzTWFYSytSVFZGY2VkUUQ0?=
 =?utf-8?Q?Q4EhSXWKXABgLBh19LhnxybpMLk9YPck92RtpU+?=
X-MS-Exchange-CrossTenant-Network-Message-Id: f72e0116-a02c-4bd1-124b-08d98faf986e
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2021 07:44:19.0418
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: CeC5gjwfXn4uCKFoN4uz79GgMKY1joneUfY1p6mC/cl00yjQwbflkwNiyFXch40MkYkazGIeBGdJxfnIuIyG8Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB2969
X-OriginatorOrg: citrix.com

On Thu, Oct 14, 2021 at 03:49:49PM +0100, Bertrand Marquis wrote:
> PCI standard is using ECAM and not MCFG which is coming from ACPI[1].
> Use ECAM/ecam instead of MCFG in common code and in new functions added
> in common vpci code by this patch.
> 
> Rename vpci_access_allowed to vpci_ecam_access_allowed and move it
> from arch/x86/hvm/io.c to drivers/vpci/vpci.c.
> 
> Create vpci_ecam_mmio_{read,write} in drivers/vpci/vpci.c that
> contains the common code to perform these operations, changed
> vpci_mmcfg_{read,write} accordingly to make use of these functions.
> 
> The vpci_ecam_mmio_{read,write} functions are returning 0 on error and 1
> on success. As the x86 code was previously always returning X86EMUL_OKAY
> the return code is ignored. A comment has been added in the code to show
> that this is intentional.
> 
> Those functions will be used in a following patch inside by arm vpci
> implementation.
> 
> Rename MMCFG_SBDF to ECAM_SBDF.
> 
> Not functional change intended with this patch.
> 
> [1] https://wiki.osdev.org/PCI_Express
> 
> Suggested-by: Roger Pau Monné <roger.pau@citrix.com>
> Signed-off-by: Bertrand Marquis <bertrand.marquis@arm.com>
> ---
> Changes in v6: Patch added
> ---
>  xen/arch/x86/hvm/io.c     | 50 +++++---------------------------
>  xen/drivers/vpci/vpci.c   | 60 +++++++++++++++++++++++++++++++++++++++
>  xen/include/asm-x86/pci.h |  2 +-
>  xen/include/xen/vpci.h    | 10 +++++++
>  4 files changed, 78 insertions(+), 44 deletions(-)
> 
> diff --git a/xen/arch/x86/hvm/io.c b/xen/arch/x86/hvm/io.c
> index 046a8eb4ed..340b8c8b0e 100644
> --- a/xen/arch/x86/hvm/io.c
> +++ b/xen/arch/x86/hvm/io.c
> @@ -260,20 +260,6 @@ unsigned int hvm_pci_decode_addr(unsigned int cf8, unsigned int addr,
>      return CF8_ADDR_LO(cf8) | (addr & 3);
>  }
>  
> -/* Do some sanity checks. */
> -static bool vpci_access_allowed(unsigned int reg, unsigned int len)
> -{
> -    /* Check access size. */
> -    if ( len != 1 && len != 2 && len != 4 && len != 8 )
> -        return false;
> -
> -    /* Check that access is size aligned. */
> -    if ( (reg & (len - 1)) )
> -        return false;
> -
> -    return true;
> -}
> -
>  /* vPCI config space IO ports handlers (0xcf8/0xcfc). */
>  static bool vpci_portio_accept(const struct hvm_io_handler *handler,
>                                 const ioreq_t *p)
> @@ -305,7 +291,7 @@ static int vpci_portio_read(const struct hvm_io_handler *handler,
>  
>      reg = hvm_pci_decode_addr(cf8, addr, &sbdf);
>  
> -    if ( !vpci_access_allowed(reg, size) )
> +    if ( !vpci_ecam_access_allowed(reg, size) )
>          return X86EMUL_OKAY;
>  
>      *data = vpci_read(sbdf, reg, size);
> @@ -335,7 +321,7 @@ static int vpci_portio_write(const struct hvm_io_handler *handler,
>  
>      reg = hvm_pci_decode_addr(cf8, addr, &sbdf);
>  
> -    if ( !vpci_access_allowed(reg, size) )
> +    if ( !vpci_ecam_access_allowed(reg, size) )
>          return X86EMUL_OKAY;
>  
>      vpci_write(sbdf, reg, size, data);
> @@ -394,7 +380,7 @@ static unsigned int vpci_mmcfg_decode_addr(const struct hvm_mmcfg *mmcfg,
>                                             paddr_t addr, pci_sbdf_t *sbdf)
>  {
>      addr -= mmcfg->addr;
> -    sbdf->bdf = MMCFG_BDF(addr);
> +    sbdf->bdf = ECAM_BDF(addr);
>      sbdf->bus += mmcfg->start_bus;
>      sbdf->seg = mmcfg->segment;
>  
> @@ -434,25 +420,8 @@ static int vpci_mmcfg_read(struct vcpu *v, unsigned long addr,
>      reg = vpci_mmcfg_decode_addr(mmcfg, addr, &sbdf);
>      read_unlock(&d->arch.hvm.mmcfg_lock);
>  
> -    if ( !vpci_access_allowed(reg, len) ||
> -         (reg + len) > PCI_CFG_SPACE_EXP_SIZE )
> -        return X86EMUL_OKAY;
> -
> -    /*
> -     * According to the PCIe 3.1A specification:
> -     *  - Configuration Reads and Writes must usually be DWORD or smaller
> -     *    in size.
> -     *  - Because Root Complex implementations are not required to support
> -     *    accesses to a RCRB that cross DW boundaries [...] software
> -     *    should take care not to cause the generation of such accesses
> -     *    when accessing a RCRB unless the Root Complex will support the
> -     *    access.
> -     *  Xen however supports 8byte accesses by splitting them into two
> -     *  4byte accesses.
> -     */
> -    *data = vpci_read(sbdf, reg, min(4u, len));
> -    if ( len == 8 )
> -        *data |= (uint64_t)vpci_read(sbdf, reg + 4, 4) << 32;
> +    /* Ignore return code */
> +    vpci_ecam_mmio_read(sbdf, reg, len, data);

I think it would be better for vpci_ecam_mmio_read to just return the
read value, or ~0 in case of error, at least that interface would be
simpler and suitable for x86.

Also I would drop the mmio part from the function name.

>  
>      return X86EMUL_OKAY;
>  }
> @@ -476,13 +445,8 @@ static int vpci_mmcfg_write(struct vcpu *v, unsigned long addr,
>      reg = vpci_mmcfg_decode_addr(mmcfg, addr, &sbdf);
>      read_unlock(&d->arch.hvm.mmcfg_lock);
>  
> -    if ( !vpci_access_allowed(reg, len) ||
> -         (reg + len) > PCI_CFG_SPACE_EXP_SIZE )
> -        return X86EMUL_OKAY;
> -
> -    vpci_write(sbdf, reg, min(4u, len), data);
> -    if ( len == 8 )
> -        vpci_write(sbdf, reg + 4, 4, data >> 32);
> +    /* Ignore return code */
> +    vpci_ecam_mmio_write(sbdf, reg, len, data);

Kind of likely here, x86 would be fine with this function return type
being void.

If that's not good for Arm, I think the comment can be dropped as it's
clear the return code is ignored. It would better to maybe add:

/* Failed writes are not propagated to the caller */

>  
>      return X86EMUL_OKAY;
>  }
> diff --git a/xen/drivers/vpci/vpci.c b/xen/drivers/vpci/vpci.c
> index cbd1bac7fc..c0853176d7 100644
> --- a/xen/drivers/vpci/vpci.c
> +++ b/xen/drivers/vpci/vpci.c
> @@ -478,6 +478,66 @@ void vpci_write(pci_sbdf_t sbdf, unsigned int reg, unsigned int size,
>      spin_unlock(&pdev->vpci->lock);
>  }
>  
> +/* Helper function to check an access size and alignment on vpci space. */
> +bool vpci_ecam_access_allowed(unsigned int reg, unsigned int len)
> +{
> +    /*
> +     * Check access size.
> +     *
> +     * On arm32 or for 32bit guests on arm, 64bit accesses should be forbidden
> +     * but as for those platform ISV register, which gives the access size,
> +     * cannot have a value 3, checking this would just harden the code.

It feels kind of weird to have an Arm specific comment in common code,
but I guess there's no better place for it to live?

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Fri Oct 15 07:53:58 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 07:53:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.209851.366418 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbI2L-0006Sl-5D; Fri, 15 Oct 2021 07:53:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 209851.366418; Fri, 15 Oct 2021 07:53:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbI2L-0006Se-2L; Fri, 15 Oct 2021 07:53:53 +0000
Received: by outflank-mailman (input) for mailman id 209851;
 Fri, 15 Oct 2021 07:53:51 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Fqmt=PD=arm.com=Bertrand.Marquis@srs-us1.protection.inumbo.net>)
 id 1mbI2J-0006SW-BA
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 07:53:51 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com (unknown
 [2a01:111:f400:7d00::611])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id b54b31b3-7fc5-4067-9dcb-18dfcf5e4430;
 Fri, 15 Oct 2021 07:53:49 +0000 (UTC)
Received: from AM6PR04CA0024.eurprd04.prod.outlook.com (2603:10a6:20b:92::37)
 by DBBPR08MB4744.eurprd08.prod.outlook.com (2603:10a6:10:f6::11) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16; Fri, 15 Oct
 2021 07:53:46 +0000
Received: from AM5EUR03FT044.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:92:cafe::73) by AM6PR04CA0024.outlook.office365.com
 (2603:10a6:20b:92::37) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15 via Frontend
 Transport; Fri, 15 Oct 2021 07:53:46 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM5EUR03FT044.mail.protection.outlook.com (10.152.17.56) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.15 via Frontend Transport; Fri, 15 Oct 2021 07:53:46 +0000
Received: ("Tessian outbound 16951d3c485e:v103");
 Fri, 15 Oct 2021 07:53:46 +0000
Received: from d0de6239896d.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 1889B60D-8DDC-4563-8B8F-78B41E92B03F.1; 
 Fri, 15 Oct 2021 07:53:39 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id d0de6239896d.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 15 Oct 2021 07:53:39 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com (2603:10a6:4:74::9)
 by DB9PR08MB6714.eurprd08.prod.outlook.com (2603:10a6:10:2a4::18) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16; Fri, 15 Oct
 2021 07:53:38 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955]) by DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955%4]) with mapi id 15.20.4587.031; Fri, 15 Oct 2021
 07:53:38 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b54b31b3-7fc5-4067-9dcb-18dfcf5e4430
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ABdMiD04Gxw5eMEq5p6sZqHLoyqXrjYV0q5rUo713Zs=;
 b=aJSAkANCCBxUxjDTqnXBob4runt7f9iDtuOICjufYot26tqniLa8uZWUDGP/jzAau0xPTWZYOZHkhAGCJOewjZuchGdCUZzBkE7jqJw1eOR7jH7xiPi+wHdHksNE7CPlr+IqRdw48AomlepTR/7zS160ms7xiKAjGGdQKbQX1PA=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 60b9c6c90cce7ec8
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=nxs3K7H7hVWe2Or0+ilAd8MYNiRt3QuzCO7ph0pYjnJK0LRl/PH0zz9z2NyK5aaR258oU1r+FiI89xmKrr91tQ6u1a+yiHGrbUAH/FJ+AiXVEjnUQg1rlgzAGxjsZ8VnGxBUwzzbdMINKI34co8Zj3yLFIFZuZgFqFqMnWxJAt25UoXAXkyvoRj/z+kHJ6P0hJ2fGnVi9h37fRxpFv863FjUgqdgv1XiK1Ggj2+m9JeYKEI1MmF3BXq3WjRQPowgBMXrHIRp3TEL3kRO71eqeU+V4OiS+qOfdE/YiT5RCaaE5JNIVyiVmFfJApSs4iMetel5yFGaK1o6XqKKoTzfVw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ABdMiD04Gxw5eMEq5p6sZqHLoyqXrjYV0q5rUo713Zs=;
 b=b98kvZSQqX0AF8S1wPvgYPe16CQaohtoyMQBE+wN/iOeONV89/o5sa2zke0Dbmdc9BIQcQjSmZzwF72+yVzb7GTbQcfAM9oNvqcupzflSBoX9pEeKVoxps4A0qtre26wmOHZ8kdyZAnGiz0JJgtGQBeeDI06lqEKTR5cLYq5IHuntCGUdt6xhmsuZFic1mBcy5e7bPBNMltRw5qEnXSLyDMadEAhKfOIakPgTZ73Wl4MxW09G5QX+fOYu5EGRCY/fOVJ3ecRhm0dDIRd8Bb09blcPGKSkiGUWFYnaZtG6Y1VTKYhPCSreJuZY1G3+BQQ4GTEcNg1x7rb2+zH+O+gUg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ABdMiD04Gxw5eMEq5p6sZqHLoyqXrjYV0q5rUo713Zs=;
 b=aJSAkANCCBxUxjDTqnXBob4runt7f9iDtuOICjufYot26tqniLa8uZWUDGP/jzAau0xPTWZYOZHkhAGCJOewjZuchGdCUZzBkE7jqJw1eOR7jH7xiPi+wHdHksNE7CPlr+IqRdw48AomlepTR/7zS160ms7xiKAjGGdQKbQX1PA=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>, "iwj@xenproject.org"
	<iwj@xenproject.org>, Paul Durrant <paul@xen.org>, Jan Beulich
	<jbeulich@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu
	<wl@xen.org>
Subject: Re: [PATCH v6 1/3] xen/vpci: Move ecam access functions to common
 code
Thread-Topic: [PATCH v6 1/3] xen/vpci: Move ecam access functions to common
 code
Thread-Index: AQHXwQraA42SZeh0QUGI/xX7keuWA6vTrtGAgAACnoA=
Date: Fri, 15 Oct 2021 07:53:38 +0000
Message-ID: <EB6EE7F3-80BD-4717-87C7-C54FAB0FD832@arm.com>
References: <cover.1634221830.git.bertrand.marquis@arm.com>
 <ced6f870dbfabcfe8584555cc80f9a37a0655a0c.1634221830.git.bertrand.marquis@arm.com>
 <YWkxT1bVmBT7Av43@MacBook-Air-de-Roger.local>
In-Reply-To: <YWkxT1bVmBT7Av43@MacBook-Air-de-Roger.local>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3654.120.0.1.13)
Authentication-Results-Original: citrix.com; dkim=none (message not signed)
 header.d=none;citrix.com; dmarc=none action=none header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: 3b40f4a1-37e7-482d-60b3-08d98fb0ea9c
x-ms-traffictypediagnostic: DB9PR08MB6714:|DBBPR08MB4744:
X-Microsoft-Antispam-PRVS:
	<DBBPR08MB474498E51436E79AC589D9AA9DB99@DBBPR08MB4744.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:10000;OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 Pz4C3YNBonN/0t988/bAIK3vZqANUhcDJu0e9InFgF97vENmPL+IC445l4Bn8SyKnEbleEY8w/sxbeeg+5QUQSfB59wTiuduAYFeV31m1uXtMdSDBe92krPsSe0H14IxbwsniVHn4YzuiNx3hzDFD4tNkog8Xwv6tmUrpgXy29ebJoL5p4u8K0YE+aV+rB+i5VWNHWNBGj9PWcMyDqKR8IzWr/yhziWJMMmX8nBvgDAf0zKEKSYNgdH2HqyvPxUHpWGia6jO89eInkgdchHHMVOy42x4TmkJbSV0fXiV4hV4WxE4OX4GTRffsBpOnyKoUMKRh4/K2/Pvb3Bs7Dn2sbrSO9rl1L5f+gkA79huh44ESPKouHot8XLIF8fPFrvCmaNpiKN9R3rQ18Fp0oiQtlUg6brxyWUYorA1gvYuvYaT2Q6G9tMtgZtC3u1ajwLuzIhH+tKotIef09E3zM/omlzphbW0HAaxgQZA6LhRDKNhe7YjJHIgXGRheNpRKtARjrhr2tIOHVl3+QS7O8ZyiFt/2xn7hPJFM801Ku+zF6Q9anv74vjNEcBmMIa70updmbTo8fGNasCH4Cnqcjn9kL4bnE5roTTm/KautyMvTIriCH/8FaPI3pskTL+anpoAQ9slISneK6ddYsxTBqXg7fPqqloVvYjrICLuc91TkbGPfKbKRvf4dLxh8e3/lO7frR2NnyvkH3cWaNWbBRw6+rGgwCJtMrCodA6FwK5fklJRGI1MPnd0FnvsgBAuOBr+cifhjQNL6ReZ3yN1BLjEPSD4pd8gCvwT8fgreKg40YIq7DDFN0Pqz7vXWJrP3V9s
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB6PR0801MB2024.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(122000001)(4326008)(36756003)(966005)(508600001)(33656002)(38070700005)(54906003)(2906002)(316002)(53546011)(6506007)(5660300002)(86362001)(38100700002)(66556008)(8936002)(8676002)(2616005)(66476007)(66946007)(91956017)(76116006)(6916009)(64756008)(26005)(66446008)(71200400001)(6486002)(83380400001)(186003)(6512007)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="utf-8"
Content-ID: <FF4339637CE28D468C128BB93DD6442D@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB6714
Original-Authentication-Results: citrix.com; dkim=none (message not signed)
 header.d=none;citrix.com; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM5EUR03FT044.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	610ff8a7-65ad-40e9-6620-08d98fb0e5c6
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	drE0cFGrRO6bwvLfMHQOELxM/XwoHX0wvXRUswAa29R96X2Lrp6Vbpyc2qtPyziuQHZ42Ii9/B1/JgIVYqSqZXleSJPq8m5tClFBH+OwL1GkdZV0Y7YOlJwsVdEwse80yZ6wuDLgKFXB0SsRs+yFsKbiJUmeHO6mWWC32/bTORywuVx2OggF00S2TKGZkp0XWIQtDkRnOhWSnSpd7smdMOmMmtUCq4Aua8koesiuz6OfjjmdOX+IJ+TfLUrnzhKyJ5Ak28fsQyVZRpd+JL+44ut0Ig8tAenp1v8lVfOz9J/CjBBxDYLaw4UaRmvuz2gTe3e59+vB6imaNcGzwvWGmDeK6SVdk5dFyf6FOVUMjyBSOfGu3Nw9L5Jyoq1E2X27A2v+Dn4GfXoXhPrqxw3cS1gjbZm7e4arAT0e0boiJNTFrnQCfbwYR1jO5RZtlf/bfE5eUVung0b8qj/y6rtRSPRreqVOXmqfG6fCpW9C7GCU+P8MM12978pO0/4ptTJhSf8vUAhmXjRyy2p1Zuvpy01/SlcUIy0Nk36uS7OgUDwiK5yYzNZ9Il7LVUbrJlfpMh8N3xAkFrCDr/3tWfyCTZTBApas7F5dW4a43NVyipyrPmz/31vzW0ZVL3VBGyMvOtHqbK0+WfKlqI5JoKdW91b7i8Qi39CAWFkmpeEMOuQNlGxqLuIrGGUnEQ7Tdg4RGHdTWh7MpE1y6eEa+74kPhk/GVlSfopgU33S/F5r2t9yZoBhQ377T2gicolrU/DtIu4a7abYCEe+UeDB/rQd2ZQHU1PAGZX+HTZcRZppMw0=
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(2906002)(316002)(4326008)(54906003)(5660300002)(6506007)(53546011)(356005)(26005)(8936002)(70206006)(70586007)(2616005)(336012)(508600001)(966005)(186003)(8676002)(81166007)(86362001)(47076005)(6512007)(36860700001)(33656002)(36756003)(82310400003)(6862004)(6486002)(83380400001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2021 07:53:46.1800
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 3b40f4a1-37e7-482d-60b3-08d98fb0ea9c
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM5EUR03FT044.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB4744

SGkgUm9nZXIsDQoNCj4gT24gMTUgT2N0IDIwMjEsIGF0IDA4OjQ0LCBSb2dlciBQYXUgTW9ubsOp
IDxyb2dlci5wYXVAY2l0cml4LmNvbT4gd3JvdGU6DQo+IA0KPiBPbiBUaHUsIE9jdCAxNCwgMjAy
MSBhdCAwMzo0OTo0OVBNICswMTAwLCBCZXJ0cmFuZCBNYXJxdWlzIHdyb3RlOg0KPj4gUENJIHN0
YW5kYXJkIGlzIHVzaW5nIEVDQU0gYW5kIG5vdCBNQ0ZHIHdoaWNoIGlzIGNvbWluZyBmcm9tIEFD
UElbMV0uDQo+PiBVc2UgRUNBTS9lY2FtIGluc3RlYWQgb2YgTUNGRyBpbiBjb21tb24gY29kZSBh
bmQgaW4gbmV3IGZ1bmN0aW9ucyBhZGRlZA0KPj4gaW4gY29tbW9uIHZwY2kgY29kZSBieSB0aGlz
IHBhdGNoLg0KPj4gDQo+PiBSZW5hbWUgdnBjaV9hY2Nlc3NfYWxsb3dlZCB0byB2cGNpX2VjYW1f
YWNjZXNzX2FsbG93ZWQgYW5kIG1vdmUgaXQNCj4+IGZyb20gYXJjaC94ODYvaHZtL2lvLmMgdG8g
ZHJpdmVycy92cGNpL3ZwY2kuYy4NCj4+IA0KPj4gQ3JlYXRlIHZwY2lfZWNhbV9tbWlvX3tyZWFk
LHdyaXRlfSBpbiBkcml2ZXJzL3ZwY2kvdnBjaS5jIHRoYXQNCj4+IGNvbnRhaW5zIHRoZSBjb21t
b24gY29kZSB0byBwZXJmb3JtIHRoZXNlIG9wZXJhdGlvbnMsIGNoYW5nZWQNCj4+IHZwY2lfbW1j
Zmdfe3JlYWQsd3JpdGV9IGFjY29yZGluZ2x5IHRvIG1ha2UgdXNlIG9mIHRoZXNlIGZ1bmN0aW9u
cy4NCj4+IA0KPj4gVGhlIHZwY2lfZWNhbV9tbWlvX3tyZWFkLHdyaXRlfSBmdW5jdGlvbnMgYXJl
IHJldHVybmluZyAwIG9uIGVycm9yIGFuZCAxDQo+PiBvbiBzdWNjZXNzLiBBcyB0aGUgeDg2IGNv
ZGUgd2FzIHByZXZpb3VzbHkgYWx3YXlzIHJldHVybmluZyBYODZFTVVMX09LQVkNCj4+IHRoZSBy
ZXR1cm4gY29kZSBpcyBpZ25vcmVkLiBBIGNvbW1lbnQgaGFzIGJlZW4gYWRkZWQgaW4gdGhlIGNv
ZGUgdG8gc2hvdw0KPj4gdGhhdCB0aGlzIGlzIGludGVudGlvbmFsLg0KPj4gDQo+PiBUaG9zZSBm
dW5jdGlvbnMgd2lsbCBiZSB1c2VkIGluIGEgZm9sbG93aW5nIHBhdGNoIGluc2lkZSBieSBhcm0g
dnBjaQ0KPj4gaW1wbGVtZW50YXRpb24uDQo+PiANCj4+IFJlbmFtZSBNTUNGR19TQkRGIHRvIEVD
QU1fU0JERi4NCj4+IA0KPj4gTm90IGZ1bmN0aW9uYWwgY2hhbmdlIGludGVuZGVkIHdpdGggdGhp
cyBwYXRjaC4NCj4+IA0KPj4gWzFdIGh0dHBzOi8vd2lraS5vc2Rldi5vcmcvUENJX0V4cHJlc3MN
Cj4+IA0KPj4gU3VnZ2VzdGVkLWJ5OiBSb2dlciBQYXUgTW9ubsOpIDxyb2dlci5wYXVAY2l0cml4
LmNvbT4NCj4+IFNpZ25lZC1vZmYtYnk6IEJlcnRyYW5kIE1hcnF1aXMgPGJlcnRyYW5kLm1hcnF1
aXNAYXJtLmNvbT4NCj4+IC0tLQ0KPj4gQ2hhbmdlcyBpbiB2NjogUGF0Y2ggYWRkZWQNCj4+IC0t
LQ0KPj4geGVuL2FyY2gveDg2L2h2bS9pby5jICAgICB8IDUwICsrKysrLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tDQo+PiB4ZW4vZHJpdmVycy92cGNpL3ZwY2kuYyAgIHwgNjAgKysrKysrKysr
KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrDQo+PiB4ZW4vaW5jbHVkZS9hc20teDg2L3Bj
aS5oIHwgIDIgKy0NCj4+IHhlbi9pbmNsdWRlL3hlbi92cGNpLmggICAgfCAxMCArKysrKysrDQo+
PiA0IGZpbGVzIGNoYW5nZWQsIDc4IGluc2VydGlvbnMoKyksIDQ0IGRlbGV0aW9ucygtKQ0KPj4g
DQo+PiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gveDg2L2h2bS9pby5jIGIveGVuL2FyY2gveDg2L2h2
bS9pby5jDQo+PiBpbmRleCAwNDZhOGViNGVkLi4zNDBiOGM4YjBlIDEwMDY0NA0KPj4gLS0tIGEv
eGVuL2FyY2gveDg2L2h2bS9pby5jDQo+PiArKysgYi94ZW4vYXJjaC94ODYvaHZtL2lvLmMNCj4+
IEBAIC0yNjAsMjAgKzI2MCw2IEBAIHVuc2lnbmVkIGludCBodm1fcGNpX2RlY29kZV9hZGRyKHVu
c2lnbmVkIGludCBjZjgsIHVuc2lnbmVkIGludCBhZGRyLA0KPj4gICAgIHJldHVybiBDRjhfQURE
Ul9MTyhjZjgpIHwgKGFkZHIgJiAzKTsNCj4+IH0NCj4+IA0KPj4gLS8qIERvIHNvbWUgc2FuaXR5
IGNoZWNrcy4gKi8NCj4+IC1zdGF0aWMgYm9vbCB2cGNpX2FjY2Vzc19hbGxvd2VkKHVuc2lnbmVk
IGludCByZWcsIHVuc2lnbmVkIGludCBsZW4pDQo+PiAtew0KPj4gLSAgICAvKiBDaGVjayBhY2Nl
c3Mgc2l6ZS4gKi8NCj4+IC0gICAgaWYgKCBsZW4gIT0gMSAmJiBsZW4gIT0gMiAmJiBsZW4gIT0g
NCAmJiBsZW4gIT0gOCApDQo+PiAtICAgICAgICByZXR1cm4gZmFsc2U7DQo+PiAtDQo+PiAtICAg
IC8qIENoZWNrIHRoYXQgYWNjZXNzIGlzIHNpemUgYWxpZ25lZC4gKi8NCj4+IC0gICAgaWYgKCAo
cmVnICYgKGxlbiAtIDEpKSApDQo+PiAtICAgICAgICByZXR1cm4gZmFsc2U7DQo+PiAtDQo+PiAt
ICAgIHJldHVybiB0cnVlOw0KPj4gLX0NCj4+IC0NCj4+IC8qIHZQQ0kgY29uZmlnIHNwYWNlIElP
IHBvcnRzIGhhbmRsZXJzICgweGNmOC8weGNmYykuICovDQo+PiBzdGF0aWMgYm9vbCB2cGNpX3Bv
cnRpb19hY2NlcHQoY29uc3Qgc3RydWN0IGh2bV9pb19oYW5kbGVyICpoYW5kbGVyLA0KPj4gICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNvbnN0IGlvcmVxX3QgKnApDQo+PiBAQCAtMzA1
LDcgKzI5MSw3IEBAIHN0YXRpYyBpbnQgdnBjaV9wb3J0aW9fcmVhZChjb25zdCBzdHJ1Y3QgaHZt
X2lvX2hhbmRsZXIgKmhhbmRsZXIsDQo+PiANCj4+ICAgICByZWcgPSBodm1fcGNpX2RlY29kZV9h
ZGRyKGNmOCwgYWRkciwgJnNiZGYpOw0KPj4gDQo+PiAtICAgIGlmICggIXZwY2lfYWNjZXNzX2Fs
bG93ZWQocmVnLCBzaXplKSApDQo+PiArICAgIGlmICggIXZwY2lfZWNhbV9hY2Nlc3NfYWxsb3dl
ZChyZWcsIHNpemUpICkNCj4+ICAgICAgICAgcmV0dXJuIFg4NkVNVUxfT0tBWTsNCj4+IA0KPj4g
ICAgICpkYXRhID0gdnBjaV9yZWFkKHNiZGYsIHJlZywgc2l6ZSk7DQo+PiBAQCAtMzM1LDcgKzMy
MSw3IEBAIHN0YXRpYyBpbnQgdnBjaV9wb3J0aW9fd3JpdGUoY29uc3Qgc3RydWN0IGh2bV9pb19o
YW5kbGVyICpoYW5kbGVyLA0KPj4gDQo+PiAgICAgcmVnID0gaHZtX3BjaV9kZWNvZGVfYWRkcihj
ZjgsIGFkZHIsICZzYmRmKTsNCj4+IA0KPj4gLSAgICBpZiAoICF2cGNpX2FjY2Vzc19hbGxvd2Vk
KHJlZywgc2l6ZSkgKQ0KPj4gKyAgICBpZiAoICF2cGNpX2VjYW1fYWNjZXNzX2FsbG93ZWQocmVn
LCBzaXplKSApDQo+PiAgICAgICAgIHJldHVybiBYODZFTVVMX09LQVk7DQo+PiANCj4+ICAgICB2
cGNpX3dyaXRlKHNiZGYsIHJlZywgc2l6ZSwgZGF0YSk7DQo+PiBAQCAtMzk0LDcgKzM4MCw3IEBA
IHN0YXRpYyB1bnNpZ25lZCBpbnQgdnBjaV9tbWNmZ19kZWNvZGVfYWRkcihjb25zdCBzdHJ1Y3Qg
aHZtX21tY2ZnICptbWNmZywNCj4+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICBwYWRkcl90IGFkZHIsIHBjaV9zYmRmX3QgKnNiZGYpDQo+PiB7DQo+PiAgICAgYWRk
ciAtPSBtbWNmZy0+YWRkcjsNCj4+IC0gICAgc2JkZi0+YmRmID0gTU1DRkdfQkRGKGFkZHIpOw0K
Pj4gKyAgICBzYmRmLT5iZGYgPSBFQ0FNX0JERihhZGRyKTsNCj4+ICAgICBzYmRmLT5idXMgKz0g
bW1jZmctPnN0YXJ0X2J1czsNCj4+ICAgICBzYmRmLT5zZWcgPSBtbWNmZy0+c2VnbWVudDsNCj4+
IA0KPj4gQEAgLTQzNCwyNSArNDIwLDggQEAgc3RhdGljIGludCB2cGNpX21tY2ZnX3JlYWQoc3Ry
dWN0IHZjcHUgKnYsIHVuc2lnbmVkIGxvbmcgYWRkciwNCj4+ICAgICByZWcgPSB2cGNpX21tY2Zn
X2RlY29kZV9hZGRyKG1tY2ZnLCBhZGRyLCAmc2JkZik7DQo+PiAgICAgcmVhZF91bmxvY2soJmQt
PmFyY2guaHZtLm1tY2ZnX2xvY2spOw0KPj4gDQo+PiAtICAgIGlmICggIXZwY2lfYWNjZXNzX2Fs
bG93ZWQocmVnLCBsZW4pIHx8DQo+PiAtICAgICAgICAgKHJlZyArIGxlbikgPiBQQ0lfQ0ZHX1NQ
QUNFX0VYUF9TSVpFICkNCj4+IC0gICAgICAgIHJldHVybiBYODZFTVVMX09LQVk7DQo+PiAtDQo+
PiAtICAgIC8qDQo+PiAtICAgICAqIEFjY29yZGluZyB0byB0aGUgUENJZSAzLjFBIHNwZWNpZmlj
YXRpb246DQo+PiAtICAgICAqICAtIENvbmZpZ3VyYXRpb24gUmVhZHMgYW5kIFdyaXRlcyBtdXN0
IHVzdWFsbHkgYmUgRFdPUkQgb3Igc21hbGxlcg0KPj4gLSAgICAgKiAgICBpbiBzaXplLg0KPj4g
LSAgICAgKiAgLSBCZWNhdXNlIFJvb3QgQ29tcGxleCBpbXBsZW1lbnRhdGlvbnMgYXJlIG5vdCBy
ZXF1aXJlZCB0byBzdXBwb3J0DQo+PiAtICAgICAqICAgIGFjY2Vzc2VzIHRvIGEgUkNSQiB0aGF0
IGNyb3NzIERXIGJvdW5kYXJpZXMgWy4uLl0gc29mdHdhcmUNCj4+IC0gICAgICogICAgc2hvdWxk
IHRha2UgY2FyZSBub3QgdG8gY2F1c2UgdGhlIGdlbmVyYXRpb24gb2Ygc3VjaCBhY2Nlc3Nlcw0K
Pj4gLSAgICAgKiAgICB3aGVuIGFjY2Vzc2luZyBhIFJDUkIgdW5sZXNzIHRoZSBSb290IENvbXBs
ZXggd2lsbCBzdXBwb3J0IHRoZQ0KPj4gLSAgICAgKiAgICBhY2Nlc3MuDQo+PiAtICAgICAqICBY
ZW4gaG93ZXZlciBzdXBwb3J0cyA4Ynl0ZSBhY2Nlc3NlcyBieSBzcGxpdHRpbmcgdGhlbSBpbnRv
IHR3bw0KPj4gLSAgICAgKiAgNGJ5dGUgYWNjZXNzZXMuDQo+PiAtICAgICAqLw0KPj4gLSAgICAq
ZGF0YSA9IHZwY2lfcmVhZChzYmRmLCByZWcsIG1pbig0dSwgbGVuKSk7DQo+PiAtICAgIGlmICgg
bGVuID09IDggKQ0KPj4gLSAgICAgICAgKmRhdGEgfD0gKHVpbnQ2NF90KXZwY2lfcmVhZChzYmRm
LCByZWcgKyA0LCA0KSA8PCAzMjsNCj4+ICsgICAgLyogSWdub3JlIHJldHVybiBjb2RlICovDQo+
PiArICAgIHZwY2lfZWNhbV9tbWlvX3JlYWQoc2JkZiwgcmVnLCBsZW4sIGRhdGEpOw0KPiANCj4g
SSB0aGluayBpdCB3b3VsZCBiZSBiZXR0ZXIgZm9yIHZwY2lfZWNhbV9tbWlvX3JlYWQgdG8ganVz
dCByZXR1cm4gdGhlDQo+IHJlYWQgdmFsdWUsIG9yIH4wIGluIGNhc2Ugb2YgZXJyb3IsIGF0IGxl
YXN0IHRoYXQgaW50ZXJmYWNlIHdvdWxkIGJlDQo+IHNpbXBsZXIgYW5kIHN1aXRhYmxlIGZvciB4
ODYuDQoNCkkgYW0gbm90IHF1aXRlIHN1cmUgb24gdGhpcyBhcyBvbiBhYnNvbHV0ZSB0byByZWFk
IH4wIGlzIHBvc3NpYmxlIHNvIHRoZQ0KY2FsbGVyIGNhbm5vdCBkaXN0aW5ndWlzaCBiZXR3ZWVu
IHByb3Blcmx5IHJlYWRpbmcgfjAgb3IgYW4gYWNjZXNzIGFsbG93ZWQgZXJyb3IuDQoNCj4gDQo+
IEFsc28gSSB3b3VsZCBkcm9wIHRoZSBtbWlvIHBhcnQgZnJvbSB0aGUgZnVuY3Rpb24gbmFtZS4N
Cg0KT2sgSSB3aWxsIGRvIHRoYXQuDQoNCj4gDQo+PiANCj4+ICAgICByZXR1cm4gWDg2RU1VTF9P
S0FZOw0KPj4gfQ0KPj4gQEAgLTQ3NiwxMyArNDQ1LDggQEAgc3RhdGljIGludCB2cGNpX21tY2Zn
X3dyaXRlKHN0cnVjdCB2Y3B1ICp2LCB1bnNpZ25lZCBsb25nIGFkZHIsDQo+PiAgICAgcmVnID0g
dnBjaV9tbWNmZ19kZWNvZGVfYWRkcihtbWNmZywgYWRkciwgJnNiZGYpOw0KPj4gICAgIHJlYWRf
dW5sb2NrKCZkLT5hcmNoLmh2bS5tbWNmZ19sb2NrKTsNCj4+IA0KPj4gLSAgICBpZiAoICF2cGNp
X2FjY2Vzc19hbGxvd2VkKHJlZywgbGVuKSB8fA0KPj4gLSAgICAgICAgIChyZWcgKyBsZW4pID4g
UENJX0NGR19TUEFDRV9FWFBfU0laRSApDQo+PiAtICAgICAgICByZXR1cm4gWDg2RU1VTF9PS0FZ
Ow0KPj4gLQ0KPj4gLSAgICB2cGNpX3dyaXRlKHNiZGYsIHJlZywgbWluKDR1LCBsZW4pLCBkYXRh
KTsNCj4+IC0gICAgaWYgKCBsZW4gPT0gOCApDQo+PiAtICAgICAgICB2cGNpX3dyaXRlKHNiZGYs
IHJlZyArIDQsIDQsIGRhdGEgPj4gMzIpOw0KPj4gKyAgICAvKiBJZ25vcmUgcmV0dXJuIGNvZGUg
Ki8NCj4+ICsgICAgdnBjaV9lY2FtX21taW9fd3JpdGUoc2JkZiwgcmVnLCBsZW4sIGRhdGEpOw0K
PiANCj4gS2luZCBvZiBsaWtlbHkgaGVyZSwgeDg2IHdvdWxkIGJlIGZpbmUgd2l0aCB0aGlzIGZ1
bmN0aW9uIHJldHVybiB0eXBlDQo+IGJlaW5nIHZvaWQuDQo+IA0KPiBJZiB0aGF0J3Mgbm90IGdv
b2QgZm9yIEFybSwgSSB0aGluayB0aGUgY29tbWVudCBjYW4gYmUgZHJvcHBlZCBhcyBpdCdzDQo+
IGNsZWFyIHRoZSByZXR1cm4gY29kZSBpcyBpZ25vcmVkLiBJdCB3b3VsZCBiZXR0ZXIgdG8gbWF5
YmUgYWRkOg0KPiANCj4gLyogRmFpbGVkIHdyaXRlcyBhcmUgbm90IHByb3BhZ2F0ZWQgdG8gdGhl
IGNhbGxlciAqLw0KDQpJIHdpbGwgcmVwbGFjZSB0aGUgY3VycmVudCBjb21tZW50IGJ5IHRoaXMg
b25lLg0KDQo+IA0KPj4gDQo+PiAgICAgcmV0dXJuIFg4NkVNVUxfT0tBWTsNCj4+IH0NCj4+IGRp
ZmYgLS1naXQgYS94ZW4vZHJpdmVycy92cGNpL3ZwY2kuYyBiL3hlbi9kcml2ZXJzL3ZwY2kvdnBj
aS5jDQo+PiBpbmRleCBjYmQxYmFjN2ZjLi5jMDg1MzE3NmQ3IDEwMDY0NA0KPj4gLS0tIGEveGVu
L2RyaXZlcnMvdnBjaS92cGNpLmMNCj4+ICsrKyBiL3hlbi9kcml2ZXJzL3ZwY2kvdnBjaS5jDQo+
PiBAQCAtNDc4LDYgKzQ3OCw2NiBAQCB2b2lkIHZwY2lfd3JpdGUocGNpX3NiZGZfdCBzYmRmLCB1
bnNpZ25lZCBpbnQgcmVnLCB1bnNpZ25lZCBpbnQgc2l6ZSwNCj4+ICAgICBzcGluX3VubG9jaygm
cGRldi0+dnBjaS0+bG9jayk7DQo+PiB9DQo+PiANCj4+ICsvKiBIZWxwZXIgZnVuY3Rpb24gdG8g
Y2hlY2sgYW4gYWNjZXNzIHNpemUgYW5kIGFsaWdubWVudCBvbiB2cGNpIHNwYWNlLiAqLw0KPj4g
K2Jvb2wgdnBjaV9lY2FtX2FjY2Vzc19hbGxvd2VkKHVuc2lnbmVkIGludCByZWcsIHVuc2lnbmVk
IGludCBsZW4pDQo+PiArew0KPj4gKyAgICAvKg0KPj4gKyAgICAgKiBDaGVjayBhY2Nlc3Mgc2l6
ZS4NCj4+ICsgICAgICoNCj4+ICsgICAgICogT24gYXJtMzIgb3IgZm9yIDMyYml0IGd1ZXN0cyBv
biBhcm0sIDY0Yml0IGFjY2Vzc2VzIHNob3VsZCBiZSBmb3JiaWRkZW4NCj4+ICsgICAgICogYnV0
IGFzIGZvciB0aG9zZSBwbGF0Zm9ybSBJU1YgcmVnaXN0ZXIsIHdoaWNoIGdpdmVzIHRoZSBhY2Nl
c3Mgc2l6ZSwNCj4+ICsgICAgICogY2Fubm90IGhhdmUgYSB2YWx1ZSAzLCBjaGVja2luZyB0aGlz
IHdvdWxkIGp1c3QgaGFyZGVuIHRoZSBjb2RlLg0KPiANCj4gSXQgZmVlbHMga2luZCBvZiB3ZWly
ZCB0byBoYXZlIGFuIEFybSBzcGVjaWZpYyBjb21tZW50IGluIGNvbW1vbiBjb2RlLA0KPiBidXQg
SSBndWVzcyB0aGVyZSdzIG5vIGJldHRlciBwbGFjZSBmb3IgaXQgdG8gbGl2ZT8NCg0KRm9yIG5v
dyBJIHRoaW5rIEkgY2FuIG1vdmUgaXQgZGlyZWN0bHkgaW50byBhcm0gdnBjaSBjb2RlIGV2ZW4g
dGhvdWdoIGl0IGlzIG5vdCBwZXJmZWN0Lg0KDQpUaGFua3MgZm9yIHRoZSBjb21tZW50cw0KDQpS
ZWdhcmRzDQpCZXJ0cmFuZA0KDQo+IA0KPiBUaGFua3MsIFJvZ2VyLg0KDQo=


From xen-devel-bounces@lists.xenproject.org Fri Oct 15 08:00:42 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 08:00:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.209862.366430 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbI8q-0008QQ-4V; Fri, 15 Oct 2021 08:00:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 209862.366430; Fri, 15 Oct 2021 08:00:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbI8q-0008QJ-0G; Fri, 15 Oct 2021 08:00:36 +0000
Received: by outflank-mailman (input) for mailman id 209862;
 Fri, 15 Oct 2021 08:00:34 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=FGCa=PD=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mbI8o-0008QD-J5
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 08:00:34 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 4cecc61b-dc2a-4876-9602-b4af37ce4a79;
 Fri, 15 Oct 2021 08:00:33 +0000 (UTC)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2105.outbound.protection.outlook.com [104.47.18.105])
 (Using TLS) by relay.mimecast.com with ESMTP id
 de-mta-16-vze-wcxwMUuq0m212oZ8ag-1; Fri, 15 Oct 2021 10:00:31 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0402MB3934.eurprd04.prod.outlook.com (2603:10a6:803:1b::29)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.17; Fri, 15 Oct
 2021 08:00:29 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.017; Fri, 15 Oct 2021
 08:00:28 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS9PR06CA0117.eurprd06.prod.outlook.com (2603:10a6:20b:465::32) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15 via Frontend
 Transport; Fri, 15 Oct 2021 08:00:27 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4cecc61b-dc2a-4876-9602-b4af37ce4a79
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634284832;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=Tq+awYj+ZnEKgeRiE5OU/ofkwXDqqFRhPxxAft7XSNA=;
	b=hIUjJib6bJbE9uEXmBgbvgBJ8cffAk9FIfvUx10rCZe35XdtoShTMb4rSCtRjEf3RVJdFS
	9jY6YP5NSZU2cARAGiZhCqvLdWCyJ6e5VDwpUOyX7Dlir824c/Ba1yr4w25T+ZHTuxUPKT
	w+6fLjg6WJWqIFsT5J+FDm549l3EbIM=
X-MC-Unique: vze-wcxwMUuq0m212oZ8ag-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=UlDIhU0QF5na84842RwtxMSpqHFDjJZxoWqMflUX2X2Sw8bgfI0oH52wFQS0DQJDcNl5wcYLXdFtdwYKrFXN8NqQdDKVgPpWoaVa7VDWSP6Ui46dWLSELip8hKaFO5aQQWa/K+XCgusVFQ1t+4k72GZF9iDepFxruiVWze6zuggC4E8PWDPIqk67/by3GRvxmQmm6hcAabKMbpMcfUOI5OwcIQxI4+NQd57wqDOOuOfjzOW/Lu5dmf/9zYlGl+m42y45aYGk2KbluW1C7NuQHHPpQzAPIXC28Z3qvrbBTqp8Hw8IJU92wbLLupAJmYScgAbsRY3KFTuwSLHvjLgx/w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Tq+awYj+ZnEKgeRiE5OU/ofkwXDqqFRhPxxAft7XSNA=;
 b=JGi9UcExgNqQe0QU94+Tqn4/g0pzyU9Grlrenv6OaKl7j871LCdc/exXuMvzLVhhrLlFdzikg3ZoLMh8EvYfCnkMEWCQ74v9Mxp3Dctw3c1COn95E5PEmemZPH4AVKXG4dGpfgEGmYpBBXc9xBhj7JPHu1f7iLBzgk1Ni0kaehaBqYquFp/SzpJ4xVQn3QgzFNBTYsLbRdNe0Ry6irn3l6gq1FQtp1jesi47INSMsA4JOt2v6u2SnyQ/Hbunp7193SqtgNNuxua/pXhMaT/WVC8ogeAYQXZJ34mp4tEIuRx9bq5t48TEvqn8lesJ/Wi62kCIOLb+Pui3kECr8eC7ow==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [PATCH v6 2/3] xen/arm: Enable the existing x86 virtual PCI
 support for ARM.
To: Bertrand Marquis <bertrand.marquis@arm.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
Cc: iwj@xenproject.org, Rahul Singh <rahul.singh@arm.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
 Paul Durrant <paul@xen.org>, xen-devel@lists.xenproject.org
References: <cover.1634221830.git.bertrand.marquis@arm.com>
 <396b08e2598cf0338e0c7f4ad3cd5cb66db89224.1634221830.git.bertrand.marquis@arm.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <f41f59f7-69ed-e2fe-dc17-434b456cf693@suse.com>
Date: Fri, 15 Oct 2021 10:00:25 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <396b08e2598cf0338e0c7f4ad3cd5cb66db89224.1634221830.git.bertrand.marquis@arm.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0117.eurprd06.prod.outlook.com
 (2603:10a6:20b:465::32) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: d743cfd1-1105-409e-6e9a-08d98fb1da8c
X-MS-TrafficTypeDiagnostic: VI1PR0402MB3934:
X-Microsoft-Antispam-PRVS:
	<VI1PR0402MB39340A321015A5775A49E35EB3B99@VI1PR0402MB3934.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6108;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	nfmRcA/7FGPTj/wLqkN56G1r/GqMPRbsi1cMG1H0xN5e7GbBWaiytXWQ3EJcjwFRIyR5uOExXvjDVOa8ErsYIER7R2vVc31AH1CzzhRqiQcSsy1kNVPbrorz7ZSmGEp+19eIa/qZiYZIh8H6Bpl8dnHcSfBNLXXlxZPj4OgEvtZkXiBeZLlIc/YWNsvLiy44PqM+zJBCGZSAJUoJ5VRmHZn67YjTuWDDclE8nHmS2Z2ToTILNqzWOZuHWdticGy9H3f+KZrYMe8BiPx2ClS4IiNDoT8J168h2KlMrIyK9ImJQzfHiQFDqblpFkVsiSNP61QranS5QOteHDqS5uzOs0hRKk9r5k0vM/QmZv3XF/cyS2EhdcREG3N8W5k30HMGG/yYW+alHnDnZOW75a0FHddOPyW0qIYI7YZDzIWKfT7Hc+PXNZz3/GuctxzI6OaZ50xu6cGLCHbgG6NvYj+jLQpH5Ev2jXaKk2A+8gVma2WY7/3XPikonkWVr3DWxp1oM8h2pU1E2iHSX3Vuwi5QxuKjCqOaaB/2ZtOzRV5s04E7NMRH+laTWBKgegfUXKye2+pFrixUnLQ3Q5gSGNv4jC/12NMxfOWlw7Kd0rFgD+okfflrkYsgD19EJMl8oSD33dKz1/O+tILFbOQshC1NaU8yTJdsZkm3zaV7uQEvxEchh4el1et29By+CGe8Mqa4B/JOho39riUI8opapsQoO7XGqQO/vWEwLXJYw0wOiUI=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(66946007)(31686004)(38100700002)(66476007)(66556008)(5660300002)(26005)(83380400001)(31696002)(7416002)(508600001)(53546011)(86362001)(8676002)(36756003)(2616005)(8936002)(956004)(110136005)(6486002)(186003)(16576012)(2906002)(316002)(4326008)(54906003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?NlNxWEx5eVFrMTYwNDJJMEVkY3NycTBUN3NPM0tnak1oUGE3ZmVDc2hkUU5n?=
 =?utf-8?B?L3MyTDltOHY3V2F2UDFoL3NHTG41V2g1OGJ0YlVNb2Yrc016NFRxSXRsSmln?=
 =?utf-8?B?L0NYdldhQnRxaHR0VmFLQUdST25LSGtCdUcxV3Z2U1lVNTkvZ29RM3pNOVR1?=
 =?utf-8?B?TDNrMEFLeThJNWFvWkkrVTZjSDF4SEEzNEpDWndWZTNMY09LWHJrbjV3SGVh?=
 =?utf-8?B?NEw5bENQanJJVVluTXNialNkbVROZ1hDbmlZZURYVHk5dHhlODV5YmhReWdh?=
 =?utf-8?B?VGhGQVdMM3BWbjh1d1BXb2krYTFRazdTSXVIOG40ZEdyS25keXMyY0d1Z1Zp?=
 =?utf-8?B?a3dpUm5qZ1E1Mk1KNjJNYXIvQWNueFZvT2pEYVM4d1pBNXZuc3NONExDdjgx?=
 =?utf-8?B?NTEvbkM1em1sZXlIQUZ1Vjd6di9OSnV1ZXB3eGxVR29YRDZidnFPNG1yZUZV?=
 =?utf-8?B?UXFlUnA1NWlNeVN6OCttZElnZEZxTnNvRnlvK29HN0h5eDJtMnFjQkFja0JT?=
 =?utf-8?B?QkFvN1dYc1laeVlHaEdmTXFnQ3JtQ1pocXhRc2VYTVR3SFIrRVZkcjFvek90?=
 =?utf-8?B?eXlndnVoNGJGV0h2bnRDNS9kS0tzSlZwYlFLZUkzbnByb0JWa1NrNitsNW9H?=
 =?utf-8?B?NmRtSTQrTTN0VWdzdkYxbFNTN3VTaXkwZTJyUkJoeWVwMDVhdjlNTmtobk8z?=
 =?utf-8?B?aWh2Wk85Vy83Q2wzbHdlOExSM09jVnFLRGJKOU5SN2drWUZWVms3RC9pQmZ6?=
 =?utf-8?B?bTlYazNuQ2Z5akt3T0ZtM2dOaU9uS2V5U21qcFlyTlVtaXloRXB5K1VSYlZO?=
 =?utf-8?B?eE1YSTRyUHVPcVBnUTZveUlMY2Vvb0FNSnVCMjR3bStuWlRNSXV4d29hYmVh?=
 =?utf-8?B?SXZHQ0FpUTNNdzI4UjRYcnFOWGdsVEdUdFp2WGEvVjFNNFpMSTJPNFI4NWx4?=
 =?utf-8?B?QjBDMEdvc0VLak5scmVPeWRGbFRMRG5Ld096QTMwZUVGT1hCaGlPRFJKelNV?=
 =?utf-8?B?SlBBaTlIYXB5dWNFTm41VWdMYmtCMHltYXdKQzJQZVBQSi8ybTBFOTRjTTda?=
 =?utf-8?B?cUdxbVJCcGoramxYR2w2WnpGMmt1Wk5URWJ4RTR5NEJDWC8xQjF6SlJ3V2ZR?=
 =?utf-8?B?ZG54Z3F6ZlljdnFRYXNqeFc1RnBheGt3RzdOZnRZZ0hOQ1NrNVBjOFFqek1a?=
 =?utf-8?B?SVRxa2pPZnowb0VBSVlRdkU3RXlSbWprK2RZYnFMeS93Q0dDWEwybW5KdTVJ?=
 =?utf-8?B?TU1ydkZWMXJWVmtpZlNZalo4Uzg0NGxQS2hxTG00VlRuMFRTL3NOSmh0anh2?=
 =?utf-8?B?V3premt5TktVcHdXY280ckx4K25GaGhnZzRHb3R2RVZVYlJrdE5NYVFDMGlG?=
 =?utf-8?B?RkR0WEV5a1FlaFJjNkdYekZKTkZTMS8xb3Bjc2RHTHRscTFhR0tnU2FTWUda?=
 =?utf-8?B?VXQ2dE9VWjdVb21RNnU2NjdQQmhIdy9GNzlXZ1FMS2pkWHFNbk8ybmdKelZt?=
 =?utf-8?B?c1UveXdTOWFzK1liSXZ5TUVLMldZQTF4QVBqcGdhTnVyRlpuR2ZZQTUzSVhE?=
 =?utf-8?B?MDR4aEJMNSt2Z1Jua05qSm51UUNRRDBBcmVBcmZHTFVtWlZZcVZEaklIaVBK?=
 =?utf-8?B?Y04zK01KbENlcGQrcFpwS3ZHYkpUOHdmZnhNQkk4VFpyNHBTNjA3QmJObDI2?=
 =?utf-8?B?Z1hoUElmeEp5V1F3WkFkMk1odEVKelg2NW9sNzNaa0lrMHVScVdVTmhhV1ha?=
 =?utf-8?Q?LfUSrF8rD7PbSDRHXhA+uML3wAX2UjpYF46iKPJ?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d743cfd1-1105-409e-6e9a-08d98fb1da8c
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2021 08:00:28.9474
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Vleld+FHM3Sc6Dg6ccvgIWZ6aTc76WHvzvBdQ+O5lVCtCj0hhy3eJ2oiZDNFTXVYoACPQ28PnHhC2m1Qr2RYOg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3934

On 14.10.2021 16:49, Bertrand Marquis wrote:
> @@ -752,6 +752,19 @@ int pci_add_device(u16 seg, u8 bus, u8 devfn,
>  
>      check_pdev(pdev);
>  
> +#ifdef CONFIG_ARM
> +    /*
> +     * On ARM PCI devices discovery will be done by Dom0. Add vpci handler when
> +     * Dom0 inform XEN to add the PCI devices in XEN.
> +     */
> +    ret = vpci_add_handlers(pdev);
> +    if ( ret )
> +    {
> +        printk(XENLOG_ERR "Setup of vPCI failed: %d\n", ret);
> +        goto out;
> +    }
> +#endif
> +
>      ret = 0;
>      if ( !pdev->domain )

Elsewhere I did point out that you need to be careful wrt pdev->domain
being NULL. As the code in context clearly documents, you're now
adding handlers before that field was set. In comments to a prior
version I did already suggest to consider placing the new code inside
the if() in question (albeit at the time this was mainly to make clear
that error cleanup may not fiddle with things not put in place by the
iommu_enable_device() alternative path). This would have the further
benefit of making is crystal clear that here only handlers for Dom0
would get put in place (and hence their installing for DomU-s would
need to be looked for elsewhere).

> @@ -784,6 +797,9 @@ out:
>                     &PCI_SBDF(seg, bus, slot, func));
>          }
>      }
> +    else if ( pdev )
> +        pci_cleanup_msi(pdev);

Have you thoroughly checked that this call is benign on x86? There's
no wording to that effect in the description afaics, and I can't
easily convince myself that it would be correct when the
iommu_enable_device() path was taken. (I'm also not going to
exclude that it should have been there even prior to your work,
albeit then adding this would want to be a separate bugfix patch.)

> --- a/xen/drivers/vpci/header.c
> +++ b/xen/drivers/vpci/header.c
> @@ -374,7 +374,8 @@ static void bar_write(const struct pci_dev *pdev, unsigned int reg,
>          if ( val != (uint32_t)(bar->addr >> (hi ? 32 : 0)) )
>              gprintk(XENLOG_WARNING,
>                      "%pp: ignored BAR %lu write with memory decoding enabled\n",
> -                    &pdev->sbdf, bar - pdev->vpci->header.bars + hi);
> +                    &pdev->sbdf,
> +                    (unsigned long)(bar - pdev->vpci->header.bars + hi));

This looks like an entirely unrelated change which I'm afraid I don't
even understand why it needs making. The description says this is for
Arm32, but it remains unclear what the compilation error would have
been. My best guess is that perhaps you really mean to change the
format specifier to %zu (really this should be %td, but our vsprintf()
doesn't support 't' for whatever reason).

Please recall that we try to avoid casts where possible.

> --- a/xen/drivers/vpci/vpci.c
> +++ b/xen/drivers/vpci/vpci.c
> @@ -507,7 +507,7 @@ int vpci_ecam_mmio_write(pci_sbdf_t sbdf, unsigned int reg, unsigned int len,
>  
>      vpci_write(sbdf, reg, min(4u, len), data);
>      if ( len == 8 )
> -        vpci_write(sbdf, reg + 4, 4, data >> 32);
> +        vpci_write(sbdf, reg + 4, 4, (uint64_t)data >> 32);

I assume  the need for this change will go away with the use of
CONFIG_64BIT in the earlier patch.

> --- a/xen/include/xen/pci.h
> +++ b/xen/include/xen/pci.h
> @@ -40,6 +40,9 @@
>  #define PCI_SBDF3(s,b,df) \
>      ((pci_sbdf_t){ .sbdf = (((s) & 0xffff) << 16) | PCI_BDF2(b, df) })
>  
> +#define ECAM_BDF(addr)         ( ((addr) & 0x0ffff000) >> 12)
> +#define ECAM_REG_OFFSET(addr)  ((addr) & 0x00000fff)

The latter is fine to be put here (i.e. FTAOD I'm fine with it
staying here). For the former I even question its original placement
in asm-x86/pci.h: It's not generally correct as per the PCI spec, as
the bus portion of the address can be anywhere from 1 to 8 bits. And
in fact there is a reason why this macro was/is used in only a
single place, but not e.g. in x86'es handling of physical MCFG. It
is merely an implementation choice in vPCI that the entire segment 0
has a linear address range covering all 256 buses. Hence I think
this wants to move to xen/vpci.h and then perhaps also be named
VPCI_ECAM_BDF().

Also, as already pointed out on a much earlier version, while the
blank following the opening parenthesis was warranted in
asm-x86/pci.h for alignment reasons, it is no longer warranted here.
It was certainly gone in v4 and v5.

And one final nit: I don't think we commonly use full stops in patch
titles. (Personally I therefore also think titles shouldn't start
with a capital letter, but I know others think differently.)

Jan



From xen-devel-bounces@lists.xenproject.org Fri Oct 15 08:07:44 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 08:07:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.209872.366441 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbIFg-0000k0-TM; Fri, 15 Oct 2021 08:07:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 209872.366441; Fri, 15 Oct 2021 08:07:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbIFg-0000jt-Q2; Fri, 15 Oct 2021 08:07:40 +0000
Received: by outflank-mailman (input) for mailman id 209872;
 Fri, 15 Oct 2021 08:07:39 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=esao=PD=suse.com=jgross@srs-us1.protection.inumbo.net>)
 id 1mbIFf-0000jn-O5
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 08:07:39 +0000
Received: from smtp-out2.suse.de (unknown [195.135.220.29])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id f4fe7bbf-2d8e-11ec-8227-12813bfff9fa;
 Fri, 15 Oct 2021 08:07:37 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id B00791FD39;
 Fri, 15 Oct 2021 08:07:36 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 82C3713A9C;
 Fri, 15 Oct 2021 08:07:36 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id FlS4Hsg2aWGgfgAAMHmgww
 (envelope-from <jgross@suse.com>); Fri, 15 Oct 2021 08:07:36 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f4fe7bbf-2d8e-11ec-8227-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1634285256; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=3zgN+myWPBqYFRmvK+j+wUzYK3zNb9TBfy2y3lYjKJI=;
	b=gjUxZbM3h8p6m0v8VUa78NvOx1WeoO2Jo9IELK51tdyGS0XP+1oBmhC0bv5zMQnUkrb1nd
	5/1EAHDjo8e3ONZxVAZhvg+JGPfWDlhHkAO/zJE+sHKIpg6RimAO21mgS9LgQrmfb8RPt2
	lMNvNFiQgaurL4ecXpMvDy0CYWYhvj8=
Subject: Re: [PATCH v6 1/3] usb: Add Xen pvUSB protocol description
To: Greg KH <greg@kroah.com>
Cc: linux-usb@vger.kernel.org, xen-devel@lists.xenproject.org,
 linux-kernel@vger.kernel.org, Boris Ostrovsky <boris.ostrovsky@oracle.com>,
 Stefano Stabellini <sstabellini@kernel.org>
References: <20211013075207.13910-1-jgross@suse.com>
 <20211013075207.13910-2-jgross@suse.com> <YWbKnEMvHGU/rv96@kroah.com>
From: Juergen Gross <jgross@suse.com>
Message-ID: <54da6414-4183-2d0c-cc24-a9471ed8332b@suse.com>
Date: Fri, 15 Oct 2021 10:07:35 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <YWbKnEMvHGU/rv96@kroah.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="1AL0cPpr5ivk43VHNW6HPPQSETbcwK4QV"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--1AL0cPpr5ivk43VHNW6HPPQSETbcwK4QV
Content-Type: multipart/mixed; boundary="VIW7wmtVR3xkM2QJxXfKkqFg4bP298XiF";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Greg KH <greg@kroah.com>
Cc: linux-usb@vger.kernel.org, xen-devel@lists.xenproject.org,
 linux-kernel@vger.kernel.org, Boris Ostrovsky <boris.ostrovsky@oracle.com>,
 Stefano Stabellini <sstabellini@kernel.org>
Message-ID: <54da6414-4183-2d0c-cc24-a9471ed8332b@suse.com>
Subject: Re: [PATCH v6 1/3] usb: Add Xen pvUSB protocol description
References: <20211013075207.13910-1-jgross@suse.com>
 <20211013075207.13910-2-jgross@suse.com> <YWbKnEMvHGU/rv96@kroah.com>
In-Reply-To: <YWbKnEMvHGU/rv96@kroah.com>

--VIW7wmtVR3xkM2QJxXfKkqFg4bP298XiF
Content-Type: multipart/mixed;
 boundary="------------14B33D5C604B74B5090F9B0A"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------14B33D5C604B74B5090F9B0A
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 13.10.21 14:01, Greg KH wrote:
> On Wed, Oct 13, 2021 at 09:52:05AM +0200, Juergen Gross wrote:
>> Add the definition of pvUSB protocol used between the pvUSB frontend i=
n
>> a Xen domU and the pvUSB backend in a Xen driver domain (usually Dom0)=
=2E
>>
>> This header was originally provided by Fujitsu for Xen based on Linux
>> 2.6.18.
>>
>> Changes are:
>> - adapt to Linux kernel style guide
>> - use Xen namespace
>> - add lots of comments
>> - don't use kernel internal defines
>>
>> Signed-off-by: Juergen Gross <jgross@suse.com>
>> Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
>> ---
>>   include/xen/interface/io/usbif.h | 421 +++++++++++++++++++++++++++++=
++
>>   1 file changed, 421 insertions(+)
>>   create mode 100644 include/xen/interface/io/usbif.h
>>
>> diff --git a/include/xen/interface/io/usbif.h b/include/xen/interface/=
io/usbif.h
>> new file mode 100644
>> index 000000000000..9494b1c9be99
>> --- /dev/null
>> +++ b/include/xen/interface/io/usbif.h
>> @@ -0,0 +1,421 @@
>> +/*
>> + * usbif.h
>> + *
>> + * USB I/O interface for Xen guest OSes.
>> + *
>> + * Copyright (C) 2009, FUJITSU LABORATORIES LTD.
>> + * Author: Noboru Iwamatsu <n_iwamatsu@jp.fujitsu.com>
>> + *
>> + * Permission is hereby granted, free of charge, to any person obtain=
ing a copy
>> + * of this software and associated documentation files (the "Software=
"), to
>> + * deal in the Software without restriction, including without limita=
tion the
>> + * rights to use, copy, modify, merge, publish, distribute, sublicens=
e, and/or
>> + * sell copies of the Software, and to permit persons to whom the Sof=
tware is
>> + * furnished to do so, subject to the following conditions:
>> + *
>> + * The above copyright notice and this permission notice shall be inc=
luded in
>> + * all copies or substantial portions of the Software.
>> + *
>> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EX=
PRESS OR
>> + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTAB=
ILITY,
>> + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT =
SHALL THE
>> + * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR O=
THER
>> + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, AR=
ISING
>> + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHE=
R
>> + * DEALINGS IN THE SOFTWARE.
>> + */
>=20
> Please use a SPDX line and not license "boilerplate" text like this :(

Okay. Is this your only concern for this series? Or is it a blocking
point for you before looking into it in more detail?

IOW: does it make sense for me to wait for further comments before
sending a new version of the series?


Juergen

--------------14B33D5C604B74B5090F9B0A
Content-Type: application/pgp-keys;
 name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Transfer-Encoding: quoted-printable
Content-Description: OpenPGP public key
Content-Disposition: attachment;
 filename="OpenPGP_0xB0DE9DD628BF132F.asc"

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy=
cWx
w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O=
f8Z
d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y=
9bf
IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq=
G7/
377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR=
3Jv
c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA=
QIe
AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT=
hpw
dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0=
MbD
1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv=
oPH
Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v=
5QL
+qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ=
2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC=
QoL
BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr=
Wf0
teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC=
/nu
AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh=
ITT
d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm=
XBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz=
80h
SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC=
AcD
AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn=
FOX
gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1=
jnD
kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0=
N51
N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l=
otu
fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1=
tqS
EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA=
hsD
BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3=
g3O
ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5=
dM7
wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5=
D+j
LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm=
V2x
AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N=
Eaw
QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW=
nHI
s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR=
wgn
BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV=
bVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk=
pEd
IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA=
QAB
wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw=
Tbe
8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1=
vJz
Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8=
VGi
wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW=
svi
uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX=
zXs
ZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------14B33D5C604B74B5090F9B0A--

--VIW7wmtVR3xkM2QJxXfKkqFg4bP298XiF--

--1AL0cPpr5ivk43VHNW6HPPQSETbcwK4QV
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmFpNscFAwAAAAAACgkQsN6d1ii/Ey9I
oQf+JHfh17hWBy1gUj3DRKyBJD5Y3mI+TOUvtyUzxOTKkfrJCL9PhsxKNU9Fk79GhrCuwsjNRxiA
1u4TNChP5ejQn8ohgQ/jCQlq5hvvSblEixbMXOzf8U4Mu66+fSPUofu3AF2awHlrBRM9GSFFlb0n
UAMgXt+DYjAywwI4jkyDosYXscBiBybZtPYNmuIlRZxtwsz53Knh3cdT8rugoXGyq1C/Salepf++
nS8XzgZg/QfRcuuS3wNKp0NC8QxlKOTc9w6zPa1rwT828dHjayiY0YtjV6XE8ncocmhpd+j+us1c
u04/VwImDRDChbK69ujnfeXBmBi6NHC3HscdedQhdA==
=bvvE
-----END PGP SIGNATURE-----

--1AL0cPpr5ivk43VHNW6HPPQSETbcwK4QV--


From xen-devel-bounces@lists.xenproject.org Fri Oct 15 08:13:37 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 08:13:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.209881.366451 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbILN-000289-Hl; Fri, 15 Oct 2021 08:13:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 209881.366451; Fri, 15 Oct 2021 08:13:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbILN-000282-En; Fri, 15 Oct 2021 08:13:33 +0000
Received: by outflank-mailman (input) for mailman id 209881;
 Fri, 15 Oct 2021 08:13:32 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=FGCa=PD=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mbILM-00027w-KP
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 08:13:32 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id c7c7e29c-2d8f-11ec-8227-12813bfff9fa;
 Fri, 15 Oct 2021 08:13:30 +0000 (UTC)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2059.outbound.protection.outlook.com [104.47.13.59]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-11-iEm7GL59P4O0A_wZhzPs7A-1; Fri, 15 Oct 2021 10:13:28 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB6176.eurprd04.prod.outlook.com (2603:10a6:803:f6::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.17; Fri, 15 Oct
 2021 08:13:26 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.017; Fri, 15 Oct 2021
 08:13:26 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM7PR03CA0017.eurprd03.prod.outlook.com (2603:10a6:20b:130::27) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16 via Frontend
 Transport; Fri, 15 Oct 2021 08:13:25 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c7c7e29c-2d8f-11ec-8227-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634285609;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=G45z5wBSzGBfXED+oSoJraWC/ttXCnIGd8DrKcdFqVQ=;
	b=M3BX5+b0db+NmlyTioL4D3pqp6j87Eh6VsddAiComZyc94nzTjJfL7TvcMHQChvH5XHnoK
	FKSdb4+WHusx7jLXiYPN6LgQZUPwkYEDgK57JjCGvhf48NplfUyXTV57xe3Ca56YtzcbKj
	+Dg++GE0FKWnmDJVrWHbvLRba7OFz2k=
X-MC-Unique: iEm7GL59P4O0A_wZhzPs7A-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=lLP0TsDcpRLTAwb17doCTDD6nGHdTBqj2Vwly4TJU2FR8OtGFdWzUMa0k32k/e8fndkLdnZbLX6WdbkwC8o9bVxfY0vNJ32afT+wwjZ5vp7nGdu2z5SeYhTNvZoKkuhHmqBo3i9FO8Jj/37XTTgzB7mLo3w0YfauRs3jAg+OyMRkXwDLlAbUfTVhr8IYOY5++rUyOe3idSo1c21elPFLfBhwULdmHb8fBtCUlRFH+/y6Rwq9NFLILxFOKWvdpsLAAiHdnRSl77JYiBzlfDZFIJRFbbC0/llM+TLOIOpmdva3vwoMBTCaUQLLtpie22UeMU4o6HNdIcPAnoqg5VVO8A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=G45z5wBSzGBfXED+oSoJraWC/ttXCnIGd8DrKcdFqVQ=;
 b=PDTT7Kej2n3Tp/rDdmsFynv7OxM4hW2t9IHiCf0TVmtn3tHUBMBRFqtmSAEkyliOBCLua9gRbtEAbNLHTZ16ZXImkzFaHp5uOAqhdC/kZxuD483bB4IeQ99KZXyBVObM0k97xnDwtR6kIFYQGoG/s9Vkbkfzp9iIk3XKOjQDZcgCKZ6oySePHrCPJobg14Yu5hynPcNejcCInzs9Mygxxhp4gMyJN/HgNs1USIRg2BQVYILxIv0XvRFCA9bpEJRnHOSkVJPjfuvlS6aOGrsRPMoTK5iHc4BaBqpyGsPolf+VuRlVBDoQRCJ21bbJCdn7RALtFQp4yBPU1/nX7wQN1Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: xen.org; dkim=none (message not signed)
 header.d=none;xen.org; dmarc=none action=none header.from=suse.com;
Subject: Re: [PATCH v6 1/3] xen/vpci: Move ecam access functions to common
 code
To: Bertrand Marquis <Bertrand.Marquis@arm.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
Cc: Ian Jackson <iwj@xenproject.org>, Paul Durrant <paul@xen.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Julien Grall <julien@xen.org>
References: <cover.1634221830.git.bertrand.marquis@arm.com>
 <ced6f870dbfabcfe8584555cc80f9a37a0655a0c.1634221830.git.bertrand.marquis@arm.com>
 <20c73f4e-5a8b-c127-f3a7-b841f50b1a4a@suse.com>
 <6C71E132-0A78-4DA4-AA52-E62833912145@arm.com>
 <8a7d1370-ee58-8e95-efea-8e4162e1e5f7@suse.com>
 <152124C4-9A34-4F5B-B6C5-CBCC6A175665@arm.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <9f0f8e0b-c989-d2ae-39eb-6784446fa6c3@suse.com>
Date: Fri, 15 Oct 2021 10:13:24 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <152124C4-9A34-4F5B-B6C5-CBCC6A175665@arm.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM7PR03CA0017.eurprd03.prod.outlook.com
 (2603:10a6:20b:130::27) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: cac025c8-da4e-4982-7f4f-08d98fb3aa32
X-MS-TrafficTypeDiagnostic: VI1PR04MB6176:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB6176AE10A6A1C71F58124F86B3B99@VI1PR04MB6176.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	oKjvIJHKO944Oevx1vAHEcduNvWFL/9YLjl/xsrMxZ8pr1XGWlrS1gXm8bkNggZNhpjVgle/HwkHo/r7pZloldPonOZf4M/CE4fyUVTb+y4dAjI8Qghj0LuQUmbNyTwt6SNcDqS7nGP1yRbsuaUU9zvi7++uluLM0+yqqZQDpjwbwpNMlZDSr0LRpPOftpM+08tfatSWOfj1yw894qB9GVzdb6MyYllxkKj4azvjDu7MSHldTFzzgOhuFZz2xMisMjSfc7NOu37X0KE9ubxeZbZH15TwZP+RkMtm1P1nmxCN9U0rMop+5RQZhX18B2LKVpeV7GYmISGSMBMpveqQo6Ff5TV6bnwWA8e2is0Zqe1Oa265nHkbP6kpy9QwUAM0/9mAGdBbpsDEp7oHhDG0ckyZ1MDeueYaZDBAd+ixfEyUbDJzBPFiSXGCXeasV4uLHV/TG6Prr7/AKlYCjrqs9AXZmOmrRrifU9Jzadbr6TXTDqJSsOGC58tUThpPbOwq2+5qz2Ych9urQPkRW5ABZUmkIr5amQlgkY9vy5O28pMW+YNFiGjqpn5oxzkR7uxLaNiKWeLmrlePpARpHCcp2VLPXfkVj3FYEMHts9hjOY3vEdnB8y9tmrNcem0mebiod7dDuTuC0fRaa4Z52bxRHPpbGZWjYIz7L29JCpe4EtvS2Qo9MlLnTNsnl2l9FZyjOo2HUxmyCeSEW3IIrMoTkazqI2FvJC4m+CGMFvDE0fD4whfQAjM4+evmn7jJCfjZ
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(26005)(31686004)(8676002)(66556008)(66476007)(6486002)(16576012)(8936002)(4326008)(66946007)(86362001)(956004)(508600001)(2616005)(316002)(38100700002)(54906003)(110136005)(5660300002)(36756003)(186003)(2906002)(31696002)(53546011)(83380400001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?MUI4MDBpaTBSK3J1Q1d1WWw1S2NKMGxtVm4vL01BWC9naW9FbURKUWtPbDBB?=
 =?utf-8?B?WnpGY1RmWURUV3hKK3pJSXVHQVJMM2p3bis1NHpqVWtrbXhXczI2LzJtTXdO?=
 =?utf-8?B?WnlmSWF3TzlLL1lhZFkxamJFbndKUnVxOXYxVVFkaGFRRVFaY2ZaeElKRGFv?=
 =?utf-8?B?TEFBMWFFcEMvazkwMzJ0T1l2Y3pUSHpLOGVnUTQ4cjRoc1BOd2k0Y3hsUTVL?=
 =?utf-8?B?VGtrVEtTd2VqOGNXcG04Z05nQzRRL0huMEVDYWVGTHhZYnh2d29YaWg5NFZR?=
 =?utf-8?B?MUhJNmJ6TFlXQmZpTmxEd0NXTW1iOGZRK2h4dG5LdTVDNERsOG5KK2hYeFNj?=
 =?utf-8?B?NkphclIxbEE5SkU4RnArQ0crZi9nazVERHo3VVFqOUN2NUdJYldYWHNhdkk5?=
 =?utf-8?B?eUM3OXFtaUpKNUxjV215VkNSWVk1NnlzdTQvSWpPZWhQQzNnK3NITXpzYk1B?=
 =?utf-8?B?OGZFa1VnL1Bub2txV09zeVhEOGdoUlJvR254bERrSFBxTlFLaVduN3VjVGdj?=
 =?utf-8?B?U1lJTmRVMThXMjl4NUdONk9mekdZQ1hmaGg3V3lndXI2WmFoZ2g5SThiWWRF?=
 =?utf-8?B?MERhOVdlSVNKdEFxalJEdG80TkFkWXBoU2d2RTgzbitxUUVmWjVDdmRwV3VL?=
 =?utf-8?B?ajFoM0tHZENWKzI5eldjWFN5UkNsZVBPYW5rVmlhbmVudjRsVGZnOVpBcktG?=
 =?utf-8?B?UlpIK0pvc3pUV1Foc21QVWdTY3RwNnRRdy93NTl4V2p1a2NhRUIxTnVSR1JC?=
 =?utf-8?B?eVo3RXphSmUvMDNwQVJidmEwUDhldWZ4dnZIcUpaNUpyclUrcUNDeHlDUXJT?=
 =?utf-8?B?Z255d0orZ1Y3eXFFeHBZZHF1VlFZUjR5VzBvVWcwaGgzeEdESUhVcUI1d2J1?=
 =?utf-8?B?N0wyTG9NZkpkckwvcjFhL01KclJoci9rMVdtY2hhNXcvMmJnaVBBdGlFcE5w?=
 =?utf-8?B?eXcrZno4b01NOE5janJZaTJIK214RlArNDhTc0tGQWkveG9xempxUnBRenhK?=
 =?utf-8?B?eTJ5anlhTCtneTFOM0s1YisyUjJoMzhTTDljYXFrY3RQQTNxSDd1dFA0K2Ry?=
 =?utf-8?B?aXo5RmRydy9HWUMvVndsS1pSdWFaZTBwcHhnNUp3REhuQUZvWjdZZjJHNGV5?=
 =?utf-8?B?dUk5RWxxdlBDUCtSZ1FEU1hpeUpKdWdmSGZKTUdpbFpBM0RSem5OK2FpZEFB?=
 =?utf-8?B?bk9jbWhtcXEzTW1XYjYrUkNWMEt4NEhzcmdhYUZDaXRZMHV3OVVKREx0UGxx?=
 =?utf-8?B?bVdNSXRsVEhnUDR4WUpITGNhenNvZFU1QmxDdXhRNHhzUGdnR01peEJwZzE3?=
 =?utf-8?B?M3psRFlMT05kOUNldmkyRXVtNVV0N2JVOExrN0poOGVIUkNneVRuOTUrRFdI?=
 =?utf-8?B?a2NPWGQyTHRELzd4NHUvOXl2SU5lNVVPbmN3MTFkdVpvSU9DTDdod2FFWFE1?=
 =?utf-8?B?Z1kyVDdNUWdGOGxHUUtJRWs2T1FaRGlMWk1rbU1vd2JpT2M4WmFvdEs0Q0p4?=
 =?utf-8?B?cHRoYWJVRjhWYklsM2QxVVpLY1dDaWZPa3Z5c0VETHF0NDlYeWlIa01IK1pm?=
 =?utf-8?B?bHMxRmNWL0U1aVN2ZE1aS29xZXRrTTJPNkhybXVnRTFsYjZSMkdGTFN5WHd5?=
 =?utf-8?B?LzB6a2lXL0k0MFF6N3I3aXk2dVFTdzhjNFptSUtaWFpzV01JSlpLbTVGT0hH?=
 =?utf-8?B?MXpHcGlWbkdOS3YzOWg5aHF3ZVBleTNVTkgrU0tRTTQxVW9zeTFmR3MwMFNr?=
 =?utf-8?Q?5O58HvpifL1/fU/cNZjDkuNKG/5OIpymq8Vj2fJ?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cac025c8-da4e-4982-7f4f-08d98fb3aa32
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2021 08:13:26.8439
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: HOn8HCF9ERpTNOzV1+bL3+kly1WgOc8WSqHcC9dacioFMzDdC9fhqc+EG1AnlFVT0dV29m0Rb8TxMZ59C+Q6hQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6176

On 15.10.2021 09:37, Bertrand Marquis wrote:
>> On 15 Oct 2021, at 07:29, Jan Beulich <jbeulich@suse.com> wrote:
>> On 14.10.2021 19:09, Bertrand Marquis wrote:
>>>> On 14 Oct 2021, at 17:06, Jan Beulich <jbeulich@suse.com> wrote:
>>>> On 14.10.2021 16:49, Bertrand Marquis wrote:
>>>>> @@ -305,7 +291,7 @@ static int vpci_portio_read(const struct hvm_io_handler *handler,
>>>>>
>>>>>    reg = hvm_pci_decode_addr(cf8, addr, &sbdf);
>>>>>
>>>>> -    if ( !vpci_access_allowed(reg, size) )
>>>>> +    if ( !vpci_ecam_access_allowed(reg, size) )
>>>>>        return X86EMUL_OKAY;
>>>>>
>>>>>    *data = vpci_read(sbdf, reg, size);
>>>>> @@ -335,7 +321,7 @@ static int vpci_portio_write(const struct hvm_io_handler *handler,
>>>>>
>>>>>    reg = hvm_pci_decode_addr(cf8, addr, &sbdf);
>>>>>
>>>>> -    if ( !vpci_access_allowed(reg, size) )
>>>>> +    if ( !vpci_ecam_access_allowed(reg, size) )
>>>>>        return X86EMUL_OKAY;
>>>>>
>>>>>    vpci_write(sbdf, reg, size, data);
>>>>
>>>> Why would port I/O functions call an ECAM helper? And in how far is
>>>> that helper actually ECAM-specific?
>>>
>>> The function was global before.
>>
>> I'm not objecting to the function being global, but to the "ecam" in
>> its name.
> 
> Adding ecam in the name was a request from Roger.
> This is just a consequence of this.

Roger - did you have in mind the uses here when asking for the addition
of "ecam"?

> One suggestion here could be to turn vpci_ecam_access_allowed into
> vpci_access_allowed

That's what I'm asking for.

> and maybe put this into vpci.h as a static inline ?

I'm not overly fussed here.

>>>>> @@ -434,25 +420,8 @@ static int vpci_mmcfg_read(struct vcpu *v, unsigned long addr,
>>>>>    reg = vpci_mmcfg_decode_addr(mmcfg, addr, &sbdf);
>>>>>    read_unlock(&d->arch.hvm.mmcfg_lock);
>>>>>
>>>>> -    if ( !vpci_access_allowed(reg, len) ||
>>>>> -         (reg + len) > PCI_CFG_SPACE_EXP_SIZE )
>>>>> -        return X86EMUL_OKAY;
>>>>
>>>> While I assume this earlier behavior is the reason for ...
>>>
>>> Yes :-)
>>>
>>>>
>>>>> -    /*
>>>>> -     * According to the PCIe 3.1A specification:
>>>>> -     *  - Configuration Reads and Writes must usually be DWORD or smaller
>>>>> -     *    in size.
>>>>> -     *  - Because Root Complex implementations are not required to support
>>>>> -     *    accesses to a RCRB that cross DW boundaries [...] software
>>>>> -     *    should take care not to cause the generation of such accesses
>>>>> -     *    when accessing a RCRB unless the Root Complex will support the
>>>>> -     *    access.
>>>>> -     *  Xen however supports 8byte accesses by splitting them into two
>>>>> -     *  4byte accesses.
>>>>> -     */
>>>>> -    *data = vpci_read(sbdf, reg, min(4u, len));
>>>>> -    if ( len == 8 )
>>>>> -        *data |= (uint64_t)vpci_read(sbdf, reg + 4, 4) << 32;
>>>>> +    /* Ignore return code */
>>>>> +    vpci_ecam_mmio_read(sbdf, reg, len, data);
>>>>
>>>> ... the commented-upon ignoring of the return value, I don't think
>>>> that's a good way to deal with things anymore. Instead I think
>>>> *data should be written to ~0 upon failure, unless it is intended
>>>> for vpci_ecam_mmio_read() to take care of that case (in which case
>>>> I'm not sure I would see why it needs to return an error indicator
>>>> in the first place).
>>>
>>> I am not sure in the first place why this is actually ignored and just
>>> returning a -1 value.
>>> If an access is not right, an exception should be generated to the
>>> Guest instead.
>>
>> No. That's also not what happens on bare metal, at least not on x86.
>> Faults cannot be raised for reasons outside of the CPU; such errors
>> (if these are errors in the first place) need to be dealt with
>> differently. Signaling an error on the PCI bus would be possible,
>> but would leave open how that's actually to be dealt with. Instead
>> bad reads return all ones, while bad writes simply get dropped.
> 
> So that behaviour is kept here on x86 and I think as the function is
> generic it is right for it to return an error here. It is up to the caller to
> ignore it or not.
> To make this more generic I could return 0 on success and -EACCESS,
> the caller would then handle it as he wants.

I think boolean is sufficient here, but I wouldn't object to errno-
style return values. All I do object to is int when boolean is meant.

>>>>> +int vpci_ecam_mmio_write(pci_sbdf_t sbdf, unsigned int reg, unsigned int len,
>>>>> +                         unsigned long data)
>>>>> +{
>>>>> +    if ( !vpci_ecam_access_allowed(reg, len) ||
>>>>> +         (reg + len) > PCI_CFG_SPACE_EXP_SIZE )
>>>>> +        return 0;
>>>>> +
>>>>> +    vpci_write(sbdf, reg, min(4u, len), data);
>>>>> +    if ( len == 8 )
>>>>> +        vpci_write(sbdf, reg + 4, 4, data >> 32);
>>>>> +
>>>>> +    return 1;
>>>>> +}
>>>>> +
>>>>> +int vpci_ecam_mmio_read(pci_sbdf_t sbdf, unsigned int reg, unsigned int len,
>>>>> +                        unsigned long *data)
>>>>> +{
>>>>> +    if ( !vpci_ecam_access_allowed(reg, len) ||
>>>>> +         (reg + len) > PCI_CFG_SPACE_EXP_SIZE )
>>>>> +        return 0;
>>>>> +
>>>>> +    /*
>>>>> +     * According to the PCIe 3.1A specification:
>>>>> +     *  - Configuration Reads and Writes must usually be DWORD or smaller
>>>>> +     *    in size.
>>>>> +     *  - Because Root Complex implementations are not required to support
>>>>> +     *    accesses to a RCRB that cross DW boundaries [...] software
>>>>> +     *    should take care not to cause the generation of such accesses
>>>>> +     *    when accessing a RCRB unless the Root Complex will support the
>>>>> +     *    access.
>>>>> +     *  Xen however supports 8byte accesses by splitting them into two
>>>>> +     *  4byte accesses.
>>>>> +     */
>>>>> +    *data = vpci_read(sbdf, reg, min(4u, len));
>>>>> +    if ( len == 8 )
>>>>> +        *data |= (uint64_t)vpci_read(sbdf, reg + 4, 4) << 32;
>>>>> +
>>>>> +    return 1;
>>>>> +}
>>>>
>>>> Why do these two functions return int/0/1 instead of
>>>> bool/false/true (assuming, as per above, that them returning non-
>>>> void is warranted at all)?
>>>
>>> This is what the mmio handlers should return to say that an access
>>> was ok or not so the function stick to this standard.
>>
>> Sticking to this would be okay if the functions here needed their
>> address taken, such that they can be installed as hooks for a
>> more general framework to invoke. The functions, however, only get
>> called directly. Hence there's no reason to mirror what is in need
>> of cleaning up elsewhere. I'm sure you're aware there we're in the
>> (slow going) process of improving which types get used where.
>> While the functions you refer to may not have undergone such
>> cleanup yet, we generally expect new code to conform to the new
>> model.
> 
> I am ok to rename those to vpci_ecam_{read/write}.
> Is it what you want ?

Yes, that's what I've been asking for, and I just saw Roger requesting
the same. (I'm a little puzzled about the context though, as you reply
looks disconnected here.)

Jan



From xen-devel-bounces@lists.xenproject.org Fri Oct 15 08:14:16 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 08:14:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.209887.366462 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbIM3-0002gM-Sa; Fri, 15 Oct 2021 08:14:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 209887.366462; Fri, 15 Oct 2021 08:14:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbIM3-0002gF-PH; Fri, 15 Oct 2021 08:14:15 +0000
Received: by outflank-mailman (input) for mailman id 209887;
 Fri, 15 Oct 2021 08:14:14 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=D3dH=PD=kroah.com=greg@srs-us1.protection.inumbo.net>)
 id 1mbIM1-0002g1-Kt
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 08:14:13 +0000
Received: from wnew4-smtp.messagingengine.com (unknown [64.147.123.18])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id e0f459e4-2d8f-11ec-8227-12813bfff9fa;
 Fri, 15 Oct 2021 08:14:12 +0000 (UTC)
Received: from compute5.internal (compute5.nyi.internal [10.202.2.45])
 by mailnew.west.internal (Postfix) with ESMTP id 85FF52B01252;
 Fri, 15 Oct 2021 04:14:10 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
 by compute5.internal (MEProxy); Fri, 15 Oct 2021 04:14:11 -0400
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri,
 15 Oct 2021 04:14:09 -0400 (EDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e0f459e4-2d8f-11ec-8227-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kroah.com; h=
	date:from:to:cc:subject:message-id:references:mime-version
	:content-type:in-reply-to; s=fm2; bh=A0sZcq8K/bMEVM6Z/GmabDSwCYf
	1knmEGs8b2zvlHhQ=; b=ZzfVVTn6dbh38/j3OKZRepxl9kEa3guxDRvTHgZd9UZ
	5v475Ji0wfwDq8R0BC5n6i6uI1xKhG5QXS0vU3PQrvzwCJVxNVwe4Q3512+yPov1
	FYna5xLUZmgHh55dF+5IblbiJhBiLy5Lk/tOfcYAdbifrOTRSWP62RBtkhSZfW3i
	noblBfXvaOS8rffbJ0VqHO6LzAmEdQpjLKXszHkSSGlYTUuL5UKzyeB7liYAZYFA
	2Ac2+WCIL4kXLzCZd/+moJDiL7W5ZhzTRIdM+zB9s7rqraSsP/ZvtbWGUbH3+yfT
	+XyOdsbt1tSkpZPPAY/l1GmDYFRVKSc1QEpg8utzK4A==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:content-type:date:from:in-reply-to
	:message-id:mime-version:references:subject:to:x-me-proxy
	:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=A0sZcq
	8K/bMEVM6Z/GmabDSwCYf1knmEGs8b2zvlHhQ=; b=ktnorKikd3Z9v0GZ3qijQN
	mrCxmSbMkQNrE3w3/8mM0hlt+mshhb7YU59TimV2tezcpmFUJPCdswYfjfG7ro47
	PDHegrv1krJQQgFNCwLew5Rpfifynr/p6Dzwe29TSHr18aMmrAwv9eoZhGwTenAs
	/eaS/6rtthi1IAm/k3FWU9/PaxqnQaAnv2pk1NlhQvD4jCGfJSEowNmD9yyxhv36
	R0s/LDMbPXQ7a6tHTzn2lo0nIaLXbG4hI1shprTDIcCKT+wMmhVgqee0b8k0sghz
	+6pzsualiK/tq28vlmbADF/pwGmUP95FCFO/dEHC1SUgpoaYi8h9io+lPLZcDmNw
	==
X-ME-Sender: <xms:UjhpYRPTiuE9SZFAtEfWxUkUSryt8k573jnHMcFlMSCE7rEiGbJZIQ>
    <xme:UjhpYT8NORnxJzMdUwfTNbaLl-iZE-PH8Vsalz4pXJhFAHbXW010MTQsTbryIUES1
    B8r9WcroCVgRg>
X-ME-Received: <xmr:UjhpYQSWpc5je8X1tcnumCxR0zoEDhW2JunBMtH2lfDL3xU-QQQoq9RWQbEQfk5wAgAOt1NkTHu_7vMzGhe8Ety9oTb2A68l>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrvddugedgtdduucetufdoteggodetrfdotf
    fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
    uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
    cujfgurhepfffhvffukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpefirhgvghcu
    mffjuceoghhrvghgsehkrhhorghhrdgtohhmqeenucggtffrrghtthgvrhhnpeevueehje
    fgfffgiedvudekvdektdelleelgefhleejieeugeegveeuuddukedvteenucevlhhushht
    vghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehgrhgvgheskhhrohgrhh
    drtghomh
X-ME-Proxy: <xmx:UjhpYdvj28l7TDdqA2-jLKTA9OEvEj_vWHcs9zbvFXVtgalUSfFNwQ>
    <xmx:UjhpYZeKfrVBkpFmWCOcb47rgpnfb4Vfl2NuJXkDQc5pbTelAOf4Ug>
    <xmx:UjhpYZ1Ify1N6dGT5gBMC7Is-KSKADbopgPoGoIPmpwcQbyPWvxJlA>
    <xmx:UjhpYaXwCA88UchI6-C-P-N4WqV4iFPayIOkbPqljl8sh1hLc2T5STfKXGE>
Date: Fri, 15 Oct 2021 10:14:07 +0200
From: Greg KH <greg@kroah.com>
To: Juergen Gross <jgross@suse.com>
Cc: linux-usb@vger.kernel.org, xen-devel@lists.xenproject.org,
	linux-kernel@vger.kernel.org,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>
Subject: Re: [PATCH v6 1/3] usb: Add Xen pvUSB protocol description
Message-ID: <YWk4T2HTAD3VJMYR@kroah.com>
References: <20211013075207.13910-1-jgross@suse.com>
 <20211013075207.13910-2-jgross@suse.com>
 <YWbKnEMvHGU/rv96@kroah.com>
 <54da6414-4183-2d0c-cc24-a9471ed8332b@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <54da6414-4183-2d0c-cc24-a9471ed8332b@suse.com>

On Fri, Oct 15, 2021 at 10:07:35AM +0200, Juergen Gross wrote:
> On 13.10.21 14:01, Greg KH wrote:
> > On Wed, Oct 13, 2021 at 09:52:05AM +0200, Juergen Gross wrote:
> > > Add the definition of pvUSB protocol used between the pvUSB frontend in
> > > a Xen domU and the pvUSB backend in a Xen driver domain (usually Dom0).
> > > 
> > > This header was originally provided by Fujitsu for Xen based on Linux
> > > 2.6.18.
> > > 
> > > Changes are:
> > > - adapt to Linux kernel style guide
> > > - use Xen namespace
> > > - add lots of comments
> > > - don't use kernel internal defines
> > > 
> > > Signed-off-by: Juergen Gross <jgross@suse.com>
> > > Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> > > ---
> > >   include/xen/interface/io/usbif.h | 421 +++++++++++++++++++++++++++++++
> > >   1 file changed, 421 insertions(+)
> > >   create mode 100644 include/xen/interface/io/usbif.h
> > > 
> > > diff --git a/include/xen/interface/io/usbif.h b/include/xen/interface/io/usbif.h
> > > new file mode 100644
> > > index 000000000000..9494b1c9be99
> > > --- /dev/null
> > > +++ b/include/xen/interface/io/usbif.h
> > > @@ -0,0 +1,421 @@
> > > +/*
> > > + * usbif.h
> > > + *
> > > + * USB I/O interface for Xen guest OSes.
> > > + *
> > > + * Copyright (C) 2009, FUJITSU LABORATORIES LTD.
> > > + * Author: Noboru Iwamatsu <n_iwamatsu@jp.fujitsu.com>
> > > + *
> > > + * Permission is hereby granted, free of charge, to any person obtaining a copy
> > > + * of this software and associated documentation files (the "Software"), to
> > > + * deal in the Software without restriction, including without limitation the
> > > + * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or
> > > + * sell copies of the Software, and to permit persons to whom the Software is
> > > + * furnished to do so, subject to the following conditions:
> > > + *
> > > + * The above copyright notice and this permission notice shall be included in
> > > + * all copies or substantial portions of the Software.
> > > + *
> > > + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
> > > + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
> > > + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
> > > + * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
> > > + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
> > > + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
> > > + * DEALINGS IN THE SOFTWARE.
> > > + */
> > 
> > Please use a SPDX line and not license "boilerplate" text like this :(
> 
> Okay. Is this your only concern for this series? Or is it a blocking
> point for you before looking into it in more detail?

It was an easy thing to see at first glance that you hadn't taken my
previous comment about this seriously :(

> IOW: does it make sense for me to wait for further comments before
> sending a new version of the series?

Sure, you can fix this up and resend, it will take a while to review the
host controller code...

thanks,

greg k-h


From xen-devel-bounces@lists.xenproject.org Fri Oct 15 08:20:37 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 08:20:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.209897.366473 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbIS8-0004Ck-Lc; Fri, 15 Oct 2021 08:20:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 209897.366473; Fri, 15 Oct 2021 08:20:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbIS8-0004Cd-IV; Fri, 15 Oct 2021 08:20:32 +0000
Received: by outflank-mailman (input) for mailman id 209897;
 Fri, 15 Oct 2021 08:20:31 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Fqmt=PD=arm.com=Bertrand.Marquis@srs-us1.protection.inumbo.net>)
 id 1mbIS7-0004CX-6k
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 08:20:31 +0000
Received: from EUR02-HE1-obe.outbound.protection.outlook.com (unknown
 [2a01:111:f400:fe05::62e])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 032c2502-997a-4c87-bb9e-711e47385fac;
 Fri, 15 Oct 2021 08:20:29 +0000 (UTC)
Received: from AS9PR06CA0315.eurprd06.prod.outlook.com (2603:10a6:20b:45b::26)
 by PR3PR08MB5836.eurprd08.prod.outlook.com (2603:10a6:102:8f::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15; Fri, 15 Oct
 2021 08:20:27 +0000
Received: from AM5EUR03FT019.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:45b:cafe::60) by AS9PR06CA0315.outlook.office365.com
 (2603:10a6:20b:45b::26) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15 via Frontend
 Transport; Fri, 15 Oct 2021 08:20:27 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM5EUR03FT019.mail.protection.outlook.com (10.152.16.104) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.15 via Frontend Transport; Fri, 15 Oct 2021 08:20:26 +0000
Received: ("Tessian outbound f1898412aff1:v103");
 Fri, 15 Oct 2021 08:20:26 +0000
Received: from cb940565f6c6.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 ED9F4B0D-2D6D-46D2-ACAE-939B3A9A21D0.1; 
 Fri, 15 Oct 2021 08:20:19 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id cb940565f6c6.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 15 Oct 2021 08:20:19 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com (2603:10a6:4:74::9)
 by DBBPR08MB4919.eurprd08.prod.outlook.com (2603:10a6:10:f0::16) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.17; Fri, 15 Oct
 2021 08:20:16 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955]) by DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955%4]) with mapi id 15.20.4587.031; Fri, 15 Oct 2021
 08:20:16 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 032c2502-997a-4c87-bb9e-711e47385fac
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ylyEFr7ZRm/Rji1Q2XsNjohqntNHuiA+r7nCGnGWRz0=;
 b=dVcA3oyze7nQH8an2B0dOC5GP3gjxLCpRNf3eA1FYKMWbYJGcaWegrGUYBhxg829jVj+xed6YMlQ1nFRdLN1HDLYjNrmQnKl31sIxsV+/EtByitxlfFCIrkBveOqVdZ7ny69y40NKbhYvoTXPsjzITsead7WgPUfYGJf/mMtCow=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: d7b6ecd2e8583707
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=bSDwOoP/GJ7hASwkFBn7Yx0nWCRlpFAd/GWK8ttS8rwQk/UXeH0cS07Ee6t028kxKHpxfd4IIwiTB6roS/+0yU6Q5gswD6iccVWtzKyb6eh6xiXwznkY8p0qp60GB5LALmAUMlYFZGWF3G1gS8Hy1Oh05XQZK/094N8rhF+8ADQZyWk7v8xDzTrK3oHqH6yO0X5tZKCPPc+HTDa5HrmT+wSbq+Y/cwhsFn+iVy6t2QROaucEndnS33GzjFNWbJIgE0esDUKdpFc78P9SMZYmr6yaPe29XIIB7CGFu1QgAyPNqVxMWvNg/kQu5yHmYJehOQ7P0CYnZTaHNje1MwXazQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ylyEFr7ZRm/Rji1Q2XsNjohqntNHuiA+r7nCGnGWRz0=;
 b=jq5ySdjlnvgOpdEq5xqhDq5VWoaf7rh6XPqkQkSIfmfV/KtbmRB+WADfOrjrcRPCy984Uh9rmDMc2lc37lVYIPaM219Llkpfo5/blXZMbv+QjOHv5H2MEmZ2vQRnEnvyVm+fsIF1aAGti1tCG9fjE4OXp/gNU1ai4Rvj2RBnve7N1155M6DhVoWJpa6x4DXUP4oyoTJn0K38wKZPqRcTP8jhF0h8Ih6NNZcb+N6WytCynVj1Q6wL+rVC/X9NhSMsKFdaBB51rcVpUmspgYlf9bG9Yf6L1PLd6jJXKnk6SZusPbk5hJS/dNDZZC1cVZp/swgD+X3C/1E0w35jbba2HQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ylyEFr7ZRm/Rji1Q2XsNjohqntNHuiA+r7nCGnGWRz0=;
 b=dVcA3oyze7nQH8an2B0dOC5GP3gjxLCpRNf3eA1FYKMWbYJGcaWegrGUYBhxg829jVj+xed6YMlQ1nFRdLN1HDLYjNrmQnKl31sIxsV+/EtByitxlfFCIrkBveOqVdZ7ny69y40NKbhYvoTXPsjzITsead7WgPUfYGJf/mMtCow=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Jan Beulich <jbeulich@suse.com>
CC: =?iso-8859-1?Q?Roger_Pau_Monn=E9?= <roger.pau@citrix.com>, Ian Jackson
	<iwj@xenproject.org>, Paul Durrant <paul@xen.org>, Andrew Cooper
	<andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Julien
 Grall <julien@xen.org>
Subject: Re: [PATCH v6 1/3] xen/vpci: Move ecam access functions to common
 code
Thread-Topic: [PATCH v6 1/3] xen/vpci: Move ecam access functions to common
 code
Thread-Index:
 AQHXwQraA42SZeh0QUGI/xX7keuWA6vSqLgAgAARnQCAAN+ngIAAEtoAgAAKIACAAAHqgA==
Date: Fri, 15 Oct 2021 08:20:16 +0000
Message-ID: <9B9BE725-53E4-49CC-80EC-E856081E08ED@arm.com>
References: <cover.1634221830.git.bertrand.marquis@arm.com>
 <ced6f870dbfabcfe8584555cc80f9a37a0655a0c.1634221830.git.bertrand.marquis@arm.com>
 <20c73f4e-5a8b-c127-f3a7-b841f50b1a4a@suse.com>
 <6C71E132-0A78-4DA4-AA52-E62833912145@arm.com>
 <8a7d1370-ee58-8e95-efea-8e4162e1e5f7@suse.com>
 <152124C4-9A34-4F5B-B6C5-CBCC6A175665@arm.com>
 <9f0f8e0b-c989-d2ae-39eb-6784446fa6c3@suse.com>
In-Reply-To: <9f0f8e0b-c989-d2ae-39eb-6784446fa6c3@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3654.120.0.1.13)
Authentication-Results-Original: suse.com; dkim=none (message not signed)
 header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: e39ba81e-105a-4d16-5421-08d98fb4a4af
x-ms-traffictypediagnostic: DBBPR08MB4919:|PR3PR08MB5836:
X-Microsoft-Antispam-PRVS:
	<PR3PR08MB58360AF3FC99BD59BEDCFB2C9DB99@PR3PR08MB5836.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:10000;OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 b1WM6mg+DgfzSTV9kwgC8Q+Etv8M9BfJN1y0/gDN/dw/lfMex5TclHkPQFalMfey4mjmUYW1HJQ1KOz+AFsmK2TTRpNSLxkKVDnedMfHXWewUcww7W0XHfnxc3Jm1PUZ1nV09jiZS3PuJ4SGuXWNJMY7Plppd51k8YcqDlOlCcRNhHDgP88E+NpldPrzy7jcsbFFJ/044tUEXfX3XpUMpRHFV3BcjxxmLeI9VUa/gPrIjiveOG3YqBZvbmkeDXFGgjtDAVWrx9MY3kRfHtOXhx0ic1CeGBY2HkDGBXwLa/Uzwa7iHPxXaOxfo1WfTuAOEY9lOusqYNL3E4veMxATjZ8nXow2ivDowguZgsrDclm4BaDMBv95w2gzEWWz4CL1l2IhOtNcvErFDFg1kRRNS0UjCXkcJng2C9m0EjHc/P2eCd/S7+CQw5mWryAkoOMeQj1MU2dpjkS82lT2nRXQoP/QYDkCxZZ9plUfoz61oMxpcxvXNbby8TTMRfjwl8LD5Y24fnL2czB/kqslIe0NiA3Kf9zy9trCgm55VqsDwo9y1eD17gDyan4rmNZhbfvoCBdaUVG4k5LTRltYCC7h11SrcDyGCKoXZ+UvzTTbAzTK3n3AN4ivD+ml1zgelSba7Fk9Mvsp1NgkZvtxUdm2Tz6A7mqesxZ3F/k5K9EOU6hGWnpB6rR+BRlkb7afRANP4qCB6lI+T9oFlFRVi2xjXxOd3XqSd/9Lldx1ioUj9dHRzNu0uLtndGaRCbmPX/Nr
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB6PR0801MB2024.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(316002)(8676002)(53546011)(508600001)(2616005)(4326008)(33656002)(71200400001)(6506007)(83380400001)(54906003)(36756003)(6512007)(38070700005)(186003)(66446008)(64756008)(66946007)(66556008)(66476007)(8936002)(6916009)(76116006)(6486002)(86362001)(2906002)(5660300002)(91956017)(38100700002)(26005)(122000001)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="iso-8859-1"
Content-ID: <B9B8C73115548D478BADE4306F689147@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB4919
Original-Authentication-Results: suse.com; dkim=none (message not signed)
 header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM5EUR03FT019.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	8634fa75-38e6-47c5-1352-08d98fb49e9b
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	LvUIwMxx2I8YAv1LibWItFKloFR4T47RYB9rCy/Bs9kehZ14Q/oT653djGY6W2D3FTW4ouff62lhHtRffWoW8GKjIpXbpPpwLo6hCP0fyOXuwKpGQyC/n+fbCJ3n3WP8POS6ZZXwKcngv/z2f0t2m8Qp973gEW4L9matJ0cVeAXMWK6v3/HUM6tQblVz4L8isauPYkcMk1aUWryWTSU4+ebUcMOOQQMRSDNDApS4KjGpgB+4EiXpnc0Qx/kO9o8W8/LnpK/t0w2lxmW1W6mj+Y/TehpQUFCWuIoagSL5wMJy5j7oBnJAedkGymmLyrXhqJm2oU/dG7I9BVGZaOJAzsylSxOFqjaLT8JMayfmjbZSzHapIFWWGF4WdZcWdN4pnaXA9YiU1yciYL3Kxyuuq/AvncnEiC73fNg9xAobfCHlHerBf215tdlH87puoVny8un7rAw1Jcr8xXrmgbyhiUuV1oxi6wqPFV9yK27GYDyZCvKHK/44VFPA2updycQQV52PBscaq7ZcmF/LaQ7G3ccnEJOtsQYkX7Io8JuCReImh5C46ESnfhmWICgw0wt/AZvaoUh1hIqmdMc6gbnSMJh6A3QsmDh1FYFb9A7aUYPLYRx7Yc1WJldSlEqoLaeeo9wQdWJiQU6jQZtUCEF4QwjLNo4Bq7eskz7cTpx3oXxH+67IRn2Y8ybMXhrp0wvqLBrqG3hTrI9hUaQl5/TGcA==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(8676002)(82310400003)(4326008)(508600001)(8936002)(81166007)(6506007)(6862004)(47076005)(6486002)(53546011)(316002)(83380400001)(36860700001)(70206006)(86362001)(70586007)(33656002)(5660300002)(36756003)(54906003)(356005)(186003)(6512007)(336012)(2906002)(2616005)(26005);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2021 08:20:26.8915
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: e39ba81e-105a-4d16-5421-08d98fb4a4af
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM5EUR03FT019.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR08MB5836

Hi Jan,

> On 15 Oct 2021, at 09:13, Jan Beulich <jbeulich@suse.com> wrote:
>=20
> On 15.10.2021 09:37, Bertrand Marquis wrote:
>>> On 15 Oct 2021, at 07:29, Jan Beulich <jbeulich@suse.com> wrote:
>>> On 14.10.2021 19:09, Bertrand Marquis wrote:
>>>>> On 14 Oct 2021, at 17:06, Jan Beulich <jbeulich@suse.com> wrote:
>>>>> On 14.10.2021 16:49, Bertrand Marquis wrote:
>>>>>> @@ -305,7 +291,7 @@ static int vpci_portio_read(const struct hvm_io_=
handler *handler,
>>>>>>=20
>>>>>>   reg =3D hvm_pci_decode_addr(cf8, addr, &sbdf);
>>>>>>=20
>>>>>> -    if ( !vpci_access_allowed(reg, size) )
>>>>>> +    if ( !vpci_ecam_access_allowed(reg, size) )
>>>>>>       return X86EMUL_OKAY;
>>>>>>=20
>>>>>>   *data =3D vpci_read(sbdf, reg, size);
>>>>>> @@ -335,7 +321,7 @@ static int vpci_portio_write(const struct hvm_io=
_handler *handler,
>>>>>>=20
>>>>>>   reg =3D hvm_pci_decode_addr(cf8, addr, &sbdf);
>>>>>>=20
>>>>>> -    if ( !vpci_access_allowed(reg, size) )
>>>>>> +    if ( !vpci_ecam_access_allowed(reg, size) )
>>>>>>       return X86EMUL_OKAY;
>>>>>>=20
>>>>>>   vpci_write(sbdf, reg, size, data);
>>>>>=20
>>>>> Why would port I/O functions call an ECAM helper? And in how far is
>>>>> that helper actually ECAM-specific?
>>>>=20
>>>> The function was global before.
>>>=20
>>> I'm not objecting to the function being global, but to the "ecam" in
>>> its name.
>>=20
>> Adding ecam in the name was a request from Roger.
>> This is just a consequence of this.
>=20
> Roger - did you have in mind the uses here when asking for the addition
> of "ecam"?
>=20
>> One suggestion here could be to turn vpci_ecam_access_allowed into
>> vpci_access_allowed
>=20
> That's what I'm asking for.

Will do

>=20
>> and maybe put this into vpci.h as a static inline ?
>=20
> I'm not overly fussed here.

Was just a suggestion, I am ok to just rename it and keep it where it is.

>=20
>>>>>> @@ -434,25 +420,8 @@ static int vpci_mmcfg_read(struct vcpu *v, unsi=
gned long addr,
>>>>>>   reg =3D vpci_mmcfg_decode_addr(mmcfg, addr, &sbdf);
>>>>>>   read_unlock(&d->arch.hvm.mmcfg_lock);
>>>>>>=20
>>>>>> -    if ( !vpci_access_allowed(reg, len) ||
>>>>>> -         (reg + len) > PCI_CFG_SPACE_EXP_SIZE )
>>>>>> -        return X86EMUL_OKAY;
>>>>>=20
>>>>> While I assume this earlier behavior is the reason for ...
>>>>=20
>>>> Yes :-)
>>>>=20
>>>>>=20
>>>>>> -    /*
>>>>>> -     * According to the PCIe 3.1A specification:
>>>>>> -     *  - Configuration Reads and Writes must usually be DWORD or s=
maller
>>>>>> -     *    in size.
>>>>>> -     *  - Because Root Complex implementations are not required to =
support
>>>>>> -     *    accesses to a RCRB that cross DW boundaries [...] softwar=
e
>>>>>> -     *    should take care not to cause the generation of such acce=
sses
>>>>>> -     *    when accessing a RCRB unless the Root Complex will suppor=
t the
>>>>>> -     *    access.
>>>>>> -     *  Xen however supports 8byte accesses by splitting them into =
two
>>>>>> -     *  4byte accesses.
>>>>>> -     */
>>>>>> -    *data =3D vpci_read(sbdf, reg, min(4u, len));
>>>>>> -    if ( len =3D=3D 8 )
>>>>>> -        *data |=3D (uint64_t)vpci_read(sbdf, reg + 4, 4) << 32;
>>>>>> +    /* Ignore return code */
>>>>>> +    vpci_ecam_mmio_read(sbdf, reg, len, data);
>>>>>=20
>>>>> ... the commented-upon ignoring of the return value, I don't think
>>>>> that's a good way to deal with things anymore. Instead I think
>>>>> *data should be written to ~0 upon failure, unless it is intended
>>>>> for vpci_ecam_mmio_read() to take care of that case (in which case
>>>>> I'm not sure I would see why it needs to return an error indicator
>>>>> in the first place).
>>>>=20
>>>> I am not sure in the first place why this is actually ignored and just
>>>> returning a -1 value.
>>>> If an access is not right, an exception should be generated to the
>>>> Guest instead.
>>>=20
>>> No. That's also not what happens on bare metal, at least not on x86.
>>> Faults cannot be raised for reasons outside of the CPU; such errors
>>> (if these are errors in the first place) need to be dealt with
>>> differently. Signaling an error on the PCI bus would be possible,
>>> but would leave open how that's actually to be dealt with. Instead
>>> bad reads return all ones, while bad writes simply get dropped.
>>=20
>> So that behaviour is kept here on x86 and I think as the function is
>> generic it is right for it to return an error here. It is up to the call=
er to
>> ignore it or not.
>> To make this more generic I could return 0 on success and -EACCESS,
>> the caller would then handle it as he wants.
>=20
> I think boolean is sufficient here, but I wouldn't object to errno-
> style return values. All I do object to is int when boolean is meant.

Boolean sounds right as there is only one error case.
I will use that.

>=20
>>>>>> +int vpci_ecam_mmio_write(pci_sbdf_t sbdf, unsigned int reg, unsigne=
d int len,
>>>>>> +                         unsigned long data)
>>>>>> +{
>>>>>> +    if ( !vpci_ecam_access_allowed(reg, len) ||
>>>>>> +         (reg + len) > PCI_CFG_SPACE_EXP_SIZE )
>>>>>> +        return 0;
>>>>>> +
>>>>>> +    vpci_write(sbdf, reg, min(4u, len), data);
>>>>>> +    if ( len =3D=3D 8 )
>>>>>> +        vpci_write(sbdf, reg + 4, 4, data >> 32);
>>>>>> +
>>>>>> +    return 1;
>>>>>> +}
>>>>>> +
>>>>>> +int vpci_ecam_mmio_read(pci_sbdf_t sbdf, unsigned int reg, unsigned=
 int len,
>>>>>> +                        unsigned long *data)
>>>>>> +{
>>>>>> +    if ( !vpci_ecam_access_allowed(reg, len) ||
>>>>>> +         (reg + len) > PCI_CFG_SPACE_EXP_SIZE )
>>>>>> +        return 0;
>>>>>> +
>>>>>> +    /*
>>>>>> +     * According to the PCIe 3.1A specification:
>>>>>> +     *  - Configuration Reads and Writes must usually be DWORD or s=
maller
>>>>>> +     *    in size.
>>>>>> +     *  - Because Root Complex implementations are not required to =
support
>>>>>> +     *    accesses to a RCRB that cross DW boundaries [...] softwar=
e
>>>>>> +     *    should take care not to cause the generation of such acce=
sses
>>>>>> +     *    when accessing a RCRB unless the Root Complex will suppor=
t the
>>>>>> +     *    access.
>>>>>> +     *  Xen however supports 8byte accesses by splitting them into =
two
>>>>>> +     *  4byte accesses.
>>>>>> +     */
>>>>>> +    *data =3D vpci_read(sbdf, reg, min(4u, len));
>>>>>> +    if ( len =3D=3D 8 )
>>>>>> +        *data |=3D (uint64_t)vpci_read(sbdf, reg + 4, 4) << 32;
>>>>>> +
>>>>>> +    return 1;
>>>>>> +}
>>>>>=20
>>>>> Why do these two functions return int/0/1 instead of
>>>>> bool/false/true (assuming, as per above, that them returning non-
>>>>> void is warranted at all)?
>>>>=20
>>>> This is what the mmio handlers should return to say that an access
>>>> was ok or not so the function stick to this standard.
>>>=20
>>> Sticking to this would be okay if the functions here needed their
>>> address taken, such that they can be installed as hooks for a
>>> more general framework to invoke. The functions, however, only get
>>> called directly. Hence there's no reason to mirror what is in need
>>> of cleaning up elsewhere. I'm sure you're aware there we're in the
>>> (slow going) process of improving which types get used where.
>>> While the functions you refer to may not have undergone such
>>> cleanup yet, we generally expect new code to conform to the new
>>> model.
>>=20
>> I am ok to rename those to vpci_ecam_{read/write}.
>> Is it what you want ?
>=20
> Yes, that's what I've been asking for, and I just saw Roger requesting
> the same. (I'm a little puzzled about the context though, as you reply
> looks disconnected here.)

Oups sorry.
Anyway if we agree on naming scheme and bool return type I think all
your comments here are covered ?

Cheers
Bertrand

>=20
> Jan
>=20



From xen-devel-bounces@lists.xenproject.org Fri Oct 15 08:20:48 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 08:20:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.209898.366485 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbISN-0004YI-Uy; Fri, 15 Oct 2021 08:20:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 209898.366485; Fri, 15 Oct 2021 08:20:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbISN-0004YB-R5; Fri, 15 Oct 2021 08:20:47 +0000
Received: by outflank-mailman (input) for mailman id 209898;
 Fri, 15 Oct 2021 08:20:47 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=vjd/=PD=arm.com=Hongda.Deng@srs-us1.protection.inumbo.net>)
 id 1mbISN-0004XP-2C
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 08:20:47 +0000
Received: from EUR03-AM5-obe.outbound.protection.outlook.com (unknown
 [40.107.3.81]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id cab3ae7c-2d90-11ec-8227-12813bfff9fa;
 Fri, 15 Oct 2021 08:20:44 +0000 (UTC)
Received: from DB6PR0601CA0032.eurprd06.prod.outlook.com (2603:10a6:4:17::18)
 by AS8PR08MB6597.eurprd08.prod.outlook.com (2603:10a6:20b:334::5)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.21; Fri, 15 Oct
 2021 08:20:43 +0000
Received: from DB5EUR03FT014.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:4:17:cafe::b4) by DB6PR0601CA0032.outlook.office365.com
 (2603:10a6:4:17::18) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.14 via Frontend
 Transport; Fri, 15 Oct 2021 08:20:43 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT014.mail.protection.outlook.com (10.152.20.102) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.15 via Frontend Transport; Fri, 15 Oct 2021 08:20:42 +0000
Received: ("Tessian outbound e27daf245730:v103");
 Fri, 15 Oct 2021 08:20:42 +0000
Received: from 60b6f38b5e3c.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 9885F19A-6396-4C04-828F-6DF978BDDA94.1; 
 Fri, 15 Oct 2021 08:20:37 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 60b6f38b5e3c.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 15 Oct 2021 08:20:37 +0000
Received: from VE1PR08MB5677.eurprd08.prod.outlook.com (2603:10a6:800:1ab::17)
 by VI1PR08MB4398.eurprd08.prod.outlook.com (2603:10a6:803:102::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.17; Fri, 15 Oct
 2021 08:20:34 +0000
Received: from VE1PR08MB5677.eurprd08.prod.outlook.com
 ([fe80::d810:52a3:dce3:4d06]) by VE1PR08MB5677.eurprd08.prod.outlook.com
 ([fe80::d810:52a3:dce3:4d06%7]) with mapi id 15.20.4608.017; Fri, 15 Oct 2021
 08:20:34 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: cab3ae7c-2d90-11ec-8227-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=S/BVQsT8KdmOUjh8TkT+55alI9IC+eKHzeU1pRKWYok=;
 b=dxdhtUn74kNep0mVBylfT7lVrh/nF7fUjDAITj4jRPOY0Ljv2271X5PXZ8PvoYLQFEPX+ZHhF1nyfhWO4UyJaf1rEeP8fZk8REIrVTPRv/gWRUQ/qLk+BniPV4O8UzYKrZ5xoHz3TORCjnUg9XJjQyOyABI/5mtUXf2+m7FMo6E=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=MVWrtnN7wZlfQbPmSvbdmSUQtC6ZXwqUyYanJMMhp1n8hHZOYebegNdrGfU0l36JSFOV6jM45As7QWFdVLSIqVh+UcwEYe+O/DUBU/17699GWylsiMvVqNHzYFuziAehiU10R3T2LNcvWGWE0ZmTOjr8azJyJWE2m6FT4iKDvBME3emvbxpwlRiESTEhYrOtpDAAqBo7Z/RktHzUqYi1FOwmULB1lWLEoXwx8CWV9md4W982ng/bYd2OAgHlqM8j8BJo4E3w1PPE4JqsI5mWTGGZLz1CY2JqjFQ6JdXdodQZDkGCdEWzLBAbegUCxtcRGSylMgA8C/0NbL9KHshr4A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=S/BVQsT8KdmOUjh8TkT+55alI9IC+eKHzeU1pRKWYok=;
 b=GoqWgIY9DimazY3+06odj9gNBZRof0rlT9VMXakXNl0mc9lwjYH/YABPz9o3jU8ak5Y48YBXYgWDrHD1HIoczR3fQmKMDX5MPFaeKKWq5T39z7KZgGdhl+I4E7Kg80SOidLB6mKj23RXyJvK/KF2GVuC8iQBgSIKJakk7HzNCdPc3D223re8jCzPULsMNiX8tfdodkBDj3k6jbelEIvVkiDlHfwraGwkrinuh2S3tLpvMHkD9RAFSpBMNtzPpfQ7d+EHTR8VxbemJVxzjbwmzOcfeAhKri8qHY2mjecOWxsF1Ah1IUYJAxQYRs6X56VDIfujx45177CSaNMFO+pnbg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=S/BVQsT8KdmOUjh8TkT+55alI9IC+eKHzeU1pRKWYok=;
 b=dxdhtUn74kNep0mVBylfT7lVrh/nF7fUjDAITj4jRPOY0Ljv2271X5PXZ8PvoYLQFEPX+ZHhF1nyfhWO4UyJaf1rEeP8fZk8REIrVTPRv/gWRUQ/qLk+BniPV4O8UzYKrZ5xoHz3TORCjnUg9XJjQyOyABI/5mtUXf2+m7FMo6E=
From: Hongda Deng <Hongda.Deng@arm.com>
To: Julien Grall <julien@xen.org>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, "sstabellini@kernel.org"
	<sstabellini@kernel.org>
CC: Bertrand Marquis <Bertrand.Marquis@arm.com>, Wei Chen <Wei.Chen@arm.com>
Subject: RE: [PATCH v2] xen/arm: vgic to ignore GICD ICPENRn registers access
Thread-Topic: [PATCH v2] xen/arm: vgic to ignore GICD ICPENRn registers access
Thread-Index: AQHXvzHlijaP4Y1NK0CFHMPF7AWOSqvP6giAgAIRRICAAEJogIABejRg
Date: Fri, 15 Oct 2021 08:20:34 +0000
Message-ID:
 <VE1PR08MB5677AFFDC961517E0C85A9E4E6B99@VE1PR08MB5677.eurprd08.prod.outlook.com>
References: <20211012062449.30966-1-Hongda.Deng@arm.com>
 <2006f09d-25c3-af7a-cbea-dbc811fc8748@xen.org>
 <VE1PR08MB5677670DF19601441701380FE6B89@VE1PR08MB5677.eurprd08.prod.outlook.com>
 <e56e0ee0-2675-a746-3880-b6af48c7054b@xen.org>
In-Reply-To: <e56e0ee0-2675-a746-3880-b6af48c7054b@xen.org>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: 95590394284A6D4886471F5E874BB793.0
x-checkrecipientchecked: true
Authentication-Results-Original: xen.org; dkim=none (message not signed)
 header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: c81a047e-af62-495d-ce4e-08d98fb4ae23
x-ms-traffictypediagnostic: VI1PR08MB4398:|AS8PR08MB6597:
x-ms-exchange-transport-forked: True
X-Microsoft-Antispam-PRVS:
	<AS8PR08MB6597F68589CCDDEE9C910C0FE6B99@AS8PR08MB6597.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:5797;OLM:5797;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 M31pMRCkYvCMyX77P9nb2MAhdxDzVzwGhFkJC6vaSn5+LwAinCGVFuvrsgEZRMlaKlU+GDXgoS6yqCjeKyt8L6TFBqsrTA2AIcjQWN+DPm+uJHdYO2ohxqHoT8YBwMlLkd8J6QCCspfeW8be77GtzVgPIn5imD/eQoM40gsuKSXYOlvLQdrSJltP59VVPLjENqBHbxJ03p54HIiwPBAeGZsW5JtzI2+5Rt+GR8xUpUTOrCMwH6NLV/LMEnGCVE70vL2+Gthl6OmsecDsqzTGhYumZroSQLMhSynvS1JNalRY4x5WSlyfTOkG63MJJzuNwSwblnzPJ0KlLqtNggQzJOJsc1g+HKamOmv8+WpwdOTWYsG/5nancc0cYaXbvwhRUbs45AZ7dtk2pYFM3v/vPDLfLEk8NVOKY9CIdgk1JAubZI8XLkDCdaJLjkM94zpmrXxIi3ln5itbA8EcUrP2nOS9+UczL9EUh1XxvCnCKOE1lDUk4yMH++XCPNTgRO9z8KqJ1ovwogzf/Avjga58/zMvJDpvPgpb5iHK6uI3vyeUWUHHblbKLNnXI0XQoHwKxMevVPL42nG5+qxX9tfrG9u5ZGFpfm5f9Xcn9CbTJomSU6bpo6ArpsoACJjynGYl5rj6ES4+kLu/h+C/5YYO3nx7VCNo8LFMVJZGPN8DsDxm5Q067jYVF+vSuRDQSTs7UIoAf9yC9w7/hVjo7Z3Bb1WzRROXh1EekejyTPnCa3fXObnSTL4/W4Z4ZutemBEtKlQgtuu2H9YmmCwmkfp9cxtypVp2rOsHKdhsn7Xurcs=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR08MB5677.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(186003)(30864003)(76116006)(54906003)(8936002)(2906002)(52536014)(26005)(66946007)(9686003)(508600001)(38100700002)(71200400001)(83380400001)(966005)(316002)(55016002)(5660300002)(110136005)(66476007)(8676002)(4326008)(66446008)(64756008)(38070700005)(122000001)(86362001)(7696005)(6506007)(53546011)(33656002)(66556008);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB4398
Original-Authentication-Results: xen.org; dkim=none (message not signed)
 header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT014.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	37518c2b-a55e-4105-49d9-08d98fb4a918
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Exo9k8LQg3xzlSc+2kAy1SW1bLne9q7m0RddDaD5jcjgEWNXEjLLm+ovs1j/X1+Sr79mXn89w35vt8uycFR+D8rWcf94DF9izlGjz+x+lkmzBAOIGzIryo36AwirQ3a9EQhultXMML5rsXLsBgp2n93PLmQ5j1wOfjVndggPNQ6t3zGY5OB0veRO+UMl7y4AXK0Y7JqTTNpY021d3L5HBTOSD/HhYG3FsEdymZk+kih3h7YJHZOLucV3lqQ+VL1ecKNHTQA4CwrmXRWaXCMrNB3mjS74/ttnMUmXLyyeV/FdzI6OP2njQR9lhF2WZFuxeXcFvWYhGkU2wQIduCYgEScMLf8Z0Bs4O0uc8QlqtH1NuZcAWgX4u6MM4mXD/p1nCDlRVZzpfZB1eUsnEmgV4CZ0pEXnfm4nB/r8gMmKy2CVOImng1zLXkP/+we5opWj+sJrqseszD/EeK/S3BrbGzzOVuIORE0i3RI0ZGJqQae7n4pYPDs2iXg7ZN/I9bDHa3L5WeAAN2bJefPq8m+t2KM9QupzZA08SkQyAYIPhDfilaaE/1chXhJ9coT6hl4dZ6fY3xtaC8i/jG7k8o32CHb7A9JRnPAMzYPeyeMC8rXWGzk63XKvy0bO8XE+TKCT0mWXMSdqJja+oiKTi/5gIbeWVb+/JvOvyf989Bl8bgatkmKMMk62JdORAUJjOreWkahnrx3T3CDlyfiWU/bvceBmqWTzYLiW+t2UaftPxmqcJGPCZo6ugo/4sxNFqbhLoj5p/E6ytsLlvJv4O8Hs7579SS56qw2+DoWsq7vuJJA=
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(26005)(81166007)(8936002)(5660300002)(508600001)(9686003)(53546011)(8676002)(7696005)(82310400003)(6506007)(316002)(54906003)(2906002)(186003)(36860700001)(55016002)(52536014)(33656002)(70586007)(4326008)(336012)(966005)(83380400001)(70206006)(47076005)(356005)(86362001)(30864003)(110136005);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2021 08:20:42.8013
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: c81a047e-af62-495d-ce4e-08d98fb4ae23
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT014.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6597

SGksDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogSnVsaWVuIEdyYWxs
IDxqdWxpZW5AeGVuLm9yZz4NCj4gU2VudDogMjAyMeW5tDEw5pyIMTTml6UgMTc6MzANCj4gVG86
IEhvbmdkYSBEZW5nIDxIb25nZGEuRGVuZ0Bhcm0uY29tPjsgeGVuLQ0KPiBkZXZlbEBsaXN0cy54
ZW5wcm9qZWN0Lm9yZzsgc3N0YWJlbGxpbmlAa2VybmVsLm9yZw0KPiBDYzogQmVydHJhbmQgTWFy
cXVpcyA8QmVydHJhbmQuTWFycXVpc0Bhcm0uY29tPjsgV2VpIENoZW4NCj4gPFdlaS5DaGVuQGFy
bS5jb20+DQo+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggdjJdIHhlbi9hcm06IHZnaWMgdG8gaWdub3Jl
IEdJQ0QgSUNQRU5SbiByZWdpc3RlcnMNCj4gYWNjZXNzDQo+IA0KPiBPbiAxNC8xMC8yMDIxIDA3
OjU1LCBIb25nZGEgRGVuZyB3cm90ZToNCj4gPiBIaSwNCj4gSGksDQo+IA0KPiA+PiAtLS0tLU9y
aWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiA+PiBGcm9tOiBKdWxpZW4gR3JhbGwgPGp1bGllbkB4ZW4u
b3JnPg0KPiA+PiBTZW50OiAyMDIx5bm0MTDmnIgxM+aXpSA1OjU4DQo+ID4+IFRvOiBIb25nZGEg
RGVuZyA8SG9uZ2RhLkRlbmdAYXJtLmNvbT47IHhlbi0NCj4gZGV2ZWxAbGlzdHMueGVucHJvamVj
dC5vcmc7DQo+ID4+IHNzdGFiZWxsaW5pQGtlcm5lbC5vcmcNCj4gPj4gQ2M6IEJlcnRyYW5kIE1h
cnF1aXMgPEJlcnRyYW5kLk1hcnF1aXNAYXJtLmNvbT47IFdlaSBDaGVuDQo+ID4+IDxXZWkuQ2hl
bkBhcm0uY29tPg0KPiA+PiBTdWJqZWN0OiBSZTogW1BBVENIIHYyXSB4ZW4vYXJtOiB2Z2ljIHRv
IGlnbm9yZSBHSUNEIElDUEVOUm4gcmVnaXN0ZXJzDQo+IGFjY2Vzcw0KPiA+Pg0KPiA+PiBIaSwN
Cj4gPj4NCj4gPj4gT24gMTIvMTAvMjAyMSAwNzoyNCwgSG9uZ2RhIERlbmcgd3JvdGU6DQo+ID4+
PiBDdXJyZW50bHksIFhlbiB3aWxsIHJldHVybiBJTyB1bmhhbmRsZWQgd2hlbiBndWVzdHMgYWNj
ZXNzIEdJQ0QNCj4gSUNQRU5Sbg0KPiA+Pj4gcmVnaXN0ZXJzLiBUaGlzIHdpbGwgcmFpc2UgYSBk
YXRhIGFib3J0IGluc2lkZSBndWVzdC4gRm9yIExpbnV4IEd1ZXN0LA0KPiA+Pj4gdGhlc2Ugdmly
dHVhbCByZWdpc3RlcnMgd2lsbCBub3QgYmUgYWNjZXNzZWQuIEJ1dCBmb3IgWmVwaHlyLCBpbiBp
dHMNCj4gPj4+IEdJQyBpbml0aWFsaXphdGlvbiBjb2RlLCB0aGVzZSB2aXJ0dWFsIHJlZ2lzdGVy
cyB3aWxsIGJlIGFjY2Vzc2VkLiBBbmQNCj4gPj4+IHplcGh5ciBndWVzdCB3aWxsIGdldCBhbiBJ
TyBkYXRhIGFib3J0IGluIGluaXRpbGl6YXRpb24gc3RhZ2UgYW5kIGVudGVyDQo+ID4+PiBmYXRh
bCBlcnJvci4gRW11bGF0aW5nIElDUEVORFIgaXMgbm90IGVhc3kgd2l0aCB0aGUgZXhpc3Rpbmcg
dkdJQywgc28NCj4gPj4+IHdlIGN1cnJlbnRseSBpZ25vcmUgdGhlc2UgdmlydHVhbCByZWdpc3Rl
cnMgYWNjZXNzIGFuZCBwcmludCBhIG1lc3NhZ2UNCj4gPj4+IGFib3V0IHdoZXRoZXIgdGhleSBh
cmUgYWxyZWFkeSBwZW5kaW5nIGluc3RlYWQgb2YgcmV0dXJuaW5nIHVuaGFuZGxlZC4NCj4gPj4+
IE1vcmUgZGV0YWlscyBjYW4gYmUgZm91bmQgYXQgWzFdLg0KPiA+Pg0KPiA+PiBUaGUgbGluayB5
b3UgcHJvdmlkZSBvbmx5IHN0YXRlcyB0aGF0IEkgYW0gaGFwcHkgd2l0aCB0aGUgd2FybmluZy4g
VGhpcw0KPiA+PiBkb2Vzbid0IHNlZW0gcmVsZXZhbnQgZm9yIGEgZnV0dXJlIHJlYWRlci4gRGlk
IHlvdSBpbnRlbmQgdG8gcG9pbnQgdG8NCj4gPj4gc29tZXRoaW5nIGRpZmZlcmVudD8NCj4gPj4N
Cj4gPg0KPiA+IFllcywgSSB3b3VsZCBhdHRhY2ggdGhpcyBsaW5rIFsxXSB0aGVuLCB3aGljaCBl
eHBsYWlucyBob3cgemVwaHlyIGFjY2Vzc2VzDQo+ID4gSUNQRU5EUiBhdCBpdHMgaW5pdGlhbGl6
YXRpb24uICggVGhvdWdoIEkgc3RpbGwgZG9uJ3QgdW5kZXJzdGFuZCB3aHkgemVwaHlyDQo+ID4g
d291bGQgY2xlYXIgdGhpcyByZWdpc3RlciBhdCBpbml0aWFsaXphdGlvbiB3aGlsZSBsaW51eCB3
b3VsZG4ndCApDQo+IA0KPiBJIGFtIGNvbmZ1c2VkIGFzIHdlbGwuIEZyb20gbXkgdW5kZXJzdGFu
ZGluZywgY2xlYXJpbmcgSUNQRU5EUiBhdA0KPiBpbml0aWFsaXphdGlvbiBpcyBwb2ludGxlc3Mg
Zm9yIGxldmVsIGludGVycnVwdHMgaWYgeW91IGRpZG4ndCBxdWllc2NlDQo+IHRoZSBkZXZpY2Ug
YmVmb3JlaGFuZC4NCj4gDQo+IFRoZSBnaXQgaGlzdG9yeSBkb2Vzbid0IHNlZW0gdG8gZ2l2ZSBt
dWNoIGRldGFpbHMgb24gdGhlIHJlYXNvbi4gQnV0DQo+IGxvb2tpbmcgYXQgdGhlIGNvZGUsIEkg
YW0gd29uZGVyaW5nIGlmIHRoZSBpbnRlbnRpb24gd2FzIHRvIGNsZWFyIHRoZQ0KPiBhY3RpdmUg
Yml0IHJhdGhlciB0aGFuIHRoZSBwZW5kaW5nIGJpdC4NCj4gDQoNCkkgd2lsbCB0cnkgdG8gZmlu
ZCBzb21lb25lIHdvcmtzIG9uIHplcGh5ciB0byBzZWUgaXQgaWYgaGUvc2hlIGtub3dzIHRoYXQu
DQoNCj4gPg0KPiA+Pj4NCj4gPj4+IFsxXSBodHRwczovL2xpc3RzLnhlbnByb2plY3Qub3JnL2Fy
Y2hpdmVzL2h0bWwveGVuLWRldmVsLzIwMjEtMDkvDQo+ID4+PiBtc2cwMDc0NC5odG1sDQo+ID4+
Pg0KPiA+Pj4gU2lnbmVkLW9mZi1ieTogSG9uZ2RhIERlbmcgPGhvbmdkYS5kZW5nQGFybS5jb20+
DQo+ID4+PiAtLS0NCj4gPj4+ICAgIHhlbi9hcmNoL2FybS92Z2ljLXYyLmMgfCAyNiArKysrKysr
KysrKysrKysrKysrKysrKysrLQ0KPiA+Pj4gICAgeGVuL2FyY2gvYXJtL3ZnaWMtdjMuYyB8IDQw
ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKystLQ0KPiAtLS0tLS0tDQo+ID4+PiAgICAy
IGZpbGVzIGNoYW5nZWQsIDU2IGluc2VydGlvbnMoKyksIDEwIGRlbGV0aW9ucygtKQ0KPiA+Pj4N
Cj4gPj4+IGRpZmYgLS1naXQgYS94ZW4vYXJjaC9hcm0vdmdpYy12Mi5jIGIveGVuL2FyY2gvYXJt
L3ZnaWMtdjIuYw0KPiA+Pj4gaW5kZXggYjJkYTg4NmFkYy4uZDdmZmFlZWI2NSAxMDA2NDQNCj4g
Pj4+IC0tLSBhL3hlbi9hcmNoL2FybS92Z2ljLXYyLmMNCj4gPj4+ICsrKyBiL3hlbi9hcmNoL2Fy
bS92Z2ljLXYyLmMNCj4gPj4+IEBAIC00ODAsMTEgKzQ4MCwzNSBAQCBzdGF0aWMgaW50IHZnaWNf
djJfZGlzdHJfbW1pb193cml0ZShzdHJ1Y3QNCj4gdmNwdSAqdiwNCj4gPj4gbW1pb19pbmZvX3Qg
KmluZm8sDQo+ID4+PiAgICAgICAgICAgIHJldHVybiAxOw0KPiA+Pj4NCj4gPj4+ICAgICAgICBj
YXNlIFZSQU5HRTMyKEdJQ0RfSUNQRU5EUiwgR0lDRF9JQ1BFTkRSTik6DQo+ID4+PiArICAgIHsN
Cj4gPj4+ICsgICAgICAgIHN0cnVjdCBwZW5kaW5nX2lycSAqaXRlcjsNCj4gPj4+ICsgICAgICAg
IHVuc2lnbmVkIGludCBpcnFfc3RhcnQ7DQo+ID4+PiArICAgICAgICB1bnNpZ25lZCBpbnQgaXJx
X2VuZDsNCj4gPj4+ICsgICAgICAgIHVpbnQzMl90IGlycV9wZW5kaW5nID0gMDsNCj4gPj4+ICsN
Cj4gPj4+ICAgICAgICAgICAgaWYgKCBkYWJ0LnNpemUgIT0gREFCVF9XT1JEICkgZ290byBiYWRf
d2lkdGg7DQo+ID4+PiAgICAgICAgICAgIHByaW50ayhYRU5MT0dfR19FUlINCj4gPj4+ICAgICAg
ICAgICAgICAgICAgICIlcHY6IHZHSUNEOiB1bmhhbmRsZWQgd29yZCB3cml0ZSAlIyJQUklyZWdp
c3RlciIgdG8NCj4gPj4gSUNQRU5EUiVkXG4iLA0KPiA+Pj4gICAgICAgICAgICAgICAgICAgdiwg
ciwgZ2ljZF9yZWcgLSBHSUNEX0lDUEVORFIpOw0KPiA+Pg0KPiA+PiBBcyBJIHdyb3RlIGluIHYx
LCB3ZSBzaG91bGQgYXZvaWQgdG8gcHJpbnQgYSBtZXNzYWdlIHdoZW4gd2Uga25vdyB0aGVyZQ0K
PiA+PiBpcyBubyBwZW5kaW5nIGludGVycnVwdHMuDQo+ID4+DQo+ID4NCj4gPiBUaGVzZSBhcmUg
bm90IHRoZSBtb2RpZmljYXRpb25zIG1hZGUgaW4gdGhpcyBwYXRjaCwgYW5kIHNhbWUgY29kZXMg
YWxzbw0KPiBleGlzdA0KPiA+IGZvciBJQ0FDVElWRVIuIEkgZGlkbid0IGRlbGV0ZSB0aGVtIGZv
ciB0aGF0IEkgdGhpbmsgdGhleSBhcmUgdXNlZCB0byBnaXZlDQo+IHNvbWUNCj4gPiB1c2VmdWwg
YW5kIGNvaGVyZW50IG1lc3NhZ2VzIHRvIHVzZXIgZm9yIHJlZmVyZW5jZS4gU2hvdWxkIHdlIGRl
bGV0ZSBpdA0KPiBmb3IgYm90aA0KPiA+IG9yIG9ubHkgZm9yIElDUEVORFI/DQo+IA0KPiBMb29r
aW5nIGF0IHRoZSBpbXBsZW1lbnRhdGlvbiBJQ0FDVElWRVIsIHdlIHNpbXBseSBpZ25vcmUgdGhl
IHdyaXRlIHNvDQo+IGl0IG1ha2VzIHNlbnNlIHRvIHByaW50IGEgbWVzc2FnZSBldmVyeXRpbWUu
DQo+IA0KPiBUaGlzIGlzIHF1aXRlIGRpZmZlcmVudCB0byB0aGUgaW1wbGVtZW50YXRpb24gb2Yg
SUNQRU5EUiBhcyB3ZSB3aWxsDQo+IHBhcnRpYWxseSBlbXVsYXRlIGl0LiBXZSB0ZWNobmljYWxs
eSBlbXVsYXRlZCB0aGUgcmVnaXN0ZXIgY29ycmVjdGx5DQo+IHdoZW4gdGhlcmUgaXMgbm8gcGVu
ZGluZyBpbnRlcnJ1cHRzLCBzbyBJIHRoaW5rIGl0IGlzIHdyb25nIHRvIHByaW50IGENCj4gbWVz
c2FnZSBzdGF0ZSB0aGlzIHdhc24ndCBoYW5kbGVkIHByb3Blcmx5Lg0KPiANCj4gVGhlcmVmb3Jl
LCBJIHdvdWxkIGxpa2UgdGhpcyBtZXNzYWdlIHRvIG9ubHkgYXBwZWFyIHdoZW4gd2Uga25vdyB0
aGUNCj4gd3JpdGUgd2Fzbid0IGhhbmRsZWQgcHJvcGVybHkuDQo+IA0KDQpBY2ssIEkgd2lsbCBm
aXggaXQgaW4gbmV4dCBwYXRjaC4NCg0KPiA+Pj4gLSAgICAgICAgcmV0dXJuIDA7DQo+ID4+PiAr
DQo+ID4+PiArICAgICAgICBpcnFfc3RhcnQgPSAoZ2ljZF9yZWcgLSBHSUNEX0lDUEVORFIpICog
MzI7DQo+ID4+PiArICAgICAgICBpcnFfZW5kID0gaXJxX3N0YXJ0ICsgMzE7DQo+ID4+PiArICAg
ICAgICAvKiBnbyB0aHJvdWdoIGluZmxpZ2h0X2lycXMgYW5kIHByaW50IHNwZWNpZmllZCBwZW5k
aW5nIGlycXMgKi8NCj4gPj4+ICsgICAgICAgIGxpc3RfZm9yX2VhY2hfZW50cnkoaXRlciwgJnYt
PmFyY2gudmdpYy5pbmZsaWdodF9pcnFzLCBpbmZsaWdodCkNCj4gPj4gWW91IG5lZWQgdG8gaG9s
ZCB2LT5hcmNoLnZnaWMubG9jayAod2l0aCBpbnRlcnJ1cHQgZGlzYWJsZWQpIHRvIGdvDQo+ID4+
IHRocm91Z2ggdGhlIGxpc3Qgb2YgaW5mbGlnaHQgaXJxcy4gT3RoZXJ3aXNlLCB0aGUgbGlzdCBt
YXkgYmUgbW9kaWZpZWQNCj4gPj4gd2hpbGUgeW91IGFyZSB3YWxraW5nIGl0Lg0KPiA+Pg0KPiA+
DQo+ID4gQWNrLg0KPiA+DQo+ID4+IEhvd2V2ZXIsIEkgYW0gYSBsaXR0bGUgYml0IGNvbmNlcm5l
ZCB3aXRoIHRoaXMgYXBwcm9hY2hlZCAoSSBub3RpY2VkDQo+ID4+IFN0ZWZhbm8gc3VnZ2VzdGVk
KS4gVGhlIGxpc3QgbWF5IGluIHRoZW9yeSBjb250YWlucyBhIGZldyBodW5kcmVkcw0KPiA+PiBp
bnRlcnJ1cHRzIChhIG1hbGljaW91cyBPUyBNYXkgZGVjaWRlIHRvIG5ldmVyIHJlYWQgSUFSKS4g
U28gd2UgYXJlDQo+ID4+IHBvdGVudGlhbGx5IGRvaW5nIG1vcmUgd29yayB0aGFuIG5lY2Vzc2Fy
eSAod2UgbmVlZCB0byB0aGluayBhYm91dCB0aGUNCj4gPj4gd29yc2UgY2FzZSBzY2VuYXJpbyku
DQo+ID4+DQo+ID4+IEluc3RlYWQsIEkgdGhpbmsgaXQgd291bGQgYmUgYmV0dGVyIHRvIGdvIHRo
cm91Z2ggdGhlIDMyIGludGVycnVwdHMgYW5kDQo+ID4+IGZvciBlYWNoIG9mIHRoZW06DQo+ID4+
ICAgICAxKSBmaW5kIHRoZSBwZW5kaW5nX2lycSgpIHVzaW5nIGlycV90b19wZW5kaW5nKCkNCj4g
Pj4gICAgIDIpIGNoZWNrIGlmIHRoZSBJUlEgaW4gdGhlIGluZmxpZ2h0IGxpc3Qgd2l0aCBsaXN0
X2VtcHR5KCZwLT5pbmZsaWdodCkNCj4gPj4NCj4gPj4gSW4gYWRkaXRpb24gdG8gdGhhdCwgeW91
IHdhbnQgdG8gY2hlY2sgdGhhdCB0aGUgcmFuayBleGlzdHMgc28gd2UgZG9uJ3QNCj4gPj4gZG8g
YW55IGV4dHJhIHdvcmsgaWYgdGhlIGd1ZXN0IGlzIHRyeWluZyB0byBjbGVhciBhbiBpbnRlcnJ1
cHRzIGFib3ZlDQo+ID4+IHRoZSBudW1iZXIgb2YgaW50ZXJydXB0cyB3ZSBzdXBwb3J0Lg0KPiA+
Pg0KPiA+DQo+ID4gQWdyZWVkLCBhbmQgdGhhdCdzIHF1aXRlIGhlbHBmdWwuDQo+IA0KPiBJIGZv
cmdvdCB0byBtZW50aW9uIHRoYXQgeW91IG1heSBuZWVkIHRvIGJlIGNhcmVmdWwgd2l0aCB0aGUg
bG9ja2luZy4gSWYNCj4gSSBhbSBub3QgbWlzdGFrZW4sICJpbmZsaWdodCIgaXMgcHJvdGVjdGVk
IHdpdGggdGhlIGFyY2gudmdpYy5sb2NrIG9mDQo+IHZnaWNfZ2V0X3RhcmdldF92Y3B1KCk7DQo+
IA0KDQpZZWFoLCBJIG5vdGljZWQgdGhhdC4gVGhhbmtzIH4NCg0KPiA+Pj4gKyAgICAgICAgew0K
PiA+Pj4gKyAgICAgICAgICAgIGlmICggaXRlci0+aXJxIDwgaXJxX3N0YXJ0IHx8IGlycV9lbmQg
PCBpdGVyLT5pcnEgKQ0KPiA+Pj4gKyAgICAgICAgICAgICAgICBjb250aW51ZTsNCj4gPj4+ICsN
Cj4gPj4+ICsgICAgICAgICAgICBpZiAoIHRlc3RfYml0KEdJQ19JUlFfR1VFU1RfUVVFVUVELCAm
aXRlci0+c3RhdHVzKSApDQo+ID4+PiArICAgICAgICAgICAgICAgIGlycV9wZW5kaW5nID0gaXJx
X3BlbmRpbmcgfCAoMSA8PCAoaXRlci0+aXJxIC0gaXJxX3N0YXJ0KSk7DQo+IA0KPiBMb29raW5n
IGF0IHRoaXMgY29kZSBhZ2Fpbi4gWW91IHdhbnQgdG8gY2hlY2sgd2hldGhlciB0aGUgZ3Vlc3QN
Cj4gcmVxdWVzdGVkIHRvIGNsZWFyIHRoZSBpbnRlcnJ1cHQuIE90aGVyd2lzZSwgd2UgbWF5IGdl
dCBzcHVyaW91cyB3YXJuaW5nLg0KPiANCg0KQWNrLg0KDQo+ID4+PiArICAgICAgICB9DQo+ID4+
PiArDQo+ID4+PiArICAgICAgICBpZiAoIGlycV9wZW5kaW5nICE9IDAgKQ0KPiA+Pj4gKyAgICAg
ICAgICAgIHByaW50ayhYRU5MT0dfR19FUlINCj4gPj4+ICsgICAgICAgICAgICAgICAgICAgIiVw
djogdkdJQ0Q6IElDUEVORFIlZD0weCUwOHhcbiIsDQo+ID4+PiArICAgICAgICAgICAgICAgICAg
IHYsIGdpY2RfcmVnIC0gR0lDRF9JQ1BFTkRSLCBpcnFfcGVuZGluZyk7DQo+ID4+DQo+ID4+IFRo
aXMgbWVzc2FnZSBpcyBhIGJpdCBjb25mdXNpbmcuIEkgdGhpbmsgaXQgd291bGQgYmUgd29ydGgg
dG8gcHJpbnQgYQ0KPiA+PiBtZXNzYWdlIGZvciBldmVyeSBpbnRlcnJ1cHQgbm90IGNsZWFyZWQu
IE1heWJlIHNvbWV0aGluZyBsaWtlOg0KPiA+Pg0KPiA+PiAiJXB2IHRyeWluZyB0byBjbGVhciBw
ZW5kaW5nIGludGVycnVwdCAldS4iDQo+ID4+DQo+ID4NCj4gPiBJIHdhcyB0aGlua2luZyB0aGF0
IHRoZXJlIG1heSBiZSB0b28gbWFueSBpbnRlcnJ1cHRzIHRoZXJlLCB0byBwcmludCBlYWNoDQo+
IHdpdGgNCj4gPiBvbmUgbWVzc2FnZSBsaW5lIHdvdWxkIGJlIHRvbyBzdXBlcmZsdW91cy4NCj4g
PiBCdXQgdGhhdCB3b3JzdCBjYXNlIHNjZW5hcmlvIHNob3VsZCBub3QgYmUgdXN1YWwsIGFuZCBw
cmludCBhIG1lc3NhZ2UgZm9yDQo+IGVhY2gNCj4gPiBpbnRlcnJ1cHQgd291bGQgYmUgbXVjaCBj
bGVhcmVyLg0KPiANCj4gSW4gdGhlIHdvcnN0IGNhc2Ugc2NlbmFyaW8sIHdlIHdvdWxkIHByaW50
IDMyIG1lc3NhZ2VzLiBXZSBjb3VsZA0KPiBwb3NzaWJseSBvcHRpbWl6ZSB0byBwcmludCBhbGwg
dGhlIGludGVycnVwdHMgb24gb25lIGxpbmUsIGJ1dCBJIGRvbid0DQo+IHRoaW5rIGl0IGlzIHdv
cnRoIGl0LiBJbiBtb3N0IG9mIHRoZSBjYXNlcywgeW91IHdpbGwgaGF2ZSBhdCBtb3N0IGENCj4g
Y291cGxlIG9mIGludGVycnVwdHMgcGVuZGluZy4gSWYgeW91IGhhdmUgbW9yZSwgdGhlIFhFTkxP
R19HX0VSUg0KPiBtZXNzYWdlcyBhcmUgcmF0ZWxpbWl0ZWQgc28gdGhlcmUgaXMgbm8gcmlzayB0
byBmbG9vZCB0aGUgY29uc29sZS4NCj4gDQoNCkFjay4NCg0KPiA+Pj4gKyAgICAgICAgZ290byB3
cml0ZV9pZ25vcmVfMzI7DQo+ID4+PiArICAgIH0NCj4gPj4+DQo+ID4+PiAgICAgICAgY2FzZSBW
UkFOR0UzMihHSUNEX0lTQUNUSVZFUiwgR0lDRF9JU0FDVElWRVJOKToNCj4gPj4+ICAgICAgICAg
ICAgaWYgKCBkYWJ0LnNpemUgIT0gREFCVF9XT1JEICkgZ290byBiYWRfd2lkdGg7DQo+ID4+PiBk
aWZmIC0tZ2l0IGEveGVuL2FyY2gvYXJtL3ZnaWMtdjMuYyBiL3hlbi9hcmNoL2FybS92Z2ljLXYz
LmMNCj4gPj4+IGluZGV4IGNiNWE3MGM0MmUuLjI0M2IyNGU0OTYgMTAwNjQ0DQo+ID4+PiAtLS0g
YS94ZW4vYXJjaC9hcm0vdmdpYy12My5jDQo+ID4+PiArKysgYi94ZW4vYXJjaC9hcm0vdmdpYy12
My5jDQo+ID4+PiBAQCAtODE2LDExICs4MTYsMzUgQEAgc3RhdGljIGludA0KPiA+PiBfX3ZnaWNf
djNfZGlzdHJfY29tbW9uX21taW9fd3JpdGUoY29uc3QgY2hhciAqbmFtZSwgc3RydWN0IHZjcHUg
KnYsDQo+ID4+PiAgICAgICAgICAgIHJldHVybiAxOw0KPiA+Pj4NCj4gPj4+ICAgICAgICBjYXNl
IFZSQU5HRTMyKEdJQ0RfSUNQRU5EUiwgR0lDRF9JQ1BFTkRSTik6DQo+ID4+PiArICAgIHsNCj4g
Pj4+ICsgICAgICAgIHN0cnVjdCBwZW5kaW5nX2lycSAqaXRlcjsNCj4gPj4+ICsgICAgICAgIHVu
c2lnbmVkIGludCBpcnFfc3RhcnQ7DQo+ID4+PiArICAgICAgICB1bnNpZ25lZCBpbnQgaXJxX2Vu
ZDsNCj4gPj4+ICsgICAgICAgIHVpbnQzMl90IGlycV9wZW5kaW5nID0gMDsNCj4gPj4+ICsNCj4g
Pj4+ICAgICAgICAgICAgaWYgKCBkYWJ0LnNpemUgIT0gREFCVF9XT1JEICkgZ290byBiYWRfd2lk
dGg7DQo+ID4+PiAgICAgICAgICAgIHByaW50ayhYRU5MT0dfR19FUlINCj4gPj4+ICAgICAgICAg
ICAgICAgICAgICIlcHY6ICVzOiB1bmhhbmRsZWQgd29yZCB3cml0ZSAlIyJQUklyZWdpc3RlciIg
dG8NCj4gSUNQRU5EUiVkXG4iLA0KPiA+Pj4gICAgICAgICAgICAgICAgICAgdiwgbmFtZSwgciwg
cmVnIC0gR0lDRF9JQ1BFTkRSKTsNCj4gPj4+IC0gICAgICAgIHJldHVybiAwOw0KPiA+Pj4gKw0K
PiA+Pj4gKyAgICAgICAgaXJxX3N0YXJ0ID0gKHJlZyAtIEdJQ0RfSUNQRU5EUikgKiAzMjsNCj4g
Pj4+ICsgICAgICAgIGlycV9lbmQgPSBpcnFfc3RhcnQgKyAzMTsNCj4gPj4+ICsgICAgICAgIC8q
IGdvIHRocm91Z2ggaW5mbGlnaHRfaXJxcyBhbmQgcHJpbnQgc3BlY2lmaWVkIHBlbmRpbmcgaXJx
cyAqLw0KPiA+Pj4gKyAgICAgICAgbGlzdF9mb3JfZWFjaF9lbnRyeShpdGVyLCAmdi0+YXJjaC52
Z2ljLmluZmxpZ2h0X2lycXMsIGluZmxpZ2h0KQ0KPiA+Pj4gKyAgICAgICAgew0KPiA+Pj4gKyAg
ICAgICAgICAgIGlmICggaXRlci0+aXJxIDwgaXJxX3N0YXJ0IHx8IGlycV9lbmQgPCBpdGVyLT5p
cnEgKQ0KPiA+Pj4gKyAgICAgICAgICAgICAgICBjb250aW51ZTsNCj4gPj4+ICsNCj4gPj4+ICsg
ICAgICAgICAgICBpZiAoIHRlc3RfYml0KEdJQ19JUlFfR1VFU1RfUVVFVUVELCAmaXRlci0+c3Rh
dHVzKSApDQo+ID4+PiArICAgICAgICAgICAgICAgIGlycV9wZW5kaW5nID0gaXJxX3BlbmRpbmcg
fCAoMSA8PCAoaXRlci0+aXJxIC0gaXJxX3N0YXJ0KSk7DQo+ID4+PiArICAgICAgICB9DQo+ID4+
PiArDQo+ID4+PiArICAgICAgICBpZiAoIGlycV9wZW5kaW5nICE9IDAgKQ0KPiA+Pj4gKyAgICAg
ICAgICAgIHByaW50ayhYRU5MT0dfR19FUlINCj4gPj4+ICsgICAgICAgICAgICAgICAgICAgIiVw
djogJXM6IElDUEVORFIlZD0weCUwOHhcbiIsDQo+ID4+PiArICAgICAgICAgICAgICAgICAgIHYs
IG5hbWUsIHJlZyAtIEdJQ0RfSUNQRU5EUiwgaXJxX3BlbmRpbmcpOw0KPiA+Pg0KPiA+PiBNeSBy
ZW1hcmtzIGFwcGx5IGZvciBHSUN2MyBhcyB3ZWxsLiBOb3RlIHRoYXQgaW4gdGhlIGNhc2Ugb2Yg
R0lDdjMgdiBtYXkNCj4gPj4gbm90IGJlIGN1cnJlbnQuDQo+ID4+DQo+ID4NCj4gPiBJIGFtIGEg
Yml0IGNvbmZ1c2VkIHdoeSB2IG1heSBub3QgYmUgY3VycmVudCBmb3IgR0lDdjM/DQo+IA0KPiBV
bmxpa2Ugb24gR0lDdjIsIHRoZSBJQ1BFTkRSMCBpcyBub3QgYmFua2VkLiBJbnN0ZWFkLCB0aGV5
IGFyZSBwYXJ0IG9mDQo+IHRoZSByZS1kaXN0cmlidXRvci4gU28gdkNQVSBBIGNvdWxkIHdyaXRl
IGludG8gdkNQVSBCIHJlLWRpc3RyaWJ1dG9yLg0KPiANCg0KT2ssIEkgdGhpbmsgdGhpcyBpcyB3
aGF0IEkgbmVlZCwgYW5kIEkgd2lsbCBmaW5kIGl0IG91dC4NCg0KPiA+IERvZXMgdGhhdCBtZWFu
DQo+ID4gdGhhdCBmb3IgU1BJIHdlIHNob3VsZCB1c2UgdmdpY19nZXRfdGFyZ2V0X3ZjcHUoKSB0
byBnZXQgaXRzIGNvcnJlY3QgdmNwdQ0KPiA+IG9uIEdJQ3YzIGFuZCBtdWx0aSBjb3Jlcz8NCj4g
DQo+IFlvdSBzaG91bGQgZG8gdGhhdCBmb3IgYm90aCBHSUN2MiBhbmQgR0lDdjMgd2hlbiBkZWFs
aW5nIHdpdGggU1BJcy4NCj4gDQoNCkFjay4NCg0KPiA+Pj4gQEAgLTk3OCwxOSArMTAwMiwxNyBA
QCBzdGF0aWMgaW50DQo+IHZnaWNfdjNfcmRpc3RyX3NnaV9tbWlvX3dyaXRlKHN0cnVjdA0KPiA+
PiB2Y3B1ICp2LCBtbWlvX2luZm9fdCAqaW5mbywNCj4gPj4+ICAgICAgICBjYXNlIFZSRUczMihH
SUNSX0lDRkdSMSk6DQo+ID4+PiAgICAgICAgY2FzZSBWUkFOR0UzMihHSUNSX0lQUklPUklUWVIw
LCBHSUNSX0lQUklPUklUWVI3KToNCj4gPj4+ICAgICAgICBjYXNlIFZSRUczMihHSUNSX0lTUEVO
RFIwKToNCj4gPj4+IC0gICAgICAgICAvKg0KPiA+Pj4gLSAgICAgICAgICAqIEFib3ZlIHJlZ2lz
dGVycyBvZmZzZXQgYXJlIGNvbW1vbiB3aXRoIEdJQ0QuDQo+ID4+PiAtICAgICAgICAgICogU28g
aGFuZGxlIGNvbW1vbiB3aXRoIEdJQ0QgaGFuZGxpbmcNCj4gPj4+IC0gICAgICAgICAgKi8NCj4g
Pj4+ICsgICAgICAgIC8qDQo+ID4+PiArICAgICAgICAqIEFib3ZlIHJlZ2lzdGVycyBvZmZzZXQg
YXJlIGNvbW1vbiB3aXRoIEdJQ0QuDQo+ID4+PiArICAgICAgICAqIFNvIGhhbmRsZSBjb21tb24g
d2l0aCBHSUNEIGhhbmRsaW5nDQo+ID4+PiArICAgICAgICAqLw0KPiA+Pg0KPiA+PiBUaGlzIGxv
b2tzIGxpa2UgYSBzcHVyaW91cyBjaGFuZ2UuDQo+ID4+DQo+ID4NCj4gPiBJIG1vdmVkIHRoaXMg
Y29tbWVudCB0byB0aGUgbGVmdCBieSBvbmUgc3BhY2UgdG8gYXBwbHkgZm9ybWF0IHN0eWxlDQo+
ID4gdG8gYmUgY29oZXJlbnQgd2l0aCBvdGhlcnMuDQo+IA0KPiBBaCB5ZXMsIHRoZXJlIGlzIG9u
ZSBtb3JlIHNwYWNlLiBCdXQgYWxsIHRoZSAqIHNob3VsZCBiZSBhbGlnbmVkIGxpa2UgYmVsb3c6
DQo+IA0KPiAvKg0KPiAgICogRm9vDQo+ICAgKiBCYXINCj4gICAqLw0KPiANCg0KRWguLi55ZXMs
IHRoaXMgc2hvdWxkbid0IGhhcHBlbiwgc29ycnkgZm9yIHRoYXQuDQoNCj4gDQo+ID4gSSB3aWxs
IHVuZG8gdGhpcyBtb2RpZmljYXRpb24gYW5kIHdyaXRlIGFub3RoZXIgcGF0Y2ggdG8gZml4IGl0
IGlmIG5lZWRlZC4NCj4gSSBhbSB1c3VhbGx5IE9LIHdpdGggY29kaW5nIHN0eWxlIGNoYW5nZSB3
aXRoaW4gYSBmdW5jdGlvbmFsIHBhdGNoIGlmDQo+IHRoZXkgYXJlIGFyb3VuZCB0aGUgY29kZSBt
b2RpZmllZC4gVGhpcyBpcyBub3QgdGhlIGNhc2UgaGVyZSwgc28gcGxlYXNlDQo+IHNlbmQgaXQg
c2VwYXJhdGVseS4NCj4gDQoNCkFjay4NCg0KSSB3aWxsIHNlbmQgdGhlIG5ldyBwYXRjaCBhZnRl
ciB0aGUgbmV3IHZlcnNpb24gcmVsZWFzZW1lbnQuDQoNCi0gLSAtDQpDaGVlcnMsDQpIb25nZGEN
Cg==


From xen-devel-bounces@lists.xenproject.org Fri Oct 15 08:23:02 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 08:23:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.209915.366496 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbIUX-0005Te-FZ; Fri, 15 Oct 2021 08:23:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 209915.366496; Fri, 15 Oct 2021 08:23:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbIUX-0005TX-CF; Fri, 15 Oct 2021 08:23:01 +0000
Received: by outflank-mailman (input) for mailman id 209915;
 Fri, 15 Oct 2021 08:23:00 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=FGCa=PD=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mbIUW-0005TR-EE
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 08:23:00 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 1ae0edb0-2d91-11ec-8227-12813bfff9fa;
 Fri, 15 Oct 2021 08:22:59 +0000 (UTC)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2052.outbound.protection.outlook.com [104.47.13.52]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-10-u1NHadIWMeS9ZaDwvzwZ0A-1; Fri, 15 Oct 2021 10:22:57 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB7038.eurprd04.prod.outlook.com (2603:10a6:800:12d::9)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16; Fri, 15 Oct
 2021 08:22:55 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.017; Fri, 15 Oct 2021
 08:22:55 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6P195CA0025.EURP195.PROD.OUTLOOK.COM (2603:10a6:209:81::38) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.16 via Frontend Transport; Fri, 15 Oct 2021 08:22:54 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1ae0edb0-2d91-11ec-8227-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634286178;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=tcEEOLuogRK5uoZ3FacOBqBT2+NDkomXpHyEYUQstR4=;
	b=IEq77BOqekVfBBWg7CoW2s+bPJO30/uiEz7cta+QRLf5EZuo7XSH+M80sq+8f6YmnGyMc0
	gPdFEcqS0b3YeMu+KLa7DbGGknwV1nYjSVk4TEK+B8PCJ+th89qJuM3s47sILOHOGs37+F
	pokmYGBg10sXCCOsA2NaCcBxpINHL64=
X-MC-Unique: u1NHadIWMeS9ZaDwvzwZ0A-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=iYRyIQPbObyhdpT2DZ20kbjkxgX3UfV5sfVGhrU0omrFwhU7T8YY0sthG9BrhtQyQGYrIuOVg/Xmgwb8mQi5HpfPgvuEfdJGQtouFV/Pz8MZ7UxISHaSBY4uuoYX4BgC46z0KZzTRIFP9+ci0ktGfLoDw+pesYEBXHlZBFXX1+WH1HPzvNt/yglbfbMgM35wtayojkJ5JKh+BffauuUs7YP6pTeIwwaz5zvMIa18dmV0LGEFwuyM+BVCivCYZrxYxEmgKnefghPK9Qcx4HpCrtnEh6v7Wq3lFc3/fexj4d7ghnU35ZPlSbis8erAY8vcD/PKBqIx0xMlzs/7DYn66Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=tcEEOLuogRK5uoZ3FacOBqBT2+NDkomXpHyEYUQstR4=;
 b=Svla099OAwZ15hV4mA6oSbMHn6s8/0IeOfQVkVvXByOZw4xEwyfZYFQ4XR+pDokRKNozszs64c/1dCn5pLaYNq+b/LK8doj3P9Y9vp04gt+tXYSLsSCyie06fAo9m3CrwMWPV+lOcfpu1ltprs143WEXPrXcaxwSeOZcYSgKef74NLldJfLyUKrv77YvipcQFBzwG1zlvBC7xp1SZvmHeCaf87n9fV1BOxK4ODMareldL+Bm+kCnjBWPJfE6VXxg1vxSsQxEg7y6/ZsUAwZ7TqDc1k2x5yyGXXo4rEq8L4AUIDAzpc4JfEsFy9zpt7PL7yAPNiOl3iSzMjbUYr2FNA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [PATCH 1/1] xen/include/xen/byteorder: Re-implement bswap/swab
 with compiler builtin functions
To: Lin Liu <lin.liu@citrix.com>
Cc: sstabellini@kernel.org, julien@xen.org, Volodymyr_Babchuk@epam.com,
 andrew.cooper3@citrix.com, George.Dunlap@eu.citrix.com,
 ian.jackson@eu.citrix.com, konrad.wilk@oracle.com, wl@xen.org,
 roger.pau@citrix.com, xen-devel@lists.xenproject.org
References: <cover.1634282259.git.lin.liu@citrix.com>
 <ed4f3f82cc2989ebf52425aead420014fbe00bf7.1634282259.git.lin.liu@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <a51be6b0-ba7c-0f0a-b441-a9594607954d@suse.com>
Date: Fri, 15 Oct 2021 10:22:53 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <ed4f3f82cc2989ebf52425aead420014fbe00bf7.1634282259.git.lin.liu@citrix.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P195CA0025.EURP195.PROD.OUTLOOK.COM
 (2603:10a6:209:81::38) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 7d931fb0-b638-4e43-2934-08d98fb4fd2c
X-MS-TrafficTypeDiagnostic: VI1PR04MB7038:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB70387773EA625076B7331614B3B99@VI1PR04MB7038.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:655;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	aGPmvUm7Wq+YuKPhdOjCIbB8i1q6FbfPviDQdWJi1Jgjwc9Ojjckzp/dVyrw/ytqRqTkjVRJ97fSIuxfvr9LVszzJUZb0ldDWSws46d+Evo9b1rA+mO1dVDFGACJMDgrCMriLyI3G1j65Ozm6ooY3snGsoMJicMjqmY9IOlRtljijlPyAkmTu2GTK5HRPY0GvkRwG7Zh0WPeTjcdJYSOpOOmlNWee7FDJm/6ZsAJHS7qqqTcS+Dyy1jOxeDc+1z6rfacfBqDYRQtpTYwF4pnVhU3Bo3Yg8I9beoPQfAG3rnyAO+PAXTYuVvLRep3v343ZoAyx67wRK+x7BR1d6XurOCbL5CBpHrF8FKXS1CXsnV9HU2A3itiE2Rdbg6b4V8vOsbV0/Ebcwzsrbv6XTpoBc1m3MK9XkxPvm/R6Dc5nsEqrpIDNPxeiGiE1UAkP9RdidNx4Bm0N6fs+rCDJ2XaEgjHy0cskMkS1vMLZuemzaHHJQMHurLXZvby9GCsHaOJ2yB4BvnTzNqoCbJYKy8nA4IATOWLIKJp9yFUFA+a7Ut7zlOA9lt7AKZF7ZgDVAYSn15/KQSlhy8kX0Lg/xN6tl0e5o2wDBlvqL2pHbuEmfTYqdQCk+aEd7yiBc/Ex3P4N18r1uow+L2xCuECu6O1oahdJNtJnT/lh6O7lAz+9sVGozTeZ6G2bzKAtsSOWa0gBreftn92o1pIyYlPnGwrswtfSNm5b11NySnJ4ZDrO4ZrXIBHtrR2ipLVYGiHmSrI+K6GlsFfutasxbD44GKFqDQnVcZ5h++juIpu9jmvan9p5Je9RB5t5agJ6Azo9oky
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(83380400001)(966005)(38100700002)(2616005)(8676002)(66556008)(66946007)(26005)(66476007)(6916009)(8936002)(5660300002)(7416002)(31696002)(6486002)(4326008)(53546011)(86362001)(36756003)(16576012)(31686004)(186003)(508600001)(956004)(2906002)(316002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?S0tOVk9sQjIvUHRhR0p3N20ra1U0ZXhtRnVjaEtHK3NnQklSaU9IdWd0UW4r?=
 =?utf-8?B?bklMMnU5aGJkTHdMdGpSb2ZZWnhLZG9lNk1WVXNKOTh1MHhWVXRiemNDMG5u?=
 =?utf-8?B?Mnc4d0MrajVtVENZVU5EUkRwVEpGc2x1UncvVVFvd3JtZGxsN0lnSlJJV0JM?=
 =?utf-8?B?cDZYSUNEL1lzNEdxR0RVb0Q1QVR6UWpoYy9Ib2V1RnEvWmhoczBvUUVjSjNv?=
 =?utf-8?B?YUVGMjZsU2FHVVJURXFtV2x6ZVpwQ1R6dEhkamZ5N2FwK2ZyNDVkOHlrQTdt?=
 =?utf-8?B?ME5JTzFDV0EyWlJ1NWt5SkxSYXVNTXFadm05VjN1bmpkLyt4QWZXL1FqREpm?=
 =?utf-8?B?ZWM2d2tZUnZ2VWpZNGxJYlU0eEZRaXlQa05ZNVdVWEgwOHN2azV6QUpBVXlh?=
 =?utf-8?B?WG1rUThBL0RyM2Y1UjZSTEwvdjI5TE80UTRxUG4rUlN2RnFnUE9odG9aRERh?=
 =?utf-8?B?MG43bGdJVmJzUERGcXgrNTZkSE9XUVQ1TWtzSmdWL3NWQXlyVEN4NVVuSUdv?=
 =?utf-8?B?TlpWYU91ZmY0cGpIdmxTK1FHL1JJbnhjbEUwQllUbkkxbjF4YTNwaGdTOHIr?=
 =?utf-8?B?bHVCUVpZN0hweGdqcFpoeTNja2VGaFp6RVd1a29HUEF4bElkMGtiZWNpTThy?=
 =?utf-8?B?V29STmpvbE85c1V6V2szK1pTQ3BHUXFoVVB6M09Pc0xHcXovb2VxRjAwUmto?=
 =?utf-8?B?QmdrYy84TC9yakN0UkFZV2gxV3gvMWRLUXhSalBTSzh2eTZ2OWkzM2Fza2tN?=
 =?utf-8?B?Sm83bFZDQ1A0K0ZpNTB3MFNGclREbHR1OWM0cUJuN0FldSs0UmNFaThtYWo4?=
 =?utf-8?B?OVV3eHFtcVFUMUg1c3l4dmtFc2hPWFhtZk1UaDFmbkJZTTBrN3Ayd1Z3eUN4?=
 =?utf-8?B?dkFuVWxCVG9kQVd2cVNtQ09YREVWbmViRXp1Wmx4SVhLc0VMWGxmTkZYbDNG?=
 =?utf-8?B?YkpYMGc1d2gvWmlwTzFkR3Uwemx3Sk5DWEJYU2lhSTFIM24wdFdQNlZyRWl4?=
 =?utf-8?B?dDMvZEYvMGtZNFduUU9mQkduUFJpdU96Um9BVkEra3EzdlBOd2xuWmZIdFAy?=
 =?utf-8?B?TVk4eU84ME92YllaejRoMHVQVUxzdi82REp0VnVzSmJjOTFtN2R1NGNvNDNZ?=
 =?utf-8?B?R3BnWThQWi9GOXlUbFowNTVuTkVEZ3FLaXZYL3hzMjNLY1pTSDRHc2M3SFd1?=
 =?utf-8?B?UFhFY0txRW9EUTlwYjd5bGNyNldqTHNHdFB5enlGZDYxWlo5d0pubGpueDFL?=
 =?utf-8?B?TGtRSnB6RDhDU3VqM0VaSDdkMzlEaGpVUkZ0TS9mYTkxRjJwYXNGbzFWWk1Z?=
 =?utf-8?B?emtZN293aEpPQWlGOGVlUi9BbmttNWFqOXFaTjBrei9kdkFTTkd5R0dPcVBQ?=
 =?utf-8?B?N3ZjclpNbjdOTENEVDJsdmwreFArVkZhZDJaa0ZNTVdJOFJneTE2WGVpTEpp?=
 =?utf-8?B?SlZvYzNxNGNuZVBaVlJzeXNjMnduNnBjQmJFOEZmck9rSlBtSVl1NGlHWGFU?=
 =?utf-8?B?LzhGWHFVNWpuZEFObzhUTU1pbktmdHExNjM3a2IweEd1bEQvNUNJd1dNeWow?=
 =?utf-8?B?Q2gzRUVZbmRqbGJZaHVSMU1hOFpXdW9sWEk1OFM5V1JpQ3RkS1hBZmhKM1dL?=
 =?utf-8?B?dVBNcHBtRmk1Unhnanhyd1prdTRJUjlCT1d0V0E3ZWVzY3NKcmo2aDUxMjlK?=
 =?utf-8?B?TmwrbmZ3S1VSTmNYQzZnYm5pcWZrL3JTcnpqS0xJekZDbVRzVGxHbVFNOXZH?=
 =?utf-8?Q?gxHeMah3woJdFr5f/ze3YYj3dr+ztiuyU5EVwIj?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7d931fb0-b638-4e43-2934-08d98fb4fd2c
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2021 08:22:55.5150
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: IOC9Dmn6GsYCOaJFCwh2b9WKZO/d2GRCGsXrWAF4pBLTwh0GV+u9kaNSxtZd3pdlcYIA3ftASORqKraw1q6rug==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7038

On 15.10.2021 09:26, Lin Liu wrote:
> Current implementation of bswap/swab is overhaul which involves
> byte operations, compilers has builtin functions can help to
> simply the implementation
> * GCC: https://gcc.gnu.org/onlinedocs/gcc/Other-Builtins.html
> * Clang: https://clang.llvm.org/docs/LanguageExtensions.html
> 
> This commit replace the implementation with compiler builtins

__builtin_bswap{32,64}() appeared in gcc 4.3, __builtin_bswap16() in
gcc 4.8. I don't think we can use these just yet without having any
fallback. Apart from this aspect the change looks okay to me, with
just one nit:

> --- a/xen/include/xen/byteorder/swab.h
> +++ b/xen/include/xen/byteorder/swab.h
> @@ -10,166 +10,32 @@
>   *    to clean up support for bizarre-endian architectures.
>   */
>  
> -/* casts are necessary for constants, because we never know how for sure
> - * how U/UL/ULL map to __u16, __u32, __u64. At least not in a portable way.
> - */
> -#define ___swab16(x)                                    \
> -({                                                      \
> -    __u16 __x = (x);                                    \
> -    ((__u16)(                                           \
> -        (((__u16)(__x) & (__u16)0x00ffU) << 8) |        \
> -        (((__u16)(__x) & (__u16)0xff00U) >> 8) ));      \
> -})
> -
> -#define ___swab32(x)                                            \
> -({                                                              \
> -    __u32 __x = (x);                                            \
> -    ((__u32)(                                                   \
> -        (((__u32)(__x) & (__u32)0x000000ffUL) << 24) |          \
> -        (((__u32)(__x) & (__u32)0x0000ff00UL) <<  8) |          \
> -        (((__u32)(__x) & (__u32)0x00ff0000UL) >>  8) |          \
> -        (((__u32)(__x) & (__u32)0xff000000UL) >> 24) ));        \
> -})
> +#define __swab16(x)  (__builtin_bswap16(x))

In cases like this one there's no need for the outer pair of parentheses.

Jan



From xen-devel-bounces@lists.xenproject.org Fri Oct 15 08:24:35 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 08:24:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.209922.366507 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbIW2-00064o-Qt; Fri, 15 Oct 2021 08:24:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 209922.366507; Fri, 15 Oct 2021 08:24:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbIW2-00064h-NN; Fri, 15 Oct 2021 08:24:34 +0000
Received: by outflank-mailman (input) for mailman id 209922;
 Fri, 15 Oct 2021 08:24:33 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=FGCa=PD=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mbIW1-00064Z-5I
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 08:24:33 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 522e9df9-2d91-11ec-8227-12813bfff9fa;
 Fri, 15 Oct 2021 08:24:32 +0000 (UTC)
Received: from EUR02-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur02lp2051.outbound.protection.outlook.com [104.47.4.51]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-33-VkE-98xcN1qfUiLyU881kA-1; Fri, 15 Oct 2021 10:24:29 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB7038.eurprd04.prod.outlook.com (2603:10a6:800:12d::9)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16; Fri, 15 Oct
 2021 08:24:29 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.017; Fri, 15 Oct 2021
 08:24:29 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS8PR04CA0090.eurprd04.prod.outlook.com (2603:10a6:20b:313::35) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16 via Frontend
 Transport; Fri, 15 Oct 2021 08:24:28 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 522e9df9-2d91-11ec-8227-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634286271;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=i3pZo031zZZd7VKTWJucMw6/RGE1cqzsBzXnvbwxelk=;
	b=idD9LHsIvkVaYdeer1Gnq++XDItW8iYhA2KODEJEqRk6LPc56ld+vanSxr+FNVabiS5Zp9
	4DWfsnWKZAv1wUXUt8jm+pcWPbu7MkB2w0wieHcqXD+FzL6E8vSUZwVq7104XDVPIOgIGS
	8Mm87ptf1SJO9bDPTkkqaoCxq6WEeGc=
X-MC-Unique: VkE-98xcN1qfUiLyU881kA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=edFP/cVsaFiamomhnopHxV6K8agDiPNb791LaTSiGTrzihbHd5CyjLN4eWnbGF3Y+DM/1WWGPMYgtuo1vseR968vICj3JhCE7DLeWSTPDSpTwMIab/1VIu+2hqoqu3YhFSjkNQ3U6FIFkTkVLUgaZ7MTqbKKLj9yhnqTySkzEEVYIhwTLA+FkvT5q2r0co0Ik1/aKbOM/PBBK/X2fB3tnWXWPKtRgw5NM5/rKgOoNH/nGwFwz0Z18HlmWe/yX9ZLkMMaFfuZX9CFW4JtANpPQDVJmnWE6Wt734xmIhYZMs98pKtypP6vv9UVW+yFk+qTXOJP8MueUniKUt8EW1oZBQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=i3pZo031zZZd7VKTWJucMw6/RGE1cqzsBzXnvbwxelk=;
 b=nFLY+CA8ArdOS7HFMzr6DMFk+Mk7vTDLLFVCTYZiVOOBs8iW+BVv6uJoRpaT5/c38ig5Vpm49A42sZ0OViN268qMOAgZsARddRV3Piu5SBWNf21mrl790clASeLOnN0ZSBboYzQv+tYJIq8iPaPW3wT/qePLkmIrrTxBQX3bTazmIuqh83JBUUfgveRaSYfEcMziWN+Cs2hSoV4dKcvkhXdS6R/mrUHIFXIX2CHnr3pMt4m1tKV7orR4ypYBs8B0ajLY1VwCy7u9ImwacLhIf+YN5bI1AXXMaV0MGD5+7HP4K+XIRn1kDDICBxz2/LkSNLhoqMrS4EQWD77RKW/A/g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: xen.org; dkim=none (message not signed)
 header.d=none;xen.org; dmarc=none action=none header.from=suse.com;
Subject: Re: [PATCH v6 1/3] xen/vpci: Move ecam access functions to common
 code
To: Bertrand Marquis <Bertrand.Marquis@arm.com>
Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Ian Jackson <iwj@xenproject.org>, Paul Durrant <paul@xen.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Julien Grall <julien@xen.org>
References: <cover.1634221830.git.bertrand.marquis@arm.com>
 <ced6f870dbfabcfe8584555cc80f9a37a0655a0c.1634221830.git.bertrand.marquis@arm.com>
 <20c73f4e-5a8b-c127-f3a7-b841f50b1a4a@suse.com>
 <6C71E132-0A78-4DA4-AA52-E62833912145@arm.com>
 <8a7d1370-ee58-8e95-efea-8e4162e1e5f7@suse.com>
 <152124C4-9A34-4F5B-B6C5-CBCC6A175665@arm.com>
 <9f0f8e0b-c989-d2ae-39eb-6784446fa6c3@suse.com>
 <9B9BE725-53E4-49CC-80EC-E856081E08ED@arm.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <ab925dae-236b-d4f4-6b82-15d924297f07@suse.com>
Date: Fri, 15 Oct 2021 10:24:27 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <9B9BE725-53E4-49CC-80EC-E856081E08ED@arm.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8PR04CA0090.eurprd04.prod.outlook.com
 (2603:10a6:20b:313::35) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 21c002eb-fb11-4bd0-178b-08d98fb534f2
X-MS-TrafficTypeDiagnostic: VI1PR04MB7038:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB7038036A39BDFFDEE429584CB3B99@VI1PR04MB7038.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:2399;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	VdxYS3uy8IJ90o3NFwZcaMUWvu4ffXTtzXFwILtJQMyrYgs6NDWPygQZngYYSDuQZTKTokJpmQ+/L7uQ4h2NiLhVK7Lq27RHDw53RRq81Vgz6IV85yEhKxM35R6X3I0ETx2cMmU29ul4D3981IICC+VIp2IKYmB0dQcfj8QTvZKnhvo1mPfkJVnIbC6aNQavPH9YpHRXNe4SP6U5A4kxuSnuxUz3X/ytLcXUB+QNbduTjmhK1TxqmH0cpP/R9THee6I3f/gS5/DBTp992t+VFCsugKnaYHeLnG7oy+d2DVD7zqIsB/bQrcQBLsjiJ5WwQQbXKZEwWKGjCB/m5WtmFdutQ7qbGX9kPOqsdIsebFuv0i6/E7cmBLFF/YUqyqjqtxV/GL9uwAVcivuKApoQzurAQ1NnpXbI7R3kI+RRpPfNMQegLoiNoiSptM74f7CZdGYCuycVGUnWC9sl3NP55LL9xZfYhsF4IaiRzewJRrbt0kuXzh3BaR8EaWxxBj1/M/yJOgz5lTirNWjiRhQlbBIToZLtEyWp5ShpA67pexhzf6GAumfDIiAwwbb9fld4RSW0HXGVAOZ9nLbIkk2pHxMjgLmjA78cP/tcqiLZ1RzoJFYV1f6wi/qSgLwlWJBsNZlgSbah+0uLraGtJiRZW+u2JHpc3omg7qscAfVGIQfDQwZ8HEqFInAq7foIIKBfcne1hZS3QwIWAMpsE4N+3lYg4rz/q/ZQiVM24qV5KLM=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(38100700002)(2616005)(8676002)(66556008)(66946007)(26005)(66476007)(6916009)(8936002)(5660300002)(558084003)(31696002)(6486002)(4326008)(53546011)(86362001)(54906003)(36756003)(16576012)(31686004)(186003)(508600001)(956004)(2906002)(316002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?aXg3Q3RiN3dyRWdIL0hEeWtOMnB5cXpIb1ZDSjJ1V29BRVVOeDZTbGNiRkh0?=
 =?utf-8?B?cStic0ZGWEovQ2lmY2tFc0gxNzlmOWJ3RzRYMzFiSWVxRDVJa3FaUUJQNjNt?=
 =?utf-8?B?NXNRT3laMEszbjhWNGNlY2ZhSUZyeXZObnJkMmhwTzBZTXdndW9IOUo4Zmo0?=
 =?utf-8?B?K1ZPa08rSFRzNFJRSElkS2dtanBaNVdxTExUVkZMaUZSa2pkSzk2bUtrRmNw?=
 =?utf-8?B?dkhyZDhPc2dYREJock9SUm1KS2k0OW9kSEtRaHJQemoraDVoTDFhd3A1RnE5?=
 =?utf-8?B?Q2tmb05WRVlDY3IvbVI5czlaYmx4UVNnNjJzdHhYYzJPWkxYRy90S3RXczRa?=
 =?utf-8?B?bHkxRmtWZHk3OCt4ekxrMENBK2U1d21SY3pwUndESktic1pLNWZyY09PTTFJ?=
 =?utf-8?B?NlArcHUyVlQ1aEoyTlcxSHpIQzdraGxvNVhyL245S0NNcWFWZGY1MFFZQ1hk?=
 =?utf-8?B?d3RaakVseU90V0N1cmpLQUVPR1JCOFU0eXQ4UWY5WEN0U08wZklIUzdnU3A4?=
 =?utf-8?B?WDYzYTNyVDl4VEtuNnBwR0pSQUpGdTFHNFpiY3l0eTQ0TjBxQXJhcmwyckwy?=
 =?utf-8?B?c3ZPSzlrUS95azRmNXZVa2lxcC9YaGZZTEU5RG51dkhMQzBXM21vczk5Yk1X?=
 =?utf-8?B?Szl4U3FMKzJkTFRLcXNMOFFjaFcwV25QZStIQklEaEs0Zk94UUNzNGxZTzFq?=
 =?utf-8?B?ODd2bk1qVWZIVnRPVGF5UGxwd29qWWI4R0VuY0haMHpoM3E3aWNLdFpNTnBt?=
 =?utf-8?B?UEZ4K3ExT1NGS2tsQ05LUmNNc0NUd3RrODducWJ1cVp3UStWcXlid3F3VE4x?=
 =?utf-8?B?L3Y3L0pMbWl1OGxMdFFzVG93YUh5cjZIMDhUZ2lYSitIMVhWQXVLdnVXdjU2?=
 =?utf-8?B?UzQ3ZW1UcTZMcEl4S0ZUbzdXVHlKYjZZb0hUVDVLS0tSUUNpbDBVUko4RUd6?=
 =?utf-8?B?Wm9pL0FVTVBuRGJWd0pHb1dHLytmaTV1S25SUzM2VXZuZWJKVWxHNFVtaHhl?=
 =?utf-8?B?cEZyYmI3N1A3UVd4dmNrS2RJb3p6UXo2NnQrcWQ5bWZXcXV4cVpRVC84Z3JY?=
 =?utf-8?B?ZVJJb3I1S3pHYjVSWk9LWVV1bEI3a2RwdFVWMEk5cFJDVnB1ZGpCbkI2RUto?=
 =?utf-8?B?VGxrdjMvbkN4WXd5T2pPOFV3TExGRFJMY3FSWlpNSVpqZDF2VE1LTWFpbG9W?=
 =?utf-8?B?b0FEMmxrcUNSSmc2VjBPcGEwUkxNYmZHR3JtNE1ub0RzMzB0SExqckNNQ1R4?=
 =?utf-8?B?VThrNWd2K0ZzQnlGVkdZQkp4ZFROZW5NYjdhWDdta3FZL25hNFNmdHBGYzVE?=
 =?utf-8?B?ZVFncjIveG9xZy9pdVg4ZEFjVjhKMm9ycW5uZTJxS2Y4ZHdwYWF4dGR6Mi8r?=
 =?utf-8?B?VitUaXFjVG1UeWd6Z3duRDFDK3RuUWlLdWp3RTY1R2NMRDZiaWZBeUVFNE1s?=
 =?utf-8?B?RUUvVFpPZFRCenJ5R2ZmM2xZeXlXdWNESktTdHZoVU1tbnZML29vaHU4cWQ1?=
 =?utf-8?B?UVRpa0REZ2NUcXk4azV3eks2STBTMlNoc2NkcFhKZFdwRnhzTXpTSllqR09l?=
 =?utf-8?B?S2VjYnFVd2FHMU5XN3k2NXQzWGkvZURONmMyMGRtdXhVNXNseW5BV0I4ck9T?=
 =?utf-8?B?V3d0SDNTZThwSTR1NWc1aGtMQUxFejJYdFpEOVdwNjVyU3o4NHVma24yNk9t?=
 =?utf-8?B?OWJmQStZOHFsL3RaT0dORENQdWxNenovd3pvdkxnd2hiZjhnRHR5NDBoVWpl?=
 =?utf-8?Q?A1ws44aEzXrQ5zgeEqw0uRHmMecudgDy9nVhy2Q?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 21c002eb-fb11-4bd0-178b-08d98fb534f2
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2021 08:24:29.0828
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: fl3ly7suib3F15AulSLLnekAziBfZmVH4N6FGx+XMIyAS3InLKbDWQHNWHUwOAIGG3k+oX/UvIqUYWNUrnIvBQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7038

On 15.10.2021 10:20, Bertrand Marquis wrote:
> Anyway if we agree on naming scheme and bool return type I think all
> your comments here are covered ?

Probably, but I have to admit I've lost track ...

Jan



From xen-devel-bounces@lists.xenproject.org Fri Oct 15 08:34:20 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 08:34:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.209930.366518 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbIf2-0007WX-O1; Fri, 15 Oct 2021 08:33:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 209930.366518; Fri, 15 Oct 2021 08:33:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbIf2-0007WQ-KW; Fri, 15 Oct 2021 08:33:52 +0000
Received: by outflank-mailman (input) for mailman id 209930;
 Fri, 15 Oct 2021 08:33:51 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=UM5E=PD=citrix.com=roger.pau@srs-us1.protection.inumbo.net>)
 id 1mbIf0-0007WK-PM
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 08:33:50 +0000
Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id f370f1f1-d5bd-4cf1-9d0a-393a60039f3a;
 Fri, 15 Oct 2021 08:33:48 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f370f1f1-d5bd-4cf1-9d0a-393a60039f3a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1634286828;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=eA4VPJlqf2r+B6/UrDf2aD9m7XenpRSy47re9JtrLXc=;
  b=U/jwxmc4EVy+UPR2wJNQuB3naEJ8Bb1SkQPU3aP7RoEvTvLn4VXLHY8N
   Zj65c23uE6ov08tvObodul1MbYHl8tBycoMtK+4e3t9Cr7CEuzGmYlV94
   /O4yrIos7PdGecv5cfjHkr9bpVDEd8yMa/AUWlUwUOQ7XFgP50Tyl1SnE
   k=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: H4RSizQZgWZp3d0Bh1zjpLMEzBOhfKVchZUjIcOX+rakuZv2YWYrKNfjLZXzJ3r6YoUGQQXAGF
 jl7iGt1a21X2ElS/OsrqLIJmB4wpjZ1ZU5j3yOaZ6aTeIgyv0ZRcW+tKL0xWuA418aEmTsC1VG
 dU6JAjKj6QMiiWc5IJPaXNhq1b/EZlMc0zRT4lzZ7wETsCQ8CsKvNsas2f69Eb4hObDN7iFKLa
 4KQthyFh5mvSqoVHKNMI/zyr6WMFocKKJCewAK0//xhBkGPPdJ1qs40a8MDDEm7a48iZSUWcVI
 UgaUnlfm4mcNaGc90J6SmYLv
X-SBRS: 5.1
X-MesageID: 57154802
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:DioBL64OJWPxoU/W2WgQUwxRtEnBchMFZxGqfqrLsTDasY5as4F+v
 mMXWG3SOK6MMGryedh+boi0oxgFupaEzYdkHgNsrnhgHi5G8cbLO4+Ufxz6V8+wwmwvb67FA
 +E2MISowBUcFyeEzvuV3zyIQUBUjclkfJKlYAL/En03FVIMpBsJ00o5wrdh29Mw2LBVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Z7
 uoQsr+RUBwSHYaUgPgWeTBUKR9ZBPgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALNs7kMZlZonh95TrYEewnUdbIRKCiCdpwgWhp25weRay2i
 8wxUTc3UxvuRy92OkYoJIo+jsyio3X1WmgNwL6SjfVuuDWCpOBr65DTN97Sds2PVN9itE+Sr
 WLb/Ez0GhgfcteYzFKt8G+oh+LJtTP2XsQVDrLQ3vxgjUCXx2cTIAYLTlb9qv684mamUs9bA
 1wZ/Gwpt6da3FOvZsnwWVu/unHslg4RXZ9cHvM37CmJy7HI+ECJC24cVDlDZdc68sgsSlQC3
 FKTg8ngAzAptbSPUG+c7Z+dtzb0Mi8QRUcDei0sXQYD+8Pkoow4klTIVNkLOLWuktT/FDX0w
 jaLhCsznbMeiYgMzarT1UrOgy+o4IPISAE1zgzNWySu6QYRWWK+T9X2sx6Bt68GddvHCAna1
 JQZpySAxMYxUJautTWWe8YmRKm17NysPAfipmc6SvHN6A+R03KkeIlR5hR3K0FoLtsIdFfVX
 aPDhe9CzMQMZCXyPMebd6r0Up5wlfGxSrwJQ9iNNoIWCqWdYjNr682HiaS45GvqjFQ32Z82P
 ZOWYK5A5l5LVPw5klJaqwobuILHJxzSJ0uPGvgXLDz9iNJygUJ5r59ebTNiichjvcu5TP39q
 Yo3Cidz40w3vBfCSifW65UPClsBMGI2A5v7w+QOKLXfeFE8Qzx4W6WPqV/ER2CDt/8I/gsv1
 irlMnK0NXKl3SGXQel0QiELhEzTsWZX8itgYH1E0aeA0Hk/e4e/hJrzhLNsFYTLANdLlKYuJ
 9FcIp3oKq0WFlzvpmRMBbGg/dcKXEn62mqz09+NPWFXk2hIHFeSpLcJv2LHqUEzM8ZAnZBg/
 uP6j1iFHMNrqsYLJJ++Vc9DBmiZ5BA1sOlzQ1HJMp9UfkDt+5JtMCv/krk8JMRkFPkJ7mLGv
 +pPKRtH9+TLvaEv99zF2fKNo4uzSrMsFUtGBWjLq72xMHCCrGakxIZBVseOfCzcCzyoqPnzO
 70NwqGuKuADkXZLr5F4T+Rhw5Uh6oa9vLRd1AllQinGNgz5FrN6L3Ca9sBTrakRlKRBsA67V
 xvXqNlXMLmEIu3/F1sVKFZ3Z+iPz6hMyDLT8e40MAPx4youpOiLVkBbPh+tji1BLeQqbNN5k
 Ll54MNPsl6xkBsnNNqCnxt4zWXUIyxSSbgju7EbHJTv1lghxGZdbMGOESTx+pyONYlBaxF4P
 j+OiaPerL1A3U6eIWErHH3A0OcB15QDvBdGkA0LK1iTw4eXg/Y22Fta8CgtTxQTxRJCirohN
 m9uPkxzBKOP4zY325QTAzHyQ1lMVE+D50j861oVj2mIHUCnW1vEIHA5JevQrlsS9HhRf2QD8
 byVoIo/ve0GoC0lMvMOZHNY
IronPort-HdrOrdr: A9a23:k/eBDa7wr7205T1FiQPXwUiBI+orL9Y04lQ7vn2ZFiY5TiXIra
 qTdaogviMc0AxhIE3Jmbi7WJVoMkmsjqKdgLNhdotKMzOW3FdAQLsN0WKm+UyYJ8SczJ8W6U
 4DSdkYNDSYNzET4anHCUuDYrAdKbK8gcOVbJLlvhJQpHZRGsNdBmlCazqzIwlTfk1rFJA5HJ
 2T6o5svDy7Y0kaacy9Gz0sQ/XDj8ejruOrXTc2QzocrCWehzKh77D3VzKC2A0Fbj9JybA+tU
 DYjg3C4Lm5uf3T8G6S64aT1eUZpDLS8KoCOCW+sLlXFtwqsHfrWG1VYczCgNnympDr1L9lqq
 iJn/5qBbUI15qYRBDJnfKq4Xis7N9m0Q6f9XaIxXTkusD3XzQ8Fo5Igp9YaALQ7w46sMh7y7
 8j5RPui3N7N2K1oM3G3am+a/iqrDvFnVMy1eoIy3BPW4oXb7Fc6YQZ4UNOCZ8FWCb38pouHu
 ViBNzVoK8+SyLTU1nJ+m10hNC8VHU6GRmLBkAEp8yOyjBT2HR01VERysATlmoJsJg9V55H7e
 LZNbkArsAGcuYGKaZmQOsRS8q+DWLABRrKLWKJOFziULoKPnrcwqSHlYndJNvaCqDg4KFC5q
 gpYWkoxlLaIXiedvFm9Kc7gyzwfA==
X-IronPort-AV: E=Sophos;i="5.85,375,1624334400"; 
   d="scan'208";a="57154802"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=mVDOaaxYvq4RzaMi/W+or75TD0/GN3cHCa1boalJ3iutaki7n7+QCwL+3Lza+qjCZRnzUCrWQdHqhEiwPU3RXwBLN1PsmeobOO2ivCM/qWV1z/4pzvKO+7EljN0gQvbcSNdtHujxnuesYJBDb3PH9gAX+rxJPZqUV1lcm3qVOOTWEyusatuRy96F2Wbutpn/MT21sQD3TO9mbkSgB8qZmTNu9oiDba6KVM/jz6Hl5ac3pHBqiXKobf84PJsDBlQNtBRlzQdSYvNMBvyqEZNqdfEw976RoziNqanZlA2Bd9lzspVln2TX8H+OBE/++HXOvjo7aP8W3qLvcvz5b66kbg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=gAuRfnc1G5Fbz2J4zxeYdGa46ophWsjCLeuvL5kxp4c=;
 b=jnV6joemXM0yTkqQVVdU5OUZvA6+I98tW+Yh1Y36QLAs+l/MnsSbiAPgzusdTGUJs16X+f8u3TZlvvU6ETK1tXt9FmBH6TdUR3hJQxBTXa4+/x9d0MwPg5DGb1xTZpSa8JMuiEl22GjDSmhTbZmQ7197kZ8A4da7tlij0/Ixoi5TPg8JlrXAX8j0PLUVyzT9dHYJC5tEKlwQKtna4YnotZXzFMeAOLnE4l7KlCpk80U231LfIyjitbiPXNBr4UhYXOtCM6bQON0+NjJqa4g3K2t0dwK3vy0ltmwPkQKLJMw81mtuuJLDs9/0GL7+di20/PpjrQkV44x8dXBPEWRE/Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=gAuRfnc1G5Fbz2J4zxeYdGa46ophWsjCLeuvL5kxp4c=;
 b=OlO94h5emSIHa7fX7nLDWqMYGu+Ej75l8GvDY8Ae3LTtwKyzIkGsgKDTcEGheUqk7sT8jIjlJ3nC9x5JBwkR9FhR7RT2SBK6FGyonr7zV704ZzZCC0MEqG9GJBW7LJJczZ1lGvO9LCCwmKPZQy7wEnSyX/ifubeuikFjZSCzO/k=
Date: Fri, 15 Oct 2021 10:32:56 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Bertrand Marquis <bertrand.marquis@arm.com>
CC: <xen-devel@lists.xenproject.org>, <iwj@xenproject.org>, Rahul Singh
	<rahul.singh@arm.com>, Stefano Stabellini <sstabellini@kernel.org>, Julien
 Grall <julien@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>, George Dunlap
	<george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>, Wei Liu
	<wl@xen.org>, Paul Durrant <paul@xen.org>
Subject: Re: [PATCH v6 2/3] xen/arm: Enable the existing x86 virtual PCI
 support for ARM.
Message-ID: <YWk8uP/YuSee1MfG@MacBook-Air-de-Roger.local>
References: <cover.1634221830.git.bertrand.marquis@arm.com>
 <396b08e2598cf0338e0c7f4ad3cd5cb66db89224.1634221830.git.bertrand.marquis@arm.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <396b08e2598cf0338e0c7f4ad3cd5cb66db89224.1634221830.git.bertrand.marquis@arm.com>
X-ClientProxiedBy: LO2P265CA0244.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:8a::16) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: e78f1775-cacb-4ab2-6581-08d98fb666a3
X-MS-TrafficTypeDiagnostic: DM6PR03MB3740:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <DM6PR03MB3740C9A0717A20160C7E5C6F8FB99@DM6PR03MB3740.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6790;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: ZrM6y3ceSzRsfmRcuS2/gpmYifUHn+ypYzLWczzfgp/oiUELfBhuOgYPzeFl9rYLXd+0gLNeOnRkPf+Og16OQoDAPAl42dAmj1WY0iFjFKQTlkC4r33bQtB1lsFaNzsM69k8oOxAlen6PxxjZV8lSdsVXnucJ2ZzkIQ9LiPWPpYHxRodR2E7dgOG0fY6LVtz8lj7qN0+5J0lvGzFe7Pa2tToaWtujj72ONxPBbdYbINdYLrUyJ50ufCyte254rxwgDyt9RjWJS7qBR0g+yHOBJFlj1LlPpxpQCbPlk1V9zZbWMn8D/Dv3ez+3MdW3LUCQ/s/JLOO9sOJZJEilVyKD+jc3BJ7JU1v+KGvUHn9s3AGOIK7kchIBT+clzjN6Fm9BTaraUlB3utSrmb/drJN5z+O7pNgCM1vHGAxK5I/TGAj9dfIMyx8DRz5H5rczRBVoJ21IdumXMZCJ/b5OowmFmafNdfbZ+xIx/G2W5V1rBlTnIcerl+Z/ftWXOTtTk5fXW9eG/hVs1qExtYs3jBBa4hVWfsUIaLkp5ldjmVZE6972qNuoHH3zwAb4Aw7JkdtA6tCvfBbwx79r1/c15IeghXlzerOSs9Hg6B8vuE8Rl3fTf+zCo3zZe3rmyOBr28yRMPPzwpY+/S3C4VVIb1qQMMP75fZ6Fir8MMgdHPjQ5mjuZwO6VKh9jMVC9I5yvFi3HcZ33ics8YjSuDCkF4E5A==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(5660300002)(2906002)(66556008)(956004)(66476007)(6666004)(26005)(6486002)(4326008)(9686003)(86362001)(8676002)(38100700002)(6916009)(6496006)(316002)(66946007)(85182001)(30864003)(508600001)(83380400001)(8936002)(54906003)(7416002)(186003)(82960400001)(2004002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?V0NMUnNadjYvZnlQWGdOMlZVMzJwVEowUU1rdUhDQjZzU3plWnEwMnY1ZGtH?=
 =?utf-8?B?d1dNU2lDYWMzSWo2eUJ3NTV6amV0NkcrSHIveVpSeTJtM1R3R1JFVng1MENK?=
 =?utf-8?B?VEVZQ2lEbXEzeUI1YXJnYkZCcjlZUENCWitaZzZxZlYrajZTUDdrR2tPekk0?=
 =?utf-8?B?bWtpM0tYT3EvM2RRV0JTUDhCUWlickRUTEVnaHM0WFNxVTlEN3YvWkpBNzZP?=
 =?utf-8?B?YlJwdnVjZmlKTWxIRWhhWmExOG4wNlJvVW11emppazFYY0Z2WDdXVnhiOFFp?=
 =?utf-8?B?Si83VENJNW5PZ0lKeEFYaVpuQ2FydkU5SFoxaXhCQmlqUGN3UlIzNit1UXUz?=
 =?utf-8?B?QnJ4bnhXWEZzK1ZIaTE4Z0NNWE15WHMraUVmSllidkp0WWNkU2VodTVLaTg4?=
 =?utf-8?B?QndBWXpqRGp0ZVJpRWY1OXNxbWoxZ1NWay9ObnczM3A1WEI1SlY4S1BoMmhM?=
 =?utf-8?B?ODc3LzJ3VUREdSs2Q1BWVTlkZFZkVThXVGV0a1VrblFmV0pTRlhxVklvOVE4?=
 =?utf-8?B?Yk05S01xaUo1V3JRS21iMmM4a09rdlE2QTJXdklab1d4MDNVZk1nc3BEL21G?=
 =?utf-8?B?d0RNN1pJMUVJaFIwcVhSU3lPMnNLd2JmT2M3MWpqTk42NWFzMmZ0b2habDZq?=
 =?utf-8?B?RUNQVG03SHBLV2JraTA0NGh6WEl0MXhDWWdINk1GWmg5R2xUelE2TTl5QXJi?=
 =?utf-8?B?N0hWeXNEMmZ5RVhGOCtCYWJnMUZ2S3lkVUVlb2pXa0d1WVo4NmE4Sm0xejRS?=
 =?utf-8?B?UnVMSkwyYmRkTFJQMnUzTmJneGlvY2lFYXVraE9kQ09IdElhMHpad3ZXUHpT?=
 =?utf-8?B?TFRTbnBnT3hKV3RpWkxMdktpeG5JV3pROFNlc25ZQlkrbXNLa3ZMZWRpR2NO?=
 =?utf-8?B?NkFwM0JOL2R6cWhqby9UQkE1VTlBWnovUzNwNXMvR284R2tLenFXWmxoampV?=
 =?utf-8?B?cEMwYUswNG53bHRwQnpZNVNWT28vaVUxMWJjSEUxWlBQbUdrYTlhTzYvWWJp?=
 =?utf-8?B?c2xVRytkcHAza1RsL0o0SllKUUtkRUpQQVZ3ZFZVZ0RYK1lXcnY3ZnoyTElv?=
 =?utf-8?B?WERWbi9OVk5kUDBlNWx6VDRhMDBTRzhiYisra1p6TDVsY0U0eUpzZ3Vva0Fx?=
 =?utf-8?B?ZWRKdjY2bkZSdlpnVUlaeVBya1ZKd2wxclZLSFhmTFNTTXlONjVUNGVUakJ4?=
 =?utf-8?B?dlBoa3lIZ25uanpXdWtpUyt0YkNTWFZsZXNKNXpSRkN3ZTVSWGVHd1REbnEr?=
 =?utf-8?B?Q1diSUIxWGgrNHpsTjJIaWlPOTFLL1IwWjZEWXNtSjNRUEFscG5ac3RIUjRu?=
 =?utf-8?B?RWdRb2ZqZUhwYnh0WkwwWTBRZlM0OTNzS1IrYmxvT3dxTlErMlh6QmQxZk9I?=
 =?utf-8?B?T2UyYmpVclB3cnJzZjlPVmxPd2RqSEU2Qk0vWnBjQmNzeHFZQmN1ZzdPN2Ni?=
 =?utf-8?B?SmlJWDU1WGF5Q0tDcHAwc3BXNnRyRE9TVUsrUmpGa205M1ErLzZrWVZiYndW?=
 =?utf-8?B?bDEzc1drK3lBcG5rL0Eyc1pjall1UWt1VGRybzZCQmptT0NPYU9HQTVTSHk1?=
 =?utf-8?B?SUpMYnc3MWs1NFNPcWVSRWVWMGtXdHNTdlp1cEJweHI4eUQyTW44TkdQMnZ1?=
 =?utf-8?B?dUZJREtXTnNVMmdDTzhMbkJBWmJ6YnM5Q3lSWVVUemFSbjN6YUZlRU9zN3Z0?=
 =?utf-8?B?VHpKaHJPeWNpZFVmV2hmMlVhWGVOY1ZuOUROMlR0YXVmT29sRTNpcEI2OVhp?=
 =?utf-8?Q?oprEGhGkV691kOmkfiht8yojCkgI58pj5WF/C8F?=
X-MS-Exchange-CrossTenant-Network-Message-Id: e78f1775-cacb-4ab2-6581-08d98fb666a3
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2021 08:33:01.9983
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: FMaj+6eCZayIb68zzRgItoEbmy4SOz1+09mjGiJFqSEnq2aD8DYvBCwVyUaPKyF3wesm5EbUIKzZMCgWHKR9oQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB3740
X-OriginatorOrg: citrix.com

On Thu, Oct 14, 2021 at 03:49:50PM +0100, Bertrand Marquis wrote:
> From: Rahul Singh <rahul.singh@arm.com>
> 
> The existing VPCI support available for X86 is adapted for Arm.
> When the device is added to XEN via the hyper call
> “PHYSDEVOP_pci_device_add”, VPCI handler for the config space
> access is added to the Xen to emulate the PCI devices config space.
> 
> A MMIO trap handler for the PCI ECAM space is registered in XEN
> so that when guest is trying to access the PCI config space,XEN
> will trap the access and emulate read/write using the VPCI and
> not the real PCI hardware.
> 
> For Dom0less systems scan_pci_devices() would be used to discover the
> PCI device in XEN and VPCI handler will be added during XEN boots.
> 
> This patch is also doing some small fixes to fix compilation errors on
> arm32 of vpci:
> - add a cast to unsigned long in print in header.c
> - add a cast to uint64_t in vpci_ecam_mmio_write
> 
> Signed-off-by: Rahul Singh <rahul.singh@arm.com>
> Signed-off-by: Bertrand Marquis <bertrand.marquis@arm.com>
> ---
> Changes in v6:
> - Use new vpci_ecam_ helpers for PCI access
> - Do not set XEN_DOMCTL_CDF_vpci for dom0 for now (will be done in a
> future patch once everything is ready)

Isn't the series missing a revert of XEN_DOMCTL_CDF_vpci? I think
that's what we agreed would be the way forward.

> - rename REGISTER_OFFSET to ECAM_REG_OFFSET and move it to pci.h
> - remove not needed local variables in vpci_mmio_write, the one in read
> has been kept to ensure proper compilation on arm32
> - move call to vpci_add_handlers before iommu init to simplify exit path
> - move call to pci_cleanup_msi in the out section of pci_add_device if
> pdev is not NULL and on error
> - initialize pdev to NULL to handle properly exit path call of
> pci_cleanup_msi
> - keep has_vpci to return false for now as CFG_vpci has been removed.
> Added a comment on top of the definition.
> - fix compilation errors on arm32 (print in header.c, cast missing in
> mmio_write.
> - local variable was kept in vpci_mmio_read on arm to prevent a cast
> error in arm32.
> Change in v5:
> - Add pci_cleanup_msi(pdev) incleanup part.
> - Added Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
> Change in v4:
> - Move addition of XEN_DOMCTL_CDF_vpci flag to separate patch
> Change in v3:
> - Use is_pci_passthrough_enabled() in place of pci_passthrough_enabled variable
> - Reject XEN_DOMCTL_CDF_vpci for x86 in arch_sanitise_domain_config()
> - Remove IS_ENABLED(CONFIG_HAS_VPCI) from has_vpci()
> Change in v2:
> - Add new XEN_DOMCTL_CDF_vpci flag
> - modify has_vpci() to include XEN_DOMCTL_CDF_vpci
> - enable vpci support when pci-passthough option is enabled.
> ---
> ---
>  xen/arch/arm/Makefile         |  1 +
>  xen/arch/arm/domain.c         |  4 ++
>  xen/arch/arm/vpci.c           | 74 +++++++++++++++++++++++++++++++++++
>  xen/arch/arm/vpci.h           | 36 +++++++++++++++++
>  xen/drivers/passthrough/pci.c | 18 ++++++++-
>  xen/drivers/vpci/header.c     |  3 +-
>  xen/drivers/vpci/vpci.c       |  2 +-
>  xen/include/asm-arm/domain.h  |  1 +
>  xen/include/asm-x86/pci.h     |  2 -
>  xen/include/public/arch-arm.h |  7 ++++
>  xen/include/xen/pci.h         |  3 ++
>  11 files changed, 146 insertions(+), 5 deletions(-)
>  create mode 100644 xen/arch/arm/vpci.c
>  create mode 100644 xen/arch/arm/vpci.h
> 
> diff --git a/xen/arch/arm/Makefile b/xen/arch/arm/Makefile
> index 64518848b2..07f634508e 100644
> --- a/xen/arch/arm/Makefile
> +++ b/xen/arch/arm/Makefile
> @@ -7,6 +7,7 @@ ifneq ($(CONFIG_NO_PLAT),y)
>  obj-y += platforms/
>  endif
>  obj-$(CONFIG_TEE) += tee/
> +obj-$(CONFIG_HAS_VPCI) += vpci.o
>  
>  obj-$(CONFIG_HAS_ALTERNATIVE) += alternative.o
>  obj-y += bootfdt.init.o
> diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
> index eef0661beb..96e1b23550 100644
> --- a/xen/arch/arm/domain.c
> +++ b/xen/arch/arm/domain.c
> @@ -39,6 +39,7 @@
>  #include <asm/vgic.h>
>  #include <asm/vtimer.h>
>  
> +#include "vpci.h"
>  #include "vuart.h"
>  
>  DEFINE_PER_CPU(struct vcpu *, curr_vcpu);
> @@ -773,6 +774,9 @@ int arch_domain_create(struct domain *d,
>      if ( is_hardware_domain(d) && (rc = domain_vuart_init(d)) )
>          goto fail;
>  
> +    if ( (rc = domain_vpci_init(d)) != 0 )
> +        goto fail;
> +
>      return 0;
>  
>  fail:
> diff --git a/xen/arch/arm/vpci.c b/xen/arch/arm/vpci.c
> new file mode 100644
> index 0000000000..7c3552b65d
> --- /dev/null
> +++ b/xen/arch/arm/vpci.c
> @@ -0,0 +1,74 @@
> +/*
> + * xen/arch/arm/vpci.c
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; either version 2 of the License, or
> + * (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + */
> +#include <xen/sched.h>
> +#include <xen/vpci.h>
> +
> +#include <asm/mmio.h>
> +
> +static int vpci_mmio_read(struct vcpu *v, mmio_info_t *info,
> +                          register_t *r, void *p)
> +{
> +    pci_sbdf_t sbdf;
> +    /* data is needed to prevent a pointer cast on 32bit */
> +    unsigned long data = ~0ul;
> +    int ret;
> +
> +    /* We ignore segment part and always handle segment 0 */
> +    sbdf.sbdf = ECAM_BDF(info->gpa);
> +
> +    ret = vpci_ecam_mmio_read(sbdf, ECAM_REG_OFFSET(info->gpa),
> +                              1U << info->dabt.size, &data);
> +
> +    *r = data;
> +
> +    return ret;
> +}
> +
> +static int vpci_mmio_write(struct vcpu *v, mmio_info_t *info,
> +                           register_t r, void *p)
> +{
> +    pci_sbdf_t sbdf;
> +
> +    /* We ignore segment part and always handle segment 0 */
> +    sbdf.sbdf = ECAM_BDF(info->gpa);
> +
> +    return vpci_ecam_mmio_write(sbdf, ECAM_REG_OFFSET(info->gpa),
> +                                1U << info->dabt.size, r);
> +}

I'm not sure returning an error value here is helpful, as I'm not sure
how native Arm behaves and how this error is propagated into the
guest. FWIWreturning ~0 or dropping writes is what we do in x86 when
vPCI is not capable of handling the access.

> +
> +static const struct mmio_handler_ops vpci_mmio_handler = {
> +    .read  = vpci_mmio_read,
> +    .write = vpci_mmio_write,
> +};
> +
> +int domain_vpci_init(struct domain *d)
> +{
> +    if ( !has_vpci(d) )
> +        return 0;
> +
> +    register_mmio_handler(d, &vpci_mmio_handler,
> +                          GUEST_VPCI_ECAM_BASE, GUEST_VPCI_ECAM_SIZE, NULL);
> +
> +    return 0;
> +}
> +
> +/*
> + * Local variables:
> + * mode: C
> + * c-file-style: "BSD"
> + * c-basic-offset: 4
> + * indent-tabs-mode: nil
> + * End:
> + */
> +
> diff --git a/xen/arch/arm/vpci.h b/xen/arch/arm/vpci.h
> new file mode 100644
> index 0000000000..d8a7b0e3e8
> --- /dev/null
> +++ b/xen/arch/arm/vpci.h
> @@ -0,0 +1,36 @@
> +/*
> + * xen/arch/arm/vpci.h
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; either version 2 of the License, or
> + * (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + */
> +
> +#ifndef __ARCH_ARM_VPCI_H__
> +#define __ARCH_ARM_VPCI_H__
> +
> +#ifdef CONFIG_HAS_VPCI
> +int domain_vpci_init(struct domain *d);
> +#else
> +static inline int domain_vpci_init(struct domain *d)
> +{
> +    return 0;
> +}
> +#endif
> +
> +#endif /* __ARCH_ARM_VPCI_H__ */
> +
> +/*
> + * Local variables:
> + * mode: C
> + * c-file-style: "BSD"
> + * c-basic-offset: 4
> + * indent-tabs-mode: nil
> + * End:
> + */
> diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci.c
> index 3aa8c3175f..8cc529ecec 100644
> --- a/xen/drivers/passthrough/pci.c
> +++ b/xen/drivers/passthrough/pci.c
> @@ -658,7 +658,7 @@ int pci_add_device(u16 seg, u8 bus, u8 devfn,
>                     const struct pci_dev_info *info, nodeid_t node)
>  {
>      struct pci_seg *pseg;
> -    struct pci_dev *pdev;
> +    struct pci_dev *pdev = NULL;
>      unsigned int slot = PCI_SLOT(devfn), func = PCI_FUNC(devfn);
>      const char *pdev_type;
>      int ret;
> @@ -752,6 +752,19 @@ int pci_add_device(u16 seg, u8 bus, u8 devfn,
>  
>      check_pdev(pdev);
>  
> +#ifdef CONFIG_ARM
> +    /*
> +     * On ARM PCI devices discovery will be done by Dom0. Add vpci handler when
> +     * Dom0 inform XEN to add the PCI devices in XEN.
> +     */
> +    ret = vpci_add_handlers(pdev);
> +    if ( ret )
> +    {
> +        printk(XENLOG_ERR "Setup of vPCI failed: %d\n", ret);
> +        goto out;
> +    }
> +#endif

I think vpci_add_handlers should be called after checking that
pdev->domain is != NULL, so I would move this chunk a bit below.

> +
>      ret = 0;
>      if ( !pdev->domain )
>      {
> @@ -784,6 +797,9 @@ out:
>                     &PCI_SBDF(seg, bus, slot, func));
>          }
>      }
> +    else if ( pdev )
> +        pci_cleanup_msi(pdev);

I'm slightly lost at why you add this chunk, is this strictly related
to the patch?

>      return ret;
>  }
>  
> diff --git a/xen/drivers/vpci/header.c b/xen/drivers/vpci/header.c
> index f8cd55e7c0..c5b025b88b 100644
> --- a/xen/drivers/vpci/header.c
> +++ b/xen/drivers/vpci/header.c
> @@ -374,7 +374,8 @@ static void bar_write(const struct pci_dev *pdev, unsigned int reg,
>          if ( val != (uint32_t)(bar->addr >> (hi ? 32 : 0)) )
>              gprintk(XENLOG_WARNING,
>                      "%pp: ignored BAR %lu write with memory decoding enabled\n",
> -                    &pdev->sbdf, bar - pdev->vpci->header.bars + hi);
> +                    &pdev->sbdf,
> +                    (unsigned long)(bar - pdev->vpci->header.bars + hi));
>          return;
>      }
>  
> diff --git a/xen/drivers/vpci/vpci.c b/xen/drivers/vpci/vpci.c
> index c0853176d7..2bd67fc27a 100644
> --- a/xen/drivers/vpci/vpci.c
> +++ b/xen/drivers/vpci/vpci.c
> @@ -507,7 +507,7 @@ int vpci_ecam_mmio_write(pci_sbdf_t sbdf, unsigned int reg, unsigned int len,
>  
>      vpci_write(sbdf, reg, min(4u, len), data);
>      if ( len == 8 )
> -        vpci_write(sbdf, reg + 4, 4, data >> 32);
> +        vpci_write(sbdf, reg + 4, 4, (uint64_t)data >> 32);
>  
>      return 1;
>  }
> diff --git a/xen/include/asm-arm/domain.h b/xen/include/asm-arm/domain.h
> index 14e575288f..9b3647587a 100644
> --- a/xen/include/asm-arm/domain.h
> +++ b/xen/include/asm-arm/domain.h
> @@ -263,6 +263,7 @@ static inline void arch_vcpu_block(struct vcpu *v) {}
>  
>  #define arch_vm_assist_valid_mask(d) (1UL << VMASST_TYPE_runstate_update_flag)
>  
> +/* vPCI is not available on Arm */
>  #define has_vpci(d)    ({ (void)(d); false; })
>  
>  #endif /* __ASM_DOMAIN_H__ */
> diff --git a/xen/include/asm-x86/pci.h b/xen/include/asm-x86/pci.h
> index a0df5c1279..443f25347d 100644
> --- a/xen/include/asm-x86/pci.h
> +++ b/xen/include/asm-x86/pci.h
> @@ -6,8 +6,6 @@
>  #define CF8_ADDR_HI(cf8) (  ((cf8) & 0x0f000000) >> 16)
>  #define CF8_ENABLED(cf8) (!!((cf8) & 0x80000000))
>  
> -#define ECAM_BDF(addr)   ( ((addr) & 0x0ffff000) >> 12)
> -
>  #define IS_SNB_GFX(id) (id == 0x01068086 || id == 0x01168086 \
>                          || id == 0x01268086 || id == 0x01028086 \
>                          || id == 0x01128086 || id == 0x01228086 \
> diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h
> index d46c61fca9..44be337dec 100644
> --- a/xen/include/public/arch-arm.h
> +++ b/xen/include/public/arch-arm.h
> @@ -418,6 +418,13 @@ typedef uint64_t xen_callback_t;
>  #define GUEST_GICV3_GICR0_BASE     xen_mk_ullong(0x03020000) /* vCPU0..127 */
>  #define GUEST_GICV3_GICR0_SIZE     xen_mk_ullong(0x01000000)
>  
> +/*
> + * 256 MB is reserved for VPCI configuration space based on calculation
> + * 256 buses × 32 devices × 8 functions × 4 KB = 256 MB
> + */
> +#define GUEST_VPCI_ECAM_BASE    xen_mk_ullong(0x10000000)
> +#define GUEST_VPCI_ECAM_SIZE    xen_mk_ullong(0x10000000)
> +
>  /* ACPI tables physical address */
>  #define GUEST_ACPI_BASE xen_mk_ullong(0x20000000)
>  #define GUEST_ACPI_SIZE xen_mk_ullong(0x02000000)
> diff --git a/xen/include/xen/pci.h b/xen/include/xen/pci.h
> index 70ac25345c..db18cb7639 100644
> --- a/xen/include/xen/pci.h
> +++ b/xen/include/xen/pci.h
> @@ -40,6 +40,9 @@
>  #define PCI_SBDF3(s,b,df) \
>      ((pci_sbdf_t){ .sbdf = (((s) & 0xffff) << 16) | PCI_BDF2(b, df) })
>  
> +#define ECAM_BDF(addr)         ( ((addr) & 0x0ffff000) >> 12)
                                   ^ extra space?

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Fri Oct 15 08:43:00 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 08:43:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.209941.366529 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbInm-0000bu-Of; Fri, 15 Oct 2021 08:42:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 209941.366529; Fri, 15 Oct 2021 08:42:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbInm-0000bn-LN; Fri, 15 Oct 2021 08:42:54 +0000
Received: by outflank-mailman (input) for mailman id 209941;
 Fri, 15 Oct 2021 08:42:53 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=KdBF=PD=arm.com=michal.orzel@srs-us1.protection.inumbo.net>)
 id 1mbInl-0000bh-DL
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 08:42:53 +0000
Received: from foss.arm.com (unknown [217.140.110.172])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTP
 id b2511a81-4e8e-4366-bb5c-3d5f0362dca2;
 Fri, 15 Oct 2021 08:42:50 +0000 (UTC)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 909C12F;
 Fri, 15 Oct 2021 01:42:50 -0700 (PDT)
Received: from [10.57.25.205] (unknown [10.57.25.205])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 6CE963F694;
 Fri, 15 Oct 2021 01:42:47 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b2511a81-4e8e-4366-bb5c-3d5f0362dca2
Subject: Re: [PATCH v6 2/3] xen/arm: Enable the existing x86 virtual PCI
 support for ARM.
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>
Cc: xen-devel@lists.xenproject.org, iwj@xenproject.org,
 Rahul Singh <rahul.singh@arm.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Wei Liu <wl@xen.org>, Paul Durrant <paul@xen.org>
References: <cover.1634221830.git.bertrand.marquis@arm.com>
 <396b08e2598cf0338e0c7f4ad3cd5cb66db89224.1634221830.git.bertrand.marquis@arm.com>
 <YWk8uP/YuSee1MfG@MacBook-Air-de-Roger.local>
From: Michal Orzel <michal.orzel@arm.com>
Message-ID: <5b0d2a54-14a6-afd8-1a7e-0359cadab4f1@arm.com>
Date: Fri, 15 Oct 2021 10:42:37 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <YWk8uP/YuSee1MfG@MacBook-Air-de-Roger.local>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit



On 15.10.2021 10:32, Roger Pau Monné wrote:
> On Thu, Oct 14, 2021 at 03:49:50PM +0100, Bertrand Marquis wrote:
>> From: Rahul Singh <rahul.singh@arm.com>
>>
>> The existing VPCI support available for X86 is adapted for Arm.
>> When the device is added to XEN via the hyper call
>> “PHYSDEVOP_pci_device_add”, VPCI handler for the config space
>> access is added to the Xen to emulate the PCI devices config space.
>>
>> A MMIO trap handler for the PCI ECAM space is registered in XEN
>> so that when guest is trying to access the PCI config space,XEN
>> will trap the access and emulate read/write using the VPCI and
>> not the real PCI hardware.
>>
>> For Dom0less systems scan_pci_devices() would be used to discover the
>> PCI device in XEN and VPCI handler will be added during XEN boots.
>>
>> This patch is also doing some small fixes to fix compilation errors on
>> arm32 of vpci:
>> - add a cast to unsigned long in print in header.c
>> - add a cast to uint64_t in vpci_ecam_mmio_write
>>
>> Signed-off-by: Rahul Singh <rahul.singh@arm.com>
>> Signed-off-by: Bertrand Marquis <bertrand.marquis@arm.com>
>> ---
>> Changes in v6:
>> - Use new vpci_ecam_ helpers for PCI access
>> - Do not set XEN_DOMCTL_CDF_vpci for dom0 for now (will be done in a
>> future patch once everything is ready)
> 
> Isn't the series missing a revert of XEN_DOMCTL_CDF_vpci? I think
> that's what we agreed would be the way forward.
> 
The revert patch has already been merged.
https://xenbits.xen.org/gitweb/?p=xen.git;a=commit;h=9516d01ac3015f522528ed6dafb3f584eaa7ed2c
>> - rename REGISTER_OFFSET to ECAM_REG_OFFSET and move it to pci.h
>> - remove not needed local variables in vpci_mmio_write, the one in read
>> has been kept to ensure proper compilation on arm32
>> - move call to vpci_add_handlers before iommu init to simplify exit path
>> - move call to pci_cleanup_msi in the out section of pci_add_device if
>> pdev is not NULL and on error
>> - initialize pdev to NULL to handle properly exit path call of
>> pci_cleanup_msi
>> - keep has_vpci to return false for now as CFG_vpci has been removed.
>> Added a comment on top of the definition.
>> - fix compilation errors on arm32 (print in header.c, cast missing in
>> mmio_write.
>> - local variable was kept in vpci_mmio_read on arm to prevent a cast
>> error in arm32.
>> Change in v5:
>> - Add pci_cleanup_msi(pdev) incleanup part.
>> - Added Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
>> Change in v4:
>> - Move addition of XEN_DOMCTL_CDF_vpci flag to separate patch
>> Change in v3:
>> - Use is_pci_passthrough_enabled() in place of pci_passthrough_enabled variable
>> - Reject XEN_DOMCTL_CDF_vpci for x86 in arch_sanitise_domain_config()
>> - Remove IS_ENABLED(CONFIG_HAS_VPCI) from has_vpci()
>> Change in v2:
>> - Add new XEN_DOMCTL_CDF_vpci flag
>> - modify has_vpci() to include XEN_DOMCTL_CDF_vpci
>> - enable vpci support when pci-passthough option is enabled.
>> ---
>> ---
>>  xen/arch/arm/Makefile         |  1 +
>>  xen/arch/arm/domain.c         |  4 ++
>>  xen/arch/arm/vpci.c           | 74 +++++++++++++++++++++++++++++++++++
>>  xen/arch/arm/vpci.h           | 36 +++++++++++++++++
>>  xen/drivers/passthrough/pci.c | 18 ++++++++-
>>  xen/drivers/vpci/header.c     |  3 +-
>>  xen/drivers/vpci/vpci.c       |  2 +-
>>  xen/include/asm-arm/domain.h  |  1 +
>>  xen/include/asm-x86/pci.h     |  2 -
>>  xen/include/public/arch-arm.h |  7 ++++
>>  xen/include/xen/pci.h         |  3 ++
>>  11 files changed, 146 insertions(+), 5 deletions(-)
>>  create mode 100644 xen/arch/arm/vpci.c
>>  create mode 100644 xen/arch/arm/vpci.h
>>
>> diff --git a/xen/arch/arm/Makefile b/xen/arch/arm/Makefile
>> index 64518848b2..07f634508e 100644
>> --- a/xen/arch/arm/Makefile
>> +++ b/xen/arch/arm/Makefile
>> @@ -7,6 +7,7 @@ ifneq ($(CONFIG_NO_PLAT),y)
>>  obj-y += platforms/
>>  endif
>>  obj-$(CONFIG_TEE) += tee/
>> +obj-$(CONFIG_HAS_VPCI) += vpci.o
>>  
>>  obj-$(CONFIG_HAS_ALTERNATIVE) += alternative.o
>>  obj-y += bootfdt.init.o
>> diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
>> index eef0661beb..96e1b23550 100644
>> --- a/xen/arch/arm/domain.c
>> +++ b/xen/arch/arm/domain.c
>> @@ -39,6 +39,7 @@
>>  #include <asm/vgic.h>
>>  #include <asm/vtimer.h>
>>  
>> +#include "vpci.h"
>>  #include "vuart.h"
>>  
>>  DEFINE_PER_CPU(struct vcpu *, curr_vcpu);
>> @@ -773,6 +774,9 @@ int arch_domain_create(struct domain *d,
>>      if ( is_hardware_domain(d) && (rc = domain_vuart_init(d)) )
>>          goto fail;
>>  
>> +    if ( (rc = domain_vpci_init(d)) != 0 )
>> +        goto fail;
>> +
>>      return 0;
>>  
>>  fail:
>> diff --git a/xen/arch/arm/vpci.c b/xen/arch/arm/vpci.c
>> new file mode 100644
>> index 0000000000..7c3552b65d
>> --- /dev/null
>> +++ b/xen/arch/arm/vpci.c
>> @@ -0,0 +1,74 @@
>> +/*
>> + * xen/arch/arm/vpci.c
>> + *
>> + * This program is free software; you can redistribute it and/or modify
>> + * it under the terms of the GNU General Public License as published by
>> + * the Free Software Foundation; either version 2 of the License, or
>> + * (at your option) any later version.
>> + *
>> + * This program is distributed in the hope that it will be useful,
>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>> + * GNU General Public License for more details.
>> + */
>> +#include <xen/sched.h>
>> +#include <xen/vpci.h>
>> +
>> +#include <asm/mmio.h>
>> +
>> +static int vpci_mmio_read(struct vcpu *v, mmio_info_t *info,
>> +                          register_t *r, void *p)
>> +{
>> +    pci_sbdf_t sbdf;
>> +    /* data is needed to prevent a pointer cast on 32bit */
>> +    unsigned long data = ~0ul;
>> +    int ret;
>> +
>> +    /* We ignore segment part and always handle segment 0 */
>> +    sbdf.sbdf = ECAM_BDF(info->gpa);
>> +
>> +    ret = vpci_ecam_mmio_read(sbdf, ECAM_REG_OFFSET(info->gpa),
>> +                              1U << info->dabt.size, &data);
>> +
>> +    *r = data;
>> +
>> +    return ret;
>> +}
>> +
>> +static int vpci_mmio_write(struct vcpu *v, mmio_info_t *info,
>> +                           register_t r, void *p)
>> +{
>> +    pci_sbdf_t sbdf;
>> +
>> +    /* We ignore segment part and always handle segment 0 */
>> +    sbdf.sbdf = ECAM_BDF(info->gpa);
>> +
>> +    return vpci_ecam_mmio_write(sbdf, ECAM_REG_OFFSET(info->gpa),
>> +                                1U << info->dabt.size, r);
>> +}
> 
> I'm not sure returning an error value here is helpful, as I'm not sure
> how native Arm behaves and how this error is propagated into the
> guest. FWIWreturning ~0 or dropping writes is what we do in x86 when
> vPCI is not capable of handling the access.
> 
>> +
>> +static const struct mmio_handler_ops vpci_mmio_handler = {
>> +    .read  = vpci_mmio_read,
>> +    .write = vpci_mmio_write,
>> +};
>> +
>> +int domain_vpci_init(struct domain *d)
>> +{
>> +    if ( !has_vpci(d) )
>> +        return 0;
>> +
>> +    register_mmio_handler(d, &vpci_mmio_handler,
>> +                          GUEST_VPCI_ECAM_BASE, GUEST_VPCI_ECAM_SIZE, NULL);
>> +
>> +    return 0;
>> +}
>> +
>> +/*
>> + * Local variables:
>> + * mode: C
>> + * c-file-style: "BSD"
>> + * c-basic-offset: 4
>> + * indent-tabs-mode: nil
>> + * End:
>> + */
>> +
>> diff --git a/xen/arch/arm/vpci.h b/xen/arch/arm/vpci.h
>> new file mode 100644
>> index 0000000000..d8a7b0e3e8
>> --- /dev/null
>> +++ b/xen/arch/arm/vpci.h
>> @@ -0,0 +1,36 @@
>> +/*
>> + * xen/arch/arm/vpci.h
>> + *
>> + * This program is free software; you can redistribute it and/or modify
>> + * it under the terms of the GNU General Public License as published by
>> + * the Free Software Foundation; either version 2 of the License, or
>> + * (at your option) any later version.
>> + *
>> + * This program is distributed in the hope that it will be useful,
>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>> + * GNU General Public License for more details.
>> + */
>> +
>> +#ifndef __ARCH_ARM_VPCI_H__
>> +#define __ARCH_ARM_VPCI_H__
>> +
>> +#ifdef CONFIG_HAS_VPCI
>> +int domain_vpci_init(struct domain *d);
>> +#else
>> +static inline int domain_vpci_init(struct domain *d)
>> +{
>> +    return 0;
>> +}
>> +#endif
>> +
>> +#endif /* __ARCH_ARM_VPCI_H__ */
>> +
>> +/*
>> + * Local variables:
>> + * mode: C
>> + * c-file-style: "BSD"
>> + * c-basic-offset: 4
>> + * indent-tabs-mode: nil
>> + * End:
>> + */
>> diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci.c
>> index 3aa8c3175f..8cc529ecec 100644
>> --- a/xen/drivers/passthrough/pci.c
>> +++ b/xen/drivers/passthrough/pci.c
>> @@ -658,7 +658,7 @@ int pci_add_device(u16 seg, u8 bus, u8 devfn,
>>                     const struct pci_dev_info *info, nodeid_t node)
>>  {
>>      struct pci_seg *pseg;
>> -    struct pci_dev *pdev;
>> +    struct pci_dev *pdev = NULL;
>>      unsigned int slot = PCI_SLOT(devfn), func = PCI_FUNC(devfn);
>>      const char *pdev_type;
>>      int ret;
>> @@ -752,6 +752,19 @@ int pci_add_device(u16 seg, u8 bus, u8 devfn,
>>  
>>      check_pdev(pdev);
>>  
>> +#ifdef CONFIG_ARM
>> +    /*
>> +     * On ARM PCI devices discovery will be done by Dom0. Add vpci handler when
>> +     * Dom0 inform XEN to add the PCI devices in XEN.
>> +     */
>> +    ret = vpci_add_handlers(pdev);
>> +    if ( ret )
>> +    {
>> +        printk(XENLOG_ERR "Setup of vPCI failed: %d\n", ret);
>> +        goto out;
>> +    }
>> +#endif
> 
> I think vpci_add_handlers should be called after checking that
> pdev->domain is != NULL, so I would move this chunk a bit below.
> 
>> +
>>      ret = 0;
>>      if ( !pdev->domain )
>>      {
>> @@ -784,6 +797,9 @@ out:
>>                     &PCI_SBDF(seg, bus, slot, func));
>>          }
>>      }
>> +    else if ( pdev )
>> +        pci_cleanup_msi(pdev);
> 
> I'm slightly lost at why you add this chunk, is this strictly related
> to the patch?
> 
>>      return ret;
>>  }
>>  
>> diff --git a/xen/drivers/vpci/header.c b/xen/drivers/vpci/header.c
>> index f8cd55e7c0..c5b025b88b 100644
>> --- a/xen/drivers/vpci/header.c
>> +++ b/xen/drivers/vpci/header.c
>> @@ -374,7 +374,8 @@ static void bar_write(const struct pci_dev *pdev, unsigned int reg,
>>          if ( val != (uint32_t)(bar->addr >> (hi ? 32 : 0)) )
>>              gprintk(XENLOG_WARNING,
>>                      "%pp: ignored BAR %lu write with memory decoding enabled\n",
>> -                    &pdev->sbdf, bar - pdev->vpci->header.bars + hi);
>> +                    &pdev->sbdf,
>> +                    (unsigned long)(bar - pdev->vpci->header.bars + hi));
>>          return;
>>      }
>>  
>> diff --git a/xen/drivers/vpci/vpci.c b/xen/drivers/vpci/vpci.c
>> index c0853176d7..2bd67fc27a 100644
>> --- a/xen/drivers/vpci/vpci.c
>> +++ b/xen/drivers/vpci/vpci.c
>> @@ -507,7 +507,7 @@ int vpci_ecam_mmio_write(pci_sbdf_t sbdf, unsigned int reg, unsigned int len,
>>  
>>      vpci_write(sbdf, reg, min(4u, len), data);
>>      if ( len == 8 )
>> -        vpci_write(sbdf, reg + 4, 4, data >> 32);
>> +        vpci_write(sbdf, reg + 4, 4, (uint64_t)data >> 32);
>>  
>>      return 1;
>>  }
>> diff --git a/xen/include/asm-arm/domain.h b/xen/include/asm-arm/domain.h
>> index 14e575288f..9b3647587a 100644
>> --- a/xen/include/asm-arm/domain.h
>> +++ b/xen/include/asm-arm/domain.h
>> @@ -263,6 +263,7 @@ static inline void arch_vcpu_block(struct vcpu *v) {}
>>  
>>  #define arch_vm_assist_valid_mask(d) (1UL << VMASST_TYPE_runstate_update_flag)
>>  
>> +/* vPCI is not available on Arm */
>>  #define has_vpci(d)    ({ (void)(d); false; })
>>  
>>  #endif /* __ASM_DOMAIN_H__ */
>> diff --git a/xen/include/asm-x86/pci.h b/xen/include/asm-x86/pci.h
>> index a0df5c1279..443f25347d 100644
>> --- a/xen/include/asm-x86/pci.h
>> +++ b/xen/include/asm-x86/pci.h
>> @@ -6,8 +6,6 @@
>>  #define CF8_ADDR_HI(cf8) (  ((cf8) & 0x0f000000) >> 16)
>>  #define CF8_ENABLED(cf8) (!!((cf8) & 0x80000000))
>>  
>> -#define ECAM_BDF(addr)   ( ((addr) & 0x0ffff000) >> 12)
>> -
>>  #define IS_SNB_GFX(id) (id == 0x01068086 || id == 0x01168086 \
>>                          || id == 0x01268086 || id == 0x01028086 \
>>                          || id == 0x01128086 || id == 0x01228086 \
>> diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h
>> index d46c61fca9..44be337dec 100644
>> --- a/xen/include/public/arch-arm.h
>> +++ b/xen/include/public/arch-arm.h
>> @@ -418,6 +418,13 @@ typedef uint64_t xen_callback_t;
>>  #define GUEST_GICV3_GICR0_BASE     xen_mk_ullong(0x03020000) /* vCPU0..127 */
>>  #define GUEST_GICV3_GICR0_SIZE     xen_mk_ullong(0x01000000)
>>  
>> +/*
>> + * 256 MB is reserved for VPCI configuration space based on calculation
>> + * 256 buses × 32 devices × 8 functions × 4 KB = 256 MB
>> + */
>> +#define GUEST_VPCI_ECAM_BASE    xen_mk_ullong(0x10000000)
>> +#define GUEST_VPCI_ECAM_SIZE    xen_mk_ullong(0x10000000)
>> +
>>  /* ACPI tables physical address */
>>  #define GUEST_ACPI_BASE xen_mk_ullong(0x20000000)
>>  #define GUEST_ACPI_SIZE xen_mk_ullong(0x02000000)
>> diff --git a/xen/include/xen/pci.h b/xen/include/xen/pci.h
>> index 70ac25345c..db18cb7639 100644
>> --- a/xen/include/xen/pci.h
>> +++ b/xen/include/xen/pci.h
>> @@ -40,6 +40,9 @@
>>  #define PCI_SBDF3(s,b,df) \
>>      ((pci_sbdf_t){ .sbdf = (((s) & 0xffff) << 16) | PCI_BDF2(b, df) })
>>  
>> +#define ECAM_BDF(addr)         ( ((addr) & 0x0ffff000) >> 12)
>                                    ^ extra space?
> 
> Thanks, Roger.
> 


From xen-devel-bounces@lists.xenproject.org Fri Oct 15 08:46:51 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 08:46:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.209948.366540 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbIra-0001GA-9P; Fri, 15 Oct 2021 08:46:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 209948.366540; Fri, 15 Oct 2021 08:46:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbIra-0001G3-6B; Fri, 15 Oct 2021 08:46:50 +0000
Received: by outflank-mailman (input) for mailman id 209948;
 Fri, 15 Oct 2021 08:46:48 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=FGCa=PD=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mbIrY-0001Fx-CA
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 08:46:48 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id b87425e8-3b8f-49b9-a4ef-268676f54f84;
 Fri, 15 Oct 2021 08:46:47 +0000 (UTC)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2056.outbound.protection.outlook.com [104.47.14.56]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-22-f7BWRgjHO9ax80xbqc-NbA-1; Fri, 15 Oct 2021 10:46:45 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VE1PR04MB6478.eurprd04.prod.outlook.com (2603:10a6:803:12a::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15; Fri, 15 Oct
 2021 08:46:43 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.017; Fri, 15 Oct 2021
 08:46:43 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS9PR06CA0393.eurprd06.prod.outlook.com (2603:10a6:20b:461::34) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16 via Frontend
 Transport; Fri, 15 Oct 2021 08:46:42 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b87425e8-3b8f-49b9-a4ef-268676f54f84
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634287606;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=S9ZuMCTs+lIj/8Hj1q2CDClfVA0P5EBBRDSOqG+rdYA=;
	b=HRb1uE5lYdMnmSZp1LJOGEe0ZgxEunzTnQgl8BIFJnzqYdxMvAHGI9UhSsZ7zOklTMc6iw
	qq5hxgRXfHHiFqUKjiYkUQrcDkfZBoJgNxAH7fUJMwyxff+KFTpYm+5DO8jFiM8x2+Oblc
	tXxOhGwHq9B+h/afuMWBkm/JSwhKpJ0=
X-MC-Unique: f7BWRgjHO9ax80xbqc-NbA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=F5uTaTsAYj4L6OZDJaYRRc2If4cZ9W5AxmUetRjku1Z9eRafREkm/fM1F/WMe34dLtPKhKzTpXdahT6qHasP2Y2ceySBXsapEZN6dV3FcggbPdRg9NPGc/S/zlBDvjCjZEdKdRyO2r2pG29IfiT02CItx1QYl7EYu6gT4cY7OaZVGmY/JuD26DEvVgqz3mwpVSvfpiYq3EYKnmIhBEHOsZCuXeq+DHI09EnseAbt9waMGHxQ0I9yHolCzYtxX0yxLos8GF0E0l25hTvi4SzSRJhi9WGPscrFwveFapXNipls3fjV2fjdBSJkEggsl8CA4UFTmfjS4pE+H+t5kZVeXA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=PyvRoloTOWjWUXSGIpwSFTfMd1GNqAm6Q6HANk4lEc4=;
 b=fcaoEPRwbLC8Z4tZoDjxb4th2blAjZY29xt49QR6HYH/o42g/n+FEDidvh+LrLhRjKSUbfl6umKALhxavCub7EN1yKx3DLjhjK9pJvzw/ftxe2fSYikMRXRx1076WQScRikdi+Uuz0M8rFieyZwFvrYaTXglDwyBBOZaD4pcEFcWNyxqKh0J0Oi7rFgNVZOeT1ymrrjaf2Ac8ih8j6Pyf3y1E8Nm9PD+tRDt5dQRr6n5naOc+dxJ9lATTD4DeZYzwTqrAeiScgN7GN2Rwq3pJ6TqF2hRLpe/G+89npJod9/2hPGtPC2tikj61OW2syDcBmJOQmXgxLg56BwEqIpc4w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: xen.org; dkim=none (message not signed)
 header.d=none;xen.org; dmarc=none action=none header.from=suse.com;
Subject: Re: [PATCH v2 1/6] xen: introduce XEN_DOMCTL_CDF_directmap
To: Penny Zheng <penny.zheng@arm.com>
CC: Wei.Chen@arm.com, Bertrand.Marquis@arm.com,
 xen-devel@lists.xenproject.org, sstabellini@kernel.org, julien@xen.org
References: <20211015030945.2082898-1-penny.zheng@arm.com>
 <20211015030945.2082898-2-penny.zheng@arm.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <073d4b36-cb2f-88b2-76d2-3438d4ef589a@suse.com>
Date: Fri, 15 Oct 2021 10:46:41 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <20211015030945.2082898-2-penny.zheng@arm.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS9PR06CA0393.eurprd06.prod.outlook.com
 (2603:10a6:20b:461::34) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 122ac8a4-3cd9-4d81-99e2-08d98fb85064
X-MS-TrafficTypeDiagnostic: VE1PR04MB6478:
X-Microsoft-Antispam-PRVS:
	<VE1PR04MB64786804085C9876BE1D1A4DB3B99@VE1PR04MB6478.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:1265;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	NqA9BU8r1wNtoFuLBhyaXPwTgyk7ZPrwGr01hp+9uHqECEkvGHGo97T4TrI5ydM6SmNNeLPJ6quzPQpGp7OiLXTSFJtTsJEtHzAbiimHQSpEJ6KnGofWrTT4+U2birYQQTjBbxPQLv+3UQdLdzY8JuCfXEpzQYsEOzSpvfRGXUgk38bZTJ+IVPzqk/OuZrpoVN4yDNYx1MLuecS1qPPmwUYNvuFUKNKU3AsvbpGlGNHbhgsunSRj/LPOD6emWrfgCWvhA2xzrMD4JgmvVurm4xDK1fh/qWSaMT1n6fI7YB3uxBgdgo1qs5sNfHT5rzvXSZv54DUoH3H3nSbh8IbbqC/KV/SHM9fqxQTOM+W0nOAuukMj4jGVK2lWhVHPLLSEL6cwWes2VX9zzBcWrnXpUCFp2D+2EeuouOz1SN5E5HSgh89XUiIhAGlsDFJgIPdoZvUCbPs1hk4EhBgwCD+AwnisWxx1Abdls7HTplQ/87ounFb0eP662OVMGMY85RnSI/cEr39yli6jEPBnSVZvikJnP4CdIDMPckQr/RV2LfVwQFr8Fchitcx+b27wq27B/PKOtRtW7efhbcNnDDQS95AVEOeRa4Ta2U+CM64Bi3OeXwiDOmYYLRsYVQbt4zTend6K4sdkR4RtT3CaI5XH6kBvHMa7u7CX57rE6CrXwjefGBpP78AVq48zHZDKokl3RVpwmtDc8GLYQ1dAlF0k0NtTLHPKtwoXuETmabE08O+S02F7uCwLoW/BaumO0IiB
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(2616005)(66946007)(4326008)(38100700002)(66556008)(53546011)(6916009)(8676002)(66476007)(2906002)(36756003)(8936002)(316002)(86362001)(16576012)(508600001)(5660300002)(83380400001)(31696002)(956004)(186003)(31686004)(6486002)(26005)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?UaLRT/2EUAsX21M9pRI79BYVEJ6i/5AvGUJB+E6ne7v7wRE/gmWsB+EvfBIl?=
 =?us-ascii?Q?aWR3hsygmwX4A+UbapEFMBHkspHTBQ6KhWXua3ko6e3mrh0NpaO419pQpnf1?=
 =?us-ascii?Q?AFRkJsUKG0MhjaBocAckfMQ1/vd3sB6ZLGxuoGXO3uaWGabA/Ucy7CUhc2Ww?=
 =?us-ascii?Q?bflUPGLs36NIA4MLJun5INeJC4rkk7hAnrzpqzyMhPMKVQ2re9TavX8pQg4z?=
 =?us-ascii?Q?t54I3h7v37tKV4zXxPjr98z+e6BiI36FDpY5lzmArxFtBj41kV1ZfOhD3XLu?=
 =?us-ascii?Q?8TRU/m7zdQ2/WPiQI0A9KKHhvIsXAV3PnKgVS/EouoLfyhtD3kcIRf0QSMnX?=
 =?us-ascii?Q?pC/+yYN6MP9f7iozfD/z7oTMQvFD5MQYOwCmfmzSevODCMTJ823Mrqkpruue?=
 =?us-ascii?Q?9XLa9dx5w+iJfNfayFcLALpRk41gw863m3LkqtHx+LjIK7PRX+6/Ij1rVY/I?=
 =?us-ascii?Q?OTrlLwoCcWv7ReJS8dwuB/groH/tI6nUqBb3WsxAPagQ7OKKb89+U9SV3oG9?=
 =?us-ascii?Q?wD3B5M+aROUMhXGG2m0bvAzr2byg4gNOH5v1Z70Y5avUIvEI3zXSfukhdueQ?=
 =?us-ascii?Q?gE00iMbSMqUmOTuQY+L12BSYD2ob0wUGCcKakDgVG//woUJhPc77ZpjBtlwz?=
 =?us-ascii?Q?IiGBLb7bJjBZocQBJz+UN1vTH+mw6n9PQ8RpatEj9KRx+dBBfR+7chvOo+M+?=
 =?us-ascii?Q?62YVx6EB+GrKf0Tns4q8zEm1iWto7Ci2cO/ZguQEIdcSuuqvy2brt5762hao?=
 =?us-ascii?Q?iTfRFHTM2gMFRP9CtJjqQNZLQapHNg2gQwZByVfuNCidvvraJK+uIEALLjP/?=
 =?us-ascii?Q?x37XQvGEwX/JeDtEpj+MMHEUpLWTL8Hh5fQn9EmlGtGMW2Jx3K/vNoOVAzIF?=
 =?us-ascii?Q?qfq0JNoFtEz8KooxUDa1/CtJjZdMkj/Sm67rMOc23HaKKFjn1zQWd4grGGmd?=
 =?us-ascii?Q?aC6LPrDd6P5eMagNmuuNXX2bgO2ZePgzUpCj3NGlHGvdg+qdfnnf/1DOq63w?=
 =?us-ascii?Q?uwNaI8YrxXCJjoi6LJk8FiftnMlS06M+VQT7zzPWgYGoOxaUYCFLx1HHpfKv?=
 =?us-ascii?Q?d9tShB78BkFd0tqzQuc4NNT7YxIoMUIRKgChEX3QOSMxQlaULGkKt48EIzCK?=
 =?us-ascii?Q?Atoxz1w6IRLhLnbfH9iri9bqgh+zqe7j2SI5O+//SU5B2TN3XooTvUFVebSk?=
 =?us-ascii?Q?shg6KoxK105HubacG44rUnmzthv8Fso5khNFXChMEqJzYoJvUMrbsh098J+h?=
 =?us-ascii?Q?1UG2ErpyZ/GGyz5FZLUSqTlZ93ei6K/eoFqv5VTn+FKAp0Dg64G65hzRu6/f?=
 =?us-ascii?Q?fmMwRApVjPKwgWhz4LyZn7oX?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 122ac8a4-3cd9-4d81-99e2-08d98fb85064
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2021 08:46:43.6729
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: RQcorq6afrCIqg6/AJL+4XYy9QNS4PUwh7JzNe70b8h2pUfelMNPqqCUrqRdOBhVSjhFkabzu/Z+c6EryxL6fw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6478

On 15.10.2021 05:09, Penny Zheng wrote:
> From: Stefano Stabellini <stefano.stabellini@xilinx.com>
>=20
> This commit introduces a new arm-specific flag XEN_DOMCTL_CDF_directmap t=
o
> specify that this domain should have its memory directly mapped
> (guest physical address =3D=3D physical address) at domain creation.
>=20
> Refine is_domain_direct_mapped to check whether the flag
> XEN_DOMCTL_CDF_directmap is set.
>=20
> Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>
> Signed-off-by: Penny Zheng <penny.zheng@arm.com>
> ---
> CC: andrew.cooper3@citrix.com
> CC: jbeulich@suse.com
> CC: George Dunlap <George.Dunlap@eu.citrix.com>
> CC: Ian Jackson <ian.jackson@eu.citrix.com>
> CC: Wei Liu <wl@xen.org>
> CC: "Roger Pau Monn=C3=A9" <roger.pau@citrix.com>
> ---

Please have here a brief log of changes in the new version, to aid
reviewers.

>  xen/arch/arm/domain.c        | 3 ++-
>  xen/arch/arm/domain_build.c  | 4 +++-
>  xen/common/domain.c          | 3 ++-
>  xen/include/asm-arm/domain.h | 4 ++--
>  xen/include/public/domctl.h  | 4 +++-
>  5 files changed, 12 insertions(+), 6 deletions(-)

You clearly had to re-base over the XEN_DOMCTL_CDF_vpmu addition. I think
just like that change (which I'd expect you to have looked at while doing
the re-base) you also need to at least fiddle with OCaml's
domain_create_flag, to keep the ABI check there happy.

> --- a/xen/include/public/domctl.h
> +++ b/xen/include/public/domctl.h
> @@ -72,9 +72,11 @@ struct xen_domctl_createdomain {
>  #define XEN_DOMCTL_CDF_nested_virt    (1U << _XEN_DOMCTL_CDF_nested_virt=
)
>  /* Should we expose the vPMU to the guest? */
>  #define XEN_DOMCTL_CDF_vpmu           (1U << 7)
> +/* If this domain has its memory directly mapped? (ARM only) */
> +#define XEN_DOMCTL_CDF_directmap      (1U << 8)

The comment doesn't read well; how about "Should domain memory be directly
mapped?" That's if a comment here is really needed in the first place. I
also don't think "Arm only" should be here - this may go stale. What I'm
missing in this regard is rejecting of the flag in x86'es
arch_sanitise_domain_config() (or by whichever other means).

Jan



From xen-devel-bounces@lists.xenproject.org Fri Oct 15 08:52:13 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 08:52:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.209955.366551 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbIwj-0002dR-Tu; Fri, 15 Oct 2021 08:52:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 209955.366551; Fri, 15 Oct 2021 08:52:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbIwj-0002dK-Px; Fri, 15 Oct 2021 08:52:09 +0000
Received: by outflank-mailman (input) for mailman id 209955;
 Fri, 15 Oct 2021 08:52:08 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=esao=PD=suse.com=jgross@srs-us1.protection.inumbo.net>)
 id 1mbIwi-0002dE-Fc
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 08:52:08 +0000
Received: from smtp-out1.suse.de (unknown [195.135.220.28])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 50e0a34c-3e23-4785-a67c-136a6eb6a4f6;
 Fri, 15 Oct 2021 08:52:07 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 667042196B;
 Fri, 15 Oct 2021 08:52:06 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 3CC6413B87;
 Fri, 15 Oct 2021 08:52:06 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id BieTDTZBaWGEIAAAMHmgww
 (envelope-from <jgross@suse.com>); Fri, 15 Oct 2021 08:52:06 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 50e0a34c-3e23-4785-a67c-136a6eb6a4f6
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1634287926; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=IXAl2q6bJ/uf1ZF69wGwObp1dDnRLmcEatmkzy7CMLY=;
	b=BhSQb8kRLdd/dNc0xCsCtFvD3UwhStC7Kg1kmQDxUwPCPm/84cSbal6K7uFVz7lcQXClig
	sAQpEmFkKI/lIb7KOtmPV9gh9Dc2yOAa6iqpHRsYGfu3AlaOMMpoRawqRHX6mD7bKy/koU
	zqdp2rozH7GOrOjB0DS1mh3SM+J9B70=
To: Greg KH <greg@kroah.com>
Cc: linux-usb@vger.kernel.org, xen-devel@lists.xenproject.org,
 linux-kernel@vger.kernel.org, Boris Ostrovsky <boris.ostrovsky@oracle.com>,
 Stefano Stabellini <sstabellini@kernel.org>
References: <20211013075207.13910-1-jgross@suse.com>
 <20211013075207.13910-2-jgross@suse.com> <YWbKnEMvHGU/rv96@kroah.com>
 <54da6414-4183-2d0c-cc24-a9471ed8332b@suse.com> <YWk4T2HTAD3VJMYR@kroah.com>
From: Juergen Gross <jgross@suse.com>
Subject: Re: [PATCH v6 1/3] usb: Add Xen pvUSB protocol description
Message-ID: <e2245716-ea36-aa21-f0a0-aad9c3e37136@suse.com>
Date: Fri, 15 Oct 2021 10:52:05 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <YWk4T2HTAD3VJMYR@kroah.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="1Smack4gtX8AsrGGFe6fqZJRGo8fuJXPl"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--1Smack4gtX8AsrGGFe6fqZJRGo8fuJXPl
Content-Type: multipart/mixed; boundary="Nkwb4DjyLs57lOoHe5NTLeXy3J57x9HeL";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Greg KH <greg@kroah.com>
Cc: linux-usb@vger.kernel.org, xen-devel@lists.xenproject.org,
 linux-kernel@vger.kernel.org, Boris Ostrovsky <boris.ostrovsky@oracle.com>,
 Stefano Stabellini <sstabellini@kernel.org>
Message-ID: <e2245716-ea36-aa21-f0a0-aad9c3e37136@suse.com>
Subject: Re: [PATCH v6 1/3] usb: Add Xen pvUSB protocol description
References: <20211013075207.13910-1-jgross@suse.com>
 <20211013075207.13910-2-jgross@suse.com> <YWbKnEMvHGU/rv96@kroah.com>
 <54da6414-4183-2d0c-cc24-a9471ed8332b@suse.com> <YWk4T2HTAD3VJMYR@kroah.com>
In-Reply-To: <YWk4T2HTAD3VJMYR@kroah.com>

--Nkwb4DjyLs57lOoHe5NTLeXy3J57x9HeL
Content-Type: multipart/mixed;
 boundary="------------2F77AC7F69D1198DD8D382E0"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------2F77AC7F69D1198DD8D382E0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 15.10.21 10:14, Greg KH wrote:
> On Fri, Oct 15, 2021 at 10:07:35AM +0200, Juergen Gross wrote:
>> On 13.10.21 14:01, Greg KH wrote:
>>> On Wed, Oct 13, 2021 at 09:52:05AM +0200, Juergen Gross wrote:
>>>> Add the definition of pvUSB protocol used between the pvUSB frontend=
 in
>>>> a Xen domU and the pvUSB backend in a Xen driver domain (usually Dom=
0).
>>>>
>>>> This header was originally provided by Fujitsu for Xen based on Linu=
x
>>>> 2.6.18.
>>>>
>>>> Changes are:
>>>> - adapt to Linux kernel style guide
>>>> - use Xen namespace
>>>> - add lots of comments
>>>> - don't use kernel internal defines
>>>>
>>>> Signed-off-by: Juergen Gross <jgross@suse.com>
>>>> Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
>>>> ---
>>>>    include/xen/interface/io/usbif.h | 421 ++++++++++++++++++++++++++=
+++++
>>>>    1 file changed, 421 insertions(+)
>>>>    create mode 100644 include/xen/interface/io/usbif.h
>>>>
>>>> diff --git a/include/xen/interface/io/usbif.h b/include/xen/interfac=
e/io/usbif.h
>>>> new file mode 100644
>>>> index 000000000000..9494b1c9be99
>>>> --- /dev/null
>>>> +++ b/include/xen/interface/io/usbif.h
>>>> @@ -0,0 +1,421 @@
>>>> +/*
>>>> + * usbif.h
>>>> + *
>>>> + * USB I/O interface for Xen guest OSes.
>>>> + *
>>>> + * Copyright (C) 2009, FUJITSU LABORATORIES LTD.
>>>> + * Author: Noboru Iwamatsu <n_iwamatsu@jp.fujitsu.com>
>>>> + *
>>>> + * Permission is hereby granted, free of charge, to any person obta=
ining a copy
>>>> + * of this software and associated documentation files (the "Softwa=
re"), to
>>>> + * deal in the Software without restriction, including without limi=
tation the
>>>> + * rights to use, copy, modify, merge, publish, distribute, sublice=
nse, and/or
>>>> + * sell copies of the Software, and to permit persons to whom the S=
oftware is
>>>> + * furnished to do so, subject to the following conditions:
>>>> + *
>>>> + * The above copyright notice and this permission notice shall be i=
ncluded in
>>>> + * all copies or substantial portions of the Software.
>>>> + *
>>>> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, =
EXPRESS OR
>>>> + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANT=
ABILITY,
>>>> + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVEN=
T SHALL THE
>>>> + * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR=
 OTHER
>>>> + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, =
ARISING
>>>> + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OT=
HER
>>>> + * DEALINGS IN THE SOFTWARE.
>>>> + */
>>>
>>> Please use a SPDX line and not license "boilerplate" text like this :=
(
>>
>> Okay. Is this your only concern for this series? Or is it a blocking
>> point for you before looking into it in more detail?
>=20
> It was an easy thing to see at first glance that you hadn't taken my
> previous comment about this seriously :(

I'm sorry for that. This was clearly an oversight from me.

BTW, when checking which SPDX tag to use I discovered that most of the
Xen header files under include/xen/interface have been tagged as GPL-2.0
by a patch from you.

Said patch (commit b24413180f5600) stated that there was no license
information found in those files, but they all clearly had a verbatim
copy of the MIT license in them.

I'll send another patch fixing those SPDX tags.

>=20
>> IOW: does it make sense for me to wait for further comments before
>> sending a new version of the series?
>=20
> Sure, you can fix this up and resend, it will take a while to review th=
e
> host controller code...

I'm quite sure there will be at least some comments, so I'll wait with
resending until I've got more feedback.


Thanks,

Juergen

--------------2F77AC7F69D1198DD8D382E0
Content-Type: application/pgp-keys;
 name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Transfer-Encoding: quoted-printable
Content-Description: OpenPGP public key
Content-Disposition: attachment;
 filename="OpenPGP_0xB0DE9DD628BF132F.asc"

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy=
cWx
w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O=
f8Z
d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y=
9bf
IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq=
G7/
377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR=
3Jv
c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA=
QIe
AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT=
hpw
dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0=
MbD
1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv=
oPH
Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v=
5QL
+qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ=
2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC=
QoL
BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr=
Wf0
teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC=
/nu
AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh=
ITT
d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm=
XBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz=
80h
SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC=
AcD
AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn=
FOX
gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1=
jnD
kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0=
N51
N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l=
otu
fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1=
tqS
EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA=
hsD
BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3=
g3O
ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5=
dM7
wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5=
D+j
LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm=
V2x
AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N=
Eaw
QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW=
nHI
s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR=
wgn
BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV=
bVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk=
pEd
IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA=
QAB
wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw=
Tbe
8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1=
vJz
Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8=
VGi
wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW=
svi
uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX=
zXs
ZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------2F77AC7F69D1198DD8D382E0--

--Nkwb4DjyLs57lOoHe5NTLeXy3J57x9HeL--

--1Smack4gtX8AsrGGFe6fqZJRGo8fuJXPl
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmFpQTUFAwAAAAAACgkQsN6d1ii/Ey/1
ggf/VxJ1rByBYmOWYbIitQVuWqcyV6FZmx6M+INEKilSXTCiRmjsrGCYsBhByW8qU0os5foX4/qt
3geRP9u5d9+WPAT/o6katzOXmKg2VrUAEzksrvW/J6UAZvFQNSqVAPsRFvf7Qzoie2+29N274LNW
avH0VPRPUNB+0xFOAAR5JrNsF0FAWwVOhCeLmYScjNb1wkFF4Se9MENTK7f0HskvZeEsjpFnd5P2
bhcqZ+mXkHithna63ghGFEuxqwWfUJCCk84y3XqBOok5I3SKM5jGiwoM/HDOxr3rjOMr7TrjFhVY
/+gJMGBVRh+hdTFvxM3hDp5smO4uGbRcIJNIPrKj9g==
=mMim
-----END PGP SIGNATURE-----

--1Smack4gtX8AsrGGFe6fqZJRGo8fuJXPl--


From xen-devel-bounces@lists.xenproject.org Fri Oct 15 08:55:36 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 08:55:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.209966.366562 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbJ03-0003LS-Gc; Fri, 15 Oct 2021 08:55:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 209966.366562; Fri, 15 Oct 2021 08:55:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbJ03-0003LL-Dg; Fri, 15 Oct 2021 08:55:35 +0000
Received: by outflank-mailman (input) for mailman id 209966;
 Fri, 15 Oct 2021 08:55:34 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=FGCa=PD=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mbJ02-0003LF-Ib
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 08:55:34 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id f0b27c18-e83b-4a67-ac5d-31d813b304bd;
 Fri, 15 Oct 2021 08:55:33 +0000 (UTC)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2059.outbound.protection.outlook.com [104.47.13.59]) (Using
 TLS) by relay.mimecast.com with ESMTP id de-mta-3-zUtcuswLNzm6-lkADQC61A-1;
 Fri, 15 Oct 2021 10:55:31 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB6862.eurprd04.prod.outlook.com (2603:10a6:803:130::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16; Fri, 15 Oct
 2021 08:55:30 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.017; Fri, 15 Oct 2021
 08:55:29 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM5PR0201CA0020.eurprd02.prod.outlook.com (2603:10a6:203:3d::30) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16 via Frontend
 Transport; Fri, 15 Oct 2021 08:55:29 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f0b27c18-e83b-4a67-ac5d-31d813b304bd
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634288132;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=OFqnTrTr94B3V0C2IJQmLJjKf3K2fOFOezVpqOUqfac=;
	b=cgquxz/qGHsyGUj764yye0wLU5P+IuNV1ANhaI7JpW9+xQawqK66GmUMgpCNHPjKMfzRUw
	lrfh7psbOJsPpQbS5diuz/71XG8PJCzqpRGoH5x/N2r0CXXwA/SY+s/3KzZVQpHNUYV5Ok
	ArGpNfXC2XDPlSSRgx1Dr7I5hpui9l8=
X-MC-Unique: zUtcuswLNzm6-lkADQC61A-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=VCgY2W7nYPRMBEun16tLPOCPnW23VgsJ7FraADqDcV/KANQZKr6Nl7VX71r2tvWCn5A2wQEF8YOnxNce8KwETmUc+ByJvRxy1zCWqB/DsmjM6YZte1LM/+2threen/nnhsEvicsBkucHCp1715VbB4VTYiXGBiCN8G6ppCNjBhV1rAryw338JW/a1Azco2ih0+JbIw4QvRUNvB5jOOP0fivfDF0lR8WXvnW/s88XGNjQMFfzg7VY7O+eyiUFtPPmG91pQD6slHXFb6zxQW5slCDL6iEaoRRa6nJYbaLWAkJqZSs8dMjHk4S9yV34bV0g9xygUPQKAWiUsj7bZeBmCQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=fnMkFGoim2tKIuA4770PFfPAj5poJOwKX5JlA/NuywE=;
 b=OWAKleaoha9hjHBmeNDEAtPxneBusV6JK7hP0pPjxYcH+OV+ZBFaies5CZFQfKYSsyGOwlu4U7JAc//m7UYBvTL/k7AXR1EUFuYKY4Go5KwEOG55yVZ+BzpJEdgGlxS25Q0v8nQjlX1PzLuRn0Mw/lUqGpv2idU3pOUhzbcITjYvXRDaNpJe9+7F7PawgdyP3Cskh2m1QIlfnEh2Xy5BoUri9nQZJ8+RwoQI1tRnVMbjg1ztIyitQdMdOd7gViUQafphHlFt0X5hm34DFAb6dVAXif0FXuprT3dcsLnKgsADGPLzNh1qkVVnghkB0unb0lxLH54cDbrtSMsWicX7JA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [PATCH 0/2] x86/shadow: address two Coverity issues
To: Andrew Cooper <andrew.cooper3@citrix.com>
CC: Wei Liu <wl@xen.org>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>, Tim Deegan <tim@xen.org>,
 George Dunlap <george.dunlap@citrix.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <24329000-06d7-2047-b0a1-51b149d19189@suse.com>
 <ff9639f7-a853-7755-0d5b-5ccf21877cda@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <b22dc240-aa22-de03-e837-0ba82ca63312@suse.com>
Date: Fri, 15 Oct 2021 10:55:27 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <ff9639f7-a853-7755-0d5b-5ccf21877cda@citrix.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM5PR0201CA0020.eurprd02.prod.outlook.com
 (2603:10a6:203:3d::30) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: ca9e0b9b-c498-4c05-63ff-08d98fb98a16
X-MS-TrafficTypeDiagnostic: VI1PR04MB6862:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB6862242ED1BC4645D8C25BE8B3B99@VI1PR04MB6862.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	gKTja0RvbICXgEKtuikxTBi1KjeUJmEWFYQksF1CeB8XUgFLLAtsG14ZcZIOLxgky6S/qXiidq50H1eivpckeqqGRIhPuLFhdmFAIe4ApLtVJAPd5new27R0Pj9YJw144CE1Wo2Q8iofdV0UJ9jnAhVUt3pwU1P/TMlsbdgXd/aCPTOFGHnsio0T1M3NXSknruBbzyLxlVI8nDRo/pPKg1SvGb229Btpub7m/EFBRj8ZSmD7XH1b8OcFvap9xyP8ehlteCJXsc0OlGnGKUdhbhWQHJrDy1AT1iydnT6WzSzw3YazlhDgUxOXNh48RrBHWV4HWrNzsWuk/NGEQoI8MSaQq7kMJqEHYlMMZ3cYVYgHyPC5HpxnD8xTbvIruQ0m/x180Sa/LzhBcZhMT8B2GG3x8hQV/5ZW6RgVUNzjOIRIF9QGOqZ5VjGkZnMSGjcMPYxmeU8hfWyat4+eA6pGbeQxo5b9QPhNytqW53GHwaisfInhskkyo/AiXSokJBpiRwKhJN7rf+B3SP3zxpDkGTgpsx+435NF3PsvGmsRwyMGU5oZ8afM+BvNkdloDl9WwHiSBD1Br5iLY4EcXY45I4IHUWY9NwKXpvIZ4gqZI5i5WDl1q/5U2RUQuoTMBHjUcvkL6WRXP56OnmzEeV6VIqaKB6rhxcAvqWQT4hpRgFvlLLBrTPt9rrptcLtvvERMSxYhMZpmHA1JUa4aaOTmTG8pJuYuwlMSf8k9XMDYZG5TqyBryDmpIqDs8pPIrJjT
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(956004)(66946007)(66476007)(2616005)(8676002)(6916009)(66556008)(4326008)(31696002)(5660300002)(54906003)(36756003)(6486002)(16576012)(316002)(86362001)(31686004)(8936002)(2906002)(508600001)(53546011)(83380400001)(38100700002)(186003)(26005)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?27mAw6JVv61tdMDWNXg5J372iTzOoutmgnSs2r4S2kZWGsvKNItxLf/01YKg?=
 =?us-ascii?Q?SshaQQYNwWDWLNbiUxzYXMKDmklja1e510LOE0Cf/sAhdu4pUM1t1kgqyBtq?=
 =?us-ascii?Q?jF8RCC3+MLicFO78bY2WIY875f5+nSso6GN/do1hdJyxVA+850mMJFI1jyIR?=
 =?us-ascii?Q?rdFVJ3Z+vIbhkPd337Q+uXyoPGndW8iEiFxC9nURbbO8LFTFzyNBM00vdj9n?=
 =?us-ascii?Q?Hh2Llf0lX9nSVMpCKvCpes/ci4xTG5sxPbx4/CDcNh3XOY8HEWmi5g6dcqh0?=
 =?us-ascii?Q?1ty0DXqbIMYnZmYqgRXwkoYClb8UjuEDhm0z44Yq7QePsyZaGZI/4SMUXox0?=
 =?us-ascii?Q?ndp/ZHWwGLBwuNYnlK0+nOtHXeiPgXG5BZglmmqyxe4suC/YNd8C6/XOesRk?=
 =?us-ascii?Q?f6IIutvsQ7IBcYW2VgbVO8K9sAA5wgClRfJXcYILisnuI89rtBfumJ89gB5i?=
 =?us-ascii?Q?e7TMBbFhLJSU0YDv3mUKfqqNeLaT9DJ4giR+y6XQ8hzj23R6NtvOVemzb/4t?=
 =?us-ascii?Q?wvJK7QeJkf+Q/oa5bwQHb8UBsdVZmdUl0GisdskAlEy/BUbMPEWHbh7RuvJF?=
 =?us-ascii?Q?rcL5c4n3HZ3NuGaKd+GMFc24U0hS8kuiNZEwfn8j9rutBg61rp1YFfsJFg+P?=
 =?us-ascii?Q?HYLf+Z6gELszLqIQgBW824AMbVSL6sHxy2LjkuzIWMzC9Jtyz9bcliGtzRAz?=
 =?us-ascii?Q?ywox1dUhIau8KIMp56WIQ1lMuVCWkmFyd7ZoJoAc1vxpTKC3o5/9NTv8BE8e?=
 =?us-ascii?Q?YxnO+qtdmpflEwwzu018Vh9v1EsOm+iyYM4tyxa9qZVDCt6j6TeGPBbMVEwF?=
 =?us-ascii?Q?PCg20jYxzr7PpMu/EZs2+rf2R85BAQ3ZNffXexm46Lp5Dtgl3UO7EP0kKo89?=
 =?us-ascii?Q?Fox8uwsRcAizrLehkfmH00WMvpU3CBC+S9BVOk+BKrnVRb1O0k07IeRYRTCP?=
 =?us-ascii?Q?JQr2mdojDQkPhifpxSSJDhSCJ20YYChJp4Eu2lOYaYxiIKlfWi475zViRtCX?=
 =?us-ascii?Q?wwMmNvnqWLsCXLiqLivYrMv5zyIGpZZensiiZc8EdZYSBcPmY+O4p66WoTOd?=
 =?us-ascii?Q?IKdvntWMgpxUOKtQMEaU0hFXoIYICXs0XOd9QQv8/qpeqKGYsVKB6fhbC/Xk?=
 =?us-ascii?Q?9AS5FJWIi3yXGNEaWVu2I8BH2Odg5PQrhzAZX5J4VYbP07ii87Tk2G6pUsR2?=
 =?us-ascii?Q?jL1Fkuyct5cRkd69BKE8vtsztzVhXIyZFTLJQMgK4rmhZ6o7dYDhlp0mGG2M?=
 =?us-ascii?Q?AT8iSIZzWnIJBMcgf88AQ0R56Sgw73GfwDEAe9mQLdJ4QrMiU1dHCtNBJ4eo?=
 =?us-ascii?Q?PeanQNwYVJ5NR0ISx6syw63Q?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ca9e0b9b-c498-4c05-63ff-08d98fb98a16
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2021 08:55:29.9220
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 3tneImEJWYh4E3H1UIn0XGtkZic6JxCLoNPr+QkiMSMSDdU0WiT7CuTtfnty2bv8+Eo7SQxZW3nBpGi8z2XRQQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6862

On 13.10.2021 18:10, Andrew Cooper wrote:
> On 13/10/2021 16:36, Jan Beulich wrote:
>> It's not clear to me why the tool spotted them now and not before,
>=20
> Several reasons.
>=20
> The Coverity backend is a software product just like everything else.=C2=
=A0
> IIRC, it releases quarterly.
>=20
> "If something's free, then you are the product".=C2=A0 The value of offer=
ing
> free scanning of open source codebases comes from us (the free users)
> integrating a massive corpus of code into Coverity's system, upon which
> they can evaluate the effectiveness of new heuristics.
>=20
>=20
> Second, and far more likely in this case, "x86/mm: avoid building
> multiple .o from a single .c file".=C2=A0 Coverity has always choked on t=
hat
> in Xen, because it's intermediate database is keyed on source file with
> latest takes precedent, so we were only seeing the 4-level case previousl=
y.
>=20
>=20
> And to also answer your question from patch 1 here, there are upper time
> and complexity bounds on all analysis, because scanning is an
> exponential problem with the size of the source file.=C2=A0 I don't know
> exactly where the cutoffs are, and I fear that some of our larger files
> never have later functions looked at.

Thanks for the explanations. I have to admit that I would find it helpful
if the tool distinguished new issues it found just because code previously
wasn't scanned from ones that were truly introduced anew. For patch 1 here
this might mean that the report was previously put off when reported
against the 4-level case; I think it shouldn't have been ignored, but
opinions might diverge and hence there might be a reason why patch 1
isn't wanted then. Patch 2, otoh, doesn't have a 4-level equivalent so is
likely to be wanted. Unfortunately your reply didn't include an ack, nak,
or at least a vague indication towards either, so I don't really know what
(if anything) it means towards the actual patches.

Jan



From xen-devel-bounces@lists.xenproject.org Fri Oct 15 08:57:05 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 08:57:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.209973.366572 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbJ1S-0003w6-SL; Fri, 15 Oct 2021 08:57:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 209973.366572; Fri, 15 Oct 2021 08:57:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbJ1S-0003vz-Oq; Fri, 15 Oct 2021 08:57:02 +0000
Received: by outflank-mailman (input) for mailman id 209973;
 Fri, 15 Oct 2021 08:57:01 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mbJ1R-0003vr-SJ
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 08:57:01 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mbJ1R-0008AX-Nr; Fri, 15 Oct 2021 08:57:01 +0000
Received: from [54.239.6.185] (helo=[192.168.0.140])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mbJ1R-0002xo-I1; Fri, 15 Oct 2021 08:57:01 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=gECphvyWX0b1+h78PP+qAnI6f0/3xmOHqAK4Dv1Xi34=; b=X7RgAM0bDrEQO1WY2u1tK4z+5m
	D+OZ860ZkX3Eqj4uXZj0nuu1OTJY2bBUpD94z+dUu1TB/E72RKO0GzowWk7JifDy0GZe8ciIC61nc
	pjrmC9OM4NpuPVDU2kIKlkMA1uRtz54mZ8JG0LVn4SLt7WUm3WkPIXRolCqjdKjkItk0=;
Message-ID: <0eba23e2-54f4-0fe4-d811-c2fb8a0602b0@xen.org>
Date: Fri, 15 Oct 2021 09:56:59 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.2.0
Subject: Re: [PATCH v2 1/6] xen: introduce XEN_DOMCTL_CDF_directmap
To: Penny Zheng <penny.zheng@arm.com>, xen-devel@lists.xenproject.org,
 sstabellini@kernel.org
Cc: Wei.Chen@arm.com, Bertrand.Marquis@arm.com
References: <20211015030945.2082898-1-penny.zheng@arm.com>
 <20211015030945.2082898-2-penny.zheng@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20211015030945.2082898-2-penny.zheng@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Penny,

On 15/10/2021 04:09, Penny Zheng wrote:
> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
> index 0167731ab0..37e2d62d47 100644
> --- a/xen/arch/arm/domain_build.c
> +++ b/xen/arch/arm/domain_build.c
> @@ -3069,8 +3069,10 @@ static int __init construct_dom0(struct domain *d)
>   void __init create_dom0(void)
>   {
>       struct domain *dom0;
> +    /* DOM0 has always its memory directly mapped. */
>       struct xen_domctl_createdomain dom0_cfg = {
> -        .flags = XEN_DOMCTL_CDF_hvm | XEN_DOMCTL_CDF_hap,
> +        .flags = XEN_DOMCTL_CDF_hvm | XEN_DOMCTL_CDF_hap |
> +                 XEN_DOMCTL_CDF_directmap,
>           .max_evtchn_port = -1,
>           .max_grant_frames = gnttab_dom0_frames(),
>           .max_maptrack_frames = -1,
> diff --git a/xen/common/domain.c b/xen/common/domain.c
> index 8b53c49d1e..7a6131db74 100644
> --- a/xen/common/domain.c
> +++ b/xen/common/domain.c
> @@ -486,7 +486,8 @@ static int sanitise_domain_config(struct xen_domctl_createdomain *config)
>            ~(XEN_DOMCTL_CDF_hvm | XEN_DOMCTL_CDF_hap |
>              XEN_DOMCTL_CDF_s3_integrity | XEN_DOMCTL_CDF_oos_off |
>              XEN_DOMCTL_CDF_xs_domain | XEN_DOMCTL_CDF_iommu |
> -           XEN_DOMCTL_CDF_nested_virt | XEN_DOMCTL_CDF_vpmu) )
> +           XEN_DOMCTL_CDF_nested_virt | XEN_DOMCTL_CDF_vpmu |
> +           XEN_DOMCTL_CDF_directmap) )
>       {
>           dprintk(XENLOG_INFO, "Unknown CDF flags %#x\n", config->flags);
>           return -EINVAL;
> diff --git a/xen/include/asm-arm/domain.h b/xen/include/asm-arm/domain.h
> index 14e575288f..fc42c6a310 100644
> --- a/xen/include/asm-arm/domain.h
> +++ b/xen/include/asm-arm/domain.h
> @@ -29,8 +29,8 @@ enum domain_type {
>   #define is_64bit_domain(d) (0)
>   #endif
>   
> -/* The hardware domain has always its memory direct mapped. */
> -#define is_domain_direct_mapped(d) is_hardware_domain(d)
> +/* Check if domain is direct-map memory map. */
> +#define is_domain_direct_mapped(d) (d->options & XEN_DOMCTL_CDF_directmap)
>   
>   struct vtimer {
>       struct vcpu *v;
> diff --git a/xen/include/public/domctl.h b/xen/include/public/domctl.h
> index 238384b5ae..b505a0db51 100644
> --- a/xen/include/public/domctl.h
> +++ b/xen/include/public/domctl.h
> @@ -72,9 +72,11 @@ struct xen_domctl_createdomain {
>   #define XEN_DOMCTL_CDF_nested_virt    (1U << _XEN_DOMCTL_CDF_nested_virt)
>   /* Should we expose the vPMU to the guest? */
>   #define XEN_DOMCTL_CDF_vpmu           (1U << 7)
> +/* If this domain has its memory directly mapped? (ARM only) */
> +#define XEN_DOMCTL_CDF_directmap      (1U << 8)
>   
>   /* Max XEN_DOMCTL_CDF_* constant.  Used for ABI checking. */
> -#define XEN_DOMCTL_CDF_MAX XEN_DOMCTL_CDF_vpmu
> +#define XEN_DOMCTL_CDF_MAX XEN_DOMCTL_CDF_directmap

In the previous version, this flag was only settable for domain created 
by Xen. Now this is also settable by the toolstack. I don't think the 
toolstack can sensibly use this flag (at least in the current state).

So can you explain why this flag is exposed to the toolstack?

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Oct 15 09:01:56 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 09:01:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.209980.366583 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbJ68-0005MV-FG; Fri, 15 Oct 2021 09:01:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 209980.366583; Fri, 15 Oct 2021 09:01:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbJ68-0005MO-CN; Fri, 15 Oct 2021 09:01:52 +0000
Received: by outflank-mailman (input) for mailman id 209980;
 Fri, 15 Oct 2021 09:01:51 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mbJ67-0005MI-Fv
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 09:01:51 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mbJ66-0008Hs-Ft; Fri, 15 Oct 2021 09:01:50 +0000
Received: from [54.239.6.185] (helo=[192.168.0.140])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mbJ66-0003et-51; Fri, 15 Oct 2021 09:01:50 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=z82C8+p6wH+cgCBmok3OzvBn3VVk/jtgwPysru9FCNc=; b=tECVEH6Y2RUMTJYsYRK5DjGKRQ
	oD7m+f2aExXR/8mQleqLB7DEdsQYFaLQIPiWL1PMCZf1/ISwuuJ7GEK56iSGKrHtfttx6HbPq2Apc
	1g8OyrXnGsHY9uy9/pSCWa0QdMRfyFJvYuWEuI/2vzqjl6ken7ChCyEiM3U098UN2naQ=;
Message-ID: <4e29e233-3741-1f2e-52b6-a56f2a6aa3b8@xen.org>
Date: Fri, 15 Oct 2021 10:01:47 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.2.0
Subject: Re: [PATCH v6 3/3] arm/libxl: Emulated PCI device tree node in libxl
 [and 1 more messages]
To: Michal Orzel <michal.orzel@arm.com>, Ian Jackson <iwj@xenproject.org>,
 Bertrand Marquis <Bertrand.Marquis@arm.com>
Cc: xen-devel@lists.xenproject.org, Rahul Singh <rahul.singh@arm.com>,
 Wei Liu <wl@xen.org>, Anthony PERARD <anthony.perard@citrix.com>,
 Juergen Gross <jgross@suse.com>, Stefano Stabellini
 <sstabellini@kernel.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andre Przywara <Andre.Przywara@arm.com>
References: <cover.1633540842.git.rahul.singh@arm.com>
 <b81b5dea800c8fe47071f3dbd20588b1e472fb99.1633540842.git.rahul.singh@arm.com>
 <7bdac405-a889-15e1-be19-5876f7253855@xen.org>
 <24926.53690.621007.507249@mariner.uk.xensource.com>
 <294BE20A-7E45-405C-BC19-C292295E85E3@arm.com>
 <24927.7235.736221.270358@mariner.uk.xensource.com>
 <8A04B9B2-E816-425E-BF1B-5A8B89F8836C@arm.com>
 <cover.1634221830.git.bertrand.marquis@arm.com>
 <fd9c54a381daa52436b0a1b27cf1bba8e7ff9af9.1634221830.git.bertrand.marquis@arm.com>
 <24936.28385.679884.535704@mariner.uk.xensource.com>
 <6f82141c-8a0b-1e30-a996-223f7c0c508d@xen.org>
 <623814d1-a40d-df93-34f4-c1dd3eef60f6@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <623814d1-a40d-df93-34f4-c1dd3eef60f6@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Michal,

On 15/10/2021 08:41, Michal Orzel wrote:
> Do you agree on the following approach:
> 1. Modify argument of libxl__arch_domain_init_hw_description to libxl_domain_config (patch 1)
> 2. Modify argument of libxl__prepare_dtb to libxl_domain_config (patch 2)
> 3. Remove arch_arm.vpci completely and in libxl__prepare_dtb add a check (patch 3):
> if (d_config->num_pcidevs)
>      FDT( make_vpci_node(gc, fdt, ainfo, dom) );
> + make_vpci_node implementation
> 
> Does it sound ok for you?

This sounds ok to me.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Oct 15 09:20:20 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 09:20:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.210005.366659 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbJNu-0008NM-OY; Fri, 15 Oct 2021 09:20:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 210005.366659; Fri, 15 Oct 2021 09:20:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbJNu-0008NF-KD; Fri, 15 Oct 2021 09:20:14 +0000
Received: by outflank-mailman (input) for mailman id 210005;
 Fri, 15 Oct 2021 09:20:13 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=doKy=PD=citrix.com=Andrew.Cooper3@srs-us1.protection.inumbo.net>)
 id 1mbJNt-0008N9-Ol
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 09:20:13 +0000
Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 1940f790-2d99-11ec-8229-12813bfff9fa;
 Fri, 15 Oct 2021 09:20:12 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1940f790-2d99-11ec-8229-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1634289612;
  h=subject:to:cc:references:from:message-id:date:
   in-reply-to:content-transfer-encoding:mime-version;
  bh=8k7tCjyo4Qq2kUKLUP653B/CUYHYrYdovKTWpM/QmDs=;
  b=WsNARm6j66zz6zZ+lITs8ulZjyg6PuBB4CfJxJWZ79K4sqLpn3debG25
   4b0jx9xsdWhDM9igPuQaGM+wp0Rt6PiiULkTJv/4hi/wk0p2LdoyQ+00y
   5s3Q3wpGyqUUomVEY64zx9vuhMDUvQ/eEJnn5gfgFmZnvkYgBWP9Vm4RU
   Y=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: XQuiyKc6J94Zx/VxcgzlIyC50Xi4lTUznjPo3Qp1q/KcZXO30R6r1qx7b6lvc9lYsFVsvKLAVd
 y4DAFS+Baz+lX6d12DtVireQQaSGYbNSwQhigtiygh2HajZeG8zfEoVpAlLIlEKaUb2QNmCWT/
 LHoJ5Ft6rVi9EMhWBVID5zsU0Zs23Ym7yZI4DcTckHBmTsMrDq7Qlg+AN9MNQiDB/L3AGCaMN1
 RlJWph945m45YuNgI2kr9QwOL3oTU82ihqhw94OHBFZ3UCgPTl7q8QFDvE92xtAE8y0TIrKuRF
 zhEaandxlnSSRUFLo83WS9F3
X-SBRS: 5.1
X-MesageID: 57158146
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:DT6TDKIn4yW6xL2RFE+RJJIlxSXFcZb7ZxGr2PjKsXjdYENShDZWz
 DZMWG6HOvzZZGOjedt0OYrk9h9TuZXXzoVgQQplqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s
 q3yv/GZdJhcokcxIn5BC5C5xZVG/fjgqoHUVaiUZ0ideSc+EH140Eo6xrZg6mJVqYPR7z2l6
 IuaT/L3YDdJ6xYsWo7Dw/vewP/HlK2aVAIw5jTSV9gS1LPtvyB94KYkDbOwNxPFrrx8RYZWc
 QphIIaRpQs19z91Yj+sfy2SnkciGtY+NiDW4pZatjTLbrGvaUXe345iXMfwZ3u7hB22goxL9
 dJupaaIWDsiFYnJoLQxUUBxRnQW0a1uoNcrIFC6uM2XiUbHb2Ht07NlC0Re0Y8wo7gtRzsUr
 LpBdW5LPkvra+GemdpXTsFFgMg5IdatF4QYonx6lhnSDOo8QICFSKLPjTNd9Gpv350eRKqAD
 yYfQSZlQDHYQQRvBnsoF60slcaFvEjuVDIN/Tp5ooJoujOOnWSdyoPFINfTP9CHW8hRtkKZv
 X7duXT0BAkAM96SwibD9Wij7sfNly7mXIMZFJWj6+VnxlaUwwQ7FBwTfUu2p7++kEHWc81bA
 1wZ/Gwpt6dayaCwZoCjBVvi+ifC50NCHYoLewEn1O2T4pXJvzykAUsUdAZQVNcNkMoOFRAoj
 3bcyrsFGgdTmLGSTHuc8JKdojWzJTUZIAc+WMMUcecWy4K8+N9r33ojWv4mSfTv1oSkRlkc1
 hjT9HBm74j/m/LnwElSEbrvuDmruoTSBjA84gHaTwpJBSsoOdb7OeREBbXdhMuszbp1rHHd4
 xDoeODEtYji6K1hcgTWHY3h+5nztp643MX02wIHInXY323FF4SfVY5R+ipiA0xiL9wJfzTkC
 GeK51gNvsQJZybzPfUpC25UNyjM5fO9fTgCfquMBuein7ArLFPXlM2QTR/4M5/RfLgEzvhkZ
 MbznTeEBncGE6V3pAdatM9GuYLHMhsWnDuJLbiilkzP+ePHOBa9FOdUWHPTP7tRxP7V/23oH
 yN3apLiJ+N3C7alPEE6MOc7cDg3EJTMLcuo9pINL7Xdf1MO9aNII6a5/I7NsrdNxsx9vuzJ4
 mu8Sglfzl/+jmfAMgKEdjZob7aHYHq1hS9T0fUEMQn61n49T5yo6atDJZI7caN+rL5ozOJuT
 ulDcMKFW6wdRjPC8jUbTJ/8sI09K0j72VPQZ3KoMGolYpptZw3V4du4LAHhwzYDU3isvswkr
 rz+ig6CGcgfRx5vBdr9Ye60yw/jpmAUne9/BhOaItRadEj23pJtLij90q0+L80WcE2RzTqGz
 QeGRxwfoLCV8YMy9dDIg4GCrpuoTLQiThYLQTGD4O/vZyfA/2elzYtRa8qyfGjQBDHu5aGvR
 eRJ1PWgYvcJq0lH7thnGLFxwKNgu9a2/+1Gzh5pFWngZkiwDu8yOWGP2MRCu/EfxrJdvgfqC
 EuD9sMDZOeMMcLhVlUQOBAkfqKI0vRNwmve6vE8IUPb4i5r/eXYDRUObkfU0CENfqFoNI4Fw
 Ps6vJ9E4gOyvRMmL9Kag30G7G+LNHEBD/0qu5xy7FUHUeb3JoWuuaDhNxI=
IronPort-HdrOrdr: A9a23:A48PqKpzzIkh6RlIctiK0KoaV5ulL9V00zEX/kB9WHVpm5Oj+P
 xGzc526farslsssREb+OxpOMG7MBfhHO1OkPYs1NCZLXXbUQqTXfxfBO7ZrQEIdBeOjtK1uZ
 0QFZSWTeeAd2SS7vyKkDVQcexQueVvmZrA7Yy1rwYPPHJXguNbnmBE426gYzxLrWJ9dPgE/f
 Snl696TnabCA8qhpPRPAh6YwGPnayFqHqgCiR2cCIP2U2rt3eF+bT6Gx+X0lM3VC5O+64r9S
 zgnxbi7quunvmnwluEvlWjrqh+qZ/E8J9uFcaMgs8aJnHFjRupXp1oX/mnsCouqO+ixV42mJ
 3nogsmPe5093TNF1vF7yfF6k3F6nID+nXiwViXjT/KptH4fiszD457iYdQYnLimgAdleA59J
 gO83OStpJRAx+Ftj/6/cL0WxZjkVfxiWY+kMYI5kYvE7c2Wft0l8gy7UlVGJAPEGbR84Y8Ct
 RjC8na+bJ/bU6aVXbEpWNiqebcHUjbJi32BnTqh/bllAS/xBtCvg0lLY0k7zc9HasGOtx5D7
 +uCNUwqFlMJvVmJp6VSt1xGfdepwT2MGTx2VmpUCHa/Zc8SjrwQq7MkccIDd6RCeg1JbsJ6d
 n8uQBjxCIPk3yHM7zG4HQMyGGXfFmA
X-IronPort-AV: E=Sophos;i="5.85,375,1624334400"; 
   d="scan'208";a="57158146"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Gvz0FIWT/lFTGxTba6VCGihe4py1vt9KlFRSE7nibuUtY4qNFkVwOKhF+okAevjTVk1XImFxzXqn9bNV50eATiQBWXBIN+sf1NeZJK1d0P7mLXkxL9p0aFJdYr3UXsEL3B9be+NzDWqeQ2FlQBIIiVFI2EiXR9PEPv+EOFaN/FzeBO3u903D5wbyUfjabjblrgfO2uIRM7PtYK+V3EunlKO3lSTSLAeaXspjf4Ce1jI1e6vk7XuYPxa8H6JbCTCDr0H2TSdPY6h3p//bLbtTlLh/hTmdQ7U0oOW+sRpdB8eJzgXW/Io37xdNP3BQjkT0bDUlbvmrRjFG9H9PYzfeNQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=8k7tCjyo4Qq2kUKLUP653B/CUYHYrYdovKTWpM/QmDs=;
 b=HV58XUNzjhK4jXbOCNRb8QVoiKRUe9rOlGOvcueHcja7/nLmCjcXxbbP778fYhhai0BIEdEXrz1pHrieGWin37L74Jb269eEhRoMyS8NPpdvXkXBfPIcLmPHSN0Ok+oQez1NHQge4FNvRl2GICYz1edQp48Nzt8OoNw8aF9M1lx1zOxgks2TvX1fwvXSnSrJ87besunOD+o9PEk6vkqN8cV4u9X5cBoNqRdTyNXkR+rEt64xQUHrczKNcGsPYJrNnYP2H6K0rkrpUsEPMoG+e/Is4kXsiWiotmAFqw0k3bR9yRILmFxnBDVuWJnFTiuiFg9BvgJziQr8rFWw0DhbLw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=8k7tCjyo4Qq2kUKLUP653B/CUYHYrYdovKTWpM/QmDs=;
 b=ZdPUaXqSLWl8TQiqqzOOFn6TpPQ6sSH5w+RmrltOyfSXRcJ72uYeZnDLxMjxn0fRk5XWyq0SYANIMYztwfWIQaiXe9F1xyoPZnf4kcibfTrALcKOzT3koC0CtSrT4/PdT8yfbhjMuVkCdb7uMUIVHYKulfnH9IhzihGXK8Nzspg=
Subject: Re: [PATCH 1/2] x86/shadow: adjust some shadow_set_l<N>e() callers
To: Jan Beulich <jbeulich@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Wei Liu <wl@xen.org>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
	<roger.pau@citrix.com>, Tim Deegan <tim@xen.org>, George Dunlap
	<george.dunlap@citrix.com>
References: <24329000-06d7-2047-b0a1-51b149d19189@suse.com>
 <298846aa-f93f-4564-dbf4-4f893df8f328@suse.com>
From: Andrew Cooper <andrew.cooper3@citrix.com>
Message-ID: <0ccccb9e-6d99-f3c4-68ac-b6af88be8335@citrix.com>
Date: Fri, 15 Oct 2021 10:19:59 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <298846aa-f93f-4564-dbf4-4f893df8f328@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Content-Language: en-GB
X-ClientProxiedBy: LO2P265CA0193.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:9e::13) To BYAPR03MB3623.namprd03.prod.outlook.com
 (2603:10b6:a02:aa::12)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: c2d198ae-9dd5-4709-8e89-08d98fbcf919
X-MS-TrafficTypeDiagnostic: BYAPR03MB4680:
X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <BYAPR03MB4680759B21A1DA513B25996BBAB99@BYAPR03MB4680.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:5236;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: OW3fvBBD7I0+/KpXTj6VthrOKnciCXDMO4+SEO/JTJ3evDGjeVc5sgnyeH83mmI7AARrJuHYQlS7Ci4VIYfniCRnmgy9LlZdVbzomyVgCdq2zzX2WCGn5Zpe6gUHLa7km4ltTKhUVMLodmXOSJnYdcTMLryc9UtUMxZWsQ4eFoo+llm3pIOzi9ia4Gh5/alWyr1qnTWD+ceHfSXklrvsvsA/eCkNw2dJEsLpqW2KyJN8o/BvB8h/ll75nzWT9VQyi0VAcciy5OoIk5qjxs9LuWEFd/JcxSJufiFME+s2ULL2k/eyi8//VpQ+1iP+7SMcBH6pNVawyZIYdwvv/X0VOa8ott8cMv4dK5UnJs+NkQ+07LqicUr2O8Skkd9OTyb9QXWFDvG5Ejgicj5sQMaDrZ3hi8wiVml4M/lrdnX8mGt3IiXfWPRzczdGhBPSAVEVAbrUzdQwNIPklaxB08gqd7g2XHj5rwzOnigiMEXrraOetrMn9AE+Vn+lstn9mzw+O3x2NoQzz8R74nR5Od03hdpJfcgV2yqi2IwIZJBEgw+wq5MYRG/jGRmbuCstozTuWHylAjmlkBF/Y2sEdeF3f86rO3gRoddz1L/FC8KcHgx0WEFTm84V3Y7Ggz3HUHEQXqz5H9+wo+VBlzmJxqon7pVcSrTVqXerBC++kdi8tO6/H964QNOvg/wblqsVHSagPz5SeoJI1yW26X4pqfakoDt05BOg2GY2hw+kACLnzzE=
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(16576012)(26005)(316002)(82960400001)(66946007)(54906003)(4326008)(5660300002)(86362001)(110136005)(53546011)(31696002)(4744005)(36756003)(508600001)(2906002)(31686004)(186003)(8936002)(6666004)(8676002)(6486002)(107886003)(38100700002)(2616005)(956004)(66556008)(66476007)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VGZwVjhVWWczaVVqTXZDWW84WHI1WXhiZkJwclNxZ1c2MEI4SmVQL0RtdzF4?=
 =?utf-8?B?cVVsNUtad1hvd3NzQ2ZSdWR1THVGazBPeGtCd1Q0MGJYU2RlWmxHeDFNUWFI?=
 =?utf-8?B?YVpybGZtcVFSMFpYUXdBbXVGakMzQ3hFODF4VFdxRXlKRUlkaVZQWUkzRktV?=
 =?utf-8?B?ZVoyYVRoRktMTVpMSEpCNW9SaDFuSWhEbDZCbW1ac3Zjd2ZRSTl5SnJrWEgw?=
 =?utf-8?B?dXFhMXBxQ20vaW0weGwyYktwWGpzWkR3dXFmQmxvU1dCbjdhTWgxS1BHU0xx?=
 =?utf-8?B?eGRXYncvb01ydUxEVno5MGFmeWxwalNNdTdXM2IrZFUrWDdCZmVOK2duT2RQ?=
 =?utf-8?B?a0I5R28rMnJ3UmNUUXh2amdDVmtkNUhDRVVDcUtncEpydUdQSkFUTXBOT0w0?=
 =?utf-8?B?M0pFQlpzdjdwblBqajJzV3VtMlk2RXl4ZWhCRGtHbC9xcnl2cnZiM2s2ZlFp?=
 =?utf-8?B?dU5vRStSVHdJTG9CS0hPSFU1elZSUTdYUUVBM2Qzek13TXdLb3VKb0J6M2FF?=
 =?utf-8?B?NGtqUEx6R2k2R3h4YVEzK2w1V3c3SXQwTFlUQmo4WjhINmt4NnJRclhkak1M?=
 =?utf-8?B?N2JJZjJMUHlPSmorci8xcjM5SVVIc0NXRjMxbTlSenc3eTM1amtxazJWZlpt?=
 =?utf-8?B?UHR4UEc5NWFXazYzNnJPcTkrK1QrWkQ5Y2NDaHhHRE4wMjA2OW9NUzZ6ZGQw?=
 =?utf-8?B?QlhON05qSTFQd1AxVkpTYTFmYmtPTGdlaVZpUEd3a25aUmIxTzBwaU1zMVV0?=
 =?utf-8?B?RFIrZlo2Q3FwRGFva3Iydmk3WWhnaFBKNkJ2NVJFYW52eVhHc202ZEExU2VP?=
 =?utf-8?B?Z1hQeTZqT2ZRUnNzcmlwcW9zek5UTExCdExzZUVLMmlHcXdIRXNjQjZwTG9E?=
 =?utf-8?B?dk1PT3QwZGRRLzhPZHozQzNld29GMnJjcS84anR1NzBYQ2J1Zm91cXRIM3Bh?=
 =?utf-8?B?TlUrZlh3V0RHR1Z0bTVEYTlaSG4wQWxBeGdLc2s2aDUxTDhPN216RFl0Z1NQ?=
 =?utf-8?B?V0xEOXBQODdhTnozcWlmQlEybEdHU1NvRTFldThJTWtvNnlFRFNISlRManYz?=
 =?utf-8?B?bjRYNG1zUlJYVFk4TXZTcTNYMnp6VTF2VFN4bG1DOUhIdW5QUmpIMXgwUW1E?=
 =?utf-8?B?Wmw4c0lTVTZ1SXFCVUJZRzUrcHduNVp3dDkrNVQxemhRb1hBVHRLYVJOckdu?=
 =?utf-8?B?SXlSREdUN3dmVFUxTmxiMk1pWFRrMkJwR2FzcmFib1Y3LzJGU0UzV0hmLzNP?=
 =?utf-8?B?ako1M1EzRjl2NkJTRzRNM2NQTFVLZTh0QW4vZytTQjlhY1RxcmJ3MFdHU21Z?=
 =?utf-8?B?ZzRhRHZYNG5UbjlucXllRnA5VWpmanUyV05mdUxOUFBMYytMK0MrNzJWVjl1?=
 =?utf-8?B?em5qMVIrMWlCMFlGbDJ2eElWMjIwUVVFOGxqVTlGM0lPZkpnUVVNVzkwRXl5?=
 =?utf-8?B?dERyZDVSSjV1RjBzamRiY2JWRDIwQjJRUVV1V0pZaTdsa0xzN2dURFdraUIr?=
 =?utf-8?B?VDQ0Lzh3REM5Zk5EQXBuYVBXc3lCRmVPYVVBbzl5RDlUMHVTeExGTTNUK3M1?=
 =?utf-8?B?aWdZM3FVbDByTXRPTEZiQ3c4czJmOXBLV0E4VlBGZnBiRjd0dzNwai9NYk1a?=
 =?utf-8?B?cDArWjFLNUlBN0QwbWFJbHpJWnlDb0lIMEZyb0lycUsveFg4bE9yTnJCWGJP?=
 =?utf-8?B?SUNBdmZUQ3RobU0xYlhialp1QTVxNE5EeUhQTDdBK0NFRHBGYnA3WXduSHht?=
 =?utf-8?Q?aRf6cANzQtSeSjiWdT4iD6aWwMNoSKx9qcUeat3?=
X-MS-Exchange-CrossTenant-Network-Message-Id: c2d198ae-9dd5-4709-8e89-08d98fbcf919
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2021 09:20:04.9548
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: THdvF1y3D0qVDG2qLYZZvIzVnN4/eC9UvrSjyF/bP39kS3s1gpxk5TExwNrz76LqJ3qPxjNhVfFKO1cnczhelxRuH+YljzRjz7Ckf0/kEAc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB4680
X-OriginatorOrg: citrix.com

On 13/10/2021 16:37, Jan Beulich wrote:
> Coverity dislikes sh_page_fault() storing the return value into a local
> variable but then never using the value (and oddly enough spots this in
> the 2- and 3-level cases, but not in the 4-level one). Instead of adding
> yet another cast to void as replacement, take the opportunity and drop a
> bunch of such casts at the same time - not using function return values
> is a common thing to do. (It of course is an independent question
> whether ignoring errors like this is a good idea.)
>
> Coverity-ID: 1492856
> Coverity-ID: 1492858
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>


From xen-devel-bounces@lists.xenproject.org Fri Oct 15 09:26:26 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 09:26:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.210031.366730 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbJTr-0001Nu-6L; Fri, 15 Oct 2021 09:26:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 210031.366730; Fri, 15 Oct 2021 09:26:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbJTr-0001Nn-34; Fri, 15 Oct 2021 09:26:23 +0000
Received: by outflank-mailman (input) for mailman id 210031;
 Fri, 15 Oct 2021 09:26:22 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mbJTq-0001Nh-No
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 09:26:22 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mbJTn-0000Mk-Vw; Fri, 15 Oct 2021 09:26:19 +0000
Received: from [54.239.6.185] (helo=[192.168.0.140])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mbJTn-00062c-Nv; Fri, 15 Oct 2021 09:26:19 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=hOzbmovLvtJQ1Jo5rJVgx04ACmD0CR3WuBqls7yBu7Y=; b=TR0CzgugG/ngzLxzAw3spMvzJ2
	eExp7m1YyDpDllVJD/79C5N41R5E1iK4ju40QWj33fOhonM+r9QSiEjZlEILFAlFDgrXgGDTaNjM3
	cmknszTXYfSZ7xK8uffYGCVRsq3q7EptZgCGeg7ZtLA5O37YHaTS13fNTyDM0KazNpAs=;
Message-ID: <de2a74f3-5b7d-d0b2-28a1-c3efe5ae05de@xen.org>
Date: Fri, 15 Oct 2021 10:26:17 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.2.0
Subject: Re: [PATCH 2/2] memory: XENMEM_add_to_physmap (almost) wrapping
 checks
To: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <4f54456b-e8da-f67f-b6a0-b5ce2cf12cae@suse.com>
 <f78f8a30-39b7-cec2-2af0-27ebab28cedd@suse.com>
 <561dcb90-7b6d-4dd6-2ca7-a4a5ec1c5e35@xen.org>
 <5e829583-d593-3b19-ea54-acb31ee8eec9@suse.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <5e829583-d593-3b19-ea54-acb31ee8eec9@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

On 14/10/2021 15:10, Jan Beulich wrote:
> On 14.10.2021 13:29, Julien Grall wrote:
>> On 13/09/2021 07:42, Jan Beulich wrote:
>>> Determining that behavior is correct (i.e. results in failure) for a
>>> passed in GFN equaling INVALID_GFN is non-trivial. Make this quite a
>>> bit more obvious by checking input in generic code - both for singular
>>> requests to not match the value and for range ones to not pass / wrap
>>> through it.
>>>
>>> For Arm similarly make more obvious that no wrapping of MFNs passed
>>> for XENMAPSPACE_dev_mmio and thus to map_dev_mmio_region() can occur:
>>> Drop the "nr" parameter of the function to avoid future callers
>>> appearing which might not themselves check for wrapping. Otherwise
>>> the respective ASSERT() in rangeset_contains_range() could trigger.
>>>
>>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>>> ---
>>> I find it odd that map_dev_mmio_region() returns success upon
>>> iomem_access_permitted() indicating failure - is this really intended?
>>
>> AFAIR yes. The hypercall is not used as "Map the region" but instead
>> "Make sure the region is mapped if the IOMEM region is accessible".
>>
>> It is necessary to return 0 because dom0 OS cannot distinguished between
>> emulated and non-emulated. So we may report error when there is none.
> 
> Odd, but I clearly don't understand all the aspects here.
> 
>>> As per commit 102984bb1987 introducing it this also was added for ACPI
>>> only - any reason XENMAPSPACE_dev_mmio isn't restricted to CONFIG_ACPI
>>> builds?
>>
>> There is nothing specific to ACPI in the implementation. So I don't
>> really see the reason to restrict to CONFIG_ACPI.
>>
>> However, it is still possible to boot using DT when Xen is built with
>> CONFIG_ACPI. So if the restriction was desirable, then I think it should
>> be using !acpi_disabled.
> 
> My point was rather about this potentially being dead code in non-ACPI
> builds (i.e. in particular uniformly on 32-bit).

The hypercall is already wired and a dom0 OS can use it today even on 
non-ACPI. Whether a dom0 OS will use it is a different question. I know 
that Linux will limit it to ACPI. It is likely not used by other OS, but 
I can't guarantee it.

In this case, the hypercall is only a few lines and already restricted 
to dom0 only (see xapt_permission_check()). So to me, the #ifdef here is 
not worth it.

>>> @@ -841,6 +844,15 @@ int xenmem_add_to_physmap(struct domain
>>>        if ( xatp->size < start )
>>>            return -EILSEQ;
>>>    
>>> +    if ( xatp->gpfn + xatp->size < xatp->gpfn ||
>>> +         xatp->idx + xatp->size < xatp->idx )
>>> +    {
>>> +#define _gfn(x) (x)
>>
>> AFAICT, _gfn() will already be defined. So some compiler may complain
>> because will be defined differently on debug build.
> 
> No - _gfn() is an inline function as per typesafe.h. (Or else it
> wouldn't be just "some" compiler, but gcc at least would have
> complained to me.)

Ah. somehow I thought it was a macro. But looking at the implementation, 
it makes sense to be an inline funciton.

Sorry for the noise.

> 
>> However...
>>
>>> +        BUILD_BUG_ON(INVALID_GFN + 1);
>>
>> ... I might be missing something... but why can't use gfn_x(INVALID_GFN)
>> + 1 here?
> 
> Because gfn_x() also is an inline function, and that's not suitable
> for a compile-time constant expression.

Right. How about introduce INVALID_GFN_RAW in mm-frame.h? This could 
also be used to replace the open-code value in INVALID_GFN and 
INVALID_GFN_INITIALIZER?

> 
>> In fact, I am not entirely sure what's the purpose of this
>> BUILD_BUG_ON(). Could you give more details?
> 
> The expression in the surrounding if() relies on INVALID_GFN being the
> largest representable value, i.e. this ensures that INVALID_GFN doesn't
> sit anywhere in [xatp->gpfn, xatp->gpfn + xatp->size).

Thanks the explanation. Can you add the rationale in a comment on top of 
BUILD_BUG_ON()?

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Oct 15 09:40:25 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 09:40:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.210038.366741 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbJh3-0002qt-DG; Fri, 15 Oct 2021 09:40:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 210038.366741; Fri, 15 Oct 2021 09:40:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbJh3-0002qe-A2; Fri, 15 Oct 2021 09:40:01 +0000
Received: by outflank-mailman (input) for mailman id 210038;
 Fri, 15 Oct 2021 09:40:00 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=FGCa=PD=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mbJh2-0002qY-Bw
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 09:40:00 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id dc018572-2d9b-11ec-822c-12813bfff9fa;
 Fri, 15 Oct 2021 09:39:58 +0000 (UTC)
Received: from EUR02-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur02lp2051.outbound.protection.outlook.com [104.47.6.51]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-31-SZqKm_8mMPqclDzGmBwqNw-1; Fri, 15 Oct 2021 11:39:56 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0401MB2448.eurprd04.prod.outlook.com (2603:10a6:800:52::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16; Fri, 15 Oct
 2021 09:39:55 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.017; Fri, 15 Oct 2021
 09:39:54 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS9PR06CA0002.eurprd06.prod.outlook.com (2603:10a6:20b:462::7) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.14 via Frontend Transport; Fri, 15 Oct 2021 09:39:53 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: dc018572-2d9b-11ec-822c-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634290797;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=oIAWWs9j41bH0x/Er5tH9xUdRz2opxoNRR4Bc7MFB28=;
	b=b0FgGTdddwPEAbjhyWlK4M0VEfqNQfQWxMuqp8fi5MShODZOWrHNlUz//A3ev0OMnzDk3u
	Wc4pUgniuT50B6B9T3XoU3rRzRZ6a125bEVLlxQxFXWUzHEGAgSAu2JTz7WsQ+oF9IORUA
	luUCWPqrGK1tGgnlfVr5fsCh0+1QHWw=
X-MC-Unique: SZqKm_8mMPqclDzGmBwqNw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=JM6jmeUGQBsAc3IFlQf0xnjoyX43uBSq3aquXCFP6Ie+VdqNf+E2K9JA4Br+nH4Fhmi9Htg+SSD/GN7lthiN2jDN3hy0S7LOhfqhhHTLRTRyAcebaIxf/vqq+Z17xce/aFnjZ7J4dIOcHWVc6j8SndDwvkZa8GGjTRDjrEOUz4PAohjGbOlwfnTQ55W/uNefem4KYFqar14it31CmCbP6Yhz/w65Tgj4cHxGUkabLqPxUs/dX8eytY7l6B4Z2bcoOzkwCBuhtdj9+e04D0CjIVGzathDm3caK7VSy+uN6q2qFqZwBiRdsnSbd2ZEA2a+IWkpH7B4dftP0nAF7OFyTA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=oIAWWs9j41bH0x/Er5tH9xUdRz2opxoNRR4Bc7MFB28=;
 b=Qvp6nB1M4DNfPBeh2sQ4to1JJ0crhiabpWyInN+hmgicaW8FkB8Xz/n11U1ZZ+QbokOcrWjHvF75koIn4HD53x7lbUB0/QJFSH11f2/JJWP7ZMdWVltRHAu6thVn21e5RG31x9Q/pucV5IrmvRZkiTbsiXQU+63tT0v2Kz0sHtBwZTO6S+gNG5UCutG8vrA3dBIVOPcAzOA5088nImWSEDiIRRyTJh2Js1RcKZcKeQIET3raft27QlJwcCIjoUCiS+TQ1tV43ATaz0hRQdnSInztNbHHM39fTs15PySwOz+oTFtDcdwIJy4Lhjg2jPStQ7mV8CLNi7SpWiKx2k6omw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [PATCH v2 2/6] gnttab: allow setting max version per-domain
To: Roger Pau Monne <roger.pau@citrix.com>
Cc: Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Anthony PERARD <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>,
 Christian Lindig <christian.lindig@citrix.com>, David Scott
 <dave@recoil.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 xen-devel@lists.xenproject.org
References: <20210922082123.54374-1-roger.pau@citrix.com>
 <20210922082123.54374-3-roger.pau@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <f5564634-5f9e-0b94-f73a-d44ae65c30f4@suse.com>
Date: Fri, 15 Oct 2021 11:39:52 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <20210922082123.54374-3-roger.pau@citrix.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0002.eurprd06.prod.outlook.com
 (2603:10a6:20b:462::7) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: cd3deadd-e014-4de4-c093-08d98fbfbe74
X-MS-TrafficTypeDiagnostic: VI1PR0401MB2448:
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS:
	<VI1PR0401MB2448D7701F2F322F46611FEAB3B99@VI1PR0401MB2448.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	TaOV4ogJ7CjFZeBAE6zvMw2gkKI+Hrck0a2hksjziNz2ppL7CdRpLrLvTq6Ae8z4PnzGQ0MG0VcRT3/8LCILwS260gQlK7TdH9BCaLD8Jp+dXe6FKqfwZ4IgWrkNSRWEQ6ISsto7Biwm9D91Ci4k7w30aULuK2Xgua5X/rbCmubj8vbgayJ7fgVPDxkkFR6i0bgep9ZLjzTcdtsBw7bcavoqD9nLjqkBSHPheNnvTWamSg9XkDwSXRPyYGo3YcpUnVTtMgJwOJXJd2rP80v/rlI+2zX9J/ocJlL4TASNBHJlkkPTEsRD4n64M7bw0jmiOhqD/TlrZZp77N+EAgbdQP/iK11iQFLk7ebBcMZJO/sjFiQugMROvLlSVhPpJFCzD07oRIcvPhIAcnit1vR0EpfXLtJCRuZKBQvhwlBjuedKDnEFYM6a9uePi8czu7/96BlOrCfd6PflZlHefweklCRTfepmQOjgcsDebnnDH3jzzyNxWFUpRLwJApr3CujIQj8rNSJ44wf7w9P4rdkAgjrSTtzChXFbqboE/yfvFRDB12zB58OZH6yYdqHpMiUqwld/6ZTc0UcQgwMlw1Sbj5W2fAl/jOsF7Zs68HNn8FUgFukNMjN22A1uQ0/2XzCh1ReQwu6qCqQ1MvCpxPkY56w72qtqBMdN88sDeFSSSlSlKsqvpoje1DmP5K/CbO2KPXd/kcIVFx7RNIWXOxJAy1aieURKDY7YLvnvY9mMtWWMEa7EkKaRvEGZxCuRCDKB
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(66556008)(66946007)(7416002)(31686004)(186003)(66476007)(38100700002)(6486002)(5660300002)(16576012)(508600001)(36756003)(8936002)(2906002)(54906003)(53546011)(4326008)(2616005)(956004)(6916009)(316002)(86362001)(8676002)(83380400001)(26005)(31696002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?OG1wMUo2OER0NkdzTlMzUlRvTWtWSmd0SlZFSUNNQ1YxUVhjajQ2RVdqcTNz?=
 =?utf-8?B?SGgvL09CT3F4VVFpY1dSRlQxak5CVFZORkMyenpZTnZ6T1JkSkhEQVFjNXJj?=
 =?utf-8?B?R1gyUHFJZ0hvbzlmWmlXbytORE5iQzZBV1pvcnpPRkwvaStxZ3c5QkhSTHNa?=
 =?utf-8?B?L0RQR0ZMNUlPeU9GdzFPMFBXUDlrWVRYK2FIbWFHdmw4Nks2WlpjNkdTWUht?=
 =?utf-8?B?Y3lkaXp6cS8zY3pmNkR1SnlrWEl2UTJEK205NDc3bnpiUzJXazhncHIyUTJC?=
 =?utf-8?B?RU1NY2RwNlRITUdvQytrUyswSjk0WmVFeFZCYmNBcmVReWhOS2NzeFg3Zkxm?=
 =?utf-8?B?TjRQMmRudm8vSUFrZnVyUmlsL252M0pnemJ4K2ZOVU0yUjZNNXpHd0kxZThY?=
 =?utf-8?B?VmYzNzNIdmVrYmtYNlkvWk9tZUFaaVRRQUtkci84ZEJvUmg0V2lIRGlndlRs?=
 =?utf-8?B?cG82aGtCMUcvWmlMUnhScFFVYktsWGE1MmJHL2NOeXBQOExqZy9nNC95UzBy?=
 =?utf-8?B?WitoMnRZU2g1T25LWWxjN2dFK1M1ZUF5OWZHTmZLR1JBVVZQVHJNbk5FZTZS?=
 =?utf-8?B?MGJVVUhTWkFMUHRYRk43OUFFUkordXBKSGNqNEladGVlY05vWkR5M3VGeW5r?=
 =?utf-8?B?VThEL3g5UHJCOGdOTi9VQzdzcDRkMHZjVGtad1FTWDlDOTFOcU9meUp0b2R4?=
 =?utf-8?B?cWRPNFFHc211WFpzd2luc3hEY0xtdS95Z0pVNWpRZEh0dG5IUCt3MDNySU0y?=
 =?utf-8?B?d2ZZYUQrU2U2VFlURml4K09JTXE1cU9HbFYxaWdvMGZnWFh6NVhjY0hLQW8v?=
 =?utf-8?B?ZkFzYWo2a2tXQTVBRWRqWkZTUWdZeHJaYk5JVDVYbUFSNDkrNXpHbmRCTmJR?=
 =?utf-8?B?eGZZRjBvWEczWkdTYkg2NDNmVWNEaTErdEVaODgwZDBWOFo3MzF4ZWE3bDRN?=
 =?utf-8?B?ZGhVZXFab3ZVT3l4VnZTNXNvZnJLbUVyS0k3eW1FcFQ4aWlXWk9jNW5VT0hY?=
 =?utf-8?B?Sis2Y3RHZXhMY3pLSEZCR3gvbk1BVEpuVm4yQXU1OTJQYlVhekJUQ2JTcGpT?=
 =?utf-8?B?dmJWVDZ6L3dZSWRBOVE3a2hIUGxsMU50dE9IZWZGQjZ4ZDFuMThiV0lRTjkv?=
 =?utf-8?B?OS92eHU5azl2ZmY3a3d0SkNUMnhabysrREpYK0p2Y1ZrV0ljUHZ1SjRjcXRF?=
 =?utf-8?B?YWcvNDFGOVJQQUdDTkR0ejdxdHJubWZzT2VqNzF6dXdNY1g1N2dyZFZvOWtI?=
 =?utf-8?B?cDdEU3ZFSEIwcUcwRTdMU2Fqc0JORnV4eC9sWjZSaHZLTXBaRkVNaXJPTTFJ?=
 =?utf-8?B?MkdRY3l6VmYrMzdTYlB1SVprZVNhb1hIZllCa0xmNzlMMmYyLzhrK2dWcWZ0?=
 =?utf-8?B?UVJIWUJ5eitjUXhwNll4VFp4eFJtM3RxRGNMQ2dzUU9ybWp5dmh1ZkxVYm5L?=
 =?utf-8?B?MnJkbWtVWEI0SW1NTHoxaXRvRkJkSU1jcEliYkJhQlVtSzZZV25LaEg5NFI3?=
 =?utf-8?B?dWFJV0diZmxLT3dFdUpZN2ZwL1huVVhYWUV0U2MrVHFNcG8xQlpUaVhXY0hT?=
 =?utf-8?B?WmpLVk1Ebk9kTVdwaWZTeThsSjJ3bERHTVRxWXFaVzNYSjA5Mys0S3VyL0pa?=
 =?utf-8?B?QWxjSlhwSVJBcEpNQ2NaaUlFeTJ2Z3FWU3BDR2oyS00vMzAvR3ZiWkhEQ2FV?=
 =?utf-8?B?dysyWEVUdm5MUEJPYVR6NEdjT0JwL2ltMWU1aFEvcEFZSGs5TWVDOTFHSUNu?=
 =?utf-8?Q?pWmEY9pyBTPo3sqJTrDLlkfNJgSe6OuqTi2QOsV?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cd3deadd-e014-4de4-c093-08d98fbfbe74
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2021 09:39:54.7733
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: G9fZAWL6i7YNwoCnW9Rv3GjjksiqbJhUyO34H0LUJI5Hp1Ky6kwJfB5Ug6SzqO8izs53nhN8QUfNtLSXclwCbw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2448

On 22.09.2021 10:21, Roger Pau Monne wrote:
> --- a/xen/common/grant_table.c
> +++ b/xen/common/grant_table.c
> @@ -53,6 +53,7 @@ struct grant_table {
>      percpu_rwlock_t       lock;
>      /* Lock protecting the maptrack limit */
>      spinlock_t            maptrack_lock;
> +    unsigned int          max_grant_version;

Nit: I realize the version field also has "gt" in its name, but just
like I consider that superfluous, I don't think "grant" needs to be
in the field name here.

> --- a/xen/include/public/domctl.h
> +++ b/xen/include/public/domctl.h
> @@ -87,14 +87,22 @@ struct xen_domctl_createdomain {
>      /*
>       * Various domain limits, which impact the quantity of resources
>       * (global mapping space, xenheap, etc) a guest may consume.  For
> -     * max_grant_frames and max_maptrack_frames, < 0 means "use the
> -     * default maximum value in the hypervisor".
> +     * max_grant_frames, max_maptrack_frames and max_gnttab_version < 0
> +     * means "use the default maximum value in the hypervisor".
>       */
>      uint32_t max_vcpus;
>      uint32_t max_evtchn_port;
>      int32_t max_grant_frames;
>      int32_t max_maptrack_frames;
>  
> +/* Grant version, use low 4 bits. */
> +#define XEN_DOMCTL_GRANT_version_mask    0xf
> +#define XEN_DOMCTL_GRANT_version_default 0xf
> +
> +#define XEN_DOMCTLGRANT_MAX XEN_DOMCTL_GRANT_version_mask
> +
> +    uint32_t grant_opts;

As it now seems unlikely that this will make 4.16, please don't forget
to bump the interface version for 4.17. With that and preferably with
the nit above addressed, hypervisor parts:
Reviewed-by: Jan Beulich <jbeulich@suse.com>

Jan



From xen-devel-bounces@lists.xenproject.org Fri Oct 15 09:48:47 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 09:48:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.210047.366752 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbJpS-0004Gt-8a; Fri, 15 Oct 2021 09:48:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 210047.366752; Fri, 15 Oct 2021 09:48:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbJpS-0004Gm-5J; Fri, 15 Oct 2021 09:48:42 +0000
Received: by outflank-mailman (input) for mailman id 210047;
 Fri, 15 Oct 2021 09:48:40 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=FGCa=PD=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mbJpQ-0004Gg-PW
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 09:48:40 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 65d989a0-0d5b-4fa5-93e0-31042c693c6d;
 Fri, 15 Oct 2021 09:48:39 +0000 (UTC)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2058.outbound.protection.outlook.com [104.47.12.58]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-40-6X4l4gyDOwa-zn6FjXwk2Q-1; Fri, 15 Oct 2021 11:48:37 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB4191.eurprd04.prod.outlook.com (2603:10a6:803:45::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16; Fri, 15 Oct
 2021 09:48:35 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.017; Fri, 15 Oct 2021
 09:48:35 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6PR0502CA0054.eurprd05.prod.outlook.com (2603:10a6:20b:56::31) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15 via Frontend
 Transport; Fri, 15 Oct 2021 09:48:34 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 65d989a0-0d5b-4fa5-93e0-31042c693c6d
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634291318;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=hxyHKNc/iXTt0TtTxZAJo9ZsPSW3psvBcn7Q+Jb4ATA=;
	b=aGCECnOIRSCyKTTX0bKlF2AJiHjILjV6/J1NwLBUDXoWwh+VPbJ6k60/oSqUwv7MBXcXX2
	ehjGMeaWOsuI23p571XHaAUUPpcSLi/j1YEsTLJBGn5bh2CfAJgatoV4cNrqe3KHnhSJwV
	w9Lt7nuySKehoyd5ubkh6DujslLmCMs=
X-MC-Unique: 6X4l4gyDOwa-zn6FjXwk2Q-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ZtoIcMEppkhWYmP6Nc2S5/INRZUWcdBXj0pM34Rf9FFsFY9uRNLCnSSQTBUjF3WszVoJNKVPR9bGsI+cQC7AgFW4JJWuRNqkXFJCQMHRZx2ALV0WYpxunesSX9BEGQ9aiy661XknJbFC2ztwvgL+tBN20GqSOsVrJa9iC+JK7NQ4NsG/tb4G8P+6Iu7RqBIqGJW5FYdbVWqnpHTwl/jxHn1hourZIy1s2D969i1Uo3rkfHadV3v5xnqT39i7McK7OK21dty4aGix+Qwm5lYBrmehuLK529Ge6xhrc50mM9iPu31wKV2O8jdhBkA+FX+OI74brcZ+z6CNb6mDslzroA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=hxyHKNc/iXTt0TtTxZAJo9ZsPSW3psvBcn7Q+Jb4ATA=;
 b=JRLe43yvYr0T1DTQGiDp273CswCv767jN2w80KmPgi0zSsMyKEwbwCn2cllXrZVWzJXsKm1vRqQ7TWp7lH7AlabE52KHyaW4LmADiIWY4E96GZh27oZ4fXrK8V1UF8ZPjaY8enkd4SJF4j2uIAgvOsZ4YxoCPDrR3yBPpW55b1c3jmm0gZvpVU0GuHWUDrONiH5+EaiF57DcHvIerXUeMHohTRKjC5ZD4V+G514jvEVELAGnp0iQ0UqsYGl+yqY5wiqIrQPDTnP+E0W0oU5ha8XISu7P8SUX+yiDflskRtzgFzArOIAW+UUPrvjJSr6AmHKeHd+BCX5LfKR84Wqbeg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [PATCH v2 2/6] gnttab: allow setting max version per-domain
From: Jan Beulich <jbeulich@suse.com>
To: Roger Pau Monne <roger.pau@citrix.com>
Cc: Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Anthony PERARD <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>,
 Christian Lindig <christian.lindig@citrix.com>, David Scott
 <dave@recoil.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 xen-devel@lists.xenproject.org
References: <20210922082123.54374-1-roger.pau@citrix.com>
 <20210922082123.54374-3-roger.pau@citrix.com>
 <f5564634-5f9e-0b94-f73a-d44ae65c30f4@suse.com>
Message-ID: <0b58667f-b6bc-d5b5-2dd1-0c8996367319@suse.com>
Date: Fri, 15 Oct 2021 11:48:33 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <f5564634-5f9e-0b94-f73a-d44ae65c30f4@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR0502CA0054.eurprd05.prod.outlook.com
 (2603:10a6:20b:56::31) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 3c279e25-fbde-4e9d-525e-08d98fc0f4ef
X-MS-TrafficTypeDiagnostic: VI1PR04MB4191:
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB4191A8F097CCB6420A6BC2D2B3B99@VI1PR04MB4191.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	rab21fxsAkEJtJPt2XcZ0DEbz4SIIRlCpnF05ExYqCuC1pCt6VzJSf39+ANp1aX3ZpVmu5v2Zue/DRwOxYY8vBJfPOI3+8YSfNRb3igJ5lZvRVoSV7qB3AEeH9afQHyAi5LHidsJqBycdkgldxd9sbd5dtdtPLxLWQHC1exzu2U77RXeOWwkOCE+xRkfBQUvODKP6+ugCY2y5Z4Z1uybLB4SS51o+YkEUB6TCY9mnahjfVbx9IcJ9W7cgKJLFcNJgDzw7/eoYllOsk1f3FFHYckUA+1Z1h484ojEX681G5Wp2BintS37cPqs6KDujsru4ZOyI7ufANAJ3NpqOg+UQLbDfKzoRhlhBokfNgJnnRF7eRTXlGIUqtZra3fzPVmoSVo/IsrDVDUt8fDdvGiXBbMszLTfRW0GjSTt2amhgDZo4qYdOFqQbLZMQvbkO/3tj4vjevOHNmaDJhoaCYKtbtX75s6LNlvix0uBdLvcHnKHztbfXS3sBLSi1Z+pixaxIoub/OZon3XiVQveuXRiyztaABbzw9LMGDOvfTgp2PQNiRmDciRnEzObmV1qgaPd6chDEmDuDhLzTW6JWHeuWVBQ42u3y3tJH236AhHX8tVKIrhEKI5Ol/xVoC5iGQ8T1yNSh0orlwnU9dYSqYp76oozMUJcHJzzWYSnLc1xbpIng8GN475r1Dvu65LCc6quX+sUEWUzKmi75STd54jm43ausFJFWdhxhOfmaFB3mnhccGm7WgroJqyF0cg1wP5i
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(8936002)(5660300002)(16576012)(66556008)(2616005)(956004)(66476007)(31686004)(83380400001)(66946007)(7416002)(53546011)(54906003)(36756003)(186003)(31696002)(2906002)(26005)(8676002)(86362001)(6486002)(508600001)(4326008)(6916009)(316002)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?MHh1VlZpQ3gwUmcveGNscjU4dGUvWFhFQS9Zd0hsOHpXcnREOWZ3UVA4dVUv?=
 =?utf-8?B?WWxxdUJPNGdwbXlYY0dMNVZGN0lVSmx3L1RsRW9oalp4bEIvNEF2Tzd3Z043?=
 =?utf-8?B?WThyeDFrVWxPUkRUVU4rOVdWSFhwRUdMK05uSzR1ODVnUmlMRk0yeCtpZEJB?=
 =?utf-8?B?ZFIxWmRhNWx5TThaeGFBRHZMZTZoMFZBTGV1ektFcVFrNno2S24xVUZaMlpZ?=
 =?utf-8?B?ZTE1Y2lNU0p2ajlrMmExSVR0QXBwdkc4ek5FSkJiNnR5dHZJY1RPQUFjcDgw?=
 =?utf-8?B?OEh2aURYT2p0R2M5bm13R2lqVDNFUUltZ3pob3JPNDdIRUxMSEhiZHB2ZGp2?=
 =?utf-8?B?WlJSVEdIMW9BdkZQdkxLT1dlRzJmd3V3SnVYWEprQVlEeDdXU2pnT2p4MjBV?=
 =?utf-8?B?UHdkZEJVQzJmclZWMWVRcy8yeWVnYm40Mlk2bUZsdkJIeXkzdy9zMUhMY1Rm?=
 =?utf-8?B?b3lwcVJGWnZnQWE3ZVZ6K3dLNjZMYms4VkZ1bVArdW9xdGxFQ29OMS8vN1N2?=
 =?utf-8?B?b0wyM3J6YWJ2NUxsM280YVNwMFBRNUkwbTJpVnY4anRwc3REcG9mN2t4NHpv?=
 =?utf-8?B?WmhqYUlVRVpLNmpIdFZWeHRlUzlDL00waDhBLzllcWFYR3F6SCtOMlRZK3Yx?=
 =?utf-8?B?eE8xWU04ckg4ekpVcWZYemZIalYwdVE0VlVVTU91YUJTQWtoTEFJeFNLV2pY?=
 =?utf-8?B?akROYXNxWVBDdGhzLzJ6OFNyWDhoN3lRbkYxNUc1T3VZdm5hOFUwamh6Yngr?=
 =?utf-8?B?YnlFSnpoc2JYdVJ2a0FOK09EY0J5ZEl3NUozTnoyajgvb0VmaE8yc2MzZ0xo?=
 =?utf-8?B?dXllNHpWODBvZUZSZ0JTd1dlanVHQkxSTXNHL2NBUnVWWHVjRFcxVzN0Z0tN?=
 =?utf-8?B?ZTBRMnJkY2JaN3NFNk1yQmFTcTJYbGhyVnFEOHkvV1BhQThsV3VsZVc1dWpr?=
 =?utf-8?B?cUtsOHlLeVY1UG5VUXhwZWt6K2xBRlk2ZHV6cUt1WmRJU1BqL3VIVjYxQzRR?=
 =?utf-8?B?MEhxODIwaVNWUVB4YUtmdHkxS0t3QlRxUG4zMFBLYzdQK0d0QmU1TUVnYVJT?=
 =?utf-8?B?L0VQakJjRFdTZlJaM25lVjE4Z3lIOEFMK0xrU3VEdnJPend1dzFSbGVaekNE?=
 =?utf-8?B?Zk9MYm1DUUJBU1hWaFNhSisxNXF6M0tVT05iMHRsb3ZGZzdyM2NBeWVXQXla?=
 =?utf-8?B?Q0tjb3ZWQjJEZmt1bm9DNkJ6cWQ3d2RMMldnNlRwREVxSkRIc1FIU2M5YUFO?=
 =?utf-8?B?S3ZYY0FTZXFtVmdGQVFBNE9tc2ZkTnNFeXZjeWtyd3pGb0VXckdwa1AxT045?=
 =?utf-8?B?OWIwaS9kdzF1N2F3Z2RXb25tdkU4ejFwQXo3alBDSll4ZlZNRGlZM2hUejNG?=
 =?utf-8?B?TWRLczU5azNuaUx2TVpGenFzK3piekN3U2ZlN08vNTJSRk1HTGxlSldHTU5q?=
 =?utf-8?B?Q1F6WXEwVlNEUmUvRm9keGt2aDJGRzYrdXo5YW14S0QydGxHMjgycTgwVGxE?=
 =?utf-8?B?U1NYeHE1U1EwUGFOVy9CRVY5OUhQSlZSdi91eTBoaTJpU1EzalpRSCt0ZGxP?=
 =?utf-8?B?M1NUZ1ZaaEZMcHpNQmpjTVF6UlVzOU1nZG1pSDZCSnEvRlBsckFGTkFKdzJt?=
 =?utf-8?B?Z0FEMy9ONjdTZExVeHVsSkFJRy83YUVzK0J1S3phT1BQUzlLb3JBVWhsWUpP?=
 =?utf-8?B?blZNekFwbnJrYTUwZXdPVkJMZDBBR04wRnplb3lyT1RtT0lGZEh0d3I1TFBP?=
 =?utf-8?Q?nZYN2D7dhDjOaYIVNX9lYHhlb/wMoGavAlXjqdG?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3c279e25-fbde-4e9d-525e-08d98fc0f4ef
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2021 09:48:35.6263
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: etEdMcBKJ8Qnv3VMdnMvWbJSw3nkNvtKp3F1cnnq1z0E811+XGHIJB2JvwQ8t/IYqBNjmGIYQ3ZVOp2B4B5j3A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4191

On 15.10.2021 11:39, Jan Beulich wrote:
> On 22.09.2021 10:21, Roger Pau Monne wrote:
>> --- a/xen/include/public/domctl.h
>> +++ b/xen/include/public/domctl.h
>> @@ -87,14 +87,22 @@ struct xen_domctl_createdomain {
>>      /*
>>       * Various domain limits, which impact the quantity of resources
>>       * (global mapping space, xenheap, etc) a guest may consume.  For
>> -     * max_grant_frames and max_maptrack_frames, < 0 means "use the
>> -     * default maximum value in the hypervisor".
>> +     * max_grant_frames, max_maptrack_frames and max_gnttab_version < 0
>> +     * means "use the default maximum value in the hypervisor".
>>       */
>>      uint32_t max_vcpus;
>>      uint32_t max_evtchn_port;
>>      int32_t max_grant_frames;
>>      int32_t max_maptrack_frames;
>>  
>> +/* Grant version, use low 4 bits. */
>> +#define XEN_DOMCTL_GRANT_version_mask    0xf
>> +#define XEN_DOMCTL_GRANT_version_default 0xf
>> +
>> +#define XEN_DOMCTLGRANT_MAX XEN_DOMCTL_GRANT_version_mask
>> +
>> +    uint32_t grant_opts;
> 
> As it now seems unlikely that this will make 4.16, please don't forget
> to bump the interface version for 4.17. With that and preferably with
> the nit above addressed, hypervisor parts:
> Reviewed-by: Jan Beulich <jbeulich@suse.com>

Actually no, I'm afraid there is an issue with migration: If the tool
stack remembers the "use default" setting and hands this to the new
host, that host's default may be different from the source host's. It
is the effective max-version that needs passing on in this case, which
in turn requires a means to obtain the value.

Jan



From xen-devel-bounces@lists.xenproject.org Fri Oct 15 09:49:38 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 09:49:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.210055.366762 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbJqM-0004uP-MP; Fri, 15 Oct 2021 09:49:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 210055.366762; Fri, 15 Oct 2021 09:49:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbJqM-0004uI-JV; Fri, 15 Oct 2021 09:49:38 +0000
Received: by outflank-mailman (input) for mailman id 210055;
 Fri, 15 Oct 2021 09:49:37 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=UM5E=PD=citrix.com=roger.pau@srs-us1.protection.inumbo.net>)
 id 1mbJqL-0004u6-7C
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 09:49:37 +0000
Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 217f509a-11ef-4de1-ada6-6dd28b3bbaff;
 Fri, 15 Oct 2021 09:49:35 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 217f509a-11ef-4de1-ada6-6dd28b3bbaff
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1634291375;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=SIkgIASlfSkqjS+gLvXwnBuUOj4B3sLNfYc2MyBFnxc=;
  b=WaSoi/7LCdjtM7BPl1pG4GyeVvwKwbx/M02RSm/xVOU+qk1LWcC4mF9R
   XRisEb5HzXLiXcbCxveOJmQx0hKuTWucO+rRnbJcJ+eL/SHrHBTG52yPW
   YOPOQnJb1iJ+qtNQrI2yDLSrek1XHyUCtLpCBwS7V6g8WLciwoIAnlMyi
   w=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: I+tspSi9GQrP0fA0L0GLpR17a8BP/spomo72hD/hL05EttME/FZDUf5EZHzEcYQm+LMRVTgndr
 calYYnbMAUBlXhJMe4DXXyExwUUv/lx32u9rFvuxgNyjpe2c5ezFt/Hs2fdYfFDBcWhS7rbr7k
 Omk1gvJu0o/5LoTEH6t3V+LaD55omXIDXCFCLfv5Qj5mpHno4FrkW7JpokU18Uo8MutoHCg6jn
 zUF2hoCDYiigOLPC9f4BQlWIicoKBDDhfHnGA3TxxiQNaAtS1abQdmm0I5wnbsrWWHtZDFI3ge
 /NmGLoS++m5itXVEBj948GIk
X-SBRS: 5.1
X-MesageID: 55303274
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:9xtCz6zT6fkuzh3linZ6t+eYwSrEfRIJ4+MujC+fZmUNrF6WrkUHz
 WAWCDjQM/qONmemKNElPtyy8UtXvZPUyNMxTABoqSAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx
 59DAjUVBJlsFhcwnvopW1TYhSEUOZugH9IQM8aZfHAsLeNYYH1500s6w7dk2tcAbeWRWGthh
 /uj+6UzB3f9s9JEGjp8B3Wr8U4HUFza4Vv0j3RmDRx5lAa2e0o9VfrzEZqZPXrgKrS4K8bhL
 wr1IBNVyUuCl/slIovNfr8W6STmSJaKVeSFoiI+t6RPHnGuD8H9u0o2HKN0VKtZt9mGt/4sy
 vZ0rLbhcB8kOKzog/s9dyZ6FhgraMWq+JefSZS+mcmazkmAeHrw2fR+SkoxOOX0+M4uXzsIr
 6ZBbmlQMFbT3Ipaw5riIgVort4kI8TxepsWp1lrzC3DDOZgSpfGK0nPzYIFh29r3J8SdRrYT
 5EeWwA3VgnPWDZSH0wwDZwllb6Jv3aqJlW0r3rK/PFqsgA/1jdZz7zFINfTPNuQSq19jkue4
 27L4Wn9KhUbL8CEjyqI9Gq2ge3Clj+9X5gdfJW66/prjVu71mEVThoMWjOTufCkjmauVtQZL
 FYbkgIsp6Uv8E2gTvHmQga15nWDu3Y0cddKD/cz7g3L76PO+huYHUANVDsHY9sj3Oc3Wj4Cx
 lKPh8nuBzFkrPuSU331y1uPhWrsY25PdzZEPHJaC1teizX+nG0tpjySTPVaCYTkt8X4HzDU2
 C+qiBccgoxG2KbnyJ6H1VzAhjutoL3AQQg0+hjbUwqZ0+9pWGK2T9f3sQaDvJ6sOK7cFwPb5
 CFVxKBy+chXVcnV/BFhVtnhC11ACxytCzbbnUJ0V6co8zCg6hZPlqgBvWkgei+F3isCEAIFg
 XM/WysNu/e/31PwNMebhr5d7exxkMAM8vy/B5jpgiJmOMQZSeN+1HgGibSs927silMwtqo0J
 I2Wd82hZV5DV/87lmHsHLpEgeV1rszb+Y81bcump/hA+eHGDEN5tJ9faAfeBgzHxPLsTPrpH
 yZ3aJLRlkQ3vBzWaSjL648DRW3m3lBgba0aX/d/L7bZSiI/QTlJI6aIndsJJtw094wIx7yg1
 izsBSdlJK/X2CSvxfOiMSs4NtsCnP9X8BoGAMDbFQ32hiZ5ON3xsf53mlleVeBPydGPBMVcF
 pEtU86BHu5OWnLA/TEcZoP6t4tsaFKgggfmAsZvSGJXk0dIS1Ob99n6UBHo8SVSXCO7udFn+
 ++r1x/BQIpFTANnVZ6EZPWqxlK3nH4chOMtABeYfogNIB3hoNpwNij8rv4rOMVQex/N8SSXi
 lSNChACqOiT/4JsqIvVhbqJppuCGvdlGhYIBHHS6Lu7bHGI/meqzYJafvyPeDTRCDH99Km4P
 L0HxPDgKvwX2l1NttMkQbpsyKs/4frppqNbkVs4TCmaMQzzB+o5cHec3MRJuqlc/ZNjuFO7C
 hCV591XGbSVI8e5QlQfExUoM7aY3vYOlziMsflseBfm5DV69aasWFlJO0XekzRUKbZ4Pd93w
 eolv8JKuQWzhgBzb4SDhyFQsW+NMmYBQ+MssZRDWN3njQ8iy1djZ53AC3CpvMHTOosUakR6c
 CWJgKfihqhHwhuQenU+InHBwO5BiMlcoxtN1lIDewyEl9etaiXbB/GNHeDbljho8yg=
IronPort-HdrOrdr: A9a23:BYeiT6mJ0Dl3DupugAu/D/qZs8DpDfOximdD5ihNYBxZY6Wkfp
 +V8sjzhCWatN9OYh0dcLC7WJVpQRvnhPhICK0qTMqftWjdyRGVxeRZjLcKrAeQfhEWmtQtsZ
 uINpIOdOEYbmIK/PoSgjPIa+rIqePvmMvD6Ja8vhUdPT2CKZsQlDuRYjzrbHGeLzM2fKbReq
 Dsgfau8FGbCAsqh4mAdzQ4dtmGg+eOuIPtYBYACRJiwA6SjQmw4Lq/NxSDxB8RXx5G3L9nqA
 H+4kPEz5Tml8v+5g7X1mfV4ZgTsNz9yuFbDMjJrsQOMD3jhiuheYwkcbyfuzIepv2p9T8R4Z
 XxiiZlG/42x2Laf2mzrxeo8w780Aw243un8lOciWuLm72weBsKT+56wa5JeBrQ7EQt+Ptm1r
 hQ4m6fv51LSTvdgSXU/bHzJlFXv3vxhUBnvf8YjnRZX4dbQqRWt5Yj8ERcF4pFND7m6bogDP
 JlAKjnlbdrmGuhHjLkV1RUsZmRtixZJGbDfqFCgL3a79FupgE786NCr/Zv2Uvp9/oGOtB5Dq
 r/Q+JVfBwndL5jUUtHPpZyfSKAMB26ffv9ChPgHb3ZLtBzB5vske+93Fxn3pDhRHQ3pKFC76
 gpFmko7FIPRw==
X-IronPort-AV: E=Sophos;i="5.85,375,1624334400"; 
   d="scan'208";a="55303274"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=h+vVdV/1pepwjo6raDik3KnFPO61x8rA+b/hIfDJSfwGBldYltgEAZZkH7JJyfsklJMnqjG1H/8S5YexH4c8r11w9pLbyP9G7SzoAWYh9EY2NE2IWOjI4PF1jysAmRV98UjFEFWVp6WTZ1QSXqi80mA7hcs7itFMMPq5+j6EeeWxjwJU2FUW05imTd2XQfbeIviBweeCnoxdHs/mJf131g3komvggwZgNoepRilDnLCBMnpbFa4PWOHBP4bqW1rv5+z0NJlNB1ej9HxXuWyO9daUDzw1m3+NFJPWl+PXHjUFAsKuPWApvwUAOFxJ4EI2VurrtWBs7f0iOGrxO/3alQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=iVEuiwYQwnseWpjmazVcr598DjTpv7Cf9Z3K7ZXzXiA=;
 b=PtuIsN/Lv6OpQ3Se0ybF0U6T5aOFp8anuQrkHZv5HIc3+7U5u8LKu6EN5vPP27jV+zV+oIHUsXiC4kGLx1dMzeuItgjgqSI5eTt9mpfMLOiuZSn9IOnwDOdmbcvJhP2vH+dFIc1KAY494KXtqDGZa8qdcE1E8oDhsrtXgFozhkw3EyK4RD7glG0cltRiGXvUv96RfhspIGo5ouC/vKuyQaiZ7GisVRUn/HhEOK0VB1X9Bj6AVOSyh60O3gWizB0exDH6d+0QnYOUuClsTXlCYeRDJS2UEAzkrf6hA72mEL3z97uz4K3aiDPM/Mdd08eJblIth/PSlntUKd8CRBWh3w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=iVEuiwYQwnseWpjmazVcr598DjTpv7Cf9Z3K7ZXzXiA=;
 b=a02EbU8ov2dUeN62JYhqQzpKMquhGZvXpAd1p31GJXCOKNQbYdt4IbAvm+cExdFWqsunNaEFZNG9QG2SPUp1oD4L6Vm/o88ZQ2tmmP9uMfomfCcOvq8NxYoRUnxEhtkma3KGMfU7PGCg/eorjIp7FDsB9JAs7c/AhatM6/ukPw0=
Date: Fri, 15 Oct 2021 11:49:08 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Bertrand Marquis <Bertrand.Marquis@arm.com>, Ian Jackson
	<iwj@xenproject.org>, Paul Durrant <paul@xen.org>, Andrew Cooper
	<andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, "Julien
 Grall" <julien@xen.org>
Subject: Re: [PATCH v6 1/3] xen/vpci: Move ecam access functions to common
 code
Message-ID: <YWlOlK82Ko4Yfydw@MacBook-Air-de-Roger.local>
References: <cover.1634221830.git.bertrand.marquis@arm.com>
 <ced6f870dbfabcfe8584555cc80f9a37a0655a0c.1634221830.git.bertrand.marquis@arm.com>
 <20c73f4e-5a8b-c127-f3a7-b841f50b1a4a@suse.com>
 <6C71E132-0A78-4DA4-AA52-E62833912145@arm.com>
 <8a7d1370-ee58-8e95-efea-8e4162e1e5f7@suse.com>
 <152124C4-9A34-4F5B-B6C5-CBCC6A175665@arm.com>
 <9f0f8e0b-c989-d2ae-39eb-6784446fa6c3@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <9f0f8e0b-c989-d2ae-39eb-6784446fa6c3@suse.com>
X-ClientProxiedBy: LO2P265CA0428.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:a0::32) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 5ea4675e-8ca2-4939-0530-08d98fc10b3e
X-MS-TrafficTypeDiagnostic: DM6PR03MB4762:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <DM6PR03MB4762C984AA0238FE7F9A5F098FB99@DM6PR03MB4762.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: TV9sDthe1GIbbd7QET+H6qzidtRZAjNRHNZ4/paTIPzeGguYMCBuYxeQen3PVy6P5PhBieEVWhaeB1GVfDgxhe4Gv6Gh0FmUjQswVH8RaUkU5XCOvRAYP4eC4TOByflsjWzSmuvwsat8vwQURA5VDcVnY2dFgTBfTlLrOaz2MYzPPiOsUSLewGNbdNN33Vf3Q70xoydM8A7c0cNl6ruDd9pvovOa460vc83IVTruRMP9Dpxn8B2G9865fH+T2/h0MQpi6pb1BEuhUdIAQnWiSX+AUVeqsXgln7D3PlAc+RsLZAZnO17PV95JmDqPVbcZ9TBB+mJPogFzMXE7Fd473G5X+LIuuXtXfSiAD3QPdAIiEirMPiCo2aPz/bvnA0nakAvEX0EgOedmNH0vl+mRZvwM2KooixLqTGqc84YfCA9r5JkFQc2bcJS3uhVIANjJ6Suoc0mxllEwjc2d5ZBCJ9EomkLXk9KpZDO2wfhsOWnjGE8bDt8BSiwibzIAcXUER/4znjeP5WTcKwzRCypJvg6QIguCUulKChxjyp8Db8klPIp4sOtZcVUECxOxzdmLVQN9A98Q20SLAaI1ctCmVu+YABAVM6jgbGKBvLi6oRoWIKe24k5v5atfgpFiZ9vsy1gtvnz2CCb9mS29qoeQpg==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(53546011)(82960400001)(86362001)(4326008)(316002)(8676002)(5660300002)(508600001)(26005)(66946007)(9686003)(66556008)(6486002)(54906003)(6496006)(66476007)(83380400001)(186003)(8936002)(38100700002)(6666004)(85182001)(2906002)(956004)(6916009);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WWQzdnhURitRSFNtVWZhR3lzZlVyOXFlOG15VVVHaXV1NTBGbnhOaythVGta?=
 =?utf-8?B?eG9lL1NYWTljbGFIRTlyL0hqZEN0ckJiSEwvOWo3a3dSNElITU00WDAyWXNx?=
 =?utf-8?B?Rzd0dXgrNTJIZ25JTE9jcUhBWkxKbzdrSFJEMVpKeVc4aS9GVDhxdEowVnZj?=
 =?utf-8?B?THk0STNyMjNQTUVqQ1B2OXkxbFdHSVNoY2tjR25xekorWVo4OXpMRk8zWk5z?=
 =?utf-8?B?OXBhTnZ3TU5HM2d1L3ROQ1N1ZHcyVk92cVJLczZwSWNaQTFjKzh5Z3ZzYXlR?=
 =?utf-8?B?NTdBSGpTQmtOaU5HZ1lqdVZuQkNRN3YvdnN2eG9RT1ZYNVg2TG1xSi80YWFw?=
 =?utf-8?B?bW5ISHVwRzBlMHV2eWJmekRVZGZFYkkyYUtwQXo5RTdoUDdONGtsUFdEZGI4?=
 =?utf-8?B?b3hqWTFWTVlJUUE3RE9lcWdpS3E4ZFpVNUZSRVpnc0hpazRvcVFvdnlYdndL?=
 =?utf-8?B?c2M1T3V5OFNMQ0RMeXVYZ1Q4eHdKQi9ieTlBWFhJSUEydVpuSjNycU0zcFRV?=
 =?utf-8?B?QkpqMFlPTW8rRXBzaGdKZjhOTk1DbkNYMjVadXhEK3R2ZDgyNEdCUkNqZmlm?=
 =?utf-8?B?Q1NKNWM1VVZ2ZUk2VFZweVJNWjQ4YUM2STd3VHhQKzlsYTQvckFFbjROQjhM?=
 =?utf-8?B?cjdkdHczYW1zV1FDNkdaaHJGNUlFdUxmbTFkd0RTNFViaC9PRU55bWEwVThU?=
 =?utf-8?B?aVFhWDRXZ28wTWp2Qkh6dTZzdnU0VFJ0SjdsRHNEQmlVek4wQ0x2OXc2cDJ2?=
 =?utf-8?B?T3F6NXJJUVRsb3hBZTg1T1NNS293Tk1YcVJJV1NZYk5lOEE5bk1DeGZDSkZ6?=
 =?utf-8?B?U1p5NE12YSt2bWhudHVKT01xdm9nLzhLR0lSOE5kVWFkOExTL1E5V2lHZTR6?=
 =?utf-8?B?K0JMRDhLY3JVT1lNM2FsU0UrRitNVUNEZFhib09hZjk0a0RkOWs5Z29QUzJ6?=
 =?utf-8?B?ekJQQmFmSytCSlJ2aXFRS3ZEVUd0Vk5zeTFubGxEdjNRYkRJenRTMUJEeWs1?=
 =?utf-8?B?RTFHMmVjRitUWS9uMmloU2diSWZuOVFVUkR5cVQ2SStZQlVYd01wQWVXMDVI?=
 =?utf-8?B?VDVPQ1pscXV0eG9VdEdiUWMyb24yTCtFK0tNcU9MMEl0T3U0bkFFY2tBL29q?=
 =?utf-8?B?TzlBSUxQczdKYytSRWkzVTZvcHVkTFBueXMrS0RGbENYTlNKV0RtMWJCNFNj?=
 =?utf-8?B?ZjFlT1dDeFBCNDUrakdJRktaaUtqaUhNcDI5VTZqMTdPeUxvbTlEMmo4NStJ?=
 =?utf-8?B?cmE1TVRLTmcxeEJINzlyZ0NVVnlGcWFEbGhycnlPNDhXN0owZGpuejFja1ZY?=
 =?utf-8?B?Q0lTZGdna1VSVWhnVUlSYTEyOVVscTNNWmhYQVNGTUNHVFdteWg0UE1hVmhk?=
 =?utf-8?B?TVRRY0g2NzdDNklXVHluMkppR1VSK2I2U29vM0xtNkpPQW81ZVFUTWVxdTZ0?=
 =?utf-8?B?WjRaeHpzLzBTL1h6enQvRTRkWG9ZUXI4Z0pYaUFBeE1URmtZVDFDdWluSW8r?=
 =?utf-8?B?Vm5mb21GZjdIU1ZBN2tXd0V1MWNUVm03VElIK3dDNUFoVjBkeE1sVkprL1Bw?=
 =?utf-8?B?MWN3d2krajlKNGpLWHhmZFhBVUhTVGY1dEl5VGtCeVdOZ2RwMkNiT3BUZlYw?=
 =?utf-8?B?Z005RWhzekxhaWlnUTdPRWFYTkhxemhINlBrTkgxaHd6N21GK2MxUTJaeFJ0?=
 =?utf-8?B?TDd1MWdJZ2cyNm9GUGVnMGYvY3JEYXgvU285aVJUazk5aEFSY1Z0OHBBd21W?=
 =?utf-8?Q?O471Wzro32b5Pfxj3iZ6XGNaBm5xPmdLuTFhb6e?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 5ea4675e-8ca2-4939-0530-08d98fc10b3e
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2021 09:49:13.1770
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: nA3bXFQrrA/8j90Mp3zGAcRkywgGqWMMupHXxHS8l/uJ/IVrDYAAg9nZEkNC24Ry1ztA04YFnU7uu7wEEIyLZw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4762
X-OriginatorOrg: citrix.com

On Fri, Oct 15, 2021 at 10:13:24AM +0200, Jan Beulich wrote:
> On 15.10.2021 09:37, Bertrand Marquis wrote:
> >> On 15 Oct 2021, at 07:29, Jan Beulich <jbeulich@suse.com> wrote:
> >> On 14.10.2021 19:09, Bertrand Marquis wrote:
> >>>> On 14 Oct 2021, at 17:06, Jan Beulich <jbeulich@suse.com> wrote:
> >>>> On 14.10.2021 16:49, Bertrand Marquis wrote:
> >>>>> @@ -305,7 +291,7 @@ static int vpci_portio_read(const struct hvm_io_handler *handler,
> >>>>>
> >>>>>    reg = hvm_pci_decode_addr(cf8, addr, &sbdf);
> >>>>>
> >>>>> -    if ( !vpci_access_allowed(reg, size) )
> >>>>> +    if ( !vpci_ecam_access_allowed(reg, size) )
> >>>>>        return X86EMUL_OKAY;
> >>>>>
> >>>>>    *data = vpci_read(sbdf, reg, size);
> >>>>> @@ -335,7 +321,7 @@ static int vpci_portio_write(const struct hvm_io_handler *handler,
> >>>>>
> >>>>>    reg = hvm_pci_decode_addr(cf8, addr, &sbdf);
> >>>>>
> >>>>> -    if ( !vpci_access_allowed(reg, size) )
> >>>>> +    if ( !vpci_ecam_access_allowed(reg, size) )
> >>>>>        return X86EMUL_OKAY;
> >>>>>
> >>>>>    vpci_write(sbdf, reg, size, data);
> >>>>
> >>>> Why would port I/O functions call an ECAM helper? And in how far is
> >>>> that helper actually ECAM-specific?
> >>>
> >>> The function was global before.
> >>
> >> I'm not objecting to the function being global, but to the "ecam" in
> >> its name.
> > 
> > Adding ecam in the name was a request from Roger.
> > This is just a consequence of this.
> 
> Roger - did you have in mind the uses here when asking for the addition
> of "ecam"?

I didn't realize it was also used by the IO ports accessors. Strictly
speaking 64bit accesses (lenght == 8) shouldn't be possible/allowed
from IO ports, but that's a red herring.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Fri Oct 15 09:52:53 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 09:52:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.210064.366773 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbJtU-0006JM-0w; Fri, 15 Oct 2021 09:52:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 210064.366773; Fri, 15 Oct 2021 09:52:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbJtT-0006JF-UH; Fri, 15 Oct 2021 09:52:51 +0000
Received: by outflank-mailman (input) for mailman id 210064;
 Fri, 15 Oct 2021 09:52:50 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Fqmt=PD=arm.com=Bertrand.Marquis@srs-us1.protection.inumbo.net>)
 id 1mbJtS-0006J9-4u
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 09:52:50 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com (unknown
 [40.107.6.80]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 83e9a08b-327f-4b4c-a312-01921892b614;
 Fri, 15 Oct 2021 09:52:47 +0000 (UTC)
Received: from AM6P192CA0082.EURP192.PROD.OUTLOOK.COM (2603:10a6:209:8d::23)
 by AM8PR08MB6497.eurprd08.prod.outlook.com (2603:10a6:20b:316::9) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16; Fri, 15 Oct
 2021 09:52:46 +0000
Received: from AM5EUR03FT049.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:209:8d:cafe::8b) by AM6P192CA0082.outlook.office365.com
 (2603:10a6:209:8d::23) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16 via Frontend
 Transport; Fri, 15 Oct 2021 09:52:46 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM5EUR03FT049.mail.protection.outlook.com (10.152.17.130) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.15 via Frontend Transport; Fri, 15 Oct 2021 09:52:44 +0000
Received: ("Tessian outbound 16951d3c485e:v103");
 Fri, 15 Oct 2021 09:52:44 +0000
Received: from 79ea2e6d09ba.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 3129DF6D-ACB7-4CF1-A756-8302EE20944C.1; 
 Fri, 15 Oct 2021 09:52:34 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 79ea2e6d09ba.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 15 Oct 2021 09:52:34 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com (2603:10a6:4:74::9)
 by DBAPR08MB5671.eurprd08.prod.outlook.com (2603:10a6:10:1a1::15) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.17; Fri, 15 Oct
 2021 09:52:28 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955]) by DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955%4]) with mapi id 15.20.4587.031; Fri, 15 Oct 2021
 09:52:28 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 83e9a08b-327f-4b4c-a312-01921892b614
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=S55r22TSjYYu/fgsnHE+cmSNZhFGMrXN/0af2COC6OA=;
 b=3AQ12s2L/RO26FKUimTmRcThTKzH/6BPcvo4W/etx0Tlqycpixo7CGDw949EbsZcIadMhIZHHdfDEPQ/36cZMVp9KnvGuZV1D+jgXL1mcWEjqHuQ8dAI179e0XDPZnZAHpGk109SQEwhVwES7tc/T58HRL1cvellMNvopcMpTfk=
X-MS-Exchange-Authentication-Results: spf=temperror (sender IP is
 63.35.35.123) smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass
 (signature was verified) header.d=armh.onmicrosoft.com;lists.xenproject.org;
 dmarc=temperror action=none header.from=arm.com;
Received-SPF: TempError (protection.outlook.com: error in processing during
 lookup of arm.com: DNS Timeout)
X-CheckRecipientChecked: true
X-CR-MTA-CID: 2a9ebeebef34fb41
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=gSsWdRkrpQ8Aty0GDEOm6uHs2Wc6gPCKpaC9J7LCVIj8usF5ck46o87UR56hckLy8X+Oi65E6/txS0AI0L1qZJoQyBb/RKMtgys2GP1Z2SB9mM2EhBmVjmcjcB4p4SDt4HyKIUqZksJwG/l4PApndI15uc2UWdQFSV1+JyQQz6oeVNRrWBXNp84abJNaPNOkRlhfeqhrtNt/dCZ4mjd0UHjCdUAg+xdmtsqAyeHOl8aYWXlnJQ0l7Sm9S3hyQRivf7EtBdpzoADa7ZjMs5LM6xy47XeHOy1xW8sLDdSo2UGB8cCS8Nb838YEjlxEyRFC/vUp8bfl6UZ5QwjH3XEPCg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=S55r22TSjYYu/fgsnHE+cmSNZhFGMrXN/0af2COC6OA=;
 b=Knc7P1Iq+u9mkCwDy4f+TzfYgAqVljJSEOx8D2bwlw8rH5ld3v8SNMhgAqHLKl+rA63U/atbyc58IMANj2F9coJZctK0dQWZdaR9J/P5PTI11m5Ek8OUAfob/gvH4iZ6Nccw0Wx8xBaf/oFcVIijfv/gWyFgdF5NF1DQ4MZJxYPbQZbKmqTL+uh/n9KkAs+6NUl/2/CDSeey1oqqFO5fJ4BU0D/SNTKoF13rFxVKQCdhpJ+0kwOCPCzzMIXwXa0ktYzOlpvzrKYS/BeryFuBDHaRNk1wVO2zBs7xLKfCh+Rcqi01cGwexassnro3EQPbFy2A4/CAKJ5EsJz52S/skg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=S55r22TSjYYu/fgsnHE+cmSNZhFGMrXN/0af2COC6OA=;
 b=3AQ12s2L/RO26FKUimTmRcThTKzH/6BPcvo4W/etx0Tlqycpixo7CGDw949EbsZcIadMhIZHHdfDEPQ/36cZMVp9KnvGuZV1D+jgXL1mcWEjqHuQ8dAI179e0XDPZnZAHpGk109SQEwhVwES7tc/T58HRL1cvellMNvopcMpTfk=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>, Ian Jackson
	<iwj@xenproject.org>, Rahul Singh <Rahul.Singh@arm.com>, Stefano Stabellini
	<sstabellini@kernel.org>, Julien Grall <julien@xen.org>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
	Wei Liu <wl@xen.org>, Paul Durrant <paul@xen.org>, Oleksandr Andrushchenko
	<Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH v6 2/3] xen/arm: Enable the existing x86 virtual PCI
 support for ARM.
Thread-Topic: [PATCH v6 2/3] xen/arm: Enable the existing x86 virtual PCI
 support for ARM.
Thread-Index: AQHXwQrjS6mPrKT7Q06z3N66FcsDAKvTvGsAgAAWOIA=
Date: Fri, 15 Oct 2021 09:52:28 +0000
Message-ID: <CD9B29B0-31FD-4E09-93E3-7124C724BC23@arm.com>
References: <cover.1634221830.git.bertrand.marquis@arm.com>
 <396b08e2598cf0338e0c7f4ad3cd5cb66db89224.1634221830.git.bertrand.marquis@arm.com>
 <YWk8uP/YuSee1MfG@MacBook-Air-de-Roger.local>
In-Reply-To: <YWk8uP/YuSee1MfG@MacBook-Air-de-Roger.local>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3654.120.0.1.13)
Authentication-Results-Original: citrix.com; dkim=none (message not signed)
 header.d=none;citrix.com; dmarc=none action=none header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: 7ae3d465-d097-4258-596a-08d98fc18958
x-ms-traffictypediagnostic: DBAPR08MB5671:|AM8PR08MB6497:
x-ms-exchange-transport-forked: True
X-Microsoft-Antispam-PRVS:
	<AM8PR08MB6497CD6D67969E08AC3926629DB99@AM8PR08MB6497.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:10000;OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 pXM0HpyDg/S28+xqdJfRE4mmjl9xEeqNr4YKICrg5WNFx+60KQeesjzFMqR163CDugACoBwFkjI6Cx9ge/cUGeIFMoiR+AAgZ46MZN9A2oHuWFdr5cPcKPL7/RogiDma54OyhlVzCumMVxuKASCmb5Nme4Mk6oZSLLSllRmCvMqc4FCJym/Vo7agSlOvCIowXwiqN4eBxWIeRgTw4RkwHem+U1doqMtZLbpiaEMKt8dkvv8RYo0cit+5deFUB2mg7iY47joYpQQqTMNGr/8AJNOnRkCb/WWw73n1fEYxlqmnxgARig0FG4KJKaBCQQ1HhUI6shp3aFDUB3LfCdtV73ufbggoKKqvK4Yv3W5pyqQbaIx9GejxcWFMVSIIx7t973Cp8GC8KqsL4QRKDA2bKhedfkmuxCwtahgq+OnlYGPOESpNqqP+7+AB+grlCoTOpvLB86yZHH+HEV2rSCDt47HgOHmW4gXG2B/gc1mWhDf6UE8f3sy9hKKb2n1hYG8iJcSMC5zpKfljYeP0t1mJpUTBAdav7Z7dTa6x1tdAykuxfhTCcEwuruyNT3UARxftU9Sp/SVmn31PLMfyrv0i5bSEPGcB1+rlWUrAGgFIi54BzvZeP7fBpXMHhU5XtQMblzN7ZSYMh3TaKW5wVvNOQ/1GfmiA20LU+Wx0lnKmUxUI6mxsOi8hPyYppsROMV4m0oMayH7QO/jq+sgFkvhwFMDI4Ca7TZN3gIvdxfPcT4g8O6U9EArY5OztLnvGQwKcvtvCVI4Oh8Uvl1ueDl5wASM9WR6IPk1GhKERh5lrbxIlybkLmy0j+Za5OYLwWd3D6/XyaYXBQXkeJgpRdZ9Duf0WYrPGyb0FveVMdLRhWIQI+uFdiI3nqXfhLUmM8MEfeWanejGCJU093ZMOX9K9zg==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB6PR0801MB2024.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(6486002)(54906003)(76116006)(71200400001)(38070700005)(66446008)(4326008)(66476007)(66556008)(64756008)(508600001)(66946007)(83380400001)(6916009)(316002)(2616005)(6512007)(53546011)(30864003)(38100700002)(86362001)(91956017)(36756003)(26005)(122000001)(186003)(6506007)(8936002)(7416002)(966005)(5660300002)(2906002)(33656002)(8676002)(2004002)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-ID: <5865F0674F957748AEC92AFF61E8646C@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR08MB5671
Original-Authentication-Results: citrix.com; dkim=none (message not signed)
 header.d=none;citrix.com; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM5EUR03FT049.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	cadfb87d-8e3f-4a91-d36e-08d98fc17fa7
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	CiapY7xbFgXRs66uVRUB4K9hbu/uVAeh6T9Y0XTDmm8Lirl45tZkio+h+r0VZG/T6voZXs/8in3BXDPr32o5BeszExCfcKuPzyDU/T1TzG78Uq7oHLyAzHBrluXFZIOxVxskajBtzDK4KshTmjVin7y1g1qfB4cbwJR2B8uxjO7Lg1PS0w47OguwAIDCPrJdAMxuB2gXsHB1e8K99DhWlXfh1yQ/RXER6THSJeFlsez0eA8AHJglaqRGypiKSg7DaTaoQ4vKPhGI60OhLlPbwD4VpWu7+9pHWRP3pr0QKwrv/oMTnms5eGplT3HAhil8RtOjdpQmObSWB2EcEjgUVSQ2+byU7xGAmBiN1lI8nnxzbL0Tr/aM/xn53B0da4yfSjtm+iv3cWMcSBo/2Zu4OH5LIhchRit0d2ClkQ2N+kLXCfhyMphDoA4iQ2ZTlpanAZebocaStAISHlrFcHXhgXAXSSwlh4MX+lfEsLntHDg361wglKta0YHGaN1SLTsbpoqM8+MIUfeZuMaCtAxJ/mznU6+wdWCv0e4SShbFTbW/mjpcLzJtmKAdB4VPcF4PdYNaGU4DjMAxjMDV+XA374rwTUC0NpwHX9eDqHZsSZci0P2t3uSsvZ+DwWIQOhG5gybALw4a4VXiPCj2Z3a/wZPBlkzxtTVIEXlfwtT5yvoPY0w7grKbjFAJ5kVEioV3RCgPXN2WX+I6hiLabmQJUoRZNBW5iDpKVXdq+4BIscMQmiwDDc1Y95XXsAQmjk3iBDxvD76peNAi7gHOess+qR5ZvBKObkjgjUqsLyWkTFknoGlZJEVPQShE95pQfEV10Gx0xEX+Te04YD6/jAMp54HOG/Ji1LuO94zouI2Pjq3Lky5Xas0eXKSDT7VQYerw
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(5660300002)(107886003)(47076005)(36860700001)(6506007)(33656002)(53546011)(356005)(86362001)(4326008)(81166007)(6486002)(6862004)(186003)(54906003)(30864003)(8676002)(82310400003)(316002)(63370400001)(26005)(63350400001)(508600001)(336012)(8936002)(2616005)(6512007)(966005)(70206006)(70586007)(2906002)(36756003)(83380400001)(2004002)(45980500001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2021 09:52:44.4734
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 7ae3d465-d097-4258-596a-08d98fc18958
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM5EUR03FT049.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB6497

SGkgUm9nZXIsDQoNCj4gT24gMTUgT2N0IDIwMjEsIGF0IDA5OjMyLCBSb2dlciBQYXUgTW9ubsOp
IDxyb2dlci5wYXVAY2l0cml4LmNvbT4gd3JvdGU6DQo+IA0KPiBPbiBUaHUsIE9jdCAxNCwgMjAy
MSBhdCAwMzo0OTo1MFBNICswMTAwLCBCZXJ0cmFuZCBNYXJxdWlzIHdyb3RlOg0KPj4gRnJvbTog
UmFodWwgU2luZ2ggPHJhaHVsLnNpbmdoQGFybS5jb20+DQo+PiANCj4+IFRoZSBleGlzdGluZyBW
UENJIHN1cHBvcnQgYXZhaWxhYmxlIGZvciBYODYgaXMgYWRhcHRlZCBmb3IgQXJtLg0KPj4gV2hl
biB0aGUgZGV2aWNlIGlzIGFkZGVkIHRvIFhFTiB2aWEgdGhlIGh5cGVyIGNhbGwNCj4+IOKAnFBI
WVNERVZPUF9wY2lfZGV2aWNlX2FkZOKAnSwgVlBDSSBoYW5kbGVyIGZvciB0aGUgY29uZmlnIHNw
YWNlDQo+PiBhY2Nlc3MgaXMgYWRkZWQgdG8gdGhlIFhlbiB0byBlbXVsYXRlIHRoZSBQQ0kgZGV2
aWNlcyBjb25maWcgc3BhY2UuDQo+PiANCj4+IEEgTU1JTyB0cmFwIGhhbmRsZXIgZm9yIHRoZSBQ
Q0kgRUNBTSBzcGFjZSBpcyByZWdpc3RlcmVkIGluIFhFTg0KPj4gc28gdGhhdCB3aGVuIGd1ZXN0
IGlzIHRyeWluZyB0byBhY2Nlc3MgdGhlIFBDSSBjb25maWcgc3BhY2UsWEVODQo+PiB3aWxsIHRy
YXAgdGhlIGFjY2VzcyBhbmQgZW11bGF0ZSByZWFkL3dyaXRlIHVzaW5nIHRoZSBWUENJIGFuZA0K
Pj4gbm90IHRoZSByZWFsIFBDSSBoYXJkd2FyZS4NCj4+IA0KPj4gRm9yIERvbTBsZXNzIHN5c3Rl
bXMgc2Nhbl9wY2lfZGV2aWNlcygpIHdvdWxkIGJlIHVzZWQgdG8gZGlzY292ZXIgdGhlDQo+PiBQ
Q0kgZGV2aWNlIGluIFhFTiBhbmQgVlBDSSBoYW5kbGVyIHdpbGwgYmUgYWRkZWQgZHVyaW5nIFhF
TiBib290cy4NCj4+IA0KPj4gVGhpcyBwYXRjaCBpcyBhbHNvIGRvaW5nIHNvbWUgc21hbGwgZml4
ZXMgdG8gZml4IGNvbXBpbGF0aW9uIGVycm9ycyBvbg0KPj4gYXJtMzIgb2YgdnBjaToNCj4+IC0g
YWRkIGEgY2FzdCB0byB1bnNpZ25lZCBsb25nIGluIHByaW50IGluIGhlYWRlci5jDQo+PiAtIGFk
ZCBhIGNhc3QgdG8gdWludDY0X3QgaW4gdnBjaV9lY2FtX21taW9fd3JpdGUNCj4+IA0KPj4gU2ln
bmVkLW9mZi1ieTogUmFodWwgU2luZ2ggPHJhaHVsLnNpbmdoQGFybS5jb20+DQo+PiBTaWduZWQt
b2ZmLWJ5OiBCZXJ0cmFuZCBNYXJxdWlzIDxiZXJ0cmFuZC5tYXJxdWlzQGFybS5jb20+DQo+PiAt
LS0NCj4+IENoYW5nZXMgaW4gdjY6DQo+PiAtIFVzZSBuZXcgdnBjaV9lY2FtXyBoZWxwZXJzIGZv
ciBQQ0kgYWNjZXNzDQo+PiAtIERvIG5vdCBzZXQgWEVOX0RPTUNUTF9DREZfdnBjaSBmb3IgZG9t
MCBmb3Igbm93ICh3aWxsIGJlIGRvbmUgaW4gYQ0KPj4gZnV0dXJlIHBhdGNoIG9uY2UgZXZlcnl0
aGluZyBpcyByZWFkeSkNCj4gDQo+IElzbid0IHRoZSBzZXJpZXMgbWlzc2luZyBhIHJldmVydCBv
ZiBYRU5fRE9NQ1RMX0NERl92cGNpPyBJIHRoaW5rDQo+IHRoYXQncyB3aGF0IHdlIGFncmVlZCB3
b3VsZCBiZSB0aGUgd2F5IGZvcndhcmQuDQoNCkEgc2VwYXJhdGUgcmV2ZXJzZSBwYXRjaCBmb3Ig
dGhhdCBoYXMgYWxyZWFkeSBiZWVuIG1lcmdlZDoNCmh0dHBzOi8veGVuYml0cy54ZW4ub3JnL2dp
dHdlYi8/cD14ZW4uZ2l0O2E9Y29tbWl0O2g9OTUxNmQwMWFjMzAxNWY1MjI1MjhlZDZkYWZiM2Y1
ODRlYWE3ZWQyYw0KDQo+IA0KPj4gLSByZW5hbWUgUkVHSVNURVJfT0ZGU0VUIHRvIEVDQU1fUkVH
X09GRlNFVCBhbmQgbW92ZSBpdCB0byBwY2kuaA0KPj4gLSByZW1vdmUgbm90IG5lZWRlZCBsb2Nh
bCB2YXJpYWJsZXMgaW4gdnBjaV9tbWlvX3dyaXRlLCB0aGUgb25lIGluIHJlYWQNCj4+IGhhcyBi
ZWVuIGtlcHQgdG8gZW5zdXJlIHByb3BlciBjb21waWxhdGlvbiBvbiBhcm0zMg0KPj4gLSBtb3Zl
IGNhbGwgdG8gdnBjaV9hZGRfaGFuZGxlcnMgYmVmb3JlIGlvbW11IGluaXQgdG8gc2ltcGxpZnkg
ZXhpdCBwYXRoDQo+PiAtIG1vdmUgY2FsbCB0byBwY2lfY2xlYW51cF9tc2kgaW4gdGhlIG91dCBz
ZWN0aW9uIG9mIHBjaV9hZGRfZGV2aWNlIGlmDQo+PiBwZGV2IGlzIG5vdCBOVUxMIGFuZCBvbiBl
cnJvcg0KPj4gLSBpbml0aWFsaXplIHBkZXYgdG8gTlVMTCB0byBoYW5kbGUgcHJvcGVybHkgZXhp
dCBwYXRoIGNhbGwgb2YNCj4+IHBjaV9jbGVhbnVwX21zaQ0KPj4gLSBrZWVwIGhhc192cGNpIHRv
IHJldHVybiBmYWxzZSBmb3Igbm93IGFzIENGR192cGNpIGhhcyBiZWVuIHJlbW92ZWQuDQo+PiBB
ZGRlZCBhIGNvbW1lbnQgb24gdG9wIG9mIHRoZSBkZWZpbml0aW9uLg0KPj4gLSBmaXggY29tcGls
YXRpb24gZXJyb3JzIG9uIGFybTMyIChwcmludCBpbiBoZWFkZXIuYywgY2FzdCBtaXNzaW5nIGlu
DQo+PiBtbWlvX3dyaXRlLg0KPj4gLSBsb2NhbCB2YXJpYWJsZSB3YXMga2VwdCBpbiB2cGNpX21t
aW9fcmVhZCBvbiBhcm0gdG8gcHJldmVudCBhIGNhc3QNCj4+IGVycm9yIGluIGFybTMyLg0KPj4g
Q2hhbmdlIGluIHY1Og0KPj4gLSBBZGQgcGNpX2NsZWFudXBfbXNpKHBkZXYpIGluY2xlYW51cCBw
YXJ0Lg0KPj4gLSBBZGRlZCBSZXZpZXdlZC1ieTogU3RlZmFubyBTdGFiZWxsaW5pIDxzc3RhYmVs
bGluaUBrZXJuZWwub3JnPg0KPj4gQ2hhbmdlIGluIHY0Og0KPj4gLSBNb3ZlIGFkZGl0aW9uIG9m
IFhFTl9ET01DVExfQ0RGX3ZwY2kgZmxhZyB0byBzZXBhcmF0ZSBwYXRjaA0KPj4gQ2hhbmdlIGlu
IHYzOg0KPj4gLSBVc2UgaXNfcGNpX3Bhc3N0aHJvdWdoX2VuYWJsZWQoKSBpbiBwbGFjZSBvZiBw
Y2lfcGFzc3Rocm91Z2hfZW5hYmxlZCB2YXJpYWJsZQ0KPj4gLSBSZWplY3QgWEVOX0RPTUNUTF9D
REZfdnBjaSBmb3IgeDg2IGluIGFyY2hfc2FuaXRpc2VfZG9tYWluX2NvbmZpZygpDQo+PiAtIFJl
bW92ZSBJU19FTkFCTEVEKENPTkZJR19IQVNfVlBDSSkgZnJvbSBoYXNfdnBjaSgpDQo+PiBDaGFu
Z2UgaW4gdjI6DQo+PiAtIEFkZCBuZXcgWEVOX0RPTUNUTF9DREZfdnBjaSBmbGFnDQo+PiAtIG1v
ZGlmeSBoYXNfdnBjaSgpIHRvIGluY2x1ZGUgWEVOX0RPTUNUTF9DREZfdnBjaQ0KPj4gLSBlbmFi
bGUgdnBjaSBzdXBwb3J0IHdoZW4gcGNpLXBhc3N0aG91Z2ggb3B0aW9uIGlzIGVuYWJsZWQuDQo+
PiAtLS0NCj4+IC0tLQ0KPj4geGVuL2FyY2gvYXJtL01ha2VmaWxlICAgICAgICAgfCAgMSArDQo+
PiB4ZW4vYXJjaC9hcm0vZG9tYWluLmMgICAgICAgICB8ICA0ICsrDQo+PiB4ZW4vYXJjaC9hcm0v
dnBjaS5jICAgICAgICAgICB8IDc0ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr
DQo+PiB4ZW4vYXJjaC9hcm0vdnBjaS5oICAgICAgICAgICB8IDM2ICsrKysrKysrKysrKysrKysr
DQo+PiB4ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC9wY2kuYyB8IDE4ICsrKysrKysrLQ0KPj4geGVu
L2RyaXZlcnMvdnBjaS9oZWFkZXIuYyAgICAgfCAgMyArLQ0KPj4geGVuL2RyaXZlcnMvdnBjaS92
cGNpLmMgICAgICAgfCAgMiArLQ0KPj4geGVuL2luY2x1ZGUvYXNtLWFybS9kb21haW4uaCAgfCAg
MSArDQo+PiB4ZW4vaW5jbHVkZS9hc20teDg2L3BjaS5oICAgICB8ICAyIC0NCj4+IHhlbi9pbmNs
dWRlL3B1YmxpYy9hcmNoLWFybS5oIHwgIDcgKysrKw0KPj4geGVuL2luY2x1ZGUveGVuL3BjaS5o
ICAgICAgICAgfCAgMyArKw0KPj4gMTEgZmlsZXMgY2hhbmdlZCwgMTQ2IGluc2VydGlvbnMoKyks
IDUgZGVsZXRpb25zKC0pDQo+PiBjcmVhdGUgbW9kZSAxMDA2NDQgeGVuL2FyY2gvYXJtL3ZwY2ku
Yw0KPj4gY3JlYXRlIG1vZGUgMTAwNjQ0IHhlbi9hcmNoL2FybS92cGNpLmgNCj4+IA0KPj4gZGlm
ZiAtLWdpdCBhL3hlbi9hcmNoL2FybS9NYWtlZmlsZSBiL3hlbi9hcmNoL2FybS9NYWtlZmlsZQ0K
Pj4gaW5kZXggNjQ1MTg4NDhiMi4uMDdmNjM0NTA4ZSAxMDA2NDQNCj4+IC0tLSBhL3hlbi9hcmNo
L2FybS9NYWtlZmlsZQ0KPj4gKysrIGIveGVuL2FyY2gvYXJtL01ha2VmaWxlDQo+PiBAQCAtNyw2
ICs3LDcgQEAgaWZuZXEgKCQoQ09ORklHX05PX1BMQVQpLHkpDQo+PiBvYmoteSArPSBwbGF0Zm9y
bXMvDQo+PiBlbmRpZg0KPj4gb2JqLSQoQ09ORklHX1RFRSkgKz0gdGVlLw0KPj4gK29iai0kKENP
TkZJR19IQVNfVlBDSSkgKz0gdnBjaS5vDQo+PiANCj4+IG9iai0kKENPTkZJR19IQVNfQUxURVJO
QVRJVkUpICs9IGFsdGVybmF0aXZlLm8NCj4+IG9iai15ICs9IGJvb3RmZHQuaW5pdC5vDQo+PiBk
aWZmIC0tZ2l0IGEveGVuL2FyY2gvYXJtL2RvbWFpbi5jIGIveGVuL2FyY2gvYXJtL2RvbWFpbi5j
DQo+PiBpbmRleCBlZWYwNjYxYmViLi45NmUxYjIzNTUwIDEwMDY0NA0KPj4gLS0tIGEveGVuL2Fy
Y2gvYXJtL2RvbWFpbi5jDQo+PiArKysgYi94ZW4vYXJjaC9hcm0vZG9tYWluLmMNCj4+IEBAIC0z
OSw2ICszOSw3IEBADQo+PiAjaW5jbHVkZSA8YXNtL3ZnaWMuaD4NCj4+ICNpbmNsdWRlIDxhc20v
dnRpbWVyLmg+DQo+PiANCj4+ICsjaW5jbHVkZSAidnBjaS5oIg0KPj4gI2luY2x1ZGUgInZ1YXJ0
LmgiDQo+PiANCj4+IERFRklORV9QRVJfQ1BVKHN0cnVjdCB2Y3B1ICosIGN1cnJfdmNwdSk7DQo+
PiBAQCAtNzczLDYgKzc3NCw5IEBAIGludCBhcmNoX2RvbWFpbl9jcmVhdGUoc3RydWN0IGRvbWFp
biAqZCwNCj4+ICAgICBpZiAoIGlzX2hhcmR3YXJlX2RvbWFpbihkKSAmJiAocmMgPSBkb21haW5f
dnVhcnRfaW5pdChkKSkgKQ0KPj4gICAgICAgICBnb3RvIGZhaWw7DQo+PiANCj4+ICsgICAgaWYg
KCAocmMgPSBkb21haW5fdnBjaV9pbml0KGQpKSAhPSAwICkNCj4+ICsgICAgICAgIGdvdG8gZmFp
bDsNCj4+ICsNCj4+ICAgICByZXR1cm4gMDsNCj4+IA0KPj4gZmFpbDoNCj4+IGRpZmYgLS1naXQg
YS94ZW4vYXJjaC9hcm0vdnBjaS5jIGIveGVuL2FyY2gvYXJtL3ZwY2kuYw0KPj4gbmV3IGZpbGUg
bW9kZSAxMDA2NDQNCj4+IGluZGV4IDAwMDAwMDAwMDAuLjdjMzU1MmI2NWQNCj4+IC0tLSAvZGV2
L251bGwNCj4+ICsrKyBiL3hlbi9hcmNoL2FybS92cGNpLmMNCj4+IEBAIC0wLDAgKzEsNzQgQEAN
Cj4+ICsvKg0KPj4gKyAqIHhlbi9hcmNoL2FybS92cGNpLmMNCj4+ICsgKg0KPj4gKyAqIFRoaXMg
cHJvZ3JhbSBpcyBmcmVlIHNvZnR3YXJlOyB5b3UgY2FuIHJlZGlzdHJpYnV0ZSBpdCBhbmQvb3Ig
bW9kaWZ5DQo+PiArICogaXQgdW5kZXIgdGhlIHRlcm1zIG9mIHRoZSBHTlUgR2VuZXJhbCBQdWJs
aWMgTGljZW5zZSBhcyBwdWJsaXNoZWQgYnkNCj4+ICsgKiB0aGUgRnJlZSBTb2Z0d2FyZSBGb3Vu
ZGF0aW9uOyBlaXRoZXIgdmVyc2lvbiAyIG9mIHRoZSBMaWNlbnNlLCBvcg0KPj4gKyAqIChhdCB5
b3VyIG9wdGlvbikgYW55IGxhdGVyIHZlcnNpb24uDQo+PiArICoNCj4+ICsgKiBUaGlzIHByb2dy
YW0gaXMgZGlzdHJpYnV0ZWQgaW4gdGhlIGhvcGUgdGhhdCBpdCB3aWxsIGJlIHVzZWZ1bCwNCj4+
ICsgKiBidXQgV0lUSE9VVCBBTlkgV0FSUkFOVFk7IHdpdGhvdXQgZXZlbiB0aGUgaW1wbGllZCB3
YXJyYW50eSBvZg0KPj4gKyAqIE1FUkNIQU5UQUJJTElUWSBvciBGSVRORVNTIEZPUiBBIFBBUlRJ
Q1VMQVIgUFVSUE9TRS4gIFNlZSB0aGUNCj4+ICsgKiBHTlUgR2VuZXJhbCBQdWJsaWMgTGljZW5z
ZSBmb3IgbW9yZSBkZXRhaWxzLg0KPj4gKyAqLw0KPj4gKyNpbmNsdWRlIDx4ZW4vc2NoZWQuaD4N
Cj4+ICsjaW5jbHVkZSA8eGVuL3ZwY2kuaD4NCj4+ICsNCj4+ICsjaW5jbHVkZSA8YXNtL21taW8u
aD4NCj4+ICsNCj4+ICtzdGF0aWMgaW50IHZwY2lfbW1pb19yZWFkKHN0cnVjdCB2Y3B1ICp2LCBt
bWlvX2luZm9fdCAqaW5mbywNCj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgIHJlZ2lzdGVy
X3QgKnIsIHZvaWQgKnApDQo+PiArew0KPj4gKyAgICBwY2lfc2JkZl90IHNiZGY7DQo+PiArICAg
IC8qIGRhdGEgaXMgbmVlZGVkIHRvIHByZXZlbnQgYSBwb2ludGVyIGNhc3Qgb24gMzJiaXQgKi8N
Cj4+ICsgICAgdW5zaWduZWQgbG9uZyBkYXRhID0gfjB1bDsNCj4+ICsgICAgaW50IHJldDsNCj4+
ICsNCj4+ICsgICAgLyogV2UgaWdub3JlIHNlZ21lbnQgcGFydCBhbmQgYWx3YXlzIGhhbmRsZSBz
ZWdtZW50IDAgKi8NCj4+ICsgICAgc2JkZi5zYmRmID0gRUNBTV9CREYoaW5mby0+Z3BhKTsNCj4+
ICsNCj4+ICsgICAgcmV0ID0gdnBjaV9lY2FtX21taW9fcmVhZChzYmRmLCBFQ0FNX1JFR19PRkZT
RVQoaW5mby0+Z3BhKSwNCj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAxVSA8PCBp
bmZvLT5kYWJ0LnNpemUsICZkYXRhKTsNCj4+ICsNCj4+ICsgICAgKnIgPSBkYXRhOw0KPj4gKw0K
Pj4gKyAgICByZXR1cm4gcmV0Ow0KPj4gK30NCj4+ICsNCj4+ICtzdGF0aWMgaW50IHZwY2lfbW1p
b193cml0ZShzdHJ1Y3QgdmNwdSAqdiwgbW1pb19pbmZvX3QgKmluZm8sDQo+PiArICAgICAgICAg
ICAgICAgICAgICAgICAgICAgcmVnaXN0ZXJfdCByLCB2b2lkICpwKQ0KPj4gK3sNCj4+ICsgICAg
cGNpX3NiZGZfdCBzYmRmOw0KPj4gKw0KPj4gKyAgICAvKiBXZSBpZ25vcmUgc2VnbWVudCBwYXJ0
IGFuZCBhbHdheXMgaGFuZGxlIHNlZ21lbnQgMCAqLw0KPj4gKyAgICBzYmRmLnNiZGYgPSBFQ0FN
X0JERihpbmZvLT5ncGEpOw0KPj4gKw0KPj4gKyAgICByZXR1cm4gdnBjaV9lY2FtX21taW9fd3Jp
dGUoc2JkZiwgRUNBTV9SRUdfT0ZGU0VUKGluZm8tPmdwYSksDQo+PiArICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAxVSA8PCBpbmZvLT5kYWJ0LnNpemUsIHIpOw0KPj4gK30NCj4gDQo+
IEknbSBub3Qgc3VyZSByZXR1cm5pbmcgYW4gZXJyb3IgdmFsdWUgaGVyZSBpcyBoZWxwZnVsLCBh
cyBJJ20gbm90IHN1cmUNCj4gaG93IG5hdGl2ZSBBcm0gYmVoYXZlcyBhbmQgaG93IHRoaXMgZXJy
b3IgaXMgcHJvcGFnYXRlZCBpbnRvIHRoZQ0KPiBndWVzdC4gRldJV3JldHVybmluZyB+MCBvciBk
cm9wcGluZyB3cml0ZXMgaXMgd2hhdCB3ZSBkbyBpbiB4ODYgd2hlbg0KPiB2UENJIGlzIG5vdCBj
YXBhYmxlIG9mIGhhbmRsaW5nIHRoZSBhY2Nlc3MuDQoNCk1taW8gaGFuZGxlcnMgY2FuIHRha2Ug
YSByZXR1cm4gY29kZSBvbiBhcm0gaWYgc29tZXRoaW5nIGRpZCBub3Qgd29yaw0Kc28gSSB0aGlu
ayB0aGlzIGlzIHRoZSByaWdodCB3YXkgdG8gZG8gaXQgb24gYXJtLg0KTm93IGhhcyBhZ3JlZWQg
d2l0aCBKYW4sIHdlIHdpbGwgY2hhbmdlIHRoZSByZXR1cm4gdHlwZSBvZiANCnZwY2lfZWNhbV93
cml0ZSAoYWxzbyByZW5hbWVkKSB0byBiZSBhIGJvb2xlYW4uDQoNCj4gDQo+PiArDQo+PiArc3Rh
dGljIGNvbnN0IHN0cnVjdCBtbWlvX2hhbmRsZXJfb3BzIHZwY2lfbW1pb19oYW5kbGVyID0gew0K
Pj4gKyAgICAucmVhZCAgPSB2cGNpX21taW9fcmVhZCwNCj4+ICsgICAgLndyaXRlID0gdnBjaV9t
bWlvX3dyaXRlLA0KPj4gK307DQo+PiArDQo+PiAraW50IGRvbWFpbl92cGNpX2luaXQoc3RydWN0
IGRvbWFpbiAqZCkNCj4+ICt7DQo+PiArICAgIGlmICggIWhhc192cGNpKGQpICkNCj4+ICsgICAg
ICAgIHJldHVybiAwOw0KPj4gKw0KPj4gKyAgICByZWdpc3Rlcl9tbWlvX2hhbmRsZXIoZCwgJnZw
Y2lfbW1pb19oYW5kbGVyLA0KPj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgR1VFU1RfVlBD
SV9FQ0FNX0JBU0UsIEdVRVNUX1ZQQ0lfRUNBTV9TSVpFLCBOVUxMKTsNCj4+ICsNCj4+ICsgICAg
cmV0dXJuIDA7DQo+PiArfQ0KPj4gKw0KPj4gKy8qDQo+PiArICogTG9jYWwgdmFyaWFibGVzOg0K
Pj4gKyAqIG1vZGU6IEMNCj4+ICsgKiBjLWZpbGUtc3R5bGU6ICJCU0QiDQo+PiArICogYy1iYXNp
Yy1vZmZzZXQ6IDQNCj4+ICsgKiBpbmRlbnQtdGFicy1tb2RlOiBuaWwNCj4+ICsgKiBFbmQ6DQo+
PiArICovDQo+PiArDQo+PiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gvYXJtL3ZwY2kuaCBiL3hlbi9h
cmNoL2FybS92cGNpLmgNCj4+IG5ldyBmaWxlIG1vZGUgMTAwNjQ0DQo+PiBpbmRleCAwMDAwMDAw
MDAwLi5kOGE3YjBlM2U4DQo+PiAtLS0gL2Rldi9udWxsDQo+PiArKysgYi94ZW4vYXJjaC9hcm0v
dnBjaS5oDQo+PiBAQCAtMCwwICsxLDM2IEBADQo+PiArLyoNCj4+ICsgKiB4ZW4vYXJjaC9hcm0v
dnBjaS5oDQo+PiArICoNCj4+ICsgKiBUaGlzIHByb2dyYW0gaXMgZnJlZSBzb2Z0d2FyZTsgeW91
IGNhbiByZWRpc3RyaWJ1dGUgaXQgYW5kL29yIG1vZGlmeQ0KPj4gKyAqIGl0IHVuZGVyIHRoZSB0
ZXJtcyBvZiB0aGUgR05VIEdlbmVyYWwgUHVibGljIExpY2Vuc2UgYXMgcHVibGlzaGVkIGJ5DQo+
PiArICogdGhlIEZyZWUgU29mdHdhcmUgRm91bmRhdGlvbjsgZWl0aGVyIHZlcnNpb24gMiBvZiB0
aGUgTGljZW5zZSwgb3INCj4+ICsgKiAoYXQgeW91ciBvcHRpb24pIGFueSBsYXRlciB2ZXJzaW9u
Lg0KPj4gKyAqDQo+PiArICogVGhpcyBwcm9ncmFtIGlzIGRpc3RyaWJ1dGVkIGluIHRoZSBob3Bl
IHRoYXQgaXQgd2lsbCBiZSB1c2VmdWwsDQo+PiArICogYnV0IFdJVEhPVVQgQU5ZIFdBUlJBTlRZ
OyB3aXRob3V0IGV2ZW4gdGhlIGltcGxpZWQgd2FycmFudHkgb2YNCj4+ICsgKiBNRVJDSEFOVEFC
SUxJVFkgb3IgRklUTkVTUyBGT1IgQSBQQVJUSUNVTEFSIFBVUlBPU0UuICBTZWUgdGhlDQo+PiAr
ICogR05VIEdlbmVyYWwgUHVibGljIExpY2Vuc2UgZm9yIG1vcmUgZGV0YWlscy4NCj4+ICsgKi8N
Cj4+ICsNCj4+ICsjaWZuZGVmIF9fQVJDSF9BUk1fVlBDSV9IX18NCj4+ICsjZGVmaW5lIF9fQVJD
SF9BUk1fVlBDSV9IX18NCj4+ICsNCj4+ICsjaWZkZWYgQ09ORklHX0hBU19WUENJDQo+PiAraW50
IGRvbWFpbl92cGNpX2luaXQoc3RydWN0IGRvbWFpbiAqZCk7DQo+PiArI2Vsc2UNCj4+ICtzdGF0
aWMgaW5saW5lIGludCBkb21haW5fdnBjaV9pbml0KHN0cnVjdCBkb21haW4gKmQpDQo+PiArew0K
Pj4gKyAgICByZXR1cm4gMDsNCj4+ICt9DQo+PiArI2VuZGlmDQo+PiArDQo+PiArI2VuZGlmIC8q
IF9fQVJDSF9BUk1fVlBDSV9IX18gKi8NCj4+ICsNCj4+ICsvKg0KPj4gKyAqIExvY2FsIHZhcmlh
YmxlczoNCj4+ICsgKiBtb2RlOiBDDQo+PiArICogYy1maWxlLXN0eWxlOiAiQlNEIg0KPj4gKyAq
IGMtYmFzaWMtb2Zmc2V0OiA0DQo+PiArICogaW5kZW50LXRhYnMtbW9kZTogbmlsDQo+PiArICog
RW5kOg0KPj4gKyAqLw0KPj4gZGlmZiAtLWdpdCBhL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL3Bj
aS5jIGIveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvcGNpLmMNCj4+IGluZGV4IDNhYThjMzE3NWYu
LjhjYzUyOWVjZWMgMTAwNjQ0DQo+PiAtLS0gYS94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC9wY2ku
Yw0KPj4gKysrIGIveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvcGNpLmMNCj4+IEBAIC02NTgsNyAr
NjU4LDcgQEAgaW50IHBjaV9hZGRfZGV2aWNlKHUxNiBzZWcsIHU4IGJ1cywgdTggZGV2Zm4sDQo+
PiAgICAgICAgICAgICAgICAgICAgY29uc3Qgc3RydWN0IHBjaV9kZXZfaW5mbyAqaW5mbywgbm9k
ZWlkX3Qgbm9kZSkNCj4+IHsNCj4+ICAgICBzdHJ1Y3QgcGNpX3NlZyAqcHNlZzsNCj4+IC0gICAg
c3RydWN0IHBjaV9kZXYgKnBkZXY7DQo+PiArICAgIHN0cnVjdCBwY2lfZGV2ICpwZGV2ID0gTlVM
TDsNCj4+ICAgICB1bnNpZ25lZCBpbnQgc2xvdCA9IFBDSV9TTE9UKGRldmZuKSwgZnVuYyA9IFBD
SV9GVU5DKGRldmZuKTsNCj4+ICAgICBjb25zdCBjaGFyICpwZGV2X3R5cGU7DQo+PiAgICAgaW50
IHJldDsNCj4+IEBAIC03NTIsNiArNzUyLDE5IEBAIGludCBwY2lfYWRkX2RldmljZSh1MTYgc2Vn
LCB1OCBidXMsIHU4IGRldmZuLA0KPj4gDQo+PiAgICAgY2hlY2tfcGRldihwZGV2KTsNCj4+IA0K
Pj4gKyNpZmRlZiBDT05GSUdfQVJNDQo+PiArICAgIC8qDQo+PiArICAgICAqIE9uIEFSTSBQQ0kg
ZGV2aWNlcyBkaXNjb3Zlcnkgd2lsbCBiZSBkb25lIGJ5IERvbTAuIEFkZCB2cGNpIGhhbmRsZXIg
d2hlbg0KPj4gKyAgICAgKiBEb20wIGluZm9ybSBYRU4gdG8gYWRkIHRoZSBQQ0kgZGV2aWNlcyBp
biBYRU4uDQo+PiArICAgICAqLw0KPj4gKyAgICByZXQgPSB2cGNpX2FkZF9oYW5kbGVycyhwZGV2
KTsNCj4+ICsgICAgaWYgKCByZXQgKQ0KPj4gKyAgICB7DQo+PiArICAgICAgICBwcmludGsoWEVO
TE9HX0VSUiAiU2V0dXAgb2YgdlBDSSBmYWlsZWQ6ICVkXG4iLCByZXQpOw0KPj4gKyAgICAgICAg
Z290byBvdXQ7DQo+PiArICAgIH0NCj4+ICsjZW5kaWYNCj4gDQo+IEkgdGhpbmsgdnBjaV9hZGRf
aGFuZGxlcnMgc2hvdWxkIGJlIGNhbGxlZCBhZnRlciBjaGVja2luZyB0aGF0DQo+IHBkZXYtPmRv
bWFpbiBpcyAhPSBOVUxMLCBzbyBJIHdvdWxkIG1vdmUgdGhpcyBjaHVuayBhIGJpdCBiZWxvdy4N
Cg0KT24gYXJtIHRoaXMgd291bGQgcHJldmVudCB0aGUgZG9tMGxlc3MgdXNlIGNhc2Ugb3IgdG8g
aGF2ZSB0aGUgUENJDQpidXMgZW51bWVyYXRlZCBmcm9tIGFuIG90aGVyIGRvbWFpbi4NCkBvbGVr
c2FuZHI6IGNhbiB5b3UgY29tbWVudCBvbiB0aGlzIG9uZSwgeW91IG1pZ2h0IGhhdmUgYSBiZXR0
ZXINCmFuc3dlciB0aGFuIG1lIG9uIHRoaXMgPw0KDQo+IA0KPj4gKw0KPj4gICAgIHJldCA9IDA7
DQo+PiAgICAgaWYgKCAhcGRldi0+ZG9tYWluICkNCj4+ICAgICB7DQo+PiBAQCAtNzg0LDYgKzc5
Nyw5IEBAIG91dDoNCj4+ICAgICAgICAgICAgICAgICAgICAmUENJX1NCREYoc2VnLCBidXMsIHNs
b3QsIGZ1bmMpKTsNCj4+ICAgICAgICAgfQ0KPj4gICAgIH0NCj4+ICsgICAgZWxzZSBpZiAoIHBk
ZXYgKQ0KPj4gKyAgICAgICAgcGNpX2NsZWFudXBfbXNpKHBkZXYpOw0KPiANCj4gSSdtIHNsaWdo
dGx5IGxvc3QgYXQgd2h5IHlvdSBhZGQgdGhpcyBjaHVuaywgaXMgdGhpcyBzdHJpY3RseSByZWxh
dGVkDQo+IHRvIHRoZSBwYXRjaD8NCg0KVGhpcyB3YXMgZGlzY3Vzc2VkIGEgbG90IGluIHByZXZp
b3VzIHZlcnNpb24gb2YgdGhlIHBhdGNoIGFuZA0KcmVxdWVzdGVkIGJ5IFN0ZWZhbm8uIFRoZSBp
ZGVhIGhlcmUgaXMgdGhhdCBhcyBzb29uIGFzIGhhbmRsZXJzDQphcmUgYWRkZWQgc29tZSBiaXRz
IG1pZ2h0IGJlIG1vZGlmaWVkIGluIHRoZSBQQ0kgY29uZmlnIHNwYWNlDQpsZWFkaW5nIHBvc3Np
Ymx5IHRvIG1zaSBpbnRlcnJ1cHRzLiBTbyBpdCBpcyBzYWZlciB0byBjbGVhbnVwIG9uIHRoZQ0K
ZXJyb3IgcGF0aC4gRm9yIHJlZmVyZW5jZXMgcGxlYXNlIHNlZSBkaXNjdXNzaW9uIG9uIHY0IGFu
ZCB2NSB3aGVyZQ0KdGhpcyB3YXMgYWN0dWFsbHkgYWRkZWQgKHRvIG11Y2ggcmVmZXJlbmNlcyBh
cyB0aGUgZGlzY3Vzc2lvbiB3YXMNCmxvbmcgc28gaGVyZSBbMV0gYW5kIFsyXSBhcmUgdGhlIHBh
dGNod29yayB0aHJlYWQpLg0KDQpbMV0gaHR0cHM6Ly9wYXRjaHdvcmsua2VybmVsLm9yZy9wcm9q
ZWN0L3hlbi1kZXZlbC9wYXRjaC85YmRjYTJjZGE1ZDJlODNmOTRkYzI0MjNlNTU3MTQyNzM1Mzk3
NjBhLjE2MzM1NDA4NDIuZ2l0LnJhaHVsLnNpbmdoQGFybS5jb20vDQpbMl0gaHR0cHM6Ly9wYXRj
aHdvcmsua2VybmVsLm9yZy9wcm9qZWN0L3hlbi1kZXZlbC9wYXRjaC9mMDkzZGU2ODFjMjU2MGE3
MTk2ODk1YmNkNjY2ZWY4ODQwODg1YzFkLjE2MzMzNDA3OTUuZ2l0LnJhaHVsLnNpbmdoQGFybS5j
b20vDQoNClJlZ2FyZHMNCkJlcnRyYW5kDQoNCg==


From xen-devel-bounces@lists.xenproject.org Fri Oct 15 09:54:00 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 09:54:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.210071.366784 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbJuX-0006wJ-Fs; Fri, 15 Oct 2021 09:53:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 210071.366784; Fri, 15 Oct 2021 09:53:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbJuX-0006wC-Cn; Fri, 15 Oct 2021 09:53:57 +0000
Received: by outflank-mailman (input) for mailman id 210071;
 Fri, 15 Oct 2021 09:53:56 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=UM5E=PD=citrix.com=roger.pau@srs-us1.protection.inumbo.net>)
 id 1mbJuW-0006vz-BA
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 09:53:56 +0000
Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id cece8754-2d9d-11ec-822c-12813bfff9fa;
 Fri, 15 Oct 2021 09:53:55 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: cece8754-2d9d-11ec-822c-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1634291635;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=cFT7MuVWqsioz3dLk2GIV0Q8jEBxk5Ryti6eH/nBGxw=;
  b=Q8xHXezpW0kj3EpNPumDCPMNJ0VExFFsP1yft1p6GRvCoT0fJmkc3x4u
   IcUkpD816N6H5ilubroDMsVFJEf5PVdsFFFo/7zygslzE7BhldWh8mAfI
   rasl53YJXqfzvC91DH2GYUnaifpeDFFtizdras41zAvQ/21h8a4lf2Z3i
   E=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: 0CoA2L2E0fZ6hI+eOTvPl7/5iiLcwAqavrJ84oFDIiICyygqoKBEhIryrPh6WLWfmTRj3olXUQ
 VdbhmAOU5tojjvTjB/mqBB23sB4u6tcFvf8Bq9ZFzJAgVf0ymYywLJyV2fpUr18SY8aNjMNtVK
 uWgHf2U7/bBUsCaMjVF3xte72WbG1qWdMYOIQXYyj14v/GSFNuw9m+QHEkOVDDjKqXpMJc8T1R
 jnDRvAvk+cNIFRCAwEVAn+t8LYzetEGp2zhw5slzB/W+b8ZMDEgP4ZA7EXdaCzt7Kik4CCLtrL
 pQUoL35NfiDf2o/HPejkVgcY
X-SBRS: 5.1
X-MesageID: 54836120
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:9YNXRqoPqgOFETNUQrpC24ze0m9eBmKHYhIvgKrLsJaIsI4StFCzt
 garIBmObPmMNGDxfopybtnn9kwD6p/RmtFnSwNl/nozQi1ApZuZCYyVIHmrMnLJJKUvbq7GA
 +byyDXkBJppJpMJjk71atANlZT4vE2xbuKU5NTsY0idfic5Dnd84f5fs7Rh2Ncx2YHkW1rlV
 e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL
 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9
 DlCnZKXdF0sfYrIoboyb0ZZHwVeLLJ+/6CSdBBTseTLp6HHW37lwvEoB0AqJ4wIvO1wBAmi9
 9RBdmpLNErawbvrnvTrEYGAhex6RCXvFJkYtXx6iynQEN4tQIzZQrWM7thdtNs1rp0STa2AP
 pBBAdZpRBb5WE0SOGk0MqsvhuOOmCLTcQUAt13A8MLb5ECMlVcsgdABKuH9YtWXQe1Fk0Deo
 XjJl0z7CBwHMN2UyRKe72mhwOTImEvTR4Y6BLC+sPlwjzW77GEJFAcfU1f9hPCjk1O/QPpWM
 UlS8S0rxYAi+UruQtTjUhmQpH+fogVaS9dWC/c96gyG1uzT+QnxLmkbTBZRZdo+rsg0SDc2k
 FiTkLvU6SdH6ePPDyjHr/HN8G30aXN9wXI+iTEsQyw4udygh4UK0D3zEddvNI6kkeXyBmSlq
 9yVlxQWi7IWhM8N8qy0+1Hbnj6hzqT0oh4JChb/BT39sFsoDGKxT8nxswKDtKcfRGqMZgDZ5
 CBspiSI0AwZ4XhhfgS2S+IRAKrh2f+BNDDN6bKEN8h8r2rzk5JPkIY53d2fGKuLGppbEdMKS
 BWK0e+02HO1FCD3BUOQS9jgY/nGNYC6SbzYugn8N7KimKRZeg6d5z1JbkWNxW3rm0VEufhhY
 svBKpz3UC9KU/oPIN+KqwE1iuJDKscWnju7eHwG507/jer2iIC9GN/pz2dinshmtfjZ8W05A
 v5UNteQygU3bQENSnK/zGLnFnhTdSJTLcmv86R/L7ffSiI7SDBJI6KAmtsJJt0695m5Y8+Vp
 xlRrGcDkwGh7ZAGQC3XAk1ehETHBsgi8yhiZnJxZD5FGRELOO6S0UvWTLNuFZEP/+1/1/9kC
 f4DfsSLGPNUTTrbvT8aaPHAQEZKLXxHXCqCYHioZiYRZZllS1Cb89PoZFK3piIPEjC2pY01p
 Lj5jlHXRp8KRgJDCsfKaa3wkwPt7CZFwO8iDVHVJtRzeVn39NQ4ISLGkfJqcdoHLg/Ox2XG2
 l/OUwsYv+TEv6Q87MLN2fKft46sHuYnRhhaEmDX4KyYLy7f+mb/k4ZMXPzRJWLWVX/u+bXkb
 uJQlqmuPPoClVdMkox9D7c0kv5uu4qx/+dXl102Em/KYlKnDqJbDkOHhcQf5LdQwrJ5uBetX
 h7d8NdtJrjUatjuF0QcJVR5Y73bh+0UgDTb8d88PF7+uH1s5LOCXEhfY0uMhShaIOcnOY8p2
 7586ssf6gj5gRs2KNeWyCtT8j3UfHAHVqwmsLAcAZPq1VV3mg0TP8SEB3+k+oyLZvVNLlIuc
 22di6f1jrhBwlbPLigoHn/X0OsB3ZkDtXimFrPZy4hlTjYdusIK4Q==
IronPort-HdrOrdr: A9a23:WfwB66rRu9TWtimGvRwFE+QaV5u4L9V00zEX/kB9WHVpm5Oj+f
 xGzc516farslossREb+expOMG7MBXhHLpOkPQs1NCZLXXbUQqTXftfBO7ZogEIdBeOk9K1uZ
 0QF5SWTeeAcmSS7vyKkDVQcexQuOVvmZrA7Yy1ogYPPGMaGJ2IrT0JcTpzencGNTWubqBJba
 Z0iPA3wAZJLh8sH7qG7zQ+LqT+juyOsKijTQ8NBhYh5gXLpTS06ITiGxzd+hsFSTtAzZor7G
 CAymXCl+uemsD+7iWZ+37Y7pxQltek4txfBPaUgsxQDjn3kA6naKloRrXHljEop+OE7kosjb
 D30lgdFvU2z0mUUnC+oBPr1QWl+DEy60X6wVvdunfnqdyRfkNwN+NxwaZiNjfJ4Uspu99xlI
 hR2XiCipZRBRTc2Azg+tnhTXhR5wmJiEtntdRWo21UUIMYZrMUh5cY5llpHJAJGz+/wJw7Ed
 NpENrX6J9tABOnhkjizyxSKeGXLzAO9k/seDlEhiXV6UkWoJlB9Tpb+CRF9U1wsq7USPF/lq
 z52+pT5ehzpmJ/V9MLOA47e7rDNoX6e2OEDIujGyWUKEg5AQO4l3fW2sR+2Aj4Qu1E8HMN8K
 6xJm+w81RCI37TNQ==
X-IronPort-AV: E=Sophos;i="5.85,375,1624334400"; 
   d="scan'208";a="54836120"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Qc1j+yKitTR5OCgnE1jGBog4CSeDGEUz218nD/Do2Ovceul6Yp1sWi7+RxKUlkRDcP81YSrcPkbNtuc8/QfEq98nkJwqepOZ/AEITDOjTnhjWZE2jRhN/4gTQVsj1kC/1h6SY/0dUd1tB5j55/NmvhKftpp3iaZDJQBi0rl1HsaT1Hw9zjRxJZFlAQ8PLB2fhycs3TCoDHMI4QLtSOBfSSv3z2uk09byKOAJv79ZVyFZtvOOBhaG3KUyy6r1fDm2I+jn5YpjI1LN+wzCJNd1AtyhHunpJ1lj8QDV/px8TO+/EsmYESjxSTkG0j7yZuaeah+s0GicPYWnFKIxOVO/sQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=GRGrxkwCGoRmDJVmWtGcVrqCKpbBMU/fv95Cgxayhus=;
 b=Nq5AeOQ3RvYsJaGkt75+F/TyZTnDK8Tv42oXQZnoHFkMeM/oUJ4EdnYUMg1hBril9u8U6l8lrw4AIh9lET2LM10jHdKtLe0WmpE9osMTBK8FEAyncKI8xvNnJB2AjuNqBeqOJxGsqLksbQDmeSdRhJhxR99TGBFxdqMzafuul0SUh+eUVPgIH1CNYXQupn9Z3IrjOkN1thBLQzABM4s/qSIcKsJKielzI7GX6sEvRNSmQr/wztexjKm+RsdZnDxz+NJMMgMx1qd7SxvM/rxSo//4q4t22mXvZEwR81VWYI/ZRi+agPIRhCFtT7WnzrBn2ZcDWZ+XkSrfun9bnGzDEg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=GRGrxkwCGoRmDJVmWtGcVrqCKpbBMU/fv95Cgxayhus=;
 b=AA6sPdSplfBOXY7j02sOVR1vAAbsWzTp9RHg/N9rI5mv7xqEw6A9is+FYIkvcsgS3w8oiPzXey7w7Q1t9VUgLwvipZROF0AAxr5OwWX3g8BFGzU9YhG48TlvMkFrIp9tlI7dZRO4cXSxFcHq+t23YtNVpPhxlZjqVCV+w6pZ338=
Date: Fri, 15 Oct 2021 11:53:38 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Bertrand Marquis <Bertrand.Marquis@arm.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>, "iwj@xenproject.org"
	<iwj@xenproject.org>, Paul Durrant <paul@xen.org>, Jan Beulich
	<jbeulich@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu
	<wl@xen.org>
Subject: Re: [PATCH v6 1/3] xen/vpci: Move ecam access functions to common
 code
Message-ID: <YWlPohYpgxs3gRlc@MacBook-Air-de-Roger.local>
References: <cover.1634221830.git.bertrand.marquis@arm.com>
 <ced6f870dbfabcfe8584555cc80f9a37a0655a0c.1634221830.git.bertrand.marquis@arm.com>
 <YWkxT1bVmBT7Av43@MacBook-Air-de-Roger.local>
 <EB6EE7F3-80BD-4717-87C7-C54FAB0FD832@arm.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <EB6EE7F3-80BD-4717-87C7-C54FAB0FD832@arm.com>
X-ClientProxiedBy: LO4P123CA0117.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:192::14) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: e8ff2df9-b22d-476f-7eac-08d98fc1ac7c
X-MS-TrafficTypeDiagnostic: DM5PR03MB3146:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <DM5PR03MB31468139CB1D0C7913DDC0B18FB99@DM5PR03MB3146.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: Wr8aTuniaI2r2WpKnMwKa8jr8EW1B3tR5KOR0cs4WKHuM+l6+6dkqZfbWpDFwurrbAlo3/5/vjRzeai0teGBY/s+qlBYdzkBn9WmCIImqX0LLbGghx3nYFXj9WZdJY16SM6TiFSDOAyqHNXrHZ7NEuAMOQFWU4JoU5alQRGagCt+wn1armjfnRfJ2PZIQM9su13JrkivXgw/jSfyswT15b+A8U9Qq31A6PafgRFHz4ynY46SRSetF+s8vfDXNvm6HXlIxlRt+KwVvr2OBGNo84VE6gz5SVsoYQ9Qj/yLa6Y8q70n0LdbAFV6cByHXz+zRLazK5rZBgxwRNiHd6P3doILTOmAGbNKBcGRnAbAnm3iMGO4IVuBThuFuJ9YTDEDaf0f3UbaiILsuAVOZBo2E2zEQ5p5w/uwN9IqIGZECaJGHU5lttA/r2yDV6sg+b636WWQcSSgalLahaWeCNfwZlFQE1iJKC7vSG+4/TLJyqoIMvordktX8n8wsevFoG+wbEYFkd0f9L8pMnrIPvxjz9cXuCf0/bgVWppG8ZqB4u+4tSwdXhv9bUL0WG1QIFP86UuzMAU4iyH9LG9NPFm88nMKYlVPeD0BXB3jvPJ/y7EStntj1qWEOJh+e03l+EyVYIQ+SiHyp7vWMhxPXvS49Q==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(54906003)(316002)(83380400001)(6486002)(82960400001)(8936002)(508600001)(956004)(5660300002)(53546011)(85182001)(38100700002)(2906002)(66556008)(6666004)(66946007)(86362001)(4326008)(6916009)(66476007)(8676002)(9686003)(186003)(26005)(6496006);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RkRNTURvcVUxNWkxUFBvNmNlZHJlb2pZOXhhSWlUeHRoOVNzbTRsanRqbFd4?=
 =?utf-8?B?b2ovc2ZiVTZWdmRIOEFaMUJ1TTNhNmRhSmFSNjMvRFB2Wk1UZW1yTmZlMUN1?=
 =?utf-8?B?SHhHWC8rRU9EZVMxTG9qK0dXWm1jaC9HZ1V5MC9wVzdycWpjSTI5LzJBeCtC?=
 =?utf-8?B?NkhTY3JPeTVneXZQN1FJcnl4ekFYdnB2Rlh0cVEyd3V2SGMxQU9KeHJTK0pt?=
 =?utf-8?B?eWpRK3BReGU4WEc1bVF5K0l4NEVHYnQrOTRYaFlPK0NKYnFlOTFKTU5STlNT?=
 =?utf-8?B?TFpNTlJmQm1VR01OcG9vbStHOVg3cFBxYnpqc0ZiVHJIR2pxYXppc2VKSEE5?=
 =?utf-8?B?TW1iWXFpdWh6b2NCRWNjNFR4Wjhnb1RleWNTaWdEaWpnRnBJNDh4UWJpLzl4?=
 =?utf-8?B?bDY1RmgzckRnOGl5ZWRjQmZYbisxMklhQzUyc0pLZzIyKzJ2UkE2NTRSa1pP?=
 =?utf-8?B?dnBERjFwc0hmQVpmeVpFL2ZXc3p1MGhDUjFxOGdPNlNOMXRxTHphR1ZRWXNO?=
 =?utf-8?B?M1ByK2JIL3htNkQwVkpPUm1zeHVpNHFsaU4rL3hsTEorMWtFMU4vblZRNXpF?=
 =?utf-8?B?TlppT3hSczhCS3k1L3ZsME01SklNOHdiOXhDTmVueHF0MEtDeVFuT1NxcC9H?=
 =?utf-8?B?aUhOUEx2LzVQU1RBVTZCd1NHcHFNZWdqRklIb1d1bzRRL3cxYm5ueEZKZUNO?=
 =?utf-8?B?ZEkxZVFzdkxDK2svOFpjWWJPcy9KNjRUNzNrOWdtKzlQUFBEUGNhQ0txV2Ur?=
 =?utf-8?B?MWxOdlpkOFVvZUQrM2cyczFnM0g1TVBldE5mTTByOU43MEhaUWFWaG41UExi?=
 =?utf-8?B?QnREOVBRMGdRQjF2b2xETlZSNHN3OXA5QkdJaEFxeXNnNGE2ZmlPR2JWb1Ju?=
 =?utf-8?B?a3F3Y290eE94SmN5blN5RTVjcFJTQ2VKQVZkQnFWd01adVd3TGJ4T2o3SHBu?=
 =?utf-8?B?ZC92Z3hER1A4cVZkZTRPSlJKaU5uQlNNK0grMEhPb0t4dzFzamRJVlFVZGIx?=
 =?utf-8?B?eG5QL1QrckxPZUFJS2hyZWJJbGQyenFEM25pSTE2TGFQU3dBaW53cUVKeDAv?=
 =?utf-8?B?UGRLYjE0V3NXQjQ1UnltdDBZU1NwaXd1VHNUM0dJeW1SeG9JMERZbXpiMjF2?=
 =?utf-8?B?aVh6NytLUnA4MmtncVNOdHVMRXFtUXpoaFNRemxBdHJzWHNWWXZaMXpvczFZ?=
 =?utf-8?B?cmtFV005SDB1MVo3L1hDV0JYck8xWE83Um9HOGxqTXl0MlhEN3RlUFZMMWxP?=
 =?utf-8?B?bXMyQnhLZmQ5NHd1RkJWL0tkbndCOFl0dEtOcVFocC9SQ2ZTR2twdXRESGls?=
 =?utf-8?B?ajV0NzY0TGxSRGNlTFh5c1pzS2RycUg1MSt4ZVQzZmNpOFNGUm55OVpYV3R6?=
 =?utf-8?B?bUxTTFRLSTI3dm03Q3V4c1dOSytFYzgxdW95TlNsbkZkM1VTVFhIZHJkcjND?=
 =?utf-8?B?RWpXSU91NTdJQVlFc1Y4cTIweDFnanZjekpoMDBvVlJpRkVRUVlBOCt3bFpO?=
 =?utf-8?B?MjhucktXWWJpSE1CaGE2RFk5TTNzQVl5SldGcTlRVmVpM1B5QVJJMTRBRm9Q?=
 =?utf-8?B?VGlWaVFibmNCUTRIbEx0eTRwMDgyWjZFRXl5SnA0bVVHUWdvN3ZYQjIweW5W?=
 =?utf-8?B?VjZORFN3NFJxdEw2YThGbElVclRIMi9rdEIxVFlJTXdZbk5EZGhsdjVvQnlQ?=
 =?utf-8?B?c3FrTk5zaTBDZE0yaUFocXA5TG01dkxhWGpYTDJVeXF2NUFkQW9laXc4UkYr?=
 =?utf-8?Q?/ad7L87GuRbWo5Ols0ENcKvqIMNoWKCCtBimABA?=
X-MS-Exchange-CrossTenant-Network-Message-Id: e8ff2df9-b22d-476f-7eac-08d98fc1ac7c
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2021 09:53:43.6977
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Bxw03+0XwsH93gBF/35HFTSPaDV9pJxcl6MJt3npGaWpBYdUKC79N89dNMDRdiehuRneHGhWLVnVSaqa56WgAw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB3146
X-OriginatorOrg: citrix.com

On Fri, Oct 15, 2021 at 07:53:38AM +0000, Bertrand Marquis wrote:
> > On 15 Oct 2021, at 08:44, Roger Pau Monné <roger.pau@citrix.com> wrote:
> > On Thu, Oct 14, 2021 at 03:49:49PM +0100, Bertrand Marquis wrote:
> >> @@ -434,25 +420,8 @@ static int vpci_mmcfg_read(struct vcpu *v, unsigned long addr,
> >>     reg = vpci_mmcfg_decode_addr(mmcfg, addr, &sbdf);
> >>     read_unlock(&d->arch.hvm.mmcfg_lock);
> >> 
> >> -    if ( !vpci_access_allowed(reg, len) ||
> >> -         (reg + len) > PCI_CFG_SPACE_EXP_SIZE )
> >> -        return X86EMUL_OKAY;
> >> -
> >> -    /*
> >> -     * According to the PCIe 3.1A specification:
> >> -     *  - Configuration Reads and Writes must usually be DWORD or smaller
> >> -     *    in size.
> >> -     *  - Because Root Complex implementations are not required to support
> >> -     *    accesses to a RCRB that cross DW boundaries [...] software
> >> -     *    should take care not to cause the generation of such accesses
> >> -     *    when accessing a RCRB unless the Root Complex will support the
> >> -     *    access.
> >> -     *  Xen however supports 8byte accesses by splitting them into two
> >> -     *  4byte accesses.
> >> -     */
> >> -    *data = vpci_read(sbdf, reg, min(4u, len));
> >> -    if ( len == 8 )
> >> -        *data |= (uint64_t)vpci_read(sbdf, reg + 4, 4) << 32;
> >> +    /* Ignore return code */
> >> +    vpci_ecam_mmio_read(sbdf, reg, len, data);
> > 
> > I think it would be better for vpci_ecam_mmio_read to just return the
> > read value, or ~0 in case of error, at least that interface would be
> > simpler and suitable for x86.
> 
> I am not quite sure on this as on absolute to read ~0 is possible so the
> caller cannot distinguish between properly reading ~0 or an access allowed error.

How do you report an access allowed error on Arm for the PCI config
space?

At least on x86 I don't think we currently have a way to propagate
such errors, neither a plan to do so that I'm aware.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Fri Oct 15 09:59:26 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 09:59:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.210081.366796 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbJzm-0007dX-4B; Fri, 15 Oct 2021 09:59:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 210081.366796; Fri, 15 Oct 2021 09:59:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbJzm-0007dQ-0g; Fri, 15 Oct 2021 09:59:22 +0000
Received: by outflank-mailman (input) for mailman id 210081;
 Fri, 15 Oct 2021 09:59:20 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=lHOs=PD=arm.com=Penny.Zheng@srs-us1.protection.inumbo.net>)
 id 1mbJzk-0007dK-Bp
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 09:59:20 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com (unknown
 [2a01:111:f400:fe0c::60e])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id bc4b2063-9537-4d95-9492-8450a5873f3a;
 Fri, 15 Oct 2021 09:59:18 +0000 (UTC)
Received: from AM6P194CA0003.EURP194.PROD.OUTLOOK.COM (2603:10a6:209:90::16)
 by AM4PR08MB2850.eurprd08.prod.outlook.com (2603:10a6:205:3::27) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.25; Fri, 15 Oct
 2021 09:59:16 +0000
Received: from VE1EUR03FT016.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:209:90:cafe::37) by AM6P194CA0003.outlook.office365.com
 (2603:10a6:209:90::16) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16 via Frontend
 Transport; Fri, 15 Oct 2021 09:59:15 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT016.mail.protection.outlook.com (10.152.18.115) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.15 via Frontend Transport; Fri, 15 Oct 2021 09:59:15 +0000
Received: ("Tessian outbound 8e26f7114b75:v103");
 Fri, 15 Oct 2021 09:59:14 +0000
Received: from 078073e218ed.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 0FC93A6C-34F0-4E07-A44D-DD2C9824B073.1; 
 Fri, 15 Oct 2021 09:59:04 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 078073e218ed.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 15 Oct 2021 09:59:04 +0000
Received: from VE1PR08MB5215.eurprd08.prod.outlook.com (2603:10a6:803:10a::33)
 by VE1PR08MB4895.eurprd08.prod.outlook.com (2603:10a6:802:ac::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.17; Fri, 15 Oct
 2021 09:59:00 +0000
Received: from VE1PR08MB5215.eurprd08.prod.outlook.com
 ([fe80::41d6:b115:3b22:2cd]) by VE1PR08MB5215.eurprd08.prod.outlook.com
 ([fe80::41d6:b115:3b22:2cd%2]) with mapi id 15.20.4587.026; Fri, 15 Oct 2021
 09:59:00 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: bc4b2063-9537-4d95-9492-8450a5873f3a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=gQmxa07pRCEJF1EK8YPd/kuFqwLQ/P6m0VXS0LMi8A0=;
 b=kgbdCFxh8dOUdMA7sxzY3ybSy+g2t0uhyr20YlcJitEBjjI4eTzoaXh6iGleS7W0Y6x3vKCWKzBm0gULedUREtzYoNqfqEYV4/PqPQbRYx3CEI7/R02ByxY8SNKEG1J0/RTsJV1Xgsxh8t/YLeA8uK72GMaXkk1ERz5BjhJmMhE=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=MzBQvOQ/I/FobDOzyxqRZex0lN/zTORCIzRyBqWl9555mHUvNNLLc7iFsYeMEkVcEL3Z5GJhXvKmTVGxL2xroSGKztETuVCAPXyAdKdVAQS4p6GlQFKI7Ar79pPbeWXFSifI15Z/V5dh1IO+QggWLkznBCFPWZqovDsZO/pIAGg3Kj9LxqR+hzQgSUV5dEdrJL0Wy8cS/Tf3LUmWIOeq8NDssX8FfczCjYFOlMcttRuiDB4e01p9DI777vVF+yyYCOM35nc+3E3YW8TRKc3ZjP9uT8u4IZ1vJuo1lcM6ZUSxq+ODEXCpzz5Aht1UFCW2In18JopdnqLYuqnu/X1BmQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=gQmxa07pRCEJF1EK8YPd/kuFqwLQ/P6m0VXS0LMi8A0=;
 b=d/Z7dt9hbomv1siwz40RkwqyNG8R07q0U5kfRzjihmnd09BVx/qHkSXdmCRtAjoN18lqu/vnzw6qyH5z2iyDaDDcQbknNerp6Z2CUW4FdxQfzozK3zBrdiXeT4gY6ybxSCSbgqyXSt8DsKWSMpSXUQlgrqdUizBeUlw0druO7QXJtewHDZB/ojt6z3/w0akBUFxjCJp0gTyw1ypcwOqBMEGHPdAcMYJBMqcRzdP5TxFcr9N5M1mLeD05MQkVpRbPAhCeL7HU9KO1PFHc5Be48YXPDmKdTpkahciJgNkeM/xc8PvqxegAd2lHCydVOYZ6TXmXAjePJ3RrsnW0LuYOHg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=gQmxa07pRCEJF1EK8YPd/kuFqwLQ/P6m0VXS0LMi8A0=;
 b=kgbdCFxh8dOUdMA7sxzY3ybSy+g2t0uhyr20YlcJitEBjjI4eTzoaXh6iGleS7W0Y6x3vKCWKzBm0gULedUREtzYoNqfqEYV4/PqPQbRYx3CEI7/R02ByxY8SNKEG1J0/RTsJV1Xgsxh8t/YLeA8uK72GMaXkk1ERz5BjhJmMhE=
From: Penny Zheng <Penny.Zheng@arm.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Wei Chen <Wei.Chen@arm.com>, Bertrand Marquis <Bertrand.Marquis@arm.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	"sstabellini@kernel.org" <sstabellini@kernel.org>, "julien@xen.org"
	<julien@xen.org>
Subject: RE: [PATCH v2 1/6] xen: introduce XEN_DOMCTL_CDF_directmap
Thread-Topic: [PATCH v2 1/6] xen: introduce XEN_DOMCTL_CDF_directmap
Thread-Index: AQHXwaEz9sR/Jlon9kSpv6953h7AKKvTwZeQ
Date: Fri, 15 Oct 2021 09:59:00 +0000
Message-ID:
 <VE1PR08MB521583497AD2D7A3FA3AAA8CF7B99@VE1PR08MB5215.eurprd08.prod.outlook.com>
References: <20211015030945.2082898-1-penny.zheng@arm.com>
 <20211015030945.2082898-2-penny.zheng@arm.com>
 <073d4b36-cb2f-88b2-76d2-3438d4ef589a@suse.com>
In-Reply-To: <073d4b36-cb2f-88b2-76d2-3438d4ef589a@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: 40D2948B8CCF5347ABDF82F81703A94B.0
x-checkrecipientchecked: true
Authentication-Results-Original: suse.com; dkim=none (message not signed)
 header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: 194e6e3d-ce7f-4ceb-b23d-08d98fc27256
x-ms-traffictypediagnostic: VE1PR08MB4895:|AM4PR08MB2850:
x-ms-exchange-transport-forked: True
X-Microsoft-Antispam-PRVS:
	<AM4PR08MB2850ED3D1B1501403AB400FDF7B99@AM4PR08MB2850.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:3631;OLM:3631;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 m6kL9Bj7C4WW0I4ZJQNVoWwd2WBbU2/xzHReiOhNIBO+jJrjRIhSKnWqunMWvrmxwsS6nFfmaJPuK6fQbklPGqL/P/sl8mgaI8t6zCfzJoMmn3/OcYacXTTJsIN44wVuJFCc89JcKyuh0NRBfHy1hdItA7VI63CC9Xx5on5mG8ImGJcFQLlsP1bc2h07sKWchUfA9OjYmiON5IrTKXgJ14r+fcnWRR2kZ3M6aGQFO/HctMI/sAt3C/yugXmAMI8/198rtU0ljBQVNKCAu0pCJD9xvQYrgWAe8d7bQV41Eh+TzbNoQ0HjlQTeyXP8UWZHjPu1qySGb/2oglo0R5PVr3yFm7AUe1pbnMnqNnS+XSwVgpsdBKhhiAMoveLQyH7uH2iReuool942/M7OGiMARo4ajjm9QZL1150mTa66wMm+sFG0zVtQk8wfAkmjcr2C6uN44ydb2ULYVFt0r4Bmfe1/+woix7AXXaFZLgjflCQCxn5BIQi9q4zmoG/MsJKgX0M5u0mh8eGFMa1jl6pxu33nQrySLq34fGJE1NazsIe8pG4cqqIgNJQt0dxHLFiefCba8ZOnw1JhNd5aI4myzNigIbll394TDOfYc+544HP4viA3Prw5T0TYNbFd2Ci6ebq+AG1Fs4HqBdFB0yhhzQchIEQOuPzkI5RRXg3YPtnAc38UWXqvgxl+kME/HmCNQWnqD7U4ZhQscBEQt8VL4S0JFQlMqihJHGwsJSmJfiSvewnGMzEsU3DoyYIFkCkpt3gXFYIFAsmSyL3ojnwad445ZLgS9w4Y3toUvd6AByI=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR08MB5215.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(54906003)(52536014)(53546011)(316002)(966005)(6506007)(33656002)(86362001)(71200400001)(8676002)(26005)(508600001)(76116006)(8936002)(38100700002)(122000001)(55016002)(66556008)(64756008)(66946007)(9686003)(186003)(5660300002)(66446008)(38070700005)(4326008)(66476007)(7696005)(2906002)(83380400001)(6916009);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB4895
Original-Authentication-Results: suse.com; dkim=none (message not signed)
 header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT016.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	de1b868d-7de0-47c4-45f0-08d98fc26973
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	sp3s/T7yh7MQXl5c9WCLrEF+Jg0Uh0KsDMzMXRuWjFgoQs5fhBV/qHNPvptxjo8uH2RGlUdf2gfdcOqWkqpa2wB3mp/q4drKLa/3Y2TGXL/YXMRl99j519ObEO6oFZZZF/AYvvVGcxgDHH8SzPvZDipH2FA3fbSS/fjbyYWaBXN6k7Xr6Z7lC5NmE5S3QCKNHpSl5ZBl0hDoktkI02uBGjtWHgeCHAhLDFOFvaXkXgN046IY+lpwYvgsowNtIXF2dIwy1o3JaxAGYg0EAWR8Cdn6oYyNRC7R9SszTHLscR4juMSIfd/OyTiQNuSr9YUwHXzGj5Q36YjX4FtY3UvsYRwXibO10r4PIcE9nCaYNK1mXvopiaX64z38EGI0VsOhy+4OxmxGetUmRLyzVOu3WHNUtCEu+Bk4kKQqAiGV7dM9B10nnN0xI/25BIvPA228nkymzysmY7WYs2hBB1YOfOZK8S2d/0FwaM1zAtrvJseI7TC0oIWAjNDQG2wZ4EIQYVSWLmTcVwz6ep6GoSAkucv5wvWV3EBdz7NvgAHI+aCf//14ACO4gMI+tMvTLXSk6UfWFMddERJ5P01VkBgDM2hP+wMvpoBA8N7yXinhBt2e94o0pD6nEh9psYam0xJMBYDxaXDJ8/N8f3sEfNBEAEdaR45jW7q2nwVUNeHZYJsuA+510VUyVHQBo4J4HgTyCm0mvNBEFa86k2jKZMHOK8zCre2CRTlib97iWbln34P++7pIeRxc89zgyGWckWfwtWZF/l86uy72VEs/nklAPPP/KUufmv4gMaz4+m24NIg=
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(47076005)(54906003)(53546011)(26005)(316002)(33656002)(6506007)(9686003)(356005)(8676002)(52536014)(55016002)(82310400003)(7696005)(186003)(6862004)(81166007)(8936002)(5660300002)(36860700001)(70586007)(70206006)(508600001)(83380400001)(86362001)(336012)(966005)(4326008)(2906002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2021 09:59:15.2978
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 194e6e3d-ce7f-4ceb-b23d-08d98fc27256
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT016.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR08MB2850

SGkgSmFuDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogSmFuIEJldWxp
Y2ggPGpiZXVsaWNoQHN1c2UuY29tPg0KPiBTZW50OiBGcmlkYXksIE9jdG9iZXIgMTUsIDIwMjEg
NDo0NyBQTQ0KPiBUbzogUGVubnkgWmhlbmcgPFBlbm55LlpoZW5nQGFybS5jb20+DQo+IENjOiBX
ZWkgQ2hlbiA8V2VpLkNoZW5AYXJtLmNvbT47IEJlcnRyYW5kIE1hcnF1aXMNCj4gPEJlcnRyYW5k
Lk1hcnF1aXNAYXJtLmNvbT47IHhlbi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZzsNCj4gc3N0
YWJlbGxpbmlAa2VybmVsLm9yZzsganVsaWVuQHhlbi5vcmcNCj4gU3ViamVjdDogUmU6IFtQQVRD
SCB2MiAxLzZdIHhlbjogaW50cm9kdWNlIFhFTl9ET01DVExfQ0RGX2RpcmVjdG1hcA0KPiANCj4g
T24gMTUuMTAuMjAyMSAwNTowOSwgUGVubnkgWmhlbmcgd3JvdGU6DQo+ID4gRnJvbTogU3RlZmFu
byBTdGFiZWxsaW5pIDxzdGVmYW5vLnN0YWJlbGxpbmlAeGlsaW54LmNvbT4NCj4gPg0KPiA+IFRo
aXMgY29tbWl0IGludHJvZHVjZXMgYSBuZXcgYXJtLXNwZWNpZmljIGZsYWcNCj4gPiBYRU5fRE9N
Q1RMX0NERl9kaXJlY3RtYXAgdG8gc3BlY2lmeSB0aGF0IHRoaXMgZG9tYWluIHNob3VsZCBoYXZl
IGl0cw0KPiA+IG1lbW9yeSBkaXJlY3RseSBtYXBwZWQgKGd1ZXN0IHBoeXNpY2FsIGFkZHJlc3Mg
PT0gcGh5c2ljYWwgYWRkcmVzcykgYXQNCj4gZG9tYWluIGNyZWF0aW9uLg0KPiA+DQo+ID4gUmVm
aW5lIGlzX2RvbWFpbl9kaXJlY3RfbWFwcGVkIHRvIGNoZWNrIHdoZXRoZXIgdGhlIGZsYWcNCj4g
PiBYRU5fRE9NQ1RMX0NERl9kaXJlY3RtYXAgaXMgc2V0Lg0KPiA+DQo+ID4gU2lnbmVkLW9mZi1i
eTogU3RlZmFubyBTdGFiZWxsaW5pIDxzdGVmYW5vLnN0YWJlbGxpbmlAeGlsaW54LmNvbT4NCj4g
PiBTaWduZWQtb2ZmLWJ5OiBQZW5ueSBaaGVuZyA8cGVubnkuemhlbmdAYXJtLmNvbT4NCj4gPiAt
LS0NCj4gPiBDQzogYW5kcmV3LmNvb3BlcjNAY2l0cml4LmNvbQ0KPiA+IENDOiBqYmV1bGljaEBz
dXNlLmNvbQ0KPiA+IENDOiBHZW9yZ2UgRHVubGFwIDxHZW9yZ2UuRHVubGFwQGV1LmNpdHJpeC5j
b20+DQo+ID4gQ0M6IElhbiBKYWNrc29uIDxpYW4uamFja3NvbkBldS5jaXRyaXguY29tPg0KPiA+
IENDOiBXZWkgTGl1IDx3bEB4ZW4ub3JnPg0KPiA+IENDOiAiUm9nZXIgUGF1IE1vbm7DqSIgPHJv
Z2VyLnBhdUBjaXRyaXguY29tPg0KPiA+IC0tLQ0KPiANCj4gUGxlYXNlIGhhdmUgaGVyZSBhIGJy
aWVmIGxvZyBvZiBjaGFuZ2VzIGluIHRoZSBuZXcgdmVyc2lvbiwgdG8gYWlkIHJldmlld2Vycy4N
Cj4gDQoNClN1cmUuDQoNCj4gPiAgeGVuL2FyY2gvYXJtL2RvbWFpbi5jICAgICAgICB8IDMgKyst
DQo+ID4gIHhlbi9hcmNoL2FybS9kb21haW5fYnVpbGQuYyAgfCA0ICsrKy0NCj4gPiAgeGVuL2Nv
bW1vbi9kb21haW4uYyAgICAgICAgICB8IDMgKystDQo+ID4gIHhlbi9pbmNsdWRlL2FzbS1hcm0v
ZG9tYWluLmggfCA0ICsrLS0gIHhlbi9pbmNsdWRlL3B1YmxpYy9kb21jdGwuaCAgfA0KPiA+IDQg
KysrLQ0KPiA+ICA1IGZpbGVzIGNoYW5nZWQsIDEyIGluc2VydGlvbnMoKyksIDYgZGVsZXRpb25z
KC0pDQo+IA0KPiBZb3UgY2xlYXJseSBoYWQgdG8gcmUtYmFzZSBvdmVyIHRoZSBYRU5fRE9NQ1RM
X0NERl92cG11IGFkZGl0aW9uLiBJIHRoaW5rDQo+IGp1c3QgbGlrZSB0aGF0IGNoYW5nZSAod2hp
Y2ggSSdkIGV4cGVjdCB5b3UgdG8gaGF2ZSBsb29rZWQgYXQgd2hpbGUgZG9pbmcgdGhlDQo+IHJl
LWJhc2UpIHlvdSBhbHNvIG5lZWQgdG8gYXQgbGVhc3QgZmlkZGxlIHdpdGggT0NhbWwncyBkb21h
aW5fY3JlYXRlX2ZsYWcsIHRvDQo+IGtlZXAgdGhlIEFCSSBjaGVjayB0aGVyZSBoYXBweS4NCj4g
DQoNClRoZSBwYXRjaCBzZXJpZSBpcyBiYXNlZCBvbiB0aGUgc3RhZ2luZyBicmFuY2ggd2l0aCBh
biBleHRyYSBjb21taXQgIg0KUmV2ZXJ0ICJ4ZW4vZG9tY3RsOiBJbnRyb2R1Y2UgWEVOX0RPTUNU
TF9DREZfdnBjaSBmbGFnIiwgd2hpY2gNCklzIGFscmVhZHkgYmVlbiBwdXNoZWQgdG8gY29tbXVu
aXR5IGZvciByZXZpZXcuKA0KaHR0cHM6Ly9saXN0cy54ZW5wcm9qZWN0Lm9yZy9hcmNoaXZlcy9o
dG1sL3hlbi1kZXZlbC8yMDIxLTEwL21zZzAwODIyLmh0bWwpDQoNCj4gPiAtLS0gYS94ZW4vaW5j
bHVkZS9wdWJsaWMvZG9tY3RsLmgNCj4gPiArKysgYi94ZW4vaW5jbHVkZS9wdWJsaWMvZG9tY3Rs
LmgNCj4gPiBAQCAtNzIsOSArNzIsMTEgQEAgc3RydWN0IHhlbl9kb21jdGxfY3JlYXRlZG9tYWlu
IHsNCj4gPiAgI2RlZmluZSBYRU5fRE9NQ1RMX0NERl9uZXN0ZWRfdmlydCAgICAoMVUgPDwNCj4g
X1hFTl9ET01DVExfQ0RGX25lc3RlZF92aXJ0KQ0KPiA+ICAvKiBTaG91bGQgd2UgZXhwb3NlIHRo
ZSB2UE1VIHRvIHRoZSBndWVzdD8gKi8NCj4gPiAgI2RlZmluZSBYRU5fRE9NQ1RMX0NERl92cG11
ICAgICAgICAgICAoMVUgPDwgNykNCj4gPiArLyogSWYgdGhpcyBkb21haW4gaGFzIGl0cyBtZW1v
cnkgZGlyZWN0bHkgbWFwcGVkPyAoQVJNIG9ubHkpICovDQo+ID4gKyNkZWZpbmUgWEVOX0RPTUNU
TF9DREZfZGlyZWN0bWFwICAgICAgKDFVIDw8IDgpDQo+IA0KPiBUaGUgY29tbWVudCBkb2Vzbid0
IHJlYWQgd2VsbDsgaG93IGFib3V0ICJTaG91bGQgZG9tYWluIG1lbW9yeSBiZQ0KPiBkaXJlY3Rs
eSBtYXBwZWQ/IiBUaGF0J3MgaWYgYSBjb21tZW50IGhlcmUgaXMgcmVhbGx5IG5lZWRlZCBpbiB0
aGUgZmlyc3QgcGxhY2UuIEkNCj4gYWxzbyBkb24ndCB0aGluayAiQXJtIG9ubHkiIHNob3VsZCBi
ZSBoZXJlIC0gdGhpcyBtYXkgZ28gc3RhbGUuIFdoYXQgSSdtDQo+IG1pc3NpbmcgaW4gdGhpcyBy
ZWdhcmQgaXMgcmVqZWN0aW5nIG9mIHRoZSBmbGFnIGluIHg4Nidlcw0KPiBhcmNoX3Nhbml0aXNl
X2RvbWFpbl9jb25maWcoKSAob3IgYnkgd2hpY2hldmVyIG90aGVyIG1lYW5zKS4NCj4gDQo+IEph
bg0KDQo=


From xen-devel-bounces@lists.xenproject.org Fri Oct 15 09:59:38 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 09:59:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.210083.366807 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbK02-0007zT-BK; Fri, 15 Oct 2021 09:59:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 210083.366807; Fri, 15 Oct 2021 09:59:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbK02-0007zM-8V; Fri, 15 Oct 2021 09:59:38 +0000
Received: by outflank-mailman (input) for mailman id 210083;
 Fri, 15 Oct 2021 09:59:36 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mbK00-0007yV-DQ
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 09:59:36 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mbK00-0000us-AS
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 09:59:36 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mbK00-0001tY-8r
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 09:59:36 +0000
Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89)
 (envelope-from <iwj@xenproject.org>)
 id 1mbJzt-0005Ed-HL; Fri, 15 Oct 2021 10:59:29 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date
	:Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From;
	bh=Vqw3aVQWcHjwZB6ejJhU2o21G6uco6OlVwp1rzUv06M=; b=SR24suf7Kt93E1p+amkmoF7JjA
	oKOIPuMtYZ9M/sRMY391cCcs3RVD07DHrurhvpCp6qXuIw2ZIxPp7zif4FaCX0pgmxwPZCcIjLfBp
	6LrexNRPZ+5DsChD/Hn4o1MUHbMpKmFIyFoKYTo8dj3I+WLwKk7zNgobIR0NhRri/ElY=;
From: Ian Jackson <iwj@xenproject.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Message-ID: <24937.20736.976552.479677@mariner.uk.xensource.com>
Date: Fri, 15 Oct 2021 10:59:28 +0100
To: Jan Beulich <jbeulich@suse.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
    Bertrand Marquis <bertrand.marquis@arm.com>,
    xen-devel@lists.xenproject.org,
    Rahul Singh <rahul.singh@arm.com>,
    Julien Grall <julien@xen.org>,
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
    Andrew Cooper <andrew.cooper3@citrix.com>,
    George Dunlap <george.dunlap@citrix.com>,
    Wei Liu <wl@xen.org>,
    Paul Durrant <paul@xen.org>,
    Roger Pau =?iso-8859-1?Q?Monn=E9?=  <roger.pau@citrix.com>
Subject: Re: [PATCH v6 2/3] xen/arm: Enable the existing x86 virtual PCI
 support for ARM.
In-Reply-To: <e4eeaa45-e473-9cb1-a65e-70cb0fdfc443@suse.com>
References: <cover.1634221830.git.bertrand.marquis@arm.com>
	<396b08e2598cf0338e0c7f4ad3cd5cb66db89224.1634221830.git.bertrand.marquis@arm.com>
	<alpine.DEB.2.21.2110141331310.9408@sstabellini-ThinkPad-T480s>
	<e4eeaa45-e473-9cb1-a65e-70cb0fdfc443@suse.com>
X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu)

Jan Beulich writes ("Re: [PATCH v6 2/3] xen/arm: Enable the existing x86 virtual PCI support for ARM."):
> On 15.10.2021 01:49, Stefano Stabellini wrote:
> > Replacing the 3 characters with 'x' solves the problem.
> > https://gitlab.com/xen-project/people/sstabellini/xen/-/pipelines/388721262
> 
> Interesting. I thought we permit UTF-8 in the sources; see e.g.
> tools/tests/x86_emulator/simd-sha.c using Σ. Is mkheader.py in need
> of adjustment? Of course I can see that right now the easiest is to
> use ASCII x, but I think it was deliberate to use × here.

I think in general we should permit UTF-8 in sources.

But:

> Then again, with the goal of the public headers being usable with
> pretty old compilers as well (C89 being the assumed baseline),
> excluding them from the permission to use UTF-8 may also be quite
> reasonable.

This is a good reason to do otherwise for the public headers.
Maybe this should be documented in CODING_STYLE (can be done after
feature freeze obviously).

That python has such botched unicode handling is a bug of course but
we could decide we think it's a feature :-).  In which case maybe
mkheaders should be adjusted to explicitly set IO to ascii so that
this will fail in local builds too.

Anyway, for now we need to replace the UTF-8 in this patch.

Thanks,
Ian.


From xen-devel-bounces@lists.xenproject.org Fri Oct 15 10:02:41 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 10:02:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.210097.366817 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbK2y-0001K4-Rq; Fri, 15 Oct 2021 10:02:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 210097.366817; Fri, 15 Oct 2021 10:02:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbK2y-0001Jx-Oz; Fri, 15 Oct 2021 10:02:40 +0000
Received: by outflank-mailman (input) for mailman id 210097;
 Fri, 15 Oct 2021 10:02:39 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mbK2x-0001Jr-ID
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 10:02:39 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mbK2x-00015h-HY
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 10:02:39 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mbK2x-0002Op-GA
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 10:02:39 +0000
Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89)
 (envelope-from <iwj@xenproject.org>)
 id 1mbK2s-0005G4-Ct; Fri, 15 Oct 2021 11:02:34 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date
	:Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From;
	bh=OrgBT6xXYxOqtMDnRH5MU1HVy4KdQFU8hDg1BR2n9A0=; b=XEmopOb5oCLTC/J2N7FQmrfinL
	+yr862LjVBpKE8nU6jv4SQ3haQtbeQ4Rpw4FuFFdFouXzvZcgun9D3wL8r9+lsDWaYgSerVuVkDMc
	3cscIUB2MItJjUrn0xNhgLkYEco5zLR0yJrtSmmPOox/6k5G4B1BN+RK6NX5hCrBEV40=;
From: Ian Jackson <iwj@xenproject.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <24937.20922.73382.850023@mariner.uk.xensource.com>
Date: Fri, 15 Oct 2021 11:02:34 +0100
To: Julien Grall <julien@xen.org>
Cc: Bertrand Marquis <Bertrand.Marquis@arm.com>,
    xen-devel@lists.xenproject.org,
    Rahul Singh <rahul.singh@arm.com>,
    Wei Liu <wl@xen.org>,
    Anthony PERARD <anthony.perard@citrix.com>,
    Juergen Gross <jgross@suse.com>,
    Stefano Stabellini  <sstabellini@kernel.org>,
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
    Michal Orzel <michal.orzel@arm.com>,
    Andre Przywara <Andre.Przywara@arm.com>
Subject: Re: [PATCH v6 3/3] arm/libxl: Emulated PCI device tree node in libxl
 [and 1 more messages]
In-Reply-To: <6f82141c-8a0b-1e30-a996-223f7c0c508d@xen.org>
References: <cover.1633540842.git.rahul.singh@arm.com>
	<b81b5dea800c8fe47071f3dbd20588b1e472fb99.1633540842.git.rahul.singh@arm.com>
	<7bdac405-a889-15e1-be19-5876f7253855@xen.org>
	<24926.53690.621007.507249@mariner.uk.xensource.com>
	<294BE20A-7E45-405C-BC19-C292295E85E3@arm.com>
	<24927.7235.736221.270358@mariner.uk.xensource.com>
	<8A04B9B2-E816-425E-BF1B-5A8B89F8836C@arm.com>
	<cover.1634221830.git.bertrand.marquis@arm.com>
	<fd9c54a381daa52436b0a1b27cf1bba8e7ff9af9.1634221830.git.bertrand.marquis@arm.com>
	<24936.28385.679884.535704@mariner.uk.xensource.com>
	<6f82141c-8a0b-1e30-a996-223f7c0c508d@xen.org>
X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu)

Julien Grall writes ("Re: [PATCH v6 3/3] arm/libxl: Emulated PCI device tree node in libxl [and 1 more messages]"):
> On 14/10/2021 18:54, Ian Jackson wrote:
...
> > That is, as I understand it on ARM vpci should be enabled if
> > passthrough is enabled and not otherwise.  That is precisely what
> > the variable c_info->passthrough is.
> 
> On Arm, c_info->passthrough is also set when assigning platform devives 
> (e.g. a non-PCI network card). At least for now, we don't want to create 
> a node for vCPI in the Device-Tree because we don't enable the 
> emulation. So...

Oh.

> > 3. Now you can use d_config->c_info.passthrough to gate the addition
> >     of the additional stuff to the DT.  Ie, that is a respin of this
> >     patch 3/3.
> 
> ... we will need to check d_config->num_pcidevs for the time being.

OK.

Can you leave a comment somewhere (near where c_info.passthrough is
set) pointing to this use of num_pcidevs ?  That might save someone
some future confusion.

Thanks,
Ian.


From xen-devel-bounces@lists.xenproject.org Fri Oct 15 10:03:51 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 10:03:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.210103.366829 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbK46-0001uO-6a; Fri, 15 Oct 2021 10:03:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 210103.366829; Fri, 15 Oct 2021 10:03:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbK46-0001uH-2r; Fri, 15 Oct 2021 10:03:50 +0000
Received: by outflank-mailman (input) for mailman id 210103;
 Fri, 15 Oct 2021 10:03:49 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=lHOs=PD=arm.com=Penny.Zheng@srs-us1.protection.inumbo.net>)
 id 1mbK45-0001u9-IZ
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 10:03:49 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com (unknown
 [40.107.20.82]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id a9e32ab5-8e6f-477d-bf9c-4f54d8b8a6b7;
 Fri, 15 Oct 2021 10:03:47 +0000 (UTC)
Received: from AM6P191CA0077.EURP191.PROD.OUTLOOK.COM (2603:10a6:209:8a::18)
 by DB8PR08MB5194.eurprd08.prod.outlook.com (2603:10a6:10:e8::19) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.25; Fri, 15 Oct
 2021 10:03:45 +0000
Received: from VE1EUR03FT044.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:209:8a:cafe::b7) by AM6P191CA0077.outlook.office365.com
 (2603:10a6:209:8a::18) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15 via Frontend
 Transport; Fri, 15 Oct 2021 10:03:45 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT044.mail.protection.outlook.com (10.152.19.106) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.15 via Frontend Transport; Fri, 15 Oct 2021 10:03:44 +0000
Received: ("Tessian outbound f1898412aff1:v103");
 Fri, 15 Oct 2021 10:03:44 +0000
Received: from 4eaa3b155f11.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 78CBAFA1-169C-4478-BAE4-24F780E68C3F.1; 
 Fri, 15 Oct 2021 10:03:34 +0000
Received: from EUR03-DB5-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 4eaa3b155f11.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 15 Oct 2021 10:03:34 +0000
Received: from VE1PR08MB5215.eurprd08.prod.outlook.com (2603:10a6:803:10a::33)
 by VI1PR08MB2864.eurprd08.prod.outlook.com (2603:10a6:802:21::31)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.14; Fri, 15 Oct
 2021 10:03:30 +0000
Received: from VE1PR08MB5215.eurprd08.prod.outlook.com
 ([fe80::41d6:b115:3b22:2cd]) by VE1PR08MB5215.eurprd08.prod.outlook.com
 ([fe80::41d6:b115:3b22:2cd%2]) with mapi id 15.20.4587.026; Fri, 15 Oct 2021
 10:03:30 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a9e32ab5-8e6f-477d-bf9c-4f54d8b8a6b7
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=2KybSIbBQR0pu/fexgEmJ6uNwS+q/R4RdSw5aKV1/Hw=;
 b=HSX92AVsqWLCl2daHoEkRe9sjGDmsY6Uo6SiJJKi0P5SljOI7PC1QUM40Ob68Li8Bq7UuqnC5M+yhDHQqhsUAJlMEQdnyLtv+tC3zR3+ptcgrtJuTefzd8MPhUtG/1QyF4nq4z+8etUnqkIG+mJocQGbss06WmVGARx7ebz8JAk=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ipbGbsplaVFMwWw5/pe5AFN4EByzFf56o3pCKWAR7683lg7/bFpgvYANQyeJ3rMyARRJRmSJ61Ofm0ujPOzo3Rd24T4ENJGS7iBc36BTO5a26RCN8/26w/CybUS9NDT/C/1IbeIANghlmRBTwHH8adg4KHsPeSU1Q0KnRe0Y/SNnf9jo07tT0dbjJsLhENdI8OCSA970wNYTLKohla2ky2+3NTRkOinOFd2TF/8c/ZoKoDfs+xzTv35AqHmIkacXNtywL9p8DdAzOQ+9G1IqscB5leh+uNQ8Sv/Xsk2iI7YZzZutIamwNjkQ7OkTuL+cdmvU1/HhUMld2I9MqwCt4Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=2KybSIbBQR0pu/fexgEmJ6uNwS+q/R4RdSw5aKV1/Hw=;
 b=fcJCf0aDddtB3mY9zr4a33ykppZlrtRQ2NzFTDM5eznu8FlaqXWi2x6rj8IZWFiThDKBRu5PUpUUiilynCJ2S1+nmwimAxy0HUjDdNdojrz950IJLrPiCWg0x6WOUJW4tYVc4Nxj1Y9cVYRMd+vzzUpL8uoJVBHL3/8yT4rO9U/Wpm+3NhhQEo1dkcy/8KSxcxcHmwyBr08BJoHusYffbUg5DVu6o8cEsVKLi7ajtGjLIMTNhUUdl20BFqSLFr0IKOj/4fbEorjbHt2o7rmc/si8DRN1qtKgsCps/vgsPycjKgiRLLF7cbh3GFZrP63qXNrRjCnW0v3hV8GpnDKJLQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=2KybSIbBQR0pu/fexgEmJ6uNwS+q/R4RdSw5aKV1/Hw=;
 b=HSX92AVsqWLCl2daHoEkRe9sjGDmsY6Uo6SiJJKi0P5SljOI7PC1QUM40Ob68Li8Bq7UuqnC5M+yhDHQqhsUAJlMEQdnyLtv+tC3zR3+ptcgrtJuTefzd8MPhUtG/1QyF4nq4z+8etUnqkIG+mJocQGbss06WmVGARx7ebz8JAk=
From: Penny Zheng <Penny.Zheng@arm.com>
To: Julien Grall <julien@xen.org>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, "sstabellini@kernel.org"
	<sstabellini@kernel.org>
CC: Wei Chen <Wei.Chen@arm.com>, Bertrand Marquis <Bertrand.Marquis@arm.com>
Subject: RE: [PATCH v2 1/6] xen: introduce XEN_DOMCTL_CDF_directmap
Thread-Topic: [PATCH v2 1/6] xen: introduce XEN_DOMCTL_CDF_directmap
Thread-Index: AQHXwaKc9sR/Jlon9kSpv6953h7AKKvT01dA
Date: Fri, 15 Oct 2021 10:03:30 +0000
Message-ID:
 <VE1PR08MB52154092FD59B77B76EF81BBF7B99@VE1PR08MB5215.eurprd08.prod.outlook.com>
References: <20211015030945.2082898-1-penny.zheng@arm.com>
 <20211015030945.2082898-2-penny.zheng@arm.com>
 <0eba23e2-54f4-0fe4-d811-c2fb8a0602b0@xen.org>
In-Reply-To: <0eba23e2-54f4-0fe4-d811-c2fb8a0602b0@xen.org>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: F035C602837AB840A6DA271DC89BB84B.0
x-checkrecipientchecked: true
Authentication-Results-Original: xen.org; dkim=none (message not signed)
 header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: 089fcfc0-f936-4370-22f7-08d98fc31310
x-ms-traffictypediagnostic: VI1PR08MB2864:|DB8PR08MB5194:
x-ms-exchange-transport-forked: True
X-Microsoft-Antispam-PRVS:
	<DB8PR08MB5194CF19A0488DB7B85473B1F7B99@DB8PR08MB5194.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:9508;OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 hV+45GuQ6p8jOgGWItVjV3S/nSOG3eGET9G2EhNLLl52sOKtB2eQQnSo0aJCRX1mkk+mmJdfZSqs/hLG6UjnhqD+ZVDINJpqBn1uFhkLzTPSg24+p7tWW9ALW/qS5JuiX9yROdfMhj14TbgmUlH+XUdtgbpbhGVR2x6Hj8JRrh5tVcqGDUecDXO+OSFkAhI30d8xsPGUM+zE8GyV5akrka1iWXiwP2aSHoYxK7QrH1D6mhnBZrKN1MXfeDnCWa4ykbweNRbH8OTjZnCrgR0HttdfEiX8mQS/ZDx5F1gJFoLjr0lUTLzJD2yYt7/jDJdCEM+P2DstjrQPVnoqIeM/Ve5H3b7Z9KQh+ZOIieWKHulw5kRjD62e6gHSBu1ynSVNFukseyMJXOWldNvBl1JTKYer0Rg/KwmWI4kAFV4T4tW6bbBf42bILT9mV2QftK25YxLbdfIntdhBaKVBjpVU/rE3jcMi2fQMqWwe8qvbjVpUnfTxNJFldTTUBPEG9XlwUOEeGzWpS1kkvpWOK5T9ofz2qPORmtfaG13WCzMbiwjCAseEx7zfUhmjEawS4NQxNJrtuPHlc0HjBSh7WBLTOHxYoTkhhVHGR39jz3g56plOH2yL1UjPXF2goKgakf3FUEI+AAlBrT+HKKSmtrX5c++Rta7Qj2mEsOGven98wQODogDBABlWQvLxBbE4JogYFyLX/BQ9qlODX8My6I+92A==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR08MB5215.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(54906003)(8676002)(66556008)(52536014)(8936002)(66446008)(2906002)(110136005)(508600001)(7696005)(5660300002)(66946007)(4326008)(55016002)(53546011)(83380400001)(33656002)(9686003)(86362001)(26005)(64756008)(6506007)(38070700005)(76116006)(316002)(71200400001)(38100700002)(122000001)(186003)(66476007);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB2864
Original-Authentication-Results: xen.org; dkim=none (message not signed)
 header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT044.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	4113968f-62cd-4c66-2695-08d98fc30a99
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	tLiHUKPRKm1tHzLBb8P7AT4cTXDV0sb4sRXs5jmg5xy2w1LTqJSpUufzwEri0g43f4UOS78pF2ACrwgW/lV2xUbJhGEm6SyrDTvgTv56fIMfEa4YaSFuoxGZa3NSSV1tTZVRjkI6d2/NsrLnFwFz1yrjQhX/yY3WVKi7reX2pQnpFI1QtvoDWVTavOUqnRAKRO7bkNOieI+RYbSpCBvi1Y2jj/DwVipHYSMaFuWqVtXAaXtClQ4CCTbl1osMZgxm52WHPbGpGkFHcQepBM2HicC9FRqITHderavvuGKZm18kmwGuSCBEGCFSzSOLwiMNVKuQfyC81RwEeqlnZXbF+gYN/cMZwqzmuaD6lAsRa67ZS9/+NQTFZzxKnwH7DeVVa/uYtZI1AlpEBV35SYdrx7oP2etS0l1iA5B26cMEAn6MztOqMAIV6+yRoqpe1kcOnfVidtBf9uClSk+FvsoCF2uTUc6opu7BWXwAj+sPmNZF7l1EgVTR+OEH2MSSjDIV8FxLZaPD0VLmErq9KmU/j5EpuWqwt3eJ1KrSFIrFjFYe0bgpwcvHlW+lgY+2OueH1g7aoQNa4/H0XsdvObClE8dgM/Me7zH2Z9S1pzCiebh63NfjnlcEA5WQy+VJx5kB1T95OtyzNEcavkRnmf0FUluOZi5hrAOeax9Pm6IKmxjTx4xqQz9PmErBEGSi/O33Vdk28hu4wj5d+1KhEWt64w==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(82310400003)(4326008)(36860700001)(6506007)(86362001)(55016002)(508600001)(7696005)(53546011)(83380400001)(110136005)(70586007)(356005)(8676002)(54906003)(26005)(70206006)(2906002)(47076005)(5660300002)(81166007)(8936002)(336012)(52536014)(316002)(9686003)(186003)(33656002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2021 10:03:44.9727
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 089fcfc0-f936-4370-22f7-08d98fc31310
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT044.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB5194

SGkganVsaWVuIA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEp1bGll
biBHcmFsbCA8anVsaWVuQHhlbi5vcmc+DQo+IFNlbnQ6IEZyaWRheSwgT2N0b2JlciAxNSwgMjAy
MSA0OjU3IFBNDQo+IFRvOiBQZW5ueSBaaGVuZyA8UGVubnkuWmhlbmdAYXJtLmNvbT47IHhlbi1k
ZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZzsNCj4gc3N0YWJlbGxpbmlAa2VybmVsLm9yZw0KPiBD
YzogV2VpIENoZW4gPFdlaS5DaGVuQGFybS5jb20+OyBCZXJ0cmFuZCBNYXJxdWlzDQo+IDxCZXJ0
cmFuZC5NYXJxdWlzQGFybS5jb20+DQo+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggdjIgMS82XSB4ZW46
IGludHJvZHVjZSBYRU5fRE9NQ1RMX0NERl9kaXJlY3RtYXANCj4gDQo+IEhpIFBlbm55LA0KPiAN
Cj4gT24gMTUvMTAvMjAyMSAwNDowOSwgUGVubnkgWmhlbmcgd3JvdGU6DQo+ID4gZGlmZiAtLWdp
dCBhL3hlbi9hcmNoL2FybS9kb21haW5fYnVpbGQuYyBiL3hlbi9hcmNoL2FybS9kb21haW5fYnVp
bGQuYw0KPiA+IGluZGV4IDAxNjc3MzFhYjAuLjM3ZTJkNjJkNDcgMTAwNjQ0DQo+ID4gLS0tIGEv
eGVuL2FyY2gvYXJtL2RvbWFpbl9idWlsZC5jDQo+ID4gKysrIGIveGVuL2FyY2gvYXJtL2RvbWFp
bl9idWlsZC5jDQo+ID4gQEAgLTMwNjksOCArMzA2OSwxMCBAQCBzdGF0aWMgaW50IF9faW5pdCBj
b25zdHJ1Y3RfZG9tMChzdHJ1Y3QgZG9tYWluICpkKQ0KPiA+ICAgdm9pZCBfX2luaXQgY3JlYXRl
X2RvbTAodm9pZCkNCj4gPiAgIHsNCj4gPiAgICAgICBzdHJ1Y3QgZG9tYWluICpkb20wOw0KPiA+
ICsgICAgLyogRE9NMCBoYXMgYWx3YXlzIGl0cyBtZW1vcnkgZGlyZWN0bHkgbWFwcGVkLiAqLw0K
PiA+ICAgICAgIHN0cnVjdCB4ZW5fZG9tY3RsX2NyZWF0ZWRvbWFpbiBkb20wX2NmZyA9IHsNCj4g
PiAtICAgICAgICAuZmxhZ3MgPSBYRU5fRE9NQ1RMX0NERl9odm0gfCBYRU5fRE9NQ1RMX0NERl9o
YXAsDQo+ID4gKyAgICAgICAgLmZsYWdzID0gWEVOX0RPTUNUTF9DREZfaHZtIHwgWEVOX0RPTUNU
TF9DREZfaGFwIHwNCj4gPiArICAgICAgICAgICAgICAgICBYRU5fRE9NQ1RMX0NERl9kaXJlY3Rt
YXAsDQo+ID4gICAgICAgICAgIC5tYXhfZXZ0Y2huX3BvcnQgPSAtMSwNCj4gPiAgICAgICAgICAg
Lm1heF9ncmFudF9mcmFtZXMgPSBnbnR0YWJfZG9tMF9mcmFtZXMoKSwNCj4gPiAgICAgICAgICAg
Lm1heF9tYXB0cmFja19mcmFtZXMgPSAtMSwNCj4gPiBkaWZmIC0tZ2l0IGEveGVuL2NvbW1vbi9k
b21haW4uYyBiL3hlbi9jb21tb24vZG9tYWluLmMgaW5kZXgNCj4gPiA4YjUzYzQ5ZDFlLi43YTYx
MzFkYjc0IDEwMDY0NA0KPiA+IC0tLSBhL3hlbi9jb21tb24vZG9tYWluLmMNCj4gPiArKysgYi94
ZW4vY29tbW9uL2RvbWFpbi5jDQo+ID4gQEAgLTQ4Niw3ICs0ODYsOCBAQCBzdGF0aWMgaW50IHNh
bml0aXNlX2RvbWFpbl9jb25maWcoc3RydWN0DQo+IHhlbl9kb21jdGxfY3JlYXRlZG9tYWluICpj
b25maWcpDQo+ID4gICAgICAgICAgICB+KFhFTl9ET01DVExfQ0RGX2h2bSB8IFhFTl9ET01DVExf
Q0RGX2hhcCB8DQo+ID4gICAgICAgICAgICAgIFhFTl9ET01DVExfQ0RGX3MzX2ludGVncml0eSB8
IFhFTl9ET01DVExfQ0RGX29vc19vZmYgfA0KPiA+ICAgICAgICAgICAgICBYRU5fRE9NQ1RMX0NE
Rl94c19kb21haW4gfCBYRU5fRE9NQ1RMX0NERl9pb21tdSB8DQo+ID4gLSAgICAgICAgICAgWEVO
X0RPTUNUTF9DREZfbmVzdGVkX3ZpcnQgfCBYRU5fRE9NQ1RMX0NERl92cG11KSApDQo+ID4gKyAg
ICAgICAgICAgWEVOX0RPTUNUTF9DREZfbmVzdGVkX3ZpcnQgfCBYRU5fRE9NQ1RMX0NERl92cG11
IHwNCj4gPiArICAgICAgICAgICBYRU5fRE9NQ1RMX0NERl9kaXJlY3RtYXApICkNCj4gPiAgICAg
ICB7DQo+ID4gICAgICAgICAgIGRwcmludGsoWEVOTE9HX0lORk8sICJVbmtub3duIENERiBmbGFn
cyAlI3hcbiIsIGNvbmZpZy0+ZmxhZ3MpOw0KPiA+ICAgICAgICAgICByZXR1cm4gLUVJTlZBTDsN
Cj4gPiBkaWZmIC0tZ2l0IGEveGVuL2luY2x1ZGUvYXNtLWFybS9kb21haW4uaA0KPiA+IGIveGVu
L2luY2x1ZGUvYXNtLWFybS9kb21haW4uaCBpbmRleCAxNGU1NzUyODhmLi5mYzQyYzZhMzEwIDEw
MDY0NA0KPiA+IC0tLSBhL3hlbi9pbmNsdWRlL2FzbS1hcm0vZG9tYWluLmgNCj4gPiArKysgYi94
ZW4vaW5jbHVkZS9hc20tYXJtL2RvbWFpbi5oDQo+ID4gQEAgLTI5LDggKzI5LDggQEAgZW51bSBk
b21haW5fdHlwZSB7DQo+ID4gICAjZGVmaW5lIGlzXzY0Yml0X2RvbWFpbihkKSAoMCkNCj4gPiAg
ICNlbmRpZg0KPiA+DQo+ID4gLS8qIFRoZSBoYXJkd2FyZSBkb21haW4gaGFzIGFsd2F5cyBpdHMg
bWVtb3J5IGRpcmVjdCBtYXBwZWQuICovDQo+ID4gLSNkZWZpbmUgaXNfZG9tYWluX2RpcmVjdF9t
YXBwZWQoZCkgaXNfaGFyZHdhcmVfZG9tYWluKGQpDQo+ID4gKy8qIENoZWNrIGlmIGRvbWFpbiBp
cyBkaXJlY3QtbWFwIG1lbW9yeSBtYXAuICovICNkZWZpbmUNCj4gPiAraXNfZG9tYWluX2RpcmVj
dF9tYXBwZWQoZCkgKGQtPm9wdGlvbnMgJiBYRU5fRE9NQ1RMX0NERl9kaXJlY3RtYXApDQo+ID4N
Cj4gPiAgIHN0cnVjdCB2dGltZXIgew0KPiA+ICAgICAgIHN0cnVjdCB2Y3B1ICp2Ow0KPiA+IGRp
ZmYgLS1naXQgYS94ZW4vaW5jbHVkZS9wdWJsaWMvZG9tY3RsLmggYi94ZW4vaW5jbHVkZS9wdWJs
aWMvZG9tY3RsLmgNCj4gPiBpbmRleCAyMzgzODRiNWFlLi5iNTA1YTBkYjUxIDEwMDY0NA0KPiA+
IC0tLSBhL3hlbi9pbmNsdWRlL3B1YmxpYy9kb21jdGwuaA0KPiA+ICsrKyBiL3hlbi9pbmNsdWRl
L3B1YmxpYy9kb21jdGwuaA0KPiA+IEBAIC03Miw5ICs3MiwxMSBAQCBzdHJ1Y3QgeGVuX2RvbWN0
bF9jcmVhdGVkb21haW4gew0KPiA+ICAgI2RlZmluZSBYRU5fRE9NQ1RMX0NERl9uZXN0ZWRfdmly
dCAgICAoMVUgPDwNCj4gX1hFTl9ET01DVExfQ0RGX25lc3RlZF92aXJ0KQ0KPiA+ICAgLyogU2hv
dWxkIHdlIGV4cG9zZSB0aGUgdlBNVSB0byB0aGUgZ3Vlc3Q/ICovDQo+ID4gICAjZGVmaW5lIFhF
Tl9ET01DVExfQ0RGX3ZwbXUgICAgICAgICAgICgxVSA8PCA3KQ0KPiA+ICsvKiBJZiB0aGlzIGRv
bWFpbiBoYXMgaXRzIG1lbW9yeSBkaXJlY3RseSBtYXBwZWQ/IChBUk0gb25seSkgKi8NCj4gPiAr
I2RlZmluZSBYRU5fRE9NQ1RMX0NERl9kaXJlY3RtYXAgICAgICAoMVUgPDwgOCkNCj4gPg0KPiA+
ICAgLyogTWF4IFhFTl9ET01DVExfQ0RGXyogY29uc3RhbnQuICBVc2VkIGZvciBBQkkgY2hlY2tp
bmcuICovDQo+ID4gLSNkZWZpbmUgWEVOX0RPTUNUTF9DREZfTUFYIFhFTl9ET01DVExfQ0RGX3Zw
bXUNCj4gPiArI2RlZmluZSBYRU5fRE9NQ1RMX0NERl9NQVggWEVOX0RPTUNUTF9DREZfZGlyZWN0
bWFwDQo+IA0KPiBJbiB0aGUgcHJldmlvdXMgdmVyc2lvbiwgdGhpcyBmbGFnIHdhcyBvbmx5IHNl
dHRhYmxlIGZvciBkb21haW4gY3JlYXRlZCBieSBYZW4uDQo+IE5vdyB0aGlzIGlzIGFsc28gc2V0
dGFibGUgYnkgdGhlIHRvb2xzdGFjay4gSSBkb24ndCB0aGluayB0aGUgdG9vbHN0YWNrIGNhbg0K
PiBzZW5zaWJseSB1c2UgdGhpcyBmbGFnIChhdCBsZWFzdCBpbiB0aGUgY3VycmVudCBzdGF0ZSku
DQo+IA0KPiBTbyBjYW4geW91IGV4cGxhaW4gd2h5IHRoaXMgZmxhZyBpcyBleHBvc2VkIHRvIHRo
ZSB0b29sc3RhY2s/DQoNCk9oLCAgSSBtaXN1bmRlcnN0b29kIHRoZSBwcmV2aW91cyBkaXNjdXNz
aW9uIG9uIGludGVybmFsIHVzYWdlIGEgYml0LCBzb3JyeS4NCg0KQW5kIEkgd2lsbCBtYWtlIGl0
IGJhY2sgdG8geGVuL2luY2x1ZGUveGVuL2RvbWFpbi5oIA0KDQo+IA0KPiBDaGVlcnMsDQo+IA0K
PiAtLQ0KPiBKdWxpZW4gR3JhbGwNCg==


From xen-devel-bounces@lists.xenproject.org Fri Oct 15 10:05:21 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 10:05:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.210111.366840 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbK5V-0002XV-Io; Fri, 15 Oct 2021 10:05:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 210111.366840; Fri, 15 Oct 2021 10:05:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbK5V-0002XO-Dj; Fri, 15 Oct 2021 10:05:17 +0000
Received: by outflank-mailman (input) for mailman id 210111;
 Fri, 15 Oct 2021 10:05:16 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=FGCa=PD=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mbK5U-0002XF-Kp
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 10:05:16 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 0fcccf13-fb38-4ebe-bf8d-b850cc8e8a3f;
 Fri, 15 Oct 2021 10:05:15 +0000 (UTC)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2111.outbound.protection.outlook.com [104.47.17.111])
 (Using TLS) by relay.mimecast.com with ESMTP id
 de-mta-10-DQCCqSQoN3i1lpyqPKX5sw-1; Fri, 15 Oct 2021 12:05:13 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB4352.eurprd04.prod.outlook.com (2603:10a6:803:4a::25)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.17; Fri, 15 Oct
 2021 10:05:09 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.017; Fri, 15 Oct 2021
 10:05:09 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM5PR0402CA0019.eurprd04.prod.outlook.com (2603:10a6:203:90::29) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15 via Frontend
 Transport; Fri, 15 Oct 2021 10:05:08 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0fcccf13-fb38-4ebe-bf8d-b850cc8e8a3f
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634292314;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=Z8bD126L9ldiYG2yNwGi2hmVGOVHgqbVZUjn5UhGaa4=;
	b=H/JElzXwtlvZlS87/NjN/P/ADhkjSwSW10IFrJ38bf6YK57EXymTqhvhk/66X+831qafKm
	2c18ZT3axad23bs3w7K0CTSCKtCPMtQPXwhTQKTUpo4ZG4ZDF2I9SID+a4mFXksNeUSXTY
	B/y2i3p1z2gnm4zIuT3QhGp7ZkFNgzc=
X-MC-Unique: DQCCqSQoN3i1lpyqPKX5sw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=iE2eMfkjvJ0dxCeX8CdR5g/8icIZJsTXQQW+MY3j7zsn14NVl2kEPWZCKgvZ6CzAXoQ0cG+Yzf5I0qfrdmxpbQVcb7b1aiu/ca22QFzrop1i3o3vFJLo5bpv2ZQNcFxZQfd2hcKmk7tC7oq517rFEuCHyGTbK5riG1uyHPmTMkIHZeC3UIYwyL0b3siiaXDVlSUcih4fjgq/ibSUic20Bl7n2ap0/gsLyPLpCb3lipCxC1FQfHXBTwGN7ZodmXq3r8GyQbyPwc+xknyBiuePVEPO13chBSrhO36xf1lSs5LcpujJPR/rsgPULYezeu9v+sD+6bqc5IE6iUNV8QFViQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Z8bD126L9ldiYG2yNwGi2hmVGOVHgqbVZUjn5UhGaa4=;
 b=NIbaMWsqHCCtvrQPd50pdKIdd2RSIAnT9OJsq+SdafF1fLKRqwQqpwRY73F/0o2igCAGDE71p+sY65lU5DTVMPFLGDCLo0xaYG/yHHwbsLTiFDm/HfiCyP4SXt3ov1ZCZIeFU/Z5e9aUstq77Lkh3Ns9mi5UUNG5A/cOuQ/zquH5MWDDW1V+NF1QuqRt66rTyO1FxFj0MlOHGomDhLLvOQkugz8GLK8mmDQRz04uGt3RTiN2xNmRDOYUK8czOKY1OwnvyrIPbZnEXLRlKOKM8zI+OkvOBw5gyGm0c1BEB9OknCaaZi5b90OW1Clc7Ds54JQEsPBQPRMO/Vw6vncZwA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [PATCH v2 3/6] gnttab: allow per-domain control over transitive
 grants
To: Roger Pau Monne <roger.pau@citrix.com>
Cc: Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Anthony PERARD <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>,
 Christian Lindig <christian.lindig@citrix.com>, David Scott
 <dave@recoil.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 xen-devel@lists.xenproject.org
References: <20210922082123.54374-1-roger.pau@citrix.com>
 <20210922082123.54374-4-roger.pau@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <1d741841-6aaf-1d33-e1c6-b98f77ce41fb@suse.com>
Date: Fri, 15 Oct 2021 12:05:06 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <20210922082123.54374-4-roger.pau@citrix.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM5PR0402CA0019.eurprd04.prod.outlook.com
 (2603:10a6:203:90::29) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 5090543a-96a3-4635-b7cf-08d98fc34543
X-MS-TrafficTypeDiagnostic: VI1PR04MB4352:
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB4352755C60C6CCE72546512BB3B99@VI1PR04MB4352.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	PrbDy7nAKJhdSBGpklO3m1e78ZyNF9zct4bS4CC1/N5fHUS/FlGtQj454yo4JrewMDNudID8Op3bEEJE+US7gwvLT81TzD52Q+BaVJDQfVfWGwstKSuVxrf9c0+M9hdQWIUa/KvM8bWbK7UvHrbMKA5FvY96SyIJw/0spSp6Jf4Jd9QwazBBsllfKc4rf151gU6lUq4vKurG7qr0jhDRvDbpEglBBhOVjOwwjKV+yNZmqb3TcqgvHFj6D3skJdFvzsnjTLtTnmelDmutiQwuH55n6b9074g2VDN/wlPge49OrKBz2WQozvMfp38etjzqqqtuKojYSj0V/OaTGrPSJqQ0g2XoekdIN378BeuUjnWA2qoLWEyeEE/fo6DdvoniriaTiA1JhqF1H2dMPnA+TVRk+/0wTYzZLlUxa6Xvronc9fPxYag1EZGQrVVKtPaQTOn0pCgQFKW0AZ/GBsfOVFfT5lv9cvhHeWKZptgpncegpTAS5KTVZjShlI7nwUElomaxlep3kNItuGuO9IJ5R4kum8pMfrUZwZHmxClRDqkO+GVeDQ5sZzHQCSxpPwuMWcaBOj3s1vKauf7xxbKLVfKSNJDx05NcEAVwXhJLRcpv5kCUV6WazefGX2TQDd2bTl6zTDxLUMMgA6jRBwBfnwQStBHad4Ma4i0VtuomDxc33LUDrrDYJQmZXEkkmD0n4rdGvSLKe1u/KFSCEqTqt1gJK2X0NUJhoSQaCBfSf3H0IncuPaF8IqrU96VAt65A
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(16576012)(54906003)(53546011)(316002)(956004)(86362001)(31696002)(8676002)(26005)(31686004)(6486002)(508600001)(7416002)(8936002)(38100700002)(36756003)(66556008)(66946007)(83380400001)(5660300002)(2616005)(186003)(4326008)(66476007)(2906002)(6916009)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?YlRvYi81Y3hwTWlWM2ZOM1VMOXBVUk9FWlM4Ti9sR0psaFRWd1ByeGJ1aThJ?=
 =?utf-8?B?Y2R6Q0tuZzVkcUVvRytRRnJ1TlNNZHk3eEpHd2hqRDRaY0ozWGwzWnBkVnVB?=
 =?utf-8?B?a2RBeTFJcmVVdzhVMU9hbzVDbVZBRXVPdUNSOStRclU3NDFIakdPamJJN3Va?=
 =?utf-8?B?OERXTWVtU0tnS0J4aS82NFFOMXUwdGxvbUZMelZNaEtadURVN2ZZNUxpRlJq?=
 =?utf-8?B?d3BINDdYbitsRlVKaU1MdVJkbXpEbTlaOVFYK013WHRNUTRBNWx2anlabzhL?=
 =?utf-8?B?UVdmYVJoTzFYK1ZpMjZLVy9iVGYvVzhhSC90TTBSY3ZGNXVtQUZIT3dkN3I3?=
 =?utf-8?B?YWEydXZ3RXdJYi9Ccys3MnRkdEN5bWh6UFF6NmxSemhUVEZkMno3SUZjWXcy?=
 =?utf-8?B?SGx5SG1TRjgwYU9IYTUvdzFjMFlTeU45QTBVUDR6ZElSMDdVMXhtT3lTMVMx?=
 =?utf-8?B?b29YUW5CT08zbXJpSkpVbVdQNW0vM3BUUXZoNVBsdU52MFBQVEJ2dExJaUxI?=
 =?utf-8?B?V3VLSUxDZ3AwUE9sRXVHRlpMZEllV1JiUnFaYlVQYndmT0trK1JHQVBMMTAv?=
 =?utf-8?B?djBCMExuMlZCeWNMRitwYlFiWDQyRGdZUmx0bWFNa0d4NGFOaDltdFFQOXNS?=
 =?utf-8?B?N3VCdWx5emczcjh1OGRvNWVqQmxaTkh6K0lUQUM1VEtzV0RrOWxXczhpaU56?=
 =?utf-8?B?WFRWR3BJUkYzRjNkYXErSS96aWtGN3dLb2wyRGM1d1RKeERTNExWb0ovdEhO?=
 =?utf-8?B?ekJ2Z1YwNmhoOTExNjljamE4SXVvVW5ncWZjZEpEQ1J4bUwrVEltY3dhNWtu?=
 =?utf-8?B?OFlMSEVmTnczMnVKVHhvUGJodlhnbzB4QWlKdmpOTzVrRXY1NzJpQmtGQnJp?=
 =?utf-8?B?SXJEWXc2eTdMaGxqTlFSeERkbi9UMW1qL3FpakgzMGhucnBIa3cyWU1Ibk5V?=
 =?utf-8?B?Mk14SW00ejVmSjZ0S1F3U3lUVDhiblZKYVFrUnBSdGtlNlZKZ3pzemgvQXpO?=
 =?utf-8?B?WGlvc0tWc1MyRDM2WUd6OUNiY2xuYlovNU4yK1E5RzhWS3dVeDF0ekVhdWpa?=
 =?utf-8?B?Wjg3V2ZSY1BvbTFaR3I0WXNvT25PQkNxT29PMitrL0cra21TZjRxR0lONnVs?=
 =?utf-8?B?blQxK3k4ZWM5MnhOS1dxazdxaFlYWmRPN2pjZ2pvelpvNDZ2K3d4OHhrQUNE?=
 =?utf-8?B?cDUrRDFySm1kRjJUeGhXVmd6RldaNFhGcEV3b1U1Y0dKZVlEZGl3Rjlkb0lJ?=
 =?utf-8?B?U3FxTXRUVnlhejBQREZ4a3dEQlZVVllnWGU5eVFiZmp3dXJRdlRQYXovQzZQ?=
 =?utf-8?B?ZGRrdmpPRlk2QUszNTBtZWxhWmxNVStlamFZZDYvbnFQQXQ3VUtpaGNkNDlm?=
 =?utf-8?B?UnpDRXcwVmp2djBLQ2J2QmFNK28rYmFLUHpsbHhGTFcrRFM2Z3lKbzdkTnor?=
 =?utf-8?B?K1haTlB4ZWorQk1NRVYwaEU1OHNDcVc4ZFBKdWI1QXNRckdFVmg5WnpIdU44?=
 =?utf-8?B?WXA2SHl3SXFYcVRnRjRrOTBLV0VPOWRmbytQZFVRWHNwSW52SlFzeksyZnpP?=
 =?utf-8?B?bkMzUEc0RnNFakx3cHFUR1ZINFc1bGlJb2tJMjV1QSt2ejZEa3JrQng5ekNN?=
 =?utf-8?B?aytDamhIcnlOSCtLQkVmRk56SmhTQXBUZVJBYWt2N2M2NG9SRGcxU2k5M291?=
 =?utf-8?B?aEJIcXlLYnpoNkRBbnlDR1RQNFRMZjdXcjlNeDloNGY4TU4rYk40VGw2QjU1?=
 =?utf-8?Q?VgicpP7w+oBkuTqT7Kk/5Tvq3Hmrv0DcrwWWY+B?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5090543a-96a3-4635-b7cf-08d98fc34543
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2021 10:05:09.4005
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Mx2bfplmRq3T83S5Y9ebUYZvTV9fQQBrCLXK62Pg1gWPj0hJLwKEl2aXGz4aLz4tC78eKOb2Oy4Bv1hyEUzHjA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4352

On 22.09.2021 10:21, Roger Pau Monne wrote:
> --- a/xen/arch/arm/domain_build.c
> +++ b/xen/arch/arm/domain_build.c
> @@ -2649,7 +2649,8 @@ void __init create_domUs(void)
>              .max_evtchn_port = -1,
>              .max_grant_frames = -1,
>              .max_maptrack_frames = -1,
> -            .grant_opts = XEN_DOMCTL_GRANT_version_default,
> +            .grant_opts = XEN_DOMCTL_GRANT_version_default |
> +                          XEN_DOMCTL_GRANT_transitive,
>          };
>  
>          if ( !dt_device_is_compatible(node, "xen,domain") )
> @@ -2757,7 +2758,8 @@ void __init create_dom0(void)
>          .max_evtchn_port = -1,
>          .max_grant_frames = gnttab_dom0_frames(),
>          .max_maptrack_frames = -1,
> -        .grant_opts = XEN_DOMCTL_GRANT_version_default,
> +        .grant_opts = XEN_DOMCTL_GRANT_version_default |
> +                      XEN_DOMCTL_GRANT_transitive,
>      };
>  
>      /* The vGIC for DOM0 is exactly emulating the hardware GIC */
> --- a/xen/arch/x86/setup.c
> +++ b/xen/arch/x86/setup.c
> @@ -750,7 +750,8 @@ static struct domain *__init create_dom0(const module_t *image,
>          .max_evtchn_port = -1,
>          .max_grant_frames = -1,
>          .max_maptrack_frames = -1,
> -        .grant_opts = XEN_DOMCTL_GRANT_version_default,
> +        .grant_opts = XEN_DOMCTL_GRANT_version_default |
> +                      XEN_DOMCTL_GRANT_transitive,
>          .max_vcpus = dom0_max_vcpus(),
>          .arch = {
>              .misc_flags = opt_dom0_msr_relaxed ? XEN_X86_MSR_RELAXED : 0,

While I can see that you make these adjustments for retaining backwards
compatibility, I wonder if we need to, at least for Dom0. Dom0 doesn't
normally grant anything anyway and hence would even less so use
transitive grants. Of course then there's need to be a command line
control to re-enable that, just in case.

> @@ -1965,6 +1969,8 @@ int grant_table_init(struct domain *d, int max_grant_frames,
>      gt->max_grant_frames = max_grant_frames;
>      gt->max_maptrack_frames = max_maptrack_frames;
>      gt->max_grant_version = max_grant_version;
> +    gt->allow_transitive = !!(options & XEN_DOMCTL_GRANT_transitive) &&
> +                           opt_transitive_grants;

No need for !! here afaics. Not even if there weren't the &&.

As to combining with the global option: I think if an admin requested
them for a domain, this should overrule the command line option. Which
in turn suggests that the command line option could go away at this
point. Otherwise, if you AND both together and the guest is known to
not work without this functionality, domain creation would instead
better fail (or at the very least it should be logged by the tool
stack that the request wasn't satisfied, which would require a means
to retrieve the effective setting). IOW I would see the command line
turning this off to trump the per-guest enabling request.

> --- a/xen/include/public/domctl.h
> +++ b/xen/include/public/domctl.h
> @@ -98,8 +98,11 @@ struct xen_domctl_createdomain {
>  /* Grant version, use low 4 bits. */
>  #define XEN_DOMCTL_GRANT_version_mask    0xf
>  #define XEN_DOMCTL_GRANT_version_default 0xf
> +/* Allow transitive grants. */
> +#define _XEN_DOMCTL_GRANT_transitive     4
> +#define XEN_DOMCTL_GRANT_transitive      (1U << _XEN_DOMCTL_GRANT_transitive)

Omit the former and have the latter be 0x10 or (1U << 4)?

> -#define XEN_DOMCTLGRANT_MAX XEN_DOMCTL_GRANT_version_mask
> +#define XEN_DOMCTLGRANT_MAX XEN_DOMCTL_GRANT_transitive

I didn't even spot this in patch 2 - what is this intended to be used
for? Neither there nor here I can spot any use.

Jan



From xen-devel-bounces@lists.xenproject.org Fri Oct 15 10:06:46 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 10:06:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.210121.366851 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbK6w-0003D3-05; Fri, 15 Oct 2021 10:06:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 210121.366851; Fri, 15 Oct 2021 10:06:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbK6v-0003Cw-Sz; Fri, 15 Oct 2021 10:06:45 +0000
Received: by outflank-mailman (input) for mailman id 210121;
 Fri, 15 Oct 2021 10:06:44 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mbK6u-0003Cl-OO
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 10:06:44 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mbK6u-0001Bc-Mr
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 10:06:44 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mbK6u-0002pC-Ll
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 10:06:44 +0000
Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89)
 (envelope-from <iwj@xenproject.org>)
 id 1mbK6p-0005II-P7; Fri, 15 Oct 2021 11:06:39 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date
	:Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From;
	bh=Kl5bV6qIhI9Bc76pmX+92Fxx+x8FhCpO8AuWretIQpw=; b=zpNc1vYdBUZoYpfCfzHi3kmHkc
	XiNf7JqHnPn0o9E36D82g1khDpjXqQD4WLenXeesJMyFk69PrEbMoHnyZLCOJ3qXLp6L2ojtQWa5L
	UMHF+opKXh9CTkMl1GUF6QKKXhuNblPpT3BR38Wb+qfTOtlXgjR4d1QYEiz1LBXP2ws0=;
From: Ian Jackson <iwj@xenproject.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <24937.21167.484708.191165@mariner.uk.xensource.com>
Date: Fri, 15 Oct 2021 11:06:39 +0100
To: Juergen Gross <jgross@suse.com>
Cc: Ian Jackson <iwj@xenproject.org>,
    xen-devel@lists.xenproject.org,
    Andrew Cooper  <andrew.cooper3@citrix.com>,
    George Dunlap <george.dunlap@citrix.com>,
    Jan Beulich <jbeulich@suse.com>,
    Julien Grall <julien@xen.org>,
    Stefano Stabellini <sstabellini@kernel.org>,
    Wei Liu <wl@xen.org>,
    Samuel Thibault <samuel.thibault@ens-lyon.org>,
    Community Manager <community.manager@xenproject.org>
Subject: Re: [PATCH v3 0/3] disable building of pv-grub and qemu-trad per
 default
In-Reply-To: <2037c30a-5ac4-caf6-b47b-f2574422151f@suse.com>
References: <20210910055518.562-1-jgross@suse.com>
	<24891.31480.165445.521062@mariner.uk.xensource.com>
	<d894799e-27c6-bbbd-8d65-3e32c1aff843@suse.com>
	<24913.55427.402592.660538@mariner.uk.xensource.com>
	<2037c30a-5ac4-caf6-b47b-f2574422151f@suse.com>
X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu)

Juergen Gross writes ("Re: [PATCH v3 0/3] disable building of pv-grub and qemu-trad per default"):
> I believe patch 1 of my series could go in at any time, as it is just
> fixing a bug.

Oh yes, indeed.  Done.

Ian.


From xen-devel-bounces@lists.xenproject.org Fri Oct 15 10:09:04 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 10:09:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.210129.366862 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbK99-0003qE-Dm; Fri, 15 Oct 2021 10:09:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 210129.366862; Fri, 15 Oct 2021 10:09:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbK99-0003q7-9O; Fri, 15 Oct 2021 10:09:03 +0000
Received: by outflank-mailman (input) for mailman id 210129;
 Fri, 15 Oct 2021 10:09:02 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=FGCa=PD=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mbK98-0003pz-2W
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 10:09:02 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id ea50780a-2d9f-11ec-822c-12813bfff9fa;
 Fri, 15 Oct 2021 10:09:00 +0000 (UTC)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2173.outbound.protection.outlook.com [104.47.17.173])
 (Using TLS) by relay.mimecast.com with ESMTP id
 de-mta-29-m0YwLdz_MAOuDl1-T66vnQ-1; Fri, 15 Oct 2021 12:08:58 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB4352.eurprd04.prod.outlook.com (2603:10a6:803:4a::25)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.17; Fri, 15 Oct
 2021 10:08:57 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.017; Fri, 15 Oct 2021
 10:08:57 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM7PR02CA0016.eurprd02.prod.outlook.com (2603:10a6:20b:100::26) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.17 via Frontend
 Transport; Fri, 15 Oct 2021 10:08:56 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ea50780a-2d9f-11ec-822c-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634292539;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=jUDAo3tVpGKKJeF98JoZ41MZHO9meDQxahh0ucIWiv8=;
	b=avpbSAaIqa1zl6nzirtyPPzB9/OP16wkIlCis3hugd5xtyO5ElMUQY3bo/ykjsiAei9Q/N
	X0OUXrPCrN+Du8RpbKYacWtC6UUCEgxPOamUwem9EMX8+U5ZkIAsr7tH5F6zYfkT5NwKUM
	BZ9LY7zm51lAVgp9ZGxAs/lcrEjJORc=
X-MC-Unique: m0YwLdz_MAOuDl1-T66vnQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=IYjWyZXIyfXQ2mJixILjYZGFB3b0r26npNclY368PMcSUcbnA74auipC7cO+hEYICcS3JJX4OgZEiZDi9O0lfzl37eg01i1L1Kn6Vp5f2fNdNeiVwvr7qq75HMtCTdU3F79+y2/NJYbdwUdoTuOqa+PZox5TVxQmCQDMI3DCb2d1iiCIKaKqCoshpgR0PAA7pCLE26er/P8iUbaJLxHHDp1wpETC0MI7uSGeDHuwEcxxGPYMe6ahbi2oect7Q59LFx3IWc9XnDSCEdCADvjE4KTb/LlCJRzKhCg7dNlEyIKdzTOi6YStecx+SRbIWVWNgd3/auqovkTdF2J2e+LCWA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=jUDAo3tVpGKKJeF98JoZ41MZHO9meDQxahh0ucIWiv8=;
 b=N+cbx/y3muq/gO1XJai1MzyE0PSLbFeHR+1UHcAkA81e/x+mVHv6Pl25AHGtgKTeHHsxMWmY55J5C7v8cWFlD6dxnorzpx+09ydWeJOu7bwdytFKDFNYN1RpeEWpbsjJ5gwa9KCbEwamRQgh+C+kmvTYG6dgVm7arVqu1W0vMD2bRJNYQHNqBcvfuJx6E5iEG7nzMbtpq+IBYECpp7T3vpaZkc7QDaKY+UAyx4Q3jMAztzXDqbCIsAYwRJPHtOCFbhPnWwz44DF3amxsiMVtD0Vo8fUHh/KY/8YIet+F63DlVjPmibigvALVI6x8q+NtlqQZC6+Cn+Qs7fX3zObRBA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: xen.org; dkim=none (message not signed)
 header.d=none;xen.org; dmarc=none action=none header.from=suse.com;
Subject: Re: [PATCH v2 1/6] xen: introduce XEN_DOMCTL_CDF_directmap
To: Penny Zheng <Penny.Zheng@arm.com>
Cc: Wei Chen <Wei.Chen@arm.com>, Bertrand Marquis <Bertrand.Marquis@arm.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 "sstabellini@kernel.org" <sstabellini@kernel.org>,
 "julien@xen.org" <julien@xen.org>
References: <20211015030945.2082898-1-penny.zheng@arm.com>
 <20211015030945.2082898-2-penny.zheng@arm.com>
 <073d4b36-cb2f-88b2-76d2-3438d4ef589a@suse.com>
 <VE1PR08MB521583497AD2D7A3FA3AAA8CF7B99@VE1PR08MB5215.eurprd08.prod.outlook.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <6e4895d7-9a89-59a4-af41-83668bfd1ae9@suse.com>
Date: Fri, 15 Oct 2021 12:08:55 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <VE1PR08MB521583497AD2D7A3FA3AAA8CF7B99@VE1PR08MB5215.eurprd08.prod.outlook.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM7PR02CA0016.eurprd02.prod.outlook.com
 (2603:10a6:20b:100::26) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 10e1df13-8ddc-4639-990b-08d98fc3cd32
X-MS-TrafficTypeDiagnostic: VI1PR04MB4352:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB4352EAA3EE7EB7531BA9C567B3B99@VI1PR04MB4352.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:826;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	2b+l5jgQq8rtLSrXeM4LFk1Nwr81mbtWb0+7amkFjTdcPjfewWDeQvA5zdJ5a+i+sZBmf71yzrky3epv9NRW68bgLwKvz+rvORIscbNsa3Ykos1bqtRVc3GAPBbYRK149IuVnVYdKFZ7Je6zIt9QJhJLVTA/4pnBoRkcsFUxBjI07Ve1KfTsIWsJBRcdlEacS8t8xxrjdPAPCvH7xguNG+gTdYv2lZls+XrWo98BBkzqxaf+iOg8f9kenKmCu55Ok622R5P2tl8bmzrqpDkgMeR9k3UmUYq8MFrLpHg4LTQy7mKrEJr/M9+jZQElyAMSGdgbNRHLadtVr/+LUXQpHEdfXAOJ8uvErB5T40aPDGfHe3u52h5Mvl55ij1plal0l4Sl+d1x55nDwObcz3Gzy+T2dD9mPETeUrwhQRaNiEAFp0pXDOZGtlaVHEDPKQj9gfHx81hRlY2Q1Z9JjHBl6yY17TyXo+g6+PUXShHjAg0Qelf+39z2/WqaAp9uvlqJIAQBhofUs9hXaV6q7QnaysX9K/hfrAPmNSc+Y+PqCviDSxmIPUFJKahW6pbWxZW9KVrbpCoG/+Dj/Q4h19l31fCsXVT3OYBd6oDRXal3kMtya+vMDmo166E5Bd6cKy9AvpdBtGnaHvNbaIJcOyh7cdeUmi60tKLczusfgV7udWECkjCQXmKuq1gflIfcMM2iOt3j7w1OmcZlYR8ybn/kwieH9sDHS9Uqc2dj/WW9cehaleRhvqDTsZ4M7CP0Kx9HSyHJahT+OJHjAgyqMO8fWzNgCHr5iUxlhRKoZnqRxdjYNyrOpy+VtS/dcnMqI0CsFfF8RWFJN0lvFxOrR5b1FQ==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(16576012)(54906003)(53546011)(316002)(966005)(956004)(86362001)(31696002)(8676002)(26005)(31686004)(6486002)(508600001)(8936002)(38100700002)(36756003)(66556008)(66946007)(83380400001)(5660300002)(2616005)(186003)(4326008)(66476007)(2906002)(6916009)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?cjRhejg0RWlacElNV1lDL3FzR3FQa25uYUhPYWVGaEMrSmloWHZ5SHRQQ3FN?=
 =?utf-8?B?eXdBM2VKQWw5Rno4ZlRIVDFYS3Y0ZVpITmpWdkpmZ1BJc2k4YWJKLzVzU1d2?=
 =?utf-8?B?WTQ1M3lLeHZ0Nkhpc1p3U2lkYjFXVzIreWcrMUl1MHNqRlRaZDUyYlNKaTdZ?=
 =?utf-8?B?RW1sK0s0M1NNZnpXaWZRRG1LV3g1UkJxbWpwY08vM1BsL2dwc1BBWXNUOWJt?=
 =?utf-8?B?UU9HTmpaNE80ZXp5dzZuMHBuY0F5WTdCNnlnSnQ2bDFpTEYvSW1EOXJhVHd5?=
 =?utf-8?B?MThlKzVaWGQ4NDkxZjVYNnhpdGhKYkVndlVzVHdRdnBHS2pSblNXa3VJMDdK?=
 =?utf-8?B?SllXdTBNY2JXR1E4NlBsSUxKNXJYeENteFF3RGhOTEVIT1EwV0x4SzNNdE5E?=
 =?utf-8?B?MlZMN0xOTWxBN2l3dnlwbVBVTmlFRnFmSnI1QnJ5akNZbytCUWM4aWVCVVZX?=
 =?utf-8?B?NkdCeW1uelBrUzJyYmRGNkZrWXFyMGxEKzJqYWlrbFRZbm0xNG5JYjQ2RXVs?=
 =?utf-8?B?YldxQmNza2w4UlJOS20xdGtyOVk0T3ZRQXc1Rkhud3RJTWJ5NVNLSTQzTFNp?=
 =?utf-8?B?U0s5WlFkQWJYRmFFUTVvMTlNL3hXMVlvV0J0RzRGU0ZQRVFXejkzK2piUnk3?=
 =?utf-8?B?WmZrZ0pCdHJtMm1SWVNWUTU5MVg0eHNxQ2orc3RLZmFYdTdlalJKOUw1aGZH?=
 =?utf-8?B?RmV4ME9EWmQ3MEhOR09jUEtQZHJTUExlQVVGeDFPMTBDVms3UzRnSGpqR1A0?=
 =?utf-8?B?WEpLY05FTTJqZnNvdUVYYVlRUTkwODcvQ05vTTF6QU5mVkVjZ05SQ0daeXhR?=
 =?utf-8?B?Mk54R2M1T1J5L1RhL1FSaWI2ZTRqVDM1Y3R0VU5ONDRtK21jeUZWWlhPcngw?=
 =?utf-8?B?TnBJMHZFYVlrcnZOTFA5eGxzQXJUMVpEYm9aVGpXdm54a2g3NlFWQU0wR2tY?=
 =?utf-8?B?MTI0M1dpWjhiL2VnU0diWGxFeVRFemtzRjZoTjF1cS9sdkJsVjZiWWViYmNP?=
 =?utf-8?B?dG4wcmVDUzB0TThlZFp5bzhJbVZqN1VsYVh5aXRic0pLazJDY3NwalRxenFl?=
 =?utf-8?B?cERpVjlaclkyY0xnS3hIMURGTCtLQ1BhL25jdlB2Qk5LM25iKzBJWmh6T2Z1?=
 =?utf-8?B?UjVsUjNxWEc4eFlaOHY2N1o2UDFEa2l0RVVqY1YrN0RFZ1laSEdQS09sUS9r?=
 =?utf-8?B?M2hpUzc5T003MHBxQm16UnR2ZGp1b1FFN3pVSENjaC91U3JFV2lBKzc2LzJZ?=
 =?utf-8?B?dFE1R0Y1WTlDV09xWVBFcW5Ya1hmVUlJMzVneWtyMlVyaWF3enZvVTRJTUxP?=
 =?utf-8?B?cGxlOHVKMHB1OExualMyaEh6ZlV1TU5zV2dqSUdaVlAvYS8xd2hpYXR1RGJO?=
 =?utf-8?B?WnY4TnU2OHhNMmNIeDlCYlJxcFZLTENZeTdoeEc4VkVDWmdWQ3NJTWhsbjN6?=
 =?utf-8?B?VDNpajE0dUlnM1BscFBDOVg2UzBVSnFwWGVEblYzYzVydHduNEpjS3dMbnRv?=
 =?utf-8?B?VzZjbHJLbEF1MDlxU3dMWHJoV0R5WmMwLy9udERFYlBIOFc1YTFvM1dGelc2?=
 =?utf-8?B?azFmTUdNcjRJL0JDQU1KdDNrSldySmZmcWtDOGg2cUhncGp6bWJ2Mm1TL2Ry?=
 =?utf-8?B?WmJLbklhUVNJNmNUcy9SWGJUV2RaL1cweEFTbmp6RzN5Yjl6Vy9PUFA1cUFw?=
 =?utf-8?B?YkprSXAwYVNDNktCcENQQ0NqMGFnRWp4cnhBK2huRVNyT1pIc29vRk9HTWhW?=
 =?utf-8?Q?/48zZ1AE3SWGLQ8ALSVEy/ru5xq1emNS0CKhnJa?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 10e1df13-8ddc-4639-990b-08d98fc3cd32
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2021 10:08:57.4465
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zFrcXjlTGWLt8/MwvercCkjFYdYrWgQDu9vDtF4FN1KPK+pNTSUq/p3AETNmbVDb76Dm1c72Usulju4ZwHQtEA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4352

On 15.10.2021 11:59, Penny Zheng wrote:
>> From: Jan Beulich <jbeulich@suse.com>
>> Sent: Friday, October 15, 2021 4:47 PM
>>
>> On 15.10.2021 05:09, Penny Zheng wrote:
>>>  xen/arch/arm/domain.c        | 3 ++-
>>>  xen/arch/arm/domain_build.c  | 4 +++-
>>>  xen/common/domain.c          | 3 ++-
>>>  xen/include/asm-arm/domain.h | 4 ++--  xen/include/public/domctl.h  |
>>> 4 +++-
>>>  5 files changed, 12 insertions(+), 6 deletions(-)
>>
>> You clearly had to re-base over the XEN_DOMCTL_CDF_vpmu addition. I think
>> just like that change (which I'd expect you to have looked at while doing the
>> re-base) you also need to at least fiddle with OCaml's domain_create_flag, to
>> keep the ABI check there happy.
>>
> 
> The patch serie is based on the staging branch with an extra commit "
> Revert "xen/domctl: Introduce XEN_DOMCTL_CDF_vpci flag", which
> Is already been pushed to community for review.(
> https://lists.xenproject.org/archives/html/xen-devel/2021-10/msg00822.html)

I was assuming so, and hence I didn't also refer you to the vPCI
patch, which you could also have used for reference. I guess my
primary problem here is that I can't see what you're trying to tell
me.

Jan



From xen-devel-bounces@lists.xenproject.org Fri Oct 15 10:09:25 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 10:09:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.210133.366873 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbK9V-0004L7-NB; Fri, 15 Oct 2021 10:09:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 210133.366873; Fri, 15 Oct 2021 10:09:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbK9V-0004L0-IV; Fri, 15 Oct 2021 10:09:25 +0000
Received: by outflank-mailman (input) for mailman id 210133;
 Fri, 15 Oct 2021 10:09:25 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Fqmt=PD=arm.com=Bertrand.Marquis@srs-us1.protection.inumbo.net>)
 id 1mbK9V-0004He-1h
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 10:09:25 +0000
Received: from EUR01-DB5-obe.outbound.protection.outlook.com (unknown
 [40.107.15.50]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 33ba2ead-6df8-497a-b42c-527ce4b91460;
 Fri, 15 Oct 2021 10:09:24 +0000 (UTC)
Received: from DU2PR04CA0181.eurprd04.prod.outlook.com (2603:10a6:10:28d::6)
 by AM5PR0801MB2002.eurprd08.prod.outlook.com (2603:10a6:203:49::18) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.17; Fri, 15 Oct
 2021 10:09:21 +0000
Received: from DB5EUR03FT022.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:10:28d:cafe::24) by DU2PR04CA0181.outlook.office365.com
 (2603:10a6:10:28d::6) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16 via Frontend
 Transport; Fri, 15 Oct 2021 10:09:21 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT022.mail.protection.outlook.com (10.152.20.171) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.15 via Frontend Transport; Fri, 15 Oct 2021 10:09:21 +0000
Received: ("Tessian outbound f1898412aff1:v103");
 Fri, 15 Oct 2021 10:09:21 +0000
Received: from 54aa9056040b.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 A323C787-AF16-4B27-BEF8-E968EDEF0AB4.1; 
 Fri, 15 Oct 2021 10:09:13 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 54aa9056040b.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 15 Oct 2021 10:09:13 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com (2603:10a6:4:74::9)
 by DB6PR08MB2677.eurprd08.prod.outlook.com (2603:10a6:6:1c::22) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.17; Fri, 15 Oct
 2021 10:09:11 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955]) by DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955%4]) with mapi id 15.20.4587.031; Fri, 15 Oct 2021
 10:09:11 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 33ba2ead-6df8-497a-b42c-527ce4b91460
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ennNuK/Wq7Q2ZVgzWxwtNJOmEZblBDQgnZ0q1aBiXyg=;
 b=crTVwVoLXdnLJSf+oBYdsosMPytDBdFLq7FLWfHXWy4E8MbDqqLuTgt7UHajeO8SWUaGQvEYQiZpWq46v2TPdHkxWPikCl8IgTE0WuDc+s9ncU2zE9logiAE2hUc8Tj2E+g+2eEH35sC0SigJGcmcfSY1Baia6rLTzsNxUihn+E=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: cb11f23102aaab6d
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=DA0OpZu35m3ns0UOdCCQy7/TmGF6YPxSUX7A8BPKa7BDgUFJepgLNTaPZrj7K++/DnmC3l0MFurXxr/lEs5bWATwGFQwORUxiIpXVoaH/EMV27Lx85kGkUlahsdUeSyGSvbs/ISAtl+1Axl48eq0G4wIEhGVN1YSHgKqf1hDah12EhAMTz0iTbOi1adddhMNk9gRzTcdAhp438punmXetcjwgbO/kXbuw5A+hYgjwisi6DPNGEZjR4Q9U9al2Doe3tVFjZb44qQQ4ie9JLHOs3LuX/vPXQop/d55D2PDaOxQAGSfEA6W0vyfNb5IRgcty8jq181iU1tu6smqgviWBw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ennNuK/Wq7Q2ZVgzWxwtNJOmEZblBDQgnZ0q1aBiXyg=;
 b=iCdPvYwqiRd18E2TkPMnqbaZ9cHhaYsSmK42dBRHgiC18q9+HtYP1FyDJxDACNiXMyL2S9ZR459BWBScvzdIKS1QHh70i6AwGZ6VBOq6UAdhyvzzPympfM4oZ3G8VQodbcJ3T3sFtvEbGHaDQOhs9GDFPSyG4G0J9WLBGYFsE9D2Fztmw0h4rQAz5Q0CqTQYTP1Btg8onYlkm78sZ7vF/CS/btdjI1w3Qe1z7A9drZRV0FoKFTc93szEUb/7Z/Uv0hqFHAs5/EdqmacljCr9GL/HEO22HaN3xEHxvaKHsLTNRRM766B3T0gr//daY26xJ0FA7jZi/XoQbc+OvfhkSA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ennNuK/Wq7Q2ZVgzWxwtNJOmEZblBDQgnZ0q1aBiXyg=;
 b=crTVwVoLXdnLJSf+oBYdsosMPytDBdFLq7FLWfHXWy4E8MbDqqLuTgt7UHajeO8SWUaGQvEYQiZpWq46v2TPdHkxWPikCl8IgTE0WuDc+s9ncU2zE9logiAE2hUc8Tj2E+g+2eEH35sC0SigJGcmcfSY1Baia6rLTzsNxUihn+E=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Jan Beulich <jbeulich@suse.com>
CC: =?iso-8859-1?Q?Roger_Pau_Monn=E9?= <roger.pau@citrix.com>,
	"iwj@xenproject.org" <iwj@xenproject.org>, Rahul Singh <Rahul.Singh@arm.com>,
	Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, Andrew Cooper
	<andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>, Wei
 Liu <wl@xen.org>, Paul Durrant <paul@xen.org>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v6 2/3] xen/arm: Enable the existing x86 virtual PCI
 support for ARM.
Thread-Topic: [PATCH v6 2/3] xen/arm: Enable the existing x86 virtual PCI
 support for ARM.
Thread-Index: AQHXwQrjS6mPrKT7Q06z3N66FcsDAKvTs1WAgAAj+QA=
Date: Fri, 15 Oct 2021 10:09:11 +0000
Message-ID: <57A39480-34DF-4BF5-9B0E-802D30F94BBD@arm.com>
References: <cover.1634221830.git.bertrand.marquis@arm.com>
 <396b08e2598cf0338e0c7f4ad3cd5cb66db89224.1634221830.git.bertrand.marquis@arm.com>
 <f41f59f7-69ed-e2fe-dc17-434b456cf693@suse.com>
In-Reply-To: <f41f59f7-69ed-e2fe-dc17-434b456cf693@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3654.120.0.1.13)
Authentication-Results-Original: suse.com; dkim=none (message not signed)
 header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: 34ace1d2-8d42-4031-83b7-08d98fc3db54
x-ms-traffictypediagnostic: DB6PR08MB2677:|AM5PR0801MB2002:
x-ms-exchange-transport-forked: True
X-Microsoft-Antispam-PRVS:
	<AM5PR0801MB20023564B319AC67C5B995709DB99@AM5PR0801MB2002.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:6108;OLM:6108;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 smCvQEaEV0ttsD2NcTDYfv3pnlAUbtvpKbLGkdPfKXx2IhCqP0Yl6DP7t1ytYd9UPf5kDsl/p2WNaY8NOX0hF1LoRoJN5PIzXBwCF2g2D5UBVjs8doCt0zs10sjXEG33ZUO3nTWzXyd9EcH/5Txf6cz4Q3VRm9DhGYwb4zbFpn+dAda5ZzROnISFbuLhcKyf0vWSoT4PSrydGq6P6+ehzO7JxL+cvFZGI9KyH6xNimo49IX6pprvzM1m8bpQRJ56lGM985GRseRRApmCfnCgq1yILo6e1+V9V57AR5N5HGn7moCQCVP52eF4M+N7ZPcCwia+zfAorQapfzyYV4U4rwOZIkPfzRum8GR/Y7jgRuEpXaSfY0S4EmcTxXZkG2vKhEpgjGNCEax97oC6YHxZYqXEF6/2gUVWGZWlicTu1HYhW6hoCHzF+NS33CdAm0heCvKrblr2bcoE9IFl4tJ2fU2kbI1WD/L8k0cCFwoQRkzFXE196eLOUFPCwORCskH5jvOgw/1+MViMCvk0szayLpoe4zEIDWVQfbvSJPIJRcS+qIG31dWJshgpnRjIlG34UBspAq0dsjIBHGu+vKNkDqMz7Q3hZRIVKkzftr79whVcrw5d8AyDhlaakNAy7yYqwMdqtCJg/G6udcSgTxXZOvFd8n5soaJnAeZE4umuYEoXVEEAy3v838QAiS3zP9MZArdr5sHrP6nIQuf9DwxUDe002K/cT3Hz5wmAi/Mn8Vo9u6i2t4xfM/NQZ3j7EUAP
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB6PR0801MB2024.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(316002)(8676002)(53546011)(508600001)(2616005)(4326008)(33656002)(71200400001)(83380400001)(6506007)(54906003)(36756003)(6512007)(186003)(66446008)(64756008)(66946007)(66556008)(66476007)(38070700005)(8936002)(7416002)(6916009)(76116006)(6486002)(86362001)(2906002)(5660300002)(38100700002)(91956017)(26005)(122000001)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="iso-8859-1"
Content-ID: <75F9127404561B49A51A22E81F49C6D0@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR08MB2677
Original-Authentication-Results: suse.com; dkim=none (message not signed)
 header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT022.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	2f54eca4-191d-418a-2582-08d98fc3d586
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	VqQMfVygePHw+2Ys9489TySsaXcY4QNHdTn/QCtOA1PT3x8Hx7HQQ9ll3gJttOQ8FpKwWEHxllrOWyiJp1noTkJz4kIVNc5nlmh7CYRRRLLEkKRNrSJsL+YFoQPAaeQm90ZKZqFc9mQRpgqhKMMi0Yxl3Um9SrCjRvLvh4TqmMLqH8ikMIEoDa19+hgrI8KqdPDltQmLeWggiOhsCPKysx6sGVVwnHXBeh/n7UF+srxAdCXwZffHl/vttymz6CMnZ4KDlZegT+K+goE/Xns7G8sQq9PLYz5OUl4R52zMLHNBlCJY92qbg7ertJF67uDT4LWqEA/+j77g58K98RuYu3us1bs55HD/cw14+jfnY21yx1VlSL9VIPDMkNXdH7dWYVhoBFS7wjO34+Hmo5L3yUp1CUzEtsU+yJ0WBzzbGzkO5afpTgxTtH9Y3/CSVr9rakYENH0qUc9nA7f+RW2pia7XJLKYF7NovCirKwr2Lni1mjgXiMwtULqUp/BSE8na4JeMM9TAo+H+UJTUKme+CTTwDcJMCdA10l/wvmX2dtxvY1bH4YMJf06pCQheZG8ZiKHXwKBTYVhwFuLyGu1jD7jz70simpL2wNf82M3zXTB2gxQIQucviQAt3ZQBS11k/IbRZAoe/jM5vM1Woh3JIjc7qsp/GPyOHdxMow2v2Hgl3LxtqDA6q0paArZtM+OwdYl4ku1Gp79PxqNQ/xA1Bg==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(33656002)(186003)(6862004)(6486002)(336012)(316002)(54906003)(4326008)(2906002)(83380400001)(26005)(70206006)(5660300002)(70586007)(36756003)(2616005)(8676002)(82310400003)(8936002)(356005)(6506007)(81166007)(508600001)(53546011)(6512007)(36860700001)(47076005)(86362001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2021 10:09:21.0699
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 34ace1d2-8d42-4031-83b7-08d98fc3db54
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT022.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0801MB2002

Hi Jan,

> On 15 Oct 2021, at 09:00, Jan Beulich <jbeulich@suse.com> wrote:
>=20
> On 14.10.2021 16:49, Bertrand Marquis wrote:
>> @@ -752,6 +752,19 @@ int pci_add_device(u16 seg, u8 bus, u8 devfn,
>>=20
>>     check_pdev(pdev);
>>=20
>> +#ifdef CONFIG_ARM
>> +    /*
>> +     * On ARM PCI devices discovery will be done by Dom0. Add vpci hand=
ler when
>> +     * Dom0 inform XEN to add the PCI devices in XEN.
>> +     */
>> +    ret =3D vpci_add_handlers(pdev);
>> +    if ( ret )
>> +    {
>> +        printk(XENLOG_ERR "Setup of vPCI failed: %d\n", ret);
>> +        goto out;
>> +    }
>> +#endif
>> +
>>     ret =3D 0;
>>     if ( !pdev->domain )
>=20
> Elsewhere I did point out that you need to be careful wrt pdev->domain
> being NULL. As the code in context clearly documents, you're now
> adding handlers before that field was set. In comments to a prior
> version I did already suggest to consider placing the new code inside
> the if() in question (albeit at the time this was mainly to make clear
> that error cleanup may not fiddle with things not put in place by the
> iommu_enable_device() alternative path). This would have the further
> benefit of making is crystal clear that here only handlers for Dom0
> would get put in place (and hence their installing for DomU-s would
> need to be looked for elsewhere).

I asked Oleksandr for confirmation here but on arm there will be 2 other us=
e cases:
- PCI own by a DomD so device enumeration done from there
- dom0less with devices detection done inside Xen

>=20
>> @@ -784,6 +797,9 @@ out:
>>                    &PCI_SBDF(seg, bus, slot, func));
>>         }
>>     }
>> +    else if ( pdev )
>> +        pci_cleanup_msi(pdev);
>=20
> Have you thoroughly checked that this call is benign on x86? There's
> no wording to that effect in the description afaics, and I can't
> easily convince myself that it would be correct when the
> iommu_enable_device() path was taken. (I'm also not going to
> exclude that it should have been there even prior to your work,
> albeit then adding this would want to be a separate bugfix patch.)

This was not in the original serie and requested by Stefano. I must admit
I am not completely sure on the details here so I am really ok to remove th=
is
but this would go against what was requested on the previous versions (4 an=
d 5).

>=20
>> --- a/xen/drivers/vpci/header.c
>> +++ b/xen/drivers/vpci/header.c
>> @@ -374,7 +374,8 @@ static void bar_write(const struct pci_dev *pdev, un=
signed int reg,
>>         if ( val !=3D (uint32_t)(bar->addr >> (hi ? 32 : 0)) )
>>             gprintk(XENLOG_WARNING,
>>                     "%pp: ignored BAR %lu write with memory decoding ena=
bled\n",
>> -                    &pdev->sbdf, bar - pdev->vpci->header.bars + hi);
>> +                    &pdev->sbdf,
>> +                    (unsigned long)(bar - pdev->vpci->header.bars + hi)=
);
>=20
> This looks like an entirely unrelated change which I'm afraid I don't
> even understand why it needs making. The description says this is for
> Arm32, but it remains unclear what the compilation error would have
> been. My best guess is that perhaps you really mean to change the
> format specifier to %zu (really this should be %td, but our vsprintf()
> doesn't support 't' for whatever reason).

Compilation error is about an invalid %lu print for an unsigned int value
when compiled for arm32.

I will use zu instead in the next version and remove the cast.

>=20
> Please recall that we try to avoid casts where possible.

Sure I will.

>=20
>> --- a/xen/drivers/vpci/vpci.c
>> +++ b/xen/drivers/vpci/vpci.c
>> @@ -507,7 +507,7 @@ int vpci_ecam_mmio_write(pci_sbdf_t sbdf, unsigned i=
nt reg, unsigned int len,
>>=20
>>     vpci_write(sbdf, reg, min(4u, len), data);
>>     if ( len =3D=3D 8 )
>> -        vpci_write(sbdf, reg + 4, 4, data >> 32);
>> +        vpci_write(sbdf, reg + 4, 4, (uint64_t)data >> 32);
>=20
> I assume  the need for this change will go away with the use of
> CONFIG_64BIT in the earlier patch.

Yes

>=20
>> --- a/xen/include/xen/pci.h
>> +++ b/xen/include/xen/pci.h
>> @@ -40,6 +40,9 @@
>> #define PCI_SBDF3(s,b,df) \
>>     ((pci_sbdf_t){ .sbdf =3D (((s) & 0xffff) << 16) | PCI_BDF2(b, df) })
>>=20
>> +#define ECAM_BDF(addr)         ( ((addr) & 0x0ffff000) >> 12)
>> +#define ECAM_REG_OFFSET(addr)  ((addr) & 0x00000fff)
>=20
> The latter is fine to be put here (i.e. FTAOD I'm fine with it
> staying here). For the former I even question its original placement
> in asm-x86/pci.h: It's not generally correct as per the PCI spec, as
> the bus portion of the address can be anywhere from 1 to 8 bits. And
> in fact there is a reason why this macro was/is used in only a
> single place, but not e.g. in x86'es handling of physical MCFG. It
> is merely an implementation choice in vPCI that the entire segment 0
> has a linear address range covering all 256 buses. Hence I think
> this wants to move to xen/vpci.h and then perhaps also be named
> VPCI_ECAM_BDF().

On previous version it was request to renamed this to ECAM and agreed
to put is here. Now you want me to rename it to VPCI and move it again.
I would like to have a confirmation that this is ok and the final move if p=
ossible.

@Roger can you confirm this is what is wanted ?

Also if I have to do this I will do the same for REG_OFFSET of course.


>=20
> Also, as already pointed out on a much earlier version, while the
> blank following the opening parenthesis was warranted in
> asm-x86/pci.h for alignment reasons, it is no longer warranted here.
> It was certainly gone in v4 and v5.

Yes my mistake during the process I did a copy and paste from the original
one and did not modify. I will fix that.

>=20
> And one final nit: I don't think we commonly use full stops in patch
> titles. (Personally I therefore also think titles shouldn't start
> with a capital letter, but I know others think differently.)

Ok I will fix the patch name.

Cheers
Bertrand

>=20
> Jan
>=20



From xen-devel-bounces@lists.xenproject.org Fri Oct 15 10:10:10 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 10:10:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.210143.366884 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbKAE-0005mt-62; Fri, 15 Oct 2021 10:10:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 210143.366884; Fri, 15 Oct 2021 10:10:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbKAE-0005mh-2m; Fri, 15 Oct 2021 10:10:10 +0000
Received: by outflank-mailman (input) for mailman id 210143;
 Fri, 15 Oct 2021 10:10:08 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=bU0q=PD=kernel.org=patchwork-bot+netdevbpf@srs-us1.protection.inumbo.net>)
 id 1mbKAC-0005lY-QS
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 10:10:08 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 12d6edea-2da0-11ec-822c-12813bfff9fa;
 Fri, 15 Oct 2021 10:10:08 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPS id 3854860F5D;
 Fri, 15 Oct 2021 10:10:07 +0000 (UTC)
Received: from pdx-korg-docbuild-2.ci.codeaurora.org (localhost.localdomain
 [127.0.0.1])
 by pdx-korg-docbuild-2.ci.codeaurora.org (Postfix) with ESMTP id 2907B60A47;
 Fri, 15 Oct 2021 10:10:07 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 12d6edea-2da0-11ec-822c-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1634292607;
	bh=0MfS7M8bqmbo6Sa8T+anrOM8zgErxdkmqGBEWGlx3Bg=;
	h=Subject:From:Date:References:In-Reply-To:To:Cc:From;
	b=hNMFicw3CpcMLPWuRShyIjlkm5feBOZf6kE4hjgOBlxon/hzgi5rz4OiyAhsy4LIs
	 /pJwSEyHuC4qL8TbeZ42P4Es4F60slIjsSN9Wbjh44faDDvssamEhLQ1EwQnbbxC87
	 zP7ow4wU37rRHHlw/iJQOejJJmNTOitYuSu27hTHJVfGxqABUAZJ2LOIZynd1ed7lZ
	 X29CtjtsqFSNDUcSsKi+ZrBThnZ9axSq52N4/njfg9DbdNZ6uLwfkF8Roy7a6r/qbc
	 +4GG8zPK4mx76XUwn7MwUYMO00t8bJ+MFL6qLF+Vx0YoDMFtCUzt88dHHq1LtpfuW4
	 E6lQ9rzuuT80g==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Subject: Re: [PATCH] xen-netback: Remove redundant initialization of variable err
From: patchwork-bot+netdevbpf@kernel.org
Message-Id: 
 <163429260716.22961.1289715814535736615.git-patchwork-notify@kernel.org>
Date: Fri, 15 Oct 2021 10:10:07 +0000
References: <20211013165142.135795-1-colin.king@canonical.com>
In-Reply-To: <20211013165142.135795-1-colin.king@canonical.com>
To: Colin King <colin.king@canonical.com>
Cc: wei.liu@kernel.org, paul@xen.org, davem@davemloft.net, kuba@kernel.org,
 xen-devel@lists.xenproject.org, netdev@vger.kernel.org,
 kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org

Hello:

This patch was applied to netdev/net-next.git (master)
by David S. Miller <davem@davemloft.net>:

On Wed, 13 Oct 2021 17:51:42 +0100 you wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> The variable err is being initialized with a value that is never read, it
> is being updated immediately afterwards. The assignment is redundant and
> can be removed.
> 
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> 
> [...]

Here is the summary with links:
  - xen-netback: Remove redundant initialization of variable err
    https://git.kernel.org/netdev/net-next/c/bacc8daf97d4

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html




From xen-devel-bounces@lists.xenproject.org Fri Oct 15 10:10:46 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 10:10:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.210150.366895 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbKAm-0006NF-F6; Fri, 15 Oct 2021 10:10:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 210150.366895; Fri, 15 Oct 2021 10:10:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbKAm-0006N8-BP; Fri, 15 Oct 2021 10:10:44 +0000
Received: by outflank-mailman (input) for mailman id 210150;
 Fri, 15 Oct 2021 10:10:42 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Fqmt=PD=arm.com=Bertrand.Marquis@srs-us1.protection.inumbo.net>)
 id 1mbKAk-0006Mr-PH
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 10:10:42 +0000
Received: from EUR01-VE1-obe.outbound.protection.outlook.com (unknown
 [40.107.14.81]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 26f42888-2da0-11ec-822c-12813bfff9fa;
 Fri, 15 Oct 2021 10:10:41 +0000 (UTC)
Received: from AM6P195CA0017.EURP195.PROD.OUTLOOK.COM (2603:10a6:209:81::30)
 by AM6PR08MB4472.eurprd08.prod.outlook.com (2603:10a6:20b:bf::19) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.25; Fri, 15 Oct
 2021 10:10:36 +0000
Received: from VE1EUR03FT043.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:209:81:cafe::ed) by AM6P195CA0017.outlook.office365.com
 (2603:10a6:209:81::30) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15 via Frontend
 Transport; Fri, 15 Oct 2021 10:10:36 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT043.mail.protection.outlook.com (10.152.19.122) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.15 via Frontend Transport; Fri, 15 Oct 2021 10:10:36 +0000
Received: ("Tessian outbound e27daf245730:v103");
 Fri, 15 Oct 2021 10:10:36 +0000
Received: from 2af5423f9a88.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 80585131-6E71-468F-98B4-B9E9E0BCC93E.1; 
 Fri, 15 Oct 2021 10:10:29 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 2af5423f9a88.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 15 Oct 2021 10:10:29 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com (2603:10a6:4:74::9)
 by DB6PR08MB2677.eurprd08.prod.outlook.com (2603:10a6:6:1c::22) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.17; Fri, 15 Oct
 2021 10:10:28 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955]) by DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955%4]) with mapi id 15.20.4587.031; Fri, 15 Oct 2021
 10:10:28 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 26f42888-2da0-11ec-822c-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=fHV3G/JTEleo8t3XDHLr28j0uAYp5tafmKTJxxB8b5I=;
 b=qgRxMI1HdSSnCbhZkr2R1qNMLwbjBib/8h8VCTnlWDQK9fAm13Fb+AbdcBwCIjciawzNOECLv/g0J0lQM0YvbPyystp2GvXidG/05lWoKBLXotix8x5zeWHyaQbedq6VWktCuUSpRbdFAUCMe5/8GhyhLZuuReEuOq71Je9bd70=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 42ac83fbe00eef4d
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=BPS/8VJrwzuKMF+yc56LA6tN2TlCkh8RUS7tuTeMjHFezn/u/tc+epQAicSVR4XALToTiP8qR4GqhUGQ8OC9v12K4khW5293mc/EtPv+Y1TF1Xc0B5BN2DHfJIt2dJDTuR+dfzKt4tHogo9eLi6uULEHEXcquOixtdRBouo9xwTau2RFBNDnhwQGW2BPIkLufq09nkTOhy4Tfb0xtFrD4BPQqF43sE1LMg+K8qcpFrBuQueR2TbfWEXxFrhtXcdt10kdyt2ZKXNV37j+Inb73P6KHKa2Xc2/Qlev9wKKSBYDu2El05HqTkWOXsU0+XoiZ9ZegTi/496VN0MGyW70nw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=fHV3G/JTEleo8t3XDHLr28j0uAYp5tafmKTJxxB8b5I=;
 b=htBjLELmUGiXn4wna7DhKHZjHme6VNRhBUYlw0EdiAL63yO7TPOjjvhsIoTzquyq9LMe20SA6Xw6PZO2p4His1DQp4iCUG9zCUZlXmyz6kPQ8Pb38AvvKVDkZSSG3lbQQKHlWTnHoATGf34i0X6tbrVhnZ9cyfwX7sbqgY/3VWhEmx1n3whs5OjCPD0iyVZA975wGRhBlmQ//TJRpoQRgBTAtUXInRXLvLx5Tg0qeiwE45c6VYzPoNlPW5tCcaYjmgvN4FEB/jHxTu0v57ofkKJ1ov9qypRN5+XUP6XZz9HSZpPvb1obF2juw6zLeDk7mtc/ViZYCvczIeIPXYZDgQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=fHV3G/JTEleo8t3XDHLr28j0uAYp5tafmKTJxxB8b5I=;
 b=qgRxMI1HdSSnCbhZkr2R1qNMLwbjBib/8h8VCTnlWDQK9fAm13Fb+AbdcBwCIjciawzNOECLv/g0J0lQM0YvbPyystp2GvXidG/05lWoKBLXotix8x5zeWHyaQbedq6VWktCuUSpRbdFAUCMe5/8GhyhLZuuReEuOq71Je9bd70=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Stefano Stabellini <sstabellini@kernel.org>
CC: Xen-devel <xen-devel@lists.xenproject.org>, "iwj@xenproject.org"
	<iwj@xenproject.org>, Rahul Singh <Rahul.Singh@arm.com>, Julien Grall
	<julien@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, Andrew
 Cooper <andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>, Wei Liu <wl@xen.org>, Paul Durrant
	<paul@xen.org>, =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>
Subject: Re: [PATCH v6 2/3] xen/arm: Enable the existing x86 virtual PCI
 support for ARM.
Thread-Topic: [PATCH v6 2/3] xen/arm: Enable the existing x86 virtual PCI
 support for ARM.
Thread-Index: AQHXwQrjS6mPrKT7Q06z3N66FcsDAKvTKhiAgACtkoA=
Date: Fri, 15 Oct 2021 10:10:28 +0000
Message-ID: <9FCFF57A-105B-4248-A75C-E7D42DA4BB51@arm.com>
References: <cover.1634221830.git.bertrand.marquis@arm.com>
 <396b08e2598cf0338e0c7f4ad3cd5cb66db89224.1634221830.git.bertrand.marquis@arm.com>
 <alpine.DEB.2.21.2110141331310.9408@sstabellini-ThinkPad-T480s>
In-Reply-To: <alpine.DEB.2.21.2110141331310.9408@sstabellini-ThinkPad-T480s>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3654.120.0.1.13)
Authentication-Results-Original: kernel.org; dkim=none (message not signed)
 header.d=none;kernel.org; dmarc=none action=none header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: 1acab069-05af-4e6e-591f-08d98fc4085b
x-ms-traffictypediagnostic: DB6PR08MB2677:|AM6PR08MB4472:
x-ms-exchange-transport-forked: True
X-Microsoft-Antispam-PRVS:
	<AM6PR08MB4472530EBC9A5D187826B3B89DB99@AM6PR08MB4472.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:7219;OLM:7219;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 czh/XzGuYLDLp3w30x10gRHsbSQ5m4azbUYu1JFGo72iL/fK1fVTFTpnK3Y/MygG0m0HrvO+Zh9r6h0HAek2p8rVtNwqvJw//qLUJW7Vkx1jhiBcztd8yL1VP24kWal9ytS1VClgVHREwsknXXL9sp+9JtuBMKVeZ7uEwCnuJk7WGKW0Fa0a7bRMwMNSQ0EUruLy0o8Vp5ar21nBsfargC+P8e6tWJTCeqfPp2SwD2nVFcPwEkm9Cm/QO79nnFj8xBfI3ob2ckrJpRWTMHlmrxKDB2rg1VLvW9xKyCavzpsjXtjtRv5IVMY3UWyffVcV8pGngu4ew8lYWdy2M6yOXpxoSgMuqHMZ10Ry8e/AqEs7bD8vMPOO01IcRK4V8ZaXf0RWlFaaa7L4YoAKtvaJxh1mk2iSrtXySH6LGPddoS0M5yjhPW8hCpKHfaYeEpxMwMuvgGWTZjl3zmimfkQm/rVqGPBtEs/vhUk6RzEWrP2UcW/Dg8fhGTFme8ylHY8arcbPVE6ZDw9Jbttgq7V4vpOsvaZTCfUw1s7N0GIoKx43tNsj5ISiYcOlXtcU89KSeAVcwwF86PG4Mr/4Lt+I67P19s8G3bW/dBmN0akxyVTknnlJxLAtB5vAFIUybCMQOP9HgpySvMkKK6Xb83WaYpBxI16WYtGUiiLav4fOx35N4+qnLhpXkD4hSr1fqBEhTfogWA/X5lfm4KzsrZ/FZuAyn8Dt2lszFEUJ8pQ+UazHqoFdEyNLUJZcjXYmAk8z4Ybyxg+hVSzx8OuL5sdbN2YNIdtLV+xMsN95sgYQ5nUPlQrFYx0lGiqzaKXKV279+vnkTDYBJLnhqRc4jh2l/dmQrPDZbJ8HJGNxQFqSZfSvdnV9btAQfiUeJsNjLml39je9vX7sMOJBPRaSjdmQcg==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB6PR0801MB2024.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(316002)(8676002)(53546011)(508600001)(2616005)(4326008)(33656002)(966005)(71200400001)(30864003)(83380400001)(6506007)(54906003)(36756003)(6512007)(186003)(66446008)(64756008)(66946007)(66556008)(66476007)(38070700005)(8936002)(7416002)(6916009)(76116006)(6486002)(86362001)(2906002)(5660300002)(38100700002)(91956017)(26005)(122000001)(2004002)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-ID: <5B8CB83394B2D84AA15383EA6901D185@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR08MB2677
Original-Authentication-Results: kernel.org; dkim=none (message not signed)
 header.d=none;kernel.org; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT043.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	55f79386-37d0-475d-72f6-08d98fc40374
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	ONu7+LbSHo1xNfIqPjMSVCWeqEe5EbcJ5M1kQzSyx6AECE9Me0NHFc0qLtgTv96MqqKYlRzyaoQsLvjJfqea75Ya71iN7CFZ4dBRLNtM0CRI+A93OLFRi0plrjUABZwnN4T1FVMJ2B0y2mGBAHaF2+F+SvE+tNLy2FKmyxRAjev/a3GkNu/HwNpvMQPGlmFdRn6lBMhJe+DU2TRIvlpWFssQLucYM34NjONm591xC0+ybQwZBHuBq4hh/43yrGkkj87HeIFbTqe+klosdbRlwgjMGZJ9nS7iStAaNEAnB/UcIurG7FSuVf701C+xyDWu4r2tybxfJUYRTGXZGSe2v0oRGpxPH6COs10mcMpauPDRN+P8mI17vj0+0+UbNsXC2UbtpvROg79hcX4JeaSY0cdyruOyAeXf9/n0LtBBE6qoEVdTvDXM73V2Xpzndt5GATuv49cFaEB+6+qVtpjjl1En8A2ZSHE6twgCmNTiCrQ/pVCUim6lZcqzBFAqYXA6DVHqkzhG/FDKR0xwFQx2WzbWw13+wThkQpwkk1P048FNc+2VJJnYBxdZZze2vyqYqU/7fZjOtl/xMAtEbSjFMsR8KS8RNXz53ZqJIJ1AjQBIDcr4SDLXNOzPFIzcxCkkJbQ7quOAOjucHNzi852Q0kV4OByAsFtPKUthYrdNhkmieP9FoR/X9lUdAMhNUdZ1i8avvSQrcF4kckM9sw8F2lhF0okb0OLfgZ/rUjMB/twuJ6biQW2mlfoSGdL4ySi0vIu7ID/ReNGSoeS3O8UOqQi6h2x6AgV246Sy0zp73q1etm7cqZc3MYQSe3VjDCnjIaJ9Sk2bdH0UVJ9Ig1pVkixuWscwcSN7dOhi7Px+UoY=
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(2906002)(47076005)(86362001)(36756003)(508600001)(30864003)(6862004)(70586007)(4326008)(26005)(316002)(70206006)(2616005)(82310400003)(54906003)(336012)(83380400001)(33656002)(8936002)(107886003)(186003)(6506007)(53546011)(8676002)(36860700001)(6486002)(81166007)(6512007)(966005)(5660300002)(356005)(2004002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2021 10:10:36.4682
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 1acab069-05af-4e6e-591f-08d98fc4085b
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT043.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB4472

SGkgU3RlZmFubywNCg0KPiBPbiAxNSBPY3QgMjAyMSwgYXQgMDA6NDksIFN0ZWZhbm8gU3RhYmVs
bGluaSA8c3N0YWJlbGxpbmlAa2VybmVsLm9yZz4gd3JvdGU6DQo+IA0KPiBPbiBUaHUsIDE0IE9j
dCAyMDIxLCBCZXJ0cmFuZCBNYXJxdWlzIHdyb3RlOg0KPj4gRnJvbTogUmFodWwgU2luZ2ggPHJh
aHVsLnNpbmdoQGFybS5jb20+DQo+PiANCj4+IFRoZSBleGlzdGluZyBWUENJIHN1cHBvcnQgYXZh
aWxhYmxlIGZvciBYODYgaXMgYWRhcHRlZCBmb3IgQXJtLg0KPj4gV2hlbiB0aGUgZGV2aWNlIGlz
IGFkZGVkIHRvIFhFTiB2aWEgdGhlIGh5cGVyIGNhbGwNCj4+IOKAnFBIWVNERVZPUF9wY2lfZGV2
aWNlX2FkZOKAnSwgVlBDSSBoYW5kbGVyIGZvciB0aGUgY29uZmlnIHNwYWNlDQo+PiBhY2Nlc3Mg
aXMgYWRkZWQgdG8gdGhlIFhlbiB0byBlbXVsYXRlIHRoZSBQQ0kgZGV2aWNlcyBjb25maWcgc3Bh
Y2UuDQo+PiANCj4+IEEgTU1JTyB0cmFwIGhhbmRsZXIgZm9yIHRoZSBQQ0kgRUNBTSBzcGFjZSBp
cyByZWdpc3RlcmVkIGluIFhFTg0KPj4gc28gdGhhdCB3aGVuIGd1ZXN0IGlzIHRyeWluZyB0byBh
Y2Nlc3MgdGhlIFBDSSBjb25maWcgc3BhY2UsWEVODQo+PiB3aWxsIHRyYXAgdGhlIGFjY2VzcyBh
bmQgZW11bGF0ZSByZWFkL3dyaXRlIHVzaW5nIHRoZSBWUENJIGFuZA0KPj4gbm90IHRoZSByZWFs
IFBDSSBoYXJkd2FyZS4NCj4+IA0KPj4gRm9yIERvbTBsZXNzIHN5c3RlbXMgc2Nhbl9wY2lfZGV2
aWNlcygpIHdvdWxkIGJlIHVzZWQgdG8gZGlzY292ZXIgdGhlDQo+PiBQQ0kgZGV2aWNlIGluIFhF
TiBhbmQgVlBDSSBoYW5kbGVyIHdpbGwgYmUgYWRkZWQgZHVyaW5nIFhFTiBib290cy4NCj4+IA0K
Pj4gVGhpcyBwYXRjaCBpcyBhbHNvIGRvaW5nIHNvbWUgc21hbGwgZml4ZXMgdG8gZml4IGNvbXBp
bGF0aW9uIGVycm9ycyBvbg0KPj4gYXJtMzIgb2YgdnBjaToNCj4+IC0gYWRkIGEgY2FzdCB0byB1
bnNpZ25lZCBsb25nIGluIHByaW50IGluIGhlYWRlci5jDQo+PiAtIGFkZCBhIGNhc3QgdG8gdWlu
dDY0X3QgaW4gdnBjaV9lY2FtX21taW9fd3JpdGUNCj4gDQo+IFRoYW5rIHlvdSBmb3IgdGhlc2Uh
IFN0cmljdGx5IHNwZWFraW5nIHRoZXkgYXJlIG5vdCByZXF1aXJlZCBub3cgYnV0DQo+IHRoZXkg
YXJlIHdlbGNvbWUuIEkgd291bGQgYWxzbyBiZSBPSyBpZiB0aGV5IHdlcmUgcmVtb3ZlZCBmcm9t
IHRoaXMNCj4gcGF0Y2ggYnV0IGl0IGlzIGZpbmUgdG8gaGF2ZSB0aGVtIGluIGhlcmUuDQo+IA0K
PiBUaGVyZSBpcyBhbiBpc3N1ZXMgd2l0aCB0aGlzIHBhdGNoLCBzZWUgYmVsb3cgYXQgdGhlIGJv
dHRvbQ0KPiANCj4gDQo+PiBTaWduZWQtb2ZmLWJ5OiBSYWh1bCBTaW5naCA8cmFodWwuc2luZ2hA
YXJtLmNvbT4NCj4+IFNpZ25lZC1vZmYtYnk6IEJlcnRyYW5kIE1hcnF1aXMgPGJlcnRyYW5kLm1h
cnF1aXNAYXJtLmNvbT4NCj4+IA0KPj4gLS0tDQo+PiBDaGFuZ2VzIGluIHY2Og0KPj4gLSBVc2Ug
bmV3IHZwY2lfZWNhbV8gaGVscGVycyBmb3IgUENJIGFjY2Vzcw0KPj4gLSBEbyBub3Qgc2V0IFhF
Tl9ET01DVExfQ0RGX3ZwY2kgZm9yIGRvbTAgZm9yIG5vdyAod2lsbCBiZSBkb25lIGluIGENCj4+
IGZ1dHVyZSBwYXRjaCBvbmNlIGV2ZXJ5dGhpbmcgaXMgcmVhZHkpDQo+PiAtIHJlbmFtZSBSRUdJ
U1RFUl9PRkZTRVQgdG8gRUNBTV9SRUdfT0ZGU0VUIGFuZCBtb3ZlIGl0IHRvIHBjaS5oDQo+PiAt
IHJlbW92ZSBub3QgbmVlZGVkIGxvY2FsIHZhcmlhYmxlcyBpbiB2cGNpX21taW9fd3JpdGUsIHRo
ZSBvbmUgaW4gcmVhZA0KPj4gaGFzIGJlZW4ga2VwdCB0byBlbnN1cmUgcHJvcGVyIGNvbXBpbGF0
aW9uIG9uIGFybTMyDQo+PiAtIG1vdmUgY2FsbCB0byB2cGNpX2FkZF9oYW5kbGVycyBiZWZvcmUg
aW9tbXUgaW5pdCB0byBzaW1wbGlmeSBleGl0IHBhdGgNCj4+IC0gbW92ZSBjYWxsIHRvIHBjaV9j
bGVhbnVwX21zaSBpbiB0aGUgb3V0IHNlY3Rpb24gb2YgcGNpX2FkZF9kZXZpY2UgaWYNCj4+IHBk
ZXYgaXMgbm90IE5VTEwgYW5kIG9uIGVycm9yDQo+PiAtIGluaXRpYWxpemUgcGRldiB0byBOVUxM
IHRvIGhhbmRsZSBwcm9wZXJseSBleGl0IHBhdGggY2FsbCBvZg0KPj4gcGNpX2NsZWFudXBfbXNp
DQo+PiAtIGtlZXAgaGFzX3ZwY2kgdG8gcmV0dXJuIGZhbHNlIGZvciBub3cgYXMgQ0ZHX3ZwY2kg
aGFzIGJlZW4gcmVtb3ZlZC4NCj4+IEFkZGVkIGEgY29tbWVudCBvbiB0b3Agb2YgdGhlIGRlZmlu
aXRpb24uDQo+PiAtIGZpeCBjb21waWxhdGlvbiBlcnJvcnMgb24gYXJtMzIgKHByaW50IGluIGhl
YWRlci5jLCBjYXN0IG1pc3NpbmcgaW4NCj4+IG1taW9fd3JpdGUuDQo+PiAtIGxvY2FsIHZhcmlh
YmxlIHdhcyBrZXB0IGluIHZwY2lfbW1pb19yZWFkIG9uIGFybSB0byBwcmV2ZW50IGEgY2FzdA0K
Pj4gZXJyb3IgaW4gYXJtMzIuDQo+PiBDaGFuZ2UgaW4gdjU6DQo+PiAtIEFkZCBwY2lfY2xlYW51
cF9tc2kocGRldikgaW5jbGVhbnVwIHBhcnQuDQo+PiAtIEFkZGVkIFJldmlld2VkLWJ5OiBTdGVm
YW5vIFN0YWJlbGxpbmkgPHNzdGFiZWxsaW5pQGtlcm5lbC5vcmc+DQo+PiBDaGFuZ2UgaW4gdjQ6
DQo+PiAtIE1vdmUgYWRkaXRpb24gb2YgWEVOX0RPTUNUTF9DREZfdnBjaSBmbGFnIHRvIHNlcGFy
YXRlIHBhdGNoDQo+PiBDaGFuZ2UgaW4gdjM6DQo+PiAtIFVzZSBpc19wY2lfcGFzc3Rocm91Z2hf
ZW5hYmxlZCgpIGluIHBsYWNlIG9mIHBjaV9wYXNzdGhyb3VnaF9lbmFibGVkIHZhcmlhYmxlDQo+
PiAtIFJlamVjdCBYRU5fRE9NQ1RMX0NERl92cGNpIGZvciB4ODYgaW4gYXJjaF9zYW5pdGlzZV9k
b21haW5fY29uZmlnKCkNCj4+IC0gUmVtb3ZlIElTX0VOQUJMRUQoQ09ORklHX0hBU19WUENJKSBm
cm9tIGhhc192cGNpKCkNCj4+IENoYW5nZSBpbiB2MjoNCj4+IC0gQWRkIG5ldyBYRU5fRE9NQ1RM
X0NERl92cGNpIGZsYWcNCj4+IC0gbW9kaWZ5IGhhc192cGNpKCkgdG8gaW5jbHVkZSBYRU5fRE9N
Q1RMX0NERl92cGNpDQo+PiAtIGVuYWJsZSB2cGNpIHN1cHBvcnQgd2hlbiBwY2ktcGFzc3Rob3Vn
aCBvcHRpb24gaXMgZW5hYmxlZC4NCj4+IC0tLQ0KPj4gLS0tDQo+PiB4ZW4vYXJjaC9hcm0vTWFr
ZWZpbGUgICAgICAgICB8ICAxICsNCj4+IHhlbi9hcmNoL2FybS9kb21haW4uYyAgICAgICAgIHwg
IDQgKysNCj4+IHhlbi9hcmNoL2FybS92cGNpLmMgICAgICAgICAgIHwgNzQgKysrKysrKysrKysr
KysrKysrKysrKysrKysrKysrKysrKysNCj4+IHhlbi9hcmNoL2FybS92cGNpLmggICAgICAgICAg
IHwgMzYgKysrKysrKysrKysrKysrKysNCj4+IHhlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL3BjaS5j
IHwgMTggKysrKysrKystDQo+PiB4ZW4vZHJpdmVycy92cGNpL2hlYWRlci5jICAgICB8ICAzICst
DQo+PiB4ZW4vZHJpdmVycy92cGNpL3ZwY2kuYyAgICAgICB8ICAyICstDQo+PiB4ZW4vaW5jbHVk
ZS9hc20tYXJtL2RvbWFpbi5oICB8ICAxICsNCj4+IHhlbi9pbmNsdWRlL2FzbS14ODYvcGNpLmgg
ICAgIHwgIDIgLQ0KPj4geGVuL2luY2x1ZGUvcHVibGljL2FyY2gtYXJtLmggfCAgNyArKysrDQo+
PiB4ZW4vaW5jbHVkZS94ZW4vcGNpLmggICAgICAgICB8ICAzICsrDQo+PiAxMSBmaWxlcyBjaGFu
Z2VkLCAxNDYgaW5zZXJ0aW9ucygrKSwgNSBkZWxldGlvbnMoLSkNCj4+IGNyZWF0ZSBtb2RlIDEw
MDY0NCB4ZW4vYXJjaC9hcm0vdnBjaS5jDQo+PiBjcmVhdGUgbW9kZSAxMDA2NDQgeGVuL2FyY2gv
YXJtL3ZwY2kuaA0KPj4gDQo+PiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gvYXJtL01ha2VmaWxlIGIv
eGVuL2FyY2gvYXJtL01ha2VmaWxlDQo+PiBpbmRleCA2NDUxODg0OGIyLi4wN2Y2MzQ1MDhlIDEw
MDY0NA0KPj4gLS0tIGEveGVuL2FyY2gvYXJtL01ha2VmaWxlDQo+PiArKysgYi94ZW4vYXJjaC9h
cm0vTWFrZWZpbGUNCj4+IEBAIC03LDYgKzcsNyBAQCBpZm5lcSAoJChDT05GSUdfTk9fUExBVCks
eSkNCj4+IG9iai15ICs9IHBsYXRmb3Jtcy8NCj4+IGVuZGlmDQo+PiBvYmotJChDT05GSUdfVEVF
KSArPSB0ZWUvDQo+PiArb2JqLSQoQ09ORklHX0hBU19WUENJKSArPSB2cGNpLm8NCj4+IA0KPj4g
b2JqLSQoQ09ORklHX0hBU19BTFRFUk5BVElWRSkgKz0gYWx0ZXJuYXRpdmUubw0KPj4gb2JqLXkg
Kz0gYm9vdGZkdC5pbml0Lm8NCj4+IGRpZmYgLS1naXQgYS94ZW4vYXJjaC9hcm0vZG9tYWluLmMg
Yi94ZW4vYXJjaC9hcm0vZG9tYWluLmMNCj4+IGluZGV4IGVlZjA2NjFiZWIuLjk2ZTFiMjM1NTAg
MTAwNjQ0DQo+PiAtLS0gYS94ZW4vYXJjaC9hcm0vZG9tYWluLmMNCj4+ICsrKyBiL3hlbi9hcmNo
L2FybS9kb21haW4uYw0KPj4gQEAgLTM5LDYgKzM5LDcgQEANCj4+ICNpbmNsdWRlIDxhc20vdmdp
Yy5oPg0KPj4gI2luY2x1ZGUgPGFzbS92dGltZXIuaD4NCj4+IA0KPj4gKyNpbmNsdWRlICJ2cGNp
LmgiDQo+PiAjaW5jbHVkZSAidnVhcnQuaCINCj4+IA0KPj4gREVGSU5FX1BFUl9DUFUoc3RydWN0
IHZjcHUgKiwgY3Vycl92Y3B1KTsNCj4+IEBAIC03NzMsNiArNzc0LDkgQEAgaW50IGFyY2hfZG9t
YWluX2NyZWF0ZShzdHJ1Y3QgZG9tYWluICpkLA0KPj4gICAgIGlmICggaXNfaGFyZHdhcmVfZG9t
YWluKGQpICYmIChyYyA9IGRvbWFpbl92dWFydF9pbml0KGQpKSApDQo+PiAgICAgICAgIGdvdG8g
ZmFpbDsNCj4+IA0KPj4gKyAgICBpZiAoIChyYyA9IGRvbWFpbl92cGNpX2luaXQoZCkpICE9IDAg
KQ0KPj4gKyAgICAgICAgZ290byBmYWlsOw0KPj4gKw0KPj4gICAgIHJldHVybiAwOw0KPj4gDQo+
PiBmYWlsOg0KPj4gZGlmZiAtLWdpdCBhL3hlbi9hcmNoL2FybS92cGNpLmMgYi94ZW4vYXJjaC9h
cm0vdnBjaS5jDQo+PiBuZXcgZmlsZSBtb2RlIDEwMDY0NA0KPj4gaW5kZXggMDAwMDAwMDAwMC4u
N2MzNTUyYjY1ZA0KPj4gLS0tIC9kZXYvbnVsbA0KPj4gKysrIGIveGVuL2FyY2gvYXJtL3ZwY2ku
Yw0KPj4gQEAgLTAsMCArMSw3NCBAQA0KPj4gKy8qDQo+PiArICogeGVuL2FyY2gvYXJtL3ZwY2ku
Yw0KPj4gKyAqDQo+PiArICogVGhpcyBwcm9ncmFtIGlzIGZyZWUgc29mdHdhcmU7IHlvdSBjYW4g
cmVkaXN0cmlidXRlIGl0IGFuZC9vciBtb2RpZnkNCj4+ICsgKiBpdCB1bmRlciB0aGUgdGVybXMg
b2YgdGhlIEdOVSBHZW5lcmFsIFB1YmxpYyBMaWNlbnNlIGFzIHB1Ymxpc2hlZCBieQ0KPj4gKyAq
IHRoZSBGcmVlIFNvZnR3YXJlIEZvdW5kYXRpb247IGVpdGhlciB2ZXJzaW9uIDIgb2YgdGhlIExp
Y2Vuc2UsIG9yDQo+PiArICogKGF0IHlvdXIgb3B0aW9uKSBhbnkgbGF0ZXIgdmVyc2lvbi4NCj4+
ICsgKg0KPj4gKyAqIFRoaXMgcHJvZ3JhbSBpcyBkaXN0cmlidXRlZCBpbiB0aGUgaG9wZSB0aGF0
IGl0IHdpbGwgYmUgdXNlZnVsLA0KPj4gKyAqIGJ1dCBXSVRIT1VUIEFOWSBXQVJSQU5UWTsgd2l0
aG91dCBldmVuIHRoZSBpbXBsaWVkIHdhcnJhbnR5IG9mDQo+PiArICogTUVSQ0hBTlRBQklMSVRZ
IG9yIEZJVE5FU1MgRk9SIEEgUEFSVElDVUxBUiBQVVJQT1NFLiAgU2VlIHRoZQ0KPj4gKyAqIEdO
VSBHZW5lcmFsIFB1YmxpYyBMaWNlbnNlIGZvciBtb3JlIGRldGFpbHMuDQo+PiArICovDQo+PiAr
I2luY2x1ZGUgPHhlbi9zY2hlZC5oPg0KPj4gKyNpbmNsdWRlIDx4ZW4vdnBjaS5oPg0KPj4gKw0K
Pj4gKyNpbmNsdWRlIDxhc20vbW1pby5oPg0KPj4gKw0KPj4gK3N0YXRpYyBpbnQgdnBjaV9tbWlv
X3JlYWQoc3RydWN0IHZjcHUgKnYsIG1taW9faW5mb190ICppbmZvLA0KPj4gKyAgICAgICAgICAg
ICAgICAgICAgICAgICAgcmVnaXN0ZXJfdCAqciwgdm9pZCAqcCkNCj4+ICt7DQo+PiArICAgIHBj
aV9zYmRmX3Qgc2JkZjsNCj4+ICsgICAgLyogZGF0YSBpcyBuZWVkZWQgdG8gcHJldmVudCBhIHBv
aW50ZXIgY2FzdCBvbiAzMmJpdCAqLw0KPj4gKyAgICB1bnNpZ25lZCBsb25nIGRhdGEgPSB+MHVs
Ow0KPj4gKyAgICBpbnQgcmV0Ow0KPj4gKw0KPj4gKyAgICAvKiBXZSBpZ25vcmUgc2VnbWVudCBw
YXJ0IGFuZCBhbHdheXMgaGFuZGxlIHNlZ21lbnQgMCAqLw0KPj4gKyAgICBzYmRmLnNiZGYgPSBF
Q0FNX0JERihpbmZvLT5ncGEpOw0KPj4gKw0KPj4gKyAgICByZXQgPSB2cGNpX2VjYW1fbW1pb19y
ZWFkKHNiZGYsIEVDQU1fUkVHX09GRlNFVChpbmZvLT5ncGEpLA0KPj4gKyAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgIDFVIDw8IGluZm8tPmRhYnQuc2l6ZSwgJmRhdGEpOw0KPj4gKw0KPj4g
KyAgICAqciA9IGRhdGE7DQo+PiArDQo+PiArICAgIHJldHVybiByZXQ7DQo+PiArfQ0KPj4gKw0K
Pj4gK3N0YXRpYyBpbnQgdnBjaV9tbWlvX3dyaXRlKHN0cnVjdCB2Y3B1ICp2LCBtbWlvX2luZm9f
dCAqaW5mbywNCj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICByZWdpc3Rlcl90IHIsIHZv
aWQgKnApDQo+PiArew0KPj4gKyAgICBwY2lfc2JkZl90IHNiZGY7DQo+PiArDQo+PiArICAgIC8q
IFdlIGlnbm9yZSBzZWdtZW50IHBhcnQgYW5kIGFsd2F5cyBoYW5kbGUgc2VnbWVudCAwICovDQo+
PiArICAgIHNiZGYuc2JkZiA9IEVDQU1fQkRGKGluZm8tPmdwYSk7DQo+PiArDQo+PiArICAgIHJl
dHVybiB2cGNpX2VjYW1fbW1pb193cml0ZShzYmRmLCBFQ0FNX1JFR19PRkZTRVQoaW5mby0+Z3Bh
KSwNCj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIDFVIDw8IGluZm8tPmRhYnQu
c2l6ZSwgcik7DQo+PiArfQ0KPj4gKw0KPj4gK3N0YXRpYyBjb25zdCBzdHJ1Y3QgbW1pb19oYW5k
bGVyX29wcyB2cGNpX21taW9faGFuZGxlciA9IHsNCj4+ICsgICAgLnJlYWQgID0gdnBjaV9tbWlv
X3JlYWQsDQo+PiArICAgIC53cml0ZSA9IHZwY2lfbW1pb193cml0ZSwNCj4+ICt9Ow0KPj4gKw0K
Pj4gK2ludCBkb21haW5fdnBjaV9pbml0KHN0cnVjdCBkb21haW4gKmQpDQo+PiArew0KPj4gKyAg
ICBpZiAoICFoYXNfdnBjaShkKSApDQo+PiArICAgICAgICByZXR1cm4gMDsNCj4+ICsNCj4+ICsg
ICAgcmVnaXN0ZXJfbW1pb19oYW5kbGVyKGQsICZ2cGNpX21taW9faGFuZGxlciwNCj4+ICsgICAg
ICAgICAgICAgICAgICAgICAgICAgIEdVRVNUX1ZQQ0lfRUNBTV9CQVNFLCBHVUVTVF9WUENJX0VD
QU1fU0laRSwgTlVMTCk7DQo+PiArDQo+PiArICAgIHJldHVybiAwOw0KPj4gK30NCj4+ICsNCj4+
ICsvKg0KPj4gKyAqIExvY2FsIHZhcmlhYmxlczoNCj4+ICsgKiBtb2RlOiBDDQo+PiArICogYy1m
aWxlLXN0eWxlOiAiQlNEIg0KPj4gKyAqIGMtYmFzaWMtb2Zmc2V0OiA0DQo+PiArICogaW5kZW50
LXRhYnMtbW9kZTogbmlsDQo+PiArICogRW5kOg0KPj4gKyAqLw0KPj4gKw0KPj4gZGlmZiAtLWdp
dCBhL3hlbi9hcmNoL2FybS92cGNpLmggYi94ZW4vYXJjaC9hcm0vdnBjaS5oDQo+PiBuZXcgZmls
ZSBtb2RlIDEwMDY0NA0KPj4gaW5kZXggMDAwMDAwMDAwMC4uZDhhN2IwZTNlOA0KPj4gLS0tIC9k
ZXYvbnVsbA0KPj4gKysrIGIveGVuL2FyY2gvYXJtL3ZwY2kuaA0KPj4gQEAgLTAsMCArMSwzNiBA
QA0KPj4gKy8qDQo+PiArICogeGVuL2FyY2gvYXJtL3ZwY2kuaA0KPj4gKyAqDQo+PiArICogVGhp
cyBwcm9ncmFtIGlzIGZyZWUgc29mdHdhcmU7IHlvdSBjYW4gcmVkaXN0cmlidXRlIGl0IGFuZC9v
ciBtb2RpZnkNCj4+ICsgKiBpdCB1bmRlciB0aGUgdGVybXMgb2YgdGhlIEdOVSBHZW5lcmFsIFB1
YmxpYyBMaWNlbnNlIGFzIHB1Ymxpc2hlZCBieQ0KPj4gKyAqIHRoZSBGcmVlIFNvZnR3YXJlIEZv
dW5kYXRpb247IGVpdGhlciB2ZXJzaW9uIDIgb2YgdGhlIExpY2Vuc2UsIG9yDQo+PiArICogKGF0
IHlvdXIgb3B0aW9uKSBhbnkgbGF0ZXIgdmVyc2lvbi4NCj4+ICsgKg0KPj4gKyAqIFRoaXMgcHJv
Z3JhbSBpcyBkaXN0cmlidXRlZCBpbiB0aGUgaG9wZSB0aGF0IGl0IHdpbGwgYmUgdXNlZnVsLA0K
Pj4gKyAqIGJ1dCBXSVRIT1VUIEFOWSBXQVJSQU5UWTsgd2l0aG91dCBldmVuIHRoZSBpbXBsaWVk
IHdhcnJhbnR5IG9mDQo+PiArICogTUVSQ0hBTlRBQklMSVRZIG9yIEZJVE5FU1MgRk9SIEEgUEFS
VElDVUxBUiBQVVJQT1NFLiAgU2VlIHRoZQ0KPj4gKyAqIEdOVSBHZW5lcmFsIFB1YmxpYyBMaWNl
bnNlIGZvciBtb3JlIGRldGFpbHMuDQo+PiArICovDQo+PiArDQo+PiArI2lmbmRlZiBfX0FSQ0hf
QVJNX1ZQQ0lfSF9fDQo+PiArI2RlZmluZSBfX0FSQ0hfQVJNX1ZQQ0lfSF9fDQo+PiArDQo+PiAr
I2lmZGVmIENPTkZJR19IQVNfVlBDSQ0KPj4gK2ludCBkb21haW5fdnBjaV9pbml0KHN0cnVjdCBk
b21haW4gKmQpOw0KPj4gKyNlbHNlDQo+PiArc3RhdGljIGlubGluZSBpbnQgZG9tYWluX3ZwY2lf
aW5pdChzdHJ1Y3QgZG9tYWluICpkKQ0KPj4gK3sNCj4+ICsgICAgcmV0dXJuIDA7DQo+PiArfQ0K
Pj4gKyNlbmRpZg0KPj4gKw0KPj4gKyNlbmRpZiAvKiBfX0FSQ0hfQVJNX1ZQQ0lfSF9fICovDQo+
PiArDQo+PiArLyoNCj4+ICsgKiBMb2NhbCB2YXJpYWJsZXM6DQo+PiArICogbW9kZTogQw0KPj4g
KyAqIGMtZmlsZS1zdHlsZTogIkJTRCINCj4+ICsgKiBjLWJhc2ljLW9mZnNldDogNA0KPj4gKyAq
IGluZGVudC10YWJzLW1vZGU6IG5pbA0KPj4gKyAqIEVuZDoNCj4+ICsgKi8NCj4+IGRpZmYgLS1n
aXQgYS94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC9wY2kuYyBiL3hlbi9kcml2ZXJzL3Bhc3N0aHJv
dWdoL3BjaS5jDQo+PiBpbmRleCAzYWE4YzMxNzVmLi44Y2M1MjllY2VjIDEwMDY0NA0KPj4gLS0t
IGEveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvcGNpLmMNCj4+ICsrKyBiL3hlbi9kcml2ZXJzL3Bh
c3N0aHJvdWdoL3BjaS5jDQo+PiBAQCAtNjU4LDcgKzY1OCw3IEBAIGludCBwY2lfYWRkX2Rldmlj
ZSh1MTYgc2VnLCB1OCBidXMsIHU4IGRldmZuLA0KPj4gICAgICAgICAgICAgICAgICAgIGNvbnN0
IHN0cnVjdCBwY2lfZGV2X2luZm8gKmluZm8sIG5vZGVpZF90IG5vZGUpDQo+PiB7DQo+PiAgICAg
c3RydWN0IHBjaV9zZWcgKnBzZWc7DQo+PiAtICAgIHN0cnVjdCBwY2lfZGV2ICpwZGV2Ow0KPj4g
KyAgICBzdHJ1Y3QgcGNpX2RldiAqcGRldiA9IE5VTEw7DQo+PiAgICAgdW5zaWduZWQgaW50IHNs
b3QgPSBQQ0lfU0xPVChkZXZmbiksIGZ1bmMgPSBQQ0lfRlVOQyhkZXZmbik7DQo+PiAgICAgY29u
c3QgY2hhciAqcGRldl90eXBlOw0KPj4gICAgIGludCByZXQ7DQo+PiBAQCAtNzUyLDYgKzc1Miwx
OSBAQCBpbnQgcGNpX2FkZF9kZXZpY2UodTE2IHNlZywgdTggYnVzLCB1OCBkZXZmbiwNCj4+IA0K
Pj4gICAgIGNoZWNrX3BkZXYocGRldik7DQo+PiANCj4+ICsjaWZkZWYgQ09ORklHX0FSTQ0KPj4g
KyAgICAvKg0KPj4gKyAgICAgKiBPbiBBUk0gUENJIGRldmljZXMgZGlzY292ZXJ5IHdpbGwgYmUg
ZG9uZSBieSBEb20wLiBBZGQgdnBjaSBoYW5kbGVyIHdoZW4NCj4+ICsgICAgICogRG9tMCBpbmZv
cm0gWEVOIHRvIGFkZCB0aGUgUENJIGRldmljZXMgaW4gWEVOLg0KPj4gKyAgICAgKi8NCj4+ICsg
ICAgcmV0ID0gdnBjaV9hZGRfaGFuZGxlcnMocGRldik7DQo+PiArICAgIGlmICggcmV0ICkNCj4+
ICsgICAgew0KPj4gKyAgICAgICAgcHJpbnRrKFhFTkxPR19FUlIgIlNldHVwIG9mIHZQQ0kgZmFp
bGVkOiAlZFxuIiwgcmV0KTsNCj4+ICsgICAgICAgIGdvdG8gb3V0Ow0KPj4gKyAgICB9DQo+PiAr
I2VuZGlmDQo+PiArDQo+PiAgICAgcmV0ID0gMDsNCj4+ICAgICBpZiAoICFwZGV2LT5kb21haW4g
KQ0KPj4gICAgIHsNCj4+IEBAIC03ODQsNiArNzk3LDkgQEAgb3V0Og0KPj4gICAgICAgICAgICAg
ICAgICAgICZQQ0lfU0JERihzZWcsIGJ1cywgc2xvdCwgZnVuYykpOw0KPj4gICAgICAgICB9DQo+
PiAgICAgfQ0KPj4gKyAgICBlbHNlIGlmICggcGRldiApDQo+PiArICAgICAgICBwY2lfY2xlYW51
cF9tc2kocGRldik7DQo+PiArDQo+PiAgICAgcmV0dXJuIHJldDsNCj4+IH0NCj4+IA0KPj4gZGlm
ZiAtLWdpdCBhL3hlbi9kcml2ZXJzL3ZwY2kvaGVhZGVyLmMgYi94ZW4vZHJpdmVycy92cGNpL2hl
YWRlci5jDQo+PiBpbmRleCBmOGNkNTVlN2MwLi5jNWIwMjViODhiIDEwMDY0NA0KPj4gLS0tIGEv
eGVuL2RyaXZlcnMvdnBjaS9oZWFkZXIuYw0KPj4gKysrIGIveGVuL2RyaXZlcnMvdnBjaS9oZWFk
ZXIuYw0KPj4gQEAgLTM3NCw3ICszNzQsOCBAQCBzdGF0aWMgdm9pZCBiYXJfd3JpdGUoY29uc3Qg
c3RydWN0IHBjaV9kZXYgKnBkZXYsIHVuc2lnbmVkIGludCByZWcsDQo+PiAgICAgICAgIGlmICgg
dmFsICE9ICh1aW50MzJfdCkoYmFyLT5hZGRyID4+IChoaSA/IDMyIDogMCkpICkNCj4+ICAgICAg
ICAgICAgIGdwcmludGsoWEVOTE9HX1dBUk5JTkcsDQo+PiAgICAgICAgICAgICAgICAgICAgICIl
cHA6IGlnbm9yZWQgQkFSICVsdSB3cml0ZSB3aXRoIG1lbW9yeSBkZWNvZGluZyBlbmFibGVkXG4i
LA0KPj4gLSAgICAgICAgICAgICAgICAgICAgJnBkZXYtPnNiZGYsIGJhciAtIHBkZXYtPnZwY2kt
PmhlYWRlci5iYXJzICsgaGkpOw0KPj4gKyAgICAgICAgICAgICAgICAgICAgJnBkZXYtPnNiZGYs
DQo+PiArICAgICAgICAgICAgICAgICAgICAodW5zaWduZWQgbG9uZykoYmFyIC0gcGRldi0+dnBj
aS0+aGVhZGVyLmJhcnMgKyBoaSkpOw0KPj4gICAgICAgICByZXR1cm47DQo+PiAgICAgfQ0KPj4g
DQo+PiBkaWZmIC0tZ2l0IGEveGVuL2RyaXZlcnMvdnBjaS92cGNpLmMgYi94ZW4vZHJpdmVycy92
cGNpL3ZwY2kuYw0KPj4gaW5kZXggYzA4NTMxNzZkNy4uMmJkNjdmYzI3YSAxMDA2NDQNCj4+IC0t
LSBhL3hlbi9kcml2ZXJzL3ZwY2kvdnBjaS5jDQo+PiArKysgYi94ZW4vZHJpdmVycy92cGNpL3Zw
Y2kuYw0KPj4gQEAgLTUwNyw3ICs1MDcsNyBAQCBpbnQgdnBjaV9lY2FtX21taW9fd3JpdGUocGNp
X3NiZGZfdCBzYmRmLCB1bnNpZ25lZCBpbnQgcmVnLCB1bnNpZ25lZCBpbnQgbGVuLA0KPj4gDQo+
PiAgICAgdnBjaV93cml0ZShzYmRmLCByZWcsIG1pbig0dSwgbGVuKSwgZGF0YSk7DQo+PiAgICAg
aWYgKCBsZW4gPT0gOCApDQo+PiAtICAgICAgICB2cGNpX3dyaXRlKHNiZGYsIHJlZyArIDQsIDQs
IGRhdGEgPj4gMzIpOw0KPj4gKyAgICAgICAgdnBjaV93cml0ZShzYmRmLCByZWcgKyA0LCA0LCAo
dWludDY0X3QpZGF0YSA+PiAzMik7DQo+PiANCj4+ICAgICByZXR1cm4gMTsNCj4+IH0NCj4+IGRp
ZmYgLS1naXQgYS94ZW4vaW5jbHVkZS9hc20tYXJtL2RvbWFpbi5oIGIveGVuL2luY2x1ZGUvYXNt
LWFybS9kb21haW4uaA0KPj4gaW5kZXggMTRlNTc1Mjg4Zi4uOWIzNjQ3NTg3YSAxMDA2NDQNCj4+
IC0tLSBhL3hlbi9pbmNsdWRlL2FzbS1hcm0vZG9tYWluLmgNCj4+ICsrKyBiL3hlbi9pbmNsdWRl
L2FzbS1hcm0vZG9tYWluLmgNCj4+IEBAIC0yNjMsNiArMjYzLDcgQEAgc3RhdGljIGlubGluZSB2
b2lkIGFyY2hfdmNwdV9ibG9jayhzdHJ1Y3QgdmNwdSAqdikge30NCj4+IA0KPj4gI2RlZmluZSBh
cmNoX3ZtX2Fzc2lzdF92YWxpZF9tYXNrKGQpICgxVUwgPDwgVk1BU1NUX1RZUEVfcnVuc3RhdGVf
dXBkYXRlX2ZsYWcpDQo+PiANCj4+ICsvKiB2UENJIGlzIG5vdCBhdmFpbGFibGUgb24gQXJtICov
DQo+PiAjZGVmaW5lIGhhc192cGNpKGQpICAgICh7ICh2b2lkKShkKTsgZmFsc2U7IH0pDQo+PiAN
Cj4+ICNlbmRpZiAvKiBfX0FTTV9ET01BSU5fSF9fICovDQo+PiBkaWZmIC0tZ2l0IGEveGVuL2lu
Y2x1ZGUvYXNtLXg4Ni9wY2kuaCBiL3hlbi9pbmNsdWRlL2FzbS14ODYvcGNpLmgNCj4+IGluZGV4
IGEwZGY1YzEyNzkuLjQ0M2YyNTM0N2QgMTAwNjQ0DQo+PiAtLS0gYS94ZW4vaW5jbHVkZS9hc20t
eDg2L3BjaS5oDQo+PiArKysgYi94ZW4vaW5jbHVkZS9hc20teDg2L3BjaS5oDQo+PiBAQCAtNiw4
ICs2LDYgQEANCj4+ICNkZWZpbmUgQ0Y4X0FERFJfSEkoY2Y4KSAoICAoKGNmOCkgJiAweDBmMDAw
MDAwKSA+PiAxNikNCj4+ICNkZWZpbmUgQ0Y4X0VOQUJMRUQoY2Y4KSAoISEoKGNmOCkgJiAweDgw
MDAwMDAwKSkNCj4+IA0KPj4gLSNkZWZpbmUgRUNBTV9CREYoYWRkcikgICAoICgoYWRkcikgJiAw
eDBmZmZmMDAwKSA+PiAxMikNCj4+IC0NCj4+ICNkZWZpbmUgSVNfU05CX0dGWChpZCkgKGlkID09
IDB4MDEwNjgwODYgfHwgaWQgPT0gMHgwMTE2ODA4NiBcDQo+PiAgICAgICAgICAgICAgICAgICAg
ICAgICB8fCBpZCA9PSAweDAxMjY4MDg2IHx8IGlkID09IDB4MDEwMjgwODYgXA0KPj4gICAgICAg
ICAgICAgICAgICAgICAgICAgfHwgaWQgPT0gMHgwMTEyODA4NiB8fCBpZCA9PSAweDAxMjI4MDg2
IFwNCj4+IGRpZmYgLS1naXQgYS94ZW4vaW5jbHVkZS9wdWJsaWMvYXJjaC1hcm0uaCBiL3hlbi9p
bmNsdWRlL3B1YmxpYy9hcmNoLWFybS5oDQo+PiBpbmRleCBkNDZjNjFmY2E5Li40NGJlMzM3ZGVj
IDEwMDY0NA0KPj4gLS0tIGEveGVuL2luY2x1ZGUvcHVibGljL2FyY2gtYXJtLmgNCj4+ICsrKyBi
L3hlbi9pbmNsdWRlL3B1YmxpYy9hcmNoLWFybS5oDQo+PiBAQCAtNDE4LDYgKzQxOCwxMyBAQCB0
eXBlZGVmIHVpbnQ2NF90IHhlbl9jYWxsYmFja190Ow0KPj4gI2RlZmluZSBHVUVTVF9HSUNWM19H
SUNSMF9CQVNFICAgICB4ZW5fbWtfdWxsb25nKDB4MDMwMjAwMDApIC8qIHZDUFUwLi4xMjcgKi8N
Cj4+ICNkZWZpbmUgR1VFU1RfR0lDVjNfR0lDUjBfU0laRSAgICAgeGVuX21rX3VsbG9uZygweDAx
MDAwMDAwKQ0KPj4gDQo+PiArLyoNCj4+ICsgKiAyNTYgTUIgaXMgcmVzZXJ2ZWQgZm9yIFZQQ0kg
Y29uZmlndXJhdGlvbiBzcGFjZSBiYXNlZCBvbiBjYWxjdWxhdGlvbg0KPj4gKyAqIDI1NiBidXNl
cyDDlyAzMiBkZXZpY2VzIMOXIDggZnVuY3Rpb25zIMOXIDQgS0IgPSAyNTYgTUINCj4+ICsgKi8N
Cj4gDQo+IFNvbWVob3cgMyBub24tYXNjaWkgY2hhcmFjdGVycyBzbmVha2VkIGludG8gdGhpcyBw
YXRjaC4gVGhlICd4JyBhcmUgbm90DQo+ICd4JyBidXQgYXJlIDB4YzMgYW5kIGNhdXNlIHRoZSBm
b2xsb3dpbmcgZXJyb3JzIGluIGEgZmV3IGdpdGxhYi1jaQ0KPiBidWlsZHM6DQo+IA0KPiBweXRo
b24zIG1raGVhZGVyLnB5IGFybTMyIGFybTMyLmgudG1wIC9idWlsZHMveGVuLXByb2plY3QvcGVv
cGxlL3NzdGFiZWxsaW5pL3hlbi90b29scy9pbmNsdWRlL3hlbi1mb3JlaWduLy4uLy4uLy4uL3hl
bi9pbmNsdWRlL3B1YmxpYy9hcmNoLWFybS5oIC9idWlsZHMveGVuLXByb2plY3QvcGVvcGxlL3Nz
dGFiZWxsaW5pL3hlbi90b29scy9pbmNsdWRlL3hlbi1mb3JlaWduLy4uLy4uLy4uL3hlbi9pbmNs
dWRlL3B1YmxpYy94ZW4uaA0KPiBUcmFjZWJhY2sgKG1vc3QgcmVjZW50IGNhbGwgbGFzdCk6DQo+
ICBGaWxlICJta2hlYWRlci5weSIsIGxpbmUgMTIwLCBpbiA8bW9kdWxlPg0KPiAgICBpbnB1dCAr
PSBmLnJlYWQoKTsNCj4gIEZpbGUgIi91c3IvbGliL3B5dGhvbjMuNS9lbmNvZGluZ3MvYXNjaWku
cHkiLCBsaW5lIDI2LCBpbiBkZWNvZGUNCj4gICAgcmV0dXJuIGNvZGVjcy5hc2NpaV9kZWNvZGUo
aW5wdXQsIHNlbGYuZXJyb3JzKVswXQ0KPiBVbmljb2RlRGVjb2RlRXJyb3I6ICdhc2NpaScgY29k
ZWMgY2FuJ3QgZGVjb2RlIGJ5dGUgMHhjMyBpbiBwb3NpdGlvbiAxNDY0MTogb3JkaW5hbCBub3Qg
aW4gcmFuZ2UoMTI4KQ0KPiBNYWtlZmlsZToyODogcmVjaXBlIGZvciB0YXJnZXQgJ2FybTMyLmgn
IGZhaWxlZA0KPiBtYWtlWzJdOiAqKiogW2FybTMyLmhdIEVycm9yIDENCj4gDQo+IEZ1bGwgbG9n
cyBoZXJlOg0KPiBodHRwczovL2dpdGxhYi5jb20veGVuLXByb2plY3QvcGVvcGxlL3NzdGFiZWxs
aW5pL3hlbi8tL3BpcGVsaW5lcy8zODg1NTA3OA0KPiBodHRwczovL2dpdGxhYi5jb20veGVuLXBy
b2plY3QvcGVvcGxlL3NzdGFiZWxsaW5pL3hlbi8tL2pvYnMvMTY4MTAxMDg3NTYNCj4gDQo+IA0K
PiBSZXBsYWNpbmcgdGhlIDMgY2hhcmFjdGVycyB3aXRoICd4JyBzb2x2ZXMgdGhlIHByb2JsZW0u
DQo+IGh0dHBzOi8vZ2l0bGFiLmNvbS94ZW4tcHJvamVjdC9wZW9wbGUvc3N0YWJlbGxpbmkveGVu
Ly0vcGlwZWxpbmVzLzM4ODcyMTI2Mg0KPiANCj4gDQo+IFdpdGggdGhlIHRocmVlICd4JyBjaGFu
Z2VkIHRvIGFzY2lpOg0KPiANCj4gUmV2aWV3ZWQtYnk6IFN0ZWZhbm8gU3RhYmVsbGluaSA8c3N0
YWJlbGxpbmlAa2VybmVsLm9yZz4NCg0KSSB3aWxsIGZpeCB0aGF0IGJ1dCBzYWRseSBzZWVpbmcg
YWxsIG90aGVyIGNoYW5nZXMgdG8gYmUgZG9uZSBJIGRvIG5vdCB0aGluayBJIGNhbiBrZWVwIHlv
dXIgUi1iLg0KDQpUaGFua3MNCkJlcnRyYW5kDQoNCj4gDQo+IA0KPiANCj4+ICsjZGVmaW5lIEdV
RVNUX1ZQQ0lfRUNBTV9CQVNFICAgIHhlbl9ta191bGxvbmcoMHgxMDAwMDAwMCkNCj4+ICsjZGVm
aW5lIEdVRVNUX1ZQQ0lfRUNBTV9TSVpFICAgIHhlbl9ta191bGxvbmcoMHgxMDAwMDAwMCkNCj4+
ICsNCj4+IC8qIEFDUEkgdGFibGVzIHBoeXNpY2FsIGFkZHJlc3MgKi8NCj4+ICNkZWZpbmUgR1VF
U1RfQUNQSV9CQVNFIHhlbl9ta191bGxvbmcoMHgyMDAwMDAwMCkNCj4+ICNkZWZpbmUgR1VFU1Rf
QUNQSV9TSVpFIHhlbl9ta191bGxvbmcoMHgwMjAwMDAwMCkNCj4+IGRpZmYgLS1naXQgYS94ZW4v
aW5jbHVkZS94ZW4vcGNpLmggYi94ZW4vaW5jbHVkZS94ZW4vcGNpLmgNCj4+IGluZGV4IDcwYWMy
NTM0NWMuLmRiMThjYjc2MzkgMTAwNjQ0DQo+PiAtLS0gYS94ZW4vaW5jbHVkZS94ZW4vcGNpLmgN
Cj4+ICsrKyBiL3hlbi9pbmNsdWRlL3hlbi9wY2kuaA0KPj4gQEAgLTQwLDYgKzQwLDkgQEANCj4+
ICNkZWZpbmUgUENJX1NCREYzKHMsYixkZikgXA0KPj4gICAgICgocGNpX3NiZGZfdCl7IC5zYmRm
ID0gKCgocykgJiAweGZmZmYpIDw8IDE2KSB8IFBDSV9CREYyKGIsIGRmKSB9KQ0KPj4gDQo+PiAr
I2RlZmluZSBFQ0FNX0JERihhZGRyKSAgICAgICAgICggKChhZGRyKSAmIDB4MGZmZmYwMDApID4+
IDEyKQ0KPj4gKyNkZWZpbmUgRUNBTV9SRUdfT0ZGU0VUKGFkZHIpICAoKGFkZHIpICYgMHgwMDAw
MGZmZikNCj4+ICsNCj4+IHR5cGVkZWYgdW5pb24gew0KPj4gICAgIHVpbnQzMl90IHNiZGY7DQo+
PiAgICAgc3RydWN0IHsNCj4+IC0tIA0KPj4gMi4yNS4xDQoNCg==


From xen-devel-bounces@lists.xenproject.org Fri Oct 15 10:12:47 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 10:12:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.210162.366910 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbKCl-0007A1-2j; Fri, 15 Oct 2021 10:12:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 210162.366910; Fri, 15 Oct 2021 10:12:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbKCk-00079u-Um; Fri, 15 Oct 2021 10:12:46 +0000
Received: by outflank-mailman (input) for mailman id 210162;
 Fri, 15 Oct 2021 10:12:46 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Fqmt=PD=arm.com=Bertrand.Marquis@srs-us1.protection.inumbo.net>)
 id 1mbKCk-00079o-G1
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 10:12:46 +0000
Received: from EUR05-AM6-obe.outbound.protection.outlook.com (unknown
 [2a01:111:f400:7e1b::620])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id d887e701-db77-4a2d-b05a-784fb6902e8e;
 Fri, 15 Oct 2021 10:12:45 +0000 (UTC)
Received: from AM5PR0202CA0007.eurprd02.prod.outlook.com
 (2603:10a6:203:69::17) by VI1PR08MB2638.eurprd08.prod.outlook.com
 (2603:10a6:802:1f::26) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18; Fri, 15 Oct
 2021 10:12:42 +0000
Received: from VE1EUR03FT013.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:203:69:cafe::83) by AM5PR0202CA0007.outlook.office365.com
 (2603:10a6:203:69::17) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16 via Frontend
 Transport; Fri, 15 Oct 2021 10:12:42 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT013.mail.protection.outlook.com (10.152.19.37) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.15 via Frontend Transport; Fri, 15 Oct 2021 10:12:41 +0000
Received: ("Tessian outbound 8e26f7114b75:v103");
 Fri, 15 Oct 2021 10:12:41 +0000
Received: from 78d4ed326ada.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 28225B74-60B2-434F-AF29-B430C90A1C03.1; 
 Fri, 15 Oct 2021 10:12:35 +0000
Received: from EUR02-VE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 78d4ed326ada.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 15 Oct 2021 10:12:35 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com (2603:10a6:4:74::9)
 by DB9PR08MB6825.eurprd08.prod.outlook.com (2603:10a6:10:2af::9) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16; Fri, 15 Oct
 2021 10:12:33 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955]) by DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955%4]) with mapi id 15.20.4587.031; Fri, 15 Oct 2021
 10:12:33 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d887e701-db77-4a2d-b05a-784fb6902e8e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=gHihjhMyBnsJlRDO5BLNNL2M+R+5vHhW9efdHWLCojk=;
 b=mjyqeEp9YQ3IEY+PezXLTzDDFHIozsDotq0LumQjSi3+xJoZkLGClG3ehB5XztoPuCUyx4Jo4BGdTJlSkXF3rsMV+pTlvNRcp+CAwQjrfMEVhERFpRnhaZ7lUPMaMeO1vvnCRYv2IMErTr79Rxabp0ZYvacQ6oda4fPnitVaS9Y=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: f4bb9e850a702bb5
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ktIYFkUVsoASGlGfh0RzgcL+lSeGu77ddKtpn/EOaxUS6REpmAbYApchqL1r3kJwIC+tTX7lmKiKC7w58X4AouRwuuRStkVktQgsuz/qbZT2DTa0ll7EzA+wGR8aQH6tL32Ep9oHjTa7+ET30zxKpq2z/cRQSgNZEPHb/1HvN7RCfCO+uooj5PBh08DJJsp/RbubrZq1/5FjIIfKXga9wvtgLoGwllcvsmXeDtnjRJCf5JmnJO4SnGXWrV/73az96kfJuohbh8GVTAHQIGIz/azUxdlHPNiONEhhLFmC0I1q7kj/wO2qcHbDg/my31dUyV9KY0gapbxdXY1Vg2EVuA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=gHihjhMyBnsJlRDO5BLNNL2M+R+5vHhW9efdHWLCojk=;
 b=KN9jxrAWrFhRPjv4Bgqsru2nO3gfL872He0HQdU0VbHI8vN5tTIMkAF487MeD0LOlNNiZwX7ILmOL/5jEwiuehdYxkC34varuhHT2yZztkXIvZQnWf4FrS+xHTCbXQDYVDxKa6fvwnVn/8vQpOra1tQfShbEpEf7r/KGhR3dHZoCwka8u5v/4z5Jt1c//CdQjEXc67xy4HJl4uBUAS5FjV/Ly/UkWvhT+6qzcXDynCOFXj3w3xZes3xWLbumM8GOpbrURMYOo3/qgDkjb+AOtb4GyVpxnFtHb0t3VDY4+zsBYb8zTcwdOzswzsydlHWNih3ZHor3S4OEUkZxNrsGBg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=gHihjhMyBnsJlRDO5BLNNL2M+R+5vHhW9efdHWLCojk=;
 b=mjyqeEp9YQ3IEY+PezXLTzDDFHIozsDotq0LumQjSi3+xJoZkLGClG3ehB5XztoPuCUyx4Jo4BGdTJlSkXF3rsMV+pTlvNRcp+CAwQjrfMEVhERFpRnhaZ7lUPMaMeO1vvnCRYv2IMErTr79Rxabp0ZYvacQ6oda4fPnitVaS9Y=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>, "iwj@xenproject.org"
	<iwj@xenproject.org>, Paul Durrant <paul@xen.org>, Jan Beulich
	<jbeulich@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu
	<wl@xen.org>
Subject: Re: [PATCH v6 1/3] xen/vpci: Move ecam access functions to common
 code
Thread-Topic: [PATCH v6 1/3] xen/vpci: Move ecam access functions to common
 code
Thread-Index: AQHXwQraA42SZeh0QUGI/xX7keuWA6vTrtGAgAACnoCAACGIAIAABUmA
Date: Fri, 15 Oct 2021 10:12:33 +0000
Message-ID: <5CD14C43-2131-487F-B4D8-ECE5B2F07A14@arm.com>
References: <cover.1634221830.git.bertrand.marquis@arm.com>
 <ced6f870dbfabcfe8584555cc80f9a37a0655a0c.1634221830.git.bertrand.marquis@arm.com>
 <YWkxT1bVmBT7Av43@MacBook-Air-de-Roger.local>
 <EB6EE7F3-80BD-4717-87C7-C54FAB0FD832@arm.com>
 <YWlPohYpgxs3gRlc@MacBook-Air-de-Roger.local>
In-Reply-To: <YWlPohYpgxs3gRlc@MacBook-Air-de-Roger.local>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3654.120.0.1.13)
Authentication-Results-Original: citrix.com; dkim=none (message not signed)
 header.d=none;citrix.com; dmarc=none action=none header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: ca89365b-7cec-4f22-2b6d-08d98fc4531c
x-ms-traffictypediagnostic: DB9PR08MB6825:|VI1PR08MB2638:
X-Microsoft-Antispam-PRVS:
	<VI1PR08MB26386FC90A941866C820F1B79DB99@VI1PR08MB2638.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:8882;OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 sIpL3fUct7tcFsHEwp2WN89Sl8Hke9C4+g3rr17aKzfuwt8XaFRT4HeXp3rfSigtq9Y6bBKBR+nx1fmaKxio9Ld5Ed0PZvXamMvaOEKC4eI5gijaOvUDdj3He5eD3EyA7mUB4n3wUpWTBiZhZg72VcIH5SYIlnK7IMmPVl/Vzhg0ww2FnRDjp4HPPxpbd72ONT1fCwXsQOLTfdpXKnnl3xJjHAh6rN3gHt2Gt8lNaopZWtTwwukQD3RogCWmEZsBvFN7xw4mycdw0e/7c2Zthydy+v6CiIjYpX1GHm3QxwBOzt1IwfMMG46tK4kVAur1BSwQOmmYto3Aih0FW/nZIwBW6aUedCBXW9xl+OBnJ3xZZFFrgkg4CjyPT4+aM7L19s26kdlIuTwTcu0YttQfPOMPU3rFPx6kAYs6Mp9vR6eEuOJ6UbDphTM1lCsNxWCOa/tWEyXkKCgQ5PTSd70X8AUGnjg3KEElducVTx1T3dWDgIOVVL6JRwKsm2Y+dKdtoqUl/UCrMGVwqdK3DGxLUq1iRMq30OglFpkU2ykwIjH/NiD7DgXkmkzSdTWD6jMT3nbqt8DDXSrLh4Qs5Tf1y07FXwklwcM4nP0GjXwdiEMmNfzMChNQfe57ezdNQna2/PpOTTo5KyJkCWnLQik8trQbOKlIwYSvKl5K1Rj12KZjXrPHlzH9XgNW2JHLHf8VjUbZ+i7Rp3vHlX/9vyIk+vm7zgH92kGtHPo+oTZIsGE=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB6PR0801MB2024.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(186003)(316002)(53546011)(4326008)(86362001)(76116006)(54906003)(36756003)(508600001)(6512007)(2906002)(71200400001)(6506007)(66556008)(38070700005)(38100700002)(8936002)(122000001)(5660300002)(6916009)(26005)(64756008)(66476007)(66946007)(8676002)(83380400001)(6486002)(33656002)(66446008)(91956017)(2616005)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="utf-8"
Content-ID: <A65083CB1E1B864B8715F912EBEBB5E0@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB6825
Original-Authentication-Results: citrix.com; dkim=none (message not signed)
 header.d=none;citrix.com; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT013.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	7c562b7a-b456-4a45-1cbd-08d98fc44e4a
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	cbOnEBX7Zc+Le2myO/zIOlTIrBLqy9cV8lHpqnbujhN9UB9JY8yTfLZE2PzRfeiKfvLvWNQ6vX9ZryE/GOtAaP6W+Eigqp10VfK3kCIl7Xj6YtC/5YNXX7OGFTS7gjV/e3DNlJRpQtXNdW6qgkm5E+9cRtPLk8IGs4IhiHHxwWg8tRGRVrjACf/+HwFs2u7XxMdoPT4K0up5kqotq0zgYngyUJaC+GvWEUInLl5iVigeNfIa7PWnx0vIfQbdG9tVUKruK6WhWdJopnkoyjO9iHfNCUvZRGwkj2txeTS5zmJ+/cXJu11z7YvGUGTncK2o31oDhK0enjmM/++pTmS7kSrcBfeHSlC+IHLNJ5Nq0Ff8HTgi5jo15GLskyb5qtzDb+4IfHvdanx4lfPEDzv0yAhwcr4vW/KUAoI3V1o5R4Q3HJ6n0LQLHm4Aa1FUCUDxjk/3SoIZ7AcqN+/0tUjGEfPppYj1+oAH6ze25zy9qCIP5j/yiGnkzM6l/i695hoA6Y6PAjLrJPCyqkdBdyYAo6q8XY7djOAXLQkEtNom+7GCJjP6PlIaTG4den3s93r9ciRCe/ULCBHpD/De83w3Cs5w6CK98lKbqeN4pOQaaAsRvvo7Ru3guXF5wSrQsBzJAUB1H6OKZaF/qaZ9DhPzXMILoHrEkm/vPzsRGhz/taQleVWa6jYBibMtgTqpWkfs
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(508600001)(81166007)(33656002)(2616005)(47076005)(356005)(86362001)(2906002)(336012)(6862004)(70206006)(6512007)(8936002)(5660300002)(70586007)(53546011)(8676002)(6486002)(83380400001)(36860700001)(82310400003)(54906003)(4326008)(186003)(6506007)(26005)(316002)(36756003);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2021 10:12:41.8403
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: ca89365b-7cec-4f22-2b6d-08d98fc4531c
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT013.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB2638

SGkgUm9nZXIsDQoNCj4gT24gMTUgT2N0IDIwMjEsIGF0IDEwOjUzLCBSb2dlciBQYXUgTW9ubsOp
IDxyb2dlci5wYXVAY2l0cml4LmNvbT4gd3JvdGU6DQo+IA0KPiBPbiBGcmksIE9jdCAxNSwgMjAy
MSBhdCAwNzo1MzozOEFNICswMDAwLCBCZXJ0cmFuZCBNYXJxdWlzIHdyb3RlOg0KPj4+IE9uIDE1
IE9jdCAyMDIxLCBhdCAwODo0NCwgUm9nZXIgUGF1IE1vbm7DqSA8cm9nZXIucGF1QGNpdHJpeC5j
b20+IHdyb3RlOg0KPj4+IE9uIFRodSwgT2N0IDE0LCAyMDIxIGF0IDAzOjQ5OjQ5UE0gKzAxMDAs
IEJlcnRyYW5kIE1hcnF1aXMgd3JvdGU6DQo+Pj4+IEBAIC00MzQsMjUgKzQyMCw4IEBAIHN0YXRp
YyBpbnQgdnBjaV9tbWNmZ19yZWFkKHN0cnVjdCB2Y3B1ICp2LCB1bnNpZ25lZCBsb25nIGFkZHIs
DQo+Pj4+ICAgIHJlZyA9IHZwY2lfbW1jZmdfZGVjb2RlX2FkZHIobW1jZmcsIGFkZHIsICZzYmRm
KTsNCj4+Pj4gICAgcmVhZF91bmxvY2soJmQtPmFyY2guaHZtLm1tY2ZnX2xvY2spOw0KPj4+PiAN
Cj4+Pj4gLSAgICBpZiAoICF2cGNpX2FjY2Vzc19hbGxvd2VkKHJlZywgbGVuKSB8fA0KPj4+PiAt
ICAgICAgICAgKHJlZyArIGxlbikgPiBQQ0lfQ0ZHX1NQQUNFX0VYUF9TSVpFICkNCj4+Pj4gLSAg
ICAgICAgcmV0dXJuIFg4NkVNVUxfT0tBWTsNCj4+Pj4gLQ0KPj4+PiAtICAgIC8qDQo+Pj4+IC0g
ICAgICogQWNjb3JkaW5nIHRvIHRoZSBQQ0llIDMuMUEgc3BlY2lmaWNhdGlvbjoNCj4+Pj4gLSAg
ICAgKiAgLSBDb25maWd1cmF0aW9uIFJlYWRzIGFuZCBXcml0ZXMgbXVzdCB1c3VhbGx5IGJlIERX
T1JEIG9yIHNtYWxsZXINCj4+Pj4gLSAgICAgKiAgICBpbiBzaXplLg0KPj4+PiAtICAgICAqICAt
IEJlY2F1c2UgUm9vdCBDb21wbGV4IGltcGxlbWVudGF0aW9ucyBhcmUgbm90IHJlcXVpcmVkIHRv
IHN1cHBvcnQNCj4+Pj4gLSAgICAgKiAgICBhY2Nlc3NlcyB0byBhIFJDUkIgdGhhdCBjcm9zcyBE
VyBib3VuZGFyaWVzIFsuLi5dIHNvZnR3YXJlDQo+Pj4+IC0gICAgICogICAgc2hvdWxkIHRha2Ug
Y2FyZSBub3QgdG8gY2F1c2UgdGhlIGdlbmVyYXRpb24gb2Ygc3VjaCBhY2Nlc3Nlcw0KPj4+PiAt
ICAgICAqICAgIHdoZW4gYWNjZXNzaW5nIGEgUkNSQiB1bmxlc3MgdGhlIFJvb3QgQ29tcGxleCB3
aWxsIHN1cHBvcnQgdGhlDQo+Pj4+IC0gICAgICogICAgYWNjZXNzLg0KPj4+PiAtICAgICAqICBY
ZW4gaG93ZXZlciBzdXBwb3J0cyA4Ynl0ZSBhY2Nlc3NlcyBieSBzcGxpdHRpbmcgdGhlbSBpbnRv
IHR3bw0KPj4+PiAtICAgICAqICA0Ynl0ZSBhY2Nlc3Nlcy4NCj4+Pj4gLSAgICAgKi8NCj4+Pj4g
LSAgICAqZGF0YSA9IHZwY2lfcmVhZChzYmRmLCByZWcsIG1pbig0dSwgbGVuKSk7DQo+Pj4+IC0g
ICAgaWYgKCBsZW4gPT0gOCApDQo+Pj4+IC0gICAgICAgICpkYXRhIHw9ICh1aW50NjRfdCl2cGNp
X3JlYWQoc2JkZiwgcmVnICsgNCwgNCkgPDwgMzI7DQo+Pj4+ICsgICAgLyogSWdub3JlIHJldHVy
biBjb2RlICovDQo+Pj4+ICsgICAgdnBjaV9lY2FtX21taW9fcmVhZChzYmRmLCByZWcsIGxlbiwg
ZGF0YSk7DQo+Pj4gDQo+Pj4gSSB0aGluayBpdCB3b3VsZCBiZSBiZXR0ZXIgZm9yIHZwY2lfZWNh
bV9tbWlvX3JlYWQgdG8ganVzdCByZXR1cm4gdGhlDQo+Pj4gcmVhZCB2YWx1ZSwgb3IgfjAgaW4g
Y2FzZSBvZiBlcnJvciwgYXQgbGVhc3QgdGhhdCBpbnRlcmZhY2Ugd291bGQgYmUNCj4+PiBzaW1w
bGVyIGFuZCBzdWl0YWJsZSBmb3IgeDg2Lg0KPj4gDQo+PiBJIGFtIG5vdCBxdWl0ZSBzdXJlIG9u
IHRoaXMgYXMgb24gYWJzb2x1dGUgdG8gcmVhZCB+MCBpcyBwb3NzaWJsZSBzbyB0aGUNCj4+IGNh
bGxlciBjYW5ub3QgZGlzdGluZ3Vpc2ggYmV0d2VlbiBwcm9wZXJseSByZWFkaW5nIH4wIG9yIGFu
IGFjY2VzcyBhbGxvd2VkIGVycm9yLg0KPiANCj4gSG93IGRvIHlvdSByZXBvcnQgYW4gYWNjZXNz
IGFsbG93ZWQgZXJyb3Igb24gQXJtIGZvciB0aGUgUENJIGNvbmZpZw0KPiBzcGFjZT8NCg0KVGhp
cyBkb2VzIG5vdCBnbyB0aGF0IGZhci4gSW4gdGhlIGN1cnJlbnQgY2FzZSB0aGlzIGlzIGFjdHVh
bGx5IGFuIHVuYWxpZ25lZA0KYWNjZXNzIHRvIG1taW8gd2hpY2ggd2lsbCB0cmlnZ2VyIGFuZCBl
eGNlcHRpb24gYmVmb3JlIHJlYWNoaW5nIHRoZSBQQ0kgY29uZmlnIHNwYWNlLg0KDQo+IA0KPiBB
dCBsZWFzdCBvbiB4ODYgSSBkb24ndCB0aGluayB3ZSBjdXJyZW50bHkgaGF2ZSBhIHdheSB0byBw
cm9wYWdhdGUNCj4gc3VjaCBlcnJvcnMsIG5laXRoZXIgYSBwbGFuIHRvIGRvIHNvIHRoYXQgSSdt
IGF3YXJlLg0KDQpUaGUgYmVoYXZpb3VyIG9uIHg4NiB3aWxsIG5vdCBjaGFuZ2UgYXMgd2Ugd2ls
bCBpZ25vcmUgdGhpcy4NCg0KUmVnYXJkcw0KQmVydHJhbmQNCg0KPiANCj4gVGhhbmtzLCBSb2dl
ci4NCg0K


From xen-devel-bounces@lists.xenproject.org Fri Oct 15 10:13:39 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 10:13:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.210168.366921 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbKDb-0007j7-Bx; Fri, 15 Oct 2021 10:13:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 210168.366921; Fri, 15 Oct 2021 10:13:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbKDb-0007j0-8K; Fri, 15 Oct 2021 10:13:39 +0000
Received: by outflank-mailman (input) for mailman id 210168;
 Fri, 15 Oct 2021 10:13:37 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=YWEc=PD=arm.com=Luca.Fancellu@srs-us1.protection.inumbo.net>)
 id 1mbKDZ-0007iq-Md
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 10:13:37 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com (unknown
 [40.107.7.43]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 8e78dc42-2da0-11ec-822c-12813bfff9fa;
 Fri, 15 Oct 2021 10:13:35 +0000 (UTC)
Received: from AS9PR04CA0069.eurprd04.prod.outlook.com (2603:10a6:20b:48b::11)
 by AM6PR08MB4456.eurprd08.prod.outlook.com (2603:10a6:20b:b3::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15; Fri, 15 Oct
 2021 10:13:33 +0000
Received: from VE1EUR03FT044.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:48b:cafe::f3) by AS9PR04CA0069.outlook.office365.com
 (2603:10a6:20b:48b::11) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15 via Frontend
 Transport; Fri, 15 Oct 2021 10:13:33 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT044.mail.protection.outlook.com (10.152.19.106) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.15 via Frontend Transport; Fri, 15 Oct 2021 10:13:33 +0000
Received: ("Tessian outbound e27daf245730:v103");
 Fri, 15 Oct 2021 10:13:32 +0000
Received: from 41f811c56e9a.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 C5C82085-1852-443E-9583-32E12AD01F69.1; 
 Fri, 15 Oct 2021 10:13:23 +0000
Received: from EUR01-HE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 41f811c56e9a.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 15 Oct 2021 10:13:23 +0000
Received: from PAXPR08MB6816.eurprd08.prod.outlook.com (2603:10a6:102:130::10)
 by PA4PR08MB5951.eurprd08.prod.outlook.com (2603:10a6:102:ee::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15; Fri, 15 Oct
 2021 10:13:19 +0000
Received: from PAXPR08MB6816.eurprd08.prod.outlook.com
 ([fe80::c1b4:db1c:376f:b697]) by PAXPR08MB6816.eurprd08.prod.outlook.com
 ([fe80::c1b4:db1c:376f:b697%8]) with mapi id 15.20.4608.017; Fri, 15 Oct 2021
 10:13:19 +0000
Received: from smtpclient.apple (82.8.129.65) by
 LO4P265CA0036.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2ae::12) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.15 via Frontend Transport; Fri, 15 Oct 2021 10:13:19 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8e78dc42-2da0-11ec-822c-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=iohhfgrr3LCvkvtkU3E3dhPp19PWUSdlUFKzONORix4=;
 b=MEnUOXT6xaArxqr/QMFf1QPQmVRIlj4N4CkoHTdtRWZVswIYbKnAWSdqwI1uBte9Xa+JQaZbAsN3CgjGrCw0rmr43zQ8cm6ppNrN+aq25up2p9Lz2C6e+XRo73l4kTx2XtAbRZwJcOzUtxnw2R6NFZzSyUzt7V2XdpNKL8/8PgE=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 5a7781c2fd872a67
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=MJyJ2vnSFQP1M0V5zqlX9dggjrGJIfooeraHb2Dibb1LONobkHO68J2eLWKV1m7WyT8Sx9nDej1Yklr/zE+/rUvNRyX9jr+rT9eL8PfcwMvPmdphivkurZFvvortiSc3aZJG+2tbuI3okvuXA3IziU3PHMZOR9e9ehwyIdMVJcsacecFOwgsQfdRIj7Hp3XUe3zIDq5QqHnUfP088Xusz6aE99NjolqjfJZKxuwZ6G9QFWUkBxdaYdjI5zS2wsy+1Z1GTjmtwOz0k0WjLEx0FLRW+E9+v977TVCZ4/MzSrAGL+eEY8s+GZCsUpfFf+OtfysG8v+FVD82G1a1ztHjDQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=iohhfgrr3LCvkvtkU3E3dhPp19PWUSdlUFKzONORix4=;
 b=l71sMyy+mupsa3S9Knc6uwDkqokHD7AZQG4uWz7uKm+mZzOiOHWC8/HKqun7Q37OP5rTO8pLXLZvGtG+nyIaBvhpp1VsPcMKEuWA5sPxVUSw8QE5YeN984Z007yw8fOEscpZ3M4JqVaTPGHt38Dut8839c1SxMFKYon0YPDBBfZ7wdCEy2NxoMF4HoNlwGYsN4gdhg2b3o2LonQFtzwwMhp7gngAOR9njvCzH/tU9rmhgGmQQsbGsqUz/v1QOJocpFdUe5+o256R4sZeRPe1vf1R84FtAW/qP+NJrJdqQnzkBJQdbQSM5mmlfYfX60mjyKKzrYc2AxvbZZI02aGw3Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=iohhfgrr3LCvkvtkU3E3dhPp19PWUSdlUFKzONORix4=;
 b=MEnUOXT6xaArxqr/QMFf1QPQmVRIlj4N4CkoHTdtRWZVswIYbKnAWSdqwI1uBte9Xa+JQaZbAsN3CgjGrCw0rmr43zQ8cm6ppNrN+aq25up2p9Lz2C6e+XRo73l4kTx2XtAbRZwJcOzUtxnw2R6NFZzSyUzt7V2XdpNKL8/8PgE=
Authentication-Results-Original: arm.com; dkim=none (message not signed)
 header.d=none;arm.com; dmarc=none action=none header.from=arm.com;
Content-Type: text/plain;
	charset=utf-8
Subject: Re: [PATCH v6 2/3] xen/arm: Enable the existing x86 virtual PCI
 support for ARM.
From: Luca Fancellu <luca.fancellu@arm.com>
In-Reply-To: <CD9B29B0-31FD-4E09-93E3-7124C724BC23@arm.com>
Date: Fri, 15 Oct 2021 11:13:13 +0100
Cc: =?utf-8?Q?Roger_Pau_Monn=C3=A9?= <roger.pau@citrix.com>,
 Xen-devel <xen-devel@lists.xenproject.org>,
 Ian Jackson <iwj@xenproject.org>,
 Rahul Singh <Rahul.Singh@arm.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Julien Grall <julien@xen.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Jan Beulich <jbeulich@suse.com>,
 Wei Liu <wl@xen.org>,
 Paul Durrant <paul@xen.org>,
 Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
Content-Transfer-Encoding: quoted-printable
Message-Id: <E80D6A5A-2556-49C4-A9F0-E85CCD44D1A8@arm.com>
References: <cover.1634221830.git.bertrand.marquis@arm.com>
 <396b08e2598cf0338e0c7f4ad3cd5cb66db89224.1634221830.git.bertrand.marquis@arm.com>
 <YWk8uP/YuSee1MfG@MacBook-Air-de-Roger.local>
 <CD9B29B0-31FD-4E09-93E3-7124C724BC23@arm.com>
To: Bertrand Marquis <Bertrand.Marquis@arm.com>
X-Mailer: Apple Mail (2.3654.120.0.1.13)
X-ClientProxiedBy: LO4P265CA0036.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:2ae::12) To PAXPR08MB6816.eurprd08.prod.outlook.com
 (2603:10a6:102:130::10)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 06b6e886-ce2a-4422-54a7-08d98fc4719e
X-MS-TrafficTypeDiagnostic: PA4PR08MB5951:|AM6PR08MB4456:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS:
	<AM6PR08MB4456BF65911278A555E0C991E4B99@AM6PR08MB4456.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 FRgYwfC58/1SMqTOIEsyhx1lpF5U5r0b6BHGxxDwJiUbC78hzVzWqALxlMgXvwzCiG+pVRr4hlbOz3tomu41dfNkIgEJRSz9hG890zlxO6aceDtLUwn3V/Xz0EwFI2C19c5/xVR1RDZtNb2dCxAru3/oDuccEVxVgyxShUV4JKIrz27372XtTK87NqDd59hcrB9lFQPHrHqOUcHa3yp0Hx93GMRWOqezBOZZ02hUvuSKlgk5y3SRYruLzATF5F7B+EvwrWHEfnHRsm2ogcqrDRtzBzgVLeAFjf/E+GsY8MYECqGBusyAnn9rhMyNvS5RCFXiTd0bl0JC/1xYaQKxhP8hUE6cm9JIWbg2eqKx33p5ahuhektKZod6MRqIVpwlZZHtcGx9g4RAYH6TDZ2Jl8FnqfzDlL2EAXVGBnPbA+19i0mRgUAI4jEgcag6r83NL1W27180+bf3QCUGVWjfv0bHhNg4Lc+zONXoJ4UKZvZVTbxX5irR8QUfh62Bja6+pfoH9okdzhUXSDdaE3CmpOprV8Ld9AjPnX0ZSaH+6piJkXQelqP5xUV9cs/PdyUxZjYiF68vjrIbE71IQPkzq6NPFLbRmHD1MP0dNIv7z6e28wkjTbbGV4mQGo0Y7s1ZlaIOSjptAPL8mgLsGTK09r8iWdxz7dlq9z+maRM3PAPsKY9glYjg3AQpkrgn91iC/5IqBtN2Oju+RTi2uoGytqEIPoKkyiTZ4hvUsmQggolSlAUm7oUy2CG7Z5w+txHeotDxxEmO7y2ieUYLUzfKmumChTp8tmPfQpylPlCNpif/orvl5FaMn+lNEpeAtCgH0aA3bnjxGhCAf6AEiERsk7aEKJLF9JSzegFGMm+uexZqvp7afY0UN1O/6WIALkFe
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB6816.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(186003)(5660300002)(26005)(53546011)(30864003)(6506007)(508600001)(38100700002)(54906003)(38350700002)(37006003)(6666004)(4326008)(66476007)(66556008)(66946007)(33656002)(7416002)(2616005)(956004)(6486002)(44832011)(8676002)(6512007)(86362001)(966005)(6862004)(52116002)(83380400001)(316002)(36756003)(6636002)(8936002)(2906002)(2004002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB5951
Original-Authentication-Results: arm.com; dkim=none (message not signed)
 header.d=none;arm.com; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT044.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	06fcd33c-ef71-4306-2bbb-08d98fc46973
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	ero8ZkQf4qoGYjTcVTRRsubOe/V8bfSXmO5kgC959VhJmZ0adS5iPP9d2iP5Yqd3f4IoiJdQGgYOXlmGkEf5PMfnSdGVdX1lDieBW9tOwJme2kRKgzYQMZ8UkvYllz1h/0OQ9ovmpV1Aa5QsEFwCN9OkeJyJe0bG4wzzz4UW4C2p8C5vZIvNT1OJWu7QgyQkAN5jCFwa1yKgAQwvB9q1+6HePkHaJ5fiwfM2SbVmflcgN98O8U9CgWD+KUZC9bQrVMqLz3yfFZq47YQski/hYzIDZGw7WVTnzdYjCk6IXWvVNr0U47OPMAcOYwh2xiQN34VTnzVx874zUMX7OBvCdy+phVAER44xWntg7d/mc+J3/k2nUOJZjb+co+mqqtLqt1oIifzZDiZ7JuipNLiseKnkdY939X4m5Y4mxKXIXwkucIAXF7HBtyEwzvPEDj17OMw56ze3Gs5f5LJ1l26A5Vk7mQu2l96nCsEJbHo42/TALJoCieAdwm83T1VtviPjDHgwWLArZZkr2rAzgf+q6haZ5VOOk5w2Wp379vu/wuLQHPGCntRFriEttxZcJSnUcwDbHQtB+8fV9ETmZezyJ5TdHmZxl5n22gCuG6KqfpAv/Ke3H3UQB8Y5FiWVaUV+8bYFxefadWQW/nL8FAqBuX/Ke+y53pxlnFFGKThbe3TFhBqW9SKvX1kJoIfOsNt/XkyxgnbaS05zoBYILn7CxR/5cAYxTzXRDcsyOdetI0hQ6NKhH4vv7YMjmDOxWxYEkOB9ikJ7t0pQBIqkH3sMddyzg23dPerqh/PrVpsB+leI4+MfxGjs7Bj1wqouQicGhCasjqTJTO1TDN2jFh5givUuQTc01Y8RyTQ7X0gAKSM=
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(33656002)(8936002)(508600001)(83380400001)(6636002)(966005)(956004)(2616005)(186003)(47076005)(44832011)(8676002)(26005)(30864003)(86362001)(6666004)(36860700001)(5660300002)(82310400003)(107886003)(4326008)(2906002)(53546011)(316002)(81166007)(6512007)(54906003)(336012)(37006003)(36756003)(356005)(6506007)(6862004)(70206006)(6486002)(70586007)(2004002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2021 10:13:33.0782
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 06b6e886-ce2a-4422-54a7-08d98fc4719e
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT044.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB4456



> On 15 Oct 2021, at 10:52, Bertrand Marquis <Bertrand.Marquis@arm.com> wro=
te:
>=20
> Hi Roger,
>=20
>> On 15 Oct 2021, at 09:32, Roger Pau Monn=C3=A9 <roger.pau@citrix.com> wr=
ote:
>>=20
>> On Thu, Oct 14, 2021 at 03:49:50PM +0100, Bertrand Marquis wrote:
>>> From: Rahul Singh <rahul.singh@arm.com>
>>>=20
>>> The existing VPCI support available for X86 is adapted for Arm.
>>> When the device is added to XEN via the hyper call
>>> =E2=80=9CPHYSDEVOP_pci_device_add=E2=80=9D, VPCI handler for the config=
 space
>>> access is added to the Xen to emulate the PCI devices config space.
>>>=20
>>> A MMIO trap handler for the PCI ECAM space is registered in XEN
>>> so that when guest is trying to access the PCI config space,XEN
>>> will trap the access and emulate read/write using the VPCI and
>>> not the real PCI hardware.
>>>=20
>>> For Dom0less systems scan_pci_devices() would be used to discover the
>>> PCI device in XEN and VPCI handler will be added during XEN boots.
>>>=20
>>> This patch is also doing some small fixes to fix compilation errors on
>>> arm32 of vpci:
>>> - add a cast to unsigned long in print in header.c
>>> - add a cast to uint64_t in vpci_ecam_mmio_write
>>>=20
>>> Signed-off-by: Rahul Singh <rahul.singh@arm.com>
>>> Signed-off-by: Bertrand Marquis <bertrand.marquis@arm.com>
>>> ---
>>> Changes in v6:
>>> - Use new vpci_ecam_ helpers for PCI access
>>> - Do not set XEN_DOMCTL_CDF_vpci for dom0 for now (will be done in a
>>> future patch once everything is ready)
>>=20
>> Isn't the series missing a revert of XEN_DOMCTL_CDF_vpci? I think
>> that's what we agreed would be the way forward.
>=20
> A separate reverse patch for that has already been merged:
> https://xenbits.xen.org/gitweb/?p=3Dxen.git;a=3Dcommit;h=3D9516d01ac3015f=
522528ed6dafb3f584eaa7ed2c
>=20
>>=20
>>> - rename REGISTER_OFFSET to ECAM_REG_OFFSET and move it to pci.h
>>> - remove not needed local variables in vpci_mmio_write, the one in read
>>> has been kept to ensure proper compilation on arm32
>>> - move call to vpci_add_handlers before iommu init to simplify exit pat=
h
>>> - move call to pci_cleanup_msi in the out section of pci_add_device if
>>> pdev is not NULL and on error
>>> - initialize pdev to NULL to handle properly exit path call of
>>> pci_cleanup_msi
>>> - keep has_vpci to return false for now as CFG_vpci has been removed.
>>> Added a comment on top of the definition.
>>> - fix compilation errors on arm32 (print in header.c, cast missing in
>>> mmio_write.
>>> - local variable was kept in vpci_mmio_read on arm to prevent a cast
>>> error in arm32.
>>> Change in v5:
>>> - Add pci_cleanup_msi(pdev) incleanup part.
>>> - Added Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
>>> Change in v4:
>>> - Move addition of XEN_DOMCTL_CDF_vpci flag to separate patch
>>> Change in v3:
>>> - Use is_pci_passthrough_enabled() in place of pci_passthrough_enabled =
variable
>>> - Reject XEN_DOMCTL_CDF_vpci for x86 in arch_sanitise_domain_config()
>>> - Remove IS_ENABLED(CONFIG_HAS_VPCI) from has_vpci()
>>> Change in v2:
>>> - Add new XEN_DOMCTL_CDF_vpci flag
>>> - modify has_vpci() to include XEN_DOMCTL_CDF_vpci
>>> - enable vpci support when pci-passthough option is enabled.
>>> ---
>>> ---
>>> xen/arch/arm/Makefile         |  1 +
>>> xen/arch/arm/domain.c         |  4 ++
>>> xen/arch/arm/vpci.c           | 74 +++++++++++++++++++++++++++++++++++
>>> xen/arch/arm/vpci.h           | 36 +++++++++++++++++
>>> xen/drivers/passthrough/pci.c | 18 ++++++++-
>>> xen/drivers/vpci/header.c     |  3 +-
>>> xen/drivers/vpci/vpci.c       |  2 +-
>>> xen/include/asm-arm/domain.h  |  1 +
>>> xen/include/asm-x86/pci.h     |  2 -
>>> xen/include/public/arch-arm.h |  7 ++++
>>> xen/include/xen/pci.h         |  3 ++
>>> 11 files changed, 146 insertions(+), 5 deletions(-)
>>> create mode 100644 xen/arch/arm/vpci.c
>>> create mode 100644 xen/arch/arm/vpci.h
>>>=20
>>> diff --git a/xen/arch/arm/Makefile b/xen/arch/arm/Makefile
>>> index 64518848b2..07f634508e 100644
>>> --- a/xen/arch/arm/Makefile
>>> +++ b/xen/arch/arm/Makefile
>>> @@ -7,6 +7,7 @@ ifneq ($(CONFIG_NO_PLAT),y)
>>> obj-y +=3D platforms/
>>> endif
>>> obj-$(CONFIG_TEE) +=3D tee/
>>> +obj-$(CONFIG_HAS_VPCI) +=3D vpci.o
>>>=20
>>> obj-$(CONFIG_HAS_ALTERNATIVE) +=3D alternative.o
>>> obj-y +=3D bootfdt.init.o
>>> diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
>>> index eef0661beb..96e1b23550 100644
>>> --- a/xen/arch/arm/domain.c
>>> +++ b/xen/arch/arm/domain.c
>>> @@ -39,6 +39,7 @@
>>> #include <asm/vgic.h>
>>> #include <asm/vtimer.h>
>>>=20
>>> +#include "vpci.h"
>>> #include "vuart.h"
>>>=20
>>> DEFINE_PER_CPU(struct vcpu *, curr_vcpu);
>>> @@ -773,6 +774,9 @@ int arch_domain_create(struct domain *d,
>>>    if ( is_hardware_domain(d) && (rc =3D domain_vuart_init(d)) )
>>>        goto fail;
>>>=20
>>> +    if ( (rc =3D domain_vpci_init(d)) !=3D 0 )
>>> +        goto fail;
>>> +
>>>    return 0;
>>>=20
>>> fail:
>>> diff --git a/xen/arch/arm/vpci.c b/xen/arch/arm/vpci.c
>>> new file mode 100644
>>> index 0000000000..7c3552b65d
>>> --- /dev/null
>>> +++ b/xen/arch/arm/vpci.c
>>> @@ -0,0 +1,74 @@
>>> +/*
>>> + * xen/arch/arm/vpci.c
>>> + *
>>> + * This program is free software; you can redistribute it and/or modif=
y
>>> + * it under the terms of the GNU General Public License as published b=
y
>>> + * the Free Software Foundation; either version 2 of the License, or
>>> + * (at your option) any later version.
>>> + *
>>> + * This program is distributed in the hope that it will be useful,
>>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
>>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>>> + * GNU General Public License for more details.
>>> + */
>>> +#include <xen/sched.h>
>>> +#include <xen/vpci.h>
>>> +
>>> +#include <asm/mmio.h>
>>> +
>>> +static int vpci_mmio_read(struct vcpu *v, mmio_info_t *info,
>>> +                          register_t *r, void *p)
>>> +{
>>> +    pci_sbdf_t sbdf;
>>> +    /* data is needed to prevent a pointer cast on 32bit */
>>> +    unsigned long data =3D ~0ul;
>>> +    int ret;
>>> +
>>> +    /* We ignore segment part and always handle segment 0 */
>>> +    sbdf.sbdf =3D ECAM_BDF(info->gpa);
>>> +
>>> +    ret =3D vpci_ecam_mmio_read(sbdf, ECAM_REG_OFFSET(info->gpa),
>>> +                              1U << info->dabt.size, &data);
>>> +
>>> +    *r =3D data;
>>> +
>>> +    return ret;
>>> +}
>>> +
>>> +static int vpci_mmio_write(struct vcpu *v, mmio_info_t *info,
>>> +                           register_t r, void *p)
>>> +{
>>> +    pci_sbdf_t sbdf;
>>> +
>>> +    /* We ignore segment part and always handle segment 0 */
>>> +    sbdf.sbdf =3D ECAM_BDF(info->gpa);
>>> +
>>> +    return vpci_ecam_mmio_write(sbdf, ECAM_REG_OFFSET(info->gpa),
>>> +                                1U << info->dabt.size, r);
>>> +}
>>=20
>> I'm not sure returning an error value here is helpful, as I'm not sure
>> how native Arm behaves and how this error is propagated into the
>> guest. FWIWreturning ~0 or dropping writes is what we do in x86 when
>> vPCI is not capable of handling the access.
>=20
> Mmio handlers can take a return code on arm if something did not work
> so I think this is the right way to do it on arm.
> Now has agreed with Jan, we will change the return type of=20
> vpci_ecam_write (also renamed) to be a boolean.
>=20
>>=20
>>> +
>>> +static const struct mmio_handler_ops vpci_mmio_handler =3D {
>>> +    .read  =3D vpci_mmio_read,
>>> +    .write =3D vpci_mmio_write,
>>> +};
>>> +
>>> +int domain_vpci_init(struct domain *d)
>>> +{
>>> +    if ( !has_vpci(d) )
>>> +        return 0;
>>> +
>>> +    register_mmio_handler(d, &vpci_mmio_handler,
>>> +                          GUEST_VPCI_ECAM_BASE, GUEST_VPCI_ECAM_SIZE, =
NULL);
>>> +
>>> +    return 0;
>>> +}
>>> +
>>> +/*
>>> + * Local variables:
>>> + * mode: C
>>> + * c-file-style: "BSD"
>>> + * c-basic-offset: 4
>>> + * indent-tabs-mode: nil
>>> + * End:
>>> + */
>>> +
>>> diff --git a/xen/arch/arm/vpci.h b/xen/arch/arm/vpci.h
>>> new file mode 100644
>>> index 0000000000..d8a7b0e3e8
>>> --- /dev/null
>>> +++ b/xen/arch/arm/vpci.h
>>> @@ -0,0 +1,36 @@
>>> +/*
>>> + * xen/arch/arm/vpci.h
>>> + *
>>> + * This program is free software; you can redistribute it and/or modif=
y
>>> + * it under the terms of the GNU General Public License as published b=
y
>>> + * the Free Software Foundation; either version 2 of the License, or
>>> + * (at your option) any later version.
>>> + *
>>> + * This program is distributed in the hope that it will be useful,
>>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
>>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>>> + * GNU General Public License for more details.
>>> + */
>>> +
>>> +#ifndef __ARCH_ARM_VPCI_H__
>>> +#define __ARCH_ARM_VPCI_H__
>>> +
>>> +#ifdef CONFIG_HAS_VPCI
>>> +int domain_vpci_init(struct domain *d);
>>> +#else
>>> +static inline int domain_vpci_init(struct domain *d)
>>> +{
>>> +    return 0;
>>> +}
>>> +#endif
>>> +
>>> +#endif /* __ARCH_ARM_VPCI_H__ */
>>> +
>>> +/*
>>> + * Local variables:
>>> + * mode: C
>>> + * c-file-style: "BSD"
>>> + * c-basic-offset: 4
>>> + * indent-tabs-mode: nil
>>> + * End:
>>> + */
>>> diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pc=
i.c
>>> index 3aa8c3175f..8cc529ecec 100644
>>> --- a/xen/drivers/passthrough/pci.c
>>> +++ b/xen/drivers/passthrough/pci.c
>>> @@ -658,7 +658,7 @@ int pci_add_device(u16 seg, u8 bus, u8 devfn,
>>>                   const struct pci_dev_info *info, nodeid_t node)
>>> {
>>>    struct pci_seg *pseg;
>>> -    struct pci_dev *pdev;
>>> +    struct pci_dev *pdev =3D NULL;
>>>    unsigned int slot =3D PCI_SLOT(devfn), func =3D PCI_FUNC(devfn);
>>>    const char *pdev_type;
>>>    int ret;
>>> @@ -752,6 +752,19 @@ int pci_add_device(u16 seg, u8 bus, u8 devfn,
>>>=20
>>>    check_pdev(pdev);
>>>=20
>>> +#ifdef CONFIG_ARM
>>> +    /*
>>> +     * On ARM PCI devices discovery will be done by Dom0. Add vpci han=
dler when
>>> +     * Dom0 inform XEN to add the PCI devices in XEN.
>>> +     */
>>> +    ret =3D vpci_add_handlers(pdev);
>>> +    if ( ret )
>>> +    {
>>> +        printk(XENLOG_ERR "Setup of vPCI failed: %d\n", ret);
>>> +        goto out;
>>> +    }
>>> +#endif
>>=20
>> I think vpci_add_handlers should be called after checking that
>> pdev->domain is !=3D NULL, so I would move this chunk a bit below.
>=20
> On arm this would prevent the dom0less use case or to have the PCI
> bus enumerated from an other domain.
> @oleksandr: can you comment on this one, you might have a better
> answer than me on this ?

For my understanding, as also Jan pointed out, this should be put inside th=
e
If ( !pdev->domain ) because also as the comment suggests, this operation
should be performed only when there is a Dom0 and when we are using
a dom0less setup the pdev->domain should be NULL if I=E2=80=99m not wrong.
@oleksandr maybe can confirm

>=20
>>=20
>>> +
>>>    ret =3D 0;
>>>    if ( !pdev->domain )
>>>    {
>>> @@ -784,6 +797,9 @@ out:
>>>                   &PCI_SBDF(seg, bus, slot, func));
>>>        }
>>>    }
>>> +    else if ( pdev )
>>> +        pci_cleanup_msi(pdev);
>>=20
>> I'm slightly lost at why you add this chunk, is this strictly related
>> to the patch?
>=20
> This was discussed a lot in previous version of the patch and
> requested by Stefano. The idea here is that as soon as handlers
> are added some bits might be modified in the PCI config space
> leading possibly to msi interrupts. So it is safer to cleanup on the
> error path. For references please see discussion on v4 and v5 where
> this was actually added (to much references as the discussion was
> long so here [1] and [2] are the patchwork thread).
>=20
> [1] https://patchwork.kernel.org/project/xen-devel/patch/9bdca2cda5d2e83f=
94dc2423e55714273539760a.1633540842.git.rahul.singh@arm.com/
> [2] https://patchwork.kernel.org/project/xen-devel/patch/f093de681c2560a7=
196895bcd666ef8840885c1d.1633340795.git.rahul.singh@arm.com/
>=20
> Regards
> Bertrand



From xen-devel-bounces@lists.xenproject.org Fri Oct 15 10:14:47 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 10:14:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.210177.366931 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbKEf-0008PI-RX; Fri, 15 Oct 2021 10:14:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 210177.366931; Fri, 15 Oct 2021 10:14:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbKEf-0008PB-Of; Fri, 15 Oct 2021 10:14:45 +0000
Received: by outflank-mailman (input) for mailman id 210177;
 Fri, 15 Oct 2021 10:14:44 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mbKEe-0008P3-KP
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 10:14:44 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mbKEe-0001NJ-It
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 10:14:44 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mbKEe-0003hP-Hy
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 10:14:44 +0000
Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89)
 (envelope-from <iwj@xenproject.org>)
 id 1mbKEJ-0005Kl-R4; Fri, 15 Oct 2021 11:14:23 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date
	:Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From;
	bh=H6pztpx/uFpPKE+XGY0rm2RF+c8Zb5Y4KFjJQfNb56Y=; b=agums+b5LVi4wtLwRP1Qr6Ea7t
	6WspI73DF0wk7oknqp+4ysEp3xitOVcaKOAcGEepU3OEPjiVjsiJ29W1GWVwTBjkFeGw3SgcmmVIh
	q8AkwvyH8zYJRHY4ss7OP0+39T0ZlVE5EuGJNHy9Z1XIVYkoxD1161aI4CKu5e7niFkA=;
From: Ian Jackson <iwj@xenproject.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <24937.21631.538303.29471@mariner.uk.xensource.com>
Date: Fri, 15 Oct 2021 11:14:23 +0100
To: Bertrand Marquis <Bertrand.Marquis@arm.com>
Cc: Jan Beulich <jbeulich@suse.com>,
    Roger Pau =?iso-8859-1?Q?Monn=E9?= <roger.pau@citrix.com>,
    "iwj\@xenproject.org" <iwj@xenproject.org>,
    Rahul Singh <Rahul.Singh@arm.com>,
    Stefano Stabellini <sstabellini@kernel.org>,
    Julien Grall <julien@xen.org>,
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
    Andrew Cooper <andrew.cooper3@citrix.com>,
    George Dunlap <george.dunlap@citrix.com>,
    Wei  Liu <wl@xen.org>,
    Paul Durrant <paul@xen.org>,
    "xen-devel\@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v6 2/3] xen/arm: Enable the existing x86 virtual PCI
 support for ARM.
In-Reply-To: <57A39480-34DF-4BF5-9B0E-802D30F94BBD@arm.com>
References: <cover.1634221830.git.bertrand.marquis@arm.com>
	<396b08e2598cf0338e0c7f4ad3cd5cb66db89224.1634221830.git.bertrand.marquis@arm.com>
	<f41f59f7-69ed-e2fe-dc17-434b456cf693@suse.com>
	<57A39480-34DF-4BF5-9B0E-802D30F94BBD@arm.com>
X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu)

Bertrand Marquis writes ("Re: [PATCH v6 2/3] xen/arm: Enable the existing x86 virtual PCI support for ARM."):
> > On 15 Oct 2021, at 09:00, Jan Beulich <jbeulich@suse.com> wrote:
> > The latter is fine to be put here (i.e. FTAOD I'm fine with it
> > staying here). For the former I even question its original placement
> > in asm-x86/pci.h: It's not generally correct as per the PCI spec, as
> > the bus portion of the address can be anywhere from 1 to 8 bits. And
> > in fact there is a reason why this macro was/is used in only a
> > single place, but not e.g. in x86'es handling of physical MCFG. It
> > is merely an implementation choice in vPCI that the entire segment 0
> > has a linear address range covering all 256 buses. Hence I think
> > this wants to move to xen/vpci.h and then perhaps also be named
> > VPCI_ECAM_BDF().
> 
> On previous version it was request to renamed this to ECAM and agreed
> to put is here. Now you want me to rename it to VPCI and move it again.
> I would like to have a confirmation that this is ok and the final move if possible.
> 
> @Roger can you confirm this is what is wanted ?

I think Roger is not available today I'm afraid.

Bertrand, can you give me a link to the comment from Roger ?
Assuming that it says what I think it will say:

I think the best thing to do will be to leave the name as it was in
the most recent version of your series.  I don't think it makes sense
to block this patch over a naming disagreement.  And it would be best
to minimise unnecessary churn.

I would be happy to release-ack a name change (perhaps proposed bo Jan
or Roger) supposing that that is the ultimate maintainer consensus.

Jan, would that approach be OK with you ?

Ian.


From xen-devel-bounces@lists.xenproject.org Fri Oct 15 10:15:00 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 10:15:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.210178.366943 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbKEu-0000Nq-3t; Fri, 15 Oct 2021 10:15:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 210178.366943; Fri, 15 Oct 2021 10:15:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbKEu-0000Nh-0S; Fri, 15 Oct 2021 10:15:00 +0000
Received: by outflank-mailman (input) for mailman id 210178;
 Fri, 15 Oct 2021 10:14:58 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=FGCa=PD=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mbKEs-0000Ms-OG
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 10:14:58 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id bf530068-2da0-11ec-822c-12813bfff9fa;
 Fri, 15 Oct 2021 10:14:57 +0000 (UTC)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2113.outbound.protection.outlook.com [104.47.17.113])
 (Using TLS) by relay.mimecast.com with ESMTP id
 de-mta-2-9fnRqoRDMb-vckerAqAXZw-1; Fri, 15 Oct 2021 12:14:55 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0401MB2608.eurprd04.prod.outlook.com (2603:10a6:800:4f::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15; Fri, 15 Oct
 2021 10:14:53 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.017; Fri, 15 Oct 2021
 10:14:53 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM5PR0402CA0020.eurprd04.prod.outlook.com (2603:10a6:203:90::30) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16 via Frontend
 Transport; Fri, 15 Oct 2021 10:14:52 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: bf530068-2da0-11ec-822c-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634292896;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=vU/UzPs96iEJe0gPDJyp3myE5nI9kPBtnBucX2HnWh4=;
	b=JJZa9BNL+1vbo4Nju9IMnqLc5sQzgByDggZu3kgU3/cfZwSmAsY3KbvUI8Jq7hyz7SMuiW
	V3EaptwSER7HQFL2wK40p1sYA1e1MtdSNYR2vlVTuNGnHqDTGC8NCk7kHdl3BHjP3JscPy
	h90mxeLcwt4r1Uf37CfgRTZTS4/lRf8=
X-MC-Unique: 9fnRqoRDMb-vckerAqAXZw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=hQcOgqxS7i430luD8UG1gSw3XvW+ke8Lq21MxFEcqsqyU+IDODkvKYAhx4EtxoCvAdkkhdJhghtvWbkUlC7AvV3U/Gt80CBm4Oad3k3R3IaTMh+OFFqmxUyHZjRTq9IgNaulOh4lRUMmSCUTGnA+5OSXkeLCAUa3zcn0xSFawulieEiDdBt80qwq1sPbyJg4ePHA0W+hK6Zr0UhNbPmQWawEQYDG2CH/fA5LYyL+CRPbrrqWfYXoIdnV4Asgpa7bjOTANWzkfuVeWB7zFAnj+csIKHZI4ACl8XI9WHvNz0E3pwB4S5uJg1iV9Im60FNM6NfhrfXZDcWunxbdfNsvIA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=UGochgLon9VsdOmajJGgaWQk2WlIGXRMlKdcLCdPRYE=;
 b=Lr47QeOLC3D1UJ6ef6G9kUI/wMI6nrnae7iMOLStEwIqSvKvaRHBPRVil02gGSbm0QLWZff7OOZhPjTj7JPEBCxUtsPpPVl8syR/A+WEINLeheoEfodaW3gcrr3X5eFLSBnFtUPPbFXZChnS2rtK2Is7Y0nJ5hJOVMpkR/i3Y3cpLE9KRfKzWnfucpjQN+706EDVgB02sJ1hlk0KjUQ5wvVu2+q0JSSgdTT8i+CS9VyXzmwztxrgt3LolrmTuVnV1VgDb5Hx6Ki1Q300yzak/j4fiSIcsXI65XE/Aj2xkMmuVWucki8UfpYMP34sZevL8l7K5hWzhoVZ5H+T3J9u9Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: xen.org; dkim=none (message not signed)
 header.d=none;xen.org; dmarc=none action=none header.from=suse.com;
Subject: Re: [PATCH v6 1/3] xen/vpci: Move ecam access functions to common
 code
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Bertrand Marquis <Bertrand.Marquis@arm.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>,
 "iwj@xenproject.org" <iwj@xenproject.org>, Paul Durrant <paul@xen.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
References: <cover.1634221830.git.bertrand.marquis@arm.com>
 <ced6f870dbfabcfe8584555cc80f9a37a0655a0c.1634221830.git.bertrand.marquis@arm.com>
 <YWkxT1bVmBT7Av43@MacBook-Air-de-Roger.local>
 <EB6EE7F3-80BD-4717-87C7-C54FAB0FD832@arm.com>
 <YWlPohYpgxs3gRlc@MacBook-Air-de-Roger.local>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <f115a820-e4ad-54a5-cbe6-9c5569745d7f@suse.com>
Date: Fri, 15 Oct 2021 12:14:51 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <YWlPohYpgxs3gRlc@MacBook-Air-de-Roger.local>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM5PR0402CA0020.eurprd04.prod.outlook.com
 (2603:10a6:203:90::30) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 01b8fa7d-9b93-4a9b-19a9-08d98fc4a170
X-MS-TrafficTypeDiagnostic: VI1PR0401MB2608:
X-Microsoft-Antispam-PRVS:
	<VI1PR0401MB2608572F425F4FB2F61394A3B3B99@VI1PR0401MB2608.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	OhIc3Lfa8Q5TYv1E/yqe0kFgCGucmpTMMp0edxzbisfcjbdb8oe9PBzpmXfEgtkA/W7RnRVjKjWLSYekR5YWK7zXpJasgo92yrvtgwGnL0G0xfGdLdLGUXwdlXTYbFdbn4IUfN3xr1gdPNOlyyOP+b2gazWTQQv9Ue9KrH5x7c7QEaAXCT4b41D5qCuU6APSwrc1gMr6/G2xNCJu9tpm2GqNPLzlQvqdT9C6kKBuF3lPxJx0HcMrjTFjWvioBearBoEHAGNa/mK1+dRQ2dFKwMNqpVhq4rMV/Js+C0SJxpuX0T0jrTqeHOWcYYs5G8eFBxlKMeBkBoS4PnZ60vrX2V6X5b7e4CQ/fP83RTux6ISCBIwFA0daD0qj4DMjW1/2gySLl3kY5ITSE1j1gont4atac3oW6WTD//a/0ddqml0uqttudzQ+fpTaOTRkJefAyBVH+2H8Bw9Gc5E71Doi9omH6TttQv3jeECGw/5OGDbH3LhXY2GYYz1X9Qaey9Gmx1wsuCTXq3lUQD3r+Kth19adrOxRCRoS+ezana3OgHT+OnbaaN8QuvGN/f8yhGoQIVUeO3YEuKm02quLeH7HirpKGIf2f0BxlsnmZS1CM/mbCEkuyAnuHhEUIGVmvZROk9H4oIqJiSJhK5OaDR0y8RQkSOVo9zKzm40X9eB80X1l3hyxi4EyxpTmmzdbJG9N+DZOCcdzql8eiuBRZp7J3mx2qxHpetv+tW8EtreYC7g=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(66476007)(4326008)(16576012)(86362001)(54906003)(316002)(31696002)(38100700002)(53546011)(66556008)(66946007)(110136005)(36756003)(83380400001)(508600001)(956004)(26005)(6486002)(5660300002)(2906002)(8676002)(8936002)(31686004)(186003)(2616005)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?GbR1t8rHETsTOz6rQp5VFbr49zic5GHvaIh2pET4p5nDW1NRKsg9Q7lzGzDV?=
 =?us-ascii?Q?FcAqqbR+ttPpdJRWVMQ/w867BrUhoFcblfY3aZyMSf6TzsQYpFIdIe5khmzh?=
 =?us-ascii?Q?unD1w5Ls9hm2DQd4pi7qRlHgTzXDPNSkDJkcpdgkb3ckefiUZqKh23M+wyoY?=
 =?us-ascii?Q?hE7B8QyFr0AFl1+5BNPcAJuCyN1iXKuJUnb2IxPrwmUNCxof40TCmQtS7dMt?=
 =?us-ascii?Q?4w2NB58jomZROwMX/S13/owgbygn0wGKkjWtQWwrX8vGhX5ZGVwHtHju8xtG?=
 =?us-ascii?Q?cue3g2OMzfX2II6i4UwpwL/YVU3dYwnJc+ywXGmuYP16sHcJOmt+dW8wjBvx?=
 =?us-ascii?Q?w5drFv+GgtccLXKJRCIWsI+d7J+Sfh4q0n9wni4Z6KRR38TiiCiW+7TbqCdp?=
 =?us-ascii?Q?Yp+2WzNnOt6Hl1dFq8OHa0rB8rgo/Jx5bQH+4OA1+4hYGu64+G1PgyRZ1iOX?=
 =?us-ascii?Q?oDcmWVfyCGAiNYIgt2t1xZvf8r81G4FrCPi1anO3ULJFj6Y1mvOgWlY+Qlh9?=
 =?us-ascii?Q?uQi5InlL2Z6Yf/dR2hKr572AhVVV14t1xilR1374cHnnYFBfcr7THnLHTCS4?=
 =?us-ascii?Q?ZIns7E2pmGVdckeSMVoo9gOmNYoZnXvvSMz/2PlG0/EwCvn8aqoRri6dLi7P?=
 =?us-ascii?Q?hKQaLpYynWtx1YTgPpQLiG6GAMB3BeSif8kEu4mu0r/f31vCeX8AgVZ7FLL0?=
 =?us-ascii?Q?ptA+/xxODYUBH6jzXUkfp5Wq5hWEzwMHHv3bKbivt6+BHe/xMwz2hofREmUU?=
 =?us-ascii?Q?FPZiGUGpBY6AZtysvnVZHZ0GvnOilkdQ9nbAFErMpPCCYzdOaMa2aySmQDHg?=
 =?us-ascii?Q?IiNKEJUzjmd8TTB2uHwwKDg1iZdEoepS9oTUO79OHB7Zfy0x240oPvQL/ve2?=
 =?us-ascii?Q?Ws/8afuVyWsFrRkDoHGDEQmnfUaJPmA2oxIVV5pzJy4A+2tzQ+Q3yfMh5Okd?=
 =?us-ascii?Q?D0z8/yF912hloGDvdPaqrSsYedwFwhscXtyx0KqllRttUrVnr8xbvfkCzunS?=
 =?us-ascii?Q?gaNbFyRYo2Nl7G0LNG3/41QBS/pHqbHKgY2RxScREkKLSBXBKe3z1YmQNGTq?=
 =?us-ascii?Q?V2p7JHDRPLDvWSsf3DxQcEuFXWDMwHCZAroPGCpxi+CIdfOCO/04wEWnw4xi?=
 =?us-ascii?Q?LI5Ho9ne38DnNOHbmVWFkcEXOIlK66w3DNc+GZxgi6wHgR5eSou2Y3gVBt1f?=
 =?us-ascii?Q?Mn5TgkazFfPfgZYMn+empUovytGv8TnKQh76kMxCT4A4jnkT3lkRYhQZV+Uf?=
 =?us-ascii?Q?1MMCzxnAo//ylsNPBwuaDSXRRopPODE3rsiYMzZ4esSJxjsC2Z/maze8nD6+?=
 =?us-ascii?Q?77zMNg1uHTc7fX7SSa/DIf4Q?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 01b8fa7d-9b93-4a9b-19a9-08d98fc4a170
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2021 10:14:53.5145
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4Wi8gPOa+8i2ZCJnxWUsui3rZFn+1GucdSCLVJcaicBZC2X3w7JtI6arW2/bMe0UFxmf+uucSU33iB33Wlleng==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2608

On 15.10.2021 11:53, Roger Pau Monn=C3=A9 wrote:
> On Fri, Oct 15, 2021 at 07:53:38AM +0000, Bertrand Marquis wrote:
>>> On 15 Oct 2021, at 08:44, Roger Pau Monn=C3=A9 <roger.pau@citrix.com> w=
rote:
>>> On Thu, Oct 14, 2021 at 03:49:49PM +0100, Bertrand Marquis wrote:
>>>> @@ -434,25 +420,8 @@ static int vpci_mmcfg_read(struct vcpu *v, unsign=
ed long addr,
>>>>     reg =3D vpci_mmcfg_decode_addr(mmcfg, addr, &sbdf);
>>>>     read_unlock(&d->arch.hvm.mmcfg_lock);
>>>>
>>>> -    if ( !vpci_access_allowed(reg, len) ||
>>>> -         (reg + len) > PCI_CFG_SPACE_EXP_SIZE )
>>>> -        return X86EMUL_OKAY;
>>>> -
>>>> -    /*
>>>> -     * According to the PCIe 3.1A specification:
>>>> -     *  - Configuration Reads and Writes must usually be DWORD or sma=
ller
>>>> -     *    in size.
>>>> -     *  - Because Root Complex implementations are not required to su=
pport
>>>> -     *    accesses to a RCRB that cross DW boundaries [...] software
>>>> -     *    should take care not to cause the generation of such access=
es
>>>> -     *    when accessing a RCRB unless the Root Complex will support =
the
>>>> -     *    access.
>>>> -     *  Xen however supports 8byte accesses by splitting them into tw=
o
>>>> -     *  4byte accesses.
>>>> -     */
>>>> -    *data =3D vpci_read(sbdf, reg, min(4u, len));
>>>> -    if ( len =3D=3D 8 )
>>>> -        *data |=3D (uint64_t)vpci_read(sbdf, reg + 4, 4) << 32;
>>>> +    /* Ignore return code */
>>>> +    vpci_ecam_mmio_read(sbdf, reg, len, data);
>>>
>>> I think it would be better for vpci_ecam_mmio_read to just return the
>>> read value, or ~0 in case of error, at least that interface would be
>>> simpler and suitable for x86.
>>
>> I am not quite sure on this as on absolute to read ~0 is possible so the
>> caller cannot distinguish between properly reading ~0 or an access allow=
ed error.
>=20
> How do you report an access allowed error on Arm for the PCI config
> space?
>=20
> At least on x86 I don't think we currently have a way to propagate
> such errors, neither a plan to do so that I'm aware.

I have to admit I can't even think of how such a plan could look like,
give x86'es history.

Jan



From xen-devel-bounces@lists.xenproject.org Fri Oct 15 10:17:37 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 10:17:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.210192.366954 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbKHO-0001Fx-Hg; Fri, 15 Oct 2021 10:17:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 210192.366954; Fri, 15 Oct 2021 10:17:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbKHO-0001Fq-Ea; Fri, 15 Oct 2021 10:17:34 +0000
Received: by outflank-mailman (input) for mailman id 210192;
 Fri, 15 Oct 2021 10:17:33 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Fqmt=PD=arm.com=Bertrand.Marquis@srs-us1.protection.inumbo.net>)
 id 1mbKHN-0001Fk-6s
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 10:17:33 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com (unknown
 [2a01:111:f400:7d00::629])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 2b72da8e-ee9a-4d14-a64d-089365aa0a6d;
 Fri, 15 Oct 2021 10:17:32 +0000 (UTC)
Received: from AM6P195CA0002.EURP195.PROD.OUTLOOK.COM (2603:10a6:209:81::15)
 by AS8PR08MB6406.eurprd08.prod.outlook.com (2603:10a6:20b:33c::23) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16; Fri, 15 Oct
 2021 10:17:28 +0000
Received: from VE1EUR03FT058.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:209:81:cafe::11) by AM6P195CA0002.outlook.office365.com
 (2603:10a6:209:81::15) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.14 via Frontend
 Transport; Fri, 15 Oct 2021 10:17:28 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT058.mail.protection.outlook.com (10.152.19.86) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.15 via Frontend Transport; Fri, 15 Oct 2021 10:17:28 +0000
Received: ("Tessian outbound 8e26f7114b75:v103");
 Fri, 15 Oct 2021 10:17:28 +0000
Received: from 219db27a419f.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 752CC1BA-F8B4-4D93-8815-AAC0B770015C.1; 
 Fri, 15 Oct 2021 10:17:21 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 219db27a419f.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 15 Oct 2021 10:17:21 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com (2603:10a6:4:74::9)
 by DB6PR0802MB2582.eurprd08.prod.outlook.com (2603:10a6:4:a2::11) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.22; Fri, 15 Oct
 2021 10:17:12 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955]) by DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955%4]) with mapi id 15.20.4587.031; Fri, 15 Oct 2021
 10:17:12 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2b72da8e-ee9a-4d14-a64d-089365aa0a6d
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=9IDpuw3OjAhQxHI03lo0s2VOkWaMOsvZOynfCG5fr7Y=;
 b=fNF45QCO+DnSN2lwG/aYb3wYEFGmqH1DyneL+sZijCIGM2ntrj8Zf2Ylc7zkJw6enXXSQNgl87h/M8yqJdAOCWUVrGc6LCHfZpcdR0lagYZJc3nopJIeyrvGdJ+MnYww9CP+uwqRCGAz4hskz2VMNQiGjKgyRzn8M/evQlLE1KI=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 41c19d1eff1c9fe9
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Lo8YvacQyoVLsWO0C6SbO7fFU3rHQk5BRF6YXfgOiQ0KFgGN9twV61FD1K9NWaBpS+yIGrPm195op8IttNDEIdRTWHqChiq78FBJjTaNDJarDL+gVScPgd6C3pRnGdTBw2DIFZQDcHvdiqnZQ6frkZesq5qBMK4GmeAwnIvI+/YYkIM3FAiBq+69KxGGNhjO/EIvSe2gXVeewf4p9ESQXO7M2OBj/YPK6XX3p2wX+3ig+Xi+w+AGPiq72jz+J6LrixyRUUyrjx4xq/zilHB8yK9Z53QVQmQ3VFAywSh2HBMzkyo/v7twm+G6wgv2DAKnRGYZ5NMU8brRkRJdApHzQw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=9IDpuw3OjAhQxHI03lo0s2VOkWaMOsvZOynfCG5fr7Y=;
 b=U3KjNBVqRRtp3aRsRjq4YjlG9TXeTGA6T995IyhjsBhH5SXts7EiZOiamB5hAidgENz74ZREFdugfuK14edInJ7skDz8u+ZXuPlBZS3gNJF2FHseZaAks5Wo29u9XkGSjP7MbzOYVC5d3qQcSI4pYuJAH8EuhZo9dEAfbW/MTrzaSIxUG9zSgNYBcZoLlF2P3u74d5RJrTMofHIePXvpWhK956TnmJKD0WmOg9k/Z3dmEE9uj75KeeYbDkbKMlq5HyiPjmI1p1dTIPXt8KhEVinr8SJNQQmmr6fSVOtb6fHJJOzWKgdTsh9UKe8xcg5kGj1a8Do5Frd+e0W2PJKG3g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=9IDpuw3OjAhQxHI03lo0s2VOkWaMOsvZOynfCG5fr7Y=;
 b=fNF45QCO+DnSN2lwG/aYb3wYEFGmqH1DyneL+sZijCIGM2ntrj8Zf2Ylc7zkJw6enXXSQNgl87h/M8yqJdAOCWUVrGc6LCHfZpcdR0lagYZJc3nopJIeyrvGdJ+MnYww9CP+uwqRCGAz4hskz2VMNQiGjKgyRzn8M/evQlLE1KI=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Luca Fancellu <Luca.Fancellu@arm.com>
CC: =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>, Xen-devel
	<xen-devel@lists.xenproject.org>, Ian Jackson <iwj@xenproject.org>, Rahul
 Singh <Rahul.Singh@arm.com>, Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
	Wei Liu <wl@xen.org>, Paul Durrant <paul@xen.org>, Oleksandr Andrushchenko
	<Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH v6 2/3] xen/arm: Enable the existing x86 virtual PCI
 support for ARM.
Thread-Topic: [PATCH v6 2/3] xen/arm: Enable the existing x86 virtual PCI
 support for ARM.
Thread-Index: AQHXwQrjS6mPrKT7Q06z3N66FcsDAKvTvGsAgAAWOICAAAXNgIAAAR0A
Date: Fri, 15 Oct 2021 10:17:12 +0000
Message-ID: <B67603A1-A4B0-4D7D-9787-4DA7050336D2@arm.com>
References: <cover.1634221830.git.bertrand.marquis@arm.com>
 <396b08e2598cf0338e0c7f4ad3cd5cb66db89224.1634221830.git.bertrand.marquis@arm.com>
 <YWk8uP/YuSee1MfG@MacBook-Air-de-Roger.local>
 <CD9B29B0-31FD-4E09-93E3-7124C724BC23@arm.com>
 <E80D6A5A-2556-49C4-A9F0-E85CCD44D1A8@arm.com>
In-Reply-To: <E80D6A5A-2556-49C4-A9F0-E85CCD44D1A8@arm.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3654.120.0.1.13)
Authentication-Results-Original: arm.com; dkim=none (message not signed)
 header.d=none;arm.com; dmarc=none action=none header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: 450ee358-9beb-4c50-9920-08d98fc4fde9
x-ms-traffictypediagnostic: DB6PR0802MB2582:|AS8PR08MB6406:
x-ms-exchange-transport-forked: True
X-Microsoft-Antispam-PRVS:
	<AS8PR08MB6406EDDB4C6634F15EC30A4D9DB99@AS8PR08MB6406.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:10000;OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 ve3+rCP+bjJNZvK9bq5/BdbSpMhh3mTEs6R48F7W9pdfrpDDGpqmYIvtF4YaZjHitZgfYxIRToBPV4uo+saBLYaUmsX28CnLvvbKTPXXvcQTv7kNUDGj9Hf8XsDpVIKj1WmuO1MuR56Lr/roV14fDGEY5Cj7UECfFnCQV2YyQ5+55k/nFitvVz89S9/PWKJoqTGEx3n87nyveL2gStqNC8p7ugLhY1lyzEx69M93ZHeNSYw1Xq44b9wV3TehYAn9QZ59na/517hybrw2IntaBN8Mx0G7b6WspG/dgm4SrcRi3J2cl/jdF5AM+uqjycuhFdKhCSKlifhd3+NZN+/j4Xt9vOcgkrZvbu9hBRK8sItSSyxHLP8dWM9OgM6GQln/hnB27uq9fA4y8CjHqpGezMup/lc9i/wGdcMO51X3UQYRL0tQ73gSTfe/MOXpPeCX9k5UqK9y4SLcGPtYndkf0P9mOoOWofcANhrm/BFFXuJyCfA7I4Wdmj42dBTVE9U1xwMTMVU3YiBKlD67je8oRNFFuAAKcQtKSD5fQG/lKR18g3CebFIR4vkw8envlvSo3Vufi77W1KelMVDCIWDKEXt9g+g2ahrGMJsKZ7+JaWyPPWSO2tWpS1UEGT5yMs5dd3tBFQ3z5tDqHmhOMgewB3t9X21IRDsB60vGXAZGc41CvbkqDDvkDR7WKi59CxDbrx4gm4Alb6yneInZxnNH4eSmt2U1LGnMnJtoj7S3gMBjRYoGvtrx2vYUZeY2nHdqrmgbIVCk1NttweXZteN+aWCNf0OziPorsHc8rJzFJQ/vxZiXaEuYU/90NrCPfcv737+1j/+z+OLZnY3f9OBtpGehJQnq8s29HxVOJtb7GE65Fn9H9pHKJiWGg2zPE8qAdOgga5l1VUwIOBwkDcl05g==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB6PR0801MB2024.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(66556008)(64756008)(66476007)(76116006)(86362001)(2616005)(91956017)(66946007)(66446008)(54906003)(6512007)(30864003)(8936002)(6486002)(4326008)(6636002)(5660300002)(316002)(8676002)(26005)(7416002)(2906002)(71200400001)(37006003)(38070700005)(6506007)(33656002)(36756003)(38100700002)(122000001)(6862004)(83380400001)(966005)(53546011)(508600001)(186003)(2004002)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-ID: <CDF68956091EF247BB921AE021054991@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0802MB2582
Original-Authentication-Results: arm.com; dkim=none (message not signed)
 header.d=none;arm.com; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT058.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	09d96d9f-c879-4a90-2ff8-08d98fc4f469
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	U8M6vfI1kr7Matxy2Vt5s4osLpvSljeMiD7B9eTHPzEf0ICuck/2MROqrtENAU/rM8bAXC4FMMjWViRzlrmUYW24YiVgMFwC+Kmi0I7yhW7mE0MF9EE/Vka9vmdw/j3Mj6udj6L0yGi/Rh3BBrN8xFbWiXbozAXX8VHjjVp/ihd/lqU2B3WKgogDa0U1u58Wkj1u8ZZoPxJodLG1poRgcOpG4/xaafvfZdpfzX0nTVzLTw4pXL+ZxIswfHEo06BeF5Yjx+mkR2Xcd5bCMJB0Y7u8n2yiIafF3PlomkSyVB/OJWBFYuwrIsLKCUNlNav7xGzPGA5+tTg62BhoV8FCCzuQpTARKcwTSmBxfVfVQgdZhv66qPukJ7cVbI2yLTD63asetSb/TsJslFna77i0W1osMF92d5yta61i3PhRJ7SMPWT9bsENAK6FRXWj8RaS8e516z1AvVY0rLscdDMvJ3ep4sCgJHbBXdwHmIEn6APfCkI1OgC+2nNXRJMkkyNWBeYqkcmlRJM7fxFVJNLThmoi00cWEF6FU/qie4fsprhxAyYNpWqflNAgBfeImK+NnYFX7znlk03WQkxBqycC0DlTzkAPIj9quq4J2inYXgjA01AP3j7CZvp1qhgrbaJ7pceo+E96vnTsETZ6tI6PXTIb0kbGXgjzquv1fg5WKM76MIrJHLV4CQ4k6guFhfkSjBJnBasIXzyAw+7lamPS9y4ZI1vZHTpGmufkJV3FwqGvKMtuoSsIWPREQLvW3muzvR/8Hci3czz3Ru4ywZUsFZfBqPyLhs7uLmpuJBvgyGPFlTFGoZ27iR/B8W8MWB8pWeMlbicVbJt2Ny/JbnM81X9WqAP21UpRBnvW5NLQ0aI=
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(36860700001)(53546011)(8676002)(70206006)(70586007)(6636002)(33656002)(8936002)(26005)(37006003)(316002)(54906003)(356005)(4326008)(30864003)(186003)(83380400001)(6506007)(508600001)(86362001)(81166007)(2616005)(6486002)(6862004)(36756003)(2906002)(966005)(6512007)(5660300002)(82310400003)(107886003)(47076005)(336012)(2004002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2021 10:17:28.4573
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 450ee358-9beb-4c50-9920-08d98fc4fde9
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT058.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6406

SGkgTHVjYSwNCg0KPiBPbiAxNSBPY3QgMjAyMSwgYXQgMTE6MTMsIEx1Y2EgRmFuY2VsbHUgPEx1
Y2EuRmFuY2VsbHVAYXJtLmNvbT4gd3JvdGU6DQo+IA0KPiANCj4gDQo+PiBPbiAxNSBPY3QgMjAy
MSwgYXQgMTA6NTIsIEJlcnRyYW5kIE1hcnF1aXMgPEJlcnRyYW5kLk1hcnF1aXNAYXJtLmNvbT4g
d3JvdGU6DQo+PiANCj4+IEhpIFJvZ2VyLA0KPj4gDQo+Pj4gT24gMTUgT2N0IDIwMjEsIGF0IDA5
OjMyLCBSb2dlciBQYXUgTW9ubsOpIDxyb2dlci5wYXVAY2l0cml4LmNvbT4gd3JvdGU6DQo+Pj4g
DQo+Pj4gT24gVGh1LCBPY3QgMTQsIDIwMjEgYXQgMDM6NDk6NTBQTSArMDEwMCwgQmVydHJhbmQg
TWFycXVpcyB3cm90ZToNCj4+Pj4gRnJvbTogUmFodWwgU2luZ2ggPHJhaHVsLnNpbmdoQGFybS5j
b20+DQo+Pj4+IA0KPj4+PiBUaGUgZXhpc3RpbmcgVlBDSSBzdXBwb3J0IGF2YWlsYWJsZSBmb3Ig
WDg2IGlzIGFkYXB0ZWQgZm9yIEFybS4NCj4+Pj4gV2hlbiB0aGUgZGV2aWNlIGlzIGFkZGVkIHRv
IFhFTiB2aWEgdGhlIGh5cGVyIGNhbGwNCj4+Pj4g4oCcUEhZU0RFVk9QX3BjaV9kZXZpY2VfYWRk
4oCdLCBWUENJIGhhbmRsZXIgZm9yIHRoZSBjb25maWcgc3BhY2UNCj4+Pj4gYWNjZXNzIGlzIGFk
ZGVkIHRvIHRoZSBYZW4gdG8gZW11bGF0ZSB0aGUgUENJIGRldmljZXMgY29uZmlnIHNwYWNlLg0K
Pj4+PiANCj4+Pj4gQSBNTUlPIHRyYXAgaGFuZGxlciBmb3IgdGhlIFBDSSBFQ0FNIHNwYWNlIGlz
IHJlZ2lzdGVyZWQgaW4gWEVODQo+Pj4+IHNvIHRoYXQgd2hlbiBndWVzdCBpcyB0cnlpbmcgdG8g
YWNjZXNzIHRoZSBQQ0kgY29uZmlnIHNwYWNlLFhFTg0KPj4+PiB3aWxsIHRyYXAgdGhlIGFjY2Vz
cyBhbmQgZW11bGF0ZSByZWFkL3dyaXRlIHVzaW5nIHRoZSBWUENJIGFuZA0KPj4+PiBub3QgdGhl
IHJlYWwgUENJIGhhcmR3YXJlLg0KPj4+PiANCj4+Pj4gRm9yIERvbTBsZXNzIHN5c3RlbXMgc2Nh
bl9wY2lfZGV2aWNlcygpIHdvdWxkIGJlIHVzZWQgdG8gZGlzY292ZXIgdGhlDQo+Pj4+IFBDSSBk
ZXZpY2UgaW4gWEVOIGFuZCBWUENJIGhhbmRsZXIgd2lsbCBiZSBhZGRlZCBkdXJpbmcgWEVOIGJv
b3RzLg0KPj4+PiANCj4+Pj4gVGhpcyBwYXRjaCBpcyBhbHNvIGRvaW5nIHNvbWUgc21hbGwgZml4
ZXMgdG8gZml4IGNvbXBpbGF0aW9uIGVycm9ycyBvbg0KPj4+PiBhcm0zMiBvZiB2cGNpOg0KPj4+
PiAtIGFkZCBhIGNhc3QgdG8gdW5zaWduZWQgbG9uZyBpbiBwcmludCBpbiBoZWFkZXIuYw0KPj4+
PiAtIGFkZCBhIGNhc3QgdG8gdWludDY0X3QgaW4gdnBjaV9lY2FtX21taW9fd3JpdGUNCj4+Pj4g
DQo+Pj4+IFNpZ25lZC1vZmYtYnk6IFJhaHVsIFNpbmdoIDxyYWh1bC5zaW5naEBhcm0uY29tPg0K
Pj4+PiBTaWduZWQtb2ZmLWJ5OiBCZXJ0cmFuZCBNYXJxdWlzIDxiZXJ0cmFuZC5tYXJxdWlzQGFy
bS5jb20+DQo+Pj4+IC0tLQ0KPj4+PiBDaGFuZ2VzIGluIHY2Og0KPj4+PiAtIFVzZSBuZXcgdnBj
aV9lY2FtXyBoZWxwZXJzIGZvciBQQ0kgYWNjZXNzDQo+Pj4+IC0gRG8gbm90IHNldCBYRU5fRE9N
Q1RMX0NERl92cGNpIGZvciBkb20wIGZvciBub3cgKHdpbGwgYmUgZG9uZSBpbiBhDQo+Pj4+IGZ1
dHVyZSBwYXRjaCBvbmNlIGV2ZXJ5dGhpbmcgaXMgcmVhZHkpDQo+Pj4gDQo+Pj4gSXNuJ3QgdGhl
IHNlcmllcyBtaXNzaW5nIGEgcmV2ZXJ0IG9mIFhFTl9ET01DVExfQ0RGX3ZwY2k/IEkgdGhpbmsN
Cj4+PiB0aGF0J3Mgd2hhdCB3ZSBhZ3JlZWQgd291bGQgYmUgdGhlIHdheSBmb3J3YXJkLg0KPj4g
DQo+PiBBIHNlcGFyYXRlIHJldmVyc2UgcGF0Y2ggZm9yIHRoYXQgaGFzIGFscmVhZHkgYmVlbiBt
ZXJnZWQ6DQo+PiBodHRwczovL3hlbmJpdHMueGVuLm9yZy9naXR3ZWIvP3A9eGVuLmdpdDthPWNv
bW1pdDtoPTk1MTZkMDFhYzMwMTVmNTIyNTI4ZWQ2ZGFmYjNmNTg0ZWFhN2VkMmMNCj4+IA0KPj4+
IA0KPj4+PiAtIHJlbmFtZSBSRUdJU1RFUl9PRkZTRVQgdG8gRUNBTV9SRUdfT0ZGU0VUIGFuZCBt
b3ZlIGl0IHRvIHBjaS5oDQo+Pj4+IC0gcmVtb3ZlIG5vdCBuZWVkZWQgbG9jYWwgdmFyaWFibGVz
IGluIHZwY2lfbW1pb193cml0ZSwgdGhlIG9uZSBpbiByZWFkDQo+Pj4+IGhhcyBiZWVuIGtlcHQg
dG8gZW5zdXJlIHByb3BlciBjb21waWxhdGlvbiBvbiBhcm0zMg0KPj4+PiAtIG1vdmUgY2FsbCB0
byB2cGNpX2FkZF9oYW5kbGVycyBiZWZvcmUgaW9tbXUgaW5pdCB0byBzaW1wbGlmeSBleGl0IHBh
dGgNCj4+Pj4gLSBtb3ZlIGNhbGwgdG8gcGNpX2NsZWFudXBfbXNpIGluIHRoZSBvdXQgc2VjdGlv
biBvZiBwY2lfYWRkX2RldmljZSBpZg0KPj4+PiBwZGV2IGlzIG5vdCBOVUxMIGFuZCBvbiBlcnJv
cg0KPj4+PiAtIGluaXRpYWxpemUgcGRldiB0byBOVUxMIHRvIGhhbmRsZSBwcm9wZXJseSBleGl0
IHBhdGggY2FsbCBvZg0KPj4+PiBwY2lfY2xlYW51cF9tc2kNCj4+Pj4gLSBrZWVwIGhhc192cGNp
IHRvIHJldHVybiBmYWxzZSBmb3Igbm93IGFzIENGR192cGNpIGhhcyBiZWVuIHJlbW92ZWQuDQo+
Pj4+IEFkZGVkIGEgY29tbWVudCBvbiB0b3Agb2YgdGhlIGRlZmluaXRpb24uDQo+Pj4+IC0gZml4
IGNvbXBpbGF0aW9uIGVycm9ycyBvbiBhcm0zMiAocHJpbnQgaW4gaGVhZGVyLmMsIGNhc3QgbWlz
c2luZyBpbg0KPj4+PiBtbWlvX3dyaXRlLg0KPj4+PiAtIGxvY2FsIHZhcmlhYmxlIHdhcyBrZXB0
IGluIHZwY2lfbW1pb19yZWFkIG9uIGFybSB0byBwcmV2ZW50IGEgY2FzdA0KPj4+PiBlcnJvciBp
biBhcm0zMi4NCj4+Pj4gQ2hhbmdlIGluIHY1Og0KPj4+PiAtIEFkZCBwY2lfY2xlYW51cF9tc2ko
cGRldikgaW5jbGVhbnVwIHBhcnQuDQo+Pj4+IC0gQWRkZWQgUmV2aWV3ZWQtYnk6IFN0ZWZhbm8g
U3RhYmVsbGluaSA8c3N0YWJlbGxpbmlAa2VybmVsLm9yZz4NCj4+Pj4gQ2hhbmdlIGluIHY0Og0K
Pj4+PiAtIE1vdmUgYWRkaXRpb24gb2YgWEVOX0RPTUNUTF9DREZfdnBjaSBmbGFnIHRvIHNlcGFy
YXRlIHBhdGNoDQo+Pj4+IENoYW5nZSBpbiB2MzoNCj4+Pj4gLSBVc2UgaXNfcGNpX3Bhc3N0aHJv
dWdoX2VuYWJsZWQoKSBpbiBwbGFjZSBvZiBwY2lfcGFzc3Rocm91Z2hfZW5hYmxlZCB2YXJpYWJs
ZQ0KPj4+PiAtIFJlamVjdCBYRU5fRE9NQ1RMX0NERl92cGNpIGZvciB4ODYgaW4gYXJjaF9zYW5p
dGlzZV9kb21haW5fY29uZmlnKCkNCj4+Pj4gLSBSZW1vdmUgSVNfRU5BQkxFRChDT05GSUdfSEFT
X1ZQQ0kpIGZyb20gaGFzX3ZwY2koKQ0KPj4+PiBDaGFuZ2UgaW4gdjI6DQo+Pj4+IC0gQWRkIG5l
dyBYRU5fRE9NQ1RMX0NERl92cGNpIGZsYWcNCj4+Pj4gLSBtb2RpZnkgaGFzX3ZwY2koKSB0byBp
bmNsdWRlIFhFTl9ET01DVExfQ0RGX3ZwY2kNCj4+Pj4gLSBlbmFibGUgdnBjaSBzdXBwb3J0IHdo
ZW4gcGNpLXBhc3N0aG91Z2ggb3B0aW9uIGlzIGVuYWJsZWQuDQo+Pj4+IC0tLQ0KPj4+PiAtLS0N
Cj4+Pj4geGVuL2FyY2gvYXJtL01ha2VmaWxlICAgICAgICAgfCAgMSArDQo+Pj4+IHhlbi9hcmNo
L2FybS9kb21haW4uYyAgICAgICAgIHwgIDQgKysNCj4+Pj4geGVuL2FyY2gvYXJtL3ZwY2kuYyAg
ICAgICAgICAgfCA3NCArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKw0KPj4+PiB4
ZW4vYXJjaC9hcm0vdnBjaS5oICAgICAgICAgICB8IDM2ICsrKysrKysrKysrKysrKysrDQo+Pj4+
IHhlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL3BjaS5jIHwgMTggKysrKysrKystDQo+Pj4+IHhlbi9k
cml2ZXJzL3ZwY2kvaGVhZGVyLmMgICAgIHwgIDMgKy0NCj4+Pj4geGVuL2RyaXZlcnMvdnBjaS92
cGNpLmMgICAgICAgfCAgMiArLQ0KPj4+PiB4ZW4vaW5jbHVkZS9hc20tYXJtL2RvbWFpbi5oICB8
ICAxICsNCj4+Pj4geGVuL2luY2x1ZGUvYXNtLXg4Ni9wY2kuaCAgICAgfCAgMiAtDQo+Pj4+IHhl
bi9pbmNsdWRlL3B1YmxpYy9hcmNoLWFybS5oIHwgIDcgKysrKw0KPj4+PiB4ZW4vaW5jbHVkZS94
ZW4vcGNpLmggICAgICAgICB8ICAzICsrDQo+Pj4+IDExIGZpbGVzIGNoYW5nZWQsIDE0NiBpbnNl
cnRpb25zKCspLCA1IGRlbGV0aW9ucygtKQ0KPj4+PiBjcmVhdGUgbW9kZSAxMDA2NDQgeGVuL2Fy
Y2gvYXJtL3ZwY2kuYw0KPj4+PiBjcmVhdGUgbW9kZSAxMDA2NDQgeGVuL2FyY2gvYXJtL3ZwY2ku
aA0KPj4+PiANCj4+Pj4gZGlmZiAtLWdpdCBhL3hlbi9hcmNoL2FybS9NYWtlZmlsZSBiL3hlbi9h
cmNoL2FybS9NYWtlZmlsZQ0KPj4+PiBpbmRleCA2NDUxODg0OGIyLi4wN2Y2MzQ1MDhlIDEwMDY0
NA0KPj4+PiAtLS0gYS94ZW4vYXJjaC9hcm0vTWFrZWZpbGUNCj4+Pj4gKysrIGIveGVuL2FyY2gv
YXJtL01ha2VmaWxlDQo+Pj4+IEBAIC03LDYgKzcsNyBAQCBpZm5lcSAoJChDT05GSUdfTk9fUExB
VCkseSkNCj4+Pj4gb2JqLXkgKz0gcGxhdGZvcm1zLw0KPj4+PiBlbmRpZg0KPj4+PiBvYmotJChD
T05GSUdfVEVFKSArPSB0ZWUvDQo+Pj4+ICtvYmotJChDT05GSUdfSEFTX1ZQQ0kpICs9IHZwY2ku
bw0KPj4+PiANCj4+Pj4gb2JqLSQoQ09ORklHX0hBU19BTFRFUk5BVElWRSkgKz0gYWx0ZXJuYXRp
dmUubw0KPj4+PiBvYmoteSArPSBib290ZmR0LmluaXQubw0KPj4+PiBkaWZmIC0tZ2l0IGEveGVu
L2FyY2gvYXJtL2RvbWFpbi5jIGIveGVuL2FyY2gvYXJtL2RvbWFpbi5jDQo+Pj4+IGluZGV4IGVl
ZjA2NjFiZWIuLjk2ZTFiMjM1NTAgMTAwNjQ0DQo+Pj4+IC0tLSBhL3hlbi9hcmNoL2FybS9kb21h
aW4uYw0KPj4+PiArKysgYi94ZW4vYXJjaC9hcm0vZG9tYWluLmMNCj4+Pj4gQEAgLTM5LDYgKzM5
LDcgQEANCj4+Pj4gI2luY2x1ZGUgPGFzbS92Z2ljLmg+DQo+Pj4+ICNpbmNsdWRlIDxhc20vdnRp
bWVyLmg+DQo+Pj4+IA0KPj4+PiArI2luY2x1ZGUgInZwY2kuaCINCj4+Pj4gI2luY2x1ZGUgInZ1
YXJ0LmgiDQo+Pj4+IA0KPj4+PiBERUZJTkVfUEVSX0NQVShzdHJ1Y3QgdmNwdSAqLCBjdXJyX3Zj
cHUpOw0KPj4+PiBAQCAtNzczLDYgKzc3NCw5IEBAIGludCBhcmNoX2RvbWFpbl9jcmVhdGUoc3Ry
dWN0IGRvbWFpbiAqZCwNCj4+Pj4gICBpZiAoIGlzX2hhcmR3YXJlX2RvbWFpbihkKSAmJiAocmMg
PSBkb21haW5fdnVhcnRfaW5pdChkKSkgKQ0KPj4+PiAgICAgICBnb3RvIGZhaWw7DQo+Pj4+IA0K
Pj4+PiArICAgIGlmICggKHJjID0gZG9tYWluX3ZwY2lfaW5pdChkKSkgIT0gMCApDQo+Pj4+ICsg
ICAgICAgIGdvdG8gZmFpbDsNCj4+Pj4gKw0KPj4+PiAgIHJldHVybiAwOw0KPj4+PiANCj4+Pj4g
ZmFpbDoNCj4+Pj4gZGlmZiAtLWdpdCBhL3hlbi9hcmNoL2FybS92cGNpLmMgYi94ZW4vYXJjaC9h
cm0vdnBjaS5jDQo+Pj4+IG5ldyBmaWxlIG1vZGUgMTAwNjQ0DQo+Pj4+IGluZGV4IDAwMDAwMDAw
MDAuLjdjMzU1MmI2NWQNCj4+Pj4gLS0tIC9kZXYvbnVsbA0KPj4+PiArKysgYi94ZW4vYXJjaC9h
cm0vdnBjaS5jDQo+Pj4+IEBAIC0wLDAgKzEsNzQgQEANCj4+Pj4gKy8qDQo+Pj4+ICsgKiB4ZW4v
YXJjaC9hcm0vdnBjaS5jDQo+Pj4+ICsgKg0KPj4+PiArICogVGhpcyBwcm9ncmFtIGlzIGZyZWUg
c29mdHdhcmU7IHlvdSBjYW4gcmVkaXN0cmlidXRlIGl0IGFuZC9vciBtb2RpZnkNCj4+Pj4gKyAq
IGl0IHVuZGVyIHRoZSB0ZXJtcyBvZiB0aGUgR05VIEdlbmVyYWwgUHVibGljIExpY2Vuc2UgYXMg
cHVibGlzaGVkIGJ5DQo+Pj4+ICsgKiB0aGUgRnJlZSBTb2Z0d2FyZSBGb3VuZGF0aW9uOyBlaXRo
ZXIgdmVyc2lvbiAyIG9mIHRoZSBMaWNlbnNlLCBvcg0KPj4+PiArICogKGF0IHlvdXIgb3B0aW9u
KSBhbnkgbGF0ZXIgdmVyc2lvbi4NCj4+Pj4gKyAqDQo+Pj4+ICsgKiBUaGlzIHByb2dyYW0gaXMg
ZGlzdHJpYnV0ZWQgaW4gdGhlIGhvcGUgdGhhdCBpdCB3aWxsIGJlIHVzZWZ1bCwNCj4+Pj4gKyAq
IGJ1dCBXSVRIT1VUIEFOWSBXQVJSQU5UWTsgd2l0aG91dCBldmVuIHRoZSBpbXBsaWVkIHdhcnJh
bnR5IG9mDQo+Pj4+ICsgKiBNRVJDSEFOVEFCSUxJVFkgb3IgRklUTkVTUyBGT1IgQSBQQVJUSUNV
TEFSIFBVUlBPU0UuICBTZWUgdGhlDQo+Pj4+ICsgKiBHTlUgR2VuZXJhbCBQdWJsaWMgTGljZW5z
ZSBmb3IgbW9yZSBkZXRhaWxzLg0KPj4+PiArICovDQo+Pj4+ICsjaW5jbHVkZSA8eGVuL3NjaGVk
Lmg+DQo+Pj4+ICsjaW5jbHVkZSA8eGVuL3ZwY2kuaD4NCj4+Pj4gKw0KPj4+PiArI2luY2x1ZGUg
PGFzbS9tbWlvLmg+DQo+Pj4+ICsNCj4+Pj4gK3N0YXRpYyBpbnQgdnBjaV9tbWlvX3JlYWQoc3Ry
dWN0IHZjcHUgKnYsIG1taW9faW5mb190ICppbmZvLA0KPj4+PiArICAgICAgICAgICAgICAgICAg
ICAgICAgICByZWdpc3Rlcl90ICpyLCB2b2lkICpwKQ0KPj4+PiArew0KPj4+PiArICAgIHBjaV9z
YmRmX3Qgc2JkZjsNCj4+Pj4gKyAgICAvKiBkYXRhIGlzIG5lZWRlZCB0byBwcmV2ZW50IGEgcG9p
bnRlciBjYXN0IG9uIDMyYml0ICovDQo+Pj4+ICsgICAgdW5zaWduZWQgbG9uZyBkYXRhID0gfjB1
bDsNCj4+Pj4gKyAgICBpbnQgcmV0Ow0KPj4+PiArDQo+Pj4+ICsgICAgLyogV2UgaWdub3JlIHNl
Z21lbnQgcGFydCBhbmQgYWx3YXlzIGhhbmRsZSBzZWdtZW50IDAgKi8NCj4+Pj4gKyAgICBzYmRm
LnNiZGYgPSBFQ0FNX0JERihpbmZvLT5ncGEpOw0KPj4+PiArDQo+Pj4+ICsgICAgcmV0ID0gdnBj
aV9lY2FtX21taW9fcmVhZChzYmRmLCBFQ0FNX1JFR19PRkZTRVQoaW5mby0+Z3BhKSwNCj4+Pj4g
KyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIDFVIDw8IGluZm8tPmRhYnQuc2l6ZSwgJmRh
dGEpOw0KPj4+PiArDQo+Pj4+ICsgICAgKnIgPSBkYXRhOw0KPj4+PiArDQo+Pj4+ICsgICAgcmV0
dXJuIHJldDsNCj4+Pj4gK30NCj4+Pj4gKw0KPj4+PiArc3RhdGljIGludCB2cGNpX21taW9fd3Jp
dGUoc3RydWN0IHZjcHUgKnYsIG1taW9faW5mb190ICppbmZvLA0KPj4+PiArICAgICAgICAgICAg
ICAgICAgICAgICAgICAgcmVnaXN0ZXJfdCByLCB2b2lkICpwKQ0KPj4+PiArew0KPj4+PiArICAg
IHBjaV9zYmRmX3Qgc2JkZjsNCj4+Pj4gKw0KPj4+PiArICAgIC8qIFdlIGlnbm9yZSBzZWdtZW50
IHBhcnQgYW5kIGFsd2F5cyBoYW5kbGUgc2VnbWVudCAwICovDQo+Pj4+ICsgICAgc2JkZi5zYmRm
ID0gRUNBTV9CREYoaW5mby0+Z3BhKTsNCj4+Pj4gKw0KPj4+PiArICAgIHJldHVybiB2cGNpX2Vj
YW1fbW1pb193cml0ZShzYmRmLCBFQ0FNX1JFR19PRkZTRVQoaW5mby0+Z3BhKSwNCj4+Pj4gKyAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgMVUgPDwgaW5mby0+ZGFidC5zaXplLCByKTsN
Cj4+Pj4gK30NCj4+PiANCj4+PiBJJ20gbm90IHN1cmUgcmV0dXJuaW5nIGFuIGVycm9yIHZhbHVl
IGhlcmUgaXMgaGVscGZ1bCwgYXMgSSdtIG5vdCBzdXJlDQo+Pj4gaG93IG5hdGl2ZSBBcm0gYmVo
YXZlcyBhbmQgaG93IHRoaXMgZXJyb3IgaXMgcHJvcGFnYXRlZCBpbnRvIHRoZQ0KPj4+IGd1ZXN0
LiBGV0lXcmV0dXJuaW5nIH4wIG9yIGRyb3BwaW5nIHdyaXRlcyBpcyB3aGF0IHdlIGRvIGluIHg4
NiB3aGVuDQo+Pj4gdlBDSSBpcyBub3QgY2FwYWJsZSBvZiBoYW5kbGluZyB0aGUgYWNjZXNzLg0K
Pj4gDQo+PiBNbWlvIGhhbmRsZXJzIGNhbiB0YWtlIGEgcmV0dXJuIGNvZGUgb24gYXJtIGlmIHNv
bWV0aGluZyBkaWQgbm90IHdvcmsNCj4+IHNvIEkgdGhpbmsgdGhpcyBpcyB0aGUgcmlnaHQgd2F5
IHRvIGRvIGl0IG9uIGFybS4NCj4+IE5vdyBoYXMgYWdyZWVkIHdpdGggSmFuLCB3ZSB3aWxsIGNo
YW5nZSB0aGUgcmV0dXJuIHR5cGUgb2YgDQo+PiB2cGNpX2VjYW1fd3JpdGUgKGFsc28gcmVuYW1l
ZCkgdG8gYmUgYSBib29sZWFuLg0KPj4gDQo+Pj4gDQo+Pj4+ICsNCj4+Pj4gK3N0YXRpYyBjb25z
dCBzdHJ1Y3QgbW1pb19oYW5kbGVyX29wcyB2cGNpX21taW9faGFuZGxlciA9IHsNCj4+Pj4gKyAg
ICAucmVhZCAgPSB2cGNpX21taW9fcmVhZCwNCj4+Pj4gKyAgICAud3JpdGUgPSB2cGNpX21taW9f
d3JpdGUsDQo+Pj4+ICt9Ow0KPj4+PiArDQo+Pj4+ICtpbnQgZG9tYWluX3ZwY2lfaW5pdChzdHJ1
Y3QgZG9tYWluICpkKQ0KPj4+PiArew0KPj4+PiArICAgIGlmICggIWhhc192cGNpKGQpICkNCj4+
Pj4gKyAgICAgICAgcmV0dXJuIDA7DQo+Pj4+ICsNCj4+Pj4gKyAgICByZWdpc3Rlcl9tbWlvX2hh
bmRsZXIoZCwgJnZwY2lfbW1pb19oYW5kbGVyLA0KPj4+PiArICAgICAgICAgICAgICAgICAgICAg
ICAgICBHVUVTVF9WUENJX0VDQU1fQkFTRSwgR1VFU1RfVlBDSV9FQ0FNX1NJWkUsIE5VTEwpOw0K
Pj4+PiArDQo+Pj4+ICsgICAgcmV0dXJuIDA7DQo+Pj4+ICt9DQo+Pj4+ICsNCj4+Pj4gKy8qDQo+
Pj4+ICsgKiBMb2NhbCB2YXJpYWJsZXM6DQo+Pj4+ICsgKiBtb2RlOiBDDQo+Pj4+ICsgKiBjLWZp
bGUtc3R5bGU6ICJCU0QiDQo+Pj4+ICsgKiBjLWJhc2ljLW9mZnNldDogNA0KPj4+PiArICogaW5k
ZW50LXRhYnMtbW9kZTogbmlsDQo+Pj4+ICsgKiBFbmQ6DQo+Pj4+ICsgKi8NCj4+Pj4gKw0KPj4+
PiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gvYXJtL3ZwY2kuaCBiL3hlbi9hcmNoL2FybS92cGNpLmgN
Cj4+Pj4gbmV3IGZpbGUgbW9kZSAxMDA2NDQNCj4+Pj4gaW5kZXggMDAwMDAwMDAwMC4uZDhhN2Iw
ZTNlOA0KPj4+PiAtLS0gL2Rldi9udWxsDQo+Pj4+ICsrKyBiL3hlbi9hcmNoL2FybS92cGNpLmgN
Cj4+Pj4gQEAgLTAsMCArMSwzNiBAQA0KPj4+PiArLyoNCj4+Pj4gKyAqIHhlbi9hcmNoL2FybS92
cGNpLmgNCj4+Pj4gKyAqDQo+Pj4+ICsgKiBUaGlzIHByb2dyYW0gaXMgZnJlZSBzb2Z0d2FyZTsg
eW91IGNhbiByZWRpc3RyaWJ1dGUgaXQgYW5kL29yIG1vZGlmeQ0KPj4+PiArICogaXQgdW5kZXIg
dGhlIHRlcm1zIG9mIHRoZSBHTlUgR2VuZXJhbCBQdWJsaWMgTGljZW5zZSBhcyBwdWJsaXNoZWQg
YnkNCj4+Pj4gKyAqIHRoZSBGcmVlIFNvZnR3YXJlIEZvdW5kYXRpb247IGVpdGhlciB2ZXJzaW9u
IDIgb2YgdGhlIExpY2Vuc2UsIG9yDQo+Pj4+ICsgKiAoYXQgeW91ciBvcHRpb24pIGFueSBsYXRl
ciB2ZXJzaW9uLg0KPj4+PiArICoNCj4+Pj4gKyAqIFRoaXMgcHJvZ3JhbSBpcyBkaXN0cmlidXRl
ZCBpbiB0aGUgaG9wZSB0aGF0IGl0IHdpbGwgYmUgdXNlZnVsLA0KPj4+PiArICogYnV0IFdJVEhP
VVQgQU5ZIFdBUlJBTlRZOyB3aXRob3V0IGV2ZW4gdGhlIGltcGxpZWQgd2FycmFudHkgb2YNCj4+
Pj4gKyAqIE1FUkNIQU5UQUJJTElUWSBvciBGSVRORVNTIEZPUiBBIFBBUlRJQ1VMQVIgUFVSUE9T
RS4gIFNlZSB0aGUNCj4+Pj4gKyAqIEdOVSBHZW5lcmFsIFB1YmxpYyBMaWNlbnNlIGZvciBtb3Jl
IGRldGFpbHMuDQo+Pj4+ICsgKi8NCj4+Pj4gKw0KPj4+PiArI2lmbmRlZiBfX0FSQ0hfQVJNX1ZQ
Q0lfSF9fDQo+Pj4+ICsjZGVmaW5lIF9fQVJDSF9BUk1fVlBDSV9IX18NCj4+Pj4gKw0KPj4+PiAr
I2lmZGVmIENPTkZJR19IQVNfVlBDSQ0KPj4+PiAraW50IGRvbWFpbl92cGNpX2luaXQoc3RydWN0
IGRvbWFpbiAqZCk7DQo+Pj4+ICsjZWxzZQ0KPj4+PiArc3RhdGljIGlubGluZSBpbnQgZG9tYWlu
X3ZwY2lfaW5pdChzdHJ1Y3QgZG9tYWluICpkKQ0KPj4+PiArew0KPj4+PiArICAgIHJldHVybiAw
Ow0KPj4+PiArfQ0KPj4+PiArI2VuZGlmDQo+Pj4+ICsNCj4+Pj4gKyNlbmRpZiAvKiBfX0FSQ0hf
QVJNX1ZQQ0lfSF9fICovDQo+Pj4+ICsNCj4+Pj4gKy8qDQo+Pj4+ICsgKiBMb2NhbCB2YXJpYWJs
ZXM6DQo+Pj4+ICsgKiBtb2RlOiBDDQo+Pj4+ICsgKiBjLWZpbGUtc3R5bGU6ICJCU0QiDQo+Pj4+
ICsgKiBjLWJhc2ljLW9mZnNldDogNA0KPj4+PiArICogaW5kZW50LXRhYnMtbW9kZTogbmlsDQo+
Pj4+ICsgKiBFbmQ6DQo+Pj4+ICsgKi8NCj4+Pj4gZGlmZiAtLWdpdCBhL3hlbi9kcml2ZXJzL3Bh
c3N0aHJvdWdoL3BjaS5jIGIveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvcGNpLmMNCj4+Pj4gaW5k
ZXggM2FhOGMzMTc1Zi4uOGNjNTI5ZWNlYyAxMDA2NDQNCj4+Pj4gLS0tIGEveGVuL2RyaXZlcnMv
cGFzc3Rocm91Z2gvcGNpLmMNCj4+Pj4gKysrIGIveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvcGNp
LmMNCj4+Pj4gQEAgLTY1OCw3ICs2NTgsNyBAQCBpbnQgcGNpX2FkZF9kZXZpY2UodTE2IHNlZywg
dTggYnVzLCB1OCBkZXZmbiwNCj4+Pj4gICAgICAgICAgICAgICAgICBjb25zdCBzdHJ1Y3QgcGNp
X2Rldl9pbmZvICppbmZvLCBub2RlaWRfdCBub2RlKQ0KPj4+PiB7DQo+Pj4+ICAgc3RydWN0IHBj
aV9zZWcgKnBzZWc7DQo+Pj4+IC0gICAgc3RydWN0IHBjaV9kZXYgKnBkZXY7DQo+Pj4+ICsgICAg
c3RydWN0IHBjaV9kZXYgKnBkZXYgPSBOVUxMOw0KPj4+PiAgIHVuc2lnbmVkIGludCBzbG90ID0g
UENJX1NMT1QoZGV2Zm4pLCBmdW5jID0gUENJX0ZVTkMoZGV2Zm4pOw0KPj4+PiAgIGNvbnN0IGNo
YXIgKnBkZXZfdHlwZTsNCj4+Pj4gICBpbnQgcmV0Ow0KPj4+PiBAQCAtNzUyLDYgKzc1MiwxOSBA
QCBpbnQgcGNpX2FkZF9kZXZpY2UodTE2IHNlZywgdTggYnVzLCB1OCBkZXZmbiwNCj4+Pj4gDQo+
Pj4+ICAgY2hlY2tfcGRldihwZGV2KTsNCj4+Pj4gDQo+Pj4+ICsjaWZkZWYgQ09ORklHX0FSTQ0K
Pj4+PiArICAgIC8qDQo+Pj4+ICsgICAgICogT24gQVJNIFBDSSBkZXZpY2VzIGRpc2NvdmVyeSB3
aWxsIGJlIGRvbmUgYnkgRG9tMC4gQWRkIHZwY2kgaGFuZGxlciB3aGVuDQo+Pj4+ICsgICAgICog
RG9tMCBpbmZvcm0gWEVOIHRvIGFkZCB0aGUgUENJIGRldmljZXMgaW4gWEVOLg0KPj4+PiArICAg
ICAqLw0KPj4+PiArICAgIHJldCA9IHZwY2lfYWRkX2hhbmRsZXJzKHBkZXYpOw0KPj4+PiArICAg
IGlmICggcmV0ICkNCj4+Pj4gKyAgICB7DQo+Pj4+ICsgICAgICAgIHByaW50ayhYRU5MT0dfRVJS
ICJTZXR1cCBvZiB2UENJIGZhaWxlZDogJWRcbiIsIHJldCk7DQo+Pj4+ICsgICAgICAgIGdvdG8g
b3V0Ow0KPj4+PiArICAgIH0NCj4+Pj4gKyNlbmRpZg0KPj4+IA0KPj4+IEkgdGhpbmsgdnBjaV9h
ZGRfaGFuZGxlcnMgc2hvdWxkIGJlIGNhbGxlZCBhZnRlciBjaGVja2luZyB0aGF0DQo+Pj4gcGRl
di0+ZG9tYWluIGlzICE9IE5VTEwsIHNvIEkgd291bGQgbW92ZSB0aGlzIGNodW5rIGEgYml0IGJl
bG93Lg0KPj4gDQo+PiBPbiBhcm0gdGhpcyB3b3VsZCBwcmV2ZW50IHRoZSBkb20wbGVzcyB1c2Ug
Y2FzZSBvciB0byBoYXZlIHRoZSBQQ0kNCj4+IGJ1cyBlbnVtZXJhdGVkIGZyb20gYW4gb3RoZXIg
ZG9tYWluLg0KPj4gQG9sZWtzYW5kcjogY2FuIHlvdSBjb21tZW50IG9uIHRoaXMgb25lLCB5b3Ug
bWlnaHQgaGF2ZSBhIGJldHRlcg0KPj4gYW5zd2VyIHRoYW4gbWUgb24gdGhpcyA/DQo+IA0KPiBG
b3IgbXkgdW5kZXJzdGFuZGluZywgYXMgYWxzbyBKYW4gcG9pbnRlZCBvdXQsIHRoaXMgc2hvdWxk
IGJlIHB1dCBpbnNpZGUgdGhlDQo+IElmICggIXBkZXYtPmRvbWFpbiApIGJlY2F1c2UgYWxzbyBh
cyB0aGUgY29tbWVudCBzdWdnZXN0cywgdGhpcyBvcGVyYXRpb24NCj4gc2hvdWxkIGJlIHBlcmZv
cm1lZCBvbmx5IHdoZW4gdGhlcmUgaXMgYSBEb20wIGFuZCB3aGVuIHdlIGFyZSB1c2luZw0KPiBh
IGRvbTBsZXNzIHNldHVwIHRoZSBwZGV2LT5kb21haW4gc2hvdWxkIGJlIE5VTEwgaWYgSeKAmW0g
bm90IHdyb25nLg0KPiBAb2xla3NhbmRyIG1heWJlIGNhbiBjb25maXJtDQoNCllvdSBhcmUgcmln
aHQuDQpJIHdpbGwgZml4IHRoYXQgYW5kIG1vdmUgdGhhdCBpbnRvIGFuIGlmLg0KDQpSZWdhcmRz
DQpCZXJ0cmFuZA0KDQo+IA0KPj4gDQo+Pj4gDQo+Pj4+ICsNCj4+Pj4gICByZXQgPSAwOw0KPj4+
PiAgIGlmICggIXBkZXYtPmRvbWFpbiApDQo+Pj4+ICAgew0KPj4+PiBAQCAtNzg0LDYgKzc5Nyw5
IEBAIG91dDoNCj4+Pj4gICAgICAgICAgICAgICAgICAmUENJX1NCREYoc2VnLCBidXMsIHNsb3Qs
IGZ1bmMpKTsNCj4+Pj4gICAgICAgfQ0KPj4+PiAgIH0NCj4+Pj4gKyAgICBlbHNlIGlmICggcGRl
diApDQo+Pj4+ICsgICAgICAgIHBjaV9jbGVhbnVwX21zaShwZGV2KTsNCj4+PiANCj4+PiBJJ20g
c2xpZ2h0bHkgbG9zdCBhdCB3aHkgeW91IGFkZCB0aGlzIGNodW5rLCBpcyB0aGlzIHN0cmljdGx5
IHJlbGF0ZWQNCj4+PiB0byB0aGUgcGF0Y2g/DQo+PiANCj4+IFRoaXMgd2FzIGRpc2N1c3NlZCBh
IGxvdCBpbiBwcmV2aW91cyB2ZXJzaW9uIG9mIHRoZSBwYXRjaCBhbmQNCj4+IHJlcXVlc3RlZCBi
eSBTdGVmYW5vLiBUaGUgaWRlYSBoZXJlIGlzIHRoYXQgYXMgc29vbiBhcyBoYW5kbGVycw0KPj4g
YXJlIGFkZGVkIHNvbWUgYml0cyBtaWdodCBiZSBtb2RpZmllZCBpbiB0aGUgUENJIGNvbmZpZyBz
cGFjZQ0KPj4gbGVhZGluZyBwb3NzaWJseSB0byBtc2kgaW50ZXJydXB0cy4gU28gaXQgaXMgc2Fm
ZXIgdG8gY2xlYW51cCBvbiB0aGUNCj4+IGVycm9yIHBhdGguIEZvciByZWZlcmVuY2VzIHBsZWFz
ZSBzZWUgZGlzY3Vzc2lvbiBvbiB2NCBhbmQgdjUgd2hlcmUNCj4+IHRoaXMgd2FzIGFjdHVhbGx5
IGFkZGVkICh0byBtdWNoIHJlZmVyZW5jZXMgYXMgdGhlIGRpc2N1c3Npb24gd2FzDQo+PiBsb25n
IHNvIGhlcmUgWzFdIGFuZCBbMl0gYXJlIHRoZSBwYXRjaHdvcmsgdGhyZWFkKS4NCj4+IA0KPj4g
WzFdIGh0dHBzOi8vcGF0Y2h3b3JrLmtlcm5lbC5vcmcvcHJvamVjdC94ZW4tZGV2ZWwvcGF0Y2gv
OWJkY2EyY2RhNWQyZTgzZjk0ZGMyNDIzZTU1NzE0MjczNTM5NzYwYS4xNjMzNTQwODQyLmdpdC5y
YWh1bC5zaW5naEBhcm0uY29tLw0KPj4gWzJdIGh0dHBzOi8vcGF0Y2h3b3JrLmtlcm5lbC5vcmcv
cHJvamVjdC94ZW4tZGV2ZWwvcGF0Y2gvZjA5M2RlNjgxYzI1NjBhNzE5Njg5NWJjZDY2NmVmODg0
MDg4NWMxZC4xNjMzMzQwNzk1LmdpdC5yYWh1bC5zaW5naEBhcm0uY29tLw0KPj4gDQo+PiBSZWdh
cmRzDQo+PiBCZXJ0cmFuZA0KDQo=


From xen-devel-bounces@lists.xenproject.org Fri Oct 15 10:18:34 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 10:18:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.210199.366964 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbKIM-0001t5-0c; Fri, 15 Oct 2021 10:18:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 210199.366964; Fri, 15 Oct 2021 10:18:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbKIL-0001sy-Tf; Fri, 15 Oct 2021 10:18:33 +0000
Received: by outflank-mailman (input) for mailman id 210199;
 Fri, 15 Oct 2021 10:18:32 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mbKIK-0001sm-7b; Fri, 15 Oct 2021 10:18:32 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mbKIK-0001T3-3h; Fri, 15 Oct 2021 10:18:32 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mbKIJ-0003bL-Oc; Fri, 15 Oct 2021 10:18:31 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mbKIJ-0000E0-O5; Fri, 15 Oct 2021 10:18:31 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=hx6G2pFM8xNk0R8ne+9XpJWuxiyKGFeiTJZboFGVTmc=; b=ICSZuq6WBA+GLvHT/oRddkzPn/
	9FWggXaudFvUm4p18uThCxFAT8zm5it+MAEZNNnm7e4g17+ZgYahrOJqQZDuWuQvWOvD0O4kTNcNL
	8DJgE6YEtRnH0Thi5v2vrlEVerOheETepuYPQKI0isygfJ9ieK2gYLl4HBGUb/nYLi1A=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165516-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 165516: regressions - FAIL
X-Osstest-Failures:
    libvirt:build-armhf-libvirt:libvirt-build:fail:regression
    libvirt:build-amd64-libvirt:libvirt-build:fail:regression
    libvirt:build-arm64-libvirt:libvirt-build:fail:regression
    libvirt:build-i386-libvirt:libvirt-build:fail:regression
    libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    libvirt=61cb54e3cbefc389d64357d9c479750593855383
X-Osstest-Versions-That:
    libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 15 Oct 2021 10:18:31 +0000

flight 165516 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165516/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-armhf-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-amd64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-arm64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-i386-libvirt            6 libvirt-build            fail REGR. vs. 151777

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-libvirt-vhd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a

version targeted for testing:
 libvirt              61cb54e3cbefc389d64357d9c479750593855383
baseline version:
 libvirt              2c846fa6bcc11929c9fb857a22430fb9945654ad

Last test of basis   151777  2020-07-10 04:19:19 Z  462 days
Failing since        151818  2020-07-11 04:18:52 Z  461 days  447 attempts
Testing same since   165504  2021-10-14 04:21:19 Z    1 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
    Adolfo Jayme Barrientos <fitoschido@gmail.com>
  Aleksandr Alekseev <alexander.alekseev@virtuozzo.com>
  Aleksei Zakharov <zaharov@selectel.ru>
  Andika Triwidada <andika@gmail.com>
  Andrea Bolognani <abologna@redhat.com>
  Ani Sinha <ani@anisinha.ca>
  Balázs Meskó <meskobalazs@mailbox.org>
  Barrett Schonefeld <bschoney@utexas.edu>
  Bastian Germann <bastiangermann@fishpost.de>
  Bastien Orivel <bastien.orivel@diateam.net>
  BiaoXiang Ye <yebiaoxiang@huawei.com>
  Bihong Yu <yubihong@huawei.com>
  Binfeng Wu <wubinfeng@huawei.com>
  Bjoern Walk <bwalk@linux.ibm.com>
  Boris Fiuczynski <fiuczy@linux.ibm.com>
  Brian Turek <brian.turek@gmail.com>
  Bruno Haible <bruno@clisp.org>
  Chris Mayo <aklhfex@gmail.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Ehrhardt <christian.ehrhardt@canonical.com>
  Christian Kirbach <christian.kirbach@gmail.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Cole Robinson <crobinso@redhat.com>
  Collin Walling <walling@linux.ibm.com>
  Cornelia Huck <cohuck@redhat.com>
  Cédric Bosdonnat <cbosdonnat@suse.com>
  Côme Borsoi <fedora@borsoi.fr>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniel Letai <dani@letai.org.il>
  Daniel P. Berrange <berrange@redhat.com>
  Daniel P. Berrangé <berrange@redhat.com>
  Didik Supriadi <didiksupriadi41@gmail.com>
  dinglimin <dinglimin@cmss.chinamobile.com>
  Dmytro Linkin <dlinkin@nvidia.com>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Eric Farman <farman@linux.ibm.com>
  Erik Skultety <eskultet@redhat.com>
  Fabian Affolter <mail@fabian-affolter.ch>
  Fabian Freyer <fabian.freyer@physik.tu-berlin.de>
  Fabiano Fidêncio <fabiano@fidencio.org>
  Fangge Jin <fjin@redhat.com>
  Farhan Ali <alifm@linux.ibm.com>
  Fedora Weblate Translation <i18n@lists.fedoraproject.org>
  gongwei <gongwei@smartx.com>
  Guoyi Tu<tu.guoyi@h3c.com>
  Göran Uddeborg <goeran@uddeborg.se>
  Halil Pasic <pasic@linux.ibm.com>
  Han Han <hhan@redhat.com>
  Hao Wang <wanghao232@huawei.com>
  Hela Basa <r45xveza@pm.me>
  Helmut Grohne <helmut@subdivi.de>
  Hiroki Narukawa <hnarukaw@yahoo-corp.jp>
  Ian Wienand <iwienand@redhat.com>
  Jakob Meng <jakobmeng@web.de>
  Jamie Strandboge <jamie@canonical.com>
  Jamie Strandboge <jamie@ubuntu.com>
  Jan Kuparinen <copper_fin@hotmail.com>
  jason lee <ppark5237@gmail.com>
  Jean-Baptiste Holcroft <jean-baptiste@holcroft.fr>
  Jia Zhou <zhou.jia2@zte.com.cn>
  Jianan Gao <jgao@redhat.com>
  Jim Fehlig <jfehlig@suse.com>
  Jin Yan <jinyan12@huawei.com>
  Jinsheng Zhang <zhangjl02@inspur.com>
  Jiri Denemark <jdenemar@redhat.com>
  John Ferlan <jferlan@redhat.com>
  Jonathan Watt <jwatt@jwatt.org>
  Jonathon Jongsma <jjongsma@redhat.com>
  Julio Faracco <jcfaracco@gmail.com>
  Justin Gatzen <justin.gatzen@gmail.com>
  Ján Tomko <jtomko@redhat.com>
  Kashyap Chamarthy <kchamart@redhat.com>
  Kevin Locke <kevin@kevinlocke.name>
  Kristina Hanicova <khanicov@redhat.com>
  Laine Stump <laine@redhat.com>
  Laszlo Ersek <lersek@redhat.com>
  Lee Yarwood <lyarwood@redhat.com>
  Lei Yang <yanglei209@huawei.com>
  Liao Pingfang <liao.pingfang@zte.com.cn>
  Lin Ma <lma@suse.com>
  Lin Ma <lma@suse.de>
  Lin Ma <morecache@gmail.com>
  Liu Yiding <liuyd.fnst@fujitsu.com>
  Luke Yue <lukedyue@gmail.com>
  Luyao Zhong <luyao.zhong@intel.com>
  Marc Hartmayer <mhartmay@linux.ibm.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Markus Schade <markus.schade@hetzner.com>
  Martin Kletzander <mkletzan@redhat.com>
  Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
  Matej Cepl <mcepl@cepl.eu>
  Matt Coleman <matt@datto.com>
  Matt Coleman <mcoleman@datto.com>
  Mauro Matteo Cascella <mcascell@redhat.com>
  Meina Li <meili@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Michał Smyk <fedora@smyk.it>
  Milo Casagrande <milo@milo.name>
  Moshe Levi <moshele@nvidia.com>
  Muha Aliss <muhaaliss@gmail.com>
  Nathan <nathan95@live.it>
  Neal Gompa <ngompa13@gmail.com>
  Nick Chevsky <nchevsky@gmail.com>
  Nick Shyrokovskiy <nshyrokovskiy@gmail.com>
  Nickys Music Group <nickys.music.group@gmail.com>
  Nico Pache <npache@redhat.com>
  Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
  Olaf Hering <olaf@aepfle.de>
  Olesya Gerasimenko <gammaray@basealt.ru>
  Orion Poplawski <orion@nwra.com>
  Pany <geekpany@gmail.com>
  Patrick Magauran <patmagauran.j@gmail.com>
  Paulo de Rezende Pinatti <ppinatti@linux.ibm.com>
  Pavel Hrdina <phrdina@redhat.com>
  Peng Liang <liangpeng10@huawei.com>
  Peter Krempa <pkrempa@redhat.com>
  Pino Toscano <ptoscano@redhat.com>
  Pino Toscano <toscano.pino@tiscali.it>
  Piotr Drąg <piotrdrag@gmail.com>
  Prathamesh Chavan <pc44800@gmail.com>
  Praveen K Paladugu <prapal@linux.microsoft.com>
  Richard W.M. Jones <rjones@redhat.com>
  Ricky Tigg <ricky.tigg@gmail.com>
  Robin Lee <cheeselee@fedoraproject.org>
  Roman Bogorodskiy <bogorodskiy@gmail.com>
  Roman Bolshakov <r.bolshakov@yadro.com>
  Ryan Gahagan <rgahagan@cs.utexas.edu>
  Ryan Schmidt <git@ryandesign.com>
  Sam Hartman <hartmans@debian.org>
  Scott Shambarger <scott-libvirt@shambarger.net>
  Sebastian Mitterle <smitterl@redhat.com>
  SeongHyun Jo <caelus9536@gmail.com>
  Shalini Chellathurai Saroja <shalini@linux.ibm.com>
  Shaojun Yang <yangshaojun@phytium.com.cn>
  Shi Lei <shi_lei@massclouds.com>
  simmon <simmon@nplob.com>
  Simon Chopin <chopin.simon@gmail.com>
  Simon Gaiser <simon@invisiblethingslab.com>
  Simon Rowe <simon.rowe@nutanix.com>
  Stefan Bader <stefan.bader@canonical.com>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Berger <stefanb@linux.vnet.ibm.com>
  Stefan Hajnoczi <stefanha@gmail.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Szymon Scholz <szymonscholz@gmail.com>
  Thomas Huth <thuth@redhat.com>
  Tim Wiederhake <twiederh@redhat.com>
  Tomáš Golembiovský <tgolembi@redhat.com>
  Tomáš Janoušek <tomi@nomi.cz>
  Tuguoyi <tu.guoyi@h3c.com>
  Victor Toso <victortoso@redhat.com>
  Ville Skyttä <ville.skytta@iki.fi>
  Vinayak Kale <vkale@nvidia.com>
  Wang Xin <wangxinxin.wang@huawei.com>
  WangJian <wangjian161@huawei.com>
  Weblate <noreply@weblate.org>
  Wei Liu <liuwe@microsoft.com>
  Wei Liu <wei.liu@kernel.org>
  Wei-Chen Chen <weicche@microsoft.com>
  William Douglas <william.douglas@intel.com>
  Yalei Li <274268859@qq.com>
  Yalei Li <liyl43@chinatelecom.cn>
  Yang Fei <yangfei85@huawei.com>
  Yang Hang <yanghang44@huawei.com>
  Yanqiu Zhang <yanqzhan@redhat.com>
  Yaroslav Kargin <ykargin@virtuozzo.com>
  Yi Li <yili@winhong.com>
  Yi Wang <wang.yi59@zte.com.cn>
  Yuri Chornoivan <yurchor@ukr.net>
  Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
  zhangjl02 <zhangjl02@inspur.com>
  Zheng Chuan <zhengchuan@huawei.com>
  zhenwei pi <pizhenwei@bytedance.com>
  Zhenyu Ye <yezhenyu2@huawei.com>
  Zhenyu Zheng <zheng.zhenyu@outlook.com>
  Zhenzhong Duan <zhenzhong.duan@intel.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          fail    
 build-arm64-libvirt                                          fail    
 build-armhf-libvirt                                          fail    
 build-i386-libvirt                                           fail    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           blocked 
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-libvirt-xsm                                 blocked 
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-libvirt                                     blocked 
 test-arm64-arm64-libvirt                                     blocked 
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-libvirt-pair                                blocked 
 test-amd64-i386-libvirt-pair                                 blocked 
 test-arm64-arm64-libvirt-qcow2                               blocked 
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-libvirt-vhd                                 blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 79452 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Oct 15 10:19:09 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 10:19:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.210206.366979 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbKIv-0002RS-Bz; Fri, 15 Oct 2021 10:19:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 210206.366979; Fri, 15 Oct 2021 10:19:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbKIv-0002RL-8u; Fri, 15 Oct 2021 10:19:09 +0000
Received: by outflank-mailman (input) for mailman id 210206;
 Fri, 15 Oct 2021 10:19:07 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=FGCa=PD=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mbKIt-0002R0-Bf
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 10:19:07 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 537d2d04-2da1-11ec-822d-12813bfff9fa;
 Fri, 15 Oct 2021 10:19:06 +0000 (UTC)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2051.outbound.protection.outlook.com [104.47.12.51]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-36-IOfnjC1DPIG7Uj_Cy2Q5UQ-1; Fri, 15 Oct 2021 12:19:04 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB5325.eurprd04.prod.outlook.com (2603:10a6:803:60::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.19; Fri, 15 Oct
 2021 10:19:01 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.017; Fri, 15 Oct 2021
 10:19:01 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 FR0P281CA0058.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:49::19) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4628.9 via Frontend Transport; Fri, 15 Oct 2021 10:19:00 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 537d2d04-2da1-11ec-822d-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634293145;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=7vG7th2ViwhqEtFmOJxS6pXO2/ai+G8iXQXhuBqqK2A=;
	b=hToeyWoTyw7KTq+ciNs6/jtn5eGrFL1NMSWjrR2VrPSCoclCRacsaV7ju+c7mjjQyr9n0A
	SjmilInEjdS/TRPxrcRzrrpWlcFoBBc4CPcTpbNP0Fp8pE1v6rVnzebtl2sQT0AAH3LTCg
	M1IQDw+MCqWysKZJcWvQR1c0Zt0P9ak=
X-MC-Unique: IOfnjC1DPIG7Uj_Cy2Q5UQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=QTIl/22J6k9ckUcMak60hrJKhSXey+letY2S9PpCTRlxjk9tBoZAQB+x4IWaNKoHuxHSJMhuzZUKKRN/zD6vpCYn2liEwTfRubVZhUQ1v54ELqJcMKP+aHL5hUY0gprW19NTDZix7vjgqBmWHCgVhEmnhOH3jikO8p9LiB6/cA4UFbso+gLqQwt+825ClWE8PxjqajKJtjFNgYm7o1pn1lYq9d/aNrBL6dd0fCVGfm6M7QTm11IG2NtNSQJRKu19tMvQlQEZTltXGtAIqVwGHg0VVzMFUToWVf/qFpTarXQjHKNtMI4ME0o0Mk1+pCb71HGF61dLDxfFSp5/adToog==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=7vG7th2ViwhqEtFmOJxS6pXO2/ai+G8iXQXhuBqqK2A=;
 b=HYNcMjhFbI6hDYtlSnZ5+s3fjVvV5THMr/jlF8r5Yg5xMYMUtxp8nplGQZ20SuedVU7bk70qYrODIAgBCKjBnUV2IWHjka1fMF6hob3N5qSGpewvtYD2c0Nklu+rK7deeUnoemLgtz93l36vuMBebkorbAVGcOMP1iCouYw0QEtToL+FGU8sFFk0oCr2xsu52p0673IKPe+Ry22kVNchO4rWvCIgS/V5Xzc0qV3OVVdOtDe5kkZ1O0GoJ+kb7Awc1iYbHWieIGzTD2+2uL3wQLGS7ng29dYsDez16NYfdBxlI+rWCgIPrUfCZAWTAl44PKFqNKNsfYCJ+3nLa2RdSA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [PATCH v6 2/3] xen/arm: Enable the existing x86 virtual PCI
 support for ARM.
To: Ian Jackson <iwj@xenproject.org>,
 Bertrand Marquis <Bertrand.Marquis@arm.com>
Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Rahul Singh <Rahul.Singh@arm.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
 Paul Durrant <paul@xen.org>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <cover.1634221830.git.bertrand.marquis@arm.com>
 <396b08e2598cf0338e0c7f4ad3cd5cb66db89224.1634221830.git.bertrand.marquis@arm.com>
 <f41f59f7-69ed-e2fe-dc17-434b456cf693@suse.com>
 <57A39480-34DF-4BF5-9B0E-802D30F94BBD@arm.com>
 <24937.21631.538303.29471@mariner.uk.xensource.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <b8fc68e6-2bba-ef11-4c4a-50c2046ecb04@suse.com>
Date: Fri, 15 Oct 2021 12:18:59 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <24937.21631.538303.29471@mariner.uk.xensource.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR0P281CA0058.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:49::19) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 8544c240-52d0-4935-43e3-08d98fc5355a
X-MS-TrafficTypeDiagnostic: VI1PR04MB5325:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB53258224DE4C8F9077196044B3B99@VI1PR04MB5325.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	iyHJjXt5nmtiKx691PXAdaI7yGcNOq4ujcoZRzvW4vF3/UUmm0Faz7FKuBkju8t1C3g6hyZlU/0biyRLqrOMsZWL2jaXO1zqnIVPRXwgK7P41annzWMNEGYMbzyAIVtWKKbGcpo7CMT6Ca3fNaJSfkBLVILZMK5Ut8GbcsW/C1yir6XbmOAjhQZMEIP/LH0DNVPJXxFiONFlnkoOKJMHwdsNQ0wasOsX43T0llaNvlwVpyxsvnk6EN06aD0O8x5K2/mdjqcvJ2Iut5T33BauQA5Po3FOhre0gbF05W/a2JX+AlcVUhCXbH4jO6RPU8bwIQzEk7cMoQrMSnx+FYQmXoaln0ymIMOmKRHkGL5VvRxw6UTJ2AHo5s3KpoXBJKbhDQjUiYI2Bff4HemU9fMZjmlegahzhltUI8IwCikAnuvqbkBWvc8FJHXjQIvcyl8ODTjzM70RG1ToAneixgLNEFtx1jH7PwAwhf1ODZG40wxtpfBkX+kYghTZDzVOS/krW54x+Rbc1NefSirKbtRSlT9n6+LB57BX6Ey0BHoHB1tk/Fn1AJIM1TMVawCXbaXS6CPEZ1EC0M2tTYQmX6MdODPR/dBCrI9gfX4bBJhMX/LPVi0V00Codpz7SVyITFrPXCpQMI5aDPkrh/zNEBRwdKCfKnUxhR9Hnlv6QiFa+J2deZXGpwk4+qyAEjKhADLaqH+hyq66mFiBQnUUexkKlLkNrlGMzETWIBaY/YuUl7X1UlWCIMLl8BL0AHiX9Jws
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(31686004)(8676002)(31696002)(26005)(8936002)(36756003)(66946007)(2906002)(38100700002)(66556008)(7416002)(53546011)(16576012)(6486002)(186003)(956004)(66476007)(5660300002)(86362001)(2616005)(110136005)(83380400001)(508600001)(4326008)(316002)(54906003)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Z2hBMzlNQkZUTjlHT3F5bkZ1aENwWWpib1I0REttOTZBNm5CK1FucElmRDUx?=
 =?utf-8?B?SFErM0M3ZVJKWDk0eHRoMU10QkNjci9YcjlIc0JoeFdYRkgrNDVKM2dvcFRC?=
 =?utf-8?B?OGtsYTRmQXE4eDRwSVBPSTBsc0FUN3JJN0FDeFkycUIrZ0RTeG9SRWRYeUlJ?=
 =?utf-8?B?K0wwUWw3cjlZZGp5dUUyMHR6ek5TcHFKbjJiekQ5U0FpR3VWNTkySzlSNzhI?=
 =?utf-8?B?MHQ4ajBBNUR6OFVKN0Y5anJ4MUQ4bHBYNDVKZHBOeUNnemp3TUs5N3ZkRVBi?=
 =?utf-8?B?QzUySWQ2a2tIbFArKytUbzIwbFhtYllFSmhLdHJYcXRJNC92UnUzWFB2RHdB?=
 =?utf-8?B?Ny9adm5ETEE0N0FnbXdhWExWQ0UvRFZnOWh5YjdETXNRNkdnSnV1WHo0SDhQ?=
 =?utf-8?B?TGtQY2E0OGdtbkZmZmtnRTYrODN0eWtxWXFFMGdWSTdGTFNJd3VQbmlwNmkr?=
 =?utf-8?B?QzE0NXY4MDJIeC93SGdCRkVaTXJka1dNUzVNbE1OOEZUenoxdnB4ZVlMc0Uv?=
 =?utf-8?B?UElqYnlLWTEya09jaHpNbUlNVzdLdG9mVnR6Q3h6bFdnNTdIbXVqeTM3UkZG?=
 =?utf-8?B?ajZWK1lyQm1CU2xuRnNFdlY1VTU4K01tM2RGa3lwb0pxZTBlTU5uejE4Q1FK?=
 =?utf-8?B?RmdhYmZtNHNPdDFRS1p5NytCWlMremVtS21zRzQyRFpGK1pGZ25XVlNaaGZz?=
 =?utf-8?B?Vlludk5JclRJVy9qbGxjN3MwRHRMNWQ4VVNteE1NR2VzOW9WMXk2anQwK1ls?=
 =?utf-8?B?a213MHl3ZHlMMFgrd3UyUFJXU2JDeDVJcWRsYTB3QjQvK0VkbDE2cnZmZTdW?=
 =?utf-8?B?TXk2SnhMSmtFT0tPR1JnUmlZc1ErMlF5VHp2NTFEZEkrUit3NCtseHZCSzVq?=
 =?utf-8?B?OEFMSzVCWlgzZEt1dWppMCtlRVdXY3pqUi9wcnlob3pDRVZ3c2V2anYrYXdw?=
 =?utf-8?B?cG5KazF4QkNDWVR5WHptVTRISkNNRVRBQy85OVl6V2ZWTUhFdWVPekZyVmRV?=
 =?utf-8?B?R1JSbnd5d2pnV0lVT21xaVNlU1U4R044eEQ0Zzd6bHREaUMvNUVCZWtXdnp3?=
 =?utf-8?B?YThlaVY5Y0ttYXorYkZvekg4NytSaGp6akVFeTQ4SHNnZ2JnSHEzQkZ1WklG?=
 =?utf-8?B?Nm5MOFV1cVJEaXhlRitsQXpLRkxKWXF2VXJickJadmhLTGVnaElqVHNzdXdm?=
 =?utf-8?B?d2JDZ2gzQ2h5SVBVcFlVTXNoY25UVDlxODJ1QkovRlBFSmlSRHJWSTNMN1NB?=
 =?utf-8?B?bzFXVHpHYzBQdTJVTmdlMGdKVGFCKzl3ODJUNGU5djFIczhUWDBvdjJ1VXZi?=
 =?utf-8?B?YzFvUFZ2eVBNZGdMVHFKWTB3VjR0TFNwM3c1UC95dS9HV1ZneCs3b2llMi9L?=
 =?utf-8?B?UEJSakZKMDB3VFRZbkRYcWdLSGpDd000Z0VPdFhoQ2ZsM3g2T0FqdytqcUZL?=
 =?utf-8?B?aHk2bGxTbGY2LyttZlJ6RGxVdjlxRXNSeFVHRGtIays2dFdGRUdCU005Tm1w?=
 =?utf-8?B?ZVRXVmwydlN5amloMVBVYTE2ZkNWU1JrZzhvbzJzQS9wcVZGbklueFVWbjdP?=
 =?utf-8?B?ZXpoVU8xbFlnaGdybFZyV1hqbHdXM1p1bllKMENPNnV6dW51SkpqREZMUU02?=
 =?utf-8?B?SjgxZXd4MzQwdWx5UzRUU2xtc05zcmV3bXZRcUR5VmhwYnpxd0JwbVNUMW5z?=
 =?utf-8?B?bEIwYVFmVDhBQjBQcWJabiswb2tZN2FpdjZidkhJaTVoYXBUYzhYNTc5OW45?=
 =?utf-8?Q?pqvAiRmDO1/oUXrNR66ah4optln8ALrGokl0oK1?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8544c240-52d0-4935-43e3-08d98fc5355a
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2021 10:19:01.7032
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: VlW9zH9E7ONrThLReatFtndkoBaHuHPao0n7YKOwJZTV14Ft8Iqx8umuwRad4uCV0N+viSpIc9JzhuTwDj9ArA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5325

On 15.10.2021 12:14, Ian Jackson wrote:
> Bertrand Marquis writes ("Re: [PATCH v6 2/3] xen/arm: Enable the existing x86 virtual PCI support for ARM."):
>>> On 15 Oct 2021, at 09:00, Jan Beulich <jbeulich@suse.com> wrote:
>>> The latter is fine to be put here (i.e. FTAOD I'm fine with it
>>> staying here). For the former I even question its original placement
>>> in asm-x86/pci.h: It's not generally correct as per the PCI spec, as
>>> the bus portion of the address can be anywhere from 1 to 8 bits. And
>>> in fact there is a reason why this macro was/is used in only a
>>> single place, but not e.g. in x86'es handling of physical MCFG. It
>>> is merely an implementation choice in vPCI that the entire segment 0
>>> has a linear address range covering all 256 buses. Hence I think
>>> this wants to move to xen/vpci.h and then perhaps also be named
>>> VPCI_ECAM_BDF().
>>
>> On previous version it was request to renamed this to ECAM and agreed
>> to put is here. Now you want me to rename it to VPCI and move it again.
>> I would like to have a confirmation that this is ok and the final move if possible.
>>
>> @Roger can you confirm this is what is wanted ?
> 
> I think Roger is not available today I'm afraid.
> 
> Bertrand, can you give me a link to the comment from Roger ?
> Assuming that it says what I think it will say:
> 
> I think the best thing to do will be to leave the name as it was in
> the most recent version of your series.  I don't think it makes sense
> to block this patch over a naming disagreement.  And it would be best
> to minimise unnecessary churn.
> 
> I would be happy to release-ack a name change (perhaps proposed bo Jan
> or Roger) supposing that that is the ultimate maintainer consensus.
> 
> Jan, would that approach be OK with you ?

Well, yes, if a subsequent name change is okay, then I could live with
that. I'd still find it odd to rename a function immediately after it
already got renamed. As expressed elsewhere, I suspect in his request
Roger did not pay attention to a use of the function in non-ECAM code.

Jan



From xen-devel-bounces@lists.xenproject.org Fri Oct 15 10:20:16 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 10:20:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.210214.366990 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbKJz-0003rM-N2; Fri, 15 Oct 2021 10:20:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 210214.366990; Fri, 15 Oct 2021 10:20:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbKJz-0003rD-Iw; Fri, 15 Oct 2021 10:20:15 +0000
Received: by outflank-mailman (input) for mailman id 210214;
 Fri, 15 Oct 2021 10:20:13 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=UM5E=PD=citrix.com=roger.pau@srs-us1.protection.inumbo.net>)
 id 1mbKJx-0003qt-FN
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 10:20:13 +0000
Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 7aee564d-2da1-11ec-822d-12813bfff9fa;
 Fri, 15 Oct 2021 10:20:12 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7aee564d-2da1-11ec-822d-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1634293212;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=xryMakgPAx+TdFX7ksKFqeArEpHY8BuQX20FfbnizRw=;
  b=hSoZjcKMM0sZEPvZoFFXhZm30rl6avb7Hh4b3zGoNMLKWgfaF/rpPwL0
   2JXUT8DybWonyAaiFwZZiDzpWR5kP0PDgxupZMhL/jUSpF3dBtKMcLNM2
   RKeMNUOltNSRH9xCj4V5aqHU1hVWN2xuiS2T/OOhowjlZqvbd+evKI6Vi
   0=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: Vahd2xfC8RE/GRFckPm5YaM5ciHt5L4FbBbTOsE9c8P8L342rPzw2r4oYwF058i/9HENAQRD24
 mC+RVYPne0pjEkoDIS2F5LOmFX88im4eumvEupuuxHKjkTx9dG1Ui6s5jgXt5ClVHukworYtWm
 Vj+fg+yDqSUmHf6EDcNWUYwjAhpeOUtcYeYpta3CnOwtfoZ+ywZWaguwNWC+KtL4TSMepLDK2c
 P46n6DfwffI6MSODs5t2ud5bPvu/E5YnLClDBulOpipb1u4sfiGcuU+EZWkzTP7y4VQtBkb28R
 4D5e9IiSjC6IXlUDhHNzrfMF
X-SBRS: 5.1
X-MesageID: 55262659
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:OTabFa5BBVbLd2cIstuCGAxRtCjBchMFZxGqfqrLsTDasY5as4F+v
 mIfUGjSPq2LYTfxKY1/Odmz9U0Bu8LWmN81SwZo+yBgHi5G8cbLO4+Ufxz6V8+wwmwvb67FA
 +E2MISowBUcFyeEzvuV3zyIQUBUjclkfJKlYAL/En03FVIMpBsJ00o5wrdh29Mw2LBVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Z8
 MsUn7G0bAIVOO71srsfFDR3MnhiBPgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALNs7kMZlZonh95TrYEewnUdbIRKCiCdpwgWpq2JoQQKe2i
 8wxTBlOaRvpPUJzJE4sMbMOkNyxpj7SWmgNwL6SjfVuuDWCpOBr65DvOtfIft2BRe1Og12V4
 GnB+gzRPBYeM9COzCufxViljOTPgCDTVZobEfuz8fsCqEKX7nweDlsRT1TTid69h02lUtRTM
 Xs9/CY0sLMy/0ymSNr6dxCgqXvCtRkZM/JIGvA+wBGAzOzT+QnxLmoZSj9MbvQ2uclwQiYlv
 neZktWsCTFxvbm9TXOG6qzSvT60ITISL2IJeWkDVwRty/Puup0phxTDCPNqCreoj8bdECv1h
 TuNqUAWhqoRpd4G0b2h+lLKiC7qoYLGJiYu/RneVG+h6gJ/Zaamapau5Fyd6uxPRK6jR1mcu
 D4/ms6R7MgHF5TLnyuIKNjhB5nwuazDameFxwcyQd9xrFxB5kJPY6ho/mhUCUNMN/oCOgbDP
 02UlCxwvYNqaS7CgbBMX6q9DMEjzK7FHNvjV+zJYtcmXqWdZDNr7wk1OhbOhzGFfFwE1PhlY
 8/CIJnE4WMyUPw/lFKLq/EhPajHL8zU7VjYQozn1FyZ2L6aaW/9pVwtYQbWML5RAE9ppmzoH
 zdj2ymil0o3vA7WOHC/HWsvwbYidiVT6Xfe8Z0/SwJ7ClA6cFzN8teIqV/bR6Rrnr5OisDD9
 WynV0lTxTLX3COcdV/RMCs+MeO1A/6TSE7X2wR3YD5EPFB4Oe6SAFo3LcNrLdHLCsQypRKLc
 xX1U5rZWakeItg20z8ccYP8vORfmOeD3mqz096eSGFnJfZIHlWRkve9J1eH3HReX0Kf6Jply
 5X9h1yzfHb2b1k7ZCogQKn0lA3ZULl0sL8aYnYk1fEIJhiyqtExdXGo5hL1SulVQSj+KvKh/
 1/+KT8TpPXXop9z99/MhKueqJyuHfc4FU1fd1Q3J57oXcUD1mb8k4JGTsiSejXRCDH99Km4P
 L0HxPDgKvwX2l1NttMkQbpsyKs/4frppqNbkVs4TCmaMQzzB+MyOGSC0OlOqrZJmu1TtzypV
 x/d4dJdI7iIZp/oSQZDOAo/Y+2f/vgIgT2Ov+8tKUD36XYvrrqKWElfJTeWjylZIOcnOY8p2
 7556sUX9xa+mlwhNdPf1nJY8GGFL3ohVaQ7t85FXN+321RzklwbOM7SEC775p2Leu5gCEhyL
 2/GnrfGipRd2lHGLyg5G0/S0LcPnp8Joh1LkgMPfgzbhtrfi/Yr9xRN6jBrHB9NxxBK3u8va
 GhmM0p5efeH8zty3ZURWmmtH0dKBQGD+1y3wFwMzTWLQ06tX23LDWs8JefSoxxJrzMCJmBWr
 OOC1WLocTf2Z8WgjCI9VHlsp+HnUdEspBbJn9qqHpjdEpQ3CdY/bnRCuYbcR8PbPP4M
IronPort-HdrOrdr: A9a23:tEPj06nCsuatD/A4pRh/Rx0Xg4TpDfO9imdD5ihNYBxZY6Wkfp
 +V88jzhCWZtN9OYhwdcLC7WZVpQRvnhPlICK0qTM2ftW7dyRaVxeBZnPDfKljbdREWmdQtt5
 uIH5IObeEYSGIK8foSgzPIYurIouP3iZxA7N22pxwGLXAIGtFdBkVCe36m+yVNNXd77PECZf
 yhD6R81l6dkSN9VLXFOpBJZZmPm/T70LbdJTIWDR8u7weDyRuu9b7BChCdmjMTSSlGz7sO+X
 XM11WR3NTtj9iLjjvnk0PD5ZVfn9XsjvNFGcy3k8AQbhHhkByhaohNU6CL+Bo1vOaswlA3l8
 SkmWZtA+1Dr1fqOk2lqxrk3AftlB4o9n/Z0FedxUDupMToLQhKQ/ZptMZ8SF/0+kAgtNZz3O
 ZgxGSCradaChvGgWDU+8XIfwsCrDv1nVMS1cooy1BPW4oXb7Fc6aYF+llOLZsGFCXmrKg6De
 hVCt3G7vo+SyLaU5nghBgs/DWQZAV3Iv/fKXJy/vB9kgIm0kyR9nFoh/D2xRw7hdUAo5ot3Z
 WMDk0nrsAJcie6BZgNcNvpevHHeFAldyi8Rl56EW6XZ53vBEi93qIfwI9Fr91CK6Z4hqfbpv
 z6ISRlXCgJChvTNfE=
X-IronPort-AV: E=Sophos;i="5.85,375,1624334400"; 
   d="scan'208";a="55262659"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=YX9LFIxx5zscLhPM1odE3bXgND9SDwQuOfdz0NcsIe+3CQtS1yeYUveP199Vz9srrL8n0TVIwRam3pYR/UAZPNCjuRgHYsWxzvQxD+yeIu/8j7DtjgNuxDVJko8krM9Bcwt6cdV1nRF+76WxKRQqZvV8XJuTDXim/+/Tz46dewZ9TiorMTHmH7sAZtMYPupcld1VkeGp110arOTXhOtM7GWT6oJ3D9zSLeC6YCvAmoWNsEac7ia1aItJb+3FOY80vejHLE16TVh6zP6Iv3yY5pWhFoxLgNDZ/i6dnQbvsJeibgeBioVmsEvxs51juxVPf+O/Xtp57k6+Duq5+Liw5w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=7MNC1a91rpq7DUgy3k6U5HtOdN4y858cGx50d5cboIg=;
 b=Eb39JKwWNVv+aBMhJwDE/KcdsiX61rXoCk3GPT41kqLrD29cjN/Cf962ikQnjpxMo5Xr8VYKt8yKYxd8qT0916e483IkU8clhDcsNuU4SuQjaZwKklUjqaf1glU1gxADnRXoUQvBflfBwUJr8RnhfTU9EjHSzvkXodL1Q7wUbH25Z4QS5hLoq0XHx7rP9/w5eppg92f75koyHyNwuLfakrzJFfTZKLp4eWIBjCQwaFgaxYVjzQ3Eo7Bznk5XOAmJJZeq3Z7a/meVM97BS11QVzgMPuJKSVpoWjuHJ1KkqIJ1ZtmOGNSXZvp7sIqsUZF6fy4jnmHgxSXm5t0S201z+Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=7MNC1a91rpq7DUgy3k6U5HtOdN4y858cGx50d5cboIg=;
 b=G6J/9LfqYL0mLSycp8ic3ivfjFz5lMrNWAaWEgv+mBUPExm+/wl42Ti2oYZhmJqUZczMcfF0Mpz39DRA977yRXpYv9ga+clvxoS55COzyVxYAzarWZ0YQvXylMbA+XUEA50TzfJRkN15+kNDRi6Nf9RgiCdMywGDfbHeWW4XroY=
Date: Fri, 15 Oct 2021 12:19:48 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Bertrand Marquis <Bertrand.Marquis@arm.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>, Ian Jackson
	<iwj@xenproject.org>, Rahul Singh <Rahul.Singh@arm.com>, Stefano Stabellini
	<sstabellini@kernel.org>, Julien Grall <julien@xen.org>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
	Wei Liu <wl@xen.org>, Paul Durrant <paul@xen.org>, Oleksandr Andrushchenko
	<Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH v6 2/3] xen/arm: Enable the existing x86 virtual PCI
 support for ARM.
Message-ID: <YWlVxAPcuWVHtxsR@MacBook-Air-de-Roger.local>
References: <cover.1634221830.git.bertrand.marquis@arm.com>
 <396b08e2598cf0338e0c7f4ad3cd5cb66db89224.1634221830.git.bertrand.marquis@arm.com>
 <YWk8uP/YuSee1MfG@MacBook-Air-de-Roger.local>
 <CD9B29B0-31FD-4E09-93E3-7124C724BC23@arm.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CD9B29B0-31FD-4E09-93E3-7124C724BC23@arm.com>
X-ClientProxiedBy: LNXP123CA0011.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:d2::23) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: fb47ba05-d0b9-4c88-ad4d-08d98fc5543d
X-MS-TrafficTypeDiagnostic: DM4PR03MB6062:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <DM4PR03MB606241210D2A725ECBDCA5A68FB99@DM4PR03MB6062.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: yKLeQqvv274ycAtzeYZzATXsvkW679bvT6dXC5i6ii1IWu5j3bwQQh0qpommuO6WeyF+N0ZDHy9u/MLKDepVYuEAU799QVFuLjR/rE7xdCduBHFfDoA7wPqY1oXiThtPMdJd+a+IgD/9w/StI8Lxzw1WP/1io/SJFQqlm0GuWyk5J6u0ijInGfDgG068LkvzMQzEX7G9x3cae8isOT9c6AqIHD/XlQSR3axvX3BBS4ZuJm8o0aQlz9eaCqHN3+b6pRMal1TFR8RDGTTnBgMV7A14WaEXw2Nay2218IerHw/OfO9/JT9L+I1FezE6T2jMZUgwzbnwXVt1vFHmbiOwTTwVSjyoOZ/F92j4ln6N5ef+Q2lXotlGJG1JYo+XX8EyVaYuJSzfVflukqCepPWf82AnlotplKd1SOrbQObLhamGhZTJh4JqJHayPwd2EHtN10HRe3flf+j/rDddZP1bEQzqnqMpvhhPbok+kvDTcE1c+ksDVa5kqN+o6/vyO1wJq9qperP4GHYK0HIa68YXjCznKT2aWAEswilgnPZ/NQX8dtm5jf30ehakviCKl7ksGzfWUqETwj/0iEYedCRgIKWuW+H0XG0qtd7TeyX6Z4UI99X6HIt0Ul2UxHCqnQ3PPEW4H43ZITEwaHinW33ldA==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(85182001)(54906003)(316002)(86362001)(508600001)(6496006)(53546011)(26005)(5660300002)(8676002)(8936002)(6916009)(66476007)(66556008)(66946007)(186003)(7416002)(9686003)(83380400001)(956004)(6666004)(4326008)(2906002)(82960400001)(38100700002)(6486002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NlVQYkdzRUpzbEM0TEpzQ01FY0tXUlpPMUhFRkRaYXJxc2dmQ1NmaHZVTC95?=
 =?utf-8?B?M0VaWVh5RUtFeW1Eb0RZU0prb2NqMGZ6aFdpMTUwVS95bjhSZW1adDgxUnRt?=
 =?utf-8?B?Z2J5ZnRKakpNb2dwc2diM2VhbEF2OTBDanlYWVB4M1l6RytLcFFxSmpyUEgv?=
 =?utf-8?B?SXVOQ3duRmx3ai9RanY1RXR4QXQ1a3ZwUXI5djBxeURaYWczZWg0SDJHR242?=
 =?utf-8?B?STFqaEJqY1Zod3pqSnlkTkxkZVdxeHE4eDkxVGhwbHVKQWNCUVdCOGQ1S2xC?=
 =?utf-8?B?Wm5vT3l4T0M2anVHVFl1aVcyUTdxYWM3czluWnY1eWxTQkJUZzZuSGlHUmVz?=
 =?utf-8?B?TXFNWXhDOUx6SjQrNVZWYmhmY2dBb3VlbWE0MVFqYTFmbG52NUw0YVp3M1Uv?=
 =?utf-8?B?Tm9yUy80ZndqSlJNNlN6RUlnV1Z2cmQyaTFoRWh5SFhSb0VxVHhBSjl5OVZ5?=
 =?utf-8?B?THozRmRpQ1RLRG1GSkdsQUNoMUVaa0RiSWN1L3ZWbTgyUUdENlkzSGdCR0ty?=
 =?utf-8?B?SmdVc3c4eUxIUHl2M01ESmhjeFNSYU9TZ0tOM2RVSTkzNmJ3bWFJaC92ckc2?=
 =?utf-8?B?dFEzbmd3VEFHd0tNamsrSVlVS2VBQjVDNUx5VVR1SzRpcTRLMWZydTVaM3JQ?=
 =?utf-8?B?djlqb0pNbmNBdElSczZURTZUZWkzQTFzZ2F6YkovS2haeHJyZll4UWQ0WFFW?=
 =?utf-8?B?OGg2cGxMR3FqNk9rSUczSFBSUjBnUk8yZXpRcEhCUU41bWVyY1VtZ2xZOHlt?=
 =?utf-8?B?K3R2WTM1dDhHZnZXdWJpb0RnZmxuMUJKRzRYVnAvSG0vNC9qWjU1UGRsaDNZ?=
 =?utf-8?B?R0pVRzJCK29SYlRjUktncytvUDFGYWRkb0U3cEJwV2hkZG56bXhMaVJrTVhr?=
 =?utf-8?B?VkpROW9Va0dLNHcvVFM3amYvYk1zNlZpTEFKZjlxNHNtekxESDQySkJmQlZE?=
 =?utf-8?B?MjBiSHg2QXpRblkvSk1nRnU2OWJwSFFmbnR5anA1VG0yT0NiekJ1TXBmWmVz?=
 =?utf-8?B?SmR4ZUs5blZWVHVmaDhrb2tielBSUnBPQmdLbUFEelRWWlA0UWdCZXBZU3FI?=
 =?utf-8?B?NkFnNEJoVjZGbzNXOGpKQUphOVJGekVQZm5NWXBDNWRabjBTRVdRcmZLWWpV?=
 =?utf-8?B?QXRUbkRLaVZLaW01L054bFdLL3U4MkZtbTZYZ0dMMm9VNWhoQUpNOFpoOUtp?=
 =?utf-8?B?M1QzWGQxeDNFUm9ETmNVK2ZxbkxhaDFWU0ZrRXNjYUl0QkpjbTZxUEpDVTBN?=
 =?utf-8?B?OE1GYXFMZmhjRzI0TUY0WG1IcDdzUVBoS1FqKzJ0Lzk3WlA1dWhVeGc5eURi?=
 =?utf-8?B?RnFsU1hmOWRuQ1JWRFhkaHJvSEN5OFlBNmFkdmJPcjNNSHkybEtXY2hZQmRP?=
 =?utf-8?B?aXhlYnN0V000SXVnZUN1d0QxUUsrV096dWdGKy9WQ2NKeHBZNVlZYXN2NGo3?=
 =?utf-8?B?M2RMaEJ5dTdIaVdiNFZlVUp2ZTBVdTd0aVdtM1Fza1UzSUs3ckxPNlk3UkJS?=
 =?utf-8?B?OFpnMC8rMEZZZ2hzcTlLbTNjTkVlYm81VUhvUHgwWGxwVXc5cDRKYkxRQlJ4?=
 =?utf-8?B?eGdUSS80ZEtIS3BYVG1lbTdVSzcrNElhYWlkNFBvQ1lzUTFqQjFQbWVmaHgw?=
 =?utf-8?B?YmNSMVphS1g4VlpkWWRlS1VhR1Q2WkJTMWU3UDhIV3VNN3cwZkNsRzZCOFNW?=
 =?utf-8?B?cmxROGpOQ3JiU2RRcG1VOFo3MkI5czIrMEVlVHBOSlZRVGthZjRmRzllR3pn?=
 =?utf-8?Q?jpirelQ8fzBeyJVEf9sRmztNq9Mgv0OlVrGn6Su?=
X-MS-Exchange-CrossTenant-Network-Message-Id: fb47ba05-d0b9-4c88-ad4d-08d98fc5543d
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2021 10:19:53.6304
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: cnA/4K9PdYLZ+DAFdB8fszMmMSgvCvckqUuj/h2VEYgZCDG+Vi1K64xK8UHRXQWzpCPocF5CzPZzlzsX0RtVsg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR03MB6062
X-OriginatorOrg: citrix.com

On Fri, Oct 15, 2021 at 09:52:28AM +0000, Bertrand Marquis wrote:
> Hi Roger,
> 
> > On 15 Oct 2021, at 09:32, Roger Pau Monné <roger.pau@citrix.com> wrote:
> > 
> > On Thu, Oct 14, 2021 at 03:49:50PM +0100, Bertrand Marquis wrote:
> >> From: Rahul Singh <rahul.singh@arm.com>
> >> diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci.c
> >> index 3aa8c3175f..8cc529ecec 100644
> >> --- a/xen/drivers/passthrough/pci.c
> >> +++ b/xen/drivers/passthrough/pci.c
> >> @@ -658,7 +658,7 @@ int pci_add_device(u16 seg, u8 bus, u8 devfn,
> >>                    const struct pci_dev_info *info, nodeid_t node)
> >> {
> >>     struct pci_seg *pseg;
> >> -    struct pci_dev *pdev;
> >> +    struct pci_dev *pdev = NULL;
> >>     unsigned int slot = PCI_SLOT(devfn), func = PCI_FUNC(devfn);
> >>     const char *pdev_type;
> >>     int ret;
> >> @@ -752,6 +752,19 @@ int pci_add_device(u16 seg, u8 bus, u8 devfn,
> >> 
> >>     check_pdev(pdev);
> >> 
> >> +#ifdef CONFIG_ARM
> >> +    /*
> >> +     * On ARM PCI devices discovery will be done by Dom0. Add vpci handler when
> >> +     * Dom0 inform XEN to add the PCI devices in XEN.
> >> +     */
> >> +    ret = vpci_add_handlers(pdev);
> >> +    if ( ret )
> >> +    {
> >> +        printk(XENLOG_ERR "Setup of vPCI failed: %d\n", ret);
> >> +        goto out;
> >> +    }
> >> +#endif
> > 
> > I think vpci_add_handlers should be called after checking that
> > pdev->domain is != NULL, so I would move this chunk a bit below.
> 
> On arm this would prevent the dom0less use case or to have the PCI
> bus enumerated from an other domain.

vpci_add_handlers will try to access pdev->domain, so passing a pdev
without domain being set is wrong.

> @oleksandr: can you comment on this one, you might have a better
> answer than me on this ?
> 
> > 
> >> +
> >>     ret = 0;
> >>     if ( !pdev->domain )
> >>     {
> >> @@ -784,6 +797,9 @@ out:
> >>                    &PCI_SBDF(seg, bus, slot, func));
> >>         }
> >>     }
> >> +    else if ( pdev )
> >> +        pci_cleanup_msi(pdev);
> > 
> > I'm slightly lost at why you add this chunk, is this strictly related
> > to the patch?
> 
> This was discussed a lot in previous version of the patch and
> requested by Stefano. The idea here is that as soon as handlers
> are added some bits might be modified in the PCI config space
> leading possibly to msi interrupts. So it is safer to cleanup on the
> error path. For references please see discussion on v4 and v5 where
> this was actually added (to much references as the discussion was
> long so here [1] and [2] are the patchwork thread).

pci_add_device being solely used by trusted domains, I think it would
be fine to require that the domain doesn't poke the PCI config space
until the call to pci_add_device has finished. Else it's likely to get
inconsistent results, or mess up with the device state.

In any case, such addition needs some kind of reasoning added to the
commit message if it's really required.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Fri Oct 15 10:24:48 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 10:24:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.210231.367001 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbKOK-0004bm-JL; Fri, 15 Oct 2021 10:24:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 210231.367001; Fri, 15 Oct 2021 10:24:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbKOK-0004be-E3; Fri, 15 Oct 2021 10:24:44 +0000
Received: by outflank-mailman (input) for mailman id 210231;
 Fri, 15 Oct 2021 10:24:43 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=FGCa=PD=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mbKOJ-0004bY-K8
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 10:24:43 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id fd2c9cbf-2ab2-416a-9da9-df8a4a09945e;
 Fri, 15 Oct 2021 10:24:42 +0000 (UTC)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2171.outbound.protection.outlook.com [104.47.17.171])
 (Using TLS) by relay.mimecast.com with ESMTP id
 de-mta-39-2t0HzOcVN3uj0z4zGjg1YA-1; Fri, 15 Oct 2021 12:24:40 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB4848.eurprd04.prod.outlook.com (2603:10a6:803:55::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.17; Fri, 15 Oct
 2021 10:24:39 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.017; Fri, 15 Oct 2021
 10:24:39 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM7PR02CA0005.eurprd02.prod.outlook.com (2603:10a6:20b:100::15) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.17 via Frontend
 Transport; Fri, 15 Oct 2021 10:24:38 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fd2c9cbf-2ab2-416a-9da9-df8a4a09945e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634293481;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=uakifc3B+A4nUiv6FULm9YM+JIQkKazVNPdzUhN8Vbs=;
	b=nustPMwWXWffTXVNY4ElJez9Fwy1bDNbhApjGIu+Ml3VXjZrTiKcOz1NmnrAti69vaH1am
	hmGZu3lMrjfJR54Blo0BB4Y2W0/elXRym1BNgKlqE0jyRjS/fFAPScN/Fd9Z0q2yauQNai
	zn7I5gCrtN9b/6O7y03udyxIvXHkg1c=
X-MC-Unique: 2t0HzOcVN3uj0z4zGjg1YA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=BKPGNzxjSK4M6HABDlL9g8F7KxM7Cpul4JmoQf2/5uVUPiq0c5+Vhv0h0X+J2I+Hk65HTcbjS1cqM7VedFOu6zNGnHrvb/tGfV14IjMoqWQYPJ1fD8YQV8uKuDIif3w7CZMRP560hvmjnCDSTZhY8p90Ah22A2Z4WrJQaG54OlBb9F+pgEc4+9uAC7nazzsF/ROXYhpiSbuWZ+aHUY0IJ4n4aEw47N37WXJUxhRcAZJbDorfi72crR/lXz/clnmH0u5WVqlVzYuRRStM/kPrkRh0X8LNFhtFQm/QesT+XDR3c4u9aZPQFE5zCRphaTBVTpuLDayRuaCfqnHPg3XnXw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=2VarEX2s5xZSbwsgpL/6lT5onBvZTkTqxCqU4i8R1Js=;
 b=Rt9Hy2T8DrkCvUf3FFzFiaL0MaE8CvRlaN8kRqaozSvX0BF0lX+39sJUiP87NgZogFJg/G+Am1Neb37fGrrU8xpNtms0T4DkM56J+FQnNOMo3zE4fjOGODPdbOnDfZx+qy1b9rsH+z9BlPnVytgTxMzDyjEHBkIuVL1oBKsknq2ciilyRu5UA8gmKGHIloWS741j6Rgurp8W0LI9gX/2D4ZJFXR0e9RDDTrqzhwkdYdPU+EDmwLSutXZQL7sU5+JpVXb724Ckywc3nhSEtx7ysyrwPoEjQY0JQ+24O3jXLjUX9d4kXMavlILZHjNuA8Njzc380PZ0jaD1ebbocIu4A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: citrix.com; dkim=none (message not signed)
 header.d=none;citrix.com; dmarc=none action=none header.from=suse.com;
Subject: Re: [PATCH v6 2/3] xen/arm: Enable the existing x86 virtual PCI
 support for ARM.
To: Bertrand Marquis <Bertrand.Marquis@arm.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>,
 Ian Jackson <iwj@xenproject.org>, Rahul Singh <Rahul.Singh@arm.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
 Paul Durrant <paul@xen.org>,
 Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <cover.1634221830.git.bertrand.marquis@arm.com>
 <396b08e2598cf0338e0c7f4ad3cd5cb66db89224.1634221830.git.bertrand.marquis@arm.com>
 <YWk8uP/YuSee1MfG@MacBook-Air-de-Roger.local>
 <CD9B29B0-31FD-4E09-93E3-7124C724BC23@arm.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <1c298c02-5791-8935-f996-516da2409f24@suse.com>
Date: Fri, 15 Oct 2021 12:24:35 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <CD9B29B0-31FD-4E09-93E3-7124C724BC23@arm.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM7PR02CA0005.eurprd02.prod.outlook.com
 (2603:10a6:20b:100::15) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 076b5dbe-0b06-4566-590b-08d98fc5fe5f
X-MS-TrafficTypeDiagnostic: VI1PR04MB4848:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB484869F7B5ACAFC41DB05069B3B99@VI1PR04MB4848.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	YXK6adMDjutzQLvzpj8jJzQ2U6X/QGBcgT5Uf2ZUkd1Xw6RLu9upCBLrH5HSGhqv+Dubg5M/QcQgjJoxjousASmwSrUuhKpw8VghG/eDFGWIbRK9ADsnRpRe/kbC8cQtHP0A9/ceqesOCUx46+hKLvdwDOyAZG/iaXztaAMvHMxZvmXC/2aPG7PwV//C95tap55MfhxzxC6oJX/7nM/+7l377p6LL7SvyJy6+MDrnXw1eOgSFoKM6lG1KV8GXQw6bc4CkiXadmr1d3L+AzJFInpoTdAfFst26R0ZOmC9A1ZciKWMqoHGLfLXY+eIwSCZEAQ7QwkTac0TH8EXvRdlshH0rk8hqalP5gel4vQON4MhbrmLyq01T7RIRk2kEj69eR1C76ZZ6mRlq/53h2wtUP+d9Oi8AmU5YcYr0Db6RSu9VzSNzpvs4LeWsoVsT8QSlutvfwaUcSDTQ7Bys3b7Ol5lBJ1MYimQHcio9C1t2UYdOKxhhG+uHXuKeoxS7Nb13dffMdxbpwmwFDGJEyOWSny4COvTW2nqw7bne24CA53miZsBGdGcQSIEkYJWYoD+0FTebHc0rty7+F7pzUH0d8JJx/HykvfNo8wiGBwhCxNyt+YhdaA6jI9Ixj65KjDSgOzuos7NCUpPABoO5BzqYdAGq8URRkcYDMkNdx199BHcMUQzypRvBfaIk2jaVJM1dTDnympsZaJeTzuf4qozDb3qufhnBpH/APR2Ql+WSFis9Zr4wWNF4DwTVuzekzvmNTbg/sG4FNCR707Wo8CGJ8QPXOnvhnI9owpLJ8tGbSWIwVA+LD6w8IXHGa/kb1M7mmwcORWwCivF7CZ44hC+OdK8Gb3tMOLhItE9V1B6ZZQ=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(16576012)(54906003)(53546011)(316002)(966005)(956004)(86362001)(31696002)(8676002)(26005)(31686004)(508600001)(6486002)(7416002)(8936002)(6666004)(38100700002)(36756003)(66556008)(66946007)(2616005)(186003)(5660300002)(4326008)(66476007)(2906002)(83380400001)(6916009)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?v2M67bcSkC2vJPsZFyv83DZqaR4YFIf6bxntrX9UpZ8nQkM2sFAh8QSHdIoS?=
 =?us-ascii?Q?XKmgQN+KJ1wwhO7+opE6PU6IvT7UCLFxF8nVkEKkAWi7pZ3RJU1We/yzY1Hw?=
 =?us-ascii?Q?TUeh8kcr542jo5mH2Sj5GNmjArFyy0FAEHAPg2oBP46cQa+2CwlqoTkU51sM?=
 =?us-ascii?Q?yQpP0u9ryXZip0HF+3tDQjRlg1aJu3afw9ERMYU6KSgi0lsMsiQhs8WSTrWw?=
 =?us-ascii?Q?PjpKZzPRVhWvlLZRzkxETHTOBy6+XORzDghukSqAI8pEavgqhTQ7NRlR8WuI?=
 =?us-ascii?Q?3g+3Xvvf7xpFr16hyftXcwhv8I7EjB4j9uhf4OAPtDfGgbapUBgMLDyw526l?=
 =?us-ascii?Q?QTLMvxjCZ3sbjnYhkR4QYwMpmr9SnrU6qAFDCwzvFP9fMisXj+CYyIBZI2i8?=
 =?us-ascii?Q?bEzjhwM9aU6DTqHlDjegeYwkn7kcRlF9aduyrcyZe1kWGtfxiMjKZj2m4gde?=
 =?us-ascii?Q?GgnMOh6+sWiGgY+hy88FbXDsCqKUWrqL8LmEEQ3SYF4EaiX6TKNq6WeVWL/w?=
 =?us-ascii?Q?RwLs7ySjshWQsxiCpS5iAoWJRMVg/X2DuiLS6khsV/RrzBUdseecnmM8B7KD?=
 =?us-ascii?Q?c9U5V3ErR5sKtdvv8lYuQXEWRSUiPmhCBatMJ6hWghg78/tzuZun3AuhYBD4?=
 =?us-ascii?Q?jJSVQrrRMqm4cDk3i5i9M90blMI40xEnpvQGR/17X3KHPYvANMulKGvUmgdL?=
 =?us-ascii?Q?CbV3MB87g38dF5rCkbK/2TFKAHIE8XUwR0+/o5+I6Ao5sVRYffYVJkqmw0ZR?=
 =?us-ascii?Q?lGwpLcCXO0kgCyPt6i7zERZ56wAQxpkAQL/R0koJHIn/uHt03J+CwXYZVe3A?=
 =?us-ascii?Q?0HstH+/0T9xCr7rLR6kvb+N3EjCDWoSKpOFg1ae7MS7t01EyVjMTFPONr907?=
 =?us-ascii?Q?PvkDBjBygiGjlg5aFrLK/9E+lzXK//bg+O1tnFUptlcwcg1TIYTP9Bc/D3Lz?=
 =?us-ascii?Q?fzaHKh9+24Q52ynhilcH4fB0dXEkWIUGFvPdW/fSYZidXNVexSD4gGfoRA2n?=
 =?us-ascii?Q?c2HBhFWATvpC+ky9d1iVw+r6thDwhLEofp5U9bn8yCDi8tcBHvqaCo2l3fvq?=
 =?us-ascii?Q?UUnaypVyiXeFw6EC1Zm6iUssMXFTmJxn3vdTZNK30YYi3O+IDK3gplsDTn/U?=
 =?us-ascii?Q?q0+UgerteV26/+NrMfdSjip/e06Aupd97rXNzKbM6M8MUbD0ca3z2ronLL6N?=
 =?us-ascii?Q?AhvEwFvYyZncw7tA96aVi5cdTHlfcR+nQ8Z1alZYFm5PuUd/sxtuBP18iH6j?=
 =?us-ascii?Q?0l/BgGrpN1KX8ymPjC3y/D4RB8Onb5tzh1n3V3jh0ke29TBODSA0a/ckI0ov?=
 =?us-ascii?Q?/X02znoDcjFASzGJ0p5vKKpn?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 076b5dbe-0b06-4566-590b-08d98fc5fe5f
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2021 10:24:38.9636
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: TQNsGhMnJEYSdVQ8vm33VAxBa40MkuQlJtbJdBvgFYEQXeyoIg0Uy31oeStBhDDQ82FVRDn8yU0sJG5sbWr0jg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4848

On 15.10.2021 11:52, Bertrand Marquis wrote:
>> On 15 Oct 2021, at 09:32, Roger Pau Monn=C3=A9 <roger.pau@citrix.com> wr=
ote:
>> On Thu, Oct 14, 2021 at 03:49:50PM +0100, Bertrand Marquis wrote:
>>> @@ -752,6 +752,19 @@ int pci_add_device(u16 seg, u8 bus, u8 devfn,
>>>
>>>     check_pdev(pdev);
>>>
>>> +#ifdef CONFIG_ARM
>>> +    /*
>>> +     * On ARM PCI devices discovery will be done by Dom0. Add vpci han=
dler when
>>> +     * Dom0 inform XEN to add the PCI devices in XEN.
>>> +     */
>>> +    ret =3D vpci_add_handlers(pdev);
>>> +    if ( ret )
>>> +    {
>>> +        printk(XENLOG_ERR "Setup of vPCI failed: %d\n", ret);
>>> +        goto out;
>>> +    }
>>> +#endif
>>
>> I think vpci_add_handlers should be called after checking that
>> pdev->domain is !=3D NULL, so I would move this chunk a bit below.
>=20
> On arm this would prevent the dom0less use case or to have the PCI
> bus enumerated from an other domain.
> @oleksandr: can you comment on this one, you might have a better
> answer than me on this ?

Well, without Xen doing the enumeration, some other entity would need
to do so, including the reporting to Xen. Obviously without a Dom0 it
would be ambiguous which domain to assign the device to; perhaps it
should be the caller in this case? That would make that caller domain
a pseudo-hwdom though, as far as PCI is concerned, which may not be
desirable according to my (limited) understanding of dom0less.

>>> @@ -784,6 +797,9 @@ out:
>>>                    &PCI_SBDF(seg, bus, slot, func));
>>>         }
>>>     }
>>> +    else if ( pdev )
>>> +        pci_cleanup_msi(pdev);
>>
>> I'm slightly lost at why you add this chunk, is this strictly related
>> to the patch?
>=20
> This was discussed a lot in previous version of the patch and
> requested by Stefano. The idea here is that as soon as handlers
> are added some bits might be modified in the PCI config space
> leading possibly to msi interrupts. So it is safer to cleanup on the
> error path. For references please see discussion on v4 and v5 where
> this was actually added (to much references as the discussion was
> long so here [1] and [2] are the patchwork thread).
>=20
> [1] https://patchwork.kernel.org/project/xen-devel/patch/9bdca2cda5d2e83f=
94dc2423e55714273539760a.1633540842.git.rahul.singh@arm.com/
> [2] https://patchwork.kernel.org/project/xen-devel/patch/f093de681c2560a7=
196895bcd666ef8840885c1d.1633340795.git.rahul.singh@arm.com/

The addition of this call has repeatedly raised questions. This is a
good indication that sufficient discussion thereof has been lacking
from the patch description.

Jan



From xen-devel-bounces@lists.xenproject.org Fri Oct 15 10:31:29 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 10:31:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.210238.367012 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbKUm-000627-98; Fri, 15 Oct 2021 10:31:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 210238.367012; Fri, 15 Oct 2021 10:31:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbKUm-000620-5c; Fri, 15 Oct 2021 10:31:24 +0000
Received: by outflank-mailman (input) for mailman id 210238;
 Fri, 15 Oct 2021 10:31:23 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Fqmt=PD=arm.com=Bertrand.Marquis@srs-us1.protection.inumbo.net>)
 id 1mbKUl-00061u-7p
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 10:31:23 +0000
Received: from EUR02-AM5-obe.outbound.protection.outlook.com (unknown
 [2a01:111:f400:fe07::625])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id ec829e53-f65f-4f37-9af9-8ace4576edc5;
 Fri, 15 Oct 2021 10:31:22 +0000 (UTC)
Received: from DB3PR06CA0014.eurprd06.prod.outlook.com (2603:10a6:8:1::27) by
 AM0PR08MB3764.eurprd08.prod.outlook.com (2603:10a6:208:ff::21) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4587.24; Fri, 15 Oct 2021 10:31:19 +0000
Received: from DB5EUR03FT042.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:8:1:cafe::a9) by DB3PR06CA0014.outlook.office365.com
 (2603:10a6:8:1::27) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15 via Frontend
 Transport; Fri, 15 Oct 2021 10:31:19 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT042.mail.protection.outlook.com (10.152.21.123) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.15 via Frontend Transport; Fri, 15 Oct 2021 10:31:18 +0000
Received: ("Tessian outbound d5def7722ff7:v103");
 Fri, 15 Oct 2021 10:31:18 +0000
Received: from 7e3cc61e7a8f.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 E942B3FE-F1FD-4428-9F0E-C4C7FAEEC4B8.1; 
 Fri, 15 Oct 2021 10:31:13 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 7e3cc61e7a8f.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 15 Oct 2021 10:31:13 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com (2603:10a6:4:74::9)
 by DB7PR08MB3561.eurprd08.prod.outlook.com (2603:10a6:10:42::20) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.17; Fri, 15 Oct
 2021 10:31:11 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955]) by DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955%4]) with mapi id 15.20.4587.031; Fri, 15 Oct 2021
 10:31:11 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ec829e53-f65f-4f37-9af9-8ace4576edc5
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=fIWSyGfbbxj4QSzA8fWcb9mpKcyMiqPrc5/Z1rq0sfo=;
 b=JV0lRAR9/RBGqoTEyhXwagOStUbKoxKzW1jU1olSJMBk7HSqwzhnrwVHxAsqejiRsube3eVGnATpFCa80/C4+09TIctHPHnYDQ256146UMSAdpqMwUSsiUStcs1qkL4Ls05Pp6xaG3jZh9CG4nJ1poghlAUo63NPIcxmMpWpYFo=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: b85bcb25d5ceae19
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Fdg7L8nANXVFXbscVGgXsrX6ghKb23tMsGRqvfI3GWgNyQMRDPVjV6ZXPOEIovXEkuapj8/9jeOOa0ScsA1WFgkFQ293l8TTtCIyy5IJA8JXLVx2GJCwTG2nflIqck8UlGzFa2kAIudNpfjqm0UtktRBPgekt2hkEFC5iIUIBBw46ACl4zoAE1W5MZ0fWwtEpSdRTxPNj1hKvaqRHMHr7JRt4IZd7Co/aCpiOyn/Vhs5FUYdFVC5LF5P+iJp0X6XuXYIkyfrINIne94HIT2ZPEvLlR98dj01uoj/Q4UISzgMsNNHx6od+6Iyg3pWWL5SEjzxSi7cTddjGSuMnCC5Eg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=fIWSyGfbbxj4QSzA8fWcb9mpKcyMiqPrc5/Z1rq0sfo=;
 b=BgguVq6W2r/iYuWNkhvHSQgMAMHbRgN3y6E1vVrdZRLO5o7ph9D7SIecV+ubjmNCFmrSb56yp+5Cmx0t9tcVyP3TS9FbYA/OoUMjP+I5OS5xNL+ywXY1U8UgwFhDSCNytNCAcbYl7HG+6Cwzr8fgIKgLHq9zUceQnYQD9bCDWcm/b2qQrNiVGJc5Ut9I+rTsnWXhbr0CN2REHFc9+TbenYf5Ca5jDVr+OXiej6btzAUOTTSOaCyLMN6DKmCx582DMk/V/9AFcJeyXeIpE99KtacQjirRWoOjjTTquvohmb0qADGBfDvXFXR466UF5XTaWug2uVJkslaSHWz1XSKpaw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=fIWSyGfbbxj4QSzA8fWcb9mpKcyMiqPrc5/Z1rq0sfo=;
 b=JV0lRAR9/RBGqoTEyhXwagOStUbKoxKzW1jU1olSJMBk7HSqwzhnrwVHxAsqejiRsube3eVGnATpFCa80/C4+09TIctHPHnYDQ256146UMSAdpqMwUSsiUStcs1qkL4Ls05Pp6xaG3jZh9CG4nJ1poghlAUo63NPIcxmMpWpYFo=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>, Ian Jackson
	<iwj@xenproject.org>, Rahul Singh <Rahul.Singh@arm.com>, Stefano Stabellini
	<sstabellini@kernel.org>, Julien Grall <julien@xen.org>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
	Wei Liu <wl@xen.org>, Paul Durrant <paul@xen.org>, Oleksandr Andrushchenko
	<Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH v6 2/3] xen/arm: Enable the existing x86 virtual PCI
 support for ARM.
Thread-Topic: [PATCH v6 2/3] xen/arm: Enable the existing x86 virtual PCI
 support for ARM.
Thread-Index: AQHXwQrjS6mPrKT7Q06z3N66FcsDAKvTvGsAgAAWOICAAAekAIAAAy0A
Date: Fri, 15 Oct 2021 10:31:11 +0000
Message-ID: <59D40B50-EB18-40C3-ACCE-C727A4A7B1B6@arm.com>
References: <cover.1634221830.git.bertrand.marquis@arm.com>
 <396b08e2598cf0338e0c7f4ad3cd5cb66db89224.1634221830.git.bertrand.marquis@arm.com>
 <YWk8uP/YuSee1MfG@MacBook-Air-de-Roger.local>
 <CD9B29B0-31FD-4E09-93E3-7124C724BC23@arm.com>
 <YWlVxAPcuWVHtxsR@MacBook-Air-de-Roger.local>
In-Reply-To: <YWlVxAPcuWVHtxsR@MacBook-Air-de-Roger.local>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3654.120.0.1.13)
Authentication-Results-Original: citrix.com; dkim=none (message not signed)
 header.d=none;citrix.com; dmarc=none action=none header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: befe4c0f-e0e8-4942-616e-08d98fc6ecdc
x-ms-traffictypediagnostic: DB7PR08MB3561:|AM0PR08MB3764:
x-ms-exchange-transport-forked: True
X-Microsoft-Antispam-PRVS:
	<AM0PR08MB37649F9BD0C374DDBC57309A9DB99@AM0PR08MB3764.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:9508;OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 J76Sskwzc/TX1BxzcjSxQJEtymuFnmIqVWnYDib7W9WOqURrmU2c3Eh+ZxRxAM+6Ixe0cmK5nfAg5ws1skYUXHZo5LpWI1sR13sCvSaydIE4RrpACHGYKvJvvi6k33pkpUGi9Q7ds7ClhAbJiOY94GwB8gSJLGub9fGbRAjSV9Bor5FUYTHrWPg2rDM/t1OGojKOsS4ehZyN8wXTmfwOUnWDAbt7OpFAbYmB7WwBzre3BkvBZjD3GROCBp80mQqX3gK24Gi9mRp0lWhjBPy5WinRx+VtikESu2JBfrWJGLXBDw8J6mu6gPD38/jYq+LaBB+5tClcsoRRPW4uaz8VhtF5/tHYpN55E+EUyZjfjvAhDA2XFdLWB5dcaSTivrNYop6DadTrCuhm3lotKuRpX4XSaLwEGAkDz8/lp4c0i2L1tDjbtP+PTXHlvcmGs567jm/QhaXafR+gaBbvzwXsRgj7drycYwAZjIZiFLuGtnThbc+BCRuFcN4gBnM2tnIMq0/r0odmvG05dOuDSvsdXhfCxFkUzBb+RNbr7fZF1Mc9psFrFrq8Cjumoo2wIhp4a00ktoUeIxWE9gHD6e+fgO6Y0oVXj+nV6Hndi9dcErPNSq2ngrtPTelPgSCpvLiqrlT+f2WxmUSnB0IGmjbXXjERVPsWTSS+lbX+De1Vtu6buQm2zqhcG5yaedSgMYaE/653WrPmeVGB5292re/7w7pl0K4lk8I4qV9mGEkriCgfe/yTUXruDsocTQ2a0zlD
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB6PR0801MB2024.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(8936002)(7416002)(6916009)(36756003)(6512007)(66946007)(66556008)(66476007)(38070700005)(64756008)(66446008)(186003)(122000001)(26005)(6486002)(86362001)(2906002)(76116006)(38100700002)(91956017)(5660300002)(54906003)(8676002)(53546011)(508600001)(316002)(83380400001)(6506007)(33656002)(2616005)(4326008)(71200400001)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-ID: <2AC9878C6C0D4A45A110CD923B7B66E8@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3561
Original-Authentication-Results: citrix.com; dkim=none (message not signed)
 header.d=none;citrix.com; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT042.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	62f761e8-7943-4090-0147-08d98fc6e856
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	dxBhOH/qJGDo5XChKxzQ2mSDMJbj8/8slGmEiB971UF2BnaVaZVcPMDWnL4sqC7UGBSsinYxP+/jKtkyVrF00InzeEFaHHCyvd3RSmsu+gwlKqNTyxag8pwKpfq01jzfgmS004crbf8FPDFLoEORR1dDAODaEDt0i+NCDhnpsVjoDPzyjfXfEz9W23m2RU4wiTBxlmVwXatANMKb+bBOwYgUaHnZMydYib69XGTGX2H50MbgzrtEK7evSubE/RhzNt/7xPm6VUkP30ghlf7ftMaPN2yqxeGAK0uWAsky2LKM6mlwpuNHwIr3Xv3fY+3Vw2YZ0ER9En3DVS1KjnOlx7KsHTIkl6sSpdCgQaS7/smi6EDtGyGPaZhE9v34PeqQ9khx478ersQz8BHvvUnRidhnbNfPRO/W1Lws76A053XXKbdjl74KAzLtOKCuLJZSfOVYF1ec1TJ4eSrdXqE6l0c6DVv5zYS2IeIUqbGxU9QKDl2v1+TRsrU3HBz/Axctc70fZf6ETOmSCPeHAMkbyMVHoZiXPi/6hSfvJLxqsiYGRvfck3YDtL54UisMfcfqdMfkwcfqMNtU9mTZI9W/kT1vtf3sNaW+ovLCBe1HMCfGM/2FSe1z3VL3U2Z7dmU4ZRFTpbkckjHLKc7n4cKsXt5TblrWOnWQOMV1KbxGm9yrW/9i1t5hn94hPujuiuLU/US0LOwcMEjN9qtgNWFyMA==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(82310400003)(2906002)(107886003)(336012)(70586007)(6862004)(8936002)(6506007)(6512007)(70206006)(356005)(47076005)(36860700001)(4326008)(5660300002)(36756003)(26005)(186003)(33656002)(81166007)(316002)(53546011)(86362001)(6486002)(508600001)(54906003)(8676002)(2616005)(83380400001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2021 10:31:18.9688
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: befe4c0f-e0e8-4942-616e-08d98fc6ecdc
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT042.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3764

SGksDQoNCj4gT24gMTUgT2N0IDIwMjEsIGF0IDExOjE5LCBSb2dlciBQYXUgTW9ubsOpIDxyb2dl
ci5wYXVAY2l0cml4LmNvbT4gd3JvdGU6DQo+IA0KPiBPbiBGcmksIE9jdCAxNSwgMjAyMSBhdCAw
OTo1MjoyOEFNICswMDAwLCBCZXJ0cmFuZCBNYXJxdWlzIHdyb3RlOg0KPj4gSGkgUm9nZXIsDQo+
PiANCj4+PiBPbiAxNSBPY3QgMjAyMSwgYXQgMDk6MzIsIFJvZ2VyIFBhdSBNb25uw6kgPHJvZ2Vy
LnBhdUBjaXRyaXguY29tPiB3cm90ZToNCj4+PiANCj4+PiBPbiBUaHUsIE9jdCAxNCwgMjAyMSBh
dCAwMzo0OTo1MFBNICswMTAwLCBCZXJ0cmFuZCBNYXJxdWlzIHdyb3RlOg0KPj4+PiBGcm9tOiBS
YWh1bCBTaW5naCA8cmFodWwuc2luZ2hAYXJtLmNvbT4NCj4+Pj4gZGlmZiAtLWdpdCBhL3hlbi9k
cml2ZXJzL3Bhc3N0aHJvdWdoL3BjaS5jIGIveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvcGNpLmMN
Cj4+Pj4gaW5kZXggM2FhOGMzMTc1Zi4uOGNjNTI5ZWNlYyAxMDA2NDQNCj4+Pj4gLS0tIGEveGVu
L2RyaXZlcnMvcGFzc3Rocm91Z2gvcGNpLmMNCj4+Pj4gKysrIGIveGVuL2RyaXZlcnMvcGFzc3Ro
cm91Z2gvcGNpLmMNCj4+Pj4gQEAgLTY1OCw3ICs2NTgsNyBAQCBpbnQgcGNpX2FkZF9kZXZpY2Uo
dTE2IHNlZywgdTggYnVzLCB1OCBkZXZmbiwNCj4+Pj4gICAgICAgICAgICAgICAgICAgY29uc3Qg
c3RydWN0IHBjaV9kZXZfaW5mbyAqaW5mbywgbm9kZWlkX3Qgbm9kZSkNCj4+Pj4gew0KPj4+PiAg
ICBzdHJ1Y3QgcGNpX3NlZyAqcHNlZzsNCj4+Pj4gLSAgICBzdHJ1Y3QgcGNpX2RldiAqcGRldjsN
Cj4+Pj4gKyAgICBzdHJ1Y3QgcGNpX2RldiAqcGRldiA9IE5VTEw7DQo+Pj4+ICAgIHVuc2lnbmVk
IGludCBzbG90ID0gUENJX1NMT1QoZGV2Zm4pLCBmdW5jID0gUENJX0ZVTkMoZGV2Zm4pOw0KPj4+
PiAgICBjb25zdCBjaGFyICpwZGV2X3R5cGU7DQo+Pj4+ICAgIGludCByZXQ7DQo+Pj4+IEBAIC03
NTIsNiArNzUyLDE5IEBAIGludCBwY2lfYWRkX2RldmljZSh1MTYgc2VnLCB1OCBidXMsIHU4IGRl
dmZuLA0KPj4+PiANCj4+Pj4gICAgY2hlY2tfcGRldihwZGV2KTsNCj4+Pj4gDQo+Pj4+ICsjaWZk
ZWYgQ09ORklHX0FSTQ0KPj4+PiArICAgIC8qDQo+Pj4+ICsgICAgICogT24gQVJNIFBDSSBkZXZp
Y2VzIGRpc2NvdmVyeSB3aWxsIGJlIGRvbmUgYnkgRG9tMC4gQWRkIHZwY2kgaGFuZGxlciB3aGVu
DQo+Pj4+ICsgICAgICogRG9tMCBpbmZvcm0gWEVOIHRvIGFkZCB0aGUgUENJIGRldmljZXMgaW4g
WEVOLg0KPj4+PiArICAgICAqLw0KPj4+PiArICAgIHJldCA9IHZwY2lfYWRkX2hhbmRsZXJzKHBk
ZXYpOw0KPj4+PiArICAgIGlmICggcmV0ICkNCj4+Pj4gKyAgICB7DQo+Pj4+ICsgICAgICAgIHBy
aW50ayhYRU5MT0dfRVJSICJTZXR1cCBvZiB2UENJIGZhaWxlZDogJWRcbiIsIHJldCk7DQo+Pj4+
ICsgICAgICAgIGdvdG8gb3V0Ow0KPj4+PiArICAgIH0NCj4+Pj4gKyNlbmRpZg0KPj4+IA0KPj4+
IEkgdGhpbmsgdnBjaV9hZGRfaGFuZGxlcnMgc2hvdWxkIGJlIGNhbGxlZCBhZnRlciBjaGVja2lu
ZyB0aGF0DQo+Pj4gcGRldi0+ZG9tYWluIGlzICE9IE5VTEwsIHNvIEkgd291bGQgbW92ZSB0aGlz
IGNodW5rIGEgYml0IGJlbG93Lg0KPj4gDQo+PiBPbiBhcm0gdGhpcyB3b3VsZCBwcmV2ZW50IHRo
ZSBkb20wbGVzcyB1c2UgY2FzZSBvciB0byBoYXZlIHRoZSBQQ0kNCj4+IGJ1cyBlbnVtZXJhdGVk
IGZyb20gYW4gb3RoZXIgZG9tYWluLg0KPiANCj4gdnBjaV9hZGRfaGFuZGxlcnMgd2lsbCB0cnkg
dG8gYWNjZXNzIHBkZXYtPmRvbWFpbiwgc28gcGFzc2luZyBhIHBkZXYNCj4gd2l0aG91dCBkb21h
aW4gYmVpbmcgc2V0IGlzIHdyb25nLg0KDQpSaWdodCBhbmQgdGhlIGluaXRpYWwgY29tbWVudCBm
cm9tIFJhaHVsIGluIHRoZSBjb2RlIGlzIHNheWluZyBzby4NCkkgd2lsbCBtb3ZlIHRoZSBibG9j
ayBpbnNpZGUgdGhlIGlmLg0KDQo+IA0KPj4gQG9sZWtzYW5kcjogY2FuIHlvdSBjb21tZW50IG9u
IHRoaXMgb25lLCB5b3UgbWlnaHQgaGF2ZSBhIGJldHRlcg0KPj4gYW5zd2VyIHRoYW4gbWUgb24g
dGhpcyA/DQo+PiANCj4+PiANCj4+Pj4gKw0KPj4+PiAgICByZXQgPSAwOw0KPj4+PiAgICBpZiAo
ICFwZGV2LT5kb21haW4gKQ0KPj4+PiAgICB7DQo+Pj4+IEBAIC03ODQsNiArNzk3LDkgQEAgb3V0
Og0KPj4+PiAgICAgICAgICAgICAgICAgICAmUENJX1NCREYoc2VnLCBidXMsIHNsb3QsIGZ1bmMp
KTsNCj4+Pj4gICAgICAgIH0NCj4+Pj4gICAgfQ0KPj4+PiArICAgIGVsc2UgaWYgKCBwZGV2ICkN
Cj4+Pj4gKyAgICAgICAgcGNpX2NsZWFudXBfbXNpKHBkZXYpOw0KPj4+IA0KPj4+IEknbSBzbGln
aHRseSBsb3N0IGF0IHdoeSB5b3UgYWRkIHRoaXMgY2h1bmssIGlzIHRoaXMgc3RyaWN0bHkgcmVs
YXRlZA0KPj4+IHRvIHRoZSBwYXRjaD8NCj4+IA0KPj4gVGhpcyB3YXMgZGlzY3Vzc2VkIGEgbG90
IGluIHByZXZpb3VzIHZlcnNpb24gb2YgdGhlIHBhdGNoIGFuZA0KPj4gcmVxdWVzdGVkIGJ5IFN0
ZWZhbm8uIFRoZSBpZGVhIGhlcmUgaXMgdGhhdCBhcyBzb29uIGFzIGhhbmRsZXJzDQo+PiBhcmUg
YWRkZWQgc29tZSBiaXRzIG1pZ2h0IGJlIG1vZGlmaWVkIGluIHRoZSBQQ0kgY29uZmlnIHNwYWNl
DQo+PiBsZWFkaW5nIHBvc3NpYmx5IHRvIG1zaSBpbnRlcnJ1cHRzLiBTbyBpdCBpcyBzYWZlciB0
byBjbGVhbnVwIG9uIHRoZQ0KPj4gZXJyb3IgcGF0aC4gRm9yIHJlZmVyZW5jZXMgcGxlYXNlIHNl
ZSBkaXNjdXNzaW9uIG9uIHY0IGFuZCB2NSB3aGVyZQ0KPj4gdGhpcyB3YXMgYWN0dWFsbHkgYWRk
ZWQgKHRvIG11Y2ggcmVmZXJlbmNlcyBhcyB0aGUgZGlzY3Vzc2lvbiB3YXMNCj4+IGxvbmcgc28g
aGVyZSBbMV0gYW5kIFsyXSBhcmUgdGhlIHBhdGNod29yayB0aHJlYWQpLg0KPiANCj4gcGNpX2Fk
ZF9kZXZpY2UgYmVpbmcgc29sZWx5IHVzZWQgYnkgdHJ1c3RlZCBkb21haW5zLCBJIHRoaW5rIGl0
IHdvdWxkDQo+IGJlIGZpbmUgdG8gcmVxdWlyZSB0aGF0IHRoZSBkb21haW4gZG9lc24ndCBwb2tl
IHRoZSBQQ0kgY29uZmlnIHNwYWNlDQo+IHVudGlsIHRoZSBjYWxsIHRvIHBjaV9hZGRfZGV2aWNl
IGhhcyBmaW5pc2hlZC4gRWxzZSBpdCdzIGxpa2VseSB0byBnZXQNCj4gaW5jb25zaXN0ZW50IHJl
c3VsdHMsIG9yIG1lc3MgdXAgd2l0aCB0aGUgZGV2aWNlIHN0YXRlLg0KDQpBY2suDQoNCj4gDQo+
IEluIGFueSBjYXNlLCBzdWNoIGFkZGl0aW9uIG5lZWRzIHNvbWUga2luZCBvZiByZWFzb25pbmcg
YWRkZWQgdG8gdGhlDQo+IGNvbW1pdCBtZXNzYWdlIGlmIGl0J3MgcmVhbGx5IHJlcXVpcmVkLg0K
DQpXaXRoIHRoZSBjb2RlIG1vdmluZyBpbnNpZGUgdGhlIGZvbGxvd2luZyBlbHNlIGFuZCBwY2lf
Y2xlYW51cF9tc2kgYmVpbmcNCmVtcHR5IGZvciBub3cgb24gYXJtLCBJIHdpbGwgcmVtb3ZlIHRo
ZSBwY2lfY2xlYW51cF9tc2kgYXMgaXQgZG9lcyBub3QNCnJlbGF0ZWQgZGlyZWN0bHkgdG8gdGhp
cyBjaGFuZ2UgZm9yIG5vdyBhbmQgbWlnaHQgY2hhbmdlIHRoZSBiZWhhdmlvdXIgb24geDg2Lg0K
DQpJZiB0aGlzIGlzIG5lZWRlZCBhdCBzb21lIHBvaW50IGR1ZSB0byBhcm0sIHRoaXMgd2lsbCBi
ZSBkb25lIG9uY2UgbXNpIHN1cHBvcnQgd2lsbCBiZSBhZGRlZC4NCg0KUmVnYXJkcw0KQmVydHJh
bmQNCg0KPiANCj4gVGhhbmtzLCBSb2dlci4NCg0K


From xen-devel-bounces@lists.xenproject.org Fri Oct 15 10:34:16 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 10:34:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.210245.367023 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbKXW-0006e0-Nj; Fri, 15 Oct 2021 10:34:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 210245.367023; Fri, 15 Oct 2021 10:34:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbKXW-0006dt-K0; Fri, 15 Oct 2021 10:34:14 +0000
Received: by outflank-mailman (input) for mailman id 210245;
 Fri, 15 Oct 2021 10:34:13 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Fqmt=PD=arm.com=Bertrand.Marquis@srs-us1.protection.inumbo.net>)
 id 1mbKXU-0006dl-Tq
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 10:34:12 +0000
Received: from EUR03-AM5-obe.outbound.protection.outlook.com (unknown
 [2a01:111:f400:fe08::60b])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id a98536d8-b8fa-4eec-b97f-576e208de899;
 Fri, 15 Oct 2021 10:34:11 +0000 (UTC)
Received: from AS9PR05CA0057.eurprd05.prod.outlook.com (2603:10a6:20b:489::35)
 by HE1PR0802MB2380.eurprd08.prod.outlook.com (2603:10a6:3:c6::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.25; Fri, 15 Oct
 2021 10:34:05 +0000
Received: from VE1EUR03FT021.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:489:cafe::5) by AS9PR05CA0057.outlook.office365.com
 (2603:10a6:20b:489::35) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16 via Frontend
 Transport; Fri, 15 Oct 2021 10:34:05 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT021.mail.protection.outlook.com (10.152.18.117) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.15 via Frontend Transport; Fri, 15 Oct 2021 10:34:05 +0000
Received: ("Tessian outbound e27daf245730:v103");
 Fri, 15 Oct 2021 10:34:04 +0000
Received: from 4fce7bd9266e.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 4D9101E4-5C64-41F8-96EC-54AE9329E1C0.1; 
 Fri, 15 Oct 2021 10:33:58 +0000
Received: from EUR02-HE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 4fce7bd9266e.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 15 Oct 2021 10:33:58 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com (2603:10a6:4:74::9)
 by DB7PR08MB3561.eurprd08.prod.outlook.com (2603:10a6:10:42::20) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.17; Fri, 15 Oct
 2021 10:33:54 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955]) by DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955%4]) with mapi id 15.20.4587.031; Fri, 15 Oct 2021
 10:33:54 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a98536d8-b8fa-4eec-b97f-576e208de899
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=5eFMa+E8JcpKIaxl768vJ8cp10kxiTSJzeR6Cil4j/I=;
 b=5dMvVjSKcBXugu/4YD8OMJSAWW8skLkfFnOgSUJy+Kcxz+G10Yjp+Tlv9hPSf7NJ2IDZkJ46sAKiF5KqB1uW0RTgcJQm7ZQYLYzr37h35WwyfizAPLv30iXEWUwu3xyAN+Cj9FU17vPfBVjqmWtdn33i/jR/XhKCpBbkIKh7sd8=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 8328fcdafdcb65d0
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=fsRqK49zvyscG3/mZeXzWC2wrz7GCSTXRanGjk4W0LVME/0h4v52fP/ptnhgYXfwuOeYxtD6WUARRZZRDJkzjGniO941zj9zMphjIC5eheS7IE60cwEFwfqosrD46DrDnbgNmpOieJbyLWpkg7a06SyWfVdb5ejkSN9sIY9WFrg5B3h9N+9MSNcrmr4kQ7fRrB6vvRbSkbIiwkXdyXEWQv0FpXnWmKb/F0dgWrUEeyZoXNFyG3zKMkLEyqqqKe/WXutQQBq3DklU6BotuK5+gRewY63b4edoTnXXfLco4jJA2Mn3pahKtOZhOOvp+JzrOZHjE0ugCUPjAL0I0ri1SA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=5eFMa+E8JcpKIaxl768vJ8cp10kxiTSJzeR6Cil4j/I=;
 b=layTUdSJ8fH7u7IoBt8e8b2qt53dUPVaUCHzICYdjUPo2fnGiFneP0fgAY1pVVGLK6K1gcO8SP/Zu4A6K8/A4aAlRPXM4Svj0GGDPtqPTdITzpA+swCDvVT1MFz7Qsck48QRuzTvqHzN1zO+XAGqJnMYtoHGsdvWkXIPnVbHrMC9kf3BS2zmCtPLiaw8TtlH39DUMWX7EGsJGC1unVU3DT99cHBCdg1fYKi1Qbx/TRyEYgVAG05v6muSuF7jn2NxFahc83HQg5oCpouAVa0VCQkZrlk94lmBkHe1i/XTYgkzPFZ6mrZq0J9dNWsAc9BQe+Tkorp8Ptk1TmkCnEnEuw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=5eFMa+E8JcpKIaxl768vJ8cp10kxiTSJzeR6Cil4j/I=;
 b=5dMvVjSKcBXugu/4YD8OMJSAWW8skLkfFnOgSUJy+Kcxz+G10Yjp+Tlv9hPSf7NJ2IDZkJ46sAKiF5KqB1uW0RTgcJQm7ZQYLYzr37h35WwyfizAPLv30iXEWUwu3xyAN+Cj9FU17vPfBVjqmWtdn33i/jR/XhKCpBbkIKh7sd8=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>, Ian Jackson
	<iwj@xenproject.org>, Rahul Singh <Rahul.Singh@arm.com>, Stefano Stabellini
	<sstabellini@kernel.org>, Julien Grall <julien@xen.org>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>, Paul Durrant
	<paul@xen.org>, Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>,
	=?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>
Subject: Re: [PATCH v6 2/3] xen/arm: Enable the existing x86 virtual PCI
 support for ARM.
Thread-Topic: [PATCH v6 2/3] xen/arm: Enable the existing x86 virtual PCI
 support for ARM.
Thread-Index: AQHXwQrjS6mPrKT7Q06z3N66FcsDAKvTvGsAgAAWOICAAAj6gIAAApmA
Date: Fri, 15 Oct 2021 10:33:54 +0000
Message-ID: <BFC005A8-4C72-41C5-93F4-98BB9CBAB198@arm.com>
References: <cover.1634221830.git.bertrand.marquis@arm.com>
 <396b08e2598cf0338e0c7f4ad3cd5cb66db89224.1634221830.git.bertrand.marquis@arm.com>
 <YWk8uP/YuSee1MfG@MacBook-Air-de-Roger.local>
 <CD9B29B0-31FD-4E09-93E3-7124C724BC23@arm.com>
 <1c298c02-5791-8935-f996-516da2409f24@suse.com>
In-Reply-To: <1c298c02-5791-8935-f996-516da2409f24@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3654.120.0.1.13)
Authentication-Results-Original: suse.com; dkim=none (message not signed)
 header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: e77c0b50-7497-473b-07e4-08d98fc7500a
x-ms-traffictypediagnostic: DB7PR08MB3561:|HE1PR0802MB2380:
x-ms-exchange-transport-forked: True
X-Microsoft-Antispam-PRVS:
	<HE1PR0802MB23809E31F41D8CADA940EFB39DB99@HE1PR0802MB2380.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:10000;OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 Egv69TsnhWqxPTQIgROH6yi1dcW4aT4d0bqKddjMWXnXalUR02RW5FzSirPJhcgckOswXoV7nc1/O6edWDwEs1Fz8r+ur0MZJ399zStbM1ELj7e9kKTzdXzRk5okS2deX9lbv2Dxnlfk5rrNG83F/sP4YQaV01LNCaJuW2gO4Po5G5WCFHKAUAyfxeDD5gM1tLt2kp6jOdSIh0WEx9A7FoGdJUWmhH066nBUXAzkhLO5L9TX/5I49ygvhk6de7zvVIUutDUPKaim9iJo9UEtF5/aoHRSkHj+mSYRPh4Hb9P4GMTrcRqLUOQp0tKw1RhTyp2rJTHZNgLAZEk7AybDmz/ilhLhG8tkF+BAC7efjE3ayi6d6ZENjCmdfutaMx+E/z5DANhidwLRKt9duhdH2z5FoMo3Ohbv/aA7/ADTCXEwe+66gb6ecYvGyHbuhCv7KTMHa/EYdNCHUcPl21cy/IiTJWr+4BFj+ueqXpo4Xo+1VkjfFHqiweYctEh4R0fWitKpMyy+6oML693d4jrRBu6bkYyRClbKrspGYayNXlcf6bZus+FTlQFTl1kKJUO5raogw6qzYTuFu16l1Fje17KqUfXCmS2IpJLbAmbgxn2rJIqywajgJyeCW2nIjEcwRjpdC5UOJnT1ZPGjOqda+VYfnDdiFubifhR3xQeP0uY69jkARAcZNlH0e34kM2FtmKmEqS3dpn4uSArqlpx/cf8azOgTUml3W9hEkMuwKNbuJ1SazpriGtBI57fLHXR+0jHAxD5ETFPgwbLS2iRoodt6wLA5s5AtMYAJh6KUS5b9XE7ZVQqXirByitTjSdAl5a2lyTV1TNvd30rEmgRsVM+tR7YHaqlmfMGkRQbEu5c=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB6PR0801MB2024.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(316002)(8676002)(53546011)(508600001)(2616005)(4326008)(33656002)(966005)(71200400001)(54906003)(83380400001)(6506007)(5660300002)(36756003)(6512007)(186003)(66446008)(66946007)(66556008)(66476007)(38070700005)(64756008)(8936002)(7416002)(6916009)(76116006)(6486002)(86362001)(2906002)(38100700002)(91956017)(26005)(122000001)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-ID: <22BE28B286725343822A98DFFC3D3C43@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3561
Original-Authentication-Results: suse.com; dkim=none (message not signed)
 header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT021.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	1b5aaff9-aeea-43da-af59-08d98fc74962
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	O3ApfrqeFGWgezfZNmjuXYCOWouLAslOevN2bICUqHgtPOVo2tya6TkfyNxFv9Cel4hPq5XkCoxD1QnWnDseidO6T1gnqji2WQRyEbeGiKNqZWDw/UQCRXAuQ8mNC7zGvp3/Z4jHp1amZM8KipRvu5r/4QKxXpuXH8iOb/v+fOmlo8swlLo95KD5gSyjjAzQJ05Y4R8AzrD8q8aWxcjfah0sERrrShq3MtaVShfVO80TfsiEIm2FELmEZOA1U70kyL39jjlGskAsN316Ft0iLLGUokOcrboioUyzy5FeDabVIHb5sNbSOflRJYU+AIhx+9HMtdyjYwZHhvM4DLElFQy58vV3OdvRVGvBNEA5wVB6J2jbQe1wZNKdl9iqr8iYtkEoeI8yP4wlZMMHHbdfg8HiNYqUMaNJc6670tI/nK3h93Qmd5SAZFPphhs4oQ5hKztvmhlycQ8V9hdpAbRFK05wD/6/NLIC7kIPbUz8WrXBcm7TwnOXuVe1Yh58UgmDGQuOdzSLF3Q+Dzjf1r+kTLW7dHfYFVad/Y5n9FDW2xXPRDkdMPcrWSpvMGjzIYRWc7LG3pPtvlqmiKrbQxD5/YObx1RYx7kvvfwTvfR0PLBJXR4HIribQGyTbBQPAR8AkGUwYzVS/oiejNmnqDDbmcrptzg5GT1UTBv8OWXRV6PQ0mWzM1D3b8wOO/ADUp4eRB3XmvSEWgNXi8N4cSjQpFDuAt+CLlnA6zdJI4Fc4mMYa6sdR5Z81GxH2O2oW0v91Ab07fiJlnQ+Em5ljLlPs2EQcoJsOBLtnfOEtgj0awtebTOTnFWoVWbAvbeqjelJi1y2fB5xzInomb8z4DVCTw==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(8676002)(6512007)(6862004)(6486002)(2616005)(47076005)(5660300002)(8936002)(81166007)(82310400003)(33656002)(54906003)(36860700001)(508600001)(83380400001)(70586007)(4326008)(36756003)(316002)(186003)(966005)(26005)(107886003)(70206006)(2906002)(6506007)(86362001)(53546011)(356005)(336012);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2021 10:34:05.2664
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: e77c0b50-7497-473b-07e4-08d98fc7500a
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT021.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0802MB2380

DQoNCj4gT24gMTUgT2N0IDIwMjEsIGF0IDExOjI0LCBKYW4gQmV1bGljaCA8amJldWxpY2hAc3Vz
ZS5jb20+IHdyb3RlOg0KPiANCj4gT24gMTUuMTAuMjAyMSAxMTo1MiwgQmVydHJhbmQgTWFycXVp
cyB3cm90ZToNCj4+PiBPbiAxNSBPY3QgMjAyMSwgYXQgMDk6MzIsIFJvZ2VyIFBhdSBNb25uw6kg
PHJvZ2VyLnBhdUBjaXRyaXguY29tPiB3cm90ZToNCj4+PiBPbiBUaHUsIE9jdCAxNCwgMjAyMSBh
dCAwMzo0OTo1MFBNICswMTAwLCBCZXJ0cmFuZCBNYXJxdWlzIHdyb3RlOg0KPj4+PiBAQCAtNzUy
LDYgKzc1MiwxOSBAQCBpbnQgcGNpX2FkZF9kZXZpY2UodTE2IHNlZywgdTggYnVzLCB1OCBkZXZm
biwNCj4+Pj4gDQo+Pj4+ICAgIGNoZWNrX3BkZXYocGRldik7DQo+Pj4+IA0KPj4+PiArI2lmZGVm
IENPTkZJR19BUk0NCj4+Pj4gKyAgICAvKg0KPj4+PiArICAgICAqIE9uIEFSTSBQQ0kgZGV2aWNl
cyBkaXNjb3Zlcnkgd2lsbCBiZSBkb25lIGJ5IERvbTAuIEFkZCB2cGNpIGhhbmRsZXIgd2hlbg0K
Pj4+PiArICAgICAqIERvbTAgaW5mb3JtIFhFTiB0byBhZGQgdGhlIFBDSSBkZXZpY2VzIGluIFhF
Ti4NCj4+Pj4gKyAgICAgKi8NCj4+Pj4gKyAgICByZXQgPSB2cGNpX2FkZF9oYW5kbGVycyhwZGV2
KTsNCj4+Pj4gKyAgICBpZiAoIHJldCApDQo+Pj4+ICsgICAgew0KPj4+PiArICAgICAgICBwcmlu
dGsoWEVOTE9HX0VSUiAiU2V0dXAgb2YgdlBDSSBmYWlsZWQ6ICVkXG4iLCByZXQpOw0KPj4+PiAr
ICAgICAgICBnb3RvIG91dDsNCj4+Pj4gKyAgICB9DQo+Pj4+ICsjZW5kaWYNCj4+PiANCj4+PiBJ
IHRoaW5rIHZwY2lfYWRkX2hhbmRsZXJzIHNob3VsZCBiZSBjYWxsZWQgYWZ0ZXIgY2hlY2tpbmcg
dGhhdA0KPj4+IHBkZXYtPmRvbWFpbiBpcyAhPSBOVUxMLCBzbyBJIHdvdWxkIG1vdmUgdGhpcyBj
aHVuayBhIGJpdCBiZWxvdy4NCj4+IA0KPj4gT24gYXJtIHRoaXMgd291bGQgcHJldmVudCB0aGUg
ZG9tMGxlc3MgdXNlIGNhc2Ugb3IgdG8gaGF2ZSB0aGUgUENJDQo+PiBidXMgZW51bWVyYXRlZCBm
cm9tIGFuIG90aGVyIGRvbWFpbi4NCj4+IEBvbGVrc2FuZHI6IGNhbiB5b3UgY29tbWVudCBvbiB0
aGlzIG9uZSwgeW91IG1pZ2h0IGhhdmUgYSBiZXR0ZXINCj4+IGFuc3dlciB0aGFuIG1lIG9uIHRo
aXMgPw0KPiANCj4gV2VsbCwgd2l0aG91dCBYZW4gZG9pbmcgdGhlIGVudW1lcmF0aW9uLCBzb21l
IG90aGVyIGVudGl0eSB3b3VsZCBuZWVkDQo+IHRvIGRvIHNvLCBpbmNsdWRpbmcgdGhlIHJlcG9y
dGluZyB0byBYZW4uIE9idmlvdXNseSB3aXRob3V0IGEgRG9tMCBpdA0KPiB3b3VsZCBiZSBhbWJp
Z3VvdXMgd2hpY2ggZG9tYWluIHRvIGFzc2lnbiB0aGUgZGV2aWNlIHRvOyBwZXJoYXBzIGl0DQo+
IHNob3VsZCBiZSB0aGUgY2FsbGVyIGluIHRoaXMgY2FzZT8gVGhhdCB3b3VsZCBtYWtlIHRoYXQg
Y2FsbGVyIGRvbWFpbg0KPiBhIHBzZXVkby1od2RvbSB0aG91Z2gsIGFzIGZhciBhcyBQQ0kgaXMg
Y29uY2VybmVkLCB3aGljaCBtYXkgbm90IGJlDQo+IGRlc2lyYWJsZSBhY2NvcmRpbmcgdG8gbXkg
KGxpbWl0ZWQpIHVuZGVyc3RhbmRpbmcgb2YgZG9tMGxlc3MuDQoNClRoaXMgaXMgbm90IHJlYWxs
eSByZWxhdGVkIHRvIHRoaXMgcGF0Y2ggYnV0IHRoZSBwbGFuIGlzIHRoZSBmb2xsb3dpbmc6DQot
IGVudW1lcmF0aW9uIHdvdWxkIGhhdmUgdG8gYmUgZG9uZSBieSB0aGUgZmlybXdhcmUgb3IgYm9v
dCBsb2FkZXIgYmVmb3JlDQotIHhlbiB3aWxsIGhhdmUgc29tZSBjb2RlIHRvIGRldGVjdCBQQ0kg
ZGV2aWNlcw0KLSBkb20wbGVzcyBjYW4gYmUgdXNlZCB0byBhc3NpZ24gUENJIGRldmljZXMgdG8g
Z3Vlc3QNCg0KQW55d2F5IGRvZXMgbm90IGNoYW5nZSB0aGUgZmFjdCB0aGF0IHRoaXMgbXVzdCBi
ZSBjYWxsZWQgd2hlbiBkb21haW4gaXMgbm90IE5VTEwgYW5kIEkgd2lsbCBmaXggdGhhdC4NCg0K
PiANCj4+Pj4gQEAgLTc4NCw2ICs3OTcsOSBAQCBvdXQ6DQo+Pj4+ICAgICAgICAgICAgICAgICAg
ICZQQ0lfU0JERihzZWcsIGJ1cywgc2xvdCwgZnVuYykpOw0KPj4+PiAgICAgICAgfQ0KPj4+PiAg
ICB9DQo+Pj4+ICsgICAgZWxzZSBpZiAoIHBkZXYgKQ0KPj4+PiArICAgICAgICBwY2lfY2xlYW51
cF9tc2kocGRldik7DQo+Pj4gDQo+Pj4gSSdtIHNsaWdodGx5IGxvc3QgYXQgd2h5IHlvdSBhZGQg
dGhpcyBjaHVuaywgaXMgdGhpcyBzdHJpY3RseSByZWxhdGVkDQo+Pj4gdG8gdGhlIHBhdGNoPw0K
Pj4gDQo+PiBUaGlzIHdhcyBkaXNjdXNzZWQgYSBsb3QgaW4gcHJldmlvdXMgdmVyc2lvbiBvZiB0
aGUgcGF0Y2ggYW5kDQo+PiByZXF1ZXN0ZWQgYnkgU3RlZmFuby4gVGhlIGlkZWEgaGVyZSBpcyB0
aGF0IGFzIHNvb24gYXMgaGFuZGxlcnMNCj4+IGFyZSBhZGRlZCBzb21lIGJpdHMgbWlnaHQgYmUg
bW9kaWZpZWQgaW4gdGhlIFBDSSBjb25maWcgc3BhY2UNCj4+IGxlYWRpbmcgcG9zc2libHkgdG8g
bXNpIGludGVycnVwdHMuIFNvIGl0IGlzIHNhZmVyIHRvIGNsZWFudXAgb24gdGhlDQo+PiBlcnJv
ciBwYXRoLiBGb3IgcmVmZXJlbmNlcyBwbGVhc2Ugc2VlIGRpc2N1c3Npb24gb24gdjQgYW5kIHY1
IHdoZXJlDQo+PiB0aGlzIHdhcyBhY3R1YWxseSBhZGRlZCAodG8gbXVjaCByZWZlcmVuY2VzIGFz
IHRoZSBkaXNjdXNzaW9uIHdhcw0KPj4gbG9uZyBzbyBoZXJlIFsxXSBhbmQgWzJdIGFyZSB0aGUg
cGF0Y2h3b3JrIHRocmVhZCkuDQo+PiANCj4+IFsxXSBodHRwczovL3BhdGNod29yay5rZXJuZWwu
b3JnL3Byb2plY3QveGVuLWRldmVsL3BhdGNoLzliZGNhMmNkYTVkMmU4M2Y5NGRjMjQyM2U1NTcx
NDI3MzUzOTc2MGEuMTYzMzU0MDg0Mi5naXQucmFodWwuc2luZ2hAYXJtLmNvbS8NCj4+IFsyXSBo
dHRwczovL3BhdGNod29yay5rZXJuZWwub3JnL3Byb2plY3QveGVuLWRldmVsL3BhdGNoL2YwOTNk
ZTY4MWMyNTYwYTcxOTY4OTViY2Q2NjZlZjg4NDA4ODVjMWQuMTYzMzM0MDc5NS5naXQucmFodWwu
c2luZ2hAYXJtLmNvbS8NCj4gDQo+IFRoZSBhZGRpdGlvbiBvZiB0aGlzIGNhbGwgaGFzIHJlcGVh
dGVkbHkgcmFpc2VkIHF1ZXN0aW9ucy4gVGhpcyBpcyBhDQo+IGdvb2QgaW5kaWNhdGlvbiB0aGF0
IHN1ZmZpY2llbnQgZGlzY3Vzc2lvbiB0aGVyZW9mIGhhcyBiZWVuIGxhY2tpbmcNCj4gZnJvbSB0
aGUgcGF0Y2ggZGVzY3JpcHRpb24uDQoNClllcyBhbmQgSSB3aWxsIHJlbW92ZSBpdCBhcyBpdCBv
bmx5IGltcGFjdHMgeDg2IHJpZ2h0IG5vdy4NCklmIHRoaXMgaXMgbmVlZGVkLCB3ZSB3aWxsIGhh
dmUgdG8gZG8gaXQgd2hpbGUgYWRkaW5nIE1TSSBzdXBwb3J0IG9uIEFybS4NCg0KUmVnYXJkcw0K
QmVydHJhbmQNCg0KPiANCj4gSmFuDQo+IA0KDQo=


From xen-devel-bounces@lists.xenproject.org Fri Oct 15 10:38:28 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 10:38:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.210256.367034 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbKbY-0007MW-En; Fri, 15 Oct 2021 10:38:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 210256.367034; Fri, 15 Oct 2021 10:38:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbKbY-0007MP-A5; Fri, 15 Oct 2021 10:38:24 +0000
Received: by outflank-mailman (input) for mailman id 210256;
 Fri, 15 Oct 2021 10:38:23 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=FGCa=PD=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mbKbX-0007MJ-Qv
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 10:38:23 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id f823604a-943a-4258-a03a-e4e8fe6474d3;
 Fri, 15 Oct 2021 10:38:22 +0000 (UTC)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2171.outbound.protection.outlook.com [104.47.17.171])
 (Using TLS) by relay.mimecast.com with ESMTP id
 de-mta-23-MSBeK08gPT-m0eZJPNvMeA-1; Fri, 15 Oct 2021 12:38:20 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0402MB3533.eurprd04.prod.outlook.com (2603:10a6:803:b::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.22; Fri, 15 Oct
 2021 10:38:19 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.017; Fri, 15 Oct 2021
 10:38:19 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6P193CA0084.EURP193.PROD.OUTLOOK.COM (2603:10a6:209:88::25) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.16 via Frontend Transport; Fri, 15 Oct 2021 10:38:18 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f823604a-943a-4258-a03a-e4e8fe6474d3
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634294301;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=0PRJW0H3ozAjWjSzUkYTXT/qhFFpxaaixVpFzRrqPR4=;
	b=c42Hno6AdHG/JYulzLHpnkUZ9Tg0Ji3Wfx6/bwwEfHKh9aHWt9LFxcrN+2/MKPc/OyZN4T
	I4ZkEwdNxpC4qFWOaLUuCpP8hPA6vdMiHqy35/tojQe2pbuJHQhF7Q3yWRl58n4AXDl2aU
	piHd/FQRv++LnnjGIAubtZqOb7tPP0g=
X-MC-Unique: MSBeK08gPT-m0eZJPNvMeA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=m6mcQAUHBT3fsGFxypMXIp6WIHDT5BmoZWSckuucGslvKfZk1bn9o+OYX+SenmCK0mSvdo9fbVo5PeutpLbOJ60gv7eBEPABr57psRvCSiH5wKI3Utxcc6WMMf0GXSw9H/k5E83Ocd+I11fK+epwLth/0pjm8ez04ff9/jHW8ehhIQEdas2lvZGoUxDg2eBMEXavm9+6rZIiYXDKATtUvE1Jevol7bZd1w7wt8f80StEtUWuld3LFEqs78sw9ZKg4t6T7Pvy0Kfm0X2AYjo+hXLfWhOAMS31v9QWpGkNGLWprIbUFjiGAl25LhRqVTtnQBiHu/bfp+WNx1u1PVnyOQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=0PRJW0H3ozAjWjSzUkYTXT/qhFFpxaaixVpFzRrqPR4=;
 b=OQ958Qn/QZjlAltJuUxwmmF/PK718RGYwXJaFEBjZeJja+iMrsRiin8HqFAnCjlW5r/G8rcx+HeCpi4vyDJMyRRjqvjDCbGs3UE94HBjJJvjDokkCJkCej/obMAeJHUx40hZHDntnMrFkZ7wGoH1ZtarcPjDhX8AR/MgwsPN6pjzRZo1Z2xn1O4Nxmb+nIQT3Pq9ZUUvlQMRHKtSyUONqXToYxAfzGqxfhnsaJkserCSlSZGeHdwMBv0Lbr3LqCIjuoHhMiKW3eYFK6PZeLwiEJU75QgECZohPqkAjigwzRhBa2VmsBcE3bdg3o8ZYZDNrGyQhWoHGiH7Dkou8B2cA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [PATCH v6 2/3] xen/arm: Enable the existing x86 virtual PCI
 support for ARM.
To: Bertrand Marquis <Bertrand.Marquis@arm.com>
Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 "iwj@xenproject.org" <iwj@xenproject.org>, Rahul Singh
 <Rahul.Singh@arm.com>, Stefano Stabellini <sstabellini@kernel.org>,
 Julien Grall <julien@xen.org>, Volodymyr Babchuk
 <Volodymyr_Babchuk@epam.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
 Paul Durrant <paul@xen.org>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <cover.1634221830.git.bertrand.marquis@arm.com>
 <396b08e2598cf0338e0c7f4ad3cd5cb66db89224.1634221830.git.bertrand.marquis@arm.com>
 <f41f59f7-69ed-e2fe-dc17-434b456cf693@suse.com>
 <57A39480-34DF-4BF5-9B0E-802D30F94BBD@arm.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <31419c19-2783-593a-04a9-9b0e1ae101e1@suse.com>
Date: Fri, 15 Oct 2021 12:38:16 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <57A39480-34DF-4BF5-9B0E-802D30F94BBD@arm.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P193CA0084.EURP193.PROD.OUTLOOK.COM
 (2603:10a6:209:88::25) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 43a9e7b6-224e-43d8-31f1-08d98fc7e73e
X-MS-TrafficTypeDiagnostic: VI1PR0402MB3533:
X-Microsoft-Antispam-PRVS:
	<VI1PR0402MB353379B448B68EF8D99894C9B3B99@VI1PR0402MB3533.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:5236;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	25yYNqdpjcpbIQLI/jq9Zo0D0qirpw+ZeJ8Cy8VV61eN3fO7flq2q772dj8iKM6TR/ujARqAbodzzrqMOSQPGzd2M4I9AiYwgCIOkRmqb3opnK3EdneTvod0GONoy1fXU+9Wyx/v839418Kc43C3NDei8STh3/nGgYbWsCJ2W124Vf+okaCbowThvu7pzWUqAhLN7E1E0baTdyAayUF86NRq4Xg8x3UUylNS6YVS/nft14WDKLRjpkjFOAM7eEXJfFwTmhzxhxdSJQU8MzH30vdbNyFI2kcXqJw/N1tbfcALg57fIGvhqTBH8cKsFtZ5JZgsCH/0UgigyEGWIAcN0Ou6UGWbuxegpaqWNt1iIJnXXoDWJ2g7zv/tUIEjOa33NMaiAhlL1oN4KB2X1dTXb/KA0l4U3h8/wn9bpJzqdgLyqorXHx+ETnzZmV+Qy5OjuJE5a6XJBu5MM9zfM8sK911iGdxWWauiCwQC/h4KTTRPDZkswaFxGtWZ9/GjbU+N8Cm+gwsg9Byr9mnVDmVNIgdRY+YooKphDN8qiSZ1vPojDunMcFXisqPY+6xAzbrF9nym3oOtdZ+pD0aEIeirzgpRLVa/tw+NawVQAxXbWgb3m6h22uWwol+yXXIWff0u17ZEgUGmlt5+uAZYRUw/vuGzUioljKxMy7DfzxLWE8+yQP8ni0ioJCswNSzLCAyC5eB3J2SIX8RlwSEA4dO3KvkvVPbGUwCZyLhyrpX87QI=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(508600001)(7416002)(4326008)(66476007)(31686004)(66556008)(8676002)(83380400001)(6916009)(5660300002)(8936002)(6486002)(66946007)(86362001)(38100700002)(31696002)(2616005)(36756003)(2906002)(186003)(53546011)(54906003)(956004)(26005)(16576012)(316002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?bkVoSlR6UkNvU3k1MmZsMTVmc2Z1SWZPaWtBSE9jOExZbCtuempzRUE4bFFv?=
 =?utf-8?B?S2RoY0NNRDF1RzhGRDdsUmRjUWhrQVk3OHNWZ3dHbitqZkV0YStMVHp4RmYz?=
 =?utf-8?B?T0JKc3lhQjBKYTNCcS9wQVh5SThwVmdHUFZYS3V1M2FUUm9OR2JiVDZJT1Nr?=
 =?utf-8?B?dXRYTm0vOTlnNjJQeEw5T0ZTQ0JybzF3Ty9wbk5uUHNYQmVvZEh6VTVUbTlH?=
 =?utf-8?B?elJkUyt1NElHZ08zMkdMVjh4M05GbjkxcE9ad2NzQ2ZNUlg0RExlNXB6Tncr?=
 =?utf-8?B?VHU0c0Z0d3p4TlE1a0M4czEydFlhbnV0eWp6eHFoRzNzTzltU3VhRDkwSC9R?=
 =?utf-8?B?cUp3UmdsV2ZLM2dKTE14eTEyanJYb0RhNEZ6TzVXSDBZbG4yVGlsNEdRUWxv?=
 =?utf-8?B?Y0RZaTdIMkFPaXdJL2w4RUh5ZTEyRDdlVi8rNGphOGRDcWRHNVc1VjVad3lI?=
 =?utf-8?B?ZzRjOGFlUW1CblNJd1FoemF3YnR2My9MbHZiMytwekZwK3dkUE1XbE42SWk5?=
 =?utf-8?B?ejh3bU9BNkRBa0xzcklpL1Z1UFdPUHZSYjhFSE1iN2pZQkpkWkNuNExuaGFD?=
 =?utf-8?B?b29tbG5sZ08rSEFnTmI1cjJuazhNSjFYT0FkclZDMjhrMlhoMUdiYm5xUFVq?=
 =?utf-8?B?T1o2SENVeVBLMUozS2NYeG81OXRBaTlYSDR1UDA3WGdtc1htZkYvdFlVODZa?=
 =?utf-8?B?OE1KQWlRd3hBQlVRRWJ2akhlQ0ViQjlDMkUrOGt3RHdwZmVCbnRsTGdKOWpj?=
 =?utf-8?B?ODNVcTVGVUpPTHdzbjhPcElqTGlFSk1ROWd4VEUzT0VNWktUT3VoMStNYk9H?=
 =?utf-8?B?VHRKRGJzSVhxajZyMzBhM2hqTkhMamhZZlRmcjhSUHduZjhXM2phNS9BdE03?=
 =?utf-8?B?dVRqZ3pNcU9VWFhSTkhIak5kcHcwNU13SHZZT0RWcHI0TGVUVmRZYWFsMGpm?=
 =?utf-8?B?bHM5N0NkOXF0SWY0T2N0dlJoNjJJQUJDSEljVmx6aytZNzNvdHBPKzFsOW93?=
 =?utf-8?B?eGE2VDhybjJXYitnRjBQeE1GRkNMQnFEcnBmNFFEWlAydytxUVNFajRRaVZm?=
 =?utf-8?B?dTNjOG5seDZoSkcxekNjelN2T2Vsckt4bW5JYVNxM0lLVG9xcXRkZnZ4YzVF?=
 =?utf-8?B?bGJlWWdVMi80dWlmT0tMOEUyNkMvcHNCMW1TSWgySEZyQ1NmSm5XN2lBcm9z?=
 =?utf-8?B?dDJhZE1PRkpCYnFaTjVudTR4LzZtLzZKQ2pOOGxibWpQSEU2K3NRTTdVSUVV?=
 =?utf-8?B?ZXJVUjlxVmV1U0hFVXZRYURCbUg4Wi9HeUMwVjRWUitlUUZwejlSSDFpUGdB?=
 =?utf-8?B?a2x6RkdwTzRJcEdlTDUzOENOdzJzNHR3Zi9mUXcxR1QxRlhMOEhMV2MyMTJP?=
 =?utf-8?B?VXpockw4NjlrU1JNZjM5MUllUkNJeTZOMmJzUHNWN3dHSGVLR2xTd2orTXd2?=
 =?utf-8?B?ZHlsZVBrU012aFNkbmxNNlBsaklUZ0pXTzNnNkFvZ05tTzNlbUhsYVN1aDhH?=
 =?utf-8?B?cndYZGliRUFvVW9la2RlTm1YZ3FwVnkvdFFrMDlGODg4SHZpejA4dEY0UjVD?=
 =?utf-8?B?dnE1OEJRTThxRFFUVHhiV3l6bEJRaUtNSjh1c1pBL0poeTRjVklMUU9ZRWZy?=
 =?utf-8?B?aytWMHp2L1RyNUEzUnBLVHF2cEhkY0MyWDV4WGlFVXNqME80djliOElKS2JI?=
 =?utf-8?B?UW8yYXJ4RzFSdDRQOXhxYzJrdWtlMmcvdCtlaTNUTzFVU2dPVVJEaDRlMndB?=
 =?utf-8?Q?Z5zvlaapOTF6HwKtTjetoV6XYAGLdwVKl7lWPyS?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 43a9e7b6-224e-43d8-31f1-08d98fc7e73e
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2021 10:38:19.1352
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: wZxcUa0ni6Sp9UrKKoIv2SYr/9rhLOmYF1x4B58oW/JydTzHW10d0bgeTcaEvPw3hbUg3UOp9xbOcNtZkEPBMg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3533

On 15.10.2021 12:09, Bertrand Marquis wrote:
>> On 15 Oct 2021, at 09:00, Jan Beulich <jbeulich@suse.com> wrote:
>> On 14.10.2021 16:49, Bertrand Marquis wrote:
>>> @@ -752,6 +752,19 @@ int pci_add_device(u16 seg, u8 bus, u8 devfn,
>>>
>>>     check_pdev(pdev);
>>>
>>> +#ifdef CONFIG_ARM
>>> +    /*
>>> +     * On ARM PCI devices discovery will be done by Dom0. Add vpci handler when
>>> +     * Dom0 inform XEN to add the PCI devices in XEN.
>>> +     */
>>> +    ret = vpci_add_handlers(pdev);
>>> +    if ( ret )
>>> +    {
>>> +        printk(XENLOG_ERR "Setup of vPCI failed: %d\n", ret);
>>> +        goto out;
>>> +    }
>>> +#endif
>>> +
>>>     ret = 0;
>>>     if ( !pdev->domain )
>>
>> Elsewhere I did point out that you need to be careful wrt pdev->domain
>> being NULL. As the code in context clearly documents, you're now
>> adding handlers before that field was set. In comments to a prior
>> version I did already suggest to consider placing the new code inside
>> the if() in question (albeit at the time this was mainly to make clear
>> that error cleanup may not fiddle with things not put in place by the
>> iommu_enable_device() alternative path). This would have the further
>> benefit of making is crystal clear that here only handlers for Dom0
>> would get put in place (and hence their installing for DomU-s would
>> need to be looked for elsewhere).
> 
> I asked Oleksandr for confirmation here but on arm there will be 2 other use cases:
> - PCI own by a DomD so device enumeration done from there
> - dom0less with devices detection done inside Xen

Question is whether at this time you mean to handle all these cases.
Installing handlers when device detection happens in Xen might need
to be done differently, for example - e.g. more along the lines of
what x86 PVH Dom0 has done.

Anything you don't mean to handle (and is safe to be left out, i.e.
without breaking existing cases) will want spelling out in the
description.

>>> @@ -784,6 +797,9 @@ out:
>>>                    &PCI_SBDF(seg, bus, slot, func));
>>>         }
>>>     }
>>> +    else if ( pdev )
>>> +        pci_cleanup_msi(pdev);
>>
>> Have you thoroughly checked that this call is benign on x86? There's
>> no wording to that effect in the description afaics, and I can't
>> easily convince myself that it would be correct when the
>> iommu_enable_device() path was taken. (I'm also not going to
>> exclude that it should have been there even prior to your work,
>> albeit then adding this would want to be a separate bugfix patch.)
> 
> This was not in the original serie and requested by Stefano. I must admit
> I am not completely sure on the details here so I am really ok to remove this
> but this would go against what was requested on the previous versions (4 and 5).

I understand this, but a request to add something still requires that
it be checked that the addition can't have bad effects in other cases.
A compromise here (which I wouldn't like very much) might be to add
another #ifdef CONFIG_ARM, solely to leave the existing x86 case
undisturbed. Yet then, with the called function doing nothing on Arm,
not adding the code here might as well be an option (which it looked
like Stefano would be amenable to). A TODO item would then perhaps
best be left here in a comment.

>>> --- a/xen/include/xen/pci.h
>>> +++ b/xen/include/xen/pci.h
>>> @@ -40,6 +40,9 @@
>>> #define PCI_SBDF3(s,b,df) \
>>>     ((pci_sbdf_t){ .sbdf = (((s) & 0xffff) << 16) | PCI_BDF2(b, df) })
>>>
>>> +#define ECAM_BDF(addr)         ( ((addr) & 0x0ffff000) >> 12)
>>> +#define ECAM_REG_OFFSET(addr)  ((addr) & 0x00000fff)
>>
>> The latter is fine to be put here (i.e. FTAOD I'm fine with it
>> staying here). For the former I even question its original placement
>> in asm-x86/pci.h: It's not generally correct as per the PCI spec, as
>> the bus portion of the address can be anywhere from 1 to 8 bits. And
>> in fact there is a reason why this macro was/is used in only a
>> single place, but not e.g. in x86'es handling of physical MCFG. It
>> is merely an implementation choice in vPCI that the entire segment 0
>> has a linear address range covering all 256 buses. Hence I think
>> this wants to move to xen/vpci.h and then perhaps also be named
>> VPCI_ECAM_BDF().
> 
> On previous version it was request to renamed this to ECAM and agreed
> to put is here. Now you want me to rename it to VPCI and move it again.
> I would like to have a confirmation that this is ok and the final move
> if possible.

A final confirmation is, unfortunately, only as final as it can be at
the very moment it is given. It was the MCFG vs ECAM naming discussion
which made me pull out again the section in the spec, reminding me of
aspects I didn't previously take into consideration. I'm sorry for
this, but it's an iterative process on all sides.

So, FTAOD, as a maintainer of this headed I will continue to object to
a non-spec-compliant construct to be put into here. It'll be Roger,
being the vPCI maintainer, to confirm that putting it in xen/vpci.h is
fine.

> Also if I have to do this I will do the same for REG_OFFSET of course.

As said - that one, being in line with the PCI spec, is fine to remain
as and where you have it.

Jan



From xen-devel-bounces@lists.xenproject.org Fri Oct 15 10:41:42 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 10:41:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.210263.367044 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbKea-0000Je-SK; Fri, 15 Oct 2021 10:41:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 210263.367044; Fri, 15 Oct 2021 10:41:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbKea-0000JX-PI; Fri, 15 Oct 2021 10:41:32 +0000
Received: by outflank-mailman (input) for mailman id 210263;
 Fri, 15 Oct 2021 10:41:32 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=FGCa=PD=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mbKeZ-0000JN-V6
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 10:41:31 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 74a0ed4c-2da4-11ec-822d-12813bfff9fa;
 Fri, 15 Oct 2021 10:41:30 +0000 (UTC)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2106.outbound.protection.outlook.com [104.47.17.106])
 (Using TLS) by relay.mimecast.com with ESMTP id
 de-mta-20-aVRJ4kwoNjG2HdeLq6YHrA-1; Fri, 15 Oct 2021 12:41:28 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VE1PR04MB6671.eurprd04.prod.outlook.com (2603:10a6:803:11f::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16; Fri, 15 Oct
 2021 10:41:26 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.017; Fri, 15 Oct 2021
 10:41:26 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6P193CA0041.EURP193.PROD.OUTLOOK.COM (2603:10a6:209:8e::18) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.15 via Frontend Transport; Fri, 15 Oct 2021 10:41:25 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 74a0ed4c-2da4-11ec-822d-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634294489;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=x8OGBE07PelvuHq6WePHCT6UYhKQsplzwayZfVdsyXc=;
	b=RRT8Ym5BNX/yJWx4oqQdHjQi5yA9hZU/uLdUCsYfFfCWZ4HjTgtdxaE+gfi8Opqe3uLrwb
	t4HUxhv2lxlxdidGxMqRX3K1DunaqeQtG/kgBsghAjkTMk+CsT7ZeMCOexaZ8SfYQw8W0K
	wRprLqNPbSmoLrYBBRtj+9M1gzW8l1Q=
X-MC-Unique: aVRJ4kwoNjG2HdeLq6YHrA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=J0c9navOkUScl9KwlSCVd77zbeDK/18QxBeEBsJCRRV5Q/yo66PopJ+qccsk10h+dqXeZmgGOem2rPVhVLydgUOatQ8SjXybVQVrSIvCP1Kf8lW/ynkTgQEY1KX81eFUo3/DAMwP7DGeN5AXGYhGg8IaZghs9EwDnDDcGXZiYFA3e4s4VeHmzIrII9yg57M6GC7O33R52Fw85iwJjIjGwcdpVTMaXEPo77HxTV4pxNTLXe5NrpU7MdnLlzx7M4LoFxFjOf680/hvtiRSZH4PPbCXKKFoMH9mUtHFFKIofnKUigwjdDtYw9U4Mh94lPxmKEi63mWDqoFu6eBah87C6w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=kaoPH3CTf7RBPOU2dtXrvzoOfvYv94QQZDguNdtAm/E=;
 b=MqmK9ulRZ+LYKq7PKoJLOD8wK+cVVie3l9iqB2mkhMa1DoN3+ZPv+vUVJVumHS3mb2O0pjTqiR7RhSaUXFuti4j6r16drJVdyAGzlGZ6nyDdDecBwliB8BOLlebXKxbicUlSt1y8sVHY1yG+3qdOqQ77YUFKB2elR8ubhRfdJQxmZ6kU83lbBN0q7j48T60B53UoERljRwlsjVf9HlR8i9vqNljEgNW8B89jWH9iVoJw7QQGjd0zIdWVCNdMmWS7bC9BC7HBQBZMkaqZKX+sSCWmadRiDUrjC0obH0NR4SUFyUCphZqnPNdStAFH5aLpnk8rDfBpHf2BjWXhEJ5LWA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: citrix.com; dkim=none (message not signed)
 header.d=none;citrix.com; dmarc=none action=none header.from=suse.com;
Subject: Re: [PATCH v6 2/3] xen/arm: Enable the existing x86 virtual PCI
 support for ARM.
To: Bertrand Marquis <Bertrand.Marquis@arm.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>,
 Ian Jackson <iwj@xenproject.org>, Rahul Singh <Rahul.Singh@arm.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
 Paul Durrant <paul@xen.org>,
 Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <cover.1634221830.git.bertrand.marquis@arm.com>
 <396b08e2598cf0338e0c7f4ad3cd5cb66db89224.1634221830.git.bertrand.marquis@arm.com>
 <YWk8uP/YuSee1MfG@MacBook-Air-de-Roger.local>
 <CD9B29B0-31FD-4E09-93E3-7124C724BC23@arm.com>
 <1c298c02-5791-8935-f996-516da2409f24@suse.com>
 <BFC005A8-4C72-41C5-93F4-98BB9CBAB198@arm.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <cd81cc31-617c-c750-01f4-b02bcb9e3a9e@suse.com>
Date: Fri, 15 Oct 2021 12:41:23 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <BFC005A8-4C72-41C5-93F4-98BB9CBAB198@arm.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6P193CA0041.EURP193.PROD.OUTLOOK.COM
 (2603:10a6:209:8e::18) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 97185701-d385-4a64-a0a1-08d98fc85707
X-MS-TrafficTypeDiagnostic: VE1PR04MB6671:
X-Microsoft-Antispam-PRVS:
	<VE1PR04MB6671FF376D26E03D57DE46CEB3B99@VE1PR04MB6671.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	KRvZg1qWr3bp+excY0BUNcmQIgl2YRElOd9K+q4Lg2eyq99T2NdUa1rehX3lr5dkDdWw1tX/toAPElCLLfKzLaU512X2ZMEA3ZMJrLvrQlWFWtADdzMi7lXUsBUhRuVRD1pHBLCHwMuZMYdkGOZFYInxctF8UUtUmHu9aNEC/ftf8J+HF+fv06nvUrm1OvhqKh7eCqzF2AHp76LvDCy05Ie/8kS6PFDsGivcww4ns3KuYqeaXJ5CNtvYPRvA7Tj6tvf34DeCkPLCmCYRgOZzl/r7KN36UXMlHtrXge0eirtF69pbiC6Hqk5//fYsJZLMUJj5dInkzEh6vOqbWxr3hsYE96+SrzGzf2rxLIuaVCx3Ns7zcXFwcMmIBlx0gj5PtlcxS2OWHdphRFuJIHPewQc0mOg+/CErdM3rmN8zQOFYR3pi6O54DkDq94M+E4PeDhJsZSffL88c8U6EmcdG6oiz5tuEK1acBUVQncVwW1vSCFkQZRszECHFrbqck8Xmg6XEKhE676yomLhC7nUpdNDHROBrUrONHXUPKc5NjMEtNgljw5KUmErfVfS5HrZreBSNM6j8paxKM6ReGiXj/0ta/0e44JsOHU1MvtQ4cErQ5xe5i/tqJJ+ns4jxuFkNtYmdKbBKrRI13V+vI7NqMlNE+GQvMA21RO/s3whViC8skcKvmSYtJvbMqMW0ypEVqBoDdEePQ1AJkSoIt69egvpBnQMLwEAPqb3uIwKxxQM=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(5660300002)(66476007)(6916009)(66946007)(8936002)(8676002)(4326008)(31686004)(66556008)(316002)(508600001)(16576012)(6486002)(31696002)(38100700002)(54906003)(83380400001)(26005)(186003)(7416002)(86362001)(36756003)(956004)(2616005)(53546011)(2906002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?NDAMCmGAmZyU7U2+PugEmxZ8aCi+r3a6gXXp3aomKsMHOXvBGoEjBA+2EmVJ?=
 =?us-ascii?Q?/GIagLW8JraWcO/nJlNdeWi6u3XSwuD51LgPo1l5haG3p6LQdTtoSs5jy2mT?=
 =?us-ascii?Q?BIoz297GHoDI98DBiOLDDmKYBv5FA7EgrEEuCKxxk3P+Xzl/32S32BWaT077?=
 =?us-ascii?Q?1sbXSGhuYfSpjb5B2Ukl6XRDak9NccO6cmYEPjOVUThV8+fvaKHSJji1ZJTI?=
 =?us-ascii?Q?b11/xWAm9jDDAeEYzUOEpGjul2PnG4AFGH9NHbBe60/wj3A8BVIn2XwP3CU9?=
 =?us-ascii?Q?FUyGUFCnHNnp97psmNuNmz7xeGHZ+Ae3wYclgxz1S4vZHsaV754/xeDT/jv3?=
 =?us-ascii?Q?z3qx+7MNG30Og8yQTZD8wnxmg9pn27PhFgi8JfGTknTMiYhfahuHxoxXA89m?=
 =?us-ascii?Q?wmIfveWq0ciIo10nS6tSqJEPYU/1ST65Ka9IjIUR43Uj677+tMkvpqHi1mXf?=
 =?us-ascii?Q?h91YBbAdt24pxqCkPwjIUUVx1YGc7Ic//gjcIUjDLeALDRPpJgxhBEkBmtv9?=
 =?us-ascii?Q?FJ5vwZePPBEU1oL9ra0WwtCYDgxe9JAumW+SeyoPN9/WVXzA/prUkPtJXlCk?=
 =?us-ascii?Q?9uVRLR8oRxMXXV9SB7j/58GONNyV8U2/XUkyxlFezqIwf8itl2xqLTpVjl2l?=
 =?us-ascii?Q?vc96vrxbAZmX9+H1o7eExBwlf7Hdlj89xWCMKQ3jMF7bORy6oti7MSNCUMG+?=
 =?us-ascii?Q?Ux9mqwec4/zuJef+Qe113MaZ1lyCD06hFfurn4ISKKwcKU/xoEn2BDffHGDd?=
 =?us-ascii?Q?j7GXPxvaiY+YGMYzUp3QOLG2VGU2kja5w2KX37DpzWayBrvCbg7ddBvRkayf?=
 =?us-ascii?Q?Kq/qJ2y56gdlQPNmmh5n1GYhpEOpHqPro7toQN0yX3AUe5ffhonlCkcqXzhd?=
 =?us-ascii?Q?P3augtiPvfYA6uIogdAPA2qYaw6KI0znwYlL96NQjMXaGdGUK+CNkANQHH2o?=
 =?us-ascii?Q?YzAtVKHhpTwui5Svo+zvW7WpvSWM1adoiKKSOyRbANerJZbNV/IKmBYgUYCw?=
 =?us-ascii?Q?jnnRl3JNPDqvGLpZLl8Sq5MWvnRswjlLSmpKWvLsN7g1bBH8Hr4OaXhVQmBH?=
 =?us-ascii?Q?veQ2NUIs9JiNBUgth1NM+6iO7xhmeaHrVYj6ofktDxrCI+vgFikONWF6n6yZ?=
 =?us-ascii?Q?RA+okoW2qccspKZ40N9Fn6epT8FOYoNVtoVXuni9wyQdO+mb+Dt4IbpgoNvJ?=
 =?us-ascii?Q?2KhyKCbq7RM1f9BH99VpAcM7y3Ivsb7Sn/+JGZ9I8gLxSzr9zLT3ZZT7L/Os?=
 =?us-ascii?Q?Q9ZMCmWyKiWtRQFUGroFbNTbw4VwZEf63MKPIj5sDpjT2NeJm+iIU5KtRr8/?=
 =?us-ascii?Q?D+cM4lR4FIa8Oy+pPzeS+fYe?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 97185701-d385-4a64-a0a1-08d98fc85707
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2021 10:41:26.6994
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: MFUZAWlrlmsP42ko/y3xOL5Y6ziB2iklphfDj3vADWObiVbUZ9jyVxvfkBK0yMBK3x1qwYuFBqBb2mlD9Kn0Yw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6671

On 15.10.2021 12:33, Bertrand Marquis wrote:
>> On 15 Oct 2021, at 11:24, Jan Beulich <jbeulich@suse.com> wrote:
>> On 15.10.2021 11:52, Bertrand Marquis wrote:
>>>> On 15 Oct 2021, at 09:32, Roger Pau Monn=C3=A9 <roger.pau@citrix.com> =
wrote:
>>>> On Thu, Oct 14, 2021 at 03:49:50PM +0100, Bertrand Marquis wrote:
>>>>> @@ -752,6 +752,19 @@ int pci_add_device(u16 seg, u8 bus, u8 devfn,
>>>>>
>>>>>    check_pdev(pdev);
>>>>>
>>>>> +#ifdef CONFIG_ARM
>>>>> +    /*
>>>>> +     * On ARM PCI devices discovery will be done by Dom0. Add vpci h=
andler when
>>>>> +     * Dom0 inform XEN to add the PCI devices in XEN.
>>>>> +     */
>>>>> +    ret =3D vpci_add_handlers(pdev);
>>>>> +    if ( ret )
>>>>> +    {
>>>>> +        printk(XENLOG_ERR "Setup of vPCI failed: %d\n", ret);
>>>>> +        goto out;
>>>>> +    }
>>>>> +#endif
>>>>
>>>> I think vpci_add_handlers should be called after checking that
>>>> pdev->domain is !=3D NULL, so I would move this chunk a bit below.
>>>
>>> On arm this would prevent the dom0less use case or to have the PCI
>>> bus enumerated from an other domain.
>>> @oleksandr: can you comment on this one, you might have a better
>>> answer than me on this ?
>>
>> Well, without Xen doing the enumeration, some other entity would need
>> to do so, including the reporting to Xen. Obviously without a Dom0 it
>> would be ambiguous which domain to assign the device to; perhaps it
>> should be the caller in this case? That would make that caller domain
>> a pseudo-hwdom though, as far as PCI is concerned, which may not be
>> desirable according to my (limited) understanding of dom0less.
>=20
> This is not really related to this patch but the plan is the following:
> - enumeration would have to be done by the firmware or boot loader before
> - xen will have some code to detect PCI devices
> - dom0less can be used to assign PCI devices to guest
>=20
> Anyway does not change the fact that this must be called when domain is
> not NULL and I will fix that.

Since we now all seem to agree that the NULL would have been a problem,
may I ask in how far any of this has actually been tested?

Jan



From xen-devel-bounces@lists.xenproject.org Fri Oct 15 10:49:07 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 10:49:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.210272.367056 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbKlp-00010m-Mc; Fri, 15 Oct 2021 10:49:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 210272.367056; Fri, 15 Oct 2021 10:49:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbKlp-00010f-Iy; Fri, 15 Oct 2021 10:49:01 +0000
Received: by outflank-mailman (input) for mailman id 210272;
 Fri, 15 Oct 2021 10:49:00 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Fqmt=PD=arm.com=Bertrand.Marquis@srs-us1.protection.inumbo.net>)
 id 1mbKlo-00010Z-2h
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 10:49:00 +0000
Received: from EUR01-VE1-obe.outbound.protection.outlook.com (unknown
 [2a01:111:f400:fe1f::631])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 397c752a-c966-4d99-8077-3edafb911e4c;
 Fri, 15 Oct 2021 10:48:58 +0000 (UTC)
Received: from AS8P251CA0014.EURP251.PROD.OUTLOOK.COM (2603:10a6:20b:2f2::13)
 by AM6PR08MB3638.eurprd08.prod.outlook.com (2603:10a6:20b:4b::25)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.25; Fri, 15 Oct
 2021 10:48:55 +0000
Received: from VE1EUR03FT004.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:2f2:cafe::b1) by AS8P251CA0014.outlook.office365.com
 (2603:10a6:20b:2f2::13) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.17 via Frontend
 Transport; Fri, 15 Oct 2021 10:48:55 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT004.mail.protection.outlook.com (10.152.18.106) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.15 via Frontend Transport; Fri, 15 Oct 2021 10:48:55 +0000
Received: ("Tessian outbound 2e7020cc8961:v103");
 Fri, 15 Oct 2021 10:48:54 +0000
Received: from 547183e437cd.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 D61BA5C5-E70F-48D8-BE07-FD7F077CDBDB.1; 
 Fri, 15 Oct 2021 10:48:44 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 547183e437cd.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 15 Oct 2021 10:48:44 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com (2603:10a6:4:74::9)
 by DBAPR08MB5832.eurprd08.prod.outlook.com (2603:10a6:10:1a5::15) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.17; Fri, 15 Oct
 2021 10:48:41 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955]) by DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955%4]) with mapi id 15.20.4587.031; Fri, 15 Oct 2021
 10:48:41 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 397c752a-c966-4d99-8077-3edafb911e4c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=5k/MxR6zlKA0Y4QlMCek+MtrBmbslaomLUm1a9BGVmE=;
 b=pG8tGfQ3xrN2YpD3vCLQKYkyDoj6d7C2yrmMiWVi/+bKRVC8S89ebO37GlIOuIW21obFRZq9Dmx2qhtVeMaUQrWRddhiRYMLIKmPG0nNbVERP+/o8gSuyeDcvqLzPcUE+SPQX3/pi83kd2GMfauuEIoO8y7ZJCg/GBwzfYtmKPk=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: f8a5b23081f44577
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=hkA8VoAkNoAXpTAOEJDzEpqmOfZVg5T1izTASD3PQl6dIVCoSIB0hk4Ld+FNcCpS8u/l6B+cNVbW3XEbgtgBGHY/zfn9qSX+NvxI9I5bUulpESKki0O5n7ITXyHoBhkjS7oTnbGCeH/aQXlOmQ4MWyg3Ct+11BKPb6L209ojifyd43jZCKk3fyQivzbEKYTDLJtWY082p67lDxU/mZ7HiLbIBn6VC6IH//tAWEX+FoIyH64Su+IaVuu3uBFW9dgUINrC64DMixRhgJlJ87ppKICGeVPta0GEklAXQ61b1kJXY7y6FGj+z29aTYuoFrYQ2D7bSCCY5qjaqODYwsHlRA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=5k/MxR6zlKA0Y4QlMCek+MtrBmbslaomLUm1a9BGVmE=;
 b=XV5wqfXFf2EF37HJYfr02AIRLobDjhxfcGPqr3mUEY6oaqRCG8xVUzLYWTQRmS421hxleK8+0V3n4lVuC716NpG+3V3p/uzAWKri2HFFbcUo8YB36UtuWZTWW7mR5E22OYycgSGLopzyK0Q+CKzbjzUW55agUMjgGUUWodmqEAL8jMvk68noU2xtpyguJLyngCaR7Lnqw+JbvfZtnuuAuueiHqjR8RDiZURkcv5PeV7IqXl++VXn++ltEpel/Kz3AOTJZwmZk/gP7+3/oXpvyCNlxsbEIMpLp9HsYwhlM6MDcX+viT4VH56nrVDp0xXdHd7cpqn2eaMxLR9wubnrEw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=5k/MxR6zlKA0Y4QlMCek+MtrBmbslaomLUm1a9BGVmE=;
 b=pG8tGfQ3xrN2YpD3vCLQKYkyDoj6d7C2yrmMiWVi/+bKRVC8S89ebO37GlIOuIW21obFRZq9Dmx2qhtVeMaUQrWRddhiRYMLIKmPG0nNbVERP+/o8gSuyeDcvqLzPcUE+SPQX3/pi83kd2GMfauuEIoO8y7ZJCg/GBwzfYtmKPk=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>, Ian Jackson
	<iwj@xenproject.org>, Rahul Singh <Rahul.Singh@arm.com>, Stefano Stabellini
	<sstabellini@kernel.org>, Julien Grall <julien@xen.org>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>, Paul Durrant
	<paul@xen.org>, Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>,
	=?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>
Subject: Re: [PATCH v6 2/3] xen/arm: Enable the existing x86 virtual PCI
 support for ARM.
Thread-Topic: [PATCH v6 2/3] xen/arm: Enable the existing x86 virtual PCI
 support for ARM.
Thread-Index:
 AQHXwQrjS6mPrKT7Q06z3N66FcsDAKvTvGsAgAAWOICAAAj6gIAAApmAgAACGYCAAAIKgA==
Date: Fri, 15 Oct 2021 10:48:41 +0000
Message-ID: <B57498FA-F205-4DC1-ACE0-414558400293@arm.com>
References: <cover.1634221830.git.bertrand.marquis@arm.com>
 <396b08e2598cf0338e0c7f4ad3cd5cb66db89224.1634221830.git.bertrand.marquis@arm.com>
 <YWk8uP/YuSee1MfG@MacBook-Air-de-Roger.local>
 <CD9B29B0-31FD-4E09-93E3-7124C724BC23@arm.com>
 <1c298c02-5791-8935-f996-516da2409f24@suse.com>
 <BFC005A8-4C72-41C5-93F4-98BB9CBAB198@arm.com>
 <cd81cc31-617c-c750-01f4-b02bcb9e3a9e@suse.com>
In-Reply-To: <cd81cc31-617c-c750-01f4-b02bcb9e3a9e@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3654.120.0.1.13)
Authentication-Results-Original: suse.com; dkim=none (message not signed)
 header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: 14e91714-a797-4ea4-a543-08d98fc96279
x-ms-traffictypediagnostic: DBAPR08MB5832:|AM6PR08MB3638:
x-ms-exchange-transport-forked: True
X-Microsoft-Antispam-PRVS:
	<AM6PR08MB3638A7FD49B52D997F9845219DB99@AM6PR08MB3638.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:10000;OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 Ve17cRra2KjlTVoG4qF2xSI3CwHJFA5cEFRAUM5tyBmfUjONORuySNPn6exk8pPxnC+c+6Sng/eP3Q8tQvmnRPP9Xjrvy30GB7Bzd6X5QpV0HOPXTemx7wxyz2aWZfKkxxr4tRApe0pH2DIXwlg1RLEdGgHDdkHwq58UKX31smYoavLb1NivfhtVLKlHzDx2lHQJAESL8E1OzJ671jHVvHAEJuiw/pXIUOfPcyNGtTx0nNaxQC08By7GnTQiAxkyOMa9xcJsUzJjn9HAptXdYtjqauo5MpeyoVzGW3FKMBEyDS8EpZY6tDpK1llzPoAiz0XP1IzdKe6tL+OvIT/VadSsryJLL3+iSbqstBlRRLiwFzTWY4WidJWDdYmcDx9PvEmcmHTiYkJc7pbVIdksub8vsgYtiZvEcujfkqeoCelegqaczDnlFwJCQLC1No6jymiWuW6U+/o4F2/63LpbXxYuBlacKmniL5VsS21Scg+Mir6bJnYNFyYM17SKCd531nbe27ypunVz7NCWUcVkNOqi+jKShhgC9vQkTFRdfaurVZA4LlaUM/0nmeiyXMqBIO3Y1tqty6wUq9BMilaieh0OHmcdoTIBW+xA7lIAIhNYIGn0QpmprdI/ECCm53D+XnIToUkZUrUse6MA+ei3Tom2jD1HIpKRwI7UyTQ73X+VsdNuC4WTR8JOUVrfhdVcyGadvvvVRPObj5ubr+jaqq5os47guTwhO5+feAo4QjPOKJATKPMWonoMXJJtMTTv
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB6PR0801MB2024.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(6512007)(91956017)(186003)(7416002)(6916009)(76116006)(54906003)(8936002)(2616005)(26005)(2906002)(36756003)(66946007)(316002)(71200400001)(508600001)(38100700002)(83380400001)(5660300002)(66446008)(64756008)(8676002)(4326008)(38070700005)(122000001)(86362001)(6486002)(53546011)(6506007)(66556008)(33656002)(66476007)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-ID: <8F8B9D34940CFB46A2492EAEBEB38038@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR08MB5832
Original-Authentication-Results: suse.com; dkim=none (message not signed)
 header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT004.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	4b221924-adb7-4319-a079-08d98fc95a5a
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	VXqHFn1XZTnS/ZIPwjsP7mFVv17vlJ13ozbN4lnF7lKsD+kZI+Xx1f3dM5wj3xYjXC1xKFJGWDOSpCiqaayi+RVkq1Y6FGOyWDjzAtNcatRzUxL2rEMXvCGjLI074K2Cte9i1hLasRfxmA8DVkZGC19bcggixaxHOGpaDFpUIF50YufLr7+VvwRM/ya6SQS0pEIUrnxp4LGBZgNhScx0QsmMUqUsqgiD4vkewYnHqHFTFt3VWA3sbE3MR2DmRJ1QOnEy4jVaZcFN0pYgfUGi8ZvTA/hKT6smsiOPiv7pRMoL3jp6nRva2D1j2Srdb2Z/DjED2DfnVv8OKSuKQVNPvV/HrHD0HLClj8viEmecQstq6ew493Jog0U13sMCjVV9JhvbfGNM5w1gKxJXfyCxT305XAk+T0nP7q3E9eJQi6LOzZ/eDL/tj56kH1QPSHhk30mcdyR2TxZWHgIJcrxYU/Q0IZt1K41uBsHrcdIo3Qdx2s/uKHdJCN3y7BXehKCt98I5iqkCnYLq9zKhSaHvDPcWuXq73un3F3mN3k5NcPZ2Ahm7dirmnC/HeWs6Qsx2iE3ac/9IrnKu7DS8/f20vpxPlcQZkE7/IiyPCgM5dcjTP9evmPTDaiFTbwfIpWM0E6Dvjp47uBlJBvnCyzjJ9yjUOQnDJiHwq14pmXZaGdUaiN1egGGCjMZBemV/wRuGYTMcA8uH4OZAKPXQwdfUkA==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(6512007)(8676002)(26005)(54906003)(70586007)(336012)(356005)(36860700001)(36756003)(33656002)(6506007)(83380400001)(70206006)(2906002)(107886003)(6862004)(186003)(81166007)(4326008)(6486002)(5660300002)(82310400003)(47076005)(2616005)(8936002)(316002)(86362001)(508600001)(53546011);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2021 10:48:55.1944
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 14e91714-a797-4ea4-a543-08d98fc96279
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT004.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3638

SGkgSmFuLA0KDQo+IE9uIDE1IE9jdCAyMDIxLCBhdCAxMTo0MSwgSmFuIEJldWxpY2ggPGpiZXVs
aWNoQHN1c2UuY29tPiB3cm90ZToNCj4gDQo+IE9uIDE1LjEwLjIwMjEgMTI6MzMsIEJlcnRyYW5k
IE1hcnF1aXMgd3JvdGU6DQo+Pj4gT24gMTUgT2N0IDIwMjEsIGF0IDExOjI0LCBKYW4gQmV1bGlj
aCA8amJldWxpY2hAc3VzZS5jb20+IHdyb3RlOg0KPj4+IE9uIDE1LjEwLjIwMjEgMTE6NTIsIEJl
cnRyYW5kIE1hcnF1aXMgd3JvdGU6DQo+Pj4+PiBPbiAxNSBPY3QgMjAyMSwgYXQgMDk6MzIsIFJv
Z2VyIFBhdSBNb25uw6kgPHJvZ2VyLnBhdUBjaXRyaXguY29tPiB3cm90ZToNCj4+Pj4+IE9uIFRo
dSwgT2N0IDE0LCAyMDIxIGF0IDAzOjQ5OjUwUE0gKzAxMDAsIEJlcnRyYW5kIE1hcnF1aXMgd3Jv
dGU6DQo+Pj4+Pj4gQEAgLTc1Miw2ICs3NTIsMTkgQEAgaW50IHBjaV9hZGRfZGV2aWNlKHUxNiBz
ZWcsIHU4IGJ1cywgdTggZGV2Zm4sDQo+Pj4+Pj4gDQo+Pj4+Pj4gICBjaGVja19wZGV2KHBkZXYp
Ow0KPj4+Pj4+IA0KPj4+Pj4+ICsjaWZkZWYgQ09ORklHX0FSTQ0KPj4+Pj4+ICsgICAgLyoNCj4+
Pj4+PiArICAgICAqIE9uIEFSTSBQQ0kgZGV2aWNlcyBkaXNjb3Zlcnkgd2lsbCBiZSBkb25lIGJ5
IERvbTAuIEFkZCB2cGNpIGhhbmRsZXIgd2hlbg0KPj4+Pj4+ICsgICAgICogRG9tMCBpbmZvcm0g
WEVOIHRvIGFkZCB0aGUgUENJIGRldmljZXMgaW4gWEVOLg0KPj4+Pj4+ICsgICAgICovDQo+Pj4+
Pj4gKyAgICByZXQgPSB2cGNpX2FkZF9oYW5kbGVycyhwZGV2KTsNCj4+Pj4+PiArICAgIGlmICgg
cmV0ICkNCj4+Pj4+PiArICAgIHsNCj4+Pj4+PiArICAgICAgICBwcmludGsoWEVOTE9HX0VSUiAi
U2V0dXAgb2YgdlBDSSBmYWlsZWQ6ICVkXG4iLCByZXQpOw0KPj4+Pj4+ICsgICAgICAgIGdvdG8g
b3V0Ow0KPj4+Pj4+ICsgICAgfQ0KPj4+Pj4+ICsjZW5kaWYNCj4+Pj4+IA0KPj4+Pj4gSSB0aGlu
ayB2cGNpX2FkZF9oYW5kbGVycyBzaG91bGQgYmUgY2FsbGVkIGFmdGVyIGNoZWNraW5nIHRoYXQN
Cj4+Pj4+IHBkZXYtPmRvbWFpbiBpcyAhPSBOVUxMLCBzbyBJIHdvdWxkIG1vdmUgdGhpcyBjaHVu
ayBhIGJpdCBiZWxvdy4NCj4+Pj4gDQo+Pj4+IE9uIGFybSB0aGlzIHdvdWxkIHByZXZlbnQgdGhl
IGRvbTBsZXNzIHVzZSBjYXNlIG9yIHRvIGhhdmUgdGhlIFBDSQ0KPj4+PiBidXMgZW51bWVyYXRl
ZCBmcm9tIGFuIG90aGVyIGRvbWFpbi4NCj4+Pj4gQG9sZWtzYW5kcjogY2FuIHlvdSBjb21tZW50
IG9uIHRoaXMgb25lLCB5b3UgbWlnaHQgaGF2ZSBhIGJldHRlcg0KPj4+PiBhbnN3ZXIgdGhhbiBt
ZSBvbiB0aGlzID8NCj4+PiANCj4+PiBXZWxsLCB3aXRob3V0IFhlbiBkb2luZyB0aGUgZW51bWVy
YXRpb24sIHNvbWUgb3RoZXIgZW50aXR5IHdvdWxkIG5lZWQNCj4+PiB0byBkbyBzbywgaW5jbHVk
aW5nIHRoZSByZXBvcnRpbmcgdG8gWGVuLiBPYnZpb3VzbHkgd2l0aG91dCBhIERvbTAgaXQNCj4+
PiB3b3VsZCBiZSBhbWJpZ3VvdXMgd2hpY2ggZG9tYWluIHRvIGFzc2lnbiB0aGUgZGV2aWNlIHRv
OyBwZXJoYXBzIGl0DQo+Pj4gc2hvdWxkIGJlIHRoZSBjYWxsZXIgaW4gdGhpcyBjYXNlPyBUaGF0
IHdvdWxkIG1ha2UgdGhhdCBjYWxsZXIgZG9tYWluDQo+Pj4gYSBwc2V1ZG8taHdkb20gdGhvdWdo
LCBhcyBmYXIgYXMgUENJIGlzIGNvbmNlcm5lZCwgd2hpY2ggbWF5IG5vdCBiZQ0KPj4+IGRlc2ly
YWJsZSBhY2NvcmRpbmcgdG8gbXkgKGxpbWl0ZWQpIHVuZGVyc3RhbmRpbmcgb2YgZG9tMGxlc3Mu
DQo+PiANCj4+IFRoaXMgaXMgbm90IHJlYWxseSByZWxhdGVkIHRvIHRoaXMgcGF0Y2ggYnV0IHRo
ZSBwbGFuIGlzIHRoZSBmb2xsb3dpbmc6DQo+PiAtIGVudW1lcmF0aW9uIHdvdWxkIGhhdmUgdG8g
YmUgZG9uZSBieSB0aGUgZmlybXdhcmUgb3IgYm9vdCBsb2FkZXIgYmVmb3JlDQo+PiAtIHhlbiB3
aWxsIGhhdmUgc29tZSBjb2RlIHRvIGRldGVjdCBQQ0kgZGV2aWNlcw0KPj4gLSBkb20wbGVzcyBj
YW4gYmUgdXNlZCB0byBhc3NpZ24gUENJIGRldmljZXMgdG8gZ3Vlc3QNCj4+IA0KPj4gQW55d2F5
IGRvZXMgbm90IGNoYW5nZSB0aGUgZmFjdCB0aGF0IHRoaXMgbXVzdCBiZSBjYWxsZWQgd2hlbiBk
b21haW4gaXMNCj4+IG5vdCBOVUxMIGFuZCBJIHdpbGwgZml4IHRoYXQuDQo+IA0KPiBTaW5jZSB3
ZSBub3cgYWxsIHNlZW0gdG8gYWdyZWUgdGhhdCB0aGUgTlVMTCB3b3VsZCBoYXZlIGJlZW4gYSBw
cm9ibGVtLA0KPiBtYXkgSSBhc2sgaW4gaG93IGZhciBhbnkgb2YgdGhpcyBoYXMgYWN0dWFsbHkg
YmVlbiB0ZXN0ZWQ/DQoNCldpdGggdGhlIHdob2xlIHNlcmllIGN1cnJlbnRseSBvbiBnaXRsYWIg
d2UgaGF2ZSBleHRlbnNpdmVseSB0ZXN0ZWQgcGFzc2luZw0KdGhyb3VnaCBQQ0kgZGV2aWNlcyBv
biBBcm0gaW4gc2V2ZXJhbCBjb25maWd1cmF0aW9uIChudW1iZXIgb2YgZGV2aWNlLCBNU0ksDQpN
U0ktWCkgYW5kIGNoZWNrIHRoYXQgUENJIHdhcyBzdGlsbCBmdW5jdGlvbmFsIG9uIHg4Ni4NCg0K
V2l0aCB0aGUgcGF0Y2hlcyBwdXNoZWQgdG8gWGVuIHJpZ2h0IG5vdyBpdCB3YXMgY2hlY2tlZCB0
aGF0Og0KLSB4ZW4gY29tcGlsZXMgcHJvcGVybHkgb24gYXJtMzIsIGFybTY0IGFuZCB4ODYNCi0g
eGVuIGNvbXBpbGVzIHByb3Blcmx5IHdpdGggVlBDSSBhY3RpdmF0ZWQgKHVzaW5nIGEgcGF0Y2gp
IG9uIGFybTMyIGFuZCBhcm02NA0KLSB4ZW4gb24geDg2IGlzIGZ1bmN0aW9ubmFsICh1c2luZyBi
YXNpYyB0ZXN0IG9uIFFFTVUpDQotIHhlbiBvbiBhcm02NCBpcyBmdW5jdGlvbm5hbCAod2l0aCBz
b21lIGV4dGVuc2l2ZSB0ZXN0cyBvbiBkaWZmZXJlbnQgdGFyZ2V0cykNCg0KV2UgYXJlIG9ubHkg
bGFja2luZyBzb21lIGFjdHVhbCB0ZXN0aW5nIG9uIGFybTMyIGludGVybmFsbHkuDQoNClJlZ2Fy
ZHMNCkJlcnRyYW5kDQoNCj4gDQo+IEphbg0KDQo=


From xen-devel-bounces@lists.xenproject.org Fri Oct 15 10:51:33 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 10:51:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.210282.367066 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbKoH-0002Qj-5n; Fri, 15 Oct 2021 10:51:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 210282.367066; Fri, 15 Oct 2021 10:51:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbKoH-0002Qc-2o; Fri, 15 Oct 2021 10:51:33 +0000
Received: by outflank-mailman (input) for mailman id 210282;
 Fri, 15 Oct 2021 10:51:31 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=FGCa=PD=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mbKoF-0002QV-Jm
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 10:51:31 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id da5e81d4-2da5-11ec-822d-12813bfff9fa;
 Fri, 15 Oct 2021 10:51:30 +0000 (UTC)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2110.outbound.protection.outlook.com [104.47.18.110])
 (Using TLS) by relay.mimecast.com with ESMTP id
 de-mta-40-0_RihBxkPia3n_SNu-fpJg-1; Fri, 15 Oct 2021 12:51:28 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB2960.eurprd04.prod.outlook.com (2603:10a6:802:9::11) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.17; Fri, 15 Oct
 2021 10:51:27 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.017; Fri, 15 Oct 2021
 10:51:27 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM7PR02CA0023.eurprd02.prod.outlook.com (2603:10a6:20b:100::33) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15 via Frontend
 Transport; Fri, 15 Oct 2021 10:51:26 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: da5e81d4-2da5-11ec-822d-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634295089;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=WnPy3dVPOs7dEJwR7bfGZBUDz4Gle0WFyFn9nfHv3ck=;
	b=hr4SM9+hvMDwVcHqU2tiyf4DwO4rI7rIYR8gc97FqVaG0mGWMT5c8ZbqNCvawvpOzXip2g
	KgL8AHLF42FffznbwT3DsO0RFFW11Sul/hGuLhos6EIaOJFFD1dJKqU7LEojkFon39V+aM
	/g0ieXVNrL+mjzLEatwJTuSzICAGSdQ=
X-MC-Unique: 0_RihBxkPia3n_SNu-fpJg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=L3U+Sug8qlLC7esk78RjV9VGzYWf6bqeDCJdLC3iJnD3O30SqB4qxMS6zAfdzDhrv07j/MjuK7JCsUhIKRcCdyWoKbwWsiyRuPE19D7gqEiPM7Ux12OEO63q9jqSg+dQRUyfiWZdADszLWiVCFHUPg6ksUN6IBHUsQbxQ6n+kwCE2VI6uIVKTTSiRlBhAy2buEJiK2553KEHyQUDFNQXqcSFPhwJN5hWw/TvpIdcvwOQdgnm0gxw0/fWE/S52zZS0LsJUnM5z/WZSkGiqW6a6TO69LVeDVUDj0fgukDHrlpg+2R9x4YbmdgcTHpcpIyo2Q4anXowhFgSpqn5xGLvoA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Zh+KyPYYRPVpcSZmdGW4byPD700xATPD6CtE1r4R30w=;
 b=cqVGFxTPbtd8cwVX/voqzmW8FyblBV4hx191zbGw54miYvdh9pJbKEkKaiAyhV7ohjUkYbBeey8sWZxVGOQ9Ot+/eMBK25eQ10myLx6do9+yRuXOnF9IMKkE9WE2ltzP+vwsL8+FuiLIELGSpH9ZstSc9PY7/ETjoYEj3dz7Q+EzSMYGoPEo3+bCblXj2xPX40FDP/3CguYWby036y289UE16f9AopGkfDIMIubPhkD8j/rINZ0yRm3LixTp1YVWRzvDMUwtf3Ixjrn5U8GAbdBV4gL3KxFDen4FG45P6/09U36CuoOiTlLr+7jFlAFhcnVHBfVa4uRZDRbqryu1vQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: citrix.com; dkim=none (message not signed)
 header.d=none;citrix.com; dmarc=none action=none header.from=suse.com;
Subject: Re: [PATCH v6 2/3] xen/arm: Enable the existing x86 virtual PCI
 support for ARM.
To: Bertrand Marquis <Bertrand.Marquis@arm.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>,
 Ian Jackson <iwj@xenproject.org>, Rahul Singh <Rahul.Singh@arm.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
 Paul Durrant <paul@xen.org>,
 Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <cover.1634221830.git.bertrand.marquis@arm.com>
 <396b08e2598cf0338e0c7f4ad3cd5cb66db89224.1634221830.git.bertrand.marquis@arm.com>
 <YWk8uP/YuSee1MfG@MacBook-Air-de-Roger.local>
 <CD9B29B0-31FD-4E09-93E3-7124C724BC23@arm.com>
 <1c298c02-5791-8935-f996-516da2409f24@suse.com>
 <BFC005A8-4C72-41C5-93F4-98BB9CBAB198@arm.com>
 <cd81cc31-617c-c750-01f4-b02bcb9e3a9e@suse.com>
 <B57498FA-F205-4DC1-ACE0-414558400293@arm.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <d6c2efde-d22a-4d57-63c3-5522f9485188@suse.com>
Date: Fri, 15 Oct 2021 12:51:24 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <B57498FA-F205-4DC1-ACE0-414558400293@arm.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM7PR02CA0023.eurprd02.prod.outlook.com
 (2603:10a6:20b:100::33) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 972bfa6b-eec4-4b82-ce11-08d98fc9bcf3
X-MS-TrafficTypeDiagnostic: VI1PR04MB2960:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB296024C911C3E31728EE57C7B3B99@VI1PR04MB2960.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	5qwa27TBDjMg+Sj+qgeFGZr2KdXTRZuIQWWPwgY7W/ogalY8DVul6e5m7GxNPkLd523/z9fAe5v42KlT0MfTra6ZM55sBHBpPcjv6tCvroS3q8kKw5vF/DRbYmkwfbYd+dXLn7Kr9SgdGyNwA14Esuz1gaETdhI7NEZF8ShyZW/dcvslMXYF71nJxWxm7wUDGzN9bEmAuN7pspT2Fn0jBgoTLlBhdfno3Md8GsRX1xjcOg7+rPJTrgH5BP7mC2XlMajZYt4Tm/mBAlHDXsU6G2I/LgE8wtrEDMsIOVwOYoxg3ok2xASwQgfZJm+nWGtzbHS6hDXwHrTSYLnoL12dne+WCOQxCsSgtKgyRGO301gqRaEQKck3SCoYFye2Bgm+FBJjY2iPjZQ9GCb0Zv313OfS9anBZXjM7VJ2aSqJM8+Kgj+5KOBFH90of5ihDAWBI3iCkJ2dzgVGNkN/Ea5jgppcDDyU2CFTf08I0YwfUdmiaVBrC7RFylmCyIX9ZKTW0NUi1aPNJso6fxyqM3Pj117XDsfhRKus3JvZ3DI6Lkg0Zk1GSwZ49OpF2shSmV3ZnFJG7UroaxPbCRkF3ZGzO3mxz7Twz4fa6dY5DlcJBQ/iKymBvuJQd31hXi6yjXKxTOhOCgxSMvTWlnix5wmlC9EP7YOJQC5y04GBTFryLvd6mopJ5zQ+YiYbICdobTs46V9RW+pGGBDjs2G/dxrLQdqNtf5HKKy3q7+3GtHs+jY=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(7416002)(38100700002)(8936002)(508600001)(6486002)(66476007)(4326008)(83380400001)(6916009)(2906002)(66946007)(36756003)(66556008)(2616005)(186003)(5660300002)(53546011)(316002)(16576012)(54906003)(8676002)(31696002)(31686004)(26005)(956004)(86362001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?4OqvSPQF2U3+BNXLOk4FBxJ4yEH/ZsGzI9X0dYEKTU9ceYMhSvimkfbk2g+Q?=
 =?us-ascii?Q?sIqLtKSOX1PhzL7T8YmtBHSJug5hnhtumvy89remduCNJHPzKJKVKcXSzU0z?=
 =?us-ascii?Q?tzeko/cPF6+0qOsIXNtdemalP6vgbkPEpCTX3AiBNTIIfgQkdJkDhwNEuGOD?=
 =?us-ascii?Q?mf8VulPzJZRzRQhgX0r9MTqtlSnVQLbkWZqtLKbAv2UK8pb08Jz9Zc5in/di?=
 =?us-ascii?Q?N/o7wma+OalF+zko5R9lVtAhffALwuI8KrZcSNBLSGRwy8egzCpbiNFwTrzV?=
 =?us-ascii?Q?BBZpLasrOTRocfo9vAI2nSlS4MOwroaRCx0iAHSagzeqaR+cEndmnUI98Bxz?=
 =?us-ascii?Q?diO9bE1oaaRHJIbUVp9fbZprLBORLHaF0PpRcc4+cH9TNtTh7fX3r8IQFrcx?=
 =?us-ascii?Q?DtroTgMrS6LK/DfOXVgFGJXzwX6kfecARSw3bAJ7KYVhktD4Dw2FnQtgxXP5?=
 =?us-ascii?Q?Iv0BG94h6ChRL/eK7ogNjsAI5c/wk4SfUzODLQ9ZrMPm8Of6Efsujj7lqoU9?=
 =?us-ascii?Q?TIiQS4CJkTckfoC+z2EefwBwFfz5hsQKlHonWieO2xJth/YYn6A+YWDNQFZz?=
 =?us-ascii?Q?WbBSj6pkoIPPumC4stJmv2Rao/t1ka6TFgZCBpUT6WVV99MaUC+Ia3zuqiSA?=
 =?us-ascii?Q?KXXbMza38OCU64P3w+Gpw/cNmPancnzzmTMttoX8V8lP8iqeP718gsOMwV6M?=
 =?us-ascii?Q?BH7IpViMn4eweNpAhHOPJ2iJXx4Iead9Yqmt5K2B/M37b2ZOKudIPckvt42J?=
 =?us-ascii?Q?MfBY5oxu8CQ1xdZwior/9O99PbAe8KJY1SfDuqcCPZr9VOti8L8/6V3R4F+H?=
 =?us-ascii?Q?eGsf5oDfcLyGhvHWGvru1Q5ZMitobTrpxtw5CP5jJ5H1uIu9GTaHbiqj0acx?=
 =?us-ascii?Q?liYq+lSw1JEUC0DQSjNrx5mCPUrFeuOFTIa4HSpOyFymgezSO++tdpT7ZS32?=
 =?us-ascii?Q?hpNjal18A+YVnkukqqfgjENGx8/K7uPa2q20+4Cfr0tvZoiEg5XNDdb9SXLd?=
 =?us-ascii?Q?7BPA6XDSZueMwnsShGQYv1S8ps97L+8SnRI/gH/yU56Vgr4x+I+BNIMebwtm?=
 =?us-ascii?Q?6pEBVms8p3UfvSiGY4gOQ0HdQ7TM0k7fZQfp3kqwxDqAfxezBITXnpvTMqpw?=
 =?us-ascii?Q?x/9DR2SoHHjqVsPwzb3pUJjhZrMw9QHGcQirIbyeBfoV/LOv76OuvXSVUAqh?=
 =?us-ascii?Q?q/SjB7l7h514LmeHqrA9LXa5DV0u9GhTSwNFvd1jkcRW0hhMl+pNTZvjXFyO?=
 =?us-ascii?Q?wW/GxWpIurVR//GuOLFIUtEjXS69sNr6/VhuFQElUu+Q1JKs80ud8fd2QHNx?=
 =?us-ascii?Q?H3/nEIe3fr+PScMsd96iWkoE?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 972bfa6b-eec4-4b82-ce11-08d98fc9bcf3
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2021 10:51:27.1928
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: AbTGpmcGuPNi96Yo2AicOk4XaV9EpZ1ks6Cl4r1CoMQZW8wCgmZYFMKmdvw4r+NszD6dNBJhQ3vWp5cX2MWENQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB2960

On 15.10.2021 12:48, Bertrand Marquis wrote:
> Hi Jan,
>=20
>> On 15 Oct 2021, at 11:41, Jan Beulich <jbeulich@suse.com> wrote:
>>
>> On 15.10.2021 12:33, Bertrand Marquis wrote:
>>>> On 15 Oct 2021, at 11:24, Jan Beulich <jbeulich@suse.com> wrote:
>>>> On 15.10.2021 11:52, Bertrand Marquis wrote:
>>>>>> On 15 Oct 2021, at 09:32, Roger Pau Monn=C3=A9 <roger.pau@citrix.com=
> wrote:
>>>>>> On Thu, Oct 14, 2021 at 03:49:50PM +0100, Bertrand Marquis wrote:
>>>>>>> @@ -752,6 +752,19 @@ int pci_add_device(u16 seg, u8 bus, u8 devfn,
>>>>>>>
>>>>>>>   check_pdev(pdev);
>>>>>>>
>>>>>>> +#ifdef CONFIG_ARM
>>>>>>> +    /*
>>>>>>> +     * On ARM PCI devices discovery will be done by Dom0. Add vpci=
 handler when
>>>>>>> +     * Dom0 inform XEN to add the PCI devices in XEN.
>>>>>>> +     */
>>>>>>> +    ret =3D vpci_add_handlers(pdev);
>>>>>>> +    if ( ret )
>>>>>>> +    {
>>>>>>> +        printk(XENLOG_ERR "Setup of vPCI failed: %d\n", ret);
>>>>>>> +        goto out;
>>>>>>> +    }
>>>>>>> +#endif
>>>>>>
>>>>>> I think vpci_add_handlers should be called after checking that
>>>>>> pdev->domain is !=3D NULL, so I would move this chunk a bit below.
>>>>>
>>>>> On arm this would prevent the dom0less use case or to have the PCI
>>>>> bus enumerated from an other domain.
>>>>> @oleksandr: can you comment on this one, you might have a better
>>>>> answer than me on this ?
>>>>
>>>> Well, without Xen doing the enumeration, some other entity would need
>>>> to do so, including the reporting to Xen. Obviously without a Dom0 it
>>>> would be ambiguous which domain to assign the device to; perhaps it
>>>> should be the caller in this case? That would make that caller domain
>>>> a pseudo-hwdom though, as far as PCI is concerned, which may not be
>>>> desirable according to my (limited) understanding of dom0less.
>>>
>>> This is not really related to this patch but the plan is the following:
>>> - enumeration would have to be done by the firmware or boot loader befo=
re
>>> - xen will have some code to detect PCI devices
>>> - dom0less can be used to assign PCI devices to guest
>>>
>>> Anyway does not change the fact that this must be called when domain is
>>> not NULL and I will fix that.
>>
>> Since we now all seem to agree that the NULL would have been a problem,
>> may I ask in how far any of this has actually been tested?
>=20
> With the whole serie currently on gitlab we have extensively tested passi=
ng
> through PCI devices on Arm in several configuration (number of device, MS=
I,
> MSI-X) and check that PCI was still functional on x86.
>=20
> With the patches pushed to Xen right now it was checked that:
> - xen compiles properly on arm32, arm64 and x86
> - xen compiles properly with VPCI activated (using a patch) on arm32 and =
arm64
> - xen on x86 is functionnal (using basic test on QEMU)
> - xen on arm64 is functionnal (with some extensive tests on different tar=
gets)

But somehow in the testing done you must have avoided the code path
in question, or else you would have observed a crash.

Jan



From xen-devel-bounces@lists.xenproject.org Fri Oct 15 10:58:49 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 10:58:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.210297.367105 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbKvG-0003Qm-8Y; Fri, 15 Oct 2021 10:58:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 210297.367105; Fri, 15 Oct 2021 10:58:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbKvG-0003Qf-5b; Fri, 15 Oct 2021 10:58:46 +0000
Received: by outflank-mailman (input) for mailman id 210297;
 Fri, 15 Oct 2021 10:58:45 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=KdBF=PD=arm.com=michal.orzel@srs-us1.protection.inumbo.net>)
 id 1mbKvF-0003QZ-B3
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 10:58:45 +0000
Received: from foss.arm.com (unknown [217.140.110.172])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTP
 id 4b6ec0d4-ec01-40a2-8227-39e01ab47c73;
 Fri, 15 Oct 2021 10:58:43 +0000 (UTC)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6329E147A;
 Fri, 15 Oct 2021 03:58:43 -0700 (PDT)
Received: from [10.57.25.205] (unknown [10.57.25.205])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 82AA33F70D;
 Fri, 15 Oct 2021 03:58:41 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4b6ec0d4-ec01-40a2-8227-39e01ab47c73
Subject: Re: [PATCH v6 3/3] arm/libxl: Emulated PCI device tree node in libxl
 [and 1 more messages]
To: Ian Jackson <iwj@xenproject.org>, Julien Grall <julien@xen.org>
Cc: Bertrand Marquis <Bertrand.Marquis@arm.com>,
 xen-devel@lists.xenproject.org, Rahul Singh <rahul.singh@arm.com>,
 Wei Liu <wl@xen.org>, Anthony PERARD <anthony.perard@citrix.com>,
 Juergen Gross <jgross@suse.com>, Stefano Stabellini
 <sstabellini@kernel.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andre Przywara <Andre.Przywara@arm.com>
References: <cover.1633540842.git.rahul.singh@arm.com>
 <b81b5dea800c8fe47071f3dbd20588b1e472fb99.1633540842.git.rahul.singh@arm.com>
 <7bdac405-a889-15e1-be19-5876f7253855@xen.org>
 <24926.53690.621007.507249@mariner.uk.xensource.com>
 <294BE20A-7E45-405C-BC19-C292295E85E3@arm.com>
 <24927.7235.736221.270358@mariner.uk.xensource.com>
 <8A04B9B2-E816-425E-BF1B-5A8B89F8836C@arm.com>
 <cover.1634221830.git.bertrand.marquis@arm.com>
 <fd9c54a381daa52436b0a1b27cf1bba8e7ff9af9.1634221830.git.bertrand.marquis@arm.com>
 <24936.28385.679884.535704@mariner.uk.xensource.com>
 <6f82141c-8a0b-1e30-a996-223f7c0c508d@xen.org>
 <24937.20922.73382.850023@mariner.uk.xensource.com>
From: Michal Orzel <michal.orzel@arm.com>
Message-ID: <56490119-6040-9ab1-aab7-e43975cbb80d@arm.com>
Date: Fri, 15 Oct 2021 12:58:32 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <24937.20922.73382.850023@mariner.uk.xensource.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

Hi,

On 15.10.2021 12:02, Ian Jackson wrote:
> Julien Grall writes ("Re: [PATCH v6 3/3] arm/libxl: Emulated PCI device tree node in libxl [and 1 more messages]"):
>> On 14/10/2021 18:54, Ian Jackson wrote:
> ...
>>> That is, as I understand it on ARM vpci should be enabled if
>>> passthrough is enabled and not otherwise.  That is precisely what
>>> the variable c_info->passthrough is.
>>
>> On Arm, c_info->passthrough is also set when assigning platform devives 
>> (e.g. a non-PCI network card). At least for now, we don't want to create 
>> a node for vCPI in the Device-Tree because we don't enable the 
>> emulation. So...
> 
> Oh.
> 
>>> 3. Now you can use d_config->c_info.passthrough to gate the addition
>>>     of the additional stuff to the DT.  Ie, that is a respin of this
>>>     patch 3/3.
>>
>> ... we will need to check d_config->num_pcidevs for the time being.
> 
> OK.
> 
> Can you leave a comment somewhere (near where c_info.passthrough is
> set) pointing to this use of num_pcidevs ?  That might save someone
> some future confusion.
> 
Here, c_info->passthrough is set to enabled if either d_config->num_pcidevs or
d_config->num_dtdevs is set. Do you think we need to add there additional comment?
If so can you please help with what should I write there?

BTW. None of the patch I'm preparing with regards to this discussion modifies libxl_create
where c_info.passthrough i set. Do you still want me to add some comment there?
> Thanks,
> Ian.
> 
Cheers,
Michal


From xen-devel-bounces@lists.xenproject.org Fri Oct 15 11:05:08 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 11:05:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.210304.367117 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbL1L-0004rK-05; Fri, 15 Oct 2021 11:05:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 210304.367117; Fri, 15 Oct 2021 11:05:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbL1K-0004rD-Sf; Fri, 15 Oct 2021 11:05:02 +0000
Received: by outflank-mailman (input) for mailman id 210304;
 Fri, 15 Oct 2021 11:05:01 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=KdBF=PD=arm.com=michal.orzel@srs-us1.protection.inumbo.net>)
 id 1mbL1J-0004r7-Jp
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 11:05:01 +0000
Received: from foss.arm.com (unknown [217.140.110.172])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTP
 id 5d7e0ca5-4ff3-4a34-8b03-4dedc1e9e31a;
 Fri, 15 Oct 2021 11:05:00 +0000 (UTC)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2140D147A;
 Fri, 15 Oct 2021 04:05:00 -0700 (PDT)
Received: from [10.57.25.205] (unknown [10.57.25.205])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E09233F70D;
 Fri, 15 Oct 2021 04:04:57 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5d7e0ca5-4ff3-4a34-8b03-4dedc1e9e31a
Subject: Re: [PATCH v6 3/3] arm/libxl: Emulated PCI device tree node in libxl
 [and 1 more messages]
From: Michal Orzel <michal.orzel@arm.com>
To: Ian Jackson <iwj@xenproject.org>, Julien Grall <julien@xen.org>
Cc: Bertrand Marquis <Bertrand.Marquis@arm.com>,
 xen-devel@lists.xenproject.org, Rahul Singh <rahul.singh@arm.com>,
 Wei Liu <wl@xen.org>, Anthony PERARD <anthony.perard@citrix.com>,
 Juergen Gross <jgross@suse.com>, Stefano Stabellini
 <sstabellini@kernel.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andre Przywara <Andre.Przywara@arm.com>
References: <cover.1633540842.git.rahul.singh@arm.com>
 <b81b5dea800c8fe47071f3dbd20588b1e472fb99.1633540842.git.rahul.singh@arm.com>
 <7bdac405-a889-15e1-be19-5876f7253855@xen.org>
 <24926.53690.621007.507249@mariner.uk.xensource.com>
 <294BE20A-7E45-405C-BC19-C292295E85E3@arm.com>
 <24927.7235.736221.270358@mariner.uk.xensource.com>
 <8A04B9B2-E816-425E-BF1B-5A8B89F8836C@arm.com>
 <cover.1634221830.git.bertrand.marquis@arm.com>
 <fd9c54a381daa52436b0a1b27cf1bba8e7ff9af9.1634221830.git.bertrand.marquis@arm.com>
 <24936.28385.679884.535704@mariner.uk.xensource.com>
 <6f82141c-8a0b-1e30-a996-223f7c0c508d@xen.org>
 <24937.20922.73382.850023@mariner.uk.xensource.com>
 <56490119-6040-9ab1-aab7-e43975cbb80d@arm.com>
Message-ID: <7212d8c2-f744-7161-f707-2c8f9941a320@arm.com>
Date: Fri, 15 Oct 2021 13:04:49 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <56490119-6040-9ab1-aab7-e43975cbb80d@arm.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit



On 15.10.2021 12:58, Michal Orzel wrote:
> Hi,
> 
> On 15.10.2021 12:02, Ian Jackson wrote:
>> Julien Grall writes ("Re: [PATCH v6 3/3] arm/libxl: Emulated PCI device tree node in libxl [and 1 more messages]"):
>>> On 14/10/2021 18:54, Ian Jackson wrote:
>> ...
>>>> That is, as I understand it on ARM vpci should be enabled if
>>>> passthrough is enabled and not otherwise.  That is precisely what
>>>> the variable c_info->passthrough is.
>>>
>>> On Arm, c_info->passthrough is also set when assigning platform devives 
>>> (e.g. a non-PCI network card). At least for now, we don't want to create 
>>> a node for vCPI in the Device-Tree because we don't enable the 
>>> emulation. So...
>>
>> Oh.
>>
>>>> 3. Now you can use d_config->c_info.passthrough to gate the addition
>>>>     of the additional stuff to the DT.  Ie, that is a respin of this
>>>>     patch 3/3.
>>>
>>> ... we will need to check d_config->num_pcidevs for the time being.
>>
>> OK.
>>
>> Can you leave a comment somewhere (near where c_info.passthrough is
>> set) pointing to this use of num_pcidevs ?  That might save someone
>> some future confusion.
>>
> Here, c_info->passthrough is set to enabled if either d_config->num_pcidevs or
> d_config->num_dtdevs is set. Do you think we need to add there additional comment?
> If so can you please help with what should I write there?
> 
I forgot to add a link:
https://xenbits.xen.org/gitweb/?p=xen.git;a=blob;f=tools/libs/light/libxl_create.c;h=6ebb2bfc768d060fb898619be907fc973375cce5;hb=HEAD#l1099
> BTW. None of the patch I'm preparing with regards to this discussion modifies libxl_create
> where c_info.passthrough i set. Do you still want me to add some comment there?
>> Thanks,
>> Ian.
>>
> Cheers,
> Michal
> 


From xen-devel-bounces@lists.xenproject.org Fri Oct 15 11:08:42 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 11:08:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.210312.367128 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbL4r-0005VK-Fa; Fri, 15 Oct 2021 11:08:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 210312.367128; Fri, 15 Oct 2021 11:08:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbL4r-0005VD-C3; Fri, 15 Oct 2021 11:08:41 +0000
Received: by outflank-mailman (input) for mailman id 210312;
 Fri, 15 Oct 2021 11:08:39 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Fqmt=PD=arm.com=Bertrand.Marquis@srs-us1.protection.inumbo.net>)
 id 1mbL4p-0005V7-Cq
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 11:08:39 +0000
Received: from EUR01-DB5-obe.outbound.protection.outlook.com (unknown
 [40.107.15.74]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 3f5adc2a-2da8-11ec-822d-12813bfff9fa;
 Fri, 15 Oct 2021 11:08:38 +0000 (UTC)
Received: from AS9PR06CA0346.eurprd06.prod.outlook.com (2603:10a6:20b:466::21)
 by AS8PR08MB6280.eurprd08.prod.outlook.com (2603:10a6:20b:29b::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.20; Fri, 15 Oct
 2021 11:08:35 +0000
Received: from AM5EUR03FT034.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:466:cafe::b4) by AS9PR06CA0346.outlook.office365.com
 (2603:10a6:20b:466::21) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15 via Frontend
 Transport; Fri, 15 Oct 2021 11:08:35 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM5EUR03FT034.mail.protection.outlook.com (10.152.16.81) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.15 via Frontend Transport; Fri, 15 Oct 2021 11:08:34 +0000
Received: ("Tessian outbound d5def7722ff7:v103");
 Fri, 15 Oct 2021 11:08:34 +0000
Received: from e373e520409d.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 1DA9D597-A330-472F-860B-0FFC068C92CC.1; 
 Fri, 15 Oct 2021 11:08:25 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id e373e520409d.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 15 Oct 2021 11:08:25 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com (2603:10a6:4:74::9)
 by DB6PR0801MB1752.eurprd08.prod.outlook.com (2603:10a6:4:3c::8) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.17; Fri, 15 Oct
 2021 11:08:21 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955]) by DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955%4]) with mapi id 15.20.4587.031; Fri, 15 Oct 2021
 11:08:21 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3f5adc2a-2da8-11ec-822d-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=g18dRfe0rAE1Y4oxUgsZksq/0G8W9ja82v7QyJjxzbM=;
 b=gio1GJSuz+jmBXBDd/7qFoeGAijV8KLkudUyYB0do0TzO0Pu9MEw0nhlbFSwFbvhg1/aD058sdCJdQAnT+vaEDF+NJTh/LaAJIwpodUqFJ6n5QRLgaXyzEAWu+5uRrQT7wAPraiYpX/49GBwSIn/zm3AMkkXxR6SKpCZxT2FTug=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 4a9ae4a556265743
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=co9QSp+CdEaVmT70fShMNt1pBRK47mIMKIcA//xVYCUAv5mCX8mEcaw9IUaH2j4S22jKcO7DhfmZZN8eRAT35E2y9tFap0mHvYzLgpw5QhLp/eIWrREfSSbB49+hqHSYs/5u7ZWkEH7fUTcJ6RO36ePKrZsy90jeDGRhUFnBc8boBG6lgwvUVFGL//pYR9JSEoFg4ze5MOLYN3w8yyFBMsHisJrou3SRrAKhzGNfNdEOFYINQA8km9GzAGAwBAi5+UazY7KZgGVA9lMyC2RXduMKcZh0NMdBmhEleSzZtFBoY7mkDwOU2W2ktrfkLf1hxjXJHV+nOCWNGL07iSWBhg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=g18dRfe0rAE1Y4oxUgsZksq/0G8W9ja82v7QyJjxzbM=;
 b=hpSGSQTLNeFsP89oX+OT/7tGPiqbfOXibTd4OlAXyAQRbcRpBBjGjQ0rUwJCHdGz2UFgKP1KAfCUr9LETUS4OqYM3LHyO6VdGVKzWDRasE5PsRW6rixQg9M0VP3CYwprSYukq8Vb5j27J2UJ5thkvbmQmcPYhBD27gFAyP4zeyi1l5eN4AgRlZNpG09llop//BwE4AziuFw1C+w2ZxFlDzVCtUoFSopOwh5f+vE5fVBtJDMBh++LiHwS7WM9DyZz82QE4oBMtN/u9KGl/NJVRCw7snYhhwQxv+Q4MVdROP+Zn9Hn0+Ny/CuPyzsSIfPRzMWCeEIM/Bgotk19jbsobw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=g18dRfe0rAE1Y4oxUgsZksq/0G8W9ja82v7QyJjxzbM=;
 b=gio1GJSuz+jmBXBDd/7qFoeGAijV8KLkudUyYB0do0TzO0Pu9MEw0nhlbFSwFbvhg1/aD058sdCJdQAnT+vaEDF+NJTh/LaAJIwpodUqFJ6n5QRLgaXyzEAWu+5uRrQT7wAPraiYpX/49GBwSIn/zm3AMkkXxR6SKpCZxT2FTug=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>, Ian Jackson
	<iwj@xenproject.org>, Rahul Singh <Rahul.Singh@arm.com>, Stefano Stabellini
	<sstabellini@kernel.org>, Julien Grall <julien@xen.org>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>, Paul Durrant
	<paul@xen.org>, Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>,
	=?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>
Subject: Re: [PATCH v6 2/3] xen/arm: Enable the existing x86 virtual PCI
 support for ARM.
Thread-Topic: [PATCH v6 2/3] xen/arm: Enable the existing x86 virtual PCI
 support for ARM.
Thread-Index:
 AQHXwQrjS6mPrKT7Q06z3N66FcsDAKvTvGsAgAAWOICAAAj6gIAAApmAgAACGYCAAAIKgIAAAMIAgAAEuwA=
Date: Fri, 15 Oct 2021 11:08:20 +0000
Message-ID: <E3C75894-EF18-48A8-A5FC-6981DF1DC33E@arm.com>
References: <cover.1634221830.git.bertrand.marquis@arm.com>
 <396b08e2598cf0338e0c7f4ad3cd5cb66db89224.1634221830.git.bertrand.marquis@arm.com>
 <YWk8uP/YuSee1MfG@MacBook-Air-de-Roger.local>
 <CD9B29B0-31FD-4E09-93E3-7124C724BC23@arm.com>
 <1c298c02-5791-8935-f996-516da2409f24@suse.com>
 <BFC005A8-4C72-41C5-93F4-98BB9CBAB198@arm.com>
 <cd81cc31-617c-c750-01f4-b02bcb9e3a9e@suse.com>
 <B57498FA-F205-4DC1-ACE0-414558400293@arm.com>
 <d6c2efde-d22a-4d57-63c3-5522f9485188@suse.com>
In-Reply-To: <d6c2efde-d22a-4d57-63c3-5522f9485188@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3654.120.0.1.13)
Authentication-Results-Original: suse.com; dkim=none (message not signed)
 header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: 59e7537b-c9cf-4a70-5ec5-08d98fcc2178
x-ms-traffictypediagnostic: DB6PR0801MB1752:|AS8PR08MB6280:
x-ms-exchange-transport-forked: True
X-Microsoft-Antispam-PRVS:
	<AS8PR08MB62807204607D7742CC72A9A19DB99@AS8PR08MB6280.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:10000;OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 Jxra1oQlgJqbN7vIQrRMm97ux/+OLiPLQaUDqhL6sEv64whs2XgwTLc4601dH72StD+SVO5WZf+8pSiVNGAfOUVCRyD/fNeLtLhq2mVlKQn201G/DVmv//zueTgKvbAP/cmV6gDx5osSAo9R//k6rWxP6l3AOgbOKgT6nRfaWeCDXVdWpdyFHIiMlsFj8UNVzyzXTwTGIlSmfv8FLJhdojciLlpH3qOUtTCrurucVDnIlueQu7n/yaTDEtFub87lgZyJQBrTZEcZP5S2aTZ4DiNqBUfPOyRw7XJegepYxim9zy9OwxnMFjQyvo1k4XlpLFXWa3cRvQP669NHSFU9lB+t08ZGWoBuHzVsHCNSwLPXha6KUV7COeLykJm5MZM9e1irlyTpoj0S9dC44hsUMkvRjuR0XeGDnW59/JOEZ80E01wW0kt0Eucq00KhCNd/XsAk0X8zbZApsrLdH1KCEc/Mm2KWgVERa9xAxqDvD2oavS70A06hQLdXyryhknmwI6dC5+UBF7L02hsyQuC0OjS1KqfaVWC1WEx9fILOBpAbHaHS8RIcWCwfb3WCwR9J+2IdCumI29GcqrvPoRJtuVr9uhrfI8eZuAtVbLSyPjLxXBf1LuLRtYVlO/QAVSdU6mTmA7uuLD8scBtE2EnzN7gOnoV+hJQlSj/ih1dPKzI+ldG09gKWeYJTGG9lZo3U4pjSvtEBHkk+ImLYLggdOp1TKNwDobt3IvwGURAbXHhW8Qq11pg0rNbQ8oV/vuyf
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB6PR0801MB2024.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(66946007)(26005)(6916009)(2906002)(66446008)(66476007)(186003)(64756008)(66556008)(76116006)(71200400001)(508600001)(2616005)(316002)(91956017)(5660300002)(86362001)(7416002)(8936002)(6486002)(6512007)(4326008)(8676002)(54906003)(38070700005)(36756003)(6506007)(53546011)(122000001)(38100700002)(33656002)(83380400001)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-ID: <4AB6E3D7C702034AA4F36CC924FF7E09@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0801MB1752
Original-Authentication-Results: suse.com; dkim=none (message not signed)
 header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM5EUR03FT034.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	26bf74f6-c487-4f21-c9c1-08d98fcc194a
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	2fh45KG577u5AmffKkEkpg6GqbqxRkoceR1uSDB2+LTtAChaBo9zwOlrL+3fW7q0k3ayMSpdtN5vIPFtuxzw/0+Ky5aVamWULSJytcz38AiePGlor+aMi46Bp4gcMZ8tB10ffM9f7MNhZFcBfvA8Zk6S8glcIyA399j3aycG6rOES3efrUpkW5oxBMR1pJx+EptHID0SlkZkEYXw6jxeeRD7z6RArnhp8ktuvDJ2oKbDP0rQqH5sAfN+BdUb9JvlTSHvcTXJNKGq+5oX6guVQp6G39SWOlI/tuKtm55bBTZFkCkOSr1z8pKgu4x+GGpgCXwWPcdtF001ATolj3kTsCLyFpc7AkygVvZhEiLYjHtgFdVG2E1CD6x8T0zM5JYGHNRuwbL1ImXMGTY88rw95ONSDQNkMgT0eHJXDbXtKXNtsnlCdkJrnB06vQL+Yxk3CYsA7h5kSPpYQWyy7DuBqvaGW+Z9y4rldhG7m7/SdTTVeibJSzN6T+TVaACOdKgmFGK3s5xVQGu/v3Sv1Nz0C8spyEv6US0een6FzBV1S3+c50u1shXkgJ5g/3hNc7Gfzdw4+ImGnD5pJIVe0Z6sIMSTKhsm1aNWJ1C/21z8EutukDgRkcuzpTCEiaN/3jX4rSJdCWu+G7T7SPvm1RBXJhmT124VJgbNnLn6rsvYrYiM7a9T0TV/2scQquLRZWuhsJHMQBvucbVD8mjWk1rVkQ==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(81166007)(356005)(70586007)(70206006)(186003)(508600001)(53546011)(26005)(6862004)(6486002)(4326008)(107886003)(6512007)(54906003)(316002)(5660300002)(82310400003)(336012)(36756003)(47076005)(86362001)(83380400001)(6506007)(2616005)(8676002)(36860700001)(33656002)(2906002)(8936002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2021 11:08:34.6663
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 59e7537b-c9cf-4a70-5ec5-08d98fcc2178
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM5EUR03FT034.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6280

SGksDQoNCj4gT24gMTUgT2N0IDIwMjEsIGF0IDExOjUxLCBKYW4gQmV1bGljaCA8amJldWxpY2hA
c3VzZS5jb20+IHdyb3RlOg0KPiANCj4gT24gMTUuMTAuMjAyMSAxMjo0OCwgQmVydHJhbmQgTWFy
cXVpcyB3cm90ZToNCj4+IEhpIEphbiwNCj4+IA0KPj4+IE9uIDE1IE9jdCAyMDIxLCBhdCAxMTo0
MSwgSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPiB3cm90ZToNCj4+PiANCj4+PiBPbiAx
NS4xMC4yMDIxIDEyOjMzLCBCZXJ0cmFuZCBNYXJxdWlzIHdyb3RlOg0KPj4+Pj4gT24gMTUgT2N0
IDIwMjEsIGF0IDExOjI0LCBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+IHdyb3RlOg0K
Pj4+Pj4gT24gMTUuMTAuMjAyMSAxMTo1MiwgQmVydHJhbmQgTWFycXVpcyB3cm90ZToNCj4+Pj4+
Pj4gT24gMTUgT2N0IDIwMjEsIGF0IDA5OjMyLCBSb2dlciBQYXUgTW9ubsOpIDxyb2dlci5wYXVA
Y2l0cml4LmNvbT4gd3JvdGU6DQo+Pj4+Pj4+IE9uIFRodSwgT2N0IDE0LCAyMDIxIGF0IDAzOjQ5
OjUwUE0gKzAxMDAsIEJlcnRyYW5kIE1hcnF1aXMgd3JvdGU6DQo+Pj4+Pj4+PiBAQCAtNzUyLDYg
Kzc1MiwxOSBAQCBpbnQgcGNpX2FkZF9kZXZpY2UodTE2IHNlZywgdTggYnVzLCB1OCBkZXZmbiwN
Cj4+Pj4+Pj4+IA0KPj4+Pj4+Pj4gIGNoZWNrX3BkZXYocGRldik7DQo+Pj4+Pj4+PiANCj4+Pj4+
Pj4+ICsjaWZkZWYgQ09ORklHX0FSTQ0KPj4+Pj4+Pj4gKyAgICAvKg0KPj4+Pj4+Pj4gKyAgICAg
KiBPbiBBUk0gUENJIGRldmljZXMgZGlzY292ZXJ5IHdpbGwgYmUgZG9uZSBieSBEb20wLiBBZGQg
dnBjaSBoYW5kbGVyIHdoZW4NCj4+Pj4+Pj4+ICsgICAgICogRG9tMCBpbmZvcm0gWEVOIHRvIGFk
ZCB0aGUgUENJIGRldmljZXMgaW4gWEVOLg0KPj4+Pj4+Pj4gKyAgICAgKi8NCj4+Pj4+Pj4+ICsg
ICAgcmV0ID0gdnBjaV9hZGRfaGFuZGxlcnMocGRldik7DQo+Pj4+Pj4+PiArICAgIGlmICggcmV0
ICkNCj4+Pj4+Pj4+ICsgICAgew0KPj4+Pj4+Pj4gKyAgICAgICAgcHJpbnRrKFhFTkxPR19FUlIg
IlNldHVwIG9mIHZQQ0kgZmFpbGVkOiAlZFxuIiwgcmV0KTsNCj4+Pj4+Pj4+ICsgICAgICAgIGdv
dG8gb3V0Ow0KPj4+Pj4+Pj4gKyAgICB9DQo+Pj4+Pj4+PiArI2VuZGlmDQo+Pj4+Pj4+IA0KPj4+
Pj4+PiBJIHRoaW5rIHZwY2lfYWRkX2hhbmRsZXJzIHNob3VsZCBiZSBjYWxsZWQgYWZ0ZXIgY2hl
Y2tpbmcgdGhhdA0KPj4+Pj4+PiBwZGV2LT5kb21haW4gaXMgIT0gTlVMTCwgc28gSSB3b3VsZCBt
b3ZlIHRoaXMgY2h1bmsgYSBiaXQgYmVsb3cuDQo+Pj4+Pj4gDQo+Pj4+Pj4gT24gYXJtIHRoaXMg
d291bGQgcHJldmVudCB0aGUgZG9tMGxlc3MgdXNlIGNhc2Ugb3IgdG8gaGF2ZSB0aGUgUENJDQo+
Pj4+Pj4gYnVzIGVudW1lcmF0ZWQgZnJvbSBhbiBvdGhlciBkb21haW4uDQo+Pj4+Pj4gQG9sZWtz
YW5kcjogY2FuIHlvdSBjb21tZW50IG9uIHRoaXMgb25lLCB5b3UgbWlnaHQgaGF2ZSBhIGJldHRl
cg0KPj4+Pj4+IGFuc3dlciB0aGFuIG1lIG9uIHRoaXMgPw0KPj4+Pj4gDQo+Pj4+PiBXZWxsLCB3
aXRob3V0IFhlbiBkb2luZyB0aGUgZW51bWVyYXRpb24sIHNvbWUgb3RoZXIgZW50aXR5IHdvdWxk
IG5lZWQNCj4+Pj4+IHRvIGRvIHNvLCBpbmNsdWRpbmcgdGhlIHJlcG9ydGluZyB0byBYZW4uIE9i
dmlvdXNseSB3aXRob3V0IGEgRG9tMCBpdA0KPj4+Pj4gd291bGQgYmUgYW1iaWd1b3VzIHdoaWNo
IGRvbWFpbiB0byBhc3NpZ24gdGhlIGRldmljZSB0bzsgcGVyaGFwcyBpdA0KPj4+Pj4gc2hvdWxk
IGJlIHRoZSBjYWxsZXIgaW4gdGhpcyBjYXNlPyBUaGF0IHdvdWxkIG1ha2UgdGhhdCBjYWxsZXIg
ZG9tYWluDQo+Pj4+PiBhIHBzZXVkby1od2RvbSB0aG91Z2gsIGFzIGZhciBhcyBQQ0kgaXMgY29u
Y2VybmVkLCB3aGljaCBtYXkgbm90IGJlDQo+Pj4+PiBkZXNpcmFibGUgYWNjb3JkaW5nIHRvIG15
IChsaW1pdGVkKSB1bmRlcnN0YW5kaW5nIG9mIGRvbTBsZXNzLg0KPj4+PiANCj4+Pj4gVGhpcyBp
cyBub3QgcmVhbGx5IHJlbGF0ZWQgdG8gdGhpcyBwYXRjaCBidXQgdGhlIHBsYW4gaXMgdGhlIGZv
bGxvd2luZzoNCj4+Pj4gLSBlbnVtZXJhdGlvbiB3b3VsZCBoYXZlIHRvIGJlIGRvbmUgYnkgdGhl
IGZpcm13YXJlIG9yIGJvb3QgbG9hZGVyIGJlZm9yZQ0KPj4+PiAtIHhlbiB3aWxsIGhhdmUgc29t
ZSBjb2RlIHRvIGRldGVjdCBQQ0kgZGV2aWNlcw0KPj4+PiAtIGRvbTBsZXNzIGNhbiBiZSB1c2Vk
IHRvIGFzc2lnbiBQQ0kgZGV2aWNlcyB0byBndWVzdA0KPj4+PiANCj4+Pj4gQW55d2F5IGRvZXMg
bm90IGNoYW5nZSB0aGUgZmFjdCB0aGF0IHRoaXMgbXVzdCBiZSBjYWxsZWQgd2hlbiBkb21haW4g
aXMNCj4+Pj4gbm90IE5VTEwgYW5kIEkgd2lsbCBmaXggdGhhdC4NCj4+PiANCj4+PiBTaW5jZSB3
ZSBub3cgYWxsIHNlZW0gdG8gYWdyZWUgdGhhdCB0aGUgTlVMTCB3b3VsZCBoYXZlIGJlZW4gYSBw
cm9ibGVtLA0KPj4+IG1heSBJIGFzayBpbiBob3cgZmFyIGFueSBvZiB0aGlzIGhhcyBhY3R1YWxs
eSBiZWVuIHRlc3RlZD8NCj4+IA0KPj4gV2l0aCB0aGUgd2hvbGUgc2VyaWUgY3VycmVudGx5IG9u
IGdpdGxhYiB3ZSBoYXZlIGV4dGVuc2l2ZWx5IHRlc3RlZCBwYXNzaW5nDQo+PiB0aHJvdWdoIFBD
SSBkZXZpY2VzIG9uIEFybSBpbiBzZXZlcmFsIGNvbmZpZ3VyYXRpb24gKG51bWJlciBvZiBkZXZp
Y2UsIE1TSSwNCj4+IE1TSS1YKSBhbmQgY2hlY2sgdGhhdCBQQ0kgd2FzIHN0aWxsIGZ1bmN0aW9u
YWwgb24geDg2Lg0KPj4gDQo+PiBXaXRoIHRoZSBwYXRjaGVzIHB1c2hlZCB0byBYZW4gcmlnaHQg
bm93IGl0IHdhcyBjaGVja2VkIHRoYXQ6DQo+PiAtIHhlbiBjb21waWxlcyBwcm9wZXJseSBvbiBh
cm0zMiwgYXJtNjQgYW5kIHg4Ng0KPj4gLSB4ZW4gY29tcGlsZXMgcHJvcGVybHkgd2l0aCBWUENJ
IGFjdGl2YXRlZCAodXNpbmcgYSBwYXRjaCkgb24gYXJtMzIgYW5kIGFybTY0DQo+PiAtIHhlbiBv
biB4ODYgaXMgZnVuY3Rpb25uYWwgKHVzaW5nIGJhc2ljIHRlc3Qgb24gUUVNVSkNCj4+IC0geGVu
IG9uIGFybTY0IGlzIGZ1bmN0aW9ubmFsICh3aXRoIHNvbWUgZXh0ZW5zaXZlIHRlc3RzIG9uIGRp
ZmZlcmVudCB0YXJnZXRzKQ0KPiANCj4gQnV0IHNvbWVob3cgaW4gdGhlIHRlc3RpbmcgZG9uZSB5
b3UgbXVzdCBoYXZlIGF2b2lkZWQgdGhlIGNvZGUgcGF0aA0KPiBpbiBxdWVzdGlvbiwgb3IgZWxz
ZSB5b3Ugd291bGQgaGF2ZSBvYnNlcnZlZCBhIGNyYXNoLg0KDQpEZXZpY2VfYWRkIGlzIGFsd2F5
cyBjYWxsZWQgYnkgZG9tMCBzbyB3ZSBkaWQgbm90IGhhdmUgaXNzdWVzIGhlcmUuDQpEb20wbGVz
cyBQQ0kgcGFzc3Rocm91Z2ggaW1wbGVtZW50YXRpb24gaXMgbm90IGRvbmUgcmlnaHQgbm93Lg0K
DQpTbyB5ZXMgd2UgZGlkIG5vdCBnbyB0aHJvdWdoIHRoaXMgcGF0aC4NCg0KQmVydHJhbmQNCg0K
PiANCj4gSmFuDQo+IA0KDQo=


From xen-devel-bounces@lists.xenproject.org Fri Oct 15 11:18:01 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 11:18:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.210322.367138 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbLDo-000705-HN; Fri, 15 Oct 2021 11:17:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 210322.367138; Fri, 15 Oct 2021 11:17:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbLDo-0006zy-ES; Fri, 15 Oct 2021 11:17:56 +0000
Received: by outflank-mailman (input) for mailman id 210322;
 Fri, 15 Oct 2021 11:17:55 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=doKy=PD=citrix.com=Andrew.Cooper3@srs-us1.protection.inumbo.net>)
 id 1mbLDn-0006zs-3i
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 11:17:55 +0000
Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 1b22bb89-e968-45f3-9173-108994f2f2a7;
 Fri, 15 Oct 2021 11:17:53 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1b22bb89-e968-45f3-9173-108994f2f2a7
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1634296673;
  h=to:cc:references:from:subject:message-id:date:
   in-reply-to:content-transfer-encoding:mime-version;
  bh=1uo8Mv0D2r70UbdMK/P/Vk+E+XAdltSMPlY3GeqN5xc=;
  b=KtDt4awZU4d728ZDR1rt0xKLj8uOjxDuCJNydMJWjiRbC+zfOUoc5G4w
   OZ9GZKSqKXWTSq2rbCvGotD/L8vvEG5ys/Ax1dRhySU0b+PXhuItZTOCQ
   6QdXPk5sx9jjBwe6SfyL0YLaLYm2kcW7Ei/h1hVzyL973nuSKxV37RlDp
   c=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: RNCy9xWIR22Inh+vqh0P5UKlcfr/tUPfKPa9gcprqZDqBWQQbtNNqGOaxPJ4mx8H+YdN39YsUe
 6hYdQf+GThep0cshtRnTQHTKrbRwVvGUxoIMyksFJPk+H/UsIIt+Hg1Dn6sfXh5JRWlxRZyCff
 DEKg0ETScyFsO+/0YXSf8shFW0N0VzYt6BfHe5D9o1aqgeQS/JIGFmZntS9T6kHHikFXtLepVY
 eDUDLFbPhouGMR5ci4Cx1bGcY0DxoJjvvxNhmf0Zj07lV0kz/GhR7T0+mnelf2iNwmruHoMA4Y
 FGx/url0x1tLH8FvB19SG7nj
X-SBRS: 5.1
X-MesageID: 55308482
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:zkzNxqwciataWNq369J6t+fCwSrEfRIJ4+MujC+fZmUNrF6WrkUFn
 DEbXTjXa6mDNjD2KdpzPtnj9U0FsMSEnNVnTQA6rSAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx
 59DAjUVBJlsFhcwnvopW1TYhSEUOZugH9IQM8aZfHAsLeNYYH1500s6w7dk2tcAbeWRWGthh
 /uj+6UzB3f9s9JEGjp8B3Wr8U4HUFza4Vv0j3RmDRx5lAa2e0o9VfrzEZqZPXrgKrS4K8bhL
 wr1IBNVyUuCl/slIovNfr8W6STmSJaKVeSFoiI+t6RPHnGuD8H9u0o2HKN0VKtZt9mGt8htl
 e9Wj9vvdSwkPavoteUPbTBkFD4raMWq+JefSZS+mcmazkmAeHrw2fR+SkoxOOX0+M4uXzsIr
 6ZBbmlQMFbT3Ipaw5riIgVoru0lINPmI8U0vXZ4wCuCJf0nXYrCU+PB4towMDIY250VRaaCN
 5BxhTxHVRvaYkd/A2cuWMgFl8b12nvyQj1fkQfAzUYwyzeKl1EguFT3C/LFd9rPSchLk0Kwo
 mPd43+/EhwcLMaYyzeO7jSrnOCntSHxVZ8WFba43uV3m1DVzWsWYDUKVF6TsfS/zEmkVLp3N
 Eg86ico668o+ySWosLVBkPi5iTe51hFBoQWQ7ZSBByxJrT8+xrEPHM+CWF9Q9ElsusbRC4U/
 2OOgIa8bdBwi4G9RXWY/7aSiDq9PykJMGMPDRM5oRs5D8rL+95r0EqeJjp3OOvs1IetQGCvq
 9yfhHFm3+17sCId60msEbkraRqXrZ/VUhV92AzTWm+0hu+STN/4P9L2gbQ3APApEWp4crVjl
 CRb8yR9xLpXZX1oqMBraL5QdF1Oz6zUWAAweXY1Q/EcG82FohZPh7x47jBkP1tOOc0ZYzLva
 0K7kVoPv8MJZyHxMPYnOdzZ5yEWIU7ITomNuhf8NYImX3SMXFXfoHEGibC4jggBb3TAYYlgY
 MzGIK5A/F4RCLh9zSreegvu+eRD+8zK/kuKHcqT503+idK2PSfJIZ9YYArmRr1ot8us/VSKm
 +uzwuPXkn2zpsWlOXKJmWPSRHhXRUUG6Wfe8JIKKLTaeVQ7QQnMyZb5mNscRmCspIwM/s/g9
 XChQE5Ijl35gHzMMwKRbX5/LrjoWP5CQbgTZETA5H6khCouZ5iB9qAae8dldLUr7rU7n/V1U
 +MEa4OLBfEWEmbL/DEUbJ/cqo1+dUv02VLSbnT9ODVvLYR9QwHp+8P/ele9/ic5ESfq59A1p
 Ket112HTMNbFRhiFsvfdNmm00i14SoGgOt3UkaReotTdUzg/ZJEMSv0ivNrccgAJQ+anmmR1
 hqMAAderu7I+tdn/N7MjKGCjoGoD+ohQRYKQziFte67bHCI8HCizIlMVPezUQrcDG6kqr+/Y
 eh1zu3nNKFVllh9rIchQa1gyrgz5oWzquYCnBhkBnjCc3+iFqhkfiudxcBKu6BAmu1ZtA+xV
 h7d89VWI+zUasbsEVpXLws5dOWTk/oTn2CKv/gyJUz74g5x/aaGDhoOb0Xd1nQFIesnKp4hz
 McgpNUSul62hRcdO9qbijxZqjaXJXsaXqR77pwXDecHUObwJo2utXAENhLL3Q==
IronPort-HdrOrdr: A9a23:2+7Rs6N1EUctXMBcT0/155DYdb4zR+YMi2TDiHofdfUFSKClfp
 6V8cjztSWUtN4QMEtQ/OxoS5PwPk80kqQFnbX5XI3SITUO3VHHEGgM1/qb/9SNIVyYygcZ79
 YbT0EcMqyBMbEZt7eC3ODQKb9Jq7PmgcPY9ts2jU0dKT2CA5sQnjuRYTzrdHGeKjM2Z6bRWK
 Dsnfau8FGbCAoqh4mAdzY4t6+pnay9qLvWJTo9QzI34giHij2lrJb8Dhijxx8bFxdC260r/2
 TpmxHwovzLiYD79jbsk0voq7hGktrozdVOQOSKl8guMz3pziKlfp5oVbGutC085Muv9FEput
 /RpApIBbU811rhOkWO5Tf90Qjp1zgjr1fk1F+jmHPm5ff0QTorYvAxz75xQ1/80Q4Nrdt82K
 VE0yayrJxMFy7Nmyz7+pzhSwxqvlDcmwthrccjy1hkFacOYr5YqoISuGlPFo0bIS784Ic7VM
 FzEcDn4upMe1/yVQGbgoBW+q3pYp0PJGbAfqBb0fbllQS+3UoJj3fw/fZv20vpr/kGOsB5D+
 etCNUiqFgBdL5PUUrRbN1xN/dfMVa9NC4kBljiaWgPJJt3SU4llKSHlIndxNvaNaDgn6FC1K
 gobjtjxCcPkgTVeJaz4KE=
X-IronPort-AV: E=Sophos;i="5.85,375,1624334400"; 
   d="scan'208";a="55308482"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=eJJf0ctgfrD/pwfNrGSe86uv2TIMoEd55A+0KQQY4Pn76Klkf+U/Via79u571ofBrWlWQSz91/HrU3J5e2MRuJeSqkC8rrsD1VIht4160yTRbmUhLYPMbrTef0EuhFyrMFaEnM12hONLSNsnU4uhVjZaiLcAsq0u03N5CUldWFUWUbyybLSWmhzzvUpfc/UiG9VZ3o/sOvYQM32FTN9F9fqWTho014wisIvmeH3OguKqt0sj8PfpxiGjBCihUwwlhoFkDMRV/oH0Iva9SLCqew5CkJ6TI1wJikD/e4yCRwiYhA/rTrvplouSQ5UVVIiL+9iUdeuWnsAAyHmHiw5Ejg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=1uo8Mv0D2r70UbdMK/P/Vk+E+XAdltSMPlY3GeqN5xc=;
 b=Xdh+V4sAaKw7CWBKrOfhjmQZnlSiA1La3XhyoBPY1ivys+xsrker0BE0iGZlTILfxmlxr2PB702t2csoFv8qGSsgd0brD5CAfAsL6SVHpFcp/h8VKDM9DUDw1NjDkH/sJWHPFJEYzP0Wt5akGSfO2+njv5OfNfM2cDiuQxht+DX8U++zy6QhAF2vyKI3CX1SzUhQja9B9zx1pVJ7IVsIgJZ4Edf/eUq0ga8rZpZ+mTKkdzsziCQplfSQ5SUREiKOu0DPBVDRABA6WyNlHlUi1YoIXGfocwF97poHir3EPhw0jHtbrJUbD3zlBM4cxM8HdYdc1K7eou7ji3X5ZBeIzA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=1uo8Mv0D2r70UbdMK/P/Vk+E+XAdltSMPlY3GeqN5xc=;
 b=OtpxICKbzfgWWULzepW5BbgcqQMXO14SCQoUOABGokUpwnf2SWhWLRn7qrjJJGet9q01bLihuFL5OXvtYo+3qNFVNagXVxRpL9jTcRnILsXaSndYlHADX3hC/WnQs7wu6FzMHo1kLl5rrZMxuMFzxSuhUAGuKQ2vw6mnU9Bij1I=
To: Jan Beulich <jbeulich@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Wei Liu <wl@xen.org>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
	<roger.pau@citrix.com>, Tim Deegan <tim@xen.org>, George Dunlap
	<george.dunlap@citrix.com>
References: <24329000-06d7-2047-b0a1-51b149d19189@suse.com>
 <b2f750c4-3aa3-e560-626a-c7fa921cf4df@suse.com>
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH 2/2] x86/shadow: adjust 2-level case of
 SHADOW_FOREACH_L2E()
Message-ID: <b5a2eed4-0175-17c6-b3a6-1678244294ad@citrix.com>
Date: Fri, 15 Oct 2021 12:17:28 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <b2f750c4-3aa3-e560-626a-c7fa921cf4df@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Content-Language: en-GB
X-ClientProxiedBy: LO2P265CA0369.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:a3::21) To BYAPR03MB3623.namprd03.prod.outlook.com
 (2603:10b6:a02:aa::12)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 4bbe55a7-790f-459f-8b4d-08d98fcd630c
X-MS-TrafficTypeDiagnostic: BY5PR03MB5032:
X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <BY5PR03MB5032B7B55CD61FCD5689FE17BAB99@BY5PR03MB5032.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6790;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: ewfrKke1qpG/ms8Y+YQd288sz6WAAEaTkL+He6wsxgL+ITaxPRUhcLPP6G9aXj5pu5qfIWzjPzjYvU6T9S0VQrWqUuH+BLXV71yIYa4L0CLYdxWO7EjEXyfBQamhp36E2n1ODYoHIFqbf5oiqvGruLZZW7eb32aSqShiIprtiNQzgEZnax4s8CdKmhewFtSw4P5VbcXFz39DPstjG+ImpOBJZUQFGieE6+fKeYdcpJbPYJP017nXM0qJSvU8FQRpWLFNDn7XCXgsDc4jmbWivo3PNntsPxd0CYFWxmVFKMHaD/SV2ZGwscxBYbwKVijYblZ577VjJUN6qSxNdOmsCBv9FnZHC663EBsLn4cnv/DNiw2vlep/JQJySmDjTtF/rE9pzvZyEseVy3I/WGR+0qrYMU0txgjqWYFRk8SliibBtLumYqFBnyHaz0wERJXCSPoJimqBSY9tvst52KjTfctss9C1du3exr747wlMpyStGX4FfnVlBeRhzfkSxUNShsmZmywySyo67PygpFA4hOoNkq6d6MCknomtkUc5O95oLS7Ess6Nu76G8wKh81VFEjPcdrtJcUlAJCnwSX9sepOYNPIvGm9AGxiSjV4XawxdcIDCwPERNzVDaNXhAsLhzysqegOUyt0ldsRU3GYZcyYQODkvclgt7gqiHbI9wZZ6/3TOWO++DrVUiwsyKSRVpdRx5QE/C2ucSZ+uzMbmzQvN1HPQ/6MW7vX2WOQZblquREawDJLGiam1V5t+7H8c
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(6666004)(54906003)(110136005)(38100700002)(5660300002)(36756003)(186003)(82960400001)(4744005)(2906002)(53546011)(31696002)(66476007)(6486002)(16576012)(8936002)(31686004)(26005)(8676002)(66556008)(316002)(956004)(508600001)(107886003)(2616005)(66946007)(86362001)(4326008)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cFlVeWV0cHNnT3hOWXZTS3ptODJsYkxoZ0xYUzJqU1F0ZFdXVXNRR2w4a0JF?=
 =?utf-8?B?SmQ0bFNKWXZITEZuT1FFdXMxUEI4cVVPVFpNeVhZY0poWmlFQkg1ZllMak5U?=
 =?utf-8?B?ZWcwRFVzT01GdVJ2d1IzbDVQaEVPTjJXdk05MkZBS0c2QitjZ1hraUVSRkNU?=
 =?utf-8?B?WFp0RUpPeTEwdkwzaGlxc0RobDZqOEtnMHpCQ1c3ZFkzTDhUZUlSdmg5YjZ6?=
 =?utf-8?B?UU44M0M1cmNqcUQ5M21hdWxWTkt4M0o5YWJBaWo2di9SSUo0SnVuY2tyNWdv?=
 =?utf-8?B?RVZHVTNIYkNBdGd6aDZEdEhPRGtnNThuQ0VyaHRGK1g2SlJvaUZSajlOMUYx?=
 =?utf-8?B?Ri9xRmpPa29zWWhhNHBEdUw5YkF4cDJ6K2hIUEZQNWl2SWxZYlpvMkdJOU9J?=
 =?utf-8?B?OWRuRnVMcVdsMzc3ZFRUNFBRWFBnM08rSzFVY1dwaDNKLzFUTXdVcDEzakFQ?=
 =?utf-8?B?VTR1ekU4aHNlbmlPSjc4RFhzUW5mMm1uYnVuVHkrV2pWQXBHTU94eGpFRGVL?=
 =?utf-8?B?a2pjZE12S0pUNEh1dmlLdEV4TXdMWGdSV3k2YW1zcDlJeC9BZlVrYVo3emt0?=
 =?utf-8?B?UndpNUhmdHhmQ0wyVnJDWi8rcDJ3d3NuRmsrSDJyRGdkTU9GanBYT0pWc3VN?=
 =?utf-8?B?RHVLMjdwWkpDU0RKZnJZNkthWjRFTnJWK3pLaVUxU1JTMmdLOEpmbUtJakY5?=
 =?utf-8?B?ZXFxdlVFUDVhZU10UXJIWnhvT2lkUmNnMnZiMTlxdW5QQ1BmMlNMYzJLSTRi?=
 =?utf-8?B?RTNlN0tBU2VRUVovNW5TWms3MWhadWlRdlRNOEhzUnI0cEJCNGU3RlBZRlFL?=
 =?utf-8?B?UnFiNFhYb2h5OWNwVWZqTXYyNStWL3NjVHlUV3VJU2FkNXJwSzRHWGVKQXBq?=
 =?utf-8?B?SUNQbVZSZThueW9DVE5Telo1S0tuZUZ5QnQxM2duc0orVUsxZHhOTG8rOG9n?=
 =?utf-8?B?QmxBNXVlaUczR2gvUm9MMkV3RTdUTENOS1ZqeWl1dWhoaXN2Mm5HenM3L1hy?=
 =?utf-8?B?eXZ3eW0vYVBoRFVFSUR4UWJyNks2aWkzeFpUZnM5bXdNYVR3aG1XM3FpRWVU?=
 =?utf-8?B?QnNEUjE3MzZ5anBXTVZKWHExVnNBWWRvcGlkNUhjME5BQmhGM3Fjem9lRWND?=
 =?utf-8?B?cXJSMFZqaUhOZnFHS2JJTk1JVm1paUpka0ZyYlVXaXN2dW4xbkNkSXprVy81?=
 =?utf-8?B?T3BsVGNvU3pCcmJVNmxWdUpXK3lOK1RNUVQyaS9BVW91cFUyQ0ZVMnp2VW0r?=
 =?utf-8?B?SElKNEpPeGFrb3c3cVJPTzRDblVPcnJDQ1RmeTNLYzBBQjNtSElKaWpoNlFR?=
 =?utf-8?B?aGF6RklQTmllMlFYOGl2elQveFMyUHoxNjM5ZEZwVk9uZGZGWG1EUXVkTEJh?=
 =?utf-8?B?YmR0UFZlRFc5Q09vdG9Nb3JTdHQxblN2YmdSVVJpTHdFQUMxaDFmVzZvaXND?=
 =?utf-8?B?WkNINUErM2NSK1lWUjNDM3hweDdoWkEzbm80Ry9JWVQwZmJLNTU0SVFaNzRk?=
 =?utf-8?B?ejRJTVdIZVlMRWE4ZUVDc3lTekt5RWFZQTBxMldPd1JRckRvd1ZLU1ZzUHNM?=
 =?utf-8?B?akpqd1ZTejlrR3NBZU1JM3RkaUVOMlE0K25yeGZwT1o5MWpzL3BDZm1EU2NF?=
 =?utf-8?B?emVDZmNxV3dyWlBJYUVwR1E3RHRqWWV1WHpad08rSGR1eUM3VTdQcDVzYkcy?=
 =?utf-8?B?OFZNVDlhU2ZEQ0dCSW9UZlcvbVNjeEh2WHRhejJFVUdmMDhsL1FiZkRvazZm?=
 =?utf-8?Q?b0SFvz/yUJLRVn7C7Ya3ZtB9au1k0/QcXZkQgV1?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 4bbe55a7-790f-459f-8b4d-08d98fcd630c
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2021 11:17:34.3899
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: oGp9tjWEC6Opigsmq6swRFcamzwaqIXQlshhngAZNOdZEvgPgdvFlnHev6x3xo+HeVMGk5wB7eyKNnC54SsIxly/qG1X96i6NSxpCGpvXGQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR03MB5032
X-OriginatorOrg: citrix.com

On 13/10/2021 16:38, Jan Beulich wrote:
> Coverity apparently takes issue with the assignment inside an if(), but
> then only in two of the cases (sh_destroy_l2_shadow() and
> sh_unhook_32b_mappings()). As it's pretty simple to break out of the
> outer loop without the need for a local helper variable, adjust the code
> that way.
>
> While there, with the other "unused value" reports also in mind, further
> drop a dead assignment from SHADOW_FOREACH_L1E().
>
> Coverity-ID: 1492857
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> ---
> Looking over other SHADOW_FOREACH_L<N>E() invocations wrt their uses of
> "done", I find the audit ones particularly odd: The respective variables
> get set only from AUDIT_FAIL() and AUDIT_FAIL_MIN(), but in both cases
> after invoking BUG(), i.e. in an unreachable position.

Sounds like there is dead code we can drop.

This logic is all horrible.=C2=A0 I think this is an improvement, so
Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>



From xen-devel-bounces@lists.xenproject.org Fri Oct 15 11:24:14 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 11:24:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.210335.367170 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbLJq-0000C9-IC; Fri, 15 Oct 2021 11:24:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 210335.367170; Fri, 15 Oct 2021 11:24:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbLJq-0000C2-Cp; Fri, 15 Oct 2021 11:24:10 +0000
Received: by outflank-mailman (input) for mailman id 210335;
 Fri, 15 Oct 2021 11:24:08 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mbLJo-0000Br-ST; Fri, 15 Oct 2021 11:24:08 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mbLJo-0002g1-Li; Fri, 15 Oct 2021 11:24:08 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mbLJo-0005qa-AA; Fri, 15 Oct 2021 11:24:08 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mbLJo-0003WF-9A; Fri, 15 Oct 2021 11:24:08 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=hw1DVtLerFLST8Vdy9bKjlq12zzG+sAdU55wTc4GLoc=; b=O6Rg8YX+0h2sebwpiM0uvUIVaE
	18hFpHRMdeeka/T/CEgrYRwNjW76MBGR024knJfNn9OeGn0ggNIM8gZb5gBr4fZrPF1oOgmu3X4Th
	ssYIl7dl3JNuUJeQBbQRoKnvVASVT5e++r7gf5TaTAnPaCL0ZK0Qsq7beZp2+MTBELi4=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165515-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 165515: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-unstable:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=b75838ad6c4f42c93efee83fc2508c78641e1b57
X-Osstest-Versions-That:
    xen=4cfab4425d39f76660b4e76ba6ee4cbf0f92e7e5
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 15 Oct 2021 11:24:08 +0000

flight 165515 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165515/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-rtds     20 guest-localmigrate/x10       fail  like 165509
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 165509
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 165509
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165509
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165509
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 165509
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 165509
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 165509
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 165509
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 165509
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 165509
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165509
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 165509
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  b75838ad6c4f42c93efee83fc2508c78641e1b57
baseline version:
 xen                  4cfab4425d39f76660b4e76ba6ee4cbf0f92e7e5

Last test of basis   165509  2021-10-14 13:09:36 Z    0 days
Testing same since   165515  2021-10-15 01:39:51 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Anthony PERARD <anthony.perard@citrix.com>
  Christian Lindig <christian.lindig@citrix.com<mailto:christian.lindig@citrix.com>>
  Ian Jackson <iwj@xenproject.org>
  Jan Beulich <jbeulich@suse.com>
  Julien Grall <jgrall@amazon.com>
  Michal Orzel <michal.orzel@arm.com>
  Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
  Volodymyr Babchuk <volodymyr_babchuk@epam.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     fail    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   4cfab4425d..b75838ad6c  b75838ad6c4f42c93efee83fc2508c78641e1b57 -> master


From xen-devel-bounces@lists.xenproject.org Fri Oct 15 11:36:03 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 11:36:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.210347.367184 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbLVF-0001lA-PS; Fri, 15 Oct 2021 11:35:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 210347.367184; Fri, 15 Oct 2021 11:35:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbLVF-0001l3-M8; Fri, 15 Oct 2021 11:35:57 +0000
Received: by outflank-mailman (input) for mailman id 210347;
 Fri, 15 Oct 2021 11:35:56 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=UM5E=PD=citrix.com=roger.pau@srs-us1.protection.inumbo.net>)
 id 1mbLVE-0001kx-5y
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 11:35:56 +0000
Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 0e87c8f2-2dac-11ec-822e-12813bfff9fa;
 Fri, 15 Oct 2021 11:35:55 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0e87c8f2-2dac-11ec-822e-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1634297754;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=RBR8NExi6P/5nWPVx8DSkXub3TBMlXw+Y1GZJthKL4Y=;
  b=Ysf77pEWlIhlSGiX5vVeNC1Jmq4w7d92YXDedHkZ35Vcdoelgu5earI2
   ji6fDIcpFAB5/34b2X33BpBvtWy8ruDpiTzImBR1In0zVam75bRxR6cfo
   sDdV4cCDeLEnSyCt5HzmJYTIn2agYwNetSC9q0NsbS2xSjijE7LfAfKoE
   M=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: KVHSt4gABU8tRG0vCqTIkdfqOGeDIHfy1xk+dP8KJGTZ4ExNReIAW2KdddWqwBGXDQfsN3lyJ8
 fFI9MCGKGjxy8E4/kIQ3/BcOL4jMSlcs77aNLftlmJBpkoLCumS2ryM3hdtHHEo9A1Hrjs9rP7
 Ei3ncVTnfbg3wR1LW4gcwvgRvYJN8qt1ogY5Edi8zrSKALlAYuAAp1dcfniFI6CWCFjb+nlX7E
 6bz0yHYVsS79Tjrl2dCNAn+UYkCdztwrGRO7SxrOvKiGTAwMeN7NhFc0iMEYB+XiDjr2oxbfL9
 hXPD9SPH7DbOPygZAivoo7cJ
X-SBRS: 5.1
X-MesageID: 57166003
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:uQeY6KLY3qQDy4qPFE+Rp5MlxSXFcZb7ZxGr2PjKsXjdYENSgzECy
 zMeUWjVMviDYzT9edt/O47ipBxUuceDztQxTARlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s
 q3yv/GZdJhcokcxIn5BC5C5xZVG/fjgqoHUVaiUZ0ideSc+EH140Eo6xrZg6mJVqYPR7z2l6
 IuaT/L3YDdJ6xYsWo7Dw/vewP/HlK2aVAIw5jTSV9gS1LPtvyB94KYkDbOwNxPFrrx8RYZWc
 QphIIaRpQs19z91Yj+sfy2SnkciGtY+NiDW4pZatjTLbrGvaUXe345iXMfwZ3u7hB2zoopX5
 81Mr6aBUAsuZLbNneRCWDxXRnQW0a1uoNcrIFC6uM2XiUbHb2Ht07NlC0Re0Y8wo7gtRzsUr
 LpBdW5LPkvra+GemdpXTsF2gcsuNo/zNZ43sXB81zDJS/0hRPgvRo2XuoYGgm9o3aiiG96Aa
 sAcMSMocy7uaiJoIVo1JYphm7eB0yyXnzpw9wvO+PtfD3Lo5DJ21L/hId/EYOugTM9enlubj
 m/e9mG/CRYfXPSd1D6E/3SEluLJ2yThV+o6C7mQ5vNsxlqJyQQ7GBAQEFe2v/S9okq/QM5Eb
 VwZ/DI0qqo//1DtScPyNzWgqWOAlg4RXZxXCeJSwACSyILE7gCBHG8GQzVdLts8u6ceRzYny
 1uIlNPBHiF0vfueTnf13p2Zty+oMC4Za0oLfzYZTBAt6sPm5oo0i3rnVc1/GaS4itn0HzDYw
 D2QqiU6wbIJgqYj7ay74FSBuDOqqZjhRxQwoA7QWwqYAhhRPdD/IdbysB6CsKgGfN3xokS9U
 GYsofXEys8WDIu3pTWBR78WHbSpuP2gP2iJ6bJwJKUJ+zOo8n+lWIlf5jBiOUtkWvo5lS/Vj
 Fz74lwJuscCVJe+ReouOdjpUpV1pUT1PY29Dqi8UzZYXnRmmOZrFglVbkmMw3ulrkEolawuU
 XtwWZfxVShEYUiLITzfegv87VPJ7nxhrY8wbcqip/hC7VZ4TCXIIVviGAHfBt3VFIve/G3oH
 y93bqNmMSl3XuzkeTXw+oUON10MJnVTLcmo8JANLbTYf1M2Qj9J5xrtLVUJINENc0N9zb+gw
 51AchUAlAqXaYPveG1mlUyPmJuwBM0i/BrXzAQnPEqy2mhLXGpcxPx3SnfDRpF+rLYL5actF
 5EtIpzcatwSGmWv02lMNvHV8d09HClHcCrTZkJJlhBkJMU+L+EIk/e5FjbSGN4mVXTq65Fn+
 OP9j2s2g/MrHmxfMSofU9r2p3uZtnkBguNiGUzOJ9hYYkL394Z2bSf2i5cKzwskcn0vHxOWi
 FSbBwk2v+7Ir9Nn+dXFn/nc/YyoD/F/DgxRGGyCteS6MizT/2yCx45cUbnXIWCBBT2soKjyN
 /9Iy/zcMeEcmAoYuYRLDLs2n7k14MHipuEGw108TmnLdVmiFphpPmKCgZtUrqRIy7IA4Vm2V
 0uD98N0I7KMPM+5QlcdKBB8NraI1O0OmymU5vMweR2o6Chy9buBcENTIxjT13ANcOoraNsom
 L5zttQX5gqzjgsRHuyH1i0EpX6RKnEgUrk8ss1ICoHclQd2mEpJZobRC3Gq7cjXOclMKEQjP
 hSdmLHG2+ZH3kPHfnc+SSrN0O5aichcsRxG1gZfdVGAm96Djf4rxhxBtz8wS10NnBlA1utyP
 EltNlF0evrSr2s52pAbUjD+ARxFCT2Y5lf1mgkAm2DuRkW1UnDAcT8mMuGX8UFFq29Rc1C3J
 l1DJLoJhdoyQPzM4w==
IronPort-HdrOrdr: A9a23:R9SaR61Be9X7iWhzfAj5qgqjBSlyeYIsimQD101hICG9Lfb2qy
 n+ppgmPEHP5Qr5OEtApTiBUJPwJk800aQFm7X5XI3SJzUO3VHHEGgM1/qB/9SNIVyaygcZ79
 YcT0EcMqyPMbEZt7eC3ODQKb9Jq7PmgcPY9Ns2jU0dNT2CA5sQkDuRYTzrdHGeKjM2YabQQ/
 Gnl7Z6TnebCD4qR/X+IkNAc/nIptXNmp6jSRkaByQ/4A3LqT+z8rb1HzWRwx9bClp0sPsf2F
 mAtza8yrSosvm9xBOZ/2jP765OkN+k7tdYHsSDhuUcNz2poAe1Y4ZKXaGEoVkO0aySwWdvtO
 OJjwYrPsx15X+UVmapoSH10w2l6zoq42+K8y7QvVLT5ejCAB4qActIgoxUNjHD7VA7gd162K
 VXm0qEqpt+F3r77WXAzumNcysvulu/oHIkn+JWpWdYS5EiZLhYqpFa1F9JEa0HADnx5OkcYa
 dT5fnnlbVrmG6hHjLkVjEF+q3oYp1zJGbIfqE6gL3U79AM90oJi3fxx6Qk7wE9HdwGOt55D0
 mtCNUcqFh0dL5kUUtKPpZ3fSKGMB28ffvyChPhHb3GLtBOB5ufke+93F0KjNvaDKDgiqFC3q
 j8bA==
X-IronPort-AV: E=Sophos;i="5.85,375,1624334400"; 
   d="scan'208";a="57166003"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=K0D1Ac4rBM9E+2g8xhmIyNXp89R/zgOwFCgdbPh59RiMfS/qjMCjU8bE8Xzi+g2RmqbcrAfJnS0+B/yjM5KwnPOaTmoYzIEDc1bjp9suDGLqO1sUG+J+j5Uh7MdA5jc7APmf+g3h+4KVSAmxUvQvHO5PeGlHQxa+yLCUvEJGVoTXD3DRKL5ozoIwcaV+SYD80fYJZYA3rt3vni0KCkF/XFm9PUJVE1zjOrQJBIdlGI8iIl64F0nHSrf/qRnRZBlAu8fp57nHnKlG5/lPVs9Fo54w7rr2m1kG2n5hcWTWTLzaZC81wBtzE2Z0ex0ElKRfR7Wd5S0yh5ko74q48FWYEA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=qVaKWQWok/L4wsobSpNYYkwFYE4O5PER6ESkKvtd2w0=;
 b=CFpPxtQ+4GIY0xjDUXv93Q0UO8/4nfPYxXbbvV0DRYOTkhC8xjC1oEZWoLCdqrE9RuS1/+6w6ut0t5luPh4HVh6lArfUii5cB2DdMbTWVPtulQ8fBXkZ0WLUH+JLPOrZBrFviQ2giAka2kivjYOZrk85Z06CDYEnP3Ma52/C2ni+rT3sxMPo/SCX0cN0h8jsIzPIfsFcTI1+ePTHkoEzAhkYghM6P0O4FX8TkIwnJHy2DL5DUfTvPSDaVBuWeo5fW0NT5DfVxaVQRtct+m8w4HJX5tmxAEYHGG27DKSMvLz6Ocx8HbzpJP9W7A3GcN9Qsc6t+PMUpVs3BngjIfSFvg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=qVaKWQWok/L4wsobSpNYYkwFYE4O5PER6ESkKvtd2w0=;
 b=ti+ZNzWyQenyhmPMcxAq9Wsi/B8O6pGC7xaDW8sAhNvplr5D81jH8J6n7UuBoA1F4uwvoke2Q3WQfF8GsY75xkjYCqbXkPk8A2O0TSaU+owqSRqcDh5QaWtaViy/1tyG6SBK9q7tB1gRcuxzFpC4mid2DEn2+Pk3TZ/yuWzOWcc=
Date: Fri, 15 Oct 2021 13:35:15 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Ian Jackson <iwj@xenproject.org>, Bertrand Marquis
	<Bertrand.Marquis@arm.com>, Rahul Singh <Rahul.Singh@arm.com>, Stefano
 Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>, Volodymyr
 Babchuk <Volodymyr_Babchuk@epam.com>, Andrew Cooper
	<andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>, Wei
 Liu <wl@xen.org>, Paul Durrant <paul@xen.org>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v6 2/3] xen/arm: Enable the existing x86 virtual PCI
 support for ARM.
Message-ID: <YWlnc3b0sj4akUWa@MacBook-Air-de-Roger.local>
References: <cover.1634221830.git.bertrand.marquis@arm.com>
 <396b08e2598cf0338e0c7f4ad3cd5cb66db89224.1634221830.git.bertrand.marquis@arm.com>
 <f41f59f7-69ed-e2fe-dc17-434b456cf693@suse.com>
 <57A39480-34DF-4BF5-9B0E-802D30F94BBD@arm.com>
 <24937.21631.538303.29471@mariner.uk.xensource.com>
 <b8fc68e6-2bba-ef11-4c4a-50c2046ecb04@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <b8fc68e6-2bba-ef11-4c4a-50c2046ecb04@suse.com>
X-ClientProxiedBy: LO4P123CA0471.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:1a8::8) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: fd30eaa5-e932-42f0-1da8-08d98fcfdeec
X-MS-TrafficTypeDiagnostic: DM6PR03MB3738:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <DM6PR03MB37380B30A6ADA1E4CF9D50948FB99@DM6PR03MB3738.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: yuCpHIS6ugD8WZyjPkkX3ZGhTPaNve9xySe3Lm+Ico+ET4EUXcvPROWADZw2KKsEEAwh3MlUDuX64XkskQXbd2R9Unv1f3xPMMAt6xns8h4pcuWs8XRDAwZTaFa2uNJaw9LOQf195/0ci6ttvHwDLIvOdJ7exXTgXJHTm8nfFkFmIuktQLIxZypzz59kyv7w8WByxojlCK5soOAYiUZULzTY9DunwlVVTXjIKwJXzvmMOLyn2HJXv7JkGxNYFkcX/K79JyGE4ubqqVDiWUQA4vAK86wImW+qK4NZ1W9pT3p5Sy5CwzGQVCCNmwDfnlRGukbEhDdaAbbB5hSHby+Z/FLt7Zovq+vRC+NN8EDMIiHXE2JPf6QDkrCCRbPq7rQ5uJYH74+0jY7Cwy7yL5JXWwzO2lu6zsS5V9eVfnkiEKlyrf02yOjyXeffwlVUYlkZ8z6o8AA5MEL/kamLFl9OF3EBCYQXgwoPqJil0zyUSGaPvPXmUhlDTi8PHwc3DfIsv2TJdFQVjj2oLbKDygcDYTgGY6g4bI+blgDAZbdQ+8nfpPOsijN6m5VwOv27cOjS12vhIywBfCNDGN2pdU3Un3DTr5s+lhx3IgBu4v11m55T6Tr3pXM3jqjukVItWTGuPdtxk4ETmm39QspSAGGxzeBZN7xLp5KQZi5gisRBYepmDco10jatdnzOgN2pmXeoV9/+eJwcjIYQl5+DL30kG0y8GEDTmbxozLapna563Xs=
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(53546011)(966005)(6486002)(2906002)(66556008)(508600001)(6666004)(6916009)(8936002)(9686003)(38100700002)(85182001)(66476007)(66946007)(4326008)(5660300002)(83380400001)(86362001)(8676002)(6496006)(316002)(26005)(186003)(82960400001)(7416002)(54906003)(956004);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WDgzTHNCRXpWYncrNk5UTzBXZTFwT3RNYmFSUUI0WC9LY0RzeVRUbFhoUU5G?=
 =?utf-8?B?MEw2UlErTWliUTFKZEw3a3NIUXFwK0lTd0pUdTg2UUIvTnAvZDZXTEl1ZlFX?=
 =?utf-8?B?dVpLdHJnOFp4OXBsOWk3VHZSMWgyc2Z5SGtiSk9aTDBoK1VZOXFwS0Z4ZTI1?=
 =?utf-8?B?N0dPRzVmU1djOUJkMkt5RUN6a3N3WE1EU0xnMWp4Y2FCamlSanVBUXM3VWhC?=
 =?utf-8?B?Mk1MaExhaklYQUdzeHl3aDNpS09RZTJpSnFuTmF6dHJiS2lsNSs3YlBFRHgx?=
 =?utf-8?B?SXVySGxHcXdROGNVZ0hqRVNqMkwvRENndzc4OEJaWkNDcEI5YkdGeTVIbHVx?=
 =?utf-8?B?NjczRHM1VXBnektuNWdBNUJBeWUyVkVyaHVRSm5RWVFHYnZXbmVLSmszT1RX?=
 =?utf-8?B?TndtOVg3b0dib2JRejluVzA4bzFVRE93OG9FSjFaVXpkWUgxMlM5KzYrMlJ0?=
 =?utf-8?B?b1lOamJHVFl0eEliU3VPdTMvOFZ4dmY5SklnVXBFMVViUXR4eHhIdGo3L1J3?=
 =?utf-8?B?OStFOGdPSVk1YlRVRm9WMmdzeGJMdFMzME9UYmk1aWdGSXdtWG5LVVM0bTRR?=
 =?utf-8?B?U3VkRm5WUHM1UWFmY1lYK0xNNWtxdTdIRnc0d3NxV0c0dnBLdWlLeUw5cU9V?=
 =?utf-8?B?VUpmc1JnVDlVZkV0MzVBRTNOb0JpZlpzaDhVWlV0WmhraEM3d08vRmFmZEdV?=
 =?utf-8?B?bnNHaWFzdWxRZEFpd3FEaUtXSGtpdi9WMm0rN09NK0srYXZodzFWY0VqaVhT?=
 =?utf-8?B?Z2JkSXQ1YStLWGhoYU9iY3NFODJCZzEvdkt0aFFhdnFxemZRK1E1SkRsSFkw?=
 =?utf-8?B?eFoxVTY3bWZSc3RuN1Z0UCtCNWZuRkhUSlRkSFFXejNDVGVrdzVldlhOSlV3?=
 =?utf-8?B?dHlyc0J1NFN4SnZQV1VQWU9UZ1pJdFo1UUxWakk2d2lVSmJneXZLZGM1UHNa?=
 =?utf-8?B?Qlh4SkpadXNuekhQcVdZa0FCaDZoUS80cjBOS2wrWm1OOWVnWlZ6SmVxY3pT?=
 =?utf-8?B?SmlkTlFJdE0rbG0wUDFhUzBlQnpGaE5mYUlaZEZ0ajBYVnB3VzBQdy84dVp1?=
 =?utf-8?B?ZVhzSmltMkJyM1llb2Z4NzY2TVhVYXZVWVZlRTBEenJ0WlJYVlNPdDdGWUhP?=
 =?utf-8?B?Ykx1T2Q3ZDd1T1hJRldZMWl2UFdvOXZDMTBjRnJGN2poVkt5am40cDE4enVP?=
 =?utf-8?B?UXRJK2I2WXVtM0wxaENtTE5QN1NZK0U5bVRsNm4wczkzWXhweUZIZThLQ3ky?=
 =?utf-8?B?bUhGb1B4RDJkOHFQNEZPOG9ncGI3RnE5eWNhcUNzVENtR3lqdjJERzVBT3B2?=
 =?utf-8?B?OXE3QXRTbHZ1SmR2RlBwb2I0NG4zZU1wV0JNbTFzUURPbUtiOUMreEZiU09M?=
 =?utf-8?B?MU4rNHhLU2dwSTRqa1gzRlRRMzM4ZHB6OVQrY2VyS3I5RzNwQWVPTmFsWHhE?=
 =?utf-8?B?ZlpCZVFocnBTeExQT0tYYjFXL21mTEJKcmdQTHdmakNNaTFhankwOUt1RjZ3?=
 =?utf-8?B?Vm1uSlZMeEZrMEFEM0FIcVlIK1lucTh3SitxUDAzbms4VDdqZmRMNWcrZ0g1?=
 =?utf-8?B?MjExSGZHRlJlMGl3N2d3cExOZXB6aFQvbDFOMHhrbWpSVG94UWpnNXZXanVr?=
 =?utf-8?B?eWo0TUZwSytpQm9uU3hITkNleUxoU0FGdUQ2Y09kT2hhRkFZOUJVNzlMLzEr?=
 =?utf-8?B?MFVXVjhnWGo2cEpzMlRndCtLTHovMkV1a0NyTE45YlhyeVJtbS9xRWFUdUxz?=
 =?utf-8?Q?zKWJ6PiYUAjBV4GChOnsBys/AK90FU+akXiQml1?=
X-MS-Exchange-CrossTenant-Network-Message-Id: fd30eaa5-e932-42f0-1da8-08d98fcfdeec
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2021 11:35:21.2774
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: b+bn55isxTeCalMS6vAcBmUzhvQ3P+mfnQX13cNN2WFZoFvwKXHWWcwkYFRKh1gvKgkbgZeCG5wilHl/jWwRKQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB3738
X-OriginatorOrg: citrix.com

On Fri, Oct 15, 2021 at 12:18:59PM +0200, Jan Beulich wrote:
> On 15.10.2021 12:14, Ian Jackson wrote:
> > Bertrand Marquis writes ("Re: [PATCH v6 2/3] xen/arm: Enable the existing x86 virtual PCI support for ARM."):
> >>> On 15 Oct 2021, at 09:00, Jan Beulich <jbeulich@suse.com> wrote:
> >>> The latter is fine to be put here (i.e. FTAOD I'm fine with it
> >>> staying here). For the former I even question its original placement
> >>> in asm-x86/pci.h: It's not generally correct as per the PCI spec, as
> >>> the bus portion of the address can be anywhere from 1 to 8 bits. And
> >>> in fact there is a reason why this macro was/is used in only a
> >>> single place, but not e.g. in x86'es handling of physical MCFG. It
> >>> is merely an implementation choice in vPCI that the entire segment 0
> >>> has a linear address range covering all 256 buses. Hence I think
> >>> this wants to move to xen/vpci.h and then perhaps also be named
> >>> VPCI_ECAM_BDF().
> >>
> >> On previous version it was request to renamed this to ECAM and agreed
> >> to put is here. Now you want me to rename it to VPCI and move it again.
> >> I would like to have a confirmation that this is ok and the final move if possible.
> >>
> >> @Roger can you confirm this is what is wanted ?
> > 
> > I think Roger is not available today I'm afraid.
> > 
> > Bertrand, can you give me a link to the comment from Roger ?
> > Assuming that it says what I think it will say:
> > 
> > I think the best thing to do will be to leave the name as it was in
> > the most recent version of your series.  I don't think it makes sense
> > to block this patch over a naming disagreement.  And it would be best
> > to minimise unnecessary churn.
> > 
> > I would be happy to release-ack a name change (perhaps proposed bo Jan
> > or Roger) supposing that that is the ultimate maintainer consensus.
> > 
> > Jan, would that approach be OK with you ?
> 
> Well, yes, if a subsequent name change is okay, then I could live with
> that. I'd still find it odd to rename a function immediately after it
> already got renamed. As expressed elsewhere, I suspect in his request
> Roger did not pay attention to a use of the function in non-ECAM code.

Using MMCFG_BDF was original requested by Julien, not myself I think:

https://lore.kernel.org/xen-devel/a868e1e7-8400-45df-6eaa-69f1e2c99383@xen.org/

I'm slightly loss in so many messages. On x86 we subtract the MCFG
start address from the passed one before getting the BDF, and then we
add the startting bus address passed in the ACPI table. This is so far
not need on Arm AFAICT because of the fixed nature of the selected
virtual ECAM region.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Fri Oct 15 11:46:40 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 11:46:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.210356.367198 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbLfR-0003Ex-Oz; Fri, 15 Oct 2021 11:46:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 210356.367198; Fri, 15 Oct 2021 11:46:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbLfR-0003Eq-Lu; Fri, 15 Oct 2021 11:46:29 +0000
Received: by outflank-mailman (input) for mailman id 210356;
 Fri, 15 Oct 2021 11:46:28 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mbLfQ-0003Ek-Iz
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 11:46:28 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mbLfQ-00034j-IG
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 11:46:28 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mbLfQ-0003m2-HE
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 11:46:28 +0000
Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89)
 (envelope-from <iwj@xenproject.org>)
 id 1mbLfJ-0005Z5-QE; Fri, 15 Oct 2021 12:46:21 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date
	:Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From;
	bh=r41TwO0pFTgjf/SPE5slDooBiqKdCTWbHTaApsfdDGg=; b=Vn6zsjzIUHztz7Dezdcc7k1xC5
	Eb0yinJfoW/jmxlGD/MpBsjdAQbrEraoFiuu7/dpZx6c2Zmjbaj6aAxOxE+nNAzj0ivHPJiCiJ2Gy
	VGf2m7KgwC7P7Qeu1ceuCppXp70lvI0Rhv4zkbywL75/oGF0drhAVH3/4/w+tZtXwQlg=;
From: Ian Jackson <iwj@xenproject.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <24937.27149.222087.933297@mariner.uk.xensource.com>
Date: Fri, 15 Oct 2021 12:46:21 +0100
To: Michal Orzel <michal.orzel@arm.com>
Cc: Julien Grall <julien@xen.org>,
    Bertrand Marquis <Bertrand.Marquis@arm.com>,
    xen-devel@lists.xenproject.org,
    Rahul Singh <rahul.singh@arm.com>,
    Wei Liu <wl@xen.org>,
    Anthony PERARD <anthony.perard@citrix.com>,
    Juergen Gross <jgross@suse.com>,
    Stefano Stabellini  <sstabellini@kernel.org>,
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
    Andre Przywara <Andre.Przywara@arm.com>
Subject: Re: [PATCH v6 3/3] arm/libxl: Emulated PCI device tree node in libxl
 [and 1 more messages]
In-Reply-To: <56490119-6040-9ab1-aab7-e43975cbb80d@arm.com>
References: <cover.1633540842.git.rahul.singh@arm.com>
	<b81b5dea800c8fe47071f3dbd20588b1e472fb99.1633540842.git.rahul.singh@arm.com>
	<7bdac405-a889-15e1-be19-5876f7253855@xen.org>
	<24926.53690.621007.507249@mariner.uk.xensource.com>
	<294BE20A-7E45-405C-BC19-C292295E85E3@arm.com>
	<24927.7235.736221.270358@mariner.uk.xensource.com>
	<8A04B9B2-E816-425E-BF1B-5A8B89F8836C@arm.com>
	<cover.1634221830.git.bertrand.marquis@arm.com>
	<fd9c54a381daa52436b0a1b27cf1bba8e7ff9af9.1634221830.git.bertrand.marquis@arm.com>
	<24936.28385.679884.535704@mariner.uk.xensource.com>
	<6f82141c-8a0b-1e30-a996-223f7c0c508d@xen.org>
	<24937.20922.73382.850023@mariner.uk.xensource.com>
	<56490119-6040-9ab1-aab7-e43975cbb80d@arm.com>
X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu)

Michal Orzel writes ("Re: [PATCH v6 3/3] arm/libxl: Emulated PCI device tree node in libxl [and 1 more messages]"):
> On 15.10.2021 12:02, Ian Jackson wrote:
> > Can you leave a comment somewhere (near where c_info.passthrough is
> > set) pointing to this use of num_pcidevs ?  That might save someone
> > some future confusion.
> 
> Here, c_info->passthrough is set to enabled if either d_config->num_pcidevs or
> d_config->num_dtdevs is set. Do you think we need to add there additional comment?
> If so can you please help with what should I write there?
> 
> BTW. None of the patch I'm preparing with regards to this discussion modifies libxl_create
> where c_info.passthrough i set. Do you still want me to add some comment there?

Yes, I think so.  I won't insisting on it if you feel it doesn't make
sense.

Maybe something like

  // NB, on ARM, libxl__arch_blah directly examines num_pcidevs to
  // decide whether to enable vpci, rather than using c_info->passthrough.
  // This will be insufficient if and when ARM does PCI hotplug.

?

Ian.


From xen-devel-bounces@lists.xenproject.org Fri Oct 15 11:46:43 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 11:46:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.210357.367210 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbLff-0003Yp-2N; Fri, 15 Oct 2021 11:46:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 210357.367210; Fri, 15 Oct 2021 11:46:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbLfe-0003Yg-UK; Fri, 15 Oct 2021 11:46:42 +0000
Received: by outflank-mailman (input) for mailman id 210357;
 Fri, 15 Oct 2021 11:46:42 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=FGCa=PD=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mbLfd-0003YF-Ty
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 11:46:41 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id cbed5b85-7657-46fa-baf4-98570b0cdf60;
 Fri, 15 Oct 2021 11:46:41 +0000 (UTC)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2109.outbound.protection.outlook.com [104.47.18.109])
 (Using TLS) by relay.mimecast.com with ESMTP id
 de-mta-37-P2oPqzP6OOyTDZ2BkKPE2g-2; Fri, 15 Oct 2021 13:46:38 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB4846.eurprd04.prod.outlook.com (2603:10a6:803:5b::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.21; Fri, 15 Oct
 2021 11:46:36 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.017; Fri, 15 Oct 2021
 11:46:36 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS8P251CA0010.EURP251.PROD.OUTLOOK.COM (2603:10a6:20b:2f2::8) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.17 via Frontend Transport; Fri, 15 Oct 2021 11:46:35 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: cbed5b85-7657-46fa-baf4-98570b0cdf60
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634298400;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=ouqg4ZcgVSb17GN+FWPxCQe48GIW9ahi4s1Ln/bTg8s=;
	b=XZ1yRhfz85T9NgHYkZ3HSeP7bLOj3YDvgJ82/G4ZfIq118du4WKRxZjry1slqJLto89X9a
	KXWBS7uq06FsQqBNMzp2Msj99woTkXZc0XIVSPEEjG3/60g3VxTrQiMTYkharBLHW+j/gK
	gffYi8ZyqRH4SnbCWg1ywiT6jJFBcgA=
X-MC-Unique: P2oPqzP6OOyTDZ2BkKPE2g-2
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Wh7m/V1QLBy6HcKy3wqiYe55dJGUB06PdOPkOCUGla0sIDbEa7rJCgarkuCiLOo2UF2O4KEJNpXdjSLTnI5Vaat9fJLxaOcDhp8ZoXSsFyT4GnmYTW2TuD6d38FwUM+zqVGvERit5ENhcjawfiP+G/1uOaBccFmkE62q6xP1Vx+tQcllQqL397t4T9VWi7I/FtU+Yhx/6RHGo/wIoXS7NtdeXwMuLppHgx/LWaz5c5dpRFuoJoZ2QO9ZA5x2oDGh1bcwC2Vj+SdLrtkE3a3oM0+dcETjC8A1oJ85RcJtfNWFd8OjgMA7GGs7X2cMLwJl93hzC39qJGswGefKgMCb7A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ouqg4ZcgVSb17GN+FWPxCQe48GIW9ahi4s1Ln/bTg8s=;
 b=SRstMUdTd3JULuDTK8+0dQ+m8k6zBe5PlVArln0YK4nU6BNhAHv56gA8Pu9MdeDTjf1+MsHYHp8kKQ2l3OaVauSI9nuW0y6WPfV6aV4xq2ieSh0KHDsFLI+mdXqkJlqtEgjbWYlevK6aI0zcGUq+dKJcjCJqJ1HtM8GN7h2Gm5mfm92gcTEW2Vqxz8mF4l9FaiPDl74kG4opVGY8Ss8o2Y/JDGCKunq87gzYIsc1Zf4VYOztHEu4uZSSgnZZDs7bUO5gWd6db9HhNknC46lGellByB98TltKPtBmgwFrmm5Hf8oZIl9rQ8/su3BnTBb89Bsvh+uC/7lIZtTrlUFojA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [PATCH v2 3/6] gnttab: allow per-domain control over transitive
 grants
To: Roger Pau Monne <roger.pau@citrix.com>
Cc: Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Anthony PERARD <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>,
 Christian Lindig <christian.lindig@citrix.com>, David Scott
 <dave@recoil.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 xen-devel@lists.xenproject.org
References: <20210922082123.54374-1-roger.pau@citrix.com>
 <20210922082123.54374-4-roger.pau@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <be74d987-6968-3369-b7b6-96ca1fcd3e0c@suse.com>
Date: Fri, 15 Oct 2021 13:46:33 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <20210922082123.54374-4-roger.pau@citrix.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8P251CA0010.EURP251.PROD.OUTLOOK.COM
 (2603:10a6:20b:2f2::8) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 2c0ddd3e-8326-48f8-bd7f-08d98fd1713e
X-MS-TrafficTypeDiagnostic: VI1PR04MB4846:
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB48466949E34BA02646D36E15B3B99@VI1PR04MB4846.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:1443;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	JM8YLz2xbg28OH6bYVLhu8ie/6TfJt993LRilt2m2DiRug/ws5l4qvw+Rhx83jK9jnXHSsIjSb11xjndJ97zIcTvj6oJhv4nTpvxcOyFW+pEgqIEgpUKVB58CP0jkru71j6OFCuSaWjSnBTW+LhLq+YKjlUGo2hB0VRFF6kVLCAE9MyqQ5flcmcwV09suvcW4qDgtbKehcgT4704aa5iU5Xty/WzHgIuYXz3vLNN3KN5EdYV1XKzOFovRJWCZLHGMQcnlQRQ+geB9OfTiZKCCp043UlF0NJNLwWWWxEX00YbViKmwEAasZELVLokI0IunFskcrEGCmWmtJ0ILinn0BPxm4Cf77lBlSkM0h/DaDThgfYvPdfXFlUs/CM5dEs7HmOhNFyX70SunnSZpZQIUqNZjwI8i5HrfSPUP9Ait1HxHrW1d40C+AOXmZzcQ1px4Bi2s/h8MGqktlPqJqCs4lrP2yivIpQ8GfQQXYQgZKKKoyF7IgXdXcHDaklEGVbzVHygBlEVUNbBaN3guscr2R+FwwwgiBoOje3ZX3i1d6kxTaBitW+nbNTNNHspuGRtSr92kMDTslRLfNa0CWOr+OvRLD6ATqSOq16NMXFCsfBrATbzU61FLBCEe8B8/gcOecCwCLg8lbZKHRXOGxf5lumo/mF/c6r/BaxLWVbVQHC/LpMjSlEXwxgUJSRV5pJAKRJ2tz8we0srMoY6O89/9PTWoOpYA0HRKaVm1NhBQmFHluE6KsOb/rCKjN2zEYXH
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(8936002)(5660300002)(956004)(86362001)(2616005)(7416002)(186003)(6916009)(508600001)(8676002)(4744005)(66556008)(66476007)(26005)(31696002)(53546011)(66946007)(316002)(2906002)(31686004)(36756003)(16576012)(54906003)(6486002)(38100700002)(4326008)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?SWNFSzZvV3RvUTF4UkFFbDY0Ymd0WHVmR3YwRXcreS9vTVRtUW9QS1FXSVNP?=
 =?utf-8?B?cm5ETE4zcStVdEtIamFiMWp5M3dKVkx5QXc4U2I0djdlVDg4UXJRMmZrSzRu?=
 =?utf-8?B?TGRSd2JDUG9vRGJhWlhlejgzK015cEp0eE9rdmo1QlJ1MmRBb3UzbHBYTzZr?=
 =?utf-8?B?cTFVeEw3MkN6MWR2U0FoaldVblZNY0o0YktlMHlKUDU5K1NEZXhzMklGNGh1?=
 =?utf-8?B?eE5iN1FvUDVTZEhlNmQrNVlhNHY5eGpCYlpmTHF4RS9LcWt1azFvTEp6aGFl?=
 =?utf-8?B?eUMxTHh1d1AzYTdnbXpoYk1tL1VBK0lucExDaXRPSlc0SmFxMEV5TXM0ODlE?=
 =?utf-8?B?L3djOWQ3TXd0d3NZdE9QaUhWZUtieXBYQStqSTdUbzB6NFcxakp2WjNXbWJZ?=
 =?utf-8?B?VWpCK01EZTQyczVFWlRQMU10VTd6dUF1YkluMkgxYS9FZ2d2SXlNWmhNdVJW?=
 =?utf-8?B?Z1lMVnRMQ2doa3phSE9aSXZhdzNhQzVTZzFxRFh1YUhNUjBPeHl6TkVTSlF6?=
 =?utf-8?B?TG5tWE10MHU3dEhYU0hTVmRwZ3ZhcjE0bkdQbWlzRUMzMFQ5NVBjUWZ2N0tY?=
 =?utf-8?B?YU5ySWlFWWdST294Q213VU1sZ1lQS0FNK0VKWDBYRStEa0ZWbFFEQmNJOUdl?=
 =?utf-8?B?dmJLbC9kaXRpYlJiSGVLSTQrck9DMWJNWUF1ckJ2aDhyU1gvUFdDdlo5TnBP?=
 =?utf-8?B?ZWhpSXpENnFYdUJiYWFIRVl6WFhjRUI0bFBEejJTb2lzVG9BdFpKR0Z6aUZk?=
 =?utf-8?B?Z1R1SERBR3FzMmQ0QmZsMXJBdTFnS1dXd1hub1lOVXpMNHlkVjVwQ0ZNdnN3?=
 =?utf-8?B?VkMzMlh5cnZpWlFldzVEb2pIaVoxQUxXQXN5NWF5VG5WbUxrWFdKUjd2ZWg2?=
 =?utf-8?B?b1ROa245TUh5a2VNNzB4TTZpM05JQWdIejhlbGhPV2RNOTB5WkEyQ0dzYkZT?=
 =?utf-8?B?ZS9ydGZ3MENYS1JTN0xGcTdqcW9wTFc3b01DaGN3UnNqUU4wQWtiWFJwZnFN?=
 =?utf-8?B?NzgydzRQem9DMDFVLzVGbFlPT1VYWjhoNldOeE9HWmNnRHJvclFuWEdINkZv?=
 =?utf-8?B?Wno4WGtZNjRTUmxjQi9SWk9iZzZtKzBzNnZZZEw4bGFGeWRDTlZCVGpUMGVj?=
 =?utf-8?B?eHVJRDZ3TTRvdVV0L0dNVUJPL1lwaTVlRC9saWRyVTZ6Q2lPempWb0Q5alJX?=
 =?utf-8?B?NnZBN0pKZ1BoYW8xQlNYNVZtN2Zka0RYYzZLOURtbXlFeTBib1lmdGhZQjJG?=
 =?utf-8?B?QkZKdjlzNm1xZUFvYy96SkZuTXdZUWlOaWlrU1dnRlhNNmxQdE9VY1VQbVpa?=
 =?utf-8?B?WnA3SUZjcVdXa1IrQXhvNGZGazc1VDRXOWFQVnRvRmg3Z0xJK2NseGYyZnRD?=
 =?utf-8?B?Q1dEQ2JxMFQrL0dLNTV3N21DVEUrOHlIQjZ2amd4SmFFV3dyejgrRVZib2w2?=
 =?utf-8?B?Tkl5aE0xUS9XUmYzS2l0UURUQ3M2dE1kV0V4cHMwdmRnck4rV0tvOGFJVFVV?=
 =?utf-8?B?SWs1ZFlrSSsvVTZtc3lZSUpUK0VZWkV6U3R5clV1aHBvOWhRMzNmUUNuUlRy?=
 =?utf-8?B?N3ZJSXR0cjJlanRaQmR4enNTRXQwWkVOaCs0WVMzd0FzaHl6UTQ1NDZWeWg2?=
 =?utf-8?B?cFppcFpVUnBMTWlid0tQbTdHNUtRRy9SQnpiOG1wZTJXNmZxaldBcFhSbjR6?=
 =?utf-8?B?c01JSmF0MmtDR2Zac1FxNU8rOHZDYzRWWDQ2RkRIc05WQk5HaXpLREtxWEMw?=
 =?utf-8?Q?A2n36Axav4biAXsaxGsxXlXwn3bLvN7Cjhs4Plo?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2c0ddd3e-8326-48f8-bd7f-08d98fd1713e
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2021 11:46:36.2268
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ui4rQUn4gE6Ttex6Tu8XJYkxeTAoLYfFRapPi9ELTHIHtLfj/iHPXWQw9IELSRRg/r3niMV4B2ps4cyoz9djMg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4846

On 22.09.2021 10:21, Roger Pau Monne wrote:
> @@ -1965,6 +1969,8 @@ int grant_table_init(struct domain *d, int max_grant_frames,
>      gt->max_grant_frames = max_grant_frames;
>      gt->max_maptrack_frames = max_maptrack_frames;
>      gt->max_grant_version = max_grant_version;
> +    gt->allow_transitive = !!(options & XEN_DOMCTL_GRANT_transitive) &&
> +                           opt_transitive_grants;

Btw, should you perhaps reject the flag being set when max version isn't 2?

Jan



From xen-devel-bounces@lists.xenproject.org Fri Oct 15 11:47:53 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 11:47:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.210370.367221 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbLgm-0004SQ-Hr; Fri, 15 Oct 2021 11:47:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 210370.367221; Fri, 15 Oct 2021 11:47:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbLgm-0004SJ-Da; Fri, 15 Oct 2021 11:47:52 +0000
Received: by outflank-mailman (input) for mailman id 210370;
 Fri, 15 Oct 2021 11:47:50 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=FGCa=PD=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mbLgk-0004SB-CO
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 11:47:50 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id d9b7b373-58d7-4457-9a33-9dd50f335ed5;
 Fri, 15 Oct 2021 11:47:49 +0000 (UTC)
Received: from EUR03-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur03lp2058.outbound.protection.outlook.com [104.47.8.58]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-13-GWwMQo6gMHihJJdg5inCDQ-1; Fri, 15 Oct 2021 13:47:47 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0402MB3392.eurprd04.prod.outlook.com (2603:10a6:803:7::26)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.17; Fri, 15 Oct
 2021 11:47:44 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.017; Fri, 15 Oct 2021
 11:47:44 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6PR08CA0039.eurprd08.prod.outlook.com (2603:10a6:20b:c0::27) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.14 via Frontend Transport; Fri, 15 Oct 2021 11:47:43 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d9b7b373-58d7-4457-9a33-9dd50f335ed5
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634298468;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=oHRBOLdnfasBwrRmnIyqCz064wyayF1zWhy6MAvALLw=;
	b=ZoEPpafA98y1l/GHEEQ4DZtr3IDDyKhIAN8OTeENoSZQN5tkY8Bp3fC6WZW/9wAJgwzJ2T
	YFhrMY4nZ8JhTc4Y0lr/0LYGuRunyOlBiHe4gzhC0ByQoJtRZQQIzAmq7WE7VMpUcuRLBg
	Nkk6kb293IhAL+v5b3BaFmNvlmvv+uo=
X-MC-Unique: GWwMQo6gMHihJJdg5inCDQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=KTkgfL0vzllWNthidoxtGojAmNyFgtbk+hcJvOQNO+daabsRYpWCKQo+dlJFUD22XSf8m04SjyTeppkFhSOdmhlRAdoL+G+j6L6RVcha1NyOSIB5kz0gjYHxYj12ujfD6MeZTQEDBFmONJWuMHPyR4B+fqGDU3E2vC/K5I2Gl8TOutv24dghMpvDrO0Pbq0o+3c8v25H0LpVxyUpVqfC1puuJyEd5rLb8TcEA+x13VXu9GUvXAZ57Yd4eWG0OVDWkwThw4QSOP/yzbiYsilc1ZnAJaqDn3PxMzUgBzOa2jP2TBblQF2XabCLW8sT3rxOnM123IQzkU6Qti7UVFUCCA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=oHRBOLdnfasBwrRmnIyqCz064wyayF1zWhy6MAvALLw=;
 b=GWuQwnlN0sXCOYf2CAZR1HoxAaunfvcoi/dObj4meGH/Bkl8t1ZP++i0S+hpwveFLBkxXiZwYBuKPpDPJPvTC8q+EJUbtA8VtJl9vHuVPLz6KmdCNQq48DL05+SobyO0YCctULh3bXTNWhx6dk9ZlhVBT7/HKtsfblB+qqnEK+Kosa8AZNKwwWvAhVunJ0tUFfdyeqwC+MQAJUTHGJfepGeyo+iXIORn4ZCyD9lzana16rMaEEzhg5qDqpDIeQV/qzvQioxNJ56LF044GG7QGf7Ojw217Kzz6/eWkHpyFB109BeX/BChxqXH7IpgWEqQB3UXuBky4MeX1xBrcUE/QA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [PATCH v2 2/6] gnttab: allow setting max version per-domain
To: Roger Pau Monne <roger.pau@citrix.com>
Cc: Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Anthony PERARD <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>,
 Christian Lindig <christian.lindig@citrix.com>, David Scott
 <dave@recoil.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 xen-devel@lists.xenproject.org
References: <20210922082123.54374-1-roger.pau@citrix.com>
 <20210922082123.54374-3-roger.pau@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <fe51d9b8-5c2a-9e1b-a613-bdc36a613463@suse.com>
Date: Fri, 15 Oct 2021 13:47:41 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <20210922082123.54374-3-roger.pau@citrix.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR08CA0039.eurprd08.prod.outlook.com
 (2603:10a6:20b:c0::27) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 0a86a6ac-8324-420b-66f1-08d98fd199e3
X-MS-TrafficTypeDiagnostic: VI1PR0402MB3392:
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS:
	<VI1PR0402MB33924FCDC9BC8C0BE90C8BE8B3B99@VI1PR0402MB3392.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6430;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	EstWfbhtY/Wz89u8MClT6L1Bbrdb7vELcRBWbAFZnXp5YDfAg5/hJq7FIShNc3+Ec3U7SYd12Cj5jca/lTpoSE6j6YDKQeeG/rIrP34/Ypa+LgaVNBK+lQYAWQ5wbx5vasWa8K3OESVc22uhJJV/6hfBFVteO24XZ0dJJ2jwXOahASSxeBRkgKkjUINQoD2X9u/n+D4OHJEcIEnGJD2NG1gBDlnZSrfTxJge7gtnRtdQ6j+noN+rbJE0NcjdgiaipJoSNsfJ+1NXm7N/JQ6PccBEc5r5w5dfjMQoNsVnhzA4ilQgxH4IkT79QMnY8J51KI2PPzxKunAQSJfEaY1W6ziJXxjkQJ8RL31ttUHIYDkcP+nBS15ktiWnZRLVTcqAAfyXfRRqRgG1acH2db4zc5mZ8wudoSQrag+rufHFHkKqhvAUTnDGKwBIG/C4FomDs/IDxHD8Ka/9YESrFh+qMqSc+O+M0UPeNKJyX06QF65aX8l8SSpnJkjwNL2M15hQL4ubwgFtM5qSsXdj+eiaqvkqgRYkGRZX+6FC57uE8ZVOfHZya0RmslW5e1PbnZwbJ7SpmSZSEeKEZ3DZC92Jnq07wiWbPky4Ha36FqiBrBzbQhLlSEKfBtEG7sQpq2BMVVU4MG0rtJHWFB+mzu4CPMV5kwzFK4Dy/pwZYkhwTjfvcRXVW2f+OvJMUeQA/ruhBLlpfvleIDR1Mqg3OaXUcpI+GIcxZDOW5hjbt1lns4hDMhxYssglJdcLAkl4If6Z
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(66946007)(6916009)(2906002)(26005)(66476007)(186003)(66556008)(2616005)(316002)(508600001)(956004)(16576012)(5660300002)(86362001)(31696002)(7416002)(8936002)(6486002)(4326008)(54906003)(8676002)(36756003)(4744005)(53546011)(38100700002)(31686004)(83380400001)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?b3RIVkxTVlBUaXo3dGhuN09qbHcycmh0T0xuR2pKazlMN0lvM2tyMWVrWWFZ?=
 =?utf-8?B?cjl4bHNZclBkNXZwVTRISExpcU02dkFFcURySVRpSkRiQ2JPaEpTQ2FoVjNn?=
 =?utf-8?B?b1ZaQjBrMk15N3JjRndqK3JXUGtNd05lSTN5T1Z1U1ZPUjFwYmJsdUxtaTdu?=
 =?utf-8?B?alBGd3M1enZuMFE5dmZrWmhwSGtGOUttTzliRFpBL0hTVElBeXcwaWZ4MU9v?=
 =?utf-8?B?RCtMOTNXZkxkeHRHMURWbDdsK0d1MDFqQUtJVWxvRFQySnNlbnlyRk8vVFRU?=
 =?utf-8?B?V3dpTEh5Vzc2Q0RFL2VWaUEweUY0a2QzcGpTYVRic1NoNExBdTI1Vmc1bnN6?=
 =?utf-8?B?V0QvNDJJUkppc2s0bkt4S0YrN1VSL3JJWldJSktEYjBqQlo4d2IxVW1idnd1?=
 =?utf-8?B?Sko5amtiY3ZFa05yS2RHVkk4UEdoYW5vSG5Fbmsxb0xNSVFCdy9IRkhtV0NE?=
 =?utf-8?B?aDBBTzNUSTRvdU95Y3FMYUVnZ0JqMTFOWEQzN1o1MEJhRXBmNTF0cjhybVcv?=
 =?utf-8?B?blFzUGNaemNYVDhOdW9EeElUVERjQ2hSc2FzRkRFVjhsNy9PeXpKNy9UQ3Zp?=
 =?utf-8?B?bkFSK25aWUxkL24vcm9EOEdoTmZyZ3hqMHZwbUMzazBxWlYyTm5QV1Q0THZi?=
 =?utf-8?B?dnpLdmpVUUxSVG9OL0tWdHhOWS92c0tZNzc2Znc4NFl5dkZPMktWVkoyZksr?=
 =?utf-8?B?bUIrTTEvQlRLdlZEUUU0ODduVWplQmpMdHd4NUpHV0JBSFNlRVpqRnBTUUpF?=
 =?utf-8?B?Z0JadVRkbDVsSHNsa2p2eTNMWThyZytPTXdFZ0ZFbzhWZEhNMWxOVGk4bXlW?=
 =?utf-8?B?VnlwYk45eGdOV080c2Q0d2Rja3VMTVlpNmdGakZFVXhGYnEzc3EzUFZMZUZ6?=
 =?utf-8?B?NmU4OHNDV3hwaVhTc2l4ck1ENG1lM1l4eDlubHVTOTZwOGRxSkcwT0N1aUNN?=
 =?utf-8?B?eVEyanpwa24rTzM2cEIxMWtja1ZtV3MrekttZ0ZJZDQ2Tzh1enZGbVU4cmNa?=
 =?utf-8?B?RjJnZUFkcnhVeDZMTjQ4SmlqU0FEclFFR1Qwb2JVTWIzY0Y0VkF6Z2kzNnJm?=
 =?utf-8?B?YUxKWDA3VkZneEllWFFkdnNqVzFib1IvQ2lVdmZpeUJIY01oWGNWemxzdlJu?=
 =?utf-8?B?Y2dyTlB2Yk9PZEZPeFlnMXN2b2l2dStuNzcwS3NubjBPM25DNnRiTmJ6N2x0?=
 =?utf-8?B?UzNRLzhSMXlOcDhNZng4S0psVnhJOGlKK1NUMXNwU1haVkZ0Q2twV1krcEw2?=
 =?utf-8?B?NW01VGczNHJRd3JFUk1nZENucDV6ckZFaG1vUFBWVzEzR1d3NDdtcit0N1JE?=
 =?utf-8?B?S2haWjdXWVR6czUvZFh0U3BzNjJBempzMEVqaDhtQU0xSG45L096YmhSR3px?=
 =?utf-8?B?T1F4QlI4RDB3OWRMVDNsZFpRRThPckZYM0Q1REZYMDY1Zmd0TDhVOTRsMVdv?=
 =?utf-8?B?dGRLVC8rOVVPcVNXSG9WUGgvK1ZsNFA5bEJ1eEQxSnpFanVxNnh4TGQyTXRu?=
 =?utf-8?B?akYrbkRqRURaa0FPSzRsUEU1UHVNN1hxbmt3WHRzeWtBZEZXaytFd21NUUp0?=
 =?utf-8?B?NW1KUVZKZnBMVEpSelI2WGdWZi9oRWxwck5BWlRDVDhnazRWRCtTYy8yYUlq?=
 =?utf-8?B?NnpYSWZtcHNPMDVBRFkzSTc1bjR1Rzl4blJYbDUzUW9rMUJGdWVPMVdUbkEv?=
 =?utf-8?B?Z2dnWFZEMFY4Y0ZONkI1WHlpQ0ZKaEZmUjFCMm5lMjBlUUtORUNta0FFK2sy?=
 =?utf-8?Q?NmJMqfb4cjNbwUhaGLDyVJUYg9QkoCLYnqY855E?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0a86a6ac-8324-420b-66f1-08d98fd199e3
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2021 11:47:44.3459
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: uD42nFJD1TBYeJHUv0+SKiwgUED5zFDGJO5UhVVFj12OmVLTuukOaZed0M4mGs0fkJY7DftjSZdfgRnm15Ys/A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3392

On 22.09.2021 10:21, Roger Pau Monne wrote:
> @@ -1917,11 +1918,27 @@ active_alloc_failed:
>  }
>  
>  int grant_table_init(struct domain *d, int max_grant_frames,
> -                     int max_maptrack_frames)
> +                     int max_maptrack_frames, unsigned int options)
>  {
>      struct grant_table *gt;
> +    unsigned int max_grant_version = options & XEN_DOMCTL_GRANT_version_mask;
>      int ret = -ENOMEM;
>  
> +    if ( max_grant_version == XEN_DOMCTL_GRANT_version_default )
> +        max_grant_version = opt_gnttab_max_version;
> +    if ( !max_grant_version )
> +    {
> +        dprintk(XENLOG_INFO, "Invalid grant table version 0 requested\n");
> +        return -EINVAL;
> +    }
> +    if ( max_grant_version > opt_gnttab_max_version )
> +    {
> +        dprintk(XENLOG_INFO,
> +                "Requested grant version (%u) greater than supported (%u)\n",
> +                max_grant_version, opt_gnttab_max_version);
> +        return -EINVAL;
> +    }

To aid diagnosis of issues, maybe also log the affected domain in
both cases?

Jan



From xen-devel-bounces@lists.xenproject.org Fri Oct 15 11:51:22 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 11:51:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.210379.367232 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbLk9-0005sS-0k; Fri, 15 Oct 2021 11:51:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 210379.367232; Fri, 15 Oct 2021 11:51:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbLk8-0005sL-Ts; Fri, 15 Oct 2021 11:51:20 +0000
Received: by outflank-mailman (input) for mailman id 210379;
 Fri, 15 Oct 2021 11:51:19 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=FGCa=PD=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mbLk7-0005sF-R6
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 11:51:19 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 349da191-2dae-11ec-822f-12813bfff9fa;
 Fri, 15 Oct 2021 11:51:18 +0000 (UTC)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2106.outbound.protection.outlook.com [104.47.17.106])
 (Using TLS) by relay.mimecast.com with ESMTP id
 de-mta-27-omwxeIjkMaaBY8a6tb5-jg-2; Fri, 15 Oct 2021 13:51:15 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VE1PR04MB6381.eurprd04.prod.outlook.com (2603:10a6:803:119::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15; Fri, 15 Oct
 2021 11:51:12 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.017; Fri, 15 Oct 2021
 11:51:12 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS9PR06CA0067.eurprd06.prod.outlook.com (2603:10a6:20b:464::26) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15 via Frontend
 Transport; Fri, 15 Oct 2021 11:51:11 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 349da191-2dae-11ec-822f-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634298677;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=UJObJvrHkBBtUo8kY0zE7JBZu0xKJo5GoGPZmP9A/+Q=;
	b=glP6EbeQbsd/tJ8/UZbyP9qNm82LTTS47xC56Pl4ZJ+qnBzwFtWa5m01MhYgv2krP/iy6r
	NjLrI5NP2o+zyKUMSGvG9/BrC5AAF3M+gpNGYn4LbkYBnncBzCwoaBqkHU8kSQ4d8R2Lan
	saEYAJNz7smORyhoHO5ik8i8QLAeQPI=
X-MC-Unique: omwxeIjkMaaBY8a6tb5-jg-2
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=jIlEh5BY5vIjkM2Gx7bk2mEsXqALR+/THJtpb/xXQEJjHeXX/IF0VB0YNClUaTsudkcjgNmvPadioC3WTae3Rt+1GGlZf8wfDf2esqjpgAvDwLbG7vDS59yzqKzMbd3S+yV1H/p7bLT4EoEtr0hbszCPvTa0jfaZfZbYIClCHXwFUqICQtvFOryrXrE14ypb4Cy9GX75afO6uT5DbOs0/sXeQYt4fQsnmw6OOdNCbsUErXJROTFw+8DIkaufyNt7BwrmvKiegrQyFgv+CStppmBdzn6zbiLy9zWKq7njkbyi9+8zWJVvpa67OH5pg2L7DUYyjCJ884+OlsrVZgdh/w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=UJObJvrHkBBtUo8kY0zE7JBZu0xKJo5GoGPZmP9A/+Q=;
 b=jK0IoDNrDt+MXSU/A/pqr6Sxyh/2tjRGLvdY+6x+CaXghEXxDLlUEat398aSAB63FsLbniO+tHIT14BZ7h7HkpwYuFDAmEHgMdM+revwNEo+sQFIhwowdVxQidJzaLKdlqKZpV3YW9sY6PhzeTBqLbwleWsUgZBBzHS9CDKkD+So/RbKhgW65W/581b4dHkUVgcYDUwXD4YkACz9zcriJ4Q0atwoTxcQebPf76GX+ZcxTdetwrhWyWz7wNm5LWyzu4jCHeboEqPJd/uBAGMOZuko1rKJfNMy5g8/uqQuiKq9VpgAr6DIndVFGgVsHw+riZM+983uKkyNDhEh7P5bow==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [PATCH v2 6/6] gnttab: allow disabling grant table per-domain
To: Julien Grall <julien@xen.org>, Roger Pau Monne <roger.pau@citrix.com>
Cc: Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Anthony PERARD <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>,
 xen-devel@lists.xenproject.org
References: <20210922082123.54374-1-roger.pau@citrix.com>
 <20210922082123.54374-7-roger.pau@citrix.com>
 <b900f179-c6c2-00f5-e531-5110307fa491@xen.org>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <e4580f38-763f-e7bc-4982-3eb0cef07d8f@suse.com>
Date: Fri, 15 Oct 2021 13:51:09 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <b900f179-c6c2-00f5-e531-5110307fa491@xen.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0067.eurprd06.prod.outlook.com
 (2603:10a6:20b:464::26) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 0adfe356-4157-4f3b-cd2b-08d98fd215ca
X-MS-TrafficTypeDiagnostic: VE1PR04MB6381:
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS:
	<VE1PR04MB6381EE49A22067D7383772D7B3B99@VE1PR04MB6381.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	I4cgOCDBfS2/xE1nMF9aOPv0ICPc+bg/jgMTHf5KO5SwH0cCzjrMCRPXXG9cWxq8cUSUBcoDyqHgTWFJFtv1e/RI8nFKz0tiUYeN4bdm31/wB/nPgcGKaJN1PMjGKSqM+H76ILzsgPPxPGTeS7zqLI5yLdgMVPboGfN8+rNoziS3POXsdL8IJy81ZWuuYp39Ad8PRJ31hCLgIfF0YhuEe6ORHBvJ+CsFG58x6OBYPag5Rd8wa2ctElrXiNicaS6OCXcOutGlTGNs2coDcnrdJUZ3ds04+ShrmGVe/GKlkwDUA8RTfQhLrLI2KOy5LCE/jwAx2EFlxML/OBj31yOSDIfB07oh40N4qo+japb4Rhb68MQkZc6+OARyYoagZGzFbE/baJivVBCuD8AwUl/VQuQnW7hwc/hi41l1quOOLhQXgv7i/mhMT7f7Ns4K7dVY3tstZHZTue+9lcWYLN4E4my/Wj9Ecotg0YZETDFxMO93LggUhm8aryS64MnRmwqLyNxcgf/QRZk++9AX0kgZl5lXUnv6/6fEms3bay87JthH+/GX7hQftIVfyyLApKMlec+wdCIQLoKUraRE266MiHbtdPl68wdWi0ytzAFXNrQjdywvLc0A2rKK6UcYeRoOn6qMHl6+7GOQpkqgX3eIrsZP35Nt52gVn6EMDTX7xdMmpz7PQ5ph903RolwTb4l5+XATpBLr9bpgLWGBWc4niil1OQOcDAOBho/uSLA5qft0yY8qNoXq2UnCb0kOHxiZ
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(31686004)(956004)(2616005)(38100700002)(66476007)(508600001)(66946007)(66556008)(26005)(31696002)(186003)(86362001)(36756003)(16576012)(2906002)(6486002)(316002)(53546011)(54906003)(8676002)(110136005)(5660300002)(8936002)(4326008)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?ZmVQSFdVeGtwWVhOc0JUT2NxeE8wT1BCc1FFLy9IV1NhR0tHd1JyUEhRNEEv?=
 =?utf-8?B?dTlKODZPRGdGcVdtTGtRUmJmdktJWUE3Y1VDdTUxNTlQbThKTWJQNmJHalFW?=
 =?utf-8?B?bkpNa0dDMlhad2lCaHZsSWF6UnF5Uk9CaDNqaGxHRkZDTFdDd0N0WU5NR0Fk?=
 =?utf-8?B?VERhdGxNVFM4Q0Y3UFE1ZUlKLzAxNStHQ1B1ZUkrWm14VzNIK2RmRjdNVjFu?=
 =?utf-8?B?WHIwanFINWtBR0hhZy9wWDdZNzVRVjY3MHM1Z2IxQmtMeXlzRkZDcE5oYlNu?=
 =?utf-8?B?MFlzajJtaFpXbVB3T3dTaXlpbzlmUzNEdFR1QmxDQ3RJQnhnY3RoSjBJZTBO?=
 =?utf-8?B?NFJFQ0tzdi84VkFhQjFhNWxPNER5dmhrK3FvVnpTMjk2N2JyQ1o0V3E2OHlQ?=
 =?utf-8?B?UkN0KzFIT042UTBSem9YMlVYNU00V3V5UUxBQUtONnlrUFZFVDNrMUhPK1Y1?=
 =?utf-8?B?MHYwYmlmUFZmRzZHcDRwdjM4VTZlZ1A4QXVndjhXNW8yVEdycEg5UXFPMEVx?=
 =?utf-8?B?R2NNTnNhSHMxZUthbEhzTGJ6dTlQSlJtazJGczVjdkVmN2ZQSWZXbUpsdXpk?=
 =?utf-8?B?SDlWV09jMzFVSk92SzRkeUxTU2l6b3BMTVp0R3RsYUt5MGgvYlFuK25oOVU5?=
 =?utf-8?B?TnF2a05OOHV0dW5UelU5VU9aQ0NPU3dnaE9sVis5Ry9ZSlJ4bHpkTmNUYUNw?=
 =?utf-8?B?am1tRktOcnZ3N3J0NTFwSmlBOE5UR2NVeGc0NTliazlSdkNjT1owcGZZWFBY?=
 =?utf-8?B?MXZGeGl3dUFRZ1JSRCtReDFJSy8yQ1JZTFovdFNsQ25hYXY5T3NRSmJ5dUd4?=
 =?utf-8?B?dkNYSWhsWDJodUhpMStPOWR5OVlTYmYxbU1URG5OWjRsbmNsWjdXYUxYY2hx?=
 =?utf-8?B?ZlFCTlF0RkFJQ2taZlpMaHMzWi8vRU1nSERGUStBNDM3YTJhc1FnN3V1Qm0v?=
 =?utf-8?B?eGhjczMzTnVEVmd1VHpYWXNBZ2gzMCt3QWNPaElHRFl3Q20wb0hucXB5WDRR?=
 =?utf-8?B?SVY1ZzVFZllMWTkxaUVkcmVTUEVPTGxUYXk5NlJkeEdjd3ZxcWJPZjFZS0xt?=
 =?utf-8?B?N1k0S3gvUSttQ2J5MkpEWVpvY2ZKNTg1aTJISWJXQkcvWjZaNUdzenFJMFVF?=
 =?utf-8?B?OG9sbTBiL3BlYjdJb0srZEQrVlIxMzJEOTk4MXNVenZyTmw2SktCbFNqMHVU?=
 =?utf-8?B?MktuQmd4amZSQmcxbm1kT2ZYcDhVK1QrNGFEek1KLzBwV0RYYVR3TnJUUjlo?=
 =?utf-8?B?UjdCUXJqbHRtTmFOUGlCOHdwaG9MSUtuZzR0TmxDazlnWUFLdW9rTDNzU1ZZ?=
 =?utf-8?B?dERSTnpyUzJPcXNYWWx2Sk8vaXl1ZXgyWm51bDc3MnpGZ0NJTGF6Q1ErTUJQ?=
 =?utf-8?B?ZlpDVEN4MVJzVVFaUXVhemFLUm92bWZvVXAySVJPQ3RBSDRucVNGd3lHTFhJ?=
 =?utf-8?B?ZThQWG9MVWgwNVpiSG93ZEpMd3dMeXMrYW4yU3QwSW4wRHRtNmFaQTlkK29i?=
 =?utf-8?B?M2FSTjdCMVJqRDFHK1RmOTQ1Mi9sY0RZTlRWUEtMRWRBMTJnMlIwNHBYdW9L?=
 =?utf-8?B?V3RXQU9UL0puS1NrZTM5TFRKYlpmSzFqaTcyRGpBYWtNK3F6TlMram9aZDR2?=
 =?utf-8?B?OUxlZnhuQ2NhMjdUMDRrbkdhVzRHSWM3U3lnZzhrSkhhVGdvYll3K043a0VD?=
 =?utf-8?B?M2xFYUpRV3QzeHBDYitreGtOWVBoTVNaL0IvQjdqRXczRGlKTmFTSFVZUGZO?=
 =?utf-8?Q?dmA5eM3FXBisXtqKnQ2hFMo6ed4vqqaGRAeS6rF?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0adfe356-4157-4f3b-cd2b-08d98fd215ca
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2021 11:51:12.2171
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: b8n3g0xfB0fpJy2zn74iSDW/IRI7ku0g51o0d0tSWkrjHPvee7/7PTrN1om29JC5L5acQE2M6/mOJVIlcHXiMA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6381

On 22.09.2021 11:19, Julien Grall wrote:
> On 22/09/2021 13:21, Roger Pau Monne wrote:
>> --- a/docs/man/xl.cfg.5.pod.in
>> +++ b/docs/man/xl.cfg.5.pod.in
>> @@ -583,8 +583,8 @@ L<xl.conf(5)>.
>>   =item B<max_grant_version=NUMBER>
>>   
>>   Specify the maximum grant table version the domain is allowed to use. Current
>> -supported versions are 1 and 2. The default value is settable via
>> -L<xl.conf(5)>.
>> +supported versions are 1 and 2. Setting to 0 disables the grant table for the
>> +domain. The default value is settable via L<xl.conf(5)>.
> 
> Technically, the version only applies to format of the table for 
> granting page. The mapping itself is version agnostic. So this feels a 
> bit wrong to use max_grant_version to not allocate d->grant_table.
> 
> I also can see use-cases where we may want to allow a domain to grant 
> page but not map grant (for instance, a further hardening of XSA-380). 

Or the other way around: A typical Dom0 may not have a need to grant
anything, but will likely want to be able to map grants.

Nevertheless I think an overall "no grant operations at all" switch
is good; both of the sub-aspects already have controls.

Jan



From xen-devel-bounces@lists.xenproject.org Fri Oct 15 11:54:02 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 11:54:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.210388.367243 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbLmh-0006UX-EL; Fri, 15 Oct 2021 11:53:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 210388.367243; Fri, 15 Oct 2021 11:53:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbLmh-0006UQ-B7; Fri, 15 Oct 2021 11:53:59 +0000
Received: by outflank-mailman (input) for mailman id 210388;
 Fri, 15 Oct 2021 11:53:58 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=KdBF=PD=arm.com=michal.orzel@srs-us1.protection.inumbo.net>)
 id 1mbLmf-0006UK-Uk
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 11:53:57 +0000
Received: from foss.arm.com (unknown [217.140.110.172])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTP
 id d3619fb1-4c31-495f-893d-188cc817352b;
 Fri, 15 Oct 2021 11:53:56 +0000 (UTC)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 17B0A147A;
 Fri, 15 Oct 2021 04:53:56 -0700 (PDT)
Received: from [10.57.25.205] (unknown [10.57.25.205])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 3FAAF3F70D;
 Fri, 15 Oct 2021 04:53:54 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d3619fb1-4c31-495f-893d-188cc817352b
Subject: Re: [PATCH v6 3/3] arm/libxl: Emulated PCI device tree node in libxl
 [and 1 more messages]
To: Ian Jackson <iwj@xenproject.org>
Cc: Julien Grall <julien@xen.org>, Bertrand Marquis
 <Bertrand.Marquis@arm.com>, xen-devel@lists.xenproject.org,
 Rahul Singh <rahul.singh@arm.com>, Wei Liu <wl@xen.org>,
 Anthony PERARD <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andre Przywara <Andre.Przywara@arm.com>
References: <cover.1633540842.git.rahul.singh@arm.com>
 <b81b5dea800c8fe47071f3dbd20588b1e472fb99.1633540842.git.rahul.singh@arm.com>
 <7bdac405-a889-15e1-be19-5876f7253855@xen.org>
 <24926.53690.621007.507249@mariner.uk.xensource.com>
 <294BE20A-7E45-405C-BC19-C292295E85E3@arm.com>
 <24927.7235.736221.270358@mariner.uk.xensource.com>
 <8A04B9B2-E816-425E-BF1B-5A8B89F8836C@arm.com>
 <cover.1634221830.git.bertrand.marquis@arm.com>
 <fd9c54a381daa52436b0a1b27cf1bba8e7ff9af9.1634221830.git.bertrand.marquis@arm.com>
 <24936.28385.679884.535704@mariner.uk.xensource.com>
 <6f82141c-8a0b-1e30-a996-223f7c0c508d@xen.org>
 <24937.20922.73382.850023@mariner.uk.xensource.com>
 <56490119-6040-9ab1-aab7-e43975cbb80d@arm.com>
 <24937.27149.222087.933297@mariner.uk.xensource.com>
From: Michal Orzel <michal.orzel@arm.com>
Message-ID: <6e29d836-918c-3b15-7608-342b2e4f8475@arm.com>
Date: Fri, 15 Oct 2021 13:53:45 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <24937.27149.222087.933297@mariner.uk.xensource.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit



On 15.10.2021 13:46, Ian Jackson wrote:
> Michal Orzel writes ("Re: [PATCH v6 3/3] arm/libxl: Emulated PCI device tree node in libxl [and 1 more messages]"):
>> On 15.10.2021 12:02, Ian Jackson wrote:
>>> Can you leave a comment somewhere (near where c_info.passthrough is
>>> set) pointing to this use of num_pcidevs ?  That might save someone
>>> some future confusion.
>>
>> Here, c_info->passthrough is set to enabled if either d_config->num_pcidevs or
>> d_config->num_dtdevs is set. Do you think we need to add there additional comment?
>> If so can you please help with what should I write there?
>>
>> BTW. None of the patch I'm preparing with regards to this discussion modifies libxl_create
>> where c_info.passthrough i set. Do you still want me to add some comment there?
> 
> Yes, I think so.  I won't insisting on it if you feel it doesn't make
> sense.
> 
> Maybe something like
> 
>   // NB, on ARM, libxl__arch_blah directly examines num_pcidevs to
>   // decide whether to enable vpci, rather than using c_info->passthrough.
>   // This will be insufficient if and when ARM does PCI hotplug.
> 
Well we are not enabling vpci. We are creating a DT node for it.
So either I will write:
/*
 * Note: libxl_arm directly examines num_pcidevs to decide whether
 * to create a vPCI DT node, rather than using c_info->passthrough.
 * This will be insufficient if and when ARM does PCI hotplug.
 */

or I will not add any comment (it can be add in the future when "enabling" vpci).
@Julien?

> ?
> 
> Ian.
> 

Cheers,
Michal


From xen-devel-bounces@lists.xenproject.org Fri Oct 15 12:09:21 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 12:09:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.210403.367254 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbM1U-0008GP-5Y; Fri, 15 Oct 2021 12:09:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 210403.367254; Fri, 15 Oct 2021 12:09:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbM1U-0008GI-1b; Fri, 15 Oct 2021 12:09:16 +0000
Received: by outflank-mailman (input) for mailman id 210403;
 Fri, 15 Oct 2021 12:09:14 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=FGCa=PD=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mbM1S-0008GC-HT
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 12:09:14 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id f8793b47-f45b-46f7-8aee-410e228fd8b0;
 Fri, 15 Oct 2021 12:09:13 +0000 (UTC)
Received: from EUR01-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur01lp2050.outbound.protection.outlook.com [104.47.1.50]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-20-7Supj-IEPneeUSJwkLTYIw-2; Fri, 15 Oct 2021 14:09:11 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB6304.eurprd04.prod.outlook.com (2603:10a6:803:fd::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16; Fri, 15 Oct
 2021 12:09:09 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.017; Fri, 15 Oct 2021
 12:09:09 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS9PR05CA0037.eurprd05.prod.outlook.com (2603:10a6:20b:489::28) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15 via Frontend
 Transport; Fri, 15 Oct 2021 12:09:08 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f8793b47-f45b-46f7-8aee-410e228fd8b0
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634299752;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=QB2nMFTzniCHD9QkSOsZAfdws39Ns2c+rtN6WG0uAqA=;
	b=dkzuevNU2tzq+bRODWtqkfvOjgk28J3QyTUBzHJW85UGZeU1yh5U1JEHBOkEcryx9oFNPh
	EalbSqsmAd5UOkEBeHXVvyvajNffteRHbkzv32gp9BP7NUVvSVEkWb6LKFOj70JBntIhrO
	1zoEN0IOXPuPV/dYlw+PoxYueOZG8BA=
X-MC-Unique: 7Supj-IEPneeUSJwkLTYIw-2
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=cI90MJESIXWqDFRJ7dyuci2sk3Z1BxHnKTmK8PHcNNcoU5ynsgEUhd6+XRlKdXtV7ZzmY3XI6F3Kq1C3wQp4NppxkIxW/2ykz4X4Y2XyOgdq/p5Ffhk/zwfNaeIYfiV/+kxyhnDWKTd5GOqU7BHWYPBvLfi5qklhcp2F+sJfGxHCbsrgup6YjMsdpoejan/yM81nOguxjMvPbayxycgHRGA4ieInFl5NwJeNwS7nPkqkXKk/AWUSvf98bYzozyKxylq5oGDn7G42DgLxazR3XOGKallFLoRdum5e5sQnyg08UYpxFauMWn3RVCuGKQWeHM12VZM4GaZoUfpJrkqjIQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=QB2nMFTzniCHD9QkSOsZAfdws39Ns2c+rtN6WG0uAqA=;
 b=YhzMorxCMEBDGWlh+6MfUAWfTiSZ8ilSLKhz5R8Cw5Qh1d5Ke6hoTFYsSnwOuWIDKh6ihstaxHjGzx8L032kf5fQ2n6oYhn0bWdgq8ioSmRth3zNFhaNCSPmRdyvF+eRdPqlnKmRL+lyP5w7jY7egMXFK2IZh2YxQw8ZhjQddNsBMZ0Kyv43Hu0mauWyjeIHdrEXNceJHlYiSgEqalKWgumwigu+54XaAsO4F3HGINQGngwzsFCO7btzXYPDvXcFKdX1HC0YbgdaKejysCJX0MRl++o/Za65JE3Bq3Iqe9ch9Mi3gyQls2xiEhuoFCfkhlxSGUA/azQCsd7xwY8ZSw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [PATCH v2 6/6] gnttab: allow disabling grant table per-domain
To: Roger Pau Monne <roger.pau@citrix.com>
Cc: Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Anthony PERARD <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>,
 xen-devel@lists.xenproject.org
References: <20210922082123.54374-1-roger.pau@citrix.com>
 <20210922082123.54374-7-roger.pau@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <379abbd7-da1e-cd20-a5a2-0f2849fb69c6@suse.com>
Date: Fri, 15 Oct 2021 14:09:06 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <20210922082123.54374-7-roger.pau@citrix.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR05CA0037.eurprd05.prod.outlook.com
 (2603:10a6:20b:489::28) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: f90effcf-34a0-4938-62b8-08d98fd497bd
X-MS-TrafficTypeDiagnostic: VI1PR04MB6304:
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB6304750A83BEEF5302E2F387B3B99@VI1PR04MB6304.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	fta6wI1r+gujSne4g+q3DwjC9H723H7svCBE9I9vgZOJA9FxXVKAlbdF04aQxR56X/km78MEMjJJZAalsCpjoPTOyt7ScJXU3UYQ+3rZHR68Zypbjbghp0HtUjZV36qkBmiEzaqzZuFRdLfKgLv9chPCBcW5Dy+jFrmBha7OWmvxsGuXzP6jtJq0np8yiashDSkLyzwGbNmEfHTVUjR3QgEHr9f4fbOxOwVKiDFXL9bS7q2e80R7N1K/B+qReO+aCaLOA6/V1F6H9QC20x0oWkKEDhtSuZKsstD37m59jmyxnxvkwc9q/x1tvTMhIOvdZdmq409aFXf08H8F6od6al4lzzCUlBebA51Nka/shPNIY22bj43icVS3mluMXXykWuWZ3ffhafi33FQ0j2kKjYwwD4p0jKAlVhPuiJUasVV3ZFRPnzfAG1ISlX/1KXkfcD0XrP5bQB1CLCFL354LQGf6wCZB7BkvQZqZ9JYCu5zhjTBnchsdilk49wiS+pd0bFA1Wkq6hnwDsEqo7OqfJp30qAX3YkbXoZQDAF3CoDwwU08AdNte0XunXOn06mC1xSX6Ia5utCPe/HJnW7AXyl9m/nd9Wd2ADXh0W9/fF/GBcoRHB+77N5qXOnyvw+gIqNunCK2oomAKQ3FBtDPZpwbfhPSnI/hr6P/4iT5/xHaBpGvSp4hzQhjf0j3DzdERDNCwVEKNiJh/Kz+97IdlenGnikBvC8IOBcaksp/JMt8=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(8676002)(508600001)(38100700002)(54906003)(83380400001)(5660300002)(36756003)(8936002)(2616005)(31696002)(31686004)(4326008)(6916009)(316002)(53546011)(2906002)(956004)(86362001)(16576012)(66946007)(66476007)(186003)(6486002)(66556008)(26005)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?VFhLaWp6R3dtQnJUcUJxUDJaejh6U3g2dEJlRzlpRUNOSUV6ajRUMHRvbjN2?=
 =?utf-8?B?c1VNeGNpdU85Z3JrbFMxaEZJQndZdXFJVnp3UVlZWjlqSkh0Y0t6akY1VjRY?=
 =?utf-8?B?eG5UbnByaG9IOVNWUU9paWdkTGYxakt3b2hIZmdIanMzelgyWXhQVDlqSHNC?=
 =?utf-8?B?UTBXR0ZZakJ1WDZkdC9uQ1NNQUdEVktDeVdEdEdBemRZZU1XTjI4OWRvdHR1?=
 =?utf-8?B?dU5KQmNuMEVMVWRkQWJodlovT3hIUkQrTUJFcWx5ZEUreHNsNFNSZmlGSFQv?=
 =?utf-8?B?NXdtUHZDQ0dCUndHeWhNWVVqSnhuOFhQeTN0bVdoYy9EaXJ2K29zaksxMklQ?=
 =?utf-8?B?YnYwMXIyb2RBc2E4TzhhakxzMGkvUGZWNHVCdUN0ZlBORWFnKzRFT0hiNHlD?=
 =?utf-8?B?Ylk4Mm1GRWtQME0vbzRtMVhxVkIvUzFEcGoxYVUxV0FYM1lzQVZxWFYzTzdp?=
 =?utf-8?B?cFZYV2g1bjc4QzR5WXdlcUIzUndMWkRjTlE4dGdzK0YwV0xrS2RuTHByYzlz?=
 =?utf-8?B?OW1TZkZ4ckJpQWVkTVpoMVVRMUJrWDM2SElMaUxLMlE5Q2JqcGgvS2VLTFJC?=
 =?utf-8?B?S041SURTQ1h3SjYyL2k0cnNncVBTYXc0NmZhODhhY1dSeThoVVFWZlVFaHFE?=
 =?utf-8?B?RnJjZjNhbUwrL0dDZXArNzc1Y2FBRUYxTGFZSjVqSEdmNW90NTFpS2o1eitO?=
 =?utf-8?B?MHFGUVJacTlJTUt0bjZ0SVhHcUFyRUdFbEZYR2dIZ3Noa1A0VnA0bTR0Rk5S?=
 =?utf-8?B?WHNvTEFtUzZvbzlnWGxuZWZjaHdNZzZXRzYxVytFUzRyTkdoZ3lNSTVTdFAz?=
 =?utf-8?B?QjQzUlB4L2dEcjJ5azVJU1JiQnNvMURaVmJGVGZYTUZtNHBLeSt2cit1TFgr?=
 =?utf-8?B?TlF5VFZVaUVSYlZURStHR25CcWZDUFh0QnRraFVjbCtSeUdYMHNjRTZpSGFO?=
 =?utf-8?B?OXJGVGRNa21zSUtNN1VUSjBQbjliNEVQajdnRU5NdzY5cFlLaTNPRVdIQ1ky?=
 =?utf-8?B?ejBFalhzOWU0aFFTZ1Z5emdzWWFnVUNyZ2xuVXBmWGF4enJSd3dpc2wvY253?=
 =?utf-8?B?RWdVVXFwZk9PY3VDa1ZaV1UzT1d6RnM5b2JvbEFqRUpCWjZWUTNMNHM3SDVo?=
 =?utf-8?B?WmYrNUswSlB0VkFjZ1B1OW1ZN1l0Nm95OHFIVk9RckJSK3JiOVY0N2I2NThY?=
 =?utf-8?B?Vm5UL1hMeDBwWEJjYTg2anFpbGd4QzZGMGcxYmxiTDlqS1lITUt2YW5VUXFP?=
 =?utf-8?B?R3hVT2RQMENxNUNsYkg0bFdIQnRhWm1NSEVUbHQ2UzF1SVNSRGJWT1JFaDM5?=
 =?utf-8?B?Zlc5TG9xd0tGTUtHN3I5dERtZGZKU1B6V2hQT3l3cGdlSjhYbjI4K1F0NzlK?=
 =?utf-8?B?RVMyZHBiNXRmemZTbHh5OFVPSTQ2OFRyNFpmRHo4RVlKK1NDWS92dDV0VGw2?=
 =?utf-8?B?dGl5VXV4b1d1WGZBbU1veTlNMFZTa3Fac016alBmMDk1Z0VqRW1PVnBnWE1Q?=
 =?utf-8?B?cFl3N2FrQXhpRnFid3JMc1JsL0FUZGJKOWU1cEtLNzN6NlpXWENoMXArakcy?=
 =?utf-8?B?aXV4ZENONThmeFkvSWw1TXAwUDliQUJEb3VxaC92dXFIUkFTZ3pObnpXYlN0?=
 =?utf-8?B?MjJtZjZnbTlsTm5kdzArWnZTQVpKWndSc1hQMVVqb0huOU1yQUhmdGxzMERX?=
 =?utf-8?B?c1gzdmk3M0R3YXExc1REWXlBa2RPazN2cWFmMGFOMjBNRlhFSzYxZUtlcC9y?=
 =?utf-8?Q?ivBu0sVyCzcb3bzeKpoHEukpeV3+FZ4HxQNqdce?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f90effcf-34a0-4938-62b8-08d98fd497bd
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2021 12:09:09.2305
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: KEEaQvjxkxfuqDG/QdADAQtEGc/ApgAdOEmKr5hwWKo+j9s+nqABCCsWWdVzM4Q/IvIrU7nKHg/TyUzyofDYcQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6304

On 22.09.2021 10:21, Roger Pau Monne wrote:
> Allow setting max_grant_version to 0 in order to disable grant table
> usage by a domain. This prevents allocating the grant-table structure
> inside of Xen and requires guards to be added in several functions in
> order to prevent dereferencing the structure.
> 
> Note that a domain without a grant table could still use some of the
> grant related hypercalls, it could for example issue a GNTTABOP_copy
> of a grant reference from a remote domain into a local frame.

I guess I'd consider this wrong - no grant table should imo mean no
grant operations at all. Disabling granting can be done by setting
the frame count to zero, while disabling the mapping of grants can
be done by forcing no maptrack table.

That way the number of places where checks need adding would reduce
quite a bit.

> @@ -1037,6 +1043,14 @@ map_grant_ref(
>      }
>  
>      rgt = rd->grant_table;
> +    if ( !rgt )
> +    {
> +        put_maptrack_handle(lgt, handle);
> +        rcu_unlock_domain(rd);
> +        gdprintk(XENLOG_INFO, "%pd has no grant table\n", rd);
> +        op->status = GNTST_bad_domain;
> +        return;

I would pull this check earlier, to simplify error cleanup. It
could live right after having established rd.

> @@ -1367,6 +1381,13 @@ unmap_common(
>      ld = current->domain;
>      lgt = ld->grant_table;
>  
> +    if ( !lgt )
> +    {
> +        gdprintk(XENLOG_INFO, "%pd has no grant table\n", ld);
> +        op->status = GNTST_bad_domain;
> +        return;
> +    }

While this is necessary, ...

> @@ -1406,6 +1427,13 @@ unmap_common(
>      TRACE_1D(TRC_MEM_PAGE_GRANT_UNMAP, dom);
>  
>      rgt = rd->grant_table;
> +    if ( !rgt )
> +    {
> +        rcu_unlock_domain(rd);
> +        gdprintk(XENLOG_INFO, "%pd has no grant table\n", rd);
> +        op->status = GNTST_bad_domain;
> +        return;
> +    }

.. this looks to simply be a bug check, i.e. may want to be BUG_ON().
There's can't be anything to unmap if the mapping of a grant of that
domain can't have succeeded.

> @@ -1556,6 +1584,12 @@ unmap_common_complete(struct gnttab_unmap_common *op)
>  
>      rcu_lock_domain(rd);
>      rgt = rd->grant_table;
> +    if ( !rgt )
> +    {
> +        rcu_unlock_domain(rd);
> +        op->status = GNTST_bad_domain;
> +        return;
> +    }

Same here, I think.

> @@ -2138,6 +2174,11 @@ gnttab_query_size(
>      }
>  
>      gt = d->grant_table;
> +    if ( !gt )
> +    {
> +        op.status = GNTST_bad_domain;
> +        goto out;
> +    }

I'm not sure here - I could also see this report zero (and success).

> @@ -3270,6 +3327,11 @@ gnttab_get_status_frames(XEN_GUEST_HANDLE_PARAM(gnttab_get_status_frames_t) uop,
>      }
>  
>      gt = d->grant_table;
> +    if ( !gt )
> +    {
> +        op.status = GNTST_bad_domain;
> +        goto out2;
> +    }

While not simplifying error cleanup here, I think this might still
benefit from getting moved ahead of the XSM hook. There's no point
querying XSM in this case.

Jan



From xen-devel-bounces@lists.xenproject.org Fri Oct 15 12:10:53 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 12:10:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.210409.367264 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbM32-0001BL-GQ; Fri, 15 Oct 2021 12:10:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 210409.367264; Fri, 15 Oct 2021 12:10:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbM32-0001BB-DH; Fri, 15 Oct 2021 12:10:52 +0000
Received: by outflank-mailman (input) for mailman id 210409;
 Fri, 15 Oct 2021 12:10:51 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mbM31-0001B5-Mz
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 12:10:51 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mbM30-0003WH-LQ; Fri, 15 Oct 2021 12:10:50 +0000
Received: from [54.239.6.185] (helo=[192.168.0.140])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mbM30-00066f-Dq; Fri, 15 Oct 2021 12:10:50 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=0PzjHvVT+CyGzsKALkPCHgKjzCUIXN2rCoEKeF27DOQ=; b=zOdJLxESdJYn9Q0Heq3AEeJ0ie
	pC76lk6lbtGD/g1+AfQFBn80tZ6WsKNzoTMHBKXtQc84iUNfL8d/huRoOHScC8fcZPJ6zyDmupDxn
	c/XkQ9QKinjAouZQiEV3SDvuNy8tn5dld5fDryG80X3SU4jVb7v2oCZ8heUtRZIsVlIA=;
Message-ID: <76897e97-8f44-d1c5-f108-045ea48442e5@xen.org>
Date: Fri, 15 Oct 2021 13:10:47 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.2.0
Subject: Re: [PATCH v6 3/3] arm/libxl: Emulated PCI device tree node in libxl
 [and 1 more messages]
To: Michal Orzel <michal.orzel@arm.com>, Ian Jackson <iwj@xenproject.org>
Cc: Bertrand Marquis <Bertrand.Marquis@arm.com>,
 xen-devel@lists.xenproject.org, Rahul Singh <rahul.singh@arm.com>,
 Wei Liu <wl@xen.org>, Anthony PERARD <anthony.perard@citrix.com>,
 Juergen Gross <jgross@suse.com>, Stefano Stabellini
 <sstabellini@kernel.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andre Przywara <Andre.Przywara@arm.com>
References: <cover.1633540842.git.rahul.singh@arm.com>
 <b81b5dea800c8fe47071f3dbd20588b1e472fb99.1633540842.git.rahul.singh@arm.com>
 <7bdac405-a889-15e1-be19-5876f7253855@xen.org>
 <24926.53690.621007.507249@mariner.uk.xensource.com>
 <294BE20A-7E45-405C-BC19-C292295E85E3@arm.com>
 <24927.7235.736221.270358@mariner.uk.xensource.com>
 <8A04B9B2-E816-425E-BF1B-5A8B89F8836C@arm.com>
 <cover.1634221830.git.bertrand.marquis@arm.com>
 <fd9c54a381daa52436b0a1b27cf1bba8e7ff9af9.1634221830.git.bertrand.marquis@arm.com>
 <24936.28385.679884.535704@mariner.uk.xensource.com>
 <6f82141c-8a0b-1e30-a996-223f7c0c508d@xen.org>
 <24937.20922.73382.850023@mariner.uk.xensource.com>
 <56490119-6040-9ab1-aab7-e43975cbb80d@arm.com>
 <24937.27149.222087.933297@mariner.uk.xensource.com>
 <6e29d836-918c-3b15-7608-342b2e4f8475@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <6e29d836-918c-3b15-7608-342b2e4f8475@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Michal,

On 15/10/2021 12:53, Michal Orzel wrote:
> 
> 
> On 15.10.2021 13:46, Ian Jackson wrote:
>> Michal Orzel writes ("Re: [PATCH v6 3/3] arm/libxl: Emulated PCI device tree node in libxl [and 1 more messages]"):
>>> On 15.10.2021 12:02, Ian Jackson wrote:
>>>> Can you leave a comment somewhere (near where c_info.passthrough is
>>>> set) pointing to this use of num_pcidevs ?  That might save someone
>>>> some future confusion.
>>>
>>> Here, c_info->passthrough is set to enabled if either d_config->num_pcidevs or
>>> d_config->num_dtdevs is set. Do you think we need to add there additional comment?
>>> If so can you please help with what should I write there?
>>>
>>> BTW. None of the patch I'm preparing with regards to this discussion modifies libxl_create
>>> where c_info.passthrough i set. Do you still want me to add some comment there?
>>
>> Yes, I think so.  I won't insisting on it if you feel it doesn't make
>> sense.
>>
>> Maybe something like
>>
>>    // NB, on ARM, libxl__arch_blah directly examines num_pcidevs to
>>    // decide whether to enable vpci, rather than using c_info->passthrough.
>>    // This will be insufficient if and when ARM does PCI hotplug.
>>
> Well we are not enabling vpci. We are creating a DT node for it.
> So either I will write:
> /*
>   * Note: libxl_arm directly examines num_pcidevs to decide whether
>   * to create a vPCI DT node, rather than using c_info->passthrough.
>   * This will be insufficient if and when ARM does PCI hotplug.
>   */
> 
> or I will not add any comment (it can be add in the future when "enabling" vpci).
> @Julien?

I would prefer if we had a comment. Your proposal makes more sense as we 
only create the DT.

Long term, I would expect a similar check to be necessary to set the 
vCPI flag at the domain creation. So it would be best to introduce an 
internal field 'vpci' to avoid duplicating that check. (Note I am not 
requesting this change for Xen 4.16).

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Oct 15 12:13:11 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 12:13:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.210417.367276 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbM5G-0001o0-So; Fri, 15 Oct 2021 12:13:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 210417.367276; Fri, 15 Oct 2021 12:13:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbM5G-0001nr-PU; Fri, 15 Oct 2021 12:13:10 +0000
Received: by outflank-mailman (input) for mailman id 210417;
 Fri, 15 Oct 2021 12:13:10 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mbM5F-0001nl-UO
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 12:13:09 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mbM5F-0003a4-Ta
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 12:13:09 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mbM5F-0006Wi-SL
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 12:13:09 +0000
Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89)
 (envelope-from <iwj@xenproject.org>)
 id 1mbM59-0005dj-2x; Fri, 15 Oct 2021 13:13:03 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date
	:Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From;
	bh=5DosDQ0jMg17JaXbVmtbhh3Os9IDrkBEW2QKyuFFuEM=; b=cgf0HQP7jjn1UUnzEmu7k91rnr
	tvrTNQMTozxE1wVQ/5gPBRPIaBg3Ud56xBLAVcO0w6knvOF3J5ty1vEDN0iNjre67ATRuresOZwK1
	05Dm0cET5zM9F5Ylh2hwR54thTqG7LrDRArZUcxHQ7O3oN5+nU70GHJN4Hzvh62Fh67s=;
From: Ian Jackson <iwj@xenproject.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <24937.28750.781635.971114@mariner.uk.xensource.com>
Date: Fri, 15 Oct 2021 13:13:02 +0100
To: Michal Orzel <michal.orzel@arm.com>
Cc: Julien Grall <julien@xen.org>,
    Bertrand Marquis  <Bertrand.Marquis@arm.com>,
    xen-devel@lists.xenproject.org,
    Rahul Singh <rahul.singh@arm.com>,
    Wei Liu <wl@xen.org>,
    Anthony PERARD <anthony.perard@citrix.com>,
    Juergen Gross <jgross@suse.com>,
    Stefano Stabellini <sstabellini@kernel.org>,
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
    Andre Przywara <Andre.Przywara@arm.com>
Subject: Re: [PATCH v6 3/3] arm/libxl: Emulated PCI device tree node in libxl
 [and 1 more messages]
In-Reply-To: <6e29d836-918c-3b15-7608-342b2e4f8475@arm.com>
References: <cover.1633540842.git.rahul.singh@arm.com>
	<b81b5dea800c8fe47071f3dbd20588b1e472fb99.1633540842.git.rahul.singh@arm.com>
	<7bdac405-a889-15e1-be19-5876f7253855@xen.org>
	<24926.53690.621007.507249@mariner.uk.xensource.com>
	<294BE20A-7E45-405C-BC19-C292295E85E3@arm.com>
	<24927.7235.736221.270358@mariner.uk.xensource.com>
	<8A04B9B2-E816-425E-BF1B-5A8B89F8836C@arm.com>
	<cover.1634221830.git.bertrand.marquis@arm.com>
	<fd9c54a381daa52436b0a1b27cf1bba8e7ff9af9.1634221830.git.bertrand.marquis@arm.com>
	<24936.28385.679884.535704@mariner.uk.xensource.com>
	<6f82141c-8a0b-1e30-a996-223f7c0c508d@xen.org>
	<24937.20922.73382.850023@mariner.uk.xensource.com>
	<56490119-6040-9ab1-aab7-e43975cbb80d@arm.com>
	<24937.27149.222087.933297@mariner.uk.xensource.com>
	<6e29d836-918c-3b15-7608-342b2e4f8475@arm.com>
X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu)

Michal Orzel writes ("Re: [PATCH v6 3/3] arm/libxl: Emulated PCI device tree node in libxl [and 1 more messages]"):
> On 15.10.2021 13:46, Ian Jackson wrote:
> > Maybe something like
> > 
> >   // NB, on ARM, libxl__arch_blah directly examines num_pcidevs to
> >   // decide whether to enable vpci, rather than using c_info->passthrough.
> >   // This will be insufficient if and when ARM does PCI hotplug.
> 
> Well we are not enabling vpci. We are creating a DT node for it.
> So either I will write:
> /*
>  * Note: libxl_arm directly examines num_pcidevs to decide whether
>  * to create a vPCI DT node, rather than using c_info->passthrough.
>  * This will be insufficient if and when ARM does PCI hotplug.
>  */

That sounds good to me.  Thank you for correcting me :-).

Ian.


From xen-devel-bounces@lists.xenproject.org Fri Oct 15 12:13:33 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 12:13:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.210420.367287 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbM5d-0002IU-4l; Fri, 15 Oct 2021 12:13:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 210420.367287; Fri, 15 Oct 2021 12:13:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbM5d-0002IN-1Q; Fri, 15 Oct 2021 12:13:33 +0000
Received: by outflank-mailman (input) for mailman id 210420;
 Fri, 15 Oct 2021 12:13:31 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Fqmt=PD=arm.com=Bertrand.Marquis@srs-us1.protection.inumbo.net>)
 id 1mbM5b-0002DJ-Bk
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 12:13:31 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com (unknown
 [40.107.8.73]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 9eefe415-3e72-4429-8a06-6ae4de107654;
 Fri, 15 Oct 2021 12:13:29 +0000 (UTC)
Received: from DB8PR04CA0011.eurprd04.prod.outlook.com (2603:10a6:10:110::21)
 by DBBPR08MB6217.eurprd08.prod.outlook.com (2603:10a6:10:201::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16; Fri, 15 Oct
 2021 12:13:26 +0000
Received: from DB5EUR03FT054.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:10:110:cafe::9c) by DB8PR04CA0011.outlook.office365.com
 (2603:10a6:10:110::21) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.17 via Frontend
 Transport; Fri, 15 Oct 2021 12:13:26 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT054.mail.protection.outlook.com (10.152.20.248) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.15 via Frontend Transport; Fri, 15 Oct 2021 12:13:26 +0000
Received: ("Tessian outbound 16951d3c485e:v103");
 Fri, 15 Oct 2021 12:13:26 +0000
Received: from 7f7a0db48bd4.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 5E0FA01C-8B5B-4039-A71E-EC2888B9FB58.1; 
 Fri, 15 Oct 2021 12:13:16 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 7f7a0db48bd4.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 15 Oct 2021 12:13:16 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com (2603:10a6:4:74::9)
 by DB6PR0801MB1863.eurprd08.prod.outlook.com (2603:10a6:4:76::17) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.25; Fri, 15 Oct
 2021 12:13:05 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955]) by DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955%4]) with mapi id 15.20.4587.031; Fri, 15 Oct 2021
 12:13:05 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9eefe415-3e72-4429-8a06-6ae4de107654
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=5K0K0IGkCQcCOOaFasUKhPNp1jYbyhQEBdP2gn0ExBo=;
 b=m00JD27X5UAjUdpq1zoNyI8ecFSrdLkBWqXwkwvPjsusd2NIR0D5Jv4U+AXAgdADa7BEGdMitv7sSVKiAYEWl9QAWNCMZ3Wp2bi0jpF8kkR3WWu2G+05pOnp93pgchEUgwZUtcs2EH4d9IQBSQPOBtmVuTYiQu/vDs7R0KLSgJM=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 7cec54b3d234ed6a
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=goDRff0lbISlBOdZWLlSyfuzZhIsNCUHx6MIO3Q5B3/V4GXtYDMGKotRGFSaMg8BzJWpJrYZBPd9fuW4B3Pgl0aAknhunFuB/+DCnOWRHB/ePvflVRDNFPh+TXlYxwC3qi+Ey3lyUl9CfOTWUkeiPs/GJRdFQ/XZ5YfgHDL3rlxoimcs+UjysZBrivjHZniNT2AkrtS3wOZl5SlOCkdHSFgch8R5z6FtkjvOMfbyu6iyR8eIHuT9/56D1McSF/fUlZTDx8hSiDf2jZnw/IRkCizKPGNf1hGFX7w7M8r/KYBl1XBa0OJ4hmj+hC+bh5yURNAsKDrnl+Sem6Kuc7MCqA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=5K0K0IGkCQcCOOaFasUKhPNp1jYbyhQEBdP2gn0ExBo=;
 b=NkYdrdyzo1Scf0hyYWohCU6QtrKORbeIeMgjZ8NZ0hYgd0pKC8AV7ixzOeFmttXal0bduIOtsvVNChhLmehUO+yu7vn1RHt/scOW2IPb7qGw8ExB91jHsMpzifLLSfpY/dvVFXEqOBsDdEDV3o7+tEDNsAejYVAtqLGoyHT2ouSlnhG07UlWi4P8ts2QQNs9Ul+89O1KZbwf9Rq15sKB1DUuuXBUqeqQ1X96H/7IQUgZs3XTnNtj7buduC5jwj0z91aO/CXjUIp0jmhqaT3KQRwdiZA4HAydWctxxT2xTTzE/Q3V0NSsIpkZ2dAt+hD4vIwPDduQ0xcbARgg/JdcFw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=5K0K0IGkCQcCOOaFasUKhPNp1jYbyhQEBdP2gn0ExBo=;
 b=m00JD27X5UAjUdpq1zoNyI8ecFSrdLkBWqXwkwvPjsusd2NIR0D5Jv4U+AXAgdADa7BEGdMitv7sSVKiAYEWl9QAWNCMZ3Wp2bi0jpF8kkR3WWu2G+05pOnp93pgchEUgwZUtcs2EH4d9IQBSQPOBtmVuTYiQu/vDs7R0KLSgJM=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>
CC: Jan Beulich <jbeulich@suse.com>, Ian Jackson <iwj@xenproject.org>, Rahul
 Singh <Rahul.Singh@arm.com>, Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>, Paul Durrant
	<paul@xen.org>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v6 2/3] xen/arm: Enable the existing x86 virtual PCI
 support for ARM.
Thread-Topic: [PATCH v6 2/3] xen/arm: Enable the existing x86 virtual PCI
 support for ARM.
Thread-Index:
 AQHXwQrjS6mPrKT7Q06z3N66FcsDAKvTs1WAgAAj+QCAAAF1gIAAAUmAgAAVT4CAAAqRAA==
Date: Fri, 15 Oct 2021 12:13:05 +0000
Message-ID: <A2AAD333-35A2-4250-891C-E8FB885D5660@arm.com>
References: <cover.1634221830.git.bertrand.marquis@arm.com>
 <396b08e2598cf0338e0c7f4ad3cd5cb66db89224.1634221830.git.bertrand.marquis@arm.com>
 <f41f59f7-69ed-e2fe-dc17-434b456cf693@suse.com>
 <57A39480-34DF-4BF5-9B0E-802D30F94BBD@arm.com>
 <24937.21631.538303.29471@mariner.uk.xensource.com>
 <b8fc68e6-2bba-ef11-4c4a-50c2046ecb04@suse.com>
 <YWlnc3b0sj4akUWa@MacBook-Air-de-Roger.local>
In-Reply-To: <YWlnc3b0sj4akUWa@MacBook-Air-de-Roger.local>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3654.120.0.1.13)
Authentication-Results-Original: citrix.com; dkim=none (message not signed)
 header.d=none;citrix.com; dmarc=none action=none header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: 1a79e6b0-9513-4054-2285-08d98fd5313f
x-ms-traffictypediagnostic: DB6PR0801MB1863:|DBBPR08MB6217:
x-ms-exchange-transport-forked: True
X-Microsoft-Antispam-PRVS:
	<DBBPR08MB621728CA88425C24E82B281E9DB99@DBBPR08MB6217.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:10000;OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 ZzoBfj3lJqSElnXEQ2roDXbzVwPerCZ9GwRztbecRm9RSSmNLUJzj7WNRonGiMx1KPajdair4BbLLZU0LWvcDIM7su5G6di0ddSGH0ynwtQ1kweaPd2YtVt4TNO+igFDFEI+m8aMvFM3k1dijnWdA7ccCWS/VEuCnrIQifhdHhGFjrP1rbBui7ISLOUQr8h6Du4sDduWNkm4w/nfyDmud5W8TbHrXMw9KX6D6NnISwAm9dpMemKlLIkQJ1CfhfiiPHq/nZ3/zWo0r664xETFZyFXidCNpq5uDzqHY+knZZldGHjItGWpXsjDqurdXvKWRfD53fraHAXgYOvLizChnCd8QFNETpF1qe6Jk7vgT5ZiE50pxZN82zWDTx7uXxnZ5tMqsU9QwS9ucj8YuzN2uMfl23x6UmhlewfeYniByTgsBUgGfx0Pzkuymuqii+L3cZxaUqXGrwtWW+1fZhZcaCGNArcoE1xZb7jEQEgeWmRI66HhUTYJ7/WWkoIFWxB1x1l34Jn1LlvHoL4JNGTPcSrSOHDJATO/k7lD9CkMz7qMuMtmIpyVS8cWy7Lvf9+Z91IvLY0IeDZmJhINjNtwM9K6aB8OPDeFGhx3jY7Y3km9U4XlBE9Vopc0WgTtZHU6xV8kPQ6dk4DdnvupRDl42+D7AZQ/oow2FV+Jyg3Wszvp2loPXvnDwBk0pVWOTv7qX38mvtVT2aEXpXMa9PnDerTe8ZC/MSsBo1xRpn55O+ba5Tn+KAY/cXJ8xh78K7I6Mt6Ifq62NwtV6cKVQ99nwmO0WigTlDkNC4fWvfpIdzsj7B9GpELkm6Y1Iw6qrTW7H7r0nhh4FaZEsSdCBUv6Rg==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB6PR0801MB2024.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(71200400001)(66476007)(66556008)(8676002)(508600001)(66946007)(38070700005)(966005)(53546011)(66446008)(6486002)(64756008)(76116006)(26005)(6512007)(91956017)(54906003)(36756003)(6506007)(2906002)(5660300002)(83380400001)(186003)(86362001)(122000001)(316002)(38100700002)(6916009)(4326008)(2616005)(7416002)(8936002)(33656002)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-ID: <67551000D17B4A4F9D4BF1BBE2181FF6@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0801MB1863
Original-Authentication-Results: citrix.com; dkim=none (message not signed)
 header.d=none;citrix.com; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT054.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	6742e90c-34ef-4b21-519e-08d98fd52480
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	/2VdfrM+bPf+IWq8J/dvxNyzZm5fIUPtQN3lIFuGdKIhTuNgx8A6gq7MRCefCK2KFGo8DBOqU1tZ2xCD+2yqjQn4dHKlWBTNBCsDOaNHmRTa0HaTPRyDwSZcCNtzDAVbu8YWofMf1YZHo3L1jsf8D5sf6/6cER1Z4pKQ9yQhg7yiITlsos3EPhjzUpcnrns71qyh/ycnFkNSUibPeJnnAncbSkYnblaot2d4+1hdDgo3eXBugGmPB1FzPXevfnhd5748kinitdS9zQSA7v5q/9ZbXJzwpzwqSv2XJ5bN2FwohrtY6EpdJBZWUcxl37ck7+uwo1MUKJFu2DxTkaLsid5l8IwXGZdd+3oYgelzWb3+9mqlFZZ1MOqN7lHUbbKA3GLl8GzHeiz/lj11jo1oOt3VHSWMefAYa8yV8aV9nJoaOOTU5S9GVE9NmUyHz6eBGHbdCvXlwVBK8QSE1u8PpA7YQwaicW7PKRJ/q4zxSWjWUx+UGiTKzZtHlbyfAkdOF73DfLW5azRMnwtpqVONJJhFuIYVXA0LezmilFVcygG0KPIZCR3wU+j6S1f2zfgXmupYNk2RGwoXUmaA2J5xVCzNvbM7uIXPyg5l9zjli1eTHiYVCkbX1abn0hOahDevzRmCojj9pNd3QOA5HFmXX3qUgYGbFaXRftpRfU87BBzvo3QbfohdHEk52qn49Jy3AeWpe1UrFjdZF/ayaEqX7fKv27rjOiHjnfcLrNUaCOj5MdfFvU5PEp/4OwGCt3XlL98XGea3KdFUDjmto52Cs9igswae8dGkz+ZiiGPTXOI=
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(5660300002)(8676002)(2906002)(53546011)(2616005)(26005)(508600001)(316002)(83380400001)(82310400003)(86362001)(8936002)(6506007)(47076005)(33656002)(54906003)(36756003)(966005)(70206006)(6486002)(36860700001)(186003)(70586007)(356005)(81166007)(6862004)(4326008)(6512007)(336012);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2021 12:13:26.6593
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 1a79e6b0-9513-4054-2285-08d98fd5313f
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT054.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB6217

SGkgUm9nZXIsDQoNCj4gT24gMTUgT2N0IDIwMjEsIGF0IDEyOjM1LCBSb2dlciBQYXUgTW9ubsOp
IDxyb2dlci5wYXVAY2l0cml4LmNvbT4gd3JvdGU6DQo+IA0KPiBPbiBGcmksIE9jdCAxNSwgMjAy
MSBhdCAxMjoxODo1OVBNICswMjAwLCBKYW4gQmV1bGljaCB3cm90ZToNCj4+IE9uIDE1LjEwLjIw
MjEgMTI6MTQsIElhbiBKYWNrc29uIHdyb3RlOg0KPj4+IEJlcnRyYW5kIE1hcnF1aXMgd3JpdGVz
ICgiUmU6IFtQQVRDSCB2NiAyLzNdIHhlbi9hcm06IEVuYWJsZSB0aGUgZXhpc3RpbmcgeDg2IHZp
cnR1YWwgUENJIHN1cHBvcnQgZm9yIEFSTS4iKToNCj4+Pj4+IE9uIDE1IE9jdCAyMDIxLCBhdCAw
OTowMCwgSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPiB3cm90ZToNCj4+Pj4+IFRoZSBs
YXR0ZXIgaXMgZmluZSB0byBiZSBwdXQgaGVyZSAoaS5lLiBGVEFPRCBJJ20gZmluZSB3aXRoIGl0
DQo+Pj4+PiBzdGF5aW5nIGhlcmUpLiBGb3IgdGhlIGZvcm1lciBJIGV2ZW4gcXVlc3Rpb24gaXRz
IG9yaWdpbmFsIHBsYWNlbWVudA0KPj4+Pj4gaW4gYXNtLXg4Ni9wY2kuaDogSXQncyBub3QgZ2Vu
ZXJhbGx5IGNvcnJlY3QgYXMgcGVyIHRoZSBQQ0kgc3BlYywgYXMNCj4+Pj4+IHRoZSBidXMgcG9y
dGlvbiBvZiB0aGUgYWRkcmVzcyBjYW4gYmUgYW55d2hlcmUgZnJvbSAxIHRvIDggYml0cy4gQW5k
DQo+Pj4+PiBpbiBmYWN0IHRoZXJlIGlzIGEgcmVhc29uIHdoeSB0aGlzIG1hY3JvIHdhcy9pcyB1
c2VkIGluIG9ubHkgYQ0KPj4+Pj4gc2luZ2xlIHBsYWNlLCBidXQgbm90IGUuZy4gaW4geDg2J2Vz
IGhhbmRsaW5nIG9mIHBoeXNpY2FsIE1DRkcuIEl0DQo+Pj4+PiBpcyBtZXJlbHkgYW4gaW1wbGVt
ZW50YXRpb24gY2hvaWNlIGluIHZQQ0kgdGhhdCB0aGUgZW50aXJlIHNlZ21lbnQgMA0KPj4+Pj4g
aGFzIGEgbGluZWFyIGFkZHJlc3MgcmFuZ2UgY292ZXJpbmcgYWxsIDI1NiBidXNlcy4gSGVuY2Ug
SSB0aGluaw0KPj4+Pj4gdGhpcyB3YW50cyB0byBtb3ZlIHRvIHhlbi92cGNpLmggYW5kIHRoZW4g
cGVyaGFwcyBhbHNvIGJlIG5hbWVkDQo+Pj4+PiBWUENJX0VDQU1fQkRGKCkuDQo+Pj4+IA0KPj4+
PiBPbiBwcmV2aW91cyB2ZXJzaW9uIGl0IHdhcyByZXF1ZXN0IHRvIHJlbmFtZWQgdGhpcyB0byBF
Q0FNIGFuZCBhZ3JlZWQNCj4+Pj4gdG8gcHV0IGlzIGhlcmUuIE5vdyB5b3Ugd2FudCBtZSB0byBy
ZW5hbWUgaXQgdG8gVlBDSSBhbmQgbW92ZSBpdCBhZ2Fpbi4NCj4+Pj4gSSB3b3VsZCBsaWtlIHRv
IGhhdmUgYSBjb25maXJtYXRpb24gdGhhdCB0aGlzIGlzIG9rIGFuZCB0aGUgZmluYWwgbW92ZSBp
ZiBwb3NzaWJsZS4NCj4+Pj4gDQo+Pj4+IEBSb2dlciBjYW4geW91IGNvbmZpcm0gdGhpcyBpcyB3
aGF0IGlzIHdhbnRlZCA/DQo+Pj4gDQo+Pj4gSSB0aGluayBSb2dlciBpcyBub3QgYXZhaWxhYmxl
IHRvZGF5IEknbSBhZnJhaWQuDQo+Pj4gDQo+Pj4gQmVydHJhbmQsIGNhbiB5b3UgZ2l2ZSBtZSBh
IGxpbmsgdG8gdGhlIGNvbW1lbnQgZnJvbSBSb2dlciA/DQo+Pj4gQXNzdW1pbmcgdGhhdCBpdCBz
YXlzIHdoYXQgSSB0aGluayBpdCB3aWxsIHNheToNCj4+PiANCj4+PiBJIHRoaW5rIHRoZSBiZXN0
IHRoaW5nIHRvIGRvIHdpbGwgYmUgdG8gbGVhdmUgdGhlIG5hbWUgYXMgaXQgd2FzIGluDQo+Pj4g
dGhlIG1vc3QgcmVjZW50IHZlcnNpb24gb2YgeW91ciBzZXJpZXMuICBJIGRvbid0IHRoaW5rIGl0
IG1ha2VzIHNlbnNlDQo+Pj4gdG8gYmxvY2sgdGhpcyBwYXRjaCBvdmVyIGEgbmFtaW5nIGRpc2Fn
cmVlbWVudC4gIEFuZCBpdCB3b3VsZCBiZSBiZXN0DQo+Pj4gdG8gbWluaW1pc2UgdW5uZWNlc3Nh
cnkgY2h1cm4uDQo+Pj4gDQo+Pj4gSSB3b3VsZCBiZSBoYXBweSB0byByZWxlYXNlLWFjayBhIG5h
bWUgY2hhbmdlIChwZXJoYXBzIHByb3Bvc2VkIGJvIEphbg0KPj4+IG9yIFJvZ2VyKSBzdXBwb3Np
bmcgdGhhdCB0aGF0IGlzIHRoZSB1bHRpbWF0ZSBtYWludGFpbmVyIGNvbnNlbnN1cy4NCj4+PiAN
Cj4+PiBKYW4sIHdvdWxkIHRoYXQgYXBwcm9hY2ggYmUgT0sgd2l0aCB5b3UgPw0KPj4gDQo+PiBX
ZWxsLCB5ZXMsIGlmIGEgc3Vic2VxdWVudCBuYW1lIGNoYW5nZSBpcyBva2F5LCB0aGVuIEkgY291
bGQgbGl2ZSB3aXRoDQo+PiB0aGF0LiBJJ2Qgc3RpbGwgZmluZCBpdCBvZGQgdG8gcmVuYW1lIGEg
ZnVuY3Rpb24gaW1tZWRpYXRlbHkgYWZ0ZXIgaXQNCj4+IGFscmVhZHkgZ290IHJlbmFtZWQuIEFz
IGV4cHJlc3NlZCBlbHNld2hlcmUsIEkgc3VzcGVjdCBpbiBoaXMgcmVxdWVzdA0KPj4gUm9nZXIg
ZGlkIG5vdCBwYXkgYXR0ZW50aW9uIHRvIGEgdXNlIG9mIHRoZSBmdW5jdGlvbiBpbiBub24tRUNB
TSBjb2RlLg0KPiANCj4gVXNpbmcgTU1DRkdfQkRGIHdhcyBvcmlnaW5hbCByZXF1ZXN0ZWQgYnkg
SnVsaWVuLCBub3QgbXlzZWxmIEkgdGhpbms6DQo+IA0KPiBodHRwczovL2xvcmUua2VybmVsLm9y
Zy94ZW4tZGV2ZWwvYTg2OGUxZTctODQwMC00NWRmLTZlYWEtNjlmMWUyYzk5MzgzQHhlbi5vcmcv
DQo+IA0KPiBJJ20gc2xpZ2h0bHkgbG9zcyBpbiBzbyBtYW55IG1lc3NhZ2VzLiBPbiB4ODYgd2Ug
c3VidHJhY3QgdGhlIE1DRkcNCj4gc3RhcnQgYWRkcmVzcyBmcm9tIHRoZSBwYXNzZWQgb25lIGJl
Zm9yZSBnZXR0aW5nIHRoZSBCREYsIGFuZCB0aGVuIHdlDQo+IGFkZCB0aGUgc3RhcnR0aW5nIGJ1
cyBhZGRyZXNzIHBhc3NlZCBpbiB0aGUgQUNQSSB0YWJsZS4gVGhpcyBpcyBzbyBmYXINCj4gbm90
IG5lZWQgb24gQXJtIEFGQUlDVCBiZWNhdXNlIG9mIHRoZSBmaXhlZCBuYXR1cmUgb2YgdGhlIHNl
bGVjdGVkDQo+IHZpcnR1YWwgRUNBTSByZWdpb24uDQoNCkF0IHRoZSBlbmQgbXkgcGF0Y2ggd2ls
bCBhZGQgaW4geGVuL3BjaS5oOg0KI2RlZmluZSBFQ0FNX0JERihhZGRyKSAgICAgICAgICgoKGFk
ZHIpICYgMHgwZmZmZjAwMCkgPj4gMTIpDQojZGVmaW5lIEVDQU1fUkVHX09GRlNFVChhZGRyKSAg
KChhZGRyKSAmIDB4MDAwMDBmZmYpDQoNCk5vdyBzZWVpbmcgdGhlIGNvbW1lbnQgdGhlIHF1ZXN0
aW9uIGlzIHNob3VsZCB0aG9zZSBiZSByZW5hbWVkIHdpdGggYSBWUENJDQpwcmVmaXggYW5kIGJl
IG1vdmVkIHRvIHhlbi92cGNpLmguDQoNClNvIGZhciBFQ0FNX0JERiBpcyBvbmx5IHVzZWQgaW4g
dnBjaV9tbWNmZ19kZWNvZGVfYWRkciB3aGljaCBpcyBvbmx5IGNhbGxlZA0KYmVmb3JlIGNhbGxp
bmcgdnBjaV9lY2FtX3tyZWFkL3dyaXRlfS4NCg0KRUNBTV9SRUdfT0ZGU0VUIGlzIG9ubHkgdXNl
ZCBpbiBhcm0gdnBjaSBjb2RlLg0KDQpEbyB5b3UgdGhpbmsgdGhlIGN1cnJlbnQgc3RhdGUgaXMg
b2sgb2YgdGhlIHJlbmFtaW5nICsgbW92aW5nIHNob3VsZCBiZSBkb25lID8NCg0KQ2hlZXJzDQpC
ZXJ0cmFuZA0KDQo=


From xen-devel-bounces@lists.xenproject.org Fri Oct 15 12:14:09 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 12:14:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.210430.367298 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbM6D-0002xR-I5; Fri, 15 Oct 2021 12:14:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 210430.367298; Fri, 15 Oct 2021 12:14:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbM6D-0002xK-F9; Fri, 15 Oct 2021 12:14:09 +0000
Received: by outflank-mailman (input) for mailman id 210430;
 Fri, 15 Oct 2021 12:14:07 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mbM6B-0002x8-Lu
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 12:14:07 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mbM6B-0003bn-LA
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 12:14:07 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mbM6B-0006eg-KQ
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 12:14:07 +0000
Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89)
 (envelope-from <iwj@xenproject.org>)
 id 1mbM64-0005ed-Ut; Fri, 15 Oct 2021 13:14:01 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date
	:Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From;
	bh=mz7CXo4IvmDJBATn8fvcvOFPhfjCyiYxGy3yam05NNM=; b=Qmwc78O30+8ogQJSvqy19a3daO
	i0pnOtkth9/6P9iNKVptmEH39OqOyZe6meJS5V53dOtAUYUBHsnUzwqpoOq9cmHp/2bc7adn4kDMC
	4/GdqREFySLV1KTCDtYMThwsFBdCQl59bOhkGh96rk8xv7QGMlN6p0aK21Lz9qdv6Rn4=;
From: Ian Jackson <iwj@xenproject.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <24937.28808.688889.814621@mariner.uk.xensource.com>
Date: Fri, 15 Oct 2021 13:14:00 +0100
To: Julien Grall <julien@xen.org>
Cc: Michal Orzel <michal.orzel@arm.com>,
    Bertrand Marquis <Bertrand.Marquis@arm.com>,
    xen-devel@lists.xenproject.org,
    Rahul Singh <rahul.singh@arm.com>,
    Wei Liu <wl@xen.org>,
    Anthony PERARD <anthony.perard@citrix.com>,
    Juergen Gross <jgross@suse.com>,
    Stefano Stabellini  <sstabellini@kernel.org>,
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
    Andre Przywara <Andre.Przywara@arm.com>
Subject: Re: [PATCH v6 3/3] arm/libxl: Emulated PCI device tree node in libxl
 [and 1 more messages]
In-Reply-To: <76897e97-8f44-d1c5-f108-045ea48442e5@xen.org>
References: <cover.1633540842.git.rahul.singh@arm.com>
	<b81b5dea800c8fe47071f3dbd20588b1e472fb99.1633540842.git.rahul.singh@arm.com>
	<7bdac405-a889-15e1-be19-5876f7253855@xen.org>
	<24926.53690.621007.507249@mariner.uk.xensource.com>
	<294BE20A-7E45-405C-BC19-C292295E85E3@arm.com>
	<24927.7235.736221.270358@mariner.uk.xensource.com>
	<8A04B9B2-E816-425E-BF1B-5A8B89F8836C@arm.com>
	<cover.1634221830.git.bertrand.marquis@arm.com>
	<fd9c54a381daa52436b0a1b27cf1bba8e7ff9af9.1634221830.git.bertrand.marquis@arm.com>
	<24936.28385.679884.535704@mariner.uk.xensource.com>
	<6f82141c-8a0b-1e30-a996-223f7c0c508d@xen.org>
	<24937.20922.73382.850023@mariner.uk.xensource.com>
	<56490119-6040-9ab1-aab7-e43975cbb80d@arm.com>
	<24937.27149.222087.933297@mariner.uk.xensource.com>
	<6e29d836-918c-3b15-7608-342b2e4f8475@arm.com>
	<76897e97-8f44-d1c5-f108-045ea48442e5@xen.org>
X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu)

Julien Grall writes ("Re: [PATCH v6 3/3] arm/libxl: Emulated PCI device tree node in libxl [and 1 more messages]"):
> Long term, I would expect a similar check to be necessary to set the 
> vCPI flag at the domain creation. So it would be best to introduce an 
> internal field 'vpci' to avoid duplicating that check. (Note I am not 
> requesting this change for Xen 4.16).

Yes, I agree with all of that.

Ian.


From xen-devel-bounces@lists.xenproject.org Fri Oct 15 12:14:37 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 12:14:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.210434.367308 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbM6b-0003XK-QE; Fri, 15 Oct 2021 12:14:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 210434.367308; Fri, 15 Oct 2021 12:14:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbM6b-0003XD-N2; Fri, 15 Oct 2021 12:14:33 +0000
Received: by outflank-mailman (input) for mailman id 210434;
 Fri, 15 Oct 2021 12:14:31 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Z1Iv=PD=citrix.com=Kevin.Stefanov@srs-us1.protection.inumbo.net>)
 id 1mbM6Z-0003Vn-TU
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 12:14:31 +0000
Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 72fbfd62-2db1-11ec-8231-12813bfff9fa;
 Fri, 15 Oct 2021 12:14:30 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 72fbfd62-2db1-11ec-8231-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1634300070;
  h=from:to:cc:subject:date:message-id:mime-version:
   content-transfer-encoding;
  bh=YYWuWAVeA6+IHR6oFqCP4UO+MQc3A44zw+1QAAoBvB0=;
  b=gAO/vMquM1Y8agx8v+FCklcr1sokZ12pFUCsJVhJlfe0x0tcnXdgjNBj
   13XCDIuNergMocbSp0tKlyeJoGcggt+YQhbHogL6vVDp8xNoTx76NUhhj
   yjFIcm4hF5GuiSnrlJKGzDdUzP2mjF6il1xTCLd06Eg9d4RJLghleVpt2
   4=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: 6DVR2/cz0CG6qbFLu3FmvdYkc15Eo/CKY93zqgCwgYJSPOQbtG1MalTK4Aa7MzX6U8NuEuRpk/
 XuM239J+Wl4xBZ3IKW7vLxD2EaXlNAvLN3IG2NmgcEX8TW5o+1RBnsusQ6JPdkgdeE16LUzZxc
 OwbDelZgJEYH+00/qKAYFUo0uDkdl/8AelYiuFLeHjTUJkupT+2jtZtO+nvPkNd+x2p0Vgq0a1
 c/IldJC23de/RXFVTwgoTrslIZ3LMO8PMbfsQ7+MsELCRQ6GV93blPNhE2Lcp0Re/4bxWbpZyV
 oj3o5HHUnXHrb7nhaLeJPB50
X-SBRS: 5.1
X-MesageID: 54844375
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:clFLQalkXiHsf+aZtimkWhfo5gxqIURdPkR7XQ2eYbSJt1+Wr1Gzt
 xJLCDzXP/6IZWOkedx0a4mw8R8HupXdydFjTwU4pS9kHiMWpZLJC+rCIxarNUt+DCFioGGLT
 Sk6QoOdRCzhZiaE/n9BClVlxJVF/fngqoDUUYYoAQgsA185IMsdoUg7wbdg2tc12YHR7z6l4
 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc
 s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4
 NZyvKaPRQ4OArfRwLRFSBZaPiRfFKITrdcrIVDn2SCS50jPcn+qyPRyFkAme4Yf/46bA0kXq
 6ZecmpUKEne2aTmm9pXScE17ignBOrmIoIZ/Ep8wD/QC/E4aZvCX7/L9ZlT2zJYasVmQKqOO
 5ZCNmcHgBLoeiNhJkYtIb0HhsSaoFPQS2R3lXGyuv9ii4TU5FMoi+W8WDbPQfSVQe1Fk0Deo
 XjJl0z7HxUbOdq32TeDtHW2iYfnnyzhX5kJPKal7fMsi1qWrkQDBRtTWValrP2Rjk+lR8kZO
 0ES4jApr6U56AqsVNaVdxynolaUsxgEQd1SHuYmrgaXxcLpDx2xXzZeCGQbMZp/6ZFwFWdCO
 kK1c83BBgNmioKZQFWh7KrM/WupNio4KE4ranpRJeca2OXLrIY2hxPJa99sFq+pk9H4cQ3NL
 yC2QDsW3OpL05Zav0mv1RWe2Wj0/8mWJuIgzlyPBjrN0+9vWGKyi2VEA3Dg5vFcMJ3RcFCFu
 HUV8yR1xLFTVc/T/MBhreNkIV1I2xpnGGGD6bKMN8N4n9hIx5JFVdsNiN2ZDB04WvvogRezP
 CfuVfp5vfe/xkeCY65teJ6WAM8316XmHtmNfqmKNYYUOcIqKVbXpn8GiausM4bFyxVEfUYXY
 s/zTCpRJSxCVfQPIMSeFo/xLoPHNghhnDiOFPgXPjys0KaEZW79dFv2GADmUwzN14vd+F+92
 48Gb6OikkwDOMWjMni/2dNCdjgicClkba0aXuQKL4Zv1CI9Qzp/YxIQqJt8E7FYc1N9zbmVo
 CvkAREFkTISRxTvcG23V5yqU5u3Nb4XkJ7xFXJE0Y+A1ydxbICxwr0YcpdrL7Ar+PY6lax/T
 uUfetXGCfNKE2yV9zMYZJj7jYpjaBX02l7eY3v7OGAyL8x6WgjE2t74ZQ+zpiMAOTW66Jklq
 Lq62wKFHZdaH1Z+DNzbYe6Exk+quSRPg/p7WkbFe4EBeEjl/IVwBTb2i/s7f5MFJRnZn2PI3
 AeKGxYI4+LKptZtotXOgKmFqaavEvd/QRUGTzWKs+7uOHCDrGS5wIJGXOKZRhznVTv5qPe4e
 OFY7/DgK/lbzlxEhJVxTuRwxqUk6tqx+7IDllZ4HG/GZkiAA697JiXUxtFGs6BAy+MLuQayX
 U7TqNBWNa/QZZHgGV8VYgEkcv6CxbcfnTyLtaY5J0Dz5SlW+rubUBoNY0nQ2XIFdLYlYpk4x
 eoBudIN713tgxUnBd+KkyRI+jneNXcHSagm6skXDYKDZtDHEb2ejUgw0hPL3aw=
IronPort-HdrOrdr: A9a23:Nz4HRq8mCyOhktjIHiNuk+ESdb1zdoMgy1knxilNoERuA6qlfr
 OV7Y0mPHjP+XAssRAb6Je90ca7MBfhHPJOgLX5Xo3SBTUO2lHYS72KhLGKq1eMd0KRygc079
 Y5T0EUMqySMbEOt7ee3ODOKadD/DDoysCVbbi09RxQpEpRGtldBk9Ce32m++dNNVN77NwCZc
 GhDjYsnUvoRZzpBP7LcEXsoYL41qr2fdvdEGQ772VO0njHsdt0gISKVyRxDn8lInZy6KZn/m
 7fnwPj4KK/9/m91x/HzmfWq49bgd3717J4dbixY2cuW0vRYyuTFfZcsoe5zUUISK3F0idbrP
 Dc5xM7e8hj4XLYeW+45RH33RP7zToo43j+jVeFnHrqu6XCNXkHItsEgZgcfgrS6kImst052r
 lMxXiFu51eCg6FlDjh5sLPSwphmiOP0DAfead6tQ0RbWNpAIUh47D20ihuYdY99GOT0vFrLA
 EYZPusqMq/UTihHjDkVhoG+q3uYp0XJGb2fqEvgL3o79FmpgEL86JD/r1jop4pzuNDd3GSj9
 60cJhVqA==
X-IronPort-AV: E=Sophos;i="5.85,375,1624334400"; 
   d="scan'208";a="54844375"
From: Kevin Stefanov <kevin.stefanov@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Kevin Stefanov <kevin.stefanov@citrix.com>, Ian Jackson
	<iwj@xenproject.org>, Wei Liu <wl@xen.org>, Juergen Gross <jgross@suse.com>,
	Julien Grall <julien@xen.org>, Andrew Cooper <andrew.cooper3@citrix.com>
Subject: [PATCH v2] tools/tests: Make E2BIG non-fatal to xenstore unit test
Date: Fri, 15 Oct 2021 13:14:09 +0100
Message-ID: <20211015121409.24434-1-kevin.stefanov@citrix.com>
X-Mailer: git-send-email 2.25.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

Xenstore's unit test fails on read and write of big numbers if
quota-maxsize is set to a lower number than those test cases use.

Output a special warning instead of a failure message in such cases
and make the error non-fatal to the unit test.

Signed-off-by: Kevin Stefanov <kevin.stefanov@citrix.com>
---
CC: Ian Jackson <iwj@xenproject.org>
CC: Wei Liu <wl@xen.org>
CC: Juergen Gross <jgross@suse.com>
CC: Julien Grall <julien@xen.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>

v2: Adhere to coding style, use E2BIG instead of 7, set ret to 0
---
 tools/tests/xenstore/test-xenstore.c | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/tools/tests/xenstore/test-xenstore.c b/tools/tests/xenstore/test-xenstore.c
index d3574b3fa2..f8423e568e 100644
--- a/tools/tests/xenstore/test-xenstore.c
+++ b/tools/tests/xenstore/test-xenstore.c
@@ -110,8 +110,17 @@ static int call_test(struct test *tst, int iters, bool no_clock)
             break;
     }
 
+    /* Make E2BIG non-fatal to the test */
     if ( ret )
-        printf("%-10s: failed (ret = %d, stage %s)\n", tst->name, ret, stage);
+    {
+	if ( ret == E2BIG )
+        {
+            printf("%-10s: Not run - argument list too long\n", tst->name);
+            ret = 0;
+        }
+        else      
+            printf("%-10s: failed (ret = %d, stage %s)\n", tst->name, ret, stage);
+    }
     else if ( !no_clock )
     {
         printf("%-10s:", tst->name);
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Fri Oct 15 12:18:42 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 12:18:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.210447.367320 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbMAb-0004JL-Cc; Fri, 15 Oct 2021 12:18:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 210447.367320; Fri, 15 Oct 2021 12:18:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbMAb-0004JE-7x; Fri, 15 Oct 2021 12:18:41 +0000
Received: by outflank-mailman (input) for mailman id 210447;
 Fri, 15 Oct 2021 12:18:40 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=FGCa=PD=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mbMAZ-0004J8-Sc
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 12:18:39 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 06391e48-2db2-11ec-8233-12813bfff9fa;
 Fri, 15 Oct 2021 12:18:38 +0000 (UTC)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2107.outbound.protection.outlook.com [104.47.17.107])
 (Using TLS) by relay.mimecast.com with ESMTP id
 de-mta-18-eouw6wRvN82ajG1vlupPPQ-1; Fri, 15 Oct 2021 14:18:36 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB7087.eurprd04.prod.outlook.com (2603:10a6:800:12a::15)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.17; Fri, 15 Oct
 2021 12:18:33 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.017; Fri, 15 Oct 2021
 12:18:33 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6PR08CA0027.eurprd08.prod.outlook.com (2603:10a6:20b:c0::15) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.15 via Frontend Transport; Fri, 15 Oct 2021 12:18:32 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 06391e48-2db2-11ec-8233-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634300317;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=gBLt3FjmvUTpXFBaKSKWoslIsmUk90v9LPziO8f2KyA=;
	b=XhdcgMtDNoy07+4DD3JL1HdDf3sB+irrpT4jaeLmvwe6XAqojFAXkMBoDKoslKm/YhOeKI
	RjcH1hmXJ8xbdgSzmvx34klJg/MK3Rbu75nZeIIxotUeYwzconj8WVlMbFoKBj/bNuvVDF
	IREZNpfTsFakXWiPtXezsPKAyKhc2w0=
X-MC-Unique: eouw6wRvN82ajG1vlupPPQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Qykf3TF14UqtbOwltVxevPwZjgU42m/HDK1pXSa+dlOPp07M/wt3PoyU5kP11OYg2Z/oVFwnstyzsAe+OCbrqYMWjGQkuAePThBCx2d3Xu1Ll3Ryna19rdikN4TZJX6MSb2tEBrUbn00PZ8zH+g5r64haTGmgdq6T2fCkH3NQvq8hJadY6MOQex7+kpVe+gpj0zXKzdxd8cQ5cTaNU+B+WGBavs7sUaJb9TWKssOypgECXZ8NDoUV406y6FJUe7U0Jjad2nrpJ+Jbw1vHiy2E+DzmL+x/hvC9wGJOZmBY18HdVsVOuOSxn+x/Oyu4cH+WQf+uGuWNWyBCzCXWLhFwA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=mIrenqwBTsZZYWTwlnlT9zUDNrK0dtDQqKf+P3ZijvE=;
 b=HM+/3CSnjgyUQVeormfJx7PrmXZiHqYPeXoQeWqo7/+SRds7QIOwjunqW+oarBPc05YqPhCwvpK1LtN1/GBkM6u+Ad1OKKAgqE/TjWZ21H3s89KTDO5oyeq/MTaC+bdFuQvuhHo3yAdZ9psxkhnHXGAyNoQ9gUxCgmHa1bwAJKiw8sPa8D+m26heddBVroMlei0lLLreGU2HcY5r/Fk6UZf57Ea/xZ0hoaxuHuUOTL4JeDaw5+3CM2jElO8JbUYUJ3VQcBq8Wr5ARaHiUpR3m33+YdUHzaGJCxq82dq/JP+McNkrc9ziKuUnYotIFtYg8EtKi/ADHc/VKW6ry9mG0g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [PATCH v6 2/3] xen/arm: Enable the existing x86 virtual PCI
 support for ARM.
To: Bertrand Marquis <Bertrand.Marquis@arm.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: Ian Jackson <iwj@xenproject.org>, Rahul Singh <Rahul.Singh@arm.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
 Paul Durrant <paul@xen.org>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <cover.1634221830.git.bertrand.marquis@arm.com>
 <396b08e2598cf0338e0c7f4ad3cd5cb66db89224.1634221830.git.bertrand.marquis@arm.com>
 <f41f59f7-69ed-e2fe-dc17-434b456cf693@suse.com>
 <57A39480-34DF-4BF5-9B0E-802D30F94BBD@arm.com>
 <24937.21631.538303.29471@mariner.uk.xensource.com>
 <b8fc68e6-2bba-ef11-4c4a-50c2046ecb04@suse.com>
 <YWlnc3b0sj4akUWa@MacBook-Air-de-Roger.local>
 <A2AAD333-35A2-4250-891C-E8FB885D5660@arm.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <887d99e8-bcc5-f854-ceed-a38701e1ad1d@suse.com>
Date: Fri, 15 Oct 2021 14:18:30 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <A2AAD333-35A2-4250-891C-E8FB885D5660@arm.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6PR08CA0027.eurprd08.prod.outlook.com
 (2603:10a6:20b:c0::15) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: a47baf78-a9a5-4ede-57a4-08d98fd5e822
X-MS-TrafficTypeDiagnostic: VI1PR04MB7087:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB70872B1FF2C29ADD0D9D0645B3B99@VI1PR04MB7087.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	6ovk9tetiSsHpp3l6VxnVrp+RLRwPE3EBEb2q0ItFWKAOo5ZxiEcgykSVKtZNAwYrm3Wd18rxNk/WV8bJHjJZUhHfwrbngJwvW+heBwSks7rZqyitSpD9GjXwd+wF7K3+ZI82/rhKC/IX3PVklKtCjmElF1qBLVd8cEBmIfY1lN9vRKsz5nE4MSShjV27HMmILKXpx85v+NKo8aBPUntv98qBH6q9nMRhcUNmQDECYh+bk27a16Iy/Xdu+aI3tly3Q3cOZJZ/Z/ceMA1sYnIyzN3UnnooW06ZWUw4UkIeJ8TN/rK0jijRcgeRRKsNqixmuIqktxUY0Zj8lbqimjC+YsR8ENXpe8gwVnMVauQWiW9AzzEAOGnqBkQbIdO4jg1Q/9V/latFP8qmbQnjmW+VhcKN/mMcD8M/FI2U3u/shNdQ7Vidnqtn9awUadpPco30YTGws9sUL1bX8bRNwyxdAQiSrVYuJ5rqLxGzU4XXr5cjo42s0NrKSLLjkJ1SyFr4+9R+2N9ErFqwxRbuHmVfEANtjB7cdN9EqIYV1O9lOoVz8kBoVH72Y8px7LTG3KCrwNAGMjZ0VFsOE94q2vlKaiUtp+T0EC8xH47kLLHLFsrw/iCXODJJZx1+h4ZN1u6whc2fCJ4XMwxqM6aWSbgCQJZsg/t38YpAZ1QvYWodZsIM6WUMhLCuchbDhKcwzoEfAUzJwKcQKz3/brBnOQobrNJu+AK2zvGR++4oc1BFep94MfxSpdRrwhSAxAMyut3JacZuv6BYIA0Z7fthgS1jatqvQqEM7BUjy7T1SIiu02CwpIs6CiQ87TuXuwohpZYJzzL9LlUf2A1DGzpDuiGeA==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(83380400001)(2906002)(53546011)(966005)(6486002)(66556008)(66946007)(66476007)(38100700002)(31696002)(31686004)(36756003)(8676002)(7416002)(16576012)(110136005)(54906003)(316002)(508600001)(5660300002)(956004)(2616005)(86362001)(186003)(8936002)(4326008)(26005)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?lWQIz7D9MuciFgtkCWYtt3ObOlwUv9mvom7Q4fdrV7pNBwUlsmHME/yatlEp?=
 =?us-ascii?Q?ZlwVIgncldWrvbKZEE6WN81mvMUKZdwCBm7SMeDY5ApQZmmljwnu3W9rYHzX?=
 =?us-ascii?Q?N1yHGTGviEqc46s7Rl7aHBlIQGKCu2RO57GdMl1nUwYC+JAFH0BCNzlQRfcH?=
 =?us-ascii?Q?2PmWfimhQuF+g5ZF6YlJ5gdggFSu3wLkZ26v0r+pmA8iuZ5FhiyqQfktsXqV?=
 =?us-ascii?Q?WMziafpR1VckV6buMbufzCCJk7q25YYuYITEmp+GumtR+aV9mDAt1c5pb3/g?=
 =?us-ascii?Q?dSVnyUbgfrHaV9+n9gAwn0RMLKSe3VqG6pLxpSMnRq/qOhym9MSCeoje+Xei?=
 =?us-ascii?Q?bLO1VxkupWgeORI2CY4wI2TmSL4LIhkJxqGJygRkFXDTJzQujdbCziLus9qb?=
 =?us-ascii?Q?sD3FcQKP5T3wfcc1+8x8nFzYnsJjZ74QbymyOsDLGJPE3Dqpv92IiLk8SPZR?=
 =?us-ascii?Q?uhOBqycveIuOKp/Mq8f77sQOTVOJXg1y7Go1PY0E2XlZudDHdwxy09BJCOfU?=
 =?us-ascii?Q?nFvR57+5oxvyrCQUJN50pmKM+EF0HDMR5PAfMN/fvAcv2KvkunVIg+XDNN3s?=
 =?us-ascii?Q?CvXkswMBTrTfgCmaM2PK09knXXM9AfgaQraQsPZCM/64idfFR9FZ49+GgIll?=
 =?us-ascii?Q?hjnB6d7/BrUokp3B8Fj5bcOh9X62Y4SOBMQevUfJl7eaFr6M8CoePsh0avRv?=
 =?us-ascii?Q?8AO22rpbkOVEGzIyx8bxW/pl+HdcX0/vb3D7Lkfymq1DYfSrfYTDpe6m3yha?=
 =?us-ascii?Q?I2E6I3uescth+xHtfSp571z2KBvwd/EFBUQZLfJBGf0WtKXois6pgorfcPxx?=
 =?us-ascii?Q?MTMsGuGNUozy9SnYO5mE9a2fi9h+rjqhZHEZcCxulVISIp5Ia3AceBgEIFuk?=
 =?us-ascii?Q?UAOrjZlsdE14WzBJlNLQ6k/+Kp42cZiXzjm+oYBX8b3wJ9DLPtt/V1fdKW9C?=
 =?us-ascii?Q?ffgEBmqBMabihawJ9vHFkSKa54FzVvtPBTXatABr1Kn//WIZ9uu2Wf5k3hw2?=
 =?us-ascii?Q?VeBJ4MeTxOFlfGEfHLvpAgL3l76DAs8RBKp1H6SLETJ/QT4mmavTBewE9h8Z?=
 =?us-ascii?Q?QGPiC9G+6kymKmsMxUiNas1fZWaKo+0S62k8iAXF4oxFL+0iRykyitChs5Qg?=
 =?us-ascii?Q?60+RG7nv0gq8Jvuabrihps0DvdfA4r/tDAGUQVmKPLNFPcnqSxJTpQalfan+?=
 =?us-ascii?Q?dRbFetnskw7HtW86dGFQ6QVhext1tBa342glJ/2royq9Lww4wLjqM/NsluPM?=
 =?us-ascii?Q?U/Y7E6bUALTezP4CinTy6qAKPJN+s8RLJ+Sf8dxNqV3aJieuAXpUZxpJnwu5?=
 =?us-ascii?Q?+xprVHq9rmpKhX6Ir+oLjIdV?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a47baf78-a9a5-4ede-57a4-08d98fd5e822
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2021 12:18:33.6315
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 26BJff3PfExzXG8v9KlPwnJKyMIOFHcFKiaJvxAgjOXeK5BzBtQj/P22gn4dcZPDUfRKZUE0Be/qwDlV74Syug==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7087

On 15.10.2021 14:13, Bertrand Marquis wrote:
> Hi Roger,
>=20
>> On 15 Oct 2021, at 12:35, Roger Pau Monn=C3=A9 <roger.pau@citrix.com> wr=
ote:
>>
>> On Fri, Oct 15, 2021 at 12:18:59PM +0200, Jan Beulich wrote:
>>> On 15.10.2021 12:14, Ian Jackson wrote:
>>>> Bertrand Marquis writes ("Re: [PATCH v6 2/3] xen/arm: Enable the exist=
ing x86 virtual PCI support for ARM."):
>>>>>> On 15 Oct 2021, at 09:00, Jan Beulich <jbeulich@suse.com> wrote:
>>>>>> The latter is fine to be put here (i.e. FTAOD I'm fine with it
>>>>>> staying here). For the former I even question its original placement
>>>>>> in asm-x86/pci.h: It's not generally correct as per the PCI spec, as
>>>>>> the bus portion of the address can be anywhere from 1 to 8 bits. And
>>>>>> in fact there is a reason why this macro was/is used in only a
>>>>>> single place, but not e.g. in x86'es handling of physical MCFG. It
>>>>>> is merely an implementation choice in vPCI that the entire segment 0
>>>>>> has a linear address range covering all 256 buses. Hence I think
>>>>>> this wants to move to xen/vpci.h and then perhaps also be named
>>>>>> VPCI_ECAM_BDF().
>>>>>
>>>>> On previous version it was request to renamed this to ECAM and agreed
>>>>> to put is here. Now you want me to rename it to VPCI and move it agai=
n.
>>>>> I would like to have a confirmation that this is ok and the final mov=
e if possible.
>>>>>
>>>>> @Roger can you confirm this is what is wanted ?
>>>>
>>>> I think Roger is not available today I'm afraid.
>>>>
>>>> Bertrand, can you give me a link to the comment from Roger ?
>>>> Assuming that it says what I think it will say:
>>>>
>>>> I think the best thing to do will be to leave the name as it was in
>>>> the most recent version of your series.  I don't think it makes sense
>>>> to block this patch over a naming disagreement.  And it would be best
>>>> to minimise unnecessary churn.
>>>>
>>>> I would be happy to release-ack a name change (perhaps proposed bo Jan
>>>> or Roger) supposing that that is the ultimate maintainer consensus.
>>>>
>>>> Jan, would that approach be OK with you ?
>>>
>>> Well, yes, if a subsequent name change is okay, then I could live with
>>> that. I'd still find it odd to rename a function immediately after it
>>> already got renamed. As expressed elsewhere, I suspect in his request
>>> Roger did not pay attention to a use of the function in non-ECAM code.
>>
>> Using MMCFG_BDF was original requested by Julien, not myself I think:
>>
>> https://lore.kernel.org/xen-devel/a868e1e7-8400-45df-6eaa-69f1e2c99383@x=
en.org/
>>
>> I'm slightly loss in so many messages. On x86 we subtract the MCFG
>> start address from the passed one before getting the BDF, and then we
>> add the startting bus address passed in the ACPI table. This is so far
>> not need on Arm AFAICT because of the fixed nature of the selected
>> virtual ECAM region.
>=20
> At the end my patch will add in xen/pci.h:
> #define ECAM_BDF(addr)         (((addr) & 0x0ffff000) >> 12)

Since you still make this proposal, once again: I'm not going to
accept such a macro in this header, whatever the name. Its prior
placement was wrong as well. Only ...

> #define ECAM_REG_OFFSET(addr)  ((addr) & 0x00000fff)

... this one is fine to live here (and presumably it could gain uses
elsewhere).

Jan

> Now seeing the comment the question is should those be renamed with a VPC=
I
> prefix and be moved to xen/vpci.h.
>=20
> So far ECAM_BDF is only used in vpci_mmcfg_decode_addr which is only call=
ed
> before calling vpci_ecam_{read/write}.
>=20
> ECAM_REG_OFFSET is only used in arm vpci code.
>=20
> Do you think the current state is ok of the renaming + moving should be d=
one ?
>=20
> Cheers
> Bertrand
>=20



From xen-devel-bounces@lists.xenproject.org Fri Oct 15 12:21:26 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 12:21:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.210456.367330 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbMDB-0005gI-Q8; Fri, 15 Oct 2021 12:21:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 210456.367330; Fri, 15 Oct 2021 12:21:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbMDB-0005gB-ND; Fri, 15 Oct 2021 12:21:21 +0000
Received: by outflank-mailman (input) for mailman id 210456;
 Fri, 15 Oct 2021 12:21:20 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=FGCa=PD=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mbMDA-0005g5-B7
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 12:21:20 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 66564350-2db2-11ec-8235-12813bfff9fa;
 Fri, 15 Oct 2021 12:21:19 +0000 (UTC)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2168.outbound.protection.outlook.com [104.47.17.168])
 (Using TLS) by relay.mimecast.com with ESMTP id
 de-mta-1-XW6KcitBPvC5VAsXFWK4Mw-2; Fri, 15 Oct 2021 14:21:17 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB4384.eurprd04.prod.outlook.com (2603:10a6:803:6f::26)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18; Fri, 15 Oct
 2021 12:21:13 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.017; Fri, 15 Oct 2021
 12:21:13 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM5PR0602CA0011.eurprd06.prod.outlook.com (2603:10a6:203:a3::21) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.14 via Frontend
 Transport; Fri, 15 Oct 2021 12:21:13 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 66564350-2db2-11ec-8235-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634300478;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=uFI1l6HpFJqS7tyEPeOP1lybrbAvgDqn8oz4gNy3HqQ=;
	b=OOLFJySmIkz0NXbrr//r0cChmAohwqb4C0jfR8370Kr2Dr3lewYBpt4Y+M9KjpKg2brKaj
	sI4/e73auxSyyf7sjB0VVxMptWFt6dzvUNn1ilwD1sspWxe04dv7mgYjGPh61lsJpV875q
	ZBh/TbQNab+/5cTYbSW8UVDCi8ydLF8=
X-MC-Unique: XW6KcitBPvC5VAsXFWK4Mw-2
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=esILonrKT8iSBvigaB67gU4Q08kZzpIlsGb0qc+tVY0TeCW7sR2kcFQN3NgBD0hk/dd7KRLJ7oQ6PVzlwWrhaDRjJ68Fgh6TaiVdV32CYD2Xn7pTpqWeGoYZFujlY1MPgpzmHzgPo4LPZMToZypbRBmWvesBIlI1B9ibF1fu7id8oyC5JR2xzwlurgjtr48kqFMyNu/yzoo2rFvcm0FzXrdBi7QDOh3On4xJZGvofs80mfE5Y0YlBcpLkPPSMji1G+zWrxppmKzZwb3v67xcEizAgGm1V/A5l7/gycQcyzcoyRDjFF/T1FdFtvBiU/0XIxcP1pkBuvzGn0sQvFN/Gw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=uFI1l6HpFJqS7tyEPeOP1lybrbAvgDqn8oz4gNy3HqQ=;
 b=U0eTkN7xIV7Cb289SinWqMHAcH2E5egm0IyJbr/j1+y3TpnvaNJSGBU3Se9fjO90FIbi7F7LIOj5rC98s+KnrkHr+AwIZBU1okog09oymKx8UuuB22pP7vJV1MSsAhX7DXQmFTyCxQebG8FgFl01poR5haKqye4h/JTLhipae/d8oOM1544Fa3CG0qB6DHwCe4SBFOG81yCjtzdn0lOtXWBg5M2tx+zqJvslWoLDXIdedEOTWKMM6dPb270eoxdYRzogA258/ia/hH/w4mhN4KzCSMoC/GfYVqZ7pDOxFALvLmO9JuzWZ66tQP0TAIHsUXUeUDyfmJy74EtDiA57Tg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [PATCH v2] tools/tests: Make E2BIG non-fatal to xenstore unit
 test
To: Kevin Stefanov <kevin.stefanov@citrix.com>
Cc: Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>,
 Juergen Gross <jgross@suse.com>, Julien Grall <julien@xen.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 Xen-devel <xen-devel@lists.xenproject.org>
References: <20211015121409.24434-1-kevin.stefanov@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <4f65bee5-f8cc-cbb2-9731-5367f4fc08d4@suse.com>
Date: Fri, 15 Oct 2021 14:21:11 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <20211015121409.24434-1-kevin.stefanov@citrix.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM5PR0602CA0011.eurprd06.prod.outlook.com
 (2603:10a6:203:a3::21) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 9f099b22-caac-4286-7b8f-08d98fd6478c
X-MS-TrafficTypeDiagnostic: VI1PR04MB4384:
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB4384B356AD504858A5451D48B3B99@VI1PR04MB4384.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:3631;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	zpM5lGyv/M3NMs6ArbdZ5GQmIEKwN2gIpGPr91/XZyo4hhwFXYa63eLJv2iniFbQRH8ZwKE06+bB84bzSLV/n+5ZVW1ThqGLAobLFw13M8G1ZnzF5tCLyI2dPy6AyCW/sFMoPGfBOrX8Ju7B04BLBuHloNuO7CX/YXVQby3drIUkW/6vKU+8+U7K4+U7IfFOZAbfGwIhFvT7f7HE/0eccuYXwqSKE3+Zo8H1QlWn/PFyK04C+28udhANXBr+z5lZmB6Ms3eXc3dRUhlWC1L2pOSyvWVX65YDCA9p0qUoB6ZRRRHHhb7siFPgh/Bd48wNx2Jyrb2LNIlKKW7sJVlTDZ36ZaNXymCY/8KQGOE/UBrMw90DOgWPCiM+zEfvQLrj/SdBrMcqsvvlwy293Wg+07TieiYg7rtKeQwbjQarvXPHvz2xsn9HevCdNXgPlhvOBMtVVMtY6z9F1fHA1UxbTomigXMJcAV2/zRg48pTHh08IFDX32pKWVNUHcUIg3AgRMIUaSS9bLDKKx0/UWcBhk4Wrz9yzo5VcLLCKN+PTaQcaH6JIv1FxR5k/Xik9hHBy2LKIdD2RX9qegSZXoybUt23UZ71scgIiqB54i7lx2O6acgUi8c2dgiY2u46MV66BirKtPA1BxGceoErHhSX15DSbwPVVzJcqJZvMtmszcVXjoslD+sBvxcgtY3yaZhdahAEkSyAGe+V8X9xKzFCoYR5lgO77zLako09S9+4eAc=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(6916009)(31696002)(83380400001)(956004)(4326008)(16576012)(2616005)(316002)(54906003)(8936002)(6486002)(66946007)(36756003)(38100700002)(86362001)(508600001)(66556008)(66476007)(2906002)(26005)(53546011)(31686004)(8676002)(4744005)(5660300002)(186003)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?NUVTRFJvUXZ3YjUwb2FSRXBWQUN1azlsOG5NS1NRaDJZMWhyd3I2VVlQQjAy?=
 =?utf-8?B?eCtab0o2LzgyZTVIRHN4b3BtbmdQOGpDN28wcFJrR3NqMVVFZ0xjeUtFSUVl?=
 =?utf-8?B?M3lldUlCTzZRdWNkUFdxUzUwdm9OSTc0aDQ3aDBwa3B2Y1ZJbVV4eitNcFNH?=
 =?utf-8?B?L3hTQjFib0RxK2w0VkVCVWpHMWpnc1o5SHk5RmF1NllyYXFCdGYvZ1o3a3hq?=
 =?utf-8?B?UTYxTkFpbjNNNHpuL2wyWVY0bGk5VjhmVDZHODhwVmF2YUpZcjltcjNLRk1Q?=
 =?utf-8?B?amIyK1NaUEIzeDFZRTd3ZDk4YUdxZDNQN00raVRhZFl3TlJOODN6cS9YcXlX?=
 =?utf-8?B?eWc1Ykg4Sk11bGRnejJBanRvQUVmQm9OWlZHTXpRNHk3ZHBZelFCWk93c0lO?=
 =?utf-8?B?MDR5U0x0dUxadDMxcEF6bTRLWDljeWpQZjd3U0dYTHlNRWN3MmtsSGVXZE55?=
 =?utf-8?B?eStKUVBleGNXbER6djNWRDUzVlF3Q1FlVjIwSkM3SmZDMUF6NFJzL1ZNODJC?=
 =?utf-8?B?VkhOcURQNjdoYVhXc3VWMVJVdlJCRFF3dmtHOE9LaXdTWkNWcndSUnlvOTln?=
 =?utf-8?B?ajExWExhbkNRUWhySUZXOGU2dzlEb0lrMGFlMyt4YlhOV0hibDF3eEZmVUMx?=
 =?utf-8?B?OHI1SGFXbC9kbVlpQkl3Ym1OVkRJT2lIakZ4Z3VKb3lxWitqZ25CbWR3b01O?=
 =?utf-8?B?QXUyM0JnWTFPdUFIUU9XWEs3RElvM0NSdlVrajI3eWtqQWxxcXlFSW8vNWd4?=
 =?utf-8?B?RXlPMzdqbTFkVm1mOUIxZjM5UVo0aU1FN09BcnJScngremYwZXRraUNMamZy?=
 =?utf-8?B?dGcrVVFjc04xTWdmZmlhUU5DWDZjclE3dWtXbkFYemFDc21OTE8zUmdiOVVm?=
 =?utf-8?B?TmFwL1RoQlFEczNEaXRLS1JsaVRjK2V1eG81Um9vTnErOWxKQnhDYTN4M05H?=
 =?utf-8?B?VlkzWlFsNEpNSFZGLzRvUnZ4RHlMOEczb3JZNm50dXUvZTlZVUJWNmZHTVRQ?=
 =?utf-8?B?YnY2VEppY1N3RW9QOVFST0pGakRxNSsyL0Z2aG5wWWNVYUQwSmNQQkZYQjRG?=
 =?utf-8?B?TzdIQ2V4OXo4bkorQmp1U0xqWm0yRHY2ZUhIdUpTM2ZINU05bTc0M1Q3TTl0?=
 =?utf-8?B?dG42T3R2QytIY2ZIV2Z1allHTG1LS1pqYjRQdVM1bTlGL0tzYkVWRCtETWwr?=
 =?utf-8?B?ejhXOVNFZjRsclN1ajlMS2pXWEorKzBBUC9XSTNiWGc1K0ZVZWp3Um56a2ht?=
 =?utf-8?B?S1h3NkVJUHZNQTI1MzVYVlBUMFdwc3lydmFpWEx1Qkl1NEZiYmtFRkdWR2pr?=
 =?utf-8?B?UVlrMDVnTXVoNmdQOExNVTA5SWZhY29kSnJxUEdITTRxUnkxWHh3SVdJUVhl?=
 =?utf-8?B?WXRWUkJ3N3VuaXd1VnlQcjRlTm9IcnBXOExsMU5wTmlFaGFEeWMrT1pZaHFH?=
 =?utf-8?B?b3RXNFprRXhBMzV2L09tK3dualRkeEhCTDFRODJOTTB4cEhYNGxFSVVNRUx6?=
 =?utf-8?B?aW5UcjhrUisya0JnRm5xaDVWZXk0RnVCbkNHd0w0L2VETTQybldTTmlPT3h5?=
 =?utf-8?B?a3QrNzIzLzk4M3pGMTMxa0dXL0RVMGNEZkNVT0haNGtyTWxIRkZzTmk4TDhj?=
 =?utf-8?B?dER1RmY5T2hFTDM2Mld1Tnp0THhDelVzeHZwb0R6UVFtTHVoOWg5d3ExRlYy?=
 =?utf-8?B?Sk1ab0RLSDJWTVB6cHYvTCtuanhVL3RBZVdiK2lVVHQwMUZGTk10ZDd1aElT?=
 =?utf-8?Q?rM+2Xn0YtV2L2z5b0AvKdVBaqCvGHv4ILuPr0ot?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9f099b22-caac-4286-7b8f-08d98fd6478c
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2021 12:21:13.6807
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ywwhGwKhM8MM7P58o4M9fATmEHwleUfyvZhX8JekpdXCvYEOt7hdkSOJyQfqAaT3+rXYElzyrqNOjRGSd1T+Ww==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4384

On 15.10.2021 14:14, Kevin Stefanov wrote:
> --- a/tools/tests/xenstore/test-xenstore.c
> +++ b/tools/tests/xenstore/test-xenstore.c
> @@ -110,8 +110,17 @@ static int call_test(struct test *tst, int iters, bool no_clock)
>              break;
>      }
>  
> +    /* Make E2BIG non-fatal to the test */
>      if ( ret )
> -        printf("%-10s: failed (ret = %d, stage %s)\n", tst->name, ret, stage);
> +    {
> +	if ( ret == E2BIG )

Just fyi that it looks like a hard tab has slipped in here.

Jan



From xen-devel-bounces@lists.xenproject.org Fri Oct 15 12:29:00 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 12:29:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.210465.367342 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbMKU-0006Q7-OR; Fri, 15 Oct 2021 12:28:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 210465.367342; Fri, 15 Oct 2021 12:28:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbMKU-0006Q0-L8; Fri, 15 Oct 2021 12:28:54 +0000
Received: by outflank-mailman (input) for mailman id 210465;
 Fri, 15 Oct 2021 12:28:53 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Fqmt=PD=arm.com=Bertrand.Marquis@srs-us1.protection.inumbo.net>)
 id 1mbMKT-0006Ps-I3
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 12:28:53 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com (unknown
 [2a01:111:f400:fe0e::605])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 0a2d4ac7-f6e8-471e-8024-b9edcd07a1e4;
 Fri, 15 Oct 2021 12:28:52 +0000 (UTC)
Received: from DB9PR05CA0013.eurprd05.prod.outlook.com (2603:10a6:10:1da::18)
 by AM0PR08MB3105.eurprd08.prod.outlook.com (2603:10a6:208:5f::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.17; Fri, 15 Oct
 2021 12:28:49 +0000
Received: from DB5EUR03FT014.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:10:1da:cafe::1d) by DB9PR05CA0013.outlook.office365.com
 (2603:10a6:10:1da::18) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15 via Frontend
 Transport; Fri, 15 Oct 2021 12:28:49 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT014.mail.protection.outlook.com (10.152.20.102) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.15 via Frontend Transport; Fri, 15 Oct 2021 12:28:49 +0000
Received: ("Tessian outbound e27daf245730:v103");
 Fri, 15 Oct 2021 12:28:49 +0000
Received: from 9f45f0317120.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 DDF6E81D-F640-4A96-ADFA-3EF2B592CD72.1; 
 Fri, 15 Oct 2021 12:28:42 +0000
Received: from EUR02-AM5-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 9f45f0317120.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 15 Oct 2021 12:28:42 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com (2603:10a6:4:74::9)
 by DB6PR0802MB2453.eurprd08.prod.outlook.com (2603:10a6:4:9e::11) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.17; Fri, 15 Oct
 2021 12:28:39 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955]) by DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955%4]) with mapi id 15.20.4587.031; Fri, 15 Oct 2021
 12:28:39 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0a2d4ac7-f6e8-471e-8024-b9edcd07a1e4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=GyLw0HBGfFyr4eksYhX7tavd7s7xp7G5Nb8Cm3HgPFo=;
 b=ihggpbbTtH5pxSRrnCBl9LKb3140UEjbPj4HQaW8jkC+iTJ4/3Kr7j9KI48kwTjZesQHmM0ROZecd1HiiGFHR4Ge8ecSkYIUt8vgkom513U50UPyH5Vr6f0OfpG7bZNe7wbhBgL8DGd1pOzYhQgC8+aimf5Imfnzb9N4IwtMmTY=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 0c8eb75a338cf270
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=DGfDq1RtsfmUhw9qflsYwRqeMVNDuxgPaJy5crFGRsmKk9Sgqc+uzIopZba40HfUe2MXb9nKfpWhBGRLP24RmJIBqcjxc3+zlpm2u+1sHYsU5Hr+/SGvXkGlghxbxWmG6nuPX9P6fPgXX8hGooaow6ixfdPKm6xL0C825B672/ZXpDkqTKJzPaB5Ax6beFsSkKjNb0CIQTBW53BSXl+1rDrBbevFGn1n4UCFvCxo+Xe3r24GohrtE5Gl3oo8+V/zQTzVnGCiR0Dxwx74jNJOVxKQtPmhxJ8XOfdDoaR86Pjg/PdJzLgd7abGEBAxdMaMCIZERnSu6z1cfivH/x7g6w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=GyLw0HBGfFyr4eksYhX7tavd7s7xp7G5Nb8Cm3HgPFo=;
 b=Ra2rViAIks3Mgs//AV2r+H/fbGmSMPrOnFx+fVYghQRxGzEQkwk8luo0gIQn895kYtuv7HVK8cuQr3OUa6dWnEz7q7cl+sUdW5CnQVDgwFWgt7+g6prk1iNBgsNAYVvuUO1TYU6jpKocr3anG7hL68QRRUeHbvJboYcBhKsgNnwBPFawNhmNG7fySXNSnEbHEWXAQ5f1UBWyE9D6t7+zJBfqbJDFts+A7xS5/iLHBBUHMTR7SOxbmt0cFFe6AijYgFDq8FaJ4NCm9yPN+3/kYIqcSDslD4DLWmGbKTBT3RO233i3oRhFSlkseqbtorHiO8xV6vOZcBlvleCoykKvqw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=GyLw0HBGfFyr4eksYhX7tavd7s7xp7G5Nb8Cm3HgPFo=;
 b=ihggpbbTtH5pxSRrnCBl9LKb3140UEjbPj4HQaW8jkC+iTJ4/3Kr7j9KI48kwTjZesQHmM0ROZecd1HiiGFHR4Ge8ecSkYIUt8vgkom513U50UPyH5Vr6f0OfpG7bZNe7wbhBgL8DGd1pOzYhQgC8+aimf5Imfnzb9N4IwtMmTY=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Jan Beulich <jbeulich@suse.com>
CC: =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>, Ian Jackson
	<iwj@xenproject.org>, Rahul Singh <Rahul.Singh@arm.com>, Stefano Stabellini
	<sstabellini@kernel.org>, Julien Grall <julien@xen.org>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>, Paul Durrant
	<paul@xen.org>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v6 2/3] xen/arm: Enable the existing x86 virtual PCI
 support for ARM.
Thread-Topic: [PATCH v6 2/3] xen/arm: Enable the existing x86 virtual PCI
 support for ARM.
Thread-Index:
 AQHXwQrjS6mPrKT7Q06z3N66FcsDAKvTs1WAgAAj+QCAAAF1gIAAAUmAgAAVT4CAAAqRAIAAAYUAgAAC1QA=
Date: Fri, 15 Oct 2021 12:28:38 +0000
Message-ID: <6C183E72-A9E8-4AB0-B6C4-C31E8AAFC4B6@arm.com>
References: <cover.1634221830.git.bertrand.marquis@arm.com>
 <396b08e2598cf0338e0c7f4ad3cd5cb66db89224.1634221830.git.bertrand.marquis@arm.com>
 <f41f59f7-69ed-e2fe-dc17-434b456cf693@suse.com>
 <57A39480-34DF-4BF5-9B0E-802D30F94BBD@arm.com>
 <24937.21631.538303.29471@mariner.uk.xensource.com>
 <b8fc68e6-2bba-ef11-4c4a-50c2046ecb04@suse.com>
 <YWlnc3b0sj4akUWa@MacBook-Air-de-Roger.local>
 <A2AAD333-35A2-4250-891C-E8FB885D5660@arm.com>
 <887d99e8-bcc5-f854-ceed-a38701e1ad1d@suse.com>
In-Reply-To: <887d99e8-bcc5-f854-ceed-a38701e1ad1d@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3654.120.0.1.13)
Authentication-Results-Original: suse.com; dkim=none (message not signed)
 header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: 3af33216-ea10-4fd7-6f18-08d98fd7571c
x-ms-traffictypediagnostic: DB6PR0802MB2453:|AM0PR08MB3105:
x-ms-exchange-transport-forked: True
X-Microsoft-Antispam-PRVS:
	<AM0PR08MB3105A5D5F9C40BE31EF0BE5A9DB99@AM0PR08MB3105.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:10000;OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 RMZO6SYS8YVDy3GexkBXDu5QMeQZvLYd1SN50BAg41Tdhlzfzr/dV+g3SW92lQ958GOejgRdy6xIR9+sqLrE2j9THEomUTN97/mG9OIdB0IkmwIuZCOhbjZJi3UdvHfh9Drhwj5MMbPDTQPdHXDXUOURRRyETVshlnxBUBN+HVJgEDu3APE+JPGxMsp0eShN+78EJQR1etqxZADT771imIlXYxUaraO6LexnmFj5vuvzk3B1hacc83cAs9gA2DCAS/L/CoiNoxjIBkdBFYVCzj0kGZcVhcM05HFjtxAVw7u//rkGCh9kkx1P6Y54MxfyVg/9Z66/DriWCOoehr+CBFjghvJEwedC1zeJBH9vHhFMR8HlpiLMOJHxPV0tFPoGv0qPjdDPYv6APqG/TGieO6OVrSY5jRENfHRSwh/ORr7oq3MGLrco5yWGIvNw8BkAXZ5efs71jf2JkGB/oeVcttHi7ufQ4+btXMvmYXEVddWTezc7yF7cfMDnrz603CnXNhRmrwZAq8BBC1tc9JGR4Ip9OkD6k4fVoL63uy6nFKho6/1ssKPn7E1YOaA5FpaCc/m6WV3TVTBBCHd1OrNVMUrY2tBZtAoNsOjB9dqs9esSYOQK8+gBC86tP/YeKXa6EDricQy0bPoQbWD1hb+GSKjDoKnNHcYfpM2AhE81Oez2Z+ItV4MTcrKc3FLr9pvIUeI2H7hM8AdHnBZV4gz2ssn9cdU/4bDl2vtFtNT01zArQkvoNFR/qjyaP8d6R0+nOYdmFHZcEiTqCkAcKE4Zljy8iuCIMGEQ2iNHIspTww0HkeO5i+17EXIuRQ2eNQ6Ufvc5eP7fpg5gEdn2QfVDpg==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB6PR0801MB2024.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(66946007)(6916009)(26005)(66446008)(2906002)(71200400001)(66476007)(186003)(64756008)(66556008)(76116006)(966005)(2616005)(316002)(508600001)(91956017)(5660300002)(86362001)(7416002)(8936002)(6486002)(6512007)(4326008)(54906003)(8676002)(38070700005)(36756003)(53546011)(122000001)(38100700002)(6506007)(33656002)(83380400001)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-ID: <02D619E56C9F1645A6A0D934367A86BA@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0802MB2453
Original-Authentication-Results: suse.com; dkim=none (message not signed)
 header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT014.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	e3d3cc8a-624b-4e40-a9f4-08d98fd75115
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	T3KdL1y/rj99XGL8DrmPgYP7G0k+uPQsWcABUg7jNz+klgLgFuQQ8U5fomCDVybrqy+6XGnj7qJKVRdppvE0CONSkM2j4e/v+Vw5OJ84os3y0r0pJnh6NzntMOCMmtrV208mZ807lIZCt9VF0/u3a5kaRH5ai2V9hcIpg/qp0t//F2yVKyzkSHta66xlcll5zwI+zb9uj+nTofITLGczB7dEagFHNL6efC0kLv6LZqIF5lNFm3SImDJpOzMO4y8wy20PdTuVJ8UGfRZ6VZPnDFwF8az64AbkEVX37f8Lk5fnmnkkeHoGdnahuuggPX9SCu6huJjCOGtffLKJnGtTIS8PKRl6VztuEOHuz1pPEJbZE702Ol9/4G2RQ+OoMrO5jmyBl/g3frrtf7I7IfKVPFIF+6RQ/AdYGjH31S242PKkdSDzE+K1S+Pd6U2vB+R5WbdyzZ4gSWcEkFAERIQbZdw1cPb1nTnwyoParAADeKINXg2IwhbfLjcKWO6PpZ4AyrZR6XGJa58+2+61BoaPU3l8yXsuMj3pr9SlH+E5APDkGFU1E3B5d65vl92XPMMQzOJ48J56XiaWyFiF6pX3n0zBw+82tSIuP5nhY5jdaUJz7XAxvYsCqM/MNIgx4my6hRJbD8fGp4yktM0oDq9hfXgh05MAqnCQSG3GxtjKcv/9EGmiBf4pxwm5DQeZ6SUWaTJ5n3vfMq1dAUNpEnpvu1G3bNaAoBx3ZYpYMD9ksXvB3efAIkv4NuOW7WqFqXZlUTy5t3S6opSb5mgjVdK+lF6EfqzOZgD1hnNZtQaR30Q=
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(8936002)(70586007)(36756003)(6512007)(336012)(6862004)(70206006)(186003)(82310400003)(26005)(5660300002)(86362001)(2906002)(6486002)(356005)(47076005)(8676002)(53546011)(508600001)(36860700001)(316002)(83380400001)(6506007)(81166007)(966005)(2616005)(4326008)(33656002)(54906003);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2021 12:28:49.1757
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 3af33216-ea10-4fd7-6f18-08d98fd7571c
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT014.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3105

SGkgSmFuLA0KDQo+IE9uIDE1IE9jdCAyMDIxLCBhdCAxMzoxOCwgSmFuIEJldWxpY2ggPGpiZXVs
aWNoQHN1c2UuY29tPiB3cm90ZToNCj4gDQo+IE9uIDE1LjEwLjIwMjEgMTQ6MTMsIEJlcnRyYW5k
IE1hcnF1aXMgd3JvdGU6DQo+PiBIaSBSb2dlciwNCj4+IA0KPj4+IE9uIDE1IE9jdCAyMDIxLCBh
dCAxMjozNSwgUm9nZXIgUGF1IE1vbm7DqSA8cm9nZXIucGF1QGNpdHJpeC5jb20+IHdyb3RlOg0K
Pj4+IA0KPj4+IE9uIEZyaSwgT2N0IDE1LCAyMDIxIGF0IDEyOjE4OjU5UE0gKzAyMDAsIEphbiBC
ZXVsaWNoIHdyb3RlOg0KPj4+PiBPbiAxNS4xMC4yMDIxIDEyOjE0LCBJYW4gSmFja3NvbiB3cm90
ZToNCj4+Pj4+IEJlcnRyYW5kIE1hcnF1aXMgd3JpdGVzICgiUmU6IFtQQVRDSCB2NiAyLzNdIHhl
bi9hcm06IEVuYWJsZSB0aGUgZXhpc3RpbmcgeDg2IHZpcnR1YWwgUENJIHN1cHBvcnQgZm9yIEFS
TS4iKToNCj4+Pj4+Pj4gT24gMTUgT2N0IDIwMjEsIGF0IDA5OjAwLCBKYW4gQmV1bGljaCA8amJl
dWxpY2hAc3VzZS5jb20+IHdyb3RlOg0KPj4+Pj4+PiBUaGUgbGF0dGVyIGlzIGZpbmUgdG8gYmUg
cHV0IGhlcmUgKGkuZS4gRlRBT0QgSSdtIGZpbmUgd2l0aCBpdA0KPj4+Pj4+PiBzdGF5aW5nIGhl
cmUpLiBGb3IgdGhlIGZvcm1lciBJIGV2ZW4gcXVlc3Rpb24gaXRzIG9yaWdpbmFsIHBsYWNlbWVu
dA0KPj4+Pj4+PiBpbiBhc20teDg2L3BjaS5oOiBJdCdzIG5vdCBnZW5lcmFsbHkgY29ycmVjdCBh
cyBwZXIgdGhlIFBDSSBzcGVjLCBhcw0KPj4+Pj4+PiB0aGUgYnVzIHBvcnRpb24gb2YgdGhlIGFk
ZHJlc3MgY2FuIGJlIGFueXdoZXJlIGZyb20gMSB0byA4IGJpdHMuIEFuZA0KPj4+Pj4+PiBpbiBm
YWN0IHRoZXJlIGlzIGEgcmVhc29uIHdoeSB0aGlzIG1hY3JvIHdhcy9pcyB1c2VkIGluIG9ubHkg
YQ0KPj4+Pj4+PiBzaW5nbGUgcGxhY2UsIGJ1dCBub3QgZS5nLiBpbiB4ODYnZXMgaGFuZGxpbmcg
b2YgcGh5c2ljYWwgTUNGRy4gSXQNCj4+Pj4+Pj4gaXMgbWVyZWx5IGFuIGltcGxlbWVudGF0aW9u
IGNob2ljZSBpbiB2UENJIHRoYXQgdGhlIGVudGlyZSBzZWdtZW50IDANCj4+Pj4+Pj4gaGFzIGEg
bGluZWFyIGFkZHJlc3MgcmFuZ2UgY292ZXJpbmcgYWxsIDI1NiBidXNlcy4gSGVuY2UgSSB0aGlu
aw0KPj4+Pj4+PiB0aGlzIHdhbnRzIHRvIG1vdmUgdG8geGVuL3ZwY2kuaCBhbmQgdGhlbiBwZXJo
YXBzIGFsc28gYmUgbmFtZWQNCj4+Pj4+Pj4gVlBDSV9FQ0FNX0JERigpLg0KPj4+Pj4+IA0KPj4+
Pj4+IE9uIHByZXZpb3VzIHZlcnNpb24gaXQgd2FzIHJlcXVlc3QgdG8gcmVuYW1lZCB0aGlzIHRv
IEVDQU0gYW5kIGFncmVlZA0KPj4+Pj4+IHRvIHB1dCBpcyBoZXJlLiBOb3cgeW91IHdhbnQgbWUg
dG8gcmVuYW1lIGl0IHRvIFZQQ0kgYW5kIG1vdmUgaXQgYWdhaW4uDQo+Pj4+Pj4gSSB3b3VsZCBs
aWtlIHRvIGhhdmUgYSBjb25maXJtYXRpb24gdGhhdCB0aGlzIGlzIG9rIGFuZCB0aGUgZmluYWwg
bW92ZSBpZiBwb3NzaWJsZS4NCj4+Pj4+PiANCj4+Pj4+PiBAUm9nZXIgY2FuIHlvdSBjb25maXJt
IHRoaXMgaXMgd2hhdCBpcyB3YW50ZWQgPw0KPj4+Pj4gDQo+Pj4+PiBJIHRoaW5rIFJvZ2VyIGlz
IG5vdCBhdmFpbGFibGUgdG9kYXkgSSdtIGFmcmFpZC4NCj4+Pj4+IA0KPj4+Pj4gQmVydHJhbmQs
IGNhbiB5b3UgZ2l2ZSBtZSBhIGxpbmsgdG8gdGhlIGNvbW1lbnQgZnJvbSBSb2dlciA/DQo+Pj4+
PiBBc3N1bWluZyB0aGF0IGl0IHNheXMgd2hhdCBJIHRoaW5rIGl0IHdpbGwgc2F5Og0KPj4+Pj4g
DQo+Pj4+PiBJIHRoaW5rIHRoZSBiZXN0IHRoaW5nIHRvIGRvIHdpbGwgYmUgdG8gbGVhdmUgdGhl
IG5hbWUgYXMgaXQgd2FzIGluDQo+Pj4+PiB0aGUgbW9zdCByZWNlbnQgdmVyc2lvbiBvZiB5b3Vy
IHNlcmllcy4gIEkgZG9uJ3QgdGhpbmsgaXQgbWFrZXMgc2Vuc2UNCj4+Pj4+IHRvIGJsb2NrIHRo
aXMgcGF0Y2ggb3ZlciBhIG5hbWluZyBkaXNhZ3JlZW1lbnQuICBBbmQgaXQgd291bGQgYmUgYmVz
dA0KPj4+Pj4gdG8gbWluaW1pc2UgdW5uZWNlc3NhcnkgY2h1cm4uDQo+Pj4+PiANCj4+Pj4+IEkg
d291bGQgYmUgaGFwcHkgdG8gcmVsZWFzZS1hY2sgYSBuYW1lIGNoYW5nZSAocGVyaGFwcyBwcm9w
b3NlZCBibyBKYW4NCj4+Pj4+IG9yIFJvZ2VyKSBzdXBwb3NpbmcgdGhhdCB0aGF0IGlzIHRoZSB1
bHRpbWF0ZSBtYWludGFpbmVyIGNvbnNlbnN1cy4NCj4+Pj4+IA0KPj4+Pj4gSmFuLCB3b3VsZCB0
aGF0IGFwcHJvYWNoIGJlIE9LIHdpdGggeW91ID8NCj4+Pj4gDQo+Pj4+IFdlbGwsIHllcywgaWYg
YSBzdWJzZXF1ZW50IG5hbWUgY2hhbmdlIGlzIG9rYXksIHRoZW4gSSBjb3VsZCBsaXZlIHdpdGgN
Cj4+Pj4gdGhhdC4gSSdkIHN0aWxsIGZpbmQgaXQgb2RkIHRvIHJlbmFtZSBhIGZ1bmN0aW9uIGlt
bWVkaWF0ZWx5IGFmdGVyIGl0DQo+Pj4+IGFscmVhZHkgZ290IHJlbmFtZWQuIEFzIGV4cHJlc3Nl
ZCBlbHNld2hlcmUsIEkgc3VzcGVjdCBpbiBoaXMgcmVxdWVzdA0KPj4+PiBSb2dlciBkaWQgbm90
IHBheSBhdHRlbnRpb24gdG8gYSB1c2Ugb2YgdGhlIGZ1bmN0aW9uIGluIG5vbi1FQ0FNIGNvZGUu
DQo+Pj4gDQo+Pj4gVXNpbmcgTU1DRkdfQkRGIHdhcyBvcmlnaW5hbCByZXF1ZXN0ZWQgYnkgSnVs
aWVuLCBub3QgbXlzZWxmIEkgdGhpbms6DQo+Pj4gDQo+Pj4gaHR0cHM6Ly9sb3JlLmtlcm5lbC5v
cmcveGVuLWRldmVsL2E4NjhlMWU3LTg0MDAtNDVkZi02ZWFhLTY5ZjFlMmM5OTM4M0B4ZW4ub3Jn
Lw0KPj4+IA0KPj4+IEknbSBzbGlnaHRseSBsb3NzIGluIHNvIG1hbnkgbWVzc2FnZXMuIE9uIHg4
NiB3ZSBzdWJ0cmFjdCB0aGUgTUNGRw0KPj4+IHN0YXJ0IGFkZHJlc3MgZnJvbSB0aGUgcGFzc2Vk
IG9uZSBiZWZvcmUgZ2V0dGluZyB0aGUgQkRGLCBhbmQgdGhlbiB3ZQ0KPj4+IGFkZCB0aGUgc3Rh
cnR0aW5nIGJ1cyBhZGRyZXNzIHBhc3NlZCBpbiB0aGUgQUNQSSB0YWJsZS4gVGhpcyBpcyBzbyBm
YXINCj4+PiBub3QgbmVlZCBvbiBBcm0gQUZBSUNUIGJlY2F1c2Ugb2YgdGhlIGZpeGVkIG5hdHVy
ZSBvZiB0aGUgc2VsZWN0ZWQNCj4+PiB2aXJ0dWFsIEVDQU0gcmVnaW9uLg0KPj4gDQo+PiBBdCB0
aGUgZW5kIG15IHBhdGNoIHdpbGwgYWRkIGluIHhlbi9wY2kuaDoNCj4+ICNkZWZpbmUgRUNBTV9C
REYoYWRkcikgICAgICAgICAoKChhZGRyKSAmIDB4MGZmZmYwMDApID4+IDEyKQ0KPiANCj4gU2lu
Y2UgeW91IHN0aWxsIG1ha2UgdGhpcyBwcm9wb3NhbCwgb25jZSBhZ2FpbjogSSdtIG5vdCBnb2lu
ZyB0bw0KPiBhY2NlcHQgc3VjaCBhIG1hY3JvIGluIHRoaXMgaGVhZGVyLCB3aGF0ZXZlciB0aGUg
bmFtZS4gSXRzIHByaW9yDQo+IHBsYWNlbWVudCB3YXMgd3JvbmcgYXMgd2VsbC4gT25seSAuLi4N
Cj4gDQo+PiAjZGVmaW5lIEVDQU1fUkVHX09GRlNFVChhZGRyKSAgKChhZGRyKSAmIDB4MDAwMDBm
ZmYpDQo+IA0KPiAuLi4gdGhpcyBvbmUgaXMgZmluZSB0byBsaXZlIGhlcmUgKGFuZCBwcmVzdW1h
Ymx5IGl0IGNvdWxkIGdhaW4gdXNlcw0KPiBlbHNld2hlcmUpLg0KDQpTbyB5b3Ugd291bGQgYWdy
ZWUgaWYgdGhleSBhcmUgYm90aCBtb3ZlZCB0byB2cGNpLmggd2l0aCBhIFZQQ0lfIHByZWZpeCA/
DQoNCkJlcnRyYW5kDQoNCj4gDQo+IEphbg0KPiANCj4+IE5vdyBzZWVpbmcgdGhlIGNvbW1lbnQg
dGhlIHF1ZXN0aW9uIGlzIHNob3VsZCB0aG9zZSBiZSByZW5hbWVkIHdpdGggYSBWUENJDQo+PiBw
cmVmaXggYW5kIGJlIG1vdmVkIHRvIHhlbi92cGNpLmguDQo+PiANCj4+IFNvIGZhciBFQ0FNX0JE
RiBpcyBvbmx5IHVzZWQgaW4gdnBjaV9tbWNmZ19kZWNvZGVfYWRkciB3aGljaCBpcyBvbmx5IGNh
bGxlZA0KPj4gYmVmb3JlIGNhbGxpbmcgdnBjaV9lY2FtX3tyZWFkL3dyaXRlfS4NCj4+IA0KPj4g
RUNBTV9SRUdfT0ZGU0VUIGlzIG9ubHkgdXNlZCBpbiBhcm0gdnBjaSBjb2RlLg0KPj4gDQo+PiBE
byB5b3UgdGhpbmsgdGhlIGN1cnJlbnQgc3RhdGUgaXMgb2sgb2YgdGhlIHJlbmFtaW5nICsgbW92
aW5nIHNob3VsZCBiZSBkb25lID8NCj4+IA0KPj4gQ2hlZXJzDQo+PiBCZXJ0cmFuZA0KDQo=


From xen-devel-bounces@lists.xenproject.org Fri Oct 15 12:52:15 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 12:52:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.210480.367397 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbMh4-0002CS-TQ; Fri, 15 Oct 2021 12:52:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 210480.367397; Fri, 15 Oct 2021 12:52:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbMh4-0002C9-PH; Fri, 15 Oct 2021 12:52:14 +0000
Received: by outflank-mailman (input) for mailman id 210480;
 Fri, 15 Oct 2021 12:52:14 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=esao=PD=suse.com=jgross@srs-us1.protection.inumbo.net>)
 id 1mbMh4-00012o-3E
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 12:52:14 +0000
Received: from smtp-out2.suse.de (unknown [195.135.220.29])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id bf772da3-ce75-4130-b42e-9dba69243e60;
 Fri, 15 Oct 2021 12:52:05 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 879221FD53;
 Fri, 15 Oct 2021 12:52:04 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 4627C13FC3;
 Fri, 15 Oct 2021 12:52:04 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id uMzoD3R5aWEYHgAAMHmgww
 (envelope-from <jgross@suse.com>); Fri, 15 Oct 2021 12:52:04 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: bf772da3-ce75-4130-b42e-9dba69243e60
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1634302324; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=jbCrdJmB+LvvFT54GH7dIQVd+hNw2QbLXV79l4uAygg=;
	b=Imb2n1DJXmbW8+Nw9IvK8W4nTyAD8dZ/64TXvzg2JRO3rq8AbY9o/W79uNd2GDgVIW4K9h
	YaUG8AY3Kog8N3JR7Nh72w6p1u1OoeXkyWYaOQc3cgMU+DK5p/uNojB3wyXH+22l97Cx3k
	IL2HDANBd3F+CWxcDKDei9DEqHkoS/s=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org
Cc: Juergen Gross <jgross@suse.com>,
	Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	Wei Liu <wl@xen.org>,
	George Dunlap <george.dunlap@citrix.com>,
	Ian Jackson <iwj@xenproject.org>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>
Subject: [PATCH 08/12] x86/pv-shim: don't modify hypercall table
Date: Fri, 15 Oct 2021 14:51:48 +0200
Message-Id: <20211015125152.25198-9-jgross@suse.com>
X-Mailer: git-send-email 2.26.2
In-Reply-To: <20211015125152.25198-1-jgross@suse.com>
References: <20211015125152.25198-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

When running as pv-shim the hypercall is modified today in order to
replace the functions for __HYPERVISOR_event_channel_op and
__HYPERVISOR_grant_table_op hypercalls.

Change this to call the related functions from the normal handlers
instead when running as shim. The performance implications are not
really relevant, as a normal production hypervisor will not be
configured to support shim mode, so the related calls will be dropped
due to optimization of the compiler.

Note that for the CONFIG_PV_SHIM_EXCLUSIVE case there is a dummy
wrapper do_grant_table_op() needed, as in this case grant_table.c
isn't being built.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 xen/arch/x86/pv/shim.c        | 48 +++++++++++++++--------------------
 xen/common/event_channel.c    |  9 +++++++
 xen/common/grant_table.c      |  9 +++++++
 xen/include/asm-x86/pv/shim.h |  3 +++
 4 files changed, 42 insertions(+), 27 deletions(-)

diff --git a/xen/arch/x86/pv/shim.c b/xen/arch/x86/pv/shim.c
index d9704121a7..8f66aa3957 100644
--- a/xen/arch/x86/pv/shim.c
+++ b/xen/arch/x86/pv/shim.c
@@ -56,11 +56,6 @@ static DEFINE_SPINLOCK(balloon_lock);
 
 static struct platform_bad_page __initdata reserved_pages[2];
 
-static long pv_shim_event_channel_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg);
-static long pv_shim_grant_table_op(unsigned int cmd,
-                                   XEN_GUEST_HANDLE_PARAM(void) uop,
-                                   unsigned int count);
-
 /*
  * By default give the shim 1MB of free memory slack. Some users may wish to
  * tune this constants for better memory utilization. This can be achieved
@@ -203,7 +198,6 @@ void __init pv_shim_setup_dom(struct domain *d, l4_pgentry_t *l4start,
                               start_info_t *si)
 {
     bool compat = is_pv_32bit_domain(d);
-    pv_hypercall_table_t *rw_pv_hypercall_table;
     uint64_t param = 0;
     long rc;
 
@@ -249,23 +243,6 @@ void __init pv_shim_setup_dom(struct domain *d, l4_pgentry_t *l4start,
         consoled_set_ring_addr(page);
     }
 
-    /*
-     * Locate pv_hypercall_table[] (usually .rodata) in the directmap (which
-     * is writeable) and insert some shim-specific hypercall handlers.
-     */
-    rw_pv_hypercall_table = __va(__pa(pv_hypercall_table));
-    rw_pv_hypercall_table[__HYPERVISOR_event_channel_op].native =
-        (hypercall_fn_t *)pv_shim_event_channel_op;
-    rw_pv_hypercall_table[__HYPERVISOR_grant_table_op].native =
-        (hypercall_fn_t *)pv_shim_grant_table_op;
-
-#ifdef CONFIG_PV32
-    rw_pv_hypercall_table[__HYPERVISOR_event_channel_op].compat =
-        (hypercall_fn_t *)pv_shim_event_channel_op;
-    rw_pv_hypercall_table[__HYPERVISOR_grant_table_op].compat =
-        (hypercall_fn_t *)pv_shim_grant_table_op;
-#endif
-
     guest = d;
 
     /*
@@ -435,7 +412,7 @@ int pv_shim_shutdown(uint8_t reason)
     return 0;
 }
 
-static long pv_shim_event_channel_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
+long pv_shim_event_channel_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
 {
     struct domain *d = current->domain;
     struct evtchn_close close;
@@ -683,9 +660,9 @@ void pv_shim_inject_evtchn(unsigned int port)
 # define compat_handle_okay guest_handle_okay
 #endif
 
-static long pv_shim_grant_table_op(unsigned int cmd,
-                                   XEN_GUEST_HANDLE_PARAM(void) uop,
-                                   unsigned int count)
+long pv_shim_grant_table_op(unsigned int cmd,
+                            XEN_GUEST_HANDLE_PARAM(void) uop,
+                            unsigned int count)
 {
     struct domain *d = current->domain;
     long rc = 0;
@@ -845,6 +822,23 @@ static long pv_shim_grant_table_op(unsigned int cmd,
     return rc;
 }
 
+#ifndef CONFIG_GRANT_TABLE
+/* Thin wrapper(s) needed. */
+long do_grant_table_op(unsigned int cmd, XEN_GUEST_HANDLE_PARAM(void) uop,
+                       unsigned int count)
+{
+    return pv_shim_grant_table_op(cmd, uop, count);
+}
+
+#ifdef CONFIG_PV32
+int compat_grant_table_op(unsigned int cmd, XEN_GUEST_HANDLE_PARAM(void) uop,
+                          unsigned int count)
+{
+    return pv_shim_grant_table_op(cmd, uop, count);
+}
+#endif
+#endif
+
 long pv_shim_cpu_up(void *data)
 {
     struct vcpu *v = data;
diff --git a/xen/common/event_channel.c b/xen/common/event_channel.c
index 12006f592e..a15f986b32 100644
--- a/xen/common/event_channel.c
+++ b/xen/common/event_channel.c
@@ -32,6 +32,10 @@
 #include <public/event_channel.h>
 #include <xsm/xsm.h>
 
+#ifdef CONFIG_PV_SHIM
+#include <asm/guest.h>
+#endif
+
 #define ERROR_EXIT(_errno)                                          \
     do {                                                            \
         gdprintk(XENLOG_WARNING,                                    \
@@ -1190,6 +1194,11 @@ long do_event_channel_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
 {
     int rc;
 
+#ifdef CONFIG_PV_SHIM
+    if ( pv_shim )
+        return pv_shim_event_channel_op(cmd, arg);
+#endif
+
     switch ( cmd )
     {
     case EVTCHNOP_alloc_unbound: {
diff --git a/xen/common/grant_table.c b/xen/common/grant_table.c
index 49e12621ac..de097c0eda 100644
--- a/xen/common/grant_table.c
+++ b/xen/common/grant_table.c
@@ -45,6 +45,10 @@
 #include <asm/flushtlb.h>
 #include <asm/guest_atomics.h>
 
+#ifdef CONFIG_PV_SHIM
+#include <asm/guest.h>
+#endif
+
 /* Per-domain grant information. */
 struct grant_table {
     /*
@@ -3526,6 +3530,11 @@ do_grant_table_op(
     long rc;
     unsigned int opaque_in = cmd & GNTTABOP_ARG_MASK, opaque_out = 0;
 
+#ifdef CONFIG_PV_SHIM
+    if ( pv_shim )
+        return pv_shim_grant_table_op(cmd, uop, count);
+#endif
+
     if ( (int)count < 0 )
         return -EINVAL;
 
diff --git a/xen/include/asm-x86/pv/shim.h b/xen/include/asm-x86/pv/shim.h
index 8a91f4f9df..6415f8068e 100644
--- a/xen/include/asm-x86/pv/shim.h
+++ b/xen/include/asm-x86/pv/shim.h
@@ -19,6 +19,7 @@
 #ifndef __X86_PV_SHIM_H__
 #define __X86_PV_SHIM_H__
 
+#include <xen/hypercall.h>
 #include <xen/types.h>
 
 #if defined(CONFIG_PV_SHIM_EXCLUSIVE)
@@ -45,6 +46,8 @@ domid_t get_initial_domain_id(void);
 uint64_t pv_shim_mem(uint64_t avail);
 void pv_shim_fixup_e820(struct e820map *e820);
 const struct platform_bad_page *pv_shim_reserved_pages(unsigned int *size);
+typeof(do_event_channel_op) pv_shim_event_channel_op;
+typeof(do_grant_table_op) pv_shim_grant_table_op;
 
 #else
 
-- 
2.26.2



From xen-devel-bounces@lists.xenproject.org Fri Oct 15 12:52:15 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 12:52:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.210479.367386 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbMh3-0001up-J0; Fri, 15 Oct 2021 12:52:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 210479.367386; Fri, 15 Oct 2021 12:52:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbMh3-0001uQ-FF; Fri, 15 Oct 2021 12:52:13 +0000
Received: by outflank-mailman (input) for mailman id 210479;
 Fri, 15 Oct 2021 12:52:12 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=esao=PD=suse.com=jgross@srs-us1.protection.inumbo.net>)
 id 1mbMh1-0001If-US
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 12:52:11 +0000
Received: from smtp-out1.suse.de (unknown [195.135.220.28])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id b1a31ad2-2db6-11ec-8235-12813bfff9fa;
 Fri, 15 Oct 2021 12:52:03 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id B262A21974;
 Fri, 15 Oct 2021 12:52:02 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 66E0713C1A;
 Fri, 15 Oct 2021 12:52:02 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id 0HjvF3J5aWEYHgAAMHmgww
 (envelope-from <jgross@suse.com>); Fri, 15 Oct 2021 12:52:02 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b1a31ad2-2db6-11ec-8235-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1634302322; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=JZRlGSWF2EiK/LbFLLQovLWJFg0uUM6yzYNKwQso+lM=;
	b=BKDQA57PMur/hYqQjSuqmz0yuLXcRgI6ISZITcdgrkEPIBu12bsKVYzxxriK7NfAOp5EGM
	/zE3l+poi18A7I+OGjR7MuB8+A/V5vJ+J+xy2ch89Z2xrHBViYmSRx/NL3G66tZV1lJ9SU
	UVhm9nhhKPwAMsyiq2YZUisJAc0xZTI=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org
Cc: Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Ian Jackson <iwj@xenproject.org>,
	Jan Beulich <jbeulich@suse.com>,
	Wei Liu <wl@xen.org>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>
Subject: [PATCH 02/12] xen: move do_vcpu_op() to arch specific code
Date: Fri, 15 Oct 2021 14:51:42 +0200
Message-Id: <20211015125152.25198-3-jgross@suse.com>
X-Mailer: git-send-email 2.26.2
In-Reply-To: <20211015125152.25198-1-jgross@suse.com>
References: <20211015125152.25198-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Today Arm is using another entry point for the vcpu_op hypercall as
x86, as some of the common sub-ops are not supported on Arm. The Arm
specific handler filetrs out the not supported sub-ops and then calls
the common handler. This leads to the weird call hierarchy:

  do_arm_vcpu_op()
    do_vcpu_op()
      arch_do_vcpu_op()

Clean this up by renaming do_vcpu_op() to common_vcpu_op() and
arch_do_vcpu_op() in each architecture to do_vcpu_op(). This way one
of above calls can be avoided without restricting any potential
future use of common sub-ops for Arm.

Additionally the single user of HYPERCALL_ARM() can be modified and
HYPERCALL_ARM() can be removed.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 xen/arch/arm/domain.c           | 15 ++++++++-------
 xen/arch/arm/traps.c            |  7 +------
 xen/arch/x86/domain.c           | 11 +++++++----
 xen/arch/x86/x86_64/domain.c    | 16 ++++++++++++----
 xen/common/compat/domain.c      | 14 ++++++--------
 xen/common/domain.c             | 11 ++++-------
 xen/include/asm-arm/hypercall.h |  2 --
 xen/include/asm-x86/hypercall.h |  2 +-
 xen/include/xen/hypercall.h     |  2 +-
 9 files changed, 40 insertions(+), 40 deletions(-)

diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
index eef0661beb..d20a972b51 100644
--- a/xen/arch/arm/domain.c
+++ b/xen/arch/arm/domain.c
@@ -1070,23 +1070,24 @@ void arch_dump_domain_info(struct domain *d)
 }
 
 
-long do_arm_vcpu_op(int cmd, unsigned int vcpuid, XEN_GUEST_HANDLE_PARAM(void) arg)
+long do_vcpu_op(int cmd, unsigned int vcpuid, XEN_GUEST_HANDLE_PARAM(void) arg)
 {
+    struct domain *d = current->domain;
+    struct vcpu *v;
+
+    if ( (v = domain_vcpu(d, vcpuid)) == NULL )
+        return -ENOENT;
+
     switch ( cmd )
     {
         case VCPUOP_register_vcpu_info:
         case VCPUOP_register_runstate_memory_area:
-            return do_vcpu_op(cmd, vcpuid, arg);
+            return common_vcpu_op(cmd, v, arg);
         default:
             return -EINVAL;
     }
 }
 
-long arch_do_vcpu_op(int cmd, struct vcpu *v, XEN_GUEST_HANDLE_PARAM(void) arg)
-{
-    return -ENOSYS;
-}
-
 void arch_dump_vcpu_info(struct vcpu *v)
 {
     gic_dump_info(v);
diff --git a/xen/arch/arm/traps.c b/xen/arch/arm/traps.c
index 219ab3c3fb..7abc28848e 100644
--- a/xen/arch/arm/traps.c
+++ b/xen/arch/arm/traps.c
@@ -1351,11 +1351,6 @@ typedef struct {
         .nr_args = _nr_args,                                         \
     }
 
-#define HYPERCALL_ARM(_name, _nr_args)                        \
-    [ __HYPERVISOR_ ## _name ] =  {                                  \
-        .fn = (arm_hypercall_fn_t) &do_arm_ ## _name,                \
-        .nr_args = _nr_args,                                         \
-    }
 /*
  * Only use this for hypercalls which were deprecated (i.e. replaced
  * by something else) before Xen on ARM was created, i.e. *not* for
@@ -1386,7 +1381,7 @@ static arm_hypercall_t arm_hypercall_table[] = {
 #endif
     HYPERCALL(multicall, 2),
     HYPERCALL(platform_op, 1),
-    HYPERCALL_ARM(vcpu_op, 3),
+    HYPERCALL(vcpu_op, 3),
     HYPERCALL(vm_assist, 2),
 #ifdef CONFIG_ARGO
     HYPERCALL(argo_op, 5),
diff --git a/xen/arch/x86/domain.c b/xen/arch/x86/domain.c
index ef1812dc14..e1440ec2f5 100644
--- a/xen/arch/x86/domain.c
+++ b/xen/arch/x86/domain.c
@@ -1488,11 +1488,14 @@ int arch_vcpu_reset(struct vcpu *v)
     return 0;
 }
 
-long
-arch_do_vcpu_op(
-    int cmd, struct vcpu *v, XEN_GUEST_HANDLE_PARAM(void) arg)
+long do_vcpu_op(int cmd, unsigned int vcpuid, XEN_GUEST_HANDLE_PARAM(void) arg)
 {
     long rc = 0;
+    struct domain *d = current->domain;
+    struct vcpu *v;
+
+    if ( (v = domain_vcpu(d, vcpuid)) == NULL )
+        return -ENOENT;
 
     switch ( cmd )
     {
@@ -1544,7 +1547,7 @@ arch_do_vcpu_op(
     }
 
     default:
-        rc = -ENOSYS;
+        rc = common_vcpu_op(cmd, v, arg);
         break;
     }
 
diff --git a/xen/arch/x86/x86_64/domain.c b/xen/arch/x86/x86_64/domain.c
index c46dccc25a..62fe51ee74 100644
--- a/xen/arch/x86/x86_64/domain.c
+++ b/xen/arch/x86/x86_64/domain.c
@@ -13,10 +13,14 @@ CHECK_vcpu_get_physid;
 #undef xen_vcpu_get_physid
 
 int
-arch_compat_vcpu_op(
-    int cmd, struct vcpu *v, XEN_GUEST_HANDLE_PARAM(void) arg)
+compat_vcpu_op(int cmd, unsigned int vcpuid, XEN_GUEST_HANDLE_PARAM(void) arg)
 {
-    int rc = -ENOSYS;
+    int rc;
+    struct domain *d = current->domain;
+    struct vcpu *v;
+
+    if ( (v = domain_vcpu(d, vcpuid)) == NULL )
+        return -ENOENT;
 
     switch ( cmd )
     {
@@ -55,7 +59,11 @@ arch_compat_vcpu_op(
     }
 
     case VCPUOP_get_physid:
-        rc = arch_do_vcpu_op(cmd, v, arg);
+        rc = do_vcpu_op(cmd, vcpuid, arg);
+        break;
+
+    default:
+        rc = compat_common_vcpu_op(cmd, v, arg);
         break;
     }
 
diff --git a/xen/common/compat/domain.c b/xen/common/compat/domain.c
index 98b8c15cea..1119534679 100644
--- a/xen/common/compat/domain.c
+++ b/xen/common/compat/domain.c
@@ -38,14 +38,12 @@ CHECK_vcpu_hvm_context;
 
 #endif
 
-int compat_vcpu_op(int cmd, unsigned int vcpuid, XEN_GUEST_HANDLE_PARAM(void) arg)
+int compat_common_vcpu_op(int cmd, struct vcpu *v,
+                          XEN_GUEST_HANDLE_PARAM(void) arg)
 {
-    struct domain *d = current->domain;
-    struct vcpu *v;
     int rc = 0;
-
-    if ( (v = domain_vcpu(d, vcpuid)) == NULL )
-        return -ENOENT;
+    struct domain *d = current->domain;
+    unsigned int vcpuid = v->vcpu_id;
 
     switch ( cmd )
     {
@@ -102,7 +100,7 @@ int compat_vcpu_op(int cmd, unsigned int vcpuid, XEN_GUEST_HANDLE_PARAM(void) ar
     case VCPUOP_stop_singleshot_timer:
     case VCPUOP_register_vcpu_info:
     case VCPUOP_send_nmi:
-        rc = do_vcpu_op(cmd, vcpuid, arg);
+        rc = common_vcpu_op(cmd, v, arg);
         break;
 
     case VCPUOP_get_runstate_info:
@@ -133,7 +131,7 @@ int compat_vcpu_op(int cmd, unsigned int vcpuid, XEN_GUEST_HANDLE_PARAM(void) ar
     }
 
     default:
-        rc = arch_compat_vcpu_op(cmd, v, arg);
+        rc = -ENOSYS;
         break;
     }
 
diff --git a/xen/common/domain.c b/xen/common/domain.c
index 8b53c49d1e..8eb36fe714 100644
--- a/xen/common/domain.c
+++ b/xen/common/domain.c
@@ -1559,14 +1559,11 @@ int default_initialise_vcpu(struct vcpu *v, XEN_GUEST_HANDLE_PARAM(void) arg)
     return rc;
 }
 
-long do_vcpu_op(int cmd, unsigned int vcpuid, XEN_GUEST_HANDLE_PARAM(void) arg)
+long common_vcpu_op(int cmd, struct vcpu *v, XEN_GUEST_HANDLE_PARAM(void) arg)
 {
-    struct domain *d = current->domain;
-    struct vcpu *v;
     long rc = 0;
-
-    if ( (v = domain_vcpu(d, vcpuid)) == NULL )
-        return -ENOENT;
+    struct domain *d = current->domain;
+    unsigned int vcpuid = v->vcpu_id;
 
     switch ( cmd )
     {
@@ -1736,7 +1733,7 @@ long do_vcpu_op(int cmd, unsigned int vcpuid, XEN_GUEST_HANDLE_PARAM(void) arg)
     }
 
     default:
-        rc = arch_do_vcpu_op(cmd, v, arg);
+        rc = -ENOSYS;
         break;
     }
 
diff --git a/xen/include/asm-arm/hypercall.h b/xen/include/asm-arm/hypercall.h
index a0c5a31a2f..9fd13c6b2c 100644
--- a/xen/include/asm-arm/hypercall.h
+++ b/xen/include/asm-arm/hypercall.h
@@ -4,8 +4,6 @@
 #include <public/domctl.h> /* for arch_do_domctl */
 int do_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg);
 
-long do_arm_vcpu_op(int cmd, unsigned int vcpuid, XEN_GUEST_HANDLE_PARAM(void) arg);
-
 long subarch_do_domctl(struct xen_domctl *domctl, struct domain *d,
                        XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_domctl);
 
diff --git a/xen/include/asm-x86/hypercall.h b/xen/include/asm-x86/hypercall.h
index 5d394d4923..e614f7c78c 100644
--- a/xen/include/asm-x86/hypercall.h
+++ b/xen/include/asm-x86/hypercall.h
@@ -152,7 +152,7 @@ compat_physdev_op(
     XEN_GUEST_HANDLE_PARAM(void) arg);
 
 extern int
-arch_compat_vcpu_op(
+compat_common_vcpu_op(
     int cmd, struct vcpu *v, XEN_GUEST_HANDLE_PARAM(void) arg);
 
 extern int compat_mmuext_op(
diff --git a/xen/include/xen/hypercall.h b/xen/include/xen/hypercall.h
index 07b10ec230..30558d3c61 100644
--- a/xen/include/xen/hypercall.h
+++ b/xen/include/xen/hypercall.h
@@ -110,7 +110,7 @@ do_vcpu_op(
 
 struct vcpu;
 extern long
-arch_do_vcpu_op(int cmd,
+common_vcpu_op(int cmd,
     struct vcpu *v,
     XEN_GUEST_HANDLE_PARAM(void) arg);
 
-- 
2.26.2



From xen-devel-bounces@lists.xenproject.org Fri Oct 15 12:52:15 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 12:52:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.210478.367374 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbMh0-0001aV-9B; Fri, 15 Oct 2021 12:52:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 210478.367374; Fri, 15 Oct 2021 12:52:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbMh0-0001aK-5b; Fri, 15 Oct 2021 12:52:10 +0000
Received: by outflank-mailman (input) for mailman id 210478;
 Fri, 15 Oct 2021 12:52:09 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=esao=PD=suse.com=jgross@srs-us1.protection.inumbo.net>)
 id 1mbMgz-00012o-2z
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 12:52:09 +0000
Received: from smtp-out1.suse.de (unknown [195.135.220.28])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 40cbc8a5-4797-46f1-86f7-a8bb1b3388ee;
 Fri, 15 Oct 2021 12:52:04 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 4FF3621A63;
 Fri, 15 Oct 2021 12:52:03 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 20ED713FC3;
 Fri, 15 Oct 2021 12:52:03 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id YOatBnN5aWEYHgAAMHmgww
 (envelope-from <jgross@suse.com>); Fri, 15 Oct 2021 12:52:03 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 40cbc8a5-4797-46f1-86f7-a8bb1b3388ee
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1634302323; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=YcsMVWc26F4IzPW2qrnc4ICY7a8VQjWrlsP2Sb59fyU=;
	b=b5jLXeJGRzgnF+yPJZIrIJWvYnXluHjYMdVg9xIscKbfTQKjyiujP9hn1EeaijyMyOD9RS
	zAYSX0PULlPGj5LPeX02dGUILdmViL492DfiIV7HiDsCy0TfKQQXrYkLq3BnsvahvzQI7n
	Ug5PjXPL/n3M/X2YjaHH9lF50c0dsGQ=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org
Cc: Juergen Gross <jgross@suse.com>,
	Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	Wei Liu <wl@xen.org>
Subject: [PATCH 04/12] xen/x86: modify hvm_memory_op() prototype
Date: Fri, 15 Oct 2021 14:51:44 +0200
Message-Id: <20211015125152.25198-5-jgross@suse.com>
X-Mailer: git-send-email 2.26.2
In-Reply-To: <20211015125152.25198-1-jgross@suse.com>
References: <20211015125152.25198-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

hvm_memory_op() should take an unsigned long as cmd, like
do_memory_op().

As hvm_memory_op() is basically just calling do_memory_op() (or
compat_memory_op()) passing through the parameters the cmd parameter
should have no smaller size than that of the called functions.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 xen/arch/x86/hvm/hypercall.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/arch/x86/hvm/hypercall.c b/xen/arch/x86/hvm/hypercall.c
index 5be1050453..9d3b193bad 100644
--- a/xen/arch/x86/hvm/hypercall.c
+++ b/xen/arch/x86/hvm/hypercall.c
@@ -31,7 +31,7 @@
 #include <public/hvm/hvm_op.h>
 #include <public/hvm/params.h>
 
-static long hvm_memory_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
+static long hvm_memory_op(unsigned long cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
 {
     long rc;
 
-- 
2.26.2



From xen-devel-bounces@lists.xenproject.org Fri Oct 15 12:52:17 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 12:52:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.210476.367353 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbMgu-000131-M8; Fri, 15 Oct 2021 12:52:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 210476.367353; Fri, 15 Oct 2021 12:52:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbMgu-00012u-Iv; Fri, 15 Oct 2021 12:52:04 +0000
Received: by outflank-mailman (input) for mailman id 210476;
 Fri, 15 Oct 2021 12:52:04 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=esao=PD=suse.com=jgross@srs-us1.protection.inumbo.net>)
 id 1mbMgu-00012o-4G
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 12:52:04 +0000
Received: from smtp-out2.suse.de (unknown [195.135.220.29])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 06d854fb-6787-4ba4-ad8a-409e563bf1c8;
 Fri, 15 Oct 2021 12:52:03 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 29F6E1FD39;
 Fri, 15 Oct 2021 12:52:02 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id D0CB813C1A;
 Fri, 15 Oct 2021 12:52:01 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id ePzMMXF5aWEYHgAAMHmgww
 (envelope-from <jgross@suse.com>); Fri, 15 Oct 2021 12:52:01 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 06d854fb-6787-4ba4-ad8a-409e563bf1c8
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1634302322; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:  content-transfer-encoding:content-transfer-encoding;
	bh=h/aThGSgBclseJubeLeify5D5fKyfeInIDBDmjWAbXI=;
	b=mgfx1mPuqx8QPBgWxSs4lT6zY/yY0XglsxROx8ZQSISYz74TwIRM3jeQhTi2LpJGqk/TMG
	KUZwetUF5tM951dPJL6HLejis7R+mAb+wHwiKu1URBX0/Ov8suGCieUdzhvRTIPQAyH0pm
	5ZhmOT70NZqd6RjjNA0EM6yavWGvqSA=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org
Cc: Juergen Gross <jgross@suse.com>,
	Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	Wei Liu <wl@xen.org>,
	George Dunlap <george.dunlap@citrix.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Ian Jackson <iwj@xenproject.org>,
	Christopher Clark <christopher.w.clark@gmail.com>
Subject: [PATCH 00/12] xen: drop hypercall function tables
Date: Fri, 15 Oct 2021 14:51:40 +0200
Message-Id: <20211015125152.25198-1-jgross@suse.com>
X-Mailer: git-send-email 2.26.2
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

In order to avoid indirect function calls on the hypercall path as
much as possible this series is removing the hypercall function tables
and is replacing the hypercall handler calls via the function array
by automatically generated switch statements.

Another by-product of generating the switch statements is the
automatic generating of the hypercall handler prototypes from the
same data base which is used to generate the switch.

This has the additional advantage of using type safe calls of the
handlers and to ensure related handler (e.g. PV and HVM ones) share
the same prototypes.

A very brief performance test (parallel build of the Xen hypervisor
in a 6 vcpu guest) showed a very slim improvement (less than 1%) of
the performance with the patches applied. The test was performed using
a PV and a PVH guest.

Juergen Gross (12):
  xen: limit number of hypercall parameters to 5
  xen: move do_vcpu_op() to arch specific code
  xen: harmonize return types of hypercall handlers
  xen/x86: modify hvm_memory_op() prototype
  xen: don't include asm/hypercall.h from C sources
  xen: generate hypercall interface related code
  xen: use generated prototypes for hypercall handlers
  x86/pv-shim: don't modify hypercall table
  xen/x86: don't use hypercall table for calling compat hypercalls
  xen/x86: call hypercall handlers via switch statement
  xen/arm: call hypercall handlers via switch statement
  xen/x86: add hypercall performance counters for hvm, correct pv

 .gitignore                               |   2 +
 xen/Makefile                             |  10 +
 xen/arch/arm/domain.c                    |  15 +-
 xen/arch/arm/hvm.c                       |   3 +-
 xen/arch/arm/physdev.c                   |   2 +-
 xen/arch/arm/platform_hypercall.c        |   6 +-
 xen/arch/arm/traps.c                     | 124 +++--------
 xen/arch/x86/compat.c                    |  14 +-
 xen/arch/x86/cpu/vpmu.c                  |   1 +
 xen/arch/x86/domain.c                    |  11 +-
 xen/arch/x86/domctl.c                    |   4 +-
 xen/arch/x86/hvm/hypercall.c             | 172 ++------------
 xen/arch/x86/hypercall.c                 |  59 -----
 xen/arch/x86/mm.c                        |   1 -
 xen/arch/x86/mm/paging.c                 |   3 +-
 xen/arch/x86/platform_hypercall.c        |   6 +-
 xen/arch/x86/pv/callback.c               |  20 +-
 xen/arch/x86/pv/emul-priv-op.c           |   2 +-
 xen/arch/x86/pv/hypercall.c              | 188 ++--------------
 xen/arch/x86/pv/iret.c                   |   5 +-
 xen/arch/x86/pv/misc-hypercalls.c        |  14 +-
 xen/arch/x86/pv/shim.c                   |  48 ++--
 xen/arch/x86/traps.c                     |   2 +-
 xen/arch/x86/x86_64/compat.c             |   1 -
 xen/arch/x86/x86_64/compat/mm.c          |   1 +
 xen/arch/x86/x86_64/domain.c             |  16 +-
 xen/arch/x86/x86_64/mm.c                 |   1 -
 xen/arch/x86/x86_64/platform_hypercall.c |   9 +-
 xen/common/argo.c                        |  12 +-
 xen/common/compat/domain.c               |  14 +-
 xen/common/compat/grant_table.c          |   1 +
 xen/common/compat/multicall.c            |   2 +-
 xen/common/domain.c                      |  11 +-
 xen/common/event_channel.c               |  10 +
 xen/common/grant_table.c                 |  10 +
 xen/common/kexec.c                       |   6 +-
 xen/common/multicall.c                   |   1 +
 xen/common/trace.c                       |   2 +-
 xen/include/asm-arm/hypercall.h          |   7 +-
 xen/include/asm-x86/hypercall.h          | 195 +++-------------
 xen/include/asm-x86/paging.h             |   3 -
 xen/include/asm-x86/pv/shim.h            |   3 +
 xen/include/hypercall-defs.c             | 272 +++++++++++++++++++++++
 xen/include/xen/hypercall.h              | 181 +--------------
 xen/scripts/gen_hypercall.awk            | 228 +++++++++++++++++++
 45 files changed, 769 insertions(+), 929 deletions(-)
 create mode 100644 xen/include/hypercall-defs.c
 create mode 100644 xen/scripts/gen_hypercall.awk

-- 
2.26.2



From xen-devel-bounces@lists.xenproject.org Fri Oct 15 12:52:17 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 12:52:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.210477.367364 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbMgx-0001Iy-Us; Fri, 15 Oct 2021 12:52:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 210477.367364; Fri, 15 Oct 2021 12:52:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbMgx-0001Ir-RU; Fri, 15 Oct 2021 12:52:07 +0000
Received: by outflank-mailman (input) for mailman id 210477;
 Fri, 15 Oct 2021 12:52:07 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=esao=PD=suse.com=jgross@srs-us1.protection.inumbo.net>)
 id 1mbMgw-0001If-VX
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 12:52:07 +0000
Received: from smtp-out2.suse.de (unknown [195.135.220.29])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id b0c4471d-2db6-11ec-8235-12813bfff9fa;
 Fri, 15 Oct 2021 12:52:03 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 60F781FD4D;
 Fri, 15 Oct 2021 12:52:02 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 2EA2F13FC3;
 Fri, 15 Oct 2021 12:52:02 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id 2B42CnJ5aWEYHgAAMHmgww
 (envelope-from <jgross@suse.com>); Fri, 15 Oct 2021 12:52:02 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b0c4471d-2db6-11ec-8235-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1634302322; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=DEHpkmfZZt1as/ZYBqmT3ZnKiWxNryhzyhq2qPkcsrg=;
	b=uYdgmTzuLpR62js2qZH5Kr6ISPNqFaqKpw3hm8tAqdoD8QVVK/z9iLy82dvpWbJWBpmohF
	H73jgVGQ+ztugPtIfLrJX3LId7J+QmHYFUM+IJNJyqWbJGC8fCvPNUlIgepeFF8nWG8fY9
	pc8q99wxz79rnjlqBOl3ooYtHNdEL2Q=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org
Cc: Juergen Gross <jgross@suse.com>,
	Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	Wei Liu <wl@xen.org>,
	George Dunlap <george.dunlap@citrix.com>
Subject: [PATCH 01/12] xen: limit number of hypercall parameters to 5
Date: Fri, 15 Oct 2021 14:51:41 +0200
Message-Id: <20211015125152.25198-2-jgross@suse.com>
X-Mailer: git-send-email 2.26.2
In-Reply-To: <20211015125152.25198-1-jgross@suse.com>
References: <20211015125152.25198-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Today there is no hypercall with more than 5 parameters, while the ABI
allows up to 6 parameters. Especially for the X86 32-bit case using
6 parameters would require to run without frame pointer, which isn't
very fortunate. Note that for Arm the limit is 5 parameters already.

So limit the maximum number of parameters to 5 for x86, too.

Signed-off-by: Juergen Gross <jgross@suse.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
---
 xen/arch/x86/hvm/hypercall.c    | 28 ++++++++++------------------
 xen/arch/x86/pv/hypercall.c     | 22 ++++++++--------------
 xen/common/trace.c              |  2 +-
 xen/include/asm-x86/hypercall.h |  2 +-
 4 files changed, 20 insertions(+), 34 deletions(-)

diff --git a/xen/arch/x86/hvm/hypercall.c b/xen/arch/x86/hvm/hypercall.c
index 122abf80de..f0321c6cb4 100644
--- a/xen/arch/x86/hvm/hypercall.c
+++ b/xen/arch/x86/hvm/hypercall.c
@@ -239,10 +239,9 @@ int hvm_hypercall(struct cpu_user_regs *regs)
         unsigned long rdx = regs->rdx;
         unsigned long r10 = regs->r10;
         unsigned long r8 = regs->r8;
-        unsigned long r9 = regs->r9;
 
-        HVM_DBG_LOG(DBG_LEVEL_HCALL, "hcall%lu(%lx, %lx, %lx, %lx, %lx, %lx)",
-                    eax, rdi, rsi, rdx, r10, r8, r9);
+        HVM_DBG_LOG(DBG_LEVEL_HCALL, "hcall%lu(%lx, %lx, %lx, %lx, %lx)",
+                    eax, rdi, rsi, rdx, r10, r8);
 
 #ifndef NDEBUG
         /* Deliberately corrupt parameter regs not used by this hypercall. */
@@ -252,13 +251,11 @@ int hvm_hypercall(struct cpu_user_regs *regs)
         case 1: rsi = 0xdeadbeefdeadf00dUL; fallthrough;
         case 2: rdx = 0xdeadbeefdeadf00dUL; fallthrough;
         case 3: r10 = 0xdeadbeefdeadf00dUL; fallthrough;
-        case 4: r8 = 0xdeadbeefdeadf00dUL; fallthrough;
-        case 5: r9 = 0xdeadbeefdeadf00dUL;
+        case 4: r8 = 0xdeadbeefdeadf00dUL;
         }
 #endif
 
-        regs->rax = hvm_hypercall_table[eax].native(rdi, rsi, rdx, r10, r8,
-                                                    r9);
+        regs->rax = hvm_hypercall_table[eax].native(rdi, rsi, rdx, r10, r8);
 
 #ifndef NDEBUG
         if ( !curr->hcall_preempted )
@@ -266,7 +263,6 @@ int hvm_hypercall(struct cpu_user_regs *regs)
             /* Deliberately corrupt parameter regs used by this hypercall. */
             switch ( hypercall_args_table[eax].native )
             {
-            case 6: regs->r9  = 0xdeadbeefdeadf00dUL; fallthrough;
             case 5: regs->r8  = 0xdeadbeefdeadf00dUL; fallthrough;
             case 4: regs->r10 = 0xdeadbeefdeadf00dUL; fallthrough;
             case 3: regs->rdx = 0xdeadbeefdeadf00dUL; fallthrough;
@@ -283,10 +279,9 @@ int hvm_hypercall(struct cpu_user_regs *regs)
         unsigned int edx = regs->edx;
         unsigned int esi = regs->esi;
         unsigned int edi = regs->edi;
-        unsigned int ebp = regs->ebp;
 
-        HVM_DBG_LOG(DBG_LEVEL_HCALL, "hcall%lu(%x, %x, %x, %x, %x, %x)", eax,
-                    ebx, ecx, edx, esi, edi, ebp);
+        HVM_DBG_LOG(DBG_LEVEL_HCALL, "hcall%lu(%x, %x, %x, %x, %x)", eax,
+                    ebx, ecx, edx, esi, edi);
 
 #ifndef NDEBUG
         /* Deliberately corrupt parameter regs not used by this hypercall. */
@@ -296,14 +291,12 @@ int hvm_hypercall(struct cpu_user_regs *regs)
         case 1: ecx = 0xdeadf00d; fallthrough;
         case 2: edx = 0xdeadf00d; fallthrough;
         case 3: esi = 0xdeadf00d; fallthrough;
-        case 4: edi = 0xdeadf00d; fallthrough;
-        case 5: ebp = 0xdeadf00d;
+        case 4: edi = 0xdeadf00d;
         }
 #endif
 
         curr->hcall_compat = true;
-        regs->rax = hvm_hypercall_table[eax].compat(ebx, ecx, edx, esi, edi,
-                                                    ebp);
+        regs->rax = hvm_hypercall_table[eax].compat(ebx, ecx, edx, esi, edi);
         curr->hcall_compat = false;
 
 #ifndef NDEBUG
@@ -312,7 +305,6 @@ int hvm_hypercall(struct cpu_user_regs *regs)
             /* Deliberately corrupt parameter regs used by this hypercall. */
             switch ( hypercall_args_table[eax].compat )
             {
-            case 6: regs->rbp = 0xdeadf00d; fallthrough;
             case 5: regs->rdi = 0xdeadf00d; fallthrough;
             case 4: regs->rsi = 0xdeadf00d; fallthrough;
             case 3: regs->rdx = 0xdeadf00d; fallthrough;
@@ -349,7 +341,7 @@ enum mc_disposition hvm_do_multicall_call(struct mc_state *state)
             func = array_access_nospec(hvm_hypercall_table, call->op).native;
         if ( func )
             call->result = func(call->args[0], call->args[1], call->args[2],
-                                call->args[3], call->args[4], call->args[5]);
+                                call->args[3], call->args[4]);
         else
             call->result = -ENOSYS;
     }
@@ -361,7 +353,7 @@ enum mc_disposition hvm_do_multicall_call(struct mc_state *state)
             func = array_access_nospec(hvm_hypercall_table, call->op).compat;
         if ( func )
             call->result = func(call->args[0], call->args[1], call->args[2],
-                                call->args[3], call->args[4], call->args[5]);
+                                call->args[3], call->args[4]);
         else
             call->result = -ENOSYS;
     }
diff --git a/xen/arch/x86/pv/hypercall.c b/xen/arch/x86/pv/hypercall.c
index 3579ba905c..16a77e3a35 100644
--- a/xen/arch/x86/pv/hypercall.c
+++ b/xen/arch/x86/pv/hypercall.c
@@ -145,7 +145,6 @@ _pv_hypercall(struct cpu_user_regs *regs, bool compat)
         unsigned long rdx = regs->rdx;
         unsigned long r10 = regs->r10;
         unsigned long r8 = regs->r8;
-        unsigned long r9 = regs->r9;
 
 #ifndef NDEBUG
         /* Deliberately corrupt parameter regs not used by this hypercall. */
@@ -155,18 +154,17 @@ _pv_hypercall(struct cpu_user_regs *regs, bool compat)
         case 1: rsi = 0xdeadbeefdeadf00dUL; fallthrough;
         case 2: rdx = 0xdeadbeefdeadf00dUL; fallthrough;
         case 3: r10 = 0xdeadbeefdeadf00dUL; fallthrough;
-        case 4: r8 = 0xdeadbeefdeadf00dUL; fallthrough;
-        case 5: r9 = 0xdeadbeefdeadf00dUL;
+        case 4: r8 = 0xdeadbeefdeadf00dUL;
         }
 #endif
         if ( unlikely(tb_init_done) )
         {
-            unsigned long args[6] = { rdi, rsi, rdx, r10, r8, r9 };
+            unsigned long args[5] = { rdi, rsi, rdx, r10, r8 };
 
             __trace_hypercall(TRC_PV_HYPERCALL_V2, eax, args);
         }
 
-        regs->rax = pv_hypercall_table[eax].native(rdi, rsi, rdx, r10, r8, r9);
+        regs->rax = pv_hypercall_table[eax].native(rdi, rsi, rdx, r10, r8);
 
 #ifndef NDEBUG
         if ( !curr->hcall_preempted )
@@ -174,7 +172,6 @@ _pv_hypercall(struct cpu_user_regs *regs, bool compat)
             /* Deliberately corrupt parameter regs used by this hypercall. */
             switch ( hypercall_args_table[eax].native )
             {
-            case 6: regs->r9  = 0xdeadbeefdeadf00dUL; fallthrough;
             case 5: regs->r8  = 0xdeadbeefdeadf00dUL; fallthrough;
             case 4: regs->r10 = 0xdeadbeefdeadf00dUL; fallthrough;
             case 3: regs->rdx = 0xdeadbeefdeadf00dUL; fallthrough;
@@ -192,7 +189,6 @@ _pv_hypercall(struct cpu_user_regs *regs, bool compat)
         unsigned int edx = regs->edx;
         unsigned int esi = regs->esi;
         unsigned int edi = regs->edi;
-        unsigned int ebp = regs->ebp;
 
 #ifndef NDEBUG
         /* Deliberately corrupt parameter regs not used by this hypercall. */
@@ -202,20 +198,19 @@ _pv_hypercall(struct cpu_user_regs *regs, bool compat)
         case 1: ecx = 0xdeadf00d; fallthrough;
         case 2: edx = 0xdeadf00d; fallthrough;
         case 3: esi = 0xdeadf00d; fallthrough;
-        case 4: edi = 0xdeadf00d; fallthrough;
-        case 5: ebp = 0xdeadf00d;
+        case 4: edi = 0xdeadf00d;
         }
 #endif
 
         if ( unlikely(tb_init_done) )
         {
-            unsigned long args[6] = { ebx, ecx, edx, esi, edi, ebp };
+            unsigned long args[5] = { ebx, ecx, edx, esi, edi };
 
             __trace_hypercall(TRC_PV_HYPERCALL_V2, eax, args);
         }
 
         curr->hcall_compat = true;
-        regs->eax = pv_hypercall_table[eax].compat(ebx, ecx, edx, esi, edi, ebp);
+        regs->eax = pv_hypercall_table[eax].compat(ebx, ecx, edx, esi, edi);
         curr->hcall_compat = false;
 
 #ifndef NDEBUG
@@ -224,7 +219,6 @@ _pv_hypercall(struct cpu_user_regs *regs, bool compat)
             /* Deliberately corrupt parameter regs used by this hypercall. */
             switch ( hypercall_args_table[eax].compat )
             {
-            case 6: regs->ebp = 0xdeadf00d; fallthrough;
             case 5: regs->edi = 0xdeadf00d; fallthrough;
             case 4: regs->esi = 0xdeadf00d; fallthrough;
             case 3: regs->edx = 0xdeadf00d; fallthrough;
@@ -262,7 +256,7 @@ enum mc_disposition pv_do_multicall_call(struct mc_state *state)
              pv_hypercall_table[op].compat )
             call->result = pv_hypercall_table[op].compat(
                 call->args[0], call->args[1], call->args[2],
-                call->args[3], call->args[4], call->args[5]);
+                call->args[3], call->args[4]);
         else
             call->result = -ENOSYS;
     }
@@ -276,7 +270,7 @@ enum mc_disposition pv_do_multicall_call(struct mc_state *state)
              pv_hypercall_table[op].native )
             call->result = pv_hypercall_table[op].native(
                 call->args[0], call->args[1], call->args[2],
-                call->args[3], call->args[4], call->args[5]);
+                call->args[3], call->args[4]);
         else
             call->result = -ENOSYS;
     }
diff --git a/xen/common/trace.c b/xen/common/trace.c
index a2a389a1c7..61fecc2b2b 100644
--- a/xen/common/trace.c
+++ b/xen/common/trace.c
@@ -822,7 +822,7 @@ void __trace_hypercall(uint32_t event, unsigned long op,
 {
     struct {
         uint32_t op;
-        uint32_t args[6];
+        uint32_t args[5];
     } d;
     uint32_t *a = d.args;
 
diff --git a/xen/include/asm-x86/hypercall.h b/xen/include/asm-x86/hypercall.h
index 0ae3b8b043..5d394d4923 100644
--- a/xen/include/asm-x86/hypercall.h
+++ b/xen/include/asm-x86/hypercall.h
@@ -13,7 +13,7 @@
 
 typedef unsigned long hypercall_fn_t(
     unsigned long, unsigned long, unsigned long,
-    unsigned long, unsigned long, unsigned long);
+    unsigned long, unsigned long);
 
 typedef struct {
     hypercall_fn_t *native;
-- 
2.26.2



From xen-devel-bounces@lists.xenproject.org Fri Oct 15 12:52:18 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 12:52:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.210481.367407 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbMh8-0002aL-6U; Fri, 15 Oct 2021 12:52:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 210481.367407; Fri, 15 Oct 2021 12:52:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbMh8-0002aE-30; Fri, 15 Oct 2021 12:52:18 +0000
Received: by outflank-mailman (input) for mailman id 210481;
 Fri, 15 Oct 2021 12:52:17 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=esao=PD=suse.com=jgross@srs-us1.protection.inumbo.net>)
 id 1mbMh6-0001If-UN
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 12:52:16 +0000
Received: from smtp-out2.suse.de (unknown [195.135.220.29])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id b16a0834-2db6-11ec-8235-12813bfff9fa;
 Fri, 15 Oct 2021 12:52:04 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 1AA841FD4E;
 Fri, 15 Oct 2021 12:52:03 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id BBA3A13C1A;
 Fri, 15 Oct 2021 12:52:02 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id +BCdLHJ5aWEYHgAAMHmgww
 (envelope-from <jgross@suse.com>); Fri, 15 Oct 2021 12:52:02 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b16a0834-2db6-11ec-8235-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1634302323; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=+amjpCEkLABoHYrFaDEAVh4RiKqtXVPNjx7bKB7pr0s=;
	b=WN/m/f3HLIHinv6kfyD/+6ZawzkDnbHEwzqZmzqcizsLFIA3sN0mL+ZPXSrYfQQ0z8xSL0
	xqBYeaxuI8KNgovnwObLkJlmBn3QPJwmHct/npPk64xlV+Bjn0bHSwfV9yOKnJazSNqfAs
	AkM6S6a343RQe9GXZaY4Ca6V9ngNHw0=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org
Cc: Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Ian Jackson <iwj@xenproject.org>,
	Jan Beulich <jbeulich@suse.com>,
	Wei Liu <wl@xen.org>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	Christopher Clark <christopher.w.clark@gmail.com>
Subject: [PATCH 03/12] xen: harmonize return types of hypercall handlers
Date: Fri, 15 Oct 2021 14:51:43 +0200
Message-Id: <20211015125152.25198-4-jgross@suse.com>
X-Mailer: git-send-email 2.26.2
In-Reply-To: <20211015125152.25198-1-jgross@suse.com>
References: <20211015125152.25198-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Today most hypercall handlers have a return type of long, while the
compat ones return an int. There are a few exceptions from that rule,
however.

Get rid of the exceptions by letting compat handlers always return int
and others always return long.

For the compat hvm case use eax instead of rax for the stored result as
it should have been from the beginning.

Additionally move some prototypes to include/asm-x86/hypercall.h
as they are x86 specific. Move the do_physdev_op() prototype from both
architecture dependant headers to the common one. Move the
compat_platform_op() prototype to the common header.

Switch some non style compliant types (u32, s32, s64) to style compliant
ones.

Rename paging_domctl_continuation() to do_paging_domctl_cont() and add
a matching define for the associated hypercall.

Make do_callback_op() and compat_callback_op() more similar by adding
the const attribute to compat_callback_op()'s 2nd parameter.

The do_platform_op() prototype needs to be modified in order to better
match its compat variant.

Change the type of the cmd parameter for [do|compat]_kexec_op() to
unsigned int, as this is more appropriate for the compat case.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 xen/arch/arm/physdev.c                   |  2 +-
 xen/arch/arm/platform_hypercall.c        |  5 ++-
 xen/arch/x86/domctl.c                    |  4 +--
 xen/arch/x86/hvm/hypercall.c             |  8 ++---
 xen/arch/x86/hypercall.c                 |  2 +-
 xen/arch/x86/mm/paging.c                 |  3 +-
 xen/arch/x86/platform_hypercall.c        |  5 ++-
 xen/arch/x86/pv/callback.c               | 20 +++++------
 xen/arch/x86/pv/emul-priv-op.c           |  2 +-
 xen/arch/x86/pv/hypercall.c              |  5 +--
 xen/arch/x86/pv/iret.c                   |  4 +--
 xen/arch/x86/pv/misc-hypercalls.c        | 14 +++++---
 xen/arch/x86/x86_64/platform_hypercall.c |  5 ++-
 xen/common/argo.c                        | 12 +++----
 xen/common/kexec.c                       |  6 ++--
 xen/include/asm-arm/hypercall.h          |  1 -
 xen/include/asm-x86/hypercall.h          | 43 +++++++++++-------------
 xen/include/asm-x86/paging.h             |  3 --
 xen/include/xen/hypercall.h              | 26 +++++++-------
 19 files changed, 84 insertions(+), 86 deletions(-)

diff --git a/xen/arch/arm/physdev.c b/xen/arch/arm/physdev.c
index f9aa274dda..5a7593fa8f 100644
--- a/xen/arch/arm/physdev.c
+++ b/xen/arch/arm/physdev.c
@@ -11,7 +11,7 @@
 #include <xen/hypercall.h>
 
 
-int do_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
+long do_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
 {
 #ifdef CONFIG_HAS_PCI
     return pci_physdev_op(cmd, arg);
diff --git a/xen/arch/arm/platform_hypercall.c b/xen/arch/arm/platform_hypercall.c
index 8efac7ee60..0013b99202 100644
--- a/xen/arch/arm/platform_hypercall.c
+++ b/xen/arch/arm/platform_hypercall.c
@@ -17,12 +17,15 @@
 
 DEFINE_SPINLOCK(xenpf_lock);
 
-long do_platform_op(XEN_GUEST_HANDLE_PARAM(xen_platform_op_t) u_xenpf_op)
+long do_platform_op(XEN_GUEST_HANDLE_PARAM(void) arg)
 {
     long ret;
+    XEN_GUEST_HANDLE_PARAM(xen_platform_op_t) u_xenpf_op;
     struct xen_platform_op curop, *op = &curop;
     struct domain *d;
 
+    u_xenpf_op = guest_handle_cast(arg, xen_platform_op_t);
+
     if ( copy_from_guest(op, u_xenpf_op, 1) )
         return -EFAULT;
 
diff --git a/xen/arch/x86/domctl.c b/xen/arch/x86/domctl.c
index 7d102e0647..b01ea81373 100644
--- a/xen/arch/x86/domctl.c
+++ b/xen/arch/x86/domctl.c
@@ -221,8 +221,8 @@ long arch_do_domctl(
     case XEN_DOMCTL_shadow_op:
         ret = paging_domctl(d, &domctl->u.shadow_op, u_domctl, 0);
         if ( ret == -ERESTART )
-            return hypercall_create_continuation(__HYPERVISOR_arch_1,
-                                                 "h", u_domctl);
+            return hypercall_create_continuation(
+                       __HYPERVISOR_paging_domctl_cont, "h", u_domctl);
         copyback = true;
         break;
 
diff --git a/xen/arch/x86/hvm/hypercall.c b/xen/arch/x86/hvm/hypercall.c
index f0321c6cb4..5be1050453 100644
--- a/xen/arch/x86/hvm/hypercall.c
+++ b/xen/arch/x86/hvm/hypercall.c
@@ -120,8 +120,6 @@ static long hvm_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
     [ __HYPERVISOR_ ## x ] = { (hypercall_fn_t *) do_ ## x,  \
                                (hypercall_fn_t *) compat_ ## x }
 
-#define do_arch_1             paging_domctl_continuation
-
 static const struct {
     hypercall_fn_t *native, *compat;
 } hvm_hypercall_table[] = {
@@ -154,11 +152,9 @@ static const struct {
 #ifdef CONFIG_HYPFS
     HYPERCALL(hypfs_op),
 #endif
-    HYPERCALL(arch_1)
+    HYPERCALL(paging_domctl_cont)
 };
 
-#undef do_arch_1
-
 #undef HYPERCALL
 #undef HVM_CALL
 #undef COMPAT_CALL
@@ -296,7 +292,7 @@ int hvm_hypercall(struct cpu_user_regs *regs)
 #endif
 
         curr->hcall_compat = true;
-        regs->rax = hvm_hypercall_table[eax].compat(ebx, ecx, edx, esi, edi);
+        regs->eax = hvm_hypercall_table[eax].compat(ebx, ecx, edx, esi, edi);
         curr->hcall_compat = false;
 
 #ifndef NDEBUG
diff --git a/xen/arch/x86/hypercall.c b/xen/arch/x86/hypercall.c
index 2370d31d3f..07e1a45ef5 100644
--- a/xen/arch/x86/hypercall.c
+++ b/xen/arch/x86/hypercall.c
@@ -75,7 +75,7 @@ const hypercall_args_t hypercall_args_table[NR_hypercalls] =
     ARGS(dm_op, 3),
     ARGS(hypfs_op, 5),
     ARGS(mca, 1),
-    ARGS(arch_1, 1),
+    ARGS(paging_domctl_cont, 1),
 };
 
 #undef COMP
diff --git a/xen/arch/x86/mm/paging.c b/xen/arch/x86/mm/paging.c
index dd6b2bdf6f..6cc2636bf4 100644
--- a/xen/arch/x86/mm/paging.c
+++ b/xen/arch/x86/mm/paging.c
@@ -21,6 +21,7 @@
 
 #include <xen/init.h>
 #include <xen/guest_access.h>
+#include <xen/hypercall.h>
 #include <asm/paging.h>
 #include <asm/shadow.h>
 #include <asm/p2m.h>
@@ -756,7 +757,7 @@ int paging_domctl(struct domain *d, struct xen_domctl_shadow_op *sc,
         return shadow_domctl(d, sc, u_domctl);
 }
 
-long paging_domctl_continuation(XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_domctl)
+long do_paging_domctl_cont(XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_domctl)
 {
     struct xen_domctl op;
     struct domain *d;
diff --git a/xen/arch/x86/platform_hypercall.c b/xen/arch/x86/platform_hypercall.c
index 284c2dfb9e..681e0eb6c6 100644
--- a/xen/arch/x86/platform_hypercall.c
+++ b/xen/arch/x86/platform_hypercall.c
@@ -210,11 +210,14 @@ void resource_access(void *info)
 }
 #endif
 
-ret_t do_platform_op(XEN_GUEST_HANDLE_PARAM(xen_platform_op_t) u_xenpf_op)
+ret_t do_platform_op(XEN_GUEST_HANDLE_PARAM(void) arg)
 {
     ret_t ret;
+    XEN_GUEST_HANDLE_PARAM(xen_platform_op_t) u_xenpf_op;
     struct xen_platform_op curop, *op = &curop;
 
+    u_xenpf_op = guest_handle_cast(arg, xen_platform_op_t);
+
     if ( copy_from_guest(op, u_xenpf_op, 1) )
         return -EFAULT;
 
diff --git a/xen/arch/x86/pv/callback.c b/xen/arch/x86/pv/callback.c
index 42a6aa0831..6d60263dbc 100644
--- a/xen/arch/x86/pv/callback.c
+++ b/xen/arch/x86/pv/callback.c
@@ -207,9 +207,9 @@ long do_set_callbacks(unsigned long event_address,
 #include <compat/callback.h>
 #include <compat/nmi.h>
 
-static long compat_register_guest_callback(struct compat_callback_register *reg)
+static int compat_register_guest_callback(struct compat_callback_register *reg)
 {
-    long ret = 0;
+    int ret = 0;
     struct vcpu *curr = current;
 
     fixup_guest_code_selector(curr->domain, reg->address.cs);
@@ -256,10 +256,10 @@ static long compat_register_guest_callback(struct compat_callback_register *reg)
     return ret;
 }
 
-static long compat_unregister_guest_callback(
+static int compat_unregister_guest_callback(
     struct compat_callback_unregister *unreg)
 {
-    long ret;
+    int ret;
 
     switch ( unreg->type )
     {
@@ -283,9 +283,9 @@ static long compat_unregister_guest_callback(
     return ret;
 }
 
-long compat_callback_op(int cmd, XEN_GUEST_HANDLE(void) arg)
+int compat_callback_op(int cmd, XEN_GUEST_HANDLE(const_void) arg)
 {
-    long ret;
+    int ret;
 
     switch ( cmd )
     {
@@ -321,10 +321,10 @@ long compat_callback_op(int cmd, XEN_GUEST_HANDLE(void) arg)
     return ret;
 }
 
-long compat_set_callbacks(unsigned long event_selector,
-                          unsigned long event_address,
-                          unsigned long failsafe_selector,
-                          unsigned long failsafe_address)
+int compat_set_callbacks(unsigned long event_selector,
+                         unsigned long event_address,
+                         unsigned long failsafe_selector,
+                         unsigned long failsafe_address)
 {
     struct compat_callback_register event = {
         .type = CALLBACKTYPE_event,
diff --git a/xen/arch/x86/pv/emul-priv-op.c b/xen/arch/x86/pv/emul-priv-op.c
index d0df5bc616..41f72abbd2 100644
--- a/xen/arch/x86/pv/emul-priv-op.c
+++ b/xen/arch/x86/pv/emul-priv-op.c
@@ -22,12 +22,12 @@
 #include <xen/domain_page.h>
 #include <xen/event.h>
 #include <xen/guest_access.h>
+#include <xen/hypercall.h>
 #include <xen/iocap.h>
 
 #include <asm/amd.h>
 #include <asm/debugreg.h>
 #include <asm/hpet.h>
-#include <asm/hypercall.h>
 #include <asm/mc146818rtc.h>
 #include <asm/pv/domain.h>
 #include <asm/pv/trace.h>
diff --git a/xen/arch/x86/pv/hypercall.c b/xen/arch/x86/pv/hypercall.c
index 16a77e3a35..7e99dbda34 100644
--- a/xen/arch/x86/pv/hypercall.c
+++ b/xen/arch/x86/pv/hypercall.c
@@ -40,8 +40,6 @@
 #define COMPAT_CALL(x) HYPERCALL(x)
 #endif
 
-#define do_arch_1             paging_domctl_continuation
-
 const pv_hypercall_table_t pv_hypercall_table[] = {
     COMPAT_CALL(set_trap_table),
     HYPERCALL(mmu_update),
@@ -102,11 +100,10 @@ const pv_hypercall_table_t pv_hypercall_table[] = {
 #endif
     HYPERCALL(mca),
 #ifndef CONFIG_PV_SHIM_EXCLUSIVE
-    HYPERCALL(arch_1),
+    HYPERCALL(paging_domctl_cont),
 #endif
 };
 
-#undef do_arch_1
 #undef COMPAT_CALL
 #undef HYPERCALL
 
diff --git a/xen/arch/x86/pv/iret.c b/xen/arch/x86/pv/iret.c
index 29a2f7cc45..90946c4629 100644
--- a/xen/arch/x86/pv/iret.c
+++ b/xen/arch/x86/pv/iret.c
@@ -48,7 +48,7 @@ static void async_exception_cleanup(struct vcpu *curr)
         curr->arch.async_exception_state(trap).old_mask;
 }
 
-unsigned long do_iret(void)
+long do_iret(void)
 {
     struct cpu_user_regs *regs = guest_cpu_user_regs();
     struct iret_context iret_saved;
@@ -105,7 +105,7 @@ unsigned long do_iret(void)
 }
 
 #ifdef CONFIG_PV32
-unsigned int compat_iret(void)
+int compat_iret(void)
 {
     struct cpu_user_regs *regs = guest_cpu_user_regs();
     struct vcpu *v = current;
diff --git a/xen/arch/x86/pv/misc-hypercalls.c b/xen/arch/x86/pv/misc-hypercalls.c
index 5dade24726..8b9b1f8dfa 100644
--- a/xen/arch/x86/pv/misc-hypercalls.c
+++ b/xen/arch/x86/pv/misc-hypercalls.c
@@ -28,12 +28,16 @@ long do_set_debugreg(int reg, unsigned long value)
     return set_debugreg(current, reg, value);
 }
 
-unsigned long do_get_debugreg(int reg)
+long do_get_debugreg(int reg)
 {
-    unsigned long val;
-    int res = x86emul_read_dr(reg, &val, NULL);
-
-    return res == X86EMUL_OKAY ? val : -ENODEV;
+    /* Avoid undefined behavior due to casting an unsigned long to long. */
+    union {
+        unsigned long val;
+        long ret;
+    } u;
+    int res = x86emul_read_dr(reg, &u.val, NULL);
+
+    return res == X86EMUL_OKAY ? u.ret : -ENODEV;
 }
 
 long do_fpu_taskswitch(int set)
diff --git a/xen/arch/x86/x86_64/platform_hypercall.c b/xen/arch/x86/x86_64/platform_hypercall.c
index fbba893a47..4576c014a4 100644
--- a/xen/arch/x86/x86_64/platform_hypercall.c
+++ b/xen/arch/x86/x86_64/platform_hypercall.c
@@ -4,13 +4,16 @@
 
 EMIT_FILE;
 
+#include <xen/types.h>
+#include <xen/guest_access.h>
+#include <xen/hypercall.h>
 #include <xen/lib.h>
 #include <compat/platform.h>
 
 DEFINE_XEN_GUEST_HANDLE(compat_platform_op_t);
 #define xen_platform_op     compat_platform_op
 #define xen_platform_op_t   compat_platform_op_t
-#define do_platform_op(x)   compat_platform_op(_##x)
+#define do_platform_op(x)   compat_platform_op(x)
 
 #define efi_get_info        efi_compat_get_info
 #define efi_runtime_call(x) efi_compat_runtime_call(x)
diff --git a/xen/common/argo.c b/xen/common/argo.c
index eaea7ba888..bf6aac7655 100644
--- a/xen/common/argo.c
+++ b/xen/common/argo.c
@@ -2207,13 +2207,13 @@ do_argo_op(unsigned int cmd, XEN_GUEST_HANDLE_PARAM(void) arg1,
 }
 
 #ifdef CONFIG_COMPAT
-long
-compat_argo_op(unsigned int cmd, XEN_GUEST_HANDLE_PARAM(void) arg1,
-               XEN_GUEST_HANDLE_PARAM(void) arg2, unsigned long arg3,
-               unsigned long arg4)
+int compat_argo_op(unsigned int cmd,
+                   XEN_GUEST_HANDLE_PARAM(void) arg1,
+                   XEN_GUEST_HANDLE_PARAM(void) arg2,
+                   unsigned long arg3, unsigned long arg4)
 {
     struct domain *currd = current->domain;
-    long rc;
+    int rc;
     xen_argo_send_addr_t send_addr;
     xen_argo_iov_t iovs[XEN_ARGO_MAXIOV];
     compat_argo_iov_t compat_iovs[XEN_ARGO_MAXIOV];
@@ -2267,7 +2267,7 @@ compat_argo_op(unsigned int cmd, XEN_GUEST_HANDLE_PARAM(void) arg1,
 
     rc = sendv(currd, &send_addr.src, &send_addr.dst, iovs, niov, arg4);
  out:
-    argo_dprintk("<-compat_argo_op(%u)=%ld\n", cmd, rc);
+    argo_dprintk("<-compat_argo_op(%u)=%d\n", cmd, rc);
 
     return rc;
 }
diff --git a/xen/common/kexec.c b/xen/common/kexec.c
index c63db618a7..d7373233e1 100644
--- a/xen/common/kexec.c
+++ b/xen/common/kexec.c
@@ -1213,7 +1213,7 @@ static int kexec_status(XEN_GUEST_HANDLE_PARAM(void) uarg)
     return !!test_bit(bit, &kexec_flags);
 }
 
-static int do_kexec_op_internal(unsigned long op,
+static int do_kexec_op_internal(unsigned int op,
                                 XEN_GUEST_HANDLE_PARAM(void) uarg,
                                 bool_t compat)
 {
@@ -1265,13 +1265,13 @@ static int do_kexec_op_internal(unsigned long op,
     return ret;
 }
 
-long do_kexec_op(unsigned long op, XEN_GUEST_HANDLE_PARAM(void) uarg)
+long do_kexec_op(unsigned int op, XEN_GUEST_HANDLE_PARAM(void) uarg)
 {
     return do_kexec_op_internal(op, uarg, 0);
 }
 
 #ifdef CONFIG_COMPAT
-int compat_kexec_op(unsigned long op, XEN_GUEST_HANDLE_PARAM(void) uarg)
+int compat_kexec_op(unsigned int op, XEN_GUEST_HANDLE_PARAM(void) uarg)
 {
     return do_kexec_op_internal(op, uarg, 1);
 }
diff --git a/xen/include/asm-arm/hypercall.h b/xen/include/asm-arm/hypercall.h
index 9fd13c6b2c..cadafd76c7 100644
--- a/xen/include/asm-arm/hypercall.h
+++ b/xen/include/asm-arm/hypercall.h
@@ -2,7 +2,6 @@
 #define __ASM_ARM_HYPERCALL_H__
 
 #include <public/domctl.h> /* for arch_do_domctl */
-int do_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg);
 
 long subarch_do_domctl(struct xen_domctl *domctl, struct domain *d,
                        XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_domctl);
diff --git a/xen/include/asm-x86/hypercall.h b/xen/include/asm-x86/hypercall.h
index e614f7c78c..9c0981defd 100644
--- a/xen/include/asm-x86/hypercall.h
+++ b/xen/include/asm-x86/hypercall.h
@@ -11,6 +11,8 @@
 #include <public/arch-x86/xen-mca.h> /* for do_mca */
 #include <asm/paging.h>
 
+#define __HYPERVISOR_paging_domctl_cont __HYPERVISOR_arch_1
+
 typedef unsigned long hypercall_fn_t(
     unsigned long, unsigned long, unsigned long,
     unsigned long, unsigned long);
@@ -88,7 +90,7 @@ do_set_debugreg(
     int reg,
     unsigned long value);
 
-extern unsigned long
+extern long
 do_get_debugreg(
     int reg);
 
@@ -102,17 +104,13 @@ do_mca(XEN_GUEST_HANDLE_PARAM(xen_mc_t) u_xen_mc);
 extern long
 do_update_va_mapping(
     unsigned long va,
-    u64 val64,
+    uint64_t val64,
     unsigned long flags);
 
-extern long
-do_physdev_op(
-    int cmd, XEN_GUEST_HANDLE_PARAM(void) arg);
-
 extern long
 do_update_va_mapping_otherdomain(
     unsigned long va,
-    u64 val64,
+    uint64_t val64,
     unsigned long flags,
     domid_t domid);
 
@@ -126,7 +124,7 @@ do_mmuext_op(
 extern long do_callback_op(
     int cmd, XEN_GUEST_HANDLE_PARAM(const_void) arg);
 
-extern unsigned long
+extern long
 do_iret(
     void);
 
@@ -141,16 +139,18 @@ do_set_segment_base(
     unsigned int which,
     unsigned long base);
 
+long do_nmi_op(unsigned int cmd, XEN_GUEST_HANDLE_PARAM(void) arg);
+
+long do_xenpmu_op(unsigned int op,
+                  XEN_GUEST_HANDLE_PARAM(xen_pmu_params_t) arg);
+
+long do_paging_domctl_cont(XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_domctl);
+
 #ifdef CONFIG_COMPAT
 
 #include <compat/arch-x86/xen.h>
 #include <compat/physdev.h>
 
-extern int
-compat_physdev_op(
-    int cmd,
-    XEN_GUEST_HANDLE_PARAM(void) arg);
-
 extern int
 compat_common_vcpu_op(
     int cmd, struct vcpu *v, XEN_GUEST_HANDLE_PARAM(void) arg);
@@ -161,17 +161,14 @@ extern int compat_mmuext_op(
     XEN_GUEST_HANDLE_PARAM(uint) pdone,
     unsigned int foreigndom);
 
-extern int compat_platform_op(
-    XEN_GUEST_HANDLE_PARAM(void) u_xenpf_op);
-
-extern long compat_callback_op(
-    int cmd, XEN_GUEST_HANDLE(void) arg);
+extern int compat_callback_op(
+    int cmd, XEN_GUEST_HANDLE(const_void) arg);
 
 extern int compat_update_va_mapping(
-    unsigned int va, u32 lo, u32 hi, unsigned int flags);
+    unsigned int va, uint32_t lo, uint32_t hi, unsigned int flags);
 
 extern int compat_update_va_mapping_otherdomain(
-    unsigned int va, u32 lo, u32 hi, unsigned int flags, domid_t domid);
+    unsigned int va, uint32_t lo, uint32_t hi, unsigned int flags, domid_t domid);
 
 DEFINE_XEN_GUEST_HANDLE(trap_info_compat_t);
 extern int compat_set_trap_table(XEN_GUEST_HANDLE(trap_info_compat_t) traps);
@@ -180,13 +177,13 @@ extern int compat_set_gdt(
     XEN_GUEST_HANDLE_PARAM(uint) frame_list, unsigned int entries);
 
 extern int compat_update_descriptor(
-    u32 pa_lo, u32 pa_hi, u32 desc_lo, u32 desc_hi);
+    uint32_t pa_lo, uint32_t pa_hi, uint32_t desc_lo, uint32_t desc_hi);
 
-extern unsigned int compat_iret(void);
+extern int compat_iret(void);
 
 extern int compat_nmi_op(unsigned int cmd, XEN_GUEST_HANDLE_PARAM(void) arg);
 
-extern long compat_set_callbacks(
+extern int compat_set_callbacks(
     unsigned long event_selector, unsigned long event_address,
     unsigned long failsafe_selector, unsigned long failsafe_address);
 
diff --git a/xen/include/asm-x86/paging.h b/xen/include/asm-x86/paging.h
index fa22558e2e..f6e8808b0a 100644
--- a/xen/include/asm-x86/paging.h
+++ b/xen/include/asm-x86/paging.h
@@ -236,9 +236,6 @@ int paging_domctl(struct domain *d, struct xen_domctl_shadow_op *sc,
                   XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_domctl,
                   bool_t resuming);
 
-/* Helper hypercall for dealing with continuations. */
-long paging_domctl_continuation(XEN_GUEST_HANDLE_PARAM(xen_domctl_t));
-
 /* Call when destroying a vcpu/domain */
 void paging_vcpu_teardown(struct vcpu *v);
 int paging_teardown(struct domain *d);
diff --git a/xen/include/xen/hypercall.h b/xen/include/xen/hypercall.h
index 30558d3c61..8247a7ffc8 100644
--- a/xen/include/xen/hypercall.h
+++ b/xen/include/xen/hypercall.h
@@ -43,7 +43,7 @@ arch_do_sysctl(
 
 extern long
 do_platform_op(
-    XEN_GUEST_HANDLE_PARAM(xen_platform_op_t) u_xenpf_op);
+    XEN_GUEST_HANDLE_PARAM(void) u_xenpf_op);
 
 extern long
 pci_physdev_op(
@@ -114,11 +114,6 @@ common_vcpu_op(int cmd,
     struct vcpu *v,
     XEN_GUEST_HANDLE_PARAM(void) arg);
 
-extern long
-do_nmi_op(
-    unsigned int cmd,
-    XEN_GUEST_HANDLE_PARAM(void) arg);
-
 extern long
 do_hvm_op(
     unsigned long op,
@@ -126,13 +121,15 @@ do_hvm_op(
 
 extern long
 do_kexec_op(
-    unsigned long op,
+    unsigned int op,
     XEN_GUEST_HANDLE_PARAM(void) uarg);
 
 extern long
 do_xsm_op(
     XEN_GUEST_HANDLE_PARAM(void) u_xsm_op);
 
+long do_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg);
+
 #ifdef CONFIG_ARGO
 extern long do_argo_op(
     unsigned int cmd,
@@ -145,9 +142,6 @@ extern long do_argo_op(
 extern long
 do_xenoprof_op(int op, XEN_GUEST_HANDLE_PARAM(void) arg);
 
-extern long
-do_xenpmu_op(unsigned int op, XEN_GUEST_HANDLE_PARAM(xen_pmu_params_t) arg);
-
 extern long
 do_dm_op(
     domid_t domid,
@@ -198,21 +192,25 @@ compat_sched_op(
 
 extern int
 compat_set_timer_op(
-    u32 lo,
-    s32 hi);
+    uint32_t lo,
+    int32_t hi);
 
 extern int compat_xsm_op(
     XEN_GUEST_HANDLE_PARAM(void) op);
 
-extern int compat_kexec_op(unsigned long op, XEN_GUEST_HANDLE_PARAM(void) uarg);
+extern int compat_kexec_op(unsigned int op, XEN_GUEST_HANDLE_PARAM(void) uarg);
 
 DEFINE_XEN_GUEST_HANDLE(multicall_entry_compat_t);
 extern int compat_multicall(
     XEN_GUEST_HANDLE_PARAM(multicall_entry_compat_t) call_list,
     uint32_t nr_calls);
 
+int compat_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg);
+
+int compat_platform_op(XEN_GUEST_HANDLE_PARAM(void) u_xenpf_op);
+
 #ifdef CONFIG_ARGO
-extern long compat_argo_op(
+extern int compat_argo_op(
     unsigned int cmd,
     XEN_GUEST_HANDLE_PARAM(void) arg1,
     XEN_GUEST_HANDLE_PARAM(void) arg2,
-- 
2.26.2



From xen-devel-bounces@lists.xenproject.org Fri Oct 15 12:52:21 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 12:52:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.210482.367419 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbMhA-0002xi-Tu; Fri, 15 Oct 2021 12:52:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 210482.367419; Fri, 15 Oct 2021 12:52:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbMhA-0002xX-Q6; Fri, 15 Oct 2021 12:52:20 +0000
Received: by outflank-mailman (input) for mailman id 210482;
 Fri, 15 Oct 2021 12:52:19 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=esao=PD=suse.com=jgross@srs-us1.protection.inumbo.net>)
 id 1mbMh9-00012o-3X
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 12:52:19 +0000
Received: from smtp-out1.suse.de (unknown [195.135.220.28])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 506ac4c3-e4f4-4da1-9002-e6fb8d9a105d;
 Fri, 15 Oct 2021 12:52:05 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id BA45921A66;
 Fri, 15 Oct 2021 12:52:04 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 8C6F913C1A;
 Fri, 15 Oct 2021 12:52:04 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id 2PAGIXR5aWEYHgAAMHmgww
 (envelope-from <jgross@suse.com>); Fri, 15 Oct 2021 12:52:04 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 506ac4c3-e4f4-4da1-9002-e6fb8d9a105d
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1634302324; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=B6lk/UzkImxz2VrZ7mFHlSSb9Fuu2CXaul/l1ThebeE=;
	b=YLgQen0QlGIqg7538kqmKHDT8vOLkio2D/Za6Dc53kSjRjsNHtKbdU+3/nRnrcZLIakYJS
	JueVI/VU6g8GO3X0xFCGJsf4qjaPSWeKIZUrzFmARDF7DHfhgDaE1RNHHVTKP/qA7rJTpD
	DUas1f/Fe3gRtfFH+1nBgxT1bqh4GQw=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org
Cc: Juergen Gross <jgross@suse.com>,
	Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	Wei Liu <wl@xen.org>
Subject: [PATCH 09/12] xen/x86: don't use hypercall table for calling compat hypercalls
Date: Fri, 15 Oct 2021 14:51:49 +0200
Message-Id: <20211015125152.25198-10-jgross@suse.com>
X-Mailer: git-send-email 2.26.2
In-Reply-To: <20211015125152.25198-1-jgross@suse.com>
References: <20211015125152.25198-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Today the *_op_compat hypercalls call the modern handler functions by
using the entries from the hypercall table. This is resulting in a
not needed indirect function call which can be avoided by using the
correct handler function directly. This is basically a revert of
commit 1252e282311734 ("86/pv: Export pv_hypercall_table[] rather
than working around it in several ways"), which reasoning no longer
applies, as shim no longer modifies the hypercall table.

The hypercall table can now be made static as there is no external
reference to it any longer.

Commit 834cb8761051f7 ("x86/PV32: fix physdev_op_compat handling")
can be reverted, too, as using the direct call of the correct handler
is already handled fine without that patch.

Signed-off-by: Juergen Gross <jgross@suse.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
---
 xen/arch/x86/compat.c           | 14 ++++----------
 xen/arch/x86/pv/hypercall.c     |  9 ++++++++-
 xen/arch/x86/x86_64/compat.c    |  1 -
 xen/include/asm-x86/hypercall.h |  8 --------
 4 files changed, 12 insertions(+), 20 deletions(-)

diff --git a/xen/arch/x86/compat.c b/xen/arch/x86/compat.c
index 58b202f701..939b449dec 100644
--- a/xen/arch/x86/compat.c
+++ b/xen/arch/x86/compat.c
@@ -17,14 +17,12 @@ typedef long ret_t;
 /* Legacy hypercall (as of 0x00030202). */
 ret_t do_physdev_op_compat(XEN_GUEST_HANDLE_PARAM(physdev_op_t) uop)
 {
-    typeof(do_physdev_op) *fn =
-        (void *)pv_hypercall_table[__HYPERVISOR_physdev_op].native;
     struct physdev_op op;
 
     if ( unlikely(copy_from_guest(&op, uop, 1) != 0) )
         return -EFAULT;
 
-    return fn(op.cmd, guest_handle_from_ptr(&uop.p->u, void));
+    return do_physdev_op(op.cmd, guest_handle_from_ptr(&uop.p->u, void));
 }
 
 #ifndef COMPAT
@@ -32,14 +30,11 @@ ret_t do_physdev_op_compat(XEN_GUEST_HANDLE_PARAM(physdev_op_t) uop)
 /* Legacy hypercall (as of 0x00030101). */
 long do_sched_op_compat(int cmd, unsigned long arg)
 {
-    typeof(do_sched_op) *fn =
-        (void *)pv_hypercall_table[__HYPERVISOR_sched_op].native;
-
     switch ( cmd )
     {
     case SCHEDOP_yield:
     case SCHEDOP_block:
-        return fn(cmd, guest_handle_from_ptr(NULL, void));
+        return do_sched_op(cmd, guest_handle_from_ptr(NULL, void));
 
     case SCHEDOP_shutdown:
         TRACE_3D(TRC_SCHED_SHUTDOWN,
@@ -57,8 +52,6 @@ long do_sched_op_compat(int cmd, unsigned long arg)
 /* Legacy hypercall (as of 0x00030202). */
 long do_event_channel_op_compat(XEN_GUEST_HANDLE_PARAM(evtchn_op_t) uop)
 {
-    typeof(do_event_channel_op) *fn =
-        (void *)pv_hypercall_table[__HYPERVISOR_event_channel_op].native;
     struct evtchn_op op;
 
     if ( unlikely(copy_from_guest(&op, uop, 1) != 0) )
@@ -76,7 +69,8 @@ long do_event_channel_op_compat(XEN_GUEST_HANDLE_PARAM(evtchn_op_t) uop)
     case EVTCHNOP_bind_ipi:
     case EVTCHNOP_bind_vcpu:
     case EVTCHNOP_unmask:
-        return fn(op.cmd, guest_handle_from_ptr(&uop.p->u, void));
+        return do_event_channel_op(op.cmd,
+                                   guest_handle_from_ptr(&uop.p->u, void));
 
     default:
         return -ENOSYS;
diff --git a/xen/arch/x86/pv/hypercall.c b/xen/arch/x86/pv/hypercall.c
index 7e99dbda34..6c4a32d2a6 100644
--- a/xen/arch/x86/pv/hypercall.c
+++ b/xen/arch/x86/pv/hypercall.c
@@ -27,6 +27,13 @@
 #include <asm/multicall.h>
 #include <irq_vectors.h>
 
+typedef struct {
+    hypercall_fn_t *native;
+#ifdef CONFIG_PV32
+    hypercall_fn_t *compat;
+#endif
+} pv_hypercall_table_t;
+
 #ifdef CONFIG_PV32
 #define HYPERCALL(x)                                                \
     [ __HYPERVISOR_ ## x ] = { (hypercall_fn_t *) do_ ## x,         \
@@ -40,7 +47,7 @@
 #define COMPAT_CALL(x) HYPERCALL(x)
 #endif
 
-const pv_hypercall_table_t pv_hypercall_table[] = {
+static const pv_hypercall_table_t pv_hypercall_table[] = {
     COMPAT_CALL(set_trap_table),
     HYPERCALL(mmu_update),
     COMPAT_CALL(set_gdt),
diff --git a/xen/arch/x86/x86_64/compat.c b/xen/arch/x86/x86_64/compat.c
index fcbc1cc0d7..0e4c71f2aa 100644
--- a/xen/arch/x86/x86_64/compat.c
+++ b/xen/arch/x86/x86_64/compat.c
@@ -12,7 +12,6 @@ EMIT_FILE;
 #define physdev_op_t                  physdev_op_compat_t
 #define do_physdev_op                 compat_physdev_op
 #define do_physdev_op_compat(x)       compat_physdev_op_compat(_##x)
-#define native                        compat
 
 #define COMPAT
 #define _XEN_GUEST_HANDLE(t) XEN_GUEST_HANDLE(t)
diff --git a/xen/include/asm-x86/hypercall.h b/xen/include/asm-x86/hypercall.h
index 2547572ccd..eb2907b5b6 100644
--- a/xen/include/asm-x86/hypercall.h
+++ b/xen/include/asm-x86/hypercall.h
@@ -21,13 +21,6 @@ typedef unsigned long hypercall_fn_t(
     unsigned long, unsigned long, unsigned long,
     unsigned long, unsigned long);
 
-typedef struct {
-    hypercall_fn_t *native;
-#ifdef CONFIG_PV32
-    hypercall_fn_t *compat;
-#endif
-} pv_hypercall_table_t;
-
 typedef struct {
     uint8_t native;
 #ifdef CONFIG_COMPAT
@@ -38,7 +31,6 @@ typedef struct {
 extern const hypercall_args_t hypercall_args_table[NR_hypercalls];
 
 #ifdef CONFIG_PV
-extern const pv_hypercall_table_t pv_hypercall_table[];
 void pv_hypercall(struct cpu_user_regs *regs);
 #endif
 
-- 
2.26.2



From xen-devel-bounces@lists.xenproject.org Fri Oct 15 12:52:23 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 12:52:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.210483.367430 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbMhD-0003No-Bh; Fri, 15 Oct 2021 12:52:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 210483.367430; Fri, 15 Oct 2021 12:52:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbMhD-0003NV-4M; Fri, 15 Oct 2021 12:52:23 +0000
Received: by outflank-mailman (input) for mailman id 210483;
 Fri, 15 Oct 2021 12:52:22 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=esao=PD=suse.com=jgross@srs-us1.protection.inumbo.net>)
 id 1mbMhB-0001If-US
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 12:52:21 +0000
Received: from smtp-out1.suse.de (unknown [195.135.220.28])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id b2375fda-2db6-11ec-8235-12813bfff9fa;
 Fri, 15 Oct 2021 12:52:04 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 9A7E521A65;
 Fri, 15 Oct 2021 12:52:03 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 55E5D13C1A;
 Fri, 15 Oct 2021 12:52:03 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id yK2yE3N5aWEYHgAAMHmgww
 (envelope-from <jgross@suse.com>); Fri, 15 Oct 2021 12:52:03 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b2375fda-2db6-11ec-8235-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1634302323; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=4nXxOzt62hZYydtbxBcv+M/6K4pNHLA4Ij2qiyCNUF4=;
	b=KXVebXrOU98sR4pUlx5xaVOYYF8bF21RXx1WLmyrHfeurxf+e2+WeKh6p8NGHjwpbyVVaI
	uVigH23xX3T7q9hSzP+TiDMQJcZfuUVznt2tA1+ft5SIj6UrZc+fbGOBUg0r90fuYiqyVq
	T7nmFgwre0iv1FIMGV8zd2Y0YiwIO+0=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org
Cc: Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Ian Jackson <iwj@xenproject.org>,
	Jan Beulich <jbeulich@suse.com>,
	Wei Liu <wl@xen.org>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>
Subject: [PATCH 05/12] xen: don't include asm/hypercall.h from C sources
Date: Fri, 15 Oct 2021 14:51:45 +0200
Message-Id: <20211015125152.25198-6-jgross@suse.com>
X-Mailer: git-send-email 2.26.2
In-Reply-To: <20211015125152.25198-1-jgross@suse.com>
References: <20211015125152.25198-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Instead of including asm/hypercall.h always use xen/hypercall.h.
Additionally include xen/hypercall.h from all sources containing a
hypercall handler.

This prepares for generating the handlers' prototypes at build time.

Add a guard in asm/hypercall.h to catch direct inclusion.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 xen/arch/arm/hvm.c                       | 3 +--
 xen/arch/arm/platform_hypercall.c        | 1 +
 xen/arch/x86/cpu/vpmu.c                  | 1 +
 xen/arch/x86/mm.c                        | 1 -
 xen/arch/x86/platform_hypercall.c        | 1 +
 xen/arch/x86/pv/iret.c                   | 1 +
 xen/arch/x86/traps.c                     | 2 +-
 xen/arch/x86/x86_64/compat/mm.c          | 1 +
 xen/arch/x86/x86_64/mm.c                 | 1 -
 xen/arch/x86/x86_64/platform_hypercall.c | 4 ++--
 xen/common/compat/grant_table.c          | 1 +
 xen/common/compat/multicall.c            | 2 +-
 xen/common/event_channel.c               | 1 +
 xen/common/grant_table.c                 | 1 +
 xen/common/multicall.c                   | 1 +
 xen/include/asm-arm/hypercall.h          | 4 ++++
 xen/include/asm-x86/hypercall.h          | 4 ++++
 17 files changed, 22 insertions(+), 8 deletions(-)

diff --git a/xen/arch/arm/hvm.c b/xen/arch/arm/hvm.c
index 8951b34086..fc1a52767d 100644
--- a/xen/arch/arm/hvm.c
+++ b/xen/arch/arm/hvm.c
@@ -20,6 +20,7 @@
 #include <xen/lib.h>
 #include <xen/errno.h>
 #include <xen/guest_access.h>
+#include <xen/hypercall.h>
 #include <xen/sched.h>
 #include <xen/monitor.h>
 
@@ -29,8 +30,6 @@
 #include <public/hvm/params.h>
 #include <public/hvm/hvm_op.h>
 
-#include <asm/hypercall.h>
-
 static int hvm_allow_set_param(const struct domain *d, unsigned int param)
 {
     switch ( param )
diff --git a/xen/arch/arm/platform_hypercall.c b/xen/arch/arm/platform_hypercall.c
index 0013b99202..6ede3b508c 100644
--- a/xen/arch/arm/platform_hypercall.c
+++ b/xen/arch/arm/platform_hypercall.c
@@ -9,6 +9,7 @@
 #include <xen/types.h>
 #include <xen/sched.h>
 #include <xen/guest_access.h>
+#include <xen/hypercall.h>
 #include <xen/spinlock.h>
 #include <public/platform.h>
 #include <xsm/xsm.h>
diff --git a/xen/arch/x86/cpu/vpmu.c b/xen/arch/x86/cpu/vpmu.c
index 16e91a3694..6784f1bc2b 100644
--- a/xen/arch/x86/cpu/vpmu.c
+++ b/xen/arch/x86/cpu/vpmu.c
@@ -21,6 +21,7 @@
 #include <xen/xenoprof.h>
 #include <xen/event.h>
 #include <xen/guest_access.h>
+#include <xen/hypercall.h>
 #include <xen/cpu.h>
 #include <xen/param.h>
 #include <asm/regs.h>
diff --git a/xen/arch/x86/mm.c b/xen/arch/x86/mm.c
index 4d799032dc..8df4539b7e 100644
--- a/xen/arch/x86/mm.c
+++ b/xen/arch/x86/mm.c
@@ -129,7 +129,6 @@
 #include <asm/ldt.h>
 #include <asm/x86_emulate.h>
 #include <asm/e820.h>
-#include <asm/hypercall.h>
 #include <asm/shared.h>
 #include <asm/mem_sharing.h>
 #include <public/memory.h>
diff --git a/xen/arch/x86/platform_hypercall.c b/xen/arch/x86/platform_hypercall.c
index 681e0eb6c6..639fd8f959 100644
--- a/xen/arch/x86/platform_hypercall.c
+++ b/xen/arch/x86/platform_hypercall.c
@@ -17,6 +17,7 @@
 #include <xen/console.h>
 #include <xen/iocap.h>
 #include <xen/guest_access.h>
+#include <xen/hypercall.h>
 #include <xen/acpi.h>
 #include <xen/efi.h>
 #include <xen/cpu.h>
diff --git a/xen/arch/x86/pv/iret.c b/xen/arch/x86/pv/iret.c
index 90946c4629..316a23e77e 100644
--- a/xen/arch/x86/pv/iret.c
+++ b/xen/arch/x86/pv/iret.c
@@ -18,6 +18,7 @@
  */
 
 #include <xen/guest_access.h>
+#include <xen/hypercall.h>
 #include <xen/lib.h>
 #include <xen/sched.h>
 
diff --git a/xen/arch/x86/traps.c b/xen/arch/x86/traps.c
index 64f3396f20..05acbb8479 100644
--- a/xen/arch/x86/traps.c
+++ b/xen/arch/x86/traps.c
@@ -29,6 +29,7 @@
 #include <xen/lib.h>
 #include <xen/err.h>
 #include <xen/errno.h>
+#include <xen/hypercall.h>
 #include <xen/mm.h>
 #include <xen/param.h>
 #include <xen/console.h>
@@ -70,7 +71,6 @@
 #include <asm/x86_emulate.h>
 #include <asm/traps.h>
 #include <asm/hvm/vpt.h>
-#include <asm/hypercall.h>
 #include <asm/mce.h>
 #include <asm/apic.h>
 #include <asm/mc146818rtc.h>
diff --git a/xen/arch/x86/x86_64/compat/mm.c b/xen/arch/x86/x86_64/compat/mm.c
index 215e96aba0..13dfa94fee 100644
--- a/xen/arch/x86/x86_64/compat/mm.c
+++ b/xen/arch/x86/x86_64/compat/mm.c
@@ -1,4 +1,5 @@
 #include <xen/event.h>
+#include <xen/hypercall.h>
 #include <xen/mem_access.h>
 #include <xen/multicall.h>
 #include <compat/memory.h>
diff --git a/xen/arch/x86/x86_64/mm.c b/xen/arch/x86/x86_64/mm.c
index 4f225da81e..fdcb75c78f 100644
--- a/xen/arch/x86/x86_64/mm.c
+++ b/xen/arch/x86/x86_64/mm.c
@@ -32,7 +32,6 @@ EMIT_FILE;
 #include <asm/page.h>
 #include <asm/flushtlb.h>
 #include <asm/fixmap.h>
-#include <asm/hypercall.h>
 #include <asm/msr.h>
 #include <asm/pv/domain.h>
 #include <asm/setup.h>
diff --git a/xen/arch/x86/x86_64/platform_hypercall.c b/xen/arch/x86/x86_64/platform_hypercall.c
index 4576c014a4..1368be455f 100644
--- a/xen/arch/x86/x86_64/platform_hypercall.c
+++ b/xen/arch/x86/x86_64/platform_hypercall.c
@@ -41,8 +41,8 @@ CHECK_pf_resource_entry;
 #undef xen_pf_resource_entry
 
 #define COMPAT
-#define _XEN_GUEST_HANDLE(t) XEN_GUEST_HANDLE(t)
-#define _XEN_GUEST_HANDLE_PARAM(t) XEN_GUEST_HANDLE_PARAM(t)
+#undef guest_handle_okay
+#define guest_handle_okay          compat_handle_okay
 typedef int ret_t;
 
 #include "../platform_hypercall.c"
diff --git a/xen/common/compat/grant_table.c b/xen/common/compat/grant_table.c
index ff1d678f01..8077771508 100644
--- a/xen/common/compat/grant_table.c
+++ b/xen/common/compat/grant_table.c
@@ -4,6 +4,7 @@
  */
 
 #include <compat/grant_table.h>
+#include <xen/hypercall.h>
 
 #define xen_grant_entry_v1 grant_entry_v1
 CHECK_grant_entry_v1;
diff --git a/xen/common/compat/multicall.c b/xen/common/compat/multicall.c
index a0e9918f48..c5982baf76 100644
--- a/xen/common/compat/multicall.c
+++ b/xen/common/compat/multicall.c
@@ -4,6 +4,7 @@
 
 EMIT_FILE;
 
+#include <xen/hypercall.h>
 #include <xen/types.h>
 #include <xen/multicall.h>
 #include <xen/trace.h>
@@ -19,7 +20,6 @@ static inline void xlat_multicall_entry(struct mc_state *mcs)
         mcs->compat_call.args[i] = mcs->call.args[i];
 }
 
-DEFINE_XEN_GUEST_HANDLE(multicall_entry_compat_t);
 #define multicall_entry      compat_multicall_entry
 #define multicall_entry_t    multicall_entry_compat_t
 #define do_multicall_call    compat_multicall_call
diff --git a/xen/common/event_channel.c b/xen/common/event_channel.c
index da88ad141a..12006f592e 100644
--- a/xen/common/event_channel.c
+++ b/xen/common/event_channel.c
@@ -24,6 +24,7 @@
 #include <xen/iocap.h>
 #include <xen/compat.h>
 #include <xen/guest_access.h>
+#include <xen/hypercall.h>
 #include <xen/keyhandler.h>
 #include <asm/current.h>
 
diff --git a/xen/common/grant_table.c b/xen/common/grant_table.c
index e510395d08..49e12621ac 100644
--- a/xen/common/grant_table.c
+++ b/xen/common/grant_table.c
@@ -33,6 +33,7 @@
 #include <xen/trace.h>
 #include <xen/grant_table.h>
 #include <xen/guest_access.h>
+#include <xen/hypercall.h>
 #include <xen/domain_page.h>
 #include <xen/iommu.h>
 #include <xen/paging.h>
diff --git a/xen/common/multicall.c b/xen/common/multicall.c
index 5a199ebf8f..7b20717c88 100644
--- a/xen/common/multicall.c
+++ b/xen/common/multicall.c
@@ -9,6 +9,7 @@
 #include <xen/event.h>
 #include <xen/multicall.h>
 #include <xen/guest_access.h>
+#include <xen/hypercall.h>
 #include <xen/perfc.h>
 #include <xen/trace.h>
 #include <asm/current.h>
diff --git a/xen/include/asm-arm/hypercall.h b/xen/include/asm-arm/hypercall.h
index cadafd76c7..ccd26c5184 100644
--- a/xen/include/asm-arm/hypercall.h
+++ b/xen/include/asm-arm/hypercall.h
@@ -1,3 +1,7 @@
+#ifndef __XEN_HYPERCALL_H__
+#error "asm/hypercall.h should not be included directly - include xen/hypercall.h instead"
+#endif
+
 #ifndef __ASM_ARM_HYPERCALL_H__
 #define __ASM_ARM_HYPERCALL_H__
 
diff --git a/xen/include/asm-x86/hypercall.h b/xen/include/asm-x86/hypercall.h
index 9c0981defd..efe5963ee5 100644
--- a/xen/include/asm-x86/hypercall.h
+++ b/xen/include/asm-x86/hypercall.h
@@ -2,6 +2,10 @@
  * asm-x86/hypercall.h
  */
 
+#ifndef __XEN_HYPERCALL_H__
+#error "asm/hypercall.h should not be included directly - include xen/hypercall.h instead"
+#endif
+
 #ifndef __ASM_X86_HYPERCALL_H__
 #define __ASM_X86_HYPERCALL_H__
 
-- 
2.26.2



From xen-devel-bounces@lists.xenproject.org Fri Oct 15 12:52:26 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 12:52:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.210484.367441 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbMhF-0003ti-SY; Fri, 15 Oct 2021 12:52:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 210484.367441; Fri, 15 Oct 2021 12:52:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbMhF-0003se-Jq; Fri, 15 Oct 2021 12:52:25 +0000
Received: by outflank-mailman (input) for mailman id 210484;
 Fri, 15 Oct 2021 12:52:24 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=esao=PD=suse.com=jgross@srs-us1.protection.inumbo.net>)
 id 1mbMhE-00012o-3r
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 12:52:24 +0000
Received: from smtp-out1.suse.de (unknown [195.135.220.28])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 7384eba4-6dd3-4a31-8f37-ead6aba339fd;
 Fri, 15 Oct 2021 12:52:05 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id EDBEC21A67;
 Fri, 15 Oct 2021 12:52:04 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id C1B6413C1A;
 Fri, 15 Oct 2021 12:52:04 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id yIMXLnR5aWEYHgAAMHmgww
 (envelope-from <jgross@suse.com>); Fri, 15 Oct 2021 12:52:04 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7384eba4-6dd3-4a31-8f37-ead6aba339fd
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1634302324; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=YbzgjhMjFz2fWHYnyWUY/M+bimSV/pLOA+XqwH3l3Aw=;
	b=LdLDqd87d31wjMIlDA/zNFkeruGrcTmVrnV+BCNHuHI4dimTIAW7T11JHvgWiWQk7JoeZL
	rfjWSzYm6wV9dxZm66VoZO6rSxcagw1GFzU6KVVf7Xeehrl3zJ7+MKjaP4UetgN21Q7Szh
	5rEMjOcg4Ke/Q+6iP36bkQgU3OgGJrs=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org
Cc: Juergen Gross <jgross@suse.com>,
	Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	Wei Liu <wl@xen.org>
Subject: [PATCH 10/12] xen/x86: call hypercall handlers via switch statement
Date: Fri, 15 Oct 2021 14:51:50 +0200
Message-Id: <20211015125152.25198-11-jgross@suse.com>
X-Mailer: git-send-email 2.26.2
In-Reply-To: <20211015125152.25198-1-jgross@suse.com>
References: <20211015125152.25198-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Instead of using a function table use the generated switch statement
macros for calling the appropriate hypercall handlers.

This is beneficial to performance and avoids speculation issues.

With calling the handlers using the correct number of parameters now
it is possible to do the parameter register clobbering in the NDEBUG
case after returning from the handler. This in turn removes the only
users of hypercall_args_table[] which can be removed now.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 xen/arch/x86/hvm/hypercall.c    | 144 +++----------------------
 xen/arch/x86/hypercall.c        |  59 -----------
 xen/arch/x86/pv/hypercall.c     | 180 +++-----------------------------
 xen/include/asm-x86/hypercall.h |  43 +++++---
 4 files changed, 60 insertions(+), 366 deletions(-)

diff --git a/xen/arch/x86/hvm/hypercall.c b/xen/arch/x86/hvm/hypercall.c
index 85b7a33523..e766cf4c72 100644
--- a/xen/arch/x86/hvm/hypercall.c
+++ b/xen/arch/x86/hvm/hypercall.c
@@ -108,56 +108,10 @@ long hvm_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
         return compat_physdev_op(cmd, arg);
 }
 
-#define HYPERCALL(x)                                         \
-    [ __HYPERVISOR_ ## x ] = { (hypercall_fn_t *) do_ ## x,  \
-                               (hypercall_fn_t *) do_ ## x }
-
-#define HVM_CALL(x)                                          \
-    [ __HYPERVISOR_ ## x ] = { (hypercall_fn_t *) hvm_ ## x, \
-                               (hypercall_fn_t *) hvm_ ## x }
-
-#define COMPAT_CALL(x)                                       \
-    [ __HYPERVISOR_ ## x ] = { (hypercall_fn_t *) do_ ## x,  \
-                               (hypercall_fn_t *) compat_ ## x }
-
-static const struct {
-    hypercall_fn_t *native, *compat;
-} hvm_hypercall_table[] = {
-    HVM_CALL(memory_op),
-    COMPAT_CALL(multicall),
-#ifdef CONFIG_GRANT_TABLE
-    HVM_CALL(grant_table_op),
-#endif
-    HYPERCALL(vm_assist),
-    COMPAT_CALL(vcpu_op),
-    HVM_CALL(physdev_op),
-    COMPAT_CALL(xen_version),
-    HYPERCALL(console_io),
-    HYPERCALL(event_channel_op),
-    COMPAT_CALL(sched_op),
-    COMPAT_CALL(set_timer_op),
-    COMPAT_CALL(xsm_op),
-    HYPERCALL(hvm_op),
-    HYPERCALL(sysctl),
-    HYPERCALL(domctl),
-#ifdef CONFIG_ARGO
-    COMPAT_CALL(argo_op),
-#endif
-    COMPAT_CALL(platform_op),
-#ifdef CONFIG_PV
-    COMPAT_CALL(mmuext_op),
-#endif
-    HYPERCALL(xenpmu_op),
-    COMPAT_CALL(dm_op),
-#ifdef CONFIG_HYPFS
-    HYPERCALL(hypfs_op),
+#ifndef NDEBUG
+static unsigned char hypercall_args_64[] = hypercall_args_hvm64;
+static unsigned char hypercall_args_32[] = hypercall_args_hvm32;
 #endif
-    HYPERCALL(paging_domctl_cont)
-};
-
-#undef HYPERCALL
-#undef HVM_CALL
-#undef COMPAT_CALL
 
 int hvm_hypercall(struct cpu_user_regs *regs)
 {
@@ -203,23 +157,6 @@ int hvm_hypercall(struct cpu_user_regs *regs)
         return ret;
     }
 
-    BUILD_BUG_ON(ARRAY_SIZE(hvm_hypercall_table) >
-                 ARRAY_SIZE(hypercall_args_table));
-
-    if ( eax >= ARRAY_SIZE(hvm_hypercall_table) )
-    {
-        regs->rax = -ENOSYS;
-        return HVM_HCALL_completed;
-    }
-
-    eax = array_index_nospec(eax, ARRAY_SIZE(hvm_hypercall_table));
-
-    if ( !hvm_hypercall_table[eax].native )
-    {
-        regs->rax = -ENOSYS;
-        return HVM_HCALL_completed;
-    }
-
     /*
      * Caching is intended for instruction emulation only. Disable it
      * for any accesses by hypercall argument copy-in / copy-out.
@@ -239,33 +176,11 @@ int hvm_hypercall(struct cpu_user_regs *regs)
         HVM_DBG_LOG(DBG_LEVEL_HCALL, "hcall%lu(%lx, %lx, %lx, %lx, %lx)",
                     eax, rdi, rsi, rdx, r10, r8);
 
-#ifndef NDEBUG
-        /* Deliberately corrupt parameter regs not used by this hypercall. */
-        switch ( hypercall_args_table[eax].native )
-        {
-        case 0: rdi = 0xdeadbeefdeadf00dUL; fallthrough;
-        case 1: rsi = 0xdeadbeefdeadf00dUL; fallthrough;
-        case 2: rdx = 0xdeadbeefdeadf00dUL; fallthrough;
-        case 3: r10 = 0xdeadbeefdeadf00dUL; fallthrough;
-        case 4: r8 = 0xdeadbeefdeadf00dUL;
-        }
-#endif
-
-        regs->rax = hvm_hypercall_table[eax].native(rdi, rsi, rdx, r10, r8);
+        call_handlers_hvm64(eax, regs->rax, rdi, rsi, rdx, r10, r8);
 
 #ifndef NDEBUG
-        if ( !curr->hcall_preempted )
-        {
-            /* Deliberately corrupt parameter regs used by this hypercall. */
-            switch ( hypercall_args_table[eax].native )
-            {
-            case 5: regs->r8  = 0xdeadbeefdeadf00dUL; fallthrough;
-            case 4: regs->r10 = 0xdeadbeefdeadf00dUL; fallthrough;
-            case 3: regs->rdx = 0xdeadbeefdeadf00dUL; fallthrough;
-            case 2: regs->rsi = 0xdeadbeefdeadf00dUL; fallthrough;
-            case 1: regs->rdi = 0xdeadbeefdeadf00dUL;
-            }
-        }
+        if ( !curr->hcall_preempted && regs->rax != -ENOSYS )
+            clobber_regs(regs, hypercall_args_64[eax]);
 #endif
     }
     else
@@ -279,35 +194,13 @@ int hvm_hypercall(struct cpu_user_regs *regs)
         HVM_DBG_LOG(DBG_LEVEL_HCALL, "hcall%lu(%x, %x, %x, %x, %x)", eax,
                     ebx, ecx, edx, esi, edi);
 
-#ifndef NDEBUG
-        /* Deliberately corrupt parameter regs not used by this hypercall. */
-        switch ( hypercall_args_table[eax].compat )
-        {
-        case 0: ebx = 0xdeadf00d; fallthrough;
-        case 1: ecx = 0xdeadf00d; fallthrough;
-        case 2: edx = 0xdeadf00d; fallthrough;
-        case 3: esi = 0xdeadf00d; fallthrough;
-        case 4: edi = 0xdeadf00d;
-        }
-#endif
-
         curr->hcall_compat = true;
-        regs->eax = hvm_hypercall_table[eax].compat(ebx, ecx, edx, esi, edi);
+        call_handlers_hvm32(eax, regs->eax, ebx, ecx, edx, esi, edi);
         curr->hcall_compat = false;
 
 #ifndef NDEBUG
-        if ( !curr->hcall_preempted )
-        {
-            /* Deliberately corrupt parameter regs used by this hypercall. */
-            switch ( hypercall_args_table[eax].compat )
-            {
-            case 5: regs->rdi = 0xdeadf00d; fallthrough;
-            case 4: regs->rsi = 0xdeadf00d; fallthrough;
-            case 3: regs->rdx = 0xdeadf00d; fallthrough;
-            case 2: regs->rcx = 0xdeadf00d; fallthrough;
-            case 1: regs->rbx = 0xdeadf00d;
-            }
-        }
+        if ( !curr->hcall_preempted && regs->eax != -ENOSYS )
+            clobber_regs32(regs, hypercall_args_32[eax]);
 #endif
     }
 
@@ -327,31 +220,20 @@ int hvm_hypercall(struct cpu_user_regs *regs)
 enum mc_disposition hvm_do_multicall_call(struct mc_state *state)
 {
     struct vcpu *curr = current;
-    hypercall_fn_t *func = NULL;
 
     if ( hvm_guest_x86_mode(curr) == 8 )
     {
         struct multicall_entry *call = &state->call;
 
-        if ( call->op < ARRAY_SIZE(hvm_hypercall_table) )
-            func = array_access_nospec(hvm_hypercall_table, call->op).native;
-        if ( func )
-            call->result = func(call->args[0], call->args[1], call->args[2],
-                                call->args[3], call->args[4]);
-        else
-            call->result = -ENOSYS;
+        call_handlers_hvm64(call->op, call->result, call->args[0], call->args[1],
+                            call->args[2], call->args[3], call->args[4]);
     }
     else
     {
         struct compat_multicall_entry *call = &state->compat_call;
 
-        if ( call->op < ARRAY_SIZE(hvm_hypercall_table) )
-            func = array_access_nospec(hvm_hypercall_table, call->op).compat;
-        if ( func )
-            call->result = func(call->args[0], call->args[1], call->args[2],
-                                call->args[3], call->args[4]);
-        else
-            call->result = -ENOSYS;
+        call_handlers_hvm32(call->op, call->result, call->args[0], call->args[1],
+                            call->args[2], call->args[3], call->args[4]);
     }
 
     return !hvm_get_cpl(curr) ? mc_continue : mc_preempt;
diff --git a/xen/arch/x86/hypercall.c b/xen/arch/x86/hypercall.c
index 07e1a45ef5..6b73cff9b9 100644
--- a/xen/arch/x86/hypercall.c
+++ b/xen/arch/x86/hypercall.c
@@ -22,65 +22,6 @@
 #include <xen/hypercall.h>
 #include <asm/multicall.h>
 
-#ifdef CONFIG_COMPAT
-#define ARGS(x, n)                              \
-    [ __HYPERVISOR_ ## x ] = { n, n }
-#define COMP(x, n, c)                           \
-    [ __HYPERVISOR_ ## x ] = { n, c }
-#else
-#define ARGS(x, n)    [ __HYPERVISOR_ ## x ] = { n }
-#define COMP(x, n, c) ARGS(x, n)
-#endif
-
-const hypercall_args_t hypercall_args_table[NR_hypercalls] =
-{
-    ARGS(set_trap_table, 1),
-    ARGS(mmu_update, 4),
-    ARGS(set_gdt, 2),
-    ARGS(stack_switch, 2),
-    COMP(set_callbacks, 3, 4),
-    ARGS(fpu_taskswitch, 1),
-    ARGS(sched_op_compat, 2),
-    ARGS(platform_op, 1),
-    ARGS(set_debugreg, 2),
-    ARGS(get_debugreg, 1),
-    COMP(update_descriptor, 2, 4),
-    ARGS(memory_op, 2),
-    ARGS(multicall, 2),
-    COMP(update_va_mapping, 3, 4),
-    COMP(set_timer_op, 1, 2),
-    ARGS(event_channel_op_compat, 1),
-    ARGS(xen_version, 2),
-    ARGS(console_io, 3),
-    ARGS(physdev_op_compat, 1),
-    ARGS(grant_table_op, 3),
-    ARGS(vm_assist, 2),
-    COMP(update_va_mapping_otherdomain, 4, 5),
-    ARGS(vcpu_op, 3),
-    COMP(set_segment_base, 2, 0),
-    ARGS(mmuext_op, 4),
-    ARGS(xsm_op, 1),
-    ARGS(nmi_op, 2),
-    ARGS(sched_op, 2),
-    ARGS(callback_op, 2),
-    ARGS(xenoprof_op, 2),
-    ARGS(event_channel_op, 2),
-    ARGS(physdev_op, 2),
-    ARGS(sysctl, 1),
-    ARGS(domctl, 1),
-    ARGS(kexec_op, 2),
-    ARGS(argo_op, 5),
-    ARGS(xenpmu_op, 2),
-    ARGS(hvm_op, 2),
-    ARGS(dm_op, 3),
-    ARGS(hypfs_op, 5),
-    ARGS(mca, 1),
-    ARGS(paging_domctl_cont, 1),
-};
-
-#undef COMP
-#undef ARGS
-
 #define NEXT_ARG(fmt, args)                                                 \
 ({                                                                          \
     unsigned long __arg;                                                    \
diff --git a/xen/arch/x86/pv/hypercall.c b/xen/arch/x86/pv/hypercall.c
index 6c4a32d2a6..9b575e5c0b 100644
--- a/xen/arch/x86/pv/hypercall.c
+++ b/xen/arch/x86/pv/hypercall.c
@@ -27,119 +27,22 @@
 #include <asm/multicall.h>
 #include <irq_vectors.h>
 
-typedef struct {
-    hypercall_fn_t *native;
-#ifdef CONFIG_PV32
-    hypercall_fn_t *compat;
-#endif
-} pv_hypercall_table_t;
-
+#ifndef NDEBUG
+static unsigned char hypercall_args_64[] = hypercall_args_pv64;
 #ifdef CONFIG_PV32
-#define HYPERCALL(x)                                                \
-    [ __HYPERVISOR_ ## x ] = { (hypercall_fn_t *) do_ ## x,         \
-                               (hypercall_fn_t *) do_ ## x }
-#define COMPAT_CALL(x)                                              \
-    [ __HYPERVISOR_ ## x ] = { (hypercall_fn_t *) do_ ## x,         \
-                               (hypercall_fn_t *) compat_ ## x }
-#else
-#define HYPERCALL(x)                                                \
-    [ __HYPERVISOR_ ## x ] = { (hypercall_fn_t *) do_ ## x }
-#define COMPAT_CALL(x) HYPERCALL(x)
-#endif
-
-static const pv_hypercall_table_t pv_hypercall_table[] = {
-    COMPAT_CALL(set_trap_table),
-    HYPERCALL(mmu_update),
-    COMPAT_CALL(set_gdt),
-    HYPERCALL(stack_switch),
-    COMPAT_CALL(set_callbacks),
-    HYPERCALL(fpu_taskswitch),
-    HYPERCALL(sched_op_compat),
-#ifndef CONFIG_PV_SHIM_EXCLUSIVE
-    COMPAT_CALL(platform_op),
-#endif
-    HYPERCALL(set_debugreg),
-    HYPERCALL(get_debugreg),
-    COMPAT_CALL(update_descriptor),
-    COMPAT_CALL(memory_op),
-    COMPAT_CALL(multicall),
-    COMPAT_CALL(update_va_mapping),
-    COMPAT_CALL(set_timer_op),
-    HYPERCALL(event_channel_op_compat),
-    COMPAT_CALL(xen_version),
-    HYPERCALL(console_io),
-    COMPAT_CALL(physdev_op_compat),
-#ifdef CONFIG_GRANT_TABLE
-    COMPAT_CALL(grant_table_op),
-#endif
-    HYPERCALL(vm_assist),
-    COMPAT_CALL(update_va_mapping_otherdomain),
-    COMPAT_CALL(iret),
-    COMPAT_CALL(vcpu_op),
-    HYPERCALL(set_segment_base),
-    COMPAT_CALL(mmuext_op),
-    COMPAT_CALL(xsm_op),
-    COMPAT_CALL(nmi_op),
-    COMPAT_CALL(sched_op),
-    COMPAT_CALL(callback_op),
-#ifdef CONFIG_XENOPROF
-    COMPAT_CALL(xenoprof_op),
-#endif
-    HYPERCALL(event_channel_op),
-    COMPAT_CALL(physdev_op),
-#ifndef CONFIG_PV_SHIM_EXCLUSIVE
-    HYPERCALL(sysctl),
-    HYPERCALL(domctl),
+static unsigned char hypercall_args_32[] = hypercall_args_pv32;
 #endif
-#ifdef CONFIG_KEXEC
-    COMPAT_CALL(kexec_op),
 #endif
-#ifdef CONFIG_ARGO
-    COMPAT_CALL(argo_op),
-#endif
-    HYPERCALL(xenpmu_op),
-#ifdef CONFIG_HVM
-    HYPERCALL(hvm_op),
-    COMPAT_CALL(dm_op),
-#endif
-#ifdef CONFIG_HYPFS
-    HYPERCALL(hypfs_op),
-#endif
-    HYPERCALL(mca),
-#ifndef CONFIG_PV_SHIM_EXCLUSIVE
-    HYPERCALL(paging_domctl_cont),
-#endif
-};
-
-#undef COMPAT_CALL
-#undef HYPERCALL
 
 /* Forced inline to cause 'compat' to be evaluated at compile time. */
 static void always_inline
 _pv_hypercall(struct cpu_user_regs *regs, bool compat)
 {
     struct vcpu *curr = current;
-    unsigned long eax = compat ? regs->eax : regs->rax;
+    unsigned long eax;
 
     ASSERT(guest_kernel_mode(curr, regs));
 
-    BUILD_BUG_ON(ARRAY_SIZE(pv_hypercall_table) >
-                 ARRAY_SIZE(hypercall_args_table));
-
-    if ( eax >= ARRAY_SIZE(pv_hypercall_table) )
-    {
-        regs->rax = -ENOSYS;
-        return;
-    }
-
-    eax = array_index_nospec(eax, ARRAY_SIZE(pv_hypercall_table));
-
-    if ( !pv_hypercall_table[eax].native )
-    {
-        regs->rax = -ENOSYS;
-        return;
-    }
-
     curr->hcall_preempted = false;
 
     if ( !compat )
@@ -150,17 +53,8 @@ _pv_hypercall(struct cpu_user_regs *regs, bool compat)
         unsigned long r10 = regs->r10;
         unsigned long r8 = regs->r8;
 
-#ifndef NDEBUG
-        /* Deliberately corrupt parameter regs not used by this hypercall. */
-        switch ( hypercall_args_table[eax].native )
-        {
-        case 0: rdi = 0xdeadbeefdeadf00dUL; fallthrough;
-        case 1: rsi = 0xdeadbeefdeadf00dUL; fallthrough;
-        case 2: rdx = 0xdeadbeefdeadf00dUL; fallthrough;
-        case 3: r10 = 0xdeadbeefdeadf00dUL; fallthrough;
-        case 4: r8 = 0xdeadbeefdeadf00dUL;
-        }
-#endif
+        eax = regs->rax;
+
         if ( unlikely(tb_init_done) )
         {
             unsigned long args[5] = { rdi, rsi, rdx, r10, r8 };
@@ -168,21 +62,11 @@ _pv_hypercall(struct cpu_user_regs *regs, bool compat)
             __trace_hypercall(TRC_PV_HYPERCALL_V2, eax, args);
         }
 
-        regs->rax = pv_hypercall_table[eax].native(rdi, rsi, rdx, r10, r8);
+        call_handlers_pv64(eax, regs->rax, rdi, rsi, rdx, r10, r8);
 
 #ifndef NDEBUG
-        if ( !curr->hcall_preempted )
-        {
-            /* Deliberately corrupt parameter regs used by this hypercall. */
-            switch ( hypercall_args_table[eax].native )
-            {
-            case 5: regs->r8  = 0xdeadbeefdeadf00dUL; fallthrough;
-            case 4: regs->r10 = 0xdeadbeefdeadf00dUL; fallthrough;
-            case 3: regs->rdx = 0xdeadbeefdeadf00dUL; fallthrough;
-            case 2: regs->rsi = 0xdeadbeefdeadf00dUL; fallthrough;
-            case 1: regs->rdi = 0xdeadbeefdeadf00dUL;
-            }
-        }
+        if ( !curr->hcall_preempted && regs->rax != -ENOSYS )
+            clobber_regs(regs, hypercall_args_64[eax]);
 #endif
     }
 #ifdef CONFIG_PV32
@@ -194,17 +78,7 @@ _pv_hypercall(struct cpu_user_regs *regs, bool compat)
         unsigned int esi = regs->esi;
         unsigned int edi = regs->edi;
 
-#ifndef NDEBUG
-        /* Deliberately corrupt parameter regs not used by this hypercall. */
-        switch ( hypercall_args_table[eax].compat )
-        {
-        case 0: ebx = 0xdeadf00d; fallthrough;
-        case 1: ecx = 0xdeadf00d; fallthrough;
-        case 2: edx = 0xdeadf00d; fallthrough;
-        case 3: esi = 0xdeadf00d; fallthrough;
-        case 4: edi = 0xdeadf00d;
-        }
-#endif
+        eax = regs->eax;
 
         if ( unlikely(tb_init_done) )
         {
@@ -214,22 +88,12 @@ _pv_hypercall(struct cpu_user_regs *regs, bool compat)
         }
 
         curr->hcall_compat = true;
-        regs->eax = pv_hypercall_table[eax].compat(ebx, ecx, edx, esi, edi);
+        call_handlers_pv32(eax, regs->eax, ebx, ecx, edx, esi, edi);
         curr->hcall_compat = false;
 
 #ifndef NDEBUG
-        if ( !curr->hcall_preempted )
-        {
-            /* Deliberately corrupt parameter regs used by this hypercall. */
-            switch ( hypercall_args_table[eax].compat )
-            {
-            case 5: regs->edi = 0xdeadf00d; fallthrough;
-            case 4: regs->esi = 0xdeadf00d; fallthrough;
-            case 3: regs->edx = 0xdeadf00d; fallthrough;
-            case 2: regs->ecx = 0xdeadf00d; fallthrough;
-            case 1: regs->ebx = 0xdeadf00d;
-            }
-        }
+        if ( !curr->hcall_preempted && regs->eax != -ENOSYS )
+            clobber_regs32(regs, hypercall_args_32[eax]);
 #endif
     }
 #endif /* CONFIG_PV32 */
@@ -256,13 +120,8 @@ enum mc_disposition pv_do_multicall_call(struct mc_state *state)
         struct compat_multicall_entry *call = &state->compat_call;
 
         op = call->op;
-        if ( (op < ARRAY_SIZE(pv_hypercall_table)) &&
-             pv_hypercall_table[op].compat )
-            call->result = pv_hypercall_table[op].compat(
-                call->args[0], call->args[1], call->args[2],
-                call->args[3], call->args[4]);
-        else
-            call->result = -ENOSYS;
+        call_handlers_pv32(op, call->result, call->args[0], call->args[1],
+                           call->args[2], call->args[3], call->args[4]);
     }
     else
 #endif
@@ -270,13 +129,8 @@ enum mc_disposition pv_do_multicall_call(struct mc_state *state)
         struct multicall_entry *call = &state->call;
 
         op = call->op;
-        if ( (op < ARRAY_SIZE(pv_hypercall_table)) &&
-             pv_hypercall_table[op].native )
-            call->result = pv_hypercall_table[op].native(
-                call->args[0], call->args[1], call->args[2],
-                call->args[3], call->args[4]);
-        else
-            call->result = -ENOSYS;
+        call_handlers_pv64(op, call->result, call->args[0], call->args[1],
+                           call->args[2], call->args[3], call->args[4]);
     }
 
     return unlikely(op == __HYPERVISOR_iret)
diff --git a/xen/include/asm-x86/hypercall.h b/xen/include/asm-x86/hypercall.h
index eb2907b5b6..f2db3f3c21 100644
--- a/xen/include/asm-x86/hypercall.h
+++ b/xen/include/asm-x86/hypercall.h
@@ -17,19 +17,6 @@
 
 #define __HYPERVISOR_paging_domctl_cont __HYPERVISOR_arch_1
 
-typedef unsigned long hypercall_fn_t(
-    unsigned long, unsigned long, unsigned long,
-    unsigned long, unsigned long);
-
-typedef struct {
-    uint8_t native;
-#ifdef CONFIG_COMPAT
-    uint8_t compat;
-#endif
-} hypercall_args_t;
-
-extern const hypercall_args_t hypercall_args_table[NR_hypercalls];
-
 #ifdef CONFIG_PV
 void pv_hypercall(struct cpu_user_regs *regs);
 #endif
@@ -55,4 +42,34 @@ compat_common_vcpu_op(
 
 #endif /* CONFIG_COMPAT */
 
+#ifndef NDEBUG
+static inline void clobber_regs(struct cpu_user_regs *regs,
+                                unsigned int nargs)
+{
+    /* Deliberately corrupt used parameter regs. */
+    switch ( nargs )
+    {
+    case 5: regs->r8  = 0xdeadbeefdeadf00dUL; fallthrough;
+    case 4: regs->r10 = 0xdeadbeefdeadf00dUL; fallthrough;
+    case 3: regs->rdx = 0xdeadbeefdeadf00dUL; fallthrough;
+    case 2: regs->rsi = 0xdeadbeefdeadf00dUL; fallthrough;
+    case 1: regs->rdi = 0xdeadbeefdeadf00dUL;
+    }
+}
+
+static inline void clobber_regs32(struct cpu_user_regs *regs,
+                                  unsigned int nargs)
+{
+    /* Deliberately corrupt used parameter regs. */
+    switch ( nargs )
+    {
+    case 5: regs->edi = 0xdeadf00dUL; fallthrough;
+    case 4: regs->esi = 0xdeadf00dUL; fallthrough;
+    case 3: regs->edx = 0xdeadf00dUL; fallthrough;
+    case 2: regs->ecx = 0xdeadf00dUL; fallthrough;
+    case 1: regs->ebx = 0xdeadf00dUL;
+    }
+}
+#endif
+
 #endif /* __ASM_X86_HYPERCALL_H__ */
-- 
2.26.2



From xen-devel-bounces@lists.xenproject.org Fri Oct 15 12:52:28 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 12:52:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.210488.367452 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbMhI-0004Nb-L1; Fri, 15 Oct 2021 12:52:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 210488.367452; Fri, 15 Oct 2021 12:52:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbMhI-0004Mk-Bb; Fri, 15 Oct 2021 12:52:28 +0000
Received: by outflank-mailman (input) for mailman id 210488;
 Fri, 15 Oct 2021 12:52:27 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=esao=PD=suse.com=jgross@srs-us1.protection.inumbo.net>)
 id 1mbMhG-0001If-Uc
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 12:52:26 +0000
Received: from smtp-out2.suse.de (unknown [195.135.220.29])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id b2375fdd-2db6-11ec-8235-12813bfff9fa;
 Fri, 15 Oct 2021 12:52:05 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 4B8A01FD50;
 Fri, 15 Oct 2021 12:52:04 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id EB18113C1A;
 Fri, 15 Oct 2021 12:52:03 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id oA48OHN5aWEYHgAAMHmgww
 (envelope-from <jgross@suse.com>); Fri, 15 Oct 2021 12:52:03 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b2375fdd-2db6-11ec-8235-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1634302324; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=9PRIFBYfDAkDfF9JUnG+6Qyh2bCaAakz0Z0+rRDQ7n8=;
	b=fB+c2faxHuKx6rMVi51l0BNcKFEfpdBQnKRQQHYAzP32lZRkb8Cw2T4Oq1cXY83PlHCMmm
	P6U8A2LTRA42tB0OHHM7vRCl5ijHZDmsnTaQoHRgQQWzPhguCyqbDhFo50+nrOWKXt2fuN
	6eQQBp+YCt4tjhOm9VdH1tGehS1HCBU=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org
Cc: Juergen Gross <jgross@suse.com>,
	Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	Wei Liu <wl@xen.org>,
	George Dunlap <george.dunlap@citrix.com>,
	Ian Jackson <iwj@xenproject.org>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>
Subject: [PATCH 07/12] xen: use generated prototypes for hypercall handlers
Date: Fri, 15 Oct 2021 14:51:47 +0200
Message-Id: <20211015125152.25198-8-jgross@suse.com>
X-Mailer: git-send-email 2.26.2
In-Reply-To: <20211015125152.25198-1-jgross@suse.com>
References: <20211015125152.25198-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Remove the hypercall handler's prototypes in the related header files
and use the generated ones instead.

Some handlers having been static before need to be made globally
visible.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 xen/arch/x86/hvm/hypercall.c    |   6 +-
 xen/include/asm-x86/hypercall.h | 133 ------------------------
 xen/include/xen/hypercall.h     | 177 +-------------------------------
 3 files changed, 5 insertions(+), 311 deletions(-)

diff --git a/xen/arch/x86/hvm/hypercall.c b/xen/arch/x86/hvm/hypercall.c
index 9d3b193bad..85b7a33523 100644
--- a/xen/arch/x86/hvm/hypercall.c
+++ b/xen/arch/x86/hvm/hypercall.c
@@ -31,7 +31,7 @@
 #include <public/hvm/hvm_op.h>
 #include <public/hvm/params.h>
 
-static long hvm_memory_op(unsigned long cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
+long hvm_memory_op(unsigned long cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
 {
     long rc;
 
@@ -51,7 +51,7 @@ static long hvm_memory_op(unsigned long cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
 }
 
 #ifdef CONFIG_GRANT_TABLE
-static long hvm_grant_table_op(
+long hvm_grant_table_op(
     unsigned int cmd, XEN_GUEST_HANDLE_PARAM(void) uop, unsigned int count)
 {
     switch ( cmd )
@@ -77,7 +77,7 @@ static long hvm_grant_table_op(
 }
 #endif
 
-static long hvm_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
+long hvm_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
 {
     const struct vcpu *curr = current;
     const struct domain *currd = curr->domain;
diff --git a/xen/include/asm-x86/hypercall.h b/xen/include/asm-x86/hypercall.h
index efe5963ee5..2547572ccd 100644
--- a/xen/include/asm-x86/hypercall.h
+++ b/xen/include/asm-x86/hypercall.h
@@ -52,104 +52,6 @@ void pv_ring3_init_hypercall_page(void *ptr);
  */
 #define MMU_UPDATE_PREEMPTED          (~(~0U>>1))
 
-extern long
-do_event_channel_op_compat(
-    XEN_GUEST_HANDLE_PARAM(evtchn_op_t) uop);
-
-/* Legacy hypercall (as of 0x00030202). */
-extern long do_physdev_op_compat(
-    XEN_GUEST_HANDLE(physdev_op_t) uop);
-
-/* Legacy hypercall (as of 0x00030101). */
-extern long do_sched_op_compat(
-    int cmd, unsigned long arg);
-
-extern long
-do_set_trap_table(
-    XEN_GUEST_HANDLE_PARAM(const_trap_info_t) traps);
-
-extern long
-do_mmu_update(
-    XEN_GUEST_HANDLE_PARAM(mmu_update_t) ureqs,
-    unsigned int count,
-    XEN_GUEST_HANDLE_PARAM(uint) pdone,
-    unsigned int foreigndom);
-
-extern long
-do_set_gdt(
-    XEN_GUEST_HANDLE_PARAM(xen_ulong_t) frame_list,
-    unsigned int entries);
-
-extern long
-do_stack_switch(
-    unsigned long ss,
-    unsigned long esp);
-
-extern long
-do_fpu_taskswitch(
-    int set);
-
-extern long
-do_set_debugreg(
-    int reg,
-    unsigned long value);
-
-extern long
-do_get_debugreg(
-    int reg);
-
-extern long
-do_update_descriptor(
-    uint64_t gaddr, seg_desc_t desc);
-
-extern long
-do_mca(XEN_GUEST_HANDLE_PARAM(xen_mc_t) u_xen_mc);
-
-extern long
-do_update_va_mapping(
-    unsigned long va,
-    uint64_t val64,
-    unsigned long flags);
-
-extern long
-do_update_va_mapping_otherdomain(
-    unsigned long va,
-    uint64_t val64,
-    unsigned long flags,
-    domid_t domid);
-
-extern long
-do_mmuext_op(
-    XEN_GUEST_HANDLE_PARAM(mmuext_op_t) uops,
-    unsigned int count,
-    XEN_GUEST_HANDLE_PARAM(uint) pdone,
-    unsigned int foreigndom);
-
-extern long do_callback_op(
-    int cmd, XEN_GUEST_HANDLE_PARAM(const_void) arg);
-
-extern long
-do_iret(
-    void);
-
-extern long
-do_set_callbacks(
-    unsigned long event_address,
-    unsigned long failsafe_address,
-    unsigned long syscall_address);
-
-extern long
-do_set_segment_base(
-    unsigned int which,
-    unsigned long base);
-
-long do_nmi_op(unsigned int cmd, XEN_GUEST_HANDLE_PARAM(void) arg);
-
-long do_xenpmu_op(unsigned int op,
-                  XEN_GUEST_HANDLE_PARAM(xen_pmu_params_t) arg);
-
-long do_paging_domctl_cont(XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_domctl);
-
 #ifdef CONFIG_COMPAT
 
 #include <compat/arch-x86/xen.h>
@@ -159,41 +61,6 @@ extern int
 compat_common_vcpu_op(
     int cmd, struct vcpu *v, XEN_GUEST_HANDLE_PARAM(void) arg);
 
-extern int compat_mmuext_op(
-    XEN_GUEST_HANDLE_PARAM(void) arg,
-    unsigned int count,
-    XEN_GUEST_HANDLE_PARAM(uint) pdone,
-    unsigned int foreigndom);
-
-extern int compat_callback_op(
-    int cmd, XEN_GUEST_HANDLE(const_void) arg);
-
-extern int compat_update_va_mapping(
-    unsigned int va, uint32_t lo, uint32_t hi, unsigned int flags);
-
-extern int compat_update_va_mapping_otherdomain(
-    unsigned int va, uint32_t lo, uint32_t hi, unsigned int flags, domid_t domid);
-
-DEFINE_XEN_GUEST_HANDLE(trap_info_compat_t);
-extern int compat_set_trap_table(XEN_GUEST_HANDLE(trap_info_compat_t) traps);
-
-extern int compat_set_gdt(
-    XEN_GUEST_HANDLE_PARAM(uint) frame_list, unsigned int entries);
-
-extern int compat_update_descriptor(
-    uint32_t pa_lo, uint32_t pa_hi, uint32_t desc_lo, uint32_t desc_hi);
-
-extern int compat_iret(void);
-
-extern int compat_nmi_op(unsigned int cmd, XEN_GUEST_HANDLE_PARAM(void) arg);
-
-extern int compat_set_callbacks(
-    unsigned long event_selector, unsigned long event_address,
-    unsigned long failsafe_selector, unsigned long failsafe_address);
-
-DEFINE_XEN_GUEST_HANDLE(physdev_op_compat_t);
-extern int compat_physdev_op_compat(XEN_GUEST_HANDLE(physdev_op_compat_t) uop);
-
 #endif /* CONFIG_COMPAT */
 
 #endif /* __ASM_X86_HYPERCALL_H__ */
diff --git a/xen/include/xen/hypercall.h b/xen/include/xen/hypercall.h
index 8247a7ffc8..cf6a3c463d 100644
--- a/xen/include/xen/hypercall.h
+++ b/xen/include/xen/hypercall.h
@@ -18,33 +18,19 @@
 #include <asm/hypercall.h>
 #include <xsm/xsm.h>
 
-extern long
-do_sched_op(
-    int cmd,
-    XEN_GUEST_HANDLE_PARAM(void) arg);
-
-extern long
-do_domctl(
-    XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_domctl);
+/* Needs to be after asm/hypercall.h. */
+#include <xen/hypercall-defs.h>
 
 extern long
 arch_do_domctl(
     struct xen_domctl *domctl, struct domain *d,
     XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_domctl);
 
-extern long
-do_sysctl(
-    XEN_GUEST_HANDLE_PARAM(xen_sysctl_t) u_sysctl);
-
 extern long
 arch_do_sysctl(
     struct xen_sysctl *sysctl,
     XEN_GUEST_HANDLE_PARAM(xen_sysctl_t) u_sysctl);
 
-extern long
-do_platform_op(
-    XEN_GUEST_HANDLE_PARAM(void) u_xenpf_op);
-
 extern long
 pci_physdev_op(
     int cmd, XEN_GUEST_HANDLE_PARAM(void) arg);
@@ -62,170 +48,11 @@ pci_physdev_op(
 #define MEMOP_EXTENT_SHIFT 6 /* cmd[:6] == start_extent */
 #define MEMOP_CMD_MASK     ((1 << MEMOP_EXTENT_SHIFT) - 1)
 
-extern long
-do_memory_op(
-    unsigned long cmd,
-    XEN_GUEST_HANDLE_PARAM(void) arg);
-
-extern long
-do_multicall(
-    XEN_GUEST_HANDLE_PARAM(multicall_entry_t) call_list,
-    unsigned int nr_calls);
-
-extern long
-do_set_timer_op(
-    s_time_t timeout);
-
-extern long
-do_event_channel_op(
-    int cmd, XEN_GUEST_HANDLE_PARAM(void) arg);
-
-extern long
-do_xen_version(
-    int cmd,
-    XEN_GUEST_HANDLE_PARAM(void) arg);
-
-extern long
-do_console_io(
-    unsigned int cmd,
-    unsigned int count,
-    XEN_GUEST_HANDLE_PARAM(char) buffer);
-
-extern long
-do_grant_table_op(
-    unsigned int cmd,
-    XEN_GUEST_HANDLE_PARAM(void) uop,
-    unsigned int count);
-
-extern long
-do_vm_assist(
-    unsigned int cmd,
-    unsigned int type);
-
-extern long
-do_vcpu_op(
-    int cmd,
-    unsigned int vcpuid,
-    XEN_GUEST_HANDLE_PARAM(void) arg);
-
-struct vcpu;
 extern long
 common_vcpu_op(int cmd,
     struct vcpu *v,
     XEN_GUEST_HANDLE_PARAM(void) arg);
 
-extern long
-do_hvm_op(
-    unsigned long op,
-    XEN_GUEST_HANDLE_PARAM(void) arg);
-
-extern long
-do_kexec_op(
-    unsigned int op,
-    XEN_GUEST_HANDLE_PARAM(void) uarg);
-
-extern long
-do_xsm_op(
-    XEN_GUEST_HANDLE_PARAM(void) u_xsm_op);
-
-long do_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg);
-
-#ifdef CONFIG_ARGO
-extern long do_argo_op(
-    unsigned int cmd,
-    XEN_GUEST_HANDLE_PARAM(void) arg1,
-    XEN_GUEST_HANDLE_PARAM(void) arg2,
-    unsigned long arg3,
-    unsigned long arg4);
-#endif
-
-extern long
-do_xenoprof_op(int op, XEN_GUEST_HANDLE_PARAM(void) arg);
-
-extern long
-do_dm_op(
-    domid_t domid,
-    unsigned int nr_bufs,
-    XEN_GUEST_HANDLE_PARAM(xen_dm_op_buf_t) bufs);
-
-#ifdef CONFIG_HYPFS
-extern long
-do_hypfs_op(
-    unsigned int cmd,
-    XEN_GUEST_HANDLE_PARAM(const_char) arg1,
-    unsigned long arg2,
-    XEN_GUEST_HANDLE_PARAM(void) arg3,
-    unsigned long arg4);
-#endif
-
-#ifdef CONFIG_COMPAT
-
-extern int
-compat_memory_op(
-    unsigned int cmd,
-    XEN_GUEST_HANDLE_PARAM(void) arg);
-
-extern int
-compat_grant_table_op(
-    unsigned int cmd,
-    XEN_GUEST_HANDLE_PARAM(void) uop,
-    unsigned int count);
-
-extern int
-compat_vcpu_op(
-    int cmd,
-    unsigned int vcpuid,
-    XEN_GUEST_HANDLE_PARAM(void) arg);
-
-extern int
-compat_xenoprof_op(int op, XEN_GUEST_HANDLE_PARAM(void) arg);
-
-extern int
-compat_xen_version(
-    int cmd,
-    XEN_GUEST_HANDLE_PARAM(void) arg);
-
-extern int
-compat_sched_op(
-    int cmd,
-    XEN_GUEST_HANDLE_PARAM(void) arg);
-
-extern int
-compat_set_timer_op(
-    uint32_t lo,
-    int32_t hi);
-
-extern int compat_xsm_op(
-    XEN_GUEST_HANDLE_PARAM(void) op);
-
-extern int compat_kexec_op(unsigned int op, XEN_GUEST_HANDLE_PARAM(void) uarg);
-
-DEFINE_XEN_GUEST_HANDLE(multicall_entry_compat_t);
-extern int compat_multicall(
-    XEN_GUEST_HANDLE_PARAM(multicall_entry_compat_t) call_list,
-    uint32_t nr_calls);
-
-int compat_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg);
-
-int compat_platform_op(XEN_GUEST_HANDLE_PARAM(void) u_xenpf_op);
-
-#ifdef CONFIG_ARGO
-extern int compat_argo_op(
-    unsigned int cmd,
-    XEN_GUEST_HANDLE_PARAM(void) arg1,
-    XEN_GUEST_HANDLE_PARAM(void) arg2,
-    unsigned long arg3,
-    unsigned long arg4);
-#endif
-
-extern int
-compat_dm_op(
-    domid_t domid,
-    unsigned int nr_bufs,
-    XEN_GUEST_HANDLE_PARAM(void) bufs);
-
-#endif
-
 void arch_get_xen_caps(xen_capabilities_info_t *info);
 
 #endif /* __XEN_HYPERCALL_H__ */
-- 
2.26.2



From xen-devel-bounces@lists.xenproject.org Fri Oct 15 12:52:34 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 12:52:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.210491.367463 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbMhN-00058i-Uj; Fri, 15 Oct 2021 12:52:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 210491.367463; Fri, 15 Oct 2021 12:52:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbMhN-00058Q-Pc; Fri, 15 Oct 2021 12:52:33 +0000
Received: by outflank-mailman (input) for mailman id 210491;
 Fri, 15 Oct 2021 12:52:32 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=esao=PD=suse.com=jgross@srs-us1.protection.inumbo.net>)
 id 1mbMhL-0001If-Uv
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 12:52:32 +0000
Received: from smtp-out2.suse.de (unknown [195.135.220.29])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id b25a9f40-2db6-11ec-8235-12813bfff9fa;
 Fri, 15 Oct 2021 12:52:04 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id E44C01FD4F;
 Fri, 15 Oct 2021 12:52:03 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id A0BA013FC3;
 Fri, 15 Oct 2021 12:52:03 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id wJMNJnN5aWEYHgAAMHmgww
 (envelope-from <jgross@suse.com>); Fri, 15 Oct 2021 12:52:03 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b25a9f40-2db6-11ec-8235-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1634302323; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=P67YztJxQ0QrNAgf0tD9vXCGkoISc/gTTj7K0FhcSbo=;
	b=Y45W/NGxmc5UP1jW9ncsepjaV3viGsGwkgWXwwlf5rZ3BzoT9QF67Pn43JLQT6PTGaH8d7
	FQuP9MKRiyuDhE3dae6m8EupxMp7Jg0fOdgrn/zxqGY4if/dm/C84agGTzJ/qQ3D2DVT/g
	7YswDP9sUqULTo3SeleiRM8QM7sLDcU=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org
Cc: Juergen Gross <jgross@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Ian Jackson <iwj@xenproject.org>,
	Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wl@xen.org>
Subject: [PATCH 06/12] xen: generate hypercall interface related code
Date: Fri, 15 Oct 2021 14:51:46 +0200
Message-Id: <20211015125152.25198-7-jgross@suse.com>
X-Mailer: git-send-email 2.26.2
In-Reply-To: <20211015125152.25198-1-jgross@suse.com>
References: <20211015125152.25198-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Instead of repeating similar data multiple times use a single source
file and a generator script for producing prototypes and call sequences
of the hypercalls.

As the script already knows the number of parameters used add generating
a macro for populating an array with the number of parameters per
hypercall.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 .gitignore                    |   2 +
 xen/Makefile                  |  10 ++
 xen/include/hypercall-defs.c  | 272 ++++++++++++++++++++++++++++++++++
 xen/scripts/gen_hypercall.awk | 228 ++++++++++++++++++++++++++++
 4 files changed, 512 insertions(+)
 create mode 100644 xen/include/hypercall-defs.c
 create mode 100644 xen/scripts/gen_hypercall.awk

diff --git a/.gitignore b/.gitignore
index 8ebb51b6c5..0edc014eb7 100644
--- a/.gitignore
+++ b/.gitignore
@@ -332,10 +332,12 @@ xen/include/asm-x86/asm-macros.h
 xen/include/compat/*
 xen/include/config/
 xen/include/generated/
+xen/include//hypercall-defs.i
 xen/include/public/public
 xen/include/xen/*.new
 xen/include/xen/acm_policy.h
 xen/include/xen/compile.h
+xen/include/xen/hypercall-defs.h
 xen/include/xen/lib/x86/cpuid-autogen.h
 xen/test/livepatch/config.h
 xen/test/livepatch/expect_config.h
diff --git a/xen/Makefile b/xen/Makefile
index a3189eb47c..dfdae47e74 100644
--- a/xen/Makefile
+++ b/xen/Makefile
@@ -383,6 +383,7 @@ _clean: delete-unfresh-files
 		-o -name "*.gcno" -o -name ".*.cmd" -o -name "lib.a" \) -exec rm -f {} \;
 	rm -f include/asm $(TARGET) $(TARGET).gz $(TARGET).efi $(TARGET).efi.map $(TARGET)-syms $(TARGET)-syms.map *~ core
 	rm -f asm-offsets.s include/asm-*/asm-offsets.h
+	rm -f include/xen/hypercall-defs.h include/hypercall-defs.i
 	rm -f .banner .allconfig.tmp
 
 .PHONY: _distclean
@@ -405,6 +406,7 @@ $(TARGET): delete-unfresh-files
 	$(MAKE) -f $(BASEDIR)/Rules.mk -C include
 	$(MAKE) -f $(BASEDIR)/Rules.mk -C arch/$(TARGET_ARCH) include
 	$(MAKE) -f $(BASEDIR)/Rules.mk include/asm-$(TARGET_ARCH)/asm-offsets.h
+	$(MAKE) -f $(BASEDIR)/Rules.mk include/xen/hypercall-defs.h
 	$(MAKE) -f $(BASEDIR)/Rules.mk -C arch/$(TARGET_ARCH) $@
 
 # drivers/char/console.o contains static banner/compile info. Blow it away.
@@ -466,6 +468,14 @@ include/asm-$(TARGET_ARCH)/asm-offsets.h: asm-offsets.s
 	  echo ""; \
 	  echo "#endif") <$< >$@
 
+quiet_cmd_genhyp = GEN     $@
+define cmd_genhyp
+    awk -f scripts/gen_hypercall.awk <$< >$@
+endef
+
+include/xen/hypercall-defs.h: include/hypercall-defs.i scripts/gen_hypercall.awk FORCE
+	$(call if_changed,genhyp)
+
 SUBDIRS = xsm arch/$(TARGET_ARCH) common drivers lib test
 define all_sources
     ( find include/asm-$(TARGET_ARCH) -name '*.h' -print; \
diff --git a/xen/include/hypercall-defs.c b/xen/include/hypercall-defs.c
new file mode 100644
index 0000000000..2ddd5ec962
--- /dev/null
+++ b/xen/include/hypercall-defs.c
@@ -0,0 +1,272 @@
+/*
+ * Hypercall interface description:
+ * Used by scripts/gen_hypercall.awk to generate hypercall prototypes and call
+ * sequences.
+ *
+ * Syntax is like a prototype, but without return type and without the ";" at
+ * the end. Pointer types will be automatically converted to use the
+ * XEN_GUEST_HANDLE_PARAM() macro. Handlers with no parameters just use a
+ * definition like "fn()".
+ * Hypercall/function names are without the leading "__HYPERVISOR_"/"do_"
+ * strings.
+ *
+ * The return type of a class of prototypes using the same prefix is set via:
+ * rettype: <prefix> <type>
+ * Default return type is "long". A return type for a prefix can be set only
+ * once and it needs to be set before that prefix is being used via the
+ * "prefix:" directive.
+ *
+ * The prefix of the prototypes is set via a line:
+ * prefix: <prefix> ...
+ * Multiple prefixes are possible (restriction see below). Prefixes are without
+ * a trailing "_". The current prefix settings are active until a new "prefix:"
+ * line.
+ *
+ * Caller macros are suffixed with a selectable name via lines like:
+ * caller: <suffix>
+ * When a caller suffix is active, there is only one active prefix allowed.
+ *
+ * With a "defhandle:" line it is possible to add a DEFINE_XEN_GUEST_HANDLE()
+ * to the generated header:
+ * defhandle: <handle-type> [<type>]
+ * Without specifying <type> only a DEFINE_XEN_GUEST_HANDLE(<handle-type>)
+ * will be generated, otherwise it will be a
+ * __DEFINE_XEN_GUEST_HANDLE(<handle-type>, <type>) being generated. Note that
+ * the latter will include the related "const" handle "const_<handle-type>".
+ *
+ * In order to support using coding style compliant pointers in the
+ * prototypes it is possible to add translation entries to generate the correct
+ * handle types:
+ * handle: <handle-type> <type>
+ * This will result in the prototype translation from "<type> *" to
+ * "XEN_GUEST_HANDLE_PARAM(<handle-type>)".
+ *
+ * The switch() statement bodies will be generated from a final table in the
+ * source file, which is started via the line:
+ * table: <caller> <caller> ...
+ * with the <caller>s specifying the designated caller macro of each column of
+ * the table. Any column of a <caller> not having been set via a "caller:"
+ * line will be ignored.
+ * The first column of the table contains the hypercall/prototype, each
+ * <caller> column contains the prefix for the function to use for that caller.
+ * A column not being supported by a <caller> is marked with "-". Lines with all
+ * entries being "-" after removal of inactive <caller> columns are ignored.
+ *
+ * This file is being preprocessed using $(CPP), so #ifdef CONFIG_* conditionals
+ * are possible.
+ */
+
+#ifdef CONFIG_HVM
+#define PREFIX_hvm hvm
+#else
+#define PREFIX_hvm
+#endif
+
+#ifdef CONFIG_COMPAT
+#define PREFIX_compat compat
+rettype: compat int
+#else
+#define PREFIX_compat
+#endif
+
+#ifdef CONFIG_ARM
+#define PREFIX_dep dep
+#else
+#define PREFIX_dep
+#endif
+
+handle: uint unsigned int
+handle: const_void const void
+handle: const_char const char
+
+#ifdef CONFIG_COMPAT
+defhandle: multicall_entry_compat_t
+#endif
+#ifdef CONFIG_PV32
+defhandle: trap_info_compat_t
+defhandle: physdev_op_compat_t
+#endif
+
+prefix: do PREFIX_hvm PREFIX_compat
+physdev_op(int cmd, void *arg)
+#if defined(CONFIG_GRANT_TABLE) || defined(CONFIG_PV_SHIM)
+grant_table_op(unsigned int cmd, void *uop, unsigned int count)
+#endif
+
+prefix: do PREFIX_hvm
+memory_op(unsigned long cmd, void *arg)
+
+prefix: do PREFIX_compat
+xen_version(int cmd, void *arg)
+vcpu_op(int cmd, unsigned int vcpuid, void *arg)
+sched_op(int cmd, void *arg)
+xsm_op(void *op)
+callback_op(int cmd, const void *arg)
+#ifndef CONFIG_PV_SHIM_EXCLUSIVE
+platform_op(void *u_xenpf_op)
+#endif
+#ifdef CONFIG_ARGO
+argo_op(unsigned int cmd, void *arg1, void *arg2, unsigned long arg3, unsigned long arg4)
+#endif
+#ifdef CONFIG_KEXEC
+kexec_op(unsigned int op, void *uarg)
+#endif
+#ifdef CONFIG_PV
+iret()
+nmi_op(unsigned int cmd, void *arg)
+#ifdef CONFIG_XENOPROF
+xenoprof_op(int op, void *arg)
+#endif
+#endif /* CONFIG_PV */
+
+#ifdef CONFIG_COMPAT
+prefix: compat
+set_timer_op(uint32_t lo, int32_t hi)
+multicall(multicall_entry_compat_t *call_list, uint32_t nr_calls)
+memory_op(unsigned int cmd, void *arg)
+#ifdef CONFIG_IOREQ_SERVER
+dm_op(domid_t domid, unsigned int nr_bufs, void *bufs)
+#endif
+mmuext_op(void *arg, unsigned int count, uint *pdone, unsigned int foreigndom)
+#ifdef CONFIG_PV32
+set_trap_table(trap_info_compat_t *traps)
+set_gdt(unsigned int *frame_list, unsigned int entries)
+set_callbacks(unsigned long event_selector, unsigned long event_address, unsigned long failsafe_selector, unsigned long failsafe_address)
+update_descriptor(uint32_t pa_lo, uint32_t pa_hi, uint32_t desc_lo, uint32_t desc_hi)
+update_va_mapping(unsigned int va, uint32_t lo, uint32_t hi, unsigned int flags)
+physdev_op_compat(physdev_op_compat_t *uop)
+update_va_mapping_otherdomain(unsigned int va, uint32_t lo, uint32_t hi, unsigned int flags, domid_t domid)
+#endif
+#endif /* CONFIG_COMPAT */
+
+#if defined(CONFIG_PV) || defined(CONFIG_ARM)
+prefix: do PREFIX_dep
+event_channel_op_compat(evtchn_op_t *uop)
+physdev_op_compat(physdev_op_t *uop)
+/* Legacy hypercall (as of 0x00030101). */
+sched_op_compat(int cmd, unsigned long arg)
+#endif
+
+prefix: do
+set_timer_op(s_time_t timeout)
+console_io(unsigned int cmd, unsigned int count, char *buffer)
+vm_assist(unsigned int cmd, unsigned int type)
+event_channel_op(int cmd, void *arg)
+mmuext_op(mmuext_op_t *uops, unsigned int count, unsigned int *pdone, unsigned int foreigndom)
+multicall(multicall_entry_t *call_list, unsigned int nr_calls)
+#ifdef CONFIG_PV
+mmu_update(mmu_update_t *ureqs, unsigned int count, unsigned int *pdone, unsigned int foreigndom)
+stack_switch(unsigned long ss, unsigned long esp)
+fpu_taskswitch(int set)
+set_debugreg(int reg, unsigned long value)
+get_debugreg(int reg)
+set_segment_base(unsigned int which, unsigned long base)
+mca(xen_mc_t *u_xen_mc)
+set_trap_table(const_trap_info_t *traps)
+set_gdt(xen_ulong_t *frame_list, unsigned int entries)
+set_callbacks(unsigned long event_address, unsigned long failsafe_address, unsigned long syscall_address)
+update_descriptor(uint64_t gaddr, seg_desc_t desc)
+update_va_mapping(unsigned long va, uint64_t val64, unsigned long flags)
+update_va_mapping_otherdomain(unsigned long va, uint64_t val64, unsigned long flags, domid_t domid)
+#endif
+#ifdef CONFIG_IOREQ_SERVER
+dm_op(domid_t domid, unsigned int nr_bufs, xen_dm_op_buf_t *bufs)
+#endif
+#ifndef CONFIG_PV_SHIM_EXCLUSIVE
+sysctl(xen_sysctl_t *u_sysctl)
+domctl(xen_domctl_t *u_domctl)
+paging_domctl_cont(xen_domctl_t *u_domctl)
+#endif
+#ifdef CONFIG_HVM
+hvm_op(unsigned long op, void *arg)
+#endif
+#ifdef CONFIG_HYPFS
+hypfs_op(unsigned int cmd, const char *arg1, unsigned long arg2, void *arg3, unsigned long arg4)
+#endif
+#ifdef CONFIG_X86
+xenpmu_op(unsigned int op, xen_pmu_params_t *arg)
+#endif
+
+#ifdef CONFIG_PV
+caller: pv64
+#ifdef CONFIG_PV32
+caller: pv32
+#endif
+#endif
+#ifdef CONFIG_HVM
+caller: hvm64
+#ifdef CONFIG_COMPAT
+caller: hvm32
+#endif
+#endif
+#ifdef CONFIG_ARM
+caller: arm
+#endif
+
+table:                             pv32    pv64    hvm32   hvm64   arm
+set_trap_table                     compat  do      -       -       -
+mmu_update                         do      do      -       -       -
+set_gdt                            compat  do      -       -       -
+stack_switch                       do      do      -       -       -
+set_callbacks                      compat  do      -       -       -
+fpu_taskswitch                     do      do      -       -       -
+sched_op_compat                    do      do      -       -       dep
+#ifndef CONFIG_PV_SHIM_EXCLUSIVE
+platform_op                        compat  do      compat  do      do
+#endif
+set_debugreg                       do      do      -       -       -
+get_debugreg                       do      do      -       -       -
+update_descriptor                  compat  do      -       -       -
+memory_op                          compat  do      hvm     hvm     do
+multicall                          compat  do      compat  do      do
+update_va_mapping                  compat  do      -       -       -
+set_timer_op                       compat  do      compat  do      -
+event_channel_op_compat            do      do      -       -       dep
+xen_version                        compat  do      compat  do      do
+console_io                         do      do      do      do      do
+physdev_op_compat                  compat  do      -       -       dep
+#if defined(CONFIG_GRANT_TABLE) || defined(CONFIG_PV_SHIM)
+grant_table_op                     compat  do      hvm     hvm     do
+#endif
+vm_assist                          do      do      do      do      do
+update_va_mapping_otherdomain      compat  do      -       -       -
+iret                               compat  do      -       -       -
+vcpu_op                            compat  do      compat  do      do
+set_segment_base                   do      do      -       -       -
+#ifdef CONFIG_PV
+mmuext_op                          compat  do      compat  do      -
+#endif
+xsm_op                             compat  do      compat  do      do
+nmi_op                             compat  do      -       -       -
+sched_op                           compat  do      compat  do      do
+callback_op                        compat  do      -       -       -
+#ifdef CONFIG_XENOPROF
+xenoprof_op                        compat  do      -       -       -
+#endif
+event_channel_op                   do      do      do      do      do
+physdev_op                         compat  do      hvm     hvm     do
+#ifdef CONFIG_HVM
+hvm_op                             do      do      do      do      do
+#endif
+#ifndef CONFIG_PV_SHIM_EXCLUSIVE
+sysctl                             do      do      do      do      do
+domctl                             do      do      do      do      do
+#endif
+#ifdef CONFIG_KEXEC
+kexec_op                           compat  do      -       -       -
+#endif
+tmem_op                            -       -       -       -       -
+#ifdef CONFIG_ARGO
+argo_op                            compat  do      compat  do      do
+#endif
+xenpmu_op                          do      do      do      do      -
+#ifdef CONFIG_IOREQ_SERVER
+dm_op                              compat  do      compat  do      do
+#endif
+#ifdef CONFIG_HYPFS
+hypfs_op                           do      do      do      do      do
+#endif
+mca                                do      do      -       -       -
+#ifndef CONFIG_PV_SHIM_EXCLUSIVE
+paging_domctl_cont                 do      do      do      do      -
+#endif
diff --git a/xen/scripts/gen_hypercall.awk b/xen/scripts/gen_hypercall.awk
new file mode 100644
index 0000000000..50d4cdbfcd
--- /dev/null
+++ b/xen/scripts/gen_hypercall.awk
@@ -0,0 +1,228 @@
+# awk script to generate hypercall handler prototypes and a macro for doing
+# the calls of the handlers inside a switch() statement.
+
+BEGIN {
+    printf("/* Generated file, do not edit! */\n\n");
+    e = 0;
+    n = 0;
+    p = 0;
+    nc = 0;
+}
+
+# Issue error to stderr
+function do_err(msg) {
+    print "Error: "msg": "$0 >"/dev/stderr";
+    exit 1;
+}
+
+# Generate case statement for call
+function do_call(f, p,    i) {
+    printf("    case __HYPERVISOR_%s: \\\n", fn[f]);
+    printf("        ret = %s_%s(", pre[f, p], fn[f]);
+    for (i = 1; i <= n_args[f]; i++) {
+        if (i > 1)
+            printf(", ");
+        if (ptr[f, i])
+            printf("(XEN_GUEST_HANDLE_PARAM(%s)){ _p(a%d) }", typ[f, i], i);
+        else
+            printf("(%s)(a%d)", typ[f, i], i);
+    }
+    printf("); \\\n");
+    printf("        break; \\\n");
+}
+
+function rest_of_line(par,    i, val) {
+    val = $(par);
+    for (i = par + 1; i <= NF; i++)
+        val = val " " $(i);
+    return val;
+}
+
+# Handle comments (multi- and single line)
+$1 == "/*" {
+    comment = 1;
+}
+comment == 1 {
+    if ($(NF) == "*/") comment = 0;
+    next;
+}
+
+# Skip preprocessing artefacts
+$1 == "extern" {
+    next;
+}
+/^#/ {
+    next;
+}
+
+# Drop empty lines
+NF == 0 {
+    next;
+}
+
+# Handle "handle:" line
+$1 == "handle:" {
+    if (NF < 3)
+        do_err("\"handle:\" requires at least two parameters");
+    val = rest_of_line(3);
+    xlate[val] = $2;
+    next;
+}
+
+# Handle "defhandle:" line
+$1 == "defhandle:" {
+    if (NF < 2)
+        do_err("\"defhandle:\" requires at least one parameter");
+    e++;
+    if (NF == 2) {
+        emit[e] = sprintf("DEFINE_XEN_GUEST_HANDLE(%s);", $2);
+    } else {
+        val = rest_of_line(3);
+        emit[e] = sprintf("__DEFINE_XEN_GUEST_HANDLE(%s, %s);", $2, val);
+        xlate[val] = $2;
+    }
+    next;
+}
+
+# Handle "rettype:" line
+$1 == "rettype:" {
+    if (NF < 3)
+        do_err("\"rettype:\" requires at least two parameters");
+    if ($2 in rettype)
+        do_err("rettype can be set only once for each prefix");
+    rettype[$2] = rest_of_line(3);
+    next;
+}
+
+# Handle "caller:" line
+$1 == "caller:" {
+    caller[$2] = 1;
+    next;
+}
+
+# Handle "prefix:" line
+$1 == "prefix:" {
+    p = NF - 1;
+    for (i = 2; i <= NF; i++) {
+        prefix[i - 1] = $(i);
+        if (!(prefix[i - 1] in rettype))
+            rettype[prefix[i - 1]] = "long";
+    }
+    next;
+}
+
+# Handle "table:" line
+$1 == "table:" {
+    table = 1;
+    for (i = 2; i <= NF; i++)
+        col[i - 1] = $(i);
+    n_cols = NF - 1;
+    next;
+}
+
+# Handle table definition line
+table == 1 {
+    if (NF != n_cols + 1)
+        do_err("Table definition line has wrong number of fields");
+    for (c = 1; c <= n_cols; c++) {
+        if (caller[col[c]] != 1)
+            continue;
+        if ($(c + 1) == "-")
+            continue;
+        for (i = 1; i <= n; i++) {
+            if (fn[i] != $1)
+                continue;
+            for (j = 1; j <= n_pre[i]; j++) {
+                if (pre[i, j] == $(c + 1)) {
+                    nc++;
+                    call[nc] = col[c];
+                    call_fn[nc] = i;
+                    call_p[nc] = j;
+                }
+            }
+        }
+    }
+    next;
+}
+
+# Prototype line
+{
+    bro = index($0, "(");
+    brc = index($0, ")");
+    if (bro < 2 || brc < bro)
+        do_err("No valid prototype line");
+    n++;
+    fn[n] = substr($0, 1, bro - 1);
+    n_pre[n] = p;
+    for (i = 1; i <= p; i++)
+        pre[n, i] = prefix[i];
+    args = substr($0, bro + 1, brc - bro - 1);
+    n_args[n] = split(args, a, ",");
+    if (n_args[n] > 5)
+        do_err("Too many parameters");
+    for (i = 1; i <= n_args[n]; i++) {
+        sub("^ *", "", a[i]);         # Remove leading white space
+        sub(" +", " ", a[i]);         # Replace multiple spaces with single ones
+        sub(" *$", "", a[i]);         # Remove trailing white space
+        ptr[n, i] = index(a[i], "*"); # Is it a pointer type?
+        sub("[*]", "", a[i]);         # Remove "*"
+        if (index(a[i], " ") == 0)
+            do_err("Parameter with no type or no name");
+        typ[n, i] = a[i];
+        sub(" [^ ]+$", "", typ[n, i]);    # Remove parameter name
+        if (ptr[n, i] && (typ[n, i] in xlate))
+            typ[n, i] = xlate[typ[n, i]];
+        arg[n, i] = a[i];
+        sub("^([^ ]+ )+", "", arg[n, i]); # Remove parameter type
+    }
+}
+
+# Generate the output
+END {
+    # Verbatim generated lines
+    for (i = 1; i <= e; i++)
+        printf("%s\n", emit[i]);
+    printf("\n");
+    # Generate prototypes
+    for (i = 1; i <= n; i++) {
+        for (p = 1; p <= n_pre[i]; p++) {
+            printf("%s %s_%s(", rettype[pre[i, p]], pre[i, p], fn[i]);
+            if (n_args[i] == 0)
+                printf("void");
+            else
+                for (j = 1; j <= n_args[i]; j++) {
+                    if (j > 1)
+                        printf(", ");
+                    if (ptr[i, j])
+                        printf("XEN_GUEST_HANDLE_PARAM(%s)", typ[i, j]);
+                    else
+                        printf("%s", typ[i, j]);
+                    printf(" %s", arg[i, j]);
+                }
+            printf(");\n");
+        }
+    }
+    # Generate call sequences and args array contents
+    for (ca in caller) {
+        if (caller[ca] != 1)
+            continue;
+        printf("\n");
+        printf("#define call_handlers_%s(num, ret, a1, a2, a3, a4, a5) \\\n", ca);
+        printf("    switch ( num ) \\\n");
+        printf("    { \\\n");
+        for (i = 1; i <= nc; i++)
+            if (call[i] == ca)
+                do_call(call_fn[i], call_p[i]);
+        printf("    default: \\\n");
+        printf("        ret = -ENOSYS; \\\n");
+        printf("        break; \\\n");
+        printf("    }\n");
+        printf("\n");
+        printf("#define hypercall_args_%s \\\n", ca);
+        printf("{ \\\n");
+        for (i = 1; i <= nc; i++)
+            if (call[i] == ca)
+                printf("[__HYPERVISOR_%s] = %d, \\\n", fn[call_fn[i]], n_args[call_fn[i]]);
+        printf("}\n");
+    }
+}
-- 
2.26.2



From xen-devel-bounces@lists.xenproject.org Fri Oct 15 12:52:38 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 12:52:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.210499.367474 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbMhS-0005yI-KG; Fri, 15 Oct 2021 12:52:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 210499.367474; Fri, 15 Oct 2021 12:52:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbMhS-0005xs-F5; Fri, 15 Oct 2021 12:52:38 +0000
Received: by outflank-mailman (input) for mailman id 210499;
 Fri, 15 Oct 2021 12:52:37 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=esao=PD=suse.com=jgross@srs-us1.protection.inumbo.net>)
 id 1mbMhQ-0001If-Ut
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 12:52:36 +0000
Received: from smtp-out2.suse.de (unknown [195.135.220.29])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id b314408a-2db6-11ec-8235-12813bfff9fa;
 Fri, 15 Oct 2021 12:52:06 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 275E31FD54;
 Fri, 15 Oct 2021 12:52:05 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 0069413C1A;
 Fri, 15 Oct 2021 12:52:04 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id wNBwOnR5aWEYHgAAMHmgww
 (envelope-from <jgross@suse.com>); Fri, 15 Oct 2021 12:52:04 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b314408a-2db6-11ec-8235-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1634302325; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=m18kDFVS7Ui84LXyYHOs/zs7ME9jIsMa1CgETT/9pcY=;
	b=Yi8D1dldW4eTmpN9WAVUDw7STYwyGoMmOzz3DSsuM3hrbSLzmdFO1GOi4WMGFjF2haZ6LE
	hcNr9KDxAzt3IwAwlVC+ZWgXIuDfTYTKFFmQ2A+ypIoU3Ds+iESH/HqsDr+VjLDWqlRKGP
	kHA5SjjaGuhO6vaj1yC+5CFfrID29GE=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org
Cc: Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: [PATCH 11/12] xen/arm: call hypercall handlers via switch statement
Date: Fri, 15 Oct 2021 14:51:51 +0200
Message-Id: <20211015125152.25198-12-jgross@suse.com>
X-Mailer: git-send-email 2.26.2
In-Reply-To: <20211015125152.25198-1-jgross@suse.com>
References: <20211015125152.25198-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Instead of using a function table use the generated switch statement
macros for calling the appropriate hypercall handlers.

This makes the calls of the handlers type safe.

For deprecated hypercalls define stub functions.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 xen/arch/arm/traps.c | 119 ++++++++++---------------------------------
 1 file changed, 26 insertions(+), 93 deletions(-)

diff --git a/xen/arch/arm/traps.c b/xen/arch/arm/traps.c
index 7abc28848e..72e914030f 100644
--- a/xen/arch/arm/traps.c
+++ b/xen/arch/arm/traps.c
@@ -1337,62 +1337,20 @@ static register_t do_deprecated_hypercall(void)
     return -ENOSYS;
 }
 
-typedef register_t (*arm_hypercall_fn_t)(
-    register_t, register_t, register_t, register_t, register_t);
-
-typedef struct {
-    arm_hypercall_fn_t fn;
-    int nr_args;
-} arm_hypercall_t;
-
-#define HYPERCALL(_name, _nr_args)                                   \
-    [ __HYPERVISOR_ ## _name ] =  {                                  \
-        .fn = (arm_hypercall_fn_t) &do_ ## _name,                    \
-        .nr_args = _nr_args,                                         \
-    }
+long dep_sched_op_compat(int cmd, unsigned long arg)
+{
+    return do_deprecated_hypercall();
+}
 
-/*
- * Only use this for hypercalls which were deprecated (i.e. replaced
- * by something else) before Xen on ARM was created, i.e. *not* for
- * hypercalls which are simply not yet used on ARM.
- */
-#define HYPERCALL_DEPRECATED(_name, _nr_args)                   \
-    [ __HYPERVISOR_##_name ] = {                                \
-        .fn = (arm_hypercall_fn_t) &do_deprecated_hypercall,    \
-        .nr_args = _nr_args,                                    \
-    }
+long dep_event_channel_op_compat(XEN_GUEST_HANDLE_PARAM(evtchn_op_t) uop)
+{
+    return do_deprecated_hypercall();
+}
 
-static arm_hypercall_t arm_hypercall_table[] = {
-    HYPERCALL(memory_op, 2),
-    HYPERCALL(domctl, 1),
-    HYPERCALL(sched_op, 2),
-    HYPERCALL_DEPRECATED(sched_op_compat, 2),
-    HYPERCALL(console_io, 3),
-    HYPERCALL(xen_version, 2),
-    HYPERCALL(xsm_op, 1),
-    HYPERCALL(event_channel_op, 2),
-    HYPERCALL_DEPRECATED(event_channel_op_compat, 1),
-    HYPERCALL(physdev_op, 2),
-    HYPERCALL_DEPRECATED(physdev_op_compat, 1),
-    HYPERCALL(sysctl, 2),
-    HYPERCALL(hvm_op, 2),
-#ifdef CONFIG_GRANT_TABLE
-    HYPERCALL(grant_table_op, 3),
-#endif
-    HYPERCALL(multicall, 2),
-    HYPERCALL(platform_op, 1),
-    HYPERCALL(vcpu_op, 3),
-    HYPERCALL(vm_assist, 2),
-#ifdef CONFIG_ARGO
-    HYPERCALL(argo_op, 5),
-#endif
-#ifdef CONFIG_HYPFS
-    HYPERCALL(hypfs_op, 5),
-#endif
-#ifdef CONFIG_IOREQ_SERVER
-    HYPERCALL(dm_op, 3),
-#endif
-};
+long dep_physdev_op_compat(XEN_GUEST_HANDLE_PARAM(physdev_op_t) uop)
+{
+    return do_deprecated_hypercall();
+}
 
 #ifndef NDEBUG
 static void do_debug_trap(struct cpu_user_regs *regs, unsigned int code)
@@ -1431,7 +1389,6 @@ static void do_debug_trap(struct cpu_user_regs *regs, unsigned int code)
 #define HYPERCALL_ARG3(r) (r)->x2
 #define HYPERCALL_ARG4(r) (r)->x3
 #define HYPERCALL_ARG5(r) (r)->x4
-#define HYPERCALL_ARGS(r) (r)->x0, (r)->x1, (r)->x2, (r)->x3, (r)->x4
 #else
 #define HYPERCALL_RESULT_REG(r) (r)->r0
 #define HYPERCALL_ARG1(r) (r)->r0
@@ -1439,52 +1396,40 @@ static void do_debug_trap(struct cpu_user_regs *regs, unsigned int code)
 #define HYPERCALL_ARG3(r) (r)->r2
 #define HYPERCALL_ARG4(r) (r)->r3
 #define HYPERCALL_ARG5(r) (r)->r4
-#define HYPERCALL_ARGS(r) (r)->r0, (r)->r1, (r)->r2, (r)->r3, (r)->r4
 #endif
 
+static unsigned char hypercall_args[] = hypercall_args_arm;
+
 static void do_trap_hypercall(struct cpu_user_regs *regs, register_t *nr,
                               const union hsr hsr)
 {
-    arm_hypercall_fn_t call = NULL;
     struct vcpu *curr = current;
 
-    BUILD_BUG_ON(NR_hypercalls < ARRAY_SIZE(arm_hypercall_table) );
-
     if ( hsr.iss != XEN_HYPERCALL_TAG )
     {
         gprintk(XENLOG_WARNING, "Invalid HVC imm 0x%x\n", hsr.iss);
         return inject_undef_exception(regs, hsr);
     }
 
-    if ( *nr >= ARRAY_SIZE(arm_hypercall_table) )
-    {
-        perfc_incr(invalid_hypercalls);
-        HYPERCALL_RESULT_REG(regs) = -ENOSYS;
-        return;
-    }
-
     curr->hcall_preempted = false;
 
     perfc_incra(hypercalls, *nr);
-    call = arm_hypercall_table[*nr].fn;
-    if ( call == NULL )
-    {
-        HYPERCALL_RESULT_REG(regs) = -ENOSYS;
-        return;
-    }
 
-    HYPERCALL_RESULT_REG(regs) = call(HYPERCALL_ARGS(regs));
+    call_handlers_arm(*nr, HYPERCALL_RESULT_REG(regs), HYPERCALL_ARG1(regs),
+                      HYPERCALL_ARG2(regs), HYPERCALL_ARG3(regs),
+                      HYPERCALL_ARG4(regs), HYPERCALL_ARG5(regs));
 
 #ifndef NDEBUG
-    if ( !curr->hcall_preempted )
+    if ( !curr->hcall_preempted && HYPERCALL_RESULT_REG(regs) != -ENOSYS )
     {
         /* Deliberately corrupt parameter regs used by this hypercall. */
-        switch ( arm_hypercall_table[*nr].nr_args ) {
+        switch ( hypercall_args[*nr] ) {
         case 5: HYPERCALL_ARG5(regs) = 0xDEADBEEF;
         case 4: HYPERCALL_ARG4(regs) = 0xDEADBEEF;
         case 3: HYPERCALL_ARG3(regs) = 0xDEADBEEF;
         case 2: HYPERCALL_ARG2(regs) = 0xDEADBEEF;
         case 1: /* Don't clobber x0/r0 -- it's the return value */
+        case 0: /* -ENOSYS case */
             break;
         default: BUG();
         }
@@ -1521,7 +1466,10 @@ static bool check_multicall_32bit_clean(struct multicall_entry *multi)
 {
     int i;
 
-    for ( i = 0; i < arm_hypercall_table[multi->op].nr_args; i++ )
+    if ( multi->op >= ARRAY_SIZE(hypercall_args) )
+        return true;
+
+    for ( i = 0; i < hypercall_args[multi->op]; i++ )
     {
         if ( unlikely(multi->args[i] & 0xffffffff00000000ULL) )
         {
@@ -1538,28 +1486,13 @@ static bool check_multicall_32bit_clean(struct multicall_entry *multi)
 enum mc_disposition arch_do_multicall_call(struct mc_state *state)
 {
     struct multicall_entry *multi = &state->call;
-    arm_hypercall_fn_t call = NULL;
-
-    if ( multi->op >= ARRAY_SIZE(arm_hypercall_table) )
-    {
-        multi->result = -ENOSYS;
-        return mc_continue;
-    }
-
-    call = arm_hypercall_table[multi->op].fn;
-    if ( call == NULL )
-    {
-        multi->result = -ENOSYS;
-        return mc_continue;
-    }
 
     if ( is_32bit_domain(current->domain) &&
          !check_multicall_32bit_clean(multi) )
         return mc_continue;
 
-    multi->result = call(multi->args[0], multi->args[1],
-                         multi->args[2], multi->args[3],
-                         multi->args[4]);
+    call_handlers_arm(multi->op, multi->result, multi->args[0], multi->args[1],
+                      multi->args[2], multi->args[3], multi->args[4]);
 
     return likely(!psr_mode_is_user(guest_cpu_user_regs()))
            ? mc_continue : mc_preempt;
-- 
2.26.2



From xen-devel-bounces@lists.xenproject.org Fri Oct 15 12:52:44 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 12:52:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.210505.367485 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbMhX-0006g0-UM; Fri, 15 Oct 2021 12:52:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 210505.367485; Fri, 15 Oct 2021 12:52:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbMhX-0006fm-Qw; Fri, 15 Oct 2021 12:52:43 +0000
Received: by outflank-mailman (input) for mailman id 210505;
 Fri, 15 Oct 2021 12:52:42 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=esao=PD=suse.com=jgross@srs-us1.protection.inumbo.net>)
 id 1mbMhV-0001If-Uy
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 12:52:41 +0000
Received: from smtp-out1.suse.de (unknown [195.135.220.28])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id b2dc843a-2db6-11ec-8235-12813bfff9fa;
 Fri, 15 Oct 2021 12:52:06 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 587F421A69;
 Fri, 15 Oct 2021 12:52:05 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 2CF7713C1A;
 Fri, 15 Oct 2021 12:52:05 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id KPPLCXV5aWEYHgAAMHmgww
 (envelope-from <jgross@suse.com>); Fri, 15 Oct 2021 12:52:05 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b2dc843a-2db6-11ec-8235-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1634302325; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=fl7rNXPaOF/rSqcMCLu39+aDb9pf3LlEE3G2oqMEJsc=;
	b=WOzvxyvsFED/BlTD78alE86l3sJ0PshZhOW5840BFzGbvbLV0l3CYQwae0xhDgjqzVtpLG
	p5DGEchBlzv/MHgEcapE27cQdnfYMNSuUjAB7niX+j12iKb377lXVHI4MfUPU7QXlORXn+
	ILrheYV+FMb6bS+iD5At2Sqt+LKPa6M=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org
Cc: Juergen Gross <jgross@suse.com>,
	Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	Wei Liu <wl@xen.org>
Subject: [PATCH 12/12] xen/x86: add hypercall performance counters for hvm, correct pv
Date: Fri, 15 Oct 2021 14:51:52 +0200
Message-Id: <20211015125152.25198-13-jgross@suse.com>
X-Mailer: git-send-email 2.26.2
In-Reply-To: <20211015125152.25198-1-jgross@suse.com>
References: <20211015125152.25198-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

The HVM hypercall handler is missing incrementing the per hypercall
counters. Add that.

The counters for PV are handled wrong, as they are not using
perf_incra() with the number of the hypercall as index, but are
incrementing the total number of hypercalls only. Fix that.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 xen/arch/x86/hvm/hypercall.c | 2 ++
 xen/arch/x86/pv/hypercall.c  | 2 +-
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/xen/arch/x86/hvm/hypercall.c b/xen/arch/x86/hvm/hypercall.c
index e766cf4c72..599921dc48 100644
--- a/xen/arch/x86/hvm/hypercall.c
+++ b/xen/arch/x86/hvm/hypercall.c
@@ -214,6 +214,8 @@ int hvm_hypercall(struct cpu_user_regs *regs)
         ioreq_signal_mapcache_invalidate();
     }
 
+    perfc_incra(hypercalls, eax);
+
     return curr->hcall_preempted ? HVM_HCALL_preempted : HVM_HCALL_completed;
 }
 
diff --git a/xen/arch/x86/pv/hypercall.c b/xen/arch/x86/pv/hypercall.c
index 9b575e5c0b..ec8d2c7f87 100644
--- a/xen/arch/x86/pv/hypercall.c
+++ b/xen/arch/x86/pv/hypercall.c
@@ -106,7 +106,7 @@ _pv_hypercall(struct cpu_user_regs *regs, bool compat)
     if ( curr->hcall_preempted )
         regs->rip -= 2;
 
-    perfc_incr(hypercalls);
+    perfc_incra(hypercalls, eax);
 }
 
 enum mc_disposition pv_do_multicall_call(struct mc_state *state)
-- 
2.26.2



From xen-devel-bounces@lists.xenproject.org Fri Oct 15 13:00:25 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 13:00:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.210573.367495 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbMov-0001WB-Qi; Fri, 15 Oct 2021 13:00:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 210573.367495; Fri, 15 Oct 2021 13:00:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbMov-0001W4-NK; Fri, 15 Oct 2021 13:00:21 +0000
Received: by outflank-mailman (input) for mailman id 210573;
 Fri, 15 Oct 2021 13:00:20 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=FGCa=PD=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mbMou-0001Vy-TX
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 13:00:20 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 0f45ec14-db50-4365-9d70-4527ca05bd82;
 Fri, 15 Oct 2021 13:00:19 +0000 (UTC)
Received: from EUR03-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur03lp2050.outbound.protection.outlook.com [104.47.8.50]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-18-oCj84NtYMR2kzM_8CJVvjQ-1; Fri, 15 Oct 2021 15:00:17 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB7038.eurprd04.prod.outlook.com (2603:10a6:800:12d::9)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16; Fri, 15 Oct
 2021 13:00:15 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.017; Fri, 15 Oct 2021
 13:00:15 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM5PR0402CA0017.eurprd04.prod.outlook.com (2603:10a6:203:90::27) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16 via Frontend
 Transport; Fri, 15 Oct 2021 13:00:14 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0f45ec14-db50-4365-9d70-4527ca05bd82
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634302818;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=Dlqg6wIP95EU5M/9cFVtRdRsm0M8IGxop5ZZddvic7E=;
	b=hgFMvWXdfwp35t9fm11Nb14eS/a9ALL7FxjDCYKyyINca6vDC+qOmR1KjRhmOYL9C3nL9p
	PCirAtncvbfGCrdna5mgvpAdwgQOrlCmGk/irhll4nMEzQq/cddGfGHHFCbzbhMX2p/E3Q
	btnkI86779VfHt20Muz47rjDxTMV8Dk=
X-MC-Unique: oCj84NtYMR2kzM_8CJVvjQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=NiEseSDklaVEEkLxl4wwiqxZtApXFKG5rbQiF1LlncCqYQSpoSbKX2zMKmMav/vHR+MiAy9nKWzKyeWeo1vtE25W7V79CZ62mnyozJs3h6E+x4lZH6SLLrvTzQuxOtyiu13ZwwkZluv+FYiqFZ/9qxh/JtNIVdGURINIKQ6gPTMbMT3hTfwU9N/V+2Ma+oO4xrmLbJ3C9Se7ebYYRmlj5FrP4YJduopCW3IZRgUkIriO4RNwjf212vIe7JPi28pryBzGf0QX6oFIJb7ZTB9a2Qthpuom121yikCGOx7aeQNP5T1j/jWajwLduupbO835/ne3wbwgou2Rj1c+nsBieg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=vR6wTKTrVwmg0T+zOhdOldEAmYszKY/1ruNfZL9Tj1g=;
 b=i9cmN6SZjmZGKMHR2I0S4LuFeNHAQBQwTuVEgEgajJKffwHgS6Uyud2dJc1PNRZ0nGIgV7LzzP9spNGvGmQ99hodBlEAwHP6WCJYA5XR+KNlp+TiwYj5imgOl5dAWDqogkdyjMeOYwz+mMOO+5CUmS9avQ+S5DNRyWknKX1YvGgdv+z4BBxAvv1ZRMOfwCbuljxrrR99uauVEplJtzlSz1D42AnI6cHSsHcR1M6vQooDeFwYFjEIiisl70HO1MgXiIBzQFspDBiFCyOIU/PWc1HbDB0m/fWyG9Hs5XJ66xFXpfimYuXN81F3RXcYxoiaBk8LoxJIEQRTzpQeB5a6ZA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [PATCH v6 2/3] xen/arm: Enable the existing x86 virtual PCI
 support for ARM.
To: Bertrand Marquis <Bertrand.Marquis@arm.com>
CC: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Ian Jackson <iwj@xenproject.org>, Rahul Singh <Rahul.Singh@arm.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
 Paul Durrant <paul@xen.org>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <cover.1634221830.git.bertrand.marquis@arm.com>
 <396b08e2598cf0338e0c7f4ad3cd5cb66db89224.1634221830.git.bertrand.marquis@arm.com>
 <f41f59f7-69ed-e2fe-dc17-434b456cf693@suse.com>
 <57A39480-34DF-4BF5-9B0E-802D30F94BBD@arm.com>
 <24937.21631.538303.29471@mariner.uk.xensource.com>
 <b8fc68e6-2bba-ef11-4c4a-50c2046ecb04@suse.com>
 <YWlnc3b0sj4akUWa@MacBook-Air-de-Roger.local>
 <A2AAD333-35A2-4250-891C-E8FB885D5660@arm.com>
 <887d99e8-bcc5-f854-ceed-a38701e1ad1d@suse.com>
 <6C183E72-A9E8-4AB0-B6C4-C31E8AAFC4B6@arm.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <08fec860-7e8a-c8c7-df70-3c277de81718@suse.com>
Date: Fri, 15 Oct 2021 15:00:13 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <6C183E72-A9E8-4AB0-B6C4-C31E8AAFC4B6@arm.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM5PR0402CA0017.eurprd04.prod.outlook.com
 (2603:10a6:203:90::27) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: f4969986-09bf-4bee-5831-08d98fdbbb5a
X-MS-TrafficTypeDiagnostic: VI1PR04MB7038:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB7038C0CE1D14703706B4F979B3B99@VI1PR04MB7038.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	3521F/G7YrRiuBWfMoSKhBJTT0bd8LYYsBeMFRTEJmu7euT9uzul/8vz0M4A3j12b+ezfy8IEHyaqakO94MKBgbBzwfFtHvRpZhuACOEpfy5feaAF13tXBIgdKvP3GsEVWULR3zcaoI1rXS55fL2aUl3KHU5esV00f+NkPb8kZ8UdPORo0O/nuMUBK3jomlmHg/wNNqM2MxEAuL5Q8gNdFA4q9Ps8vuEH3owJ1wCMZ58sZfGd7mbsUEnayirBG2mU7o056gX9qRXx5X2XEoyzfKS5hLWErWg7/P6vrM0LFJIWgflfIu9WdQR5mk3gLQ0kmDOEKPrI8zzt4gFES/wCbmcSn/w/XFKXG5L4wIvpDRtqvG8O6jhA6I88/pfuQMRZE6DZML64GdMVB59YxVuqdLQoj5gegfUybTEFaYra5fr8SJ+JBB/zLjfYmi000VualxYSqhvjxKaKkXck8r9mQl5oSdlTvoz7bF7ztJEIPH3FU6V1kMy8POpTjheNw8yW1UFQgoILL99jTS/uiTo4TJ0pgFfmWjHiToZLKQd058QqJxWkLCJdmSNMRR1p8c2PtkcMBJ5Mnw50rtkEWuHQ4DFE7GhUyOQVZnMTpPwylWyFuxZ6LW44fAY5nlNcIbttOIkqcWx2K2yPDLJBhVkEWLGdaZfzRXU5a3dS3LE3wcmtOFHzzjCbJaWTRKJy0DaNSkMbzQS9ZHWp9XH3gIhewcydE2Ery5GxuWYTfm33OXZTTiQBKp9g4b6TS7gqEHiLDK5Wzdoyr1qNrfRQ+zr1ZRH2H8t5WTW54vRqxi2kR0J6NagpXa1qHKQuZ0Ur+ZPX9Eg01AZ9wVxImHvodiC2w==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(2616005)(8676002)(83380400001)(966005)(38100700002)(66556008)(8936002)(26005)(66476007)(66946007)(6916009)(5660300002)(7416002)(31696002)(6486002)(316002)(956004)(86362001)(16576012)(31686004)(54906003)(186003)(508600001)(36756003)(53546011)(4326008)(2906002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?OGBLF5zgF+ltaJ/8mWWa3gNVM6/5fIhNzAGZ7Jw/qLJbsFK0UIieitRsY7jl?=
 =?us-ascii?Q?d3uW5Y+claOm1hkwPFrZzIIezWnCAk0fZ60NiktBjhJStWsTJYq8t8vl59qD?=
 =?us-ascii?Q?8hB/bJYyY3ucHq1IWzH95eKhWntcZNxL7fWc7VrLH1uCZQy7iLlDi38mopf9?=
 =?us-ascii?Q?B+4LMWDrkUkHQr56D2gzn4mrcZVyPaQLcKvXBJcIVvoRDIjbuMr2dkdznUOe?=
 =?us-ascii?Q?XTSmE0Vkfh1erEpjCzMdkyZIXph8x+B83tGt+39arzJeBtcQi7Qg9A5EEB5S?=
 =?us-ascii?Q?tPgNQhXMf8jaNbf9DxGLYQ2bowRJjezD4eU6Pm3rYl4kTDaZ40IOvPjBUrGf?=
 =?us-ascii?Q?gYBinXV2oQtiQPJVwdPfeebM0n1fmpg0sf7E1lOO1Mh5IO1LByORd7Mi0P5A?=
 =?us-ascii?Q?Cb1n94LYpsgf56KpD7rMq9Gv//dFnPfJwd79ITgUrt9o0Bragvj0/QMTls4K?=
 =?us-ascii?Q?OFpRNRQI63NtoL3cGExtOWH7uXxhWxWygFN4ka7XiO7fgY0ti+Z2dWvUqxXv?=
 =?us-ascii?Q?t37Rg8axPLD2dfoh9Kb2c5xB7hFdhGm694zma0rH+Qa74GOGuYq/PqVXjJAY?=
 =?us-ascii?Q?mb3B09YqtG+DJMUql0/Gtr/HFO5ZIdBV0KbbXoCTrc0j/XTt/yXezZBnMiyn?=
 =?us-ascii?Q?3CDc0ZtQV+DlK1P01YLrPqxgWksDlv4hR5v+gJbJz7PkTJc+NzbclZ1jS8EY?=
 =?us-ascii?Q?qq+csp9Cw2XZ+YJa9qa1PIjCIbRdrHtDDoceMWyNspu2aMEeqbSl+vcvhmLy?=
 =?us-ascii?Q?1in701pR2o+eHLtLQTx39DIttVUcK04/Z30xAN9584YuogJGV974rxVMpWCq?=
 =?us-ascii?Q?CGYOdOZz38S/QSFdRRP2HP45SDShL+I2EnadEm9bJ/0NKNJtRinSTZuegxK+?=
 =?us-ascii?Q?OoETYVXsFQcuCYQHlagj1NZXl9ZrtVWKdgzuGA5+kkDFeDpeehjRJeTt8NJZ?=
 =?us-ascii?Q?QymQvHX31zFLfa+d3+PYRzAljSjQmRRAaSCg3j2pYMPLp0EBVHd6T75gsSym?=
 =?us-ascii?Q?GS3akvXVdAnVFRTVrWURwtkFDkaJ+SkeRUwC8SSpyLuM9EG39u66X3o+w22h?=
 =?us-ascii?Q?Xmiv1MqJdYW91svAUyQcIVGeQYrJ6JuVrbc3FCJWeJRkPm6cc1ndOHbYGCiD?=
 =?us-ascii?Q?GgHlVYA+bALROdRbu4XjME7Y+ANBtQTZ4r12zZlE3PpaXXhWR3O+cv8rINjW?=
 =?us-ascii?Q?J0vaE6BaaO0iIlcM0qCcC86S1vBPuBokxJCZwlBPr6SYtK7FnxEScIIjPC1Z?=
 =?us-ascii?Q?uRXAGeRIPOIC3RQmY5nZX+zsgMlQiPTQoGNF9amal3Lmfh2qOqqjla2GGug2?=
 =?us-ascii?Q?1vln+1kswxdgckA3FBtPyodo?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f4969986-09bf-4bee-5831-08d98fdbbb5a
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2021 13:00:15.4645
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: sZ2liF3Kihfb6ridm6XjKtr1GrzYgoXbrV9GAR6PLL3DOqCc1eLhtORivF0KNFbsBi/yjgBhweEDGBpIYSqnXg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7038

On 15.10.2021 14:28, Bertrand Marquis wrote:
>> On 15 Oct 2021, at 13:18, Jan Beulich <jbeulich@suse.com> wrote:
>> On 15.10.2021 14:13, Bertrand Marquis wrote:
>>>> On 15 Oct 2021, at 12:35, Roger Pau Monn=C3=A9 <roger.pau@citrix.com> =
wrote:
>>>> On Fri, Oct 15, 2021 at 12:18:59PM +0200, Jan Beulich wrote:
>>>>> On 15.10.2021 12:14, Ian Jackson wrote:
>>>>>> Bertrand Marquis writes ("Re: [PATCH v6 2/3] xen/arm: Enable the exi=
sting x86 virtual PCI support for ARM."):
>>>>>>>> On 15 Oct 2021, at 09:00, Jan Beulich <jbeulich@suse.com> wrote:
>>>>>>>> The latter is fine to be put here (i.e. FTAOD I'm fine with it
>>>>>>>> staying here). For the former I even question its original placeme=
nt
>>>>>>>> in asm-x86/pci.h: It's not generally correct as per the PCI spec, =
as
>>>>>>>> the bus portion of the address can be anywhere from 1 to 8 bits. A=
nd
>>>>>>>> in fact there is a reason why this macro was/is used in only a
>>>>>>>> single place, but not e.g. in x86'es handling of physical MCFG. It
>>>>>>>> is merely an implementation choice in vPCI that the entire segment=
 0
>>>>>>>> has a linear address range covering all 256 buses. Hence I think
>>>>>>>> this wants to move to xen/vpci.h and then perhaps also be named
>>>>>>>> VPCI_ECAM_BDF().
>>>>>>>
>>>>>>> On previous version it was request to renamed this to ECAM and agre=
ed
>>>>>>> to put is here. Now you want me to rename it to VPCI and move it ag=
ain.
>>>>>>> I would like to have a confirmation that this is ok and the final m=
ove if possible.
>>>>>>>
>>>>>>> @Roger can you confirm this is what is wanted ?
>>>>>>
>>>>>> I think Roger is not available today I'm afraid.
>>>>>>
>>>>>> Bertrand, can you give me a link to the comment from Roger ?
>>>>>> Assuming that it says what I think it will say:
>>>>>>
>>>>>> I think the best thing to do will be to leave the name as it was in
>>>>>> the most recent version of your series.  I don't think it makes sens=
e
>>>>>> to block this patch over a naming disagreement.  And it would be bes=
t
>>>>>> to minimise unnecessary churn.
>>>>>>
>>>>>> I would be happy to release-ack a name change (perhaps proposed bo J=
an
>>>>>> or Roger) supposing that that is the ultimate maintainer consensus.
>>>>>>
>>>>>> Jan, would that approach be OK with you ?
>>>>>
>>>>> Well, yes, if a subsequent name change is okay, then I could live wit=
h
>>>>> that. I'd still find it odd to rename a function immediately after it
>>>>> already got renamed. As expressed elsewhere, I suspect in his request
>>>>> Roger did not pay attention to a use of the function in non-ECAM code=
.
>>>>
>>>> Using MMCFG_BDF was original requested by Julien, not myself I think:
>>>>
>>>> https://lore.kernel.org/xen-devel/a868e1e7-8400-45df-6eaa-69f1e2c99383=
@xen.org/
>>>>
>>>> I'm slightly loss in so many messages. On x86 we subtract the MCFG
>>>> start address from the passed one before getting the BDF, and then we
>>>> add the startting bus address passed in the ACPI table. This is so far
>>>> not need on Arm AFAICT because of the fixed nature of the selected
>>>> virtual ECAM region.
>>>
>>> At the end my patch will add in xen/pci.h:
>>> #define ECAM_BDF(addr)         (((addr) & 0x0ffff000) >> 12)
>>
>> Since you still make this proposal, once again: I'm not going to
>> accept such a macro in this header, whatever the name. Its prior
>> placement was wrong as well. Only ...
>>
>>> #define ECAM_REG_OFFSET(addr)  ((addr) & 0x00000fff)
>>
>> ... this one is fine to live here (and presumably it could gain uses
>> elsewhere).
>=20
> So you would agree if they are both moved to vpci.h with a VPCI_ prefix ?

I wouldn't object, but as said several times before I see no reason
to also move and rename ECAM_REG_OFFSET(). If you moved it and if
later we find a use for it outside of vPCI, we'd need to rename and
move it again.

Jan



From xen-devel-bounces@lists.xenproject.org Fri Oct 15 13:10:49 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 13:10:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.210584.367507 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbMyy-0002xj-Ql; Fri, 15 Oct 2021 13:10:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 210584.367507; Fri, 15 Oct 2021 13:10:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbMyy-0002xc-Mr; Fri, 15 Oct 2021 13:10:44 +0000
Received: by outflank-mailman (input) for mailman id 210584;
 Fri, 15 Oct 2021 13:10:43 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Fqmt=PD=arm.com=Bertrand.Marquis@srs-us1.protection.inumbo.net>)
 id 1mbMyx-0002xW-Hs
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 13:10:43 +0000
Received: from EUR05-AM6-obe.outbound.protection.outlook.com (unknown
 [2a01:111:f400:7e1b::630])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 0f2cd3ab-066f-496a-934f-a6a5122f9a01;
 Fri, 15 Oct 2021 13:10:41 +0000 (UTC)
Received: from FR3P281CA0036.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1c::18)
 by AM9PR08MB6689.eurprd08.prod.outlook.com (2603:10a6:20b:30f::9) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.17; Fri, 15 Oct
 2021 13:10:36 +0000
Received: from VE1EUR03FT007.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:d10:1c:cafe::d6) by FR3P281CA0036.outlook.office365.com
 (2603:10a6:d10:1c::18) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.9 via Frontend
 Transport; Fri, 15 Oct 2021 13:10:36 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT007.mail.protection.outlook.com (10.152.18.114) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.15 via Frontend Transport; Fri, 15 Oct 2021 13:10:36 +0000
Received: ("Tessian outbound d5def7722ff7:v103");
 Fri, 15 Oct 2021 13:10:35 +0000
Received: from 3f3ce42df36f.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 324EFB68-8D25-4282-A125-E78AFB31153B.1; 
 Fri, 15 Oct 2021 13:10:25 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 3f3ce42df36f.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 15 Oct 2021 13:10:25 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com (2603:10a6:4:74::9)
 by DB8PR08MB4186.eurprd08.prod.outlook.com (2603:10a6:10:b1::22) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.25; Fri, 15 Oct
 2021 13:10:22 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955]) by DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955%4]) with mapi id 15.20.4587.031; Fri, 15 Oct 2021
 13:10:22 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0f2cd3ab-066f-496a-934f-a6a5122f9a01
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=X9Vxl43kclpZM5scmQvjcv5dbse8cpDHD4HhyKT9iL8=;
 b=yggc/R+3NwnZOJ0qT1X6HrgTjYY8ycKjToTFDFZWb0UlYYIxu0NxPAERqJCG/PPe7l37ibm1QW1RRX9ojvhoWgnSrapinAJcos3wR7IHnnzIfd1jJyUIFn8pHOwlzu7ZvaVgn5CU8oT4wISOTBhiNZRPSI9Y+yylZYEIEao57vk=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 206d4b5102850bad
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=eOEUdK3/J4cXQHURg592lftCEXTzMgR9dB+DsQUO7RUoMAJMexTXhGJ9xNeML/fFsDuA1qLHVzmK/olh5duiXR/fyogubbVgW3JrzHEYRtFZtbJ8qFGmp/YjLDTafejyEGZaHVCi6IS/n84yghSHRn0Ar3fCNK/+ruq/U5p2153a0T2BpsFJHAM53i/6qmQ68/oe58sCNvQs2TOH04E+7b7xrdl69JnRpkzQPLcdCLnzzrGKdFDDAbEZFsX2ShH+yMaz9Pk/F2Sr7sfBz/pyJZmYvl+LWInEkDox3HyKvxMKFE1bCBtvtWFWn5ahXEfCEUxDDOav76HBwNt8zYvH0Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=X9Vxl43kclpZM5scmQvjcv5dbse8cpDHD4HhyKT9iL8=;
 b=RvcjiD83Dy54br8or4HOmQSYweyRuj159pCSqsgULDudFWazH9ovTK1oXtZdOHLc7sAqtAPP27YqYPhlgJAdiumgP/I1KRxX1gnLWNTu6RUZUBgqxcYi9CrUePVNBuoeWPFlZBwOXLeEVqPX1Tsiwp2HPNdFxS5/CBslLxl+eQm8p21klObjRmWUEumWD5JPSVZe7/vGky5Gpze4pin6GaYSch+o9PCChl9Zb1tsJ5gxYzyOtavcrQzjTRP66p5PudkhD/LK7i6aLWwSfx9NPXPEBUsNogxuf9NVS18qRx97vTmghSVRpHV+Q9nZmVc9S2y0b+AOuyAPelE23TV4TA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=X9Vxl43kclpZM5scmQvjcv5dbse8cpDHD4HhyKT9iL8=;
 b=yggc/R+3NwnZOJ0qT1X6HrgTjYY8ycKjToTFDFZWb0UlYYIxu0NxPAERqJCG/PPe7l37ibm1QW1RRX9ojvhoWgnSrapinAJcos3wR7IHnnzIfd1jJyUIFn8pHOwlzu7ZvaVgn5CU8oT4wISOTBhiNZRPSI9Y+yylZYEIEao57vk=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Jan Beulich <jbeulich@suse.com>
CC: =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>, Ian Jackson
	<iwj@xenproject.org>, Rahul Singh <Rahul.Singh@arm.com>, Stefano Stabellini
	<sstabellini@kernel.org>, Julien Grall <julien@xen.org>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>, Paul Durrant
	<paul@xen.org>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v6 2/3] xen/arm: Enable the existing x86 virtual PCI
 support for ARM.
Thread-Topic: [PATCH v6 2/3] xen/arm: Enable the existing x86 virtual PCI
 support for ARM.
Thread-Index:
 AQHXwQrjS6mPrKT7Q06z3N66FcsDAKvTs1WAgAAj+QCAAAF1gIAAAUmAgAAVT4CAAAqRAIAAAYUAgAAC1QCAAAjTgIAAAtSA
Date: Fri, 15 Oct 2021 13:10:22 +0000
Message-ID: <E5F78DF2-D7CA-40C3-9E98-537155DD9529@arm.com>
References: <cover.1634221830.git.bertrand.marquis@arm.com>
 <396b08e2598cf0338e0c7f4ad3cd5cb66db89224.1634221830.git.bertrand.marquis@arm.com>
 <f41f59f7-69ed-e2fe-dc17-434b456cf693@suse.com>
 <57A39480-34DF-4BF5-9B0E-802D30F94BBD@arm.com>
 <24937.21631.538303.29471@mariner.uk.xensource.com>
 <b8fc68e6-2bba-ef11-4c4a-50c2046ecb04@suse.com>
 <YWlnc3b0sj4akUWa@MacBook-Air-de-Roger.local>
 <A2AAD333-35A2-4250-891C-E8FB885D5660@arm.com>
 <887d99e8-bcc5-f854-ceed-a38701e1ad1d@suse.com>
 <6C183E72-A9E8-4AB0-B6C4-C31E8AAFC4B6@arm.com>
 <08fec860-7e8a-c8c7-df70-3c277de81718@suse.com>
In-Reply-To: <08fec860-7e8a-c8c7-df70-3c277de81718@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3654.120.0.1.13)
Authentication-Results-Original: suse.com; dkim=none (message not signed)
 header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: a48e5928-bfec-48b7-3ff8-08d98fdd2d97
x-ms-traffictypediagnostic: DB8PR08MB4186:|AM9PR08MB6689:
x-ms-exchange-transport-forked: True
X-Microsoft-Antispam-PRVS:
	<AM9PR08MB66895A1C5FB97813544874CC9DB99@AM9PR08MB6689.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:10000;OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 qMrq3t0oO5iw1TNjxf6PIK9wq8YsrMddFQeHjbcM1xhhYsRH+40vco9D6xRcH2FGBe2BRwfihJB6Ve7Pdxr8ae0tE1l8Vl9wo/O3Pp1GZa/UlaXhSGNBpYEa8+zrKX1dO76AQXP7S4oPg8prT5dqd9nMvOW3Q6oEBPgA7v8SiAFUHPdGDGKQqLN9aIq6undCgjDLkLL9jeWTRTrd5JhVN+DXR2nZwDHQ2NrCdOTTvHvoQDUgdGMNzPbjGrg1ePQORFy0HrC3pkDw/hxVI1zGwu553Fd/VQRLaIs8likMeIIYqAYJnLZpkLIVIb/KW600rtftLT2ZHucif2o1XG+6ZLTzn3px77S0ecjbN2XF5OKs+gbUCOr7qCm3Gp0Q8XQd/4abhFQJfJfa8/EOIL9Ep57P3mxaMMUTkcXX47reroxv6KHS7NuqmoJxBWT+fE2qX3r7icgJ2I5yTYhdIX12tGUANXMRuyKAY0qDhWdDF3R8eXen+L71DpxPhvwmSw936AWv1Ma3J3KG7T5NgGBEYdwLOAsUZFHuwcbSVHJ1RN0KEsPpLy8gkgNwtQJ96gHCHoiZUNuUEp42LrjyiDID/MTtA374FEsZU4aFx8JTV7Vv/iPh4yHRwOPXEfTmVWt9B1ZyVwvxFxkscVMqh0zLP4nW8BUo8vtnoyfyuIJxSdd1BceaHgm0NHEOnFF3heqoe8QHBaAI5DZsa4H96uEJNs8aIoc6BcLcGwTxCTGUd0oHalupIEHYG7RAYJYuDywK6b4QomMORHC05U8ocJ1K4s+Gzx7A7HcI+Hu4CpKY+8x8k3xEAGvjlQwr1qS8dWx1EFGuBYMgvWfVtFl/0Bzcgw==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB6PR0801MB2024.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(4326008)(186003)(54906003)(122000001)(316002)(6506007)(8936002)(6486002)(8676002)(86362001)(38070700005)(53546011)(26005)(38100700002)(7416002)(33656002)(76116006)(5660300002)(508600001)(36756003)(2616005)(66556008)(64756008)(66476007)(71200400001)(966005)(91956017)(6916009)(83380400001)(66446008)(2906002)(66946007)(6512007)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-ID: <053FBC05CFA16043BF39A17879A060BE@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB4186
Original-Authentication-Results: suse.com; dkim=none (message not signed)
 header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT007.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	950a1784-58fa-4c49-7e53-08d98fdd253e
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	nhO6zjN6/W0DgLuKm4UrYr2NlEEeIP82Gc0ycKIMSbX46fpTzEE8edAqdYzXR1fkuznWN0xv8YK/Y65UHg+6XPbOWkcc64naafM36jcYnFMvyryIEbGIiyzCuvRh4YuN6G/Y3Y7WJJlVEK25Xi2HDa597rY7xaObGGzefPoA+jGUBGVbFhhJzC5hTLhhJjH20JNkRyUTwWSB+4l2skBJmQ6rI7nbJP+GivCwarU2uQdfW2FIyCc2aaGPCivQ2I+/gQNjy5HD4mzZKXJ5l445b8g1iIPN7I3xnnLo13niQ0IV0wOqQiL7R6w08sTLrpK6280BO/ffa+zVZ76dOysDHm7jAjzBiBXqGwNTFdrePG8tMHV8WRmtjE+T9Ok6WCQepxSSUhuc601n8rDMXwobhb6mgb8EblhEHKKjv65N4Vut5Cryzet9PyJZpf6StDXT87LebYPXiSkEpu6Z+LroCJM8RzqXRO5KLFUoQFiQbn73kXe4W3hX2Fo0z22JVdwmOZe6bwQfFm9y4jD4VuSbr+AGQLMEWqxXa/X/cRdq1PiYEyzy42b9imtUfpPfHMyp/nqNYkHXjIdPVG/zddm+SWpn1ePJuvpgrW75QRfyeOt3BGkEa19wtsRWcSSHpTiDEIDWNwhjNzYkKurDC0E7kAgeK2xdohdZxUyQbGoHs1cHeiC1j9ASLK5kbbfy0VB6BzolGrv0bE9r14DDf+w4GhhIqxkoBlD5TIppdcD1RX3OIFNbOh7K1O/RMeKQIXWnWKAGk/ccLNutZzgsEjVyw82TP/cJ4xrdz50ehvVrEd8=
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(966005)(336012)(5660300002)(8676002)(36860700001)(8936002)(6486002)(6506007)(53546011)(83380400001)(316002)(54906003)(26005)(186003)(70206006)(508600001)(70586007)(81166007)(4326008)(6862004)(356005)(2616005)(6512007)(2906002)(33656002)(36756003)(47076005)(86362001)(82310400003);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2021 13:10:36.3637
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: a48e5928-bfec-48b7-3ff8-08d98fdd2d97
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT007.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB6689

SGkgSmFuLA0KDQo+IE9uIDE1IE9jdCAyMDIxLCBhdCAxNDowMCwgSmFuIEJldWxpY2ggPGpiZXVs
aWNoQHN1c2UuY29tPiB3cm90ZToNCj4gDQo+IE9uIDE1LjEwLjIwMjEgMTQ6MjgsIEJlcnRyYW5k
IE1hcnF1aXMgd3JvdGU6DQo+Pj4gT24gMTUgT2N0IDIwMjEsIGF0IDEzOjE4LCBKYW4gQmV1bGlj
aCA8amJldWxpY2hAc3VzZS5jb20+IHdyb3RlOg0KPj4+IE9uIDE1LjEwLjIwMjEgMTQ6MTMsIEJl
cnRyYW5kIE1hcnF1aXMgd3JvdGU6DQo+Pj4+PiBPbiAxNSBPY3QgMjAyMSwgYXQgMTI6MzUsIFJv
Z2VyIFBhdSBNb25uw6kgPHJvZ2VyLnBhdUBjaXRyaXguY29tPiB3cm90ZToNCj4+Pj4+IE9uIEZy
aSwgT2N0IDE1LCAyMDIxIGF0IDEyOjE4OjU5UE0gKzAyMDAsIEphbiBCZXVsaWNoIHdyb3RlOg0K
Pj4+Pj4+IE9uIDE1LjEwLjIwMjEgMTI6MTQsIElhbiBKYWNrc29uIHdyb3RlOg0KPj4+Pj4+PiBC
ZXJ0cmFuZCBNYXJxdWlzIHdyaXRlcyAoIlJlOiBbUEFUQ0ggdjYgMi8zXSB4ZW4vYXJtOiBFbmFi
bGUgdGhlIGV4aXN0aW5nIHg4NiB2aXJ0dWFsIFBDSSBzdXBwb3J0IGZvciBBUk0uIik6DQo+Pj4+
Pj4+Pj4gT24gMTUgT2N0IDIwMjEsIGF0IDA5OjAwLCBKYW4gQmV1bGljaCA8amJldWxpY2hAc3Vz
ZS5jb20+IHdyb3RlOg0KPj4+Pj4+Pj4+IFRoZSBsYXR0ZXIgaXMgZmluZSB0byBiZSBwdXQgaGVy
ZSAoaS5lLiBGVEFPRCBJJ20gZmluZSB3aXRoIGl0DQo+Pj4+Pj4+Pj4gc3RheWluZyBoZXJlKS4g
Rm9yIHRoZSBmb3JtZXIgSSBldmVuIHF1ZXN0aW9uIGl0cyBvcmlnaW5hbCBwbGFjZW1lbnQNCj4+
Pj4+Pj4+PiBpbiBhc20teDg2L3BjaS5oOiBJdCdzIG5vdCBnZW5lcmFsbHkgY29ycmVjdCBhcyBw
ZXIgdGhlIFBDSSBzcGVjLCBhcw0KPj4+Pj4+Pj4+IHRoZSBidXMgcG9ydGlvbiBvZiB0aGUgYWRk
cmVzcyBjYW4gYmUgYW55d2hlcmUgZnJvbSAxIHRvIDggYml0cy4gQW5kDQo+Pj4+Pj4+Pj4gaW4g
ZmFjdCB0aGVyZSBpcyBhIHJlYXNvbiB3aHkgdGhpcyBtYWNybyB3YXMvaXMgdXNlZCBpbiBvbmx5
IGENCj4+Pj4+Pj4+PiBzaW5nbGUgcGxhY2UsIGJ1dCBub3QgZS5nLiBpbiB4ODYnZXMgaGFuZGxp
bmcgb2YgcGh5c2ljYWwgTUNGRy4gSXQNCj4+Pj4+Pj4+PiBpcyBtZXJlbHkgYW4gaW1wbGVtZW50
YXRpb24gY2hvaWNlIGluIHZQQ0kgdGhhdCB0aGUgZW50aXJlIHNlZ21lbnQgMA0KPj4+Pj4+Pj4+
IGhhcyBhIGxpbmVhciBhZGRyZXNzIHJhbmdlIGNvdmVyaW5nIGFsbCAyNTYgYnVzZXMuIEhlbmNl
IEkgdGhpbmsNCj4+Pj4+Pj4+PiB0aGlzIHdhbnRzIHRvIG1vdmUgdG8geGVuL3ZwY2kuaCBhbmQg
dGhlbiBwZXJoYXBzIGFsc28gYmUgbmFtZWQNCj4+Pj4+Pj4+PiBWUENJX0VDQU1fQkRGKCkuDQo+
Pj4+Pj4+PiANCj4+Pj4+Pj4+IE9uIHByZXZpb3VzIHZlcnNpb24gaXQgd2FzIHJlcXVlc3QgdG8g
cmVuYW1lZCB0aGlzIHRvIEVDQU0gYW5kIGFncmVlZA0KPj4+Pj4+Pj4gdG8gcHV0IGlzIGhlcmUu
IE5vdyB5b3Ugd2FudCBtZSB0byByZW5hbWUgaXQgdG8gVlBDSSBhbmQgbW92ZSBpdCBhZ2Fpbi4N
Cj4+Pj4+Pj4+IEkgd291bGQgbGlrZSB0byBoYXZlIGEgY29uZmlybWF0aW9uIHRoYXQgdGhpcyBp
cyBvayBhbmQgdGhlIGZpbmFsIG1vdmUgaWYgcG9zc2libGUuDQo+Pj4+Pj4+PiANCj4+Pj4+Pj4+
IEBSb2dlciBjYW4geW91IGNvbmZpcm0gdGhpcyBpcyB3aGF0IGlzIHdhbnRlZCA/DQo+Pj4+Pj4+
IA0KPj4+Pj4+PiBJIHRoaW5rIFJvZ2VyIGlzIG5vdCBhdmFpbGFibGUgdG9kYXkgSSdtIGFmcmFp
ZC4NCj4+Pj4+Pj4gDQo+Pj4+Pj4+IEJlcnRyYW5kLCBjYW4geW91IGdpdmUgbWUgYSBsaW5rIHRv
IHRoZSBjb21tZW50IGZyb20gUm9nZXIgPw0KPj4+Pj4+PiBBc3N1bWluZyB0aGF0IGl0IHNheXMg
d2hhdCBJIHRoaW5rIGl0IHdpbGwgc2F5Og0KPj4+Pj4+PiANCj4+Pj4+Pj4gSSB0aGluayB0aGUg
YmVzdCB0aGluZyB0byBkbyB3aWxsIGJlIHRvIGxlYXZlIHRoZSBuYW1lIGFzIGl0IHdhcyBpbg0K
Pj4+Pj4+PiB0aGUgbW9zdCByZWNlbnQgdmVyc2lvbiBvZiB5b3VyIHNlcmllcy4gIEkgZG9uJ3Qg
dGhpbmsgaXQgbWFrZXMgc2Vuc2UNCj4+Pj4+Pj4gdG8gYmxvY2sgdGhpcyBwYXRjaCBvdmVyIGEg
bmFtaW5nIGRpc2FncmVlbWVudC4gIEFuZCBpdCB3b3VsZCBiZSBiZXN0DQo+Pj4+Pj4+IHRvIG1p
bmltaXNlIHVubmVjZXNzYXJ5IGNodXJuLg0KPj4+Pj4+PiANCj4+Pj4+Pj4gSSB3b3VsZCBiZSBo
YXBweSB0byByZWxlYXNlLWFjayBhIG5hbWUgY2hhbmdlIChwZXJoYXBzIHByb3Bvc2VkIGJvIEph
bg0KPj4+Pj4+PiBvciBSb2dlcikgc3VwcG9zaW5nIHRoYXQgdGhhdCBpcyB0aGUgdWx0aW1hdGUg
bWFpbnRhaW5lciBjb25zZW5zdXMuDQo+Pj4+Pj4+IA0KPj4+Pj4+PiBKYW4sIHdvdWxkIHRoYXQg
YXBwcm9hY2ggYmUgT0sgd2l0aCB5b3UgPw0KPj4+Pj4+IA0KPj4+Pj4+IFdlbGwsIHllcywgaWYg
YSBzdWJzZXF1ZW50IG5hbWUgY2hhbmdlIGlzIG9rYXksIHRoZW4gSSBjb3VsZCBsaXZlIHdpdGgN
Cj4+Pj4+PiB0aGF0LiBJJ2Qgc3RpbGwgZmluZCBpdCBvZGQgdG8gcmVuYW1lIGEgZnVuY3Rpb24g
aW1tZWRpYXRlbHkgYWZ0ZXIgaXQNCj4+Pj4+PiBhbHJlYWR5IGdvdCByZW5hbWVkLiBBcyBleHBy
ZXNzZWQgZWxzZXdoZXJlLCBJIHN1c3BlY3QgaW4gaGlzIHJlcXVlc3QNCj4+Pj4+PiBSb2dlciBk
aWQgbm90IHBheSBhdHRlbnRpb24gdG8gYSB1c2Ugb2YgdGhlIGZ1bmN0aW9uIGluIG5vbi1FQ0FN
IGNvZGUuDQo+Pj4+PiANCj4+Pj4+IFVzaW5nIE1NQ0ZHX0JERiB3YXMgb3JpZ2luYWwgcmVxdWVz
dGVkIGJ5IEp1bGllbiwgbm90IG15c2VsZiBJIHRoaW5rOg0KPj4+Pj4gDQo+Pj4+PiBodHRwczov
L2xvcmUua2VybmVsLm9yZy94ZW4tZGV2ZWwvYTg2OGUxZTctODQwMC00NWRmLTZlYWEtNjlmMWUy
Yzk5MzgzQHhlbi5vcmcvDQo+Pj4+PiANCj4+Pj4+IEknbSBzbGlnaHRseSBsb3NzIGluIHNvIG1h
bnkgbWVzc2FnZXMuIE9uIHg4NiB3ZSBzdWJ0cmFjdCB0aGUgTUNGRw0KPj4+Pj4gc3RhcnQgYWRk
cmVzcyBmcm9tIHRoZSBwYXNzZWQgb25lIGJlZm9yZSBnZXR0aW5nIHRoZSBCREYsIGFuZCB0aGVu
IHdlDQo+Pj4+PiBhZGQgdGhlIHN0YXJ0dGluZyBidXMgYWRkcmVzcyBwYXNzZWQgaW4gdGhlIEFD
UEkgdGFibGUuIFRoaXMgaXMgc28gZmFyDQo+Pj4+PiBub3QgbmVlZCBvbiBBcm0gQUZBSUNUIGJl
Y2F1c2Ugb2YgdGhlIGZpeGVkIG5hdHVyZSBvZiB0aGUgc2VsZWN0ZWQNCj4+Pj4+IHZpcnR1YWwg
RUNBTSByZWdpb24uDQo+Pj4+IA0KPj4+PiBBdCB0aGUgZW5kIG15IHBhdGNoIHdpbGwgYWRkIGlu
IHhlbi9wY2kuaDoNCj4+Pj4gI2RlZmluZSBFQ0FNX0JERihhZGRyKSAgICAgICAgICgoKGFkZHIp
ICYgMHgwZmZmZjAwMCkgPj4gMTIpDQo+Pj4gDQo+Pj4gU2luY2UgeW91IHN0aWxsIG1ha2UgdGhp
cyBwcm9wb3NhbCwgb25jZSBhZ2FpbjogSSdtIG5vdCBnb2luZyB0bw0KPj4+IGFjY2VwdCBzdWNo
IGEgbWFjcm8gaW4gdGhpcyBoZWFkZXIsIHdoYXRldmVyIHRoZSBuYW1lLiBJdHMgcHJpb3INCj4+
PiBwbGFjZW1lbnQgd2FzIHdyb25nIGFzIHdlbGwuIE9ubHkgLi4uDQo+Pj4gDQo+Pj4+ICNkZWZp
bmUgRUNBTV9SRUdfT0ZGU0VUKGFkZHIpICAoKGFkZHIpICYgMHgwMDAwMGZmZikNCj4+PiANCj4+
PiAuLi4gdGhpcyBvbmUgaXMgZmluZSB0byBsaXZlIGhlcmUgKGFuZCBwcmVzdW1hYmx5IGl0IGNv
dWxkIGdhaW4gdXNlcw0KPj4+IGVsc2V3aGVyZSkuDQo+PiANCj4+IFNvIHlvdSB3b3VsZCBhZ3Jl
ZSBpZiB0aGV5IGFyZSBib3RoIG1vdmVkIHRvIHZwY2kuaCB3aXRoIGEgVlBDSV8gcHJlZml4ID8N
Cj4gDQo+IEkgd291bGRuJ3Qgb2JqZWN0LCBidXQgYXMgc2FpZCBzZXZlcmFsIHRpbWVzIGJlZm9y
ZSBJIHNlZSBubyByZWFzb24NCj4gdG8gYWxzbyBtb3ZlIGFuZCByZW5hbWUgRUNBTV9SRUdfT0ZG
U0VUKCkuIElmIHlvdSBtb3ZlZCBpdCBhbmQgaWYNCj4gbGF0ZXIgd2UgZmluZCBhIHVzZSBmb3Ig
aXQgb3V0c2lkZSBvZiB2UENJLCB3ZSdkIG5lZWQgdG8gcmVuYW1lIGFuZA0KPiBtb3ZlIGl0IGFn
YWluLg0KDQpJIHdpbGwgbW92ZSBCREYgdG8gdnBjaS5oIGFuZCBoYWQgVlBDSSBwcmVmaXggYW5k
IGtlZXAgUkVHX09GRlNFVCBhcw0KaXQgaXMgYW5kIHdoZXJlIGl0IGlzIHRoZW4uDQoNCkNoZWVy
cw0KQmVydHJhbmQNCg0KPiANCj4gSmFuDQo+IA0KDQo=


From xen-devel-bounces@lists.xenproject.org Fri Oct 15 13:16:25 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 13:16:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.210593.367518 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbN4P-0003gk-KZ; Fri, 15 Oct 2021 13:16:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 210593.367518; Fri, 15 Oct 2021 13:16:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbN4P-0003gd-GY; Fri, 15 Oct 2021 13:16:21 +0000
Received: by outflank-mailman (input) for mailman id 210593;
 Fri, 15 Oct 2021 13:16:20 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mbN4O-0003gX-H4
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 13:16:20 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mbN4O-0004na-En
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 13:16:20 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mbN4O-000479-Dd
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 13:16:20 +0000
Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89)
 (envelope-from <iwj@xenproject.org>)
 id 1mbN4K-0005nu-O8; Fri, 15 Oct 2021 14:16:16 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date
	:Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From;
	bh=kLm5d6faupQ9lA3jQZ9hZ/2hKEnrXUOkZ6Kr/FAIHL0=; b=x+plB/zVekqW9qrM9XMHit4k+k
	XHGCtBzyWNspjjwrYPsq3YUyexfxcTteVqISeh5Jg9n3z116+lZrpyOz/NIcRfc7D9rylUQtWmiWf
	i29DTCx7BHJ14Eu4Dj2vUpAv+whE2YhBAS7giC/X67v6YHN7YbkLzXMswjDU2fH0MaXU=;
From: Ian Jackson <iwj@xenproject.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <24937.32544.417730.402070@mariner.uk.xensource.com>
Date: Fri, 15 Oct 2021 14:16:16 +0100
To: Kevin Stefanov <kevin.stefanov@citrix.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>,
    Ian Jackson <iwj@xenproject.org>,
    Wei Liu <wl@xen.org>,
    Juergen Gross <jgross@suse.com>,
    Julien Grall <julien@xen.org>,
    Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH v2] tools/tests: Make E2BIG non-fatal to xenstore unit test
In-Reply-To: <20211015121409.24434-1-kevin.stefanov@citrix.com>
References: <20211015121409.24434-1-kevin.stefanov@citrix.com>
X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu)

Kevin Stefanov writes ("[PATCH v2] tools/tests: Make E2BIG non-fatal to xenstore unit test"):
> Xenstore's unit test fails on read and write of big numbers if
> quota-maxsize is set to a lower number than those test cases use.
> 
> Output a special warning instead of a failure message in such cases
> and make the error non-fatal to the unit test.

I realise that I am late to this, but I'm not sure I agree with the
basic principle of this change.  In general tolerating particular
errors in a test, and simply abandoning the test if they occcur, is
normally not the best approach.

Questions that come to my mind (and which aren't answered in the
commit message and probably should be) include:

Why does test-xenstore using these large numbers for its tests ?
Why would you run the tests with a quota too low for the tests ?
Might this test change not in principle miss genuine bugs ?

Ian.


From xen-devel-bounces@lists.xenproject.org Fri Oct 15 13:47:51 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 13:47:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.210604.367529 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbNYm-0006rI-2W; Fri, 15 Oct 2021 13:47:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 210604.367529; Fri, 15 Oct 2021 13:47:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbNYl-0006rB-V0; Fri, 15 Oct 2021 13:47:43 +0000
Received: by outflank-mailman (input) for mailman id 210604;
 Fri, 15 Oct 2021 13:47:42 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=UM5E=PD=citrix.com=roger.pau@srs-us1.protection.inumbo.net>)
 id 1mbNYj-0006r5-W6
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 13:47:42 +0000
Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 49a81ca9-b578-45d0-9a87-d7fbd490eadd;
 Fri, 15 Oct 2021 13:47:40 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 49a81ca9-b578-45d0-9a87-d7fbd490eadd
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1634305660;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=rxHefHo66IXw+lNQvqOV3aGfWd14F0ppwhcLcMyhPDQ=;
  b=WCPaRzBdhunlSMqud4G4Q7LDXtk06OB5IvIq+iQE2yOq4vt7SYfkVLoA
   h/vB4PS+Oa1x9568orGMg7XhkGSEOoIFk0XlFumooXA2bkERpMbshSPW7
   qYcI2ZR8+EmznUbe1MVC+ixk6gNQ9BKUJeTsN4uW8UbVEUzxXGefcp0f4
   8=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: NL/KQgug7lSuMdzjx9ahq1l/oZQ4CVsWWnOd+umI9mOwcSeX36n6LRfHCCvteBZFMdx1LCYng/
 CrCdJ0+Kcp9mgcP1zhMfkFpuP5Ilrim4Z8s1RDYPDO9v/dtL88rlGxmQqF8uIooXgtNT8bgsJ+
 LnogGEhPCHdhrU8GzOV591FQp/8wkEecASnz2wyHGmsvlF/Zoa4dLm0w3M1xDe5DkeEkPvJ0zW
 LAg12fsnOkoKlE0/USs9ewp9Pa7T99XjEy1B5286wPUavw2/ku4sTeqaciAPTPxdz+d0W0AJQy
 sMizc8aVr6IqrRNRSQUEl44F
X-SBRS: 5.1
X-MesageID: 55291026
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:WRdGZq/ZOjepbniI6j+1DrUDkHiTJUtcMsCJ2f8bNWPcYEJGY0x3m
 msfDW3UPfiIazamc9tyPYnjoUpT75bSn9ZhHgNspSA8E34SpcT7XtnIdU2Y0wF+jyHgoOCLy
 +1EN7Es+ehtFie0Si9AttENlFEkvU2ybuOU5NXsZ2YhGGeIdA970Ug6wrZg39Yx6TSEK1jlV
 e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH
 I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPhfk
 OwWsZOwYz0UHbLpxeQiCkgFDwdxaPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us
 6ZCcXZUM07F17neLLGTE4GAguw5K8bmJsUHs2xIxjDFF/c2B5vERs0m4PcFgW1h35gUQ54yY
 eI+VhB+QQXLZSduP1YwBZQQhdWipSDwJmgwRFW9+vNsvjm7IBZK+IbqNN3Za9mbX/J/l0yTp
 n/F12nhCxRcP9uaoRKH73ati+nnjS79HoUIG9WQ6fpCkFCVgGsJB3U+cl+2ouKwjEKkbPtZJ
 1YJ4SolraU090uDQ8H0Wluzp3vslgYVRt54A+A8rgaXxcL8+B2FD2IJSjpAbt0Ot8IsQzEuk
 FiTkLvBBzZirbmUQnK17aqPoHW5Pi19BUUPfzMeRA0JpfzqupgujwnnR8xmVqWyi7XdCTz2h
 jyHsiU6r7ESltIQkbW2+0jdhDChrYSPSRQ6ji3tV2K46kVCZYiqZ6Sh812d5vFFRK6YUVupr
 HUCg9KZ7u0FEdeKjiPlfQkWNOj3vbDfamSa2AMxWcl6n9iwx5K9Va4I2Wp6K0dDCPsnZhq0Y
 HCK6F5NwpAGaRNGcpRLS462Ds0ry43pGtLkSu3YY7JyX3RhSOOU1HoxPRDIjggBhGBpyPtlY
 c7KLq5AGF5DUfw/pAdaUdvxxlPCKsoW/mjUWYzghyqu1b6TdRZ5op9UbQPQMIjVAE6CyTg5E
 uqz1ePWlH2zs8WkO0E7FLL/y3hRcBDX4ris+qRqmhareFYOJY3YI6a5LUkdU4Jkhb9JsezD4
 2uwXERVoHKm2yabc17QMS06OOmxNXqakZ7dFXdxVbpP8yN7CbtDEY9FL8dnFVXZ3L0LIQFIo
 wktJJzbX6UnpsXv8DUBd5jtxLGOhzzw7T9iyxGNOWBlF7Y5HlSh0oa9ImPHqXlfZgLq5JBWi
 +DxiWvmrW8rGl0K4DD+M6n0kTtcfBE1xYpPYqc/CoINJRu2qdM0dnWZYz1eC5hkFCgvDwCyj
 m6+KRwZufPMs8ky9tzIjrqDtICnD611GU8yIoURxe/e2fDy8jXxzIlefvyPeDyBBmr49L/7P
 bdezu3mMe1Bl1FP6tIuH7FuxKM4xt3uu74FkVg0QCSVNwymWuF6P32L/chTrakRlLVXjhS7B
 xCU8d5ANLTXZM68SAwNJBAoZ/io3O0PnmWA9uw8JUj3vXcl/LeOXUhIEQOLjShRcOl8PI8/m
 L9zs88K8Q2vzBEtN4/e3CxT8m2NKF0GUrkm6c5GUNO61FJzxwgbM5LGCyLw7JWeUPl2MxEnc
 m2Oma7Pp7VA3U6eIXA9ImfAgLhGjpMUtREUkFJbfwaVmsDIj+Mc1QFK9WhlVRxcyxhK3r4hO
 mVvMEEpd6yC8y0x2ZpGVmGoXQpAGAeY6gr6zF5QzD/VSEyhV2rsKmwhOLnSoBBFojwEJjULr
 quFzGvFUCrxeJCj1yQ/bkdptvj/QIEj7QbFgs2mQ5yIEpRSjeAJWUNyib7kcyfaPP4=
IronPort-HdrOrdr: A9a23:WgCZ36qoTIlLLrKr6SVK+wEaV5u4L9V00zEX/kB9WHVpm5Oj+f
 xGzc516farslossREb+expOMG7MBXhHLpOkPQs1NCZLXXbUQqTXftfBO7ZogEIdBeOk9K1uZ
 0QF5SWTeeAcmSS7vyKkDVQcexQuOVvmZrA7Yy1ogYPPGMaGJ2IrT0JcTpzencGNTWubqBJba
 Z0iPA3wAZJLh8sH7qG7zQ+LqT+juyOsKijTQ8NBhYh5gXLpTS06ITiGxzd+hsFSTtAzZor7G
 CAymXCl+uemsD+7iWZ+37Y7pxQltek4txfBPaUgsxQDjn3kA6naKloRrXHljEop+OE7kosjb
 D30lgdFvU2z0mUUnC+oBPr1QWl+DEy60X6wVvdunfnqdyRfkNwN+NxwaZiNjfJ4Uspu99xlI
 hR2XiCipZRBRTc2Azg+tnhTXhR5wmJiEtntdRWo21UUIMYZrMUh5cY5llpHJAJGz+/wJw7Ed
 NpENrX6J9tABOnhkjizyxSKeGXLzAO9k/seDlEhiXV6UkWoJlB9Tpb+CRF9U1wsq7USPF/lq
 z52+pT5ehzpmJ/V9MLOA47e7rDNoX6e2OEDIujGyWUKEg5AQO4l3fW2sR+2Aj4Qu1E8HMN8K
 6xJm+w81RCI37TNQ==
X-IronPort-AV: E=Sophos;i="5.85,375,1624334400"; 
   d="scan'208";a="55291026"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=HXaT/VwYAR1RVNe+0MbAb5smi3GMw1VI5rYI7DhREvpvRVVNcEIfhswQLhFgyN198bm7CPEBRdW41FOMWtBvBDEQVTDBLKvcY7pItCqilqdK5h3rTxRy2mFtkHWaRP628fG6YSu+PP029gMGqYk4vaOBJnsKoTxjjfCvzsCiAmnyz/GdM/rr3JtRhvbZAAtv0YTJfpSpFCL/RGEzMYAUEZNNj5Aa2rzEG92HsjCjOblSXXPQZDhVSSLOex2ollWQ0c9VaoiIz5bEKW2PN/NdcSETLUFcGDdzfdwHgUinGnGnbi8OhI+GgL83++SwG02+epN9BnPJN2ghaFADxiB5hQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=aV5AwARp94NX6IihHSUjnTV9/aEWOTrRgdUCmtrUkHE=;
 b=d+DGmKkehXOE0NdN0qKbuAtSUjwsbS1l1oLF3fK1iyaVffO3ax/vDqYM1gYRzcQfBdMJNXcbyxgFpmY3YzfnNqsaCDlP6ITR1HdpkSCnCF5/PgLT88XAEJH8PR5ey/Q32hM7hVBiShUFmpEoC6x/vWa7HjU0xZsv2sZAHR9iNQLUb2HjNcuoye1r6g7Qco0OUJKmciaZMdGON+WfceHODZ49WEWKpaYCg9aMaZoHA2iAyt8q+rQLNaxEkryE0ntdosiT+NbG6Z0WsSk2twr6Ly0cSaTxAOiTOj8KcGr20X0fWZMjBLbXG2+JNbbY8Oh0ChdjUD7GTcs/tIB+SDs+Jg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=aV5AwARp94NX6IihHSUjnTV9/aEWOTrRgdUCmtrUkHE=;
 b=iA6CXObcbfvAtdrXEeU3TmIrmb9SzfdduqPScypP+XcGS2lW+y67sIuyeesAsLbE3I1LotHs9Kewbjn1zhfhJhz+pzFIFIU+LECQdwOh2tKUO1C8WrpmLd24B983nPQvIB1D3w7TenhUzrEA5KoxsHhCIXAHOmp8XSHRALbnUgc=
Date: Fri, 15 Oct 2021 15:47:27 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Bertrand Marquis <Bertrand.Marquis@arm.com>
CC: Jan Beulich <jbeulich@suse.com>, Xen-devel
	<xen-devel@lists.xenproject.org>, Ian Jackson <iwj@xenproject.org>, "Rahul
 Singh" <Rahul.Singh@arm.com>, Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>, Paul Durrant
	<paul@xen.org>, Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH v6 2/3] xen/arm: Enable the existing x86 virtual PCI
 support for ARM.
Message-ID: <YWmGbzPdCxmwfdIX@MacBook-Air-de-Roger.local>
References: <cover.1634221830.git.bertrand.marquis@arm.com>
 <396b08e2598cf0338e0c7f4ad3cd5cb66db89224.1634221830.git.bertrand.marquis@arm.com>
 <YWk8uP/YuSee1MfG@MacBook-Air-de-Roger.local>
 <CD9B29B0-31FD-4E09-93E3-7124C724BC23@arm.com>
 <1c298c02-5791-8935-f996-516da2409f24@suse.com>
 <BFC005A8-4C72-41C5-93F4-98BB9CBAB198@arm.com>
 <cd81cc31-617c-c750-01f4-b02bcb9e3a9e@suse.com>
 <B57498FA-F205-4DC1-ACE0-414558400293@arm.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <B57498FA-F205-4DC1-ACE0-414558400293@arm.com>
X-ClientProxiedBy: LO4P265CA0013.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:2ad::9) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: d349c140-cf54-4f48-ccfb-08d98fe25689
X-MS-TrafficTypeDiagnostic: DM6PR03MB4474:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <DM6PR03MB4474E10B394AA9E30BE31B2A8FB99@DM6PR03MB4474.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 8+GY7FOlyq8qT88gJHu+vlalrIihKOydC3WgIw0cS8CAV8baX/+IEzrwaTGkqtIyDPz0yhXn0Tcx3ZxVOMPb/uib+EPqIZbShNLjxWIzOA1OuxvUKEtbNUIOBxDncgJDG1kiy01GOc0xQL2+1dY8doCNIV+b20etTaFUXbNyDh5s+JgrP0toAUOUQt5yyf1myr0xwK/kbaT7Ttivs+n7XAYoHqVSjb/yfVPlh/HwBqm6XxbXS8ENAIKwMJekLL+BiNl8e//VQwH4iSbEB7UvH5tneDgEy2F81SUM1koA4nPXZ1oTx1EzsW/V4DMu3xBSQU9x5UrDHF+KU1P1qltyZw62S57XhppuAt2+1a1SygCl++EUKGoiQkxz+GSoCvgIbeGreOScS8GA8pHg20zIliXKd3Nk6pC/+QDzuKj7o4EY9KdRqGGOtr9Q5pcqPnSlyiEhQE1juV+wXa3MdYuff2cKB2+sWgGFw1ECSWnxAyEMlA/lxXqMvVKgzlplrr03XLxiy9JsLgyhAWfEMkQF5XfeKhRMD0ycHT7zagxXOz2/XoU26vtwuYjZ+hjyFOyfKCW8+vTLanlk7xbR4iMmLHgfoQViDTzb5vwuUqCvyZaSegd8N2vNLBedODQgHtKgd/eeJtMIdGe3TegsmB8xvA==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(956004)(6916009)(316002)(66476007)(66556008)(26005)(9686003)(6496006)(53546011)(186003)(85182001)(8936002)(66946007)(38100700002)(83380400001)(2906002)(82960400001)(54906003)(8676002)(86362001)(6486002)(4326008)(5660300002)(7416002)(508600001)(6666004);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SmZCQXJTR2ltbGlFOEdwZTlQOUNBNWVrUm1BbHp4bm85M1dSRHFCT2pIQVdW?=
 =?utf-8?B?RENvcStZRnlMd3dlek84cFJ1NnF0SDd3QjVheHVjME0vS0NGbW9uNEFCWXND?=
 =?utf-8?B?bFhrWldZRDk1S2F4R1hMOWpZRmo2RUxHR0tSdFFvUE1udTk5QUo1clJoOUxQ?=
 =?utf-8?B?SURRaWFxeDVRajN4aFA0QjdnQUtCSWxneE05dEZBZWxubitHT3lRcmg1YS9E?=
 =?utf-8?B?cS9oZjZMdEZ6TkRGeVlQQ0NtOWlqeTFuZjFEZy82UWlML3pXcW9XYTJERW9u?=
 =?utf-8?B?bkpvK2NRL1VuZHZUNlJEOExuejFzREFnTlpicWlPVWNtSDZKeHNDOFR5Rytu?=
 =?utf-8?B?aFQ2azZDWExQZXBtVXlyVTJwcGFBVXNOZzlsRnB2UTh3RDdMbkQyRXZUYk1u?=
 =?utf-8?B?YXZXeVFkdjJqZ1AxQ1V1VzMvTmcwalZKMlhTTXpHUncvcWNsVVloOTRDcCtP?=
 =?utf-8?B?d0ptM0Jld1ZQNlJRaDRKRHVUUTYyaXlMNnhJZDdKc3JkaGRUZVZHN2VYQ0dh?=
 =?utf-8?B?ZnNlcW9ackxpZ3lkMGQ3WlJWZmlwUDlDWk0zV2hxdll2MENsS0QxVXZabHBL?=
 =?utf-8?B?b3hkbW01ZWppV3NuNVdLT1AwMHNkRmRqL05LNHhDdTJFamJFRUV2U29CVkF2?=
 =?utf-8?B?MnB2SnNvNDFJUEJkSHpKWGs5dEF6cjFCU0hFYzFYSVUvVW5ZeEhhWjc0dTk1?=
 =?utf-8?B?M3lGSnI1OG5KdnhWRllOdjRZanlyaUdIY0loQjEzWERVUHNOT1RyK2hzaDR3?=
 =?utf-8?B?cEl1MW9zK2lsdW9RZlFETjBwSmdocENNUEc3OXExQWp5OFR1WXZrRnFYdDRr?=
 =?utf-8?B?WjlTOWdHMTd1SFlzYlMyTUZuUlV2YUZ3RGNXRURqamp0clBUNlpSZlpnNTdB?=
 =?utf-8?B?R0dRUjRNV3F2S0dqZ0MwVnNyY0RWK1FyWW9ZS1dsc0tYdjRPRGx2RTl5SFNj?=
 =?utf-8?B?c25vUXVNalVkWkl2blVVRGhsSmVTamZNaDhpTlFtTUFkVVAwQ2tIdWc5Q3V6?=
 =?utf-8?B?RkJYZ0ZYaUttaTF6Y0lDbUZKbURtQ0d0eFAxU2psSk1mbklVN2xzVjVBbEVp?=
 =?utf-8?B?NlR3VFEvam9JQTVHbjFPelJrRy9ZQUFIOGIzRDdUZUI3RkFqTDFXWlg1VzU5?=
 =?utf-8?B?NnovL05nZ1crSUxmaUdGQ3F0WEQ3SUpVVDVMcDM2MzJ2VkVCR1FCZWZmYm9u?=
 =?utf-8?B?ZEpkMTBlOWhMbFUxWFNiN25GMHBLNWlTTitYTG1kREw0MHZOcUt2QVNKcUZ6?=
 =?utf-8?B?c2ZUWXNpaEgvNlR3N2dmOHJFNTFuWE5aVTlNNjB1WVRJVmdVRkt0dTd6ZkVL?=
 =?utf-8?B?MjhGcTQ4YXhLeEc2d1VtSnR6Sm04RHg3aUVTU2FQUU05cFR0b0lJblNTZ2Y1?=
 =?utf-8?B?RGw1VVR0MWNPd0JyMFZPQk52aElOT2Zydmg0MVNqaWxlTlg5d212eFdkOGpK?=
 =?utf-8?B?K21iTVQ0cmFFN3hWYW5PaHYxRHh6WTNxUUp6KzlRTXBLWnZDZ1dzTTFFc0hi?=
 =?utf-8?B?WFptRHh6dEViYmFHMHczczk4alhOYUw4M0RtZ25QSXY5bGp4c1JFYU1FOThn?=
 =?utf-8?B?Wlg5VEcxNzZxck4vYW50Z3BqZmpqbHNyc2RMSkd6Znh1bHVmeVUyV3M1NTZ3?=
 =?utf-8?B?T2VPNnJnNzFEbUVlM204b3FsUXU0d0pHcE1KQktzZVl5b0dHeUN0QmtuSG9m?=
 =?utf-8?B?aHBvMnlvbXFpOTFlT01nWkpKbkVxTE1IMGYyVTRPR1oxd0JtdU5uOVROaHRx?=
 =?utf-8?Q?O3B8v2qg9TX9vt9lnZVdeH3nGUPEbppKtsj8F7h?=
X-MS-Exchange-CrossTenant-Network-Message-Id: d349c140-cf54-4f48-ccfb-08d98fe25689
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2021 13:47:33.1935
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: d35ZPVcj2sU9tG4b0dpcMK0BER7C0qcJa2znAtTCby9O8ZZadHsbkdbVaOA8gAUR3iKJenNln1szEkAuhG4iFg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4474
X-OriginatorOrg: citrix.com

On Fri, Oct 15, 2021 at 10:48:41AM +0000, Bertrand Marquis wrote:
> Hi Jan,
> 
> > On 15 Oct 2021, at 11:41, Jan Beulich <jbeulich@suse.com> wrote:
> > 
> > On 15.10.2021 12:33, Bertrand Marquis wrote:
> >>> On 15 Oct 2021, at 11:24, Jan Beulich <jbeulich@suse.com> wrote:
> >>> On 15.10.2021 11:52, Bertrand Marquis wrote:
> >>>>> On 15 Oct 2021, at 09:32, Roger Pau Monné <roger.pau@citrix.com> wrote:
> >>>>> On Thu, Oct 14, 2021 at 03:49:50PM +0100, Bertrand Marquis wrote:
> >>>>>> @@ -752,6 +752,19 @@ int pci_add_device(u16 seg, u8 bus, u8 devfn,
> >>>>>> 
> >>>>>>   check_pdev(pdev);
> >>>>>> 
> >>>>>> +#ifdef CONFIG_ARM
> >>>>>> +    /*
> >>>>>> +     * On ARM PCI devices discovery will be done by Dom0. Add vpci handler when
> >>>>>> +     * Dom0 inform XEN to add the PCI devices in XEN.
> >>>>>> +     */
> >>>>>> +    ret = vpci_add_handlers(pdev);
> >>>>>> +    if ( ret )
> >>>>>> +    {
> >>>>>> +        printk(XENLOG_ERR "Setup of vPCI failed: %d\n", ret);
> >>>>>> +        goto out;
> >>>>>> +    }
> >>>>>> +#endif
> >>>>> 
> >>>>> I think vpci_add_handlers should be called after checking that
> >>>>> pdev->domain is != NULL, so I would move this chunk a bit below.
> >>>> 
> >>>> On arm this would prevent the dom0less use case or to have the PCI
> >>>> bus enumerated from an other domain.
> >>>> @oleksandr: can you comment on this one, you might have a better
> >>>> answer than me on this ?
> >>> 
> >>> Well, without Xen doing the enumeration, some other entity would need
> >>> to do so, including the reporting to Xen. Obviously without a Dom0 it
> >>> would be ambiguous which domain to assign the device to; perhaps it
> >>> should be the caller in this case? That would make that caller domain
> >>> a pseudo-hwdom though, as far as PCI is concerned, which may not be
> >>> desirable according to my (limited) understanding of dom0less.
> >> 
> >> This is not really related to this patch but the plan is the following:
> >> - enumeration would have to be done by the firmware or boot loader before
> >> - xen will have some code to detect PCI devices
> >> - dom0less can be used to assign PCI devices to guest
> >> 
> >> Anyway does not change the fact that this must be called when domain is
> >> not NULL and I will fix that.
> > 
> > Since we now all seem to agree that the NULL would have been a problem,
> > may I ask in how far any of this has actually been tested?
> 
> With the whole serie currently on gitlab we have extensively tested passing
> through PCI devices on Arm in several configuration (number of device, MSI,
> MSI-X) and check that PCI was still functional on x86.
> 
> With the patches pushed to Xen right now it was checked that:
> - xen compiles properly on arm32, arm64 and x86
> - xen compiles properly with VPCI activated (using a patch) on arm32 and arm64
> - xen on x86 is functionnal (using basic test on QEMU)
> - xen on arm64 is functionnal (with some extensive tests on different targets)

I thinks it's unlikely, but since I haven't checked myself, could you
see if the vpci user-space test harness (tools/tests/vpci) still
builds and functions properly?

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Fri Oct 15 13:53:19 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 13:53:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.210611.367539 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbNdq-0008F9-Ku; Fri, 15 Oct 2021 13:52:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 210611.367539; Fri, 15 Oct 2021 13:52:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbNdq-0008F2-I4; Fri, 15 Oct 2021 13:52:58 +0000
Received: by outflank-mailman (input) for mailman id 210611;
 Fri, 15 Oct 2021 13:52:57 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mbNdp-0008Es-7V; Fri, 15 Oct 2021 13:52:57 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mbNdo-0005OQ-TQ; Fri, 15 Oct 2021 13:52:56 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mbNdo-0005BR-Kg; Fri, 15 Oct 2021 13:52:56 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mbNdo-0005Lr-KC; Fri, 15 Oct 2021 13:52:56 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=qpqTSoVURuQiBOSuikveYwmX/ILZ9q362IKGdQsPucI=; b=uH1t5u5mL2TnquJZALNx55HOGP
	3tPIFl2HYbRrexbNJ56yBG2vQIu9Skgn9fZ0Ll+MnU5V6K2fygQws6TOtDyMQ4/lDbfjeb+k3qJs7
	xvBA8DPno89dvrAk6+RHJ2kLtv0p5L1XqLMpp9dCR+xrX53YKAAAAzzFg0JKkGNI/STU=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165522-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 165522: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=9f4f20b27b0733e9b792e3cd2ad996febdea46ba
X-Osstest-Versions-That:
    xen=b75838ad6c4f42c93efee83fc2508c78641e1b57
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 15 Oct 2021 13:52:56 +0000

flight 165522 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165522/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  9f4f20b27b0733e9b792e3cd2ad996febdea46ba
baseline version:
 xen                  b75838ad6c4f42c93efee83fc2508c78641e1b57

Last test of basis   165512  2021-10-14 19:01:36 Z    0 days
Testing same since   165522  2021-10-15 11:02:48 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Jan Beulich <jbeulich@suse.com>
  Juergen Gross <jgross@suse.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   b75838ad6c..9f4f20b27b  9f4f20b27b0733e9b792e3cd2ad996febdea46ba -> smoke


From xen-devel-bounces@lists.xenproject.org Fri Oct 15 13:53:19 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 13:53:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.210613.367554 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbNdv-00004s-U0; Fri, 15 Oct 2021 13:53:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 210613.367554; Fri, 15 Oct 2021 13:53:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbNdv-0008WR-QP; Fri, 15 Oct 2021 13:53:03 +0000
Received: by outflank-mailman (input) for mailman id 210613;
 Fri, 15 Oct 2021 13:53:03 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=esao=PD=suse.com=jgross@srs-us1.protection.inumbo.net>)
 id 1mbNdv-0008WB-1g
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 13:53:03 +0000
Received: from smtp-out1.suse.de (unknown [195.135.220.28])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id b2306036-efa6-47c4-aff6-60ecea5f9c35;
 Fri, 15 Oct 2021 13:53:01 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id D907521A63;
 Fri, 15 Oct 2021 13:53:00 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id AB930133A7;
 Fri, 15 Oct 2021 13:53:00 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id /oJ7KLyHaWFOPAAAMHmgww
 (envelope-from <jgross@suse.com>); Fri, 15 Oct 2021 13:53:00 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b2306036-efa6-47c4-aff6-60ecea5f9c35
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1634305980; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=MTnvML1CY6imkev/A3yjj65hPiCOGfVEOIU/jM/L83c=;
	b=NhmJOw2RGs2qVpE2uRnNp5ZGEsBMtsQY2+t6DqbaqYhI9/psncg3s66AnrV6xT88/Z7RCm
	2fwjza2INHdG1uVx9KDA0SxQNR4tBz+nLydM9ScDvbyvQW5ZEmMN09oBTJvacsYvTtHof8
	EtiMoPZJjgiUc0fWQ9M5Fi+4a83pc9g=
Subject: Re: [PATCH v6 1/3] usb: Add Xen pvUSB protocol description
From: Juergen Gross <jgross@suse.com>
To: Greg KH <greg@kroah.com>
Cc: linux-usb@vger.kernel.org, xen-devel@lists.xenproject.org,
 linux-kernel@vger.kernel.org, Boris Ostrovsky <boris.ostrovsky@oracle.com>,
 Stefano Stabellini <sstabellini@kernel.org>
References: <20211013075207.13910-1-jgross@suse.com>
 <20211013075207.13910-2-jgross@suse.com> <YWbKnEMvHGU/rv96@kroah.com>
 <54da6414-4183-2d0c-cc24-a9471ed8332b@suse.com> <YWk4T2HTAD3VJMYR@kroah.com>
 <e2245716-ea36-aa21-f0a0-aad9c3e37136@suse.com>
Message-ID: <f3b4afb6-c033-34eb-2ec1-c878648740a5@suse.com>
Date: Fri, 15 Oct 2021 15:53:00 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <e2245716-ea36-aa21-f0a0-aad9c3e37136@suse.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="SG0JvX653DgGrJNZbC6HlMFT64oAzTtBp"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--SG0JvX653DgGrJNZbC6HlMFT64oAzTtBp
Content-Type: multipart/mixed; boundary="jq8jfbjGI4uzKAedXYv7Mz4Q0zWRWi8Mo";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Greg KH <greg@kroah.com>
Cc: linux-usb@vger.kernel.org, xen-devel@lists.xenproject.org,
 linux-kernel@vger.kernel.org, Boris Ostrovsky <boris.ostrovsky@oracle.com>,
 Stefano Stabellini <sstabellini@kernel.org>
Message-ID: <f3b4afb6-c033-34eb-2ec1-c878648740a5@suse.com>
Subject: Re: [PATCH v6 1/3] usb: Add Xen pvUSB protocol description
References: <20211013075207.13910-1-jgross@suse.com>
 <20211013075207.13910-2-jgross@suse.com> <YWbKnEMvHGU/rv96@kroah.com>
 <54da6414-4183-2d0c-cc24-a9471ed8332b@suse.com> <YWk4T2HTAD3VJMYR@kroah.com>
 <e2245716-ea36-aa21-f0a0-aad9c3e37136@suse.com>
In-Reply-To: <e2245716-ea36-aa21-f0a0-aad9c3e37136@suse.com>

--jq8jfbjGI4uzKAedXYv7Mz4Q0zWRWi8Mo
Content-Type: multipart/mixed;
 boundary="------------95C6EFF82384FBC6EC00FB65"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------95C6EFF82384FBC6EC00FB65
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 15.10.21 10:52, Juergen Gross wrote:
> On 15.10.21 10:14, Greg KH wrote:
>> On Fri, Oct 15, 2021 at 10:07:35AM +0200, Juergen Gross wrote:
>>> On 13.10.21 14:01, Greg KH wrote:
>>>> On Wed, Oct 13, 2021 at 09:52:05AM +0200, Juergen Gross wrote:
>>>>> Add the definition of pvUSB protocol used between the pvUSB=20
>>>>> frontend in
>>>>> a Xen domU and the pvUSB backend in a Xen driver domain (usually=20
>>>>> Dom0).
>>>>>
>>>>> This header was originally provided by Fujitsu for Xen based on Lin=
ux
>>>>> 2.6.18.
>>>>>
>>>>> Changes are:
>>>>> - adapt to Linux kernel style guide
>>>>> - use Xen namespace
>>>>> - add lots of comments
>>>>> - don't use kernel internal defines
>>>>>
>>>>> Signed-off-by: Juergen Gross <jgross@suse.com>
>>>>> Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
>>>>> ---
>>>>> =C2=A0=C2=A0 include/xen/interface/io/usbif.h | 421=20
>>>>> +++++++++++++++++++++++++++++++
>>>>> =C2=A0=C2=A0 1 file changed, 421 insertions(+)
>>>>> =C2=A0=C2=A0 create mode 100644 include/xen/interface/io/usbif.h
>>>>>
>>>>> diff --git a/include/xen/interface/io/usbif.h=20
>>>>> b/include/xen/interface/io/usbif.h
>>>>> new file mode 100644
>>>>> index 000000000000..9494b1c9be99
>>>>> --- /dev/null
>>>>> +++ b/include/xen/interface/io/usbif.h
>>>>> @@ -0,0 +1,421 @@
>>>>> +/*
>>>>> + * usbif.h
>>>>> + *
>>>>> + * USB I/O interface for Xen guest OSes.
>>>>> + *
>>>>> + * Copyright (C) 2009, FUJITSU LABORATORIES LTD.
>>>>> + * Author: Noboru Iwamatsu <n_iwamatsu@jp.fujitsu.com>
>>>>> + *
>>>>> + * Permission is hereby granted, free of charge, to any person=20
>>>>> obtaining a copy
>>>>> + * of this software and associated documentation files (the=20
>>>>> "Software"), to
>>>>> + * deal in the Software without restriction, including without=20
>>>>> limitation the
>>>>> + * rights to use, copy, modify, merge, publish, distribute,=20
>>>>> sublicense, and/or
>>>>> + * sell copies of the Software, and to permit persons to whom the =

>>>>> Software is
>>>>> + * furnished to do so, subject to the following conditions:
>>>>> + *
>>>>> + * The above copyright notice and this permission notice shall be =

>>>>> included in
>>>>> + * all copies or substantial portions of the Software.
>>>>> + *
>>>>> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,=
=20
>>>>> EXPRESS OR
>>>>> + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF=20
>>>>> MERCHANTABILITY,
>>>>> + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO=20
>>>>> EVENT SHALL THE
>>>>> + * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES=20
>>>>> OR OTHER
>>>>> + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,=
=20
>>>>> ARISING
>>>>> + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR=20
>>>>> OTHER
>>>>> + * DEALINGS IN THE SOFTWARE.
>>>>> + */
>>>>
>>>> Please use a SPDX line and not license "boilerplate" text like this =
:(
>>>
>>> Okay. Is this your only concern for this series? Or is it a blocking
>>> point for you before looking into it in more detail?
>>
>> It was an easy thing to see at first glance that you hadn't taken my
>> previous comment about this seriously :(
>=20
> I'm sorry for that. This was clearly an oversight from me.
>=20
> BTW, when checking which SPDX tag to use I discovered that most of the
> Xen header files under include/xen/interface have been tagged as GPL-2.=
0
> by a patch from you.
>=20
> Said patch (commit b24413180f5600) stated that there was no license
> information found in those files, but they all clearly had a verbatim
> copy of the MIT license in them.

They didn't. No idea where I was seeing that, sorry for that wrong
statement. Nevertheless the GPL-2.0 tag is wrong for those files.

Clearly need more coffee. :-(

> I'll send another patch fixing those SPDX tags.


Juergen

--------------95C6EFF82384FBC6EC00FB65
Content-Type: application/pgp-keys;
 name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Transfer-Encoding: quoted-printable
Content-Description: OpenPGP public key
Content-Disposition: attachment;
 filename="OpenPGP_0xB0DE9DD628BF132F.asc"

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy=
cWx
w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O=
f8Z
d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y=
9bf
IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq=
G7/
377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR=
3Jv
c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA=
QIe
AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT=
hpw
dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0=
MbD
1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv=
oPH
Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v=
5QL
+qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ=
2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC=
QoL
BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr=
Wf0
teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC=
/nu
AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh=
ITT
d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm=
XBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz=
80h
SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC=
AcD
AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn=
FOX
gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1=
jnD
kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0=
N51
N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l=
otu
fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1=
tqS
EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA=
hsD
BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3=
g3O
ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5=
dM7
wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5=
D+j
LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm=
V2x
AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N=
Eaw
QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW=
nHI
s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR=
wgn
BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV=
bVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk=
pEd
IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA=
QAB
wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw=
Tbe
8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1=
vJz
Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8=
VGi
wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW=
svi
uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX=
zXs
ZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------95C6EFF82384FBC6EC00FB65--

--jq8jfbjGI4uzKAedXYv7Mz4Q0zWRWi8Mo--

--SG0JvX653DgGrJNZbC6HlMFT64oAzTtBp
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmFph7wFAwAAAAAACgkQsN6d1ii/Ey/8
CQf/Sy5estBGDIzqKLtJAXx/wKIzGKCtx35oEAo6E1wS/P64qMsqJ7TzvFlR0s8IF0m7sRDPD/Qw
Qy3B6ik/7sgTkEUa0I4fGmYO2i3b9nMEIp9K0R+qFWrmLQivCkOTrLjk9wz/xdNgXm52rqbYsj1D
qWsHos6hTbNUiazASb1ZhVvMuFCqsDz1C4QdEFz9Q91FH+ZOyBAzoycpNcV/ETPDRJS026AhuBKm
NZ73y5t24mfHWg12BqNDOP3WJqNFl3QE0mKW9BT0+BKr2cpe7WrI+RzIwAoQtaTIW1cbgcvdnsIO
HLqUNI3C3vsb8WA34ZNgbhc0RECqDRtO6/0El9692A==
=Srkb
-----END PGP SIGNATURE-----

--SG0JvX653DgGrJNZbC6HlMFT64oAzTtBp--


From xen-devel-bounces@lists.xenproject.org Fri Oct 15 13:57:43 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 13:57:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.210630.367565 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbNiQ-00019B-NV; Fri, 15 Oct 2021 13:57:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 210630.367565; Fri, 15 Oct 2021 13:57:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbNiQ-000194-JK; Fri, 15 Oct 2021 13:57:42 +0000
Received: by outflank-mailman (input) for mailman id 210630;
 Fri, 15 Oct 2021 13:57:41 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=FGCa=PD=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mbNiP-00018y-7Z
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 13:57:41 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 4c862bb6-d042-4891-9f55-cff03af87784;
 Fri, 15 Oct 2021 13:57:40 +0000 (UTC)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2058.outbound.protection.outlook.com [104.47.12.58]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-38-fAk8bI9nNmOwYrMpzzQybA-1; Fri, 15 Oct 2021 15:57:38 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB5901.eurprd04.prod.outlook.com (2603:10a6:803:e9::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16; Fri, 15 Oct
 2021 13:57:36 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.017; Fri, 15 Oct 2021
 13:57:36 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6PR08CA0021.eurprd08.prod.outlook.com (2603:10a6:20b:b2::33) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.16 via Frontend Transport; Fri, 15 Oct 2021 13:57:35 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4c862bb6-d042-4891-9f55-cff03af87784
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634306259;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=9JWv/VNFc7LRjtRkF+Z3aoimnueAbl2VwHj/UtZSMVI=;
	b=IskJUlDRYesmd/jqVBvZkha+wfpymPvtcutyBDGhMi5ObIeFf1wEEk3cFXEm5CgPkKlgoi
	T7c2cfVkl62Sa3za0KetbHRlYN5Kar0YUR2dxLny8jVZcrwmyZFkrWfoTywS6HBRZhBKQ5
	JWioPIulQvgYfx0KKcsZHqQ2znhhCaM=
X-MC-Unique: fAk8bI9nNmOwYrMpzzQybA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=KFj8BU/k7IJOYMumema3iUbweeQfyvL14RVcoBFMVGAaA1HdcGuivQQwPA8ycxEZWuGeJWx8F8fzcV9EJKGTA63jeiLq5WXjboBCX1MRWcv8G81Ja+i6Sw9wXElw0n9VUSXG/iQSt1BqjKkGJwUnkDNfjOoGFdOVqJX5tJJUtKj1WJzqGoXa1dbHEYVVME2bhcbnDV5nYuTd/AdqIQIPly0uZhBDLAxdFZdvBPQhhcaIkuG0TndKOHLd+dl3qotLdPz47opmX9uL6tIKaNSnbpNQrqhERU+7puTT+yVmGoarHpwwiZBH8GBYxPidJdnoaEVUwsfsdeObOjAMXGRZtQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=9JWv/VNFc7LRjtRkF+Z3aoimnueAbl2VwHj/UtZSMVI=;
 b=RTma+yq0OZuDXI4bMNZ3WuZJRH/ZY5wv0ita8XGEGye+Z27vYF9efiQgAUkWZqC7cWZQnmzNLmcgtfHlf/2Y9eJ8C2d+8mdu1U+D/CxCqm94tb0lL69KsAtO3cGgwevrbaG+AU7nq3LJlS8AxBw1m5/hpxRsrIcchZy6rz2TOLDIF86Lm15l3xXXJ9WwsW4pmoJfSeEu5G4fID3BBUMxlvQylBriU/FSdgb2QbqbfiWLNOv43D+AA2uoA41nC9FCHbp+bcDxSLctBBAP/vZnKtfOecxSD51apWKrcbOy8v0yLvK3gV+YSw1haBGlTwNPF1g0h08ZFrxEElqHQcOfRg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [PATCH 08/12] x86/pv-shim: don't modify hypercall table
To: Juergen Gross <jgross@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>, Wei Liu
 <wl@xen.org>, George Dunlap <george.dunlap@citrix.com>,
 Ian Jackson <iwj@xenproject.org>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, xen-devel@lists.xenproject.org
References: <20211015125152.25198-1-jgross@suse.com>
 <20211015125152.25198-9-jgross@suse.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <460a149d-8d54-679a-1af8-694d7ee1ac01@suse.com>
Date: Fri, 15 Oct 2021 15:57:32 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <20211015125152.25198-9-jgross@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR08CA0021.eurprd08.prod.outlook.com
 (2603:10a6:20b:b2::33) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 6b5c887b-cf2f-45be-dc2a-08d98fe3be45
X-MS-TrafficTypeDiagnostic: VI1PR04MB5901:
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB59011D65CCAD56829F759DD7B3B99@VI1PR04MB5901.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	VUNUXihkeA1udrS3t7W1Mme2rON5lNstmS1VyYt8+LuRdxNL60BUXGVUU3szIsvIIBf6hx+PdO8tp17RQkVlpWnMOXeKok75gM+22PvO8YDCQaw21KiBL0En8nZn9IclGG7fHofVOcWROnxBT8MRC4mI3aWDfZ1+FfQw2q7AyUXFFd7hGXX4+WVbUObYrEXkkNwCa6HNv3BhCsiFI6lcOARaiGiJxr/7hoEmFXEfUdZf3ifnFICNqLd+OvLIwHksM2vnKAE6grTnWOof0tWwiMw0V37PUKSuyXaRzQXWhoW8+pzdoQVt7pROe83yp8+75MVbn7PKvuYOXf0L+VYN8DptW97ryqGu/aN6tSK1MtdgIfFrE+Z7C/gU3vHo7EfI/4jh3lfogOYmqDMvMV2mVvKFF83wK1cJ/98S3OkhX4ar2p8kqHcVcUiVHjFdH/5EVoACz179k4yiVg5UiCAviEwwJI0+tx5OVmzLvtPgYMspLPeHql089FN2fDXajOpidzanhLT0Mr/YPf4ACttEU2l09iqlpmdrPZU6SlYWPKsqlACoI2U+tnlPliNX6HQbYrHa8V9fS9erm1riswmlFw68FUnKC4+EhW+rEJXh+XfbUYL1BhxKU+lhZQWQkQwRIcVl8rrdbW8DVxIVZYWK8x84CrrmbqiB+De65fjGdncntV0Kb6uFi2KOg16MZrEfn4Xfu30PG1VmrvilqMgkZm1ulzh22BKmz/bNLmi/FTAcCZPDazlfQJaop3UBmEKd
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(26005)(31686004)(508600001)(8936002)(4326008)(86362001)(6636002)(6486002)(2616005)(956004)(2906002)(31696002)(54906003)(83380400001)(6862004)(53546011)(8676002)(186003)(66556008)(66946007)(36756003)(16576012)(316002)(66476007)(37006003)(5660300002)(38100700002)(6666004)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Wis5cE1uQVZSMTNnVnpaeklKZXhUMS9EeENzR0FUd0h2bkZSNDczcjQwbUlQ?=
 =?utf-8?B?d0JUSk4xS3dGUXY2R3BmOFBqR1lkVUx5NXVlMHR4eU1UV2dPRDRQVkFnakxq?=
 =?utf-8?B?UUtiYkFCZGJDcXRCY1docnVmWVNtV1B2VHdEdWE1RjkrZzNKUUlLa3Uvclp1?=
 =?utf-8?B?YVd2N2NSWHJtQmlQakxOM1JOc00vUEZVUThnUUtzYW90SHBUbURCdE54THBj?=
 =?utf-8?B?Y1FVNElWWXE1b1lIcGRCY3VIN3BBZTlDYzV4UUtXK0tiWWV2d3kyZkRwV1Fa?=
 =?utf-8?B?NzlhUzhnWU90YVErOFpmb2V4eGZSYkNxYmJWdEI3ZU96dTR0MEhqb0hYb0xt?=
 =?utf-8?B?eXlEeFkwd3pFdGhxVXdadlpKNWFMN1U2N1ZJMWJHeGRXVUtJdlh1N2RYMXVl?=
 =?utf-8?B?ME12Wi9GTVRINk5URWxLdDY4SXI0bFdxNlkreDg3aTQ4aFp1M0ExMi9ReS9S?=
 =?utf-8?B?VXRaWmY1ZS9GRDlEOWxJMGlQaTdxWDN1elRxYXRMKzBuYkRoWm16cm9YSlkz?=
 =?utf-8?B?V1NBYWp1ZnFIdHJ4SG5FUk44azJrcm5jVS96eS90eXh2QjdEaEJ1eUVCWTZ2?=
 =?utf-8?B?bldVZHR2ZU5wMXpFK0pJcXR6MVhiMFRMZHNZU1d6MTdKQzI3OFMxaFJhODQx?=
 =?utf-8?B?blBZZXkxMkFNdHdhMFV2M1k3ZzY4bk9OQ3ZsU09xK0Jwdkw5bWQzU05hTk44?=
 =?utf-8?B?SDRiQzBhRU1YbWZ0cXM2aElRdnNFNVJ4L2srdzlHY0NaUldib2pHdEQ0Rmxv?=
 =?utf-8?B?QUZkWHV1VFJXNXRWUXd2dWN1SENRbUFNRi9kTWZVcGpBMEkvbVU4OGkvQzI5?=
 =?utf-8?B?QmtGTktHQzBFL3NCTWJSMHZZYU5Fc0JmY3BLc3BZRVZHd01KQ1IwaGFRWW83?=
 =?utf-8?B?K0orQUl0WDlBa3Z6TW91c3U5WG81TmplYk16QTBXWEdyaENmSUo0WGx4Nk1M?=
 =?utf-8?B?NHFuUmxsTVNPNWZaK2lITVJnRk5pS3lubGQrZ25vZTNlNExwZXRMVElUazNw?=
 =?utf-8?B?OWROUCs1TWtqQlluUzM1MVlUOXcyc1ZnMHlDKzdWckIwdGlIMEhkbzdkWkhV?=
 =?utf-8?B?RGFmTzVPTjhjYjl2ZzkrelJuYVFqMlY2VnlQVWF2aTVic2R0b3cwWDVpV2Fa?=
 =?utf-8?B?dXpkOEZlYmVvOFVyMkRjS3BVeFRCOTVwV2sway9VbDMxOG1WaU4zYkFhc2k3?=
 =?utf-8?B?RzZGU0xnSmF2K2tGMTRoK1VMUTd5WEZhSFJaRGh3QWtuenFRUTVnN1NzNEFM?=
 =?utf-8?B?N0ZZcEVwMVM3M3M5bEpVQU9VQitIdmFLbzI2VnptQ3IxdFFPRUc4M3JtR2Ry?=
 =?utf-8?B?SUc0QW9LTFozWGFnNDV1aGRhNzZXUzFkMGFtOC95MFN1TFJXNUp4TEhoVW9L?=
 =?utf-8?B?VllkaHpVUW0wTlF2Qmp2d1ZoSXpEZ01udWNMcis3RXV5RWJWRXlLODBsYmlF?=
 =?utf-8?B?NmtKNTZEZEZ4SCs1akJuSU1zcTVEU2pXeWlyclc2alpzS2dQMVhZYjZ2L2Rs?=
 =?utf-8?B?UnFwNGtPbCtNRGlCek9FbFVvYStDR0tFK2V5UmVaK1MzOSthVFp1OTBvdjhz?=
 =?utf-8?B?VVFmb0l0MjlnUnAyQ2V2M3YrNHpYUjM1cENybFVhMEljNjVUWXViTjRmWkJ3?=
 =?utf-8?B?aUpVbHZvNllZNnkyYndZU08reHZwTUd4SlFUa25PQkJXeWJYZERiWmNUSHZP?=
 =?utf-8?B?aGwza2RGeisvbll3S1NNWmRzVEJLbkJvcnU1bzhpWkw4U1VhMElSb2xGZXBU?=
 =?utf-8?Q?GdOtjHVbCF7PfZet43BM2rlR1BHdUj3BbRa/MyE?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6b5c887b-cf2f-45be-dc2a-08d98fe3be45
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2021 13:57:36.3252
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: XcrLdDnIEO8cK+UTxeGdBd0zBfG0cqSJgfMeMhgH65Nu9ixn8KriVy6aj4sEXwtm+haKqD2KA7i1xOmR9iDGzQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5901

On 15.10.2021 14:51, Juergen Gross wrote:
> When running as pv-shim the hypercall is modified today in order to
> replace the functions for __HYPERVISOR_event_channel_op and
> __HYPERVISOR_grant_table_op hypercalls.
> 
> Change this to call the related functions from the normal handlers
> instead when running as shim. The performance implications are not
> really relevant, as a normal production hypervisor will not be
> configured to support shim mode, so the related calls will be dropped
> due to optimization of the compiler.
> 
> Note that for the CONFIG_PV_SHIM_EXCLUSIVE case there is a dummy
> wrapper do_grant_table_op() needed, as in this case grant_table.c
> isn't being built.

While you say CONFIG_PV_SHIM_EXCLUSIVE here, ...

> @@ -845,6 +822,23 @@ static long pv_shim_grant_table_op(unsigned int cmd,
>      return rc;
>  }
>  
> +#ifndef CONFIG_GRANT_TABLE

... you don't actually enforce this here. I also don't see why it would
be needed in the "exclusive" case only. A binary usable both ways would
still need these, wouldn't it?

> +/* Thin wrapper(s) needed. */
> +long do_grant_table_op(unsigned int cmd, XEN_GUEST_HANDLE_PARAM(void) uop,
> +                       unsigned int count)
> +{
> +    return pv_shim_grant_table_op(cmd, uop, count);
> +}
> +
> +#ifdef CONFIG_PV32
> +int compat_grant_table_op(unsigned int cmd, XEN_GUEST_HANDLE_PARAM(void) uop,
> +                          unsigned int count)
> +{
> +    return pv_shim_grant_table_op(cmd, uop, count);
> +}
> +#endif
> +#endif

Don't you also need to adjust the respective #ifdef in
pv_hypercall_table[]? Otherwise I don't see how, at this point of the
series, the functions would actually get hooked up. In a bi-modal
binary further guarding will then be needed inside the wrappers, I
think. (While the table is going to go away, that guarding is going
to be needed even at the end of this series, I believe.)

Talking of wrappers - do you need actual code to be emitted for this?
Can't you simply put in place an alias each, which is permitted now
that pv_shim_grant_table_op() isn't static anymore? (Albeit that's
partly moot if guarding code gets added to the functions - in that
case only compat_grant_table_op() could become an alias of
do_grant_table_op().)

Jan



From xen-devel-bounces@lists.xenproject.org Fri Oct 15 13:59:43 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 13:59:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.210638.367586 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbNkN-000224-B5; Fri, 15 Oct 2021 13:59:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 210638.367586; Fri, 15 Oct 2021 13:59:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbNkN-00021x-7w; Fri, 15 Oct 2021 13:59:43 +0000
Received: by outflank-mailman (input) for mailman id 210638;
 Fri, 15 Oct 2021 13:59:41 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Fqmt=PD=arm.com=bertrand.marquis@srs-us1.protection.inumbo.net>)
 id 1mbNkL-00020z-7t
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 13:59:41 +0000
Received: from foss.arm.com (unknown [217.140.110.172])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTP
 id a2b38552-6df8-4faf-9778-cada5db9f8e5;
 Fri, 15 Oct 2021 13:59:40 +0000 (UTC)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 30528147A;
 Fri, 15 Oct 2021 06:59:40 -0700 (PDT)
Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com
 [10.1.199.62])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 301D93F694;
 Fri, 15 Oct 2021 06:59:39 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a2b38552-6df8-4faf-9778-cada5db9f8e5
From: Bertrand Marquis <bertrand.marquis@arm.com>
To: xen-devel@lists.xenproject.org
Cc: iwj@xenproject.org,
	Paul Durrant <paul@xen.org>,
	Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	Wei Liu <wl@xen.org>
Subject: [PATCH v7 1/5] xen/vpci: Move ecam access functions to common code
Date: Fri, 15 Oct 2021 14:59:18 +0100
Message-Id: <bac1cc0d06dffc8f00233ea31233080bae8868aa.1634305870.git.bertrand.marquis@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <cover.1634305870.git.bertrand.marquis@arm.com>
References: <cover.1634305870.git.bertrand.marquis@arm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

PCI standard is using ECAM and not MCFG which is coming from ACPI[1].
Use ECAM/ecam instead of MCFG in common code and in new functions added
in common vpci code by this patch.

Move vpci_access_allowed from arch/x86/hvm/io.c to drivers/vpci/vpci.c.

Create vpci_ecam_{read,write} in drivers/vpci/vpci.c that
contains the common code to perform these operations, changed
vpci_mmcfg_{read,write} accordingly to make use of these functions.

The vpci_ecam_{read,write} functions are returning false on error and
true on success. As the x86 code was previously always returning
X86EMUL_OKAY the return code is ignored. A comment has been added in
the code to show that this is intentional.

Those functions will be used in a following patch inside by arm vpci
implementation.

Rename MMCFG_BDF to VPCI_ECAM_BDF and move it to vpci.h.
This macro is only used by functions calling vpci_ecam helpers.

No functional change intended with this patch.

[1] https://wiki.osdev.org/PCI_Express

Suggested-by: Roger Pau Monné <roger.pau@citrix.com>
Signed-off-by: Bertrand Marquis <bertrand.marquis@arm.com>
---
Changes in v7:
- Rename vpci_ecam_access_allowed to vpci_access_allowed
- Rename vpci_ecam_mmio_{read/write} to vpci_ecam_{read/write}
- Replace comment in x86/hvm/io.c with one suggested by Roger
- Remove 32bit comments and fixes from this patch and move it to the next
one to keep only the moving+renaming in this patch
- Change return type of vpci_ecam_{read/write} to bool
- rename ECAM_BDF to VPCI_ECAM_BDF and move it to vpci.h
Changes in v6: Patch added
---
 xen/arch/x86/hvm/io.c     | 46 ++++-----------------------------
 xen/drivers/vpci/vpci.c   | 54 +++++++++++++++++++++++++++++++++++++++
 xen/include/asm-x86/pci.h |  2 --
 xen/include/xen/vpci.h    | 12 +++++++++
 4 files changed, 71 insertions(+), 43 deletions(-)

diff --git a/xen/arch/x86/hvm/io.c b/xen/arch/x86/hvm/io.c
index 046a8eb4ed..eb3c80743e 100644
--- a/xen/arch/x86/hvm/io.c
+++ b/xen/arch/x86/hvm/io.c
@@ -260,20 +260,6 @@ unsigned int hvm_pci_decode_addr(unsigned int cf8, unsigned int addr,
     return CF8_ADDR_LO(cf8) | (addr & 3);
 }
 
-/* Do some sanity checks. */
-static bool vpci_access_allowed(unsigned int reg, unsigned int len)
-{
-    /* Check access size. */
-    if ( len != 1 && len != 2 && len != 4 && len != 8 )
-        return false;
-
-    /* Check that access is size aligned. */
-    if ( (reg & (len - 1)) )
-        return false;
-
-    return true;
-}
-
 /* vPCI config space IO ports handlers (0xcf8/0xcfc). */
 static bool vpci_portio_accept(const struct hvm_io_handler *handler,
                                const ioreq_t *p)
@@ -394,7 +380,7 @@ static unsigned int vpci_mmcfg_decode_addr(const struct hvm_mmcfg *mmcfg,
                                            paddr_t addr, pci_sbdf_t *sbdf)
 {
     addr -= mmcfg->addr;
-    sbdf->bdf = MMCFG_BDF(addr);
+    sbdf->bdf = VCPI_ECAM_BDF(addr);
     sbdf->bus += mmcfg->start_bus;
     sbdf->seg = mmcfg->segment;
 
@@ -434,25 +420,8 @@ static int vpci_mmcfg_read(struct vcpu *v, unsigned long addr,
     reg = vpci_mmcfg_decode_addr(mmcfg, addr, &sbdf);
     read_unlock(&d->arch.hvm.mmcfg_lock);
 
-    if ( !vpci_access_allowed(reg, len) ||
-         (reg + len) > PCI_CFG_SPACE_EXP_SIZE )
-        return X86EMUL_OKAY;
-
-    /*
-     * According to the PCIe 3.1A specification:
-     *  - Configuration Reads and Writes must usually be DWORD or smaller
-     *    in size.
-     *  - Because Root Complex implementations are not required to support
-     *    accesses to a RCRB that cross DW boundaries [...] software
-     *    should take care not to cause the generation of such accesses
-     *    when accessing a RCRB unless the Root Complex will support the
-     *    access.
-     *  Xen however supports 8byte accesses by splitting them into two
-     *  4byte accesses.
-     */
-    *data = vpci_read(sbdf, reg, min(4u, len));
-    if ( len == 8 )
-        *data |= (uint64_t)vpci_read(sbdf, reg + 4, 4) << 32;
+    /* Failed reads are not propagated to the caller */
+    vpci_ecam_read(sbdf, reg, len, data);
 
     return X86EMUL_OKAY;
 }
@@ -476,13 +445,8 @@ static int vpci_mmcfg_write(struct vcpu *v, unsigned long addr,
     reg = vpci_mmcfg_decode_addr(mmcfg, addr, &sbdf);
     read_unlock(&d->arch.hvm.mmcfg_lock);
 
-    if ( !vpci_access_allowed(reg, len) ||
-         (reg + len) > PCI_CFG_SPACE_EXP_SIZE )
-        return X86EMUL_OKAY;
-
-    vpci_write(sbdf, reg, min(4u, len), data);
-    if ( len == 8 )
-        vpci_write(sbdf, reg + 4, 4, data >> 32);
+    /* Failed writes are not propagated to the caller */
+    vpci_ecam_write(sbdf, reg, len, data);
 
     return X86EMUL_OKAY;
 }
diff --git a/xen/drivers/vpci/vpci.c b/xen/drivers/vpci/vpci.c
index cbd1bac7fc..ef690f15a9 100644
--- a/xen/drivers/vpci/vpci.c
+++ b/xen/drivers/vpci/vpci.c
@@ -478,6 +478,60 @@ void vpci_write(pci_sbdf_t sbdf, unsigned int reg, unsigned int size,
     spin_unlock(&pdev->vpci->lock);
 }
 
+/* Helper function to check an access size and alignment on vpci space. */
+bool vpci_access_allowed(unsigned int reg, unsigned int len)
+{
+    /* Check access size. */
+    if ( len != 1 && len != 2 && len != 4 && len != 8 )
+        return false;
+
+    /* Check that access is size aligned. */
+    if ( (reg & (len - 1)) )
+        return false;
+
+    return true;
+}
+
+bool vpci_ecam_write(pci_sbdf_t sbdf, unsigned int reg, unsigned int len,
+                         unsigned long data)
+{
+    if ( !vpci_access_allowed(reg, len) ||
+         (reg + len) > PCI_CFG_SPACE_EXP_SIZE )
+        return false;
+
+    vpci_write(sbdf, reg, min(4u, len), data);
+    if ( len == 8 )
+        vpci_write(sbdf, reg + 4, 4, data >> 32);
+
+    return true;
+}
+
+bool vpci_ecam_read(pci_sbdf_t sbdf, unsigned int reg, unsigned int len,
+                        unsigned long *data)
+{
+    if ( !vpci_access_allowed(reg, len) ||
+         (reg + len) > PCI_CFG_SPACE_EXP_SIZE )
+        return false;
+
+    /*
+     * According to the PCIe 3.1A specification:
+     *  - Configuration Reads and Writes must usually be DWORD or smaller
+     *    in size.
+     *  - Because Root Complex implementations are not required to support
+     *    accesses to a RCRB that cross DW boundaries [...] software
+     *    should take care not to cause the generation of such accesses
+     *    when accessing a RCRB unless the Root Complex will support the
+     *    access.
+     *  Xen however supports 8byte accesses by splitting them into two
+     *  4byte accesses.
+     */
+    *data = vpci_read(sbdf, reg, min(4u, len));
+    if ( len == 8 )
+        *data |= (uint64_t)vpci_read(sbdf, reg + 4, 4) << 32;
+
+    return true;
+}
+
 /*
  * Local variables:
  * mode: C
diff --git a/xen/include/asm-x86/pci.h b/xen/include/asm-x86/pci.h
index edd7c3e71a..443f25347d 100644
--- a/xen/include/asm-x86/pci.h
+++ b/xen/include/asm-x86/pci.h
@@ -6,8 +6,6 @@
 #define CF8_ADDR_HI(cf8) (  ((cf8) & 0x0f000000) >> 16)
 #define CF8_ENABLED(cf8) (!!((cf8) & 0x80000000))
 
-#define MMCFG_BDF(addr)  ( ((addr) & 0x0ffff000) >> 12)
-
 #define IS_SNB_GFX(id) (id == 0x01068086 || id == 0x01168086 \
                         || id == 0x01268086 || id == 0x01028086 \
                         || id == 0x01128086 || id == 0x01228086 \
diff --git a/xen/include/xen/vpci.h b/xen/include/xen/vpci.h
index 9f5b5d52e1..d6cf0baf14 100644
--- a/xen/include/xen/vpci.h
+++ b/xen/include/xen/vpci.h
@@ -19,6 +19,8 @@ typedef int vpci_register_init_t(struct pci_dev *dev);
 #define VPCI_PRIORITY_MIDDLE    "5"
 #define VPCI_PRIORITY_LOW       "9"
 
+#define VPCI_ECAM_BDF(addr)     (((addr) & 0x0ffff000) >> 12)
+
 #define REGISTER_VPCI_INIT(x, p)                \
   static vpci_register_init_t *const x##_entry  \
                __used_section(".data.vpci." p) = x
@@ -208,6 +210,16 @@ static inline unsigned int vmsix_entry_nr(const struct vpci_msix *msix,
 {
     return entry - msix->entries;
 }
+
+/* ECAM mmio read/write helpers */
+bool vpci_access_allowed(unsigned int reg, unsigned int len);
+
+bool vpci_ecam_write(pci_sbdf_t sbdf, unsigned int reg, unsigned int len,
+                         unsigned long data);
+
+bool vpci_ecam_read(pci_sbdf_t sbdf, unsigned int reg, unsigned int len,
+                        unsigned long *data);
+
 #endif /* __XEN__ */
 
 #else /* !CONFIG_HAS_VPCI */
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Fri Oct 15 13:59:43 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 13:59:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.210637.367576 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbNkJ-0001kq-32; Fri, 15 Oct 2021 13:59:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 210637.367576; Fri, 15 Oct 2021 13:59:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbNkI-0001kj-WD; Fri, 15 Oct 2021 13:59:39 +0000
Received: by outflank-mailman (input) for mailman id 210637;
 Fri, 15 Oct 2021 13:59:37 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Fqmt=PD=arm.com=bertrand.marquis@srs-us1.protection.inumbo.net>)
 id 1mbNkH-0001kd-Cj
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 13:59:37 +0000
Received: from foss.arm.com (unknown [217.140.110.172])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTP
 id 21c4e8a0-2dc0-11ec-8237-12813bfff9fa;
 Fri, 15 Oct 2021 13:59:36 +0000 (UTC)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 44395147A;
 Fri, 15 Oct 2021 06:59:36 -0700 (PDT)
Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com
 [10.1.199.62])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 96BC83F694;
 Fri, 15 Oct 2021 06:59:34 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 21c4e8a0-2dc0-11ec-8237-12813bfff9fa
From: Bertrand Marquis <bertrand.marquis@arm.com>
To: xen-devel@lists.xenproject.org
Cc: iwj@xenproject.org,
	Paul Durrant <paul@xen.org>,
	Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	Wei Liu <wl@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Anthony PERARD <anthony.perard@citrix.com>,
	Juergen Gross <jgross@suse.com>
Subject: [PATCH v7 0/5] PCI devices passthrough on Arm
Date: Fri, 15 Oct 2021 14:59:17 +0100
Message-Id: <cover.1634305870.git.bertrand.marquis@arm.com>
X-Mailer: git-send-email 2.25.1
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Hello All,

This serie is a follow up on Rahul serie where we included various fixes
required after review on the mailing list and a new patch to move some
of the x86 ecam related code to the common vpci code.

Most of the patches of the original serie have been merged and this
serie includes only 2 of the original patches reworked and 3 new patches:

Move some ECAM related functions from x86 to generic vpci
implementation:
- move vcpi mmcfg_{read/write} and vpci_access_allowed to common vpci.c.
- use ecam instead of mmcfg in common code.

Enable the existing x86 virtual PCI support for ARM:
- Add VPCI trap handler for each of the PCI device added for config
  space access.
- Register the trap handler in XEN for each of the host bridge PCI ECAM
  config space access.

Modify libxl function to take the whole domain config as argument:
- libxl__arch_domain_init_hw_description
- libxl__prepare_dt

Emulated PCI device tree node in libxl:
- Create a virtual PCI device tree node in libxl to enable the guest OS
  to discover the virtual PCI during guest boot.

The patch modifying xc_domain_ioport_permission has been removed from
the serie.

Bertrand Marquis (1):
  xen/vpci: Move ecam access functions to common code

Michal Orzel (2):
  tools/libxl: Modify libxl__arch_domain_init_hw_description...
  tools/libxl_arm: Modify libxl__prepare_dtb...

Rahul Singh (2):
  xen/arm: Enable the existing x86 virtual PCI support for ARM
  arm/libxl: Emulated PCI device tree node in libxl

 tools/libs/light/libxl_arch.h   |   2 +-
 tools/libs/light/libxl_arm.c    | 111 +++++++++++++++++++++++++++++++-
 tools/libs/light/libxl_create.c |   5 ++
 tools/libs/light/libxl_dom.c    |   2 +-
 tools/libs/light/libxl_x86.c    |   2 +-
 xen/arch/arm/Makefile           |   1 +
 xen/arch/arm/domain.c           |   4 ++
 xen/arch/arm/vpci.c             |  77 ++++++++++++++++++++++
 xen/arch/arm/vpci.h             |  36 +++++++++++
 xen/arch/x86/hvm/io.c           |  46 ++-----------
 xen/drivers/passthrough/pci.c   |  14 ++++
 xen/drivers/vpci/header.c       |   2 +-
 xen/drivers/vpci/vpci.c         |  64 ++++++++++++++++++
 xen/include/asm-arm/domain.h    |   1 +
 xen/include/asm-x86/pci.h       |   2 -
 xen/include/public/arch-arm.h   |  17 +++++
 xen/include/xen/pci.h           |   2 +
 xen/include/xen/vpci.h          |  12 ++++
 18 files changed, 350 insertions(+), 50 deletions(-)
 create mode 100644 xen/arch/arm/vpci.c
 create mode 100644 xen/arch/arm/vpci.h

-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Fri Oct 15 13:59:47 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 13:59:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.210639.367598 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbNkR-0002MI-Ko; Fri, 15 Oct 2021 13:59:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 210639.367598; Fri, 15 Oct 2021 13:59:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbNkR-0002M7-HD; Fri, 15 Oct 2021 13:59:47 +0000
Received: by outflank-mailman (input) for mailman id 210639;
 Fri, 15 Oct 2021 13:59:46 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Fqmt=PD=arm.com=bertrand.marquis@srs-us1.protection.inumbo.net>)
 id 1mbNkQ-00020z-76
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 13:59:46 +0000
Received: from foss.arm.com (unknown [217.140.110.172])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTP
 id 12d6442e-a78f-46ee-800c-93c651db31c7;
 Fri, 15 Oct 2021 13:59:42 +0000 (UTC)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 119C614BF;
 Fri, 15 Oct 2021 06:59:42 -0700 (PDT)
Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com
 [10.1.199.62])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 653133F694;
 Fri, 15 Oct 2021 06:59:40 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 12d6442e-a78f-46ee-800c-93c651db31c7
From: Bertrand Marquis <bertrand.marquis@arm.com>
To: xen-devel@lists.xenproject.org
Cc: iwj@xenproject.org,
	Rahul Singh <rahul.singh@arm.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Wei Liu <wl@xen.org>,
	Paul Durrant <paul@xen.org>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>
Subject: [PATCH v7 2/5] xen/arm: Enable the existing x86 virtual PCI support for ARM
Date: Fri, 15 Oct 2021 14:59:19 +0100
Message-Id: <847d430fdeb19e695176ddea71eeb11dcef8b23e.1634305870.git.bertrand.marquis@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <cover.1634305870.git.bertrand.marquis@arm.com>
References: <cover.1634305870.git.bertrand.marquis@arm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

From: Rahul Singh <rahul.singh@arm.com>

The existing VPCI support available for X86 is adapted for Arm.
When the device is added to XEN via the hyper call
“PHYSDEVOP_pci_device_add”, VPCI handler for the config space
access is added to the Xen to emulate the PCI devices config space.

A MMIO trap handler for the PCI ECAM space is registered in XEN
so that when guest is trying to access the PCI config space,XEN
will trap the access and emulate read/write using the VPCI and
not the real PCI hardware.

For Dom0less systems scan_pci_devices() would be used to discover the
PCI device in XEN and VPCI handler will be added during XEN boots.

This patch is also doing some small fixes to fix compilation errors on
arm32 of vpci and prevent 64bit accesses on 32bit:
- use %zu instead of lu in header.c for print
- prevent 64bit accesses in vpci_access_allowed
- ifdef out using CONFIG_64BIT handling of len 8 in
vpci_ecam_{read/write}

Signed-off-by: Rahul Singh <rahul.singh@arm.com>
Signed-off-by: Bertrand Marquis <bertrand.marquis@arm.com>
---
Changes in v7:
- adapt to changes in vpci generic functions (name and type)
- remove call to pci_cleanup_msi on error exit
- move pci_add_handlers to be only done when pdev->domain is not NULL
- Remove cast to unsigned long in header.c and use %zu for print
- Fix non ascii chars in arch-arm.h
- Use CONFIG_64BIT inside vpci_access_allowed to prevent 64bit access on
32bit platforms
- Use CONFIG_64BIT to compile out 64bit cases in vpci_ecam_{read/write}
Changes in v6:
- Use new vpci_ecam_ helpers for PCI access
- Do not set XEN_DOMCTL_CDF_vpci for dom0 for now (will be done in a
future patch once everything is ready)
- rename REGISTER_OFFSET to ECAM_REG_OFFSET and move it to pci.h
- remove not needed local variables in vpci_mmio_write, the one in read
has been kept to ensure proper compilation on arm32
- move call to vpci_add_handlers before iommu init to simplify exit path
- move call to pci_cleanup_msi in the out section of pci_add_device if
pdev is not NULL and on error
- initialize pdev to NULL to handle properly exit path call of
pci_cleanup_msi
- keep has_vpci to return false for now as CFG_vpci has been removed.
Added a comment on top of the definition.
- fix compilation errors on arm32 (print in header.c, cast missing in
mmio_write.
- local variable was kept in vpci_mmio_read on arm to prevent a cast
error in arm32.
Change in v5:
- Add pci_cleanup_msi(pdev) incleanup part.
- Added Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
Change in v4:
- Move addition of XEN_DOMCTL_CDF_vpci flag to separate patch
Change in v3:
- Use is_pci_passthrough_enabled() in place of pci_passthrough_enabled variable
- Reject XEN_DOMCTL_CDF_vpci for x86 in arch_sanitise_domain_config()
- Remove IS_ENABLED(CONFIG_HAS_VPCI) from has_vpci()
Change in v2:
- Add new XEN_DOMCTL_CDF_vpci flag
- modify has_vpci() to include XEN_DOMCTL_CDF_vpci
- enable vpci support when pci-passthough option is enabled.
---
---
 xen/arch/arm/Makefile         |  1 +
 xen/arch/arm/domain.c         |  4 ++
 xen/arch/arm/vpci.c           | 77 +++++++++++++++++++++++++++++++++++
 xen/arch/arm/vpci.h           | 36 ++++++++++++++++
 xen/drivers/passthrough/pci.c | 14 +++++++
 xen/drivers/vpci/header.c     |  2 +-
 xen/drivers/vpci/vpci.c       | 10 +++++
 xen/include/asm-arm/domain.h  |  1 +
 xen/include/public/arch-arm.h |  7 ++++
 xen/include/xen/pci.h         |  2 +
 10 files changed, 153 insertions(+), 1 deletion(-)
 create mode 100644 xen/arch/arm/vpci.c
 create mode 100644 xen/arch/arm/vpci.h

diff --git a/xen/arch/arm/Makefile b/xen/arch/arm/Makefile
index 64518848b2..07f634508e 100644
--- a/xen/arch/arm/Makefile
+++ b/xen/arch/arm/Makefile
@@ -7,6 +7,7 @@ ifneq ($(CONFIG_NO_PLAT),y)
 obj-y += platforms/
 endif
 obj-$(CONFIG_TEE) += tee/
+obj-$(CONFIG_HAS_VPCI) += vpci.o
 
 obj-$(CONFIG_HAS_ALTERNATIVE) += alternative.o
 obj-y += bootfdt.init.o
diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
index eef0661beb..96e1b23550 100644
--- a/xen/arch/arm/domain.c
+++ b/xen/arch/arm/domain.c
@@ -39,6 +39,7 @@
 #include <asm/vgic.h>
 #include <asm/vtimer.h>
 
+#include "vpci.h"
 #include "vuart.h"
 
 DEFINE_PER_CPU(struct vcpu *, curr_vcpu);
@@ -773,6 +774,9 @@ int arch_domain_create(struct domain *d,
     if ( is_hardware_domain(d) && (rc = domain_vuart_init(d)) )
         goto fail;
 
+    if ( (rc = domain_vpci_init(d)) != 0 )
+        goto fail;
+
     return 0;
 
 fail:
diff --git a/xen/arch/arm/vpci.c b/xen/arch/arm/vpci.c
new file mode 100644
index 0000000000..a312d02f3d
--- /dev/null
+++ b/xen/arch/arm/vpci.c
@@ -0,0 +1,77 @@
+/*
+ * xen/arch/arm/vpci.c
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+#include <xen/sched.h>
+#include <xen/vpci.h>
+
+#include <asm/mmio.h>
+
+static int vpci_mmio_read(struct vcpu *v, mmio_info_t *info,
+                          register_t *r, void *p)
+{
+    pci_sbdf_t sbdf;
+    /* data is needed to prevent a pointer cast on 32bit */
+    unsigned long data;
+
+    /* We ignore segment part and always handle segment 0 */
+    sbdf.sbdf = VCPI_ECAM_BDF(info->gpa);
+
+    if ( vpci_ecam_read(sbdf, ECAM_REG_OFFSET(info->gpa),
+                        1U << info->dabt.size, &data) )
+    {
+        *r = data;
+        return 1;
+    }
+
+    *r = ~0ul;
+
+    return 0;
+}
+
+static int vpci_mmio_write(struct vcpu *v, mmio_info_t *info,
+                           register_t r, void *p)
+{
+    pci_sbdf_t sbdf;
+
+    /* We ignore segment part and always handle segment 0 */
+    sbdf.sbdf = VCPI_ECAM_BDF(info->gpa);
+
+    return vpci_ecam_write(sbdf, ECAM_REG_OFFSET(info->gpa),
+                           1U << info->dabt.size, r);
+}
+
+static const struct mmio_handler_ops vpci_mmio_handler = {
+    .read  = vpci_mmio_read,
+    .write = vpci_mmio_write,
+};
+
+int domain_vpci_init(struct domain *d)
+{
+    if ( !has_vpci(d) )
+        return 0;
+
+    register_mmio_handler(d, &vpci_mmio_handler,
+                          GUEST_VPCI_ECAM_BASE, GUEST_VPCI_ECAM_SIZE, NULL);
+
+    return 0;
+}
+
+/*
+ * Local variables:
+ * mode: C
+ * c-file-style: "BSD"
+ * c-basic-offset: 4
+ * indent-tabs-mode: nil
+ * End:
+ */
+
diff --git a/xen/arch/arm/vpci.h b/xen/arch/arm/vpci.h
new file mode 100644
index 0000000000..d8a7b0e3e8
--- /dev/null
+++ b/xen/arch/arm/vpci.h
@@ -0,0 +1,36 @@
+/*
+ * xen/arch/arm/vpci.h
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+
+#ifndef __ARCH_ARM_VPCI_H__
+#define __ARCH_ARM_VPCI_H__
+
+#ifdef CONFIG_HAS_VPCI
+int domain_vpci_init(struct domain *d);
+#else
+static inline int domain_vpci_init(struct domain *d)
+{
+    return 0;
+}
+#endif
+
+#endif /* __ARCH_ARM_VPCI_H__ */
+
+/*
+ * Local variables:
+ * mode: C
+ * c-file-style: "BSD"
+ * c-basic-offset: 4
+ * indent-tabs-mode: nil
+ * End:
+ */
diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci.c
index 3aa8c3175f..082892c8a2 100644
--- a/xen/drivers/passthrough/pci.c
+++ b/xen/drivers/passthrough/pci.c
@@ -766,7 +766,21 @@ int pci_add_device(u16 seg, u8 bus, u8 devfn,
         list_add(&pdev->domain_list, &hardware_domain->pdev_list);
     }
     else
+    {
+#ifdef CONFIG_ARM
+        /*
+         * On ARM PCI devices discovery will be done by Dom0. Add vpci handler
+         * when Dom0 inform XEN to add the PCI devices in XEN.
+         */
+        ret = vpci_add_handlers(pdev);
+        if ( ret )
+        {
+            printk(XENLOG_ERR "Setup of vPCI failed: %d\n", ret);
+            goto out;
+        }
+#endif
         iommu_enable_device(pdev);
+    }
 
     pci_enable_acs(pdev);
 
diff --git a/xen/drivers/vpci/header.c b/xen/drivers/vpci/header.c
index f8cd55e7c0..40ff79c33f 100644
--- a/xen/drivers/vpci/header.c
+++ b/xen/drivers/vpci/header.c
@@ -373,7 +373,7 @@ static void bar_write(const struct pci_dev *pdev, unsigned int reg,
         /* If the value written is the current one avoid printing a warning. */
         if ( val != (uint32_t)(bar->addr >> (hi ? 32 : 0)) )
             gprintk(XENLOG_WARNING,
-                    "%pp: ignored BAR %lu write with memory decoding enabled\n",
+                    "%pp: ignored BAR %zu write with memory decoding enabled\n",
                     &pdev->sbdf, bar - pdev->vpci->header.bars + hi);
         return;
     }
diff --git a/xen/drivers/vpci/vpci.c b/xen/drivers/vpci/vpci.c
index ef690f15a9..decf7d87a1 100644
--- a/xen/drivers/vpci/vpci.c
+++ b/xen/drivers/vpci/vpci.c
@@ -485,6 +485,12 @@ bool vpci_access_allowed(unsigned int reg, unsigned int len)
     if ( len != 1 && len != 2 && len != 4 && len != 8 )
         return false;
 
+#ifndef CONFIG_64BIT
+    /* Prevent 64bit accesses on 32bit */
+    if ( len == 8 )
+        return false;
+#endif
+
     /* Check that access is size aligned. */
     if ( (reg & (len - 1)) )
         return false;
@@ -500,8 +506,10 @@ bool vpci_ecam_write(pci_sbdf_t sbdf, unsigned int reg, unsigned int len,
         return false;
 
     vpci_write(sbdf, reg, min(4u, len), data);
+#ifdef CONFIG_64BIT
     if ( len == 8 )
         vpci_write(sbdf, reg + 4, 4, data >> 32);
+#endif
 
     return true;
 }
@@ -526,8 +534,10 @@ bool vpci_ecam_read(pci_sbdf_t sbdf, unsigned int reg, unsigned int len,
      *  4byte accesses.
      */
     *data = vpci_read(sbdf, reg, min(4u, len));
+#ifdef CONFIG_64BIT
     if ( len == 8 )
         *data |= (uint64_t)vpci_read(sbdf, reg + 4, 4) << 32;
+#endif
 
     return true;
 }
diff --git a/xen/include/asm-arm/domain.h b/xen/include/asm-arm/domain.h
index 14e575288f..9b3647587a 100644
--- a/xen/include/asm-arm/domain.h
+++ b/xen/include/asm-arm/domain.h
@@ -263,6 +263,7 @@ static inline void arch_vcpu_block(struct vcpu *v) {}
 
 #define arch_vm_assist_valid_mask(d) (1UL << VMASST_TYPE_runstate_update_flag)
 
+/* vPCI is not available on Arm */
 #define has_vpci(d)    ({ (void)(d); false; })
 
 #endif /* __ASM_DOMAIN_H__ */
diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h
index 96ead3de07..b4c615bcdf 100644
--- a/xen/include/public/arch-arm.h
+++ b/xen/include/public/arch-arm.h
@@ -418,6 +418,13 @@ typedef uint64_t xen_callback_t;
 #define GUEST_GICV3_GICR0_BASE     xen_mk_ullong(0x03020000) /* vCPU0..127 */
 #define GUEST_GICV3_GICR0_SIZE     xen_mk_ullong(0x01000000)
 
+/*
+ * 256 MB is reserved for VPCI configuration space based on calculation
+ * 256 buses x 32 devices x 8 functions x 4 KB = 256 MB
+ */
+#define GUEST_VPCI_ECAM_BASE    xen_mk_ullong(0x10000000)
+#define GUEST_VPCI_ECAM_SIZE    xen_mk_ullong(0x10000000)
+
 /* ACPI tables physical address */
 #define GUEST_ACPI_BASE xen_mk_ullong(0x20000000)
 #define GUEST_ACPI_SIZE xen_mk_ullong(0x02000000)
diff --git a/xen/include/xen/pci.h b/xen/include/xen/pci.h
index 70ac25345c..b6d7e454f8 100644
--- a/xen/include/xen/pci.h
+++ b/xen/include/xen/pci.h
@@ -40,6 +40,8 @@
 #define PCI_SBDF3(s,b,df) \
     ((pci_sbdf_t){ .sbdf = (((s) & 0xffff) << 16) | PCI_BDF2(b, df) })
 
+#define ECAM_REG_OFFSET(addr)  ((addr) & 0x00000fff)
+
 typedef union {
     uint32_t sbdf;
     struct {
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Fri Oct 15 13:59:49 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 13:59:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.210640.367609 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbNkT-0002eF-0U; Fri, 15 Oct 2021 13:59:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 210640.367609; Fri, 15 Oct 2021 13:59:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbNkS-0002e4-TI; Fri, 15 Oct 2021 13:59:48 +0000
Received: by outflank-mailman (input) for mailman id 210640;
 Fri, 15 Oct 2021 13:59:46 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Fqmt=PD=arm.com=bertrand.marquis@srs-us1.protection.inumbo.net>)
 id 1mbNkQ-0002KR-Fj
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 13:59:46 +0000
Received: from foss.arm.com (unknown [217.140.110.172])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTP
 id 2769dd60-2dc0-11ec-8237-12813bfff9fa;
 Fri, 15 Oct 2021 13:59:46 +0000 (UTC)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C94F8147A;
 Fri, 15 Oct 2021 06:59:45 -0700 (PDT)
Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com
 [10.1.199.62])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 78E733F694;
 Fri, 15 Oct 2021 06:59:44 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2769dd60-2dc0-11ec-8237-12813bfff9fa
From: Bertrand Marquis <bertrand.marquis@arm.com>
To: xen-devel@lists.xenproject.org
Cc: iwj@xenproject.org,
	Rahul Singh <rahul.singh@arm.com>,
	Wei Liu <wl@xen.org>,
	Anthony PERARD <anthony.perard@citrix.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Michal Orzel <michal.orzel@arm.com>
Subject: [PATCH v7 5/5] arm/libxl: Emulated PCI device tree node in libxl
Date: Fri, 15 Oct 2021 14:59:22 +0100
Message-Id: <4a22121e6474adfb1c5166e0fdaddff47c6dae46.1634305870.git.bertrand.marquis@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <cover.1634305870.git.bertrand.marquis@arm.com>
References: <cover.1634305870.git.bertrand.marquis@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Rahul Singh <rahul.singh@arm.com>

libxl will create an emulated PCI device tree node in the device tree to
enable the guest OS to discover the virtual PCI during guest boot.
Emulated PCI device tree node will only be created when there is any
device assigned to guest.

A new area has been reserved in the arm guest physical map at
which the VPCI bus is declared in the device tree (reg and ranges
parameters of the node).

Note that currently we are using num_pcidevs instead of
c_info->passthrough to decide whether to create a vPCI DT node.
This will be insufficient if and when ARM does PCI hotplug.
Add this note inside libxl_create.c where c_info->passthrough
is set.

Signed-off-by: Rahul Singh <rahul.singh@arm.com>
Signed-off-by: Michal Orzel <michal.orzel@arm.com>
---
Changes in v7:
-remove arch_arm.vpci
-create vpci DT note if (d_config->num_pcidevs)
Changes in v6:
According to https://marc.info/?l=xen-devel&m=163415838129479&w=2:
-do not set XEN_DOMCTL_CDF_vpci
-do not enable VPCI support (by setting b_info.arch_arm.vpci)
-do not define LIBXL_HAVE_BUILDINFO_ARM_VPCI
-keep b_info.arch_arm.vpci, make_vpci_node and its helpers
Change in v5:
- Move setting the arch_arm.vpci and XEN_DOMCTL_CDF_vpci to libxl_arm.c
Change in v4:
- Gate code for x86 for setting the XEN_DOMCTL_CDF_vpci for x86.
Change in v3:
- Make GUEST_VPCI_MEM_ADDR address 2MB aligned
Change in v2:
- enable doamin_vpci_init() when XEN_DOMCTL_CDF_vpci is set for domain.
---
---
 tools/libs/light/libxl_arm.c    | 103 ++++++++++++++++++++++++++++++++
 tools/libs/light/libxl_create.c |   5 ++
 xen/include/public/arch-arm.h   |  10 ++++
 3 files changed, 118 insertions(+)

diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c
index fdae129605..eef1de0939 100644
--- a/tools/libs/light/libxl_arm.c
+++ b/tools/libs/light/libxl_arm.c
@@ -284,6 +284,59 @@ static int fdt_property_reg_placeholder(libxl__gc *gc, void *fdt,
     return fdt_property(fdt, "reg", regs, sizeof(regs));
 }
 
+static int fdt_property_values(libxl__gc *gc, void *fdt,
+                               const char *name,
+                               unsigned num_cells, ...)
+{
+    uint32_t prop[num_cells];
+    be32 *cells = &prop[0];
+    int i;
+    va_list ap;
+    uint32_t arg;
+
+    va_start(ap, num_cells);
+    for (i = 0 ; i < num_cells; i++) {
+        arg = va_arg(ap, uint32_t);
+        set_cell(&cells, 1, arg);
+    }
+    va_end(ap);
+
+    return fdt_property(fdt, name, prop, sizeof(prop));
+}
+
+static int fdt_property_vpci_ranges(libxl__gc *gc, void *fdt,
+                                    unsigned addr_cells,
+                                    unsigned size_cells,
+                                    unsigned num_regs, ...)
+{
+    uint32_t regs[num_regs*((addr_cells*2)+size_cells+1)];
+    be32 *cells = &regs[0];
+    int i;
+    va_list ap;
+    uint64_t arg;
+
+    va_start(ap, num_regs);
+    for (i = 0 ; i < num_regs; i++) {
+        /* Set the memory bit field */
+        arg = va_arg(ap, uint32_t);
+        set_cell(&cells, 1, arg);
+
+        /* Set the vpci bus address */
+        arg = addr_cells ? va_arg(ap, uint64_t) : 0;
+        set_cell(&cells, addr_cells , arg);
+
+        /* Set the cpu bus address where vpci address is mapped */
+        set_cell(&cells, addr_cells, arg);
+
+        /* Set the vpci size requested */
+        arg = size_cells ? va_arg(ap, uint64_t) : 0;
+        set_cell(&cells, size_cells, arg);
+    }
+    va_end(ap);
+
+    return fdt_property(fdt, "ranges", regs, sizeof(regs));
+}
+
 static int make_root_properties(libxl__gc *gc,
                                 const libxl_version_info *vers,
                                 void *fdt)
@@ -687,6 +740,53 @@ static int make_vpl011_uart_node(libxl__gc *gc, void *fdt,
     return 0;
 }
 
+static int make_vpci_node(libxl__gc *gc, void *fdt,
+                          const struct arch_info *ainfo,
+                          struct xc_dom_image *dom)
+{
+    int res;
+    const uint64_t vpci_ecam_base = GUEST_VPCI_ECAM_BASE;
+    const uint64_t vpci_ecam_size = GUEST_VPCI_ECAM_SIZE;
+    const char *name = GCSPRINTF("pcie@%"PRIx64, vpci_ecam_base);
+
+    res = fdt_begin_node(fdt, name);
+    if (res) return res;
+
+    res = fdt_property_compat(gc, fdt, 1, "pci-host-ecam-generic");
+    if (res) return res;
+
+    res = fdt_property_string(fdt, "device_type", "pci");
+    if (res) return res;
+
+    res = fdt_property_regs(gc, fdt, GUEST_ROOT_ADDRESS_CELLS,
+            GUEST_ROOT_SIZE_CELLS, 1, vpci_ecam_base, vpci_ecam_size);
+    if (res) return res;
+
+    res = fdt_property_values(gc, fdt, "bus-range", 2, 0, 255);
+    if (res) return res;
+
+    res = fdt_property_cell(fdt, "#address-cells", 3);
+    if (res) return res;
+
+    res = fdt_property_cell(fdt, "#size-cells", 2);
+    if (res) return res;
+
+    res = fdt_property_string(fdt, "status", "okay");
+    if (res) return res;
+
+    res = fdt_property_vpci_ranges(gc, fdt, GUEST_ROOT_ADDRESS_CELLS,
+        GUEST_ROOT_SIZE_CELLS, 2,
+        GUEST_VPCI_ADDR_TYPE_MEM, GUEST_VPCI_MEM_ADDR, GUEST_VPCI_MEM_SIZE,
+        GUEST_VPCI_ADDR_TYPE_PREFETCH_MEM, GUEST_VPCI_PREFETCH_MEM_ADDR,
+        GUEST_VPCI_PREFETCH_MEM_SIZE);
+    if (res) return res;
+
+    res = fdt_end_node(fdt);
+    if (res) return res;
+
+    return 0;
+}
+
 static const struct arch_info *get_arch_info(libxl__gc *gc,
                                              const struct xc_dom_image *dom)
 {
@@ -991,6 +1091,9 @@ next_resize:
         if (info->tee == LIBXL_TEE_TYPE_OPTEE)
             FDT( make_optee_node(gc, fdt) );
 
+        if (d_config->num_pcidevs)
+            FDT( make_vpci_node(gc, fdt, ainfo, dom) );
+
         if (pfdt)
             FDT( copy_partial_fdt(gc, fdt, pfdt) );
 
diff --git a/tools/libs/light/libxl_create.c b/tools/libs/light/libxl_create.c
index 6ebb2bfc76..5a61d01722 100644
--- a/tools/libs/light/libxl_create.c
+++ b/tools/libs/light/libxl_create.c
@@ -1096,6 +1096,11 @@ int libxl__domain_config_setdefault(libxl__gc *gc,
         goto error_out;
     }
 
+    /*
+     * Note: libxl_arm directly examines num_pcidevs to decide whether
+     * to create a vPCI DT node, rather than using c_info->passthrough.
+     * This will be insufficient if and when ARM does PCI hotplug.
+     */
     bool need_pt = d_config->num_pcidevs || d_config->num_dtdevs;
     if (c_info->passthrough == LIBXL_PASSTHROUGH_DEFAULT) {
         c_info->passthrough = need_pt
diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h
index b4c615bcdf..94b31511dd 100644
--- a/xen/include/public/arch-arm.h
+++ b/xen/include/public/arch-arm.h
@@ -433,6 +433,11 @@ typedef uint64_t xen_callback_t;
 #define GUEST_PL011_BASE    xen_mk_ullong(0x22000000)
 #define GUEST_PL011_SIZE    xen_mk_ullong(0x00001000)
 
+/* Guest PCI-PCIe memory space where config space and BAR will be available.*/
+#define GUEST_VPCI_ADDR_TYPE_MEM            xen_mk_ullong(0x02000000)
+#define GUEST_VPCI_MEM_ADDR                 xen_mk_ullong(0x23000000)
+#define GUEST_VPCI_MEM_SIZE                 xen_mk_ullong(0x10000000)
+
 /*
  * 16MB == 4096 pages reserved for guest to use as a region to map its
  * grant table in.
@@ -453,6 +458,11 @@ typedef uint64_t xen_callback_t;
 #define GUEST_RAM0_BASE   xen_mk_ullong(0x40000000) /* 3GB of low RAM @ 1GB */
 #define GUEST_RAM0_SIZE   xen_mk_ullong(0xc0000000)
 
+/* 4GB @ 4GB Prefetch Memory for VPCI */
+#define GUEST_VPCI_ADDR_TYPE_PREFETCH_MEM   xen_mk_ullong(0x42000000)
+#define GUEST_VPCI_PREFETCH_MEM_ADDR        xen_mk_ullong(0x100000000)
+#define GUEST_VPCI_PREFETCH_MEM_SIZE        xen_mk_ullong(0x100000000)
+
 #define GUEST_RAM1_BASE   xen_mk_ullong(0x0200000000) /* 1016GB of RAM @ 8GB */
 #define GUEST_RAM1_SIZE   xen_mk_ullong(0xfe00000000)
 
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Fri Oct 15 13:59:52 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 13:59:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.210641.367620 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbNkW-00031O-BH; Fri, 15 Oct 2021 13:59:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 210641.367620; Fri, 15 Oct 2021 13:59:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbNkW-000313-6f; Fri, 15 Oct 2021 13:59:52 +0000
Received: by outflank-mailman (input) for mailman id 210641;
 Fri, 15 Oct 2021 13:59:51 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Fqmt=PD=arm.com=bertrand.marquis@srs-us1.protection.inumbo.net>)
 id 1mbNkV-00020z-7I
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 13:59:51 +0000
Received: from foss.arm.com (unknown [217.140.110.172])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTP
 id 2d922a5b-17a9-464d-bd3e-0963b84be3d7;
 Fri, 15 Oct 2021 13:59:43 +0000 (UTC)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2AAB4147A;
 Fri, 15 Oct 2021 06:59:43 -0700 (PDT)
Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com
 [10.1.199.62])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 452D23F694;
 Fri, 15 Oct 2021 06:59:42 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2d922a5b-17a9-464d-bd3e-0963b84be3d7
From: Bertrand Marquis <bertrand.marquis@arm.com>
To: xen-devel@lists.xenproject.org
Cc: iwj@xenproject.org,
	Michal Orzel <michal.orzel@arm.com>,
	Wei Liu <wl@xen.org>,
	Anthony PERARD <anthony.perard@citrix.com>,
	Juergen Gross <jgross@suse.com>
Subject: [PATCH v7 3/5] tools/libxl: Modify libxl__arch_domain_init_hw_description...
Date: Fri, 15 Oct 2021 14:59:20 +0100
Message-Id: <a8cbb1887c1419625dd01d5360a1ff0aaee21b55.1634305870.git.bertrand.marquis@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <cover.1634305870.git.bertrand.marquis@arm.com>
References: <cover.1634305870.git.bertrand.marquis@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Michal Orzel <michal.orzel@arm.com>

... to take a second argument of type libxl_domain_config*
rather than libxl_domain_build_info*.

We need to pass the whole libxl_domain_config
structure as this will be needed later on to modify
the libxl__prepare_dtb function to also take
libxl_domain_config.

Signed-off-by: Michal Orzel <michal.orzel@arm.com>
Suggested-by: Ian Jackson <iwj@xenproject.org>
---
 tools/libs/light/libxl_arch.h | 2 +-
 tools/libs/light/libxl_arm.c  | 3 ++-
 tools/libs/light/libxl_dom.c  | 2 +-
 tools/libs/light/libxl_x86.c  | 2 +-
 4 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/tools/libs/light/libxl_arch.h b/tools/libs/light/libxl_arch.h
index 8527fc5c6c..1522ecb97f 100644
--- a/tools/libs/light/libxl_arch.h
+++ b/tools/libs/light/libxl_arch.h
@@ -38,7 +38,7 @@ int libxl__arch_domain_create(libxl__gc *gc,
 /* setup arch specific hardware description, i.e. DTB on ARM */
 _hidden
 int libxl__arch_domain_init_hw_description(libxl__gc *gc,
-                                           libxl_domain_build_info *info,
+                                           libxl_domain_config *d_config,
                                            libxl__domain_build_state *state,
                                            struct xc_dom_image *dom);
 /* finalize arch specific hardware description. */
diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c
index a7801558cf..d5771f98dd 100644
--- a/tools/libs/light/libxl_arm.c
+++ b/tools/libs/light/libxl_arm.c
@@ -1016,12 +1016,13 @@ out:
 }
 
 int libxl__arch_domain_init_hw_description(libxl__gc *gc,
-                                           libxl_domain_build_info *info,
+                                           libxl_domain_config *d_config,
                                            libxl__domain_build_state *state,
                                            struct xc_dom_image *dom)
 {
     int rc;
     uint64_t val;
+    libxl_domain_build_info *const info = &d_config->b_info;
 
     if (info->type != LIBXL_DOMAIN_TYPE_PVH) {
         LOG(ERROR, "Unsupported Arm guest type %s",
diff --git a/tools/libs/light/libxl_dom.c b/tools/libs/light/libxl_dom.c
index e9f58ee4b2..fe9f760f71 100644
--- a/tools/libs/light/libxl_dom.c
+++ b/tools/libs/light/libxl_dom.c
@@ -571,7 +571,7 @@ static int libxl__build_dom(libxl__gc *gc, uint32_t domid,
         LOG(ERROR, "xc_dom_parse_image failed");
         goto out;
     }
-    if ( (ret = libxl__arch_domain_init_hw_description(gc, info, state, dom)) != 0 ) {
+    if ( (ret = libxl__arch_domain_init_hw_description(gc, d_config, state, dom)) != 0 ) {
         LOGE(ERROR, "libxl__arch_domain_init_hw_description failed");
         goto out;
     }
diff --git a/tools/libs/light/libxl_x86.c b/tools/libs/light/libxl_x86.c
index 6083878315..1feadebb18 100644
--- a/tools/libs/light/libxl_x86.c
+++ b/tools/libs/light/libxl_x86.c
@@ -568,7 +568,7 @@ int libxl__arch_extra_memory(libxl__gc *gc,
 }
 
 int libxl__arch_domain_init_hw_description(libxl__gc *gc,
-                                           libxl_domain_build_info *info,
+                                           libxl_domain_config *d_config,
                                            libxl__domain_build_state *state,
                                            struct xc_dom_image *dom)
 {
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Fri Oct 15 13:59:57 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 13:59:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.210644.367631 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbNkb-0003Zs-MV; Fri, 15 Oct 2021 13:59:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 210644.367631; Fri, 15 Oct 2021 13:59:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbNkb-0003Zh-Hf; Fri, 15 Oct 2021 13:59:57 +0000
Received: by outflank-mailman (input) for mailman id 210644;
 Fri, 15 Oct 2021 13:59:56 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Fqmt=PD=arm.com=bertrand.marquis@srs-us1.protection.inumbo.net>)
 id 1mbNka-00020z-7U
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 13:59:56 +0000
Received: from foss.arm.com (unknown [217.140.110.172])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTP
 id 3be2732e-6ea7-4ff9-a604-330bc3adcd15;
 Fri, 15 Oct 2021 13:59:44 +0000 (UTC)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4403014BF;
 Fri, 15 Oct 2021 06:59:44 -0700 (PDT)
Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com
 [10.1.199.62])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5E9A03F694;
 Fri, 15 Oct 2021 06:59:43 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3be2732e-6ea7-4ff9-a604-330bc3adcd15
From: Bertrand Marquis <bertrand.marquis@arm.com>
To: xen-devel@lists.xenproject.org
Cc: iwj@xenproject.org,
	Michal Orzel <michal.orzel@arm.com>,
	Wei Liu <wl@xen.org>,
	Anthony PERARD <anthony.perard@citrix.com>,
	Juergen Gross <jgross@suse.com>
Subject: [PATCH v7 4/5] tools/libxl_arm: Modify libxl__prepare_dtb...
Date: Fri, 15 Oct 2021 14:59:21 +0100
Message-Id: <a016279b31ad0b0801bb8cd36c0b84c95db0bd09.1634305870.git.bertrand.marquis@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <cover.1634305870.git.bertrand.marquis@arm.com>
References: <cover.1634305870.git.bertrand.marquis@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Michal Orzel <michal.orzel@arm.com>

... to take a second argument of type libxl_domain_config*
rather than libxl_domain_build_info*.

This change will be needed to get access from
libxl__prepare_dtb to "num_pcidevs" field of
libxl_domain_config to check whether to create
a vPCI DT node or not.

Signed-off-by: Michal Orzel <michal.orzel@arm.com>
Suggested-by: Ian Jackson <iwj@xenproject.org>
---
 tools/libs/light/libxl_arm.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c
index d5771f98dd..fdae129605 100644
--- a/tools/libs/light/libxl_arm.c
+++ b/tools/libs/light/libxl_arm.c
@@ -878,7 +878,7 @@ static int copy_partial_fdt(libxl__gc *gc, void *fdt, void *pfdt)
 
 #define FDT_MAX_SIZE (1<<20)
 
-static int libxl__prepare_dtb(libxl__gc *gc, libxl_domain_build_info *info,
+static int libxl__prepare_dtb(libxl__gc *gc, libxl_domain_config *d_config,
                               libxl__domain_build_state *state,
                               struct xc_dom_image *dom)
 {
@@ -887,6 +887,7 @@ static int libxl__prepare_dtb(libxl__gc *gc, libxl_domain_build_info *info,
     int rc, res;
     size_t fdt_size = 0;
     int pfdt_size = 0;
+    libxl_domain_build_info *const info = &d_config->b_info;
 
     const libxl_version_info *vers;
     const struct arch_info *ainfo;
@@ -1042,7 +1043,7 @@ int libxl__arch_domain_init_hw_description(libxl__gc *gc,
     if (rc)
         return rc;
 
-    rc = libxl__prepare_dtb(gc, info, state, dom);
+    rc = libxl__prepare_dtb(gc, d_config, state, dom);
     if (rc) goto out;
 
     if (!libxl_defbool_val(info->acpi)) {
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Fri Oct 15 14:07:52 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 14:07:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.210676.367642 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbNsC-0006IA-Cn; Fri, 15 Oct 2021 14:07:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 210676.367642; Fri, 15 Oct 2021 14:07:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbNsC-0006I3-9m; Fri, 15 Oct 2021 14:07:48 +0000
Received: by outflank-mailman (input) for mailman id 210676;
 Fri, 15 Oct 2021 14:07:47 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=YWEc=PD=arm.com=Luca.Fancellu@srs-us1.protection.inumbo.net>)
 id 1mbNlT-00020z-9S
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 14:00:51 +0000
Received: from EUR05-AM6-obe.outbound.protection.outlook.com (unknown
 [2a01:111:f400:7e1b::624])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 9a07e0c3-9b87-4de3-b537-013db65077d6;
 Fri, 15 Oct 2021 14:00:47 +0000 (UTC)
Received: from DB6P191CA0022.EURP191.PROD.OUTLOOK.COM (2603:10a6:6:28::32) by
 DB9PR08MB7115.eurprd08.prod.outlook.com (2603:10a6:10:2c8::5) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.16; Fri, 15 Oct 2021 14:00:43 +0000
Received: from DB5EUR03FT058.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:6:28:cafe::63) by DB6P191CA0022.outlook.office365.com
 (2603:10a6:6:28::32) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.25 via Frontend
 Transport; Fri, 15 Oct 2021 14:00:43 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT058.mail.protection.outlook.com (10.152.20.255) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.15 via Frontend Transport; Fri, 15 Oct 2021 14:00:43 +0000
Received: ("Tessian outbound f1898412aff1:v103");
 Fri, 15 Oct 2021 14:00:43 +0000
Received: from 646f281e39fb.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 9A46B6CC-C3C3-49B3-A354-15CE6714070C.1; 
 Fri, 15 Oct 2021 14:00:32 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 646f281e39fb.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 15 Oct 2021 14:00:32 +0000
Received: from PAXPR08MB6816.eurprd08.prod.outlook.com (2603:10a6:102:130::10)
 by PR2PR08MB4892.eurprd08.prod.outlook.com (2603:10a6:101:24::15)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.17; Fri, 15 Oct
 2021 14:00:29 +0000
Received: from PAXPR08MB6816.eurprd08.prod.outlook.com
 ([fe80::c1b4:db1c:376f:b697]) by PAXPR08MB6816.eurprd08.prod.outlook.com
 ([fe80::c1b4:db1c:376f:b697%8]) with mapi id 15.20.4608.017; Fri, 15 Oct 2021
 14:00:29 +0000
Received: from smtpclient.apple (82.8.129.65) by
 LO2P123CA0021.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:a6::33) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.16 via Frontend Transport; Fri, 15 Oct 2021 14:00:28 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9a07e0c3-9b87-4de3-b537-013db65077d6
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=FoPwl1Fpwipzy4xVQrWJajg9fFL6J9cj58tmr0JHQnM=;
 b=UauxhzbZRPXD9SyRk7xcJPpjf58cJiGNOE2j7mX5slqH84YC48vpujp8g2WucwbVQbpim40+E6XGeq4cqpu+E0uSNXsAZ5t+JhzWvq/GqcVdScYcxlrfAWmtYaGYFNcsZAXYv4njn+VYkEgOFToi8Ea9fa4oM5wYJ6scxjcLDx0=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 276e0a3b289fe71b
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=eTytjeNInz7DhJg7usOmdiOqRA5rttB3DYOBXk2T3ePhXhYr/BTsr3/3pjjxL9vYSceX9rKgTkZHTQ0nLcNLJ+kaDt4DB0y/M+qoTqZjjo/TsboZP3Oc72KzDjzGhu70bHoT/MkgciPdkmf+FwxvrzWX+3va+WuwrbcyUAtQ1ItYTmoh3pkbMOXAiv5Rt/wbeOhrFIeq/YXhFGs6cNpYYjqY9O113s7QkUCjF4WpV6gC5mIQlfdGXyyDhcFNIuMapfmMqkhbg8TinQaelXhkPvfJTw0cnUleFomLrifLOsLUMgtJDM3HNOF02eH1fP+un0K59zaYlAVSdnmyjvgi8g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=FoPwl1Fpwipzy4xVQrWJajg9fFL6J9cj58tmr0JHQnM=;
 b=TYcvH6qOP91UJpPPpvyGciYVeA9IMzkr/CpY8mCW+p5pyeFmt1oX5HS37uxwFdL04bEsMsCNKUN0ZTnro3ugCtPmQvSQv8xTZ9WB4Z5Fpj/BVKitVQHYEM4OWH3VrCb+O+jQ9DQfYC3eoxl2fD6Mxms8sS6dd8SSrJinDZUwRc71/zuk3/hM275lYHY3qJLblPMSN4W025pfm/QCGhJdQlC6HgImsipjq8KKmDBvYvMiZM5PvcGznybuFtkLwdrKFiaz6NCaLV9UZzZwjhOeLtZvUH508kIYqK0EN5B8wnJphJiVNXy+w5YcIbJAae4DWGoqbMRQF9YnXS3scoM2ag==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=FoPwl1Fpwipzy4xVQrWJajg9fFL6J9cj58tmr0JHQnM=;
 b=UauxhzbZRPXD9SyRk7xcJPpjf58cJiGNOE2j7mX5slqH84YC48vpujp8g2WucwbVQbpim40+E6XGeq4cqpu+E0uSNXsAZ5t+JhzWvq/GqcVdScYcxlrfAWmtYaGYFNcsZAXYv4njn+VYkEgOFToi8Ea9fa4oM5wYJ6scxjcLDx0=
Authentication-Results-Original: citrix.com; dkim=none (message not signed)
 header.d=none;citrix.com; dmarc=none action=none header.from=arm.com;
Content-Type: text/plain;
	charset=utf-8
Subject: Re: [PATCH v6 2/3] xen/arm: Enable the existing x86 virtual PCI
 support for ARM.
From: Luca Fancellu <luca.fancellu@arm.com>
In-Reply-To: <YWmGbzPdCxmwfdIX@MacBook-Air-de-Roger.local>
Date: Fri, 15 Oct 2021 15:00:21 +0100
Cc: Bertrand Marquis <Bertrand.Marquis@arm.com>,
 Jan Beulich <jbeulich@suse.com>,
 Xen-devel <xen-devel@lists.xenproject.org>,
 Ian Jackson <iwj@xenproject.org>,
 Rahul Singh <Rahul.Singh@arm.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Julien Grall <julien@xen.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Wei Liu <wl@xen.org>,
 Paul Durrant <paul@xen.org>,
 Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
Content-Transfer-Encoding: quoted-printable
Message-Id: <90FEC0F8-A5CA-4B7F-8E94-38223FE3F6D2@arm.com>
References: <cover.1634221830.git.bertrand.marquis@arm.com>
 <396b08e2598cf0338e0c7f4ad3cd5cb66db89224.1634221830.git.bertrand.marquis@arm.com>
 <YWk8uP/YuSee1MfG@MacBook-Air-de-Roger.local>
 <CD9B29B0-31FD-4E09-93E3-7124C724BC23@arm.com>
 <1c298c02-5791-8935-f996-516da2409f24@suse.com>
 <BFC005A8-4C72-41C5-93F4-98BB9CBAB198@arm.com>
 <cd81cc31-617c-c750-01f4-b02bcb9e3a9e@suse.com>
 <B57498FA-F205-4DC1-ACE0-414558400293@arm.com>
 <YWmGbzPdCxmwfdIX@MacBook-Air-de-Roger.local>
To: =?utf-8?Q?Roger_Pau_Monn=C3=A9?= <roger.pau@citrix.com>
X-Mailer: Apple Mail (2.3654.120.0.1.13)
X-ClientProxiedBy: LO2P123CA0021.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:a6::33) To PAXPR08MB6816.eurprd08.prod.outlook.com
 (2603:10a6:102:130::10)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 65a440e5-8d5f-4883-0567-08d98fe42df8
X-MS-TrafficTypeDiagnostic: PR2PR08MB4892:|DB9PR08MB7115:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS:
	<DB9PR08MB71151FF5012A6A6625EE769EE4B99@DB9PR08MB7115.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 US716nvkSayxs1Y0mxuDgxUOmEn3NhYR2TEKKpdrP69ODspq5469ttfi9elJUX2gq+fZCmantjtfiapVtxbfk9ZTOCUnhGOWx45b5ZvvoWh1v17yBDyaxv+2MWc/f/5QS3YXvfnKNFiNwixseHuhgxCl5bWcSRgo6ZAG8bzyzH2RSzcf9wpFuVmUJ6LmKjenTBvfza3c5ajEK67LPNDBCe0liAhfFSdDCENMbDHZeWgvX5IRL2/1afji1v4Nr/KJvlsQWw6x0M9kWnnHYrcUcRs1EQZZjdeZcTxhnfWA/mZK76eJlO5uyc1e22t6SkKFktBfhYbwJobkkPLEbkaDts1a1hB/w9fH0+vsZyBSAKOehQOkhrmywNurykEQ2a97J3B+PkE+kjASa8Uj84xANgooc7EDQYP+VULvcNwvJNlIU4iaPf0DofdM3zmYwimGHknVthiVeVWwkI6nqQGwpfBrbkkPXnTsDexfuugFrI4YLKa0rQu/rn8ICjQf897gXqcRCURN8WSlmo8vavyMpchKHkvoObQR4fNb6sBVVW+xtCVhCEz8FU0YbfhepL85Yh6kLA0DUBbN8Bo9AWsqyDSBATSMoC6Ih9gCQKYk83iQUQagw9Zq/6LReBjkZbr65F3KJR2NVO++4UEcSUgUbfM/pTBUZ3hBcJ394lJcn1rGt0y/n2Beb2x7Q5At0g7Fy+0PumJnnYUPdd8Yx5VBQCl5Ftpk0jEGKfwk51XHjx8=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB6816.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(53546011)(54906003)(6486002)(6506007)(8936002)(86362001)(52116002)(7416002)(8676002)(4326008)(508600001)(316002)(26005)(6916009)(36756003)(6512007)(83380400001)(186003)(5660300002)(6666004)(66476007)(2906002)(66556008)(33656002)(38350700002)(66946007)(38100700002)(44832011)(956004)(2616005)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR2PR08MB4892
Original-Authentication-Results: citrix.com; dkim=none (message not signed)
 header.d=none;citrix.com; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT058.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	b2bcac0b-9dc2-4422-07f0-08d98fe4250d
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	0vmlJasXEIlIP1YmFhgjIYBwlFDDMir3eL3Yu1VidER/It9WBuwmb6ZnVzqSh/Yxc5t2frmrpj2dGLplbrYFIR1NAfVrDxRsHLNV6Fe3s09vP6aX9hZCClpi6G08whUJruKAh2qrGC9PBdgy3OVD8iedYoR2nG14zfW0/3iH89vVcuPGcNVUTk3IwvQI4t88g8HcA1ItO5Qw6A+N9NICtum+elrWrl8Eqv0MF1m4GjliWEd96rKTn2ELv6+KcYyn+spKAPgONUoS5o6x5imxyJXbAe7D20hlQSS4PghMGmgM9zI1mRbcI536se8z0j2zwNsYiRSO2BDTAx7LO+9tq5cn/evebOZmMM0m3FzAjYKDrXr+ZUaQp5odnjLOaWc8Iyp5TIK9KM2CFjh1FM4GZ46BVG4V7XFSToxdpygTUXKEOlFYJ47fBrah2J5brpKO8DVvpyKtwBHdLCUyu85DWUZyAiI2W71ZvHW5dGxKjuAOK8BKmcYEfCsuiixfViHHgzbLXt/3vt7aerIToe0vcSj5fMB2HZFv/7S4+agOtjtSzZO/v5LfWfOHN7e3ocXrVgzp17Nx4VdsjAhrkLJgtPdVm/pjuNDE0QWfIF0miqlclGylt4FhXs42okouhqZ6Z5HwuBAMle9k9etVp8aEMlgGDAKvPLuWzjQio94sF/uKnth7n5y4yfP5rK8BPZwnW2cwIQhx9cZaR8sOAB7H4g==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(36860700001)(4326008)(6486002)(6666004)(81166007)(186003)(36756003)(70206006)(6512007)(6862004)(107886003)(356005)(336012)(70586007)(86362001)(2616005)(26005)(44832011)(2906002)(5660300002)(956004)(8676002)(53546011)(8936002)(54906003)(33656002)(47076005)(508600001)(316002)(6506007)(82310400003)(83380400001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2021 14:00:43.6100
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 65a440e5-8d5f-4883-0567-08d98fe42df8
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT058.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB7115



> On 15 Oct 2021, at 14:47, Roger Pau Monn=C3=A9 <roger.pau@citrix.com> wro=
te:
>=20
> On Fri, Oct 15, 2021 at 10:48:41AM +0000, Bertrand Marquis wrote:
>> Hi Jan,
>>=20
>>> On 15 Oct 2021, at 11:41, Jan Beulich <jbeulich@suse.com> wrote:
>>>=20
>>> On 15.10.2021 12:33, Bertrand Marquis wrote:
>>>>> On 15 Oct 2021, at 11:24, Jan Beulich <jbeulich@suse.com> wrote:
>>>>> On 15.10.2021 11:52, Bertrand Marquis wrote:
>>>>>>> On 15 Oct 2021, at 09:32, Roger Pau Monn=C3=A9 <roger.pau@citrix.co=
m> wrote:
>>>>>>> On Thu, Oct 14, 2021 at 03:49:50PM +0100, Bertrand Marquis wrote:
>>>>>>>> @@ -752,6 +752,19 @@ int pci_add_device(u16 seg, u8 bus, u8 devfn,
>>>>>>>>=20
>>>>>>>>  check_pdev(pdev);
>>>>>>>>=20
>>>>>>>> +#ifdef CONFIG_ARM
>>>>>>>> +    /*
>>>>>>>> +     * On ARM PCI devices discovery will be done by Dom0. Add vpc=
i handler when
>>>>>>>> +     * Dom0 inform XEN to add the PCI devices in XEN.
>>>>>>>> +     */
>>>>>>>> +    ret =3D vpci_add_handlers(pdev);
>>>>>>>> +    if ( ret )
>>>>>>>> +    {
>>>>>>>> +        printk(XENLOG_ERR "Setup of vPCI failed: %d\n", ret);
>>>>>>>> +        goto out;
>>>>>>>> +    }
>>>>>>>> +#endif
>>>>>>>=20
>>>>>>> I think vpci_add_handlers should be called after checking that
>>>>>>> pdev->domain is !=3D NULL, so I would move this chunk a bit below.
>>>>>>=20
>>>>>> On arm this would prevent the dom0less use case or to have the PCI
>>>>>> bus enumerated from an other domain.
>>>>>> @oleksandr: can you comment on this one, you might have a better
>>>>>> answer than me on this ?
>>>>>=20
>>>>> Well, without Xen doing the enumeration, some other entity would need
>>>>> to do so, including the reporting to Xen. Obviously without a Dom0 it
>>>>> would be ambiguous which domain to assign the device to; perhaps it
>>>>> should be the caller in this case? That would make that caller domain
>>>>> a pseudo-hwdom though, as far as PCI is concerned, which may not be
>>>>> desirable according to my (limited) understanding of dom0less.
>>>>=20
>>>> This is not really related to this patch but the plan is the following=
:
>>>> - enumeration would have to be done by the firmware or boot loader bef=
ore
>>>> - xen will have some code to detect PCI devices
>>>> - dom0less can be used to assign PCI devices to guest
>>>>=20
>>>> Anyway does not change the fact that this must be called when domain i=
s
>>>> not NULL and I will fix that.
>>>=20
>>> Since we now all seem to agree that the NULL would have been a problem,
>>> may I ask in how far any of this has actually been tested?
>>=20
>> With the whole serie currently on gitlab we have extensively tested pass=
ing
>> through PCI devices on Arm in several configuration (number of device, M=
SI,
>> MSI-X) and check that PCI was still functional on x86.
>>=20
>> With the patches pushed to Xen right now it was checked that:
>> - xen compiles properly on arm32, arm64 and x86
>> - xen compiles properly with VPCI activated (using a patch) on arm32 and=
 arm64
>> - xen on x86 is functionnal (using basic test on QEMU)
>> - xen on arm64 is functionnal (with some extensive tests on different ta=
rgets)
>=20
> I thinks it's unlikely, but since I haven't checked myself, could you
> see if the vpci user-space test harness (tools/tests/vpci) still
> builds and functions properly?

Hi Roger,

Bertrand is going to send the v7, however I=E2=80=99m keen to do this test =
but unfortunately
I=E2=80=99ve never used it before and I don=E2=80=99t have an x86 environme=
nt, do you have any
resource that I can read or some guidance?

Cheers,
Luca

>=20
> Thanks, Roger.
>=20



From xen-devel-bounces@lists.xenproject.org Fri Oct 15 14:17:56 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 14:17:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.210692.367653 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbO1s-0007nk-D3; Fri, 15 Oct 2021 14:17:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 210692.367653; Fri, 15 Oct 2021 14:17:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbO1s-0007nd-A3; Fri, 15 Oct 2021 14:17:48 +0000
Received: by outflank-mailman (input) for mailman id 210692;
 Fri, 15 Oct 2021 14:17:46 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=UM5E=PD=citrix.com=roger.pau@srs-us1.protection.inumbo.net>)
 id 1mbO1q-0007nT-MI
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 14:17:46 +0000
Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id aa0efcc6-2dc2-11ec-823d-12813bfff9fa;
 Fri, 15 Oct 2021 14:17:45 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: aa0efcc6-2dc2-11ec-823d-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1634307464;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=X+CM9WWEl8W22qiK6sD30MnmK66/ALVNwYYQ+V9I66A=;
  b=ewZxzH8UcJhPaGvGmvjIv6FDGZKSt5uuc9i5bqms0fgDYerC37w5sie2
   g/VAiK+gYVRIxKqdfi9/ibh13dWdwxzT/M4nF5fLp2yxxYvoSjNG+p4Oe
   AJYOIGiy+a8t5QXyk+W2UhJ70SXrT0eZgbZD1OznoptJasWnhKZX2qQ+K
   E=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: KkAKFokib1zOJ+ZfDwH32cjGMsBT6arnbbOvLhbYZd+58vcC0r/zdnobvrkjD5rBRud3fsRncX
 kFRcTNdtX6yKnBV2JM2paVWHS6WRGNmBhNIClta+/7IzQCExeATkNCu0K8WrQfqGftPQSvX5aB
 cfRW3cPAbiMFFyy+4WVG0ig0hY+gmPLEFAp76WJrXECQaYKIU18e6Z+pLOvwyZEzcYQ4VZxmOa
 LBuQO323DwvaYyYuGeVd39VZrDqd/BSAPiLg7mVFXuJc/86QkyloAU+X1bAwhB5M/pxkBRiStx
 WBYOuZAj6w2xamLQT811+yyF
X-SBRS: 5.1
X-MesageID: 55690843
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:Za4x8Kk7tYquD6ruwTADZ/vo5gweIURdPkR7XQ2eYbSJt1+Wr1Gzt
 xIdXW+Daf2KZmWjedpxbtzjoRwF7Z6HyddrGQZu/yFnRSMWpZLJC+rCIxarNUt+DCFioGGLT
 Sk6QoOdRCzhZiaE/n9BClVlxJVF/fngqoDUUYYoAQgsA185IMsdoUg7wbdg2tc12YHR7z6l4
 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc
 s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4
 OlQ6rOqT1oFBbbRn8AeCwYIFTBYZZQTrdcrIVDn2SCS50jPcn+qyPRyFkAme4Yf/46bA0kXq
 6ZecmpUKEne2aTmm9pXScE17ignBNPsM44F/Glp0BnSDOo8QICFSKLPjTNd9Gpt2JEWTaqFD
 yYfQSdGdi2QORheA21JOs4Up8utpmjBKiIN/Tp5ooJoujOOnWSdyoPFKNPIfvSaSMMTmVyXz
 krE9WnkBhARNPSE1CGItHmrg4fngifTSI8UUrqi+ZZCilCJ2nYaDhFQUFKhuOS4kWa3QdcZI
 EsRkgI+oK53+EG1Q93VWxyjvGXCrhMaQ8BXEeAx9EeK0KW8yweGBEAUQzhZctskucQqAzsw2
 Te0c8jBXGI19ufPEDTEq+nS/Wja1TUpwXEqWTJbYhEDvvXYu5w0qhGXUYZlAYjtt4igcd3v+
 AyioC87jrQVqMcE0aSn4FzK6w6RSoj1oh0dvVqPADr0hu9tTMv8PdbwsAmEhRpVBN/BFgHpg
 ZQSpySJAAni57m2nyuRXP5FIrit4/uUWNE3qQ8yR8d/n9hBFnjKQGyx3N2cDBs2WirnUWWwC
 KM2he+3zMQOVJdNRfUmC79d8+xwkcDd+S3ND5g4lOZmbJlrbxOg9ypzf0OW1G2FuBFyyv1lY
 s3ALJ/8Vyhy5UFbINyeHLp1PVgDnXhW+I8ubcqjk0TPPUS2NRZ5tovpwHPRN7tkvctoUS3e8
 spFNtvi9vmseLaWX8UjyqZKdQpiBSFiXfje8pULHsbeclsOMDxwUJf5nOJ+E7GJaowIz48kC
 FnmARQGoLc+7FWaQTi3hodLM+2yA8wm9ixmZETB/z+AghAeXGpm149GH7Mfdrg77u1zi/lyS
 vgOYcKbBfpTDD/A/lwggVPV8OSOrTyn2lCDOTSLej86c8IyTgDF4Ia8LADu6DMPHmy8ss5n+
 ++s0QbSQJwiQQV+DZmJNKLzng3p5XVNyvhvW0boI8VIfBm++oZdNCGs3OQ8JNsBKEufy2LCh
 RqWGxoRucLEv5QxrIvSnamBoorwS7l+E0NWEnP197GzMSWGrGOvzZUZCLSDfCzHVXOy86KnP
 L0Hw/b5OfwBvVBLr4sjTOo7kfNgv4Pi/uYIwB5lEXPHa0WQJolhenTWj9NSsqBtx6NCvVfkU
 Ey45dQHa66CP9noEQBNKVN9PPiDz/wdhhLb8e8xfBfh/CZy8beKDRdSMh2LhHAPJbd5Ktp4k
 +IoucpQ4A2jkBs6dN2Bi3kMpWiLK3UBVYQht40bX9C32lZ6lAkabMyOEDLy7bGOd85IYxsjL
 TKjjabfg6hRmxjZeH0pGHmRhedQiPziYvyRIIPu87hRpuf4uw==
IronPort-HdrOrdr: A9a23:bC7U46yXxUL3MpPuaojEKrPxveskLtp133Aq2lEZdPULSKOlfp
 GV8MjziyWYtN9wYhAdcdDpAtjmfZr5z+8O3WB3B8beYOCGghrSEGgG1+XfKlLbak/DH4JmpM
 Jdmu1FeaHN5DtB/LfHCWuDYq8dKbC8mcjC74eurAYccegpUdAZ0+4QMHfkLqQcfnghOXNWLu
 v52iIRzADQBkj/I/7LS0UtbqzmnZnmhZjmaRkJC1oO7xSPtyqh7PrfHwKD1hkTfjtTyfN6mF
 K13DDR1+GGibWW2xXc32jc49B/n8bg8MJKAIiphtIOIjvhpw60bMBKWqGEvhoyvOazgWxa3O
 XkklMFBYBe+nnRdma6rV/E3BTh6i8n7zvYxVqRkRLY0ITEbQN/L/AEqZNScxPf5UZllsp7yr
 h302WQsIcSJQ/cnQzmjuK4Fy1Cpw6Rmz4PgOQTh3tQXc81c7lKt7ES+0tTDdMpAD/60oY6C+
 NjZfuspcq+SWnqLUwxg1MfheBFBh8Ib1O7qwk5y4KoOgFt7TNEJxBy/r1Zop8CnKhNAqWsqd
 60dJiBOdl1P7srhJlGdZU8qP2MexrwqCL3QRGvyGvcZdQ60lL22tXKCeYOlauXkKJh9upEpH
 2GaiIAiVIP
X-IronPort-AV: E=Sophos;i="5.85,375,1624334400"; 
   d="scan'208";a="55690843"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=TFOY+eu1A6VNMCj7cUI3TqhJh5ZFe5VGMSkBz+Ykdtk8r1UXg8C1txXqM3R7KphvKv2GdmS3WdlnGGi/36iuTFnso1hdJOE4HYoNZfqfQ5Dzh2UW0qdbpYP3JnrEtsVqk1qy6ZfLyUNAgD/ErLaIL2D+kAcicwwT/msmG/sBQcbLBHDOIiuEIsU2AeAKTUqjtLuXZT/LVKRtRUkQFbCUaJWg23rn3K/BzvZKt+BedJG46e32MgoVzHCPzyX6+m7diHudTbjFbc1bmJqYAXWgMwre7n/BQVdkSYP/hUysQYt1P7bLvLUWDeoiQd21p/FN4WWb0B4s5txPycNYNpGi6w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=qTqxUtnqHnu6/MFHf4+rmAddRe2Lb+QYfkfKY0fUZHs=;
 b=KExcHtRrkGreyOaxQG/S3wBssDYAKwdCBGSzIYYKOg7X+muGkk3LdWxcbds3Kd+ws+NwSx2Zejo/ZdElTjwvfFCTKPAPD7mL0yoqTVxpRxTgVZaWRAnqaOc/biGADku7etm17k7+vJXbx7XW32kpfcQLjJp/2hnAFpT7scDClSdT+gCKUQ+J81srCHrfapeBuDy/0ng5o8vDEeI+2pZ1szwJsX4IwZtKxeA+I/ltA+bSMX/0twLuDD6JKqno8tvaAYpY/2ML3wqY0V/gAf+P6YALkwpykBOBYj91e4cDa0I5DwcJ5v3q/iZTs/kyinu5NU8V9rHxgVsHP8nJQ/s4sw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=qTqxUtnqHnu6/MFHf4+rmAddRe2Lb+QYfkfKY0fUZHs=;
 b=uIcg6I871FiQcsPAiCA3uUTwTszwnkwXA1TduCdm0lVB33yJ+YE4W+sRB/tK4SaYpI7eXRUJ9dOZYBnnS2rQHegBjohpcD9n/ZTeQFiRpIw9ADdDefmcWwrRdslqdqrHxJUVOT5tG2K6CEsPd+y2Td282/w0/wsNX7/QK5k8KJs=
Date: Fri, 15 Oct 2021 16:17:29 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Bertrand Marquis <bertrand.marquis@arm.com>
CC: <xen-devel@lists.xenproject.org>, <iwj@xenproject.org>, Paul Durrant
	<paul@xen.org>, Jan Beulich <jbeulich@suse.com>, Andrew Cooper
	<andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH v7 1/5] xen/vpci: Move ecam access functions to common
 code
Message-ID: <YWmNeWSdmcbKNdSh@MacBook-Air-de-Roger.local>
References: <cover.1634305870.git.bertrand.marquis@arm.com>
 <bac1cc0d06dffc8f00233ea31233080bae8868aa.1634305870.git.bertrand.marquis@arm.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <bac1cc0d06dffc8f00233ea31233080bae8868aa.1634305870.git.bertrand.marquis@arm.com>
X-ClientProxiedBy: LO2P265CA0504.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:13b::11) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 75cf156b-e79e-4b12-02b6-08d98fe6886e
X-MS-TrafficTypeDiagnostic: DM5PR03MB2972:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <DM5PR03MB29724CCEC4FAA1C5FC71099E8FB99@DM5PR03MB2972.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: GYKuqzLc3v0Zqh42v7tXlaW6B4Hr6Rs8YnVkKq2YQPGs36mA9uuf+hiiKfSfW+gO+Qwh8SlceYYw6emj3Xv3osyl3QNija6fngLFQzEwA28PNjJsQ9OYBZacY5v0CzAoecf4A34gvlF+c16uw3KqLIZg+J84XHejT9mEgaxiwJ1D8Js5SjzUluG9tWYw2cuirNwpJeknEnref7/Fe8w19ESX/vnKQ5BCfIzNBNjHh4Y8iyxMpaqtaDTVZ+yHOM6JK9VjFWd6r+hfdQEBgZ4e2R+c0rUj9TRUnj13thegDOdvAAcX4DGglUPy6iPKbfTg7E98nvADrMWas6rIJTZIcclQvd2Mbxkd3BGJwtuu6fh31XChqv0DpvrpE0athQucsqV0Z6f8uxqwSew7XWx2rm3nUlQ4XmJeuHWuE8iPnwsHJg8fkelLBEW7Hxx0liXVfr3orBDh54Bm0zT72g8FSBpQpH55e6/z/6a3g2AnTVCStqtY4hWAgYJeXCBQDEwWlImsGKV/zdK1zPEAos3xo+WqhTXaD9m/9ndo7L4FDHKtscLErDnoEk7nV2mzEQ+VSVl3gk0GRmBKRfU9NhX1S/3LKntj+Ug0o0FEPhjzj7G2ndBMWGMZC00UnEAyshhvJVd4fdS+XBsxZj8ffpmROn3MyTHEy7CILG8m53/3ncxRllyH38F47e48Y66BZJetVDFCAXNYj+1pxzq6z2bZfwQ5wfHg4wmqGH81tb1BcXM=
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(5660300002)(316002)(6916009)(2906002)(4326008)(508600001)(6486002)(38100700002)(9686003)(26005)(66946007)(6496006)(86362001)(85182001)(966005)(83380400001)(82960400001)(66556008)(54906003)(956004)(66476007)(186003)(8676002)(8936002)(6666004);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZUFwbnZuOEwyc0p4a2w2S0JLTlJ3YTdVd2lEUWFpaklrQVl5TnZuanR6OHk5?=
 =?utf-8?B?RnhneVFTS1J6Z2lKelpZNlptV3YrUFN0Y3p2YURKNU54cno1ajdKbVFoUHJo?=
 =?utf-8?B?bG5zSVZHYW96ZmxMMWllOFdOOStmY1lpRkFoMU9VdXdGUkpRdGR6cEc0Wnp5?=
 =?utf-8?B?aXZlUktiRjI1ZW9wR2RYVjlWVjk2T1JNbG5tekhEckFJVFloeGY1cG5yQUR0?=
 =?utf-8?B?Zi9MRi96ZXdzK3hjbXBsMGlSd3NmT1ZSa0JjSnJVWWVqZkphTFNQb2U2S0xz?=
 =?utf-8?B?TFNKSkM0My9RTHB5enp4cVAwWnI1dHFRakJrd1lwVFA2ZE5yTjVuLzBtWnVT?=
 =?utf-8?B?Ulhhbi8rRndFa2FWYUp6NDVsam4zR0U4RGlaVWJXd1BhbGhpVHk1N0VwdEpl?=
 =?utf-8?B?LzJHYS92Tm5ndDJxK1FGV0M1dEZVeElLSmpIYWt3dTk0YTBtYVJrb0Q1N0l5?=
 =?utf-8?B?eHQ5QlZ4a2EvUlJ1bUNLaXhJTHo3VjZKNm5pdU0yRjBEc2wrdVJ3TE81WWF2?=
 =?utf-8?B?Skg0ZUplb3ZqTTRlQmxwSWxRTElrSjR5T0o0YVMxbUZsS0dWSlBrN0w1QVVQ?=
 =?utf-8?B?VlRHc01tSkFidUxQMDA1N2pnQW9yZlBHWVpielhZeDREN3daTGN1NjlHN0dl?=
 =?utf-8?B?ME8wTnZIYm9WNjc1QTh5clhKanpkSjhucTVrdFdUNGZNMDBSaXlxcHhzU0Vt?=
 =?utf-8?B?Z00zc1dXMDYrOVNwTjQ0MTZUT0xCLytZaVFQODZPNVFlVjdBYXN4MXJjNGJl?=
 =?utf-8?B?S3FmRW9KK0I2d2Q1YUU1VU1NcjBwVnBhdUkwc0xVc1kxUTgrWUJFeTQ2VWhZ?=
 =?utf-8?B?K2lWbEZCMTBwZUFSbWo4OEJycG51N3VFU2lsUmVndVROcmZwZTk4VnUwcGtj?=
 =?utf-8?B?MEJ3MXovVEhodHhaNkVtbXlBSWlManhKNzFIRUpaWllpRVBGbU12bWxDcXhT?=
 =?utf-8?B?MnlrQzlJazhmWGdpaGoxaFFBRW5SS2dsQXpIYmNaTUNSUTNsVzJHVkF2cG1l?=
 =?utf-8?B?aVUzMGRidlNXT1hNazZNOXcvTlRBUUNKMTdzMFBobi9WSElqYS9ERVRJR1ZO?=
 =?utf-8?B?TDM5TDVxQ2JwVFc5VTh0MlE2MkJJaDFYTE0ybVNxYTh5VHVTTW85L0FpaS94?=
 =?utf-8?B?R015dzVVSzUyVVNIbFFyREsyUHk3V0dJamZoZUEyaHgwaE1DNjNOeWdUbnI4?=
 =?utf-8?B?NVRHdWNxRlNHRkxRQXdVbWQ3WHVLZk40bUo2Mmo2aXFReWd4MDA5dzU4ZlNP?=
 =?utf-8?B?d045d3M5WjBWTDQwclFEMEZTbEN2c05zTWxnQjZuTkp0bHFCd3dWdFpOQzYz?=
 =?utf-8?B?SmhuTnVQeVJkeTR1VjlrNVRQU3NSUDlSNmVNbDR4U0oyYkt1V2hEcFFvT3Jm?=
 =?utf-8?B?dEcyOHhCUjBTbDhWSG51a0JJSzJodkVRZUZQMUF2dG1JS0htcE10WjZ1dUNn?=
 =?utf-8?B?eDhEOERZaHJTSHdvTkZlNm03dHdneld6QXZwMm83bUx1RjdMa0t2Rnl4MWl1?=
 =?utf-8?B?UFVJblJJUW5JZTNrcE5Ya2JGZmYwdEVXYnpTRFlwREQ0Ky96V1ZOZUJST2tZ?=
 =?utf-8?B?Sk5oWGsvcjlEUHRJVXp0dHlGVG5heHUrd1VxS0cybFUrZm9CczVFUDVmdE1X?=
 =?utf-8?B?dDUvaFdFcXJKSGRnS0xaMHBsNFEvTGhwWG9iUU5XZWVmUHFlZ2swd2x6L3dx?=
 =?utf-8?B?WGRGWWI5OTVWSEQvTDVUSDZyaGhIWkN4T3hYZUZnazJheUNueWpHNUZFdDlF?=
 =?utf-8?Q?I+rUbPy5kHDswHzQ5s03ssOTn4CR0BzSJ+NZU+U?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 75cf156b-e79e-4b12-02b6-08d98fe6886e
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2021 14:17:34.5101
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0tW9/O/PkrPgMAFpPKsH36X3JO2jj0H8Hf4u3NApmSjsokiGtwk/77kvTu7Kd1r7NjXDB3brmze0sqhux18pXw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB2972
X-OriginatorOrg: citrix.com

On Fri, Oct 15, 2021 at 02:59:18PM +0100, Bertrand Marquis wrote:
> PCI standard is using ECAM and not MCFG which is coming from ACPI[1].
> Use ECAM/ecam instead of MCFG in common code and in new functions added
> in common vpci code by this patch.
> 
> Move vpci_access_allowed from arch/x86/hvm/io.c to drivers/vpci/vpci.c.
> 
> Create vpci_ecam_{read,write} in drivers/vpci/vpci.c that
> contains the common code to perform these operations, changed
> vpci_mmcfg_{read,write} accordingly to make use of these functions.
> 
> The vpci_ecam_{read,write} functions are returning false on error and
> true on success. As the x86 code was previously always returning
> X86EMUL_OKAY the return code is ignored. A comment has been added in
> the code to show that this is intentional.

I still wonder how you plan to propagate those errors back to the
guest in a proper way, so I'm dubious whether returning a boolean is
really warranted here, as I don't think raising a CPU fault/abort or
similar on vpci errors in correct. We will see I guess, and the
current behavior for x86 is not changed anyway.

> 
> Those functions will be used in a following patch inside by arm vpci
> implementation.
> 
> Rename MMCFG_BDF to VPCI_ECAM_BDF and move it to vpci.h.
> This macro is only used by functions calling vpci_ecam helpers.
> 
> No functional change intended with this patch.
> 
> [1] https://wiki.osdev.org/PCI_Express
> 
> Suggested-by: Roger Pau Monné <roger.pau@citrix.com>
> Signed-off-by: Bertrand Marquis <bertrand.marquis@arm.com>

Acked-by: Roger Pau Monné <roger.pau@citrix.com>

> ---
> Changes in v7:
> - Rename vpci_ecam_access_allowed to vpci_access_allowed
> - Rename vpci_ecam_mmio_{read/write} to vpci_ecam_{read/write}
> - Replace comment in x86/hvm/io.c with one suggested by Roger
> - Remove 32bit comments and fixes from this patch and move it to the next
> one to keep only the moving+renaming in this patch
> - Change return type of vpci_ecam_{read/write} to bool
> - rename ECAM_BDF to VPCI_ECAM_BDF and move it to vpci.h
> Changes in v6: Patch added
> ---
>  xen/arch/x86/hvm/io.c     | 46 ++++-----------------------------
>  xen/drivers/vpci/vpci.c   | 54 +++++++++++++++++++++++++++++++++++++++
>  xen/include/asm-x86/pci.h |  2 --
>  xen/include/xen/vpci.h    | 12 +++++++++
>  4 files changed, 71 insertions(+), 43 deletions(-)
> 
> diff --git a/xen/arch/x86/hvm/io.c b/xen/arch/x86/hvm/io.c
> index 046a8eb4ed..eb3c80743e 100644
> --- a/xen/arch/x86/hvm/io.c
> +++ b/xen/arch/x86/hvm/io.c
> @@ -260,20 +260,6 @@ unsigned int hvm_pci_decode_addr(unsigned int cf8, unsigned int addr,
>      return CF8_ADDR_LO(cf8) | (addr & 3);
>  }
>  
> -/* Do some sanity checks. */
> -static bool vpci_access_allowed(unsigned int reg, unsigned int len)
> -{
> -    /* Check access size. */
> -    if ( len != 1 && len != 2 && len != 4 && len != 8 )
> -        return false;
> -
> -    /* Check that access is size aligned. */
> -    if ( (reg & (len - 1)) )
> -        return false;
> -
> -    return true;
> -}
> -
>  /* vPCI config space IO ports handlers (0xcf8/0xcfc). */
>  static bool vpci_portio_accept(const struct hvm_io_handler *handler,
>                                 const ioreq_t *p)
> @@ -394,7 +380,7 @@ static unsigned int vpci_mmcfg_decode_addr(const struct hvm_mmcfg *mmcfg,
>                                             paddr_t addr, pci_sbdf_t *sbdf)
>  {
>      addr -= mmcfg->addr;
> -    sbdf->bdf = MMCFG_BDF(addr);
> +    sbdf->bdf = VCPI_ECAM_BDF(addr);
>      sbdf->bus += mmcfg->start_bus;
>      sbdf->seg = mmcfg->segment;
>  
> @@ -434,25 +420,8 @@ static int vpci_mmcfg_read(struct vcpu *v, unsigned long addr,
>      reg = vpci_mmcfg_decode_addr(mmcfg, addr, &sbdf);
>      read_unlock(&d->arch.hvm.mmcfg_lock);
>  
> -    if ( !vpci_access_allowed(reg, len) ||
> -         (reg + len) > PCI_CFG_SPACE_EXP_SIZE )
> -        return X86EMUL_OKAY;
> -
> -    /*
> -     * According to the PCIe 3.1A specification:
> -     *  - Configuration Reads and Writes must usually be DWORD or smaller
> -     *    in size.
> -     *  - Because Root Complex implementations are not required to support
> -     *    accesses to a RCRB that cross DW boundaries [...] software
> -     *    should take care not to cause the generation of such accesses
> -     *    when accessing a RCRB unless the Root Complex will support the
> -     *    access.
> -     *  Xen however supports 8byte accesses by splitting them into two
> -     *  4byte accesses.
> -     */
> -    *data = vpci_read(sbdf, reg, min(4u, len));
> -    if ( len == 8 )
> -        *data |= (uint64_t)vpci_read(sbdf, reg + 4, 4) << 32;
> +    /* Failed reads are not propagated to the caller */
> +    vpci_ecam_read(sbdf, reg, len, data);
>  
>      return X86EMUL_OKAY;
>  }
> @@ -476,13 +445,8 @@ static int vpci_mmcfg_write(struct vcpu *v, unsigned long addr,
>      reg = vpci_mmcfg_decode_addr(mmcfg, addr, &sbdf);
>      read_unlock(&d->arch.hvm.mmcfg_lock);
>  
> -    if ( !vpci_access_allowed(reg, len) ||
> -         (reg + len) > PCI_CFG_SPACE_EXP_SIZE )
> -        return X86EMUL_OKAY;
> -
> -    vpci_write(sbdf, reg, min(4u, len), data);
> -    if ( len == 8 )
> -        vpci_write(sbdf, reg + 4, 4, data >> 32);
> +    /* Failed writes are not propagated to the caller */
> +    vpci_ecam_write(sbdf, reg, len, data);
>  
>      return X86EMUL_OKAY;
>  }
> diff --git a/xen/drivers/vpci/vpci.c b/xen/drivers/vpci/vpci.c
> index cbd1bac7fc..ef690f15a9 100644
> --- a/xen/drivers/vpci/vpci.c
> +++ b/xen/drivers/vpci/vpci.c
> @@ -478,6 +478,60 @@ void vpci_write(pci_sbdf_t sbdf, unsigned int reg, unsigned int size,
>      spin_unlock(&pdev->vpci->lock);
>  }
>  
> +/* Helper function to check an access size and alignment on vpci space. */
> +bool vpci_access_allowed(unsigned int reg, unsigned int len)
> +{
> +    /* Check access size. */
> +    if ( len != 1 && len != 2 && len != 4 && len != 8 )
> +        return false;
> +
> +    /* Check that access is size aligned. */
> +    if ( (reg & (len - 1)) )
> +        return false;
> +
> +    return true;
> +}
> +
> +bool vpci_ecam_write(pci_sbdf_t sbdf, unsigned int reg, unsigned int len,
> +                         unsigned long data)
> +{
> +    if ( !vpci_access_allowed(reg, len) ||
> +         (reg + len) > PCI_CFG_SPACE_EXP_SIZE )
> +        return false;
> +
> +    vpci_write(sbdf, reg, min(4u, len), data);
> +    if ( len == 8 )
> +        vpci_write(sbdf, reg + 4, 4, data >> 32);
> +
> +    return true;
> +}
> +
> +bool vpci_ecam_read(pci_sbdf_t sbdf, unsigned int reg, unsigned int len,
> +                        unsigned long *data)
> +{
> +    if ( !vpci_access_allowed(reg, len) ||
> +         (reg + len) > PCI_CFG_SPACE_EXP_SIZE )
> +        return false;
> +
> +    /*
> +     * According to the PCIe 3.1A specification:
> +     *  - Configuration Reads and Writes must usually be DWORD or smaller
> +     *    in size.
> +     *  - Because Root Complex implementations are not required to support
> +     *    accesses to a RCRB that cross DW boundaries [...] software
> +     *    should take care not to cause the generation of such accesses
> +     *    when accessing a RCRB unless the Root Complex will support the
> +     *    access.
> +     *  Xen however supports 8byte accesses by splitting them into two
> +     *  4byte accesses.
> +     */
> +    *data = vpci_read(sbdf, reg, min(4u, len));
> +    if ( len == 8 )
> +        *data |= (uint64_t)vpci_read(sbdf, reg + 4, 4) << 32;
> +
> +    return true;
> +}
> +
>  /*
>   * Local variables:
>   * mode: C
> diff --git a/xen/include/asm-x86/pci.h b/xen/include/asm-x86/pci.h
> index edd7c3e71a..443f25347d 100644
> --- a/xen/include/asm-x86/pci.h
> +++ b/xen/include/asm-x86/pci.h
> @@ -6,8 +6,6 @@
>  #define CF8_ADDR_HI(cf8) (  ((cf8) & 0x0f000000) >> 16)
>  #define CF8_ENABLED(cf8) (!!((cf8) & 0x80000000))
>  
> -#define MMCFG_BDF(addr)  ( ((addr) & 0x0ffff000) >> 12)
> -
>  #define IS_SNB_GFX(id) (id == 0x01068086 || id == 0x01168086 \
>                          || id == 0x01268086 || id == 0x01028086 \
>                          || id == 0x01128086 || id == 0x01228086 \
> diff --git a/xen/include/xen/vpci.h b/xen/include/xen/vpci.h
> index 9f5b5d52e1..d6cf0baf14 100644
> --- a/xen/include/xen/vpci.h
> +++ b/xen/include/xen/vpci.h
> @@ -19,6 +19,8 @@ typedef int vpci_register_init_t(struct pci_dev *dev);
>  #define VPCI_PRIORITY_MIDDLE    "5"
>  #define VPCI_PRIORITY_LOW       "9"
>  
> +#define VPCI_ECAM_BDF(addr)     (((addr) & 0x0ffff000) >> 12)
> +
>  #define REGISTER_VPCI_INIT(x, p)                \
>    static vpci_register_init_t *const x##_entry  \
>                 __used_section(".data.vpci." p) = x
> @@ -208,6 +210,16 @@ static inline unsigned int vmsix_entry_nr(const struct vpci_msix *msix,
>  {
>      return entry - msix->entries;
>  }
> +
> +/* ECAM mmio read/write helpers */

Nit: comment should likely be below vpci_access_allowed.

> +bool vpci_access_allowed(unsigned int reg, unsigned int len);
> +
> +bool vpci_ecam_write(pci_sbdf_t sbdf, unsigned int reg, unsigned int len,
> +                         unsigned long data);
> +
> +bool vpci_ecam_read(pci_sbdf_t sbdf, unsigned int reg, unsigned int len,
> +                        unsigned long *data);

Nit: the lines containing the overflow parameter are not properly
aligned.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Fri Oct 15 14:22:37 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 14:22:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.210700.367664 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbO6W-0000lO-Va; Fri, 15 Oct 2021 14:22:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 210700.367664; Fri, 15 Oct 2021 14:22:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbO6W-0000lH-SZ; Fri, 15 Oct 2021 14:22:36 +0000
Received: by outflank-mailman (input) for mailman id 210700;
 Fri, 15 Oct 2021 14:22:36 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mbO6W-0000lB-Hv
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 14:22:36 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mbO6W-00062z-Eh
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 14:22:36 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mbO6W-0002Ao-DY
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 14:22:36 +0000
Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89)
 (envelope-from <iwj@xenproject.org>)
 id 1mbO6T-0005xv-27; Fri, 15 Oct 2021 15:22:33 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date
	:Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From;
	bh=CWNgjw5Kka2HzOU9Isjhws3LLFj6Br2+Ld/25dSW/7U=; b=RjLqLLKEIpWnNc666ULAucPZ/k
	fOmLBagOt7BrXchNF0YaU354l6iClI4a8V7RTxI53kUlE/8sIGs7xv78jYlVFVo0EvwepHVbYP/eY
	FIRg2wKcYgG4nadKGIBoqKAdSajzG+SssRcxNcdrnAaX2mLcQ9mPp40rswT6JiONC0mw=;
From: Ian Jackson <iwj@xenproject.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <24937.36520.665618.208731@mariner.uk.xensource.com>
Date: Fri, 15 Oct 2021 15:22:32 +0100
To: Bertrand Marquis <bertrand.marquis@arm.com>
Cc: xen-devel@lists.xenproject.org,
    iwj@xenproject.org,
    Michal Orzel <michal.orzel@arm.com>,
    Wei Liu <wl@xen.org>,
    Anthony PERARD <anthony.perard@citrix.com>,
    Juergen Gross <jgross@suse.com>
Subject: Re: [PATCH v7 4/5] tools/libxl_arm: Modify libxl__prepare_dtb...
In-Reply-To: <a016279b31ad0b0801bb8cd36c0b84c95db0bd09.1634305870.git.bertrand.marquis@arm.com>
References: <cover.1634305870.git.bertrand.marquis@arm.com>
	<a016279b31ad0b0801bb8cd36c0b84c95db0bd09.1634305870.git.bertrand.marquis@arm.com>
X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu)

Bertrand Marquis writes ("[PATCH v7 4/5] tools/libxl_arm: Modify libxl__prepare_dtb..."):
> From: Michal Orzel <michal.orzel@arm.com>
> 
> ... to take a second argument of type libxl_domain_config*
> rather than libxl_domain_build_info*.
> 
> This change will be needed to get access from
> libxl__prepare_dtb to "num_pcidevs" field of
> libxl_domain_config to check whether to create
> a vPCI DT node or not.
> 
> Signed-off-by: Michal Orzel <michal.orzel@arm.com>
> Suggested-by: Ian Jackson <iwj@xenproject.org>

Reviewed-by: Ian Jackson <iwj@xenproject.org>


From xen-devel-bounces@lists.xenproject.org Fri Oct 15 14:23:02 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 14:23:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.210704.367675 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbO6s-0001Eq-7C; Fri, 15 Oct 2021 14:22:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 210704.367675; Fri, 15 Oct 2021 14:22:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbO6s-0001Ej-41; Fri, 15 Oct 2021 14:22:58 +0000
Received: by outflank-mailman (input) for mailman id 210704;
 Fri, 15 Oct 2021 14:22:57 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mbO6r-0001EO-FC
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 14:22:57 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mbO6r-00063T-EV
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 14:22:57 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mbO6r-0002De-DP
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 14:22:57 +0000
Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89)
 (envelope-from <iwj@xenproject.org>)
 id 1mbO6n-0005yU-Qp; Fri, 15 Oct 2021 15:22:53 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date
	:Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From;
	bh=dArCr4gRo2Loq6+rCDAXZV1g/hPXnLtC05jGQwQpanA=; b=zI7KgKTm8JzVsS3hhoEkGHwrqw
	sBrKCRmKmfMzxiSWFHT9hz0647KxjCA063VzletO2DzQPliqULt40+mEe8mP88I6pwMjFObXIsaJE
	uy6R+05KlPWqKSp+Hc5Wvbaoe6aXEX17CoAJhB08kqULbQ1QkSQFom649WUjjClj2ROc=;
From: Ian Jackson <iwj@xenproject.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <24937.36541.583459.117880@mariner.uk.xensource.com>
Date: Fri, 15 Oct 2021 15:22:53 +0100
To: Bertrand Marquis <bertrand.marquis@arm.com>
Cc: xen-devel@lists.xenproject.org,
    iwj@xenproject.org,
    Michal Orzel <michal.orzel@arm.com>,
    Wei Liu <wl@xen.org>,
    Anthony PERARD <anthony.perard@citrix.com>,
    Juergen Gross <jgross@suse.com>
Subject: Re: [PATCH v7 3/5] tools/libxl: Modify libxl__arch_domain_init_hw_description...
In-Reply-To: <a8cbb1887c1419625dd01d5360a1ff0aaee21b55.1634305870.git.bertrand.marquis@arm.com>
References: <cover.1634305870.git.bertrand.marquis@arm.com>
	<a8cbb1887c1419625dd01d5360a1ff0aaee21b55.1634305870.git.bertrand.marquis@arm.com>
X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu)

Bertrand Marquis writes ("[PATCH v7 3/5] tools/libxl: Modify libxl__arch_domain_init_hw_description..."):
> From: Michal Orzel <michal.orzel@arm.com>
> 
> ... to take a second argument of type libxl_domain_config*
> rather than libxl_domain_build_info*.
> 
> We need to pass the whole libxl_domain_config
> structure as this will be needed later on to modify
> the libxl__prepare_dtb function to also take
> libxl_domain_config.

Reviewed-by: Ian Jackson <iwj@xenproject.org>


From xen-devel-bounces@lists.xenproject.org Fri Oct 15 14:23:53 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 14:23:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.210711.367685 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbO7k-0001uB-G9; Fri, 15 Oct 2021 14:23:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 210711.367685; Fri, 15 Oct 2021 14:23:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbO7k-0001u4-D3; Fri, 15 Oct 2021 14:23:52 +0000
Received: by outflank-mailman (input) for mailman id 210711;
 Fri, 15 Oct 2021 14:23:51 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=esao=PD=suse.com=jgross@srs-us1.protection.inumbo.net>)
 id 1mbO7j-0001tL-2c
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 14:23:51 +0000
Received: from smtp-out1.suse.de (unknown [195.135.220.28])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 042695fc-66cb-4f53-ad70-0e2994bddac3;
 Fri, 15 Oct 2021 14:23:50 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 6570B21A63;
 Fri, 15 Oct 2021 14:23:49 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 2C2DE13C29;
 Fri, 15 Oct 2021 14:23:49 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id HLWqCfWOaWEsSgAAMHmgww
 (envelope-from <jgross@suse.com>); Fri, 15 Oct 2021 14:23:49 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 042695fc-66cb-4f53-ad70-0e2994bddac3
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1634307829; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=BtWnqO2+fgTq9PT/WsY2DMNetpY4LZOLwwE5wpQvswc=;
	b=t4hHeBQw+9aaLnZM1lNScSiCdTdiFEACcHFKc23QCCTOBc0Lez9+9CUY+9PYeMM1Atg3Ed
	g4+DE46K6YhClBPWTTjNscpkpC4BSzZviyuEMwp11AZWQ0NOGcRQ9ObOWyYdcfMWQAyzPn
	xc8nMjuTD+nW6WhZK1UoWOyA0qvyR74=
To: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>, Wei Liu
 <wl@xen.org>, George Dunlap <george.dunlap@citrix.com>,
 Ian Jackson <iwj@xenproject.org>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, xen-devel@lists.xenproject.org
References: <20211015125152.25198-1-jgross@suse.com>
 <20211015125152.25198-9-jgross@suse.com>
 <460a149d-8d54-679a-1af8-694d7ee1ac01@suse.com>
From: Juergen Gross <jgross@suse.com>
Subject: Re: [PATCH 08/12] x86/pv-shim: don't modify hypercall table
Message-ID: <4592bb70-3a91-8dc1-0921-0801a0ef18d3@suse.com>
Date: Fri, 15 Oct 2021 16:23:48 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <460a149d-8d54-679a-1af8-694d7ee1ac01@suse.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="oluKzkFK6OUFxTk4npzrqaljOnuQQNrXC"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--oluKzkFK6OUFxTk4npzrqaljOnuQQNrXC
Content-Type: multipart/mixed; boundary="qHjbyJwnGq8KfMTCHmCNJK7AwUHrkm4eT";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>, Wei Liu
 <wl@xen.org>, George Dunlap <george.dunlap@citrix.com>,
 Ian Jackson <iwj@xenproject.org>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, xen-devel@lists.xenproject.org
Message-ID: <4592bb70-3a91-8dc1-0921-0801a0ef18d3@suse.com>
Subject: Re: [PATCH 08/12] x86/pv-shim: don't modify hypercall table
References: <20211015125152.25198-1-jgross@suse.com>
 <20211015125152.25198-9-jgross@suse.com>
 <460a149d-8d54-679a-1af8-694d7ee1ac01@suse.com>
In-Reply-To: <460a149d-8d54-679a-1af8-694d7ee1ac01@suse.com>

--qHjbyJwnGq8KfMTCHmCNJK7AwUHrkm4eT
Content-Type: multipart/mixed;
 boundary="------------C4488559691535F53432299A"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------C4488559691535F53432299A
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 15.10.21 15:57, Jan Beulich wrote:
> On 15.10.2021 14:51, Juergen Gross wrote:
>> When running as pv-shim the hypercall is modified today in order to
>> replace the functions for __HYPERVISOR_event_channel_op and
>> __HYPERVISOR_grant_table_op hypercalls.
>>
>> Change this to call the related functions from the normal handlers
>> instead when running as shim. The performance implications are not
>> really relevant, as a normal production hypervisor will not be
>> configured to support shim mode, so the related calls will be dropped
>> due to optimization of the compiler.
>>
>> Note that for the CONFIG_PV_SHIM_EXCLUSIVE case there is a dummy
>> wrapper do_grant_table_op() needed, as in this case grant_table.c
>> isn't being built.
>=20
> While you say CONFIG_PV_SHIM_EXCLUSIVE here, ...
>=20
>> @@ -845,6 +822,23 @@ static long pv_shim_grant_table_op(unsigned int c=
md,
>>       return rc;
>>   }
>>  =20
>> +#ifndef CONFIG_GRANT_TABLE
>=20
> ... you don't actually enforce this here. I also don't see why it would=

> be needed in the "exclusive" case only. A binary usable both ways would=

> still need these, wouldn't it?

The "exclusive" case is normally the one where CONFIG_GRANT_TABLE is not
set. I highlighted this as it is a common situation.

>=20
>> +/* Thin wrapper(s) needed. */
>> +long do_grant_table_op(unsigned int cmd, XEN_GUEST_HANDLE_PARAM(void)=
 uop,
>> +                       unsigned int count)
>> +{
>> +    return pv_shim_grant_table_op(cmd, uop, count);
>> +}
>> +
>> +#ifdef CONFIG_PV32
>> +int compat_grant_table_op(unsigned int cmd, XEN_GUEST_HANDLE_PARAM(vo=
id) uop,
>> +                          unsigned int count)
>> +{
>> +    return pv_shim_grant_table_op(cmd, uop, count);
>> +}
>> +#endif
>> +#endif
>=20
> Don't you also need to adjust the respective #ifdef in
> pv_hypercall_table[]? Otherwise I don't see how, at this point of the
> series, the functions would actually get hooked up.

Ah, right.

> In a bi-modal
> binary further guarding will then be needed inside the wrappers, I
> think. (While the table is going to go away, that guarding is going
> to be needed even at the end of this series, I believe.)

Oh, you mean for the weird case of !pv_shim? Yes, I need to return
-ENOSYS in this case.

> Talking of wrappers - do you need actual code to be emitted for this?
> Can't you simply put in place an alias each, which is permitted now
> that pv_shim_grant_table_op() isn't static anymore? (Albeit that's
> partly moot if guarding code gets added to the functions - in that
> case only compat_grant_table_op() could become an alias of
> do_grant_table_op().)

I didn't think of an alias. But I don't think I can make
compat_grant_table_op() an alias of do_grant_table_op(), as they have
different return types.


Juergen

--------------C4488559691535F53432299A
Content-Type: application/pgp-keys;
 name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Transfer-Encoding: quoted-printable
Content-Description: OpenPGP public key
Content-Disposition: attachment;
 filename="OpenPGP_0xB0DE9DD628BF132F.asc"

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy=
cWx
w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O=
f8Z
d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y=
9bf
IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq=
G7/
377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR=
3Jv
c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA=
QIe
AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT=
hpw
dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0=
MbD
1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv=
oPH
Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v=
5QL
+qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ=
2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC=
QoL
BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr=
Wf0
teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC=
/nu
AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh=
ITT
d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm=
XBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz=
80h
SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC=
AcD
AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn=
FOX
gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1=
jnD
kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0=
N51
N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l=
otu
fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1=
tqS
EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA=
hsD
BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3=
g3O
ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5=
dM7
wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5=
D+j
LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm=
V2x
AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N=
Eaw
QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW=
nHI
s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR=
wgn
BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV=
bVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk=
pEd
IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA=
QAB
wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw=
Tbe
8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1=
vJz
Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8=
VGi
wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW=
svi
uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX=
zXs
ZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------C4488559691535F53432299A--

--qHjbyJwnGq8KfMTCHmCNJK7AwUHrkm4eT--

--oluKzkFK6OUFxTk4npzrqaljOnuQQNrXC
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmFpjvQFAwAAAAAACgkQsN6d1ii/Ey8O
kAf/RLaYtnkqPGwRtXUB70O1d5w6mww01Yx6cfTOOmdZsEqaGT0P0LosI5RVArZOrYBIBTYRsvQW
rS/qA/lXar9WTdKy+yQnJjYiX67g9CNi6doCtZZHnZlq5sF07Q93lOgjomH31LinkNiu4jewNiQH
IHBXRme7wd7/W6pvfBPOpDNo8QAkrY45wMtpW4CMyB7GV6p8j60N1d6DpQpRWELgoUqP3p9G127f
cTVXfBklMBI3qanvOgSTz/QP7fxOUrC/LY7penHBb43nqxpltP9rUEHwFTMZGhdkIEPmk1xztG7k
eJ4DwvTuI7FZ/Tazlwp4T5Fc0nbE9ZHJCqq9jdPVYg==
=FYbK
-----END PGP SIGNATURE-----

--oluKzkFK6OUFxTk4npzrqaljOnuQQNrXC--


From xen-devel-bounces@lists.xenproject.org Fri Oct 15 14:24:22 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 14:24:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.210721.367697 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbO8D-0002XM-TP; Fri, 15 Oct 2021 14:24:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 210721.367697; Fri, 15 Oct 2021 14:24:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbO8D-0002XF-QL; Fri, 15 Oct 2021 14:24:21 +0000
Received: by outflank-mailman (input) for mailman id 210721;
 Fri, 15 Oct 2021 14:24:20 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mbO8C-0002Wu-BC
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 14:24:20 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mbO8C-000668-AT
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 14:24:20 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mbO8C-0002Kk-9T
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 14:24:20 +0000
Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89)
 (envelope-from <iwj@xenproject.org>)
 id 1mbO88-0005zX-Ur; Fri, 15 Oct 2021 15:24:16 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date
	:Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From;
	bh=VkbAhtOJmjXzxQaBvElNv6fF0jwKgNywHiUd5hmNz0c=; b=toruvAnkIcof9pJVico6r4Y/TK
	j/bzUt5YisUx2LKIIyrj7zIN5F3h5Txj2TNRcjqWldeNhuvBFBZr/9jwUWe9lkvJo+2Kuv/n74Lz/
	sfCeN4DzxacZhgfkL83ZN/V10MIXdyppfkixr2NZpsGmLixA33453DGw9SyVMcBE5wvI=;
From: Ian Jackson <iwj@xenproject.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <24937.36624.694770.174303@mariner.uk.xensource.com>
Date: Fri, 15 Oct 2021 15:24:16 +0100
To: Bertrand Marquis <bertrand.marquis@arm.com>
Cc: xen-devel@lists.xenproject.org,
    Rahul Singh <rahul.singh@arm.com>,
    Wei Liu <wl@xen.org>,
    Anthony PERARD <anthony.perard@citrix.com>,
    Juergen Gross <jgross@suse.com>,
    Stefano Stabellini <sstabellini@kernel.org>,
    Julien Grall <julien@xen.org>,
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
    Michal Orzel <michal.orzel@arm.com>
Subject: Re: [PATCH v7 5/5] arm/libxl: Emulated PCI device tree node in libxl
In-Reply-To: <4a22121e6474adfb1c5166e0fdaddff47c6dae46.1634305870.git.bertrand.marquis@arm.com>
References: <cover.1634305870.git.bertrand.marquis@arm.com>
	<4a22121e6474adfb1c5166e0fdaddff47c6dae46.1634305870.git.bertrand.marquis@arm.com>
X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu)

Bertrand Marquis writes ("[PATCH v7 5/5] arm/libxl: Emulated PCI device tree node in libxl"):
> From: Rahul Singh <rahul.singh@arm.com>
> 
> libxl will create an emulated PCI device tree node in the device tree to
> enable the guest OS to discover the virtual PCI during guest boot.
> Emulated PCI device tree node will only be created when there is any
> device assigned to guest.
> 
> A new area has been reserved in the arm guest physical map at
> which the VPCI bus is declared in the device tree (reg and ranges
> parameters of the node).
> 
> Note that currently we are using num_pcidevs instead of
> c_info->passthrough to decide whether to create a vPCI DT node.
> This will be insufficient if and when ARM does PCI hotplug.
> Add this note inside libxl_create.c where c_info->passthrough
> is set.
> 
> Signed-off-by: Rahul Singh <rahul.singh@arm.com>
> Signed-off-by: Michal Orzel <michal.orzel@arm.com>

This looks good to me.  I will ack it when it has an ARM R-b.

Thanks,
Ian.


From xen-devel-bounces@lists.xenproject.org Fri Oct 15 14:30:32 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 14:30:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.210730.367707 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbOE8-00042K-IP; Fri, 15 Oct 2021 14:30:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 210730.367707; Fri, 15 Oct 2021 14:30:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbOE8-00042D-FZ; Fri, 15 Oct 2021 14:30:28 +0000
Received: by outflank-mailman (input) for mailman id 210730;
 Fri, 15 Oct 2021 14:30:26 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=UM5E=PD=citrix.com=roger.pau@srs-us1.protection.inumbo.net>)
 id 1mbOE6-000427-Ay
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 14:30:26 +0000
Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 75cba17e-cfaf-46b3-873d-eb20a2acfc9f;
 Fri, 15 Oct 2021 14:30:25 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 75cba17e-cfaf-46b3-873d-eb20a2acfc9f
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1634308225;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=Vu3O9a9RlsYjNlKIfK9sEj6cSaZki0vr3RCKMn5rq8I=;
  b=fSpK3Vs/fqKrm7HEd5ZlJ+1Pwlz7OPFFL5PUvkCkE5VkPjf4q7GnAjoW
   hrMXq+6ErA/I9Z+oiFD3DBbpr0Ir9pANUamHJtFfqXtSQpymMB3mQbHH5
   rmW/zNxDfLlFC/5IZ6hsVGTeceJNK4QS8ae7VhIo2+t0pBZ7/7Ku7ON8V
   8=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: DXwKK1IhSh5t7BgLPbT8woDh5g/MCMo2P8AzDRm2OKs0/7LbAeckmmJZxVWq/PGXjqQpBtjD/s
 9SKEtF4qrTq9XoHoiCt0Npntzh0FekX26aOCBM6TK2GSR4si2LUMFMDJqMotCro2MNM90bwFcq
 ajqv1PIBuHpHPl4l50fyxW1sBmPeHnHidL8oj1EBa7Wbzoeqok8M9rNW6+DoszIJ5A8OkrExOQ
 rtEoaKCcQlOaVeb5Cyn3CcII/IfNArJd492wT4VUdZ7c1y5RE9m+mLht7sjgfMdXJCqRXdlxT4
 oYUaIr8vsz3I4qWqevna+atz
X-SBRS: 5.1
X-MesageID: 55280633
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:JZrEt6M9L4sk7NDvrR3TkcFynXyQoLVcMsEvi/4bfWQNrUoi02YGy
 WMcWW2GaK7bazahKYp2Ptm+pEJVvZDdnN4xGgto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdpJYz/uUGuCJQUNUjMlkfZKhTr6ZUsxNbVU8En540Us+w7dRbrNA2rBVPSvc4
 bsenOWHULOV82Yc3rU8sv/rRLtH5ZweiRtA1rAMTakjUGz2zhH5OKk3N6CpR0YUd6EPdgKMq
 0Qv+5nilo/R109F5tpICd8XeGVSKlLZFVDmZna7x8FOK/WNz8A/+v9TCRYSVatYoxuYlfwp0
 stHiZ+Pdj8FfYKLv/8ifRYNRkmSPYUekFPGCX22sMjVxEzaaXr8hf5pCSnaP6VBpLwxWzsXs
 6VFdnZdNXhvhMrvqF6/YvNrick5atHiIasUu216zCGfBvEjKXzGa/iXv48Agmxr7ixINfTXe
 MlFdhRFVUXBXB52B2s8Npc0g8790xETdBUH8QnI9MLb+VP78gt117T8NcvPTfaDT85Vg0Wwq
 3rP+iLyBRRyHN6CzTuI9Fq8i+mJmjn0MKoQHrCl8v9hgHWI23ceThYRUDOTufCkjmauVtQZL
 FYbkgIxqYAi+UrtScPyNzWorXjBshMCVt54F+wh9BrL2qfS+xyeBGUPUnhGctNOnMU7XyAw3
 1mF2dbgHyVysaa9QGiYsLyTqFuaODcXBX8PYzceSgkI6MWlp5s85jrUVcpqGqOxitzzGBnzz
 iqMoSx4gK8c5eYR3qWm+RbcgjSjprDAVAtz7QLSNl9J9SsgOtTjPdbxrwGGs7AQd+51U2Vto
 lAqisKytPoQB62OqxO1bKYiW5ay2NiKZWi0bUFUI7Et8DGk+niGdI9W4S1jKEoBDvvoaQMFc
 2eI5lsPvM470G+CKPYtOdroWptCIb3ITIy9Dpjpgsxyjo+dneNt1BplYlKMxCjTmUwonLBX1
 XyzIJv0Uyhy5UiKylOLqwYhPV0Dmn9WKYD7H8mTI/GbPVy2PyP9pVAtagrmUwzBxPnYyDg5C
 v4GXydw9z1RUfflfg7c+pMJIFYBIBATXM6t95YMLLXee1o8RgnN7sM9J5t6JuSJeIwOzo/1E
 oyVABcEmDITe1WWQel1VpyTQOy2BssuxZ7KFSctIUypyxAejXWHt88im28MVeB/roRLlKcsJ
 9FcIpnoKqkfG1zvpmVGBbGg/dMKSfherV/XV8ZTSGNkJMAIqs2g0oKMQzYDAwFVUHfp75Jl/
 eD5vu4ZKLJaLzlf4A/tQKvH53u6vGQHmfI0WE3NI9JJf17r/pQsICv05sLb6eldQfka7jfFh
 QuQHzkCouzB/908/NXT3PjWpIa1CepuWEFdGjCDv7qxMCDb+EulwJNBD7nULWyMCjus9fXwf
 /hRwtH9LOYDwARAvb1jHus51qk5/dbu+eNXl1w2AHXRYl23Ibp8OX3aj9JXv6hAy+YB6wu7U
 06C4PdAPrCNNJ+3GVIdPlN9PO+CyesVin/Z6vFseBf24yp+/bymV0ROPkbT1HwBfeUtaI58m
 LUvos8b7QC7myEGCNfeg3AG7XmII1wBT74j6sMQDrj0h1d50VpFe5HdVHP7ucndd9VWP0A2C
 TaIn66e1a9Ez0/PfndvR3jA2e1R2cYHtBxQlQJQIl2InpzOh+Mt3Q0X+jMyF1wHwhJC2uN1G
 25qK0wqevneo2Y23JBODzK2BgVMJByF4UigmVIGmVrQQ1SsSmGQfnY2PvyA/RxB/m9RFtSBE
 Gp0FIoxve7WQfzM
IronPort-HdrOrdr: A9a23:Msn9QatTykJB75ktxnY4YFql7skC5YMji2hC6mlwRA09TyXGra
 6TdaUguiMc1gx8ZJhBo7C90KnpewK7yXdQ2/htAV7EZnibhILIFvAZ0WKG+Vzd8kLFh4tgPM
 tbAsxD4ZjLfCdHZKXBkXmF+rQbsaG6GcmT7I+0pRodLnAJGtJdBkVCe32m+yVNNXh77PECZe
 OhD6R81l2dkSN9VLXEOpBJZZmOm/T70LbdJTIWDR8u7weDyRuu9b7BChCdmjMTSSlGz7sO+X
 XM11WR3NTsj9iLjjvnk0PD5ZVfn9XsjvNFGcy3k8AQbhHhkByhaohNU6CL+Bo1vOaswlA3l8
 SkmWZuA+1Dr1fqOk2lqxrk3AftlB4o9n/Z0FedxUDupMToLQhKQPZptMZ8SF/0+kAgtNZz3O
 ZgxGSCradaChvGgWDU+8XIfwsCrDv2nVMS1cooy1BPW4oXb7Fc6aYF+llOLZsGFCXmrKg6De
 hVCt3G7vo+SyLbU5nghBgr/DWQZAV2Iv/fKXJy/fB9kgIm3UyR9nFohvD2xRw7hdQAo5ot3Z
 WNDk0nrsAWcie6BZgNc9vpevHHf1Aldyi8eV56EW6XZp3vBEi936IfwI9Frt1CK6Z4gafbpv
 z6ISVlXCgJChrTNfE=
X-IronPort-AV: E=Sophos;i="5.85,375,1624334400"; 
   d="scan'208";a="55280633"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=MvHEzPrQyw6JF7wUNCzYHU7w0lViJld65BtkdUubTYvIeJurS80WK7RRHREbgBzVQDMDH3LZRjMNPGjdIgVbKdtyHb9i8ngWLuqpD/z2wXpEOVDY5D+z6QqZbzHEwDs1kgkqawYyK7lJrh97p20EEjZECCHLaHk5xFZQyQ5iOQNbmCk8nrZh32vaLxAxSXbGOyRTRguXWXi7P7Jm2bSpPdNmyahrcBN3wRYx1Qn6yYow/OkshvuMYL+nzYyaChgjWAt+9IYnJTJPH34chs03xOzqQL7nmu2O+IlwEc+4NiknSWpiyRuu0zTaQhdSrGXIC+Zla+rFtQnV/x/8A64s/w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=I0+3qYUb+Q1FysRGZgGkC50CSStj0qWL5rTTMaQox/Y=;
 b=itAKvrUOnUdt/wWfE4kZLhdVENmozIqD+49i1GlzpGyuRaeJAGUgI7E0m0NI0vMsVHLgaUPZYSDKGKMDDGti+yrzmndkqTWII9Kx6ZOWMd4cDhnjfgfItb0LHMwhOUCGDk1dLlFm2gf+2w+O0/KPQhIzQcIT+XzkH+SeTh8DCOBt9fg5kt6SRRveJVUUY1r+FD9lW03QwRBBAyguf8FAReYWHz+aam1gC0e8n8Hscj/bURhMzzPfdiiFjYG7/LSJgy38r31Pfq2POG51/uSt6p5RQcbg+7CL6PVJB50o0hjh+DVE+UdHd5LwBF1VxMayCMJEqz8Q0QYGLDoUBQIrYw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=I0+3qYUb+Q1FysRGZgGkC50CSStj0qWL5rTTMaQox/Y=;
 b=PPN3JOxbT2uZqn9WB40aKj88tv3HBcCV9I7qRceWjJNX6Msrf/ESw9qyIELnkrDpWxSO+WoP4GLIzXZ0Ajgdj39mx3H8S2rE8lk8MBOPvobKIDfgKu1L5hDfkqxXTREGa6kYzdHzObBaysc8L33dG4BA/KILdaC3y5DjTq3fhWM=
Date: Fri, 15 Oct 2021 16:30:03 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Bertrand Marquis <bertrand.marquis@arm.com>
CC: <xen-devel@lists.xenproject.org>, <iwj@xenproject.org>, Rahul Singh
	<rahul.singh@arm.com>, Stefano Stabellini <sstabellini@kernel.org>, "Julien
 Grall" <julien@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>, George Dunlap
	<george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>, Wei Liu
	<wl@xen.org>, Paul Durrant <paul@xen.org>
Subject: Re: [PATCH v7 2/5] xen/arm: Enable the existing x86 virtual PCI
 support for ARM
Message-ID: <YWmQa4uMA8usiHcu@MacBook-Air-de-Roger.local>
References: <cover.1634305870.git.bertrand.marquis@arm.com>
 <847d430fdeb19e695176ddea71eeb11dcef8b23e.1634305870.git.bertrand.marquis@arm.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <847d430fdeb19e695176ddea71eeb11dcef8b23e.1634305870.git.bertrand.marquis@arm.com>
X-ClientProxiedBy: LO2P265CA0195.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:9e::15) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 7d6aaf37-e260-48d7-5199-08d98fe849b4
X-MS-TrafficTypeDiagnostic: DM6PR03MB4842:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <DM6PR03MB48421F3AEEBEA3DA635B7BBF8FB99@DM6PR03MB4842.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: qYGi/BpjzM/Ofnn8cjIdoetspcanb6HP5zB3Yyfpab3g88IAP9c1KB9FIHDqWjHXwqYDALTHYDWWsaGVSyOW/PaPpQrpR/fgNiYVjToJ3fSoB3sh3GM62y6qrPA+2i+RmehgpfgnyCePwJwa69RIZxpWnIMHKKxcm1NvBPb4QoOzPHMYKhFnWgExp9DTcRXo68BqFRrD3vL8MyDh3QJZ1+uSwOpzb7Taq5lRgL7qYna1jCcGDTCJvGt/m6oej3vkGPMa1QQ7/tI37W6s7mBN4xcpsvJc52aE+UkK19Ogw5nwmjRQG1InTbMlfxP5hF9mwdcY95FuaUZEleuqkQDf54p4CKLMVth7NYT+Yo0UiU0x6k6wz7pIcleyQv5u9LEckIZNQUR5H22NxMn+SkvUln+dGw9VtI3VZkBwc4LOI/1IhBD4+/8KChwl9+l6djrgXmbLeA3Au3HLfPLDBGNEWwmLtonmtdDWgdtjTPJjSNlXfQ2FLNRu9VdutjqLtcZQ5o5yxkq4nZxSKAqyGLrOK4OYX4DddnsGJA0TxjC+TpMLB5LNq4aTbuzBeLo3uwYhEXkWk01gy2OTXURYgXo0ZAO9bZjtWRvWcNsdcI4FkTr1NBKSDmuBP/49yUPwyAWhkQtguQ1QPS1IqvYPvctheA==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(26005)(82960400001)(6486002)(508600001)(6496006)(7416002)(4326008)(9686003)(85182001)(8936002)(8676002)(86362001)(6666004)(54906003)(5660300002)(66946007)(38100700002)(83380400001)(2906002)(6916009)(186003)(66476007)(956004)(316002)(66556008);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UWxQZWJsS3UrUjVyRXgvTmFWRCs1bDM4NlUxcXBHQUNlN1c3ZDNFT2g3NGZK?=
 =?utf-8?B?NHNVR2ZkZzBvRC90TEkvUlp3NzBJZkcwY2NZbmxBb1VtZ0RqNndwSUxtK3V1?=
 =?utf-8?B?KytUeDlNZTRLM2NadkY0MkRURG1adFNrZ1FsdEVxbytwbk1TeXRvek1PVFVs?=
 =?utf-8?B?cmRRMHluaEVlT0YyU2JUYXM3ZVBWbnNyRG9hWElYNVgxZXNOOWFVYlIvbkFP?=
 =?utf-8?B?ck9CUFpwTGthUXpzV29QQUlwcDBmV1pWM0VEUkhQUjZuL1d1T1V1SEdGZE00?=
 =?utf-8?B?MGYzZXBwajhhdkRFbGFSVlZLc1daZ095Yk1uZTc4bUFoc0YrUW0rR0s5d2gx?=
 =?utf-8?B?L3k2VmZZcTZpOG1sNlVHZ0xXdlZWVG5wK1R6S1pQRmkrd1pZZURVQVg0Zlc0?=
 =?utf-8?B?VWJHUUcrekdmVE9zdHF1Q0oyU1c4c1ZKTmkraXVIdlloNkhEdDdBNzgrZE1v?=
 =?utf-8?B?NXlCOTNKVVNDWmFGSERSWlc4a3BTOERacHJoa3l5MUZUaDROMXFEYVdTRWgz?=
 =?utf-8?B?bHkxaU5hUzFWK1ZZeGJ0R2VwMS9OMW9peTlKWm1Ec0VGQm1zWWd6K2M5cFpZ?=
 =?utf-8?B?Q0N4ZWdLbEw0dURJS0QvNnpoQWsvNWdjU0hVL01mZ0Y2QnEwNm5tNG9mbGt3?=
 =?utf-8?B?K1U4V0xoTDZrWkZBK21NdXJkdk8vR3kzZ3ErbmhIZUJWUmZRU29vVXI2ZFZl?=
 =?utf-8?B?U1JSTEh6ZVk0elFwWEZVV2dNQ0lBZVIwQXJFVTRkQk5HSm1sWlNtazhROWlk?=
 =?utf-8?B?cDdKV3Jab2l3VjM1aEorQjFKeVdSbmpIMDREOFgvZWFsRkJWUllnbDNjVFNQ?=
 =?utf-8?B?SnFLN3J3aXExVzN6NE95VjRtaldqS2FyWnptZDlVWXRDQk5qd1VwN1ZYdnRj?=
 =?utf-8?B?dVJTSnNjRHlZMVlLcGlqVkdyL1FnOFFFYi8ySEpPYmdQeDdsSWlLaTcyWkow?=
 =?utf-8?B?UENDbWVZNlkxcm9DSUxrUHY3ZWNDYmRDRzN2UGlDM0JGUjFQZDVrWEFDZ0NM?=
 =?utf-8?B?cUVNZGlNM21zRFIwYXIyUTVCQXA5L3hoV3JNY05tR05IRXdycUVwZ2VWSHBx?=
 =?utf-8?B?cisrZDN1ekVvU2FjQ0dPU2pkZTJ6Uk5CcE5tTUhqQ2JCRDF0Ui9lRHZXSXlH?=
 =?utf-8?B?U1l4bG1MN3VIaEVDM2xwRitZOTBoMjBZL2kxckIvbzRGSjVKL0t3UWRJYnRs?=
 =?utf-8?B?cFJjb3FGd1RTSFVKYUpBSk9MUkExdElEYi9oQlM2VnJBSllPZ0xDYWt3SEN6?=
 =?utf-8?B?dmNVTmQ1cytNMkNiWWNFL1ZwZVpVeEhsUzJsOVZuUWJkbmxXbm1EcytHK0hl?=
 =?utf-8?B?OTBNaEdPeXJNaktySTZYMElYcVdWeG5DZHBjK0pJbzlFWDBoSDlJeHNaWUQ3?=
 =?utf-8?B?WUI3QXA4WW4zN0tONDhhOWhNcXZwNFhMNStwOGFCTzlFSHUvQy9zcmRDTTcr?=
 =?utf-8?B?eThQanpGaTJkVTF0Y3MybXE5K3piMzg0RVkyRTlwWDkxcFRJZ0dmYlRueU9T?=
 =?utf-8?B?Z09TMVFVQjQwQnUzWGJiNmc3cEFJNFlTUm44NVp6dGkzTDJsNWVZN3BXZGtv?=
 =?utf-8?B?ZldHYVV2b2Y0RHUvZ0FvUitvS2pOOU1jYklVQTNDQUxDVVp6eDY0TUNEbVNY?=
 =?utf-8?B?cnh5UHN4cUh2YmFybkNwZWZUTjhoMWVVaE5kUWdGdmtPMWI5UEdOWU5HQXB0?=
 =?utf-8?B?RmtNQzFlTDd4K1k2NTlmMk5BZjk3K1JsK3BhTGF4RTE5WkhEK1ZJU1crVDh2?=
 =?utf-8?Q?EsYsJZSzDXvp1n0fPM2j/g4HNuKJVzGuX9hbpHK?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 7d6aaf37-e260-48d7-5199-08d98fe849b4
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2021 14:30:08.2748
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ejJqVfmQ8+n0XPYLgxUTntS1p+6xcQL0shI1sebz9OD54F9lNM425ZTi+aSVHUEhReth8s+vjq4zm4e1Knyi4g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4842
X-OriginatorOrg: citrix.com

On Fri, Oct 15, 2021 at 02:59:19PM +0100, Bertrand Marquis wrote:
> From: Rahul Singh <rahul.singh@arm.com>
> 
> The existing VPCI support available for X86 is adapted for Arm.
> When the device is added to XEN via the hyper call
> “PHYSDEVOP_pci_device_add”, VPCI handler for the config space
> access is added to the Xen to emulate the PCI devices config space.
> 
> A MMIO trap handler for the PCI ECAM space is registered in XEN
> so that when guest is trying to access the PCI config space,XEN
> will trap the access and emulate read/write using the VPCI and
> not the real PCI hardware.
> 
> For Dom0less systems scan_pci_devices() would be used to discover the
> PCI device in XEN and VPCI handler will be added during XEN boots.
> 
> This patch is also doing some small fixes to fix compilation errors on
> arm32 of vpci and prevent 64bit accesses on 32bit:
> - use %zu instead of lu in header.c for print
> - prevent 64bit accesses in vpci_access_allowed
> - ifdef out using CONFIG_64BIT handling of len 8 in
> vpci_ecam_{read/write}
> 
> Signed-off-by: Rahul Singh <rahul.singh@arm.com>
> Signed-off-by: Bertrand Marquis <bertrand.marquis@arm.com>

The vpci bits looks fine to me, so:

Acked-by: Roger Pau Monné <roger.pau@citrix.com>

I have one question however related to the placement of the vpci setup
call in pci_add_device.

> diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci.c
> index 3aa8c3175f..082892c8a2 100644
> --- a/xen/drivers/passthrough/pci.c
> +++ b/xen/drivers/passthrough/pci.c
> @@ -766,7 +766,21 @@ int pci_add_device(u16 seg, u8 bus, u8 devfn,
>          list_add(&pdev->domain_list, &hardware_domain->pdev_list);
>      }
>      else
> +    {
> +#ifdef CONFIG_ARM
> +        /*
> +         * On ARM PCI devices discovery will be done by Dom0. Add vpci handler
> +         * when Dom0 inform XEN to add the PCI devices in XEN.
> +         */
> +        ret = vpci_add_handlers(pdev);
> +        if ( ret )
> +        {
> +            printk(XENLOG_ERR "Setup of vPCI failed: %d\n", ret);
> +            goto out;
> +        }

I'm likely lost here, but shouldn't this also be done for devices that
belong to the hardware domain and are assigned to it in the first
branch of this conditional?

Or else you will end up with devices assigned to the hardware domain
that don't have vPCI setup for them.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Fri Oct 15 14:32:56 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 14:32:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.210737.367719 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbOGV-0004eX-0R; Fri, 15 Oct 2021 14:32:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 210737.367719; Fri, 15 Oct 2021 14:32:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbOGU-0004eQ-TT; Fri, 15 Oct 2021 14:32:54 +0000
Received: by outflank-mailman (input) for mailman id 210737;
 Fri, 15 Oct 2021 14:32:53 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=UM5E=PD=citrix.com=roger.pau@srs-us1.protection.inumbo.net>)
 id 1mbOGT-0004eK-QE
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 14:32:53 +0000
Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id c6ec72e0-2dc4-11ec-823d-12813bfff9fa;
 Fri, 15 Oct 2021 14:32:52 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c6ec72e0-2dc4-11ec-823d-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1634308372;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=ceJzGrY3tK3KWw61ipDVYOoTuR8tGS9ocfRpj3ZkZzU=;
  b=QJ03exw/OBG2WhgoZ5Ls3mVuF1s45SzId0Xb1+JyJB8D/sZ50FaD9qaD
   EsL1g4wKrHlwdB9iGc4aInQ6H+3R7x9Z8XQPsLn5KFZ3v4f6wGq30r4nc
   y7w3OkllFb4a/KGa/Fdr5EI9gTkB3TqPKaTaXyOqVeCitOz4Cgy3D/Lm5
   M=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: VX82wxF8sE4BhkLI26/5J3nnWeC6TspYti0NC5DHScDioYJYDAMvaPFf+cb9c8KxbsigN96AZm
 UJobM4In5qY0TQ507FACX/LraQd6LgWbg4rtwL9wduMIVQh7pzKoTosE2qljPlDLUzwHJDw2vI
 bvodQWXX2+naHFi5CRh4r1s1Ou4h7CCVK/ZUMsEN2+J6Flz8V8zQZqw7YZown7s6iz7043YICG
 ZDCe3HaN9nn5Lh4o9aAA71dLxZy1qVOywsObcxflotu4djHi7FP+Ea9Ns3TYFLy6NwQcunSd70
 iQhyd7o/spbytDcs3b0znAdA
X-SBRS: 5.1
X-MesageID: 55324201
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:XuSUHqg3uRtzKlcw6siNuVT9X161SBYKZh0ujC45NGQN5FlHY01je
 htvWmyFaPbcNDf2KY92OYq3oExUuZ7Qzd8xGgRrrH1mRC0b9cadCdqndUqhZCn6wu8v7a5EA
 2fyTvGacajYm1eF/k/F3oAMKRCQ7InQLlbGILes1htZGEk0FU/NtTo5w7Rg29Yx3IDga++wk
 YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq
 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx
 /0KpbjvR1kEHJbvnfYMbxpxDSZ7HoFZreqvzXiX6aR/zmXDenrohf5vEFs3LcsT/eMf7WNmr
 KJCbmpXN1ba2rzwkOnTpupE36zPKOHxO4wSoDd4xCzxBvc6W5HTBa7N4Le02R9t25sUQayGP
 qL1bxJscy3vTidXE25QDZ5mnfa0vCfZTwdh/Qf9Sa0fvDGIkV0ZPKLWGOTSftuGVMBEhHGyr
 2jN/3n6KhwCPdnZwj2Amlqum+vOkCXTSI8UUrqi+ZZCm0aPz2YeDBkXU1qTovSjjEO6HdVFJ
 CQ83S4jrrM78kCxefD7Uwelu36PvhMaWN14HvUz7UeGza+8yx6QG2wsXjNHLts8u6ceWjgCx
 lKP2dTzClRHsreYVHac/be8ti6pNG4eKmpqTQUJVxcf6t/v5qQ6lAvST81LGbSwyNbyHFnYx
 y2BpW4wjrMYgMoPyo2y51WBiDWpzrDzRw4o4kPsX2Sq7itwfovjbIutgXDa8vRoPIufVkOGv
 nUPh46Z9u9mJYGAkmmBTfsAGJmt5u2ZK3vMjFh3BZ4j+j+xvXm5cuhtDCpWfRkzdJxeIHmwP
 RGV6Vg5CIJv0GWCKr9TPIzvJuYR7q3yBOjmf+7Ta/lifc0kHOOYxx1GaUmV1mHrtUEjl6AjJ
 JuWGfqR4WYm5bdPl2XuGb9MuVM/7mVnnzmLHMGkp/iy+ePGPCb9dFsTDLeZggnVBou/qwLJ7
 80XCcKOzxhOOAEVSniKqdBNRbzmwH5SOHwXlyC1XrLcSuaFMDt4YxM0/V/HU9c490iyvr2Zl
 kxRomcClDLCaYTvcG1mkExLZrL1RopYpnkmJyEqNlvA8yF9Otr1t/1EKsJnJ+dPGAlfIRhcF
 KRtlyKoWawnd9g6025FMcmVQHJKJXxHej5izwL6OWNiLvaMtiTC+8P+fxuHycX9JnHfiCfKm
 JX5jlmzacNaH2xKVZ+KANrynwLZlSVMw4paAhqXSuS/jW2xqeCG3QSq1aRpSyzNQD2erganO
 /G+WklF+7OU+NFoqbEkR8ms9u+ULge3JWIDd0Hz5reqLyjKuG2lxI5LSuGTej7BEmjz/c2fi
 S99lqqU3CQvkAkYvoxiPaxsyK5itdLjq6UDllZvHWnRbkTtAbRleyHU0c5Kv6xL57lYpQrpB
 R7fpogEYe2EaJH/DVocBAs5deDfh/sarSbfsKYuK0Lg6S4poLfeCRdOPwOBgTB2JaduNN932
 v8ovcMbslTtihcjPtucoDpT8mCAci4JX6k978lIC473kAs7jFpFZMWEWCPx5ZiObfRKM1Urf
 WDI1PaT2ewEyxObIXQpFHXL0e5Mvrg0uUhHnA0YOlCEutvZnftrjhdfxis6E1ZOxRJd3uMtZ
 mUybx9pJb+D9itDjdRYWzz+ABlIARCU9xCjy1YNk2GFHUCkWnaUcT84MOeJuksY73hdbn5Q+
 7TBkDTpVjPjfcfQ2CouWBE696y/HIIprgCSytq6G8mlHoUhZWu3i6CjUmMEth/7DJ5jn0bAv
 +RroL59ZKCT2fT8eEHn5112DYgtdS0=
IronPort-HdrOrdr: A9a23:UfwgWK3uRjh0YrG6ahgECwqjBSNyeYIsimQD101hICG9Lfb2qy
 n+ppgmPEHP5Qr5OEtApTiBUJPwJk800aQFm7X5Wo3SITUO2VHYV72KiLGN/9SOIVydygcw79
 YET0E6MqyNMbEYt7eK3ODbKadY/DDvysnB7o2/vhQdPT2CKZsQlzuRYjzrbHGeLzM2Y6bReq
 Dsgvau8FGbCAsqh4mAdzQ4dtmGg+eOuIPtYBYACRJiwA6SjQmw4Lq/NxSDxB8RXx5G3L9nqA
 H+4kPEz5Tml8v+5g7X1mfV4ZgTsNz9yuFbDMjJrsQOMD3jhiuheYwkcbyfuzIepv2p9T8R4Z
 XxiiZlG/42x2Laf2mzrxeo8w780Aw243un8lOciWuLm72weBsKT+56wa5JeBrQ7EQt+Ptm1r
 hQ4m6fv51LSTvdgSXU/bHzJlFXv3vxhUBnvf8YjnRZX4dbQqRWt5Yj8ERcF4pFND7m6bogDP
 JlAKjnlbdrmGuhHjLkV1RUsZmRtixZJGbDfqFCgL3a79FupgE786NCr/Zv2Uvp9/oGOtB5Dq
 r/Q+JVfBwndL5jUUtHPpZyfSKAMB26ffv9ChPgHb3ZLtBzB5vske+93Fxn3pDhRHQ3pKFC76
 gpFmko7FIPRw==
X-IronPort-AV: E=Sophos;i="5.85,375,1624334400"; 
   d="scan'208";a="55324201"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=DALIi+Prq9V4SwTYINtw3zhnn/Ra12OWT6qLCvSGNYRJixiWXxIrmIOeJBsnoae3/liNnrSRK1O8kGgFuesrYX3TmO/soRyHYtojXQG8UqDa+2P3wD4/tNan2EaBYFX44VZFEfgqSG0I20u3h+H5ql1cXiO2KNvaYYOvrzw8DV4LL2ktYFl4HCHVpXrjhoaba3KuXklbXVHaekJ7C1Dk4iAxHj9eCxXpVtS6pjmlyLGStlDlS+L8d0mPA8cuYc9Zm3t6sHcc4AaUR8hJJuFsNCbBKO6I2lA+v+3hpk9231XrMSr4N6kSfIup4jJoC3WStfGITHcJJJe/rVhnupc2Mg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=o+H1+SA3XGSvjOPHbiJJ1jibJht7HXe+gh1tDK4mLA4=;
 b=X2W1tpu6FF8OclRe8I813VY4BXpsYRZPJr3OJnK4pE2P7m1It+nIlQVb2Be2iBdyFG8jV9InkZaEUQGxaxUpMZ9vmbu7TdFyzobZp79ANIBBPoNpwBbevywMdb8jGiBXLvxj57m+xFWxriVp2iKYF72hjkI/UeYZ2z+oObrXH4gkqq+rnPyJ8VBOGPvMsvnC19gPQwvangdq1hn0CqG0qhyiCdrprIZ7PoE/LxlHpewSNoygylN8tcjBW0CUu/KzKh/kypFT1ppSQ1qZ6PcRVzogMbDez1vavXnsqNib17E+ZTwYgGtnCdZdLcatvdDImuetVqRf/v3UmWUEC7iYQA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=o+H1+SA3XGSvjOPHbiJJ1jibJht7HXe+gh1tDK4mLA4=;
 b=xHSRiPNV0YDb+3bd0k0yjCA+4ZFX48AoGu+kl/1X2pM1w5jgBWFYnGNj/+KGiMI3EHurMel+t2wsVnrNFK/XdfouNfvHmDZ8u7tWVQkkQqA+R99s/YOX5NZkgAWQESBDkCyAI6OJ2I8UzdDucvREJUeUb3to/hCD9jRbcRVOC6o=
Date: Fri, 15 Oct 2021 16:32:08 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Luca Fancellu <luca.fancellu@arm.com>
CC: Bertrand Marquis <Bertrand.Marquis@arm.com>, Jan Beulich
	<jbeulich@suse.com>, Xen-devel <xen-devel@lists.xenproject.org>, Ian Jackson
	<iwj@xenproject.org>, Rahul Singh <Rahul.Singh@arm.com>, Stefano Stabellini
	<sstabellini@kernel.org>, Julien Grall <julien@xen.org>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>, Paul Durrant
	<paul@xen.org>, Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH v6 2/3] xen/arm: Enable the existing x86 virtual PCI
 support for ARM.
Message-ID: <YWmQ6HDY53NtPguP@MacBook-Air-de-Roger.local>
References: <cover.1634221830.git.bertrand.marquis@arm.com>
 <396b08e2598cf0338e0c7f4ad3cd5cb66db89224.1634221830.git.bertrand.marquis@arm.com>
 <YWk8uP/YuSee1MfG@MacBook-Air-de-Roger.local>
 <CD9B29B0-31FD-4E09-93E3-7124C724BC23@arm.com>
 <1c298c02-5791-8935-f996-516da2409f24@suse.com>
 <BFC005A8-4C72-41C5-93F4-98BB9CBAB198@arm.com>
 <cd81cc31-617c-c750-01f4-b02bcb9e3a9e@suse.com>
 <B57498FA-F205-4DC1-ACE0-414558400293@arm.com>
 <YWmGbzPdCxmwfdIX@MacBook-Air-de-Roger.local>
 <90FEC0F8-A5CA-4B7F-8E94-38223FE3F6D2@arm.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <90FEC0F8-A5CA-4B7F-8E94-38223FE3F6D2@arm.com>
X-ClientProxiedBy: LO2P265CA0040.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:61::28) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 5177d765-95f1-4585-a5c9-08d98fe89496
X-MS-TrafficTypeDiagnostic: DS7PR03MB5542:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <DS7PR03MB55421F889C45ADD22FDA6CFA8FB99@DS7PR03MB5542.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: lUfPqIQhaPHJPglYsko4TwforGs89XHNn5pMqHA7scA2lETl5RBVfTqMtlu0G3ljPjP5/42wIdUho+Dh12f3X+jBHUVvd3pvIeLMQoh1CppVtk09QkmBpH3DZY6QnxCWg7i8I8ePkf+rcZ7xv/q16zkNA67dt6AljJ+zmjjA0XPNw6ol+U+UYMqdcSCEwR916Kw0c3T8rngVd+BQ49dle9roM++0JjdE/fi4IYG7GM134DH+Nlb9egb94O/OWYcY8hXKXZ2dj6wpI5H3vG8uPheYBYZ70bxMOAfKDaBWjqt3fBh1fwjAKrr3xN03l7xYhFou+xy5ETDeLLAqKP4zRVpQfhacncMcqGt8xF7IDxnHAPN9uqYitmj6zJ0NGzyR5nuXEPCMZ2SO63TDNZNR7FFYyX9ed+N+s220J1TVgXX2IkPTmt5wr45mjrSzisdMH1b1KruzQNKK0WISl/ulhGlsuOfGITtqC8Q5IDPNQviVOjymkodcfJkrMn5ahqyrAJFA6E3nCFtH7XEejcuxUgZHwpHes46D7GwL7kUSB9Nam36KPLpGg0jOAt2pU40u/qeSzblml4hyDAsJl14LCWGHr+ga0zGKhEAeDe7kU40/dKzvGPUQc5l8NO1H9sWfnpp0EY0ZXw01DqUdROgefQ==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(4326008)(6496006)(508600001)(5660300002)(6916009)(38100700002)(316002)(6486002)(26005)(7416002)(8676002)(9686003)(8936002)(82960400001)(53546011)(66476007)(66556008)(66946007)(186003)(2906002)(86362001)(6666004)(956004)(54906003)(85182001)(83380400001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WXhLNXpReWpxNmJVN2x1VHpmKzJoSnJ1Y1MzT1VhV2llSWxLWHQrL1haMzF3?=
 =?utf-8?B?MERFZ3V3MFB1UlcyM2lkNFlkcVhKV1VDa2szcU81VEhYNnBaclIwTkVSSnBI?=
 =?utf-8?B?cTNFWkhqaW51eEY1THJCbmtSQzBnUFUvUkQ0OE40akhjYVZXN25WVzRtNi9Y?=
 =?utf-8?B?em1PaTRNZXhseU0zeXZ1b0NHUTVrVzMvdGxzUkdBUkFkR3hoR1VQQkY2K0gz?=
 =?utf-8?B?ZTV5S3pYZHFwU1NVTytrVWoxamdkYlM3UlZ2WVVDMXFjZTNjTHZTN3BUS0cw?=
 =?utf-8?B?RzFUY2c5cng2a3RIZ3BnWGRyWHYycGFPSTJZUHJYdjR4bklYbVhYS0Uwd2Qw?=
 =?utf-8?B?bS9SZXQwTEZ4MDBmbExiTnZtVTJ6QllnRUY0ajdBOUNIdWpTc3FRSFJ4TCtP?=
 =?utf-8?B?ampFalZtSWpyUHZxcWlmUlpuakNiVnNHblYvMFd2QnlxRGI4S2s2Q01aaEhv?=
 =?utf-8?B?b2VIcElMMFVPWGtieHVyaml1dG9FQnc3cU56WXRmTU9SeXNSdGYrZ3JHUkNH?=
 =?utf-8?B?bURRbWYreXorbzNZQUYzQlFxN29FQ2FtSVdobjJNWS9zWTBmQVUyUFRHK1RP?=
 =?utf-8?B?d01INkdVR3R1eTgyeStjS09SWUhqQW52YmQva2lNWjRaNTlWUEVtcGlOZjVS?=
 =?utf-8?B?Sndwc1AvVHhnNmQzTUY5MmYwUHpvVlViOUZzYjJ4eDhzUDlYTktpMkFRUUdI?=
 =?utf-8?B?M3JyM1VqVFhXb0JlRUwwVE9rVXgzTURCdHFOUXl4N0pXb09jWHI5VFIxUjZm?=
 =?utf-8?B?dVE1b3h6MDEvQndRTWRWMmJzQ3dPWEtyWlpiR3BKcTRscFlBNjdra0U0TmZJ?=
 =?utf-8?B?SlI1YzA4N1pFd012azRUWFFmZit4RUNYbHFqOTRaM2tVRWcxLzgrQ1VrOGxw?=
 =?utf-8?B?ZkZwMHJuNTFGd3FlQnM0aDhUYlJHeDAzQUZJaXlGNExNU2lQUlB3TU0rcWRQ?=
 =?utf-8?B?MWIwdlY4VE9iQUQ2Uk1rNzMwRjB2ZFN5R3hIaWVjenlUZk1ncllhTXFGVjJZ?=
 =?utf-8?B?QXFmd05wYzF5MFBBSzMzcmxQdk5mMUU2bDNnVzdGZkwxYWptbm9PWnlnN1hQ?=
 =?utf-8?B?UzRoUUJya0RvcmplQUxoOEFaOGUyd0liem9rUEFvN2pKRXRrMTMxeXc4ZHRs?=
 =?utf-8?B?UlZrbU4wWEZFK2JiV1YzZ1kxeWk1b2t0TnpmSVdNSDNtY0diRWNtMjUraE1Y?=
 =?utf-8?B?Tzl6M3VUcTVLbGVRblRTT1ZXeUFQTHE0V1VHemlLV1pQUHUvK1QrYTBXdGdO?=
 =?utf-8?B?MFZySmhHV21qb010M21Cb0p3LzFRTEtadGFBSjJjSjFkdnN1MzV2TEU5Q3N3?=
 =?utf-8?B?MzRBTHZzQ3RjQkd1YWNhNVBmRktKOEh4UUVMNzZid3RZOWFuVHhRZGtucWx5?=
 =?utf-8?B?eGNnenZwcjlQMUpyZkM5RFZwTkwwYlNvMlN6cjVEeldoanczdHlJbEREd1RH?=
 =?utf-8?B?ZG5oL3FYK2VFUWJFTmt5NHpUUnAxUC8yMGVjbUpITTQ0cjlwQkNTVTVuYjlB?=
 =?utf-8?B?bEo5WThVaURsY1p5cHhsOFNXdUwwL0NHV3pUcjN0REZCY2FneEFZanZmbi96?=
 =?utf-8?B?eVp5RnQyR0Y0NllJS2dVMFE5dUtPMnBQcUpTMWdOMDlJQ21ycUU2R0YxVnU0?=
 =?utf-8?B?aUgyT3Bvc2xQQkhwV0dSazdUdXp4QXYya052MGxXTU80WFl5dmxmMlg1ZzBZ?=
 =?utf-8?B?bjR0M0pmYTA0SFZTZDFXMFZOdzFLaGFraXcwTmVHN1UwUEo1eWhBMnc3emwr?=
 =?utf-8?Q?79cM8GSaFSOHkXwyUjVctaCjbAbRtSpfaq1ADb4?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 5177d765-95f1-4585-a5c9-08d98fe89496
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2021 14:32:13.9314
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: fkxDBOgnJQ2yB6b8WKqMH2fBWvOi2EI8hTu6qbWFOhMV0lUwklKE7O7sRIi25P0FI9ZM6yPCl3eWnYSYTHwFaA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR03MB5542
X-OriginatorOrg: citrix.com

On Fri, Oct 15, 2021 at 03:00:21PM +0100, Luca Fancellu wrote:
> 
> 
> > On 15 Oct 2021, at 14:47, Roger Pau Monné <roger.pau@citrix.com> wrote:
> > 
> > On Fri, Oct 15, 2021 at 10:48:41AM +0000, Bertrand Marquis wrote:
> >> Hi Jan,
> >> 
> >>> On 15 Oct 2021, at 11:41, Jan Beulich <jbeulich@suse.com> wrote:
> >>> 
> >>> On 15.10.2021 12:33, Bertrand Marquis wrote:
> >>>>> On 15 Oct 2021, at 11:24, Jan Beulich <jbeulich@suse.com> wrote:
> >>>>> On 15.10.2021 11:52, Bertrand Marquis wrote:
> >>>>>>> On 15 Oct 2021, at 09:32, Roger Pau Monné <roger.pau@citrix.com> wrote:
> >>>>>>> On Thu, Oct 14, 2021 at 03:49:50PM +0100, Bertrand Marquis wrote:
> >>>>>>>> @@ -752,6 +752,19 @@ int pci_add_device(u16 seg, u8 bus, u8 devfn,
> >>>>>>>> 
> >>>>>>>>  check_pdev(pdev);
> >>>>>>>> 
> >>>>>>>> +#ifdef CONFIG_ARM
> >>>>>>>> +    /*
> >>>>>>>> +     * On ARM PCI devices discovery will be done by Dom0. Add vpci handler when
> >>>>>>>> +     * Dom0 inform XEN to add the PCI devices in XEN.
> >>>>>>>> +     */
> >>>>>>>> +    ret = vpci_add_handlers(pdev);
> >>>>>>>> +    if ( ret )
> >>>>>>>> +    {
> >>>>>>>> +        printk(XENLOG_ERR "Setup of vPCI failed: %d\n", ret);
> >>>>>>>> +        goto out;
> >>>>>>>> +    }
> >>>>>>>> +#endif
> >>>>>>> 
> >>>>>>> I think vpci_add_handlers should be called after checking that
> >>>>>>> pdev->domain is != NULL, so I would move this chunk a bit below.
> >>>>>> 
> >>>>>> On arm this would prevent the dom0less use case or to have the PCI
> >>>>>> bus enumerated from an other domain.
> >>>>>> @oleksandr: can you comment on this one, you might have a better
> >>>>>> answer than me on this ?
> >>>>> 
> >>>>> Well, without Xen doing the enumeration, some other entity would need
> >>>>> to do so, including the reporting to Xen. Obviously without a Dom0 it
> >>>>> would be ambiguous which domain to assign the device to; perhaps it
> >>>>> should be the caller in this case? That would make that caller domain
> >>>>> a pseudo-hwdom though, as far as PCI is concerned, which may not be
> >>>>> desirable according to my (limited) understanding of dom0less.
> >>>> 
> >>>> This is not really related to this patch but the plan is the following:
> >>>> - enumeration would have to be done by the firmware or boot loader before
> >>>> - xen will have some code to detect PCI devices
> >>>> - dom0less can be used to assign PCI devices to guest
> >>>> 
> >>>> Anyway does not change the fact that this must be called when domain is
> >>>> not NULL and I will fix that.
> >>> 
> >>> Since we now all seem to agree that the NULL would have been a problem,
> >>> may I ask in how far any of this has actually been tested?
> >> 
> >> With the whole serie currently on gitlab we have extensively tested passing
> >> through PCI devices on Arm in several configuration (number of device, MSI,
> >> MSI-X) and check that PCI was still functional on x86.
> >> 
> >> With the patches pushed to Xen right now it was checked that:
> >> - xen compiles properly on arm32, arm64 and x86
> >> - xen compiles properly with VPCI activated (using a patch) on arm32 and arm64
> >> - xen on x86 is functionnal (using basic test on QEMU)
> >> - xen on arm64 is functionnal (with some extensive tests on different targets)
> > 
> > I thinks it's unlikely, but since I haven't checked myself, could you
> > see if the vpci user-space test harness (tools/tests/vpci) still
> > builds and functions properly?
> 
> Hi Roger,
> 
> Bertrand is going to send the v7, however I’m keen to do this test but unfortunately
> I’ve never used it before and I don’t have an x86 environment, do you have any
> resource that I can read or some guidance?

Oh, you just need to build it (make) and then run it (make run). If
it returns success everything is fine.

Regards, Roger.


From xen-devel-bounces@lists.xenproject.org Fri Oct 15 14:33:29 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 14:33:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.210743.367729 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbOH3-0005Es-Dg; Fri, 15 Oct 2021 14:33:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 210743.367729; Fri, 15 Oct 2021 14:33:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbOH3-0005El-AV; Fri, 15 Oct 2021 14:33:29 +0000
Received: by outflank-mailman (input) for mailman id 210743;
 Fri, 15 Oct 2021 14:33:28 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=esao=PD=suse.com=jgross@srs-us1.protection.inumbo.net>)
 id 1mbOH2-0005Ed-DU
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 14:33:28 +0000
Received: from smtp-out2.suse.de (unknown [195.135.220.29])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id fcc1f586-4dd8-48c8-b1f6-fff0bae09e78;
 Fri, 15 Oct 2021 14:33:24 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 57F311FD50;
 Fri, 15 Oct 2021 14:33:23 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1794813C29;
 Fri, 15 Oct 2021 14:33:23 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id qn9+BDORaWFlTgAAMHmgww
 (envelope-from <jgross@suse.com>); Fri, 15 Oct 2021 14:33:23 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fcc1f586-4dd8-48c8-b1f6-fff0bae09e78
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1634308403; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:  content-transfer-encoding:content-transfer-encoding;
	bh=F3kepskjvyVwimHlSrmq0OiX2n5/35tVfRLzRvQBZrY=;
	b=G5s/oPCFmUkt02ZywkeXQOrBt4yDDlAWOfppvdIBUS8PYDO+z4KGDSplzDco9Nz3zVf/6o
	RvJdt8Wm2ohB2X+XNZpK1CfP6Lkuhcu4AzaUzdCapZHi5quYK0Tumx5hA9Cx6I/6ZZKSEq
	HexfCNLo1+s1DaWDtomRFBJOnDrwaX8=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org,
	linux-kernel@vger.kernel.org,
	linux-scsi@vger.kernel.org
Cc: gregkh@linuxfoundation.org,
	Juergen Gross <jgross@suse.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>
Subject: [PATCH] xen: fix wrong SPDX headers of Xen related headers
Date: Fri, 15 Oct 2021 16:33:12 +0200
Message-Id: <20211015143312.29900-1-jgross@suse.com>
X-Mailer: git-send-email 2.26.2
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Commit b24413180f5600 ("License cleanup: add SPDX GPL-2.0 license
identifier to files with no license") was meant to do a tree-wide
cleanup for files without any license information by adding a SPDX
GPL-2.0 line to them.

Unfortunately this was applied even to several Xen-related headers
which have been originally under the MIT license, but obviously have
been copied to the Linux tree from the Xen project without keeping the
license boiler plate as required.

Correct that by changing the license of those files back to "MIT".

Some files still contain the MIT license text. Replace that by the
related SPDX line.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 include/xen/interface/callback.h       | 19 +------------------
 include/xen/interface/elfnote.h        | 19 +------------------
 include/xen/interface/event_channel.h  |  2 +-
 include/xen/interface/features.h       |  2 +-
 include/xen/interface/grant_table.h    | 19 +------------------
 include/xen/interface/hvm/dm_op.h      | 19 +------------------
 include/xen/interface/hvm/hvm_op.h     | 20 +-------------------
 include/xen/interface/hvm/hvm_vcpu.h   | 19 +------------------
 include/xen/interface/hvm/params.h     | 20 +-------------------
 include/xen/interface/hvm/start_info.h | 19 +------------------
 include/xen/interface/io/9pfs.h        | 19 +------------------
 include/xen/interface/io/blkif.h       |  2 +-
 include/xen/interface/io/console.h     |  2 +-
 include/xen/interface/io/displif.h     | 19 +------------------
 include/xen/interface/io/fbif.h        | 19 +------------------
 include/xen/interface/io/kbdif.h       | 19 +------------------
 include/xen/interface/io/netif.h       | 19 +------------------
 include/xen/interface/io/pciif.h       | 19 +------------------
 include/xen/interface/io/protocols.h   |  2 +-
 include/xen/interface/io/pvcalls.h     |  2 ++
 include/xen/interface/io/ring.h        | 19 +------------------
 include/xen/interface/io/sndif.h       | 19 +------------------
 include/xen/interface/io/vscsiif.h     | 19 +------------------
 include/xen/interface/io/xenbus.h      |  2 +-
 include/xen/interface/io/xs_wire.h     |  2 +-
 include/xen/interface/memory.h         |  2 +-
 include/xen/interface/nmi.h            |  2 +-
 include/xen/interface/physdev.h        | 20 +-------------------
 include/xen/interface/platform.h       | 19 +------------------
 include/xen/interface/sched.h          | 19 +------------------
 include/xen/interface/vcpu.h           | 19 +------------------
 include/xen/interface/version.h        |  2 +-
 include/xen/interface/xen-mca.h        |  1 +
 include/xen/interface/xen.h            | 19 +------------------
 include/xen/interface/xenpmu.h         |  2 +-
 35 files changed, 36 insertions(+), 410 deletions(-)

diff --git a/include/xen/interface/callback.h b/include/xen/interface/callback.h
index dc3193f4b581..c67822a25ea6 100644
--- a/include/xen/interface/callback.h
+++ b/include/xen/interface/callback.h
@@ -1,26 +1,9 @@
+/* SPDX-License-Identifier: MIT */
 /******************************************************************************
  * callback.h
  *
  * Register guest OS callbacks with Xen.
  *
- * Permission is hereby granted, free of charge, to any person obtaining a copy
- * of this software and associated documentation files (the "Software"), to
- * deal in the Software without restriction, including without limitation the
- * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or
- * sell copies of the Software, and to permit persons to whom the Software is
- * furnished to do so, subject to the following conditions:
- *
- * The above copyright notice and this permission notice shall be included in
- * all copies or substantial portions of the Software.
- *
- * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
- * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
- * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
- * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
- * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
- * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
- * DEALINGS IN THE SOFTWARE.
- *
  * Copyright (c) 2006, Ian Campbell
  */
 
diff --git a/include/xen/interface/elfnote.h b/include/xen/interface/elfnote.h
index 449bd383cb76..38deb1214613 100644
--- a/include/xen/interface/elfnote.h
+++ b/include/xen/interface/elfnote.h
@@ -1,26 +1,9 @@
+/* SPDX-License-Identifier: MIT */
 /******************************************************************************
  * elfnote.h
  *
  * Definitions used for the Xen ELF notes.
  *
- * Permission is hereby granted, free of charge, to any person obtaining a copy
- * of this software and associated documentation files (the "Software"), to
- * deal in the Software without restriction, including without limitation the
- * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or
- * sell copies of the Software, and to permit persons to whom the Software is
- * furnished to do so, subject to the following conditions:
- *
- * The above copyright notice and this permission notice shall be included in
- * all copies or substantial portions of the Software.
- *
- * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
- * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
- * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
- * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
- * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
- * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
- * DEALINGS IN THE SOFTWARE.
- *
  * Copyright (c) 2006, Ian Campbell, XenSource Ltd.
  */
 
diff --git a/include/xen/interface/event_channel.h b/include/xen/interface/event_channel.h
index cf80e338fbb0..5f8da466e8a9 100644
--- a/include/xen/interface/event_channel.h
+++ b/include/xen/interface/event_channel.h
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0 */
+/* SPDX-License-Identifier: MIT */
 /******************************************************************************
  * event_channel.h
  *
diff --git a/include/xen/interface/features.h b/include/xen/interface/features.h
index 5a7bdefa06a8..53f760378e39 100644
--- a/include/xen/interface/features.h
+++ b/include/xen/interface/features.h
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0 */
+/* SPDX-License-Identifier: MIT */
 /******************************************************************************
  * features.h
  *
diff --git a/include/xen/interface/grant_table.h b/include/xen/interface/grant_table.h
index 7fb7112d667c..3eeabbc7ee09 100644
--- a/include/xen/interface/grant_table.h
+++ b/include/xen/interface/grant_table.h
@@ -1,27 +1,10 @@
+/* SPDX-License-Identifier: MIT */
 /******************************************************************************
  * grant_table.h
  *
  * Interface for granting foreign access to page frames, and receiving
  * page-ownership transfers.
  *
- * Permission is hereby granted, free of charge, to any person obtaining a copy
- * of this software and associated documentation files (the "Software"), to
- * deal in the Software without restriction, including without limitation the
- * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or
- * sell copies of the Software, and to permit persons to whom the Software is
- * furnished to do so, subject to the following conditions:
- *
- * The above copyright notice and this permission notice shall be included in
- * all copies or substantial portions of the Software.
- *
- * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
- * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
- * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
- * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
- * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
- * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
- * DEALINGS IN THE SOFTWARE.
- *
  * Copyright (c) 2004, K A Fraser
  */
 
diff --git a/include/xen/interface/hvm/dm_op.h b/include/xen/interface/hvm/dm_op.h
index ee9e480bc559..08d972f87c7b 100644
--- a/include/xen/interface/hvm/dm_op.h
+++ b/include/xen/interface/hvm/dm_op.h
@@ -1,23 +1,6 @@
+/* SPDX-License-Identifier: MIT */
 /*
  * Copyright (c) 2016, Citrix Systems Inc
- *
- * Permission is hereby granted, free of charge, to any person obtaining a copy
- * of this software and associated documentation files (the "Software"), to
- * deal in the Software without restriction, including without limitation the
- * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or
- * sell copies of the Software, and to permit persons to whom the Software is
- * furnished to do so, subject to the following conditions:
- *
- * The above copyright notice and this permission notice shall be included in
- * all copies or substantial portions of the Software.
- *
- * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
- * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
- * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
- * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
- * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
- * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
- * DEALINGS IN THE SOFTWARE.
  */
 
 #ifndef __XEN_PUBLIC_HVM_DM_OP_H__
diff --git a/include/xen/interface/hvm/hvm_op.h b/include/xen/interface/hvm/hvm_op.h
index 25d945ef17de..f3097e79bb03 100644
--- a/include/xen/interface/hvm/hvm_op.h
+++ b/include/xen/interface/hvm/hvm_op.h
@@ -1,22 +1,4 @@
-/*
- * Permission is hereby granted, free of charge, to any person obtaining a copy
- * of this software and associated documentation files (the "Software"), to
- * deal in the Software without restriction, including without limitation the
- * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or
- * sell copies of the Software, and to permit persons to whom the Software is
- * furnished to do so, subject to the following conditions:
- *
- * The above copyright notice and this permission notice shall be included in
- * all copies or substantial portions of the Software.
- *
- * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
- * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
- * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
- * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
- * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
- * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
- * DEALINGS IN THE SOFTWARE.
- */
+/* SPDX-License-Identifier: MIT */
 
 #ifndef __XEN_PUBLIC_HVM_HVM_OP_H__
 #define __XEN_PUBLIC_HVM_HVM_OP_H__
diff --git a/include/xen/interface/hvm/hvm_vcpu.h b/include/xen/interface/hvm/hvm_vcpu.h
index bfc2138e0bf5..cbf93493275c 100644
--- a/include/xen/interface/hvm/hvm_vcpu.h
+++ b/include/xen/interface/hvm/hvm_vcpu.h
@@ -1,22 +1,5 @@
+/* SPDX-License-Identifier: MIT */
 /*
- * Permission is hereby granted, free of charge, to any person obtaining a copy
- * of this software and associated documentation files (the "Software"), to
- * deal in the Software without restriction, including without limitation the
- * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or
- * sell copies of the Software, and to permit persons to whom the Software is
- * furnished to do so, subject to the following conditions:
- *
- * The above copyright notice and this permission notice shall be included in
- * all copies or substantial portions of the Software.
- *
- * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
- * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
- * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
- * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
- * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
- * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
- * DEALINGS IN THE SOFTWARE.
- *
  * Copyright (c) 2015, Roger Pau Monne <roger.pau@citrix.com>
  */
 
diff --git a/include/xen/interface/hvm/params.h b/include/xen/interface/hvm/params.h
index 4d61fc58d99d..4e2c94b3c466 100644
--- a/include/xen/interface/hvm/params.h
+++ b/include/xen/interface/hvm/params.h
@@ -1,22 +1,4 @@
-/*
- * Permission is hereby granted, free of charge, to any person obtaining a copy
- * of this software and associated documentation files (the "Software"), to
- * deal in the Software without restriction, including without limitation the
- * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or
- * sell copies of the Software, and to permit persons to whom the Software is
- * furnished to do so, subject to the following conditions:
- *
- * The above copyright notice and this permission notice shall be included in
- * all copies or substantial portions of the Software.
- *
- * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
- * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
- * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
- * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
- * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
- * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
- * DEALINGS IN THE SOFTWARE.
- */
+/* SPDX-License-Identifier: MIT */
 
 #ifndef __XEN_PUBLIC_HVM_PARAMS_H__
 #define __XEN_PUBLIC_HVM_PARAMS_H__
diff --git a/include/xen/interface/hvm/start_info.h b/include/xen/interface/hvm/start_info.h
index 50af9ea2ff1e..e33557c0b4e9 100644
--- a/include/xen/interface/hvm/start_info.h
+++ b/include/xen/interface/hvm/start_info.h
@@ -1,22 +1,5 @@
+/* SPDX-License-Identifier: MIT */
 /*
- * Permission is hereby granted, free of charge, to any person obtaining a copy
- * of this software and associated documentation files (the "Software"), to
- * deal in the Software without restriction, including without limitation the
- * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or
- * sell copies of the Software, and to permit persons to whom the Software is
- * furnished to do so, subject to the following conditions:
- *
- * The above copyright notice and this permission notice shall be included in
- * all copies or substantial portions of the Software.
- *
- * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
- * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
- * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
- * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
- * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
- * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
- * DEALINGS IN THE SOFTWARE.
- *
  * Copyright (c) 2016, Citrix Systems, Inc.
  */
 
diff --git a/include/xen/interface/io/9pfs.h b/include/xen/interface/io/9pfs.h
index 5b6c19dae5e2..f1a4c5ad2fd1 100644
--- a/include/xen/interface/io/9pfs.h
+++ b/include/xen/interface/io/9pfs.h
@@ -1,24 +1,7 @@
+/* SPDX-License-Identifier: MIT */
 /*
  * 9pfs.h -- Xen 9PFS transport
  *
- * Permission is hereby granted, free of charge, to any person obtaining a copy
- * of this software and associated documentation files (the "Software"), to
- * deal in the Software without restriction, including without limitation the
- * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or
- * sell copies of the Software, and to permit persons to whom the Software is
- * furnished to do so, subject to the following conditions:
- *
- * The above copyright notice and this permission notice shall be included in
- * all copies or substantial portions of the Software.
- *
- * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
- * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
- * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
- * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
- * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
- * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
- * DEALINGS IN THE SOFTWARE.
- *
  * Copyright (C) 2017 Stefano Stabellini <stefano@aporeto.com>
  */
 
diff --git a/include/xen/interface/io/blkif.h b/include/xen/interface/io/blkif.h
index 5e40041c7e95..ba1e9f5b630e 100644
--- a/include/xen/interface/io/blkif.h
+++ b/include/xen/interface/io/blkif.h
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0 */
+/* SPDX-License-Identifier: MIT */
 /******************************************************************************
  * blkif.h
  *
diff --git a/include/xen/interface/io/console.h b/include/xen/interface/io/console.h
index 85ca8b02695a..cf17e89ed861 100644
--- a/include/xen/interface/io/console.h
+++ b/include/xen/interface/io/console.h
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0 */
+/* SPDX-License-Identifier: MIT */
 /******************************************************************************
  * console.h
  *
diff --git a/include/xen/interface/io/displif.h b/include/xen/interface/io/displif.h
index d43ca0361f86..18417b017869 100644
--- a/include/xen/interface/io/displif.h
+++ b/include/xen/interface/io/displif.h
@@ -1,26 +1,9 @@
+/* SPDX-License-Identifier: MIT */
 /******************************************************************************
  * displif.h
  *
  * Unified display device I/O interface for Xen guest OSes.
  *
- * Permission is hereby granted, free of charge, to any person obtaining a copy
- * of this software and associated documentation files (the "Software"), to
- * deal in the Software without restriction, including without limitation the
- * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or
- * sell copies of the Software, and to permit persons to whom the Software is
- * furnished to do so, subject to the following conditions:
- *
- * The above copyright notice and this permission notice shall be included in
- * all copies or substantial portions of the Software.
- *
- * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
- * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
- * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
- * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
- * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
- * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
- * DEALINGS IN THE SOFTWARE.
- *
  * Copyright (C) 2016-2017 EPAM Systems Inc.
  *
  * Authors: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
diff --git a/include/xen/interface/io/fbif.h b/include/xen/interface/io/fbif.h
index 974a51ed9165..60ca808cef97 100644
--- a/include/xen/interface/io/fbif.h
+++ b/include/xen/interface/io/fbif.h
@@ -1,24 +1,7 @@
+/* SPDX-License-Identifier: MIT */
 /*
  * fbif.h -- Xen virtual frame buffer device
  *
- * Permission is hereby granted, free of charge, to any person obtaining a copy
- * of this software and associated documentation files (the "Software"), to
- * deal in the Software without restriction, including without limitation the
- * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or
- * sell copies of the Software, and to permit persons to whom the Software is
- * furnished to do so, subject to the following conditions:
- *
- * The above copyright notice and this permission notice shall be included in
- * all copies or substantial portions of the Software.
- *
- * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
- * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
- * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
- * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
- * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
- * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
- * DEALINGS IN THE SOFTWARE.
- *
  * Copyright (C) 2005 Anthony Liguori <aliguori@us.ibm.com>
  * Copyright (C) 2006 Red Hat, Inc., Markus Armbruster <armbru@redhat.com>
  */
diff --git a/include/xen/interface/io/kbdif.h b/include/xen/interface/io/kbdif.h
index 5c7630d7376e..b8b08aa53325 100644
--- a/include/xen/interface/io/kbdif.h
+++ b/include/xen/interface/io/kbdif.h
@@ -1,24 +1,7 @@
+/* SPDX-License-Identifier: MIT */
 /*
  * kbdif.h -- Xen virtual keyboard/mouse
  *
- * Permission is hereby granted, free of charge, to any person obtaining a copy
- * of this software and associated documentation files (the "Software"), to
- * deal in the Software without restriction, including without limitation the
- * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or
- * sell copies of the Software, and to permit persons to whom the Software is
- * furnished to do so, subject to the following conditions:
- *
- * The above copyright notice and this permission notice shall be included in
- * all copies or substantial portions of the Software.
- *
- * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
- * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
- * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
- * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
- * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
- * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
- * DEALINGS IN THE SOFTWARE.
- *
  * Copyright (C) 2005 Anthony Liguori <aliguori@us.ibm.com>
  * Copyright (C) 2006 Red Hat, Inc., Markus Armbruster <armbru@redhat.com>
  */
diff --git a/include/xen/interface/io/netif.h b/include/xen/interface/io/netif.h
index 2194322c3c7f..cb0c1a25d5d4 100644
--- a/include/xen/interface/io/netif.h
+++ b/include/xen/interface/io/netif.h
@@ -1,26 +1,9 @@
+/* SPDX-License-Identifier: MIT */
 /******************************************************************************
  * xen_netif.h
  *
  * Unified network-device I/O interface for Xen guest OSes.
  *
- * Permission is hereby granted, free of charge, to any person obtaining a copy
- * of this software and associated documentation files (the "Software"), to
- * deal in the Software without restriction, including without limitation the
- * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or
- * sell copies of the Software, and to permit persons to whom the Software is
- * furnished to do so, subject to the following conditions:
- *
- * The above copyright notice and this permission notice shall be included in
- * all copies or substantial portions of the Software.
- *
- * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
- * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
- * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
- * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
- * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
- * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
- * DEALINGS IN THE SOFTWARE.
- *
  * Copyright (c) 2003-2004, Keir Fraser
  */
 
diff --git a/include/xen/interface/io/pciif.h b/include/xen/interface/io/pciif.h
index d9922ae36eb5..d1a87b62daae 100644
--- a/include/xen/interface/io/pciif.h
+++ b/include/xen/interface/io/pciif.h
@@ -1,24 +1,7 @@
+/* SPDX-License-Identifier: MIT */
 /*
  * PCI Backend/Frontend Common Data Structures & Macros
  *
- * Permission is hereby granted, free of charge, to any person obtaining a copy
- * of this software and associated documentation files (the "Software"), to
- * deal in the Software without restriction, including without limitation the
- * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or
- * sell copies of the Software, and to permit persons to whom the Software is
- * furnished to do so, subject to the following conditions:
- *
- * The above copyright notice and this permission notice shall be included in
- * all copies or substantial portions of the Software.
- *
- * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
- * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
- * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
- * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
- * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
- * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
- * DEALINGS IN THE SOFTWARE.
- *
  *   Author: Ryan Wilson <hap9@epoch.ncsc.mil>
  */
 #ifndef __XEN_PCI_COMMON_H__
diff --git a/include/xen/interface/io/protocols.h b/include/xen/interface/io/protocols.h
index 6a89dc1bf225..22099bb4079f 100644
--- a/include/xen/interface/io/protocols.h
+++ b/include/xen/interface/io/protocols.h
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0 */
+/* SPDX-License-Identifier: MIT */
 #ifndef __XEN_PROTOCOLS_H__
 #define __XEN_PROTOCOLS_H__
 
diff --git a/include/xen/interface/io/pvcalls.h b/include/xen/interface/io/pvcalls.h
index ccf97b817e72..b6680fdbe2a8 100644
--- a/include/xen/interface/io/pvcalls.h
+++ b/include/xen/interface/io/pvcalls.h
@@ -1,3 +1,5 @@
+/* SPDX-License-Identifier: MIT */
+
 #ifndef __XEN_PUBLIC_IO_XEN_PVCALLS_H__
 #define __XEN_PUBLIC_IO_XEN_PVCALLS_H__
 
diff --git a/include/xen/interface/io/ring.h b/include/xen/interface/io/ring.h
index b39cdbc522ec..2470ec45ebb2 100644
--- a/include/xen/interface/io/ring.h
+++ b/include/xen/interface/io/ring.h
@@ -1,26 +1,9 @@
+/* SPDX-License-Identifier: MIT */
 /******************************************************************************
  * ring.h
  *
  * Shared producer-consumer ring macros.
  *
- * Permission is hereby granted, free of charge, to any person obtaining a copy
- * of this software and associated documentation files (the "Software"), to
- * deal in the Software without restriction, including without limitation the
- * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or
- * sell copies of the Software, and to permit persons to whom the Software is
- * furnished to do so, subject to the following conditions:
- *
- * The above copyright notice and this permission notice shall be included in
- * all copies or substantial portions of the Software.
- *
- * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
- * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
- * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
- * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
- * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
- * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
- * DEALINGS IN THE SOFTWARE.
- *
  * Tim Deegan and Andrew Warfield November 2004.
  */
 
diff --git a/include/xen/interface/io/sndif.h b/include/xen/interface/io/sndif.h
index 2aac8f73614c..445657cdb1de 100644
--- a/include/xen/interface/io/sndif.h
+++ b/include/xen/interface/io/sndif.h
@@ -1,26 +1,9 @@
+/* SPDX-License-Identifier: MIT */
 /******************************************************************************
  * sndif.h
  *
  * Unified sound-device I/O interface for Xen guest OSes.
  *
- * Permission is hereby granted, free of charge, to any person obtaining a copy
- * of this software and associated documentation files (the "Software"), to
- * deal in the Software without restriction, including without limitation the
- * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or
- * sell copies of the Software, and to permit persons to whom the Software is
- * furnished to do so, subject to the following conditions:
- *
- * The above copyright notice and this permission notice shall be included in
- * all copies or substantial portions of the Software.
- *
- * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
- * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
- * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
- * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
- * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
- * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
- * DEALINGS IN THE SOFTWARE.
- *
  * Copyright (C) 2013-2015 GlobalLogic Inc.
  * Copyright (C) 2016-2017 EPAM Systems Inc.
  *
diff --git a/include/xen/interface/io/vscsiif.h b/include/xen/interface/io/vscsiif.h
index d07d7aca8d1c..1f6047d3de44 100644
--- a/include/xen/interface/io/vscsiif.h
+++ b/include/xen/interface/io/vscsiif.h
@@ -1,26 +1,9 @@
+/* SPDX-License-Identifier: MIT */
 /******************************************************************************
  * vscsiif.h
  *
  * Based on the blkif.h code.
  *
- * Permission is hereby granted, free of charge, to any person obtaining a copy
- * of this software and associated documentation files (the "Software"), to
- * deal in the Software without restriction, including without limitation the
- * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or
- * sell copies of the Software, and to permit persons to whom the Software is
- * furnished to do so, subject to the following conditions:
- *
- * The above copyright notice and this permission notice shall be included in
- * all copies or substantial portions of the Software.
- *
- * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
- * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
- * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
- * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
- * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
- * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
- * DEALINGS IN THE SOFTWARE.
- *
  * Copyright(c) FUJITSU Limited 2008.
  */
 
diff --git a/include/xen/interface/io/xenbus.h b/include/xen/interface/io/xenbus.h
index fb8716112251..44456e2853fc 100644
--- a/include/xen/interface/io/xenbus.h
+++ b/include/xen/interface/io/xenbus.h
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0 */
+/* SPDX-License-Identifier: MIT */
 /*****************************************************************************
  * xenbus.h
  *
diff --git a/include/xen/interface/io/xs_wire.h b/include/xen/interface/io/xs_wire.h
index 1517c7e93a3a..d40a44f09b16 100644
--- a/include/xen/interface/io/xs_wire.h
+++ b/include/xen/interface/io/xs_wire.h
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0 */
+/* SPDX-License-Identifier: MIT */
 /*
  * Details of the "wire" protocol between Xen Store Daemon and client
  * library or guest kernel.
diff --git a/include/xen/interface/memory.h b/include/xen/interface/memory.h
index 447004861f00..1a371a825c55 100644
--- a/include/xen/interface/memory.h
+++ b/include/xen/interface/memory.h
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0 */
+/* SPDX-License-Identifier: MIT */
 /******************************************************************************
  * memory.h
  *
diff --git a/include/xen/interface/nmi.h b/include/xen/interface/nmi.h
index 73d9b0a2974e..b665fdbef1fd 100644
--- a/include/xen/interface/nmi.h
+++ b/include/xen/interface/nmi.h
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0 */
+/* SPDX-License-Identifier: MIT */
 /******************************************************************************
  * nmi.h
  *
diff --git a/include/xen/interface/physdev.h b/include/xen/interface/physdev.h
index 610dba9b620a..a237af867873 100644
--- a/include/xen/interface/physdev.h
+++ b/include/xen/interface/physdev.h
@@ -1,22 +1,4 @@
-/*
- * Permission is hereby granted, free of charge, to any person obtaining a copy
- * of this software and associated documentation files (the "Software"), to
- * deal in the Software without restriction, including without limitation the
- * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or
- * sell copies of the Software, and to permit persons to whom the Software is
- * furnished to do so, subject to the following conditions:
- *
- * The above copyright notice and this permission notice shall be included in
- * all copies or substantial portions of the Software.
- *
- * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
- * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
- * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
- * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
- * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
- * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
- * DEALINGS IN THE SOFTWARE.
- */
+/* SPDX-License-Identifier: MIT */
 
 #ifndef __XEN_PUBLIC_PHYSDEV_H__
 #define __XEN_PUBLIC_PHYSDEV_H__
diff --git a/include/xen/interface/platform.h b/include/xen/interface/platform.h
index 732efb08c3e1..655d92e803e1 100644
--- a/include/xen/interface/platform.h
+++ b/include/xen/interface/platform.h
@@ -1,26 +1,9 @@
+/* SPDX-License-Identifier: MIT */
 /******************************************************************************
  * platform.h
  *
  * Hardware platform operations. Intended for use by domain-0 kernel.
  *
- * Permission is hereby granted, free of charge, to any person obtaining a copy
- * of this software and associated documentation files (the "Software"), to
- * deal in the Software without restriction, including without limitation the
- * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or
- * sell copies of the Software, and to permit persons to whom the Software is
- * furnished to do so, subject to the following conditions:
- *
- * The above copyright notice and this permission notice shall be included in
- * all copies or substantial portions of the Software.
- *
- * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
- * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
- * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
- * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
- * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
- * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
- * DEALINGS IN THE SOFTWARE.
- *
  * Copyright (c) 2002-2006, K Fraser
  */
 
diff --git a/include/xen/interface/sched.h b/include/xen/interface/sched.h
index a4c4d735d781..4dac0634ffff 100644
--- a/include/xen/interface/sched.h
+++ b/include/xen/interface/sched.h
@@ -1,26 +1,9 @@
+/* SPDX-License-Identifier: MIT */
 /******************************************************************************
  * sched.h
  *
  * Scheduler state interactions
  *
- * Permission is hereby granted, free of charge, to any person obtaining a copy
- * of this software and associated documentation files (the "Software"), to
- * deal in the Software without restriction, including without limitation the
- * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or
- * sell copies of the Software, and to permit persons to whom the Software is
- * furnished to do so, subject to the following conditions:
- *
- * The above copyright notice and this permission notice shall be included in
- * all copies or substantial portions of the Software.
- *
- * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
- * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
- * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
- * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
- * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
- * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
- * DEALINGS IN THE SOFTWARE.
- *
  * Copyright (c) 2005, Keir Fraser <keir@xensource.com>
  */
 
diff --git a/include/xen/interface/vcpu.h b/include/xen/interface/vcpu.h
index 504c71601511..c7cc28ad8d63 100644
--- a/include/xen/interface/vcpu.h
+++ b/include/xen/interface/vcpu.h
@@ -1,26 +1,9 @@
+/* SPDX-License-Identifier: MIT */
 /******************************************************************************
  * vcpu.h
  *
  * VCPU initialisation, query, and hotplug.
  *
- * Permission is hereby granted, free of charge, to any person obtaining a copy
- * of this software and associated documentation files (the "Software"), to
- * deal in the Software without restriction, including without limitation the
- * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or
- * sell copies of the Software, and to permit persons to whom the Software is
- * furnished to do so, subject to the following conditions:
- *
- * The above copyright notice and this permission notice shall be included in
- * all copies or substantial portions of the Software.
- *
- * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
- * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
- * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
- * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
- * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
- * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
- * DEALINGS IN THE SOFTWARE.
- *
  * Copyright (c) 2005, Keir Fraser <keir@xensource.com>
  */
 
diff --git a/include/xen/interface/version.h b/include/xen/interface/version.h
index 8772b552c006..37d6588873d6 100644
--- a/include/xen/interface/version.h
+++ b/include/xen/interface/version.h
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0 */
+/* SPDX-License-Identifier: MIT */
 /******************************************************************************
  * version.h
  *
diff --git a/include/xen/interface/xen-mca.h b/include/xen/interface/xen-mca.h
index 7483a78d2425..464aa6b3a5f9 100644
--- a/include/xen/interface/xen-mca.h
+++ b/include/xen/interface/xen-mca.h
@@ -1,3 +1,4 @@
+/* SPDX-License-Identifier: MIT */
 /******************************************************************************
  * arch-x86/mca.h
  * Guest OS machine check interface to x86 Xen.
diff --git a/include/xen/interface/xen.h b/include/xen/interface/xen.h
index 5ee37a296481..5e9916939268 100644
--- a/include/xen/interface/xen.h
+++ b/include/xen/interface/xen.h
@@ -1,26 +1,9 @@
+/* SPDX-License-Identifier: MIT */
 /******************************************************************************
  * xen.h
  *
  * Guest OS interface to Xen.
  *
- * Permission is hereby granted, free of charge, to any person obtaining a copy
- * of this software and associated documentation files (the "Software"), to
- * deal in the Software without restriction, including without limitation the
- * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or
- * sell copies of the Software, and to permit persons to whom the Software is
- * furnished to do so, subject to the following conditions:
- *
- * The above copyright notice and this permission notice shall be included in
- * all copies or substantial portions of the Software.
- *
- * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
- * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
- * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
- * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
- * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
- * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
- * DEALINGS IN THE SOFTWARE.
- *
  * Copyright (c) 2004, K A Fraser
  */
 
diff --git a/include/xen/interface/xenpmu.h b/include/xen/interface/xenpmu.h
index ad603eab24b3..e2ee73d91bd6 100644
--- a/include/xen/interface/xenpmu.h
+++ b/include/xen/interface/xenpmu.h
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0 */
+/* SPDX-License-Identifier: MIT */
 #ifndef __XEN_PUBLIC_XENPMU_H__
 #define __XEN_PUBLIC_XENPMU_H__
 
-- 
2.26.2



From xen-devel-bounces@lists.xenproject.org Fri Oct 15 14:53:03 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 14:53:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.210759.367741 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbOZt-0007fi-5T; Fri, 15 Oct 2021 14:52:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 210759.367741; Fri, 15 Oct 2021 14:52:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbOZt-0007fb-2F; Fri, 15 Oct 2021 14:52:57 +0000
Received: by outflank-mailman (input) for mailman id 210759;
 Fri, 15 Oct 2021 14:52:55 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mbOZr-0007fV-QJ
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 14:52:55 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mbOZq-0006k4-NW; Fri, 15 Oct 2021 14:52:54 +0000
Received: from [54.239.6.185] (helo=[192.168.0.140])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mbOZq-0004wv-GF; Fri, 15 Oct 2021 14:52:54 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=gD1HMW7XLDLxdf9QHfhL6CGsenlzknnMDUpECNWAFzI=; b=F4qf+3qYyBJvcQatLjcmygoVYS
	GBm0zL2q/slTRYkRrNYs8+AGxSwMv21GqYDTZGJoQ0I0w8i67Dt6QDnVmttJaqFQeqwBZW8Nkta3t
	Jd9aNya2L8UuN2apCl+CEkxIFiqYkyJmxno4lX7UnGBzJIy6NCjrr08LPdxxMftBdR+4=;
Message-ID: <0204f92a-4637-d3cd-5420-979e9c03f237@xen.org>
Date: Fri, 15 Oct 2021 15:52:51 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.2.0
Subject: Re: [PATCH v7 5/5] arm/libxl: Emulated PCI device tree node in libxl
To: Bertrand Marquis <bertrand.marquis@arm.com>,
 xen-devel@lists.xenproject.org
Cc: iwj@xenproject.org, Rahul Singh <rahul.singh@arm.com>,
 Wei Liu <wl@xen.org>, Anthony PERARD <anthony.perard@citrix.com>,
 Juergen Gross <jgross@suse.com>, Stefano Stabellini
 <sstabellini@kernel.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Michal Orzel <michal.orzel@arm.com>
References: <cover.1634305870.git.bertrand.marquis@arm.com>
 <4a22121e6474adfb1c5166e0fdaddff47c6dae46.1634305870.git.bertrand.marquis@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <4a22121e6474adfb1c5166e0fdaddff47c6dae46.1634305870.git.bertrand.marquis@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Bertrand,

On 15/10/2021 14:59, Bertrand Marquis wrote:
> From: Rahul Singh <rahul.singh@arm.com>
> 
> libxl will create an emulated PCI device tree node in the device tree to
> enable the guest OS to discover the virtual PCI during guest boot.
> Emulated PCI device tree node will only be created when there is any
> device assigned to guest.
> 
> A new area has been reserved in the arm guest physical map at
> which the VPCI bus is declared in the device tree (reg and ranges
> parameters of the node).
> 
> Note that currently we are using num_pcidevs instead of
> c_info->passthrough to decide whether to create a vPCI DT node.
> This will be insufficient if and when ARM does PCI hotplug.
> Add this note inside libxl_create.c where c_info->passthrough
> is set.
> 
> Signed-off-by: Rahul Singh <rahul.singh@arm.com>
> Signed-off-by: Michal Orzel <michal.orzel@arm.com>

I believe you need to add your signed-off-by here as you sent the new 
version on xen-devel.

With one remark below (not to be handled for 4.16):

Reviewed-by: Julien Grall <jgrall@amazon.com>

> +static int make_vpci_node(libxl__gc *gc, void *fdt,
> +                          const struct arch_info *ainfo,
> +                          struct xc_dom_image *dom)
> +{
> +    int res;
> +    const uint64_t vpci_ecam_base = GUEST_VPCI_ECAM_BASE;
> +    const uint64_t vpci_ecam_size = GUEST_VPCI_ECAM_SIZE;
> +    const char *name = GCSPRINTF("pcie@%"PRIx64, vpci_ecam_base);
> +
> +    res = fdt_begin_node(fdt, name);
> +    if (res) return res;
> +
> +    res = fdt_property_compat(gc, fdt, 1, "pci-host-ecam-generic");
> +    if (res) return res;
> +
> +    res = fdt_property_string(fdt, "device_type", "pci");
> +    if (res) return res;
> +
> +    res = fdt_property_regs(gc, fdt, GUEST_ROOT_ADDRESS_CELLS,
> +            GUEST_ROOT_SIZE_CELLS, 1, vpci_ecam_base, vpci_ecam_size);
> +    if (res) return res;
> +
> +    res = fdt_property_values(gc, fdt, "bus-range", 2, 0, 255);
> +    if (res) return res;
> +
> +    res = fdt_property_cell(fdt, "#address-cells", 3);
> +    if (res) return res;
> +
> +    res = fdt_property_cell(fdt, "#size-cells", 2);
> +    if (res) return res;
> +
> +    res = fdt_property_string(fdt, "status", "okay");
> +    if (res) return res;
> +
> +    res = fdt_property_vpci_ranges(gc, fdt, GUEST_ROOT_ADDRESS_CELLS,
> +        GUEST_ROOT_SIZE_CELLS, 2,
> +        GUEST_VPCI_ADDR_TYPE_MEM, GUEST_VPCI_MEM_ADDR, GUEST_VPCI_MEM_SIZE,
> +        GUEST_VPCI_ADDR_TYPE_PREFETCH_MEM, GUEST_VPCI_PREFETCH_MEM_ADDR,

 From my understanding, the prefetch memory region is optional. Is it 
going to be a problem to expose one for the vCPI when the host PCI 
hostbridge may not support it?

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Oct 15 15:05:13 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 15:05:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.210768.367752 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbOlW-0000kW-8s; Fri, 15 Oct 2021 15:04:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 210768.367752; Fri, 15 Oct 2021 15:04:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbOlW-0000kP-5j; Fri, 15 Oct 2021 15:04:58 +0000
Received: by outflank-mailman (input) for mailman id 210768;
 Fri, 15 Oct 2021 15:04:56 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Fqmt=PD=arm.com=Bertrand.Marquis@srs-us1.protection.inumbo.net>)
 id 1mbOlU-0000kJ-IT
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 15:04:56 +0000
Received: from EUR02-HE1-obe.outbound.protection.outlook.com (unknown
 [40.107.1.86]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 0e680471-be91-47c7-a531-90f7b9b93526;
 Fri, 15 Oct 2021 15:04:54 +0000 (UTC)
Received: from AM6P194CA0028.EURP194.PROD.OUTLOOK.COM (2603:10a6:209:90::41)
 by HE1PR0802MB2540.eurprd08.prod.outlook.com (2603:10a6:3:d4::17) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.20; Fri, 15 Oct
 2021 15:04:52 +0000
Received: from VE1EUR03FT056.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:209:90:cafe::b1) by AM6P194CA0028.outlook.office365.com
 (2603:10a6:209:90::41) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.14 via Frontend
 Transport; Fri, 15 Oct 2021 15:04:52 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT056.mail.protection.outlook.com (10.152.19.28) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.15 via Frontend Transport; Fri, 15 Oct 2021 15:04:52 +0000
Received: ("Tessian outbound 16951d3c485e:v103");
 Fri, 15 Oct 2021 15:04:51 +0000
Received: from c9771da20a92.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 F903488B-5160-4AC5-9F6D-47ECF7A9B007.1; 
 Fri, 15 Oct 2021 15:04:41 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id c9771da20a92.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 15 Oct 2021 15:04:41 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com (2603:10a6:4:74::9)
 by DB6PR0801MB1862.eurprd08.prod.outlook.com (2603:10a6:4:75::21) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.17; Fri, 15 Oct
 2021 15:04:37 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955]) by DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955%4]) with mapi id 15.20.4587.031; Fri, 15 Oct 2021
 15:04:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0e680471-be91-47c7-a531-90f7b9b93526
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=FrKl4S1boW/FetRzJ4k3nbpvsIkHmkx/mkFE6eNhl0E=;
 b=EQxt72PfQKXiWB2zaAS68pBK2aLXTO+S7izchvLuyuIx0TUwlZ44vbN9I/92tutrezQCIVnZzFBscc/We1mTAtgPFKDlRdnIIt6DkemS8B4s6Ez4w2vQCCorfJLa5UIWBFRJPF49o3rCTAioiRZTCK8qfHHWW9m8ZP7lHn6CnWw=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: a37943207c259c67
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=FQxZVBsu5FOPR1PDGVl1Nfxjs9NUsfSMc+IAic9rRCspJXqFkR3HfWLhtH0r+cC6ECRRnDe3pyoMtXeattgRbje47289dKDa2MU4Rvfo+3Nle5KElfP24rMPP3sXmgcJnlmQOUPLC9+p6L+mclBKmAdprGlhstC+v0jndOpg6qDEQMIxjH4f0wg0nNuR1scwH7yWDbeC0PEOR3gD8WoJkfNKY0HWrCuRhchT3802P8h0+XHvdZu4XtzvBbywiPSy2UU24GeNjo5MG0vCvlWexb3wUnFYv69o7a4cf/X+1EUnQpXEDYgulhdUCQFTcQnBzk3M3jxj5zVmUk7EFFRQSQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=FrKl4S1boW/FetRzJ4k3nbpvsIkHmkx/mkFE6eNhl0E=;
 b=hnGUi7JI3lZvVHdgAYF9NP7wQ1Dq6GjWus1+4tg8fhTj82anoG4bPIzANcYNGNA/NOqiFyf5gL0+UvDYYinEVu9WEVkax6bEnWKY/FofSQ/0vJCz7EI+pQAW/jw4erg5+ttTHdFXyl5YFISetUPBQv25SgLzjukL8czXOsjOpb5PGhWEs+Je9BKHFiVIct9seaCgfgt9ND6U+iadt9bVskhl70u45uEEoMLG2aK9f0ukI03vv22Tlq4MWtYYBlCYQXxMPKQNJmUIf16jKJ2d6JldW7eMNswM7og4xk11J95PnPq6TvfIpryq0Ko7Eegyl0//qlbTj6G3WXdtj7Bcag==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=FrKl4S1boW/FetRzJ4k3nbpvsIkHmkx/mkFE6eNhl0E=;
 b=EQxt72PfQKXiWB2zaAS68pBK2aLXTO+S7izchvLuyuIx0TUwlZ44vbN9I/92tutrezQCIVnZzFBscc/We1mTAtgPFKDlRdnIIt6DkemS8B4s6Ez4w2vQCCorfJLa5UIWBFRJPF49o3rCTAioiRZTCK8qfHHWW9m8ZP7lHn6CnWw=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Julien Grall <julien@xen.org>
CC: Xen-devel <xen-devel@lists.xenproject.org>, "iwj@xenproject.org"
	<iwj@xenproject.org>, Rahul Singh <Rahul.Singh@arm.com>, Wei Liu
	<wl@xen.org>, Anthony PERARD <anthony.perard@citrix.com>, Juergen Gross
	<jgross@suse.com>, Stefano Stabellini <sstabellini@kernel.org>, Volodymyr
 Babchuk <Volodymyr_Babchuk@epam.com>, Michal Orzel <Michal.Orzel@arm.com>
Subject: Re: [PATCH v7 5/5] arm/libxl: Emulated PCI device tree node in libxl
Thread-Topic: [PATCH v7 5/5] arm/libxl: Emulated PCI device tree node in libxl
Thread-Index: AQHXwczxs7P/2oORBkqz9VQaBzYYAavUJQ2AgAADSAA=
Date: Fri, 15 Oct 2021 15:04:37 +0000
Message-ID: <BFD982F5-7567-445F-9819-57E512326222@arm.com>
References: <cover.1634305870.git.bertrand.marquis@arm.com>
 <4a22121e6474adfb1c5166e0fdaddff47c6dae46.1634305870.git.bertrand.marquis@arm.com>
 <0204f92a-4637-d3cd-5420-979e9c03f237@xen.org>
In-Reply-To: <0204f92a-4637-d3cd-5420-979e9c03f237@xen.org>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3654.120.0.1.13)
Authentication-Results-Original: xen.org; dkim=none (message not signed)
 header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: 36cf4fbd-5574-48fc-ba11-08d98fed23fc
x-ms-traffictypediagnostic: DB6PR0801MB1862:|HE1PR0802MB2540:
x-ms-exchange-transport-forked: True
X-Microsoft-Antispam-PRVS:
	<HE1PR0802MB2540EFE5A1CD078F184F13B59DB99@HE1PR0802MB2540.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:10000;OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 XmPjekALAf9YxKze5ML1KLB9K69eNprhxPYTuxRdkpq1rlkKkOsx98mJCctT0+rdPwWBA8nIhMQrJvQ2EcMzw8G/A76xomgcWwjCaCJwNMgGxOlXy8duWZ+0hHBEieKkVIkQ9LQo5sGgptKoW6JRiORKHcbIhIRk4LT+gGjL2nAwo/xC57V5lsWvJbbARoe6JdTFBKpSPZ/1va3U7fvMCFBonHAQJ2uup8C5CpRz7BivAzGkYYx37Ox3dkDMEn25X6XTPdXCcMoPWM8qKkEXFFTJi1fOrBG7+sSzxWlj6QUGw/6ygg57gjjpe0V9MRulitUZU4Qk0dAyPsPvAPl6v+jlhl5DSJKDyImjnJTxRC9TYf/Z/O4Apmhc1TdEEFc19SxqhpZEpIBRRO/LFeKG1bnC2FBnQ212nf7/Xas+nEsN7KVRQegKpTn4IugCT51/I1APk0esWwJM1P3yow+A8z0BRlvNVqpeQTfsVMQ072vhXbItOkclTz4mbvo4lzN7lTMpDpY0ZSdCqe+ynsad/o2JT2wBcNyb1eb39WVMjIDzASoCTtfAZcMhO+ul9pj5asBLc3w7BQXRRRduq1HI9Vxqza2w4WWMUOaifMR/24KcsC8fp5P1slH3OSswmbDPEQjO/9O4fIkklOUkDIO0A44KJOL9kQE9ImzE0ZJ5oXtFIYeHp0ukpi7FZaXYZR/noMggZaqpgibbi5HdReNbFYGyuMowrkQ11m4Fo5uEo8HZQg3cy/6n9yt1EXKoMSXv
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB6PR0801MB2024.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(6486002)(8936002)(33656002)(53546011)(8676002)(38070700005)(4326008)(6512007)(54906003)(38100700002)(6506007)(36756003)(122000001)(64756008)(186003)(66476007)(66556008)(71200400001)(76116006)(66946007)(2906002)(66446008)(26005)(6916009)(5660300002)(86362001)(508600001)(2616005)(316002)(91956017)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="us-ascii"
Content-ID: <F173153BFA83894DBA7046B57FA2C3C9@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0801MB1862
Original-Authentication-Results: xen.org; dkim=none (message not signed)
 header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT056.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	50c6f9ab-f79d-4f89-2657-08d98fed1b3d
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	vkF9EEwCrzpOJVkHAZ7LEjNg99MzncZtujnvi145T58HlGgiPQdgFQO+VPe29H0RgaNxhzKqTvsdiC8maJrIdHz+xHGx3oUfzJFzijDLCvw1gvJg5NukY/IvoTq5Hlg1nG8Ablb36P7XgiHbiq7vfdlmpkJg6IiSmCiaLTa5D5GjJhj/+4oqmUkHH/fON6y8IT9LGSakXGJJPCffe2RpEHtlsp8m2k5i5/35SMmce+XWNjpglM2j4UDFDWGmgcjgauIZTOpN8iYAIKJo3PGYqUXoc6AZMrckecIyfouJ8TkJKICJZ6GjCnU5OddLm7iCkkZopgHJSAjVasS27ALmiZtmRinf8fAm5kd0q/EEH9w9ph/Dx+ncanhdtChI2q4d86c6uvZLakHxjyeNiA59lUYgRlj7CLGoZe387zsIEMHHiJyHVfqBsBW592rq3hJP17wBepsm43sRXXMifJjp+3DTqZLkNT45CNqjL8poUY63Oz1Q/K8Junlq6mbnUFYj3JEKx4edpo379aQi5jOVKa1Y+OBsE5/mUJ4fvR5IDd41WubiC4KGmjyEnu077df0HmDoxD7rd7gt4JsC+w0z+vXhQYyjtDCZsgMj+MotNZrk3KsJ0UwISI5W/z88W51PKlqkaHzFNNKskvMTIULwTto1LQPz5UU9EkmX4Od8GbO/lnINOdxSAT3gpI2/gBGlK9JGRNXM1nVUEZTmCEcs1g==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(70206006)(47076005)(8936002)(5660300002)(356005)(54906003)(81166007)(508600001)(6486002)(82310400003)(36860700001)(33656002)(70586007)(26005)(6512007)(36756003)(316002)(2616005)(6862004)(186003)(2906002)(8676002)(336012)(86362001)(6506007)(4326008)(53546011);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2021 15:04:52.2062
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 36cf4fbd-5574-48fc-ba11-08d98fed23fc
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT056.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0802MB2540

Hi Julien,

> On 15 Oct 2021, at 15:52, Julien Grall <julien@xen.org> wrote:
>=20
> Hi Bertrand,
>=20
> On 15/10/2021 14:59, Bertrand Marquis wrote:
>> From: Rahul Singh <rahul.singh@arm.com>
>> libxl will create an emulated PCI device tree node in the device tree to
>> enable the guest OS to discover the virtual PCI during guest boot.
>> Emulated PCI device tree node will only be created when there is any
>> device assigned to guest.
>> A new area has been reserved in the arm guest physical map at
>> which the VPCI bus is declared in the device tree (reg and ranges
>> parameters of the node).
>> Note that currently we are using num_pcidevs instead of
>> c_info->passthrough to decide whether to create a vPCI DT node.
>> This will be insufficient if and when ARM does PCI hotplug.
>> Add this note inside libxl_create.c where c_info->passthrough
>> is set.
>> Signed-off-by: Rahul Singh <rahul.singh@arm.com>
>> Signed-off-by: Michal Orzel <michal.orzel@arm.com>
>=20
> I believe you need to add your signed-off-by here as you sent the new ver=
sion on xen-devel.

I packed it together but the changes where done by Michal so I did not add =
it.

Could it be added on commit ?

>=20
> With one remark below (not to be handled for 4.16):
>=20
> Reviewed-by: Julien Grall <jgrall@amazon.com>

Thanks

>=20
>> +static int make_vpci_node(libxl__gc *gc, void *fdt,
>> +                          const struct arch_info *ainfo,
>> +                          struct xc_dom_image *dom)
>> +{
>> +    int res;
>> +    const uint64_t vpci_ecam_base =3D GUEST_VPCI_ECAM_BASE;
>> +    const uint64_t vpci_ecam_size =3D GUEST_VPCI_ECAM_SIZE;
>> +    const char *name =3D GCSPRINTF("pcie@%"PRIx64, vpci_ecam_base);
>> +
>> +    res =3D fdt_begin_node(fdt, name);
>> +    if (res) return res;
>> +
>> +    res =3D fdt_property_compat(gc, fdt, 1, "pci-host-ecam-generic");
>> +    if (res) return res;
>> +
>> +    res =3D fdt_property_string(fdt, "device_type", "pci");
>> +    if (res) return res;
>> +
>> +    res =3D fdt_property_regs(gc, fdt, GUEST_ROOT_ADDRESS_CELLS,
>> +            GUEST_ROOT_SIZE_CELLS, 1, vpci_ecam_base, vpci_ecam_size);
>> +    if (res) return res;
>> +
>> +    res =3D fdt_property_values(gc, fdt, "bus-range", 2, 0, 255);
>> +    if (res) return res;
>> +
>> +    res =3D fdt_property_cell(fdt, "#address-cells", 3);
>> +    if (res) return res;
>> +
>> +    res =3D fdt_property_cell(fdt, "#size-cells", 2);
>> +    if (res) return res;
>> +
>> +    res =3D fdt_property_string(fdt, "status", "okay");
>> +    if (res) return res;
>> +
>> +    res =3D fdt_property_vpci_ranges(gc, fdt, GUEST_ROOT_ADDRESS_CELLS,
>> +        GUEST_ROOT_SIZE_CELLS, 2,
>> +        GUEST_VPCI_ADDR_TYPE_MEM, GUEST_VPCI_MEM_ADDR, GUEST_VPCI_MEM_S=
IZE,
>> +        GUEST_VPCI_ADDR_TYPE_PREFETCH_MEM, GUEST_VPCI_PREFETCH_MEM_ADDR=
,
>=20
> From my understanding, the prefetch memory region is optional. Is it goin=
g to be a problem to expose one for the vCPI when the host PCI hostbridge m=
ay not support it?

Good point but I would guess no as the host bridge should not use it.
I keep that as a point to check with Rahul.

Cheers
Bertrand

>=20
> Cheers,
>=20
> --=20
> Julien Grall



From xen-devel-bounces@lists.xenproject.org Fri Oct 15 15:06:50 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 15:06:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.210776.367762 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbOnJ-0001MA-Ky; Fri, 15 Oct 2021 15:06:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 210776.367762; Fri, 15 Oct 2021 15:06:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbOnJ-0001M3-Hu; Fri, 15 Oct 2021 15:06:49 +0000
Received: by outflank-mailman (input) for mailman id 210776;
 Fri, 15 Oct 2021 15:06:47 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Fqmt=PD=arm.com=Bertrand.Marquis@srs-us1.protection.inumbo.net>)
 id 1mbOnH-0001Lu-T5
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 15:06:47 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com (unknown
 [40.107.20.54]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id db27658a-9e27-4202-bf27-14fd81108b1c;
 Fri, 15 Oct 2021 15:06:46 +0000 (UTC)
Received: from DU2PR04CA0238.eurprd04.prod.outlook.com (2603:10a6:10:2b1::33)
 by PA4PR08MB6046.eurprd08.prod.outlook.com (2603:10a6:102:e4::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16; Fri, 15 Oct
 2021 15:06:43 +0000
Received: from DB5EUR03FT037.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:10:2b1:cafe::1d) by DU2PR04CA0238.outlook.office365.com
 (2603:10a6:10:2b1::33) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15 via Frontend
 Transport; Fri, 15 Oct 2021 15:06:43 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT037.mail.protection.outlook.com (10.152.20.215) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.15 via Frontend Transport; Fri, 15 Oct 2021 15:06:43 +0000
Received: ("Tessian outbound e27daf245730:v103");
 Fri, 15 Oct 2021 15:06:42 +0000
Received: from 27232b8faef9.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 5BB6899B-ADFB-41F5-9CDC-7FC97FB555C5.1; 
 Fri, 15 Oct 2021 15:06:31 +0000
Received: from EUR02-AM5-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 27232b8faef9.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 15 Oct 2021 15:06:31 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com (2603:10a6:4:74::9)
 by DB6PR0801MB1862.eurprd08.prod.outlook.com (2603:10a6:4:75::21) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.17; Fri, 15 Oct
 2021 15:06:29 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955]) by DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955%4]) with mapi id 15.20.4587.031; Fri, 15 Oct 2021
 15:06:29 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: db27658a-9e27-4202-bf27-14fd81108b1c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=X4WWQu7W+GeNroKLEzq4EIWTHSqe5cpjxlMyPJ0yiBA=;
 b=R8c03Dtq6UzgdrP4bWaWZ8KHurPbTOsWjeQ6armdvz2Akrm7F/xbEZkU9dB3zGJNKjwwOINvMWDLYIb0bjYBIBiq5Xd+zbDWrJhhhRkcoM12p/gmUzN3/FeuP7t+EW2msA6XBetsrjIE/z/qJ1VGn4wrIPB4P31Yen9DS2kBppU=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: b69892878d90edec
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=dOo2plHG64REaxkg4VHqPN4Aa/hvlYDfylgqknU0+wL38IGbddahHf7mQzEHioCKbf2Nd1Vm9a72G6kMzJB5Cein9HGg7j8bewKce8huRYOqWJIhuID/QRfrywnYrhI3j2xrW9zE9mwLkB7Znui3uIzna5isyJ1KLaL6KK5BqGXw0Ic+NjQvvu9PzCAHYkPbK/a80N0CgUVwEYiJaoO05BkxkU6+ogy+gy6sm8ZoueZrwsb43LKt57tXWC6NuPY6sfSO+1X7YW/HhdUaO11oGUirJdRovBOaBpnrKAk2l148hs5vY3xRZOna8fhzbLHpQzLBNl98I3CuMC/zQ/7DMw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=X4WWQu7W+GeNroKLEzq4EIWTHSqe5cpjxlMyPJ0yiBA=;
 b=eSTy//2zQFxohd5v+cXi21Gs+AXLCpinYl/LPfDkhpi7hzB/jXgXFAM4tx0+rAu1FBSLHk71zB9IyYPW1oLf+cVH7trsDraQjrRXvZG1kTIjq1961Dv2nT49Wg1Sw4tckYwCjLHm1Ec62iY2SHfbFpL2wrn4ozdSHdz78t+kCsmPqhmNMQYyqneuRVwuq9UPqfqsec09+E0TyNgnX6awTvHKlbC4H6rVv0TrGNV+VLanx1qZujbXPKLsPHmEQAo3JejLZxR7LWr6PtJzF2dQi8lZL0dRpwSx2ZmzXVYUgFBbzkEl3ogjqzATfVm3zG8Il/n333UxfBz3SefnPExnPg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=X4WWQu7W+GeNroKLEzq4EIWTHSqe5cpjxlMyPJ0yiBA=;
 b=R8c03Dtq6UzgdrP4bWaWZ8KHurPbTOsWjeQ6armdvz2Akrm7F/xbEZkU9dB3zGJNKjwwOINvMWDLYIb0bjYBIBiq5Xd+zbDWrJhhhRkcoM12p/gmUzN3/FeuP7t+EW2msA6XBetsrjIE/z/qJ1VGn4wrIPB4P31Yen9DS2kBppU=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>, "iwj@xenproject.org"
	<iwj@xenproject.org>, Rahul Singh <Rahul.Singh@arm.com>, Stefano Stabellini
	<sstabellini@kernel.org>, Julien Grall <julien@xen.org>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
	Wei Liu <wl@xen.org>, Paul Durrant <paul@xen.org>
Subject: Re: [PATCH v7 2/5] xen/arm: Enable the existing x86 virtual PCI
 support for ARM
Thread-Topic: [PATCH v7 2/5] xen/arm: Enable the existing x86 virtual PCI
 support for ARM
Thread-Index: AQHXwcz8unryLt1qUEeMdpd7xMjDNavUHq6AgAAKLQA=
Date: Fri, 15 Oct 2021 15:06:28 +0000
Message-ID: <801F3B48-BAA0-4520-8B41-E83627AA845C@arm.com>
References: <cover.1634305870.git.bertrand.marquis@arm.com>
 <847d430fdeb19e695176ddea71eeb11dcef8b23e.1634305870.git.bertrand.marquis@arm.com>
 <YWmQa4uMA8usiHcu@MacBook-Air-de-Roger.local>
In-Reply-To: <YWmQa4uMA8usiHcu@MacBook-Air-de-Roger.local>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3654.120.0.1.13)
Authentication-Results-Original: citrix.com; dkim=none (message not signed)
 header.d=none;citrix.com; dmarc=none action=none header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: 21a5a571-33c4-484c-969a-08d98fed65f8
x-ms-traffictypediagnostic: DB6PR0801MB1862:|PA4PR08MB6046:
x-ms-exchange-transport-forked: True
X-Microsoft-Antispam-PRVS:
	<PA4PR08MB60464EE1EE0A83BCBD6DDDF39DB99@PA4PR08MB6046.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:10000;OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 d9t96IrqxTfP8Nrp/j8cGsFrJRKi02WrGeoBNwvX+ouMKfZM1mN3nbbB6EnabAzUWNDyLWDJ3CRvB3XZMLX7NdPE/fl6wTlYUTS74fBXdWa5EZ98ZG/dy55f/jLZacpAdiinCib+KdMXNfxfouw0B993T/1orJrxYj+M/HdBjn7II2JAQa4IcCJajcdh19AdduaYuKZEbscHozr6NXokQuqPHNqWaNSU9dX+y10tUXzV22xTaqszQJMAgBNJTrI7YCeKzOwyMfEhhmLsf1qgxIbCBS18nLqeRs+mRmJ1CRnXWY/Y0vHM3sx7PezV6C6rVjUgf80l1P91+JmrqIc0P528dMcuvblImZGG7u8LT1Ajd2eoB47lOKNTNt8sJ9w+o8y2842IY7QFwpBQsYbpzLEKTk4Md77KA7riW+ZI965zixPbX0y+6h7SS362P33OqTZkX4HIP9QhPrI8C95hC/K7e+Gel2hj2EQG9fnRsOp/0JD37mGnPjsQefCB4khGiomxcJiiwRFWzpwQVDlN7oNCYh/1CwVL2EOzNRWI5+D5HJ4Bt95rBgPCBNCQpV0VjUrcAB0MvuVOWKQk3gQCojDBgk3RjMkk7CpcxrXysOT0to+MR4jWXrHOAaueRjQQ4i0iogw1TeAptghCivH0y958oSX22vpxsb4QMZVwqRQcFG8dbRhcL4p3Sd3ljJnOx5Z2l2kd5bvNuKzskB/98g6EqrD830bqdcNnP7cWmep/rc/CE14j7c58D6mb2F11
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB6PR0801MB2024.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(6486002)(7416002)(8936002)(33656002)(53546011)(8676002)(38070700005)(4326008)(6512007)(54906003)(38100700002)(6506007)(36756003)(122000001)(83380400001)(64756008)(186003)(66476007)(66556008)(71200400001)(76116006)(66946007)(2906002)(66446008)(26005)(6916009)(5660300002)(86362001)(508600001)(2616005)(316002)(91956017)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-ID: <658B46760F25B349AA298A052C36D4AD@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0801MB1862
Original-Authentication-Results: citrix.com; dkim=none (message not signed)
 header.d=none;citrix.com; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT037.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	c99f32af-73ab-4535-cbeb-08d98fed5da6
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	A21dR+tO+kd138PPue/OYV17i21LN2as78KJdteb+fnwfC668TAlGV4KGp008I+li9jA/8jEgPTcv77kJsZmXSdxRScO3NNDq2M7Wtg0X78JZiL68zYqgE4SqiwvzKP/3AB0qaYeaELM26Ot7a+ZftzJ4r3ZE4ldiXh7jox1Cnbbd4gjovPptgAbKD3R36AVHaKA73EgPa2d4nftG3G4UZiDr8lRaKewVhmiSiYdzA9w4ZEHjWLZDdzVd+o9rSOnA/cJ+WTnd+BEbxS7lw4lgboJ0bC07sU46J+x+Zmz7ydXiP6MjQf/+MxV9B4+6cQKzOUvCEOP6pu/aeyDX5hsW8BBVHwtmlwwjKzrKdrnDfeL4oyU4rkiaA6rjkd2mGNvpmH7SKZ/kiB72Qn7MfnsRI0a3yDIH8vJRoIrj2fyKUIrTQnAhmVdKu3SO0yp3opTGM03Zve/LkqDtoJ9KMZ18Pu1/X0ApbwCKRAy6iochm8hESiaBdUfR7PomOSu6odeS8fntMyb0M8GX+DGS/qNN/biDMBj6ONQFLcbQecv4xLLblnvetPczLc0ZmmVHRUomE5Bl+0fs9yRegJHcfHBAseFYXHJGmOG5YEwYHV/CeiILO0ObxB+iM5XuoErw1d/tP2kuvh1XDWnMoLq9dP68JkxK+CjtrmPqyTUOjf28qU8EsZbqq9q4Ng7S/zlpOP4vpHBwkxJZzIZarH/Zje8qQ==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(4326008)(33656002)(81166007)(8676002)(316002)(356005)(82310400003)(47076005)(336012)(36756003)(508600001)(86362001)(8936002)(186003)(36860700001)(6862004)(2616005)(6512007)(54906003)(70206006)(70586007)(26005)(6486002)(2906002)(83380400001)(5660300002)(53546011)(6506007);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2021 15:06:43.0367
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 21a5a571-33c4-484c-969a-08d98fed65f8
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT037.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB6046

SGkgUm9nZXIsDQoNCj4gT24gMTUgT2N0IDIwMjEsIGF0IDE1OjMwLCBSb2dlciBQYXUgTW9ubsOp
IDxyb2dlci5wYXVAY2l0cml4LmNvbT4gd3JvdGU6DQo+IA0KPiBPbiBGcmksIE9jdCAxNSwgMjAy
MSBhdCAwMjo1OToxOVBNICswMTAwLCBCZXJ0cmFuZCBNYXJxdWlzIHdyb3RlOg0KPj4gRnJvbTog
UmFodWwgU2luZ2ggPHJhaHVsLnNpbmdoQGFybS5jb20+DQo+PiANCj4+IFRoZSBleGlzdGluZyBW
UENJIHN1cHBvcnQgYXZhaWxhYmxlIGZvciBYODYgaXMgYWRhcHRlZCBmb3IgQXJtLg0KPj4gV2hl
biB0aGUgZGV2aWNlIGlzIGFkZGVkIHRvIFhFTiB2aWEgdGhlIGh5cGVyIGNhbGwNCj4+IOKAnFBI
WVNERVZPUF9wY2lfZGV2aWNlX2FkZOKAnSwgVlBDSSBoYW5kbGVyIGZvciB0aGUgY29uZmlnIHNw
YWNlDQo+PiBhY2Nlc3MgaXMgYWRkZWQgdG8gdGhlIFhlbiB0byBlbXVsYXRlIHRoZSBQQ0kgZGV2
aWNlcyBjb25maWcgc3BhY2UuDQo+PiANCj4+IEEgTU1JTyB0cmFwIGhhbmRsZXIgZm9yIHRoZSBQ
Q0kgRUNBTSBzcGFjZSBpcyByZWdpc3RlcmVkIGluIFhFTg0KPj4gc28gdGhhdCB3aGVuIGd1ZXN0
IGlzIHRyeWluZyB0byBhY2Nlc3MgdGhlIFBDSSBjb25maWcgc3BhY2UsWEVODQo+PiB3aWxsIHRy
YXAgdGhlIGFjY2VzcyBhbmQgZW11bGF0ZSByZWFkL3dyaXRlIHVzaW5nIHRoZSBWUENJIGFuZA0K
Pj4gbm90IHRoZSByZWFsIFBDSSBoYXJkd2FyZS4NCj4+IA0KPj4gRm9yIERvbTBsZXNzIHN5c3Rl
bXMgc2Nhbl9wY2lfZGV2aWNlcygpIHdvdWxkIGJlIHVzZWQgdG8gZGlzY292ZXIgdGhlDQo+PiBQ
Q0kgZGV2aWNlIGluIFhFTiBhbmQgVlBDSSBoYW5kbGVyIHdpbGwgYmUgYWRkZWQgZHVyaW5nIFhF
TiBib290cy4NCj4+IA0KPj4gVGhpcyBwYXRjaCBpcyBhbHNvIGRvaW5nIHNvbWUgc21hbGwgZml4
ZXMgdG8gZml4IGNvbXBpbGF0aW9uIGVycm9ycyBvbg0KPj4gYXJtMzIgb2YgdnBjaSBhbmQgcHJl
dmVudCA2NGJpdCBhY2Nlc3NlcyBvbiAzMmJpdDoNCj4+IC0gdXNlICV6dSBpbnN0ZWFkIG9mIGx1
IGluIGhlYWRlci5jIGZvciBwcmludA0KPj4gLSBwcmV2ZW50IDY0Yml0IGFjY2Vzc2VzIGluIHZw
Y2lfYWNjZXNzX2FsbG93ZWQNCj4+IC0gaWZkZWYgb3V0IHVzaW5nIENPTkZJR182NEJJVCBoYW5k
bGluZyBvZiBsZW4gOCBpbg0KPj4gdnBjaV9lY2FtX3tyZWFkL3dyaXRlfQ0KPj4gDQo+PiBTaWdu
ZWQtb2ZmLWJ5OiBSYWh1bCBTaW5naCA8cmFodWwuc2luZ2hAYXJtLmNvbT4NCj4+IFNpZ25lZC1v
ZmYtYnk6IEJlcnRyYW5kIE1hcnF1aXMgPGJlcnRyYW5kLm1hcnF1aXNAYXJtLmNvbT4NCj4gDQo+
IFRoZSB2cGNpIGJpdHMgbG9va3MgZmluZSB0byBtZSwgc286DQo+IA0KPiBBY2tlZC1ieTogUm9n
ZXIgUGF1IE1vbm7DqSA8cm9nZXIucGF1QGNpdHJpeC5jb20+DQoNClRoYW5rcw0KDQo+IA0KPiBJ
IGhhdmUgb25lIHF1ZXN0aW9uIGhvd2V2ZXIgcmVsYXRlZCB0byB0aGUgcGxhY2VtZW50IG9mIHRo
ZSB2cGNpIHNldHVwDQo+IGNhbGwgaW4gcGNpX2FkZF9kZXZpY2UuDQo+IA0KPj4gZGlmZiAtLWdp
dCBhL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL3BjaS5jIGIveGVuL2RyaXZlcnMvcGFzc3Rocm91
Z2gvcGNpLmMNCj4+IGluZGV4IDNhYThjMzE3NWYuLjA4Mjg5MmM4YTIgMTAwNjQ0DQo+PiAtLS0g
YS94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC9wY2kuYw0KPj4gKysrIGIveGVuL2RyaXZlcnMvcGFz
c3Rocm91Z2gvcGNpLmMNCj4+IEBAIC03NjYsNyArNzY2LDIxIEBAIGludCBwY2lfYWRkX2Rldmlj
ZSh1MTYgc2VnLCB1OCBidXMsIHU4IGRldmZuLA0KPj4gICAgICAgICBsaXN0X2FkZCgmcGRldi0+
ZG9tYWluX2xpc3QsICZoYXJkd2FyZV9kb21haW4tPnBkZXZfbGlzdCk7DQo+PiAgICAgfQ0KPj4g
ICAgIGVsc2UNCj4+ICsgICAgew0KPj4gKyNpZmRlZiBDT05GSUdfQVJNDQo+PiArICAgICAgICAv
Kg0KPj4gKyAgICAgICAgICogT24gQVJNIFBDSSBkZXZpY2VzIGRpc2NvdmVyeSB3aWxsIGJlIGRv
bmUgYnkgRG9tMC4gQWRkIHZwY2kgaGFuZGxlcg0KPj4gKyAgICAgICAgICogd2hlbiBEb20wIGlu
Zm9ybSBYRU4gdG8gYWRkIHRoZSBQQ0kgZGV2aWNlcyBpbiBYRU4uDQo+PiArICAgICAgICAgKi8N
Cj4+ICsgICAgICAgIHJldCA9IHZwY2lfYWRkX2hhbmRsZXJzKHBkZXYpOw0KPj4gKyAgICAgICAg
aWYgKCByZXQgKQ0KPj4gKyAgICAgICAgew0KPj4gKyAgICAgICAgICAgIHByaW50ayhYRU5MT0df
RVJSICJTZXR1cCBvZiB2UENJIGZhaWxlZDogJWRcbiIsIHJldCk7DQo+PiArICAgICAgICAgICAg
Z290byBvdXQ7DQo+PiArICAgICAgICB9DQo+IA0KPiBJJ20gbGlrZWx5IGxvc3QgaGVyZSwgYnV0
IHNob3VsZG4ndCB0aGlzIGFsc28gYmUgZG9uZSBmb3IgZGV2aWNlcyB0aGF0DQo+IGJlbG9uZyB0
byB0aGUgaGFyZHdhcmUgZG9tYWluIGFuZCBhcmUgYXNzaWduZWQgdG8gaXQgaW4gdGhlIGZpcnN0
DQo+IGJyYW5jaCBvZiB0aGlzIGNvbmRpdGlvbmFsPw0KPiANCj4gT3IgZWxzZSB5b3Ugd2lsbCBl
bmQgdXAgd2l0aCBkZXZpY2VzIGFzc2lnbmVkIHRvIHRoZSBoYXJkd2FyZSBkb21haW4NCj4gdGhh
dCBkb24ndCBoYXZlIHZQQ0kgc2V0dXAgZm9yIHRoZW0uDQoNCkkgbWlnaHQgYmUgd3JvbmcgYnV0
IHdoZW4gdGhlIGhhcmR3YXJlIGRvbWFpbiBpcyBkZWNsYXJpbmcgdGhlIGRldmljZXMgdGhleSBh
cmUgYWRkZWQgdG8gaGltLg0KVGhlbiBsYXRlciB3aGVuIHRob3NlIGRldmljZSBhcmUgYXNzaWdu
ZWQgdG8gYSBndWVzdCwgdGhleSBhcmUgcmVtb3ZlZCBmcm9tIHRoZSBoYXJkd2FyZSBkb21haW4u
DQoNClJlZ2FyZHMNCkJlcnRyYW5kDQoNCj4gDQo+IFRoYW5rcywgUm9nZXIuDQoNCg==


From xen-devel-bounces@lists.xenproject.org Fri Oct 15 15:07:38 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 15:07:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.210783.367773 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbOo6-0001z9-39; Fri, 15 Oct 2021 15:07:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 210783.367773; Fri, 15 Oct 2021 15:07:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbOo6-0001z2-02; Fri, 15 Oct 2021 15:07:38 +0000
Received: by outflank-mailman (input) for mailman id 210783;
 Fri, 15 Oct 2021 15:07:36 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=esao=PD=suse.com=jgross@srs-us1.protection.inumbo.net>)
 id 1mbOo4-0001ys-5C
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 15:07:36 +0000
Received: from smtp-out2.suse.de (unknown [195.135.220.29])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id a00de816-2dc9-11ec-823f-12813bfff9fa;
 Fri, 15 Oct 2021 15:07:34 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 96A641FD4F;
 Fri, 15 Oct 2021 15:07:33 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 6D3F813C25;
 Fri, 15 Oct 2021 15:07:33 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id HMR5GTWZaWFCXgAAMHmgww
 (envelope-from <jgross@suse.com>); Fri, 15 Oct 2021 15:07:33 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a00de816-2dc9-11ec-823f-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1634310453; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=xPiDGgZf1/Xhaexxhb5+lJmg3U7KAxj1ix3DM0yh+iw=;
	b=fW/wCoImFeZ2wFc+4D4LIqeuzh9yvBrgUordytBOXihjbO+PAf7wm7aavsSDVx4ckIdaXB
	0AcASL+8wRl/LwXJdSy2WTSd3Fr8wAVEKMCTEHoxjL/VB2Dvz8yHE2OFFGz9IJWVRQLnOV
	QC4b1PG/9AiGPV+WpsB+hDVjFdhmCpM=
To: Ian Jackson <iwj@xenproject.org>,
 Kevin Stefanov <kevin.stefanov@citrix.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>, Wei Liu <wl@xen.org>,
 Julien Grall <julien@xen.org>, Andrew Cooper <andrew.cooper3@citrix.com>
References: <20211015121409.24434-1-kevin.stefanov@citrix.com>
 <24937.32544.417730.402070@mariner.uk.xensource.com>
From: Juergen Gross <jgross@suse.com>
Subject: Re: [PATCH v2] tools/tests: Make E2BIG non-fatal to xenstore unit
 test
Message-ID: <227b70e9-23c1-1aaa-4e77-1c64ba8f24ae@suse.com>
Date: Fri, 15 Oct 2021 17:07:32 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <24937.32544.417730.402070@mariner.uk.xensource.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="Lm90hfZgeWCAMF3pmRhVafx8ot1HI2VNr"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--Lm90hfZgeWCAMF3pmRhVafx8ot1HI2VNr
Content-Type: multipart/mixed; boundary="uUOeEvfsRexUssKlieshmLQWNrRTbhGDe";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Ian Jackson <iwj@xenproject.org>,
 Kevin Stefanov <kevin.stefanov@citrix.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>, Wei Liu <wl@xen.org>,
 Julien Grall <julien@xen.org>, Andrew Cooper <andrew.cooper3@citrix.com>
Message-ID: <227b70e9-23c1-1aaa-4e77-1c64ba8f24ae@suse.com>
Subject: Re: [PATCH v2] tools/tests: Make E2BIG non-fatal to xenstore unit
 test
References: <20211015121409.24434-1-kevin.stefanov@citrix.com>
 <24937.32544.417730.402070@mariner.uk.xensource.com>
In-Reply-To: <24937.32544.417730.402070@mariner.uk.xensource.com>

--uUOeEvfsRexUssKlieshmLQWNrRTbhGDe
Content-Type: multipart/mixed;
 boundary="------------1A74959F423BE42A6DD2FA25"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------1A74959F423BE42A6DD2FA25
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 15.10.21 15:16, Ian Jackson wrote:
> Kevin Stefanov writes ("[PATCH v2] tools/tests: Make E2BIG non-fatal to=
 xenstore unit test"):
>> Xenstore's unit test fails on read and write of big numbers if
>> quota-maxsize is set to a lower number than those test cases use.
>>
>> Output a special warning instead of a failure message in such cases
>> and make the error non-fatal to the unit test.
>=20
> I realise that I am late to this, but I'm not sure I agree with the
> basic principle of this change.  In general tolerating particular
> errors in a test, and simply abandoning the test if they occcur, is
> normally not the best approach.
>=20
> Questions that come to my mind (and which aren't answered in the
> commit message and probably should be) include:
>=20
> Why does test-xenstore using these large numbers for its tests ?

For testing large data packets.

> Why would you run the tests with a quota too low for the tests ?

Good question.

> Might this test change not in principle miss genuine bugs ?

Yes, e.g. if a test returns E2BIG even if it shouldn't.

So I agree to being more cautious here.

Maybe a parameter could be added to limit the allowed data size?
Then the "large data" test could be adjusted to not send more data
than allowed (it should be noted that the node size quota is
including data, names of children, and access right entries, so
the pure node data should be selected with some spare size in
mind, e.g. 100 bytes smaller than the quota).


Juergen

--------------1A74959F423BE42A6DD2FA25
Content-Type: application/pgp-keys;
 name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Transfer-Encoding: quoted-printable
Content-Description: OpenPGP public key
Content-Disposition: attachment;
 filename="OpenPGP_0xB0DE9DD628BF132F.asc"

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy=
cWx
w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O=
f8Z
d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y=
9bf
IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq=
G7/
377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR=
3Jv
c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA=
QIe
AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT=
hpw
dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0=
MbD
1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv=
oPH
Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v=
5QL
+qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ=
2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC=
QoL
BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr=
Wf0
teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC=
/nu
AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh=
ITT
d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm=
XBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz=
80h
SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC=
AcD
AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn=
FOX
gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1=
jnD
kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0=
N51
N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l=
otu
fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1=
tqS
EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA=
hsD
BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3=
g3O
ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5=
dM7
wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5=
D+j
LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm=
V2x
AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N=
Eaw
QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW=
nHI
s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR=
wgn
BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV=
bVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk=
pEd
IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA=
QAB
wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw=
Tbe
8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1=
vJz
Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8=
VGi
wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW=
svi
uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX=
zXs
ZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------1A74959F423BE42A6DD2FA25--

--uUOeEvfsRexUssKlieshmLQWNrRTbhGDe--

--Lm90hfZgeWCAMF3pmRhVafx8ot1HI2VNr
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmFpmTQFAwAAAAAACgkQsN6d1ii/Ey/a
vQf/ekvSODBbnsIuY9lhJkK1osIKM2ROEGpbNcy/lmRr0nlHZcPHSdwCCLOG43tbfugouN78eYY4
pfWHXXXeQT/c8kJPRQMDXUZ81MEtwBrSj916tvxgkfWKhDDpmRQBYv+qqLBU1S4eOPBLRK5Nteqa
D9Wo3gfxHCSMgMn1cdC/YM3KWYh69ZgSd/VK6PUDcf0gmDNfmWWU9mPe3kmiIlA69B63Mlb53hPE
AC1ooaRN2Pjj59oOoTzk4v3JrFzbS7/u4NR1t5uetTip4jA4FEEAskNFtttRxBZKZMRfuxdXq8WQ
5Uc3e1m9/o991/Yt58yvS2rwcuG3NW6FmwLWmi/X6A==
=+U/Y
-----END PGP SIGNATURE-----

--Lm90hfZgeWCAMF3pmRhVafx8ot1HI2VNr--


From xen-devel-bounces@lists.xenproject.org Fri Oct 15 15:09:45 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 15:09:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.210792.367785 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbOq7-0002fR-HE; Fri, 15 Oct 2021 15:09:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 210792.367785; Fri, 15 Oct 2021 15:09:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbOq7-0002fK-Du; Fri, 15 Oct 2021 15:09:43 +0000
Received: by outflank-mailman (input) for mailman id 210792;
 Fri, 15 Oct 2021 15:09:42 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Fqmt=PD=arm.com=Bertrand.Marquis@srs-us1.protection.inumbo.net>)
 id 1mbOq6-0002fC-Fb
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 15:09:42 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com (unknown
 [40.107.7.72]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id ebba59f2-2dc9-11ec-823f-12813bfff9fa;
 Fri, 15 Oct 2021 15:09:41 +0000 (UTC)
Received: from AS8PR05CA0030.eurprd05.prod.outlook.com (2603:10a6:20b:311::35)
 by AM9PR08MB7069.eurprd08.prod.outlook.com (2603:10a6:20b:413::7)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15; Fri, 15 Oct
 2021 15:09:38 +0000
Received: from AM5EUR03FT037.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:311:cafe::94) by AS8PR05CA0030.outlook.office365.com
 (2603:10a6:20b:311::35) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15 via Frontend
 Transport; Fri, 15 Oct 2021 15:09:38 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM5EUR03FT037.mail.protection.outlook.com (10.152.17.241) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.15 via Frontend Transport; Fri, 15 Oct 2021 15:09:38 +0000
Received: ("Tessian outbound 8e26f7114b75:v103");
 Fri, 15 Oct 2021 15:09:37 +0000
Received: from fd4347012b09.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 9294A406-09E6-42B8-877C-8B40B9B3642A.1; 
 Fri, 15 Oct 2021 15:09:30 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id fd4347012b09.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 15 Oct 2021 15:09:30 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com (2603:10a6:4:74::9)
 by DB6PR0801MB1862.eurprd08.prod.outlook.com (2603:10a6:4:75::21) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.17; Fri, 15 Oct
 2021 15:09:29 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955]) by DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955%4]) with mapi id 15.20.4587.031; Fri, 15 Oct 2021
 15:09:29 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ebba59f2-2dc9-11ec-823f-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=zdyH08EyPeKsyhGyV3A5z4kmWA1EzWBVxfztqzwkKMk=;
 b=jzpPATaoo+9iYfHbRzMR1woyG4oGm0jk9ePFtUXK7x+Q09kCSXJ4DEgSLJ/vLawwYJ6jQQpZJYzz+RD5VvDHLT1b+8wlAVg1aZqG0/z39mPGUvCWxj/cAffSxIZk6lgGqUHF4/MSBmloHw4/QHshX5rrpJZzuC5Ymo6abZGu1KU=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 0d1544f306c7802c
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=MCC5LKgmpAJyQ+Jyc55r04nPcTQ5yn2wMTxnzXINNitDZbzDIWBXRDI6i65TvXtb84X+WG7yrFMbxrps9Z3m9DvjUyXpTZjlNdSKOra+nvty5Wzp3hzJgRrESIU//i6oYhJrY7pHXNLjByYfFRzMk3yfb7CEMWlqEkykws25pUg/3mqcamPD4Y5OPAeT6TLXZazcGL1B9VKk1d4W0B9HqWHp8Iz/wuYPcF8BcCHR4O8+s/udueE8TLeSEaIOqHn9K+4SLP0g2tVsDeU/5hnVmFQkV4bl3AZ/f9xSLTDfdX7S7O8VTZadhH7zqA5xd9iecr2oFwQYMUBX1lKOkW9L5A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=zdyH08EyPeKsyhGyV3A5z4kmWA1EzWBVxfztqzwkKMk=;
 b=cmrVQqjLAFS+6rNEUCFJPLwigbk9+wVPp1QtRwCoukrgod2pUFI1eY/46Rs0ukazFmJVJeWOkQ2/t9rOgxGHFlYSboDnNI7maPUq3FpwK15UaIWBHObvsx2bhJQaQ5ykQ6ag/xFmrLxtxV+FNQqa3pCIBohYajBF3P24aWrAYcKeFew9LCtdbllSLSnhWcjW3KJas+N/0WgBG2S9FfULZd3TV1yvsMvWpm3cWPPOleYlo2CjFq2e9S92055y1MBLutRGB47nRVWPHL6vLfk1TnWuBg7iv/ttW+EQR/dGfQMrQZpht+BTjOC8Gxewf5sTm9UFAWLfczZ7t8qwpyHSUQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=zdyH08EyPeKsyhGyV3A5z4kmWA1EzWBVxfztqzwkKMk=;
 b=jzpPATaoo+9iYfHbRzMR1woyG4oGm0jk9ePFtUXK7x+Q09kCSXJ4DEgSLJ/vLawwYJ6jQQpZJYzz+RD5VvDHLT1b+8wlAVg1aZqG0/z39mPGUvCWxj/cAffSxIZk6lgGqUHF4/MSBmloHw4/QHshX5rrpJZzuC5Ymo6abZGu1KU=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>, "iwj@xenproject.org"
	<iwj@xenproject.org>, Paul Durrant <paul@xen.org>, Jan Beulich
	<jbeulich@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu
	<wl@xen.org>
Subject: Re: [PATCH v7 1/5] xen/vpci: Move ecam access functions to common
 code
Thread-Topic: [PATCH v7 1/5] xen/vpci: Move ecam access functions to common
 code
Thread-Index: AQHXwczyJFPyn+DMbUSbLe6mtGg4MavUGyuAgAAOhgA=
Date: Fri, 15 Oct 2021 15:09:29 +0000
Message-ID: <9580344D-B66D-45EE-9086-61077E3EC18C@arm.com>
References: <cover.1634305870.git.bertrand.marquis@arm.com>
 <bac1cc0d06dffc8f00233ea31233080bae8868aa.1634305870.git.bertrand.marquis@arm.com>
 <YWmNeWSdmcbKNdSh@MacBook-Air-de-Roger.local>
In-Reply-To: <YWmNeWSdmcbKNdSh@MacBook-Air-de-Roger.local>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3654.120.0.1.13)
Authentication-Results-Original: citrix.com; dkim=none (message not signed)
 header.d=none;citrix.com; dmarc=none action=none header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: ffe2c8a5-4652-404a-5ed2-08d98fedce71
x-ms-traffictypediagnostic: DB6PR0801MB1862:|AM9PR08MB7069:
X-Microsoft-Antispam-PRVS:
	<AM9PR08MB70692A97B4544D3E127871EF9DB99@AM9PR08MB7069.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:9508;OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 fvMQD2F634e+RbsWPtIqcLZjgRngPhYMhueMyZCzvGDp6Zmqnvi8aGMtdGLxf7Zt+ChQu4eSl2cIs8UhlOqDRo9Ywa+J464/35UrFFEZ1FbZCuZpgFE3cCS34UTjO4jGdPmcd6zwYbz47zxGFaXqKmXmf805t8eAhi/wrgMvou0UKPwmQrVt0PdGMwxi0/toKHs2YKMmEqiEt5MD564MdU9YEcLttSbWDVcY3FQaJ/Y6Evt6sQpLLGzNybE3gUY8AouBt0GLq5dJFarzlu8U2n8Y0amHqMi2nbPNKyQ5BrUsXanHCyLQxkM6Jaj3SGSoGnu6kWVRZn2PVAD2lVqzJeRqUiGRj6RVNswCe6bNhXD6uBy0c1Ph4uHeATWdN1MSEylZnFMjNcE3p2g+3AA+4897lA0TihU9tZBrf2akYoFxyI0h/7NaYUJx4EzWYWLT7lldYPWqPr/LZBH10hFYFBSOkngYK3R9NQCT2v1JS3FCQCqbrr3m7maHuUMPA3kG7X01jaLXAvl/c4JmHW3crSMbHcoq8r5vKlkg1M/kMHNi6sHD/Y9+zZsyx6r4nV3T6amT+mOKpx53cOV0q6Mt+Zgp1DEQMAczfCEr3TSQVqgTCjAHXxRcPrhFmPdAc8bMfrGQJf+1M68LyjzoV6Ltz/ENK40AweNaqI7Ahi/k4aH0PukjPOU+UMDB6Q4mZvlo+2OLvxLYrBNm0OyMpExfV5RHFFlDDmtirgVhBQtdaFZFblxFOjbZ7XV0Mt5VjIUdHVEMmU3UKZ/J/XeKHnrFm7VOHkSLPLtw+SWJ1mFe+oAokej8+k5f6KQFWewZxMwv
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB6PR0801MB2024.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(6486002)(8936002)(33656002)(53546011)(8676002)(38070700005)(4326008)(6512007)(54906003)(38100700002)(6506007)(36756003)(122000001)(83380400001)(64756008)(186003)(66476007)(66556008)(966005)(71200400001)(76116006)(66946007)(2906002)(66446008)(26005)(6916009)(5660300002)(86362001)(508600001)(2616005)(316002)(91956017)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="utf-8"
Content-ID: <3B5F486F082DF241B1BB196DD1565AE6@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0801MB1862
Original-Authentication-Results: citrix.com; dkim=none (message not signed)
 header.d=none;citrix.com; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM5EUR03FT037.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	9b38b9dc-6231-4ffb-e472-08d98fedc906
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	QQ4WSScvz4V7kDRgTerKVULyksi3H3+XJ7BV3lCNizhtzLrC4usk8EUTMnjuuyuUsmQnTrhjTQLOI0yriWj6qDyBUKLLSqfLx0+LchndqdvpaIeba6P7bfQNVyFvYfJ4mwIFlUXTWJwmdzY4rf5etcdY7PpsGqyKgrmjUaWbKVI9s4XCD/L10lXVkhZTjls9irnehQrxdOrcwDXxAn3ZxS5l5vsvt1cQt/OIMp1rv0iY5XNF3TM6/nbOlOGimuv0ZLMJjL1JKdk6nXx0K9yAm6dWwSNnPu2HITyXbrwdJZk+QyI+lb9EdExYR0Ya5xUtEEVQUSHb2WC6bVCtQPqzO/ynxvIda/aKBCeA6/skzjqSSDsM1Lqv2stH//1NO9uUlRt8Y+XgDMsHKC51D8ISmP0U795mkmX6rh70zqKOEKukSTfnUAqeBNcVS8afsebPkjt78aGZi864fqX2BqEww6biZ26wRoCV/oYdFVrvsr116BR5cMePt+D5qHQNeNwSN2F9HajlPBtVIa79Rsk8LhU326CBj4JlGIIEiQhe9NKYPtVW7UB9YqYPt/zfCxVfste0ojF6tJzBr+JAUcKk5xJygXP/oEi3TOkarNcc8VvfoKkaeRntI8dOCQ2euBEkXjoYenhru7qjjXxeFdDkQuPVz3Fun7dxlCc87bgVKHw9a6KbR/G4gAh3YqXxdChhWHPECxTL0U4y/C1R62MPz6pbRKmkTGdOr4ag7FxQDb3J3gPm7F+QRqs/qHZ+in77Ppb64WNi4H4XbvMBmdM3h6LQdRMaNxXKGF0WDQ3QqcM=
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(82310400003)(54906003)(36756003)(36860700001)(8676002)(47076005)(2906002)(83380400001)(2616005)(26005)(6512007)(6506007)(356005)(508600001)(4326008)(966005)(81166007)(33656002)(186003)(336012)(70206006)(86362001)(6486002)(5660300002)(316002)(6862004)(8936002)(53546011)(70586007);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2021 15:09:38.2313
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: ffe2c8a5-4652-404a-5ed2-08d98fedce71
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM5EUR03FT037.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB7069

SGksDQoNCj4gT24gMTUgT2N0IDIwMjEsIGF0IDE1OjE3LCBSb2dlciBQYXUgTW9ubsOpIDxyb2dl
ci5wYXVAY2l0cml4LmNvbT4gd3JvdGU6DQo+IA0KPiBPbiBGcmksIE9jdCAxNSwgMjAyMSBhdCAw
Mjo1OToxOFBNICswMTAwLCBCZXJ0cmFuZCBNYXJxdWlzIHdyb3RlOg0KPj4gUENJIHN0YW5kYXJk
IGlzIHVzaW5nIEVDQU0gYW5kIG5vdCBNQ0ZHIHdoaWNoIGlzIGNvbWluZyBmcm9tIEFDUElbMV0u
DQo+PiBVc2UgRUNBTS9lY2FtIGluc3RlYWQgb2YgTUNGRyBpbiBjb21tb24gY29kZSBhbmQgaW4g
bmV3IGZ1bmN0aW9ucyBhZGRlZA0KPj4gaW4gY29tbW9uIHZwY2kgY29kZSBieSB0aGlzIHBhdGNo
Lg0KPj4gDQo+PiBNb3ZlIHZwY2lfYWNjZXNzX2FsbG93ZWQgZnJvbSBhcmNoL3g4Ni9odm0vaW8u
YyB0byBkcml2ZXJzL3ZwY2kvdnBjaS5jLg0KPj4gDQo+PiBDcmVhdGUgdnBjaV9lY2FtX3tyZWFk
LHdyaXRlfSBpbiBkcml2ZXJzL3ZwY2kvdnBjaS5jIHRoYXQNCj4+IGNvbnRhaW5zIHRoZSBjb21t
b24gY29kZSB0byBwZXJmb3JtIHRoZXNlIG9wZXJhdGlvbnMsIGNoYW5nZWQNCj4+IHZwY2lfbW1j
Zmdfe3JlYWQsd3JpdGV9IGFjY29yZGluZ2x5IHRvIG1ha2UgdXNlIG9mIHRoZXNlIGZ1bmN0aW9u
cy4NCj4+IA0KPj4gVGhlIHZwY2lfZWNhbV97cmVhZCx3cml0ZX0gZnVuY3Rpb25zIGFyZSByZXR1
cm5pbmcgZmFsc2Ugb24gZXJyb3IgYW5kDQo+PiB0cnVlIG9uIHN1Y2Nlc3MuIEFzIHRoZSB4ODYg
Y29kZSB3YXMgcHJldmlvdXNseSBhbHdheXMgcmV0dXJuaW5nDQo+PiBYODZFTVVMX09LQVkgdGhl
IHJldHVybiBjb2RlIGlzIGlnbm9yZWQuIEEgY29tbWVudCBoYXMgYmVlbiBhZGRlZCBpbg0KPj4g
dGhlIGNvZGUgdG8gc2hvdyB0aGF0IHRoaXMgaXMgaW50ZW50aW9uYWwuDQo+IA0KPiBJIHN0aWxs
IHdvbmRlciBob3cgeW91IHBsYW4gdG8gcHJvcGFnYXRlIHRob3NlIGVycm9ycyBiYWNrIHRvIHRo
ZQ0KPiBndWVzdCBpbiBhIHByb3BlciB3YXksIHNvIEknbSBkdWJpb3VzIHdoZXRoZXIgcmV0dXJu
aW5nIGEgYm9vbGVhbiBpcw0KPiByZWFsbHkgd2FycmFudGVkIGhlcmUsIGFzIEkgZG9uJ3QgdGhp
bmsgcmFpc2luZyBhIENQVSBmYXVsdC9hYm9ydCBvcg0KPiBzaW1pbGFyIG9uIHZwY2kgZXJyb3Jz
IGluIGNvcnJlY3QuIFdlIHdpbGwgc2VlIEkgZ3Vlc3MsIGFuZCB0aGUNCj4gY3VycmVudCBiZWhh
dmlvciBmb3IgeDg2IGlzIG5vdCBjaGFuZ2VkIGFueXdheS4NCj4gDQo+PiANCj4+IFRob3NlIGZ1
bmN0aW9ucyB3aWxsIGJlIHVzZWQgaW4gYSBmb2xsb3dpbmcgcGF0Y2ggaW5zaWRlIGJ5IGFybSB2
cGNpDQo+PiBpbXBsZW1lbnRhdGlvbi4NCj4+IA0KPj4gUmVuYW1lIE1NQ0ZHX0JERiB0byBWUENJ
X0VDQU1fQkRGIGFuZCBtb3ZlIGl0IHRvIHZwY2kuaC4NCj4+IFRoaXMgbWFjcm8gaXMgb25seSB1
c2VkIGJ5IGZ1bmN0aW9ucyBjYWxsaW5nIHZwY2lfZWNhbSBoZWxwZXJzLg0KPj4gDQo+PiBObyBm
dW5jdGlvbmFsIGNoYW5nZSBpbnRlbmRlZCB3aXRoIHRoaXMgcGF0Y2guDQo+PiANCj4+IFsxXSBo
dHRwczovL3dpa2kub3NkZXYub3JnL1BDSV9FeHByZXNzDQo+PiANCj4+IFN1Z2dlc3RlZC1ieTog
Um9nZXIgUGF1IE1vbm7DqSA8cm9nZXIucGF1QGNpdHJpeC5jb20+DQo+PiBTaWduZWQtb2ZmLWJ5
OiBCZXJ0cmFuZCBNYXJxdWlzIDxiZXJ0cmFuZC5tYXJxdWlzQGFybS5jb20+DQo+IA0KPiBBY2tl
ZC1ieTogUm9nZXIgUGF1IE1vbm7DqSA8cm9nZXIucGF1QGNpdHJpeC5jb20+DQoNClRoYW5rcw0K
DQo+IA0KPj4gLS0tDQo+PiBDaGFuZ2VzIGluIHY3Og0KPj4gLSBSZW5hbWUgdnBjaV9lY2FtX2Fj
Y2Vzc19hbGxvd2VkIHRvIHZwY2lfYWNjZXNzX2FsbG93ZWQNCj4+IC0gUmVuYW1lIHZwY2lfZWNh
bV9tbWlvX3tyZWFkL3dyaXRlfSB0byB2cGNpX2VjYW1fe3JlYWQvd3JpdGV9DQo+PiAtIFJlcGxh
Y2UgY29tbWVudCBpbiB4ODYvaHZtL2lvLmMgd2l0aCBvbmUgc3VnZ2VzdGVkIGJ5IFJvZ2VyDQo+
PiAtIFJlbW92ZSAzMmJpdCBjb21tZW50cyBhbmQgZml4ZXMgZnJvbSB0aGlzIHBhdGNoIGFuZCBt
b3ZlIGl0IHRvIHRoZSBuZXh0DQo+PiBvbmUgdG8ga2VlcCBvbmx5IHRoZSBtb3ZpbmcrcmVuYW1p
bmcgaW4gdGhpcyBwYXRjaA0KPj4gLSBDaGFuZ2UgcmV0dXJuIHR5cGUgb2YgdnBjaV9lY2FtX3ty
ZWFkL3dyaXRlfSB0byBib29sDQo+PiAtIHJlbmFtZSBFQ0FNX0JERiB0byBWUENJX0VDQU1fQkRG
IGFuZCBtb3ZlIGl0IHRvIHZwY2kuaA0KPj4gQ2hhbmdlcyBpbiB2NjogUGF0Y2ggYWRkZWQNCj4+
IC0tLQ0KPj4geGVuL2FyY2gveDg2L2h2bS9pby5jICAgICB8IDQ2ICsrKystLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLQ0KPj4geGVuL2RyaXZlcnMvdnBjaS92cGNpLmMgICB8IDU0ICsrKysr
KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKw0KPj4geGVuL2luY2x1ZGUvYXNtLXg4
Ni9wY2kuaCB8ICAyIC0tDQo+PiB4ZW4vaW5jbHVkZS94ZW4vdnBjaS5oICAgIHwgMTIgKysrKysr
KysrDQo+PiA0IGZpbGVzIGNoYW5nZWQsIDcxIGluc2VydGlvbnMoKyksIDQzIGRlbGV0aW9ucygt
KQ0KPj4gDQo+PiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gveDg2L2h2bS9pby5jIGIveGVuL2FyY2gv
eDg2L2h2bS9pby5jDQo+PiBpbmRleCAwNDZhOGViNGVkLi5lYjNjODA3NDNlIDEwMDY0NA0KPj4g
LS0tIGEveGVuL2FyY2gveDg2L2h2bS9pby5jDQo+PiArKysgYi94ZW4vYXJjaC94ODYvaHZtL2lv
LmMNCj4+IEBAIC0yNjAsMjAgKzI2MCw2IEBAIHVuc2lnbmVkIGludCBodm1fcGNpX2RlY29kZV9h
ZGRyKHVuc2lnbmVkIGludCBjZjgsIHVuc2lnbmVkIGludCBhZGRyLA0KPj4gICAgIHJldHVybiBD
RjhfQUREUl9MTyhjZjgpIHwgKGFkZHIgJiAzKTsNCj4+IH0NCj4+IA0KPj4gLS8qIERvIHNvbWUg
c2FuaXR5IGNoZWNrcy4gKi8NCj4+IC1zdGF0aWMgYm9vbCB2cGNpX2FjY2Vzc19hbGxvd2VkKHVu
c2lnbmVkIGludCByZWcsIHVuc2lnbmVkIGludCBsZW4pDQo+PiAtew0KPj4gLSAgICAvKiBDaGVj
ayBhY2Nlc3Mgc2l6ZS4gKi8NCj4+IC0gICAgaWYgKCBsZW4gIT0gMSAmJiBsZW4gIT0gMiAmJiBs
ZW4gIT0gNCAmJiBsZW4gIT0gOCApDQo+PiAtICAgICAgICByZXR1cm4gZmFsc2U7DQo+PiAtDQo+
PiAtICAgIC8qIENoZWNrIHRoYXQgYWNjZXNzIGlzIHNpemUgYWxpZ25lZC4gKi8NCj4+IC0gICAg
aWYgKCAocmVnICYgKGxlbiAtIDEpKSApDQo+PiAtICAgICAgICByZXR1cm4gZmFsc2U7DQo+PiAt
DQo+PiAtICAgIHJldHVybiB0cnVlOw0KPj4gLX0NCj4+IC0NCj4+IC8qIHZQQ0kgY29uZmlnIHNw
YWNlIElPIHBvcnRzIGhhbmRsZXJzICgweGNmOC8weGNmYykuICovDQo+PiBzdGF0aWMgYm9vbCB2
cGNpX3BvcnRpb19hY2NlcHQoY29uc3Qgc3RydWN0IGh2bV9pb19oYW5kbGVyICpoYW5kbGVyLA0K
Pj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNvbnN0IGlvcmVxX3QgKnApDQo+PiBA
QCAtMzk0LDcgKzM4MCw3IEBAIHN0YXRpYyB1bnNpZ25lZCBpbnQgdnBjaV9tbWNmZ19kZWNvZGVf
YWRkcihjb25zdCBzdHJ1Y3QgaHZtX21tY2ZnICptbWNmZywNCj4+ICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICBwYWRkcl90IGFkZHIsIHBjaV9zYmRmX3QgKnNiZGYp
DQo+PiB7DQo+PiAgICAgYWRkciAtPSBtbWNmZy0+YWRkcjsNCj4+IC0gICAgc2JkZi0+YmRmID0g
TU1DRkdfQkRGKGFkZHIpOw0KPj4gKyAgICBzYmRmLT5iZGYgPSBWQ1BJX0VDQU1fQkRGKGFkZHIp
Ow0KPj4gICAgIHNiZGYtPmJ1cyArPSBtbWNmZy0+c3RhcnRfYnVzOw0KPj4gICAgIHNiZGYtPnNl
ZyA9IG1tY2ZnLT5zZWdtZW50Ow0KPj4gDQo+PiBAQCAtNDM0LDI1ICs0MjAsOCBAQCBzdGF0aWMg
aW50IHZwY2lfbW1jZmdfcmVhZChzdHJ1Y3QgdmNwdSAqdiwgdW5zaWduZWQgbG9uZyBhZGRyLA0K
Pj4gICAgIHJlZyA9IHZwY2lfbW1jZmdfZGVjb2RlX2FkZHIobW1jZmcsIGFkZHIsICZzYmRmKTsN
Cj4+ICAgICByZWFkX3VubG9jaygmZC0+YXJjaC5odm0ubW1jZmdfbG9jayk7DQo+PiANCj4+IC0g
ICAgaWYgKCAhdnBjaV9hY2Nlc3NfYWxsb3dlZChyZWcsIGxlbikgfHwNCj4+IC0gICAgICAgICAo
cmVnICsgbGVuKSA+IFBDSV9DRkdfU1BBQ0VfRVhQX1NJWkUgKQ0KPj4gLSAgICAgICAgcmV0dXJu
IFg4NkVNVUxfT0tBWTsNCj4+IC0NCj4+IC0gICAgLyoNCj4+IC0gICAgICogQWNjb3JkaW5nIHRv
IHRoZSBQQ0llIDMuMUEgc3BlY2lmaWNhdGlvbjoNCj4+IC0gICAgICogIC0gQ29uZmlndXJhdGlv
biBSZWFkcyBhbmQgV3JpdGVzIG11c3QgdXN1YWxseSBiZSBEV09SRCBvciBzbWFsbGVyDQo+PiAt
ICAgICAqICAgIGluIHNpemUuDQo+PiAtICAgICAqICAtIEJlY2F1c2UgUm9vdCBDb21wbGV4IGlt
cGxlbWVudGF0aW9ucyBhcmUgbm90IHJlcXVpcmVkIHRvIHN1cHBvcnQNCj4+IC0gICAgICogICAg
YWNjZXNzZXMgdG8gYSBSQ1JCIHRoYXQgY3Jvc3MgRFcgYm91bmRhcmllcyBbLi4uXSBzb2Z0d2Fy
ZQ0KPj4gLSAgICAgKiAgICBzaG91bGQgdGFrZSBjYXJlIG5vdCB0byBjYXVzZSB0aGUgZ2VuZXJh
dGlvbiBvZiBzdWNoIGFjY2Vzc2VzDQo+PiAtICAgICAqICAgIHdoZW4gYWNjZXNzaW5nIGEgUkNS
QiB1bmxlc3MgdGhlIFJvb3QgQ29tcGxleCB3aWxsIHN1cHBvcnQgdGhlDQo+PiAtICAgICAqICAg
IGFjY2Vzcy4NCj4+IC0gICAgICogIFhlbiBob3dldmVyIHN1cHBvcnRzIDhieXRlIGFjY2Vzc2Vz
IGJ5IHNwbGl0dGluZyB0aGVtIGludG8gdHdvDQo+PiAtICAgICAqICA0Ynl0ZSBhY2Nlc3Nlcy4N
Cj4+IC0gICAgICovDQo+PiAtICAgICpkYXRhID0gdnBjaV9yZWFkKHNiZGYsIHJlZywgbWluKDR1
LCBsZW4pKTsNCj4+IC0gICAgaWYgKCBsZW4gPT0gOCApDQo+PiAtICAgICAgICAqZGF0YSB8PSAo
dWludDY0X3QpdnBjaV9yZWFkKHNiZGYsIHJlZyArIDQsIDQpIDw8IDMyOw0KPj4gKyAgICAvKiBG
YWlsZWQgcmVhZHMgYXJlIG5vdCBwcm9wYWdhdGVkIHRvIHRoZSBjYWxsZXIgKi8NCj4+ICsgICAg
dnBjaV9lY2FtX3JlYWQoc2JkZiwgcmVnLCBsZW4sIGRhdGEpOw0KPj4gDQo+PiAgICAgcmV0dXJu
IFg4NkVNVUxfT0tBWTsNCj4+IH0NCj4+IEBAIC00NzYsMTMgKzQ0NSw4IEBAIHN0YXRpYyBpbnQg
dnBjaV9tbWNmZ193cml0ZShzdHJ1Y3QgdmNwdSAqdiwgdW5zaWduZWQgbG9uZyBhZGRyLA0KPj4g
ICAgIHJlZyA9IHZwY2lfbW1jZmdfZGVjb2RlX2FkZHIobW1jZmcsIGFkZHIsICZzYmRmKTsNCj4+
ICAgICByZWFkX3VubG9jaygmZC0+YXJjaC5odm0ubW1jZmdfbG9jayk7DQo+PiANCj4+IC0gICAg
aWYgKCAhdnBjaV9hY2Nlc3NfYWxsb3dlZChyZWcsIGxlbikgfHwNCj4+IC0gICAgICAgICAocmVn
ICsgbGVuKSA+IFBDSV9DRkdfU1BBQ0VfRVhQX1NJWkUgKQ0KPj4gLSAgICAgICAgcmV0dXJuIFg4
NkVNVUxfT0tBWTsNCj4+IC0NCj4+IC0gICAgdnBjaV93cml0ZShzYmRmLCByZWcsIG1pbig0dSwg
bGVuKSwgZGF0YSk7DQo+PiAtICAgIGlmICggbGVuID09IDggKQ0KPj4gLSAgICAgICAgdnBjaV93
cml0ZShzYmRmLCByZWcgKyA0LCA0LCBkYXRhID4+IDMyKTsNCj4+ICsgICAgLyogRmFpbGVkIHdy
aXRlcyBhcmUgbm90IHByb3BhZ2F0ZWQgdG8gdGhlIGNhbGxlciAqLw0KPj4gKyAgICB2cGNpX2Vj
YW1fd3JpdGUoc2JkZiwgcmVnLCBsZW4sIGRhdGEpOw0KPj4gDQo+PiAgICAgcmV0dXJuIFg4NkVN
VUxfT0tBWTsNCj4+IH0NCj4+IGRpZmYgLS1naXQgYS94ZW4vZHJpdmVycy92cGNpL3ZwY2kuYyBi
L3hlbi9kcml2ZXJzL3ZwY2kvdnBjaS5jDQo+PiBpbmRleCBjYmQxYmFjN2ZjLi5lZjY5MGYxNWE5
IDEwMDY0NA0KPj4gLS0tIGEveGVuL2RyaXZlcnMvdnBjaS92cGNpLmMNCj4+ICsrKyBiL3hlbi9k
cml2ZXJzL3ZwY2kvdnBjaS5jDQo+PiBAQCAtNDc4LDYgKzQ3OCw2MCBAQCB2b2lkIHZwY2lfd3Jp
dGUocGNpX3NiZGZfdCBzYmRmLCB1bnNpZ25lZCBpbnQgcmVnLCB1bnNpZ25lZCBpbnQgc2l6ZSwN
Cj4+ICAgICBzcGluX3VubG9jaygmcGRldi0+dnBjaS0+bG9jayk7DQo+PiB9DQo+PiANCj4+ICsv
KiBIZWxwZXIgZnVuY3Rpb24gdG8gY2hlY2sgYW4gYWNjZXNzIHNpemUgYW5kIGFsaWdubWVudCBv
biB2cGNpIHNwYWNlLiAqLw0KPj4gK2Jvb2wgdnBjaV9hY2Nlc3NfYWxsb3dlZCh1bnNpZ25lZCBp
bnQgcmVnLCB1bnNpZ25lZCBpbnQgbGVuKQ0KPj4gK3sNCj4+ICsgICAgLyogQ2hlY2sgYWNjZXNz
IHNpemUuICovDQo+PiArICAgIGlmICggbGVuICE9IDEgJiYgbGVuICE9IDIgJiYgbGVuICE9IDQg
JiYgbGVuICE9IDggKQ0KPj4gKyAgICAgICAgcmV0dXJuIGZhbHNlOw0KPj4gKw0KPj4gKyAgICAv
KiBDaGVjayB0aGF0IGFjY2VzcyBpcyBzaXplIGFsaWduZWQuICovDQo+PiArICAgIGlmICggKHJl
ZyAmIChsZW4gLSAxKSkgKQ0KPj4gKyAgICAgICAgcmV0dXJuIGZhbHNlOw0KPj4gKw0KPj4gKyAg
ICByZXR1cm4gdHJ1ZTsNCj4+ICt9DQo+PiArDQo+PiArYm9vbCB2cGNpX2VjYW1fd3JpdGUocGNp
X3NiZGZfdCBzYmRmLCB1bnNpZ25lZCBpbnQgcmVnLCB1bnNpZ25lZCBpbnQgbGVuLA0KPj4gKyAg
ICAgICAgICAgICAgICAgICAgICAgICB1bnNpZ25lZCBsb25nIGRhdGEpDQo+PiArew0KPj4gKyAg
ICBpZiAoICF2cGNpX2FjY2Vzc19hbGxvd2VkKHJlZywgbGVuKSB8fA0KPj4gKyAgICAgICAgIChy
ZWcgKyBsZW4pID4gUENJX0NGR19TUEFDRV9FWFBfU0laRSApDQo+PiArICAgICAgICByZXR1cm4g
ZmFsc2U7DQo+PiArDQo+PiArICAgIHZwY2lfd3JpdGUoc2JkZiwgcmVnLCBtaW4oNHUsIGxlbiks
IGRhdGEpOw0KPj4gKyAgICBpZiAoIGxlbiA9PSA4ICkNCj4+ICsgICAgICAgIHZwY2lfd3JpdGUo
c2JkZiwgcmVnICsgNCwgNCwgZGF0YSA+PiAzMik7DQo+PiArDQo+PiArICAgIHJldHVybiB0cnVl
Ow0KPj4gK30NCj4+ICsNCj4+ICtib29sIHZwY2lfZWNhbV9yZWFkKHBjaV9zYmRmX3Qgc2JkZiwg
dW5zaWduZWQgaW50IHJlZywgdW5zaWduZWQgaW50IGxlbiwNCj4+ICsgICAgICAgICAgICAgICAg
ICAgICAgICB1bnNpZ25lZCBsb25nICpkYXRhKQ0KPj4gK3sNCj4+ICsgICAgaWYgKCAhdnBjaV9h
Y2Nlc3NfYWxsb3dlZChyZWcsIGxlbikgfHwNCj4+ICsgICAgICAgICAocmVnICsgbGVuKSA+IFBD
SV9DRkdfU1BBQ0VfRVhQX1NJWkUgKQ0KPj4gKyAgICAgICAgcmV0dXJuIGZhbHNlOw0KPj4gKw0K
Pj4gKyAgICAvKg0KPj4gKyAgICAgKiBBY2NvcmRpbmcgdG8gdGhlIFBDSWUgMy4xQSBzcGVjaWZp
Y2F0aW9uOg0KPj4gKyAgICAgKiAgLSBDb25maWd1cmF0aW9uIFJlYWRzIGFuZCBXcml0ZXMgbXVz
dCB1c3VhbGx5IGJlIERXT1JEIG9yIHNtYWxsZXINCj4+ICsgICAgICogICAgaW4gc2l6ZS4NCj4+
ICsgICAgICogIC0gQmVjYXVzZSBSb290IENvbXBsZXggaW1wbGVtZW50YXRpb25zIGFyZSBub3Qg
cmVxdWlyZWQgdG8gc3VwcG9ydA0KPj4gKyAgICAgKiAgICBhY2Nlc3NlcyB0byBhIFJDUkIgdGhh
dCBjcm9zcyBEVyBib3VuZGFyaWVzIFsuLi5dIHNvZnR3YXJlDQo+PiArICAgICAqICAgIHNob3Vs
ZCB0YWtlIGNhcmUgbm90IHRvIGNhdXNlIHRoZSBnZW5lcmF0aW9uIG9mIHN1Y2ggYWNjZXNzZXMN
Cj4+ICsgICAgICogICAgd2hlbiBhY2Nlc3NpbmcgYSBSQ1JCIHVubGVzcyB0aGUgUm9vdCBDb21w
bGV4IHdpbGwgc3VwcG9ydCB0aGUNCj4+ICsgICAgICogICAgYWNjZXNzLg0KPj4gKyAgICAgKiAg
WGVuIGhvd2V2ZXIgc3VwcG9ydHMgOGJ5dGUgYWNjZXNzZXMgYnkgc3BsaXR0aW5nIHRoZW0gaW50
byB0d28NCj4+ICsgICAgICogIDRieXRlIGFjY2Vzc2VzLg0KPj4gKyAgICAgKi8NCj4+ICsgICAg
KmRhdGEgPSB2cGNpX3JlYWQoc2JkZiwgcmVnLCBtaW4oNHUsIGxlbikpOw0KPj4gKyAgICBpZiAo
IGxlbiA9PSA4ICkNCj4+ICsgICAgICAgICpkYXRhIHw9ICh1aW50NjRfdCl2cGNpX3JlYWQoc2Jk
ZiwgcmVnICsgNCwgNCkgPDwgMzI7DQo+PiArDQo+PiArICAgIHJldHVybiB0cnVlOw0KPj4gK30N
Cj4+ICsNCj4+IC8qDQo+PiAgKiBMb2NhbCB2YXJpYWJsZXM6DQo+PiAgKiBtb2RlOiBDDQo+PiBk
aWZmIC0tZ2l0IGEveGVuL2luY2x1ZGUvYXNtLXg4Ni9wY2kuaCBiL3hlbi9pbmNsdWRlL2FzbS14
ODYvcGNpLmgNCj4+IGluZGV4IGVkZDdjM2U3MWEuLjQ0M2YyNTM0N2QgMTAwNjQ0DQo+PiAtLS0g
YS94ZW4vaW5jbHVkZS9hc20teDg2L3BjaS5oDQo+PiArKysgYi94ZW4vaW5jbHVkZS9hc20teDg2
L3BjaS5oDQo+PiBAQCAtNiw4ICs2LDYgQEANCj4+ICNkZWZpbmUgQ0Y4X0FERFJfSEkoY2Y4KSAo
ICAoKGNmOCkgJiAweDBmMDAwMDAwKSA+PiAxNikNCj4+ICNkZWZpbmUgQ0Y4X0VOQUJMRUQoY2Y4
KSAoISEoKGNmOCkgJiAweDgwMDAwMDAwKSkNCj4+IA0KPj4gLSNkZWZpbmUgTU1DRkdfQkRGKGFk
ZHIpICAoICgoYWRkcikgJiAweDBmZmZmMDAwKSA+PiAxMikNCj4+IC0NCj4+ICNkZWZpbmUgSVNf
U05CX0dGWChpZCkgKGlkID09IDB4MDEwNjgwODYgfHwgaWQgPT0gMHgwMTE2ODA4NiBcDQo+PiAg
ICAgICAgICAgICAgICAgICAgICAgICB8fCBpZCA9PSAweDAxMjY4MDg2IHx8IGlkID09IDB4MDEw
MjgwODYgXA0KPj4gICAgICAgICAgICAgICAgICAgICAgICAgfHwgaWQgPT0gMHgwMTEyODA4NiB8
fCBpZCA9PSAweDAxMjI4MDg2IFwNCj4+IGRpZmYgLS1naXQgYS94ZW4vaW5jbHVkZS94ZW4vdnBj
aS5oIGIveGVuL2luY2x1ZGUveGVuL3ZwY2kuaA0KPj4gaW5kZXggOWY1YjVkNTJlMS4uZDZjZjBi
YWYxNCAxMDA2NDQNCj4+IC0tLSBhL3hlbi9pbmNsdWRlL3hlbi92cGNpLmgNCj4+ICsrKyBiL3hl
bi9pbmNsdWRlL3hlbi92cGNpLmgNCj4+IEBAIC0xOSw2ICsxOSw4IEBAIHR5cGVkZWYgaW50IHZw
Y2lfcmVnaXN0ZXJfaW5pdF90KHN0cnVjdCBwY2lfZGV2ICpkZXYpOw0KPj4gI2RlZmluZSBWUENJ
X1BSSU9SSVRZX01JRERMRSAgICAiNSINCj4+ICNkZWZpbmUgVlBDSV9QUklPUklUWV9MT1cgICAg
ICAgIjkiDQo+PiANCj4+ICsjZGVmaW5lIFZQQ0lfRUNBTV9CREYoYWRkcikgICAgICgoKGFkZHIp
ICYgMHgwZmZmZjAwMCkgPj4gMTIpDQo+PiArDQo+PiAjZGVmaW5lIFJFR0lTVEVSX1ZQQ0lfSU5J
VCh4LCBwKSAgICAgICAgICAgICAgICBcDQo+PiAgIHN0YXRpYyB2cGNpX3JlZ2lzdGVyX2luaXRf
dCAqY29uc3QgeCMjX2VudHJ5ICBcDQo+PiAgICAgICAgICAgICAgICBfX3VzZWRfc2VjdGlvbigi
LmRhdGEudnBjaS4iIHApID0geA0KPj4gQEAgLTIwOCw2ICsyMTAsMTYgQEAgc3RhdGljIGlubGlu
ZSB1bnNpZ25lZCBpbnQgdm1zaXhfZW50cnlfbnIoY29uc3Qgc3RydWN0IHZwY2lfbXNpeCAqbXNp
eCwNCj4+IHsNCj4+ICAgICByZXR1cm4gZW50cnkgLSBtc2l4LT5lbnRyaWVzOw0KPj4gfQ0KPj4g
Kw0KPj4gKy8qIEVDQU0gbW1pbyByZWFkL3dyaXRlIGhlbHBlcnMgKi8NCj4gDQo+IE5pdDogY29t
bWVudCBzaG91bGQgbGlrZWx5IGJlIGJlbG93IHZwY2lfYWNjZXNzX2FsbG93ZWQuDQo+IA0KPj4g
K2Jvb2wgdnBjaV9hY2Nlc3NfYWxsb3dlZCh1bnNpZ25lZCBpbnQgcmVnLCB1bnNpZ25lZCBpbnQg
bGVuKTsNCj4+ICsNCj4+ICtib29sIHZwY2lfZWNhbV93cml0ZShwY2lfc2JkZl90IHNiZGYsIHVu
c2lnbmVkIGludCByZWcsIHVuc2lnbmVkIGludCBsZW4sDQo+PiArICAgICAgICAgICAgICAgICAg
ICAgICAgIHVuc2lnbmVkIGxvbmcgZGF0YSk7DQo+PiArDQo+PiArYm9vbCB2cGNpX2VjYW1fcmVh
ZChwY2lfc2JkZl90IHNiZGYsIHVuc2lnbmVkIGludCByZWcsIHVuc2lnbmVkIGludCBsZW4sDQo+
PiArICAgICAgICAgICAgICAgICAgICAgICAgdW5zaWduZWQgbG9uZyAqZGF0YSk7DQo+IA0KPiBO
aXQ6IHRoZSBsaW5lcyBjb250YWluaW5nIHRoZSBvdmVyZmxvdyBwYXJhbWV0ZXIgYXJlIG5vdCBw
cm9wZXJseQ0KPiBhbGlnbmVkLg0KDQpJIGNhbiBzZW5kIGEgdjggb2YgdGhpcyBwYXRjaCB0byBm
aXggdGhvc2UuDQpJIHdpbGwgd2FpdCB1bnRpbCB0aGVyZSBhcmUgb3RoZXIgdGhpbmdzIG9uIHRo
ZSBvdGhlciBwYXRjaGVzDQoNClRoYW5rcw0KQmVydHJhbmQNCg0KPiANCj4gVGhhbmtzLCBSb2dl
ci4NCg0K


From xen-devel-bounces@lists.xenproject.org Fri Oct 15 15:10:23 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 15:10:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.210800.367795 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbOqe-000416-Uh; Fri, 15 Oct 2021 15:10:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 210800.367795; Fri, 15 Oct 2021 15:10:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbOqe-00040z-Ru; Fri, 15 Oct 2021 15:10:16 +0000
Received: by outflank-mailman (input) for mailman id 210800;
 Fri, 15 Oct 2021 15:10:15 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mbOqd-00040t-UD
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 15:10:15 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mbOqc-00074t-Ve; Fri, 15 Oct 2021 15:10:14 +0000
Received: from [54.239.6.185] (helo=[192.168.0.140])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mbOqc-0006ar-Og; Fri, 15 Oct 2021 15:10:14 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=vh0ZxInDhydo1ovtUd1g3R0ouVC3IIv2Sn6et1433EU=; b=iyj+LT2ryjjXq0RiDOHUEn8tyj
	VtDwTns+NzKCuKBwKf16Ygt1axFgYYFUEFoPSL6/2IwAW6lVWNZzKxYC/N+xqTTQjcGad3yvH3qSz
	KjvjG/+3cgPNT57HH2i5zpOPFEbEL2KLyrncEF7foKYBzU7JDkhZmSWyd9BQKFqZ/JdM=;
Message-ID: <ec52b9e9-5908-7fd0-dfbf-31906eb8398d@xen.org>
Date: Fri, 15 Oct 2021 16:10:12 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.2.0
Subject: Re: [PATCH v7 2/5] xen/arm: Enable the existing x86 virtual PCI
 support for ARM
To: Bertrand Marquis <bertrand.marquis@arm.com>,
 xen-devel@lists.xenproject.org
Cc: iwj@xenproject.org, Rahul Singh <rahul.singh@arm.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Wei Liu <wl@xen.org>, Paul Durrant <paul@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <cover.1634305870.git.bertrand.marquis@arm.com>
 <847d430fdeb19e695176ddea71eeb11dcef8b23e.1634305870.git.bertrand.marquis@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <847d430fdeb19e695176ddea71eeb11dcef8b23e.1634305870.git.bertrand.marquis@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Bertrand,

On 15/10/2021 14:59, Bertrand Marquis wrote:
> diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci.c
> index 3aa8c3175f..082892c8a2 100644
> --- a/xen/drivers/passthrough/pci.c
> +++ b/xen/drivers/passthrough/pci.c
> @@ -766,7 +766,21 @@ int pci_add_device(u16 seg, u8 bus, u8 devfn,
>           list_add(&pdev->domain_list, &hardware_domain->pdev_list);
>       }
>       else
> +    {
> +#ifdef CONFIG_ARM
> +        /*
> +         * On ARM PCI devices discovery will be done by Dom0. Add vpci handler
> +         * when Dom0 inform XEN to add the PCI devices in XEN.
> +         */
> +        ret = vpci_add_handlers(pdev);

Sorry for only noticing it now. Looking at the last staging
  vpci_add_handlers() is annotated with __hwdom_init. On Arm, 
__hwdom_init means the function will disappear after boot.

However, pci_add_device() can be called from a physdev op. So I think we 
would need to drop __hwdom_init. I can't seem to find this change in 
this series. Did I miss anything?

The rest of the changes LGTM.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Oct 15 15:14:24 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 15:14:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.210808.367807 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbOud-0004hd-Fg; Fri, 15 Oct 2021 15:14:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 210808.367807; Fri, 15 Oct 2021 15:14:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbOud-0004hW-Cb; Fri, 15 Oct 2021 15:14:23 +0000
Received: by outflank-mailman (input) for mailman id 210808;
 Fri, 15 Oct 2021 15:14:22 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Fqmt=PD=arm.com=Bertrand.Marquis@srs-us1.protection.inumbo.net>)
 id 1mbOuc-0004hQ-55
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 15:14:22 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com (unknown
 [2a01:111:f400:fe0e::621])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 8fd49e19-2950-4055-9c5a-6574bc69148f;
 Fri, 15 Oct 2021 15:14:20 +0000 (UTC)
Received: from AS8PR04CA0089.eurprd04.prod.outlook.com (2603:10a6:20b:313::34)
 by AM0PR08MB3217.eurprd08.prod.outlook.com (2603:10a6:208:5e::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.25; Fri, 15 Oct
 2021 15:14:15 +0000
Received: from VE1EUR03FT049.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:313:cafe::c1) by AS8PR04CA0089.outlook.office365.com
 (2603:10a6:20b:313::34) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15 via Frontend
 Transport; Fri, 15 Oct 2021 15:14:15 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT049.mail.protection.outlook.com (10.152.19.216) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.15 via Frontend Transport; Fri, 15 Oct 2021 15:14:15 +0000
Received: ("Tessian outbound 16951d3c485e:v103");
 Fri, 15 Oct 2021 15:14:15 +0000
Received: from ddf242b6634c.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 508684CD-8537-4992-892B-4297CCA8CF12.1; 
 Fri, 15 Oct 2021 15:14:08 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id ddf242b6634c.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 15 Oct 2021 15:14:08 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com (2603:10a6:4:74::9)
 by DB9PR08MB6714.eurprd08.prod.outlook.com (2603:10a6:10:2a4::18) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16; Fri, 15 Oct
 2021 15:14:05 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955]) by DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955%4]) with mapi id 15.20.4587.031; Fri, 15 Oct 2021
 15:14:04 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8fd49e19-2950-4055-9c5a-6574bc69148f
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Yf2VFPezLaqTJAgzasJxu6h/fBw8U0G5tjKhMyiq014=;
 b=TO1DQQy/nsx99IZBMCGotOREDLSygxVH3lVrI7OpSKLFz3fcJPtHcjUWjLUbZaMoDzHxrqOR6eFCOLM0hhzeujGEJu5vEhGSfAB+t/UvPYxzkWFc4TBiD51cfpD6SktuYHcAwsc80LmNlJ137Yq7BlUYa2bybzb2HUQp6Jof5+M=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: aae02257d0f47096
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=XrqS19EdtTFajPFsBLzFmeAZn5Dz1viBUA3nwDmpqD7UHaHAnFHoiBXS0d2xPa6co7J/VS+g3V79zg6t4DPtvhOoqxvvqjQl0Z0GXZMH1DMWoIkcq4gBFCdPariMTk4ElI+BK4Jaj7962vvgWEd/TI0tIxYa9I/9+i3MaqsXV3Zmgg/guMv/NCXaepaoROVvw7oz7MUssFYwT4n0vFZ/NnnCtR8t0gJn74Kjo44zyBX6dfZrAKe7k4kix26+xmXhiqHiTkEuG9HNR/1A8C9p4lpUswdpvOfAio/oWo3/7NR4/qD/Y+Gk5uVyZuodk52ejVpTOLDp8hLNmohcYpL19Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Yf2VFPezLaqTJAgzasJxu6h/fBw8U0G5tjKhMyiq014=;
 b=E2Dsd5mufUXTaG7+SRbeh6yGuBU4Lf2R2Cyqc8/wSVe/dxe4E6VxBo+X4tUQFPmum4BQwHk+Zl2+vcqVzgUDWBDePjvQPRbeCUu+2NpHPazHqUb3nf9ECs8b/ypVdV01OWYcqyFhvvX1KXfZNBkzwT3Gt0jIWg0KoeZcBpZ27+VjHADwtSzB2FNLbQW2ZAFAoVIshCTmWts4AGRaQr9LxSI2sdSIHzLPtR122Nfg169naXucNGrFENNhQkEqiBDRk1bG3hbom6+FU9SO8Fwt4ieJ1/yMbgXW3BSlFs/UAJ+Pj/rowYLtsYP7jJff8lo31fNA73OnSIlHU2X+CVf87Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Yf2VFPezLaqTJAgzasJxu6h/fBw8U0G5tjKhMyiq014=;
 b=TO1DQQy/nsx99IZBMCGotOREDLSygxVH3lVrI7OpSKLFz3fcJPtHcjUWjLUbZaMoDzHxrqOR6eFCOLM0hhzeujGEJu5vEhGSfAB+t/UvPYxzkWFc4TBiD51cfpD6SktuYHcAwsc80LmNlJ137Yq7BlUYa2bybzb2HUQp6Jof5+M=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Julien Grall <julien@xen.org>
CC: Xen-devel <xen-devel@lists.xenproject.org>, Ian Jackson
	<iwj@xenproject.org>, Rahul Singh <Rahul.Singh@arm.com>, Stefano Stabellini
	<sstabellini@kernel.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>, George Dunlap
	<george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>, Wei Liu
	<wl@xen.org>, Paul Durrant <paul@xen.org>, =?iso-8859-1?Q?Roger_Pau_Monn=E9?=
	<roger.pau@citrix.com>
Subject: Re: [PATCH v7 2/5] xen/arm: Enable the existing x86 virtual PCI
 support for ARM
Thread-Topic: [PATCH v7 2/5] xen/arm: Enable the existing x86 virtual PCI
 support for ARM
Thread-Index: AQHXwcz8unryLt1qUEeMdpd7xMjDNavUKeYAgAABFAA=
Date: Fri, 15 Oct 2021 15:14:04 +0000
Message-ID: <D471145B-813F-457C-BB81-23BE1FFACB93@arm.com>
References: <cover.1634305870.git.bertrand.marquis@arm.com>
 <847d430fdeb19e695176ddea71eeb11dcef8b23e.1634305870.git.bertrand.marquis@arm.com>
 <ec52b9e9-5908-7fd0-dfbf-31906eb8398d@xen.org>
In-Reply-To: <ec52b9e9-5908-7fd0-dfbf-31906eb8398d@xen.org>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3654.120.0.1.13)
Authentication-Results-Original: xen.org; dkim=none (message not signed)
 header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: ba98799b-b9b1-406c-eaa9-08d98fee73b6
x-ms-traffictypediagnostic: DB9PR08MB6714:|AM0PR08MB3217:
x-ms-exchange-transport-forked: True
X-Microsoft-Antispam-PRVS:
	<AM0PR08MB321750473B7603D9B3673BA19DB99@AM0PR08MB3217.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:9508;OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 ox1YHyAKCORteb0Ns7EBD9TZD7K8c2eUCogHXDLtr1ScdMzwJiRH/ZtvV96BQdmNSyYMptj7vclebWtLwvaGf/XHpv/r2J5kQo5ZrKRUpcW3W3pH2b5yx8rmtMiIrEHGzEmdKsnjsSZJQkxh654dZKloEAIjcSaE0kUaHNCOekOBOmqBjAzpuDGD/ne+vbjCWe4wbQoPTt+59+1ULPcfpIoSM2BDiQgxbGzAYBjbCQA36HHgYtq4qX6vqbTzIx1pF+2rdVFwZPjMhY3xdALApG75JGcBRZ4leb59u23ZFmh2cqiRDZ2IQf4+uzrJiHkFCcG8Zc2yAPNlIwTE7TLebQYkKhkBkflUlershBP6UYZFeHHHEmhOU/1A6l1CW0OAtwfpSm9eXCPnRlqD0MwESnl5jkr8Glv8Tp1JtG3/KSf3uD96LmUagupaIf9OLITbDgOJvuBkYfpyMdAfFTCGCBvJMrdE0o9nmcjFt6M19MtZ2c0LJzoqr3Ee2bryWKEkPlfPlU8Vn+YePnq1HXwJMd9oK9H9v3+pqegB13UKvTnrhl9i9VZfVQ/OT+Zi9Ha5NkHoOlHaheOpmBhKiyhWcFigLWwS7UBedGyo/AzsHsH81cFvp3da+zcFjRBX3gowa9efzy4+EvA71X5pjonOmOSPVwF1ftTrqbIqmmZ7kJVdNGr7ICcsnTFD9/adFAijFywY0HGtvdar2aJcLE+Z+O6bAxtKrJNgOmKDnx+5bNaCi3Qpfwd1UXzr6UIMz/EG
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB6PR0801MB2024.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(26005)(8676002)(7416002)(6916009)(64756008)(66446008)(71200400001)(2616005)(66556008)(8936002)(66476007)(66946007)(91956017)(76116006)(6512007)(6486002)(186003)(2906002)(36756003)(33656002)(38070700005)(508600001)(122000001)(4326008)(53546011)(6506007)(38100700002)(86362001)(5660300002)(54906003)(316002)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="iso-8859-1"
Content-ID: <84E2D78D66D19541A847372643D678ED@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB6714
Original-Authentication-Results: xen.org; dkim=none (message not signed)
 header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT049.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	ea15857e-98f8-485f-44ed-08d98fee6d56
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	W5SDbrd65SxH2OidZNEqsT7h+Yrt4S5Enk/tvxBjAUPlwRhTYAp7o6mxZPD4V0e8gOyvPUf1O+FtNyMoWaj+/+Cuqb2bSAYTUMnWK42az9zX0l5406kibxNLsUFWsN32QHxSPXM3Dn4c92LgbhiB1+93FZZI2X6ONssLBW1b8kR31WGnLHnZ5jJqBaWNMLh4tHRR7Q8Kimnf4F6j3mU0paUM9vjHiCOnmPHLCZa9HixKpQ7dHnTAYiEx5A8+fy73bBolh4khgvT6ywBwNbiVD0zEY20c/c3LXvYBxYUHpKdVYHhijzlFgXujAMGWSaPlmxCH1bTcy2U9NIseTnn3SG3+HJTLhQzd6ZeOmbB0F+t04v6YDMnlaoSrkzjoxx+3+j4r8ACRFJAeHlBcm+cy5+6eyo0StsNJGYcqZtAKJyVbsitlEuZtrFUT961oTSqE7LG/eDOaQVDp6DYs4TciyqJK2ooqHr4szvlhHo2Trp9Yy21CAywY5UvI+ayML3rXQRAxYxT30vijcNi6DBaMKHx16n2vKsyBtXLiJ5Oz26Fh9ksOQmoexJ6vndu+VmrMd2SFlHvbzFlraej3BMD/mu+JJ/0xK6tJg8Z9WMJ9F2ejgUJ5B+dq0oOMxeD2UAsRK3KgYiRpUZ8sjk3HINIPg9UKTOQNY5tuyxQ9QIH5CqUWbL8x5kuarhvfxRIrbl3GfdKBWCJrwRAi3RdZ9CEvwA==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(53546011)(336012)(5660300002)(508600001)(8936002)(47076005)(81166007)(26005)(186003)(4326008)(82310400003)(6506007)(316002)(2906002)(6862004)(356005)(6486002)(70206006)(8676002)(54906003)(6512007)(36756003)(2616005)(33656002)(70586007)(36860700001)(107886003)(86362001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2021 15:14:15.4908
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: ba98799b-b9b1-406c-eaa9-08d98fee73b6
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT049.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3217

Hi,

> On 15 Oct 2021, at 16:10, Julien Grall <julien@xen.org> wrote:
>=20
> Hi Bertrand,
>=20
> On 15/10/2021 14:59, Bertrand Marquis wrote:
>> diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci=
.c
>> index 3aa8c3175f..082892c8a2 100644
>> --- a/xen/drivers/passthrough/pci.c
>> +++ b/xen/drivers/passthrough/pci.c
>> @@ -766,7 +766,21 @@ int pci_add_device(u16 seg, u8 bus, u8 devfn,
>>          list_add(&pdev->domain_list, &hardware_domain->pdev_list);
>>      }
>>      else
>> +    {
>> +#ifdef CONFIG_ARM
>> +        /*
>> +         * On ARM PCI devices discovery will be done by Dom0. Add vpci =
handler
>> +         * when Dom0 inform XEN to add the PCI devices in XEN.
>> +         */
>> +        ret =3D vpci_add_handlers(pdev);
>=20
> Sorry for only noticing it now. Looking at the last staging
> vpci_add_handlers() is annotated with __hwdom_init. On Arm, __hwdom_init =
means the function will disappear after boot.
>=20
> However, pci_add_device() can be called from a physdev op. So I think we =
would need to drop __hwdom_init. I can't seem to find this change in this s=
eries. Did I miss anything?

Good catch and not this is not in the serie.

Can we consider that a bug so that I can send a new patch or should I send =
a v8 ?

Cheers
Bertrand

>=20
> The rest of the changes LGTM.
>=20
> Cheers,
>=20
> --=20
> Julien Grall



From xen-devel-bounces@lists.xenproject.org Fri Oct 15 15:18:31 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 15:18:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.210816.367818 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbOyY-0005Mb-27; Fri, 15 Oct 2021 15:18:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 210816.367818; Fri, 15 Oct 2021 15:18:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbOyX-0005MU-Tk; Fri, 15 Oct 2021 15:18:25 +0000
Received: by outflank-mailman (input) for mailman id 210816;
 Fri, 15 Oct 2021 15:18:24 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mbOyW-0005MO-Cx
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 15:18:24 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mbOyU-0007Eq-Uc; Fri, 15 Oct 2021 15:18:22 +0000
Received: from [54.239.6.185] (helo=[192.168.0.140])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mbOyU-0007C9-NP; Fri, 15 Oct 2021 15:18:22 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=GM2v2tNpKGMkFIEekC/2+T1oszNEFZ3uynNX7Zfh8VU=; b=TwE94Jm2VaC0Ks0zWJX/qHl7Li
	TAQFmQd5je4OuG0r45B4aTxqBGRZ2YNik+PhYMsERHLiWrwhDx6I+SGa9UCfGhBbxeCwbI7RJv7Fp
	5CmLBDGvdsrLYnkO++NK0n6R3g/nmIW0PvIILElnG6TKC0gCQ6K3Op6ZTDsTNrwlvf4Y=;
Message-ID: <406fbce4-9e5a-a661-bd6a-a65956886f26@xen.org>
Date: Fri, 15 Oct 2021 16:18:20 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.2.0
Subject: Re: [PATCH v7 2/5] xen/arm: Enable the existing x86 virtual PCI
 support for ARM
To: Bertrand Marquis <Bertrand.Marquis@arm.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>,
 "iwj@xenproject.org" <iwj@xenproject.org>, Rahul Singh
 <Rahul.Singh@arm.com>, Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Wei Liu <wl@xen.org>, Paul Durrant <paul@xen.org>
References: <cover.1634305870.git.bertrand.marquis@arm.com>
 <847d430fdeb19e695176ddea71eeb11dcef8b23e.1634305870.git.bertrand.marquis@arm.com>
 <YWmQa4uMA8usiHcu@MacBook-Air-de-Roger.local>
 <801F3B48-BAA0-4520-8B41-E83627AA845C@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <801F3B48-BAA0-4520-8B41-E83627AA845C@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi Bertrand,

On 15/10/2021 16:06, Bertrand Marquis wrote:
>> On 15 Oct 2021, at 15:30, Roger Pau Monné <roger.pau@citrix.com> wrote:
>>
>> On Fri, Oct 15, 2021 at 02:59:19PM +0100, Bertrand Marquis wrote:
>>> From: Rahul Singh <rahul.singh@arm.com>
>>>
>>> The existing VPCI support available for X86 is adapted for Arm.
>>> When the device is added to XEN via the hyper call
>>> “PHYSDEVOP_pci_device_add”, VPCI handler for the config space
>>> access is added to the Xen to emulate the PCI devices config space.
>>>
>>> A MMIO trap handler for the PCI ECAM space is registered in XEN
>>> so that when guest is trying to access the PCI config space,XEN
>>> will trap the access and emulate read/write using the VPCI and
>>> not the real PCI hardware.
>>>
>>> For Dom0less systems scan_pci_devices() would be used to discover the
>>> PCI device in XEN and VPCI handler will be added during XEN boots.
>>>
>>> This patch is also doing some small fixes to fix compilation errors on
>>> arm32 of vpci and prevent 64bit accesses on 32bit:
>>> - use %zu instead of lu in header.c for print
>>> - prevent 64bit accesses in vpci_access_allowed
>>> - ifdef out using CONFIG_64BIT handling of len 8 in
>>> vpci_ecam_{read/write}
>>>
>>> Signed-off-by: Rahul Singh <rahul.singh@arm.com>
>>> Signed-off-by: Bertrand Marquis <bertrand.marquis@arm.com>
>>
>> The vpci bits looks fine to me, so:
>>
>> Acked-by: Roger Pau Monné <roger.pau@citrix.com>
> 
> Thanks
> 
>>
>> I have one question however related to the placement of the vpci setup
>> call in pci_add_device.
>>
>>> diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci.c
>>> index 3aa8c3175f..082892c8a2 100644
>>> --- a/xen/drivers/passthrough/pci.c
>>> +++ b/xen/drivers/passthrough/pci.c
>>> @@ -766,7 +766,21 @@ int pci_add_device(u16 seg, u8 bus, u8 devfn,
>>>          list_add(&pdev->domain_list, &hardware_domain->pdev_list);
>>>      }
>>>      else
>>> +    {
>>> +#ifdef CONFIG_ARM
>>> +        /*
>>> +         * On ARM PCI devices discovery will be done by Dom0. Add vpci handler
>>> +         * when Dom0 inform XEN to add the PCI devices in XEN.
>>> +         */
>>> +        ret = vpci_add_handlers(pdev);
>>> +        if ( ret )
>>> +        {
>>> +            printk(XENLOG_ERR "Setup of vPCI failed: %d\n", ret);
>>> +            goto out;
>>> +        }
>>
>> I'm likely lost here, but shouldn't this also be done for devices that
>> belong to the hardware domain and are assigned to it in the first
>> branch of this conditional?
>>
>> Or else you will end up with devices assigned to the hardware domain
>> that don't have vPCI setup for them.
> 
> I might be wrong but when the hardware domain is declaring the devices they are added to him.
> Then later when those device are assigned to a guest, they are removed from the hardware domain.

 From my understanding, when the device is initially registered we would 
go through the first branch because pdev->domain is not yet set.

The else would be taken only with subsequent call of 
PHYSDEVOP_manage_pci_add & co.

For the device assignment, a different path would be taken. This would 
go through the domctl XEN_DOMCTL_assign_device.

Therefore, I think Roger is right and the call belongs to the first 
branch. Otherwise, we would miss out the vpci handlers in some cases.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Oct 15 15:20:09 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 15:20:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.210823.367829 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbP0D-0006gy-Ci; Fri, 15 Oct 2021 15:20:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 210823.367829; Fri, 15 Oct 2021 15:20:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbP0D-0006gh-9e; Fri, 15 Oct 2021 15:20:09 +0000
Received: by outflank-mailman (input) for mailman id 210823;
 Fri, 15 Oct 2021 15:20:08 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=OB3O=PD=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1mbP0C-0006gC-4M
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 15:20:08 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id bc1c6b65-99b2-41fa-817f-d02f6a178f7f;
 Fri, 15 Oct 2021 15:20:07 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id B475A60E0C;
 Fri, 15 Oct 2021 15:20:05 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: bc1c6b65-99b2-41fa-817f-d02f6a178f7f
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1634311206;
	bh=x556hhFOILWFWTemgkti16JuunmtqWe1AxY0NQTosXk=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=MeSNyAMVDn37zUjJ/HJu37xoIe2XFKOZtXlzQ2Xfs9oouzQuG6vjGyFKGre6j428p
	 dPmTtCSzU+LE7dvykAfiGPyrP9cVwoUbJ7ZZgeObfZb2s3DQjZMFvnkVxQV0xYfCAF
	 9OCk37DT5vNNlX2sbol1Cw0K+QFUVMkXYu8lpeAfg6RWrtAxZ42yufXZNSi6V+ZwD+
	 CbTcmlAd8NZA/4HRHpUS57MpOplpQhvj6NII+moe9j+MYEIvDjXj9v5ePnM8T+7Sdi
	 dfpfwYRvZAa6izyS70j44IP4BLwuCKmfWyfBnylHZz9IZck1CV43lCarvt4bPTlhx8
	 YzS4/i440Aj2Q==
Date: Fri, 15 Oct 2021 08:20:04 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Bertrand Marquis <Bertrand.Marquis@arm.com>
cc: Julien Grall <julien@xen.org>, Xen-devel <xen-devel@lists.xenproject.org>, 
    Ian Jackson <iwj@xenproject.org>, Rahul Singh <Rahul.Singh@arm.com>, 
    Stefano Stabellini <sstabellini@kernel.org>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, 
    Andrew Cooper <andrew.cooper3@citrix.com>, 
    George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>, 
    Wei Liu <wl@xen.org>, Paul Durrant <paul@xen.org>, 
    =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= <roger.pau@citrix.com>
Subject: Re: [PATCH v7 2/5] xen/arm: Enable the existing x86 virtual PCI
 support for ARM
In-Reply-To: <D471145B-813F-457C-BB81-23BE1FFACB93@arm.com>
Message-ID: <alpine.DEB.2.21.2110150817230.9408@sstabellini-ThinkPad-T480s>
References: <cover.1634305870.git.bertrand.marquis@arm.com> <847d430fdeb19e695176ddea71eeb11dcef8b23e.1634305870.git.bertrand.marquis@arm.com> <ec52b9e9-5908-7fd0-dfbf-31906eb8398d@xen.org> <D471145B-813F-457C-BB81-23BE1FFACB93@arm.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Fri, 15 Oct 2021, Bertrand Marquis wrote:
> Hi,
> 
> > On 15 Oct 2021, at 16:10, Julien Grall <julien@xen.org> wrote:
> > 
> > Hi Bertrand,
> > 
> > On 15/10/2021 14:59, Bertrand Marquis wrote:
> >> diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci.c
> >> index 3aa8c3175f..082892c8a2 100644
> >> --- a/xen/drivers/passthrough/pci.c
> >> +++ b/xen/drivers/passthrough/pci.c
> >> @@ -766,7 +766,21 @@ int pci_add_device(u16 seg, u8 bus, u8 devfn,
> >>          list_add(&pdev->domain_list, &hardware_domain->pdev_list);
> >>      }
> >>      else
> >> +    {
> >> +#ifdef CONFIG_ARM
> >> +        /*
> >> +         * On ARM PCI devices discovery will be done by Dom0. Add vpci handler
> >> +         * when Dom0 inform XEN to add the PCI devices in XEN.
> >> +         */
> >> +        ret = vpci_add_handlers(pdev);
> > 
> > Sorry for only noticing it now. Looking at the last staging
> > vpci_add_handlers() is annotated with __hwdom_init. On Arm, __hwdom_init means the function will disappear after boot.
> > 
> > However, pci_add_device() can be called from a physdev op. So I think we would need to drop __hwdom_init. I can't seem to find this change in this series. Did I miss anything?
> 
> Good catch and not this is not in the serie.
> 
> Can we consider that a bug so that I can send a new patch or should I send a v8 ?
 
We don't typically do that, but I could make the change on commit, or
merge a second patch from you with this one on commit, after I run all
the gitlab-ci tests.

(I still have to read the series but FYI)


From xen-devel-bounces@lists.xenproject.org Fri Oct 15 15:22:11 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 15:22:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.210834.367840 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbP29-0007KQ-RO; Fri, 15 Oct 2021 15:22:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 210834.367840; Fri, 15 Oct 2021 15:22:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbP29-0007KJ-O6; Fri, 15 Oct 2021 15:22:09 +0000
Received: by outflank-mailman (input) for mailman id 210834;
 Fri, 15 Oct 2021 15:22:08 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Fqmt=PD=arm.com=Bertrand.Marquis@srs-us1.protection.inumbo.net>)
 id 1mbP28-0007K8-Tn
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 15:22:08 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com (unknown
 [2a01:111:f400:7d00::61d])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 2b578b5f-93ec-4328-8191-aa1017b7340d;
 Fri, 15 Oct 2021 15:22:07 +0000 (UTC)
Received: from AS8P251CA0027.EURP251.PROD.OUTLOOK.COM (2603:10a6:20b:2f2::9)
 by DB8PR08MB4169.eurprd08.prod.outlook.com (2603:10a6:10:ab::24) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15; Fri, 15 Oct
 2021 15:22:03 +0000
Received: from VE1EUR03FT016.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:2f2:cafe::99) by AS8P251CA0027.outlook.office365.com
 (2603:10a6:20b:2f2::9) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15 via Frontend
 Transport; Fri, 15 Oct 2021 15:22:03 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT016.mail.protection.outlook.com (10.152.18.115) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.15 via Frontend Transport; Fri, 15 Oct 2021 15:22:03 +0000
Received: ("Tessian outbound a8bfe25d7364:v103");
 Fri, 15 Oct 2021 15:22:02 +0000
Received: from 59118bf89d9f.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 6F60BC28-DEA8-43D9-AA0C-31E54534139B.1; 
 Fri, 15 Oct 2021 15:21:56 +0000
Received: from EUR01-VE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 59118bf89d9f.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 15 Oct 2021 15:21:56 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com (2603:10a6:4:74::9)
 by DB9PR08MB6714.eurprd08.prod.outlook.com (2603:10a6:10:2a4::18) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16; Fri, 15 Oct
 2021 15:21:54 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955]) by DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955%4]) with mapi id 15.20.4587.031; Fri, 15 Oct 2021
 15:21:54 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2b578b5f-93ec-4328-8191-aa1017b7340d
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=BkrKpOlu2K+v/47oj3jFI8xlPKPStmSbUstRAuprWc0=;
 b=clAtD9uM1J7D+tCZxEUbXxQq3NQ4srzM8uOgUVkLvbWc1DcLnSEqIkmV6ivMyFSwviNKpDakbSvMkroWJkOM+McidW26mOUfbFzPggkXSwV9uzkmFfJrBHsLEGKqpJtu666Ob/KZiU6gnL5I/dqpxtIAwaDaHTa6fw6Ybh6T7XU=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 9aa418b6092a01f5
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=WkQk/AxBoNynt2TDj8lyZvznKA5x7L2TqvGLBS4oOXnZk033hoO3NI9lrF+zNp6R53f8rwEuV/cU/f28wizdZUARjFuGDaZhEmPflSlOaiiShymip6waQatsaAL+9cEnV1FVh9+gvFwh0mYl5AHb5HQASratz9Jf8F6rcLM+QQuOjXYuEKwhxlMLDBCRyQaKDZXj1qtmNEYsJic5iVTapeu6tc1OIvsMO8UsYJUS7Jk65U0c6L21QVC7ew6qkPN8biKNiu38y0Myo5PSNNCD/SzrHNo4anTT3e7r7qhyW+6YBecjvWJENpgYUI3UjMrv3KxTGhVwowcIDZCdv8Xkmw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=BkrKpOlu2K+v/47oj3jFI8xlPKPStmSbUstRAuprWc0=;
 b=HQzSgE1deITsTg3zlhPN7X+xivqMQCYQuOI2Norg5iOCn0DgjzGxv04SGi10b4ebx/eWOgtUG0zBssfyNUJeRGfT0y9EW87ce+tv82SSg1BkG3VQIxwSXU0ndkLT6cAxPjmEY+s60Gg3a/7GBG5H/juYWNBS9FGCkVCvdX6cmnfkYwVtHmYebFNnJkMDkDfHAc6m5+BFF30ynI8u0w0bBOJxK6zGpjpqpKBtmGJdN7vFLYfpNtPwSvtNVr1G+VCFRpIfXEpp+8jQDA9NzWMqh0iF44au7BvQitGVL/qil0xKoJNhyKdBccZnl6BbkLjwHOiC8h2p/w3B2Do1Rh1O5Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=BkrKpOlu2K+v/47oj3jFI8xlPKPStmSbUstRAuprWc0=;
 b=clAtD9uM1J7D+tCZxEUbXxQq3NQ4srzM8uOgUVkLvbWc1DcLnSEqIkmV6ivMyFSwviNKpDakbSvMkroWJkOM+McidW26mOUfbFzPggkXSwV9uzkmFfJrBHsLEGKqpJtu666Ob/KZiU6gnL5I/dqpxtIAwaDaHTa6fw6Ybh6T7XU=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Stefano Stabellini <sstabellini@kernel.org>
CC: Julien Grall <julien@xen.org>, Xen-devel <xen-devel@lists.xenproject.org>,
	Ian Jackson <iwj@xenproject.org>, Rahul Singh <Rahul.Singh@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, Andrew Cooper
	<andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>, Jan
 Beulich <jbeulich@suse.com>, Wei Liu <wl@xen.org>, Paul Durrant
	<paul@xen.org>, =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>
Subject: Re: [PATCH v7 2/5] xen/arm: Enable the existing x86 virtual PCI
 support for ARM
Thread-Topic: [PATCH v7 2/5] xen/arm: Enable the existing x86 virtual PCI
 support for ARM
Thread-Index: AQHXwcz8unryLt1qUEeMdpd7xMjDNavUKeYAgAABFACAAAGtAIAAAIKA
Date: Fri, 15 Oct 2021 15:21:53 +0000
Message-ID: <34230BD4-9E31-4B57-867F-C924002FDF5E@arm.com>
References: <cover.1634305870.git.bertrand.marquis@arm.com>
 <847d430fdeb19e695176ddea71eeb11dcef8b23e.1634305870.git.bertrand.marquis@arm.com>
 <ec52b9e9-5908-7fd0-dfbf-31906eb8398d@xen.org>
 <D471145B-813F-457C-BB81-23BE1FFACB93@arm.com>
 <alpine.DEB.2.21.2110150817230.9408@sstabellini-ThinkPad-T480s>
In-Reply-To: <alpine.DEB.2.21.2110150817230.9408@sstabellini-ThinkPad-T480s>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3654.120.0.1.13)
Authentication-Results-Original: kernel.org; dkim=none (message not signed)
 header.d=none;kernel.org; dmarc=none action=none header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: ceaca3c9-d0cf-448a-956e-08d98fef8a6c
x-ms-traffictypediagnostic: DB9PR08MB6714:|DB8PR08MB4169:
x-ms-exchange-transport-forked: True
X-Microsoft-Antispam-PRVS:
	<DB8PR08MB416962CA6A3C595FDB46D2C09DB99@DB8PR08MB4169.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:10000;OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 quDqXMv+SS7lpmEC2cr4KABE/I3ndVC6ACgh/yE6AzCt/7DqcHEwV0SJnSssp7lxEE4Ysfx/WxoS5TAOiGYNqnEFmpvfrLaE9bqEkKSPLcKCKNms0h0iBXq1J6mQ/+G3XFOBqc8Z85I3WwuJkbyxY/KnXBK78pOo8ZA3fscyEuQafk2n0qzEf80wo+EyadAPcvSunmFwgXlyI0vWMpkupZ9u4wZhV6eBd0BHMjBkM+1Slr9mMYvUGhe6PDHKzfPJRyQLw6MjmQ02QSd/VX5flKILwYOmPakvLC0w/FNU/89T3fiCIh0CHRX5yJQjXsapkYvbY59WW67KwDB2Ttg/go6K7b4aMZv77duHHlP0D4I2C23RIjtdg4DTBkt/gny25hDJ2/sY4B4e7hMTbfdJ8EpH/n1L4ZS74PZwbdaJ+ogZrHRKAG2fhNU+lCTRPLU4BDfkSLvlljyUMBrSwCtyDFPIJzleI32689jCPy/1dAVbOwh0Ds5FGXTQPlEiDFvHHBLThA7U49IQO5c4YpASukHYGpTAXwRmtL/sWeebL2Chas1p152hfulcs6SzuCGNAQc/oQgw62m83lGFZmpECd/IjAjRms0IpgVw4ejwIpVnyiA3n06taXPMN9FJuHcdCotoyNZX9n+vkO45fQXR8RU3WMSiYma0C6YVP8UVZFpXj2K3i6tMJ7Ysl2PWCEXDKcQm2TYmBIC0Mbnb5NzkA8Y7dWbHuihnm1YshNuFayT+Myf9DcohiBuj1ToF+0nN
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB6PR0801MB2024.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(122000001)(4326008)(36756003)(2906002)(33656002)(38070700005)(508600001)(54906003)(316002)(53546011)(6506007)(5660300002)(86362001)(38100700002)(2616005)(66556008)(8936002)(66476007)(66946007)(91956017)(76116006)(8676002)(7416002)(26005)(71200400001)(6916009)(64756008)(66446008)(6486002)(186003)(6512007)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-ID: <35DF60943CD0F34B902AE9A25D9C5712@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB6714
Original-Authentication-Results: kernel.org; dkim=none (message not signed)
 header.d=none;kernel.org; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT016.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	1b44e6fb-f8c7-4218-9874-08d98fef8509
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	SxKTVeojPM3qtDGVPLaZj5/pnXutd4cEk9QG9xKqmmRY82ligz7L3PVc8qvLCUtlvDCmnF/FYeFq+yhC/aloGKNWFknFVPrVDGsbn9cM8iOK9FN/7DU+esfLSqkygvX0JczkA/AdWlDpTfXGaNzvVCZBCprIWRZGJPL+2vYMBBGeuIpc1X8ElvE7NqEwsNc2/Ygy9hHoYq8K2MHYCQdANe94Dxxs+WxFOhFHbSNzTCxVayrX9I57krGgZO3278mBFXvZBHs6XFj5oX4N1iipKIR64wMRtxbN9fG6dgGAd35/fonAlpPkoJoXiyMPiJnyAcMx9HLy8rAkW8odxR4iInBagCaywUTlTVjGhiH2j80WK+8ngRWvrlJTP6qxWQUkJamrqm9jdvHmf1YCEwEV0iu00NipsXciMqcG0JVyDvGc9j3RqRtuJaj5BjC085ggCFb4QpueYthAJEbeGsivjb2U6Fz/mL54x3HjvGGS9zrvsffdHgGSfJPvrciIH1WiW7DUBTQFg9jrFgTrlc5GddTSHN3o5m/z8m114ODYbCjlQ3AynTQXRBuPC1ZzmsdFFKXNmffZ7ElVEJC7+DYbR2da6GEw8D49Akc22MHHD+M6Zv0HoExyvlnqFn6cgKaVN5ZxKtcsnaePHZji2xSIREVMgmo9OXPXeH3/QyFJANlmDs6v11coOcLju9sxJSV8NEJp9MnfVDlbwTKHkBKPuA==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(6862004)(54906003)(2906002)(82310400003)(8936002)(316002)(8676002)(508600001)(6486002)(86362001)(53546011)(356005)(6506007)(47076005)(33656002)(36756003)(2616005)(70586007)(36860700001)(4326008)(81166007)(26005)(6512007)(336012)(5660300002)(70206006)(107886003)(186003);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2021 15:22:03.0923
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: ceaca3c9-d0cf-448a-956e-08d98fef8a6c
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT016.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB4169

SGksDQoNCj4gT24gMTUgT2N0IDIwMjEsIGF0IDE2OjIwLCBTdGVmYW5vIFN0YWJlbGxpbmkgPHNz
dGFiZWxsaW5pQGtlcm5lbC5vcmc+IHdyb3RlOg0KPiANCj4gT24gRnJpLCAxNSBPY3QgMjAyMSwg
QmVydHJhbmQgTWFycXVpcyB3cm90ZToNCj4+IEhpLA0KPj4gDQo+Pj4gT24gMTUgT2N0IDIwMjEs
IGF0IDE2OjEwLCBKdWxpZW4gR3JhbGwgPGp1bGllbkB4ZW4ub3JnPiB3cm90ZToNCj4+PiANCj4+
PiBIaSBCZXJ0cmFuZCwNCj4+PiANCj4+PiBPbiAxNS8xMC8yMDIxIDE0OjU5LCBCZXJ0cmFuZCBN
YXJxdWlzIHdyb3RlOg0KPj4+PiBkaWZmIC0tZ2l0IGEveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gv
cGNpLmMgYi94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC9wY2kuYw0KPj4+PiBpbmRleCAzYWE4YzMx
NzVmLi4wODI4OTJjOGEyIDEwMDY0NA0KPj4+PiAtLS0gYS94ZW4vZHJpdmVycy9wYXNzdGhyb3Vn
aC9wY2kuYw0KPj4+PiArKysgYi94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC9wY2kuYw0KPj4+PiBA
QCAtNzY2LDcgKzc2NiwyMSBAQCBpbnQgcGNpX2FkZF9kZXZpY2UodTE2IHNlZywgdTggYnVzLCB1
OCBkZXZmbiwNCj4+Pj4gICAgICAgICBsaXN0X2FkZCgmcGRldi0+ZG9tYWluX2xpc3QsICZoYXJk
d2FyZV9kb21haW4tPnBkZXZfbGlzdCk7DQo+Pj4+ICAgICB9DQo+Pj4+ICAgICBlbHNlDQo+Pj4+
ICsgICAgew0KPj4+PiArI2lmZGVmIENPTkZJR19BUk0NCj4+Pj4gKyAgICAgICAgLyoNCj4+Pj4g
KyAgICAgICAgICogT24gQVJNIFBDSSBkZXZpY2VzIGRpc2NvdmVyeSB3aWxsIGJlIGRvbmUgYnkg
RG9tMC4gQWRkIHZwY2kgaGFuZGxlcg0KPj4+PiArICAgICAgICAgKiB3aGVuIERvbTAgaW5mb3Jt
IFhFTiB0byBhZGQgdGhlIFBDSSBkZXZpY2VzIGluIFhFTi4NCj4+Pj4gKyAgICAgICAgICovDQo+
Pj4+ICsgICAgICAgIHJldCA9IHZwY2lfYWRkX2hhbmRsZXJzKHBkZXYpOw0KPj4+IA0KPj4+IFNv
cnJ5IGZvciBvbmx5IG5vdGljaW5nIGl0IG5vdy4gTG9va2luZyBhdCB0aGUgbGFzdCBzdGFnaW5n
DQo+Pj4gdnBjaV9hZGRfaGFuZGxlcnMoKSBpcyBhbm5vdGF0ZWQgd2l0aCBfX2h3ZG9tX2luaXQu
IE9uIEFybSwgX19od2RvbV9pbml0IG1lYW5zIHRoZSBmdW5jdGlvbiB3aWxsIGRpc2FwcGVhciBh
ZnRlciBib290Lg0KPj4+IA0KPj4+IEhvd2V2ZXIsIHBjaV9hZGRfZGV2aWNlKCkgY2FuIGJlIGNh
bGxlZCBmcm9tIGEgcGh5c2RldiBvcC4gU28gSSB0aGluayB3ZSB3b3VsZCBuZWVkIHRvIGRyb3Ag
X19od2RvbV9pbml0LiBJIGNhbid0IHNlZW0gdG8gZmluZCB0aGlzIGNoYW5nZSBpbiB0aGlzIHNl
cmllcy4gRGlkIEkgbWlzcyBhbnl0aGluZz8NCj4+IA0KPj4gR29vZCBjYXRjaCBhbmQgbm90IHRo
aXMgaXMgbm90IGluIHRoZSBzZXJpZS4NCj4+IA0KPj4gQ2FuIHdlIGNvbnNpZGVyIHRoYXQgYSBi
dWcgc28gdGhhdCBJIGNhbiBzZW5kIGEgbmV3IHBhdGNoIG9yIHNob3VsZCBJIHNlbmQgYSB2OCA/
DQo+IA0KPiBXZSBkb24ndCB0eXBpY2FsbHkgZG8gdGhhdCwgYnV0IEkgY291bGQgbWFrZSB0aGUg
Y2hhbmdlIG9uIGNvbW1pdCwgb3INCj4gbWVyZ2UgYSBzZWNvbmQgcGF0Y2ggZnJvbSB5b3Ugd2l0
aCB0aGlzIG9uZSBvbiBjb21taXQsIGFmdGVyIEkgcnVuIGFsbA0KPiB0aGUgZ2l0bGFiLWNpIHRl
c3RzLg0KDQpUaGFua3MgYnV0IHdlIG5lZWQgdG8gc29ydCBvdXQgdGhlIHdoZXJlIGZpcnN0IChK
dWxpZW7igJlzIG1haWwpLg0KDQpJIGd1ZXNzIGEgdjggd2lsbCBiZSByZXF1aXJlZC4NCg0KQ2hl
ZXJzDQpCZXJ0cmFuZA0KDQo+IA0KPiAoSSBzdGlsbCBoYXZlIHRvIHJlYWQgdGhlIHNlcmllcyBi
dXQgRllJKQ0KDQo=


From xen-devel-bounces@lists.xenproject.org Fri Oct 15 15:38:34 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 15:38:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.210845.367851 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbPHv-0000WH-E1; Fri, 15 Oct 2021 15:38:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 210845.367851; Fri, 15 Oct 2021 15:38:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbPHv-0000WA-9u; Fri, 15 Oct 2021 15:38:27 +0000
Received: by outflank-mailman (input) for mailman id 210845;
 Fri, 15 Oct 2021 15:38:26 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Fqmt=PD=arm.com=Bertrand.Marquis@srs-us1.protection.inumbo.net>)
 id 1mbPHu-0000W4-3g
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 15:38:26 +0000
Received: from EUR01-HE1-obe.outbound.protection.outlook.com (unknown
 [40.107.13.57]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id bf7e8320-ba37-4094-9159-efaeb2950d99;
 Fri, 15 Oct 2021 15:38:24 +0000 (UTC)
Received: from AM3PR07CA0123.eurprd07.prod.outlook.com (2603:10a6:207:7::33)
 by VE1PR08MB5872.eurprd08.prod.outlook.com (2603:10a6:800:1aa::16) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16; Fri, 15 Oct
 2021 15:38:20 +0000
Received: from VE1EUR03FT045.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:207:7:cafe::2) by AM3PR07CA0123.outlook.office365.com
 (2603:10a6:207:7::33) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.10 via Frontend
 Transport; Fri, 15 Oct 2021 15:38:20 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT045.mail.protection.outlook.com (10.152.19.51) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.15 via Frontend Transport; Fri, 15 Oct 2021 15:38:19 +0000
Received: ("Tessian outbound b9598e0ead92:v103");
 Fri, 15 Oct 2021 15:38:18 +0000
Received: from 59317a685499.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 AE7A8F88-E1B9-4D21-B3E4-9BFB92CA4F48.1; 
 Fri, 15 Oct 2021 15:38:10 +0000
Received: from EUR01-HE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 59317a685499.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 15 Oct 2021 15:38:10 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com (2603:10a6:4:74::9)
 by DBBPR08MB4728.eurprd08.prod.outlook.com (2603:10a6:10:d6::17) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.17; Fri, 15 Oct
 2021 15:38:05 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955]) by DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955%4]) with mapi id 15.20.4587.031; Fri, 15 Oct 2021
 15:38:05 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: bf7e8320-ba37-4094-9159-efaeb2950d99
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=5pfsxNnsT4NIh6xme90gDPokatEedxm6Zp05Lsz7/0A=;
 b=eduStwWsks90kTD1OOQVOEwnmcHS4LbEa/oYIDz1NZGxGpZgGiNVW4BmpN0MzX93H4qpwXhaaPXDL5CU0yRTSRr4NzNMGhJMiZ7e8DQX/fpyNMSJDB8EFYPBbLKXsXWrquUMA4S3zZEdpDewgt2Hbksps53syo+pXZ0ZJYVoBfU=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 0790663c178d3d2b
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=SJiz1BpyQ+yJG/b0H720f8cNAFIza2oG2956dqaXqYgQYOrUveZwsnW4BGnQXCRBETm76qOpQ9sspikug3l9qOomzXQIpJYWPmoEkq9ZfUI/DiBWNDSS++eiW4KXjz9pTkECgtTIAa7pOH3uZ5BBpGt7eQ7GuvUBz7mwSf0heNwFxs2+B4s58hBwEb5N6TV6HovpIWard2yNxH2KNXjLjUND7DjnxkcmK/yYW+1mx+FNKN3DaWAd6wvpzmPBHeVx2cYP1J2Pb90UpfmYPsGZD90N8Kn9iW3gHXGJrqu4w9/2QfiOtKYfw7Jy3vOKcZHTn4avkXZXdXQE2q05qHocXg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=5pfsxNnsT4NIh6xme90gDPokatEedxm6Zp05Lsz7/0A=;
 b=iX5HnMp+RKxpMXlClOeIF3Ccjp0jLSrkGadgNn1UBK8HJXqXvDeDp8nLq6ikne+z/gPY5Ph2rbt/Bb4VENAMWjc1s1zpdS+VJ9QemIdtqO7HGfPPDkH0NRBLVRzAQEI0DrjquxJ0enYHe5iTfB3/0En0ZgnCisFZwreQvhSmGfS9ltB4Vtm3RhMPYO1GYBl3DP/BZtC+JY1yHgkYmLVKJHiUjGZEYYhKI69GicToMxDjR6yDoTFUBNHSwA5TLuB1FWOHC3wRCsdt1FCb7YfgW/HNOfg2hta/K0gzXaqZNxcmId0b1LQy/RlHggfURGKHTGHqIQEpVC2g1SHb2tNoww==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=5pfsxNnsT4NIh6xme90gDPokatEedxm6Zp05Lsz7/0A=;
 b=eduStwWsks90kTD1OOQVOEwnmcHS4LbEa/oYIDz1NZGxGpZgGiNVW4BmpN0MzX93H4qpwXhaaPXDL5CU0yRTSRr4NzNMGhJMiZ7e8DQX/fpyNMSJDB8EFYPBbLKXsXWrquUMA4S3zZEdpDewgt2Hbksps53syo+pXZ0ZJYVoBfU=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Julien Grall <julien@xen.org>
CC: =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>, Xen-devel
	<xen-devel@lists.xenproject.org>, "iwj@xenproject.org" <iwj@xenproject.org>,
	Rahul Singh <Rahul.Singh@arm.com>, Stefano Stabellini
	<sstabellini@kernel.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>, George Dunlap
	<george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>, Wei Liu
	<wl@xen.org>, Paul Durrant <paul@xen.org>
Subject: Re: [PATCH v7 2/5] xen/arm: Enable the existing x86 virtual PCI
 support for ARM
Thread-Topic: [PATCH v7 2/5] xen/arm: Enable the existing x86 virtual PCI
 support for ARM
Thread-Index: AQHXwcz8unryLt1qUEeMdpd7xMjDNavUHq6AgAAKLQCAAANQAIAABYQA
Date: Fri, 15 Oct 2021 15:38:05 +0000
Message-ID: <9B3E6929-AA14-48ED-BE4F-65B7C4913B51@arm.com>
References: <cover.1634305870.git.bertrand.marquis@arm.com>
 <847d430fdeb19e695176ddea71eeb11dcef8b23e.1634305870.git.bertrand.marquis@arm.com>
 <YWmQa4uMA8usiHcu@MacBook-Air-de-Roger.local>
 <801F3B48-BAA0-4520-8B41-E83627AA845C@arm.com>
 <406fbce4-9e5a-a661-bd6a-a65956886f26@xen.org>
In-Reply-To: <406fbce4-9e5a-a661-bd6a-a65956886f26@xen.org>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3654.120.0.1.13)
Authentication-Results-Original: xen.org; dkim=none (message not signed)
 header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: ba29ec9c-7444-4241-b648-08d98ff1d04d
x-ms-traffictypediagnostic: DBBPR08MB4728:|VE1PR08MB5872:
x-ms-exchange-transport-forked: True
X-Microsoft-Antispam-PRVS:
	<VE1PR08MB58725EB8FAED42BF033A3B449DB99@VE1PR08MB5872.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:10000;OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 4jiG0lWYbZhEWdFVqsYGrN0dK16bHZ0JEO4AeWoTCfskNdv2ZVr52ASiA7lShzofqXA04Uq4DqG+BtQcb9Y8GKTFsDahm0uUBN7f3ubHdaVxhrQjZM1ByCOHV01T5TMRQByAUhAWYOKHSrTYoELnVc7CmJTIn+A2nOADxd+uBsa2WhxPAaWs7RMrt4cflYfryPbk76hTfqFmckgMffPFLoM4DzV0jhvzih7P/LzVeQKvAMeXym0Y6Hvi0Gz2jUIXOxNGDO21bKod9H0TblmXHfvDY5UhjCGXp/h5mSeKMgsaRMEFwVivcvpQAOA+H8OnqiaTwj/k3AJgCReuiAdyA1BV+Bq3NHrOOXBMsBwez4S491rssIGKvPgf1/siIK/zuRg80qTrct3b9Pyd6L62Pz4MMoTHO9EhDmwVhmMc9/QG7GDnrgbHiI4jQ7VEqf+YGoQ4ng8BbL/btNxXQ7lr72qdPPWDhxvqzVHN5bKw6jMyXPdPVmyH2M6rlbsuhw7cbkqKnT2R5dBnOikpWhzdby7Dwl/Rl3VxpYixPrOQgzDFkSne14V0t41ZixxFn28LXnCofU/yXvi5VMs2LABC8rLy61m2AfRVW4M02LZ7ywjpH8+Sf35/e5aRxS8SzkHbOsUKhj9X4dQtLIF8Li9uTXxsaPldBt73aSKEvzyMndWuIzpwULudTdOhwAQb8KDiiqGLXvTyo++en8lFdQ3g9i8WkHrSc7iTGuZyrjifkjDmKB7UFsgNlxgzSDufe+0a
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB6PR0801MB2024.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(33656002)(186003)(6916009)(316002)(4326008)(54906003)(2906002)(38070700005)(6486002)(66476007)(66556008)(64756008)(83380400001)(7416002)(66946007)(66446008)(5660300002)(91956017)(38100700002)(76116006)(2616005)(8676002)(36756003)(26005)(8936002)(6512007)(71200400001)(6506007)(508600001)(53546011)(122000001)(86362001)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-ID: <BEC3A492C6F1EF4C9E24C39B62A90A1F@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB4728
Original-Authentication-Results: xen.org; dkim=none (message not signed)
 header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT045.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	df98dc9a-5d06-4c1d-1824-08d98ff1c7da
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	ZhF3sKnKYZuf9Ia9rSnyRbK9k8qugPQn9wl5Mu+pTJj5RB/HVuh+8FRx8zBm9qs3CWkcaHSjM/ID6JScxaGtksP4fgIuCNTvX4QuA1ii/EhzjJcinDVgcUyDAyB8I69vyx6o3GRpDMuIztGXn0GHiwQ9pw+wD/PKkf0cfsV7FYq/QU/6UDKnUToNs6HG7C3SxwOFJ2G9kNJYu+SpBnVN9jzSOsXMftBADEMyz1VSHU+20qGBX+TJB/+RYr/ZOMurmW6JCgjh98jeXTpqxm6TNr4yNrRq7ZSh8b0+P6xGuVrFrHWqB1WYwp/rQdKJLGjBlFT3HyLbG+lIhFeanpaVzR6ZepG8o5+liwxifSNeUZWNFl1rreNNL1q2M3nfy0vzJMJQsX1rsUXYYO04NAuo4gzA1U17RdOhZ2d/kiYv7rpJYPo+vrPUFCbjv6+jifZmmTw4uiUHFX+tE00zz6VSv3PGznAEeEglgoZ3DZUnThYQKuVrSuzXARC+RGRFfdGspsOeFmVmCyEV+ldsQustKX/suysKBrGuRc4v3vKRBxkZ3acsZcMnC3+TO/qUyUdEObPwIQscSiXbBAJoq6FeLP2HK4tG+oc32nN5q81ZKO+6K3d+mMtHmlRub2ZycYe3vJKTEBSd4FbulTTm7m86pRCuUh3ZZpd2XVd4IZZczjzq+dh59gaqW4TZ95PIbmk0JJlCQ5bRDMRjzF+QEYIpdw==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(36860700001)(186003)(36756003)(70206006)(6862004)(6512007)(81166007)(70586007)(336012)(356005)(2616005)(508600001)(6486002)(4326008)(2906002)(5660300002)(8676002)(54906003)(26005)(83380400001)(8936002)(33656002)(47076005)(86362001)(316002)(82310400003)(6506007)(53546011);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2021 15:38:19.2830
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: ba29ec9c-7444-4241-b648-08d98ff1d04d
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT045.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5872

SGkgSnVsaWVuLA0KDQo+IE9uIDE1IE9jdCAyMDIxLCBhdCAxNjoxOCwgSnVsaWVuIEdyYWxsIDxq
dWxpZW5AeGVuLm9yZz4gd3JvdGU6DQo+IA0KPiBIaSBCZXJ0cmFuZCwNCj4gDQo+IE9uIDE1LzEw
LzIwMjEgMTY6MDYsIEJlcnRyYW5kIE1hcnF1aXMgd3JvdGU6DQo+Pj4gT24gMTUgT2N0IDIwMjEs
IGF0IDE1OjMwLCBSb2dlciBQYXUgTW9ubsOpIDxyb2dlci5wYXVAY2l0cml4LmNvbT4gd3JvdGU6
DQo+Pj4gDQo+Pj4gT24gRnJpLCBPY3QgMTUsIDIwMjEgYXQgMDI6NTk6MTlQTSArMDEwMCwgQmVy
dHJhbmQgTWFycXVpcyB3cm90ZToNCj4+Pj4gRnJvbTogUmFodWwgU2luZ2ggPHJhaHVsLnNpbmdo
QGFybS5jb20+DQo+Pj4+IA0KPj4+PiBUaGUgZXhpc3RpbmcgVlBDSSBzdXBwb3J0IGF2YWlsYWJs
ZSBmb3IgWDg2IGlzIGFkYXB0ZWQgZm9yIEFybS4NCj4+Pj4gV2hlbiB0aGUgZGV2aWNlIGlzIGFk
ZGVkIHRvIFhFTiB2aWEgdGhlIGh5cGVyIGNhbGwNCj4+Pj4g4oCcUEhZU0RFVk9QX3BjaV9kZXZp
Y2VfYWRk4oCdLCBWUENJIGhhbmRsZXIgZm9yIHRoZSBjb25maWcgc3BhY2UNCj4+Pj4gYWNjZXNz
IGlzIGFkZGVkIHRvIHRoZSBYZW4gdG8gZW11bGF0ZSB0aGUgUENJIGRldmljZXMgY29uZmlnIHNw
YWNlLg0KPj4+PiANCj4+Pj4gQSBNTUlPIHRyYXAgaGFuZGxlciBmb3IgdGhlIFBDSSBFQ0FNIHNw
YWNlIGlzIHJlZ2lzdGVyZWQgaW4gWEVODQo+Pj4+IHNvIHRoYXQgd2hlbiBndWVzdCBpcyB0cnlp
bmcgdG8gYWNjZXNzIHRoZSBQQ0kgY29uZmlnIHNwYWNlLFhFTg0KPj4+PiB3aWxsIHRyYXAgdGhl
IGFjY2VzcyBhbmQgZW11bGF0ZSByZWFkL3dyaXRlIHVzaW5nIHRoZSBWUENJIGFuZA0KPj4+PiBu
b3QgdGhlIHJlYWwgUENJIGhhcmR3YXJlLg0KPj4+PiANCj4+Pj4gRm9yIERvbTBsZXNzIHN5c3Rl
bXMgc2Nhbl9wY2lfZGV2aWNlcygpIHdvdWxkIGJlIHVzZWQgdG8gZGlzY292ZXIgdGhlDQo+Pj4+
IFBDSSBkZXZpY2UgaW4gWEVOIGFuZCBWUENJIGhhbmRsZXIgd2lsbCBiZSBhZGRlZCBkdXJpbmcg
WEVOIGJvb3RzLg0KPj4+PiANCj4+Pj4gVGhpcyBwYXRjaCBpcyBhbHNvIGRvaW5nIHNvbWUgc21h
bGwgZml4ZXMgdG8gZml4IGNvbXBpbGF0aW9uIGVycm9ycyBvbg0KPj4+PiBhcm0zMiBvZiB2cGNp
IGFuZCBwcmV2ZW50IDY0Yml0IGFjY2Vzc2VzIG9uIDMyYml0Og0KPj4+PiAtIHVzZSAlenUgaW5z
dGVhZCBvZiBsdSBpbiBoZWFkZXIuYyBmb3IgcHJpbnQNCj4+Pj4gLSBwcmV2ZW50IDY0Yml0IGFj
Y2Vzc2VzIGluIHZwY2lfYWNjZXNzX2FsbG93ZWQNCj4+Pj4gLSBpZmRlZiBvdXQgdXNpbmcgQ09O
RklHXzY0QklUIGhhbmRsaW5nIG9mIGxlbiA4IGluDQo+Pj4+IHZwY2lfZWNhbV97cmVhZC93cml0
ZX0NCj4+Pj4gDQo+Pj4+IFNpZ25lZC1vZmYtYnk6IFJhaHVsIFNpbmdoIDxyYWh1bC5zaW5naEBh
cm0uY29tPg0KPj4+PiBTaWduZWQtb2ZmLWJ5OiBCZXJ0cmFuZCBNYXJxdWlzIDxiZXJ0cmFuZC5t
YXJxdWlzQGFybS5jb20+DQo+Pj4gDQo+Pj4gVGhlIHZwY2kgYml0cyBsb29rcyBmaW5lIHRvIG1l
LCBzbzoNCj4+PiANCj4+PiBBY2tlZC1ieTogUm9nZXIgUGF1IE1vbm7DqSA8cm9nZXIucGF1QGNp
dHJpeC5jb20+DQo+PiBUaGFua3MNCj4+PiANCj4+PiBJIGhhdmUgb25lIHF1ZXN0aW9uIGhvd2V2
ZXIgcmVsYXRlZCB0byB0aGUgcGxhY2VtZW50IG9mIHRoZSB2cGNpIHNldHVwDQo+Pj4gY2FsbCBp
biBwY2lfYWRkX2RldmljZS4NCj4+PiANCj4+Pj4gZGlmZiAtLWdpdCBhL3hlbi9kcml2ZXJzL3Bh
c3N0aHJvdWdoL3BjaS5jIGIveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvcGNpLmMNCj4+Pj4gaW5k
ZXggM2FhOGMzMTc1Zi4uMDgyODkyYzhhMiAxMDA2NDQNCj4+Pj4gLS0tIGEveGVuL2RyaXZlcnMv
cGFzc3Rocm91Z2gvcGNpLmMNCj4+Pj4gKysrIGIveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvcGNp
LmMNCj4+Pj4gQEAgLTc2Niw3ICs3NjYsMjEgQEAgaW50IHBjaV9hZGRfZGV2aWNlKHUxNiBzZWcs
IHU4IGJ1cywgdTggZGV2Zm4sDQo+Pj4+ICAgICAgICAgbGlzdF9hZGQoJnBkZXYtPmRvbWFpbl9s
aXN0LCAmaGFyZHdhcmVfZG9tYWluLT5wZGV2X2xpc3QpOw0KPj4+PiAgICAgfQ0KPj4+PiAgICAg
ZWxzZQ0KPj4+PiArICAgIHsNCj4+Pj4gKyNpZmRlZiBDT05GSUdfQVJNDQo+Pj4+ICsgICAgICAg
IC8qDQo+Pj4+ICsgICAgICAgICAqIE9uIEFSTSBQQ0kgZGV2aWNlcyBkaXNjb3Zlcnkgd2lsbCBi
ZSBkb25lIGJ5IERvbTAuIEFkZCB2cGNpIGhhbmRsZXINCj4+Pj4gKyAgICAgICAgICogd2hlbiBE
b20wIGluZm9ybSBYRU4gdG8gYWRkIHRoZSBQQ0kgZGV2aWNlcyBpbiBYRU4uDQo+Pj4+ICsgICAg
ICAgICAqLw0KPj4+PiArICAgICAgICByZXQgPSB2cGNpX2FkZF9oYW5kbGVycyhwZGV2KTsNCj4+
Pj4gKyAgICAgICAgaWYgKCByZXQgKQ0KPj4+PiArICAgICAgICB7DQo+Pj4+ICsgICAgICAgICAg
ICBwcmludGsoWEVOTE9HX0VSUiAiU2V0dXAgb2YgdlBDSSBmYWlsZWQ6ICVkXG4iLCByZXQpOw0K
Pj4+PiArICAgICAgICAgICAgZ290byBvdXQ7DQo+Pj4+ICsgICAgICAgIH0NCj4+PiANCj4+PiBJ
J20gbGlrZWx5IGxvc3QgaGVyZSwgYnV0IHNob3VsZG4ndCB0aGlzIGFsc28gYmUgZG9uZSBmb3Ig
ZGV2aWNlcyB0aGF0DQo+Pj4gYmVsb25nIHRvIHRoZSBoYXJkd2FyZSBkb21haW4gYW5kIGFyZSBh
c3NpZ25lZCB0byBpdCBpbiB0aGUgZmlyc3QNCj4+PiBicmFuY2ggb2YgdGhpcyBjb25kaXRpb25h
bD8NCj4+PiANCj4+PiBPciBlbHNlIHlvdSB3aWxsIGVuZCB1cCB3aXRoIGRldmljZXMgYXNzaWdu
ZWQgdG8gdGhlIGhhcmR3YXJlIGRvbWFpbg0KPj4+IHRoYXQgZG9uJ3QgaGF2ZSB2UENJIHNldHVw
IGZvciB0aGVtLg0KPj4gSSBtaWdodCBiZSB3cm9uZyBidXQgd2hlbiB0aGUgaGFyZHdhcmUgZG9t
YWluIGlzIGRlY2xhcmluZyB0aGUgZGV2aWNlcyB0aGV5IGFyZSBhZGRlZCB0byBoaW0uDQo+PiBU
aGVuIGxhdGVyIHdoZW4gdGhvc2UgZGV2aWNlIGFyZSBhc3NpZ25lZCB0byBhIGd1ZXN0LCB0aGV5
IGFyZSByZW1vdmVkIGZyb20gdGhlIGhhcmR3YXJlIGRvbWFpbi4NCj4gDQo+IEZyb20gbXkgdW5k
ZXJzdGFuZGluZywgd2hlbiB0aGUgZGV2aWNlIGlzIGluaXRpYWxseSByZWdpc3RlcmVkIHdlIHdv
dWxkIGdvIHRocm91Z2ggdGhlIGZpcnN0IGJyYW5jaCBiZWNhdXNlIHBkZXYtPmRvbWFpbiBpcyBu
b3QgeWV0IHNldC4NCj4gDQo+IFRoZSBlbHNlIHdvdWxkIGJlIHRha2VuIG9ubHkgd2l0aCBzdWJz
ZXF1ZW50IGNhbGwgb2YgUEhZU0RFVk9QX21hbmFnZV9wY2lfYWRkICYgY28uDQo+IA0KPiBGb3Ig
dGhlIGRldmljZSBhc3NpZ25tZW50LCBhIGRpZmZlcmVudCBwYXRoIHdvdWxkIGJlIHRha2VuLiBU
aGlzIHdvdWxkIGdvIHRocm91Z2ggdGhlIGRvbWN0bCBYRU5fRE9NQ1RMX2Fzc2lnbl9kZXZpY2Uu
DQo+IA0KPiBUaGVyZWZvcmUsIEkgdGhpbmsgUm9nZXIgaXMgcmlnaHQgYW5kIHRoZSBjYWxsIGJl
bG9uZ3MgdG8gdGhlIGZpcnN0IGJyYW5jaC4gT3RoZXJ3aXNlLCB3ZSB3b3VsZCBtaXNzIG91dCB0
aGUgdnBjaSBoYW5kbGVycyBpbiBzb21lIGNhc2VzLg0KDQpZZXMgd2Ugb25seSB3YW50IHRoaXMg
dG8gYmUgZG9uZSBvbmNlIG9uIHRoZSBmaXJzdCBjYWxsLg0KDQpTbyBpbiBmYWN0IGl0IHNob3Vs
ZCBiZSBkb25lIHdoZW4gcGRldi0+ZG9tYWluIGlzIE5VTEwgaW4gdGhlIGZpcnN0IGJyYW5jaC4N
Cg0KSSB3aWxsIGRvIHRoaXMgaW4gdjguDQoNClRoYW5rcyBhIGxvdCBmb3IgdGhlIGFuYWx5c2lz
LCBzYXlpbmcgaXQgbWFrZXMgdGhpbmdzIG1vcmUgY2xlYXIgOi0pDQoNCkNoZWVycw0KQmVydHJh
bmQNCg0KPiANCj4gQ2hlZXJzLA0KPiANCj4gLS0gDQo+IEp1bGllbiBHcmFsbA0KDQo=


From xen-devel-bounces@lists.xenproject.org Fri Oct 15 15:42:01 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 15:42:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.210852.367861 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbPLM-0001t4-Sw; Fri, 15 Oct 2021 15:42:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 210852.367861; Fri, 15 Oct 2021 15:42:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbPLM-0001sx-Q2; Fri, 15 Oct 2021 15:42:00 +0000
Received: by outflank-mailman (input) for mailman id 210852;
 Fri, 15 Oct 2021 15:41:59 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mbPLL-0001sn-8u; Fri, 15 Oct 2021 15:41:59 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mbPLL-0007e5-2p; Fri, 15 Oct 2021 15:41:59 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mbPLK-00029A-Lb; Fri, 15 Oct 2021 15:41:58 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mbPLK-0002zv-L4; Fri, 15 Oct 2021 15:41:58 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=yyNyYh5ryhmgdE5EUeVVtIhBlJm7JrWh6rWJ0hRJ7K0=; b=cVTiUeeUV4IrAUEZIZzNBGXLBJ
	j1z0gIvFJC7xNRe6A48ODbOSB2WX41H/WiXWBPlJ93eMjGcl5FNtwTkN3g8cSULa6b3ITFX2BA/1b
	/0XUxB/7T99vEgl99ylOc07iqGG7OlEHyo8iZpsL5Ww4arBqO83dA/X8owAoEHmT05TI=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165518-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 165518: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable
    linux-linus:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=ec681c53f8d2d0ee362ff67f5b98dd8263c15002
X-Osstest-Versions-That:
    linux=26d6574109838b8fa40a8261421693015bab0579
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 15 Oct 2021 15:41:58 +0000

flight 165518 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165518/

Failures :-/ but no regressions.

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds    18 guest-start/debian.repeat fail REGR. vs. 165510

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-rtds     20 guest-localmigrate/x10       fail  like 165510
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 165510
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 165510
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165510
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165510
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 165510
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165510
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 165510
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 165510
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 linux                ec681c53f8d2d0ee362ff67f5b98dd8263c15002
baseline version:
 linux                26d6574109838b8fa40a8261421693015bab0579

Last test of basis   165510  2021-10-14 14:42:03 Z    1 days
Testing same since   165518  2021-10-15 05:57:36 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Alvin Šipraga <alsi@bang-olufsen.dk>
  Arnd Bergmann <arnd@arndb.de>
  Arun Ramadoss <arun.ramadoss@microchip.com>
  Aya Levin <ayal@nvidia.com>
  Baowen Zheng <baowen.zheng@corigine.com>
  Cai Huoqing <caihuoqing@baidu.com>
  chongjiapeng <jiapeng.chong@linux.alibaba.com>
  Corentin Noël <corentin.noel@collabora.com>
  David S. Miller <davem@davemloft.net>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Florian Fainelli <f.fainelli@gmail.com>
  Haiyang Zhang <haiyangz@microsoft.com>
  Herve Codina <herve.codina@bootlin.com>
  Ido Schimmel <idosch@nvidia.com>
  Jacob Keller <jacob.e.keller@intel.com>
  Jakub Kicinski <kuba@kernel.org>
  Justin Iurman <justin.iurman@uliege.be>
  Karsten Graul <kgraul@linux.ibm.com>
  Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
  Lin Ma <linma@zju.edu.cn>
  Linus Torvalds <torvalds@linux-foundation.org>
  Louis Peens <louis.peens@corigine.com>
  Maarten Zanders <maarten.zanders@mind.be>
  Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
  Marcelo Ricardo Leitner <mleitner@redhat.com>
  Mat Martineau <mathew.j.martineau@linux.intel.com>
  Maxim Mikityanskiy <maximmi@nvidia.com>
  Michael S. Tsirkin <mst@redhat.com>
  Nanyong Sun <sunnanyong@huawei.com>
  Paolo Abeni <pabeni@redhat.com>
  Saeed Mahameed <saeedm@nvidia.com>
  Sebastian Andrzej Siewior <bigeasy@linutronix.de>
  Shannon Nelson <snelson@pensando.io>
  Shay Drory <shayd@nvidia.com>
  Simon Horman <simon.horman@corigine.com>
  Stephen Boyd <swboyd@chromium.org>
  Tariq Toukan <tariqt@nvidia.com>
  Tony Nguyen <anthony.l.nguyen@intel.com>
  Vadim Pasternak <vadimp@nvidia.com>
  Valentine Fatiev <valentinef@nvidia.com>
  Vegard Nossum <vegard.nossum@oracle.com>
  Vladimir Oltean <vladimir.oltean@nxp.com>
  Wan Jiabing <wanjiabing@vivo.com>
  Xiaolong Huang <butterflyhuangxx@gmail.com>
  Xin Long <lucien.xin@gmail.com>
  Xuan Zhuo <xuanzhuo@linux.alibaba.com>
  Zheyu Ma <zheyuma97@gmail.com>
  Ziyang Xuan <william.xuanziyang@huawei.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     fail    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   26d657410983..ec681c53f8d2  ec681c53f8d2d0ee362ff67f5b98dd8263c15002 -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Fri Oct 15 15:46:27 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 15:46:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.210862.367875 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbPPa-0002bi-Ia; Fri, 15 Oct 2021 15:46:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 210862.367875; Fri, 15 Oct 2021 15:46:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbPPa-0002bb-FO; Fri, 15 Oct 2021 15:46:22 +0000
Received: by outflank-mailman (input) for mailman id 210862;
 Fri, 15 Oct 2021 15:46:21 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mbPPZ-0002bV-PU
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 15:46:21 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mbPPZ-0007jY-Ok
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 15:46:21 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mbPPZ-0001Sw-Nj
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 15:46:21 +0000
Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89)
 (envelope-from <iwj@xenproject.org>)
 id 1mbPPU-0006CS-LP; Fri, 15 Oct 2021 16:46:16 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date
	:Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From;
	bh=pRAgxyL+/eH+9LIEtM4JCzHaRddQGyhmbw5gN4KFOSE=; b=Z2sKRjXevI34Fu8X7LKY6uP8at
	9LSzGh1qRIaA7NcghTlLte1n54RWDZ1vDXrONWM4/P34P0U3xaTR9o+JiZeyBfATNiZI7nfr3gnFP
	iqbq8jcD/jO/iECOBEVYRjgTcNikzCtoRW+dVUwnQeSoQaNZKOU1QiAcQ6upAPX4Qqps=;
From: Ian Jackson <iwj@xenproject.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <24937.41544.300001.875658@mariner.uk.xensource.com>
Date: Fri, 15 Oct 2021 16:46:16 +0100
To: Julien Grall <julien@xen.org>
Cc: Bertrand Marquis <bertrand.marquis@arm.com>,
    xen-devel@lists.xenproject.org,
    Rahul Singh <rahul.singh@arm.com>,
    Wei Liu <wl@xen.org>,
    Anthony PERARD <anthony.perard@citrix.com>,
    Juergen Gross <jgross@suse.com>,
    Stefano Stabellini  <sstabellini@kernel.org>,
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
    Michal Orzel <michal.orzel@arm.com>
Subject: Re: [PATCH v7 5/5] arm/libxl: Emulated PCI device tree node in libxl
In-Reply-To: <0204f92a-4637-d3cd-5420-979e9c03f237@xen.org>
References: <cover.1634305870.git.bertrand.marquis@arm.com>
	<4a22121e6474adfb1c5166e0fdaddff47c6dae46.1634305870.git.bertrand.marquis@arm.com>
	<0204f92a-4637-d3cd-5420-979e9c03f237@xen.org>
X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu)

Julien Grall writes ("Re: [PATCH v7 5/5] arm/libxl: Emulated PCI device tree node in libxl"):
> On 15/10/2021 14:59, Bertrand Marquis wrote:
> > Signed-off-by: Rahul Singh <rahul.singh@arm.com>
> > Signed-off-by: Michal Orzel <michal.orzel@arm.com>
> 
> I believe you need to add your signed-off-by here as you sent the new 
> version on xen-devel.
> 
> With one remark below (not to be handled for 4.16):
> 
> Reviewed-by: Julien Grall <jgrall@amazon.com>

Acked-by: Ian Jackson <iwj@xenproject.org>

Ian.


From xen-devel-bounces@lists.xenproject.org Fri Oct 15 15:51:20 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 15:51:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.210871.367887 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbPUM-00040E-5W; Fri, 15 Oct 2021 15:51:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 210871.367887; Fri, 15 Oct 2021 15:51:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbPUM-000407-1x; Fri, 15 Oct 2021 15:51:18 +0000
Received: by outflank-mailman (input) for mailman id 210871;
 Fri, 15 Oct 2021 15:51:17 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Fqmt=PD=arm.com=Bertrand.Marquis@srs-us1.protection.inumbo.net>)
 id 1mbPUL-000401-3x
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 15:51:17 +0000
Received: from EUR03-DB5-obe.outbound.protection.outlook.com (unknown
 [40.107.4.66]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 8c49da7a-882f-4921-bc9d-244838d8f717;
 Fri, 15 Oct 2021 15:51:15 +0000 (UTC)
Received: from DB6PR0202CA0019.eurprd02.prod.outlook.com (2603:10a6:4:29::29)
 by PR3PR08MB5852.eurprd08.prod.outlook.com (2603:10a6:102:8e::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.17; Fri, 15 Oct
 2021 15:51:12 +0000
Received: from DB5EUR03FT004.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:4:29:cafe::b7) by DB6PR0202CA0019.outlook.office365.com
 (2603:10a6:4:29::29) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15 via Frontend
 Transport; Fri, 15 Oct 2021 15:51:12 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT004.mail.protection.outlook.com (10.152.20.128) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.15 via Frontend Transport; Fri, 15 Oct 2021 15:51:12 +0000
Received: ("Tessian outbound b9598e0ead92:v103");
 Fri, 15 Oct 2021 15:51:12 +0000
Received: from 56194ff95feb.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 CFCF9EB0-C4C0-40F5-BDDF-62E188327330.1; 
 Fri, 15 Oct 2021 15:51:01 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 56194ff95feb.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 15 Oct 2021 15:51:01 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com (2603:10a6:4:74::9)
 by DB8PR08MB3930.eurprd08.prod.outlook.com (2603:10a6:10:a7::28) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15; Fri, 15 Oct
 2021 15:50:59 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955]) by DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955%4]) with mapi id 15.20.4587.031; Fri, 15 Oct 2021
 15:50:59 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8c49da7a-882f-4921-bc9d-244838d8f717
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=0bGH/qu2dgSDtErA7z2J90g4PQX1c+73o5cjfXC4M2E=;
 b=1miN8ZZuAh9uYjVNe6xz+JUy7oAt7rAhKy0Xglovx/ACik8WCnCjPfDnz4omRjbKeorTDduR3cZTo/1dZfci/Vfe4mzdaqr6wRiXH2t9S0l1Xsdbqmnv3j6jbZWbbG2W0CVGqwBfZoqOfW+rvD6EIc5pgZUyXcYuBIoEygqUxFI=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: dc3b848e7ae1fd00
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=AjDk4WOcsuVq4saTb6wP/RPdvg2YUACttoRfsoPUbixAv7UomuuWrI07T9lUZ5tWFRwr6ydp6Hkc7ZjIQaUSRqN7JSfKk74FaYYAixl+JWGWwoWxaQyBsgJUcZ0SCiIEdlV9iCcya6B59crsDeDbOY/hmpC4duyCXZKwTAiqCGCda4dSV/GP59zC+wwHZTT6bm0IrL6WMC6VMzjM5w1sMJ79mlzVpi7asKTItx/mWWS/5DT/Dmf7TpmzY+BM9Y0AxsQOBRT1cXJX6ixuot0U8Zk3eGNaOPrl7LDKN1zqd6hZkjxmnJzfMJ1JR+bnytVKqFv9Z6/nBTMPEWc5pTcAgw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=0bGH/qu2dgSDtErA7z2J90g4PQX1c+73o5cjfXC4M2E=;
 b=M+1lqnzofTLv7Emql1yGFObODp2yhsJcX0waBQPC6QaoFo+bAHNVW67KXGDgQOQIYXi64o1B0verQY9tcYKoaFUEHgSvHy+IVlK2sz5rF2rK6w7gPEzHA3Rs1LCp+EZRgTm/C96mWVPrs3zyyEd7APZBs0lq0uzbMayBesJedmWXXJ9oTcmVqp93UJx9yEN/1BpuCWb71j8ZsCk7w47Ou6L1i2rAnUT3KF7QRPKASjJnxg3xjCnCmqtSorDHnze3RTjoFdMyMhG63Q9RSma23hajfZxNP1MVHMGYsmgs3x7SHgi3vssbmYlX2DHThlGXKYyg04a+NhqXvQjYzwOnZA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=0bGH/qu2dgSDtErA7z2J90g4PQX1c+73o5cjfXC4M2E=;
 b=1miN8ZZuAh9uYjVNe6xz+JUy7oAt7rAhKy0Xglovx/ACik8WCnCjPfDnz4omRjbKeorTDduR3cZTo/1dZfci/Vfe4mzdaqr6wRiXH2t9S0l1Xsdbqmnv3j6jbZWbbG2W0CVGqwBfZoqOfW+rvD6EIc5pgZUyXcYuBIoEygqUxFI=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Ian Jackson <iwj@xenproject.org>, Rahul Singh <Rahul.Singh@arm.com>,
	Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, Andrew Cooper
	<andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>, Jan
 Beulich <jbeulich@suse.com>, Wei Liu <wl@xen.org>, Paul Durrant
	<paul@xen.org>, =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>
Subject: Re: [PATCH v7 2/5] xen/arm: Enable the existing x86 virtual PCI
 support for ARM
Thread-Topic: [PATCH v7 2/5] xen/arm: Enable the existing x86 virtual PCI
 support for ARM
Thread-Index: AQHXwcz8unryLt1qUEeMdpd7xMjDNavUNUuA
Date: Fri, 15 Oct 2021 15:50:59 +0000
Message-ID: <DA5ED16C-6D1E-4A7C-95D7-B1C910F86EBC@arm.com>
References: <cover.1634305870.git.bertrand.marquis@arm.com>
 <847d430fdeb19e695176ddea71eeb11dcef8b23e.1634305870.git.bertrand.marquis@arm.com>
In-Reply-To:
 <847d430fdeb19e695176ddea71eeb11dcef8b23e.1634305870.git.bertrand.marquis@arm.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3654.120.0.1.13)
Authentication-Results-Original: lists.xenproject.org; dkim=none (message not
 signed) header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: 1c0d1a19-c003-4309-8826-08d98ff39cdd
x-ms-traffictypediagnostic: DB8PR08MB3930:|PR3PR08MB5852:
x-ms-exchange-transport-forked: True
X-Microsoft-Antispam-PRVS:
	<PR3PR08MB5852B88F58D59AC94A5FF3159DB99@PR3PR08MB5852.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:3968;OLM:3968;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 05njcGvAubW+1TucZemNrax47oR2AtEKQQkUi/G+gvzSuP+OeDx2JvR21/UI75zZw4hEyh1+h0cc3duDPIsDC8YVds+lH02IGc1XyABvq7SxCY45CEItsXyHia8ZYMtOU08biR9ZDkoTY3J8IBn85bMrBAy4qrtEjZFO6POEPJf3N10acuVrzX5XuQQ8xSXjr/ucHvPEPmpjvP18n95cQGNCEpw2HGtwb+IJPxEzXDwQxttoXG2cu0I/NiJDfhmrx/fp7ckJ0hXnL5wadS5vhYe9jYg2twwHOIYO7/E2t+BPntj4yDclC8wigCwVYZw/dL0u/HR4u87b17sC1hUdaiZcLWp+uyd7DdeePVczKgkiVyootmjh0BypoiaXDtYvBMyHumWKyjb+ROjHrjYT+u3HLClChZcHUZ3Ybs/KWqkFT+WFmo9mmOUdzXog+puWivrZju08lDRtLtJTphZIetgrzOSgn4TzSmWKWyLv4kcnpN5/Uad7K3oJf1c8Bw5eUwMmorY4NhVSZ2SKDsUrQNwRuPzzjkS/3jGl6vCK7ga/Rn5bPsd2KY3Gb9P3CTrm8osPsxHAbfCRzjJTm+B+MLi2i4LIDHuk1L3sLOwzVIs2vpJdKmEy/n4vIakuNFWi8/Xz94Tbpbjd0U6zRWUZdbY0UxTeiPu80YAdZn1HBllfUUH9gPf3TcZ/nAnPXdNTjkc9KOPusU4KRPxiyzHMJ3HocRGc1x0DIIbGFcV6CPnmLbWUXKqomazDU62XFHSflG7Ozzk2C89+u3aEavxYdw==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB6PR0801MB2024.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(64756008)(54906003)(66446008)(316002)(6486002)(508600001)(36756003)(186003)(91956017)(38070700005)(2616005)(30864003)(71200400001)(2906002)(6512007)(83380400001)(66946007)(86362001)(4326008)(76116006)(7416002)(6916009)(33656002)(26005)(6506007)(53546011)(122000001)(66476007)(8936002)(66556008)(8676002)(5660300002)(38100700002)(2004002)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-ID: <AE0A414BDA8FFA4BB7CAC483A8C12F4D@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB3930
Original-Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT004.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	4ccd16b7-04cd-4ca7-49af-08d98ff39579
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	h2WDpyOPmVeFtiqvcV5q3WyJBF4VqIycS7W1z3aSsc07FxJWK1DeSUXh6LAyp87k5+1zchmO3NBrHkuK8Yov3XGp33xFkWPJv4hLkVukeKca5It3Z5mIhFSJbibDC/HsEL0Kha3ofFWfgdplDLaZVISHK+egSFXNTowxrhgE+WkwcVpzagNSEu3JaxEBo06F6DCqy4dZ9R4eovza7YZRugXP56b8QdyQ9IEx1rHDNl9Oa+IzyZOICohE67A6a1DICcxL+OkN5oDsMZVcs3fN5n66ote/kYg+TkyVl94GLcEMAXZrkdKrBLm7zkYjjkA4mjp/e8Nv6pvLgKEnP7drN3KNfj+xgfSy6iACRYs5oD1adb67gruaW9kt+NPrZ4GupFTpuONGOr1eB7R59rQ6Lf44QrSD2v/Ofgp7mFlNcOJI5pQO8WKeDZMP5UVUpFYx0JuCtWjFXEmdggtc6hQ/Kt+1rh2HiMYoPWl+tqeQf2IGkpneu7CT0h2wMpWhxTXMCZCeIBhCvo+TsZR0WvcOZmCZf4Jb6uZeJELTT6TiZXR5Nic9gm3dlSJFgF5Cy8Y4MfbE/WacAAZ5eqwzABX5L0AlL2VP4LJPqndw6ygvPObgU3cUj+KbENA37huqHDDQFRz7jLyll98oSFYBHVXWaZtMKY8P7sfD1V1+EO8YPmFVed45S16/wKlt50SDi7XPgyhxHi/36CPK6cax7N078oreKZBmesmFEe31evkeIHU=
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(70206006)(5660300002)(70586007)(83380400001)(356005)(6506007)(81166007)(508600001)(53546011)(6512007)(36860700001)(47076005)(86362001)(107886003)(8676002)(36756003)(2616005)(82310400003)(8936002)(26005)(336012)(6916009)(33656002)(186003)(30864003)(6486002)(2906002)(4326008)(54906003)(316002)(2004002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2021 15:51:12.1154
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 1c0d1a19-c003-4309-8826-08d98ff39cdd
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT004.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR08MB5852

SGksDQoNCj4gT24gMTUgT2N0IDIwMjEsIGF0IDE0OjU5LCBCZXJ0cmFuZCBNYXJxdWlzIDxiZXJ0
cmFuZC5tYXJxdWlzQGFybS5jb20+IHdyb3RlOg0KPiANCj4gRnJvbTogUmFodWwgU2luZ2ggPHJh
aHVsLnNpbmdoQGFybS5jb20+DQo+IA0KPiBUaGUgZXhpc3RpbmcgVlBDSSBzdXBwb3J0IGF2YWls
YWJsZSBmb3IgWDg2IGlzIGFkYXB0ZWQgZm9yIEFybS4NCj4gV2hlbiB0aGUgZGV2aWNlIGlzIGFk
ZGVkIHRvIFhFTiB2aWEgdGhlIGh5cGVyIGNhbGwNCj4g4oCcUEhZU0RFVk9QX3BjaV9kZXZpY2Vf
YWRk4oCdLCBWUENJIGhhbmRsZXIgZm9yIHRoZSBjb25maWcgc3BhY2UNCj4gYWNjZXNzIGlzIGFk
ZGVkIHRvIHRoZSBYZW4gdG8gZW11bGF0ZSB0aGUgUENJIGRldmljZXMgY29uZmlnIHNwYWNlLg0K
PiANCj4gQSBNTUlPIHRyYXAgaGFuZGxlciBmb3IgdGhlIFBDSSBFQ0FNIHNwYWNlIGlzIHJlZ2lz
dGVyZWQgaW4gWEVODQo+IHNvIHRoYXQgd2hlbiBndWVzdCBpcyB0cnlpbmcgdG8gYWNjZXNzIHRo
ZSBQQ0kgY29uZmlnIHNwYWNlLFhFTg0KPiB3aWxsIHRyYXAgdGhlIGFjY2VzcyBhbmQgZW11bGF0
ZSByZWFkL3dyaXRlIHVzaW5nIHRoZSBWUENJIGFuZA0KPiBub3QgdGhlIHJlYWwgUENJIGhhcmR3
YXJlLg0KPiANCj4gRm9yIERvbTBsZXNzIHN5c3RlbXMgc2Nhbl9wY2lfZGV2aWNlcygpIHdvdWxk
IGJlIHVzZWQgdG8gZGlzY292ZXIgdGhlDQo+IFBDSSBkZXZpY2UgaW4gWEVOIGFuZCBWUENJIGhh
bmRsZXIgd2lsbCBiZSBhZGRlZCBkdXJpbmcgWEVOIGJvb3RzLg0KPiANCj4gVGhpcyBwYXRjaCBp
cyBhbHNvIGRvaW5nIHNvbWUgc21hbGwgZml4ZXMgdG8gZml4IGNvbXBpbGF0aW9uIGVycm9ycyBv
bg0KPiBhcm0zMiBvZiB2cGNpIGFuZCBwcmV2ZW50IDY0Yml0IGFjY2Vzc2VzIG9uIDMyYml0Og0K
PiAtIHVzZSAlenUgaW5zdGVhZCBvZiBsdSBpbiBoZWFkZXIuYyBmb3IgcHJpbnQNCj4gLSBwcmV2
ZW50IDY0Yml0IGFjY2Vzc2VzIGluIHZwY2lfYWNjZXNzX2FsbG93ZWQNCj4gLSBpZmRlZiBvdXQg
dXNpbmcgQ09ORklHXzY0QklUIGhhbmRsaW5nIG9mIGxlbiA4IGluDQo+IHZwY2lfZWNhbV97cmVh
ZC93cml0ZX0NCj4gDQo+IFNpZ25lZC1vZmYtYnk6IFJhaHVsIFNpbmdoIDxyYWh1bC5zaW5naEBh
cm0uY29tPg0KPiBTaWduZWQtb2ZmLWJ5OiBCZXJ0cmFuZCBNYXJxdWlzIDxiZXJ0cmFuZC5tYXJx
dWlzQGFybS5jb20+DQo+IC0tLQ0KPiBDaGFuZ2VzIGluIHY3Og0KPiAtIGFkYXB0IHRvIGNoYW5n
ZXMgaW4gdnBjaSBnZW5lcmljIGZ1bmN0aW9ucyAobmFtZSBhbmQgdHlwZSkNCj4gLSByZW1vdmUg
Y2FsbCB0byBwY2lfY2xlYW51cF9tc2kgb24gZXJyb3IgZXhpdA0KPiAtIG1vdmUgcGNpX2FkZF9o
YW5kbGVycyB0byBiZSBvbmx5IGRvbmUgd2hlbiBwZGV2LT5kb21haW4gaXMgbm90IE5VTEwNCj4g
LSBSZW1vdmUgY2FzdCB0byB1bnNpZ25lZCBsb25nIGluIGhlYWRlci5jIGFuZCB1c2UgJXp1IGZv
ciBwcmludA0KPiAtIEZpeCBub24gYXNjaWkgY2hhcnMgaW4gYXJjaC1hcm0uaA0KPiAtIFVzZSBD
T05GSUdfNjRCSVQgaW5zaWRlIHZwY2lfYWNjZXNzX2FsbG93ZWQgdG8gcHJldmVudCA2NGJpdCBh
Y2Nlc3Mgb24NCj4gMzJiaXQgcGxhdGZvcm1zDQo+IC0gVXNlIENPTkZJR182NEJJVCB0byBjb21w
aWxlIG91dCA2NGJpdCBjYXNlcyBpbiB2cGNpX2VjYW1fe3JlYWQvd3JpdGV9DQo+IENoYW5nZXMg
aW4gdjY6DQo+IC0gVXNlIG5ldyB2cGNpX2VjYW1fIGhlbHBlcnMgZm9yIFBDSSBhY2Nlc3MNCj4g
LSBEbyBub3Qgc2V0IFhFTl9ET01DVExfQ0RGX3ZwY2kgZm9yIGRvbTAgZm9yIG5vdyAod2lsbCBi
ZSBkb25lIGluIGENCj4gZnV0dXJlIHBhdGNoIG9uY2UgZXZlcnl0aGluZyBpcyByZWFkeSkNCj4g
LSByZW5hbWUgUkVHSVNURVJfT0ZGU0VUIHRvIEVDQU1fUkVHX09GRlNFVCBhbmQgbW92ZSBpdCB0
byBwY2kuaA0KPiAtIHJlbW92ZSBub3QgbmVlZGVkIGxvY2FsIHZhcmlhYmxlcyBpbiB2cGNpX21t
aW9fd3JpdGUsIHRoZSBvbmUgaW4gcmVhZA0KPiBoYXMgYmVlbiBrZXB0IHRvIGVuc3VyZSBwcm9w
ZXIgY29tcGlsYXRpb24gb24gYXJtMzINCj4gLSBtb3ZlIGNhbGwgdG8gdnBjaV9hZGRfaGFuZGxl
cnMgYmVmb3JlIGlvbW11IGluaXQgdG8gc2ltcGxpZnkgZXhpdCBwYXRoDQo+IC0gbW92ZSBjYWxs
IHRvIHBjaV9jbGVhbnVwX21zaSBpbiB0aGUgb3V0IHNlY3Rpb24gb2YgcGNpX2FkZF9kZXZpY2Ug
aWYNCj4gcGRldiBpcyBub3QgTlVMTCBhbmQgb24gZXJyb3INCj4gLSBpbml0aWFsaXplIHBkZXYg
dG8gTlVMTCB0byBoYW5kbGUgcHJvcGVybHkgZXhpdCBwYXRoIGNhbGwgb2YNCj4gcGNpX2NsZWFu
dXBfbXNpDQo+IC0ga2VlcCBoYXNfdnBjaSB0byByZXR1cm4gZmFsc2UgZm9yIG5vdyBhcyBDRkdf
dnBjaSBoYXMgYmVlbiByZW1vdmVkLg0KPiBBZGRlZCBhIGNvbW1lbnQgb24gdG9wIG9mIHRoZSBk
ZWZpbml0aW9uLg0KPiAtIGZpeCBjb21waWxhdGlvbiBlcnJvcnMgb24gYXJtMzIgKHByaW50IGlu
IGhlYWRlci5jLCBjYXN0IG1pc3NpbmcgaW4NCj4gbW1pb193cml0ZS4NCj4gLSBsb2NhbCB2YXJp
YWJsZSB3YXMga2VwdCBpbiB2cGNpX21taW9fcmVhZCBvbiBhcm0gdG8gcHJldmVudCBhIGNhc3QN
Cj4gZXJyb3IgaW4gYXJtMzIuDQo+IENoYW5nZSBpbiB2NToNCj4gLSBBZGQgcGNpX2NsZWFudXBf
bXNpKHBkZXYpIGluY2xlYW51cCBwYXJ0Lg0KPiAtIEFkZGVkIFJldmlld2VkLWJ5OiBTdGVmYW5v
IFN0YWJlbGxpbmkgPHNzdGFiZWxsaW5pQGtlcm5lbC5vcmc+DQo+IENoYW5nZSBpbiB2NDoNCj4g
LSBNb3ZlIGFkZGl0aW9uIG9mIFhFTl9ET01DVExfQ0RGX3ZwY2kgZmxhZyB0byBzZXBhcmF0ZSBw
YXRjaA0KPiBDaGFuZ2UgaW4gdjM6DQo+IC0gVXNlIGlzX3BjaV9wYXNzdGhyb3VnaF9lbmFibGVk
KCkgaW4gcGxhY2Ugb2YgcGNpX3Bhc3N0aHJvdWdoX2VuYWJsZWQgdmFyaWFibGUNCj4gLSBSZWpl
Y3QgWEVOX0RPTUNUTF9DREZfdnBjaSBmb3IgeDg2IGluIGFyY2hfc2FuaXRpc2VfZG9tYWluX2Nv
bmZpZygpDQo+IC0gUmVtb3ZlIElTX0VOQUJMRUQoQ09ORklHX0hBU19WUENJKSBmcm9tIGhhc192
cGNpKCkNCj4gQ2hhbmdlIGluIHYyOg0KPiAtIEFkZCBuZXcgWEVOX0RPTUNUTF9DREZfdnBjaSBm
bGFnDQo+IC0gbW9kaWZ5IGhhc192cGNpKCkgdG8gaW5jbHVkZSBYRU5fRE9NQ1RMX0NERl92cGNp
DQo+IC0gZW5hYmxlIHZwY2kgc3VwcG9ydCB3aGVuIHBjaS1wYXNzdGhvdWdoIG9wdGlvbiBpcyBl
bmFibGVkLg0KPiAtLS0NCj4gLS0tDQo+IHhlbi9hcmNoL2FybS9NYWtlZmlsZSAgICAgICAgIHwg
IDEgKw0KPiB4ZW4vYXJjaC9hcm0vZG9tYWluLmMgICAgICAgICB8ICA0ICsrDQo+IHhlbi9hcmNo
L2FybS92cGNpLmMgICAgICAgICAgIHwgNzcgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr
KysrKysNCj4geGVuL2FyY2gvYXJtL3ZwY2kuaCAgICAgICAgICAgfCAzNiArKysrKysrKysrKysr
KysrDQo+IHhlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL3BjaS5jIHwgMTQgKysrKysrKw0KPiB4ZW4v
ZHJpdmVycy92cGNpL2hlYWRlci5jICAgICB8ICAyICstDQo+IHhlbi9kcml2ZXJzL3ZwY2kvdnBj
aS5jICAgICAgIHwgMTAgKysrKysNCj4geGVuL2luY2x1ZGUvYXNtLWFybS9kb21haW4uaCAgfCAg
MSArDQo+IHhlbi9pbmNsdWRlL3B1YmxpYy9hcmNoLWFybS5oIHwgIDcgKysrKw0KPiB4ZW4vaW5j
bHVkZS94ZW4vcGNpLmggICAgICAgICB8ICAyICsNCj4gMTAgZmlsZXMgY2hhbmdlZCwgMTUzIGlu
c2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkNCj4gY3JlYXRlIG1vZGUgMTAwNjQ0IHhlbi9hcmNo
L2FybS92cGNpLmMNCj4gY3JlYXRlIG1vZGUgMTAwNjQ0IHhlbi9hcmNoL2FybS92cGNpLmgNCj4g
DQo+IGRpZmYgLS1naXQgYS94ZW4vYXJjaC9hcm0vTWFrZWZpbGUgYi94ZW4vYXJjaC9hcm0vTWFr
ZWZpbGUNCj4gaW5kZXggNjQ1MTg4NDhiMi4uMDdmNjM0NTA4ZSAxMDA2NDQNCj4gLS0tIGEveGVu
L2FyY2gvYXJtL01ha2VmaWxlDQo+ICsrKyBiL3hlbi9hcmNoL2FybS9NYWtlZmlsZQ0KPiBAQCAt
Nyw2ICs3LDcgQEAgaWZuZXEgKCQoQ09ORklHX05PX1BMQVQpLHkpDQo+IG9iai15ICs9IHBsYXRm
b3Jtcy8NCj4gZW5kaWYNCj4gb2JqLSQoQ09ORklHX1RFRSkgKz0gdGVlLw0KPiArb2JqLSQoQ09O
RklHX0hBU19WUENJKSArPSB2cGNpLm8NCj4gDQo+IG9iai0kKENPTkZJR19IQVNfQUxURVJOQVRJ
VkUpICs9IGFsdGVybmF0aXZlLm8NCj4gb2JqLXkgKz0gYm9vdGZkdC5pbml0Lm8NCj4gZGlmZiAt
LWdpdCBhL3hlbi9hcmNoL2FybS9kb21haW4uYyBiL3hlbi9hcmNoL2FybS9kb21haW4uYw0KPiBp
bmRleCBlZWYwNjYxYmViLi45NmUxYjIzNTUwIDEwMDY0NA0KPiAtLS0gYS94ZW4vYXJjaC9hcm0v
ZG9tYWluLmMNCj4gKysrIGIveGVuL2FyY2gvYXJtL2RvbWFpbi5jDQo+IEBAIC0zOSw2ICszOSw3
IEBADQo+ICNpbmNsdWRlIDxhc20vdmdpYy5oPg0KPiAjaW5jbHVkZSA8YXNtL3Z0aW1lci5oPg0K
PiANCj4gKyNpbmNsdWRlICJ2cGNpLmgiDQo+ICNpbmNsdWRlICJ2dWFydC5oIg0KPiANCj4gREVG
SU5FX1BFUl9DUFUoc3RydWN0IHZjcHUgKiwgY3Vycl92Y3B1KTsNCj4gQEAgLTc3Myw2ICs3NzQs
OSBAQCBpbnQgYXJjaF9kb21haW5fY3JlYXRlKHN0cnVjdCBkb21haW4gKmQsDQo+ICAgICBpZiAo
IGlzX2hhcmR3YXJlX2RvbWFpbihkKSAmJiAocmMgPSBkb21haW5fdnVhcnRfaW5pdChkKSkgKQ0K
PiAgICAgICAgIGdvdG8gZmFpbDsNCj4gDQo+ICsgICAgaWYgKCAocmMgPSBkb21haW5fdnBjaV9p
bml0KGQpKSAhPSAwICkNCj4gKyAgICAgICAgZ290byBmYWlsOw0KPiArDQo+ICAgICByZXR1cm4g
MDsNCj4gDQo+IGZhaWw6DQo+IGRpZmYgLS1naXQgYS94ZW4vYXJjaC9hcm0vdnBjaS5jIGIveGVu
L2FyY2gvYXJtL3ZwY2kuYw0KPiBuZXcgZmlsZSBtb2RlIDEwMDY0NA0KPiBpbmRleCAwMDAwMDAw
MDAwLi5hMzEyZDAyZjNkDQo+IC0tLSAvZGV2L251bGwNCj4gKysrIGIveGVuL2FyY2gvYXJtL3Zw
Y2kuYw0KPiBAQCAtMCwwICsxLDc3IEBADQo+ICsvKg0KPiArICogeGVuL2FyY2gvYXJtL3ZwY2ku
Yw0KPiArICoNCj4gKyAqIFRoaXMgcHJvZ3JhbSBpcyBmcmVlIHNvZnR3YXJlOyB5b3UgY2FuIHJl
ZGlzdHJpYnV0ZSBpdCBhbmQvb3IgbW9kaWZ5DQo+ICsgKiBpdCB1bmRlciB0aGUgdGVybXMgb2Yg
dGhlIEdOVSBHZW5lcmFsIFB1YmxpYyBMaWNlbnNlIGFzIHB1Ymxpc2hlZCBieQ0KPiArICogdGhl
IEZyZWUgU29mdHdhcmUgRm91bmRhdGlvbjsgZWl0aGVyIHZlcnNpb24gMiBvZiB0aGUgTGljZW5z
ZSwgb3INCj4gKyAqIChhdCB5b3VyIG9wdGlvbikgYW55IGxhdGVyIHZlcnNpb24uDQo+ICsgKg0K
PiArICogVGhpcyBwcm9ncmFtIGlzIGRpc3RyaWJ1dGVkIGluIHRoZSBob3BlIHRoYXQgaXQgd2ls
bCBiZSB1c2VmdWwsDQo+ICsgKiBidXQgV0lUSE9VVCBBTlkgV0FSUkFOVFk7IHdpdGhvdXQgZXZl
biB0aGUgaW1wbGllZCB3YXJyYW50eSBvZg0KPiArICogTUVSQ0hBTlRBQklMSVRZIG9yIEZJVE5F
U1MgRk9SIEEgUEFSVElDVUxBUiBQVVJQT1NFLiAgU2VlIHRoZQ0KPiArICogR05VIEdlbmVyYWwg
UHVibGljIExpY2Vuc2UgZm9yIG1vcmUgZGV0YWlscy4NCj4gKyAqLw0KPiArI2luY2x1ZGUgPHhl
bi9zY2hlZC5oPg0KPiArI2luY2x1ZGUgPHhlbi92cGNpLmg+DQo+ICsNCj4gKyNpbmNsdWRlIDxh
c20vbW1pby5oPg0KPiArDQo+ICtzdGF0aWMgaW50IHZwY2lfbW1pb19yZWFkKHN0cnVjdCB2Y3B1
ICp2LCBtbWlvX2luZm9fdCAqaW5mbywNCj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgcmVn
aXN0ZXJfdCAqciwgdm9pZCAqcCkNCj4gK3sNCj4gKyAgICBwY2lfc2JkZl90IHNiZGY7DQo+ICsg
ICAgLyogZGF0YSBpcyBuZWVkZWQgdG8gcHJldmVudCBhIHBvaW50ZXIgY2FzdCBvbiAzMmJpdCAq
Lw0KPiArICAgIHVuc2lnbmVkIGxvbmcgZGF0YTsNCj4gKw0KPiArICAgIC8qIFdlIGlnbm9yZSBz
ZWdtZW50IHBhcnQgYW5kIGFsd2F5cyBoYW5kbGUgc2VnbWVudCAwICovDQo+ICsgICAgc2JkZi5z
YmRmID0gVkNQSV9FQ0FNX0JERihpbmZvLT5ncGEpOw0KDQpUeXBvOiBzL1ZDUEkvVlBDSSAhIQ0K
DQpTb3JyeSBmb3IgdGhhdC4NCg0KV2lsbCBmaXggaW4gdjguDQoNCkNoZWVycw0KQmVydHJhbmQN
Cg0KPiArDQo+ICsgICAgaWYgKCB2cGNpX2VjYW1fcmVhZChzYmRmLCBFQ0FNX1JFR19PRkZTRVQo
aW5mby0+Z3BhKSwNCj4gKyAgICAgICAgICAgICAgICAgICAgICAgIDFVIDw8IGluZm8tPmRhYnQu
c2l6ZSwgJmRhdGEpICkNCj4gKyAgICB7DQo+ICsgICAgICAgICpyID0gZGF0YTsNCj4gKyAgICAg
ICAgcmV0dXJuIDE7DQo+ICsgICAgfQ0KPiArDQo+ICsgICAgKnIgPSB+MHVsOw0KPiArDQo+ICsg
ICAgcmV0dXJuIDA7DQo+ICt9DQo+ICsNCj4gK3N0YXRpYyBpbnQgdnBjaV9tbWlvX3dyaXRlKHN0
cnVjdCB2Y3B1ICp2LCBtbWlvX2luZm9fdCAqaW5mbywNCj4gKyAgICAgICAgICAgICAgICAgICAg
ICAgICAgIHJlZ2lzdGVyX3Qgciwgdm9pZCAqcCkNCj4gK3sNCj4gKyAgICBwY2lfc2JkZl90IHNi
ZGY7DQo+ICsNCj4gKyAgICAvKiBXZSBpZ25vcmUgc2VnbWVudCBwYXJ0IGFuZCBhbHdheXMgaGFu
ZGxlIHNlZ21lbnQgMCAqLw0KPiArICAgIHNiZGYuc2JkZiA9IFZDUElfRUNBTV9CREYoaW5mby0+
Z3BhKTsNCg0KVHlwbzogcy9WQ1BJL1ZQQ0kgIQ0KDQo+ICsNCj4gKyAgICByZXR1cm4gdnBjaV9l
Y2FtX3dyaXRlKHNiZGYsIEVDQU1fUkVHX09GRlNFVChpbmZvLT5ncGEpLA0KPiArICAgICAgICAg
ICAgICAgICAgICAgICAgICAgMVUgPDwgaW5mby0+ZGFidC5zaXplLCByKTsNCj4gK30NCj4gKw0K
PiArc3RhdGljIGNvbnN0IHN0cnVjdCBtbWlvX2hhbmRsZXJfb3BzIHZwY2lfbW1pb19oYW5kbGVy
ID0gew0KPiArICAgIC5yZWFkICA9IHZwY2lfbW1pb19yZWFkLA0KPiArICAgIC53cml0ZSA9IHZw
Y2lfbW1pb193cml0ZSwNCj4gK307DQo+ICsNCj4gK2ludCBkb21haW5fdnBjaV9pbml0KHN0cnVj
dCBkb21haW4gKmQpDQo+ICt7DQo+ICsgICAgaWYgKCAhaGFzX3ZwY2koZCkgKQ0KPiArICAgICAg
ICByZXR1cm4gMDsNCj4gKw0KPiArICAgIHJlZ2lzdGVyX21taW9faGFuZGxlcihkLCAmdnBjaV9t
bWlvX2hhbmRsZXIsDQo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgIEdVRVNUX1ZQQ0lfRUNB
TV9CQVNFLCBHVUVTVF9WUENJX0VDQU1fU0laRSwgTlVMTCk7DQo+ICsNCj4gKyAgICByZXR1cm4g
MDsNCj4gK30NCj4gKw0KPiArLyoNCj4gKyAqIExvY2FsIHZhcmlhYmxlczoNCj4gKyAqIG1vZGU6
IEMNCj4gKyAqIGMtZmlsZS1zdHlsZTogIkJTRCINCj4gKyAqIGMtYmFzaWMtb2Zmc2V0OiA0DQo+
ICsgKiBpbmRlbnQtdGFicy1tb2RlOiBuaWwNCj4gKyAqIEVuZDoNCj4gKyAqLw0KPiArDQo+IGRp
ZmYgLS1naXQgYS94ZW4vYXJjaC9hcm0vdnBjaS5oIGIveGVuL2FyY2gvYXJtL3ZwY2kuaA0KPiBu
ZXcgZmlsZSBtb2RlIDEwMDY0NA0KPiBpbmRleCAwMDAwMDAwMDAwLi5kOGE3YjBlM2U4DQo+IC0t
LSAvZGV2L251bGwNCj4gKysrIGIveGVuL2FyY2gvYXJtL3ZwY2kuaA0KPiBAQCAtMCwwICsxLDM2
IEBADQo+ICsvKg0KPiArICogeGVuL2FyY2gvYXJtL3ZwY2kuaA0KPiArICoNCj4gKyAqIFRoaXMg
cHJvZ3JhbSBpcyBmcmVlIHNvZnR3YXJlOyB5b3UgY2FuIHJlZGlzdHJpYnV0ZSBpdCBhbmQvb3Ig
bW9kaWZ5DQo+ICsgKiBpdCB1bmRlciB0aGUgdGVybXMgb2YgdGhlIEdOVSBHZW5lcmFsIFB1Ymxp
YyBMaWNlbnNlIGFzIHB1Ymxpc2hlZCBieQ0KPiArICogdGhlIEZyZWUgU29mdHdhcmUgRm91bmRh
dGlvbjsgZWl0aGVyIHZlcnNpb24gMiBvZiB0aGUgTGljZW5zZSwgb3INCj4gKyAqIChhdCB5b3Vy
IG9wdGlvbikgYW55IGxhdGVyIHZlcnNpb24uDQo+ICsgKg0KPiArICogVGhpcyBwcm9ncmFtIGlz
IGRpc3RyaWJ1dGVkIGluIHRoZSBob3BlIHRoYXQgaXQgd2lsbCBiZSB1c2VmdWwsDQo+ICsgKiBi
dXQgV0lUSE9VVCBBTlkgV0FSUkFOVFk7IHdpdGhvdXQgZXZlbiB0aGUgaW1wbGllZCB3YXJyYW50
eSBvZg0KPiArICogTUVSQ0hBTlRBQklMSVRZIG9yIEZJVE5FU1MgRk9SIEEgUEFSVElDVUxBUiBQ
VVJQT1NFLiAgU2VlIHRoZQ0KPiArICogR05VIEdlbmVyYWwgUHVibGljIExpY2Vuc2UgZm9yIG1v
cmUgZGV0YWlscy4NCj4gKyAqLw0KPiArDQo+ICsjaWZuZGVmIF9fQVJDSF9BUk1fVlBDSV9IX18N
Cj4gKyNkZWZpbmUgX19BUkNIX0FSTV9WUENJX0hfXw0KPiArDQo+ICsjaWZkZWYgQ09ORklHX0hB
U19WUENJDQo+ICtpbnQgZG9tYWluX3ZwY2lfaW5pdChzdHJ1Y3QgZG9tYWluICpkKTsNCj4gKyNl
bHNlDQo+ICtzdGF0aWMgaW5saW5lIGludCBkb21haW5fdnBjaV9pbml0KHN0cnVjdCBkb21haW4g
KmQpDQo+ICt7DQo+ICsgICAgcmV0dXJuIDA7DQo+ICt9DQo+ICsjZW5kaWYNCj4gKw0KPiArI2Vu
ZGlmIC8qIF9fQVJDSF9BUk1fVlBDSV9IX18gKi8NCj4gKw0KPiArLyoNCj4gKyAqIExvY2FsIHZh
cmlhYmxlczoNCj4gKyAqIG1vZGU6IEMNCj4gKyAqIGMtZmlsZS1zdHlsZTogIkJTRCINCj4gKyAq
IGMtYmFzaWMtb2Zmc2V0OiA0DQo+ICsgKiBpbmRlbnQtdGFicy1tb2RlOiBuaWwNCj4gKyAqIEVu
ZDoNCj4gKyAqLw0KPiBkaWZmIC0tZ2l0IGEveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvcGNpLmMg
Yi94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC9wY2kuYw0KPiBpbmRleCAzYWE4YzMxNzVmLi4wODI4
OTJjOGEyIDEwMDY0NA0KPiAtLS0gYS94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC9wY2kuYw0KPiAr
KysgYi94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC9wY2kuYw0KPiBAQCAtNzY2LDcgKzc2NiwyMSBA
QCBpbnQgcGNpX2FkZF9kZXZpY2UodTE2IHNlZywgdTggYnVzLCB1OCBkZXZmbiwNCj4gICAgICAg
ICBsaXN0X2FkZCgmcGRldi0+ZG9tYWluX2xpc3QsICZoYXJkd2FyZV9kb21haW4tPnBkZXZfbGlz
dCk7DQo+ICAgICB9DQo+ICAgICBlbHNlDQo+ICsgICAgew0KPiArI2lmZGVmIENPTkZJR19BUk0N
Cj4gKyAgICAgICAgLyoNCj4gKyAgICAgICAgICogT24gQVJNIFBDSSBkZXZpY2VzIGRpc2NvdmVy
eSB3aWxsIGJlIGRvbmUgYnkgRG9tMC4gQWRkIHZwY2kgaGFuZGxlcg0KPiArICAgICAgICAgKiB3
aGVuIERvbTAgaW5mb3JtIFhFTiB0byBhZGQgdGhlIFBDSSBkZXZpY2VzIGluIFhFTi4NCj4gKyAg
ICAgICAgICovDQo+ICsgICAgICAgIHJldCA9IHZwY2lfYWRkX2hhbmRsZXJzKHBkZXYpOw0KPiAr
ICAgICAgICBpZiAoIHJldCApDQo+ICsgICAgICAgIHsNCj4gKyAgICAgICAgICAgIHByaW50ayhY
RU5MT0dfRVJSICJTZXR1cCBvZiB2UENJIGZhaWxlZDogJWRcbiIsIHJldCk7DQo+ICsgICAgICAg
ICAgICBnb3RvIG91dDsNCj4gKyAgICAgICAgfQ0KPiArI2VuZGlmDQo+ICAgICAgICAgaW9tbXVf
ZW5hYmxlX2RldmljZShwZGV2KTsNCj4gKyAgICB9DQo+IA0KPiAgICAgcGNpX2VuYWJsZV9hY3Mo
cGRldik7DQo+IA0KPiBkaWZmIC0tZ2l0IGEveGVuL2RyaXZlcnMvdnBjaS9oZWFkZXIuYyBiL3hl
bi9kcml2ZXJzL3ZwY2kvaGVhZGVyLmMNCj4gaW5kZXggZjhjZDU1ZTdjMC4uNDBmZjc5YzMzZiAx
MDA2NDQNCj4gLS0tIGEveGVuL2RyaXZlcnMvdnBjaS9oZWFkZXIuYw0KPiArKysgYi94ZW4vZHJp
dmVycy92cGNpL2hlYWRlci5jDQo+IEBAIC0zNzMsNyArMzczLDcgQEAgc3RhdGljIHZvaWQgYmFy
X3dyaXRlKGNvbnN0IHN0cnVjdCBwY2lfZGV2ICpwZGV2LCB1bnNpZ25lZCBpbnQgcmVnLA0KPiAg
ICAgICAgIC8qIElmIHRoZSB2YWx1ZSB3cml0dGVuIGlzIHRoZSBjdXJyZW50IG9uZSBhdm9pZCBw
cmludGluZyBhIHdhcm5pbmcuICovDQo+ICAgICAgICAgaWYgKCB2YWwgIT0gKHVpbnQzMl90KShi
YXItPmFkZHIgPj4gKGhpID8gMzIgOiAwKSkgKQ0KPiAgICAgICAgICAgICBncHJpbnRrKFhFTkxP
R19XQVJOSU5HLA0KPiAtICAgICAgICAgICAgICAgICAgICAiJXBwOiBpZ25vcmVkIEJBUiAlbHUg
d3JpdGUgd2l0aCBtZW1vcnkgZGVjb2RpbmcgZW5hYmxlZFxuIiwNCj4gKyAgICAgICAgICAgICAg
ICAgICAgIiVwcDogaWdub3JlZCBCQVIgJXp1IHdyaXRlIHdpdGggbWVtb3J5IGRlY29kaW5nIGVu
YWJsZWRcbiIsDQo+ICAgICAgICAgICAgICAgICAgICAgJnBkZXYtPnNiZGYsIGJhciAtIHBkZXYt
PnZwY2ktPmhlYWRlci5iYXJzICsgaGkpOw0KPiAgICAgICAgIHJldHVybjsNCj4gICAgIH0NCj4g
ZGlmZiAtLWdpdCBhL3hlbi9kcml2ZXJzL3ZwY2kvdnBjaS5jIGIveGVuL2RyaXZlcnMvdnBjaS92
cGNpLmMNCj4gaW5kZXggZWY2OTBmMTVhOS4uZGVjZjdkODdhMSAxMDA2NDQNCj4gLS0tIGEveGVu
L2RyaXZlcnMvdnBjaS92cGNpLmMNCj4gKysrIGIveGVuL2RyaXZlcnMvdnBjaS92cGNpLmMNCj4g
QEAgLTQ4NSw2ICs0ODUsMTIgQEAgYm9vbCB2cGNpX2FjY2Vzc19hbGxvd2VkKHVuc2lnbmVkIGlu
dCByZWcsIHVuc2lnbmVkIGludCBsZW4pDQo+ICAgICBpZiAoIGxlbiAhPSAxICYmIGxlbiAhPSAy
ICYmIGxlbiAhPSA0ICYmIGxlbiAhPSA4ICkNCj4gICAgICAgICByZXR1cm4gZmFsc2U7DQo+IA0K
PiArI2lmbmRlZiBDT05GSUdfNjRCSVQNCj4gKyAgICAvKiBQcmV2ZW50IDY0Yml0IGFjY2Vzc2Vz
IG9uIDMyYml0ICovDQo+ICsgICAgaWYgKCBsZW4gPT0gOCApDQo+ICsgICAgICAgIHJldHVybiBm
YWxzZTsNCj4gKyNlbmRpZg0KPiArDQo+ICAgICAvKiBDaGVjayB0aGF0IGFjY2VzcyBpcyBzaXpl
IGFsaWduZWQuICovDQo+ICAgICBpZiAoIChyZWcgJiAobGVuIC0gMSkpICkNCj4gICAgICAgICBy
ZXR1cm4gZmFsc2U7DQo+IEBAIC01MDAsOCArNTA2LDEwIEBAIGJvb2wgdnBjaV9lY2FtX3dyaXRl
KHBjaV9zYmRmX3Qgc2JkZiwgdW5zaWduZWQgaW50IHJlZywgdW5zaWduZWQgaW50IGxlbiwNCj4g
ICAgICAgICByZXR1cm4gZmFsc2U7DQo+IA0KPiAgICAgdnBjaV93cml0ZShzYmRmLCByZWcsIG1p
big0dSwgbGVuKSwgZGF0YSk7DQo+ICsjaWZkZWYgQ09ORklHXzY0QklUDQo+ICAgICBpZiAoIGxl
biA9PSA4ICkNCj4gICAgICAgICB2cGNpX3dyaXRlKHNiZGYsIHJlZyArIDQsIDQsIGRhdGEgPj4g
MzIpOw0KPiArI2VuZGlmDQo+IA0KPiAgICAgcmV0dXJuIHRydWU7DQo+IH0NCj4gQEAgLTUyNiw4
ICs1MzQsMTAgQEAgYm9vbCB2cGNpX2VjYW1fcmVhZChwY2lfc2JkZl90IHNiZGYsIHVuc2lnbmVk
IGludCByZWcsIHVuc2lnbmVkIGludCBsZW4sDQo+ICAgICAgKiAgNGJ5dGUgYWNjZXNzZXMuDQo+
ICAgICAgKi8NCj4gICAgICpkYXRhID0gdnBjaV9yZWFkKHNiZGYsIHJlZywgbWluKDR1LCBsZW4p
KTsNCj4gKyNpZmRlZiBDT05GSUdfNjRCSVQNCj4gICAgIGlmICggbGVuID09IDggKQ0KPiAgICAg
ICAgICpkYXRhIHw9ICh1aW50NjRfdCl2cGNpX3JlYWQoc2JkZiwgcmVnICsgNCwgNCkgPDwgMzI7
DQo+ICsjZW5kaWYNCj4gDQo+ICAgICByZXR1cm4gdHJ1ZTsNCj4gfQ0KPiBkaWZmIC0tZ2l0IGEv
eGVuL2luY2x1ZGUvYXNtLWFybS9kb21haW4uaCBiL3hlbi9pbmNsdWRlL2FzbS1hcm0vZG9tYWlu
LmgNCj4gaW5kZXggMTRlNTc1Mjg4Zi4uOWIzNjQ3NTg3YSAxMDA2NDQNCj4gLS0tIGEveGVuL2lu
Y2x1ZGUvYXNtLWFybS9kb21haW4uaA0KPiArKysgYi94ZW4vaW5jbHVkZS9hc20tYXJtL2RvbWFp
bi5oDQo+IEBAIC0yNjMsNiArMjYzLDcgQEAgc3RhdGljIGlubGluZSB2b2lkIGFyY2hfdmNwdV9i
bG9jayhzdHJ1Y3QgdmNwdSAqdikge30NCj4gDQo+ICNkZWZpbmUgYXJjaF92bV9hc3Npc3RfdmFs
aWRfbWFzayhkKSAoMVVMIDw8IFZNQVNTVF9UWVBFX3J1bnN0YXRlX3VwZGF0ZV9mbGFnKQ0KPiAN
Cj4gKy8qIHZQQ0kgaXMgbm90IGF2YWlsYWJsZSBvbiBBcm0gKi8NCj4gI2RlZmluZSBoYXNfdnBj
aShkKSAgICAoeyAodm9pZCkoZCk7IGZhbHNlOyB9KQ0KPiANCj4gI2VuZGlmIC8qIF9fQVNNX0RP
TUFJTl9IX18gKi8NCj4gZGlmZiAtLWdpdCBhL3hlbi9pbmNsdWRlL3B1YmxpYy9hcmNoLWFybS5o
IGIveGVuL2luY2x1ZGUvcHVibGljL2FyY2gtYXJtLmgNCj4gaW5kZXggOTZlYWQzZGUwNy4uYjRj
NjE1YmNkZiAxMDA2NDQNCj4gLS0tIGEveGVuL2luY2x1ZGUvcHVibGljL2FyY2gtYXJtLmgNCj4g
KysrIGIveGVuL2luY2x1ZGUvcHVibGljL2FyY2gtYXJtLmgNCj4gQEAgLTQxOCw2ICs0MTgsMTMg
QEAgdHlwZWRlZiB1aW50NjRfdCB4ZW5fY2FsbGJhY2tfdDsNCj4gI2RlZmluZSBHVUVTVF9HSUNW
M19HSUNSMF9CQVNFICAgICB4ZW5fbWtfdWxsb25nKDB4MDMwMjAwMDApIC8qIHZDUFUwLi4xMjcg
Ki8NCj4gI2RlZmluZSBHVUVTVF9HSUNWM19HSUNSMF9TSVpFICAgICB4ZW5fbWtfdWxsb25nKDB4
MDEwMDAwMDApDQo+IA0KPiArLyoNCj4gKyAqIDI1NiBNQiBpcyByZXNlcnZlZCBmb3IgVlBDSSBj
b25maWd1cmF0aW9uIHNwYWNlIGJhc2VkIG9uIGNhbGN1bGF0aW9uDQo+ICsgKiAyNTYgYnVzZXMg
eCAzMiBkZXZpY2VzIHggOCBmdW5jdGlvbnMgeCA0IEtCID0gMjU2IE1CDQo+ICsgKi8NCj4gKyNk
ZWZpbmUgR1VFU1RfVlBDSV9FQ0FNX0JBU0UgICAgeGVuX21rX3VsbG9uZygweDEwMDAwMDAwKQ0K
PiArI2RlZmluZSBHVUVTVF9WUENJX0VDQU1fU0laRSAgICB4ZW5fbWtfdWxsb25nKDB4MTAwMDAw
MDApDQo+ICsNCj4gLyogQUNQSSB0YWJsZXMgcGh5c2ljYWwgYWRkcmVzcyAqLw0KPiAjZGVmaW5l
IEdVRVNUX0FDUElfQkFTRSB4ZW5fbWtfdWxsb25nKDB4MjAwMDAwMDApDQo+ICNkZWZpbmUgR1VF
U1RfQUNQSV9TSVpFIHhlbl9ta191bGxvbmcoMHgwMjAwMDAwMCkNCj4gZGlmZiAtLWdpdCBhL3hl
bi9pbmNsdWRlL3hlbi9wY2kuaCBiL3hlbi9pbmNsdWRlL3hlbi9wY2kuaA0KPiBpbmRleCA3MGFj
MjUzNDVjLi5iNmQ3ZTQ1NGY4IDEwMDY0NA0KPiAtLS0gYS94ZW4vaW5jbHVkZS94ZW4vcGNpLmgN
Cj4gKysrIGIveGVuL2luY2x1ZGUveGVuL3BjaS5oDQo+IEBAIC00MCw2ICs0MCw4IEBADQo+ICNk
ZWZpbmUgUENJX1NCREYzKHMsYixkZikgXA0KPiAgICAgKChwY2lfc2JkZl90KXsgLnNiZGYgPSAo
KChzKSAmIDB4ZmZmZikgPDwgMTYpIHwgUENJX0JERjIoYiwgZGYpIH0pDQo+IA0KPiArI2RlZmlu
ZSBFQ0FNX1JFR19PRkZTRVQoYWRkcikgICgoYWRkcikgJiAweDAwMDAwZmZmKQ0KPiArDQo+IHR5
cGVkZWYgdW5pb24gew0KPiAgICAgdWludDMyX3Qgc2JkZjsNCj4gICAgIHN0cnVjdCB7DQo+IC0t
IA0KPiAyLjI1LjENCj4gDQo+IA0KDQo=


From xen-devel-bounces@lists.xenproject.org Fri Oct 15 15:52:56 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 15:52:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.210880.367897 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbPVs-0004fE-L8; Fri, 15 Oct 2021 15:52:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 210880.367897; Fri, 15 Oct 2021 15:52:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbPVs-0004f7-IG; Fri, 15 Oct 2021 15:52:52 +0000
Received: by outflank-mailman (input) for mailman id 210880;
 Fri, 15 Oct 2021 15:52:51 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=gHjW=PD=citrix.com=anthony.perard@srs-us1.protection.inumbo.net>)
 id 1mbPVr-0004ei-60
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 15:52:51 +0000
Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id f2aedc8c-2dcf-11ec-8242-12813bfff9fa;
 Fri, 15 Oct 2021 15:52:50 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f2aedc8c-2dcf-11ec-8242-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1634313169;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=EeW4nmmfQRhj015lGTsy7R+7su82zonfsO75WL+R+xw=;
  b=VB1x2vl1qApSnMHd0dnwcDC0/CTgMMsIlxU62oa+FyrMCeBPh7MBmT/y
   1RHjBF+Jy84hsYuidnuPOSfycRvGyzVfOWlK6nluCudFS1iFFCsj0lpQT
   WwyuIj5GoU35/OlhtJQ7MODHRoP6rJcRg/GfU7nWLCWX7vfoasOCOPtCO
   g=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: 9wSG6DeTtrRWE93BilFM3/f7OUrZ44CGFHP6/KBbPTN5ZQ2Lu/L3hRBbHZinZDfJR0OFdhs5Ug
 Sk/yAUpWwKQjj+TIRmEkb4sEmi+7oCAlSLQnZCJt70D0tedFMMPsdZW75gZbih5JbB4j2YTFxD
 UOyGeXx+rYYW6tqbvAtV03HkLWZBKaLBniQCQ23gT27icQ1T1pTUx33CL/ogqR6+QEby7GJi0p
 CWG+Ur27gAweBgFjL4MXoNiptvkEBq4zAEL5ZvQXGPIohjlFsCqP20uodhfdgqQIH0tdTExDoK
 DTOr+EiJ7U9sTxIo+ia4hEXp
X-SBRS: 5.1
X-MesageID: 55288032
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:U0gbtqkkPpKq2FG4fYjPXTzo5gxIIURdPkR7XQ2eYbSJt1+Wr1Gzt
 xIYXW6BO/zYMTP0foxwbNi09hsGsZPWz9FgSQds/CE9QSMWpZLJC+rCIxarNUt+DCFioGGLT
 Sk6QoOdRCzhZiaE/n9BClVlxJVF/fngqoDUUYYoAQgsA185IMsdoUg7wbdg2tc12YLR7z6l4
 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc
 s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4
 N9iiZaJUQ5wBPCWqO4WaiJCFRB7A7ITrdcrIVDn2SCS50jPcn+qyPRyFkAme4Yf/46bA0kXq
 6ZecmpUKEne2aTmm9pXScE17ignBMDtIIMYvGAm1TzDBOwqaZvCX7/L9ZlT2zJYasVmQKuEN
 5pBMmAHgBLoaDFCFU41V5kFmMDzvVXnaTNkil6Mqv9ii4TU5FMoi+W8WDbPQfSaSMMQkkuGq
 2bu+2XiHgpcJNGZ0SCC8H+nmqnIhyyTcJ0WPK218LhtmlL77m4ZBQASVFC7ieKkkUP4UNVaQ
 3H44QJ38/J0rhbyCICgAVvo+xZooyLwRfJaPNEw0RmEk5CJuTaTDVE/VDhwbeI54ZpeqSMR6
 neFmNbgBDpKubKTSG6A+rr8kQ5eKRT5PkdZOndaFVptD83L5dhp1EqWH4kL/Lud14WtQVnNL
 ya2QD/Sbln5pfUA0Lmn5hj5ijaoq4mhouUdt1iPADzNAu+UYueYi22UBbrzsakowGWxFADpU
 J04dy62t71m4Xalzn3lfQn1NOv1j8tpyRWF6bKVI7Ev9i6251modp1K7Td1KS9Ba5hfJWWyO
 hSO4FMLuve/2UdGi4csPupd7OxxlcDd+SnNDKiIPrKinLAgHON4wM2eTRHJhD28+KTduao+J
 Y2aYa6R4YUyUsxaIM6Nb75Fi9cDn3lmrUuKHMyT50n3gNK2OS/OIZ9YYQTmUwzMxP7dyOkj2
 40EbJXiJtQ2eLCWXxQ7BqZIcw1UdyFgW82vwyGVH8baSjdb9KgaI6e56dscl0ZNxcy5T8/Eo
 SOwXFF20l36iSGVIAmGcCk7OrjuQYx+vTQwOil1ZQSk3H0qYICO6qYDdsRoIel7pbI7lfMkH
 eMYf8igA+hUTmiV8ToqcpSg/pdpcw6mhFzSMnP9MiQ/ZZNpWyfA5sTgIln07CALAyfu7Zk+r
 rSs2xn1W50GQwg+Xs/aZOj2lwG6vGQHmfI0VEzNe4EBdELp+YlsCirwkv5ofJ1cdUSdnmOXj
 l/EDw0ZqO/Bp54O3OPI3a3U/Z20F+ZeH1ZBGzWJ57iBKiSHrHGoxpVNUbjUcGmFBn/04qire
 c5c0+r4bK8chF9PvodxT+RrwKY564e9rrNW1F05TnDCblDtAbJ8OHiWm8JIs/QVlLNevAK3X
 GOJ+8VbZurVaJ+0TgZJKVp3dPmH2NEVhiLWvKY8L0jN7SNq+KaKDBdJNB6WhS0BdLZ4PevJG
 wv6VBL6P+BnticXDw==
IronPort-HdrOrdr: A9a23:igywQqAlaYp7HAjlHems55DYdb4zR+YMi2TC1yhKJyC9Vvbo8/
 xG/c5rsCMc5wx9ZJhNo7y90ey7MBThHP1OkOss1NWZPDUO0VHAROoJ0WKh+UyCJ8SXzJ866U
 4KSclD4bPLYmRHsQ==
X-IronPort-AV: E=Sophos;i="5.85,376,1624334400"; 
   d="scan'208";a="55288032"
Date: Fri, 15 Oct 2021 16:52:30 +0100
From: Anthony PERARD <anthony.perard@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Roger Pau
 =?iso-8859-1?Q?Monn=E9?= <roger.pau@citrix.com>, Wei Liu <wl@xen.org>,
	<xen-devel@lists.xenproject.org>
Subject: Re: [XEN PATCH v7 41/51] build,x86: remove the need for build32.mk
Message-ID: <YWmjvqyIyCP6IXmh@perard>
References: <20210824105038.1257926-1-anthony.perard@citrix.com>
 <20210824105038.1257926-42-anthony.perard@citrix.com>
 <c99f2bc5-b1dc-7647-4199-a6a731730967@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <c99f2bc5-b1dc-7647-4199-a6a731730967@suse.com>

On Thu, Oct 14, 2021 at 10:32:05AM +0200, Jan Beulich wrote:
> On 24.08.2021 12:50, Anthony PERARD wrote:
> > --- a/xen/arch/x86/boot/Makefile
> > +++ b/xen/arch/x86/boot/Makefile
> > @@ -1,23 +1,51 @@
> >  obj-bin-y += head.o
> > +head-objs := cmdline.S reloc.S
> >  
> > -DEFS_H_DEPS = $(BASEDIR)/$(src)/defs.h $(BASEDIR)/include/xen/stdbool.h
> > +nocov-y += $(head-objs:.S=.o)
> > +noubsan-y += $(head-objs:.S=.o)
> > +targets += $(head-objs:.S=.o)
> 
> This working right depends on targets initially getting set with := ,
> because of ...

They are because Rules.mk initialise those variables that way.

> > -CMDLINE_DEPS = $(DEFS_H_DEPS) $(BASEDIR)/$(src)/video.h \
> > -	       $(BASEDIR)/include/xen/kconfig.h \
> > -	       $(BASEDIR)/include/generated/autoconf.h
> > +head-objs := $(addprefix $(obj)/, $(head-objs))
> 
> ... this subsequent adjustment to the variable. Might it be more future
> proof for start with
> 
> head-srcs := cmdline.S reloc.S
> 
> and then derive head-objs only here?

I'll give it a try.

> > -RELOC_DEPS = $(DEFS_H_DEPS) \
> > -	     $(BASEDIR)/include/generated/autoconf.h \
> > -	     $(BASEDIR)/include/xen/kconfig.h \
> > -	     $(BASEDIR)/include/xen/multiboot.h \
> > -	     $(BASEDIR)/include/xen/multiboot2.h \
> > -	     $(BASEDIR)/include/xen/const.h \
> > -	     $(BASEDIR)/include/public/arch-x86/hvm/start_info.h
> > +$(obj)/head.o: $(head-objs)
> >  
> > -$(obj)/head.o: $(obj)/cmdline.S $(obj)/reloc.S
> > +LDFLAGS_DIRECT_OpenBSD = _obsd
> > +LDFLAGS_DIRECT_FreeBSD = _fbsd
> 
> This is somewhat ugly - it means needing to change things in two places
> when config/x86_32.mk would change (e.g. to add another build OS). How
> about ...
> 
> > +$(head-objs:.S=.lnk): LDFLAGS_DIRECT := -melf_i386$(LDFLAGS_DIRECT_$(XEN_OS))
> 
> ... instead:
> 
> $(head-objs:.S=.lnk): LDFLAGS_DIRECT := $(subst x86_64,i386,$(LDFLAGS_DIRECT))
> 
> ? Or if deemed still too broad
> 
> $(head-objs:.S=.lnk): LDFLAGS_DIRECT := $(subst elf_x86_64,elf_i386,$(LDFLAGS_DIRECT))
> 
> ?

Sounds good, I'll do that.

> > -$(obj)/cmdline.S: $(src)/cmdline.c $(CMDLINE_DEPS) $(src)/build32.lds
> > -	$(MAKE) -f $(BASEDIR)/$(src)/build32.mk -C $(obj) $(@F) CMDLINE_DEPS="$(CMDLINE_DEPS)"
> > +CFLAGS_x86_32 := -m32 -march=i686
> > +CFLAGS_x86_32 += -fno-strict-aliasing
> > +CFLAGS_x86_32 += -std=gnu99
> > +CFLAGS_x86_32 += -Wall -Wstrict-prototypes
> > +$(call cc-option-add,CFLAGS_x86_32,CC,-Wdeclaration-after-statement)
> > +$(call cc-option-add,CFLAGS_x86_32,CC,-Wno-unused-but-set-variable)
> > +$(call cc-option-add,CFLAGS_x86_32,CC,-Wno-unused-local-typedefs)
> > +$(call cc-options-add,CFLAGS_x86_32,CC,$(EMBEDDED_EXTRA_CFLAGS))
> > +CFLAGS_x86_32 += -Werror -fno-builtin -g0 -msoft-float
> > +CFLAGS_x86_32 += -I$(srctree)/include
> 
> I'm afraid I'm not convinced that having to keep this in sync with the
> original is in fair balance with the removal of build32.mk.

Why would this needs to be kept in sync with the original? I would
actually like to get rid of Config.mk, I don't see the point in sharing
CFLAGS between a kernel and userspace binaries. Also, I hope one day
that we can have the hypervisor in its own repo, and thus they won't be
any Config.mk to keep in sync with.

The goal of this patch is less about removing build32.mk, and more about
using the rest of the build system infrastructure to build those few
32bits objects, and been able to use the automatic dependencies
generation and other things without having to duplicate them.

It probably make the build a bit faster as there is two less invocation
of $(MAKE) (which parse Config.mk).

As for a possible change: instead of having those x86_32 flags in
arch/x86/boot/, I could have them in arch/x86/arch.mk. Linux does
something like that were it prepare REALMODE_CFLAGS.

I know it's a bit annoying to have another list x86_32 cflags, but I
don't see how we can extract them from Config.mk (in a Makefile where we
want to use both x86_32 and x86_64 flags).

Thanks,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Fri Oct 15 16:30:25 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 16:30:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.210891.367909 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbQ61-0000oQ-HB; Fri, 15 Oct 2021 16:30:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 210891.367909; Fri, 15 Oct 2021 16:30:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbQ61-0000oJ-Dv; Fri, 15 Oct 2021 16:30:13 +0000
Received: by outflank-mailman (input) for mailman id 210891;
 Fri, 15 Oct 2021 16:30:12 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=gHjW=PD=citrix.com=anthony.perard@srs-us1.protection.inumbo.net>)
 id 1mbQ60-0000oD-5U
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 16:30:12 +0000
Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 8eb0273a-94c9-4b42-8284-1a586b747e45;
 Fri, 15 Oct 2021 16:30:11 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8eb0273a-94c9-4b42-8284-1a586b747e45
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1634315411;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=UGSDXXQE4WBg3zOQ11gfgUZFblK5mM4fhPPFUp02v/o=;
  b=Iu7NUf5fNTVTSa5SXzzfy3BlLcnYZegpJsRFxBzUb7T6fNBa3AmV1ERs
   WU1gmCQG8lIEr53z8WR3jDMfPJKMh30kwFG/rGm84nLVXC7O9ERnucFr7
   Ne6u4cnd3ZorZ852/CrzFkKq2eHzQHQIunW8W4FV+88MwxpUBn/RmU15Z
   8=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: PjFuDB8HcK49fvC+aa6iaXLinSJyBB530Fv39ALzOtaxxyaSCJwGlePfXTnC1tAIEWAR6+RGK4
 McXgJUM8Z/o03f/DFqUgsMbfWIGPq2ivAqKKmoaHIIBUgRWBYyvnSKkTvardOlBtw759y9G0Aq
 IQb7zSVzwqZot6PiQ0qvgN73+rFDKTEm+Ahn77d7dlBfpWnmfwSQtRa/QabsJujZY4ACdTNET6
 GEQsHQQa0GtiKVXG9c3sf6e8ypNUjBsSeQR62nKNJPkyZAVjvGTrdpmTsqfruWLcyAZaaxNBi+
 qJ34IQoe9BTIntABKqJcaI45
X-SBRS: 5.1
X-MesageID: 55334737
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:JjlNWa2QdP4PG/7XePbD5XJ2kn2cJEfYwER7XKvMYLTBsI5bpzQCm
 GscXW/QOaveY2KnfdhzPImz/U8BscLWmNdlQAJlpC1hF35El5HIVI+TRqvS04J+DSFhoGZPt
 Zh2hgzodZhsJpPkS5PE3oHJ9RGQ74nRLlbHILOCan0ZqTNMEn970Es7wrNh2OaEvPDia++zk
 YKqyyHgEAfNNw5cagr4PIra9XuDFNyr0N8plgRWicJj5TcypFFMZH4rHomjLmOQf2VhNrXSq
 9Avbl2O1jixEx8FUrtJm1tgG6EAaua60QOm0hK6V0U+6/TrS+NbPqsTbZIhhUlrZzqhoOpj7
 /Rii7GMeA41OOqLvKcvDDxKHHQrVUFG0OevzXmXtMWSywvNcmf2wuUoB0YzVWEa0r8pWycUr
 6VecW1TKEDY7w616OvTpu1Ej8I/LM7tLcUHt2tp1z3xBvc6W5HTBa7N4Le02R9t25sVQamFO
 KL1bxJ1NA/sf0V1GGsdGYxnu+qkp0Hyc35x/Qf9Sa0fvDGIkV0ZPKLWGMXRUsyHQ4NShEnwj
 lzB+2P1ExQLLuu1wDCO8m+vruLXlCa9U4UXfJWo+/gvjFCNy2g7DBwNSUD9sfS/klS5Wd9UN
 woT4CVGhbMp6EWhQ935Xhu5iH2JpBgRX5xXCeJSwAOHx7fQ4g2ZLnMZVTMHY9sj3Oc3Wj4Cx
 lKPh8nuBzFkrPuSU3313rWJqTK/PwAFIGlEYjULJTbp+PG6/tt11EiWCI8+Tujl1bUZBA0c3
 Ri1ljoZppotoPI63rm9uhfjwADzg4rGG1tdChrsYkqp6QZwZYiAboOu6ETG4fsoELt1XmVtr
 1BfxJDAtLFm4YWl0XXXGr1UTe7BC+OtaWWE2TZS848dGyNBEpJJVbtb5y1iPw9XO8IAdC6Bj
 KT76F4JusE70JdHa8ZKj2ON5yYCkfeI+TfNDKm8gj9yjn5ZL1LvEMZGPx/44owVuBJw+ZzTw
 L/CGSpWMV4UCL580B29TPoH3Lkgy0gWnD2IGcqglU/6iOrEOhZ5rIvp1nPVM4jVC4vf+G3oH
 yt3bZPWm32zrsWvCsUozWLjBQ9TdiVqbXwHg8dWavSCMmJb9JIJUJfsLUcaU9U9xcx9z76Ql
 lnkAxMw4Aev1BXvdFTRAlg+OeyHYHqKhS9iVcDaFQ3zgCZLjEfGxPp3SqbbipF8qrE9l6cvE
 aRcEyhCa9wWIgn6F/0mRcGVhORfmN6D2Wpi5gKpP2oyeYBOXQvM9oO2dwfj7nBWXCG2qdE/s
 /ur0QaCGcgPQAFrDcD3bvOzzgzu4ShBybwqB0aYcMNOfEjM8ZRxL3CjhPEAPMxRew7IwSGX1
 ljKDE5A9/XNuYI87PLAmbuA89WyC+J7E0cDRzvb4L+6ODP05G2mxYMcAu+EcSqEDDH/+bm4Z
 PUTxPb5aaVVkFFPuot6MrBq0aNhuIe/++4EllxpRSyZYU6qB7VsJmi98fNO7qAdlKVEvQaWW
 16U/oUIM7u+J864QkUaIxAob7rf2KhMyCXS9/k8PG7z+DRzoOicSUxXMhSB1H5dIb9yPN93y
 OstopdLuQm2ix5sOdealCFEsW+LKyVYAakgs5gbBq7tixYqlQ4eMcCNVHeu7cHdcchIP2krP
 iSQ1fjLiLlrz0bfd2Y+SCrW1u1HiJVS4B1HwTfu/bhSdgYpUhPv4CBszA==
IronPort-HdrOrdr: A9a23:YXQvPahUmyzUooo6TBZ6jOctg3BQXtoji2hC6mlwRA09TySZ//
 rBoB0+726RtN9xYgBEpTnuAsS9qB/nmaKdpLNhWotKPzOW2ldATrsD0WKK+VSJcEfDH6xmpM
 RdmsBFebvN5DNB7PoSjjPWL+od
X-IronPort-AV: E=Sophos;i="5.85,376,1624334400"; 
   d="scan'208";a="55334737"
Date: Fri, 15 Oct 2021 17:29:47 +0100
From: Anthony PERARD <anthony.perard@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, George Dunlap
	<george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>, Julien Grall
	<julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>, Wei Liu
	<wl@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, Roger Pau
 =?iso-8859-1?Q?Monn=E9?= <roger.pau@citrix.com>,
	<xen-devel@lists.xenproject.org>
Subject: Re: [XEN PATCH v7 42/51] build: grab common EFI source files in arch
 specific dir
Message-ID: <YWmse5Sv2SFyRMdj@perard>
References: <20210824105038.1257926-1-anthony.perard@citrix.com>
 <20210824105038.1257926-43-anthony.perard@citrix.com>
 <43684fcc-f6ca-86f2-9fb1-d3d5d9dbc20d@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <43684fcc-f6ca-86f2-9fb1-d3d5d9dbc20d@suse.com>

On Thu, Oct 14, 2021 at 10:51:44AM +0200, Jan Beulich wrote:
> On 24.08.2021 12:50, Anthony PERARD wrote:
> > --- a/xen/arch/arm/efi/Makefile
> > +++ b/xen/arch/arm/efi/Makefile
> > @@ -1,4 +1,10 @@
> >  CFLAGS-y += -fshort-wchar
> > +CFLAGS-y += -I$(srctree)/common/efi
> 
> Perhaps another opportunity for -iquote?

Yes.

> >  obj-y += boot.init.o pe.init.o ebmalloc.o runtime.o
> >  obj-$(CONFIG_ACPI) +=  efi-dom0.init.o
> > +
> > +$(obj)/%.c: common/efi/%.c
> > +	$(Q)cp -f $< $@
> 
> In case both trees are on the same file system, trying to hardlink first
> would seem desirable. When copying, I think you should also pass -p.

I don't know if doing an hardlink is a good thing to do, I'm not sure of
the kind of issue this could bring. As for -p, I don't think it's a good
idea to copy the mode, ownership, and timestamps of the source file, I'd
rather have the timestamps that Make expect, e.i. "now".

> > --- a/xen/arch/x86/efi/Makefile
> > +++ b/xen/arch/x86/efi/Makefile
> > @@ -1,4 +1,5 @@
> >  CFLAGS-y += -fshort-wchar
> > +CFLAGS-y += -I$(srctree)/common/efi
> >  
> >  quiet_cmd_objcopy_o_ihex = OBJCOPY $@
> >  cmd_objcopy_o_ihex = $(OBJCOPY) -I ihex -O binary $< $@
> > @@ -19,3 +20,8 @@ obj-$(XEN_BUILD_EFI) := $(filter-out %.init.o,$(EFIOBJ-y))
> >  obj-bin-$(XEN_BUILD_EFI) := $(filter %.init.o,$(EFIOBJ-y))
> >  extra-$(XEN_BUILD_EFI) += buildid.o relocs-dummy.o
> >  nocov-$(XEN_BUILD_EFI) += stub.o
> > +
> > +$(obj)/%.c: common/efi/%.c
> > +	$(Q)cp -f $< $@
> > +
> > +.PRECIOUS: $(obj)/%.c
> 
> Seeing you repeat everything here, despite it not being all this much I
> wonder if there wouldn't better be a makefile fragment in common/efi/
> which all interested architectures' arch/<arch>/efi/Makefile would then
> include. This could then also subsume -fshort-wchar.

That sounds good, I'll look into that.

Thanks,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Fri Oct 15 16:35:05 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 16:35:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.210898.367919 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbQAj-0001RK-38; Fri, 15 Oct 2021 16:35:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 210898.367919; Fri, 15 Oct 2021 16:35:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbQAj-0001RD-09; Fri, 15 Oct 2021 16:35:05 +0000
Received: by outflank-mailman (input) for mailman id 210898;
 Fri, 15 Oct 2021 16:35:03 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=gHjW=PD=citrix.com=anthony.perard@srs-us1.protection.inumbo.net>)
 id 1mbQAh-0001R7-0W
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 16:35:03 +0000
Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id e50782c0-ca76-4f93-a9cc-c373648bc745;
 Fri, 15 Oct 2021 16:35:02 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e50782c0-ca76-4f93-a9cc-c373648bc745
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1634315702;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=IZiw5vPjhEM2fua8cVYdPOJhCw6NFmvBcfSCThV3mtE=;
  b=beqyZoVNsYl+jDkoTmMfey7wqd4VbsjA7iMH/cIiC7mAfpAZ08oDIv0N
   9dR7YuvnRYZ1PoubX8QBhnYHWE7LNvIimCBWa9dMimPlI5sWPDj1X1hXU
   AVb/iVLncPTB46xyaFOwYN/oZizUvW3g4lvgQz7aCkvMX84q0VZ3tJg/T
   s=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: tcQGgFACdWKt2FUBOCxs0CLU0oKHmJjlAddCkbrzh9kocRfAIVPFVwjkplxYeLTvYn57E48I3R
 Katd0vEdV6DnLxUfr+CVhR/Kv94w46zgVnH4Z0zRkUwJ6lYfy+OVynmjHvQ+7IsI5JVHl8sc64
 C53Ibz7gPTqq5e29cbmBfAt1IQEIoE/37RsHR0K+CCwpeSzp9juWWCqN+u2RbHz4z1bOZE2dXe
 g88JHGbjIRziLx0EMnIc+4k+T1O1LZ93tnJnZLwnmcgr1aeLjSrMj2fCa8G2SdvLCt6448IBwk
 nje9F8y0Nz70xkHdQESy9Z5a
X-SBRS: 5.1
X-MesageID: 54868458
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:BnPcy69rH+yR/xb//q56DrUDFHmTJUtcMsCJ2f8bNWPcYEJGY0x3x
 jQaXmmGbv6OZzP0f9l2bIu/oBxSv5eAzdRiSApsq3w8E34SpcT7XtnIdU2Y0wF+jyHgoOCLy
 +1EN7Es+ehtFie0Si9AttENlFEkvU2ybuOU5NXsZ2YhGGeIdA970Ug6wrZg39Yy6TSEK1jlV
 e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH
 I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPh81
 Mhj6rupETskZLKdh/Y3cygHLQZxaPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us
 6ZCcXZUM07F17neLLGTE4GAguwqKtXrO4UO/Glt1zjDAd4tQIzZQrWM7thdtNs1rp0STaiOO
 5dJAdZpRBviOhliM3ATMpY3k/2twX76I2JqjWvA8MLb5ECMlVcsgdABKuH9eMGORMhTtlaVo
 CTB5WuRKg4eHMySz3yC6H3Erv/Cm2b3VZwfEJW89+V2mxuDy2oLEhoUWFCn5/6jhSaWWdhSN
 kgV8SoGtrUp+QqgSdyVdwajvHeOsxoYWtxRO+438geAzuzT+QnxLmkbTBZRZdo+rsg0SDc2k
 FiTkLvU6SdH6ePPDyjHr/HN8G30aXN9wXI+iTEsQBcYzYbEudkPg0jQH8lxOo6E0ePSFmSlq
 9yVlxQWi7IWhM8N8qy0+1Hbnj6hzqT0oh4JChb/BT39sFsoDGKxT8nxswKDtKcfRGqMZgDZ5
 CBspiSI0AwZ4XhhfgS2S+IRAKrh2f+BNDDN6bKEN8h8r2rzk5JPkIY53d2fGKuLGppbEdMKS
 BWK0e+02HO1FCD3BUOQS9jgY/nGNYC6SbzYugroRtRPeINtUwSM4TtjY0Wdt0i0zhNwy/plY
 srCIZzyZZr/NUiB5GHrLwv6+eRzrh3SOEuJHcyrp/hZ+ev2iIGppUctbwLVM7FRAFKsqwTJ6
 ddPX/ZmOD0EONASlhL/qNZJRXhTdCBTLcmv96R/K77SSiI7STpJI6KAntscl3lNwv09vv3W5
 Uu0RkIw4AO53RUr3y3RMSs9AF4uNL4ixU8G0dsEZgj1hSJ6Otjytc/ytfIfJNEayQCq9tYsJ
 9FtRilKKqknpu3v92tPYJ/jgpZlcRj31wuCMzD8OGo0foJ6RhyP8djhJ1O9+C4LByuxlM0/v
 7z/iV+LHctdH1xvXJTMdfai71KtpnxByuh8aFTFf4tIc0L2/Yk0dyGo1q0rI9sBIAnozyeB0
 1rEGg8RoOTA+tdn8NTAia2egZ2uFu9yQhhTE2XBtO7kPijG5Guzh4RHVb/QLzzaUWr1/oSkZ
 PlUkK6gYKFWwg4SvtMlQbhxzK8469/+nJNgz1xpTCfRclCmKrJ8OX3aj8NBgbJAm+1CsgysV
 0PRptQDYeeVONnoGUI6LRY+arjRzukdnzTf4KhnIEj+4yMrrrOLXV8LYkuJgS1ZarB0LJkk0
 aEqv8tPs16zjR8jM9CniCFI9jvTcixcAvt/7pxKUpX2jgcLy01ZZc2OAyD715iDdtFQPxR4O
 TSTnqfD2+xRy0eqn6DfzpQRMT6xXagzhS0=
IronPort-HdrOrdr: A9a23:4YnJn61BrOuiN9i4ofIDbAqjBLIkLtp133Aq2lEZdPRUGvb3qy
 mLpoV+6faUskd1ZJhOo7290cW7LU80sKQFhrX5Xo3SPjUO2lHJEGgK1+KLqFfd8m/Fh41gPM
 9bAs5D4bbLbGSS4/yU3DWF
X-IronPort-AV: E=Sophos;i="5.85,376,1624334400"; 
   d="scan'208";a="54868458"
Date: Fri, 15 Oct 2021 17:34:37 +0100
From: Anthony PERARD <anthony.perard@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Stefano Stabellini <sstabellini@kernel.org>, Andrew Cooper
	<andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>, "Ian
 Jackson" <iwj@xenproject.org>, Julien Grall <julien@xen.org>, Wei Liu
	<wl@xen.org>, <xen-devel@lists.xenproject.org>
Subject: Re: [XEN PATCH v7 45/51] build: rework cloc recipe
Message-ID: <YWmtnUmxHYqlmm43@perard>
References: <20210824105038.1257926-1-anthony.perard@citrix.com>
 <20210824105038.1257926-46-anthony.perard@citrix.com>
 <be6b4b2d-2b18-820b-43ba-e8e800d97517@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <be6b4b2d-2b18-820b-43ba-e8e800d97517@suse.com>

On Thu, Oct 14, 2021 at 11:33:16AM +0200, Jan Beulich wrote:
> On 24.08.2021 12:50, Anthony PERARD wrote:
> > After folowing patches, the recipe doesn't work anymore.
> >     - build: build everything from the root dir, use obj=$subdir
> >     - build: introduce if_changed_deps
> 
> That was some 20 patches ago - shouldn't all make goals continue to
> work at every step?

That would be better yes, I'll look at bringing this patch earlier,
which would probably mean making changes to the rule several more time.

> > First patch mean that $(names) already have $(path), and the second
> > one, the .*.d files are replaced by .*.cmd files which are much
> > simpler to parse here.
> > 
> > Also replace the makefile programming by a much simpler shell command.
> > 
> > This doesn't check anymore if the source file exist, but that can be
> > fixed by running `make clean`, and probably doesn't impact the
> > calculation. `cloc` just complain that some files don't exist.
> 
> Not sure whether that's acceptable - Stefano, iirc it was you who
> introduced this goal.
> 
> Jan
> 

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Fri Oct 15 16:40:21 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 16:40:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.210906.367931 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbQFl-0002rX-NB; Fri, 15 Oct 2021 16:40:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 210906.367931; Fri, 15 Oct 2021 16:40:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbQFl-0002rQ-KE; Fri, 15 Oct 2021 16:40:17 +0000
Received: by outflank-mailman (input) for mailman id 210906;
 Fri, 15 Oct 2021 16:40:16 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=gHjW=PD=citrix.com=anthony.perard@srs-us1.protection.inumbo.net>)
 id 1mbQFk-0002rK-H5
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 16:40:16 +0000
Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id ec234d89-e7e0-48f2-a531-038a75bd7c66;
 Fri, 15 Oct 2021 16:40:15 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ec234d89-e7e0-48f2-a531-038a75bd7c66
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1634316015;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=7EuQzF1NmHI5sC5AWUR4MvnHSVxNTDge7GmFe8zrq/Y=;
  b=PZGFo2wcDv95n9GjSRgwozct06AUmuFF42Pcq5VNyib7/qBq6AbJE8+d
   Ma/a1/r9lgfRxhnTHpSXpZpEGk3VCjZoBllO7NjjRbWrGkdl6oZfA9Csm
   04YIC7Yn3kSOWduO/8oxxnEpzyEXUlM2Ib0on6NQEaKCB/LBAij4LlK53
   o=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: 2HOaOchfJ5rM1R9ndb9Gv9yjZHXxL2MSWDlL8X+mv7o0dLtWnZBYJI4Fau1QBanBE0cooSk4ML
 gF5sikEbBeRZU5n9z5o8QJimU5ml1sydAch2JIodzk1hRFQGfgX+NkVwUooRG016xQ3SQcBNYD
 4MZvEnZ8kwua8evGndFpYIxXfbMNnUgUuM8bbLqm0iDAjL7KsmgKCFIiV8jegPgngKQMcTIxEh
 trE6F9g14Nx2+8dT4Vg+Pe/xA1tv/6P+Yaz1Hm0ENhUdC5ZjOo5u4MUHpW+QIDKV+pu4b30K1P
 Y9kO6p1p+B2LN2nGKa0zCnL3
X-SBRS: 5.1
X-MesageID: 55336042
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:VCDINaAEm+GtbBVW/13lw5YqxClBgxIJ4kV8jS/XYbTApG4n0jZWx
 2ZJXDqGP/6IZWKge991boq+pEpSscKGzdVgQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA
 xA2M4GYRCwMo/u1Si6FatANl1ElvU2zbue6WLOs1hxZH1c+EX550E87wYbVv6Yz6TSHK1LV0
 T/Ni5W31G+Ng1aY5UpNtspvADs21BjDkGtwUm4WPJinj3eH/5UhN7oNJLnZEpfNatI88thW5
 Qr05OrREmvxp3/BAz4++1rxWhVirrX6ZWBihpfKMkQLb9crSiEai84G2PQghUh/2x+Qx4phy
 sd36aOVcQIXJqPmxMBeakwNe81+FfUuFL7vJHG+tYqYzlHccmuqyPJrZK00FdRGoKAtWzgIr
 KFGbmBWBvyAr7veLLaTQ+9whsMlPY/zMZkWoH1IxjDFF/c2B5vERs0m4PcFgWxr2JgSR54yY
 eIHMWMoMwjHUiZAHUU8WLNi37aag1DWJmgwRFW9+vNsvjm7IBZK+LvqNsDcdpqVRMFWtkGCr
 2nC8iLyBRRyHOKYzT2J43e9nNjllCnwWJ8RPLCg//ssi1qWrkQfBxEbWkGyieWogU65HdREI
 gob/TRGhbg/8gmnQ8fwWzW8oWWYpVgMVtxICeo45QqRjK3O7G6xCnAfSz9daPQvrMIsWSExz
 ViNgs/oAjp09raSTBq196iWhSO/PzAPKm0PbjNCShEKi/HhqowuihPETv54DbW4yNbyHFnYw
 S2OrSU4r6Uei4gMzarT1U/DqyKhoN7OVAFdzh7MQmuv4wd9ZYikT4+l817W6bBHNonxc7Wal
 CFawY7EtrlIVMzT0nzWKAkQIF23z6avKWWGkVx9JcUe0gyoxWatV9x0owgrcS+FLf04UTPuZ
 UbSvyZY65lSIGamYMdLXm6hNyg55fO/TYq9B5g4evILO8IrLFbWo0mCcGbJhzi1+HXAh53TL
 ntynSyENn0dFbh8hAS/Q+MQwNfHLQhvmDuNG/gXI/mhuIdyhUJ5q59ZbzNijchjtctoRTk5F
 f4EaqNmLD0FAYXDjtH/q9J7ELzzBSFT6WrKg8JWbPWfBQFtBXssDfTcqZt4Jdc5xf8PzbqRr
 ivjMqO99LYZrSaaQeltQis7AI4DoL4l9S5rVcDSFQfAN4cfjXaHs/5EKspfkUgP/+1/1/9kJ
 8TpiO3basmjvg/vomxHBbGk9dQKXE3y2WqmYnr0CBBiLsUIb1GYpbfZkv7HqXBm4tyf7pBl/
 dVNF2rzHPI+euiVJJ2INaz1lgjv4CF1dSAbdxKgH+S/sX7EqOBCQxEdRNdtSy3VARmclDacy
 SiMBhIU+bvEr4MvqYGbjqGYtYa5VeB5GxMCTWXc6L+3Mwjc/3aintAcALrZI2iFWTOm4rima
 MVU0+r4bK8NkmFVvtcuCL1s168/uYfi/ucI0gR+EXzXRF23Ebc8cGKe1MxCu/QVlL9UsAe7Q
 GyV/dxeNenbMc/pCgdJdgEkcv6CxbcfnTyLtaY5J0Dz5SlW+rubUBoNY0nQ2XIFdLYsadEr2
 +YsvsIS+jeTsBtyP4bUlD1Q+kSNMmcED/ctuKYFDdK5kQEs0FxDP8DRU3ek/JGVZtxQGUA2O
 TvI1rHajrFRy0eeIXo+EX/BgbhUiZgU4U0YyVYDIxKCm8bfh+9x1xpUqGxlQgNQxxRB8uRyJ
 mk0aBElefTQp29l1JpZQmShOwBdHxnIqEX+xmwAmHDdU0T1BHfGK3cwOLrV8U0Um46GkuO3I
 F1MJL7ZbAvX
IronPort-HdrOrdr: A9a23:22qOq6k/IWs/N9GlT7UynaOib3DpDfIs3DAbv31ZSRFFG/Fxl6
 iV8sjz8SWE7Ar5OUtQ/OxoV5PsfZqxz/JICMwqTNCftWrdyQmVxeNZjbcKqgeIc0aVygce79
 YCT0EXMqyXMbEQt6fHCWeDfOod/A==
X-IronPort-AV: E=Sophos;i="5.85,376,1624334400"; 
   d="scan'208";a="55336042"
Date: Fri, 15 Oct 2021 17:40:03 +0100
From: Anthony PERARD <anthony.perard@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, George Dunlap
	<george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>, Julien Grall
	<julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>, Wei Liu
	<wl@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, Roger Pau
 =?iso-8859-1?Q?Monn=E9?= <roger.pau@citrix.com>, Konrad Rzeszutek Wilk
	<konrad.wilk@oracle.com>, Ross Lagerwall <ross.lagerwall@citrix.com>, "Daniel
 De Graaf" <dgdegra@tycho.nsa.gov>, "Daniel P. Smith"
	<dpsmith@apertussolutions.com>, <xen-devel@lists.xenproject.org>
Subject: Re: [XEN PATCH v7 47/51] build: Rework "clean" to clean from the
 root dir
Message-ID: <YWmu4/3VpvAXoG30@perard>
References: <20210824105038.1257926-1-anthony.perard@citrix.com>
 <20210824105038.1257926-48-anthony.perard@citrix.com>
 <f29750b5-7028-3ec5-5bef-4c4480032a18@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <f29750b5-7028-3ec5-5bef-4c4480032a18@suse.com>

On Thu, Oct 14, 2021 at 11:44:00AM +0200, Jan Beulich wrote:
> On 24.08.2021 12:50, Anthony PERARD wrote:
> > This will allow "clean" to work from an out-of-tree build when
> > it will be available.
> > 
> > Some of the file been removed in current "clean" target aren't added
> > to $(clean-files) because they are already listed in $(extra-) or
> > $(extra-y).
> > 
> > Also clean files in "arch/x86/boot" from that directory by allowing
> > "clean" to descend into the subdir by adding "boot" into $(subdir-).
> 
> "descend into" (also used in a respective comment) looks contrary to
> doing everything from the root now, at least to me.

That's the language that Kbuild uses. While it is true that we don't
change directory, we still do the build of one directory at a time, and
the build system as its own understanding of what the current directory
is, even if it is different from $(CURDIR).

> > --- a/xen/scripts/Kbuild.include
> > +++ b/xen/scripts/Kbuild.include
> > @@ -98,7 +98,7 @@ build := -f $(srctree)/Rules.mk obj
> >  # Shorthand for $(MAKE) clean
> >  # Usage:
> >  # $(MAKE) $(clean) dir
> > -clean := -f $(abs_srctree)/scripts/Makefile.clean clean -C
> > +clean := -f $(srctree)/scripts/Makefile.clean obj
> 
> Doesn't the comment want changing as well?

Indeed,

Thanks,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Fri Oct 15 16:47:03 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 16:47:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.210914.367941 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbQME-0003Wi-Cp; Fri, 15 Oct 2021 16:46:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 210914.367941; Fri, 15 Oct 2021 16:46:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbQME-0003Wb-9s; Fri, 15 Oct 2021 16:46:58 +0000
Received: by outflank-mailman (input) for mailman id 210914;
 Fri, 15 Oct 2021 16:46:57 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=7YSI=PD=kernel.org=helgaas@srs-us1.protection.inumbo.net>)
 id 1mbQMD-0003WV-8X
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 16:46:57 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id b810e61a-0567-40f7-9460-bdfc37587462;
 Fri, 15 Oct 2021 16:46:56 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id 34DF061164;
 Fri, 15 Oct 2021 16:46:55 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b810e61a-0567-40f7-9460-bdfc37587462
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1634316415;
	bh=UazkFhnF58o243B84E27T2Q0kziPCzNQlAM0EXnPs+0=;
	h=Date:From:To:Cc:Subject:In-Reply-To:From;
	b=uJA4ra39P0Gv6naQSVcILGvPjCJywIq0xOMKparacmz05rvVX6Np5K3P9TBtMV+Q6
	 0fZMoqlsDqrvmOr81us08+gZah/AgsMkvZGLUZdvStWvkLQD9P6+IT1gNPD5kGzCTz
	 OqQa78pHkuTPX/IwPxuJYSyFJgvQojor9CCfmM0cFvkyP8yz7FerO3C6Xj6Ja6G65F
	 0JNWOrnI2B9XClHx9c5DgYXjOqp4IU9Zrxk/YET9tVYaYS+dnGehAv9e/YWKzwcbHz
	 D1LRfA0mXkjJ2/mnwlueLADrqQ5YuEa5UTY+rPKkoEu2iEn918jjZk3T8fIflFmK8o
	 yGBq7Ksq4IKXA==
Date: Fri, 15 Oct 2021 11:46:53 -0500
From: Bjorn Helgaas <helgaas@kernel.org>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= <u.kleine-koenig@pengutronix.de>,
	linux-pci <linux-pci@vger.kernel.org>,
	Sascha Hauer <kernel@pengutronix.de>,
	Alexander Duyck <alexanderduyck@fb.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Andrew Donnellan <ajd@linux.ibm.com>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Arnd Bergmann <arnd@arndb.de>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Bjorn Helgaas <bhelgaas@google.com>, Borislav Petkov <bp@alien8.de>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	"David S. Miller" <davem@davemloft.net>,
	Fiona Trahe <fiona.trahe@intel.com>,
	Frederic Barrat <fbarrat@linux.ibm.com>,
	Giovanni Cabiddu <giovanni.cabiddu@intel.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	"H. Peter Anvin" <hpa@zytor.com>, Ido Schimmel <idosch@nvidia.com>,
	Ingo Molnar <mingo@redhat.com>, Jack Xu <jack.xu@intel.com>,
	Jakub Kicinski <kuba@kernel.org>,
	Jesse Brandeburg <jesse.brandeburg@intel.com>,
	Jiri Olsa <jolsa@redhat.com>, Jiri Pirko <jiri@nvidia.com>,
	Juergen Gross <jgross@suse.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Marco Chiappero <marco.chiappero@intel.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Mathias Nyman <mathias.nyman@intel.com>, Michael Buesch <m@bues.ch>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Namhyung Kim <namhyung@kernel.org>,
	Oliver O'Halloran <oohall@gmail.com>,
	Paul Mackerras <paulus@samba.org>,
	Peter Zijlstra <peterz@infradead.org>,
	=?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= <zajec5@gmail.com>,
	Russell Currey <ruscur@russell.cc>,
	Salil Mehta <salil.mehta@huawei.com>,
	Sathya Prakash <sathya.prakash@broadcom.com>,
	Simon Horman <simon.horman@corigine.com>,
	Sreekanth Reddy <sreekanth.reddy@broadcom.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Suganath Prabu Subramani <suganath-prabu.subramani@broadcom.com>,
	Taras Chornyi <tchornyi@marvell.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Tomaszx Kowalik <tomaszx.kowalik@intel.com>,
	Vadym Kochan <vkochan@marvell.com>,
	Wojciech Ziemba <wojciech.ziemba@intel.com>,
	Yisen Zhuang <yisen.zhuang@huawei.com>,
	Zhou Wang <wangzhou1@hisilicon.com>,
	linux-crypto <linux-crypto@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-perf-users@vger.kernel.org,
	"open list:LINUX FOR POWERPC PA SEMI PWRFICIENT" <linuxppc-dev@lists.ozlabs.org>,
	linux-scsi <linux-scsi@vger.kernel.org>,
	USB <linux-usb@vger.kernel.org>,
	"open list:TI WILINK WIRELES..." <linux-wireless@vger.kernel.org>,
	MPT-FusionLinux.pdl@broadcom.com, netdev <netdev@vger.kernel.org>,
	oss-drivers@corigine.com, qat-linux@intel.com,
	"maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" <x86@kernel.org>,
	xen-devel@lists.xenproject.org
Subject: Re: [PATCH v6 00/11] PCI: Drop duplicated tracking of a pci_dev's
 bound driver
Message-ID: <20211015164653.GA2108651@bhelgaas>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <YWbdvc7EWEZLVTHM@smile.fi.intel.com>

On Wed, Oct 13, 2021 at 04:23:09PM +0300, Andy Shevchenko wrote:
> On Wed, Oct 13, 2021 at 06:33:56AM -0500, Bjorn Helgaas wrote:
> > On Wed, Oct 13, 2021 at 12:26:42PM +0300, Andy Shevchenko wrote:
> > > On Wed, Oct 13, 2021 at 2:33 AM Bjorn Helgaas <helgaas@kernel.org> wrote:
> > > > On Mon, Oct 04, 2021 at 02:59:24PM +0200, Uwe Kleine-K�nig wrote:

> > > > +       return drv && drv->resume ?
> > > > +                       drv->resume(pci_dev) : pci_pm_reenable_device(pci_dev);
> > > 
> > > One line?
> > 
> > I don't think I touched that line.
> 
> Then why they are both in + section?

They're both in the + section of the interdiff because Uwe's v6 patch
looks like this:

  static int pci_legacy_resume(struct device *dev)
  {
          struct pci_dev *pci_dev = to_pci_dev(dev);
  -       return drv && drv->resume ?
  -                       drv->resume(pci_dev) : pci_pm_reenable_device(pci_dev);
  +       if (pci_dev->dev.driver) {
  +               struct pci_driver *drv = to_pci_driver(pci_dev->dev.driver);
  +
  +               if (drv->resume)
  +                       return drv->resume(pci_dev);
  +       }
  +
  +       return pci_pm_reenable_device(pci_dev);

and my revision looks like this:

   static int pci_legacy_resume(struct device *dev)
   {
	  struct pci_dev *pci_dev = to_pci_dev(dev);
  -       struct pci_driver *drv = pci_dev->driver;
  +       struct pci_driver *drv = to_pci_driver(dev->driver);

so compared to Uwe's v6, I restored that section to the original code.
My goal here was to make the patch as simple and easy to review as
possible.

> > > > +       struct pci_driver *drv = to_pci_driver(dev->dev.driver);
> > > >         const struct pci_error_handlers *err_handler =
> > > > -                       dev->dev.driver ? to_pci_driver(dev->dev.driver)->err_handler : NULL;
> > > > +                       drv ? drv->err_handler : NULL;
> > > 
> > > Isn't dev->driver == to_pci_driver(dev->dev.driver)?
> > 
> > Yes, I think so, but not sure what you're getting at here, can you
> > elaborate?
> 
> Getting pointer from another pointer seems waste of resources, why we
> can't simply
> 
> 	struct pci_driver *drv = dev->driver;

I think this is in pci_dev_save_and_disable(), and "dev" here is a
struct pci_dev *.  We're removing the dev->driver member.  Let me know
if I'm still missing something.

> > > > -                               "bad request in aer recovery "
> > > > -                               "operation!\n");
> > > > +                               "bad request in AER recovery operation!\n");

> > > Stray change? Or is it in a separate patch in your tree?
> > 
> > Could be skipped.  The string now fits on one line so I combined it to
> > make it more greppable.
> 
> This is inconsistency in your changes, in one case you are objecting of
> doing something close to the changed lines, in the other you are doing
> unrelated change.

You're right, this didn't make much sense in that patch.  I moved the
line join to the previous patch, which unindented this section and
made space for this to fit on one line.  Here's the revised commit:

  https://git.kernel.org/cgit/linux/kernel/git/helgaas/pci.git/commit/?id=34ab316d7287



From xen-devel-bounces@lists.xenproject.org Fri Oct 15 16:52:05 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 16:52:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.210925.367964 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbQRA-0005H1-Bs; Fri, 15 Oct 2021 16:52:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 210925.367964; Fri, 15 Oct 2021 16:52:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbQRA-0005Gu-8T; Fri, 15 Oct 2021 16:52:04 +0000
Received: by outflank-mailman (input) for mailman id 210925;
 Fri, 15 Oct 2021 16:52:02 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Fqmt=PD=arm.com=bertrand.marquis@srs-us1.protection.inumbo.net>)
 id 1mbQR8-00052U-Fp
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 16:52:02 +0000
Received: from foss.arm.com (unknown [217.140.110.172])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTP
 id 90bbb406-a8c9-4a3d-b9fc-d7f92d1507e7;
 Fri, 15 Oct 2021 16:52:01 +0000 (UTC)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2994A1480;
 Fri, 15 Oct 2021 09:52:01 -0700 (PDT)
Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com
 [10.1.199.62])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0EEE73F70D;
 Fri, 15 Oct 2021 09:51:59 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 90bbb406-a8c9-4a3d-b9fc-d7f92d1507e7
From: Bertrand Marquis <bertrand.marquis@arm.com>
To: xen-devel@lists.xenproject.org
Cc: iwj@xenproject.org,
	sstabellini@kernel.org,
	Paul Durrant <paul@xen.org>,
	Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	Wei Liu <wl@xen.org>
Subject: [PATCH v8 1/5] xen/vpci: Move ecam access functions to common code
Date: Fri, 15 Oct 2021 17:51:41 +0100
Message-Id: <16ea3d72e7aedb87bb1296b353b35c2a9a19fae0.1634315461.git.bertrand.marquis@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <cover.1634315461.git.bertrand.marquis@arm.com>
References: <cover.1634315461.git.bertrand.marquis@arm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

PCI standard is using ECAM and not MCFG which is coming from ACPI[1].
Use ECAM/ecam instead of MCFG in common code and in new functions added
in common vpci code by this patch.

Move vpci_access_allowed from arch/x86/hvm/io.c to drivers/vpci/vpci.c.

Create vpci_ecam_{read,write} in drivers/vpci/vpci.c that
contains the common code to perform these operations, changed
vpci_mmcfg_{read,write} accordingly to make use of these functions.

The vpci_ecam_{read,write} functions are returning false on error and
true on success. As the x86 code was previously always returning
X86EMUL_OKAY the return code is ignored. A comment has been added in
the code to show that this is intentional.

Those functions will be used in a following patch inside by arm vpci
implementation.

Rename MMCFG_BDF to VPCI_ECAM_BDF and move it to vpci.h.
This macro is only used by functions calling vpci_ecam helpers.

No functional change intended with this patch.

[1] https://wiki.osdev.org/PCI_Express

Suggested-by: Roger Pau Monné <roger.pau@citrix.com>
Signed-off-by: Bertrand Marquis <bertrand.marquis@arm.com>
Acked-by: Roger Pau Monné <roger.pau@citrix.com>
---
Changes in v8:
- move comment in vpci.h for ecam
- fix indent of vpci_ecam declarations in vpci.h
- fix code typo: VCPI instead of VPCI
Changes in v7:
- Rename vpci_ecam_access_allowed to vpci_access_allowed
- Rename vpci_ecam_mmio_{read/write} to vpci_ecam_{read/write}
- Replace comment in x86/hvm/io.c with one suggested by Roger
- Remove 32bit comments and fixes from this patch and move it to the next
one to keep only the moving+renaming in this patch
- Change return type of vpci_ecam_{read/write} to bool
- rename ECAM_BDF to VPCI_ECAM_BDF and move it to vpci.h
Changes in v6: Patch added
---
 xen/arch/x86/hvm/io.c     | 46 ++++-----------------------------
 xen/drivers/vpci/vpci.c   | 54 +++++++++++++++++++++++++++++++++++++++
 xen/include/asm-x86/pci.h |  2 --
 xen/include/xen/vpci.h    | 12 +++++++++
 4 files changed, 71 insertions(+), 43 deletions(-)

diff --git a/xen/arch/x86/hvm/io.c b/xen/arch/x86/hvm/io.c
index 046a8eb4ed..93f1d1503f 100644
--- a/xen/arch/x86/hvm/io.c
+++ b/xen/arch/x86/hvm/io.c
@@ -260,20 +260,6 @@ unsigned int hvm_pci_decode_addr(unsigned int cf8, unsigned int addr,
     return CF8_ADDR_LO(cf8) | (addr & 3);
 }
 
-/* Do some sanity checks. */
-static bool vpci_access_allowed(unsigned int reg, unsigned int len)
-{
-    /* Check access size. */
-    if ( len != 1 && len != 2 && len != 4 && len != 8 )
-        return false;
-
-    /* Check that access is size aligned. */
-    if ( (reg & (len - 1)) )
-        return false;
-
-    return true;
-}
-
 /* vPCI config space IO ports handlers (0xcf8/0xcfc). */
 static bool vpci_portio_accept(const struct hvm_io_handler *handler,
                                const ioreq_t *p)
@@ -394,7 +380,7 @@ static unsigned int vpci_mmcfg_decode_addr(const struct hvm_mmcfg *mmcfg,
                                            paddr_t addr, pci_sbdf_t *sbdf)
 {
     addr -= mmcfg->addr;
-    sbdf->bdf = MMCFG_BDF(addr);
+    sbdf->bdf = VPCI_ECAM_BDF(addr);
     sbdf->bus += mmcfg->start_bus;
     sbdf->seg = mmcfg->segment;
 
@@ -434,25 +420,8 @@ static int vpci_mmcfg_read(struct vcpu *v, unsigned long addr,
     reg = vpci_mmcfg_decode_addr(mmcfg, addr, &sbdf);
     read_unlock(&d->arch.hvm.mmcfg_lock);
 
-    if ( !vpci_access_allowed(reg, len) ||
-         (reg + len) > PCI_CFG_SPACE_EXP_SIZE )
-        return X86EMUL_OKAY;
-
-    /*
-     * According to the PCIe 3.1A specification:
-     *  - Configuration Reads and Writes must usually be DWORD or smaller
-     *    in size.
-     *  - Because Root Complex implementations are not required to support
-     *    accesses to a RCRB that cross DW boundaries [...] software
-     *    should take care not to cause the generation of such accesses
-     *    when accessing a RCRB unless the Root Complex will support the
-     *    access.
-     *  Xen however supports 8byte accesses by splitting them into two
-     *  4byte accesses.
-     */
-    *data = vpci_read(sbdf, reg, min(4u, len));
-    if ( len == 8 )
-        *data |= (uint64_t)vpci_read(sbdf, reg + 4, 4) << 32;
+    /* Failed reads are not propagated to the caller */
+    vpci_ecam_read(sbdf, reg, len, data);
 
     return X86EMUL_OKAY;
 }
@@ -476,13 +445,8 @@ static int vpci_mmcfg_write(struct vcpu *v, unsigned long addr,
     reg = vpci_mmcfg_decode_addr(mmcfg, addr, &sbdf);
     read_unlock(&d->arch.hvm.mmcfg_lock);
 
-    if ( !vpci_access_allowed(reg, len) ||
-         (reg + len) > PCI_CFG_SPACE_EXP_SIZE )
-        return X86EMUL_OKAY;
-
-    vpci_write(sbdf, reg, min(4u, len), data);
-    if ( len == 8 )
-        vpci_write(sbdf, reg + 4, 4, data >> 32);
+    /* Failed writes are not propagated to the caller */
+    vpci_ecam_write(sbdf, reg, len, data);
 
     return X86EMUL_OKAY;
 }
diff --git a/xen/drivers/vpci/vpci.c b/xen/drivers/vpci/vpci.c
index cbd1bac7fc..ef690f15a9 100644
--- a/xen/drivers/vpci/vpci.c
+++ b/xen/drivers/vpci/vpci.c
@@ -478,6 +478,60 @@ void vpci_write(pci_sbdf_t sbdf, unsigned int reg, unsigned int size,
     spin_unlock(&pdev->vpci->lock);
 }
 
+/* Helper function to check an access size and alignment on vpci space. */
+bool vpci_access_allowed(unsigned int reg, unsigned int len)
+{
+    /* Check access size. */
+    if ( len != 1 && len != 2 && len != 4 && len != 8 )
+        return false;
+
+    /* Check that access is size aligned. */
+    if ( (reg & (len - 1)) )
+        return false;
+
+    return true;
+}
+
+bool vpci_ecam_write(pci_sbdf_t sbdf, unsigned int reg, unsigned int len,
+                         unsigned long data)
+{
+    if ( !vpci_access_allowed(reg, len) ||
+         (reg + len) > PCI_CFG_SPACE_EXP_SIZE )
+        return false;
+
+    vpci_write(sbdf, reg, min(4u, len), data);
+    if ( len == 8 )
+        vpci_write(sbdf, reg + 4, 4, data >> 32);
+
+    return true;
+}
+
+bool vpci_ecam_read(pci_sbdf_t sbdf, unsigned int reg, unsigned int len,
+                        unsigned long *data)
+{
+    if ( !vpci_access_allowed(reg, len) ||
+         (reg + len) > PCI_CFG_SPACE_EXP_SIZE )
+        return false;
+
+    /*
+     * According to the PCIe 3.1A specification:
+     *  - Configuration Reads and Writes must usually be DWORD or smaller
+     *    in size.
+     *  - Because Root Complex implementations are not required to support
+     *    accesses to a RCRB that cross DW boundaries [...] software
+     *    should take care not to cause the generation of such accesses
+     *    when accessing a RCRB unless the Root Complex will support the
+     *    access.
+     *  Xen however supports 8byte accesses by splitting them into two
+     *  4byte accesses.
+     */
+    *data = vpci_read(sbdf, reg, min(4u, len));
+    if ( len == 8 )
+        *data |= (uint64_t)vpci_read(sbdf, reg + 4, 4) << 32;
+
+    return true;
+}
+
 /*
  * Local variables:
  * mode: C
diff --git a/xen/include/asm-x86/pci.h b/xen/include/asm-x86/pci.h
index edd7c3e71a..443f25347d 100644
--- a/xen/include/asm-x86/pci.h
+++ b/xen/include/asm-x86/pci.h
@@ -6,8 +6,6 @@
 #define CF8_ADDR_HI(cf8) (  ((cf8) & 0x0f000000) >> 16)
 #define CF8_ENABLED(cf8) (!!((cf8) & 0x80000000))
 
-#define MMCFG_BDF(addr)  ( ((addr) & 0x0ffff000) >> 12)
-
 #define IS_SNB_GFX(id) (id == 0x01068086 || id == 0x01168086 \
                         || id == 0x01268086 || id == 0x01028086 \
                         || id == 0x01128086 || id == 0x01228086 \
diff --git a/xen/include/xen/vpci.h b/xen/include/xen/vpci.h
index 9f5b5d52e1..6746c2589a 100644
--- a/xen/include/xen/vpci.h
+++ b/xen/include/xen/vpci.h
@@ -19,6 +19,8 @@ typedef int vpci_register_init_t(struct pci_dev *dev);
 #define VPCI_PRIORITY_MIDDLE    "5"
 #define VPCI_PRIORITY_LOW       "9"
 
+#define VPCI_ECAM_BDF(addr)     (((addr) & 0x0ffff000) >> 12)
+
 #define REGISTER_VPCI_INIT(x, p)                \
   static vpci_register_init_t *const x##_entry  \
                __used_section(".data.vpci." p) = x
@@ -208,6 +210,16 @@ static inline unsigned int vmsix_entry_nr(const struct vpci_msix *msix,
 {
     return entry - msix->entries;
 }
+
+bool vpci_access_allowed(unsigned int reg, unsigned int len);
+
+/* ECAM mmio read/write helpers */
+bool vpci_ecam_write(pci_sbdf_t sbdf, unsigned int reg, unsigned int len,
+                     unsigned long data);
+
+bool vpci_ecam_read(pci_sbdf_t sbdf, unsigned int reg, unsigned int len,
+                    unsigned long *data);
+
 #endif /* __XEN__ */
 
 #else /* !CONFIG_HAS_VPCI */
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Fri Oct 15 16:52:05 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 16:52:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.210924.367953 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbQR8-00050s-42; Fri, 15 Oct 2021 16:52:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 210924.367953; Fri, 15 Oct 2021 16:52:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbQR8-00050l-0x; Fri, 15 Oct 2021 16:52:02 +0000
Received: by outflank-mailman (input) for mailman id 210924;
 Fri, 15 Oct 2021 16:52:00 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Fqmt=PD=arm.com=bertrand.marquis@srs-us1.protection.inumbo.net>)
 id 1mbQR6-00050f-TU
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 16:52:00 +0000
Received: from foss.arm.com (unknown [217.140.110.172])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTP
 id 36fea98c-2dd8-11ec-8248-12813bfff9fa;
 Fri, 15 Oct 2021 16:52:00 +0000 (UTC)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D04E111D4;
 Fri, 15 Oct 2021 09:51:59 -0700 (PDT)
Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com
 [10.1.199.62])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2E7A53F70D;
 Fri, 15 Oct 2021 09:51:58 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 36fea98c-2dd8-11ec-8248-12813bfff9fa
From: Bertrand Marquis <bertrand.marquis@arm.com>
To: xen-devel@lists.xenproject.org
Cc: iwj@xenproject.org,
	sstabellini@kernel.org,
	Paul Durrant <paul@xen.org>,
	Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	Wei Liu <wl@xen.org>,
	Julien Grall <julien@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Anthony PERARD <anthony.perard@citrix.com>,
	Juergen Gross <jgross@suse.com>
Subject: [PATCH v8 0/5] PCI devices passthrough on Arm
Date: Fri, 15 Oct 2021 17:51:40 +0100
Message-Id: <cover.1634315461.git.bertrand.marquis@arm.com>
X-Mailer: git-send-email 2.25.1
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Hello All,

This serie is a follow up on Rahul serie where we included various fixes
required after review on the mailing list and a new patch to move some
of the x86 ecam related code to the common vpci code.

Most of the patches of the original serie have been merged and this
serie includes only 2 of the original patches reworked and 3 new patches:

Move some ECAM related functions from x86 to generic vpci
implementation:
- move vcpi mmcfg_{read/write} and vpci_access_allowed to common vpci.c.
- use ecam instead of mmcfg in common code.

Enable the existing x86 virtual PCI support for ARM:
- Add VPCI trap handler for each of the PCI device added for config
  space access.
- Register the trap handler in XEN for each of the host bridge PCI ECAM
  config space access.

Modify libxl function to take the whole domain config as argument:
- libxl__arch_domain_init_hw_description
- libxl__prepare_dt

Emulated PCI device tree node in libxl:
- Create a virtual PCI device tree node in libxl to enable the guest OS
  to discover the virtual PCI during guest boot.

The patch modifying xc_domain_ioport_permission has been removed from
the serie.

Bertrand Marquis (1):
  xen/vpci: Move ecam access functions to common code

Michal Orzel (2):
  tools/libxl: Modify libxl__arch_domain_init_hw_description...
  tools/libxl_arm: Modify libxl__prepare_dtb...

Rahul Singh (2):
  xen/arm: Enable the existing x86 virtual PCI support for ARM
  arm/libxl: Emulated PCI device tree node in libxl

 tools/libs/light/libxl_arch.h   |   2 +-
 tools/libs/light/libxl_arm.c    | 111 +++++++++++++++++++++++++++++++-
 tools/libs/light/libxl_create.c |   5 ++
 tools/libs/light/libxl_dom.c    |   2 +-
 tools/libs/light/libxl_x86.c    |   2 +-
 xen/arch/arm/Makefile           |   1 +
 xen/arch/arm/domain.c           |   4 ++
 xen/arch/arm/vpci.c             |  77 ++++++++++++++++++++++
 xen/arch/arm/vpci.h             |  36 +++++++++++
 xen/arch/x86/hvm/io.c           |  46 ++-----------
 xen/drivers/passthrough/pci.c   |  13 ++++
 xen/drivers/vpci/header.c       |   2 +-
 xen/drivers/vpci/vpci.c         |  64 ++++++++++++++++++
 xen/include/asm-arm/domain.h    |   1 +
 xen/include/asm-x86/pci.h       |   2 -
 xen/include/public/arch-arm.h   |  17 +++++
 xen/include/xen/pci.h           |   2 +
 xen/include/xen/vpci.h          |  12 ++++
 18 files changed, 349 insertions(+), 50 deletions(-)
 create mode 100644 xen/arch/arm/vpci.c
 create mode 100644 xen/arch/arm/vpci.h

-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Fri Oct 15 16:52:06 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 16:52:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.210926.367974 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbQRC-0005Yg-LV; Fri, 15 Oct 2021 16:52:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 210926.367974; Fri, 15 Oct 2021 16:52:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbQRC-0005YV-Ho; Fri, 15 Oct 2021 16:52:06 +0000
Received: by outflank-mailman (input) for mailman id 210926;
 Fri, 15 Oct 2021 16:52:05 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Fqmt=PD=arm.com=bertrand.marquis@srs-us1.protection.inumbo.net>)
 id 1mbQRB-00050f-S1
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 16:52:05 +0000
Received: from foss.arm.com (unknown [217.140.110.172])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTP
 id 38e99c02-2dd8-11ec-8248-12813bfff9fa;
 Fri, 15 Oct 2021 16:52:03 +0000 (UTC)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0A09711D4;
 Fri, 15 Oct 2021 09:52:03 -0700 (PDT)
Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com
 [10.1.199.62])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5E61E3F70D;
 Fri, 15 Oct 2021 09:52:01 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 38e99c02-2dd8-11ec-8248-12813bfff9fa
From: Bertrand Marquis <bertrand.marquis@arm.com>
To: xen-devel@lists.xenproject.org
Cc: iwj@xenproject.org,
	sstabellini@kernel.org,
	Rahul Singh <rahul.singh@arm.com>,
	Julien Grall <julien@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Wei Liu <wl@xen.org>,
	Paul Durrant <paul@xen.org>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>
Subject: [PATCH v8 2/5] xen/arm: Enable the existing x86 virtual PCI support for ARM
Date: Fri, 15 Oct 2021 17:51:42 +0100
Message-Id: <e2b10f56043155e4bb8eae824723045ccc042f8e.1634315461.git.bertrand.marquis@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <cover.1634315461.git.bertrand.marquis@arm.com>
References: <cover.1634315461.git.bertrand.marquis@arm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

From: Rahul Singh <rahul.singh@arm.com>

The existing VPCI support available for X86 is adapted for Arm.
When the device is added to XEN via the hyper call
“PHYSDEVOP_pci_device_add”, VPCI handler for the config space
access is added to the Xen to emulate the PCI devices config space.

A MMIO trap handler for the PCI ECAM space is registered in XEN
so that when guest is trying to access the PCI config space,XEN
will trap the access and emulate read/write using the VPCI and
not the real PCI hardware.

For Dom0less systems scan_pci_devices() would be used to discover the
PCI device in XEN and VPCI handler will be added during XEN boots.

This patch is also doing some small fixes to fix compilation errors on
arm32 of vpci and prevent 64bit accesses on 32bit:
- use %zu instead of lu in header.c for print
- prevent 64bit accesses in vpci_access_allowed
- ifdef out using CONFIG_64BIT handling of len 8 in
vpci_ecam_{read/write}

Signed-off-by: Rahul Singh <rahul.singh@arm.com>
Signed-off-by: Bertrand Marquis <bertrand.marquis@arm.com>
---
Changes in v8:
- move pci_add_handlers call to right place so that it is called only
once and cleanup pdev->domain on error.
- fix code typo: VCPI instead of VPCI
Changes in v7:
- adapt to changes in vpci generic functions (name and type)
- remove call to pci_cleanup_msi on error exit
- move pci_add_handlers to be only done when pdev->domain is not NULL
- Remove cast to unsigned long in header.c and use %zu for print
- Fix non ascii chars in arch-arm.h
- Use CONFIG_64BIT inside vpci_access_allowed to prevent 64bit access on
32bit platforms
- Use CONFIG_64BIT to compile out 64bit cases in vpci_ecam_{read/write}
Changes in v6:
- Use new vpci_ecam_ helpers for PCI access
- Do not set XEN_DOMCTL_CDF_vpci for dom0 for now (will be done in a
future patch once everything is ready)
- rename REGISTER_OFFSET to ECAM_REG_OFFSET and move it to pci.h
- remove not needed local variables in vpci_mmio_write, the one in read
has been kept to ensure proper compilation on arm32
- move call to vpci_add_handlers before iommu init to simplify exit path
- move call to pci_cleanup_msi in the out section of pci_add_device if
pdev is not NULL and on error
- initialize pdev to NULL to handle properly exit path call of
pci_cleanup_msi
- keep has_vpci to return false for now as CFG_vpci has been removed.
Added a comment on top of the definition.
- fix compilation errors on arm32 (print in header.c, cast missing in
mmio_write.
- local variable was kept in vpci_mmio_read on arm to prevent a cast
error in arm32.
Change in v5:
- Add pci_cleanup_msi(pdev) incleanup part.
- Added Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
Change in v4:
- Move addition of XEN_DOMCTL_CDF_vpci flag to separate patch
Change in v3:
- Use is_pci_passthrough_enabled() in place of pci_passthrough_enabled variable
- Reject XEN_DOMCTL_CDF_vpci for x86 in arch_sanitise_domain_config()
- Remove IS_ENABLED(CONFIG_HAS_VPCI) from has_vpci()
Change in v2:
- Add new XEN_DOMCTL_CDF_vpci flag
- modify has_vpci() to include XEN_DOMCTL_CDF_vpci
- enable vpci support when pci-passthough option is enabled.
---
---
 xen/arch/arm/Makefile         |  1 +
 xen/arch/arm/domain.c         |  4 ++
 xen/arch/arm/vpci.c           | 77 +++++++++++++++++++++++++++++++++++
 xen/arch/arm/vpci.h           | 36 ++++++++++++++++
 xen/drivers/passthrough/pci.c | 13 ++++++
 xen/drivers/vpci/header.c     |  2 +-
 xen/drivers/vpci/vpci.c       | 10 +++++
 xen/include/asm-arm/domain.h  |  1 +
 xen/include/public/arch-arm.h |  7 ++++
 xen/include/xen/pci.h         |  2 +
 10 files changed, 152 insertions(+), 1 deletion(-)
 create mode 100644 xen/arch/arm/vpci.c
 create mode 100644 xen/arch/arm/vpci.h

diff --git a/xen/arch/arm/Makefile b/xen/arch/arm/Makefile
index 64518848b2..07f634508e 100644
--- a/xen/arch/arm/Makefile
+++ b/xen/arch/arm/Makefile
@@ -7,6 +7,7 @@ ifneq ($(CONFIG_NO_PLAT),y)
 obj-y += platforms/
 endif
 obj-$(CONFIG_TEE) += tee/
+obj-$(CONFIG_HAS_VPCI) += vpci.o
 
 obj-$(CONFIG_HAS_ALTERNATIVE) += alternative.o
 obj-y += bootfdt.init.o
diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
index eef0661beb..96e1b23550 100644
--- a/xen/arch/arm/domain.c
+++ b/xen/arch/arm/domain.c
@@ -39,6 +39,7 @@
 #include <asm/vgic.h>
 #include <asm/vtimer.h>
 
+#include "vpci.h"
 #include "vuart.h"
 
 DEFINE_PER_CPU(struct vcpu *, curr_vcpu);
@@ -773,6 +774,9 @@ int arch_domain_create(struct domain *d,
     if ( is_hardware_domain(d) && (rc = domain_vuart_init(d)) )
         goto fail;
 
+    if ( (rc = domain_vpci_init(d)) != 0 )
+        goto fail;
+
     return 0;
 
 fail:
diff --git a/xen/arch/arm/vpci.c b/xen/arch/arm/vpci.c
new file mode 100644
index 0000000000..8f40a0dec6
--- /dev/null
+++ b/xen/arch/arm/vpci.c
@@ -0,0 +1,77 @@
+/*
+ * xen/arch/arm/vpci.c
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+#include <xen/sched.h>
+#include <xen/vpci.h>
+
+#include <asm/mmio.h>
+
+static int vpci_mmio_read(struct vcpu *v, mmio_info_t *info,
+                          register_t *r, void *p)
+{
+    pci_sbdf_t sbdf;
+    /* data is needed to prevent a pointer cast on 32bit */
+    unsigned long data;
+
+    /* We ignore segment part and always handle segment 0 */
+    sbdf.sbdf = VPCI_ECAM_BDF(info->gpa);
+
+    if ( vpci_ecam_read(sbdf, ECAM_REG_OFFSET(info->gpa),
+                        1U << info->dabt.size, &data) )
+    {
+        *r = data;
+        return 1;
+    }
+
+    *r = ~0ul;
+
+    return 0;
+}
+
+static int vpci_mmio_write(struct vcpu *v, mmio_info_t *info,
+                           register_t r, void *p)
+{
+    pci_sbdf_t sbdf;
+
+    /* We ignore segment part and always handle segment 0 */
+    sbdf.sbdf = VPCI_ECAM_BDF(info->gpa);
+
+    return vpci_ecam_write(sbdf, ECAM_REG_OFFSET(info->gpa),
+                           1U << info->dabt.size, r);
+}
+
+static const struct mmio_handler_ops vpci_mmio_handler = {
+    .read  = vpci_mmio_read,
+    .write = vpci_mmio_write,
+};
+
+int domain_vpci_init(struct domain *d)
+{
+    if ( !has_vpci(d) )
+        return 0;
+
+    register_mmio_handler(d, &vpci_mmio_handler,
+                          GUEST_VPCI_ECAM_BASE, GUEST_VPCI_ECAM_SIZE, NULL);
+
+    return 0;
+}
+
+/*
+ * Local variables:
+ * mode: C
+ * c-file-style: "BSD"
+ * c-basic-offset: 4
+ * indent-tabs-mode: nil
+ * End:
+ */
+
diff --git a/xen/arch/arm/vpci.h b/xen/arch/arm/vpci.h
new file mode 100644
index 0000000000..d8a7b0e3e8
--- /dev/null
+++ b/xen/arch/arm/vpci.h
@@ -0,0 +1,36 @@
+/*
+ * xen/arch/arm/vpci.h
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+
+#ifndef __ARCH_ARM_VPCI_H__
+#define __ARCH_ARM_VPCI_H__
+
+#ifdef CONFIG_HAS_VPCI
+int domain_vpci_init(struct domain *d);
+#else
+static inline int domain_vpci_init(struct domain *d)
+{
+    return 0;
+}
+#endif
+
+#endif /* __ARCH_ARM_VPCI_H__ */
+
+/*
+ * Local variables:
+ * mode: C
+ * c-file-style: "BSD"
+ * c-basic-offset: 4
+ * indent-tabs-mode: nil
+ * End:
+ */
diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci.c
index 3aa8c3175f..35e0190796 100644
--- a/xen/drivers/passthrough/pci.c
+++ b/xen/drivers/passthrough/pci.c
@@ -756,6 +756,19 @@ int pci_add_device(u16 seg, u8 bus, u8 devfn,
     if ( !pdev->domain )
     {
         pdev->domain = hardware_domain;
+#ifdef CONFIG_ARM
+        /*
+         * On ARM PCI devices discovery will be done by Dom0. Add vpci handler
+         * when Dom0 inform XEN to add the PCI devices in XEN.
+         */
+        ret = vpci_add_handlers(pdev);
+        if ( ret )
+        {
+            printk(XENLOG_ERR "Setup of vPCI failed: %d\n", ret);
+            pdev->domain = NULL;
+            goto out;
+        }
+#endif
         ret = iommu_add_device(pdev);
         if ( ret )
         {
diff --git a/xen/drivers/vpci/header.c b/xen/drivers/vpci/header.c
index f8cd55e7c0..40ff79c33f 100644
--- a/xen/drivers/vpci/header.c
+++ b/xen/drivers/vpci/header.c
@@ -373,7 +373,7 @@ static void bar_write(const struct pci_dev *pdev, unsigned int reg,
         /* If the value written is the current one avoid printing a warning. */
         if ( val != (uint32_t)(bar->addr >> (hi ? 32 : 0)) )
             gprintk(XENLOG_WARNING,
-                    "%pp: ignored BAR %lu write with memory decoding enabled\n",
+                    "%pp: ignored BAR %zu write with memory decoding enabled\n",
                     &pdev->sbdf, bar - pdev->vpci->header.bars + hi);
         return;
     }
diff --git a/xen/drivers/vpci/vpci.c b/xen/drivers/vpci/vpci.c
index ef690f15a9..decf7d87a1 100644
--- a/xen/drivers/vpci/vpci.c
+++ b/xen/drivers/vpci/vpci.c
@@ -485,6 +485,12 @@ bool vpci_access_allowed(unsigned int reg, unsigned int len)
     if ( len != 1 && len != 2 && len != 4 && len != 8 )
         return false;
 
+#ifndef CONFIG_64BIT
+    /* Prevent 64bit accesses on 32bit */
+    if ( len == 8 )
+        return false;
+#endif
+
     /* Check that access is size aligned. */
     if ( (reg & (len - 1)) )
         return false;
@@ -500,8 +506,10 @@ bool vpci_ecam_write(pci_sbdf_t sbdf, unsigned int reg, unsigned int len,
         return false;
 
     vpci_write(sbdf, reg, min(4u, len), data);
+#ifdef CONFIG_64BIT
     if ( len == 8 )
         vpci_write(sbdf, reg + 4, 4, data >> 32);
+#endif
 
     return true;
 }
@@ -526,8 +534,10 @@ bool vpci_ecam_read(pci_sbdf_t sbdf, unsigned int reg, unsigned int len,
      *  4byte accesses.
      */
     *data = vpci_read(sbdf, reg, min(4u, len));
+#ifdef CONFIG_64BIT
     if ( len == 8 )
         *data |= (uint64_t)vpci_read(sbdf, reg + 4, 4) << 32;
+#endif
 
     return true;
 }
diff --git a/xen/include/asm-arm/domain.h b/xen/include/asm-arm/domain.h
index 14e575288f..9b3647587a 100644
--- a/xen/include/asm-arm/domain.h
+++ b/xen/include/asm-arm/domain.h
@@ -263,6 +263,7 @@ static inline void arch_vcpu_block(struct vcpu *v) {}
 
 #define arch_vm_assist_valid_mask(d) (1UL << VMASST_TYPE_runstate_update_flag)
 
+/* vPCI is not available on Arm */
 #define has_vpci(d)    ({ (void)(d); false; })
 
 #endif /* __ASM_DOMAIN_H__ */
diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h
index 96ead3de07..b4c615bcdf 100644
--- a/xen/include/public/arch-arm.h
+++ b/xen/include/public/arch-arm.h
@@ -418,6 +418,13 @@ typedef uint64_t xen_callback_t;
 #define GUEST_GICV3_GICR0_BASE     xen_mk_ullong(0x03020000) /* vCPU0..127 */
 #define GUEST_GICV3_GICR0_SIZE     xen_mk_ullong(0x01000000)
 
+/*
+ * 256 MB is reserved for VPCI configuration space based on calculation
+ * 256 buses x 32 devices x 8 functions x 4 KB = 256 MB
+ */
+#define GUEST_VPCI_ECAM_BASE    xen_mk_ullong(0x10000000)
+#define GUEST_VPCI_ECAM_SIZE    xen_mk_ullong(0x10000000)
+
 /* ACPI tables physical address */
 #define GUEST_ACPI_BASE xen_mk_ullong(0x20000000)
 #define GUEST_ACPI_SIZE xen_mk_ullong(0x02000000)
diff --git a/xen/include/xen/pci.h b/xen/include/xen/pci.h
index 70ac25345c..b6d7e454f8 100644
--- a/xen/include/xen/pci.h
+++ b/xen/include/xen/pci.h
@@ -40,6 +40,8 @@
 #define PCI_SBDF3(s,b,df) \
     ((pci_sbdf_t){ .sbdf = (((s) & 0xffff) << 16) | PCI_BDF2(b, df) })
 
+#define ECAM_REG_OFFSET(addr)  ((addr) & 0x00000fff)
+
 typedef union {
     uint32_t sbdf;
     struct {
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Fri Oct 15 16:52:09 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 16:52:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.210927.367986 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbQRF-0005sE-3N; Fri, 15 Oct 2021 16:52:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 210927.367986; Fri, 15 Oct 2021 16:52:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbQRF-0005ry-01; Fri, 15 Oct 2021 16:52:09 +0000
Received: by outflank-mailman (input) for mailman id 210927;
 Fri, 15 Oct 2021 16:52:07 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Fqmt=PD=arm.com=bertrand.marquis@srs-us1.protection.inumbo.net>)
 id 1mbQRD-00052U-8l
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 16:52:07 +0000
Received: from foss.arm.com (unknown [217.140.110.172])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTP
 id 4f640820-d165-4558-baf3-88a3163207e8;
 Fri, 15 Oct 2021 16:52:04 +0000 (UTC)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3D8531480;
 Fri, 15 Oct 2021 09:52:04 -0700 (PDT)
Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com
 [10.1.199.62])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 3D9C23F70D;
 Fri, 15 Oct 2021 09:52:03 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4f640820-d165-4558-baf3-88a3163207e8
From: Bertrand Marquis <bertrand.marquis@arm.com>
To: xen-devel@lists.xenproject.org
Cc: iwj@xenproject.org,
	sstabellini@kernel.org,
	Michal Orzel <michal.orzel@arm.com>,
	Wei Liu <wl@xen.org>,
	Anthony PERARD <anthony.perard@citrix.com>,
	Juergen Gross <jgross@suse.com>
Subject: [PATCH v8 3/5] tools/libxl: Modify libxl__arch_domain_init_hw_description...
Date: Fri, 15 Oct 2021 17:51:43 +0100
Message-Id: <9f08e64663ac0815fa19f7fdc8e38b1b94dd347d.1634315461.git.bertrand.marquis@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <cover.1634315461.git.bertrand.marquis@arm.com>
References: <cover.1634315461.git.bertrand.marquis@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Michal Orzel <michal.orzel@arm.com>

... to take a second argument of type libxl_domain_config*
rather than libxl_domain_build_info*.

We need to pass the whole libxl_domain_config
structure as this will be needed later on to modify
the libxl__prepare_dtb function to also take
libxl_domain_config.

Signed-off-by: Michal Orzel <michal.orzel@arm.com>
Signed-off-by: Bertrand Marquis <bertrand.marquis@arm.com>
Suggested-by: Ian Jackson <iwj@xenproject.org>
Reviewed-by: Ian Jackson <iwj@xenproject.org>
---
Changes in v8: add Signed-off Bertrand Marquis
Changes in v7: Patch added
---
 tools/libs/light/libxl_arch.h | 2 +-
 tools/libs/light/libxl_arm.c  | 3 ++-
 tools/libs/light/libxl_dom.c  | 2 +-
 tools/libs/light/libxl_x86.c  | 2 +-
 4 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/tools/libs/light/libxl_arch.h b/tools/libs/light/libxl_arch.h
index 8527fc5c6c..1522ecb97f 100644
--- a/tools/libs/light/libxl_arch.h
+++ b/tools/libs/light/libxl_arch.h
@@ -38,7 +38,7 @@ int libxl__arch_domain_create(libxl__gc *gc,
 /* setup arch specific hardware description, i.e. DTB on ARM */
 _hidden
 int libxl__arch_domain_init_hw_description(libxl__gc *gc,
-                                           libxl_domain_build_info *info,
+                                           libxl_domain_config *d_config,
                                            libxl__domain_build_state *state,
                                            struct xc_dom_image *dom);
 /* finalize arch specific hardware description. */
diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c
index a7801558cf..d5771f98dd 100644
--- a/tools/libs/light/libxl_arm.c
+++ b/tools/libs/light/libxl_arm.c
@@ -1016,12 +1016,13 @@ out:
 }
 
 int libxl__arch_domain_init_hw_description(libxl__gc *gc,
-                                           libxl_domain_build_info *info,
+                                           libxl_domain_config *d_config,
                                            libxl__domain_build_state *state,
                                            struct xc_dom_image *dom)
 {
     int rc;
     uint64_t val;
+    libxl_domain_build_info *const info = &d_config->b_info;
 
     if (info->type != LIBXL_DOMAIN_TYPE_PVH) {
         LOG(ERROR, "Unsupported Arm guest type %s",
diff --git a/tools/libs/light/libxl_dom.c b/tools/libs/light/libxl_dom.c
index e9f58ee4b2..fe9f760f71 100644
--- a/tools/libs/light/libxl_dom.c
+++ b/tools/libs/light/libxl_dom.c
@@ -571,7 +571,7 @@ static int libxl__build_dom(libxl__gc *gc, uint32_t domid,
         LOG(ERROR, "xc_dom_parse_image failed");
         goto out;
     }
-    if ( (ret = libxl__arch_domain_init_hw_description(gc, info, state, dom)) != 0 ) {
+    if ( (ret = libxl__arch_domain_init_hw_description(gc, d_config, state, dom)) != 0 ) {
         LOGE(ERROR, "libxl__arch_domain_init_hw_description failed");
         goto out;
     }
diff --git a/tools/libs/light/libxl_x86.c b/tools/libs/light/libxl_x86.c
index 6083878315..1feadebb18 100644
--- a/tools/libs/light/libxl_x86.c
+++ b/tools/libs/light/libxl_x86.c
@@ -568,7 +568,7 @@ int libxl__arch_extra_memory(libxl__gc *gc,
 }
 
 int libxl__arch_domain_init_hw_description(libxl__gc *gc,
-                                           libxl_domain_build_info *info,
+                                           libxl_domain_config *d_config,
                                            libxl__domain_build_state *state,
                                            struct xc_dom_image *dom)
 {
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Fri Oct 15 16:52:14 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 16:52:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.210928.367996 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbQRK-0006IV-EZ; Fri, 15 Oct 2021 16:52:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 210928.367996; Fri, 15 Oct 2021 16:52:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbQRK-0006IK-Af; Fri, 15 Oct 2021 16:52:14 +0000
Received: by outflank-mailman (input) for mailman id 210928;
 Fri, 15 Oct 2021 16:52:12 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Fqmt=PD=arm.com=bertrand.marquis@srs-us1.protection.inumbo.net>)
 id 1mbQRI-00052U-8z
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 16:52:12 +0000
Received: from foss.arm.com (unknown [217.140.110.172])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTP
 id 35367cef-0b68-4c69-a303-855dfb9fc1b6;
 Fri, 15 Oct 2021 16:52:05 +0000 (UTC)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7214511D4;
 Fri, 15 Oct 2021 09:52:05 -0700 (PDT)
Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com
 [10.1.199.62])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 710F73F70D;
 Fri, 15 Oct 2021 09:52:04 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 35367cef-0b68-4c69-a303-855dfb9fc1b6
From: Bertrand Marquis <bertrand.marquis@arm.com>
To: xen-devel@lists.xenproject.org
Cc: iwj@xenproject.org,
	sstabellini@kernel.org,
	Michal Orzel <michal.orzel@arm.com>,
	Wei Liu <wl@xen.org>,
	Anthony PERARD <anthony.perard@citrix.com>,
	Juergen Gross <jgross@suse.com>
Subject: [PATCH v8 4/5] tools/libxl_arm: Modify libxl__prepare_dtb...
Date: Fri, 15 Oct 2021 17:51:44 +0100
Message-Id: <d46d8a92b211e43c1784bab2cdb7bb51eee4534b.1634315461.git.bertrand.marquis@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <cover.1634315461.git.bertrand.marquis@arm.com>
References: <cover.1634315461.git.bertrand.marquis@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Michal Orzel <michal.orzel@arm.com>

... to take a second argument of type libxl_domain_config*
rather than libxl_domain_build_info*.

This change will be needed to get access from
libxl__prepare_dtb to "num_pcidevs" field of
libxl_domain_config to check whether to create
a vPCI DT node or not.

Signed-off-by: Michal Orzel <michal.orzel@arm.com>
Signed-off-by: Bertrand Marquis <bertrand.marquis@arm.com>
Suggested-by: Ian Jackson <iwj@xenproject.org>
Reviewed-by: Ian Jackson <iwj@xenproject.org>
---
Changes in v8: add Signed-off Bertrand Marquis
Changes in v7: Patch added
---
 tools/libs/light/libxl_arm.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c
index d5771f98dd..fdae129605 100644
--- a/tools/libs/light/libxl_arm.c
+++ b/tools/libs/light/libxl_arm.c
@@ -878,7 +878,7 @@ static int copy_partial_fdt(libxl__gc *gc, void *fdt, void *pfdt)
 
 #define FDT_MAX_SIZE (1<<20)
 
-static int libxl__prepare_dtb(libxl__gc *gc, libxl_domain_build_info *info,
+static int libxl__prepare_dtb(libxl__gc *gc, libxl_domain_config *d_config,
                               libxl__domain_build_state *state,
                               struct xc_dom_image *dom)
 {
@@ -887,6 +887,7 @@ static int libxl__prepare_dtb(libxl__gc *gc, libxl_domain_build_info *info,
     int rc, res;
     size_t fdt_size = 0;
     int pfdt_size = 0;
+    libxl_domain_build_info *const info = &d_config->b_info;
 
     const libxl_version_info *vers;
     const struct arch_info *ainfo;
@@ -1042,7 +1043,7 @@ int libxl__arch_domain_init_hw_description(libxl__gc *gc,
     if (rc)
         return rc;
 
-    rc = libxl__prepare_dtb(gc, info, state, dom);
+    rc = libxl__prepare_dtb(gc, d_config, state, dom);
     if (rc) goto out;
 
     if (!libxl_defbool_val(info->acpi)) {
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Fri Oct 15 16:52:18 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 16:52:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.210929.368008 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbQRO-0006nE-Qb; Fri, 15 Oct 2021 16:52:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 210929.368008; Fri, 15 Oct 2021 16:52:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbQRO-0006my-Kn; Fri, 15 Oct 2021 16:52:18 +0000
Received: by outflank-mailman (input) for mailman id 210929;
 Fri, 15 Oct 2021 16:52:17 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Fqmt=PD=arm.com=bertrand.marquis@srs-us1.protection.inumbo.net>)
 id 1mbQRN-00052U-9D
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 16:52:17 +0000
Received: from foss.arm.com (unknown [217.140.110.172])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTP
 id 76f43db9-2b5a-45af-97d4-4fe8e00b74cc;
 Fri, 15 Oct 2021 16:52:07 +0000 (UTC)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 218681480;
 Fri, 15 Oct 2021 09:52:07 -0700 (PDT)
Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com
 [10.1.199.62])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A88EA3F70D;
 Fri, 15 Oct 2021 09:52:05 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 76f43db9-2b5a-45af-97d4-4fe8e00b74cc
From: Bertrand Marquis <bertrand.marquis@arm.com>
To: xen-devel@lists.xenproject.org
Cc: iwj@xenproject.org,
	sstabellini@kernel.org,
	Rahul Singh <rahul.singh@arm.com>,
	Wei Liu <wl@xen.org>,
	Anthony PERARD <anthony.perard@citrix.com>,
	Juergen Gross <jgross@suse.com>,
	Julien Grall <julien@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Michal Orzel <michal.orzel@arm.com>,
	Julien Grall <jgrall@amazon.com>
Subject: [PATCH v8 5/5] arm/libxl: Emulated PCI device tree node in libxl
Date: Fri, 15 Oct 2021 17:51:45 +0100
Message-Id: <400225e0736c7b5b1f1950a919677fc0a72d212f.1634315461.git.bertrand.marquis@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <cover.1634315461.git.bertrand.marquis@arm.com>
References: <cover.1634315461.git.bertrand.marquis@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Rahul Singh <rahul.singh@arm.com>

libxl will create an emulated PCI device tree node in the device tree to
enable the guest OS to discover the virtual PCI during guest boot.
Emulated PCI device tree node will only be created when there is any
device assigned to guest.

A new area has been reserved in the arm guest physical map at
which the VPCI bus is declared in the device tree (reg and ranges
parameters of the node).

Note that currently we are using num_pcidevs instead of
c_info->passthrough to decide whether to create a vPCI DT node.
This will be insufficient if and when ARM does PCI hotplug.
Add this note inside libxl_create.c where c_info->passthrough
is set.

Signed-off-by: Rahul Singh <rahul.singh@arm.com>
Signed-off-by: Michal Orzel <michal.orzel@arm.com>
Signed-off-by: Bertrand Marquis <bertrand.marquis@arm.com>
Reviewed-by: Julien Grall <jgrall@amazon.com>
Acked-by: Ian Jackson <iwj@xenproject.org>
---
Changes in v8: add Signed-off Bertrand Marquis
Changes in v7:
-remove arch_arm.vpci
-create vpci DT note if (d_config->num_pcidevs)
Changes in v6:
According to https://marc.info/?l=xen-devel&m=163415838129479&w=2:
-do not set XEN_DOMCTL_CDF_vpci
-do not enable VPCI support (by setting b_info.arch_arm.vpci)
-do not define LIBXL_HAVE_BUILDINFO_ARM_VPCI
-keep b_info.arch_arm.vpci, make_vpci_node and its helpers
Change in v5:
- Move setting the arch_arm.vpci and XEN_DOMCTL_CDF_vpci to libxl_arm.c
Change in v4:
- Gate code for x86 for setting the XEN_DOMCTL_CDF_vpci for x86.
Change in v3:
- Make GUEST_VPCI_MEM_ADDR address 2MB aligned
Change in v2:
- enable doamin_vpci_init() when XEN_DOMCTL_CDF_vpci is set for domain.
---
---
 tools/libs/light/libxl_arm.c    | 103 ++++++++++++++++++++++++++++++++
 tools/libs/light/libxl_create.c |   5 ++
 xen/include/public/arch-arm.h   |  10 ++++
 3 files changed, 118 insertions(+)

diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c
index fdae129605..eef1de0939 100644
--- a/tools/libs/light/libxl_arm.c
+++ b/tools/libs/light/libxl_arm.c
@@ -284,6 +284,59 @@ static int fdt_property_reg_placeholder(libxl__gc *gc, void *fdt,
     return fdt_property(fdt, "reg", regs, sizeof(regs));
 }
 
+static int fdt_property_values(libxl__gc *gc, void *fdt,
+                               const char *name,
+                               unsigned num_cells, ...)
+{
+    uint32_t prop[num_cells];
+    be32 *cells = &prop[0];
+    int i;
+    va_list ap;
+    uint32_t arg;
+
+    va_start(ap, num_cells);
+    for (i = 0 ; i < num_cells; i++) {
+        arg = va_arg(ap, uint32_t);
+        set_cell(&cells, 1, arg);
+    }
+    va_end(ap);
+
+    return fdt_property(fdt, name, prop, sizeof(prop));
+}
+
+static int fdt_property_vpci_ranges(libxl__gc *gc, void *fdt,
+                                    unsigned addr_cells,
+                                    unsigned size_cells,
+                                    unsigned num_regs, ...)
+{
+    uint32_t regs[num_regs*((addr_cells*2)+size_cells+1)];
+    be32 *cells = &regs[0];
+    int i;
+    va_list ap;
+    uint64_t arg;
+
+    va_start(ap, num_regs);
+    for (i = 0 ; i < num_regs; i++) {
+        /* Set the memory bit field */
+        arg = va_arg(ap, uint32_t);
+        set_cell(&cells, 1, arg);
+
+        /* Set the vpci bus address */
+        arg = addr_cells ? va_arg(ap, uint64_t) : 0;
+        set_cell(&cells, addr_cells , arg);
+
+        /* Set the cpu bus address where vpci address is mapped */
+        set_cell(&cells, addr_cells, arg);
+
+        /* Set the vpci size requested */
+        arg = size_cells ? va_arg(ap, uint64_t) : 0;
+        set_cell(&cells, size_cells, arg);
+    }
+    va_end(ap);
+
+    return fdt_property(fdt, "ranges", regs, sizeof(regs));
+}
+
 static int make_root_properties(libxl__gc *gc,
                                 const libxl_version_info *vers,
                                 void *fdt)
@@ -687,6 +740,53 @@ static int make_vpl011_uart_node(libxl__gc *gc, void *fdt,
     return 0;
 }
 
+static int make_vpci_node(libxl__gc *gc, void *fdt,
+                          const struct arch_info *ainfo,
+                          struct xc_dom_image *dom)
+{
+    int res;
+    const uint64_t vpci_ecam_base = GUEST_VPCI_ECAM_BASE;
+    const uint64_t vpci_ecam_size = GUEST_VPCI_ECAM_SIZE;
+    const char *name = GCSPRINTF("pcie@%"PRIx64, vpci_ecam_base);
+
+    res = fdt_begin_node(fdt, name);
+    if (res) return res;
+
+    res = fdt_property_compat(gc, fdt, 1, "pci-host-ecam-generic");
+    if (res) return res;
+
+    res = fdt_property_string(fdt, "device_type", "pci");
+    if (res) return res;
+
+    res = fdt_property_regs(gc, fdt, GUEST_ROOT_ADDRESS_CELLS,
+            GUEST_ROOT_SIZE_CELLS, 1, vpci_ecam_base, vpci_ecam_size);
+    if (res) return res;
+
+    res = fdt_property_values(gc, fdt, "bus-range", 2, 0, 255);
+    if (res) return res;
+
+    res = fdt_property_cell(fdt, "#address-cells", 3);
+    if (res) return res;
+
+    res = fdt_property_cell(fdt, "#size-cells", 2);
+    if (res) return res;
+
+    res = fdt_property_string(fdt, "status", "okay");
+    if (res) return res;
+
+    res = fdt_property_vpci_ranges(gc, fdt, GUEST_ROOT_ADDRESS_CELLS,
+        GUEST_ROOT_SIZE_CELLS, 2,
+        GUEST_VPCI_ADDR_TYPE_MEM, GUEST_VPCI_MEM_ADDR, GUEST_VPCI_MEM_SIZE,
+        GUEST_VPCI_ADDR_TYPE_PREFETCH_MEM, GUEST_VPCI_PREFETCH_MEM_ADDR,
+        GUEST_VPCI_PREFETCH_MEM_SIZE);
+    if (res) return res;
+
+    res = fdt_end_node(fdt);
+    if (res) return res;
+
+    return 0;
+}
+
 static const struct arch_info *get_arch_info(libxl__gc *gc,
                                              const struct xc_dom_image *dom)
 {
@@ -991,6 +1091,9 @@ next_resize:
         if (info->tee == LIBXL_TEE_TYPE_OPTEE)
             FDT( make_optee_node(gc, fdt) );
 
+        if (d_config->num_pcidevs)
+            FDT( make_vpci_node(gc, fdt, ainfo, dom) );
+
         if (pfdt)
             FDT( copy_partial_fdt(gc, fdt, pfdt) );
 
diff --git a/tools/libs/light/libxl_create.c b/tools/libs/light/libxl_create.c
index 6ebb2bfc76..5a61d01722 100644
--- a/tools/libs/light/libxl_create.c
+++ b/tools/libs/light/libxl_create.c
@@ -1096,6 +1096,11 @@ int libxl__domain_config_setdefault(libxl__gc *gc,
         goto error_out;
     }
 
+    /*
+     * Note: libxl_arm directly examines num_pcidevs to decide whether
+     * to create a vPCI DT node, rather than using c_info->passthrough.
+     * This will be insufficient if and when ARM does PCI hotplug.
+     */
     bool need_pt = d_config->num_pcidevs || d_config->num_dtdevs;
     if (c_info->passthrough == LIBXL_PASSTHROUGH_DEFAULT) {
         c_info->passthrough = need_pt
diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h
index b4c615bcdf..94b31511dd 100644
--- a/xen/include/public/arch-arm.h
+++ b/xen/include/public/arch-arm.h
@@ -433,6 +433,11 @@ typedef uint64_t xen_callback_t;
 #define GUEST_PL011_BASE    xen_mk_ullong(0x22000000)
 #define GUEST_PL011_SIZE    xen_mk_ullong(0x00001000)
 
+/* Guest PCI-PCIe memory space where config space and BAR will be available.*/
+#define GUEST_VPCI_ADDR_TYPE_MEM            xen_mk_ullong(0x02000000)
+#define GUEST_VPCI_MEM_ADDR                 xen_mk_ullong(0x23000000)
+#define GUEST_VPCI_MEM_SIZE                 xen_mk_ullong(0x10000000)
+
 /*
  * 16MB == 4096 pages reserved for guest to use as a region to map its
  * grant table in.
@@ -453,6 +458,11 @@ typedef uint64_t xen_callback_t;
 #define GUEST_RAM0_BASE   xen_mk_ullong(0x40000000) /* 3GB of low RAM @ 1GB */
 #define GUEST_RAM0_SIZE   xen_mk_ullong(0xc0000000)
 
+/* 4GB @ 4GB Prefetch Memory for VPCI */
+#define GUEST_VPCI_ADDR_TYPE_PREFETCH_MEM   xen_mk_ullong(0x42000000)
+#define GUEST_VPCI_PREFETCH_MEM_ADDR        xen_mk_ullong(0x100000000)
+#define GUEST_VPCI_PREFETCH_MEM_SIZE        xen_mk_ullong(0x100000000)
+
 #define GUEST_RAM1_BASE   xen_mk_ullong(0x0200000000) /* 1016GB of RAM @ 8GB */
 #define GUEST_RAM1_SIZE   xen_mk_ullong(0xfe00000000)
 
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Fri Oct 15 16:53:37 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 16:53:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.210963.368018 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbQSe-00007E-2h; Fri, 15 Oct 2021 16:53:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 210963.368018; Fri, 15 Oct 2021 16:53:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbQSd-000074-W1; Fri, 15 Oct 2021 16:53:35 +0000
Received: by outflank-mailman (input) for mailman id 210963;
 Fri, 15 Oct 2021 16:53:35 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=1aKp=PD=gmail.com=andy.shevchenko@srs-us1.protection.inumbo.net>)
 id 1mbQSd-00006p-9Q
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 16:53:35 +0000
Received: from mail-ed1-x533.google.com (unknown [2a00:1450:4864:20::533])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 5fb46bc0-1163-4960-9021-3306e67006e7;
 Fri, 15 Oct 2021 16:53:34 +0000 (UTC)
Received: by mail-ed1-x533.google.com with SMTP id y30so22910749edi.0
 for <xen-devel@lists.xenproject.org>; Fri, 15 Oct 2021 09:53:34 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5fb46bc0-1163-4960-9021-3306e67006e7
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=DFAfhL2wTnA/x1oOiRIEIccRhRGZWYerK6em4KwuQr0=;
        b=WhznUYR2nkpwiwbTRwmHKoc047JsFdk3RvHIe/jtOLSDmdxX07MCX9Eow0Bi+yLoQp
         EyU08OzLxLG5ZCsUs7GUsgWdhql+ygc3SL2hgpQj7qkueaPaH4FCl+VEJFbTT66B35gH
         GDagaCdrbJmPFv3m1vjK25dlCo+SurtmwsJpbtn+lVZ1hUtQu8pPUJ/3APaMcce/rMb+
         gK4/JKJga2A5DLyU3cXWQ467mYYMbHs26I04bEcKD9mvTuveZ0BpijvVaw9Fg5WzWNNW
         l7COh3PfIisjI8gWM0rsyxYaukEsrZpFMim7hIuXFIwI4NkGZUXxkbzqxVTnksr3mpP4
         SUYg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=DFAfhL2wTnA/x1oOiRIEIccRhRGZWYerK6em4KwuQr0=;
        b=zXW59JpnuDXKIapTKzL11AZzoclk39l8OB7pOB29F14aZ9ZZTp11sYBCsdu35WulBP
         Wr4Nqm8Rb9n9f3DU8WOjUbD9L7/i7mL8hCCXo5fEXKM4mglJBr9vt+AHp3QJuF4SQbrH
         +/qGGqUrQZDxTfQgbmYEh3LIpE1PhC9d2aDKnO9O4pmUqLRJS75xhdJQjjn3dnXoApWs
         /sZqjt71HW5LfGLVwMt3qKYl1112CGiajPq4bA5LR1jP4XJHb/4V2FQ8R7Y2F9VZH3m/
         rRcLxahjVH/VKLkt957cZSTwJAs4uYBLBTWvuzkbD/an6S7ZiMFKQLSemZVzdDbNwKqF
         B6tw==
X-Gm-Message-State: AOAM53174cbMJje67L404c7JHVVbSutLTj9a3NDGWI+SpwlR7gDGk0k5
	Naetn0hs6eZFMP0FsZ4RdThk+4DD9YNar1B2HGE=
X-Google-Smtp-Source: ABdhPJw1GMYkf4/DzQ6xCdDldbViFURlmc0YnNdhDKa/6j1hrF7JWMyfM92nI6tIEj+fn7ChYTDQotvOC+uhf3cE48A=
X-Received: by 2002:a50:e188:: with SMTP id k8mr19911628edl.119.1634316813165;
 Fri, 15 Oct 2021 09:53:33 -0700 (PDT)
MIME-Version: 1.0
References: <YWbdvc7EWEZLVTHM@smile.fi.intel.com> <20211015164653.GA2108651@bhelgaas>
In-Reply-To: <20211015164653.GA2108651@bhelgaas>
From: Andy Shevchenko <andy.shevchenko@gmail.com>
Date: Fri, 15 Oct 2021 22:52:45 +0300
Message-ID: <CAHp75VdpVwvOkjDWHcnWA-qZFm062UBp7VwdcpWbkdVR=i75Hw@mail.gmail.com>
Subject: Re: [PATCH v6 00/11] PCI: Drop duplicated tracking of a pci_dev's
 bound driver
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= <u.kleine-koenig@pengutronix.de>, 
	linux-pci <linux-pci@vger.kernel.org>, Sascha Hauer <kernel@pengutronix.de>, 
	Alexander Duyck <alexanderduyck@fb.com>, 
	Alexander Shishkin <alexander.shishkin@linux.intel.com>, Andrew Donnellan <ajd@linux.ibm.com>, 
	Arnaldo Carvalho de Melo <acme@kernel.org>, Arnd Bergmann <arnd@arndb.de>, 
	Benjamin Herrenschmidt <benh@kernel.crashing.org>, Bjorn Helgaas <bhelgaas@google.com>, 
	Borislav Petkov <bp@alien8.de>, Boris Ostrovsky <boris.ostrovsky@oracle.com>, 
	"David S. Miller" <davem@davemloft.net>, Fiona Trahe <fiona.trahe@intel.com>, 
	Frederic Barrat <fbarrat@linux.ibm.com>, Giovanni Cabiddu <giovanni.cabiddu@intel.com>, 
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Herbert Xu <herbert@gondor.apana.org.au>, 
	"H. Peter Anvin" <hpa@zytor.com>, Ido Schimmel <idosch@nvidia.com>, Ingo Molnar <mingo@redhat.com>, 
	Jack Xu <jack.xu@intel.com>, Jakub Kicinski <kuba@kernel.org>, 
	Jesse Brandeburg <jesse.brandeburg@intel.com>, Jiri Olsa <jolsa@redhat.com>, 
	Jiri Pirko <jiri@nvidia.com>, Juergen Gross <jgross@suse.com>, 
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>, Marco Chiappero <marco.chiappero@intel.com>, 
	Mark Rutland <mark.rutland@arm.com>, Mathias Nyman <mathias.nyman@intel.com>, 
	Michael Buesch <m@bues.ch>, Michael Ellerman <mpe@ellerman.id.au>, Namhyung Kim <namhyung@kernel.org>, 
	"Oliver O'Halloran" <oohall@gmail.com>, Paul Mackerras <paulus@samba.org>, 
	Peter Zijlstra <peterz@infradead.org>, =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= <zajec5@gmail.com>, 
	Russell Currey <ruscur@russell.cc>, Salil Mehta <salil.mehta@huawei.com>, 
	Sathya Prakash <sathya.prakash@broadcom.com>, Simon Horman <simon.horman@corigine.com>, 
	Sreekanth Reddy <sreekanth.reddy@broadcom.com>, Stefano Stabellini <sstabellini@kernel.org>, 
	Suganath Prabu Subramani <suganath-prabu.subramani@broadcom.com>, 
	Taras Chornyi <tchornyi@marvell.com>, Thomas Gleixner <tglx@linutronix.de>, 
	Tomaszx Kowalik <tomaszx.kowalik@intel.com>, Vadym Kochan <vkochan@marvell.com>, 
	Wojciech Ziemba <wojciech.ziemba@intel.com>, Yisen Zhuang <yisen.zhuang@huawei.com>, 
	Zhou Wang <wangzhou1@hisilicon.com>, linux-crypto <linux-crypto@vger.kernel.org>, 
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, linux-perf-users@vger.kernel.org, 
	"open list:LINUX FOR POWERPC PA SEMI PWRFICIENT" <linuxppc-dev@lists.ozlabs.org>, linux-scsi <linux-scsi@vger.kernel.org>, 
	USB <linux-usb@vger.kernel.org>, 
	"open list:TI WILINK WIRELES..." <linux-wireless@vger.kernel.org>, MPT-FusionLinux.pdl@broadcom.com, 
	netdev <netdev@vger.kernel.org>, oss-drivers@corigine.com, qat-linux@intel.com, 
	"maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" <x86@kernel.org>, xen-devel@lists.xenproject.org
Content-Type: text/plain; charset="UTF-8"

On Fri, Oct 15, 2021 at 7:46 PM Bjorn Helgaas <helgaas@kernel.org> wrote:
> On Wed, Oct 13, 2021 at 04:23:09PM +0300, Andy Shevchenko wrote:

...

> so compared to Uwe's v6, I restored that section to the original code.
> My goal here was to make the patch as simple and easy to review as
> possible.

Thanks for elaboration. I have got it.

...

> You're right, this didn't make much sense in that patch.  I moved the
> line join to the previous patch, which unindented this section and
> made space for this to fit on one line.  Here's the revised commit:
>
>   https://git.kernel.org/cgit/linux/kernel/git/helgaas/pci.git/commit/?id=34ab316d7287

Side remark: default without break or return is error prone (okay, to
some extent). Perhaps adding the return statement there will make
things robust and clean.

-- 
With Best Regards,
Andy Shevchenko


From xen-devel-bounces@lists.xenproject.org Fri Oct 15 16:59:11 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 16:59:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.210976.368029 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbQXz-0000vz-Mo; Fri, 15 Oct 2021 16:59:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 210976.368029; Fri, 15 Oct 2021 16:59:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbQXz-0000vs-Jm; Fri, 15 Oct 2021 16:59:07 +0000
Received: by outflank-mailman (input) for mailman id 210976;
 Fri, 15 Oct 2021 16:59:06 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=gHjW=PD=citrix.com=anthony.perard@srs-us1.protection.inumbo.net>)
 id 1mbQXy-0000vm-Lv
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 16:59:06 +0000
Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id bd9ae0da-9023-48d0-94f0-081d59450ab9;
 Fri, 15 Oct 2021 16:59:04 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: bd9ae0da-9023-48d0-94f0-081d59450ab9
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1634317144;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=jBZndRRIyTWDv3s8jOCkMrX0hwxt3EJUrDq+/4qMEQs=;
  b=SaL/+EJG1LF+eM2aCSAuSQah7zDLm+ZXe15MuXBsYB7wOBXC88rhMgz6
   7n8qR2Ezt9E1KJW3tVZUN2o0CElx+hzqNY5ohjhiFLHcMk/8zkZmlMkco
   Mr7QILat1c4+Kgp9KcWamM/h9rO7F87uHf4JhzsbzCwNrasvl5Gs7lx4Y
   c=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: aOT8yUw6daduCZ7a82yy0Gf/AQsvQAhTmVdaBXu1VOxI+Mo2DCshT7qMJb/6K7sFiLnlr4YXQN
 IUwNTZKaO/2aHcKMdsFNG0lWTaTR7j9M/uelx2szjpGlTcIVBvmfSvmQwnPMBGgydKz12NB9UF
 3E5ixRI9nllDOBE+1YQgqCTP8DSUJPqLNj7l5b4nsll/2MHojqsHs7LTtL1PEFRDFwG2A0DScJ
 VZHcJvgETpEkRTQ/aflLSXIPq5t8hO4FZfu6RHBTUK3nuUhcG9qcgNaZTzV3hOXxqNBuTvrxZK
 X5OVIDxm3Vkn2jCNODbfHYq6
X-SBRS: 5.1
X-MesageID: 55337302
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:TmheZ6w4jlZ5/eei0mJ6t+dDwCrEfRIJ4+MujC+fZmUNrF6WrkVRm
 mJKDGiAPP+KZTf1fIwjaN+wpk8OvJKEm99kHVRl+yAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx
 59DAjUVBJlsFhcwnvopW1TYhSEUOZugH9IQM8aZfHAsLeNYYH1500s6w7dk2tQAbeWRWGthh
 /uj+6UzB3f9s9JEGjp8B3Wr8U4HUFza4Vv0j3RmDRx5lAa2e0o9VfrzEZqZPXrgKrS4K8bhL
 wr1IBNVyUuCl/slIovNfr8W6STmSJaKVeSFoiI+t6RPHnGuD8H9u0o2HKN0VKtZt9mGt+tzx
 Phvsp+McAA0P7PIgMREazNnIz4raMWq+JefSZS+mcmazkmAeHrw2fR+SkoxOOX0+M4uXzsIr
 6ZBbmlQMFbT3Ipaw5riIgVors0lMMnsOpJZonx6xCvVJf0nXYrCU+PB4towMDIY250VRqmFP
 5BxhTxHbgbZaD5GeXYuMYMkkeSjo1DRfiNYpwfAzUYwyzeKl1EguFT3C/LWfdqQTMkTgUecp
 UrB5W3yBhxcP9uaoRK79Xariv7KjDnMcosYH72l9dZnmFSWgGcUDXU+WVS3rPajg2aiStlfL
 AoS4SNooq8snGS7Q9+4UxCmrXqsuh8HR8EWA+A88BuKyKff/0CeHGdsZjJZc9knqM8eTCQnz
 EOUhMjuASFzsbqTUjSW8bL8hTKtOwAFIGkafygGQAAZpd75r+kbjBjCU9JiG66dlcDuFHf7x
 DXihCojg7Qei+Yb2qP9+krI6xqzorDZQwhz4R/YNkq+9R9wboOhY42u6HDY4OxGIYLfSUOO1
 EXogODHsrpIV8vU0nXQHqNdR9lF+sppLhXng1JCPZ4iyw2q5n+9eZhwuQlUG3d2Z5NslSDSX
 GffvgZY5Zl2NXSsbLNqb4/ZN/nG3ZQMBvy+CaiKNosmjoxZMVbdpnk3NBH4M3XFyRB0yckC1
 YGnndFA5JrwIZ9syyaqXK8j2LsvyzFWKYj7FM2jkUrPPVZzYheopVY53LmmMr9RAECs+ly9H
 zNj2y2ikEg3vArWOHi/zGLrBQpWRUXX/LivwyCtSsaNIxB9BEYqAOLLzLUqduRNxvoOyr2Tp
 CrgAx8CljITYEErzy3RNxiPj5u0Bf5CQY8TZ3RwbT5EJVByCWpQ0EvvX8RuJuR2nACS5fV1U
 +MEa6297gdnEVz6F8AmRcCl9uRKLU3z7SrXZnbNSGVvLvZIGl2Skve5L1SHycX7Jnfu3SfIi
 +b7jV2zrFtqb1kKMfs6n9r0kQ7v5yFGxr8rN6YKS/EKEHjRHEFRA3SZppcKzwskc30vHxOWi
 FSbBwk2v+7Ir9Nn+dXFn/nc/YyoD/F/DgxRGGyCteS6MizT/2yCx45cUbnXIWCBBT2soKjyN
 /9Iy/zcMeEcmAoYuYRLDLs2n7k14MHipuEGw108TmnLdVmiFphpPmKCgZtUrqRIy7IA4Vm2V
 0uD98N0I7KMPM+5QlcdKBB8NraI1O0OmymU5vMweR2o6Chy9buBcENTIxjT13ANcOoraNsom
 L5zttQX5gqzjgsRHuyH1i0EpX6RKnEgUrk8ss1ICoHclQd2mEpJZobRC3Gq7cjXOclMKEQjP
 hSdmLHG2+ZH3kPHfnc+SSrN0O5aichcsRxG1gZfdVGAm96Djf4rxhxBtz8wS10NnBlA1utyP
 EltNlF0evrSr2s52pAbUjD+ARxFCT2Y5lf1mgkAm2DuRkW1UnDAcT8mMuGX8UFFq29Rc1C3J
 l1DJLoJhdoyQPzM4w==
IronPort-HdrOrdr: A9a23:8mhadaOLGLTQXsBcTsOjsMiBIKoaSvp037Eqv3oRdfVwSL3+qy
 nOpoV+6faaslossR0b9uxofZPwJ080lqQFhLX5X43SPzUO0VHAROoJgLcKgQeQeREWntQtrJ
 uIGJIfNDSfNzZHsfo=
X-IronPort-AV: E=Sophos;i="5.85,376,1624334400"; 
   d="scan'208";a="55337302"
Date: Fri, 15 Oct 2021 17:58:50 +0100
From: Anthony PERARD <anthony.perard@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, George Dunlap
	<george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>, Julien Grall
	<julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>, Wei Liu
	<wl@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, Roger Pau
 =?iso-8859-1?Q?Monn=E9?= <roger.pau@citrix.com>, Konrad Rzeszutek Wilk
	<konrad.wilk@oracle.com>, Ross Lagerwall <ross.lagerwall@citrix.com>, "Daniel
 De Graaf" <dgdegra@tycho.nsa.gov>, "Daniel P. Smith"
	<dpsmith@apertussolutions.com>, <xen-devel@lists.xenproject.org>
Subject: Re: [XEN PATCH v7 49/51] build: adding out-of-tree support to the
 xen build
Message-ID: <YWmzSkLdH5wtQ77V@perard>
References: <20210824105038.1257926-1-anthony.perard@citrix.com>
 <20210824105038.1257926-50-anthony.perard@citrix.com>
 <2aaf0858-1602-be5c-77e4-2daa7fddc534@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <2aaf0858-1602-be5c-77e4-2daa7fddc534@suse.com>

On Thu, Oct 14, 2021 at 12:14:29PM +0200, Jan Beulich wrote:
> On 24.08.2021 12:50, Anthony PERARD wrote:
> > This implement out-of-tree support, there's two ways to create an
> > out-of-tree build tree (after that, `make` in that new directory
> > works):
> >     make O=build
> >     mkdir build; cd build; make -f ../Makefile
> > also works with an absolute path for both.
> > 
> > This implementation only works if the source tree is clean, as we use
> > VPATH.
> > 
> > This patch copies most new code with handling out-of-tree build from
> > Linux v5.12.
> > 
> > Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
> > ---
> >  xen/Makefile                | 173 +++++++++++++++++++++++++++++-------
> >  xen/Rules.mk                |  11 ++-
> >  xen/arch/arm/efi/Makefile   |   3 +
> >  xen/arch/x86/arch.mk        |   3 +
> >  xen/arch/x86/boot/Makefile  |   5 +-
> >  xen/arch/x86/efi/Makefile   |   3 +
> >  xen/include/Makefile        |   9 +-
> >  xen/scripts/mkmakefile      |  17 ++++
> >  xen/test/livepatch/Makefile |   2 +
> >  xen/xsm/flask/Makefile      |   3 +
> >  xen/xsm/flask/ss/Makefile   |   3 +
> >  11 files changed, 194 insertions(+), 38 deletions(-)
> >  create mode 100755 xen/scripts/mkmakefile
> 
> Linux have done away with this script just recently; I don't think we
> should introduce it.

Will change.

> > --- a/xen/Makefile
> > +++ b/xen/Makefile
> > @@ -1,3 +1,7 @@
> > +# $(lastword,) for GNU Make older than 0.81
> 
> DYM 3.81?

Yes.

> > +lastword = $(word $(words $(1)),$(1))
> > +this-makefile := $(call lastword,$(MAKEFILE_LIST))
> 
> Oh - is it documented somewhere that this would always be last?

Yes, it is even in Make's documentation about the variable:
    "if the first thing a makefile does is examine the last word in this
    variable, it will be the name of the current makefile."
    (taken from Make 3.80 documentation)

> > @@ -17,33 +21,18 @@ export XEN_BUILD_HOST	?= $(shell hostname)
> >  PYTHON_INTERPRETER	:= $(word 1,$(shell which python3 python python2 2>/dev/null) python)
> >  export PYTHON		?= $(PYTHON_INTERPRETER)
> >  
> > -export XEN_ROOT := $(CURDIR)/..
> > +$(if $(filter __%, $(MAKECMDGOALS)), \
> > +	$(error targets prefixed with '__' are only for internal use))
> >  
> > -srctree := .
> > -objtree := .
> > -export srctree objtree
> > +# That's our default target when none is given on the command line
> > +PHONY := __all
> > +__all:
> >  
> >  # Do not use make's built-in rules and variables
> >  MAKEFLAGS += -rR
> >  
> >  EFI_MOUNTPOINT ?= $(BOOT_DIR)/efi
> >  
> > -ARCH=$(XEN_TARGET_ARCH)
> > -SRCARCH=$(shell echo $(ARCH) | \
> > -          sed -e 's/x86.*/x86/' -e s'/arm\(32\|64\)/arm/g' \
> > -              -e s'/riscv.*/riscv/g')
> > -export ARCH SRCARCH
> > -
> > -# Don't break if the build process wasn't called from the top level
> > -# we need XEN_TARGET_ARCH to generate the proper config
> > -include $(XEN_ROOT)/Config.mk
> > -
> > -# Set ARCH/SUBARCH appropriately.
> > -export TARGET_SUBARCH  := $(XEN_TARGET_ARCH)
> > -export TARGET_ARCH     := $(shell echo $(XEN_TARGET_ARCH) | \
> > -                            sed -e 's/x86.*/x86/' -e s'/arm\(32\|64\)/arm/g' \
> > -                                -e s'/riscv.*/riscv/g')
> > -
> >  # Allow someone to change their config file
> >  export KCONFIG_CONFIG ?= .config
> 
> Would it be possible to split off some of the pure movement of pieces,
> to make it easier to see what (if anything) is actually changed at the
> same time as getting moved?

I'll give it a try.

> > @@ -51,14 +40,9 @@ export CC CXX LD
> >  
> >  export TARGET := xen
> >  
> > -.PHONY: default
> > -default: build
> > -
> >  .PHONY: dist
> >  dist: install
> >  
> > -include scripts/Kbuild.include
> > -
> >  ifneq ($(root-make-done),y)
> >  # section to run before calling Rules.mk, but only once.
> >  
> > @@ -130,14 +114,93 @@ endif
> >  
> >  ifneq ($(findstring s,$(filter-out --%,$(MAKEFLAGS))),)
> >      quiet := silent_
> > +    KBUILD_VERBOSE = 0
> >  endif
> 
> In how far is this related here? Doesn't this belong in an earlier patch?

That probably belong to a patch that have been committed some time ago,
and I've notice it was missing when comparing our makefile to Linux's
one. (Or maybe it wasn't set as well in Linux originally). I'll look if
that can be added to another patch, or just have a patch for this single
line.

> > --- a/xen/Rules.mk
> > +++ b/xen/Rules.mk
> > @@ -38,7 +38,7 @@ SPECIAL_DATA_SECTIONS := rodata $(foreach a,1 2 4 8 16, \
> >                           $(foreach r,rel rel.ro,data.$(r).local)
> >  
> >  # The filename build.mk has precedence over Makefile
> > -mk-dir := $(src)
> > +mk-dir := $(srctree)/$(src)
> >  include $(if $(wildcard $(mk-dir)/build.mk),$(mk-dir)/build.mk,$(mk-dir)/Makefile)
> 
> Perhaps already when it was changed to $(src) the name has become
> slightly misleading, at least imo: I would rather expect a variable
> with this name to refer to the build dir/tree. Maybe "srcdir" or
> even shorted "sd" right from the start? (Reaching here I can finally
> see why having a shorthand is helpful.)

I have to think about that. I've made some further progress in order to
be able to build the Xen pvhshim without a link farm and notice that
nearly every source file needs to use "$(srctree)/$(src)" and I'm not
sure "$(src)" could be use alone. So having a single variable which have
both would be useful.

"srcdir" might be to close to "srctree" and one might mistake it for the
other, so "sd" might be better.

> > --- a/xen/arch/x86/efi/Makefile
> > +++ b/xen/arch/x86/efi/Makefile
> > @@ -1,5 +1,8 @@
> >  CFLAGS-y += -fshort-wchar
> >  CFLAGS-y += -I$(srctree)/common/efi
> > +ifdef building_out_of_srctree
> > +CFLAGS-y += -I$(srctree)/$(src)
> > +endif
> 
> At the example of this (where perhaps -iquote could be used again) - is
> it strictly necessary to have the ifdef-s around such? I.e. would things
> fail to work for an in-tree build without them?

ifdef isn't really necessary, gcc always check that directory first
anyway (for quote-included headers), so it is just a duplicate of gcc's
path list, but it would work fine. So I'll remove the ifdef.

> > --- a/xen/xsm/flask/ss/Makefile
> > +++ b/xen/xsm/flask/ss/Makefile
> > @@ -9,3 +9,6 @@ obj-y += conditional.o
> >  obj-y += mls.o
> >  
> >  CFLAGS-y += -I$(srctree)/xsm/flask/include
> > +ifdef building_out_of_srctree
> > +    CFLAGS-y += -I$(objtree)/xsm/flask/include
> 
> There's no header in $(srctree)/xsm/flask/include in this case, so if you
> use "ifdef" here, shouldn't that other part move into an "else"?

Actually, there are headers in the source, like "security.h", and `git
ls-files xen/xsm/flask/include` shows plenty other headers.

Thanks,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Fri Oct 15 17:02:31 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 17:02:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.210987.368041 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbQbE-0002PS-DD; Fri, 15 Oct 2021 17:02:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 210987.368041; Fri, 15 Oct 2021 17:02:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbQbE-0002PL-9v; Fri, 15 Oct 2021 17:02:28 +0000
Received: by outflank-mailman (input) for mailman id 210987;
 Fri, 15 Oct 2021 17:02:26 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=gHjW=PD=citrix.com=anthony.perard@srs-us1.protection.inumbo.net>)
 id 1mbQbC-0002PF-R6
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 17:02:26 +0000
Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id abb0f7c0-2dd9-11ec-8249-12813bfff9fa;
 Fri, 15 Oct 2021 17:02:26 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: abb0f7c0-2dd9-11ec-8249-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1634317345;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=PWItVNv2zL0AmFxuoq1ed8CdUkJBfgbTzOjCaui87yE=;
  b=ZtkXsT837z7kdNEam8fugpgX0EOvWMxPaDZC+YAbwF2ipvWbB+ePG9Oj
   5yXl8JeCrsl8b76/w1nywYZlBtIO9VCV/oycjBumE2LYPmQ0wJWtioXOB
   kanU0WFOesudiSsoBFkDYM4HoVsUojrT2tydZ94YqjjLifsKTU73xE9rj
   A=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: VSMIolyxUBBZgOqgJnaA3T0UDKiZH8QDDSA3/AqBPUwqO6nrAqNEokjaxcAKjwQlbZJyRwnQRa
 b5RFEVPk2zaxoyyaiM6bFiMjXfrY41Mu5c+K/r+PaKMjVySW+LJefjrAGMfiHWB/JxJcklDEkq
 orOVy7ECjIWWhwNSB5onmPwJEBDwwT9h03Ulu0VD7YACjl9uJBD4z08tPfsKMF5hGkmhic/+eX
 zA+9NWJOukX/emylIjZIUZsNErJMwcftJZfX5yezhJVHHuirXJK3O102c66n3tb1xKDXdQY4Ok
 RLOxu1+wS7znAcjIdyiGCIx8
X-SBRS: 5.1
X-MesageID: 55337651
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:RxUluqAeGqsi6RVW/6Tkw5YqxClBgxIJ4kV8jS/XYbTApDsl3jJWy
 WsYX2vUPPaNN2qgeox2PIrl/U9QvpeBz9ZlQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA
 xA2M4GYRCwMo/u1Si6FatANl1ElvU2zbue6WLOs1hxZH1c+EX550E87wYbVv6Yz6TSHK1LV0
 T/Ni5W31G+Ng1aY5UpNtspvADs21BjDkGtwUm4WPJinj3eH/5UhN7oNJLnZEpfNatI88thW5
 Qr05OrREmvxp3/BAz4++1rxWhVirrX6ZWBihpfKMkQLb9crSiEai84G2PQghUh/hhi2p4Bt6
 O539rOsYxgDJPP0tcJaekwNe81+FfUuFL7vJHG+tYqYzlHccmuqyPJrZK00FdRGoKAtWzgIr
 KFGbmBWBvyAr7veLLaTQ+9whsMlPY/zMZkWoH1IxjDFF/c2B5vERs0m4PcFgWxr2Z4TRJ4yY
 eJBciFeQRHASidNHXolS5gXwdeEhWbGJmgwRFW9+vNsvjm7IBZK+KP2LNPfd9iORMNUtkWVv
 GTL+yL+GB5yHMOb4SqI9DSrnOCntTP2XsceGaO18tZugUaP3SoDBRsOT1y5rPKlzEmkVLp3K
 UYZ5y4vpqga71GwQ5/2WBjQiH+bvDYMVtxICeo45QqRjK3O7G6xBHUATzNHQMwrsokxXzNC6
 7OSt4q3X3o16uTTEC/DsOfPxd+vBcQLBWIvWhdUUSs+2ZrMvKsspAiRdvtFV4fg27UZBgrM6
 zyNqSE/gZAagsgKy7i38Dj7vt68mnTaZlVqvluPDwpJ+is8PdT/P9X5tjA3+N4ZdN7BJmRtq
 kTojCR3AAomNpqKiDCWCNsEGLWk9p5p2xWN3AYxQfHNG9mrkkNPnLy8Ahkiey+F0e5eIFcFh
 XM/XysKufe/21PwPMdKj3qZUZhC8EQZPY2NugroRtRPeINtUwSM4TtjY0Wdt0i0zhNwy/plY
 srCIZzyZZr/NUiB5GHrLwv6+eRzrh3SOEuJHcyrp/hZ+ev2iIGppUctbwLVM7FRAFKsqwTJ6
 ddPX/ZmOD0EONASlhL/qNZJRXhTdCBTLcmv96R/K77SSiI7STpJI6KAntscl3lNwv09ehHgp
 SrmBCe1CTPX2BX6FOl9Qis9Ne21BM0h8CtT0O5FFQ/A5kXPqL2HtM83H6bbt5F8nAC65fIrH
 fQDZeuaBfFDFmbO9zgHNMGvp41+bhW7wwmJOnP9MjQ4epdhQS3P+8PlIVSzpHVfUHLvuJtsu
 aCk2yPaXYEHG1ZoAvHJZa/91Fi2p3Ucxr5/BhOaPtlJdUzw24F2MCit3OQvKsQBJEyblDuX3
 gqbGzkCouzJr9Nn+dXFn/nc/YyoD/F/DgxRGGyCteS6MizT/2yCx45cUbnXIWCBBT2soKj7P
 Ldb1fDxNvEDjW1miYskHuY517866vvuu6ReklZuEkLUYgn5EbhnOHSHg5VC7/Uf2r9DtAKqc
 UuT4d0Ga66RMcboHVNNdgooauOPiaMdljXItKlnJUz74Gl8/aadUFUUNB6J0XQPILxwOYIj4
 OEgpM9JtFDv1kt0ao6L3nJO6mCBDn0cSKF25JgVDbjihhcv1lwfM4fXDTX74c3XZthBWqXwz
 uR4WEYWa2xg+3f/
IronPort-HdrOrdr: A9a23:jzPyral+OontyQAx/gsQErfMdQDpDfLW3DAbv31ZSRFFG/Fw9/
 rCoB3U73/JYVcqKRUdcLW7UpVoLkmyyXcY2+cs1NSZLWzbUQmTXeJfBOLZqlWNJ8SXzIVgPM
 xbAspD4bPLbGSTjazBkXSF+9RL+qj6zEh/792usEuETmtRGt9dBx8SMHf9LqXvLjM2fqbQEv
 Cnl6x6jgvlQ1s7ROKhCEIIWuDSzue77q4PMXY9dmcaABDlt0LR1ILH
X-IronPort-AV: E=Sophos;i="5.85,376,1624334400"; 
   d="scan'208";a="55337651"
Date: Fri, 15 Oct 2021 18:02:06 +0100
From: Anthony PERARD <anthony.perard@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, George Dunlap
	<george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>, Julien Grall
	<julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>, Wei Liu
	<wl@xen.org>, <xen-devel@lists.xenproject.org>
Subject: Re: [XEN PATCH v7 50/51] build: specify source tree in include/ for
 prerequisite
Message-ID: <YWm0DgfR5XyD1CCj@perard>
References: <20210824105038.1257926-1-anthony.perard@citrix.com>
 <20210824105038.1257926-51-anthony.perard@citrix.com>
 <d9591c5f-9cff-e135-1d1e-c79a82095da7@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <d9591c5f-9cff-e135-1d1e-c79a82095da7@suse.com>

On Thu, Oct 14, 2021 at 12:19:06PM +0200, Jan Beulich wrote:
> On 24.08.2021 12:50, Anthony PERARD wrote:
> > When doing an out-of-tree build, and thus setting VPATH,
> > GNU Make 0.81 on Ubuntu Trusty complains about Circular dependency of
> > include/Makefile and include/xlat.lst and drop them. The build fails
> > later due to headers malformed.
> 
> Doesn't this change need to come ahead of the one enabling out-of-tree
> builds then?

Probably yes, I've work this patch as a fix. I'll try to make the change
earlier.

> Also do you again mean 3.81?

Indeed.

Thanks,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Fri Oct 15 17:25:34 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 17:25:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.210998.368052 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbQxT-0004nR-6Y; Fri, 15 Oct 2021 17:25:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 210998.368052; Fri, 15 Oct 2021 17:25:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbQxT-0004nK-3K; Fri, 15 Oct 2021 17:25:27 +0000
Received: by outflank-mailman (input) for mailman id 210998;
 Fri, 15 Oct 2021 17:25:25 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mbQxR-0004nE-Py
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 17:25:25 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mbQxQ-0001Yi-GW; Fri, 15 Oct 2021 17:25:24 +0000
Received: from [54.239.6.185] (helo=[192.168.0.140])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mbQxQ-0005QR-9l; Fri, 15 Oct 2021 17:25:24 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=7sSLGKOU3aysiKP+Wl2yfjUUJ+GBcj+e9bj2WiEMcBU=; b=BvoxRQakAuLmWNXGr2NZrvAWjx
	D8XVq101RuVw4Jqd/QqCoIoNvqCy8rRHCjireFw8USoalj67wtgri1P8Z0vm8YiVT5czcpOSznsBn
	kU5HstDVgDqSGnejdMP+JUB95RC1je5+zvJJ8zA0YeW00HS7KkmAARKX+Q6xWhyhcN98=;
Message-ID: <cef8d2a6-91c1-2d4d-2078-98d0a92b067a@xen.org>
Date: Fri, 15 Oct 2021 18:25:21 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.2.0
Subject: Re: [PATCH v8 2/5] xen/arm: Enable the existing x86 virtual PCI
 support for ARM
To: Bertrand Marquis <bertrand.marquis@arm.com>,
 xen-devel@lists.xenproject.org
Cc: iwj@xenproject.org, sstabellini@kernel.org,
 Rahul Singh <rahul.singh@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Wei Liu <wl@xen.org>, Paul Durrant <paul@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <cover.1634315461.git.bertrand.marquis@arm.com>
 <e2b10f56043155e4bb8eae824723045ccc042f8e.1634315461.git.bertrand.marquis@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <e2b10f56043155e4bb8eae824723045ccc042f8e.1634315461.git.bertrand.marquis@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Bertrand,

On 15/10/2021 17:51, Bertrand Marquis wrote:
> diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci.c
> index 3aa8c3175f..35e0190796 100644
> --- a/xen/drivers/passthrough/pci.c
> +++ b/xen/drivers/passthrough/pci.c
> @@ -756,6 +756,19 @@ int pci_add_device(u16 seg, u8 bus, u8 devfn,
>       if ( !pdev->domain )
>       {
>           pdev->domain = hardware_domain;
> +#ifdef CONFIG_ARM
> +        /*
> +         * On ARM PCI devices discovery will be done by Dom0. Add vpci handler
> +         * when Dom0 inform XEN to add the PCI devices in XEN.
> +         */
> +        ret = vpci_add_handlers(pdev);

I don't seem to find the code to remove __init_hwdom in this series. Are 
you intending to fix it separately?

With that addressed:

Acked-by: Julien Grall <jgrall@amazon.com>

Cheers,


-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Oct 15 17:34:03 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 17:34:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.211005.368062 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbR5d-0006D7-02; Fri, 15 Oct 2021 17:33:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 211005.368062; Fri, 15 Oct 2021 17:33:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbR5c-0006D0-TS; Fri, 15 Oct 2021 17:33:52 +0000
Received: by outflank-mailman (input) for mailman id 211005;
 Fri, 15 Oct 2021 17:33:51 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Fqmt=PD=arm.com=Bertrand.Marquis@srs-us1.protection.inumbo.net>)
 id 1mbR5b-0006Cu-Nv
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 17:33:51 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com (unknown
 [40.107.7.42]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 0e8b40bb-2dde-11ec-824b-12813bfff9fa;
 Fri, 15 Oct 2021 17:33:50 +0000 (UTC)
Received: from AM6PR10CA0063.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:209:80::40)
 by DB8PR08MB5372.eurprd08.prod.outlook.com (2603:10a6:10:f9::17) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.17; Fri, 15 Oct
 2021 17:33:48 +0000
Received: from VE1EUR03FT046.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:209:80:cafe::46) by AM6PR10CA0063.outlook.office365.com
 (2603:10a6:209:80::40) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.14 via Frontend
 Transport; Fri, 15 Oct 2021 17:33:47 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT046.mail.protection.outlook.com (10.152.19.226) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.15 via Frontend Transport; Fri, 15 Oct 2021 17:33:46 +0000
Received: ("Tessian outbound b9598e0ead92:v103");
 Fri, 15 Oct 2021 17:33:46 +0000
Received: from c9330f0657f9.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 2876D7B0-E2F8-43DA-A934-B564E54DBF49.1; 
 Fri, 15 Oct 2021 17:33:35 +0000
Received: from EUR02-HE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id c9330f0657f9.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 15 Oct 2021 17:33:35 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com (2603:10a6:4:74::9)
 by DB6PR0802MB2184.eurprd08.prod.outlook.com (2603:10a6:4:83::18) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.22; Fri, 15 Oct
 2021 17:33:30 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955]) by DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955%4]) with mapi id 15.20.4587.031; Fri, 15 Oct 2021
 17:33:30 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0e8b40bb-2dde-11ec-824b-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=NS8KAcOWF2xF+shDD8oVA0iXat1AOs8G2IynsaTEqM0=;
 b=1vS/i2BKYyA39yrE+hzXSXaEq+M2k4xk5z6Ov/oA9SlLxlBjfwjvrwkPstG6y6joQBke4J3wZXTREj49zrXTpB6tywbimsk/kRN+gSd116/bkct8ZExhuKUaGrKrZAhiBVLmMhX7pkPAUzM3EK5xZzqfeLs6r0OP7BIxC+WJmp0=
X-MS-Exchange-Authentication-Results: spf=temperror (sender IP is
 63.35.35.123) smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass
 (signature was verified) header.d=armh.onmicrosoft.com;lists.xenproject.org;
 dmarc=temperror action=none header.from=arm.com;
Received-SPF: TempError (protection.outlook.com: error in processing during
 lookup of arm.com: DNS Timeout)
X-CheckRecipientChecked: true
X-CR-MTA-CID: 10ce6eb8437c2f31
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=gL+HamsuZtbX9xkuTYEz4dEva8MGvYiMdMpJA3BvL5iDTnJamScoA4BSo0kqLEd+i4hV+B0z60zqlLSmVgWIt6OzPoyZ5p2vctSbJV7VlTCgUBJhuSUo6lOMowIfD/rTHGzeGUgUSMDLmrE03v02PSuzDU3i8a2zf/7mlQBNIy5PfClhsl6J6/xTJmMdv/JDrz9Y9QkoHRYQFyenGNCUNFldVapGFCechVrHCw0SCDlCCBW01RL/DVUIbUh3Zn7jSpJNiVzc80DXbObSC6RVvll0RGD1lQ1kMx+TUa1ciMTUWtIGyg789sh/Sb/065zBk4+EYv8az1/I1m806ZtNMQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=NS8KAcOWF2xF+shDD8oVA0iXat1AOs8G2IynsaTEqM0=;
 b=PJXQBKv8Jy/VUkADUAMkYBjAwiW3KCtCCE8xVywuXVLxLg+nLoMo8XdxvRNwEbSQ33wor3vMzBIVjcojzwhJfr+DzjDaPUgHxjV1UvJ/OCuTx0XWdOE+q/6I+c4SV0C0eX+c7CMjpgMi2qywZzgy7X36XETcQwX/5kZTwPBcobgYswg1OIDYPQ9ppUgCf3CtKSGWYv6k4YcBqVSs5lgBgjH14XOCEgZp8ZHuIEPsRWFxUVEpu9zZxHYCv7ZtySkKZUvsSIZ7iryKoH52V/DUKG1/rcom0ki0fDTFmsgSWo6SL7ZkqhU+BFGPTOIaqjPhQC0Aqc/Q9dAzBGGp28NeXg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=NS8KAcOWF2xF+shDD8oVA0iXat1AOs8G2IynsaTEqM0=;
 b=1vS/i2BKYyA39yrE+hzXSXaEq+M2k4xk5z6Ov/oA9SlLxlBjfwjvrwkPstG6y6joQBke4J3wZXTREj49zrXTpB6tywbimsk/kRN+gSd116/bkct8ZExhuKUaGrKrZAhiBVLmMhX7pkPAUzM3EK5xZzqfeLs6r0OP7BIxC+WJmp0=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Julien Grall <julien@xen.org>
CC: Xen-devel <xen-devel@lists.xenproject.org>, "iwj@xenproject.org"
	<iwj@xenproject.org>, "sstabellini@kernel.org" <sstabellini@kernel.org>,
	Rahul Singh <Rahul.Singh@arm.com>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
	Wei Liu <wl@xen.org>, Paul Durrant <paul@xen.org>,
	=?iso-8859-1?Q?Roger_Pau_Monn=E9?= <roger.pau@citrix.com>
Subject: Re: [PATCH v8 2/5] xen/arm: Enable the existing x86 virtual PCI
 support for ARM
Thread-Topic: [PATCH v8 2/5] xen/arm: Enable the existing x86 virtual PCI
 support for ARM
Thread-Index: AQHXweULx+Lzp09rU0elFmx0jxVt5qvUT3iAgAACRwA=
Date: Fri, 15 Oct 2021 17:33:30 +0000
Message-ID: <F447A1D8-A023-4127-AAC0-7511868DE9C4@arm.com>
References: <cover.1634315461.git.bertrand.marquis@arm.com>
 <e2b10f56043155e4bb8eae824723045ccc042f8e.1634315461.git.bertrand.marquis@arm.com>
 <cef8d2a6-91c1-2d4d-2078-98d0a92b067a@xen.org>
In-Reply-To: <cef8d2a6-91c1-2d4d-2078-98d0a92b067a@xen.org>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3654.120.0.1.13)
Authentication-Results-Original: xen.org; dkim=none (message not signed)
 header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: 8c1d6db0-4e32-4100-28d8-08d99001f132
x-ms-traffictypediagnostic: DB6PR0802MB2184:|DB8PR08MB5372:
x-ms-exchange-transport-forked: True
X-Microsoft-Antispam-PRVS:
	<DB8PR08MB537239D156A9F2245E1B19B09DB99@DB8PR08MB5372.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:8882;OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 a95dD96Bvl9VrHsNI5dwx88VGNbLtyp0Qc4naH7S2lvdnRhoq2ADfoO9Qd5RWuh27QI7oArAvc7JQtNyb850MJ5YT4yZAK4tY2uIW9EIKLLuj0qoDLFY50g7PSdp+5rRHmZRHsK2G+bXycKidCKi/SdBxvSn4U4RlSRBdv42/zh4bX9VaBHv+EJQC6B/GTNgfv8Cy+wyn0ebX4uXa6+IsPJFhGFmYf5G1ykScllT9p8yS3zJzAKdZfVi0ARY2JltKzEJj4LoSsOh16i6gSoK8kKEyWl31xpmk0rS0v/v4LoupzLwLdF+qu44VJqcmSi9HPZexbIaAiAYMzLkN/Ply/B4IVQspQQnKjaQhDfV75abIf4fy5Jm7BvNCpf/u8DM325AH04wMXF5bKBe4jzNtPLVcJjIk67kVXNZaGOx4XTOpa3gcNMtXABpK7ro42gM0Mzqw6mAO32Ydf8kWRYkrPUVihul2wc85a1YpWJnXz2opmwLoOsz/EARzVvlosleKqb1dF5nZssPuwZuNxz3DtAeIS1SG87xabu8TaVJOezjYGG5Lj9zbOY2wasneq4vKUhTRP/bsyoJpasqRxDl/9bYQsUe6BkbSrXBKgKDYIbtTi2JfZ392JihTGt23YC4nhM+8JQs/1K7ftr69XHn9sC4nVK+HJ8n0dAPObroyanqODSF13YI0IuNO7BFXoxHNyF2m7rV5glds/RDOd2rkkh3zxoEl9s/vwQkMfhrIjuX4Bu/YNSRWbnRVgMAscwL
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB6PR0801MB2024.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(66476007)(8936002)(64756008)(33656002)(2616005)(6916009)(8676002)(5660300002)(66946007)(76116006)(4326008)(2906002)(86362001)(91956017)(66556008)(38070700005)(54906003)(38100700002)(316002)(122000001)(66446008)(6486002)(6506007)(53546011)(186003)(71200400001)(26005)(36756003)(7416002)(508600001)(6512007)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="iso-8859-1"
Content-ID: <058A6F800BCFDD4A96D6FA07646F6054@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0802MB2184
Original-Authentication-Results: xen.org; dkim=none (message not signed)
 header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT046.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	b3dfc17f-8f61-437b-04a0-08d99001e79d
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	vtCdAZ9GceyiMa7cA8oWlD4oVVdj+Flt/SNnMcWq3KXr16iFBKmp/Fni1oXuCcmp5d5RWzCSbKQKbN8NfLnzMvyNrzFOLo7wGWqg8LNlfkxsaApwLjP+5+beK4kczu5ANCkStLRkZq5WR6DGU2tm8OG8RWDcebRJDmzCgx/qYAzOMjt5Qdv4JcNiyvjE0KRiiWrn1xM739sJ5AWGrvvWvRE3xhaD098hkB8jhizZEK0+EE+czwZd4taLiKhSCS6CHTU/Se/vBM0aZz/tNAvU91VEihq0aQL5S+weJ3SFBU/ne2W6ZRVz2VW+gwCyRXDDlZGeG2ePW1DSrNrNehH5FXOsVDxCogkwHWaP5YOm22iym9v5ftppO/vtQdZT6BpxcVuV3U/YGmMBUjgeI9WKiJzI6npY52wLTjNyA6+Fw3qDf4ue40XjXT+UBcDETNqTHyOSJLXOLB9Vpp0IK/WCyVTXpmj648myFR7DYC7Lw8vPRQyEIF4LmGnKx8FUS4Z2PzJDQNvUji6tarjMlyGmDu8koTfl496L6obMmFMCTkPO9CIPB9gGvnBF6yKFqdtwpYZP4fPHAyDc6HhRSolmye0yGN4HN4131sXkcyIV9v7U7mn6pVgOHep3WYJF8J0HbXiB8IXq9alN9TA7uc3IX6QQasYd+ZhMsdRZ0aH6nugo9MePoBKl+gOpTBkUDlP27d35LUi9mDnrJuS3DAb2OVD7qd5ST0ILAcE7cCgz3AQ=
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(47076005)(82310400003)(8936002)(63370400001)(508600001)(6486002)(4326008)(70206006)(5660300002)(2906002)(63350400001)(107886003)(36756003)(6512007)(70586007)(186003)(2616005)(53546011)(6506007)(316002)(6862004)(54906003)(8676002)(356005)(33656002)(81166007)(36860700001)(86362001)(336012)(26005)(45980500001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2021 17:33:46.4529
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 8c1d6db0-4e32-4100-28d8-08d99001f132
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT046.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB5372

Hi Julien,

> On 15 Oct 2021, at 18:25, Julien Grall <julien@xen.org> wrote:
>=20
> Hi Bertrand,
>=20
> On 15/10/2021 17:51, Bertrand Marquis wrote:
>> diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci=
.c
>> index 3aa8c3175f..35e0190796 100644
>> --- a/xen/drivers/passthrough/pci.c
>> +++ b/xen/drivers/passthrough/pci.c
>> @@ -756,6 +756,19 @@ int pci_add_device(u16 seg, u8 bus, u8 devfn,
>>      if ( !pdev->domain )
>>      {
>>          pdev->domain =3D hardware_domain;
>> +#ifdef CONFIG_ARM
>> +        /*
>> +         * On ARM PCI devices discovery will be done by Dom0. Add vpci =
handler
>> +         * when Dom0 inform XEN to add the PCI devices in XEN.
>> +         */
>> +        ret =3D vpci_add_handlers(pdev);
>=20
> I don't seem to find the code to remove __init_hwdom in this series. Are =
you intending to fix it separately?

Yes I think it is better to fix that in a new patch as it will require some=
 discussion as it will impact the x86 code if I just remove the flag now.


>=20
> With that addressed:
>=20
> Acked-by: Julien Grall <jgrall@amazon.com>
>=20

Thanks
Bertrand

> Cheers,
>=20
>=20
> --=20
> Julien Grall



From xen-devel-bounces@lists.xenproject.org Fri Oct 15 17:50:51 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 17:50:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.211015.368074 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbRLx-00008k-FC; Fri, 15 Oct 2021 17:50:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 211015.368074; Fri, 15 Oct 2021 17:50:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbRLx-00008d-C3; Fri, 15 Oct 2021 17:50:45 +0000
Received: by outflank-mailman (input) for mailman id 211015;
 Fri, 15 Oct 2021 17:50:44 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mbRLw-00008T-7L; Fri, 15 Oct 2021 17:50:44 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mbRLv-0001yd-V4; Fri, 15 Oct 2021 17:50:43 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mbRLv-0000w5-Na; Fri, 15 Oct 2021 17:50:43 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mbRLv-0007hL-N5; Fri, 15 Oct 2021 17:50:43 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=f+YAdhseczWiuqVlHMG1TDgu2HQzuPzxBZzy0qIo7f4=; b=h7y8xM3abr60Z0UEswuH3vDZI5
	NDUYqx97UTw4+uXLYwDOXB5TSJ8IS2zxwC6SsgdR0+jjr/+e5JrYW5OrcgmxnbMsDxwuuUwRYu3vE
	Hpk0Xq51lRd+NwJDBJb4itWTcK/cWLcLt6HbvhRI6lytsqKKkKtOwak8dzZw1wOHJbtI=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165527-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 165527: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=f791392f82ffe39cc1ea4c4db1d877223754a04a
X-Osstest-Versions-That:
    xen=9f4f20b27b0733e9b792e3cd2ad996febdea46ba
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 15 Oct 2021 17:50:43 +0000

flight 165527 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165527/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  f791392f82ffe39cc1ea4c4db1d877223754a04a
baseline version:
 xen                  9f4f20b27b0733e9b792e3cd2ad996febdea46ba

Last test of basis   165522  2021-10-15 11:02:48 Z    0 days
Testing same since   165527  2021-10-15 14:01:46 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Jan Beulich <jbeulich@suse.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   9f4f20b27b..f791392f82  f791392f82ffe39cc1ea4c4db1d877223754a04a -> smoke


From xen-devel-bounces@lists.xenproject.org Fri Oct 15 18:38:40 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 18:38:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.211030.368088 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbS65-0004Iz-3n; Fri, 15 Oct 2021 18:38:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 211030.368088; Fri, 15 Oct 2021 18:38:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbS64-0004Is-VI; Fri, 15 Oct 2021 18:38:24 +0000
Received: by outflank-mailman (input) for mailman id 211030;
 Fri, 15 Oct 2021 18:38:23 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mbS63-0004Im-T8
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 18:38:23 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mbS62-0002q9-9a; Fri, 15 Oct 2021 18:38:22 +0000
Received: from [54.239.6.185] (helo=[192.168.0.140])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mbS62-0002tJ-1G; Fri, 15 Oct 2021 18:38:22 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=xWB/GjandfxY7il5xlUzhjF2/0EcAFuuglOttH/SFLo=; b=eThHxZiLZu68aD/A6mZ6Yg/CiK
	ada8w6khFhT6vk2UMt4GKFXVVFr6cVQFBmoZmaP7zRofeQ3CpxYvdi8PRo4XGu76uY2xzIprsFx26
	7z1g8l86vUS4YCfI04R2VbwbjPGmG6LhFotLIK1mK1ThpOS0P0eM9a6JL8ln5aSCx0AA=;
Message-ID: <a45077dc-e144-4427-9ae2-5815045ecaec@xen.org>
Date: Fri, 15 Oct 2021 19:38:19 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.2.0
Subject: Re: [PATCH v8 2/5] xen/arm: Enable the existing x86 virtual PCI
 support for ARM
To: Bertrand Marquis <Bertrand.Marquis@arm.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>,
 "iwj@xenproject.org" <iwj@xenproject.org>,
 "sstabellini@kernel.org" <sstabellini@kernel.org>,
 Rahul Singh <Rahul.Singh@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Wei Liu <wl@xen.org>, Paul Durrant <paul@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <cover.1634315461.git.bertrand.marquis@arm.com>
 <e2b10f56043155e4bb8eae824723045ccc042f8e.1634315461.git.bertrand.marquis@arm.com>
 <cef8d2a6-91c1-2d4d-2078-98d0a92b067a@xen.org>
 <F447A1D8-A023-4127-AAC0-7511868DE9C4@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <F447A1D8-A023-4127-AAC0-7511868DE9C4@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit



On 15/10/2021 18:33, Bertrand Marquis wrote:
> Hi Julien,

Hi Bertrand,

> 
>> On 15 Oct 2021, at 18:25, Julien Grall <julien@xen.org> wrote:
>>
>> Hi Bertrand,
>>
>> On 15/10/2021 17:51, Bertrand Marquis wrote:
>>> diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci.c
>>> index 3aa8c3175f..35e0190796 100644
>>> --- a/xen/drivers/passthrough/pci.c
>>> +++ b/xen/drivers/passthrough/pci.c
>>> @@ -756,6 +756,19 @@ int pci_add_device(u16 seg, u8 bus, u8 devfn,
>>>       if ( !pdev->domain )
>>>       {
>>>           pdev->domain = hardware_domain;
>>> +#ifdef CONFIG_ARM
>>> +        /*
>>> +         * On ARM PCI devices discovery will be done by Dom0. Add vpci handler
>>> +         * when Dom0 inform XEN to add the PCI devices in XEN.
>>> +         */
>>> +        ret = vpci_add_handlers(pdev);
>>
>> I don't seem to find the code to remove __init_hwdom in this series. Are you intending to fix it separately?
> 
> Yes I think it is better to fix that in a new patch as it will require some discussion as it will impact the x86 code if I just remove the flag now.
For the future patch series, may I ask to keep track of outstanding 
issues in the commit message (if you don't plan to address them before 
commiting) or after --- (if they are meant to be addressed before 
commiting)?

In this case, the impact on Arm is this would result to an hypervisor 
crash if called. If we drop __init_hwdom, the impact on x86 is Xen text 
will slightly be bigger after the boot time.

AFAICT, the code is not reachable on Arm (?). Therefore, one could argue 
we this can wait after the week-end as this is a latent bug. Yet, I am 
not really comfortable to see knowningly buggy code merged.

Stefano, would you be willing to remove __init_hwdom while committing 
it? If not, can you update the commit message and mention this patch 
doesn't work as intended?

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Oct 15 19:48:10 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 19:48:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.211047.368099 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbTAw-0002Sf-37; Fri, 15 Oct 2021 19:47:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 211047.368099; Fri, 15 Oct 2021 19:47:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbTAv-0002SX-Uw; Fri, 15 Oct 2021 19:47:29 +0000
Received: by outflank-mailman (input) for mailman id 211047;
 Fri, 15 Oct 2021 19:47:28 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=OB3O=PD=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1mbTAu-0002SR-7e
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 19:47:28 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id b97b300c-2df0-11ec-825e-12813bfff9fa;
 Fri, 15 Oct 2021 19:47:27 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id 2778F60FE3;
 Fri, 15 Oct 2021 19:47:26 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b97b300c-2df0-11ec-825e-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1634327246;
	bh=uxl2T3/DNCg0OiNUwGQ0Golh8prz654MgXPsmWG6Q8s=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=qxs4lh4aYEpNuVF2Ga+imVXDefYZSCHsnpGG8bNleUm8h94AapspFJUBrBdrt2Xd2
	 rt2k17MfQE2BANrqzv1q235Zau1PMPY519Zcn76dXG1iSr7fGQQmGzMfk3LY444Vvo
	 yGYpYIbGvPQMkDSEhqFXgkEcoD9MzWoW4AttBoElCaTB/lYN5k9UTqmnSyKv/2GD9H
	 ZYSRUXdkS54Q6+BVJHcfL9Lsh0IdG4cRNYYghDqEa8UtHfQMSIyqTkY0g3iCErZSMg
	 eibyLNhjIZG6gluj0wCMNFqf6/OL0FOthWJUHK3LlnRHrPTS2JKo3kQvVDpzNBI9as
	 0l7ayM222jxrA==
Date: Fri, 15 Oct 2021 12:47:17 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Julien Grall <julien@xen.org>
cc: Bertrand Marquis <Bertrand.Marquis@arm.com>, 
    Xen-devel <xen-devel@lists.xenproject.org>, 
    "iwj@xenproject.org" <iwj@xenproject.org>, 
    "sstabellini@kernel.org" <sstabellini@kernel.org>, 
    Rahul Singh <Rahul.Singh@arm.com>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, 
    Andrew Cooper <andrew.cooper3@citrix.com>, 
    George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>, 
    Wei Liu <wl@xen.org>, Paul Durrant <paul@xen.org>, 
    =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= <roger.pau@citrix.com>
Subject: Re: [PATCH v8 2/5] xen/arm: Enable the existing x86 virtual PCI
 support for ARM
In-Reply-To: <a45077dc-e144-4427-9ae2-5815045ecaec@xen.org>
Message-ID: <alpine.DEB.2.21.2110151235100.31303@sstabellini-ThinkPad-T480s>
References: <cover.1634315461.git.bertrand.marquis@arm.com> <e2b10f56043155e4bb8eae824723045ccc042f8e.1634315461.git.bertrand.marquis@arm.com> <cef8d2a6-91c1-2d4d-2078-98d0a92b067a@xen.org> <F447A1D8-A023-4127-AAC0-7511868DE9C4@arm.com>
 <a45077dc-e144-4427-9ae2-5815045ecaec@xen.org>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Fri, 15 Oct 2021, Julien Grall wrote:
> On 15/10/2021 18:33, Bertrand Marquis wrote:
> > > On 15 Oct 2021, at 18:25, Julien Grall <julien@xen.org> wrote:
> > > 
> > > Hi Bertrand,
> > > 
> > > On 15/10/2021 17:51, Bertrand Marquis wrote:
> > > > diff --git a/xen/drivers/passthrough/pci.c
> > > > b/xen/drivers/passthrough/pci.c
> > > > index 3aa8c3175f..35e0190796 100644
> > > > --- a/xen/drivers/passthrough/pci.c
> > > > +++ b/xen/drivers/passthrough/pci.c
> > > > @@ -756,6 +756,19 @@ int pci_add_device(u16 seg, u8 bus, u8 devfn,
> > > >       if ( !pdev->domain )
> > > >       {
> > > >           pdev->domain = hardware_domain;
> > > > +#ifdef CONFIG_ARM
> > > > +        /*
> > > > +         * On ARM PCI devices discovery will be done by Dom0. Add vpci
> > > > handler
> > > > +         * when Dom0 inform XEN to add the PCI devices in XEN.
> > > > +         */
> > > > +        ret = vpci_add_handlers(pdev);
> > > 
> > > I don't seem to find the code to remove __init_hwdom in this series. Are
> > > you intending to fix it separately?
> > 
> > Yes I think it is better to fix that in a new patch as it will require some
> > discussion as it will impact the x86 code if I just remove the flag now.
> For the future patch series, may I ask to keep track of outstanding issues in
> the commit message (if you don't plan to address them before commiting) or
> after --- (if they are meant to be addressed before commiting)?
> 
> In this case, the impact on Arm is this would result to an hypervisor crash if
> called. If we drop __init_hwdom, the impact on x86 is Xen text will slightly
> be bigger after the boot time.
> 
> AFAICT, the code is not reachable on Arm (?). Therefore, one could argue we
> this can wait after the week-end as this is a latent bug. Yet, I am not really
> comfortable to see knowningly buggy code merged.
> 
> Stefano, would you be willing to remove __init_hwdom while committing it? If
> not, can you update the commit message and mention this patch doesn't work as
> intended?

I prefer not to do a change like this on commit as it affects x86.

I added a note in the commit message about it. I also added Roger's ack
that was given to the previous version. FYI this is the only outstanding
TODO as far as I am aware (there are other pending patch series of
course).

After reviewing the whole series again, checking it against all the
reviewers comments, and making it go through gitlab-ci, I committed the
series.

Thank you all for all the efforts that went into this. We made it :-)


From xen-devel-bounces@lists.xenproject.org Fri Oct 15 21:41:58 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 21:41:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.211073.368129 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbUxS-00055N-6f; Fri, 15 Oct 2021 21:41:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 211073.368129; Fri, 15 Oct 2021 21:41:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbUxS-00055G-3n; Fri, 15 Oct 2021 21:41:42 +0000
Received: by outflank-mailman (input) for mailman id 211073;
 Fri, 15 Oct 2021 21:41:41 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=dS4n=PD=oracle.com=boris.ostrovsky@srs-us1.protection.inumbo.net>)
 id 1mbUxR-00055A-2d
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 21:41:41 +0000
Received: from mx0a-00069f02.pphosted.com (unknown [205.220.165.32])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 9686088e-5a8a-4915-94d4-f66ac5fc7d07;
 Fri, 15 Oct 2021 21:41:38 +0000 (UTC)
Received: from pps.filterd (m0246627.ppops.net [127.0.0.1])
 by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 19FKOC0G008082; 
 Fri, 15 Oct 2021 21:41:36 GMT
Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80])
 by mx0b-00069f02.pphosted.com with ESMTP id 3bqbgft74h-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Fri, 15 Oct 2021 21:41:36 +0000
Received: from pps.filterd (userp3030.oracle.com [127.0.0.1])
 by userp3030.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 19FLZIdj014852;
 Fri, 15 Oct 2021 21:41:34 GMT
Received: from nam11-co1-obe.outbound.protection.outlook.com
 (mail-co1nam11lp2173.outbound.protection.outlook.com [104.47.56.173])
 by userp3030.oracle.com with ESMTP id 3bkyvf3ks4-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Fri, 15 Oct 2021 21:41:34 +0000
Received: from BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10)
 by BLAPR10MB4978.namprd10.prod.outlook.com (2603:10b6:208:30e::23)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16; Fri, 15 Oct
 2021 21:41:32 +0000
Received: from BLAPR10MB5009.namprd10.prod.outlook.com
 ([fe80::3c49:46aa:83e1:a329]) by BLAPR10MB5009.namprd10.prod.outlook.com
 ([fe80::3c49:46aa:83e1:a329%5]) with mapi id 15.20.4608.017; Fri, 15 Oct 2021
 21:41:32 +0000
Received: from [10.74.109.235] (138.3.200.43) by
 BY5PR17CA0050.namprd17.prod.outlook.com (2603:10b6:a03:167::27) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.14 via Frontend
 Transport; Fri, 15 Oct 2021 21:41:30 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9686088e-5a8a-4915-94d4-f66ac5fc7d07
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date :
 subject : to : cc : references : from : in-reply-to : content-type :
 content-transfer-encoding : mime-version; s=corp-2021-07-09;
 bh=37HjO7lmu+6h7FsEWyn6ixoedEAAbr7XvAPKPAdlI1c=;
 b=V9DRmISNZPeGW98Fmk1qRH8N4KYi9WJjJEdsynXd/+DIEMniiLc16BBUh8nW7k3bdMUo
 x6u5NZEqF13f+/emF8B8LvhSNmXaekI02o3+hk827qQ86EWg5navp/IFOdlIM7Ot2qUc
 024LhLprr4QBbJdxCtk3P7Sr2OpzXW2qPNvNcXa+isH4yTvU2zmAs+W1XLoeSvagAveI
 MJ3q49jLB0WpSTMfEsAM4wl667/gvg+3uVrqRnuQES5Kifq9eDuizawY4MOJ5XwD2kqu
 0tdbvzcWEJQVyqpGErmL8yEd14U4YBn9RBD7IKLY3yMdwJDluFCFqxvtbozI4PRkvGqf pg== 
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=n/8ITHGqI74rVLKl3hWS33Jb6tmCWIxl76YGxLkbeM+mRB4/ybpPKJP+PUCBaNSLsLA2Vs4+RXEWr3Oh/4htuVKjzBWEruoFXbAXsjicOIExCsMVxwoicETZDK1EzS2AIPWk7VA+/3Ys3EAVf0426dCq0YubSY96NJRVCGlWMRrPOQeDSwnKdQYTyAzvuhrNHO5Ie0gm4+n948PdRGZlC46SRMOSE8MuJJs+JwMR3BjTyHOVLDFn+VEo//HYlTejUFXrK+BXFaGPQXXo69KxrUSa0o5UI1pe3FX0lz8+7O9iiN+Zwid8BAo9ES8w68whJjY86wmaUr28exgZlwZmYQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=37HjO7lmu+6h7FsEWyn6ixoedEAAbr7XvAPKPAdlI1c=;
 b=fIQ0eaWvL/dQHqcjgmjhymsKzB0wb4YR15R7VTydG7RogrRkuqONROQPbHzOlmC93c7A6bDVYE7uB/74wk0//jQB8M2sqYBKKr8UHWTFdO7Me7X8UOfO6RflK/lOk0CiRtCug4t6zo9+LYTdtdhBeQNPe26o94HwXXSVacdJWfSXIDpfiiXdv++jqQ5NCNkws/RFBDz/xeShvd3CcsQBwOl2uqN8W7updTCg1YOiHe+z9bf44B0wGRtMHSNOyCHoOmVYvoc8MAcAJ9DWrLP4E2HjRee4m4TVBdfg4nop0rYQ7WQZqLsbwKHjzkAbKBuWHsHBRtsB2R5LCDffwXmTSg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com;
 dkim=pass header.d=oracle.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=37HjO7lmu+6h7FsEWyn6ixoedEAAbr7XvAPKPAdlI1c=;
 b=epC0NPnOzJY/+FkwLm19f4E8wtx5OPpMmH2dNb6U9msscWRzVRh1N70jMl7/k0YmqI1U1RyvVRxXcMkJRXS8AtlpCgb+2dyhybt5RWLxfULLmKkJBlTAYN4j5PX0XuAcehiRIXyp3fK2sKz/cGHGfaE1w5FbiET+MRyrRUeisOw=
Authentication-Results: suse.com; dkim=none (message not signed)
 header.d=none;suse.com; dmarc=none action=none header.from=oracle.com;
Message-ID: <4cbc2abd-fc1c-4283-48c4-42c5a3f05b71@oracle.com>
Date: Fri, 15 Oct 2021 17:41:26 -0400
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.2.0
Subject: Re: [PATCH] xen: fix wrong SPDX headers of Xen related headers
Content-Language: en-US
To: Juergen Gross <jgross@suse.com>, xen-devel@lists.xenproject.org,
        linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org
Cc: gregkh@linuxfoundation.org, Stefano Stabellini <sstabellini@kernel.org>
References: <20211015143312.29900-1-jgross@suse.com>
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
In-Reply-To: <20211015143312.29900-1-jgross@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: BY5PR17CA0050.namprd17.prod.outlook.com
 (2603:10b6:a03:167::27) To BLAPR10MB5009.namprd10.prod.outlook.com
 (2603:10b6:208:321::10)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: a2c57e13-9328-4121-fa94-08d990248db3
X-MS-TrafficTypeDiagnostic: BLAPR10MB4978:
X-Microsoft-Antispam-PRVS: 
	<BLAPR10MB497875FF29FAF120E86CA4A78AB99@BLAPR10MB4978.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6108;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 
	bcl+5DsnXDdZWcPJRtOpP1bzeCkZ8Z6eGHmkBgvPUSAR3qH59dsgt/sc1Jcyi+dt9HTG1TQJPfbyiX7/IxRq5vftUFfJ890G7/jHNazw7voFjwryTqLX0JlWEvP7zvPKMKc0HDUbyTMAX/qAf3jf31z/BWWJ6SKejaQG+hMYukLDKRGI+BDSdNBzM3YsI5e3PKGXFoQDNKfcxO8fZJYbT7PIXorbArkJ45iOLVwxeiTcklvkm3YoS+EoElskvwZ4n/BRTk9MayfvAMWV24vtiNNQj5U5jf90nbXre5VOQMOWIipd65+j4cYFx7OIVQQ7xoTh+PSKDjAI2SFVVLB4ttP21Gu8ZShGO/Ud7AmLQGk6cqT7fU8N937Ilob1OeNBxESs2cj8IwEbI8Gr/IyiMyYz00e0zU45hBsM/IxYROXnj2zB//hf8OGkykm0vD6VdY+63gP3mL2t2jFk0REFjbNyvA9DNQnweiuQDN6m+MY2332gwIodsyerRNQLjhIH3wUqx6dorAsvCmtsnhHKwTEdUcA1EnwrYkSu8MqvcNMHoetqlsAK36gTGIE1LXKiTEXD36HymKkKjcDiu5MRu9BOmFSOThb5Wd7022uOnAy8a27NVgpeIWJZY2qY0sMC4Setf92vTfYK/vf0I70dUbpWMsAJMhwz2IQrfiYYsYpWNGbGKynqbx50tI+owH9kjy7/9kVCVLphrNwtXzP63oYBG0N9sOdet0rsuWRD1Qt+2B2gzc48jsUnwUnHWvlT
X-Forefront-Antispam-Report: 
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB5009.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(16576012)(2616005)(316002)(86362001)(6486002)(38100700002)(4326008)(31696002)(8676002)(5660300002)(508600001)(4744005)(26005)(8936002)(31686004)(53546011)(36756003)(44832011)(6666004)(66946007)(186003)(66476007)(66556008)(2906002)(956004)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?VmE0RzMvc0FwUlFBUnNvMzdraGN1b0tKVUhicGJDbUl0ZUMyUlNNZHBHZi9i?=
 =?utf-8?B?QncxN0NSVGJ5c09SZUNxak5rbjlQTGI2dzc3Y0dxUVF0MXhJSllMdFhCcUNB?=
 =?utf-8?B?clREbFlybEVKTUVwVEx6RFQwV3RsTlpFV3V2emJaeWloUXVQOVNoRnVqY1cw?=
 =?utf-8?B?SDVZeEVVc3plZEdwRnE2ZWovRXc5N09GWG9XS0RGRElMQUwxTmVNTWxETjVk?=
 =?utf-8?B?Y3I2Uldvc2g0S1ZtdkdzTjdlVEc2VDUxNDNPMUhUTGhtTmZMc1FPZ0s5U0Zh?=
 =?utf-8?B?ck5EZ2NrczRJYldyVG5EaXpKZWtZOUFoSW94SDNMM1ZJS1JuanB1MUYwS2FW?=
 =?utf-8?B?cjViOVV2Z1lnVWJEMzZLZG95VmF4SERDM0hvRVMyQTlkamU5R1ZIRmt2ZlRo?=
 =?utf-8?B?Q3VtQkVDSng4NSt5bmRmclY1VjdRZHlnR1ptZ1BueURZREczZSs5QkJYV0wv?=
 =?utf-8?B?KzhaTm9qS3ZjZ1grNFNGSlpOV3N2Vlg5WVZwYm12UjlnKzVaNkMvOEhIMjBO?=
 =?utf-8?B?Z3Z0Y0YvN3dqOUMweFZsWE4yb1FKY0huc085akNFTEI2T1JjSDA5Slc4cjlE?=
 =?utf-8?B?V0t1YWZsNTJudUdHRmFRZXE0ZldEaEdRM0pXaG82c0N1ejlMNVlTU0VhamZk?=
 =?utf-8?B?c0VFUjhVK3Nsb0tPTzRZR0NYWmdWVlRUaWJ1M2hJNUg1QzVEUVovdmZqV1Ju?=
 =?utf-8?B?S1dBZnVGVG9QK3U0Sm9JMDZwSVMvcFQ3ZFk4WUswUWMzQ1lRV3Y5T0JibHhN?=
 =?utf-8?B?RkRyQk5LWHIzKzdHMXJab0pZZjdpZHBBRWpvcEU1MmZ2RUlNS2F4VkRKSE80?=
 =?utf-8?B?bTR2dE9BeHkrclE1MWIzTkF2akRscDVkWEFBQkY4K202dHkybjZwbS9pekY0?=
 =?utf-8?B?YkJ3VW9OVnN0SXJRUENFcmpkNkVjQ25WSEk1OWJRY1RIdlVmNmhwbng3UUlV?=
 =?utf-8?B?SjFMZ3pzVS95K0hLNU9sM1I0TzhvYUVFSHF0VjFraGI1dGNXQTJRM1JuY3pp?=
 =?utf-8?B?SXd5dkh4VWEzRXhRMWlkVkNnSEx4MWFVTUttR3c4d2k2QVdsRE5BWWlQL3B4?=
 =?utf-8?B?MStNQzhGTVNSM2dmYm96YkFWZkJycndQZ21seGRGcThtUFNrL0VZaGV6NGkr?=
 =?utf-8?B?MzZUYmtkS3ZmZFp3aTJ2dTdmaXR6K240VjU5V0lvT04raWRJeHo0MDNOUlpM?=
 =?utf-8?B?M1RnU29USXdGSC9jS0hYMTlsT1RMejF1YjRsM1JvRldxN05PVTlVUnMrbnMy?=
 =?utf-8?B?MzJkamNSZnpLU3ZVM1V3blNZbVk1b0N2YVdIbmUyUG9OWWhMcnNpSzViT1dz?=
 =?utf-8?B?Y3FPbUJwZzRtU243dnlscHR5M0NwVUlockNjcDJDNWpFM3kxeTlqRkpTVkJL?=
 =?utf-8?B?b0wzaVc0bnRlcVkzNlNxUXltbVRaZDQ5U2xGVTBMMlVUY2hySUVLbFVIdTAy?=
 =?utf-8?B?cGZ6S1pZczg3ZVBuaVNSMTQ0bHljeUZGeDJLU1FUdXA4WGZUUVZ5SnB2cHpz?=
 =?utf-8?B?TGpxV3U5ZnZKVlJVaGRveVM2MnFrdE95eVY3QXowV1A1M3lrNWpUOVkzV1Vw?=
 =?utf-8?B?MmM3SFdTckROTlgwUGd0cW1xdGxXcU9nRFFWeEhiMVZqQWtVRGlwdVNKVGd0?=
 =?utf-8?B?aWlSMTVVdzBQVWh0dzNhd1lNc2xXcHNFaExjUlltcDZnMHh1bmNyMzJFMTJs?=
 =?utf-8?B?ZTJjRGF5Lyt1ODlFSkwvclpuVUtmOHlFV3ptbXVrcWRyMXRwZVJpRTd1WmI4?=
 =?utf-8?Q?ohpHHITfRaaN2tQmW41UteNy7CgBxAmcM4OtL/P?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a2c57e13-9328-4121-fa94-08d990248db3
X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2021 21:41:32.2341
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 7vdsR4KgV4VzWjzjXPDWlUDNpkvBoWZYEbKmNBCBdklFJb9llzxuORxAHa98JEtAXn2pt7Fqo8Tr/OIiLK3rskxQ1Y6I+kys46rMcM44VrM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB4978
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10138 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 phishscore=0 bulkscore=0
 malwarescore=0 adultscore=0 mlxscore=0 spamscore=0 mlxlogscore=999
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109230001
 definitions=main-2110150131
X-Proofpoint-ORIG-GUID: ctjq1-Lr_TX2j98_2nPF8ptobKmkHCRQ
X-Proofpoint-GUID: ctjq1-Lr_TX2j98_2nPF8ptobKmkHCRQ


On 10/15/21 10:33 AM, Juergen Gross wrote:
> Commit b24413180f5600 ("License cleanup: add SPDX GPL-2.0 license
> identifier to files with no license") was meant to do a tree-wide
> cleanup for files without any license information by adding a SPDX
> GPL-2.0 line to them.
>
> Unfortunately this was applied even to several Xen-related headers
> which have been originally under the MIT license, but obviously have
> been copied to the Linux tree from the Xen project without keeping the
> license boiler plate as required.
>
> Correct that by changing the license of those files back to "MIT".
>
> Some files still contain the MIT license text. Replace that by the
> related SPDX line.
>
> Signed-off-by: Juergen Gross <jgross@suse.com>


Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>





From xen-devel-bounces@lists.xenproject.org Fri Oct 15 21:55:32 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 21:55:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.211082.368141 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbVAl-0006Zj-DP; Fri, 15 Oct 2021 21:55:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 211082.368141; Fri, 15 Oct 2021 21:55:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbVAl-0006Zc-AQ; Fri, 15 Oct 2021 21:55:27 +0000
Received: by outflank-mailman (input) for mailman id 211082;
 Fri, 15 Oct 2021 21:55:26 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mbVAk-0006ZS-BL; Fri, 15 Oct 2021 21:55:26 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mbVAk-0006D5-4P; Fri, 15 Oct 2021 21:55:26 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mbVAj-0007R6-QL; Fri, 15 Oct 2021 21:55:25 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mbVAj-0006SE-Pu; Fri, 15 Oct 2021 21:55:25 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=TCUJlif3b6TBrgaAMTxfHMEcynwx6qy5HDngVZRVUFk=; b=R23l9pElQIQfnPFeIRbrfmb7UK
	kstiLbIt4cx+e31wBq5G+QzpD+nbHSG9sbmpPTbS983bZAQRpU4YPs+kwsuzha8IQuvEVPS3TGfJa
	3U+rnpihdP/epBYwRyquDvgDOzvaQM3y35infIonYl0H8vtMT536IGiUegYjfVSajewA=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165523-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 165523: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=7e43d3e08611ac4c4bc41c46470052d4118168eb
X-Osstest-Versions-That:
    ovmf=785cfd33053f506d4a1c17100356a63f24e98f45
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 15 Oct 2021 21:55:25 +0000

flight 165523 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165523/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 7e43d3e08611ac4c4bc41c46470052d4118168eb
baseline version:
 ovmf                 785cfd33053f506d4a1c17100356a63f24e98f45

Last test of basis   165508  2021-10-14 12:11:12 Z    1 days
Testing same since   165523  2021-10-15 11:10:08 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Leif Lindholm <leif@nuviainc.com>
  Ming Huang <huangming@linux.alibaba.com>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   785cfd3305..7e43d3e086  7e43d3e08611ac4c4bc41c46470052d4118168eb -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Fri Oct 15 22:41:30 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 22:41:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.211095.368155 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbVtD-0002x1-SS; Fri, 15 Oct 2021 22:41:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 211095.368155; Fri, 15 Oct 2021 22:41:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbVtD-0002wu-PR; Fri, 15 Oct 2021 22:41:23 +0000
Received: by outflank-mailman (input) for mailman id 211095;
 Fri, 15 Oct 2021 22:41:23 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mbVtD-0002wk-1e; Fri, 15 Oct 2021 22:41:23 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mbVtC-0006yA-Mc; Fri, 15 Oct 2021 22:41:22 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mbVtC-0001pc-9N; Fri, 15 Oct 2021 22:41:22 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mbVtC-0006qd-8D; Fri, 15 Oct 2021 22:41:22 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=3cmV5FlYtrPorDs4wSPuX7CL+NtDvHqcu1e5Soh5CMU=; b=Hb4fNl01Vax/C8p911kVlAU2wI
	P+ifFq0CusFgAuxLFPN0cPMszwf7TWWsBoMCGo8GUWt60OxSk3elvanGAzSK+vSCnIUQ4LAY767Q8
	cpf/EdUPRMuNg+VxJ+gxbhMVsGPXFzflbnGnmfbRdUjHSLB+ABoisBEa+5PoGxIZVZlA=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165520-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.14-testing test] 165520: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-4.14-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=99cbe2031a6bba62819c8e8c2acffe7fe3486cb9
X-Osstest-Versions-That:
    xen=ba45e99aa4da5dae6f42819ceb9372764fea410d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 15 Oct 2021 22:41:22 +0000

flight 165520 xen-4.14-testing real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165520/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 165386
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 165386
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 165386
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 165386
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165386
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165386
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 165386
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 165386
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 165386
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 165386
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 165386
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165386
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 xen                  99cbe2031a6bba62819c8e8c2acffe7fe3486cb9
baseline version:
 xen                  ba45e99aa4da5dae6f42819ceb9372764fea410d

Last test of basis   165386  2021-10-05 19:06:40 Z   10 days
Testing same since   165520  2021-10-15 09:38:50 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Anthony PERARD <anthony.perard@citrix.com>
  Igor Druzhinin <igor.druzhinin@citrix.com>
  Jan Beulich <jbeulich@suse.com>
  Kevin Stefanov <kevin.stefanov@citrix.com>
  Roger Pau Monné <roger.pau@citrix.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   ba45e99aa4..99cbe2031a  99cbe2031a6bba62819c8e8c2acffe7fe3486cb9 -> stable-4.14


From xen-devel-bounces@lists.xenproject.org Fri Oct 15 22:55:50 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 22:55:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.211121.368229 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbW71-0005Ct-W9; Fri, 15 Oct 2021 22:55:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 211121.368229; Fri, 15 Oct 2021 22:55:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbW71-0005Cm-SN; Fri, 15 Oct 2021 22:55:39 +0000
Received: by outflank-mailman (input) for mailman id 211121;
 Fri, 15 Oct 2021 22:55:38 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=OB3O=PD=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1mbW70-0005Cg-Jc
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 22:55:38 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 02d0b67c-2e0b-11ec-826a-12813bfff9fa;
 Fri, 15 Oct 2021 22:55:37 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id CE9346105A;
 Fri, 15 Oct 2021 22:55:35 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 02d0b67c-2e0b-11ec-826a-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1634338536;
	bh=3bxZhWBUcCw55RihIAnDgki0ivkuQs6PuULt0GyliDk=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=Ic71hPWiInirVNvoquJTuQWOV8f2K45FgrYpKBbKsx7az+6mn4ajf2sY09iN+icnw
	 4+gEop0ARmmxtBVbP5DKE0rBknZcJDrhSzVzO70ZZIUCWZpr8awJ4Xnmnicjz3R9qn
	 5V2EmyUymgqltpyH0jOk6DmwUMZ6g27dKo4bbqOfWWSlaOh2SSyFxro117difHS66I
	 UpiBlw0/Zhtk6eQ6N7wU+kJXqt//qXuWg2hJvrpyo1fU+gbzBI+gE06FLs+qrHwb/I
	 3mAWvKect14DpXrZ3rQOHb3r6g2PoWVZOfdjsK/WmagLAh0mlInf3ss0JuOg45rCxI
	 RMLpxWrsPJvew==
Date: Fri, 15 Oct 2021 15:55:34 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Jan Beulich <jbeulich@suse.com>
cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, 
    Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>, 
    =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= <roger.pau@citrix.com>, 
    Tim Deegan <tim@xen.org>, George Dunlap <george.dunlap@citrix.com>, 
    iwj@xenproject.org
Subject: Re: [PATCH 1/2] x86/shadow: adjust some shadow_set_l<N>e() callers
In-Reply-To: <298846aa-f93f-4564-dbf4-4f893df8f328@suse.com>
Message-ID: <alpine.DEB.2.21.2110151554450.31303@sstabellini-ThinkPad-T480s>
References: <24329000-06d7-2047-b0a1-51b149d19189@suse.com> <298846aa-f93f-4564-dbf4-4f893df8f328@suse.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

This patch broke gitlab-ci:

https://gitlab.com/xen-project/people/sstabellini/xen/-/jobs/1684530258

In file included from guest_4.c:2:
./multi.c:2159:9: error: unused variable 'r' [-Werror,-Wunused-variable]
    int r;
        ^
1 error generated.
make[5]: *** [/builds/xen-project/people/sstabellini/xen/xen/Rules.mk:197: guest_4.o] Error 1


To be sure I got the right commit, I confirmed that by reverting the
commit gitlab-ci passes again:

https://gitlab.com/xen-project/people/sstabellini/xen/-/pipelines/389383466


On Wed, 13 Oct 2021, Jan Beulich wrote:
> Coverity dislikes sh_page_fault() storing the return value into a local
> variable but then never using the value (and oddly enough spots this in
> the 2- and 3-level cases, but not in the 4-level one). Instead of adding
> yet another cast to void as replacement, take the opportunity and drop a
> bunch of such casts at the same time - not using function return values
> is a common thing to do. (It of course is an independent question
> whether ignoring errors like this is a good idea.)
> 
> Coverity-ID: 1492856
> Coverity-ID: 1492858
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> 
> --- a/xen/arch/x86/mm/shadow/multi.c
> +++ b/xen/arch/x86/mm/shadow/multi.c
> @@ -1416,7 +1416,7 @@ void sh_unhook_32b_mappings(struct domai
>      shadow_l2e_t *sl2e;
>      SHADOW_FOREACH_L2E(sl2mfn, sl2e, 0, 0, d, {
>          if ( !user_only || (sl2e->l2 & _PAGE_USER) )
> -            (void) shadow_set_l2e(d, sl2e, shadow_l2e_empty(), sl2mfn);
> +            shadow_set_l2e(d, sl2e, shadow_l2e_empty(), sl2mfn);
>      });
>  }
>  
> @@ -1428,7 +1428,7 @@ void sh_unhook_pae_mappings(struct domai
>      shadow_l2e_t *sl2e;
>      SHADOW_FOREACH_L2E(sl2mfn, sl2e, 0, 0, d, {
>          if ( !user_only || (sl2e->l2 & _PAGE_USER) )
> -            (void) shadow_set_l2e(d, sl2e, shadow_l2e_empty(), sl2mfn);
> +            shadow_set_l2e(d, sl2e, shadow_l2e_empty(), sl2mfn);
>      });
>  }
>  
> @@ -1439,7 +1439,7 @@ void sh_unhook_64b_mappings(struct domai
>      shadow_l4e_t *sl4e;
>      SHADOW_FOREACH_L4E(sl4mfn, sl4e, 0, 0, d, {
>          if ( !user_only || (sl4e->l4 & _PAGE_USER) )
> -            (void) shadow_set_l4e(d, sl4e, shadow_l4e_empty(), sl4mfn);
> +            shadow_set_l4e(d, sl4e, shadow_l4e_empty(), sl4mfn);
>      });
>  }
>  
> @@ -1969,7 +1969,7 @@ static void sh_prefetch(struct vcpu *v,
>  
>          /* Propagate the entry.  */
>          l1e_propagate_from_guest(v, gl1e, gmfn, &sl1e, ft_prefetch, p2mt);
> -        (void) shadow_set_l1e(d, ptr_sl1e + i, sl1e, p2mt, sl1mfn);
> +        shadow_set_l1e(d, ptr_sl1e + i, sl1e, p2mt, sl1mfn);
>  
>  #if (SHADOW_OPTIMIZATIONS & SHOPT_OUT_OF_SYNC)
>          if ( snpl1p != NULL )
> @@ -2534,7 +2534,7 @@ static int sh_page_fault(struct vcpu *v,
>  
>      /* Calculate the shadow entry and write it */
>      l1e_propagate_from_guest(v, gw.l1e, gmfn, &sl1e, ft, p2mt);
> -    r = shadow_set_l1e(d, ptr_sl1e, sl1e, p2mt, sl1mfn);
> +    shadow_set_l1e(d, ptr_sl1e, sl1e, p2mt, sl1mfn);
>  
>  #if (SHADOW_OPTIMIZATIONS & SHOPT_OUT_OF_SYNC)
>      if ( mfn_valid(gw.l1mfn)
> @@ -3014,8 +3014,7 @@ static bool sh_invlpg(struct vcpu *v, un
>                  shadow_l1e_t *sl1;
>                  sl1 = sh_linear_l1_table(v) + shadow_l1_linear_offset(linear);
>                  /* Remove the shadow entry that maps this VA */
> -                (void) shadow_set_l1e(d, sl1, shadow_l1e_empty(),
> -                                      p2m_invalid, sl1mfn);
> +                shadow_set_l1e(d, sl1, shadow_l1e_empty(), p2m_invalid, sl1mfn);
>              }
>              paging_unlock(d);
>              /* Need the invlpg, to pick up the disappeareance of the sl1e */
> @@ -3608,7 +3607,8 @@ int sh_rm_write_access_from_l1(struct do
>               && (mfn_x(shadow_l1e_get_mfn(*sl1e)) == mfn_x(readonly_mfn)) )
>          {
>              shadow_l1e_t ro_sl1e = shadow_l1e_remove_flags(*sl1e, _PAGE_RW);
> -            (void) shadow_set_l1e(d, sl1e, ro_sl1e, p2m_ram_rw, sl1mfn);
> +
> +            shadow_set_l1e(d, sl1e, ro_sl1e, p2m_ram_rw, sl1mfn);
>  #if SHADOW_OPTIMIZATIONS & SHOPT_WRITABLE_HEURISTIC
>              /* Remember the last shadow that we shot a writeable mapping in */
>              if ( curr->domain == d )
> @@ -3637,8 +3637,7 @@ int sh_rm_mappings_from_l1(struct domain
>          if ( (flags & _PAGE_PRESENT)
>               && (mfn_x(shadow_l1e_get_mfn(*sl1e)) == mfn_x(target_mfn)) )
>          {
> -            (void) shadow_set_l1e(d, sl1e, shadow_l1e_empty(),
> -                                  p2m_invalid, sl1mfn);
> +            shadow_set_l1e(d, sl1e, shadow_l1e_empty(), p2m_invalid, sl1mfn);
>              if ( sh_check_page_has_no_refs(mfn_to_page(target_mfn)) )
>                  /* This breaks us cleanly out of the FOREACH macro */
>                  done = 1;
> @@ -3656,20 +3655,20 @@ void sh_clear_shadow_entry(struct domain
>      switch ( mfn_to_page(smfn)->u.sh.type )
>      {
>      case SH_type_l1_shadow:
> -        (void) shadow_set_l1e(d, ep, shadow_l1e_empty(), p2m_invalid, smfn);
> +        shadow_set_l1e(d, ep, shadow_l1e_empty(), p2m_invalid, smfn);
>          break;
>      case SH_type_l2_shadow:
>  #if GUEST_PAGING_LEVELS >= 4
>      case SH_type_l2h_shadow:
>  #endif
> -        (void) shadow_set_l2e(d, ep, shadow_l2e_empty(), smfn);
> +        shadow_set_l2e(d, ep, shadow_l2e_empty(), smfn);
>          break;
>  #if GUEST_PAGING_LEVELS >= 4
>      case SH_type_l3_shadow:
> -        (void) shadow_set_l3e(d, ep, shadow_l3e_empty(), smfn);
> +        shadow_set_l3e(d, ep, shadow_l3e_empty(), smfn);
>          break;
>      case SH_type_l4_shadow:
> -        (void) shadow_set_l4e(d, ep, shadow_l4e_empty(), smfn);
> +        shadow_set_l4e(d, ep, shadow_l4e_empty(), smfn);
>          break;
>  #endif
>      default: BUG(); /* Called with the wrong kind of shadow. */
> @@ -3689,7 +3688,7 @@ int sh_remove_l1_shadow(struct domain *d
>          if ( (flags & _PAGE_PRESENT)
>               && (mfn_x(shadow_l2e_get_mfn(*sl2e)) == mfn_x(sl1mfn)) )
>          {
> -            (void) shadow_set_l2e(d, sl2e, shadow_l2e_empty(), sl2mfn);
> +            shadow_set_l2e(d, sl2e, shadow_l2e_empty(), sl2mfn);
>              if ( mfn_to_page(sl1mfn)->u.sh.type == 0 )
>                  /* This breaks us cleanly out of the FOREACH macro */
>                  done = 1;
> @@ -3712,7 +3711,7 @@ int sh_remove_l2_shadow(struct domain *d
>          if ( (flags & _PAGE_PRESENT)
>               && (mfn_x(shadow_l3e_get_mfn(*sl3e)) == mfn_x(sl2mfn)) )
>          {
> -            (void) shadow_set_l3e(d, sl3e, shadow_l3e_empty(), sl3mfn);
> +            shadow_set_l3e(d, sl3e, shadow_l3e_empty(), sl3mfn);
>              if ( mfn_to_page(sl2mfn)->u.sh.type == 0 )
>                  /* This breaks us cleanly out of the FOREACH macro */
>                  done = 1;
> @@ -3734,7 +3733,7 @@ int sh_remove_l3_shadow(struct domain *d
>          if ( (flags & _PAGE_PRESENT)
>               && (mfn_x(shadow_l4e_get_mfn(*sl4e)) == mfn_x(sl3mfn)) )
>          {
> -            (void) shadow_set_l4e(d, sl4e, shadow_l4e_empty(), sl4mfn);
> +            shadow_set_l4e(d, sl4e, shadow_l4e_empty(), sl4mfn);
>              if ( mfn_to_page(sl3mfn)->u.sh.type == 0 )
>                  /* This breaks us cleanly out of the FOREACH macro */
>                  done = 1;
> 
> 


From xen-devel-bounces@lists.xenproject.org Fri Oct 15 23:31:05 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 23:31:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.211129.368240 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbWfC-0000ia-Kx; Fri, 15 Oct 2021 23:30:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 211129.368240; Fri, 15 Oct 2021 23:30:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbWfC-0000iT-HG; Fri, 15 Oct 2021 23:30:58 +0000
Received: by outflank-mailman (input) for mailman id 211129;
 Fri, 15 Oct 2021 23:30:57 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ZYBM=PD=infradead.org=mcgrof@srs-us1.protection.inumbo.net>)
 id 1mbWfB-0000i4-64
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 23:30:57 +0000
Received: from bombadil.infradead.org (unknown [2607:7c80:54:e::133])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id c09bccb6-a6e2-41b0-8ec2-4fc0a94e3e80;
 Fri, 15 Oct 2021 23:30:55 +0000 (UTC)
Received: from mcgrof by bombadil.infradead.org with local (Exim 4.94.2 #2
 (Red Hat Linux)) id 1mbWej-0095ut-6A; Fri, 15 Oct 2021 23:30:29 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
X-Inumbo-ID: c09bccb6-a6e2-41b0-8ec2-4fc0a94e3e80
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Sender:Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:
	Reply-To:Content-Type:Content-ID:Content-Description;
	bh=+CQFH8oK70TJq0uFxZnllLSBarTFCbdKjMNvi/6R0AU=; b=SaCfLufaBBFJ5YdrAwSo0fvVDu
	MEDLEYbBM5r6bkQBn40iujou+0VmJ+pOupACXUkgfZGd0H80fQ3GpVUXSJVd55U0FnAojp88La+XZ
	A+JVcfQjTDsMHFZCVKHc/NoxLOewX90cZOK69Bnxa6Ag4G+qF3x/srHfVcTZInS1uIgS4Gj22jaER
	AyKLtEOGF7EhRgLSMFpt0zATZcaMo6hIgbpKTGkt8dKK1stX24tf9yHxuprWxbJQHy82ZMGgrrG81
	+q26GmRzr157Y7UTbLCxP7FCp8Gq+lduxVAiLznbifG4GwAr/TTAIhSlPJFaFqM4qhw6Ut2dNf2+2
	dgm1lHrQ==;
From: Luis Chamberlain <mcgrof@kernel.org>
To: axboe@kernel.dk,
	jejb@linux.ibm.com,
	martin.petersen@oracle.com,
	agk@redhat.com,
	snitzer@redhat.com,
	colyli@suse.de,
	kent.overstreet@gmail.com,
	boris.ostrovsky@oracle.com,
	jgross@suse.com,
	sstabellini@kernel.org,
	roger.pau@citrix.com,
	geert@linux-m68k.org,
	ulf.hansson@linaro.org,
	tj@kernel.org,
	hare@suse.de,
	jdike@addtoit.com,
	richard@nod.at,
	anton.ivanov@cambridgegreys.com,
	johannes.berg@intel.com,
	krisman@collabora.com,
	chris.obbard@collabora.com,
	thehajime@gmail.com,
	zhuyifei1999@gmail.com,
	haris.iqbal@ionos.com,
	jinpu.wang@ionos.com,
	miquel.raynal@bootlin.com,
	vigneshr@ti.com,
	linux-mtd@lists.infradead.org
Cc: linux-scsi@vger.kernel.org,
	dm-devel@redhat.com,
	linux-bcache@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	linux-m68k@lists.linux-m68k.org,
	linux-um@lists.infradead.org,
	linux-block@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Luis Chamberlain <mcgrof@kernel.org>,
	Christoph Hellwig <hch@lst.de>
Subject: [PATCH 1/9] scsi/sd: add error handling support for add_disk()
Date: Fri, 15 Oct 2021 16:30:20 -0700
Message-Id: <20211015233028.2167651-2-mcgrof@kernel.org>
X-Mailer: git-send-email 2.31.1
In-Reply-To: <20211015233028.2167651-1-mcgrof@kernel.org>
References: <20211015233028.2167651-1-mcgrof@kernel.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: Luis Chamberlain <mcgrof@infradead.org>

We never checked for errors on add_disk() as this function
returned void. Now that this is fixed, use the shiny new
error handling.

As with the error handling for device_add() we follow the same
logic and just put the device so that cleanup is done via the
scsi_disk_release().

Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
---
 drivers/scsi/sd.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
index a646d27df681..d69f2e626e76 100644
--- a/drivers/scsi/sd.c
+++ b/drivers/scsi/sd.c
@@ -3457,7 +3457,13 @@ static int sd_probe(struct device *dev)
 		pm_runtime_set_autosuspend_delay(dev,
 			sdp->host->hostt->rpm_autosuspend_delay);
 	}
-	device_add_disk(dev, gd, NULL);
+
+	error = device_add_disk(dev, gd, NULL);
+	if (error) {
+		put_device(&sdkp->dev);
+		goto out;
+	}
+
 	if (sdkp->capacity)
 		sd_dif_config_host(sdkp);
 
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Fri Oct 15 23:31:05 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 23:31:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.211130.368250 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbWfH-0000zG-S0; Fri, 15 Oct 2021 23:31:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 211130.368250; Fri, 15 Oct 2021 23:31:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbWfH-0000z9-Oh; Fri, 15 Oct 2021 23:31:03 +0000
Received: by outflank-mailman (input) for mailman id 211130;
 Fri, 15 Oct 2021 23:31:02 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ZYBM=PD=infradead.org=mcgrof@srs-us1.protection.inumbo.net>)
 id 1mbWfG-0000i4-3e
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 23:31:02 +0000
Received: from bombadil.infradead.org (unknown [2607:7c80:54:e::133])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 3bac32ea-5a6e-4dec-a2d5-60f929f3e428;
 Fri, 15 Oct 2021 23:30:56 +0000 (UTC)
Received: from mcgrof by bombadil.infradead.org with local (Exim 4.94.2 #2
 (Red Hat Linux)) id 1mbWej-0095v5-Ct; Fri, 15 Oct 2021 23:30:29 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
X-Inumbo-ID: 3bac32ea-5a6e-4dec-a2d5-60f929f3e428
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Sender:Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:
	Reply-To:Content-Type:Content-ID:Content-Description;
	bh=9ZsOqn3b5/QR03MhD1Dx1DTw82KOKjoplYOfmtrSAjo=; b=GZiKyVUl5h20WldEdrGbqyto8+
	F1vc70D//lVIeo9F6TBNDnV9e55gE+P7li975g7REzacZFJKwEAeidozUGuR+k5GME36IWRQgNuj5
	urOtJ8gdj+Bf/OPhiy9VBUYENb8BuHmtpnjNJWLDK0eSdpNiooD7FGQjHbhMc5UAm9cOA6udp1s+p
	NSkiIce6DCoLM7V11sN9tyvsjfnUlUwaqyRyrhv0W5dk9rLWQZy0h7Zy1oAtjzbbYqpj4LhPjkl3a
	v8c4n9oLWSkDy6E0r4PTZRTOQWB17HvTEyzFhn/Iz8DTM/4WrajYQEVYOkt5laZZ3N+xB/yVPdxzK
	Gf2nTOxA==;
From: Luis Chamberlain <mcgrof@kernel.org>
To: axboe@kernel.dk,
	jejb@linux.ibm.com,
	martin.petersen@oracle.com,
	agk@redhat.com,
	snitzer@redhat.com,
	colyli@suse.de,
	kent.overstreet@gmail.com,
	boris.ostrovsky@oracle.com,
	jgross@suse.com,
	sstabellini@kernel.org,
	roger.pau@citrix.com,
	geert@linux-m68k.org,
	ulf.hansson@linaro.org,
	tj@kernel.org,
	hare@suse.de,
	jdike@addtoit.com,
	richard@nod.at,
	anton.ivanov@cambridgegreys.com,
	johannes.berg@intel.com,
	krisman@collabora.com,
	chris.obbard@collabora.com,
	thehajime@gmail.com,
	zhuyifei1999@gmail.com,
	haris.iqbal@ionos.com,
	jinpu.wang@ionos.com,
	miquel.raynal@bootlin.com,
	vigneshr@ti.com,
	linux-mtd@lists.infradead.org
Cc: linux-scsi@vger.kernel.org,
	dm-devel@redhat.com,
	linux-bcache@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	linux-m68k@lists.linux-m68k.org,
	linux-um@lists.infradead.org,
	linux-block@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Luis Chamberlain <mcgrof@kernel.org>
Subject: [PATCH 7/9] um/drivers/ubd_kern: add error handling support for add_disk()
Date: Fri, 15 Oct 2021 16:30:26 -0700
Message-Id: <20211015233028.2167651-8-mcgrof@kernel.org>
X-Mailer: git-send-email 2.31.1
In-Reply-To: <20211015233028.2167651-1-mcgrof@kernel.org>
References: <20211015233028.2167651-1-mcgrof@kernel.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: Luis Chamberlain <mcgrof@infradead.org>

We never checked for errors on add_disk() as this function
returned void. Now that this is fixed, use the shiny new
error handling.

ubd_disk_register() never returned an error, so just fix
that now and let the caller handle the error condition.

Reviewed-by: Gabriel Krisman Bertazi <krisman@collabora.com>
Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
---
 arch/um/drivers/ubd_kern.c | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)

diff --git a/arch/um/drivers/ubd_kern.c b/arch/um/drivers/ubd_kern.c
index fefd343412c7..69d2d0049a61 100644
--- a/arch/um/drivers/ubd_kern.c
+++ b/arch/um/drivers/ubd_kern.c
@@ -855,8 +855,8 @@ static const struct attribute_group *ubd_attr_groups[] = {
 	NULL,
 };
 
-static void ubd_disk_register(int major, u64 size, int unit,
-			      struct gendisk *disk)
+static int ubd_disk_register(int major, u64 size, int unit,
+			     struct gendisk *disk)
 {
 	disk->major = major;
 	disk->first_minor = unit << UBD_SHIFT;
@@ -873,7 +873,7 @@ static void ubd_disk_register(int major, u64 size, int unit,
 
 	disk->private_data = &ubd_devs[unit];
 	disk->queue = ubd_devs[unit].queue;
-	device_add_disk(&ubd_devs[unit].pdev.dev, disk, ubd_attr_groups);
+	return device_add_disk(&ubd_devs[unit].pdev.dev, disk, ubd_attr_groups);
 }
 
 #define ROUND_BLOCK(n) ((n + (SECTOR_SIZE - 1)) & (-SECTOR_SIZE))
@@ -920,10 +920,15 @@ static int ubd_add(int n, char **error_out)
 	blk_queue_write_cache(ubd_dev->queue, true, false);
 	blk_queue_max_segments(ubd_dev->queue, MAX_SG);
 	blk_queue_segment_boundary(ubd_dev->queue, PAGE_SIZE - 1);
-	ubd_disk_register(UBD_MAJOR, ubd_dev->size, n, disk);
+	err = ubd_disk_register(UBD_MAJOR, ubd_dev->size, n, disk);
+	if (err)
+		goto out_cleanup_disk;
+
 	ubd_gendisk[n] = disk;
 	return 0;
 
+out_cleanup_disk:
+	blk_cleanup_disk(disk);
 out_cleanup_tags:
 	blk_mq_free_tag_set(&ubd_dev->tag_set);
 out:
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Fri Oct 15 23:31:09 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 23:31:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.211131.368262 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbWfN-0001K5-32; Fri, 15 Oct 2021 23:31:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 211131.368262; Fri, 15 Oct 2021 23:31:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbWfM-0001Jr-WD; Fri, 15 Oct 2021 23:31:08 +0000
Received: by outflank-mailman (input) for mailman id 211131;
 Fri, 15 Oct 2021 23:31:07 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ZYBM=PD=infradead.org=mcgrof@srs-us1.protection.inumbo.net>)
 id 1mbWfL-0000i4-3l
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 23:31:07 +0000
Received: from bombadil.infradead.org (unknown [2607:7c80:54:e::133])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 36687f3e-9db5-49d6-a118-80a78d51faf4;
 Fri, 15 Oct 2021 23:30:56 +0000 (UTC)
Received: from mcgrof by bombadil.infradead.org with local (Exim 4.94.2 #2
 (Red Hat Linux)) id 1mbWej-0095ur-55; Fri, 15 Oct 2021 23:30:29 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
X-Inumbo-ID: 36687f3e-9db5-49d6-a118-80a78d51faf4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Sender:Content-Transfer-Encoding:
	MIME-Version:Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-Type:
	Content-ID:Content-Description:In-Reply-To:References;
	bh=0/vUy76aoPqtosIeLCeI7X3UUbEJbC7MDQlzKX9/imU=; b=Qu5GFvduvjpL/149x5vJFhyA9d
	OHeXqOlyZYRjWN9OS2cCc07oQgdMYKnZtAKIhxuxO+HOF4yeuDfBrl9hts78YInLDdv4S1rButLnj
	ZW99/qMPGJ5nMZJ9n3SQjUlAws+mYXHbdvkvNeipgadm4ZCSQRzlOb/WRTd+64VXK3M5e5LsEEnb2
	H5xrHiyIX3qjAzKgsMAOhSEUf9hGBzS4i09QsHZ8LWqrneE0BVQm8yNdYbNWIfbGaMgIn4ks0Mer/
	aFrzChQyVK9ZQPEijiEBdBivuALzv2afyXywT/Z3bOHrCprGl8US5syTuD2h/pFd2RAHvysZ7I7mJ
	OJ+4BK4Q==;
From: Luis Chamberlain <mcgrof@kernel.org>
To: axboe@kernel.dk,
	jejb@linux.ibm.com,
	martin.petersen@oracle.com,
	agk@redhat.com,
	snitzer@redhat.com,
	colyli@suse.de,
	kent.overstreet@gmail.com,
	boris.ostrovsky@oracle.com,
	jgross@suse.com,
	sstabellini@kernel.org,
	roger.pau@citrix.com,
	geert@linux-m68k.org,
	ulf.hansson@linaro.org,
	tj@kernel.org,
	hare@suse.de,
	jdike@addtoit.com,
	richard@nod.at,
	anton.ivanov@cambridgegreys.com,
	johannes.berg@intel.com,
	krisman@collabora.com,
	chris.obbard@collabora.com,
	thehajime@gmail.com,
	zhuyifei1999@gmail.com,
	haris.iqbal@ionos.com,
	jinpu.wang@ionos.com,
	miquel.raynal@bootlin.com,
	vigneshr@ti.com,
	linux-mtd@lists.infradead.org
Cc: linux-scsi@vger.kernel.org,
	dm-devel@redhat.com,
	linux-bcache@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	linux-m68k@lists.linux-m68k.org,
	linux-um@lists.infradead.org,
	linux-block@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Luis Chamberlain <mcgrof@kernel.org>
Subject: [PATCH 0/9] block: reviewed add_disk() error handling set
Date: Fri, 15 Oct 2021 16:30:19 -0700
Message-Id: <20211015233028.2167651-1-mcgrof@kernel.org>
X-Mailer: git-send-email 2.31.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: Luis Chamberlain <mcgrof@infradead.org>

Jens,

I had last split up patches into 7 groups, but at this point now
most changes are merged except a few more drivers. Instead of creating
a new patch set for each of the 7 groups I'm creating 3 new groups of
patches now:

  * This set, for which we already have an Acked-by or Reviewed-by tag,
    it would be nice to get clarification of driver maintainers want
    these to go through you or if a the maintainers want to pick these
    changes up themselves.

  * A second set will deal with patches which have no reviews done for
    them yet 

  * The last set deals with the __register_blkdev() change and the
    __must_check change which ensures we don't let in new drivers
    which don't deal with error handling.

If you're a maintainer of any of the below patches and wish for them to
go through Jens' tree directly now would be a good time to say so or
you can just pick the patch up yourself.

Luis Chamberlain (9):
  scsi/sd: add error handling support for add_disk()
  scsi/sr: add error handling support for add_disk()
  dm: add add_disk() error handling
  bcache: add error handling support for add_disk()
  xen-blkfront: add error handling support for add_disk()
  m68k/emu/nfblock: add error handling support for add_disk()
  um/drivers/ubd_kern: add error handling support for add_disk()
  rnbd: add error handling support for add_disk()
  mtd: add add_disk() error handling

 arch/m68k/emu/nfblock.c       |  9 +++++++--
 arch/um/drivers/ubd_kern.c    | 13 +++++++++----
 drivers/block/rnbd/rnbd-clt.c | 13 +++++++++----
 drivers/block/xen-blkfront.c  |  8 +++++++-
 drivers/md/bcache/super.c     | 17 ++++++++++++-----
 drivers/md/dm.c               |  4 +++-
 drivers/mtd/mtd_blkdevs.c     |  6 +++++-
 drivers/scsi/sd.c             |  8 +++++++-
 drivers/scsi/sr.c             |  7 ++++++-
 9 files changed, 65 insertions(+), 20 deletions(-)

-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Fri Oct 15 23:31:13 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 23:31:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.211132.368273 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbWfR-0001ff-Eq; Fri, 15 Oct 2021 23:31:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 211132.368273; Fri, 15 Oct 2021 23:31:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbWfR-0001fU-Ae; Fri, 15 Oct 2021 23:31:13 +0000
Received: by outflank-mailman (input) for mailman id 211132;
 Fri, 15 Oct 2021 23:31:12 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ZYBM=PD=infradead.org=mcgrof@srs-us1.protection.inumbo.net>)
 id 1mbWfQ-0000i4-3r
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 23:31:12 +0000
Received: from bombadil.infradead.org (unknown [2607:7c80:54:e::133])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 6e90cedc-e943-40d0-ba37-340a88011eb1;
 Fri, 15 Oct 2021 23:30:57 +0000 (UTC)
Received: from mcgrof by bombadil.infradead.org with local (Exim 4.94.2 #2
 (Red Hat Linux)) id 1mbWej-0095v1-AI; Fri, 15 Oct 2021 23:30:29 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
X-Inumbo-ID: 6e90cedc-e943-40d0-ba37-340a88011eb1
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Sender:Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:
	Reply-To:Content-Type:Content-ID:Content-Description;
	bh=U16tRkYxOu2xTupE2mvnO7g0MO56Pwj7My6exHcD7bk=; b=SMPXMOkYs49b2c68ayB39v03zE
	1JbaklyNPDkaFFKPIXJZSSf9JcNnGytHsTLxnHHQA91QOrgnaKH/dLotpGBtyzbNzYxWMbm6l5XQK
	+VrXpCqV6xYKGZthiSp/C2mY62tj1C8bC4VDaVWWAqDgxXXxLsfk3NO3Y3R/Ly8UnemuQck06fwiw
	k+nhdx+1yKj/AmmFUFCI4buRGvoBC+xntL9ylynuTURoS86DXIkYd1Ev5Vq6pSXk2TDGlcg1vt8CR
	wRa1vy5MYVu0t5ZCYrJOvV4bPw2j3MZaKqQJzqy/uCT64e5hx776C5FvqrkL4WyO4f7ES6KOhW78j
	nMYiK8XA==;
From: Luis Chamberlain <mcgrof@kernel.org>
To: axboe@kernel.dk,
	jejb@linux.ibm.com,
	martin.petersen@oracle.com,
	agk@redhat.com,
	snitzer@redhat.com,
	colyli@suse.de,
	kent.overstreet@gmail.com,
	boris.ostrovsky@oracle.com,
	jgross@suse.com,
	sstabellini@kernel.org,
	roger.pau@citrix.com,
	geert@linux-m68k.org,
	ulf.hansson@linaro.org,
	tj@kernel.org,
	hare@suse.de,
	jdike@addtoit.com,
	richard@nod.at,
	anton.ivanov@cambridgegreys.com,
	johannes.berg@intel.com,
	krisman@collabora.com,
	chris.obbard@collabora.com,
	thehajime@gmail.com,
	zhuyifei1999@gmail.com,
	haris.iqbal@ionos.com,
	jinpu.wang@ionos.com,
	miquel.raynal@bootlin.com,
	vigneshr@ti.com,
	linux-mtd@lists.infradead.org
Cc: linux-scsi@vger.kernel.org,
	dm-devel@redhat.com,
	linux-bcache@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	linux-m68k@lists.linux-m68k.org,
	linux-um@lists.infradead.org,
	linux-block@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Luis Chamberlain <mcgrof@kernel.org>
Subject: [PATCH 5/9] xen-blkfront: add error handling support for add_disk()
Date: Fri, 15 Oct 2021 16:30:24 -0700
Message-Id: <20211015233028.2167651-6-mcgrof@kernel.org>
X-Mailer: git-send-email 2.31.1
In-Reply-To: <20211015233028.2167651-1-mcgrof@kernel.org>
References: <20211015233028.2167651-1-mcgrof@kernel.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: Luis Chamberlain <mcgrof@infradead.org>

We never checked for errors on device_add_disk() as this function
returned void. Now that this is fixed, use the shiny new error
handling. The function xlvbd_alloc_gendisk() typically does the
unwinding on error on allocating the disk and creating the tag,
but since all that error handling was stuffed inside
xlvbd_alloc_gendisk() we must repeat the tag free'ing as well.

We set the info->rq to NULL to ensure blkif_free() doesn't crash
on blk_mq_stop_hw_queues() on device_add_disk() error as the queue
will be long gone by then.

Reviewed-by: Juergen Gross <jgross@suse.com>
Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
---
 drivers/block/xen-blkfront.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c
index df0deb927760..8e3983e456f3 100644
--- a/drivers/block/xen-blkfront.c
+++ b/drivers/block/xen-blkfront.c
@@ -2386,7 +2386,13 @@ static void blkfront_connect(struct blkfront_info *info)
 	for_each_rinfo(info, rinfo, i)
 		kick_pending_request_queues(rinfo);
 
-	device_add_disk(&info->xbdev->dev, info->gd, NULL);
+	err = device_add_disk(&info->xbdev->dev, info->gd, NULL);
+	if (err) {
+		blk_cleanup_disk(info->gd);
+		blk_mq_free_tag_set(&info->tag_set);
+		info->rq = NULL;
+		goto fail;
+	}
 
 	info->is_ready = 1;
 	return;
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Fri Oct 15 23:31:18 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 23:31:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.211134.368284 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbWfW-00027N-Qd; Fri, 15 Oct 2021 23:31:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 211134.368284; Fri, 15 Oct 2021 23:31:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbWfW-00027B-Kh; Fri, 15 Oct 2021 23:31:18 +0000
Received: by outflank-mailman (input) for mailman id 211134;
 Fri, 15 Oct 2021 23:31:17 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ZYBM=PD=infradead.org=mcgrof@srs-us1.protection.inumbo.net>)
 id 1mbWfV-0000i4-3v
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 23:31:17 +0000
Received: from bombadil.infradead.org (unknown [2607:7c80:54:e::133])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id ec0fe7fb-3101-4ea6-8b6e-55e8114f01cc;
 Fri, 15 Oct 2021 23:30:57 +0000 (UTC)
Received: from mcgrof by bombadil.infradead.org with local (Exim 4.94.2 #2
 (Red Hat Linux)) id 1mbWej-0095ux-8E; Fri, 15 Oct 2021 23:30:29 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
X-Inumbo-ID: ec0fe7fb-3101-4ea6-8b6e-55e8114f01cc
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Sender:Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:
	Reply-To:Content-Type:Content-ID:Content-Description;
	bh=o1//ec0r5e8VTnwYNp5R5eQwtP7WISCGubCypYTw4Jw=; b=LW2F7o9AfnmLff+UOqZtBvoesh
	ZDxjZh8yGJTFjoCXtG72Qf6wiK50Ivqs2nLYTyK0D4PE3RqGQeM7NHkQc1HgaiuC389ySfZ9y6tbY
	VRe+cl9qKO5Q6YIJqZ7sL3W1y4lRXKxWamL98pgo7JKgSyLRT/JDscfv355hCy4dMGDT46XBVp+Nm
	wVo9xMhmi3IrJFUR2gl64sdIHlMJnpD1Q59OFtrhwk/RMNq6/KnSG6DyCHHu7BJ6DTes7dtF/Fbid
	VAD77+Ygj0Xd4lLc0+I1bb/qHRVoHESD8eaekIlUicJJVR3pSkX9z1zbRu8FVAewt6xEX6yxhkckp
	FUXhxm9Q==;
From: Luis Chamberlain <mcgrof@kernel.org>
To: axboe@kernel.dk,
	jejb@linux.ibm.com,
	martin.petersen@oracle.com,
	agk@redhat.com,
	snitzer@redhat.com,
	colyli@suse.de,
	kent.overstreet@gmail.com,
	boris.ostrovsky@oracle.com,
	jgross@suse.com,
	sstabellini@kernel.org,
	roger.pau@citrix.com,
	geert@linux-m68k.org,
	ulf.hansson@linaro.org,
	tj@kernel.org,
	hare@suse.de,
	jdike@addtoit.com,
	richard@nod.at,
	anton.ivanov@cambridgegreys.com,
	johannes.berg@intel.com,
	krisman@collabora.com,
	chris.obbard@collabora.com,
	thehajime@gmail.com,
	zhuyifei1999@gmail.com,
	haris.iqbal@ionos.com,
	jinpu.wang@ionos.com,
	miquel.raynal@bootlin.com,
	vigneshr@ti.com,
	linux-mtd@lists.infradead.org
Cc: linux-scsi@vger.kernel.org,
	dm-devel@redhat.com,
	linux-bcache@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	linux-m68k@lists.linux-m68k.org,
	linux-um@lists.infradead.org,
	linux-block@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Luis Chamberlain <mcgrof@kernel.org>
Subject: [PATCH 3/9] dm: add add_disk() error handling
Date: Fri, 15 Oct 2021 16:30:22 -0700
Message-Id: <20211015233028.2167651-4-mcgrof@kernel.org>
X-Mailer: git-send-email 2.31.1
In-Reply-To: <20211015233028.2167651-1-mcgrof@kernel.org>
References: <20211015233028.2167651-1-mcgrof@kernel.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: Luis Chamberlain <mcgrof@infradead.org>

We never checked for errors on add_disk() as this function
returned void. Now that this is fixed, use the shiny new
error handling.

There are two calls to dm_setup_md_queue() which can fail then,
one on dm_early_create() and we can easily see that the error path
there calls dm_destroy in the error path. The other use case is on
the ioctl table_load case. If that fails userspace needs to call
the DM_DEV_REMOVE_CMD to cleanup the state - similar to any other
failure.

Reviewed-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
---
 drivers/md/dm.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/md/dm.c b/drivers/md/dm.c
index 245fa4153306..6d3265ed37c0 100644
--- a/drivers/md/dm.c
+++ b/drivers/md/dm.c
@@ -2086,7 +2086,9 @@ int dm_setup_md_queue(struct mapped_device *md, struct dm_table *t)
 	if (r)
 		return r;
 
-	add_disk(md->disk);
+	r = add_disk(md->disk);
+	if (r)
+		return r;
 
 	r = dm_sysfs_init(md);
 	if (r) {
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Fri Oct 15 23:31:24 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 23:31:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.211136.368295 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbWfc-0002el-7P; Fri, 15 Oct 2021 23:31:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 211136.368295; Fri, 15 Oct 2021 23:31:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbWfc-0002eV-44; Fri, 15 Oct 2021 23:31:24 +0000
Received: by outflank-mailman (input) for mailman id 211136;
 Fri, 15 Oct 2021 23:31:22 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ZYBM=PD=infradead.org=mcgrof@srs-us1.protection.inumbo.net>)
 id 1mbWfa-0000i4-47
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 23:31:22 +0000
Received: from bombadil.infradead.org (unknown [2607:7c80:54:e::133])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id fb657709-bd0e-43d7-a49b-e78526a8b8fc;
 Fri, 15 Oct 2021 23:30:56 +0000 (UTC)
Received: from mcgrof by bombadil.infradead.org with local (Exim 4.94.2 #2
 (Red Hat Linux)) id 1mbWej-0095uv-7C; Fri, 15 Oct 2021 23:30:29 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
X-Inumbo-ID: fb657709-bd0e-43d7-a49b-e78526a8b8fc
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Sender:Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:
	Reply-To:Content-Type:Content-ID:Content-Description;
	bh=aZFecDF1ldcXYk4nHZIO3Oiyap30nIpOJCBEBcBqi0s=; b=HD+Qk+Bx+MpXZU2MHZ4t4Sxat2
	DNGC19tZqsNk5kaOdxLSoQOdAlgAopH4u4gn2XKvhwhhnLHxdWWqN5fCxYWfdEGroOdDkyQFSgVIM
	3NVYP1J6+CVjAH3Hab0vM3zi+zurKIUbPO2QHwBtJeapE+UxtfJCUFN8yoCUrvsHWJZZS4+8Q/on9
	WjWMykMGWnpnRaJrC2ZUBSpQheXdKedAalVoZCgNhqi0wY9btFxH319CAejwGgXRMvmWBVKs9t1kj
	/PlJZy2TK+edVXplwI9ClsL3xg19IRPdhsGIvvZ8RZLaiVWOCF7uYcsZOI48v/N59scjY1eDLwSpr
	zZKZhP1g==;
From: Luis Chamberlain <mcgrof@kernel.org>
To: axboe@kernel.dk,
	jejb@linux.ibm.com,
	martin.petersen@oracle.com,
	agk@redhat.com,
	snitzer@redhat.com,
	colyli@suse.de,
	kent.overstreet@gmail.com,
	boris.ostrovsky@oracle.com,
	jgross@suse.com,
	sstabellini@kernel.org,
	roger.pau@citrix.com,
	geert@linux-m68k.org,
	ulf.hansson@linaro.org,
	tj@kernel.org,
	hare@suse.de,
	jdike@addtoit.com,
	richard@nod.at,
	anton.ivanov@cambridgegreys.com,
	johannes.berg@intel.com,
	krisman@collabora.com,
	chris.obbard@collabora.com,
	thehajime@gmail.com,
	zhuyifei1999@gmail.com,
	haris.iqbal@ionos.com,
	jinpu.wang@ionos.com,
	miquel.raynal@bootlin.com,
	vigneshr@ti.com,
	linux-mtd@lists.infradead.org
Cc: linux-scsi@vger.kernel.org,
	dm-devel@redhat.com,
	linux-bcache@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	linux-m68k@lists.linux-m68k.org,
	linux-um@lists.infradead.org,
	linux-block@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Luis Chamberlain <mcgrof@kernel.org>,
	Christoph Hellwig <hch@lst.de>
Subject: [PATCH 2/9] scsi/sr: add error handling support for add_disk()
Date: Fri, 15 Oct 2021 16:30:21 -0700
Message-Id: <20211015233028.2167651-3-mcgrof@kernel.org>
X-Mailer: git-send-email 2.31.1
In-Reply-To: <20211015233028.2167651-1-mcgrof@kernel.org>
References: <20211015233028.2167651-1-mcgrof@kernel.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: Luis Chamberlain <mcgrof@infradead.org>

We never checked for errors on add_disk() as this function
returned void. Now that this is fixed, use the shiny new
error handling.

Just put the cdrom kref and have the unwinding be done by
sr_kref_release().

Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
---
 drivers/scsi/sr.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/drivers/scsi/sr.c b/drivers/scsi/sr.c
index 115f7ef7a5de..4e5515848fa6 100644
--- a/drivers/scsi/sr.c
+++ b/drivers/scsi/sr.c
@@ -728,7 +728,12 @@ static int sr_probe(struct device *dev)
 	dev_set_drvdata(dev, cd);
 	disk->flags |= GENHD_FL_REMOVABLE;
 	sr_revalidate_disk(cd);
-	device_add_disk(&sdev->sdev_gendev, disk, NULL);
+
+	error = device_add_disk(&sdev->sdev_gendev, disk, NULL);
+	if (error) {
+		kref_put(&cd->kref, sr_kref_release);
+		goto fail;
+	}
 
 	sdev_printk(KERN_DEBUG, sdev,
 		    "Attached scsi CD-ROM %s\n", cd->cdi.name);
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Fri Oct 15 23:31:28 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 23:31:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.211137.368305 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbWfg-0003Bz-HX; Fri, 15 Oct 2021 23:31:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 211137.368305; Fri, 15 Oct 2021 23:31:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbWfg-0003Bl-ED; Fri, 15 Oct 2021 23:31:28 +0000
Received: by outflank-mailman (input) for mailman id 211137;
 Fri, 15 Oct 2021 23:31:27 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ZYBM=PD=infradead.org=mcgrof@srs-us1.protection.inumbo.net>)
 id 1mbWff-0000i4-4H
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 23:31:27 +0000
Received: from bombadil.infradead.org (unknown [2607:7c80:54:e::133])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 27a045e9-e729-4dfc-ac2f-7a5ade56d66b;
 Fri, 15 Oct 2021 23:30:57 +0000 (UTC)
Received: from mcgrof by bombadil.infradead.org with local (Exim 4.94.2 #2
 (Red Hat Linux)) id 1mbWej-0095v9-FL; Fri, 15 Oct 2021 23:30:29 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
X-Inumbo-ID: 27a045e9-e729-4dfc-ac2f-7a5ade56d66b
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Sender:Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:
	Reply-To:Content-Type:Content-ID:Content-Description;
	bh=1bxbk0s3lfDVOxUu9YL+DFpJGCsQmsW80G59PebYRqE=; b=aalz1ZDhgOT13yhanR/NqZ5sjs
	X5pioDiqsq7wCK2104+ErSt/d87llJaWu6pQoxxECmaoO81hQebB3KNTX5PwVwh0Wlle8KkYwZZBB
	EY4W4L6CCmX4otbH/vrigBKCha0gJhBOPJveGJURS1xTFt80WQfF7LB3v5CMYxLrjOS8eZd3kniVy
	HyXUMIAEzA7S5SKbG2+6Yqkl2uLf/5+8Zq1fNAP9Axdv7DJBliakso6t7DsDPgMdI8rCvMziP5o8M
	CGo1BDA88hi8eOF897sCgWMsxi2JB/fnJEqvFbB4ooRNqP1S/IXuebirvfHfM/xaTn3IphBxajPsD
	XdhftxIw==;
From: Luis Chamberlain <mcgrof@kernel.org>
To: axboe@kernel.dk,
	jejb@linux.ibm.com,
	martin.petersen@oracle.com,
	agk@redhat.com,
	snitzer@redhat.com,
	colyli@suse.de,
	kent.overstreet@gmail.com,
	boris.ostrovsky@oracle.com,
	jgross@suse.com,
	sstabellini@kernel.org,
	roger.pau@citrix.com,
	geert@linux-m68k.org,
	ulf.hansson@linaro.org,
	tj@kernel.org,
	hare@suse.de,
	jdike@addtoit.com,
	richard@nod.at,
	anton.ivanov@cambridgegreys.com,
	johannes.berg@intel.com,
	krisman@collabora.com,
	chris.obbard@collabora.com,
	thehajime@gmail.com,
	zhuyifei1999@gmail.com,
	haris.iqbal@ionos.com,
	jinpu.wang@ionos.com,
	miquel.raynal@bootlin.com,
	vigneshr@ti.com,
	linux-mtd@lists.infradead.org
Cc: linux-scsi@vger.kernel.org,
	dm-devel@redhat.com,
	linux-bcache@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	linux-m68k@lists.linux-m68k.org,
	linux-um@lists.infradead.org,
	linux-block@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Luis Chamberlain <mcgrof@kernel.org>
Subject: [PATCH 9/9] mtd: add add_disk() error handling
Date: Fri, 15 Oct 2021 16:30:28 -0700
Message-Id: <20211015233028.2167651-10-mcgrof@kernel.org>
X-Mailer: git-send-email 2.31.1
In-Reply-To: <20211015233028.2167651-1-mcgrof@kernel.org>
References: <20211015233028.2167651-1-mcgrof@kernel.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: Luis Chamberlain <mcgrof@infradead.org>

We never checked for errors on add_disk() as this function
returned void. Now that this is fixed, use the shiny new
error handling.

Acked-by: Miquel Raynal <miquel.raynal@bootlin.com>
Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
---
 drivers/mtd/mtd_blkdevs.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/mtd/mtd_blkdevs.c b/drivers/mtd/mtd_blkdevs.c
index b8ae1ec14e17..4eaba6f4ec68 100644
--- a/drivers/mtd/mtd_blkdevs.c
+++ b/drivers/mtd/mtd_blkdevs.c
@@ -384,7 +384,9 @@ int add_mtd_blktrans_dev(struct mtd_blktrans_dev *new)
 	if (new->readonly)
 		set_disk_ro(gd, 1);
 
-	device_add_disk(&new->mtd->dev, gd, NULL);
+	ret = device_add_disk(&new->mtd->dev, gd, NULL);
+	if (ret)
+		goto out_cleanup_disk;
 
 	if (new->disk_attributes) {
 		ret = sysfs_create_group(&disk_to_dev(gd)->kobj,
@@ -393,6 +395,8 @@ int add_mtd_blktrans_dev(struct mtd_blktrans_dev *new)
 	}
 	return 0;
 
+out_cleanup_disk:
+	blk_cleanup_disk(new->disk);
 out_free_tag_set:
 	blk_mq_free_tag_set(new->tag_set);
 out_kfree_tag_set:
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Fri Oct 15 23:31:33 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 23:31:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.211141.368317 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbWfl-0003iX-1n; Fri, 15 Oct 2021 23:31:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 211141.368317; Fri, 15 Oct 2021 23:31:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbWfk-0003hw-Re; Fri, 15 Oct 2021 23:31:32 +0000
Received: by outflank-mailman (input) for mailman id 211141;
 Fri, 15 Oct 2021 23:31:32 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ZYBM=PD=infradead.org=mcgrof@srs-us1.protection.inumbo.net>)
 id 1mbWfk-0000i4-4S
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 23:31:32 +0000
Received: from bombadil.infradead.org (unknown [2607:7c80:54:e::133])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 26397316-d3ca-4d18-9a4b-cf635678a856;
 Fri, 15 Oct 2021 23:30:57 +0000 (UTC)
Received: from mcgrof by bombadil.infradead.org with local (Exim 4.94.2 #2
 (Red Hat Linux)) id 1mbWej-0095v7-E9; Fri, 15 Oct 2021 23:30:29 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
X-Inumbo-ID: 26397316-d3ca-4d18-9a4b-cf635678a856
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Sender:Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:
	Reply-To:Content-Type:Content-ID:Content-Description;
	bh=rG9IqTjAKDoxlaB9WcX4+FIDpVpRocTi/WMidAyqb5E=; b=zZoTqdfJ9Fxpi6GVhbzlxeBy5Z
	TSHUOtdRa3bmpLqWSLW0djXO8cm89eWDPeRyuLhvJmh9r4yCfAdeswev1Akm1dngsVKrFxxVL/vwK
	/o0NcsEQRPnpKqBDS1R1QPBK6jlB+L2FrQUNxMjpJa0MZyI7LNFOdAQQxAqGzBZuu+NpaCLnK3MOq
	nsEWwUrmMKWD9Ul/gId96Lp5lFjisiK/c0hgYHvTulpiaTXtvHI9nZC5vP4MLTaqoMmCcfqzH0mzI
	6UZRd/twOEufTonfDKYrunADAuSDWqwpR01BKU3v0w7aRz+6+suErEvLj7p0zymwJC/+eLN8Tnv2x
	9guF9rCQ==;
From: Luis Chamberlain <mcgrof@kernel.org>
To: axboe@kernel.dk,
	jejb@linux.ibm.com,
	martin.petersen@oracle.com,
	agk@redhat.com,
	snitzer@redhat.com,
	colyli@suse.de,
	kent.overstreet@gmail.com,
	boris.ostrovsky@oracle.com,
	jgross@suse.com,
	sstabellini@kernel.org,
	roger.pau@citrix.com,
	geert@linux-m68k.org,
	ulf.hansson@linaro.org,
	tj@kernel.org,
	hare@suse.de,
	jdike@addtoit.com,
	richard@nod.at,
	anton.ivanov@cambridgegreys.com,
	johannes.berg@intel.com,
	krisman@collabora.com,
	chris.obbard@collabora.com,
	thehajime@gmail.com,
	zhuyifei1999@gmail.com,
	haris.iqbal@ionos.com,
	jinpu.wang@ionos.com,
	miquel.raynal@bootlin.com,
	vigneshr@ti.com,
	linux-mtd@lists.infradead.org
Cc: linux-scsi@vger.kernel.org,
	dm-devel@redhat.com,
	linux-bcache@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	linux-m68k@lists.linux-m68k.org,
	linux-um@lists.infradead.org,
	linux-block@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Luis Chamberlain <mcgrof@kernel.org>
Subject: [PATCH 8/9] rnbd: add error handling support for add_disk()
Date: Fri, 15 Oct 2021 16:30:27 -0700
Message-Id: <20211015233028.2167651-9-mcgrof@kernel.org>
X-Mailer: git-send-email 2.31.1
In-Reply-To: <20211015233028.2167651-1-mcgrof@kernel.org>
References: <20211015233028.2167651-1-mcgrof@kernel.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: Luis Chamberlain <mcgrof@infradead.org>

We never checked for errors on add_disk() as this function
returned void. Now that this is fixed, use the shiny new
error handling.

Acked-by: Jack Wang <jinpu.wang@ionos.com>
Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
---
 drivers/block/rnbd/rnbd-clt.c | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)

diff --git a/drivers/block/rnbd/rnbd-clt.c b/drivers/block/rnbd/rnbd-clt.c
index 5864c9b46cb9..3b78dc55a9a2 100644
--- a/drivers/block/rnbd/rnbd-clt.c
+++ b/drivers/block/rnbd/rnbd-clt.c
@@ -1384,8 +1384,10 @@ static void setup_request_queue(struct rnbd_clt_dev *dev)
 	blk_queue_write_cache(dev->queue, dev->wc, dev->fua);
 }
 
-static void rnbd_clt_setup_gen_disk(struct rnbd_clt_dev *dev, int idx)
+static int rnbd_clt_setup_gen_disk(struct rnbd_clt_dev *dev, int idx)
 {
+	int err;
+
 	dev->gd->major		= rnbd_client_major;
 	dev->gd->first_minor	= idx << RNBD_PART_BITS;
 	dev->gd->minors		= 1 << RNBD_PART_BITS;
@@ -1410,7 +1412,11 @@ static void rnbd_clt_setup_gen_disk(struct rnbd_clt_dev *dev, int idx)
 
 	if (!dev->rotational)
 		blk_queue_flag_set(QUEUE_FLAG_NONROT, dev->queue);
-	add_disk(dev->gd);
+	err = add_disk(dev->gd);
+	if (err)
+		blk_cleanup_disk(dev->gd);
+
+	return err;
 }
 
 static int rnbd_client_setup_device(struct rnbd_clt_dev *dev)
@@ -1426,8 +1432,7 @@ static int rnbd_client_setup_device(struct rnbd_clt_dev *dev)
 	rnbd_init_mq_hw_queues(dev);
 
 	setup_request_queue(dev);
-	rnbd_clt_setup_gen_disk(dev, idx);
-	return 0;
+	return rnbd_clt_setup_gen_disk(dev, idx);
 }
 
 static struct rnbd_clt_dev *init_dev(struct rnbd_clt_session *sess,
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Fri Oct 15 23:31:38 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 23:31:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.211147.368328 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbWfq-0004KB-8O; Fri, 15 Oct 2021 23:31:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 211147.368328; Fri, 15 Oct 2021 23:31:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbWfq-0004Jl-45; Fri, 15 Oct 2021 23:31:38 +0000
Received: by outflank-mailman (input) for mailman id 211147;
 Fri, 15 Oct 2021 23:31:37 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ZYBM=PD=infradead.org=mcgrof@srs-us1.protection.inumbo.net>)
 id 1mbWfp-0000i4-4a
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 23:31:37 +0000
Received: from bombadil.infradead.org (unknown [2607:7c80:54:e::133])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 1469910f-8477-418a-950d-d21ea64b40cf;
 Fri, 15 Oct 2021 23:30:58 +0000 (UTC)
Received: from mcgrof by bombadil.infradead.org with local (Exim 4.94.2 #2
 (Red Hat Linux)) id 1mbWej-0095uz-9F; Fri, 15 Oct 2021 23:30:29 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
X-Inumbo-ID: 1469910f-8477-418a-950d-d21ea64b40cf
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Sender:Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:
	Reply-To:Content-Type:Content-ID:Content-Description;
	bh=hYL8LO+ietZVLiEWE2oEBW5mwRVdCiTP81FH5yaWaJI=; b=f+ADLXwubj85qcYLZJoMkaccF0
	LA88l99fFG2x11Wj0W927MuLNzxH+aLXSi41Sta0kPK0c00mcuAfJRMhRo8O2/gVT8jFEkt0Zk4hr
	nRpIIyZaEygIxOu2Ir+1WF5xTs39HUTMf1P+eojMMuW0QLIF0wbil/OQxvEmzd64iDDxrFcmE+0yv
	kE8A86cACAhv+x1ja677g+NC4hNwoUKBXx1xqWEMK3YQiQVLgxdzr8G77MuSAupgfSMZX4TFT1Edb
	SbvQjQ/3HgQObpF99DOxhOoPdReW+f1FUge3qPoQJgqPVxOn1VIhcnU4ycnlt6M5auGj2buchrJJi
	DE0a5Yog==;
From: Luis Chamberlain <mcgrof@kernel.org>
To: axboe@kernel.dk,
	jejb@linux.ibm.com,
	martin.petersen@oracle.com,
	agk@redhat.com,
	snitzer@redhat.com,
	colyli@suse.de,
	kent.overstreet@gmail.com,
	boris.ostrovsky@oracle.com,
	jgross@suse.com,
	sstabellini@kernel.org,
	roger.pau@citrix.com,
	geert@linux-m68k.org,
	ulf.hansson@linaro.org,
	tj@kernel.org,
	hare@suse.de,
	jdike@addtoit.com,
	richard@nod.at,
	anton.ivanov@cambridgegreys.com,
	johannes.berg@intel.com,
	krisman@collabora.com,
	chris.obbard@collabora.com,
	thehajime@gmail.com,
	zhuyifei1999@gmail.com,
	haris.iqbal@ionos.com,
	jinpu.wang@ionos.com,
	miquel.raynal@bootlin.com,
	vigneshr@ti.com,
	linux-mtd@lists.infradead.org
Cc: linux-scsi@vger.kernel.org,
	dm-devel@redhat.com,
	linux-bcache@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	linux-m68k@lists.linux-m68k.org,
	linux-um@lists.infradead.org,
	linux-block@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Luis Chamberlain <mcgrof@kernel.org>
Subject: [PATCH 4/9] bcache: add error handling support for add_disk()
Date: Fri, 15 Oct 2021 16:30:23 -0700
Message-Id: <20211015233028.2167651-5-mcgrof@kernel.org>
X-Mailer: git-send-email 2.31.1
In-Reply-To: <20211015233028.2167651-1-mcgrof@kernel.org>
References: <20211015233028.2167651-1-mcgrof@kernel.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: Luis Chamberlain <mcgrof@infradead.org>

We never checked for errors on add_disk() as this function
returned void. Now that this is fixed, use the shiny new
error handling.

This driver doesn't do any unwinding with blk_cleanup_disk()
even on errors after add_disk() and so we follow that
tradition.

Acked-by: Coly Li <colyli@suse.de>
Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
---
 drivers/md/bcache/super.c | 17 ++++++++++++-----
 1 file changed, 12 insertions(+), 5 deletions(-)

diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c
index f2874c77ff79..f0c32cdd6594 100644
--- a/drivers/md/bcache/super.c
+++ b/drivers/md/bcache/super.c
@@ -1082,7 +1082,9 @@ int bch_cached_dev_run(struct cached_dev *dc)
 		closure_sync(&cl);
 	}
 
-	add_disk(d->disk);
+	ret = add_disk(d->disk);
+	if (ret)
+		goto out;
 	bd_link_disk_holder(dc->bdev, dc->disk.disk);
 	/*
 	 * won't show up in the uevent file, use udevadm monitor -e instead
@@ -1534,10 +1536,11 @@ static void flash_dev_flush(struct closure *cl)
 
 static int flash_dev_run(struct cache_set *c, struct uuid_entry *u)
 {
+	int err = -ENOMEM;
 	struct bcache_device *d = kzalloc(sizeof(struct bcache_device),
 					  GFP_KERNEL);
 	if (!d)
-		return -ENOMEM;
+		goto err_ret;
 
 	closure_init(&d->cl, NULL);
 	set_closure_fn(&d->cl, flash_dev_flush, system_wq);
@@ -1551,9 +1554,12 @@ static int flash_dev_run(struct cache_set *c, struct uuid_entry *u)
 	bcache_device_attach(d, c, u - c->uuids);
 	bch_sectors_dirty_init(d);
 	bch_flash_dev_request_init(d);
-	add_disk(d->disk);
+	err = add_disk(d->disk);
+	if (err)
+		goto err;
 
-	if (kobject_add(&d->kobj, &disk_to_dev(d->disk)->kobj, "bcache"))
+	err = kobject_add(&d->kobj, &disk_to_dev(d->disk)->kobj, "bcache");
+	if (err)
 		goto err;
 
 	bcache_device_link(d, c, "volume");
@@ -1567,7 +1573,8 @@ static int flash_dev_run(struct cache_set *c, struct uuid_entry *u)
 	return 0;
 err:
 	kobject_put(&d->kobj);
-	return -ENOMEM;
+err_ret:
+	return err;
 }
 
 static int flash_devs_run(struct cache_set *c)
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Fri Oct 15 23:31:43 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 15 Oct 2021 23:31:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.211151.368339 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbWfv-00052o-Jw; Fri, 15 Oct 2021 23:31:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 211151.368339; Fri, 15 Oct 2021 23:31:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbWfv-00052b-FN; Fri, 15 Oct 2021 23:31:43 +0000
Received: by outflank-mailman (input) for mailman id 211151;
 Fri, 15 Oct 2021 23:31:42 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ZYBM=PD=infradead.org=mcgrof@srs-us1.protection.inumbo.net>)
 id 1mbWfu-0000i4-4h
 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 23:31:42 +0000
Received: from bombadil.infradead.org (unknown [2607:7c80:54:e::133])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id d9d9b6e3-f2ec-4260-b0db-a90eb21ca918;
 Fri, 15 Oct 2021 23:31:09 +0000 (UTC)
Received: from mcgrof by bombadil.infradead.org with local (Exim 4.94.2 #2
 (Red Hat Linux)) id 1mbWej-0095v3-Bg; Fri, 15 Oct 2021 23:30:29 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
X-Inumbo-ID: d9d9b6e3-f2ec-4260-b0db-a90eb21ca918
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Sender:Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:
	Reply-To:Content-Type:Content-ID:Content-Description;
	bh=agaE6D36LcS3m3yT/hy8ziCroVpqabvNI/EGY/bikug=; b=JZN7KnMFum6DusEMzQaTsmPto3
	iq0vhkylIJTrRi3kI9DyDDhakbylqaU5ngke9FXegqhHlTjzaES6xYJGeZrlmkrs5X82hd0xUZPly
	51vs2mHbjxbZ/JrfFkVlCzqGzxcHT6V0Rizcnxt0Xea2U4EbeIEwAYjpLQOYDW9BT1bzfC5yajRai
	glC6KamA1aVYdFKGePYEOx2LGrVyVLkNNW+ZqxRXr7CKdibjpFjc4X28nYiugdtg8MptBKUKfdmaw
	DpCnXlnKNpbt7FZn75/eotERzBrmV/jDeJiM/sUdmtdBCIWBuoe8kaRe5aUI7BgROEiElZFn9evkO
	A1LiSSlQ==;
From: Luis Chamberlain <mcgrof@kernel.org>
To: axboe@kernel.dk,
	jejb@linux.ibm.com,
	martin.petersen@oracle.com,
	agk@redhat.com,
	snitzer@redhat.com,
	colyli@suse.de,
	kent.overstreet@gmail.com,
	boris.ostrovsky@oracle.com,
	jgross@suse.com,
	sstabellini@kernel.org,
	roger.pau@citrix.com,
	geert@linux-m68k.org,
	ulf.hansson@linaro.org,
	tj@kernel.org,
	hare@suse.de,
	jdike@addtoit.com,
	richard@nod.at,
	anton.ivanov@cambridgegreys.com,
	johannes.berg@intel.com,
	krisman@collabora.com,
	chris.obbard@collabora.com,
	thehajime@gmail.com,
	zhuyifei1999@gmail.com,
	haris.iqbal@ionos.com,
	jinpu.wang@ionos.com,
	miquel.raynal@bootlin.com,
	vigneshr@ti.com,
	linux-mtd@lists.infradead.org
Cc: linux-scsi@vger.kernel.org,
	dm-devel@redhat.com,
	linux-bcache@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	linux-m68k@lists.linux-m68k.org,
	linux-um@lists.infradead.org,
	linux-block@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Luis Chamberlain <mcgrof@kernel.org>
Subject: [PATCH 6/9] m68k/emu/nfblock: add error handling support for add_disk()
Date: Fri, 15 Oct 2021 16:30:25 -0700
Message-Id: <20211015233028.2167651-7-mcgrof@kernel.org>
X-Mailer: git-send-email 2.31.1
In-Reply-To: <20211015233028.2167651-1-mcgrof@kernel.org>
References: <20211015233028.2167651-1-mcgrof@kernel.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: Luis Chamberlain <mcgrof@infradead.org>

We never checked for errors on add_disk() as this function
returned void. Now that this is fixed, use the shiny new
error handling.

Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>
Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
---
 arch/m68k/emu/nfblock.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/arch/m68k/emu/nfblock.c b/arch/m68k/emu/nfblock.c
index 9a8394e96388..4de5a6087034 100644
--- a/arch/m68k/emu/nfblock.c
+++ b/arch/m68k/emu/nfblock.c
@@ -100,6 +100,7 @@ static int __init nfhd_init_one(int id, u32 blocks, u32 bsize)
 {
 	struct nfhd_device *dev;
 	int dev_id = id - NFHD_DEV_OFFSET;
+	int err = -ENOMEM;
 
 	pr_info("nfhd%u: found device with %u blocks (%u bytes)\n", dev_id,
 		blocks, bsize);
@@ -130,16 +131,20 @@ static int __init nfhd_init_one(int id, u32 blocks, u32 bsize)
 	sprintf(dev->disk->disk_name, "nfhd%u", dev_id);
 	set_capacity(dev->disk, (sector_t)blocks * (bsize / 512));
 	blk_queue_logical_block_size(dev->disk->queue, bsize);
-	add_disk(dev->disk);
+	err = add_disk(dev->disk);
+	if (err)
+		goto out_cleanup_disk;
 
 	list_add_tail(&dev->list, &nfhd_list);
 
 	return 0;
 
+out_cleanup_disk:
+	blk_cleanup_disk(dev->disk);
 free_dev:
 	kfree(dev);
 out:
-	return -ENOMEM;
+	return err;
 }
 
 static int __init nfhd_init(void)
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Sat Oct 16 00:21:05 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 16 Oct 2021 00:21:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.211209.368350 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbXRU-0003Fv-Vi; Sat, 16 Oct 2021 00:20:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 211209.368350; Sat, 16 Oct 2021 00:20:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbXRU-0003Fn-Qu; Sat, 16 Oct 2021 00:20:52 +0000
Received: by outflank-mailman (input) for mailman id 211209;
 Sat, 16 Oct 2021 00:20:52 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mbXRU-0003Fe-H3; Sat, 16 Oct 2021 00:20:52 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mbXRU-0000rA-Ck; Sat, 16 Oct 2021 00:20:52 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mbXRU-0008KX-2S; Sat, 16 Oct 2021 00:20:52 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mbXRU-00051M-1v; Sat, 16 Oct 2021 00:20:52 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=uzjEMla00yRpOu7jEUkbtFzggmtjUrqEt2CMSYI4l48=; b=4YTsZxFTU7eKHa3i2JkSZo2gQC
	8fJx/7FVpyICZHdFd3poCu3Fw8FkyoA9CLYqhPYNe5acH+c9qpHKkYGaLV/ADYs0z4HrYErofnmHP
	PHWgjypd0HcaCVh1hLUbunMVhPZPJOQxH+sAN1erK0gESFAQXvblEQ7aXFAUWxGfFmCw=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165530-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 165530: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=52d0847d7c6972baa74156f14ee8544f5aba1d2d
X-Osstest-Versions-That:
    xen=f791392f82ffe39cc1ea4c4db1d877223754a04a
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 16 Oct 2021 00:20:52 +0000

flight 165530 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165530/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  52d0847d7c6972baa74156f14ee8544f5aba1d2d
baseline version:
 xen                  f791392f82ffe39cc1ea4c4db1d877223754a04a

Last test of basis   165527  2021-10-15 14:01:46 Z    0 days
Testing same since   165530  2021-10-15 20:00:27 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Bertrand Marquis <bertrand.marquis@arm.com>
  Ian Jackson <iwj@xenproject.org>
  Michal Orzel <michal.orzel@arm.com>
  Rahul Singh <rahul.singh@arm.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Stefano Stabellini <stefano.stabellini@xilinx.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   f791392f82..52d0847d7c  52d0847d7c6972baa74156f14ee8544f5aba1d2d -> smoke


From xen-devel-bounces@lists.xenproject.org Sat Oct 16 02:33:36 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 16 Oct 2021 02:33:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.211223.368376 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbZVl-0000Pq-OO; Sat, 16 Oct 2021 02:33:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 211223.368376; Sat, 16 Oct 2021 02:33:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbZVl-0000Pg-Iw; Sat, 16 Oct 2021 02:33:25 +0000
Received: by outflank-mailman (input) for mailman id 211223;
 Sat, 16 Oct 2021 02:33:24 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mbZVk-0000PN-KC; Sat, 16 Oct 2021 02:33:24 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mbZVk-00050f-FW; Sat, 16 Oct 2021 02:33:24 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mbZVk-0008M3-2r; Sat, 16 Oct 2021 02:33:24 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mbZVk-0007li-27; Sat, 16 Oct 2021 02:33:24 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=zoE/EzF5hjjIhhEKgiUwfHCYtzy4MT9uD52hMEEh/m8=; b=R9eY7JxuW+qxlocvm2bwdEEYIP
	EPiauf8SzEPY7zOj1Fkv9J3DiQ7CvWTDyHFjTEGmOJ1YYG6YhZ6USj/2UOJi78Q0M1Co6QonQdO1n
	Rx587W5hf7v2i+DeUyeoqhgAR2DoEGIkdhdx1wqX3SV5gGI970+rcFGwAcCdX64anFHo=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165521-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.15-testing test] 165521: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-4.15-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:guest-start/debianhvm.repeat:fail:heisenbug
    xen-4.15-testing:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    xen-4.15-testing:test-arm64-arm64-xl-vhd:debian-di-install:fail:heisenbug
    xen-4.15-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=f50ef17c9884c0c2d486d3b1de8f110bb6b22c42
X-Osstest-Versions-That:
    xen=3b98d9f35a9edd2502ff9466341132baa6664cc3
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 16 Oct 2021 02:33:24 +0000

flight 165521 xen-4.15-testing real [real]
flight 165532 xen-4.15-testing real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/165521/
http://logs.test-lab.xenproject.org/osstest/logs/165532/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 18 guest-start/debianhvm.repeat fail pass in 165532-retest
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 165532-retest
 test-arm64-arm64-xl-vhd      12 debian-di-install   fail pass in 165532-retest

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-xl-vhd     14 migrate-support-check fail in 165532 never pass
 test-arm64-arm64-xl-vhd 15 saverestore-support-check fail in 165532 never pass
 test-amd64-amd64-xl-rtds     20 guest-localmigrate/x10       fail  like 165387
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 165387
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 165387
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165387
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 165387
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165387
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165387
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 165387
 test-armhf-armhf-xl-rtds     18 guest-start/debian.repeat    fail  like 165387
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 165387
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail like 165387
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 165387
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 165387
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 165387
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 165387
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  f50ef17c9884c0c2d486d3b1de8f110bb6b22c42
baseline version:
 xen                  3b98d9f35a9edd2502ff9466341132baa6664cc3

Last test of basis   165387  2021-10-05 19:06:48 Z   10 days
Testing same since   165521  2021-10-15 09:38:50 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Anthony PERARD <anthony.perard@citrix.com>
  Igor Druzhinin <igor.druzhinin@citrix.com>
  Jan Beulich <jbeulich@suse.com>
  Juergen Gross <jgross@suse.com>
  Kevin Stefanov <kevin.stefanov@citrix.com>
  Roger Pau Monné <roger.pau@citrix.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            fail    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 fail    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     fail    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      fail    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   3b98d9f35a..f50ef17c98  f50ef17c9884c0c2d486d3b1de8f110bb6b22c42 -> stable-4.15


From xen-devel-bounces@lists.xenproject.org Sat Oct 16 05:24:31 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 16 Oct 2021 05:24:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.211247.368442 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbcB7-0008Il-1m; Sat, 16 Oct 2021 05:24:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 211247.368442; Sat, 16 Oct 2021 05:24:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbcB6-0008Ie-UM; Sat, 16 Oct 2021 05:24:16 +0000
Received: by outflank-mailman (input) for mailman id 211247;
 Sat, 16 Oct 2021 05:24:15 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mbcB5-0008IU-5U; Sat, 16 Oct 2021 05:24:15 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mbcB4-0008H9-Tk; Sat, 16 Oct 2021 05:24:14 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mbcB4-0006xJ-Gt; Sat, 16 Oct 2021 05:24:14 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mbcB4-0006lY-GQ; Sat, 16 Oct 2021 05:24:14 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=8T0tlWntAfqxKFfgvoAceCOgu/zyVSEa9AtNkrv7mvg=; b=VHNNigUKWPm40wvPCwzgJgM8z8
	azA24xsZmJV74NCK53kHtdChnqSzxJgl0kC7XTqPlM38n/sgKI5JlxW+xy3sgCrklcb5r3dwbXAER
	smaQgDu/RHdjgVdfOIm16K8WgRmbkUTaOVZHO6UvB3BoXO2UYWyZU4UZwhWIoGtxgBFc=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165524-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 165524: tolerable FAIL
X-Osstest-Failures:
    xen-unstable:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=b75838ad6c4f42c93efee83fc2508c78641e1b57
X-Osstest-Versions-That:
    xen=b75838ad6c4f42c93efee83fc2508c78641e1b57
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 16 Oct 2021 05:24:14 +0000

flight 165524 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165524/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 165515

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-rtds     20 guest-localmigrate/x10       fail  like 165515
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 165515
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 165515
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165515
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165515
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 165515
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 165515
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 165515
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 165515
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 165515
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 165515
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165515
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 165515
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  b75838ad6c4f42c93efee83fc2508c78641e1b57
baseline version:
 xen                  b75838ad6c4f42c93efee83fc2508c78641e1b57

Last test of basis   165524  2021-10-15 11:27:26 Z    0 days
Testing same since                          (not found)         0 attempts

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 fail    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     fail    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Published tested tree is already up to date.



From xen-devel-bounces@lists.xenproject.org Sat Oct 16 06:35:08 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 16 Oct 2021 06:35:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.211256.368456 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbdHS-0006Rp-C3; Sat, 16 Oct 2021 06:34:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 211256.368456; Sat, 16 Oct 2021 06:34:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbdHS-0006Ri-8y; Sat, 16 Oct 2021 06:34:54 +0000
Received: by outflank-mailman (input) for mailman id 211256;
 Sat, 16 Oct 2021 06:34:53 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mbdHR-0006RY-By; Sat, 16 Oct 2021 06:34:53 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mbdHR-00014F-7f; Sat, 16 Oct 2021 06:34:53 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mbdHQ-0003Q5-Ug; Sat, 16 Oct 2021 06:34:53 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mbdHQ-0000il-U8; Sat, 16 Oct 2021 06:34:52 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=izEddrwuHlFch2d44AR09hTZ44m7UCPh6yPrL8BWr/Q=; b=f7l38eBSUEbkQ8J9pV5zndjGiJ
	k/12QzCyEr+GvR079vaFnu2ZZWX/1b2JAi72itzZxaHHr4USp1Jpc8jmIvCziwSWj+7CHIAAFT4cd
	9i6K3S0Aem/6cQvRKc9afm51RQpwLArMWFwwRwKvRBiMiZkCm1sQfeOeraNTkoEm1VR8=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165531-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 165531: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=f10a112f08f3fb4a92c3d22f069f6066a12db3be
X-Osstest-Versions-That:
    ovmf=7e43d3e08611ac4c4bc41c46470052d4118168eb
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 16 Oct 2021 06:34:52 +0000

flight 165531 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165531/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 f10a112f08f3fb4a92c3d22f069f6066a12db3be
baseline version:
 ovmf                 7e43d3e08611ac4c4bc41c46470052d4118168eb

Last test of basis   165523  2021-10-15 11:10:08 Z    0 days
Testing same since   165531  2021-10-15 22:11:21 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Guo Dong <guo.dong@intel.com>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   7e43d3e086..f10a112f08  f10a112f08f3fb4a92c3d22f069f6066a12db3be -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Sat Oct 16 08:13:36 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 16 Oct 2021 08:13:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.211270.368469 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbeol-0007d0-0b; Sat, 16 Oct 2021 08:13:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 211270.368469; Sat, 16 Oct 2021 08:13:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbeok-0007ct-Tp; Sat, 16 Oct 2021 08:13:22 +0000
Received: by outflank-mailman (input) for mailman id 211270;
 Sat, 16 Oct 2021 08:13:22 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mbeok-0007cj-4l; Sat, 16 Oct 2021 08:13:22 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mbeoj-0003Cx-Sk; Sat, 16 Oct 2021 08:13:21 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mbeoj-0006zB-E3; Sat, 16 Oct 2021 08:13:21 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mbeoj-0004xR-Da; Sat, 16 Oct 2021 08:13:21 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=1mVHe+bEeAx+co5xsYOzKdQV9ofsdRBClQlFTXsNV9M=; b=sU0WZxj31Xl9ozez4XKl0Ib8m5
	03XVML3h/49GSlBy7ndymxLhBlWi8UjB8zYUQ+JITZFw4LKF5GjD58wi/HlXP4XHvVHrCEbKFEr91
	iU8XQv2pEakt6/YDU8WSUo8lfTNHywJPYKy9zbcfvCPxcCKnqrVvmoSg6bfgjlOP6uJA=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165528-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 165528: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:guest-localmigrate/x10:fail:heisenbug
    linux-linus:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=8fe31e0995f048d16b378b90926793a0aa4af1e5
X-Osstest-Versions-That:
    linux=ec681c53f8d2d0ee362ff67f5b98dd8263c15002
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 16 Oct 2021 08:13:21 +0000

flight 165528 linux-linus real [real]
flight 165535 linux-linus real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/165528/
http://logs.test-lab.xenproject.org/osstest/logs/165535/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 18 guest-localmigrate/x10 fail pass in 165535-retest

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-rtds     20 guest-localmigrate/x10       fail  like 165518
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 165518
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 165518
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165518
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165518
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 165518
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165518
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 165518
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 165518
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 linux                8fe31e0995f048d16b378b90926793a0aa4af1e5
baseline version:
 linux                ec681c53f8d2d0ee362ff67f5b98dd8263c15002

Last test of basis   165518  2021-10-15 05:57:36 Z    1 days
Testing same since   165528  2021-10-15 16:12:00 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andy Shevchenko <andriy.shevchenko@linux.intel.com>
  Apurva Nandan <a-nandan@ti.com>
  Arnd Bergmann <arnd@arndb.de>
  Bartosz Golaszewski <brgl@bgdev.pl>
  Christian Brauner <christian.brauner@ubuntu.com>
  Christophe JAILLET <christophe.jaillet@wanadoo.fr>
  Chun-Kuang Hu <chunkuang.hu@kernel.org>
  Colin Ian King <colin.king@canonical.com>
  Dafna Hirschfeld <dafna.hirschfeld@collabora.com>
  Dan Carpenter <dan.carpenter@oracle.com>
  Dave Airlie <airlied@redhat.com>
  Dexuan Cui <decui@microsoft.com>
  Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
  Douglas Anderson <dianders@chromium.org>
  Enric Balletbo Serra <eballetbo@gmail.com>
  Fabio Estevam <festevam@gmail.com>
  Florian Fainelli <f.fainelli@gmail.com>
  Geert Uytterhoeven <geert+renesas@glider.be>
  Jani Nikula <jani.nikula@intel.com>
  Kamal Dasu <kdasu@broadcom.com>
  Kari Argillander <kari.argillander@gmail.com>
  Karol Herbst <kherbst@redhat.com>
  Kent Gibson <warthog618@gmail.com>
  Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
  Kuogee Hsieh <khsieh@codeaurora.org>
  Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Lukas Bulwahn <lukas.bulwahn@gmail.com>
  Marek Vasut <marex@denx.de>
  Marijn Suijten <marijn.suijten@somainline.org>
  Mark Brown <broonie@kernel.org>
  Matthew Auld <matthew.auld@intel.com>
  Matthew Brost <matthew.brost@intel.com>
  Md Sadre Alam <mdalam@codeaurora.org>
  Michael Walle <michael@walle.cc>
  Miquel Raynal <miquel.raynal@bootlin.com>
  Nikita Travkin <nikita@trvn.ru>
  Randy Dunlap <rdunlap@infradead.org>
  Rob Clark <robdclark@chromium.org>
  Rob Clark <robdclark@gmail.com>
  Rob Herring <robh@kernel.org>
  Robert Foss <robert.foss@linaro.org>
  Sam Ravnborg <sam@ravnborg.org>
  Stephan Gerhold <stephan@gerhold.net>
  Thomas Zimmermann <tzimmermann@suse.de>
  Tvrtko Ursulin <tvrtko.ursulin@intel.com>
  Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
  Vegard Nossum <vegard.nossum@oracle.com>
  Ville Baillie <villeb@bytesnap.co.uk>
  Ville Syrjälä <ville.syrjala@linux.intel.com>
  Zenghui Yu <yuzenghui@huawei.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        fail    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     fail    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   ec681c53f8d2..8fe31e0995f0  8fe31e0995f048d16b378b90926793a0aa4af1e5 -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Sat Oct 16 09:03:46 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 16 Oct 2021 09:03:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.211281.368484 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbfbI-00048r-0t; Sat, 16 Oct 2021 09:03:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 211281.368484; Sat, 16 Oct 2021 09:03:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbfbH-00048k-TD; Sat, 16 Oct 2021 09:03:31 +0000
Received: by outflank-mailman (input) for mailman id 211281;
 Sat, 16 Oct 2021 09:03:30 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mbfbG-00048a-OE; Sat, 16 Oct 2021 09:03:30 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mbfbG-00041l-Ix; Sat, 16 Oct 2021 09:03:30 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mbfbG-0000xu-Ah; Sat, 16 Oct 2021 09:03:30 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mbfbG-0007rm-AD; Sat, 16 Oct 2021 09:03:30 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=UKlfnDL69ib46BlZxKREQd2jVdUp2QKFywSiyxQ7hhU=; b=1PMYLQFWBZp9eTwsz65D+6O9Gj
	SBIUYR98Hcsp6OaZUJ23rx4QrIAFf+3pXsVW44wVLSMCWjVwNkSLv5gIrYY7KA/ZJOhKbodWyS1Z2
	9D37I0IuQaWAeq2YljYXAMUnIR7hbKbzHr5kbT208NaQkFMon88mjaAuN4JNcyBHHqr0=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165533-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 165533: regressions - FAIL
X-Osstest-Failures:
    libvirt:build-armhf-libvirt:libvirt-build:fail:regression
    libvirt:build-amd64-libvirt:libvirt-build:fail:regression
    libvirt:build-arm64-libvirt:libvirt-build:fail:regression
    libvirt:build-i386-libvirt:libvirt-build:fail:regression
    libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    libvirt=2703b0b5bf2751d523a4d8d61901e473c92ba198
X-Osstest-Versions-That:
    libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 16 Oct 2021 09:03:30 +0000

flight 165533 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165533/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-armhf-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-amd64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-arm64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-i386-libvirt            6 libvirt-build            fail REGR. vs. 151777

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-libvirt-vhd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a

version targeted for testing:
 libvirt              2703b0b5bf2751d523a4d8d61901e473c92ba198
baseline version:
 libvirt              2c846fa6bcc11929c9fb857a22430fb9945654ad

Last test of basis   151777  2020-07-10 04:19:19 Z  463 days
Failing since        151818  2020-07-11 04:18:52 Z  462 days  448 attempts
Testing same since   165533  2021-10-16 04:21:23 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
    Adolfo Jayme Barrientos <fitoschido@gmail.com>
  Aleksandr Alekseev <alexander.alekseev@virtuozzo.com>
  Aleksei Zakharov <zaharov@selectel.ru>
  Andika Triwidada <andika@gmail.com>
  Andrea Bolognani <abologna@redhat.com>
  Ani Sinha <ani@anisinha.ca>
  Balázs Meskó <meskobalazs@mailbox.org>
  Barrett Schonefeld <bschoney@utexas.edu>
  Bastian Germann <bastiangermann@fishpost.de>
  Bastien Orivel <bastien.orivel@diateam.net>
  BiaoXiang Ye <yebiaoxiang@huawei.com>
  Bihong Yu <yubihong@huawei.com>
  Binfeng Wu <wubinfeng@huawei.com>
  Bjoern Walk <bwalk@linux.ibm.com>
  Boris Fiuczynski <fiuczy@linux.ibm.com>
  Brian Turek <brian.turek@gmail.com>
  Bruno Haible <bruno@clisp.org>
  Chris Mayo <aklhfex@gmail.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Ehrhardt <christian.ehrhardt@canonical.com>
  Christian Kirbach <christian.kirbach@gmail.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Cole Robinson <crobinso@redhat.com>
  Collin Walling <walling@linux.ibm.com>
  Cornelia Huck <cohuck@redhat.com>
  Cédric Bosdonnat <cbosdonnat@suse.com>
  Côme Borsoi <fedora@borsoi.fr>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniel Letai <dani@letai.org.il>
  Daniel P. Berrange <berrange@redhat.com>
  Daniel P. Berrangé <berrange@redhat.com>
  Didik Supriadi <didiksupriadi41@gmail.com>
  dinglimin <dinglimin@cmss.chinamobile.com>
  Dmytro Linkin <dlinkin@nvidia.com>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Eric Farman <farman@linux.ibm.com>
  Erik Skultety <eskultet@redhat.com>
  Fabian Affolter <mail@fabian-affolter.ch>
  Fabian Freyer <fabian.freyer@physik.tu-berlin.de>
  Fabiano Fidêncio <fabiano@fidencio.org>
  Fangge Jin <fjin@redhat.com>
  Farhan Ali <alifm@linux.ibm.com>
  Fedora Weblate Translation <i18n@lists.fedoraproject.org>
  Gavi Teitz <gavi@nvidia.com>
  gongwei <gongwei@smartx.com>
  Guoyi Tu<tu.guoyi@h3c.com>
  Göran Uddeborg <goeran@uddeborg.se>
  Halil Pasic <pasic@linux.ibm.com>
  Han Han <hhan@redhat.com>
  Hao Wang <wanghao232@huawei.com>
  Hela Basa <r45xveza@pm.me>
  Helmut Grohne <helmut@subdivi.de>
  Hiroki Narukawa <hnarukaw@yahoo-corp.jp>
  Ian Wienand <iwienand@redhat.com>
  Jakob Meng <jakobmeng@web.de>
  Jamie Strandboge <jamie@canonical.com>
  Jamie Strandboge <jamie@ubuntu.com>
  Jan Kuparinen <copper_fin@hotmail.com>
  jason lee <ppark5237@gmail.com>
  Jean-Baptiste Holcroft <jean-baptiste@holcroft.fr>
  Jia Zhou <zhou.jia2@zte.com.cn>
  Jianan Gao <jgao@redhat.com>
  Jim Fehlig <jfehlig@suse.com>
  Jin Yan <jinyan12@huawei.com>
  Jinsheng Zhang <zhangjl02@inspur.com>
  Jiri Denemark <jdenemar@redhat.com>
  John Ferlan <jferlan@redhat.com>
  Jonathan Watt <jwatt@jwatt.org>
  Jonathon Jongsma <jjongsma@redhat.com>
  Julio Faracco <jcfaracco@gmail.com>
  Justin Gatzen <justin.gatzen@gmail.com>
  Ján Tomko <jtomko@redhat.com>
  Kashyap Chamarthy <kchamart@redhat.com>
  Kevin Locke <kevin@kevinlocke.name>
  Kristina Hanicova <khanicov@redhat.com>
  Laine Stump <laine@redhat.com>
  Laszlo Ersek <lersek@redhat.com>
  Lee Yarwood <lyarwood@redhat.com>
  Lei Yang <yanglei209@huawei.com>
  Liao Pingfang <liao.pingfang@zte.com.cn>
  Lin Ma <lma@suse.com>
  Lin Ma <lma@suse.de>
  Lin Ma <morecache@gmail.com>
  Liu Yiding <liuyd.fnst@fujitsu.com>
  Luke Yue <lukedyue@gmail.com>
  Luyao Zhong <luyao.zhong@intel.com>
  Marc Hartmayer <mhartmay@linux.ibm.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Markus Schade <markus.schade@hetzner.com>
  Martin Kletzander <mkletzan@redhat.com>
  Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
  Matej Cepl <mcepl@cepl.eu>
  Matt Coleman <matt@datto.com>
  Matt Coleman <mcoleman@datto.com>
  Mauro Matteo Cascella <mcascell@redhat.com>
  Meina Li <meili@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Michał Smyk <fedora@smyk.it>
  Milo Casagrande <milo@milo.name>
  Moshe Levi <moshele@nvidia.com>
  Muha Aliss <muhaaliss@gmail.com>
  Nathan <nathan95@live.it>
  Neal Gompa <ngompa13@gmail.com>
  Nick Chevsky <nchevsky@gmail.com>
  Nick Shyrokovskiy <nshyrokovskiy@gmail.com>
  Nickys Music Group <nickys.music.group@gmail.com>
  Nico Pache <npache@redhat.com>
  Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
  Olaf Hering <olaf@aepfle.de>
  Olesya Gerasimenko <gammaray@basealt.ru>
  Orion Poplawski <orion@nwra.com>
  Pany <geekpany@gmail.com>
  Patrick Magauran <patmagauran.j@gmail.com>
  Paulo de Rezende Pinatti <ppinatti@linux.ibm.com>
  Pavel Hrdina <phrdina@redhat.com>
  Peng Liang <liangpeng10@huawei.com>
  Peter Krempa <pkrempa@redhat.com>
  Pino Toscano <ptoscano@redhat.com>
  Pino Toscano <toscano.pino@tiscali.it>
  Piotr Drąg <piotrdrag@gmail.com>
  Prathamesh Chavan <pc44800@gmail.com>
  Praveen K Paladugu <prapal@linux.microsoft.com>
  Richard W.M. Jones <rjones@redhat.com>
  Ricky Tigg <ricky.tigg@gmail.com>
  Robin Lee <cheeselee@fedoraproject.org>
  Roman Bogorodskiy <bogorodskiy@gmail.com>
  Roman Bolshakov <r.bolshakov@yadro.com>
  Ryan Gahagan <rgahagan@cs.utexas.edu>
  Ryan Schmidt <git@ryandesign.com>
  Sam Hartman <hartmans@debian.org>
  Scott Shambarger <scott-libvirt@shambarger.net>
  Sebastian Mitterle <smitterl@redhat.com>
  SeongHyun Jo <caelus9536@gmail.com>
  Shalini Chellathurai Saroja <shalini@linux.ibm.com>
  Shaojun Yang <yangshaojun@phytium.com.cn>
  Shi Lei <shi_lei@massclouds.com>
  simmon <simmon@nplob.com>
  Simon Chopin <chopin.simon@gmail.com>
  Simon Gaiser <simon@invisiblethingslab.com>
  Simon Rowe <simon.rowe@nutanix.com>
  Stefan Bader <stefan.bader@canonical.com>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Berger <stefanb@linux.vnet.ibm.com>
  Stefan Hajnoczi <stefanha@gmail.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Szymon Scholz <szymonscholz@gmail.com>
  Thomas Huth <thuth@redhat.com>
  Tim Wiederhake <twiederh@redhat.com>
  Tomáš Golembiovský <tgolembi@redhat.com>
  Tomáš Janoušek <tomi@nomi.cz>
  Tuguoyi <tu.guoyi@h3c.com>
  Victor Toso <victortoso@redhat.com>
  Ville Skyttä <ville.skytta@iki.fi>
  Vinayak Kale <vkale@nvidia.com>
  Wang Xin <wangxinxin.wang@huawei.com>
  WangJian <wangjian161@huawei.com>
  Weblate <noreply@weblate.org>
  Wei Liu <liuwe@microsoft.com>
  Wei Liu <wei.liu@kernel.org>
  Wei-Chen Chen <weicche@microsoft.com>
  William Douglas <william.douglas@intel.com>
  Yalei Li <274268859@qq.com>
  Yalei Li <liyl43@chinatelecom.cn>
  Yang Fei <yangfei85@huawei.com>
  Yang Hang <yanghang44@huawei.com>
  Yanqiu Zhang <yanqzhan@redhat.com>
  Yaroslav Kargin <ykargin@virtuozzo.com>
  Yi Li <yili@winhong.com>
  Yi Wang <wang.yi59@zte.com.cn>
  Yuri Chornoivan <yurchor@ukr.net>
  Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
  zhangjl02 <zhangjl02@inspur.com>
  Zheng Chuan <zhengchuan@huawei.com>
  zhenwei pi <pizhenwei@bytedance.com>
  Zhenyu Ye <yezhenyu2@huawei.com>
  Zhenyu Zheng <zheng.zhenyu@outlook.com>
  Zhenzhong Duan <zhenzhong.duan@intel.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          fail    
 build-arm64-libvirt                                          fail    
 build-armhf-libvirt                                          fail    
 build-i386-libvirt                                           fail    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           blocked 
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-libvirt-xsm                                 blocked 
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-libvirt                                     blocked 
 test-arm64-arm64-libvirt                                     blocked 
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-libvirt-pair                                blocked 
 test-amd64-i386-libvirt-pair                                 blocked 
 test-arm64-arm64-libvirt-qcow2                               blocked 
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-libvirt-vhd                                 blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 79619 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Oct 16 09:51:34 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 16 Oct 2021 09:51:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.211290.368498 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbgLX-0000Uw-PI; Sat, 16 Oct 2021 09:51:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 211290.368498; Sat, 16 Oct 2021 09:51:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbgLX-0000Up-LN; Sat, 16 Oct 2021 09:51:19 +0000
Received: by outflank-mailman (input) for mailman id 211290;
 Sat, 16 Oct 2021 09:51:17 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mbgLV-0000Ue-RZ; Sat, 16 Oct 2021 09:51:17 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mbgLV-0004mQ-FT; Sat, 16 Oct 2021 09:51:17 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mbgLV-0003QZ-1U; Sat, 16 Oct 2021 09:51:17 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mbgLV-0007uU-0z; Sat, 16 Oct 2021 09:51:17 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=fg6dEBcngAVXbobjB+N2y1dFFkHDBOJdr/6M5gmc0l8=; b=qh3k+bQjLonzJNlh2/c2YbQWt5
	c0uYk6jUJ54PBDtXqBcR/6Wvqms9QDE8OcqTk4vfBgTiOesiBK3GX17iXN0unZjYZ8aFyLwNRiqRd
	cj3EKjb9hcFyDmfvFf6sQ/GfU2+zCITTtcWyaOKrEA6Saqs7aPgf72/An7VO1lvx4gzQ=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165529-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 165529: tolerable FAIL - PUSHED
X-Osstest-Failures:
    qemu-mainline:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:allowable
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=82d88f834c8f7d33ad9529fca80924bc496fcb70
X-Osstest-Versions-That:
    qemuu=4d1a525dfafe995a98bb486e702da09e31b68b9c
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 16 Oct 2021 09:51:17 +0000

flight 165529 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165529/

Failures :-/ but no regressions.

Regressions which are regarded as allowable (not blocking):
 test-amd64-amd64-xl-rtds     20 guest-localmigrate/x10   fail REGR. vs. 165514

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165514
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165514
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 165514
 test-armhf-armhf-xl-rtds     18 guest-start/debian.repeat    fail  like 165514
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 165514
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 165514
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 165514
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 165514
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165514
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 qemuu                82d88f834c8f7d33ad9529fca80924bc496fcb70
baseline version:
 qemuu                4d1a525dfafe995a98bb486e702da09e31b68b9c

Last test of basis   165514  2021-10-14 20:38:00 Z    1 days
Testing same since   165529  2021-10-15 19:39:30 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Cornelia Huck <cohuck@redhat.com>
  David Gibson <david@gibson.dropbear.id.au>
  Eric Farman <farman@linux.ibm.com>
  Greg Kurz <groug@kaod.org>
  Halil Pasic <pasic@linux.ibm.com>
  Marc Hartmayer <mhartmay@linux.ibm.com>
  Matthew Rosato <mjrosato@linux.ibm.com>
  Richard Henderson <richard.henderson@linaro.org>
  Thomas Huth <thuth@redhat.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     fail    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/qemu-xen.git
   4d1a525dfa..82d88f834c  82d88f834c8f7d33ad9529fca80924bc496fcb70 -> upstream-tested


From xen-devel-bounces@lists.xenproject.org Sat Oct 16 10:29:10 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 16 Oct 2021 10:29:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.211301.368512 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbgw2-0003uY-Tv; Sat, 16 Oct 2021 10:29:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 211301.368512; Sat, 16 Oct 2021 10:29:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbgw2-0003uR-Qi; Sat, 16 Oct 2021 10:29:02 +0000
Received: by outflank-mailman (input) for mailman id 211301;
 Sat, 16 Oct 2021 10:29:02 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=UqKg=PE=citrix.com=roger.pau@srs-us1.protection.inumbo.net>)
 id 1mbgw1-0003uL-RT
 for xen-devel@lists.xenproject.org; Sat, 16 Oct 2021 10:29:02 +0000
Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id dfde1ad6-2e6b-11ec-8283-12813bfff9fa;
 Sat, 16 Oct 2021 10:29:00 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: dfde1ad6-2e6b-11ec-8283-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1634380140;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=fpe4aNTRTnT6DLHDykLk8hQaQ+coKxhrPSvOpE4LRAk=;
  b=YDaBGae3fSnCbKwc5r3FgJxciBBbun7/B1EzkQWKmWbGbCAGANqCjNkh
   cLSedFKWOejtq88TQQWoCEqdprvCa6o9O1GWJYbqHpq38fpui+aI+Lu6H
   pj++kFMcrRFXShMe1JkM4zozSZU/KfUrF8ICen9dQnZPm2rxB+gvBq0L6
   s=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: J1kIkuNJsRnnUny4HsVWM82M78HiHz2UygNudRPBFU6qz44t9mv+Uk7uSVLT7kJBZr15huERjE
 u/BLiKyAJGlLL5Z5yGRAZGWN3s44NE6o54TFhhjGdcR+xVI3z0WTIptfHStxZQkI6KDzSc9eVi
 387OvdkZLamlhSTyhpaByDI9BcT0bt1i4IxJdKCFsi0aG6NTgixiA2BBCwkUhf0DYLMdXQXq6h
 mXlvtDsCruGX/yfEC9hpccY9xEl0gkd2RzzQORSy4+srBUpqncEQzz9tpczH7ro3zNDRqd9u1Z
 3/nZDnQrXseyD747y8DkTEOw
X-SBRS: 5.1
X-MesageID: 55377331
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:fMEjkK8b8KFaTAy6ViMoDrUD93iTJUtcMsCJ2f8bNWPcYEJGY0x3y
 2dLDzuAPfrcZTPweYp2a42y805TsJHVzdcxHQs//ik8E34SpcT7XtnIdU2Y0wF+jyHgoOCLy
 +1EN7Es+ehtFie0Si9AttENlFEkvU2ybuOU5NXsZ2YhGGeIdA970Ug6wrZg3NYy6TSEK1jlV
 e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH
 I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPhs0
 PlptrLgeD4DO/adgNgYehJoFgxxaPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us
 6ZCcXZUM07F17neLLGTE4GAguw5K8bmJsUHs2xIxjDFF/c2B5vERs0m4PcFgWxv2ZsVRJ4yY
 eIycyhxNxj4ZyRfP0olGrA5tr/4v0jwJmgwRFW9+vNsvjm7IBZK+IbqNN3Za9mbX/J/l0yTp
 n/F12nhCxRcP9uaoRK/+3Kxgqn0nCX0WKobDrj+/flv6HWRzGEODBwdVXOgvOK0zEW5Xrp3M
 0UJ/gI+oK5081akJvHiWzWorXjCuQQTM/JSDuk75Qel2qfSpQGDCQAsVSVdYdYrsMs3Qz0C1
 VKTmd7tQzt1v9W9Y3+H6q2dqz/0HCEPNHIDfgcNVw5D6N7myKkykRDnXttlCLSyjND+BXf32
 T/ihDgzgfAfgNAG042//EvbmHS8q57RVAk36w7LGGW/4WtEiJWNPtLyrwKBtLAZcdjfHgLpU
 GU4d9a28fgiKZKjxB20auBWTamV4t+OADjxjgs6d3U+zAiF93mmdIFWxThxIkZ1L8oJEQPUj
 F/vVRB5v8ALYiP7BUNjS8foUZ5ylPm/fTjwfqmMNoImX3RnSOOQEMiCj2ar1GfxjFNkr6g7P
 ZqKGSpHJSdHUfo5pNZaquF07FPK+szc7T+MLXwY507+uVZ7WJJzYe1UWLdpRrthhJ5oWC2Pr
 75i2zKikn2zqtHWbCjN6pI0JlsXN3U9Dp2eg5UJLbLYeFE6QDtxU6W5LVYdl2pNxfU9egDgp
 SnVZ6Ol4ACn2S2vxfuiOxiPl48Drb4g9ClmbETAzH6j2mQ5YJbH0UvsX8BfQFXTz8Q6laQcZ
 6BcI62oW60TIhyaq2V1RcSs9+RKKUX07T9iygL4OVDTibY7HFeXkjIlFyOynBQz4t2f65Vh+
 uP6ilKKKXfBLiw7ZPvrhDuU5wrZlVAWmf5oXluOJd9WeU7295NtJTC3hfgyS/zg4z2artdD/
 wrJUxoeu8fXpIo5rIvAiaye9t/7GOpiBEtKWWLc6O/uZyXd+2Oix65GUfqJIm+BBD+lpv36a
 LUH1ez4Pd0GgE1O79h2HYF0wP9s/NDovbJbkFhpRS2Zc1SxB7p8CXCaxs0T5LZVz7pUtFLuC
 EKC89VXI5uTP8bhHAJDLQYpdL3bh/oVhiPT/bI+J0CjvH17+7+OUENzORiQiXMCcOspYd19m
 ep44ZwY8Q2yjBYuI+2qtCEM+jTeNGEEXoUmqooeXN3hhD00xwwQepfbECL3vs2CMo0eLkkwL
 zaIr6PenLAAlFHaen8+GHWRj+pQgZMC5EJDwFMYfgnbn9PEgrk83QFL8CRxRQNQl00V3+V2M
 2ltFkt0OaTRoGs42JkdBzihS1NbGRmU2k3t0F9YxmTWQn6hWnHJMGBga/2G+1oU8j4EczVWl
 F1CJL0Jjdo+kBnN4xYP
IronPort-HdrOrdr: A9a23:QHUb2KjtwtIpvKH2sgDTfQjcg3BQX0d13DAbv31ZSRFFG/FwyP
 rBoB1L73DJYWgqNE3I+erhBEGBKUmsk6KdxbNhQItKPTOWwldASbsC0WKM+UyEJ8STzJ846U
 4kSdkDNDSSNykKsS+Z2njBLz9I+rDum8rE9ISurQYccegpUdAa0+4QMHfkLqQcfng+OXNWLu
 v62iIRzADQBkj/I/7LS0UtbqzmnZnmhZjmaRkJC1oO7xSPtyqh7PrfHwKD1hkTfjtTyfN6mF
 K13DDR1+GGibWW2xXc32jc49B/n8bg8MJKAIiphtIOIjvhpw60bMBKWqGEvhoyvOazgWxa3O
 XkklMFBYBe+nnRdma6rV/E3BTh6i8n7zvYxVqRkRLY0ITEbQN/L/AEqZNScxPf5UZllsp7yr
 h302WQsIcSJQ/cnQzmjuK4Fy1Cpw6Rmz4PgOQTh3tQXc81c7lKt7ES+0tTDdMpAD/60oY6C+
 NjZfuspcq+SWnqLUwxg1MfheBFBh8Ib1O7qwk5y4KoOgFt7TNEJxBy/r1Zop8CnKhNAqWsqd
 60dJiBOdl1P7srhJlGdZU8qP2MexrwqCL3QRGvyGvcZdQ60lL22tXKCeYOlauXkKJh9upEpH
 2GaiIAiVIP
X-IronPort-AV: E=Sophos;i="5.85,378,1624334400"; 
   d="scan'208";a="55377331"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=KUwNBL3JyckKk3quoDmvVM3Vw8aHXWONytzuJEBRDTFGjkEFz2mE3NUgGJ3yB97y6fHla40uE2lE/Bw6IqET4SUyF+fnS32lHKUyANeV9Pbg+BicZcT/D9e3hsO2y+LRsmOv+HUM0XGA8zlSRoTGOnRbP1MI9Rzn2mvMhmRjaq16Kw6esQINNGdPALjPq1Ri6/MZwW6sGJmBEDi3tukk3ueLWhmhDdNVJRbm22Nk5lgLHANg5v8zxgThf8rRXewZF0Dm9MP0rplNc/zisaPz4u2SUOjEs0w6vUBVA1xyg7UZKOuRdNDDWPatVMZ7r+xpSmj2FjETl6WR0YmUF4ZXjA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Dcrc6y8tGnkbkpUojhCEgZSqBl91j1MTHBx0ByDrd4g=;
 b=XYh1MrWdtCqR8HTJKdFXt1z1zrmc89DZ2pIdUX/0lXiKEXQ8Q5NJ9yith312XmOxHYi0Zrypk7KQcfhxN57eQYJtTdYOoI9MDMlly5RqffTmjHCarGEmtb7Qv9tnB+QDhGzT+GhLuDpKYhdjIPeCAfBXyM2vflht3EW5M+MJ0mZkM6VM9oqZ91Q7/XqxHX/8XzC4wv25m0cnYO1FwTGq2x6HPGZ4qFSz8SYXN0uUMrGFyTT23E9Ya0L75S2nBuDDoni5TRL2rzVN1eTPMeRRT5gLZpEgQkYUUq+e1N79i/Vato3RSNj9KneObbRkSRjlOesrTkPzHoiPkuwavatrBw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Dcrc6y8tGnkbkpUojhCEgZSqBl91j1MTHBx0ByDrd4g=;
 b=a25LXpzHUco9oLXzFKjTOcPq5q6EC2mCWgodqX/rQ+x03mNjTBj2gNx0ztWz5vP5GOS7FLWYinbxY3toUr15WoZfwC5t4yLvKqs5UUR7ih6blsjyLIfujf+aU0igmL/mSYy1H8EcD6LCBzu03E7vgfT1poXKhn5FudW5E+RZNdA=
Date: Sat, 16 Oct 2021 12:28:19 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Stefano Stabellini <sstabellini@kernel.org>
CC: Julien Grall <julien@xen.org>, Bertrand Marquis
	<Bertrand.Marquis@arm.com>, Xen-devel <xen-devel@lists.xenproject.org>,
	"iwj@xenproject.org" <iwj@xenproject.org>, Rahul Singh <Rahul.Singh@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, Andrew Cooper
	<andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>, "Jan
 Beulich" <jbeulich@suse.com>, Wei Liu <wl@xen.org>, Paul Durrant
	<paul@xen.org>
Subject: Re: [PATCH v8 2/5] xen/arm: Enable the existing x86 virtual PCI
 support for ARM
Message-ID: <YWqpQyKvNzE8GYda@MacBook-Air-de-Roger.local>
References: <cover.1634315461.git.bertrand.marquis@arm.com>
 <e2b10f56043155e4bb8eae824723045ccc042f8e.1634315461.git.bertrand.marquis@arm.com>
 <cef8d2a6-91c1-2d4d-2078-98d0a92b067a@xen.org>
 <F447A1D8-A023-4127-AAC0-7511868DE9C4@arm.com>
 <a45077dc-e144-4427-9ae2-5815045ecaec@xen.org>
 <alpine.DEB.2.21.2110151235100.31303@sstabellini-ThinkPad-T480s>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <alpine.DEB.2.21.2110151235100.31303@sstabellini-ThinkPad-T480s>
X-ClientProxiedBy: LO4P123CA0234.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:1a6::23) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 20749868-7408-4067-6eaa-08d9908faf15
X-MS-TrafficTypeDiagnostic: DM4PR03MB5966:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <DM4PR03MB59663DFA041BF1D328B284728FBA9@DM4PR03MB5966.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: bwUud9v0naAnUZvMx1vk5uGrSMG5zaryU6Gi2qdktChIth2YD18hF1J/TnDVwtnPNg6f4+4cH+ngiZDpch1yXzxWYKJ1pEoDZbzyP6eLgAIqRKdPWn7/l4N7i7dlacQBBz/ovAG8nkKhKF6XQWAod+e5Z6zOzPNJ0N3vxCts9MShniOos5uNuAeqxL/oiN9+Ut0sUGxR5tRcthJPYyAEVoP+EZKMeSPsjPsBs27T/JyKz0JFxY4g3oFCSEJ+49zsomPFGk8fMD2d3MC95FGE8KBnfGTvOf8YJ3sAn6sV1vHJ0nyhtuhBO9o9bR+PEek5Xhy/o88JKvHTa9RbWIE1KCSYmijuzGDRd+GBjp4RNkkQnTsDVzqhi38Ly0PgV/B0KkL/Uc/jZmrz7/VNSqZxXi3Hycn1PNWjYoChBTqbFQY7Z2F63s4EmjCJ4UdWnipFYaRnrAxbzW6FYRwaXDI71YAxE+77oWf34BwV4cwIQghlebffFOLL5hjCD9dUAGJkyd9WFL7FIfSzUFyKWVC+Z5gxBdSqN7SmA24uof/R2DZ+V76dfyhaXbmtU3KIMMOBbXyJgdcHJq+F7e6pyz/C8K7/awmDRCwmIoi5k1YCst2J30td1vv4CrAiLQ02i9VLwABeI7Wax9oP96mHpfC2Ng==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(5660300002)(66946007)(38100700002)(8936002)(66476007)(186003)(7416002)(85182001)(53546011)(26005)(66556008)(316002)(83380400001)(8676002)(82960400001)(6666004)(54906003)(6486002)(956004)(6916009)(4326008)(6496006)(2906002)(86362001)(508600001)(9686003);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eWl2NHZNSGE3WWxKUFlEQXhRUGFpbWpOQkpQeW94YnlsYURhdTJoWDhDY3RM?=
 =?utf-8?B?MlAvOWJTdWpGY1gxaS9PQmY3N2QzT2xSdm1udDN1MVNBUkZQZkg2dHBjZFo2?=
 =?utf-8?B?WXJ5SElpemdYVFhFOVZrQUZmU0wrakNzdVdLWVRRN3BRaGZqdVYycUZra2d6?=
 =?utf-8?B?a2xFcnVFaXphRDBXV2hqY0kyWDZLcGZwb2pzSlpGcTJCcDZMdkdDd1hXY3RU?=
 =?utf-8?B?ZzdEamdndHNFNWhEZ0FuZXN0RjRiQ3JIOWJoOWRNaEpubU9PVzdIWjhqa0JX?=
 =?utf-8?B?K3VOOThlYWNYamc3Q3NuQldBNGtscW51K1ZTSmdNc3JUV1M2UmJILzVGNHlw?=
 =?utf-8?B?V0x2MnhqczdkSWJIMTdJOXdDLzZnZmRQaEYzbUVrQjdRcllzL21tZ3NOSWI1?=
 =?utf-8?B?aHJ6ZlB0M21ySjlweVhIaXFFRVY3RnNrbEgzMlI1eVRITkRKOHdWUHlyQ0gx?=
 =?utf-8?B?d1cxV2JQb1VQSTZWK3JhbGlmdVh1NjYxSm54S2J0dkI3Wm1nbnFBYThwSk9r?=
 =?utf-8?B?cWpUMHowckRiYjdYVDFETXI2NlBKYWQwOW4xQTExWWMxaE5oejdjayt0eWh3?=
 =?utf-8?B?WU1YQWJzZjI1a0pEVFVXa2xydElFSzcxM1VDQ3duZHdMeUFGVEZUenJsWEVF?=
 =?utf-8?B?VjBNOFpGZ1dBRytab1M3a2p6N1NJMWw2eDJWWEg4ZDJsbVVMcHE3eVNDOEtL?=
 =?utf-8?B?aWZETGJENC9OU1NqT3VNV01hNmJ2NldhZ1ZoeEhqemhkeElUMmpZNEJzVmtN?=
 =?utf-8?B?WHlXTUtCN2wxSytDSHVFTWlXUTF0bFdyNUc0ZGNaV0xEdTBJaFVaWnZpcDUr?=
 =?utf-8?B?NEp2bm1KRWx6Z0tQUnlPSkJjYnNVRVNNZ2NaRmJTUTNqRFcxKzJ5SUJIVjFN?=
 =?utf-8?B?eXk0WTIzOEx6TnBDZXF4Z2xocDhzMloyaXlXc096WWxvakFFSzdIY3ZJVjZU?=
 =?utf-8?B?ZXZMOUVSbGhreVRLeTExSUFEcDdzZmVsRmgxWm40VnJZdzJZM0syNGk2dmlN?=
 =?utf-8?B?NDJrODk2OEpsWUFJNEYxYWhZOTA1elc2dVpCM1FGWjd2QzhzcXdpM1lXdGhT?=
 =?utf-8?B?anVsOTNGTCtTWTF5RXZtUkZsdmRTbmxhb0NicnJrQlRaalQvVkY1azVRbDQy?=
 =?utf-8?B?Y0dBZXRlZXFkakNqSnJkdHVsdlliWG4reVhVK3FpbkpyNHVVTU9nd1JmZmZn?=
 =?utf-8?B?TzhrL1IzOHRmKzZaZnUrVVpNLzZMWFVuNVJITzBTRnlhdm5tVVhJSjFkWklx?=
 =?utf-8?B?emcwSEUvM3pVRE5GT25HSlB0bVp5cjdkTldpVU9PQ1NFSVI2MUJVRGh0b3pL?=
 =?utf-8?B?M0hYS0hIQzRmb202MFYvbXZIR2gza1RSYXhsVU10bGFCT0tnTnFmM1Rvb1ZN?=
 =?utf-8?B?Vnl6Y25ZUmhXSG0vOEFIVnhTcG1CdDRmZUcxQTZ1c2VJOFpITU5NeHRuQUhU?=
 =?utf-8?B?ZFUvWXFRUDlzMmxLRmd2RWJGMmsxa1l3a2JJcktXc3BKZWZiTytMNHJzYml4?=
 =?utf-8?B?Yy94Vjc2azJLTi94SHovVHQ3ZWJZem9ibzVPV2VJSDZGQjBZUGZGd0JXQmFR?=
 =?utf-8?B?a1BKUnlVZDJsRzNUNGk3Ri9OaVFVK2tPelRtLy9ZOHdMY0FVdFdXY3VLeXFu?=
 =?utf-8?B?akRpdjBDQ0hjQlVzSUVDMk1NYUplMnBQaUxVelhDYXQ5NUF4SnNha3N6VVdu?=
 =?utf-8?B?RXUwMUJ4SVpOUWwreEtCenR1eUFpT2MvcGpRRnhPNUtGUDlrdlRPelJBVlVF?=
 =?utf-8?Q?1V0XxwPGzdr6DzdTlpnliv6w3UCV9BmorzoUddW?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 20749868-7408-4067-6eaa-08d9908faf15
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Oct 2021 10:28:24.4962
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: J+bNRzsidxF6CFaRYnpN+sEOUyk3un3T3DJB3MCLU+PgQboYeXQNc1U0etpRcGPYU8wPc+3qUv8/VXDm3L/yuQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR03MB5966
X-OriginatorOrg: citrix.com

On Fri, Oct 15, 2021 at 12:47:17PM -0700, Stefano Stabellini wrote:
> On Fri, 15 Oct 2021, Julien Grall wrote:
> > On 15/10/2021 18:33, Bertrand Marquis wrote:
> > > > On 15 Oct 2021, at 18:25, Julien Grall <julien@xen.org> wrote:
> > > > 
> > > > Hi Bertrand,
> > > > 
> > > > On 15/10/2021 17:51, Bertrand Marquis wrote:
> > > > > diff --git a/xen/drivers/passthrough/pci.c
> > > > > b/xen/drivers/passthrough/pci.c
> > > > > index 3aa8c3175f..35e0190796 100644
> > > > > --- a/xen/drivers/passthrough/pci.c
> > > > > +++ b/xen/drivers/passthrough/pci.c
> > > > > @@ -756,6 +756,19 @@ int pci_add_device(u16 seg, u8 bus, u8 devfn,
> > > > >       if ( !pdev->domain )
> > > > >       {
> > > > >           pdev->domain = hardware_domain;
> > > > > +#ifdef CONFIG_ARM
> > > > > +        /*
> > > > > +         * On ARM PCI devices discovery will be done by Dom0. Add vpci
> > > > > handler
> > > > > +         * when Dom0 inform XEN to add the PCI devices in XEN.
> > > > > +         */
> > > > > +        ret = vpci_add_handlers(pdev);
> > > > 
> > > > I don't seem to find the code to remove __init_hwdom in this series. Are
> > > > you intending to fix it separately?
> > > 
> > > Yes I think it is better to fix that in a new patch as it will require some
> > > discussion as it will impact the x86 code if I just remove the flag now.
> > For the future patch series, may I ask to keep track of outstanding issues in
> > the commit message (if you don't plan to address them before commiting) or
> > after --- (if they are meant to be addressed before commiting)?
> > 
> > In this case, the impact on Arm is this would result to an hypervisor crash if
> > called. If we drop __init_hwdom, the impact on x86 is Xen text will slightly
> > be bigger after the boot time.
> > 
> > AFAICT, the code is not reachable on Arm (?). Therefore, one could argue we
> > this can wait after the week-end as this is a latent bug. Yet, I am not really
> > comfortable to see knowningly buggy code merged.
> > 
> > Stefano, would you be willing to remove __init_hwdom while committing it? If
> > not, can you update the commit message and mention this patch doesn't work as
> > intended?
> 
> I prefer not to do a change like this on commit as it affects x86.
> 
> I added a note in the commit message about it. I also added Roger's ack
> that was given to the previous version. FYI this is the only outstanding
> TODO as far as I am aware (there are other pending patch series of
> course).
> 
> After reviewing the whole series again, checking it against all the
> reviewers comments, and making it go through gitlab-ci, I committed the
> series.

Hello,

Maybe I'm being pedantic, or there was some communication outside the
mailing list, but I think strictly speaking you are missing an Ack
from either Jan or Paul for the xen/drivers/passthrough/pci.c change.

IMHO seeing how that chunk moved from 3 different places in just one
afternoon also doesn't give me a lot of confidence. It's Arm only code
at the end, so it's not going to effect the existing x86 support and
I'm not specially worried, but I would like to avoid having to move it
again.

Regards, Roger.


From xen-devel-bounces@lists.xenproject.org Sat Oct 16 15:21:34 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 16 Oct 2021 15:21:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.211314.368522 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mblUw-0004dF-AH; Sat, 16 Oct 2021 15:21:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 211314.368522; Sat, 16 Oct 2021 15:21:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mblUw-0004d8-7L; Sat, 16 Oct 2021 15:21:22 +0000
Received: by outflank-mailman (input) for mailman id 211314;
 Sat, 16 Oct 2021 15:21:20 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mblUu-0004cy-5P; Sat, 16 Oct 2021 15:21:20 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mblUt-0001kQ-Ts; Sat, 16 Oct 2021 15:21:19 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mblUt-0002sr-FO; Sat, 16 Oct 2021 15:21:19 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mblUt-0006Pu-Er; Sat, 16 Oct 2021 15:21:19 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=ElIqguY/fQN54imoOpTb/WRuWFeXER295iL1sCDHUK8=; b=DCgtfGIwUOFzMFHkhfjKXQIpFK
	zjObbq6blxDG4PTJ8Nc1J1xS4Fq2k1ETClvCp6LhYV1NYv7dG9TkG0C04l3U1FoppBmPWbrYdgZWE
	9wotQ7kLruG4/h9n+wp5YBqT+yFmDa1KzeMs7F8j4Ci0PeSKWEb2GJyt6EGN+Gh7SXS4=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165534-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 165534: regressions - FAIL
X-Osstest-Failures:
    xen-unstable:test-amd64-amd64-examine:memdisk-try-append:fail:regression
    xen-unstable:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=52d0847d7c6972baa74156f14ee8544f5aba1d2d
X-Osstest-Versions-That:
    xen=b75838ad6c4f42c93efee83fc2508c78641e1b57
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 16 Oct 2021 15:21:19 +0000

flight 165534 xen-unstable real [real]
flight 165537 xen-unstable real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/165534/
http://logs.test-lab.xenproject.org/osstest/logs/165537/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-amd64-amd64-examine      4 memdisk-try-append       fail REGR. vs. 165524

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-rtds     20 guest-localmigrate/x10       fail  like 165524
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 165524
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 165524
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165524
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165524
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 165524
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail like 165524
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 165524
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 165524
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 165524
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 165524
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 165524
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165524
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 165524
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  52d0847d7c6972baa74156f14ee8544f5aba1d2d
baseline version:
 xen                  b75838ad6c4f42c93efee83fc2508c78641e1b57

Last test of basis   165524  2021-10-15 11:27:26 Z    1 days
Testing same since   165534  2021-10-16 05:27:33 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Bertrand Marquis <bertrand.marquis@arm.com>
  Ian Jackson <iwj@xenproject.org>
  Jan Beulich <jbeulich@suse.com>
  Juergen Gross <jgross@suse.com>
  Michal Orzel <michal.orzel@arm.com>
  Rahul Singh <rahul.singh@arm.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Stefano Stabellini <stefano.stabellini@xilinx.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 fail    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     fail    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 313 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Oct 16 18:09:29 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 16 Oct 2021 18:09:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.211346.368606 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbo7T-0002r0-2u; Sat, 16 Oct 2021 18:09:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 211346.368606; Sat, 16 Oct 2021 18:09:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbo7S-0002qt-Vq; Sat, 16 Oct 2021 18:09:18 +0000
Received: by outflank-mailman (input) for mailman id 211346;
 Sat, 16 Oct 2021 18:09:18 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=k6GW=PE=oracle.com=boris.ostrovsky@srs-us1.protection.inumbo.net>)
 id 1mbo7S-0002qn-DB
 for xen-devel@lists.xenproject.org; Sat, 16 Oct 2021 18:09:18 +0000
Received: from mx0b-00069f02.pphosted.com (unknown [205.220.177.32])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 2ced89f2-2eac-11ec-8295-12813bfff9fa;
 Sat, 16 Oct 2021 18:09:16 +0000 (UTC)
Received: from pps.filterd (m0246630.ppops.net [127.0.0.1])
 by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 19GGlpSu013536; 
 Sat, 16 Oct 2021 18:09:05 GMT
Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79])
 by mx0b-00069f02.pphosted.com with ESMTP id 3bqqj5s4qp-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Sat, 16 Oct 2021 18:09:05 +0000
Received: from pps.filterd (userp3020.oracle.com [127.0.0.1])
 by userp3020.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 19GI5OnT168058;
 Sat, 16 Oct 2021 18:09:04 GMT
Received: from nam12-dm6-obe.outbound.protection.outlook.com
 (mail-dm6nam12lp2170.outbound.protection.outlook.com [104.47.59.170])
 by userp3020.oracle.com with ESMTP id 3bqp2k3112-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Sat, 16 Oct 2021 18:09:04 +0000
Received: from BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10)
 by MN2PR10MB4029.namprd10.prod.outlook.com (2603:10b6:208:186::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16; Sat, 16 Oct
 2021 18:09:02 +0000
Received: from BLAPR10MB5009.namprd10.prod.outlook.com
 ([fe80::3c49:46aa:83e1:a329]) by BLAPR10MB5009.namprd10.prod.outlook.com
 ([fe80::3c49:46aa:83e1:a329%5]) with mapi id 15.20.4608.018; Sat, 16 Oct 2021
 18:09:02 +0000
Received: from [10.74.110.15] (138.3.200.15) by
 SJ0PR03CA0190.namprd03.prod.outlook.com (2603:10b6:a03:2ef::15) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15 via Frontend
 Transport; Sat, 16 Oct 2021 18:08:59 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2ced89f2-2eac-11ec-8295-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date :
 subject : to : cc : references : from : in-reply-to : content-type :
 content-transfer-encoding : mime-version; s=corp-2021-07-09;
 bh=aOlWC3Cw595G8TJ54yVSc2BzRIgENLvlwz77HvIGxqo=;
 b=SdsclP8oeCRw0ilqjOtBi1u8hYTlmjovk2K8rWDQa3gHJX/LseJf/m3KXNLxlvQakJUk
 4R9z6jDJVjrnp/dQChT5qzTlPke6NIjwhoY1LaLlG91+e/LmGrE2I/QVyQ1tEqqPvAfG
 JTLKn4CcFMPNVuuK+8/Fa3UAbI4r9/+btdqUuyjKPQSDbh4Qwm1z8SSdhzvg4PXNMirt
 tdvOft2wapmHiYjikWu2Jow2Sso3e4X+n675SfJTGQcAiwL9DIU7wWT2SfhbC3qyqaW3
 KYFCXoNIPP5pZ/lbWGxDWIUGukG6lh9VtmMkQ5peoJEs2nia0usl/pZdFTEN2VHa27Zx WQ== 
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Wa9G4ZY4VdEs1AyOc9SLUzoQrB0ZniP03YKB6pGkgSpD/yQC9YU3R1QdlMWt2qe4FCQNGsfWa7tBmevfT6YZseEjbBTyPSJ30yobReM+WzxqxspOVWIH4C4e3W0hug9Dl2fKLozDX1l8pteR6cA07XhYFhintoHbqfRO+942OYemlqT3Mq1GJSVb1w+MNl/vUEUMlNCYThriafmKV9dm+KBOY4CUoxWymRG9hPlYDO9dKnkgLPzKSD+E6xoAmR2p1QzE3wayFW615I+uG+6IkpwlRncyK3apitGl/Vk/CJSOIpS/MsaI9uoV8+ypiTwb0dQvv2Jyzjb5h8LAtW8Saw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=aOlWC3Cw595G8TJ54yVSc2BzRIgENLvlwz77HvIGxqo=;
 b=Oku/rzWnHAwxVc9kqfFxYwy53k92yeeB2PaEjIGSlEHt9agUS3uv8fRygkpXtuBgzr5ISRHIWjtMASk+sTn4nhl1RgpWPSgeJbkUqqCuK39vyFoLTONNAgWcXgbyXmiUEXntkg94Gva7TisPNrVxKSl6E/Rzrd/ukHCWpn21WTumzOOVfCxu2j8ZyANewTd5ABHmLjrSJrup+hW8pFNztTyq7DXLqi1741cvqJ1ZjKmoGzC+4PpsZHgWqmtAOgcnFlbzaMgBl7nnYKvcyXDilEnJbq/1AM35aRiPpfZIaEsBKwyAEpX/+LUs+0PzW4OB/TEiDJiGZ2fv4SXve7eTDw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com;
 dkim=pass header.d=oracle.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=aOlWC3Cw595G8TJ54yVSc2BzRIgENLvlwz77HvIGxqo=;
 b=Bb16enKOYBfpieuRixqNPuiMbMjKHWjYcS1RIXS/6oaQpi04EDhGRfzCwGv8NgyPa3X0I7tCITVhkc9RNZ0yxcxamQhaJ1iYXJ04B0ImEgukI3OrJnikBiS2S0/okny8nCWMoYpSeE9b3E2ALH+RI2pui4uZ6thEjtt7XSZwL+4=
Authentication-Results: gmail.com; dkim=none (message not signed)
 header.d=none;gmail.com; dmarc=none action=none header.from=oracle.com;
Message-ID: <b8793bbb-a148-6b31-0c92-a0d71e50380d@oracle.com>
Date: Sat, 16 Oct 2021 14:08:55 -0400
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.2.0
Subject: Re: [PATCH V3 04/49] x86/xen: Add
 xenpv_restore_regs_and_return_to_usermode()
Content-Language: en-US
To: Lai Jiangshan <jiangshanlai@gmail.com>, linux-kernel@vger.kernel.org
Cc: x86@kernel.org, Lai Jiangshan <laijs@linux.alibaba.com>,
        Jan Beulich <jbeulich@suse.com>, Thomas Gleixner <tglx@linutronix.de>,
        Juergen Gross <jgross@suse.com>, Peter Anvin <hpa@zytor.com>,
        xen-devel@lists.xenproject.org, Andy Lutomirski <luto@kernel.org>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        Stefano Stabellini <sstabellini@kernel.org>
References: <20211014031413.14471-1-jiangshanlai@gmail.com>
 <20211014031413.14471-5-jiangshanlai@gmail.com>
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
In-Reply-To: <20211014031413.14471-5-jiangshanlai@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: SJ0PR03CA0190.namprd03.prod.outlook.com
 (2603:10b6:a03:2ef::15) To BLAPR10MB5009.namprd10.prod.outlook.com
 (2603:10b6:208:321::10)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: cd83abbc-a7c3-4b59-587b-08d990d00880
X-MS-TrafficTypeDiagnostic: MN2PR10MB4029:
X-Microsoft-Antispam-PRVS: 
	<MN2PR10MB4029D536FBB182C0E57145AC8ABA9@MN2PR10MB4029.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 
	7//iOluov1mWVUtMBbm2zF5xT7HkojfPRv8hOI7wKn9yjoOLdtPxizfO5rSmDM+CoGgi0UZ41ABKzctXOhF3wb9O6IMhgymZXpUI3ACdeh4wC5DHXek5tuM6VQbPHLRnbety0FTjQZFJXuvVTR+0O7KSgC1k/le2Nie7IMA3Q7p9uUwgxvYKbLYh6TxWkRS6DfCI27ntnNKgx8O6FDDJ3TlDwRSukFXweXqJBDSZSKbUeeAazKkpKQdq13QwPPMbHH1C17u5DXzP3ADkxvT3LTM/OAv1l2iCzBV72GvfHBsFc+gV7IyYgBjuAHsAkpURrNDtMwIhkHse7rh6SPHSl/porgk2sQU7LVC504W0o9Vj3yxzclJ4lMB5fFFvgpAYr4UvDISTz2AGymqUwmetDjkrrZGAweVexnyK61fg8q/HO6f9KKI8+bb0LFtFQhKFbXYwHTvTHb2nkl0egEL2jUyg517Gy5//H3GAl02oQFBKFuaQbvwvLRGe5v2Ts50bvW+98ogAmdDcw67S4wc9B3DCrJjN+YEl7+QiM8EIJpvXD/AyWxlaFJJsKFAWiDO5qt6IRN+8ra+ABwsniFe+TCSwnabS3Km+FAz1Ot6HlPFPdj/RMMwL2NnEiaT7+87oSHGuuGVqsn3bY4HM70HY7e4vxs+o/br1qAaPceMoEqtXC+gPUJDp9jdREl7V2u+ybV1UgpcndiiIfwp7vI2bL4edvNYHzmdu/y93Rx+0huKv0Vo8j+mRkNAhKSLYbNwD
X-Forefront-Antispam-Report: 
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB5009.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(54906003)(53546011)(36756003)(83380400001)(66476007)(26005)(38100700002)(4326008)(508600001)(31696002)(2906002)(6486002)(8936002)(186003)(66946007)(31686004)(956004)(2616005)(44832011)(6666004)(86362001)(316002)(66556008)(16576012)(8676002)(5660300002)(7416002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?bks2QzAwdEVndXJaOFR1bmt1M21wM0hISWFvRWd3NEhqcnUzNDhNdTk5WkVn?=
 =?utf-8?B?WmFsSjB0KzBGeEJBRUJpZy9wdUI1NFQ2LzRZN1JoZXV1R1FPMWVJd1VPUytW?=
 =?utf-8?B?UDlvVURpck4waUZQSG5DTlZzK3JWdlZxNkM0REFvQ0dtS1hoNnAxZTJhZXRP?=
 =?utf-8?B?L3Y3aE5Zc2xDQ05mUHpKN2FiT0ROd05FTzhNRWxOMS9hdHVMczZmbzJxSy9J?=
 =?utf-8?B?RkxKU1V6V1J0c21yRUQrUFJ5Y0MwWDdxdHZjY3VQS29MR1VtSGMwQjMwaWdU?=
 =?utf-8?B?VTAxOEhSS0FkKzBiNXYyc0luWnQ5cFlZalpiazFEWGlMbFVPNU1MejlSR0Mz?=
 =?utf-8?B?RzN5UEtmQUtWekUvRmI1SDgwbWtLZFJUdWNVL3VpeDFQYklUN0I4OG9SSVJV?=
 =?utf-8?B?SmMweHZoV0IxZUxhNzNPajJhTGJPL0F5dFYwdWF5TXNlV2c2bzFoL1QrMlBQ?=
 =?utf-8?B?cFZ6Wmh3RThyajQrTnJnRmZ6ZDBaQm1icURXTVBIUWVwWUpDd0NIakFHbHBL?=
 =?utf-8?B?M0tsUzdEa0VOWFR4ZXRUcm5yUExRZ3RDdng2VU9zd2IrWUhWUW9SWFN0Qjh6?=
 =?utf-8?B?M1JlWVlQT1VlMkdkUFRSTVJxN2ZhcEZPSnB1SjJpUm5jV3dwQ3Jqd3BVSWw1?=
 =?utf-8?B?OU1CWHNFMlhrbVk5NVROMkhKdXlyTmg2TTY2YkdGdy9rQzdlcFYybGtucExN?=
 =?utf-8?B?cUFJOGZ1TktDK3pSUkpseVM4ZUc2bVQ3V1FnNmt3MUdpdjhZeEVaUGJHdWF6?=
 =?utf-8?B?MVZFOU53VkRpTFM1Q2xVWGl4SnN5aUFzUGZkY3lxTDJHMnVYblFGaHY0bXRj?=
 =?utf-8?B?Y2lWTEpCbXFNZldtaFF0cXkyTVlwd1VKQVJwWlNBMjRwY0V1TklhNHFwNXQx?=
 =?utf-8?B?T2hlQk9aekVpbTlpVnpZOFVVbEVXcUlMS0Vtc2R1bTlvV1NPalpnYkJJaGh2?=
 =?utf-8?B?bVA0aEVDeU5BUHEwb1B6dkRwT2FMdlZseVQ1c2F1ZnYxZko5U05FeUxmL2Z1?=
 =?utf-8?B?Q0NrczV3andDdW5tT0FuOEJJL3o0Qnl0VnJUOHczd0xXVHhIOWVZYnUwK28x?=
 =?utf-8?B?bFVKU29FUTNaK0ZNRUlCZS83NmtISWQ0K2t2U3dJV2doL1NuUHFCQmVrQU5O?=
 =?utf-8?B?b3RkcVFmQ2o1ZzVpbThrdHFjeld1cDk3NTdTRTdGTVNhS1gvVUFYa3Y3Rmxy?=
 =?utf-8?B?UVN6VzZtV1ZBU1o3L21MZnhKTDhEMjg0dHRiR1VKOUpjOTRDTG5wMk14V1Bw?=
 =?utf-8?B?UlVUTzlsUTNkOXFsQ1dVOEdYM09Ecm1pYlZGWHVaQ1BUVkI3ZjdYcGdRR1Ru?=
 =?utf-8?B?b2JlNWxkRGhXTDJkeSttTldmMjh6R1NpenhwcktFS1hyNlJuL204b2ZBREZG?=
 =?utf-8?B?V3RRNmFKS2sxdzAzM01xZWI1Q3ZFUzkvUXpzdHNPeVdxUVFTWkF5eVN0MU83?=
 =?utf-8?B?d0ExbUlRQ2pyR2RWYzBKZlhCWkZOWTRqS0RSTW9PQ1JuQ3ZPUHdyanN1aElj?=
 =?utf-8?B?M1dwRW9VRGlsY2JuN0xGQXZzNXIxMjNRY1I4bDVMUzJDQUd5STREeU82Y3Vw?=
 =?utf-8?B?bHhBOUc5aFpHSzN4b0V2b3htckZuN0htL1BvTlpSVEVHcnhlODZydVBqbFls?=
 =?utf-8?B?d3dlUmwzaVZmNmZWcWFsOHpob2tKa2NyUlRhN3VQY241RHdIczM0TUNjOGo2?=
 =?utf-8?B?MkxLc3Jwa2VCS25DM1BvU1AzVG1GR21wNk93MnBWcmtaNEhiUHNkcFRhZnJM?=
 =?utf-8?Q?BkAh4p4abaTbwqh6rWbHTYrmZ+8oMHOlSNxS8fm?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cd83abbc-a7c3-4b59-587b-08d990d00880
X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Oct 2021 18:09:02.1226
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: RjeW05seVUw3TzaYWD/Tx1zSWrS24ynuxebjdmlG8bjVbW36XmDuI+0Gkz1wneQwjpiA3TDxKEG9wuMApW09w6iKhdEQZNwIecqVNoDHMwg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR10MB4029
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10139 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 malwarescore=0 spamscore=0
 phishscore=0 bulkscore=0 mlxscore=0 mlxlogscore=999 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109230001
 definitions=main-2110160123
X-Proofpoint-GUID: gLbTOyA-ea95nxqJhTfIAROB3hJqHxAy
X-Proofpoint-ORIG-GUID: gLbTOyA-ea95nxqJhTfIAROB3hJqHxAy


On 10/13/21 11:13 PM, Lai Jiangshan wrote:
> From: Lai Jiangshan <laijs@linux.alibaba.com>
>
> While in the native case, PER_CPU_VAR(cpu_tss_rw + TSS_sp0) is the
> trampoline stack.  But XEN pv doesn't use trampoline stack, so
> PER_CPU_VAR(cpu_tss_rw + TSS_sp0) is also the kernel stack.  Hence source
> and destination stacks are identical in that case, which means reusing
> swapgs_restore_regs_and_return_to_usermode() in XEN pv would cause %rsp
> to move up to the top of the kernel stack and leave the IRET frame below
> %rsp, which is dangerous to be corrupted if #NMI / #MC hit as either of
> these events occurring in the middle of the stack pushing would clobber
> data on the (original) stack.
>
> And swapgs_restore_regs_and_return_to_usermode() pushing the IRET frame
> on to the original address is useless and error-prone when there is any
> future attempt to modify the code.
>
> Fixes: 7f2590a110b8 ("x86/entry/64: Use a per-CPU trampoline stack for IDT entries")
> Cc: Jan Beulich <jbeulich@suse.com>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Juergen Gross <jgross@suse.com>
> Cc: Peter Anvin <hpa@zytor.com>
> Cc: xen-devel@lists.xenproject.org>
> Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> Signed-off-by: Lai Jiangshan <laijs@linux.alibaba.com>


Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>




From xen-devel-bounces@lists.xenproject.org Sat Oct 16 19:02:49 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 16 Oct 2021 19:02:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.211363.368638 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbox9-0000B0-L7; Sat, 16 Oct 2021 19:02:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 211363.368638; Sat, 16 Oct 2021 19:02:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbox9-0000As-I2; Sat, 16 Oct 2021 19:02:43 +0000
Received: by outflank-mailman (input) for mailman id 211363;
 Sat, 16 Oct 2021 19:02:41 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mbox7-0000Ai-Od; Sat, 16 Oct 2021 19:02:41 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mbox7-0005u7-He; Sat, 16 Oct 2021 19:02:41 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mbox7-0005Z2-8B; Sat, 16 Oct 2021 19:02:41 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mbox7-0008MU-7e; Sat, 16 Oct 2021 19:02:41 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=pHl1/5yIVtblbE1Fcd3QV+gLfO4ZnrKcDI9vH5HUAdM=; b=v11WKAGxebDDrLY4F+8eIfdkSX
	Imrj5buruukPHrRBbmSwWlfTgT4pfTq3xWeU+5Yn4sVzNdp45GiZYhmq3af28k1avvhBxvGeN/bQV
	9/p4YLNASz2/gYwz4gM3u76wKbqzCKDXCJYBujNVkQY2U7dTtiJYSUngNkH5kITZJ1kA=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165536-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 165536: tolerable FAIL - PUSHED
X-Osstest-Failures:
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=6587b0c1331d427b0939c37e763842550ed581db
X-Osstest-Versions-That:
    qemuu=82d88f834c8f7d33ad9529fca80924bc496fcb70
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 16 Oct 2021 19:02:41 +0000

flight 165536 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165536/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165529
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165529
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 165529
 test-armhf-armhf-xl-rtds     18 guest-start/debian.repeat    fail  like 165529
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 165529
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 165529
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 165529
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 165529
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165529
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 qemuu                6587b0c1331d427b0939c37e763842550ed581db
baseline version:
 qemuu                82d88f834c8f7d33ad9529fca80924bc496fcb70

Last test of basis   165529  2021-10-15 19:39:30 Z    0 days
Testing same since   165536  2021-10-16 09:54:33 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Damien Hedde <damien.hedde@greensocs.com>
  Eric Blake <eblake@redhat.com>
  Hanna Reitz <hreitz@redhat.com>
  Jason Wang <jasowang@redhat.com>
  Kevin Wolf <kwolf@redhat.com>
  Peter Krempa <pkrempa@redhat.com>
  Richard Henderson <richard.henderson@linaro.org>
  Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/qemu-xen.git
   82d88f834c..6587b0c133  6587b0c1331d427b0939c37e763842550ed581db -> upstream-tested


From xen-devel-bounces@lists.xenproject.org Sat Oct 16 23:43:37 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 16 Oct 2021 23:43:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.211409.368763 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbtKh-0008AT-BD; Sat, 16 Oct 2021 23:43:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 211409.368763; Sat, 16 Oct 2021 23:43:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbtKh-0008AM-6h; Sat, 16 Oct 2021 23:43:19 +0000
Received: by outflank-mailman (input) for mailman id 211409;
 Sat, 16 Oct 2021 23:43:18 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mbtKg-0008AC-J7; Sat, 16 Oct 2021 23:43:18 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mbtKg-00023H-E1; Sat, 16 Oct 2021 23:43:18 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mbtKg-0003gX-4C; Sat, 16 Oct 2021 23:43:18 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mbtKg-0004ic-3j; Sat, 16 Oct 2021 23:43:18 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=fJLAYgEjQ3vpeS01VBvMjAg9RUedDNLLOayPGinLkQk=; b=w7kBozGwSLWmXPoJbHYNhsQs7h
	oUOsgCSV9rw06I/GZrrxtHV7282114d+FjVcfwZogKONnyhEEezM1TDVaClhDwBFtv9fPEsKoPzMV
	WEjr8urRXTxXwFFyOyKiwSOFX1USeuGWysQ3nzTKuzMx83e2UOU0RoB/Nhi5HLMta0x8=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165539-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 165539: regressions - FAIL
X-Osstest-Failures:
    xen-unstable:test-amd64-amd64-examine:memdisk-try-append:fail:regression
    xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=52d0847d7c6972baa74156f14ee8544f5aba1d2d
X-Osstest-Versions-That:
    xen=b75838ad6c4f42c93efee83fc2508c78641e1b57
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 16 Oct 2021 23:43:18 +0000

flight 165539 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165539/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-amd64-amd64-examine      4 memdisk-try-append       fail REGR. vs. 165524

Tests which are failing intermittently (not blocking):
 test-armhf-armhf-xl-rtds     18 guest-start/debian.repeat  fail pass in 165534

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-rtds  20 guest-localmigrate/x10 fail in 165534 like 165524
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail in 165534 like 165524
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 165524
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 165524
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165524
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165524
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 165524
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 165524
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 165524
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 165524
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 165524
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 165524
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165524
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 165524
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  52d0847d7c6972baa74156f14ee8544f5aba1d2d
baseline version:
 xen                  b75838ad6c4f42c93efee83fc2508c78641e1b57

Last test of basis   165524  2021-10-15 11:27:26 Z    1 days
Testing same since   165534  2021-10-16 05:27:33 Z    0 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Bertrand Marquis <bertrand.marquis@arm.com>
  Ian Jackson <iwj@xenproject.org>
  Jan Beulich <jbeulich@suse.com>
  Juergen Gross <jgross@suse.com>
  Michal Orzel <michal.orzel@arm.com>
  Rahul Singh <rahul.singh@arm.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Stefano Stabellini <stefano.stabellini@xilinx.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 313 lines long.)


From xen-devel-bounces@lists.xenproject.org Sun Oct 17 02:18:02 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 17 Oct 2021 02:18:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.211436.368825 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbvkD-0007vG-Bu; Sun, 17 Oct 2021 02:17:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 211436.368825; Sun, 17 Oct 2021 02:17:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbvkD-0007uo-4t; Sun, 17 Oct 2021 02:17:49 +0000
Received: by outflank-mailman (input) for mailman id 211436;
 Sun, 17 Oct 2021 02:17:48 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mbvkC-0007uc-EG; Sun, 17 Oct 2021 02:17:48 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mbvkC-0007AF-5q; Sun, 17 Oct 2021 02:17:48 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mbvkB-0000el-SJ; Sun, 17 Oct 2021 02:17:47 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mbvkB-0000JA-Ro; Sun, 17 Oct 2021 02:17:47 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=XaanSx4tDZYZEJSI/MKZ3CazcVC7/aP7t0XgJu20Pxs=; b=Jvy8kjaLW65G6apwpyyW6qX+cQ
	PunVmAZHT+0K8sCfckNmUU1Yx2TEgLyWw6A4z6I9/mEwcGQ9vSuGnR2cugN2HtNtdYuEYMCITHg5R
	xVFfCzi+piqiTOd4XAzpY/ygWivYDsR/0G8ScSN6xiea4VtdSN2pj1+JxPkg0kVw4Ldk=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165545-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 165545: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=304040fb4909f7771caf6f8e8c61dbe51c93505a
X-Osstest-Versions-That:
    linux=8fe31e0995f048d16b378b90926793a0aa4af1e5
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 17 Oct 2021 02:17:47 +0000

flight 165545 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165545/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-rtds     20 guest-localmigrate/x10       fail  like 165528
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 165528
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 165528
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165528
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165528
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 165528
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165528
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 165528
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 165528
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 linux                304040fb4909f7771caf6f8e8c61dbe51c93505a
baseline version:
 linux                8fe31e0995f048d16b378b90926793a0aa4af1e5

Last test of basis   165528  2021-10-15 16:12:00 Z    1 days
Testing same since   165545  2021-10-16 16:43:38 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Al Viro <viro@zeniv.linux.org.uk>
  Alexander Gordeev <agordeev@linux.ibm.com>
  Arnd Bergmann <arnd@arndb.de>
  Barry Song <song.bao.hua@hisilicon.com>
  Bjorn Helgaas <bhelgaas@google.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Cornelia Huck <cohuck@redhat.com>
  Eric Farman <farman@linux.ibm.com>
  Fabio Estevam <festevam@gmail.com>
  Florian Fainelli <f.fainelli@gmail.com>
  Guenter Roeck <linux@roeck-us.net>
  Guo Ren <guoren@kernel.org>
  Guo Ren <guoren@linux.alibaba.com>
  Heiko Carstens <hca@linux.ibm.com>
  Janosch Frank <frankja@linux.ibm.com>
  Jens Wiklander <jens.wiklander@linaro.org>
  Linus Torvalds <torvalds@linux-foundation.org>
  Mateusz Kwiatkowski <kfyatek+publicgit@gmail.com>
  Matthew Rosato <mjrosato@linux.ibm.com>
  Nicolas Saenz Julienne <nsaenz@kernel.org>
  Philipp Zabel <p.zabel@pengutronix.de>
  Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  Roberto Sassu <roberto.sassu@huawei.com>
  Sachi King <nakato@nakato.io>
  Shawn Guo <shawnguo@kernel.org>
  Stefan Wahren <stefan.wahren@i2se.com>
  Sudeep Holla <sudeep.holla@arm.com>
  Sumit Garg <sumit.garg@linaro.org>
  Vasily Gorbik <gor@linux.ibm.com>
  Vineet Gupta <vgupta@kernel.org>
  Wang Hai <wanghai38@huawei.com>
  Will Deacon <will@kernel.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     fail    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   8fe31e0995f0..304040fb4909  304040fb4909f7771caf6f8e8c61dbe51c93505a -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Sun Oct 17 02:52:28 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 17 Oct 2021 02:52:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.211452.368859 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbwHe-0003VS-Kb; Sun, 17 Oct 2021 02:52:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 211452.368859; Sun, 17 Oct 2021 02:52:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbwHe-0003VL-Ha; Sun, 17 Oct 2021 02:52:22 +0000
Received: by outflank-mailman (input) for mailman id 211452;
 Sun, 17 Oct 2021 02:52:21 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=SugK=PF=oracle.com=martin.petersen@srs-us1.protection.inumbo.net>)
 id 1mbwHd-0003VF-JT
 for xen-devel@lists.xenproject.org; Sun, 17 Oct 2021 02:52:21 +0000
Received: from mx0b-00069f02.pphosted.com (unknown [205.220.177.32])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 3f459100-2ef5-11ec-82a5-12813bfff9fa;
 Sun, 17 Oct 2021 02:52:20 +0000 (UTC)
Received: from pps.filterd (m0246632.ppops.net [127.0.0.1])
 by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 19H00NsD011778; 
 Sun, 17 Oct 2021 02:51:54 GMT
Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70])
 by mx0b-00069f02.pphosted.com with ESMTP id 3bqqm49r8a-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Sun, 17 Oct 2021 02:51:54 +0000
Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1])
 by aserp3020.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 19H2owIY152011;
 Sun, 17 Oct 2021 02:51:53 GMT
Received: from nam12-mw2-obe.outbound.protection.outlook.com
 (mail-mw2nam12lp2044.outbound.protection.outlook.com [104.47.66.44])
 by aserp3020.oracle.com with ESMTP id 3bqpj28sfd-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Sun, 17 Oct 2021 02:51:53 +0000
Received: from PH0PR10MB4759.namprd10.prod.outlook.com (2603:10b6:510:3d::12)
 by PH0PR10MB5530.namprd10.prod.outlook.com (2603:10b6:510:10c::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16; Sun, 17 Oct
 2021 02:51:51 +0000
Received: from PH0PR10MB4759.namprd10.prod.outlook.com
 ([fe80::a457:48f2:991f:c349]) by PH0PR10MB4759.namprd10.prod.outlook.com
 ([fe80::a457:48f2:991f:c349%9]) with mapi id 15.20.4608.018; Sun, 17 Oct 2021
 02:51:51 +0000
Received: from ca-mkp.ca.oracle.com (138.3.201.5) by
 SJ0PR03CA0105.namprd03.prod.outlook.com (2603:10b6:a03:333::20) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16 via Frontend
 Transport; Sun, 17 Oct 2021 02:51:50 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3f459100-2ef5-11ec-82a5-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject :
 from : message-id : references : date : in-reply-to : content-type :
 mime-version; s=corp-2021-07-09;
 bh=Pl/XfbWyXkO9WxOahSYpg/veQLO34KTMKHuf1fPJlq8=;
 b=H9Mcbv3eP2B1UttHPG6ujNWfe65zpOleRDKOm0xSxkpkd1AN0askNKTnQBBE4E0tcIfQ
 7dUUiSp7o3esA34K7OpgfQSJrxgWWUr29uenPzcTKf7WOeEqDt0miOXyObT208fnfGuH
 3XlnqzBmaJtH181W5ERL0eINjs0UoPmyqIO6Z3uu7DIQbhuNIEQfTQl82DCdH4scu/Go
 5L9C81K5Uzi195lm7ToiudbAisJLUHtpDkl9c8smzG0UVvqYrEBWdDHUmD5KahXcLdKJ
 1hkTc4MUDW0SBIooUJ0+Od0cma0C/qLyNyFUwvMbl2/yFrgvW0H7cf+cxkUrmGkyn8Zt ow== 
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=YNJ9tEeVny6bJG1CtMZsR5mFoJuDAKQgkXf+GMg84r5if0jwscRKFtLC0lH5aghZbStV1/XZyKWOjCPpdBpOs8OQLs9DWDB2DpxKfyA9S1NWJZEPQjFSvr3W82u0+d+jonOh0IAdeL85FqPqMpuFpMHftMfa7sxtMaAbximweZTzb6S/B+5BKjFmm8pnr0R/6STyp3cJIRBPRKtrcpEhVSXp4aylp3P64xsI8VJBMozCyCkORVu9ebMPHVdAQxzpBtuiOCFJvvgRW4yTOHuHAq0fOcwfE2V+7N2em0XPTpnPB+hp3nIJla4+1jnnmFpGDrstkebUsd4XQJB+WXHz9w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Pl/XfbWyXkO9WxOahSYpg/veQLO34KTMKHuf1fPJlq8=;
 b=nnqS5R26xbyePPq72qzvymPOo1lbWOdLzbPeRmeFkTgcD7SNXBYz1FgidtxeRbK74r/hwHNB0TDAh37PfqbEVYuIZJSvOhgPRBcR2bLiE9sKVlFw8O/opsQLam5a29Z0RVBg4sLH9OzFwiR4Fsoi9ncp7xr9t7Ez8TcHDc7xCwHv1eQGVukb9pFH7hGX4tva3mbkvHzmIhp4KbsVpjWE8WK/VJ5KolPxcbpyWm+uJJzaieFbNkPdd5kps8VmUP4ZFpcQst7YIaEIhfFm5oq0++JmN+e3cBbL24lFxfaXba0WCE4ULVD/AlQnHRpAzi71FfP3VQAbXEbi/FFM04ShAQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com;
 dkim=pass header.d=oracle.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Pl/XfbWyXkO9WxOahSYpg/veQLO34KTMKHuf1fPJlq8=;
 b=U6wB/PueCe5NeZIGjAnH9guPdczL981YavurwbH81sFGMm+ztjYU7F3h4bvPy8fzjMzCB39VMRWUB+17nVCnCCc275SVmO4YAbN5rI4kLUDQlgDmJqHALxHBW3moCy9s2SwNCOhfYNnWwMx+lTJW0Gum+2GQJLHezoUHzrAuvOo=
Authentication-Results: kernel.org; dkim=none (message not signed)
 header.d=none;kernel.org; dmarc=none action=none header.from=oracle.com;
To: Luis Chamberlain <mcgrof@kernel.org>
Cc: axboe@kernel.dk, jejb@linux.ibm.com, martin.petersen@oracle.com,
        agk@redhat.com, snitzer@redhat.com, colyli@suse.de,
        kent.overstreet@gmail.com, boris.ostrovsky@oracle.com, jgross@suse.com,
        sstabellini@kernel.org, roger.pau@citrix.com, geert@linux-m68k.org,
        ulf.hansson@linaro.org, tj@kernel.org, hare@suse.de, jdike@addtoit.com,
        richard@nod.at, anton.ivanov@cambridgegreys.com,
        johannes.berg@intel.com, krisman@collabora.com,
        chris.obbard@collabora.com, thehajime@gmail.com,
        zhuyifei1999@gmail.com, haris.iqbal@ionos.com, jinpu.wang@ionos.com,
        miquel.raynal@bootlin.com, vigneshr@ti.com,
        linux-mtd@lists.infradead.org, linux-scsi@vger.kernel.org,
        dm-devel@redhat.com, linux-bcache@vger.kernel.org,
        xen-devel@lists.xenproject.org, linux-m68k@lists.linux-m68k.org,
        linux-um@lists.infradead.org, linux-block@vger.kernel.org,
        linux-kernel@vger.kernel.org, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH 1/9] scsi/sd: add error handling support for add_disk()
From: "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq1bl3ofjo5.fsf@ca-mkp.ca.oracle.com>
References: <20211015233028.2167651-1-mcgrof@kernel.org>
	<20211015233028.2167651-2-mcgrof@kernel.org>
Date: Sat, 16 Oct 2021 22:51:48 -0400
In-Reply-To: <20211015233028.2167651-2-mcgrof@kernel.org> (Luis Chamberlain's
	message of "Fri, 15 Oct 2021 16:30:20 -0700")
Content-Type: text/plain
X-ClientProxiedBy: SJ0PR03CA0105.namprd03.prod.outlook.com
 (2603:10b6:a03:333::20) To PH0PR10MB4759.namprd10.prod.outlook.com
 (2603:10b6:510:3d::12)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 87750c7a-62d2-4af9-7bce-08d9911911c6
X-MS-TrafficTypeDiagnostic: PH0PR10MB5530:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: 
	<PH0PR10MB55306D7AD1B871FDE590A8488EBB9@PH0PR10MB5530.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6790;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 
	T+3QZh9zDXqbMpdWQQ/r85NOc5Ti89JpwExfWWPeOwMUQTWQzPmsvCr5wfJECIO/PO0Zma+QD5T33Op2EB5Qt0qbsEjMFbUp81rTL0WzJ9EUm+kdIZ6AqkNbbxlXFj/U+Yrjb8NBGn2jckdXFwJSIUvxHMFDuqdNfSQv2ppXc1zeNR6EsIsmJgmIU8uORpHOdThJLSKwp0OYoGbKtfuJEBCLoYbqath8C+BKd5cfrqoA8U/gbJPZbbhKO+2ZhJGeh2peLmMZmNbcjaQJqWY/8/Xx2lb3ZgJm8Ncgh4flggLaqAkTuknwiL8BkFKMaaltI5zYiUKb2oFpb29J+1MOmVcYQe+Y4iejXTuDgEHtpPlXMDX3ru6ayRTf/eX5DM4UgSBqN3gi66NcVUnx+7T2seNETumb6ZunepJdKQypSIJCHcj17Folhds9kKowKStACbc18fjqyeAQybYIV9YwNUSWakn3m+kUm5d7ympfQK2b3UmkBdFs4WcyTv8Ep1aeFCx5L95H4MbYPWH0zHZUAWZw9VsxC8N3rX6YFKBDOPF54bzNB9GkwSMQtCe96R4aRDVRZ3vnxjOSX5SS4m4TGP9wpLsLM2tfWis6k0YrXkg/axCUgF7e0W2J26kcHq0hG9rzcVCpI13HTnmN8eNJM9EZnVLKtfBy6CNDWMvcrebdqbH5RdVsh5Ph4Q7h22xKyx0n/53HZGfVZ6nn4FvU0w==
X-Forefront-Antispam-Report: 
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR10MB4759.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(86362001)(4326008)(7416002)(2906002)(7406005)(8936002)(186003)(55016002)(508600001)(8676002)(38100700002)(66946007)(4744005)(26005)(7696005)(956004)(38350700002)(36916002)(6916009)(66556008)(66476007)(5660300002)(316002)(52116002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?kbOcSvfAD3n8+/pgfNz4afbOzyk+4imAhPOnJpxkTf3ax8Y/1yToD7VQRkGd?=
 =?us-ascii?Q?qhE5G0NdN+zo2pCC9drM2JygrIoNPpoGovRXweaL2EbCA+De+5sdUcsyBZLd?=
 =?us-ascii?Q?jGHa1OqM4GlvLOtRjaYnnWidD3dBmlQumSh75LqqxVJ5UzSTiQqT+6YahZ5J?=
 =?us-ascii?Q?s/xvH33hDO84KdfO7DzT3JTAGoy7CA3Mia2s7GaOTGHd6AM6kGrBZrzX6KvR?=
 =?us-ascii?Q?MK6FtmfbbKape0swwjU6zXKnz4cBXifUakFq5qBvyymgGuo2eE+JJhzFoepf?=
 =?us-ascii?Q?+UmBpauR6B3q4kxogOriPhddWPLD2FiaL14AALtkRz5ths4GzWNsX0ye/2qC?=
 =?us-ascii?Q?gXsFs/z4d4tFR+E2PoWzaA3HkYbhXUSMUpuJ92GG7Hu0kzORz8UzMocu7MHm?=
 =?us-ascii?Q?0TxdEHtx0OpawTqM/wnBqIuSR4ClbvjGtQOv0B5nxiSSEffX8qcQp+e4qcAw?=
 =?us-ascii?Q?cLDUc6ZiLsYNeBjxxn9gZuoCaLRhbM8tcB+sGb+F3/5TGUd2q34h13YvVfIR?=
 =?us-ascii?Q?mFbzww1kiMt4kYtP619iZWrxN61cjjvnf5eJmjRjJUAhknFSmdFSZghfv4nN?=
 =?us-ascii?Q?Nh8tRig/u0wBGdqDw6NW0hpMxdTI0aPxUjGd1Fzjk8KdiDBzw1wB1oWTdOdW?=
 =?us-ascii?Q?5QoymXHRsRqottz1LAfEj1bqLQ4rKTF+A0iZLAgvKLFOTWA6oGhxWYBBRlTl?=
 =?us-ascii?Q?S1hR/x9rX2464fWOjw85GhE/H8/9bSwvAn96DxbaZDfO+uRQ/2kjHNxS4OLG?=
 =?us-ascii?Q?jnTIcXdbj43Rw3nKlFdDljTUHINRmhJUh/5yWTYC51BKORAV3UDzLU0wg+8Q?=
 =?us-ascii?Q?UVysoJld9Rjhw0sNA0uvROVtP0EJN/EdCef49o37CvkhfWTc2p1NbRUMRSjB?=
 =?us-ascii?Q?RDCV0SKTbSQ3bigKGD3B9wVouZfAXwcPldL6VXN4GYp+JSkCXRYlRmmub5bf?=
 =?us-ascii?Q?46VvObEgIjvWfUV93OzqOnTJvzGSRvZqeVNtq+xdCCIsi8+uQJfK/+1uT4j3?=
 =?us-ascii?Q?w8Vgv4G0vFoppxrjOdclGUnYDgVcONfeq6Xu4BcIWaUeGt5rOxkjx5QDx7vJ?=
 =?us-ascii?Q?HAK71BnywH+40DJvxrAYaE40klq/ZriRMX62RH5465m7szhs2eFx28akDjT8?=
 =?us-ascii?Q?DCWfQJKgSkEj0pVwbMCP/VtAocPU3L5tWsrYraWZCAS/xJD8eRkVSl52D1BB?=
 =?us-ascii?Q?slBcB2cYui7HayYCicaLOW8kMX/sOpnjOEP398XqMbm0RaBqL9xNXfx9s+LN?=
 =?us-ascii?Q?EPzGZ74dw3eACDizqTMgy0x0QjEErlUxq3bB0xSNUikrj4gP7hyWr/LxgTtI?=
 =?us-ascii?Q?soND5s1uxdkkWCoBILN0KFSJ?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 87750c7a-62d2-4af9-7bce-08d9911911c6
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Oct 2021 02:51:50.9440
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: B/ypriX/ATAIn+9bdvbRDsWuRS9rBK0O+rHMXxZXH5WW0+QSxhlFYmySwH5NeyKvdSQZMEIdkTc6cHUDMazsQtp0X7jo2SzeiQhTTssOTog=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB5530
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10139 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 spamscore=0 adultscore=0
 malwarescore=0 phishscore=0 bulkscore=0 mlxlogscore=999 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109230001
 definitions=main-2110170019
X-Proofpoint-GUID: u-f9w0o21UbNSEkBxlEUvTP3SOw8xORs
X-Proofpoint-ORIG-GUID: u-f9w0o21UbNSEkBxlEUvTP3SOw8xORs


Luis,

> We never checked for errors on add_disk() as this function returned
> void. Now that this is fixed, use the shiny new error handling.
>
> As with the error handling for device_add() we follow the same logic
> and just put the device so that cleanup is done via the
> scsi_disk_release().

Acked-by: Martin K. Petersen <martin.petersen@oracle.com>

-- 
Martin K. Petersen	Oracle Linux Engineering


From xen-devel-bounces@lists.xenproject.org Sun Oct 17 02:54:23 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 17 Oct 2021 02:54:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.211461.368874 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbwJa-0004Av-9d; Sun, 17 Oct 2021 02:54:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 211461.368874; Sun, 17 Oct 2021 02:54:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mbwJa-0004Ao-6T; Sun, 17 Oct 2021 02:54:22 +0000
Received: by outflank-mailman (input) for mailman id 211461;
 Sun, 17 Oct 2021 02:54:20 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=SugK=PF=oracle.com=martin.petersen@srs-us1.protection.inumbo.net>)
 id 1mbwJY-0004Ag-IT
 for xen-devel@lists.xenproject.org; Sun, 17 Oct 2021 02:54:20 +0000
Received: from mx0a-00069f02.pphosted.com (unknown [205.220.165.32])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 85a5f554-2ef5-11ec-82a5-12813bfff9fa;
 Sun, 17 Oct 2021 02:54:19 +0000 (UTC)
Received: from pps.filterd (m0246617.ppops.net [127.0.0.1])
 by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 19GNRbBI014069; 
 Sun, 17 Oct 2021 02:53:53 GMT
Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80])
 by mx0b-00069f02.pphosted.com with ESMTP id 3bqqmasrmq-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Sun, 17 Oct 2021 02:53:53 +0000
Received: from pps.filterd (userp3030.oracle.com [127.0.0.1])
 by userp3030.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 19H2pNdu067524;
 Sun, 17 Oct 2021 02:53:52 GMT
Received: from nam10-dm6-obe.outbound.protection.outlook.com
 (mail-dm6nam10lp2105.outbound.protection.outlook.com [104.47.58.105])
 by userp3030.oracle.com with ESMTP id 3bqkuts2mn-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Sun, 17 Oct 2021 02:53:52 +0000
Received: from PH0PR10MB4759.namprd10.prod.outlook.com (2603:10b6:510:3d::12)
 by PH0PR10MB5530.namprd10.prod.outlook.com (2603:10b6:510:10c::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16; Sun, 17 Oct
 2021 02:53:49 +0000
Received: from PH0PR10MB4759.namprd10.prod.outlook.com
 ([fe80::a457:48f2:991f:c349]) by PH0PR10MB4759.namprd10.prod.outlook.com
 ([fe80::a457:48f2:991f:c349%9]) with mapi id 15.20.4608.018; Sun, 17 Oct 2021
 02:53:49 +0000
Received: from ca-mkp.ca.oracle.com (138.3.201.5) by
 BL0PR1501CA0010.namprd15.prod.outlook.com (2603:10b6:207:17::23) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.14 via Frontend
 Transport; Sun, 17 Oct 2021 02:53:49 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 85a5f554-2ef5-11ec-82a5-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject :
 from : message-id : references : date : in-reply-to : content-type :
 mime-version; s=corp-2021-07-09;
 bh=F2DuFZ9tEWw4pRHLyoqBJHru4J2Eh5wEYZRxt2aKZAw=;
 b=AOcypj59y7ZyRx1awne5AcuNgMSsM9X7ZfYDKHX05RGCPTMExifBvl+70niN1vZ1v/qv
 OBYevr+rVlNAMgkLsvMR/1TSTL+XFLoTbyHbEYyfEMoh/gLpYU2+WReNnIEvrMMtQew5
 u0KZF3siX+fkAoSMsjBHgf9NwrWbn1QU0iDpoKIIz+lcmqikA691qcjGvX8RlEboqtWl
 MXGqT6s/DyCxnx1MTGbnkzkCNDLY+iRO82M60NarPrrsUO3qE5BQLau73GOzoNyDjpP4
 KWB/cwcPQ9gSyiWWPjFxwq3wFCgpSaw4soG47553+NVXyoXeZ8spXTRrv79DQvcnvNIe 5A== 
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=HDFvxUy5Td0BOMWY2WVU+mBNO3B4l+xUxRH3H2l/oa/baci01p0Extk94woA/P+XrqGNTTTs2dDHUk4FELk5RKigdmVo2G3bmHe8CMLRHVVHgTpFIuyDyVUyseBPJe+7QliPo2mR8AIZQTkAN30xwjdxqpWw4/ZCNGk4MY0iez2uIYrjJeM2jrVOEWY9WPqWCnsvVWAU9GIiLcU0Tv5J6xVrLm4l/14WHo5M0Xao5BAvHbeMefasdSMWkWapkJCaHhXGnX/XbziarrwOjjz26WkE9NaV2W6hbsHOvCSaQO+TYHhYk2+8QqYdy2R6OeYZosVERqqCntWQ+BQrKoUiFg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=F2DuFZ9tEWw4pRHLyoqBJHru4J2Eh5wEYZRxt2aKZAw=;
 b=dSSdyrJA5+8XoZe/i0QOzZMCImPSFpSUryId3y3UQ89qsTTRXhTs5q/srlBr5M65B9G6Od3DZUfZRUURy7I/wp8ZpSUl99aNmP7Sb6mNtvr3RsHxZ0Wp3MJCBwSiwJ4VscHuF/MuglALQAr/NPu412Sh8yQR+Uu6hHluklXPyPtleVvcSNzsvp9eK7AvFxcG9vstRuEPeKudTdDCUMPEGIEGhGLapSuKKqt5869S3YvOaSRXn4L9IBx9UZ7GJzDpYzurv90IUOQ0VjZCcR5Kh7vvvTvxSyZb7/gQKwuz9QOZEpGngorS1Z01Wtg76Ib8xB8ebk3bc3WaglvNWt815g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com;
 dkim=pass header.d=oracle.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=F2DuFZ9tEWw4pRHLyoqBJHru4J2Eh5wEYZRxt2aKZAw=;
 b=kcFmucZgHqGPmog2rswUQYiywjt/6Lqn9Geee/rYgEIxxh/BaowsjVs70bXtA6gBPA5yAreAO5vsNIR9NbEKBZv/w4whTUIOrty7EwPnPaO4/2WRUXobyOMGDH1KsG/TGk/71XORW2F3do9LTROow80RttJ9vYWDKtNk7fcyCxQ=
Authentication-Results: kernel.org; dkim=none (message not signed)
 header.d=none;kernel.org; dmarc=none action=none header.from=oracle.com;
To: Luis Chamberlain <mcgrof@kernel.org>
Cc: axboe@kernel.dk, jejb@linux.ibm.com, martin.petersen@oracle.com,
        agk@redhat.com, snitzer@redhat.com, colyli@suse.de,
        kent.overstreet@gmail.com, boris.ostrovsky@oracle.com, jgross@suse.com,
        sstabellini@kernel.org, roger.pau@citrix.com, geert@linux-m68k.org,
        ulf.hansson@linaro.org, tj@kernel.org, hare@suse.de, jdike@addtoit.com,
        richard@nod.at, anton.ivanov@cambridgegreys.com,
        johannes.berg@intel.com, krisman@collabora.com,
        chris.obbard@collabora.com, thehajime@gmail.com,
        zhuyifei1999@gmail.com, haris.iqbal@ionos.com, jinpu.wang@ionos.com,
        miquel.raynal@bootlin.com, vigneshr@ti.com,
        linux-mtd@lists.infradead.org, linux-scsi@vger.kernel.org,
        dm-devel@redhat.com, linux-bcache@vger.kernel.org,
        xen-devel@lists.xenproject.org, linux-m68k@lists.linux-m68k.org,
        linux-um@lists.infradead.org, linux-block@vger.kernel.org,
        linux-kernel@vger.kernel.org, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH 2/9] scsi/sr: add error handling support for add_disk()
From: "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq15ytwfjkp.fsf@ca-mkp.ca.oracle.com>
References: <20211015233028.2167651-1-mcgrof@kernel.org>
	<20211015233028.2167651-3-mcgrof@kernel.org>
Date: Sat, 16 Oct 2021 22:53:47 -0400
In-Reply-To: <20211015233028.2167651-3-mcgrof@kernel.org> (Luis Chamberlain's
	message of "Fri, 15 Oct 2021 16:30:21 -0700")
Content-Type: text/plain
X-ClientProxiedBy: BL0PR1501CA0010.namprd15.prod.outlook.com
 (2603:10b6:207:17::23) To PH0PR10MB4759.namprd10.prod.outlook.com
 (2603:10b6:510:3d::12)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: a0bfa92a-e7e4-442d-5367-08d99119585e
X-MS-TrafficTypeDiagnostic: PH0PR10MB5530:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: 
	<PH0PR10MB5530FB6FDCAAC407630802F68EBB9@PH0PR10MB5530.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6790;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 
	QsfLZfZig6woBatdGRDkFbq31aXp+FtDjZ22KG0u/EGf74TEgLQMnQ8fwVXMIG53SEp7ETZvSuwAj6Y4z3UE4fEsqieMYJWnstNbAxA7sJs/hJyanmu2jHI7wOeQ5Z4QVV8sqpVUIWhGm7+rcTgmYsryKHc1VR/Q0yEhCaV8k8ywh5tcEcHZKcDWl3LB7No4mjLxVD2n8KiPwxmL8vpZXBepFfZcwtMR1jKx+2ql+62ayBGG62x64ygXgkJKrqifRtc2JZvejCkd1tO9Xih6+zjqsKRxbXhm1Vqdb6oyvlggYv2vfidCn2AoDTdSn1zDMU4Ubi613ZwVREwNR9XmPIZbxWnZ2SyZsXBSitz7lmucZ1x+tXBSabs/feg4pZfrPTG74C958OqjGGgZ31E60WtUy9uYQealKXFf4kHyDKhf0hGpTFErkptPw9qu+xDKFjRpmSuQ+K87C1u5Cd2lQTn29vOHF0m2s+QdfCQKeZf0M7dJj18L18A2uNRj8WCh+hlJuP/wa+OQw4zGN4EGH5WJTE0zvrQBvhd6VmKDIQigpBiIT8yPDGR4Pt8xqsJSgkxJsMrBpNd/8fp63mKlLeAFVkd/BMJ8On9AnU+oHdx5/0Vs8AqA+lCS3YEGrn8q0y7dEb1bs2bkJFSzvs0E0/BkK2rPqHvqLIHvYS8yfV7ROdD7MazUWzSjcluYA/eMcUVBJ67D6pP7zQvPF6u15g==
X-Forefront-Antispam-Report: 
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR10MB4759.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(86362001)(4326008)(7416002)(2906002)(7406005)(8936002)(186003)(55016002)(508600001)(8676002)(38100700002)(66946007)(4744005)(26005)(7696005)(956004)(38350700002)(36916002)(6916009)(66556008)(66476007)(5660300002)(316002)(52116002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?clQft+DB/cQ8EVhShXnj7YVUmpucmfWZRpuSu8mJ//Ky+BYesLu9ourropjG?=
 =?us-ascii?Q?RxSIHIpSCvwFSWxxIxfc/qr/8l5g0udTacPwjX+VpzIsf1R8WzQ7eBycW+ej?=
 =?us-ascii?Q?cCOPkh7KuMmBeAQLiSYysQd9gihuqhcNT2Oe2d6sTeYvCFtfeyRn9IUM4XCZ?=
 =?us-ascii?Q?gVzcpsSjY/8wpIamEkl/mXP6wt7nuNUXysbb7/GgzYUjHy0NxuauQW7HkM3y?=
 =?us-ascii?Q?GOS0/XZDZxIIrFtegT3sw2J2B8IMcKN1VgW7QbZrS6qpviFiYjyTEkUSOy0R?=
 =?us-ascii?Q?lHvHxqhFUztNFXdc287j4G+KNAj2hYgT6snPDdvGiShk32Rmbt6r71l0l8Yw?=
 =?us-ascii?Q?4HeLrfdg3748lAW+Lfyz+tGEwLpzP4VWivFDzL22/EuQ7OPi+RnBVp8Hpp4f?=
 =?us-ascii?Q?WtQj2tHyaNmU7Yo+naiUAZ6+rhmpASstZPO+W92RoddrOJliHnH8Q8rBWfrD?=
 =?us-ascii?Q?i4JJ42ridVUEETgrBjFQEb5A4QhNBT61sDrH6TXuMCUfb7OUTwUwwtURIBwt?=
 =?us-ascii?Q?sBOgY9MBo74eHnw3uthYfw3pGleEnVtR4thv+dSt0vlAESnTXeU1nGaAe51b?=
 =?us-ascii?Q?Y3b71DyF54UhxaDSAnNlTuA4HBvZQeJ9/IS2zTTGO7g4JFoJCXHEUM/9NV2m?=
 =?us-ascii?Q?JBcO2nnO3X/3Ie6jOleivATjdVjFJ8isZSnMfJzAP9GQt7bMCVFGCUSe/w4e?=
 =?us-ascii?Q?oEcRBAzVdqoxXGNy81LJ2MexpvsD1LLUkW1ezkTmorpD1Ubb/DlosXUkzvJQ?=
 =?us-ascii?Q?3SGIoBCxnVYxLdOu99LLoQKFUThfOBW5xc0ja5j/Jxrssb3FEa4vijSDE6Or?=
 =?us-ascii?Q?V5El65zm0gDXc+IF551YGzb+GMUfvJ4SHmbmOr4Wp00r+7tJPPy87Hy3Srjo?=
 =?us-ascii?Q?jwey5MAJvORBenuyMcbWgYN+ETyxmya/2m9HH6h4C2JQ5fLTpnvs18Wp74UY?=
 =?us-ascii?Q?exTtgHVuZ6Ardxmh7GyoBwilEUbu0z/Ud/J8Z/oM6JDbu83O5S5DSN78eiY4?=
 =?us-ascii?Q?jEUjOcUyf4YjaLNVugBSgZndjcnoiALFYEdGRD4QQmuTjib4yi/4Jy2cvjKl?=
 =?us-ascii?Q?7fZKcDRAtlPWZoeElS9XIBwKdQaZ0UIxs+XRqi14oJFZbM5Q5VaxaHwQSL8f?=
 =?us-ascii?Q?NNA+W1GC0Sef5Fn3G5Jd8lgHUgv22kRr5Abfwhlydx8LJ1fPzec9KaVQEcr1?=
 =?us-ascii?Q?GySCSiZ2G6B63xA+TVtsxIHt0YZEjmzwXoIrEfxnnaG2AAJC+0OUqzaM7eDA?=
 =?us-ascii?Q?Yopqf1ewabImciPqNvkFp6BoUNAo7BUZoFtgVoSJkJogbFQnudNDRPlgR5oZ?=
 =?us-ascii?Q?c9rWQY6EpSoBz7Nq+6CXH8Wm?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a0bfa92a-e7e4-442d-5367-08d99119585e
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Oct 2021 02:53:49.3676
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: F5OBFaaQD8apEfWdamOSQEWEVDWX+cI9u7UMWTM7JNXOFtbhYrtY0Q8jykOxQvswZFmGFguQdsrLejGQCVSIYWH//GHD/ncfle+IdRZ2dLA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB5530
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10139 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 suspectscore=0
 malwarescore=0 bulkscore=0 phishscore=0 adultscore=0 spamscore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2109230001 definitions=main-2110170019
X-Proofpoint-ORIG-GUID: I9vDwYIJ4XUL_ytw0gWdScYgWipqJs0n
X-Proofpoint-GUID: I9vDwYIJ4XUL_ytw0gWdScYgWipqJs0n


Luis,

> We never checked for errors on add_disk() as this function returned
> void. Now that this is fixed, use the shiny new error handling.
>
> Just put the cdrom kref and have the unwinding be done by
> sr_kref_release().

Acked-by: Martin K. Petersen <martin.petersen@oracle.com>

-- 
Martin K. Petersen	Oracle Linux Engineering


From xen-devel-bounces@lists.xenproject.org Sun Oct 17 09:01:10 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 17 Oct 2021 09:01:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.211526.369035 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mc22K-0004Fk-N2; Sun, 17 Oct 2021 09:00:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 211526.369035; Sun, 17 Oct 2021 09:00:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mc22K-0004Fd-IC; Sun, 17 Oct 2021 09:00:56 +0000
Received: by outflank-mailman (input) for mailman id 211526;
 Sun, 17 Oct 2021 09:00:54 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mc22I-0004FT-Gk; Sun, 17 Oct 2021 09:00:54 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mc22I-0006Kn-Bf; Sun, 17 Oct 2021 09:00:54 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mc22I-0006OO-5W; Sun, 17 Oct 2021 09:00:54 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mc22I-0006rb-52; Sun, 17 Oct 2021 09:00:54 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=0tjutn5evbiYe9aEoy39BnCs5FcifxW9L1/5Sf+9Rs8=; b=rWol9NPn+LbVBGlGJkItl+UX+1
	NOqmCIbDhmpEHDlvA73f35CeQ0FLsHRxwfqyy+Sqtv77rJCZ74ColqQCkMiM42nYUcVGb9sc5GMGG
	PT6fTBvV6S30sNr2rPOo955E0OcqaUnxDkuSWyPfwV0F4rY0D+wUdPnK5AyCFLhdsx0U=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165576-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 165576: tolerable FAIL - PUSHED
X-Osstest-Failures:
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=c148a0572130ff485cd2249fbdd1a3260d5e10a4
X-Osstest-Versions-That:
    qemuu=6587b0c1331d427b0939c37e763842550ed581db
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 17 Oct 2021 09:00:54 +0000

flight 165576 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165576/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165536
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165536
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 165536
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 165536
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 165536
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 165536
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 165536
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165536
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 qemuu                c148a0572130ff485cd2249fbdd1a3260d5e10a4
baseline version:
 qemuu                6587b0c1331d427b0939c37e763842550ed581db

Last test of basis   165536  2021-10-16 09:54:33 Z    0 days
Testing same since   165576  2021-10-17 00:06:59 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Laurent Vivier <laurent@vivier.eu>
  Michael Rolnik <mrolnik@gmail.com>
  Richard Henderson <richard.henderson@linaro.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/qemu-xen.git
   6587b0c133..c148a05721  c148a0572130ff485cd2249fbdd1a3260d5e10a4 -> upstream-tested


From xen-devel-bounces@lists.xenproject.org Sun Oct 17 10:35:21 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 17 Oct 2021 10:35:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.211549.369087 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mc3VN-0004Se-5F; Sun, 17 Oct 2021 10:35:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 211549.369087; Sun, 17 Oct 2021 10:35:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mc3VN-0004SX-29; Sun, 17 Oct 2021 10:35:01 +0000
Received: by outflank-mailman (input) for mailman id 211549;
 Sun, 17 Oct 2021 10:35:00 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mc3VM-0004SN-6E; Sun, 17 Oct 2021 10:35:00 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mc3VM-0007un-0o; Sun, 17 Oct 2021 10:35:00 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mc3VL-0002Wg-Qw; Sun, 17 Oct 2021 10:34:59 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mc3VL-0000Ri-QR; Sun, 17 Oct 2021 10:34:59 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=QZmTpa8Um/NvDia2ZERDEp5SuQKlm9SImXvqfbgsytM=; b=4+zgHnzJ+Z2YsL7u4jP5YeptNZ
	jH9yFCPdJP6eWza4tTa8gCrsf1vtE6/PqUWJ3+y0AUp5x7/bwlwbWvaywHyJPP3adCj9dVZUackvw
	HZTaOkP6WI7oWB9+WRCS2U75lUkKFq9a8f+hec37gDUdIUvTKQsC0stXxRkkgAlit7ds=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165617-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-coverity test] 165617: all pass - PUSHED
X-Osstest-Versions-This:
    xen=52d0847d7c6972baa74156f14ee8544f5aba1d2d
X-Osstest-Versions-That:
    xen=f9294486926c865a3ef11cacd7cb6b26cce6f4a4
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 17 Oct 2021 10:34:59 +0000

flight 165617 xen-unstable-coverity real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165617/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 xen                  52d0847d7c6972baa74156f14ee8544f5aba1d2d
baseline version:
 xen                  f9294486926c865a3ef11cacd7cb6b26cce6f4a4

Last test of basis   165493  2021-10-13 09:20:53 Z    4 days
Testing same since   165617  2021-10-17 09:18:30 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Anthony PERARD <anthony.perard@citrix.com>
  Bertrand Marquis <bertrand.marquis@arm.com>
  Christian Lindig <christian.lindig@citrix.com<mailto:christian.lindig@citrix.com>>
  Ian Jackson <iwj@xenproject.org>
  Jan Beulich <jbeulich@suse.com>
  Juergen Gross <jgross@suse.com>
  Julien Grall <jgrall@amazon.com>
  Julien Grall <julien@xen.org>
  Luca Fancellu <luca.fancellu@arm.com>
  Michal Orzel <michal.orzel@arm.com>
  Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
  Rahul Singh <rahul.singh@arm.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Stefano Stabellini <stefano.stabellini@xilinx.com>
  Volodymyr Babchuk <volodymyr_babchuk@epam.com>

jobs:
 coverity-amd64                                               pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   f929448692..52d0847d7c  52d0847d7c6972baa74156f14ee8544f5aba1d2d -> coverity-tested/smoke


From xen-devel-bounces@lists.xenproject.org Sun Oct 17 11:59:08 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 17 Oct 2021 11:59:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.211568.369135 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mc4oW-0003hu-6J; Sun, 17 Oct 2021 11:58:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 211568.369135; Sun, 17 Oct 2021 11:58:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mc4oW-0003hn-2m; Sun, 17 Oct 2021 11:58:52 +0000
Received: by outflank-mailman (input) for mailman id 211568;
 Sun, 17 Oct 2021 11:58:50 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mc4oU-0003hd-LG; Sun, 17 Oct 2021 11:58:50 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mc4oU-0000sj-DU; Sun, 17 Oct 2021 11:58:50 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mc4oU-0007OE-4D; Sun, 17 Oct 2021 11:58:50 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mc4oU-0004ef-3j; Sun, 17 Oct 2021 11:58:50 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=R4v5ImLsyOKPjDFmSRbHaFitcSgS/8lupTkEF2V7Nac=; b=TzhRIBQRrszGXja4so2gSv3iTl
	lg/7eKlvlqx9RWmn8Uq9viheu6NXOTNLnnq5G+Clgti6oRr9LnzkajW7OKHwH3Ops5QrhmUDLGpJ2
	RRYDMp5vzVpzHajqVir3i4gX8kL4ridCX0NujKP77RcIGfu2Aj5mj4tp7s0pj7P1/5gY=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165575-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 165575: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=52d0847d7c6972baa74156f14ee8544f5aba1d2d
X-Osstest-Versions-That:
    xen=b75838ad6c4f42c93efee83fc2508c78641e1b57
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 17 Oct 2021 11:58:50 +0000

flight 165575 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165575/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 165524
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 165524
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165524
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165524
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 165524
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 165524
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 165524
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 165524
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 165524
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 165524
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165524
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 165524
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  52d0847d7c6972baa74156f14ee8544f5aba1d2d
baseline version:
 xen                  b75838ad6c4f42c93efee83fc2508c78641e1b57

Last test of basis   165524  2021-10-15 11:27:26 Z    2 days
Testing same since   165534  2021-10-16 05:27:33 Z    1 days    3 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Bertrand Marquis <bertrand.marquis@arm.com>
  Ian Jackson <iwj@xenproject.org>
  Jan Beulich <jbeulich@suse.com>
  Juergen Gross <jgross@suse.com>
  Michal Orzel <michal.orzel@arm.com>
  Rahul Singh <rahul.singh@arm.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Stefano Stabellini <stefano.stabellini@xilinx.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   b75838ad6c..52d0847d7c  52d0847d7c6972baa74156f14ee8544f5aba1d2d -> master


From xen-devel-bounces@lists.xenproject.org Sun Oct 17 12:42:37 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 17 Oct 2021 12:42:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.211596.369207 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mc5Uj-0000pP-AW; Sun, 17 Oct 2021 12:42:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 211596.369207; Sun, 17 Oct 2021 12:42:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mc5Uj-0000pI-7U; Sun, 17 Oct 2021 12:42:29 +0000
Received: by outflank-mailman (input) for mailman id 211596;
 Sun, 17 Oct 2021 12:42:28 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mc5Ui-0000p8-9h; Sun, 17 Oct 2021 12:42:28 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mc5Ui-0001f1-3z; Sun, 17 Oct 2021 12:42:28 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mc5Uh-00018J-RU; Sun, 17 Oct 2021 12:42:27 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mc5Uh-0000Xv-R1; Sun, 17 Oct 2021 12:42:27 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=RVlhds9miu6p0tgW5D8pi67Rh4nhQcumijqPCWjj+HU=; b=G7WlatQ2Wde3HTcQbDICSr7D/P
	JUIoMbG5+VUex1erdnC1sf2LXA9G7rnopF4GpzEIOtlRooWRkZ7IsYI6TqlmWv5kvR4zmIDdEX9Ld
	cb5GmyCykJGbwiwHGNrATwhSHBTXlfdjEArZfO6kJ28P1tHridJiBkeMpTl0TaXjX5VY=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165595-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 165595: regressions - FAIL
X-Osstest-Failures:
    libvirt:build-armhf-libvirt:libvirt-build:fail:regression
    libvirt:build-amd64-libvirt:libvirt-build:fail:regression
    libvirt:build-arm64-libvirt:libvirt-build:fail:regression
    libvirt:build-i386-libvirt:libvirt-build:fail:regression
    libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    libvirt=2703b0b5bf2751d523a4d8d61901e473c92ba198
X-Osstest-Versions-That:
    libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 17 Oct 2021 12:42:27 +0000

flight 165595 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165595/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-armhf-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-amd64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-arm64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-i386-libvirt            6 libvirt-build            fail REGR. vs. 151777

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-libvirt-vhd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a

version targeted for testing:
 libvirt              2703b0b5bf2751d523a4d8d61901e473c92ba198
baseline version:
 libvirt              2c846fa6bcc11929c9fb857a22430fb9945654ad

Last test of basis   151777  2020-07-10 04:19:19 Z  464 days
Failing since        151818  2020-07-11 04:18:52 Z  463 days  449 attempts
Testing same since   165533  2021-10-16 04:21:23 Z    1 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
    Adolfo Jayme Barrientos <fitoschido@gmail.com>
  Aleksandr Alekseev <alexander.alekseev@virtuozzo.com>
  Aleksei Zakharov <zaharov@selectel.ru>
  Andika Triwidada <andika@gmail.com>
  Andrea Bolognani <abologna@redhat.com>
  Ani Sinha <ani@anisinha.ca>
  Balázs Meskó <meskobalazs@mailbox.org>
  Barrett Schonefeld <bschoney@utexas.edu>
  Bastian Germann <bastiangermann@fishpost.de>
  Bastien Orivel <bastien.orivel@diateam.net>
  BiaoXiang Ye <yebiaoxiang@huawei.com>
  Bihong Yu <yubihong@huawei.com>
  Binfeng Wu <wubinfeng@huawei.com>
  Bjoern Walk <bwalk@linux.ibm.com>
  Boris Fiuczynski <fiuczy@linux.ibm.com>
  Brian Turek <brian.turek@gmail.com>
  Bruno Haible <bruno@clisp.org>
  Chris Mayo <aklhfex@gmail.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Ehrhardt <christian.ehrhardt@canonical.com>
  Christian Kirbach <christian.kirbach@gmail.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Cole Robinson <crobinso@redhat.com>
  Collin Walling <walling@linux.ibm.com>
  Cornelia Huck <cohuck@redhat.com>
  Cédric Bosdonnat <cbosdonnat@suse.com>
  Côme Borsoi <fedora@borsoi.fr>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniel Letai <dani@letai.org.il>
  Daniel P. Berrange <berrange@redhat.com>
  Daniel P. Berrangé <berrange@redhat.com>
  Didik Supriadi <didiksupriadi41@gmail.com>
  dinglimin <dinglimin@cmss.chinamobile.com>
  Dmytro Linkin <dlinkin@nvidia.com>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Eric Farman <farman@linux.ibm.com>
  Erik Skultety <eskultet@redhat.com>
  Fabian Affolter <mail@fabian-affolter.ch>
  Fabian Freyer <fabian.freyer@physik.tu-berlin.de>
  Fabiano Fidêncio <fabiano@fidencio.org>
  Fangge Jin <fjin@redhat.com>
  Farhan Ali <alifm@linux.ibm.com>
  Fedora Weblate Translation <i18n@lists.fedoraproject.org>
  Gavi Teitz <gavi@nvidia.com>
  gongwei <gongwei@smartx.com>
  Guoyi Tu<tu.guoyi@h3c.com>
  Göran Uddeborg <goeran@uddeborg.se>
  Halil Pasic <pasic@linux.ibm.com>
  Han Han <hhan@redhat.com>
  Hao Wang <wanghao232@huawei.com>
  Hela Basa <r45xveza@pm.me>
  Helmut Grohne <helmut@subdivi.de>
  Hiroki Narukawa <hnarukaw@yahoo-corp.jp>
  Ian Wienand <iwienand@redhat.com>
  Jakob Meng <jakobmeng@web.de>
  Jamie Strandboge <jamie@canonical.com>
  Jamie Strandboge <jamie@ubuntu.com>
  Jan Kuparinen <copper_fin@hotmail.com>
  jason lee <ppark5237@gmail.com>
  Jean-Baptiste Holcroft <jean-baptiste@holcroft.fr>
  Jia Zhou <zhou.jia2@zte.com.cn>
  Jianan Gao <jgao@redhat.com>
  Jim Fehlig <jfehlig@suse.com>
  Jin Yan <jinyan12@huawei.com>
  Jinsheng Zhang <zhangjl02@inspur.com>
  Jiri Denemark <jdenemar@redhat.com>
  John Ferlan <jferlan@redhat.com>
  Jonathan Watt <jwatt@jwatt.org>
  Jonathon Jongsma <jjongsma@redhat.com>
  Julio Faracco <jcfaracco@gmail.com>
  Justin Gatzen <justin.gatzen@gmail.com>
  Ján Tomko <jtomko@redhat.com>
  Kashyap Chamarthy <kchamart@redhat.com>
  Kevin Locke <kevin@kevinlocke.name>
  Kristina Hanicova <khanicov@redhat.com>
  Laine Stump <laine@redhat.com>
  Laszlo Ersek <lersek@redhat.com>
  Lee Yarwood <lyarwood@redhat.com>
  Lei Yang <yanglei209@huawei.com>
  Liao Pingfang <liao.pingfang@zte.com.cn>
  Lin Ma <lma@suse.com>
  Lin Ma <lma@suse.de>
  Lin Ma <morecache@gmail.com>
  Liu Yiding <liuyd.fnst@fujitsu.com>
  Luke Yue <lukedyue@gmail.com>
  Luyao Zhong <luyao.zhong@intel.com>
  Marc Hartmayer <mhartmay@linux.ibm.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Markus Schade <markus.schade@hetzner.com>
  Martin Kletzander <mkletzan@redhat.com>
  Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
  Matej Cepl <mcepl@cepl.eu>
  Matt Coleman <matt@datto.com>
  Matt Coleman <mcoleman@datto.com>
  Mauro Matteo Cascella <mcascell@redhat.com>
  Meina Li <meili@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Michał Smyk <fedora@smyk.it>
  Milo Casagrande <milo@milo.name>
  Moshe Levi <moshele@nvidia.com>
  Muha Aliss <muhaaliss@gmail.com>
  Nathan <nathan95@live.it>
  Neal Gompa <ngompa13@gmail.com>
  Nick Chevsky <nchevsky@gmail.com>
  Nick Shyrokovskiy <nshyrokovskiy@gmail.com>
  Nickys Music Group <nickys.music.group@gmail.com>
  Nico Pache <npache@redhat.com>
  Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
  Olaf Hering <olaf@aepfle.de>
  Olesya Gerasimenko <gammaray@basealt.ru>
  Orion Poplawski <orion@nwra.com>
  Pany <geekpany@gmail.com>
  Patrick Magauran <patmagauran.j@gmail.com>
  Paulo de Rezende Pinatti <ppinatti@linux.ibm.com>
  Pavel Hrdina <phrdina@redhat.com>
  Peng Liang <liangpeng10@huawei.com>
  Peter Krempa <pkrempa@redhat.com>
  Pino Toscano <ptoscano@redhat.com>
  Pino Toscano <toscano.pino@tiscali.it>
  Piotr Drąg <piotrdrag@gmail.com>
  Prathamesh Chavan <pc44800@gmail.com>
  Praveen K Paladugu <prapal@linux.microsoft.com>
  Richard W.M. Jones <rjones@redhat.com>
  Ricky Tigg <ricky.tigg@gmail.com>
  Robin Lee <cheeselee@fedoraproject.org>
  Roman Bogorodskiy <bogorodskiy@gmail.com>
  Roman Bolshakov <r.bolshakov@yadro.com>
  Ryan Gahagan <rgahagan@cs.utexas.edu>
  Ryan Schmidt <git@ryandesign.com>
  Sam Hartman <hartmans@debian.org>
  Scott Shambarger <scott-libvirt@shambarger.net>
  Sebastian Mitterle <smitterl@redhat.com>
  SeongHyun Jo <caelus9536@gmail.com>
  Shalini Chellathurai Saroja <shalini@linux.ibm.com>
  Shaojun Yang <yangshaojun@phytium.com.cn>
  Shi Lei <shi_lei@massclouds.com>
  simmon <simmon@nplob.com>
  Simon Chopin <chopin.simon@gmail.com>
  Simon Gaiser <simon@invisiblethingslab.com>
  Simon Rowe <simon.rowe@nutanix.com>
  Stefan Bader <stefan.bader@canonical.com>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Berger <stefanb@linux.vnet.ibm.com>
  Stefan Hajnoczi <stefanha@gmail.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Szymon Scholz <szymonscholz@gmail.com>
  Thomas Huth <thuth@redhat.com>
  Tim Wiederhake <twiederh@redhat.com>
  Tomáš Golembiovský <tgolembi@redhat.com>
  Tomáš Janoušek <tomi@nomi.cz>
  Tuguoyi <tu.guoyi@h3c.com>
  Victor Toso <victortoso@redhat.com>
  Ville Skyttä <ville.skytta@iki.fi>
  Vinayak Kale <vkale@nvidia.com>
  Wang Xin <wangxinxin.wang@huawei.com>
  WangJian <wangjian161@huawei.com>
  Weblate <noreply@weblate.org>
  Wei Liu <liuwe@microsoft.com>
  Wei Liu <wei.liu@kernel.org>
  Wei-Chen Chen <weicche@microsoft.com>
  William Douglas <william.douglas@intel.com>
  Yalei Li <274268859@qq.com>
  Yalei Li <liyl43@chinatelecom.cn>
  Yang Fei <yangfei85@huawei.com>
  Yang Hang <yanghang44@huawei.com>
  Yanqiu Zhang <yanqzhan@redhat.com>
  Yaroslav Kargin <ykargin@virtuozzo.com>
  Yi Li <yili@winhong.com>
  Yi Wang <wang.yi59@zte.com.cn>
  Yuri Chornoivan <yurchor@ukr.net>
  Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
  zhangjl02 <zhangjl02@inspur.com>
  Zheng Chuan <zhengchuan@huawei.com>
  zhenwei pi <pizhenwei@bytedance.com>
  Zhenyu Ye <yezhenyu2@huawei.com>
  Zhenyu Zheng <zheng.zhenyu@outlook.com>
  Zhenzhong Duan <zhenzhong.duan@intel.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          fail    
 build-arm64-libvirt                                          fail    
 build-armhf-libvirt                                          fail    
 build-i386-libvirt                                           fail    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           blocked 
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-libvirt-xsm                                 blocked 
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-libvirt                                     blocked 
 test-arm64-arm64-libvirt                                     blocked 
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-libvirt-pair                                blocked 
 test-amd64-i386-libvirt-pair                                 blocked 
 test-arm64-arm64-libvirt-qcow2                               blocked 
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-libvirt-vhd                                 blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 79619 lines long.)


From xen-devel-bounces@lists.xenproject.org Sun Oct 17 16:53:04 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 17 Oct 2021 16:53:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.211605.369222 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mc9Oz-0006Rw-Qg; Sun, 17 Oct 2021 16:52:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 211605.369222; Sun, 17 Oct 2021 16:52:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mc9Oz-0006Rp-N4; Sun, 17 Oct 2021 16:52:49 +0000
Received: by outflank-mailman (input) for mailman id 211605;
 Sun, 17 Oct 2021 16:52:49 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mc9Oy-0006Rf-WB; Sun, 17 Oct 2021 16:52:49 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mc9Oy-0006Dv-QY; Sun, 17 Oct 2021 16:52:48 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mc9Oy-0005nF-DE; Sun, 17 Oct 2021 16:52:48 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mc9Oy-0001nR-Ck; Sun, 17 Oct 2021 16:52:48 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=0vDbjKf49kUVSYnJWfmEp5mFOSlnmA8CgCpmia5CPh4=; b=TiNvgKLORC6kpikHxF1pWwaIiM
	7tHsRxF2UcRiJnTbwh+yoynq1UyYvXEl4EzqX65HA+YLUYUs+TQfNdg+o/Su9kHA6TLYLEqde1yi1
	nPw9Ztk+580x3NB5/c51Km5ywk6Gx7+Z7lPevE0uljHHCH7I6mgZ6UHQ+ozN1N7+LYzw=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165584-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 165584: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    linux-linus:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=d999ade1cc86cd2951d41c11ea769cb4452c8811
X-Osstest-Versions-That:
    linux=304040fb4909f7771caf6f8e8c61dbe51c93505a
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 17 Oct 2021 16:52:48 +0000

flight 165584 linux-linus real [real]
flight 165630 linux-linus real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/165584/
http://logs.test-lab.xenproject.org/osstest/logs/165630/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 165630-retest

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-rtds     20 guest-localmigrate/x10       fail  like 165545
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 165545
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 165545
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165545
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165545
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 165545
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165545
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 165545
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 165545
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 linux                d999ade1cc86cd2951d41c11ea769cb4452c8811
baseline version:
 linux                304040fb4909f7771caf6f8e8c61dbe51c93505a

Last test of basis   165545  2021-10-16 16:43:38 Z    1 days
Testing same since   165584  2021-10-17 02:20:12 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Akilesh Kailash <akailash@google.com>
  Alexey Bayduraev <alexey.v.bayduraev@linux.intel.com>
  Andi Kleen <ak@linux.intel.com>
  Arnaldo Carvalho de Melo <acme@redhat.com>
  Biju Das <biju.das.jz@bp.renesas.com>
  Colin Ian King <colin.king@canonical.com>
  Dinh Nguyen <dinguyen@kernel.org>
  Geert Uytterhoeven <geert+renesas@glider.be>
  Greentime Hu <green.hu@gmail.com>
  Jackie Liu <liuyun01@kylinos.cn>
  Jiazi Li <jqqlijiazi@gmail.com>
  Jiazi Li <lijiazi@xiaomi.com>
  Jiri Olsa <jolsa@redhat.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Luca Weiss <luca@z3ntu.xyz>
  Masami Hiramatsu <mhiramat@kernel.org>
  Mike Rapoport <rppt@linux.ibm.com>
  Mike Snitzer <snitzer@redhat.com>
  Ming Lei <ming.lei@redhat.com>
  Namhyung Kim <namhyung@kernel.org>
  Randy Dunlap <rdunlap@infradead.org> # build-tested
  Riccardo Mancini <rickyman7@gmail.com>
  Shawn Guo <shawn.guo@linaro.org>
  Shunsuke Nakamura <nakamura.shun@fujitsu.com>
  Stephen Boyd <sboyd@kernel.org>
  Steven Rostedt (VMware) <rostedt@goodmis.org>
  Steven Rostedt <rostedt@goodmis.org>
  Vamshi K Sthambamkadi <vamshi.k.sthambamkadi@gmail.com>
  Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 fail    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     fail    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   304040fb4909..d999ade1cc86  d999ade1cc86cd2951d41c11ea769cb4452c8811 -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Sun Oct 17 19:34:10 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 17 Oct 2021 19:34:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.211639.369254 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcBus-00058N-52; Sun, 17 Oct 2021 19:33:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 211639.369254; Sun, 17 Oct 2021 19:33:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcBus-00058G-1x; Sun, 17 Oct 2021 19:33:54 +0000
Received: by outflank-mailman (input) for mailman id 211639;
 Sun, 17 Oct 2021 19:33:53 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mcBuq-000586-VX; Sun, 17 Oct 2021 19:33:52 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mcBuq-0000Qz-O8; Sun, 17 Oct 2021 19:33:52 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mcBuq-0005JR-Bk; Sun, 17 Oct 2021 19:33:52 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mcBuq-0005Vs-BF; Sun, 17 Oct 2021 19:33:52 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=DI4Q4muv3vpMRTF0LQ4WqMoiwIaWPxH0fX8UBIzE0wk=; b=tFAkXhKK0EEzNxOklDq9ioRhrW
	l3qpx/4u0h/CWLYTE0ca8Hb+3SNASeWYcScqzlEF+QZv2HmhXHVaAjbyWwKOzO1MGNB9HJN5w4WcI
	Fai/Sl//I+CMBWZxiYcQl2gyj0EtLtmrtI2DzXGSBsvbbtvvnud8fxCutpYeIVDLOxk8=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165616-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-5.4 test] 165616: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=ce061ef43f1dede7ee2bd907d2bf38402831e30d
X-Osstest-Versions-That:
    linux=940a14a7d844386c72f449045080dbbd86d1d244
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 17 Oct 2021 19:33:52 +0000

flight 165616 linux-5.4 real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165616/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 165495
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 165495
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165495
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 165495
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165495
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165495
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 165495
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 165495
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 165495
 test-armhf-armhf-xl-rtds     18 guest-start/debian.repeat    fail  like 165495
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 165495
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 165495
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 165495
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 linux                ce061ef43f1dede7ee2bd907d2bf38402831e30d
baseline version:
 linux                940a14a7d844386c72f449045080dbbd86d1d244

Last test of basis   165495  2021-10-13 13:22:26 Z    4 days
Testing same since   165616  2021-10-17 09:11:05 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Al Viro <viro@zeniv.linux.org.uk>
  Alex Deucher <alexander.deucher@amd.com>
  Colin Ian King <colin.king@canonical.com>
  David S. Miller <davem@davemloft.net>
  Finn Thain <fthain@linux-m68k.org>
  Florian Fainelli <f.fainelli@gmail.com>
  Florian Westphal <fw@strlen.de>
  Geert Uytterhoeven <geert@linux-m68k.org>
  Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  Guchun Chen <guchun.chen@amd.com>
  Guenter Roeck <linux@roeck-us.net>
  Hulk Robot <hulkrobot@huawei.com>
  Jeremy Sowden <jeremy@azazel.net>
  Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
  Jiri Kosina <jkosina@suse.cz>
  Johannes Berg <johannes.berg@intel.com>
  Jon Hunter <jonathanh@nvidia.com>
  Joshua Dickens <joshua.dickens@wacom.com>
  Joshua-Dickens <Joshua@Joshua-Dickens.com>
  Leslie Shi <Yuliang.Shi@amd.com>
  Linux Kernel Functional Testing <lkft@linaro.org>
  Martin K. Petersen <martin.petersen@oracle.com>
  Michael Schmitz <schmitzmic@gmail.com>
  Michael Wang <yun.wang@linux.alibaba.com>
  MichelleJin <shjy180909@gmail.com>
  Mizuho Mori <morimolymoly@gmail.com>
  Pablo Neira Ayuso <pablo@netfilter.org>
  Peter Zijlstra (Intel) <peterz@infradead.org>
  Peter Zijlstra <peterz@infradead.org>
  Randy Dunlap <rdunlap@infradead.org>
  Sasha Levin <sashal@kernel.org>
  Shuah Khan <skhan@linuxfoundation.org>
  Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
  Theodore Ts'o <tytso@mit.edu>
  YueHaibing <yuehaibing@huawei.com>
  Zhang Yi <yi.zhang@huawei.com>
  王贇 <yun.wang@linux.alibaba.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   940a14a7d844..ce061ef43f1d  ce061ef43f1dede7ee2bd907d2bf38402831e30d -> tested/linux-5.4


From xen-devel-bounces@lists.xenproject.org Sun Oct 17 22:14:51 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 17 Oct 2021 22:14:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.211648.369267 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcEQP-0002fP-Q2; Sun, 17 Oct 2021 22:14:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 211648.369267; Sun, 17 Oct 2021 22:14:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcEQP-0002fI-N8; Sun, 17 Oct 2021 22:14:37 +0000
Received: by outflank-mailman (input) for mailman id 211648;
 Sun, 17 Oct 2021 22:14:36 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mcEQO-0002f8-SO; Sun, 17 Oct 2021 22:14:36 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mcEQO-00036C-L2; Sun, 17 Oct 2021 22:14:36 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mcEQO-0002gU-A3; Sun, 17 Oct 2021 22:14:36 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mcEQO-0005PV-9b; Sun, 17 Oct 2021 22:14:36 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=kfd9zgC/vPj0ffHI/Rez587cJAiHsxHQH0uwEybu3gk=; b=PYOd9k7YYOVYcn0oqPh5HrpV8g
	n7pKD00GO3Ve2sYIwmztz/kRRLCCljwDhjeFFkQOuaqVvan4wgcmq6DCsOFtGP5lawAQ7oVsQbVso
	EJlz+7OTzzXgsemXUQeLMRH6Md3AHVFigtMAaJLbP/wqNXhh6FJNyMzJAiAklhQH1bio=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165629-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 165629: tolerable FAIL
X-Osstest-Failures:
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=52d0847d7c6972baa74156f14ee8544f5aba1d2d
X-Osstest-Versions-That:
    xen=52d0847d7c6972baa74156f14ee8544f5aba1d2d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 17 Oct 2021 22:14:36 +0000

flight 165629 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165629/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 165575
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 165575
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165575
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165575
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 165575
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 165575
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 165575
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 165575
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 165575
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 165575
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165575
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 165575
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  52d0847d7c6972baa74156f14ee8544f5aba1d2d
baseline version:
 xen                  52d0847d7c6972baa74156f14ee8544f5aba1d2d

Last test of basis   165629  2021-10-17 12:01:01 Z    0 days
Testing same since                          (not found)         0 attempts

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Published tested tree is already up to date.



From xen-devel-bounces@lists.xenproject.org Mon Oct 18 06:22:57 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Oct 2021 06:22:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.211660.369282 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcM2l-0006s8-0W; Mon, 18 Oct 2021 06:22:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 211660.369282; Mon, 18 Oct 2021 06:22:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcM2k-0006s0-Rm; Mon, 18 Oct 2021 06:22:42 +0000
Received: by outflank-mailman (input) for mailman id 211660;
 Mon, 18 Oct 2021 06:22:41 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=ja7B=PG=oderland.se=josef@srs-us1.protection.inumbo.net>)
 id 1mcM2j-0006ru-OU
 for xen-devel@lists.xenproject.org; Mon, 18 Oct 2021 06:22:41 +0000
Received: from office.oderland.com (unknown [91.201.60.5])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id ab01b8e4-2d93-4872-9af6-88e95917d7a6;
 Mon, 18 Oct 2021 06:22:39 +0000 (UTC)
Received: from [193.180.18.161] (port=36186 helo=[10.137.0.14])
 by office.oderland.com with esmtpsa (TLS1.2) tls
 TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2)
 (envelope-from <josef@oderland.se>)
 id 1mcM2f-00258i-1m; Mon, 18 Oct 2021 08:22:38 +0200
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ab01b8e4-2d93-4872-9af6-88e95917d7a6
Message-ID: <859dbb71-098f-07f2-f063-4874ccc8523b@oderland.se>
Date: Mon, 18 Oct 2021 08:22:32 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:93.0) Gecko/20100101
 Thunderbird/93.0
Content-Language: en-US
To: Bjorn Helgaas <bhelgaas@google.com>, linux-pci@vger.kernel.org,
 xen-devel <xen-devel@lists.xenproject.org>
Cc: Jason Andryuk <jandryuk@gmail.com>, Thomas Gleixner <tglx@linutronix.de>
From: Josef Johansson <josef@oderland.se>
Subject: [PATCH] PCI/MSI: Re-add checks for skip masking MSI-X on Xen PV
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-AntiAbuse: This header was added to track abuse, please include it with any abuse report
X-AntiAbuse: Primary Hostname - office.oderland.com
X-AntiAbuse: Original Domain - lists.xenproject.org
X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12]
X-AntiAbuse: Sender Address Domain - oderland.se
X-Get-Message-Sender-Via: office.oderland.com: authenticated_id: josjoh@oderland.se
X-Authenticated-Sender: office.oderland.com: josjoh@oderland.se

From: Josef Johansson <josef@oderland.se>


PCI/MSI: Re-add checks for skip masking MSI-X on Xen PV
    
'commit fcacdfbef5a1 ("PCI/MSI: Provide a new set of mask and unmask
functions")' introduced functions pci_msi_update_mask() and 
pci_msix_write_vector_ctrl() that were missing checks for
pci_msi_ignore_mask that existed in 'commit 446a98b19fd6 ("PCI/MSI: Use
new mask/unmask functions")'. This patch adds them back since it was
causing softlocks in amdgpu drivers under Xen.

As explained in 'commit 1a519dc7a73c ("PCI/MSI: Skip masking MSI-X
on Xen PV")', when running as Xen PV guest, masking MSI-X is a 
responsibility of the hypervisor.

Fixes: fcacdfbef5a1 ("PCI/MSI: Provide a new set of mask and unmask
functions")
Suggested-by: Jason Andryuk <jandryuk@gmail.com>
Signed-off-by: Josef Johansson <josef@oderland.se>
---

This patch solves a major issue with booting 5.15-rc1 under Xen
with amdgpu drivers. Specifically Lenovo P14s Gen 1, AMD 4750U.

The softlock below takes about ~2-3 minutes to release, and will
lock again if I switch between X and console, when staying in
X I can do things without it softlock.

I have to note that this is my first commit and PCI/MSI area is
not my area of expertise. I tried to mimic what was
obviously missing between the aforementioned commits. There may be
better ways to solve this problem, or other places to put the checks.
Should desc->msi_attrib.is_virtual be checked? It is not checked in
'commit 1a519dc7a73c ("PCI/MSI: Skip masking MSI-X on Xen PV")'

I should also note that my original problem with *flip done timeout*
inside drm during suspend/resume is not solved, but with this patch
at least the kernel boots properly.

The kernel is much more stable not running inside Xen, and much 
more stable running pci=nomsi (under Xen). Are we missing something
more regarding masking?

The error that occurs is:

kernel: ------------[ cut here ]------------
kernel: WARNING: CPU: 6 PID: 3754 at
drivers/gpu/drm/amd/amdgpu/../display/amdgp
u_dm/amdgpu_dm.c:8630 amdgpu_dm_commit_planes+0x9b4/0x9c0 [amdgpu]
kernel: Modules linked in: nf_tables nfnetlink vfat fat intel_rapl_msr wmi_bmof
intel_rapl_common pcspkr joydev uvcvideo k10temp sp5100_tco videobuf2_vmalloc vi
deobuf2_memops i2c_piix4 videobuf2_v4l2 videobuf2_common videodev mc iwlwifi thi
nkpad_acpi platform_profile ipmi_devintf ledtrig_audio ucsi_acpi cfg80211 ipmi_m
sghandler r8169 snd typec_ucsi soundcore typec rfkill wmi video amd_pmc i2c_scmi
 fuse xenfs ip_tables dm_thin_pool dm_persistent_data dm_bio_prison dm_crypt tru
sted asn1_encoder hid_multitouch amdgpu crct10dif_pclmul iommu_v2 crc32_pclmul c
rc32c_intel gpu_sched i2c_algo_bit drm_ttm_helper ttm drm_kms_helper ccp cec gha
sh_clmulni_intel sdhci_pci xhci_pci xhci_pci_renesas serio_raw cqhci drm sdhci x
hci_hcd mmc_core nvme ehci_pci ehci_hcd nvme_core xen_acpi_processor xen_privcmd
 xen_pciback xen_blkback xen_gntalloc xen_gntdev xen_evtchn uinput
kernel: CPU: 6 PID: 3754 Comm: Xorg Tainted: G   W 5.15.0-1.fc32.qubes.x86_64 #1
kernel: Hardware name: LENOVO 20Y1S02400/20Y1S02400, BIOS R1BET61W(1.30) 12/21/
2020
kernel: RIP: e030:amdgpu_dm_commit_planes+0x9b4/0x9c0 [amdgpu]
kernel: Code: 8b 45 b0 48 c7 c7 4b fc 90 c0 4c 89 55 88 8b b0 f0 03 00 00 e8 6d
cb ca ff 4c 8b 55 88 0f b6 55 ab 49 8b 72 08 e9 2b fa ff ff <0f> 0b e9 fa fe ff
ff e8 40 2f 6e c1 0f 1f 44 00 00 55 b9 27 00 00
kernel: RSP: e02b:ffffc90042d93638 EFLAGS: 00010002
kernel: RAX: ffff888110840210 RBX: 00000000000083c1 RCX: 0000000000000466
kernel: RDX: 0000000000000001 RSI: 0000000000000204 RDI: ffff888110840170
kernel: RBP: ffffc90042d936f8 R08: 0000000000000002 R09: 0000000000000001
kernel: R10: 0000000000000000 R11: ffff88810cb2e118 R12: ffff888110840210
kernel: R13: ffff88810cb2e000 R14: ffff888103d50400 R15: ffff888103bb2c00
kernel: FS:  0000718c6de4da40(0000) GS:ffff888140780000(0000)
knlGS:000000000000
0000
kernel: CS:  10000e030 DS: 0000 ES: 0000 CR0: 0000000080050033
kernel: CR2: 0000726ada294000 CR3: 0000000103f0e000 CR4: 0000000000050660
kernel: Call Trace:
kernel:  amdgpu_dm_atomic_commit_tail+0xc3e/0x1360 [amdgpu]
kernel:  commit_tail+0x94/0x130 [drm_kms_helper]
kernel:  drm_atomic_helper_commit+0x113/0x140 [drm_kms_helper]
kernel:  drm_client_modeset_commit_atomic+0x1fc/0x240 [drm]
kernel:  drm_client_modeset_commit_locked+0x53/0x80 [drm]
kernel:  drm_fb_helper_pan_display+0xdc/0x210 [drm_kms_helper]
kernel:  fb_pan_display+0x83/0x100
kernel:  fb_set_var+0x200/0x3b0
kernel:  fbcon_blank+0x186/0x280
kernel:  do_unblank_screen+0xaa/0x150
kernel:  complete_change_console+0x54/0x120
kernel:  vt_ioctl+0x31d/0x5f0
kernel:  tty_ioctl+0x312/0x780
kernel:  __x64_sys_ioctl+0x83/0xb0
kernel:  do_syscall_64+0x3b/0x90
kernel:  entry_SYSCALL_64_after_hwframe+0x44/0xae
kernel: RIP: 0033:0x718c6e33217b
kernel: Code: 0f 1e fa 48 8b 05 1d ad 0c 00 64 c7 00 26 00 00 00 48 c7 c0 ff ff
ff ff c3 66 0f 1f 44 00 00 f3 0f 1e fa b8 10 00 00 00 0f 05 <48> 3d 01 f0 ff ff
73 01 c3 48 8b 0d ed ac 0c 00 f7 d8 64 89 01 48
kernel: RSP: 002b:00007ffd5c6157c8 EFLAGS: 00000246 ORIG_RAX:
0000000000000010
kernel: RAX: ffffffffffffffda RBX: 0000000000000001 RCX: 0000718c6e33217b
kernel: RDX: 0000000000000001 RSI: 0000000000005605 RDI: 0000000000000014
kernel: RBP: 000057b9b2aa93f4 R08: 0000000000000000 R09: 0000000000000001
kernel: R10: fffffffffffff9ce R11: 0000000000000246 R12: 000057b9b2aa94b0
kernel: R13: 000057b9b2aa94a0 R14: 000057b9b2aa93f0 R15: 00007ffd5c615844
kernel: ---[ end trace 2c3e3998803422cb ]---
kernel: ------------[ cut here ]------------
kernel: WARNING: CPU: 6 PID: 3754 at
drivers/gpu/drm/amd/amdgpu/../display/amdgp
u_dm/amdgpu_dm.c:8217 prepare_flip_isr+0x64/0x70 [amdgpu]
kernel: Modules linked in: nf_tables nfnetlink vfat fat intel_rapl_msr wmi_bmof
intel_rapl_common pcspkr joydev uvcvideo k10temp sp5100_tco videobuf2_vmalloc vi
deobuf2_memops i2c_piix4 videobuf2_v4l2 videobuf2_common videodev mc iwlwifi thi
nkpad_acpi platform_profile ipmi_devintf ledtrig_audio ucsi_acpi cfg80211 ipmi_m
sghandler r8169 snd typec_ucsi soundcore typec rfkill wmi video amd_pmc i2c_scmi
 fuse xenfs ip_tables dm_thin_pool dm_persistent_data dm_bio_prison dm_crypt tru
sted asn1_encoder hid_multitouch amdgpu crct10dif_pclmul iommu_v2 crc32_pclmul c
rc32c_intel gpu_sched i2c_algo_bit drm_ttm_helper ttm drm_kms_helper ccp cec gha
sh_clmulni_intel sdhci_pci xhci_pci xhci_pci_renesas serio_raw cqhci drm sdhci x
hci_hcd mmc_core nvme ehci_pci ehci_hcd nvme_core xen_acpi_processor xen_privcmd
 xen_pciback xen_blkback xen_gntalloc xen_gntdev xen_evtchn uinput
kernel: CPU: 6 PID: 3754 Comm: Xorg Tainted: G W 5.15.0-1.fc32.qubes.x86_64 #1
kernel: Hardware name: LENOVO 20Y1S02400/20Y1S02400, BIOS R1BET61W(1.30) 12/21/
2020
kernel: RIP: e030:prepare_flip_isr+0x64/0x70 [amdgpu]
kernel: Code: 00 48 c7 80 38 01 00 00 00 00 00 00 66 90 c3 8b 97 f0 03 00 00 48
c7 c6 18 72 8d c0 48 c7 c7 90 5b a7 c0 e9 7e 6e 13 c1 0f 0b <0f> 0b eb b4 0f 1f
84 00 00 00 00 00 0f 1f 44 00 00 41 57 41 56 41
kernel: RSP: e02b:ffffc90042d93630 EFLAGS: 00010086
kernel: RAX: 0000000000000001 RBX: 00000000000083c1 RCX: 0000000000000466
kernel: RDX: 0000000000000001 RSI: 0000000000000204 RDI: ffff88810cb2e000
kernel: RBP: ffffc90042d936f8 R08: 0000000000000002 R09: 0000000000000001
kernel: R10: 0000000000000000 R11: ffff88810cb2e118 R12: ffff888110840210
kernel: R13: ffff88810cb2e000 R14: ffff888103d50400 R15: ffff888103bb2c00
kernel: FS:  0000718c6de4da40(0000) GS:ffff888140780000(0000) knlGS:000000000000
0000
kernel: CS:  10000e030 DS: 0000 ES: 0000 CR0: 0000000080050033
kernel: CR2: 0000726ada294000 CR3: 0000000103f0e000 CR4: 0000000000050660
kernel: Call Trace:
kernel:  amdgpu_dm_commit_planes+0x8bd/0x9c0 [amdgpu]
kernel:  amdgpu_dm_atomic_commit_tail+0xc3e/0x1360 [amdgpu]
kernel:  commit_tail+0x94/0x130 [drm_kms_helper]
kernel:  drm_atomic_helper_commit+0x113/0x140 [drm_kms_helper]
kernel:  drm_client_modeset_commit_atomic+0x1fc/0x240 [drm]
kernel:  drm_client_modeset_commit_locked+0x53/0x80 [drm]
kernel:  drm_fb_helper_pan_display+0xdc/0x210 [drm_kms_helper]
kernel:  fb_pan_display+0x83/0x100
kernel:  fb_set_var+0x200/0x3b0
kernel:  fbcon_blank+0x186/0x280
kernel:  do_unblank_screen+0xaa/0x150
kernel:  complete_change_console+0x54/0x120
kernel:  vt_ioctl+0x31d/0x5f0
kernel:  tty_ioctl+0x312/0x780
kernel:  __x64_sys_ioctl+0x83/0xb0
kernel:  do_syscall_64+0x3b/0x90
kernel:  entry_SYSCALL_64_after_hwframe+0x44/0xae
kernel: RIP: 0033:0x718c6e33217b
kernel: Code: 0f 1e fa 48 8b 05 1d ad 0c 00 64 c7 00 26 00 00 00 48 c7 c0 ff ff
ff ff c3 66 0f 1f 44 00 00 f3 0f 1e fa b8 10 00 00 00 0f 05 <48> 3d 01 f0 ff ff
73 01 c3 48 8b 0d ed ac 0c 00 f7 d8 64 89 01 48
kernel: RSP: 002b:00007ffd5c6157c8 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
kernel: RAX: ffffffffffffffda RBX: 0000000000000001 RCX: 0000718c6e33217b
kernel: RDX: 0000000000000001 RSI: 0000000000005605 RDI: 0000000000000014
kernel: RBP: 000057b9b2aa93f4 R08: 0000000000000000 R09: 0000000000000001
kernel: R10: fffffffffffff9ce R11: 0000000000000246 R12: 000057b9b2aa94b0
kernel: R13: 000057b9b2aa94a0 R14: 000057b9b2aa93f0 R15: 00007ffd5c615844
kernel: ---[ end trace 2c3e3998803422cc ]---

It is discussed briefly at:
https://lore.kernel.org/linux-pci/CAKf6xpvGyCKVHsvauP54=0j10fxis4XiiqBNWH+1cpkbtt_QJw@mail.gmail.com/


diff --git a/drivers/pci/msi.c b/drivers/pci/msi.c
index 0099a00af361..355b791e382f 100644
--- a/drivers/pci/msi.c
+++ b/drivers/pci/msi.c
@@ -148,6 +148,9 @@ static noinline void pci_msi_update_mask(struct msi_desc *desc, u32 clear, u32 s
 	raw_spinlock_t *lock = &desc->dev->msi_lock;
 	unsigned long flags;
 
+	if (pci_msi_ignore_mask || desc->msi_attrib.is_virtual)
+		return;
+
 	raw_spin_lock_irqsave(lock, flags);
 	desc->msi_mask &= ~clear;
 	desc->msi_mask |= set;
@@ -181,6 +184,9 @@ static void pci_msix_write_vector_ctrl(struct msi_desc *desc, u32 ctrl)
 {
 	void __iomem *desc_addr = pci_msix_desc_addr(desc);
 
+	if (pci_msi_ignore_mask || desc->msi_attrib.is_virtual)
+		return;
+
 	writel(ctrl, desc_addr + PCI_MSIX_ENTRY_VECTOR_CTRL);
 }

--
2.31.1



From xen-devel-bounces@lists.xenproject.org Mon Oct 18 06:44:01 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Oct 2021 06:44:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.211668.369293 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcMNE-0000k9-Od; Mon, 18 Oct 2021 06:43:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 211668.369293; Mon, 18 Oct 2021 06:43:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcMNE-0000k2-LL; Mon, 18 Oct 2021 06:43:52 +0000
Received: by outflank-mailman (input) for mailman id 211668;
 Mon, 18 Oct 2021 06:43:51 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=628V=PG=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mcMNC-0000jw-VL
 for xen-devel@lists.xenproject.org; Mon, 18 Oct 2021 06:43:50 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id bf6c4380-2fde-11ec-82cb-12813bfff9fa;
 Mon, 18 Oct 2021 06:43:49 +0000 (UTC)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2109.outbound.protection.outlook.com [104.47.18.109])
 (Using TLS) by relay.mimecast.com with ESMTP id
 de-mta-25-HK9oMB9zMsev9JrDuoitdw-1; Mon, 18 Oct 2021 08:43:47 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB4847.eurprd04.prod.outlook.com (2603:10a6:803:54::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.18; Mon, 18 Oct
 2021 06:43:46 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.018; Mon, 18 Oct 2021
 06:43:46 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM5PR0602CA0023.eurprd06.prod.outlook.com (2603:10a6:203:a3::33) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15 via Frontend
 Transport; Mon, 18 Oct 2021 06:43:45 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: bf6c4380-2fde-11ec-82cb-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634539428;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding;
	bh=6RTaJnDpsf+3jxyWaCH4JPBdEEWZCkOkmhH6iZy3jXA=;
	b=Ox6oqHGQ++rTXHMNRLCRt4jbAkSxpxCkrJUUaFvElUc1tleHMuFjuSEgJcGAIn1VCfp/H9
	oV4sFDDcmHY4jbmkTUOGdmZhbdtcGjNPP6bzBQX8cUAcx6lFHb2igbmUkMvt/uV1RgWo8i
	y27gfL2UjrIOXk+rGueSKH+Ta7u/FkY=
X-MC-Unique: HK9oMB9zMsev9JrDuoitdw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=jQtCReAI+ENiYmID3+qHfozYnPfMAFcXTIRQ6/r3SGzSQMA4PBI8fEb8X8ZHwk5zGI2OSFCu0l8JsZDFjNBJK3DLFjIhOq0ym+LFunKIZb1gW6FBZSm+hm0lVqkqCsHrNzWfBPuEq6YYdZXU6hqU52F77GjjgVGVwE+3VWJRIHCjRkqt3xPyIADDKVoNriWxUTjROlw2jtJtGuGlOS7Uc99sOC89Ypa+sow0Nr/n+KQ8HFHX6JDDQ46+eAG7CKNC5IFUu4d0ng54PRJ3+y6F5YuEDKmzsyYfnSoPy+3D/rdSatTbUdHzw0Uh/vQkAiU2jrw4KFx+xJrQfMsm2j0AsQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=6RTaJnDpsf+3jxyWaCH4JPBdEEWZCkOkmhH6iZy3jXA=;
 b=PIvfPttuiC/JagytyKYJ0B+qSQ2SSvlxY9W62EamaP2R6kesYhJ2f+opRZyDucwSLsv1OrL+PXuLOynsHeDcbqUm/qt0XOc3wR4zabF+4O4dhjjcv64FY9EOJS2RxlOXN/x+iQSaRZk3tzIp5weUY0oBDYHKOamzQoKeDWa8liUuuooLsramKmmOnNvb77G1LhGD4TzGY1oo2WuEz+2EH70M25zStbxbl9j+q/RqKzoQ8EtNlJRjnvl5U/LE7tCzcZ2S26cIvtosiG52zySKN1LCXyUVpkyIdaDEGSAYZxpYP46o6ViwHHADwA1oj8fNB4YNe7IEHlqFStX63g4xUA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: xen.org; dkim=none (message not signed)
 header.d=none;xen.org; dmarc=none action=none header.from=suse.com;
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Ian Jackson <iwj@xenproject.org>, Paul Durrant <paul@xen.org>
From: Jan Beulich <jbeulich@suse.com>
Subject: [PATCH] x86/HVM: correct cleanup after failed viridian_vcpu_init()
Message-ID: <55570db5-3823-8996-f69b-c2b00bcd4227@suse.com>
Date: Mon, 18 Oct 2021 08:43:46 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM5PR0602CA0023.eurprd06.prod.outlook.com
 (2603:10a6:203:a3::33) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 069c3b5b-6b75-4db9-ef3a-08d99202a22e
X-MS-TrafficTypeDiagnostic: VI1PR04MB4847:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB4847D88017B6B3C5DB9B680FB3BC9@VI1PR04MB4847.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:519;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	v6orTniFQbMASZdHuYLVDWB2Lvq/RKBoPD+oMQabJiqPOQk84v0w2aq062Myc720e4L+E5KizTaGRon6pNoTCA5c7bwsXu6DOvxNyHtmDm6dE2E9WaXwNAGwNhqH5nmCbaUl5qRxWdS3czKhvtIUDZQ+POpAvrZaCiQeZE1LIHmNqf8v87QcoT0Ym992qKhJvRFuH1kuNpCT9m2MpuupbSaxz82UqKC/T/0mhBp3X88tBRIdoopoV3f9mZw326wu5Nd30NRE/Q94v0x4znw9mD22j8MFY7vgyHHi0TpS1bDWM6hXmEjXtllBxtJz+XZMdwg2XP4n6X2t1V9qb0gQ7QyVEAsvktQZImpnlmTbMQZ/zThDjnUk1PRKJRrXEnF7OC73FIT4Da2aJgjZov9gMkEBbuvOclvsw1xr1D0nXmAkhWmGwbjhwamki/o+gjuulQBsFl+y6vfY6nSQGtAQ9ChQMxWFYQr0b7CJgOF8dtnk+czTcbInSqxPVyuvGM5nburuS7CByIV3jNp8f+4W9TFHnwe0hcFNnaEXSSpH8UQ3T58vUNqIuItpVyHuVFEdZS4sTw6uVWEfk41qTvBwpLox5xnQD7hYWwwK+yUTaRHu+EqJhhSVMobdY/1FNzKv1oSaJXbZOFhLlQALgvVc4GdcV8E4q+LxVDeoG/yq6PPLEC9k2/5XKEM7oP76hch7vyFvKtCg41x2r6/8ZG9iu9I+xGAJyQyo1yuPPEfIb60=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(86362001)(31696002)(4744005)(6916009)(54906003)(4326008)(316002)(5660300002)(8936002)(66556008)(16576012)(66946007)(2906002)(6486002)(186003)(8676002)(956004)(36756003)(2616005)(38100700002)(26005)(66476007)(31686004)(508600001)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?M3FpdlUxd3FnQ3lPYnRxdWxwQVRKZDdKZ1ZVdkNacDRqY2xCcmlvU2VibTZE?=
 =?utf-8?B?cEpGVnhKNGd3b20xUko4RUFwSzdtU3R4cXZDVXBQVDhnUVJPcWluTDBIdUVZ?=
 =?utf-8?B?OXVhUmxLNVYveUxSMUQ3OTQ2S3dvek1jeWxpOSsyMFBYZWtxeHhZcDlQNzk0?=
 =?utf-8?B?QWU3a0ZOMWV4K29veG0xNW5LSWJTbkw2aUttTXlvYkpXSStGUktXT05EVXVT?=
 =?utf-8?B?UHhmQ0k3VU40VlhMSVc4bS9ZdC8rbCtTNkZtck5hTzhyeVFBMC9CVThmLzJY?=
 =?utf-8?B?eWxPa3lTNzlDZFp1TXgzRjBxUGt5MUpybjdqdmNIN3RGaE1aOEhHYzdxalZB?=
 =?utf-8?B?dlNTK0tkczl1eC9HMFM5Z3VkQ1M2d0VucTY0amJnYkxnTmR3N3VPTitJM3ZI?=
 =?utf-8?B?OFVSZVNNd3VGWUIvYVRhNnBUQXF1OS8vVE9XYTU3UGNtTEdXVGNRQUczdWsv?=
 =?utf-8?B?cHJMbzVoLzZaUnlQMWFEYnFoVWZPeG1KVDlXaHRMM1Z4UFZWTXJlQzlneHZV?=
 =?utf-8?B?RFlzaDk0TkdadWV0RzVqNnBDMHFSWTVKamhBSVNOZElQSmYrVWJqbDEyL0VU?=
 =?utf-8?B?RzRoT0M0OWRoY0MrWU9CSFFITGpmYVo0OXJ6TG9yOVN3aVhMMi9rb0xvWU53?=
 =?utf-8?B?U1E4MkdFeDRZVVJXNnpockdiU09nTGZPOXlyekxzcGZyRk5hNWtKMDZSMmxn?=
 =?utf-8?B?TDZ0UGtxeGZkY1o3OThvU203dHFMTnRxV0pDVi95K3dDQkY1Zkh6M21HREZT?=
 =?utf-8?B?bFV5bFQ4ZUhZRGRtWitvaHhNN2hNTHBnQmdlTmgyaTdSODhzREpqUk5zOUMr?=
 =?utf-8?B?TmhBcnN2a3Q1bi93ajB5SGtpT0pRWWo1WlhQUFNLQXJIYThRd2l1L0dBeGM0?=
 =?utf-8?B?dlE4R2gyRTJxMWtZbW83TXkwbnZZU1h0S2lNQmZ2NXFRMkx1N3J3R3BxQ1Mr?=
 =?utf-8?B?VmZ3bUdFK3ppNHFKMnhhN0ZndWxoWEEyN1pLa25LK1ZsSEtFaUwrZ3lTNlBn?=
 =?utf-8?B?cEx6Ynl2OTVkZXVtOHlnVTRubkhHUFpMUkNrVStaNjVMMllDRXA2ZEd5OG1M?=
 =?utf-8?B?MkxwZDBTWkpDaVl0bmFqQVc1SHlsWFdaZDd0cFg0KzRRQ3IzelVOMG1RVWRU?=
 =?utf-8?B?WHRKVHZEUHpJL0pLRERBRzFTUjVXZ0w4Q2ViUUN3MTRRRXJuazV2TmxobFV1?=
 =?utf-8?B?RndMYVNFQkJ1UXNBTjdrcFg4S0NSbytsWkRzdVcxMHBvdWZFd3ZRWmtnUm5P?=
 =?utf-8?B?OUZPWG9INzQzNWUxQUJabTRoQnluS0xqV244NjRESFpaYUYvRCtYNFB6Mkph?=
 =?utf-8?B?N3N0aTU5ZkdNZVNvS3hFYU03QzE1dS9WNG9mYmxwdlIwanlxQ1dOT29admdU?=
 =?utf-8?B?MkROcW1XeFNzVWlmcG9QR3VXU0J2RjEzOVdWdlg1Zlpjd096UzA0SXN1bmN5?=
 =?utf-8?B?Q0RWZHRaTTlGWStDb0d2L1hZWDBNamhSYXRYQ3U0RnAwM2lXbVlwZEdyYWc4?=
 =?utf-8?B?QXNwMGU4V1Y2TUlaY2dBWXRKVFBZclhyQ05EWDJiSHZ0YVNvYytQY0FZaFFR?=
 =?utf-8?B?VW8rZXBJQ2cxU2dvZ0diMDExVEZKOHZCVTBpRUNIZ1dEL29ZTTNJeTZXMDFF?=
 =?utf-8?B?VmtoT25udUd3bGZ5L0YvbFZoQlRmbmZLZzFSVmJZMnlWbGpmZCtnMlNNdE5C?=
 =?utf-8?B?Nis4c0Z0L0dxcnZGQ3VYeVYzcmFvTG05QjJyV3plWjA3L1pEYTNJaGVCdUd6?=
 =?utf-8?Q?BkpntRsfeb7NTaLs7k5L96eOZuQSBWGN07CshWT?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 069c3b5b-6b75-4db9-ef3a-08d99202a22e
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2021 06:43:45.8870
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: DodYLGA1+0QvW5K14Fv6EWCFnkiz49eOwLOI8W2lOIDZLd+SaZ6A2r5mLo0Oje2iFzBylkHjL38hDMlRqguNGw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4847

This happens after nestedhvm_vcpu_initialise(), so its effects also need
to be undone.

Fixes: 40a4a9d72d16 ("viridian: add init hooks")
Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/arch/x86/hvm/hvm.c
+++ b/xen/arch/x86/hvm/hvm.c
@@ -1583,7 +1583,7 @@ int hvm_vcpu_initialise(struct vcpu *v)
 
     rc = viridian_vcpu_init(v);
     if ( rc )
-        goto fail5;
+        goto fail6;
 
     rc = ioreq_server_add_vcpu_all(d, v);
     if ( rc != 0 )



From xen-devel-bounces@lists.xenproject.org Mon Oct 18 06:44:53 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Oct 2021 06:44:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.211674.369304 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcMOD-0001Ij-2U; Mon, 18 Oct 2021 06:44:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 211674.369304; Mon, 18 Oct 2021 06:44:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcMOC-0001Ic-VY; Mon, 18 Oct 2021 06:44:52 +0000
Received: by outflank-mailman (input) for mailman id 211674;
 Mon, 18 Oct 2021 06:44:52 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=628V=PG=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mcMOC-0001IQ-IZ
 for xen-devel@lists.xenproject.org; Mon, 18 Oct 2021 06:44:52 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id e4b09a42-2fde-11ec-82cb-12813bfff9fa;
 Mon, 18 Oct 2021 06:44:51 +0000 (UTC)
Received: from EUR02-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur02lp2057.outbound.protection.outlook.com [104.47.4.57]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-10-FWnEhckuNryUibQ5kxIpQQ-1; Mon, 18 Oct 2021 08:44:49 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB5904.eurprd04.prod.outlook.com (2603:10a6:803:e6::29)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16; Mon, 18 Oct
 2021 06:44:48 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.018; Mon, 18 Oct 2021
 06:44:48 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM7PR04CA0015.eurprd04.prod.outlook.com (2603:10a6:20b:110::25) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16 via Frontend
 Transport; Mon, 18 Oct 2021 06:44:48 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e4b09a42-2fde-11ec-82cb-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634539490;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding;
	bh=I1lOxkcSWLuK57F6wf4bdXAcbJ7aLZKAUAaOcQ62Src=;
	b=enoLkLHVFKb5wBUqRdM310ds7U4LS0TpB3W0Q0O3UP/SLd281N1iGYQ8QvfHQt0O7mzqMY
	WaBs8jt5M05k3AOURvVfjFV0ny+16j8TL3BEcnmxyB15ULqyzAgugxlhnx4PYGJnfqlhu/
	u8w4SOaB+BCE60hQyiMGwqb6SsuTgoU=
X-MC-Unique: FWnEhckuNryUibQ5kxIpQQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=P9hgpWKG4uNpDc2ACZa9x70uGyRpLpzrUvkF1ZZiIm8yj3nPNd/xnSiTda7NSzINr+10cWTTx9u8nc7Z2bVoFXrPngD/AfQKxqBrTz/fFLiXxta3JomxXqExj3k35+b6v+uPw0YdYbsVd+nP0wCSu+Pg4DKZymZkh0oLO4aLG6Qa/rooLbtqyBs5JzwXbflzDj3OKnyEVcAL9+2E8tK4/X11n4wQXlACuniwoj6GW5ynZAji38LST44FqUpOH/sZGU4V7BoWyg4dmuEJh3qnDIhbaa5CkopkAq7KdB4V0MHfvC71H/dQVDpBKyu2PBMVSZV/OLfTAjAlyOA5nnuP2Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=I1lOxkcSWLuK57F6wf4bdXAcbJ7aLZKAUAaOcQ62Src=;
 b=LwUrEp0Pb/AXjkNuP15rnyp3HwuDNI0nMTyX++IQWtn4Z3nDE8u8oTOHUMDTBLiDxjBuhJL0CAvRM6P6O8v5K+5udRatmCwdGloJmeKgrDcMJcl9pYnYJZCO0jya0j3KUt8c2bePCrypDtiePJwf5i9Gkail9Lr6iHHiWN8wwOzzzGKGmr0BLkUiIgeq149MQ/fh6IWDn6KnVkPZkgbP/lUtqh3jmQvHGCkMeJjt7CfAAriyP2hzcMMObp0v+mklK8kmypuCBjuDJf/uMMyoG7Yl6GMHQJBYMNApUO8pZN9NX9XmUBrnYc1K4gIirXddI72AslhHuRXqh7wYEKHvAw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: citrix.com; dkim=none (message not signed)
 header.d=none;citrix.com; dmarc=none action=none header.from=suse.com;
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Ian Jackson <iwj@xenproject.org>, Tim Deegan <tim@xen.org>,
 George Dunlap <george.dunlap@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
Subject: [PATCH] x86/shadow: make a local variable in sh_page_fault() HVM-only
Message-ID: <e469f3d3-ec0b-fce9-5fdb-5939970fdc6e@suse.com>
Date: Mon, 18 Oct 2021 08:44:49 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM7PR04CA0015.eurprd04.prod.outlook.com
 (2603:10a6:20b:110::25) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 6aa6dad9-3041-4868-c4c1-08d99202c793
X-MS-TrafficTypeDiagnostic: VI1PR04MB5904:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB590481AC84D997FE12A45233B3BC9@VI1PR04MB5904.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:576;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	wG/KfxkwbjME48e/mPkaNDfE+x4wcHUj1bLKXywAdIC6yGA7rjniKIV7EdJuDN66Fbrov6rYGY+uX5bp1lXlu/QYu/f6lOYLGouXZjBzRzseA6mBgt6ngTa1qdQwiDZBryK9O6EIzbKwp9uXXfUYw1aY0yF7ijTS4x8VFKtoWaZmbQ5ageK6+vrPEG5h0SuIxXk1b/U3ok8BJmwm4zUdSvjKxKGMS5F/KSt70ox6iMqz776z6b5Ng8P5NLvFt5NjVlEccKPjpQAe9lKW4IZ7DR5HNnohJIbVsmC74H/Ehr6BoyT6oBvcotX0LGIYh+PUz8YOWHiTTNAcAfMFN6HYHs1haGIh5lk7neTmqOMQi4AYvK8KcAeeU/c11nCJO9DWIfk3ot5mh7MhN8u+RFcoG0a30rnMuBe4Iy4uN39RNCYZf5Z1hilfwaO2+qggcNUUGai2m27sBKfnHavvutqXrLCW10TSwMwg1GJCHfBYAwqnAOVHqYsic9e5O6s7Y8llGlVItOLSze/BEiKZhLBgAuQUYOXkdUwgkTBTuP+aUellMvz6jLbNs5Fupd5BqGheJfi/JiP4Yl4TjIy71lBxeen3JIQpvW3/vYvSAZygJ4Sw4gH6dRZ/qeLVdY2e9T/a+NmxNa1MVY/jpAzmV1UBbnoBMw2HXluN36I5QnObxyB0+tju6qE2vyVbedUg4Jnz1swaiJJVNL/77PyIcyG/rTlUg4nfr4AOeZ6tsMMBmiw=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(956004)(6916009)(4326008)(2616005)(16576012)(4744005)(54906003)(316002)(66476007)(66556008)(8676002)(86362001)(36756003)(66946007)(508600001)(5660300002)(8936002)(26005)(6486002)(2906002)(38100700002)(186003)(31696002)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?ajNpc3Z3SzY1dk5saUVJeVNHU3ZVVC9PRTd2NzZGdklPbENoNnRFSzhQWWRH?=
 =?utf-8?B?amVXRmt4VUVseG4wcE1qeDB2U2toNGxFeUNlekxEOTJ2N3hldFJaTjZ5Zmlo?=
 =?utf-8?B?WjJScXQ3bkpXVk9KK3FWS3Jxc3VJZTRqZGh3RlBPK0FseTVjN2JHR25UT0JC?=
 =?utf-8?B?K3lqV2FadU1KampTK2o1NmFLVjIzbXBTRzd0dGtXbVVXczB4NGZxRUdkUHI1?=
 =?utf-8?B?aVNoSHZ0LzJyVk9ucjh1UndEZjZ2Ylk0dFI2RFBOb1AwbENVbDM4cFBoSytZ?=
 =?utf-8?B?aFhGRDJOV3duMHJldHlDUGdFTytCeWRrOGxOMVpSMzBBOU9xaE1wRkxMMWRB?=
 =?utf-8?B?RG1ubTArWmlsOXhJVmJ5Zi9vSHRrTkRwZGZ6MVlKL3RDTzlrcHEzQi9scUVx?=
 =?utf-8?B?TzBvak5sUGdCSmxxYzNSMStlY2lKRmIzOUJCZGRyTXk4dDhMUXRDUnFRTlB6?=
 =?utf-8?B?K1J5WHYvYkdPcXhCNE1GWm5sRkliY3NCL3RBOEszS2h0NEdlK25iQzVRVjBs?=
 =?utf-8?B?SWRNK1dYL2JaQ05vdDM0aDdWcHdUVEw1R2tCdENVSE1tK2JqSEprT0Q5Smsy?=
 =?utf-8?B?M1p2NmRKSzVOeXdUbkNOMURrNFB5NGttc2Y3OVRKaEJsQ2hvVUtHckQ5a05o?=
 =?utf-8?B?WHZXQXo3Zkt2eXZJN240dGxyWXVGQ3VpTjVwV1YwczREdGsvTkYrZTZZZEN1?=
 =?utf-8?B?Q0dxU1FibnRrbjRJVmNHcVJFZ1JoaVhrQnhvVXRuR0NGY3pqWS83WktGd0xv?=
 =?utf-8?B?Vk5BY1o5NWZoRUxyT3JSNWhlRDZ4aE1MdHJpblZkVFhYcVF6SEhEeEJUNUha?=
 =?utf-8?B?R2Ewc1h5cUtxMmY3ZmptRm5hVFp2clpnRXRJVU52bThyejcrZzMxWFROVzVl?=
 =?utf-8?B?Rm02UWMxWEVLMDN2cjA4TmMwZmtOU0tISk5QRCtJWWVXK2N4L2ZsV2hmS1hB?=
 =?utf-8?B?a1ZCMzkySmV0RmRuVVgyTHZGVElwWnZpWFBSZlQ5YTdUcGtjNFZ6aFN4Zndy?=
 =?utf-8?B?ZHBZeDlZYnp5YXZUK3JvZGpkdWVNbXpyc292enpMVFFoMjR5OVc4NE1kY1Jo?=
 =?utf-8?B?WlVXK1g2WXh1VCs3Q2lId3pYeGZYckVTVU5GZGNXaEpUMlM0bS9lbG8yRThr?=
 =?utf-8?B?WmljN0h4TFRVeUUzbkhtNFR5ZEwwVThveDdTK2RSdWtTcWswR3hxUXgrZDFp?=
 =?utf-8?B?R2VxcURNdXVoVHFmcldpTW1mL2lsVE1FUDdBR1kzZ1B3Q3M2aXdEQkFuaHlY?=
 =?utf-8?B?cjh5cVJkenRST2JndWQwdmlvZDFDMnl6ajR1RnlQRUE4T1JpeHJYdlZ0djgw?=
 =?utf-8?B?VWFZZGg5eGF2SGRtR0JqYVRSd1hPKzJtZDc1b3Zrc012VEw2d214YUpaQVI1?=
 =?utf-8?B?UStMMDFVVEtZajB5NXhVTUVGK2M4SnBPTGNwa1YzWkJhalUvNmNkSnZtYnZO?=
 =?utf-8?B?dlpiZGUyRnVhWGxMRWtnY3RCTEdaUU9pYW5LeE56Q2Jma1pORjg3SjlBRUhQ?=
 =?utf-8?B?RDVJTFFsUDhUeXJmZnFnRTdTUU5zV1FEeFNRdVhsOU80bG43UkY2UkRUREdL?=
 =?utf-8?B?Ulo0OXBHblZ5UnN6dGQ5Z2R6YzI1Z1U5TzN1b0tZdkxJQWFvemgzdUcrRUla?=
 =?utf-8?B?MHlWM2Z2bmgyZ01LVUg0TSttZzlGY0QvNStwQmg1Vm5QYkZYNVVkdVBhWVhv?=
 =?utf-8?B?YjgvWVpJdFhvM0tVMlI0SUZVeW5JdFB5UW02d01UWUdKaExETHFCN2RnVnd3?=
 =?utf-8?Q?NpVoDGfC4mOm+oCmL0TSVQw6P7KPr7SytP3DrOe?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6aa6dad9-3041-4868-c4c1-08d99202c793
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2021 06:44:48.6135
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0P9XNtzRvmu7lMmGimtTDYj7ep/nbgWwcrJhuQoUryO+NcHzpwpU58s0sEX8jYcFrDChT4hKK2oodpMhBOVjfg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5904

I recall checking that "r" would still have a user, but when doing so I
failed to recognize that all uses are inside a CONFIG_HVM conditional
section.

Fixes: 9f4f20b27b07 ("x86/shadow: adjust some shadow_set_l<N>e() callers")
Reported-by: Stefano Stabellini <sstabellini@kernel.org>
Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/arch/x86/mm/shadow/multi.c
+++ b/xen/arch/x86/mm/shadow/multi.c
@@ -2155,8 +2155,8 @@ static int sh_page_fault(struct vcpu *v,
 #ifdef CONFIG_HVM
     struct sh_emulate_ctxt emul_ctxt;
     const struct x86_emulate_ops *emul_ops;
-#endif
     int r;
+#endif
     p2m_type_t p2mt;
     uint32_t rc, error_code;
     bool walk_ok;



From xen-devel-bounces@lists.xenproject.org Mon Oct 18 06:45:58 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Oct 2021 06:45:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.211684.369315 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcMPF-000202-J6; Mon, 18 Oct 2021 06:45:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 211684.369315; Mon, 18 Oct 2021 06:45:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcMPF-0001zv-EQ; Mon, 18 Oct 2021 06:45:57 +0000
Received: by outflank-mailman (input) for mailman id 211684;
 Mon, 18 Oct 2021 06:45:56 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=628V=PG=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mcMPE-0001zh-9e
 for xen-devel@lists.xenproject.org; Mon, 18 Oct 2021 06:45:56 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 0a84e003-2fdf-11ec-82cb-12813bfff9fa;
 Mon, 18 Oct 2021 06:45:55 +0000 (UTC)
Received: from EUR02-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur02lp2053.outbound.protection.outlook.com [104.47.4.53]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-20-Xk_fhSXmNV6dwJM9kltYcQ-1; Mon, 18 Oct 2021 08:45:53 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB5904.eurprd04.prod.outlook.com (2603:10a6:803:e6::29)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16; Mon, 18 Oct
 2021 06:45:52 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.018; Mon, 18 Oct 2021
 06:45:52 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6P192CA0023.EURP192.PROD.OUTLOOK.COM (2603:10a6:209:83::36) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.16 via Frontend Transport; Mon, 18 Oct 2021 06:45:51 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0a84e003-2fdf-11ec-82cb-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634539554;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=RlER8m9Nr8SjdDh7HKYWVOMKLjwOc+9imsjBzvXOd4c=;
	b=CdHpiayCIiL+dPVb4IcEH7OsjkbsbSK9ABRqBEymsO3OWx0dr7yYO0ypolP1z7ylrcALJE
	a5Q0FP+AscZVsqrUvRnFLVH8CF3iEVT+AKwubmvoL5GbaQ7tKTBAXuSu0mYJbi3PoIkQpu
	03hxzyNcrjAhPsTOnD5ddLX60jVG+J4=
X-MC-Unique: Xk_fhSXmNV6dwJM9kltYcQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=MFd+iqF78o9/dNaXhYQVmAin3h/xyxWd8+c5Fz9p0iJaBEPhIFINmi3mtKeHlBUFvz3/nB3OvZ5ESZB77ADi2TjLctrzLgCu1RgjP9U7NvnAgPZkE9YaAyuJyiABROwa0uQ/0eE0YuGfguBcSyP5FNDExTqYTRh3c7tGCKgoeMd5CfwNnhTOAc59BpaFgMJz/ZHVveO9l5pViWbpTlogEiem5WNYY1N80pXXmixre4T/5m+ottjnZoC+DV165E2AQL1SymT3fpN8cTOeHXGxSN5MlwnchtE2t27mw3Qmkg1HoCWh14bSQSE/IevJUOgfOg0LYmUb7XGcciyb1MvoSA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=RlER8m9Nr8SjdDh7HKYWVOMKLjwOc+9imsjBzvXOd4c=;
 b=L9cJ3mk3t+laHGLAz0IuRz0x/94bYgWXoFJPsVMh4cXCHtn/czkJQMv00f1oTcvhjwlYBwsQG3ORRti2f2DeK/3YS4xF2Blu9PI1fIdA8w8p7qcoftihFBYC3K7JQ0rUP9YuBMigqFXH42K8QTOXKBSiB2oErYqBpjrTKoXDvf8BHbZEzVdpubB5uZ9dBzfreONbreHCIn7p5G4xEqxhc3seWKtVUOfDgVV6cnKJr8L8H2bZYdlyjMZ8wDYM5LhFH1ZRDpcyo9QPj5TdB9bgtoOcbCJuCdclnk9mEE+uYJRy+j9w9mXlRQDCEt00Ys/Y3r98eA2wV/8/3W5eADV3aQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: xenproject.org; dkim=none (message not signed)
 header.d=none;xenproject.org; dmarc=none action=none header.from=suse.com;
Subject: Re: [PATCH 1/2] x86/shadow: adjust some shadow_set_l<N>e() callers
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Tim Deegan <tim@xen.org>, George Dunlap <george.dunlap@citrix.com>,
 iwj@xenproject.org
References: <24329000-06d7-2047-b0a1-51b149d19189@suse.com>
 <298846aa-f93f-4564-dbf4-4f893df8f328@suse.com>
 <alpine.DEB.2.21.2110151554450.31303@sstabellini-ThinkPad-T480s>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <8cec9f3c-ab3f-2729-cf5d-faf8786b33b6@suse.com>
Date: Mon, 18 Oct 2021 08:45:53 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <alpine.DEB.2.21.2110151554450.31303@sstabellini-ThinkPad-T480s>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P192CA0023.EURP192.PROD.OUTLOOK.COM
 (2603:10a6:209:83::36) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 4b76b904-b57a-4181-abdb-08d99202ed73
X-MS-TrafficTypeDiagnostic: VI1PR04MB5904:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB5904E9B75CCAC61AF06F5CBEB3BC9@VI1PR04MB5904.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:1332;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	E/tp7K0xhM33ZrBpMHGMt7hHrpKsnsDE5FP48TU5q1Tvxq+Vzf1YinMnw0x2pYVlEfYJLeua0aLfryViH2XjgC9JYG22isyGrFXpY2S6vJMPda8bzT1TPSda+ZMqeTkBocyie6gUuB4Wcd04OEm97xpPzHA+gAu9qOrGGf3O1aaLe/YciFwLKkdQMNKBoiRxsukpoVzfLjub+vmCOKeLs33Pw+0l0bxndnvoPIFVjRtE7zr0U6CafI2JizoJd1DHa6GnXwvuqBlym75hdg9jgHKn0lyqpe9QJxoTse74Fdk2KMFfCWKMiicrjC6rSMAZ2PS9OSVoe1lg2LGw8M6FYI+r+wUFQdxjw6VKmm+whO+vnbiqvf/+gm7KcCKxzHcBt+pLatXOvnjvzhePeV8Iz+cvx3S/wP37A7s/xu0Zf1dY7Lv6Or8J+mfJV5YOop5A3oP+x5Jaoq/gNd7b2bHdkydAf2TrkV0ZK/0Oih86QqOrgJahwbT7vBYIbL499LB14mRNxlzBY5Wbt8Qly6QVtkJiGqsl8MQrP6IPrbk3Htm/EihCy/7CNHXfDlRgIrCfR4Pr5F8MNBYBx2+rOczcsV+JUZjymaAyxjw988rHrQ7xppHvxCCf1hsf8xtYuWpBfhPO5K+cl6lw0ezbFx/kRd3unvFxC+gDaY2aCGtI1omU24BqjLfEAb7wexbrQIRD9RckEyEnkaCBrZT2yNPLeHepV2N/quXbMJ9SIC25kvzKK+UdgCh22M0fG3IBZ0mMVL3J5PMJMk8gN0cYRJ9jXW6+VCcJo7Q0OKMmVpBPFfGE+DhwZP9BPy7UeYJaBpvc
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(956004)(6916009)(4326008)(2616005)(16576012)(4744005)(54906003)(316002)(66476007)(66556008)(8676002)(86362001)(36756003)(66946007)(508600001)(53546011)(5660300002)(8936002)(26005)(966005)(6486002)(2906002)(38100700002)(186003)(31696002)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?aVZ1aFB0VUxGVGxNUCtQdy9VVjNzSnhOekFPN1BNNjdWOUlaWHlLOTYxNzRt?=
 =?utf-8?B?cE9KRDhiZGhZTU5IMFNQdFU0UkxxMDExaWhwNDZwSndRNndhYllXQTNMa1dO?=
 =?utf-8?B?K213eEd6SGpBVmtrYXFUWEJnSWdNQ01uTWhodlFQZDMvdlM5dDVRc1FBb1lR?=
 =?utf-8?B?OXR5RmVhcDEvWUpDTUQ4bmMrRWhycDQwaWhsc2VmVTN0cGJFaGVPSlk3VW8y?=
 =?utf-8?B?OURIbVd6VUhUbDVJdjRwcmtnMmxXNDhMcVpobThWSjNIQnFYWXpKZHQySis5?=
 =?utf-8?B?M01MVkV1VWRsd0EyRTNZZVQrVDlRRG9nUFdJVHI3bGQ4d3hMay8wOWZxN3dt?=
 =?utf-8?B?NnBRK3NISnIwR2dUd0tna0xLd0d4VWY0K2FXVXpPRjhXcldJUXlSWEUwOUFa?=
 =?utf-8?B?ek8rVmpWM1JwS1haVndUU0lVbGFoOEFQZ0RnVlFLSHVzTyt2RmFXb1pCb1Ev?=
 =?utf-8?B?VTk2R1ZoS1B1VzdNVkJJbkNZcVgveno2cEpDRlhmdVBNYTJmb0NDVnczcmZl?=
 =?utf-8?B?Vkxtb096aVZYZmJuZDZWQVVFYmNxOEF0WjBoTHV1V2hxY2daQ05qblVwNDYv?=
 =?utf-8?B?NDl1VW1hR0RXbnl1TDR0eXM1Q01IUVJTZ1lnM0NrZ0huajRRWE0zR1BRSGVu?=
 =?utf-8?B?b2UrVGZzbE01WUN2VjNubzZqbitjSjNXSngvYVJjNHJDaHZLN1dadTZUU2Fo?=
 =?utf-8?B?eTdCZTFLTEpRT1VocGlUMXRvUHJPVUpQaTFoZDJLNHY5cXZhOHkzWGZ2bjVT?=
 =?utf-8?B?NVVIUFJOTUo4L2RiMmF4M01iV01Kb01tWmVRKzFIL1N3UnI3ZUNBejNYVlc5?=
 =?utf-8?B?V0JGeFIvRmZCNnAxZ2tNYy9wN0tIeGZQNGZMY05lYlVQeWxtWmpYbWtPWUxi?=
 =?utf-8?B?YjZieVNHWGIvUW9XdlVoNkVWYzh5eDRNM2g2ZEJEZG90cE42L2h1OUhVU0Nz?=
 =?utf-8?B?Q2QzN3lGWGNqS1BLVkNsNmZWNVVjNWZ5bnl5QUNITlRRbHdoUVNBZE1rUFNN?=
 =?utf-8?B?aWV6UW9HT2ZITEFqZkxrRjdwOU8yb3ZKd1ZNOVZYTy8vbVBocjB4ZUwrUmU0?=
 =?utf-8?B?L0pXUjhyRi9wK0gxNUgrM3VjYXNhUmtJeEk2bFVPT1dQWnJEOXRHNFFVTVBh?=
 =?utf-8?B?OG1JN2FieU9QVERyaDF2Z0lYay9IbENjOVZSSm9VdkEvRDhVaWU1eFoxTnJv?=
 =?utf-8?B?NHkzSWJ1M3BCZFVDck9mYkZXMWlXamZjZnVzZEVLdXNINVRPVTBPd2d0MUlE?=
 =?utf-8?B?SllRcEp2Mnh6WlJWdFlPTnpVSjVpTXpHSDNRSUFoRHJMNjBlck1wZTFma1pw?=
 =?utf-8?B?ZEF0bG40M3FTQ0s0aUV0b2pXVHlIL0U1a0szNGhVNVBuMndOS3RLekh2RnNR?=
 =?utf-8?B?T2Y4UnN2NzY2WWlReGNDK0lsZjdNU2lXTnNMSXQ1QlZhRk0zcmRBbzlKWnBC?=
 =?utf-8?B?bDJpQ3pkUVNidHdocllkaXNRQ09VN20xUjhMeGxSWTUrUWs3bEkzNlZpc2xC?=
 =?utf-8?B?S050VFdpY3Y3MWdRazJFWDhFUnYyL1A3aC9vYi80MW1qaHA5ZmJUNHN4a3FG?=
 =?utf-8?B?Sk56NjlXZDlBNFVzVURJRVBwa2Q5a3o4YzFYMnA5VG5xRC9ROWVjNnRId2lr?=
 =?utf-8?B?REM5Rm1EZEZJL003YWgyU0pXaGxjamluUnNLVnQ5WXBEYjM1L0xaTHRhVzZ3?=
 =?utf-8?B?V3JIaHUzYkJlSkV1bU41bDdMTWdjSEljSE8wV1RtWThEbFR3WElnMmRuY2hw?=
 =?utf-8?Q?gtow/APLkMKss1Q1lQcTKhmMWjyujR7/62hAhUZ?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4b76b904-b57a-4181-abdb-08d99202ed73
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2021 06:45:52.1776
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: D3uMyyfmhY0nCyUjNmoya5GGv16fht0Vma7vlHXkiaZxpagDiW2WjXIGPyY/HGMDuxvdpkqUvACwK6h7y7jUSQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5904

On 16.10.2021 00:55, Stefano Stabellini wrote:
> This patch broke gitlab-ci:
> 
> https://gitlab.com/xen-project/people/sstabellini/xen/-/jobs/1684530258
> 
> In file included from guest_4.c:2:
> ./multi.c:2159:9: error: unused variable 'r' [-Werror,-Wunused-variable]
>     int r;
>         ^
> 1 error generated.
> make[5]: *** [/builds/xen-project/people/sstabellini/xen/xen/Rules.mk:197: guest_4.o] Error 1

Oh, indeed, that variable is now only when CONFIG_HVM. Fix sent.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Oct 18 07:01:22 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Oct 2021 07:01:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.211694.369326 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcMe4-0004MG-R5; Mon, 18 Oct 2021 07:01:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 211694.369326; Mon, 18 Oct 2021 07:01:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcMe4-0004M9-NV; Mon, 18 Oct 2021 07:01:16 +0000
Received: by outflank-mailman (input) for mailman id 211694;
 Mon, 18 Oct 2021 07:01:15 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=628V=PG=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mcMe3-0004M3-JO
 for xen-devel@lists.xenproject.org; Mon, 18 Oct 2021 07:01:15 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id d51ade07-c6e0-4207-8ede-d6f18a8d5344;
 Mon, 18 Oct 2021 07:01:14 +0000 (UTC)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2056.outbound.protection.outlook.com [104.47.13.56]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-15-UNTXLoBQO9yOMGEOXgnL5A-1; Mon, 18 Oct 2021 09:01:12 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB4608.eurprd04.prod.outlook.com (2603:10a6:803:72::24)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.25; Mon, 18 Oct
 2021 07:01:10 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.018; Mon, 18 Oct 2021
 07:01:10 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6PR0502CA0067.eurprd05.prod.outlook.com (2603:10a6:20b:56::44) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16 via Frontend
 Transport; Mon, 18 Oct 2021 07:01:10 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d51ade07-c6e0-4207-8ede-d6f18a8d5344
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634540473;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=aEW+RFKkCN8E47hLxhAvmBp6BRV0oVmK/rIjpI4iU3c=;
	b=fCL1P8Ec0MaYsj+jo038eo2+vw8Z+/LdsJyTW/dszvVUZdPrStQ5oPK91uOGg/NaIhbSm6
	eDp3Dg4r8ndEIT08H5ynrksLZpOMwl6IILbraZFROdQaHRD8D+czi0d1O9MMH9MM1E8eBd
	aVb+aMIq3Cqy1R4hkyv8VHMlsoPhOWM=
X-MC-Unique: UNTXLoBQO9yOMGEOXgnL5A-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=UpcHexVSPjMJJo0wth+MwOy2JPh6nkq1zIPkKORCgP5suVLIUM2tmxUq1f5kBTN+Q9J0+3dNlu8Im+WFQyNLZuVjbKoq6gp+X/VvFsdHUwfyccCd8qZDnyjCVpUHUAbcxZiZeKrQXF8cNZl+kDeyFZ5mnlmJcIjHN43b94e8j4WRkKr6LardMndzEyNGFB9oPzQMz0ha39AzuayxfKt4xD7+j9YYem9KhyMzfE6JTTViNEPfjEpaRRyXEy5AS2zRWzpj679VS0Bj1zYVjGDjYnZ84QBOxREo8wVsvPBePmPG1haB4ytiUCb5V+V+Vju8iDpBZZ0XFmAgQWk+vblD4g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=aEW+RFKkCN8E47hLxhAvmBp6BRV0oVmK/rIjpI4iU3c=;
 b=gnzj5xr5yAg4GR8vfHiDmlhxft6zsE+SZ6Qz2rds97ikZP0D7JMS6AucXDhuI/PBCKSyiUD5wFD1ZhcukfrnarDz7+7YCFiouVDOrGXyCAve7qEHLVDfpBBo/uuuNBA47f1BKnVH6WKG+DenQhSVJedOoN+X4+A9CR4d0/ljhBtlrBgoKAX8g2LB8sot5z7vA4Nr9uUryF2DnQkzrbMU/hEOqJWpaCQGadox6j46LxHN+D36bfUoJHpveunEKGQMjMavt4gz7EQ96GXjj0/i9O+A59OKJbZrkZgYGw3Bk/Ak4d9nLGmc9l1CwNZqWImDc/tH2Yk6L214nm/ba31v/Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [xen-unstable test] 165539: regressions - FAIL
To: osstest service owner <osstest-admin@xenproject.org>
References: <osstest-165539-mainreport@xen.org>
Cc: xen-devel@lists.xenproject.org
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <c19e4ae5-7b2a-3b3b-f556-b2d1bf5918df@suse.com>
Date: Mon, 18 Oct 2021 09:01:11 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <osstest-165539-mainreport@xen.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR0502CA0067.eurprd05.prod.outlook.com
 (2603:10a6:20b:56::44) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 9201d3d3-426f-4f67-10fd-08d9920510d9
X-MS-TrafficTypeDiagnostic: VI1PR04MB4608:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB460821731810B4291CF77190B3BC9@VI1PR04MB4608.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	hbE1ilSQkx9wdVrKmiuHbhu69g+TqxYkupwmQIbuTrDbfRq4vgVT0zTMXnucQU9l8H0+mdNweKTXlQ8dI6DZGzIrSRC3f0LaIMphA/e6jfY4NgGchhuiYzElg7zlXJ6TzumvQErWW/GYfi4coBuBCaf9ke5LO2LjcXQ3AciNV/opUxhqrZAiuHaToWYgdVflJTfxkB3m6paWXOFJ/442hfy/KrDLZ3WEo4xs4FAKTk9ZjeL7OiqBpd6n/YiqemrQkhxaSipjDpHC6rhaMbQtKuUmna+9F6lMlzH/H/5f6Hr+EJrMPgk8VCX3RzDdkV05FjOaT62+njJaG5cSt+AImZahjBIk1nhaOkJZpvzVtliMmE6zA3JH0ja1/srCT+Kg4jjt/jktEWl0E4yti1gyn3Hwr9jrpKhW0dzcbhqF5TvkrGium7E1HpsswbboWB34zIYeTZkITtnQ8Rjgu97HGd6zpA6WS+hWqqAQ7F0qalMbhrs90jTAzuDwqBpUleckefAe9TiZYNnF74+4+bXMbqRYPA7Leh5KmwpRv2ZqoLIEnel1ZeIyddp4x2pQfn9dG/xildyno7OvFUD38k3udOvQ3z96+uPTapGLbVVNBgYIIl+E1dXTJf2Bd7DIkjUc79PQR5+0rPtUh+owMZdVNMWRpl86ddpQj4KVt3z9PArl5NiEkmW4lwf+2mF0QqT+Hz9PmBsCRWqKOOzC0BwIRi/egVYSKS4D4gs6r91zoRSrEY6/+wWs2tVTLoR0bQLC5C+XKwlksJsGFUIow90YypHxW6IPgcPiaR47Mw6O/4/9ZW76fN3Xd/68f2Yz+v7I
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(66946007)(66476007)(66556008)(6916009)(4326008)(5660300002)(26005)(83380400001)(86362001)(2616005)(956004)(31696002)(31686004)(38100700002)(6486002)(966005)(53546011)(186003)(16576012)(8676002)(508600001)(316002)(2906002)(8936002)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?ZTBmRkdlNTNDbWlHM1dKMDZONHhkQ2Z1RXpQVWI2ZTkrWVVUdTZjbnpQTDZI?=
 =?utf-8?B?bVRRVkNsZ3R3SXdITUN1ME5rOHNUV2pnL1NFS0hlOWN3aDJCSEpienJieVg1?=
 =?utf-8?B?elNOTFlQaEdjeC9VQWtiVEhvbUEvNVQ5MDBRcjYxMlhWb0NES1dRSmczUzNy?=
 =?utf-8?B?bUpoWEQvckUrc2p1N2dzOGI0RHIxQUE1ejVmWEpLd1BqVkZkOW05d0QrMkVQ?=
 =?utf-8?B?d2RCS1VodVZEanZjdTdtMTdOK2lKeVBJMFJtSER2NnF6alhwTG9zMm1yYlZR?=
 =?utf-8?B?a3AzU0g2YUJpN0s2TUhES2dJbFBwUW9zRmovem1TcHJ4TkFrWkFSMXpLY2ht?=
 =?utf-8?B?R0F5T29hYkxiSzlZNzNXZEVIWS9VK1ZsYXFPWVdpTDVJL0ZMcHNBM0VuaXVR?=
 =?utf-8?B?UnJKTmpidmMyeDI5TTJIblJsYTJMdmczckFUVGZOUmp2TXJ3clY2VFpyaGI2?=
 =?utf-8?B?TUNnN3FUdnkwTmJtREFiQk1uOU1HdHQreHVjb0xBVEVoenlZazYyaDdwT3Jm?=
 =?utf-8?B?YUI4UkhDaW94YjFDRDdQMTRqY0FGV0JubWVPNnBiSnZNY3RVYjFKeFN2Wmc1?=
 =?utf-8?B?N2lIOFIzdEJzckptZXIrWE1QeDVSejQzOWtjbVRmTkJGdW5WTkFQbGREZERw?=
 =?utf-8?B?RDJvK2RMdG9RaGdCSmR1dElhZ2N1TEdTODdoMHZPakxFRzFvYkhhWTFZdHBJ?=
 =?utf-8?B?WEk5UXkwbEorcjIwT0xCcmE2cGQwcUk5bW9qWTIyeVA4Sno0VUlNRmthMzJR?=
 =?utf-8?B?bC9QUWlOa2dFeXZHaXdPNWFnODdwY2JweEhZZ0tHSUxRTC95MndxMUtwclhG?=
 =?utf-8?B?ZVgxWFR4TWszZ05OVEJPQ0V0UUlKeTFnMGRZNnBuQTFFNzdNMENRT3hQM25a?=
 =?utf-8?B?dW54N0ZnemdBbGQ2Q1NMWE9LODIwQ2g3NFZSTjVxQjc1RFY2dXBvbWZja29w?=
 =?utf-8?B?ek1kODZnNVdqVGY0VzBrWlV3K1FvaDR4b2RkbHk1ZjJaemVMMWtvMnU4OXhB?=
 =?utf-8?B?NHF0azMzZ0NGNy9qckxrZU5zdXA5bzl0NXg3S2FLdzg4SWZPNlFKSE5FclFl?=
 =?utf-8?B?dTlUMm5NMnZ5WklRNTdLS093Q2pXTG1iQVJkUThiKzZQdlo3MlNjcExyVFQy?=
 =?utf-8?B?QkdCenp2TmcySjVqK2oycU5Fa2VzQzdnUWJGaHh6bWJqQ3VkaXZvMld1ZVNw?=
 =?utf-8?B?V242L3J6TWI1dFBHQzFET0pYelZiM3dySU54cG9XdWc3QUdGZ0o1NWNMRXV5?=
 =?utf-8?B?QmxySVlXYndUN1lBYmt6R3FzTTNpc0JGN21UeDRIVFFKb3pNVHpLMVBNci9x?=
 =?utf-8?B?YkdhaVNTaFJDUGY4bFBBbmJWUXR1US93TW1GL3R4RHRZalMzZmVZN2U4YUgy?=
 =?utf-8?B?WHpNNVp2ZktRYkd2L296RmgvTDRkN3djTGorcUpETWJDWW90Vk1UOGFVVE4z?=
 =?utf-8?B?ZUU5TzBiYzZ2RGQ5Q0g3QUlTN0FXUHhCS0VZc2RRa0dJWDZtbVlON3RCbjEr?=
 =?utf-8?B?bzhwdVR5V0ZCaGprMVFBTzJDVzNxK09SbURxVS9wTUFrRHhJL1pRK201UVhl?=
 =?utf-8?B?UVNzYkR0akl0ek8vVXhkMStiNEdneU5DRHBwRk1sSTVjYlRYME9GRy9ZOGJT?=
 =?utf-8?B?bVA3YmR1N2s0VWhNV0xIYXV5Zi9RL0pDdEdQL3lPYU1RQU0vSnhMalZnN3FM?=
 =?utf-8?B?VzlUY1gzUEEramJzd2dQYVJLTngrd3ZBc3lhanZuMXhDUFVEazMzZGZxT0tj?=
 =?utf-8?Q?iE3BS/ASvvnP5zLieEn/OJ1Cyo/QGf+THb6PCFP?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9201d3d3-426f-4f67-10fd-08d9920510d9
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2021 07:01:10.5448
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 19C7LrexDgxC4aF/DB7Dr5N33dxyNGTtDE4oY+qn5JGv4ER8iuRLLYrkaMVcZg/JOQpe/7/TSJE5WFdihAMcjg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4608

On 17.10.2021 01:43, osstest service owner wrote:
> flight 165539 xen-unstable real [real]
> http://logs.test-lab.xenproject.org/osstest/logs/165539/
> 
> Regressions :-(
> 
> Tests which did not succeed and are blocking,
> including tests which could not be run:
>  test-amd64-amd64-examine      4 memdisk-try-append       fail REGR. vs. 165524

This failure looks to have "resolved" itself on the next flight by having
got moved from albana{0,1} to godello0. I wonder whether the underlying
issue is still there:

Oct 16 18:03:04.051396 Booting from PXE Device 1: Embedded NIC 1 Port 1 Partition 1
Oct 16 18:03:04.207398 
Oct 16 18:03:05.215362 >>Start PXE over IPv4.
Oct 16 18:03:09.163371   Station IP address is 172.16.144.59
Oct 16 18:03:09.163389 
Oct 16 18:03:09.163395   Server IP address is 172.16.144.3
Oct 16 18:03:09.175381   NBP filename is bootnetx64.efi
Oct 16 18:03:09.187377   NBP filesize is 435712 Bytes
Oct 16 18:03:09.187394  Downloading NBP file...
Oct 16 18:03:09.187403 
Oct 16 18:03:09.247368   Succeed to download NBP file.
Oct 16 18:03:09.247385 error: serial port `0' isn't found.
Oct 16 18:03:09.343393 
error: can't find command `timeout'.
Oct 16 18:03:09.343410 
error: can't find command `label'.
Oct 16 18:03:09.355420 
error: can't find command `menu'.
Oct 16 18:03:09.355437 
error: can't find command `menu'.
Oct 16 18:03:09.355446 
error: can't find command `kernel'.
Oct 16 18:03:09.367359 
alloc magic is broken at 0x7a59fac0: 0
Oct 16 18:03:09.379381 
Aborted. Press any key to exit.error: you need to load the kernel first.

Looks like a broken grub configuration file that gets sent to the
system.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Oct 18 07:09:13 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Oct 2021 07:09:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.211702.369337 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcMlh-00052e-M5; Mon, 18 Oct 2021 07:09:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 211702.369337; Mon, 18 Oct 2021 07:09:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcMlh-00052X-IU; Mon, 18 Oct 2021 07:09:09 +0000
Received: by outflank-mailman (input) for mailman id 211702;
 Mon, 18 Oct 2021 07:09:07 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=628V=PG=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mcMlf-00052R-RJ
 for xen-devel@lists.xenproject.org; Mon, 18 Oct 2021 07:09:07 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 47e86394-2fe2-11ec-82cb-12813bfff9fa;
 Mon, 18 Oct 2021 07:09:06 +0000 (UTC)
Received: from EUR03-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur03lp2059.outbound.protection.outlook.com [104.47.8.59]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-39-N5nlzpjSPwuZ03p1X_xHjg-1; Mon, 18 Oct 2021 09:09:04 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB4605.eurprd04.prod.outlook.com (2603:10a6:803:65::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.25; Mon, 18 Oct
 2021 07:09:02 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.018; Mon, 18 Oct 2021
 07:09:02 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS9PR06CA0222.eurprd06.prod.outlook.com (2603:10a6:20b:45e::32) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.14 via Frontend
 Transport; Mon, 18 Oct 2021 07:09:01 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 47e86394-2fe2-11ec-82cb-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634540945;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=slF/gu56ubJDSJkfAmnSkNeWbqJG6AhZQ+FwjS7uTYQ=;
	b=OxGuy/rJV4Cfn71OgDz+/QzxZn7PmQH2X/CAEjROubxSUuKVY7QZmLwFt/iAWAEtKUWILJ
	aWrHm0dyKQ1bvs6eqjnDabZobSxnhSEeNJ5i8Nb8ks4oGH0Cqqs3QHMaHqjxFBevQgKXMO
	/Iccr2qPy59gzUEeAaDLtebvJuUndnI=
X-MC-Unique: N5nlzpjSPwuZ03p1X_xHjg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=eefUJm8nSfl+vlR+OQP53HPKQmgcKrLXuC0XG6CZOR+yc2sheg3u38n5tlSyrQh2l18pFWC8P5ZO9zmnsjyctVdKzbEgBXlahCFSEDyCi/Z9cd2h/KvMU4/G1mpJBUSBPLwduv2RNDbpGVIqLuz/YLuzOiUukU8BOHOTQoXh3JPjdq2t/1ZT1B2Hc1dblRZgJ1TG/Tv5D6DBuktFc5Z8qyrgxBEB7UhvwT77fcuXL9kOs+TJWhQFxFf4Mb37aYvzBoTKA/03rQ2oxIsj1VMOOVaECmJNzDt5vvpvnEU9KdvWAh/LUnnAxNy5IuFgesBw3DrR39Q9/YrPGQI4gaPIMw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=W5aJvPuZVuPFahGlRe0PSxEc8cTBs8HVKC2LptStzS0=;
 b=nF08b5JyTP8P5E6y2qA+MZHpnRpT58FWmtmRrcwsqbK/aFFc5J3j5nGiXugxTGGU3lG38HjH7iaimY9Gab59TZBB3RILxGGAcu3G/aGy5rVnizBI56HCU7tImHSQDAOD1GPhjemFN/ibrSrp4AznflimiNSMC2fbhv0rJAndaNlKic9BRCconyzfJgalhl0xEjzGJQDi6Ujhp1+m4z5KnMUOsONHc/DaeK2jsuo6kvzBh4yq61dwtb8++5+V08VLIaEp9xStZPKNav594+CuRYO/oa9xfosKOPUXskOJuBIfJngKcQh8dapuh2u8ZJ7VZiVHh1VBJNcQ4uwh/KgXUQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: xen.org; dkim=none (message not signed)
 header.d=none;xen.org; dmarc=none action=none header.from=suse.com;
Subject: Re: [PATCH v8 2/5] xen/arm: Enable the existing x86 virtual PCI
 support for ARM
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Ian Jackson <iwj@xenproject.org>
CC: Julien Grall <julien@xen.org>, Bertrand Marquis
 <Bertrand.Marquis@arm.com>, Xen-devel <xen-devel@lists.xenproject.org>,
 "iwj@xenproject.org" <iwj@xenproject.org>, Rahul Singh
 <Rahul.Singh@arm.com>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
 Paul Durrant <paul@xen.org>
References: <cover.1634315461.git.bertrand.marquis@arm.com>
 <e2b10f56043155e4bb8eae824723045ccc042f8e.1634315461.git.bertrand.marquis@arm.com>
 <cef8d2a6-91c1-2d4d-2078-98d0a92b067a@xen.org>
 <F447A1D8-A023-4127-AAC0-7511868DE9C4@arm.com>
 <a45077dc-e144-4427-9ae2-5815045ecaec@xen.org>
 <alpine.DEB.2.21.2110151235100.31303@sstabellini-ThinkPad-T480s>
 <YWqpQyKvNzE8GYda@MacBook-Air-de-Roger.local>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <2b6c80de-f71a-b32e-340f-130f62d9dfd5@suse.com>
Date: Mon, 18 Oct 2021 09:09:02 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <YWqpQyKvNzE8GYda@MacBook-Air-de-Roger.local>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS9PR06CA0222.eurprd06.prod.outlook.com
 (2603:10a6:20b:45e::32) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: ac669c05-d64e-4aa8-cee9-08d9920629d5
X-MS-TrafficTypeDiagnostic: VI1PR04MB4605:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB4605BC3AFC421899E483BC62B3BC9@VI1PR04MB4605.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	F4XWSAHaKWLsecOvXDA99/cjJTYD5lO7iLqvWhels0k0neYfZBiBmK/15vB9PVSaV3n3OUAIx4YyApSYX5PKW7s1KuFJPWWlcnINcS8/u0IZhD3epfn8sZQy/+JJ3NB/1iforVJkJE0RKXmVLDDWv1e1e0Uy4Dwrr0FBmd5aIoH82zBJh6KbECAEHA2w46rbVhJH3xFJW1ywP7mPJ1sCX7M/AKwO/YzQaweOZNqQUebZRQ5JT45oNCwlCuhPNksGiZolzv/tXKcXgYty41Mn6bZEcRAVcHI/I4ku6G4GXLfjBxMOkER0VXdNk59uSnFxsZ5dVuUCZ1qXbcyKxozv4lzVXmbjm/5j42LJM2uDndjZC+qZ4CAcMSfh+lDMPcYwbNGwtyUUFSeG293yxzr7Av9vA3CJjv9+CDwyE2TGD6thIeiwljVpJDOVbuvqIuiM6/xb5sSpGHnvPhTe6neZ3mmUBYeCZDakTbzMpv2nX4lttNJVg2wH+JMzWP2VdlbIxfyR/TlMJZar8LwwCjOTxe3MEVXcPQC5fBJ++5TR+IP1OAvlioZpdjAn70Mn5PBnwsDbZrZQSVqv2yrvp+XX/EYCDiP3Mclkra/Pd2WVq56JXgE6q+96uGXEB1KO9/p4ljg+2am3kVi6q7BQABaMP/9k721cO4C7zcQnJ2g2eKNtWwrj4SvVlXlZPRLw8o6Z8X4o5vYb+TjvBG12EutrR0/Gqz8Az8OqcLPRFZntj302KXMc8FHjL8v/nMmrJSMN
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(2616005)(956004)(316002)(16576012)(66946007)(86362001)(7416002)(66556008)(66476007)(38100700002)(26005)(53546011)(2906002)(110136005)(36756003)(83380400001)(54906003)(31686004)(6486002)(5660300002)(8936002)(4326008)(508600001)(186003)(8676002)(31696002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?miedexEOL9+5JL7aisswumYNL+8s0URsG+NId4fDJ1RtNHlCX80frtnZz7S7?=
 =?us-ascii?Q?D0R0jxW9GyoE4+fsi9sg5kM1+c+g6TBJsr4gOIIiIR0aHC+4wNAMaJxwyf2v?=
 =?us-ascii?Q?RdCa60R71wQrztAZKdHPj/d6c0TQrGq7R+KRGvTr7ua9gSQjfi59sh3x6qxY?=
 =?us-ascii?Q?6GBdALd2VZ5giQ6TTQSCqoF5JZbvbbfEE6Y4QtjM8dVM9nffd8mLZUFigs3A?=
 =?us-ascii?Q?cJptOHN9OQ3rtGyXk86FU5bAcQqb/ifVfeIENSffRSWG8Ts+7cM/faMTAtoh?=
 =?us-ascii?Q?W5Jp15S5JfNzLIV+Vns0cNZda1k2Hu8RMywitCmfT0zeCHaaZgvVntqnLjv+?=
 =?us-ascii?Q?8zN4Z2hcAOCg07ZckmXFI8xA6+Bcq5Eu3twxFydKaLnGE+knG1ZTRGaFvgo6?=
 =?us-ascii?Q?z3PJXNGeUxPtfoEgrfQHmeQId58Wa881z4NavJmgG3atPv12KWGg0hpplqt/?=
 =?us-ascii?Q?yYUdcP1xQArwT92bwrRjS5u7XtlCTBHfiAlhnyWyXTaBmFLFlnEavGpISqWb?=
 =?us-ascii?Q?BQP/JlM+CaiHL0wIy4uxJjnRr43c/Gz/5O4TbuSf7sXs8cX5f0chYYmEpMnn?=
 =?us-ascii?Q?MyHGZogymCcWVhd+XrhjyOPjOcwGGPqgBpPwu6OdPm24cbICYTn0aWBfCo0M?=
 =?us-ascii?Q?JRsw23mBZSCll/mO3ezVNcP5EY7nYClXT8VAmgbJCowP319cmGnYlN9aWR/P?=
 =?us-ascii?Q?C+cW7TqfSn7uiiNJlMuHzzS0gAZyIsW//0MOrtFNRXlhknDu04jNVJftCFs0?=
 =?us-ascii?Q?zhXMWGKtIlHAhSECBjbf7+qG16DCPVwzf35d42OgMhxiuLeECWOvHTUVqSeS?=
 =?us-ascii?Q?+rEJG/sKqivruHKH50VwrhJahEkYCN92NoXhTckXdv3ff9nX73ve4oZSrRb/?=
 =?us-ascii?Q?NGS3fnIPB5UZ/1UnXKDITnDMV3/dX1Zta+rhAZ9sXS3edz3cvihXBSxaDp8S?=
 =?us-ascii?Q?ZkXI4+yK42YYrgcF02DwsNvG5zIG8eOz+3+Q8B4QCuNeN36VL1mYBRQ7aPnN?=
 =?us-ascii?Q?wl7ytKfegX44BC0WWl5yO5IzdDi72+a4wYpX3TGQAcKrdHT6KnVtbdLog2YI?=
 =?us-ascii?Q?wiX92vAgnX8E9XFgkolBFFjrlYP7tzZz+qzVgjFVKT0eWwmi2EBh5Q25UDU1?=
 =?us-ascii?Q?EJ0WZgccIM995eBK0XC18RbfsoGhOEyJ14gPDzcSsVgmonVmThT5jdxP/KBc?=
 =?us-ascii?Q?HC3YSSgFZ++M8ZASSDxTj4AtSRBrRDZQLPDiiEY3yzGqkHBKCGUKiW1XsO+3?=
 =?us-ascii?Q?m/Dw6kJuIpURWlZc9id7Y367/KpXYlYpfD9BbqpQovoxtM9/D1W8Xff36JwQ?=
 =?us-ascii?Q?QRiaBZ4GnsRg/HX2+2sXnx8S?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ac669c05-d64e-4aa8-cee9-08d9920629d5
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2021 07:09:01.9812
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: klp6oXhuIwjcXUt/VlzkYL1WbTIFXCSKqXRrm5xaCjxnEIPy/2Ith/gwPTk/nwrxVfZqFTCxif0fLlf6QrcBhQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4605

On 16.10.2021 12:28, Roger Pau Monn=C3=A9 wrote:
> On Fri, Oct 15, 2021 at 12:47:17PM -0700, Stefano Stabellini wrote:
>> On Fri, 15 Oct 2021, Julien Grall wrote:
>>> On 15/10/2021 18:33, Bertrand Marquis wrote:
>>>>> On 15 Oct 2021, at 18:25, Julien Grall <julien@xen.org> wrote:
>>>>>
>>>>> Hi Bertrand,
>>>>>
>>>>> On 15/10/2021 17:51, Bertrand Marquis wrote:
>>>>>> diff --git a/xen/drivers/passthrough/pci.c
>>>>>> b/xen/drivers/passthrough/pci.c
>>>>>> index 3aa8c3175f..35e0190796 100644
>>>>>> --- a/xen/drivers/passthrough/pci.c
>>>>>> +++ b/xen/drivers/passthrough/pci.c
>>>>>> @@ -756,6 +756,19 @@ int pci_add_device(u16 seg, u8 bus, u8 devfn,
>>>>>>       if ( !pdev->domain )
>>>>>>       {
>>>>>>           pdev->domain =3D hardware_domain;
>>>>>> +#ifdef CONFIG_ARM
>>>>>> +        /*
>>>>>> +         * On ARM PCI devices discovery will be done by Dom0. Add v=
pci
>>>>>> handler
>>>>>> +         * when Dom0 inform XEN to add the PCI devices in XEN.
>>>>>> +         */
>>>>>> +        ret =3D vpci_add_handlers(pdev);
>>>>>
>>>>> I don't seem to find the code to remove __init_hwdom in this series. =
Are
>>>>> you intending to fix it separately?
>>>>
>>>> Yes I think it is better to fix that in a new patch as it will require=
 some
>>>> discussion as it will impact the x86 code if I just remove the flag no=
w.
>>> For the future patch series, may I ask to keep track of outstanding iss=
ues in
>>> the commit message (if you don't plan to address them before commiting)=
 or
>>> after --- (if they are meant to be addressed before commiting)?
>>>
>>> In this case, the impact on Arm is this would result to an hypervisor c=
rash if
>>> called. If we drop __init_hwdom, the impact on x86 is Xen text will sli=
ghtly
>>> be bigger after the boot time.
>>>
>>> AFAICT, the code is not reachable on Arm (?). Therefore, one could argu=
e we
>>> this can wait after the week-end as this is a latent bug. Yet, I am not=
 really
>>> comfortable to see knowningly buggy code merged.
>>>
>>> Stefano, would you be willing to remove __init_hwdom while committing i=
t? If
>>> not, can you update the commit message and mention this patch doesn't w=
ork as
>>> intended?
>>
>> I prefer not to do a change like this on commit as it affects x86.
>>
>> I added a note in the commit message about it. I also added Roger's ack
>> that was given to the previous version. FYI this is the only outstanding
>> TODO as far as I am aware (there are other pending patch series of
>> course).
>>
>> After reviewing the whole series again, checking it against all the
>> reviewers comments, and making it go through gitlab-ci, I committed the
>> series.
>=20
> Hello,
>=20
> Maybe I'm being pedantic, or there was some communication outside the
> mailing list, but I think strictly speaking you are missing an Ack
> from either Jan or Paul for the xen/drivers/passthrough/pci.c change.
>=20
> IMHO seeing how that chunk moved from 3 different places in just one
> afternoon also doesn't give me a lot of confidence. It's Arm only code
> at the end, so it's not going to effect the existing x86 support and
> I'm not specially worried, but I would like to avoid having to move it
> again.

+1

I'll be replying to the patch itself for the technical aspects. As per
context still visible above this code path is supposedly unreachable
right now, which makes me wonder even more: Why the rush? Depending on
the answer plus considering the __hwdom_init issue, Ian, I'm inclined
to suggest a revert.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Oct 18 07:19:34 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Oct 2021 07:19:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.211712.369348 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcMve-0006Y9-OD; Mon, 18 Oct 2021 07:19:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 211712.369348; Mon, 18 Oct 2021 07:19:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcMve-0006Y2-L8; Mon, 18 Oct 2021 07:19:26 +0000
Received: by outflank-mailman (input) for mailman id 211712;
 Mon, 18 Oct 2021 07:19:25 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=RJnW=PG=citrix.com=Andrew.Cooper3@srs-us1.protection.inumbo.net>)
 id 1mcMvd-0006Xw-LH
 for xen-devel@lists.xenproject.org; Mon, 18 Oct 2021 07:19:25 +0000
Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 7a9f2ba7-f98d-4e71-a343-1c632d90f8ce;
 Mon, 18 Oct 2021 07:19:24 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7a9f2ba7-f98d-4e71-a343-1c632d90f8ce
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1634541563;
  h=to:cc:references:from:subject:message-id:date:
   in-reply-to:content-transfer-encoding:mime-version;
  bh=JKTT7rm8VjwUs/bHBsxdjVggnwiwEmltQmXMzT+uoZo=;
  b=MSGLy0NByGXhyOyMF+3/j/bDfQ8sajzvLNiQxqCBgiF8NdjR5Sb5ADpJ
   9J4t96cgV/eK4H8AOGkX88nfqn6cZDOp5A4n0wTHBn6XTRSj1X1ZqOxe0
   5MXTuiYVAWko5KnIeyJ2AcT6/FWtOONLXHrnYZpAr48dTNbbKvAMfZWAW
   o=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: a9HyRuLyd2ovMOv1zAUJy0wX6uWTQggju9IhVOsTJPz6R3JMuDqyp+5kheX2mcrfo5jfGFoEF2
 8PsXpEInvwygmrCjrTpsrNt9FtTtUMvohf0FfMZl55hYrjD62kHMyY6jf034EwqQIVRGDtsyVX
 iutka9NSc9vaO/aM3cqToBTfwWWVhyPm0TSzsSBMqcXE3SKSyfBC6TJ6uAw857H/VGMjsKi4Fo
 yYcUNIZyN2QxxiaWlJLAXThS8PktxtlJ2ttYX/vSWHLVWTn6wdJ5/IKjesN0/dgW+zvENODvH9
 SMlV0VF/4I4GR6X3OxeQtcAp
X-SBRS: 5.1
X-MesageID: 55395963
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:E6gUHanQ+3NOxB+kqa6j57vo5gwBIURdPkR7XQ2eYbSJt1+Wr1Gzt
 xJMWj3XaPveMWaheo0gOduy8UlV656AmoBqTVdoqi01EyMWpZLJC+rCIxarNUt+DCFioGGLT
 Sk6QoOdRCzhZiaE/n9BClVlxJVF/fngqoDUUYYoAQgsA185IMsdoUg7wbdg2tc42YHR7z6l4
 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc
 s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4
 PQRuKGpTFl5B5CPquU4Cj58PRNPLaITrdcrIVDn2SCS50jPcn+qyPRyFkAme4Yf/46bA0kXq
 6ZecmpUKEne2aTmm9pXScE17ignBODtMJkSpTdLyjbBAOx9aZvCX7/L9ZlT2zJYasVmQKuFN
 pdIN2EHgBLofBJuI0YULZsFmv6QqT7WVyJlln+2jP9ii4TU5FMoi+W8WDbPQfSaSMMQkkuGq
 2bu+2XiHgpcJNGZ0SCC8H+nmqnIhyyTcIAYGaC89/VqqEaO3WFVAxoTPXOkpdGph0j4XMhQQ
 2QM8zcqhbg/8gqsVNaVdxynolaUsxgEQd1SHuYmrgaXxcLpDx2xXzZeCGQbMZp/6ZFwFWdCO
 kK1c83BJGBijaSQFyKky/SmrBbrHgw7H14SanpRJeca2OXLrIY2hxPJa99sFq+pk9H4cQ3NL
 yC2QDsW3OpL05Zav0mv1RWe2Wj0/8mWJuIgzlyPBjrN0+9vWGKyi2VEA3Dg5vFcMJ3RcFCFu
 HUV8yR1xLFTVc/T/MBhreNkIV1I2xpnGGCE6bKMN8N4n9hIx5JFVdoBiN2ZDBwxWvvogRezP
 CfuVfp5vfe/xkeCY65teJ6WAM8316XmHtmNfqmKNYYSM8UgLlPbpnAGiausM4bFyhlEfUYXY
 s/zTCpRJSxCVfQPIMSeFo/xLoPHNghhnDiOFPgXPjys0KaEZW79dFv2GADmUwzN14vd+F+92
 48Gb6OikkwDOMWjMni/2dNCdjgicClkba0aXuQKL4Zv1CI9Qzp/YxIQqJt8E7FYc1N9zbuRo
 SzhBxYFkTISRxTvcG23V5yqU5u2Nb5XpnMnJy08e1Gu3nkoe4G066kDMZAweNEaGCZLlpaYl
 tEJJJeNBOphUDPC92hPZJXxttU6Jh+qmRiPL2yuZz1mJ8xsQAnA+9nFeArz9XZRUnrr5JVm+
 7DwhBnGRZcjRhh5CJqEYvyY0F7s72MWn/h/XhWUL4ALKlns6oVjNwf4kuQzf5MXMRzGyzbDj
 1SWDB4UqPPjuYgw9NWV16mIo53wS7l1H1ZAHnmd5rGzbHGI8m2myI5GceCJYTGCCz+kpPT8P
 b1YlqiuPucGkVBGt5tHP4xqla9utcHyo7J6zxh/GCmZZVqcFb49cGKN2tNCt/MRy+YB6xe2Q
 E+G5vJTJa6NZJH+CFcUKQcoMraD2PUTlmWA5Pg5Ohyntip+/b7BWkROJRiczidaKeItYo8ix
 O4gvu8Q6hC+1UV2YorX0HgM+jTeNGEEXoUmqooeUd3ihQccw11fZYDRV33t65aVZtQQakQnL
 1d4XkYZa2iwEqYaT0cOKA==
IronPort-HdrOrdr: A9a23:TUkqpaqpV3fVYDc7Q+kE/kEaV5oVeYIsimQD101hICG9Ffbo8P
 xG/c5rsSMc5wxhOk3I9erhBEDiexLhHPxOkO8s1N6ZNWGN1QeVxelZnPLfKlbbakjDH4BmpM
 RdmoFFeaXN5QcQt63HCXODferIauP3i5xA/t2w80tQ
X-IronPort-AV: E=Sophos;i="5.85,381,1624334400"; 
   d="scan'208";a="55395963"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=YlkZ8/BwU6OMIFAUtWKYlFo0/RxSiXfrkCRdfY2r5HbbjfEGI3PYPbL++QGfIt7KJTCDyNXeBpYRunkUoB1gRG0cxab3UUnZjR34IF+bYo+bQJoBxglzpmTkDM/YhuVlq2vA+CHwEkMoesfz+QmI7SwM9VdT6WXUzdW2129+SjePMkUGqG2GGst3HYC1Fp82QB55ObRbVALcGpRXYEp5FBy59Ndxeri0uMe1PYifL09kbsu//xaOnPz10sd7MoNgrgYoexOiLPLJxiMLxrowlB1UBVtJkZ9ghHg8yj+dPQzEvJIjawvqjlgWABOGyenDLaXIqgwdXWzGCJa87aly3A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=JKTT7rm8VjwUs/bHBsxdjVggnwiwEmltQmXMzT+uoZo=;
 b=lmIU6oc6mi5f5mzQ4d/22A+9rd9F6bTPtOD6aZcbne+9N3YK+Gjv+lqun+9OXzPQupRXvzxiRRwyd1m1k3cSw4ASn+yrmkb0jHivEQ2o7HVtg5Hr5p44jfhBgxzPFgioYwDdLcuXAuY5PwZJx2ZS0meq62H2u1KqkcnXJTsFCPcBbLNHfYxoQWX8grjU01/Qi5yqPLX/aOICy6bKYpbjxLx3Wh55dxdI8QttAHFt+y6oWLmFgsiWW/k8sOQMtS/blg75YfFtYtcyRNzjwf76rmyBe06RdST6m5Ju4QJ5CTb9uKlnifKVbTxPx0lH6Jk3OsPEMLs5wDKbYAssgj2pnQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=JKTT7rm8VjwUs/bHBsxdjVggnwiwEmltQmXMzT+uoZo=;
 b=CYgl38VKQRG2z9WxRiCD80rpi6LsUs7P0VzuicSeaMrLNU2+b4LzALG8oWu9wRwNJ0joi8h9rZ4FKUKKg64ZUZYyJTREQLFuSxzeuGdxB6JfSMR4ZfOf0fRhEsXw7Rpl4CpVQBt53NzmymI/Pk7qNESqA1cL8l5YY95ileYLT64=
To: Jan Beulich <jbeulich@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Wei Liu <wl@xen.org>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
	<roger.pau@citrix.com>, Ian Jackson <iwj@xenproject.org>, Paul Durrant
	<paul@xen.org>
References: <55570db5-3823-8996-f69b-c2b00bcd4227@suse.com>
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH] x86/HVM: correct cleanup after failed
 viridian_vcpu_init()
Message-ID: <569bffa4-8f66-f93b-89f6-e1d5ee799964@citrix.com>
Date: Mon, 18 Oct 2021 08:18:47 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <55570db5-3823-8996-f69b-c2b00bcd4227@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Content-Language: en-GB
X-ClientProxiedBy: LO4P123CA0129.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:193::8) To BYAPR03MB3623.namprd03.prod.outlook.com
 (2603:10b6:a02:aa::12)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 57189b32-b5cc-4ca7-9052-08d992078a85
X-MS-TrafficTypeDiagnostic: BY5PR03MB4997:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <BY5PR03MB4997CC10DE02786325E9C0D9BABC9@BY5PR03MB4997.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:595;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: oKGmBK3vEu9jyo9WBZyD6rAcsIVSWPi6SbNeWRI4k+kQMnuBhMIOrqZO33mli9/ZSkwVYzE+nNllhHCmJV1sWQWyQOXunLIfB6+jhpR+I21HC/cEsYbrRtgQEkfKsMMXj1ip/iTdy/PeDlnW/chz+oXJr8uoj0FZUQLh5fTN/RcHCnFt0aiqQ+HTPf4TMA0fUtzRBN2hTjPRyG35KNc72RzHGHAEpNpTckBhvvLs5lh23o6OmvFilrDZz4PFH43BUO0v7AdaoEAkRv84Z4z09aUfR4VXwosHNJiXF+z7szUIf4W1LNsf98yW/euA0oeX2Icym5lBRgPfzoX0u5M40RHE+9HOshEhUUMHCY2Zz18s5S72WGS7IW3LITRPArobTQp0E8jjmgPCgXBx97TydDH015o7kVv4QJI3ifrOksKU8OqrO20FUbJ1uBWsIS/1fCVl3njyTew124NRxLsCYgBahpA7CHv7Xq8sxNmSAprVhEiyQr2tQ4CVlBaLLtw+RQMdqNJgGhXWhCMOoXi+FWd5oiqi4fZMuTgFKk7YhDlNEZ8dtBoiHa0ApFv5YCIdKbjgE/+n988ahqkr053lU8efYyEE0KVkuNf/qgJ9kQ4uVAAIk9auAcptzkLsrJudnHgO11iZXwxg8HZ+pb+IcPvxSnAty344SodsSiTR5+SuIYIeZkht+wGsiMpRqLz8G9clmA6qbNOE6ATFO4Vve3HI6be4oMdqaOVJb1EmbpY=
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(4326008)(31686004)(38100700002)(2616005)(956004)(558084003)(31696002)(26005)(316002)(186003)(36756003)(82960400001)(110136005)(2906002)(508600001)(54906003)(66556008)(8936002)(6486002)(66476007)(66946007)(86362001)(6666004)(53546011)(16576012)(8676002)(5660300002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bmxkcUg2dklZbjNUYVduVFlyZlRXUDYzYnh1SFltT0tobUdRWmw3eUU1dm9Z?=
 =?utf-8?B?dGxTcE5UL0ZvZURxZy9jYW5KSi9pRFp3bDJPQndUMUkwQS9mN3hISnJaQjhJ?=
 =?utf-8?B?VmFPd1NLN3drWjUyTExxSFlwRS83dFlrWFpZN3VJeC8veE1YK0xoS0NWc25i?=
 =?utf-8?B?SzBheHpFbUFwSjBGUzZVajNHRUx6ajZsVTlnc3VQVVRPMk9PbVN6WldmME5l?=
 =?utf-8?B?c0xvWmZmNDMvelhZY3hQZFBEUGp5ZzVJV2pvS0o0R2owVWUzNU94VmgzS3Mr?=
 =?utf-8?B?ckI3Z2RyRjhUVGR1bTd2OFFaUHcwRlRKVlcwZW9GaFBFS2VaM21vcm9Ka1Zm?=
 =?utf-8?B?ZVRlSTVtOXdBRkl0ZEdVdTBOa2RDM1ZQSUJIQ0E3NndQUk02SVliMG9pT2Jo?=
 =?utf-8?B?bHE1c1NnTnppamo2UGVzcHI5UHFLNjAvdmx0ZHNhU2xvK1FGbUJPR3BreTRY?=
 =?utf-8?B?bnlHU2ROaWRXa1cvQzNjRmoxK3IraU82WFV0STJMaDZVM1pkbEc2a3FXcmVJ?=
 =?utf-8?B?ZTR4MytHQkNYYk93Z2JtSlNSWXhleC9aUTZ4d2lQRDEwQnpaR0tpeHhjbDJi?=
 =?utf-8?B?cDFyaFBFZVpwWGdBNmlWaUdYMzFpcHRzdDNCbFFtalhCM3c4UEFweFQ3MnVL?=
 =?utf-8?B?a0wxazJrS0VBSmY0dmVtYUJvbXNaL0ZRT0xhUnhsSVFBOWJBOWRnVWJFZkov?=
 =?utf-8?B?cTN5T1JldjJhM1BtT0VQSDFJeE5VNEZWZEsyeDlERmpYWnVYOFJQanlNaHND?=
 =?utf-8?B?Y3JucDZaczh0Ui8ycjlpMDVURHJHYTI3MC9oV3c3dHJDVDF0Y0x4QVVicHdU?=
 =?utf-8?B?TU0vUmh5VGlHdG5ycjh5T29TNlBSZEdub3RNemkrdmF5eUZqZzdnNXpCakMw?=
 =?utf-8?B?dkNLRzJrcXZQZHJvY1dRSTI5MlhVVmtpYW5jUTRDekI2RGNRNGNvUnhsSS94?=
 =?utf-8?B?VTRZb2tsSHY3N0VOTnpST2tkSlJ0SjV3c0pOclE3dzdOdHNxNlA5U3l0bEtT?=
 =?utf-8?B?TlY1Y1Y3K29tMVFTRndweFowNFlEMkZHSnczVUN5VE9KLzVPR01GeXBZOXg5?=
 =?utf-8?B?RUNOa2FHelo0QWM2LzB1T1hVODVTclhCTlNOdzBqSzYyTlRQZ2tiOE5xaS80?=
 =?utf-8?B?VjNXdzk4bUZ5S29KMkxOQWIrRzljQnUreWtYelVMQUU4Q3BMY3ZITzdGbktU?=
 =?utf-8?B?TWM0Z3ZpdG9JQzVZaE1Zb2ZhL1EvREJhVFgwSDcxOHd1T2hTOUlyUGU1MWUz?=
 =?utf-8?B?czNXQzAvUGFRVUZVY3V5cmtqaTFzNGthREp0c2JyUnRFcmVxTWwzVFVpZzc3?=
 =?utf-8?B?QmMzQXI2N1VvaTZOTkc0UzN0TTVtSEpnMXdGOVF3R2FaMDN2RXk4d0lrVWJk?=
 =?utf-8?B?ZDJGeXpCUThSSUZOdVZYL2ZVK0l4ZXJKUVVjR2tSVmt1TTNSOFJGNXN0QmJU?=
 =?utf-8?B?T1lPOTk5UHY3WlZIbHZaUVZxa0VRNjVVaXJDaFlZc3BrUVlIaVBQQ1BTakRy?=
 =?utf-8?B?UW5NTXptdCtRK0pjQ1lyRVozMHRmc0o5S0x6VlZoK1VNSnlYOEVLYzZkWXB5?=
 =?utf-8?B?NWEzRUdBQ29HS2RPeW9CejZxYk5iSUZQQjAyMTlERzNRTjQ2R1FEbnZqQkFX?=
 =?utf-8?B?MVM3d3dFME8vUUZtZG5USkpvcTVwMktUMUl3Nyt1dGczcSt4RDNNMm1DSGxS?=
 =?utf-8?B?MG9yMmJzVGlqdVVmZ3JwMjU1UDZWZ29ubWNtWWpVNjZCY3FEak93MFdGc1M3?=
 =?utf-8?Q?FRlTkYuzjHKe8Ti281pand8FevIT5SRuoiPtZAv?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 57189b32-b5cc-4ca7-9052-08d992078a85
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2021 07:18:53.7750
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: wJhmZL0qyrwUMvb2wKxnYhhVwi/gG4FZ2dkC+VJNx4oGv+A8imxp1857XqniJ0M83Kt2TkY91J0wwhxfzsH7Y0hF0JtikCWOYyoPQxqoBUM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR03MB4997
X-OriginatorOrg: citrix.com

On 18/10/2021 07:43, Jan Beulich wrote:
> This happens after nestedhvm_vcpu_initialise(), so its effects also need
> to be undone.
>
> Fixes: 40a4a9d72d16 ("viridian: add init hooks")
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>



From xen-devel-bounces@lists.xenproject.org Mon Oct 18 07:21:30 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Oct 2021 07:21:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.211720.369358 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcMxe-0007te-4i; Mon, 18 Oct 2021 07:21:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 211720.369358; Mon, 18 Oct 2021 07:21:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcMxe-0007tX-1c; Mon, 18 Oct 2021 07:21:30 +0000
Received: by outflank-mailman (input) for mailman id 211720;
 Mon, 18 Oct 2021 07:21:29 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=RJnW=PG=citrix.com=Andrew.Cooper3@srs-us1.protection.inumbo.net>)
 id 1mcMxc-0007tR-Ur
 for xen-devel@lists.xenproject.org; Mon, 18 Oct 2021 07:21:28 +0000
Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 0199de2a-2fe4-11ec-82cb-12813bfff9fa;
 Mon, 18 Oct 2021 07:21:27 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0199de2a-2fe4-11ec-82cb-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1634541686;
  h=subject:to:cc:references:from:message-id:date:
   in-reply-to:content-transfer-encoding:mime-version;
  bh=YAuQIayE3t3dABNES/1XDbBZ1R6MaeFa9BxG7v1wPGk=;
  b=apMjE7QBNdPy0Tu9f8dACi1yeV/mDuaMKZgcmIFC80WuAs61MZCPmHMf
   YwwBIBMaAQYogdASAv235UX4i9RriWO2bWYfxsKmT3hKdgTybYGDCcm6e
   D1gUkzNmfJjugTjz7EgB3Trh2cqWVXiyYUo2nVV0gO4VqxNKotS1gL8dx
   o=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: surCThefBP1a+6d97AieNTFaD+YFgYr7t4pzW82IWeSD8G609S9IL2DMNUDRPWa48o1rABwehC
 lOC7gZLAO0kkTVYF7uNulvsGs5pa1cpUGQiXtYDE6uUWClxLh138jPnzK/Pd5Me5pj9ikn2NlX
 aS3o84KM40lbYd1Z5jHyVU1MbOPvdo87CIBLwuraVtCrD03XgGx+x2B2QIV3fXe3X6rM3T5NXx
 lOmnSlP8RjROtHyE1IbgAlP8ALckGkYbKGGgSFKcijRx2ORXAztF/Dn8alkrylL6RubbpIFVFs
 37bToz7ovHIWsP2nALt0mkno
X-SBRS: 5.1
X-MesageID: 55439562
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:lZJ0Uq1JHzthnj1UQfbD5VJ2kn2cJEfYwER7XKvMYLTBsI5bp2MDx
 zAaXTvXP/iNZjOnc4wlbo+19RlX75CAztZrHVE/pC1hF35El5HIVI+TRqvS04J+DSFhoGZPt
 Zh2hgzodZhsJpPkS5PE3oHJ9RGQ74nRLlbHILOCan0ZqTNMEn970Es7wr5h2+aEvPDia++zk
 YKqyyHgEAfNNw5cagr4PIra9XuDFNyr0N8plgRWicJj5TcypFFMZH4rHomjLmOQf2VhNrXSq
 9Avbl2O1jixEx8FUrtJm1tgG6EAaua60QOm0hK6V0U+6/TrS+NbPqsTbZIhhUlrZzqhpvFsl
 8tSkqWJdAJ3MKTdsd06dQBYOnQrVUFG0OevzXmXtMWSywvNcmf2wuUoB0YzVWEa0r8pWycUr
 6VecW1TKEDY7w616OvTpu1Er8IvNsT0eqgYvWlt12rxBvc6W5HTBa7N4Le02R9t25wVTKuAP
 aL1bxJEQE7OW01uPm0mL5MVrr7yi0H6Uhth/Qf9Sa0fvDGIkV0ZPKLWGMrYfJmGSNtYmm6cp
 3na5CLpDxcCLtudxDGZtHW2iYfnnyn2RYYTH72Q7eNxjRuYwWl7IAISfUu2p7++kEHWc85eL
 mQE9yxoqrI9nGSqUdvVTxC+uGSDvBMXR5xXCeJS1e2W4vOKuUDDXDFCF2MfLox93CMredA0/
 maogoz3GhtWiYCQF3yU556tihWrOQFAeAfuehQ4ZQcC5tDipqQ6gRTOUstvHcaJszHlJd3j6
 2vV9HZm1t3/meZOjv/hpQmW3FpAs7CQFlZtjjg7SF5J+e+QiGSNXIev9UTApchJKIKUXzFtV
 1BVxpDAsoji4XyL/RFhodnh/pn0v55p0xWG2DaD+qXNERz3qhZPmqgLuFlDyL9BaJpsRNMQS
 Ba7VfltzJFSJmC2SqR8fpi8Dc8npYC5S4+5CqGJP4ASPsIgHONiwM2ITRTBt4wKuBN0+ZzTx
 L/BKZr8ZZrkIfUPIMWKqxc1juZwm3FWKZL7TpHn1RW3uYdyl1bOIYrpxGCmN7hjhIvd+V292
 48Ga6OilkUOOMWjM3K/2dNCcjg3wY0TWMmeRzp/LbXYfGKL2QgJVpfs/F/WU9c5xvsIyrqRo
 yjVt40x4AOXuEAr4D6iMxhLQLjuQYx+vTQ8OyktNkyvwH8tfcCk66J3Snf9VeBPGDVLwaEmQ
 v8bVd+HB/gTGD3L9y5ENcv2rZB4dQTtjgWLZnL3bD86dp9mZgrI5t67IVe/qHhQVnK65Zkkv
 rmt9gLHWp5fFQ5sO9nbNaC0xFSrsHlDxO8rBxnUIsNecVnH+ZRxL3Cjlec+JswBcE2RxjaT2
 wuMLw0foO3B/908/NXT3PjWpIa1CepuWEFdGjCDv7qxMCDb+EulwJNBD7nULWyMCjus9fz7N
 +tPzvz6PPkWp3pwstJxQ+Rx0KYzx9rzvLsGnA5qK2rGMgawAbR6L3jYgcQW7v9RxqVUsBedU
 16U/oUIIq2APc7oHQJDJAchaejfh/gYliOLsKYwKUT+oiR24KCGQQNZOBzV0H5RK758MYUEx
 +Y9uZFJt1zj20RyatvW3DpJ82msL2AbV/R1v54XN4bnlw43xwwQepfbECL3vMmCZtgk3pPG+
 dNIaH4uX4hh+3c=
IronPort-HdrOrdr: A9a23:ap/QvK2i/UP9gokSP67jHAqjBLYkLtp133Aq2lEZdPUzSL3+qy
 nOpoV+6faQsl0ssR4b9exoVJPufZq+z/5ICOsqU4tKNTOO0AHEEGgI1+rf6gylNyri9vNMkY
 dMGpIObeEY1GIK7voSNjPIceod/A==
X-IronPort-AV: E=Sophos;i="5.85,381,1624334400"; 
   d="scan'208";a="55439562"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=nilTrGyfsCVkm0/Oyvdqq9FaFQA1apIwXT7KcETTRvoMnBnOCSAAULW8++TU8+OB5dxhGV6CJTeiez/ScRHK1mg0PZsDK/f1RUlOlaYJIQh7g0KUVyxdSvvIqfGksMqUDg7i2Vu1J9/zViSrNARhw4FQ0exo72k/HKiRyd+sb+dxWuWfYsr6k7SPBPgZzRk6mAwwQ8Y7h8d4TnSx5CXYMp6nOjzt56WDLmv3rBKubABsTSH+OVtJCLyG9QxGjRATiFioHS8r0EAPSuSQWY/Yh0vxho8Vky8FEYbF/LKLCgoAHtJXNPOybCQfNBaRx8vhVGpOH02NrDYk0yzMkztlNw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=YAuQIayE3t3dABNES/1XDbBZ1R6MaeFa9BxG7v1wPGk=;
 b=FAaFG67AbCz3U7tjuxuQ1zpXS4PMWEWOiG/ORxZoHxUGcgyGD0sIYpPL1YUeWsTsVWo11XxLr92wZYCJSmhW3fhNqITm43s2ggcrcUgX1sqe4NkigHwdPBqoTNULfLUnqoaS642y4Hs2L4L7JEU4YHU3ls0k229kwmF/UUsCTw7tfnXRhccvcnsMOMBaE/bgxcPcpQ96GbnzOa6r7H4XiTyhVprnb6vJ5A743tRe+Idh7ukFZ1/LyKWr2G6zoR9KwKSCtGWImVkxtSGHt48Mb4Fgb/r53HVBMsYnk9HmueR0BzA9maCxM4nfa4UMv9G25pAw/2W+uX86CtBBoWsufg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=YAuQIayE3t3dABNES/1XDbBZ1R6MaeFa9BxG7v1wPGk=;
 b=l2Nn+5D2xDfm/ZWNxq1cRHHTDwN4x9uWKYl1us1x50y8ATX9dhrCZ2riEhmYiql5xjBtNYKmxcTZRmq+Y98EdrDqvB47WpXAuldhVUvp5gzGgZqqq5pG4lpNH8lE6MslicIWjnuzOdHCGl5on8z8/PtGSXgbnp8dv+RZFu4/1p4=
Subject: Re: [PATCH] x86/shadow: make a local variable in sh_page_fault()
 HVM-only
To: Jan Beulich <jbeulich@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Wei Liu <wl@xen.org>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
	<roger.pau@citrix.com>, Ian Jackson <iwj@xenproject.org>, Tim Deegan
	<tim@xen.org>, George Dunlap <george.dunlap@citrix.com>
References: <e469f3d3-ec0b-fce9-5fdb-5939970fdc6e@suse.com>
From: Andrew Cooper <andrew.cooper3@citrix.com>
Message-ID: <9d7753f3-726d-06e1-7e42-1fcd83330000@citrix.com>
Date: Mon, 18 Oct 2021 08:21:04 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <e469f3d3-ec0b-fce9-5fdb-5939970fdc6e@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Content-Language: en-GB
X-ClientProxiedBy: LO2P265CA0063.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:60::27) To BYAPR03MB3623.namprd03.prod.outlook.com
 (2603:10b6:a02:aa::12)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 09df3434-6121-4df1-c72f-08d99207dbe4
X-MS-TrafficTypeDiagnostic: SJ0PR03MB5776:
X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <SJ0PR03MB57760EE4AB8FD936C015F608BABC9@SJ0PR03MB5776.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:576;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 8iLhVo+OPqjUxLc0YYIsR7vKIboKga1742YHqSOXF4+E7gjOd13yyFPnKyXksfidc+9GEuqto0vs65cVZDualg25nF40EJP52yEfrOC626wK+nr3DYXjZuYaxw0Eto+kp+XNGB2rvsmN28wepLHPNpgsVdKHylQWOEbYlvtDV7pi2v3IllNj6w0QOWMdTKVgP5uxWJ7Ril+tpgeRVPMHXypXhaR4kwLG9UXRdYjltzMdfB2330vltlOV6zf+Qo1D/ng+iMZa4pWmuufVz50Q0F+NO1qV+F+s3lbi3ikFg+Mz9NFrz9TomqvJ7zopTBP+LjJB1Bi13pVTXoOJsGRazfN8+35wpdtarso3JIkAiLZotThs36sf6crlEcSrJ37VJxSaWcnUrTHqEmVCLuRJGA/1SQZBnBVQja95G1c/HM+LT+VPWt4+t9rivWwxqUXnSho72U7bwkmK90Q6KyZ7T6fdCBLIJFjXOQy3Fs7sZWyxnhJ1jD3pR7Vo7oL3Fh/u28hwof6LFj4mp/tLtpYVPAnvE7v9Dqzco0niPbD81i74E+I6lvqTqy/FF5yRpeP+kEW7YOqFCrEsHS4MRxMwW4TWuThrB4YYU3cCb/++hLPBanBW2WHR79BM7PlxbEaLYewC5gW5IwDgXYZhqhUISxJzaH+y15CWB/WQh2/oVzstdNh5sc/aZRA+o3jj5d4yVnLggCeVUCu84UGO+Djulmu4FnMO9VvUdmNJCjOrp+5OX5VuwDcxt2XP3QXOjNz2
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(82960400001)(508600001)(316002)(956004)(2616005)(26005)(8676002)(31686004)(4744005)(36756003)(110136005)(8936002)(31696002)(54906003)(107886003)(186003)(86362001)(66946007)(6666004)(53546011)(16576012)(2906002)(4326008)(6486002)(38100700002)(66556008)(66476007)(5660300002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZmkzWXBXb3cxQ0h0YVpwRHV6Y0JCRzNKRk5XdjVJdnBSMnFyeXhUQ29YVFV4?=
 =?utf-8?B?NDhxWUVabStjYmxZRm4yVmNnNTdGZk1tK0RqV2xwMGNoZ1FxZXI0SWVxa2Rw?=
 =?utf-8?B?ZXM4UytneVMrdzRzM0E0Skc2NDQxNFZmVS9FTHRhWHBETnBqMCtrLzRscUdh?=
 =?utf-8?B?UlV6TlNkY3lsZmtWSHN0SDA3ZzFDQVQvT0MvR0l5Q3B6ZTFMR1ZqNVRWTTZU?=
 =?utf-8?B?TEd6WUMyTDQxQy91MkpreXB1NURWZUc3SDhiUk84akFkM2MzNmxIelF4bHZp?=
 =?utf-8?B?YUYzS0orczhyWGNYRnZQY2IycFR3UDBCM1l2VTBMMTBxdEZScFl3N1VWUDdw?=
 =?utf-8?B?bEFxb3p3RFhwT25OSEVvU2I5b2N1N2ErdVJpZ2hYc1lUMVZmWXZjb3k0OXAx?=
 =?utf-8?B?UjMxQzE5RzdSSlR4MWk1WFAwck9RYzRHNzBxSWZHMlpkaEJnLzdzajJqWkww?=
 =?utf-8?B?OWtCdmp5ZmoyKzFUc0N6cEpkWDNURDJoK0RPbTVnSFRhTXBpZURuVHY0VklW?=
 =?utf-8?B?bkRuNXRPWWk5TkN0c0pKdTF5R0Q4N0xQRC91eFBLZXBLMUV4dDlCV0hEYXdX?=
 =?utf-8?B?bUtZVTFaL3A4ZzB5NlRINEQvQmRua0xESS9TZ09LMDF4OFhEOHFkazFHWThB?=
 =?utf-8?B?VGxRZHkyNlNYUTIwYlR3R29YWG4xcHlmcXp0SWM5cjFibWQ3cjZpRXhvOWJL?=
 =?utf-8?B?bXYvMUJaam5FaFVJSzl0eEtnSGVtUUNidmxZbGNqdUlwcmFBckVMQmJaMERC?=
 =?utf-8?B?Y0JVd1FNek9jc084RE41VkJoMkVCYkpZUnZEQTFpYTE0RWNjMTZNeHYrSXUy?=
 =?utf-8?B?UmtlcDJRL2RvRG9iSldvNWZENlJjOWdLWU40cW5BRUQ1MmsxNXJjOTBJU3A3?=
 =?utf-8?B?aEYwOFhJZ2tWL25ablNwK0haeXdaemdWV0hiTUZUc2NwV3pmWDdGTEE4aFJQ?=
 =?utf-8?B?TjBLMnNLWGVLN0xxWHMxVFcyOEtubGo5aW1pOUNDdWk2c3B2bXhIeFBlR3Mv?=
 =?utf-8?B?ZkxRaHd3M1lMd1dvOC8xRE9oeVM3QjU0Y3NBUktHVWRVeXRaZVMyY0VVNHhN?=
 =?utf-8?B?TFJybThzS1hpRW9xT2xKcS8rNThuQWVGOHNxcGtpeWpGSlNkZTJtRWJYbWx3?=
 =?utf-8?B?YWY2b3ZwZklqYUNtSUtjMklmaGhZcStZS3VoNlozK29BcjhuWklkUnl4dU9X?=
 =?utf-8?B?WGM5TnVMZzdyVDBhRGJ4Z2cyNFZOa1pHRTNhK3ZXVnZjSzZobTlLWTRCZ01F?=
 =?utf-8?B?bjV3Ylp6TkR3ajBKR0lFVVRSejBhcDBDbWpNZ0pOd1d4VkpnZmd2RWU3ckt3?=
 =?utf-8?B?RXhSQlNWcTdWQ3BtSXp2UnJXeVpsS1RYa1dvSk02NWxhYldNZmI5M0sxcHMw?=
 =?utf-8?B?Lzl4eGMzdURzcUtwemF3QVVjdHFGbXpFZUllRUd1bUVFbzI4NzJtc2QwbG9F?=
 =?utf-8?B?NWMxeGdZajIvRlJ0WjRpREgvbkJTSVZxT3JITExUT1JpTzMwcElqSWpQQTlv?=
 =?utf-8?B?NGlMTkpmaW1DdXhNMEpVQXJmUFJkbFJWNXV1c29aMGd5WkdBa3VoU2JsYStK?=
 =?utf-8?B?SUU3YW0xYzZWbmFzU1NjRXFhbzZtODZobU1nTUE3eG5MNHZDeW1nWEhOWmln?=
 =?utf-8?B?Um9tZjRzRjk5emtPRzNXZFdHV3dDWGJUT01xd1dBQVVNSjhpMHhLMVJSMGNl?=
 =?utf-8?B?YlFQNTRrL1FPVTVOZ3JhcHl5NitFZjlQYXJKdUNXc21nZEN4eHFEVnRPemVH?=
 =?utf-8?Q?NU93SUx7f23609EG9GIFedbDBXPdzUs3Lv2kCZr?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 09df3434-6121-4df1-c72f-08d99207dbe4
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2021 07:21:10.4423
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: i4SfCnswNhUVSLQ8xbJ8sK7x2UmQFEkVUNQVWJz84jEmF40oFOWocCDaiKXop/KrRi2XDTh/EBhHuDg0pl3xli90CUfJSDDIJFe+GRntHus=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5776
X-OriginatorOrg: citrix.com

On 18/10/2021 07:44, Jan Beulich wrote:
> I recall checking that "r" would still have a user, but when doing so I
> failed to recognize that all uses are inside a CONFIG_HVM conditional
> section.
>
> Fixes: 9f4f20b27b07 ("x86/shadow: adjust some shadow_set_l<N>e() callers")
> Reported-by: Stefano Stabellini <sstabellini@kernel.org>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>


From xen-devel-bounces@lists.xenproject.org Mon Oct 18 07:47:31 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Oct 2021 07:47:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.211730.369369 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcNMa-0001rr-9q; Mon, 18 Oct 2021 07:47:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 211730.369369; Mon, 18 Oct 2021 07:47:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcNMa-0001rk-6r; Mon, 18 Oct 2021 07:47:16 +0000
Received: by outflank-mailman (input) for mailman id 211730;
 Mon, 18 Oct 2021 07:47:15 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=628V=PG=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mcNMZ-0001re-42
 for xen-devel@lists.xenproject.org; Mon, 18 Oct 2021 07:47:15 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 9b1caae8-2fe7-11ec-82cb-12813bfff9fa;
 Mon, 18 Oct 2021 07:47:13 +0000 (UTC)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2108.outbound.protection.outlook.com [104.47.17.108])
 (Using TLS) by relay.mimecast.com with ESMTP id
 de-mta-25-3_jM1QqIN12wt6_e48vr-A-1; Mon, 18 Oct 2021 09:47:11 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0402MB3534.eurprd04.prod.outlook.com (2603:10a6:803:8::27)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.21; Mon, 18 Oct
 2021 07:47:09 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.018; Mon, 18 Oct 2021
 07:47:09 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6PR10CA0027.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:209:89::40) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.15 via Frontend Transport; Mon, 18 Oct 2021 07:47:08 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9b1caae8-2fe7-11ec-82cb-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634543232;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=LGNuHK/ycs3TRq7mbZuf4wdWnWMhifvOvkq8vtsDVgI=;
	b=nK3RD8+Ct1uQ2QUwf1lkCbxPMaShJmDLegKVQ2iNM3vW8CyT4G2IqhTgwSpadPZ2tEIo2j
	CvaUoUEcHRUwGBX0YiGLd57ILfvRCZ6PU2j4v/j5n/77ok54Cw+JruaNKZ0zLUEAOVdqYD
	UKqUy9P0+BNtQ4xU4xm0pRhlyadXtLY=
X-MC-Unique: 3_jM1QqIN12wt6_e48vr-A-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=UD/YMWuegoh83KZ5q2IRwKJ7BdJnS2klsUne/x0WCkhZsytVVQe+o2RRGdMxaCRQSNCmPIS646aM9E9jjCaRHyXfPzeDqvqkFUMkldQZ2ltClRfmlAV/Au4DWuTx3QBqc0aGTksRPYT57ar16sDXyie/fz0k7qnWLpifaWQAcsCxSWGz8r4kFREWWlNXUgtx4MDrDlZ+RQykhv+O0tRe1U79GD/9OiRFKqwLtBdDpfQutlut6+SdZPgzTsrlKAKfdfCpTknoomM4TMBeCe4VaYk7xFpsaUCLA8rTEZemjNG9ZGaXkIeNXRiN3dh0GTD+RzpkjOUdz3iDInc73i6Zrg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=LGNuHK/ycs3TRq7mbZuf4wdWnWMhifvOvkq8vtsDVgI=;
 b=C2GUpjCK/w4CA6UBC45yk6ICJLBUJhujeQZIGKa8NHKNsDA3A73s8JxlVRAIRdZ8D+tiwPUT/x/lXtH7pXwNvD3lY3sLKVQfNNtkZAocptQsuk2XS1ndrpFRC9cWF8sVyRnvyDx/cY3FU8LSHXOufivLvAcJN9bjRiHKlEz5MxX2jyDjom7PIuMHb9Pubud7v2Sh/ke+jQ5JJwjHFv9E3gy7IFMm7jWVpNnm1IraexK6ELqeNdl/5TDxo8/J3SEs9/8Uf5kMCfgOa2I58NCNdF/GV9UjtvsSo1SD3h1xDX013frvOrdl3vU0MEYshxFiKLO80ixXKWorah9egsNU/A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [PATCH v8 2/5] xen/arm: Enable the existing x86 virtual PCI
 support for ARM
To: Bertrand Marquis <bertrand.marquis@arm.com>,
 Rahul Singh <rahul.singh@arm.com>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>
Cc: iwj@xenproject.org, sstabellini@kernel.org, Julien Grall
 <julien@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
 Paul Durrant <paul@xen.org>, xen-devel@lists.xenproject.org
References: <cover.1634315461.git.bertrand.marquis@arm.com>
 <e2b10f56043155e4bb8eae824723045ccc042f8e.1634315461.git.bertrand.marquis@arm.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <ca5558b2-25c6-90d2-284b-03cbbb02691f@suse.com>
Date: Mon, 18 Oct 2021 09:47:06 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <e2b10f56043155e4bb8eae824723045ccc042f8e.1634315461.git.bertrand.marquis@arm.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR10CA0027.EURPRD10.PROD.OUTLOOK.COM
 (2603:10a6:209:89::40) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 7305aad7-6b38-4ab7-27f1-08d9920b7d2e
X-MS-TrafficTypeDiagnostic: VI1PR0402MB3534:
X-Microsoft-Antispam-PRVS:
	<VI1PR0402MB3534129C77AE3046043E78D9B3BC9@VI1PR0402MB3534.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	N7Fs5gUIIbQRV0OyKyqjAbPuE7UBWJZGsgFr+pIpbNXxgdYs+pOdoL7met6Eynt4ijKzK2LY0c9GY0fNn5fPYmAIkzewf2hS/z9LgxZcG0Ga/ut5Hv2I2Iz4nk7d8+OsVpHTbCxbgFF+aH5K2yAdEXXyUIbBSkcvZ+9Xaeu36iX2R+7amp6xassOVicBAbsray1cWcfSEWFF3N894uPqT3upyzfS9D5sWtxIzwTAzVgetPq8PjVPjs4x+urMuNhx5S4spbP0tFMJUm0Sb8oTRbsFlR8l16UcH+EOrz5PylxNXu3Mz/F6x3rtYOyMxS4LIupv4j6b0WG6sAg5wzoOHpL69KYYfb2h1KIaW4ZeHv58tMWdJZ2xT1S/1tjLC95LaT/7CJg48NcY7DvO/XrDpqSpDQsp015SfP7c8P4BkBzmX7oNGN8DuGUvsZgOs4ZsVrpWgphvuOA7yrnH0trz9Z9BfSTKwOFqsXgePkdSqCLrFcybRDBYMB0RY9I0Zbqre1RTvui6gXEhtReDFvju8d1aaKgd25+ALGe7DFptEgODwrfbnLpR7V+QUulVvzOBUuqXISxL+IFBOIMVBsj97XeYiF8vPKUbYtTBcLZRNY+ucc1ryvvy4UB86pCLbQKGrPLgMfREeBqW7Y3aMVVxKEBUetkjdQdSHt7oitBLcwHMOdXlumkQbr+FUb96+tAI2QRhxKuVwUpT+exxyfMHXsLGeZaLJDm6WbwgAkEXxRhACW1xguUZxT6i8FroMFe7LN9G959TlLN9aYk9CCoYeQ==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(36756003)(6486002)(53546011)(83380400001)(956004)(8676002)(38100700002)(16576012)(186003)(8936002)(26005)(31696002)(2616005)(66556008)(66946007)(66476007)(5660300002)(54906003)(508600001)(2906002)(316002)(110136005)(4326008)(86362001)(31686004)(7416002)(2004002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?bXRsNVBiMVJPUDB4VG5aQlNQWUVUcmFyVkRMeHNBRjVZaXhUcGZxOHh3bjI3?=
 =?utf-8?B?bXdtK2hydjVCanFGZm1pSGEvZXhzVVBHQjRwcW5NQ2labHNYMnk0R3lDQ1A3?=
 =?utf-8?B?UUtGMHN4ZUt2blZUM2pubUk5R0tyaWplNEFCV3ZYUkhmRFAvNzltNEd5UkJU?=
 =?utf-8?B?OEcrNFJVVmNMK1MzY0huRFBTZHlHbDBHdVFUQ0JneU1jdFVHS3lWRzlBYWd0?=
 =?utf-8?B?Uk50T0FhdVR5eDVmSU8wUTM5S0FUL0tCRTJBWmw1S21pd1RFOW40V1MrUFd1?=
 =?utf-8?B?bnJSSGRSWmNQdThwejFSa3BuWjlkWWNQcEQ5bnlscTFEblkrQ0ZmMVhCaEp4?=
 =?utf-8?B?dEtFRi8zUGFXZDcySFlOY21IbnZNQkxSMkZsOWFsZnVhODhXdGlyRnhWWkNa?=
 =?utf-8?B?YUR5cC94cFhZVlE1amR3Q3RwdFlmZldncUVZSTVnamdOcnI0UEV3eWVDQlN6?=
 =?utf-8?B?clBXUnMyV1poNEtsNis5aVFudmlvWkpVZVpYcjRrQVE2VFdiRExIV1J0eTNh?=
 =?utf-8?B?aDZsK2NhNVBBNkhhWmtwbkd4VUoxRStxakZ4VGdtc2w2ZjdnckJHVnlpVGxw?=
 =?utf-8?B?Y01oK0hiYTV4Tm52V1czbFQwQSthY0JycUVBTzRCMWx3bHk4bDh4Vkd2bHJ5?=
 =?utf-8?B?OE5mYXJQUFFKcU0ya3RyY0wxT1hheXRRRjlla3BZSnpqdzlLVGhUVmhhY0dH?=
 =?utf-8?B?amo0a0FsQTc2TGRoNGQyMGdObkNkajM3aUtmZ0tEcWM4b2V4eGNLQklqUGhh?=
 =?utf-8?B?TzZ0UjBhZ1krRmFvdnkwQzhiY05ZMjd6cXY2bDByOWcvWG1KdkhwNU1QT3Bt?=
 =?utf-8?B?MVkxMXB6RTB4RVgrREs4ZHNVRTlwVlN4WEV3OUpIR1QwaE1LTGZ2WllMRG1I?=
 =?utf-8?B?SkpVWHA1TDNGTk53UlpFekN2cU00SDFrRTd2cjJ0YldCaWt1VWg4RjdFL2tT?=
 =?utf-8?B?UGF5d01pb2l3eXdXZ3Z6U2ZWZ3lqRWFUc01HWWJ4Z3JOUmMzeHBRdDdSeE1t?=
 =?utf-8?B?Q2F6M2NBQVZIN2RmblVDYVI3NjdkVmZIeWQxQWlUOXA1VWNFYVRpOFFpVGo4?=
 =?utf-8?B?ek9mMnFsRFNWZmpMVnhrTDJINlpZNTV4RXBvalNCMEtEd2pLdWdqTEhSTEEx?=
 =?utf-8?B?OXBuNFlsOGpLK3NWNWZlUE1ndmpIY3VHT3RVYlFLdko4QlIreHJtTEpGQVB6?=
 =?utf-8?B?NndxZFZMK25BN29xRFdWQTJOM0ZpMlpaMUhQcGhRbGd2ZDlaRTBZQnV2eThi?=
 =?utf-8?B?TTBnaFRWZFg0UHRobzA5bERjTEhSa0RLVkRXeUNVQkF1dFZ4SzZaTlpmT00y?=
 =?utf-8?B?N2hVaTFUTUVpZ2h6OUMxQitxc3UyZjRXd0JMdjZyWnc5TjI2dUVFeDhlZnB4?=
 =?utf-8?B?d1V1T3VGQkxZbkRiU0VsbmV6Q2VSNkozRkdRTlpVQXRRYy9zdlF1cUpBbjMw?=
 =?utf-8?B?WjF2aitHSmdJVnRTNzE2dzN2ZXNmeDdXU3NmVnVKN1JDakpLV1V2RldDVG8x?=
 =?utf-8?B?aTZZVk1qNUhQN2Uzdm12TCt1MzlNN3gybTZPQThtaURPQmRNbndPZmkxYjRW?=
 =?utf-8?B?S3dHb0FZdnRHTFNaZ2ZkMGU4NFNSK3N6N0J1bHhRQm1lOGgyQVdYamJ3OFkr?=
 =?utf-8?B?TExHQ2hJZEwzZ0piZ2RRSkhiVGYrb3kzZ1VrdWVlYzhMTVVHb1JFcURzenNz?=
 =?utf-8?B?YUlYQmwvaDJWSEhqcWZjVmlXVVd5Slh0VmcyR240aXlLQkg0V1VHYk0xaUoy?=
 =?utf-8?Q?G2R2AIvF5Sl3oPYMyStqCsDJZeN8sW9BnGezDx8?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7305aad7-6b38-4ab7-27f1-08d9920b7d2e
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2021 07:47:09.3047
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2xLaS2YxbfghTob+nhH4Pt8L1ThSxDp2WmhspQSvePbF/m2zLfTCO/6DJLysHFBd2QJBbqgnWnDsyMlcb0WUSw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3534

On 15.10.2021 18:51, Bertrand Marquis wrote:
> --- /dev/null
> +++ b/xen/arch/arm/vpci.c
> @@ -0,0 +1,77 @@
> +/*
> + * xen/arch/arm/vpci.c
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; either version 2 of the License, or
> + * (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + */
> +#include <xen/sched.h>
> +#include <xen/vpci.h>
> +
> +#include <asm/mmio.h>
> +
> +static int vpci_mmio_read(struct vcpu *v, mmio_info_t *info,
> +                          register_t *r, void *p)
> +{
> +    pci_sbdf_t sbdf;
> +    /* data is needed to prevent a pointer cast on 32bit */
> +    unsigned long data;
> +
> +    /* We ignore segment part and always handle segment 0 */
> +    sbdf.sbdf = VPCI_ECAM_BDF(info->gpa);
> +
> +    if ( vpci_ecam_read(sbdf, ECAM_REG_OFFSET(info->gpa),
> +                        1U << info->dabt.size, &data) )
> +    {

Here it is quite clear that the SBDF you pass into vpci_ecam_read() is
the virtual one. The function then calls vpci_read(), which in turn
will call vpci_read_hw() in a number of situations (first and foremost
whenever pci_get_pdev_by_domain() returns NULL). That function as well
as pci_get_pdev_by_domain() use the passed in SBDF as if it was a
physical one; I'm unable to spot any translation. Yet I do recall
seeing assignment of a virtual device and function number somewhere
(perhaps another of the related series), so the model also doesn't
look to assume 1:1 mapping of SBDF.

> --- a/xen/drivers/passthrough/pci.c
> +++ b/xen/drivers/passthrough/pci.c
> @@ -756,6 +756,19 @@ int pci_add_device(u16 seg, u8 bus, u8 devfn,
>      if ( !pdev->domain )
>      {
>          pdev->domain = hardware_domain;
> +#ifdef CONFIG_ARM
> +        /*
> +         * On ARM PCI devices discovery will be done by Dom0. Add vpci handler
> +         * when Dom0 inform XEN to add the PCI devices in XEN.
> +         */
> +        ret = vpci_add_handlers(pdev);
> +        if ( ret )
> +        {
> +            printk(XENLOG_ERR "Setup of vPCI failed: %d\n", ret);
> +            pdev->domain = NULL;
> +            goto out;
> +        }
> +#endif
>          ret = iommu_add_device(pdev);
>          if ( ret )
>          {

Upon failure, vpci_add_handlers() will itself call vpci_remove_handlers().
What about iommu_add_device() failure? The device will have ->domain
zapped, but all vPCI handlers still in place. This aspect of insufficient
error cleanup was pointed out already in review of v1.

Furthermore already in v1 I questioned why this would be Arm-specific: On
x86 this code path is going to be taken for all devices Xen wasn't able
to discover at boot (anything on segments we wouldn't consider config
space access safe on without reassurance by Dom0 plus SR-IOV VFs, at the
very least). Hence it is my understanding that something along these
lines is actually also needed for PVH Dom0. I've just checked, and
according to my mailbox that comment was actually left unresponded to.

Roger, am I missing anything here as to PVH Dom0 getting handlers put in
place?

Of course as soon as the CONFIG_ARM conditionals were dropped, the
__hwdom_init issue would become an "active" one.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Oct 18 07:51:19 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Oct 2021 07:51:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.211740.369381 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcNQU-0003Jp-Vq; Mon, 18 Oct 2021 07:51:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 211740.369381; Mon, 18 Oct 2021 07:51:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcNQU-0003Ji-Rd; Mon, 18 Oct 2021 07:51:18 +0000
Received: by outflank-mailman (input) for mailman id 211740;
 Mon, 18 Oct 2021 07:51:17 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=628V=PG=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mcNQT-0003Jb-LS
 for xen-devel@lists.xenproject.org; Mon, 18 Oct 2021 07:51:17 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 2b80e1da-2fe8-11ec-82cb-12813bfff9fa;
 Mon, 18 Oct 2021 07:51:15 +0000 (UTC)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2106.outbound.protection.outlook.com [104.47.17.106])
 (Using TLS) by relay.mimecast.com with ESMTP id
 de-mta-14-t6pQhcLQM3uBaZLQEGmzPQ-1; Mon, 18 Oct 2021 09:51:13 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0401MB2334.eurprd04.prod.outlook.com (2603:10a6:800:29::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.17; Mon, 18 Oct
 2021 07:51:11 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.018; Mon, 18 Oct 2021
 07:51:11 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS8P251CA0002.EURP251.PROD.OUTLOOK.COM (2603:10a6:20b:2f2::15) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.17 via Frontend Transport; Mon, 18 Oct 2021 07:51:10 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2b80e1da-2fe8-11ec-82cb-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634543474;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=FknbApa2PAo7adaUdVHxba5J4xeT9MoJ8JZDuiScedE=;
	b=J9xVzToeOLuM8NWK8qIoY5SJ/Xd6cJ+aWxfnD0g3IXYsONSkf1N3SZBC1kn/SArE5IyAQs
	EGDTBP8UN/5m5sj6oWUQWNQ0ueSx/2HR2T7nh9tnMDG7Bv+K0Z9bBH64Y+9c9C1r7Gw/PV
	+F7lFPDJ/sc94KRsPUHI/QtgYHD3f4k=
X-MC-Unique: t6pQhcLQM3uBaZLQEGmzPQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=QYQZxuq9Oy2P29ug11XL97EhzXja2NBFVK1X2IPXyxVtjbpP8zMvSXsGE4qrY/BqQ2L4TpFC3EuyrTd7X5E2GKXjYl9olRbSE3J1XOxbLNFJvaSq7GhuSiBx5VDGexIape6Ph+nDDnxDzMX4ml7ZwONH+mEVFceshUmzW8zXDHp9q0GUgySymztLUowAE9moBqeRZmNz0iCtlwQkbRqDcc4G0CwXCL+N2UK6Xo43LUFQbVtKRb/UfIh32ZzWW6c5Ol/7e9EMCu1deaEWmrpu9nQNRrH6n2LcRK783ZwXyMcl8ntTcyZGW6DHSo0h9x6YEuG2DnyjcpXVN0LOeLGL9A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=FknbApa2PAo7adaUdVHxba5J4xeT9MoJ8JZDuiScedE=;
 b=dzhjhhH2NKECbw5NVO15SefOYk8z54NRrFQoKTWejknZUIrMnp4w9cJ+zFzCKo9HxkR/+WW6aFFlmTZgyZ8CjwcxLe20c0fKuMXMGxw8c1z/bFhYA3H1qeB/skn6XOqLlHWpNqJDj58+vWXB3YSwGugY/+RQxkE4S/CtSs0bgP3Uok1NftiwqqH1ZFxQqqrmNZir+EsJ5es60Xf+iqDJb2b7Rfqeh8zMdc884/BfRtujAOwHnz6bXituuhd0DsOJS5cGVwoSveAfZBs9IeARL5/W2SlaXqVRhYpZW2P/MCOp6xNKYEAv1xCJl5DdsRDPp3An3+WBfhT26tQzbC1puw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: xen.org; dkim=none (message not signed)
 header.d=none;xen.org; dmarc=none action=none header.from=suse.com;
Subject: Re: [PATCH v8 2/5] xen/arm: Enable the existing x86 virtual PCI
 support for ARM
To: Bertrand Marquis <Bertrand.Marquis@arm.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>,
 "iwj@xenproject.org" <iwj@xenproject.org>,
 "sstabellini@kernel.org" <sstabellini@kernel.org>,
 Rahul Singh <Rahul.Singh@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
 Paul Durrant <paul@xen.org>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>, Julien Grall <julien@xen.org>
References: <cover.1634315461.git.bertrand.marquis@arm.com>
 <e2b10f56043155e4bb8eae824723045ccc042f8e.1634315461.git.bertrand.marquis@arm.com>
 <cef8d2a6-91c1-2d4d-2078-98d0a92b067a@xen.org>
 <F447A1D8-A023-4127-AAC0-7511868DE9C4@arm.com>
 <a45077dc-e144-4427-9ae2-5815045ecaec@xen.org>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <f77c42e2-4a3c-9e28-25c5-b23efffef25d@suse.com>
Date: Mon, 18 Oct 2021 09:51:08 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <a45077dc-e144-4427-9ae2-5815045ecaec@xen.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8P251CA0002.EURP251.PROD.OUTLOOK.COM
 (2603:10a6:20b:2f2::15) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: a27dd519-8add-4e79-6221-08d9920c0d59
X-MS-TrafficTypeDiagnostic: VI1PR0401MB2334:
X-Microsoft-Antispam-PRVS:
	<VI1PR0401MB23345B31AB43751990973BC5B3BC9@VI1PR0401MB2334.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	N3iKni3xzndSQn9wq4grOva3SBEGyLFsMywn8t2OgLBA4qrf3d1e91K35+zyij6pyMwxDNlS53NOnfofBGBgAq2F6sHVZBVxTmXw+wLvESPoDtUhqQKvaJSAVBTO8Tgpa0qXcBWJBSjb540KAeq2V/L22jydHWWe3H21qi5dzQiGwdIr2ELzU1nCcSPgJhWzvUzVF0VqYBDPSdeVJwcBCwJhT3uVw7VvlgR9H17aiu+64fRB+hAwKeWWAr4jKtLQKam4qy04rRkTJwBSQtUwioxxPS1vni/SmoI1y1NOydsDF2FAywv8WUzaQ1SKEf/fhl+qWGKNCtCVo6E0wK0U3cHuXmcwXhK+dwmQcrBetmPdjSJ0hGMby6YDmU4LpUChZfuRO2+EuW3h3k1840sflx79/JDXvD5WNKZHUc8C3ur93EWQDwdU2YeosUXjpFgeYi2Gr5TTm4hZShRp9++OHa0pfx9RWoEPt4I/JUyP1qmCpBDVJqWvQe/zPERwDcMKemtNr0gW8LV6Z45AIMCwiSzlPlVKbOiYeyqYAQttSce8YfITLp0wKQxf6sNb5lU3Az3cCE5wsw7CATVZVF5oiwtFLdXuHtdtPfFVoP0zDFu+3RUHtrxGNVdrF3kkfqN83kPfwnK5J7yov1xz7SIVT7DbIHEOkE9QAV0Ttgm7dcVlxvxFRJnzWE8RlyqIBtd5WuqYCsdiLQevj5JrrO9VFz0746HzhFmLJTp38DoU9Vh7kMYIRGcBCjCjndXmtk0n
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(2616005)(31686004)(956004)(31696002)(86362001)(6486002)(83380400001)(4326008)(16576012)(7416002)(316002)(8936002)(8676002)(2906002)(54906003)(6916009)(38100700002)(186003)(5660300002)(508600001)(66946007)(53546011)(26005)(36756003)(66476007)(66556008)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?b1dYUlNpS1Axak5GNEJ3V1JYdTAzbVR5SmRSVXR0ek1sbzhaZEVkdlZ4STl5?=
 =?utf-8?B?WHNPQ2EvWFRjczVnVUxLKzJtN1RkSjRYbTlTb0VKbUpRbUlOM1d2L256UlpS?=
 =?utf-8?B?RitSdTVjQVI0U0h5bHRVY2tTcHlhTlpjbEs0c2VLWkFzZ0dKVjNXV1dmb2Nl?=
 =?utf-8?B?ZTU1eTlQcmRTVDVlYWg1Z0F2bFMyOWcwWGY3RXprc3lEQTZlNXFxOElrWlpV?=
 =?utf-8?B?WGkzUlhWRTFPY0Q3NU4xd0lqS1hWaFJvTEJ5UnloajVBY3RMNEhtbnRZTExI?=
 =?utf-8?B?NXU3b2gybG4xMkFjMTZwemo1NC9HSk9NL2o5ZGRiRndjVU42RGluRXZYd0R2?=
 =?utf-8?B?RTBRVlZyYk1tSHNSTjFQS3RrSnYybkhEWWRPbi9YSWZScjQ3dGgraTRsT2sv?=
 =?utf-8?B?em80SUNrQnRaY0pxaU9IUFFjNnZ3MWFLVU9SU1RDSEVKd2tVOTU2VkppWTlX?=
 =?utf-8?B?TmJxR3I5MWY2bU1FNDVQdE5OVWxRbytoQTg5UkFkaDV0bDgvemlDTTRqQlV4?=
 =?utf-8?B?WFlDMVVUbEJyajRUTjBNSG0wTkxmUVZhYUV3TzBNaGpOUFptTllJUnhQWnYw?=
 =?utf-8?B?N3A3TmVhckl2K0kvd204b1V3QmQwVUpXV1VnUzA3MTEvL3JVQzdnVTJnTFVV?=
 =?utf-8?B?Q3VsT0RoVGhQL0pxeS9WSGZhMFREMGxkbG94dStoYUJjYmJnQUhpWk1OY2ND?=
 =?utf-8?B?YkRKUFhQa1ZYZFU2dTFIdVFxc0RaWFNxeE1CSmFDSU5zcTVlN2NwS0dpYkM3?=
 =?utf-8?B?SzY0YVZNRXJDUlRJaEM3SlplZUlxOU5yaE1TM00yYmkxWFNaaElKczVHVFoy?=
 =?utf-8?B?MnlSU2lpRGF2N0g2Y2orWHE4WnJVY1IzeVFZZDhERnZBSjFLQk44blNJTWtH?=
 =?utf-8?B?bmlVS01XdlI1RjBibnpSQUFYRHlMbUVoSjhwY1JjVXBKdXcrZHJBWXdOM1pV?=
 =?utf-8?B?d1pockhsRERLMkp1anMyWUEreVZ6ZmoxZVVKdWV6MUtFQUVEK2F3V0VXOFlk?=
 =?utf-8?B?bnZlNTNkLzNJb3BIQjE2MFlLcTY2NTlJdDV0djZ6QVk3RHVXc0krT0hpbUpv?=
 =?utf-8?B?YnFNYTE4Mkd2aUJLWE10RUt5dVB2a2NSZ0paZkZ5RnpOeGZlbEpLTlgvcDQw?=
 =?utf-8?B?MWEvTEVMeXppcFpnYVBvak1XWGxLcndkaEEzMXkwc1M5N2JJd1M4MGkvU2E3?=
 =?utf-8?B?cFhGVjIxcDRhdVY2RjNaMkNQSUFrbnFOZmdMeXJvcVFYa0F3Y1hMN21VUWk5?=
 =?utf-8?B?UGI5TnpXRHlJd3U1QXVGVjBiU2VuTmtWaTByeHZhUGs1bFN0ZWtELzhwWkxo?=
 =?utf-8?B?LzBTRjZiWVZScndRK3BzSm91MmFTVm9FbjdKa0VRNWUrckRJdy95NlpsOTY4?=
 =?utf-8?B?ekEyZzlPQk5kSWxzYitZbVljV2pHZzg3V2ZJUzUvUnhTQWh0TnpKMFljU0hv?=
 =?utf-8?B?NG5wbDNVdE1qcml1ekNvczc1RVMxbU5ybmtPWjZaRjRvckQ0WlE0Uy84Q2h3?=
 =?utf-8?B?cHVHcFJBZ29heUU3K2kyRGdncGdLWE1MMVBycG5ucHd0eDJhSFdkMVpNcTZ0?=
 =?utf-8?B?R0xYcmtUdmlsMFo0c21HRWVxRnJsc1QyUGpHMUpIOG11TzN6Um9aZWNmekFX?=
 =?utf-8?B?WlRZVU55SnZxZW5ZeHd2ZEN2MDE4Z0tmRG5lNm9ydWt3MGl4aHZwN3d4Wlo5?=
 =?utf-8?B?LzEwZ0U2REtFVUMreC9BdXo1a0FVVU5CZTZwMlZQemVZcDBsYk0rZzVaeHVM?=
 =?utf-8?Q?EnPUVwBNZPA5QHlixJrxrbRyv+nB/B45R/sCh8z?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a27dd519-8add-4e79-6221-08d9920c0d59
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2021 07:51:11.1779
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: t6SRWryyq2uqzpDcgutO9UkQEh1oPza55uArz1flrnIUJOgPGIDCc1BvHchMHlL806wmzaY1T17y2IaRyoP/PQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2334

On 15.10.2021 20:38, Julien Grall wrote:
> 
> 
> On 15/10/2021 18:33, Bertrand Marquis wrote:
>> Hi Julien,
> 
> Hi Bertrand,
> 
>>
>>> On 15 Oct 2021, at 18:25, Julien Grall <julien@xen.org> wrote:
>>>
>>> Hi Bertrand,
>>>
>>> On 15/10/2021 17:51, Bertrand Marquis wrote:
>>>> diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci.c
>>>> index 3aa8c3175f..35e0190796 100644
>>>> --- a/xen/drivers/passthrough/pci.c
>>>> +++ b/xen/drivers/passthrough/pci.c
>>>> @@ -756,6 +756,19 @@ int pci_add_device(u16 seg, u8 bus, u8 devfn,
>>>>       if ( !pdev->domain )
>>>>       {
>>>>           pdev->domain = hardware_domain;
>>>> +#ifdef CONFIG_ARM
>>>> +        /*
>>>> +         * On ARM PCI devices discovery will be done by Dom0. Add vpci handler
>>>> +         * when Dom0 inform XEN to add the PCI devices in XEN.
>>>> +         */
>>>> +        ret = vpci_add_handlers(pdev);
>>>
>>> I don't seem to find the code to remove __init_hwdom in this series. Are you intending to fix it separately?
>>
>> Yes I think it is better to fix that in a new patch as it will require some discussion as it will impact the x86 code if I just remove the flag now.
> For the future patch series, may I ask to keep track of outstanding 
> issues in the commit message (if you don't plan to address them before 
> commiting) or after --- (if they are meant to be addressed before 
> commiting)?
> 
> In this case, the impact on Arm is this would result to an hypervisor 
> crash if called. If we drop __init_hwdom, the impact on x86 is Xen text 
> will slightly be bigger after the boot time.
> 
> AFAICT, the code is not reachable on Arm (?).

Which re-raises my question towards testing of what is being added in
this series. Supported also by the typo in v7 patch 1, which suggests
that version wasn't even build-tested.

Jan

> Therefore, one could argue 
> we this can wait after the week-end as this is a latent bug. Yet, I am 
> not really comfortable to see knowningly buggy code merged.
> 
> Stefano, would you be willing to remove __init_hwdom while committing 
> it? If not, can you update the commit message and mention this patch 
> doesn't work as intended?
> 
> Cheers,
> 



From xen-devel-bounces@lists.xenproject.org Mon Oct 18 08:04:46 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Oct 2021 08:04:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.211752.369392 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcNdS-0005N0-6q; Mon, 18 Oct 2021 08:04:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 211752.369392; Mon, 18 Oct 2021 08:04:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcNdS-0005Mt-3P; Mon, 18 Oct 2021 08:04:42 +0000
Received: by outflank-mailman (input) for mailman id 211752;
 Mon, 18 Oct 2021 08:04:41 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=3tpC=PG=citrix.com=roger.pau@srs-us1.protection.inumbo.net>)
 id 1mcNdR-0005Mn-Hv
 for xen-devel@lists.xenproject.org; Mon, 18 Oct 2021 08:04:41 +0000
Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 0ae3b2c1-2fea-11ec-82ce-12813bfff9fa;
 Mon, 18 Oct 2021 08:04:39 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0ae3b2c1-2fea-11ec-82ce-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1634544279;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=K4bXTjPPgPko8ofm7jiQJvczyLzruiAT11T3OlpA2zg=;
  b=Znmyh5M/AuwglIwoqmqrLe/t+VUQ0Ar81w72710mvsuIO/Hx2c4h9voG
   xmgXr7L/Cz8a7M5liJ7JIhWNhulH+FnGiOmw7cd/RXU6xpb0be5BOJ8wF
   B587LMUIuy2XbqtAy4YFemNkrZ6Drmj7mGdm/ajZnvlfzlPb+A9r+we/+
   0=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: 1dyQevWT6WDJAjtQZP2ac+4+kqDQr2HeaiUFzb3+9xDq63nKGXZSfBizK+UlGCHTi9WOSU1VWR
 caQUvk7MNCscokGNyQ2yUwhJyTmUDe/PtQnby7cJxdjSHXx+X8CWsWJSH9C7PyYmLi2E/C58p2
 +YLWvTQ0rkcLS/4HZ7Re2QvHKJqKvJtTx0Rh0Rph0it92wFEKLQrRXNeQ+5uQw5iFh3DC2jVpt
 UGIHmUpZz0TtiwpiLwCqEJmK841uxuNDUP5SpFN0XTCr2Sv8CPN9Og79IAYsnIYfO2PK2V2C1r
 FDRGjUO7tix9MTGz+kvvYC+H
X-SBRS: 5.1
X-MesageID: 55398827
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:JNo7bqNY35FUdi3vrR3TkcFynXyQoLVcMsEvi/4bfWQNrUokhTxVz
 2EaDWqBOP/ZNmCmeYh0atywoEgC657SyNdmTQto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdpJYz/uUGuCJQUNUjMlkfZKhTr6ZUsxNbVU8En540Uszw7dRbrNA2rBVPSvc4
 bsenOWHULOV82Yc3rU8sv/rRLtH5ZweiRtA1rAMTakjUGz2zhH5OKk3N6CpR0YUd6EPdgKMq
 0Qv+5nilo/R109F5tpICd8XeGVSKlLZFVDmZna7x8FOK/WNz8A/+v9TCRYSVatYoz6moP18z
 c1wjLubUixqOrH+28gCYSANRkmSPYUekFPGCX22sMjVxEzaaXr8hf5pCSnaP6VBpLwxWzsXs
 6VFdnZdNXhvhMrvqF6/YvNrick5atHiIasUu216zCGfBvEjKXzGa/iXvo4IjG1v7ixINfSFT
 I1JNiBMVwjrPgNJI3VLWL0yovj90xETdBUH8QnI9MLb+VP78gt117T8NcvPTfaDT85Vg0Wwq
 3rP+iLyBRRyHN6CzTuI9Fq8i+mJmjn0MKoNEJWo+/gsh0ecrkQDBRtTWValrP2Rjk+lR8kZO
 0ES4jApr6U56AqsVNaVdwWxvXqsrhMaHd1KHIUS4gyX1rDd5QrfA2EeVyNAc/QvrspwTjsvv
 neLld70AT1ksJWOVGmQsLyTqFuaIyEVMGtEfi4CQgst6sPm5oo0i3rnVc1/GaS4itn0HzDYw
 D2QqiU6wbIJgqYj1rq51UDKhSq2oZrERRJz4R/YNl9J9SsgOtTjPdbxrwGGs7AQd+51U2Vto
 lAPtPez4eUWMKiqvzemA+ERLvKF+MS8ZWi0bUFUI7Et8DGk+niGdI9W4S1jKEoBDvvoaQMFc
 2eI5lsPvM470G+CKPYtOdroWptCIb3ITIy9Dpjpgsxyjo+dneNt1BplYlKMxCjTmUwonLBX1
 XyzIJv0Uyhy5UiKylOLqwYhPV0Dm3hWKYD7H8mTI/GbPVy2Pi/9pVAtawPmUwzBxPnYyDg5C
 v4GXydw9z1RUfflfg7c+pMJIFYBIBATXM6t95AGK7/ZflY8SQnN7sM9J5t7KuSJeIwOzo/1E
 oyVABcEmDITe1WWQel1VpyTQOy2BssuxZ7KFSctIUypyxAejXWHt88im28MVeB/roRLlKcsJ
 9FcIpnoKqkfG1zvpmVGBbGg/dMKSfherV/XV8ZTSGNkJMAIqs2g0oKMQzYDAwFVUnPo6Jdj+
 uD5vu4ZKLJaLzlf4A/tQKvH53u6vGQHmfI0WE3NI9JJf17r/pQsICv05sLb6elXQfka7jfFh
 QuQHzkCouzB/908/NXT3PjWpIa1CepuWEFdGjCDv7qxMCDb+EulwJNBD7nULWyMCjus9fXwf
 /hRwtH9LOYDwARAvb1jHus51qk5/dbu+eNXl1w2AHXRYl23Ibp8OX3aj9JXv6hAy+YB6wu7U
 06C4PdAPrCNNJ+3GVIdPlN9PO+CyesVin/Z6vFseBf24yp+/bymV0ROPkbT1HwBfeUtaI58m
 LUvos8b7QC7myEGCNfeg3AG7XmII1wBT74j6sMQDrj0h1d50VpFe5HdVHP7ucndd9VWP0A2C
 TaIn66e1a9Ez0/PfndvR3jA2e1R2cYHtBxQlQJQIl2InpzOh+Mt3Q0X+jMyF1wHwhJC2uN1G
 25qK0wqevneo2Y23JBODzK2BgVMJByF4UigmVIGmVrQQ1SsSmGQfnY2PvyA/RxB/m9RFtSBE
 Gp0FIoxve7WQfzM
IronPort-HdrOrdr: A9a23:9ygcMqDq9+3IlnHlHemZ55DYdb4zR+YMi2TDgXoBMCC9Afb5qy
 nOppomPHDP5wr5NEtMpTnEAtjjfZq+z/RICOsqTNSftWDd0QOVxcNZnO7fKlbbakvDH5tmpM
 Bdmt9FebnN5DZB4foTv2KDeOrJibO8kZxAL92ut0tQcQ==
X-IronPort-AV: E=Sophos;i="5.85,381,1624334400"; 
   d="scan'208";a="55398827"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Ipjy7lTwiboGV1RDAak9wUnT6AhRK/sKSIedEIB6ugIQIR6rLLiCUeLlKYpeIibFSsH1jO+AWK9wzNBaSz8z9WceO5lC9DpirmWF7IMFE0lJotxGSrwfwD+cP8xPnEWiFPEdmMq/xfks6lhxXTH8177903mN8VyWxKevlchF2niZrXuEbS7WAk+Hec5CUL1fdOPnyJwf8lNeLrp5bjyuCbLyD45DMcIbEPrI5hLZEoC5ps44faZaGe1KtF12YKKWTrAp/PDAaiGE0OcvJ0w5UmV76V5buMBvKymPNTRecV5bsEa2LEkgTEtF2hsYTyNVdgStr98dS5D5CY8V3OodfA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=xCGL8SNFNpLLM3D06NxF5xSBXoQ1UwrVW4z556ysmOc=;
 b=dLPtfRVqJwYBZd1Tl2ILdqPR9cg4H2Z87wvnAQS6HeX8422956K08uK1B/8ii63im4dCDwX8kfwW52sSM4ocSYFfO9X0nwUMU8AOwmkIVRbWwlcsVSFefIYI3lUaHs2pGN6wHK7Ur3M9xN4AocH37d+QqVedR6meMH8OP5r1fZAbHN47WrpOZv36U5fPIsgT4RlCstWHR50h6TK2BquoosSxaUxJglZtctuA/9Uz6jKmvpt5WhLUu4OPGs7ZdxyZdmRy6hl1uzDG+/+rShMr+IaZNYmP068GSOJJZXARuw4U2l4VF3Z9KKly18uz4Vf+9rjgqjZDxeQQXCH/xDMKKA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=xCGL8SNFNpLLM3D06NxF5xSBXoQ1UwrVW4z556ysmOc=;
 b=rg4HAoiMm48JI70lb3TbkXfxqK3TghTmDzKUH4egSyXxeKo/+D8PhsSRqNGLxjsy4SpxfwAKBpVKaooU07TQULa07chvuPA8BzRmNo793iDY5f4nG++WEKZYBu2RXPL8G7l/uTSUZPrArxOMNZSFjNd9KC/ZM1zLl4nI6ee17UE=
Date: Mon, 18 Oct 2021 10:03:55 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Bertrand Marquis <bertrand.marquis@arm.com>, Rahul Singh
	<rahul.singh@arm.com>, <iwj@xenproject.org>, <sstabellini@kernel.org>,
	"Julien Grall" <julien@xen.org>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>, Paul Durrant
	<paul@xen.org>, <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v8 2/5] xen/arm: Enable the existing x86 virtual PCI
 support for ARM
Message-ID: <YW0qa2CXcnWZNCf7@MacBook-Air-de-Roger.local>
References: <cover.1634315461.git.bertrand.marquis@arm.com>
 <e2b10f56043155e4bb8eae824723045ccc042f8e.1634315461.git.bertrand.marquis@arm.com>
 <ca5558b2-25c6-90d2-284b-03cbbb02691f@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <ca5558b2-25c6-90d2-284b-03cbbb02691f@suse.com>
X-ClientProxiedBy: LO2P123CA0035.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600::23)
 To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 5e271659-a088-480d-1760-08d9920dd7cc
X-MS-TrafficTypeDiagnostic: DM5PR03MB2779:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <DM5PR03MB2779EE41BA1A849BBE4ED28A8FBC9@DM5PR03MB2779.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: SejfcdXNm373AICP0kakrlChVnxYVYmLvwPCMQQCVApUYLXZb5eMZdaq9cGMsHE37Etxkr51XV9/5gOO5lCND/F23U7SSasgaSmjwQ3TPTe9R58Bhbkh4Q720SOkiFeDH9Qso/wSmZImrfMn80s0sDiY0ruUTpfGgDlxyXOrwhqeVcsv94M71HEiRLKucxVMiIatGccjh2q+x5AgXKKOO1xbYS6s/BCIlt1Sis37t8xHUB+M6QE5jgF99gFgT5chye+O+0WfjI3WP9fSn6Emj5lghbNQ4yW2hrRfnF398UV4jY047RrkD641j4PC/Z0xECfjEQaFy6G5dZNlNJ97wLM1SUAj+0EXGMkpMmQxBbD5Qic6IsS2RhSHQI15Oq50bdrzy3eBrs8i6nfgQAZvUQPk84zlYVfQJP2zItaR+Ge8aa33AdG0Kt5RjW25Nr+X713I7rundeOzsaJoMbO82On5OcI8oG4XZs8WCTsPLgDxlIMKnto0grNxCBBN/BZPn68ZVQZZvfxaQ1KBnAWBKR3OPbxEcx1wqeXhFMoeWgiWc5IE341GhRdBNra2GALGZxC4myPevfqh89welOY/V3s4QOOTE4QPoTppotthDXhBk624pujzKNoI7WAO6kfraLOZAku61CDlx7f8cLrC3DkKEXjZS5MLwVWPdQJ87jWRDfilBw8t4jA3A1WgTsRi
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(6916009)(508600001)(82960400001)(2906002)(8676002)(85182001)(7416002)(6496006)(5660300002)(54906003)(38100700002)(8936002)(6486002)(6666004)(316002)(53546011)(26005)(86362001)(956004)(186003)(66476007)(83380400001)(66946007)(4326008)(9686003)(66556008)(2004002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VzR2aHgvQjhXNEc3MC85WkUxd3dvS1orclFYb0VGblpsaFQxWTN6YkZMWmI3?=
 =?utf-8?B?Mk9TaCtvMDltWDd6S053TS9BUlE2R1g4c1pXMXdTQ3ZJaklpY0MyOWxWSGdT?=
 =?utf-8?B?QitOMmdXN3c3RWxzTFpiK3hmSTlQeEIyUDJ2Ty81NW5XcVBQakhURm81Uk1n?=
 =?utf-8?B?VmNnTzRDZ3RVUVp4dERiWkVzaTA2TVEvc0d3bWlqVjBaSUFYYnowdTNYQWxt?=
 =?utf-8?B?cWxYZU55dWFKMzNGUUVXc1d2SEpXakoyODZ0RzZHa2ZHLzlwSklrWWxzOWJH?=
 =?utf-8?B?REFaaDRxV2ZtM3B6MFFRTkNNeExOMWFRSmN1N04zZ0VIejJSTmo3eWNUQ3Iw?=
 =?utf-8?B?NW5MSmRrcTdYSSt4TUpPY1RHWjZsWEhiZTlMNWwrYmpFSDJSSDJDOEVKNmw5?=
 =?utf-8?B?OEtRR0IwS3FRTnRHbWdkbjZkOEMzenpNdkFLNElYL3hQYnh3OEgwQ282ME9D?=
 =?utf-8?B?VHNTTndPNnplT1Bsc1U2MDFJNkt4TEcwdklWcW1kSjAyc21JYmJ3alQ1bnpv?=
 =?utf-8?B?dWpMZEJQWWdqMjBYT080RU5BZzJncjFzM2dJSUluY3o3QXU0Z1NKUGFQQkNG?=
 =?utf-8?B?NktuaTduc1dJdjc1UE5PeVNYV3p0U3FOU0JIdEo3UHN6anVSYTlZWStwNkxq?=
 =?utf-8?B?bHlpV0tTTnc4SUlxYm13T250dVgrM3EySWIvcFVnYzJwSjZYUU1KMjJnb2Fx?=
 =?utf-8?B?cExSTXZueVM4TUdrZm1NcGlrWngyWlB3VUJhSjM1T1c3MlpqWVNXU0h1dHZO?=
 =?utf-8?B?SnBDcFU3REI2S1VHWFE1S3p0YVRYc3E1ZXMxYk9JMWhEaUh1YWFiWTNlY0NZ?=
 =?utf-8?B?ZS9nR0QybjNnSno3Rk15ZDRCcnBiSkt2dzJtV3Z4Ny8rdzlNa1IvbTZpZEFP?=
 =?utf-8?B?dHJYVW5sRnJKam85Vk9PbW5FcFFIdHhOSWo3bUJmQmtZeHYrMThjYWU1eWhl?=
 =?utf-8?B?dk1FMG1XVEF3TzkzZHlhT1UvV0tLRGx5RW1aTVNHZzM4MlJod2IyUzk3WXNT?=
 =?utf-8?B?S21VT0dsbS9qa2hNVkNYMTE2VXFqUnVNaVpKM1gvaXVYck5jSFh2T1Z4SnR4?=
 =?utf-8?B?QW16RFVyV0JIemtRamtGaGErc1ZJMjZscDhtWnlldzh2U1p6WmN2V2lPSndp?=
 =?utf-8?B?eGMrSkRuVTRFN3VuamJ3Q1lwNDN1S2QxaFJJbE5XZlRtK1VUWmp6RWRCRC9j?=
 =?utf-8?B?clc2aFdld0xQd0JqUjBHVTVjQmk2Q3E1YnFTbjEzTm1RTzE5RmhWbkZhZ2Jp?=
 =?utf-8?B?cStieGZ5Q1JrL0JBN0N6bzBtb2RGbmtoeHE5OGJQbCs5V20zY3Yvc2dheGtn?=
 =?utf-8?B?L3A3VFhiTGE4OHl4MWFTSEJwRDIyNDdUWVR6SmxCb2VhcXp1Vis3SkR5VDRL?=
 =?utf-8?B?b3c3SjlRQmVZU0ExMTlZVUxsZFpQbDVWQjRybW4rcnEweGJtOFp1WTJpNWw3?=
 =?utf-8?B?SmQzQTNiR1NidWhXOFdTVjNaVUdOczI5ZUlNR2J6R3RSdFpKbkJKWGpQZHRX?=
 =?utf-8?B?UEd4ZjFtdUpiNjZxNytFYW5GUVRwcmVvNmVBa01la3JjWWo5dXR1Sk1DOElu?=
 =?utf-8?B?L1lUeUVTU1kvK1BnZURtaXRFYWprVHVtOW9BNmhid3Z0N3FzQ3ZwZ0xyYTJZ?=
 =?utf-8?B?YUx5OEpVK1NNU2pKQ2QvUytJS0JaQlJEbERjSkZsKzNRWHZXTHcveEdYckYv?=
 =?utf-8?B?bGw3VE1CR21lbnNOQlZrWXlhdVU3T0dEY3VUZVdUYVJkNkFTWFFabGVtcWR0?=
 =?utf-8?Q?mWP/f6DNZGqIEHMHgu7FwZB2QLMlKdcAXHIiSkA?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 5e271659-a088-480d-1760-08d9920dd7cc
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2021 08:04:00.4423
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: mZ91V/uS/a6cPbgnQg/j3Psb+21WU8uN3ZfqxGWvmSu33mlsipDnrLNH7S1PYyLtZpXqJ8ZJmwY7AsGuRrGDqw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB2779
X-OriginatorOrg: citrix.com

On Mon, Oct 18, 2021 at 09:47:06AM +0200, Jan Beulich wrote:
> On 15.10.2021 18:51, Bertrand Marquis wrote:
> > --- /dev/null
> > +++ b/xen/arch/arm/vpci.c
> > @@ -0,0 +1,77 @@
> > +/*
> > + * xen/arch/arm/vpci.c
> > + *
> > + * This program is free software; you can redistribute it and/or modify
> > + * it under the terms of the GNU General Public License as published by
> > + * the Free Software Foundation; either version 2 of the License, or
> > + * (at your option) any later version.
> > + *
> > + * This program is distributed in the hope that it will be useful,
> > + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> > + * GNU General Public License for more details.
> > + */
> > +#include <xen/sched.h>
> > +#include <xen/vpci.h>
> > +
> > +#include <asm/mmio.h>
> > +
> > +static int vpci_mmio_read(struct vcpu *v, mmio_info_t *info,
> > +                          register_t *r, void *p)
> > +{
> > +    pci_sbdf_t sbdf;
> > +    /* data is needed to prevent a pointer cast on 32bit */
> > +    unsigned long data;
> > +
> > +    /* We ignore segment part and always handle segment 0 */
> > +    sbdf.sbdf = VPCI_ECAM_BDF(info->gpa);
> > +
> > +    if ( vpci_ecam_read(sbdf, ECAM_REG_OFFSET(info->gpa),
> > +                        1U << info->dabt.size, &data) )
> > +    {
> 
> Here it is quite clear that the SBDF you pass into vpci_ecam_read() is
> the virtual one. The function then calls vpci_read(), which in turn
> will call vpci_read_hw() in a number of situations (first and foremost
> whenever pci_get_pdev_by_domain() returns NULL). That function as well
> as pci_get_pdev_by_domain() use the passed in SBDF as if it was a
> physical one; I'm unable to spot any translation. Yet I do recall
> seeing assignment of a virtual device and function number somewhere
> (perhaps another of the related series), so the model also doesn't
> look to assume 1:1 mapping of SBDF.
> 
> > --- a/xen/drivers/passthrough/pci.c
> > +++ b/xen/drivers/passthrough/pci.c
> > @@ -756,6 +756,19 @@ int pci_add_device(u16 seg, u8 bus, u8 devfn,
> >      if ( !pdev->domain )
> >      {
> >          pdev->domain = hardware_domain;
> > +#ifdef CONFIG_ARM
> > +        /*
> > +         * On ARM PCI devices discovery will be done by Dom0. Add vpci handler
> > +         * when Dom0 inform XEN to add the PCI devices in XEN.
> > +         */
> > +        ret = vpci_add_handlers(pdev);
> > +        if ( ret )
> > +        {
> > +            printk(XENLOG_ERR "Setup of vPCI failed: %d\n", ret);
> > +            pdev->domain = NULL;
> > +            goto out;
> > +        }
> > +#endif
> >          ret = iommu_add_device(pdev);
> >          if ( ret )
> >          {
> 
> Upon failure, vpci_add_handlers() will itself call vpci_remove_handlers().
> What about iommu_add_device() failure? The device will have ->domain
> zapped, but all vPCI handlers still in place. This aspect of insufficient
> error cleanup was pointed out already in review of v1.
> 
> Furthermore already in v1 I questioned why this would be Arm-specific: On
> x86 this code path is going to be taken for all devices Xen wasn't able
> to discover at boot (anything on segments we wouldn't consider config
> space access safe on without reassurance by Dom0 plus SR-IOV VFs, at the
> very least).

My original plans for SR-IOV VFs on PVH dom0 involved trapping
accesses to the SR-IOV capability and detecting the creation of VFs
without the need for dom0 to notify them to Xen. This would avoid dom0
having to call PHYSDEVOP_pci_device_add for that case.

I might be confused, but I think we also spoke about other (non SR-IOV
related) cases where PCI devices might appear after certain actions by
dom0, so I think we need to keep the PHYSDEVOP_pci_device_add for PVH
dom0.

> Hence it is my understanding that something along these
> lines is actually also needed for PVH Dom0. I've just checked, and
> according to my mailbox that comment was actually left unresponded to.
> 
> Roger, am I missing anything here as to PVH Dom0 getting handlers put in
> place?

No, I think we will need those, likewise for run-time reported MCFG
regions.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Mon Oct 18 08:06:00 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Oct 2021 08:06:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.211758.369403 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcNeh-0005xn-Iz; Mon, 18 Oct 2021 08:05:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 211758.369403; Mon, 18 Oct 2021 08:05:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcNeh-0005xg-F5; Mon, 18 Oct 2021 08:05:59 +0000
Received: by outflank-mailman (input) for mailman id 211758;
 Mon, 18 Oct 2021 08:05:58 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=628V=PG=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mcNeg-0005xa-AU
 for xen-devel@lists.xenproject.org; Mon, 18 Oct 2021 08:05:58 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 38ebc0e0-2fea-11ec-82ce-12813bfff9fa;
 Mon, 18 Oct 2021 08:05:57 +0000 (UTC)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2111.outbound.protection.outlook.com [104.47.17.111])
 (Using TLS) by relay.mimecast.com with ESMTP id
 de-mta-2-4wy4WqCNO1CKlG3RFN-8FQ-1; Mon, 18 Oct 2021 10:05:55 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB4942.eurprd04.prod.outlook.com (2603:10a6:803:59::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.18; Mon, 18 Oct
 2021 08:05:53 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.018; Mon, 18 Oct 2021
 08:05:52 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6PR04CA0064.eurprd04.prod.outlook.com (2603:10a6:20b:f0::41) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.18 via Frontend Transport; Mon, 18 Oct 2021 08:05:52 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 38ebc0e0-2fea-11ec-82ce-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634544356;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=XwUo7Lw7IfGtRWkL4PKNPB39NB8A/txOu8Lk2EVup0U=;
	b=HcAJWIKdTP46LTYvI7Amiv8ZHvXIAtl4snsb7utYB2qpCa8uTYGnCik3xZ5wJphQGmYNMA
	QxixuXawgiK+w2SLNYSviPQ/TjYoWELXHk93F2LCnKEPYS9ztQUjg8TzEUOa0yDZCjyjUV
	qyhuyAJdypHQ6a4dZnGU8iEQ/+irfpM=
X-MC-Unique: 4wy4WqCNO1CKlG3RFN-8FQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=MIe0vD0Qz2hlYPLXZY2ioFzAlJqSBZ6vDQr3Jhr8D3pZHChgtbpCmRjfoCrTf3apct9k2TqDt/vPTCY+khOkShMlPRtPn9uLV5wE/yvL54cUXp9EWYleu6cX3t3QZnisS52sjIUbULUvz6whgeeGah317ktFDnJk+n1kmgH4Ux5jNjO8BMOuCd4mJNmGVFBxomwiQnohVvm2Rvqu2PiQWN35dRVnURdjS6XY0vMRT3RdDAfVETZQnDgSAkng1B5WrSJxePYoR0oPM13M4PwsxOHnbW8s1cYsxDexvZUIlMGD0+0laO6BBQNHCce66DigpmquLyPy/+VXZNGjt/lcuw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=XwUo7Lw7IfGtRWkL4PKNPB39NB8A/txOu8Lk2EVup0U=;
 b=PCsE99MoeYTZ67yMB6KfHuL9wuHB9Prn19kFMcdQhJreEH9g6T1dt5JF4eKV9dkYskWzjs3CBCumtr2lEucU+vA7X0Bkn5LBwkRCn8DygLQvigVSDqvznhhSHKYTB6W5EuygP+9AhC8HyK4sYKLuzmIX/bynacMavq+MYbY0mrYFWmXdz2qCe2lBGivV1121tG5n3J8DSjG6qGoHG5anZMSgxBQrFlgnCVIo2NdrIIo/m4s9oY8/jLPVxKdm7RyC2eG0oacdO5UOXMOTr/lNk6CnT/96QfIM+RbmYXratkOIG3FserhwwmWDY13sQxDhGHJK6JYN7GGo2smnDukm1w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: xenproject.org; dkim=none (message not signed)
 header.d=none;xenproject.org; dmarc=none action=none header.from=suse.com;
Subject: =?UTF-8?Q?Ping=c2=b2=3a_=5bPATCH=5d_x86/CPUID=3a_don=27t_shrink_hyp?=
 =?UTF-8?Q?ervisor_leaves?=
From: Jan Beulich <jbeulich@suse.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Wei Liu <wl@xen.org>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Ian Jackson <iwj@xenproject.org>
References: <0f5fe8d3-4c43-e60f-c585-67b2f23383ab@suse.com>
 <03f80bf0-047d-f940-72e7-7065e55d0d25@suse.com>
Message-ID: <d5a3a840-5095-25dd-a035-0f8cf745b861@suse.com>
Date: Mon, 18 Oct 2021 10:05:51 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <03f80bf0-047d-f940-72e7-7065e55d0d25@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR04CA0064.eurprd04.prod.outlook.com
 (2603:10a6:20b:f0::41) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 1d8ca013-7f9c-4118-26f9-08d9920e1ae6
X-MS-TrafficTypeDiagnostic: VI1PR04MB4942:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB4942B7E4BEEBB21C34FED0A8B3BC9@VI1PR04MB4942.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	u5TlmON32fWmCgYb0r5ISBXnnCjWiWI7FMCQ2G2EbkrbD8cylFPLF+UGM/ly9lWGNoUQ9i/xQzmnWGfh+WdqQmueNnrG8jFnB44hKjESPQ0UcSRJ0wkmPLFXAhAeGcThsPVlO/oVrN2vBiRGW7ewTdM6cA0YrKzMrO6jvf88IUVl5zJtgHJsKNpdQFq4Ew7x3NWkFP3sFYeMRZQR1ehAV/yjg72uwxTl5zxra21wvBjky9X43EkaLx3cKmMewFklNYXfmbZhy1YcXn8cYKXQW5P0CNOqB/RQtal3ixX8+/fB9jGK1KF+3mDuTI//6Umt1/gszYI84bBBuy9hcLZIs73eBxSd3rkhSLZyYf6bQ211uhQm9L9GlLhJCP91WO7tuMi9wKEzsKbRrZR65oDV2esigWzcqxT0O5qfoGaQO+RzVb2Fuy7uyPaNQPZwLjBO8Ev/NVVzCGUEFuI/jWIYyaFb4grETulrgSUXSdEILSObBOgkINKv2MHpfQoYERRXm9BaYmvV/apRHZrN9mb8fo+wbSBkNugDxjXJCV7LjzfK1YNGUqbbHw+BvQJCrDEkU0quzQEis33icDEtfY80nd0/W/We7FI8bTiGWljCO2v7XZVbESg+5sNHOTq8p5ydWVC11vfNtBO0q0fNHK96JXofnVmQSVXsPyiFxSG4SQfwYXW1l6e9Jt55P0tyFVcHF9/6WOtpzZcgUboQhHAW/1bZRhiWUN/optqvpV3/TxiBvGOQ47czpgdzK5kpM7CCbgGNHrfaEC+Ch8OBP0PMtA==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(36756003)(16576012)(956004)(66476007)(66556008)(508600001)(86362001)(66946007)(4326008)(186003)(6486002)(2616005)(8936002)(54906003)(53546011)(6916009)(83380400001)(26005)(316002)(5660300002)(2906002)(38100700002)(31686004)(31696002)(21314003)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?b1BWQVpRY2RGMEpNRmtleFZINkFNbGw0WmEzam5jdFhJSHZQRUZkcWV6RFhm?=
 =?utf-8?B?dG1HSG9YY3lxNzJrQUxYMkNwTGhKdVI1THMxOGs5eU9PSTl0dTRDTVYyQXJ3?=
 =?utf-8?B?QkFNdDRtOWo5em1JK1l3NDRJeVBHNU02UUVsS1dsTVR0RFlmd3UxTENSVU04?=
 =?utf-8?B?M3k4a0FrcjFsY1Y1aVNPOXNtRmVVQTc0Z3dyMGR0VTE3YzNVWlk3QVJwb1R6?=
 =?utf-8?B?M2pPMmVpazVuOVhLc21yUVlJa1VLZWQ5eVk1azVQcUgxUkh3c0xsc0lmRlND?=
 =?utf-8?B?VVB5RHMwTGdZR1J6QlgrdVZWeUluQXlpRDk5ZFVYdWlVbkttYTlnSSs1K1pQ?=
 =?utf-8?B?enhSZkdjT3dPUkZjMlJYZU1Dd3hrOTNnSFRLQjdBbUNvdmtZYk1MdHZLUHBx?=
 =?utf-8?B?czBlemZiRmRxdmtWS0pZeEJoaUVnR2cwaFNTdEYrUTZZcys5K3huV09qK08y?=
 =?utf-8?B?cVBRUnhGdzk5ZGlRNk1vaUtKdTdDeWdOMzBSL1NpSzBjQzBQVnJOWGtHWnAw?=
 =?utf-8?B?MWF3amh5NWxHQkpBeGptclY3M29YaDJqSnkxYVVMSGJuV09TSG9PdC9WZmpC?=
 =?utf-8?B?V0JwUDlJU0czOHB6WUtMRVlDQWxneC9aSWk1T0ZDMUN2TEsxRGxjSFk3MUZ0?=
 =?utf-8?B?Y25WMjdEYi9FVHdjbVNkcTBJei9VR1RkV1RkcGQ2WlJod1pyNXVPQWQ4cmlt?=
 =?utf-8?B?K3hQYkpiZG9OZVJ6RU1hMFJOMVlON0tnTHVTTEx2MFdkbjMxeFg4NG5yamJM?=
 =?utf-8?B?SlZVSmQwSVV0eWowWmhqL1ovMW5DV2VWcS9YRkRvb2VINExCVWhkTjIraldK?=
 =?utf-8?B?Rnp5SEc1Ry9WSXFJNFFKQzVUaE41Y2dZMUlRMEtEa2xaR3RWVkl4N2U5UVQ5?=
 =?utf-8?B?anZNWkpLb21QR0hCc1hsZENiVy9SSkhTNzhhTmJYSFhLc3FqRjcrRGhCcWJL?=
 =?utf-8?B?RURwZW1xaWVyR0tjcnZZV2VtbGluNXN1ZG5OYXVFYk1pU0lKSEdjT2JMQ2s5?=
 =?utf-8?B?U3d5ek5FV04vVkpaemFDTHUrMC8xeTRtWVdQaTNFN0xsaExqZzk4OWcxYVQy?=
 =?utf-8?B?UTJ4YUZjb0pudk14T3JCcndra2dNWno1dFBYYUVRV0V4aWxaK1IvL2R5dS9K?=
 =?utf-8?B?Y3JQcS91cWxqR1hHUVpFLy9rSlVwdmpMT25mRi95ZUtFNFhOWEM3RXlGcEcr?=
 =?utf-8?B?ejZOZ1k5ZWhobXpoaTAwZzBpN2xDYXd0UkVsNTNoQkxMczlPRllxUDJIS0xH?=
 =?utf-8?B?RTF4MXZ2QjdIUGFRUmJGTzJLRmw0ZlBZdy9WMVVwaXA1N0VQdWJhOExuY1h0?=
 =?utf-8?B?bVVZUDdSdEhZYkxScGN0LzdZcjF6V1pkL1VOb2p6L3E0V2Y3cUZBVkpqa2ln?=
 =?utf-8?B?N2kyaHVpdVBrSy9VRi9JdEg1SGwvV0hkWlVyNG84Wk1RWlJMeVAzVzZxR0dD?=
 =?utf-8?B?NEU5L1RIU1RpNndRZVlYRlpEbEVGdzNhcVpTc2ozbVBBbGt0bzBGRkgwM3cr?=
 =?utf-8?B?SFgvdmxSaE42SFlOdU5ZMU1ldS8yWmtEUVRGQitPWFBBLzBpVGlmRjQ0R0JP?=
 =?utf-8?B?TWZzZUtRQWVsZ1VqU0VmQyt4djVGRWEvNllRKytPT2pmdDVHNFUrK0JkT2xr?=
 =?utf-8?B?ZUNmVWM2d2lDS3VnamxnaUo2L0VtZ1B2TXNVNGttM1MzOVkvWGRxNUhVK1hN?=
 =?utf-8?B?akg2NXNKbHVWRTZwcU1zSVF3RVZCdVg1L3JicW8vOVB4dCtxV0czMkpqK3VG?=
 =?utf-8?Q?SvZkkO5XL+PNQ/dC7g6B9GUc77ds3VKzB66XUpa?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1d8ca013-7f9c-4118-26f9-08d9920e1ae6
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2021 08:05:52.8983
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zn7wFz03YGWKprNUWBhY9k2dekPgSDXGPsj9DlMAFSV4y3b077n0OEOddwpWwoe53FX5XrPLbRKkfWBwq92MKQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4942

On 06.07.2021 09:48, Jan Beulich wrote:
> Andrew,
> 
> On 07.05.2021 10:40, Jan Beulich wrote:
>> This is a partial revert of 540d911c2813 ("x86/CPUID: shrink
>> max_{,sub}leaf fields according to actual leaf contents"). Andrew points
>> out that XXX.
> 
> if you still think the original change was wrong, would you please take
> the time to fill in the XXX above. It was you who asked for the revert,
> so I hope you can explain the reasons (I'm sorry for not being able to
> deduce these from your [informal iirc] revert request), and I expect
> you can find this much of time when I've already taken care of
> everything else. If I don't hear back within a couple of days, I'll
> assume you've changed your mind, and I'd then drop this patch.
> 
> Thanks, Jan

I notice this still is pending, despite what I've said above, since it
seems unlikely to me that you've changed your mind and didn't care about
saying so. Could you please clarify things one way or another?

Jan

>> Reported-by: Andrew Cooper <andrew.cooper3@citrix.com>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>> ---
>> Obviously the XXX wants filling in. So far I did not really understand
>> what bad consequences there might be, but I can agree with the undoing
>> of this part of the original change along the lines of why the Viridian
>> side adjustment was also requested to be dropped (before the patch went
>> in).
>>
>> --- a/xen/arch/x86/traps.c
>> +++ b/xen/arch/x86/traps.c
>> @@ -964,15 +964,13 @@ void cpuid_hypervisor_leaves(const struc
>>      uint32_t base = is_viridian_domain(d) ? 0x40000100 : 0x40000000;
>>      uint32_t idx  = leaf - base;
>>      unsigned int limit = is_viridian_domain(d) ? p->hv2_limit : p->hv_limit;
>> -    unsigned int dflt = is_pv_domain(d) ? XEN_CPUID_MAX_PV_NUM_LEAVES
>> -                                        : XEN_CPUID_MAX_HVM_NUM_LEAVES;
>>  
>>      if ( limit == 0 )
>>          /* Default number of leaves */
>> -        limit = dflt;
>> +        limit = XEN_CPUID_MAX_NUM_LEAVES;
>>      else
>>          /* Clamp toolstack value between 2 and MAX_NUM_LEAVES. */
>> -        limit = min(max(limit, 2u), dflt);
>> +        limit = min(max(limit, 2u), XEN_CPUID_MAX_NUM_LEAVES + 0u);
>>  
>>      if ( idx > limit )
>>          return;
>> --- a/xen/include/public/arch-x86/cpuid.h
>> +++ b/xen/include/public/arch-x86/cpuid.h
>> @@ -113,10 +113,6 @@
>>  /* Max. address width in bits taking memory hotplug into account. */
>>  #define XEN_CPUID_MACHINE_ADDRESS_WIDTH_MASK (0xffu << 0)
>>  
>> -#define XEN_CPUID_MAX_PV_NUM_LEAVES 5
>> -#define XEN_CPUID_MAX_HVM_NUM_LEAVES 4
>> -#define XEN_CPUID_MAX_NUM_LEAVES \
>> -    (XEN_CPUID_MAX_PV_NUM_LEAVES > XEN_CPUID_MAX_HVM_NUM_LEAVES ? \
>> -     XEN_CPUID_MAX_PV_NUM_LEAVES : XEN_CPUID_MAX_HVM_NUM_LEAVES)
>> +#define XEN_CPUID_MAX_NUM_LEAVES 5
>>  
>>  #endif /* __XEN_PUBLIC_ARCH_X86_CPUID_H__ */
>>
> 



From xen-devel-bounces@lists.xenproject.org Mon Oct 18 08:06:16 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Oct 2021 08:06:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.211762.369413 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcNex-0006S2-VS; Mon, 18 Oct 2021 08:06:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 211762.369413; Mon, 18 Oct 2021 08:06:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcNex-0006Rv-SM; Mon, 18 Oct 2021 08:06:15 +0000
Received: by outflank-mailman (input) for mailman id 211762;
 Mon, 18 Oct 2021 08:06:14 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=J+Bz=PG=arm.com=Bertrand.Marquis@srs-us1.protection.inumbo.net>)
 id 1mcNew-0006Oy-MY
 for xen-devel@lists.xenproject.org; Mon, 18 Oct 2021 08:06:14 +0000
Received: from EUR05-AM6-obe.outbound.protection.outlook.com (unknown
 [40.107.22.41]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 42af881e-2fea-11ec-82ce-12813bfff9fa;
 Mon, 18 Oct 2021 08:06:13 +0000 (UTC)
Received: from DB6PR0202CA0033.eurprd02.prod.outlook.com (2603:10a6:4:a5::19)
 by DBBPR08MB6316.eurprd08.prod.outlook.com (2603:10a6:10:207::5) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16; Mon, 18 Oct
 2021 08:06:11 +0000
Received: from DB5EUR03FT015.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:4:a5:cafe::f1) by DB6PR0202CA0033.outlook.office365.com
 (2603:10a6:4:a5::19) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16 via Frontend
 Transport; Mon, 18 Oct 2021 08:06:11 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT015.mail.protection.outlook.com (10.152.20.145) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.15 via Frontend Transport; Mon, 18 Oct 2021 08:06:10 +0000
Received: ("Tessian outbound 8e26f7114b75:v103");
 Mon, 18 Oct 2021 08:06:10 +0000
Received: from c05969f79600.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 24DD6916-2FC3-45CE-B369-2E94ABC71ACF.1; 
 Mon, 18 Oct 2021 08:05:59 +0000
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id c05969f79600.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Mon, 18 Oct 2021 08:05:59 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com (2603:10a6:4:74::9)
 by DB9PR08MB6633.eurprd08.prod.outlook.com (2603:10a6:10:23d::6) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.17; Mon, 18 Oct
 2021 08:05:58 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955]) by DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955%4]) with mapi id 15.20.4608.018; Mon, 18 Oct 2021
 08:05:57 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 42af881e-2fea-11ec-82ce-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=PYbXdiZrqnq/ewGWjWYobOuyBPl4ycZ1/MdqCuZY6pg=;
 b=3JcXuUnDbddIcMl84X1vBaz5JjxpMcUXXAhRbEnCmbRKjLvCgoSMnxfEfg3dwbkks6l4ImaA4lodIEIFFoe1vvoktbdGaRRn/xCc6vRHy+D4FO4wBsOPEkkdQcZQw7VfC+vcClkeeBWZ/IQA+uHjaMGud6jR5seBwHM/ZYgZpnA=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 7d7bc893ef96a900
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=kXsXt9PApp+h4+ko+z12UBp/97hcp204jTolK8qb1YLvpvs7DUdK1iJ1guueHXiYRr//EOwrZ9HciPJxRH9/RCxYte4RX2slJeJhyY1DBqJfi7eLdlaJ4pSB1LFQNnCMueaSpZ0KaIg68hlg1RTS4XRqO3mUkf+rRlgPd7xm3kunrKO7qgy+EIRWnww2j8+Dv/vN8E/325CIQ2nxmyr7zQP/Fhmuwtm4PcxsbwgEGjP52LLmJEcztiJ1c97V/49rom5g3WeauApMpeF4Rx5HXAMZjNU0fWYYeOxjp3TsIc8C/b1JjZuTOLkZi++nR8hIaEjf5D6xUuFY7ITOjAErIg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=PYbXdiZrqnq/ewGWjWYobOuyBPl4ycZ1/MdqCuZY6pg=;
 b=Yz/Zwt8FcKw0ydjSqi8fpbOPaoHdOD3x76Ia57h1DKbMmU+mSf6462G/wyGJPm/W5aSddkE3E8XoMPhKD6bZtWvM7zSQdClNDQgTEthMdoR+1kA37BQ3fML7XiXqQDtpJZ6l7uJVrPD7f2511DcKcCWc5LCmLcJTNOeaMI78znzdL3sllXgeSp50wBB1gJlvJ4lZw0I6VmWh4I+l69jxz5FxO06GZ49+YQQ7iWNoqJkB5WU+Z4COs08WkWEc46+OafbpCvrngW9Q/bymQgEDLhSFT/5BOdXTlxJK6dMnZzT0vgGn4MWRiw5Gys4yKpZXtDGkPphtDeabwiiB6j0j7Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=PYbXdiZrqnq/ewGWjWYobOuyBPl4ycZ1/MdqCuZY6pg=;
 b=3JcXuUnDbddIcMl84X1vBaz5JjxpMcUXXAhRbEnCmbRKjLvCgoSMnxfEfg3dwbkks6l4ImaA4lodIEIFFoe1vvoktbdGaRRn/xCc6vRHy+D4FO4wBsOPEkkdQcZQw7VfC+vcClkeeBWZ/IQA+uHjaMGud6jR5seBwHM/ZYgZpnA=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>, "iwj@xenproject.org"
	<iwj@xenproject.org>, "sstabellini@kernel.org" <sstabellini@kernel.org>,
	Rahul Singh <Rahul.Singh@arm.com>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>, Paul Durrant
	<paul@xen.org>, =?iso-8859-1?Q?Roger_Pau_Monn=E9?= <roger.pau@citrix.com>,
	Julien Grall <julien@xen.org>
Subject: Re: [PATCH v8 2/5] xen/arm: Enable the existing x86 virtual PCI
 support for ARM
Thread-Topic: [PATCH v8 2/5] xen/arm: Enable the existing x86 virtual PCI
 support for ARM
Thread-Index: AQHXweULx+Lzp09rU0elFmx0jxVt5qvUT3iAgAACRwCAABIcgIAEAi0AgAAEIYA=
Date: Mon, 18 Oct 2021 08:05:55 +0000
Message-ID: <85CB568A-E026-4D4F-B72E-B2AB8B001F66@arm.com>
References: <cover.1634315461.git.bertrand.marquis@arm.com>
 <e2b10f56043155e4bb8eae824723045ccc042f8e.1634315461.git.bertrand.marquis@arm.com>
 <cef8d2a6-91c1-2d4d-2078-98d0a92b067a@xen.org>
 <F447A1D8-A023-4127-AAC0-7511868DE9C4@arm.com>
 <a45077dc-e144-4427-9ae2-5815045ecaec@xen.org>
 <f77c42e2-4a3c-9e28-25c5-b23efffef25d@suse.com>
In-Reply-To: <f77c42e2-4a3c-9e28-25c5-b23efffef25d@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3654.120.0.1.13)
Authentication-Results-Original: suse.com; dkim=none (message not signed)
 header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: c23db6a2-14cb-4dbd-52aa-08d9920e25a2
x-ms-traffictypediagnostic: DB9PR08MB6633:|DBBPR08MB6316:
x-ms-exchange-transport-forked: True
X-Microsoft-Antispam-PRVS:
	<DBBPR08MB6316DD9BACC46FDCD3A670229DBC9@DBBPR08MB6316.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:10000;OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 Qq+N439+YD3qPLyuUgIiabhustf0CQduc6uEoDYde7C4+1fYciEw/uqLvXM5Op8cV0IW661v/C5ou/KgSBqNPaEIbeZDb9NGvf1zZebmhldE+I7MSuRUgKrQYLSBwT6jfIlmgctoy0CeI0zQ5IOeCqAwMvKtYYWVSAOnMtn9lHPa3SKgFHyK9Ivo1UEDOQ7xRIjcVd++6xezwOkADHTmvVzMQ7+XsfM85LsmdVGgW02ekpXlUcqebbyIhyuPgxyEm/kT0uQZgN0OgwSxQueMJ3ioutFOOtISud/8t6E0p4Ub4ksJwMKJDDgfXhuzVJJz6Yk0mE+sr1RPgmgI/jKdK46ApFpFcl/W4auOm/ei5FqShxVcv/ylg5e6lrQXD6tcqtjWAvIqYdB2JNxWDYeT1XAbiG9t6qOKCXgDe3uyOFmhYNU0GFSqLhkf7ExNeszEwQN/eF5h5pqcxbjRl3hXKLi28DOq6eYH5l5TCW8vKRxlkvid+b4piOuoaPruZ2xPqPdfn2arMxIk4XsHO06G+30a6A2IobmNcaaLHc29DziCwzXG97I+4AQQheoCiFGD54C76QnD+o0OT83YOwnbMKdfN0HFdGiFWGp1HZoJfzzTeB7HCIRQvmcEoDnQ3+PbLsxFBES0bfhabLxcPVkkQKgWH4/3b6a04pOmKNRPqzdZLr25Zii+0cEJgn19dYpaLf45mqSHipUs/yMUToxoM2M6/G7KJKSSJZqFXO8x1YZyscgxMTDnH78agASA28xe
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB6PR0801MB2024.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(53546011)(8676002)(38070700005)(86362001)(5660300002)(186003)(122000001)(66556008)(76116006)(66446008)(6486002)(66946007)(66476007)(64756008)(83380400001)(38100700002)(2616005)(2906002)(316002)(36756003)(91956017)(508600001)(6506007)(6916009)(4326008)(6512007)(54906003)(33656002)(8936002)(71200400001)(26005)(7416002)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="iso-8859-1"
Content-ID: <73D89DA1251FE54187B6EB7B887FAD40@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB6633
Original-Authentication-Results: suse.com; dkim=none (message not signed)
 header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT015.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	81ade068-29e3-40b3-f343-08d9920e1da3
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	litBNqZRWeZBypnM0qAnFareXEen8ziaDgVX/yyG7+YdlwWl8OcwWTxGTyz+hAJN4doGRfUxXTzwHjCAL2i9Ktv814sOAw5et/gqzGF31o5uwsNF6AwSN/wdUVzr95y0NeAeRRMknEv81OypOWU97+RgV5PMjE9P5cHVrpfuqWwfiRzOO0IIRvohb8mtwCq1EOPHSMqQ3ns918rMsJtzfC89a5v+6o7MTubi4E2lquO/VG8zTHskUI/1yUXxa8evx6V7rF4BNei3j13R3IG5awhvQ0QbfvsUzt8aIhTQ4idblDR/aGHFXQAIztnl6IBMCGoJbohWbt4MY27HE2sij0fmc3xvgdKF4E6mICHc8e2hCm+Jl4Lw6g7giMHqxwz5rAGmh3kUIhUcV+QoXAtkwh4ctZH1wOXKtfQN5tR4bn6CgevgTP96KEWh6VsEyz1ZJmsQe4DgwfEf0Kz52JvPzj/mn/Q53xlCz40eZfVXiCrV5pVHeIWKsQ+Ss//eAQM8XTIOiPA2sHsWsORJNxD+QfrJOsist5d0p2QYtcEAtUQO6PrqI//OTz+67Ari4mj7fWGZSqVNBRaDJ3WewbtMIhy0cc/e/oWsGADIff5ESkS1BoxR+pxQQz57F/1fa487lA6nbSux3X1Moe6vjUTPH+uDCb0qWWzSE+1sOs0gxG6Dm6GuwsfcM8IEWX3JV0/86cBzJxnUCw8BlObQIl6MSw==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(316002)(83380400001)(5660300002)(26005)(8676002)(53546011)(2616005)(6486002)(6512007)(6506007)(8936002)(186003)(82310400003)(508600001)(2906002)(336012)(70586007)(70206006)(36860700001)(54906003)(86362001)(47076005)(33656002)(6862004)(36756003)(356005)(81166007)(4326008);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2021 08:06:10.8148
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: c23db6a2-14cb-4dbd-52aa-08d9920e25a2
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT015.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB6316

Hi Jan,

> On 18 Oct 2021, at 08:51, Jan Beulich <jbeulich@suse.com> wrote:
>=20
> On 15.10.2021 20:38, Julien Grall wrote:
>>=20
>>=20
>> On 15/10/2021 18:33, Bertrand Marquis wrote:
>>> Hi Julien,
>>=20
>> Hi Bertrand,
>>=20
>>>=20
>>>> On 15 Oct 2021, at 18:25, Julien Grall <julien@xen.org> wrote:
>>>>=20
>>>> Hi Bertrand,
>>>>=20
>>>> On 15/10/2021 17:51, Bertrand Marquis wrote:
>>>>> diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/=
pci.c
>>>>> index 3aa8c3175f..35e0190796 100644
>>>>> --- a/xen/drivers/passthrough/pci.c
>>>>> +++ b/xen/drivers/passthrough/pci.c
>>>>> @@ -756,6 +756,19 @@ int pci_add_device(u16 seg, u8 bus, u8 devfn,
>>>>>      if ( !pdev->domain )
>>>>>      {
>>>>>          pdev->domain =3D hardware_domain;
>>>>> +#ifdef CONFIG_ARM
>>>>> +        /*
>>>>> +         * On ARM PCI devices discovery will be done by Dom0. Add vp=
ci handler
>>>>> +         * when Dom0 inform XEN to add the PCI devices in XEN.
>>>>> +         */
>>>>> +        ret =3D vpci_add_handlers(pdev);
>>>>=20
>>>> I don't seem to find the code to remove __init_hwdom in this series. A=
re you intending to fix it separately?
>>>=20
>>> Yes I think it is better to fix that in a new patch as it will require =
some discussion as it will impact the x86 code if I just remove the flag no=
w.
>> For the future patch series, may I ask to keep track of outstanding=20
>> issues in the commit message (if you don't plan to address them before=20
>> commiting) or after --- (if they are meant to be addressed before=20
>> commiting)?
>>=20
>> In this case, the impact on Arm is this would result to an hypervisor=20
>> crash if called. If we drop __init_hwdom, the impact on x86 is Xen text=
=20
>> will slightly be bigger after the boot time.
>>=20
>> AFAICT, the code is not reachable on Arm (?).
>=20
> Which re-raises my question towards testing of what is being added in
> this series. Supported also by the typo in v7 patch 1, which suggests
> that version wasn't even build-tested.

This was an honest mistake, we did build locally but without VPCI activated=
.
Once I discovered this by rerunning all tests (including one modifying the
code to activate VPCI), I signalled it on the mailing list and it was fixed=
 in v8.

We did a lot of tests and tried to be as careful as possible but on the las=
t rush
before the feature freeze deadline those can happen.

Regards
Bertrand

>=20
> Jan
>=20
>> Therefore, one could argue=20
>> we this can wait after the week-end as this is a latent bug. Yet, I am=20
>> not really comfortable to see knowningly buggy code merged.
>>=20
>> Stefano, would you be willing to remove __init_hwdom while committing=20
>> it? If not, can you update the commit message and mention this patch=20
>> doesn't work as intended?
>>=20
>> Cheers,



From xen-devel-bounces@lists.xenproject.org Mon Oct 18 08:10:30 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Oct 2021 08:10:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.211777.369425 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcNj1-00083G-Hc; Mon, 18 Oct 2021 08:10:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 211777.369425; Mon, 18 Oct 2021 08:10:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcNj1-000839-DQ; Mon, 18 Oct 2021 08:10:27 +0000
Received: by outflank-mailman (input) for mailman id 211777;
 Mon, 18 Oct 2021 08:10:25 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=628V=PG=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mcNiz-000833-Ku
 for xen-devel@lists.xenproject.org; Mon, 18 Oct 2021 08:10:25 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id b116ad8c-41a3-42bb-a0d3-c3618eb88100;
 Mon, 18 Oct 2021 08:10:24 +0000 (UTC)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2109.outbound.protection.outlook.com [104.47.18.109])
 (Using TLS) by relay.mimecast.com with ESMTP id
 de-mta-13-UEjl64wLOcS9ViY8LlvGQA-1; Mon, 18 Oct 2021 10:10:22 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB5165.eurprd04.prod.outlook.com (2603:10a6:803:54::25)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16; Mon, 18 Oct
 2021 08:10:19 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.018; Mon, 18 Oct 2021
 08:10:19 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM5PR04CA0012.eurprd04.prod.outlook.com (2603:10a6:206:1::25) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.16 via Frontend Transport; Mon, 18 Oct 2021 08:10:18 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b116ad8c-41a3-42bb-a0d3-c3618eb88100
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634544623;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=7SA5a6hHmZkTNFxPKlvV5iOMZgWohXyXRfJN0wSlrnY=;
	b=mFOPBosMf3ZbZGNlXUvta+sLsfgRrQ8TEByBttJAtEWChj9sw15QK6h/nK4oby9D3T7VjT
	rjpOZbHHqR+QgHKyYKdJ8bU6nS1N6WO5G1TD38YdHK96DGWHnH4slozWDQKvHP9+a8NLu+
	b8K/QTGjU4R+qzLm580BWFMRwyhRl88=
X-MC-Unique: UEjl64wLOcS9ViY8LlvGQA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=fOLluS/85ylv4ZD8AC8SjLBpB6PDtqyEiSrXqT6GxiY6bkt3/KbVM3fkbnxucQN9xSeu0KhmdwpXYFEIRxsT53pswfUaIw9R11Tl51btib5g9gv4UgHqIBV3s1MmKtGt4mjIH1Idev61U7TvI6LohjKAlHsLcD1DZXQkfoNzuSDukwM4Z+uQqXtF6NTgE1hf2cWfLbtqywvM4Y9KcP7vLHNr++eoC5ZDcNwDHpAH5g1HHvBRzLUhNpvad9sthhoSl/boml7ymmI2/cD6FxMIRL7GayrBIfBiH+oJvHeaNJo0oxe9erEDUXzfjXtiHGk9H+/BViahR89A2e0K1ddLmg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=7SA5a6hHmZkTNFxPKlvV5iOMZgWohXyXRfJN0wSlrnY=;
 b=QUTBDYNxUtOwV5joFsSkZsillA6G8M9VDgV61N7iKBBB/U5SdY+GtkaNyOvzayjMtm1HiObGKZDTHtJHqD2+aRgjv5c4YzXRhA8hKhZlsB+GQc8nDE3StB/ktaIxPrjOzBQmZCs2jq6S3HEhKSzqip9BeyfsajCMWi+NKVxMLa+dtji0ei+dqA0V9+34ObLZFbmujWl7SECsTDRfKCIjy3tKF7k4cX3H76edeH9xbT1J1VU37o6M+Zym6xE3W5k7NqKrlPyEAAREl9a++2wKtysUepObVS04reZUsx9sByJzZwSKleYOKw0S2eVmFy0GnFJDnDqg/8k96HvCCSvepw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: xenproject.org; dkim=none (message not signed)
 header.d=none;xenproject.org; dmarc=none action=none header.from=suse.com;
Subject: =?UTF-8?Q?Ping=c2=b2=3a_=5bPATCH_v2=5d_x86emul=3a_de-duplicate_scat?=
 =?UTF-8?Q?ters_to_the_same_linear_address?=
From: Jan Beulich <jbeulich@suse.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Ian Jackson <iwj@xenproject.org>
References: <cf935e11-27c8-969f-9fb2-a5c0e85ccff1@suse.com>
 <26495a3f-d250-4445-ca91-0d0aae336fe7@suse.com>
Message-ID: <3b1b038d-3cba-f947-3458-297ca21a262b@suse.com>
Date: Mon, 18 Oct 2021 10:10:17 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <26495a3f-d250-4445-ca91-0d0aae336fe7@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM5PR04CA0012.eurprd04.prod.outlook.com
 (2603:10a6:206:1::25) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 2deb69e3-9bc7-4695-ab67-08d9920eb9f8
X-MS-TrafficTypeDiagnostic: VI1PR04MB5165:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB51652292284659EDF02D445FB3BC9@VI1PR04MB5165.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	af8iNQsfBKFBZPDrJNakhlLAFvioLc1evd8qNBrVNIe986PeiDVBjuEjC9qr5czH/rDhltN2lSATS+Xx+dF39LKTYQBDRDfOlz+XAXrATJXGlGzC52fUEi0/L3U5xqUfC8TILGaGLX5pvTYCO3RRZKutywkKakqz9nhLwP6nZ1+3qdtSmoOkcXrj6ZEakZIb94w3p//0FnZNKcOrRF6JxS6UYbOUBP8i6QWTh9yXIC25kET2eJcoNT7LrDaHsNXah9mrnnwdEgpkz4fgpIsz/oz8VQAwojwYhuL1RyGHqTYDnihtY9A5oAxsp6qvrjCRbupgDlfeL0vYQOMgxhUz6y7BbJ1L+LD655SGkQfxmiovNX69akesJMfROrezi0F0ChLisgMuFqAeaYdJLmtoSEIEj0vkTPh5ZXq4pZHcRni9VeBnFwZq8Jon9EFlGi23bH8DJjyLEl5UlmBOvfdN96uUjUQh0h9YRbcyQ0Ann2huFWQAZLnKlWUq3G9XAT91sO03XVVKWctqOO5t5DPb6QcxGlJMGbKH+a6Jx+AZmoRTVid+t+whARI7vtty8uR6G7xM3oRgNJDWRuUcx+zt0xGD62fNRBXU6u3dR0nwhromTDafn0KOsVK+BDUlK7RDuheWJj5yxSYBaSGUlrWGj8GZsL2une0GzK8YZ/fgFVNLjaibEtUhiratfR5nw0I3F5VQILnjFBLNkDyYuSNKwDKe3OWqslhC68qth9eFDxk=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(2906002)(956004)(316002)(5660300002)(54906003)(66946007)(83380400001)(66556008)(16576012)(38100700002)(6486002)(53546011)(186003)(86362001)(110136005)(508600001)(66476007)(8936002)(2616005)(36756003)(31686004)(26005)(4326008)(31696002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Q1Erd0JMVlJnbU9vbWhTMFdNVUNTK0lWczhLaWNuc0RlU21WK201d0tOamk4?=
 =?utf-8?B?WUswT1Q2M3lYa3gycVdoMGUwVEVzUWh3eXZibm9sbDV4Q0ljbm1waldlU09Z?=
 =?utf-8?B?dGlpN29hNVVhOTdkUzI0UFdhdGNOaHo5cE5uNk1iMjlDZHF5RzhmRmN1clFu?=
 =?utf-8?B?cVlOS29jNUp3ZWVNYW52MjN5ZVNpWTQvdjdSaWxlV1VtVnFxR0ZGamQ5clpo?=
 =?utf-8?B?RVhDdjc1R2szd1k5a1FQWG0xeUZHdlE4ZGVkSnBTaDhrZHdrUFVIU0hTSG5m?=
 =?utf-8?B?YnJSZy90c0ExM2NYeHArTWt3OE9wdUZYTVBJN2ZsRmEybnoyZEhiQ2tVa0Vp?=
 =?utf-8?B?MkhibjkyVEZwYVlnYnk1MEFEVkpWcDI3ZEtWSzNvdVNDck9ReVczNlhrc2ho?=
 =?utf-8?B?S3BCMHgxV0FDcUdtU24vanpPWjg4bDIreTZ1aFhtelAxR2wxZStnNU14V1dG?=
 =?utf-8?B?SkpSYXpYTmZjOGpReTRINmp6bXlueTR6TU9OOWRDSjY1V2ZwTmFyWDE0ajcy?=
 =?utf-8?B?YmlyWkM2dVc0UTM4OW1Xb01CT1pBYVBjdEdoS3d4NmJtN09adGExeEtTN2Zl?=
 =?utf-8?B?bm5HZ0d2RlNlQjAxZUVTL28wQk1HSzJxRXIzaDRtSzVmMFFRc0dIQi9OYXZE?=
 =?utf-8?B?Qy9mdDNnNFBGNHRwZ1NacFVtYlNnYzQ4SitLT3BMcFRsd0lRWFVXYnE1aXVh?=
 =?utf-8?B?Y3BnSC9LbWNMRkpRLy9CcVIvdDhuZzJpYnRJaFdtZ3BId2NjZ0hoMS9pYXN5?=
 =?utf-8?B?UHFMZmtxM1FmbS96TVNuK0huRG5LWW91bEdlRzVNdjdjMW4wQWtFMGxOeWFs?=
 =?utf-8?B?eFdkeU1BcmNDMFhSL3lsQkJUUmU2SnpkbnpiV2QzemZwS3Q0S09ja0YwdnM2?=
 =?utf-8?B?cXBxTFZDREFqQ01wTENubTlrU20vUW01OCt1VHRCQlpGSmRzVFI0SW9ORkpY?=
 =?utf-8?B?SDNMdVZHN2tVSzhvS0Frblp4cE1nclk1TG02VWtqMDFBQmFvcTYwcWJyZVN1?=
 =?utf-8?B?NElWM3UxSjZXejBmSUgyaXFWdnBOQStqbEpSdU9sMUNEeGtnc20ra09BMFlZ?=
 =?utf-8?B?K1QzMXkxd1BGTjY1aTNBenZCeDNmaGdnbnFtVDFmYmFxS0xXMm5NY3F2Z3RE?=
 =?utf-8?B?bUkrcjlSSzNMcHF1TStFT0dQR3o1cFpGS2l4M3J6c2laTkZkdmVGR2tUbWps?=
 =?utf-8?B?M1lKYmlzdEYrcmVwU3JTbHhYTnRNQ1g3R0dpOGlJckhreFVPeXBuVlA5ZWxy?=
 =?utf-8?B?dDJVQjB3RnJnb2ZzVkVzR2pIMk1KZk91KzRRQ01RcTRIc3Fmb1VsY3JjTnBy?=
 =?utf-8?B?UW14RTkzd2tWNFpndnFiV09INkZVbHpVWXhzcitqV3Z1TDZEUkViL3JUd2FG?=
 =?utf-8?B?cytkenA1WTlCZTI3OWdTOTZ2Tkp1NW9WdG5LT3RFTUUwZUxkTy9sL0wxMHBs?=
 =?utf-8?B?MDJTMUNESEQ3bW9TZXpxWC94aDBjUmNhWDBxOGJZNmJTUTI5VER1M0x6ZlFT?=
 =?utf-8?B?Mm9ZN2tGMmxPdCt4SVAyRnAxUUlxanVsV1hjQ21MYVdxZmkxZDd0RURyZHZB?=
 =?utf-8?B?K3o0V2VZcWVFa2NobDFLY2JOL1k3VlFDSll3b3dETzN1YTJtM1NKcjhhS2Fh?=
 =?utf-8?B?ejBDdW9iZGJJRzkweDlWWjBER0Q5T1NuSThqVThpWmMyYlJRK29nUysxaFYr?=
 =?utf-8?B?bmpHeUE2cnhHSFRabm1YUGtTTGtYYVJNTnpMQk9qYWxvQnZFV2dNcEEybHJT?=
 =?utf-8?Q?kxMjzDJ8rH6QFLzp4M3s1X/j4Stjl/nYARIuxda?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2deb69e3-9bc7-4695-ab67-08d9920eb9f8
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2021 08:10:19.7614
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: mfvVM3XaEkvrIXovQp1JfCoFIlzvdxGhusHWqsAYjwYTcSHj90E+EzhM2xiPxySciR4MN4oeprhHFTdAo3koqA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5165

On 28.06.2021 14:13, Jan Beulich wrote:
> On 20.05.2021 15:34, Jan Beulich wrote:
>> The SDM specifically allows for earlier writes to fully overlapping
>> ranges to be dropped. If a guest did so, hvmemul_phys_mmio_access()
>> would crash it if varying data was written to the same address. Detect
>> overlaps early, as doing so in hvmemul_{linear,phys}_mmio_access() would
>> be quite a bit more difficult. To maintain proper faulting behavior,
>> instead of dropping earlier write instances of fully overlapping slots
>> altogether, write the data of the final of these slots multiple times.
>> (We also can't pull ahead the [single] write of the data of the last of
>> the slots, clearing all involved slots' op_mask bits together, as this
>> would yield incorrect results if there were intervening partially
>> overlapping ones.)
>>
>> Note that due to cache slot use being linear address based, there's no
>> similar issue with multiple writes to the same physical address (mapped
>> through different linear addresses).
>>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> 
> As indicated before, this is an issue which - afaict - would be a
> security issue if introspection was security supported. As such I
> find it highly irritating that this has now been pending for well
> over half a year (counting from the submission of v1).

This continues to be pending, despite having got submitted well in time
for 4.15 (Nov 2020). Are we meaning to ship another major release with
this bug unaddressed?

Jan

>> ---
>> v2: Maintain correct faulting behavior.
>>
>> --- a/xen/arch/x86/x86_emulate/x86_emulate.c
>> +++ b/xen/arch/x86/x86_emulate/x86_emulate.c
>> @@ -10073,15 +10073,36 @@ x86_emulate(
>>  
>>          for ( i = 0; op_mask; ++i )
>>          {
>> -            long idx = b & 1 ? index.qw[i] : index.dw[i];
>> +            long idx = (b & 1 ? index.qw[i]
>> +                              : index.dw[i]) * (1 << state->sib_scale);
>> +            unsigned long offs = truncate_ea(ea.mem.off + idx);
>> +            unsigned int j, slot;
>>  
>>              if ( !(op_mask & (1 << i)) )
>>                  continue;
>>  
>> -            rc = ops->write(ea.mem.seg,
>> -                            truncate_ea(ea.mem.off +
>> -                                        idx * (1 << state->sib_scale)),
>> -                            (void *)mmvalp + i * op_bytes, op_bytes, ctxt);
>> +            /*
>> +             * hvmemul_linear_mmio_access() will find a cache slot based on
>> +             * linear address.  hvmemul_phys_mmio_access() will crash the
>> +             * domain if observing varying data getting written to the same
>> +             * cache slot.  Utilize that squashing earlier writes to fully
>> +             * overlapping addresses is permitted by the spec.  We can't,
>> +             * however, drop the writes altogether, to maintain correct
>> +             * faulting behavior.  Instead write the data from the last of
>> +             * the fully overlapping slots multiple times.
>> +             */
>> +            for ( j = (slot = i) + 1; j < n; ++j )
>> +            {
>> +                long idx2 = (b & 1 ? index.qw[j]
>> +                                   : index.dw[j]) * (1 << state->sib_scale);
>> +
>> +                if ( (op_mask & (1 << j)) &&
>> +                     truncate_ea(ea.mem.off + idx2) == offs )
>> +                    slot = j;
>> +            }
>> +
>> +            rc = ops->write(ea.mem.seg, offs,
>> +                            (void *)mmvalp + slot * op_bytes, op_bytes, ctxt);
>>              if ( rc != X86EMUL_OKAY )
>>              {
>>                  /* See comment in gather emulation. */
>>
> 
> 



From xen-devel-bounces@lists.xenproject.org Mon Oct 18 08:13:52 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Oct 2021 08:13:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.211784.369436 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcNmJ-0000EW-2g; Mon, 18 Oct 2021 08:13:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 211784.369436; Mon, 18 Oct 2021 08:13:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcNmI-0000EP-Tn; Mon, 18 Oct 2021 08:13:50 +0000
Received: by outflank-mailman (input) for mailman id 211784;
 Mon, 18 Oct 2021 08:13:50 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=628V=PG=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mcNmI-0000EJ-EV
 for xen-devel@lists.xenproject.org; Mon, 18 Oct 2021 08:13:50 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 5255c4f8-2feb-11ec-82ce-12813bfff9fa;
 Mon, 18 Oct 2021 08:13:49 +0000 (UTC)
Received: from EUR02-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur02lp2055.outbound.protection.outlook.com [104.47.5.55]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-12-4TQnxubdOmid0gkNln7arQ-2; Mon, 18 Oct 2021 10:13:47 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB5598.eurprd04.prod.outlook.com (2603:10a6:803:e9::30)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.18; Mon, 18 Oct
 2021 08:13:44 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.018; Mon, 18 Oct 2021
 08:13:43 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS8P250CA0014.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:330::19) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.16 via Frontend Transport; Mon, 18 Oct 2021 08:13:43 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5255c4f8-2feb-11ec-82ce-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634544828;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=xlvw/4hZx1tozqsc0YYpIF3EOF4lf9Rp0LuzwCZv2yQ=;
	b=AlDE+aT/lVWgI1eqgBJywPCicocepsa2XFdobBsT+ns0qa8bYToJUGmM5MKwNn4qw69atm
	AOeArO88D4dGVIV6qiw0qiuhfT61fsbhOdMID/k30ieJgQB2hx8OLvNmvIcikcevAGrBhE
	Jy1o/2+An3Vr/KxMApFGFMy3rDnu9eI=
X-MC-Unique: 4TQnxubdOmid0gkNln7arQ-2
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=jRgIJ3bZz7KoCuGNicHZDKu+ihhn5/fFOosfN58T7Q69wnCJApAUWjw9rzcyYQsE2koUIbLZwX6isC2UUAp3Y1bMMvukbEbRLcCsatZLk50JbXM52D733UlySgGFW1Wtpz4RqOXiNHVWmJGdIl1IiTui0nzy8EUv2pSueFcaB0Wny/ShY0j3KqWQMjazhc4pTY70poAFuNoW6MOOuBau/lffxboj/U1ZHRVgE6/fOBFZg+wunyFDQvYRT4CaGP5MCPpc0nmsdeb7FrPsPIDPtuTGWpn5WRx6U4tOyUGLl39a9sITdGevQX+5KtHZ5qAVHvdoRQ6yKNA9hb4fNwbZIw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=xlvw/4hZx1tozqsc0YYpIF3EOF4lf9Rp0LuzwCZv2yQ=;
 b=RgDuqemzdys00wglV9NxqVCE7Fzci9yzMP1rm3/nMAR+mp+ku/xXK74etopq9mIu/RdQh5LSDuGM66wQJRycUbuIq3VZB89sTYChKqGzHbSFFEXWD8DTvb6AYuIj+WDP0knFqIw5P8ZDmJxoEnO4ItdvKxajdqc0O4ZLZiFwLGQJvGkbqm3ziQD/9eaHT9S4w/ycVNOsMwr1SMPi0ftwdzWpkY+ZZQVyz6jfJHKml4kx5qI+PmUR1ubAVEsyDT7QAhD8ERhomiZ260YB85jVDTGq17Cgay7wxINZBc7bn3jRYSCCD+TGQ445lSjCvBGsPUJHqpRwPIEBTIlV8/Bf3g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: xenproject.org; dkim=none (message not signed)
 header.d=none;xenproject.org; dmarc=none action=none header.from=suse.com;
Subject: Ping: [PATCH v2] x86/AMD: make HT range dynamic for Fam17 and up
From: Jan Beulich <jbeulich@suse.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Ian Jackson <iwj@xenproject.org>
References: <36df1141-5c3b-6f8a-3a83-1f954b1e27a6@suse.com>
Message-ID: <84798d50-f362-f18d-a979-6ec973d95216@suse.com>
Date: Mon, 18 Oct 2021 10:13:41 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <36df1141-5c3b-6f8a-3a83-1f954b1e27a6@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8P250CA0014.EURP250.PROD.OUTLOOK.COM
 (2603:10a6:20b:330::19) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 1ffadb10-a0fb-4bbe-4ae4-08d9920f338a
X-MS-TrafficTypeDiagnostic: VI1PR04MB5598:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB5598DAE7119960F7E7DE6453B3BC9@VI1PR04MB5598.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	5rLoBp1l4Xm8Nf2gMKsaBj6RZaME+a4g6kp2V5rrTtQtcmQdL6FTrl0lIlFeihIlj18w3vXff7MS219NuLHu34xvC9EEx7ydIZYOiwaVuyEzfxAw/KYA1fw8pTNoCk1QqSQEL2iUGLFfUzRKCyXHs0h94TaA1aU0c2U3NizXCNSpcVGRg9iLlrGmdQM/WGTeK6x6ayHAEF3UZmY2JjcB/Id0VOPWCZGqEH/N4URFErs6OIb3ovM33El9Vrw4/lMlOHzfbuOBS5VUEmEuFUYEex7ZefItq8vTuJ1rsjUyzLIgUy8IeMzQjJ1911o+n82pObxcKxgpwewUG6/NLwu7Gwp47WbNXndK0kuEqr9cooeQK7+hsZtoSTki3QTARrCtTQ6q2KfpE9QG1T/02d1dn+4+Ev1NISeWH06K4ajsAldVd/Z8+OPdyU7tAcBeEvy6xX7r+Kth//+v2swtg2mXJH82gWQ2W5jnPEclfCKKK7KF7mzn+WnBUzX77BBWM5iXuJDn698rIyJc4VVJOGT4OlMgL0YEdjYNb7LewDiNG//8KQRPD7HR9zsLNG18YGVdCyOBPrhLZVPZ5vCRgIY561V5U+vi9HrG4VCqDxg1HgRlxdlVKjEXX8jmr36lKzMuje+gUBJqMTYzNqEqYt/wo42jHXxq8wI5+8pqO19s+ylYMvp/auYjdZOdoj/d4Vvuk6qt14DfYXI1RrsImTt9Q2PsUXqdvSXM0Nlh1cjKI1s4E33Xkswy/4EPtSvSrzbs
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(4326008)(36756003)(508600001)(16576012)(6486002)(31686004)(66556008)(26005)(66476007)(38100700002)(86362001)(5660300002)(8676002)(8936002)(31696002)(66946007)(2906002)(956004)(2616005)(83380400001)(316002)(110136005)(186003)(53546011)(54906003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?R1cvUUg2MU8wcGRrMVZzZ05VZlA0dmR5V05aMWVLdnZWeXVKNlQyMFp1am9B?=
 =?utf-8?B?bnBpSmlmUmVVeGUvaUlKTDA1ZGtNWEpEUzVPTmZOd24zaG8weG43RlBjNTdz?=
 =?utf-8?B?VnVPbzEyZUNidTVHQS8ySVAwUmJkYk5JTmk2UWlUcjNCaXlwRWxqdXkvRjZI?=
 =?utf-8?B?bWFtUlF1Smg2blJ6Z1pTSXcvMitUNUlGQUVRb0Jvd0dvQi9SSWxNR0N0dlNL?=
 =?utf-8?B?bXhsa2JTaUdPV052TGl5d0dQb21oL1ErOWFBemtOaEQ1VWtMQUlENWo2cFY4?=
 =?utf-8?B?bXh1bndrWVBGOFByM3hsSWJ5YW1TTkFRTkpENlZ4a2NqZ21jazNyWU91dGN6?=
 =?utf-8?B?U0V6ZE4wdE9JbVd3cDZDclRsck5maW1WYVNGeVFkRXQrNHdPSU5NaHc1T0Q2?=
 =?utf-8?B?TCtJSnllb0JHRzhzY1FOSjNybitlOW8rZ0ROcERYRjNnWFFCL3dvbXV3andO?=
 =?utf-8?B?LzkyanYrYXpoL3d0SE8vZ1FyT3JJbTdkTHlaT3J4UWRka2NaTFloTzd0VWNM?=
 =?utf-8?B?RS9WSEVNRDJVSE5DMEViT090eXRYQ3VSbWhOVmlvemwwZEtOcHZQMVVDUGlN?=
 =?utf-8?B?MVAvbkw2VndWV2hRblpTQ1hIM21PRHJuMERZOHo3YnlLSmp3VTlIT3VLcENO?=
 =?utf-8?B?Q0tORGQrQUFaNXpRUnhiK1g4OGs2c0Nld0F0UDhVT1E2QVc1eUtWTDY1dnVr?=
 =?utf-8?B?Wm1zbFJ1TmNCSGl0b28xU1UxNWRKVkF2TitmeUo1Tng1ZWc2T2Q5OVRDT24r?=
 =?utf-8?B?bTRkOHFKRDcvUjFtbE9nbGtPNHhXMHNKazlFL2l6TEI0M0V3NUVneTliK3hU?=
 =?utf-8?B?NklHN1cxeVZIMnllaGlJdmsyUlEyRkJCTGpJSldrS1pjaHYzT0R6WmVpa0p3?=
 =?utf-8?B?UHVCR3kvYXZJancxeE9hUlFMK3I4SWNSbWhtNnN5TVlsTzFSZzFxajAzZ3Va?=
 =?utf-8?B?RndrRENQNEJzdFpiUHFTbDVkaHNYNEE0bWY5T1RnZDZ6eUJxOTBHWkpaS1hT?=
 =?utf-8?B?SmR6UTQrZlQrZFcxMWJFcCtOMVVlSXlKaVMzM2NScFZjdW9hL0ZvNlVOL01R?=
 =?utf-8?B?NHZsYS83dzJWak5CYThYd252U0tlakx1Z2FUbGs1T2laVzV3RHUvTmlERVdI?=
 =?utf-8?B?R2h3OHNhY1pNbTFDTXBYRTBoTDE2dVgxUWg5Tm91eWEwVFNVcmVoN1ljbzJr?=
 =?utf-8?B?S1NsTkc2OVZodW9BR2wyaVAzV0VFc3p5d1FkRDRyVHFHZ1MvUzJ6SnE3b2Iy?=
 =?utf-8?B?OFRwTGxoRzZqOEFsdUJIU3R2dllCRGl1NDFLTXJDdjVHVllVZGxObisvS0JZ?=
 =?utf-8?B?ZE02Y042WVFTUkRIV2ZIcXpYem5WY0dSYitIZVdQZXptVUNtK2h3bnJHRVp5?=
 =?utf-8?B?OXFqYUV6YUkrQ2djWnR6L2FCMERWaVBuVmFzRHpLV0tPRGdOWTBzK2Z1RnRR?=
 =?utf-8?B?NnJ4cFAwbE4vQ3lQa21UYUNRcHNNbW1YN0Ywc3o2ODRvL2M2T2hoRStUbERN?=
 =?utf-8?B?SmttTy93WkFlZTR6b2pwUWVPbUxlMWJySGxhMlF3a0RrMTVJemtuaDBiR0pG?=
 =?utf-8?B?ZzJNVlJVa3NhNlhweDJUbjhnMXZ1TWxZL2M4ZHJrTmVUSEFvbVdrNXJJTWtB?=
 =?utf-8?B?MmhMUmg2ZWNyVk9nQkNsSkJXWCt1THpDb2V5VDA2aDFRV2V6SUZITzMzMlBG?=
 =?utf-8?B?Nlk4T21hZCt4LzJHWXA4bVlMYitwQVA3UWlJakloR0UvTjJvOVBIbW9Hc3I3?=
 =?utf-8?Q?9KLMP93IeqKzhTkx1tuUHQxH8hqWfpei58BGe6N?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1ffadb10-a0fb-4bbe-4ae4-08d9920f338a
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2021 08:13:43.7251
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: HJmTWSmTFoOq1ar8RbHHmXkLL+dUqj/MGkVmkMS56FOPQybGwQZh2ak4DEnnHxTo4sOmuaZZWHfnIQzV1PxP4w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5598

On 28.06.2021 13:48, Jan Beulich wrote:
> At the time of d838ac2539cf ("x86: don't allow Dom0 access to the HT
> address range") documentation correctly stated that the range was
> completely fixed. For Fam17 and newer, it lives at the top of physical
> address space, though.
> 
> To correctly determine the top of physical address space, we need to
> account for their physical address reduction, hence the calculation of
> paddr_bits also gets adjusted.
> 
> While for paddr_bits < 40 the HT range is completely hidden, there's no
> need to suppress the range insertion in that case: It'll just have no
> real meaning.
> 
> Reported-by: Igor Druzhinin <igor.druzhinin@citrix.com>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> ---
> v2: Move adjustment last, to leave hap_paddr_bits unaffected. Add
>     comment.

If there are any further adjustments needed here (or if the whole
situation needs to be addressed differently altogether), could
respective requests please be voiced? Or else may I please ask for
an ack?

Jan

> --- a/xen/arch/x86/cpu/common.c
> +++ b/xen/arch/x86/cpu/common.c
> @@ -349,16 +349,23 @@ void __init early_cpu_init(void)
>  
>  	eax = cpuid_eax(0x80000000);
>  	if ((eax >> 16) == 0x8000 && eax >= 0x80000008) {
> +		ebx = eax >= 0x8000001f ? cpuid_ebx(0x8000001f) : 0;
>  		eax = cpuid_eax(0x80000008);
> +
>  		paddr_bits = eax & 0xff;
>  		if (paddr_bits > PADDR_BITS)
>  			paddr_bits = PADDR_BITS;
> +
>  		vaddr_bits = (eax >> 8) & 0xff;
>  		if (vaddr_bits > VADDR_BITS)
>  			vaddr_bits = VADDR_BITS;
> +
>  		hap_paddr_bits = ((eax >> 16) & 0xff) ?: paddr_bits;
>  		if (hap_paddr_bits > PADDR_BITS)
>  			hap_paddr_bits = PADDR_BITS;
> +
> +		/* Account for SME's physical address space reduction. */
> +		paddr_bits -= (ebx >> 6) & 0x3f;
>  	}
>  
>  	if (!(c->x86_vendor & (X86_VENDOR_AMD | X86_VENDOR_HYGON)))
> --- a/xen/arch/x86/dom0_build.c
> +++ b/xen/arch/x86/dom0_build.c
> @@ -524,8 +524,11 @@ int __init dom0_setup_permissions(struct
>                                           MSI_ADDR_DEST_ID_MASK));
>      /* HyperTransport range. */
>      if ( boot_cpu_data.x86_vendor & (X86_VENDOR_AMD | X86_VENDOR_HYGON) )
> -        rc |= iomem_deny_access(d, paddr_to_pfn(0xfdULL << 32),
> -                                paddr_to_pfn((1ULL << 40) - 1));
> +    {
> +        mfn = paddr_to_pfn(1UL <<
> +                           (boot_cpu_data.x86 < 0x17 ? 40 : paddr_bits));
> +        rc |= iomem_deny_access(d, mfn - paddr_to_pfn(3UL << 32), mfn - 1);
> +    }
>  
>      /* Remove access to E820_UNUSABLE I/O regions above 1MB. */
>      for ( i = 0; i < e820.nr_map; i++ )
> 
> 



From xen-devel-bounces@lists.xenproject.org Mon Oct 18 08:17:15 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Oct 2021 08:17:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.211793.369446 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcNpX-0000x8-Je; Mon, 18 Oct 2021 08:17:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 211793.369446; Mon, 18 Oct 2021 08:17:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcNpX-0000x1-Gg; Mon, 18 Oct 2021 08:17:11 +0000
Received: by outflank-mailman (input) for mailman id 211793;
 Mon, 18 Oct 2021 08:17:10 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=628V=PG=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mcNpW-0000wv-Ln
 for xen-devel@lists.xenproject.org; Mon, 18 Oct 2021 08:17:10 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id c99a34cc-2feb-11ec-82ce-12813bfff9fa;
 Mon, 18 Oct 2021 08:17:09 +0000 (UTC)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2170.outbound.protection.outlook.com [104.47.17.170])
 (Using TLS) by relay.mimecast.com with ESMTP id
 de-mta-4-vjAU4yskPVCO_q7GuvVcjQ-1; Mon, 18 Oct 2021 10:17:07 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0402MB2703.eurprd04.prod.outlook.com (2603:10a6:800:ae::9)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.18; Mon, 18 Oct
 2021 08:17:06 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.018; Mon, 18 Oct 2021
 08:17:06 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6PR08CA0011.eurprd08.prod.outlook.com (2603:10a6:20b:b2::23) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.16 via Frontend Transport; Mon, 18 Oct 2021 08:17:05 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c99a34cc-2feb-11ec-82ce-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634545028;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=TT1Yg1Ui+3ajrltfvs1+MwffPu6AfveDBZrEEbldyUM=;
	b=XF85mcxQIDIsN51AULxMpGZmoQPWqsfefxSFz4Kz99mzw4EalHK1Q3bzpS/S0MOj0BEQyi
	4Aj7nFUamSQc+VJEcQVI0HTA3yUEa2Zh1V9ZgffdVQwLASRV6ugxRmioJ81ochMz6XMLzK
	i+z3CUCslvVbr2MeVeQBjXjcOuOLDUI=
X-MC-Unique: vjAU4yskPVCO_q7GuvVcjQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=dZCFdm5O798SMAaU8F8someSy4WdcVhiFXiquR1n4WL2edhSwJvC6baenV8L3EyLL7mPZ4uZsXAQZl24Iq5ffwB7tGQTerjMgJJ2IuOhTMNfK6zO4ofvAwFhceiD17Pn5klPjKhxUdXxEV3aIFg6detyRKm3nRFuj1VmS0lsnp4Fr6rjNdtpa9chHnN6zy2+BPRsJpvJlpFlR7NP3Mvxd0eM9UUqLTwKsic4jgrDyjxqCWj5g94xVPID0ff6GEMZXRVORU3xBFREn9V3JyxcnXicR+imFzweyx15NGWIe0HNkM702/FG/D7fmLl4t7UoEPWpwwnwbDC9OKwqKqwgJg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=TT1Yg1Ui+3ajrltfvs1+MwffPu6AfveDBZrEEbldyUM=;
 b=cwC2RVbojiXzr/pmtvoWPBfzPBsrB92ewxK4lqnkCOoI813eIatTbnu6eYLGo/svLY99JYAU+GcBWtUKD4NfkAj4Ixj5ICbYxF2qHyleM/OEHgufLsKqjlv8+te0hqrfETFVldWFuwQt89hkNeUKGtN47+DjLOiQX15ngiKNLME2YpV9T4WpxdoDNvLcohiIvN4JQWBdpkDe2xFBEV5BejYY4NTWBN7InFXToPPLxJCUzvWb1/DO9xIzkDJ9gAUCVNoXNzB6IWv9VoSim5QpfyrXwtUpop7DAm4qrkOpWAxhTLibFzN9xLZEbr49vFDdeOVYvdLcckY9ZC8LAmTsfw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Ping: [PATCH] x86/PV: address odd UB in I/O emulation
From: Jan Beulich <jbeulich@suse.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>, Wei Liu <wl@xen.org>
Cc: Rroach <2284696125@qq.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <b9bbc584-db3c-0b03-0314-3dd907f645bc@suse.com>
Message-ID: <bea4ef0f-fe6d-a4f3-4929-4fc22c67c817@suse.com>
Date: Mon, 18 Oct 2021 10:17:04 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <b9bbc584-db3c-0b03-0314-3dd907f645bc@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR08CA0011.eurprd08.prod.outlook.com
 (2603:10a6:20b:b2::23) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: db98a3a5-3676-40b6-7cbf-08d9920fac23
X-MS-TrafficTypeDiagnostic: VI1PR0402MB2703:
X-Microsoft-Antispam-PRVS:
	<VI1PR0402MB2703FE13F8161E0344D0EB3BB3BC9@VI1PR0402MB2703.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	tww85VxnFXBv5Hs7zapohbznhOl6XdIJYKG4ERH2ll1PjHlatlDj47EiMdeGrZTD8iLqsRZAIkxjr4/B0sP1hI4l9hMIAfjoZoTAf0Lr6FiS2aPtmEm3+0zz7qjohq5R/Y7dzQMvAEU9hsiC50huGNZXqO1KKRAVouFr0Ob7XjV0Be4ljaoVOJWQbEAEpHpW22WjDrCt91HsOQQPS6FJvPcdTo5yOvxHASmjqikZCEBKSqbf8x3fyudcdCjXB/Mkrw/aWwaEXGkjuw8dH7AjKfR1NXraS45fZdm7LelQHXAXpbZ1jeb6oYsblMsXOOByvCR78fiwucepRw2stLYPlMbq/9lCFP4sez988klYT/NrKxU6FeY/JzUesiZiWHroPi/5iFV8HqHUOxBOHYb4sgmxeycwl573vfayqZVmNnO4owXhhI5IqJ5da6D5f7Fo1oEYdNLRYEIG2bjsdDJQrSDYg+f4KKuqztpf5+JDDgygnW/NBHnnGcMsLmTao/S6ircKa+QdVLqLPMHWSqLj3n/XoiLvvEIBtRixopJgU7Baa57tP4OwEavwlyhl+mRmRa3w9zuoZNFFJ7lX51qum90L1U3K/7lz5btWMD/39JSzyhu2eCml2zH4UdlblcMndiZ4herLqGH4w+nYw2mn0VrZPfdA4o24Uso+xM6DPTykFsB5qTa+uvC0mDQCZN5ST9+/p2cYnxtYthMzWy9pKE8SivrD4QvcZP11NeV3jKGeL5wvSGEPDyyM8jcMG4Ee
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(8936002)(26005)(2616005)(2906002)(508600001)(66556008)(4326008)(83380400001)(956004)(66476007)(53546011)(66946007)(31686004)(54906003)(16576012)(38100700002)(316002)(6486002)(8676002)(86362001)(31696002)(36756003)(110136005)(5660300002)(186003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?K3NXWDFUcC9RM3ZVckVoeTFrQVJQc1pRd0dZVGFBWnFLWDA4czdvNUQ1WldJ?=
 =?utf-8?B?OFRMU3I1Ui9saHZDb1JPc2tZczVDZHduMFR4RFRpM0lIZnlxOTV6c2htRlJx?=
 =?utf-8?B?Q09qVVFnTm81blJNMFNDL3pyZXNHZWJ6N2JsQmZyMDY2cEI4eU1IekVxejda?=
 =?utf-8?B?a2g5cDBGNXVYd2NPblJkaXlIVGtBWTNDV3ZtWm5adjFWNWRGWk5SZ0xNTG9l?=
 =?utf-8?B?Nm56TUdlMDlIYnN4SFVEVnh0MVVYK2tCTVkwMlZwcFdpc05VMTNsQi9hcUhl?=
 =?utf-8?B?d0xsTFAzNUhEaGt0QjZoclNwRVZOQkRIVzRCbmttMGhlais5SVkyVlVQK0I2?=
 =?utf-8?B?TEFUMjVZVWlsNVA3MjVtOHR4eTE3YzFSbTQ2WmZEaWtoQkFQY3RpczMrQXBY?=
 =?utf-8?B?MmRSbW9SZHRmNXZDRFp4ZjlKNXk1ODFRMStjdm04Q0J0em44VTlCMFpqbUh5?=
 =?utf-8?B?dFQ5clhET200U210UEhvUHBPTTQ4ZG1ZYmRXRE50RWZkL1VhMlZ6azN5NXlG?=
 =?utf-8?B?djd6T1dsS0NMNnRCOXNBWm1YRGwyODB6eDExQnFpbkFxS3FyU1lNOWRTenBG?=
 =?utf-8?B?TEgwR0JkT3hkNlZaNndTREJNQTQvMFFZcU8yazRBTlBvRWFIYy9wOEFJenVH?=
 =?utf-8?B?SUhvQVVhZXQ0YmkwelJjbDBaNmQwUFhwNkEvYjdQQStKWkV5V1hxWGFmdlJO?=
 =?utf-8?B?c0xQMmN1b3JpQVpKL0NsRjJoZ012R2hkOUFBVUJ2dU1OY2xzck1ZOWdNSUJM?=
 =?utf-8?B?YmdWL3EzRVJLYTduSjJUTk9rWFo5T3FlL0xnWksxcVI4OHgxZ1lJeXdOV3Qr?=
 =?utf-8?B?Tm5sMi9CbjVCV1VSejE0YVAwNG9DbWtZODBtNUxtSVVJKzBSUVY5blVneml5?=
 =?utf-8?B?bW5IWmZlR3lCRFVyOHA3VnhZeFRDM3hORXhGbE9rUW55SUlrQWVKWEtEU2pS?=
 =?utf-8?B?RENTeWNOL2ZoSUNobktudDlxTFRZUmxhcjd6bkVlL2JjOWUxb3JBQkxYZHBl?=
 =?utf-8?B?V0xhL3VERlhvUkhrbTVIM0xLM2JtOG40eEJsZWlRY21oYndLWGVWRSsrK0NL?=
 =?utf-8?B?bGFqdDcxb2FsZzk3YVR2V05uS3hYSXdGdlh2dCsrcUdhUEJxb05qaWNQazU1?=
 =?utf-8?B?TThYSHpqL0lQQTFMR1hEU0hENzdKQnZXcTE2SitDWmwyZXhnL2hlQ2xNbDBE?=
 =?utf-8?B?V1RReHlRSWVnNHh1YndNeCtDWkoxVUN0ZS8vM05OWUdXYzRQb2thOVo0c1VX?=
 =?utf-8?B?Ry9GZXU5Z1BLNFppZi9Ca2JoM2pTVC9yTk9SWmR1YWdyU1pWUUFScjhsc2oy?=
 =?utf-8?B?Q0l1Wk9pQlQrZHNGd2JWcHZKUzVwbzZwVGJ3ZTdadjA3Z3JZZkR2VGZiVFJp?=
 =?utf-8?B?TTRCOGlWSVlKSE5pLzhISjNxem1PcmtyWEdSTGNiN2ZkRFlqNHYvUys1WGpM?=
 =?utf-8?B?Mnl0NlpEN2pLV2RGU2sxeE9ZVDF2TVNLNElOUU5MNEJhbG92UmtSRjQyN3Jl?=
 =?utf-8?B?bXUzdVdYcHlKdlBLdlI1OWgxbEdiOWVNT2pMb2NIZU4xc2VkRE9PamRCWlkx?=
 =?utf-8?B?Q3RlNldBQ0Fadkg2TkpEZEZLRHJtTll2Qml6bzE4Q1NXazFJTmdXQklHR0hs?=
 =?utf-8?B?ajJLZk9CMkxLY2pGVVovTCttczlsUEo1MFNKNlgxMmFaZzVoS09hNWJ4OU93?=
 =?utf-8?B?OVNMSFBIZVhIcDg4Uzk0WHZEajQrRFJaL0x2NFN6MVF3UXgxdTgrUmlLbUR4?=
 =?utf-8?Q?mSQ9Tt5ndoKcbIVtOin1juVxHVePXXJ1epWv2y6?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: db98a3a5-3676-40b6-7cbf-08d9920fac23
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2021 08:17:06.3635
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: A4ck3dna+Rs8hCdjVRs8LcUaJJh30cLk1xebdixcEbWtr4bv7XiyBYo3PFs7usLtyRf8TP4SNbrijW8x6SVoHg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB2703

On 08.07.2021 09:21, Jan Beulich wrote:
> Compilers are certainly right in detecting UB here, given that fully
> parenthesized (to express precedence) the original offending expression
> was (((stub_va + p) - ctxt->io_emul_stub) + 5), which in fact exhibits
> two overflows in pointer calculations. We really want to calculate
> (p - ctxt->io_emul_stub) first, which is guaranteed to not overflow.
> 
> The issue was observed with clang 9 on 4.13.
> 
> The oddities are
> - the issue was detected on APPEND_CALL(save_guest_gprs), despite the
>   earlier similar APPEND_CALL(load_guest_gprs),
> - merely casting the original offending expression to long was reported
>   to also help.
> 
> While at it also avoid converting guaranteed (with our current address
> space layout) negative values to unsigned long (which has implementation
> defined behavior): Have stub_va be of pointer type. And since it's on an
> immediately adjacent line, also constify this_stubs.
> 
> Fixes: d89e5e65f305 ("x86/ioemul: Rewrite stub generation to be shadow stack compatible")
> Reported-by: Franklin Shen <2284696125@qq.com>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> ---
> I'm not going to insist on the part avoiding implementation defined
> behavior here. If I am to drop that, it is less clear whether
> constifying this_stubs would then still be warranted.

While I did respond to all review comments by Andrew, this has not
lead to forward progress here.

Jan

> --- a/xen/arch/x86/pv/emul-priv-op.c
> +++ b/xen/arch/x86/pv/emul-priv-op.c
> @@ -89,8 +89,8 @@ static io_emul_stub_t *io_emul_stub_setu
>          0xc3,       /* ret       */
>      };
>  
> -    struct stubs *this_stubs = &this_cpu(stubs);
> -    unsigned long stub_va = this_stubs->addr + STUB_BUF_SIZE / 2;
> +    const struct stubs *this_stubs = &this_cpu(stubs);
> +    const void *stub_va = (void *)this_stubs->addr + STUB_BUF_SIZE / 2;
>      unsigned int quirk_bytes = 0;
>      char *p;
>  
> @@ -98,7 +98,7 @@ static io_emul_stub_t *io_emul_stub_setu
>  #define APPEND_BUFF(b) ({ memcpy(p, b, sizeof(b)); p += sizeof(b); })
>  #define APPEND_CALL(f)                                                  \
>      ({                                                                  \
> -        long disp = (long)(f) - (stub_va + p - ctxt->io_emul_stub + 5); \
> +        long disp = (void *)(f) - (stub_va + (p - ctxt->io_emul_stub) + 5); \
>          BUG_ON((int32_t)disp != disp);                                  \
>          *p++ = 0xe8;                                                    \
>          *(int32_t *)p = disp; p += 4;                                   \
> @@ -106,7 +106,7 @@ static io_emul_stub_t *io_emul_stub_setu
>  
>      if ( !ctxt->io_emul_stub )
>          ctxt->io_emul_stub =
> -            map_domain_page(_mfn(this_stubs->mfn)) + (stub_va & ~PAGE_MASK);
> +            map_domain_page(_mfn(this_stubs->mfn)) + PAGE_OFFSET(stub_va);
>  
>      p = ctxt->io_emul_stub;
>  
> @@ -141,7 +141,7 @@ static io_emul_stub_t *io_emul_stub_setu
>      block_speculation(); /* SCSB */
>  
>      /* Handy function-typed pointer to the stub. */
> -    return (void *)stub_va;
> +    return stub_va;
>  
>  #undef APPEND_CALL
>  #undef APPEND_BUFF
> 
> 



From xen-devel-bounces@lists.xenproject.org Mon Oct 18 08:21:39 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Oct 2021 08:21:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.211801.369457 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcNto-0002Ll-5r; Mon, 18 Oct 2021 08:21:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 211801.369457; Mon, 18 Oct 2021 08:21:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcNto-0002Le-2J; Mon, 18 Oct 2021 08:21:36 +0000
Received: by outflank-mailman (input) for mailman id 211801;
 Mon, 18 Oct 2021 08:21:34 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=628V=PG=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mcNtm-0002LF-OJ
 for xen-devel@lists.xenproject.org; Mon, 18 Oct 2021 08:21:34 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id ee506014-f6bc-4b9a-8c5a-a0ecf9ecc395;
 Mon, 18 Oct 2021 08:21:33 +0000 (UTC)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2052.outbound.protection.outlook.com [104.47.13.52]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-40-kxHj-J7vOG2e-vwCMXcqtA-1; Mon, 18 Oct 2021 10:21:31 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB4606.eurprd04.prod.outlook.com (2603:10a6:803:70::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.21; Mon, 18 Oct
 2021 08:21:30 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.018; Mon, 18 Oct 2021
 08:21:30 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS9PR06CA0306.eurprd06.prod.outlook.com (2603:10a6:20b:45b::15) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16 via Frontend
 Transport; Mon, 18 Oct 2021 08:21:29 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ee506014-f6bc-4b9a-8c5a-a0ecf9ecc395
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634545292;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=+nPUiq0plCIbRzmzsCmwU7v1T8rSdDbSQ2p4utiF+ww=;
	b=ToLpJDEHlJ0jYnmnEDLOkQrzZV1uGDxBSNZS9ehjHqPCy5/sPHR/jKiMrOc7FMiO+RQXaJ
	ZDtOTzYPk7avwzZhzwF0sbpeVQ3x2UEyM2IgiPQB4Suob8EfSgS7JGJiGcQNSl2aG66i9h
	jQm5RPjx+Cugsx6EvTE4Ofe34kvUL1g=
X-MC-Unique: kxHj-J7vOG2e-vwCMXcqtA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=RU0NWOufSA7jMnIVHusRVLY9wi33VP9KwevUEJ0xKUYP2c8GAEiyhFV9JOi7W4Ok0weQ+P8PIgz1cUqgUCMtSikaNFbAa9Fg6zsz1T/apYVo0tg76p/vnhQIuRp+99sMHh/Z+z/1UHOpOOM7erQNsYvPBdR2PLFIxHDIomJWuwhIKE3H2kheK/CUz64Cw+fDyELaRwlYS6hpwjuggY9NGPVoKz8tmchQL9hBe2hsRUIJdDJ+VqbpOCExU9TTK7Hx5QOVkzPZRbB/ugBpFOJ3SzkPYUbUEw5+YO+E11+iAXEGl5/rknfYSceRtln+bYk3B4QN+lKZ6Md+5yTVPUgeHg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ICn+1vKFaW1xoOwZufQfKZd5z/UH5Lfil54ktYv5ioM=;
 b=nxMVpquSkrS2GIPrNRFWMJ37S8jObDl7+5+BPgjleLwT7pv9WiWMIujBV0/9wU7uBpIPpV7gLa8jKnC3oJDbwD3Ac6wPSIlgdjyRsW5W3U2Th8J+ZDTVNOpDAiz3sQebYbGirnnqo3jUrR6sEYuWKijCamgfGqbCN1IXtan0lQkvSOxqLGcePCYsm/CFBtVEFMJhMkAgihedUxxZD8Mq13c1uPNdC6id8CtEn9WpOx1kgItsVcqyPe71a9YF5tPjSSOvkNt0L0CNTbAAh1KwqbnI5T9RecsmPMoX4c/bJ5ycX7vX3/t9T7DlE6CCU8nDK4gTttnCv+iIdWTI2fR//g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: xenproject.org; dkim=none (message not signed)
 header.d=none;xenproject.org; dmarc=none action=none header.from=suse.com;
Subject: Ping: [PATCH] x86/xstate: reset cached register values on resume
To: Andrew Cooper <andrew.cooper3@citrix.com>
CC: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?=
 <marmarek@invisiblethingslab.com>, xen-devel@lists.xenproject.org,
 Ian Jackson <iwj@xenproject.org>
References: <20210818113017.454251-1-marmarek@invisiblethingslab.com>
 <45de5185-b514-8c52-6922-4c587818c698@citrix.com>
 <3125583f-b965-7746-d833-c197857cd7d7@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <6adf41a6-8f05-8ead-2b12-e922939955da@suse.com>
Date: Mon, 18 Oct 2021 10:21:28 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <3125583f-b965-7746-d833-c197857cd7d7@citrix.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS9PR06CA0306.eurprd06.prod.outlook.com
 (2603:10a6:20b:45b::15) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 4658da40-9bd5-4639-cab1-08d99210497c
X-MS-TrafficTypeDiagnostic: VI1PR04MB4606:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB46063AC3E7587FA819A9914BB3BC9@VI1PR04MB4606.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	mMxKAe9yJMn9Y4f/RGVNJGV6bk1RWZZxxqYXF5iu5MpsaIc8TMuggcs1JCXGlDb4t/JLlyLRez9FFkB1c9czsc9ZKx59dgoaSWZD9aLqSYmzkmhcm8G86YMr4w2Kn6STwKIjVqtgvSO4+ZqLx+mnksVKuE9pgQOJQzLtAoACFOS18SPTtl4Z4tp96oNDRQGOebesndx6sIQFZMqCJI6bzjh39Nq4wVfdxIMrwREIgDCD6AaYNN5V+UTATp1yPgKxDzDwEqYsq6YNms8+GmWNRRxIz0xHhw/Hxnh7MF031ZIT4qOEOorQlbp0TAHfdxrBkKeypf2YG2Bv6u3ZRO8rB1L3IEsvdzGAkDAzp+KwreqsMPjorRMXdqRgDv3Wf51EWlZt2bDWmWXhSOcf0ZXPMst1v6CRdKyP7ZAwZisA2e4o2MiVUVClnpmRKE0bgOpYafrH7jwHysw84qbn/IEmwHbf6x/RjcGOpfFStCbUSuXFJToWvQUj81GG7CS54S+PKp6SR4Au0/UhhLFPwEBcxm+Sn09kGRg2X4WuT4rfMLxiHpukoSL3NS5rjkg5E41ddh2msz0CYRoxitO6ytLFNu64kBr0+b9djTmrzE8t+Xjwj4Cyl+eeQVU8KE6DRP6NlhH2IV28gFCznHcd3d5uh23AMDyynRCuTQMqNekuaIaPIggPrH+DVqLwaQKVP7wPLqEGIUrV4MjKpWzFMEwByaAOoy65tL1wAfbNMaXOCM+P2n4574skU/oEOiSaZ2jg
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(26005)(83380400001)(53546011)(6486002)(2616005)(54906003)(31696002)(186003)(66476007)(16576012)(31686004)(5660300002)(508600001)(956004)(66574015)(86362001)(36756003)(316002)(38100700002)(66946007)(6916009)(8676002)(4326008)(2906002)(66556008)(8936002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?EoFKfiaPoh+XQklzmeNwLuIyrccIahg478w+qBBE/a5r3ujzPOxGP8TladLD?=
 =?us-ascii?Q?fKiHO1diMj+wToNn6qDRTYvUSLYaOQDTqEaxDUpcer8WSvMZ5g1omBwI3Tob?=
 =?us-ascii?Q?3Ev5NO2jYD/aan0JbhDZKb/uHsNO5Y1MwdhbGKcUo13hx6IONiZiRz/q8qy4?=
 =?us-ascii?Q?C97hbQCuI5h7NsWqlqzk+PZMQLaSHMVU90aIu2n81yrAjEMW9i7FFySKh5QZ?=
 =?us-ascii?Q?OCNTCn80gD/LtKORhaFGi7dITzFIBdSBrztgltGLknuMiNd43dIbVhbMAcSJ?=
 =?us-ascii?Q?bnzc8cCrRRn4Gww6FFccqaP05Et2cxyJ2NTCYFXm0Si+fZtXK/G/Lcl3zaH1?=
 =?us-ascii?Q?jnoLR80KYqz2wf1jnSIW25oxJ/fNl20VuJbIwrHULnHmsG7n9/7uhG+pwYLj?=
 =?us-ascii?Q?+eHkHiL6I0v6n6Cq4KPpudnw1ZKg09/6XvZI6YHvU8cOBmzGuwkLdEe/sMrI?=
 =?us-ascii?Q?EnbPiGZDjQPktbCsOM85+QDVQQj5l18EvzJBAZiptUD8SCoWb7btbsxEavWS?=
 =?us-ascii?Q?LeTJRNB0D/vCC+WM1TcT50dnwDngfZ/W+iG2it+X7jRw3VdM1UtCeRvWPdAk?=
 =?us-ascii?Q?goI1Rrajj2SMxyVfLToJq5czfxP8tDRldN1GPWVwb0BE/473i/46JjFKZXs4?=
 =?us-ascii?Q?tMsiuwMjXJaCWU9eFGPWANVXYHt5uish3nE10QKqZXXTn5OH0eyS6M451s/m?=
 =?us-ascii?Q?1YOx0Aunl9lTdvWds86H49Ap2IR+vZY6GqGoum0avXU6x+d9XrZuZiQ0fRsa?=
 =?us-ascii?Q?Je4Pn9kDcYGV81WlNmTmw6+zbPwPtFA7V17l6IcrLjw/WB0o5QaI3m0CFnUR?=
 =?us-ascii?Q?eGo+NTEjQvMJNrSQxRifo0MRgGudHgCFPb195e9ECnxX6VBsVqAINNoKh3w+?=
 =?us-ascii?Q?ceCVMJhLyybwQAsrrtMFjP19+JWXTUCG6p5v5P92o7zd651Fasw9iiNqLV6S?=
 =?us-ascii?Q?66p/ts6nERq+nRjVosDNpqKz1QrXGLoj6Zyxulp0rfFWzvr1Za+VKnd2aq5F?=
 =?us-ascii?Q?u/JbvgZIgwgGTA74NnRfufon++cN3cdaAlP1zuAoe4Daz+97ZL6CU/o8Nemd?=
 =?us-ascii?Q?5TLCvJwLovU2BH0UhfosH8hX+yBBXZrsQb5IuzElfORwQ91191CxLcCdSdz8?=
 =?us-ascii?Q?11E3BFmpDnGvSE33tarT7mgER1UwR1Z6q0GYeDg7aBiXm1oOXTclL2UJlt4e?=
 =?us-ascii?Q?5lqZB0J+6XOY0kaWJOMRe7vJMAfgJSGvxUIOW/oWdfDkQSHh/UWIcVMYEbFn?=
 =?us-ascii?Q?VtPBG2xl9Vu0AnnlQF3JS0CjVoIkVmWBnrpWOzPw0/u0u6NQ1nIrlIUIEeKy?=
 =?us-ascii?Q?fLkJaPFdv4ltybwtjcIBW9d6?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4658da40-9bd5-4639-cab1-08d99210497c
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2021 08:21:30.0822
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: OMdPYNeqWcl7j5LnFef+IRcPYbvmry8Gv1vLgPK3+alYMHRyMmWgK/fkt0NUDFcJk+LGu82fPp08+/osHYIVww==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4606

On 24.08.2021 23:11, Andrew Cooper wrote:
> On 18/08/2021 13:44, Andrew Cooper wrote:
>> On 18/08/2021 12:30, Marek Marczykowski-G=C3=B3recki wrote:
>>> set_xcr0() and set_msr_xss() use cached value to avoid setting the
>>> register to the same value over and over. But suspend/resume implicitly
>>> reset the registers and since percpu areas are not deallocated on
>>> suspend anymore, the cache gets stale.
>>> Reset the cache on resume, to ensure the next write will really hit the
>>> hardware. Choose value 0, as it will never be a legitimate write to
>>> those registers - and so, will force write (and cache update).
>>>
>>> Note the cache is used io get_xcr0() and get_msr_xss() too, but:
>>> - set_xcr0() is called few lines below in xstate_init(), so it will
>>>   update the cache with appropriate value
>>> - get_msr_xss() is not used anywhere - and thus not before any
>>>   set_msr_xss() that will fill the cache
>>>
>>> Fixes: aca2a985a55a "xen: don't free percpu areas during suspend"
>>> Signed-off-by: Marek Marczykowski-G=C3=B3recki <marmarek@invisiblething=
slab.com>
>> I'd prefer to do this differently.=C2=A0 As I said in the thread, there =
are
>> other registers such as MSR_TSC_AUX which fall into the same category,
>> and I'd like to make something which works systematically.
>=20
> Ok - after some searching, I think we have problems with:
>=20
> cpu/common.c:47:DEFINE_PER_CPU(struct cpuidmasks, cpuidmasks);
> cpu/common.c:120:static DEFINE_PER_CPU(uint64_t, msr_misc_features);
> msr.c:35:DEFINE_PER_CPU(uint32_t, tsc_aux);
> xstate.c:36:static DEFINE_PER_CPU(uint64_t, xcr0);
> xstate.c:79:static DEFINE_PER_CPU(uint64_t, xss);
>=20
> There is also:
>=20
> traps.c:100:DEFINE_PER_CPU(uint64_t, efer);
>=20
> which we *almost* handle correctly, but fail to update the cache on the
> BSP out of S3.
>=20
>=20
> For the APIC, I think we have issues with:
>=20
> irq.c:1083:static DEFINE_PER_CPU(struct pending_eoi,
> pending_eoi[NR_DYNAMIC_VECTORS]);
>=20
> because we don't defer S3 until all pending EOIs are complete.

As your planned more extensive rework appears to not have made much
progress yet, may I suggest that we go with Marek's fix for 4.16,
with the one adjustment I suggested alongside giving my R-b?

Jan

> I gave up trying to figure out the MCE or power governor logic so we may
> have additional issues there.
>=20
>=20
> Additionally,
>=20
> flushtlb.c:34:DEFINE_PER_CPU(u32, tlbflush_time);
>=20
> really does need setting appropriately, although I think the only
> fallout is a few unnecessary TLB flushes.
>=20
> ~Andrew
>=20



From xen-devel-bounces@lists.xenproject.org Mon Oct 18 08:26:20 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Oct 2021 08:26:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.211808.369469 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcNyK-00030A-Ol; Mon, 18 Oct 2021 08:26:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 211808.369469; Mon, 18 Oct 2021 08:26:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcNyK-000303-LB; Mon, 18 Oct 2021 08:26:16 +0000
Received: by outflank-mailman (input) for mailman id 211808;
 Mon, 18 Oct 2021 08:26:15 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=628V=PG=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mcNyI-0002zx-Tm
 for xen-devel@lists.xenproject.org; Mon, 18 Oct 2021 08:26:14 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 0e214882-2fed-11ec-82cf-12813bfff9fa;
 Mon, 18 Oct 2021 08:26:14 +0000 (UTC)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2171.outbound.protection.outlook.com [104.47.17.171])
 (Using TLS) by relay.mimecast.com with ESMTP id
 de-mta-5-TL863SDfOwitNo4jKDmOFA-1; Mon, 18 Oct 2021 10:26:11 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB6174.eurprd04.prod.outlook.com (2603:10a6:803:fa::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.17; Mon, 18 Oct
 2021 08:26:11 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.018; Mon, 18 Oct 2021
 08:26:11 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6PR05CA0029.eurprd05.prod.outlook.com (2603:10a6:20b:2e::42) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.17 via Frontend Transport; Mon, 18 Oct 2021 08:26:10 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0e214882-2fed-11ec-82cf-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634545573;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=WC8Hjl9zSOo/4nj9xF50M0CWijjrQvuXtd4yotDJfa0=;
	b=VHVPzi01wWf3YSi5jmabt+hlRXzpTuDX264MvKxIoL0xYFd5kXV2VEJb+5ugkNsgSxDk3p
	LudCP7zi+DAv9XNh1hfvMqCanckuvnS7o91R8pcYyJUzXOrIMLLiub16wcVkz3lOLa0k+2
	VbnEVyGhIUHNupV5WBEA3P7pfu2/GF4=
X-MC-Unique: TL863SDfOwitNo4jKDmOFA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=nx5c8dDe2nM9ey/E1a24QZjC7+/xz121bNJAqQbsFmQdGREDd6I35qPzpnXQDNAv3gCLoGCNS32QUvrN1mSePHV9psaK6sI3veRy8c0YiizWDjlVDrjGt3KC/DZHks8tdWSJrwwIhHOuIjYv+5nXjJE1iRhOS/2JRrAacVqmYm707/SihUvdDRmIHKNoiAXd/hWsE72HZD2xoUMvJmcG10Z2VYZ0PgeHPvhUkwbYQ92+cJABi6HpXUuBwoeZChFQoEce9Eg/NNEZ7kHr6VLhKWRkWSmaCQnLgObWYUVn7p36cQfyjaX7OVzJewx4sexrdxVabUXnDJN+cVwVWI8P7g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=WC8Hjl9zSOo/4nj9xF50M0CWijjrQvuXtd4yotDJfa0=;
 b=YN/3wSzVkfX7M76hMLI1AE6v1w6vqUL+bsSauhe0hossAZA4pnDSrXXDEm3hQYKtj3NcpmKo+f6kU+Gj6tIv0+fbx107AQ9i4dkc6PCxF0U4siw9nODN/GO02FFlKSp8yHEJZBkTax21FVAt5TMolHiUeZE4kFmEaeU87GHpKZ4sE88AFgBTcmxd195nED3bEdgQY1pp5DFc9wfJ+ya5j9RBhPJRjnBQRSYrvHUM6KySoNy0WmP3BJe0tDr/XpUEUe6qJdXBRxdv+ijOZzOT11YUQMw+4CzdHLgO3IMPw0ZsliDPAmTm+TNrLBSdm7YvOSGyI7XFd/t4z1Xct/AyUQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: bitdefender.com; dkim=none (message not signed)
 header.d=none;bitdefender.com; dmarc=none action=none header.from=suse.com;
Subject: Ping: [PATCH] x86/altp2m: don't consider "active" when enabling
 failed
From: Jan Beulich <jbeulich@suse.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: George Dunlap <george.dunlap@citrix.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Ian Jackson <iwj@xenproject.org>, Tamas K Lengyel <tamas@tklengyel.com>,
 Petre Pircalabu <ppircalabu@bitdefender.com>,
 Alexandru Isaila <aisaila@bitdefender.com>
References: <f0de7945-84df-8668-f94a-c15cd5196be3@suse.com>
Message-ID: <7f947b0b-4b65-51cb-c098-edf056610fb0@suse.com>
Date: Mon, 18 Oct 2021 10:26:09 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <f0de7945-84df-8668-f94a-c15cd5196be3@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR05CA0029.eurprd05.prod.outlook.com
 (2603:10a6:20b:2e::42) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: a5b7bd61-b33f-4ab8-4e96-08d99210f0f1
X-MS-TrafficTypeDiagnostic: VI1PR04MB6174:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB6174E96C2568FDC0A48F5EF0B3BC9@VI1PR04MB6174.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:4714;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	tEo8Qf42ly+0EPXbkaTKtUG4+9ObT5+M7JwbwEa4nLiwnqnWTGsw3RTRnyW4xqTtpgyXjyR97EtfKCZjpHPob3jBcPhWWUgONG60cr0YQqeLJAWeKOmvN2lbWOOBrOsxAtSLs0izWlpu+J6Sb1RhBZEe9Luk2AFuT9AAhGWSCwEb7jXpBmgRHdRSkTYeM1+ytIhMEklLILaEZoCWL3uGxamPEwwipsvKcvJr/meIPBdfUT+Zynf2L48QO15nhWVpSbaoT+ufk2fOXIVPF4MAvshot9DoxrWbRR1qMlTOned/1lYq1R84IMBCZ8T2uF3McWu5sjWZ7cxIEE5mMKWUkYEiG4ItS6Zu0b1x3j21E1WsTrtaozH04DRrubTEnR+2sVYmHBFP/4MKCWkZxtVNCqRmjPQBUQV38uQobZ1STG4Jmo059r5+ha6yViFSU3DD7heQwrSZpNIrdBuNxPr2MQJbKyx9Rt4rnBEzSQJd0/wXZq5A1VaS5RE5B+JASrMaUajZTCv7HbVmG6ZXyGa/VgpoludsLulqGrRlykj3/2ckhiLlogC3VkcYL8K2Z+3Ab2UQAiAFRdTtd5ZU8t2obLISLAoQR6dD6yspI717/gJWhtphEg4Zqwt32RJDtEYRRUUHyxEzhc9lVGh/a5OFbGnMBfIYex+xgP7NusXy5AgoU2iQ4DPOugTzdWROL6WOZjH+9jSL2Pn9sOawrzP+r9JVzMFti31eMt4G9cDcK1/Tkzf2znm+YMyEjqj/f6YR
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(186003)(31686004)(6916009)(26005)(86362001)(2906002)(31696002)(316002)(16576012)(83380400001)(66946007)(38100700002)(508600001)(4326008)(8936002)(2616005)(6486002)(956004)(36756003)(53546011)(4744005)(5660300002)(54906003)(66556008)(8676002)(66476007)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?aGJCOXNOanRUNExSeWwrT3FNaVV5SW50VTRocWVuRzZMMXVjUEVhZEE0RjBy?=
 =?utf-8?B?Y3R5SUMrMjI5WVNjdEdreTQwK3p4TUtkeXNLQTVCdWJPV0U2R2pMMUJQWWg2?=
 =?utf-8?B?a3RxMENDRFQybkg2MDF0Mk53QkNtSkNIVElDM0k5MW5NQkR6ZDd6NUp1ZEtw?=
 =?utf-8?B?aWlJQUNLbWQydkpPWUlQVHlvN3ZIeFJTMGRHamZ2ZVpyU1FSVXBvYUtwK3kw?=
 =?utf-8?B?cHoyeEtma01jc1E5aW5NSlpSZ3VEWk9PQnl4cDRrYVNNczJNMlBXWFJTdElT?=
 =?utf-8?B?SzZRSXNQcnVNc29sUVZrQWd5Z21BRjBiWGpBTkJ3bzhXRDlmOSsyMUtDRTNS?=
 =?utf-8?B?bnd0QUpRdi84aDZHMzBqMGdIb1B2M3ZBcUJWN3cralVDcUpoNlBLMEhoUnlw?=
 =?utf-8?B?Yk1CYm5WZlhkbFdPSjlSbHlEWS9rdnlEalVTWXVhaWF1MkZaOUhBTTFoc1Rl?=
 =?utf-8?B?VWxldE82aGhkL0IxT3lGMVd6TTdXR3lHRWJxb1JENDkxVldtcjF3OVU4MERD?=
 =?utf-8?B?Q01PWEwrbXR2eWZJSUVueXp2Zm50WlUrZCtZY2U4VHFnQ1FmR0hhK095NnNF?=
 =?utf-8?B?T3dKVlZzNGFrSCtjaGhRYklqQ1BhU2JUcGduc2hMMGpldlF5UmJaZ1E0TWcz?=
 =?utf-8?B?NHloeUlXcjUvTUp1dk9ienFsUFM4WERsSncvMnVoQXdTNWFTLzZxeGFTNEtE?=
 =?utf-8?B?MDFKc3FxVEZWQ21QcktMNUNKdmZjeGl6bUM0K1hDK21mWGpFVFRqK2lXdGMr?=
 =?utf-8?B?a2hITkFzU2dsNHFBUGpTYy9YNjZaZTM3b1JKUGg2L21kOHJjdEI4VWlvTGFG?=
 =?utf-8?B?bG9SK0NJYmpTcDlKNVNIOVlzbmNSVUVkNVp2eEpaSURkK0E1b1IvTlcrWHNR?=
 =?utf-8?B?cEFWUUNOQ2RYN3pOdjMrNjJobnJ1Q0pwbnM3UnRmMlpoZmJ4by9td0NqNmtV?=
 =?utf-8?B?V2xCcGVsZlJBVi9scTFHOTFsSU50N0t2VmN1YWlwNlBTcHNJRXVwaWxDWVZE?=
 =?utf-8?B?RHNyUFo4UzcyekIxNzA0dzJpRzNMWW9FWFhvYUNoM0h4dmlqZ0lYVnNZaHQ4?=
 =?utf-8?B?SXdUWTBzWE9HTWdCdVdrc01EOWFHaVB6RVg3RkdWRDEra3BUSHB4VHhFMVJs?=
 =?utf-8?B?TVdLNzU5dEhvaWNmMWNMVjI2KytSOS9Jd2hpb0NVcHpoREdteUdNTmxvTEUw?=
 =?utf-8?B?dmduV0N5c1FLVXYvYnBqUUo5WmxxSUNQeXVJczNFZHhua3dMU1NJWVhrRjc5?=
 =?utf-8?B?RmtOS1N0K1BqREhmRFBDNkJ3alV0aCtOdmNIb0p1dXUzemhFNitmWnVpdXhu?=
 =?utf-8?B?RlJRVVRDWk1DNldvSWNUUUgxRWVxYU5xZDV3YmtlczVCb3NsNk1oaGVkN2lv?=
 =?utf-8?B?eVgreGtONFpZeWVZRmtLS0cvMm1OQ3Z5cStwNlRvTklyM2ZvMU5WWVM0aFRp?=
 =?utf-8?B?cUxpdlJwZVpMdndaLzNPQUtLeVBIdmV2ZkhtaXJIcFlySFZTaHQxaEVqcUtG?=
 =?utf-8?B?YmpGWktybzMrckhzeG1uVEJzZndoN1o1alVNc3paNXMzMUUxV0pucFlDSy9s?=
 =?utf-8?B?NEtMM1doemlXenhpNEJSaWFGc3JUZUFIUGsvdnEzeDQ3WEMreWt1YkRhRm5T?=
 =?utf-8?B?WFV4SDVVOFRpdmdmeDlVNkdXSWYrUjM1UEtTOVRSNStGOFhWeEpVQ3lTUThm?=
 =?utf-8?B?M0d6WlBwWTZ5MFBUYnNLVTFtSlNIOUc0ZXI3dnFSK3lmZmRHekx2K3RwVXE4?=
 =?utf-8?Q?JhjCAHuVtB0ndoEsBU0836Y4yc/oZDznmVpMY6k?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a5b7bd61-b33f-4ab8-4e96-08d99210f0f1
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2021 08:26:11.0103
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: CV8WQ40NfGH1qZdspB1G39jQmIpfFCpVfDnnKqiPHXRyUVJ7IbJgkNlsbUIN4RhTRtsnHm+ND9viN7YNJdb9rg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6174

On 25.08.2021 11:31, Jan Beulich wrote:
> We should not rely on guests to not use altp2m after reporting failure
> of HVMOP_altp2m_set_domain_state to them. Set "active" back to false in
> this case.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Because of their relationship, I'm also Cc-ing the vm-event maintainers /
reviewers: Maybe one of you would care to review this one?

Jan

> --- a/xen/arch/x86/hvm/hvm.c
> +++ b/xen/arch/x86/hvm/hvm.c
> @@ -4609,6 +4609,8 @@ static int do_altp2m_op(
>              if ( ostate )
>                  p2m_flush_altp2m(d);
>          }
> +        else if ( rc )
> +            d->arch.altp2m_active = false;
>  
>          domain_unpause_except_self(d);
>          break;
> 
> 



From xen-devel-bounces@lists.xenproject.org Mon Oct 18 08:31:54 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Oct 2021 08:31:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.211818.369480 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcO3h-0004U6-Iq; Mon, 18 Oct 2021 08:31:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 211818.369480; Mon, 18 Oct 2021 08:31:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcO3h-0004Tz-Ea; Mon, 18 Oct 2021 08:31:49 +0000
Received: by outflank-mailman (input) for mailman id 211818;
 Mon, 18 Oct 2021 08:31:48 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=628V=PG=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mcO3g-0004Tt-AP
 for xen-devel@lists.xenproject.org; Mon, 18 Oct 2021 08:31:48 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id d498f3b6-2fed-11ec-82cf-12813bfff9fa;
 Mon, 18 Oct 2021 08:31:47 +0000 (UTC)
Received: from EUR03-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur03lp2052.outbound.protection.outlook.com [104.47.10.52]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-40-CZLK6DqUM1GK2xGWyQcF8Q-1; Mon, 18 Oct 2021 10:31:44 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB7152.eurprd04.prod.outlook.com (2603:10a6:800:12b::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.17; Mon, 18 Oct
 2021 08:31:43 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.018; Mon, 18 Oct 2021
 08:31:43 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6P194CA0049.EURP194.PROD.OUTLOOK.COM (2603:10a6:209:84::26) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.16 via Frontend Transport; Mon, 18 Oct 2021 08:31:42 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d498f3b6-2fed-11ec-82cf-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634545906;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=U9fXPAUvp+PI5noEtMwq5/nEfyVlrqz8Jizs1H8AwfI=;
	b=NWmDijg58Br73LK+ZsPFbTG5GHvG/okYbPfI6nVIezy54MOB/cuqWkMXEIasTOBsrrKpFJ
	5zLF7GRJrgFyi6bW9iGgMu+JDzmnjt2SBWMt8M+EoG4aM/aVHbSQ1+ATmHQML5D/KMqHQj
	SR5KK37Sg0llGu9H2k9Y6NfTkvbnNiY=
X-MC-Unique: CZLK6DqUM1GK2xGWyQcF8Q-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=TOc2yzo8J091O9JzRtmGa+FcbegVMDQkfH9A8ynYx0ak7qQk1OlF2vwPnHwskM3DEV6s8docEigPbi2pFHcgSK/WPjj685mkEDRD7fRD7JzD1jBw9QR002897d480ih+G0wFvSpT0mSJYsVVloZhuRV//yoNt7/qeivKlb4XW2o8JaWAZ3uwd8d7sNxoUNHoVezSP+tx1nGfsgbwCFq5BWEQWZFkZjA2J1bQtQU6ItXy/Kva+ymJRWFt3lTwblYXOPJFT49UynSd+fgPxJMYQlBt1t/YvloVZUxAKXbqQJfS43rFBWMMQvj7k32V23iQSdeP/F0c3Dw7UKoi5zE4OQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=U9fXPAUvp+PI5noEtMwq5/nEfyVlrqz8Jizs1H8AwfI=;
 b=WRNIC/wd+ac3BpDiziV/HYlHix7N+fE3FnDNNd3+Q8uGj7yWh6zF+uftsO0/EfL7wXlzNQHHphlgG/Bscub1T0sY9zXQdv6UH0RfsTxi2QZWsoD6tabYVjQka1z60Ul+1h78IDfdLaSn0GW4faHCTnkSeshl9/2xJyh4uVLD+FqCIiqJ9/szfXUQDmtXL26nVHGBsjp9YFCVIVRyEg0Y8QGmK6adG2qAtoevDRFml0m7hOBXr43IBhTqVV9YAqADZv6k/xnjxTgeos6dXo62sIiTtzS7UVEPtNzCuyImILFqgZiXUAdSZAktaHGYxjdlr899nGMgFyLu3UV8PvgFGg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: xenproject.org; dkim=none (message not signed)
 header.d=none;xenproject.org; dmarc=none action=none header.from=suse.com;
Subject: Ping: [PATCH 0/3] x86/PV: '0' debug key stack dumping adjustments
From: Jan Beulich <jbeulich@suse.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Ian Jackson <iwj@xenproject.org>
References: <2a14f2d0-2a53-287f-da36-dfb054c7f944@suse.com>
Message-ID: <9f86c0ce-0a47-dc2f-5642-95c99cb8bb4a@suse.com>
Date: Mon, 18 Oct 2021 10:31:41 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <2a14f2d0-2a53-287f-da36-dfb054c7f944@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P194CA0049.EURP194.PROD.OUTLOOK.COM
 (2603:10a6:209:84::26) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 896db434-9bcd-45f9-4e04-08d99211b6dc
X-MS-TrafficTypeDiagnostic: VI1PR04MB7152:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB71523D87DFC8D1DC52381F5BB3BC9@VI1PR04MB7152.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:5797;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	mKilwBEjSqVWoJDfS08CAl54MFtq24G5ICx2Z8GU9DcVi/SI3EJ4jw53jRYYOuNRJDfsL5y8ykSsCQs0HWYeRgVUobcftnFz2JERpxjyLhAbXkTzVi5sAvymv3aQE86CiOSaJVdVz4N/T5iVVTo4ncHuO2RAKkR8dahLhQf4lUjP/tN7sl0+dfI9zIBLl1Wwzuio7RDwoiB5RJCqAtAdkGj8qhVLwbDZx8ycNF5Ix/F0wxbryVt3DHMN1CpTAMoP1FEq0WmaCEZJDXRz+ll1WpdykYdLNiOOT0rdfVi98H/UGy/tDUM8zvEoj55Vm6J9a84n4JHsksIAEJHMX5K3kuji9Vi0OCyp7eV/CzpT8ecJzSz8BDR+5+bPDEYFh/354YkjjluGaIfhOKDenVxpa9MzEzrrefZve3e9Ou4xzQ4pkfATlDZGZdRUuAL9Pn9jH+6FiaS085v4GIXafEjuEMECZGs6ASwQjEbYenb0ugLzhCO2ILxN58jTMri+2gxFOEKZ5NALSETVxRUUDS2a/6JGtxqYrKl5uuT7xJueCwDw1Wnk7ojp0L5XqDifWAp04aYbR89mXvzg5PXzqsTGMciOeIvjgPYZnbW1DDfVcCiZfKGufIPemw05by9LWH22gSwfO2jVVFKE4vC+F3sPouAa0PjTio5f67taC4zpUJvG/kTFvdBnGyPg5lUaCJWF9YMFSSmV0cnUyfFGkqws74EpNO/iDHs1DV8A1GlJZDlwk/oo+XYb3y27wrKB1/Y3
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(4744005)(31686004)(186003)(54906003)(6486002)(31696002)(26005)(8936002)(38100700002)(53546011)(2616005)(2906002)(508600001)(8676002)(86362001)(110136005)(956004)(16576012)(4326008)(66476007)(66556008)(66946007)(5660300002)(316002)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?M0RMQ0ZOT0ZoMmNnQlYzc3N0R3VvdnZLSEFsb2VrRkpWenNXL1BZUE9FYStm?=
 =?utf-8?B?RmFWSFppMERNdmFvR09wU3ZXQlpMd0w0UmNCMG5rWXN2ZUtCZEFKendybVBy?=
 =?utf-8?B?N1h1VG9tZkdaVW1ZeGZwT2pDUE5QbDNkbXVTbS9EUmdUR0kwdnJ5NzZJeVhx?=
 =?utf-8?B?eVJUR0NYSVovQ2VtYUpmOTU1YWNRQnBlbDdkSlN1aG4zd3oyNnBUS0tKTldW?=
 =?utf-8?B?M2VPejJzVEVZVFNRKzhUSFArNy94VkFIQUwvQkNPbVhuelNSNzBXSUt2dFh5?=
 =?utf-8?B?aWtQdDZ1UWNGUGNWQ2hGcHFyN3poR0pQT3hOcXpCR0JIbkpHd2NBVWFGdkVs?=
 =?utf-8?B?K0owblIzaFdiVzl2ZnhyUEdVd2E4NEM3QU5ZcHNnNy8rbFI3NXcrZXZMczMx?=
 =?utf-8?B?K1BYNkQxekJRYTdlL3d4bndlSVRjQit2N2J3cTFLSmw1cTlGd0ZadDdoc2ZM?=
 =?utf-8?B?Sk51ZnBpSmwwbWFtSVdUbVlPL1NETFU1UTZ3Ykxkd0dpNWpaQzNJbGRuZExL?=
 =?utf-8?B?MVdKeGVYaFNSdnhOY3BhWEs3K3BxcEZWUE8ycCtTR1ZMMHNreFFYOWo0Nndz?=
 =?utf-8?B?akFBR1ZEbjA3THk4YmVpYmo1UkN1WGZpYTlsdUF4WmIzVUJzeEdUVkltZVR0?=
 =?utf-8?B?eFNHUTFzM1VsV053N0VlZTgvY3p1SmkyNEN1V2pwWVNtRmtnS2N6ZmkwQ3gz?=
 =?utf-8?B?WjBNMHIwL1BDZDRHMTF5ZXdpaW9ZSmxnejYwbnB1eUcybUsxdS9BVmdKemd4?=
 =?utf-8?B?TkNXdmV6K3dLVXdSQW1lV1d2SGZIeU5qaFZoQWZpUGd3MU9KdURqRW1rQUFF?=
 =?utf-8?B?NWE2bk9oOXVVNUdibUs5NEVWYUV2R2pBOGk5aXN3WTkyUEZYUUdBdy8xeElC?=
 =?utf-8?B?S3c4dld4Ylp1aTBqWm1VVWZvbm92YkNYdnJIOUFBbzE4b0dYTGlBUitrZXFk?=
 =?utf-8?B?d1VSY3diTVFGQ2tWZ09sK2I0T2k0a0J0OWlYTVBwTG53RUF6MnVKbzE2cUQr?=
 =?utf-8?B?bWhCY0ZGTXJESmozSWxML3dJZnE1ZDdzcnlhbjBDNXRQVXppOTNpQ3Y5Uzhn?=
 =?utf-8?B?Rlk3ejhiZHhSc1Y4N1pFcUdnYzVQbUF1NU56NXMvLzB1ek11Rzd6YTJZMDFB?=
 =?utf-8?B?bWszVGxFeDNUaDNJclM3cDZCY1JKUDRVQnNadFVsdzZZbjdQeEFpdzh2cUF3?=
 =?utf-8?B?WEo3TkdBY1VhMGwwVFd0WDU1cThkMVNINEF6V0NsZHRGTmt6Yit4cDd3enh6?=
 =?utf-8?B?UmtQRGxLMTFUbG91RFU3d2RWZUR5SjMvTGJEQW4wd2lvOHVmbXRCVjRpdERB?=
 =?utf-8?B?M3VBNkdFTG5Zek1EbU5KOW9ONGVraTRhNTV0UkNmN3h4YytZYlkzTk1uKzlp?=
 =?utf-8?B?SkpRb1ZNaTgvYTNKVHBuWmw0YTV4c2VSdmxhUG4wbitNWTdmVjhRNU91V3JQ?=
 =?utf-8?B?bEdQMFFiWkxET0tFb25vdmpRb0VCRWVjYVVUai9wcExBVUxuakhibTc1UWdR?=
 =?utf-8?B?L0lYMDdSSmYzeExxWXB2T2JEUGIzTlZENmVOaG1meXl0YUxZU20rckMvTHg5?=
 =?utf-8?B?c0c2MGFSQUFUZU1uNVI1TDZQendmVUNHTW1nOXRDb3pLTHpTSXpFcU9Ucy9G?=
 =?utf-8?B?R0pIWWM3TXkxSDBtMWYvMmlEY0E1RTZ1KzhkUG5FamdJcTBXM3FvY2dvY3Nl?=
 =?utf-8?B?N1cyZjhOd0UvU2YySXRtY2FTa1VQdHRUa3l4bFUvajBLbCtxK09QQk9EdTFZ?=
 =?utf-8?Q?RaTtdxAZw6P342IrmcNJB6vur/QFEu8vzsLgabW?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 896db434-9bcd-45f9-4e04-08d99211b6dc
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2021 08:31:43.0525
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: LonuiIc3MW0NuheEtCGX2CU7xtc8V2CViEXmhwyV8CKKFqinLgCj2whyU80k3BtptscXubu50lkNYt3YUCwqmA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7152

On 29.09.2021 11:40, Jan Beulich wrote:
> Having played with '0' for PVH quite a bit lately, it just so happened
> that I also tried it with PV, finding that it has been broken for quite
> some time.
> 
> 1: make '0' debug key dump Dom0's stacks again

The breakage dealt with here can be observed in about every osstest flight.
Therefore I consider this and ...

> 2: replace assertions in '0' debug key stack dumping

... this bugfixes for 4.16, while clearly ...

> 3: drop "vcpu" local variable from show_guest_stack()

... this one is only cleanup.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Oct 18 08:32:59 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Oct 2021 08:32:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.211824.369491 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcO4o-00053F-SU; Mon, 18 Oct 2021 08:32:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 211824.369491; Mon, 18 Oct 2021 08:32:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcO4o-000538-PX; Mon, 18 Oct 2021 08:32:58 +0000
Received: by outflank-mailman (input) for mailman id 211824;
 Mon, 18 Oct 2021 08:32:58 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=628V=PG=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mcO4n-000531-Tq
 for xen-devel@lists.xenproject.org; Mon, 18 Oct 2021 08:32:57 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id fdf340e1-2fed-11ec-82cf-12813bfff9fa;
 Mon, 18 Oct 2021 08:32:56 +0000 (UTC)
Received: from EUR02-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur02lp2055.outbound.protection.outlook.com [104.47.4.55]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-31-u0fxkqNxMuaVSXyAW6rMHg-1; Mon, 18 Oct 2021 10:32:54 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB7024.eurprd04.prod.outlook.com (2603:10a6:800:124::8)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.17; Mon, 18 Oct
 2021 08:32:52 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.018; Mon, 18 Oct 2021
 08:32:52 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS8PR05CA0024.eurprd05.prod.outlook.com (2603:10a6:20b:311::29) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16 via Frontend
 Transport; Mon, 18 Oct 2021 08:32:51 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fdf340e1-2fed-11ec-82cf-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634545975;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=0ckteT9f09rmydGrRAXFDU1djCAJx0Y6/nZgDk36Vcw=;
	b=P7uZv7mRSVJG5BLdQKMHiYt4715567a0c0abroC5bD44eOXKFFiUKekN2leuaRmhbCsxYE
	RNbntb9MCV4d2ZSw1EVuY4l3LSNaMCZnpqrFMp37ZAab/P71UW6531Ud0qgY0N3SMd9Tqc
	TkuXxphwnqiHDYz/vxZRTHTZvCrRk6Q=
X-MC-Unique: u0fxkqNxMuaVSXyAW6rMHg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ZEplxdq7J63IkKXsEyJutkPA6zfA8+h9wxSV4AGjDuJmM3mPEjUxm2VI8rD40QUPFNKGm5+Ypl2FakmyaGj3IXe4CNyoxzN0fDPOuYnV7Wj7yK8cfrveTyhAYOwcs1+Fd1s7ocpnUjCT3MexWojK1V0vVvaNEiE09abP9qTYH3KewJ41i3kktSxnIcjvV2iyTcHyt077Ru1bl9YbiTTa/rtFA4Ai2+PnEx9jgErseUMRh9nwBh8VgP27Tt8HdiN58izAk94vFMo6dGtVzUovdUPF7o9EVqOUFJgUpAtUjU+N//uBmrLhlJcv9TBc1RH9NjjbFNBiY/FNpTKDJrQCDg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=0ckteT9f09rmydGrRAXFDU1djCAJx0Y6/nZgDk36Vcw=;
 b=As/jVrJwbpwtw2UmHBYdg6fQ07S3vA1HOQBKjwNsGHV73GN+ugn4V9rdrhx64JciJWbRWzWvxPZ2uRz2LsEk1X1fhOQBt2u+Ng4vEcRaNZqQ3Mo4A6UpTgHbi3pEigZzxFNBvXNiAegmAJQZZqegj97xgHBP4xezt3TxCA6bJwGtFruYy0SMGlHZrVogRuiN3eUwwk0PlQNZJtz8ArKPCxaFP07/nLm3L5AXqhoAOUtgn05ucFL7sDsj7SqMlQjl34SHK7MaHdVC9pEOn4lBFQFuCPKjUosTRQ9tTZGnmkcdLWBgvRGBMwrWP1G08v97ErilzNHPL+yOcQtxiyrAow==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: xenproject.org; dkim=none (message not signed)
 header.d=none;xenproject.org; dmarc=none action=none header.from=suse.com;
Subject: Ping: [PATCH] x86/paging: restrict physical address width reported to
 guests
From: Jan Beulich <jbeulich@suse.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>, Wei Liu <wl@xen.org>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Ian Jackson <iwj@xenproject.org>
References: <e0acfa40-0901-2fc9-31b6-c2609625de22@suse.com>
Message-ID: <aaefaf9f-3970-b954-ba1f-0b4ed70c1fb4@suse.com>
Date: Mon, 18 Oct 2021 10:32:50 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <e0acfa40-0901-2fc9-31b6-c2609625de22@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8PR05CA0024.eurprd05.prod.outlook.com
 (2603:10a6:20b:311::29) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: f9612f6a-5b56-40cd-edee-08d99211e00f
X-MS-TrafficTypeDiagnostic: VI1PR04MB7024:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB70248F6AD87346BE2C9EFC9BB3BC9@VI1PR04MB7024.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7219;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Xz+XYD/FdHTQA/H8JXEPbqsRgEyGj4MymIpSaXvMVd7AYrllo8lGoJDouv94B2yGya9/EzUJKzh+9/yY10F6P0k2r74mp0IAE9AmwFvB1BWZ/Yj1M4eqYqoU0eUT1a7jqeIBMntqoHQ+RFDgmR2MPxekHIkr8VvuCddRET4fEdjw/Y82d+z4Za68xNgWCVsPofCnKD/cmeJwqm1ACVhky6+ii279qmrJy0lcnawjarXirdaoT8EVwcIe/qHSLNf6JCo6/frjAdzZTDIzrVIVToDru7LAo+pIaVqVfkM7bhFLnReAskGD64eq+4P1FWBf4RMQOdCNoe8qieqDzkD+YY/+598fhlwQMP8e0g/JnUCmrbgoQ+OaaIRTHu547UNjINMZBPSzZwZNfe+sATQhGja1DyAE8tbuCATYZu+R9bES5EIwm+l+AVbeMfYSWnE7fMGogo1IKpipOeCBK0Zme6qIFUqLRWiD9o+iqW15VAQ2k3PcRMAx3O0A5Fi9p7Qi8Ri0zc3LFMot3VR+76RSVJnfhz8rKZJBzka/rMuNwLIN2P5LfJWwXA3Ql9QL5mPhNpoNBXUPMSwVdrgo/90HG+RRPEti6AUfuWIdhQlCeIXKdTYwUw/fqbEHAVuatx5tU9/wqqRp5qXXSKF1VYBXbSnqRUCCZMo6w0vFtbaYS2E7769mEEPknobVb/DY2n1f6ByXkY706gb4LqMjWzaVPFZ6cZB0J7Kpd9oXL6d5C2U=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(26005)(66556008)(6486002)(2616005)(66476007)(16576012)(508600001)(8676002)(110136005)(36756003)(38100700002)(4326008)(66946007)(186003)(316002)(54906003)(5660300002)(8936002)(2906002)(31696002)(86362001)(53546011)(31686004)(956004)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?S2JWYmFPY1FkTkF2RHEwTGJ4cUlxdUU1UVVGUkhyeEJmT2VBUE1lWmNISmZw?=
 =?utf-8?B?bVl6aGp2b2d6MGMyVGxUNERRUFdCNDd3R1FONVQ4VDROR25OLytmYVZ0VXZw?=
 =?utf-8?B?SUxEOTJuSm92ZHdOQ1hRR2xwQkZKeER3d05VN0x6UGpjK2VXWXBFT2Viam9l?=
 =?utf-8?B?OVYrRFp5ekVqYkpUS2Q5OURyMTVBRmRZODQ0bnlGVEtJcWlQMzYwQ0hFV3pJ?=
 =?utf-8?B?QzVBWFZCNUxDMXorcDRNUVN3S3N6NDg0YWpRbGRTOHFWZTR6K3BpZGpTcVN5?=
 =?utf-8?B?Y1N1OEs0ekdTaHlDcm1aYWUvQzFGTDNYQVhrSXI3WjRiTGlOblZwaG5UeldE?=
 =?utf-8?B?ZytJM2Fxb1RUaGNoNDdaZDlyN0RvM1NydUhjbTljMVMvL0ViUGY4QWh6azdy?=
 =?utf-8?B?SmxnWWMraGdwTnBwandaekYwSWdxYlFxMGFkTy9zMFpyNndWQ2JuMWx5bmxJ?=
 =?utf-8?B?YThVUndmN0svRXJxbUM0ZnFsYmRSbjE0RTF0a25wa1FpKzZBdXRjQ2QyOW1S?=
 =?utf-8?B?NUw0a1Q3M2lLSmdwZmU5aEh6OTNJS3A2S0FxMHJsUVgydGt2WjhJYUJDMG1F?=
 =?utf-8?B?RHBXdmcvNy9abk04aDJiM3ZveWZPcDBvVlIwYlNSNTg4Z1RBK21BYW14eWxt?=
 =?utf-8?B?YzYzb0hjdDNUWXU2WFRUVCtrd3MveXZSaDhhRHdvMmtCdHlkS1ZJOFNyS3pw?=
 =?utf-8?B?bnRjTUxySFpqR2h0N1E3MVRVVmNoOHR3Y2d0OWxYdk9Sb3oxMzBqY2hWQ0RS?=
 =?utf-8?B?NTFqYWJlSy91Nzg4SXYzSnRZWHNQMjhURnhiNUxMejVQUmhvb0EvK3hCbFcz?=
 =?utf-8?B?N0VYZGp1SWEwNkNvQjNVWlUxNE1Qek5UdEN3aGtqdzlHcjBtY1R5bGZSZUwv?=
 =?utf-8?B?UnNaTE1iWDdRZmd6Y1lNNFVhQ2N0MjJwSG5aaWgwU1lhS2JES1FBblZHekhi?=
 =?utf-8?B?bk4rVjV4ZlhBZ0ZvVk9UcDhQSWpyaHBZZnNIYnJPa0dNL3MvRzhUZ1JrRkcz?=
 =?utf-8?B?TVMxTTVHY0ZYOW1zeFo2SkVZcmwrR1lseGhKaGlZeTdmTkNzY0xmMVhPNDFu?=
 =?utf-8?B?ZkJmYlFsalNUNXpYbU1TTHQvc1dPMEp4Y3FxS2phM08wQVRrdENmcjBrQlpn?=
 =?utf-8?B?Q3NOUUxDQjFkMW9GbkVTMGo2VGNyYXdUajZ2OVBGbVZzdndDTm4xQ01DREE3?=
 =?utf-8?B?VFVPMmxvYjlDbmMzYXRHVzZZVndCemZXcFM4RDg4Q0tsZXdKRFo2MTU3Zmdi?=
 =?utf-8?B?cVhkalhreDlFTmJkNGhhN2J2UUFvbVhkQmUwai9udlBtUklCRVFRNXNtZVlP?=
 =?utf-8?B?bUZrUFlxNUlJRjVpbXN1aHJodmpUdnVOK3YzdXN5UE1rUUpEUmRkT0lLaE1Z?=
 =?utf-8?B?dzdGdDc2N1ZGNlp3dmVyc3Z4cTVQUTNaaDRGV203Uys4RXltREVnbkdNZGhF?=
 =?utf-8?B?alJwWVJlL01IcnVmRmN1SXJOTXlmWnF5UlEvL1NxL01uRnlGOXBWNjkwODdU?=
 =?utf-8?B?dWpsVWhCM0JITFUvU0lZTXJYS2ZncVNWTStxTGJtQUJrcVpHUktIWnZLamNu?=
 =?utf-8?B?am4zY2c1YlJyMG1Vb0dIOUxpb25FejdHV0czWlNCRzMvTnJKL2FDa0hyMktI?=
 =?utf-8?B?NUtwajR2dTAza0NBbEgxK2pXQTJxZUdwdzVabS8vS2VEUXAzN252clBUWmdD?=
 =?utf-8?B?WHAybU14MnNhY2VTdzhsOFZucXhOZGdRTzRHN1RMbDUrckhjM3k3TDFQUDVD?=
 =?utf-8?Q?1YBjxqdVgaNrsypXwHkZsWQ/c31JmKahD1a0BG2?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f9612f6a-5b56-40cd-edee-08d99211e00f
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2021 08:32:52.2694
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: hTSIDcJW7VIeTbZLs6M3aPIfVpN+SlqUylqrHs9EkIyElNfhViJlNo+syl1U0ldJC5EIY6IWCyJpIfWooQCuqw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7024

On 29.09.2021 14:47, Jan Beulich wrote:
> Modern hardware may report more than 48 bits of physical address width.
> For paging-external guests our P2M implementation does not cope with
> larger values. Telling the guest of more available bits means misleading
> it into perhaps trying to actually put some page there (like was e.g.
> intermediately done in OVMF for the shared info page).
> 
> While there also convert the PV check to a paging-external one (which in
> our current code base are synonyms of one another anyway).
> 
> Fixes: 5dbd60e16a1f ("x86/shadow: Correct guest behaviour when creating PTEs above maxphysaddr")
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Anyone?

Thanks, Jan

> --- a/xen/include/asm-x86/paging.h
> +++ b/xen/include/asm-x86/paging.h
> @@ -401,11 +401,18 @@ static always_inline unsigned int paging
>  {
>      unsigned int bits = paging_mode_hap(d) ? hap_paddr_bits : paddr_bits;
>  
> -    if ( !IS_ENABLED(CONFIG_BIGMEM) && paging_mode_shadow(d) &&
> -         !is_pv_domain(d) )
> +    if ( paging_mode_external(d) )
>      {
> -        /* Shadowed superpages store GFNs in 32-bit page_info fields. */
> -        bits = min(bits, 32U + PAGE_SHIFT);
> +        if ( !IS_ENABLED(CONFIG_BIGMEM) && paging_mode_shadow(d) )
> +        {
> +            /* Shadowed superpages store GFNs in 32-bit page_info fields. */
> +            bits = min(bits, 32U + PAGE_SHIFT);
> +        }
> +        else
> +        {
> +            /* Both p2m-ept and p2m-pt only support 4-level page tables. */
> +            bits = min(bits, 48U);
> +        }
>      }
>  
>      return bits;
> 
> 



From xen-devel-bounces@lists.xenproject.org Mon Oct 18 08:34:50 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Oct 2021 08:34:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.211832.369502 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcO6c-0005gG-8F; Mon, 18 Oct 2021 08:34:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 211832.369502; Mon, 18 Oct 2021 08:34:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcO6c-0005g9-4w; Mon, 18 Oct 2021 08:34:50 +0000
Received: by outflank-mailman (input) for mailman id 211832;
 Mon, 18 Oct 2021 08:34:48 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=628V=PG=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mcO6a-0005g1-KF
 for xen-devel@lists.xenproject.org; Mon, 18 Oct 2021 08:34:48 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 4009c12a-2fee-11ec-82cf-12813bfff9fa;
 Mon, 18 Oct 2021 08:34:47 +0000 (UTC)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2110.outbound.protection.outlook.com [104.47.18.110])
 (Using TLS) by relay.mimecast.com with ESMTP id
 de-mta-4-egRkkfEqOFyLqaS_4orqyQ-1; Mon, 18 Oct 2021 10:34:45 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB5597.eurprd04.prod.outlook.com (2603:10a6:803:dd::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16; Mon, 18 Oct
 2021 08:34:44 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.018; Mon, 18 Oct 2021
 08:34:44 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6PR04CA0011.eurprd04.prod.outlook.com (2603:10a6:20b:92::24) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.17 via Frontend Transport; Mon, 18 Oct 2021 08:34:43 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4009c12a-2fee-11ec-82cf-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634546086;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=O1WCzCUHowXa3IVmqwgrjYgiYZ+gsIQw4nCQKvcHNBQ=;
	b=d4+kRcUjhLJQxsrU2WjT3KpIOn5P0/C/E8Yun13/Cgyv2JIXUcRStS8cEU1sxKXTvbApEs
	RZuTftCX/jccL2QtzEPYsXU1cfDXXGtGoKwgHmyDZ0CwRvKis7/M/aeVYyxUkHEqxkfQ/q
	KQnubJ2VZqX7y4QJoYmCGpwkNichCBA=
X-MC-Unique: egRkkfEqOFyLqaS_4orqyQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=jFEZQOC9hQ40uTXlS26LMAP1K4jJfQPadRGvMiz3VyTXnnN0keDr1178XzGAKtaA83f1aKGYPNM1srNKxhYCuNd4b2lTSzWqBUGc5xo9KolV4CT8SzVHYBNXRisS6zzGf0CZC+HRVCmIW6vEVYq58mP4jce5vpgDA8on49xiS2LaRs46NlSfPrCxmHl9csfFq/LpTzs7hweMSfq/aPZp9jqpPU5OpiuirnYqpE8sMb4WPAxivh6zKCU4pn5pbVjxhm6073PpAryB7oHdIDN2XgUKaFLRU7wdYxECINArmEJmEupjUjOTh4CEXcpeZ+V1tqqQsgP9GPQlGg68+f4uNA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=O1WCzCUHowXa3IVmqwgrjYgiYZ+gsIQw4nCQKvcHNBQ=;
 b=YmVP4Gwb+5ZiFx8YY/qS16lo7ZxBKpMZJwHvnETnlUriKysgENSo7sVy+r+gPd9T3KW/COZ63h69rSOL9cIuqO+5BaqORctJqwQlYk1T0B2OTP0mj9bfz4V/7La+2WqFpOuyHB9MWvnsMfOmpwGMImgHtdszh74SQkK1nPT4bW3rt69QfE9XAE5QB4LCqKZDkuzdEOJpBrSRiOXNUl+91JX9g6Mey3PLFgVxk+XLbmLgW71dadW0gQ9vLGDq4FA+OVFrtB11vtSmfvUYE4yeYIVCvjF7u94MZSGCo3sJGuEqwlbWQVcaO/rEZlLa3gAgRMYzhYB0jRyTkrey+SiGPA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: xenproject.org; dkim=none (message not signed)
 header.d=none;xenproject.org; dmarc=none action=none header.from=suse.com;
Subject: Ping: [PATCH] x86/PoD: defer nested P2M flushes
From: Jan Beulich <jbeulich@suse.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: George Dunlap <george.dunlap@citrix.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Ian Jackson <iwj@xenproject.org>
References: <e47d51c6-1b4b-2f72-6e12-070df66c30e2@suse.com>
Message-ID: <462b493a-a745-e6cf-b86c-c4dcd285acb5@suse.com>
Date: Mon, 18 Oct 2021 10:34:43 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <e47d51c6-1b4b-2f72-6e12-070df66c30e2@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR04CA0011.eurprd04.prod.outlook.com
 (2603:10a6:20b:92::24) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: f057857f-9789-463a-5bb7-08d9921222d7
X-MS-TrafficTypeDiagnostic: VI1PR04MB5597:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB55974C306AC1B7D1FE8CC703B3BC9@VI1PR04MB5597.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	gOAG4YzJPz/Gka+n6lJM6mUERRiGv6Hf5ipwzu8HBnqeggtrC3WQYwx7e54yOJpcrF/j78XoodVzcS7JmzytqmBlHDsMHXm53GylUtFiEC9678aQ+D3hO8Hb1HQ/Bvgq41E9TtB58g4/yijGpJSxcBL2ZhdgKMjF2JD7b/7ZrN2IABizSwf4SEqDaicqkhh8z4tbXusLTwzu8KtYJqSMVaePn/AAu17rZQhY0gUmWSZt+jA7JC3yBOK+E3uzRhR/hDAoyVyYOlDq0g9H9DkIcps/mgXDeLur56KyY2yn9Q2TNQAMk6Ic0q2577btb5dLNAxUzkw2SwJ1IABLN0Uxx8Nyj1RREGYxnDHrnZYfK2lZRxJ03tuT76KLP3iZWxLCTczMs0nEo4sIYShUu7t2H9b0tz/Fi4GYZMNjOLEuX0e8bdKJbV6ZDW/RDbMeaYE3bpeNG80Pfeid/G6g8kx+cr21h4n0VOP1fIHmjTyBhKXJ2yShQc9s8moBB+Z8G3TfXX4kIAveLunYXIa9tapBICgQIw22lbzkhjS1S5+ZWz6V1JOg82lW0+KiyFxivdyF2ozt+WVatqzfBCc79q3Wn3fRNBB4r9CHm3jnc08YTE6zUbovUwjLiGf1X4d2Z6Quc1lBoX00JhaXKJ17qsh5CSdcBUnOeAo6YofMyntwANa5+iquFfZhqQY3MzpfV68sWa0l1JubWblfpvoo9VtQW8cSmjg8CSgyKU0XvI0s3cQ=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(956004)(316002)(16576012)(2616005)(86362001)(54906003)(66476007)(26005)(186003)(6916009)(31696002)(36756003)(4326008)(31686004)(8676002)(508600001)(2906002)(66946007)(8936002)(53546011)(5660300002)(83380400001)(38100700002)(6486002)(66556008)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?T2RWTllGd3U1WUdIMmtyb3ZiWWdDQVpBUnJYb0lldmE0dWlEbDJ0d1ZzSnU4?=
 =?utf-8?B?OWdYc05taDRlTDIwTm56TEd2ZERiOHl3VktZU29vY0lSZTlzL2N6OWRBR1FB?=
 =?utf-8?B?VEdldm50ZjdFZmVWQ1RQWWhTRmR1eWpMc3VEOGdEMkF3YW8xZk5XcitwZUY5?=
 =?utf-8?B?eHI4WkFZVW9mbTYyb2JKYTNyZWhlSit5OGc0UHBpdFgxaCsvaTFKSnV0U3hQ?=
 =?utf-8?B?QTcyaERVcE94c0dVUDFwSU9LeXdXNGs5SjBzMlA0TElmRGY4K1QzZTRzb2VJ?=
 =?utf-8?B?U0RQRklBUFU1T3JQK3hLbmhKNjhmQUlRVnc2eHJBOUdSMHo0ZStGY2Rkb0o4?=
 =?utf-8?B?RVljVXlBdnhxYVhJQytuNzUyUVZheVFUeFNuNFZVMGtaYlZ2OXl0SUpoQTJj?=
 =?utf-8?B?YUY3c0JoQTI5dCt0Nm54YjFIMjJzaURaQXRYOUF5TEt3cWVaSXpaMFV0eHNr?=
 =?utf-8?B?SVNiT1RHZmVnM0NrY3UrVHp1N2ZyQkRGRGUvUVE0dXFhSUtBUWZWWXpGM2lD?=
 =?utf-8?B?cVB5aFU0V2VYd0pnNXg4TjI1SlROajg4RWpsK1AybjNYSFA1bThqbEUzUEFP?=
 =?utf-8?B?SDU3Ym5TTmxrYzNXTlpOd0VCdXdRZjI3dlppN255QloyZXpDV3d1aDNBVWN2?=
 =?utf-8?B?Qm5kbXl1WVJLVXhJYTJOeC9HTzdKcmgzZWZvZStaeVdHcUswTmhuSERHQ1Ey?=
 =?utf-8?B?bzJ1RllmbkIzUHlYV2lkN09YWG0zOUpWYlZHSysxamhIYTZraHk3WFNoc2h0?=
 =?utf-8?B?TzcyUWhhMXQ2UXk2ZTZhWmh3WUtWN0VaczhZTGNQSEYyRnhHVXpiQzAxNmNi?=
 =?utf-8?B?UzRCcFNXZE9yeDBxM0RkRUkrTElhWUdBUFZ4QVNacVduWWZydlBiUnBxTUVq?=
 =?utf-8?B?NDhBR2s1M3FVN2liK3Z4RTJiaXFvdHl4NXBXbzhYd2p2RVRra3Z1K0JqRWVO?=
 =?utf-8?B?SmNpdW9TdWxHL1BWamdqcDJRT1N0YlplRzFJVHVZaGtFQlkvajBhVGtaM2Y1?=
 =?utf-8?B?alkxcHQzQ0F0bXlwNEoxcU9PZE9BdGt5b1N3RklmSWhsYSttMGhPYkhsRXVv?=
 =?utf-8?B?dGdPbWVLa24rZThRYnFYUUlLeXlSRjBLbVg5bllwRkxqVU1saTlKNUk4VHJq?=
 =?utf-8?B?V1A0dVI2L2NpYzBiUjBxMC9zRDE5N05PbGJLQW5yaGNUWlFMUWxlR0VlNVhj?=
 =?utf-8?B?UEFYNUJxTzFYRGIrdldTbEhaajVLVjdWY1lHdkNkMGRUTjd4aHZSSUdIbXdo?=
 =?utf-8?B?alVEdU5IUlh6UlZIa0tZb3VKVnpKU0FlZ3lMc2hJL1k0b2hPaXd3b1grMUtM?=
 =?utf-8?B?STQwTlNNWnBTQWd2V01jazZZQU1kOGw0SWZ1VTh5ZWszUS8vNForSHZQSGh0?=
 =?utf-8?B?aWJGVjYrd1l4c2M5R1FSTDJDWWpOM3ZZMmxBYnpJUHV2dHVTcFNrWUJMaGZm?=
 =?utf-8?B?bS8xZU9ieGIxTTVhUENOYll5blpub1pNZ2pWUGw1bGl6dnJ1U3NOZXAyeURy?=
 =?utf-8?B?L2RTTEgrNlI3RC9sRVJzam4rZU5HSjdZVnlCQWZPeGdBaWZFeW42VkRpWlpW?=
 =?utf-8?B?MlRtK3g2SG9iVjFzTlk5Nk9BOE1pVkJnaXNsais4MjhmRENxSDFKR2FkbkJW?=
 =?utf-8?B?eEY2V0lnR0dhUWs0MTBrV3VPMUVUUEg1QVBwaGV2TnN3UWNHcUZLR1Z0Qmp5?=
 =?utf-8?B?aGVsL0tuUmtaSEFHeVV1YWp5dDhBaXRHZDJlUjh0cjJZVnRoRGNoR0V5dHdJ?=
 =?utf-8?Q?k8BD3gkfJf8cvZlrpAVxmluR4MwtCRJjLSvGR5s?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f057857f-9789-463a-5bb7-08d9921222d7
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2021 08:34:44.2041
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /UT55Qu8QCLXdBD9dJnYNvBrGQDfMqNQthjvhsu5XBTr6VOo6U4nEvP30VvQSkA7fYMT8UN1vLPy0yOG4TjEsg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5597

On 11.10.2021 10:17, Jan Beulich wrote:
> With NPT or shadow in use, the p2m_set_entry() -> p2m_pt_set_entry() ->
> write_p2m_entry() -> p2m_flush_nestedp2m() call sequence triggers a lock
> order violation when the PoD lock is held around it. Hence such flushing
> needs to be deferred. Steal the approach from p2m_change_type_range().
> 
> Similarly for EPT I think ept_set_entry() -> ept_sync_domain() ->
> ept_sync_domain_prepare() -> p2m_flush_nestedp2m() is affected.
> 
> Reported-by: Elliott Mitchell <ehem+xen@m5p.com>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Thoughts?

Thanks, Jan

> --- a/xen/arch/x86/mm/p2m-pod.c
> +++ b/xen/arch/x86/mm/p2m-pod.c
> @@ -24,6 +24,7 @@
>  #include <xen/mm.h>
>  #include <xen/sched.h>
>  #include <xen/trace.h>
> +#include <asm/hvm/nestedhvm.h>
>  #include <asm/page.h>
>  #include <asm/paging.h>
>  #include <asm/p2m.h>
> @@ -494,6 +495,13 @@ p2m_pod_offline_or_broken_replace(struct
>  static int
>  p2m_pod_zero_check_superpage(struct p2m_domain *p2m, gfn_t gfn);
>  
> +static void pod_unlock_and_flush(struct p2m_domain *p2m)
> +{
> +    pod_unlock(p2m);
> +    p2m->defer_nested_flush = false;
> +    if ( nestedhvm_enabled(p2m->domain) )
> +        p2m_flush_nestedp2m(p2m->domain);
> +}
>  
>  /*
>   * This function is needed for two reasons:
> @@ -514,6 +522,7 @@ p2m_pod_decrease_reservation(struct doma
>  
>      gfn_lock(p2m, gfn, order);
>      pod_lock(p2m);
> +    p2m->defer_nested_flush = true;
>  
>      /*
>       * If we don't have any outstanding PoD entries, let things take their
> @@ -665,7 +674,7 @@ out_entry_check:
>      }
>  
>  out_unlock:
> -    pod_unlock(p2m);
> +    pod_unlock_and_flush(p2m);
>      gfn_unlock(p2m, gfn, order);
>      return ret;
>  }
> @@ -1144,8 +1153,10 @@ p2m_pod_demand_populate(struct p2m_domai
>       * won't start until we're done.
>       */
>      if ( unlikely(d->is_dying) )
> -        goto out_fail;
> -
> +    {
> +        pod_unlock(p2m);
> +        return false;
> +    }
>  
>      /*
>       * Because PoD does not have cache list for 1GB pages, it has to remap
> @@ -1167,6 +1178,8 @@ p2m_pod_demand_populate(struct p2m_domai
>                                p2m_populate_on_demand, p2m->default_access);
>      }
>  
> +    p2m->defer_nested_flush = true;
> +
>      /* Only reclaim if we're in actual need of more cache. */
>      if ( p2m->pod.entry_count > p2m->pod.count )
>          pod_eager_reclaim(p2m);
> @@ -1229,8 +1242,9 @@ p2m_pod_demand_populate(struct p2m_domai
>          __trace_var(TRC_MEM_POD_POPULATE, 0, sizeof(t), &t);
>      }
>  
> -    pod_unlock(p2m);
> +    pod_unlock_and_flush(p2m);
>      return true;
> +
>  out_of_memory:
>      pod_unlock(p2m);
>  
> @@ -1239,12 +1253,14 @@ out_of_memory:
>             p2m->pod.entry_count, current->domain->domain_id);
>      domain_crash(d);
>      return false;
> +
>  out_fail:
> -    pod_unlock(p2m);
> +    pod_unlock_and_flush(p2m);
>      return false;
> +
>  remap_and_retry:
>      BUG_ON(order != PAGE_ORDER_2M);
> -    pod_unlock(p2m);
> +    pod_unlock_and_flush(p2m);
>  
>      /*
>       * Remap this 2-meg region in singleton chunks. See the comment on the
> 
> 



From xen-devel-bounces@lists.xenproject.org Mon Oct 18 08:35:50 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Oct 2021 08:35:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.211840.369512 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcO7a-0006MD-LA; Mon, 18 Oct 2021 08:35:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 211840.369512; Mon, 18 Oct 2021 08:35:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcO7a-0006M6-IG; Mon, 18 Oct 2021 08:35:50 +0000
Received: by outflank-mailman (input) for mailman id 211840;
 Mon, 18 Oct 2021 08:35:48 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=628V=PG=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mcO7Y-0006Lu-Bg
 for xen-devel@lists.xenproject.org; Mon, 18 Oct 2021 08:35:48 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 92e5773e-a72f-4d2e-a218-f7624e85d601;
 Mon, 18 Oct 2021 08:35:47 +0000 (UTC)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2059.outbound.protection.outlook.com [104.47.14.59]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-14-YW907A7YPUy5Qt-4rGwteA-1; Mon, 18 Oct 2021 10:35:45 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB6301.eurprd04.prod.outlook.com (2603:10a6:803:f1::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.18; Mon, 18 Oct
 2021 08:35:43 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.018; Mon, 18 Oct 2021
 08:35:43 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6PR04CA0020.eurprd04.prod.outlook.com (2603:10a6:20b:92::33) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.18 via Frontend Transport; Mon, 18 Oct 2021 08:35:43 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 92e5773e-a72f-4d2e-a218-f7624e85d601
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634546146;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=9Be5Vu1m46e4fiokuLaLORTjHSI9COvms1i1iq+Sft8=;
	b=ku/kZ/16XXEMcr+/GIZwH+A/LT1EzXYZw42KQjhIlNepKKSPWlPScH1frItC9MMcDG1zKi
	VP54wi66iOorfpX48ShORXP+PohNHLuG93p4aML/g6wdu2rBHUwIZNHz9s6u0Yr3pnF2W8
	4KGuDgmbBVpNqzn9j5OTbr404E0tRIQ=
X-MC-Unique: YW907A7YPUy5Qt-4rGwteA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=cr3VWQ5KRbMsC1gJMySXBuzURZO2g3wyd+oar8XqQ2AzPdl3SWHRbwFgpPtFiEu3AhbVbJiWUob8dfvdPFkqKucDaz7i6ezTczTv+h7JoIU/R9g9w9Z/PLOLZ/gpn6Njtryg4DLQq3X76ijJnPTKEvQ7RR6/BK3YWL5RIY7w8JJUouB3OEoJmiwKVugCYlU4s/ss/MQbIuvtRFd0jd04LQ7UHhYh2Qb/V70t1+HWwQ85QffRSh7Lcf+ONCHiLYNGxGCmdqaFDrnwejGukBOA0S/zhPtag5kGQ7+WC1gcUjpVaQ7zPpsCjFWGnaywJ5e/NL0JIcdWkc7gC7toyu9dJQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=9Be5Vu1m46e4fiokuLaLORTjHSI9COvms1i1iq+Sft8=;
 b=JIIJNCOOMiLFXVzcJMm5aZzHnRiz+sZYu2mvDDqAImh5VgyCZ/QTtO/2TQhfSGmDQw5Nke2bKTyobPS0JJrJrk4fPhUggJWS0TViOdd6nRtQ3Z63KUhj3AYOe6GhQRsfpEaOu84vj4FTMyC+wjMYRNMkE1j7ixn+iby7eXM6VpI+tJLqOTM9CIru+nXgB44pr+6ec7T2y1+o5fhXsYC5VxU39oPKJFDATvmRRHXvgbinm4TX1WEL4yuIP48QgeZ2SgP4WkX1Tbp8NcNqLsfHdMz30i7lCkA5JHwUSKTzxMXEgdCDSLv6rE8j8OZ8V6V6j8RDn9eXQaaghV46Uhw6CA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: Xen 4.16 development update
To: Ian Jackson <iwj@xenproject.org>
Cc: committers@xenproject.org, xen-devel@lists.xenproject.org
References: <24913.54299.590779.955301@mariner.uk.xensource.com>
 <24925.34307.187952.463474@mariner.uk.xensource.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <e644a1d4-a7a2-0554-f639-e19ba3102294@suse.com>
Date: Mon, 18 Oct 2021 10:35:42 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <24925.34307.187952.463474@mariner.uk.xensource.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR04CA0020.eurprd04.prod.outlook.com
 (2603:10a6:20b:92::33) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: c1b705f9-26d4-465b-00ca-08d992124634
X-MS-TrafficTypeDiagnostic: VI1PR04MB6301:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB63011ABE96425A9F2CC1E48FB3BC9@VI1PR04MB6301.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	/YQ1QAV1W0rOFiZINyfZJs8TJeax409xkD7Q2UAjtKo6HZRuDSfthCTmUB+xUYsKjSGt/1WRm/0Zc9rGDmDqgayPzdEJTob75Xle/7of+kOjb3EjTd7haiB0Aa8/vcO24CuKzzqxeAZz58tEwqSio5OorIWBBmKm//fOHKX20N1xcM+BY3yo5C9qJnmoQj7RPNRfYuEPaMvo7x0qZzd1fVZK8TXX03Ih59d0kugYjozTyzGaTINgXXwBX/9qNCBb869446AfN/Z3KMjMEeCkBlDVjVCu/F75/Vy8K1Fwmx/+eRxiscUYVdtciZ5XQh0757WH4Mklwc11cV6xoziyLReuAkknA8bKph8A66tTiii14GKOmnm0PTjd/8JCx8p4I32jgcHzU+w6m2cXneSBtobxcNfqEfVfeYHTc1BeV7zoRPSdonLGZD5W5IRjy7PIr7KYJ6uW8lKR18FWqEeilsk9ZH0AokR6gOPkE89Syd416RrSCZatVtflfZp/EzIXw9KzAHSWUMx1Vd7AjjFCvbN2yyoLtfVwfUnRXPLHA+sxRl14a6wfG76FVDXu2LiXMUQuK8iIZH9JyOXS0NEDFVnom96BJu827T6FDDOCUj0qY6yMxgFJljrcQP1PDUeun78snjBE0cwecAWyJBGk3LtNXA0nUZ5K5TcYr9R8JNndiCaI394y390cb/Oino5OkCZ/TUEphjkJSOEAua6ENHG3RkmOW305BmlhLaoQOKQ=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(2906002)(6486002)(8936002)(316002)(2616005)(83380400001)(36756003)(16576012)(6916009)(4326008)(5660300002)(31696002)(86362001)(38100700002)(7116003)(956004)(31686004)(8676002)(66946007)(66556008)(186003)(66476007)(26005)(53546011)(508600001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?cy8vdUljTDF1NnllVWN1VGJkUWVtdk5tRkxROWc4bVY0ZVBzcDM2ek9SZ0NE?=
 =?utf-8?B?UGZOU3pjdUFGb254LzAxd2cyRUEvZXlhRnJlTVlsZ3NvSlV0MDZOVzk2V3hH?=
 =?utf-8?B?N2UwaTY0MEZzYjlqcnpkMitma1hkMXJnSTlFWnMwMS9jU1NkT0Jkd1NuTG5M?=
 =?utf-8?B?S0NJcnRxbE1EaEFNcEdpQ1BIOUkyblFQK2VjZ1hERUJxK2tRdk5iTC9OL0VG?=
 =?utf-8?B?QlVaUklSL0d1Y0t2Wkg2QzRuUE1hWjVER05jbks3VTNqcUpTY2E3cHZTZ3lB?=
 =?utf-8?B?YjRxWFpjaDJ3TjA1TmEwRW1UbThhRGxEcTRBTFlrVDFUZ0IrbXdGcHBVb0h4?=
 =?utf-8?B?K096TXQ2bUFpNDVGSVZnSnpoNmZVQjgyZFZrRUwyTTlNcmIyVTBLeXQxd2pT?=
 =?utf-8?B?UlNxVjdwMStna3AvbVkyeCtGVmZCczQxeDBSSitlSTRVOG51V2RhaGdCUXhj?=
 =?utf-8?B?R2tQVWUweUpobWh2VlVQUzVlazlQNXI2cW8rMkJTQUZ3VmtBcFl0QzhwbFVY?=
 =?utf-8?B?QlB5ZUVTRFJYUmo5cnRXMUdsdlEvc1dwcmRxOUlxcXJ2QUFmUHVvcFRHcEFG?=
 =?utf-8?B?QmJFeU9jM1BTVHlROXlibzVubGNua2R0MEVncFQ5MWV5OFAzZTJMVjJMQzNk?=
 =?utf-8?B?MENkYW02Q2tYWHg3S1lrdm1ycC9sS21UOHY2MEFXUWluSXQ1UkNLVk1IQVNn?=
 =?utf-8?B?NFJuOU5SV0JCaDBpK2o5Vlc5V1lwNFZQZ0RpMUF6NXBvbEcyZVp6ajVLMUFr?=
 =?utf-8?B?VkY5NThZaDM5Ym1Va0JaVzBVZHludzdnakJXOWFsamtmL1lIS082SGI1TnZq?=
 =?utf-8?B?elJuVy8yd0s2UExvNWl0TVhmTWEvR2IzdjA3RzQ1SDdDYlpvSE5qWk9wYlBB?=
 =?utf-8?B?S01YUlhYSHRpbm5hL3kwNHJTRzRpNURQZEFXcjdFQkV5djVTaEtZQmdNcGNs?=
 =?utf-8?B?OEJmV3FKYnJGcW51Ym1VRE9oMEl3T2x5bGJ2K1RGS2VMb2ZtVEZWdEtlWE1V?=
 =?utf-8?B?VlJGaGNRRGtIZXc2WFFMOGJxSHZmQ2RTZFdxcGhnVE1DUElEUjFkNGdmbllz?=
 =?utf-8?B?b3hsZ0xVc1JSVEdsNnZBNUl5d0dtVVdjd1k1OHZ3aCsvUEIraEI5YTJKaGc2?=
 =?utf-8?B?amZ4dlk2WXh6M3lOVlhTaHhwS1FvMW1md1VZNWdrajBnWkpUTnc3WUlEOHVu?=
 =?utf-8?B?QmtVWG1aTnRoUGhrcXlqdEtDODJpYTd5WXdaUFAwdVFjaGFqcHJKYkxVaU8v?=
 =?utf-8?B?b0pOQzRXSGxpKzhhT0pHN2hpaWNFWVBteVljODByTnp2RHVyNXZhNzd4T05H?=
 =?utf-8?B?TjF4UlpRRTJSRTdmRVVESzNMVnl6V3QxdSs4N2kxODlRT0ZLdzk5SVg1SS9Q?=
 =?utf-8?B?blNvWFdnM2JCUzc1TXFwcHJaNDVHM3Z5RlhySmk1bWw5SzgvWXpBNTlDYzJv?=
 =?utf-8?B?QnYrNFF2ZVA3aFhmTm5iZWxoUlAwQ3Z5L2VjQm9iRExLY1JoQkJTRGJQWGRS?=
 =?utf-8?B?Vm1XMjh2Wkt2OUlEVlZHRmR5UjNOeXhjOENXTHJEWXdVdmZEYWFGc3cxbU5m?=
 =?utf-8?B?Y1FpcUN3VGZseVJLSE5GS01QSmpCOGdtWkxRUi93ZWxFOC9jM3ZDRDJVWWJL?=
 =?utf-8?B?aUVIWFVMb2ZlVmc1alZTTGtHbDNldGRraVU0U1hDd0d3N0JSMXJ6WnJtL0tS?=
 =?utf-8?B?MFo4TmVXRjZqRzRmMHpJT25KWFBkS3hjY2NqMHhHbzI2aERIenMzcmVmQTJn?=
 =?utf-8?Q?EeUR9L7kcWbZAJqK3hbMiV7mCjPpCck+7eyKOWE?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c1b705f9-26d4-465b-00ca-08d992124634
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2021 08:35:43.5195
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1l5Dt/yPdRiPPYJzB4KTcGOz6ZziTPLTGhkxDpHxldPMh/8aeknhZpJ6i8s12DbPN7O2ei4+mqWWhfQMVMMdzQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6301

On 06.10.2021 13:18, Ian Jackson wrote:
> I wrote:
>> Planned release schedule for Xen 4.16 (recap):
>>
>>   Friday 24th September   PASSED        Last posting date
>>
>>     Patches adding new features should be posted to the mailing list
>>     by this cate, although perhaps not in their final version.
>>     (3 weeks)
>>
>>   Friday 15th October                   Feature freeze
>>  
>>     Patches adding new features should be committed by this date.
>>     Straightforward bugfixes may continue to be accepted by
>>     maintainers.
> 
> As previously noted, we have had a lack of review bandwidth which
> means this release will be light on content.  We discussed but
> rejected the possibility of extending the release (beyond Christmas,
> to some time in January/February).
> 
> Under the circumstances, and considering some external constraints, I
> am considering trying to *compress* the release schedule by
> approximately one week.  The feature freeze data would remain the same
> - we need to give people as much time to get things reviewed and into
> tree as we can, but I think we can probably cut a week off the freeze.
> 
> That would look roughly like this:
> 
>>   Friday 15th October                   Feature freeze
> 
>       (2 weeks)

Now that we're here, I of course have given up on any of the pending
non-bugfix patches to make 4.16. But I very much hope 4.16 won't go
out with known bugs having fixes available. Therefore I've pinged (in
some cases again):

x86/CPUID: don't shrink hypervisor leaves
x86emul: de-duplicate scatters to the same linear address
x86/AMD: make HT range dynamic for Fam17 and up
x86/PV: address odd UB in I/O emulation
x86/xstate: reset cached register values on resume
x86/altp2m: don't consider "active" when enabling failed
x86/PV: '0' debug key stack dumping adjustments [at least the first 2]
x86/paging: restrict physical address width reported to guests
x86/PoD: defer nested P2M flushes

In principle "x86: more or less log-dirty related improvements" also
contains a number of bug fixes, but the way this series is stuck
made me not include it in the pings.

I've tried to remember to Cc you on these pings, but I may not have
succeeded in doing so.

Jan

>     Friday 29th October **tentatve**      Code freeze
> 
>       Bugfixes only, all changes to be approved by the Release Manager,
>       on the basis of a (progressively stricter[*]) risk assessment.
>       (2 weeks)
> 
>     Friday 12th November **tentative**    Hard code freeze [*]
> 
>       Bugfixes for serious bugs (including regressions), and low-risk
>       fixes only.
>       (0.5 weeks)
> 
>     Tuesday 16th November **tentative**   Branch off staging-4.16
> 
>       xen-unstable open again - with caveats to avoid release disruption.
>       (1.5 weeks)
> 
>     Friday 26th November **tentative**    Final commits (docs/prep only)
>     Week of 29th November **tentative**   Release
>       (probably Tuesday or Wednesday)
> 
> Ian.
> 



From xen-devel-bounces@lists.xenproject.org Mon Oct 18 08:38:47 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Oct 2021 08:38:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.211851.369524 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcOAN-00071v-3m; Mon, 18 Oct 2021 08:38:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 211851.369524; Mon, 18 Oct 2021 08:38:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcOAN-00071o-0U; Mon, 18 Oct 2021 08:38:43 +0000
Received: by outflank-mailman (input) for mailman id 211851;
 Mon, 18 Oct 2021 08:38:41 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=628V=PG=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mcOAL-00071i-RI
 for xen-devel@lists.xenproject.org; Mon, 18 Oct 2021 08:38:41 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 82e4ad75-bedf-48fd-9f53-1dcf919e020c;
 Mon, 18 Oct 2021 08:38:40 +0000 (UTC)
Received: from EUR02-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur02lp2052.outbound.protection.outlook.com [104.47.4.52]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-39-3XkZYGabOLSDjlqgclbChg-1; Mon, 18 Oct 2021 10:38:38 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VE1PR04MB6384.eurprd04.prod.outlook.com (2603:10a6:803:126::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16; Mon, 18 Oct
 2021 08:38:36 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.018; Mon, 18 Oct 2021
 08:38:36 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6P194CA0059.EURP194.PROD.OUTLOOK.COM (2603:10a6:209:84::36) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.16 via Frontend Transport; Mon, 18 Oct 2021 08:38:35 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 82e4ad75-bedf-48fd-9f53-1dcf919e020c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634546319;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=J3AZQt9zXFJ0tnSQRCHKAPpeLF3APpzN7f9iqQsmzuk=;
	b=nAeVTnOFRug8eWCW3IwMlDUXniwAivbOLZ7xO4V5v+fVUUS1U+perPPniaQl3ZSW0cic5Y
	n4vTtSESCAUUUIucnBX6Z54mHeJAtTTs52dj7QbboVuRPoX7VLqhUZ97iuiLE7GZy+N6Uv
	kAMIK56iNptESFUTSZN3cf1UYNi66a8=
X-MC-Unique: 3XkZYGabOLSDjlqgclbChg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=TK0ps7+4B4M5/44isJrjLK4unrcopgRHIW61ARhWfBg2xfgt2IqyrQ2Af3u3A3Rwicsx6fZisLhWG/KX3Cbvk4k3HP47ALrHyQErU5FwPfcK+xoR97N7QA+JpiCtKPexQipKix3OR49/d6OjN5MrC3BReBI0JSuj5cvxme+uEFHjK3bkKJVkM3v86j5xI0y21YPw1Oo4o8wm5ILG0f+o5DNcYGNAhWNXtjvNYhy65fDqh6gAgijCjXAxob1rTSu0rFTrKt0rE+GW8nVoVVls5mCwYzBDwW4vtlJX17zL/iKLx7CEpT2fvNNvGFnhdbC12ZKfEXTMAWHAHbDbMDhp5w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=fndire85mAACL4pbJGncAywmLzcxt7aJCh+9xcbCQdo=;
 b=Yxa084fsfn+PtIKAI7yv8xcke6wtvx+O96/Vqx3F9B1m65AqSewUtecvjQ91FAr26zUzmdCkRQBK0sSKoCNymmEDrk0AIMq8UknYDKmkh+L1V95GsQIN3HdKmf059mMEzEDmXypLdDa8jlzxY2HnKGsI2ih1XRaZGre1kyyHECZRgQsDImCMQ22s1e654vp6oTfuoJG5kp8GMHY4lDMB5jsikMSGl1IlOsib+pNhfjry8GP4672agdHf93WCrg136ua6qh038onlqCe3deaq/BEeDLhoDvx4HA4MaY8q0B9NZ9hYLbwBQRrLJgQ7f/BVniWmGzApok+eNHgb63ze0g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [PATCH v8 2/5] xen/arm: Enable the existing x86 virtual PCI
 support for ARM
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: Bertrand Marquis <bertrand.marquis@arm.com>,
 Rahul Singh <rahul.singh@arm.com>, iwj@xenproject.org,
 sstabellini@kernel.org, Julien Grall <julien@xen.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
 Paul Durrant <paul@xen.org>, xen-devel@lists.xenproject.org
References: <cover.1634315461.git.bertrand.marquis@arm.com>
 <e2b10f56043155e4bb8eae824723045ccc042f8e.1634315461.git.bertrand.marquis@arm.com>
 <ca5558b2-25c6-90d2-284b-03cbbb02691f@suse.com>
 <YW0qa2CXcnWZNCf7@MacBook-Air-de-Roger.local>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <466083bd-a4d3-0cb6-ebae-11a3e9f67a8f@suse.com>
Date: Mon, 18 Oct 2021 10:38:34 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <YW0qa2CXcnWZNCf7@MacBook-Air-de-Roger.local>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6P194CA0059.EURP194.PROD.OUTLOOK.COM
 (2603:10a6:209:84::36) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 269a01ce-7646-4424-081b-08d99212ad0c
X-MS-TrafficTypeDiagnostic: VE1PR04MB6384:
X-Microsoft-Antispam-PRVS:
	<VE1PR04MB63840C0D082B41B6DFDDC414B3BC9@VE1PR04MB6384.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	5eohtPsyy+4T8kY5It9lTbSkTBLqyTMoIW56HPq1cl/GY9aITmBXhBDaFezeC8VnimVf2YqT7sAXFl1khNybx4hE3w33OLWOP8VvJxpsKw/XPhveDAIM2LLG97EGiq535pPWyFAR+uqU6lelzkqx0ib6GtdDQtPxO9ZXGiF7c6OCGhYP+sfm7okfMHe/EDZAj09qXPH7VLtYpjj82qWXZlGU1AuyvXtNBb0cJLZ98IcyUEicuFmB5LSpagr8UYbDOCnIVWANcHqljpSa7Kto9Bo1qgyUcmqqxPU86n8MjdnGTIL8Pi0TTMTr5Qpatlp18gToBuPqhAuDRgRer6w7+qF3bXvb2BnLuvdG90tdpROsqQiItnvZeq+z4PMLMCaklVk5J5tPEFC9bO/F6r40wuSAcok3atNlpJRzrPZ+YlFOxKtbBZ81REa5PV+1AKBMSwxSyRtPXvwkRt69iT9bOxzq7ws/PGITFBySsFHYw/ED60fGYN24kUI2ZKq5GcTSE62JBHXc2aWMA0Ue3/KSBlbO4MLHVbMysmzL71nyr7o0QXNjvH/7xtM0MFdDp0Ec8/0V+Ew1r4zxa0z0J5jqrGihUJFUScH7g9OVwxtCnd4NlLYMysFpSlqhalrSxtGAKacoRfjf57RflRLu7ULqTHl07+L0hJftVogE0jXRh8n8wdzn9Wu+vfhXWk1aAj2RW/VSZK03godTr0YW4iaTINLKUjVLKlvXeliBYx4FAPgE9isyB4cAgU9idPeRv9TJ
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(54906003)(956004)(53546011)(6486002)(2616005)(186003)(2906002)(66476007)(8936002)(316002)(26005)(4326008)(5660300002)(36756003)(16576012)(6916009)(86362001)(83380400001)(38100700002)(7416002)(66946007)(31686004)(31696002)(66556008)(508600001)(8676002)(2004002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?4lggAL+3IghaaRF8gGWUua48h0kxyPIsetGUjGwZlaW+W/++C7bArhlM6pae?=
 =?us-ascii?Q?vDe0bzyE/muh2b/OeBCkjH7jjfs9iCEckty5aUAL1BnPUNKI9f3gzDp12hpW?=
 =?us-ascii?Q?1tcEbC+P7RieS9ZDHQ5hEtbukz0fhYDYPWxCJQzjT4+/7YrtfrwzrQjrGocd?=
 =?us-ascii?Q?4Qz3Oz4L0aXrvDz7X1l6jOwVGi9EkgfsoIsEqisoGWnnUO7G1LkTj3k6MOJ5?=
 =?us-ascii?Q?vr8CuzfCYZcA09stkMOvAI3KQ31S7WuO8QUTJCBxUBLIsqOjuJH53xH4+eMZ?=
 =?us-ascii?Q?+MpRUpG+pDApF7YFJas5GmFmrZLoQZrl3xDmDyzFiTIczLexfTjpV5vQ+Bwu?=
 =?us-ascii?Q?X71ZIAnJuG4tAwkxCG1iMvK43OADpDob2u79F2Jr51HkadxUzgtnkj97ynec?=
 =?us-ascii?Q?gYJfzhsu+XCwbVGkJMwRF8Z+evwNCbIeVgRmQBiELGtChZCBnliV8aiEUwos?=
 =?us-ascii?Q?xUrypCDzFxa0zHvzb4+6xAyEJ09sE8nLfTeLJTcAnKlGesdqc8cfHllycrpx?=
 =?us-ascii?Q?86CTI5kLm3T4KE93qBS5hGU9tzCUEe5TGUxIhBqugzKWoXY20PJxbKNOa+Mj?=
 =?us-ascii?Q?hd56H/KqMJ9xliSDc93yNBWY3wH+tfpuavyKOQcR6M1H37LRcfW/T4H61sCE?=
 =?us-ascii?Q?skqfzm/7s61I+5Ev/Di+I2I3yCJu/UU/7aQm7jGgkmxLiJyEnHIViDVbaLYY?=
 =?us-ascii?Q?4b7Tk/1A6/OljHBTk4fuKc96NF+aWNzdu3TugQa0NH2wr96T9Ncy1SMdfHsH?=
 =?us-ascii?Q?U5rE7PRnlD1tzOfpsONfKH8hAaU5ibgGxgDTsSEUT5Cq7kvKx2mAB5qh0K1H?=
 =?us-ascii?Q?9ZxWmyHEFYd/aGUcp3Grypg+Oy6QXrXFpibUtEII7ln3AOO7qD0+jlO1lPTg?=
 =?us-ascii?Q?wjr9630/902x4YN9vt3pIAr4ZlKZcCUttwnfob/ObLViEJjX/G9OF8v09MFE?=
 =?us-ascii?Q?Lr1w7s0iPXmJ/cLkakJPhkBHCykSoP/vpHtOgWEE52T3aY/PqG2Azq/omt/8?=
 =?us-ascii?Q?wC1p9BxTuFzO2yxvf+l0Y+HjxXulb4Cl7fMzM/AXkkEDy3K9LPhLFct1jrwB?=
 =?us-ascii?Q?Q1kBvmDX65NnVVygy59vvQ+f5lT7bFvx8UqBerMyHfgDdOIkagKN7pdeHagB?=
 =?us-ascii?Q?LqEq+ivz1yDSBomah93x9/evcfnw0WZSpZgwY9eVX+w1OYR0QNR6fjJTSCHd?=
 =?us-ascii?Q?uXKrYosya2+e3JEouoaT6fcEIXsDDHQtKChulo9IwugkdrPGk2t+MXEMe1mN?=
 =?us-ascii?Q?k/q3c3oO2UrY+fw+4kqPAI1uwwx6GV3q/hnDGYkWIOMPQnJx9ZidCZ0nGPf9?=
 =?us-ascii?Q?QCRNI2UqxzIbhqyj9vgw4gAk?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 269a01ce-7646-4424-081b-08d99212ad0c
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2021 08:38:36.0648
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: DTr6Syu0iws7knyHMwBolN04l5mklfOhezL4OC4BqUKvViKnNz7PeCY/2RVWJxwhJqxY46sMpHaBAn+atuXHfA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6384

On 18.10.2021 10:03, Roger Pau Monn=C3=A9 wrote:
> On Mon, Oct 18, 2021 at 09:47:06AM +0200, Jan Beulich wrote:
>> On 15.10.2021 18:51, Bertrand Marquis wrote:
>>> --- /dev/null
>>> +++ b/xen/arch/arm/vpci.c
>>> @@ -0,0 +1,77 @@
>>> +/*
>>> + * xen/arch/arm/vpci.c
>>> + *
>>> + * This program is free software; you can redistribute it and/or modif=
y
>>> + * it under the terms of the GNU General Public License as published b=
y
>>> + * the Free Software Foundation; either version 2 of the License, or
>>> + * (at your option) any later version.
>>> + *
>>> + * This program is distributed in the hope that it will be useful,
>>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
>>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>>> + * GNU General Public License for more details.
>>> + */
>>> +#include <xen/sched.h>
>>> +#include <xen/vpci.h>
>>> +
>>> +#include <asm/mmio.h>
>>> +
>>> +static int vpci_mmio_read(struct vcpu *v, mmio_info_t *info,
>>> +                          register_t *r, void *p)
>>> +{
>>> +    pci_sbdf_t sbdf;
>>> +    /* data is needed to prevent a pointer cast on 32bit */
>>> +    unsigned long data;
>>> +
>>> +    /* We ignore segment part and always handle segment 0 */
>>> +    sbdf.sbdf =3D VPCI_ECAM_BDF(info->gpa);
>>> +
>>> +    if ( vpci_ecam_read(sbdf, ECAM_REG_OFFSET(info->gpa),
>>> +                        1U << info->dabt.size, &data) )
>>> +    {
>>
>> Here it is quite clear that the SBDF you pass into vpci_ecam_read() is
>> the virtual one. The function then calls vpci_read(), which in turn
>> will call vpci_read_hw() in a number of situations (first and foremost
>> whenever pci_get_pdev_by_domain() returns NULL). That function as well
>> as pci_get_pdev_by_domain() use the passed in SBDF as if it was a
>> physical one; I'm unable to spot any translation. Yet I do recall
>> seeing assignment of a virtual device and function number somewhere
>> (perhaps another of the related series), so the model also doesn't
>> look to assume 1:1 mapping of SBDF.
>>
>>> --- a/xen/drivers/passthrough/pci.c
>>> +++ b/xen/drivers/passthrough/pci.c
>>> @@ -756,6 +756,19 @@ int pci_add_device(u16 seg, u8 bus, u8 devfn,
>>>      if ( !pdev->domain )
>>>      {
>>>          pdev->domain =3D hardware_domain;
>>> +#ifdef CONFIG_ARM
>>> +        /*
>>> +         * On ARM PCI devices discovery will be done by Dom0. Add vpci=
 handler
>>> +         * when Dom0 inform XEN to add the PCI devices in XEN.
>>> +         */
>>> +        ret =3D vpci_add_handlers(pdev);
>>> +        if ( ret )
>>> +        {
>>> +            printk(XENLOG_ERR "Setup of vPCI failed: %d\n", ret);
>>> +            pdev->domain =3D NULL;
>>> +            goto out;
>>> +        }
>>> +#endif
>>>          ret =3D iommu_add_device(pdev);
>>>          if ( ret )
>>>          {
>>
>> Upon failure, vpci_add_handlers() will itself call vpci_remove_handlers(=
).
>> What about iommu_add_device() failure? The device will have ->domain
>> zapped, but all vPCI handlers still in place. This aspect of insufficien=
t
>> error cleanup was pointed out already in review of v1.
>>
>> Furthermore already in v1 I questioned why this would be Arm-specific: O=
n
>> x86 this code path is going to be taken for all devices Xen wasn't able
>> to discover at boot (anything on segments we wouldn't consider config
>> space access safe on without reassurance by Dom0 plus SR-IOV VFs, at the
>> very least).
>=20
> My original plans for SR-IOV VFs on PVH dom0 involved trapping
> accesses to the SR-IOV capability and detecting the creation of VFs
> without the need for dom0 to notify them to Xen. This would avoid dom0
> having to call PHYSDEVOP_pci_device_add for that case.
>=20
> I might be confused, but I think we also spoke about other (non SR-IOV
> related) cases where PCI devices might appear after certain actions by
> dom0, so I think we need to keep the PHYSDEVOP_pci_device_add for PVH
> dom0.

Right, hotplugged ones, which I forgot to mention in my earlier reply.

>> Hence it is my understanding that something along these
>> lines is actually also needed for PVH Dom0. I've just checked, and
>> according to my mailbox that comment was actually left unresponded to.
>>
>> Roger, am I missing anything here as to PVH Dom0 getting handlers put in
>> place?
>=20
> No, I think we will need those, likewise for run-time reported MCFG
> regions.

Yes, this was what I referred to by "without reassurance by Dom0".
Thanks for confirming.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Oct 18 08:43:17 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Oct 2021 08:43:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.211858.369534 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcOEl-0008On-LT; Mon, 18 Oct 2021 08:43:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 211858.369534; Mon, 18 Oct 2021 08:43:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcOEl-0008Og-IV; Mon, 18 Oct 2021 08:43:15 +0000
Received: by outflank-mailman (input) for mailman id 211858;
 Mon, 18 Oct 2021 08:43:14 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=628V=PG=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mcOEk-0008Oa-2G
 for xen-devel@lists.xenproject.org; Mon, 18 Oct 2021 08:43:14 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 6d5ceb2e-2fef-11ec-82d0-12813bfff9fa;
 Mon, 18 Oct 2021 08:43:12 +0000 (UTC)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2176.outbound.protection.outlook.com [104.47.17.176])
 (Using TLS) by relay.mimecast.com with ESMTP id
 de-mta-33-54Dsm5k0O7yp7hAzmGZIhw-1; Mon, 18 Oct 2021 10:43:10 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB4608.eurprd04.prod.outlook.com (2603:10a6:803:72::24)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.25; Mon, 18 Oct
 2021 08:43:09 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.018; Mon, 18 Oct 2021
 08:43:09 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM5PR0402CA0005.eurprd04.prod.outlook.com (2603:10a6:203:90::15) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16 via Frontend
 Transport; Mon, 18 Oct 2021 08:43:08 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6d5ceb2e-2fef-11ec-82d0-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634546591;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=kzawKHRM+YDpQu86QEL4tfIbOhZUcRbkP6EYJTYzHmU=;
	b=ivzw4Ebuq8d9S1jWM5Fx/cS1lacUAOWO3xiImEAOG/9/OvmDpuz05SZsL3ti9o+ZcJS3ws
	B2CafEOPpGP9oJBP+pWczQ8O7C+8s2szGGgzWQkWTJIrb44vXcm7LjXZ6Vth9C9Si/kIDL
	aRYaGWv8Ea9sMuawWylsSfNTzrDZdwM=
X-MC-Unique: 54Dsm5k0O7yp7hAzmGZIhw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Y/Pwc07tS7KAbXwVq1SoEZ2mbSe7WPG9lrUvUqIqKf16DHML+Vf6iKZrCP3PPSY0acnlnqrwkHXQ/skd7Sf9hqmEVJC6GC7asjQS52RvonWy9USV8Dqxff0NOzs+SN+Dk9bKWHu87DJqjJWKbTTj9eHdgnHlMrLzIWozzAzBE/5g08ODLPk47vGFl7EfxjhDUFTkH+ZsUDfEKk89+PnvUiPfK1dY3bsHS7lYrGmt/6e2Yr6Dp/7vNssoQicP2wzeUMmMcRKKaSDOKPFMeQsp/PG7a/kNbTjfLJSu1roPFUpPenL/53RnbkXrM+3w9vEtqkIKkngC2fwprqS1q3TW5Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=kzawKHRM+YDpQu86QEL4tfIbOhZUcRbkP6EYJTYzHmU=;
 b=DaI1ObrAD1i9OIlx00B++2QxS8G4ASDqwnMlZ/PfPCWESNmtAHSnY3kHHZxGKmdqOpqNZlztubRafD3kljxNPzoLMSVRWea6dYdHrtVNTgpr/PlNkSwrLqlZC5dBcCqLNzeWR+0ZNTGXH9IxC/wA6e8zue3N6PaGEMZXTKDqpxo3wet9bdlFQubO0X4Xgeo2nrnkLtS1zDJZQC1Nsn1bhMqW+r1ut5WJIpMzgC2cAWz87b8S9yQx/+3hUVRj3r+xZ577PLQYmraj1X8q77vckjabQPHRSKIkId1wWpOvGawpi0xe/OWB35XjRJa/hQWbjzDaxd5aaoN/beD9IGAaFQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [XEN PATCH v7 41/51] build,x86: remove the need for build32.mk
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>, Wei Liu
 <wl@xen.org>, xen-devel@lists.xenproject.org
References: <20210824105038.1257926-1-anthony.perard@citrix.com>
 <20210824105038.1257926-42-anthony.perard@citrix.com>
 <c99f2bc5-b1dc-7647-4199-a6a731730967@suse.com> <YWmjvqyIyCP6IXmh@perard>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <19e598b6-547d-fa90-83c5-66eaa3787268@suse.com>
Date: Mon, 18 Oct 2021 10:43:07 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <YWmjvqyIyCP6IXmh@perard>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM5PR0402CA0005.eurprd04.prod.outlook.com
 (2603:10a6:203:90::15) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 7f656f41-a649-4eb2-9205-08d992134fb8
X-MS-TrafficTypeDiagnostic: VI1PR04MB4608:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB4608733863807551BF3C15A5B3BC9@VI1PR04MB4608.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Fg5NZdrapVW0gfN9p24qqfTZkuzB4EyiMu0pbvEPIIVLyjHddvM+IrYP43yvOM8e3dLxjpBl7f+5e2ojjrU4sPgAYwQwckv56e5NEk0DraIMeVCTyXvB2j3v89P6yEKSbEILtbQagXt40IDVArq5RVVNpmycjSOYHllMxhuLswpCxCVqG7l+lI06slxYw0JlcEGbbe+EQkM2EobbeEFtQN+P+CZoujdWA6PZqmtj17tFx4Jw6nM/lG3f7sdsu+B0paCuhyne0BuHXKMsZhqaMCp/1Vl1DhmJF7c9sWvDtazFMkU8PBsQjlgmot+GIVilE3IYB+7ezi8XUfUb/BvIey3X49zYEP3MajpouxaUbmtzOdZ21w4lpfBvqDrzmDsQ85FP4FIC9p52Yyb/m1ozildGu6Xf+DpkRNXFgvi/bAEgObFTHsxktITHRJjPWLL5Nf3W8UjzU+AGBzWj7oHZV0cYtF8KHhaTtxxxkXEGjiJ2ceK05ozo9EyaYLCE+c+bC5ugfLoqsMIi7cGZxS/Gf+QE0UzDmqNnQ/XNSkuNae8SdmJj2FMZrV4r8C0guInnbDNiO7Mqz2pQvaHWyomU/flfWrD7bLkNGIxhc6inZfqKAdcY4QUjRyrMkitz2POehw8T3OUxNcjFLfpg2k8Fo3jUyyjBscZuHtKWSfpcVqUGtNcHQuylEty1BKXuePoetDI5tJsGAHSPnG8QzaBYYetfuZGp+Ad4tPBrVzkMbrc=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(8676002)(6486002)(54906003)(16576012)(186003)(53546011)(36756003)(8936002)(508600001)(316002)(2906002)(4326008)(26005)(5660300002)(66556008)(6916009)(66946007)(66476007)(31696002)(31686004)(38100700002)(2616005)(86362001)(956004)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?dnJnWHBsOERUV1hpai8ySjFHVi9VUGJtL0FaUjVzOXRIWEx6aVJJcUFGcXdp?=
 =?utf-8?B?VTRMbVRtbWJpYTF0MG8wNVExOFI2VVdFbjhhWUVzVmNXSWFic2pOZUJveTcy?=
 =?utf-8?B?YkhPOVE4ZUZ5a2sySk04MDQ2dUw1R3B0Y20rUnhUdzZBdllBVGllUyt3aDFp?=
 =?utf-8?B?Y0t5MmgvVGUvVTB2WVZwY1grbjZwaWVoRzNseEQveHExOXo2R2ZOVWlteHFI?=
 =?utf-8?B?VUxxYXZKd2NOS1RQYVJ1bk9NbjI4eTNiUCtvS1RZOWtwRGc5K25ubEZzVlpu?=
 =?utf-8?B?ZVE2VXY0TEJkYkgvbGNpcWhxRFdHV0hwTWFOc2NTQXVLRzAyY0FuMWR0Z1lw?=
 =?utf-8?B?ek1oTGROQWVNVEhTU0JkS2lUaDM4bktVU3VPZFBFbTVrTE5GNXpOWmtoQ1g3?=
 =?utf-8?B?M2I4NWxHT3FrQVBGQ1o2YnlvcDFqN1B2ZlRWalB0bE85RUFmWkdZeTR0UFhk?=
 =?utf-8?B?enpXUWE4U1k5bFBYNVZWOVBkdGtvbUhqemY1ek1kVkgrZ1MzSXRLMGxnb1pv?=
 =?utf-8?B?bFlJTjE4V0lobklMZnc4QS9qQlM3SE1DRlZUcUNSb084Z1pUVDZvakUzRlRX?=
 =?utf-8?B?Mkg3Nk9ZK01DY0tqSFBRUmpwSXBpclZLZkErZWU2dTRyVm1oaHRQcjVoamx4?=
 =?utf-8?B?dzdCVE5Ic0hyamJhdWNrakpRMUpaQjNkUVNhTE95Tnd4ZU1MbEdiWWVva3Ba?=
 =?utf-8?B?cG9VR05ZRWtMdW10OXJ1WTIxSjVUaHMxa0Z6RHdrR21rRWtXenpVNERiZTJH?=
 =?utf-8?B?L0NhZkxDbEM3NmxiV3lsSTI0TkRrTko1ZnZKSVBtTXFucnVIQ0o2dUExWEVB?=
 =?utf-8?B?TjN4Q21nRFk5MDhFM0JTdGgvb0tqODQ4OW5PcStOVUVDSWF1NkVpMlE1SU96?=
 =?utf-8?B?TlEvSnVOcXVQMzIzSGlCdjdZTmdWa0IwRnZtaGUvUjFncGxwdzYwUzMvdXV0?=
 =?utf-8?B?ZjhGcDcvaTdWOTBzeEt2eExvdEZ0Y2Vrc3BhSDc4aFNNK1lzcEYrWG02Y2xM?=
 =?utf-8?B?bHR5MFhOdTV1d1ZsSWZXcDVvM3Q2TTNPMDRyWWl0NEZlMDYvMHJsZTdWM1BF?=
 =?utf-8?B?d3AwZ3lQZmg4Rmloemw2R2hDL3NEUUVjR0VscmNCNlIrcXY2NUtlcEF0d1Ja?=
 =?utf-8?B?S3BUeTZORE90ZlNUV0V4MHdtS3RzN1dHTTBZUEZIRjFUVUxKWi90bkI2ZVRJ?=
 =?utf-8?B?a0lueU5rUGtqU1I3ZnVsaTlLWW1xZjVwUTF5MzI5SHNxWnpxUzlLeFhjM2VW?=
 =?utf-8?B?c1VtV3MxQWF2ajdTMU1Ob3hyd3pqSlpJRk1rc3pCTXBEL2lhSitaZ3VMbDRS?=
 =?utf-8?B?MUE3bTVrZ1piRnFkRWloaXRhbXhVSE53SkhSUDNEb2w4Q2FSV21HNjhGNU1R?=
 =?utf-8?B?VWh1YkZkM2U2c0FMTDNOK1hiTWd5YldxWXBSb1h0L2ZTRHlqQVh3bk9GTk92?=
 =?utf-8?B?NTduMFZVWjB1V1lxdXFMVGNzTHVXU1Awcys1b2xlSDVMS2wvci9oWmJsOEs0?=
 =?utf-8?B?Ukh6S09XMk00MVBrZWZHQTJjZDYxZ2FFbFVJUEV3ZUNtWklOWXU2U2RBUjJW?=
 =?utf-8?B?UmtOMDZZbVlIamNGMTZZNUNKbHV0cWdVUTNXaG15MGpmYW1wYTNBZGdpRzJV?=
 =?utf-8?B?ZHYxUHFaNGJMRGZXd0R5WUFWVFZ4aXMrTFJqSXRiWXB5RVlteGd1aWtud0d3?=
 =?utf-8?B?V1JBNTg1bUZTa0lTMUk1TFg4V1p0TFJXOEVWYWVRbjJmK1lIR1NlMDl0dUJY?=
 =?utf-8?Q?CeGpO/l08+5nSCCjRV2iADa1MGmCZ0Gf7TDTb1w?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7f656f41-a649-4eb2-9205-08d992134fb8
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2021 08:43:08.9995
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 54MKGRZ6npjE/XH2rfmi4D2ynr/SBI3RL1pLl5sOm5feTILyYtMuGtq5pZn2iA3EIwsYTATu64Xiv8Sc1V3P4g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4608

On 15.10.2021 17:52, Anthony PERARD wrote:
> On Thu, Oct 14, 2021 at 10:32:05AM +0200, Jan Beulich wrote:
>> On 24.08.2021 12:50, Anthony PERARD wrote:
>>> -$(obj)/cmdline.S: $(src)/cmdline.c $(CMDLINE_DEPS) $(src)/build32.lds
>>> -	$(MAKE) -f $(BASEDIR)/$(src)/build32.mk -C $(obj) $(@F) CMDLINE_DEPS="$(CMDLINE_DEPS)"
>>> +CFLAGS_x86_32 := -m32 -march=i686
>>> +CFLAGS_x86_32 += -fno-strict-aliasing
>>> +CFLAGS_x86_32 += -std=gnu99
>>> +CFLAGS_x86_32 += -Wall -Wstrict-prototypes
>>> +$(call cc-option-add,CFLAGS_x86_32,CC,-Wdeclaration-after-statement)
>>> +$(call cc-option-add,CFLAGS_x86_32,CC,-Wno-unused-but-set-variable)
>>> +$(call cc-option-add,CFLAGS_x86_32,CC,-Wno-unused-local-typedefs)
>>> +$(call cc-options-add,CFLAGS_x86_32,CC,$(EMBEDDED_EXTRA_CFLAGS))
>>> +CFLAGS_x86_32 += -Werror -fno-builtin -g0 -msoft-float
>>> +CFLAGS_x86_32 += -I$(srctree)/include
>>
>> I'm afraid I'm not convinced that having to keep this in sync with the
>> original is in fair balance with the removal of build32.mk.
> 
> Why would this needs to be kept in sync with the original? I would
> actually like to get rid of Config.mk, I don't see the point in sharing
> CFLAGS between a kernel and userspace binaries. Also, I hope one day
> that we can have the hypervisor in its own repo, and thus they won't be
> any Config.mk to keep in sync with.

My point wasn't about Config.mk as the reference in particular, but ...

> The goal of this patch is less about removing build32.mk, and more about
> using the rest of the build system infrastructure to build those few
> 32bits objects, and been able to use the automatic dependencies
> generation and other things without having to duplicate them.
> 
> It probably make the build a bit faster as there is two less invocation
> of $(MAKE) (which parse Config.mk).
> 
> As for a possible change: instead of having those x86_32 flags in
> arch/x86/boot/, I could have them in arch/x86/arch.mk. Linux does
> something like that were it prepare REALMODE_CFLAGS.
> 
> I know it's a bit annoying to have another list x86_32 cflags, but I
> don't see how we can extract them from Config.mk (in a Makefile where we
> want to use both x86_32 and x86_64 flags).

... about the general (apparent) plan to have two sets of flags, which
may not strictly _need_ to remain in sync, but better would. So while
I appreciate the alternative of putting stuff in arch.mk, I'd still
like to see common things like -W... to get probed for and added to
whichever variable just once.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Oct 18 08:48:45 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Oct 2021 08:48:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.211867.369546 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcOJv-0000ih-DM; Mon, 18 Oct 2021 08:48:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 211867.369546; Mon, 18 Oct 2021 08:48:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcOJv-0000ia-AJ; Mon, 18 Oct 2021 08:48:35 +0000
Received: by outflank-mailman (input) for mailman id 211867;
 Mon, 18 Oct 2021 08:48:34 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=628V=PG=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mcOJu-0000iU-A6
 for xen-devel@lists.xenproject.org; Mon, 18 Oct 2021 08:48:34 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 2bc25d93-2ff0-11ec-82d0-12813bfff9fa;
 Mon, 18 Oct 2021 08:48:32 +0000 (UTC)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2112.outbound.protection.outlook.com [104.47.17.112])
 (Using TLS) by relay.mimecast.com with ESMTP id
 de-mta-5-tbJTzTX7Msy94FY-D12UJA-1; Mon, 18 Oct 2021 10:48:30 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0402MB2702.eurprd04.prod.outlook.com (2603:10a6:800:b4::8)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.18; Mon, 18 Oct
 2021 08:48:28 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.018; Mon, 18 Oct 2021
 08:48:28 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM7PR03CA0012.eurprd03.prod.outlook.com (2603:10a6:20b:130::22) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16 via Frontend
 Transport; Mon, 18 Oct 2021 08:48:27 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2bc25d93-2ff0-11ec-82d0-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634546911;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=PA0iWdDJYyeaEKNMoAovVP9ZkLAROthSOpvLGJf88i4=;
	b=cWOnQg81UbmbNBT33GCbPx2lRwnY1JPXiGBMV31AcjVosyvvuAgGPhcgfE8cxlAwCxDTDH
	Wnpa4TEHUOIVoJT/62fdta1QSKiiGzmwA4YGTw9JooXN+Dwc3YvVgcWfPTUgp31HUeEz53
	9UiL1cKqPfCwRjCulgfproHV/Lk/+2s=
X-MC-Unique: tbJTzTX7Msy94FY-D12UJA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=PCO+9yLrOw2RuHzxxsfcO5N7rYudLiU5Ekokt3E4j16aH6lfAQzUh3eA+y1v981BpaFKSEnaZPWd5pTrai2SZ2dgDLAc75B1P42C3UBMfz2Q7Or11edfOJcSDU1H7SggL9QvH38F1U1g2GHc8EXkfEerOyOv7B4SH2PRZtlFke5VqFkGniNFoQQYWFi+dXm2g2kEKL5oBSdTRtMcz4zABKhl5/NoxJNl3d4jmCB2ACgXJf4nzG44HZ0xMDkEfYXx5CeoEsgc/U19w3K7qj/tshGw2DlU5+UjJ9G+20XY6zJ7bqR0688ZOAeP+jDNq23KJES2tV9GaDovoYHix4t6Pg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=PA0iWdDJYyeaEKNMoAovVP9ZkLAROthSOpvLGJf88i4=;
 b=Xc+MT7F85WRqn1lrKYB9TnKdBhbkLFWGMe/ImDtribXxW6EQ0bwIdQ7guAW+06Y1LmVyTSXzCUeaqSswA5VfokDdQ38fX/B8jXEh8tuQ1BcFPlgc7keKEEUpfuTSHsZDzqJIcH0C2HRXdREQzoxC90/fa4cRalFyg6gvdJwkBR5MuIpMVxTcIsiXrWujuCI/BndTgvovA8uo91JTCM4mj9fL4ROwJWiXRbTpG79ausmIhgtbGByur7SBryjDl04v+OcUCjciCqdVYVmdHJNffe3REcu3TTfqtXVqcHXt2GP5w969KipkuboAsvHOHbjtMVGrDnMu7t5EH3/uR7cSkA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [XEN PATCH v7 42/51] build: grab common EFI source files in arch
 specific dir
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 xen-devel@lists.xenproject.org
References: <20210824105038.1257926-1-anthony.perard@citrix.com>
 <20210824105038.1257926-43-anthony.perard@citrix.com>
 <43684fcc-f6ca-86f2-9fb1-d3d5d9dbc20d@suse.com> <YWmse5Sv2SFyRMdj@perard>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <fd11108b-db66-3c0e-9a7e-a5e30b0b5b1f@suse.com>
Date: Mon, 18 Oct 2021 10:48:26 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <YWmse5Sv2SFyRMdj@perard>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM7PR03CA0012.eurprd03.prod.outlook.com
 (2603:10a6:20b:130::22) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 0fb4970a-366e-4822-8073-08d992140dee
X-MS-TrafficTypeDiagnostic: VI1PR0402MB2702:
X-Microsoft-Antispam-PRVS:
	<VI1PR0402MB27028C9A4A3B030C4695DF40B3BC9@VI1PR0402MB2702.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	e7RseDFODGZxYX3rIXBJ45NMPqVnrSd2fKgZXT7ljb+EYs1/T45gkJYTgzqmx1O1KGCMC6Po+uC3CK0Xco2JwnMatqHpsm/KvYxog5n/WKlqPEmIPV2rv/5okpeHrkrRBN8AFedK5NaWJ64IB+5CqHbasvSFfMBiYR6AYCAJ8lS/DnVmu19FmjNKbQ/+3AM6C0vu1ph5zQbfKkADk4XvgsRBI9lwWAr7hZxw+ZObJ6I4AWGv9qpYZ73CTioSYnq7afPPhRJOjuC69ZHvdmUaevtRJyJ0LH+6TgZEe0jCTNcaTH0jzpWlyIV5OdU7WaiRe0RwRt+IG49qRxuIaU9ZlrXIlzs3lUd1PpR0gCJ07HH0jDM/qrorSQ/jIcz/pCzXym2UVJ7GGypKigh4+KxxgiCrRsRaDynJPk3QhOe8ryTXeL4ipmR45ktz5fazvI0cugCt+q7n7ZTf5BI2NUA+heQSf+8CcOdVqFfKL2bcJyIJdi5stSmHEG3m25u/VqTlBirvGL3F0mHWhRuldZdUSLo1Q1ydnqJWQA4dTAEUd7DTBgvaIi3xegus/kVq0MyJTH+pr2CVOXFhE7HXhsQD09JYdhs7JoP88ue6fmcRDlxxgODENxbajML8kXnECUjBMx/t3JpDemyOT/QtVI62DIjZKVlEzti5duhYvwaPivw3f63EpE3179vtA7fZEaGmZEDHWwdkmLcFb94dFuxZsa8K6TWEJlxPg996V0YNe90=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(4326008)(6916009)(54906003)(66946007)(53546011)(5660300002)(8936002)(6486002)(38100700002)(956004)(66556008)(7416002)(86362001)(186003)(16576012)(8676002)(31696002)(2906002)(316002)(508600001)(2616005)(36756003)(31686004)(66476007)(26005)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?aktteTM4Z1NMb1RUTVBNVXJOVHB2cFNTR3p2bitLT09raDVmeFlhalJCRDVh?=
 =?utf-8?B?VWJhUUw2Y0F3VUNTaUZWZXF6eTA0UG5URjVXMGVOK0podVBxeGVnL2pET0ha?=
 =?utf-8?B?MSswRFF0UDBEYjl4b05IaGJVMmk3SEFhaTc3bGV3enVUOURHNldjd1JCYnJy?=
 =?utf-8?B?cjA3ZHZkK0VwT05hVW9ETkxtakNWWEt4azM3ai8rVWZaWjFaeTQ5WE9CZWlW?=
 =?utf-8?B?dFl0YzZBKzVlaXRaSnJLOXozN1hxSm1aMHJPMkF1UUtNOWFTaEdwaHBUK3pv?=
 =?utf-8?B?Y0V6a3h6NFF6b1U5S2N3SlgwOUg2b1hVSjBuUWJpTUFLbytpR0dKQWdneEV0?=
 =?utf-8?B?dWl4NU1UZmtzUDdJbjVoVmZHREZFZlJwVEMvWFUrRXkwZTJOVTJWbkFkSnFV?=
 =?utf-8?B?Q3hzYktKcllVVzB3WWtqaU1GMGpXcHF6aDh6dE5rSXBQWndpeHN5MVg2MGFy?=
 =?utf-8?B?NTFKVVBucUdMNUw0elo2cDlLWEZNRVNJblljQ3FBOGh5Um1NQ1RUcm5jY210?=
 =?utf-8?B?Y2JDQnJZRWpsZHRvMWhWZGd6bzg3TGJRRlNSMGhSKzRtVDVOcTRJdFFlMlVs?=
 =?utf-8?B?RHRKdExwTnhacmhCM1RzK0pVNzVlQmdicHArYTVhbW11Mkt0TEVPQWh3WXQ0?=
 =?utf-8?B?UGFuNVg2V096UHk5NDdlNmZRVW1aM0g0bmdOUGR4SVNjTng5emxQWTNLL2g5?=
 =?utf-8?B?OFRsZ3B6VXg3bGZqZFRSMHNkaE1kWFQ2U3dGRU9sa2VPUGZNa1Vqa3RpNDdW?=
 =?utf-8?B?TDFzam9kaGdyQ0h1eE5OZXZqUmFreGRrL0ZJWHdPYWcwVVhDY1Y1OTIvcHlm?=
 =?utf-8?B?TXhPL2NDVWdoNGo5ck5Xc3FTWVNQSFNXQjNMMXZhRHF3VkhHZklxMVdkVWZP?=
 =?utf-8?B?bGdGSzRtVEFHSFd4d3lXL2dHZnNmcms1dmtMSlNPSHYxT2xZbk9ydWpPR0Ra?=
 =?utf-8?B?WHRrRTU2NmhyandwcUVYU1FXWVNwSHdLdVBYaitSMXljZXNZbzRYdnR0enJD?=
 =?utf-8?B?T05JTlhqVERXeitUMjMzd2xUc0MxUlN3UytUUFA1YlA4VXlrQ3VQVVB5dWdV?=
 =?utf-8?B?OVcranQ1bFV5TUVGd2xMVy8yQWkvYVoxY2tzeTg1TzBsdVNVcUc2OUMyTlcr?=
 =?utf-8?B?SVZMK3VMajBxREl0eDE0NmdpNjhPbXVMeE80N2pOYTl6NWdFQjdwS3hPNnpy?=
 =?utf-8?B?U3h6dmpydDcwZVdzSEpaVHQwcVFLTkcxNEozamJMWUlNd3NrRGlTQm1ZS1Vl?=
 =?utf-8?B?ekR3MW5SbmlWRGZWdFVUVE1Xa0FoZm9ocFQ3blVvejZPZkJXZlRSL1BxZ21O?=
 =?utf-8?B?QzVEMERFbUFRTVIrYU96bUJ6UnloaHZmVnpwWkc2SGhzd3l5TlE5V0dSWnE5?=
 =?utf-8?B?WkVXK3Y4ditEeUpLMmdjVHc3TGEvcTJJOUdHM1Ivbmd3ZkxPdFRBYlRaM0tX?=
 =?utf-8?B?KzFPbnNGSlhKWFE5alhsMkhWM2tTRUI2KzlyUkFnZDFTQzFUZXV1cDlxYjhG?=
 =?utf-8?B?MzlFMGdqYk5pVmVpK0F4c3VUUW9yWlpJNWtjMmN0OG5MWVdWcC9GaU9acUFp?=
 =?utf-8?B?WHRmOFkzSG5IR0pxMUI3aHNJaTY0YkpjSklVNmtKM0J1M2RMT3cxV1VTMjVU?=
 =?utf-8?B?WXVNWnd6S2tTWjkreC9EVS9pYnUwcEo0WTJoRU83M2NzSjRKQ2c4ekd4TFdG?=
 =?utf-8?B?TnYxbVQxK3orNmNBQVVOMStrS3NmQS9IcCt3K3FDMERsQm54VHNnZVJiQTJG?=
 =?utf-8?Q?/zE+1e1tfQ4dXBiwjqPILx36HkFt1FYNUQU3qkl?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0fb4970a-366e-4822-8073-08d992140dee
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2021 08:48:28.2020
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ggQbGr3PA6MH2BXyRDd9cqBCyDbGfwEqg/LewI4SvUEfAkUvGTCusUw54bs4mrBNurtulCCqW112UEOOczxH7Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB2702

On 15.10.2021 18:29, Anthony PERARD wrote:
> On Thu, Oct 14, 2021 at 10:51:44AM +0200, Jan Beulich wrote:
>> On 24.08.2021 12:50, Anthony PERARD wrote:
>>> --- a/xen/arch/arm/efi/Makefile
>>> +++ b/xen/arch/arm/efi/Makefile
>>> @@ -1,4 +1,10 @@
>>>  CFLAGS-y += -fshort-wchar
>>> +CFLAGS-y += -I$(srctree)/common/efi
>>
>> Perhaps another opportunity for -iquote?
> 
> Yes.
> 
>>>  obj-y += boot.init.o pe.init.o ebmalloc.o runtime.o
>>>  obj-$(CONFIG_ACPI) +=  efi-dom0.init.o
>>> +
>>> +$(obj)/%.c: common/efi/%.c
>>> +	$(Q)cp -f $< $@
>>
>> In case both trees are on the same file system, trying to hardlink first
>> would seem desirable. When copying, I think you should also pass -p.
> 
> I don't know if doing an hardlink is a good thing to do, I'm not sure of
> the kind of issue this could bring. As for -p, I don't think it's a good
> idea to copy the mode, ownership, and timestamps of the source file, I'd
> rather have the timestamps that Make expect, e.i. "now".

Why would "now" be correct (or expected) in any way? The cloned file is no
different from the original. Nevertheless I agree that -p is not ideal;
it's just that the more fine grained option to preserve just the timestamp
is non-standard afaik. You could try that first and fall back to -p ...
Otherwise, failing hard linking and using "cp -p", I'm afraid I'd prefer
symlinking despite the arguments against it that you name in the
description.

Might be good to have someone else's view here as well.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Oct 18 09:02:36 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Oct 2021 09:02:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.211875.369556 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcOXO-0002zN-I8; Mon, 18 Oct 2021 09:02:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 211875.369556; Mon, 18 Oct 2021 09:02:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcOXO-0002zG-FA; Mon, 18 Oct 2021 09:02:30 +0000
Received: by outflank-mailman (input) for mailman id 211875;
 Mon, 18 Oct 2021 09:02:29 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=628V=PG=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mcOXN-0002zA-08
 for xen-devel@lists.xenproject.org; Mon, 18 Oct 2021 09:02:29 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 1da9047a-2ff2-11ec-82d0-12813bfff9fa;
 Mon, 18 Oct 2021 09:02:27 +0000 (UTC)
Received: from EUR03-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur03lp2053.outbound.protection.outlook.com [104.47.8.53]) (Using
 TLS) by relay.mimecast.com with ESMTP id de-mta-5-xS3c89VvN4CKy2YhQOT7eA-1;
 Mon, 18 Oct 2021 11:02:25 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB3295.eurprd04.prod.outlook.com (2603:10a6:802:f::25) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16; Mon, 18 Oct
 2021 09:02:23 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.018; Mon, 18 Oct 2021
 09:02:23 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 FR3P281CA0018.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1d::11) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4628.11 via Frontend Transport; Mon, 18 Oct 2021 09:02:22 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1da9047a-2ff2-11ec-82d0-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634547746;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=OGfZqQzLIgGlCIYuRToZYjeRdyBXa7Bk1f5CBu2G0o0=;
	b=b77X49Vw2Vpj5SN8yYfkA4poG6KkfGmoPKkzbwVYAp1wmJKUTmSbARBZu8BcG18DgwxurC
	H2V/zlog/Sf7Gv992flqn2XPPdqw+RQrFbRJyWAmkgF0C+DvgoekQ7iLopFnTaOHf629iZ
	+DfAzl7QicGy93n4zL9i16k5RXsQJNQ=
X-MC-Unique: xS3c89VvN4CKy2YhQOT7eA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=hcvAF6HOFDuMUShQDRYclZ/Cx/lh4kH50qU31zBd1KToYH0IbpIrTi1wWX5A83IuPYC/QUQ6wNhrDyBe8MsQ8Gsx+n0VbYw1RSYL7hvUCW4z3TOnriRFPPzs0RbGLaPalS43/AIF4qsodL7lVHqUs0iIavLK542dP0xEnt0HuibZmjX8C8nLnOzMU6tkgM6MRR8Vh2g3ZP3MvROzb/7Ub4Kjkaecfp6QqjoRE//WqywGs9DYFqXJMfAwgSZkVXiiCnWTaudsLrl20sq7kOKWFgaluivhtJVAzeonTTVYQQkol1b86VafieBfKGMxUMVvmMrNg4mz56cajxL/HpEnkQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=OGfZqQzLIgGlCIYuRToZYjeRdyBXa7Bk1f5CBu2G0o0=;
 b=CEC2cHe71yDqpEF0F1ChNKLTVma4kvHNj/mSaGtedpMwMVFSMlh4Tpwa39Zsb2ZBGDI8INefCVmtBuqP1yrZhubTvsAvREVMv0I59C/o6D6YmCrLEXQSKDJtJY/rLHeiqkzOGO6Dc6wLwmnIX3rU8rVuI+24BUkeB0q7WHQxM36Rg6+4Zks/yvGRrY6ZUlkZWkZh+f6tbEf/BpN2HSVOBt3q91IXmaNwQS0ghmKklLEGINwq4w4W2TdZH7FX2d5Wg/x3r26UIWmgv+KFJHZ1NBGMBQyUIHnuhgsND8P0I4TSvyc8ONXTD1UVdPOu+PKmzA6pEYm8ynidJTtDGO3ojg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [XEN PATCH v7 49/51] build: adding out-of-tree support to the xen
 build
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
 Ross Lagerwall <ross.lagerwall@citrix.com>,
 Daniel De Graaf <dgdegra@tycho.nsa.gov>,
 "Daniel P. Smith" <dpsmith@apertussolutions.com>,
 xen-devel@lists.xenproject.org
References: <20210824105038.1257926-1-anthony.perard@citrix.com>
 <20210824105038.1257926-50-anthony.perard@citrix.com>
 <2aaf0858-1602-be5c-77e4-2daa7fddc534@suse.com> <YWmzSkLdH5wtQ77V@perard>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <f53e4d09-9f33-6dc8-8161-156b9eca4a6b@suse.com>
Date: Mon, 18 Oct 2021 11:02:20 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <YWmzSkLdH5wtQ77V@perard>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR3P281CA0018.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:1d::11) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: f7af3cfd-c152-461f-6209-08d99215ff8a
X-MS-TrafficTypeDiagnostic: VI1PR04MB3295:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB3295987C70494DBFF14F5B83B3BC9@VI1PR04MB3295.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	0HDPvve6kd5XwfGrEKTORUFfwt9tfjM375qYrOBNXEh+VTIxJdLcQ/tWsdhMiJhf0tmzsZUIZ7HV1wbFZtgOso224+44gjfwMPKH4ULCvGcl9M55sAHzI9DBtMiuGaydSiu0vuZiuMiHfxHwdQebM8CDJHbo5kHlXUSYYUNatLo7ESdK1CZI+C0QXIfK1EXMS9EQmfKqCFgTSMY/lmhl/Vdh7f+w94SYEgFZvzBcp5JEFsYRANOhaCNoxNihEHUOLwOAd75M+6rXvvLI1R+ONuAdtCc5Y3x+iKTc02Sn0DPlXhj26i56dGg7pTkn5tqJ5F4scc0pkE6+yOlg+qZV58vmvcFHuYpVx6tmU2+qbOIG16ak8c82OYiYRq+pHfzP4F+g/MuyCh9wv2JheHRVBGW5vJ4IBGa0nDc8fHffmEERrrErAyNpVVumWqpF7MrFw9bbZzM5CSKht45GdmHEI9I+ADBBJQycEn1fufiuY39XgnOrRfyZpaczGuDPBMEr8rSfaIOGHlDQcpEP06715dYGzqg/LNEa4kuQrppBMJt/QF6uK6EZQJbFOlT+D4VQ1+J0SgDyzK/+iUJ0ckTKs8aX8yl8yHn6h1OTNNPKbeMJ8ggVZc7Ha0s+upG39mmbS4nkQNPatE0sAHjxA7YCNFvxk/K14pZKIyk3BfBuTg7VAGeW+cmKsAJSm5rHf/WlmfCxOYFo9Ls4iAhbSXZMrDnDpZsxCCoigKzJzd0rfZI+gFZtsDN10isgDZdjRrdS
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(66476007)(956004)(2906002)(5660300002)(6916009)(66556008)(66946007)(16576012)(53546011)(83380400001)(54906003)(8676002)(186003)(38100700002)(86362001)(8936002)(36756003)(2616005)(31686004)(7416002)(26005)(316002)(508600001)(6486002)(4326008)(31696002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?N1drL0lLa3h5ODBDeGRjejVST1Q4NkNmQWlpVFQxZnpMNURiTWxYQVg1QllL?=
 =?utf-8?B?RjdFOW96cXZCak5MOWs2b3htNllnZ3pMOGRwYUM2Kzk2QmJ1NzNpR1UwZmto?=
 =?utf-8?B?T2RnRWlOb3RLMk9PUSszcWtZK0dIbGpjY3MxRFl2UDRkbUdTTU9wQUl2WDRG?=
 =?utf-8?B?OUtvcXR0alM1RGxHdDhVY21McVJyZk1nRVJldnRRaWxueG8xeklHNWsyVTBi?=
 =?utf-8?B?WmhvTUY3MG8xUHpQc1plUTJ1dzI4NCtJSE5GNzhabHNGVS9vR3hVOTdmRVRM?=
 =?utf-8?B?OTl2MWh2YUsxeUo3azVoWWUzV3FaR2tENGYxNjBrNGRtL1FZVFlJQU9lZ3hm?=
 =?utf-8?B?OXZWSnRLdktHaHNoM1Nuc00wclZZcW9YNUowZ0ZvSEZ6VHZmNFFWOFJ2OUlo?=
 =?utf-8?B?OE00MjNITk5wbEVYQWoyeklXcFhvK1Z1VW8vOTNKYnpiNXVXQ1BOSnVzRk42?=
 =?utf-8?B?dk8yQW0vZjdXMGNFeTJaZnJ3RGdCVGUxK1V1ZnlPNXY0RU56KzM5MmZFQXp1?=
 =?utf-8?B?bnkyUzBqaWRvcTB6aVl6c1VYRzFadUpQK0tYaE9jQnBxVkxqNURyRFh6QXg0?=
 =?utf-8?B?NU1vZE5aOFExcEZCbmRvbDM1dHFvSzY1N0gxeFB5cS9kVGFOUDN6b0VvYlha?=
 =?utf-8?B?c1l3UHh2dVhLelFXa2xzQ2xvTzErTFZraUF2N2J6S2F2bDJyeTZGcFU4a3NB?=
 =?utf-8?B?bGdyVXQrWVg3RWhSR1VoQjFxdE9MU29uTG03SzZPYUFZazBXWU1XUGJyejAv?=
 =?utf-8?B?d2ozZWhPdXdpajlMVzFEQVhxZ2RWejVCM2k3LzdMVm9iUVFDUEpndWpqMEE5?=
 =?utf-8?B?QXZoVjg3MzNyRmRJYnYzWmFJbjhRb0U5bTlSYVdIV2Iyd0ppTlR2QjBhSG1S?=
 =?utf-8?B?T0VwbWNMc1lGbDNVcC9pVjRJTjFkZnJoVm9FcElMUE9mRlpNaDNRSTdiNHZC?=
 =?utf-8?B?N29tcld3ajk3cTVaYkFUNFhvVk9rNHR0M0dQRWFvVmdBMVFmQWNkTnYzTzlH?=
 =?utf-8?B?U2xVbjgvcTZuSFlnMVdqdGlGWVJtM2VpRHhrRnd0c2EvL2hWUnJheFpVelZp?=
 =?utf-8?B?L09wTWJJd1VZdWxtU1FOeUd0cE1sb3d5NG40MUdMeTltSVZxYXp1N2dLRVVs?=
 =?utf-8?B?ZFRXK3VYeUh4YTNIOVh0YXdHdFdvMVhmL2cxcTRzRTFwbmxBVW51aGV3RDUr?=
 =?utf-8?B?dXVWV1pySzU1VzBBeTlqSnhQOFVUR1MxbzU1dEtQa3VmQjFQdUJaazRmNjRX?=
 =?utf-8?B?UVpVcW1ReXVjSFplZ1hNaFBrMExTQmRkNkErZExIR1V1dTVxc1VZQ1YwdTY3?=
 =?utf-8?B?TnNlbFFUWGxiUHkwdEEzQmZNZjlZMElxNVIwSk82eGFJVWxpWDUxbm80dk9T?=
 =?utf-8?B?ekVtQTJrT0lrMWpvZld5WGFmQ0hOeUx2LzJidW1MV0d6VEVFN0d0NGJCUDNj?=
 =?utf-8?B?LzRYZFpUdDB6SENzUjFPZ2lHVHRSZXlNQ3oycHo2ZkVwbjJmaDN1cGQzeEZG?=
 =?utf-8?B?OTVGM1REdkhyeXlZdnVrMU1CSlREdkdCWjFSSmFteGltUUlTWnhxbDlScE1T?=
 =?utf-8?B?QjdRQlZXdjlManA5ejhkcHlOb1gzOTRiRlVzWkJjRHFtZHd6eE5wbWhxNDhW?=
 =?utf-8?B?aTlFcERTWWdKWmw3Si9WQnRJWFFvUXNMajdXczZQcFZkbFNKYm9PVlFWRDBN?=
 =?utf-8?B?WnY2cEdKdEFENWprNGdlZnROOHF4VUo2dENLZjBObzArbTRBVUozeEhxSlFG?=
 =?utf-8?Q?UKdF0UHi+qOfc9BfRgawI0W8Qa8/g4TmS4P3e5N?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f7af3cfd-c152-461f-6209-08d99215ff8a
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2021 09:02:23.0152
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: E4FNVOBGZuDpNLtzq52IsjpVgy8oTKFXccbKc/w7PewnZVv1xhxUIX5EJcLoq5GwBSPRAQHgZNRHO6yLUJIduA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB3295

On 15.10.2021 18:58, Anthony PERARD wrote:
> On Thu, Oct 14, 2021 at 12:14:29PM +0200, Jan Beulich wrote:
>> On 24.08.2021 12:50, Anthony PERARD wrote:
>>> --- a/xen/Rules.mk
>>> +++ b/xen/Rules.mk
>>> @@ -38,7 +38,7 @@ SPECIAL_DATA_SECTIONS := rodata $(foreach a,1 2 4 8 16, \
>>>                           $(foreach r,rel rel.ro,data.$(r).local)
>>>  
>>>  # The filename build.mk has precedence over Makefile
>>> -mk-dir := $(src)
>>> +mk-dir := $(srctree)/$(src)
>>>  include $(if $(wildcard $(mk-dir)/build.mk),$(mk-dir)/build.mk,$(mk-dir)/Makefile)
>>
>> Perhaps already when it was changed to $(src) the name has become
>> slightly misleading, at least imo: I would rather expect a variable
>> with this name to refer to the build dir/tree. Maybe "srcdir" or
>> even shorted "sd" right from the start? (Reaching here I can finally
>> see why having a shorthand is helpful.)
> 
> I have to think about that. I've made some further progress in order to
> be able to build the Xen pvhshim without a link farm and notice that
> nearly every source file needs to use "$(srctree)/$(src)"

Oh, now I'm curious as to the why here. I thought use of $(srctree)
ought to be the exception.

> and I'm not
> sure "$(src)" could be use alone. So having a single variable which have
> both would be useful.
> 
> "srcdir" might be to close to "srctree" and one might mistake it for the
> other, so "sd" might be better.

While I did suggest "sd" as an option, already when writing this I
wasn't convinced this would be descriptive enough. Personally I think
"dir" and "tree" are sufficiently different names. I would suggest
"srcroot" for what is now "srctree", but that would have the
disadvantage of getting us out of sync with Linux.

>>> --- a/xen/xsm/flask/ss/Makefile
>>> +++ b/xen/xsm/flask/ss/Makefile
>>> @@ -9,3 +9,6 @@ obj-y += conditional.o
>>>  obj-y += mls.o
>>>  
>>>  CFLAGS-y += -I$(srctree)/xsm/flask/include
>>> +ifdef building_out_of_srctree
>>> +    CFLAGS-y += -I$(objtree)/xsm/flask/include
>>
>> There's no header in $(srctree)/xsm/flask/include in this case, so if you
>> use "ifdef" here, shouldn't that other part move into an "else"?
> 
> Actually, there are headers in the source, like "security.h", and `git
> ls-files xen/xsm/flask/include` shows plenty other headers.

Hmm, I'm not sure now how I came to make that comment. I must have
mentally discarded the trailing "/include", looking at
xen/xsm/flask/Makefile generating a couple of headers, and then
blindly assumed these headers would land in xen/xsm/flask/. I'm
sorry for the noise.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Oct 18 09:41:55 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Oct 2021 09:41:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.211886.369567 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcP9Q-00078R-Ia; Mon, 18 Oct 2021 09:41:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 211886.369567; Mon, 18 Oct 2021 09:41:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcP9Q-00078K-FZ; Mon, 18 Oct 2021 09:41:48 +0000
Received: by outflank-mailman (input) for mailman id 211886;
 Mon, 18 Oct 2021 09:41:46 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=3tpC=PG=citrix.com=roger.pau@srs-us1.protection.inumbo.net>)
 id 1mcP9O-00078E-Iv
 for xen-devel@lists.xenproject.org; Mon, 18 Oct 2021 09:41:46 +0000
Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 74501b88-ab30-46a9-b652-b0e9b601f1f1;
 Mon, 18 Oct 2021 09:41:44 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 74501b88-ab30-46a9-b652-b0e9b601f1f1
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1634550104;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=5dIdjntD35/oVvQOVr3TJRz7ZySMHMgxMmKLhHOS8Cc=;
  b=MPjeS5fIS1dfHDncITtc3EJ0l1Zffp68f/fef+c97PMo+ksJsXMmWD18
   KkCNbdV/M121BPqR4TpLdr3bGL4cvgpfSUgaRygZYB5vX+ReiMrpyjsH5
   f8OBVVcHxzVGs2VxxPvSuqOw/anVyL5BST/4YcODOJFP+OIrrdO6L4lkl
   g=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: kHVfKkEb1ZUi+73+VjPLVcCHXGTsasS4CdjncJfOaHjniNyH7wVM1ar7kN2fb8+FVclzQUoRug
 nuS1TaZcgg3xW0dW2dL/b/1SUoposGwXgi8lZyu/kU1+9x6PKiahGe/UzhuK26eMVUNEIJJjMX
 8HN4S6SwXXqBSTsJRHwjAMgQE9s8WIWlcHXcyxhdtLY4IiDOmH6ayEn5NLY/p6mNNgGYKWKfHY
 71tP5bkH4N6WikmsFdqf6lE2S2c4XH4STWXC6x3yo6NClutA3pe86kTNtJRhjW8Qh/zuUmDnJd
 fb9jIuegPqk2q1E/oBbAov6K
X-SBRS: 5.1
X-MesageID: 55816928
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:0t+KSa/RpMPoEX/YGvraDrUDW3mTJUtcMsCJ2f8bNWPcYEJGY0x3m
 jMZXmrSafiIMTPyL4txb4mw90JUvseBndc1SgplqXw8E34SpcT7XtnIdU2Y0wF+jyHgoOCLy
 +1EN7Es+ehtFie0Si9AttENlFEkvU2ybuOU5NXsZ2YhGGeIdA970Ug6wrZg0tYx6TSEK1jlV
 e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH
 I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPhvx
 oxM9oWRVDwqM5DOiv4TAyJ5Ln5HaPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us
 6ZCcXZUM07F17neLLGTE4GAguw5K8bmJsUHs2xIxjDFF/c2B5vERs0m4PcFgWdp2JEUTZ4yY
 eIGRRFQYU6afyRRN3snIYBkw/WG2CHwJmgwRFW9+vNsvjm7IBZK+KfpGMrYfJqNX8o9tlaVo
 CfK8nr0BjkeNceD0nyV/3S0nOjNkCjnHoUIG9WQ9PRnnVmSzWw7EwANWB2wpvzRt6Klc4sBc
 QpOoHNo9PVsshzwJjXgY/GmiGCK5x9fQvtNKO431QOf0KSE2CekWVFRG1atd+canMMxQDUr0
 HqAkNXoGSFjvdWpdJ6NyluHhWjtYXZNfAfucQdBFFFfu4Cy/+nfmzqWFo47eJNZmOEZDt0ZL
 9qilyM5m6kIxfAC06G27DgraBr9+8CXEGbZCujRN19JDz+Vhqb4P+RECnCBtJ6sybp1qHHb7
 RDofODFtIgz4WmlznDlfQn0NOjBCwy5GDPdm0VzOJIq6i6g/XWuFagJvmoieBY0Y5xYJWW4C
 KM2he+3zMUCVJdNRfQvC79d9uxwlfSwfTgbfqG8giVyjmhZK1bcoXAGib+41GHxikk8+ZzTy
 r/AGftA+U0yUPw9pBLvHr91+eZymkgWmDOCLbimnk/P+efPOxaopUItbQLmghYRt/jf/m04M
 r93aqO39vmoeLaiO3aKrdNKcAliwLpSLcmelvG7v9Wre2JOMGogF+XQ0fUmfYlklL5SjeDG4
 je2XUow9bY1rSOvxdyiZi8xZbXxc4x4qH5nbyUgMUzxgyooYJq17bdZfJwyJOF1+OtmxP9yb
 v8EZ8TfXagfFmWZo2wQPcvnsYhvVBW3ngbSbSCrVycyIsx7TAvT9966Iga2rHsSDjC6vNcVq
 qG70l+JWoIKQglvVZ6EaP+mw16rk2IaneZ+AxnBLtVJIR2++4l2MS3hyPQwJphUexnEwzKb0
 SeQAAsZ+raR89NkroGRiPnd/YmzEuZ4Ek5LJEXh7O67ZXvA426u4Y5cS+LULzrTY3z5pfe5b
 uJPwvCibPBexARWs5BxGqpAxL4l44e9vKdTywlpESmZb1mvDb88cHCK0dMW6/9Iz75d/wC3R
 liO6p9RPrDQYJHpF1sYJQwEaOWf1K5LxmmOvKpteEiqtjVq+LenUFlJO0jegSNQG7J5LYc5z
 Lpzo8UR8QG+1kInP9vuYvq4LIhQwqjsi5kai6w=
IronPort-HdrOrdr: A9a23:MqvsMq0yvtjlGXC55CGlkAqjBSFyeYIsimQD101hICG9Lfb3qy
 n+ppsmPEHP5Ar5OEtBpTiBUJPwJ0800aQFnLX5Wo3SIDUO2VHYVr2KiLGC/9SOIVyaygcw79
 YFT0E6MqyOMbEYt7eL3ODbKadZ/DDvysnB7o2yvhQdL3AYV0gj1XYDNu/yKDwGeOAsP+tBKH
 Pz3Lshm9L2Ek5nEPhTS0N1E9TrlpnurtbLcBQGDxko5E2nii6p0qfzF1y90g0FWz1C7L8++S
 yd+jaJqJmLgrWe8FvxxmXT55NZlJ/IzcZCPtWFjowwJi/3ggilSYx9U/mpvSwzosuo9FE2+e
 O87CsIDoBW0Tf8b2u1qRzi103J1ysv0WbrzRuijX7qsaXCNXkHIvsEobgcXgrS6kImst05+r
 lMxXilu51eCg6FtDjh5vDTPisa1XackD4Hq6o+nnZfWYwRZPt6tooE5n5YF58GAWbT9J0nKu
 9zF8vRjcwmMW9yV0qp+1WH/ebcGkjaRny9Mw8/U42uonlrdUlCvgklLJd1pAZHyHo/I6M0r9
 gsfJ4YzY2n46ctHNVA7dw6ML6K41r2MFvx2VKpUCba/Z48SgbwQr7Mkf8IDbKRCdE1JKVbou
 W2bLofjx9rR37T
X-IronPort-AV: E=Sophos;i="5.85,381,1624334400"; 
   d="scan'208";a="55816928"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=AsLyKfc5uZHc2pcLt28c7G8iUufiyjhWYO17Din8xdRR6lIN9/vr0BV0hwdywL+5MSLVNnNuk4eIyc7+HGxwiH9dL69lQ2uf3GhMcenM7TiSYoQbcNNYK/BzA7m6kFBHnfSUzT6UHKnPvXG2pjB/Mwg1mn5hCv6oTeQCPiHrhpLIRhFC+I+ojHArMTzfdyCTvxxRzYGBPnHDTgM8H2XsxEIZ1P1EQKY39xnsEtrrZUiaaVtfSLw0fxBFFxq8fNflEtf8OhS3D0dJA60UFrLkbJlQFZKN8c2WA48bwAS/4tvqQt+SMpNRVxgl6SfKuJZWl+bsL9Q0gsWDU0OglkL2Yg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=/EZ7TR51H6tjasY3n2u1K6w9xsMVySw6o5E290iSYYA=;
 b=TLEqjaSpWyNOOaQCQrt731dzWHX8Qk+TGLKdIOe2gSRYnfSJQ0Jw4CYsr0zLZWDHhUIOOxBYETms+s80+1YEmCGz5RRHtrdSPf6YNtQhKQoUw0tvNo80mj53tdfSqoXCwPQBiojeDwLBGpo7Ixku6ohaHakM606/Y7tmmKkyVFNV8F9skkz1mZhSWm2lA0BuYW28JWt2daiLIwibG4drxeN0nkKgi58bE+zTqHwN5d2A4KNz9k5sUTNKAS9hysFahwy9elFQknxSvDTQNWtnYdIO93SrG1T1dNuqGei7eWVuh4Zw6cYV/Y4Dde3ZA3/IvWdLDXghM8amtmIBzrNBCA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=/EZ7TR51H6tjasY3n2u1K6w9xsMVySw6o5E290iSYYA=;
 b=Xt1uErB+qMoVKjnnaV/D1XF5UoF0lco711dIkKeARJpBDeEsFS3HooqLs4uD9CM5Fet6+vfNhykwtiSeQPY0wVeGxCjV1J/pN0vLWq8h8krmF+m7KyjZO4rPMskCRXlMGUn/HRRc4S2WQhKg0LfywMrQk7dy4bqRzJIST+3Jo3w=
Date: Mon, 18 Oct 2021 11:41:16 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, "Andrew
 Cooper" <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH v2] x86/AMD: make HT range dynamic for Fam17 and up
Message-ID: <YW1BPPVNAVm6EPQp@MacBook-Air-de-Roger.local>
References: <36df1141-5c3b-6f8a-3a83-1f954b1e27a6@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <36df1141-5c3b-6f8a-3a83-1f954b1e27a6@suse.com>
X-ClientProxiedBy: LO4P123CA0465.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:1aa::20) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 287888d7-e1c8-4b3b-0c21-08d9921b71d7
X-MS-TrafficTypeDiagnostic: DM6PR03MB4220:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <DM6PR03MB4220EF3B7AEDD0C1678099AA8FBC9@DM6PR03MB4220.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: Mmk3WRFkBkmqxDBVyGToq7nP0TxIKkDTmagW4hYDNprq+48KxoL9EwfDTXuIMyBjdIjuaBEssRqTUN0p94gsSSCEbESxE9CXtIvQW/aloJGWEuCustp6GW01CJ7O0PLnKgdd0gJl0zsqKUwBqgWEeV8lFNWGwNOkfuygIXQfIhcImRwnXarTjVdPSgJay9jTJsvF4zgnO6UWq44MV+5QQwLlcilQloTfcE/kfhBRRp8iLjonqCVrEdSixMi8mpPITO1XOwHrW4V7B4bIDv6/eGgc069wpv1qT1S0KuI1+HXLoud/vpDOj4tmopBjAvBonI3Iq8PRoTmi007Uo0Tz9weaHmvVvZyVSCjux1Y4SoftDhNzFwcKXYeHn5wcBfG7mAj0R+GdSkW97GzQIpeyzo458S9hFpQ1PGagTZct7KssddWgJMcYpEtWPkFUWKYV0Kx2k6kdBqsNWCUXkXXIgGYc2OtEubjPDJ9HfYbrmEyyzt4F7FBCjpvd7HATm8yXxJhjTMO/EOW+XgMyDNMyyCFaz0L2dfIUlow3rBKOOwB6uyJlpWqw1822rl+cp2Of+Opjqyf6lvL/KdaEHAbLT3C/0cjjF6vMrg6dwVXBlD+W5XCLw2BgdUc5AQU2ziPvocxRz6W4UvhPI3sWpL6iwA==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(54906003)(86362001)(66946007)(6496006)(66476007)(6666004)(85182001)(186003)(83380400001)(66556008)(508600001)(6486002)(6916009)(956004)(316002)(8936002)(9686003)(82960400001)(26005)(5660300002)(4326008)(8676002)(38100700002)(2906002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OUlUT3h6UUhza2lYdmNlUEQxcUV3c1kwc0d3WXNpQlpvblM0TWdGNFlnS3M1?=
 =?utf-8?B?M2JrMW9mMkdDYVkzY01BcFRteHE4YjQxMFg4MWFTc3V4NXZaRWhFR2FjTExm?=
 =?utf-8?B?NlJMOWtrak8ycXIvZDBDYjdRMG5HOHc5YWZxREY1bHBvTVNFa3VNOHBlTHB5?=
 =?utf-8?B?NUdFUUF4R3FLMTNUUVg4WWVBZlpFc2JkYzBrUG1HYWdoOW9vR3huaDNVUlhU?=
 =?utf-8?B?biszNU1qYlhYVUZBZ2tmNzZqSTh5Qk5uQ3JLM25pMFlSdFlhYWhUK0QwYytn?=
 =?utf-8?B?Mnl4bVNUL3Roem5UdnVoVDJ3QndOd3NaWHExbFZJNGUrclZoRjVsNVpjdlRv?=
 =?utf-8?B?aEtEanZST3BYZW8ySWJPSUJOUmtrUUhPNDA4L2Jxa0ZwdVpLTkxlZGROQ004?=
 =?utf-8?B?WkNvOWtnakp1OEVlenk2V3B1cE5WZGN4S2F0NncyeXgrV2JrS0tJWHkwcVVu?=
 =?utf-8?B?aEJrb2taMGN5RVF6bGI2cXZ1OHpaeDFsOFIyN0ZVMFpId0tJaVg0NkZVRUhM?=
 =?utf-8?B?bElCeTB1UE4zZHpWVXE0MnZoRGVaQmt4OUo3dXNXWUVPVGk5dkJTM0Z1bFRh?=
 =?utf-8?B?ZkkycGZzUEpZSXZKWXRQVnIzc1AzZlQ3VEFXaWV0QjljS2RhWDFUcDdUL0JI?=
 =?utf-8?B?ek40NVp4N1RDNmtwdE10WG9CUmk3c0dRQlNkOWMvSzNDUFU5TUVReW1SR2pX?=
 =?utf-8?B?S3JPOVR5Y1Fqc3BSWFk5L0x4YlpnazhGMlF3YlQwalZzVVNhTE84TllKbEFw?=
 =?utf-8?B?YXhycmRCL0M3K3FmTTRjWEIwKzcrZVhCQlVtMXBMK1oySzNUWkFIZy94N01w?=
 =?utf-8?B?U2FNajJxWVQvS1EvcmQ4aUwwNytBYzhJNlZMbktwaGJUQ29aOUVtaytqUjAr?=
 =?utf-8?B?VFNqUmxWNEFidnB2dTJnbzJWb3ZVWlBYQ2JKaS9VY21tcncxRndGVWFKbjNY?=
 =?utf-8?B?Z1F6QnJSeWlKNk1PNjVYQWI2dW1CUURwaisxQndCM3RMVFIvZTdJdVFLK0xx?=
 =?utf-8?B?MjRybGlzMEU0L3UzQk81bmNHS3pYZ2ZsZVhnSVNtUWxxdWROZGlWaDJuU3dJ?=
 =?utf-8?B?N0hNWDI4cm0xSlhBUDdLNVlwY0hXU01uZW9HdWgrZ01XTEwyWVVob1ExWVI5?=
 =?utf-8?B?WTlyRHRudmhBV2RpVnlXQzhxQUlhcW1RSUcvcmRNMnRmRkJpT1BrZHVoN0xN?=
 =?utf-8?B?R1BVbkpvNVhsKzhIblRtNWpHVHB2NFRvdHRncmpxVkVtMi85QXhWbzFHT1RJ?=
 =?utf-8?B?cnZBZ2Nid1E2eGxpcE8xTXJNUFpBM0VuakNoa1M1eW9BR1BQSmF0U2VKRjhq?=
 =?utf-8?B?TXkrOWQ2ZTA5Z0g1c2laT3NjSjBBUFMxbVR4ZnllV2lDMDA1cEtrbSsvWjFj?=
 =?utf-8?B?cHJIYUN2SWhSUDA3VFRsaFBjSDhyY0tGZ3FQODJjNUt0U2d3anVPemFOYVFr?=
 =?utf-8?B?eGw1ZXE3dzJmVEUvUWNSdmpzVmFXWDY1ZlQ0REFYSmxRV1A5RnkwSTBPR0sx?=
 =?utf-8?B?UTE2TzNCSTk2NWRvZ1NOL1NtK3VqMlhJS3VKc0ZnS2s1cUZDVXgwcGVFcE1t?=
 =?utf-8?B?VGtnQ256UEZtdlQ5d3RLZVN1VmtKOGJMNXlJN05PN084TDJhOUlWdUZCMlhI?=
 =?utf-8?B?b2xJdDRKeWZ3U0dRNisrdU5oalNWZzlhNFNJNGJ3a1Erd2Qvc1pBRHc0cEkz?=
 =?utf-8?B?bnl3OEI3bHM5WlpINUNSWmF6Tm9ZUFhOOVRsRExPbUptUHR5ZnNrTlpJMmJN?=
 =?utf-8?Q?unwl1tnToNddB90XlNSPp44c9Fdqr7URN6buoOW?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 287888d7-e1c8-4b3b-0c21-08d9921b71d7
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2021 09:41:22.3437
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Z7NKBsut0EvfOIvNN8jpq8XgPsaf7bcNZCgUh3FHPKx+4WVpqNPUDyqh29Tgs37hw9sJLJS8Onzk6Xx3w7KIzA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4220
X-OriginatorOrg: citrix.com

On Mon, Jun 28, 2021 at 01:48:53PM +0200, Jan Beulich wrote:
> At the time of d838ac2539cf ("x86: don't allow Dom0 access to the HT
> address range") documentation correctly stated that the range was
> completely fixed. For Fam17 and newer, it lives at the top of physical
> address space, though.
> 
> To correctly determine the top of physical address space, we need to
> account for their physical address reduction, hence the calculation of
> paddr_bits also gets adjusted.
> 
> While for paddr_bits < 40 the HT range is completely hidden, there's no
> need to suppress the range insertion in that case: It'll just have no
> real meaning.
> 
> Reported-by: Igor Druzhinin <igor.druzhinin@citrix.com>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>

> ---
> v2: Move adjustment last, to leave hap_paddr_bits unaffected. Add
>     comment.
> 
> --- a/xen/arch/x86/cpu/common.c
> +++ b/xen/arch/x86/cpu/common.c
> @@ -349,16 +349,23 @@ void __init early_cpu_init(void)
>  
>  	eax = cpuid_eax(0x80000000);
>  	if ((eax >> 16) == 0x8000 && eax >= 0x80000008) {
> +		ebx = eax >= 0x8000001f ? cpuid_ebx(0x8000001f) : 0;
>  		eax = cpuid_eax(0x80000008);
> +
>  		paddr_bits = eax & 0xff;
>  		if (paddr_bits > PADDR_BITS)
>  			paddr_bits = PADDR_BITS;
> +
>  		vaddr_bits = (eax >> 8) & 0xff;
>  		if (vaddr_bits > VADDR_BITS)
>  			vaddr_bits = VADDR_BITS;
> +
>  		hap_paddr_bits = ((eax >> 16) & 0xff) ?: paddr_bits;
>  		if (hap_paddr_bits > PADDR_BITS)
>  			hap_paddr_bits = PADDR_BITS;
> +
> +		/* Account for SME's physical address space reduction. */
> +		paddr_bits -= (ebx >> 6) & 0x3f;

Does it make sense to check for 0x8000001f[eax] bit 0 in order to
assert that there's support for SME, or assuming that the reduction is
!= 0 in the other cpuid leaf is enough.

It's possible for firmware vendors to disable advertising the SME
support bit and leave the physical address space reduction one in
place?

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Mon Oct 18 09:51:25 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Oct 2021 09:51:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.211898.369579 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcPIZ-0000EF-Jz; Mon, 18 Oct 2021 09:51:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 211898.369579; Mon, 18 Oct 2021 09:51:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcPIZ-0000E8-Gc; Mon, 18 Oct 2021 09:51:15 +0000
Received: by outflank-mailman (input) for mailman id 211898;
 Mon, 18 Oct 2021 09:51:14 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=MtCQ=PG=citrix.com=anthony.perard@srs-us1.protection.inumbo.net>)
 id 1mcPIY-0000E2-RF
 for xen-devel@lists.xenproject.org; Mon, 18 Oct 2021 09:51:14 +0000
Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id ed67dc1d-2ff8-11ec-82d1-12813bfff9fa;
 Mon, 18 Oct 2021 09:51:13 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ed67dc1d-2ff8-11ec-82d1-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1634550672;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=icSp3kkXvElRcEr7OU/i0al2/gtlmtJkYazfCeUEbYg=;
  b=U+VZbtHWoM6KWiRwSQmwHLvpkMl6/mKQjZQJFZu2GE2zH6jIaDYYWUAX
   YPK72XNRnveVwNlKAhAjp0Bc+0Ehs/0jerfCI7BOu0Zgvy+f1IlQUHdqW
   sbfKPlgWgRy5M4dZIWKULrOUUp+RZ3LBLfmQe4fJY27PzCgZRRtLFGzfu
   c=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: iZwXk77X7tVxmWmQa3b+epkYfrqoH1hSsv1JyWkxP/41SFCjXFzrs4+0g7maMVaYW/PAYYHDXp
 00t4HPfM4Z2AxmSjT+IS6/MjMdGaSs3YGmAEFxYqeKzzuMXdx7sS7F/sY5VR8ZccbwCkjL36Um
 EbB0iOppZfFpDsqKH1my+tQuDvSkatOgQfPrQ3eps2CJymPjIN0QfS7kVk3RgiFUWFBoiu3N7m
 8AVv8nu0DCW1kdWXpp2mtk60h44gpNgKs6ENO7LB8mdR1OK6kKKq1hpGuXczs3e08fq3MF4UVz
 wVSkx++ixVYLojtb9+V2NCUc
X-SBRS: 5.1
X-MesageID: 54980816
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:7+WWYq7/F1hvHr6XRCGk8gxRtEzBchMFZxGqfqrLsTDasY5as4F+v
 jQdWWmEOPeDMTT0eNona4W/9RkBv5fdy9E2Gwtu+H8yHi5G8cbLO4+Ufxz6V8+wwmwvb67FA
 +E2MISowBUcFyeEzvuV3zyIQUBUjclkfJKlYAL/En03FVIMpBsJ00o5wrdh294w2LBVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Z2
 PdvnJCoFwkVP4KLxMUtTSl9F39mFPgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALJc/3PIQZqzd4wCvQF/oOSpHfWaTao9Rf2V/cg+gTQaeOP
 5pAN1KDajz9MixmJHlLJakbkdqvpnzETSJCt0ys8P9fD2/7k1UqjemF3MDuUt+NQ99ckgCHp
 2bF12PjCxoeOZqUzj/t2kyrgujDjCbqQrU4Hbez9uNpqFCLz2lVAxoTPXO3rvW0hVS3c85OI
 EwTvCw1pO4981LDZsnwWVi0rWCJujYYWsFMCKsq5QeV0K3W7g2FQG8eQVZpZMQ9sc4qRRQjz
 lKTg87yHjtrraGUTnSGsLyTqFuaODcXBX8PYzceSgkI6MWlp5s85jrNRNt+FK++jvXuBCr9h
 TuNqUAWhagXjMMN/7W2+xbAmT3EjofNZh444EPQRG3NxhhieIevaois6F7axfVNNoCUSh+Gp
 ndspiSFxLlQV9fXznXLGbhTWuHyjxqYDNHCqU5NPbAt72qjx3+MOtxx0C9OAUM3Ku9RLFcFf
 3TvkQ9W4ZZSOl6jYql2f5+9BqwW8ETwKTj2fquLNoQWM/CdYCfCpXs0PRfBgAgBhWB1yflnU
 ap3Z/pAGprz5U5P9zGxW/sGmYEiwiQz1As/rriqkkz5j9JyiJOTIIrp0WdijMhktMtoQy2Pq
 r6z0vdmLT0FAYUShQGMqeYuwagidyRTOHwPg5U/mhS/CgRnAno9LPTa3KksfYdo94wMyLyUo
 iDgCxUElACu7ZEiFelsQioyAF8Idc0nxU/XwAR2ZQr4s5TdSdfHAFgjm2sfIuB8qb0LIQ9cR
 PgZYcSQasmjuRyckwnxmaLV9dQ4HDzy3FrmF3P8PFAXIs4xLySUq4SMVla+q0Ez4t+f6JJWT
 0uIjViAH/Luhm1KUa7rVR5Y5wjt5CdAxL8rAhKgzxs6UByEzbWG4hfZ1pcfS/zg4z2frtdD/
 wrJUxoeu8fXpIo5rIvAiaye9t/7GOpiBEtKWWLc6O/uZyXd+2Oix65GUfqJIm+BBD+lpv36a
 LUH1ez4Pd0GgE1O79h2HYF0wP9s/NDovbJbkFhpRS2Zc1SxB7p8CXCaxs0T5LZVz7pUtFLuC
 EKC89VXI5uTP8bhHAJDLQYpdL3bh/oVhiPT/bI+J0CjvH17+7+OUENzORiQiXMCcOspYd19m
 ep44ZwY8Q2yjBYuI+2qtCEM+jTeNGEEXoUmqooeXN3hhD00xwwQepfbECL3vs2CMo0eLkkwL
 zaIr6PenLAAlFHaen8+GHWRj+pQgZMC5EJDwFMYfgnbn9PEgrk83QFL8CRxRQNQl00V3+V2M
 2ltFkt0OaTRoGs42JkdBzihS1NbGRmU2k3t0F9YxmTWQn6hWnHJMGBga/2G+1oU8j4EczVWl
 F1CJL0Jjdo+kBnN4xYP
IronPort-HdrOrdr: A9a23:anYqX6yHcPyvehbYQ4k4KrPwLL1zdoMgy1knxilNoRw8SKKlfu
 SV7ZAmPH7P+VMssR4b9OxoVJPtfZqYz+8T3WBzB8bBYOCFgguVxehZhOOIqQEIWReOldK1vZ
 0QFZSWY+eQMbEVt6nH3DU=
X-IronPort-AV: E=Sophos;i="5.85,381,1624334400"; 
   d="scan'208";a="54980816"
Date: Mon, 18 Oct 2021 10:51:02 +0100
From: Anthony PERARD <anthony.perard@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, George Dunlap
	<george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>, Julien Grall
	<julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>, Wei Liu
	<wl@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, Roger Pau
 =?iso-8859-1?Q?Monn=E9?= <roger.pau@citrix.com>, Konrad Rzeszutek Wilk
	<konrad.wilk@oracle.com>, Ross Lagerwall <ross.lagerwall@citrix.com>, "Daniel
 De Graaf" <dgdegra@tycho.nsa.gov>, "Daniel P. Smith"
	<dpsmith@apertussolutions.com>, <xen-devel@lists.xenproject.org>
Subject: Re: [XEN PATCH v7 49/51] build: adding out-of-tree support to the
 xen build
Message-ID: <YW1Dhn+oEwvKgj04@perard>
References: <20210824105038.1257926-1-anthony.perard@citrix.com>
 <20210824105038.1257926-50-anthony.perard@citrix.com>
 <2aaf0858-1602-be5c-77e4-2daa7fddc534@suse.com>
 <YWmzSkLdH5wtQ77V@perard>
 <f53e4d09-9f33-6dc8-8161-156b9eca4a6b@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <f53e4d09-9f33-6dc8-8161-156b9eca4a6b@suse.com>

On Mon, Oct 18, 2021 at 11:02:20AM +0200, Jan Beulich wrote:
> On 15.10.2021 18:58, Anthony PERARD wrote:
> > On Thu, Oct 14, 2021 at 12:14:29PM +0200, Jan Beulich wrote:
> >> On 24.08.2021 12:50, Anthony PERARD wrote:
> >>> --- a/xen/Rules.mk
> >>> +++ b/xen/Rules.mk
> >>> @@ -38,7 +38,7 @@ SPECIAL_DATA_SECTIONS := rodata $(foreach a,1 2 4 8 16, \
> >>>                           $(foreach r,rel rel.ro,data.$(r).local)
> >>>  
> >>>  # The filename build.mk has precedence over Makefile
> >>> -mk-dir := $(src)
> >>> +mk-dir := $(srctree)/$(src)
> >>>  include $(if $(wildcard $(mk-dir)/build.mk),$(mk-dir)/build.mk,$(mk-dir)/Makefile)
> >>
> >> Perhaps already when it was changed to $(src) the name has become
> >> slightly misleading, at least imo: I would rather expect a variable
> >> with this name to refer to the build dir/tree. Maybe "srcdir" or
> >> even shorted "sd" right from the start? (Reaching here I can finally
> >> see why having a shorthand is helpful.)
> > 
> > I have to think about that. I've made some further progress in order to
> > be able to build the Xen pvhshim without a link farm and notice that
> > nearly every source file needs to use "$(srctree)/$(src)"
> 
> Oh, now I'm curious as to the why here. I thought use of $(srctree)
> ought to be the exception.

In Linux, the use of $(srctree) is indeed the exception. This is because
we have VPATH=$(srctree), so when `make` look for a prerequisite or a
target it will look first in the current directory and then in
$(srctree). That works fine as long as the source tree only have sources
and no built files.

But if we want to be able to build the pv-shim without the linkfarm and
thus using out-of-tree build, we are going to need the ability to build
from a non-clean source tree. I don't think another way is possible.

This can be done by teaching make to only look for source file in
$(srctree), and to look for generated/built file only in $(objtree).
That's mostly done by not using VPATH and making few other adjustments.

I hope my description of where I'm going isn't too convoluted.

> > and I'm not
> > sure "$(src)" could be use alone. So having a single variable which have
> > both would be useful.
> > 
> > "srcdir" might be to close to "srctree" and one might mistake it for the
> > other, so "sd" might be better.
> 
> While I did suggest "sd" as an option, already when writing this I
> wasn't convinced this would be descriptive enough. Personally I think
> "dir" and "tree" are sufficiently different names. I would suggest
> "srcroot" for what is now "srctree", but that would have the
> disadvantage of getting us out of sync with Linux.

Ok, I guess "srcdir" is good. Thanks.

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Mon Oct 18 09:57:24 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Oct 2021 09:57:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.211906.369590 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcPOP-0000tn-8c; Mon, 18 Oct 2021 09:57:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 211906.369590; Mon, 18 Oct 2021 09:57:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcPOP-0000tg-5P; Mon, 18 Oct 2021 09:57:17 +0000
Received: by outflank-mailman (input) for mailman id 211906;
 Mon, 18 Oct 2021 09:57:15 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=3tpC=PG=citrix.com=roger.pau@srs-us1.protection.inumbo.net>)
 id 1mcPON-0000ta-MG
 for xen-devel@lists.xenproject.org; Mon, 18 Oct 2021 09:57:15 +0000
Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id c35e8eca-78a6-49b5-84bb-42b4871dc8bf;
 Mon, 18 Oct 2021 09:57:14 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c35e8eca-78a6-49b5-84bb-42b4871dc8bf
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1634551034;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=RyGWxTBKD6WbOF06ONlYDNVyQKN75oBvoq99yMcM8ic=;
  b=VaTp7G7CAj/9FiEOHU8jcHviUIBJjCJS0qJlDtvG7RVrXDUP7GMkcv1N
   UiTiWFikV+IMxd1IrPEuAhI445Uu2ifM1r4kvASy9RcA86TEwlcdVtwLY
   qGPQ8v7phvUiXoTVMlZSnV+gAI0xEhlrMUnai2dJ7F8pm9S9OjElnqEJo
   Q=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: QadjKeR8QctnvhYlTxOQ48Pt4S3gbcT32FHgAf3RQxU9ehK0y+OLiCC5bzXHySOSp9ufVmqskB
 SO0mTIKffEkt/igYuru5dqjv+ULzFJl/Vqtrb3PMy96Tb64BFXVbKOZMd434/Kziu1kVgeq4Pd
 peHK3iTdkpNj3mjhjCFYlN0XRV1rCKwcAxleQ+cmkpcYHCTK86liRrBxcekumAwLsMfk0Sob3L
 E2oYT5BHGO8Yxm8YTfaIgAaF2hRWy0G/VFp0u9UTIjb6mfpwSxPtiwVYfy1cMENyDFSxZm2zCd
 nd1mfOU+i9wS1QR47ndRaP8a
X-SBRS: 5.1
X-MesageID: 57309191
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:6BndV642AffdRgya3BaCrQxRtMzAchMFZxGqfqrLsTDasY5as4F+v
 mUaDz2PO6uOZWbwfNh1bYjlp0MA68LXmoIyHgVrrC5nHi5G8cbLO4+Ufxz6V8+wwmwvb67FA
 +E2MISowBUcFyeEzvuV3zyIQUBUjclkfJKlYAL/En03FVIMpBsJ00o5wrdh294w2LBVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Zx
 /JN9pqoF18VYpLOnKM2U156KRwjFPgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALNs7kMZlZonh95TrYEewnUdbIRKCiCdpwgWhr3pEXTK+2i
 8wxaGQ/SimfXjx0HwlJNIAXnra3o0ijbGgNwL6SjfVuuDWCpOBr65DyNPLFd9rMQt9a9m7C/
 DKaoTWnW0tHHMWGjzGC9xqEhOXCgCf6U4I6D6Cj+7hhh1j77nweDlgaWEW2pdG9i1WiQJRPJ
 koM4C0soKMuskuxQbHAswaQ+SDe+ERGApwJTrN8uFrlJrfoDxixCU8EDThZNoQa6PA0QXsB1
 hirpe60LGk62FGKck61+rCRpDK0HCEaK24eeCMJJTc4D8nfTJIb1U2XEI4yeEKhppisQ2uom
 mHVxMQrr+xL1ZZj6kmtwbzQb9tATLDyRQkp+h6fYGuh6g5oDGJOT931sQaFhRqswYDwc7Vgg
 JTms5XGhAztJcvU/MBofAnrNOv4jxpiGGaE6WOD57F7q1yQF4eLJOi8Gg1WKkZzKdojcjT0e
 kLVsg45zMYNZyf2PPImOd7tUZVCIU3c+TLNDKG8gj1mOcAZSeN61Hs2OR74M57FwSDAbp3Ty
 b/EKJ3xXB72+IxszSasRvd17FPY7ntW+I8nfriil07P+ePHPBa9EO5ZWHPTPrFRxP7V+239r
 ocAX/ZmPj0CCYUSlAGMqtVNRb3LRFBmba3LRzt/LbLafVc6RTh8Upc8A9oJIuRYokicrc+Rl
 lmVUU5E0lvvw3rBLASBcHd4b73zG514qBoG0eYEYT5EAlAvPtSi6rkxbZwyceV1/eBv16csH
 fIEZ9+BErJETTGeo2YRapz0rYpDchW3hF3RY3r5MWZnJ5MwFRbU/tLEfxf08HVcBCSAqsZj8
 aar0RnWQMRfSl06XtrWcv+m03i4oWMZxLBpR0LNL9QKIBfs/YFmJjbflPgyJ81QexzPyiHDj
 1SdAAsCpPmLqIgwqYGbiaeBpoavMu1/AksFQDWLsefobXHXpzPxz5VBXeCEeSHmeFn1oKjyN
 /9Iy/zcMeEcmAoYuYRLDLs2n7k14MHipuEGw108TmnLdVmiFphpPmKCgZtUrqRIy7JU5Vm2V
 0aI9oUIMLmFIpq4QlsYJQ5jZeWfz/AE3DLV6K1tckn94SZ2+puBUFlTYEbQ2HAMcuMtPdN32
 /olte4X9xe720gjPduxhyxJ83iBcy4bWKI9u5BGWILmh2LHEL2ZjUAw3sMu3KyyVg==
IronPort-HdrOrdr: A9a23:U0pN7a/blHLCAkI20N1uk+FJdb1zdoMgy1knxilNoENuHfBwxv
 rDoB1E73LJYVYqOU3Jmbi7Sc69qFfnhORICO4qTMqftWjdyRCVxeRZg7cKrAeQeREWmtQtsJ
 uINpIOdOEYbmIK/PoSgjPIaurIqePvmMvD5Za8vgdQpENRGtldBm9Ce3im+yZNNW977PQCZf
 6hDp0tnUveRZ1bVLX3OlA1G8z44/HbnpPvZhALQzYh9Qm1lDutrJr3CQKR0BsyWy5Ghe5Kyx
 mLryXJooGY992rwB7V0GHeq7xQhdva09NGQOiBkNIcJDnAghuhIK5hR7qBljYop/zH0idnrP
 D85zMbe+hj4XLYeW+45TPrxgnbyT4rr0TvzFeJ6EGT6fDRdXYfMY5slIhZehzW5w4Lp9dnyp
 9G2Gqfqt5+EQ7AtD6V3amJazha0m6P5VYym+8aiHJSFaEEbqVKkIAZ9ERJVL8dASPB7pw9Gu
 UGNrCc2B9vSyLZU5nlhBgr/DT1NU5DWituA3Jy9PB96gIm30yQlCAjtYsidnRpzuN1d3AL3Z
 WDDkzE/Is+OvP+VpgNdtvpd/HHfFAlcSi8Q156Hm6XYZ3vG0i94KIfs49Frt1DRvQzvewPcd
 L6IQpliVI=
X-IronPort-AV: E=Sophos;i="5.85,381,1624334400"; 
   d="scan'208";a="57309191"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=RJXYYPkjoP0H6xz8ECCxl6nCCMwrdSc4lVa8hQckTIFdETS87o9KHsYDBWxjV3jAccCvcRacZ4NR3qI99KhfC0yT3M9oGe1naxIFAOjtxfUnGokjV8ilP6GCLN/P7eYDSqZipcMVLvitVoOTq/T6q/8no8ODZgyc2uvy2SAgHHDrRNMZJfe0QWoLkRRLwFKM7EF8szyq0MPB6cu0Q3iXoJSZkyg35jKC2Mmu38OqNTcBWxhpc3YhjIZ6GE4E99oO3jHdZPHXDjd3yimQl/lalrPwkIs6NL0taQdYbKQasWSybGTOm1Wo117h6hZsjEEZ5qrozqit+2UzQnAT0P7okg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=qUVuanLCYp2tf5S/pIWOPGQfpt/h7oPdd3wxBKvEsBY=;
 b=FUN08g16UwD+LHi4Zf2B23LHOcuJPb8hNT45UdWps1ianfdwa29FPFCCw/B0ToAbZ+97U4njIIurBodC8nVpCsJpHSP1kPrwiBXi8dtjna1g56mSO5PtQqHRbmTgIpWCaE7Lx217JtpJozSNK+vih+pCBLLOVw1C9JRwarmuOi6eUW2qL3WcQV2jJf6CihsC+2T2+xJDz1PEKHYyricfpbmGI8xwPwfxB8mYdYqqwgtrFo0cdF09uSDpR9BD4r04l9IWpwbcozPr4jHGkh+JrFTYJ9IPLcx8CiKZXhMbfa3JSBec7cxb/IKUk4HttX5kmVuEsl4JGC02P5zwlJq/PQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=qUVuanLCYp2tf5S/pIWOPGQfpt/h7oPdd3wxBKvEsBY=;
 b=FY4pp4cpou2t7zNPBILvq+xDDsV6G6uToz0YcixM/auh8CXnTymZSleiaOe4v66a0IQFbqwmTCCPcV7Yp6fZOiXiui0l99ITunn0ggymQuKMXzwqfVsNKCdAUN2ImiIrM2jsOMo1WFnl4I+e9zJJAyaY+O0dtVNVmkFS5pAAuWc=
Date: Mon, 18 Oct 2021 11:56:47 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Andrew
 Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>, Rroach
	<2284696125@qq.com>
Subject: Re: [PATCH] x86/PV: address odd UB in I/O emulation
Message-ID: <YW1E36QjW3YllTwz@MacBook-Air-de-Roger.local>
References: <b9bbc584-db3c-0b03-0314-3dd907f645bc@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <b9bbc584-db3c-0b03-0314-3dd907f645bc@suse.com>
X-ClientProxiedBy: LO4P123CA0351.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:18d::14) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 625670ab-ba9a-428b-1fbe-08d9921d9bc2
X-MS-TrafficTypeDiagnostic: DM5PR03MB3369:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <DM5PR03MB33692CFE6DFF67E2752E79168FBC9@DM5PR03MB3369.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6430;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: Da8rqofTuOFXlZXiQpsEXO4qWpjbCVj8F3JSEOnwWPHmnUbypbKaAafzsUg81KxjAgussKxj0qejiAWC9H74qBRJVYf4ukte6efFNedLBqenVOUGZ9LT7mzZI/flfX5POh/oUvSvRvatxV5SVIfqxdKAnzALAeoO0vKWbYaDbflp4ZYzusEcszYZOl2k3xuNAjtfNosrPgGQthw6cLyl0kyNorYWDGJAgrSS+vRf+CAfWFkx7MRy2T1MNjDhvsClsqJLLV1uN60qwSd2nv+FI5kEuPunxdCYsmplbHghPAsxa+V1zgcpHbLzCcT4X9dkq2QVkkRINKFAJCCvvlMv1/Bx4isBapZ/X1YeUPa/X4N3Em4lXbVFGk7dXNyCv7zMwzJJNrRKz3WL530sX/F+xr+PUrRQc8N8X9w/DT4KyqRMk/h9SM7IGGHI0cRZMWF4UUZ1X6QA1X54USr5zCleZNNYQLrIxbnDDvcCOlXt6pMNNj7s1jiPJ4Vek3voSb/lYANFzYV72QufsGDEqfe7DFqrQ73HTjYTyJsekvYnrTWVg1KHDZvXjn/jGDoDQhg5r5ah0UG/8UgkMJpmI7gGQ1S641cnMv+hISF94wd7IiC9oS5yWZEoK6RnvASb8z+BETjSKDTxfLp1Q1wmCK6nKw==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(54906003)(316002)(2906002)(38100700002)(66556008)(186003)(956004)(6486002)(6666004)(4326008)(508600001)(86362001)(26005)(66946007)(5660300002)(6916009)(6496006)(82960400001)(83380400001)(9686003)(8936002)(8676002)(66476007)(85182001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q3dKQnFvZDRVaGtHZENGMTR5SnR4ZVBpeFZ6cUNZcEVZdG44NVR3S1lUNmNQ?=
 =?utf-8?B?U09IbkJXcXNKSEVqRjIzVURFRUYwZG90UC94NzM2SXJQTDQ0dkdiVEZ2N2Fs?=
 =?utf-8?B?amdQNGVMTVFkSWY2eHZ0aDJOQllwRE9WWW94THFKcmk2S1dZaTJ5WmNBQmQr?=
 =?utf-8?B?b3FpeHZSYkFVTnBLWUtsUzFNanVJenpnNFM4WFkxeHVpbG9XdS9Ha2pua1BM?=
 =?utf-8?B?TWcrcnBiRUdTQ2hHZ0owVHJqaEhsSTF2bUsybXpZRm11ZW9ObDI4UDkwSFds?=
 =?utf-8?B?aUsrVWlON2F2WU10TkFFWTRTUFhVQUhRdUplTW1aQ0Z4d1UweU5mTW4vQWlI?=
 =?utf-8?B?Q1JQaXpsci82N3BEb25MUUFJazNDUE1qbmVKa3E4L2JhaGh4R2hJOWtOUWlE?=
 =?utf-8?B?REs4L1FDV0d5YnFSWkkwRHBIMHZTaTBIcTlaRDk1dHhlRTFUK1dXRGQ0Y1Jo?=
 =?utf-8?B?V25qNzBUbTBROHpHa1RKSSszTkhlZCtreTFqTUtpRkhIaHptK2pOTDBQRzFZ?=
 =?utf-8?B?QXg4d3J0Tys2LzhyYS8zTXlvajg1c0hBOExSamJXUEN0N3hpazlGWWtGb3pI?=
 =?utf-8?B?QU8vckVpTkx4Q1JCYmxwNDQ5KzBHdEhBSGJBbkpGdVFRVVY2aklCaTJrMG5h?=
 =?utf-8?B?cWJkK1dzSXYzSUVDdHlRWCtsYlNROWFNaHdGR0RZK2R2d1pQWGFIRjhScGVm?=
 =?utf-8?B?NHpMYmM5VGtkcjh1Q25iZ0RjSk84RnByc2M3OUpDSnhMOS9FdWNnNnVkQm9H?=
 =?utf-8?B?N3podXQvL3c2cm9IcXNNOHgvRGNLWUIwdzlndWNXa3dLZzMySVlmRWYxTUdC?=
 =?utf-8?B?S1V2SkJqR2liTEc3OXdUb040UFFrWVpMYTJKSG5jcXFsTEo0eEMzUkw4cC9u?=
 =?utf-8?B?bXRCMzFIZCsvazlnMmF3dklrTnJ5MEEzUlFGc0hxVW9zd0pKSk9TbTZrNmxz?=
 =?utf-8?B?ek1vakF0L1BVVU45VHpiVzViZE96LzZZTTJMaG9nUk12aFBpN2p3ZE5naStx?=
 =?utf-8?B?QjMyRXBNQUZuSWE4MXVoK3JhbWFjUWtNeWdKSWF4NDExSHkzUDM0U2p1S2dt?=
 =?utf-8?B?bjdVQjlqNElzMVRScUV1Z1QwckNQT0x2Y0dXYjlBelo2SnMyY3NLMTdPc3pn?=
 =?utf-8?B?V2ljZTVzL3VzSU1pZmxXSFJ1MG9yb0w2WXdLTVVNdnlLNGdpYUFTbEl5QzRR?=
 =?utf-8?B?Rk1ZQnhwVVlUWjdTaUlOTUlhVXc3d29QTkF3bjUwSnlieGZoWUUvVHlPakpz?=
 =?utf-8?B?WEM1ZXNiUStBK3pRcDBvVjBkb3ptZDlQU2tINWlPdFNaT3BVUXg0TXY1ekVM?=
 =?utf-8?B?WHBTOThhSm1ISEZ6bkJxRjhUQVZ3d3kxS3BkU055UkxHMXNKYkxqU0tSUHR2?=
 =?utf-8?B?SmdzRWhOb0tiSklJaTRsVHNnZGdRVU5rWFd3THp5aEtkcDNGWDRsNi8xeTVE?=
 =?utf-8?B?MXNLVFN4Ukg2MFo5bXVDVkFlWnNkalBvdGQ5WThWMCtZa1lvaHRvRG5TV2Vk?=
 =?utf-8?B?ZWlkZWxDTXpyckVYTjN4Y3NjL0QrUnVMcjhKRmQwdzUxOCt5NkR2aGF4b1NS?=
 =?utf-8?B?eTZzam1GdDdZZVp1V3F1THZ3NEI0Q24rQml3RWRyc25mOURna29zWjFGTklu?=
 =?utf-8?B?Z1Y5eXk5VXJzZW9sVDZvTU16ZUh2alNJM1hHbFZsU1Y3Skh3c1dHd2ZHNlRk?=
 =?utf-8?B?M2tBQ3pFc1hENldRZTdHVG9aaU16b2l2dWhVZDF5ZS9oVU11UEo1VTJuSUpi?=
 =?utf-8?Q?04TUx7qiQrTCW1tXAADZNnuHP1jD1kLFWHUkY+9?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 625670ab-ba9a-428b-1fbe-08d9921d9bc2
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2021 09:56:51.6614
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: TadtwWPmSkyboh9n++WW31beRlxPDCZA8Nk9Y5W6qtH4BSYk+J5coV6S77f9Qe03rGqXZhGBcAy/WiuhIEGx0A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB3369
X-OriginatorOrg: citrix.com

On Thu, Jul 08, 2021 at 09:21:26AM +0200, Jan Beulich wrote:
> Compilers are certainly right in detecting UB here, given that fully
> parenthesized (to express precedence) the original offending expression
> was (((stub_va + p) - ctxt->io_emul_stub) + 5), which in fact exhibits
> two overflows in pointer calculations. We really want to calculate
> (p - ctxt->io_emul_stub) first, which is guaranteed to not overflow.
> 
> The issue was observed with clang 9 on 4.13.
> 
> The oddities are
> - the issue was detected on APPEND_CALL(save_guest_gprs), despite the
>   earlier similar APPEND_CALL(load_guest_gprs),
> - merely casting the original offending expression to long was reported
>   to also help.
> 
> While at it also avoid converting guaranteed (with our current address
> space layout) negative values to unsigned long (which has implementation
> defined behavior): Have stub_va be of pointer type. And since it's on an
> immediately adjacent line, also constify this_stubs.
> 
> Fixes: d89e5e65f305 ("x86/ioemul: Rewrite stub generation to be shadow stack compatible")
> Reported-by: Franklin Shen <2284696125@qq.com>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Acked-by: Roger Pau Monné <roger.pau@citrix.com>

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Mon Oct 18 10:05:46 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Oct 2021 10:05:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.211914.369600 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcPWY-0002RM-3H; Mon, 18 Oct 2021 10:05:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 211914.369600; Mon, 18 Oct 2021 10:05:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcPWY-0002RF-09; Mon, 18 Oct 2021 10:05:42 +0000
Received: by outflank-mailman (input) for mailman id 211914;
 Mon, 18 Oct 2021 10:05:40 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=628V=PG=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mcPWW-0002R9-Ar
 for xen-devel@lists.xenproject.org; Mon, 18 Oct 2021 10:05:40 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 70ab5db1-b36b-4c71-a0f8-90594bb98fa0;
 Mon, 18 Oct 2021 10:05:39 +0000 (UTC)
Received: from EUR01-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur01lp2058.outbound.protection.outlook.com [104.47.0.58]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-18-yUx8K1_rN9OVpeb_DTNfSg-1; Mon, 18 Oct 2021 12:05:37 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB4352.eurprd04.prod.outlook.com (2603:10a6:803:4a::25)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.17; Mon, 18 Oct
 2021 10:05:34 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.018; Mon, 18 Oct 2021
 10:05:33 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS9PR06CA0008.eurprd06.prod.outlook.com (2603:10a6:20b:462::22) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16 via Frontend
 Transport; Mon, 18 Oct 2021 10:05:32 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 70ab5db1-b36b-4c71-a0f8-90594bb98fa0
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634551538;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=aSXbxzvs8zpBem+PLCV7fg/9RgUqsDun3ZepPvgOWY4=;
	b=HcnH71aBGMnTooCcinMjsC7cfk3eihMF83PsfTl6FCV1Dx3qMsHf8kKFpuzMoIKUAivlMK
	g3EAcdiVfiaeKQS9qVEO+RtRcjpAq5BV6gpSCVCRp5KcnjJd9NKI2aQJR5LChhkqRz2Ptn
	bucdo9xe1+FloZa0HgfpA/MJaqfnB+g=
X-MC-Unique: yUx8K1_rN9OVpeb_DTNfSg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Uc8dYR9mcgUh1pBVIzfk+mQUBSptFbQkc9DZDIWq57j4fgJKn5BCJC4VIJcNibafoSFjNm3ghaTvBcRzYuP/1knTy8MkenyGFFBypZtYJQSHujIhVv34rCjN0SY7Hm7NNl+jcv9IUwDAL6koYShl5KcB0ys1iubFq9bgvGLqalA459mZUeqjxZbQS2Cb7p8MQRByZBkQYzgY/PQz+pFtGzztu0EqJ/Ab9L6KX5gFiBuQqSJwM/NEW30cOwKENxxew0stWOYW9m4vHmqvKj8lipaMQRYBoO9P3nvN8fAbEkBlNsQq/+8/BnawesIxzN+uLkmwlpnZ9FjD9mPjMs3A8Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=aSXbxzvs8zpBem+PLCV7fg/9RgUqsDun3ZepPvgOWY4=;
 b=akCDQDLW8rMIQ/pN11IoFsV2FFTmJpK3AUxTO7N4Xp6l0uBXX0ydnCIDfHimL9WBbdLpjMLPRuOF49eI+Z/hbfiiRKmmSM3r4xD1UEbod2Fh2cssRYJXXJhFqf0I9z1/owKnClX1S49KF6dMIKV4uTciWNIASQUFSc/QpqlXE1m2pOKmugMvX2NJB4pEbicyYZpIkJ776Ls1G9S3RQB1bRcRfxHtwcljUTslyWzRds3RaCVRCMSMCm8t1iAV/BoaTy30JjUs4nC66f3YPkoi+p9tF1himXBRLraSXL2LujsQSe+FGugAcFA/PqrHyIGuNM0WYr/vuoVWHlGlh/C4Mw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [XEN PATCH v7 49/51] build: adding out-of-tree support to the xen
 build
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
 Ross Lagerwall <ross.lagerwall@citrix.com>,
 Daniel De Graaf <dgdegra@tycho.nsa.gov>,
 "Daniel P. Smith" <dpsmith@apertussolutions.com>,
 xen-devel@lists.xenproject.org
References: <20210824105038.1257926-1-anthony.perard@citrix.com>
 <20210824105038.1257926-50-anthony.perard@citrix.com>
 <2aaf0858-1602-be5c-77e4-2daa7fddc534@suse.com> <YWmzSkLdH5wtQ77V@perard>
 <f53e4d09-9f33-6dc8-8161-156b9eca4a6b@suse.com> <YW1Dhn+oEwvKgj04@perard>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <1220e343-3082-9f1d-a788-c4369f2944f6@suse.com>
Date: Mon, 18 Oct 2021 12:05:31 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <YW1Dhn+oEwvKgj04@perard>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0008.eurprd06.prod.outlook.com
 (2603:10a6:20b:462::22) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: b330c19e-4da9-46a3-42f7-08d9921ed313
X-MS-TrafficTypeDiagnostic: VI1PR04MB4352:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB4352346AE642247F04F1C328B3BC9@VI1PR04MB4352.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7691;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	1kiP1MOEZipR4A+fhtV06T1lEQB8ZS+ZOHCiutFNu4z82QeX6TBP+/FzIwLpP9+NHzxvZvhAHM3Qh48KXOT39+quiafKwzDS6SMMlYNrjt9FQhP1TeGIC60RbrbNueO0XH6YRaqOFysGPO1tEpJtpOYFeiQP3yUcsGc/Bf8yj8t2svMJWPpVYxc12dhoa2HcxM7kKMzF/l85zJet39xuYjwaQVxqAm2f9HkvhrojU8OLz3Tryd9pKPD3R98ziotOMeO0cn0/uS9+5ZCKXL5Oe4n7owk6erSSGHldZ4hXEawRzOq7NfTECuxUqAK0Wvkgvkr5sq2Af0E/TiKEs/5Ng+dqN7KSnilEAyV9mcmuKn+0DxvpJDL4UP4SIdktZK0IpnN21mTrdFBokt45EwTCxkKJ3r35QbFxIOyjLCdXlzussnLKfbJtz80pNqDc5oQmGyZO8hZnCJeJ/vQ2NPgrKVBN8p+181YCE8R1AA1IG4c+bE59oCVgVD9qP0TLSk+EDJ+wRCEGuTPwxrp5ATHZE3kaeTBgBJieHkA0MlwGfKbvh6HcUtEa+/EJqOw0zi+kbeoxcBMANn9FkG0WCnEV4SWlLfIha8hW3wjdW3EfpH3S2M9n55LMH5LggXaSfmL4BHJhROJuRtJvAWgEIrriMuVPTjZoTCXKYKhN6RqZ+7yQ7sXHhFXGhc6MzdMIvD4EYTmrfGjWoNTMWoHkTEBThAcsiIu51xILLLnuvPE51kjJBEA5nDRn/e7ZtXy7K2oL
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(508600001)(38100700002)(2906002)(6486002)(66476007)(83380400001)(5660300002)(36756003)(66556008)(66946007)(2616005)(186003)(8936002)(956004)(6916009)(7416002)(16576012)(54906003)(316002)(4326008)(53546011)(31696002)(86362001)(8676002)(31686004)(26005)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?ck9zTVh5M2pwWkxZLzJlWmxOUjdwbUova1hSRG55QkErc2hXOCtYZ0NDUmZs?=
 =?utf-8?B?ZVZKdHM4d3JWcFltRndyODRHQmREQXNKc3lDNy9EOEFDSHlOeXl1OGRWYWpT?=
 =?utf-8?B?UG5NTXRTL2FXbFpYNmpScUJlTk15aDJzK0Jpd3ZKOFAzM2NNYTlRVVhKZmhP?=
 =?utf-8?B?OWlYdElvL1JHWStveTVYQVBDbTBSUE9obldjNnczNlowKzFEWEJmRzcxbExz?=
 =?utf-8?B?VHJnb2pKMXBtTE5PL2IvVURYUVlpeDNZLzF6bnd1NVk4Q21JRkdweVpLQ2pD?=
 =?utf-8?B?VklEbmFUZzV6dDUwaWwvcWtjbHB1OWpBUUFmckJuamN4SnFaT0gzVVJnMWtE?=
 =?utf-8?B?Z3lURjJ4ZjZqc0N6Tktvc3hmNjQ3bnhPZlYzTG5KNFJQMkRBVVJ6WGdLaDVF?=
 =?utf-8?B?SVd2WkdHdEt5b2RRS3dXRkdId2hONnBweTlTNVVtUzh1Z0pGQjd3QVZmWVlV?=
 =?utf-8?B?WENNcm5tbVQyT2ZBdW5qLzZNd1Rzbktxd25mTlZINU81c2R2TERQZlJCekdC?=
 =?utf-8?B?ZlM2WkNhU0FQaVJhY2NpRkVoMTI3b0hVQ2VEUXlwRXlzMFE1UmppM3QxNFha?=
 =?utf-8?B?c0grcGs0Q1lXYUxka0JQaURDSnBDVTI1YXhCenplcXYyTm96eGxhaCtLT2gy?=
 =?utf-8?B?OEFhU211eXdHUzVWQ0h4ajJOWXI0N0Y4TnZmVnZsYnlNS3pZdW0rcjB4K2xt?=
 =?utf-8?B?UjhIYUJSYUFqVVhVSzRsZEg2THhHMDd6dCs0K01ielBsZCtlL2s3SytEVFQy?=
 =?utf-8?B?ZUovdXM3Q0tYcVNXUGlnRkpUcytKQnZWSmRtTnN3WUtucEU4SFhYUUF3NDlj?=
 =?utf-8?B?c2h1L2lBaFFjQ3phZEhnczB5UVNvTjhZYndhNnZSNGNDMU1vWVp5akZTL3RC?=
 =?utf-8?B?MmpQSDNJQmRrRVUwbnFlc3ZRUU9HY24wZUh1QThHaWFPbzdmeDRKWDR1ZEUz?=
 =?utf-8?B?Unc3RTJ2T2FrY0RZd0MzT0lzcnB2WllPMjhkOXJQblM3UTYwUUIwNUhlakNt?=
 =?utf-8?B?YVBQQkNKTzdPU202bnRTWTZuSlNjU1NjeHdMQXlXVWJHOVNvRmR4WGc2Nmt3?=
 =?utf-8?B?U3V6T2xReThkVGRIazQ0YzJVbnlETGZYNkNRSEtFNlZ0ZTY5U0dKTTExcTBY?=
 =?utf-8?B?SE5CZTFpaFNMNUl2NEpXMW1waFArMjVhMDVzYjYzTG5wSkJZZU9ua0RZVXFI?=
 =?utf-8?B?WUNRZVRxVFRxcHVzWFMzaGNkaG5YMVJpRkNndGZoYjlOMDFJUmRKcnRVR29K?=
 =?utf-8?B?RmU3bm9MRENjR2VaQ3RHRjFsbTNURlFOeE9NOFVML1IrMWxVTFJFRGo5WTE2?=
 =?utf-8?B?UXBZaDVuNGZiWG5nZ2p6WEh4ZHZUVVhjcWVBVjZPRzljeFJzaHZqcm9vNlNN?=
 =?utf-8?B?dkFWdmd0RDhMbFRXUXlxVzFKQ21BMmR0Tm9BSVhzNFN5S2ZrRzEyYkRLS0RR?=
 =?utf-8?B?TUZaRDNOS08vd1JzTzF3U3d3USswTXpVR0VPTytLN01UYXZEZnFnWmIyd1ph?=
 =?utf-8?B?WWdERzZiLzZrK20xQXFTZnFFZlRrRDhraHpTV3JiVkFPZjk2NWM1N0ZMZHUv?=
 =?utf-8?B?aVhkUWlzck0ycXkydzUzcmh0WityUXNTNW5RVW85bXFhcnMzdFkrNWQ0UjY1?=
 =?utf-8?B?eGVnQ2JCSXZHdmxOM2ZEZXVRVWk1QWR0K2lQcjk5Uk15d2MxeTZFMWRLbnlv?=
 =?utf-8?B?NHR2bG9lM3lxeHI0Y0FQbWJWKzNUdTJrR05tMSt0MjZPWEVoL0F3eExndzNL?=
 =?utf-8?Q?mfzp9Dj5cuqx3CvJ3zNAJLljGGpFcXOz58bmnRU?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b330c19e-4da9-46a3-42f7-08d9921ed313
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2021 10:05:33.8814
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0AA5bMBD4SNPeWp3Qz7qA25YBP/hXnOiaGJOSuZuZH3cB+fOopbp8QTThDheATFqcUtL/TGaESrNrWcEnUrDtA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4352

On 18.10.2021 11:51, Anthony PERARD wrote:
> On Mon, Oct 18, 2021 at 11:02:20AM +0200, Jan Beulich wrote:
>> On 15.10.2021 18:58, Anthony PERARD wrote:
>>> On Thu, Oct 14, 2021 at 12:14:29PM +0200, Jan Beulich wrote:
>>>> On 24.08.2021 12:50, Anthony PERARD wrote:
>>>>> --- a/xen/Rules.mk
>>>>> +++ b/xen/Rules.mk
>>>>> @@ -38,7 +38,7 @@ SPECIAL_DATA_SECTIONS := rodata $(foreach a,1 2 4 8 16, \
>>>>>                           $(foreach r,rel rel.ro,data.$(r).local)
>>>>>  
>>>>>  # The filename build.mk has precedence over Makefile
>>>>> -mk-dir := $(src)
>>>>> +mk-dir := $(srctree)/$(src)
>>>>>  include $(if $(wildcard $(mk-dir)/build.mk),$(mk-dir)/build.mk,$(mk-dir)/Makefile)
>>>>
>>>> Perhaps already when it was changed to $(src) the name has become
>>>> slightly misleading, at least imo: I would rather expect a variable
>>>> with this name to refer to the build dir/tree. Maybe "srcdir" or
>>>> even shorted "sd" right from the start? (Reaching here I can finally
>>>> see why having a shorthand is helpful.)
>>>
>>> I have to think about that. I've made some further progress in order to
>>> be able to build the Xen pvhshim without a link farm and notice that
>>> nearly every source file needs to use "$(srctree)/$(src)"
>>
>> Oh, now I'm curious as to the why here. I thought use of $(srctree)
>> ought to be the exception.
> 
> In Linux, the use of $(srctree) is indeed the exception. This is because
> we have VPATH=$(srctree), so when `make` look for a prerequisite or a
> target it will look first in the current directory and then in
> $(srctree). That works fine as long as the source tree only have sources
> and no built files.
> 
> But if we want to be able to build the pv-shim without the linkfarm and
> thus using out-of-tree build, we are going to need the ability to build
> from a non-clean source tree. I don't think another way is possible.
> 
> This can be done by teaching make to only look for source file in
> $(srctree), and to look for generated/built file only in $(objtree).
> That's mostly done by not using VPATH and making few other adjustments.

Oh, I see. That's ugly. Just like in Linux I was expecting that we'd
do/support only in-tree or only out-of-tree builds, but not a mix of
both within the same tree. But I can see how this would get in the
way of a build of everything from tree root (something I personally
have never made use of).

Jan



From xen-devel-bounces@lists.xenproject.org Mon Oct 18 10:06:10 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Oct 2021 10:06:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.211921.369611 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcPX0-00031S-Fd; Mon, 18 Oct 2021 10:06:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 211921.369611; Mon, 18 Oct 2021 10:06:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcPX0-00031L-CZ; Mon, 18 Oct 2021 10:06:10 +0000
Received: by outflank-mailman (input) for mailman id 211921;
 Mon, 18 Oct 2021 10:06:09 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=RpTT=PG=epam.com=prvs=0925c93432=oleksandr_andrushchenko@srs-us1.protection.inumbo.net>)
 id 1mcPWy-000317-Vj
 for xen-devel@lists.xenproject.org; Mon, 18 Oct 2021 10:06:09 +0000
Received: from mx0a-0039f301.pphosted.com (unknown [148.163.133.242])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 0251ab1a-2ffb-11ec-82d1-12813bfff9fa;
 Mon, 18 Oct 2021 10:06:06 +0000 (UTC)
Received: from pps.filterd (m0174676.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 19I9S3Rl029117; 
 Mon, 18 Oct 2021 10:06:05 GMT
Received: from eur01-db5-obe.outbound.protection.outlook.com
 (mail-db5eur01lp2058.outbound.protection.outlook.com [104.47.2.58])
 by mx0a-0039f301.pphosted.com with ESMTP id 3bs6ar855s-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Mon, 18 Oct 2021 10:06:05 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by AM4PR0302MB2659.eurprd03.prod.outlook.com (2603:10a6:200:95::7)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16; Mon, 18 Oct
 2021 10:06:02 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::c038:e032:595a:651]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::c038:e032:595a:651%7]) with mapi id 15.20.4608.018; Mon, 18 Oct 2021
 10:06:02 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0251ab1a-2ffb-11ec-82d1-12813bfff9fa
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=WIdU+3xgHdaxhFQ28jz+zaBOgwNCD/vKeR0+ci75DK5jLJOXpEjxPVoDWDbysJETqlZehG4dpMZVJF4fI8YYE6eOr2BsVTc0+twKy4H82VIri7yl5hzh5m5vqVQUFNcrf6/i53b5qEKYxZgmrXSINsjKeNNHGpZZ9CeGfdY92Q0o1V5BIzw+9cBiHizOj4Nr/Mg4mPRjL6J552ot7vem1kU1OaF3ISZy0Qwp8tOVUKE2ccFRP6orbgBioW1++q7kPSXswXOk5fWXv5JM59ZHDfI6tIWNbPv4+mr3+1CSXGtv6MR9m/U19qsnNIMvIkSVGyXia8CAfyzLUFXM3yXM4w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=SsCgakRF88Gi8f0O1TajMGiNPGor3X03uI6NAkKhJJc=;
 b=ZHBpzeKma1vryNTZvcOZcqFMDkYj4C6W6u/iLYog/y35sM0zE7BFQWn3r+QizCRMKSp8kjssFhNgvzGxAZpdS3+c2GZI+9JNdaSjEDlv/nZX0gp8CLqU4NWwWO+pQfj+DOd3gv945u2lYGEPZs8ah4lD1N4c62BcyPb6dd7KbmWer8IFi6xCgl8/qeQ/mGvb1Y6kSlifT3bFcKe38o9KdV713/AajGOYj7j54Fyf2uwD6DP41wpCC/5AG/3SPPTDiiqlBKz7i/KGAnDEqj7Qmn76PKDazsWhe9WF5jv7jGGc+or4/bclChqmye1i1Aa3mm9ODJhP7KX7xABqcIfbtw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=SsCgakRF88Gi8f0O1TajMGiNPGor3X03uI6NAkKhJJc=;
 b=VEju3V9GQoOmLYQC1LuZGeN2rqE2l845N5shk1CISEqmH6vWdIohWsD77wRhD83GfWsXfBCQ/QqkUN455y1s7Nb+uFXEI0zDhzAL+9duik9ojXCElnbFV2A+tkz7nIRTOs7FOQZ3wVi5GydWYQAH/mLVew3WBLTbhaf6qnN7uSMIyCohZG8F2sO2x2+LdnYfuF9nk5q5WtwGlQXnagqfR3TXtAIgNWT5BTydTip7deSJ7NZBgqYuK21q7emk3/m7jB6GsDMZ5deOFPAFNgXMHjIShoSxycXwi62JEk3ooudbS51T8cSJIHLanXHY1x6f1d3Zy2Oy8eFrTj8bxv8vjA==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Jan Beulich <jbeulich@suse.com>,
        Bertrand Marquis
	<bertrand.marquis@arm.com>,
        Rahul Singh <rahul.singh@arm.com>,
        =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>
CC: "iwj@xenproject.org" <iwj@xenproject.org>,
        "sstabellini@kernel.org"
	<sstabellini@kernel.org>,
        Julien Grall <julien@xen.org>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Andrew Cooper <andrew.cooper3@citrix.com>,
        George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
        Paul Durrant
	<paul@xen.org>,
        "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>,
        Oleksandr Andrushchenko
	<Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH v8 2/5] xen/arm: Enable the existing x86 virtual PCI
 support for ARM
Thread-Topic: [PATCH v8 2/5] xen/arm: Enable the existing x86 virtual PCI
 support for ARM
Thread-Index: AQHXxAfAx+Lzp09rU0elFmx0jxVt5g==
Date: Mon, 18 Oct 2021 10:06:01 +0000
Message-ID: <387863e8-3de6-0aa9-032c-4cde7cb61679@epam.com>
References: <cover.1634315461.git.bertrand.marquis@arm.com>
 <e2b10f56043155e4bb8eae824723045ccc042f8e.1634315461.git.bertrand.marquis@arm.com>
 <ca5558b2-25c6-90d2-284b-03cbbb02691f@suse.com>
In-Reply-To: <ca5558b2-25c6-90d2-284b-03cbbb02691f@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
authentication-results: suse.com; dkim=none (message not signed)
 header.d=none;suse.com; dmarc=none action=none header.from=epam.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 136b3300-56ee-4bfb-ec82-08d9921ee3fb
x-ms-traffictypediagnostic: AM4PR0302MB2659:
x-ms-exchange-transport-forked: True
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <AM4PR0302MB2659B3EBFBAFF408E18F06FCE7BC9@AM4PR0302MB2659.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 cNwY3YOx0ouoBgBCdMs2Etu1hb7wGiGQ2SdCTjXa8sJiEpwLCk0/GAydg4qbnj9y8NcfnwBwsQ6h8HIxVozT6wHM8aiCs00VhLW0wi4t4lFtCKi5wt8PDjB+b/EP060F78kpCnGy34KPCfdWtzTzqXBu/3FPdh9wBEvqwxVyxTi2bf0htRVIFxcmAqzcJW+L3i0Ev4K6xDvLA2/McrvJLLFtHRPV8S5a+UpO6mMFsRw18CFtdgpdycIz2Al8jqGUIKNLBJ09UcgyxQur+q92mCWLxpt1KoAgJj65H/aB86D/ksolcawhk4UK0dUNlv+YP6cvmAnuhuhq9mYcilyDDMOr98Qh71QmPrGj0LOyb9IHbmqZbydXcXuVrA0/HWy7nUVILLx6CPbe87WFWHFq9FJgZUgt3vYm0qSCHc4RPdeyReAPOOxexFv0vzq6/Ejhlw15CUZfAEjpJU8IxPw+8GF8lHfg7RKjSYJ4Xe6UIjVVjeF2w8PW++G7E7fhAZ9C7+6/vLB3dt8ssfKKsXwYEoJj70tOMS6kR4mPMO1xrx5HIobrd0Wb8MO/Ht7nERm70LYt0vICY7aiaNu/LS72C45LqKZ7OzGqquqBY4XzPYXU2rtqFve6QEt0e8sj5ZYOCc5csCLCTvwRUoQZuCeR/bz9R6hiyLFX42x1Wyx7bAxGWO/QBLY792AKGmh9u4cku44Y4cZbN6Lc+NTbavLgZGUnitFGDHIGAwXM003szf+VkESmakfnrTpCC9IzHPZJymJKKItJOr3nWiPjFwNwHw==
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(31686004)(54906003)(31696002)(71200400001)(66556008)(186003)(316002)(6506007)(2616005)(110136005)(86362001)(26005)(6486002)(53546011)(6512007)(8676002)(36756003)(66946007)(91956017)(5660300002)(66476007)(122000001)(64756008)(8936002)(66446008)(107886003)(38070700005)(508600001)(76116006)(38100700002)(2906002)(4326008)(7416002)(2004002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?SnhJZEdIRXlGcVB2Vm8wL3NpMjJReGVRTHNLWUJ4U1hTc1dHOVFUa2VobWhk?=
 =?utf-8?B?VzFnNElHaXRSUFliL0V3YlVuVzgxMmdjaWhIMTFSOHRtT3JnR3R6aTFpS09L?=
 =?utf-8?B?aUROSHUzMkNPTGdSbjhaVEdxZVBhL0Y1K1AxbzhnYlJoblR2Z0JBR0NRNUsy?=
 =?utf-8?B?cTdTMjZITCtYRlpzWkJJUXVGZEdEdXEyVU1OSUphUmJIR21NekJvRmRwYmMz?=
 =?utf-8?B?dU9aMXRGZWxBMGVyeFJqSHFtSnJNbDQydVlKRitPTlRrUFFQejJDMVdTWnZw?=
 =?utf-8?B?MmhoYkNkWmdDdzZINjkvZ2ptVitkTkhXbnlhNDQzbThWOEROeTk3Y21LVzZJ?=
 =?utf-8?B?NEkyVHA4ZFpUcnlsSUluM09mMlNWdlNGMTIvZHpoYlNyMVY4STg4RE1qbXJH?=
 =?utf-8?B?eUpSWXdqU2xIUUlld3NsdmlTcUNNNS9YTk4zTHJBV1RXWVdQNWJHK1REaUto?=
 =?utf-8?B?Mmh3R1FUZktBS1RUK2hWK2JRbGlHR0cvc0VEOER4SzEweFVNdjhzeXVjNk1M?=
 =?utf-8?B?ckNmVmpEbENHTnl5Ry90YkhSQUpEMU9seTRISHlJeE9XK0RNZmlzZHlGOGs3?=
 =?utf-8?B?Q1pQbGVaMHBRQ25HV01BUWlpNHpublVaUFkxTHo4dDZlRWtSeUd0RDdYTU9O?=
 =?utf-8?B?Z3IxTTAzUS9vM2lGbnh1bFJEU2pjRUk2NUxNWDFORGk5UmJ6M2JvcHg1bkFO?=
 =?utf-8?B?VHo4REgyWGRpcXNTcURvYVIwTHdPUEhsVVF4aDdSOW1WNndKNSsxV294TXB6?=
 =?utf-8?B?Zkx1YVBmbHBianRhR1V6NlpuMS9jRFlYRXF5c2J5R1JKTFNkblcyTWorSTI4?=
 =?utf-8?B?TGdINUNORjJlY0VhMlRUUVNkUndsZE8zaUJvRTNkbXlpK3ZYL0lRM2I4NEZ5?=
 =?utf-8?B?TFpOVmRxaWcyWHMrb3NLS2hHc2RpVFgvNG9UbTB5SnVHdm5CUk9aSVU5b1ZB?=
 =?utf-8?B?ZDc2ZVNTaVplSGhzVlRZMmxnOXovR053aFNFVVhOVWdnSmREbzZjM1QrUnZM?=
 =?utf-8?B?N215WWYwWnpCQUJ5NkhhQUxvN0s1QW1NeTcrelA4NjJXdFlGTHo1WG5PL2hC?=
 =?utf-8?B?amVjOE1xNmtRSjU3VDMxRzF2ZjZSeXhuZ2wwQ0traEs0czZKdWptTkR5MnJk?=
 =?utf-8?B?aHNQaXBnVm5jNmZtWDcwcU5BazJVSnVDTFZsY3NNM2gwRTVwUW1aZFFyazlZ?=
 =?utf-8?B?Qk1YaU9VVi9zelk2Z3poTjRTaElCUWxNN0lualNPVktrdWk1TnBmalBwUnRu?=
 =?utf-8?B?REphN0tCdmd2eHFIbUhoeTJiZ3crNVh3OHJHcUYzdlNsN0ovNEZkenZtREl1?=
 =?utf-8?B?a1NzZFR4dkVZczF3RkFKbWZXWFJRWmJjY1pScnhhMkNUeVdiQW1qdEtYdXFu?=
 =?utf-8?B?b0EyeElXMDBLR3N4dVVZMWRZbVRTSFE1OUdmWTRmWkFHb250ZkVVZGE2WDAx?=
 =?utf-8?B?MDBJN2F2RW1aS2pPNngwbU1ZTGpZZCtvNnBnV3FFSmRJMlpYMDlwSHhIL0tm?=
 =?utf-8?B?V0Q1SkxYWlQ4cXBxTDlwK1EyWUZiYzB3cGlpaWlqYTZjMDN5MGhlTXIzYitT?=
 =?utf-8?B?UzNhS2E1alBNOEduZzdSeEFrU0JNd2E3b3R6cmFhdzdFT0VSU1p4WndDOEdq?=
 =?utf-8?B?VWZaVzdGUFk0SHQzUjd4WlFwRmswSldpUlZrMElVT00zTktjOWdsSy8wbHV2?=
 =?utf-8?B?U2ZyUDBmMS9MS1Z0VWhqZXoxWjhaSG1yNTFvVFRtbytlQm9hbnJLQXg2YUZr?=
 =?utf-8?Q?Ml73k7y69FGdlZqIRrAuXzwdwjBx2Lrx2CBV5C3?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <B8B3C0C462A77F42B2D9F5BF140AC70D@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 136b3300-56ee-4bfb-ec82-08d9921ee3fb
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Oct 2021 10:06:02.0431
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Ji50GMHrYtM5Ip9nh3vceSUxGBbzPP3zBQmB6e23OLbMJhKxa7mQv+XKSSpRg7DgEKvwvi2P2aQI5xxR106MKKhdR4L5GWC22JMT5FeChS736fI+WxuWDhzwQlzPQuiP
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR0302MB2659
X-Proofpoint-GUID: mvdLd9EYaU3NBweZyVy9Zppo5WwAUb7v
X-Proofpoint-ORIG-GUID: mvdLd9EYaU3NBweZyVy9Zppo5WwAUb7v
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475
 definitions=2021-10-18_03,2021-10-14_02,2020-04-07_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0
 suspectscore=0 mlxscore=0 lowpriorityscore=0 malwarescore=0 clxscore=1015
 phishscore=0 spamscore=0 mlxlogscore=999 bulkscore=0 priorityscore=1501
 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2109230001 definitions=main-2110180063

SGksIEphbiENCg0KT24gMTguMTAuMjEgMTA6NDcsIEphbiBCZXVsaWNoIHdyb3RlOg0KPiBPbiAx
NS4xMC4yMDIxIDE4OjUxLCBCZXJ0cmFuZCBNYXJxdWlzIHdyb3RlOg0KPj4gLS0tIC9kZXYvbnVs
bA0KPj4gKysrIGIveGVuL2FyY2gvYXJtL3ZwY2kuYw0KPj4gQEAgLTAsMCArMSw3NyBAQA0KPj4g
Ky8qDQo+PiArICogeGVuL2FyY2gvYXJtL3ZwY2kuYw0KPj4gKyAqDQo+PiArICogVGhpcyBwcm9n
cmFtIGlzIGZyZWUgc29mdHdhcmU7IHlvdSBjYW4gcmVkaXN0cmlidXRlIGl0IGFuZC9vciBtb2Rp
ZnkNCj4+ICsgKiBpdCB1bmRlciB0aGUgdGVybXMgb2YgdGhlIEdOVSBHZW5lcmFsIFB1YmxpYyBM
aWNlbnNlIGFzIHB1Ymxpc2hlZCBieQ0KPj4gKyAqIHRoZSBGcmVlIFNvZnR3YXJlIEZvdW5kYXRp
b247IGVpdGhlciB2ZXJzaW9uIDIgb2YgdGhlIExpY2Vuc2UsIG9yDQo+PiArICogKGF0IHlvdXIg
b3B0aW9uKSBhbnkgbGF0ZXIgdmVyc2lvbi4NCj4+ICsgKg0KPj4gKyAqIFRoaXMgcHJvZ3JhbSBp
cyBkaXN0cmlidXRlZCBpbiB0aGUgaG9wZSB0aGF0IGl0IHdpbGwgYmUgdXNlZnVsLA0KPj4gKyAq
IGJ1dCBXSVRIT1VUIEFOWSBXQVJSQU5UWTsgd2l0aG91dCBldmVuIHRoZSBpbXBsaWVkIHdhcnJh
bnR5IG9mDQo+PiArICogTUVSQ0hBTlRBQklMSVRZIG9yIEZJVE5FU1MgRk9SIEEgUEFSVElDVUxB
UiBQVVJQT1NFLiAgU2VlIHRoZQ0KPj4gKyAqIEdOVSBHZW5lcmFsIFB1YmxpYyBMaWNlbnNlIGZv
ciBtb3JlIGRldGFpbHMuDQo+PiArICovDQo+PiArI2luY2x1ZGUgPHhlbi9zY2hlZC5oPg0KPj4g
KyNpbmNsdWRlIDx4ZW4vdnBjaS5oPg0KPj4gKw0KPj4gKyNpbmNsdWRlIDxhc20vbW1pby5oPg0K
Pj4gKw0KPj4gK3N0YXRpYyBpbnQgdnBjaV9tbWlvX3JlYWQoc3RydWN0IHZjcHUgKnYsIG1taW9f
aW5mb190ICppbmZvLA0KPj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgcmVnaXN0ZXJfdCAq
ciwgdm9pZCAqcCkNCj4+ICt7DQo+PiArICAgIHBjaV9zYmRmX3Qgc2JkZjsNCj4+ICsgICAgLyog
ZGF0YSBpcyBuZWVkZWQgdG8gcHJldmVudCBhIHBvaW50ZXIgY2FzdCBvbiAzMmJpdCAqLw0KPj4g
KyAgICB1bnNpZ25lZCBsb25nIGRhdGE7DQo+PiArDQo+PiArICAgIC8qIFdlIGlnbm9yZSBzZWdt
ZW50IHBhcnQgYW5kIGFsd2F5cyBoYW5kbGUgc2VnbWVudCAwICovDQo+PiArICAgIHNiZGYuc2Jk
ZiA9IFZQQ0lfRUNBTV9CREYoaW5mby0+Z3BhKTsNCj4+ICsNCj4+ICsgICAgaWYgKCB2cGNpX2Vj
YW1fcmVhZChzYmRmLCBFQ0FNX1JFR19PRkZTRVQoaW5mby0+Z3BhKSwNCj4+ICsgICAgICAgICAg
ICAgICAgICAgICAgICAxVSA8PCBpbmZvLT5kYWJ0LnNpemUsICZkYXRhKSApDQo+PiArICAgIHsN
Cj4gSGVyZSBpdCBpcyBxdWl0ZSBjbGVhciB0aGF0IHRoZSBTQkRGIHlvdSBwYXNzIGludG8gdnBj
aV9lY2FtX3JlYWQoKSBpcw0KPiB0aGUgdmlydHVhbCBvbmUuDQpOb3QgcmVhbGx5IHlldA0KPiAg
IFRoZSBmdW5jdGlvbiB0aGVuIGNhbGxzIHZwY2lfcmVhZCgpLCB3aGljaCBpbiB0dXJuDQo+IHdp
bGwgY2FsbCB2cGNpX3JlYWRfaHcoKSBpbiBhIG51bWJlciBvZiBzaXR1YXRpb25zIChmaXJzdCBh
bmQgZm9yZW1vc3QNCj4gd2hlbmV2ZXIgcGNpX2dldF9wZGV2X2J5X2RvbWFpbigpIHJldHVybnMg
TlVMTCkuIFRoYXQgZnVuY3Rpb24gYXMgd2VsbA0KPiBhcyBwY2lfZ2V0X3BkZXZfYnlfZG9tYWlu
KCkgdXNlIHRoZSBwYXNzZWQgaW4gU0JERiBhcyBpZiBpdCB3YXMgYQ0KPiBwaHlzaWNhbCBvbmU7
IEknbSB1bmFibGUgdG8gc3BvdCBhbnkgdHJhbnNsYXRpb24uIFlldCBJIGRvIHJlY2FsbA0KPiBz
ZWVpbmcgYXNzaWdubWVudCBvZiBhIHZpcnR1YWwgZGV2aWNlIGFuZCBmdW5jdGlvbiBudW1iZXIg
c29tZXdoZXJlDQo+IChwZXJoYXBzIGFub3RoZXIgb2YgdGhlIHJlbGF0ZWQgc2VyaWVzKSwgc28g
dGhlIG1vZGVsIGFsc28gZG9lc24ndA0KPiBsb29rIHRvIGFzc3VtZSAxOjEgbWFwcGluZyBvZiBT
QkRGLg0KPg0KQXQgdGhlIHRpbWUgb2YgdGhpcyBwYXRjaCB3ZSBkbyBub3QgeWV0IGhhdmUgYSB2
aXJ0dWFsIHRvcG9sb2d5DQppbXBsZW1lbnRlZCB3aGljaCBpcyBhZGRlZCBhdCBhIGxhdGVyIHN0
YWdlLg0KU28sIHdoZW4gYSBEb21VIHBlcmZvcm1zIFBDSSBlbnVtZXJhdGlvbiBpdCBzZWVzIGFs
bCB0aGUgcmVhbA0KUENJIEhXIGFuZCB0aHVzIGRpc2NvdmVycyBhbGwgUENJIGRldmljZXMgd2l0
aCB0aGVpciAqcmVhbCBTQkRGcyosDQplLmcuIGp1c3QgbGlrZSB3ZSBwYXNzIHRocm91Z2ggYWxs
IHRoZSB0b3BvbG9neSB0byB0aGUgZ3Vlc3QuDQpTbywgaW4gdGhlIHF1ZXN0aW9uLCBTQkRGcyBh
cmUgcGh5c2ljYWw=


From xen-devel-bounces@lists.xenproject.org Mon Oct 18 10:09:53 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Oct 2021 10:09:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.211932.369622 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcPaZ-0003kN-Vf; Mon, 18 Oct 2021 10:09:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 211932.369622; Mon, 18 Oct 2021 10:09:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcPaZ-0003kG-Sp; Mon, 18 Oct 2021 10:09:51 +0000
Received: by outflank-mailman (input) for mailman id 211932;
 Mon, 18 Oct 2021 10:09:50 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=LiEI=PG=citrix.com=Jane.Malalane@srs-us1.protection.inumbo.net>)
 id 1mcPaY-0003k6-Hj
 for xen-devel@lists.xenproject.org; Mon, 18 Oct 2021 10:09:50 +0000
Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 0d31f0e1-f092-4008-b469-16449d62ce38;
 Mon, 18 Oct 2021 10:09:49 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0d31f0e1-f092-4008-b469-16449d62ce38
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1634551789;
  h=from:to:cc:subject:date:message-id:mime-version;
  bh=YWJg+zDnYt6xqu2Z8qpX70ggtGzngAo5flx3bGFEqa4=;
  b=RAd31PhkezORLwMiTvPkThxdjZ19S0/Y8e8CeEx2kRxxTO6A9G0XX/ca
   yv82cqQ2gmKjzFvboYBtkLFx5j2hAaAHwuGIZSZ7tad1RWpRhskNGx8hk
   yJA9C47opXJ9xUeHJee3K1FB/s2hpFky8BFE5TPUxBPKRSwjmEE7/fe9T
   Y=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: 1YOxloufTNMrsdWlRFOWGjFlI5kMf0sL6+91kVewiwBqlgQTNZBIauyNNvEsyc4f6ZS9xSeYUI
 vIVVlu8IpKRLiiFZJXFipp3UukUp/SNyvHttB4e44XdF1x/61RpQsotwQUyv03XqS2hk6I8Kr6
 2oVbIxXmUEiPvzvWTOLDdm6796lSCx88I+pCaH2wmEzTx59XH354IMaZ1UN1xBWAIdZ514Omb0
 Cf5NnHBY+z8tu4nSQv5XFfscVRvBHWDyybxDOmsqHalpEaLfCGG+YjPtSQLRKh1adaUPVWEuP8
 /3AVJjHGYTn/vH3EnPT7dt07
X-SBRS: 5.1
X-MesageID: 55422929
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:9ciN4a9UQudHN9jqOhImDrUDSXmTJUtcMsCJ2f8bNWPcYEJGY0x3n
 TdLDTqBa6uDYGfweYh2Pdzj9ElX657cn95kHARvqy48E34SpcT7XtnIdU2Y0wF+jyHgoOCLy
 +1EN7Es+ehtFie0Si9AttENlFEkvU2ybuOU5NXsZ2YhGGeIdA970Ug6wrZg0tYx6TSEK1jlV
 e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH
 I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPhb7
 94X6rK6SDwSN7HhqPwASAB3AQ5HaPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us
 6ZCcXZUM07F17neLLGTE4GAguwBJc/meqYWvnhkxDfUJf0nXYrCU+PB4towMDIY250SR6yPP
 ZtxhTxHQh/uWzEXOW8rKNFng8Ol2lbZLjtGkQfAzUYwyzeKl1EguFT3C/LKfvSaSMMTmVyXz
 krH4GbREhwcLMaYyzeO7jSrnOCntTP2XsceGaO18tZugUaP3SoDBRsOT1y5rPKlzEmkVLpix
 1c8o3R06/JorQryE4e7D0bQTGO4UgA0cf1bSbIU4gC28aPIzjaBG3MdYSxuUYlz3CMpfgAC2
 liMltLvIDVgtryJVH6QnoupQSOO1Ts9djBaO3dVJecRy5y6+ttr10OQJjp2OPft1oWdJN3m/
 9ydQMHSbZ0ohskXy77zw1nDhz+9znQiZl9ovluJNo5JAwUQWWJEW2BKwQWDhRqjBNzAJrVkg
 JTis5LPhAzpJcrV/BFhuM1XQNmUCw+taVUwe2JHEZg77CiK8HW+Z41W6zwWDB43aZpYKGK4O
 hOP41I5CHpv0J2CN/4fj2WZUJxC8EQdPY69CqC8giRmM/CdizNrDAkxPBXNjggBYWAnkL0lO
 IfzTCpfJS1yNEiT9xLvH711+eZynkgWnDqPLbimn0XP+efPPxa9FOZaWGZim8hktctoVi2Oq
 I0BXyZLoj0CONDDjt7/qtJKcg1WcCFmXPgbaaV/L4a+H+avI0l5Y9e5/F/rU9UNc319mria8
 3ejdFVfzVaj13TLJR/TMiJoaa/1XIY5pnU+ZHR+MVGt0nklQICu8KZAKMdnIeh5rLRunaxuU
 v0IW8ScGfATGD7JzCsQMMvmp4t4eRX12Q/XZ3i5YCIydoJLThDS/oO2ZRPm8SQDV3LltcY3r
 7C6+BncRJ4PG1ZrAMrMMar9xFKtp3kN3ul1WhKQcNVUfUzt9qlsKjDw0aBrc51dd02by2LDh
 QiMABoeqe3cmKMP8YHE1fKesoOkM+piBU4GTWPV2qm7aHvB9W25zI4eDOvRJWLBVHn58bmJb
 PlOy62uK+UOmVtHvtYuE7tvyq5itdLjq6UDk1ZhFXTPKV+qFqlhMj+N2swW7v9BwbpQuA2XX
 EOT+4YFZeXVaZ29SFNBdhA4aumj1O0PnmiA5Ps4F0z2+Str8efVSk5VJRSN1HRQIbYd3FnJG
 gv9VBr6MzCCtyc=
IronPort-HdrOrdr: A9a23:qoTIvaHcPl4XqMxkpLqE5seALOsnbusQ8zAXPiFKJSC9F/byqy
 nAppsmPHPP5gr5OktBpTnwAsi9qBrnnPYejLX5Vo3SPzUO1lHYSb1K3M/PxCDhBj271sM179
 YFT0GmMqyTMWRH
X-IronPort-AV: E=Sophos;i="5.85,381,1624334400"; 
   d="scan'208";a="55422929"
From: Jane Malalane <jane.malalane@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Jane Malalane <jane.malalane@citrix.com>, Ian Jackson
	<iwj@xenproject.org>, Wei Liu <wl@xen.org>
Subject: [PATCH] tests/resource: Extend to check that the grant frames are mapped correctly
Date: Mon, 18 Oct 2021 11:08:48 +0100
Message-ID: <20211018100848.10612-1-jane.malalane@citrix.com>
X-Mailer: git-send-email 2.11.0
MIME-Version: 1.0
Content-Type: text/plain

Previously, we checked that we could map 40 pages with nothing
complaining. Now we're adding extra logic to check that those 40
frames are "correct".

Suggested-by: Andrew Cooper <andrew.cooper3@citrix.com>
Signed-off-by: Jane Malalane <jane.malalane@citrix.com>
---
CC: Ian Jackson <iwj@xenproject.org>
CC: Wei Liu <wl@xen.org>
---
 tools/tests/resource/Makefile        |  2 +
 tools/tests/resource/test-resource.c | 81 +++++++++++++++++++++++++++++++++---
 2 files changed, 77 insertions(+), 6 deletions(-)

diff --git a/tools/tests/resource/Makefile b/tools/tests/resource/Makefile
index 1c3aee4ff7..b3cd70c06d 100644
--- a/tools/tests/resource/Makefile
+++ b/tools/tests/resource/Makefile
@@ -31,10 +31,12 @@ CFLAGS += -Werror
 CFLAGS += $(CFLAGS_xeninclude)
 CFLAGS += $(CFLAGS_libxenctrl)
 CFLAGS += $(CFLAGS_libxenforeginmemory)
+CFLAGS += $(CFLAGS_libxengnttab)
 CFLAGS += $(APPEND_CFLAGS)
 
 LDFLAGS += $(LDLIBS_libxenctrl)
 LDFLAGS += $(LDLIBS_libxenforeignmemory)
+LDFLAGS += $(LDLIBS_libxengnttab)
 LDFLAGS += $(APPEND_LDFLAGS)
 
 %.o: Makefile
diff --git a/tools/tests/resource/test-resource.c b/tools/tests/resource/test-resource.c
index 1caaa60e62..fa4ca6217f 100644
--- a/tools/tests/resource/test-resource.c
+++ b/tools/tests/resource/test-resource.c
@@ -6,6 +6,7 @@
 
 #include <xenctrl.h>
 #include <xenforeignmemory.h>
+#include <xengnttab.h>
 #include <xen-tools/libs.h>
 
 static unsigned int nr_failures;
@@ -17,13 +18,16 @@ static unsigned int nr_failures;
 
 static xc_interface *xch;
 static xenforeignmemory_handle *fh;
+static xengnttab_handle *gh;
 
-static void test_gnttab(uint32_t domid, unsigned int nr_frames)
+static void test_gnttab(uint32_t domid, unsigned int nr_frames, unsigned long gfn)
 {
     xenforeignmemory_resource_handle *res;
-    void *addr = NULL;
+    grant_entry_v1_t *gnttab;
     size_t size;
     int rc;
+    uint32_t refs[nr_frames], domids[nr_frames];
+    void *grants;
 
     printf("  Test grant table\n");
 
@@ -51,18 +55,52 @@ static void test_gnttab(uint32_t domid, unsigned int nr_frames)
     res = xenforeignmemory_map_resource(
         fh, domid, XENMEM_resource_grant_table,
         XENMEM_resource_grant_table_id_shared, 0, size >> XC_PAGE_SHIFT,
-        &addr, PROT_READ | PROT_WRITE, 0);
+        (void *)&gnttab, PROT_READ | PROT_WRITE, 0);
 
     /*
      * Failure here with E2BIG indicates Xen is missing the bugfix to map
      * resources larger than 32 frames.
      */
     if ( !res )
-        return fail("    Fail: Map %d - %s\n", errno, strerror(errno));
+        return fail("    Fail: Map grant table %d - %s\n", errno, strerror(errno));
 
+    /* Put each gref at a unique offset in its frame. */
+    for ( unsigned int i = 0; i < nr_frames; i++ )
+    {
+        unsigned int gref = i * (XC_PAGE_SIZE / sizeof(*gnttab)) + i;
+
+        refs[i] = gref;
+        domids[i] = domid;
+
+        gnttab[gref].domid = 0;
+        gnttab[gref].frame = gfn;
+        gnttab[gref].flags = GTF_permit_access;
+    }
+
+    /* Map grants. */
+    grants = xengnttab_map_grant_refs(gh, nr_frames, domids, refs, PROT_READ | PROT_WRITE);
+
+    /* Failure here indicates either that the frames were not mapped
+     * in the correct order or xenforeignmemory_map_resource() didn't
+     * give us the frames we asked for to begin with.
+     */
+    if ( grants == NULL )
+    {
+        fail("    Fail: Map grants %d - %s\n", errno, strerror(errno));
+        goto out;
+    }
+
+    /* Unmap grants. */
+    rc = xengnttab_unmap(gh, grants, nr_frames);
+
+    if ( rc )
+        fail("    Fail: Unmap grants %d - %s\n", errno, strerror(errno));
+
+    /* Unmap grant table. */
+ out:
     rc = xenforeignmemory_unmap_resource(fh, res);
     if ( rc )
-        return fail("    Fail: Unmap %d - %s\n", errno, strerror(errno));
+        return fail("    Fail: Unmap grant table %d - %s\n", errno, strerror(errno));
 }
 
 static void test_domain_configurations(void)
@@ -107,6 +145,7 @@ static void test_domain_configurations(void)
         struct test *t = &tests[i];
         uint32_t domid = 0;
         int rc;
+        xen_pfn_t ram[1] = { 0 };
 
         printf("Test %s\n", t->name);
 
@@ -123,8 +162,25 @@ static void test_domain_configurations(void)
 
         printf("  Created d%u\n", domid);
 
-        test_gnttab(domid, t->create.max_grant_frames);
+        rc = xc_domain_setmaxmem(xch, domid, -1);
+        if ( rc )
+        {
+            fail("  Failed to set max memory for domain: %d - %s\n",
+                 errno, strerror(errno));
+            goto test_done;
+        }
+
+        rc = xc_domain_populate_physmap_exact(xch, domid, ARRAY_SIZE(ram), 0, 0, ram);
+        if ( rc )
+        {
+            fail("  Failed to populate physmap domain: %d - %s\n",
+                 errno, strerror(errno));
+            goto test_done;
+        }
+
+        test_gnttab(domid, t->create.max_grant_frames, ram[0]);
 
+    test_done:
         rc = xc_domain_destroy(xch, domid);
         if ( rc )
             fail("  Failed to destroy domain: %d - %s\n",
@@ -138,13 +194,26 @@ int main(int argc, char **argv)
 
     xch = xc_interface_open(NULL, NULL, 0);
     fh = xenforeignmemory_open(NULL, 0);
+    gh = xengnttab_open(NULL, 0);
 
     if ( !xch )
         err(1, "xc_interface_open");
     if ( !fh )
         err(1, "xenforeignmemory_open");
+    if ( !gh )
+        err(1, "xengnttab_open");
 
     test_domain_configurations();
 
     return !!nr_failures;
 }
+
+/*
+ * Local variables:
+ * mode: C
+ * c-file-style: "BSD"
+ * c-basic-offset: 4
+ * tab-width: 4
+ * indent-tabs-mode: nil
+ * End:
+ */
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Mon Oct 18 10:12:10 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Oct 2021 10:12:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.211939.369634 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcPck-00056n-Cc; Mon, 18 Oct 2021 10:12:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 211939.369634; Mon, 18 Oct 2021 10:12:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcPck-00056g-9E; Mon, 18 Oct 2021 10:12:06 +0000
Received: by outflank-mailman (input) for mailman id 211939;
 Mon, 18 Oct 2021 10:12:04 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=J+Bz=PG=arm.com=Bertrand.Marquis@srs-us1.protection.inumbo.net>)
 id 1mcPci-00056Y-NT
 for xen-devel@lists.xenproject.org; Mon, 18 Oct 2021 10:12:04 +0000
Received: from EUR02-VE1-obe.outbound.protection.outlook.com (unknown
 [40.107.2.78]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 2a57b5db-03e4-41ef-9ee0-923736e4d26d;
 Mon, 18 Oct 2021 10:12:02 +0000 (UTC)
Received: from AS9PR0301CA0040.eurprd03.prod.outlook.com
 (2603:10a6:20b:469::26) by AM8PR08MB6562.eurprd08.prod.outlook.com
 (2603:10a6:20b:355::17) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16; Mon, 18 Oct
 2021 10:11:59 +0000
Received: from AM5EUR03FT007.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:469:cafe::36) by AS9PR0301CA0040.outlook.office365.com
 (2603:10a6:20b:469::26) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.14 via Frontend
 Transport; Mon, 18 Oct 2021 10:11:59 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM5EUR03FT007.mail.protection.outlook.com (10.152.16.145) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.15 via Frontend Transport; Mon, 18 Oct 2021 10:11:59 +0000
Received: ("Tessian outbound f1898412aff1:v103");
 Mon, 18 Oct 2021 10:11:59 +0000
Received: from 78425616ff20.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 8641D81B-8312-46D6-B525-9273C9EA7A63.1; 
 Mon, 18 Oct 2021 10:11:48 +0000
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 78425616ff20.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Mon, 18 Oct 2021 10:11:48 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com (2603:10a6:4:74::9)
 by DB7PR08MB4604.eurprd08.prod.outlook.com (2603:10a6:10:34::29) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15; Mon, 18 Oct
 2021 10:11:44 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955]) by DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955%4]) with mapi id 15.20.4608.018; Mon, 18 Oct 2021
 10:11:44 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2a57b5db-03e4-41ef-9ee0-923736e4d26d
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=C7LgqLdTNDEDiVDBQehlXhP6YASeoTWOaWwPp34w2Ls=;
 b=WXefGkkz31y21dJynhvEsOXJkyWzR5CSSrFEgTur4wzUv1mFPY7j4Om5QR3Sh1zT8sIPcmbQc1qAKwRAO3JGX9KPNPdWYKg/hMjgwyjj3AeX8BLZSCfO+rt6LTWyCSsw8US+iKMTZDun5u0S/9KmMngWn9eVkLTQXZ3KUGeg/xw=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: b49b5daeddc9e32c
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=kAptvQcsXVIIaz4JLbk8pCvuNcqUcZ2Dp4DrsILIPn5ilKa71IWBpl2CdBX/NoPbu4aEr8Q3wQRalgn5yzLmLsFqAikgRNB/WU8spvpcoPJ36RNLhrCmzntQywhN/zA2Y1a5TXwyR56fYwyrGPdTgKD8lc4gQUBDST2MyMVwmz7mf6rYMvIT18WznKJzo9WzF7soEjxv2Ans4Vi43XdIKxe3EP1KHHn61RzcvHz1aYwh9sFAGhEf7+A38YLr2+2VcWS64eSnK7/CqDFoDhe4bYnTQPZfoe6oQ6LNQjdo9Z2qgq55X/BAy98uVQ9J6rF/6UtkTkAW2/aix83NDuShWQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=C7LgqLdTNDEDiVDBQehlXhP6YASeoTWOaWwPp34w2Ls=;
 b=bp7k1sO+uUWs06hfIuoSIQmg1+E/Gou1HrDL0POiAPMky+0hYov2JVBo3MmwZIny46WBu6YiHUVjRRZqILwu/r8ujpu03hyXYzjjfL+FG0ZtDjXmxpf7HoqtVVTG9hp+XJTfhblVKCS7/wEhriXOAJRxCADYX7P6lXkeN3F28M/QGvvDdnXju339x+mLRXBbFyLWquBEcJKluMMg4kcxah1CZP+thtteMcVBu0MjlEmLo0iknGt5kWMQs3+N0rYTg6mTRVkuYGZ0Za8lacoG6sUFVPIDncGMcAwdYDyHQzcvDZmqJn20aXU8gN4oqxFIrlWwyHywh4PNDnu2kWaXfA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=C7LgqLdTNDEDiVDBQehlXhP6YASeoTWOaWwPp34w2Ls=;
 b=WXefGkkz31y21dJynhvEsOXJkyWzR5CSSrFEgTur4wzUv1mFPY7j4Om5QR3Sh1zT8sIPcmbQc1qAKwRAO3JGX9KPNPdWYKg/hMjgwyjj3AeX8BLZSCfO+rt6LTWyCSsw8US+iKMTZDun5u0S/9KmMngWn9eVkLTQXZ3KUGeg/xw=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Rahul Singh <Rahul.Singh@arm.com>, =?iso-8859-1?Q?Roger_Pau_Monn=E9?=
	<roger.pau@citrix.com>, "iwj@xenproject.org" <iwj@xenproject.org>,
	"sstabellini@kernel.org" <sstabellini@kernel.org>, Julien Grall
	<julien@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, Andrew
 Cooper <andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>,
	Wei Liu <wl@xen.org>, Paul Durrant <paul@xen.org>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v8 2/5] xen/arm: Enable the existing x86 virtual PCI
 support for ARM
Thread-Topic: [PATCH v8 2/5] xen/arm: Enable the existing x86 virtual PCI
 support for ARM
Thread-Index: AQHXweULx+Lzp09rU0elFmx0jxVt5qvYZOcAgAAoaQA=
Date: Mon, 18 Oct 2021 10:11:44 +0000
Message-ID: <FBC4FA6D-AF07-437A-BD81-52708B139070@arm.com>
References: <cover.1634315461.git.bertrand.marquis@arm.com>
 <e2b10f56043155e4bb8eae824723045ccc042f8e.1634315461.git.bertrand.marquis@arm.com>
 <ca5558b2-25c6-90d2-284b-03cbbb02691f@suse.com>
In-Reply-To: <ca5558b2-25c6-90d2-284b-03cbbb02691f@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3654.120.0.1.13)
Authentication-Results-Original: suse.com; dkim=none (message not signed)
 header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: d9ddf5d6-9988-4960-ef2b-08d9921fb932
x-ms-traffictypediagnostic: DB7PR08MB4604:|AM8PR08MB6562:
x-ms-exchange-transport-forked: True
X-Microsoft-Antispam-PRVS:
	<AM8PR08MB65622918F2E2484E3C6CDBBB9DBC9@AM8PR08MB6562.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:10000;OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 /Y0zFDS/K6cTyN6LnQeIxqRecqwC/hFVMxt3uxu3hyBjqvzQ7jyo1XMjJd5RcP5/+DtH4J0DXDKKO7LsijWqUTIIAWadUVksNZmngiHjlVyLDAa56sGcxPhPG3AFcf1SF84iTPKQ6aM2CesoEqzyH9g/nvWAi3vgHPDmCCzfUbtATH5UvvAhRV6iiXdP92tVjbwj+qWrxAr03hbcVEfIgacSXdeCPREOgXV3bfe3xKel8PQHS8QXq3l3v63P4xvBBVvki4iSxUe+xfgJ6THevv86MBQKXKvwSYVjLkbTSedinM9exd0AWpMu7PXZrEoWObFPKoFtZR6lSLng9UaXJdHu4cSAE0IlbhWxlnSrAzbJLZCqE9U2ZtkBaGEqlFjFG/zSgp8RVk9+KpjvyKRH2psMsqQrb9DWo2CSKwjceBJhO9xBNehAWBX4A1GZOUmI/3QcfPXUzbDmTmFMy1v+GPJNBoozxBdr5CJihlNczJMR2mheIYOvYSi49stbw5dg7P85SC9vNyWiWojOTwDnoilbILoM32Q02fUFJKQyaFgey8p3EsooYqKP7I5cx2hrKhy6S+3B9ty2r7gdq+0XAh3d6MZpzzCdVe7N/740ePBqbavQhwqgJfvgQYiqCD+JtjBF/TPBEUlyW0qvoEKkNxtxTnQdjys8s+n08mjVn12ktatmV1LCTWa6nI5T0aZ24MMBTI11ocTEAnDz6rZPEJQIlwDgCpZGyxQQ0m+XkP9k6wKYcbsAzyeAx3hguRQ+Bb7MtEsn9qTyRURttbUkPA==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB6PR0801MB2024.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(33656002)(38100700002)(122000001)(316002)(4326008)(6506007)(38070700005)(66946007)(66476007)(6916009)(53546011)(7416002)(26005)(83380400001)(36756003)(2906002)(64756008)(76116006)(91956017)(186003)(508600001)(5660300002)(8676002)(2616005)(66556008)(66446008)(71200400001)(6486002)(6512007)(86362001)(54906003)(8936002)(2004002)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="iso-8859-1"
Content-ID: <E72AE75A5CE81147AF279F12B82DE16B@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB4604
Original-Authentication-Results: suse.com; dkim=none (message not signed)
 header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM5EUR03FT007.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	eb21536e-d583-42ed-88a8-08d9921fb030
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	iucLUbjV4Wx5IkWR50fDFccnJmfSmDv9aqTItWLUAvz9eAMMb74zPROlzNZekTbAFSVPxvz+mu8R6QvExpbkRA+v8EWfXyn3B7zHLZLzXfC0HenIcxfSrdTo2cKxoaXzsHHSeVMCv+ybf1LDvnNRV/Gti1hAdByNL84/AQbB+XQhoawVCP/BOcIc5+VyOgZX28r2tvktsruOVXRbbi8zpLa/bJEZFO1UdyEu01Wb0opUbwULvtCDTvWyBcOxFAhhOzQ0mP7BTeND8lMwgvRbES4+FkSVpk0hX9tF+YnaM69bQnE35JmdQ+vYww3Ofcy5NYC9gp3JvuNpJNbkDhmNvghcdwcAnZW7a54JYZEPMfInNYJNTqMkF5b+wBapScg06QcU7NpQt6JjvtlEAOrt3pyIQxQTv0H2CySFwR9s/1RQllY6ej5huT7KbcI7zAO5/CdyaNEJNE6SligvSOmj3VBhHO5XgwF7QYsnKkUTyB+u/c2U3I+HQ1uvwKIyJ0iHNTOkMRsXsxIpSRiIdKZ8dR9FPDzkrf7Qak4ZP0C4iK9sLTB8ey0BX0wiyrb9mpa3YDvGTV3r3OmulxJ3Pz086RllyJYQqAVOCEHZgwnKmrGeLR9AHDUgz7eqFgqiwK69AfV6eBexv9ucNVWzIfjLyv6orENezacmJjM+0MmnCgbM/3G4eipZuWcUKyunPOBxo800nUlYIZRQ8WFoLFcZxiu+ycy+XzeyVyR+1drxYjQ=
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(8936002)(6512007)(82310400003)(5660300002)(6486002)(2906002)(36756003)(356005)(26005)(81166007)(53546011)(186003)(6506007)(70206006)(83380400001)(36860700001)(8676002)(6862004)(508600001)(316002)(86362001)(47076005)(336012)(2616005)(33656002)(4326008)(70586007)(54906003)(2004002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2021 10:11:59.7790
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: d9ddf5d6-9988-4960-ef2b-08d9921fb932
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM5EUR03FT007.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB6562

Hi Jan,

> On 18 Oct 2021, at 08:47, Jan Beulich <jbeulich@suse.com> wrote:
>=20
> On 15.10.2021 18:51, Bertrand Marquis wrote:
>> --- /dev/null
>> +++ b/xen/arch/arm/vpci.c
>> @@ -0,0 +1,77 @@
>> +/*
>> + * xen/arch/arm/vpci.c
>> + *
>> + * This program is free software; you can redistribute it and/or modify
>> + * it under the terms of the GNU General Public License as published by
>> + * the Free Software Foundation; either version 2 of the License, or
>> + * (at your option) any later version.
>> + *
>> + * This program is distributed in the hope that it will be useful,
>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>> + * GNU General Public License for more details.
>> + */
>> +#include <xen/sched.h>
>> +#include <xen/vpci.h>
>> +
>> +#include <asm/mmio.h>
>> +
>> +static int vpci_mmio_read(struct vcpu *v, mmio_info_t *info,
>> +                          register_t *r, void *p)
>> +{
>> +    pci_sbdf_t sbdf;
>> +    /* data is needed to prevent a pointer cast on 32bit */
>> +    unsigned long data;
>> +
>> +    /* We ignore segment part and always handle segment 0 */
>> +    sbdf.sbdf =3D VPCI_ECAM_BDF(info->gpa);
>> +
>> +    if ( vpci_ecam_read(sbdf, ECAM_REG_OFFSET(info->gpa),
>> +                        1U << info->dabt.size, &data) )
>> +    {
>=20
> Here it is quite clear that the SBDF you pass into vpci_ecam_read() is
> the virtual one. The function then calls vpci_read(), which in turn
> will call vpci_read_hw() in a number of situations (first and foremost
> whenever pci_get_pdev_by_domain() returns NULL). That function as well
> as pci_get_pdev_by_domain() use the passed in SBDF as if it was a
> physical one; I'm unable to spot any translation. Yet I do recall
> seeing assignment of a virtual device and function number somewhere
> (perhaps another of the related series), so the model also doesn't
> look to assume 1:1 mapping of SBDF.

This question was answered by Oleksandr I think.

>=20
>> --- a/xen/drivers/passthrough/pci.c
>> +++ b/xen/drivers/passthrough/pci.c
>> @@ -756,6 +756,19 @@ int pci_add_device(u16 seg, u8 bus, u8 devfn,
>>     if ( !pdev->domain )
>>     {
>>         pdev->domain =3D hardware_domain;
>> +#ifdef CONFIG_ARM
>> +        /*
>> +         * On ARM PCI devices discovery will be done by Dom0. Add vpci =
handler
>> +         * when Dom0 inform XEN to add the PCI devices in XEN.
>> +         */
>> +        ret =3D vpci_add_handlers(pdev);
>> +        if ( ret )
>> +        {
>> +            printk(XENLOG_ERR "Setup of vPCI failed: %d\n", ret);
>> +            pdev->domain =3D NULL;
>> +            goto out;
>> +        }
>> +#endif
>>         ret =3D iommu_add_device(pdev);
>>         if ( ret )
>>         {
>=20
> Upon failure, vpci_add_handlers() will itself call vpci_remove_handlers()=
.
> What about iommu_add_device() failure? The device will have ->domain
> zapped, but all vPCI handlers still in place. This aspect of insufficient
> error cleanup was pointed out already in review of v1.

Yes a call to vpci_remove_device should be made on the error path out if
iommu_add_device is failing. This should also be done in fact in=20
pci_remove_device before cleanup the msi.
We will push a patch with a proposal for a fix for this.

>=20
> Furthermore already in v1 I questioned why this would be Arm-specific: On
> x86 this code path is going to be taken for all devices Xen wasn't able
> to discover at boot (anything on segments we wouldn't consider config
> space access safe on without reassurance by Dom0 plus SR-IOV VFs, at the
> very least). Hence it is my understanding that something along these
> lines is actually also needed for PVH Dom0. I've just checked, and
> according to my mailbox that comment was actually left unresponded to.
>=20
> Roger, am I missing anything here as to PVH Dom0 getting handlers put in
> place?

>From Roger answer I understood that it will be needed (in the future).=20
When and if this is needed, the ifdef CONFIG_ARM can be removed
but this would change x86 code behaviour so I do not think it would
have been right to do that in this serie.

>=20
> Of course as soon as the CONFIG_ARM conditionals were dropped, the
> __hwdom_init issue would become an "active" one.

We will push a proposal for a fix for that.
If I understand Roger right, vpci_add_handler will also be needed in runtim=
e
on x86 in the future so maybe it would even be right to remove the flag alt=
ogether ?

Regards
Bertrand

>=20
> Jan
>=20



From xen-devel-bounces@lists.xenproject.org Mon Oct 18 10:18:27 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Oct 2021 10:18:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.211948.369645 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcPip-0005t6-2G; Mon, 18 Oct 2021 10:18:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 211948.369645; Mon, 18 Oct 2021 10:18:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcPio-0005sz-Ut; Mon, 18 Oct 2021 10:18:22 +0000
Received: by outflank-mailman (input) for mailman id 211948;
 Mon, 18 Oct 2021 10:18:21 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=628V=PG=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mcPin-0005st-Tj
 for xen-devel@lists.xenproject.org; Mon, 18 Oct 2021 10:18:21 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 3ddcc9b5-bd0b-4aab-93b8-efadd696cbb4;
 Mon, 18 Oct 2021 10:18:20 +0000 (UTC)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2057.outbound.protection.outlook.com [104.47.12.57]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-22-2yzOZs4UNrK_8a9lTIf0Gg-1; Mon, 18 Oct 2021 12:18:19 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB6301.eurprd04.prod.outlook.com (2603:10a6:803:f1::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.18; Mon, 18 Oct
 2021 10:18:17 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.018; Mon, 18 Oct 2021
 10:18:17 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 FR0P281CA0078.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1e::17) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4628.10 via Frontend Transport; Mon, 18 Oct 2021 10:18:17 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3ddcc9b5-bd0b-4aab-93b8-efadd696cbb4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634552299;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=zxtQAX819G1D8ae8PYpvuBt4sY416LeEYZYLW+TtmXM=;
	b=E9JJHEN6+Jnrdbtx6rLoNgnf9TAlOSyrJgBbAnyXiUlBU6GKLdBjZ2oZBUkgZwdZfpkXYW
	/ysQEEnmPXCswuvsuMCcf8GQvtcgfiIMwaVd9h1zxODk2iH5QUlnaBFkzDMsUK8l0JBR5f
	Gn5TVvaoNVIr+0atCtza6NldRZkrRYw=
X-MC-Unique: 2yzOZs4UNrK_8a9lTIf0Gg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=IU5sNb/K23oAIPB4nhm+OzqiOB4fKlvyAbebXnw4Bb1sQOjjSmuNSkli5ZNjyoB8HnCLi1Ml0BafxqxDBCfuUv/23by+w+DyhhFbydvSEzvvsMkO+xaXc/NHqvvgibIfgQAbUm2NedMWGUGD5CAMNNZd/f90sQ62lRKl9+ODq6KrP5IAyL3W5434Y+GUgvtPPQ9ymHwBRX/c/wq5OZvS7JbDJMlmsgJNKZCK34AHAIbW9TMu5NWUX8p8M7nPXFXng8RF1XA/ALJoBLnrqNfckCuu9T/QdULxcRbFLaPyPOphlIwWA2fAJGzYDumrpbpG3Rmagf1YZxBwoYwv9Wv92g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=u6LTlBc0e5UBgET8ydGAKpIk5JvRbtdu72PHc+hjqpo=;
 b=lZITTVj8APfLKqgTCvCEzWLnAFUgEV4iGtOnNy+te9xvOVTKHGNvHKqvaFoy+1GjBRa+Axk9y3sNrXsHhZZ7ckirXcL3oGei7Mi2S/AOoKmDOR1QQ1zCWg/LTJ98vkzFdOuXmycpsuuy2UE/AWPpAH8SFcde7DkuZ5E376K+3k73B+So5JKdaw1OOC0r3e8ReNeEvEDPEg2IVrLPy1VzfFPf8mkJxpp/Qoha6YkDrfsMNX8X+tTXlgvMa6cjKNf+sANrnxsz+C0a7age/CLHogHYsVxjy3aekSVfFGA0uZYxhl+pqqxGAkwe4GQRrTXEFFn83LRbR1BIi0cUg+MMyw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: xen.org; dkim=none (message not signed)
 header.d=none;xen.org; dmarc=none action=none header.from=suse.com;
Subject: Re: [PATCH v2] x86/AMD: make HT range dynamic for Fam17 and up
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Wei Liu <wl@xen.org>
References: <36df1141-5c3b-6f8a-3a83-1f954b1e27a6@suse.com>
 <YW1BPPVNAVm6EPQp@MacBook-Air-de-Roger.local>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <3f08e2bb-d80a-3336-d379-a9d76a689586@suse.com>
Date: Mon, 18 Oct 2021 12:18:16 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <YW1BPPVNAVm6EPQp@MacBook-Air-de-Roger.local>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: FR0P281CA0078.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:1e::17) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 17ab434f-6289-4eb6-77cd-08d992209a4a
X-MS-TrafficTypeDiagnostic: VI1PR04MB6301:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB63015A4973ED1FED064ED427B3BC9@VI1PR04MB6301.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	J0qm1FSr4qmlgzd1hfnj/rN31D8ut/h8vEIRKkKtDghJ+XXf5/TxvLtXM78xR5FvOUTFpDsAFtg+aBJecVZtNrJWt1AQGagEeBUes/gumKHDmv6+LljcnEvk/iAupQNmGXahGJccEXTlgLQG9XJr7L04oSjDGwV9+Y4yDq4pXLYDe7LJqMEP7ecXy+he2qpwZSNAJG/6xICYiYOhXgce1QUGPFAu1lyD0QJFkM3r3bN6kkTtHr39Mvcm6awDmLBRREE91Z/aQ7B2zvZGm3XYmdbxwxwUJw/V2lGetGk0dCm1USub8TJZJv4axpybI3/kSm86MMA5V3h0fYhyLekn/zmkX8CRVG0xEROTzDIoyJFku4bXREeTo3VudHb/0PLyUoyoxl0fKNT7sJS6wm/WdoWxAh03gpbWpenoHbpIWJp6V1n0FcuabWXTpfu7uVf/uqCyGOkVjEStjfBD05lQmUBjTSoAvZHWjdsWOJVcnQzEyfa/Kj45UA7zg3gJ9sJv146NYmfOUBVXa/zIzFc7pfYiEkFNSZv+H5Gsy1INHgra+0lfxbUof0QJOLn2fgZotm7GabJcxOYvIS2+5d6oHW3q2hrk4redh1tGus1ufhJF4gVXXwywiMFenmBYew/+6GbxDOvyzocmQe28K46/oVUL6ANSTvom76KlmgyAoSmxKiI30GcsI7oz2RYqjfiCY+S3hpiu9PAsA0SjAOfrz8k/s/bJZhR7P7A/ZC8T8xQX0sTr+4JBPgMpOCVDazbP
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(38100700002)(86362001)(31696002)(5660300002)(66476007)(26005)(53546011)(508600001)(31686004)(956004)(186003)(66556008)(8676002)(66946007)(316002)(2616005)(83380400001)(8936002)(6486002)(2906002)(110136005)(36756003)(4326008)(16576012)(54906003)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?9sDshtZMJT7LHA8/+3PVnBNZ1WrkdpRbROdx+AXSqFScVqz+Yp7YO0A8ai+2?=
 =?us-ascii?Q?VgjeJGwZfDto1s37iBD18a47AJbs0wDeOcWTE8qzD2KdszQATPDwZ74hrAid?=
 =?us-ascii?Q?YOYvU/JpT4bqxFCb5CALWy4NKJ7tmck5LgqQF2rGC3uN+EV3QjGDODYRsxaZ?=
 =?us-ascii?Q?v8RQ9fGjHKSW6shxFXhdqfWtA8CIeGHI/ML4MCFb02HISMLDHuE8UoVuAdA7?=
 =?us-ascii?Q?3jnh9piTKb5B5lvYtF/we1+EIPRRGVc0p3NUpkIDdmb9mtesSpgoSRZfabBa?=
 =?us-ascii?Q?zj1kVsTQkTZfegLzYcHc3eSg011wItWFQs6rHTMb08hz3PFmZje2mbtGDSfz?=
 =?us-ascii?Q?9HBOWLqX2tpjJ9nXWUQ3taL5p9x3n6lDHNvRturtvuCncrDpRzEQD7GgbOAJ?=
 =?us-ascii?Q?+FawHExZCVw4ozEKiYCa4TlgIHlTrD6sytReCQf6IbrPacnDk1Ad9s+WIg4s?=
 =?us-ascii?Q?Mvxl6yKeL/QbjZk7VNHd89DEIQrUVezPxo1whtwU2ehawPp6aqS2xfqvhGiG?=
 =?us-ascii?Q?6RHxfuyQdDXXJf7xsUApTi44lwvKKvREyjwSi4h7j1G8CgzBJYkJ6JWLPfmL?=
 =?us-ascii?Q?4RdWNCoD3zMp/GKgaQY1aUZdRN3+KC7G4lJzp3kelWCdYtVACTfmaP4vjIH/?=
 =?us-ascii?Q?n4IIAJoBAIqsrXbTjwLuIa+RGMdFw0/+1ZtwX9tXAQ5HrrVp3VXFkhWB0/5p?=
 =?us-ascii?Q?AK5I2VeDZbgf1pBpIfks737ACmxcI6BSCCbUD6FVQftC0xfCu/K/e55s145Y?=
 =?us-ascii?Q?YAQOhdBOMBvVF4dG78BN6FwMr46QqsWlANplRmR4hefsQeZT4uFd3WAru7kV?=
 =?us-ascii?Q?pc+NmHEvyaOYHz/m/dsL5BtMrO8ORDOHahLM06i64dbNL9j27KzTOChtsqJg?=
 =?us-ascii?Q?3zMBpB8CSuGM5q70bSkOImsXR+zUeVosl18VZLSe7Mii5ZkhrfcrZSdxDbcL?=
 =?us-ascii?Q?Va9q8okL6qhVM1o8NB/T4/SdItzz8pwvs0XH7bh3ATN2R7/Y/NUq2KNSli2h?=
 =?us-ascii?Q?Du+oq1i8PE+clioJskBfZKwGXwedBHhSWcEI8izdnErjSmzGsUuB3DVfN9sn?=
 =?us-ascii?Q?vQhNZ29GS6/Zwgud5idnTvGJUnpPvfX/TU94qdbzY62at0BngsygZRlvx/Uh?=
 =?us-ascii?Q?E2kN3ncl+R77L9p2mNNhMr8sRifnDfHskTyxUkOjx5YN0IhypycdO9QHJwyi?=
 =?us-ascii?Q?x+CW/xIeA/pIWIpgKoO88fuYlVmrbhFAgrxV1YAQHKGllbPANFJFFpVpaOOl?=
 =?us-ascii?Q?EqSmIL/wW12LX3lpmSh9TnVfBZtrGDPYid5cAKCXvJtIT0pYBTEXnSylmMTh?=
 =?us-ascii?Q?zJ5NSFJ5eFNW+plbv95bdMbt?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 17ab434f-6289-4eb6-77cd-08d992209a4a
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2021 10:18:17.5855
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /MSXEg+isD8Lh2zAZ2cMCMoESOOTAzaW5KGdm+iT5b9ytR/ZTn07Iis+3KPFHYHx8RsF/b1GI6/zIixRyOWUEw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6301

On 18.10.2021 11:41, Roger Pau Monn=C3=A9 wrote:
> On Mon, Jun 28, 2021 at 01:48:53PM +0200, Jan Beulich wrote:
>> At the time of d838ac2539cf ("x86: don't allow Dom0 access to the HT
>> address range") documentation correctly stated that the range was
>> completely fixed. For Fam17 and newer, it lives at the top of physical
>> address space, though.
>>
>> To correctly determine the top of physical address space, we need to
>> account for their physical address reduction, hence the calculation of
>> paddr_bits also gets adjusted.
>>
>> While for paddr_bits < 40 the HT range is completely hidden, there's no
>> need to suppress the range insertion in that case: It'll just have no
>> real meaning.
>>
>> Reported-by: Igor Druzhinin <igor.druzhinin@citrix.com>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>=20
> Reviewed-by: Roger Pau Monn=C3=A9 <roger.pau@citrix.com>

Thanks, but before applying this I'd prefer to resolve your concern
voiced below.

>> --- a/xen/arch/x86/cpu/common.c
>> +++ b/xen/arch/x86/cpu/common.c
>> @@ -349,16 +349,23 @@ void __init early_cpu_init(void)
>> =20
>>  	eax =3D cpuid_eax(0x80000000);
>>  	if ((eax >> 16) =3D=3D 0x8000 && eax >=3D 0x80000008) {
>> +		ebx =3D eax >=3D 0x8000001f ? cpuid_ebx(0x8000001f) : 0;
>>  		eax =3D cpuid_eax(0x80000008);
>> +
>>  		paddr_bits =3D eax & 0xff;
>>  		if (paddr_bits > PADDR_BITS)
>>  			paddr_bits =3D PADDR_BITS;
>> +
>>  		vaddr_bits =3D (eax >> 8) & 0xff;
>>  		if (vaddr_bits > VADDR_BITS)
>>  			vaddr_bits =3D VADDR_BITS;
>> +
>>  		hap_paddr_bits =3D ((eax >> 16) & 0xff) ?: paddr_bits;
>>  		if (hap_paddr_bits > PADDR_BITS)
>>  			hap_paddr_bits =3D PADDR_BITS;
>> +
>> +		/* Account for SME's physical address space reduction. */
>> +		paddr_bits -=3D (ebx >> 6) & 0x3f;
>=20
> Does it make sense to check for 0x8000001f[eax] bit 0 in order to
> assert that there's support for SME, or assuming that the reduction is
> !=3D 0 in the other cpuid leaf is enough.

Documentation doesn't really tie them together afaics, so I thought
I wouldn't either. I was reading into this lack of an explicit
connection the possibility of address space reduction to also,
hypothetically at this point, apply to other features.

> It's possible for firmware vendors to disable advertising the SME
> support bit and leave the physical address space reduction one in
> place?

I don't know if it's possible (I'm unaware of e.g. MSR-level control
allowing to modify these independently), but if it is I'd consider
it inconsistent if one but not the other was zapped. I'm unconvinced
that we really would need to deal with such inconsistencies, the
more that it's not really clear what the inconsistent setting would
really mean for the placement of the HT range.

While writing this, there was one more thing I came to think of:
Should we perhaps suppress the iomem_deny_access() altogether when
running virtualized ourselves?

Jan



From xen-devel-bounces@lists.xenproject.org Mon Oct 18 10:25:19 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Oct 2021 10:25:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.211957.369656 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcPpQ-0007JD-LH; Mon, 18 Oct 2021 10:25:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 211957.369656; Mon, 18 Oct 2021 10:25:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcPpQ-0007J6-Hx; Mon, 18 Oct 2021 10:25:12 +0000
Received: by outflank-mailman (input) for mailman id 211957;
 Mon, 18 Oct 2021 10:25:10 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mcPpO-0007Iw-PA; Mon, 18 Oct 2021 10:25:10 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mcPpO-0002T6-Il; Mon, 18 Oct 2021 10:25:10 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mcPpO-00074m-5V; Mon, 18 Oct 2021 10:25:10 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mcPpO-0000i3-4y; Mon, 18 Oct 2021 10:25:10 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=LpUjXpjJaFSJBDthe2OSkMmeB0qj4ptdFla91t6i0iI=; b=1h7thykMEea7pM7/hVvFuZpKfY
	UOgLsKt6E6CeuEzCsOqKXSHXNkAQ3OutTJ6x5Zg4yTeDJ0BKcF4kajYMjmRhhGiG6L7vLh8Zn8ZHK
	HYx+kFdCZyzbCj0KycQFOXUoAtfoJvcAQRKoko9S+Pcxf2tyn/vzraxLA+keFXYu6O3w=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165633-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 165633: regressions - FAIL
X-Osstest-Failures:
    libvirt:build-armhf-libvirt:libvirt-build:fail:regression
    libvirt:build-amd64-libvirt:libvirt-build:fail:regression
    libvirt:build-arm64-libvirt:libvirt-build:fail:regression
    libvirt:build-i386-libvirt:libvirt-build:fail:regression
    libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    libvirt=2703b0b5bf2751d523a4d8d61901e473c92ba198
X-Osstest-Versions-That:
    libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 18 Oct 2021 10:25:10 +0000

flight 165633 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165633/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-armhf-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-amd64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-arm64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-i386-libvirt            6 libvirt-build            fail REGR. vs. 151777

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-libvirt-vhd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a

version targeted for testing:
 libvirt              2703b0b5bf2751d523a4d8d61901e473c92ba198
baseline version:
 libvirt              2c846fa6bcc11929c9fb857a22430fb9945654ad

Last test of basis   151777  2020-07-10 04:19:19 Z  465 days
Failing since        151818  2020-07-11 04:18:52 Z  464 days  450 attempts
Testing same since   165533  2021-10-16 04:21:23 Z    2 days    3 attempts

------------------------------------------------------------
People who touched revisions under test:
    Adolfo Jayme Barrientos <fitoschido@gmail.com>
  Aleksandr Alekseev <alexander.alekseev@virtuozzo.com>
  Aleksei Zakharov <zaharov@selectel.ru>
  Andika Triwidada <andika@gmail.com>
  Andrea Bolognani <abologna@redhat.com>
  Ani Sinha <ani@anisinha.ca>
  Balázs Meskó <meskobalazs@mailbox.org>
  Barrett Schonefeld <bschoney@utexas.edu>
  Bastian Germann <bastiangermann@fishpost.de>
  Bastien Orivel <bastien.orivel@diateam.net>
  BiaoXiang Ye <yebiaoxiang@huawei.com>
  Bihong Yu <yubihong@huawei.com>
  Binfeng Wu <wubinfeng@huawei.com>
  Bjoern Walk <bwalk@linux.ibm.com>
  Boris Fiuczynski <fiuczy@linux.ibm.com>
  Brian Turek <brian.turek@gmail.com>
  Bruno Haible <bruno@clisp.org>
  Chris Mayo <aklhfex@gmail.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Ehrhardt <christian.ehrhardt@canonical.com>
  Christian Kirbach <christian.kirbach@gmail.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Cole Robinson <crobinso@redhat.com>
  Collin Walling <walling@linux.ibm.com>
  Cornelia Huck <cohuck@redhat.com>
  Cédric Bosdonnat <cbosdonnat@suse.com>
  Côme Borsoi <fedora@borsoi.fr>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniel Letai <dani@letai.org.il>
  Daniel P. Berrange <berrange@redhat.com>
  Daniel P. Berrangé <berrange@redhat.com>
  Didik Supriadi <didiksupriadi41@gmail.com>
  dinglimin <dinglimin@cmss.chinamobile.com>
  Dmytro Linkin <dlinkin@nvidia.com>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Eric Farman <farman@linux.ibm.com>
  Erik Skultety <eskultet@redhat.com>
  Fabian Affolter <mail@fabian-affolter.ch>
  Fabian Freyer <fabian.freyer@physik.tu-berlin.de>
  Fabiano Fidêncio <fabiano@fidencio.org>
  Fangge Jin <fjin@redhat.com>
  Farhan Ali <alifm@linux.ibm.com>
  Fedora Weblate Translation <i18n@lists.fedoraproject.org>
  Gavi Teitz <gavi@nvidia.com>
  gongwei <gongwei@smartx.com>
  Guoyi Tu<tu.guoyi@h3c.com>
  Göran Uddeborg <goeran@uddeborg.se>
  Halil Pasic <pasic@linux.ibm.com>
  Han Han <hhan@redhat.com>
  Hao Wang <wanghao232@huawei.com>
  Hela Basa <r45xveza@pm.me>
  Helmut Grohne <helmut@subdivi.de>
  Hiroki Narukawa <hnarukaw@yahoo-corp.jp>
  Ian Wienand <iwienand@redhat.com>
  Jakob Meng <jakobmeng@web.de>
  Jamie Strandboge <jamie@canonical.com>
  Jamie Strandboge <jamie@ubuntu.com>
  Jan Kuparinen <copper_fin@hotmail.com>
  jason lee <ppark5237@gmail.com>
  Jean-Baptiste Holcroft <jean-baptiste@holcroft.fr>
  Jia Zhou <zhou.jia2@zte.com.cn>
  Jianan Gao <jgao@redhat.com>
  Jim Fehlig <jfehlig@suse.com>
  Jin Yan <jinyan12@huawei.com>
  Jinsheng Zhang <zhangjl02@inspur.com>
  Jiri Denemark <jdenemar@redhat.com>
  John Ferlan <jferlan@redhat.com>
  Jonathan Watt <jwatt@jwatt.org>
  Jonathon Jongsma <jjongsma@redhat.com>
  Julio Faracco <jcfaracco@gmail.com>
  Justin Gatzen <justin.gatzen@gmail.com>
  Ján Tomko <jtomko@redhat.com>
  Kashyap Chamarthy <kchamart@redhat.com>
  Kevin Locke <kevin@kevinlocke.name>
  Kristina Hanicova <khanicov@redhat.com>
  Laine Stump <laine@redhat.com>
  Laszlo Ersek <lersek@redhat.com>
  Lee Yarwood <lyarwood@redhat.com>
  Lei Yang <yanglei209@huawei.com>
  Liao Pingfang <liao.pingfang@zte.com.cn>
  Lin Ma <lma@suse.com>
  Lin Ma <lma@suse.de>
  Lin Ma <morecache@gmail.com>
  Liu Yiding <liuyd.fnst@fujitsu.com>
  Luke Yue <lukedyue@gmail.com>
  Luyao Zhong <luyao.zhong@intel.com>
  Marc Hartmayer <mhartmay@linux.ibm.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Markus Schade <markus.schade@hetzner.com>
  Martin Kletzander <mkletzan@redhat.com>
  Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
  Matej Cepl <mcepl@cepl.eu>
  Matt Coleman <matt@datto.com>
  Matt Coleman <mcoleman@datto.com>
  Mauro Matteo Cascella <mcascell@redhat.com>
  Meina Li <meili@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Michał Smyk <fedora@smyk.it>
  Milo Casagrande <milo@milo.name>
  Moshe Levi <moshele@nvidia.com>
  Muha Aliss <muhaaliss@gmail.com>
  Nathan <nathan95@live.it>
  Neal Gompa <ngompa13@gmail.com>
  Nick Chevsky <nchevsky@gmail.com>
  Nick Shyrokovskiy <nshyrokovskiy@gmail.com>
  Nickys Music Group <nickys.music.group@gmail.com>
  Nico Pache <npache@redhat.com>
  Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
  Olaf Hering <olaf@aepfle.de>
  Olesya Gerasimenko <gammaray@basealt.ru>
  Orion Poplawski <orion@nwra.com>
  Pany <geekpany@gmail.com>
  Patrick Magauran <patmagauran.j@gmail.com>
  Paulo de Rezende Pinatti <ppinatti@linux.ibm.com>
  Pavel Hrdina <phrdina@redhat.com>
  Peng Liang <liangpeng10@huawei.com>
  Peter Krempa <pkrempa@redhat.com>
  Pino Toscano <ptoscano@redhat.com>
  Pino Toscano <toscano.pino@tiscali.it>
  Piotr Drąg <piotrdrag@gmail.com>
  Prathamesh Chavan <pc44800@gmail.com>
  Praveen K Paladugu <prapal@linux.microsoft.com>
  Richard W.M. Jones <rjones@redhat.com>
  Ricky Tigg <ricky.tigg@gmail.com>
  Robin Lee <cheeselee@fedoraproject.org>
  Roman Bogorodskiy <bogorodskiy@gmail.com>
  Roman Bolshakov <r.bolshakov@yadro.com>
  Ryan Gahagan <rgahagan@cs.utexas.edu>
  Ryan Schmidt <git@ryandesign.com>
  Sam Hartman <hartmans@debian.org>
  Scott Shambarger <scott-libvirt@shambarger.net>
  Sebastian Mitterle <smitterl@redhat.com>
  SeongHyun Jo <caelus9536@gmail.com>
  Shalini Chellathurai Saroja <shalini@linux.ibm.com>
  Shaojun Yang <yangshaojun@phytium.com.cn>
  Shi Lei <shi_lei@massclouds.com>
  simmon <simmon@nplob.com>
  Simon Chopin <chopin.simon@gmail.com>
  Simon Gaiser <simon@invisiblethingslab.com>
  Simon Rowe <simon.rowe@nutanix.com>
  Stefan Bader <stefan.bader@canonical.com>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Berger <stefanb@linux.vnet.ibm.com>
  Stefan Hajnoczi <stefanha@gmail.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Szymon Scholz <szymonscholz@gmail.com>
  Thomas Huth <thuth@redhat.com>
  Tim Wiederhake <twiederh@redhat.com>
  Tomáš Golembiovský <tgolembi@redhat.com>
  Tomáš Janoušek <tomi@nomi.cz>
  Tuguoyi <tu.guoyi@h3c.com>
  Victor Toso <victortoso@redhat.com>
  Ville Skyttä <ville.skytta@iki.fi>
  Vinayak Kale <vkale@nvidia.com>
  Wang Xin <wangxinxin.wang@huawei.com>
  WangJian <wangjian161@huawei.com>
  Weblate <noreply@weblate.org>
  Wei Liu <liuwe@microsoft.com>
  Wei Liu <wei.liu@kernel.org>
  Wei-Chen Chen <weicche@microsoft.com>
  William Douglas <william.douglas@intel.com>
  Yalei Li <274268859@qq.com>
  Yalei Li <liyl43@chinatelecom.cn>
  Yang Fei <yangfei85@huawei.com>
  Yang Hang <yanghang44@huawei.com>
  Yanqiu Zhang <yanqzhan@redhat.com>
  Yaroslav Kargin <ykargin@virtuozzo.com>
  Yi Li <yili@winhong.com>
  Yi Wang <wang.yi59@zte.com.cn>
  Yuri Chornoivan <yurchor@ukr.net>
  Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
  zhangjl02 <zhangjl02@inspur.com>
  Zheng Chuan <zhengchuan@huawei.com>
  zhenwei pi <pizhenwei@bytedance.com>
  Zhenyu Ye <yezhenyu2@huawei.com>
  Zhenyu Zheng <zheng.zhenyu@outlook.com>
  Zhenzhong Duan <zhenzhong.duan@intel.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          fail    
 build-arm64-libvirt                                          fail    
 build-armhf-libvirt                                          fail    
 build-i386-libvirt                                           fail    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           blocked 
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-libvirt-xsm                                 blocked 
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-libvirt                                     blocked 
 test-arm64-arm64-libvirt                                     blocked 
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-libvirt-pair                                blocked 
 test-amd64-i386-libvirt-pair                                 blocked 
 test-arm64-arm64-libvirt-qcow2                               blocked 
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-libvirt-vhd                                 blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 79619 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Oct 18 10:28:46 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Oct 2021 10:28:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.211965.369669 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcPsr-0007yi-4i; Mon, 18 Oct 2021 10:28:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 211965.369669; Mon, 18 Oct 2021 10:28:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcPsr-0007yb-1p; Mon, 18 Oct 2021 10:28:45 +0000
Received: by outflank-mailman (input) for mailman id 211965;
 Mon, 18 Oct 2021 10:28:43 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=6zTk=PG=suse.com=jgross@srs-us1.protection.inumbo.net>)
 id 1mcPsp-0007yS-R3
 for xen-devel@lists.xenproject.org; Mon, 18 Oct 2021 10:28:43 +0000
Received: from smtp-out2.suse.de (unknown [195.135.220.29])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 34c51bc3-f4e2-42d0-a812-86d8d8457599;
 Mon, 18 Oct 2021 10:28:42 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 1121D1FD6D;
 Mon, 18 Oct 2021 10:28:42 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 8D3AD13FEE;
 Mon, 18 Oct 2021 10:28:41 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id BA31IFlMbWGIdQAAMHmgww
 (envelope-from <jgross@suse.com>); Mon, 18 Oct 2021 10:28:41 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 34c51bc3-f4e2-42d0-a812-86d8d8457599
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1634552922; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=Ado6MtlaAgrZ1Rli89sn7WhX36BUDjCnqGiv7hIJAEs=;
	b=Cl+g9c5rqY9B9UN4IULAx2rngltYYMmTPbqE7xEC+MSfoKx8tGoUxcP0TIUHfDAYpvOPoT
	SXxFBOVSuQ2BkwA7Eq4fNwMKS+IhFgKlnY2JsarP2Jb3QrogSL7wGCyXbwo05iS2gE1vv6
	DmAzbD3O9H1biGdWQeedTTNJlrQfqYY=
To: Anthony PERARD <anthony.perard@citrix.com>,
 Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
 Ross Lagerwall <ross.lagerwall@citrix.com>,
 Daniel De Graaf <dgdegra@tycho.nsa.gov>,
 "Daniel P. Smith" <dpsmith@apertussolutions.com>,
 xen-devel@lists.xenproject.org
References: <20210824105038.1257926-1-anthony.perard@citrix.com>
 <20210824105038.1257926-50-anthony.perard@citrix.com>
 <2aaf0858-1602-be5c-77e4-2daa7fddc534@suse.com> <YWmzSkLdH5wtQ77V@perard>
 <f53e4d09-9f33-6dc8-8161-156b9eca4a6b@suse.com> <YW1Dhn+oEwvKgj04@perard>
From: Juergen Gross <jgross@suse.com>
Subject: Re: [XEN PATCH v7 49/51] build: adding out-of-tree support to the xen
 build
Message-ID: <70b8f320-bcd8-b864-f9de-a7ea35d53928@suse.com>
Date: Mon, 18 Oct 2021 12:28:41 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <YW1Dhn+oEwvKgj04@perard>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="z1f5VhX0LfcOjfEa7574f2jM5xrMQwykK"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--z1f5VhX0LfcOjfEa7574f2jM5xrMQwykK
Content-Type: multipart/mixed; boundary="PLX5GIJ3S7q6aOpAEPNIOkm0Zvvq8HagV";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Anthony PERARD <anthony.perard@citrix.com>,
 Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
 Ross Lagerwall <ross.lagerwall@citrix.com>,
 Daniel De Graaf <dgdegra@tycho.nsa.gov>,
 "Daniel P. Smith" <dpsmith@apertussolutions.com>,
 xen-devel@lists.xenproject.org
Message-ID: <70b8f320-bcd8-b864-f9de-a7ea35d53928@suse.com>
Subject: Re: [XEN PATCH v7 49/51] build: adding out-of-tree support to the xen
 build
References: <20210824105038.1257926-1-anthony.perard@citrix.com>
 <20210824105038.1257926-50-anthony.perard@citrix.com>
 <2aaf0858-1602-be5c-77e4-2daa7fddc534@suse.com> <YWmzSkLdH5wtQ77V@perard>
 <f53e4d09-9f33-6dc8-8161-156b9eca4a6b@suse.com> <YW1Dhn+oEwvKgj04@perard>
In-Reply-To: <YW1Dhn+oEwvKgj04@perard>

--PLX5GIJ3S7q6aOpAEPNIOkm0Zvvq8HagV
Content-Type: multipart/mixed;
 boundary="------------FCA8054FC2BAE24B14951845"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------FCA8054FC2BAE24B14951845
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 18.10.21 11:51, Anthony PERARD wrote:
> On Mon, Oct 18, 2021 at 11:02:20AM +0200, Jan Beulich wrote:
>> On 15.10.2021 18:58, Anthony PERARD wrote:
>>> On Thu, Oct 14, 2021 at 12:14:29PM +0200, Jan Beulich wrote:
>>>> On 24.08.2021 12:50, Anthony PERARD wrote:
>>>>> --- a/xen/Rules.mk
>>>>> +++ b/xen/Rules.mk
>>>>> @@ -38,7 +38,7 @@ SPECIAL_DATA_SECTIONS :=3D rodata $(foreach a,1 2=
 4 8 16, \
>>>>>                            $(foreach r,rel rel.ro,data.$(r).local)
>>>>>  =20
>>>>>   # The filename build.mk has precedence over Makefile
>>>>> -mk-dir :=3D $(src)
>>>>> +mk-dir :=3D $(srctree)/$(src)
>>>>>   include $(if $(wildcard $(mk-dir)/build.mk),$(mk-dir)/build.mk,$(=
mk-dir)/Makefile)
>>>>
>>>> Perhaps already when it was changed to $(src) the name has become
>>>> slightly misleading, at least imo: I would rather expect a variable
>>>> with this name to refer to the build dir/tree. Maybe "srcdir" or
>>>> even shorted "sd" right from the start? (Reaching here I can finally=

>>>> see why having a shorthand is helpful.)
>>>
>>> I have to think about that. I've made some further progress in order =
to
>>> be able to build the Xen pvhshim without a link farm and notice that
>>> nearly every source file needs to use "$(srctree)/$(src)"
>>
>> Oh, now I'm curious as to the why here. I thought use of $(srctree)
>> ought to be the exception.
>=20
> In Linux, the use of $(srctree) is indeed the exception. This is becaus=
e
> we have VPATH=3D$(srctree), so when `make` look for a prerequisite or a=

> target it will look first in the current directory and then in
> $(srctree). That works fine as long as the source tree only have source=
s
> and no built files.
>=20
> But if we want to be able to build the pv-shim without the linkfarm and=

> thus using out-of-tree build, we are going to need the ability to build=

> from a non-clean source tree. I don't think another way is possible.

Is there any reason (apart from historical ones) to build the hypervisor
in $(srctree)?

I could see several advantages to build it in another directory as soon
as the build system has this capability:

- possibility to have a simple build target for building multiple archs
   (assuming the cross-tools are available), leading to probably less
   problems with breaking the build of "the other" architecture we are
   normally not working with (and in future with e.g. Risc-V being added
   this will be even more important)

- possibility to have a debug and a non-debug build in parallel (in fact
   at least at SUSE we are working around that by building those with an
   intermediate "make clean" for being able to package both variants)

- make clean for the hypervisor part would be just a "rm -r"

Yes, this would require us (the developers) to maybe change some habits,
but I think this would be better than working around the issues by
adding $(srctree) all over the build system.


Juergen

--------------FCA8054FC2BAE24B14951845
Content-Type: application/pgp-keys;
 name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Transfer-Encoding: quoted-printable
Content-Description: OpenPGP public key
Content-Disposition: attachment;
 filename="OpenPGP_0xB0DE9DD628BF132F.asc"

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy=
cWx
w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O=
f8Z
d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y=
9bf
IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq=
G7/
377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR=
3Jv
c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA=
QIe
AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT=
hpw
dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0=
MbD
1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv=
oPH
Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v=
5QL
+qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ=
2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC=
QoL
BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr=
Wf0
teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC=
/nu
AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh=
ITT
d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm=
XBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz=
80h
SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC=
AcD
AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn=
FOX
gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1=
jnD
kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0=
N51
N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l=
otu
fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1=
tqS
EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA=
hsD
BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3=
g3O
ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5=
dM7
wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5=
D+j
LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm=
V2x
AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N=
Eaw
QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW=
nHI
s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR=
wgn
BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV=
bVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk=
pEd
IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA=
QAB
wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw=
Tbe
8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1=
vJz
Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8=
VGi
wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW=
svi
uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX=
zXs
ZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------FCA8054FC2BAE24B14951845--

--PLX5GIJ3S7q6aOpAEPNIOkm0Zvvq8HagV--

--z1f5VhX0LfcOjfEa7574f2jM5xrMQwykK
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmFtTFkFAwAAAAAACgkQsN6d1ii/Ey9C
ogf9FkEA0tfMJDk6JpxsZWB3zVHUM76S5YqyFtqVFD4fkRdOUW90CBud3oCrwrxCZSg3HrvPrqGz
4Jn0jNDDrRbDMXyRhK6vKGIzYD+pAS8Xle3LkDANwexwgADETCF5jG5PDkUHBouJwMsyb2J+thv5
52SYxWZPQW1VXBDyCyiIITsVI/gIOD+QqYaErk2mo5N6vw6v2p9yrPxZaiAwJi3Bh4ghjrAw53o+
/z9Gqi1g1DegOADCiMnVCgz8mtQdQ5csq4JviTGbRW6ayNY1SMtHLCi4vujLRshyRf97y4lxJAFR
Q9yrSf7TQk4/+B5LNLC3h4vis2bz674pXoEmWv2sdw==
=Ex/U
-----END PGP SIGNATURE-----

--z1f5VhX0LfcOjfEa7574f2jM5xrMQwykK--


From xen-devel-bounces@lists.xenproject.org Mon Oct 18 10:30:01 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Oct 2021 10:30:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.211973.369681 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcPu4-0000Bz-Js; Mon, 18 Oct 2021 10:30:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 211973.369681; Mon, 18 Oct 2021 10:30:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcPu4-0000Bs-Fz; Mon, 18 Oct 2021 10:30:00 +0000
Received: by outflank-mailman (input) for mailman id 211973;
 Mon, 18 Oct 2021 10:29:59 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=628V=PG=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mcPu3-0000Bl-Ef
 for xen-devel@lists.xenproject.org; Mon, 18 Oct 2021 10:29:59 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 57139c96-2ffe-11ec-82d1-12813bfff9fa;
 Mon, 18 Oct 2021 10:29:57 +0000 (UTC)
Received: from EUR01-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur01lp2055.outbound.protection.outlook.com [104.47.1.55]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-38-kaGPccwlPDGIX5gzpKf5Rg-1; Mon, 18 Oct 2021 12:29:55 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB6174.eurprd04.prod.outlook.com (2603:10a6:803:fa::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.17; Mon, 18 Oct
 2021 10:29:53 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.018; Mon, 18 Oct 2021
 10:29:53 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 FR3P281CA0021.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1c::11) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4628.10 via Frontend Transport; Mon, 18 Oct 2021 10:29:53 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 57139c96-2ffe-11ec-82d1-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634552996;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=eRDaHiiWyXwCU/PSNaVBX4fynCkDXWAM+DosMTCygrk=;
	b=kvcwlW5lbswyVabXszrsYPIF8fi174CNnNEyuEUG23GXYZCoRSwCXve4q69d0XTJL81KZP
	JlVG/LMpbWC/FgeHR66D1yiVgUiIcifcqjzbi6CvIMQWvkMSOGy0F3gNA6bHbJ6e/mHCos
	HrNFOi2UAkZsbijzNJpUe1IrNr5BSCg=
X-MC-Unique: kaGPccwlPDGIX5gzpKf5Rg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=S3PIvXqHciQqn9tjM8EogjRkyMBmb/6D+wtp0fHlRFpNVndh/QG8329fwiA6zMnK5ytHIntUFhCAl0JsEXKbNaMHTmgNtQgawmtj/NHW5rZ1gghpTeqApq0ryYzSPGAMlkZx4zC0M2b+mXhxo3Xr5syhbxSR4DNKVXVdDerdy2n+T8+SGNLibfZT2f5t9ayqqz9NA2Jdjs741ecKaHJnD5w7MK2wZVZdAFxI13LP9XMcszyKQAvOActMZEvajF9Qa2s8Jww46nD1CV5/LSYPqLpf7WDLCBmROsfY4wAeY3bdmUurd6uxD+R3ShoNPoig2vdgX/RNQ8WR5CljSGO0LA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=eRDaHiiWyXwCU/PSNaVBX4fynCkDXWAM+DosMTCygrk=;
 b=WHIhcdL6E9r2Cg12s/rGu1fImWuLs2x/yS2r9rzkPFWISaUtJFzh6jEtinoXX+tCpXPR5+4OlztPSXWvxuzSHKiRU8noRrclgNhzoC0ABl6WxoOSCWlqb+YSc4TarwxGfXDlJzBbUs5cq+FmNOysXiAGjdieA9JR3fgGPPzaMlpAIM80A6+zsaaZYI96OWQ0JYgfsFUtyCTJiDBwXBYpeu6nztk+kbUgPWkZfpuUFF79kdHwl2ne4UQNsIh4j93YQuWDRdfZmXBU7jCJQxQQSmrhWHcI5DNpLn2CpawBj6vxzjOogHKx7hd5vf8hcBQX67qtGKw9Xfv6de/dElfxhQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [PATCH v8 2/5] xen/arm: Enable the existing x86 virtual PCI
 support for ARM
To: Bertrand Marquis <Bertrand.Marquis@arm.com>,
 Ian Jackson <iwj@xenproject.org>
Cc: Rahul Singh <Rahul.Singh@arm.com>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>, "sstabellini@kernel.org" <sstabellini@kernel.org>,
 Julien Grall <julien@xen.org>, Volodymyr Babchuk
 <Volodymyr_Babchuk@epam.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
 Paul Durrant <paul@xen.org>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <cover.1634315461.git.bertrand.marquis@arm.com>
 <e2b10f56043155e4bb8eae824723045ccc042f8e.1634315461.git.bertrand.marquis@arm.com>
 <ca5558b2-25c6-90d2-284b-03cbbb02691f@suse.com>
 <FBC4FA6D-AF07-437A-BD81-52708B139070@arm.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <8c99e635-9509-b078-2285-48fb6fb91507@suse.com>
Date: Mon, 18 Oct 2021 12:29:51 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <FBC4FA6D-AF07-437A-BD81-52708B139070@arm.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR3P281CA0021.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:1c::11) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: c985eaba-2975-49ec-db48-08d99222392c
X-MS-TrafficTypeDiagnostic: VI1PR04MB6174:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB61746F39FFB853945E795E8DB3BC9@VI1PR04MB6174.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	ht16229mhZfNh3Io3b06qX5SnlcJEPuyRYs+oRGLtCdu4ZFLY/jFXKdQgk+CBpGX7psPx9ipFJtP2eDDwIIYR3POfzpp27UWheB24I/pDkS7+Ei0InMC09qE0bvdnBgzDdvoa/i6GFQLFOkZzQt8Er0RFYkZ4wiS7vTAZKnasUbw14Vyu7OBpizR9Eu4VVqHEt/84DzADVmfenRSPDcBBhvq16cn3GM3k2r7qqjPnNRJGfxEsHFzuz6D90/IADf3nIHLVQsPiinvlt+t1T19Ldzc1HPrGMOMNoR7p9AYmxvc/tYRxTTWzHdrqh7GObDdnFZmH4GH4i0IToQrjbSZDPhLFryhbAZDsPzU8TkzfifYUiF8jJ1OTw/tfYswwonwF4CmewhnWE47/jDMoyin7ZkQ2FmiPoQ280wWBBvnvISYle+Bc5pBiUrfvFd82kKfLHvJF0JXB+kEZhaClgCU7X9enQGvrykTYoLk5oqBXOPNSnSIkwkYMsRDipyvLSrZk6x91OF2F5UCADKiT+14Wfcd0IZSvr6cAsm2RWMjRf2LZXeKF1oH1wxna1IRlSjaht7Wj365ywjr7OA8cklyuiIAZbAvZuyTp1ujm53miXI56ZkNp11fMhPDyTnLlTaSur9asAlFV/Yo+Q1LO1ZELXQUbDvyvbDfFiV6LRemYhryK6tN05ogruEbcRrCWhvW5UUE4aWS6PO5cADpaxp3GYwOnrZ96hXJjMFABATSEDmgHM2ab2zC2ZSucJhTa+vVFzxg0i2XkJKh8K1HxQe7Gw==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(31686004)(186003)(86362001)(26005)(2906002)(31696002)(316002)(110136005)(16576012)(83380400001)(66946007)(508600001)(4326008)(38100700002)(6486002)(956004)(2616005)(36756003)(53546011)(8936002)(7416002)(5660300002)(54906003)(66556008)(8676002)(66476007)(2004002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?NkFZeDFTeVZuOENIaFR5bm1lbjJOcnJGYS93OG1YRFR5eGwxSkxGdEEvN0tC?=
 =?utf-8?B?V1VrdStlcXUxU29NdVJ3MWhoN1Z2aVpuQlFQdElVNXRKOFlkckQ5RC9hZ1lp?=
 =?utf-8?B?UnFQL2VOSlVIbFVVT0V2c3hjOVVEeEw1dTJ0aEExa1B5M2tlaThZOFp5bTU4?=
 =?utf-8?B?ZE10S0x1Uk9IVVFZZmtDWjAyMEFWWDUyUWcyZ09pK3YwdXBFZGpxNXJuTzJt?=
 =?utf-8?B?SURtdnpCWEF4SnNXQnNNRGYzbVBrUnp2Y3ZYNy9tRmhrTHdzN1VHV3VDblJS?=
 =?utf-8?B?aEVYaHlMUVNkalYzQ1Yvd3YvN29pcVNhRXVBNENxVmtwZmQvdlA3WndMUnF6?=
 =?utf-8?B?NURTN3pGakpETnA4SDlmTVM1THl5UU1EN0Fra0ZJS0V0T1dYQ3lZV3VNOHEz?=
 =?utf-8?B?ejcxbXhuWndGSVNwb0ZudDlQUWFBK2RPMVV2TXY4bUNRdFh3THdEeXh5TDVv?=
 =?utf-8?B?cnB3OWkvS29IbXBLQzBRU1VVclNxbzVFRzhoUytiMS82VENxZy81QTRRc1c4?=
 =?utf-8?B?ZStDNFAvVG1ERC9CcGR6MmVLNDQ2bE9rNWlYaDU1Umdjb0UydVh4YU4rMFJC?=
 =?utf-8?B?blY1Z1FqNDJXUDVyMTRBY1VQUVdNMTZPLzB2R2ZCMU1XM2NmbnRtNmM4NnBp?=
 =?utf-8?B?a01Ham8yL3M3S2FvTkNLeTRFV2JzRFNJazJQZjV6TU1GZ2F6Y2pYcFVQVGFV?=
 =?utf-8?B?VGdUYXk3SnFMaTFGUERyMHJmaEp5ZUNtK2gySWUwczdZRmMyOFg5dGw0bkJt?=
 =?utf-8?B?RUx2YkE3Unhjb1FkeHZZN29jREJZdTNaQlBMNUxKYU54VmlpekY4SGVyZUVL?=
 =?utf-8?B?RFpmZDd2ZUp4MEZMNGhua2c5ZHA3MXFNcGZaYUtaZm5ha3l0YmtpcUhzQTZn?=
 =?utf-8?B?aGJNNWlWTFk2ZUxFUWx5RHhTMFpFWGJ6WmhodXJjdWl6UGVmUm05VGMvcitx?=
 =?utf-8?B?SCt3TnczNzNvS0pCaTI2RkU0d0sySUVyRUdaZW5IR0RCcVlPMWEvM1ZZWjJa?=
 =?utf-8?B?aDlEbm1vam5hbmVCV0tDOHNFNzNTR0J6TzBleU1xcnlBTHhlRTdjNmNnZXpL?=
 =?utf-8?B?cmllYUE5MmNoTkQySlZkS0Vqa2I3OUNCYWFDSkJsQ3owRjVHMENlbVFxOE5m?=
 =?utf-8?B?eU1iaXFZOEx0MER1U0o1VTE4RFl2OUY4UE9HdTgrckZpbG4rYUp1VGVnTHhw?=
 =?utf-8?B?RXp6dEdtYlIzTkJiZmVTYVdoWm5YS2RnUk1YYUpBWVVlWjBnVmxNR1hFM2c2?=
 =?utf-8?B?RnE0U2RSSUhSdG5Db3pJVDFzRjBCbkFEUU5uV2VVdlNjQldHampPVDBKaFhR?=
 =?utf-8?B?eURBWlg4VDIxK003OE55TWloVHlZVnJsejE3T21vNlp4QkYrOFZIdHV4RkFL?=
 =?utf-8?B?cFk1VmRsdmRtbUFrYzhURkNCV0ZBTzQvbWY5UUhkRkxpVVV1R1ZGL3lWQXls?=
 =?utf-8?B?UFYyNUJnc1dvTDEzc3didGtXTG1HNXdEUjh5Zy8xVW0wdkowTFErK2JiNmNB?=
 =?utf-8?B?RGl6a1lORm1aTjdCVmM4SUVFbmJ4MGZnaUVoUVN4a3FyWk9kVmRSaEdPNVla?=
 =?utf-8?B?ejZPLzhCNjNFUVV4MmlRN1BqWVVrWU5IeHg5R21lNFFUVWxxVXFma2hZUWpW?=
 =?utf-8?B?RXZkaDA0VDV5MThCYkVHNUhCSHRQQ2xjalZmSFl3VkdUSlV1THMrYnhpVG10?=
 =?utf-8?B?STU2ZEJqWFNoS2pBUmFVNWZ4ZEJmN1Y4VkE5QklkR3lSaXA0WmhIejNYMDRs?=
 =?utf-8?Q?2TDLtTk74ElJn+2oykhAHtwigImYOSIlh2k+Gvy?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c985eaba-2975-49ec-db48-08d99222392c
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2021 10:29:53.6949
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: NOI3Aq6crGj11rbT3PiXREppclu2lqS3imV2FoBNExdDgUIx2pNKpP9Eo36kaMjk00AcYqOknfE6aZois+LQ3w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6174

On 18.10.2021 12:11, Bertrand Marquis wrote:
>> On 18 Oct 2021, at 08:47, Jan Beulich <jbeulich@suse.com> wrote:
>> On 15.10.2021 18:51, Bertrand Marquis wrote:
>>> --- /dev/null
>>> +++ b/xen/arch/arm/vpci.c
>>> @@ -0,0 +1,77 @@
>>> +/*
>>> + * xen/arch/arm/vpci.c
>>> + *
>>> + * This program is free software; you can redistribute it and/or modify
>>> + * it under the terms of the GNU General Public License as published by
>>> + * the Free Software Foundation; either version 2 of the License, or
>>> + * (at your option) any later version.
>>> + *
>>> + * This program is distributed in the hope that it will be useful,
>>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
>>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>>> + * GNU General Public License for more details.
>>> + */
>>> +#include <xen/sched.h>
>>> +#include <xen/vpci.h>
>>> +
>>> +#include <asm/mmio.h>
>>> +
>>> +static int vpci_mmio_read(struct vcpu *v, mmio_info_t *info,
>>> +                          register_t *r, void *p)
>>> +{
>>> +    pci_sbdf_t sbdf;
>>> +    /* data is needed to prevent a pointer cast on 32bit */
>>> +    unsigned long data;
>>> +
>>> +    /* We ignore segment part and always handle segment 0 */
>>> +    sbdf.sbdf = VPCI_ECAM_BDF(info->gpa);
>>> +
>>> +    if ( vpci_ecam_read(sbdf, ECAM_REG_OFFSET(info->gpa),
>>> +                        1U << info->dabt.size, &data) )
>>> +    {
>>
>> Here it is quite clear that the SBDF you pass into vpci_ecam_read() is
>> the virtual one. The function then calls vpci_read(), which in turn
>> will call vpci_read_hw() in a number of situations (first and foremost
>> whenever pci_get_pdev_by_domain() returns NULL). That function as well
>> as pci_get_pdev_by_domain() use the passed in SBDF as if it was a
>> physical one; I'm unable to spot any translation. Yet I do recall
>> seeing assignment of a virtual device and function number somewhere
>> (perhaps another of the related series), so the model also doesn't
>> look to assume 1:1 mapping of SBDF.
> 
> This question was answered by Oleksandr I think.

Yes; I continue to be sure though that I saw devfn allocation logic in
one of the many patches that are related here. And I'm relatively sure
that there no adjustment to logic here was made (but since it's hard
to pick the right patch out of the huge pile without knowing its title,
I can't reasonably go check).

>>> --- a/xen/drivers/passthrough/pci.c
>>> +++ b/xen/drivers/passthrough/pci.c
>>> @@ -756,6 +756,19 @@ int pci_add_device(u16 seg, u8 bus, u8 devfn,
>>>     if ( !pdev->domain )
>>>     {
>>>         pdev->domain = hardware_domain;
>>> +#ifdef CONFIG_ARM
>>> +        /*
>>> +         * On ARM PCI devices discovery will be done by Dom0. Add vpci handler
>>> +         * when Dom0 inform XEN to add the PCI devices in XEN.
>>> +         */
>>> +        ret = vpci_add_handlers(pdev);
>>> +        if ( ret )
>>> +        {
>>> +            printk(XENLOG_ERR "Setup of vPCI failed: %d\n", ret);
>>> +            pdev->domain = NULL;
>>> +            goto out;
>>> +        }
>>> +#endif
>>>         ret = iommu_add_device(pdev);
>>>         if ( ret )
>>>         {
>>
>> Upon failure, vpci_add_handlers() will itself call vpci_remove_handlers().
>> What about iommu_add_device() failure? The device will have ->domain
>> zapped, but all vPCI handlers still in place. This aspect of insufficient
>> error cleanup was pointed out already in review of v1.
> 
> Yes a call to vpci_remove_device should be made on the error path out if
> iommu_add_device is failing. This should also be done in fact in 
> pci_remove_device before cleanup the msi.
> We will push a patch with a proposal for a fix for this.
> 
>>
>> Furthermore already in v1 I questioned why this would be Arm-specific: On
>> x86 this code path is going to be taken for all devices Xen wasn't able
>> to discover at boot (anything on segments we wouldn't consider config
>> space access safe on without reassurance by Dom0 plus SR-IOV VFs, at the
>> very least). Hence it is my understanding that something along these
>> lines is actually also needed for PVH Dom0. I've just checked, and
>> according to my mailbox that comment was actually left unresponded to.
>>
>> Roger, am I missing anything here as to PVH Dom0 getting handlers put in
>> place?
> 
> From Roger answer I understood that it will be needed (in the future). 
> When and if this is needed, the ifdef CONFIG_ARM can be removed
> but this would change x86 code behaviour so I do not think it would
> have been right to do that in this serie.

I view this differently: This change {c,sh}ould have been broken out
into one changing x86 behavior first, which Arm then would simply
have adopted. I don't find it unusual for issues to be found in
existing code when making that fit for another architecture. As a
result ...

>> Of course as soon as the CONFIG_ARM conditionals were dropped, the
>> __hwdom_init issue would become an "active" one.
> 
> We will push a proposal for a fix for that.
> If I understand Roger right, vpci_add_handler will also be needed in runtime
> on x86 in the future so maybe it would even be right to remove the flag altogether ?

... I view these as going hand in hand: Removing the annotation
altogether is the way to go, yes, because on x86 the call will also
need to be made.

Ian, considering that PVH Dom0 is still experimental on x86, and
considering that the patch here was committed prematurely anyway,
would you be willing to release-ack a patch dropping the "#ifdef
CONFIG_ARM" alongside other necessary adjustments here, provided
maintainers have reached agreement?

Jan



From xen-devel-bounces@lists.xenproject.org Mon Oct 18 10:37:08 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Oct 2021 10:37:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.211981.369692 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcQ0n-0001dT-Av; Mon, 18 Oct 2021 10:36:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 211981.369692; Mon, 18 Oct 2021 10:36:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcQ0n-0001dM-7q; Mon, 18 Oct 2021 10:36:57 +0000
Received: by outflank-mailman (input) for mailman id 211981;
 Mon, 18 Oct 2021 10:36:55 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=628V=PG=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mcQ0l-0001dG-NI
 for xen-devel@lists.xenproject.org; Mon, 18 Oct 2021 10:36:55 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 8d4014ac-fc49-41c4-932b-94f40dbcea2b;
 Mon, 18 Oct 2021 10:36:54 +0000 (UTC)
Received: from EUR03-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur03lp2057.outbound.protection.outlook.com [104.47.10.57]) (Using
 TLS) by relay.mimecast.com with ESMTP id de-mta-6-Ld5LBfB5NSqBeSmf-snoRA-1;
 Mon, 18 Oct 2021 12:36:52 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15; Mon, 18 Oct
 2021 10:36:47 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.018; Mon, 18 Oct 2021
 10:36:47 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM5PR0402CA0021.eurprd04.prod.outlook.com (2603:10a6:203:90::31) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.14 via Frontend
 Transport; Mon, 18 Oct 2021 10:36:46 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8d4014ac-fc49-41c4-932b-94f40dbcea2b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634553413;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=54lMYIRfOMQZrvi614eNrvR+1q6NDOVTcxW4tIPAaYI=;
	b=dS0csK8mTLNsjTpLLna2V2b5R8/vAQdtuzhFma+b7oPJouEijHsrhtfCEzTK7uHHq2Rv0I
	xd0e0WchkoXqdBDKF+M73joHjGV2x3hGhRZJpT8Rx05yFGPE+nXo7kiA6WjBlBzWsLe+Cu
	R4UI7lcQmO3zu+MiHMjj1vRhzdSi0vw=
X-MC-Unique: Ld5LBfB5NSqBeSmf-snoRA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Jh2Vt5w4RqAEFXftAiT+2IZa7Chvh8wg/ADsbhj78BaqHEnEWWN1IPbq6ITozdJb49TCjE1p5QIO6rnfrsxMcvW4IxnLtE8aHDI8c1ScXY3sol8/764in2x2Yfos4ZJY+CIdxfrVqnCryidxcBmFOkHmKRiwxnigINrC805OPJY9LEvlKA6FCb4NI/LDu1zLL5etOMG0yZpAWf4U9k6Go7J8ptrjiTQ+CKlqsck17X30Z7/PPJxKr8+P9hsYWegvbfeAYHk3U8y46HbTY/YlFGn6odNSFw/40xCxqZCtWhIQM0QU/NGb4eBxguW+gFU+I1tUrswyEQuTY9BIiW5zUQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=54lMYIRfOMQZrvi614eNrvR+1q6NDOVTcxW4tIPAaYI=;
 b=hoFopHIWUgt7AOS5yC62C0RqmZGdOT3+ssdc0T734ZS8jAjM2MUpUa4203V0CMKh/gWlEanxu4VnmlJArKYA7/1TXkcrdbJzRJ2lzo8KWYVQ/AS0tAxgAV0Ztuylf9mkKWamJ/R9W39qmY1pw9uauWqNkdK25A1BQwbd99WLaP63XnxlJ7GiQIdJ4kgioLEvUzGjTbdLTdfBhZGIaG+BpIN0CRkW4nCcc0X3AVgYQNX1VQK0ry7hSMhLAl0F4bXniJsJdJaSm08sbHxunqGL6ZfCDeDFwM2DGMHUKf4K4U0xTBriVz3gZ6sVK3weklyZySMbc+mgiVJaRPuo68j5Cg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [XEN PATCH v7 49/51] build: adding out-of-tree support to the xen
 build
To: Juergen Gross <jgross@suse.com>,
 Anthony PERARD <anthony.perard@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
 Ross Lagerwall <ross.lagerwall@citrix.com>,
 Daniel De Graaf <dgdegra@tycho.nsa.gov>,
 "Daniel P. Smith" <dpsmith@apertussolutions.com>,
 xen-devel@lists.xenproject.org
References: <20210824105038.1257926-1-anthony.perard@citrix.com>
 <20210824105038.1257926-50-anthony.perard@citrix.com>
 <2aaf0858-1602-be5c-77e4-2daa7fddc534@suse.com> <YWmzSkLdH5wtQ77V@perard>
 <f53e4d09-9f33-6dc8-8161-156b9eca4a6b@suse.com> <YW1Dhn+oEwvKgj04@perard>
 <70b8f320-bcd8-b864-f9de-a7ea35d53928@suse.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <5a4df707-5b12-a471-e957-1a1c43340bff@suse.com>
Date: Mon, 18 Oct 2021 12:36:45 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <70b8f320-bcd8-b864-f9de-a7ea35d53928@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM5PR0402CA0021.eurprd04.prod.outlook.com
 (2603:10a6:203:90::31) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 89173da7-799e-4e63-374d-08d992233000
X-MS-TrafficTypeDiagnostic: VI1PR04MB5600:
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB56009BFA319FD00789B08D66B3BC9@VI1PR04MB5600.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	rqePQiNSfqT6TQb4i/mknXgJhTDCEzmOheOYv0yW2aXUaZAo9LzXtFamHkLCnqDd5zqo2gy330OoxOmZprZvQLxJC1gd2kCosiZsT1JiN22p2oHH4drcFQCPJtSzW6B0Bdg4Gtq5Nn6bWXDQ5jX7Ey9yPzWgDPOM3zbGQz5g+h/dRHmpJGiDGNCNvPo+FUEreD+UQr2Mb85rrncA8fWBCu3VOLzmNtOWxU3Auby0a331JvibuBdCIw+jAnvk+l5Z5JrMk5Y4Bl044w1WhxQzBFdwlIGhhbCek1IjwhLaEG018rAwBo9HtASDAgeoRYkEsYofF+fLuH50YHY4JFZ0gUcRFKigKnaRX/P0ju1ZJB0V3sj22lnSbzL/01QtLULCluFwIUn29GpwRQd80/htPQT7Q7sw5URa8zgllTZHdBlI15159f9z/srApC2WwmlC5/wBKQuSSjgmkvN1KWqkBMEZVc24Gx9WrL61IXojMTZcHtH7eu0K71YafK4kFcY8sBegtvCw3j4QXcRBN8LxRgRqarzdGo9UonkAQUJl7ZyeV/k2MsFJBT1I0xPXyVrf42BPQ50mhCahYAxYaJvmluBlJv9uGdT6fEH7V67xKRjjVqUBdUrKVqOdoxgjHj9VkDTccMEVOFuEQSbmjBDcVAZ3F1BrOV1O2ENiWyXeGWCAlSVpZ4kGp3rpBk7WloIaIhk+jRbeakSGdsBbuQ9VubL8JKRlEK5Qouzw/wJCDUR2q2TE2kKxOjaQwf78aJ9l
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(8936002)(31686004)(508600001)(6486002)(53546011)(38100700002)(4326008)(26005)(5660300002)(36756003)(2616005)(7416002)(66556008)(8676002)(66946007)(83380400001)(316002)(186003)(110136005)(66476007)(956004)(16576012)(31696002)(54906003)(2906002)(86362001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?NEVYcEdOcGpqK2JwclI5WFZZYzRSYmR4YTJvVXhPZXdsL2VqbDdndG5NeFpT?=
 =?utf-8?B?QVNEZ1BzQ3pyNVkwTTl3WHNSNXN6L3ZEUFJyWVVGTXR3TDlQc2JWS3FvZWQ5?=
 =?utf-8?B?QmlxSEhCQ2Q3M3p5ZG9nMXJWOVdTZ2s2bHBNMTZTMm9tZGhkQnFkaFIzNmlR?=
 =?utf-8?B?em9YOG15aDJDb0U1MGQxUjdIalRkbmNsZzUxdHVVNHM2TzAvU25Qc3RnVi9x?=
 =?utf-8?B?TkxIOFJDVUtRMUtLL1N0cVhQVTZCVWVVVFlzUnRJb0pudTA2aFFRTGFuM0ps?=
 =?utf-8?B?bzROZVVyUVpyRG9haEV6aVZJZlkwbGYzRk1BT1lSUzYxbGxqY1NUbmJoU1V6?=
 =?utf-8?B?K1BDK29hYmE1Y1piQUVwZWhnS2lMYktXYmxnQnJhSExtbU13MG1JMzVEZlFE?=
 =?utf-8?B?bmYrOUhyalVVODRQKzJwNGJrSDFiNjVsTC9UbXpGZDZ4VVZiSGYyQVBDbEUz?=
 =?utf-8?B?UUpGK0c3Q3VlUkJQK0c3L1lIWFBRelIySHBIZENrUDRIV3FUWlE0R1JwcHhW?=
 =?utf-8?B?Ym9tTmN4UU1ySlBnT3pVbEpLby9UUGJlSUV4NUZMcU5KN2hROXZlQldGQTd3?=
 =?utf-8?B?SEVpb0lqVXlkSmJaQUhFZXpKcDBBTFVGT2ZiVXc3ZE9IZnkzbHY1YStEc2VL?=
 =?utf-8?B?T29FbHQ4RGhkU1VXbWRicjRwM0g0Tld6NzBUNEhEVGxQNGYrd2xvdlpCcFZY?=
 =?utf-8?B?N04zdFZiOW02RXFyWkhIUm5ZVENqS3FMVHBkd3h5R0tLZFh0YmtiYnRJaHNI?=
 =?utf-8?B?TUlPRWJzVkFheWhrZ2ltQ29NRCsweDl5b0k1dnBSenJQMTVNcHh1TUY3QmhF?=
 =?utf-8?B?UDVXUGRZVFQxYUMyQkFPcjBTVzNtZU03eEZYektjL0QyTHBPLy8yUGJLRldY?=
 =?utf-8?B?NFo1Rmo2V0crWThJUUVURWNHUlJkOFB4d2JJaCtsTDR0R2xMdW55T2tOamZn?=
 =?utf-8?B?WHl6U1NpQ3JDc1JxYVgwaWdlUmxKTGdtS0FRYTBia1k5cHQxWnNSeWJick5P?=
 =?utf-8?B?VFFiNzlHSDVLK3hUODcwZ0Z5cVhCSk45OHlXNDNGS0VTd3VwKy9sOG9jdlpk?=
 =?utf-8?B?dCttRVZscm5sNjJJdTdkMkpEOEs5STNqZzhNZVN1NjFWT0FiSjFIY3g3bmxB?=
 =?utf-8?B?Undqb1Y4QWc4Y3N5WTA0U2xjeVJWY252azhyZkxQQUgzTXZMV24xaDNQU2NQ?=
 =?utf-8?B?VWlISFJvcklZeXAzaVRhWEJsNGlOWkN2dmZJQ0N5dHBMT0g0RnhwZEtaYXRQ?=
 =?utf-8?B?NmVSdlZjNmI5UjdEVDh4bVBBOUo3SUE1NEhYR2V5LzM2c09KVlBHQUpiM1dQ?=
 =?utf-8?B?V2V4WDdUb0kxdWNXZ09tenZyZGJLS1dhVE1mMitnZ0xJTkgzYXZlSk1RazN2?=
 =?utf-8?B?ZlRQY0QvNEJxTkJGNjkyR0RKSjFrTEIydXVTVjF0QzFsRXlUeGxrQnlrY2JX?=
 =?utf-8?B?aWJQeGxISWpzMmFHbE05WkY2RGxXY0NnVnpQcFZOMlNqZ0R3MlBaUHppMEdW?=
 =?utf-8?B?K0lxN0NLZ3RtZWpPbnpPVjQ3am1YUytYWXRncWFoUGFPWGw1bFZTTDBsKzZI?=
 =?utf-8?B?MlJhanV6dVUvSjExK0tScGlWd0ZKNEQ0d1YzZy9DdUR3c3hQamVydzdhL0o1?=
 =?utf-8?B?MTYzK0xudE90RzBlLzNBWk1sak95WlZIdzhmSnRKbjdtU0Zici9lWFlpSVdE?=
 =?utf-8?B?SVEvMmM0QU9QY0hwcGZjUW52VFNoUEVYUzhMREtKeFlRaFZHQjF4bmJYMlB3?=
 =?utf-8?Q?BHyC+WSOSqKenaosojJNZazAU5Ff9AdAXX317uH?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 89173da7-799e-4e63-374d-08d992233000
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2021 10:36:47.7776
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +f4wq4GvlBfwfRw0rmIjJBXBgtaByBuBm1JW3AfN1HDmC8SuVxaR0+N9apNjOt3mkdx8tke3fSEA+n/p0mZ6nw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5600

On 18.10.2021 12:28, Juergen Gross wrote:
> On 18.10.21 11:51, Anthony PERARD wrote:
>> On Mon, Oct 18, 2021 at 11:02:20AM +0200, Jan Beulich wrote:
>>> On 15.10.2021 18:58, Anthony PERARD wrote:
>>>> On Thu, Oct 14, 2021 at 12:14:29PM +0200, Jan Beulich wrote:
>>>>> On 24.08.2021 12:50, Anthony PERARD wrote:
>>>>>> --- a/xen/Rules.mk
>>>>>> +++ b/xen/Rules.mk
>>>>>> @@ -38,7 +38,7 @@ SPECIAL_DATA_SECTIONS := rodata $(foreach a,1 2 4 8 16, \
>>>>>>                            $(foreach r,rel rel.ro,data.$(r).local)
>>>>>>   
>>>>>>   # The filename build.mk has precedence over Makefile
>>>>>> -mk-dir := $(src)
>>>>>> +mk-dir := $(srctree)/$(src)
>>>>>>   include $(if $(wildcard $(mk-dir)/build.mk),$(mk-dir)/build.mk,$(mk-dir)/Makefile)
>>>>>
>>>>> Perhaps already when it was changed to $(src) the name has become
>>>>> slightly misleading, at least imo: I would rather expect a variable
>>>>> with this name to refer to the build dir/tree. Maybe "srcdir" or
>>>>> even shorted "sd" right from the start? (Reaching here I can finally
>>>>> see why having a shorthand is helpful.)
>>>>
>>>> I have to think about that. I've made some further progress in order to
>>>> be able to build the Xen pvhshim without a link farm and notice that
>>>> nearly every source file needs to use "$(srctree)/$(src)"
>>>
>>> Oh, now I'm curious as to the why here. I thought use of $(srctree)
>>> ought to be the exception.
>>
>> In Linux, the use of $(srctree) is indeed the exception. This is because
>> we have VPATH=$(srctree), so when `make` look for a prerequisite or a
>> target it will look first in the current directory and then in
>> $(srctree). That works fine as long as the source tree only have sources
>> and no built files.
>>
>> But if we want to be able to build the pv-shim without the linkfarm and
>> thus using out-of-tree build, we are going to need the ability to build
>> from a non-clean source tree. I don't think another way is possible.
> 
> Is there any reason (apart from historical ones) to build the hypervisor
> in $(srctree)?
> 
> I could see several advantages to build it in another directory as soon
> as the build system has this capability:
> 
> - possibility to have a simple build target for building multiple archs
>    (assuming the cross-tools are available), leading to probably less
>    problems with breaking the build of "the other" architecture we are
>    normally not working with (and in future with e.g. Risc-V being added
>    this will be even more important)
> 
> - possibility to have a debug and a non-debug build in parallel (in fact
>    at least at SUSE we are working around that by building those with an
>    intermediate "make clean" for being able to package both variants)
> 
> - make clean for the hypervisor part would be just a "rm -r"

I fully agree, yet ...

> Yes, this would require us (the developers) to maybe change some habits,
> but I think this would be better than working around the issues by
> adding $(srctree) all over the build system.

... developers' habits would only be my second concern here (and if that
had been the only one, then I would not see this as a reason speaking
against the change, but as said I've never been building from the root,
and I've also been building sort of out-of-tree all the time). Yet while
writing this reply I came to realize that my primary concern was wrong:
People would not need to adjust their spec files (or alike), at least
not as long as they consume only files living under dist/.

So, Anthony - thoughts about making the default in-tree Xen build
actually build into, say, build/xen/?

Jan



From xen-devel-bounces@lists.xenproject.org Mon Oct 18 10:38:22 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Oct 2021 10:38:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.211987.369703 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcQ29-0002EZ-M2; Mon, 18 Oct 2021 10:38:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 211987.369703; Mon, 18 Oct 2021 10:38:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcQ29-0002ES-Id; Mon, 18 Oct 2021 10:38:21 +0000
Received: by outflank-mailman (input) for mailman id 211987;
 Mon, 18 Oct 2021 10:38:20 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mcQ28-0002EK-Kw
 for xen-devel@lists.xenproject.org; Mon, 18 Oct 2021 10:38:20 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mcQ28-0002iQ-Ht
 for xen-devel@lists.xenproject.org; Mon, 18 Oct 2021 10:38:20 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mcQ28-0002H7-H2
 for xen-devel@lists.xenproject.org; Mon, 18 Oct 2021 10:38:20 +0000
Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89)
 (envelope-from <iwj@xenproject.org>)
 id 1mcQ21-0005VV-MB; Mon, 18 Oct 2021 11:38:13 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date
	:Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From;
	bh=y3Xyy8GVqWBEIN4ybsydeTQBkgiNMMy1ZiDPQvGMWsw=; b=iUK5YKi2EQ3DAvugEaeZCBswH3
	AO/LxYenkrLMzSVeHZB44bZRqZ4s79hIv7UY1P3vdivyrtxCbYLOErsrB+ZALtwbLptruFiBZl5dp
	0IKUSRlxoUBu/SUd3/yOhfBeauHDBTINS+izGdRXnNT9YebtsCuZ644CmVF4ieziPAz0=;
From: Ian Jackson <iwj@xenproject.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
Message-ID: <24941.20117.330072.580007@mariner.uk.xensource.com>
Date: Mon, 18 Oct 2021 11:38:13 +0100
To: Jan Beulich <jbeulich@suse.com>,
    Julien Grall <julien@xen.org>
Cc: Bertrand Marquis <Bertrand.Marquis@arm.com>,
    Xen-devel <xen-devel@lists.xenproject.org>,
    "sstabellini\@kernel.org" <sstabellini@kernel.org>,
    Rahul Singh <Rahul.Singh@arm.com>,
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
    Andrew Cooper <andrew.cooper3@citrix.com>,
    George Dunlap <george.dunlap@citrix.com>,
    Wei Liu <wl@xen.org>,
    Paul Durrant <paul@xen.org>,
    Roger Pau =?iso-8859-1?Q?Monn=E9?= <roger.pau@citrix.com>
Subject: Re: [PATCH v8 2/5] xen/arm: Enable the existing x86 virtual PCI
 support for ARM [and 1 more messages]
In-Reply-To: <a45077dc-e144-4427-9ae2-5815045ecaec@xen.org>,
	<2b6c80de-f71a-b32e-340f-130f62d9dfd5@suse.com>
References: <cover.1634315461.git.bertrand.marquis@arm.com>
	<e2b10f56043155e4bb8eae824723045ccc042f8e.1634315461.git.bertrand.marquis@arm.com>
	<cef8d2a6-91c1-2d4d-2078-98d0a92b067a@xen.org>
	<F447A1D8-A023-4127-AAC0-7511868DE9C4@arm.com>
	<a45077dc-e144-4427-9ae2-5815045ecaec@xen.org>
	<alpine.DEB.2.21.2110151235100.31303@sstabellini-ThinkPad-T480s>
	<YWqpQyKvNzE8GYda@MacBook-Air-de-Roger.local>
	<2b6c80de-f71a-b32e-340f-130f62d9dfd5@suse.com>
X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu)

Julien Grall writes ("Re: [PATCH v8 2/5] xen/arm: Enable the existing x86 virtual PCI support for ARM"):
> AFAICT, the code is not reachable on Arm (?). Therefore, one could argue 
> we this can wait after the week-end as this is a latent bug. Yet, I am 
> not really comfortable to see knowningly buggy code merged.

I agree that merging something that is known to be wrong would be
quite irregular, at least without a compelling reason.

Jan Beulich writes ("Re: [PATCH v8 2/5] xen/arm: Enable the existing x86 virtual PCI support for ARM"):
> On 16.10.2021 12:28, Roger Pau Monn� wrote:
> > Maybe I'm being pedantic, or there was some communication outside the
> > mailing list, but I think strictly speaking you are missing an Ack
> > from either Jan or Paul for the xen/drivers/passthrough/pci.c change.
> > 
> > IMHO seeing how that chunk moved from 3 different places in just one
> > afternoon also doesn't give me a lot of confidence. It's Arm only code
> > at the end, so it's not going to effect the existing x86 support and
> > I'm not specially worried, but I would like to avoid having to move it
> > again.
> 
> +1
> 
> I'll be replying to the patch itself for the technical aspects. As per
> context still visible above this code path is supposedly unreachable
> right now, which makes me wonder even more: Why the rush? Depending on
> the answer plus considering the __hwdom_init issue, Ian, I'm inclined
> to suggest a revert.

I don't want to be waving hammers about at this stage, and I haven't
looked at the technical details myself, but:

Can I ask the ARM folks to make sure that this situation is sorted out
ASAP ?  Say, by the end of Thursday ?

By sorted out I mean that the __init_hwdom issue is fixed and that
the overall changes to xen/drivers/passthrough/pci.c have been
properly approved.

Furthermore, I think these followup patches should go in all in one
go, as a small series, when everyone is OK with it, rather than
dribbling in.  That will make it easier to see the wood for the trees
(and it would also make a revert less complicated).

Jan, are you OK with this approach ?

Thanks,
Ian.


From xen-devel-bounces@lists.xenproject.org Mon Oct 18 10:40:14 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Oct 2021 10:40:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.211999.369713 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcQ3w-0003gu-7r; Mon, 18 Oct 2021 10:40:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 211999.369713; Mon, 18 Oct 2021 10:40:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcQ3w-0003gn-4T; Mon, 18 Oct 2021 10:40:12 +0000
Received: by outflank-mailman (input) for mailman id 211999;
 Mon, 18 Oct 2021 10:40:11 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=6zTk=PG=suse.com=jgross@srs-us1.protection.inumbo.net>)
 id 1mcQ3v-0003gh-Hh
 for xen-devel@lists.xenproject.org; Mon, 18 Oct 2021 10:40:11 +0000
Received: from smtp-out2.suse.de (unknown [195.135.220.29])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 697ecbc5-b76d-4f93-9e1a-b52471187dbd;
 Mon, 18 Oct 2021 10:40:10 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id B1B471FD7B;
 Mon, 18 Oct 2021 10:40:09 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 2175B1401B;
 Mon, 18 Oct 2021 10:40:09 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id KGEYBQlPbWEnfQAAMHmgww
 (envelope-from <jgross@suse.com>); Mon, 18 Oct 2021 10:40:09 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 697ecbc5-b76d-4f93-9e1a-b52471187dbd
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1634553609; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=TVNorc+grSkMTuYhyzTmu7hBoe2REQ8e8xBdgzIpYf4=;
	b=aQ/7hsIYiYnAa/RmHoW4Sx1SDlgeIKTOrmYrn1/4GbWnFZYsuXDOgAH8DXak00NjapgQ8R
	D0H0p9NMtOPG9AC0nqjMkDoq2Avem93nrfMOA48m4jVpYdqTbg3bd9by0Mu+xWXxKkVHPr
	zhYqV4xe12W96h/GCphN2tBHAlrZmS8=
Subject: Re: [XEN PATCH v7 49/51] build: adding out-of-tree support to the xen
 build
To: Jan Beulich <jbeulich@suse.com>,
 Anthony PERARD <anthony.perard@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
 Ross Lagerwall <ross.lagerwall@citrix.com>,
 Daniel De Graaf <dgdegra@tycho.nsa.gov>,
 "Daniel P. Smith" <dpsmith@apertussolutions.com>,
 xen-devel@lists.xenproject.org
References: <20210824105038.1257926-1-anthony.perard@citrix.com>
 <20210824105038.1257926-50-anthony.perard@citrix.com>
 <2aaf0858-1602-be5c-77e4-2daa7fddc534@suse.com> <YWmzSkLdH5wtQ77V@perard>
 <f53e4d09-9f33-6dc8-8161-156b9eca4a6b@suse.com> <YW1Dhn+oEwvKgj04@perard>
 <70b8f320-bcd8-b864-f9de-a7ea35d53928@suse.com>
 <5a4df707-5b12-a471-e957-1a1c43340bff@suse.com>
From: Juergen Gross <jgross@suse.com>
Message-ID: <9f3f6d5b-b920-911f-fea9-66fb36a09e5b@suse.com>
Date: Mon, 18 Oct 2021 12:40:08 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <5a4df707-5b12-a471-e957-1a1c43340bff@suse.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="EWVIMzEo44VTBB9qkXJcDeJ7zwoR5dQDH"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--EWVIMzEo44VTBB9qkXJcDeJ7zwoR5dQDH
Content-Type: multipart/mixed; boundary="EeXIYFdVeQTvEWFaKk1NYoeU9mfAHbBUJ";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Jan Beulich <jbeulich@suse.com>,
 Anthony PERARD <anthony.perard@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
 Ross Lagerwall <ross.lagerwall@citrix.com>,
 Daniel De Graaf <dgdegra@tycho.nsa.gov>,
 "Daniel P. Smith" <dpsmith@apertussolutions.com>,
 xen-devel@lists.xenproject.org
Message-ID: <9f3f6d5b-b920-911f-fea9-66fb36a09e5b@suse.com>
Subject: Re: [XEN PATCH v7 49/51] build: adding out-of-tree support to the xen
 build
References: <20210824105038.1257926-1-anthony.perard@citrix.com>
 <20210824105038.1257926-50-anthony.perard@citrix.com>
 <2aaf0858-1602-be5c-77e4-2daa7fddc534@suse.com> <YWmzSkLdH5wtQ77V@perard>
 <f53e4d09-9f33-6dc8-8161-156b9eca4a6b@suse.com> <YW1Dhn+oEwvKgj04@perard>
 <70b8f320-bcd8-b864-f9de-a7ea35d53928@suse.com>
 <5a4df707-5b12-a471-e957-1a1c43340bff@suse.com>
In-Reply-To: <5a4df707-5b12-a471-e957-1a1c43340bff@suse.com>

--EeXIYFdVeQTvEWFaKk1NYoeU9mfAHbBUJ
Content-Type: multipart/mixed;
 boundary="------------32E596BF8D82DAFEEBE8D0A7"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------32E596BF8D82DAFEEBE8D0A7
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 18.10.21 12:36, Jan Beulich wrote:
> On 18.10.2021 12:28, Juergen Gross wrote:
>> On 18.10.21 11:51, Anthony PERARD wrote:
>>> On Mon, Oct 18, 2021 at 11:02:20AM +0200, Jan Beulich wrote:
>>>> On 15.10.2021 18:58, Anthony PERARD wrote:
>>>>> On Thu, Oct 14, 2021 at 12:14:29PM +0200, Jan Beulich wrote:
>>>>>> On 24.08.2021 12:50, Anthony PERARD wrote:
>>>>>>> --- a/xen/Rules.mk
>>>>>>> +++ b/xen/Rules.mk
>>>>>>> @@ -38,7 +38,7 @@ SPECIAL_DATA_SECTIONS :=3D rodata $(foreach a,1=
 2 4 8 16, \
>>>>>>>                             $(foreach r,rel rel.ro,data.$(r).loca=
l)
>>>>>>>   =20
>>>>>>>    # The filename build.mk has precedence over Makefile
>>>>>>> -mk-dir :=3D $(src)
>>>>>>> +mk-dir :=3D $(srctree)/$(src)
>>>>>>>    include $(if $(wildcard $(mk-dir)/build.mk),$(mk-dir)/build.mk=
,$(mk-dir)/Makefile)
>>>>>>
>>>>>> Perhaps already when it was changed to $(src) the name has become
>>>>>> slightly misleading, at least imo: I would rather expect a variabl=
e
>>>>>> with this name to refer to the build dir/tree. Maybe "srcdir" or
>>>>>> even shorted "sd" right from the start? (Reaching here I can final=
ly
>>>>>> see why having a shorthand is helpful.)
>>>>>
>>>>> I have to think about that. I've made some further progress in orde=
r to
>>>>> be able to build the Xen pvhshim without a link farm and notice tha=
t
>>>>> nearly every source file needs to use "$(srctree)/$(src)"
>>>>
>>>> Oh, now I'm curious as to the why here. I thought use of $(srctree)
>>>> ought to be the exception.
>>>
>>> In Linux, the use of $(srctree) is indeed the exception. This is beca=
use
>>> we have VPATH=3D$(srctree), so when `make` look for a prerequisite or=
 a
>>> target it will look first in the current directory and then in
>>> $(srctree). That works fine as long as the source tree only have sour=
ces
>>> and no built files.
>>>
>>> But if we want to be able to build the pv-shim without the linkfarm a=
nd
>>> thus using out-of-tree build, we are going to need the ability to bui=
ld
>>> from a non-clean source tree. I don't think another way is possible.
>>
>> Is there any reason (apart from historical ones) to build the hypervis=
or
>> in $(srctree)?
>>
>> I could see several advantages to build it in another directory as soo=
n
>> as the build system has this capability:
>>
>> - possibility to have a simple build target for building multiple arch=
s
>>     (assuming the cross-tools are available), leading to probably less=

>>     problems with breaking the build of "the other" architecture we ar=
e
>>     normally not working with (and in future with e.g. Risc-V being ad=
ded
>>     this will be even more important)
>>
>> - possibility to have a debug and a non-debug build in parallel (in fa=
ct
>>     at least at SUSE we are working around that by building those with=
 an
>>     intermediate "make clean" for being able to package both variants)=

>>
>> - make clean for the hypervisor part would be just a "rm -r"
>=20
> I fully agree, yet ...
>=20
>> Yes, this would require us (the developers) to maybe change some habit=
s,
>> but I think this would be better than working around the issues by
>> adding $(srctree) all over the build system.
>=20
> ... developers' habits would only be my second concern here (and if tha=
t
> had been the only one, then I would not see this as a reason speaking
> against the change, but as said I've never been building from the root,=

> and I've also been building sort of out-of-tree all the time). Yet whil=
e
> writing this reply I came to realize that my primary concern was wrong:=

> People would not need to adjust their spec files (or alike), at least
> not as long as they consume only files living under dist/.
>=20
> So, Anthony - thoughts about making the default in-tree Xen build
> actually build into, say, build/xen/?

Or maybe even build-<arch>[-debug]/xen/?


Juergen

--------------32E596BF8D82DAFEEBE8D0A7
Content-Type: application/pgp-keys;
 name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Transfer-Encoding: quoted-printable
Content-Description: OpenPGP public key
Content-Disposition: attachment;
 filename="OpenPGP_0xB0DE9DD628BF132F.asc"

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy=
cWx
w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O=
f8Z
d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y=
9bf
IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq=
G7/
377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR=
3Jv
c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA=
QIe
AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT=
hpw
dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0=
MbD
1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv=
oPH
Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v=
5QL
+qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ=
2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC=
QoL
BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr=
Wf0
teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC=
/nu
AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh=
ITT
d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm=
XBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz=
80h
SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC=
AcD
AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn=
FOX
gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1=
jnD
kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0=
N51
N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l=
otu
fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1=
tqS
EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA=
hsD
BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3=
g3O
ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5=
dM7
wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5=
D+j
LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm=
V2x
AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N=
Eaw
QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW=
nHI
s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR=
wgn
BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV=
bVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk=
pEd
IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA=
QAB
wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw=
Tbe
8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1=
vJz
Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8=
VGi
wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW=
svi
uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX=
zXs
ZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------32E596BF8D82DAFEEBE8D0A7--

--EeXIYFdVeQTvEWFaKk1NYoeU9mfAHbBUJ--

--EWVIMzEo44VTBB9qkXJcDeJ7zwoR5dQDH
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmFtTwgFAwAAAAAACgkQsN6d1ii/Ey/k
bAf/fVIQUNg+kYq69VP646gJDwQcTC9DKqxSTGsVv1T5oxF/cDHDjMQmmRDfORQ+4Z6eUekrZW/d
mGh2HEOxdf7gF07YtkLzJBska0exy4CVzy3pSuchpSDsF+PEgh8OFKLS0V3vWVLphGbvbp1LSPqf
ckvW4+Da7o5HDymsaWmNKzc4hwcHIz2HudZAywrfkm9RgDnZph7zyJAvXCh0bgHrvI8r8lzRGatZ
Zi4mL+nxiyL52taemMDld72HAyoychMdQxIzqNIVpZdzbiXMYVUzjlG9q0wePX6zja+JAZmLvy1D
58bKJi/0I2aI43klOdAkycrAj7bH5r9Fhh3rK84bdg==
=TbgG
-----END PGP SIGNATURE-----

--EWVIMzEo44VTBB9qkXJcDeJ7zwoR5dQDH--


From xen-devel-bounces@lists.xenproject.org Mon Oct 18 10:43:00 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Oct 2021 10:43:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.212006.369724 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcQ6Z-0004KG-MY; Mon, 18 Oct 2021 10:42:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 212006.369724; Mon, 18 Oct 2021 10:42:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcQ6Z-0004K9-Jg; Mon, 18 Oct 2021 10:42:55 +0000
Received: by outflank-mailman (input) for mailman id 212006;
 Mon, 18 Oct 2021 10:42:54 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mcQ6Y-0004K0-7O
 for xen-devel@lists.xenproject.org; Mon, 18 Oct 2021 10:42:54 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mcQ6Y-0002o1-6d
 for xen-devel@lists.xenproject.org; Mon, 18 Oct 2021 10:42:54 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mcQ6Y-0002Zv-5s
 for xen-devel@lists.xenproject.org; Mon, 18 Oct 2021 10:42:54 +0000
Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89)
 (envelope-from <iwj@xenproject.org>)
 id 1mcQ6U-0005YL-RS; Mon, 18 Oct 2021 11:42:50 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date
	:Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From;
	bh=luKiMLwYeNzkpUIEP+eDifVCSZHNpqH38O8R8ikOigA=; b=5GK1kBUjQNGgWGc8fX5fiCj+VJ
	Nn82sm8qF2Rrg7XLY1NKMC5DJih9qsWf0tekvnJAYbambXzmgL+5ZF+eoRB34cU8xruM9OE9GfXoY
	kNRtY1c6QGMvXUeNQwnJMS6WXPGMXTKXi1cQclSE4tok9Oyw9h2zoFlWKdV2/VSrSQmo=;
From: Ian Jackson <iwj@xenproject.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <24941.20394.574634.548545@mariner.uk.xensource.com>
Date: Mon, 18 Oct 2021 11:42:50 +0100
To: Jan Beulich <jbeulich@suse.com>
Cc: "xen-devel\@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
    Andrew Cooper <andrew.cooper3@citrix.com>,
    Wei Liu <wl@xen.org>,
    Roger Pau =?iso-8859-1?Q?Monn=E9?= <roger.pau@citrix.com>,
    Paul Durrant <paul@xen.org>
Subject: Re: [PATCH] x86/HVM: correct cleanup after failed viridian_vcpu_init()
In-Reply-To: <55570db5-3823-8996-f69b-c2b00bcd4227@suse.com>
References: <55570db5-3823-8996-f69b-c2b00bcd4227@suse.com>
X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu)

Jan Beulich writes ("[PATCH] x86/HVM: correct cleanup after failed viridian_vcpu_init()"):
> This happens after nestedhvm_vcpu_initialise(), so its effects also need
> to be undone.
> 
> Fixes: 40a4a9d72d16 ("viridian: add init hooks")
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> 
> --- a/xen/arch/x86/hvm/hvm.c
> +++ b/xen/arch/x86/hvm/hvm.c
> @@ -1583,7 +1583,7 @@ int hvm_vcpu_initialise(struct vcpu *v)
>  
>      rc = viridian_vcpu_init(v);
>      if ( rc )
> -        goto fail5;
> +        goto fail6;

Not acomment about the patch; rather about the code in general.

I have not looked at the context.

But OMG, this is horrific.  How can anyone write code in such an idiom
without writing endless bugs ?

Ian.


From xen-devel-bounces@lists.xenproject.org Mon Oct 18 10:47:46 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Oct 2021 10:47:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.212013.369735 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcQBF-0004zP-94; Mon, 18 Oct 2021 10:47:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 212013.369735; Mon, 18 Oct 2021 10:47:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcQBF-0004zI-63; Mon, 18 Oct 2021 10:47:45 +0000
Received: by outflank-mailman (input) for mailman id 212013;
 Mon, 18 Oct 2021 10:47:44 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mcQBE-0004z8-CI; Mon, 18 Oct 2021 10:47:44 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mcQBD-0002uQ-W4; Mon, 18 Oct 2021 10:47:44 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mcQBD-0007dI-JD; Mon, 18 Oct 2021 10:47:43 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mcQBD-0004ia-In; Mon, 18 Oct 2021 10:47:43 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=UeykcYNb8Dq+2graPaBprQh6nBSeFenaAbXc4I2xPjg=; b=gKh7XMavxnUfTyneqNNVaZ7eqf
	VfTGQhOJookG385OzB0ptfsQRRfrdrA6B5BTM20w+2uYdZp+jjBe9vCty9bd5KE/2JGGMzJVN9f+o
	1if8EbFyQS0YuC6XPUKLQ453bLnTwJ5s990ycGC2FS+d9S2Ga8xY9bI+tJTX02EplMNg=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165631-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 165631: tolerable FAIL
X-Osstest-Failures:
    xen-unstable:test-amd64-i386-libvirt-pair:guest-migrate/dst_host/src_host/debian.repeat:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:guest-start.2:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=52d0847d7c6972baa74156f14ee8544f5aba1d2d
X-Osstest-Versions-That:
    xen=52d0847d7c6972baa74156f14ee8544f5aba1d2d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 18 Oct 2021 10:47:43 +0000

flight 165631 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165631/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-i386-libvirt-pair 28 guest-migrate/dst_host/src_host/debian.repeat fail pass in 165629
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 21 guest-start.2 fail pass in 165629

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 165629
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 165629
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165629
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165629
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 165629
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 165629
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 165629
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 165629
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 165629
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 165629
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165629
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 165629
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  52d0847d7c6972baa74156f14ee8544f5aba1d2d
baseline version:
 xen                  52d0847d7c6972baa74156f14ee8544f5aba1d2d

Last test of basis   165631  2021-10-18 01:52:55 Z    0 days
Testing same since                          (not found)         0 attempts

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 fail    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             fail    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Published tested tree is already up to date.



From xen-devel-bounces@lists.xenproject.org Mon Oct 18 10:48:02 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Oct 2021 10:48:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.212015.369750 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcQBT-0005R4-Nr; Mon, 18 Oct 2021 10:47:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 212015.369750; Mon, 18 Oct 2021 10:47:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcQBT-0005Qx-KR; Mon, 18 Oct 2021 10:47:59 +0000
Received: by outflank-mailman (input) for mailman id 212015;
 Mon, 18 Oct 2021 10:47:58 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=J+Bz=PG=arm.com=Bertrand.Marquis@srs-us1.protection.inumbo.net>)
 id 1mcQBS-0005On-6S
 for xen-devel@lists.xenproject.org; Mon, 18 Oct 2021 10:47:58 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com (unknown
 [40.107.8.53]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id da0d4083-3000-11ec-82d2-12813bfff9fa;
 Mon, 18 Oct 2021 10:47:56 +0000 (UTC)
Received: from DB6PR07CA0023.eurprd07.prod.outlook.com (2603:10a6:6:2d::33) by
 DB8PR08MB5179.eurprd08.prod.outlook.com (2603:10a6:10:e7::31) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.18; Mon, 18 Oct 2021 10:47:52 +0000
Received: from DB5EUR03FT005.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:6:2d:cafe::4c) by DB6PR07CA0023.outlook.office365.com
 (2603:10a6:6:2d::33) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.10 via Frontend
 Transport; Mon, 18 Oct 2021 10:47:52 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT005.mail.protection.outlook.com (10.152.20.122) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.15 via Frontend Transport; Mon, 18 Oct 2021 10:47:52 +0000
Received: ("Tessian outbound e27daf245730:v103");
 Mon, 18 Oct 2021 10:47:52 +0000
Received: from eef06a2ad24a.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 390F0E62-FB3A-459D-AC1A-BE15763BB6BD.1; 
 Mon, 18 Oct 2021 10:47:45 +0000
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id eef06a2ad24a.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Mon, 18 Oct 2021 10:47:45 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com (2603:10a6:4:74::9)
 by DB8PR08MB5258.eurprd08.prod.outlook.com (2603:10a6:10:e0::32) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.18; Mon, 18 Oct
 2021 10:47:44 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955]) by DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955%4]) with mapi id 15.20.4608.018; Mon, 18 Oct 2021
 10:47:43 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: da0d4083-3000-11ec-82d2-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=J+NzuueaWOBQNO1DcAK9Wffz37UHWOd65baRCaFge5s=;
 b=Gd+OH91wowzzV2G6ZULPbQKCza/lSUFu/L/EhsHl/nd0fPSerNPLClbGt/xiK2J0UtizMh10ZzPDFBsV/LwUYgnpoza5Aee/UiSiHbafqBn3y90qFYFY+5MKCDT/hiwSAnxhyZVHThKl1hIIZmErQtbHLB4TGb1/00zZnJtc/uY=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: dd61202457f2c40e
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Op08nGKsiGFkZnDCahLvEH/ivLot64Q69QM1BbMlhtMlldvMTNE6ZTe0Xf1T7xW1CBiZMUofvKaOa4Iw6kN6VpsR2FalyGxa9KEx1yFkrGhy8Eb30OI3TU1sHq7awArKcopFY75ws4ydHYMb9sUVaGsiXXYjzlK7J/jW7Z2JOT8hbDqvW+/eJHW0m3abZ6kETlNiJDla5F4lJwIP1kk7jS3XAN/0AqvEOKph9yJMIXY0HT0wupOy0UufTFZFuGTSvjEw9FcUMHGkV3C/PZ4TbOGF8Ri6tWtwuMPWQpBWdOdJUVcoqaNho6qO2htexo+d06jWsz8KbHxw4ppbYm4aLw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=J+NzuueaWOBQNO1DcAK9Wffz37UHWOd65baRCaFge5s=;
 b=azfgggcT+dyRhkk4I3ePefE2I+Dqtktllwx8CrhcKx0z2oGeMDBkCihodikTX+T+B8ScKg2B1oytQXSDJTivRil7brwEQlDDKvmdqtVHoH2emgRxVO4kRIu44Ys+NERXTSh7mgHG/uJOxuAiklr+KnKswIcWOeGB/Dodz77Dgn1UnHNP0WvnJOC9yWg+gWjnKT7cjy36tqpoad4w3wPQGQOS1Nlv5Etm6uJD4g98GvB+Z1jzroO0zQwOkqNTO7PREN4EIQ2lbgRqJ6cCIMJLgSeC8k7gAacVjlZt0VNPEgmJvbxpRJiKwRQYCtvPNrh/E6jaIEmIp2a4nVQmodEYaA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=J+NzuueaWOBQNO1DcAK9Wffz37UHWOd65baRCaFge5s=;
 b=Gd+OH91wowzzV2G6ZULPbQKCza/lSUFu/L/EhsHl/nd0fPSerNPLClbGt/xiK2J0UtizMh10ZzPDFBsV/LwUYgnpoza5Aee/UiSiHbafqBn3y90qFYFY+5MKCDT/hiwSAnxhyZVHThKl1hIIZmErQtbHLB4TGb1/00zZnJtc/uY=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Ian Jackson <iwj@xenproject.org>
CC: Jan Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>, Xen-devel
	<xen-devel@lists.xenproject.org>, "sstabellini@kernel.org"
	<sstabellini@kernel.org>, Rahul Singh <Rahul.Singh@arm.com>, Volodymyr
 Babchuk <Volodymyr_Babchuk@epam.com>, Andrew Cooper
	<andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>, Wei
 Liu <wl@xen.org>, Paul Durrant <paul@xen.org>,
	=?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>
Subject: Re: [PATCH v8 2/5] xen/arm: Enable the existing x86 virtual PCI
 support for ARM [and 1 more messages]
Thread-Topic: [PATCH v8 2/5] xen/arm: Enable the existing x86 virtual PCI
 support for ARM [and 1 more messages]
Thread-Index: AQHXxAxJ3B/Rg+jZk0SyvH1t/aZlYKvYkw2A
Date: Mon, 18 Oct 2021 10:47:42 +0000
Message-ID: <55163F8F-2D16-4326-AC70-CB48ED6D0A4C@arm.com>
References: <cover.1634315461.git.bertrand.marquis@arm.com>
 <e2b10f56043155e4bb8eae824723045ccc042f8e.1634315461.git.bertrand.marquis@arm.com>
 <cef8d2a6-91c1-2d4d-2078-98d0a92b067a@xen.org>
 <F447A1D8-A023-4127-AAC0-7511868DE9C4@arm.com>
 <a45077dc-e144-4427-9ae2-5815045ecaec@xen.org>
 <alpine.DEB.2.21.2110151235100.31303@sstabellini-ThinkPad-T480s>
 <YWqpQyKvNzE8GYda@MacBook-Air-de-Roger.local>
 <2b6c80de-f71a-b32e-340f-130f62d9dfd5@suse.com>
 <24941.20117.330072.580007@mariner.uk.xensource.com>
In-Reply-To: <24941.20117.330072.580007@mariner.uk.xensource.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3654.120.0.1.13)
Authentication-Results-Original: xenproject.org; dkim=none (message not
 signed) header.d=none;xenproject.org; dmarc=none action=none
 header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: 1a8eb03b-a2dc-426a-1fca-08d99224bc69
x-ms-traffictypediagnostic: DB8PR08MB5258:|DB8PR08MB5179:
x-ms-exchange-transport-forked: True
X-Microsoft-Antispam-PRVS:
	<DB8PR08MB51794882BA5C2756619DADC29DBC9@DB8PR08MB5179.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:10000;OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 ENwG2uFO/cCPurixmnsBSRcVSGDWHTYIehNmg9Ie4k2qhGJk/0a0XD6UpFxRlrsGVnrZQNiIPf3FkcPnitb0iwffVlwFfxtfpgJvcY2hzm5JotOraWwP7QzEMmOC6e6/KhK6Td6YJ/maCl4GJh3DrRdzZq3RgGZcOQNGalI6juCQQh4PVXBxCdG0i+8DP/PZRlj658byi5ETVCq/GK5CS5IjsqtGqn1VALTBxILgI5PcOtdqwsULG33z0qnNf7tuZdm7K6FaPKtLDKI2sYVhHEyJdIRgDYuknHHBfuBJNn22tRP4+BYXLqBwDPAXUgaa9NF9vpQXmpvo5AcOITAM3uHdCEiZobs0zKABS+HuNbAyThjJodNQsP5NZrmjSek5oFG2nPUtGhQ1a2g/FaodkeV8zoFnOWaHvGl3yDG4o8X8/mTdNRwreS9bcZZiCFfIcBWpr4unxCUICgsvZnYtIuGuIff0pNbxE1oEO/NGJQqsj5CnXzpxvCK1ewt3HTqLXnM4nTl2bJKuhzQ6ewu9JDSk5ZJt2Sf5NRnb3oX48ejpKSCCVgPBjKBjbzpIFKDwbX4MT0iE4FrMv+uOarwuEM2n2rGNT5PYxQFQij3HXJY02OeJz52vdawl8AqXDfgpuRnQjIjhX7x3lwSRsYpeNWpotIvUXHGoEsVZ6Qpi2uA9u29Y04S6lV+wGi+r3EiupijUireFHAhAiBogqjitvBRrnyCJOeiqtU2HfZhDpZremQeKg9crgjdV8HZC7ACO
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB6PR0801MB2024.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(6512007)(4326008)(91956017)(76116006)(186003)(53546011)(66946007)(66446008)(54906003)(6506007)(38070700005)(6916009)(33656002)(26005)(6486002)(8936002)(71200400001)(508600001)(2616005)(316002)(66476007)(64756008)(66556008)(8676002)(5660300002)(7416002)(86362001)(2906002)(36756003)(122000001)(38100700002)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-ID: <DB52705F69DAFF44B30038C69FBC442A@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB5258
Original-Authentication-Results: xenproject.org; dkim=none (message not signed)
 header.d=none;xenproject.org; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT005.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	9a443bc1-0410-48e2-278f-08d99224b701
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	cYt4pEr3/dgaHRlFcuTFSz72qPW0MHLHATPiIp1+7mkU6FFXp+Fyt//gI76rsZVbMQSm+wNDfck1GzT20sMxORjfP50aIxEjKFkNLjhlKraMgArYk7ee5hknY06QaehoiZ2ouvTcJILkCo0ZTpmtdow3ZaWwGsaS49tu+SGUmk1UpXb1acXAocNLB8bKl6+WeKYhonIzW/QQWZMpynXBJWp3BdBXeleO207DTOycMIa9RS81AHCcnKAu0hahIZbS6joxfpdl3AenqCRpZmHiFdgb3kY9KOT0Ru3DyZYagd3Eg2gjJm8RGoAm/y1dKRFFdcOwy57c92LTP7BJfqsX/j2x3FtIDQtNhNFplg0VlCwU88SloQXG5QKNGNGY9Hgm1AhsLm+PsLnxnljBMnM/0ZsplbIZS0G48tUrBSP2P12cSVPVyPC3DZVBQebw7Py1hyOYQZGXO4s5GvJ9mA8GSq8m8iYZdPan6FsOSbbu+yWOwvygYlyOMxVOY8TPsp2hBkZmjKNGwFmNiSX2mvT/QRybbGlyziPefL09UlU4u0N2fkECV8q+P/weWgSSp8SLFwh80f8dn4NXc/j/a99ajY8yXlYMMv9dLX+v9QQFpwv6oNQ2fMA116Ts3lhZJRCoeUJlVEGZn6pL8s6qosaf0Rd3LhdeeDf4UORMGqsXK5vcVuQ88cB3sJ3iYsoDAtT/BJ4SLiTO3AkM85NL15DCUw==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(81166007)(186003)(5660300002)(36756003)(36860700001)(508600001)(82310400003)(26005)(316002)(54906003)(107886003)(336012)(53546011)(6506007)(4326008)(6512007)(70586007)(86362001)(70206006)(8936002)(33656002)(47076005)(356005)(6862004)(6486002)(2906002)(8676002)(2616005);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2021 10:47:52.7039
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 1a8eb03b-a2dc-426a-1fca-08d99224bc69
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT005.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB5179

SGkgSWFuLA0KDQo+IE9uIDE4IE9jdCAyMDIxLCBhdCAxMTozOCwgSWFuIEphY2tzb24gPGl3akB4
ZW5wcm9qZWN0Lm9yZz4gd3JvdGU6DQo+IA0KPiBKdWxpZW4gR3JhbGwgd3JpdGVzICgiUmU6IFtQ
QVRDSCB2OCAyLzVdIHhlbi9hcm06IEVuYWJsZSB0aGUgZXhpc3RpbmcgeDg2IHZpcnR1YWwgUENJ
IHN1cHBvcnQgZm9yIEFSTSIpOg0KPj4gQUZBSUNULCB0aGUgY29kZSBpcyBub3QgcmVhY2hhYmxl
IG9uIEFybSAoPykuIFRoZXJlZm9yZSwgb25lIGNvdWxkIGFyZ3VlIA0KPj4gd2UgdGhpcyBjYW4g
d2FpdCBhZnRlciB0aGUgd2Vlay1lbmQgYXMgdGhpcyBpcyBhIGxhdGVudCBidWcuIFlldCwgSSBh
bSANCj4+IG5vdCByZWFsbHkgY29tZm9ydGFibGUgdG8gc2VlIGtub3duaW5nbHkgYnVnZ3kgY29k
ZSBtZXJnZWQuDQo+IA0KPiBJIGFncmVlIHRoYXQgbWVyZ2luZyBzb21ldGhpbmcgdGhhdCBpcyBr
bm93biB0byBiZSB3cm9uZyB3b3VsZCBiZQ0KPiBxdWl0ZSBpcnJlZ3VsYXIsIGF0IGxlYXN0IHdp
dGhvdXQgYSBjb21wZWxsaW5nIHJlYXNvbi4NCj4gDQo+IEphbiBCZXVsaWNoIHdyaXRlcyAoIlJl
OiBbUEFUQ0ggdjggMi81XSB4ZW4vYXJtOiBFbmFibGUgdGhlIGV4aXN0aW5nIHg4NiB2aXJ0dWFs
IFBDSSBzdXBwb3J0IGZvciBBUk0iKToNCj4+IE9uIDE2LjEwLjIwMjEgMTI6MjgsIFJvZ2VyIFBh
dSBNb25uw6/Cv8K9IHdyb3RlOg0KPj4+IE1heWJlIEknbSBiZWluZyBwZWRhbnRpYywgb3IgdGhl
cmUgd2FzIHNvbWUgY29tbXVuaWNhdGlvbiBvdXRzaWRlIHRoZQ0KPj4+IG1haWxpbmcgbGlzdCwg
YnV0IEkgdGhpbmsgc3RyaWN0bHkgc3BlYWtpbmcgeW91IGFyZSBtaXNzaW5nIGFuIEFjaw0KPj4+
IGZyb20gZWl0aGVyIEphbiBvciBQYXVsIGZvciB0aGUgeGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gv
cGNpLmMgY2hhbmdlLg0KPj4+IA0KPj4+IElNSE8gc2VlaW5nIGhvdyB0aGF0IGNodW5rIG1vdmVk
IGZyb20gMyBkaWZmZXJlbnQgcGxhY2VzIGluIGp1c3Qgb25lDQo+Pj4gYWZ0ZXJub29uIGFsc28g
ZG9lc24ndCBnaXZlIG1lIGEgbG90IG9mIGNvbmZpZGVuY2UuIEl0J3MgQXJtIG9ubHkgY29kZQ0K
Pj4+IGF0IHRoZSBlbmQsIHNvIGl0J3Mgbm90IGdvaW5nIHRvIGVmZmVjdCB0aGUgZXhpc3Rpbmcg
eDg2IHN1cHBvcnQgYW5kDQo+Pj4gSSdtIG5vdCBzcGVjaWFsbHkgd29ycmllZCwgYnV0IEkgd291
bGQgbGlrZSB0byBhdm9pZCBoYXZpbmcgdG8gbW92ZSBpdA0KPj4+IGFnYWluLg0KPj4gDQo+PiAr
MQ0KPj4gDQo+PiBJJ2xsIGJlIHJlcGx5aW5nIHRvIHRoZSBwYXRjaCBpdHNlbGYgZm9yIHRoZSB0
ZWNobmljYWwgYXNwZWN0cy4gQXMgcGVyDQo+PiBjb250ZXh0IHN0aWxsIHZpc2libGUgYWJvdmUg
dGhpcyBjb2RlIHBhdGggaXMgc3VwcG9zZWRseSB1bnJlYWNoYWJsZQ0KPj4gcmlnaHQgbm93LCB3
aGljaCBtYWtlcyBtZSB3b25kZXIgZXZlbiBtb3JlOiBXaHkgdGhlIHJ1c2g/IERlcGVuZGluZyBv
bg0KPj4gdGhlIGFuc3dlciBwbHVzIGNvbnNpZGVyaW5nIHRoZSBfX2h3ZG9tX2luaXQgaXNzdWUs
IElhbiwgSSdtIGluY2xpbmVkDQo+PiB0byBzdWdnZXN0IGEgcmV2ZXJ0Lg0KPiANCj4gSSBkb24n
dCB3YW50IHRvIGJlIHdhdmluZyBoYW1tZXJzIGFib3V0IGF0IHRoaXMgc3RhZ2UsIGFuZCBJIGhh
dmVuJ3QNCj4gbG9va2VkIGF0IHRoZSB0ZWNobmljYWwgZGV0YWlscyBteXNlbGYsIGJ1dDoNCj4g
DQo+IENhbiBJIGFzayB0aGUgQVJNIGZvbGtzIHRvIG1ha2Ugc3VyZSB0aGF0IHRoaXMgc2l0dWF0
aW9uIGlzIHNvcnRlZCBvdXQNCj4gQVNBUCA/ICBTYXksIGJ5IHRoZSBlbmQgb2YgVGh1cnNkYXkg
Pw0KDQpTdXJlLg0KDQpDaGVlcnMNCkJlcnRyYW5kDQoNCj4gDQo+IEJ5IHNvcnRlZCBvdXQgSSBt
ZWFuIHRoYXQgdGhlIF9faW5pdF9od2RvbSBpc3N1ZSBpcyBmaXhlZCBhbmQgdGhhdA0KPiB0aGUg
b3ZlcmFsbCBjaGFuZ2VzIHRvIHhlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL3BjaS5jIGhhdmUgYmVl
bg0KPiBwcm9wZXJseSBhcHByb3ZlZC4NCj4gDQo+IEZ1cnRoZXJtb3JlLCBJIHRoaW5rIHRoZXNl
IGZvbGxvd3VwIHBhdGNoZXMgc2hvdWxkIGdvIGluIGFsbCBpbiBvbmUNCj4gZ28sIGFzIGEgc21h
bGwgc2VyaWVzLCB3aGVuIGV2ZXJ5b25lIGlzIE9LIHdpdGggaXQsIHJhdGhlciB0aGFuDQo+IGRy
aWJibGluZyBpbi4gIFRoYXQgd2lsbCBtYWtlIGl0IGVhc2llciB0byBzZWUgdGhlIHdvb2QgZm9y
IHRoZSB0cmVlcw0KPiAoYW5kIGl0IHdvdWxkIGFsc28gbWFrZSBhIHJldmVydCBsZXNzIGNvbXBs
aWNhdGVkKS4NCj4gDQo+IEphbiwgYXJlIHlvdSBPSyB3aXRoIHRoaXMgYXBwcm9hY2ggPw0KPiAN
Cj4gVGhhbmtzLA0KPiBJYW4uDQoNCg==


From xen-devel-bounces@lists.xenproject.org Mon Oct 18 10:51:33 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Oct 2021 10:51:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.212030.369761 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcQEm-00074a-7Y; Mon, 18 Oct 2021 10:51:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 212030.369761; Mon, 18 Oct 2021 10:51:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcQEm-00074T-4C; Mon, 18 Oct 2021 10:51:24 +0000
Received: by outflank-mailman (input) for mailman id 212030;
 Mon, 18 Oct 2021 10:51:23 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mcQEl-00074N-2h
 for xen-devel@lists.xenproject.org; Mon, 18 Oct 2021 10:51:23 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mcQEl-0002ze-1v
 for xen-devel@lists.xenproject.org; Mon, 18 Oct 2021 10:51:23 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mcQEl-0003J6-11
 for xen-devel@lists.xenproject.org; Mon, 18 Oct 2021 10:51:23 +0000
Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89)
 (envelope-from <iwj@xenproject.org>)
 id 1mcQEe-0005av-Ld; Mon, 18 Oct 2021 11:51:16 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date
	:Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From;
	bh=8H9XuXVR6da7py2LFOMq979ejxA/c/T4INmrvC65j1A=; b=lHtciyXKXCb7SUYGkRp7AXWmR1
	6cTIcmW0ZNcZ2WW7aqXc9ewu+Y6GwX4Y69BwJ1KuVHXty9WbrUdSI4PulnoV9MCvHYHRj5wqwYEjx
	sobQF2roQeHF9L7trdxpyh7/xFZpyDf7xAiNSeb+468JfeWrVqVlljflMN3E0/feAU/Q=;
From: Ian Jackson <iwj@xenproject.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <24941.20900.439531.733506@mariner.uk.xensource.com>
Date: Mon, 18 Oct 2021 11:51:16 +0100
To: Jan Beulich <jbeulich@suse.com>,
    Roger Pau =?iso-8859-1?Q?Monn=E9?= <roger.pau@citrix.com>
Cc: committers@xenproject.org,
    xen-devel@lists.xenproject.org
Subject: Re: Xen 4.16 development update
In-Reply-To: <e644a1d4-a7a2-0554-f639-e19ba3102294@suse.com>
References: <24913.54299.590779.955301@mariner.uk.xensource.com>
	<24925.34307.187952.463474@mariner.uk.xensource.com>
	<e644a1d4-a7a2-0554-f639-e19ba3102294@suse.com>
X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu)

Jan Beulich writes ("Re: Xen 4.16 development update"):
> Now that we're here, I of course have given up on any of the pending
> non-bugfix patches to make 4.16. But I very much hope 4.16 won't go
> out with known bugs having fixes available. Therefore I've pinged (in
> some cases again):
> 
> x86/CPUID: don't shrink hypervisor leaves
> x86emul: de-duplicate scatters to the same linear address
> x86/AMD: make HT range dynamic for Fam17 and up
> x86/PV: address odd UB in I/O emulation
> x86/xstate: reset cached register values on resume
> x86/altp2m: don't consider "active" when enabling failed
> x86/PV: '0' debug key stack dumping adjustments [at least the first 2]
> x86/paging: restrict physical address width reported to guests
> x86/PoD: defer nested P2M flushes
> 
> In principle "x86: more or less log-dirty related improvements" also
> contains a number of bug fixes, but the way this series is stuck
> made me not include it in the pings.
> 
> I've tried to remember to Cc you on these pings, but I may not have
> succeeded in doing so.

Thanks.  I got at least most of them.

Roger, would you be able to review these changes ?

Thanks,
Ian.


From xen-devel-bounces@lists.xenproject.org Mon Oct 18 11:02:05 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Oct 2021 11:02:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.212039.369773 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcQP3-00009D-8Z; Mon, 18 Oct 2021 11:02:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 212039.369773; Mon, 18 Oct 2021 11:02:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcQP3-000096-3E; Mon, 18 Oct 2021 11:02:01 +0000
Received: by outflank-mailman (input) for mailman id 212039;
 Mon, 18 Oct 2021 11:02:00 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=628V=PG=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mcQP2-000090-9A
 for xen-devel@lists.xenproject.org; Mon, 18 Oct 2021 11:02:00 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id cfee7f42-3002-11ec-82d2-12813bfff9fa;
 Mon, 18 Oct 2021 11:01:58 +0000 (UTC)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2054.outbound.protection.outlook.com [104.47.12.54]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-17-0Qaxow2TMJCoLlXqPWsSXw-1; Mon, 18 Oct 2021 13:01:56 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB4190.eurprd04.prod.outlook.com (2603:10a6:803:4b::23)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16; Mon, 18 Oct
 2021 11:01:55 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.018; Mon, 18 Oct 2021
 11:01:55 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM7PR02CA0011.eurprd02.prod.outlook.com (2603:10a6:20b:100::21) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16 via Frontend
 Transport; Mon, 18 Oct 2021 11:01:54 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: cfee7f42-3002-11ec-82d2-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634554917;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=9QspbvaET/fKIId+6qOGtqo2qsD2x/bCrhnclhYEg84=;
	b=lzeyupfqoIOOf8OAlN8nm9k/Tb4jhj3+FtjoYajbJfxamnusGTPog5cA4AbnY7SoS0SFDG
	t1hYyglSUyuOhPCLLZNNsa+/YzyOS5jP2rIG+s+W39Ee42Pfwy+Q3RFWPggf9ejOND9ea8
	TxpaBbL/2ENx5uTkMYe/cjln7hF4tco=
X-MC-Unique: 0Qaxow2TMJCoLlXqPWsSXw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=lrrUCFZko0PGWC4GwYuPtPDK7Gi3dkCM1+m4KG1yKCMCDERvNKznt9MuacgBlq5tkgje0/iyf3pctSr/wf9CD6+tLBhKQEG2IJNiUBQOGxloE7sgdUWomuxtwVTlBnHlBXIfxWRQaBTQW2mvVpY6ybhyLbTAI/IDJJr1HDxDJpxd2xaRgus1bN5H8TOZK4rgJboswyRW/XQ7YnYFOJAVgfegniVR9NhQUt1Dy4oCUERWilfFU6fQpxOwaypUnWa3NWCom//qOdy31xoi2cSoO1df/nz89xKphrwXww5hg41wR6YuynVOi7/Jf8sKagXyDI74+iwwNUGOdpuBOd1xZQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=9QspbvaET/fKIId+6qOGtqo2qsD2x/bCrhnclhYEg84=;
 b=QiqX1q6GchtBqCyYAlCLq7C7pl8MfUxZdinBphIfmxf0E7ahz1eedL77MRhyHNpFS9mV/MD8bYacuX0Oa5dnrAn4+yZY8+Tksz8aborFM3mpQvrWm8OgYA70CIoNRFs03dJZ6tbVQ32VchVb/7PaGv154OGqIGpL5baSmPCCxP2dFBeNDBia/ZHsjc7T7qNYPoiqWfriugMom0Mk5B5EBgNUG0QW6HXQJyKy495uk91hNbDWtMKoQP52qTVsiUhPzujOxY7ebLjiU24Z75qx4Bf8/P4fzVzUilslR9T88LiKutGB3dL3T8dM6ZOiGNcHr1bG0jX0cIzMuN/qJLkHfQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [PATCH] tests/resource: Extend to check that the grant frames are
 mapped correctly
To: Jane Malalane <jane.malalane@citrix.com>
Cc: Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>,
 Xen-devel <xen-devel@lists.xenproject.org>
References: <20211018100848.10612-1-jane.malalane@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <11747958-dc2c-270f-6f96-4d9f53ea724e@suse.com>
Date: Mon, 18 Oct 2021 13:01:53 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <20211018100848.10612-1-jane.malalane@citrix.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM7PR02CA0011.eurprd02.prod.outlook.com
 (2603:10a6:20b:100::21) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: e872a40c-fcf5-4bc7-1690-08d99226b286
X-MS-TrafficTypeDiagnostic: VI1PR04MB4190:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB4190A5F8873DA6C0C8002318B3BC9@VI1PR04MB4190.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:33;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	1IJxq/dHjy7xwQrMqwZGFC70sqbKIJa35vNGqxvRsVFiAq3W4u2QdRhKZK39hR5Y32qvKnQQYP7ClEwjQu/OiS413gaaGf9o1Koa/TpGvzkvPAL6/GlZcCAA2v/zAFfCXAdsj6brcBX2FrcpH00V2t2EMpYhShiU/561A2MBAe8t8vpV8SRh35IG+4L5SysURuISWLjZGZaF5FcNYY6CIGX2qkDqcYznPf1ARB4xwqSvTd7lJzK9+VX78RV57iyLTKf2U1A+bvckv8deqwmJ+Ru1ut33SS4Kp0gpnV8tTnwdcg/P8mck5kVJkZR5z/uJi19jjPmSGTjYtNeAv/El52HOJna1/AsjHAIGPdtbnthzHrl85NKzcw8YnqROf7TTrEoPvmxIgWABVqujypGOiM6hZ7KoVb4RiMLAOxILbQCescKST67P14as/SYOdBZRSo+BBdRGqEMTfjlfJKCstcsve7f2rxnv1X+tsIz1pXzr4wlcVXz+/nOrJvz8Euj9zBGIYxjPKg3DDQKYKfHqlE2RsA15w6j+3MNwuD9eH/xYHIosKwT5ucZUqQXAkRRo0X/UfHTRr+rAq/WhE/VShJsIafKQW+Cv4RjJUuv/9jQ/QkRBYZwNltruvG+IU0/+Kii54z1paSqoXwRk66HzU2Jahu6LKvSxINuQ9bRojJUP0dYO/962lwHOHmhwfvFSsCvvDhQdsi9mFD3q0YEiMVQGop8iCqgL7NOFNd7LR+oCxSqnBUmXoyet7gOhhFk4
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(6486002)(31696002)(16576012)(36756003)(316002)(53546011)(186003)(5660300002)(54906003)(2906002)(8676002)(86362001)(31686004)(66946007)(4326008)(26005)(508600001)(956004)(2616005)(6916009)(83380400001)(38100700002)(8936002)(66476007)(66556008)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?QVo2V0pUZmJadlhJb3JVbmV1cG5mbWNhdjlnZnA5citxMXVQbnBJdTZuazQ5?=
 =?utf-8?B?N3g0c01xNGNrUXE4NDVVSmdXdjl4bktjOG1mSkxZTTg4dTJTaXg0amxFbXow?=
 =?utf-8?B?WWpFTWZQdzlMZ0IzM1FpajI0SzFHcXY0Q2QzTU9tTFRyVXZBRnJ3TEJjdUdi?=
 =?utf-8?B?M1B2SWFsWWFaTVBNK1EzZm80Z2RlMFA3WGp6OC9uMDRPWVZrUGJWRFJIUHd6?=
 =?utf-8?B?ZkwzaGFwTWIyWTQ2emZDNkdKMzVkcGJ1VDNSRFlCZ3dhZjdsU2MxOUd0M2J3?=
 =?utf-8?B?M1VnakFUbXJ2YkdabmNlb0k2bG9DNngxNElvNEU2bjVic0kzVmNsbUVEUXhq?=
 =?utf-8?B?cVpadi90M1RqWjVRbXBGYzIrelkyemxCZGc1dFFZRUVNdzR0eW8rN2hjUlNV?=
 =?utf-8?B?d3cwTk5ENkNFb0Nid2pYT214RlFQZ3JnVnowLzdBNmQ4U0JQZGwydzFPUmY2?=
 =?utf-8?B?YzZkU0NMcG9YSXZ3dzJ6YjR1WTZxY3Z2bHl6QWxsU3ptaUJRNGFzNm8xYWFl?=
 =?utf-8?B?VCt2L1YwOWNnSmxHY3E0K1hvdG9wWnJLc0ROZngvVlB2UmxhaFE1c1kwSURS?=
 =?utf-8?B?UTBHTWhoNlVLZnFrOWx1MU5oNkJRQVdUb2QxRjhrSDJad3gzbkRzYVcrenRH?=
 =?utf-8?B?a3FuM2Q0RU8wR2FKRGhiL0xNdkdtbnk3c1BkWGxRTmNZYndhS2QvdzA2QnpT?=
 =?utf-8?B?alNwWTBuSDVqVzBJamtBckVsd0xMMG5vWE1ybzVIVGlpbTBRbWthTzhhdUtw?=
 =?utf-8?B?R2RCV0FBNFd2bUxWVXQxNDljTHV1LytFMTNzeUw1SFlRREFvdGZsekZxNjhD?=
 =?utf-8?B?RnRXenJJQ3VpU1lTbTM5SURhblpTbDc0Q3pma0UyTzJJK1RhOWFPOXdLLzVM?=
 =?utf-8?B?d3BudC9CenhsSUFjNG9rQ25ycmZUbGtaM0t2ZFBuUHZUSGdldjhzcVBaUHlR?=
 =?utf-8?B?b3kybGx6NENSZXVRTnBDeUJEbVFRTEJocDJDOW41Wlg0RHRrcVFsdXU2NU9L?=
 =?utf-8?B?N0Zqc3FtS1d1MWg2UklDZi82Uld4RUhnL28rUGxIcnNYZGJLT0JKS1hpZExv?=
 =?utf-8?B?TUtXS2ZVamYzWmVzYWY2cCt0V21VbWVqbVFRWlZreGNLc2ZmbDhlYVpuYkxS?=
 =?utf-8?B?aUFDdFhBM2dvMllGRi9ZOW1kbmhMekduN1dlVk9uQzVoblh4aHVNUGZSR25D?=
 =?utf-8?B?cVg2SkZTbFRrRkIrSXRDUmFabzQ3bWZZYUxhQnhSejZMM1lQZ2d2NCs2ZFE5?=
 =?utf-8?B?cUY1VWJYTENYZ2NxVmMxdERMUEg5Rks3aTZ1RlY1ODl2N2Q4UUsrS1hsUnFW?=
 =?utf-8?B?Sk42TGxYMktSdzd0Y3NVMHdRMTU3L2p4anRaSjNlRG1qU1I4K0p6M3ZmczAx?=
 =?utf-8?B?NzBwUmpKRU5SWHpwWEIzOSt2MFFVRVlpcFA4NHNzTStBQTBGWG5lTWpjVlF2?=
 =?utf-8?B?R0xVU3BUT1cvWUdkNGppR3EvM3Q5WWdIaHQvQXphSHM5UWVzYm9zSnNCNDdq?=
 =?utf-8?B?VFc0cm5WT0s1T2VENE1hbkJ0OXYybTdodVNhWjdNVTJodUNhZjhqKzl1cmZ6?=
 =?utf-8?B?ZlJ1eDU5WTNLNHA2MUpyT1p0K2NVY216KzN3aTgzaGZBTm4wM1d0ZVVPVjBq?=
 =?utf-8?B?UG1PcDh5dWhReU5xK1VaRUhMMm9FR2RJVFE0Wll0Wk5ucDBZdWRwUW5BQ01H?=
 =?utf-8?B?WXdxZzJhTHl2TkI2QUhONGRtdG5EM29vWWZsOVdYQnZXc25PNG12aXVDTTRR?=
 =?utf-8?Q?19OfYKUYb2D3nvN3HI8Qem7MZd+7qgzX7KwlNpS?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e872a40c-fcf5-4bc7-1690-08d99226b286
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2021 11:01:55.2539
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: PKEfPx1GDeMX7GXRBuaLtNb/nhcPMA4frUFTL62+GrohbYdU60BA0/aEb1pcIPePSIET9X6tjeBhj5E6UuY2Zg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4190

On 18.10.2021 12:08, Jane Malalane wrote:
> @@ -51,18 +55,52 @@ static void test_gnttab(uint32_t domid, unsigned int nr_frames)
>      res = xenforeignmemory_map_resource(
>          fh, domid, XENMEM_resource_grant_table,
>          XENMEM_resource_grant_table_id_shared, 0, size >> XC_PAGE_SHIFT,
> -        &addr, PROT_READ | PROT_WRITE, 0);
> +        (void *)&gnttab, PROT_READ | PROT_WRITE, 0);

While in testing code I'm not as concerned about casts, I think it would
be better to cast to a visibly correct type, i.e. maintaining the levels
of indirection (void **). Alternatively you could (ab)use grants here,
allowing to drop the cast, by then assigning grants to gnttab.

>      /*
>       * Failure here with E2BIG indicates Xen is missing the bugfix to map
>       * resources larger than 32 frames.
>       */
>      if ( !res )
> -        return fail("    Fail: Map %d - %s\n", errno, strerror(errno));
> +        return fail("    Fail: Map grant table %d - %s\n", errno, strerror(errno));
>  
> +    /* Put each gref at a unique offset in its frame. */
> +    for ( unsigned int i = 0; i < nr_frames; i++ )
> +    {
> +        unsigned int gref = i * (XC_PAGE_SIZE / sizeof(*gnttab)) + i;
> +
> +        refs[i] = gref;
> +        domids[i] = domid;
> +
> +        gnttab[gref].domid = 0;
> +        gnttab[gref].frame = gfn;
> +        gnttab[gref].flags = GTF_permit_access;
> +    }

To make obvious that you're done with gnttab[], perhaps better unmap it
here rather than at the bottom?

> +    /* Map grants. */
> +    grants = xengnttab_map_grant_refs(gh, nr_frames, domids, refs, PROT_READ | PROT_WRITE);
> +
> +    /* Failure here indicates either that the frames were not mapped
> +     * in the correct order or xenforeignmemory_map_resource() didn't
> +     * give us the frames we asked for to begin with.
> +     */

Nit: Comment style.

> @@ -123,8 +162,25 @@ static void test_domain_configurations(void)
>  
>          printf("  Created d%u\n", domid);
>  
> -        test_gnttab(domid, t->create.max_grant_frames);
> +        rc = xc_domain_setmaxmem(xch, domid, -1);

That's an unbelievably large upper bound that you set. Since you
populate ...

> +        if ( rc )
> +        {
> +            fail("  Failed to set max memory for domain: %d - %s\n",
> +                 errno, strerror(errno));
> +            goto test_done;
> +        }
> +
> +        rc = xc_domain_populate_physmap_exact(xch, domid, ARRAY_SIZE(ram), 0, 0, ram);

... only a single page, can't you get away with a much smaller value?
And without engaging truncation from uint64_t to unsigned int in
XEN_DOMCTL_max_mem handling in the hypervisor (which imo would better
yield an error)?

Jan



From xen-devel-bounces@lists.xenproject.org Mon Oct 18 11:04:34 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Oct 2021 11:04:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.212048.369783 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcQRV-0000pm-Or; Mon, 18 Oct 2021 11:04:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 212048.369783; Mon, 18 Oct 2021 11:04:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcQRV-0000pf-L1; Mon, 18 Oct 2021 11:04:33 +0000
Received: by outflank-mailman (input) for mailman id 212048;
 Mon, 18 Oct 2021 11:04:32 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=628V=PG=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mcQRU-0000pU-L9
 for xen-devel@lists.xenproject.org; Mon, 18 Oct 2021 11:04:32 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 7312a911-5284-4017-a3a9-32b137fd0b24;
 Mon, 18 Oct 2021 11:04:31 +0000 (UTC)
Received: from EUR02-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur02lp2056.outbound.protection.outlook.com [104.47.6.56]) (Using
 TLS) by relay.mimecast.com with ESMTP id de-mta-4-AwK0v_GfNcGEYgd1ciBJdg-1;
 Mon, 18 Oct 2021 13:04:29 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB6302.eurprd04.prod.outlook.com (2603:10a6:803:102::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.17; Mon, 18 Oct
 2021 11:04:27 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.018; Mon, 18 Oct 2021
 11:04:27 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS9PR05CA0060.eurprd05.prod.outlook.com (2603:10a6:20b:489::31) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.14 via Frontend
 Transport; Mon, 18 Oct 2021 11:04:26 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7312a911-5284-4017-a3a9-32b137fd0b24
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634555070;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=HGGMYNRt0HUNitdLSdjPGHmL1pFvMNeiIbsE5v9tXCY=;
	b=cWd+N6Wsr+9dcOKlTS5fCBhsAUa2DM1ezm/yc0jM3QtvmbyZZV0zU0SS5XfJmTD+A8F9NZ
	uPD8TQoVNyMukbxQoQV9E7odhLf3PA6EZmStR3iSFwtJ7oBSP/YUvlGKotHi5BqOWjO6jb
	Pc1VYLAs6smbRQdjiKskaci/hu7fGj4=
X-MC-Unique: AwK0v_GfNcGEYgd1ciBJdg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=i6jpUNQciW16pLd4BcYEZ5JsGR+I/65hdeSHwoCGpmy/+JMnGNwyAeFNtH2iIwW/yF3NHVwEFe35O+ByC9oPBTnX279HfQb2sccpC2LTlEWOyBkqHW0tz8BMHpb7Q1DjsxFUN2dgd+0hwPJGfXrHkS1kw+/vqH6lL1Lddf+c8/JwJ3ONAT/zJa3K9jrvA1OKmRklJU0WSVBy6z12WVxtJzld5oeQFXqYipQnKgVPETQyruHtmiDFGucfUl2TOqY6bidV4K+pIqn+6eTzg7PnZg3C4q8fnuCR4X20RGRnLphmOeiorkjL/22sSQL5kk6CSPI4ZAA+2nXTSxwFNM1Bgw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=HT3bgD1N2M3YaOibhdjUYNEepol+J8HxI2jA1wA9PIo=;
 b=FbyHvVWM68xZz2m7LlQt8R+SpFTZW6tfZWcnFZw+qpqRWrPIO61CRg8LfJdULLAut1jebIG1IvcNgq52TXKTI7ZNU7/7Xj6beKvVnAhpraDVsF4x1mLNtpWMh8THyQFavz1buXgGKlBBBxGM1Roz0KGe/by5Q4MMTvuzgZM8inwfuhX90JtdLj4QY7kFYx7IXl+zHP3bJJ0srRr3G/mNRHYoZ5TFP7PMiSm7CJzKuzCSFOb2FeDykdyc9a2cxqwxA8HP6+ylHR24w5lkVJtxyzyxenOTtYu11OtNE0iSwrhU9Ibr89I03rW5+mq32rqdxJQVRTP9+NY4MPV6gZyHbg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: xen.org; dkim=none (message not signed)
 header.d=none;xen.org; dmarc=none action=none header.from=suse.com;
Subject: Re: [PATCH v8 2/5] xen/arm: Enable the existing x86 virtual PCI
 support for ARM [and 1 more messages]
To: Ian Jackson <iwj@xenproject.org>
CC: Bertrand Marquis <Bertrand.Marquis@arm.com>,
 Xen-devel <xen-devel@lists.xenproject.org>,
 "sstabellini@kernel.org" <sstabellini@kernel.org>,
 Rahul Singh <Rahul.Singh@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
 Paul Durrant <paul@xen.org>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>, Julien Grall <julien@xen.org>
References: <cover.1634315461.git.bertrand.marquis@arm.com>
 <e2b10f56043155e4bb8eae824723045ccc042f8e.1634315461.git.bertrand.marquis@arm.com>
 <cef8d2a6-91c1-2d4d-2078-98d0a92b067a@xen.org>
 <F447A1D8-A023-4127-AAC0-7511868DE9C4@arm.com>
 <a45077dc-e144-4427-9ae2-5815045ecaec@xen.org>
 <alpine.DEB.2.21.2110151235100.31303@sstabellini-ThinkPad-T480s>
 <YWqpQyKvNzE8GYda@MacBook-Air-de-Roger.local>
 <2b6c80de-f71a-b32e-340f-130f62d9dfd5@suse.com>
 <24941.20117.330072.580007@mariner.uk.xensource.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <91920ca1-7d80-e4c7-b567-adeedda1c885@suse.com>
Date: Mon, 18 Oct 2021 13:04:25 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <24941.20117.330072.580007@mariner.uk.xensource.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS9PR05CA0060.eurprd05.prod.outlook.com
 (2603:10a6:20b:489::31) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: c9b5c97d-53df-421d-7cfe-08d992270d61
X-MS-TrafficTypeDiagnostic: VI1PR04MB6302:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB6302D10909B6E026433AC49CB3BC9@VI1PR04MB6302.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	jqG0Gd4Cp4uWsKVv+cQdlVA0NZVfXPeopMwQxigij5OuVL13rIZKwAeiJepYOuYACPLplm/zKxsv81/qN+gU/CeEj2fCKQwHAZtqk2zO6R335f9SFObgb5PL+YoALcG1+ctbNXZaONS1YakKtWqVkgCjD5WesdkfA9IEMcRSxESKeLfQwXa+nic9K0TB+98LWfSy7x/9bXNR5Zt1CwAWJKNqSnK0U6BJ4LZosjgDO5AJvEUnXd23cbb5wS2eHgVKXZzmqscQcRiajtb3NyjDPZaZYuko2P9Be2dHa+bDgZgeFb3mXfR9AuXXPMVtmE7ophfY9y6LXHhOjwkbS//D0CRl6yaYzOh9SRoo5wyVC6mHorntjk5sSrzJOuwk5KwzrXv5x7+o7/BvpDV0GBcMPO7RXWkrmfBMlSYdkpzunj9G+ex7xTGS+HyLc76aQgpYgqIj1/RdQaZKVn89XViufem9riqKbNtu4OGIMpph4xXVvZ2eVn5J2xYzKlXr3DaN7eeFDKtFDs0jZPm9Jfqrlg7ZLHaArdvoCCe2JoCMLMc2uhkbmprX9ARmHx/V2Pdii0kdUtSYoyHEgqNDUiBFIfzl3Ys/aL4CMEe/hBhBlMniQnLcQh5QMB3nqcY/gBhgQ5g1yIwdEYZC2Jenb1+r0HWfGOAw/QW/z4gUI3voYzfBQMMXt4D1lb4jrYACGflEYTMfbFtbhu/rl8e9o9aVwK0dOik70xHy+A6kSEAQoK8UKJSs59sGwtdknf41zwar
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(26005)(66556008)(6486002)(2616005)(66476007)(36756003)(508600001)(8676002)(38100700002)(54906003)(66946007)(186003)(4326008)(316002)(16576012)(5660300002)(8936002)(7416002)(2906002)(86362001)(31696002)(53546011)(31686004)(956004)(6916009)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?LHSMdAkar3obbkM/P27HTsi8Cqrr6PGg8E48qRu9C9fCXaKEkxFo1LmT+mMG?=
 =?us-ascii?Q?JTRNynHpE3yFCKp1vbFn0vAmZ7gDBcaucCw3eQoV+Zc4ckaQg4mmbtJyg9Rq?=
 =?us-ascii?Q?CPMep7Od6iyLI458l55dJRoJ/iuxuOiat8jVxLPaTsRUakuabyFyuRrawhyC?=
 =?us-ascii?Q?HDNtW1958B2mWKiBaWd/FFDHr/FD3FPWLyDn2CiigEr/B1GBcEGqVqWeuP2r?=
 =?us-ascii?Q?1zFstDZKZdmop0PTWsinNF3Dj9VHhmqDf2w9jy8jtJLI/9ZDYKY16KoQNz68?=
 =?us-ascii?Q?EfXDAifkgLFiIA4APhV2J0t0FOAEsmnSBBdjqUXQhr0GHI8FbgBdTpOk1M3/?=
 =?us-ascii?Q?6m8FJB9LKKg8uOgR7gWoKS7manJErnQVL1T9UqVE2gXpWKCQH2CpErOE8ugn?=
 =?us-ascii?Q?GwL0XdRcKmkBX2cH17v+k11t5kKSI1BLA9peJvrC8O7VvzpuH6E3usoZhAhE?=
 =?us-ascii?Q?L8tO8/fikNIVE80k5VIUjbAvuMOjpaJSOMEKmCRP0y9fW31+mZo3elgji860?=
 =?us-ascii?Q?ThsQWiaPA2ASHKhYIapCOBENPofGiP5UH21g3gPCGKgeVfQh17JlMzw2H3jv?=
 =?us-ascii?Q?ekvdAUp7fbhISrqx8pt2uO+SbaozxyVVkDvv3eL5Rlz4fGBK1IPrAv+l+Lpg?=
 =?us-ascii?Q?ZULDoYF4Ysd+6icWLdnFpBjiU90erTXstJMfM6Vt2h3JjSrKD91lEtPsOmuc?=
 =?us-ascii?Q?NMPCHxSaDVdDph6SYk+74eR/nno/tf6CTOIOhYNFtI9hzdlzMPKkYH3NwG1e?=
 =?us-ascii?Q?zgJtqoPJwqRS09UnQHjC10djvyzQihCGz9OEDNmeSokP1CD+2X22xl/rzdQP?=
 =?us-ascii?Q?4o+8jC6Smc+dg80S3RPEz6RPQ+/i7A/IZo6xmB7QMfQtQIsauNKxKGbOCxYM?=
 =?us-ascii?Q?dsW7DmC0PtsyAUpVib4d4ToE9TEyQNmCVHIfTzw+bV/loK4bm9iBiFFJylbw?=
 =?us-ascii?Q?r7yzbqR37ePnuw04hzCmxieid7VKbKrsuc49mEnTmi81X1eyptEIjonHp4J6?=
 =?us-ascii?Q?F5+6WN4JpspMPVOwOzC2D6AnljM35N7kFvJHWU0fwA+qpNhW0Qf3mYA+AF7E?=
 =?us-ascii?Q?+8suPscQj5mb2/iw0bDoDVe0Vea9G4QWghzQb9rqEkvbY7/IsNej+pOTp1QL?=
 =?us-ascii?Q?uHheql/dzdEFL67yiwtS3Y7T4u9p7fKsjt63KO/ttCpR+QwCu/OZNVipEzkb?=
 =?us-ascii?Q?nin16BMmGe+/87W8wU3enMXB4h86fXJCodnMBAA1yCK50bgVCzxlSl3oDv3d?=
 =?us-ascii?Q?Df7QPG58xmWRIrjtbz7CTPeIarEsjid922OEWhR32FjOaEb8Ohl11PK2Vgq3?=
 =?us-ascii?Q?9oDUKKERihH4KU4zFwhZdXzT?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c9b5c97d-53df-421d-7cfe-08d992270d61
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2021 11:04:27.6997
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Vz/TVvFZ5Q3zK8ndUE6dbmplppduGkdssg4Ml6DxJe2WFmExoA4hTyhTXnHsxuAcGmLE983MCv7vUJrbN+D1Aw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6302

On 18.10.2021 12:38, Ian Jackson wrote:
> Julien Grall writes ("Re: [PATCH v8 2/5] xen/arm: Enable the existing x86=
 virtual PCI support for ARM"):
>> AFAICT, the code is not reachable on Arm (?). Therefore, one could argue=
=20
>> we this can wait after the week-end as this is a latent bug. Yet, I am=20
>> not really comfortable to see knowningly buggy code merged.
>=20
> I agree that merging something that is known to be wrong would be
> quite irregular, at least without a compelling reason.
>=20
> Jan Beulich writes ("Re: [PATCH v8 2/5] xen/arm: Enable the existing x86 =
virtual PCI support for ARM"):
>> On 16.10.2021 12:28, Roger Pau Monn=C3=A9 wrote:
>>> Maybe I'm being pedantic, or there was some communication outside the
>>> mailing list, but I think strictly speaking you are missing an Ack
>>> from either Jan or Paul for the xen/drivers/passthrough/pci.c change.
>>>
>>> IMHO seeing how that chunk moved from 3 different places in just one
>>> afternoon also doesn't give me a lot of confidence. It's Arm only code
>>> at the end, so it's not going to effect the existing x86 support and
>>> I'm not specially worried, but I would like to avoid having to move it
>>> again.
>>
>> +1
>>
>> I'll be replying to the patch itself for the technical aspects. As per
>> context still visible above this code path is supposedly unreachable
>> right now, which makes me wonder even more: Why the rush? Depending on
>> the answer plus considering the __hwdom_init issue, Ian, I'm inclined
>> to suggest a revert.
>=20
> I don't want to be waving hammers about at this stage, and I haven't
> looked at the technical details myself, but:
>=20
> Can I ask the ARM folks to make sure that this situation is sorted out
> ASAP ?  Say, by the end of Thursday ?
>=20
> By sorted out I mean that the __init_hwdom issue is fixed and that
> the overall changes to xen/drivers/passthrough/pci.c have been
> properly approved.
>=20
> Furthermore, I think these followup patches should go in all in one
> go, as a small series, when everyone is OK with it, rather than
> dribbling in.  That will make it easier to see the wood for the trees
> (and it would also make a revert less complicated).
>=20
> Jan, are you OK with this approach ?

Yes. FTR I'm not fussed about "all in one go" vs "dribbling in".

Jan



From xen-devel-bounces@lists.xenproject.org Mon Oct 18 11:07:48 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Oct 2021 11:07:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.212057.369793 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcQUb-0001U8-7Z; Mon, 18 Oct 2021 11:07:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 212057.369793; Mon, 18 Oct 2021 11:07:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcQUb-0001U1-4F; Mon, 18 Oct 2021 11:07:45 +0000
Received: by outflank-mailman (input) for mailman id 212057;
 Mon, 18 Oct 2021 11:07:43 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=628V=PG=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mcQUZ-0001Tv-OA
 for xen-devel@lists.xenproject.org; Mon, 18 Oct 2021 11:07:43 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 9d0b06a8-3003-11ec-82d2-12813bfff9fa;
 Mon, 18 Oct 2021 11:07:42 +0000 (UTC)
Received: from EUR02-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur02lp2059.outbound.protection.outlook.com [104.47.5.59]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-38-FXxs345tOsmPECR3zuGo4Q-2; Mon, 18 Oct 2021 13:07:40 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB5472.eurprd04.prod.outlook.com (2603:10a6:803:d3::28)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.17; Mon, 18 Oct
 2021 11:07:36 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.018; Mon, 18 Oct 2021
 11:07:36 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 FR3P281CA0028.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1c::19) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4628.9 via Frontend Transport; Mon, 18 Oct 2021 11:07:35 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9d0b06a8-3003-11ec-82d2-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634555261;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=LpcXY7D0Qn9/lHPEEz/SfuMrsgtPEGlefunqWPTLDvY=;
	b=dOtNwnBk0mha6R87TVCxjo0iiH1eguXQC43CwwWnl+yrkCpgTJ7eFb0JpxEjgQgZG6PgV4
	Pdjv9BNGUwydrTeJdfOw2QZB97p7EyCzQfAVCsuaq4WXT1tyoTp4GaERE/y2ZoO5IS48/a
	+KWmtFp1ngqEoyJIHxtOC3+0QundwQM=
X-MC-Unique: FXxs345tOsmPECR3zuGo4Q-2
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=GB7k6CdEfNZBPDsPGXY85pqS90Y9iTxaCptC1a9c8KBP6yaL2sJDBo2qwu1ThEncNVM4gcbTV/YIsCZruAeOuAgXLJ2a2G8pq6YwjeSiCwnyaFIdr2o7uGqhz52zw60e2gJgIvvV2l2VBTLZrUqmoXBZmbwSry9LhhDM60emsN5//+5NDM58szsWQEvAE5Bc19lrYCAH1dB5eIFSoXvIdd8ufI64l/la2hAE41XA43Kt6Bi2UZfy3MCKby20O0yDSHENkM/P9iBqAUL1wRgNQFan4qeYZEiCMFzs5GcxJIyX5LULSWHQt9Z8utrZPdtTfAGkSMBx8S1nD5zD2t/nlA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=LpcXY7D0Qn9/lHPEEz/SfuMrsgtPEGlefunqWPTLDvY=;
 b=JSMPXHjYjoEyQOCBGbeuSQ36IljApMPYjB7NRPImFdyJoclhOLQTHZfj/WdDieAlWir5RDCvwnU/cOccEuYkQbo4Zl54LYZ/z72BuubioFqDZEvNKC0JQD6rtBPNpd+fT0haNoLzs9RqRW+VjBEBViqJQ2sRIoQVj0OIwPtd7T8F3MgKz/nIvLEg3ntNVEp2LzQdv4gc3Jd4Vy/Fn2Iw2tJAxRinvw3XoAdWtW4KQpnFcMT0xB70e1FQvLlZ3Ky/Am6r9ut/wtm3zuuQAKXaqTZveYYFjuem6xpsymlEWWkqqQMwbGFcCqHf09KkOCYQTE4w7n7cYgnq7ytwHA3jZQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: citrix.com; dkim=none (message not signed)
 header.d=none;citrix.com; dmarc=none action=none header.from=suse.com;
Subject: Re: [XEN PATCH v7 49/51] build: adding out-of-tree support to the xen
 build
To: Juergen Gross <jgross@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
 Ross Lagerwall <ross.lagerwall@citrix.com>,
 Daniel De Graaf <dgdegra@tycho.nsa.gov>,
 "Daniel P. Smith" <dpsmith@apertussolutions.com>,
 xen-devel@lists.xenproject.org, Anthony PERARD <anthony.perard@citrix.com>
References: <20210824105038.1257926-1-anthony.perard@citrix.com>
 <20210824105038.1257926-50-anthony.perard@citrix.com>
 <2aaf0858-1602-be5c-77e4-2daa7fddc534@suse.com> <YWmzSkLdH5wtQ77V@perard>
 <f53e4d09-9f33-6dc8-8161-156b9eca4a6b@suse.com> <YW1Dhn+oEwvKgj04@perard>
 <70b8f320-bcd8-b864-f9de-a7ea35d53928@suse.com>
 <5a4df707-5b12-a471-e957-1a1c43340bff@suse.com>
 <9f3f6d5b-b920-911f-fea9-66fb36a09e5b@suse.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <c0b2ca25-5700-e915-471b-3816d12efbd6@suse.com>
Date: Mon, 18 Oct 2021 13:07:34 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <9f3f6d5b-b920-911f-fea9-66fb36a09e5b@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR3P281CA0028.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:1c::19) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: b15bfbc0-d298-4fc0-024f-08d992277dc2
X-MS-TrafficTypeDiagnostic: VI1PR04MB5472:
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB5472F46349686BD47B7A6C7CB3BC9@VI1PR04MB5472.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	GesojIiWnTXeYVZAEllJZiEpPHA0WcxyXP854jouxp++atao0sAAmVfxA+mMarjNQTlCsaYu7AoULr/HlMcKlxzF0BQZ8GcBgTb9x/U6eRCBk15aYbMUgnKJwXUkKHptyiQRLxiRj2n8YcEEowiccm75PAu8ljQYJs5X3D/RzWoCkztmxTShtQC84+ZG8PtxpFga5kn3kOQvst5aV/W2l7qLPkoEN2jd11AcgflQzPLm61xdXfKbVjyh3mAvLEfh6i795J050EwtuupqyOKBhHkpy69O7Js8LflKb0LYVotPBgKwj4u64ONIMMOKG+eN5ERof/IOf+ZCI5twWjWLAFA1X8STkSvWUDgwtz4cLBEJWNPZjW0UMBSv8NjosvItHuwx+FZ3KaY46okco2tM9I1zlT7OFf3ksXfZZNpF9/AxLOTqV1mhOtgtHbyKD89+s3oFSIOyp1+QE3gce7oLuKLGdeaIfJ4fylkUJCnby1AuSjd+cdKxLc2VPqwtMG0Vhrln+wPL1PVj2zkKpqBNgT23cr6k/lB1qa4IPKcaXN6RpIDfaarhWgEobGIpRftSZVY/EQn5WC/qpQOfMCGIOqfJZgw/3a+OuNHmQmVkx4TXk8Bt8i12yx17UOlmR0YJRPqhB2wWjRfAE0+lJo1nvxuEUinG/WKSUloZP9U7t0mavQ3Vcz1081pbDasL8wfDPW5EcKH+7U7e2t9IHZXeSIHPuIctdwyxGnkLRr0ID1FjYeR5bPC4ixR5PXq34oxa
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(66946007)(4326008)(66556008)(36756003)(66476007)(2906002)(7416002)(6862004)(16576012)(316002)(508600001)(8676002)(54906003)(38100700002)(83380400001)(956004)(53546011)(2616005)(26005)(8936002)(31696002)(31686004)(37006003)(86362001)(5660300002)(6636002)(186003)(6486002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?c2hHUEZOMGhNZ2tnaG81YUI1ZzEwMXd1dVU1djlnRXphKzJUZUEwRDRlZmc3?=
 =?utf-8?B?amZVNGhlRHlnUDZKVVlVckNaZ1JCYndud2RYWTFoSzd4dVBCWnhjQUluNVlq?=
 =?utf-8?B?eGRTM0hpaDcvWTNkWkduVktVYy9lY3hab2dTUlRTRkxoc0V0UFRLd2greUJ1?=
 =?utf-8?B?YjFKVGpjOEhaRWxxMEt6LzJ4YXV4SC9KOEZtcVN0Y3VBS08zL1lEYmxJQkFK?=
 =?utf-8?B?dng4cDExczI5ZEtkb2tJNitEak1ydWNLamVwMG1hMUpybVFBVWI4UkprSUFL?=
 =?utf-8?B?T3dKb1o4L2xDM0lSbXl4UzRXcmpRYWdQVm85Q243VEFFVXI5ZnZRQ2pxL1VQ?=
 =?utf-8?B?Y1hiNEVwUm42MnVHN0FvQXYyeGYyVnQ1WkJ4RmJsQm1GUVBuQTVYSUFnblZz?=
 =?utf-8?B?a3dualhNN011SzhBRlNYZnJwSm5SdVlCcWJpSVpNL091TTVwRkpUcGV1dWkr?=
 =?utf-8?B?S0U2RkdLZFcvWXgzU2FDQzdHRlZOaytyZVovVjhEQ09NMTVkNVlTbkNySTVC?=
 =?utf-8?B?cTc0UmdwVUZmTmMySThlN1dZaVRIYnFtQzdMdHk5cXZVdHZZNVg3U3htdnhU?=
 =?utf-8?B?STFPT0VMSWcrZDdUQUFEaGMwdkVST2tFdzk1UmtSWFlhTTJHWnpqelZGbUtB?=
 =?utf-8?B?ZjhJWlJFZEdrTGJoUStJNU1STkZGK1l0WnhJQVhFRVFhQlZnaEdmWFlmbHJa?=
 =?utf-8?B?OG5JYWVPQjMrQld3VTZHVHVoM0h4cHBxQmdSbHJ5TTFTZUFOeitZTnNPREw0?=
 =?utf-8?B?R2Q3MTRKcmVwaDRoZEN6MkVnZTNlZHpSSVV0WFFVbllLL0NDZ3llYmFGWlQ4?=
 =?utf-8?B?ZWZEOUxlekUyMXVOaWRlS3BDSXZwQ24wVzZ6cUNURkpLcGg3TWZrUkRaL25u?=
 =?utf-8?B?dmFOUFFISllMNnk4T1pQb24wNTdtdnFZamJjWk1sVHZHS1N1TTZkSWw4S0d2?=
 =?utf-8?B?aWNhdUJQZkw3OVRMeEdCT0NEODIvL3dHNU9oblZoZzFVdEV5dFpXcDc1enBv?=
 =?utf-8?B?WkFPUHd4T2JtMUJGdkJDRUcvUEovbDdXNjB0MkVqWkJTYndHUTJKY2p0dTI3?=
 =?utf-8?B?K3hZU0JlVTVnZVNaWHg1WGFJZC9mTTVJeThWV0lzYkEyWlBONVloekFwT0FC?=
 =?utf-8?B?ZFI3RncrbjZaUUgrQjRFVEM2dUI4MTRtbGVJZUcxd2ZuU0V4Tm1iRFZsaWJ2?=
 =?utf-8?B?UmMrcWlpaDgxbkxmd2l2QThMbmZ2VjFWZnFoamVWblg2LzN4TVU0NERXbzNi?=
 =?utf-8?B?dmtKM20vMHJuYmJvbUt2QU45dGs0OVFXbFd0RENhTVE4ZUpuN0tONENDRHBE?=
 =?utf-8?B?dnBvcjZYbEtyNXo1eS9DRElIK0NBR0U3SlpEU3R6UzVKVmpQZ204K2JtU0Rx?=
 =?utf-8?B?Y0hKbUgzVVBYTC84UmYyZDdpOEVKUDBsa0RXcHliRHFxUmxBWW15U1hic0ZW?=
 =?utf-8?B?QUczOTBHcTk1TEVhNFZrUEJ2K0ljcjdDTFVJam04OVhCalF5Q3FBRzdIZzVp?=
 =?utf-8?B?aWJHRmo1OVAwTDNVTG9ZWnBxc1ZDd242b21WN0ZpQTJ2VUowMUcxSmFiUU1H?=
 =?utf-8?B?TG5ubEJFaFg1ZkZpUFh6cFVYbHJlTFluNEg4R1h3ZXV3bjFFUUxxaXg2a2FL?=
 =?utf-8?B?V3VJZnAwZ05hcnJOL0Rab1pPMGJPYXloZy9jaHpiS0ZjU2d1M3FDbGVDRzdN?=
 =?utf-8?B?OTNrZmQ2dVlRclhMVi91TjdMUGxEaTFzMldmdTVvV2pndDYzQjRVMExVUFVR?=
 =?utf-8?Q?29o28YhFcli8zmpsIIG5bU7wNDoj+0fUmGwq7/Y?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b15bfbc0-d298-4fc0-024f-08d992277dc2
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2021 11:07:36.1611
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: bp2eJY2KtNCgm6SzTQtwJbG8ZRobcvSmAO8/onSHGc/E7RcpTdSvpJXOM1mo2rh1iZwwCGdNyA6lU9Vp21eRrQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5472

On 18.10.2021 12:40, Juergen Gross wrote:
> On 18.10.21 12:36, Jan Beulich wrote:
>> On 18.10.2021 12:28, Juergen Gross wrote:
>>> On 18.10.21 11:51, Anthony PERARD wrote:
>>>> On Mon, Oct 18, 2021 at 11:02:20AM +0200, Jan Beulich wrote:
>>>>> On 15.10.2021 18:58, Anthony PERARD wrote:
>>>>>> I have to think about that. I've made some further progress in order to
>>>>>> be able to build the Xen pvhshim without a link farm and notice that
>>>>>> nearly every source file needs to use "$(srctree)/$(src)"
>>>>>
>>>>> Oh, now I'm curious as to the why here. I thought use of $(srctree)
>>>>> ought to be the exception.
>>>>
>>>> In Linux, the use of $(srctree) is indeed the exception. This is because
>>>> we have VPATH=$(srctree), so when `make` look for a prerequisite or a
>>>> target it will look first in the current directory and then in
>>>> $(srctree). That works fine as long as the source tree only have sources
>>>> and no built files.
>>>>
>>>> But if we want to be able to build the pv-shim without the linkfarm and
>>>> thus using out-of-tree build, we are going to need the ability to build
>>>> from a non-clean source tree. I don't think another way is possible.
>>>
>>> Is there any reason (apart from historical ones) to build the hypervisor
>>> in $(srctree)?
>>>
>>> I could see several advantages to build it in another directory as soon
>>> as the build system has this capability:
>>>
>>> - possibility to have a simple build target for building multiple archs
>>>     (assuming the cross-tools are available), leading to probably less
>>>     problems with breaking the build of "the other" architecture we are
>>>     normally not working with (and in future with e.g. Risc-V being added
>>>     this will be even more important)
>>>
>>> - possibility to have a debug and a non-debug build in parallel (in fact
>>>     at least at SUSE we are working around that by building those with an
>>>     intermediate "make clean" for being able to package both variants)
>>>
>>> - make clean for the hypervisor part would be just a "rm -r"
>>
>> I fully agree, yet ...
>>
>>> Yes, this would require us (the developers) to maybe change some habits,
>>> but I think this would be better than working around the issues by
>>> adding $(srctree) all over the build system.
>>
>> ... developers' habits would only be my second concern here (and if that
>> had been the only one, then I would not see this as a reason speaking
>> against the change, but as said I've never been building from the root,
>> and I've also been building sort of out-of-tree all the time). Yet while
>> writing this reply I came to realize that my primary concern was wrong:
>> People would not need to adjust their spec files (or alike), at least
>> not as long as they consume only files living under dist/.
>>
>> So, Anthony - thoughts about making the default in-tree Xen build
>> actually build into, say, build/xen/?
> 
> Or maybe even build-<arch>[-debug]/xen/?

I'd be okay with build-<arch>, but things would become questionable imo
when considering further elements recorded in .config: Where would you
draw the line?

Jan



From xen-devel-bounces@lists.xenproject.org Mon Oct 18 11:10:28 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Oct 2021 11:10:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.212064.369805 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcQXB-0002tN-LR; Mon, 18 Oct 2021 11:10:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 212064.369805; Mon, 18 Oct 2021 11:10:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcQXB-0002tG-I2; Mon, 18 Oct 2021 11:10:25 +0000
Received: by outflank-mailman (input) for mailman id 212064;
 Mon, 18 Oct 2021 11:10:24 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=628V=PG=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mcQX9-0002t7-UE
 for xen-devel@lists.xenproject.org; Mon, 18 Oct 2021 11:10:23 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id fc7a8f64-3003-11ec-82d2-12813bfff9fa;
 Mon, 18 Oct 2021 11:10:22 +0000 (UTC)
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur01lp2050.outbound.protection.outlook.com [104.47.2.50]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-22-XZVxxYJQPICow_o86zk0Yg-1; Mon, 18 Oct 2021 13:10:20 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB6175.eurprd04.prod.outlook.com (2603:10a6:803:fb::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.18; Mon, 18 Oct
 2021 11:10:19 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.018; Mon, 18 Oct 2021
 11:10:18 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6PR0502CA0051.eurprd05.prod.outlook.com (2603:10a6:20b:56::28) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16 via Frontend
 Transport; Mon, 18 Oct 2021 11:10:18 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fc7a8f64-3003-11ec-82d2-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634555421;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=9Mk/9E7f886e4J5u++DJqz9PL0afmdhKT2a+g4quzVI=;
	b=fWYIizHkhuim9b8SLf3NVrfo1Drvpfl77/hxoHRUCVBepBOjlgb8bwkErbDgMv8Oq02wwC
	v9laTvmBFJTPKkiQ1Sz2AGVVuKqKo9DgYGMaLWOf/ipbrzs8X+s+ufpfk7Q25iN+aXeSwu
	V1wBGIDH7cvKOO3r+BnrLqx4SlJ9Xjk=
X-MC-Unique: XZVxxYJQPICow_o86zk0Yg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=MrRib/FwjjM3fqD7CP9CmJAyqKxCcsP6nbz0gUM9r8KGNrYMLGfT0Qk4P0dtNEk8pNXTnsnDB6U3yK8JmuB85UfBLw/2eWpl5okY6/5oHSohCrbttHG2DUFbubhIypfzru/NUnrrgBTty65jXO/wwJkvoHYadHgVRYoIfSe/40ruNO8QtobXjRGyttrpBcMA4bslt3VJy9B/i5BWrdqGTXsnpRvlw4uf9RmXZQkDcHig8F5dW2NeYhauBFRAWocDpOPBt/G+ozdtgJ9Zc2M6nmhDMxh5LXhohRxiHnsn37U5Z/A+m8OoQyezDik7Vo7vdNd0Go4BFj4bwS/QuOuECA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=9Mk/9E7f886e4J5u++DJqz9PL0afmdhKT2a+g4quzVI=;
 b=D+kRBH+kM32qDCKY5GXpfNI2wxt40+yegZhkMYmPD7QWTAs3ZCPveNoZbW8Oqwt+rjC2yQMaWKmEdLxA6GhzSN9wwvtB9sJZ+CKakaVp9oR5DZa+IlE8bYd2DtZ5d0OEPeQfORsLNX8/Vy59mAVa9NxFUlFM1/hHJFHrmpB2mYKOw8oHJcYpXdDuSRWYE4Xa5463p9PxAG5mOhV67Bq38sVXy2RkdWUqRmxGjSb0BB4ArG6OvFruHpzomF5ZX8vugTRp/9ItAGq990N2z+xwuZjtx/uMY21FIS8VgRkJ35JhVsbDGPVBQyRHhVppxIzS7PmzWQih2oY0Sl2B4LTlDQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: xen.org; dkim=none (message not signed)
 header.d=none;xen.org; dmarc=none action=none header.from=suse.com;
Subject: Re: [PATCH] x86/HVM: correct cleanup after failed
 viridian_vcpu_init()
To: Ian Jackson <iwj@xenproject.org>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Paul Durrant <paul@xen.org>
References: <55570db5-3823-8996-f69b-c2b00bcd4227@suse.com>
 <24941.20394.574634.548545@mariner.uk.xensource.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <16076406-9a32-5cdf-0ea6-72a8b21f420b@suse.com>
Date: Mon, 18 Oct 2021 13:10:17 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <24941.20394.574634.548545@mariner.uk.xensource.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR0502CA0051.eurprd05.prod.outlook.com
 (2603:10a6:20b:56::28) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 9a4abc5c-287b-4b52-c764-08d99227debe
X-MS-TrafficTypeDiagnostic: VI1PR04MB6175:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB61753895B7E982D3A3260ED4B3BC9@VI1PR04MB6175.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Kvwv+acW9kkd312zJzfyCU39eq19Ds+tikRx49pjLjVoOQ19K9cP4u1Mrq3sr/1cHFGcSyWTLcVLNCqrpKhXw/S/IdqXr7RrP4Ygok3yo9kOSA0Od3yq7ZyMgZKe/cWdMXImIlQrVHA6G3bc2XlXo60HOJVhFgzVlQ7C/6pbIi3/GLDELCcJaw+Z6WS7ltR2tp7zL/SqoNHaAPMz3z5uC6ui3UAqgXox0M9Wh3ShPeJWF7G50l8p+47UXWcYfKkalL2GNDaXMBunLtmNUXjBcPruEEwZsLX4f5OCi/HqJyEEK+hKsXMR/dXjtPiFMxIgK2aebp9MBRZgjjn/2qS8xCOEpGhYH0D7+qEHtyWNgW8uhiCa09apyMbBm/qOlacsfXu5qwClnGoquix5FGdTZV1y/BhyH1HC8AEdP5XFjDeoAqWvgFU3X8FakupKUB0w8wEaJN9mtWMPiiJdkvgVd0NYhcrCtBmfMgRB/jb3IAK2aq2UJ3060jgnWPMNCYMV6ZJzDl984EbH5gJFZUGDpwMwjTZXkKQqj1uPRzxdH7rEW45PjA/ewkhKB26y5aHt8FDyaIQ3pK0w7wSA9XjEAX33MguoZOMOytYJ0N5zAgBNOt4/Espoh2cSteQ18JmjIwfah9B5/XLYvR0yvFWt+ghliFD+gJ2jlIuwP/aRpGFR5l4ArPc4nU1bQvvOQ1FXdnnHWgWXCvhHBASbMkaPaf7r8CSZKomXpa5A1MQJpAkcZkzFL52vpb6sb3zY2b+7
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(66556008)(66476007)(4326008)(316002)(2616005)(956004)(53546011)(508600001)(16576012)(6486002)(86362001)(36756003)(38100700002)(2906002)(8936002)(31696002)(8676002)(26005)(66946007)(54906003)(31686004)(6916009)(186003)(5660300002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?VTF6N0Y0R1ZibnRadVZlVFF6OUNBMlNhQ2ROV3lJQy8yVW1idjR6RVBNMVRC?=
 =?utf-8?B?NVNOUFJSRWovb0xBUlhuSUgrWngzOFRZNURMMHBLcU5CZnErcDdDTXJTUWQv?=
 =?utf-8?B?ZDBqdEsxWkpLNENWUS9pZHFrOHZtVDNnWmZnWS9XWG5yMER1aFRqbHlqeTBj?=
 =?utf-8?B?c21nTEJISkcrT1N5VDd5ZnpIYmh3S09BK29rdHpzTHJUSDZxaW10RFI0eE9i?=
 =?utf-8?B?RzM5MEhwVXp3SXNuRHpxVTFCcGNpTDBLOHVoUXo1bVZ6cEFWSE0vN3laRWNt?=
 =?utf-8?B?ZGhMbC9SbkxTN2t3cVVIeG51ZnY0TDJnakNTQzlXdEJyamVGN29JaXhGVVlM?=
 =?utf-8?B?bTRzd3VqUzFsWC9XS2ZrM2ZMUlh3MTRTWmF1MGNWQU5HbU4yZnhwS2JMZVJk?=
 =?utf-8?B?M2NUNGdhMjkwYXBuZk5wNVAvVDczcEczMkxzenl5VFYyZjVLMjR5S0xDQWxO?=
 =?utf-8?B?VUYxVVdpWTJsQlRPL3RZTFlaVDl1dmRUdytpWDNlVDBLaDRnRCsxeUVNZkhX?=
 =?utf-8?B?K05JYWpFOE1lNkM4aWhxQnY5WEQ4K1BqYjJPVGJrRzNvTk1jYll6Q09PVUQ4?=
 =?utf-8?B?aCt0Nk5laStrOU93dDVYNGxGS3BwN0kzU3lLM2tKSXpVRGJSODNlYmNRS2NM?=
 =?utf-8?B?US9GNXVtZGFqNTQ0TkN2TG8zblA1cjFuckxXNml0V3RmTW85TEVKamRaS3Nu?=
 =?utf-8?B?aldNTXAxeTQxbVlNVjFCUUxIV09mb2xUQmE4czNlSmFVcWxETU9rL1Y5NlNu?=
 =?utf-8?B?QjFKZHpsbnZwUXNJNWJrYUIwaVQ1K2Y1NWYwMDhoOUIrOW0xdkI3cFRJN09R?=
 =?utf-8?B?cEN0ZTRmL2FBRXgvLzdjd3ZFME1SWXRiZ1RvTnVPaUNBWXp0VmhrbjFGbGFt?=
 =?utf-8?B?eTFEMmNVZ0hZak01RTkvSDZFRW82b0ZKUkdqMmQwYXhKc1lCeUduMHZvZFlu?=
 =?utf-8?B?Yk1OZXlLWDVCRExMYm1sdFhxYk5Gak0rUXpRdkRJeTBiM292T1ZrcmNhb3k5?=
 =?utf-8?B?dEVVeHQ4OEh6MHM2RTNDYXczVkZTMmlhNmdHRmhVeFkwVmZEOXJJdTVWREdY?=
 =?utf-8?B?alBjRG1GM29ZUkc4am1kZDM1cmhwL21UeS9OaHhBaERBckNwY242RkIyd3g0?=
 =?utf-8?B?K09PWkFwd3Y2YWgzUEdhU3pwRy9vdXlFMXJPZ25wc3g3QWNoRFB6RmQ4WGJa?=
 =?utf-8?B?N2FXSEh0bFN6aXhvT2FHS0MyMlZnSVBHUEZrU0lJL2NiaFkrT0Q1K0F3ME52?=
 =?utf-8?B?Y2crWVp0OHZRRHV3ejJnYXZ2L0psQnQ4b3JKbGZudkNEWEFGYmhUU3FwNy9u?=
 =?utf-8?B?NWhVTWxhZGRIUDMxT3BnbC9qZ0lSeC9wMTd6Zmxtak9VdDlOQno3MkNHeXN5?=
 =?utf-8?B?WUlPZE4vUHIrVTRTK3B2V1ZJN2xPSmlndE1tdDAyRFRjVThiZHVnUE1Od0th?=
 =?utf-8?B?aFZOUWxTQTBBSHFDUDN6d3ZPeXkrWlVRbGphbGNua29SZlBTYWhZUC9RQnVK?=
 =?utf-8?B?YXNkQjBxVUZUbU81ZUREbGZreU51R0wzRkVpTUFKa2lrMXh0cE9CSmdiM2Vo?=
 =?utf-8?B?dlI3S3BjVmtxVE9OVWg0WTc0dDNFMjRYSEs2cnB0Q3orREZRM0ZEaWVsTFVO?=
 =?utf-8?B?WTVHNHFjQ2dabVZpTG4wclZmdWpMeVNYMUFwT09MVFR0L01NUVIxTXovcENG?=
 =?utf-8?B?WEdqQTIrKzBRTjY3SE1TNlVYNFR0eG45L2dTRXpCL0JuV0pUVU9LQ0ZNSFJC?=
 =?utf-8?Q?peMfHgXc7m/W1qCSmCYe+QPy0uEs48Gl1xH0Ehm?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9a4abc5c-287b-4b52-c764-08d99227debe
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2021 11:10:18.8880
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 3Pznv8yF9Cpk3BO8X4A9bP5BBxQiDbQvY/y7D+mcTUuxtPhWHh2e66lRDahGwxTbolqy3ZZEDrM8JVpjse11ZQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6175

On 18.10.2021 12:42, Ian Jackson wrote:
> Jan Beulich writes ("[PATCH] x86/HVM: correct cleanup after failed viridian_vcpu_init()"):
>> This happens after nestedhvm_vcpu_initialise(), so its effects also need
>> to be undone.
>>
>> Fixes: 40a4a9d72d16 ("viridian: add init hooks")
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>>
>> --- a/xen/arch/x86/hvm/hvm.c
>> +++ b/xen/arch/x86/hvm/hvm.c
>> @@ -1583,7 +1583,7 @@ int hvm_vcpu_initialise(struct vcpu *v)
>>  
>>      rc = viridian_vcpu_init(v);
>>      if ( rc )
>> -        goto fail5;
>> +        goto fail6;
> 
> Not acomment about the patch; rather about the code in general.
> 
> I have not looked at the context.
> 
> But OMG, this is horrific.  How can anyone write code in such an idiom
> without writing endless bugs ?

Well, one of the reasons I dislike "goto".

Since you've been looking here - any chance of getting a release ack?
Perhaps also on "x86/shadow: make a local variable in sh_page_fault()
HVM-only" and "x86/PV: address odd UB in I/O emulation"? Aiui that's
going to be needed from today on ...

Jan



From xen-devel-bounces@lists.xenproject.org Mon Oct 18 11:20:41 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Oct 2021 11:20:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.212073.369816 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcQh1-0004S4-ON; Mon, 18 Oct 2021 11:20:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 212073.369816; Mon, 18 Oct 2021 11:20:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcQh1-0004Rx-LL; Mon, 18 Oct 2021 11:20:35 +0000
Received: by outflank-mailman (input) for mailman id 212073;
 Mon, 18 Oct 2021 11:20:34 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=3tpC=PG=citrix.com=roger.pau@srs-us1.protection.inumbo.net>)
 id 1mcQh0-0004Rr-4Z
 for xen-devel@lists.xenproject.org; Mon, 18 Oct 2021 11:20:34 +0000
Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id b4e39178-8db9-4949-a496-d1805436a860;
 Mon, 18 Oct 2021 11:20:32 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b4e39178-8db9-4949-a496-d1805436a860
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1634556032;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=+PpxqIBmpSYx4p5gA0OY+PQaWpWDoOllj221jJ+5rHI=;
  b=IHtqnBxUWu94x4lp2CzHnHMg7h0Jh3dChwNPWsyozV8zkWLEhZW/gx8s
   6C0jC0vlBUv8MxWmMy67ntrkvR7LgwzS5JV+GjWuv4IQ7Dzj8JxdzyCbB
   8lYpCbSwASaJvuoYhZr1cm6AhuH70bXnM4yIatwkHrnzs+hFtKSJKoPRi
   Y=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: J+9a7fkDSHlHMvDhPveA7cpB6qPxXznd9DfnDw0EX/WfFWoftYR/vStqBzQm9IAarzl6kHOpRA
 P87MVcugIBqmET6njZJ2L3WnN1/hAY9FXCIx7xXYhOB9B9Em754pJN4Ph46VNegSxcLq+FTih8
 0geBo7et+P1ta706t9zb2UR/8TOmhnskPR1+FPBH1mdC/ETjUiGytZkgqi4N5fcHXKe87g2/xN
 sXMeOVJNYNDvV8yiGtTu/Qj0y0PL2R8nJzpyiWnUGQoyY2Vajmt9EnmQlvxyjlkvINBmBcF8wp
 lvIAr22or0PHBXvR1lg6y1Wk
X-SBRS: 5.1
X-MesageID: 54986632
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:sfEls6LE6v6C8HTyFE+RC5IlxSXFcZb7ZxGr2PjKsXjdYENS3zUPy
 2IWDGqHPK2IM2ChKN0nbYiwoEoGvZfXz9dhHANlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s
 q3yv/GZdJhcokcxIn5BC5C5xZVG/fjgqoHUVaiUZ0ideSc+EH140Eo6y7Zg6mJVqYPR7z2l6
 IuaT/L3YDdJ6xYsWo7Dw/vewP/HlK2aVAIw5jTSV9gS1LPtvyB94KYkDbOwNxPFrrx8RYZWc
 QphIIaRpQs19z91Yj+sfy2SnkciGtY+NiDW4pZatjTLbrGvaUXe345iXMfwZ3u7hB3Xx8Jv+
 tdPv6e+WF5uDqqRgc8bSElxRnQW0a1uoNcrIFC6uM2XiUbHb2Ht07NlC0Re0Y8wo7gtRzsUr
 LpBdW5LPkvra+GemdpXTsF2gcsuNo/zNZ43sXB81zDJS/0hRPgvRo2XuY4Igmlr3KiiG97YS
 dokdwhEXi7DXCZrEVgYF6gAs8230yyXnzpw9wvO+PtfD3Lo5BN1+KjgNpzSYNPibdVYmAOUq
 3zL+0z9AwoGL5qPxDyd6HWui+TT2yThV+o6Fre16/pri1273XEIBVsdUl7TnBWiohfgAZQFc
 RVSo3dw6/hpnKC2cjXjd0PgsmC2vBwWYNRBSqoK71yU4azPsy/MUwDoUQV9QNAhscY3Qxkj2
 VmIg87lCFRTjVGFdZ6O3uzL9W3qaED5OUdHPHVeFVJUvLEPtalq1kqXJuuPBpJZmTEc9dvY+
 DuNsDQlz4saicoGxs1XFniW3mry+PAlouMzjzg7v15JDCskPOZJhKTysDA3CMqsyq7DHzFtW
 1Bfw6CjABgmV83lqcB0aLxl8EuVz/iEKibAplVkAoMs8T+gk1b6I9sMvGAjdR01bpxVEdMMX
 KM1kVkAjHO0FCDyBZKbnqrrU5h6pUQePYWNug/ogipmPcEqKV7vENBGbk+MxWH9+HXAYolkU
 ap3hf2EVC5AYYw+lWLeb75EjdcDm3BvrUuOFMuT50n2jtKjiIu9FO5t3K2mNbtisstpYWz9r
 r5iCid9404DCbKjPnSOrNd7wJJjBSFTOK0aYvd/L4arCgFnBHsgG7nWx7YgcJZihKNbiqHD+
 XTVZ6OS4ACi7ZEeAQnVOH1ldp31WpNz8SAyMSA2ZA760Hk/e4e/qqwYcsJvL7Ug8eViy99yT
 uUEJJrcUqgeFGyf9mRPd4T5oaxjaA+v2VCEMR26bWVtZJVnXQHIpIPpJ1O96CkUAyOrnsIiu
 Ln8hBjDSJ8OSl06XsbbYf6i1X2run0ZlL4gVkfEOIALKk7t7JJrO2r6ifpue5MALhDKxz270
 QeKAEhH+bmR8tFtqNSQ3PKKtYakFed6D3F2JWiD4ObkLzTe80qi3ZREDLSCcwfCWT6m466lf
 +hUka3xaaVVgFZQvoNgOL931qZitcD3rrpXwwk4TnXGa1OnVuFpLnWchJQds6RMwvlSuBesW
 1LJ8d5fYO3bNMTgGV8XBQwkcuXciq1ExmiMtaw4cBfg+St63LubSkEDbRCDhRtUIKZxLI54k
 /wqv9Qb6lDnhxcnWjpcYvu4K4hYwqQ8bpga
IronPort-HdrOrdr: A9a23:ytVZpqDYlTBRnnDlHeg3sceALOsnbusQ8zAXPh9KJiC9I/b1qy
 nxppkmPH/P6Qr4WBkb6Le90Y27MAnhHP9OkPIs1NKZMjUO11HYTr2KgbGSpgEIXheOi9K1tp
 0QDZSWaueAdGSS5PySiGLTc6dCsai6GeKT9J/jJh9WPH5XgspbnmFE42igYylLrF4sP+tEKH
 PQ3LsMmxOQPVAsKuirDHgMWObO4/XNiZLdeBYDQzoq8hOHgz+E4KPzV0Hw5GZTbxp/hZMZtU
 TVmQ3w4auu99m91x/nzmfWq7BbgsHoxNdvDNGFzuIVNjLvoAC1Y5kJYczOgBkF5MWUrHo6mt
 jFpBkte+x19nPqZ2mw5SDg3gHxuQxeokPK+Bu9uz/OsMb5TDU1B45qnoRCaCbU7EImoZVVzL
 9L93jxjesXMTrw2ADGo/TYXRBjkUS55VA4l/QIsnBZWYwCLJdMsI0k+l9PGptoJlO11GkeKp
 gsMCjg3ocVTbvDBEqp+1WHgebcEUjbJy32AnTr4aeuonxrdHMQ9Tpv+CVQpAZGyHqRI6M0kt
 gsCZ4Y542mePVmGp6VNN1xMfdfNVa9My4kEFjiaWgPR5t3cE4klfbMkcEIDaeRCdo18Kc=
X-IronPort-AV: E=Sophos;i="5.85,381,1624334400"; 
   d="scan'208";a="54986632"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Z0c4SlDj+sh74yafBKLG1EdN/OclO2KCewJEA7EBd6PeEZuLyrvlHiLFPTY8ZCqBMpZFXJJzYNkqT4Jta/gyo6SGtVzEf3NA9c2AkdHH6nqjFdUiNVq0uxkltQPmfyxof2LS6CJ/pNu9jJfhl1gHJHAKnszxZhmLrW3m0/4X0lOMjaPG87V2rPoWb3L1v8iUMg1WsGBQGYtemAGiTTLkk7wz6nHc/TL9klsu5MDdox+Z5q12CIlpPh6mMrplj2CMD+9w14y5D0lkAxx+QdWW0TNpTGEOe38ydawgRtxG/+3LcEpH/NXnIunU6LoJwmRm1RMgYTQ+HD+ub/K4JSITZw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=+PpxqIBmpSYx4p5gA0OY+PQaWpWDoOllj221jJ+5rHI=;
 b=kbuT1EgvDZd4LgmggbREUoi8gA9ZryNoeDqdgXPB5TC/QmV9R2zUQ4WFMeBnTZ+tXAw0WVHhumpjLpUpwNQWaakX9ujt87fiuF59gjruW+ACfBdzc8d+QaleXFyD1wCeE4wJMFOkclGKA/mfWlgwEMZnc5xr9MTvs3DsJJhq4GvOiEU89TT8ehbYTU2TNDglVqNX1tkfgP3S5XBYxkieGdoHmOCpo9IpwMtLmTlXnYb7fSy8nQ4GfB2Lg61p3sBSOvM6ioPrJ4ZDgY0LHtsscWXHlgO1KYPa9mB0N8r8+FRk0VUoP5zPVF2BSOr/BOiWlrySS2gdWhwq8u5Mq51PTw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=+PpxqIBmpSYx4p5gA0OY+PQaWpWDoOllj221jJ+5rHI=;
 b=CECM997RJbWTQk60/BOFF1AEkSxI64KcQrnvNQJQTxaZCdPpDA8xqGuJmvJZrWodIZWITS//mECk074TxrKh965NOXCieEfyy9jU0BTukbhtBpIzY+28uO39z2vI4Jb46A/NTGaZcK8ZpteA+9y5gA0fK6uV9OdxLZ5m+qn5PnU=
Date: Mon, 18 Oct 2021 13:19:55 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Andrew
 Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH v2] x86emul: de-duplicate scatters to the same linear
 address
Message-ID: <YW1YW8HJr6ttyd84@MacBook-Air-de-Roger.local>
References: <cf935e11-27c8-969f-9fb2-a5c0e85ccff1@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <cf935e11-27c8-969f-9fb2-a5c0e85ccff1@suse.com>
X-ClientProxiedBy: LO2P265CA0289.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:a5::13) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 2996230a-aadb-414a-bd47-08d992293a0d
X-MS-TrafficTypeDiagnostic: DM4PR03MB6190:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <DM4PR03MB61907604DC4AC3233E7606108FBC9@DM4PR03MB6190.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 8SXMaBU9tm2BP7B1Ckdl/uVg9LMapf3nYjfxdZdr7hyhubWh3EHvuvQTCf4QQQu7aU2DLlG9RPF0CM0Am2D4BJ9rEjqLGaJ3PhkfHNBwdgBK2OFHzlZXQafpXHYFTfmbaO6xlxVoHSEn/OtBWZSqI45triwbjnpKFRVcBhM9tfihH0Q4LVkVMUdSS6yf2IFLSnL8OZ+bVlE2spTKaSGZC4+ew+onGwijtr8204sYVlur8q/pZlmmsHKw+Ge9nekUBOrGf2DTzpuh+DKN/0Uu9F1iYnZqqjLOlQvuiT3gAcRn0+NEXjy0bgTNbT1sCZ5iSxw8y3YEliXohkFG0fXULLa5G3QUKrKbL8GiOVwy3FZ85gp4mxnANhfPWNxyQLVk383a/xjFTwm9CmzpC7sxByjFxXXPviKblXr06/Y16KoQxQuTaZYjhoRnidWfHxQN/f78FyOevjN5ITqWYYAK+UotyD6r2RTlh/4SBeqoKD+UBSdEdw5UfPZKOnmDg1VBGkJ+X5kMgpeh484iHZqJgegYa+DuG9VJoEvDTX5T0P6s7bKNd0OjoWLgH9kVkCV8bXnFJB4Kyvs8EUL4ttBY11baFhe4jDzaCJBVZQZBTA7nDEY6HXqKhwkWATnlghZPO3IIIoB5+MiX9+Nv63f7Wg==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(6496006)(82960400001)(4326008)(956004)(6916009)(4744005)(86362001)(316002)(8676002)(8936002)(5660300002)(6486002)(9686003)(26005)(508600001)(38100700002)(186003)(6666004)(83380400001)(66946007)(54906003)(66556008)(66476007)(2906002)(85182001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RzcxckUxKzBOUG9YcS9IWmpXSWZodnpxbDB6bVAxcXA0azdnSG1RR01ma1VW?=
 =?utf-8?B?TWR5R3V4YURmQm9mU0h6eTBZck9QWU0rcDQwb0p4NHpsc2E5NzhLaVBLa0k1?=
 =?utf-8?B?N2x4NlAxd2RTZXBLSlZMaUVPL1UxelJWcHBHdHVla3hjL2xWcXduc2Z0RVVv?=
 =?utf-8?B?a0FMSHpwNTg0TGw3UTdHNmxpZ0hEcjh5akwrdzh6VEJLU1Vja1kwbDZxRVdK?=
 =?utf-8?B?cWY0czNUYWYrR0hUWGtpT1ZSbUI3NVlqdy96QWdJNWFhcHRNTDhwWGdLNWk3?=
 =?utf-8?B?N3huN1Q1alQxOU9QbTB3WFlIT1cvNzNyUHZHQzF5b1RsM1pkRWs3enhsSEVB?=
 =?utf-8?B?RU5MbFZLekp5YnZycndiblpSZ3d3aTdZOTd5UVNEMGlRNTM2SjRveUt1ak5V?=
 =?utf-8?B?TUFZUXQ1OWg3SnZQQm1Lc29zTktMcFFydjJTS0lOSnZBaTgyVVhKbHorV2JY?=
 =?utf-8?B?U2ZRNzVQZUFlcWorVWI3Sm1SVituSUtDdFJCNmFUU1g1UDBOZ1Q0YXVWbS94?=
 =?utf-8?B?Umpad2thSGRtRCtUM0tUYXV1cUtrZVpJMW8wa2hiUFBvQkNFMERDRmVtMzJG?=
 =?utf-8?B?MGpId1o2ZkpmQkgrM3JER2RBQmRpSzcwZXFoSlFpd09WOEVxVk4xb2NsMkFQ?=
 =?utf-8?B?QXAvZ3M4NnRuYVBrSTFGeXMxbU42QVFjdlRSZ0xMS29kVGVwVHJFblVZL2FV?=
 =?utf-8?B?a293TWRhK2Q2QkZjMjR2bHhIZEZhMG9mL0VqeFZHZ3pjTWNzRDRUVFlDVXFy?=
 =?utf-8?B?ZStJdUI5NDBCeTRadVdZLzJ6WnJWMjZIOHR0K25XOHAxNHBNYXkxc1BGTEVD?=
 =?utf-8?B?aW5obmpDbjB3b2xZRUlvUzdadzY5dGs0NTZMcVAzbk1rRHZkV05VV1BBWFUw?=
 =?utf-8?B?MlFudnRKcWlQMGRpbUJLRktYMmI4WG9UeU5DU2NSRFhMSVMwVFducUo0NlNT?=
 =?utf-8?B?dVZiYWVMMTMvT2IvdmRDOHgva1RkQzk5c2tFRFBDUkNuSUZRak9uNndvOFJn?=
 =?utf-8?B?blIwcGQza042NFNXUnVsb2N0SlRJQkRkVy9maitJSTVMamtBdVVpKzh2YWRT?=
 =?utf-8?B?NU81N21XT0pOVWhHQlRBMGNUNXhJN3dPOUFlczZHMmx6djU2RjNKM2N0cnkr?=
 =?utf-8?B?Q3lRd2ZsWG1EQ0U4YUtNdkxiUGFCeVlSalc0U3l0ODl4OFkwMnRMZzRMeFV6?=
 =?utf-8?B?eWhKNGo4NnVqY24xY25la2h6QWp2SDdvQ01FQ3diV2JSd29FUW9MU1EzL1pU?=
 =?utf-8?B?MGI4ZkxMQ21wTlJ2enQ3VU9YL2hLUjE2RVR4aktsaExGZlBzalBDNDh5ZEda?=
 =?utf-8?B?Qm4vb2xselpsY0pIbktyZ0xzWFRzRk0vRDFaUTVRQk1MdjZjV0wrbmRCRVVX?=
 =?utf-8?B?S0NEendNcnNzeThZejdPbiszTzlFWFI4ZWU2Z1duNURsZEloN3BYMVpBb2Y1?=
 =?utf-8?B?VmIvaWtxaEdsWE1lVW54VWk2ZlYxMDg4Q1ppdldkRnVWbC9DTm9MUWRDc0x4?=
 =?utf-8?B?aHMyUlR4eHNrek9tZnNpYlI2d2NNQ3RMSWdZMFkxejQ3MEY4OWdLYloyd1BO?=
 =?utf-8?B?TGphUjNBZ2I1Z0gxNlFnTDFlRjA1UDZIbWVmM2dJNXU3b0wxMW81RW9qSlFM?=
 =?utf-8?B?YmJldmhtb0ovVXBMQnRSdnRXYnZtUjlCaFhva3VUcG91R3VuV3UwN0VtTHlX?=
 =?utf-8?B?MlUzV1lpSERSamY1NURDdHVycTd3SDlQYmNXYkZBVVN0akhRYVZHR25RZzdG?=
 =?utf-8?Q?vCdNtoAbE8AL3TxoMBMw6VV215Vi3Galf5VnnZP?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 2996230a-aadb-414a-bd47-08d992293a0d
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2021 11:20:01.6392
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: vklGlnDDMBGfT4ROcWqz+Tp/7I5d2/O4FQQvFh4en87lVVuqRqlmc1sOer6w1B58+kkr4aG+161vfOTe8GSyXQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR03MB6190
X-OriginatorOrg: citrix.com

On Thu, May 20, 2021 at 03:34:28PM +0200, Jan Beulich wrote:
> The SDM specifically allows for earlier writes to fully overlapping
> ranges to be dropped. If a guest did so, hvmemul_phys_mmio_access()
> would crash it if varying data was written to the same address. Detect
> overlaps early, as doing so in hvmemul_{linear,phys}_mmio_access() would
> be quite a bit more difficult. To maintain proper faulting behavior,
> instead of dropping earlier write instances of fully overlapping slots
> altogether, write the data of the final of these slots multiple times.

Is it possible for a later (non duplicated slot) to cause a fault
ending the instruction without reaching that final slot that contains
the written data?

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Mon Oct 18 11:20:41 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Oct 2021 11:20:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.212074.369827 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcQh6-0004iu-05; Mon, 18 Oct 2021 11:20:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 212074.369827; Mon, 18 Oct 2021 11:20:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcQh5-0004il-T6; Mon, 18 Oct 2021 11:20:39 +0000
Received: by outflank-mailman (input) for mailman id 212074;
 Mon, 18 Oct 2021 11:20:39 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=6zTk=PG=suse.com=jgross@srs-us1.protection.inumbo.net>)
 id 1mcQh4-0004Rr-Tk
 for xen-devel@lists.xenproject.org; Mon, 18 Oct 2021 11:20:38 +0000
Received: from smtp-out2.suse.de (unknown [195.135.220.29])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id ed0e0ac5-8489-424d-9e5c-584aec0fc897;
 Mon, 18 Oct 2021 11:20:37 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 860561FD6D;
 Mon, 18 Oct 2021 11:20:36 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id EA6B813D89;
 Mon, 18 Oct 2021 11:20:35 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id JcaYN4NYbWGzFwAAMHmgww
 (envelope-from <jgross@suse.com>); Mon, 18 Oct 2021 11:20:35 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ed0e0ac5-8489-424d-9e5c-584aec0fc897
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1634556036; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=9RkQOPvuyGo7/0XHeYwaUfiaUeLX87l/2H056MfR5Wo=;
	b=Ti5s7horyqBs/FG4bOTYTPaR21qFWnCx9rSfghNcQqWGqK5t/OEUwXDsHPwbE2HG2itPSW
	4zWO7bxHhzo2cHoFPVbj/FyK6y/iuwq/frTRM7w+mNnM27LcgCpF787RyjaxPMBXPNJ5J2
	oVJE+xuu6vJ4ACXmavcKkBV+KlpLxYs=
Subject: Re: [XEN PATCH v7 49/51] build: adding out-of-tree support to the xen
 build
To: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
 Ross Lagerwall <ross.lagerwall@citrix.com>,
 Daniel De Graaf <dgdegra@tycho.nsa.gov>,
 "Daniel P. Smith" <dpsmith@apertussolutions.com>,
 xen-devel@lists.xenproject.org, Anthony PERARD <anthony.perard@citrix.com>
References: <20210824105038.1257926-1-anthony.perard@citrix.com>
 <20210824105038.1257926-50-anthony.perard@citrix.com>
 <2aaf0858-1602-be5c-77e4-2daa7fddc534@suse.com> <YWmzSkLdH5wtQ77V@perard>
 <f53e4d09-9f33-6dc8-8161-156b9eca4a6b@suse.com> <YW1Dhn+oEwvKgj04@perard>
 <70b8f320-bcd8-b864-f9de-a7ea35d53928@suse.com>
 <5a4df707-5b12-a471-e957-1a1c43340bff@suse.com>
 <9f3f6d5b-b920-911f-fea9-66fb36a09e5b@suse.com>
 <c0b2ca25-5700-e915-471b-3816d12efbd6@suse.com>
From: Juergen Gross <jgross@suse.com>
Message-ID: <129b1339-df89-44e2-2467-77b60e113882@suse.com>
Date: Mon, 18 Oct 2021 13:20:35 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <c0b2ca25-5700-e915-471b-3816d12efbd6@suse.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="mCBhbbWkOksS968tEFJlrWSt5YleF9UtI"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--mCBhbbWkOksS968tEFJlrWSt5YleF9UtI
Content-Type: multipart/mixed; boundary="FGd6yOgwSrp0xz3vIgIyfRsWfTtKKK1S7";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
 Ross Lagerwall <ross.lagerwall@citrix.com>,
 Daniel De Graaf <dgdegra@tycho.nsa.gov>,
 "Daniel P. Smith" <dpsmith@apertussolutions.com>,
 xen-devel@lists.xenproject.org, Anthony PERARD <anthony.perard@citrix.com>
Message-ID: <129b1339-df89-44e2-2467-77b60e113882@suse.com>
Subject: Re: [XEN PATCH v7 49/51] build: adding out-of-tree support to the xen
 build
References: <20210824105038.1257926-1-anthony.perard@citrix.com>
 <20210824105038.1257926-50-anthony.perard@citrix.com>
 <2aaf0858-1602-be5c-77e4-2daa7fddc534@suse.com> <YWmzSkLdH5wtQ77V@perard>
 <f53e4d09-9f33-6dc8-8161-156b9eca4a6b@suse.com> <YW1Dhn+oEwvKgj04@perard>
 <70b8f320-bcd8-b864-f9de-a7ea35d53928@suse.com>
 <5a4df707-5b12-a471-e957-1a1c43340bff@suse.com>
 <9f3f6d5b-b920-911f-fea9-66fb36a09e5b@suse.com>
 <c0b2ca25-5700-e915-471b-3816d12efbd6@suse.com>
In-Reply-To: <c0b2ca25-5700-e915-471b-3816d12efbd6@suse.com>

--FGd6yOgwSrp0xz3vIgIyfRsWfTtKKK1S7
Content-Type: multipart/mixed;
 boundary="------------1D831B898F38E4F7E72CEE48"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------1D831B898F38E4F7E72CEE48
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 18.10.21 13:07, Jan Beulich wrote:
> On 18.10.2021 12:40, Juergen Gross wrote:
>> On 18.10.21 12:36, Jan Beulich wrote:
>>> On 18.10.2021 12:28, Juergen Gross wrote:
>>>> On 18.10.21 11:51, Anthony PERARD wrote:
>>>>> On Mon, Oct 18, 2021 at 11:02:20AM +0200, Jan Beulich wrote:
>>>>>> On 15.10.2021 18:58, Anthony PERARD wrote:
>>>>>>> I have to think about that. I've made some further progress in or=
der to
>>>>>>> be able to build the Xen pvhshim without a link farm and notice t=
hat
>>>>>>> nearly every source file needs to use "$(srctree)/$(src)"
>>>>>>
>>>>>> Oh, now I'm curious as to the why here. I thought use of $(srctree=
)
>>>>>> ought to be the exception.
>>>>>
>>>>> In Linux, the use of $(srctree) is indeed the exception. This is be=
cause
>>>>> we have VPATH=3D$(srctree), so when `make` look for a prerequisite =
or a
>>>>> target it will look first in the current directory and then in
>>>>> $(srctree). That works fine as long as the source tree only have so=
urces
>>>>> and no built files.
>>>>>
>>>>> But if we want to be able to build the pv-shim without the linkfarm=
 and
>>>>> thus using out-of-tree build, we are going to need the ability to b=
uild
>>>>> from a non-clean source tree. I don't think another way is possible=
=2E
>>>>
>>>> Is there any reason (apart from historical ones) to build the hyperv=
isor
>>>> in $(srctree)?
>>>>
>>>> I could see several advantages to build it in another directory as s=
oon
>>>> as the build system has this capability:
>>>>
>>>> - possibility to have a simple build target for building multiple ar=
chs
>>>>      (assuming the cross-tools are available), leading to probably l=
ess
>>>>      problems with breaking the build of "the other" architecture we=
 are
>>>>      normally not working with (and in future with e.g. Risc-V being=
 added
>>>>      this will be even more important)
>>>>
>>>> - possibility to have a debug and a non-debug build in parallel (in =
fact
>>>>      at least at SUSE we are working around that by building those w=
ith an
>>>>      intermediate "make clean" for being able to package both varian=
ts)
>>>>
>>>> - make clean for the hypervisor part would be just a "rm -r"
>>>
>>> I fully agree, yet ...
>>>
>>>> Yes, this would require us (the developers) to maybe change some hab=
its,
>>>> but I think this would be better than working around the issues by
>>>> adding $(srctree) all over the build system.
>>>
>>> ... developers' habits would only be my second concern here (and if t=
hat
>>> had been the only one, then I would not see this as a reason speaking=

>>> against the change, but as said I've never been building from the roo=
t,
>>> and I've also been building sort of out-of-tree all the time). Yet wh=
ile
>>> writing this reply I came to realize that my primary concern was wron=
g:
>>> People would not need to adjust their spec files (or alike), at least=

>>> not as long as they consume only files living under dist/.
>>>
>>> So, Anthony - thoughts about making the default in-tree Xen build
>>> actually build into, say, build/xen/?
>>
>> Or maybe even build-<arch>[-debug]/xen/?
>=20
> I'd be okay with build-<arch>, but things would become questionable imo=

> when considering further elements recorded in .config: Where would you
> draw the line?

Okay, this is a valid question. What about an environment variable which
can be used to determine the build directory (or a suffix of the build
directory)?

This could be used to cover other use cases, too.


Juergen

--------------1D831B898F38E4F7E72CEE48
Content-Type: application/pgp-keys;
 name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Transfer-Encoding: quoted-printable
Content-Description: OpenPGP public key
Content-Disposition: attachment;
 filename="OpenPGP_0xB0DE9DD628BF132F.asc"

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy=
cWx
w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O=
f8Z
d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y=
9bf
IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq=
G7/
377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR=
3Jv
c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA=
QIe
AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT=
hpw
dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0=
MbD
1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv=
oPH
Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v=
5QL
+qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ=
2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC=
QoL
BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr=
Wf0
teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC=
/nu
AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh=
ITT
d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm=
XBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz=
80h
SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC=
AcD
AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn=
FOX
gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1=
jnD
kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0=
N51
N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l=
otu
fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1=
tqS
EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA=
hsD
BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3=
g3O
ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5=
dM7
wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5=
D+j
LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm=
V2x
AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N=
Eaw
QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW=
nHI
s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR=
wgn
BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV=
bVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk=
pEd
IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA=
QAB
wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw=
Tbe
8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1=
vJz
Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8=
VGi
wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW=
svi
uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX=
zXs
ZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------1D831B898F38E4F7E72CEE48--

--FGd6yOgwSrp0xz3vIgIyfRsWfTtKKK1S7--

--mCBhbbWkOksS968tEFJlrWSt5YleF9UtI
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmFtWIMFAwAAAAAACgkQsN6d1ii/Ey/U
fQgAhh/PbUzu3Ffz0wOajIMGLxVL4Uoo9ILRbxe5jHxgUCEa+sjTyPc+wy6kjCEo3pyz1/mPKr96
GKU9kKrLlvLcThvQh3bYWYHeHmGqg7F2O+xXI598MVwb3ELiAeEmUw8kpzeyK7tf7aBNHPFY4Bff
kvlM/6oBSn9S3QPGE579sE9p+9mDL+HN1G/Igas1wONbkVu2gAeAJG1GcgTV+pVMnL9wpCjpSbkd
9scgIVtLgiGmITFkx/jO4O2nfuaqOVcv89pSpa9ogFCm/Edq9k/0fTr+QBchOo86//GMlbqAiy3v
Eg0koYgwA0uUs9iasijoW/OwxwSJkMzrODgM6PuXmQ==
=wOjp
-----END PGP SIGNATURE-----

--mCBhbbWkOksS968tEFJlrWSt5YleF9UtI--


From xen-devel-bounces@lists.xenproject.org Mon Oct 18 11:27:25 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Oct 2021 11:27:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.212089.369837 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcQnY-0005iT-N0; Mon, 18 Oct 2021 11:27:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 212089.369837; Mon, 18 Oct 2021 11:27:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcQnY-0005iM-Jk; Mon, 18 Oct 2021 11:27:20 +0000
Received: by outflank-mailman (input) for mailman id 212089;
 Mon, 18 Oct 2021 11:27:19 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mcQnW-0005iG-Um
 for xen-devel@lists.xenproject.org; Mon, 18 Oct 2021 11:27:18 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mcQnW-0003d7-To
 for xen-devel@lists.xenproject.org; Mon, 18 Oct 2021 11:27:18 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mcQnW-0005jn-S1
 for xen-devel@lists.xenproject.org; Mon, 18 Oct 2021 11:27:18 +0000
Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89)
 (envelope-from <iwj@xenproject.org>)
 id 1mcQnT-0005gx-I8; Mon, 18 Oct 2021 12:27:15 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date
	:Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From;
	bh=a/kGvnmYWhg1GxvH9ZcGpFKbseIOXzdNmvJ6uAuOmxQ=; b=M43zsTCWlA/z/Z6057oXnxJP/0
	UuqwyjoGWg+iNsHPMQnROBOta7jFE6z7zhadDgD4OenISNr7FiQ8BWcVT6kUysn8mgZvo4lNmn4yL
	u64ZBg1E3sTFX8FqszOy4QKi5YqZ+d7yKyMTCu+Ze+aXPur7VKQAPDG12iU6izxlb6Wc=;
From: Ian Jackson <iwj@xenproject.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <24941.23059.261983.36065@mariner.uk.xensource.com>
Date: Mon, 18 Oct 2021 12:27:15 +0100
To: Jan Beulich <jbeulich@suse.com>
Cc: "xen-devel\@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
    Andrew Cooper <andrew.cooper3@citrix.com>,
    Wei Liu <wl@xen.org>,
    Roger Pau =?iso-8859-1?Q?Monn=E9?= <roger.pau@citrix.com>,
    Paul Durrant <paul@xen.org>
Subject: Re: [PATCH] x86/HVM: correct cleanup after failed
 viridian_vcpu_init()
In-Reply-To: <16076406-9a32-5cdf-0ea6-72a8b21f420b@suse.com>
References: <55570db5-3823-8996-f69b-c2b00bcd4227@suse.com>
	<24941.20394.574634.548545@mariner.uk.xensource.com>
	<16076406-9a32-5cdf-0ea6-72a8b21f420b@suse.com>
X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu)

Jan Beulich writes ("Re: [PATCH] x86/HVM: correct cleanup after failed viridian_vcpu_init()"):
> Since you've been looking here - any chance of getting a release ack?

I don't think one is needed[1], but FTR

Release-Acked-by: Ian Jackson <iwj@xenproject.org>

> Perhaps also on "x86/shadow: make a local variable in sh_page_fault()
> HVM-only" and "x86/PV: address odd UB in I/O emulation"? Aiui that's
> going to be needed from today on ...

I assume these are bugfixes too ?

[1] I think I will send out a mail clearly stating the current state
of the tree.

Ian.


From xen-devel-bounces@lists.xenproject.org Mon Oct 18 11:38:39 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Oct 2021 11:38:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.212097.369848 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcQyP-0007Fx-NZ; Mon, 18 Oct 2021 11:38:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 212097.369848; Mon, 18 Oct 2021 11:38:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcQyP-0007Fq-KZ; Mon, 18 Oct 2021 11:38:33 +0000
Received: by outflank-mailman (input) for mailman id 212097;
 Mon, 18 Oct 2021 11:38:31 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=7EWR=PG=gmail.com=xadimgnik@srs-us1.protection.inumbo.net>)
 id 1mcQyN-0007Fk-JO
 for xen-devel@lists.xenproject.org; Mon, 18 Oct 2021 11:38:31 +0000
Received: from mail-wr1-x431.google.com (unknown [2a00:1450:4864:20::431])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id f494cf52-3be0-4b99-b1a6-78482fd382be;
 Mon, 18 Oct 2021 11:38:30 +0000 (UTC)
Received: by mail-wr1-x431.google.com with SMTP id r18so40792913wrg.6
 for <xen-devel@lists.xenproject.org>; Mon, 18 Oct 2021 04:38:30 -0700 (PDT)
Received: from [192.168.1.186]
 (host86-165-42-146.range86-165.btcentralplus.com. [86.165.42.146])
 by smtp.gmail.com with ESMTPSA id o6sm15570535wri.49.2021.10.18.04.38.29
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Mon, 18 Oct 2021 04:38:29 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f494cf52-3be0-4b99-b1a6-78482fd382be
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=message-id:date:mime-version:user-agent:reply-to:subject
         :content-language:to:cc:references:from:in-reply-to
         :content-transfer-encoding;
        bh=BH8Y0dm5cM2PeXjuRhSDN9eE48XKEYhtXBA8igrCSb4=;
        b=guRwS9hKrjE1uqFRZXayIrWo4uZveFgY2NnQhPAfTXDikMVhJqXl+9E1IhgKASAnUR
         0y0OjmCM0MzfIZpaqPWibbsB5/GWkXk46HKcJ6lCZWizVzL6wZVAQxB74WqmoTPtbFPb
         IWkB+kaw0ZZjUfT2l7+At/Cmxazsqf07N0CuSGZjVOi0sGFFzaU1PXn97hwPLNgFICNy
         FvYdyaJvj20k1oqyFCS5MaBhdlR97fUdDwvBKZKW28YDlz5xnhrDCe8ezDg8IIlLml/V
         wwIRz4rHRnZgKXGlmdFCODUwuJIiXm96CWGXT4W7418NLnpCzPSdlLX4pr9xjGItlqGU
         58iA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:message-id:date:mime-version:user-agent:reply-to
         :subject:content-language:to:cc:references:from:in-reply-to
         :content-transfer-encoding;
        bh=BH8Y0dm5cM2PeXjuRhSDN9eE48XKEYhtXBA8igrCSb4=;
        b=R332i15zCletv/6h4KFr3vKli2sVAB2qvBYTr2XRI588ldcQQBuV0S7oYE4RBl+lbL
         2/oCnN8FWhL2R+YkJFGoelJKAZJ+0WyIHkZdp7NxKWkNxp568w3sSNRcq9YmsvaUOFjf
         xYLkZ4THiyKgjCPHKNetEM9fUPJ4Wzn1D6d5LL5rIilgztU+2F8xJZIetZCC5exIrkgF
         LODpOfYuEFDXZcnPvegLTWwNxcW8VOlBklCTTfl0Mh5qhfDm0hJZcpdM7TgTx8l6kij7
         LbyHNjbRM9w5QrAjwzbvZEu0q7Yb1R39ASo1GZwQN1C7fNKtp+EfB5y8nARgKNSBQObO
         3cZA==
X-Gm-Message-State: AOAM533Wze/8XIVnpBGlRnxauTfl19wMbdWWOa5jO96PRr48uoIjrMaf
	eQ7fdjqmCzvh1nkUwQhEt8c=
X-Google-Smtp-Source: ABdhPJx6FeHF4uV+hXQ9PhKI1oscAqy1pJtGhECpUPhewimvx9VhysZe+GIvN/tYCpVP4WZLDvZK7w==
X-Received: by 2002:adf:ca10:: with SMTP id o16mr33931603wrh.212.1634557109814;
        Mon, 18 Oct 2021 04:38:29 -0700 (PDT)
Message-ID: <7e4ba3ef-0c39-eb90-bd94-8320f6c06104@gmail.com>
Date: Mon, 18 Oct 2021 12:38:28 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.2.0
Reply-To: paul@xen.org
Subject: Re: [PATCH] x86/HVM: correct cleanup after failed
 viridian_vcpu_init()
Content-Language: en-US
To: Ian Jackson <iwj@xenproject.org>, Jan Beulich <jbeulich@suse.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Paul Durrant <paul@xen.org>
References: <55570db5-3823-8996-f69b-c2b00bcd4227@suse.com>
 <24941.20394.574634.548545@mariner.uk.xensource.com>
From: "Durrant, Paul" <xadimgnik@gmail.com>
In-Reply-To: <24941.20394.574634.548545@mariner.uk.xensource.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 18/10/2021 11:42, Ian Jackson wrote:
> Jan Beulich writes ("[PATCH] x86/HVM: correct cleanup after failed viridian_vcpu_init()"):
>> This happens after nestedhvm_vcpu_initialise(), so its effects also need
>> to be undone.
>>
>> Fixes: 40a4a9d72d16 ("viridian: add init hooks")
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>>
>> --- a/xen/arch/x86/hvm/hvm.c
>> +++ b/xen/arch/x86/hvm/hvm.c
>> @@ -1583,7 +1583,7 @@ int hvm_vcpu_initialise(struct vcpu *v)
>>   
>>       rc = viridian_vcpu_init(v);
>>       if ( rc )
>> -        goto fail5;
>> +        goto fail6;
> 
> Not acomment about the patch; rather about the code in general.
> 
> I have not looked at the context.
> 
> But OMG, this is horrific.  How can anyone write code in such an idiom
> without writing endless bugs ?
> 

Fairly easily. I think this is the first one due to an incorrect exit label.
Using such an idiom in the Windows PV drivers had meant many issues 
could be easily debugged without further code modification because you 
get an fairly instant audit trail of the route out of any failure condition.

   Paul



From xen-devel-bounces@lists.xenproject.org Mon Oct 18 11:46:17 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Oct 2021 11:46:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.212107.369860 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcR5o-0000Jv-MV; Mon, 18 Oct 2021 11:46:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 212107.369860; Mon, 18 Oct 2021 11:46:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcR5o-0000Jo-Is; Mon, 18 Oct 2021 11:46:12 +0000
Received: by outflank-mailman (input) for mailman id 212107;
 Mon, 18 Oct 2021 11:46:11 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=3tpC=PG=citrix.com=roger.pau@srs-us1.protection.inumbo.net>)
 id 1mcR5n-0000Ji-5Q
 for xen-devel@lists.xenproject.org; Mon, 18 Oct 2021 11:46:11 +0000
Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id c262a53e-2a3d-4c1a-88fa-26783c841b31;
 Mon, 18 Oct 2021 11:46:08 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c262a53e-2a3d-4c1a-88fa-26783c841b31
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1634557568;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=1gkF3kswacgJ2yC4f/gP8wNsUCZXuYplBY+aq4y9jm4=;
  b=YShnsFc7vBRBwEvZOlZmbjO0Y4oKElKTn07AiyJ5S+EDpK5Sndo9OP16
   ApRGqvmBlCjx64PdYR/qpue9umDuhs73lIw6Py1X3Sz5E3MkxRms2cyri
   AtbdJhdeP22Z+9VnQDuvs+nYZzV2Q7vilVmWv9rRLVkxm6a0odlyDjBk4
   8=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: JBnknY3CC1V97fTmYGZpkXQwL6u5AtuVBTNzHzWgp9VdRks3E6zbAzkOTh1Oddo2Q6rAiUEnLv
 sA+g7SbAYJ/ywfE9SWHmnnc/PPGkFA4cTKW19MUmZ0IH0HhA2cR239vPh4ZKNx5E+qyHWSzErJ
 oNa3+5PDbm+k+MTcY7N1MTJIRBV8ORS2L6xVx+9cmejlZikd/nrzjMOQVpz8EC0V56HPoTpAdO
 l6wB2Y9MJNLW9iO06zCuLDVyvybXAm6UNqnsHukJGGl+WtyoTNzaW7xc0nRq72VdGen919KhfX
 DqJYxsE8K4NKea/KqTSnFg0h
X-SBRS: 5.1
X-MesageID: 55412489
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:ZMU/eqKV/xfW4ik6FE+RCpIlxSXFcZb7ZxGr2PjKsXjdYENShDUEz
 WZOWGmGM/jZazSmKogjbI62/BgFsJKEn4RnHVNlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s
 q3yv/GZdJhcokcxIn5BC5C5xZVG/fjgqoHUVaiUZ0ideSc+EH140Eo6y7Zg6mJVqYPR7z2l6
 IuaT/L3YDdJ6xYsWo7Dw/vewP/HlK2aVAIw5jTSV9gS1LPtvyB94KYkDbOwNxPFrrx8RYZWc
 QphIIaRpQs19z91Yj+sfy2SnkciGtY+NiDW4pZatjTLbrGvaUXe345iXMfwZ3u7hB2Vx/5W4
 +xL6qX3SCwGYLOSlMUmbRZXRnQW0a1uoNcrIFC6uM2XiUbHb2Ht07NlC0Re0Y8wo7gtRzsUr
 LpBdW5LPkvra+GemdpXTsF2gcsuNo/zNZ43sXB81zDJS/0hRPgvRo2XuIMBhmtg16iiG975R
 /Ufdh1SaijtOR9SHQwlD708uqSn0yyXnzpw9wvO+PtfD3Lo5BN1+KjgNpzSYNPibdVYmAOUq
 3zL+0z9AwoGL5qPxDyd6HWui+TT2yThV+o6Fre16/pri1273XEIBVsdUl7TnBWiohfgAZQFc
 RVSo3dw6/hpnKC2cjXjdwHgjlmvhxhDYp1ROMJk9l+B65Hq7AnMUwDoUQV9QNAhscY3Qxkj2
 VmIg87lCFRTjVGFdZ6O3uzL9W3qaED5OUdHPHVeFVJUvLEPtalq1kqXJuuPBpJZmTEc9dvY+
 DuNsDQlz4saicoGxs1XFniW3mry+PAlouMzjzg7v15JDCskPOZJhKTysDA3CMqsyq7DHzFtW
 1Bfw6CjABgmV83lqcB0aLxl8EuVz/iEKibAplVkAoMs8T+gk1b6I9sMvGAjdR01bpxVEdMMX
 KM1kVkAjHO0FCDyBZKbnqrrU5h6pUQePYWNug/ogipmPcEqKV7vENBGbk+MxWH9+HXAYolkU
 ap3hf2EVC5AYYw+lWLeb75EjdcDm3BvrUuOFMuT50n2jtKjiIu9FO5t3K2mNbtisstpYWz9r
 r5iCid9404DCbKjPnSOrNd7wJJjBSFTOK0aYvd/L4arCgFnBHsgG7nWx7YgcJZihKNbiqHD+
 XTVZ6OS4AGXaaTvJVrYZ3Z9RqnoWJoj/3s3MTZ1ZQSj2mQ5YJbp56AaLsNlcb4i/e1l7Ph1U
 /haJJnQXqUREmzKq2YHcJ3wjI1+bxD31wiACDWoPWokdJl6Sg2XptK9Jlnz9DMDBzacvNclp
 +HyzRvSRJcOHlwwDMvfZP+14Um2uHwRxLB7U0fSe4EBc0Tw6ol6bSf2i6Zvcc0LLBzCwBqc1
 hqXXkhE9bWc/ddt/YCQ166eroqvH+9vJWZgHjHWveSsKC3X3mu/2oscAuyGSi/QCTHv86K4a
 OQLk/ylaK8bnExHupZXGqpwyf5s/MPmorJXw1g2HHjPaFj3WLpsLmPfgJtKv6xJgLRYpRG3S
 gSE/dwDYeeFP8bsEVgwIgs5b7vciaFIy2eKtfllcl/n4CJX/aacVRQANhaBvyVRMb9pPd532
 uwmosMXt1SyhxdC3gxqVcyIG7Bg9kA9bpg=
IronPort-HdrOrdr: A9a23:W9dgcqinqfDuFAR7lPCo1AvAq3BQX0F13DAbv31ZSRFFG/FwyP
 rAoB1L73PJYWgqNU3I+ergBEGBKUmskqKdxbNhR4tKPTOWw1dASbsN0WKM+UyDJ8STzJ856U
 4kSdkCNDSSNykFsS+Z2njALz9I+rDum8rJ9ISuvkuFDzsaE52Ihz0JdTpzeXcGIjWua6BJcK
 Z1saF81kadkDksH46GL0hAe9KGi8zAlZrgbxJDLxk76DOWhTftzLLhCRCX0joXTjsKmN4ZgC
 T4uj28wp/mn+Cwyxfa2WOWx5NKmOH5wt8GIMCXkMAaJhjllw7tToV8XL+puiwzvYiUmRsXue
 iJhy1lE9V46nvXcG3wiRzx2zP42DJr0HPmwU/wuwqrneXJABYBT+ZRj4NQdRXUr2A6ustn7a
 5N12WF87JKEBLphk3Glpn1fiAvsnDxjWspkOYVgXAae5AZcqVtoYsW+14QOIscHRj99JssHI
 BVfY/hDc5tABCnhk3izytSKITGZAV3Iv7GeDlMhiWt6UkXoJgjpHFogPD2nR87heQAotd/lq
 P52gkBrsA6ciYsV9MPOA42e7rBNoX8e2O9DIusGyWUKEgmAQOEl3el2sR/2AmVEKZ4uKfa3q
 6xFm9liQ==
X-IronPort-AV: E=Sophos;i="5.85,381,1624334400"; 
   d="scan'208";a="55412489"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=XfHkCbKCJnO6Q8QuM+fitZu0OV9LwLtI+VcdZeeqHimNNA41qhVG7KvelL0xiYUZ2P+WSCfpOv96yMT24YzZBnG5eTbDqCPtE3EDOb1fvmwygBGBzETpBWWcvqVN4SuE8llKAEPSg2rwMApaXwa538km0dUMwmqYoDdxNSg5W9jaOcYS/O3Ywled/JBBNW+oSsSZct6V+S+k69uHco0hdKktNG5gjq5QjJXevzqsJe+OTXqWyZCsiN6Dj99fGMKnl5oSDprVOYHhETd/ZtpXmO6BNaNetefCJeZ/op2Kwo0Q1b3A738SC4kfStcb1KF8o/igh2ElEBWHN6lvicAt4w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=DcYuhL0Sw6ybNQmZXVMzlvwa2CaGB10Vwt71/KMmJss=;
 b=PaaWC+ZpnmE5w0rf7jhig7WzqtEYdJBteDgkaQd2q+Xz3yMI29Yr0G/QFhlIOHJN6YXhHUNYWPIVZdy6xU7I52vd98bOu3+i174uwAUd0T7ex3yg4ZKwWMy31CJ52Ww5a32lxgNDblhQzMpmeHK1v1ETQVtSSr2PmGENHtmUQpVyqqNnsGMXPK90cmCUe8HJ5DZyfCg5rl+p9WcnXvJ+jO2Qrv3xf/xZKd4NsGz8pdnxh61yrVi80b9LDwsB8kGHLPWdpH2/GOHA+Xc/q+3/a+ua3bMVtjujefv1UzUpjtXdo8BGHZ1YLNl2BDcaRqwqWmFh0Tu0431McFUDN8MMMw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=DcYuhL0Sw6ybNQmZXVMzlvwa2CaGB10Vwt71/KMmJss=;
 b=NCyLoq+xvUWJVt1lPeV9O3En+lCgEG2Oe89dTJDnPwqkYXiAtmKCqlYy4TxO3hW6K+hwcR7wmLApzQOWMqsLe2TZ9vFtJk0HQW9bdzW0Lqq7mXgOvFLk7yDrGdrWDO8xHWeNJVGKOLB2rTQaerM9488aWohE+Fe3dn2WIr1vmtM=
Date: Mon, 18 Oct 2021 13:45:29 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Wei Liu
	<wl@xen.org>
Subject: Re: [PATCH] x86/CPUID: don't shrink hypervisor leaves
Message-ID: <YW1eWeFls5igZcHu@MacBook-Air-de-Roger.local>
References: <0f5fe8d3-4c43-e60f-c585-67b2f23383ab@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <0f5fe8d3-4c43-e60f-c585-67b2f23383ab@suse.com>
X-ClientProxiedBy: LO2P265CA0282.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:a1::30) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 8b8d33d1-5a39-4574-9119-08d9922ccc07
X-MS-TrafficTypeDiagnostic: DM6PR03MB4220:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <DM6PR03MB42203252AF7D1136B9DDC81C8FBC9@DM6PR03MB4220.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 1u5uSTraTwzPIyJenJZ7A4wt/Rk5Nt6YPzQK37lmDGbGy7AbLZOZc80+u992CDaXJ1hplcmoA13IrbUynMdcjuGYOzbSmwSI0h04wdoBcxZ7H9x+7eXjI6caDs983MQz1WntkD/cEfi8BRJeGMnKQucUV2gDKJRaPzjriKpXOxK+bQvyveiUVueeAPHYA/aIv20f79yhMq2nvEoNQ+fm3h1SFk++1CYwoEYyvKtUSwDhIyfTXewPYAgC9HrOAs6h3yrWDejxShdrovJD12AZJR5G6KZVqPFJ4JmdvcIdlYW/deibbQPqcux+jHLlkMOH9Z4UArpKVhLImAZTNuD4SqsILdBJzDcEKua3cpZSCejshR5JCOBcJWA09EG8asVcZPQ5Elv7pqA5AcOYJwUIH81r1J+OWQGWCFA/7JEzXX+HWqgFC+4bCqBqfhRoosiqf65v+d75ekQANHF5Azb3mSVYkDjsVkc9nKq5c0wJ6km4n68B95Iz1ReM/mbb7RfQs95MLabem7me1k4kiUMfI+IkKEdWUcEx+2v2OqhAsYeyAz0PpKq1qiDyCvvRkc/naJcOtu6RovSILK9vkwgQhxmjHMcUBBEcBoGZSuMDXsCni+yYtkhmOIffu22Le1Dg5JjRQ6rUPeFHzI8syMRa1Td6qLwsHzMrvD6a5N07WVXW/tHn0fvV8CpifVDzNMNgxc30wXSNEUCNvhJU6Fq/cQ==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(54906003)(110136005)(6496006)(66476007)(86362001)(66946007)(186003)(6666004)(83380400001)(508600001)(66556008)(6636002)(6486002)(85182001)(956004)(8936002)(316002)(82960400001)(9686003)(26005)(5660300002)(4744005)(4326008)(8676002)(38100700002)(2906002)(21314003);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?a3ozbG4yNlFpa2dhNGdKSmRIT3psTDFweUV3SDdENnR2eEdTSmhEa1lvNndB?=
 =?utf-8?B?QXUyRWdJZmord1JPNzV1eUVWUm45N0pPV3paNWVncWNLMHorZ3I3NkNyUFNl?=
 =?utf-8?B?SmNXak1IZGpLYUhLeFhxVWRrVU9qMDBoQk1aeG1pWHc2eFFIUytvSG55OWpL?=
 =?utf-8?B?b0hFQ0JJRXpZUDczOTkrWFRPNTdKRjdTejJpem01c1FWUExXU215RDNwU1RT?=
 =?utf-8?B?YTI0Mld2WWxpc3lDMjVQTFozazByOXA5Zkl3cGNGNVhVRFBUZlFQQ1hXVzFU?=
 =?utf-8?B?Vzhjc0lqci9ndGhZL2FjdWROWk5sbmFhb1dvenNRNkF5dWdLRTBoSDNWaTN5?=
 =?utf-8?B?cWxXTCtqMXFwK0h5QXkvR0l1OXRDaC9xV0c4cGVxYVNsczAveU1ZZ013bzVK?=
 =?utf-8?B?SFZpd3pHejhHVmdMY3hZMUYzTmV6Tm1VZmVmd2lpcldnaXlpNTRVUVg2bXho?=
 =?utf-8?B?cVlEbEFJcHF6US8xNFVuRmhqZk1PengzVXRnaFkxaW9EaFdKUUExdnptWXF6?=
 =?utf-8?B?bWlmdzZOUnQwaUl1TDBoVC9wMFJzOURCUlQ3Z2o1amgwdlpOSVJuQzYvYUlk?=
 =?utf-8?B?YTV4dDBiQVhWYVQrZ2xZWW9xRTIrWTR0NGduVXRqVHpqemZraGs1d0crSzJQ?=
 =?utf-8?B?Rm1ocUJ5NkxmeEZ5bEJLQUF5WFJReTVsQjZJKzRqWW1KMDgwQlRQRkRnbUoz?=
 =?utf-8?B?M1Bmbml3MVlEYUFKNmhjVUg0T3pnTU1IelVjRnNnMDkwaFdqRURIenBXSHVl?=
 =?utf-8?B?MDNxbSt6bTVEWVVPRVJtdzRSdU5XQXNsQTFJc0x6eUU5c1FydjJRN0FiQk5G?=
 =?utf-8?B?Z0ZUMUpVSTE1T0xocGlvTkRXaDQ2LzQ3aHoxVGdjSTd6UjFJOWJYSk4wWXky?=
 =?utf-8?B?TmZQZSt3cjFPZ091TDlzbUZmV0o2dWNSK3hZcEFnNy83SERwMmZRbm80T3Z1?=
 =?utf-8?B?Mk5TRzU2QmhhWTdyM1FDRkU0dG1TUXJOdnJMdklKM216NE5DK2FYM29nOGs2?=
 =?utf-8?B?SzkvbFNqQkRjR1p5c0RwYnJEUnJOZ2ZjRFJHTUM5VnR4bGNjU3BYditLMG11?=
 =?utf-8?B?elpRd3JHeHdvVU05dlFsMzhXMGtEQ0JiNFg4YTIrVDV5QVZjVTJSYUxTdlFN?=
 =?utf-8?B?M215T3gwOUdmRUV1VUl2aFVTRFNsdUNaZlB1b2dKZVR6eit2cnppditWYWZQ?=
 =?utf-8?B?Tm5hTWxONjBQb3pUL2hrb0ZNZ043YmFFY1RranlGRTk3VnRMNXVSUHdrcnV0?=
 =?utf-8?B?RExPbEJ3TVpVWi9LRU5VcVNUbHZhVzhzb3JRdnUwcmY3ZU1rd3RJdWFZTmk1?=
 =?utf-8?B?SUhwWDcwcEFZVXRIT2VoVS83RXk4OXZhd3ZhYm1kQTFRWGY5bmJ0L2oxQm9W?=
 =?utf-8?B?K0MzdjRscDMxYzE3NnB6QlJJbFFwUFljUDU2cGYvLzNzemdVS09wS3FBYno0?=
 =?utf-8?B?WEE2dVRFTzFBa1ZEVWQycXYwMkh4bUF3T1BockZ6REZzYSs0UXpxWVRXS0Mr?=
 =?utf-8?B?V1JQVHM5WVNyTWFKS2lZNFg4b2dWUWJxQjh5cW81SmZseWpkRWZrUS9YVlZl?=
 =?utf-8?B?QXBHU2VBS1JSV2swcm0zMlhvMnVNQnR6aFdOVncxbEpFa2FtNlQzc2JUS2hU?=
 =?utf-8?B?eE5BWTIwa3ZFYnJEN1Nvd3pzbHhSb2tGamtwTVgzVDVnL2hFc2Y2TFZQeEJx?=
 =?utf-8?B?UjIzcVBWZTVMNEdJVnZKeG5oczBzZVRBeUMvL0FRUFdOTFEvdGxKTG1wWUxp?=
 =?utf-8?Q?+bSVU/NdzZDQ4ZrsBxWmyPrbbo6NAP070JXlBWI?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 8b8d33d1-5a39-4574-9119-08d9922ccc07
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2021 11:45:35.0055
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: u+qW3r9yetBsw+OpQzXdKbymXX37arRcxy6MMNSu3636F0YnULCcK4fX/+iE5J9Z9pRaIH7lQG9dmu0gWisI7g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4220
X-OriginatorOrg: citrix.com

On Fri, May 07, 2021 at 10:40:34AM +0200, Jan Beulich wrote:
> This is a partial revert of 540d911c2813 ("x86/CPUID: shrink
> max_{,sub}leaf fields according to actual leaf contents"). Andrew points
> out that XXX.
> 
> Reported-by: Andrew Cooper <andrew.cooper3@citrix.com>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> ---
> Obviously the XXX wants filling in. So far I did not really understand
> what bad consequences there might be, but I can agree with the undoing
> of this part of the original change along the lines of why the Viridian
> side adjustment was also requested to be dropped (before the patch went
> in).

I have to admit I'm confused about this. Here the maximum leaf
reported only changes between PV and HVM, but never as a result of the
features exposed, which I think should be fine?

Ie: I recall the problem being the maximum leaf possibly shrinking
when migrating, but that's not the case.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Mon Oct 18 11:50:43 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Oct 2021 11:50:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.212114.369870 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcRAA-0001js-6z; Mon, 18 Oct 2021 11:50:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 212114.369870; Mon, 18 Oct 2021 11:50:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcRAA-0001jl-3z; Mon, 18 Oct 2021 11:50:42 +0000
Received: by outflank-mailman (input) for mailman id 212114;
 Mon, 18 Oct 2021 11:50:41 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mcRA8-0001jf-W5
 for xen-devel@lists.xenproject.org; Mon, 18 Oct 2021 11:50:41 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mcRA8-00040q-Tg
 for xen-devel@lists.xenproject.org; Mon, 18 Oct 2021 11:50:40 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mcRA8-00078E-Sb
 for xen-devel@lists.xenproject.org; Mon, 18 Oct 2021 11:50:40 +0000
Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89)
 (envelope-from <iwj@xenproject.org>)
 id 1mcRA7-0005kD-2D; Mon, 18 Oct 2021 12:50:39 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Subject:Cc:To:Date:Message-ID:
	Content-Transfer-Encoding:Content-Type:MIME-Version:From;
	bh=r2tNtUv603vNZOUaqYflZkVTT277GP2mslr5k4EciqI=; b=rUjMjCk2fwWfeku1FsQJ5wM4Ft
	ZgynYY4h30rQf7SpV4pWk36EaCCXukBZwcseme92/4MzluK6Ik2viDX3O2yZ0xXIKmKySdaevO8ZB
	nBv5bfYIjUJcb4P0uELv1YnzpdJaZb6IsYwrBNAdz2oGh7BczISS/zDiWIu12ip3q3IY=;
From: Ian Jackson <iwj@xenproject.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <24941.24462.600999.31649@mariner.uk.xensource.com>
Date: Mon, 18 Oct 2021 12:50:38 +0100
To: xen-devel@lists.xenproject.org
Cc: committers@xenproject.org
Subject: Xen 4.16 development update - tree status
X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu)

Tree status
===========

We are now in feature freeze.

Until code freeze, straightforward bugfixes (and documentation
changes) may continue to be committed without a Release-Ack,
until the Code Freeze, which will be on Friday 29th October.[1]

Any patches introducing features should have been committed by now.
All patches containing substantial refactoring need a Release-Ack,
even if the intent is to fix bugs.

If in doubt please ask for a Release-Ack.


The current planned release schedule
====================================

    Friday 29th October                   Code freeze

      Bugfixes only, all changes to be approved by the Release Manager,
      on the basis of a (progressively stricter[*]) risk assessment.
      (2 weeks)

    Friday 12th November **tentative**    Hard code freeze [*]

      Bugfixes for serious bugs (including regressions), and low-risk
      fixes only.
      (0.5 weeks)

    Tuesday 16th November **tentative**   Branch off staging-4.16

      xen-unstable open again - with caveats to avoid release disruption.
      (1.5 weeks)

    Friday 26th November **tentative**    Final commits (docs/prep only)
    Week of 29th November **tentative**   Release
      (probably Tuesday or Wednesday)


Open issues and blockers
========================

I am aware of a number of oustanding bug fixes, particularly for x86.
I would appreciate attention from maintainers to these so that they
can be applied sooner rather than later.  I don't believe any of these
have been explicitly flagged as RC, or regressions, but I think my
information may be incomplete.

In general, please would people explicitly note release-blocker issues
to me, so that I can see that they are sorted out.

I'm aware of one thing that I definitely want to see fixed before
release: the patch "Enable the existing x86 virtual PCI support for
ARM" needs rework.  I believe this is in hand.


Ian.


[1] As previously discussed, this timescale has been compressed
    by one week.

[*] The distinction between Code Freeze and Hard Code Freeze is a
matter of degree, not kind; the Hard Code Freeze data and associated
tighter policy text is indicative rather than normative.


From xen-devel-bounces@lists.xenproject.org Mon Oct 18 11:55:54 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Oct 2021 11:55:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.212123.369882 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcRF2-0002Oz-R3; Mon, 18 Oct 2021 11:55:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 212123.369882; Mon, 18 Oct 2021 11:55:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcRF2-0002Os-NE; Mon, 18 Oct 2021 11:55:44 +0000
Received: by outflank-mailman (input) for mailman id 212123;
 Mon, 18 Oct 2021 11:55:43 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=628V=PG=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mcRF1-0002Om-Pr
 for xen-devel@lists.xenproject.org; Mon, 18 Oct 2021 11:55:43 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id a217a018-f1c6-41b3-b2ef-5056a1b37cbe;
 Mon, 18 Oct 2021 11:55:42 +0000 (UTC)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2056.outbound.protection.outlook.com [104.47.14.56]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-22-ZZWvwXydMUiNBQ1inxCJgA-1; Mon, 18 Oct 2021 13:55:40 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VE1PR04MB6671.eurprd04.prod.outlook.com (2603:10a6:803:11f::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16; Mon, 18 Oct
 2021 11:55:39 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.018; Mon, 18 Oct 2021
 11:55:39 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS8PR04CA0193.eurprd04.prod.outlook.com (2603:10a6:20b:2f3::18) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15 via Frontend
 Transport; Mon, 18 Oct 2021 11:55:38 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a217a018-f1c6-41b3-b2ef-5056a1b37cbe
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634558141;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=rb+fApBEx5UC5Is9TuifRX2UO+t/BM6AlHArKX1Vuns=;
	b=hza2qPJX3r6xsli6Y+YFxtlSxs0/FL/PdmzmtPHCCs63AFwlvjCWVIxJSIq6P5TTIAnMS0
	ygetX1aTngNja03XNdpdgHGYzUPPkhNIWg2l6PIbblc4ZrtaQjCvbzOna/FiHlzvYA566W
	2PyfxYUANjBp+siJQ/019b/j3hSI6XI=
X-MC-Unique: ZZWvwXydMUiNBQ1inxCJgA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=hH696DlPey0fEbPTv5DKlbHuj+OJfDzrfcGIZ3lzEeQrETmS4Su7k5va3aXj3MmL6QNdsiTy9tTE7sU3PkuQYpXziBBC7Hdpn/sU0bDgmwiORT7ePjIM2nbHIEM1cJM2uBE+7KGwFN9LBwUWtMfMxp2d4AwJCZ5SaoctiJEysDaXAFjx+2fSegjQl/ETGFE6raKqEuNgCdg7z39p0dnRdpRL3qAxmMYhdnmle0v4xXlTIemGQdlQb9om98PVxwL7wP4eHMTfnoZz2r/Iw8KhhoQguIgpVoB3t8uuWyqi3cEIzULUEo6loG3BCMtC/5rpWRDTGN35e/6bnHrmAuRRQg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=i8zk3t+dfpxnXB7FJdCT7izv/1Zlgb6vKX4NvXTFIA4=;
 b=XP2XJbwKynnh4Wkq6w4rWJhO2SKtPiOBOcDGd1YoTlZDGGw9O+UNewTNRVX948lE8LnRj2fhEv1LfI/uNWDXLMOrZFs8+l5yfwrHe3MzqM42YS4jroM3p7hGtTDsLeOmIOujnkH//EYTFtCba2oPMN6yA0rVawyWWT905LpEo005RPsOEjEhTVwemOBaAm0Vwllv2mqBtC7SD+AhvyTqJI8f8FMPZD6smplZBQZYnGbLMS1hJZMGX2xdZA8g+uIz4Zgoq8Ea67yVk4ui7EpDV6b7P7LPjwKdI7RmXpdYNODYFs+InZ7tl1WSl2UHg6xn5pD+pEc5nRk4kYpwqVfaMA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [PATCH 03/12] xen: harmonize return types of hypercall handlers
To: Juergen Gross <jgross@suse.com>
CC: Stefano Stabellini <sstabellini@kernel.org>, Julien Grall
 <julien@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Wei Liu <wl@xen.org>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>, Christopher Clark <christopher.w.clark@gmail.com>,
 xen-devel@lists.xenproject.org
References: <20211015125152.25198-1-jgross@suse.com>
 <20211015125152.25198-4-jgross@suse.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <7bd0cff1-6e88-f8dd-d857-229e75dd2772@suse.com>
Date: Mon, 18 Oct 2021 13:55:36 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <20211015125152.25198-4-jgross@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS8PR04CA0193.eurprd04.prod.outlook.com
 (2603:10a6:20b:2f3::18) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: fc021764-0299-46fd-7825-08d9922e3406
X-MS-TrafficTypeDiagnostic: VE1PR04MB6671:
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS:
	<VE1PR04MB667196943B762B22D1F33FA1B3BC9@VE1PR04MB6671.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:5797;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	iIS4SfmTszQbpFuIKiJOeGG/CjnlPJtdufEXqqH2ogflPfqXgZx1DH+jwtpiNEu8G1jleMHNBAug0M+7TCYkRAHtm9isYtICtDbnALk7IrH0Ak7BKmgRy8kqEfhGnVGYQHMJsM5+oIWepoDkMotD0uI7IlfwvXFtXnwQfsfKVdCNgB9K/UD0W0PWM1Juj0V/j2N3RCAQsm0DNCzhifIYLEl9xWKV0kf4J3rtZuMXiymAhnxu+9FIWurn9UJPGIQzpZETg4ZHQso+XRTGtlBqp/GhCCAGrKF/U1g8yEXgomFrqPonXL2WtNBRa2Yij02idS3Cwc3qvGIOWNHs5+Nag2iFF/Ut1RyJUe+Gbuwt5FVCAkFBTsfTIRdT8H4J4JPdn842Qn7mW272Bt2NyqhlVA6y3/1xpDhXVUCheOTrVtkdH/ojlhJj+gbLbLpiX86mK6ZcN4c/i6/sE9OMWfLIe4q8/p8TqVwwm5QGexmltVlF/kuLxwZcCSXtIWsr2Noq0zTUTwE2fNELqrhf+W4Ee7pgGyAdI5mmCshT3dMcar3s+Nl1XZtxXDXaYUvNZ9TLmeWS/zHg5lVEqb2WGicMW2g9lMkgGKwVXYhlT2AzvGCS0Mhuo6UfnQ0db29KRMeAnjZAiqZWEyF17FixpUAuXHpPIkNaLjhEYKjA1T6JzXeBOiwWaGRmpoe09BIKHIRTYCvuaWseStjACcjhJ3At4AKLKhWEVj5sT1SZlB96gLfsmWMLg2Q9KQcfOc/PxpXx
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(53546011)(5660300002)(4326008)(6486002)(83380400001)(38100700002)(6636002)(7416002)(508600001)(8936002)(2906002)(86362001)(31696002)(66946007)(16576012)(31686004)(66556008)(36756003)(54906003)(26005)(66476007)(37006003)(316002)(8676002)(2616005)(186003)(956004)(6862004)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?pvtOB5VwBn27rrTAGomSms54Hz8ZPWXDlSaJsR+bK1pXbGhlsfVBksAmHl9w?=
 =?us-ascii?Q?JILH9DAKf1GD11RN6twKOdm0QYYs8XFam61DWFiUgOfRzZPgPzdqqo2tPYjf?=
 =?us-ascii?Q?lQ5QwAMiNEXK3aa9SlMcYm7BMgD0T6EQ+81LsMPiKo7JPLbTZzHbBeZdaUcG?=
 =?us-ascii?Q?BP4zjTKRCNjtnCoul3pd2XxfqDGosptG80a6mA3Hy/gYIul/gPiX5KZxqY3d?=
 =?us-ascii?Q?6fhuOK7P8FI1zBQGqvqSEEhQpM64o9wHqurfE6O+r7hg+Bsp9qfQzdm6lMpF?=
 =?us-ascii?Q?PxGRCrw2J/ci91JjoUa4r3fpFCODyY4MewCCaYwyLiQ0YkHFdVWAIWpeVjO0?=
 =?us-ascii?Q?PwcmD9tNsjjjgydjFADvVv5o8gIV54BEvRMg65b5ImwD+JeBECLIUjtb15mB?=
 =?us-ascii?Q?AtSkENmngiyyIT0uIqBqWUSn1wQ/msIArG/YrgX9DznAtfj2+BWjnAqPw9zl?=
 =?us-ascii?Q?7/jiP/xtFgIx+zmLl93cFAzDiW8kjLioVpYqj1coI5Cerenyt9k3KE6fXkqv?=
 =?us-ascii?Q?NZn5YHv8Oa5j0AG86dsWwAndoIedGMDUyQh5me+RD1clLYNnAXRcKu+fd9kR?=
 =?us-ascii?Q?17FP1VvEP9SLY0RqgxiW6e/ShQ6ass6nNkWNzj33xcn8mlYScn0IPoYKKtDc?=
 =?us-ascii?Q?wNnRDvWO0tGQTklNgOErpBFTJPuDOVKS2aZII1Euz1oQc5wobO7KqSXwwmOq?=
 =?us-ascii?Q?YehRnuMzv1Hj1Ie6ykhdHavR/bAy9KeKZFj0kAcs5pGATRgukiJ/8DemhEO1?=
 =?us-ascii?Q?eNJvz8tIb54mGaiGkHMTfkCHx4aJUw3ChMSSqpEi7qLVcpo3XJBLrEXYNWIu?=
 =?us-ascii?Q?/ws/1pmY4RDEOJWPId6X5gmX2GxeZgp5Bpzofa3dY2p+F5pptISOluQHRtfT?=
 =?us-ascii?Q?kq5noHMM1uYiuifgQfDEPQ8W0QsKFSb2iKoIMzm7mzGXeSdqg/r2ZwCteASE?=
 =?us-ascii?Q?2/TbNIWvGuXIX/JIpLweMSFByxF/u8iUNQs4nU1R0GGw3UkpLOvWuK+pwqV8?=
 =?us-ascii?Q?EHj8BePFm2a5JwR8T0PNGRSru18INlgXfLS2LWSP9RWg+p2M9unsauum27dH?=
 =?us-ascii?Q?k2+7ztxS3n9c3KYLb8GmjYYDBNntqFidvQFyWiCqThljEkpD+BbCWUse5d4x?=
 =?us-ascii?Q?7WGYiDXDytaJ/+tUgzVVqwrsoYtoTe6nYPfqjrD8SOjNnp4F67MxggNcRH+n?=
 =?us-ascii?Q?2T0/7FHHg5w+JA/vIsF79nkK7Hsv9Gk1BlPFk9vC3n/oPH/v7aPya0EWZJQm?=
 =?us-ascii?Q?n2VFzqDs1dzOBDiKYn+fJaJyJi3R3NSfakd9ynab6mwNu690OE7odYif9nLW?=
 =?us-ascii?Q?FYOS+Ad0siF2+fW0IV/K+Rig?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fc021764-0299-46fd-7825-08d9922e3406
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2021 11:55:38.9605
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: AFNPv9eOaWkFpdigMFh/y6qE8gjKAbCmp670JbK4VBC516uyhozhRqxizn7FcbuQ1MM6xVhs0LHpgBV71wpNSw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6671

On 15.10.2021 14:51, Juergen Gross wrote:
> Today most hypercall handlers have a return type of long, while the
> compat ones return an int. There are a few exceptions from that rule,
> however.
>=20
> Get rid of the exceptions by letting compat handlers always return int
> and others always return long.
>=20
> For the compat hvm case use eax instead of rax for the stored result as
> it should have been from the beginning.
>=20
> Additionally move some prototypes to include/asm-x86/hypercall.h
> as they are x86 specific. Move the do_physdev_op() prototype from both
> architecture dependant headers to the common one. Move the
> compat_platform_op() prototype to the common header.
>=20
> Switch some non style compliant types (u32, s32, s64) to style compliant
> ones.
>=20
> Rename paging_domctl_continuation() to do_paging_domctl_cont() and add
> a matching define for the associated hypercall.
>=20
> Make do_callback_op() and compat_callback_op() more similar by adding
> the const attribute to compat_callback_op()'s 2nd parameter.
>=20
> The do_platform_op() prototype needs to be modified in order to better
> match its compat variant.

"Better" in what direction? So far both have been using typed handles,
which I consider better than void ones. You also don't seem to have
had a reason to switch e.g. multicall or dm_op, where (different)
typed handles are also in use. So I wonder what the reason for this
change is.

> Change the type of the cmd parameter for [do|compat]_kexec_op() to
> unsigned int, as this is more appropriate for the compat case.

The change for the compat case is fine, but for native you change
behavior for callers passing values equaling valid KEXEC_CMD_*
modulo 2=C2=B3=C2=B2.

> --- a/xen/arch/x86/pv/misc-hypercalls.c
> +++ b/xen/arch/x86/pv/misc-hypercalls.c
> @@ -28,12 +28,16 @@ long do_set_debugreg(int reg, unsigned long value)
>      return set_debugreg(current, reg, value);
>  }
> =20
> -unsigned long do_get_debugreg(int reg)
> +long do_get_debugreg(int reg)
>  {
> -    unsigned long val;
> -    int res =3D x86emul_read_dr(reg, &val, NULL);
> -
> -    return res =3D=3D X86EMUL_OKAY ? val : -ENODEV;
> +    /* Avoid undefined behavior due to casting an unsigned long to long.=
 */

Nit: unsigned -> signed conversion is implementation-defined, not
undefined.

> --- a/xen/common/argo.c
> +++ b/xen/common/argo.c
> @@ -2207,13 +2207,13 @@ do_argo_op(unsigned int cmd, XEN_GUEST_HANDLE_PAR=
AM(void) arg1,
>  }
> =20
>  #ifdef CONFIG_COMPAT
> -long
> -compat_argo_op(unsigned int cmd, XEN_GUEST_HANDLE_PARAM(void) arg1,
> -               XEN_GUEST_HANDLE_PARAM(void) arg2, unsigned long arg3,
> -               unsigned long arg4)
> +int compat_argo_op(unsigned int cmd,
> +                   XEN_GUEST_HANDLE_PARAM(void) arg1,
> +                   XEN_GUEST_HANDLE_PARAM(void) arg2,
> +                   unsigned long arg3, unsigned long arg4)

Strictly speaking arg3 and arg4 also ought to be unsigned int here.
But that's perhaps for a separate patch at another time.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Oct 18 12:03:22 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Oct 2021 12:03:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.212135.369893 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcRML-000475-Vz; Mon, 18 Oct 2021 12:03:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 212135.369893; Mon, 18 Oct 2021 12:03:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcRML-00046y-SX; Mon, 18 Oct 2021 12:03:17 +0000
Received: by outflank-mailman (input) for mailman id 212135;
 Mon, 18 Oct 2021 12:03:17 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=628V=PG=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mcRML-00046s-1B
 for xen-devel@lists.xenproject.org; Mon, 18 Oct 2021 12:03:17 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 5fc7ffc8-300b-11ec-82d4-12813bfff9fa;
 Mon, 18 Oct 2021 12:03:15 +0000 (UTC)
Received: from EUR03-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur03lp2051.outbound.protection.outlook.com [104.47.10.51]) (Using
 TLS) by relay.mimecast.com with ESMTP id de-mta-3-s5iKH-N4MrG5kwZW2097bA-1;
 Mon, 18 Oct 2021 14:03:13 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB5742.eurprd04.prod.outlook.com (2603:10a6:803:e5::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.17; Mon, 18 Oct
 2021 12:03:10 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.018; Mon, 18 Oct 2021
 12:03:10 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 FR3P281CA0055.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4b::18) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4628.9 via Frontend Transport; Mon, 18 Oct 2021 12:03:09 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5fc7ffc8-300b-11ec-82d4-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634558594;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=8jGuSXYlFkJ7c3Ooq0r6g076LD/DKv1Q1sCgeAd3CfY=;
	b=enROS9nkfJNEWG6j4yuFGwIpd91M2p5NC2wc/OpN4NVi3l1QZjh4jXlovm6yXq8eHSASsB
	HCnkqHMmdOGYQqZCHJFw2GjWcxYV5Lw8GceHNqJ3MXwhYO5Bh5hrnoODjQliPIji1OS2dO
	17rVyYcECWm0JL4S3Gv1AHahsZ0BMQ4=
X-MC-Unique: s5iKH-N4MrG5kwZW2097bA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=iQs2ZThet4r2v3PZG1cQp0BOFny/Isl0vULdiTHTfnUyBdNluJ+DBGgwDl5oH/5NQmQ2uT0CGIoajTK0oVRtbnhKx+vVSKIlP1CFHEApVqQ9uHprZVAmmUok9l4mWAspHGsptjTpuJbspeBmPynld7+ywHM30y189l4wS7jFAtUBCTSmCGS4CPElvC2cj/p8SfSE360tEmf2jjzttOoaZFZbzm8myuVE+2IhBPJYpD0QAuW2mr5hnVntTXS9kWrQKUsLHEhherk6wHV8mFLOxf9nuD1bX+724T3qAMQIN5Rvmidi9ZUdQVFrMwFjNfcGrRgNjVy7w+GP74ydJhfmJQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=8jGuSXYlFkJ7c3Ooq0r6g076LD/DKv1Q1sCgeAd3CfY=;
 b=fQSHGq9guVeXz9qCCw0FAQk6rgwfDrLLaAgS/2GIug5ZsBjmLhbdCY+7ND3Xr4XqaAOEAzQka/ka2F/B4Gg4cwx5oDtLwqmoYtIXWqFAIaHul+6BuiTbBdy/SzdPc4xuQ8KwwSq22tElfaFnVwW3ObDo0EPl2E0EIZbZxrEh5x41H7g6APlls2ZoYFkDrdVaj4eL6PHBjiNyK51A/mYYT0F2RkoNyznk8qtkYYx6Do63DQEgStSBe98zAGOZiVF6UXTUmS57M9gM0eotREiSD6+dqg892PeijGmJi04QbjGwaGCcQFev3/kUq/yZ8VfGythc8GDmQzOwkv4HyAdW9Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: citrix.com; dkim=none (message not signed)
 header.d=none;citrix.com; dmarc=none action=none header.from=suse.com;
Subject: Re: [XEN PATCH v7 49/51] build: adding out-of-tree support to the xen
 build
To: Juergen Gross <jgross@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
 Ross Lagerwall <ross.lagerwall@citrix.com>,
 Daniel De Graaf <dgdegra@tycho.nsa.gov>,
 "Daniel P. Smith" <dpsmith@apertussolutions.com>,
 xen-devel@lists.xenproject.org, Anthony PERARD <anthony.perard@citrix.com>
References: <20210824105038.1257926-1-anthony.perard@citrix.com>
 <20210824105038.1257926-50-anthony.perard@citrix.com>
 <2aaf0858-1602-be5c-77e4-2daa7fddc534@suse.com> <YWmzSkLdH5wtQ77V@perard>
 <f53e4d09-9f33-6dc8-8161-156b9eca4a6b@suse.com> <YW1Dhn+oEwvKgj04@perard>
 <70b8f320-bcd8-b864-f9de-a7ea35d53928@suse.com>
 <5a4df707-5b12-a471-e957-1a1c43340bff@suse.com>
 <9f3f6d5b-b920-911f-fea9-66fb36a09e5b@suse.com>
 <c0b2ca25-5700-e915-471b-3816d12efbd6@suse.com>
 <129b1339-df89-44e2-2467-77b60e113882@suse.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <2e7b9d35-ac50-c74e-dd29-050384094908@suse.com>
Date: Mon, 18 Oct 2021 14:03:08 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <129b1339-df89-44e2-2467-77b60e113882@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR3P281CA0055.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:4b::18) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: cbf56244-2851-4ae2-f27e-08d9922f40e3
X-MS-TrafficTypeDiagnostic: VI1PR04MB5742:
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB5742F23CCE12639282BDBC55B3BC9@VI1PR04MB5742.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	ebqSe9BouniJiVl4wSJ16ZgCoEHBhHxVSiZY1F78W9MO+L7MkS4K84mLM+o/eNhsHiVt+BZBziectugEq+lXqlJQpFBOTt3IrvoS3zJJpWBzPZRaoBtO8MoGDd1DCfYoX+szYxoXlEHHr08ZQKkXWw9gXTOXO/98T7Xigeb3ZHdG6hU4cIeHc/1S7ib2J8ER2kU66XHdjwrnEJB2SqLPIyoKFBS5E7z+vFU5iEfE2m/cGA590I4ok3XJvq3B/R4tJ89ec5csUCEmCAAmQWvk7xsoa8D/XK6YalaHajmS3E4pphFH8OillN6Fmxn3yegG9CgtAS37utJ7A13D38TFDlGS0Up9MaI8zffxTlolbb3jED74Yi0AXVGK4Az7UAKSgAiKBAX200pCW5QOjYaRY8YrCMZ8EmI8Bjv8G0+T5sCv1K96VCRj2ECMXLT5woFV4kb9rRx7Vq3rJVIFK19SPyK7wasxrqC4tLX9kODSoZXkvzo5JyJhxH8K7WVTvICXPCF+82YqEmvpAo2I+NyxVWVxXL35nRiP8fQRjaPLL2ibOHtW5wXIFBCEC829GQHhf+DXDkeyXfTCIew6UlF5Uji1PSxM69Wfex1ws/LZT4MiBdBm7aGA/sLSBnK6cNHDcB3zXLCoPD2uQWI/FoAUSLi0gKHt8vbL/vIUMtw7R9R2JNUG2ExObTOfwIsC7WpYejIQZoL7fcAnGQJUzeIRC6kSlEgypuhsOSw1CELWW2FHeC/yAFjMBmUuq8loKsTg
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(31696002)(4326008)(31686004)(316002)(16576012)(66556008)(6862004)(83380400001)(956004)(66476007)(8676002)(86362001)(36756003)(6636002)(186003)(6486002)(37006003)(2616005)(508600001)(8936002)(5660300002)(38100700002)(2906002)(53546011)(26005)(66946007)(54906003)(7416002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?ZFB4V241SmwwTUhDeGNxRytqNzc0bVRLNjJaOXBNaDJJNDdjcmVka1MvOWhu?=
 =?utf-8?B?OUdKNlBkcWtxZHFmRzk1SDlNb0NvOFdqY0pUT0I5bU9EMDV5Tzc4bDdJbmN2?=
 =?utf-8?B?eWFyVElSQythbDBwY1YyVkR6eXQwYktPaENDaHYrd2dYUlJVMnhONWF0VFpp?=
 =?utf-8?B?eUZuMnpqTjhvc2Z2aER1WU1FaVhsZWw5WGpoYWV3cy8vYTZiL3NCS2xNMXBI?=
 =?utf-8?B?VC9ZaFI3dUlVVUdkaFZKRjkrRlFNeDlLTGNIcW8raVVQOFQ4VnZNUDluaVBC?=
 =?utf-8?B?OFZqTHN1cVQ2VzZYY3RDakpXVjRBdXZORDB5T3hPcU8vV3ZoNUlNUmxCcERO?=
 =?utf-8?B?TkRtYVU3Y2JiZ2ZISUdiazhaUFZSbEVDcTFwWnErS01NK3UyR2NQYkt5YkJC?=
 =?utf-8?B?NGdWVVZPeUJJSHd2a3YyT21hUkpxVUtNZElVSzVCNlZRbXBWMVhBT2JCRmMr?=
 =?utf-8?B?VGJMZ0dpM2JlWmpDSC90QUl0Tzh5RjBJbElrekhYUGxHSlV5MEJ1RmIwWVU1?=
 =?utf-8?B?bUZmYVdGR3BNL1RDZE1LcFdGVVMxMDhOYitkUHAxd1dCWUpFVENSdGJqQkRm?=
 =?utf-8?B?Um1WU2dlVFRyS0RFL1I1Qk5GSG9Qa1VLOXZvdUxOaXNQNHJBeEl0OFo0ZWMw?=
 =?utf-8?B?eEt2Y3JXM0pzSGVIRlpHN2VOVi83dncyeXA4bDMrb2dacGF6L2x2QzgwR0Rt?=
 =?utf-8?B?THA5Sm53Q3kvNnMwRWlwYm5wS2tHMHF4MzJDUm9WOVVweW1CV0VES0ZxVVdG?=
 =?utf-8?B?dEQ5WXpWSlNUS3JlTnVLbThkbVJGWlIrMDFuenRwelpZUHg3OXpjZUZpclps?=
 =?utf-8?B?VjZpdVpNNi90RVdIOTAwSi9FRDl5OVRLZGVtVU5wbFVvYXRTRWVMZEd4UXhN?=
 =?utf-8?B?eHZhY1JEeWY4Z3NkUGY0eU1xVis4WFB6SUkycnhtRk82RUk4T0JrYnJVRDIz?=
 =?utf-8?B?RFU3NUtaWDE1K0N3NnFpL0YwcnV6ZzY4cEdBM3FLR0kvRGswV3c1YXZQLzB2?=
 =?utf-8?B?UUU0Ly80SVhobGl0cVY2UENaN0o1WHZJQ0E4WUhLc2pnN3RXbGU3b0Z2Vk5U?=
 =?utf-8?B?emJsQ2JybXgyOEZoMDY2NjBDclRGWVVSTHg0MGtlcXVRQnJJYmJxeUNHVnlr?=
 =?utf-8?B?a0NYNXZmRVFTOHliTlJCYzlRQkxOaTA3ay9tRHFtWVJ4VlhCVHZ6K1BKbEI3?=
 =?utf-8?B?czRpUG43SXBKcnRaclRZMUJ2Z0FMQk5HZW9tU3p1RWVTSmZnRFFMQnZSMnVY?=
 =?utf-8?B?T3VVU0xUUHd5NUhHY3c0bUlPUitxdmNGU3ZxL2VrUU1rZkZOMk5pMk80RmtB?=
 =?utf-8?B?ejV6ODBOU21UL3QxSE5JUm1Ga0JvMDRoMGpiYzk5YnJzbWJScGF4aTJwN1dX?=
 =?utf-8?B?OEFYcjN3NGtESnVGZVJtVitTV1kwQmU1aG1pSmR2SzlmRWxZdmxDekxjQWFi?=
 =?utf-8?B?WWc0Wm5FaWVvbkpWUnovQVRPeVZNVTBJU2Y3Y3pqRmE0enI5ZEd6ZGQvWEg2?=
 =?utf-8?B?Tm5qRU9kRzZtSkFUcnhRQk5ielVuY0xhNm9CbENyVXNkUVhhRDFUUHAyeWRN?=
 =?utf-8?B?NjVQdklWekJydWhtN2VMYU9zRXVldzNOclZGRWkyd0FjeisxL2I5QTZRdTBI?=
 =?utf-8?B?OFFOOEp0RXlXRGlxTWlVNGR2c0hOQTRzTG93cDFVSVlaS01xTnl3Mlkvczlw?=
 =?utf-8?B?TVlqa1JOVGhSTFdsOHJ3ei9HNTQvTTBJQ0RVTTFGci9mUm1JbXp0Z1hreXRn?=
 =?utf-8?Q?oPFtchLoKyqZFtCyZw/QMuRapztxVm+7MJra+yk?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cbf56244-2851-4ae2-f27e-08d9922f40e3
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2021 12:03:10.0314
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: gSwuNmk6/3lVahd8bN3Dlqck2aQzrC7h4Ic0UwEogSc7MgkLDQEbyiRcmqdVy9kgtg+n/VP2Xe/pbrApFuLzyQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5742

On 18.10.2021 13:20, Juergen Gross wrote:
> On 18.10.21 13:07, Jan Beulich wrote:
>> On 18.10.2021 12:40, Juergen Gross wrote:
>>> On 18.10.21 12:36, Jan Beulich wrote:
>>>> On 18.10.2021 12:28, Juergen Gross wrote:
>>>>> On 18.10.21 11:51, Anthony PERARD wrote:
>>>>>> On Mon, Oct 18, 2021 at 11:02:20AM +0200, Jan Beulich wrote:
>>>>>>> On 15.10.2021 18:58, Anthony PERARD wrote:
>>>>>>>> I have to think about that. I've made some further progress in order to
>>>>>>>> be able to build the Xen pvhshim without a link farm and notice that
>>>>>>>> nearly every source file needs to use "$(srctree)/$(src)"
>>>>>>>
>>>>>>> Oh, now I'm curious as to the why here. I thought use of $(srctree)
>>>>>>> ought to be the exception.
>>>>>>
>>>>>> In Linux, the use of $(srctree) is indeed the exception. This is because
>>>>>> we have VPATH=$(srctree), so when `make` look for a prerequisite or a
>>>>>> target it will look first in the current directory and then in
>>>>>> $(srctree). That works fine as long as the source tree only have sources
>>>>>> and no built files.
>>>>>>
>>>>>> But if we want to be able to build the pv-shim without the linkfarm and
>>>>>> thus using out-of-tree build, we are going to need the ability to build
>>>>>> from a non-clean source tree. I don't think another way is possible.
>>>>>
>>>>> Is there any reason (apart from historical ones) to build the hypervisor
>>>>> in $(srctree)?
>>>>>
>>>>> I could see several advantages to build it in another directory as soon
>>>>> as the build system has this capability:
>>>>>
>>>>> - possibility to have a simple build target for building multiple archs
>>>>>      (assuming the cross-tools are available), leading to probably less
>>>>>      problems with breaking the build of "the other" architecture we are
>>>>>      normally not working with (and in future with e.g. Risc-V being added
>>>>>      this will be even more important)
>>>>>
>>>>> - possibility to have a debug and a non-debug build in parallel (in fact
>>>>>      at least at SUSE we are working around that by building those with an
>>>>>      intermediate "make clean" for being able to package both variants)
>>>>>
>>>>> - make clean for the hypervisor part would be just a "rm -r"
>>>>
>>>> I fully agree, yet ...
>>>>
>>>>> Yes, this would require us (the developers) to maybe change some habits,
>>>>> but I think this would be better than working around the issues by
>>>>> adding $(srctree) all over the build system.
>>>>
>>>> ... developers' habits would only be my second concern here (and if that
>>>> had been the only one, then I would not see this as a reason speaking
>>>> against the change, but as said I've never been building from the root,
>>>> and I've also been building sort of out-of-tree all the time). Yet while
>>>> writing this reply I came to realize that my primary concern was wrong:
>>>> People would not need to adjust their spec files (or alike), at least
>>>> not as long as they consume only files living under dist/.
>>>>
>>>> So, Anthony - thoughts about making the default in-tree Xen build
>>>> actually build into, say, build/xen/?
>>>
>>> Or maybe even build-<arch>[-debug]/xen/?
>>
>> I'd be okay with build-<arch>, but things would become questionable imo
>> when considering further elements recorded in .config: Where would you
>> draw the line?
> 
> Okay, this is a valid question. What about an environment variable which
> can be used to determine the build directory (or a suffix of the build
> directory)?

That would be fine with me, but as said I'm not building from the root
dir anyway, so people affected by a possible change here may be more
qualified to give input. Otoh if people need to adjust their stuff
anyway, they can as well switch to an out-of-tree Xen build right away.
And anyone building in-tree won't expect to be able to build multiple
flavors in parallel.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Oct 18 12:09:36 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Oct 2021 12:09:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.212144.369904 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcRSN-0004qW-M0; Mon, 18 Oct 2021 12:09:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 212144.369904; Mon, 18 Oct 2021 12:09:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcRSN-0004qP-Iw; Mon, 18 Oct 2021 12:09:31 +0000
Received: by outflank-mailman (input) for mailman id 212144;
 Mon, 18 Oct 2021 12:09:30 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=628V=PG=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mcRSM-0004qG-Mx
 for xen-devel@lists.xenproject.org; Mon, 18 Oct 2021 12:09:30 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 3e7fb102-300c-11ec-82d4-12813bfff9fa;
 Mon, 18 Oct 2021 12:09:29 +0000 (UTC)
Received: from EUR03-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur03lp2055.outbound.protection.outlook.com [104.47.8.55]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-19-URF_OSD6MwGCYdozWwYw4g-1; Mon, 18 Oct 2021 14:09:27 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB6304.eurprd04.prod.outlook.com (2603:10a6:803:fd::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16; Mon, 18 Oct
 2021 12:09:26 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.018; Mon, 18 Oct 2021
 12:09:25 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS9PR06CA0347.eurprd06.prod.outlook.com (2603:10a6:20b:466::33) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16 via Frontend
 Transport; Mon, 18 Oct 2021 12:09:25 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3e7fb102-300c-11ec-82d4-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634558968;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=fcsVj3Su770zv5cpGsP6o9y7SvTJ6VgbQejuJgTL818=;
	b=nbCeDaNP/N2vDfu8R03h6oAnXIcI6HtApbNbPZgXBqy26Kg4ss3fJSL1OUXxgD8MnGvH1I
	8ReEm282SXluZsT5fn6vfCo7uTA2WCRVu3NUpEYP3P4AQfPdCR5CBJSG9HEoAqSmTaxJAw
	tBH56d26YSoZT5Feh0c5j7bTZkZFwjA=
X-MC-Unique: URF_OSD6MwGCYdozWwYw4g-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=fJUCz301ofHHv45y6zOhwHgyxmJIksUYJ/q7Mp584x/xRTYFCLrqZKfUpiKW0oaJzTCc5pK6tHcRoeUIHZ8uadSBnYlQFgzfnFjhy7ynt7s24roGxUcGo+B9jlEgm5OYP4yqjAKFF1wX1jktlK5ah4f4MuDHRDE4ywDP4YlQkHi/nFAlwhPlfqQYgZuC/0PaIjAxNX73l8rNPt82e2bbq+df7Gh2Qo/Nalb7Mo0P7mKGXAQM6u0K181tl97YAHU6AUvRFKZg60rtO4779IxrnsWb409zn3udo8rk0+56Vz7shxgQPbFqPED49vcBLC0cN55Q3qiyFdGL1/Pw7UQavg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=GLWj5tMXlfRChWV9sYQaDGrsPtFEhU0wkmDjqZ+8xdg=;
 b=oR2dd9Ma0CoMkA4TFeOKivyXXFAjgPLyXA6QHW9ItoreDmPyWo6E0VJLJ3/FFJKAzpIMIe0C6xArpPv5qQXg2yHd4JNoR6iz4sXyc7zimo3L8H9CQUSPKs4xel90c1pWMPchgKcnBOFwNjny9ArDX/A2AXWSk3w5IBdw+zBl6vVk0iEqqED/pJ1PqWpVG2aHz+TWYL4YDKvxrYHY1daAujDSuvNjNZNs6uV+oHCBeA6WgwpjJKuwkJVb3V2U7VpKPTUdXWA/ZEWFKLqVOlF8UFSrp+Uw/kkVcOnCUqxzCLwoe05I5zIsf19M3x2w1CfvSplYmOmSfbleByfWJicp5A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: xen.org; dkim=none (message not signed)
 header.d=none;xen.org; dmarc=none action=none header.from=suse.com;
Subject: Re: [PATCH] x86/CPUID: don't shrink hypervisor leaves
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Wei Liu <wl@xen.org>
References: <0f5fe8d3-4c43-e60f-c585-67b2f23383ab@suse.com>
 <YW1eWeFls5igZcHu@MacBook-Air-de-Roger.local>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <5278ee08-c171-4dfb-43dd-1309be2796c4@suse.com>
Date: Mon, 18 Oct 2021 14:09:24 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <YW1eWeFls5igZcHu@MacBook-Air-de-Roger.local>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS9PR06CA0347.eurprd06.prod.outlook.com
 (2603:10a6:20b:466::33) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: d4619b5a-93dc-4bcf-3ddb-08d9923020f4
X-MS-TrafficTypeDiagnostic: VI1PR04MB6304:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB63047EC41376BFAF6D5A928CB3BC9@VI1PR04MB6304.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	xyQPVn8noOfmHP/ylKHVhfWt/MX96gkUhZloR3ekVrO5lCH+5kFi5PLijjPjN1r5cpX9xe/OA4tdKhQg6fRXqUIuthDYPgVJm+pWUYnAksHOWp1QNtMcGzujzoBAzDC9X3cdUiN+7cwdvIbTpG6rbhunHUtxJCUa0JTJOrZucapQXYYrGrLOkf1nKML7mYx3Wit9RUy0tM4aPX49nkOXzNq17Yyg9jYQPOxPr08c/q2J5mXyGHrozffDWXRBVSjOHgCE9OIGsSUtL5qmGnOBdsGGMRmRrEVJnyoxgTG6sGBS+qrpY/1EbUZCp01hWqoSiDE66HK8mOWH8GgfNqA5s73OK0wOtj7J/l+ASWXb2xb/FQkZ2q7wD5ZcZc3a2dQTn9HGNr9VTYgfrXsTKy1I5KqGnJg1Tih7j7hHI9JGviDhhnDq5YMWhCqnlwAq4ICAiJXILFtoTLPr/WcrNc2Eg3YAhSdRnKlKSWjKGAtJdDBSByvmRUzcZdkX/hp8WLu/4nzNY5OZmcMnbBtkySviZklcMcNBkpSvbse18VYKaLKfm3pzOIuiQshY+qmVDf9UP14hFD7E2Mh6zbxR0HoJYNIiNm5AdIBEJkgRYC3UXlaCOz4GB8U3SGfe1DDh7BirmhiPyJMJWB7EkOyDg2Jy95tu6VSYcpUicrb82283G48qHpipKRCFzPMuZo843sgGrCGvBaDpsAcscGMeLNrlgaEDdgEcHoqsP4c9a/zcutfwQcj8fObzlBwgjhXbptY6isowMYz0lTlJOW+sks5SEQ==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(31686004)(53546011)(38100700002)(110136005)(508600001)(6486002)(26005)(54906003)(86362001)(36756003)(186003)(31696002)(8936002)(66946007)(66476007)(66556008)(2906002)(5660300002)(2616005)(956004)(8676002)(16576012)(83380400001)(4326008)(316002)(21314003)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?zsv3OvgqHY+tbrPRAxVaXCHbK+/U8zOnu2uj++W0GuLlOXRG5X6Vmc1B/oRl?=
 =?us-ascii?Q?YpMERn6qdL2CfCy4S7Pg0coNXzWdkpTNti9oNnrA/2gT73/VgB+ppw5uL2nh?=
 =?us-ascii?Q?3+kU+kw+wKdh1VSV39/zvSSoFmdy7mlfdkwZ5hX9eFAq/cndyJSaHN1DIJQs?=
 =?us-ascii?Q?hUiaPko8rJtyh6I301Lfgp/s/5/gWDQiSypeDZ7x/D60RM1zBbkq3Hr/7rK2?=
 =?us-ascii?Q?n2t+UO7AsyPDKYu61vzIJe9+2YJEdaIy4I7NAyEOL201/IhLSsanNtR1MQiB?=
 =?us-ascii?Q?3HCup9bACMNATp0EjtqKZmx+qwC3GR9bfKDV6UMT4bwkDIsmSW/6HB5vSbym?=
 =?us-ascii?Q?Es6c7310vzfAepRUpazUdLRuVbajjP0LsEat3Na2h8JYlfYYbEBGfcPBqlB7?=
 =?us-ascii?Q?CjdiweuaeseCj29A+FaUbSbjR8Ajg0TiDPQ5kQi1xZ1A9zwMfPaMh400KTqZ?=
 =?us-ascii?Q?4RVKmNB/Wu3IjWD5occHZ72XPpab9nQJV8Lunb7jz+9JV3wDgy9t7m3q6IRZ?=
 =?us-ascii?Q?LRpOvojphF6NVG5mCzpcrUxctjeuEgydv82N+7OLi9UzC0vHGQvvzotQhfcA?=
 =?us-ascii?Q?y7p4jF2fF77cIhLkE7omqJ8rPQ4IZwOZRrWka7hjden6oN6Cy/euB9X22n3a?=
 =?us-ascii?Q?3F/fEISJFItF6ccMgK9ONjQDNj9hnH/4krdmdRoFbShmoEz7pDtllb4zshh8?=
 =?us-ascii?Q?7PGotzg/jW8AVVa2K5KWx3o+yOxbB+9MQuU+ciqqAMBNtYcmx1qVZfDib0QQ?=
 =?us-ascii?Q?SW6owo3vgrwbQ4V0O05NYw4Dmnp1zgOjSYyfXcopa3MQ8metNC1glMQ23PZ8?=
 =?us-ascii?Q?FbqkDdLMA7Du3m7wj6Cr+qFdzIOpM77n1GyFZcUmMDGQXOcGKz4fgMGYVj7O?=
 =?us-ascii?Q?FFmFjfzlkUwa5Jq734Wi/D1cl83LK+G21/+W1IgvSbf55PP6kW9qP6xYstPa?=
 =?us-ascii?Q?EVFf/97vGz55adMTD5+CYR2k3WhyG2BXl4TtiOMmrC9vKSaBJAwTxzr2Aq2A?=
 =?us-ascii?Q?nDYEeFt/+tpqCGSnjIUTeOtmA611nSlT3CLJBs9e4Bpu12J5O3mTvI3QdakR?=
 =?us-ascii?Q?y9qABnru27yobMzwq3u21+TQPhFQ/QwZJ2CEFroVNCA6TYDZiIA1Mu/fWchK?=
 =?us-ascii?Q?7owSZ5sSddDcuZbzyzzuD2swey/VmwGDZd3qFbEGJeDLqd8sOBoZT3egkxJV?=
 =?us-ascii?Q?dorzXhBveW+om2r3Ebtl9wQVYz6S+aCbeEth+8+47QfpOtSAKDzgKht7RJ2Q?=
 =?us-ascii?Q?54dUSHj2Y4bIEZCVKbyU89Gh3mVABl25+tsYVGox+tU6oibIFXJrOhS4EWik?=
 =?us-ascii?Q?V4eZuWCUNwuwfamczpIXAF9j?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d4619b5a-93dc-4bcf-3ddb-08d9923020f4
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2021 12:09:25.9588
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: XGs3uocubAbYT3J1ZUcli65w1fvX6GFJz9bBubuBHu9kfXtVxE8Z8+pww1PHr9xUo0mXt09oLUqzbHoNbKkBCg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6304

On 18.10.2021 13:45, Roger Pau Monn=C3=A9 wrote:
> On Fri, May 07, 2021 at 10:40:34AM +0200, Jan Beulich wrote:
>> This is a partial revert of 540d911c2813 ("x86/CPUID: shrink
>> max_{,sub}leaf fields according to actual leaf contents"). Andrew points
>> out that XXX.
>>
>> Reported-by: Andrew Cooper <andrew.cooper3@citrix.com>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>> ---
>> Obviously the XXX wants filling in. So far I did not really understand
>> what bad consequences there might be, but I can agree with the undoing
>> of this part of the original change along the lines of why the Viridian
>> side adjustment was also requested to be dropped (before the patch went
>> in).
>=20
> I have to admit I'm confused about this. Here the maximum leaf
> reported only changes between PV and HVM, but never as a result of the
> features exposed, which I think should be fine?
>=20
> Ie: I recall the problem being the maximum leaf possibly shrinking
> when migrating, but that's not the case.

I assume that's a question to Andrew? Because if I knew the answer,
I could probably have written a proper / complete description.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Oct 18 12:17:53 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Oct 2021 12:17:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.212152.369915 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcRaN-0006Gv-Hd; Mon, 18 Oct 2021 12:17:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 212152.369915; Mon, 18 Oct 2021 12:17:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcRaN-0006Go-E5; Mon, 18 Oct 2021 12:17:47 +0000
Received: by outflank-mailman (input) for mailman id 212152;
 Mon, 18 Oct 2021 12:17:46 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=628V=PG=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mcRaL-0006Gf-UJ
 for xen-devel@lists.xenproject.org; Mon, 18 Oct 2021 12:17:45 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 65984281-300d-11ec-82d4-12813bfff9fa;
 Mon, 18 Oct 2021 12:17:44 +0000 (UTC)
Received: from EUR03-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur03lp2051.outbound.protection.outlook.com [104.47.9.51]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-13-C-elG_FlNEuUGQoXBYeFCw-1; Mon, 18 Oct 2021 14:17:43 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0401MB2334.eurprd04.prod.outlook.com (2603:10a6:800:29::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.17; Mon, 18 Oct
 2021 12:17:41 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.018; Mon, 18 Oct 2021
 12:17:41 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6P195CA0027.EURP195.PROD.OUTLOOK.COM (2603:10a6:209:81::40) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.16 via Frontend Transport; Mon, 18 Oct 2021 12:17:40 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 65984281-300d-11ec-82d4-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634559464;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=qOlOn8y8Hnh5tiSkvthaJovJrDUEWNmjXDip3JXghRc=;
	b=lk43rpzWqKHJ1Vy3NjTrdn/DhkXWG738ZqBdCcgDyDXo5SpbHOXvd5N3uovcJCbjijbgN2
	TbtEGZc81SX27A3/lI74b61Up06yCZy9nrGGiI9LnP9026yEUFbyet9i+YP/9GI+VfQXuc
	NHlTSjBq131cIWVJp+j36Y+GxST+IH4=
X-MC-Unique: C-elG_FlNEuUGQoXBYeFCw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=mXBEszAAWvwZmRCCgnA8el7pT2LxEsjh7//VQuJ4tt1uLtXpNmOzsm8LtbyyGNGbSz5IXoVeBwsTSZn4HrP3sUS5JTXowkjVNp71kPW0v82kGdB6V0pc76yN1A/wvXJTr1BVmBE9PLdWWyIhoouy+ocDbyirY6CAR/+/F1sd084Laf3wVTa+3T62YB0+bBBYNwcNx3c14Eb6nSol6HH+MV1RvIgQRVrmoTTt7u1L7kFe9C/CQ9+LpBxoz46rdTWA9s6dC/y9Ndgew3GC1b/bPm1zPkrkneNeYaIXonpRbfk0pwFzws4CH0z3y/H68EBDYAN43JCnDEv7PZEn1EXrrw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=7c2nccOL8fMTNlBwSTXOXbyx6anX6RclFw2fsvpwbec=;
 b=ISNaZAhpqrPec/siITJnFemLAQ7cLXTq6xBOUVR6gGFCx/FLMWsZyIJmFuHjshOb9wJ3bBs6CBNKWynWB5Jg/ag9SIIDmvLAaEu3W/Rr4uuQw+Te4HQTHJbJGAahkJONqhDQUWhPGjvMtg5lC/0pbr4CVmz3q6VwzzzNARnlY5rdX76+aQJkFGXzKlcWXAQUXmU3kTvCMg3RahZ634JtmT9Eznxs8fmF8L2nfhW+wGX4T+aKOixao/n/oQGyRX3d2IjMY5MruxMaHmzE3aS2YH6RZPSRqgO+DnISAMF6Gomg1PMVa93sJIfgfrBAYfqI55QWA3RNMTshOk+Cxps3Uw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: xen.org; dkim=none (message not signed)
 header.d=none;xen.org; dmarc=none action=none header.from=suse.com;
Subject: Re: [PATCH v2] x86emul: de-duplicate scatters to the same linear
 address
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
References: <cf935e11-27c8-969f-9fb2-a5c0e85ccff1@suse.com>
 <YW1YW8HJr6ttyd84@MacBook-Air-de-Roger.local>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <a35c7be1-db42-9f7e-fc36-6b6abfd9e9a4@suse.com>
Date: Mon, 18 Oct 2021 14:17:39 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <YW1YW8HJr6ttyd84@MacBook-Air-de-Roger.local>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6P195CA0027.EURP195.PROD.OUTLOOK.COM
 (2603:10a6:209:81::40) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 633aa74c-abd5-4e83-5ee8-08d992314815
X-MS-TrafficTypeDiagnostic: VI1PR0401MB2334:
X-Microsoft-Antispam-PRVS:
	<VI1PR0401MB23341B859D8432D344C6BE8FB3BC9@VI1PR0401MB2334.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	UNutfOCxXZ9f7pG5qokZQdaBzog16bJ+oAodWmL0jRVdW90MQl831upIh6tJjFY4DrILKKGlgfJ72STOHXqbjiBrUWK0SHZd1tUyIs6UYiRejJOPfuOZzcwVKjHWeZag3KuWaDPBCmNp0RvzJvy2n2XWC+n9zdkLvpp7PwpVra91XJM/6exm6Rt85Mb3JtcP7OZM38bf5n07Leorxu6URKRuln6vs0cNQoPHo5pngl1zEHZ+T6CxnaoFxuPc3BAw3YgaLqFarA3PFSe3qBOGmLIBUHVi09QBSd+XjS3GLwoUkkzVPJ+vTKnM40b/xzKKuT0ptuqHktFRHLenni+tttrIYUmjuKBgL71LYXTAi/cuZsp5XvA/bRZ0zRluyZbfWUTS+FuT0b4sfESFXc0ISWMhkLYV1CidS8itQb47WTD8qRZX11h1ziGGKKBWyOXIYNnaHbLoYJT5aaz/xfZ0O+KN7kZrwvDyyoHsu0u0gfnY0uk0bndJp9ufVXmeILt/2bUxCgh2NnK10qHkDjyGsCCB4ejR1HrIZVj4wuMSxRNM5Ew6+ZA+LTUs7D0DaKqDhN4HIFmjcy32fyaNUtTr8brnXCmGz+VT9lsOeCP+FveI48B3WB9uMCMLMWlnSKtAg99P4Ey7K5BojlUC7XRfMbEZj5rJ5PILpEvPXAF7SpPX7K3wqd5PZ2EZCwRWl5USaOt+gVbqGCTPdl7V0wzDj0qXustdEzBVrfH7VOuzuX1ztOL3RnnTWKQ2UlEhdsqB
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(2616005)(31686004)(956004)(31696002)(6486002)(66476007)(86362001)(316002)(4326008)(16576012)(8936002)(8676002)(2906002)(54906003)(83380400001)(6916009)(38100700002)(5660300002)(508600001)(186003)(66946007)(36756003)(53546011)(26005)(66556008)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?hK4V6mky53vcmjOMyBrr2D/MlewBuqQJABZGnle2NGdy/+IrRxTCyuQqTvtq?=
 =?us-ascii?Q?JGsspS4yMnfY+LCxHpB803bf+/OdAKBo8v3vXYvgw4CLAW5cMngM3t3qXaRG?=
 =?us-ascii?Q?wKoS5JC9CdcIDz2N0mib56zIZCnfu0pShA/0+X9h/XWOGsdiVsnSsz/W3qBA?=
 =?us-ascii?Q?6IxxLXjZEEu8V6ABezb7uYx+rWDpTFHVWTzFx1I19+qX3zcsTBhexwtXCvQq?=
 =?us-ascii?Q?BLDmpN9NcpY/Zx73AvLOLhqtOql3oe5/L2GOPUBQaEI32jKznR8eyYUs5Ki5?=
 =?us-ascii?Q?mhtqSt6kvzhcLdJBE0n6Q4BYClXWlvLfDI8cmGU+Ro2dET1cSYzLCBc/hTsM?=
 =?us-ascii?Q?Snq1nrRT21XpEQIt9OVElWI2xPZ5YTwrOlwRxYFumkEOTQ26p9LtGsvExCg5?=
 =?us-ascii?Q?jZzW9dB4vRFmxW5Gnt+3Ul3r+Uv1JynGeKhkZHc+M0riPV2Fdehj9fkaZAr4?=
 =?us-ascii?Q?RaE3YmK/YfTwadzaXTUloFG71L+dMpoO0OkoHx3Bhu3mRLCG/0jn+/1ELrLf?=
 =?us-ascii?Q?MKUKJM8PV/1SoXR5+g9gefZVDtf4sp5c5g6M6MBjm+BS1K0XNG+hysbppd/l?=
 =?us-ascii?Q?BQ45lrrOQSaT8yjvldcC6tqq0EIWb/INV0aFgoHLjomFmpio+T11ju3hHySh?=
 =?us-ascii?Q?xAsqU1KHfR0Oz9/eETsWMJTINaqCQf+5tf6gwlPJtcoUUjSbSRnw1G+0Ac6M?=
 =?us-ascii?Q?dIS5beTlTDGojh6e4B89WYwnAtHMhEQM0Z+pdnCrgGW+82QiQ4xq4kGMJZd0?=
 =?us-ascii?Q?grr3z0DfDw+FH7eR9hlfbkR+mSJJBNschRiJPU5Rhv9B9TP0ov4npj89XOui?=
 =?us-ascii?Q?sIxfDnq8TIlE9UWfg1nx7lW/2mnxmrANV1VJTF6WZ0wf6ilRXJsUqBERXFGQ?=
 =?us-ascii?Q?EYNGaMq8hO414VqkbnW/MRxmj2QcVMiRZXKLg6vBF8VhG0tKd00PrLa+8YpZ?=
 =?us-ascii?Q?Pau0a2pdJm6h71b6nld+xHR4QDh84titpTPvVJcrRbKvPNfdI7+C1nMUAPLC?=
 =?us-ascii?Q?uGDFO5jro8n1c6T9lG033i5+kGf2p2ngjE3cqP4HQPs0hniKuiXOw1Sij3da?=
 =?us-ascii?Q?3UcEsSsCZNiqkBmAqS3GDVcnjkWPTVyeXTBbogcdJuHLITJjWOpuwr95g0BC?=
 =?us-ascii?Q?wxHiVJf/GMw+Yi+S1cTWGvalY9PVvD7xoPkSyQZPdrju1qq3Cf98LmQdlXh7?=
 =?us-ascii?Q?JexzFgAfp9unLfp+/ZqvWOWcLdOm0MmUt/T72nq1pP/R/V3/cy6KRa1PohtJ?=
 =?us-ascii?Q?rU2P2+SL1jiXZA0hNArJQPEMgS3wKqX2xxtSVCLAEW3SjcTon7y9nDXcDtyC?=
 =?us-ascii?Q?spBbpB1NuwEZEAnTdaZGM8xc?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 633aa74c-abd5-4e83-5ee8-08d992314815
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2021 12:17:41.1118
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ar5DUdzsrlmLRgBx0mi0u92LKYPYtOatkR9d4P+5s1YJnpsohwRUMFrzhBY8y2fb5pq3slk+50y2TSjD3EApsA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2334

On 18.10.2021 13:19, Roger Pau Monn=C3=A9 wrote:
> On Thu, May 20, 2021 at 03:34:28PM +0200, Jan Beulich wrote:
>> The SDM specifically allows for earlier writes to fully overlapping
>> ranges to be dropped. If a guest did so, hvmemul_phys_mmio_access()
>> would crash it if varying data was written to the same address. Detect
>> overlaps early, as doing so in hvmemul_{linear,phys}_mmio_access() would
>> be quite a bit more difficult. To maintain proper faulting behavior,
>> instead of dropping earlier write instances of fully overlapping slots
>> altogether, write the data of the final of these slots multiple times.
>=20
> Is it possible for a later (non duplicated slot) to cause a fault
> ending the instruction without reaching that final slot that contains
> the written data?

Yes, but that's not a problem: Only faults are required to be ordered,
and when a fault occurs guarantees are made only towards lower indices
(read: all lower index writes would have completed, while nothing can
be said about higher indices). All non-faulting writes can go out in
any order (unless there are [partial] overlaps, but afaict that case
still gets dealt with within spec by the proposed new logic).

Jan



From xen-devel-bounces@lists.xenproject.org Mon Oct 18 12:19:54 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Oct 2021 12:19:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.212161.369925 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcRcP-0006zb-Ua; Mon, 18 Oct 2021 12:19:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 212161.369925; Mon, 18 Oct 2021 12:19:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcRcP-0006zU-Rh; Mon, 18 Oct 2021 12:19:53 +0000
Received: by outflank-mailman (input) for mailman id 212161;
 Mon, 18 Oct 2021 12:19:52 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=628V=PG=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mcRcO-0006zM-BQ
 for xen-devel@lists.xenproject.org; Mon, 18 Oct 2021 12:19:52 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id b13058c2-300d-11ec-82d4-12813bfff9fa;
 Mon, 18 Oct 2021 12:19:51 +0000 (UTC)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2055.outbound.protection.outlook.com [104.47.14.55]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-21-FX_8b-S8OriweJtzjCrueQ-1; Mon, 18 Oct 2021 14:19:49 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB2959.eurprd04.prod.outlook.com (2603:10a6:802:8::25) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.17; Mon, 18 Oct
 2021 12:19:48 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.018; Mon, 18 Oct 2021
 12:19:48 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM5PR0602CA0005.eurprd06.prod.outlook.com (2603:10a6:203:a3::15) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16 via Frontend
 Transport; Mon, 18 Oct 2021 12:19:47 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b13058c2-300d-11ec-82d4-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634559590;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=SEQzK1MkG8qn4+sFJQLgEvMPHqf0VSLp5zs3UnJPRps=;
	b=U7Oa2V7X4Um5IbqLMicW2bnUhY/1vHeoiYt8Ku0TCM2gdUJqxbF8Rfcv5dHWcPDnyVteAx
	BEdiavENUU1mpf4dsvdJnp7VZ7m6mRYabsxlUZWxMtGtJDbLP3pcmDDfyG0OfETaIODWqQ
	ygbMBvMjHHBw6cozVb2jR3VYhhVtK0Q=
X-MC-Unique: FX_8b-S8OriweJtzjCrueQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=LJa/LnqFIrTY60cVDw1jsgjspftSfitVYmofTkeDh68pYiNiUBZxWj5JQ2fGRap5M4f61mhk/4Y+PWy0rMaxgJO2DkY/kBL8uvCo3+sf5f+1586SGMSknoorvFdyr126cm7ebPtp2MUN1CLxbyAVw7D0TQpD9amGXKxzwk1/zvWmrpGp8rahyWg51X8HaTxFznbptsZwjeIRnnZKfy1bC54dsTiuDdzpYhS5Qb/7TtPNytz/4FqN6YSLSnHifuPax0jtV+l1ih//9zYpVcGxL8m44jsYmiN7tqkF7om+YOgoYhTQ7wU8jxmYQCOFzHwd2dR+bDe+z4Zo/MAoYGYNYg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=SEQzK1MkG8qn4+sFJQLgEvMPHqf0VSLp5zs3UnJPRps=;
 b=KV6fhBjz7KDy905PiNhocYMMPKUKAGV1LvJbSwgJqSaYOksiecYAV5jrQQbo5yKiQEhe3mWo4+fY7IGtmCpCTai6R+ob3J2ky/p2sjKTlru/tjZXLAcEBOkvS64A4b/8XYbvZ0Xzr/s1mAVqqcA8Y3Hg9I8R1DWNHUH/G9sVa5HdHGV5sGb9/kmU1oYK1hm2jx9oaIZAGH1zieE6cKmhmwfV/Qwev+KvVccU0HEqoyfzYChL9ArYnQt8mabAIyZmdJ/hrKk4dHYZQH8lhDodQqb+jKK9nti+466Y1QXadZ/FHYnj4pvylxz7Ym6VX5QBAuZO8PLgLcjDJzktEiTgRw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: xen.org; dkim=none (message not signed)
 header.d=none;xen.org; dmarc=none action=none header.from=suse.com;
Subject: Re: [PATCH] x86/HVM: correct cleanup after failed
 viridian_vcpu_init()
To: Ian Jackson <iwj@xenproject.org>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Paul Durrant <paul@xen.org>
References: <55570db5-3823-8996-f69b-c2b00bcd4227@suse.com>
 <24941.20394.574634.548545@mariner.uk.xensource.com>
 <16076406-9a32-5cdf-0ea6-72a8b21f420b@suse.com>
 <24941.23059.261983.36065@mariner.uk.xensource.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <3f94a113-59ac-0da1-65e4-924b2b9d7026@suse.com>
Date: Mon, 18 Oct 2021 14:19:46 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <24941.23059.261983.36065@mariner.uk.xensource.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM5PR0602CA0005.eurprd06.prod.outlook.com
 (2603:10a6:203:a3::15) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 926104f6-1c87-458c-f98a-08d992319405
X-MS-TrafficTypeDiagnostic: VI1PR04MB2959:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB2959B91EBDFEA167E8E8B7D3B3BC9@VI1PR04MB2959.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6790;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	9rxN7/9BIF2JvkmAEkNwAdlWTxP/1Y3TWEUIEsmxfy0E+sYmCPl7dNLLPxUMVUkRrLs2rOn7ypiCHx5O5A8p22Xbm4l8M0Ph8KER8vYlvt6/H+1dSwaGWcEivqW2qrqyN3yx9dDVH75nm17fxbIDlkiROXnjT3Y+5omlXe/YaUCa2JxhkQTJCzNV1fLLFlVvmw8p5RHTkuTVmwwRkTv2/uWA70v0suWBBR/s2iLXFpGxcAWnkHINhwfucEPQRK3Hbjo1HJZxoE+X33pRHjqvHay5hObUGYti/Y5C2EYrlGcgz98yt97eA/FCshIc8Sz0LAXd8bv6ln5SQQ86DG8AYlcUt7fMaCD78B35u7XP8YG7uUuWj5xNBM0VkJNY9dlH8kMYYrOqAIw3DI4/XmFUh9D11ioQCe2BdkPHYmpgWFEXgDNe0X5BxKW1fi1PktwBLJw2D8+NkgIks47Wi0ubjzOf7bJWmIDr4U3rX/NWk5/1EMR3EVXPcZ8tPqA9nhA8eEvIm/upweLmGa4LIAqLiXXZ+qtYOVyhe0D/trqKk6vEwsZJcL3bjgnQ56f5kpZhSClboZXfXiwV5iShalCG2yI9ILH5bpRusgLiOzDc3YZf09dtOvkCJUsqlqMrIuKmMkSZ2mPa8BjrW5eL5tuCzXIKKFXIoG54/RHaAKsAHf6J8l45v5MP9UGohqxmVMfSdcRQsd2bYgYB9PU3BrDoAUq7GWBl7t/VpWoJ/ygUoMCxqfD9dxvF8Q0jVmpkrQDW
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(36756003)(4744005)(2906002)(31686004)(66946007)(66556008)(86362001)(5660300002)(4326008)(316002)(16576012)(186003)(66476007)(31696002)(6916009)(8936002)(38100700002)(54906003)(53546011)(508600001)(6486002)(26005)(8676002)(956004)(2616005)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?OStCM3liaEN1cjZmdGMvdkZWY2o2VFUzSndIVHN0TFY5UG5SejlxRTZXYmd2?=
 =?utf-8?B?cDUzWFBaYkRaMUNEd2lwSmUzMzUwb1Z2bTdxb093UFJiVmc1RVhPZC9icHpC?=
 =?utf-8?B?aG1oYWE2V0dwc0Y5bGZraU8rNUFKYy83ekw5VXVISFI3c3NLbitWWHVqQ0g2?=
 =?utf-8?B?NXVtQXRoSDlzVDRCWCtnWnNYSTZKTXIzcDdEWStDZE9JV1M3TTdCempNUEND?=
 =?utf-8?B?Z1R1YWtWVW1YNk5kd2RuOU8xZjg4V3Q4MkUxY3BGd3QxdTJPZFVHMVpCY0Ns?=
 =?utf-8?B?SG5DTEtZMDRRSU1Fbk5Cc3dpTnBYWlJGYjRNUEM2MkRocnBKM2Rkb3c4dmJM?=
 =?utf-8?B?dFpsZ1JFY1BRbHZ2TXFJTENqK0RGSlFYazJ2OVF3a3l5TzE4NGp4WkNPOS9E?=
 =?utf-8?B?cnRYT1RsVUFrWEQ2OVVXeEJ5ZzdUR3draTZ2eVdPbWc1OGkrUDl6NG1uNksw?=
 =?utf-8?B?MWJKV1BLVG9QcGs2V1ZYZTBsN2plVnRoZEJsUHFlUEwrdEt4alBVSUE4MWo5?=
 =?utf-8?B?TjRuaThaa0lIV0JHcHFvR1NvVmt1UFBWYjBhQjYwbGlKTjhqOU1VMFU1RFJy?=
 =?utf-8?B?dmRZRG1EVisvYjJ6bHhjV2VwWm5RSUtEcVRtNVNRRG5KYUo3K29QVzByMWZM?=
 =?utf-8?B?VTZybHV1eXNmRnFUSXV4eVVLeWRtOWxiUWpXK3czWXB5M0tqVWxtWHpXblBl?=
 =?utf-8?B?c3FXRGZ6d2VkZzNUM0QzS2JEajlzTmpGeVlid3BwQ1FJNlVjcDhTZnhCTEJZ?=
 =?utf-8?B?cVdxcG5GOWFtaVBDb094eU56RHV0QlFhMW5lTW5pQkxrTlFuMnVHclc2bk9y?=
 =?utf-8?B?RWxTTHlzeE95aGdkc2tHSGx1NWtkZjh1UisvWFlRRjgxWW9laVlkQ3lyRVQ5?=
 =?utf-8?B?dGxNTDM3VWxuOXo0K2FNdWdpOCtBdzR5c0wxWC9YRFd2eENxeUU0LzYzb3Bo?=
 =?utf-8?B?eDVUTW5xbnUzaHQ2QUlndExzSWgzU2Z5ZDA5eUJGOXdDdWx6WlEzRUpDeUFs?=
 =?utf-8?B?dWlMUXJRaTErNWVBNnRXa09ma0JIN1hsVVhDMjZCbkxrTGE1NWdRRytONmky?=
 =?utf-8?B?U2Y4THN6MnoxUnFaa3JZbFQwNlJNeDhvd2wrWGNQS1dQancvenB6U0xYQVo0?=
 =?utf-8?B?Vkp5ZFVYZlVZemlRSW01aEF1ME55Q3Q3VEJOM3BKVklCcTlpL0MrVEtCSzJD?=
 =?utf-8?B?ajFwQWNkMmRadStBQ2ZrcXZqWjlTY1pBRjBHM3FpeXQ5VFo0aXYrR0JPRU9x?=
 =?utf-8?B?UXZnLzZLSm9SZDF0eWhjaTcvK0lydkl3ZCtHK0JGYW9uSnoza3pPOWZoTHha?=
 =?utf-8?B?N0lTZDQvRjJ2QkdHVC9EOCtuMEc5NWRrYU5jOE9iYklTdnh4dnBLNHNxbTBZ?=
 =?utf-8?B?RmxYcnVsQ1dIVDNmNFdUUDZ5d241dmlVT09jdXJxQjB3MnlvcVk0NHVNc0sz?=
 =?utf-8?B?TVk1K2Z5VkUxdC9uQ1lkbHZtb0prWUdHdTdOVUg5c2VIdHdrR0tteDg5Y0VJ?=
 =?utf-8?B?dnpSNnhwamdlOEhYSytjK0wwNmdXN0JLcTVmOGlTb2ZIamg4b2svRUE5RFBL?=
 =?utf-8?B?SEtxa28yU3ArcmJ5Um5SK0RETWZ2ZFBxZ2hkTk10M1A2dG9PSXQwOXZhMHBw?=
 =?utf-8?B?Sy9PTGd4Z3dvYTRBY1BRTVVacG9QQnp1djdJeDdldzVxbzg5L1R0QXh2QWow?=
 =?utf-8?B?QUZWMC8wbWxyMlp3M3NRNW5RZi9GMFVzRmtJWHU5SThOUlhBcFd3YWZkUnA0?=
 =?utf-8?Q?TTfrjjrpikysFzPvMn0pCXtm/MzFcm5nKKenjE0?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 926104f6-1c87-458c-f98a-08d992319405
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2021 12:19:48.5127
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: lcENEt/uFsWn8KTZkEF59abLqil2t+QDQ/15C2J8KWxQ7cuXxKQJTgpRNUx0l20q8kAaSMTu5qNNBlO+8CLq9w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB2959

On 18.10.2021 13:27, Ian Jackson wrote:
> Jan Beulich writes ("Re: [PATCH] x86/HVM: correct cleanup after failed viridian_vcpu_init()"):
>> Since you've been looking here - any chance of getting a release ack?
> 
> I don't think one is needed[1],

Oh, okay - I keep mixing the different forms of "freeze".

> but FTR
> 
> Release-Acked-by: Ian Jackson <iwj@xenproject.org>

Thanks.

>> Perhaps also on "x86/shadow: make a local variable in sh_page_fault()
>> HVM-only" and "x86/PV: address odd UB in I/O emulation"? Aiui that's
>> going to be needed from today on ...
> 
> I assume these are bugfixes too ?

Yes.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Oct 18 12:31:54 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Oct 2021 12:31:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.212170.369937 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcRnw-0000ox-2L; Mon, 18 Oct 2021 12:31:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 212170.369937; Mon, 18 Oct 2021 12:31:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcRnv-0000oq-Va; Mon, 18 Oct 2021 12:31:47 +0000
Received: by outflank-mailman (input) for mailman id 212170;
 Mon, 18 Oct 2021 12:31:47 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=628V=PG=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mcRnu-0000ok-Um
 for xen-devel@lists.xenproject.org; Mon, 18 Oct 2021 12:31:46 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 5ae63675-300f-11ec-82d5-12813bfff9fa;
 Mon, 18 Oct 2021 12:31:46 +0000 (UTC)
Received: from EUR02-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur02lp2054.outbound.protection.outlook.com [104.47.6.54]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-23-oPzEKDNcNheB25fUFe7NQA-1; Mon, 18 Oct 2021 14:31:44 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB4384.eurprd04.prod.outlook.com (2603:10a6:803:6f::26)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.18; Mon, 18 Oct
 2021 12:31:41 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.018; Mon, 18 Oct 2021
 12:31:41 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS9PR04CA0068.eurprd04.prod.outlook.com (2603:10a6:20b:48b::10) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15 via Frontend
 Transport; Mon, 18 Oct 2021 12:31:41 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5ae63675-300f-11ec-82d5-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634560305;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=jfqe/YEfxCbwvfLVoWy/0S77ziqucFehXqYss2BRZPw=;
	b=JszrLAP6NE5Se/NoCthX/M9txImXvFkSCFG44TTl0fH8u/9wwCCyzuy2e8vMmsij6qXcN5
	rWvhZXOiSfFsSxiv5yyW5ACqBqq1QKd8MkbtXjQgH0uwSowUXbi3jvZY/EYJJPA1/ZVH4T
	tefCq50VgU++djA1lXwt0i9k+lhNvPY=
X-MC-Unique: oPzEKDNcNheB25fUFe7NQA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=VDMTu8QfbEYgUvvtdju0pj1/T8zvk+6TX2O3pc2OgqXAIwFFFXoezytLL9LWW4uuadFbVvZbhiv1RgUWAOPoAb62Do/Xi2G+z4s/louPDBhG+l8llCxgCtbsbD+PcOd/qXcdPawePeLnJH3A6oD9BMsIhDvtSAD/eIcNgZdu/AtZ//HAeblE+89lQxnGVv2/GBxRZEsOIsF4yOMJGn2kRiqQJKiPlmWVIOzs00Nge2tjiWBtPRN1CibeljV8TiX6nk/CrGenY1cHtaS8dhCYm4NxbrDrHQ7o3cMgoxDBnzN/TyE6UkkR2ju52LH2IkqJSwLk/dt2fW1yey0aEWQ18A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=jfqe/YEfxCbwvfLVoWy/0S77ziqucFehXqYss2BRZPw=;
 b=JDr5+Gz9fa3midXW5wK28c7OJTdrvt0mrYxJZ15xYPBOnAJT1gm9qVsjH+oGx5Gyx54Q8OyXGRJ+vLLraQSmyVJ0Etu62jdjuqfEBKcnN0LxfSCqyShORdaoeaNQy7bo2sZ1urK6z5+TwviXUn7HIEzi3GAm1FAggDb9KolHL1sRoWabEjlfDGN1QfwmYsTxxf10JmT18dkzhtuUiVp3+YLvh2sr1It5rVNab+9n5386gEftPhsl/aQsp4JH1bCFWKmRgP9mcYglkRJhuPrA62bApo2/4d4EPVSiUoPxiAJAX6obVts4GTyZeunx8fUAmnwnIFjd5js2/ao0C88NfA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [PATCH 04/12] xen/x86: modify hvm_memory_op() prototype
To: Juergen Gross <jgross@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>, Wei Liu
 <wl@xen.org>, xen-devel@lists.xenproject.org
References: <20211015125152.25198-1-jgross@suse.com>
 <20211015125152.25198-5-jgross@suse.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <71fae3b2-9f90-878c-50f1-e9c0d7cf7e5c@suse.com>
Date: Mon, 18 Oct 2021 14:31:40 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <20211015125152.25198-5-jgross@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR04CA0068.eurprd04.prod.outlook.com
 (2603:10a6:20b:48b::10) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 828cdda2-68c5-44b8-6c8a-08d992333d2c
X-MS-TrafficTypeDiagnostic: VI1PR04MB4384:
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB4384C898087C0C60568FCA18B3BC9@VI1PR04MB4384.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:2582;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	8lezL251FqCX/Ar+oQQuk1e9lfls/gJ2UPgMiXrWlb2RzP+bCJFssWVMadxtNf966rX5MLd+qoXE0UjMfiDHX1rmrn7k1FtLYF6sygXsNDO6WYO6yeP/vE8KOrbCYvOZbVge8vDCyWNfJ4e73AAJLmfH4nUB7N8jBEdRQIRF02YpPCnwyC9Y3hMs+xxhgjyJNDieAHsCz/ZU3wqNF/arv/X76DzxQhJ7j3CHAZKA04PevuWm6WPeHJZX0MB1fj+KEiBGR+N9NJA5+MFWAUr8SqTQRXLhzS33YjHIO4WQ3/MxMhjGKlZ2FbPjOoWOkTMoEhmtYtroYus5tyeNUTVXZyCpWZ610I5XvP8/36IL3V2oysKC4fIN3gQ4siF66cqkojESZiOt9zKJKaUGLhf7pBDlgbglD1IRkQ6ft75d/aKLSGFq0wBkIbO6rCp2/MHSpwzRhnKtEY6NcefLzyCl8wSTmVmEt4aSvycyAKTyBi5NhZyh2/Efn82oOHhiMGFofAKvWo0cy2AZRqXbER1cQ8TOkiclbebYALQj0A6wS1+KbKtaqn0Tl/BcpN18rMbZa5oOY0SQJGFDQuuiBFJp4oZsNJj72OpzcgVYM5SOxVqTQU1rUGn+AjTkDZPxkdXuLXhrAW3x1Jz8D00tvZvxp1j0nv4+4Y/h1h5Vf25lg5OzmXDBVQkrObOe8i4rOqKXkVYboyVS3es9yIW1DKWA+iKml7H6CGnsAF9OscUG0arkhTbkvbWo7tlGU3ffGrz7
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(4744005)(8676002)(26005)(186003)(37006003)(8936002)(16576012)(6862004)(316002)(4326008)(53546011)(54906003)(66476007)(66556008)(31686004)(2906002)(508600001)(956004)(2616005)(6636002)(5660300002)(6486002)(36756003)(66946007)(31696002)(86362001)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?RTl0NG1PTzMxdUZNcllrOEtydFZZQXZtYUs1NkdPYlhkckhBWEZ1RkZSeFFJ?=
 =?utf-8?B?Zi9FcDZUejU1SUsrZ2RVdndWMWJuWWZYWkFWK2k5Wk03UjRrcnVVai91emcz?=
 =?utf-8?B?cXBabEplVkpDSDRDZlYva216UkNoNmZ6R2I2Qi9KeWdEajhzbTZsYndHZmsv?=
 =?utf-8?B?c0xrR1BiL1d0OTZoVGhTMFZYamdvUEhQTVBzQytDWjNOeWxxRjEvRnpiU3Bz?=
 =?utf-8?B?djhkMG11a0NyOGdnVTNUc2NMaG01cVkyZkoyVG5BdUZIa0dCQ0tRZUxXZGtk?=
 =?utf-8?B?SjA3cHRyN3orbGd5a3lEbkRnazVTd3RWV0RqU3pMVGNCNjJVRjNBQjNiam1n?=
 =?utf-8?B?ZjREejg3MlRoZDZrTy8vMVQzdjlpcjBpLy9xOHZPN054d0hhbWplUjdVOG1G?=
 =?utf-8?B?d3RPZ1F2MG82SG5RKzNvTWIzZSttQ01BOW4za1VmMHluS3dkcXFMTWVYSXZO?=
 =?utf-8?B?QWRMb3FFN083L0EyM0p4QzJVMm5Xa0VwTGVqdFl2M2o2Y1ZSbWEzNjFZNnlW?=
 =?utf-8?B?b21ZMm5ic2l1WFY0d2UrdnczZ1dFc29tSzFTaElmcmszTmoyVXVDYnR0NzRh?=
 =?utf-8?B?NTNsSE1KbkkrQllzbCtQVUd0M1NnM0ZXNmY3WnNnN3VuTlVuOHFkU2tpWEwr?=
 =?utf-8?B?dllveFJxeXFPQ2l5QWVabHNTSm9WWXZEa2NBQ3g0dU5ldkR1TUprMDBvMEZx?=
 =?utf-8?B?QlI3ZmRhOFpKSGxkc2NhZElyV2tBZW9mRUlRRm1qRStjVitRdGlTRVhxQlFu?=
 =?utf-8?B?TnZaTG5xMFFYamFIK3EwSytoTFViamg4S0pIOFNhZmRCZGtKaUR4ckx1SzIz?=
 =?utf-8?B?QzEvM2RNOEtJYmFNSXBpQWx1NzcyREFoQit0Uko4VzFLUi9ZWU5XVzcvMkQ5?=
 =?utf-8?B?dHZVNDNuN1hLRFNnclBLY0NJQk8rNGtNZUNSRm4rQU91anFLSnlETVY4SDZB?=
 =?utf-8?B?aFk0OFhEM0FhVThQZGpJc0IxbDBPRWVsaFJXQjZFQmVrQ1B2aHFsbkFnYnZI?=
 =?utf-8?B?Qnc4OGU3YytkVFRYdTJVQk1JTjIvZWtObSt4a0E1VkpOTEtmOUMxK3JWbFJu?=
 =?utf-8?B?RlM0eDlnZlRiTXM2bHFIU1FWSjRaSnJXR20yTHJRd1VSdkozdVV2QmhTSDVD?=
 =?utf-8?B?ZUd1T1pEL3FBcCtmWjhoaGNIUXovQ0lObmNWM2dDVFltSDlMdjI5VE0wUlMx?=
 =?utf-8?B?SFo5SVdsTUVSTVVlU3ZJV0FIQjZ0L3FVYXpSbDRzWVJaL0p1bTRwelFDTG5H?=
 =?utf-8?B?VDhmWFhQd1RIMWNDM2FVc2Q0YVN4M1RvcGpaUURDdTA5bGpYN1hobW5reWd3?=
 =?utf-8?B?a2g3dk5vZENYdnU5Wm50WURBMEtURmtYMkZ5TjQreGZERjFlc2RPRENCekV1?=
 =?utf-8?B?cnZNZmplTzNuN1piWW5hZSt5U2NWNlJZMEVNZFRlVEpXTGpFQTJYVzJZaVZh?=
 =?utf-8?B?cUtFU2NhMnJmMjJYb2VIYjczdGlTZituTnlWTDN5TkNWcFdYSWpZTmswd3pz?=
 =?utf-8?B?TXRZQTA4V1hZY1M2RFlKc3JXdHFoQytmUVlhZWxoK3V1L2tFR2kxU3drOFNT?=
 =?utf-8?B?SGJVUDlNTFkyRUpheFRpVXA4TjVaS3N2WkNCUmJocngvVDlUYkowOWZFZkhy?=
 =?utf-8?B?c3E4VDN0TnJZb05tZGh0R3dHUWNRUFFlZGhQZGtnUENvTEE5R1VkcnlyVldI?=
 =?utf-8?B?Zmhkci9ubVlBaHZKOHFUNXJJYktkSFloSEpaQ2dnTVVXQVpSUFJRREZzSkpn?=
 =?utf-8?Q?RXgLOGpxplVb/8SiSv0oMQqFVQA+Oq63jnbfTWf?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 828cdda2-68c5-44b8-6c8a-08d992333d2c
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2021 12:31:41.7894
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: stF3GH+l4T07BNZ1/UurEWnNPvVhl3eD1gNeUoSwD1jvJkU/8ojbXharjyn5fHfaoWdq86pt2CZ6Q19uBEvhtg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4384

On 15.10.2021 14:51, Juergen Gross wrote:
> hvm_memory_op() should take an unsigned long as cmd, like
> do_memory_op().
> 
> As hvm_memory_op() is basically just calling do_memory_op() (or
> compat_memory_op()) passing through the parameters the cmd parameter
> should have no smaller size than that of the called functions.
> 
> Signed-off-by: Juergen Gross <jgross@suse.com>

Reviewed-by: Jan Beulich <jbeulich@suse.com>

Nevertheless ...

> --- a/xen/arch/x86/hvm/hypercall.c
> +++ b/xen/arch/x86/hvm/hypercall.c
> @@ -31,7 +31,7 @@
>  #include <public/hvm/hvm_op.h>
>  #include <public/hvm/params.h>
>  
> -static long hvm_memory_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
> +static long hvm_memory_op(unsigned long cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
>  {
>      long rc;

... I think this would even better be dealt with by splitting the
function into a native one (using unsigned long) and a compat one
(using unsigned int).

Jan



From xen-devel-bounces@lists.xenproject.org Mon Oct 18 12:40:12 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Oct 2021 12:40:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.212182.369959 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcRw0-0002PN-0I; Mon, 18 Oct 2021 12:40:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 212182.369959; Mon, 18 Oct 2021 12:40:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcRvz-0002PG-Tc; Mon, 18 Oct 2021 12:40:07 +0000
Received: by outflank-mailman (input) for mailman id 212182;
 Mon, 18 Oct 2021 12:40:06 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=628V=PG=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mcRvy-0002L4-Q7
 for xen-devel@lists.xenproject.org; Mon, 18 Oct 2021 12:40:06 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 84ddb942-3010-11ec-82d5-12813bfff9fa;
 Mon, 18 Oct 2021 12:40:05 +0000 (UTC)
Received: from EUR02-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur02lp2052.outbound.protection.outlook.com [104.47.4.52]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-21-mMD5NsD4OBilhcl8h35RdQ-1; Mon, 18 Oct 2021 14:40:03 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0401MB2448.eurprd04.prod.outlook.com (2603:10a6:800:52::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16; Mon, 18 Oct
 2021 12:39:58 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.018; Mon, 18 Oct 2021
 12:39:58 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS9PR04CA0033.eurprd04.prod.outlook.com (2603:10a6:20b:46a::8) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.14 via Frontend Transport; Mon, 18 Oct 2021 12:39:57 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 84ddb942-3010-11ec-82d5-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634560804;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=ipJNu4qj6dm2jYX0skiI/XOERdPqIDqfgYF+nBOsLdY=;
	b=QtoJW/Vr48HiA1ux0iG/y5fGikX/IUL12/QnHgbEDJNSlq/2fFOHh9scVjZ+Ha0X6hOhxq
	W49JH9zLOM0QOLQlImj4CmvzqRHRFkyzOX/WKTfXXFpkZkg05rm8dZv4l+98tP6JU400fS
	hUTMf8TsLKp9Q9XMDVn7i0my+/XfhEM=
X-MC-Unique: mMD5NsD4OBilhcl8h35RdQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=WDvmVzyhzpQXsdqgxbu1qYcp0Wh9312WfjE1rnxuVyLpwG0B9+TwGqU4lJCktP5RZUcmF167wPbIBzby6uX76Y2IOsbbXb5oIpsKrpsyF26cmlFcI7xsaiZ0zRV2+gDgIp/RlHDzqxfhQtZ9kl2AsTA0La5hypX5VCJVwZ8SXq8KGgkFiVO21ec6XTmQYbHf2OVvlnRhaQ6sq2mThV+A8uAkA+54bbSGR5yHwntLA8D4rNc7qg3te/Cczyrp2k0PlXC/tUbifFBA/An+Eg0ltVRPFmJPqQig4TL76p+50DZb4Bhu87U/+0xSAKBJns1APFIrjcGrTWvJoeOh7Z7iyw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ipJNu4qj6dm2jYX0skiI/XOERdPqIDqfgYF+nBOsLdY=;
 b=dwD/y7F0f5c+fiG2voKzkFst7ijmBrPQQas/adSKxMXdEU9NuKj2pbukrKTCd6INm/e4oBcWq8deUp0lKsdTMg8o444D5R9IH+Ap+Ps2WdrA75oXht1zUPg6Cp0rpXd/0Tr9FyAAyXjhIV0WNjEHPQ1BW5kIQan0BWRWVA/d8CureeiorampHj3oImpY9+WsoVIRcWa5xqna2VWoFxhiJrajzsyODTVT1oRyHe5/SwuiPzS/KiyH5jgWTh9N0oKHPk5ki9hYXHCUxBmg925I27q9y5rlzBs6FBLU6t2je6/dBlgTpV1+gQN5j4xl7+Tx88EUqBn+71Jn8gtgifsyXA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [PATCH 05/12] xen: don't include asm/hypercall.h from C sources
To: Juergen Gross <jgross@suse.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>, Julien Grall
 <julien@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Wei Liu <wl@xen.org>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>, xen-devel@lists.xenproject.org
References: <20211015125152.25198-1-jgross@suse.com>
 <20211015125152.25198-6-jgross@suse.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <d26c7087-8c39-9624-bbce-876cef47f84c@suse.com>
Date: Mon, 18 Oct 2021 14:39:55 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <20211015125152.25198-6-jgross@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR04CA0033.eurprd04.prod.outlook.com
 (2603:10a6:20b:46a::8) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: d8f9142b-f35f-4836-4afe-08d9923464ea
X-MS-TrafficTypeDiagnostic: VI1PR0401MB2448:
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS:
	<VI1PR0401MB2448A536F4B0BC2BB5EE8861B3BC9@VI1PR0401MB2448.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7219;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	t0tOMVmToJCA/Nm/qby8KcfhjRPwuDx+2zO24BElSRrcQvCVGiLhC3T/pY3/n5UZq7dQpCHmAb6ZTKyghh4HVCs7K19IAHV7JYSVGkeDFIZkHXUyolr0IJrngdh7HCKRnEa0RNgCE6ffJr3u06vKrRVH4Vs6ko2Y/HTUeyOlqEUJiMQehOKPgqcRx2SGrbpcSosgSV0MTUeSjeI01/q5sZIUh4g1jtMyVy6m5mmVxLV2IYHQFQIrv7f+kS6+rQc4LrhyJ+cMhjuunhz6zt5XKJwXdKSQkQomd0ycd2YjzqxIs+3JbwocwW0oTmP6JIc/aZyM6h1Um4xdjwCWkYuQPIHaT+26lehTODYuY+U4lSUt6RXTq7JDqYCvo1qtZNO5Uguq2N6yACCurrS9Cb7GaXJ9MeLLvyHfix7bb1J3C43sQQmVYQJmPhxicHkmabXkIowJ1b3gwKgdP8G8bJMt3OWBSEFJTNqZR8s7TlTeoTC3DUiNlQLCej2C5SbLGqayZPgYehOwqdQ43YtGDGPamBjenKb6+1aXq4eienzxxg63OCUofuZ8ucr6LOlWAI4NUpQxG32SwQRqRsZG4+QIFUNSlFYIVVCu2lb5kJmmzR2OIp+i0HfrJJ/8s38x6pHxqTlVmVZPVR3vO8062TVLoo2TRaWrGULXEFtGoHNQ27h+YUjDN2Hohl3pQcXXkb4FavR6ocSrrrpIa8pMeToFlJiGGeANC8TWHfLiL/qxNvk=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(508600001)(31686004)(186003)(31696002)(2616005)(66476007)(8936002)(2906002)(36756003)(316002)(66556008)(4326008)(6636002)(5660300002)(16576012)(38100700002)(6862004)(8676002)(37006003)(54906003)(66946007)(86362001)(956004)(26005)(6486002)(53546011)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?SHAvZU01M3NJSi8zRlYvTXhNVytPaXAxNlNmZTl2TzFveTJRMHZZZjBza3VI?=
 =?utf-8?B?eExsWjZDaVBoR3gyODhMUUE2VWc4YU5rYXVXdms4YVJFL0NUbk90a1hJdXNo?=
 =?utf-8?B?Y0dDcG5lNFdoTEp2VmxzcXk3d1Fta2U0RUVlaEk0bEpFR3l4UzdpNmw2dDh0?=
 =?utf-8?B?UFo2dVdQRXJ3UkNQMy9RTk1veFd5MjJrVWpxUlJhbUp5Q2hGTWNFaDJITFYw?=
 =?utf-8?B?K3RNckh2YndMTmQwd2ZGelNZVEg3eVBzd29iV0FJM2RwczNLVUhMRWFpeVRl?=
 =?utf-8?B?bXpNQlNtZnAyTUQ1anplRzhiZFV0UUUzaUE1bEowRGNOQi83SVJuS3NXM200?=
 =?utf-8?B?TWY0b1pQTVo0cmlFcVBFeklYZkVNenN6azRsNTQrVHlTTFNRRHRrMzZjY2Uw?=
 =?utf-8?B?SkxVZW5oZENuTmFsa0dySm1EaHhCd3hFck9VaExuQVBMQnI4Z1Y3N3hwd1ZF?=
 =?utf-8?B?RWUzU2wyN09WSmF1bC9TNXRpOU0wTHJ0QjMrSEhpZzNwS0g1a2NPdmVzR1Rl?=
 =?utf-8?B?d25ORnlnQ0NrZjVEdGdia1l3dHR1bTBPalIwUkFSSEIvdHZxQVlUcWxsT09V?=
 =?utf-8?B?NkE2QS9mUkdVYjRyakdiVzdIUFV6VHo0SzY2RWFVd1lPTmgrTFFibC9rVnhy?=
 =?utf-8?B?N1J5Vi83QUlaeklGeGMzVkxxKytYVVQzS3I2bDZNUUdwRDhhcVloRkI2eXdY?=
 =?utf-8?B?cytBUStvZWU2R2Jtb3VmOG13bUlQc0t4UDRCQVVKa3FUS091WVVRcWNIdGFG?=
 =?utf-8?B?dzZQTkVrSm4wbzFERTZQTHMxQ3V1Z3Q4bnB0NXlNdE1OeDBhOE0vd2hIdHhs?=
 =?utf-8?B?aUgxdGR4am5jSStiOHAyNnl0MlZlemlTTjhXQlRLQ2JxYXNzczF4amRsbjBQ?=
 =?utf-8?B?RlQ1dDRGQmFMMVd3T1VCcjZId1NBZWp6aXROYWpoc0poTm5ZcTY5WEIzTmd3?=
 =?utf-8?B?YjhRRWdrNDh5dDNod0tNdzRvSmFXQXB2Zm9sSGZuaXg5T1dTWmJOMFBqdTIv?=
 =?utf-8?B?MC91MUluRWE2cDUvamc4a05EOGNZZ0lNQ1NidnVTb3h0bVdkSkJyNWhKOWlO?=
 =?utf-8?B?SlpvbEU5cUtONkVsWWVtMWNxQ2pWMTRpeERjd082M3padGQzbVJuc01DWTVw?=
 =?utf-8?B?SlJISHJKOFpqYUo2OVh3akZUUXlucW42UmVKdDBpcW03cUVkQmRnRkthdERt?=
 =?utf-8?B?RHZjTEtQbGJWTlZTUzFsL3lpMkpVdTNMTmZpTHQyekJIY0F3aGhuYlYzZmRF?=
 =?utf-8?B?RDVOb1VoTldKMk1RZmVVRXlqTDZMcWZUSDBSOGNQVzJxSjZPVzYvQWZMYXNi?=
 =?utf-8?B?djFUNEhXOEozZVVWTE5ZYWlyMjEvOTlMOHFsNUhjNTlYRThtWkR5VDFJYXFL?=
 =?utf-8?B?ZlBKT1FmT3dORnlnNWc1TUNlS3NIYnhNVVV1RW9ERU9oYlBzazRWbGhTM0FT?=
 =?utf-8?B?TUdTL0lqbUt5RlNIMHhQWVhZZGtRK0NWMEdINllEQzEwY0hRMVJZWS9UT3A5?=
 =?utf-8?B?eklhaGlWRVVLdjQ2OXQvZjg3QUZpcmlpVGt5QmNTbDBsNHVnSEV6dFB2OUpi?=
 =?utf-8?B?Y2oyVTZwUmRwbXEvWGl2TFo1ZVM3Tlc3ZVIzUWdFbE5SV01xd0xhczA0NEFz?=
 =?utf-8?B?TWU0Rmx0eGFnWW1QSmJqU2ZQaEQzdG5IZzRWbWk1bldZYlFHdi8vQ2pVWktO?=
 =?utf-8?B?eDkrQkdXYUNlOGw2ejFhQWpFY1JQSjJpVXNSSWhXMk1ZRXRYWlFnUFhZcUNj?=
 =?utf-8?Q?8TAuLiXLL9vai+odFPmw2lXXW7NKxv2rS/nZgl8?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d8f9142b-f35f-4836-4afe-08d9923464ea
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2021 12:39:58.0145
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: RMg6akVIC1ert62L99K5PBK0d+ymH2UAgkEpeR5Nm+fSB/N07bFo+1Oe5tiemGc7niOHzk3Y958pDYfT4i+GGg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2448

On 15.10.2021 14:51, Juergen Gross wrote:
> --- a/xen/arch/x86/x86_64/mm.c
> +++ b/xen/arch/x86/x86_64/mm.c
> @@ -32,7 +32,6 @@ EMIT_FILE;
>  #include <asm/page.h>
>  #include <asm/flushtlb.h>
>  #include <asm/fixmap.h>
> -#include <asm/hypercall.h>
>  #include <asm/msr.h>
>  #include <asm/pv/domain.h>
>  #include <asm/setup.h>

Afaict xen/hypercall.h also doesn't need including here. But I can
agree that this is at best a partly related change.

> --- a/xen/arch/x86/x86_64/platform_hypercall.c
> +++ b/xen/arch/x86/x86_64/platform_hypercall.c
> @@ -41,8 +41,8 @@ CHECK_pf_resource_entry;
>  #undef xen_pf_resource_entry
>  
>  #define COMPAT
> -#define _XEN_GUEST_HANDLE(t) XEN_GUEST_HANDLE(t)
> -#define _XEN_GUEST_HANDLE_PARAM(t) XEN_GUEST_HANDLE_PARAM(t)
> +#undef guest_handle_okay
> +#define guest_handle_okay          compat_handle_okay

Is this a change that slipped in here from patch 3, accompanying

-#define do_platform_op(x)   compat_platform_op(_##x)
+#define do_platform_op(x)   compat_platform_op(x)

there? Or does that change belong here? I have to admit anyway that
it's not entirely clear to me why this adjustment needs making.

> --- a/xen/common/compat/grant_table.c
> +++ b/xen/common/compat/grant_table.c
> @@ -4,6 +4,7 @@
>   */
>  
>  #include <compat/grant_table.h>
> +#include <xen/hypercall.h>

Nit: Generally compat/*.h go last.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Oct 18 12:52:58 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Oct 2021 12:52:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.212193.369971 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcS8I-00041N-9a; Mon, 18 Oct 2021 12:52:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 212193.369971; Mon, 18 Oct 2021 12:52:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcS8I-00041G-6J; Mon, 18 Oct 2021 12:52:50 +0000
Received: by outflank-mailman (input) for mailman id 212193;
 Mon, 18 Oct 2021 12:52:48 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=3tpC=PG=citrix.com=roger.pau@srs-us1.protection.inumbo.net>)
 id 1mcS8G-000418-HK
 for xen-devel@lists.xenproject.org; Mon, 18 Oct 2021 12:52:48 +0000
Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 0d9946a3-3473-4763-93f2-68bd088492e5;
 Mon, 18 Oct 2021 12:52:47 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0d9946a3-3473-4763-93f2-68bd088492e5
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1634561567;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=lHiTrZDdt1r7yV9z+cION0Uu9OUEbBn0dRS67XA0JXw=;
  b=hYGM4q8ucm+wlLGoKb9j5alSmc0CxLNWumzTo6i2Bx67nMeFiBb5//W4
   6LZR/8pKVcnC0tx32aY3JgAXFTWW+9SODVTfJoaKbvDw3Jtx8CDVAqBRb
   Bn12fNt6tCLwWcvdjfQpwGByIn3V2MOj2NV5a5OhD9SvM5xtgQdFftDbp
   g=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: TfFC3RXOjTaeYtaGwovoWzwQqZYigTtcaLj1Jv9zH9ia5lpEMdpslwE9Lwxi4f3hfzHJEAQv3i
 QfoM0S6NiiUKZV8fdXW4flM0QUunmv+olKhiiJViFVbp5dmJYVfQVTOzlEvuC8AC1cXhznMl74
 vdQIiOB3pOnwiY86iajaanoJYAvZS3lxcSdjOqn0jNf75wVKQiFnla3ei7OwjbuI/+sSlKxn0m
 cKumWjnOv1iWDKqfAQS9ss70cLg3+gjDFjprn+rM1NFgcpSi7AEzt1burPA/9rfeDPbxKJdvAv
 /C4hmPZUwt5SFalb+B13wb2F
X-SBRS: 5.1
X-MesageID: 55417946
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:Rceh6qDliJ+j6RVW//Lkw5YqxClBgxIJ4kV8jS/XYbTApDJx32AAm
 mNOXj3UPfiJYWWjL41xb4rjoBgE7cOEyoJqQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA
 xA2M4GYRCwMo/u1Si6FatANl1ElvU2zbue6WLOs1hxZH1c+EX550EI7wYbVv6Yz6TSHK1LV0
 T/Ni5W31G+Ng1aY5UpNtspvADs21BjDkGtwUm4WPJinj3eH/5UhN7oNJLnZEpfNatI88thW5
 Qr05OrREmvxp3/BAz4++1rxWhVirrX6ZWBihpfKMkQLb9crSiEai84G2PQghUh/lwiJs4h46
 NJ3kd+UdwMZA4Kdgv44akwNe81+FfUuFL7vJHG+tYqYzlHccmuqyPJrZK00FdRGoKAtWzgIr
 KFGbmBWBvyAr7veLLaTUO5ji95lNMD2FIgepmth3XfSCvNOrZXrHviWvIAJgGlYasZmHNDaW
 ucpdGJUZ0rrYR5IGwgMEKo5g7L97pX4W2IB8w/EzUYt2EDMyCRh3b6rN8DaEvSaSMMQkkuGq
 2bu+2XiHgpcJNGZ0SCC8H+nmqnIhyyTcIAYGaC89/VqqEaO3WFVAxoTPWZXutHg1BT4AYgGb
 RVJpGx+9sDe6XBHUPHhYh2U+HekuSQ4GP5uF90Hx1CX0I/ttlPx6nc/chZNb9kvtckTTDMs1
 0OUk96BOQGDoIF5WlrGqe/K9WLa1Tw9aDZYP3ddHFRtD8zL+dlr1nryosBf/LlZZzEfMQr7x
 CyWt2AAjrEXgN9jO06TrA2f3WzESnQkSGcICuTrsoCNs1sRiG2NPdXABb3nARBodtfxor6p5
 yBspiRmxLpSZaxhbQTUKAn3IJmn5uyeLBrXikN1Ep8q+lyFoiD4IdwBvWAkeBszY67onAMFh
 meJ6Gu9A7cIZBOXgVJfOdrtW6zGM4CxfTgaahwkRoUXOcUgHON21CpveVSRzwjQfLsEyskC1
 WOgWZ/0Vx4yUP0/pBLvHrt1+eJ7l0gWmDKILbimnkvP7FZrTCPMIVvzGADVNb5RAWLtiFi9z
 uuzwOPRl0wADbGjO3SOmWPRRHhTRUUG6VnNg5U/XsaIIxZ8GXFnDPnUwLg7fJdikbgTneDNl
 kxRkGcFoLYmrXGYewiMdF55b7bjAcR2oX4hZHR+Nle0wXkzJ42o6f5HJZcweLAm8s1lzOJ1E
 KZZK5nRXKwXR2SV4SkZYLn8sJdmKEahizWRMnf3ezM4ZZNhGVDEo4e2Ygv1+SASJSOrrs9i8
 aa43wbWTMNbFQRvBcrbcty1yFa1sSRPke5+RRKQcNJSZF/t4M5hLCmo1q07JMQFKBPiwDqG1
 lnJXUdE9LeV+4JsqYvHn6GJqYutAtBSJEsCEjmJ96uyOAnb4nGnnd1KXtGXcG2PT2jz4qijO
 7lYlqmuLP0dkV9WmINgCLI3n7km7t7iqrIGnARpGHLHMwaiBr96eyTU2MBOsutGx6NDuBvwU
 UWKo4EINbKMMcLjMVgQOAt6MbjTiaBKwmHfvaYvPUH3xC5r577WA0xdMi6FhDFZMLYoYpgux
 v0suZJO5gGy4vbw3g1qUsyAG7ywE0E9
IronPort-HdrOrdr: A9a23:g104haly0fvcZnNBK10rpYEdoM3pDfO/imdD5ihNYBxZY6Wkfp
 +V8sjzhCWatN9OYh0dcLC7WJVpQRvnhPhICK0qTMqftW7dyReVxeBZnPHfKljbehEWmdQtsJ
 uIH5IObOEYSGIK8voSgzPIY+rIouP3iJxA7N22pxwGIHAIGsMQnDuRSDzraXGeLDM2dKbRf6
 Dsn/avyQDQHkj+Oa+Adwc4tqX41pH2vaOjRSRDKw8s6QGIgz/twLnmEyKA1hNbdz9U278t/U
 XMjgS8v8yYwr+G4y6Z81WWw4VdmdPnxNcGLMuQivINIjGprgqzfoxuV5CLoThwiuCy71QBls
 XKvn4bTotOwkKUWlvwjQrm2gHm3jprw3j+yWWAiX+mmsD9TCJSMbsLuatpNj/ir2YwttB116
 xGm0iDsYBMMB/GlCPho/DVShBDjCOP0DkfuN9Wq0YafZoVabdXo4Ba1lhSCo08ECXz751iOP
 VyDfvb+O1dfTqhHjDkV1FUsZmRt0kIb1O7qhBogL3T79EWpgE586Ig/r1cop9an6hNDaWt5I
 z/Q+xVff91P5YrhQ8UPpZ3fSKNMB25ffv7ChPaHb3WLtB0B5vzke+C3FwU3pDhRHVa9up+pH
 z+OGkow1LaPXieUfGz4A==
X-IronPort-AV: E=Sophos;i="5.85,382,1624334400"; 
   d="scan'208";a="55417946"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Jq569W/rMWF290iCsK0z1pyO0OZzuZCPRVkYtm0Dk7madeda1BQeFjj8rND6dp8c/MWDZdhX5TbEd+nO+Z8W6HcmcJwKDmGm5N76xfG7K7SNUOF7PM3hucpl8loUKIzTW4mxhAl5YhUQBNH+uvR6x59N/++eEA4NDoigvZ0flD9yZCnCfveLwDQXQ8VWzAODyAnY9SzImh5vNxFKrxfAcGWQjZYdLSVMgNGdd2u/r1EkERpGCO4AqPsVsen0Khgd5ny0UDqZod/5NsKaDzk4zuwwyT9z/s02KSYTv3EfxbQKm+hPf4paL8iwailZ1KKA/ieYT0wcLZ43VDD1PIrIhw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=nINN8uLBn/KX27mhSapKsCS5RQcml78jX28DdteYTB8=;
 b=UCMBZigOqnaTbRojbgm6te6DmtCxDUeEC7CcAWvjX7Zn/aUoZOJE63k8h8iLxW55eZ9nzvtjGECkX6aDaXGx6TpKq91Gy1+wrzhBcuPcLQMc8T2kg+gx3ZLQ7CJwu09A2Id+zae32xefClrzIDyLrIObON5KzIokxRXG01SXvf5JOgrjfKbopTqLLl8zWAkvX5EWxt0M608KrHM6/0ukJpZWrUIXuwrZiog/CgJR+zjfdVeH8fpMzaj2BXoe92SCNAHS9dSWx/UIiufNXlvoH5qgL9muPX43SgvZddWzCbCp6SpcI1+ecEie+1KYQF9NRvAfGPBu4DfLzByeq6/bIQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=nINN8uLBn/KX27mhSapKsCS5RQcml78jX28DdteYTB8=;
 b=gizxa8e/Kr8uvOdhDYiJ4qolNUttvLAhc4bawx6CEcaBGfWXlqlwsA7hgGBPAKxroire2N/d63oi2IntB2uHpXZ/rwKdcNXyDZZLcvKEvEJpUt2UYlEkwxVvOemVBTnQ0SpKadAGIaHL0If289KKVFk8S7tkPPezGSuxWALFZkY=
Date: Mon, 18 Oct 2021 14:52:28 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, "Andrew
 Cooper" <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH v2] x86emul: de-duplicate scatters to the same linear
 address
Message-ID: <YW1uDKPt4OLS4v4a@MacBook-Air-de-Roger.local>
References: <cf935e11-27c8-969f-9fb2-a5c0e85ccff1@suse.com>
 <YW1YW8HJr6ttyd84@MacBook-Air-de-Roger.local>
 <a35c7be1-db42-9f7e-fc36-6b6abfd9e9a4@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <a35c7be1-db42-9f7e-fc36-6b6abfd9e9a4@suse.com>
X-ClientProxiedBy: LO4P123CA0288.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:195::23) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: dfc07811-8f3a-454c-6894-08d9923627dd
X-MS-TrafficTypeDiagnostic: DM6PR03MB4058:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <DM6PR03MB40585BEEBBAD5CA057585C6E8FBC9@DM6PR03MB4058.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: SQDbZPnQuQMHLKMdbt7nls5ni+A4xy/g4Y8ZXLMyDb6q6zbRk+w/BpwlmR0a52cylsBjWtQjKhhip8C7jwuSJlwLnjjjMOaIZfHKaez/x3fo+jlZds7iaT8nyXYsxStI+GJ3WLoDvkse5iEmZvgM1I2McDMN/voHY4XInAW6BUN4gxy77mpx6tXtlYVrGLc3R5k6yC0YlYfi0PSDEFPDY5EbtfjK4mVkR/KJK/yNkpCXPhNI/AZAcoRkvm1g8Rz78W1+XQJeu0fQK5New+qr9Va5NcXuCsnUmufqY9uTevDQyU5M0R/MbA9GZKCPj+NnBHxLALMbvqjMQZPiCO9zvB9tqh7XG09c+ZHjGi7nJ7BK8pf0/9Ydwg/vmvstTdgcqR/CvqW0vvYe2A7ptXPdgMSYSEVxXV3q72fPz+EvnrxR9JGDU+/+Rd+AmOPS2qR7Jxsg9igdyH66pqmuBdyJDCENptLwqnrpbgUnBgbsv8FfPa/J5P7bc4uI4mx0cK4/cbvaz9mvS4MXvsJCxncN3dlnVGo9VgK9ySVH62outQ6iSILmSP6GQumgaHmclBV/ii1d8Izvsk7FB/EvZ7vXEa8f86oXn9tlPtpaYO1A7WHgD2hWo+KYR+OVCVpPZhhV4S/AL9QwiwwfU9opRwIhdg==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(6916009)(54906003)(82960400001)(8936002)(508600001)(2906002)(8676002)(85182001)(6496006)(38100700002)(6486002)(6666004)(316002)(53546011)(5660300002)(26005)(86362001)(4326008)(186003)(66476007)(83380400001)(956004)(66946007)(9686003)(66556008);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UUJ4a2c1UVZKSFV1SmE5eXBENWI4cGlTSnlySGhOSncrVytMVEg3RGtvbVFB?=
 =?utf-8?B?b01QTmJTV1AxanVtZVBsenB3N2hOMDlEQ2tZY0FUenJTUXBRWWtGeUd1cyt6?=
 =?utf-8?B?Rmh4NEIwM090ZnhlWlN6MjVwb0JyU3gzTzlVa3Bpa2RMeEtSMDVOWVNFOVNQ?=
 =?utf-8?B?SlJhcnh2MlptOVlnRWNMYnk2SjhxUlJPbC85a0J5aGlVTk1XQ2ovOEdsWklQ?=
 =?utf-8?B?U09HUll1YXdSUytQekpFdjFWS3lOditEanlpbndteEhNdHc4WitXVjVEQmw4?=
 =?utf-8?B?VTU0K1pXV2R6bjhraGVWTzVwdnBYSzFtQ2R6bEF0NU5EN0ttTFJ4QyttVTBO?=
 =?utf-8?B?aFZLL25YYWI0dklqZVNleDV4d2FxK3JvUjNZbk9ITXdhcVREWEx4WmVQdGd3?=
 =?utf-8?B?T0pUTU9PZEwzaEhxUVFnQjFmRW9YSWpMOWp2WFBZTUIyaGpISkIxL05uc2xU?=
 =?utf-8?B?cGZWOHlRSFRJcU1sbzd4NnlWK2x6TjJCd2pmVEFVKzdzMlVLb0NrcFdlS0Jr?=
 =?utf-8?B?N0Q3Nm9YaHZyaE95WjhxMmRCTzVoNitnVVRmblJVN3RzRlBvZUtKenhkUXdY?=
 =?utf-8?B?aGl0eTFDTXdteW5iOUVYdDhBQ3hpZktiN1loTjhqaDl3akJwZkhDRXNBRGNX?=
 =?utf-8?B?NTNGNStUamNOc29GaVdtZFl5WVlUUzFiSFI3a3F1T2U1TElhYjQ4QW1vbzY5?=
 =?utf-8?B?aXhDZFhTeWM4UXJOK3hIRjdaRi9nckx5RjZPb2NyWHdlWDVYUEZwQU1jWlVK?=
 =?utf-8?B?Ty9yTWovT0RwcDNqTnZhMytBc1pHS1NqY2JDSklyWk0wZTR6TnFzcGtaNWd3?=
 =?utf-8?B?NUhEd2xDRm52ZDVNOU5PelcwdVR0UGFvVXN6c2kybGpOVlhsdGhHSEVOYWZs?=
 =?utf-8?B?cWJ6MmZMTllnd3BKUlpYT2Z5alVkblk3ZzZheXRtV01SRGJ1ZnNLZStyTytp?=
 =?utf-8?B?bGRiSzlrWmdIR0lHckVRWk1rVzFJR3J6MlpxS0lPc0h1UUhDWTIvandwZFRx?=
 =?utf-8?B?RjJBTFQzZnluRVRSc0JjalF3RDIrNVIycnZHTlNWM2hFdkR3WUZEVFRtM0V3?=
 =?utf-8?B?YkFaVlJZQ2VBUXR5cUpQOVl3Mm9Jd0M5ZWNnSDJ0elJWbHlhUkM3WGx5MGov?=
 =?utf-8?B?YUh2RVhSMGcyTTFEL0ZkQ0dXUnhNZTNtRHkzYkJVMlV0SnZsL3c4TWpnZ0h0?=
 =?utf-8?B?YTFwdysxczYxUGNPZkJlVjhFL2puTEhZNm9qMnZvMVZiblV5eEIyY0s0VTB5?=
 =?utf-8?B?b0tiaG1NUGZ1ZUpXd3luaWd0S2IzYUxHV3dOcXFKUjM1NUFsdVN4NDZOOWJp?=
 =?utf-8?B?QWpJc201UHZyZDNaamRUVUp6WWlvSzlHT3dZY0dBZDM5Zkh3a05IdFhPb2ZR?=
 =?utf-8?B?blpyczQ5d25BRjZGUEJWUHdZYXRBVE1qNWZOL3h0TW5tYkZnaGtsWjhhY3BH?=
 =?utf-8?B?alJ6RVBpTkpKVTNkbnFLR0NpNVYxVTIwRy9GZTRvNWJFVFdnbkZHd3NEMUwv?=
 =?utf-8?B?azVsQVJjaE9KUjRxMnR5T0FhaC9WamowWW1hTjc5cXk4VXNiOTB5UjRoVktS?=
 =?utf-8?B?ZDNLY2dPYnVYYXY5ZWk4V0FRcGU0Snl5NWFvcDhURTlZL3ZRVVhxQ1Q5dnp5?=
 =?utf-8?B?bHBEdmxnREVqYUJOcERVamY5NGYyRm1WM0o4NmhRd3BmTVJ1akhPVXczR21x?=
 =?utf-8?B?TWE4cVhmODZOYnZKVkwyRThzM0dJblpxZHZpUlI0S0hWbnl1K05SSkYyb2lP?=
 =?utf-8?Q?JmaGqr90PE5UiHTqxIMzfNJ4uku7saBM6UGGJ0/?=
X-MS-Exchange-CrossTenant-Network-Message-Id: dfc07811-8f3a-454c-6894-08d9923627dd
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2021 12:52:34.6497
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: wMsJfOo6Cpf8386vTxQg89rTm/zbU5bX3GounF4JBWXS6/S0YwaG7UTUyU+8jEB9dcBiA3A4YXV+YbqdESEcgw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4058
X-OriginatorOrg: citrix.com

On Mon, Oct 18, 2021 at 02:17:39PM +0200, Jan Beulich wrote:
> On 18.10.2021 13:19, Roger Pau Monné wrote:
> > On Thu, May 20, 2021 at 03:34:28PM +0200, Jan Beulich wrote:
> >> The SDM specifically allows for earlier writes to fully overlapping
> >> ranges to be dropped. If a guest did so, hvmemul_phys_mmio_access()
> >> would crash it if varying data was written to the same address. Detect
> >> overlaps early, as doing so in hvmemul_{linear,phys}_mmio_access() would
> >> be quite a bit more difficult. To maintain proper faulting behavior,
> >> instead of dropping earlier write instances of fully overlapping slots
> >> altogether, write the data of the final of these slots multiple times.
> > 
> > Is it possible for a later (non duplicated slot) to cause a fault
> > ending the instruction without reaching that final slot that contains
> > the written data?
> 
> Yes, but that's not a problem: Only faults are required to be ordered,
> and when a fault occurs guarantees are made only towards lower indices
> (read: all lower index writes would have completed, while nothing can
> be said about higher indices). All non-faulting writes can go out in
> any order (unless there are [partial] overlaps, but afaict that case
> still gets dealt with within spec by the proposed new logic).

Oh, OK, so it's fine for a later write to be 'completed' even if one
of the previous ones faulted. In that case:

Acked-by: Roger Pau Monné <roger.pau@citrix.com>

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Mon Oct 18 12:58:41 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Oct 2021 12:58:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.212200.369982 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcSDl-0004ja-S8; Mon, 18 Oct 2021 12:58:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 212200.369982; Mon, 18 Oct 2021 12:58:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcSDl-0004jT-Ok; Mon, 18 Oct 2021 12:58:29 +0000
Received: by outflank-mailman (input) for mailman id 212200;
 Mon, 18 Oct 2021 12:58:29 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=628V=PG=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mcSDl-0004jN-9H
 for xen-devel@lists.xenproject.org; Mon, 18 Oct 2021 12:58:29 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id f6327172-53d7-4984-b8ab-5fc41de036a6;
 Mon, 18 Oct 2021 12:58:27 +0000 (UTC)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2171.outbound.protection.outlook.com [104.47.17.171])
 (Using TLS) by relay.mimecast.com with ESMTP id
 de-mta-30-YkFS12LjPJWqzBh5J7b90Q-1; Mon, 18 Oct 2021 14:58:25 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB3294.eurprd04.prod.outlook.com (2603:10a6:802:3::19) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16; Mon, 18 Oct
 2021 12:58:24 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.018; Mon, 18 Oct 2021
 12:58:24 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6P191CA0097.EURP191.PROD.OUTLOOK.COM (2603:10a6:209:8a::38) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.16 via Frontend Transport; Mon, 18 Oct 2021 12:58:23 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f6327172-53d7-4984-b8ab-5fc41de036a6
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634561906;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=vBh4PhXUiSGM5y0kJRwhAu9vswK+nC6+vxL0JOCcpYA=;
	b=aga06lzShJn4g17FEV7StHJ7fqz89I7ELEItaVpS4Ul6BHgNs1mnKfg+mOiHjgxoa8o1yk
	EimqYTdoQ3h6cbW6LEP2/d69Cwh+s3PLPykC0IB9MYsq/WJc0ZPnu/fy/myDM3dCS/ouva
	065Ta/x/zB+OyH7m8fTq4bEpphS9T6s=
X-MC-Unique: YkFS12LjPJWqzBh5J7b90Q-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=lMr9Z7EWTMZ7OkSVzn/bqffpF5fQD+MKEb10kwH0IffmJim20uB1VLTSf7r4rGtSyoX7+rFZ6LLMj+GBawsOjsfPW5+IblRg/8OMef8r2kpRHnizx8WVhsmP1Nu3yK8V0yAgipJRcPIrAtQ8kk61rEfOC94ODeSLhCUNsUTcKEqgrzITuBPh1UXKgh8aBP1Q1IdHSchdLUYxki0XrrPtBR5Gkyt3BrArGaeBOt/XMKm9KHjaP+/R9BXQn/ea2FOa3ipVd0mq6TkND+4hMC1wFcuWBvne0zu80FdhXs2ThOydKH8xlJoJ+N5IA4wy5AZtjjiM9s8xcIb9d4dltYBP+A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=vBh4PhXUiSGM5y0kJRwhAu9vswK+nC6+vxL0JOCcpYA=;
 b=AqYHvvc5cnmhZ2wEPJLjsfW4J1Zc0YAONkzXt6UXG9G1RsWp04uPdKJBln1gJJGVsZ812R2O412SeCMkGigyE+uJ4Bwra300yVM0mPGcKcpY3hTYHTHaMVdrYcNWdyr5nGCWIsEx6JKxQOrbwLgEqrkfLzZnNiBPkYRFx0TA1c3QyzfLbl7nne5YA0AQH5nY6i5j0uVzxOrTZOLjPegHfOoBcXQ5j1DZt1ywrgeAQVzv8fV1AZeuiD2TBq+wKAOkYOAhgJ3H/WeCSiEGRMRjOUf7sueqYc1JATxgAUDxAolvgx3yz2ZjadXq1hynpJq6QkYIujTR/BpvKAKiMvj2/Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [PATCH 06/12] xen: generate hypercall interface related code
To: Juergen Gross <jgross@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>, xen-devel@lists.xenproject.org
References: <20211015125152.25198-1-jgross@suse.com>
 <20211015125152.25198-7-jgross@suse.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <e5f55c9e-5615-7d10-c86c-db1a3c724f43@suse.com>
Date: Mon, 18 Oct 2021 14:58:22 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <20211015125152.25198-7-jgross@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P191CA0097.EURP191.PROD.OUTLOOK.COM
 (2603:10a6:209:8a::38) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 3c8854e0-bc33-4bba-cc16-08d99236f860
X-MS-TrafficTypeDiagnostic: VI1PR04MB3294:
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB3294AB72772A1F978A9F217BB3BC9@VI1PR04MB3294.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:983;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	cJum7pBPgOYUZMWI5p9yln0fZlpvGdz2RT5DspDD+h72brvcqUq1n2L75hMdPZV/Z673ypF2vcSB/Iq36EHsmlBCdulOi9ySQCcnS9AxfK18iAp82DcOpO6Fq7ud9QMKk//Yrp0UHqp3FpZ0RSBaOt5KauBcps+os65rpgT0sySrzb7vAze8NUZDn6n2CxN8mRO2H9QC/PanoguiMXe0xT+9AzXnnpfaWKyJlnySbnNu3YQ9NmXYU296NKUhBM6GgrP8Z+E/+uAPiz9XW0FJD8Vb3PixbmvD96XXbuW7eehoC4AyoyEqdPecekdbOxmnZMdcw/rQJkvvZ40E17cfIT4wKXuWZmicJpr7zIx9eVQpfqOlyh8Ty/iMND7VitLPEMQcmuLDIDghpKxL3HR5x+6J/bDUTY30oWwTmrjbMvedM923vO1lamTPbjM4KuFwRMCft+LRdC+3Pl52vLUWGuccNfpCRIHOl5ruLE71MmRnj5WORIscaHKgMcIbpTvXK19eE8v3jCM2MuSdKV9tHmpYeVzYxxJu9sZWKZyVs5tDekrtR+WVFQbulbcFNctYJoRpn9qxeG1Vk2k7ClHVzEeL5kUu5NGYQqy7su5Wwh5IxZFDOJBWr3cEWadbXkNs59x9pCp/mMr7iD4radgrQm20hvN/e0PC4wcgg4aoJylYMC0RImIuasEOUuoK7yS2iMRlNWcRbQG+Qs08wtepIEsIdtccrbPy4Z+jPklVy2oUv20zDL8R8KeBAWOlZjDX
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(2616005)(8676002)(4326008)(5660300002)(6862004)(8936002)(6486002)(66476007)(186003)(36756003)(956004)(31686004)(66556008)(26005)(83380400001)(86362001)(66946007)(508600001)(6636002)(316002)(54906003)(37006003)(2906002)(31696002)(16576012)(53546011)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?SGswekpQMWE4M3RqemFKTUNKT1ovZG9NWk1leFF0di92ZkVFVmJ1dVc2ZW5i?=
 =?utf-8?B?NEF6czRTa2ZMSTNoWjZvMkVUdHNodlg0aGIxNUo3L0RoQjN1c3U2cTJCRjNq?=
 =?utf-8?B?WnF2TVhEWkNZTmdXemxuZlI5U3E2NzFUVlhndGVDS0dKYjlYbEY3U0s4ZHFt?=
 =?utf-8?B?RGZhNTlPa3J0bFl0aTdzZ1RBYjdGNkFBU044SkZvQW1aM1A2Zjk5NkFNQWcy?=
 =?utf-8?B?QXZFZE9iVnJYS2VyVWFwVHBXK0FRWmtkaFI4YlJLLzhjdkE2SHRxR0xFQkJr?=
 =?utf-8?B?V1YycUJvWlphY2J3WUlWWWhPTitxTlNvV2paZXZ0NmIvOUtVNGtycHJMb1Jo?=
 =?utf-8?B?QU5sWEd2VUJZc1lrV2crdkppM0l1L29vMzl6cE43TVpOS2NmZU1ONVloUzMx?=
 =?utf-8?B?djc5aEduQjREMlpYMm15dlh2NThtdk55a1lOcWptQjg1Mng1SDFMMURlV21y?=
 =?utf-8?B?TWdTaEhRNU5hNEE3ZGtVaWFjMVdNRFFLRzQ2MXA5Y0x6d2RTOXJ2T21QVDJS?=
 =?utf-8?B?Y0dhUTNsQk5Ubk1oQTZBUmFiZi90UTk1VXptU1htRER1T0V5ZHhvU1owY1g0?=
 =?utf-8?B?UWFSczR1TFhVcXRMZHAvcDYwU0VvcTZUNmpBajRTdUZTR2dUV3pZRXYvUUQz?=
 =?utf-8?B?ZDJGRGFyNHN4aG9FdXlTV2EraVR4d2RmeHE2ZzFKTmtGc0Ixcys2VTVCdEtm?=
 =?utf-8?B?RUhyc2ZxYXI5UjAyRjZtZSt0WG1XUHJkYWRKemxxYmFJWFZWSnZPN1F1V1hH?=
 =?utf-8?B?TndnN0RuWUZnY0ZrVzVZV05IcHVDZ0g4enNxSmRNNVJVVFBacER2V3Vublli?=
 =?utf-8?B?d05DL3N2MjNVVHBsSUhHblQrcURlZ3I3REdIOUkvdmZ2S0x3MkpBbm1waGdw?=
 =?utf-8?B?NFFiL0E5bGRENGJyaUlmRzh5K2JnblA0S01TY0ZGbUNrQjJudlNkVUtGV1ZH?=
 =?utf-8?B?ak05QU8rRXNZc2RBc0I4M2RYbDRZZG8xUWJpTWc0ZjFLOE5VdFFaRkU2OHdQ?=
 =?utf-8?B?eDFrWUsxZ2VTb29WSW5LVU1VTzFOZ0RkT0NySVQwZ3J5dDBYVEowSE5RRXoy?=
 =?utf-8?B?eTZwTFdDZXM5eUtueGdEM211clZDdVgvM0FtYlc4M1BNQU85L1hXTDdUUWUv?=
 =?utf-8?B?bWVxdi8ydjJkSWNvYjRUQ2JmdFdsMUt0UG1vZHEvM3RId3NwR01Lb2dtL00y?=
 =?utf-8?B?d3B1ZDIwTGZVZ1FsRUxuMkt1V1ZmbVNabGRtZkZIdEpCejByd1pHQ2xhN2x4?=
 =?utf-8?B?Y2hZTHo4UlUrOFI0VXBOWHNXeXNnS3FVTEVDdW80N095QXg4Y0dlNnNOSExF?=
 =?utf-8?B?YjlRajd5RjhsYlRIeGRaTkZHdUVEeWVsam1NYXlHQVlDMWNuNjNkVlZQMzds?=
 =?utf-8?B?NzY0b3E5dEJqOHMxM1MzdWFnTXM1Z1ZYVlZmU3VuQW1sNlFRdmwwKzBDbVp0?=
 =?utf-8?B?czh4T05HVmxMd3RXYk84M1VlOHRudjEyeVVjYzFnUVl1QVRTUERiQ0hCL09z?=
 =?utf-8?B?RHlKTmFqRHpBS3dLZkN6R21jdGNjQjV2aG9xc3Exa1ltVnJ1bXY1Rm04KzUx?=
 =?utf-8?B?dzVHekVFZ05qcWpkbkRBTFBTdVpQMFo1a3hqdHF5aG0rRWJtZzQxeTBESnVk?=
 =?utf-8?B?OVFUaW1OQ2FpaVVGVGkvdS9SVTVVNGhmQmpyMFdTNVRGL1hVZjFtUXl2QXhn?=
 =?utf-8?B?aVhNcURUYy9IVGdPeFR4em9LL2lqVnVZdHdHa3NOQ0MzekFsMnpRSk1TVERV?=
 =?utf-8?Q?EDXgXk7HnhzufUR4DLF6vGhmVXkZzRgkNUbWEeV?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3c8854e0-bc33-4bba-cc16-08d99236f860
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2021 12:58:24.3917
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: dsV5ViJOP3Gbh4pSNM8064Mm1naNNHhHSCpLU72AAjAKJEL5vyDN3afneDFAyVeK8WdQndamMdwf10hl/DKBOQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB3294

On 15.10.2021 14:51, Juergen Gross wrote:
> Instead of repeating similar data multiple times use a single source
> file and a generator script for producing prototypes and call sequences
> of the hypercalls.
> 
> As the script already knows the number of parameters used add generating
> a macro for populating an array with the number of parameters per
> hypercall.

Isn't that array intended to go away?

> --- a/.gitignore
> +++ b/.gitignore
> @@ -332,10 +332,12 @@ xen/include/asm-x86/asm-macros.h
>  xen/include/compat/*
>  xen/include/config/
>  xen/include/generated/
> +xen/include//hypercall-defs.i

Nit: Stray double slash (unless this has a meaning I'm unaware of).

Yet then I wonder: Shouldn't *.i be among the patterns at the top of
the file, like *.o is?

> @@ -466,6 +468,14 @@ include/asm-$(TARGET_ARCH)/asm-offsets.h: asm-offsets.s
>  	  echo ""; \
>  	  echo "#endif") <$< >$@
>  
> +quiet_cmd_genhyp = GEN     $@
> +define cmd_genhyp
> +    awk -f scripts/gen_hypercall.awk <$< >$@
> +endef
> +
> +include/xen/hypercall-defs.h: include/hypercall-defs.i scripts/gen_hypercall.awk FORCE
> +	$(call if_changed,genhyp)

As per patch 5 there are quite a few sources including xen/hypercall.h
and hence (in one of the next patches) the header generated here. If
this one gets re-generated for a benign reason (i.e. without changing
the header), all dependents will get rebuilt for no reason. Use
$(move-if-changed ...)?

> +prefix: do
> +set_timer_op(s_time_t timeout)
> +console_io(unsigned int cmd, unsigned int count, char *buffer)
> +vm_assist(unsigned int cmd, unsigned int type)
> +event_channel_op(int cmd, void *arg)
> +mmuext_op(mmuext_op_t *uops, unsigned int count, unsigned int *pdone, unsigned int foreigndom)
> +multicall(multicall_entry_t *call_list, unsigned int nr_calls)
> +#ifdef CONFIG_PV
> +mmu_update(mmu_update_t *ureqs, unsigned int count, unsigned int *pdone, unsigned int foreigndom)
> +stack_switch(unsigned long ss, unsigned long esp)
> +fpu_taskswitch(int set)
> +set_debugreg(int reg, unsigned long value)
> +get_debugreg(int reg)
> +set_segment_base(unsigned int which, unsigned long base)
> +mca(xen_mc_t *u_xen_mc)
> +set_trap_table(const_trap_info_t *traps)
> +set_gdt(xen_ulong_t *frame_list, unsigned int entries)
> +set_callbacks(unsigned long event_address, unsigned long failsafe_address, unsigned long syscall_address)
> +update_descriptor(uint64_t gaddr, seg_desc_t desc)
> +update_va_mapping(unsigned long va, uint64_t val64, unsigned long flags)
> +update_va_mapping_otherdomain(unsigned long va, uint64_t val64, unsigned long flags, domid_t domid)
> +#endif
> +#ifdef CONFIG_IOREQ_SERVER
> +dm_op(domid_t domid, unsigned int nr_bufs, xen_dm_op_buf_t *bufs)
> +#endif
> +#ifndef CONFIG_PV_SHIM_EXCLUSIVE
> +sysctl(xen_sysctl_t *u_sysctl)
> +domctl(xen_domctl_t *u_domctl)
> +paging_domctl_cont(xen_domctl_t *u_domctl)
> +#endif
> +#ifdef CONFIG_HVM
> +hvm_op(unsigned long op, void *arg)
> +#endif
> +#ifdef CONFIG_HYPFS
> +hypfs_op(unsigned int cmd, const char *arg1, unsigned long arg2, void *arg3, unsigned long arg4)
> +#endif
> +#ifdef CONFIG_X86
> +xenpmu_op(unsigned int op, xen_pmu_params_t *arg)
> +#endif
> +
> +#ifdef CONFIG_PV
> +caller: pv64
> +#ifdef CONFIG_PV32
> +caller: pv32
> +#endif
> +#endif
> +#ifdef CONFIG_HVM
> +caller: hvm64
> +#ifdef CONFIG_COMPAT
> +caller: hvm32
> +#endif

HVM selects COMPAT, so I don't see a point in this inner conditional.

> +#endif
> +#ifdef CONFIG_ARM
> +caller: arm
> +#endif
> +
> +table:                             pv32    pv64    hvm32   hvm64   arm
> +set_trap_table                     compat  do      -       -       -
> +mmu_update                         do      do      -       -       -
> +set_gdt                            compat  do      -       -       -
> +stack_switch                       do      do      -       -       -
> +set_callbacks                      compat  do      -       -       -
> +fpu_taskswitch                     do      do      -       -       -
> +sched_op_compat                    do      do      -       -       dep
> +#ifndef CONFIG_PV_SHIM_EXCLUSIVE
> +platform_op                        compat  do      compat  do      do
> +#endif
> +set_debugreg                       do      do      -       -       -
> +get_debugreg                       do      do      -       -       -
> +update_descriptor                  compat  do      -       -       -
> +memory_op                          compat  do      hvm     hvm     do
> +multicall                          compat  do      compat  do      do
> +update_va_mapping                  compat  do      -       -       -
> +set_timer_op                       compat  do      compat  do      -
> +event_channel_op_compat            do      do      -       -       dep
> +xen_version                        compat  do      compat  do      do
> +console_io                         do      do      do      do      do
> +physdev_op_compat                  compat  do      -       -       dep
> +#if defined(CONFIG_GRANT_TABLE) || defined(CONFIG_PV_SHIM)
> +grant_table_op                     compat  do      hvm     hvm     do
> +#endif
> +vm_assist                          do      do      do      do      do
> +update_va_mapping_otherdomain      compat  do      -       -       -
> +iret                               compat  do      -       -       -
> +vcpu_op                            compat  do      compat  do      do
> +set_segment_base                   do      do      -       -       -
> +#ifdef CONFIG_PV
> +mmuext_op                          compat  do      compat  do      -
> +#endif
> +xsm_op                             compat  do      compat  do      do
> +nmi_op                             compat  do      -       -       -
> +sched_op                           compat  do      compat  do      do
> +callback_op                        compat  do      -       -       -
> +#ifdef CONFIG_XENOPROF
> +xenoprof_op                        compat  do      -       -       -
> +#endif
> +event_channel_op                   do      do      do      do      do
> +physdev_op                         compat  do      hvm     hvm     do
> +#ifdef CONFIG_HVM
> +hvm_op                             do      do      do      do      do
> +#endif
> +#ifndef CONFIG_PV_SHIM_EXCLUSIVE
> +sysctl                             do      do      do      do      do
> +domctl                             do      do      do      do      do
> +#endif
> +#ifdef CONFIG_KEXEC
> +kexec_op                           compat  do      -       -       -
> +#endif
> +tmem_op                            -       -       -       -       -
> +#ifdef CONFIG_ARGO
> +argo_op                            compat  do      compat  do      do
> +#endif
> +xenpmu_op                          do      do      do      do      -
> +#ifdef CONFIG_IOREQ_SERVER
> +dm_op                              compat  do      compat  do      do
> +#endif
> +#ifdef CONFIG_HYPFS
> +hypfs_op                           do      do      do      do      do
> +#endif
> +mca                                do      do      -       -       -
> +#ifndef CONFIG_PV_SHIM_EXCLUSIVE
> +paging_domctl_cont                 do      do      do      do      -
> +#endif

I assume the intention here is to sort by hypercall number. This results
in 3 PV_SHIM_EXCLUSIVE conditionals when one might do. Just a remark for
consideration, not strictly a request to change anything.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Oct 18 13:01:14 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Oct 2021 13:01:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.212209.369993 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcSGP-0006BK-DI; Mon, 18 Oct 2021 13:01:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 212209.369993; Mon, 18 Oct 2021 13:01:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcSGP-0006BD-9A; Mon, 18 Oct 2021 13:01:13 +0000
Received: by outflank-mailman (input) for mailman id 212209;
 Mon, 18 Oct 2021 13:01:12 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=628V=PG=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mcSGO-0006B7-Ip
 for xen-devel@lists.xenproject.org; Mon, 18 Oct 2021 13:01:12 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 7a0439f3-0e1d-4092-9c21-8954fdccec50;
 Mon, 18 Oct 2021 13:01:11 +0000 (UTC)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2175.outbound.protection.outlook.com [104.47.17.175])
 (Using TLS) by relay.mimecast.com with ESMTP id
 de-mta-18-5IzyxzpCPOCQE1Violo-hQ-1; Mon, 18 Oct 2021 15:01:09 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VE1PR04MB6480.eurprd04.prod.outlook.com (2603:10a6:803:11d::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16; Mon, 18 Oct
 2021 13:01:08 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.018; Mon, 18 Oct 2021
 13:01:08 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6P195CA0049.EURP195.PROD.OUTLOOK.COM (2603:10a6:209:87::26) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.16 via Frontend Transport; Mon, 18 Oct 2021 13:01:07 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7a0439f3-0e1d-4092-9c21-8954fdccec50
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634562070;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=Tq06J2k3+KFuTHISds6GwpWQGm1xmJsVhQO8laYnjas=;
	b=hk06HbVAASA42HT/6aiGzs8YCiEKWMy4mil99x09Gw1AiYEWC3wSHMHLGf6DNqcPN4kpDX
	Gk09+kYxXOj/L5slz932OvreNeTcJX4x+7XnPKTHrJDxIFeu1xM9OnyjV2wQxLPDwlDrap
	72aZ/Y3iYQtaIb0jsqmsoHjpsZQKsCQ=
X-MC-Unique: 5IzyxzpCPOCQE1Violo-hQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=QsUvfZ8qBo3WfSZqAdMxebiADuPnkHCToWgluRckOPhVMoSP/8fMqm88mjJjJWJqOjH4yL8Py2gwSvY6Ea0nOJE8sgZzE1twO2hOoP/qHcnbixhq+/d36awCKuSLmF4Q1f+YxTvqe0G9FsVNOGGzKJHtDg3SM5pvEdZ7Zm61znChVPv8Z6I2sTtZfT8+c3HXZNHlgTb3BIjEKLVCS2XzffzgjbFvs6JRlLcAi/6sEd5d7HnECqLuVDWgF/m9kqR4bWI+9h9tD5wqhwwJdr6t7WiJnqG5fuTPlqeo7iOv8mSi5GyYLUDnTX4AGeLaGamBmZNaUrOoPyk6l5JRPf9L3Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Tq06J2k3+KFuTHISds6GwpWQGm1xmJsVhQO8laYnjas=;
 b=GubqrYWaK0oxw6QIxkiToEE9cvcmKrZiFlBRVQ+ya8hmQfoMRH9v8VOQkJCuTlDVAmYHVeV6RDJ8CZaQ1SQbdL4dDkmZ/vojG9sIOzFYYBN0ArJ6Fyk9NeADwaCKNAsVydFzWLbht8TxV38tqT9yYaISaVUEf+F7esF8vnidl6843IqpUycVLEHsmBHQUMwYHohW91SIkv/wx3T26Tu/MuaGYW+oaZiSqocqXj9Kez8s0RkZbu4hRjrfA6RDuLi/QLhpyzYzC50yntqxcyw3xCgUEzm33BGZ2ASUyIqLvbiLqPEB4e5cLFNWoZggqQEAenUVpKtVH2JRSVcR1edT7Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [PATCH 07/12] xen: use generated prototypes for hypercall
 handlers
To: Juergen Gross <jgross@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>, Wei Liu
 <wl@xen.org>, George Dunlap <george.dunlap@citrix.com>,
 Ian Jackson <iwj@xenproject.org>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, xen-devel@lists.xenproject.org
References: <20211015125152.25198-1-jgross@suse.com>
 <20211015125152.25198-8-jgross@suse.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <fc30a8a8-9c05-6886-c2cb-fafb05b16573@suse.com>
Date: Mon, 18 Oct 2021 15:01:06 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <20211015125152.25198-8-jgross@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P195CA0049.EURP195.PROD.OUTLOOK.COM
 (2603:10a6:209:87::26) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: a39a6fa3-9e5d-4501-70e6-08d992375a14
X-MS-TrafficTypeDiagnostic: VE1PR04MB6480:
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS:
	<VE1PR04MB6480C348AD8D12C515138FC8B3BC9@VE1PR04MB6480.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:5516;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	ru7+mYUh1H0UgXvcXA6O3spHpSvc5DPOceCm8uHcFDn1cwGpQGbitBGj2Mu3GC/+ztZnB0/LrM5sbRkOHYZcW97ig/BTEdYCoqtvYg0cTnPYtjzvjbq1UDNqB173MEWt8hqH1wBSNwTRiLoWUyP41qHXDRJaOOYeOJFCRYxZNbQtWvw0Y6aj1M8HpE/mhgM0PQjyeed/SV/SbA0K2aZafb96tBqCmfqCoMvHS8Fv979NVvOR8ByVmwBfpJmEovY2kNizaDinXQuaGCcA7hOc0OM7vnJrISZxxI9oKE8YIb/zUNZrK4G/GPdKb4/8Y3pNgNgwercxtBtbh9o+4dzNLTCQmCX5F7hsA928Ct8TAq8DlsaEg0Vz8ujVoyreSIXZQxRNOLVM/beWkbBUU2GpBZ9BCRfctcSuJGrWiWZfsz8Gwg8U3sz6bKZg2HRrHuNdF1WLgkSEuemYcZUJvZQFNLvAa4V9sjrlQO7yIg6BQ7FXk86wrr6tm5aMxtWPI/Mq0asPLHUdPqOskuu4oA7w/Cip1FDHdlB4hPHUdj3Llc7vfDMHrlmX+TUcjCmaN8G6LS1zD+Z3j6Yg/TTu9RCdR17riopneY3up38eJt++EqaBl7Lswlz+dp1I1NhVkSdBzoVkM2dDQxvZFIghFa05oVHgEB6QtTXK/urP0oGq1AJThh+fKn0fshoAKBrgeClpuPhriD85Nhe+CxWzmN0WIwszE6s4bQ9FtZNvjoLxoUp+RL19RJHorAExbJ0RWmvf
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(956004)(316002)(16576012)(37006003)(54906003)(186003)(8936002)(2616005)(6636002)(4744005)(36756003)(31696002)(31686004)(26005)(86362001)(2906002)(66946007)(4326008)(53546011)(5660300002)(8676002)(66556008)(66476007)(38100700002)(6486002)(508600001)(6862004)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?dEI5KzJtTzFzQmpPb3JrT3hEQVBVRHYvbUNhbTJ3NFQ3dytCaFdiZzRUUlB0?=
 =?utf-8?B?RjI0c0tQbzFvS0tZTlJ4TnVIcVlNQXpjd1FJVjF2Y2xSWjh1NElWdkczTVZ6?=
 =?utf-8?B?dGVOc05ndTI3VFZ1T3o5ZkRjR2JmZU9HN3dhRjBlQ05MMUlkeVB5NjVxNHZo?=
 =?utf-8?B?elIrWlgzeWE1Ykdra0lxZk5aOE9iM0VmT20zeTI5YkZCSEgvTmUzYkxiQldL?=
 =?utf-8?B?U0RnS2Q3RmVuYWNQUG9XaGRoVDJjZEoyaVVqeTVrOW9CNU5oY3FoVVp1cCtp?=
 =?utf-8?B?YUF4Qk5TRGwvUlRwMGlmOFA3YzcvRWxOK01YNE5rWHNWYkwvK214cllzTHZC?=
 =?utf-8?B?MjJJRUo2bVpKMzJrSUswZUNIL0M0cGovUHR2YlBqa2piRUt6R0dnTDMyOFdj?=
 =?utf-8?B?VWRWcllQQnIxY2xWMHFFdzJKTWViNkt6UitJRjkyV2hGMjBDb1V0VGd5UTZr?=
 =?utf-8?B?ZlE1MFJTVFBza09qL1dxTEhqV0JWcGVOWFduaFl4Tm5Ka2RpRXNrcENpQWRP?=
 =?utf-8?B?aUVDczVLVWd0T2d2VG5JSG10eHAwdVBzTTZBRERsTGdERXk5aTRodUJWV1Fv?=
 =?utf-8?B?RkNra1Qxc0NQVFI0TXErMW0zV2JkNG5XVXBMWGhBRDJ0YzJOZkNPOGpWRzBk?=
 =?utf-8?B?Y01NNThGZ1lMdy92amRCek9waEN2OVlBMWxDREMramkydVo2OWpsRmJUNThG?=
 =?utf-8?B?NXdnQlRHbFZEMlhLSnUzTHlvYkljYnM4aUVqc1R2UXlUd3owQkJNUlBGWDND?=
 =?utf-8?B?OUpWcmRjOW1KUURNQW5iUVNGM0Y4MHhsb2xKTVhJbThPcEFVV0tIQ3FheXM0?=
 =?utf-8?B?cTRibENpQldoV0d3Y1c2bmJQYmVPU2JtdFFaSUptM3NwNVpvK0NKdXVhdmJa?=
 =?utf-8?B?UHpyOUlMRklpZXVDZDdCbElkYnpQTTdCUkRvc3R5dElvQy8rR21ML3FTUzdB?=
 =?utf-8?B?dWQ1YVVWRjdYV0oxN0ZjMWtrdFBsSCtacEVRemMzUEVaeG1SM3pNaUtGaEdo?=
 =?utf-8?B?ZUc0d2p5V1RiazVydEN1M2hhZU1Mc0l5anRzVnRWMGhKR2kzQnlSVkJGRVRD?=
 =?utf-8?B?aldtb3lkVmhjOVlDVGd5UUViNmdoRmVWZFdUN1ZvbDd5blZobG5GSzFWeEJK?=
 =?utf-8?B?SC9CWDQzSGNJZ1p1ZW4weWRjOER2WlRkYmNzNm5mRUpxVERVM2FnWDJ4QitQ?=
 =?utf-8?B?VHFoQkQ1aURQNWVpZG4wcUZ3VGNOOXZJQkdZbnROdnUxelBLZEVIcjdWeDlv?=
 =?utf-8?B?UVdLOSs3emFiOHI4Y0hDcm16VEphYWZNclN6bGVJY0s1WWVkQnI5bVVodzQ3?=
 =?utf-8?B?Z0srbkpyaGFiTjVBdUFNaWFPTGs2OGJoVWtlOVk0eWdtNkc1aHBuTXZMT2Nn?=
 =?utf-8?B?L3JOcC8rZlh6T1ZlOFp4cERGRk9MemszSWt2a0FoVFdMY0VwR0xkREZ2bmk3?=
 =?utf-8?B?QzEwUkEvbm1COVg1cHpBSDNoZHRsbjBLTDZxd2t5TFFrc2QrSmF1UHhGeUdJ?=
 =?utf-8?B?ZnNIK3hVd0NyUkgxckpZTjNGdStxUE42VWp1SGpWR0VXc094VXdKM1FIc3FE?=
 =?utf-8?B?NlI3cmVMbWE1bG1hVHBVVG5rUXUzZjg0ZlozSUcvVjFaOEFwc0NoRUNtVWov?=
 =?utf-8?B?VS9OaElPZFpuR2xnWVN2Y2ZaZXEwVjhhQlNCK3lNeGJFWFVuYkFia2FnYzJn?=
 =?utf-8?B?MmdUek9YcWZQR1AyblphVE5YV0VuMnFlL1kwdEswVGFxTXJQQnpFaDVzTFlY?=
 =?utf-8?Q?gcmWtWUa3s5SG90mSgfXuiKHSmeiOsLwbAs6+tO?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a39a6fa3-9e5d-4501-70e6-08d992375a14
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2021 13:01:08.3560
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Fv2O5TzcJdAaLnRwnaNyoWLj6HAI34XFVsfwXDvf8woJ265yqw2akQWP49IbmWd57j3kPgWJZGGStoJkvryVpA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6480

On 15.10.2021 14:51, Juergen Gross wrote:
> Remove the hypercall handler's prototypes in the related header files
> and use the generated ones instead.
> 
> Some handlers having been static before need to be made globally
> visible.
> 
> Signed-off-by: Juergen Gross <jgross@suse.com>

Acked-by: Jan Beulich <jbeulich@suse.com>



From xen-devel-bounces@lists.xenproject.org Mon Oct 18 13:11:24 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Oct 2021 13:11:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.212218.370004 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcSQC-0007ih-Av; Mon, 18 Oct 2021 13:11:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 212218.370004; Mon, 18 Oct 2021 13:11:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcSQC-0007ia-7j; Mon, 18 Oct 2021 13:11:20 +0000
Received: by outflank-mailman (input) for mailman id 212218;
 Mon, 18 Oct 2021 13:11:18 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=3tpC=PG=citrix.com=roger.pau@srs-us1.protection.inumbo.net>)
 id 1mcSQA-0007iU-SA
 for xen-devel@lists.xenproject.org; Mon, 18 Oct 2021 13:11:18 +0000
Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id e0d62e9c-3014-11ec-82d7-12813bfff9fa;
 Mon, 18 Oct 2021 13:11:17 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e0d62e9c-3014-11ec-82d7-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1634562677;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=N1t2mbnDUgndlLgcNzRMCB+Uuhk9F1NYyzB50GGqabc=;
  b=TIVCexHbGkHsxxrsBgrjXBKtXZkIv1Ow9ru4tVHq26R+I02MIYAIPeaQ
   4ZfehONu+OaK2Mf6dCh2Unm5pFcO1ftKgRHaG1Htr1kqM0psI/6crp398
   IcpiXUszPUYvo8vYqN4G+ZmkYknQov5cYlcvnbXfD8yYBnnj83YjONyKv
   s=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: CnbwzMbpWD1QZ1WySLERW8/JJRKgpGb8zct8p3oVAdBb3bzdZk0bhVTD7+Nib50hB/oHbPMsCx
 ER8T2L+arY45dQIcfgeT61hYAX0SmDHCT26YRHz0a9mEhMoU4npJki6hIlEAQic19F4vjasZRg
 uvzohGCihYEOmTZ4A44rXy0PL+Ye8Ae6xbJgt1eOAD8CEMY/9BJdPrARzfUfqQ1WFaGLKakszG
 3KwM+lYj6rA+X9DcD+/qJqcvCzVD/N3Op45fYKY1mogpoZ3M+aN1Ew1RMRZL1KajegXxyNwHth
 xIY7rRVluB1jZ7NRZiRfmmxn
X-SBRS: 5.1
X-MesageID: 57324714
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:wrRXA6A2rcS81hVW//Lkw5YqxClBgxIJ4kV8jS/XYbTApDtz0jRVy
 TEeX2HSMquMamL9fdBzPtyx9UMAuZGDmoNqQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA
 xA2M4GYRCwMo/u1Si6FatANl1ElvU2zbue6WLOs1hxZH1c+EX550EI7wYbVv6Yz6TSHK1LV0
 T/Ni5W31G+Ng1aY5UpNtspvADs21BjDkGtwUm4WPJinj3eH/5UhN7oNJLnZEpfNatI88thW5
 Qr05OrREmvxp3/BAz4++1rxWhVirrX6ZWBihpfKMkQLb9crSiEai84G2PQghUh/lxiNltUp+
 u128qORQgEXLKTDvPQ3akwNe81+FfUuFL7vJHG+tYqYzlHccmuqyPJrZK00FdRGoKAtWzgIr
 KFGbmBWBvyAr7veLLaTUO5ji95lNMD2FIgepmth3XfSCvNOrZXrHvqRv4MHhWtYasZmDav/e
 fMLezlWXDODIANgZGxULs08tbL97pX4W2IB8w/EzUYt2EDMyCRh3b6rN8DaEvSaSMMQkkuGq
 2bu+2XiHgpcJNGZ0SCC8H+nmqnIhyyTcIAYGaC89/VqqEaO3WFVAxoTPWZXutHg1BT4AYgGb
 RVJpGx+9sDe6XBHUPHhchmxpSa2hiVbZPtbFdMo4Q6p2oDttlPx6nc/chZNb9kvtckTTDMs1
 0OUk96BOQGDoIF5WlrGqe/K9WLa1Tw9aDZYP3ddHFRtD8zL+dlr1nryosBf/LlZZzEfMQr7x
 CyWt2AAjrEXgN9jO06TrA2f3WzESnQkSGcICuTrsoCNs1sRiG2NPdXABb3nARBodtfxor6p5
 yBspiRmxLpSZaxhbQTUKAn3IJmn5uyeLBrXikN1Ep8q+lyFoiD4IdwBvWAkeBszY67onAMFh
 meJ6Gu9A7cIZBOXgVJfOdrtW6zGM4CxfTgaahwkRoUXOcUgHON21CpveVSRzwjQfLsEyskC1
 WOgWZ/0Vx4yUP0/pBLvHrt1+eJ7l0gWmDKILbimnkvP7FZrTCPMIVvzGADVNb5RAWLtiFi9z
 uuzwOPRl0wADbGjO3SOmWPRRHhTRUUG6VnNg5U/XsaIIxZ8GXFnDPnUwLg7fJdikbgTneDNl
 kxRkGcHoLYmrXGYewiMdF55b7bjAcR2oX4hZHR+Nle0wXkzJ42o6f5HJZcweLAm8s1lzOJ1E
 KZZK5nRXKwXR2SV4SkZYLn8sJdmKEahizWRMnf3ezM4ZZNhGVDEo4e2Ygv1+SASJSOrrs9i8
 aa43wbWTMNbFQRvBcrbcty1yFa1sSRPke5+RRKQcNJSZF/t4M5hLCmo1q07JMQFKBPiwDqG1
 lnJXUdE9LeV+4JsqYvHn6GJqYutAtBSJEsCEjmJ96uyOAnb4nGnnd1KXtGXcG2PT2jz4qijO
 7lYlqmuLP0dkV9WmINgCLI3n7km7t7iqrIGnARpGHLHMwaiBr96eyTU2MBOsutGx6NDuBvwU
 UWKo4EINbKMMcLjMVgQOAt6MbjTiaBKwmHfvaYvPUH3xC5r577WA0xdMi6FhDFZMLYoYpgux
 v0suZJO5gGy4vbw3g1qUsyAG7ywE0E9
IronPort-HdrOrdr: A9a23:E0VbeKq+V2C2nhaliWo0hPcaV5oveYIsimQD101hICG9Ffbo8P
 xG/c5rsSMc7Qx7ZJhOo7y90cW7Lk80lqQU3WByB9mftWDd0QPDQb2KhrGC/xTQXwH46+5Bxe
 NBXsFFebjN5IFB/KXHCd+DYrQd/OU=
X-IronPort-AV: E=Sophos;i="5.85,382,1624334400"; 
   d="scan'208";a="57324714"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=CBBoV/doUpRFxJRhvjpK4m7xWB0EcQ6CVEWlZSOKLLP11l9q1IJ5gRjVtiPD/yg+GJN5K9WSkBRlWJJmdI6/9hM/hCvKMCLSwfsC8e6SGoYnAWv1ly++1qKZoQM1nBIbqPI3GIxFxSpizaTf/0M56aEibCDIjl+Cc1w7eUiH9BKc2+pcLXhdnEkyCmN7GS+KqV4ePHh1esFAl6I0GfmGFGOQ6sxankJ/5cY7VmuzTo648CXafmV9DZpamzKsSyKSLWjLS+o+Dvpc++//4bacXQxbKB4pNDjAP9B1TgSrNxo5HaKoeNVgj0IMM+5BGo6kqdqSuIz/EjXahDAbMooVUw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=cwTZ7GKdwhK81iZaOunI8wN7Z8h1DV50wyJxzgqVrKE=;
 b=VDKfbByjd+DhsyT3dtGoEwnseGCkyKlXHxEKB6cXSuH6ETgHsFHoL6PQPgcpX5aiJrFZQXLGqT6D46JEicfjhqhU//1xV61FzMTebN4O3kb2qYAJFkyeUzNxckh0VyXl4eVvoXrBaDw4+rA6HPb5smtPfunwQxFxSjyQitvH0Q+UYWtE9KuPuB+YyHT3ExgkNvdUJKVYo3uj3KN+MMkOsiYqIgTXXPqOLnG5FvzDrbPmkzQsOKUpFF65Kt2Z49NSV4jaBZ0XrybEN4Mfgsya/b1n1tXKuyrNd4OiZyt+3obpAR6bqddptAC+cmPrK718127eL3PzLmz5T3DmhGGLeA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=cwTZ7GKdwhK81iZaOunI8wN7Z8h1DV50wyJxzgqVrKE=;
 b=Ql8slKRntNUw9OU/C/XKrA/cgDfGwdCmbmS2EiTTic7AfdJafv139Ag+Ns3X19pAapkaQ5N4/iD+U+Ji9hxWDMI0qvbZJDNdX2SGS0GulY7JZn8pXFspzgn5urPBF/DTu+kojZThSHGF9aiICclWJQ8a2cjkRxQ4iBALHedLvC8=
Date: Mon, 18 Oct 2021 15:10:43 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Andrew Cooper <andrew.cooper3@citrix.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Wei Liu
	<wl@xen.org>
Subject: Re: [PATCH v2] x86/AMD: make HT range dynamic for Fam17 and up
Message-ID: <YW1yU/gogTvvRMMF@MacBook-Air-de-Roger.local>
References: <36df1141-5c3b-6f8a-3a83-1f954b1e27a6@suse.com>
 <YW1BPPVNAVm6EPQp@MacBook-Air-de-Roger.local>
 <3f08e2bb-d80a-3336-d379-a9d76a689586@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <3f08e2bb-d80a-3336-d379-a9d76a689586@suse.com>
X-ClientProxiedBy: LO4P123CA0466.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:1aa::21) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 65ecc96e-60ac-4316-4cdd-08d99238b3b7
X-MS-TrafficTypeDiagnostic: DM6PR03MB5178:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <DM6PR03MB5178AE14FC2C3F7E05EC3F428FBC9@DM6PR03MB5178.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: HwwbYmBiXufRej0wMH1g5bx3Xl7vy38qAiinrgrp3ylyaevVbWlgj6A+0tiVYwtDS4BastR5/U1Ym7kmikoVhbS37c7yYchElZm+cur0ZaT+NpjU1XE4IWVHI6UW3z84jcnymX208ul7lzgVbwoUdl883O74OYOnQtWHsVFfhDAuS7BDRPHpyfqILC9s4bhihRJiGPSOc/QVxyQcgc6expOMrdGFVKpzulw89kOSHmnpvGJbvtM2Vv+AUtr1q+Qhh6hcUbmOQfZ7K+7Q33I3UzygnrVuZAcS/GgiLIejj9nIrtRc2qIkT7traId5fk6nOnM9KEhNd2U1/BICIcsprtG+w2xJMRsVI3L6xl8PcCeIvqkzYixDuRfbh7UuQxCG0wCbizYKvZ6a2M4KiJjL9FTO8Ncj+X2+18BzRKVxmTtIfeJO2530tSO5kAzdIWn/vwhc4otQXHpw7ZhLfqDQPVDNsE6J0q1rYVJ7PfSU3t5ZLtvT94C31jEPCnv9F4OtrYQj5UdjoVwEmrh6f16gIdOSwf6W4TXvmpfMCTh5j4r0BI/YbIoGAxV/6qtVKB5nk0Lxl20E9wgOvdtIXy18u0Lqg3D7UOnNylu5ubXNal9klkuGYxooXrviFnpjB5oIQWun+GlHcWZQG10uAjfd8A==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(66476007)(66556008)(86362001)(6496006)(5660300002)(6916009)(82960400001)(316002)(6486002)(186003)(9686003)(8936002)(6666004)(53546011)(38100700002)(66946007)(8676002)(83380400001)(54906003)(508600001)(4326008)(956004)(85182001)(2906002)(26005);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L2xTS0RabGZjZFUwZVhBZnNlaFcxTjIvSUNMYXhtR0tzckpmSmZZMEpkRTN3?=
 =?utf-8?B?K0FLMTBMaGkweWs2eVhHNjFGWW4ydWt0dVJpd1FJdGtjbFI4T3dZN0d5SVl2?=
 =?utf-8?B?TU9FemJxSkUwVHJCNzcwamN0dHN2N1gwL25icFNSMUdmcHNpSHJYSHd6NEN0?=
 =?utf-8?B?clhxK2czeXNRR1ltd1I5b2tIbVVIUWd1VWcwamRGYVdlS0FLcUM3bXNOelpH?=
 =?utf-8?B?Ri95VkRlYkVsZWswWjExRlZOVDNpYUw4SnhibU9sWHlaSG1RTkd1WXhkWUg3?=
 =?utf-8?B?UmIxbWNUVSs2NUVLVzRJK0ZFVldwQW81blRzZmFCR0lhZ2JkZHVoVnJQVFBS?=
 =?utf-8?B?QXlicmY0L055cm4xNXpod0U2SzYxSWxQeTBIMUFROE5SS0RCRUhXcWNDLzlv?=
 =?utf-8?B?ZnJVbWdPWTkvTE9zZ1RUY3ZGbURFMURUcTVGSHdSZkZBbmphQlNBbjA3OGN6?=
 =?utf-8?B?YmVjTlN4ZVNxSUQ0RkVTMVB2Mjd2ek9NTXVGb0JoS0JpWm9nMEI3dFM2K0d1?=
 =?utf-8?B?VTlTQ3IyVWVJdXVXbFpNUEdDRGl5RWhyQjVacjZFRnRoY3VZZ2NSc3Y3RnlJ?=
 =?utf-8?B?VnZSb2ZKbEtrdzcxT202NFJheTdZcm41NVhDcXpZaU9rMnFuWHgxVlkzRFFW?=
 =?utf-8?B?Zi9PblY4T3dqVHZZbGxkZlc3NXl1S1dTcGhieGpuQ0N6RTNJQ2sxYjdRdDdw?=
 =?utf-8?B?RUNTOEJhT1BKbElxUyt1MnlsK2pqT1hRY3RGNGFEdFVIOWdFWkgzM1BsMmVn?=
 =?utf-8?B?aDc5WnVpK3RscmlZOGtDem10eUtHTzhXUEVUczZVY3YwcDJVKzUveDd5VFNr?=
 =?utf-8?B?NlVvSVJvYmx4Y0t5WkRGblhmK3lkNnhxSkMxTUpCbTdvZnFFWURydUhwUGZM?=
 =?utf-8?B?NjZaQWNUSXNuYnNiVWhTWjRUQ0hnWXovTGtINnAzV0ZiNHNUQ1VYcERaMy9X?=
 =?utf-8?B?OEx3U2l6QVYwVjlaVWRFRE9yWTVuYUU5MEQzRUhmd2lRSTJxcHZuOTBoTDQw?=
 =?utf-8?B?eEZGYkIvVnJkdnZqUEVqeFdFaFBBK211aVU4a3BONmRtczR4VjR1OWdzVGRO?=
 =?utf-8?B?VFJPeWxpYTRsZWZaWUZ4MHV6SGR5b1FML1B4Z0ljOXZHTWtiRTdJZDRCaCtK?=
 =?utf-8?B?M2d2ZHNqRU14QkhTRFFLaFN0NTIyck85eHJCNU0xZG4ySGNXb0FTelY4eUQ1?=
 =?utf-8?B?UWh2WnNRZG9YRFl0di9XWGRDZWhCQzJ0UG9NbThOTUxXNmZGZ2pUWHBPTkZW?=
 =?utf-8?B?Z1RZSUgzM29tQkkxQ3N5UU56R2hxR1J0V3hjbVZJNjNGUlVlQk5DUnRjblBB?=
 =?utf-8?B?SjhOYkllYWpkT0FFK1FaRU1XSHk4UEczanFkYjFxUS9BOWNvUFFFL2kwZnNN?=
 =?utf-8?B?WkdpeHNKL1p3bGxxODNhQVV4b0lyZXZlNnJray9FY09rZFB2dCtrZ09YNW80?=
 =?utf-8?B?T3BiWURmMkZ6TXpxKy9hYzJybG5SRVRaeHp5UWhzNzNxQzRXZmE4d2Vvc0dk?=
 =?utf-8?B?ZWdSL3QyU3dXeUI4NUpWN2dKRVQxZVZ4SjlkVkM4N0l2NytJbHAvdTBFMmtS?=
 =?utf-8?B?dXdROGl6cEV0dmFhRmJwcXZTaDR2QUdTZDBPUEJNZ05mVEhwMWwvcG5TOG9n?=
 =?utf-8?B?VUpPeUJlU0RHMno4V1cwSlFIN2VucllOS0FxaGRMMUdLUEpoSHBwUEN3VVRh?=
 =?utf-8?B?L1BTcjVRVHp3b1ZCcTM5Yzg3Z0ZqSVVvTWtlWUZDZExPNkNQVlAxRmROaklr?=
 =?utf-8?Q?4Sx8iA/k3PSgXurLru+0TpnwHmnjzZykQxQUYi5?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 65ecc96e-60ac-4316-4cdd-08d99238b3b7
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2021 13:10:48.2087
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: nxEJQc6USaoSXEHJa8ku7wgKNZpPe89Is1qhDP7nM0OUX+dbAISpIGENJXCPD4yVyd5Suu9yM38Yo4MkoAi5gA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB5178
X-OriginatorOrg: citrix.com

On Mon, Oct 18, 2021 at 12:18:16PM +0200, Jan Beulich wrote:
> On 18.10.2021 11:41, Roger Pau Monné wrote:
> > On Mon, Jun 28, 2021 at 01:48:53PM +0200, Jan Beulich wrote:
> >> At the time of d838ac2539cf ("x86: don't allow Dom0 access to the HT
> >> address range") documentation correctly stated that the range was
> >> completely fixed. For Fam17 and newer, it lives at the top of physical
> >> address space, though.
> >>
> >> To correctly determine the top of physical address space, we need to
> >> account for their physical address reduction, hence the calculation of
> >> paddr_bits also gets adjusted.
> >>
> >> While for paddr_bits < 40 the HT range is completely hidden, there's no
> >> need to suppress the range insertion in that case: It'll just have no
> >> real meaning.
> >>
> >> Reported-by: Igor Druzhinin <igor.druzhinin@citrix.com>
> >> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> > 
> > Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>
> 
> Thanks, but before applying this I'd prefer to resolve your concern
> voiced below.
> 
> >> --- a/xen/arch/x86/cpu/common.c
> >> +++ b/xen/arch/x86/cpu/common.c
> >> @@ -349,16 +349,23 @@ void __init early_cpu_init(void)
> >>  
> >>  	eax = cpuid_eax(0x80000000);
> >>  	if ((eax >> 16) == 0x8000 && eax >= 0x80000008) {
> >> +		ebx = eax >= 0x8000001f ? cpuid_ebx(0x8000001f) : 0;
> >>  		eax = cpuid_eax(0x80000008);
> >> +
> >>  		paddr_bits = eax & 0xff;
> >>  		if (paddr_bits > PADDR_BITS)
> >>  			paddr_bits = PADDR_BITS;
> >> +
> >>  		vaddr_bits = (eax >> 8) & 0xff;
> >>  		if (vaddr_bits > VADDR_BITS)
> >>  			vaddr_bits = VADDR_BITS;
> >> +
> >>  		hap_paddr_bits = ((eax >> 16) & 0xff) ?: paddr_bits;
> >>  		if (hap_paddr_bits > PADDR_BITS)
> >>  			hap_paddr_bits = PADDR_BITS;
> >> +
> >> +		/* Account for SME's physical address space reduction. */
> >> +		paddr_bits -= (ebx >> 6) & 0x3f;
> > 
> > Does it make sense to check for 0x8000001f[eax] bit 0 in order to
> > assert that there's support for SME, or assuming that the reduction is
> > != 0 in the other cpuid leaf is enough.
> 
> Documentation doesn't really tie them together afaics, so I thought
> I wouldn't either. I was reading into this lack of an explicit
> connection the possibility of address space reduction to also,
> hypothetically at this point, apply to other features.
> 
> > It's possible for firmware vendors to disable advertising the SME
> > support bit and leave the physical address space reduction one in
> > place?
> 
> I don't know if it's possible (I'm unaware of e.g. MSR-level control
> allowing to modify these independently), but if it is I'd consider
> it inconsistent if one but not the other was zapped. I'm unconvinced
> that we really would need to deal with such inconsistencies, the
> more that it's not really clear what the inconsistent setting would
> really mean for the placement of the HT range.

Thanks, I think your proposed solution is fine.

> While writing this, there was one more thing I came to think of:
> Should we perhaps suppress the iomem_deny_access() altogether when
> running virtualized ourselves?

Hm, hard to tell TBH. HT being part of the platform specification
for AMD it would feel wrong for hypervisors to attempt to populate
this range.

Regards, Roger.


From xen-devel-bounces@lists.xenproject.org Mon Oct 18 13:11:58 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Oct 2021 13:11:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.212223.370015 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcSQo-0008GK-KA; Mon, 18 Oct 2021 13:11:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 212223.370015; Mon, 18 Oct 2021 13:11:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcSQo-0008GD-Gn; Mon, 18 Oct 2021 13:11:58 +0000
Received: by outflank-mailman (input) for mailman id 212223;
 Mon, 18 Oct 2021 13:11:56 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=3tpC=PG=citrix.com=roger.pau@srs-us1.protection.inumbo.net>)
 id 1mcSQm-0008G4-Sj
 for xen-devel@lists.xenproject.org; Mon, 18 Oct 2021 13:11:56 +0000
Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id c98a0cc3-610d-4eb2-b0b6-5b0272538b9c;
 Mon, 18 Oct 2021 13:11:55 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c98a0cc3-610d-4eb2-b0b6-5b0272538b9c
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1634562715;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=y1WgyZ/83puoQO+6ZeJJBQkuwmWGJIphjlhjEqDOzNI=;
  b=aj6f443zO9W5FLenhFhVYYi4uIj85FybSlWyEJYMv7ttzHr2yffYrUpx
   +C6GA16Q0+5HgG4R79nbWgeQzNVnGC17tdTJ5g2WAsmkRIWwHafC8vA5V
   ob3H0fuxvxiZomAY1/9a621YQzxGu+6y6RkNNi6XIC5w65L4hID0toViw
   A=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: i5DsyNPnx0XIsLmFqumpQluR2SN369j7v3iLu5UT/r+PGXOm1p+QIuc8zDujpEBpZOHVgJOpdZ
 8v6cLqH3pf8w5ApHVaXLBjZpsm8GDdSEaGtAlq9xXOjJ9eQYJrPw5SPRUGElpRh7k+w5Dv6D8K
 sZJ/pBgZYYARQ/kX9Mdj+AmkqGI35t/5wlP7aDUT/8CF8erxAva8/jSNKj5mjAwP658O5Pqmpd
 GHKAKEV7uCf0lEafk6lR/dvj60+FlmSW295cQ3nlVn6nfWOdhBj9SBNtiVY4Gc5y4ATBG/rGTI
 VUekISWA6Fj0vzfQsP2xugnf
X-SBRS: 5.1
X-MesageID: 54996407
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:NGyNfa/ktD5wGcrLq9vWDrUDB3mTJUtcMsCJ2f8bNWPcYEJGY0x3z
 2YWXDvVMvmJYjf9Kot/bdvg8R4FvpDQnNVkGwFl+CE8E34SpcT7XtnIdU2Y0wF+jyHgoOCLy
 +1EN7Es+ehtFie0Si9AttENlFEkvU2ybuOU5NXsZ2YhGGeIdA970Ug6wrZg0tYy6TSEK1jlV
 e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH
 I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPh2w
 vZCuoyIEz41O47Nx+AsVyVZGXFHaPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us
 6ZCcXZUM07F17neLLGTE4GAguw5K8bmJsUHs2xIxjDFF/c2B5vERs0m4PcFgGZh2JwWQp4yY
 eI/dzVUTQXyQCFfN34cC6NghuKXoUDGJmgwRFW9+vNsvjm7IBZK+LPqNd/UZsCHX959jkuev
 njB/WnyHlcdLtP34SqI9Degi/HCmQv/WZkOD/uo+/hymlqRy2cPThoMWjOToOa7ol6zXcpFL
 E4Z8TZoqrI9nGSpRNTgWxyzoFafowURHdFXFoUHBBqlk/SOpVzDXy5dE2AHOIdOWNIKqSIC0
 VWqkNz5PWZWrLi2SC2Zx7OorDniAH1ARYMdXhMsQQwA6tjlhYg8iBPTU9pueJKIYs3J9SLYm
 G/S8nBv71kHpYtSjf/jpAGY6965jsGRFlZd2+nBYo6yAuqVjqaebIu09UOT0/9EKIuIJrVql
 ClZw5bAhAzi4JfkqcBsfAnvNOzxjxpmGGeF6bKKI3XH3278k5JEVdsIiAyS3G8zbq45lcbBO
 Sc/Qz956p5JJ2eNZqRqeY+3AMlC5fG+Toi5B62FNIYSOMkZmOq7EMdGPx/4M4fFyxBErE3CE
 c3DLZbE4YgyWMyLMwZat89CiOR2l0jSNEvYRIzhzgTP7FZtTCX9dFvxC3PXNrpRxPrd+G39q
 o8DX+PXm0Q3eLCvOUH/rN9MRW3m2FBmXPgaXeQMLbXdSuencUl8Y8LsLUQJINA8wPkJy76Vp
 xlQmCZwkTLCuJEOEi3TAlhLY7LzR5dv63U9OC0nJ1Gz3HY/J42o6c8im1EfJOBPGDVLwaEmQ
 v8bVd+HB/gTGD3L9y5ENcv2rZB4dQTtjgWLZnL3bD86dp9mZgrI5t67IVe/qHhQVnK65Zkkv
 rmt9gLHWp5fFQ5sO9nbNaC0xFSrsHlDxO8rBxnUIsNecVnH+ZRxL3Cjlec+JswBcE2RxjaT2
 wuMLw0foO3B/908/NXT3PjWpIa1CepuWEFdGjCDv7qxMCDb+EulwJNBD7nULWyMCjus9fz7N
 +tPzvz6PPkWp3pwstJxQ+Rx0KYzx9rzvLsGnA5qK2rGMgawAbR6L3jYgcQW7v9RxqVUsBedU
 16U/oUIIq2APc7oHQJDJAchaejfh/gYliOLsKYwKUT+oiR24KCGQQNZOBzV0H5RK758MYUEx
 +Y9uZFJt1zj20RyatvW3DpJ82msL2AbV/R1v54XN4bnlw43xwwQepfbECL3vMmCZtgk3pPG+
 dNIaH4uX4hh+3c=
IronPort-HdrOrdr: A9a23:vzv4VqxGMUpd6y1qXA2AKrPwKL1zdoMgy1knxilNoHtuA6ulfq
 GV7ZAmPHrP4wr5N0tNpTntAsa9qBDnlaKdg7N+AV7KZmCP0gaVxepZjLfK8nnNHDD/6/4Y9Y
 oISdkaNDQoNykYsS8t2njbL+od
X-IronPort-AV: E=Sophos;i="5.85,382,1624334400"; 
   d="scan'208";a="54996407"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=T3Cg2HfCcHLBg3GpnBX+PRInoJ1XSsEqdqsjgvgE9drbbd18ETsYDcYB9O3+6emqfKCE0NsT+eznsFfjKSuKS9gdWGPj0CcW3tcwsn0VbitChG88EvvarLbmQ7LG2bcH8z0x0wg8EZRyFopXtppWiq0Xh10pxYbr+BMi/edoCMkO7o9krcU5IE886Z4qNSvI49aWU73zPieGv7HSveAKMYyTeuN7QCKwCCDyVR+hvnJVuR3r3OA7NRcdFpYvoVdACJSqpHfUz+lAPHb1LkhB4JcODyojRXZZRz1w+rFx6QMTbQVb1LHWRGZmBFxjWWDEfaIEXAVDOSMiGnh53uGPnw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=h4MAdkY7uFevrVJzF/vr5+D/Gv/H/dd8ilzLcrqW3Bw=;
 b=O+AsIoTVBhgVS91b321qhTmUmmwRL5j8Q9RkoK+PnwmVr8ZMysAnIQZuVZKbkczGyQOeg/6NxoVZWwdydAp2E4qKfcGoLr+fZeKBaVMmizu3yLvzynKWqfesAVIvIkj42vp8MAMRR2YdcQPEDVBA27IxcBjzq9i/nhvnFSI6vJsJ51HFxY7rferhytfXuehR+TtKTOyTqEUZ8e2reSFhQZs/dCyNuBz2tDspPEY/GbF6Zn0nTnKX2cSJFNazO8t3Kjee7lZENXmurKUFrltrfnE9PU9PckgD/bY1hgy75UiH+bQz2ytBRf57gqC2v8+B/q0rdY4aLT+owilFrxCyrw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=h4MAdkY7uFevrVJzF/vr5+D/Gv/H/dd8ilzLcrqW3Bw=;
 b=Ui3VBN68KrQXv8xMNhDTY4YRXHj+g7nixfRWStIguaEmnE8asQPGkc3nRmU4FFTVX9t9PhDfH6yBbo0L4QbiWp+zr+5Lqi4s9u9qP82Um1eTrJlu61tzu9ex5U8r6RheKCrP05tVgcrcEi4l1a28OgVwhBai1Jbs2DOGvxFJEpw=
Date: Mon, 18 Oct 2021 15:11:42 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Ian Jackson <iwj@xenproject.org>
CC: Jan Beulich <jbeulich@suse.com>, <committers@xenproject.org>,
	<xen-devel@lists.xenproject.org>
Subject: Re: Xen 4.16 development update
Message-ID: <YW1yjgYvdQS+h7NY@MacBook-Air-de-Roger.local>
References: <24913.54299.590779.955301@mariner.uk.xensource.com>
 <24925.34307.187952.463474@mariner.uk.xensource.com>
 <e644a1d4-a7a2-0554-f639-e19ba3102294@suse.com>
 <24941.20900.439531.733506@mariner.uk.xensource.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <24941.20900.439531.733506@mariner.uk.xensource.com>
X-ClientProxiedBy: LO4P123CA0155.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:188::16) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 78bfa1d6-fe85-4ca0-506f-08d99238d660
X-MS-TrafficTypeDiagnostic: DM5PR03MB2554:
X-Microsoft-Antispam-PRVS: <DM5PR03MB25542E260C783AE0E2C30F778FBC9@DM5PR03MB2554.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:5516;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: zDmgHdqhPUpZii6qRDFJoFKcJcqIaVs1TIfLuz8JzubOM4io0m70N6BTPbcR1dbZFoJ9ZOaNxnvuSXZAfuXH3FuDAe4izA67ojWAk0NiLItDaMBsgSBVk7GfeL7fYk6b4rdnFEPzKPt4D9BWtRvlyNtb347dPo6B4q6suW5Hxv2wis15qAd2IvEd9VKT5+W/pb4lLiHZGFQDMaoiWgqzW/0QeLH37i6Rvk3V6wWjSn7gvG4hLHA+rmKUKENB0GgDmXkXnW+TSOnWYoiPHdc1Z0bHTFZsiYduofn3TNCwgOgHPQPAS7dA+fCVILlf8DLXzZ2B2oyZmqxnth8r27BGpl/t3c6J+wUiN54EiIHXdEnG4Ep0OHRvnRbj6YOnJl2gMs/HSkwy8Ilp20OB7XEVy/hD+bFxlpTSx5wCzq8EbLJuUJGRdV/Bpu+AXbzQxNCCYHwFBqw2q8XnaummDzrpgXCB9niwoGbiGhz+v0XoMzjzWOdfhksJpH/zyDP8FBAy+23Gm94G4x0Bs7ZyFKgUPGw0dOwSBKp3uroTsRbJKns5MV/5SpyM7fSE78zKJLNi3niom4pFx5XSYcTpY/yC0wROhTeBqkbZCBlk+0FNHSMD8VXoWZ33UEZDUE9xxncaz5lNo1HBUGDNhq+Fr6iPv93bp8nVZ/SJDnFXuHoYiY1Btc5a6HRjTWPbXmZxfXOmTu83jqGXyloTbD5Yg41oYA==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(8936002)(4326008)(508600001)(9686003)(6666004)(86362001)(6486002)(26005)(82960400001)(15650500001)(38100700002)(956004)(66556008)(7116003)(186003)(8676002)(2906002)(83380400001)(316002)(5660300002)(6916009)(66946007)(85182001)(6496006)(66476007)(67856001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VnpyTWNwVys5ZHVDL2V5d3pQNE5kQWlxSmsyNmNiREJxRDdDcmdudjBGelhs?=
 =?utf-8?B?V3RaU215Z0hFWUk2VXRpbHp0dHZrNUFiaE5KemJvTURJcXFWaXpFRnZIT09X?=
 =?utf-8?B?aER2blc3OXpQcmNlYStvQmdzcHVXcVVPS3E2SkNpWjVPMW5FU0VtT3ZsOUpq?=
 =?utf-8?B?SFRXKytScFhQV0JaaDZNaE9VK3JoSklEeDJneXVuN01KN2pDQWhkeFIxK2xK?=
 =?utf-8?B?alh1KzgxSUs1OE1aZXg1Q2NkSDNvRStDOU9pMUdmUWd2NHlrR29oZHgxbDNG?=
 =?utf-8?B?OXcxYittNmlzVVdTM2dhMFJBbFRmdEVvRXFBQ0NsbUlFcmpIdFVSTEY4SzB3?=
 =?utf-8?B?VndOcFdoRXpRcnNvVVY4cnJ4UDdrVEhlVFdNMmhLL1AxOVVtQUxzTG9xdGZZ?=
 =?utf-8?B?MGRjN01pbnZJQnMyMml1bkZSNHU4R216Y0x2N2wyR08vSW1sdFBvM095b3hL?=
 =?utf-8?B?Nys4V29Lbng1UGNhUk5YeVdvT0pRb3d6WkNSR0dBUVcwblQvMGlCenNaZFRC?=
 =?utf-8?B?aFMzdE1KM2Z5c0hZWjAwUGdVb2VuNGZrdncrOW9FRkd4eFQ1TEIyRDRZVlJq?=
 =?utf-8?B?WjUyWEE3S3VGdTk1L0ZkTEphUVFVNW1yczIrQ2NWRnhwSmtYTzBVTXhMaFhS?=
 =?utf-8?B?YjFUaU5oSUFRMHpuVnB6cVZ4dHVvZEpsZ21tTy9mNGxQZlA4dVlmNW4vNzdE?=
 =?utf-8?B?OU5nbnJ1dVVpVDA0eDZCa21IOFB0eGVxcjNBRjltZjVyV2szTnRLMitHZ1dU?=
 =?utf-8?B?NnRrRVAxS25HRzNNVzVIQXJXdktxVXZmd2ROeTF2YmxHZ2ZRZW9ocjZIemF3?=
 =?utf-8?B?QkllS0hiQng1UWhPc0dickNkeW5xSzZsbW1say9RRktaU2RYRjdiYWlwYUFJ?=
 =?utf-8?B?citZSzJtTG1ENmdTcW1aZkpaWmtweXhYRHFxb0hNL1lxWG1SQSs3OUp2TWVr?=
 =?utf-8?B?YzNNL0pPcFBzN1VBdjBSN1FEcjJMM1Y0d3ErUUNDSmlsVEZrT0svdCtsM25s?=
 =?utf-8?B?RHV1ZVM0aXJXL0UrWjFYc3hFZUdSbWVpMld4a1Bhc1k2YVkwbndBTkRHUlRi?=
 =?utf-8?B?RWEySnRuRUhVOHIxMlRuL083RVFWak9DcmlwbVdiNWl1bmN1eFZCY0d5MnlK?=
 =?utf-8?B?TmphTExIYzFYbUtpYm9EMTRMWHBNYVZHYVpGeC8zeDRFeFBYb2lPaWlVdXB2?=
 =?utf-8?B?aUV4bUwzcncxRldkc3E3ditCdVpTM2xwN3BKQUpNd1NSVW1rYmgzb2d3K204?=
 =?utf-8?B?a3dFcUNzTURTYld1dThzYlBOVS9La3c5aTZnckhEbktzSmI0KzJwR2FUT1RY?=
 =?utf-8?B?bW0rbVFMcmwxWjdkVkFvRWN1bWxOcFhTYjE2bXB3d3RaMUo5VjBtZlZxelF2?=
 =?utf-8?B?RmF2a1lMVUh5enoxRTI2M1FsbjFyRXhOSlB3MHhWZGJRQXU0RTZzL1Q5MHkx?=
 =?utf-8?B?WkVmczBWUm9jemVCMk1LSStwK1dZVnZHOU5GUG90NnRJWFVUUktXd1phVmNJ?=
 =?utf-8?B?aGhzTUdLV2xSWGpwYTY5QmsrR3FXcUJzTWMzdkxJZGhHT2hOeFd1M1lmeVRM?=
 =?utf-8?B?UkRXaXBiaXJKV2VPVGpOUWtCaHZ6UFNkdExzVzNTT3FDcW1zOGdwZlB4QnlM?=
 =?utf-8?B?VTJIY3YwclhUTEM2dzhoUjFFUTZpb2IvZ3NMZ1lZU1R4U0VrR2dUS0ZaUThY?=
 =?utf-8?B?QVNEdXd3WVVEcHd4MjlyanRZVU9CWHhQbENJTk52K3dreWVTOVNNYTJrdHRB?=
 =?utf-8?Q?BIqAZrhQwNZ9z1xbdta+6Gn+WVl1EVOX1MqSYkP?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 78bfa1d6-fe85-4ca0-506f-08d99238d660
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2021 13:11:46.4137
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: r+OfUQrgtG079rcnNrvsR3R1PAriiCbVwIVjak3z1ARRwpHQnA37KVaSYd5V1i7l47RrXLK7UlsZZ5sFK3nt5g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB2554
X-OriginatorOrg: citrix.com

On Mon, Oct 18, 2021 at 11:51:16AM +0100, Ian Jackson wrote:
> Jan Beulich writes ("Re: Xen 4.16 development update"):
> > Now that we're here, I of course have given up on any of the pending
> > non-bugfix patches to make 4.16. But I very much hope 4.16 won't go
> > out with known bugs having fixes available. Therefore I've pinged (in
> > some cases again):
> > 
> > x86/CPUID: don't shrink hypervisor leaves
> > x86emul: de-duplicate scatters to the same linear address
> > x86/AMD: make HT range dynamic for Fam17 and up
> > x86/PV: address odd UB in I/O emulation
> > x86/xstate: reset cached register values on resume
> > x86/altp2m: don't consider "active" when enabling failed
> > x86/PV: '0' debug key stack dumping adjustments [at least the first 2]
> > x86/paging: restrict physical address width reported to guests
> > x86/PoD: defer nested P2M flushes
> > 
> > In principle "x86: more or less log-dirty related improvements" also
> > contains a number of bug fixes, but the way this series is stuck
> > made me not include it in the pings.
> > 
> > I've tried to remember to Cc you on these pings, but I may not have
> > succeeded in doing so.
> 
> Thanks.  I got at least most of them.
> 
> Roger, would you be able to review these changes ?

Yes, already on it :).

Roger.


From xen-devel-bounces@lists.xenproject.org Mon Oct 18 13:14:53 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Oct 2021 13:14:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.212233.370026 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcSTc-0000Zp-72; Mon, 18 Oct 2021 13:14:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 212233.370026; Mon, 18 Oct 2021 13:14:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcSTc-0000Zi-3x; Mon, 18 Oct 2021 13:14:52 +0000
Received: by outflank-mailman (input) for mailman id 212233;
 Mon, 18 Oct 2021 13:14:51 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=628V=PG=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mcSTb-0000Zb-1I
 for xen-devel@lists.xenproject.org; Mon, 18 Oct 2021 13:14:51 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id c139944f-a9e5-43f9-a7a8-0c661e61cab1;
 Mon, 18 Oct 2021 13:14:50 +0000 (UTC)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2059.outbound.protection.outlook.com [104.47.13.59]) (Using
 TLS) by relay.mimecast.com with ESMTP id de-mta-6-_l_s7UZ_M12xcHrwUikPYg-1;
 Mon, 18 Oct 2021 15:14:48 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB5327.eurprd04.prod.outlook.com (2603:10a6:803:5c::23)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.17; Mon, 18 Oct
 2021 13:14:46 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.018; Mon, 18 Oct 2021
 13:14:45 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS9PR0301CA0020.eurprd03.prod.outlook.com (2603:10a6:20b:468::26) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15 via Frontend
 Transport; Mon, 18 Oct 2021 13:14:45 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c139944f-a9e5-43f9-a7a8-0c661e61cab1
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634562889;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=+HctXF8F9LSVTjNxju0dMvlO/JQrLWy6cwYDRPi9u7E=;
	b=Q7kq9bgAirutfUvJ5tVeF34RAnCf7907Ry+OhYfga4yBsvPyWnD5GGXDZwuWaS5A9gq5z0
	EuAC84VN5qlHlWaVl5dboTz2nk/ESjxWKbOGIwp9iwnxUv3v0ow5rM5HEfXDI+w9n3YEV6
	K/gTjLrh+rnLqZO+ri6Kwf737ObL0+Q=
X-MC-Unique: _l_s7UZ_M12xcHrwUikPYg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=iJ5wqfB9lhIgyaeHKmtHp1m+HMHWWpnWx3qi396XeoQIW/fc0+q2YVy0Vbwliz3MxL0bOJsoe3UA8+5PwzQaEpiUaRY86wC4M8LxAX3tdwrKoFGspeXJZPsCkzSZuqo8w9Oa+9azdwlVRjbXfoMq/GiBIE8/NaX5OC2CBrKUO+v7M3W+QlJaOJ2D4WiJTDAmZwz7bdsNEav1ouKTMAzOonDsnjLAG2Pif6IhxQ03BIkhnkTAWTada6GiWTx1N4JzO9scd6/ijfGnnTzTjSVMkaysJY9zmwZsZr7thRvH+FJVUO7zlkLGvbm2oI6zL1k7NAy/5CYEjmMJxlrRRJPfZw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=1nir/CDbgke2ctiiAkaR7d30Y01lJbfttAFYzVvKImo=;
 b=F3xeVj2mDD3Dmw/4EL4ROb3juoCxpB+4HrtxSGeXsBfb3pZz+pQnzd220x0BOnAwmdhRfaiN6Ffjep/VgqURr88cn99efYY34GDe5nfKtOhXwxI9CcOUl/HbQQ79dApcsrwQvMbEVxFLWdZLYwOD5cHbZNIx+qiuqS5aEdz3lZF+7rciwS3lZ8JTQalQJeeBxSJnSLlysFHoqJMDV4M+sg6cvHVsRV5Ok1vBj17vGFZ4Mv/6n6Oas+q3fR/GtRtr8nm51q0MZFF8rs1UaEV9fXp+ogE5rg1XLOdQvFht9RfFmIQ5zWPZfyueoHwyqyAveVdxPL0JO5aQsWyjZ/zYOw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: xen.org; dkim=none (message not signed)
 header.d=none;xen.org; dmarc=none action=none header.from=suse.com;
Subject: Re: [PATCH v2] x86/AMD: make HT range dynamic for Fam17 and up
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: Andrew Cooper <andrew.cooper3@citrix.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Wei Liu <wl@xen.org>
References: <36df1141-5c3b-6f8a-3a83-1f954b1e27a6@suse.com>
 <YW1BPPVNAVm6EPQp@MacBook-Air-de-Roger.local>
 <3f08e2bb-d80a-3336-d379-a9d76a689586@suse.com>
 <YW1yU/gogTvvRMMF@MacBook-Air-de-Roger.local>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <5f10c25d-6fe4-178e-35d5-6a5e8f445323@suse.com>
Date: Mon, 18 Oct 2021 15:14:44 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <YW1yU/gogTvvRMMF@MacBook-Air-de-Roger.local>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS9PR0301CA0020.eurprd03.prod.outlook.com
 (2603:10a6:20b:468::26) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 1251f0ed-4005-4877-82c8-08d992394153
X-MS-TrafficTypeDiagnostic: VI1PR04MB5327:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB5327396D9C0E11A1A13BBB74B3BC9@VI1PR04MB5327.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	juE4TYyJoxtjMf1uPE2Pbn6r4vCTGVEfVKjrN4f6+OY1+mbRAb0MXTCys4e47LN18zwh4wIIhdXlHcePN275CLX34jz/XSErcYpNccNoN8VBQdsSQK+gTiixbGvUnikaKIERK0s7qcG9tlW3vDlmmfSELyPIlMj35so19a5f/enVUkEAfEF6KcQ+9is829MuudvCQN0hOfY5FLYad/WNA60DyHW5bU1gi8kaNjRgT93qM02PDqymIR9wApEd1188GSIta03QQpWQisL+Sv2i3OuspHsUUVjBMB1g8ZHUYKGgz/vyLfXW3ilghqchLMZEFwratkhfoU9GIIBBXh145hidzCrGydqUliLJeEgMN0blEHCdAM8tJ1LvTuc3uEbkVTYG9B3tgk9WvG8XerNynwW4qWFGcm6CRscT8rTSac3kprMO7JZAwT/V5Nh2b6++adJw6vIIVAHuiD87do212g0pi4+1PInvw6dwQtDzrG6xUy7g5jF0GnWptymiuyGPv056Npv/FIovydizwI/FGeibHEZcRLzx1oWWWQaf2kYAbnz8XrD/VNZEftaamCbCGFQiWafSkbT3Ep3eo63Fv6rlyDXh/iY85DfemS3ArXo1AScSldTu4W+WhRjtLAUfGs9G0JtniyO+nLAtrW1DQVfuasC1pmmKyF+kE5Zyy8sBOWgL9phvUHm1cpzGHyi3XrPEzuqeSx9h9jk5LHOoytKPml3Gscl94OgzWO/P5EtvYw7VVpjVwCAOw19jyps7
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(86362001)(2616005)(53546011)(8936002)(5660300002)(956004)(6486002)(4326008)(66476007)(31686004)(66556008)(2906002)(66946007)(316002)(31696002)(8676002)(36756003)(16576012)(508600001)(6916009)(54906003)(186003)(38100700002)(83380400001)(26005)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?nuu8JAlaPhHY5ndCNdcU0p7SWIyN2ok6/TpSTNF/GV7vUHsFtl9NjYcnhiAV?=
 =?us-ascii?Q?gYT4G5tDBTh3GgQY2aVz2J+BD4xodae5wct6WElZ/+57dsqcGQHHPu0teXbM?=
 =?us-ascii?Q?1lmlLCBYZ5JDIXE9g8YnzkjQ2Lob5YMz+fP513kKMB52OlbsAEvD1DNXbayF?=
 =?us-ascii?Q?igNsbLFw3+mnSIj6Rx47fCIuHK0GLQAytQiIkogYXKBBrYFp8gDNHADRnPsP?=
 =?us-ascii?Q?YpMMBazglmbkDvwRqbbXvjLx4lQwyMMyCDo3mAMB5M2qitgFHLs/ZOrLOA4w?=
 =?us-ascii?Q?zBecHISIvbGP4PNC60OhWX2rTNPru4zisMCejkf9xgZj/FTVEq6yAx+DQqke?=
 =?us-ascii?Q?LPorPFsgNEaBbmPmOzxosAT4iltmif/Gi3qB2VHfe/gqyfHmNwfpduivlAe/?=
 =?us-ascii?Q?1yVpXAnmNZgrIf3usQoqGALpoUdNGo8ZR0XhGCEXsHb166UutBdvkgUSROgp?=
 =?us-ascii?Q?EJrkM3BzuFSf8aDDoSlPhMKOE3XWkZaA/7a1hCm9asUactyCtb/SacaxKEOe?=
 =?us-ascii?Q?n7MgXaFOhhj7IZMZpeEHTT0QK2bnJ5lu8VSOY8dp/pLShlqW/kzmK+o9rwfw?=
 =?us-ascii?Q?JRqKZTISmb67YsolvzRZSALvC3uwSfxixxFcDqkA5lmywfBoRc2Wjp1OiHsM?=
 =?us-ascii?Q?/buMwhTxi6tG/W8OANSZKhsVXA1ieQzrWzvjk/ngna+pFOg8mOHfTWDl2ctd?=
 =?us-ascii?Q?2WRsYYxfUGVuJ9t1EZMU9ZXPg63TTs4m6kFuUejNol2NT4ORqcj3PAmQn6fI?=
 =?us-ascii?Q?CjGNlZ8VhwawFJBvEnRsVVWGqtb0zvVheJ0vcQE7AJ1fh+7CP9aYu+gWpTK2?=
 =?us-ascii?Q?LmZqGLu/hQ+izEFK//8KVYl4Kjf2AbtFRkHRZh2AcTMDpQoFA7CgGg2hu71r?=
 =?us-ascii?Q?rsXZS8UshXz7cJMAy8/Ud75WV+VTertEdrLpDZmg1FUGn/RNdD4ZNESxHmCZ?=
 =?us-ascii?Q?WJ0cKkyeTqxJV4wF5fKEyBukI37gPMZn95hbXCqneN9OFlazcgWe7atbfm0c?=
 =?us-ascii?Q?tEEs/rDX3wViysX4GU6Lm38nPcMB/IhGdY27hTyV+5/6UMB7lVRiWSVBEA6L?=
 =?us-ascii?Q?cAKwNrJv4YKfLxszbNVdsKFkQ4MBv9GIzAQl9H//CPMZT1DVL3JwyowyC3Wv?=
 =?us-ascii?Q?ChtuputpnnPo4cys3rpcJUpZVfOILrnKmXtHWM/XY45E+RnKU6H58hK8AWbR?=
 =?us-ascii?Q?0t4lNQX3UWkyHkeXWWj1kXNDUBd8YcoxUZQK/bd33PncST92dq1pzeVVQVLe?=
 =?us-ascii?Q?QRZx3HvkNE6m5ez+RdM9+RfbtLHkEtrjYBAjeZOtFKm+N7zD397s6ALgxO5I?=
 =?us-ascii?Q?kOIQcPqSD2iJ8cO0ojqg9p8J?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1251f0ed-4005-4877-82c8-08d992394153
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2021 13:14:45.7668
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: mNOltvR5Uw1mI8AqtxAvqvWIA3tG216LWgCi3c6W7ep4WbWVt/G+Fd9EtJ5074UN7REqlarVPdd+jKgiazsSww==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5327

On 18.10.2021 15:10, Roger Pau Monn=C3=A9 wrote:
> On Mon, Oct 18, 2021 at 12:18:16PM +0200, Jan Beulich wrote:
>> On 18.10.2021 11:41, Roger Pau Monn=C3=A9 wrote:
>>> On Mon, Jun 28, 2021 at 01:48:53PM +0200, Jan Beulich wrote:
>>>> At the time of d838ac2539cf ("x86: don't allow Dom0 access to the HT
>>>> address range") documentation correctly stated that the range was
>>>> completely fixed. For Fam17 and newer, it lives at the top of physical
>>>> address space, though.
>>>>
>>>> To correctly determine the top of physical address space, we need to
>>>> account for their physical address reduction, hence the calculation of
>>>> paddr_bits also gets adjusted.
>>>>
>>>> While for paddr_bits < 40 the HT range is completely hidden, there's n=
o
>>>> need to suppress the range insertion in that case: It'll just have no
>>>> real meaning.
>>>>
>>>> Reported-by: Igor Druzhinin <igor.druzhinin@citrix.com>
>>>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>>>
>>> Reviewed-by: Roger Pau Monn=C3=A9 <roger.pau@citrix.com>
>>
>> Thanks, but before applying this I'd prefer to resolve your concern
>> voiced below.
>>
>>>> --- a/xen/arch/x86/cpu/common.c
>>>> +++ b/xen/arch/x86/cpu/common.c
>>>> @@ -349,16 +349,23 @@ void __init early_cpu_init(void)
>>>> =20
>>>>  	eax =3D cpuid_eax(0x80000000);
>>>>  	if ((eax >> 16) =3D=3D 0x8000 && eax >=3D 0x80000008) {
>>>> +		ebx =3D eax >=3D 0x8000001f ? cpuid_ebx(0x8000001f) : 0;
>>>>  		eax =3D cpuid_eax(0x80000008);
>>>> +
>>>>  		paddr_bits =3D eax & 0xff;
>>>>  		if (paddr_bits > PADDR_BITS)
>>>>  			paddr_bits =3D PADDR_BITS;
>>>> +
>>>>  		vaddr_bits =3D (eax >> 8) & 0xff;
>>>>  		if (vaddr_bits > VADDR_BITS)
>>>>  			vaddr_bits =3D VADDR_BITS;
>>>> +
>>>>  		hap_paddr_bits =3D ((eax >> 16) & 0xff) ?: paddr_bits;
>>>>  		if (hap_paddr_bits > PADDR_BITS)
>>>>  			hap_paddr_bits =3D PADDR_BITS;
>>>> +
>>>> +		/* Account for SME's physical address space reduction. */
>>>> +		paddr_bits -=3D (ebx >> 6) & 0x3f;
>>>
>>> Does it make sense to check for 0x8000001f[eax] bit 0 in order to
>>> assert that there's support for SME, or assuming that the reduction is
>>> !=3D 0 in the other cpuid leaf is enough.
>>
>> Documentation doesn't really tie them together afaics, so I thought
>> I wouldn't either. I was reading into this lack of an explicit
>> connection the possibility of address space reduction to also,
>> hypothetically at this point, apply to other features.
>>
>>> It's possible for firmware vendors to disable advertising the SME
>>> support bit and leave the physical address space reduction one in
>>> place?
>>
>> I don't know if it's possible (I'm unaware of e.g. MSR-level control
>> allowing to modify these independently), but if it is I'd consider
>> it inconsistent if one but not the other was zapped. I'm unconvinced
>> that we really would need to deal with such inconsistencies, the
>> more that it's not really clear what the inconsistent setting would
>> really mean for the placement of the HT range.
>=20
> Thanks, I think your proposed solution is fine.
>=20
>> While writing this, there was one more thing I came to think of:
>> Should we perhaps suppress the iomem_deny_access() altogether when
>> running virtualized ourselves?
>=20
> Hm, hard to tell TBH. HT being part of the platform specification
> for AMD it would feel wrong for hypervisors to attempt to populate
> this range.

Okay, I'll leave it as is then. If we decide otherwise, we always
can make an incremental change. Thanks for the feedback!

Jan



From xen-devel-bounces@lists.xenproject.org Mon Oct 18 13:17:15 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Oct 2021 13:17:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.212240.370036 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcSVr-0001D4-KL; Mon, 18 Oct 2021 13:17:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 212240.370036; Mon, 18 Oct 2021 13:17:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcSVr-0001Cx-HR; Mon, 18 Oct 2021 13:17:11 +0000
Received: by outflank-mailman (input) for mailman id 212240;
 Mon, 18 Oct 2021 13:17:10 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=eZ0x=PG=tklengyel.com=tamas@srs-us1.protection.inumbo.net>)
 id 1mcSVq-0001Cr-5a
 for xen-devel@lists.xenproject.org; Mon, 18 Oct 2021 13:17:10 +0000
Received: from MTA-08-3.privateemail.com (unknown [198.54.127.61])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id b1f40e90-3015-11ec-82d7-12813bfff9fa;
 Mon, 18 Oct 2021 13:17:08 +0000 (UTC)
Received: from mta-08.privateemail.com (localhost [127.0.0.1])
 by mta-08.privateemail.com (Postfix) with ESMTP id 9101018000BB
 for <xen-devel@lists.xenproject.org>; Mon, 18 Oct 2021 09:17:07 -0400 (EDT)
Received: from mail-yb1-f173.google.com (unknown [10.20.151.226])
 by mta-08.privateemail.com (Postfix) with ESMTPA id 6A5A318000B2
 for <xen-devel@lists.xenproject.org>; Mon, 18 Oct 2021 09:17:07 -0400 (EDT)
Received: by mail-yb1-f173.google.com with SMTP id q189so2794946ybq.1
 for <xen-devel@lists.xenproject.org>; Mon, 18 Oct 2021 06:17:07 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b1f40e90-3015-11ec-82d7-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=tklengyel.com;
	s=default; t=1634563027;
	bh=sQZZFHl5Dl8asJgGz20aWayFRwxypZ4Jayizx7O6u2Y=;
	h=References:In-Reply-To:From:Date:Subject:To:Cc:From;
	b=jG90ZtxVXFOxafMsCReF3xQZlVhmmzVrhZRJ+COxSfz9QcxLuzgAKPwvDnjMIBMSL
	 X41HtSOSjSFxmlNAYD3n5wKp1ZCYLbqaGZ50v8QmSQ3qxB4mQcdiplbFN6Q82/k88t
	 eL2unutwTKoHK0JOJE7GesYUnScJdMA8iiJ0gfHx1iKL8CaNlZ9+OI6i/x2zG6I5zJ
	 0vLeQqF6wk8neE8Cy9G69/bg3fC7cG12fjzIlXQItV9XNpLXDoVTXozaBJNJ/TbLSa
	 X6ITt+s8L4V+x4f1fpd0/R1RF9HSjhFUF2hT1N/oIvsZ2we+4hic75Lpmz6qcF73bV
	 NuMJvAgeskE9Q==
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=tklengyel.com;
	s=default; t=1634563027;
	bh=sQZZFHl5Dl8asJgGz20aWayFRwxypZ4Jayizx7O6u2Y=;
	h=References:In-Reply-To:From:Date:Subject:To:Cc:From;
	b=jG90ZtxVXFOxafMsCReF3xQZlVhmmzVrhZRJ+COxSfz9QcxLuzgAKPwvDnjMIBMSL
	 X41HtSOSjSFxmlNAYD3n5wKp1ZCYLbqaGZ50v8QmSQ3qxB4mQcdiplbFN6Q82/k88t
	 eL2unutwTKoHK0JOJE7GesYUnScJdMA8iiJ0gfHx1iKL8CaNlZ9+OI6i/x2zG6I5zJ
	 0vLeQqF6wk8neE8Cy9G69/bg3fC7cG12fjzIlXQItV9XNpLXDoVTXozaBJNJ/TbLSa
	 X6ITt+s8L4V+x4f1fpd0/R1RF9HSjhFUF2hT1N/oIvsZ2we+4hic75Lpmz6qcF73bV
	 NuMJvAgeskE9Q==
X-Gm-Message-State: AOAM533TMg2Icl6gaKT3TYYYjl9QZ/mmuZS+9/befpPWeDmltvFnt5f0
	mUw5khM7NQ94WezXSRbc/kO6nkckq+F7PM0PqNw=
X-Google-Smtp-Source: ABdhPJxLGOWRqX6MIVWSahltV3Qzg0iGuHP+5H2flEzGMJSBYsqU+yfAI/Az8PNIJudBuHw35oS6JKvCXvnw6mTR/4A=
X-Received: by 2002:a25:2cd6:: with SMTP id s205mr28943192ybs.367.1634563026625;
 Mon, 18 Oct 2021 06:17:06 -0700 (PDT)
MIME-Version: 1.0
References: <f0de7945-84df-8668-f94a-c15cd5196be3@suse.com> <7f947b0b-4b65-51cb-c098-edf056610fb0@suse.com>
In-Reply-To: <7f947b0b-4b65-51cb-c098-edf056610fb0@suse.com>
From: Tamas K Lengyel <tamas@tklengyel.com>
Date: Mon, 18 Oct 2021 09:16:30 -0400
X-Gmail-Original-Message-ID: <CABfawhmYzu43sMSG_TD0kHhvEjQfo1S-d-iz6cqFwb4JNbjbDA@mail.gmail.com>
Message-ID: <CABfawhmYzu43sMSG_TD0kHhvEjQfo1S-d-iz6cqFwb4JNbjbDA@mail.gmail.com>
Subject: Re: Ping: [PATCH] x86/altp2m: don't consider "active" when enabling failed
To: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>, 
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Ian Jackson <iwj@xenproject.org>, 
	Petre Pircalabu <ppircalabu@bitdefender.com>, Alexandru Isaila <aisaila@bitdefender.com>
Content-Type: multipart/alternative; boundary="00000000000090b08805cea05cef"
X-Virus-Scanned: ClamAV using ClamSMTP

--00000000000090b08805cea05cef
Content-Type: text/plain; charset="UTF-8"

On Mon, Oct 18, 2021 at 4:26 AM Jan Beulich <jbeulich@suse.com> wrote:

> On 25.08.2021 11:31, Jan Beulich wrote:
> > We should not rely on guests to not use altp2m after reporting failure
> > of HVMOP_altp2m_set_domain_state to them. Set "active" back to false in
> > this case.
> >
> > Signed-off-by: Jan Beulich <jbeulich@suse.com>
>
> Because of their relationship, I'm also Cc-ing the vm-event maintainers /
> reviewers: Maybe one of you would care to review this one?
>
> Jan
>
> > --- a/xen/arch/x86/hvm/hvm.c
> > +++ b/xen/arch/x86/hvm/hvm.c
> > @@ -4609,6 +4609,8 @@ static int do_altp2m_op(
> >              if ( ostate )
> >                  p2m_flush_altp2m(d);
> >          }
> > +        else if ( rc )
> > +            d->arch.altp2m_active = false;
> >
> >          domain_unpause_except_self(d);
> >          break;


Reviewed-by: Tamas K Lengyel <tamas@tklengyel.com>

--00000000000090b08805cea05cef
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote">=
<div dir=3D"ltr" class=3D"gmail_attr">On Mon, Oct 18, 2021 at 4:26 AM Jan B=
eulich &lt;<a href=3D"mailto:jbeulich@suse.com">jbeulich@suse.com</a>&gt; w=
rote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0p=
x 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On 25.08.2=
021 11:31, Jan Beulich wrote:<br>
&gt; We should not rely on guests to not use altp2m after reporting failure=
<br>
&gt; of HVMOP_altp2m_set_domain_state to them. Set &quot;active&quot; back =
to false in<br>
&gt; this case.<br>
&gt; <br>
&gt; Signed-off-by: Jan Beulich &lt;<a href=3D"mailto:jbeulich@suse.com" ta=
rget=3D"_blank">jbeulich@suse.com</a>&gt;<br>
<br>
Because of their relationship, I&#39;m also Cc-ing the vm-event maintainers=
 /<br>
reviewers: Maybe one of you would care to review this one?<br>
<br>
Jan<br>
<br>
&gt; --- a/xen/arch/x86/hvm/hvm.c<br>
&gt; +++ b/xen/arch/x86/hvm/hvm.c<br>
&gt; @@ -4609,6 +4609,8 @@ static int do_altp2m_op(<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 if ( ostate )<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 p2m_flus=
h_altp2m(d);<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 }<br>
&gt; +=C2=A0 =C2=A0 =C2=A0 =C2=A0 else if ( rc )<br>
&gt; +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 d-&gt;arch.altp2m_active =
=3D false;<br>
&gt;=C2=A0 <br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 domain_unpause_except_self(d);<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 break;</blockquote><div><br></div><d=
iv>Reviewed-by: Tamas K Lengyel &lt;<a href=3D"mailto:tamas@tklengyel.com">=
tamas@tklengyel.com</a>&gt;<br></div></div></div>

--00000000000090b08805cea05cef--


From xen-devel-bounces@lists.xenproject.org Mon Oct 18 13:18:39 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Oct 2021 13:18:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.212246.370048 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcSXH-0001qb-05; Mon, 18 Oct 2021 13:18:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 212246.370048; Mon, 18 Oct 2021 13:18:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcSXG-0001qU-TC; Mon, 18 Oct 2021 13:18:38 +0000
Received: by outflank-mailman (input) for mailman id 212246;
 Mon, 18 Oct 2021 13:18:37 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mcSXF-0001q8-QF
 for xen-devel@lists.xenproject.org; Mon, 18 Oct 2021 13:18:37 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mcSXF-0005cQ-Nt
 for xen-devel@lists.xenproject.org; Mon, 18 Oct 2021 13:18:37 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mcSXF-00050C-Mk
 for xen-devel@lists.xenproject.org; Mon, 18 Oct 2021 13:18:37 +0000
Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89)
 (envelope-from <iwj@xenproject.org>)
 id 1mcSXC-0005wL-5B; Mon, 18 Oct 2021 14:18:34 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date
	:Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From;
	bh=U9N4oku3+r/oA+wzLhvgv5YGr6VwYX08ChVjtI+J/dg=; b=ncgWDnBfIBj66GQstFdRsghML6
	lYGnmficWJTy8Cmse264M5h2AA8Wc95COmCKPFLcydHH056pVfMnanelC+FDdbct/fVMHpIoZ0mDW
	v9GW9qKeOgI62cKkzEShR/34x3ItbwnVhrpHqcb2Hn1Ctu1Yq6CGR5WbiX1FhSHUgXz0=;
From: Ian Jackson <iwj@xenproject.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <24941.29737.869343.966550@mariner.uk.xensource.com>
Date: Mon, 18 Oct 2021 14:18:33 +0100
To: Juergen Gross <jgross@suse.com>
Cc: xen-devel@lists.xenproject.org,
    Wei Liu <wl@xen.org>
Subject: [PATCH v6 0/2] tools/xenstore: set resource limits of xenstored
In-Reply-To: <20211012134148.6280-1-jgross@suse.com>
References: <20211012134148.6280-1-jgross@suse.com>
X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu)

Juergen Gross writes ("[PATCH v6 0/2] tools/xenstore: set resource limits of xenstored"):
> Set some limits for xenstored in order to avoid it being killed by
> OOM killer, or to run out of file descriptors.

It looks like these were overlooked; they should have gone in last
week.

I think this is arguably a bugfix and we have time to fix it if it
causes a problem, and it's only one working day late, so for the
record

Release-Acked-by: Ian Jackson <iwj@xenproject.org>

and I will push these now.

Ian.


From xen-devel-bounces@lists.xenproject.org Mon Oct 18 13:24:23 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Oct 2021 13:24:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.212254.370059 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcScl-0003GW-LT; Mon, 18 Oct 2021 13:24:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 212254.370059; Mon, 18 Oct 2021 13:24:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcScl-0003GP-Hm; Mon, 18 Oct 2021 13:24:19 +0000
Received: by outflank-mailman (input) for mailman id 212254;
 Mon, 18 Oct 2021 13:24:18 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=6zTk=PG=suse.com=jgross@srs-us1.protection.inumbo.net>)
 id 1mcScj-0003GJ-Uj
 for xen-devel@lists.xenproject.org; Mon, 18 Oct 2021 13:24:17 +0000
Received: from smtp-out2.suse.de (unknown [195.135.220.29])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 4b59636e-902b-4d43-a740-f8ae1742a6c3;
 Mon, 18 Oct 2021 13:24:16 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id C1D7C1FD6D;
 Mon, 18 Oct 2021 13:24:15 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 6975C14059;
 Mon, 18 Oct 2021 13:24:15 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id YsiCGH91bWEiWwAAMHmgww
 (envelope-from <jgross@suse.com>); Mon, 18 Oct 2021 13:24:15 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4b59636e-902b-4d43-a740-f8ae1742a6c3
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1634563455; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=bLwgFz0ouk70aMvqE/oxcKXjMKpaMZaJazTtxliKYDc=;
	b=j6TT/MWL6A7RpktjwPNPwhEdZKNkEYdB37foTRuM382dxj15lNMXvqe3Myp9jdzn49GPET
	5T3YzN9hujhtE9LF9/oAOJIDzStxwhg/rxwjbwFBp5QR8jt0IR2aeDDgQ8g8QkWmV0DdXY
	i9auQkF7dtdG6ZRtW9B6FJEpS72aqFY=
To: Jan Beulich <jbeulich@suse.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>, Julien Grall
 <julien@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Wei Liu <wl@xen.org>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>, Christopher Clark <christopher.w.clark@gmail.com>,
 xen-devel@lists.xenproject.org
References: <20211015125152.25198-1-jgross@suse.com>
 <20211015125152.25198-4-jgross@suse.com>
 <7bd0cff1-6e88-f8dd-d857-229e75dd2772@suse.com>
From: Juergen Gross <jgross@suse.com>
Subject: Re: [PATCH 03/12] xen: harmonize return types of hypercall handlers
Message-ID: <0ca6cdf1-330b-f47f-dea8-442c3cc268ea@suse.com>
Date: Mon, 18 Oct 2021 15:24:14 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <7bd0cff1-6e88-f8dd-d857-229e75dd2772@suse.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="IEjcj4KKxUWqGed8LunLYFPQPQ0wxaXYl"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--IEjcj4KKxUWqGed8LunLYFPQPQ0wxaXYl
Content-Type: multipart/mixed; boundary="xsHi2Sg6c3bEE1kNlMkoAyGeiJaA2RIB4";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>, Julien Grall
 <julien@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Wei Liu <wl@xen.org>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>, Christopher Clark <christopher.w.clark@gmail.com>,
 xen-devel@lists.xenproject.org
Message-ID: <0ca6cdf1-330b-f47f-dea8-442c3cc268ea@suse.com>
Subject: Re: [PATCH 03/12] xen: harmonize return types of hypercall handlers
References: <20211015125152.25198-1-jgross@suse.com>
 <20211015125152.25198-4-jgross@suse.com>
 <7bd0cff1-6e88-f8dd-d857-229e75dd2772@suse.com>
In-Reply-To: <7bd0cff1-6e88-f8dd-d857-229e75dd2772@suse.com>

--xsHi2Sg6c3bEE1kNlMkoAyGeiJaA2RIB4
Content-Type: multipart/mixed;
 boundary="------------CFA04F7C4334BD41A928A5F6"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------CFA04F7C4334BD41A928A5F6
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 18.10.21 13:55, Jan Beulich wrote:
> On 15.10.2021 14:51, Juergen Gross wrote:
>> Today most hypercall handlers have a return type of long, while the
>> compat ones return an int. There are a few exceptions from that rule,
>> however.
>>
>> Get rid of the exceptions by letting compat handlers always return int=

>> and others always return long.
>>
>> For the compat hvm case use eax instead of rax for the stored result a=
s
>> it should have been from the beginning.
>>
>> Additionally move some prototypes to include/asm-x86/hypercall.h
>> as they are x86 specific. Move the do_physdev_op() prototype from both=

>> architecture dependant headers to the common one. Move the
>> compat_platform_op() prototype to the common header.
>>
>> Switch some non style compliant types (u32, s32, s64) to style complia=
nt
>> ones.
>>
>> Rename paging_domctl_continuation() to do_paging_domctl_cont() and add=

>> a matching define for the associated hypercall.
>>
>> Make do_callback_op() and compat_callback_op() more similar by adding
>> the const attribute to compat_callback_op()'s 2nd parameter.
>>
>> The do_platform_op() prototype needs to be modified in order to better=

>> match its compat variant.
>=20
> "Better" in what direction? So far both have been using typed handles,
> which I consider better than void ones. You also don't seem to have
> had a reason to switch e.g. multicall or dm_op, where (different)
> typed handles are also in use. So I wonder what the reason for this
> change is.

I had some problems making this build. Before my patches
platform_hypercall.c didn't include the header with the prototype,
so there was no mismatch detected.

Thanks for the pointers above. dm_op is no good example, as the
compat variant is explicitly a different implementation compared
to the normal one. But with the multicall example I can have
another try converting platform_op to a type safe variant using
non-void handles.

>=20
>> Change the type of the cmd parameter for [do|compat]_kexec_op() to
>> unsigned int, as this is more appropriate for the compat case.
>=20
> The change for the compat case is fine, but for native you change
> behavior for callers passing values equaling valid KEXEC_CMD_*
> modulo 2=C2=B3=C2=B2.

TBH, I don't think this is really a problem. Or do you think there
really is a user of this interface relying on a -ENOSYS in this
case?

>=20
>> --- a/xen/arch/x86/pv/misc-hypercalls.c
>> +++ b/xen/arch/x86/pv/misc-hypercalls.c
>> @@ -28,12 +28,16 @@ long do_set_debugreg(int reg, unsigned long value)=

>>       return set_debugreg(current, reg, value);
>>   }
>>  =20
>> -unsigned long do_get_debugreg(int reg)
>> +long do_get_debugreg(int reg)
>>   {
>> -    unsigned long val;
>> -    int res =3D x86emul_read_dr(reg, &val, NULL);
>> -
>> -    return res =3D=3D X86EMUL_OKAY ? val : -ENODEV;
>> +    /* Avoid undefined behavior due to casting an unsigned long to lo=
ng. */
>=20
> Nit: unsigned -> signed conversion is implementation-defined, not
> undefined.

Okay, will change the comment.

>=20
>> --- a/xen/common/argo.c
>> +++ b/xen/common/argo.c
>> @@ -2207,13 +2207,13 @@ do_argo_op(unsigned int cmd, XEN_GUEST_HANDLE_=
PARAM(void) arg1,
>>   }
>>  =20
>>   #ifdef CONFIG_COMPAT
>> -long
>> -compat_argo_op(unsigned int cmd, XEN_GUEST_HANDLE_PARAM(void) arg1,
>> -               XEN_GUEST_HANDLE_PARAM(void) arg2, unsigned long arg3,=

>> -               unsigned long arg4)
>> +int compat_argo_op(unsigned int cmd,
>> +                   XEN_GUEST_HANDLE_PARAM(void) arg1,
>> +                   XEN_GUEST_HANDLE_PARAM(void) arg2,
>> +                   unsigned long arg3, unsigned long arg4)
>=20
> Strictly speaking arg3 and arg4 also ought to be unsigned int here.
> But that's perhaps for a separate patch at another time.

I'd rather leave it as is, as this way I can use the same definition for
both cases in patch 6. And I don't see how anything could go wrong this
way, as expanding a 32-bit unsigned value to 64 bits is in no way
ambiguous.


Juergen

--------------CFA04F7C4334BD41A928A5F6
Content-Type: application/pgp-keys;
 name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Transfer-Encoding: quoted-printable
Content-Description: OpenPGP public key
Content-Disposition: attachment;
 filename="OpenPGP_0xB0DE9DD628BF132F.asc"

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy=
cWx
w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O=
f8Z
d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y=
9bf
IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq=
G7/
377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR=
3Jv
c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA=
QIe
AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT=
hpw
dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0=
MbD
1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv=
oPH
Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v=
5QL
+qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ=
2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC=
QoL
BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr=
Wf0
teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC=
/nu
AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh=
ITT
d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm=
XBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz=
80h
SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC=
AcD
AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn=
FOX
gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1=
jnD
kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0=
N51
N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l=
otu
fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1=
tqS
EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA=
hsD
BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3=
g3O
ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5=
dM7
wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5=
D+j
LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm=
V2x
AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N=
Eaw
QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW=
nHI
s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR=
wgn
BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV=
bVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk=
pEd
IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA=
QAB
wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw=
Tbe
8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1=
vJz
Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8=
VGi
wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW=
svi
uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX=
zXs
ZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------CFA04F7C4334BD41A928A5F6--

--xsHi2Sg6c3bEE1kNlMkoAyGeiJaA2RIB4--

--IEjcj4KKxUWqGed8LunLYFPQPQ0wxaXYl
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmFtdX4FAwAAAAAACgkQsN6d1ii/Ey9Y
6ggAkJwRRhpHZpePa42IEeFcuZJKVgK4c380HETnYrHSsYDikdyuf/qYC41UlsfWkZQSsn4zfrxR
12RjOIGvh6WkI50CE+uMLPfbJKK0D0kIlifAChTwJVOBL09UOnzFjZxaOOszfVas4nW90vuElHw6
P9rOM3Vvr3+kLdnfyxTN/rabRxVf6GcmB1F49468hVW5hH6q+o1b4E2FLhzhH1+QcUruQ3wmvCiI
WNOv3dNH/oRPTqVajYrelVl2Oi4hsQeFEMfWr40qwHuXNXUGe6lxl4G2/FC+jpKJXxB8jgvgZfcL
FxwjRe23mM5fwDef2jgYZvXc1+9xqg/qWCXr0wusWg==
=+5A/
-----END PGP SIGNATURE-----

--IEjcj4KKxUWqGed8LunLYFPQPQ0wxaXYl--


From xen-devel-bounces@lists.xenproject.org Mon Oct 18 13:25:34 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Oct 2021 13:25:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.212263.370069 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcSdy-0003wy-3q; Mon, 18 Oct 2021 13:25:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 212263.370069; Mon, 18 Oct 2021 13:25:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcSdy-0003wr-0j; Mon, 18 Oct 2021 13:25:34 +0000
Received: by outflank-mailman (input) for mailman id 212263;
 Mon, 18 Oct 2021 13:25:32 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=628V=PG=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mcSdw-0003wj-S0
 for xen-devel@lists.xenproject.org; Mon, 18 Oct 2021 13:25:32 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id f289198a-f5d4-4f79-9980-091f49a22ae6;
 Mon, 18 Oct 2021 13:25:31 +0000 (UTC)
Received: from EUR02-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur02lp2054.outbound.protection.outlook.com [104.47.4.54]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-26-P3oYGPTWPFalbyxKVTSM4g-1; Mon, 18 Oct 2021 15:25:29 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB4383.eurprd04.prod.outlook.com (2603:10a6:803:6b::24)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16; Mon, 18 Oct
 2021 13:25:28 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.018; Mon, 18 Oct 2021
 13:25:28 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS9PR04CA0052.eurprd04.prod.outlook.com (2603:10a6:20b:46a::21) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.14 via Frontend
 Transport; Mon, 18 Oct 2021 13:25:27 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f289198a-f5d4-4f79-9980-091f49a22ae6
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634563530;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=4P8Woev+XF47DAYisPnHcFWfKJ49yuCTydDc5pMJ8YU=;
	b=KEDwf8nr2KgNOb9YAEpLXDNMsH4V1XIT7/MuWFMCm/nfSROCp7RAeAOARQhsGlgfSEeOvO
	0kWsPQZ9WZLJp3gMndqoQFbk+TBVRRwV7YnpHioqOtmj3H0TFbJPlgdlob9bP3FZqQlU6b
	IN3JaU8MbrDDsP3Xg/X9atkVWdgl83Y=
X-MC-Unique: P3oYGPTWPFalbyxKVTSM4g-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=DjLbBMssJD0Q+puGFHk/Y3kakXNcjr47H3TwUqCkXDSsRSJoSJ+/rfNC0cbj5T8GoE/y7nD5toqU9Gh9wxsYR8pTp5uuyR69rkbGoRP8MC6HWM42b1RfRCPd8Qu1bj7RI1c6QB7hp1WjCjibjrF3A7r+SCA8SwCFqnp0W4rC9aEERnh/Zz3WwGci/FydosyFAe3JGy9114p5/R81md9OkPQrB6DsBbuJhukhJJ6iC73rvTJfwibGeiDJzYMvTocQa7O/ACqZb+3rQKFte2oq4zategy8AdQlDssu8csb533Rk5hMV76GX5GGa6db5sPMO6ZNbPqRB1aBbpFfmcac5A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=4P8Woev+XF47DAYisPnHcFWfKJ49yuCTydDc5pMJ8YU=;
 b=VVlX2r4COTbZ2fonRxIDCzWFIsjDkrBlz+ZOFyyFG+0y6LD/JzMUczFlrvOj0XNoeH2irKPAv8bpOCcnki5RUTMx8PY3a5YV6NqUeGn+VXcreA+0nOvI9WmWG4R2UThO/NtkO8x+hu6B1EKV61OSZzBKJuCkIB3n4e1MDjFWgRJgKEaYZzx+1Toe9Rx1DEnGBpveudM/Zg5X5FSh03ahv5NNSofyuSMFoVjA5AVRqM8UYg8fhHP8CsvmB5XJBJGY1CcTWeFPe60Ze/rkueBBLgxl1vCcRM7T5l2Ss/e+8+K0QJ+H8Ip46iErknG7h33/p7s2zkZKHNnIfHo/F3evvA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [PATCH 2/2] memory: XENMEM_add_to_physmap (almost) wrapping
 checks
To: Julien Grall <julien@xen.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <4f54456b-e8da-f67f-b6a0-b5ce2cf12cae@suse.com>
 <f78f8a30-39b7-cec2-2af0-27ebab28cedd@suse.com>
 <561dcb90-7b6d-4dd6-2ca7-a4a5ec1c5e35@xen.org>
 <5e829583-d593-3b19-ea54-acb31ee8eec9@suse.com>
 <de2a74f3-5b7d-d0b2-28a1-c3efe5ae05de@xen.org>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <2e60ea4d-ecf1-b93d-540f-2da24383d060@suse.com>
Date: Mon, 18 Oct 2021 15:25:26 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <de2a74f3-5b7d-d0b2-28a1-c3efe5ae05de@xen.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR04CA0052.eurprd04.prod.outlook.com
 (2603:10a6:20b:46a::21) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 2ced92c6-3738-4bbc-f8be-08d9923ac060
X-MS-TrafficTypeDiagnostic: VI1PR04MB4383:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB4383B0649884AD524F641F06B3BC9@VI1PR04MB4383.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	PsxGhT7nIHkxeCr5sWXW9qhIOj957z0VpEmYstzkbU8SaCIflPuUcC8O3plyJqJq5szJhLG/WkFWcX/KVqAvPakdWRXFubBWWW/acXCDuywBb6veJ0+BznDn/YfURQcgnzSozAZKCo12yR37dTjmmCxqrJXBcqIfTEMaJFtQNhK9Nz75PehDNfboBlVoD2OrvRVBcWMqw3ArJFksgde0gy+6GSfC1WK39X7EVDGskxqQuBxAnVFFwhyA/tvclaM19jk6R+VRvT2TWg9VQJJ0oO23KeiH403r3N14mkKgr2M0IkQGrLPkjLDQyz8tUFXT6ao9CkDHItLVnnxTJ40VSiMDkgIOk6AZV3yy2IqV50idzo02KirrUfnVTrYG1Q+gopr3dGrCQmKKGtxRi27UdlJ+ms0QsYpMKEEkyln5eqe0vtjaGF5/1k0lRCyIW797agR3dA3zBqijsKrBncQBaJIRWzwZrwPkV9S0jz9qvfB9KHFixStRgCLBh1kudEQgGLzm+Vj2bJ3IIYFiscIhdWG3hakIoFUol2UPpdieuqJFzjndPJGJVkZU55O41yhaiPpqqovPMaB4DmzMhkzNWfldGtwkkVPES1zt7mTMLJzHUY/OTyi+DF0fD625M8s4HpYWzBWWJ41LzT/WuCNhAqBig8XtkJ8HZj4oHOKM3LS74PK5cNdmUqw8FV9BxaxWmjQyHFbvDu1xptvGS/rrrXYMta8GUD7B/wCKbKTZlizUDL0ueSyKOr9v9Hr6nWdq
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(66946007)(6486002)(5660300002)(36756003)(186003)(8676002)(31696002)(8936002)(2616005)(66556008)(956004)(508600001)(66476007)(316002)(38100700002)(31686004)(26005)(86362001)(54906003)(6916009)(4326008)(83380400001)(2906002)(16576012)(53546011)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?NmFKRVRuSXV3SkVNaDMxdHZoZWVSYms2d0F1M1ZJQUI2VU1FWXZ4OXJjanFQ?=
 =?utf-8?B?TnJabnFRY1hNSjlMajZZTjNsS3hMWGZSWWc1SGZPSmhwMFhaV2x1Mi9WRXVG?=
 =?utf-8?B?MURLa0d5NDVHK3M3UFhYS0hZVWthUE45ZlRtVkx2UzVkUWtESWV2UjlGb0Fz?=
 =?utf-8?B?WVM1VUUwdUtsTFFoYzNDdHpLVmRabi83Nk5udUtQekRJQUp5TDZTWlZWR2w3?=
 =?utf-8?B?WXBRa1F0UU9ITFhRMGRoT1ZOeWFWVDIrakRFOEhUZkpKbytsRG9nTmpuNVRY?=
 =?utf-8?B?Z29hSzJFNWRHM0FubnBuUmEyekdqek1QQmJIY2JEY1ZqVkR1ZUQya0FzN0Nj?=
 =?utf-8?B?bENzNGhkb05ZOHZzUTJQTEVJR1B4UjMvbUU0SlNnNThKSUs5TzYyRXkzSzU3?=
 =?utf-8?B?NzNYMUdGT1dtTDNaTGJUTnU5WGphK3VzUi9aUmJuMDcxMWNrVmk4Wkw2L3VR?=
 =?utf-8?B?M0h6ODd1bGdCZnA3TW5mODNDS0d3WmxiUnMxMFUrM1ZHUy94VGVId251TzRL?=
 =?utf-8?B?QndXZ1N4TjFsaXBCZ2lSckxTMC9sano4SkhYYU1IamRvYURlUlp1Y1d5RHVG?=
 =?utf-8?B?a2o5Ny96YzlXa2pqSis4SjAzMUNyMGhDRm5lYm0xSkJ0N2Z0NGMra0RGc3Vi?=
 =?utf-8?B?ay9vZFFybGlMYWhaRjNVK0R3aDVqZnhQcnFJcXNIMFg1eVlRdmZtZWlqZjRh?=
 =?utf-8?B?U1JLdUpaRnpsMnNRRVdlMEUrTGZ6UThMOFVQano4bWRMTU5qWWZWWmRtVnF0?=
 =?utf-8?B?MzZlYW9jN2c3MGowL3pUVC84Z0Q2cktmK1pEczFKdXFVSXR3SjRHc3ZQUXRZ?=
 =?utf-8?B?YVFCRGNDY3I5ZHNEWitqdVdET0xYMXhLb21DWjJpdDk3M2lkRDJzNk1HMVE1?=
 =?utf-8?B?eXFjb0c4TklBTUdKeUZ1N09QWDVhNGFSd01rQUV6aVdsYTNXek9CWkluVWw5?=
 =?utf-8?B?WjhweVcvcmpZUXZncU8vNTBuUHA0SENjT1o1RGV6elFMVjhld1Y0SFN6VUdD?=
 =?utf-8?B?YitMNUp1ZklSaXFJbEFNM1NPNVpMcVBrbVRXVk81azVHWEs2N2h6Y0ZEYmVN?=
 =?utf-8?B?cHNYR1piWkI0SmZ5ckdmWFlDU29PSnpEb2ttZURpOUhSSzVjdTVzQTZValZL?=
 =?utf-8?B?WWsrcmp2SlhENlV3alJxWkwyd21rUjRwZTllNlYwV096ckRMLzdaT1Era2Nk?=
 =?utf-8?B?MEdxN2xLSUdFdU8xODU2eTB4RVNTbUJ2WDM4b3hEaEtFWHdUVVY1MUxNRklE?=
 =?utf-8?B?ZE53ZURPd2tZWjlXTWZWZ0NvVUdya1Z3ZFJoQWlyM2FjVW1wVXdIQzhIRUZz?=
 =?utf-8?B?UmpEN3R2bEdSQ3A1TUpONmxrZUJWZHhZNDNNNDhseHpYUXhONGxPd25wOURr?=
 =?utf-8?B?dlNWTmpDakc0MnlYTisxVkVFdkY0RzFmTzlvemtjaG42dFBCSU5tWk4vbm9Z?=
 =?utf-8?B?Tnh0M3NzWFQrL1FyY082Qk1RWFEvY0I3Uzc5ODR0THdrTTllSnFsS1YvSUd2?=
 =?utf-8?B?eW9Eemx4TUR2VldJQi9LR1k2bG5wLzYzcVI0dUtqVHJ3V2tuTHkxdGtCcTN3?=
 =?utf-8?B?bG1vM1RFb2tCRklDUm5RcGdaZk1vZ2w4SldYbGJoVG80dGZRbzd5T2Q3NTE1?=
 =?utf-8?B?M1NWUXNRR3pkL3J2a2lHR1p2d0hPM0lKQnhRT0FUb1QyNk5WSmJFdkpPeDZ2?=
 =?utf-8?B?ZXBKWmJGSjJQRmpobENQYy94OUR0UFpSOFEyZi8rY3RTVU15Skw0aUxWRG81?=
 =?utf-8?Q?NqEFWytsiW+JhqN2te9WvMtDnCKSgmcRXplibzZ?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2ced92c6-3738-4bbc-f8be-08d9923ac060
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2021 13:25:28.4314
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: t7xSbmri7S2gV842V5/74lHzVG1w8E4kQGBFJVd6QZFENgXos1q3jh2R2E3YBSrAxvWTNb5UNlmCaIRmH/VXUQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4383

On 15.10.2021 11:26, Julien Grall wrote:
> On 14/10/2021 15:10, Jan Beulich wrote:
>> On 14.10.2021 13:29, Julien Grall wrote:
>>> On 13/09/2021 07:42, Jan Beulich wrote:
>>>> Determining that behavior is correct (i.e. results in failure) for a
>>>> passed in GFN equaling INVALID_GFN is non-trivial. Make this quite a
>>>> bit more obvious by checking input in generic code - both for singular
>>>> requests to not match the value and for range ones to not pass / wrap
>>>> through it.
>>>>
>>>> For Arm similarly make more obvious that no wrapping of MFNs passed
>>>> for XENMAPSPACE_dev_mmio and thus to map_dev_mmio_region() can occur:
>>>> Drop the "nr" parameter of the function to avoid future callers
>>>> appearing which might not themselves check for wrapping. Otherwise
>>>> the respective ASSERT() in rangeset_contains_range() could trigger.
>>>>
>>>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>>>> ---
>>>> I find it odd that map_dev_mmio_region() returns success upon
>>>> iomem_access_permitted() indicating failure - is this really intended?
>>>
>>> AFAIR yes. The hypercall is not used as "Map the region" but instead
>>> "Make sure the region is mapped if the IOMEM region is accessible".
>>>
>>> It is necessary to return 0 because dom0 OS cannot distinguished between
>>> emulated and non-emulated. So we may report error when there is none.
>>
>> Odd, but I clearly don't understand all the aspects here.
>>
>>>> As per commit 102984bb1987 introducing it this also was added for ACPI
>>>> only - any reason XENMAPSPACE_dev_mmio isn't restricted to CONFIG_ACPI
>>>> builds?
>>>
>>> There is nothing specific to ACPI in the implementation. So I don't
>>> really see the reason to restrict to CONFIG_ACPI.
>>>
>>> However, it is still possible to boot using DT when Xen is built with
>>> CONFIG_ACPI. So if the restriction was desirable, then I think it should
>>> be using !acpi_disabled.
>>
>> My point was rather about this potentially being dead code in non-ACPI
>> builds (i.e. in particular uniformly on 32-bit).
> 
> The hypercall is already wired and a dom0 OS can use it today even on 
> non-ACPI. Whether a dom0 OS will use it is a different question. I know 
> that Linux will limit it to ACPI. It is likely not used by other OS, but 
> I can't guarantee it.
> 
> In this case, the hypercall is only a few lines and already restricted 
> to dom0 only (see xapt_permission_check()). So to me, the #ifdef here is 
> not worth it.

Well, okay then - I've removed that remark.

>>>> @@ -841,6 +844,15 @@ int xenmem_add_to_physmap(struct domain
>>>>        if ( xatp->size < start )
>>>>            return -EILSEQ;
>>>>    
>>>> +    if ( xatp->gpfn + xatp->size < xatp->gpfn ||
>>>> +         xatp->idx + xatp->size < xatp->idx )
>>>> +    {
>>>> +#define _gfn(x) (x)
>>>
>>> AFAICT, _gfn() will already be defined. So some compiler may complain
>>> because will be defined differently on debug build.
>>
>> No - _gfn() is an inline function as per typesafe.h. (Or else it
>> wouldn't be just "some" compiler, but gcc at least would have
>> complained to me.)
> 
> Ah. somehow I thought it was a macro. But looking at the implementation, 
> it makes sense to be an inline funciton.
> 
> Sorry for the noise.
> 
>>
>>> However...
>>>
>>>> +        BUILD_BUG_ON(INVALID_GFN + 1);
>>>
>>> ... I might be missing something... but why can't use gfn_x(INVALID_GFN)
>>> + 1 here?
>>
>> Because gfn_x() also is an inline function, and that's not suitable
>> for a compile-time constant expression.
> 
> Right. How about introduce INVALID_GFN_RAW in mm-frame.h? This could 
> also be used to replace the open-code value in INVALID_GFN and 
> INVALID_GFN_INITIALIZER?

Can do, but that'll be a prereq patch then also taking care of INVALID_MFN.

>>> In fact, I am not entirely sure what's the purpose of this
>>> BUILD_BUG_ON(). Could you give more details?
>>
>> The expression in the surrounding if() relies on INVALID_GFN being the
>> largest representable value, i.e. this ensures that INVALID_GFN doesn't
>> sit anywhere in [xatp->gpfn, xatp->gpfn + xatp->size).
> 
> Thanks the explanation. Can you add the rationale in a comment on top of 
> BUILD_BUG_ON()?

Sure, done.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Oct 18 13:26:56 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Oct 2021 13:26:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.212271.370081 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcSfG-0004Y5-EP; Mon, 18 Oct 2021 13:26:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 212271.370081; Mon, 18 Oct 2021 13:26:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcSfG-0004Xy-BM; Mon, 18 Oct 2021 13:26:54 +0000
Received: by outflank-mailman (input) for mailman id 212271;
 Mon, 18 Oct 2021 13:26:53 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mcSfE-0004Xm-Vs; Mon, 18 Oct 2021 13:26:52 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mcSfE-0005ly-Qn; Mon, 18 Oct 2021 13:26:52 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mcSfE-0002xN-CY; Mon, 18 Oct 2021 13:26:52 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mcSfE-0006Ht-C0; Mon, 18 Oct 2021 13:26:52 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=90IM20PovMfFo9xBo6PqGBlUAWShBT/M8MEeB5Tv3sU=; b=3dJwlXpUkDtuKFg7yN5Yw1lYT4
	XjwebX0/X1/v08i6l4oPdZxEdiqw2i5s4gts4NLwVR0L5Uy2+wb9VITiIaTUkcb5LaZBFkzSiD4i3
	fEtbLCYS8SzuFBskIPZtmlFyRM399CKTIt1db4Y9ZhCw9Q3wwcNuZB7YVGfWk5X6+dn0=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165632-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 165632: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-armhf-armhf-examine:reboot:fail:heisenbug
    linux-linus:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=cf52ad5ff16c38a62a6536b5e7612b56794f5a5e
X-Osstest-Versions-That:
    linux=d999ade1cc86cd2951d41c11ea769cb4452c8811
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 18 Oct 2021 13:26:52 +0000

flight 165632 linux-linus real [real]
flight 165634 linux-linus real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/165632/
http://logs.test-lab.xenproject.org/osstest/logs/165634/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-armhf-armhf-examine      8 reboot              fail pass in 165634-retest

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-rtds     20 guest-localmigrate/x10       fail  like 165584
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 165584
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 165584
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165584
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165584
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 165584
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165584
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 165584
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 165584
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 linux                cf52ad5ff16c38a62a6536b5e7612b56794f5a5e
baseline version:
 linux                d999ade1cc86cd2951d41c11ea769cb4452c8811

Last test of basis   165584  2021-10-17 02:20:12 Z    1 days
Testing same since   165632  2021-10-18 03:40:46 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Al Viro <viro@zeniv.linux.org.uk>
  Aleksander Morgado <aleksander@aleksander.es>
  Alexander Usyskin <alexander.usyskin@intel.com>
  Alexandru Tachici <alexandru.tachici@analog.com>
  Andy Shevchenko <andriy.shevchenko@linux.intel.com>
  Arnd Bergmann <arnd@arndb.de>
  Billy Tsai <billy_tsai@aspeedtech.com>
  Bjørn Mork <bjorn@mork.no>
  Christophe JAILLET <christophe.jaillet@wanadoo.fr>
  Colin Ian King <colin.king@canonical.com>
  Damien Le Moal <damien.lemoal@wdc.com>
  Dan Carpenter <dan.carpenter@oracle.com>
  Daniele Palmas <dnlplm@gmail.com>
  Dmitry Torokhov <dmitry.torokhov@gmail.com>
  Geert Uytterhoeven <geert+renesas@glider.be>
  Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  Hui Liu <hui.liu@mediatek.com>
  Ian Kent <raven@themaw.net>
  Jiri Valek - 2N <valek@2n.cz>
  Johan Hovold <johan@kernel.org>
  Jonathan Bell <jonathan@raspberrypi.com>
  Jonathan Bell <jonathan@raspberrypi.org>
  Jonathan Cameron <Jonathan.Cameron@huawei.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Mark Brown <broonie@kernel.org>
  Martyn Welch <martyn.welch@collabora.com>
  Mathias Nyman <mathias.nyman@linux.intel.com>
  Michael Cullen <michael@michaelcullen.name>
  Miquel Raynal <miquel.raynal@bootlin.com>
  Moritz Fischer <mdf@kernel.org>
  Nathan Chancellor <nathan@kernel.org>
  Nikolay Martynov <mar.kolya@gmail.com>
  Nuno Sá <nuno.sa@analog.com>
  Oded Gabbay <ogabbay@kernel.org>
  Oleksij Rempel <o.rempel@pengutronix.de>
  Pavankumar Kondeti <pkondeti@codeaurora.org>
  Rajaravi Krishna Katta <rkatta@habana.ai>
  Randy Dunlap <rdunlap@infradead.org>
  Saravana Kannan <saravanak@google.com>
  Sean Nyekjaer <sean@geanix.com>
  Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
  Stephen Boyd <swboyd@chromium.org>
  Tomas Winkler <tomas.winkler@intel.com>
  Tomaz Solc <tomaz.solc@tablix.org>
  Ulf Hansson <ulf.hansson@linaro.org>
  Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
  Wu Hao <hao.wu@intel.com>
  Xu Yilun <yilun.xu@intel.com>
  Yang Yingliang <yangyingliang@huawei.com>
  Yi Zhang <yi.zhang@redhat.com>
  Yu-Tung Chang <mtwget@gmail.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     fail    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     fail    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   d999ade1cc86..cf52ad5ff16c  cf52ad5ff16c38a62a6536b5e7612b56794f5a5e -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Mon Oct 18 13:27:19 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Oct 2021 13:27:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.212277.370095 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcSfe-00056s-SE; Mon, 18 Oct 2021 13:27:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 212277.370095; Mon, 18 Oct 2021 13:27:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcSfe-00056l-P6; Mon, 18 Oct 2021 13:27:18 +0000
Received: by outflank-mailman (input) for mailman id 212277;
 Mon, 18 Oct 2021 13:27:17 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=6zTk=PG=suse.com=jgross@srs-us1.protection.inumbo.net>)
 id 1mcSfc-0004zx-Vg
 for xen-devel@lists.xenproject.org; Mon, 18 Oct 2021 13:27:17 +0000
Received: from smtp-out1.suse.de (unknown [195.135.220.28])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 00a2aabf-2fdd-42ac-941c-58d1c2f9be6f;
 Mon, 18 Oct 2021 13:27:15 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 4739A21958;
 Mon, 18 Oct 2021 13:27:14 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1260314059;
 Mon, 18 Oct 2021 13:27:14 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id PzbJAjJ2bWGDXAAAMHmgww
 (envelope-from <jgross@suse.com>); Mon, 18 Oct 2021 13:27:14 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 00a2aabf-2fdd-42ac-941c-58d1c2f9be6f
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1634563634; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=6y1HL0tNLVB6bTTlF9XivWo4KKigNSCoipEwckZUBjg=;
	b=ftNqJTWDYK5c3xkbRSTgbV8wDCOtwX4Rcg/A72qVNnGVIQwahTa+/dexrapyLIEtK8kboY
	N70nj6PUKzKuq293cI8uMlEqO8LzrGXJFTlTulNwsd+lrkB/jXA/CSErJACqXnCyIhOwpJ
	medUDJNoDiKhzn4DCoMgZi3sxozGpkQ=
Subject: Re: [PATCH 04/12] xen/x86: modify hvm_memory_op() prototype
To: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>, Wei Liu
 <wl@xen.org>, xen-devel@lists.xenproject.org
References: <20211015125152.25198-1-jgross@suse.com>
 <20211015125152.25198-5-jgross@suse.com>
 <71fae3b2-9f90-878c-50f1-e9c0d7cf7e5c@suse.com>
From: Juergen Gross <jgross@suse.com>
Message-ID: <d5c5854f-6bd1-db12-b530-ffc628f473f7@suse.com>
Date: Mon, 18 Oct 2021 15:27:13 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <71fae3b2-9f90-878c-50f1-e9c0d7cf7e5c@suse.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="iIYlgAyLGauNgStIOXwqbyBNNZ4JYChNv"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--iIYlgAyLGauNgStIOXwqbyBNNZ4JYChNv
Content-Type: multipart/mixed; boundary="s7d4xFdzAzZaBDKm9vjN4aOOC8N7CrDQd";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>, Wei Liu
 <wl@xen.org>, xen-devel@lists.xenproject.org
Message-ID: <d5c5854f-6bd1-db12-b530-ffc628f473f7@suse.com>
Subject: Re: [PATCH 04/12] xen/x86: modify hvm_memory_op() prototype
References: <20211015125152.25198-1-jgross@suse.com>
 <20211015125152.25198-5-jgross@suse.com>
 <71fae3b2-9f90-878c-50f1-e9c0d7cf7e5c@suse.com>
In-Reply-To: <71fae3b2-9f90-878c-50f1-e9c0d7cf7e5c@suse.com>

--s7d4xFdzAzZaBDKm9vjN4aOOC8N7CrDQd
Content-Type: multipart/mixed;
 boundary="------------B87677EE8F426A41AE78453C"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------B87677EE8F426A41AE78453C
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 18.10.21 14:31, Jan Beulich wrote:
> On 15.10.2021 14:51, Juergen Gross wrote:
>> hvm_memory_op() should take an unsigned long as cmd, like
>> do_memory_op().
>>
>> As hvm_memory_op() is basically just calling do_memory_op() (or
>> compat_memory_op()) passing through the parameters the cmd parameter
>> should have no smaller size than that of the called functions.
>>
>> Signed-off-by: Juergen Gross <jgross@suse.com>
>=20
> Reviewed-by: Jan Beulich <jbeulich@suse.com>
>=20
> Nevertheless ...
>=20
>> --- a/xen/arch/x86/hvm/hypercall.c
>> +++ b/xen/arch/x86/hvm/hypercall.c
>> @@ -31,7 +31,7 @@
>>   #include <public/hvm/hvm_op.h>
>>   #include <public/hvm/params.h>
>>  =20
>> -static long hvm_memory_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
>> +static long hvm_memory_op(unsigned long cmd, XEN_GUEST_HANDLE_PARAM(v=
oid) arg)
>>   {
>>       long rc;
>=20
> ... I think this would even better be dealt with by splitting the
> function into a native one (using unsigned long) and a compat one
> (using unsigned int).

Why? In 32-bit case the value is naturally limited to 32 bits width
zero-extending perfectly fine to unsigned long.

Otherwise I couldn't use the same definition later.


Juergen

--------------B87677EE8F426A41AE78453C
Content-Type: application/pgp-keys;
 name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Transfer-Encoding: quoted-printable
Content-Description: OpenPGP public key
Content-Disposition: attachment;
 filename="OpenPGP_0xB0DE9DD628BF132F.asc"

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy=
cWx
w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O=
f8Z
d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y=
9bf
IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq=
G7/
377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR=
3Jv
c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA=
QIe
AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT=
hpw
dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0=
MbD
1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv=
oPH
Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v=
5QL
+qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ=
2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC=
QoL
BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr=
Wf0
teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC=
/nu
AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh=
ITT
d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm=
XBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz=
80h
SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC=
AcD
AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn=
FOX
gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1=
jnD
kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0=
N51
N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l=
otu
fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1=
tqS
EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA=
hsD
BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3=
g3O
ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5=
dM7
wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5=
D+j
LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm=
V2x
AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N=
Eaw
QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW=
nHI
s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR=
wgn
BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV=
bVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk=
pEd
IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA=
QAB
wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw=
Tbe
8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1=
vJz
Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8=
VGi
wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW=
svi
uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX=
zXs
ZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------B87677EE8F426A41AE78453C--

--s7d4xFdzAzZaBDKm9vjN4aOOC8N7CrDQd--

--iIYlgAyLGauNgStIOXwqbyBNNZ4JYChNv
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmFtdjEFAwAAAAAACgkQsN6d1ii/Ey8n
PAf/R06fShcGSrzoTAZN/2dtBQmG5nd3o7SGTjvCJA26jXesz6cP/STaLNOvX4WDd+juuPHbgQYw
sMSLTkaUVs6VEaUVf9NsoiTM3I6NriZczdY0Myzg6L+6NRUB6tocdScHlwUkWCi0cc4pNYrH8RsA
Um4MfRjs33i9KySte9TA62GJE1ekFzv7O/ZBNOa8X4CuTjba/t28YAhKu5NLaBwsFCMFTDuKnj0s
DI0kDzjlivJpJQhLO/UW7at2u9KVJNGjSyh8ctNlWqE/tUQb90ROQroeI5YwltQat3msxyvsrqvL
u52t4QAMmsaJxlJjegg04TtfspfKCASf/dTdnkv9BQ==
=zyly
-----END PGP SIGNATURE-----

--iIYlgAyLGauNgStIOXwqbyBNNZ4JYChNv--


From xen-devel-bounces@lists.xenproject.org Mon Oct 18 13:28:30 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Oct 2021 13:28:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.212288.370105 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcSgo-0005t4-6I; Mon, 18 Oct 2021 13:28:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 212288.370105; Mon, 18 Oct 2021 13:28:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcSgo-0005sx-3H; Mon, 18 Oct 2021 13:28:30 +0000
Received: by outflank-mailman (input) for mailman id 212288;
 Mon, 18 Oct 2021 13:28:29 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mcSgm-0005sp-VU
 for xen-devel@lists.xenproject.org; Mon, 18 Oct 2021 13:28:28 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mcSgm-0005oM-UQ
 for xen-devel@lists.xenproject.org; Mon, 18 Oct 2021 13:28:28 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mcSgm-0005f6-TM
 for xen-devel@lists.xenproject.org; Mon, 18 Oct 2021 13:28:28 +0000
Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89)
 (envelope-from <iwj@xenproject.org>)
 id 1mcSgj-0005y7-DJ; Mon, 18 Oct 2021 14:28:25 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:To:Date:
	Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From;
	bh=QDSsGB2ZzXBnBQwu3bnaniFd7ileFmPeuhH7RFjCycM=; b=JrdtvK+CNm4O2ZxBffK08ILk3U
	IfpLcVVtFYoBGw7kNW2gyWAH+TVVBBR/Q9dPdM10oEykc4C180AWo1kCQyMqzc1tD2PBf9iCfuOXu
	iu6jsXePTmNNYA4ebK9CHSyUMeuFelfNjtMOi8qDwfMPcFaMkKqJnd5mWkxah1HeZwuI=;
From: Ian Jackson <iwj@xenproject.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <24941.30329.51635.566269@mariner.uk.xensource.com>
Date: Mon, 18 Oct 2021 14:28:25 +0100
To: Juergen Gross <jgross@suse.com>,
    xen-devel@lists.xenproject.org,
    Andrew Cooper <andrew.cooper3@citrix.com>,
    George Dunlap <george.dunlap@citrix.com>,
    Jan Beulich <jbeulich@suse.com>,
    Julien Grall <julien@xen.org>,
    Stefano Stabellini <sstabellini@kernel.org>,
    Wei Liu <wl@xen.org>,
    Samuel Thibault <samuel.thibault@ens-lyon.org>,
    Community Manager <community.manager@xenproject.org>
Subject: Re: [PATCH v3 0/3] disable building of pv-grub and qemu-trad per
 default
In-Reply-To: <24913.55427.402592.660538@mariner.uk.xensource.com>
References: <20210910055518.562-1-jgross@suse.com>
	<24891.31480.165445.521062@mariner.uk.xensource.com>
	<d894799e-27c6-bbbd-8d65-3e32c1aff843@suse.com>
	<24913.55427.402592.660538@mariner.uk.xensource.com>
X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu)

I wrote (27th September):
> Juergen Gross writes ("Re: [PATCH v3 0/3] disable building of pv-grub and qemu-trad per default"):
> > On 10.09.21 17:34, Ian Jackson wrote:
> > > Juergen Gross writes ("[PATCH v3 0/3] disable building of pv-grub and qemu-trad per default"):
> > >> This is a first step of deprecating pv-grub and qemu-trad including
> > >> ioemu-stubdom. Switch the default to not building it.
> > > 
> > > This is now fully acked.  But can we wait with committing it until we
> > > have a decision about whether to (a) have osstest explicitly enable
> > > the pv-grub and qemu-trad builds (b) have osstest stop testing these
> > > configurations ?
> > 
> > Any decisions made?
> 
> No-one seems to have had any opinions.   I'll take ...
> 
> > FWIW I'd be fine dropping pv-grub builds and tests in OSStets, but I'd
> > rather keep testing qemu-trad stubdom tests.
> 
> ... that as a proposal :-).  think that is probably the right tradeoff.
> 
> I think that means that means we need osstest patches to edit
> make-flight and ts-xen-build which
> 
>  * Explictly enables stubdom qemu build
>  * Drops the pv-grub tests
> 
> and those need to go in first.
> 
> With my RM hat on, I think those changes to osstest may need a release
> ack since they have missed the LPD, but I will grant such an ack.
> 
> As for the patches themselves, I may get to that tomorrow, but
> contributions would be very welcome.

Evidently I didn't get to that "tomorrow".  But while checking up on
this with git-log -G I found osstest commit:

  8dee6e333622d830b7a9373989f63b526a85cd94
  make-flight: Drop pvgrub (pvgrub1) tests

I think this means
  [PATCH v3 2/3] stubdom: disable building pv-grub
from this series can go in immediately.

With my RM hat on: I think this reduces risk, overall.  There is some
risk of immediately build breakage but the patch could be readily
reverted.

Accordingly, patch 2/3 disabling pv-grub is
  Release-Acked-by: Ian Jackson <iwj@xenproject.org>

It also has my tools ack so I will commit it in a moment.

I think 3/3 is waiting for the osstest patch.  In principle with my RM
hat on I think these could go in but it would have to be very soon,
and the osstest change has to go in first.

Ian.


From xen-devel-bounces@lists.xenproject.org Mon Oct 18 13:29:38 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Oct 2021 13:29:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.212294.370117 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcShq-0006Up-HF; Mon, 18 Oct 2021 13:29:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 212294.370117; Mon, 18 Oct 2021 13:29:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcShq-0006Ui-Cm; Mon, 18 Oct 2021 13:29:34 +0000
Received: by outflank-mailman (input) for mailman id 212294;
 Mon, 18 Oct 2021 13:29:33 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=RJnW=PG=citrix.com=Andrew.Cooper3@srs-us1.protection.inumbo.net>)
 id 1mcShp-0006Ub-0X
 for xen-devel@lists.xenproject.org; Mon, 18 Oct 2021 13:29:33 +0000
Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 6d170604-3017-11ec-82d7-12813bfff9fa;
 Mon, 18 Oct 2021 13:29:32 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6d170604-3017-11ec-82d7-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1634563771;
  h=to:cc:references:from:subject:message-id:date:
   in-reply-to:content-transfer-encoding:mime-version;
  bh=Ece8lD7yKfqI9OUWub6J+dTkRoS1NKzNSvdQ8ZiE+Gg=;
  b=HTDgI78wbosTX8wGyFkOqAtx2o/pSz2SCzfxG8Gw2kRgv4N7xCsa1Ogc
   ZDIohmb8mdXmvSeKkjlfC6fJxefeAV1LX7BzVi3HzfY/K1V5c+Hxj/EFZ
   nfJat+odezJTChYlUlOm+rVF3RK7kseNi30f1B4D8F7E7pcwFZNly/L7Q
   k=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: PZY0ckOnrNcz1QDsUS3MKkKsKkoMJwFj/j73EJiQrN0GD7rjzzdmilvn5quXuzkQVrqvTTkngW
 +GXWQ1iuX4y6O2jm7Rrw3bfiVVbFF9Cc7Zo0wVXj3+TpULUNEO4WFqMuVZdd/iB4mN5cR3ko+j
 t5qzZfQws+91gLpnx3fBVx8g+b6CUFPcBzD+kofv53WVOaSRODYyoeX6JZ3W3/2wTnUBe/POil
 sRHMYEhNvgo+SQ89lcFMq/84D92i8Rn/4We0fsxGjMp9+myn3hUivtpK1SAMbujGuUf9aJtqRO
 4czWqNVhytErJ/c6YPjgnzKW
X-SBRS: 5.1
X-MesageID: 55422363
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:t/iMlakcAhkj5Wq5QMp+d1fo5gxgIURdPkR7XQ2eYbSJt1+Wr1Gzt
 xIZDG7Ta/rba2GkKoh1YNnkoExX7ZLTxtEwHgM4+y1hFyMWpZLJC+rCIxarNUt+DCFioGGLT
 Sk6QoOdRCzhZiaE/n9BClVlxJVF/fngqoDUUYYoAQgsA185IMsdoUg7wbdg2tc42YLR7z6l4
 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc
 s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4
 M5Bm4G1FBcVBYDdt8Q2WDlYTjtTYKITrdcrIVDn2SCS50jPcn+qyPRyFkAme4Yf/46bA0kXq
 6ZecmpUKEne2aTmm9pXScE17ignBODtMJkSpTdLyjbBAOx9aZvCX7/L9ZlT2zJYasVmQKuCP
 ZBCN2EHgBLoOyB3FA8NA64HnqSTqSP1dBd6pk2+jP9ii4TU5FMoi+W8WDbPQfSLWsd9jkuev
 njB/WnyHlcdLtP34SWB2mKhgKnIhyyTcJIfEvi0++BnhHWXx3cPE1sGWF2ju/67h0WiHdVFJ
 CQpFjEG9PZoshbxF5+kAkP+8CXsUgMgt8R4COEU9QTQ2pbvzhe2JkMPbj4ccvF7u5pjLdA17
 WOhk9TsDD1plbSaT3OB67uZxQ+P1TgpwXwqPnBcE1NUizX3iMRq1EiXF4c8eEKgpoStQWmY/
 tyckMQpa1z/Z+Yw3KKn4UuPvTuoopXYJuLezlSKBjz7hu+ViYjMWmBJ1bQ5xasYRGp6ZgPY1
 JThpyR4xLpfZX1qvHfVKNjh5Jnzu5643MT02DaD5aUJ+TW34GKEdotN+jx4L0oBGp9aImO1M
 RKC418Nvs470J6WgUlfOdPZ5yMClvCIKDgYfqqMMoomjmZZJWdrAx2ClWbPhjuwwSDAYIk0O
 IuBcNbEMJrpIf8P8dZCfM9EieVD7nlnnQv7HMmnpzz6gev2TCPEEt8tbQrRBt3VGYvZ+W05B
 f4EbJDUo/ieOcWjChTqHXk7dgxTciVnWMmr8qS6tIere2JbJY3oMNeIqZsJcI15haVF0ODO+
 3C2QEhDz1Tjw3bALG23hrpLNNsDhL5z8iA2OzICJ1Gt1yRxaIqj9v5HJZA2YaMm5KpoyvstF
 6sJfMCJA/JuTDXb+mtCMcmh/dI6LBn71xiTOyeFYSQke8IyTQL+5dK5LBDk8zMDD3TruJJm8
 aGgzA7SXbEKWx9mUJTNcPuqwl7o5Sodlet+UlHmON5WfEmwooFmJzao1q08It0WKAWFzTyfj
 l7EDRAdrOjLgok07NiW2vzU89b3S7NzRxMIEXPa4LC6MTjh0lCimYIQAvyVeT39VX/v/Pnwb
 +ti0PyhYuYMm0xHstQgHu8zn74+/dbmu5RT0h9gQCfQd12uB75tfiuG0M1IuvEfz7NVo1LrC
 EeG+90cMrSVIsL1VlUWIVN9POiE0PgVnBjU7Og0fxqmtHMmouLfXBUAJQSIhQxcMKBxYdEsz
 uoWscIL7xCy10gxOdGcgyEIr2mBIxTsiUn8Wk321GMztjcW9w==
IronPort-HdrOrdr: A9a23:M2vhR6g8Dp0mLwODRT61FdYroHBQX0113DAbv31ZSRFFG/FwyP
 rAoB1L73PJYWgqNU3I+ergBEGBKUmskKKdkrNhQotKOzOWxFdATbsSkLcKpgePJ8SQzJ8k6U
 4NSdkYNDS0NykBsS+Y2njJLz9D+qj/zEnAv463pB0MPGIaGJ2IrT0JbjpzencGNTWubqBJcq
 Z0iPA3xQZINU5nFfhSURI+Lpb+TpDw5d7bSC9DIyRixBiFjDuu5rK/Ox+E3i0GWzcK5bs562
 DKnyHw+63m6piAu1Hh/l6Wy64TtMrqy9NFCsDJos8JKg/0ggLtQIh6QbWNsB08venqwlc3l9
 vnpQsmIq1ImjzsV1DwhSGo9xjr0T4o5XOn4ViEgUH7qci8fz4+A9opv/MTTjLpr24b+P1s2q
 NC2GyU87BNCwnboSj779/UEzl3i0uduxMZ4K0upk0adbFbRK5arIQZ8k8QOowHBjjG5IcuF/
 QrJN3A5cxRbUiRYxnizylSKeSXLzEO9yq9Mww/UpT/6UkQoJk59TpY+CUnpAZDyHpnIKM0od
 gtMcxT5flzp4EtHPtA7Epoe7rBNoX3e2O4DIulGyWvKEg2AQO+l3fJ2sRA2AiLQu1D8HJgou
 WNbLtn3VRCDX4GT/f+hKF2zg==
X-IronPort-AV: E=Sophos;i="5.85,382,1624334400"; 
   d="scan'208";a="55422363"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=gp/pqutOdCJl/jfw+EBPWQcB4r5tqvAVuGj1uDJ7eC2npNulDhawHQg977XMMpYjx6GyJApdQxSDWDB0o20RrHYITnWMfWBJ3Ra+/fkm0UHXqZq2QV489yKgGYy7eS9tVzWEMauhlNWBnirbVWf0n8BqBtU0TQlL+/L0WLiFU1ioN+Z/fUVVC3oXJqE6fY1PA2FELlT9MHSVV/YSEfjqtSJhMcgRv+VoCiB1+Gumf2aRsBqJEBNBWHrwYQxLtLnZpgH1rykdgkqKL2SCDIBQhCSML08HwR7RTPS0mWPoVKcSonMKZ7krkcAMZwp45iLB09n0TzPvXxDuKGtm3byrmw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Ece8lD7yKfqI9OUWub6J+dTkRoS1NKzNSvdQ8ZiE+Gg=;
 b=J59/YsSwnRUcZH/VFZ4w3xj8O4jc/5WsTWnVWVqPHrb71PoddeGBCa1CvTSNCq8KDncY7EoUOcZUf707HD9vMmIIueJrUArI6xwKE1pgZHAZc8N48wKetgBqOdBLWsFFeDAkRIZWkYIp0bu+VoEpDYATZnQla6xNWbzRQ4QA36SQIl7VB6Yl0VeQRG4pkkUDxVu1Kw3rfZuq/yHXt+7K+4GZ4kAJK95iGX/BDVm5aZ9qAI6Eisa8/AObT99p88yOyfCMpUtzxVoHzjDRMtZ3UTg6DsX5r4Xd5Aq/H95XwnincAGrbQ3dWe+dXaLXVLpkks3Bn8MjwyWu3cC6rp9JFA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Ece8lD7yKfqI9OUWub6J+dTkRoS1NKzNSvdQ8ZiE+Gg=;
 b=v0bjXBRYGx6WCFvlaaX+ps4WtC8+vS8BYkjG+srRaMRH0VW+eEK8e7LuoGcp6hHDw6T5FPW59j361ZoVcSfSU1Z3NrmmVXO+GVgNb5so0+ee3DIyq/lIW3EImBInOlor+uNvLoxrwHeSHWH5fr/c3clhVv4FEVNfTppXklBsXgM=
To: Ian Jackson <iwj@xenproject.org>
CC: Wei Liu <wl@xen.org>, Xen-devel <xen-devel@lists.xenproject.org>, Jane
 Malalane <jane.malalane@citrix.com>
References: <20211018100848.10612-1-jane.malalane@citrix.com>
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH for-4.16] tests/resource: Extend to check that the grant
 frames are mapped correctly
Message-ID: <f25e1fdb-90fb-7273-243d-e197eb9e2f92@citrix.com>
Date: Mon, 18 Oct 2021 14:28:53 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <20211018100848.10612-1-jane.malalane@citrix.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Content-Language: en-GB
X-ClientProxiedBy: LO4P123CA0063.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:153::14) To BYAPR03MB3623.namprd03.prod.outlook.com
 (2603:10b6:a02:aa::12)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 3a1b73b6-5d8c-4b6b-72da-08d9923b3e60
X-MS-TrafficTypeDiagnostic: BY5PR03MB5046:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <BY5PR03MB50460A5CC4987054F1BD46D0BABC9@BY5PR03MB5046.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8273;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: KjnjVVi6MpxvCL/AKPwxyj9l8LixojsN/yPgtaKHcobZCcGX/JNcSSN+IylVdM2eou7qBcc6DcF4kXGuOWP0UILLUT54iGZaGKzUtz2qCorWGgSyYg+NDp4Kau6EE6Sh8kCl3Yjb5c1zjmI1U5/004Ns0eLhlmvjG7cqxg0p2B6kL64n2bGA/Jz7L7I7soJ58395n4gNryRsTwiQA7ilVfF72xTO1X2BKgtHyPLKJzdhsLcNOssO+u4Pb1/twrMzwGQiJ3RdIv54vKmkDITanQOdZpfzQqyoKz1xPINPw/mpwQoPTEsLJm99HdctQMhO2c5mi5neY2A7kKU/WKwQY4MnxKsIWp7RoKTGBSAUMiZrZxVn1Y2Ay+H168JHUEyW7yiYPDfVJc8K6fnDtgios5ptvqNXbWVocI7MsmEC78H4Bc/yJNUxpM0+gDGCW0ayEhc+krFoFWikUaujoUYF/lRHOeeF5WEb0nou5kQWgekoZ0gh4nTG/MOn9hxJowlYzW9KSPls3q1SNLvsl0jh/95wgOL+RlIPpIHrWf2kOEVjaIdGKD0Rd7kfy1d6ucMa0Rby1cppgqFMeU7Da6BOM6aqi/4CqmNixxpORI75BYTsaJlA5SsF4iNMgPZI/2FjfKK2ENo3CvcZtOu903NulSulnqrDZU+slHspTefLeme+X1PVrAiYkdPojlMk6Ou0wTVLUraowYNzt8A5CR8Dl5X51B7iUfoCCMAQAHIQp00=
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(8936002)(26005)(316002)(66946007)(4744005)(6486002)(16576012)(2616005)(5660300002)(54906003)(956004)(31686004)(107886003)(31696002)(36756003)(8676002)(82960400001)(66556008)(66476007)(53546011)(508600001)(4326008)(6916009)(2906002)(83380400001)(86362001)(186003)(38100700002)(6666004)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UE16NnNkNlRnV1luQzZiWlVXRENDSFNEMWhhUDNIN2VvWEJwbEV5bDh3U1c5?=
 =?utf-8?B?Y1FWVzgyZEN2RUM2TW13WER4bWdvMEhTR25YeFdOS2F1UzZkWElVT2RvZWhS?=
 =?utf-8?B?NGtuWTd2dWUxQXNXS05WV2VqMVJUcVBkWlQ5L1FnTGhHWmJzSWJ6K1lUQmV3?=
 =?utf-8?B?M2hOT1NmRUZiQktqemQ0QjJldDV6WjVWVEpNSDlDanc4OGRWMGdrOGp4L0s4?=
 =?utf-8?B?WjJlUXdFQmp5Y3RTRlZBWlhlWmhSYU1OZ1p0V1NHbDgrc0hsdXdlTHFIWWlS?=
 =?utf-8?B?UkQ0eFhYQVM3N0dzSStuNGV2eFJzWXR6LzRGbE5DRUYwNTA1WU5tbFMrTHdk?=
 =?utf-8?B?QmpVUVl1cytMcGVaNTJTUGlWeVJoSXgxbjFucnF4bEtvOGVDRSt3Q3kvby9X?=
 =?utf-8?B?YnJqZE5GM1BtK0VLVDFJYU5iYUFEMHRDRW42RlJkYTR5TDYwN2JXWTQ1WW55?=
 =?utf-8?B?TFhJUVhYZkFXODVqbndZYzN5Y0ozME5JMmlGSk5Fb1B3dEtiek0wM3I4OUZF?=
 =?utf-8?B?TWwwci9VNDd5ZVZsZm1kREFFTGQxTzdzdkNrKzQvaTVTTEVxalpnZE9VRk9Z?=
 =?utf-8?B?TDIwUDZQckJYdTQ2S2I2N2JuRFpQR0gxL3hFNURWSFA1ZWYwREIxbEl5MXBF?=
 =?utf-8?B?TDF1aUY2RDQ5NC8yQzRDNDlCdTlQTnBZZHFGL05SWUdoRWJWTFBBREpoTVoz?=
 =?utf-8?B?eC9DUW8zYjZRYlRoZ05Fd3Z1YitNeXlCNHVsQVdyYlhKK2xla3J5cHVmZ0Fs?=
 =?utf-8?B?c1o0Z0pZYnNXVS9hcWY0RjN3VWpSV0srQkZJblMxM3JvMWxlRmVWQmttcmNl?=
 =?utf-8?B?L2VZSmk1ZTYxTXJEY2pIVXBrRlR3Z2FZMC9wUUs1RTdIUXBoaTZDZWhLVFJo?=
 =?utf-8?B?WE56THQ2TytRamJHdmJNVGtqZ0tqVUNHQ24zbWNKQkFaNkJSU2FXaUxTay9i?=
 =?utf-8?B?RDFSUmJOZUZkNktVV2dOZzYrM1lPQ0FTTWVtV0xUbjN6Y3U3RGllelQ0WEpT?=
 =?utf-8?B?cUFQSW0yMVJvU1UvYlVKVms0REVVUDlvYVBzcW1YUGE2UEpHNEpVM1lEYmtD?=
 =?utf-8?B?UHNKUE40cS8rSmgrNVJZRjJzQUYrRG5xNktHdWRMTFZ0MmM1S2MrWEFNTXRH?=
 =?utf-8?B?eGIxeTczV01UQ3BUWFZFWUl1b0JaTi9TM1hwQzErcWxNQm9yZWZKZEM0L3U1?=
 =?utf-8?B?S0JvbXRtbCsxdWQwbGxKa1MvRWU5eCt6ZUhVTGVmM05VVi8zZy9CRjF4SmxJ?=
 =?utf-8?B?Sk1ONit1QU1tR3V6c0JNRTBGUUNhUitsL3lnQk11UXBJbEQxeVJwNWlRMkY0?=
 =?utf-8?B?cTU0UkR3ejdwOTV2Wnh1NFJ4U3RtaTFFb2Y3YUtBVzVBV0I2d1RmNlRNQ0J0?=
 =?utf-8?B?UFVHMU1hZ2R1L1FJa0ZRR3ZmQ1FPV2owZXlHQ3dWeEdNcE9zY21HM0ZhSTlo?=
 =?utf-8?B?TkVkMWJpRUtLbHd3TmRhSXp4RGJHeUhyNW9PTFRlUll4YmZISEJ0QUN4RThi?=
 =?utf-8?B?ZmdZMUQ4TVAxVE4wZEFzdlQzRTJGRjBnSGFxeXQra0F5ZVBRMXF0Wm5JNWpH?=
 =?utf-8?B?aVY3L1BvcTRVTzhSWGpDNlBIMDhWWXRGQ2ljRW1oVmRXSnFVSWpvQlJWK1Nq?=
 =?utf-8?B?R1hzV3BJOFQyYlJBaHZIU1lPYVlUN1ovTURBVlFqRWdYODFZSUxEbWdmL3FW?=
 =?utf-8?B?MHdIMjhjbmF1STR3emFMYjhMOUo4dzBDS0xtRUVvUUFkR0J5S0RtMmxxbWxM?=
 =?utf-8?Q?hpcA22MlsxqS7hcxbknBoo6u29zsFMF1Mz3MJNy?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 3a1b73b6-5d8c-4b6b-72da-08d9923b3e60
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2021 13:28:59.8349
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: GnClVom18x1xGfXQ3jDuGK6MZ8pqMQqzMyUUQlfRhmaQ+NFLeS8N8euePirctDqMTtl8HtIv/3Jtg0pWwgxUWA+kP7D9/KIIZjMYJGB0040=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR03MB5046
X-OriginatorOrg: citrix.com

On 18/10/2021 11:08, Jane Malalane wrote:
> Previously, we checked that we could map 40 pages with nothing
> complaining. Now we're adding extra logic to check that those 40
> frames are "correct".
>
> Suggested-by: Andrew Cooper <andrew.cooper3@citrix.com>
> Signed-off-by: Jane Malalane <jane.malalane@citrix.com>

Ian:=C2=A0 I'd like this to be considered for 4.16.=C2=A0 It is extending a=
n
existing test case with better error detection.

It was a task I didn't get around to at the time, because of the 4.15
release freeze...=C2=A0 How time flies.

Anyway, it is very low risk to the release, and 0 risk for anyone who
doesn't run the tests...

~Andrew



From xen-devel-bounces@lists.xenproject.org Mon Oct 18 13:47:09 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Oct 2021 13:47:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.212309.370139 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcSyj-0000ZF-6M; Mon, 18 Oct 2021 13:47:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 212309.370139; Mon, 18 Oct 2021 13:47:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcSyj-0000Z8-3T; Mon, 18 Oct 2021 13:47:01 +0000
Received: by outflank-mailman (input) for mailman id 212309;
 Mon, 18 Oct 2021 13:47:00 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=3tpC=PG=citrix.com=roger.pau@srs-us1.protection.inumbo.net>)
 id 1mcSyi-0000Z2-An
 for xen-devel@lists.xenproject.org; Mon, 18 Oct 2021 13:47:00 +0000
Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id dd20be71-3019-11ec-82d7-12813bfff9fa;
 Mon, 18 Oct 2021 13:46:59 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: dd20be71-3019-11ec-82d7-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1634564819;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=9FPI6tqe0nO6M5yueo5xv7PAAE7It6ntZ2uEUqNTy94=;
  b=RPfvhEWuUERviWhlcPQef6rlnTS6sH2UJ/OTbO8QoQ3bje9uCtPJdMVz
   Kbmt8aWMCftQzohwMlXzcyMIgW/z7Z8CoU7bXnPafgH3+utNBaYBiLg1r
   HXOk16tHn6ERPLdm3ZdBbDKaBvevdbwPQKNMQYBE4tcIqkoFcPwlgCR4R
   Q=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: HgTPruBcWSkqA4o1ezVYNJNPUjaYaxGE3VuL/szeL3gCfG5PEyUkesteQa0CPLlxpceUUMBkze
 bkAsGlbZWTtw9wj5dEM8JMTdCqWKx5pLwkLTRQVrmEVz53eFyAudxYz/txm34bLtMQ8zF9eivy
 HJ0a0fPB9biLd8xYY0Wi7WWECUCr4rFPZZJCXUyiKWQClMRVsBxoCm5gyo6T4Mu6NtAl5isv+e
 WnUAkWisNT7c4Tnk9DBqfNkSUb0mcRUfPdTgM2wEfH00nXkqeEpzCEGkADROJoWftXHrPTPist
 GHvBoDhOabO4r4Z0IucXXBgg
X-SBRS: 5.1
X-MesageID: 55835775
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:xbJQgaOdNLWhTpfvrR1+kMFynXyQoLVcMsEvi/4bfWQNrUpx1zABy
 mVMXWuPO6qCZ2L3eox0YY+0/R8PuZXdnNFkHQto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdpJYz/uUGuCJQUNUjMlkfZKhTr6ZUsxNbVU8En540Uszw7RRbrNA2rBVPSvc4
 bsenOWHULOV82Yc3rU8sv/rRLtH5ZweiRtA1rAMTakjUGz2zhH5OKk3N6CpR0YUd6EPdgKMq
 0Qv+5nilo/R109F5tpICd8XeGVSKlLZFVDmZna7x8FOK/WNz8A/+v9TCRYSVatYoxzRotx/0
 oxHibixRCV4Z6rywt4MfDANRkmSPYUekFPGCX22sMjVxEzaaXr8hf5pCSnaP6VBpLwxWzsXs
 6VFdnZdNXhvhMrvqF6/YvNrick5atHiIasUu216zCGfBvEjKXzGa/iXtYQFg2ht7ixINcyBQ
 8kybzpxVTqeZSdPJFNUS84nk+j90xETdBUH8QnI9MLb+VP70whZwLXrdt3PdbSiVchT20qVu
 G/C12D4GQ0BcsySzyKf9XChjfOJmjn0MKoQHrCl8v9hgHWI23ceThYRUDOGTeKR0xDkHYgFc
 gpNp3Ro/fNaGFGXosfVdkWFrHCe5xQgf9tdMbxj7z/X8Lv7ylPMboQbdQJpZNsjvc4wYDUl0
 F6Vgt/kbQBSXK2ppWG1rejM82vjUcQBBSpbP3VcFFpaizX2iNhr1kqnczp1LEKiYjQZ8xnLy
 DeWsDN2ubwXicMav0lQ1QGa22zyznQlowhc2+k2Yo5Hxl4hDGJGT9bxgbQ+0RqmBNzIJrVml
 CNc8/VyFMhUUfmweNWlGY3h5o2B6fefKyH7ilVyBZQn/DnF0yf9JtwMsWwvfhs1aJdsldrVj
 Kn741I5CHh7ZyPCUEOKS9jpV5RCIVbIRLwJqcw4nvIRO8MsJWdrDQllZFKK3nCFraTfufpXB
 HtvSu71VSxyIf0+lFKeHr5BuZd2lnFW7T6CHvjTkkX4uYdykVbIEN/pxnPVNbtnhE5FyS2Im
 +ti2zyikEkGD7CiP3CKqOb+7zkidBAGOHw/kOQOHsarKQt6AmAxTfjXxLIqYYt+mKpJ0OzP+
 xmAtoVwlDITXFXLdleHbG5NcrTqUcotpH43J3V0b12px2IiccCk66JGL8k7erwu9epCy/9oT
 qZaJ5XcU6oXEjmXqS4AaZTdrZB5cEj5jwy5ICf4MiM0eIRtRlKV94a8LBfv7iQHEgG+qdA6/
 ++7zgreTJdaH1ZiAc/aZeiB1VS0uXRByut+U1GReotYeVn28ZgsICv016dlL8YJIBTF5z2by
 wfJXktI+biT+9c4qYCbi7qFooGlF/pFMnBbR2SLv6yrMST6/3a4xdMSWui/Yj2ABnj//7+vZ
 LsJwqikYuEHhltDr6F1D61vkfAl/9LqqrJXklZkEXHMYwj5A79sOCDbj8xGt6kLzb5FowqmH
 EmI/4ACa7mOPcrkFn8XJRYkMbvfha1FxGGK4KRnOlj+6Q924KGDABdbMBS7gSBAKKd4bdE+y
 uA7tc9KswGyh3LG6DpdYvy4I4hUEkE9bg==
IronPort-HdrOrdr: A9a23:e8i9xqNph4piJMBcT1L155DYdb4zR+YMi2TDiHoedfUFSKOlfp
 6V8MjztSWVtN4QMEtQ/+xoHJPwPE80kqQFnbX5XI3SJjUO3VHIEGgM1/qG/9SNIVybygcZ79
 YeT0EcMqyBMbEZt7eD3ODQKb9Jq7PrgcPY55as854ud3AQV0gJ1XYJNu/xKDwOeOApP+tfKH
 LKjfA32QZINE5nIviTNz0gZazuttfLnJXpbVovAAMm0hCHiXeN5KThGxaV8x8CW3cXqI1Sv1
 Ttokjc3OGOovu7whjT2yv66IlXosLozp9mCNaXgsYYBz3wgkKDZZhnWZeFoDcpydvfp2oCoZ
 3pmVMNLs5z43TeciWcpgbs4RDp1HIU53rr2Taj8DDeiP28YAh/J9tKhIpffBecwVEnpstA3K
 VC2H/cn4ZLDDvb9R6NpOTgZlVPrA6ZsHAimekcgzh0So0FcoJcqoQZ4Qd8DIoAJiTn84oqed
 MeTP003MwmNG9yUkqp+lWGmLeXLzMO91a9Mwk/U/WuonprdCsT9Tpf+CQd9k1wvK7VBaM0vt
 gtn8xT5cZzp/QtHNdA7dE6MIKK41z2MGDx2V2pUCDa/YE8SjjwQs3MkfgIDN/DQu1/8HJ1ou
 WYbG9l
X-IronPort-AV: E=Sophos;i="5.85,382,1624334400"; 
   d="scan'208";a="55835775"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=gWrYqM7RdU7q3Ftbt0/2E2XX5mPbEgdCNb9jbLxg8rIFOV3MenfOk8l91CwsOoCXo1cTfsK36PpXFUfWFI8o1+QiVhsmarkhpGrPwF/Mdzljy6uVIP/IbMHrZBKf9k3PWMok/uviHeduVA7JJ9E5VBPPybgPECAs4qTDkZ+SdlbEVWoQc8zY9xvfPPziUPV8lrZ0BRyJ2zFOXDcHNI24jZ+q2oGM7mcaihRLCDzp1HAz0v06CbNbXImd19y82DHEw+o1YMGv/5Qcg6ZKAqhUhWbE79Dqql+iH7rDWZOqagsCgCeeVrfSd/0fgiHVREsjKM/viDo2iKmNOl0U/dMIgw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=65CP0iUPtqia21TkFqKG7ZpQXC5syU2d8xVafPqoddg=;
 b=EahfrzCbOzj1vdEv5Lu+V4rreHly9xruxyqTO1tPALWIIyc94K25IGiCSN4WxBVjBpkZ5pBafSB2Pm99/pdMXyxU02Vqv7/H/bBwuyBj6yf+fO1kUEsUyq3+0lHdW9H4B54RBa+wn5ZQU9EAjpAOE7M/JzZr2AURZmd2iIY2Q3TgQmC9MjM6l+qD3LuA9OG/7n0HFsZ5iCYQmqP9S3LcFFgeIooTIxKrzzCDgkv+XQjn9cyjdhp0Kt4BPWyFMMcNq/+AFkZa29ySmhiw9nrgr5wJwZ8qi3kVp5eur1EUqxWvhLuLWvU2AS4SdNq00SfNMqAUuWAE5IpyFm7ABizyqg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=65CP0iUPtqia21TkFqKG7ZpQXC5syU2d8xVafPqoddg=;
 b=tilhcXq/cQft98pqDeOpQJMIfOF6JREmV5xb767sKzdNJGTIlruFRPzeNRGUhbVbPPbXOxuGaBYUprM/Sv3EVQk35TD7k6YcM8YqEjdaSvyXA9IBG/HDn6PY9pjwTjs/ESKd8+SwVcB7COY0kKZlYnKvGvY5pkBLw5wPJIqwCOY=
Date: Mon, 18 Oct 2021 15:46:25 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, "Andrew
 Cooper" <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH] x86/paging: restrict physical address width reported to
 guests
Message-ID: <YW16sQI1WmegDkwN@MacBook-Air-de-Roger.local>
References: <e0acfa40-0901-2fc9-31b6-c2609625de22@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <e0acfa40-0901-2fc9-31b6-c2609625de22@suse.com>
X-ClientProxiedBy: LO4P123CA0282.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:195::17) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 4b7aea6a-ae2b-4260-d798-08d9923db097
X-MS-TrafficTypeDiagnostic: DM5PR03MB2843:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <DM5PR03MB28431F40B996F46AA06EA7F28FBC9@DM5PR03MB2843.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 02gpsG7U5YcmDMNU2cWhmz7D09qrlzBoLZd/+N9R/93a/rf2wgCHavpAGxAMQvQeH+EuUK/90AZdBDJ5V93QvtR1xkqEo6Pa/gs5r1GEfFH93g7Zz3Ki5GhKW16tI1gSPHbCZsbiuxk+JrUvfQmt+tOQsTw2KL4zG3IUvJlDGERvDFTc7/6m9HE4OAQLZKb8CaGNAAH6kM05wfjjC7IKhNh7XZ5a4lvIFQTqlehwqcwTeAmCHDb5sk2GJAHVWa+0hOatf4N2iXCZuP/CtJFWLn9PainAjgBwlY22F2GagZyYpMbbtL/CMsIZD7ZyzhwB5/xzNCNaTjgVkAxlyAn9ucpEgLyP//2wLXcrgtJ36l/ZQcYQvsY/8xIc6749Me2tB2buJd4nv/xc/zVbRFq94beou3R9+ZO5cH6fX/ZOq0XisDnSLZ7Q5uG08H+WON72wrML+ljDzrStVHRKMonUEns48GUgigjEmDd2agiZbO2ksV0Rv7Qz6Ew13MCEND1ee6bbaUBpJjZDwoV3oy9Vjla8t6FFdddx2LcQCBzldvTBEUNRlZNv643O6L1PSwjZbPBw4IvbhBZXve6MF/s5/Sk2gZ/ZYAMdWw20DOghdFxU2FMuKB1QUbEMaeUBhc1EMn9mlAbwiZ32QRMtsklSlw==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(6486002)(26005)(85182001)(6666004)(956004)(8676002)(5660300002)(4326008)(6496006)(6916009)(8936002)(508600001)(38100700002)(54906003)(66476007)(82960400001)(186003)(66556008)(9686003)(66946007)(86362001)(316002)(2906002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WlhQSXVUY0V4dXBpNkt1WTQxVkdpTGtUMVphVUF1b0lSdXppanMrU0pLblVH?=
 =?utf-8?B?SEUzVmZqclhtN1FZVVQwVjZQemdJN0VET2dVNUN3ZkNOdDBaL0ttMlJkSmcv?=
 =?utf-8?B?c1h1ZzNZY05XajVxUzZLcm1NTk5IQmt1Ynp4Um9pWmxialROaUc5UzZENlFr?=
 =?utf-8?B?dUE2Sjg2S1MyT0RGei9laFE2dTU1eEhWSjdmNXY3NFE5ZDRPM3dNUUdPamty?=
 =?utf-8?B?R3ZZUkhEcEhwU0VZaGowMC9pOG9GMEI0ZlF5L29pemlTd3Y2c1ZXWGt4N3kx?=
 =?utf-8?B?RUtIMFNxUWJkK0lSdTFiRDNzNEY2amhRMVhJcEh5L1lBT0F1TE1peE85S2t0?=
 =?utf-8?B?LzFDbjJNelhaaElCcmVzU3haZ2s3a3B1eVV5TlArYS9Qc3o5a01nVmMrbmpK?=
 =?utf-8?B?Wkg2UWxxSy9QaDk2c0xtYnk3dUNKN3htaTRzU2ZRaTZxZ0UzR1dKVjIrOTlK?=
 =?utf-8?B?OVpwWHZnc2N6MGZLeE5Hek82MHU0YUhxMmlkY3kyOWRsTkVSNGNqbWc0bjVW?=
 =?utf-8?B?OVJFS00xazVUblJlTzRoVzAvVWdRcGl0SE1NbldaVkZPdW1XODRwSndBcm14?=
 =?utf-8?B?d0RlRXlvOTRydHdDSU1vajJJOEZsaVQ2ZmttcExKS09YdzZFVitOai9ZVmVu?=
 =?utf-8?B?d1dCWVp5b2dNZDI1eHVxK2VOQTRIMHQvY09GWEdDWGNnUldMT3drWFhvU21o?=
 =?utf-8?B?cmpuVit5N1MxZmo0RzBYWngyN1M5L2JPeCsrMXRYT1dUdUo3L3Y0NGE3NFZQ?=
 =?utf-8?B?SjdBVXluNWprbjQ5V0ZXdnl1NUJWSGZMY2w5SUxOamJtc3dSY0NRZ1J5d3NW?=
 =?utf-8?B?MkxQQS9EUnBGbFYvV1A0ZWdJQmpCUUlmMm5MYUVtSXZwR2EwTDZrS1VoN21y?=
 =?utf-8?B?K01kcTcvcVJQcTlTNXZZbCszSGRDeTB3dVFua1lqQUFKaTBXbzRjZVlHZWRW?=
 =?utf-8?B?RytXWjRxTVhWbHVXT1FhaWoyUHJtamJLR2JkNW5KS3RQeUUrVURtakY3N3J5?=
 =?utf-8?B?S0dDRWI2OWdyR2JUMnRUTXYrVmRoUTdYTU8vZDV3VndBKzZtcStVMXhVcm1q?=
 =?utf-8?B?bnBKOVVvdHFKL2trcDVyNW94ZmlmbUlpUk1ZK1NGUHNLM0N1ZUVITXFNVmFP?=
 =?utf-8?B?QnR1dFR0QWVwT0xEYUJKTjROaldUc3UraVJtOXVHWW1UVEU3OEE1aVM1RzVr?=
 =?utf-8?B?ck5Vd1ZZbGMxbkpWQTk4VWlsNSs1RGJqdllaYUpGMjhyMVJQVG9abWxBaGZz?=
 =?utf-8?B?bnMwWkFFQ1daS2Rjcy9XNStIMmMzV3JnTEczWDV2UlRDYTQ1WmRtN3Z5aE9m?=
 =?utf-8?B?RG9FbUEwMXd1RUtITkRPVGtlSDViSGYxVEFFZjJpZnJrelFqbkN2bzBHNVVa?=
 =?utf-8?B?VXc2UHhOUWNWR2RMdTNxelY1K2puMElHWDdpOU5qRE9sd2pKWitYSVdwU3kv?=
 =?utf-8?B?SGxKSHlEdFhvWmUwN0VneFNFM0RCMFNPVm5HVmNub2Q2SWVlMlZXbFoydXJo?=
 =?utf-8?B?M2p2cUgyTFBtZ1Ryek5LSTAzamhOZDNKVDRNYzVqd2FVblVmZnM2MlRXY3ph?=
 =?utf-8?B?bjBKR1Izc293ZHZrTlN2d2ZNUXExTFdWNlpqbm5YV1FaZEtSNEhYWDdFRWJN?=
 =?utf-8?B?Y2VveS93ZTFsc0ZkOEgwOEd6cFdBbVg0Z2NhSVhoanlndDl1bWNjNUFpQXZ3?=
 =?utf-8?B?Q0xOZVJrRVQ3dkQvRE9KczJEbTY1Zk4zZkRxOTJYanBYaWJHQjRUeVc0Qm4x?=
 =?utf-8?Q?tcy/+608f+glaD2vpoSMHcdzuqMRx/30vlGgjNv?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 4b7aea6a-ae2b-4260-d798-08d9923db097
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2021 13:46:30.5347
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: bY42zZh6JjjYjdUg5FJOeMI6Nl7NIJ0/pDCVCjXHLmawdcZIVCkoICniXrNWn/bBSiC5VaLXIpfdASTfn5oSTw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB2843
X-OriginatorOrg: citrix.com

On Wed, Sep 29, 2021 at 02:47:49PM +0200, Jan Beulich wrote:
> Modern hardware may report more than 48 bits of physical address width.
> For paging-external guests our P2M implementation does not cope with
> larger values. Telling the guest of more available bits means misleading
> it into perhaps trying to actually put some page there (like was e.g.
> intermediately done in OVMF for the shared info page).
> 
> While there also convert the PV check to a paging-external one (which in
> our current code base are synonyms of one another anyway).
> 
> Fixes: 5dbd60e16a1f ("x86/shadow: Correct guest behaviour when creating PTEs above maxphysaddr")
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>

> 
> --- a/xen/include/asm-x86/paging.h
> +++ b/xen/include/asm-x86/paging.h
> @@ -401,11 +401,18 @@ static always_inline unsigned int paging
>  {
>      unsigned int bits = paging_mode_hap(d) ? hap_paddr_bits : paddr_bits;
>  
> -    if ( !IS_ENABLED(CONFIG_BIGMEM) && paging_mode_shadow(d) &&
> -         !is_pv_domain(d) )
> +    if ( paging_mode_external(d) )
>      {
> -        /* Shadowed superpages store GFNs in 32-bit page_info fields. */
> -        bits = min(bits, 32U + PAGE_SHIFT);
> +        if ( !IS_ENABLED(CONFIG_BIGMEM) && paging_mode_shadow(d) )
> +        {
> +            /* Shadowed superpages store GFNs in 32-bit page_info fields. */
> +            bits = min(bits, 32U + PAGE_SHIFT);
> +        }
> +        else
> +        {
> +            /* Both p2m-ept and p2m-pt only support 4-level page tables. */
> +            bits = min(bits, 48U);

It would be nice if there was a way to not have to manually change the
values here if we ever support 5-level page tables for example, but I
don't know of any way.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Mon Oct 18 13:58:13 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Oct 2021 13:58:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.212318.370150 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcT9V-0002DA-7q; Mon, 18 Oct 2021 13:58:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 212318.370150; Mon, 18 Oct 2021 13:58:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcT9V-0002D3-4d; Mon, 18 Oct 2021 13:58:09 +0000
Received: by outflank-mailman (input) for mailman id 212318;
 Mon, 18 Oct 2021 13:58:07 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mcT9T-0002Cx-CE
 for xen-devel@lists.xenproject.org; Mon, 18 Oct 2021 13:58:07 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mcT9T-0006Km-8u
 for xen-devel@lists.xenproject.org; Mon, 18 Oct 2021 13:58:07 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mcT9T-0008G9-7x
 for xen-devel@lists.xenproject.org; Mon, 18 Oct 2021 13:58:07 +0000
Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89)
 (envelope-from <iwj@xenproject.org>)
 id 1mcT9N-00065B-OT; Mon, 18 Oct 2021 14:58:01 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date
	:Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From;
	bh=Au1K67xP+k2yvgLe6WaBnRqLuOlvNFFfEExbWSfQ8Q4=; b=yOWXpMA8JkAASelG6OZFn+pPZV
	NwAtFacjddXpGOAKHxxUYlx5j+KSYkbz2lvqmTwa4GdptITnAXperQijp6sh02Ua/sfwMypQnvW2w
	UnDLDh5Y03dQFF197PXeeeFDKIi36zWTy0Qn+wYwudQ6unzw46YGgCkouA57uyTbUJ28=;
From: Ian Jackson <iwj@xenproject.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
Message-ID: <24941.32105.341239.774328@mariner.uk.xensource.com>
Date: Mon, 18 Oct 2021 14:58:01 +0100
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Wei Liu <wl@xen.org>,
    Xen-devel <xen-devel@lists.xenproject.org>,
    Jane  Malalane <jane.malalane@citrix.com>
Subject: Re: [PATCH for-4.16] tests/resource: Extend to check that the grant
 frames are mapped correctly
In-Reply-To: <f25e1fdb-90fb-7273-243d-e197eb9e2f92@citrix.com>
References: <20211018100848.10612-1-jane.malalane@citrix.com>
	<f25e1fdb-90fb-7273-243d-e197eb9e2f92@citrix.com>
X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu)

Andrew Cooper writes ("Re: [PATCH for-4.16] tests/resource: Extend to check that the grant frames are mapped correctly"):
> On 18/10/2021 11:08, Jane Malalane wrote:
> > Previously, we checked that we could map 40 pages with nothing
> > complaining. Now we're adding extra logic to check that those 40
> > frames are "correct".
> >
> > Suggested-by: Andrew Cooper <andrew.cooper3@citrix.com>
> > Signed-off-by: Jane Malalane <jane.malalane@citrix.com>
> 
> Ian:� I'd like this to be considered for 4.16.� It is extending an
> existing test case with better error detection.
> 
> It was a task I didn't get around to at the time, because of the 4.15
> release freeze...� How time flies.
> 
> Anyway, it is very low risk to the release, and 0 risk for anyone who
> doesn't run the tests...

Of course.

Release-Acked-by: Ian Jackson <iwj@xenproject.org>

Ian.


From xen-devel-bounces@lists.xenproject.org Mon Oct 18 14:08:10 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Oct 2021 14:08:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.212329.370162 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcTJ0-0003o7-63; Mon, 18 Oct 2021 14:07:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 212329.370162; Mon, 18 Oct 2021 14:07:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcTJ0-0003o0-1j; Mon, 18 Oct 2021 14:07:58 +0000
Received: by outflank-mailman (input) for mailman id 212329;
 Mon, 18 Oct 2021 14:07:56 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=RpTT=PG=epam.com=prvs=0925c93432=oleksandr_andrushchenko@srs-us1.protection.inumbo.net>)
 id 1mcTIy-0003n6-3H
 for xen-devel@lists.xenproject.org; Mon, 18 Oct 2021 14:07:56 +0000
Received: from mx0b-0039f301.pphosted.com (unknown [148.163.137.242])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id ca036196-301c-11ec-82d8-12813bfff9fa;
 Mon, 18 Oct 2021 14:07:54 +0000 (UTC)
Received: from pps.filterd (m0174683.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.0.43) with SMTP id 19IDtcDv020444;
 Mon, 18 Oct 2021 14:07:52 GMT
Received: from eur05-vi1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2177.outbound.protection.outlook.com [104.47.17.177])
 by mx0b-0039f301.pphosted.com with ESMTP id 3bs3h79wmf-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Mon, 18 Oct 2021 14:07:51 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by AM0PR03MB6323.eurprd03.prod.outlook.com (2603:10a6:20b:159::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16; Mon, 18 Oct
 2021 14:07:48 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::c038:e032:595a:651]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::c038:e032:595a:651%7]) with mapi id 15.20.4608.018; Mon, 18 Oct 2021
 14:07:48 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ca036196-301c-11ec-82d8-12813bfff9fa
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=lhmFHc1An/VojewQmULopIm7DyEoiRpAbRsjpXycl+w4e6U4hma0+1am9qlXVEP9CA8wcr75JRN5LmG6TXOFk9PT3mCi+uJn0yX/g1x3C4mgg/VNUsk1enzCbzUoU5D3zJkWZ6zqRbk8m9li3qyL+TvCc7w8x8HTmEuhiLa8tsXEMOAcRqxuzRVTgaBASLLf0HD9jrZGUakeP5uz47Tm6P3DVjAbB3tcpfEwrhCrQN8j7OA2IyUHpBlVYg6orK47E2NuaUQMTjJCbiPbhMi0gT2bqdgO1NKIYdmcnn6obyNhhJZ+qZHhHo16bHMbUCTQ9EiqmO0cLTnmkeu9C5orTA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=YzqIXUW/GuM6HHgf1LJ/uCigthYMGbHIfWQI0mOFCLE=;
 b=gpR7p5D7xC6tgnD/qPVLBgWDdMqCSc4HDYHPv3LbecOUGiUAf416aD21y4BdwN/ncNCDS6WjID7EUhMY6J1lgLbTRTsHjIWGW4cCNC1GLlOPFICNqcSncpz/aXNZHOaQTDbgUCXev3ap9+aS79VRzDA2F7CGGTkT3cHWrm//rdA5LY2yuUmfAmkRZ72yHXWQsTzuoYhKhI0fuEiLgTmuXfdJ2OMb2C5/nd2fDLVtKAA47x2PF/VN87k8soWlVCzsIA3ynKZp/Ax3mlT6GSBSoTM62QD1ZZ+pkkfa645ugI2SLmr61kUYN3tAE6Xmis7tDixcVEjCVL9HDIQZloHzfQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=YzqIXUW/GuM6HHgf1LJ/uCigthYMGbHIfWQI0mOFCLE=;
 b=5IESHmLLzIyTT/YMiqhA85SvWRb+lQOJMSc6lXeqU1gKdXitQQlpYhaTBVtxNwJfVp5285e7cXa163eOWIlXHE1UHT78/4x6Z1W8aUEq7y/UdhHlEScjGcihBN2TBfRDxgvxEYzFLM6Ps3R5xIdVhjObOE/qrDn9qhvALHtPohoY3kyfrHMAHGkVRfNT8KfOO2BuiOq8r3WybygkVcBlkJ5hFs2NKcDUksgCD5se3J0bHjgM+8OWvhLRDbhwO6hkGIOacDLeVPaLyUDCvHlA2Z5T23LWKyFV/mBUfVJi2aSjBY6iwraF5phxdmuedhqQZ/yUbI9Q7bjQsP67MeL6Hg==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Jan Beulich <jbeulich@suse.com>,
        Bertrand Marquis
	<bertrand.marquis@arm.com>,
        Ian Jackson <iwj@xenproject.org>
CC: Rahul Singh <rahul.singh@arm.com>,
        =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?=
	<roger.pau@citrix.com>,
        "sstabellini@kernel.org" <sstabellini@kernel.org>,
        Julien Grall <julien@xen.org>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Andrew Cooper <andrew.cooper3@citrix.com>,
        George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
        Paul Durrant
	<paul@xen.org>,
        "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>,
        Oleksandr Andrushchenko
	<Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH v8 2/5] xen/arm: Enable the existing x86 virtual PCI
 support for ARM
Thread-Topic: [PATCH v8 2/5] xen/arm: Enable the existing x86 virtual PCI
 support for ARM
Thread-Index: AQHXxCmHx+Lzp09rU0elFmx0jxVt5g==
Date: Mon, 18 Oct 2021 14:07:48 +0000
Message-ID: <46bcd42f-df4f-922a-cc21-a05821481754@epam.com>
References: <cover.1634315461.git.bertrand.marquis@arm.com>
 <e2b10f56043155e4bb8eae824723045ccc042f8e.1634315461.git.bertrand.marquis@arm.com>
 <ca5558b2-25c6-90d2-284b-03cbbb02691f@suse.com>
 <FBC4FA6D-AF07-437A-BD81-52708B139070@arm.com>
 <8c99e635-9509-b078-2285-48fb6fb91507@suse.com>
In-Reply-To: <8c99e635-9509-b078-2285-48fb6fb91507@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
authentication-results: suse.com; dkim=none (message not signed)
 header.d=none;suse.com; dmarc=none action=none header.from=epam.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: bdb57ddc-922f-469f-5630-08d99240aaaa
x-ms-traffictypediagnostic: AM0PR03MB6323:
x-ms-exchange-transport-forked: True
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <AM0PR03MB632358AAF81019CEC9780E77E7BC9@AM0PR03MB6323.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:9508;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 fycNwjYmM7q+gBocVOUyF815nYa6Tey8gJAoPYZYIZbHG0C/vjefqsnrJTHHNs9UN8/kxPy0GQKUkW8p+srwNMKvtOHIJB08+PXjkvIwT73q6354ajD+wC2DlHkGlwcWLRsVoY48X6VEPFqm/Ymmkbq+LcQCwFvvd/X3M2lxtQUr3laUDOe2nrCOrvfYudNyvgYb0ba9NQDtKkwb9z0iLF+tto7wVbW/OD8qpoLMNziYwSOlJ9DD+s0+7C5OJ1F1T+PyumnHXlQ3AsoMso8N7xxLg+e5MiptCO5rDSjX0A41fV4v1QXVe6GT6BOzfv6+lBXiOZbYK9uHmtp1S5BWhLHg/tra0Y9FkXgPCvAiCJr3f0lSVOHV7M4bE/5SnGwSnj3V2g6o+LrTlOMs1Yw9a9z+Rr0Df3SNo/V15zaBLspmTMHy5IC/TIL7nECkKEu0S/Vh3tPVu3LBp2qGlwfU2ZwA6iX66v32cIgIf4xfnpz4yVihHMA9NPwQyAd9s/48XTyn5Go92ILouhbjl4lKD2Z0CVPdD33mgXik9UFyP44ozcZF1Ddqr5Gsq91YJT0AobXNSiWfDj91eIuSJiOdhr4SinCq5Dm71BY6bc+87Y4CrdokDHH3P4OOIctV1ZJ+cehrNtzNdMmslt23i8UB6OyJETS0K4PL2VvZrxDWU8D8uBypKhTVo/VBMn3EAfk93uaLranDKm2z0gYfrs6Pru/pFHSG7ha0dJOhz8+9R2ofV1EYdap2J+7DI2rw5+l/t+t0lbsJ06SQ3t9oecHLLneslygMPxLqY1CaYMuaeUhlBIx+TscB2HlFXLinonZIH4xS5IjMhZd1ZvLJGVQJZAbD18DP+UgBBiM3ulgg/20=
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(71200400001)(6506007)(316002)(31686004)(508600001)(53546011)(2906002)(7416002)(36756003)(31696002)(8936002)(966005)(66946007)(38070700005)(5660300002)(76116006)(4326008)(8676002)(110136005)(6512007)(38100700002)(86362001)(66446008)(2616005)(107886003)(122000001)(91956017)(66476007)(26005)(6486002)(66556008)(54906003)(64756008)(186003)(2004002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?VFoxQ3hydnRlTEoxT09GSkRpKy9uK3kwUXE0dk05a2hiZ210d1VCNFZnQnJu?=
 =?utf-8?B?Wjl3WmdGenpGVmV5R0FxbkZyYnAvVVMyTitVanl6VWlPYzQzVXl2YmNsRUgy?=
 =?utf-8?B?Qzc4ME1tODEvQnd0NHVYdnN2ZGxmeXBUbi96ZXM2MFJHV0FkcDE5dVlQcGdS?=
 =?utf-8?B?ejNJdms1T1BjU0c4MFNXV0F0OFNPOHBwb1d3MDBIenE4NjBaSzIrbUN1UVB2?=
 =?utf-8?B?SXRHZVZweExnYlRSQVMwSTVPVzJGL05Wd1pFZm1ybW5SZUYrRFVYV2hpR1hr?=
 =?utf-8?B?b0x5UDZrNzYzalozaXpHSEFkR3AvMk9UOG95WjZESE5RZjdWcnhyZnFJQzF6?=
 =?utf-8?B?ZVplbHRVeHZ5cHZBYTRabVFCK3NzVU5uSUhHQkcxOTM1ZThkVjZ3clRSRENx?=
 =?utf-8?B?SVNxNGNoTm1Qb3UzN0Y3UTNmc2ZHczR3anNCa1R0aWVaVkZNRFZzTGl6L2Z5?=
 =?utf-8?B?bWQ5UTk5eGEvSFI4NE5qeFhXTXJwVlBrUnNBQ2JTRWU5M3cvWndsWFdMQlNJ?=
 =?utf-8?B?ZjNxRC9VSWlVYjdSN3JDVlFuUG1BeVZlald1V0t4eFpMUC95bUs3MVNkeGRv?=
 =?utf-8?B?SnhHaGI5NkFrMElsYlZUUUlRWXFuSmg3VkRvM3NlMTdGOVcxM2Erc1o4NDZp?=
 =?utf-8?B?cTFMcEhpNGxuSkU4NHdoZHBTa0RqUklVZGcwcjRFQ3FQTkplT0hGSFBOdlh5?=
 =?utf-8?B?NzExK2x6ajI5YUwzM281aDFtTTFwcUJMYWxMWmtONlROOStPK3pveUxiL3Fi?=
 =?utf-8?B?bUdDeFFuN0lxZkxseHNHSUdRMzBOa3lQUHR2SFlSZFloOFJ3b2Rpb0R3Vkly?=
 =?utf-8?B?TVFFVUpvNTZPek4yWjRpNHlGcy9NTTBvN2dFUmI0MW5CMmM1engyWEV2N1R1?=
 =?utf-8?B?WEZwL0pmcklyUVNDQ3RubjRvL2QwYVU3dERwRFlMV2lmY3lWRDU2dnMyNFNQ?=
 =?utf-8?B?eHZDSEhKVkx2RndsdzRvVXAwK2VqbERUcHc1MHFzaVhPVEN6MHpKWlpYSDdi?=
 =?utf-8?B?bUhGcWR1V0ZYVzJvTjB6dmt5L05qTm16STRyMElOZVFQTisvRDRUVi9QWFdD?=
 =?utf-8?B?TWJhUE1FWjB6aHVEMElqelFTaTkyWWNaTHBsUEdBbjFlbkhPNVlnRmNpVW5q?=
 =?utf-8?B?Q0FLSXVKa2Z0UzNkSjZBUk5DYU43dk1rT05QUkRoNWUvUHN6ZUVLL1ppTGNi?=
 =?utf-8?B?dHc5eElOQ3hibmVneC9YZHFJaEFPY0R4czd2dVdleWZvSnQyZDJQOGlYSzFq?=
 =?utf-8?B?SE5pZldZTDg2V1N5Kzh3VnJtZitWVDROTFVYQlEzSDZKbWRMWEs4K1dpWEdB?=
 =?utf-8?B?Mks0dnRMZHJqcm9QaGxIM1hxa2U4eUNGWDlIMElvRGd5R3ZMMWlPcFBndXZ4?=
 =?utf-8?B?UzBlT011OHFPQ0FkUTRMdHQ2cXdMRnU5V2JJbWFHRGxJSTJMYWpzbklxK01T?=
 =?utf-8?B?Ujlpa0FpZ1RSUURGWGFBTUloTmxGRkp2WVBRdDdDTjYyYlRpWkhwR0lmOHdu?=
 =?utf-8?B?WmNseFdOZGliRFRXR1IrcVBHUEV5T2xEMzNRK0VyUUlJUHNUd2wvdXNLUnZP?=
 =?utf-8?B?VkJHdjF3TmRsSGJ5VEEvNW93Mi9kRTU3UmJzWW9od0NidFg3cnJ5STlVV3Rh?=
 =?utf-8?B?SkY1TnpKU2huRUZDYW9GVWQvbmFQOWgwbkliV0dSUXczUVNKVkNGRlNiMTRq?=
 =?utf-8?B?VVBlS0lUc0x5QjVPbWJ4aVYyVEsrSDFMQlZ5eTRZYTdCeUpFNFFGN0c1enVa?=
 =?utf-8?Q?lq2s67ADctL8G5Pi3jtkVQQzeMWLUG+U4pb+pNn?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <017C996A2B31DF43AE6FD504182E7BD6@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bdb57ddc-922f-469f-5630-08d99240aaaa
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Oct 2021 14:07:48.7323
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: UjU6Fnc3pOfORAIHE8WYkb1jtZ3GxB4xhsZZVwGmiwvdS/9Sy5qdFXYJEKNXbqrnMjhKUO8g25U9XqrBkTR8Hc106LwszKyYlRTj8OCmenhJ71ZDYkyPHN70vIWr1sfn
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR03MB6323
X-Proofpoint-GUID: YKrocAIzH8qSvtPFOvGQHro4mH2knCjo
X-Proofpoint-ORIG-GUID: YKrocAIzH8qSvtPFOvGQHro4mH2knCjo
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475
 definitions=2021-10-18_06,2021-10-14_02,2020-04-07_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 adultscore=0
 bulkscore=0 impostorscore=0 clxscore=1015 mlxlogscore=999
 priorityscore=1501 spamscore=0 malwarescore=0 suspectscore=0 phishscore=0
 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2109230001 definitions=main-2110180088

DQoNCk9uIDE4LjEwLjIxIDEzOjI5LCBKYW4gQmV1bGljaCB3cm90ZToNCj4gT24gMTguMTAuMjAy
MSAxMjoxMSwgQmVydHJhbmQgTWFycXVpcyB3cm90ZToNCj4+PiBPbiAxOCBPY3QgMjAyMSwgYXQg
MDg6NDcsIEphbiBCZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNvbT4gd3JvdGU6DQo+Pj4gT24gMTUu
MTAuMjAyMSAxODo1MSwgQmVydHJhbmQgTWFycXVpcyB3cm90ZToNCj4+Pj4gLS0tIC9kZXYvbnVs
bA0KPj4+PiArKysgYi94ZW4vYXJjaC9hcm0vdnBjaS5jDQo+Pj4+IEBAIC0wLDAgKzEsNzcgQEAN
Cj4+Pj4gKy8qDQo+Pj4+ICsgKiB4ZW4vYXJjaC9hcm0vdnBjaS5jDQo+Pj4+ICsgKg0KPj4+PiAr
ICogVGhpcyBwcm9ncmFtIGlzIGZyZWUgc29mdHdhcmU7IHlvdSBjYW4gcmVkaXN0cmlidXRlIGl0
IGFuZC9vciBtb2RpZnkNCj4+Pj4gKyAqIGl0IHVuZGVyIHRoZSB0ZXJtcyBvZiB0aGUgR05VIEdl
bmVyYWwgUHVibGljIExpY2Vuc2UgYXMgcHVibGlzaGVkIGJ5DQo+Pj4+ICsgKiB0aGUgRnJlZSBT
b2Z0d2FyZSBGb3VuZGF0aW9uOyBlaXRoZXIgdmVyc2lvbiAyIG9mIHRoZSBMaWNlbnNlLCBvcg0K
Pj4+PiArICogKGF0IHlvdXIgb3B0aW9uKSBhbnkgbGF0ZXIgdmVyc2lvbi4NCj4+Pj4gKyAqDQo+
Pj4+ICsgKiBUaGlzIHByb2dyYW0gaXMgZGlzdHJpYnV0ZWQgaW4gdGhlIGhvcGUgdGhhdCBpdCB3
aWxsIGJlIHVzZWZ1bCwNCj4+Pj4gKyAqIGJ1dCBXSVRIT1VUIEFOWSBXQVJSQU5UWTsgd2l0aG91
dCBldmVuIHRoZSBpbXBsaWVkIHdhcnJhbnR5IG9mDQo+Pj4+ICsgKiBNRVJDSEFOVEFCSUxJVFkg
b3IgRklUTkVTUyBGT1IgQSBQQVJUSUNVTEFSIFBVUlBPU0UuICBTZWUgdGhlDQo+Pj4+ICsgKiBH
TlUgR2VuZXJhbCBQdWJsaWMgTGljZW5zZSBmb3IgbW9yZSBkZXRhaWxzLg0KPj4+PiArICovDQo+
Pj4+ICsjaW5jbHVkZSA8eGVuL3NjaGVkLmg+DQo+Pj4+ICsjaW5jbHVkZSA8eGVuL3ZwY2kuaD4N
Cj4+Pj4gKw0KPj4+PiArI2luY2x1ZGUgPGFzbS9tbWlvLmg+DQo+Pj4+ICsNCj4+Pj4gK3N0YXRp
YyBpbnQgdnBjaV9tbWlvX3JlYWQoc3RydWN0IHZjcHUgKnYsIG1taW9faW5mb190ICppbmZvLA0K
Pj4+PiArICAgICAgICAgICAgICAgICAgICAgICAgICByZWdpc3Rlcl90ICpyLCB2b2lkICpwKQ0K
Pj4+PiArew0KPj4+PiArICAgIHBjaV9zYmRmX3Qgc2JkZjsNCj4+Pj4gKyAgICAvKiBkYXRhIGlz
IG5lZWRlZCB0byBwcmV2ZW50IGEgcG9pbnRlciBjYXN0IG9uIDMyYml0ICovDQo+Pj4+ICsgICAg
dW5zaWduZWQgbG9uZyBkYXRhOw0KPj4+PiArDQo+Pj4+ICsgICAgLyogV2UgaWdub3JlIHNlZ21l
bnQgcGFydCBhbmQgYWx3YXlzIGhhbmRsZSBzZWdtZW50IDAgKi8NCj4+Pj4gKyAgICBzYmRmLnNi
ZGYgPSBWUENJX0VDQU1fQkRGKGluZm8tPmdwYSk7DQo+Pj4+ICsNCj4+Pj4gKyAgICBpZiAoIHZw
Y2lfZWNhbV9yZWFkKHNiZGYsIEVDQU1fUkVHX09GRlNFVChpbmZvLT5ncGEpLA0KPj4+PiArICAg
ICAgICAgICAgICAgICAgICAgICAgMVUgPDwgaW5mby0+ZGFidC5zaXplLCAmZGF0YSkgKQ0KPj4+
PiArICAgIHsNCj4+PiBIZXJlIGl0IGlzIHF1aXRlIGNsZWFyIHRoYXQgdGhlIFNCREYgeW91IHBh
c3MgaW50byB2cGNpX2VjYW1fcmVhZCgpIGlzDQo+Pj4gdGhlIHZpcnR1YWwgb25lLiBUaGUgZnVu
Y3Rpb24gdGhlbiBjYWxscyB2cGNpX3JlYWQoKSwgd2hpY2ggaW4gdHVybg0KPj4+IHdpbGwgY2Fs
bCB2cGNpX3JlYWRfaHcoKSBpbiBhIG51bWJlciBvZiBzaXR1YXRpb25zIChmaXJzdCBhbmQgZm9y
ZW1vc3QNCj4+PiB3aGVuZXZlciBwY2lfZ2V0X3BkZXZfYnlfZG9tYWluKCkgcmV0dXJucyBOVUxM
KS4gVGhhdCBmdW5jdGlvbiBhcyB3ZWxsDQo+Pj4gYXMgcGNpX2dldF9wZGV2X2J5X2RvbWFpbigp
IHVzZSB0aGUgcGFzc2VkIGluIFNCREYgYXMgaWYgaXQgd2FzIGENCj4+PiBwaHlzaWNhbCBvbmU7
IEknbSB1bmFibGUgdG8gc3BvdCBhbnkgdHJhbnNsYXRpb24uIFlldCBJIGRvIHJlY2FsbA0KPj4+
IHNlZWluZyBhc3NpZ25tZW50IG9mIGEgdmlydHVhbCBkZXZpY2UgYW5kIGZ1bmN0aW9uIG51bWJl
ciBzb21ld2hlcmUNCj4+PiAocGVyaGFwcyBhbm90aGVyIG9mIHRoZSByZWxhdGVkIHNlcmllcyks
IHNvIHRoZSBtb2RlbCBhbHNvIGRvZXNuJ3QNCj4+PiBsb29rIHRvIGFzc3VtZSAxOjEgbWFwcGlu
ZyBvZiBTQkRGLg0KPj4gVGhpcyBxdWVzdGlvbiB3YXMgYW5zd2VyZWQgYnkgT2xla3NhbmRyIEkg
dGhpbmsuDQo+IFllczsgSSBjb250aW51ZSB0byBiZSBzdXJlIHRob3VnaCB0aGF0IEkgc2F3IGRl
dmZuIGFsbG9jYXRpb24gbG9naWMgaW4NCj4gb25lIG9mIHRoZSBtYW55IHBhdGNoZXMgdGhhdCBh
cmUgcmVsYXRlZCBoZXJlLiBBbmQgSSdtIHJlbGF0aXZlbHkgc3VyZQ0KPiB0aGF0IHRoZXJlIG5v
IGFkanVzdG1lbnQgdG8gbG9naWMgaGVyZSB3YXMgbWFkZSAoYnV0IHNpbmNlIGl0J3MgaGFyZA0K
PiB0byBwaWNrIHRoZSByaWdodCBwYXRjaCBvdXQgb2YgdGhlIGh1Z2UgcGlsZSB3aXRob3V0IGtu
b3dpbmcgaXRzIHRpdGxlLA0KPiBJIGNhbid0IHJlYXNvbmFibHkgZ28gY2hlY2spLg0KT2ZmdG9w
OiBJIHdhcyBzb21laG93IGRyb3BwZWQgZnJvbSB0aGUgQ2MuLg0KDQpQbGVhc2Ugc2VlOg0KDQpb
UEFUQ0ggdjMgMTAvMTFdIHZwY2k6IEFkZCBpbml0aWFsIHN1cHBvcnQgZm9yIHZpcnR1YWwgUENJ
IGJ1cyB0b3BvbG9neQ0KW1BBVENIIHYzIDExLzExXSB4ZW4vYXJtOiBUcmFuc2xhdGUgdmlydHVh
bCBQQ0kgYnVzIHRvcG9sb2d5IGZvciBndWVzdHMNCg0KWzFdIGh0dHBzOi8vcGF0Y2h3b3JrLmtl
cm5lbC5vcmcvcHJvamVjdC94ZW4tZGV2ZWwvbGlzdC8/c2VyaWVzPTU1NTQ4MQ0KDQo=


From xen-devel-bounces@lists.xenproject.org Mon Oct 18 14:13:57 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Oct 2021 14:13:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.212337.370173 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcTOi-0005Bq-Qp; Mon, 18 Oct 2021 14:13:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 212337.370173; Mon, 18 Oct 2021 14:13:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcTOi-0005Bj-Ng; Mon, 18 Oct 2021 14:13:52 +0000
Received: by outflank-mailman (input) for mailman id 212337;
 Mon, 18 Oct 2021 14:13:51 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=3tpC=PG=citrix.com=roger.pau@srs-us1.protection.inumbo.net>)
 id 1mcTOh-0005Bc-JN
 for xen-devel@lists.xenproject.org; Mon, 18 Oct 2021 14:13:51 +0000
Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 9d796cf1-301d-11ec-82d8-12813bfff9fa;
 Mon, 18 Oct 2021 14:13:50 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9d796cf1-301d-11ec-82d8-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1634566430;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=l+dNsJUXdeVg3wkrf0EehxmowJ3Zk7Gz6kQPvsSe2bk=;
  b=hsOG6oFM+kf8I4zhqgnAQ4twmF/Oa1MTnt4cVlXN7V+Ezb9hvTUySw7C
   jrPb31JgQm8hxw6GNJpbU6+0Pod42/ce3PsNIWXItbKZ0bKd0Zw4ocCww
   q89ppSU1UT74725tnhZI4KOY3UYoMC4IgveubH7Gj28UNSq4L7b0cMuLv
   M=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: ML9E70PRLNv3PU8uRxbA7/TFLZ0wiKMdcD03IEpxLHLRbZJ7+LXgYqQ8XnQmzrJDQgBFReocJj
 ekWAkeEygZ91sFXFUt6HXb1JFOHT2SYg0lqLoae7TflIWyp+rmKY50BjMeKqxEY8PGy3AUUuMY
 BFR0Ul/SPl0KLc3MaB0kPWzKDIK0GOxVQWxCQqpGlx+F5wjg/SRzjP0tv9AzF3IQml4i8SGD2L
 I51TJzWUHlfif0agtK6C2tFehCC9F/GMRVHkbSSMIRH8L55y2aDK9jtpvqVTD2qFOTWHwNVZAK
 CRFvBfFcrO38cTt732Dm+HOq
X-SBRS: 5.1
X-MesageID: 55471918
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:1/B3fa2YqSE9j1fn1vbD5Qh2kn2cJEfYwER7XKvMYLTBsI5bp2cOm
 2JJDGmGbv6NNzGheop2OYq/9U0BvMDdzd81QAdspC1hF35El5HIVI+TRqvS04J+DSFhoGZPt
 Zh2hgzodZhsJpPkS5PE3oHJ9RGQ74nRLlbHILOCan0ZqTNMEn970Es7wr5h2OaEvPDia++zk
 YKqyyHgEAfNNw5cagr4PIra9XuDFNyr0N8plgRWicJj5TcypFFMZH4rHomjLmOQf2VhNrXSq
 9Avbl2O1jixEx8FUrtJm1tgG6EAaua60QOm0hK6V0U+6/TrS+NbPqsTbZIhhUlrZzqhg81R8
 O1V74OMZjwnPIaRpeNAXEFCDHQrVUFG0OevzXmXtMWSywvNcmf2wuUoB0YzVWEa0r8pWycUr
 6VecW1TKEDY7w616OvTpu1EnMMsIdOtJIoCknph0SvYHbAtRpWrr6DiuIIEg25h35Am8fD2P
 sYeYBFAQzP5OxxVN1I1M9FlsNv1iSyqG9FfgA3M/vdmi4TJ9yRu1JD9PdyTfcaFLe1Fk0Ddq
 m/Y8mDRBhABKMfZ2TeD6mirhOLEgWX8Qo16PL+y++NugVaT7ncOExBQXly+ycRVkWbnBYgZc
 RZNvHNz8+5iryRHU+URQTWkvV68hgZGROZ/KOM4w1ywzffbuxyGUz1soiF6VPQqs8o/RDoP3
 1CPns/0CTEHjIB5WU5x5Z/P8mvsYXl9wXsqIHZeF1NcsoaLTJQb10qXFr5e/LiJYsoZ8N0a6
 wuBqzQinP0thMoP2rTTEbvv0m/0+MahouLY4GzqsoOZAuFROdbNi2+AswGzARN8wGCxFAjpU
 J8swJD20Qz2JcvR/BFhuc1UdF1T296LMSfHnXlkFIQ7+jKm9haLJN4LvG0veRYzbppeKFcFh
 XM/XysLtfe/21PxNcdKj3+ZUZx2ncAM6/y0PhwrUja+SscoL1LWlM2fTUWRw3rsgCARfVIXY
 v+mnTKXJS9CU8xPlWPuL89EiOND7n1ulAv7GMGgpzz6gOX2WZJgYepcWLd4Rrtit/3sTcS82
 4s3CvZmPD0EDLShP3WKqNNKRb3IRFBiba3LRwVsXrfrCiJtGX07Cu+XxrUkeod/mL9SmPuO9
 Xa4MnK0AnKk7ZEeAQnVOH1ldp31WpNz8SAyMSA2ZA760Hk/e4e/qqwYcsJvL7Ug8eViy99yT
 uUEJJrcUqgeFGyf9mRPd4T5oaxjaA+v2VCEMR26bWVtZJVnXQHIpIPpJ1O96CkUAyOrnsIiu
 Ln8hBjDSJ8OSl06XsbbYf6i1X2run0ZlL4gVkfEOIALKk7t7JJrO2r6ifpue5MALhDKxz270
 QeKAEhH+bmR8tFtqNSQ3PKKtYakFed6D3F2JWiD4ObkLzTe80qi3ZREDLSCcwfCWT6m466lf
 +hUka3xaaVVgFZQvoNgOL931qZitcD3rrpXwwk4TnXGa1OnVuFpLnWchJQds6RMwvlSuBesW
 1LJ8d5fYO3bNMTgGV8XBQwkcuXciq1ExmiMtaw4cBfg+St63LubSkEDbRCDhRtUIKZxLI54k
 /wqv9Qb6lDnhxcnWjpcYvu4K4hYwqQ8bpga
IronPort-HdrOrdr: A9a23:mPhO1K4uf+8oJq8OHAPXwMzXdLJyesId70hD6qkXc20zTiX4rb
 HLoB1/73TJYVkqNE3I9eruBEDiexPhHPxOj7X5VI3KNGOKhILCFuBfxLqn7zr8GzDvss5xvJ
 0QFpSW0eeAbmSSW/yKgjWFLw==
X-IronPort-AV: E=Sophos;i="5.85,382,1624334400"; 
   d="scan'208";a="55471918"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=P4YWzFN+kTupUBoAbvXhSOlYlAiGNQ2xod2Q8x6uk77MpIoudk5cpsbwQib14eGZNpYXG9Ep/NJexvVsC2g0J2e7pmOBQvJDEb7h72HPjUWgWe1FBYyu3Uuoes0X05HPrLhpnPOnMKToyEJZxkda4yAmWWzv61uJsSK7417dOj0uL3Z2PvWRG7B7AT6litTrZp6uPzsm1wf3+h7mCMq/o9fj6ZrA3RlZg66XmGzTLh4KOEnRdzNrZo4svz+yb8e/JProwUIbQ2ZLZlvfIsXxkoyL/Cy1gLzONk1kquh0eciRvniM8UFUPTJ161qwsZVQnIUSNc46aMYnkk4+HZAkew==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Dc+qMydesX1h0EmgRj4Svje9E02+vYvUHM+dhZKnqMs=;
 b=SOFK5m92noehyCXnq4OG9tdhKvGu2hfsnPBoYaaqdxPIwBUmaNEzanWpQBjp7N0ufJ9MvuMTA5ua2Us+M/AacDLRJC0PCtv81xdUac7xJ6VFBjsOj/kEVTH1WCfa5g+bjiLLi6HvIIAUaf83lyxUVfqU9sl8IPL/w47Edd+O1/CAdYDO79rYs2kTBCLzT2y9dngYoNtl8ETOVshZD0bnsdzESQW/NPCSKrOrRCBMaG8D5ZwKDTp3Mww6j3QQ1YshIDgVKRt5/3wIcWUhs09lIJzB6DxsEhqctRRX4CZro/KXOHGzKT1RAxU6sx45hs7fW/PXPGdZfAaNeRBcYhuXLg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Dc+qMydesX1h0EmgRj4Svje9E02+vYvUHM+dhZKnqMs=;
 b=LL4LLHZSBKSdn4J3w3/V3Z8ikHPfW2dIocOGnUau9Ib23mDTmupXXYT6qmzQ/SGEnS+gZxfpGxmYo1JjTwSowrrkwPgKviPBxPFNnQLTM4wAnuXsXyZg2rteiRxt/8E0vhT0HD1qNLst2KmJEn+EiaIRXRZre0PupyJFaU53GLY=
Date: Mon, 18 Oct 2021 16:13:33 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Andrew
 Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH 1/3] x86/PV: make '0' debug key dump Dom0's stacks again
Message-ID: <YW2BDQwPOJ2qL9mw@MacBook-Air-de-Roger.local>
References: <2a14f2d0-2a53-287f-da36-dfb054c7f944@suse.com>
 <268da650-1261-0ac6-9908-7916f0b4d2ec@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <268da650-1261-0ac6-9908-7916f0b4d2ec@suse.com>
X-ClientProxiedBy: LO4P123CA0187.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:1a4::12) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 8561a73e-9e91-4908-eeef-08d992417b0d
X-MS-TrafficTypeDiagnostic: DM5PR03MB3210:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <DM5PR03MB32107B4481C145280F8501BA8FBC9@DM5PR03MB3210.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8273;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: iTclhTq90kLqblPXFx22D5bNB4Z6pS4z1KWs73+2JDgsqPaQx869RKHBSzbRgA9YfcCl0gQKRDz7sbHKA8L0WwOsOofuzvlL7des80OqyUeEu4lToJc2ccIAtHZXnW/SbphkKnyQ++JiT6FMpYYdiq/aSWz8et1jw27cH9/46VXM2GXUO5Ju6oo61YwhCzkX/ZtfeYkhqqISa8869jj4GrOancEZeDGqUxFPryHNHjnh4QIlLxPrld876GH5Vl1zsFjvO/y8DJCHGHOFv1JWgdQX/IreZMT0JIMTurC4olzxpl/BzhTaFAvI4lb41123iDJyPBawLsfCTEPlNAX8zOEfR6r3yHNZLNFtUIBlU343wWc77vkVIYqNY6XMCjwDJU11SSBXNP13dbJE4IxdsZ47jFdgh+lG516nYzz4MnXjMaI+hEh3VXsaq4Muu5Gcr0mF4SKxjb6gsNr7QjVMejhymDD/Oo8xelGgqERmWUdVMMiNVZqDWg516ji1y8KQMQdPZbzvK9XCXIviGqt+R5X4DOcBmENgfI5pHhihftAQ2M0AADwa/lJuHQHz6Er6J0bzacE2DNQ8ED9pvuhvkmf9JrcfXkPRPaBvnqv5Pkd+8sljtnY28Ui5ErbXjfVcjm5LP/Crlx18G4bZto+AUQ==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(85182001)(66556008)(66946007)(66476007)(5660300002)(6496006)(956004)(82960400001)(508600001)(186003)(86362001)(6916009)(2906002)(9686003)(26005)(316002)(54906003)(83380400001)(4326008)(38100700002)(6666004)(6486002)(8936002)(8676002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dE5Ob012QVgrb2x1cHBhQVZYaGFIKzRaeVJVcEVWbjNudU93VXRKZXhzWUx5?=
 =?utf-8?B?T0lGZnlzWEl2WjZjazk5cWxjSDZMd0F1eWlJUEZkMHJKRHpRZHpQcnMzajlM?=
 =?utf-8?B?Z1lobkxFamg3Ync3dlhtcTE2c1pCNTlyaFczVmtxYWpId1N2a3d5SkFyWE9V?=
 =?utf-8?B?MHo3NFNGZzU0UldmcmdvV3k0WWg3R2xYMVR1SUxtMzBLUTlVQ041amFJMnNG?=
 =?utf-8?B?dDN2c0FmTS9UbFdCY0o2N1pYd2JnZXJMclpadVQ2N0RNRDgrZ1M2ejJhOGtu?=
 =?utf-8?B?ZXBFU3NVNE5YNGtNYXhWV3hqYVZEQk5jSlFPRE1XWUgvZWZ5RnU0QmM1OUhm?=
 =?utf-8?B?d1ZIUEIxc1ZxZkdaLzRxY1hGY3RQcVlCRHdZcjdUZStBWXN1My9pTm45ejVE?=
 =?utf-8?B?Y0lSRHRlVkdjdVRwQTRkazcxWGVrMWlDelAxWDdsNDU5cGdOaW5NS2JtZlRm?=
 =?utf-8?B?NWlSWFZlajFGQVhkZlR4ejJNQzlNd3VrdkJjdEVxWW5UTVpoMnRHL21MM24r?=
 =?utf-8?B?NXpTTFdEWUcydXk1WVFZcWR6TW4weVcyRFQ1RnFzZ3FpV0lRUndZRWJQUDhp?=
 =?utf-8?B?Q0gxdnByazlDaTJheVQ2UVN5ZHBOQ0VQbHAwVmZ1ayttZW95c1dlV1ZYOTVE?=
 =?utf-8?B?aEx4TlJLVW4vK0RyK3AzRitiTEhkZlVxNU1yVmtvcW93V3haNjk3MkZFVFNP?=
 =?utf-8?B?U1M0dWZsZno0ZjdvcHA4WmgvNHBIZVpZemg0WVhSQ3l4S3ZOaTNCaE5oQVEv?=
 =?utf-8?B?TkRyTmllZVlmb1E2TnZOWmtuTkpPVGJZWllvUHdHZldnd0ZCT0VFbFRoNUJk?=
 =?utf-8?B?dWMwUko1V2h2Vm1hcTd6ZFJPZk55d2J0WlFGbEh0K1I2TWc2dGVPTSszTFlP?=
 =?utf-8?B?U1lPZ01DNTZucVo3ZFVnSEFjNERBRHh5SGFiM1RBMDlEOGI0N1JWSldSUUpX?=
 =?utf-8?B?eis4L2JYNWExV3VYLzhxd3B4ZFN2S3gyK3JjZVJwNUdoVUVFSkJFYXFSL0E5?=
 =?utf-8?B?SSszRFVNc3R0Tis3OGcvYWVKQ3NwN0JqTlJKNEJraVFTVkpsUUxCb2JwTCtG?=
 =?utf-8?B?b2VpTlMzcXVnVjVDWjRDbnltS0NveHdJM3dac1FXbnNQZFZPS09Nd2ErYVlm?=
 =?utf-8?B?MlU3dFVxV2xnb2RVdXk5TGpTUE1IWlFVVFBPalBlNnJ0MllBMmNjYXRmZE1L?=
 =?utf-8?B?MWdiTjJVaEFqWmdscDhpRTRHUi9waG5GL0tUaTBZRmhNSWhoMFkxZXAwWDhk?=
 =?utf-8?B?c0J0STkrNlRJV29na2NGNHJ5bnIvWUg3VDkrRWk0SjI0UFZnaFZDY2RaU3Fa?=
 =?utf-8?B?Um1EZlNJNDMyN2M2R2Z3dE1PdUdBYUpvdEZhRElsWHBRYWIrYkROOVI1endw?=
 =?utf-8?B?RGJhUzNVVVZVNE5taCtqUUdrWEdhYjlHcytTVmU5WXlic2E1eU5TN2RnVVE5?=
 =?utf-8?B?VUllWHRKL3JoQVBvRGZEa3ZXWngxODY0REltR1htSzZQZ0k2SisyRWVYMUxy?=
 =?utf-8?B?bk1HMmNvYUE3L3psTWxNSzE2OW1QQWtHMXVZeUFZRkkyc01NQmFLbWcxVVFC?=
 =?utf-8?B?bllCdUc4em9oK0VGUVlBaHNGS1R6RVdXK1puME56K3NTQWVzK3VCZEUwRm5G?=
 =?utf-8?B?VnBBQVRiZG1jR21uKzdwaDBGV2xTOUF4UUo4Qk00MUpqNWN5RUtpU204YjVl?=
 =?utf-8?B?S0hORkNWZFJ1NTA2aDNzTHoxWG1uUEpTaWJMaUZaMm1IUk9mbi9MZzJYUnQy?=
 =?utf-8?Q?YqtZeKtRaMwpUXjydV+ywIfse7hdQk9pnej9WQd?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 8561a73e-9e91-4908-eeef-08d992417b0d
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2021 14:13:38.6816
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1FJIjIZP0LI1WgSnunRckaVe7KXgOETpXgaPyY+jC1H3qsgoqJZypIU1z76AUvP/gI/xqu693Rg0+n1J/7KO0w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB3210
X-OriginatorOrg: citrix.com

On Wed, Sep 29, 2021 at 11:42:34AM +0200, Jan Beulich wrote:
> The conversion to __get_guest() failed to account for the fact that for
> remote vCPU-s dumping gets done through a pointer obtained from
> map_domain_page(): __get_guest() arranges for (apparent) accesses to
> hypervisor space to cause #GP(0).
> 
> Fixes: 6a1d72d3739e ('x86: split __{get,put}_user() into "guest" and "unsafe" variants')
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> ---
> Using get_unsafe() might be an option as well, instead of the added
> extra conditional.

A third option might be to place them in a non Xen private VA range,
like we do for the compat argument translation. That's however too
much IMO.

> 
> --- a/xen/arch/x86/traps.c
> +++ b/xen/arch/x86/traps.c
> @@ -275,7 +275,9 @@ static void compat_show_guest_stack(stru
>      {
>          if ( (((long)stack - 1) ^ ((long)(stack + 1) - 1)) & mask )
>              break;
> -        if ( __get_guest(addr, stack) )
> +        if ( stack_page )
> +            addr = *stack;
> +        else if ( __get_guest(addr, stack) )
>          {
>              if ( i != 0 )
>                  printk("\n    ");
> @@ -344,7 +346,9 @@ static void show_guest_stack(struct vcpu
>      {
>          if ( (((long)stack - 1) ^ ((long)(stack + 1) - 1)) & mask )
>              break;
> -        if ( __get_guest(addr, stack) )
> +        if ( stack_page )
> +            addr = *stack;

I don't really have a strong opinion regarding this or the usage of
get_unsafe. When v == current we have the extra protection of being
sure no private Xen mappings are accessed, but that's only for a
single vCPU at most, at which point we might just use get_unsafe
uniformly. I guess I have a slight preference for get_unsafe because
using get_guest doesn't really get us anything.

If you keep it in the current form, or decide to switch to
get_unsafe:

Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Mon Oct 18 14:13:58 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Oct 2021 14:13:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.212338.370184 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcTOo-0005Tj-5n; Mon, 18 Oct 2021 14:13:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 212338.370184; Mon, 18 Oct 2021 14:13:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcTOo-0005Tb-2V; Mon, 18 Oct 2021 14:13:58 +0000
Received: by outflank-mailman (input) for mailman id 212338;
 Mon, 18 Oct 2021 14:13:56 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=628V=PG=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mcTOm-0005Bc-Fq
 for xen-devel@lists.xenproject.org; Mon, 18 Oct 2021 14:13:56 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id a00f52b8-301d-11ec-82d8-12813bfff9fa;
 Mon, 18 Oct 2021 14:13:54 +0000 (UTC)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2175.outbound.protection.outlook.com [104.47.17.175])
 (Using TLS) by relay.mimecast.com with ESMTP id
 de-mta-33-Cka9Klx-NceJk3UukOrYXw-1; Mon, 18 Oct 2021 16:13:52 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB5599.eurprd04.prod.outlook.com (2603:10a6:803:de::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16; Mon, 18 Oct
 2021 14:13:50 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.018; Mon, 18 Oct 2021
 14:13:50 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM5P194CA0009.EURP194.PROD.OUTLOOK.COM (2603:10a6:203:8f::19) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.16 via Frontend Transport; Mon, 18 Oct 2021 14:13:50 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a00f52b8-301d-11ec-82d8-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634566433;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=v4UBt0tHYIUOZn7Phc8rFXSXuyoOkRsORQ2YoIW36KA=;
	b=PF/AQER/YHmBtVJyRNLpJtjMFu1m6nGdsULX4u5IfzD9u23Hf1iOwLBp9xC6ex6KsHGXxE
	q93OHm0Jr1Lvc6MpGcuYMVbnYtWo5fm63fOIiKbs/M/a2e0SMowMFQKsougW52eq5O1ss2
	3iGPixISBxcFGowf7PAy7vt2O1BVbcM=
X-MC-Unique: Cka9Klx-NceJk3UukOrYXw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=QSV10rQIS44so6poFafC3eu1kgOaqgZ7nLOwl9FeiNRRaNyRkqS0p2sIW98jrL2ffOZ5Gs0lcIP3iXSAR6lQUv5AdKZaZACSZDwpp96TrSONhz6qJz1bHi4G9yvUMbOCUmnDyP1g+qMR4R3tvHqKnwu66hhxGF/2RUxUM3jArszXTUbvEtvIotKTx6g0TAMoKPkqbc4p2v3a1oZUSfL9v7UuOPdRv+4DOYKKQ60pCH4N13QyHJa3bckg3vEKYt3nfXzO84tTJJp1mdsDU0seg0IyOOY1etPBnxaEUPpbzFPum7B/oPCsMEO1WfedqRVqzZQGSutfIi13KzBWFBEbpg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=/OrEeaixkF0Y9PlxWXxua5NQ52g/p32JvW5cL3gsTB0=;
 b=LEClWOSlZ3Y9km81RjiesPeaKQSNW7GA3P4lEV4I11FgCgA14UBKbg5NkpEVGsW7O1O6qTvZz9lJaBqRO3QO7r5rypr+tsXUdlJLK8Z4bwL2+EB5Apucp9N2xoBnIaNj8v0ztplJrZxG3/geCxfa3+xJyvA2gUWlzQLuTvABTIx0bZd8imzO54oAeqCGy7AR3+e6I3mHa9sEEj2yZlSUPyhv7uxh9JjAQnlMyVieNQRMfbgueJdWLGf0ERrQuNIKVij4X7knt+WZJY5W9H4bMV+C2pgeQNSIg7YGYubi1q4lghiI7lW2PmBKvY4V+4DcgzCnJEmAFU7lLxyCqHa1Cw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: xen.org; dkim=none (message not signed)
 header.d=none;xen.org; dmarc=none action=none header.from=suse.com;
Subject: Re: [PATCH] x86/paging: restrict physical address width reported to
 guests
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
References: <e0acfa40-0901-2fc9-31b6-c2609625de22@suse.com>
 <YW16sQI1WmegDkwN@MacBook-Air-de-Roger.local>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <62aa184b-d712-76f3-b6fe-fdda164c3442@suse.com>
Date: Mon, 18 Oct 2021 16:13:48 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <YW16sQI1WmegDkwN@MacBook-Air-de-Roger.local>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM5P194CA0009.EURP194.PROD.OUTLOOK.COM
 (2603:10a6:203:8f::19) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 981d1206-51ef-4dcc-7db3-08d99241823d
X-MS-TrafficTypeDiagnostic: VI1PR04MB5599:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB55991B127D2DEFAB2DBB556FB3BC9@VI1PR04MB5599.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	PHhTugAfG1Szy4Q44nLnw9GnrTSDHjh0NFYLYm/Yd6hKcYAHhEPc0wL+8f7w1CjTkpFrVHbUwqneR70lssIWcKkb2Lk0tsJzHXw6FOKgwK36Ed6IWWf/yblwhqJDAz966A7LVqCcnDYgUjlt0COBeC6G+uqq1Vkbuu6qsyLraFno4L49yxE9V+gdBtBfQI2Moxoa7WN2Flyp3gMqp/AbHml/rMo6fYlG0gaaC3ydXpXBnbs1y4ujXtYPhSvQZo2RGWwo0pOcrna5kbWIpucJ92HsYb26IsOhRyD6bZX4R7vHj3/MvsAM078oAVPO/qc1dpJFH7+skd708pvDZhR4SNs5ECHWfnASFwUXmcp4smX3kisxCJDTIGXqqz/2Ks1lztLUBjdnybmCX2ZvOoJLdEpGCC53PT3I3+R+pT5erFAlf9TETgd+hffrW+MUw/I9uvrA7qJyxfop8BXa5NuI9oqcGW9c71EzvcaOAjGT92nJwRnmXbSTOHgXUbLZ/ZzMZ/tCsu7DGh1WvBi1pzD/gRspXrT1Os3XKuJRCvj55ErI+3dSRzC1w7sNP5WtOU2U+Fi0sGJR+bSqcIPrHuIZ0PgNK0zY/PeMl9DtXelNcT91oWTjz1QDt6ddYl/rPk26X0U/aXjAhwR14YWaFS2z5A9neAojbA3DiZC+e09pT9Re4CDhL7+/7a7OLaeYqbDGyddRu7NR9xOvJYdjYLWjRWibVTKFR9zNaO79Vd2sFZrRGJY7zjWXB9Sfc4ulRpto
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(508600001)(38100700002)(6486002)(8936002)(31696002)(5660300002)(86362001)(16576012)(26005)(186003)(66476007)(66946007)(66556008)(54906003)(31686004)(2906002)(316002)(36756003)(2616005)(956004)(8676002)(4326008)(6916009)(53546011)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?tMFLUaDPh8MgnNZpbJa0HKKng19KK2QAoN0dyxjsDH4ElmNRWoZQqZX9QObY?=
 =?us-ascii?Q?ivzMj44JY2NNR/57VeYarqmLUkx7N5y9oixsvtF8X+s7fTHz/x9hDGf3zu47?=
 =?us-ascii?Q?gZy1xE4Ls9jVuNhRka/RjkY/MPK8u57Wbg9Jgrhc3NmCsMgF3pS89u0uo+2m?=
 =?us-ascii?Q?HwsY6GCu5mKwWmRwOSNzjtjLONZRTeD1qCG+8g3Tm4BxsWDIR/aogZBDODhc?=
 =?us-ascii?Q?KoZjfSvjXRb+O7D3i3w9gq5zTI2uXkv0sz1mcwX5HnTiT93PCgSOUhZY0iaR?=
 =?us-ascii?Q?j2cqGAuSQABwEmTPzrlsGhVGJSk9tsTQD2ktR827narEhKvv8b9+bzgwDNFH?=
 =?us-ascii?Q?4E3c5f0CMw0+3o7FYtgTnGqbd4nPyUa/pznrN2mYNzKEtU95yfNEbWV21K76?=
 =?us-ascii?Q?YElOLWLGZ6pmFBnt8GvLvck9sHmXpKH3Zv9ScJ7hUYTGyS+UWfUVgwM1tF9p?=
 =?us-ascii?Q?UXVO74WmmrOXKMPUtBe8Bp8mn5RfrKFugegVUJJPPrrBwVIIPjr7/kh4DFo2?=
 =?us-ascii?Q?V6gS67ARcntqUlnCOTxhHpS5iM0wgBQr0L9MTkqwQLyOx4K6t/n46zhez5bB?=
 =?us-ascii?Q?o7zSVSiyvO+9OvFivaNY4tNiHfDwjZJZb5QrBiQjRiKY7iqJ1eypfVM5gK3o?=
 =?us-ascii?Q?Gsx+KxQ032xVmWZKaHZLKCR6Ht+z899mZ4/R1ZotCVHPMEaSdh0jSm4AUHi1?=
 =?us-ascii?Q?qRjcSgtjLhIaitoxEygm7SLQ6URJB04s5ZItVRXjBGIP48rypfnFFgdlXKuq?=
 =?us-ascii?Q?z0hv17xoyn2MTJYJWdyPtVfjkS0TrAkAmC2Agv+1HZjqPAf8FGRhNxqvQXJg?=
 =?us-ascii?Q?s8xT6t8X7RkY0bbjb3coxF5/sc3CIReyuqJ6ID+JU1x4J2xZg4rkED1necff?=
 =?us-ascii?Q?gX+ZZGrL2853axhCxMfOBZlFKTJ3sWmpeyH5ALbdp/2oMPmWmlZTxfnV2QgA?=
 =?us-ascii?Q?/AufxGFVbgxeCb7BEL9Nutwwn1ldtaeSyz6hEniqNjU3xCKvspB3gaQ8VXlu?=
 =?us-ascii?Q?+kRZht1uuNXSLNRVKx4BFNFhGMyoMr7okAypxoeegDj61qgVVvQlpSrf5B5d?=
 =?us-ascii?Q?4VrelN/U89bthGF8SLWbHLhtnoyN8B6DZmlFKerJeoK4zSlgTcxV6KCggcYB?=
 =?us-ascii?Q?2zUstmTi6aEa8YdiJjkEo7xX6Df3UDSMG7TYWBCX/ypdVQpNbL+ytGeI1avq?=
 =?us-ascii?Q?QwZhcZvVvLgLeR0KbY3C/hxXGRuy148ZvjLshdx7sYu9YVIwa5H6iN+5rgqE?=
 =?us-ascii?Q?tucAYNKK4Hq1so9wMIIDzax5gIUpElOtbZymnx4SGKtARQTif09kTy6m3arK?=
 =?us-ascii?Q?FnW/KgHdxeEV2Pemz950JEk3?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 981d1206-51ef-4dcc-7db3-08d99241823d
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2021 14:13:50.6352
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: HBJLRtAYbIUUIK/FAf8DwrWSVfXqHl0nBO5P2QlarulE662EdFYbKc4fmR9cPa6Nk89FIlPPzTyVEaIc7RbpMw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5599

On 18.10.2021 15:46, Roger Pau Monn=C3=A9 wrote:
> On Wed, Sep 29, 2021 at 02:47:49PM +0200, Jan Beulich wrote:
>> Modern hardware may report more than 48 bits of physical address width.
>> For paging-external guests our P2M implementation does not cope with
>> larger values. Telling the guest of more available bits means misleading
>> it into perhaps trying to actually put some page there (like was e.g.
>> intermediately done in OVMF for the shared info page).
>>
>> While there also convert the PV check to a paging-external one (which in
>> our current code base are synonyms of one another anyway).
>>
>> Fixes: 5dbd60e16a1f ("x86/shadow: Correct guest behaviour when creating =
PTEs above maxphysaddr")
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>=20
> Reviewed-by: Roger Pau Monn=C3=A9 <roger.pau@citrix.com>

Thanks.

>> --- a/xen/include/asm-x86/paging.h
>> +++ b/xen/include/asm-x86/paging.h
>> @@ -401,11 +401,18 @@ static always_inline unsigned int paging
>>  {
>>      unsigned int bits =3D paging_mode_hap(d) ? hap_paddr_bits : paddr_b=
its;
>> =20
>> -    if ( !IS_ENABLED(CONFIG_BIGMEM) && paging_mode_shadow(d) &&
>> -         !is_pv_domain(d) )
>> +    if ( paging_mode_external(d) )
>>      {
>> -        /* Shadowed superpages store GFNs in 32-bit page_info fields. *=
/
>> -        bits =3D min(bits, 32U + PAGE_SHIFT);
>> +        if ( !IS_ENABLED(CONFIG_BIGMEM) && paging_mode_shadow(d) )
>> +        {
>> +            /* Shadowed superpages store GFNs in 32-bit page_info field=
s. */
>> +            bits =3D min(bits, 32U + PAGE_SHIFT);
>> +        }
>> +        else
>> +        {
>> +            /* Both p2m-ept and p2m-pt only support 4-level page tables=
. */
>> +            bits =3D min(bits, 48U);
>=20
> It would be nice if there was a way to not have to manually change the
> values here if we ever support 5-level page tables for example, but I
> don't know of any way.

Well, I have a vague plan, along the lines of "IOMMU: have vendor
code announce supported page sizes": Once the value isn't constant
anymore, vendor code needs to supply it.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Oct 18 14:19:32 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Oct 2021 14:19:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.212353.370195 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcTU8-0006Zr-QF; Mon, 18 Oct 2021 14:19:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 212353.370195; Mon, 18 Oct 2021 14:19:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcTU8-0006Zk-NJ; Mon, 18 Oct 2021 14:19:28 +0000
Received: by outflank-mailman (input) for mailman id 212353;
 Mon, 18 Oct 2021 14:19:27 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=628V=PG=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mcTU7-0006Ze-OM
 for xen-devel@lists.xenproject.org; Mon, 18 Oct 2021 14:19:27 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 65c4b714-301e-11ec-82d8-12813bfff9fa;
 Mon, 18 Oct 2021 14:19:26 +0000 (UTC)
Received: from EUR01-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur01lp2056.outbound.protection.outlook.com [104.47.1.56]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-35-_TyS0lhyNJuCUH82H_6Wkg-1; Mon, 18 Oct 2021 16:19:24 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0402MB3392.eurprd04.prod.outlook.com (2603:10a6:803:7::26)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.17; Mon, 18 Oct
 2021 14:19:22 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.018; Mon, 18 Oct 2021
 14:19:22 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM5PR0502CA0012.eurprd05.prod.outlook.com (2603:10a6:203:91::22) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16 via Frontend
 Transport; Mon, 18 Oct 2021 14:19:21 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 65c4b714-301e-11ec-82d8-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634566765;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=WtHjRJ5yE0K4RfhuQE8jW1K6AaQIVbvo76d+uTdWq2I=;
	b=jOl06+oiXnUQ7p1XyOY8BlczKuH5uEX4MCv7rBLJ80JmxxUFalUdxCTvDAB90kaLF/vPRG
	AzZpb5W0qQb/lo1DrT6Nj6JDOBa0CzCu2qvypuOBwyCcoi9GpARwR2cbb80HP+bEal/XEe
	gSc2t0QOk46hgESqw4G3OY26imwLot8=
X-MC-Unique: _TyS0lhyNJuCUH82H_6Wkg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Zbj2/hXHRZ9uZuy/ok/9Yotkcn4RxQ1anzbCU9KwrwnagSTbgN/sPwGwEVC0k2BuH+LPeOcyE97ykPXi+hB55/wPOQu/5ENT0PJL3icg44XX/1ueulH7+7kNEuwSh4o7e3Sf6M7WYgwr661nkiqZqyJ0OvY3siEPz8706ziLxCv9WoYQ2ogKBn9zQEDbu9CMPFvMssV48iZIDIG+t/ZsUvq4dLxLvJVxwgmKGK23kOb+Ywo0v9GfjxZOLC3Wzj/Rpd1/+bE8qIu4Ed8J4GHlT+z3ZLq8Z9Za9ZDJm0KQImdH2CamPRITU9Z3R0srw/G4HjLSqlpEbhSJv7elnOPl9Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=WtHjRJ5yE0K4RfhuQE8jW1K6AaQIVbvo76d+uTdWq2I=;
 b=Pz8jEA1uILPoKeczXHRDikkI48KOSue+IADdHCveo4BgXKhVaBy4S1YLG3KfS7hb4ze05aOMd8ACl4HbUu/o9wNfTPdlQtsXey60GpsNhsb+CqtzK3839cVZ70gCU1qTSU+hPJ+didop988RzrB7zxDMPepo58qZ5b0trcRpx8R5XxyD1VXdynrMmL8J0ieM58vIgV6Abl86p8XcwzpNcM0ylJCISKRy8b9rPaf0/n8gIGH4Ivot/namCzgvMDkARqkLI3pBJfYGECu/xVs0viHbv4t56s0r1EeALCcjBlAd1tQ+9cHal2dBftt5C/3L91uvYM2qxRmCG/cvyg5neA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: xenproject.org; dkim=none (message not signed)
 header.d=none;xenproject.org; dmarc=none action=none header.from=suse.com;
Subject: Re: [PATCH v8 2/5] xen/arm: Enable the existing x86 virtual PCI
 support for ARM
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>
Cc: Rahul Singh <rahul.singh@arm.com>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>, "sstabellini@kernel.org" <sstabellini@kernel.org>,
 Julien Grall <julien@xen.org>, Volodymyr Babchuk
 <Volodymyr_Babchuk@epam.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
 Paul Durrant <paul@xen.org>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Ian Jackson <iwj@xenproject.org>
References: <cover.1634315461.git.bertrand.marquis@arm.com>
 <e2b10f56043155e4bb8eae824723045ccc042f8e.1634315461.git.bertrand.marquis@arm.com>
 <ca5558b2-25c6-90d2-284b-03cbbb02691f@suse.com>
 <FBC4FA6D-AF07-437A-BD81-52708B139070@arm.com>
 <8c99e635-9509-b078-2285-48fb6fb91507@suse.com>
 <46bcd42f-df4f-922a-cc21-a05821481754@epam.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <17fd4f89-9afa-f65c-c66d-1364d7474969@suse.com>
Date: Mon, 18 Oct 2021 16:19:20 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <46bcd42f-df4f-922a-cc21-a05821481754@epam.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM5PR0502CA0012.eurprd05.prod.outlook.com
 (2603:10a6:203:91::22) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: ee2dd4a3-0177-4aca-2d37-08d9924247df
X-MS-TrafficTypeDiagnostic: VI1PR0402MB3392:
X-Microsoft-Antispam-PRVS:
	<VI1PR0402MB33926C2E8FDAA8075E0CD039B3BC9@VI1PR0402MB3392.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	1EYEwMJWjfDIhCgSGvvOXrIywkxmfl8JRrMyNF0S33BswGwH8yeHxSZDPSR3MsybGTbizjCHZ/giKl1UnxD1Z+0S56asgLH4GmP+N05fbHEZRKRSD9jQSCK+3cM1N9LORABGG6+uO65j+EOc7Jk18oIdXeuTgg6I2wKxOV7OHSLRXUrhtoX6WW71fEzSOIEVxJwGy91zk2m8kZUrEuBObEmlZC810jM/SCW2bEMp6PdF3pKIpVbGMXAT8MlEvGacejmTx7khesmcUVFvF/9fj/PXlykj46kZSNIJidN/ZEQrbmg2kO2dFU+7zlxBsjN5O4ucDOenkKqcCG5OCag9mP07E5Wu2VFyA9V61ZSYomDpU8fPsDaLjmXRhedTvQd6UiEX3ZeuzFQIZ+e+/Hh3DDaZ2loDZAPnGIhQXiyfwHtaWZR/xGTWdDEe6EiMqU6VPAVBBFwEeDvYUDrc0S+/85A9j+nGEf9mt4SFVoW0LrJwhrdI+3f67MHAZqvn9oHLXz8gvXG7Hm/C5wI8D/ubdksPTjsn5gFl4AWMEou3JsIiMh+0vHkPf6YT+U3m06FTcEUVLgDYLEzLXNKzZgKeG147ANaHckbr+kjGb1ESzGIUSBOU2Kvn44Uk4hkOO4O6Ixt5SOlrDWhwSe3GGsIzIKdbU1gIdhbRDSYB7P/fIGJdk5K1bpJG3WM4rHzXOtgkRWm0qCOeRNy9UnRHFODlkTEuK4rtb5lUtz01OkPFLV6VomcWYo2pR02a9rOMc8BXI9sW5y/4H3A79aNjP1oJat5OW74uDuqFHHqi1foDnYZ6+1wZwRdvnqbkjtRzEc+lo9nG9sKh1doTSQNVXGdETj3SvjYxTJveyBuB1iQ3RA8=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(956004)(8936002)(186003)(6486002)(26005)(2616005)(31696002)(86362001)(36756003)(16576012)(8676002)(31686004)(66476007)(316002)(66556008)(966005)(66946007)(54906003)(5660300002)(508600001)(7416002)(38100700002)(53546011)(4326008)(83380400001)(110136005)(2906002)(2004002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?N0R2OXdCSElJQ0Z1SnJOK292SlZaU1NLbmxyQ2tHenRKMmZ0UUtISmtPMWZS?=
 =?utf-8?B?Q25aV0l6Nmhzejc2ZEtBc0FZSy90TE9KZzErQXlTcldab2hxSk5Ba3dldDBM?=
 =?utf-8?B?ZEJET3dvWm9ZaUYvMG85Z09qSThpUW9Bc2Y2ZjBNelFTYmlEdXhINUYrN1lp?=
 =?utf-8?B?aStTSjlCSmVxVTUzbzZ0M1ZDbStNSHljK3R1NXhET1pocVE3cDVWdjdHM3BL?=
 =?utf-8?B?cERtQUcvK1U0aVhBVUhwaUVUc2s1cncvZVNwMXQ1VHNubjBTaW84YlQzQ0xs?=
 =?utf-8?B?TGJWd09mOC84NXdkU1Y4dUI4Uk5QRlpZZnNGRjdoQXQyYyt5TWtvdXVBQmEz?=
 =?utf-8?B?RlZlUlkvMysxMkplaExIc3VFcFdFR29Uc3lPRm9ab0RTamp2MHUzZGZ0Zlpu?=
 =?utf-8?B?dm8wOWIwdkpwL2xucEgwVXhTYWVQMzZrSzlHQWVvSUVaNlJuQy96bXFXNGRo?=
 =?utf-8?B?MmUvdnF1b3dEa0ZJKzdtdmJ1V0dpUFppa3FUckJzYkNvT0tMdit2MkJ1TmZ1?=
 =?utf-8?B?Qk1LdTlyMVIwejdnMnRLckZBNk8yL21wS2dRRlVweU1aLzAvS0ZLckZwZnNY?=
 =?utf-8?B?emxwaURTSS8ycXE1S1VzbjJUdUcvMzF4SUZzM2RpY3ViMXl0djQzeXdDWncr?=
 =?utf-8?B?Z1ZUdFNFaDJtVkhIalRabjZaUGdJcE9WNkVGT3hiWU05MjBxdGJKL2pHMlRq?=
 =?utf-8?B?bC9xNU8yOE5XUHM3R1RidWd4Lyt2SHRldWp0K2dhUVlMRVJhSm5EN1gvSEY4?=
 =?utf-8?B?NU5wYTlHOHpOL2pWbzB5RUVqb2tZMjRJZDJvUFAraXZWUWc2STJ6b0U0L004?=
 =?utf-8?B?OFNSdm53QzRjd0g0WHZBMDR6amoxdHVzalRadjNiYmw2a1drL3pGYzNoaW01?=
 =?utf-8?B?NTNxbFB4akRqOFdnL1pMb0lQNnRkc3hsM3pMa3o0eEovdlhjaWpyclZUUXZC?=
 =?utf-8?B?TGdrYlVzdGsrWU9OSXRZUkJYWExkY1dEc2RyTGNiOGJpRE9PNlFhK0ozd21p?=
 =?utf-8?B?ay9PQmFIYnMyQVVoUHdSWWRBWXd5cVJCdzIyQWhiMVMxRkRKNGc1VEdCQ1Fq?=
 =?utf-8?B?VWhFZ1NWbUZ5NFd2RGQ0UEkzeDRvN2YwOXVKSW1aSlhrV3MwWTc4dDVWcmVB?=
 =?utf-8?B?YkMzc2xKOFpmTWRnMXdNTldhYzlHNHpPVjZ2dmE5NndDS3oyVFdBY3FBcXJL?=
 =?utf-8?B?Y0l2cUlvb25mZ0RRRjBIbGN6WnNibVZGLzNmd2xLVS9USkZ6T0FoaUN3Uk80?=
 =?utf-8?B?YW1QelRxdkM3b21LRGxRZnB2L0xZbkR0U1lFb1djSFVPdFI2QjBFV2l2T3Rh?=
 =?utf-8?B?ZThQdDZPWVh4SC9KUW5KNVVrWEo3dEFzKzUxelJybFFobUxISW13TGVUbTNx?=
 =?utf-8?B?eldxcVl3QWRwYVNLYldDTWprUElKL2x1aEt2WFNqVkxhczN2cWJTZU9qZy9G?=
 =?utf-8?B?NVE0TDFtdVlqYTBDM0d6MHJpRC9XdW9FMy9aSEdrMWVLM0xiZnBpTEV3MEFs?=
 =?utf-8?B?RldjbTNMVVJnMU9CckpNa3BnVEJZenBkK3l4Q2oyQ2ZTc1c2MUV6QW0za3dE?=
 =?utf-8?B?YWIzUGh5cXJnR0N5ekJoZkd2cG0zRUkzSDd1NzZYcU40bTlEOW1MZzd2aHRs?=
 =?utf-8?B?MzRqT2VaLzRWNVhlQWNaMFcxL2xid29mODNybm85TS9wV2pYRlVXRkVVYkFr?=
 =?utf-8?B?ektSMSsxSEt5UTFhcVJHZmVOclRuSWNzUUZQT0Z3UkczSUlGaWhWbm1xVTFL?=
 =?utf-8?Q?wYnmh+9XfSzgRAe/ioO2Q6cZupVrc+N2LTFmixW?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ee2dd4a3-0177-4aca-2d37-08d9924247df
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2021 14:19:22.2290
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4ULIaLZwFk+/ZHOL3Hr+ofTKh9RKRuoDjYuAjW1Wo+PhjZlqXjik58K+AexAHCLdUFHjkl5huoHcvFLAlbu8uQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3392

On 18.10.2021 16:07, Oleksandr Andrushchenko wrote:
> On 18.10.21 13:29, Jan Beulich wrote:
>> On 18.10.2021 12:11, Bertrand Marquis wrote:
>>>> On 18 Oct 2021, at 08:47, Jan Beulich <jbeulich@suse.com> wrote:
>>>> On 15.10.2021 18:51, Bertrand Marquis wrote:
>>>>> --- /dev/null
>>>>> +++ b/xen/arch/arm/vpci.c
>>>>> @@ -0,0 +1,77 @@
>>>>> +/*
>>>>> + * xen/arch/arm/vpci.c
>>>>> + *
>>>>> + * This program is free software; you can redistribute it and/or modify
>>>>> + * it under the terms of the GNU General Public License as published by
>>>>> + * the Free Software Foundation; either version 2 of the License, or
>>>>> + * (at your option) any later version.
>>>>> + *
>>>>> + * This program is distributed in the hope that it will be useful,
>>>>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
>>>>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>>>>> + * GNU General Public License for more details.
>>>>> + */
>>>>> +#include <xen/sched.h>
>>>>> +#include <xen/vpci.h>
>>>>> +
>>>>> +#include <asm/mmio.h>
>>>>> +
>>>>> +static int vpci_mmio_read(struct vcpu *v, mmio_info_t *info,
>>>>> +                          register_t *r, void *p)
>>>>> +{
>>>>> +    pci_sbdf_t sbdf;
>>>>> +    /* data is needed to prevent a pointer cast on 32bit */
>>>>> +    unsigned long data;
>>>>> +
>>>>> +    /* We ignore segment part and always handle segment 0 */
>>>>> +    sbdf.sbdf = VPCI_ECAM_BDF(info->gpa);
>>>>> +
>>>>> +    if ( vpci_ecam_read(sbdf, ECAM_REG_OFFSET(info->gpa),
>>>>> +                        1U << info->dabt.size, &data) )
>>>>> +    {
>>>> Here it is quite clear that the SBDF you pass into vpci_ecam_read() is
>>>> the virtual one. The function then calls vpci_read(), which in turn
>>>> will call vpci_read_hw() in a number of situations (first and foremost
>>>> whenever pci_get_pdev_by_domain() returns NULL). That function as well
>>>> as pci_get_pdev_by_domain() use the passed in SBDF as if it was a
>>>> physical one; I'm unable to spot any translation. Yet I do recall
>>>> seeing assignment of a virtual device and function number somewhere
>>>> (perhaps another of the related series), so the model also doesn't
>>>> look to assume 1:1 mapping of SBDF.
>>> This question was answered by Oleksandr I think.
>> Yes; I continue to be sure though that I saw devfn allocation logic in
>> one of the many patches that are related here. And I'm relatively sure
>> that there no adjustment to logic here was made (but since it's hard
>> to pick the right patch out of the huge pile without knowing its title,
>> I can't reasonably go check).
> Offtop: I was somehow dropped from the Cc..
> 
> Please see:
> 
> [PATCH v3 10/11] vpci: Add initial support for virtual PCI bus topology
> [PATCH v3 11/11] xen/arm: Translate virtual PCI bus topology for guests
> 
> [1] https://patchwork.kernel.org/project/xen-devel/list/?series=555481

Ah yes, this way I can find them in my mailbox. And indeed - no translation
from virtual to physical SBDF on the config space read/write paths afaics.

Thanks for the pointer,
Jan



From xen-devel-bounces@lists.xenproject.org Mon Oct 18 14:25:18 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Oct 2021 14:25:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.212362.370205 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcTZg-0007zB-Ef; Mon, 18 Oct 2021 14:25:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 212362.370205; Mon, 18 Oct 2021 14:25:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcTZg-0007z4-Bf; Mon, 18 Oct 2021 14:25:12 +0000
Received: by outflank-mailman (input) for mailman id 212362;
 Mon, 18 Oct 2021 14:25:11 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=628V=PG=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mcTZe-0007yy-Ua
 for xen-devel@lists.xenproject.org; Mon, 18 Oct 2021 14:25:10 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 3261c6a4-301f-11ec-82d8-12813bfff9fa;
 Mon, 18 Oct 2021 14:25:09 +0000 (UTC)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2106.outbound.protection.outlook.com [104.47.17.106])
 (Using TLS) by relay.mimecast.com with ESMTP id
 de-mta-3-kOy1Nm5cPoykAuiiSnf9mQ-1; Mon, 18 Oct 2021 16:25:07 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB4351.eurprd04.prod.outlook.com (2603:10a6:803:49::33)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16; Mon, 18 Oct
 2021 14:25:04 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.018; Mon, 18 Oct 2021
 14:25:04 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6P193CA0062.EURP193.PROD.OUTLOOK.COM (2603:10a6:209:8e::39) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.17 via Frontend Transport; Mon, 18 Oct 2021 14:25:03 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3261c6a4-301f-11ec-82d8-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634567108;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=vmXPEYI93Z+HoVnhHT0BZ/msEXOKkXE/W062/8hOBj0=;
	b=Y3CXrHcp+BBxqXXoi19j5XOqk+OxkTIwadW/pjYy+iu7MwZGH8nKFWwOlu7T2XHAcBfiJC
	3h1j46Tcfr/KRsICKONkLg7dz0WWhVhSWbT09EZhTolo/yJE7+KyjeX/tivz/2Fpn9H+N0
	FSEIoR1US638WgsjAglnuKD29wpZg1o=
X-MC-Unique: kOy1Nm5cPoykAuiiSnf9mQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=CP5d7QceS7eYzCxv8Tf1rWd0hbRIgv8UC7PcZKR6B9EABf9BytpNX98Sj8X21yQFXDT2SzVJPPoNPsQZTXqAf/bim0GBZ6MrBTrfpl2aKtmuvGXZXdMgol1Ju6uXokg/goFO60ynlbvd0Gs7Az7ZzQWTF8UrQImI4BdLyBdVYHy4BKxcc47NketUOvsg4oeMKI5HQtGa7EqUd5RStkuxVdko3EuPsj0grGjk+5DVVzYM6uhE+sJ+fQ+eiv95i/+Udx6f2aYANfOMkAQuRZVIsYzw8xvuH96CIc8CTQ+s8YRudY0yZwuGY2eqJ5oNDbLGrHXo7gjef1TVurJsnD90zw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=0suWGfn45wVvNVIjN4rGi3qwMwl1Q1X/xyvHV/N+a58=;
 b=MdJlPwHeearK8NgVHHzd2NXetbKnHaatMhx0NW+UC6vY5HZuVzVMRNZUywv4ku84tGRMEZ9In/nv88fsn/WiNeybaJbORuU78F/AjEgxZ7+wzSoUvq25ojM/J6sv8HMUIwfEkUlted/+cgwdN91rR58zMHKe55c0OegrqQFWU/Hf4k6UnSl6bx5g2C1YqiQNp6cWUtRHV3lDb6dBEMf4PzB3ux9KiyjHk/9nsjW8Z+2Z52bdR6D7v3EQK3HXE9S5pFv+4DF5sbLihQpbx8tcbkeSZQx14uJGeOitT78+wSXw6DiCQGNkpmgfvPMnzFRFpEZov2RLPT3HI5hfK+lSsw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [PATCH 03/12] xen: harmonize return types of hypercall handlers
To: Juergen Gross <jgross@suse.com>
CC: Stefano Stabellini <sstabellini@kernel.org>, Julien Grall
 <julien@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Wei Liu <wl@xen.org>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>, Christopher Clark <christopher.w.clark@gmail.com>,
 xen-devel@lists.xenproject.org
References: <20211015125152.25198-1-jgross@suse.com>
 <20211015125152.25198-4-jgross@suse.com>
 <7bd0cff1-6e88-f8dd-d857-229e75dd2772@suse.com>
 <0ca6cdf1-330b-f47f-dea8-442c3cc268ea@suse.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <838aace7-8076-3c78-cb53-faef04162568@suse.com>
Date: Mon, 18 Oct 2021 16:25:01 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <0ca6cdf1-330b-f47f-dea8-442c3cc268ea@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6P193CA0062.EURP193.PROD.OUTLOOK.COM
 (2603:10a6:209:8e::39) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 76a440df-0d45-495b-9f00-08d9924313f1
X-MS-TrafficTypeDiagnostic: VI1PR04MB4351:
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB43512AF1F3E40A3D59D54AB6B3BC9@VI1PR04MB4351.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	el2ysncW1XGa9o6mE8QV8kXqaO7dIlKjz9JPcGiqQ34JUenC8Fe6bXg+EwxnDzu7T5ZORjfg3dmPNvns0Eiv+SN6zWHd0dChnJ+4NSdnPL+33IRRomDNa4belBCNZFGyka0vy3JaySyYBkVBtKIpCxT2w+ZxcZ+nSLyaLVVSRk3RFjNG+pDDg//n2QCd8nEcrfDVPJF8zY2oSEnYZiObV929yzUo2MEYgEwPtG8lS+xIKYdWiIotKOoIUH4NUmecVobUu8dU9iZcugR5xp+y1ZhwwjQUbXXcUC35hbUkLuM0QBmM2e9ApPNh33ivKv19OCDokjsPVyx1FHZVtwwTFdmOPg/yOCzdh0yLqomSoZ4xew6xwGcBcdjLxUZoj4RWR3O9S+QcxAP3qlUD5MhS979UIUELGBGf/TDRiSaYiLSromKeu+I8EpWQkFd6CuPSywsVeZ/TLHwPH34ol1RtTyGSRREtEgF/0E4Nvt6lRCB36EOGL0xt4eQ5057NNN6TsuWnF4oBUHBTByy+VdRtq/bknAcWFa+qHqSQ0JcNNiOrMqm6M4va57mqVqHPD2Ww1zZlB33oSMRHF+bT1ZJ4ZeRLYN9jpdfsur/qUUA8AJXWlDCh1JgyjggraFf5MINKHAorxFrGHDdBqtz2LOsENl6lWOVKVu/u4o3LExFPFBlJK/yEQKP54uWA4X7gPtqqTQfURqeWOYVzEOffnsx+KpN7uGp8vPcIeQOFbsIkkeUGJt5Ih4FJ+TTwBd4q5a2q
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(956004)(38100700002)(6636002)(53546011)(6486002)(8936002)(8676002)(2616005)(86362001)(36756003)(5660300002)(6862004)(4744005)(66556008)(31696002)(66946007)(316002)(66476007)(186003)(16576012)(26005)(4326008)(31686004)(2906002)(37006003)(7416002)(54906003)(508600001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?mQtziUUbMA1zXoQ8s4GtyZzJ+I4j0LHgUOvk6tR5KVa+otxhHpjljWMvUfSr?=
 =?us-ascii?Q?sdizqh/bLDc9CkpfAJ3ACVebbT5t/JMynAym9vZEOUHdEE6+KtL58YRVIUD1?=
 =?us-ascii?Q?PifhVf7dcCiWBAio1WzKKAsvWKpn663iN/P48I5KqHoD3Iep5vvdi4PdIamf?=
 =?us-ascii?Q?6ejXBrr6FWlt7uWaUp+Lqh8KkXneuMcDoF+gHQj/nF9YZ+V/z85xmamnZw94?=
 =?us-ascii?Q?JHc100i7+PCZeGcYCObjm3sI1ieAGB8w73IimFelKXeD/xlyYeIOcSuS7DYg?=
 =?us-ascii?Q?egNvE9YJjMZe5zK9nKsogPM6ttJJAd5dglr56iLC4MieZ5eSR/q4YHihIM4w?=
 =?us-ascii?Q?KIeg2k8w70PBiucl4hJ/kr0ddasSvyAXIryhN3A+uuupKD9yuRCtMcGR7iaz?=
 =?us-ascii?Q?7tRFs6RrWY+EOVrAEEixBAWKkX7XdEWBgY7T4+o1LA6earyJXPm8EEXFyGYP?=
 =?us-ascii?Q?QGrS4TZ+o84DNr+1wdqJFXtAf7vBJ3Fx+jfLkNcXtXzyE1P0/DWujVTToP1N?=
 =?us-ascii?Q?oYh9d4Z640ibDr40AjBRMG00BxHohp44Vv1V7XTaYnxeVvtQpLcIEKv2CtzD?=
 =?us-ascii?Q?uBmLntood9pkbBOXiihXbUUCIJLxOkapuO9iAr1E1SkWIKeaEuALlfXqF1e6?=
 =?us-ascii?Q?smm0mS4ZgXCmh2jF65Ai08GqngfWNLAjxxn9Dxsqaf/+TgghsMN+wFQ3x0Np?=
 =?us-ascii?Q?GfesvdYpdX2S01ig2XUkGbX9AyITVUG5ncoxSZ1DnsU3CSwXVi4ZlV4WL8al?=
 =?us-ascii?Q?oM5zBYUwC4yyyNeArPp5ntw7Ebt2RFR9nFtoE8KRqOYO7QgwcQbBWlsb9FmP?=
 =?us-ascii?Q?IIObQLofK59KJJSvDFUzWwISKpebyzt3n1c4lqk7qc1vE84EwI2l4EZ72WOA?=
 =?us-ascii?Q?lb4JfJtUIzzJ4uivbpioMfCDjdPNl7EcY+ltv1jeoJcPvI9f8lPsdJfuC3iu?=
 =?us-ascii?Q?OdZn9NxGMIy1BzZYUtC6tnQAu+tyayeoee4rYLDn6IJny7Z4DJtpN+r+s1p8?=
 =?us-ascii?Q?v5ONXhd2XtWFM1T6wg6YvXUBZoxW5E1+ejnmjECfLR/plr+ArPf7JjITIwcH?=
 =?us-ascii?Q?9QzG53IYYe1Lazazl36nSSxQ8nB7snMwuhO0MpnP7Bt8JvhM4X5QDt2nZO/C?=
 =?us-ascii?Q?wl5h5yfERx35hIdfgPzF7q65MoRSIHuaHniAracLtbkqOqz6fD8o4CaB+HNg?=
 =?us-ascii?Q?XAhMJW30WA5aKpgzc9FPGjQdpyxpIvNNzEPu6xIoNdwPEv4dUFk1WnxpLcDN?=
 =?us-ascii?Q?W9d2EOogD8/2Wtrxu6mXG6JKim1lTCEML0pRQeHVG4Ls2xbpDhij6zcDKyRm?=
 =?us-ascii?Q?YkeHe4vojcI9Exx3widw1d/H?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 76a440df-0d45-495b-9f00-08d9924313f1
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2021 14:25:04.5891
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zP1m3ngiJnjZrBcQlrcPqMVoGfyU/nig9qfdpwfs33c2trcx4Uq/nBze2Tc9jOHFabF8dBLEGUAFMJoruBvBmg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4351

On 18.10.2021 15:24, Juergen Gross wrote:
> On 18.10.21 13:55, Jan Beulich wrote:
>> On 15.10.2021 14:51, Juergen Gross wrote:
>>> Change the type of the cmd parameter for [do|compat]_kexec_op() to
>>> unsigned int, as this is more appropriate for the compat case.
>>
>> The change for the compat case is fine, but for native you change
>> behavior for callers passing values equaling valid KEXEC_CMD_*
>> modulo 2=C2=B3=C2=B2.
>=20
> TBH, I don't think this is really a problem. Or do you think there
> really is a user of this interface relying on a -ENOSYS in this
> case?

That's a secondary consideration of mine only. The primary one is
that invoking with an invalid sub-op should fail, such that in the
future we can assign meaning to the upper bits, if need be. See
their use for continuations in memory-op, for example.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Oct 18 14:27:02 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Oct 2021 14:27:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.212371.370216 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcTbS-0000Cb-06; Mon, 18 Oct 2021 14:27:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 212371.370216; Mon, 18 Oct 2021 14:27:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcTbR-0000CU-TJ; Mon, 18 Oct 2021 14:27:01 +0000
Received: by outflank-mailman (input) for mailman id 212371;
 Mon, 18 Oct 2021 14:27:00 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=3tpC=PG=citrix.com=roger.pau@srs-us1.protection.inumbo.net>)
 id 1mcTbQ-0000CO-Sn
 for xen-devel@lists.xenproject.org; Mon, 18 Oct 2021 14:27:00 +0000
Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id a24517bd-3238-4cb9-9da3-956f62d0fdd2;
 Mon, 18 Oct 2021 14:26:59 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a24517bd-3238-4cb9-9da3-956f62d0fdd2
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1634567219;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=9coZakRqer3Nmfzd1rZy7qiVb1AIGaejw51CT80OliI=;
  b=emC+YWdNpcJRUENyY1h7vxaLABrwz+Q2BNOUIDTK4UFIH4cyVX2SC0yK
   iI59t1yC5yfV1EGjUoGtA4KfkJyPQPf/HFXvENYxt5ZnpvKEMB9prd0sz
   eUQi5F+8SdICby8FN4e677ZgY0ZfgTVuuUxBSP+F4nx/wcAnq/4iVICRv
   o=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: PMr+irBcdrLguanZgSKl0gOt8nXPkQZZ582ymqkgvYAxpdBFEu2VoTGR5DJbwSyE43hU8h3uaI
 Ncnqi05Rx4d1Q9w4gDNKVsbIMEX/KtRZ1vOHN5Q8B8Xci1+A+fBa4l3WL8+QOaGhzJmGRolGzc
 96e4w8SA+JXOKIDGZOx9CxeiysIr2Xiu4b4sBYpLiyTpmy+dSevp/kkdWPNCsSeO3P+B4i+Tnb
 EeqfqHChO80FiRr8zSQbyXTQTIFKne9l3Ylubc7nozGXcA6SYHv+lv+iLUFg6jTJhMZ67JlD8g
 0eTlnJpVjLk8Z2kUhvJsim8K
X-SBRS: 5.1
X-MesageID: 55841004
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:gFRPMqzTahyThr4xscR6t+fswSrEfRIJ4+MujC+fZmUNrF6WrkUDz
 2tLUTqEM/+KMzH8KN4jOtzi/UMD65GBnIIwG1M6/iAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx
 59DAjUVBJlsFhcwnvopW1TYhSEUOZugH9IQM8aZfHAsLeNYYH1500s6w7dp2tQAbeWRWGthh
 /uj+6UzB3f9s9JEGjp8B3Wr8U4HUFza4Vv0j3RmDRx5lAa2e0o9VfrzEZqZPXrgKrS4K8bhL
 wr1IBNVyUuCl/slIovNfr8W6STmSJaKVeSFoiI+t6RPHnGuD8H9u0o2HKN0VKtZt9mGt90pk
 45qmo6WcCECP5bnk+oMXD5SLy4raMWq+JefSZS+mcmazkmAeHrw2fR+SkoxOOX0+M4uXzsIr
 6ZBbmlQMFbT3Ipaw5riIgVort4kI8TxepsWp1lrzC3DDOZgSpfGK0nPzYIFjGtp3pgSdRrYT
 9soYiRISlfmWRERPn0tGLBvmsOBgnaqJlW0r3rK/PFqsgA/1jdZz7zFINfTPNuQSq19jkue4
 27L4Wn9KhUbL8CEjyqI9Gq2ge3Clj+9X5gdfJW6/PN3hFyYxkQIFQYbE1C8pJGEZlWWAowFb
 RZOo2x38PZ0pBfDosTBswOQrSbf5TkzSfxpNcY70yqGxLvbxAylCT1RJtJeU+AOuMgzTD0s8
 1aGmdL1GDBi2IGopWKhGqS89mzqZ3BERYMWTWpdF1Fduoi8yG0mpkuXFo4LLUKjsjHi9dgcK
 Rixpy8im65bs8cP06iqlbwsq2Px/saXJuLZCwO+Y45E0u+bTNP9D2BLwQKChRqlEGp/ZgPQ1
 JTjs5PGhN3i9bnXyESwrBwlRdlFHcqtPjzGmkJIFJI87Tmr8HPLVdkOu20idRo4aJpYI26Bj
 KrvVeV5vs470JyCNvcfXm5MI55ykfiI+SrNB5g4keaikrAuLVTarUmClGab3nz3kVhErE3ME
 czzTCpYNl5DUf4P5GPvH481iOZ3rghjlTK7bc2qlHyPjOvBDEN5vJ9YaTNimMhit/jayOgUm
 v4CX/a3J+J3C7GnPXSLrNdOdDjn7xETXPjLliCeTcbaSiJOE2A9Ef7Bh7Qnfo1uhaNOkenUu
 Hq6XydlJJDX2hUr8C2GNSJubq3BR5F6oS5pNCAgJw/wiXMifZyu/OEUcJ5uJesr8+lqzPhVS
 fgZeprfXqQTG2qfozlNP4PgqIFCdQiwgV7cNSSSfzViLYVrQBbE+4G4c1K3pjUOFCe+qeA3v
 6akilHAWZMGSgk7VJTWZfujwkmfp38YnO4uDULELsMKIBfn8ZRwKjy3hfgyepleJRLGzzqc9
 gCXHRZH+rWd/95rqIHE3PnWoZ2oHu1yGlthM1PatbvmZzPH+meDwJNbVLradz7qS26pqr6pY
 v9Yzq+gPaRfzkpKqYd1D51i0bk6u4n0v7ZfwwlpQCfLYlCsBu8yK3WKx5AS5KhEx7sfsgqqQ
 EOfvNJdPOzRas/iFVcQIisjb/iCiq5IymWDs6xtLRWo/jJz8ZqGTV5WbkuFhyFqJbdoNJ8on
 LU6s8kM5g3j0hcnP75qVMyPG7hg+pDYb5gaiw==
IronPort-HdrOrdr: A9a23:lblueaxOirXawdyWkTCOKrPxseskLtp133Aq2lEZdPULSKKlfp
 GV88jziyWZtN9wYhEdcdDpAtjnfZr5z+8J3WBxB8bZYOCCggqVxe5ZnO7fKlHbaknDH6tmpN
 tdmstFeazN5DpB/L7HCWCDer5KqrT3k9HL9JfjJjVWPHpXgslbnnlE422gYzRLrWd9dP0E/M
 323Ls5m9PsQwVbUu2LQl0+G8TTrdzCk5zrJTYAGh4c8QGLyRel8qTzHRS01goXF2on+8ZszU
 H11yjCoomzufCyzRHRk0fV8pRtgdPkjv9OHtaFhMQ5IijlziyoeINicbufuy1dmpDi1H8a1P
 335zswNcV67H3cOkmzvBvWwgHllA0j7nfzoGXoyUfLkIjcfnYXGsBBjYVWfl/y8Ew7puxx16
 pNwiawq4dXJQmoplW82/H4EzVR0makq3srluAey1ZFV5EFVbNXpYsDuGtIDZY7Gj7g4oxPKp
 guMCjl3ocVTbqmVQGdgoE2q+bcGkjbXy32DHTqg/blkAS/xxtCvgwlLM92pAZIyHtycegD2w
 xoWp4Y4I2mdfVmH56VMt1xN/dfOla9Mi4kD1jiVGgPNJt3cE4l+KSHqonc2omRCes1Jd0J6c
 38bG8=
X-IronPort-AV: E=Sophos;i="5.85,382,1624334400"; 
   d="scan'208";a="55841004"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=lgjXlRjHXzuSSnEbbuHbuxtsTrXQqE5bNeuIDeZbyM9Zbf8UxyV1CIDBMupmUeS0ZYwelvCYAsSxba6adZ4MfBTLcXlLBDo+n9nf9JxdZzitnhzdaCRgxVOi+LJ6lKKzIBkXoGSy1l+qDJsC5NdhPrcw7uhYaPs1CPNBqe7dn6pUIh9O7M5TC0VhrM08qE1BxIJ8dNjughv3VDkK2bUr3c1peI1vIE7raJ5rcKfrdsCyzVexBrh7eEZIKuW++dFHTdpOBE/UjtI+AYrHt2HnX5z/l1MHMDVZTc5lWLrdnhPGPj+7PQNKJROsUIoIHRegZsugeL28+dH2GsrPM3B+CA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=8pAVrMRA+vG0xvh/Afkvx5KcAtWtLEotGVlwTALjwpk=;
 b=nUt4eTCff+5lcIAkuB1iVsQtFZYQKVRrsNaRI9nJO4vrrVMK6TtoGq7SBYcJ+A2+qYP596byiCmi9I+P4KyV0QgI6PPW3yXHLU4kV+Hw8qzVwGblGsAwxhoxd0M6zL2sfUpnY5LFZwOFOfIrW8/BGsfTiPk+CSug7b7zqDOOewfDwpeJrck0xLkerPAptM78lpqxYUDJYNASHO6zbAbZUsgz+pis+fJnVXdqxLyY7zomA4YEmOfDSd3sWVMop/7wxAXOsyiZAqDu1P8sfbtDS4CAWuGG26wXcmO4hAm+rCXww6/sYOMNfPYks3S7hRcRc6hqhKdMj86MFaWCqx5J/A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=8pAVrMRA+vG0xvh/Afkvx5KcAtWtLEotGVlwTALjwpk=;
 b=aU9x5pBXSOaP5HgU1PmpdHAFrbVpIk/veN0Km4e2GWfHbXTQzKrZEcg0nrmqf+U1jLaVnpwXJlt0DhK3r39DBDIlsdPVE0HMHD/gJQeB804YHQTfxvfKK9azXBwERfzqWcPB5BSLafwxlmSDaV02TIjWYIx8bLFaeLQKJaLblO0=
Date: Mon, 18 Oct 2021 16:26:45 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, "Andrew
 Cooper" <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH 2/3] x86/PV: replace assertions in '0' debug key stack
 dumping
Message-ID: <YW2EJaZ4DoR6ptp1@MacBook-Air-de-Roger.local>
References: <2a14f2d0-2a53-287f-da36-dfb054c7f944@suse.com>
 <5ab88195-660e-5d73-cc34-67734ae161fa@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <5ab88195-660e-5d73-cc34-67734ae161fa@suse.com>
X-ClientProxiedBy: LO2P265CA0222.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:b::18) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: c5565de0-4565-4bdc-256b-08d992435304
X-MS-TrafficTypeDiagnostic: DM5PR03MB2716:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <DM5PR03MB27169ABE38253761B2A860288FBC9@DM5PR03MB2716.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8273;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: f4dnpHj+gvQadrZkUd39JykVIfyZDb3fz/jvnYVIxaW/n9UeGYlc977h3Zb3FJP9ve2lZemQqIyDMIy6dk+PVOn9KnhsAoYkQzPhpQdF571+zcmdbBXEwZ7BWUaY84GRIbhMxPXk+lLl5n+6xjrS26G/DYRKXie6e2KF4LeoGKq4OQTv3dN0Xapo7JmqTnZCnXTr5B9roxLUXtZCLiokdAjLw3qxh5t3UteusXM3vXzVj7M6lug7xxlOPy9L4Fq9jCUStTykK2Ov8posw6nXWkQWlXz5oj6rWXnxjpww1bDWBgZTJaEmxXT2bgLbK7J6yUMJaBS/VQLIYjjRbKeKZOjkmiRGCIA1UhjkZo/+SmfIU4v98zFzolT59Xd2zmPo0hnX6zgockS7sQDqTOhoYqtJ9R+omnST0RjTnzF6TRPIuMwa88n9YIWlLosEyAU1khCBgiw9ABZSR4dLU/vrvV50S6OVYrlI4SILhrXmDMOI7bkNGA9jb6icR1emzqLpkkCnjOlpR+8Hw28yNGznTSlatghXpJ/jdPf7glq6pz0NWMawmF3zVbC7Sy39i0I+w+NLGVZ0/pE08YQzylBAFGAmbBJaaBl7mRbwWhlow9LKw4SwrCYEs2K7QMkMnFHcIUpWsbXAghIdjI2P2jFLpg==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(83380400001)(8676002)(26005)(66946007)(54906003)(8936002)(5660300002)(2906002)(6916009)(186003)(6496006)(85182001)(956004)(6486002)(508600001)(9686003)(6666004)(66476007)(82960400001)(66556008)(4326008)(86362001)(38100700002)(316002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bFBEM2hXbStycHdPd0F4UUFlMU90cUdySTEvS2FyWFB1Tm9XbkdTMkF5WWk5?=
 =?utf-8?B?dzJrUEZydG5ZM1NJL2VNUHoxTGd5bXdqRGUwTUZJdFcvYVdwNzdGNC9nTEh0?=
 =?utf-8?B?Z0dNRXE5QUdIMGgyZDhBTEluZFdGYmxNS1NKUXVKaHcyUWhvOURxSGZhVG1v?=
 =?utf-8?B?OVRmODd5QXdJR2hyeFo0T2paeHhXU3g4VHlOaDBYVER2VFQzbCtLWkYvN1h1?=
 =?utf-8?B?L1JMV3lKLzhuMWNtbUJMZzlQUnpYZGd1cE1IOVZ4SGQ0Q1VjeW8wcFkyOXFa?=
 =?utf-8?B?M2l5OXRhQTBtR25TSVFjQk0wbGNjeUNnbDJZZU1DL2sxdjAwSUZGcDlxdVlP?=
 =?utf-8?B?MGlqaXJkNkRQdkZ1NkhBeCtsNEswRmtZd3N1Ykd6ajNpUTVMTkFzUXQ2OTdV?=
 =?utf-8?B?cFZEUjJRVWpFTkdKRjZxUzRGOENBb1d3RnRsN1M0NWZjNlRpbE5iZzYxY3Z2?=
 =?utf-8?B?Z2RPQmo3REdtTDB1QnNiaE82OXFLbTY4NG5ZdUJ1b2dZbFEyQnV2RGhkc0RW?=
 =?utf-8?B?U2Z0SUx1Sjlubm5teGN2T2RZcFh3NXo2OHhMaHZJNkhxazJiRWFjTGp2RWZo?=
 =?utf-8?B?QTF0MmR6TXNja2s3SWZFUjM2RHlwdEwzMHFCakR3c1c4M215MFdBZzB6YkQw?=
 =?utf-8?B?anpqczg1RFJkY09KSkY5Tndocmlvdkw2MDZjYVVwVXIzZFZ1T3d2QS9xYk1k?=
 =?utf-8?B?OU1qUVFtMDdBbFFUZklLWTJ3YmdVdHE2TDMyY0pnZnNvMnU5MVdET1JBdXBo?=
 =?utf-8?B?UlNTWXNmbktjTFFYM3YxbEtQaHFxcG9XV2FzaFNFaEFtQUc1Q2FadEpsTlpr?=
 =?utf-8?B?cHozTEhOQ3FobmVyYVFkQUM4eitqMDRxNnpPYnMvUWFVR1RtQXhFNW5UVVMw?=
 =?utf-8?B?TDk5cWFPbUM0ZGRGRXdFMHV6cVJtR3Q1WmJndjhsT28zQmdEK3Z6dGczRnlJ?=
 =?utf-8?B?REZjS1Y4UHdJSWwwaFpqaGVKSVQrUEpvUm93MmVuTGtnYUozandTQjczM1dV?=
 =?utf-8?B?WGUzM0s0bDM0NmtGN0c0eE5uTVNiUnlwRlRQK2NaYlo5WS95eElhTnp2Zk9B?=
 =?utf-8?B?clV5NnZhWUh3K3FLYkRoUnEzamN1TklMYVhYTStZOWZOR3NIZFlwWGgwNzBJ?=
 =?utf-8?B?TkJVZjZhT1U5cHBHN1ErMjN1bnFGNDlrSW8zMHloVk5pZXNjMEUwVjVMVkRB?=
 =?utf-8?B?SkZRbnZKVlFwZ0tSZHFXWkR0cWFyUmMzR2FHM1NreDVLK2RQWGFzS1VPWUtz?=
 =?utf-8?B?ay9udkRWdzU3NStPc0dqNnBSbTg4MVA2b21CYmxadVVlSkg4dlA3Vk94SXpj?=
 =?utf-8?B?UjhZMG43TC9zZVpyVURLV3hpTWw4djJWZGt6aEZxMHdpV0Zha004bXlIeTY1?=
 =?utf-8?B?QjZmcHhHckM5aFA2L3NUU3BCekE1L3kxRjM5QjZDWmRyS0FrQXRkRmJzN0U1?=
 =?utf-8?B?WHlpcytEM0VZa29hSXJ6VzA3VVhDOTZYYXZJVXV5VENlSlJIUFowT2pTeXJ0?=
 =?utf-8?B?ZjI4cXhuZXBQZS9jMGtCbkpXUkpTQjRLaE9xckkwWkF1TTlYUzBndmFQdVZw?=
 =?utf-8?B?bXA3QVZrMXh5cE1uR0lNVGo1cUNPQjNxYmVSb1ptYUVqYmdZZEVhRVRkMkNk?=
 =?utf-8?B?clU2bWVTVk5UdG1YaitJVFpOTGdVSjNyck5EWFhjeGpVcUJMa1FtWWY5RFFp?=
 =?utf-8?B?ZElHT1FTekFlTEdSSVRGdEhkOEkxR2c5M1RScGZqOE5JUmIrTysxSTYwWkVS?=
 =?utf-8?Q?KXDo1DL/+eTSrL+AXUdtG7SBYwiQ9cNcjK57AQa?=
X-MS-Exchange-CrossTenant-Network-Message-Id: c5565de0-4565-4bdc-256b-08d992435304
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2021 14:26:50.5429
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ztbt/QHp2QMAbBD6aD3nvKEG8yvWRSUKcJsfBj82/fe4PRgsHwhaV+IkF+h4FUvSrEBlWVV3eNy50hR32ogJ6g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB2716
X-OriginatorOrg: citrix.com

On Wed, Sep 29, 2021 at 11:42:54AM +0200, Jan Beulich wrote:
> While it was me to add them, I'm afraid I don't see justification for
> the assertions: A vCPU may very well have got preempted while in user
> mode. Limit compat guest user mode stack dumps to the containing page
> (like is done when using do_page_walk()), and suppress their dumping
> altogether for 64-bit Dom0.

I'm slightly lost by this last sentence...

> Fixes: cc0de53a903c ("x86: improve output resulting from sending '0' over serial")
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> ---
> An alternative to suppressing the dump for 64-bit would be to make
> do_page_fault() guest-user-mode aware.
> 
> --- a/xen/arch/x86/traps.c
> +++ b/xen/arch/x86/traps.c
> @@ -254,7 +254,6 @@ static void compat_show_guest_stack(stru
>          struct vcpu *vcpu;
>          unsigned long mfn;
>  
> -        ASSERT(guest_kernel_mode(v, regs));
>          mfn = read_cr3() >> PAGE_SHIFT;
>          for_each_vcpu( v->domain, vcpu )
>              if ( pagetable_get_pfn(vcpu->arch.guest_table) == mfn )
> @@ -269,6 +268,8 @@ static void compat_show_guest_stack(stru
>              }
>              mask = PAGE_SIZE;
>          }
> +        else if ( !guest_kernel_mode(v, regs) )
> +            mask = PAGE_SIZE;
>      }
>  
>      for ( i = 0; i < debug_stack_lines * 8; i++ )
> @@ -328,7 +329,12 @@ static void show_guest_stack(struct vcpu
>      {
>          struct vcpu *vcpu;
>  
> -        ASSERT(guest_kernel_mode(v, regs));
> +        if ( !guest_kernel_mode(v, regs) )
> +        {
> +            printk("User mode stack\n");
> +            return;
> +        }

...as you seem to unconditionally prevent the dump regardless of
whether it's dom0 or domU as long as it's not a kernel stack?

I assume when running in PV 64bit mode user-space could be executing a
32bit program and hence Xen could then misprint the stack as a 64bit
one?

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Mon Oct 18 14:28:46 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Oct 2021 14:28:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.212378.370227 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcTd7-0000u2-C1; Mon, 18 Oct 2021 14:28:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 212378.370227; Mon, 18 Oct 2021 14:28:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcTd7-0000tv-8J; Mon, 18 Oct 2021 14:28:45 +0000
Received: by outflank-mailman (input) for mailman id 212378;
 Mon, 18 Oct 2021 14:28:44 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=628V=PG=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mcTd6-0000tm-K2
 for xen-devel@lists.xenproject.org; Mon, 18 Oct 2021 14:28:44 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id b1dddc92-301f-11ec-82d8-12813bfff9fa;
 Mon, 18 Oct 2021 14:28:43 +0000 (UTC)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2054.outbound.protection.outlook.com [104.47.13.54]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-25-81RWkhORPJy8ggdSArHK7w-1; Mon, 18 Oct 2021 16:28:41 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VE1PR04MB7360.eurprd04.prod.outlook.com (2603:10a6:800:1a3::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.17; Mon, 18 Oct
 2021 14:28:40 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.018; Mon, 18 Oct 2021
 14:28:40 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM5PR0601CA0031.eurprd06.prod.outlook.com (2603:10a6:203:68::17) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15 via Frontend
 Transport; Mon, 18 Oct 2021 14:28:39 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b1dddc92-301f-11ec-82d8-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634567322;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=VYuhlC88UZgMhO4pNH4L3Gtp9dKel0eI9TFhqa0Kdu4=;
	b=bXR0Fzoly6cnzAts9W6noBF14YzzMudrWuAr5AG3nd8TePEphiYbERlsoQ9piFHtK0ZRJ7
	NjiD4PRsPgZhq+rtcyobt1sundt1MHt7t8qlvM3AoMQkhc2wZUcl1Emn60HetoexDDY5OW
	qmrnix2/435ajk5X7Q8CExBl9F7PiKU=
X-MC-Unique: 81RWkhORPJy8ggdSArHK7w-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=JojYliXSvpzXmLB6/Poeum+fu2QTGe2GfEli4QK+WBI8TeKtj6cPFi2aLljdtJlgmr+37jDjESFSBogGptE0h+ztiIBLHwdAGAO2tqFF6gOAsxDyCU6JNeelzIJCdLWeUYjDH8eWO7cfcapWsocPNnaxNVWsHBHNR5MwRr+oiwH66bUAb0frHanHUBkcH1yBEWrKQQD/dV13PkdoD5XdzOnIk14cAdjOHFSkwZTNEzH9E5Kz6ne2XK89U+B0dDzv+jE8B5vxdIu+Sd8VCWSGK3StaHtvr8ZBWBNc+HxhSFDF1rX5MNpw776yULXJHefsnDSzYfrSLUm+WGJ2e+BMdg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=VYuhlC88UZgMhO4pNH4L3Gtp9dKel0eI9TFhqa0Kdu4=;
 b=UoPHpqc8qCsuWexuGLkiQkFcXgvgSuVLDgZqme5pVOXYooFo3PaF5AJ4UDAnV2qt1Ha0sp+IVyiAROGvSV1UoAZkxdWIn6y854TfDYXMg0fCsOqbY6Yg+WQYSmFMry/LmsDEh7UpImEFZWNdxWZv9Vg8M7wgcViNeYjVzA47BLEUQc8L1jdlW5vfFcLUKdQylfBYBw1/0jppfWySCXwGCAQdTJ0XS0n5c/TBHJkdruGnx4HEU8BWNZvDFNSTu+NJNdXAY0UvE0Yf6xMQYxIUZdlsZJD1sPr6Fz5OP6H7/qUzRlOMKNW1fW/6IDJKOSCTUotOfIpW2+zZigzvh+fA1Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [PATCH 04/12] xen/x86: modify hvm_memory_op() prototype
To: Juergen Gross <jgross@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>, Wei Liu
 <wl@xen.org>, xen-devel@lists.xenproject.org
References: <20211015125152.25198-1-jgross@suse.com>
 <20211015125152.25198-5-jgross@suse.com>
 <71fae3b2-9f90-878c-50f1-e9c0d7cf7e5c@suse.com>
 <d5c5854f-6bd1-db12-b530-ffc628f473f7@suse.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <0a1aee06-41da-7045-4bdd-33993ce3741e@suse.com>
Date: Mon, 18 Oct 2021 16:28:38 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <d5c5854f-6bd1-db12-b530-ffc628f473f7@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM5PR0601CA0031.eurprd06.prod.outlook.com
 (2603:10a6:203:68::17) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: e1f258d9-cfac-4645-d6db-08d99243944c
X-MS-TrafficTypeDiagnostic: VE1PR04MB7360:
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS:
	<VE1PR04MB7360183EEC0AB811C00D0E9AB3BC9@VE1PR04MB7360.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7691;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	IGDV7AbkA9Gk6n/D7Ts03ltPPW7B57fZDoSRmwu7QtfOajLQ2AmdqR24VN7ct1YBrKwntC51K17BrS4V/U/SQ8VrxaL7vS+sSlq8Wlc0ZA4elCR3/ChtpY7ULDb3Kr6qXRSkqbR6VaK1hpknKuVpFMKNmlqnSIxrrGvmX0Zoy0+c6ev+/wvSf+Z2FTE+ufiOAO+uCDiFm579OFjwGMH2RQhPlD28dzL8KGK/o4/yUQw6uKC6ZK9+KvJrj45AuHcWTX1jlbAggYAd2CTw+OLreEHNjEOVASCYuRK1QFqnIKJvOWkoo9timUWtBKRlgGQ0zBAhmFe3aiXo3ufuQA+xWt6RPtjsghuRuAPLOjH54MQCwe1xk88YSs3+7JhidTWvuxcUoDmyYACRMXUiIy72SSCfGnfEd7TWTNgxabSNlc+Fp3o2rJhNtCY45hqae6pmw8OS6w86bU+BEjTdd4lYfuGDtw+FXGrFvUlkNZX20M0ZaejBaTDeqPQD4xybMSK4OCnaNCfUYz7g2qPurVFxk92mDqpYDZSXKZNFuQy7SKDxHP4p7967RTZD2D4f15qiCKuATot8fVlrwB6/kzTuYH3WGfmdzYy7TIbyxmw4/6p0XRmMdlMsgMtFZ8sW0j3oeBezKDMpl4u0EBGAR5MzDL4dUdzfcqtpfavOZeuG8MIYDaAC70mTQFv2LJqxJTlGwf1631CwN1M9SIqzqUm8DWDXHs94SzaDpthXpOE59m3lTIzVNVAKoZ2dXHDZrvQe
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(8676002)(26005)(36756003)(66556008)(66476007)(66946007)(16576012)(2906002)(6862004)(316002)(86362001)(6636002)(5660300002)(2616005)(38100700002)(37006003)(508600001)(54906003)(83380400001)(31696002)(53546011)(31686004)(8936002)(6486002)(4326008)(956004)(186003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?dXB4ODFEbnBDYTBmV0xMZmpuK3EzN3ZhSXV6cjFwcWhrcWkwR2s0Q1g3bE1w?=
 =?utf-8?B?eG5WWS80V2xVQzJnVDVBczdoTGZkMWxSMHU2T1lTc1d0eUFFR1c1N04wTjJm?=
 =?utf-8?B?Vk1XVTMrQ2YwUzBsL01UZHVHWlJ6MENDTXh5aWdEay9oS0ozeGNLM004NGN0?=
 =?utf-8?B?VXNlRlhLdnVzWDA5OXVTYUNFTW1hVTkvcUpuU1FWQnBTOHc4Z2tqVmJLZHNr?=
 =?utf-8?B?NjZiOWE1Z0lGSGsxdzRSWUFJVTRBYWJ6TmF4NFVWanZYQ2lXQ2xmR015WWdU?=
 =?utf-8?B?RkZzRXpWZ2xrdGlDY1RnMjRkWHQ3cWh6eERURkNoRWpKZGtiVm5JT0hGaFpu?=
 =?utf-8?B?Rk9obUlMRW1MTi9ZM2NXQ3dyYXV4dGlZd09WbVJHb2NWRXZTbTdTdkhwNnVE?=
 =?utf-8?B?Z1JneGtRdVZLMGc0RDdrNEk1bWEwb1EwVkNwckx1c0w2OHdDZXRJVUFPT01F?=
 =?utf-8?B?aXRrNUxCR1VJQmVRaVh4OWIrL0hsc3orRFE4TGc3NjJlbjFUVnlmY0hYc2Zq?=
 =?utf-8?B?QkI0VVlZc1JTbTBNODlRUnBwemhVRmI1R0tMWWpiU1FGUkhZMDZRcWFBcTl3?=
 =?utf-8?B?Z0xleWVmTk0zbkREUCtaVUt0N3pSWm1tdWE4REZSZTIxNm1zai9maEtaaVBt?=
 =?utf-8?B?N2xkVjdYUEMrS3RvQmtUOTBOYXBDVXVLK3BPREIyaGlhUlVpMHgrTWhtSmcy?=
 =?utf-8?B?Ky9wZTdMaGlManBsblZtNUsrNHZCT3VmaWNIWDBwcWYwMG9xOUFnRHl5TjNv?=
 =?utf-8?B?aDNielV2YmJyVWlNTkpsODBid1VBVUhScFF2R1ZNc0U0U0JZMkV6cWN0VGNz?=
 =?utf-8?B?N21pZlBKY1ArbTZyTGtXelpUamJFM01ubUhSK0MrR3dadmRLWGtzUnFzQm9T?=
 =?utf-8?B?c3NiYXFIemQ4bDB1QTdjLys5UTV0R1pFZWRNcFZ6U0s0RjhIWEJCNUtOczNh?=
 =?utf-8?B?WDlSUXBQelhJMnJLdnJtMzUyTkt0MUtMbWw2Y0NwUG1LeThWYlAwd3REOEph?=
 =?utf-8?B?Y0E1QVVXQ1cvR3BsakpwRFdSL3VmTHlFVHVTVkh6UVY3eXNCelBCbEZaWkxa?=
 =?utf-8?B?a0NrbkZySDVWQkY5MlRqa3hwdTF4WEJVTWx5M0hKY1NKTWh3THhhUEJJbStP?=
 =?utf-8?B?RjI3MFY0ZDB0V0pSRGV0NzdVQWU2QWxZZFlaK09GUngvTGxyS3Z6ZE5BK1Mv?=
 =?utf-8?B?WmRTTU1QOHBlOU9vc1lzRUw2em1sQzdCeVpjUFgvY080aTBWUEJjUWYyZ0ds?=
 =?utf-8?B?bDNCK0FMeVB1Vjg1d3ozMEJyRXNNcW9pTE1qM0tYdlVDNzh3d2YyZDNOYXVH?=
 =?utf-8?B?bzhwaDBwZWx1NFZPYVloY0JpUnpMNS9pdVI2OG8xS0pjak1uZ1R3dmdjai9V?=
 =?utf-8?B?Z2k0NUtoVk1MNG1ueG5KOE42VjFYQ3BVR21Fc2Exc0Z4M3gyL21Ib3hkM0F6?=
 =?utf-8?B?ZjVkZ01IaVBnd09NTHAvaFUzemQwNWt1ZWszT1RtdFRSa29nemxzY3pCTU5o?=
 =?utf-8?B?OW10YzB4WjlBVTlEOWhJM3FuenNUY1NIaEJJT3FycExKZERZSWlreHkxNGli?=
 =?utf-8?B?enhxcVJCK2NadzZXQlN1SkVub2FraTBJMjd3WTFyUzNyM2hSUmd5QTRtazVD?=
 =?utf-8?B?QmtuS1lNSStEdEZ5djk0YXdtdXZBei8waTMxTFdkNWd3YlgxT253SW1FSXhO?=
 =?utf-8?B?Y3ZteDA1SUxmWFpEMDBGSkVQcFVJMjB6N1RKSzVzUzFFMjUrMGF6VDYzYXZq?=
 =?utf-8?Q?8f7VX7BEYk258Xirk3q398v60KSIH7ZcvdDXN/F?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e1f258d9-cfac-4645-d6db-08d99243944c
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2021 14:28:39.9392
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: b09vzjqfD5SSCUBXduEmmVsQtlpZCBhtleW4HiOL9E2pV+6nhmL1vYqdjjaSsWpN4y5dKbojCHgxvAAFcQZJzg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB7360

On 18.10.2021 15:27, Juergen Gross wrote:
> On 18.10.21 14:31, Jan Beulich wrote:
>> On 15.10.2021 14:51, Juergen Gross wrote:
>>> hvm_memory_op() should take an unsigned long as cmd, like
>>> do_memory_op().
>>>
>>> As hvm_memory_op() is basically just calling do_memory_op() (or
>>> compat_memory_op()) passing through the parameters the cmd parameter
>>> should have no smaller size than that of the called functions.
>>>
>>> Signed-off-by: Juergen Gross <jgross@suse.com>
>>
>> Reviewed-by: Jan Beulich <jbeulich@suse.com>
>>
>> Nevertheless ...
>>
>>> --- a/xen/arch/x86/hvm/hypercall.c
>>> +++ b/xen/arch/x86/hvm/hypercall.c
>>> @@ -31,7 +31,7 @@
>>>   #include <public/hvm/hvm_op.h>
>>>   #include <public/hvm/params.h>
>>>   
>>> -static long hvm_memory_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
>>> +static long hvm_memory_op(unsigned long cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
>>>   {
>>>       long rc;
>>
>> ... I think this would even better be dealt with by splitting the
>> function into a native one (using unsigned long) and a compat one
>> (using unsigned int).
> 
> Why? In 32-bit case the value is naturally limited to 32 bits width
> zero-extending perfectly fine to unsigned long.

It all ends up working fine, yes. Else I wouldn't have given R-b.
But the .compat slot of the hypercall table really should use a
prototype without unsigned long, and then the calls wouldn't
zero-extend the arguments anymore. And then the declaration would
be wrong, as then it would need to be the callee to zero-extend if
it wants to use 64-bit values.

> Otherwise I couldn't use the same definition later.

Right. And this will be less of a problem once the function pointer
tables are gone, as then the compiler sees the real parameter types
for the individual functions.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Oct 18 14:36:06 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Oct 2021 14:36:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.212385.370238 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcTk9-0002KR-42; Mon, 18 Oct 2021 14:36:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 212385.370238; Mon, 18 Oct 2021 14:36:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcTk9-0002KK-0q; Mon, 18 Oct 2021 14:36:01 +0000
Received: by outflank-mailman (input) for mailman id 212385;
 Mon, 18 Oct 2021 14:36:00 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=3tpC=PG=citrix.com=roger.pau@srs-us1.protection.inumbo.net>)
 id 1mcTk8-0002KE-15
 for xen-devel@lists.xenproject.org; Mon, 18 Oct 2021 14:36:00 +0000
Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 276784e1-de06-4073-9acc-76c6cdf5776e;
 Mon, 18 Oct 2021 14:35:59 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 276784e1-de06-4073-9acc-76c6cdf5776e
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1634567759;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=FKl2FEncP2by20CzQ2Fx76DUTBjJzEWHP6//3Hkjvd8=;
  b=DBBx0fz7ON4f/F6ARQoJN44JolEQvEo2lyjZKmSqUZbqXgB7jM/Q36XW
   W9QES9PzQtJ6kCu+6DdBFsd3izhImrToy7tqqY3gKYiJ3MLgLo+V/nPLt
   pjo0DhNGGAZlTDwLSaJ9HBg+7bnXzn+zFKSE4b7HEZ5aH6BzXWCeUXTxf
   0=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: A+r86Y1FkF+CwN89RHLvtMRr9Ym8kMCK1TJr+xFqclXuqi2MkObSauBqNHdlR7EppD4FXITwH2
 cJS2dN7MuCo6gfoAW28TlDzhLllQK2L6jEP5vtz6t1gJL4eO7VG77EaQT7q5arzTsyjgz5wW90
 Eg8se1NgGkQ2j5c3ZAd/eymxoVP+bSkSMqTwR+jQJw8GBjFvnEYUcv3EcaU/QmgNsfQGuYI5GA
 TAK+6ft87nr3uq9tgcJuT1Y92DUr5qALUgcfcUZSmNAP5GXZHJ4WeLOHpVVdO22SbiX2lo+N+D
 QlqT58V2dF3+4Vdsl77vOkaz
X-SBRS: 5.1
X-MesageID: 55841867
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:ygDCIq7+RqnLjtXMRf8KIwxRtOPAchMFZxGqfqrLsTDasY5as4F+v
 mIbUGHXP/+NZDPxL40kboSx9k1U65HSx9RnT1FprX9mHi5G8cbLO4+Ufxz6V8+wwmwvb67FA
 +E2MISowBUcFyeEzvuV3zyIQUBUjclkfJKlYAL/En03FVIMpBsJ00o5wrdh294w27BVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Z6
 4p0rZzhFz8SG5LiisUsfhIEESAlBPgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALNs7kMZlZonh95TrYEewnUdbIRKCiCdpwgWpg2pkeQ6m2i
 8wxUz03Myacei91GnwSA78exNWul0T+bGgNwL6SjfVuuDWCpOBr65DyNPLFd9rMQt9a9m6Iq
 2SD82nnDxUyMN2E1SHD4n+qnvXIny7wRMQVDrLQ3vxgjUCXx2cTIAYLTlb9qv684nNSQPoGd
 RZSoHB36/Fvqgr7FbERQiFUvlan4ScEW4sOK9Yf1y+f65v56FqbBzM9G2sphMMdiOc6Qjkj1
 1msltzvBCByvLD9dU9x5ot4vhvpZnBLdT5qiTssCFJfuYG68d5bYgfnF447SMaIYsvJ9SYcK
 txghBM1gKkPloY13qG/8EGvb9mE98WREFBdCuk6WAuYAuJFiGyNOtTABbvzt68owGOlor+p5
 ilsdy+2t7hmMH11vHbRKNjh5Znwjxp/DBXSgER0A74q/Cm39niocOh4uW8leBs4b5deJWOzM
 Sc/XD+9ArcJbRNGiocsO+qM5zkCl/C8RbwJqNiFBjaxXnSBXFDep3w/DaJh92vsjFItgckC1
 WSzKq6R4YIhIf0/llKeHr5FuZdyn3xW7T6DFPjTkkX8uZLDNSH9dFvwGAbXBgzPxPjf+1u9H
 hc2H5bi9iizp8WlPnCIrNJOdA1TRZX5bLivw/Fqmie4ClMOMEkqCuPLwKNnfIpgnq9PkfzP8
 G37UUhdoGcTT1WZQelTQnw8Or7pQ7hlqnc3YX4lMVqygiBxaoez9qYPMZAweOB/puBkyPd1S
 dgDetmBXasTGmiWpWxFYMmvtpFmeTSqmRmKY3ivbg8gcsMyXAfO4NLlIFfirXFcEiqtuMIii
 LS8zQeHE4EbTgFvAZ+OOvKixl+8p1YHn+d2UxeaK9VfYhy0ooNrNzbwnrk8JMRVcUfPwT6T1
 gC3BxYEpLaS/99poYeR3a3d9tWnCepzGEZeDlL317fuOHmI5HenzK9BTP2MIWLXWlTr9fjwf
 u5S1fz9bqEKxQ4Yr4pmHr935qsi/N+z9aRCxwFpEXiXPVSmDrRsfiuP0cVV7/Afw7ZYvU29W
 16V+8kcMrKMYZu3HFkULQsjT+KCyfBLxWWCsaVreB33tH1t4b6KcUROJB3d2iVSIYx8PJ4h3
 ep86tUd7Bayi0ZyP9uL5syOG79g8pDUv30bi6wn
IronPort-HdrOrdr: A9a23:+bn4IKFdUTE012s1pLqFeZHXdLJyesId70hD6qkvc3Nom52j+/
 xGws536faVslcssHFJo6HmBEClewKnyXcT2/htAV7CZnichILMFu9fBOTZsl/d8kHFh4tgPO
 JbAtRD4b7LfClHZKTBkXCF+r8bqbHtmsDY5pav854ud3ATV0gJ1XYGNu/xKDwReOApP+tcKH
 LKjfA32AZINE5nI/iTNz0gZazuttfLnJXpbVovAAMm0hCHiXeN5KThGxaV8x8CW3cXqI1Svl
 Ttokjc3OGOovu7whjT2yv66IlXosLozp9mCNaXgsYYBz3wgkKDZZhnWZeFoDcpydvfpGoCoZ
 3pmVMNLs5z43TeciWcpgbs4RDp1HIU53rr2Taj8DPeiP28YAh/J9tKhIpffBecwVEnpstA3K
 VC2H/cn4ZLDDvb9R6Np+TgZlVPrA6ZsHAimekcgzh0So0FcoJcqoQZ4Qd8DIoAJiTn84oqed
 MeTf003MwmM29yUkqp+1WGmLeXLzAO91a9MwY/U/WuontrdCsT9Tpe+CQd9k1wva7VBaM0od
 gtn8xT5cVzp/QtHNBA7dE6ML2K41z2MGHx2V2pUCHa/YE8SjnwQs3Mkf8IDN/DQu1+8HJ1ou
 WZbG9l
X-IronPort-AV: E=Sophos;i="5.85,382,1624334400"; 
   d="scan'208";a="55841867"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=nfgljEinTwZIhuFI4l/UJnzK1ghwwn1zxwoV2ODVNgsZqIT+mMd3k6Xz2N1uDIGs1BV0Vx2NfYC4NfzSg125/aklxPJWkRgruFpL5WlXppGz6PxCMvGO15MbtnRHb7n2EsbXzHo+9Wp3FC/t8SupMu0uCcY30WX4b8SkDq68ygnpPqCDIYVp+/KVsneIVYP9THBbIOeLyOwMBCgDJolEBkW4xhnttODaY3lBzUXlNQBIvOtEkD4Ax0QQD4PoJWWT0kmqkRuFSSKWljA45WHD47BLN4D5nPKR+hDCfCNoIORvFgu0sYRHsk+KdfqHRNepRMywuysqoIch7NjFUX5OSQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=f4ipIxAZmgfh4+f6trev402Zd5Xdi5moSq+db0QEPK0=;
 b=EZyQLiReIS2kS2ogavoaL5Icz7bpfQ+oq1YALQUF7O/aPNq/WapUJHqsQeMOraailILphxadwmqfEoWB6BDxxH+hbdGdDUcsJ6xN75LjUD0Z5iMsVWUag8qTdPjEHrAJVRs5lbSBn/N2lvcXQ05J9GHcmDI6Y+xT5OpCwo04kM5r91eypUmAmveWHCTjFpeE7s21YLUZwh5uUY5uml0BFWrbHcBMEvYhWcam2aBPd02JMSTVo2Fio3iXejT64dcEzRfeIBQKoCRgNgrWzUsOMfqmor8Vg+TBWOQyDrtRggnNLsGqxmPYxOtKEsD0fBpxCS7LQ9LTt+YCHH20P0k0ww==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=f4ipIxAZmgfh4+f6trev402Zd5Xdi5moSq+db0QEPK0=;
 b=bk075Jo8ZINwJWJzShWEPwT2VYlH89jxJo0BNeH9QWYTjqa+/UssCVkbacRK/sMXfEBWmTgvk/IQOK0MA9lgl6hlB7tgen8+T91ErsCYo8FPfmTRyZX8026xyaI9JOYjh6bPbNbnRzYeERNXb/u40r7JxmtnA9sUfvTEX0RjmkQ=
Date: Mon, 18 Oct 2021 16:35:36 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Andrew
 Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH 3/3] x86/PV: drop "vcpu" local variable from
 show_guest_stack()
Message-ID: <YW2GOBRJ9hV7O7AW@MacBook-Air-de-Roger.local>
References: <2a14f2d0-2a53-287f-da36-dfb054c7f944@suse.com>
 <6dad4cfb-708d-027b-0fa1-77bb39319fe6@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <6dad4cfb-708d-027b-0fa1-77bb39319fe6@suse.com>
X-ClientProxiedBy: LO4P123CA0056.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:153::7) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 6d2ed056-ded4-43b7-5617-08d992448efc
X-MS-TrafficTypeDiagnostic: DS7PR03MB5525:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <DS7PR03MB5525C18B1F3F710B1035846F8FBC9@DS7PR03MB5525.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:3383;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: CCb18SlmuHbQaxDSSxDf0qJUDoNJHYhbUJTAfFdNsbmBUJ6hjWJ0lHsv8ow9iZc+pBJMi7twc9OkDFjJsVMNHbC2eivjI9Pa4xbyCadDH2/X+LLeuepMYVaHFpHxbFlBHqWAgrn2Fz83LNbFyY9OHCxo0lYlrl+zk0a7j5BpgdTqpibF9k5Lc4k8Gk3ZDV3lHzlW3jln5q+pM+yQpyIvLoo439E9Xdk3WCGhQ8OlwVEWrl0uM0ZgMDdpmNmbKACP9fdbcmRyxuXbrET7g4aJhb3l0cIk59gNaIc+wJ87wYvJGdFu1qwwfzDZNe1dsdKdIjGMH1U9ROW7xTc2CgpCm4/0/2Scm8lvyrK2NQKnUeqa+gdkJcMwOmJs90JMUeUZ/ibfAxgZGl7aw5Eqap/QdCcORa3bSgxp6mrE7ZASlnPvzEHQSu6vVRi+ajCktSL0MQ470+ksZeUFJ3M7HPS4L/9dDpX7+o42FEq+6TZ5n6TwcXH2UkP5ooESM05PB4NuZH3i5BNLv31V7qnJfeMjpyReu5Qutz5vzb6X/HVYtFnCnvTgrAH7Kbb2LHMMXBJ/bqZFkTdsXSV1bqviytavfxuaiUotRTqLZ+bBt5cRh6pAkM7e2/s5goCJQmakz8hvzqPbpPOsMwvealRK3qdsBQ==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(6916009)(5660300002)(85182001)(66476007)(66556008)(38100700002)(82960400001)(186003)(6486002)(9686003)(956004)(316002)(86362001)(4326008)(26005)(54906003)(2906002)(8936002)(8676002)(66946007)(508600001)(6496006)(6666004);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?M3hvQXNCdTlXSFNXc3FnaXgxc1J3YXU3S0FwS2s5bi80eWY5WWZ6VXBrSExs?=
 =?utf-8?B?UUlYeS9HZ2ptWW9sZy9GNFVrSEplMjROM2d6UTdqU0Q1QVJSWEFkR2pManZm?=
 =?utf-8?B?S1NxM2NicVMxUmczdzhpRG9NSXM5THIyejJKR3JBZkxwQWZXSHBOdzZlMkxw?=
 =?utf-8?B?N2NXdUtKRGR2WFljeFo4MHNwKytFTXJab3NxVWFyTUc3K2hkb3RhcXl1OHVv?=
 =?utf-8?B?MGNmNngwdFBKWWw0ckxwMjZReDJhb2tJNGhXcEN3bmt6Qkw5TjVCUGZEMENm?=
 =?utf-8?B?WHUvMDJ2V2ExQXBsdjdVWU9lNzQrMlhuUVpSZjVQS1M5dEFZaVB4RllFdlhP?=
 =?utf-8?B?cWg0c0xhdEMrM1U2Sk03dXRVODRzNVlEODA3VENsZkhxYkgwQVMvRWYzaG5q?=
 =?utf-8?B?b0tpcUV6UXg3d3dkVFNUdmd1THVURWJ3SSs2clF3c1VyanMrNHE3aGpRTTdQ?=
 =?utf-8?B?SjI1T280WVYxS0xNQVQwVXM4M0RyaUFIZXA4aEtXUE56MVZFaDdzcllYODhQ?=
 =?utf-8?B?VnJqSUxWUFN2Q0JpVzlET0xCZTEyRDRIQVdwOG00QTVNWnlGR0N3cHNaL0U0?=
 =?utf-8?B?UXpjamU5VytNYWlpMEFvckxHRXlkSnUyOVhWdDRNdys1d2ZxRjQ1cFRSVXBB?=
 =?utf-8?B?WUNYZkdLNnZJWWRSeUQ5aDNiNXlyNlNEcFhTcGhndmYyU0xhZmgzbVNid3NR?=
 =?utf-8?B?WHJCd3RBdnBMQm9HRk1pblZYVUxEdnB0VkpPdlphVC9VTUxUYlAwbFFYQVF0?=
 =?utf-8?B?ZG95QXBMa0tVMkRaK29qUWErRlZZaUJqMHdzSXlPUW92ODM1RWFwNzBIc1lt?=
 =?utf-8?B?VmgrcXVDallJd2FtWnJUVFl0Wlk2TFhYMmkyK04xNzkzY0MvTnA3bUZSWDlW?=
 =?utf-8?B?dXZnRHpSQjlsb3VIQU5RWU1KR2gyRlhwaWoyQnlheU5Cd2NXSVRkVnBudTRJ?=
 =?utf-8?B?SEVRdUtTejE0Yk85TGNTcmdPTWUxaW9ZbDRJaE5OYjBIdnBuR0t0TjZDSGFi?=
 =?utf-8?B?alZoc0NQeGZKRDZFRHlMa3RvMWRsWk15MVVVTkVSdW9Qd2NlMm1MTG9VdWo3?=
 =?utf-8?B?eFFDc2lyK3pHSzRyZjBwcHJ4M1BOaXpxM2tVMkNzaHpMOGN0bC91K21FVDhD?=
 =?utf-8?B?QU5TR09zL09venZQOHMwbk01cFNDejd1K3ZTV093blBnVlExQ2RPTGZxQVMv?=
 =?utf-8?B?WGk4YlRNOXpHdndlMVF1ODZhRlQzeGY4Tis1ZnJiUG5rZGd5MWx6Rjg3QmFT?=
 =?utf-8?B?SmFwYVBnM2tYdjhyZ1l4amhEQ2JBU2kyOFFNTlZ0RmJ6SGpub3hzdmdCcVpr?=
 =?utf-8?B?MS9oZUFvVjFYV2lXK1Z5TjNGSjhqdExFSjJkTzlYSHQ3eVNONDFob3ljUU5I?=
 =?utf-8?B?NHFMaWFjRXF6ODhDVnhmaWtESS94dUlzZldvdzRHMkdWdHBPcGwrMWVjbWJQ?=
 =?utf-8?B?VlhlNTR1QkRlTUt1NFUyTzhnU0dTVi9mZTQ0ZTU1U01XMVNRKzA1VkUxZ3dr?=
 =?utf-8?B?VUJUbURBSjF1bUpWMWltaTRVSDU2YWIzQzN3OTdHczVGMVUrZjZvaDlqY2Z3?=
 =?utf-8?B?N1pKbkJMT1B3QWhuemh3QlhzZTIyM3hrRzV0NENERGI0L3B0dmlldXc1aW42?=
 =?utf-8?B?WFhxU3JSQ29XRi9IMGVma2NVRFJxa0pySTNER1VPYWdmK0w2dytlOE94SVhq?=
 =?utf-8?B?YUdPSDVKSGh5T1ppaUZLRGtneWpJTUNBMU1ZNUl1SDlCWHJCdW5BVUxORE55?=
 =?utf-8?Q?3inObd9trWzmhzaL5BhkcCKESR9r1xCQhqstJuC?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 6d2ed056-ded4-43b7-5617-08d992448efc
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2021 14:35:40.6039
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: c0CxVatsxq4XxykFV2B6qImpOWrHZDTsgXtcUnPo+fR7P9hOx8/VcXCifFw1qdLff06qRDyyEhuIlNfyUQ4LOA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR03MB5525
X-OriginatorOrg: citrix.com

On Wed, Sep 29, 2021 at 11:43:32AM +0200, Jan Beulich wrote:
> It's not really needed and has been misleading me more than once to try
> and spot its "actual" use(s). It should really have been dropped when
> the 32-bit specific logic was purged from here.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>

As it makes the current code clearer. I have one question/concern
below.

> 
> --- a/xen/arch/x86/traps.c
> +++ b/xen/arch/x86/traps.c
> @@ -327,16 +327,13 @@ static void show_guest_stack(struct vcpu
>  
>      if ( v != current )
>      {
> -        struct vcpu *vcpu;
> -
>          if ( !guest_kernel_mode(v, regs) )
>          {
>              printk("User mode stack\n");
>              return;
>          }
>  
> -        vcpu = maddr_get_owner(read_cr3()) == v->domain ? v : NULL;
> -        if ( !vcpu )
> +        if ( maddr_get_owner(read_cr3()) != v->domain )

Wouldn't it be more accurate to check that the current loaded cr3
matches the one used by v?

AFAICT we don't load the cr3 from v, so it's still possible to have
diverging per-vcpu page tables and thus end up dumping wrong data?

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Mon Oct 18 14:37:35 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Oct 2021 14:37:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.212396.370250 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcTle-0002z7-JP; Mon, 18 Oct 2021 14:37:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 212396.370250; Mon, 18 Oct 2021 14:37:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcTle-0002z0-GB; Mon, 18 Oct 2021 14:37:34 +0000
Received: by outflank-mailman (input) for mailman id 212396;
 Mon, 18 Oct 2021 14:37:33 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=628V=PG=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mcTld-0002yo-2i
 for xen-devel@lists.xenproject.org; Mon, 18 Oct 2021 14:37:33 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 11ec28ef-53ad-4d86-82e7-350e3be86420;
 Mon, 18 Oct 2021 14:37:32 +0000 (UTC)
Received: from EUR01-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur01lp2052.outbound.protection.outlook.com [104.47.1.52]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-30-aMMsglb9M8Sxq7tCMiGrTg-1; Mon, 18 Oct 2021 16:37:30 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB5903.eurprd04.prod.outlook.com (2603:10a6:803:e0::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15; Mon, 18 Oct
 2021 14:37:28 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.018; Mon, 18 Oct 2021
 14:37:28 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS8PR05CA0019.eurprd05.prod.outlook.com (2603:10a6:20b:311::24) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15 via Frontend
 Transport; Mon, 18 Oct 2021 14:37:28 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 11ec28ef-53ad-4d86-82e7-350e3be86420
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634567851;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=VYjnVbrOhzDxKhw0di1UZRg5iV3yoY01rT65162/l4I=;
	b=S89OYAIHdsIs/HbcGvETsPNJj9nQWlJjEBHQXuM7jyzKa5cQLnU5j2TRxD6OxpiEnu6sMf
	tC/JynobVF/OHWImHdzEmBhGJiFYIeG/QVYZMKhjB7LbGXE9m+sejN0w6OocftyPjuUC/z
	BELhdPEkGYgexlKV1Rsgfk6mKe5cT9o=
X-MC-Unique: aMMsglb9M8Sxq7tCMiGrTg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=F7af2cOsPFseG2NXSm572PpIHHgnSKqCO8cH4JcdHteiFt0tV2OLrP4sfymTr38wmRxQA0EMd98Q5x81IKV5LC63lkOxpIra66xzZOmbeJAMX7gDm3Gja4ZtpbrzXiwJQQupV2EEDFmwY6Urb4y0zkAiuYMFHg1XxoT3RrbXZL6k0LnczkUPO6q4j4ReMQ86TomBoQK5WuEl0rh7yOE/MIzs/Ghi091bBt8ui9xw3ti8lpE9wF/gdgpoBnUr0I1NNDmGEBeJUZJxBDD1cmP7FNPeDmZ8pYRHcgY0049js/5x/zYv0yswR0MdaWD3ZI9MhncgdM+AIU8A330uYf8Byw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=aYnM3Cx+t/POs6nJpfu4JnU+GlMJPoe3IG/zUlueIVM=;
 b=B6jNuNXsIIF7mr3002b0iXEQoCYBi40knjhCxxKsdmUhCKxcEFhZ0Tt5emYKUGmWBWgLosrriF9+izzUKg8WoBCbxv8sRd1YOEuEoowof3J//GStgN/f7FBQQcH/3ftT7wsfLNcojnb8WohFK4aiqfCyUiaTx3t2S5I6ThdUsu1Ezrw+1QumBd9HIzaA/YaElmTl2DDrNDkxhhRzEqAhnlmuQYJYu00AaFY2wGIfcvFmXP/I2LRHy/kGJN3jeIPpXVT3/JfPKta38GJCoCLPPuogfoHbTifziNW+IQJCtk6p71hs99x25vawsrnG1HxJ2y/kOkqcrvh+TXO5fvVAvA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: xen.org; dkim=none (message not signed)
 header.d=none;xen.org; dmarc=none action=none header.from=suse.com;
Subject: Re: [PATCH 2/3] x86/PV: replace assertions in '0' debug key stack
 dumping
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
References: <2a14f2d0-2a53-287f-da36-dfb054c7f944@suse.com>
 <5ab88195-660e-5d73-cc34-67734ae161fa@suse.com>
 <YW2EJaZ4DoR6ptp1@MacBook-Air-de-Roger.local>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <1a9b77bc-3637-e1c0-4a8e-63126e643aba@suse.com>
Date: Mon, 18 Oct 2021 16:37:27 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <YW2EJaZ4DoR6ptp1@MacBook-Air-de-Roger.local>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS8PR05CA0019.eurprd05.prod.outlook.com
 (2603:10a6:20b:311::24) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: c9677b6a-563e-4adb-bdae-08d99244cf86
X-MS-TrafficTypeDiagnostic: VI1PR04MB5903:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB59037F214242DF002DD8FC6DB3BC9@VI1PR04MB5903.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	syDubcmc5fVYj2BADgW086KOl5pjmWJjkW0dNEVTo1NvF5Hm5zG8rUjv1pciD6t/NOhDR5gQMijeIGsmWFe5YAb6tVPAndQDhk5QXN9y9PmyxDXSH/wzBHK842kO10CqIGKT0hxHm3RG+9XKJIUYTQkS4rFzi1Yhze6M9sJnmIpn7aoS225DcY8NbXIkHWReiuy2uUvnWf4fSDNOUdMCtYWFPF2DOwiQNLx4Luv8r+IqHU5seoG1KZQ2A9754/k4wg+rmwIjk5RiumOLqQ/uFqYZJ7VdKqnSMadV6wrIyogx4t0DdR4P9eE9Nx3bENPS9l2s0uIRieu7jlI+CgRYtySbvYdoT6I4nLjFgP5RZUu88edA+va7Ll9L+rNrTW2emPPs24XBIt7ULb0QpJVumO4JShAGZ588ceJ3hSngvGaFbEwlf+8FQUAq6fvCbpC43/CFUz7x8sbJcOMNglwhzMtj+jkQAJzQR0XEBX1Fx1GVUJ7iEQiZrirwYVI13SA4//lFBX5VMkwCxFcmtQrMr8N4Pkwc97etAPLPS2LA8qL1zy8YwVmLxqxCKZozc6D7Vwj2kWJr0HuVeG1H960ZIeDhZGTTeDhXFHLtGSaaDGpWN4L0ZDjKvJ/CKFyLADCThiGBQQZ/ppL7JZ0/qlgFH+gaVYd1LPXfrJobVQiuC9vZ00KVySAvNbxgAaPsU1Dd6osxJXQUQXEk3tKFTi/euyyc/SVtXn5UEc4uot8+6Ar+TpvqrVDcvG/eeiykAHAQ
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(6916009)(53546011)(5660300002)(86362001)(31686004)(16576012)(508600001)(186003)(38100700002)(26005)(2616005)(6486002)(31696002)(956004)(2906002)(8676002)(66946007)(36756003)(8936002)(66556008)(66476007)(316002)(4326008)(54906003)(83380400001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?agz0rMgCM/4+Uc7827AjEB3Lk/p5pVDoM6zcPAd0Bve8Hmxnk4H+tlVyDqPe?=
 =?us-ascii?Q?7CFk44Imd/P/lvXUw9lAJ7gq4xCmfhOwpEko+3/9ntrVitlXIzQJON+Px7Vh?=
 =?us-ascii?Q?mYMXdQLIuKWcbZBVbldKqfe4DzQcfMFRblvqQVqR3kCMMyh01+LCB3DxvYo7?=
 =?us-ascii?Q?NzZV0dxiArOkhAQU89F7TZXGL6tBX711hTq/cHla17t1rTmcvGRSoRw0zgam?=
 =?us-ascii?Q?gPP+nbRUIEjX9lP57cpAFXuEJhSI+euz5X/CDjdEcMmz9gl9nvJH38OIuQlT?=
 =?us-ascii?Q?0v8ZFba0MWyZLramHu1KebuTA4/2ZMD9aABJVzLm6+sgkX8s3F98GhZOkBob?=
 =?us-ascii?Q?Ge+/STt5sDGRAH+qeZj8luXTgtyiNht+LKWedCiIOr/SH9XagBNUlYrL4lmR?=
 =?us-ascii?Q?DdjzsbJFduHJ3aRY+Ed3hGccx/z9magsSL+ndqOBFvJlulv211ItGOxjqVN1?=
 =?us-ascii?Q?FxsHTrFBmVamrDaNkwDGuSbJqBHzlchBUcZCDJ6yTO4X2tjQ4C7qVVMH/RUL?=
 =?us-ascii?Q?LkJDDqJlf2DPDPEupjR/H8A+YPKx629YVW2fOH/OUJrK/1BtuM+LVB7FaQKu?=
 =?us-ascii?Q?gTyPIcIj2fcMICtSU9nGbNttNrv89AeXBhtySjv7gQkWY38PHdYeRSBigxUu?=
 =?us-ascii?Q?p4KBgm47u6UmlYAGkcwivF09yb0Leol5m1tKkWk+D1Jy7saMgY0yuQq3FeNG?=
 =?us-ascii?Q?FxUVE2No/xkQ1hmLqXdsL3nUoV9zYhhNh+9IA5HL7rGdgSCJ9hyG7WcKxLmh?=
 =?us-ascii?Q?TERDy6aZA4O/1s7WFgFVyQe+lF6m30e/aAUoaIwVL91Iu/Qi7dNUNnXxuPFO?=
 =?us-ascii?Q?7epi1RYS8raGnhLCibsRXglB6YE3qxfz0ANq5WPSqHG1Nwy6LeZG/QspuSJG?=
 =?us-ascii?Q?xJLhoaTzHbRw5HgUUNgRGVzq27mn85ClbheDzKCB6tzY3GzM9NfKKi9ikora?=
 =?us-ascii?Q?w8CN4eQnTgd/nVw4AfN6mZQRc4xX32HIF0CLnZ6Z/G/reNme/Qcfx4c4aCZJ?=
 =?us-ascii?Q?MpDF1AN3e8qO9txDW2bGx0iuAB1nnIf11DbVORp96TNmtYC1OnuKgNxUTdg4?=
 =?us-ascii?Q?ZPt9bYzdJmKyudqsBU69rBx2i7vKPUZoepdkzMgXm0l0hkYV5IhfphKW0JlL?=
 =?us-ascii?Q?CiDBW3wT7GqBk2ZUAjl3PabJnzHGqRBxyntL6jhsWH20d17euiOWfTN4nt19?=
 =?us-ascii?Q?9zcFjOBzYyCyZYTq2O7H+ZmEA6ouHs23YA8R6LXS6FJ9o48S8w2AJ5YHAl4C?=
 =?us-ascii?Q?3bra6ULv1zPdZW9VVQnZUkvBVXmkfl3qNEErcwQmpdzJP1pe5OcVWR3l4zEC?=
 =?us-ascii?Q?YD+uQz6asiZ+vISfIW08Brd6?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c9677b6a-563e-4adb-bdae-08d99244cf86
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2021 14:37:28.8430
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: AchZPzcykyGTkb8/YAIy7yIDkTNP9u8YAPGvPqFaIZ+sL2m4WT/rM6Se6jf3UxnKXQJxrtJhwLlzJOrC6pcUrQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5903

On 18.10.2021 16:26, Roger Pau Monn=C3=A9 wrote:
> On Wed, Sep 29, 2021 at 11:42:54AM +0200, Jan Beulich wrote:
>> While it was me to add them, I'm afraid I don't see justification for
>> the assertions: A vCPU may very well have got preempted while in user
>> mode. Limit compat guest user mode stack dumps to the containing page
>> (like is done when using do_page_walk()), and suppress their dumping
>> altogether for 64-bit Dom0.
>=20
> I'm slightly lost by this last sentence...
>=20
>> @@ -328,7 +329,12 @@ static void show_guest_stack(struct vcpu
>>      {
>>          struct vcpu *vcpu;
>> =20
>> -        ASSERT(guest_kernel_mode(v, regs));
>> +        if ( !guest_kernel_mode(v, regs) )
>> +        {
>> +            printk("User mode stack\n");
>> +            return;
>> +        }
>=20
> ...as you seem to unconditionally prevent the dump regardless of
> whether it's dom0 or domU as long as it's not a kernel stack?

Well, Dom0 comes into play by way of me talking about debug key '0'.
I've replaced "Dom0" by "domains" in the sentence.

> I assume when running in PV 64bit mode user-space could be executing a
> 32bit program and hence Xen could then misprint the stack as a 64bit
> one?

That's not a primary concern, I would think. The real problem is
do_page_walk() doing

    unsigned long mfn =3D pagetable_get_pfn(v->arch.guest_table);

first thing: No consideration of guest user mode here at all. And
I didn't want to teach it without real need.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Oct 18 14:37:35 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Oct 2021 14:37:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.212397.370261 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcTlf-0003FQ-So; Mon, 18 Oct 2021 14:37:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 212397.370261; Mon, 18 Oct 2021 14:37:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcTlf-0003FH-P0; Mon, 18 Oct 2021 14:37:35 +0000
Received: by outflank-mailman (input) for mailman id 212397;
 Mon, 18 Oct 2021 14:37:34 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=RpTT=PG=epam.com=prvs=0925c93432=oleksandr_andrushchenko@srs-us1.protection.inumbo.net>)
 id 1mcTle-0002zA-Lf
 for xen-devel@lists.xenproject.org; Mon, 18 Oct 2021 14:37:34 +0000
Received: from mx0b-0039f301.pphosted.com (unknown [148.163.137.242])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id ee35016a-3020-11ec-82d8-12813bfff9fa;
 Mon, 18 Oct 2021 14:37:33 +0000 (UTC)
Received: from pps.filterd (m0174683.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.0.43) with SMTP id 19IDtc83020423;
 Mon, 18 Oct 2021 14:37:29 GMT
Received: from eur05-db8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2105.outbound.protection.outlook.com [104.47.17.105])
 by mx0b-0039f301.pphosted.com with ESMTP id 3bs3h7a2p7-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Mon, 18 Oct 2021 14:37:29 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by AM9PR03MB7347.eurprd03.prod.outlook.com (2603:10a6:20b:268::8)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15; Mon, 18 Oct
 2021 14:37:25 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::c038:e032:595a:651]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::c038:e032:595a:651%7]) with mapi id 15.20.4608.018; Mon, 18 Oct 2021
 14:37:25 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ee35016a-3020-11ec-82d8-12813bfff9fa
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=MJETXD7IJXDn/nGotwQLk/M6PLbylLVSkQEPTm9HiEmnHNWfqu4wmAVJDQ5oNagugGk8b7fz3pCxERUZIj/euRM1zRykx87RIt8RMlClyv9+WTnmfC1Fqbdf5vGVOPLlD5fblk7nreXzo/OrbXVQChxQcZqXaz3fvfQqZR0Uf703red92v/kwCeJzySxgT4t9UMGHzKQFIGajFxkxyMHO0VsVJK2VVxSN0Y7RypW1DtymnN8YhREh72jABJlzXXdbdej8nqpIN+eskmm/u/1hC1EGhcBINaCj7lw9YSKx3ro4zrEO97W/CsF4Og0Sgry1eDZ8mbt0NTkfwpyE3G5WA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ThbFuXUWyrEFc3RCtDoI1+ASJRiaghDVi5Dc9xXoh8E=;
 b=A0UCHgFGrJe6P/8m9Rva5kd3M1EEJm2eQjdOvMbrT9KV/KbUHiwobyuiHKj3OMRCmND6QJKdGKLVqlGVJ6RnNw7+pLo2CIWR4llnTlLoKT8zon4+tFBo7oo2f9Ckg2WuhuLg9hTrb9tiOfsjAa7+EuDSxteScEYXl4n7z0zJUQno+kDcn8p3XYk7ZuRj8rWypjSn6i3X/S68UBBZwJU3s7LizdH2dDRQF7TexiLkY9Rq33NwD34Prk9037J7+eVfQo0HJgS1lD4lFOiHIJlcmimtaovLOol6G/sndm0QuT6nMfrPQEmUHn7DNXCUd+Gpmb6g6GxckV8jhT9iShlrmg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ThbFuXUWyrEFc3RCtDoI1+ASJRiaghDVi5Dc9xXoh8E=;
 b=MfgspaaMsgnxm9nWZcdJfvXu9tW+W6HV7/WP2trIXuNpnZUXJ76VsHPiunjRrPyebqscyNEcKzNBSTf9zRa2Z1GFRppMPiC4l5QE/y5dtwEaLTyLBQmf+8OLDIFYjTtS9AZYW1cMjz/s85pNSMTPUXzkdZ9qJ3XJAOhKUgiEqpzNCPImLMpW31Is3U0/+ZxZW+froum7cECtzMrxnESzhxdWr6V+PKvHr0nOqNTDkxw/KPINUtKMlRLSuNe0Ah4JDeBOXnJNNRdaH1mVdZB0p37n4FPnO5eA/n6+lrFtW+vJWs5RM46BZNXWypoT5eQXfEye/8Ceziql+QCJU9KzAA==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Jan Beulich <jbeulich@suse.com>,
        Bertrand Marquis
	<bertrand.marquis@arm.com>
CC: Rahul Singh <rahul.singh@arm.com>,
        =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?=
	<roger.pau@citrix.com>,
        "sstabellini@kernel.org" <sstabellini@kernel.org>,
        Julien Grall <julien@xen.org>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Andrew Cooper <andrew.cooper3@citrix.com>,
        George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
        Paul Durrant
	<paul@xen.org>,
        "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>,
        Ian Jackson <iwj@xenproject.org>,
        Oleksandr
 Andrushchenko <Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH v8 2/5] xen/arm: Enable the existing x86 virtual PCI
 support for ARM
Thread-Topic: [PATCH v8 2/5] xen/arm: Enable the existing x86 virtual PCI
 support for ARM
Thread-Index: AQHXxCmHx+Lzp09rU0elFmx0jxVt5qvYzfUAgAAFDAA=
Date: Mon, 18 Oct 2021 14:37:25 +0000
Message-ID: <2a47d0d9-a821-bd2d-62ee-173ccf5374e8@epam.com>
References: <cover.1634315461.git.bertrand.marquis@arm.com>
 <e2b10f56043155e4bb8eae824723045ccc042f8e.1634315461.git.bertrand.marquis@arm.com>
 <ca5558b2-25c6-90d2-284b-03cbbb02691f@suse.com>
 <FBC4FA6D-AF07-437A-BD81-52708B139070@arm.com>
 <8c99e635-9509-b078-2285-48fb6fb91507@suse.com>
 <46bcd42f-df4f-922a-cc21-a05821481754@epam.com>
 <17fd4f89-9afa-f65c-c66d-1364d7474969@suse.com>
In-Reply-To: <17fd4f89-9afa-f65c-c66d-1364d7474969@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
authentication-results: suse.com; dkim=none (message not signed)
 header.d=none;suse.com; dmarc=none action=none header.from=epam.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 497a1cf9-9487-4dbf-4404-08d99244cd8c
x-ms-traffictypediagnostic: AM9PR03MB7347:
x-ms-exchange-transport-forked: True
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <AM9PR03MB7347D7C08ACD2E355C61A049E7BC9@AM9PR03MB7347.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 d3Vxz+VacT7S4p0aq8yBuP0tOr85/KcCf7FDuPFY9cNLnSOCKKOaq6BeIXF2sTvcjjNrHgLpSph8UfpdenPTz1NsJWsCtfjz6bs9BSJasPfmVwyG6kMJphXNsxZ9mEH0DqpxC61u9EyLjnkODV01MDzRHhVYR79Z/mPI9GfrCP0fDV+80hDsfosyJxhzgamvPf98g271C/UgwBqdYGIL/rCg9pU1ht4oauMLeg3J0XP8EVSisiugIBA/vof/WocM3DQbZnMCXbYYxJc4SzTnD81z4QJd9Fh1KkXnPkjSMyZ+CwHVgXsP3dv0gU3bOuqHt8BecPtNLAz7Ym+SPTePpg365XxtfLCoQWPe0URegr2Jpm/CcL2s69y3pE718mEVhYRl9/0nhHjbunUAylg2veGTavnIMp/MU4aQYE8MpDPfjL6AJ98ETvOggUHTLUULdGBIBBxJkeKl9+E224iK7F+HiotZV6bcARoe1dyDzVo4ziyrkvZygNs5Gb74hvbLIH+mX3xXKIY6yLxUDwv7YZAPMh8giWGWHY+1XysEU4y8xOPVU2/xo8yQ5TiR4qEsobvxQkH6ooi6PAvBoAQFMEZckFOKG2GeNBAHUZFJC/ms9tF/1/MEWn4zKBsAn8khlw94UZodIj+43yD5hvVpCSDGqz1A3zHW4cK2VAehsnH6wX2WusGkxBIxtGt8zdcxPEC0j1iRu+LzgihbfyJc8URr9qza0f3byy2i1y7OvmkqEAsxyQJCYTj1eGp2qlcWNLzwLYVNX+WV/JO0Z24zwVpPP5+JHX7/U1Klhvgo6ugEBGQgWsI0IuNxkgh3ty9h2aIOsnzAtUH3FsgKs1l82Iy0zgDC65zWNfU6Mef2/9k=
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(122000001)(2906002)(4326008)(107886003)(91956017)(8676002)(110136005)(6506007)(316002)(31686004)(2616005)(38100700002)(31696002)(5660300002)(36756003)(6512007)(38070700005)(508600001)(186003)(7416002)(6486002)(86362001)(71200400001)(54906003)(66946007)(66446008)(66556008)(64756008)(26005)(76116006)(8936002)(66476007)(966005)(53546011)(83380400001)(2004002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?VVdVdEQwcWk2YWFhYmJwR1E5M2JIb1ZXM21Pb2VBelJOb2o0Z2gxQlpPTXJm?=
 =?utf-8?B?SG1mUDJVQWRvMmZoNmdqMGhRaFhPYlhPRFR3WDlvWVJrblZpOG1sMlpNN3Jl?=
 =?utf-8?B?ektLZ29yOGk3bmFPZVpNc1BtaGlIekJ2Nk1pSWxISi9WL3pZUkhXeDRWZTBD?=
 =?utf-8?B?dXVHNFVDWTZ1Z1RpODkvYXYyU0xkWk9UT1F1WUFxSDdBeTBRV1crOVhzS3Fr?=
 =?utf-8?B?OWJuTmFHWlpqOHJLejZkZmUyMkF6cUVOMzVKY2EvK3RKNVNlOUpIYXpWR2ox?=
 =?utf-8?B?aVFhTU1yM1BiRGIyclJLL0k1RVpWQkZEOHJ1VTdRV1RGdjk4OXl1c0w5S3hQ?=
 =?utf-8?B?dlpqdU56b0laMHhYc294ZGxITU1qNUpJMGhwbHJmYkkzYW5CTFlrN1lPTkY0?=
 =?utf-8?B?VzAyTzd5aTkzR09lN2ZKNEdMTVkwYy9wcjlveUJ5em1PSzdvWHBvN2lBWWc0?=
 =?utf-8?B?bm01SFQyQk40cDFpTXZrUTQvRjhFbHBaVGNVbWdYTlh3eEpvcXNhK0FJazJm?=
 =?utf-8?B?Z2Y3UlZVMXZMeGdZU3ByZFhQUkttQmhNTEdrbjNqQjUxam8yaDBvTCtWaXBN?=
 =?utf-8?B?Zk1kKy8yV0JqUUFXSHVyZko4WjlTY1BnVzJiY0FJOHlVTnhCL3lNemZoQ2xx?=
 =?utf-8?B?RUM0UkRtNFdycDJoYmNjYklDd01yaVZya3k5STFVNy9qbTdhYi9hSWQ0cWY4?=
 =?utf-8?B?ZnQrRlM3NG1VMnNTRTdVemtIS0x0ZHVlTUt5NHYyWjB4R1JLOXIyNVh1RjBa?=
 =?utf-8?B?cG1sUXAwRGloU25YclpQOE5Jak1VYWdFdTI5WXlhaExMaHRsMGVQQ2x4UTJm?=
 =?utf-8?B?RXJ6YkNCZldiYXRETzFXUmo5eUJiUVRaRlA1Zng5TU9LU3Nqcy9KVTRGa0dM?=
 =?utf-8?B?UThSZ1dCNVVwUDkyTDRzMUpDOFlJYUNBNHJackY3RHN0M0RCNTFYVXNGaXQ4?=
 =?utf-8?B?bC9oUVJFelI3bTc3U1o5eVVWSFA1c2lRT01DY0kxUHZXeERIaGoxMFRtcUhQ?=
 =?utf-8?B?WFZhdWlhRmRhbm03alpJMXpGZVUvK2wwYnlNd0IxWDk3Qm5McGc5VWt6THhD?=
 =?utf-8?B?RnJ1Z2c0bFJJQ2N3OUdOOXk4QjUrLzB4NGUxeXdHRTlqcW0ySk9JSG9zMk8x?=
 =?utf-8?B?REc3S084OWF4OG9WaUJzOUlpb1NjSThnL0U0WG1Td3paTHBSNjg3YjM3M1A0?=
 =?utf-8?B?OVA1QUtEL21KV0JYalgvcTI0eHR5VXkrV2daKzRza2l6YjJYOFBJdVVLNC8x?=
 =?utf-8?B?MXhrMlZQN1JpU3lHQVRTRVRDcDV6UGw1K0pNNmtzUzJhM0w4VS9uMXZINGRQ?=
 =?utf-8?B?SlJPTXRuUkE5TWRCdDE1WnRNR3RYQ3AzbW1tU21YV1RQb0NoZG53aFNST01u?=
 =?utf-8?B?b1hWWnQxOXpFTDBGbTRiWmlXelBpZ21UU3NtdVV1di9sNG1xcjNRdVByS29a?=
 =?utf-8?B?M3cxY3gyMTVIc2puYmdKcGhObEpjWi9MVlZTRjNLUjZQT1pnK1VTR3hWTkxU?=
 =?utf-8?B?T282eU1uYlYzTlQ4WFRiRUQyeUFIRHhWQUJpN1RyMWJsclpLMFF5Vmc5RUFH?=
 =?utf-8?B?S0tyTUxIV2dpUWdwUXVGcmNWRWo3Z0JlQWNKRVFNOFdUekJMelZSa0dleXhz?=
 =?utf-8?B?Q1Uyekc5RGV3ditDZUkrWjRwNnRyTzFLc0plNC93V2FQd2pVWE13NVE1T0xR?=
 =?utf-8?B?YTJxQU4xWi9kNUFSNHpGbzUwSXg1ZTFhc3NOVTkxN2lPeFVrN1ppa1FzREgz?=
 =?utf-8?Q?iJLejpP1b/oZrJYUpHgpqrPgZ4pdE8mGhLxmgYw?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <19326AE6EBC07D4589B0442A2B775794@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 497a1cf9-9487-4dbf-4404-08d99244cd8c
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Oct 2021 14:37:25.2673
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: njBcO6Zc5Xb5T6rNfMoTRRyTJ5QlkeVgk4bcxbbncAK8t13ONiDFTxk36BCrGtPQ81qbn564Elm5ZFjpfS6n1JP3lGL4cobhLQbyrm8ItmbVwlABoqSptdwEbMdglYmw
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR03MB7347
X-Proofpoint-GUID: ANxlWaRtaGeCMCrYZX4o4NM1dXP6raZW
X-Proofpoint-ORIG-GUID: ANxlWaRtaGeCMCrYZX4o4NM1dXP6raZW
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475
 definitions=2021-10-18_06,2021-10-18_01,2020-04-07_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 adultscore=0
 bulkscore=0 impostorscore=0 clxscore=1015 mlxlogscore=999
 priorityscore=1501 spamscore=0 malwarescore=0 suspectscore=0 phishscore=0
 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2109230001 definitions=main-2110180090

DQoNCk9uIDE4LjEwLjIxIDE3OjE5LCBKYW4gQmV1bGljaCB3cm90ZToNCj4gT24gMTguMTAuMjAy
MSAxNjowNywgT2xla3NhbmRyIEFuZHJ1c2hjaGVua28gd3JvdGU6DQo+PiBPbiAxOC4xMC4yMSAx
MzoyOSwgSmFuIEJldWxpY2ggd3JvdGU6DQo+Pj4gT24gMTguMTAuMjAyMSAxMjoxMSwgQmVydHJh
bmQgTWFycXVpcyB3cm90ZToNCj4+Pj4+IE9uIDE4IE9jdCAyMDIxLCBhdCAwODo0NywgSmFuIEJl
dWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPiB3cm90ZToNCj4+Pj4+IE9uIDE1LjEwLjIwMjEgMTg6
NTEsIEJlcnRyYW5kIE1hcnF1aXMgd3JvdGU6DQo+Pj4+Pj4gLS0tIC9kZXYvbnVsbA0KPj4+Pj4+
ICsrKyBiL3hlbi9hcmNoL2FybS92cGNpLmMNCj4+Pj4+PiBAQCAtMCwwICsxLDc3IEBADQo+Pj4+
Pj4gKy8qDQo+Pj4+Pj4gKyAqIHhlbi9hcmNoL2FybS92cGNpLmMNCj4+Pj4+PiArICoNCj4+Pj4+
PiArICogVGhpcyBwcm9ncmFtIGlzIGZyZWUgc29mdHdhcmU7IHlvdSBjYW4gcmVkaXN0cmlidXRl
IGl0IGFuZC9vciBtb2RpZnkNCj4+Pj4+PiArICogaXQgdW5kZXIgdGhlIHRlcm1zIG9mIHRoZSBH
TlUgR2VuZXJhbCBQdWJsaWMgTGljZW5zZSBhcyBwdWJsaXNoZWQgYnkNCj4+Pj4+PiArICogdGhl
IEZyZWUgU29mdHdhcmUgRm91bmRhdGlvbjsgZWl0aGVyIHZlcnNpb24gMiBvZiB0aGUgTGljZW5z
ZSwgb3INCj4+Pj4+PiArICogKGF0IHlvdXIgb3B0aW9uKSBhbnkgbGF0ZXIgdmVyc2lvbi4NCj4+
Pj4+PiArICoNCj4+Pj4+PiArICogVGhpcyBwcm9ncmFtIGlzIGRpc3RyaWJ1dGVkIGluIHRoZSBo
b3BlIHRoYXQgaXQgd2lsbCBiZSB1c2VmdWwsDQo+Pj4+Pj4gKyAqIGJ1dCBXSVRIT1VUIEFOWSBX
QVJSQU5UWTsgd2l0aG91dCBldmVuIHRoZSBpbXBsaWVkIHdhcnJhbnR5IG9mDQo+Pj4+Pj4gKyAq
IE1FUkNIQU5UQUJJTElUWSBvciBGSVRORVNTIEZPUiBBIFBBUlRJQ1VMQVIgUFVSUE9TRS4gIFNl
ZSB0aGUNCj4+Pj4+PiArICogR05VIEdlbmVyYWwgUHVibGljIExpY2Vuc2UgZm9yIG1vcmUgZGV0
YWlscy4NCj4+Pj4+PiArICovDQo+Pj4+Pj4gKyNpbmNsdWRlIDx4ZW4vc2NoZWQuaD4NCj4+Pj4+
PiArI2luY2x1ZGUgPHhlbi92cGNpLmg+DQo+Pj4+Pj4gKw0KPj4+Pj4+ICsjaW5jbHVkZSA8YXNt
L21taW8uaD4NCj4+Pj4+PiArDQo+Pj4+Pj4gK3N0YXRpYyBpbnQgdnBjaV9tbWlvX3JlYWQoc3Ry
dWN0IHZjcHUgKnYsIG1taW9faW5mb190ICppbmZvLA0KPj4+Pj4+ICsgICAgICAgICAgICAgICAg
ICAgICAgICAgIHJlZ2lzdGVyX3QgKnIsIHZvaWQgKnApDQo+Pj4+Pj4gK3sNCj4+Pj4+PiArICAg
IHBjaV9zYmRmX3Qgc2JkZjsNCj4+Pj4+PiArICAgIC8qIGRhdGEgaXMgbmVlZGVkIHRvIHByZXZl
bnQgYSBwb2ludGVyIGNhc3Qgb24gMzJiaXQgKi8NCj4+Pj4+PiArICAgIHVuc2lnbmVkIGxvbmcg
ZGF0YTsNCj4+Pj4+PiArDQo+Pj4+Pj4gKyAgICAvKiBXZSBpZ25vcmUgc2VnbWVudCBwYXJ0IGFu
ZCBhbHdheXMgaGFuZGxlIHNlZ21lbnQgMCAqLw0KPj4+Pj4+ICsgICAgc2JkZi5zYmRmID0gVlBD
SV9FQ0FNX0JERihpbmZvLT5ncGEpOw0KPj4+Pj4+ICsNCj4+Pj4+PiArICAgIGlmICggdnBjaV9l
Y2FtX3JlYWQoc2JkZiwgRUNBTV9SRUdfT0ZGU0VUKGluZm8tPmdwYSksDQo+Pj4+Pj4gKyAgICAg
ICAgICAgICAgICAgICAgICAgIDFVIDw8IGluZm8tPmRhYnQuc2l6ZSwgJmRhdGEpICkNCj4+Pj4+
PiArICAgIHsNCj4+Pj4+IEhlcmUgaXQgaXMgcXVpdGUgY2xlYXIgdGhhdCB0aGUgU0JERiB5b3Ug
cGFzcyBpbnRvIHZwY2lfZWNhbV9yZWFkKCkgaXMNCj4+Pj4+IHRoZSB2aXJ0dWFsIG9uZS4gVGhl
IGZ1bmN0aW9uIHRoZW4gY2FsbHMgdnBjaV9yZWFkKCksIHdoaWNoIGluIHR1cm4NCj4+Pj4+IHdp
bGwgY2FsbCB2cGNpX3JlYWRfaHcoKSBpbiBhIG51bWJlciBvZiBzaXR1YXRpb25zIChmaXJzdCBh
bmQgZm9yZW1vc3QNCj4+Pj4+IHdoZW5ldmVyIHBjaV9nZXRfcGRldl9ieV9kb21haW4oKSByZXR1
cm5zIE5VTEwpLiBUaGF0IGZ1bmN0aW9uIGFzIHdlbGwNCj4+Pj4+IGFzIHBjaV9nZXRfcGRldl9i
eV9kb21haW4oKSB1c2UgdGhlIHBhc3NlZCBpbiBTQkRGIGFzIGlmIGl0IHdhcyBhDQo+Pj4+PiBw
aHlzaWNhbCBvbmU7IEknbSB1bmFibGUgdG8gc3BvdCBhbnkgdHJhbnNsYXRpb24uIFlldCBJIGRv
IHJlY2FsbA0KPj4+Pj4gc2VlaW5nIGFzc2lnbm1lbnQgb2YgYSB2aXJ0dWFsIGRldmljZSBhbmQg
ZnVuY3Rpb24gbnVtYmVyIHNvbWV3aGVyZQ0KPj4+Pj4gKHBlcmhhcHMgYW5vdGhlciBvZiB0aGUg
cmVsYXRlZCBzZXJpZXMpLCBzbyB0aGUgbW9kZWwgYWxzbyBkb2Vzbid0DQo+Pj4+PiBsb29rIHRv
IGFzc3VtZSAxOjEgbWFwcGluZyBvZiBTQkRGLg0KPj4+PiBUaGlzIHF1ZXN0aW9uIHdhcyBhbnN3
ZXJlZCBieSBPbGVrc2FuZHIgSSB0aGluay4NCj4+PiBZZXM7IEkgY29udGludWUgdG8gYmUgc3Vy
ZSB0aG91Z2ggdGhhdCBJIHNhdyBkZXZmbiBhbGxvY2F0aW9uIGxvZ2ljIGluDQo+Pj4gb25lIG9m
IHRoZSBtYW55IHBhdGNoZXMgdGhhdCBhcmUgcmVsYXRlZCBoZXJlLiBBbmQgSSdtIHJlbGF0aXZl
bHkgc3VyZQ0KPj4+IHRoYXQgdGhlcmUgbm8gYWRqdXN0bWVudCB0byBsb2dpYyBoZXJlIHdhcyBt
YWRlIChidXQgc2luY2UgaXQncyBoYXJkDQo+Pj4gdG8gcGljayB0aGUgcmlnaHQgcGF0Y2ggb3V0
IG9mIHRoZSBodWdlIHBpbGUgd2l0aG91dCBrbm93aW5nIGl0cyB0aXRsZSwNCj4+PiBJIGNhbid0
IHJlYXNvbmFibHkgZ28gY2hlY2spLg0KPj4gT2ZmdG9wOiBJIHdhcyBzb21laG93IGRyb3BwZWQg
ZnJvbSB0aGUgQ2MuLg0KPj4NCj4+IFBsZWFzZSBzZWU6DQo+Pg0KPj4gW1BBVENIIHYzIDEwLzEx
XSB2cGNpOiBBZGQgaW5pdGlhbCBzdXBwb3J0IGZvciB2aXJ0dWFsIFBDSSBidXMgdG9wb2xvZ3kN
Cj4+IFtQQVRDSCB2MyAxMS8xMV0geGVuL2FybTogVHJhbnNsYXRlIHZpcnR1YWwgUENJIGJ1cyB0
b3BvbG9neSBmb3IgZ3Vlc3RzDQo+Pg0KPj4gWzFdIGh0dHBzOi8vdXJsZGVmZW5zZS5jb20vdjMv
X19odHRwczovL3BhdGNod29yay5rZXJuZWwub3JnL3Byb2plY3QveGVuLWRldmVsL2xpc3QvP3Nl
cmllcz01NTU0ODFfXzshIUdGXzI5ZGJjUUlVQlBBIW1NOEEzOXA4bms0VU1LM1llS01NVzl1YTlC
SGoxVU9XemFRY3l4N0c0NllQZHVkeE1wRDNodXFaZmloMFVjOFMtR3lXWERfbVBnJCBbcGF0Y2h3
b3JrWy5da2VybmVsWy5db3JnXQ0KPiBBaCB5ZXMsIHRoaXMgd2F5IEkgY2FuIGZpbmQgdGhlbSBp
biBteSBtYWlsYm94LiBBbmQgaW5kZWVkIC0gbm8gdHJhbnNsYXRpb24NCj4gZnJvbSB2aXJ0dWFs
IHRvIHBoeXNpY2FsIFNCREYgb24gdGhlIGNvbmZpZyBzcGFjZSByZWFkL3dyaXRlIHBhdGhzIGFm
YWljcy4NClRoZXJlIGFyZSB0cmFuc2xhdGlvbnMgZm9yIGJvdGggcmVhZCBhbmQgd3JpdGUgWzJd
IHN1Y2ggYXM6DQoNCivCoMKgwqAgLyoNCivCoMKgwqDCoCAqIEZvciB0aGUgcGFzc2VkIHRocm91
Z2ggZGV2aWNlcyB3ZSBuZWVkIHRvIG1hcCB0aGVpciB2aXJ0dWFsIFNCREYNCivCoMKgwqDCoCAq
IHRvIHRoZSBwaHlzaWNhbCBQQ0kgZGV2aWNlIGJlaW5nIHBhc3NlZCB0aHJvdWdoLg0KK8KgwqDC
oMKgICovDQorwqDCoMKgIGlmICggcHJpdi0+aXNfdmlydF9lY2FtICYmICFwY2lfdHJhbnNsYXRl
X3ZpcnR1YWxfZGV2aWNlKHYtPmRvbWFpbiwgJnNiZGYpICkNCivCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgIHJldHVybiAxOw0KKw0KPg0KPiBUaGFua3MgZm9yIHRoZSBwb2ludGVyLA0KPiBKYW4NCj4N
ClsyXSBodHRwczovL3BhdGNod29yay5rZXJuZWwub3JnL3Byb2plY3QveGVuLWRldmVsL3BhdGNo
LzIwMjEwOTMwMDc1MjIzLjg2MDMyOS0xMi1hbmRyMjAwMEBnbWFpbC5jb20v


From xen-devel-bounces@lists.xenproject.org Mon Oct 18 14:58:02 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Oct 2021 14:58:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.212413.370272 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcU5M-00067B-Gg; Mon, 18 Oct 2021 14:57:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 212413.370272; Mon, 18 Oct 2021 14:57:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcU5M-000674-Cf; Mon, 18 Oct 2021 14:57:56 +0000
Received: by outflank-mailman (input) for mailman id 212413;
 Mon, 18 Oct 2021 14:57:55 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=628V=PG=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mcU5L-00066y-Bq
 for xen-devel@lists.xenproject.org; Mon, 18 Oct 2021 14:57:55 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 961d76fd-5cad-458f-be7b-ccba4b38a5a6;
 Mon, 18 Oct 2021 14:57:54 +0000 (UTC)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2113.outbound.protection.outlook.com [104.47.18.113])
 (Using TLS) by relay.mimecast.com with ESMTP id
 de-mta-2-ctkxHDk4OzODfcDHAUCHcw-1; Mon, 18 Oct 2021 16:57:52 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB4191.eurprd04.prod.outlook.com (2603:10a6:803:45::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16; Mon, 18 Oct
 2021 14:57:51 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.018; Mon, 18 Oct 2021
 14:57:51 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 FR0P281CA0078.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1e::17) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4628.10 via Frontend Transport; Mon, 18 Oct 2021 14:57:50 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 961d76fd-5cad-458f-be7b-ccba4b38a5a6
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634569073;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=1m4TtRldkkRXons5yLf3aVmrTJjC3JveiTqS1h836Bw=;
	b=jkc5a0jaMOzjaEAgINMD33gMRKo9/dFFgr52PY0FDw/ExjVHrrlTDkLg3IjYUZHHycT6vH
	sMArXtnx3ydba5OMiyA2zH7uaXj+RtE74Bgqdq8Im8A6KK6KLp0SYFNThnegSbhIRn0OFc
	jKJcTZdUF+cNtY2aewHijcJ9b/BNRVQ=
X-MC-Unique: ctkxHDk4OzODfcDHAUCHcw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=LbYXCBJOI9KISs3Tu4BZW1jSFITlseZWsyZGhjiaqe6t5wfyHqfKasV59Vi4gVKwVt/f9bFt1kNy8Mg/MHxzIAb+YWNmvYUDHdlXQLvrL7FiTg8xteBpfIYFYLzVwdTJc9zZfmWkpBqvn6jbiREzHFKQLE7o8CFBcNIAncuHsTfxN8Ln0WfhNHYR6e1JnPrZhVcX32tt/zSm3XSDk9nQQyfQ3YrwfeL7FfXCuOWps/nikrUwrPYvGrTGFnFMadhQ565tzpZqjzxpGCd9FIrFqzoyOhRjNtUn6al2XHJ4QdfustijOqSWMudKGYJLs+7YStCdMGiXOMHZFgGO1JQ5SQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=u8lDDQNRK3N89R4dW4qpZUfSavb1/N19lrDkKZSIOls=;
 b=YbS8izPVr0DKeGqqEEsu2dSqtZaQgL4MQjw351YgoygLo+rIx1PpUpNhZRBoHDQx2hP2k9MACVlQSzSfVlgAfNU8HZb4i4DkEXb6l4Cj2pIVX7E1djBc94NHtvjgZboJip4MFonLkla9dJ5gk5hyEsV26uu/J73j64RK0uEsn0TsJjGDGg5cLnVhOv9aBk5OyBktWl2MQLzVvg3F5qt8U/JXqEiNbp62CF/AsGShGLXVYCVGmFs/zrpaNuXMZ4lVS70vIUgJKQYqOHn7r5niJHB+sqE7oFZExAOyUNmGDI6rEdLmAlohDidimxxMqhb6BsZHydCyUjoBbAk2ewqYWQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: xen.org; dkim=none (message not signed)
 header.d=none;xen.org; dmarc=none action=none header.from=suse.com;
Subject: Re: [PATCH 3/3] x86/PV: drop "vcpu" local variable from
 show_guest_stack()
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
References: <2a14f2d0-2a53-287f-da36-dfb054c7f944@suse.com>
 <6dad4cfb-708d-027b-0fa1-77bb39319fe6@suse.com>
 <YW2GOBRJ9hV7O7AW@MacBook-Air-de-Roger.local>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <2d2a08fc-8199-e356-e3bc-af1a5dfb5ffa@suse.com>
Date: Mon, 18 Oct 2021 16:57:49 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <YW2GOBRJ9hV7O7AW@MacBook-Air-de-Roger.local>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: FR0P281CA0078.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:1e::17) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: a96de4ed-46f2-4374-6418-08d99247a7fc
X-MS-TrafficTypeDiagnostic: VI1PR04MB4191:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB4191584A67559C7560E26D11B3BC9@VI1PR04MB4191.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	54OP4LUaG1YAdVqCYFxPsx+8U0l31mUFL/0XFoA6QVHibrWCTJ3hOUhVA7zvEg86w4aDJ/acQGvPGzEqbrc7MRdW7SQEvHcF71qsUWtWLHl57Hkj3zXCLSyPXjTfxSHd/tVolGH8BV9Z180mzz7uycE4PK0j/F2YSwVYBLIUmGttbkAZdGloxcaXKIX0UK0pkQNUjirwDIN7xl62KmpwV+hmQx48DlksD0HH58NFG5k1n1RUXZYLRMnuJT1EjmWTQfR/ErKwekrOQW8ci50hfh4OvZB2z2COuwo/NqWNu4sj/NhxiG0FFbqdQIDoMeP0Zq+vcldQTmxZdza8CMDM2u+B4nwACLPoFXkQawNlIFME89n+XBPgCI/xijfqaYwKmvJsiOaUCgMzvr7eAKojwMRFX9qeBQbV7dj09waU3rbS9ZwdlQSbFGUJhd5gOVYoWJXghA/5iqItCAqgMxLF6t5bMU/9Z4OilZARNCV5JtHNqnhXJB52yuQvgG99OC5s+bLZORX84Zrfz/p9NApwY72k5whZnchN0zdEtIrlRomLcLBuQlvJF8ID9aPm0rqgkWIXfosPwfsulfTYrLvcti5eP8gOeCZRY/RBd3o8LAsqL5SCRWnh0At1ee7byFcGwdnvbc1sZQLG+klqXPCl2ubbyyhPahA0OHHNLJjKsdJ4V5XeTHTeFtfHIOpizjSB2ino/+Y4xBOuq0V2PC5Dp4liBhV/HCbYl0Oh8MnyZ2YNCl+mTG1Ldmex1byCml2e
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(2616005)(956004)(16576012)(54906003)(186003)(8936002)(2906002)(53546011)(6486002)(26005)(316002)(4326008)(66476007)(36756003)(5660300002)(38100700002)(83380400001)(86362001)(31686004)(66946007)(6916009)(31696002)(66556008)(508600001)(8676002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?cESmklXrNfHPieFSs2iFmixr5NkcgVcby8UDxqK0+ZBikFwfRjwfNq5TEg2n?=
 =?us-ascii?Q?j+yXtdySkD9oUNLB/yTUV5YVcFrAIZ8ZgFef79YBdYYNXMUp6zxPvuLRf/OL?=
 =?us-ascii?Q?z7uLLkiTiv1sECfHtYJNz8Qy+cmzgWx3Y7HdOFlPxlUh02xQETgST2XE/qDx?=
 =?us-ascii?Q?73N7icRoEtghtClmcGE6P9ZQF6+p3JWMNTuGU04ggYph07ny0qfP6fI6U5qv?=
 =?us-ascii?Q?ejH0EAy/WIGeWocl95VYs32LCdzGWWEz4G1v20VG9CDm9ewkcEWyY4XqrFFP?=
 =?us-ascii?Q?fqLPeQ/3flkor97tWk52XRYhuBCGFF1TlsO2BKRFX4cteUsPU6rnaUt8vaDp?=
 =?us-ascii?Q?INlc6F8LLXadebcGMXrZ8d+IF0DeevQUNK5PD97Bdgh8OKmds3Lh8okznCJt?=
 =?us-ascii?Q?2nhO/ebn7f2BNqHwEvOP8fdQ6obRkpWNs6tIw5avY6mWZIAYGhSz/pQkm2cL?=
 =?us-ascii?Q?Wq4SnKnICwJBw58QJfdjkGFYbdx096uYZWFJh+xLv1dGlc/fNlzy4psAiF44?=
 =?us-ascii?Q?ux365Ln1tZU9gsVh3XYlN3W3RXDy17WmeIYbN6kwo+ZzTUyukFS3TTJ4wghS?=
 =?us-ascii?Q?0b7p8Wg7d3KAHaCeUE8e9C9ast/4Vt1Y6tT7IlvhZuj8ls9DZnvJtnw8114R?=
 =?us-ascii?Q?KX0suOyAJwH3YMAjqPy7JqVF1zXGe+UdidwIYkN04EITvdBeu3T3CnKHifeT?=
 =?us-ascii?Q?HCO5/vHWQSdmsAqgEBZw6tGsbvddpgBkcJT/EKAMMfHGGX1GB4qF+YvQvFe5?=
 =?us-ascii?Q?FbQko9ZiZvfCwCZ8/XVnIsZe1hJKVqAtKPo7dW8SAK2XJD2Xr8mtgU2y3j8c?=
 =?us-ascii?Q?gQKZEo3RrFNaTyqopPxcfYxJ8LA4Mt49JgKrN0z/iDULU0KE0/C9wLXNtzfa?=
 =?us-ascii?Q?5+pGJlG7TWrPE3MZvO1Lt9e+qr2uaCavl+A7+P4Cm/X39vvYtFqMAIOL2+s0?=
 =?us-ascii?Q?emRARpgWkZWast9t86NhEDEN+NwHizr7eo7AiPC9mGm1UeC1hRTtf+L6D50L?=
 =?us-ascii?Q?BNM0stoGSrtB4mgvEE8T2vbG+lS1Bg7UzjSHxkURhmBcpXXe3/qlw6q+ntqb?=
 =?us-ascii?Q?d/Z/w3fSUsBVizTiOAY/M/x8+SVQHnOSeKt4zzr+JzM93GARb1SKWWwIJ7jM?=
 =?us-ascii?Q?hDPyDC832/5aRXar2v+zBd1myKvJ9K3v59Y4ocBQ9A3f8S3jyc3f/Joae/uW?=
 =?us-ascii?Q?0ICaffNSxHxsHgclaX09+0oLZSohXZfHks2hn9M2JoCDhVyUkZdY5SHIYlRZ?=
 =?us-ascii?Q?HdPzczVF91ppd/gugeVWfOwcJKR3W8OKZg4gUXWJdrsfYLwqLh9pAEyH7KVR?=
 =?us-ascii?Q?QnL1jPotJeVvKOa9Ihcd5sTk?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a96de4ed-46f2-4374-6418-08d99247a7fc
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2021 14:57:50.9494
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /U0go9IjIgU7rh+GFdTA+ZVpzFkoFgM0VwIuR3ojZqBLA1HruLepVQDk//E6Ga9xt2sUzsNbcw75bq0AK9jtkA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4191

On 18.10.2021 16:35, Roger Pau Monn=C3=A9 wrote:
> On Wed, Sep 29, 2021 at 11:43:32AM +0200, Jan Beulich wrote:
>> It's not really needed and has been misleading me more than once to try
>> and spot its "actual" use(s). It should really have been dropped when
>> the 32-bit specific logic was purged from here.
>>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>=20
> Reviewed-by: Roger Pau Monn=C3=A9 <roger.pau@citrix.com>

Thanks.

> As it makes the current code clearer. I have one question/concern
> below.
>=20
>> --- a/xen/arch/x86/traps.c
>> +++ b/xen/arch/x86/traps.c
>> @@ -327,16 +327,13 @@ static void show_guest_stack(struct vcpu
>> =20
>>      if ( v !=3D current )
>>      {
>> -        struct vcpu *vcpu;
>> -
>>          if ( !guest_kernel_mode(v, regs) )
>>          {
>>              printk("User mode stack\n");
>>              return;
>>          }
>> =20
>> -        vcpu =3D maddr_get_owner(read_cr3()) =3D=3D v->domain ? v : NUL=
L;
>> -        if ( !vcpu )
>> +        if ( maddr_get_owner(read_cr3()) !=3D v->domain )
>=20
> Wouldn't it be more accurate to check that the current loaded cr3
> matches the one used by v?
>=20
> AFAICT we don't load the cr3 from v, so it's still possible to have
> diverging per-vcpu page tables and thus end up dumping wrong data?

I think truly per-CPU page tables in a PV guest would be quite
cumbersome to have. And iirc (it's been over 12 years since introducing
that logic) the check also isn't about the CR3 we're on being the one
associated with the present vCPU, but merely whether we can expect that
page to be mapped. This would also fall apart when a remote vCPU's
stack isn't accessible on the current CPU for whichever other reason.
I'd be inclined to further tighten this (and force more cases through
do_page_walk()) when we see evidence that we need doing so.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Oct 18 15:15:43 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Oct 2021 15:15:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.212424.370283 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcUMM-00005w-3U; Mon, 18 Oct 2021 15:15:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 212424.370283; Mon, 18 Oct 2021 15:15:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcUMM-00005p-0C; Mon, 18 Oct 2021 15:15:30 +0000
Received: by outflank-mailman (input) for mailman id 212424;
 Mon, 18 Oct 2021 15:15:28 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=628V=PG=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mcUMK-00005i-RF
 for xen-devel@lists.xenproject.org; Mon, 18 Oct 2021 15:15:28 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 21551273-fd40-44cf-8f5c-ed8575759c27;
 Mon, 18 Oct 2021 15:15:27 +0000 (UTC)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2113.outbound.protection.outlook.com [104.47.17.113])
 (Using TLS) by relay.mimecast.com with ESMTP id
 de-mta-16-tRkOmCJdPM-Rr6C8PIYhIg-1; Mon, 18 Oct 2021 17:15:25 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB7038.eurprd04.prod.outlook.com (2603:10a6:800:12d::9)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16; Mon, 18 Oct
 2021 15:15:23 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.018; Mon, 18 Oct 2021
 15:15:23 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS8P250CA0024.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:330::29) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.16 via Frontend Transport; Mon, 18 Oct 2021 15:15:22 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 21551273-fd40-44cf-8f5c-ed8575759c27
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634570126;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=Bc1Y8xRFPrl01Nh1N08KFdcf0BIfYNpEy4FuDgekvYY=;
	b=IkrAvJ6Iny/e7kx5RbUxObWybgwBlQvlIiPZVJsBmNWzlvuV5YjMnmvAWqYLoL8ymsUoj9
	EK64dcVMYVwGcWVq/V+QfrR/MQPDo3UTlWpT+xvIzV7BWmEgEnmkizw5jNgY8vxHn931Do
	SOqhPmwcddEZYi4tFc99EWpQNdNuOd8=
X-MC-Unique: tRkOmCJdPM-Rr6C8PIYhIg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=WwoXGUZFlvCYZnU0wiqMZOwxe9qUW9Mn4MJvA6+OQxjfTAjgB9av8g69fsNlOzsGOdmUQfZHltOPY122ydBXvwHMIGcW306VFRtua2Mb6w+FsixtFG40TnxBIIAiJUjM803HsU+pLvYGxWnEYjdHlfrv2/XXVlVenFp292B3AVyTYUXmzM5P0GhbX0VwzVic7qgrf4SAInLAPAG/xw/ODLCpwvRTHf1CJMLQ7d1vCE6xXZPzGPNQCFfB/kzsFNTBOG40EehnEcb8V+q7R0H/hqrIvdtFq/yPKuuf3ESXAZJz+wqQ8DAmreuN1JqBhnJRDsfJ/G3Tc7xmxDKcyLM8Gw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=XMHdINXXzEUpuV/YRJnZqZvhB8Q2ASoh2uC3j6C8zG4=;
 b=BhC5fme3vucrzLGMJERprplpQO2V95FYXMh+bXwVDNP+KK2p/EG6hSuh8eOJB4//FLx3hI7T7EhmUni6v5p7b8ew0Qg+d2q5p63qgIY3Xk6eTQOUtU+gR52THP68V/98iTb9Gr8T1qOmkmVGbobfx0cfssfAOA06mMrSgYf/m1omk6KQC8AmtzSpXtPXfRmA4NwsiRZjgqXGpbvnWOJw7D8dPgcmq4oJ4lEZJHhKKY8wymVV23WmzkaybF4F9XtxrHX2UBtDFuyIKidUkt5ZPPLGvOx2WNlA7jrYJiGbL4diBZgbl4c22+imJFULZL64ZNyusL6TvwhukNYc7sQcRw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: arm.com; dkim=none (message not signed)
 header.d=none;arm.com; dmarc=none action=none header.from=suse.com;
Subject: Re: [PATCH v8 2/5] xen/arm: Enable the existing x86 virtual PCI
 support for ARM
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
CC: Rahul Singh <rahul.singh@arm.com>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>, "sstabellini@kernel.org" <sstabellini@kernel.org>,
 Julien Grall <julien@xen.org>, Volodymyr Babchuk
 <Volodymyr_Babchuk@epam.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
 Paul Durrant <paul@xen.org>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Ian Jackson <iwj@xenproject.org>, Bertrand Marquis <bertrand.marquis@arm.com>
References: <cover.1634315461.git.bertrand.marquis@arm.com>
 <e2b10f56043155e4bb8eae824723045ccc042f8e.1634315461.git.bertrand.marquis@arm.com>
 <ca5558b2-25c6-90d2-284b-03cbbb02691f@suse.com>
 <FBC4FA6D-AF07-437A-BD81-52708B139070@arm.com>
 <8c99e635-9509-b078-2285-48fb6fb91507@suse.com>
 <46bcd42f-df4f-922a-cc21-a05821481754@epam.com>
 <17fd4f89-9afa-f65c-c66d-1364d7474969@suse.com>
 <2a47d0d9-a821-bd2d-62ee-173ccf5374e8@epam.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <99f3194d-07d3-21bd-f75c-53cdc6b40491@suse.com>
Date: Mon, 18 Oct 2021 17:15:21 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <2a47d0d9-a821-bd2d-62ee-173ccf5374e8@epam.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS8P250CA0024.EURP250.PROD.OUTLOOK.COM
 (2603:10a6:20b:330::29) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: b615b84e-ae63-4651-baba-08d9924a1b43
X-MS-TrafficTypeDiagnostic: VI1PR04MB7038:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB7038B17F528E80097EE03175B3BC9@VI1PR04MB7038.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	MDSc/WIpWb4Dt0FNZOMGLU/kGDXSoqT902K8LLqwkiSQ5INNCXxO2wbHwkujU4jXr6bqiiBSWzhZNKGhbSy+nwgAcz4apz/SdMdyjV4QgmkxiLzvwMK5ZLTfEadDsl3KRUwPb5s1OFK3MqY8kxI9jFYG/Bjsm2WIm8yjB20ZT8BfaS8HmSuGMMw185cJxaJxDBnh/LhU40UeF+NwolnZxH1OW76OH17y1OBlk31K4reli4EjocuIxmYqKtcuFMZCYGkTvSFnebHyPTbupnDA/cdBWj0SbipscRSOukA/CvqwmYb53DNyf4lhUWegqxQEi0Px6vBMWDOYL/pEDWUHJusSfoPvWRLNrvoF+h69/BPVVj9I8BsnEhd/rnLn2tmtqnT1VoB0padiwdH/iEBmCkcmeiDtkwW/a6vtU+RwGlwArSSpQ81ddYh4AhQSG+mMzDClqEr33+MNgakgOo5XweRU0nWgRgqL+n6e2+UV9W4CO5Z4r8VaDFy+nxnBHvkV4heAyVTg78t/MZ5gqupOFvdhUD5WHfLHfamuTUDROeOzwhHsnEfZL8BUMTx8f5BfobL+BxxsM7j89XgPW5KjRI22WoO43Zc2wrr0ET3ib62MG5v9QJj3fcD/C33OwQiFF6/FBSK2DR5o1Ukz5MDBFe2xDCep7mUV4MGa1ySDzwhFeIF31fzckENPu3wVfLG8N/Za0+wVti+tvIZIKTUX7sv2RPRPPtXDB3h9bMbsy6IWoVPQc7OvxTU7tf9pOGg2483wvrCOV17A5e5cR9rc2IB+10jIOIpXysXs57Ll6DJajzyfqPNaLvy8smdOoqJsUU0dwk8Od2NRJUXw5lQOBn8P7r82hFYMD3/TyWV+2l4=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(2616005)(316002)(8676002)(186003)(86362001)(6486002)(5660300002)(38100700002)(66476007)(53546011)(36756003)(54906003)(956004)(83380400001)(966005)(2906002)(4326008)(508600001)(66556008)(31686004)(6916009)(16576012)(26005)(31696002)(66946007)(8936002)(7416002)(2004002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?xWELz1RIeaiyc9neDUoMzSXQO+rmvZVGcxI3ku2eWSIDCTSG2KauiYiQSqh1?=
 =?us-ascii?Q?ZgQ/dEQ8vqEjnaGpRyRuNgXTWO4YnsPNaFeRIgGqgBtfq9oZ7ZcpsE8QfNc3?=
 =?us-ascii?Q?E1rxtdAuQ75al7Q7UWCjIFhA+g0kaFKMzPzLQQIEIUQsh6DrRVyqjBR10gB6?=
 =?us-ascii?Q?vng3ykYOG6+9go+ymtwXSb0PriONl3m3Ogvm+OBjJanC3CS26I5Lk6Vis15x?=
 =?us-ascii?Q?IqRu3pJK5GJCmqmDJqJM/z3YhtKC2h7BKmZEV4DtHHwBjHH+okyOtGXlkcbj?=
 =?us-ascii?Q?wlFdG+u+aCzrtyoybSiuM2+kCqanPpelyK99Zcxpo4Q8iE/Dt5q9j9WmbI+m?=
 =?us-ascii?Q?9bcYrglPRPa3Sw12WwyguzSWdj3ml0CRPKzltAnAqvOXRsYTbQpxPc5IzlrI?=
 =?us-ascii?Q?d67CNKaKjWtRCr+qrpRutEv8rjYiwasAlk9lZBSW+lymStoTC8VLyvVwNlt7?=
 =?us-ascii?Q?cqKoqI2R9LDmTLetiKQSJAkr0kdsh2LZc3E2+4FC3dWaySW5/mqM4k6PchyO?=
 =?us-ascii?Q?Lgp7e5DBK82sAOo1+/ogNLQ2wv83f3kSb4Vhrqe02uGtvafaz1TbxZi9srDc?=
 =?us-ascii?Q?EcTs8W5XQr4K2Ju30/PKuU36J6Vo6ObPRl2akoNjMfYc7OfV2Xiw07UVZOm+?=
 =?us-ascii?Q?EQ3JMVOKcFbX4pIzb/2BM5lxWu3bQZ0Z/D5KzoV+phwZs5/+8Mc1BTcLA6OJ?=
 =?us-ascii?Q?J6/tHqfOOqBu0abpJAWHO2LXWSdlUxwGWGa0Q7Uy9D28a9CaCjpxM3GgJSYp?=
 =?us-ascii?Q?eM7qxjVUcNQf3ttMV0spqa3kDIEigOrz13SreslOr4n3kCGHh+o4x0ieRTT1?=
 =?us-ascii?Q?bj2QhWWVRxfSPyRVQUpvmiwyq36qoQyedV2KKo3bEyfTfseTnukGLvmAuY37?=
 =?us-ascii?Q?BpMbPgWfEZc0eCOUIBhYEWPl4c/RgRORPMtRTn5rwjm2zejG8g1wotWg1W78?=
 =?us-ascii?Q?lN3t6/bZda31cXcwLyt7szypPOAXpDwQ4YalVkZolqu99l5bnzQl0oFpcf+b?=
 =?us-ascii?Q?z1bp0znEEE3stDO89yCMwdy7FF+s2nx/ijVgp9R/1DNqzMnRtJl//1d9qO55?=
 =?us-ascii?Q?N8t2rMzWPPTG4x6i3ia8V1RWZwYtB1zro2U8eQ16gpUXJfGUio408H/ES0Mk?=
 =?us-ascii?Q?27Vx0eTo/TwjmNa9kb8zb3A0k4fxa2hZepGHSsBcRxlA8KntIMY+ztlLXQVM?=
 =?us-ascii?Q?bl6AOqFCBHgDUOPYHQywxxead8A2aqN2160Y5+kxerKfAndX6K8AGjuuKj+u?=
 =?us-ascii?Q?dTiHV39ssHaAE6Cg2N0IJf8NsXj/cuIfltwJesl+x8ISuOUMKC/5ir+13UV/?=
 =?us-ascii?Q?4OhcBcc0t5MsKOXH851CuAuL?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b615b84e-ae63-4651-baba-08d9924a1b43
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2021 15:15:23.3673
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: J5R2eTgI2cimx5ilHh7+xOUIiF7PcZTq9PEGhfk9fbw3B2nJ1vlUdig6EOEiZkeNQMqyxTc7fesIQHahadOqPw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7038

On 18.10.2021 16:37, Oleksandr Andrushchenko wrote:
>=20
>=20
> On 18.10.21 17:19, Jan Beulich wrote:
>> On 18.10.2021 16:07, Oleksandr Andrushchenko wrote:
>>> On 18.10.21 13:29, Jan Beulich wrote:
>>>> On 18.10.2021 12:11, Bertrand Marquis wrote:
>>>>>> On 18 Oct 2021, at 08:47, Jan Beulich <jbeulich@suse.com> wrote:
>>>>>> On 15.10.2021 18:51, Bertrand Marquis wrote:
>>>>>>> --- /dev/null
>>>>>>> +++ b/xen/arch/arm/vpci.c
>>>>>>> @@ -0,0 +1,77 @@
>>>>>>> +/*
>>>>>>> + * xen/arch/arm/vpci.c
>>>>>>> + *
>>>>>>> + * This program is free software; you can redistribute it and/or m=
odify
>>>>>>> + * it under the terms of the GNU General Public License as publish=
ed by
>>>>>>> + * the Free Software Foundation; either version 2 of the License, =
or
>>>>>>> + * (at your option) any later version.
>>>>>>> + *
>>>>>>> + * This program is distributed in the hope that it will be useful,
>>>>>>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
>>>>>>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>>>>>>> + * GNU General Public License for more details.
>>>>>>> + */
>>>>>>> +#include <xen/sched.h>
>>>>>>> +#include <xen/vpci.h>
>>>>>>> +
>>>>>>> +#include <asm/mmio.h>
>>>>>>> +
>>>>>>> +static int vpci_mmio_read(struct vcpu *v, mmio_info_t *info,
>>>>>>> +                          register_t *r, void *p)
>>>>>>> +{
>>>>>>> +    pci_sbdf_t sbdf;
>>>>>>> +    /* data is needed to prevent a pointer cast on 32bit */
>>>>>>> +    unsigned long data;
>>>>>>> +
>>>>>>> +    /* We ignore segment part and always handle segment 0 */
>>>>>>> +    sbdf.sbdf =3D VPCI_ECAM_BDF(info->gpa);
>>>>>>> +
>>>>>>> +    if ( vpci_ecam_read(sbdf, ECAM_REG_OFFSET(info->gpa),
>>>>>>> +                        1U << info->dabt.size, &data) )
>>>>>>> +    {
>>>>>> Here it is quite clear that the SBDF you pass into vpci_ecam_read() =
is
>>>>>> the virtual one. The function then calls vpci_read(), which in turn
>>>>>> will call vpci_read_hw() in a number of situations (first and foremo=
st
>>>>>> whenever pci_get_pdev_by_domain() returns NULL). That function as we=
ll
>>>>>> as pci_get_pdev_by_domain() use the passed in SBDF as if it was a
>>>>>> physical one; I'm unable to spot any translation. Yet I do recall
>>>>>> seeing assignment of a virtual device and function number somewhere
>>>>>> (perhaps another of the related series), so the model also doesn't
>>>>>> look to assume 1:1 mapping of SBDF.
>>>>> This question was answered by Oleksandr I think.
>>>> Yes; I continue to be sure though that I saw devfn allocation logic in
>>>> one of the many patches that are related here. And I'm relatively sure
>>>> that there no adjustment to logic here was made (but since it's hard
>>>> to pick the right patch out of the huge pile without knowing its title=
,
>>>> I can't reasonably go check).
>>> Offtop: I was somehow dropped from the Cc..
>>>
>>> Please see:
>>>
>>> [PATCH v3 10/11] vpci: Add initial support for virtual PCI bus topology
>>> [PATCH v3 11/11] xen/arm: Translate virtual PCI bus topology for guests
>>>
>>> [1] https://urldefense.com/v3/__https://patchwork.kernel.org/project/xe=
n-devel/list/?series=3D555481__;!!GF_29dbcQIUBPA!mM8A39p8nk4UMK3YeKMMW9ua9B=
Hj1UOWzaQcyx7G46YPdudxMpD3huqZfih0Uc8S-GyWXD_mPg$ [patchwork[.]kernel[.]org=
]
>> Ah yes, this way I can find them in my mailbox. And indeed - no translat=
ion
>> from virtual to physical SBDF on the config space read/write paths afaic=
s.
> There are translations for both read and write [2] such as:
>=20
> +=C2=A0=C2=A0=C2=A0 /*
> +=C2=A0=C2=A0=C2=A0=C2=A0 * For the passed through devices we need to map=
 their virtual SBDF
> +=C2=A0=C2=A0=C2=A0=C2=A0 * to the physical PCI device being passed throu=
gh.
> +=C2=A0=C2=A0=C2=A0=C2=A0 */
> +=C2=A0=C2=A0=C2=A0 if ( priv->is_virt_ecam && !pci_translate_virtual_dev=
ice(v->domain, &sbdf) )
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 retur=
n 1;
> +

Oh, that's before you even call vpci_read(). I would have expected this
to live in common vPCI code ...

Jan



From xen-devel-bounces@lists.xenproject.org Mon Oct 18 15:20:09 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Oct 2021 15:20:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.212431.370294 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcUQq-0001XY-Lt; Mon, 18 Oct 2021 15:20:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 212431.370294; Mon, 18 Oct 2021 15:20:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcUQq-0001XR-Iu; Mon, 18 Oct 2021 15:20:08 +0000
Received: by outflank-mailman (input) for mailman id 212431;
 Mon, 18 Oct 2021 15:20:07 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=6zTk=PG=suse.com=jgross@srs-us1.protection.inumbo.net>)
 id 1mcUQo-0001TF-UP
 for xen-devel@lists.xenproject.org; Mon, 18 Oct 2021 15:20:06 +0000
Received: from smtp-out2.suse.de (unknown [195.135.220.29])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id df2e68a4-3026-11ec-82dc-12813bfff9fa;
 Mon, 18 Oct 2021 15:20:06 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 0A8AC1FD6D;
 Mon, 18 Oct 2021 15:20:05 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 8CA7F140A7;
 Mon, 18 Oct 2021 15:20:04 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id 3Wz+HqSQbWFIGgAAMHmgww
 (envelope-from <jgross@suse.com>); Mon, 18 Oct 2021 15:20:04 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: df2e68a4-3026-11ec-82dc-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1634570405; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=x2yXV/Siuehs8GyFtdcqFeLIMcQJnQGVInlldGwAG7A=;
	b=BlKHhI3ukQOqZ3gm5VO9ZRvNPG8kNd7ryrX16G1boGtKcwtyHH4H3XmnFTcp3E3V6BPUV5
	tZ+6PCeEqsvsXNoh5KwltTUjzHJO5UfjNmQ67FizSwzpm0v6jVrncLp50Lg0IYZrak3XY8
	idoizN6Rjn2E9cikcyxawy5AltdpIGM=
Subject: Re: [PATCH 05/12] xen: don't include asm/hypercall.h from C sources
To: Jan Beulich <jbeulich@suse.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>, Julien Grall
 <julien@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Wei Liu <wl@xen.org>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>, xen-devel@lists.xenproject.org
References: <20211015125152.25198-1-jgross@suse.com>
 <20211015125152.25198-6-jgross@suse.com>
 <d26c7087-8c39-9624-bbce-876cef47f84c@suse.com>
From: Juergen Gross <jgross@suse.com>
Message-ID: <c2a955f6-eb30-b839-91db-b7bcaeedf848@suse.com>
Date: Mon, 18 Oct 2021 17:20:03 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <d26c7087-8c39-9624-bbce-876cef47f84c@suse.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="FPAqaxEU4v9nBwrDODEo3xpp2cEkrvoV6"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--FPAqaxEU4v9nBwrDODEo3xpp2cEkrvoV6
Content-Type: multipart/mixed; boundary="KhcZtdsEDhmfwxHV8ybASNEAD1LheWvJJ";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>, Julien Grall
 <julien@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Wei Liu <wl@xen.org>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>, xen-devel@lists.xenproject.org
Message-ID: <c2a955f6-eb30-b839-91db-b7bcaeedf848@suse.com>
Subject: Re: [PATCH 05/12] xen: don't include asm/hypercall.h from C sources
References: <20211015125152.25198-1-jgross@suse.com>
 <20211015125152.25198-6-jgross@suse.com>
 <d26c7087-8c39-9624-bbce-876cef47f84c@suse.com>
In-Reply-To: <d26c7087-8c39-9624-bbce-876cef47f84c@suse.com>

--KhcZtdsEDhmfwxHV8ybASNEAD1LheWvJJ
Content-Type: multipart/mixed;
 boundary="------------76EB8D639C1646C9CBCD82F5"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------76EB8D639C1646C9CBCD82F5
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 18.10.21 14:39, Jan Beulich wrote:
> On 15.10.2021 14:51, Juergen Gross wrote:
>> --- a/xen/arch/x86/x86_64/mm.c
>> +++ b/xen/arch/x86/x86_64/mm.c
>> @@ -32,7 +32,6 @@ EMIT_FILE;
>>   #include <asm/page.h>
>>   #include <asm/flushtlb.h>
>>   #include <asm/fixmap.h>
>> -#include <asm/hypercall.h>
>>   #include <asm/msr.h>
>>   #include <asm/pv/domain.h>
>>   #include <asm/setup.h>
>=20
> Afaict xen/hypercall.h also doesn't need including here. But I can
> agree that this is at best a partly related change.

Will check and delete it in case not needed.

>=20
>> --- a/xen/arch/x86/x86_64/platform_hypercall.c
>> +++ b/xen/arch/x86/x86_64/platform_hypercall.c
>> @@ -41,8 +41,8 @@ CHECK_pf_resource_entry;
>>   #undef xen_pf_resource_entry
>>  =20
>>   #define COMPAT
>> -#define _XEN_GUEST_HANDLE(t) XEN_GUEST_HANDLE(t)
>> -#define _XEN_GUEST_HANDLE_PARAM(t) XEN_GUEST_HANDLE_PARAM(t)
>> +#undef guest_handle_okay
>> +#define guest_handle_okay          compat_handle_okay
>=20
> Is this a change that slipped in here from patch 3, accompanying
>=20
> -#define do_platform_op(x)   compat_platform_op(_##x)
> +#define do_platform_op(x)   compat_platform_op(x)
>=20
> there? Or does that change belong here? I have to admit anyway that
> it's not entirely clear to me why this adjustment needs making.

Oh yes, this is a leftover to make things work with prototypes being
made seen in platform_hypercall.c.

>=20
>> --- a/xen/common/compat/grant_table.c
>> +++ b/xen/common/compat/grant_table.c
>> @@ -4,6 +4,7 @@
>>    */
>>  =20
>>   #include <compat/grant_table.h>
>> +#include <xen/hypercall.h>
>=20
> Nit: Generally compat/*.h go last.

Okay.


Juergen


--------------76EB8D639C1646C9CBCD82F5
Content-Type: application/pgp-keys;
 name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Transfer-Encoding: quoted-printable
Content-Description: OpenPGP public key
Content-Disposition: attachment;
 filename="OpenPGP_0xB0DE9DD628BF132F.asc"

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy=
cWx
w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O=
f8Z
d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y=
9bf
IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq=
G7/
377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR=
3Jv
c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA=
QIe
AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT=
hpw
dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0=
MbD
1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv=
oPH
Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v=
5QL
+qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ=
2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC=
QoL
BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr=
Wf0
teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC=
/nu
AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh=
ITT
d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm=
XBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz=
80h
SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC=
AcD
AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn=
FOX
gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1=
jnD
kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0=
N51
N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l=
otu
fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1=
tqS
EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA=
hsD
BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3=
g3O
ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5=
dM7
wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5=
D+j
LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm=
V2x
AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N=
Eaw
QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW=
nHI
s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR=
wgn
BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV=
bVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk=
pEd
IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA=
QAB
wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw=
Tbe
8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1=
vJz
Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8=
VGi
wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW=
svi
uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX=
zXs
ZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------76EB8D639C1646C9CBCD82F5--

--KhcZtdsEDhmfwxHV8ybASNEAD1LheWvJJ--

--FPAqaxEU4v9nBwrDODEo3xpp2cEkrvoV6
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmFtkKMFAwAAAAAACgkQsN6d1ii/Ey90
bggAhrI5cvrJPI1zMDHk4PG7uYPYh8qSIJwofQ2t0CAK+3P3PBGZVvtCnnNGkjPlkNHnBDVjkfeJ
hXwmYeQdFd8mXmFNrxZRDaqSjMTkBSb7ADmK9e04iycytVAF3FLt77xDKLUJKNC5PWISy0/z0lN4
1e3lnxPrXA27AXLQPTF71DJnGDGTuqxADZNGhu3ACyP7HLJfkl4137Q+HFexYQLqxrJSMNehOe0b
AQNHz4XydHdWbVIyeMpY8dkI78zcRzIZR7AW8g5E6IPKLJWI7N9umT0FX6YVmCU2rt+xDA1IPvNt
gkcBGW2Pj4CUy70KDnNT1+ABgrwHUBp5ZRSAY4WiAA==
=0FkH
-----END PGP SIGNATURE-----

--FPAqaxEU4v9nBwrDODEo3xpp2cEkrvoV6--


From xen-devel-bounces@lists.xenproject.org Mon Oct 18 15:28:45 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Oct 2021 15:28:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.212440.370304 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcUZ5-0002HI-H6; Mon, 18 Oct 2021 15:28:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 212440.370304; Mon, 18 Oct 2021 15:28:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcUZ5-0002HB-EC; Mon, 18 Oct 2021 15:28:39 +0000
Received: by outflank-mailman (input) for mailman id 212440;
 Mon, 18 Oct 2021 15:28:37 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=6zTk=PG=suse.com=jgross@srs-us1.protection.inumbo.net>)
 id 1mcUZ3-0002H5-K0
 for xen-devel@lists.xenproject.org; Mon, 18 Oct 2021 15:28:37 +0000
Received: from smtp-out1.suse.de (unknown [195.135.220.28])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 0efe71cd-3028-11ec-82dc-12813bfff9fa;
 Mon, 18 Oct 2021 15:28:36 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 23DCD21961;
 Mon, 18 Oct 2021 15:28:35 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id D620713E74;
 Mon, 18 Oct 2021 15:28:34 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id U4d7MqKSbWFPHgAAMHmgww
 (envelope-from <jgross@suse.com>); Mon, 18 Oct 2021 15:28:34 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0efe71cd-3028-11ec-82dc-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1634570915; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=QFjP2hNYhxPS6S4BoqPzQbGj+c/hgrgoGlj9aGHN00Q=;
	b=N0MXcy2X0L9n4swS1ptdmE6KQ41i7GdI1G2/G1r3B8NEKvMU0LoEUcgeBzSFo+8iWKQkL5
	dArlO9Ap4tF6FFJUJd2zvKDGRPNCurELDjCeKdv2H1hB1cZZEebhI/EjiOCFUjL2W3X1xE
	KIHxt28d9Rd2Ow5ihIzZ1SpO1YyBWgE=
To: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>, xen-devel@lists.xenproject.org
References: <20211015125152.25198-1-jgross@suse.com>
 <20211015125152.25198-7-jgross@suse.com>
 <e5f55c9e-5615-7d10-c86c-db1a3c724f43@suse.com>
From: Juergen Gross <jgross@suse.com>
Subject: Re: [PATCH 06/12] xen: generate hypercall interface related code
Message-ID: <e547b584-54e6-3227-82a8-ff1301eddb21@suse.com>
Date: Mon, 18 Oct 2021 17:28:34 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <e5f55c9e-5615-7d10-c86c-db1a3c724f43@suse.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="2RKxFNcEw5MU18cdbwBvKt3FP4g34xJQK"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--2RKxFNcEw5MU18cdbwBvKt3FP4g34xJQK
Content-Type: multipart/mixed; boundary="0lJ9s4wegrUNL2FbXAwlKyrFlW1RG0e4Z";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>, xen-devel@lists.xenproject.org
Message-ID: <e547b584-54e6-3227-82a8-ff1301eddb21@suse.com>
Subject: Re: [PATCH 06/12] xen: generate hypercall interface related code
References: <20211015125152.25198-1-jgross@suse.com>
 <20211015125152.25198-7-jgross@suse.com>
 <e5f55c9e-5615-7d10-c86c-db1a3c724f43@suse.com>
In-Reply-To: <e5f55c9e-5615-7d10-c86c-db1a3c724f43@suse.com>

--0lJ9s4wegrUNL2FbXAwlKyrFlW1RG0e4Z
Content-Type: multipart/mixed;
 boundary="------------8A7DC5D6DB39D196B931251F"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------8A7DC5D6DB39D196B931251F
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 18.10.21 14:58, Jan Beulich wrote:
> On 15.10.2021 14:51, Juergen Gross wrote:
>> Instead of repeating similar data multiple times use a single source
>> file and a generator script for producing prototypes and call sequence=
s
>> of the hypercalls.
>>
>> As the script already knows the number of parameters used add generati=
ng
>> a macro for populating an array with the number of parameters per
>> hypercall.
>=20
> Isn't that array intended to go away?

I thought so, yes, but on Arm there is a case where it is needed.

So generating it from the available data is the sensible thing to do
IMO.

>=20
>> --- a/.gitignore
>> +++ b/.gitignore
>> @@ -332,10 +332,12 @@ xen/include/asm-x86/asm-macros.h
>>   xen/include/compat/*
>>   xen/include/config/
>>   xen/include/generated/
>> +xen/include//hypercall-defs.i
>=20
> Nit: Stray double slash (unless this has a meaning I'm unaware of).

Oh, right. No special meaning AFAIK.

> Yet then I wonder: Shouldn't *.i be among the patterns at the top of
> the file, like *.o is?

Yes, I can do that. Probably via a separate patch then.
>> @@ -466,6 +468,14 @@ include/asm-$(TARGET_ARCH)/asm-offsets.h: asm-off=
sets.s
>>   	  echo ""; \
>>   	  echo "#endif") <$< >$@
>>  =20
>> +quiet_cmd_genhyp =3D GEN     $@
>> +define cmd_genhyp
>> +    awk -f scripts/gen_hypercall.awk <$< >$@
>> +endef
>> +
>> +include/xen/hypercall-defs.h: include/hypercall-defs.i scripts/gen_hy=
percall.awk FORCE
>> +	$(call if_changed,genhyp)
>=20
> As per patch 5 there are quite a few sources including xen/hypercall.h
> and hence (in one of the next patches) the header generated here. If
> this one gets re-generated for a benign reason (i.e. without changing
> the header), all dependents will get rebuilt for no reason. Use
> $(move-if-changed ...)?

The reasons for re-generating are quite limited. The most probable case
is a .config change, which will trigger quite some rebuild anyway.

If you think its is really worth the effort, I can use move-if-changed.

>=20
>> +prefix: do
>> +set_timer_op(s_time_t timeout)
>> +console_io(unsigned int cmd, unsigned int count, char *buffer)
>> +vm_assist(unsigned int cmd, unsigned int type)
>> +event_channel_op(int cmd, void *arg)
>> +mmuext_op(mmuext_op_t *uops, unsigned int count, unsigned int *pdone,=
 unsigned int foreigndom)
>> +multicall(multicall_entry_t *call_list, unsigned int nr_calls)
>> +#ifdef CONFIG_PV
>> +mmu_update(mmu_update_t *ureqs, unsigned int count, unsigned int *pdo=
ne, unsigned int foreigndom)
>> +stack_switch(unsigned long ss, unsigned long esp)
>> +fpu_taskswitch(int set)
>> +set_debugreg(int reg, unsigned long value)
>> +get_debugreg(int reg)
>> +set_segment_base(unsigned int which, unsigned long base)
>> +mca(xen_mc_t *u_xen_mc)
>> +set_trap_table(const_trap_info_t *traps)
>> +set_gdt(xen_ulong_t *frame_list, unsigned int entries)
>> +set_callbacks(unsigned long event_address, unsigned long failsafe_add=
ress, unsigned long syscall_address)
>> +update_descriptor(uint64_t gaddr, seg_desc_t desc)
>> +update_va_mapping(unsigned long va, uint64_t val64, unsigned long fla=
gs)
>> +update_va_mapping_otherdomain(unsigned long va, uint64_t val64, unsig=
ned long flags, domid_t domid)
>> +#endif
>> +#ifdef CONFIG_IOREQ_SERVER
>> +dm_op(domid_t domid, unsigned int nr_bufs, xen_dm_op_buf_t *bufs)
>> +#endif
>> +#ifndef CONFIG_PV_SHIM_EXCLUSIVE
>> +sysctl(xen_sysctl_t *u_sysctl)
>> +domctl(xen_domctl_t *u_domctl)
>> +paging_domctl_cont(xen_domctl_t *u_domctl)
>> +#endif
>> +#ifdef CONFIG_HVM
>> +hvm_op(unsigned long op, void *arg)
>> +#endif
>> +#ifdef CONFIG_HYPFS
>> +hypfs_op(unsigned int cmd, const char *arg1, unsigned long arg2, void=
 *arg3, unsigned long arg4)
>> +#endif
>> +#ifdef CONFIG_X86
>> +xenpmu_op(unsigned int op, xen_pmu_params_t *arg)
>> +#endif
>> +
>> +#ifdef CONFIG_PV
>> +caller: pv64
>> +#ifdef CONFIG_PV32
>> +caller: pv32
>> +#endif
>> +#endif
>> +#ifdef CONFIG_HVM
>> +caller: hvm64
>> +#ifdef CONFIG_COMPAT
>> +caller: hvm32
>> +#endif
>=20
> HVM selects COMPAT, so I don't see a point in this inner conditional.

Ah, indeed.

>=20
>> +#endif
>> +#ifdef CONFIG_ARM
>> +caller: arm
>> +#endif
>> +
>> +table:                             pv32    pv64    hvm32   hvm64   ar=
m
>> +set_trap_table                     compat  do      -       -       -
>> +mmu_update                         do      do      -       -       -
>> +set_gdt                            compat  do      -       -       -
>> +stack_switch                       do      do      -       -       -
>> +set_callbacks                      compat  do      -       -       -
>> +fpu_taskswitch                     do      do      -       -       -
>> +sched_op_compat                    do      do      -       -       de=
p
>> +#ifndef CONFIG_PV_SHIM_EXCLUSIVE
>> +platform_op                        compat  do      compat  do      do=

>> +#endif
>> +set_debugreg                       do      do      -       -       -
>> +get_debugreg                       do      do      -       -       -
>> +update_descriptor                  compat  do      -       -       -
>> +memory_op                          compat  do      hvm     hvm     do=

>> +multicall                          compat  do      compat  do      do=

>> +update_va_mapping                  compat  do      -       -       -
>> +set_timer_op                       compat  do      compat  do      -
>> +event_channel_op_compat            do      do      -       -       de=
p
>> +xen_version                        compat  do      compat  do      do=

>> +console_io                         do      do      do      do      do=

>> +physdev_op_compat                  compat  do      -       -       de=
p
>> +#if defined(CONFIG_GRANT_TABLE) || defined(CONFIG_PV_SHIM)
>> +grant_table_op                     compat  do      hvm     hvm     do=

>> +#endif
>> +vm_assist                          do      do      do      do      do=

>> +update_va_mapping_otherdomain      compat  do      -       -       -
>> +iret                               compat  do      -       -       -
>> +vcpu_op                            compat  do      compat  do      do=

>> +set_segment_base                   do      do      -       -       -
>> +#ifdef CONFIG_PV
>> +mmuext_op                          compat  do      compat  do      -
>> +#endif
>> +xsm_op                             compat  do      compat  do      do=

>> +nmi_op                             compat  do      -       -       -
>> +sched_op                           compat  do      compat  do      do=

>> +callback_op                        compat  do      -       -       -
>> +#ifdef CONFIG_XENOPROF
>> +xenoprof_op                        compat  do      -       -       -
>> +#endif
>> +event_channel_op                   do      do      do      do      do=

>> +physdev_op                         compat  do      hvm     hvm     do=

>> +#ifdef CONFIG_HVM
>> +hvm_op                             do      do      do      do      do=

>> +#endif
>> +#ifndef CONFIG_PV_SHIM_EXCLUSIVE
>> +sysctl                             do      do      do      do      do=

>> +domctl                             do      do      do      do      do=

>> +#endif
>> +#ifdef CONFIG_KEXEC
>> +kexec_op                           compat  do      -       -       -
>> +#endif
>> +tmem_op                            -       -       -       -       -
>> +#ifdef CONFIG_ARGO
>> +argo_op                            compat  do      compat  do      do=

>> +#endif
>> +xenpmu_op                          do      do      do      do      -
>> +#ifdef CONFIG_IOREQ_SERVER
>> +dm_op                              compat  do      compat  do      do=

>> +#endif
>> +#ifdef CONFIG_HYPFS
>> +hypfs_op                           do      do      do      do      do=

>> +#endif
>> +mca                                do      do      -       -       -
>> +#ifndef CONFIG_PV_SHIM_EXCLUSIVE
>> +paging_domctl_cont                 do      do      do      do      -
>> +#endif
>=20
> I assume the intention here is to sort by hypercall number. This result=
s
> in 3 PV_SHIM_EXCLUSIVE conditionals when one might do. Just a remark fo=
r
> consideration, not strictly a request to change anything.

I intentionally sorted this by hypercall number, yes.

This makes it much easier to spot any missing case IMO. I can change
that if wanted.


Juergen

--------------8A7DC5D6DB39D196B931251F
Content-Type: application/pgp-keys;
 name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Transfer-Encoding: quoted-printable
Content-Description: OpenPGP public key
Content-Disposition: attachment;
 filename="OpenPGP_0xB0DE9DD628BF132F.asc"

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy=
cWx
w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O=
f8Z
d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y=
9bf
IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq=
G7/
377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR=
3Jv
c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA=
QIe
AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT=
hpw
dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0=
MbD
1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv=
oPH
Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v=
5QL
+qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ=
2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC=
QoL
BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr=
Wf0
teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC=
/nu
AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh=
ITT
d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm=
XBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz=
80h
SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC=
AcD
AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn=
FOX
gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1=
jnD
kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0=
N51
N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l=
otu
fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1=
tqS
EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA=
hsD
BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3=
g3O
ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5=
dM7
wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5=
D+j
LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm=
V2x
AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N=
Eaw
QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW=
nHI
s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR=
wgn
BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV=
bVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk=
pEd
IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA=
QAB
wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw=
Tbe
8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1=
vJz
Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8=
VGi
wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW=
svi
uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX=
zXs
ZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------8A7DC5D6DB39D196B931251F--

--0lJ9s4wegrUNL2FbXAwlKyrFlW1RG0e4Z--

--2RKxFNcEw5MU18cdbwBvKt3FP4g34xJQK
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmFtkqIFAwAAAAAACgkQsN6d1ii/Ey8H
/AgAgRCUdtNbHokndjUFVftflThctHR7C/GWJ5NJvOJwJiuvai0u0eSG9uQtLnhWlLMo70ZTC1Xz
D/uI6uCfKoGxrJogiSikp4A6Bm45gC7uyzJ35GcDr9d41MHhpx+niC17/xxK+WM5OvDPnDsUW985
5BL5mY1Tcu+mELqwHNssCKGTBl6q6iqmtsplavCtzF1IUnZ9rWWB8HwDsHS6S9YBuVCuemnfY9CK
LbTgSGLv161yb5Wt0aGooNu6cN+pEFuiLMPqZZP1TFhBqV6Frav0qxakUdI38dl36ynueUckhJYD
Esr0KQWrSjh5rKgJvISHfaW3zqjs33NsoPWQfS4iYQ==
=38Tw
-----END PGP SIGNATURE-----

--2RKxFNcEw5MU18cdbwBvKt3FP4g34xJQK--


From xen-devel-bounces@lists.xenproject.org Mon Oct 18 15:31:30 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Oct 2021 15:31:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.212449.370316 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcUbp-0003kF-2y; Mon, 18 Oct 2021 15:31:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 212449.370316; Mon, 18 Oct 2021 15:31:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcUbo-0003k8-W6; Mon, 18 Oct 2021 15:31:28 +0000
Received: by outflank-mailman (input) for mailman id 212449;
 Mon, 18 Oct 2021 15:31:28 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=6zTk=PG=suse.com=jgross@srs-us1.protection.inumbo.net>)
 id 1mcUbo-0003k2-1s
 for xen-devel@lists.xenproject.org; Mon, 18 Oct 2021 15:31:28 +0000
Received: from smtp-out1.suse.de (unknown [195.135.220.28])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 645b8893-8fe7-48a1-b408-8b20a99f1489;
 Mon, 18 Oct 2021 15:31:27 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 7BEBD21961;
 Mon, 18 Oct 2021 15:31:26 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 33BA113E74;
 Mon, 18 Oct 2021 15:31:26 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id PYJZC06TbWHpHwAAMHmgww
 (envelope-from <jgross@suse.com>); Mon, 18 Oct 2021 15:31:26 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 645b8893-8fe7-48a1-b408-8b20a99f1489
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1634571086; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=Bebn0aIVvHG2YKd1gePyAeqWFN8ricr7tbVd8kUDnY8=;
	b=aiUDnNIFyKhfPW4LwA8ofBKE/ulW15aqs3jXivEsuZ8XA3TIqZEbFmbs5KGp2uggdvrTAn
	fyuNUUjFEDEmxGA5L6BFoBVhn5gL9+6pL3YHcFOayea3CwrDFEDSFrsoTtwI8CfMGK17Dn
	6xaEWzV/dnwTbfbft50yD0YoAD4en2Q=
Subject: Re: [PATCH 03/12] xen: harmonize return types of hypercall handlers
To: Jan Beulich <jbeulich@suse.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>, Julien Grall
 <julien@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Wei Liu <wl@xen.org>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>, Christopher Clark <christopher.w.clark@gmail.com>,
 xen-devel@lists.xenproject.org
References: <20211015125152.25198-1-jgross@suse.com>
 <20211015125152.25198-4-jgross@suse.com>
 <7bd0cff1-6e88-f8dd-d857-229e75dd2772@suse.com>
 <0ca6cdf1-330b-f47f-dea8-442c3cc268ea@suse.com>
 <838aace7-8076-3c78-cb53-faef04162568@suse.com>
From: Juergen Gross <jgross@suse.com>
Message-ID: <ccff48c8-2602-d9e1-09c2-bb8ea34199b6@suse.com>
Date: Mon, 18 Oct 2021 17:31:25 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <838aace7-8076-3c78-cb53-faef04162568@suse.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="IZ7raxpQLwcLC0WnNJktuPV4tK1wc2PKd"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--IZ7raxpQLwcLC0WnNJktuPV4tK1wc2PKd
Content-Type: multipart/mixed; boundary="f28DWcDy3mVdrwdjhptSCPNPhd0OHDMWj";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>, Julien Grall
 <julien@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Wei Liu <wl@xen.org>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>, Christopher Clark <christopher.w.clark@gmail.com>,
 xen-devel@lists.xenproject.org
Message-ID: <ccff48c8-2602-d9e1-09c2-bb8ea34199b6@suse.com>
Subject: Re: [PATCH 03/12] xen: harmonize return types of hypercall handlers
References: <20211015125152.25198-1-jgross@suse.com>
 <20211015125152.25198-4-jgross@suse.com>
 <7bd0cff1-6e88-f8dd-d857-229e75dd2772@suse.com>
 <0ca6cdf1-330b-f47f-dea8-442c3cc268ea@suse.com>
 <838aace7-8076-3c78-cb53-faef04162568@suse.com>
In-Reply-To: <838aace7-8076-3c78-cb53-faef04162568@suse.com>

--f28DWcDy3mVdrwdjhptSCPNPhd0OHDMWj
Content-Type: multipart/mixed;
 boundary="------------18F8228651698E4AAF501EC8"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------18F8228651698E4AAF501EC8
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 18.10.21 16:25, Jan Beulich wrote:
> On 18.10.2021 15:24, Juergen Gross wrote:
>> On 18.10.21 13:55, Jan Beulich wrote:
>>> On 15.10.2021 14:51, Juergen Gross wrote:
>>>> Change the type of the cmd parameter for [do|compat]_kexec_op() to
>>>> unsigned int, as this is more appropriate for the compat case.
>>>
>>> The change for the compat case is fine, but for native you change
>>> behavior for callers passing values equaling valid KEXEC_CMD_*
>>> modulo 2=C2=B3=C2=B2.
>>
>> TBH, I don't think this is really a problem. Or do you think there
>> really is a user of this interface relying on a -ENOSYS in this
>> case?
>=20
> That's a secondary consideration of mine only. The primary one is
> that invoking with an invalid sub-op should fail, such that in the
> future we can assign meaning to the upper bits, if need be. See
> their use for continuations in memory-op, for example.

But this would mean to exclude such usage of upper bits for 32 bit
systems in case this difference should matter.


Juergen


--------------18F8228651698E4AAF501EC8
Content-Type: application/pgp-keys;
 name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Transfer-Encoding: quoted-printable
Content-Description: OpenPGP public key
Content-Disposition: attachment;
 filename="OpenPGP_0xB0DE9DD628BF132F.asc"

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy=
cWx
w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O=
f8Z
d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y=
9bf
IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq=
G7/
377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR=
3Jv
c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA=
QIe
AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT=
hpw
dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0=
MbD
1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv=
oPH
Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v=
5QL
+qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ=
2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC=
QoL
BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr=
Wf0
teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC=
/nu
AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh=
ITT
d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm=
XBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz=
80h
SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC=
AcD
AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn=
FOX
gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1=
jnD
kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0=
N51
N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l=
otu
fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1=
tqS
EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA=
hsD
BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3=
g3O
ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5=
dM7
wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5=
D+j
LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm=
V2x
AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N=
Eaw
QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW=
nHI
s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR=
wgn
BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV=
bVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk=
pEd
IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA=
QAB
wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw=
Tbe
8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1=
vJz
Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8=
VGi
wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW=
svi
uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX=
zXs
ZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------18F8228651698E4AAF501EC8--

--f28DWcDy3mVdrwdjhptSCPNPhd0OHDMWj--

--IZ7raxpQLwcLC0WnNJktuPV4tK1wc2PKd
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmFtk00FAwAAAAAACgkQsN6d1ii/Ey9A
/gf/QiZ5fVV31RdsfmSg9G2jEx9rhKO4SH/Q0i7qXl73JSDLR3IVXt64MUrmMizuCJYGiMYU3WCt
youyADI1k7l74UBQiIlCebiOwmLcYxyONNolAQC8RJMth0KkgN5cpTIIlLdAM1rVJRyXj0NUjk0I
wo3rgVVXx6FGLjaHPi/PTgU7kvBAZt/ZrDhJS87OQe2N5VEluFEFYH/6+sXacAje+B/7LR/831PR
L7oZs2BQ1/SfnGUmj6aB9zi6jviVShzS2YmyaPAxNEH7HiB183nERgKOkzFtELtRYGimoNjZNJn0
dCGe217vI5fYrTFQD0jDgrfJhdXyj/YInSpO/iaDPA==
=p8m/
-----END PGP SIGNATURE-----

--IZ7raxpQLwcLC0WnNJktuPV4tK1wc2PKd--


From xen-devel-bounces@lists.xenproject.org Mon Oct 18 15:34:23 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Oct 2021 15:34:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.212456.370326 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcUeX-0004NE-HW; Mon, 18 Oct 2021 15:34:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 212456.370326; Mon, 18 Oct 2021 15:34:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcUeX-0004N7-Ed; Mon, 18 Oct 2021 15:34:17 +0000
Received: by outflank-mailman (input) for mailman id 212456;
 Mon, 18 Oct 2021 15:34:16 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=6zTk=PG=suse.com=jgross@srs-us1.protection.inumbo.net>)
 id 1mcUeW-0004N1-8a
 for xen-devel@lists.xenproject.org; Mon, 18 Oct 2021 15:34:16 +0000
Received: from smtp-out1.suse.de (unknown [195.135.220.28])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id ab8d8f8a-4d0f-4ff0-bcc4-b2921fc796fd;
 Mon, 18 Oct 2021 15:34:15 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 41BBE21961;
 Mon, 18 Oct 2021 15:34:14 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1B825140B1;
 Mon, 18 Oct 2021 15:34:14 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id nsZtBfaTbWGUIQAAMHmgww
 (envelope-from <jgross@suse.com>); Mon, 18 Oct 2021 15:34:14 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ab8d8f8a-4d0f-4ff0-bcc4-b2921fc796fd
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1634571254; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=kFk64Uh32heiFEGqzzb3aE+jycVincgZmQe5hOMAeJI=;
	b=Ex0k38cJW3oqtIF3k3otjk0W/XnJIVPrgRByYULvklSx/Q+ABjGUNUIA+dpMa/sJ1x7o/Y
	shiyDNj+BifihS96BZ7PC4M7XzZ8TmiC7OiArE3lyV+XdS8qcaGcfR6rFd1gF3D6dpXi6G
	AB1dH/QIR5a5Ik59Atp447MXY/arNmY=
Subject: Re: [PATCH 04/12] xen/x86: modify hvm_memory_op() prototype
To: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>, Wei Liu
 <wl@xen.org>, xen-devel@lists.xenproject.org
References: <20211015125152.25198-1-jgross@suse.com>
 <20211015125152.25198-5-jgross@suse.com>
 <71fae3b2-9f90-878c-50f1-e9c0d7cf7e5c@suse.com>
 <d5c5854f-6bd1-db12-b530-ffc628f473f7@suse.com>
 <0a1aee06-41da-7045-4bdd-33993ce3741e@suse.com>
From: Juergen Gross <jgross@suse.com>
Message-ID: <a2031437-d5c9-158e-d569-e34d79880ad4@suse.com>
Date: Mon, 18 Oct 2021 17:34:13 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <0a1aee06-41da-7045-4bdd-33993ce3741e@suse.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="8MZ0cbvgWoPdEv2qmeX6bjF7EgWiEG1EU"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--8MZ0cbvgWoPdEv2qmeX6bjF7EgWiEG1EU
Content-Type: multipart/mixed; boundary="5kVMQvNheUEqyv8MsIx7sCpjZq82VNTFb";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>, Wei Liu
 <wl@xen.org>, xen-devel@lists.xenproject.org
Message-ID: <a2031437-d5c9-158e-d569-e34d79880ad4@suse.com>
Subject: Re: [PATCH 04/12] xen/x86: modify hvm_memory_op() prototype
References: <20211015125152.25198-1-jgross@suse.com>
 <20211015125152.25198-5-jgross@suse.com>
 <71fae3b2-9f90-878c-50f1-e9c0d7cf7e5c@suse.com>
 <d5c5854f-6bd1-db12-b530-ffc628f473f7@suse.com>
 <0a1aee06-41da-7045-4bdd-33993ce3741e@suse.com>
In-Reply-To: <0a1aee06-41da-7045-4bdd-33993ce3741e@suse.com>

--5kVMQvNheUEqyv8MsIx7sCpjZq82VNTFb
Content-Type: multipart/mixed;
 boundary="------------FAFE546B6B3A6EE8C0C875FC"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------FAFE546B6B3A6EE8C0C875FC
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 18.10.21 16:28, Jan Beulich wrote:
> On 18.10.2021 15:27, Juergen Gross wrote:
>> On 18.10.21 14:31, Jan Beulich wrote:
>>> On 15.10.2021 14:51, Juergen Gross wrote:
>>>> hvm_memory_op() should take an unsigned long as cmd, like
>>>> do_memory_op().
>>>>
>>>> As hvm_memory_op() is basically just calling do_memory_op() (or
>>>> compat_memory_op()) passing through the parameters the cmd parameter=

>>>> should have no smaller size than that of the called functions.
>>>>
>>>> Signed-off-by: Juergen Gross <jgross@suse.com>
>>>
>>> Reviewed-by: Jan Beulich <jbeulich@suse.com>
>>>
>>> Nevertheless ...
>>>
>>>> --- a/xen/arch/x86/hvm/hypercall.c
>>>> +++ b/xen/arch/x86/hvm/hypercall.c
>>>> @@ -31,7 +31,7 @@
>>>>    #include <public/hvm/hvm_op.h>
>>>>    #include <public/hvm/params.h>
>>>>   =20
>>>> -static long hvm_memory_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg=
)
>>>> +static long hvm_memory_op(unsigned long cmd, XEN_GUEST_HANDLE_PARAM=
(void) arg)
>>>>    {
>>>>        long rc;
>>>
>>> ... I think this would even better be dealt with by splitting the
>>> function into a native one (using unsigned long) and a compat one
>>> (using unsigned int).
>>
>> Why? In 32-bit case the value is naturally limited to 32 bits width
>> zero-extending perfectly fine to unsigned long.
>=20
> It all ends up working fine, yes. Else I wouldn't have given R-b.
> But the .compat slot of the hypercall table really should use a
> prototype without unsigned long, and then the calls wouldn't
> zero-extend the arguments anymore. And then the declaration would
> be wrong, as then it would need to be the callee to zero-extend if
> it wants to use 64-bit values.
>=20
>> Otherwise I couldn't use the same definition later.
>=20
> Right. And this will be less of a problem once the function pointer
> tables are gone, as then the compiler sees the real parameter types
> for the individual functions.

Okay, I understand that.

I'd prefer to do that as a followup patch (series) then.


Juergen

--------------FAFE546B6B3A6EE8C0C875FC
Content-Type: application/pgp-keys;
 name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Transfer-Encoding: quoted-printable
Content-Description: OpenPGP public key
Content-Disposition: attachment;
 filename="OpenPGP_0xB0DE9DD628BF132F.asc"

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy=
cWx
w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O=
f8Z
d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y=
9bf
IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq=
G7/
377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR=
3Jv
c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA=
QIe
AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT=
hpw
dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0=
MbD
1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv=
oPH
Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v=
5QL
+qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ=
2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC=
QoL
BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr=
Wf0
teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC=
/nu
AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh=
ITT
d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm=
XBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz=
80h
SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC=
AcD
AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn=
FOX
gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1=
jnD
kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0=
N51
N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l=
otu
fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1=
tqS
EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA=
hsD
BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3=
g3O
ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5=
dM7
wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5=
D+j
LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm=
V2x
AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N=
Eaw
QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW=
nHI
s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR=
wgn
BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV=
bVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk=
pEd
IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA=
QAB
wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw=
Tbe
8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1=
vJz
Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8=
VGi
wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW=
svi
uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX=
zXs
ZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------FAFE546B6B3A6EE8C0C875FC--

--5kVMQvNheUEqyv8MsIx7sCpjZq82VNTFb--

--8MZ0cbvgWoPdEv2qmeX6bjF7EgWiEG1EU
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmFtk/UFAwAAAAAACgkQsN6d1ii/Ey8N
4Af+P01EOJmlM+bsehtC/fX34VpNM7DVlAp8FlzxZFR1/J4fBD7+zY9NEZPU6dCtrw/7orVaki+H
2HBs+O0WaOIZhQ/Lw/vueMa4U5ZKfLCkrkpe4K0C7jwXC2fNcdLqVqQtTF9iLWbvjciHSAXpqo5Q
TggrSYju//pIjXjT2xavluX2bow5hqxaVNXPKTGZkgRQCtZF44CRyFxkuT9hoowZYFf13+MeK/ux
BTgI/fXGSk9yKskG+nfKeSByA5qWvliDwfanJizR+aSD6iGKJHTMYW0npwO1VUHzydZNhNlqkYCO
P9d5j/DIKzitSbr5SD07dJPLdY7LQ91bACnPyXgawQ==
=zXDP
-----END PGP SIGNATURE-----

--8MZ0cbvgWoPdEv2qmeX6bjF7EgWiEG1EU--


From xen-devel-bounces@lists.xenproject.org Mon Oct 18 15:40:08 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Oct 2021 15:40:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.212465.370338 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcUk6-0005Fq-74; Mon, 18 Oct 2021 15:40:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 212465.370338; Mon, 18 Oct 2021 15:40:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcUk6-0005FA-3C; Mon, 18 Oct 2021 15:40:02 +0000
Received: by outflank-mailman (input) for mailman id 212465;
 Mon, 18 Oct 2021 15:40:00 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=628V=PG=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mcUk4-00057K-Bc
 for xen-devel@lists.xenproject.org; Mon, 18 Oct 2021 15:40:00 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id f7fe01c8-fb38-416f-a107-1ddf74c73c0b;
 Mon, 18 Oct 2021 15:39:59 +0000 (UTC)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2111.outbound.protection.outlook.com [104.47.18.111])
 (Using TLS) by relay.mimecast.com with ESMTP id
 de-mta-32-a8NaJD8MOy2AJM3GOqgd6Q-1; Mon, 18 Oct 2021 17:39:57 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB3118.eurprd04.prod.outlook.com (2603:10a6:802:a::16) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16; Mon, 18 Oct
 2021 15:39:56 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.018; Mon, 18 Oct 2021
 15:39:56 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS9PR06CA0220.eurprd06.prod.outlook.com (2603:10a6:20b:45e::23) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.14 via Frontend
 Transport; Mon, 18 Oct 2021 15:39:55 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f7fe01c8-fb38-416f-a107-1ddf74c73c0b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634571598;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=zUPUgUGRp82d2oHDYxtXqy24gz5P2252wrJjPKdhjwo=;
	b=jXie1cN/H+qUFCVHf/DFiB89BXsYlsx0cmVNYM7f1DSz5pLZ65jyrsIY0CiXRbgqJ7gYrV
	5IOt9Kt34WHghA9y7Icm7iBBBcpm4NUVADHWcqAX6r5JVb8yr//WaZesp/GWDEpMRI4ISb
	aLrPkzsIEclo0H8K3JX/XY1+ZqutJ8U=
X-MC-Unique: a8NaJD8MOy2AJM3GOqgd6Q-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ib8hlUX8KXdi0BkzIIkHZ4z7yeqlyDWsULTVb5GrXyvGsJKWXFJKd2uqJimjK/DSvWWFhi2Uo4PpnQGrBNWp2rUNWlw2B5MRv+mur98EOFFvNb8NMVi4+XW/kyu6sT/B7+2Cl6sQR6DlFd27x9mM2hBOZyEetwKgX++ikMEHI/5WNBvMoohizm1JczCI5JlczVe6t/mbIjdG5iw/FlskyCLXRA6h0YT1LqUwASCxGRczYQRh7BhJtq9pj872IvvK8cW/b+dsz9gMziEiquPyecKgID/WuNe/lIB0o59BguSeKt3XuuGSPof7Xh98nmg5wKJnxBT2MDS8GJspPy0IJg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=zUPUgUGRp82d2oHDYxtXqy24gz5P2252wrJjPKdhjwo=;
 b=kjcj9iJsI56tH18KHS2n5+sGF5eTUNgqAAthQ0nLQAaiJ6QM2dZsK29GTpRqy251PN5AcqQtkbosYf3BkzkZEBUE1MS9xFKh6Wzx1CPyzur9VV2125AVxpGFls6uwR075YuUIwDEx9+qjAlc9CBeUHOgASZ69+AynZ/nkzOFnJMd5pbtcNB+LpDFWUCoK9mSv33obOX6blIglygPKmlK53PWJdTfDQJ0+R1nKT8T3jN4P8OjCtUj5TDXriY4vXLK6F92/JnaR60YZvOTvWlm3INtq1GCMqXd7Z6vmZezcNqLVTsS4bEkxLIVbLCHCxn0JSxJ/jnW1erI7PLfYLnrAw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [PATCH 06/12] xen: generate hypercall interface related code
To: Juergen Gross <jgross@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>, xen-devel@lists.xenproject.org
References: <20211015125152.25198-1-jgross@suse.com>
 <20211015125152.25198-7-jgross@suse.com>
 <e5f55c9e-5615-7d10-c86c-db1a3c724f43@suse.com>
 <e547b584-54e6-3227-82a8-ff1301eddb21@suse.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <d4050acf-b9ce-e619-5357-96fed8324215@suse.com>
Date: Mon, 18 Oct 2021 17:39:54 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <e547b584-54e6-3227-82a8-ff1301eddb21@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0220.eurprd06.prod.outlook.com
 (2603:10a6:20b:45e::23) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 4e5fc9f4-ef67-4f44-86b7-08d9924d8906
X-MS-TrafficTypeDiagnostic: VI1PR04MB3118:
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB31186546BCBAD20228C9B1E2B3BC9@VI1PR04MB3118.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6108;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	nvKGsGO3aFydaCXGGwcz9lRFWd5BqMz60KW6sMczbjYA+CE/Z1xA7bpjrVjizUsoxmG9tn1JtkIw4yxrHvTQBLJe2rR4sW8jNteqtifhjw/ajlHnUqIiNc+BlZBRQ3wiv8MkKwOZDTrgkC9rTDnQTZY1QvXZCMKPCtp1X0LwlMYZfSaNbGSE7v8KsYmS7vlecYZca8eZsx90C/fbkWUk3xm6vPg5pi1YL1uPRdqyiW96ERaC68CYtzW1B8gV/ixfk/MC/aeXgBPvOFb/vnAKQPhel5jTsDz2wf8mDFnziOS2pUqc2cYxc/Fdd+FeswbdDQwbmlVJB8asmmDneOTPZrux8PxZ9IIWaH9Frf4IfAGJyk2KzIcN0Ddl2ovcAk2hIdhjTlTNYI4RdF0N/rWjXQkTH3SLbBHSIp3FUwpexml0aoeX987YitjhVktGR51Gdvx6g+KdFb7CxolP5J7WOQLjcJUFGz6WZqxRRIqhi3TxjBRsT6g0zhyVdWXn2qUrguIZLD4XIjdYTaJBcolWTGjfSdLZVhLC/pQDSvHKHfzU2nqJ2G7FR4+zd02M+mmtpJl3LjcBN+ucOwvvs4uc5cH9kD0jslbWB/BYrY5Vwj/oRBWYmvn41g7K1+INyEuJWNQNwIdWVDY36xqo/H0VVl+/TTZF7m6qhbZ1WXWvWBWyrJcVuANBhlA24pt95JlRhBZMajoX7OmsdyaB/PjTjzc8bhbSF64UGdzlriVJSYCgPOVB1lg2uKbGzI4Z+3f2
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(31696002)(956004)(66946007)(53546011)(83380400001)(186003)(6862004)(66476007)(2906002)(316002)(26005)(4326008)(16576012)(37006003)(6636002)(6486002)(5660300002)(8676002)(86362001)(2616005)(66556008)(508600001)(36756003)(38100700002)(31686004)(8936002)(54906003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?RnlGV1Fwb1ZkUGs2NjJjbVJxM1JsNG4rVGdnNkhsVkNiaHIxM0diVW01a3ND?=
 =?utf-8?B?RjVEbjdVRHQzOFRjSDNHQ29Vb2FEcnlDTEFUTjAxZEc3SllpWTBDS05Dc3hD?=
 =?utf-8?B?am1ldEpXK2ZuQVdvQytLdTh4eXordmdjWjMwL2xLQmFzM3FvUWsvQ1pBSENy?=
 =?utf-8?B?YjViNnlpT2hvS3ZhZVZoZjBDWEUzUmloeHpNQVp5VmpOck5VS1A0Zk9BRitV?=
 =?utf-8?B?R0tzeUxvQ2hMZ0lyKzZDbFlMZ09VZnFDaURsaGhoOTBoUng3d2VDc2Jtai94?=
 =?utf-8?B?bjQwblJ2MEk0Y3ArcVFuMEVnTVV0ZUFsS3praTNrVHl1QWVxSU1Rd0xZS3Jr?=
 =?utf-8?B?NTl0bDVxeEhLeUMxZ2NxSFRSaUwzMmFSdzFvVkVxV0lHK09RdVJLaWV0aWQ4?=
 =?utf-8?B?SVhwZ0NYZUJoajR2VlViem1OeVlXaUg2WVJqYkZlZEwrdmNySTBQN0gxdU85?=
 =?utf-8?B?N1FyUUk1bTR2ZnBraDAyTmpoaUtGN290QXRzYjk0QWxiaGYveGxXcittUlBp?=
 =?utf-8?B?bkp1YUlqdnBEbWJiQ1JYWUZSVkxvKzRIMS9BaHFFc1FXSU9PeFQ4a2FiYTFT?=
 =?utf-8?B?eVliMW9QaytBMnh6NTkza284R1NsZlAxMDdMOGJPVGlGc0JIYzZHVmRGdjVu?=
 =?utf-8?B?dGVxMTFCaFZCUTYzVVZCNEtuYXZabkRkR3VZbEZFb3l6aUxhWjkwUVNoS05S?=
 =?utf-8?B?c3VKMndIRDJoNGhOWmJiSzFJZDZwa2UwNFhXSHRXbVcxc2I3NXFJZGU3Y1BE?=
 =?utf-8?B?QlNKLzlnZkE3NFhLWW9lMGhaOWFXWUZ5OTZDUjNlYVBROHFFYnlRbjd4VFk4?=
 =?utf-8?B?aTlzRmNqcFlLTXl3V29LZjN5TkcxUFF3MllwNEJWSXFnUFFnS3k1MDBHR2hD?=
 =?utf-8?B?c0tFUTdOSDRMSFNETkFOd1JnQXBmZDQ5ZjZJU3FHemRKYmRHNnpJcGE1VW1V?=
 =?utf-8?B?eUUydnlPVmdWZjdqU0tOWi94d2NDRWlpZDloalhmZ3dVd2c1V1ZzZm45RVVI?=
 =?utf-8?B?K1o3cWZwSUt5dm1QRjJXTzQ3TUkwNjVDZGFIQkcvbXJRQVk5QTlKeG10STlO?=
 =?utf-8?B?bnF6ZTZYNmVFL0ZiVS9DdnFoQk0xUGFrVk1ZV3VBSnloYlhsSVhqaXJ3Sy9K?=
 =?utf-8?B?TVpRTk82RHUwclBJTFMrd0FlMy9HWWN4TVd5Vm5rcGF1ZWo2TDYyRGNGTjV1?=
 =?utf-8?B?VndYQkhQSjZTN043bTFvNnBiN0hmaUZyUHNia0REN0FDZTkxSlBOeThEMk42?=
 =?utf-8?B?cE13MW0za3VJWitHNHZ3ajRBdzBrbjlJU2I5U2tlQlNEQmFrNmJYRjNsRFA4?=
 =?utf-8?B?N0x0STdXVS9tdjhPVXp0dTJPWXpSY0Fqa2xBdDlVRXlIdi8yWmV0QmdXd1Q2?=
 =?utf-8?B?NE8vMkdUa3BzRDg1Q00zemJJcmhZYTVTUDhYUDJXcU0wcGpxVDJnVURlNEVi?=
 =?utf-8?B?ZE5sMFplK09RN2gwdW9wMmpTQWUwUFZxaGxBMm9lbTJTQ1R4cEdUdFh1aWpR?=
 =?utf-8?B?UTZKdUx3N3k5TVpSRnYrVksyTEREaDNwb3NyVTFpODZaOUJHY2ZvVUMrZG5r?=
 =?utf-8?B?T1dpUEZCT2JRcDdITjNFYmg2NkRFOFlIRTBGWldDQXJjZ0JzbXQ0OUthQWlw?=
 =?utf-8?B?RTdxZmR4ZWN0TjdrTkRaam1iNlFRN1VHKzlGU1g1alRyT2Z6eVN5ekh3ak1O?=
 =?utf-8?B?ZGI5K2xpYzEySnhRc0xkY1BHNmZUemw4RDZCczdqNlZGNkUwei9veVQwd1dM?=
 =?utf-8?Q?u0cK0Htz40FA4ikTHQQgnoRHcf0eJ/9dJ9qNInQ?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4e5fc9f4-ef67-4f44-86b7-08d9924d8906
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2021 15:39:56.0458
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: CvGaT66FQW6cJ6bwC/kyJYWTSxnZmlnAgVVejnVInB7nQsE7OGHEGnMwsQjddxDKtNGlOnF8qS6/AKhIkzPPAw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB3118

On 18.10.2021 17:28, Juergen Gross wrote:
> On 18.10.21 14:58, Jan Beulich wrote:
>> On 15.10.2021 14:51, Juergen Gross wrote:
>>> Instead of repeating similar data multiple times use a single source
>>> file and a generator script for producing prototypes and call sequences
>>> of the hypercalls.
>>>
>>> As the script already knows the number of parameters used add generating
>>> a macro for populating an array with the number of parameters per
>>> hypercall.
>>
>> Isn't that array intended to go away?
> 
> I thought so, yes, but on Arm there is a case where it is needed.
> 
> So generating it from the available data is the sensible thing to do
> IMO.

Absolutely, if such a table continues to be needed.

>>> @@ -466,6 +468,14 @@ include/asm-$(TARGET_ARCH)/asm-offsets.h: asm-offsets.s
>>>   	  echo ""; \
>>>   	  echo "#endif") <$< >$@
>>>   
>>> +quiet_cmd_genhyp = GEN     $@
>>> +define cmd_genhyp
>>> +    awk -f scripts/gen_hypercall.awk <$< >$@
>>> +endef
>>> +
>>> +include/xen/hypercall-defs.h: include/hypercall-defs.i scripts/gen_hypercall.awk FORCE
>>> +	$(call if_changed,genhyp)
>>
>> As per patch 5 there are quite a few sources including xen/hypercall.h
>> and hence (in one of the next patches) the header generated here. If
>> this one gets re-generated for a benign reason (i.e. without changing
>> the header), all dependents will get rebuilt for no reason. Use
>> $(move-if-changed ...)?
> 
> The reasons for re-generating are quite limited. The most probable case
> is a .config change, which will trigger quite some rebuild anyway.

Oh, good point - I should also have considered the dependencies here,
which are pretty limited. Please disregard my remark then.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Oct 18 15:42:08 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Oct 2021 15:42:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.212474.370349 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcUm7-0006Wt-M7; Mon, 18 Oct 2021 15:42:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 212474.370349; Mon, 18 Oct 2021 15:42:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcUm7-0006Wm-Iw; Mon, 18 Oct 2021 15:42:07 +0000
Received: by outflank-mailman (input) for mailman id 212474;
 Mon, 18 Oct 2021 15:42:05 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=3tpC=PG=citrix.com=roger.pau@srs-us1.protection.inumbo.net>)
 id 1mcUm5-0006We-83
 for xen-devel@lists.xenproject.org; Mon, 18 Oct 2021 15:42:05 +0000
Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id f0d65f32-3029-11ec-82dc-12813bfff9fa;
 Mon, 18 Oct 2021 15:42:04 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f0d65f32-3029-11ec-82dc-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1634571724;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=NK0ySM5BDbAMR/5pJvLLECJhlcat3ZjFUW/iLeLS4sY=;
  b=iRlyS7E2WkIQs0Xvk9npzcnktVj1HZqZWNuoYkOoBV/LbrVh/XwavIBp
   UZK6W/PgDDbCMaGHYfIaPGWKg5g2bNm5d6zk4BdEdtPYQylrpmRCJDqcj
   FMiJbTXXE0yOktyl5XvTy8Uxc9O9+SORpwRZcO0kh1YLseat31i44HX4E
   Y=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: IxZho07Rll2YSGepH2CpjA7ZrHnGW7+Wu9e/OZtqDVRSaxmQn0bGbK/W6ayDVqigq3Jh0Lu57R
 9JXjGwU9Wm36KtXNzW2LDhOpsI82XIgTsOs+DZfNGa1DUj4dd670f3rtVOKindecrjilAKs+F8
 FERkUavgfquhbFZZYLSa6mhtCQ1g2E8uk8zkh4hUxemm/vTlMULR1eCnhsI2jxwxy3YEEEEW+V
 nQ9pM4KSqub1Dh0eV/SH5MmXLBLOYRVI6OdCMFOMZKuvbJNkqX5p6yFY77Vrlp/lfh6MQxZ5zr
 qjRIa2WlXFi0uTDblZeESA09
X-SBRS: 5.1
X-MesageID: 55481363
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:vtlYPK9i9Qu8dkPbdwnZDrUDW3mTJUtcMsCJ2f8bNWPcYEJGY0x3x
 zEYUDqBMvuDMWWkedglPojk9kJXsZTcx4BqQAJr/i88E34SpcT7XtnIdU2Y0wF+jyHgoOCLy
 +1EN7Es+ehtFie0Si9AttENlFEkvU2ybuOU5NXsZ2YhGGeIdA970Ug6wrZg0tYy6TSEK1jlV
 e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH
 I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPh61
 9FpmN+pdz4pO6j2yc5MTDcJCHhHaPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us
 6ZCcXZUM07F17neLLGTE4GAguw5K8bmJsUHs2xIxjDFF/c2B5vERs0m4PcFgWtg35sQRp4yY
 eJCVzxKaSzbZidwFXwoIsNgne6BokbgJmgwRFW9+vNsvjm7IBZK+KfpGMrYfJqNX8o9tlaVo
 CfK8nr0BjkeNceD0nyV/3S0nOjNkCjnHoUIG9WQ9PRnnVmSzWw7EwANWB2wpvzRt6Klc4sBc
 QpOoHNo9PVsshzwJjXgY/GmiHWbujoxGMNuKu0/7Tvc4PvLzVeCX1FRG1atd+canMMxQDUr0
 HqAkNXoGSFjvdWpdJ6NyluHhWjtYXZNfAfucQdBFFFfu4Cy/+nfmzqWFo47eJNZmOEZDt0ZL
 9qilyM5m6kIxfAC06G27DgraBr9+8CXEGbZCujRN19JDz+Vhqb4P+RECnCBtJ6sybp1qHHb7
 RDofODFtIgz4WmlznDlfQn0NOjBCwy5GDPdm0VzOJIq6i6g/XWuFagJvmoieBY0Y5xYJWW4C
 KM2he+3zMUCVJdNRfQvC79d9uxwlfSwfTgbfqG8giVyjmhZK1bcoXAGib+41GHxikk8+ZzTy
 r/AGftA+U0yUPw9pBLvHr91+eZymkgWmDOCLbimnk/P+efPOxaopUItbQLmghYRt/jf/m04M
 r93aqO39vmoeLaiO3aKrdNKcAliwLpSLcmelvG7v9Wre2JOMGogF+XQ0fUmfYlklL5SjeDG4
 je2XUow9bY1rSevxdyiZi8xZbXxc4x4qH5nbyUgMUzxgyooYJq17bdZfJwyJOF1+OtmxP9yb
 v8EZ8TfXagfFmWZo2wQPcvnsYhvVBW3ngbSbSCrVycyIsx7TAvT9966Iga2rHsSDjC6vNcVq
 qG70l+JWoIKQglvVZ6EaP+mw16rk2IaneZ+AxnBLtVJIR2++4l2MS3hyPQwJphUexnEwzKb0
 SeQAAsZ+raR89NkroGRiPnd/YmzEuZ4Ek5LJEXh7O67ZXvA426u4Y5cS+LULzrTY3z5pfe5b
 uJPwvCibPBexARWs5BxGqpAxL4l44e9vKdTywlpESmZb1mvDb88cHCK0dMW6/9Iz75d/wC3R
 liO6p9RPrDQYJHpF1sYJQwEaOWf1K5LxmmOvKpteEiqtjVq+LenUFlJO0jegSNQG7J5LYc5z
 Lpzo8UR8QG+1kInP9vuYvq4LIhQwqjsi5kai6w=
IronPort-HdrOrdr: A9a23:hTvxHKtBDPbmwiT4hmtUXel37skDctV00zEX/kB9WHVpm6uj5q
 eTdZUgpHvJYVMqM03I9urtBEDtexzhHP1OgbX5X43NYOCOggLBRuxfBODZogHIKmnT8fNcyL
 clU4UWMqyUMbGit7eY3OBvKadD/OW6
X-IronPort-AV: E=Sophos;i="5.85,382,1624334400"; 
   d="scan'208";a="55481363"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=iW/uT6dmkwzQDh6hjUhqfiig3JhtGY5wtF0NpnKCZP28jxnaYC5UePQIlGSlTuXBTPQ2ptrTO7aM0FMLiU/VCUg4G95SrlpkJdCixeApDVBkf5RSbAX9VKNnvXkl1jiq2PaDsizP7Z+QyXihbmwkOHhRHjNG1QtY83Ns4c4SB7ea+UQ3SLP54i34ePwz5PKS1sdqZMq1YbESM5ef7oZRIG57bCHi7GiY2slkaR/LwpUgqRSRcQSsu6sbVZDPCtpRqp4f9bVwvOabRPrsZavVPpoTcm6LeXwRcZ7Egu2rO8swkj4xG+rEZgwptCAdbF5JRYi4pqiwSfkwEceAI9o0nw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=TY/D0QMVjGS3U/WUIUrBzOE/lhuGLCxFMHpuPHZlzIw=;
 b=YghZxlXQgzmxdshfeC3cCKgJBX9op12tRdQEReGt3poofEdV8OVOHox2LpQPhARB5JHLeQGTXWCeEjFkId7M+lg63PvrKOMvaWSQ4cGSeVrF5V8Qi32E1DSl96M5BoB3XhxyqYQahUFUnSmOAg2CYXDqEnfPDVS9ECv+stGgifsGnBzlLTZCxLukvkognDzDq1Y4wCgVpp5jWjf7wTdaC5CmoSbuXtlpDEJZW9DLDBgx381MNLyeCccPziFL55RHqKqNHENvs4XercEd+ti9CUZG7oLpltK9Zpvj4C105WBNaD8XEvMXBzs7+6FhGYkyGt2d6PZiTcBNgGb7RSaAPA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=TY/D0QMVjGS3U/WUIUrBzOE/lhuGLCxFMHpuPHZlzIw=;
 b=ddR8ymQcoKYQLrPkAJ2SpAtVeGvLTpgcGO2KDLLaLmP5VHuxLaZekGzx1HTpgjkfcFn+IexID2Ne4KlhEeT/C9NvYTEPtv3nDgEpA1z+Bt6t26aDbQwAniQdkns/9PxhHQ4OnQQx1s9lizSr7Ln7HU0ecXpvodxBlt5zmXoojtA=
Date: Mon, 18 Oct 2021 17:41:52 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Andrew
 Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH 2/3] x86/PV: replace assertions in '0' debug key stack
 dumping
Message-ID: <YW2VwAz9L1IRPHjK@MacBook-Air-de-Roger.local>
References: <2a14f2d0-2a53-287f-da36-dfb054c7f944@suse.com>
 <5ab88195-660e-5d73-cc34-67734ae161fa@suse.com>
 <YW2EJaZ4DoR6ptp1@MacBook-Air-de-Roger.local>
 <1a9b77bc-3637-e1c0-4a8e-63126e643aba@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1a9b77bc-3637-e1c0-4a8e-63126e643aba@suse.com>
X-ClientProxiedBy: LO4P123CA0265.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:194::18) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 0f216ec7-f83e-4265-bfb4-08d9924dd18b
X-MS-TrafficTypeDiagnostic: DM6PR03MB4476:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <DM6PR03MB44768A6E06844BB9FE8168688FBC9@DM6PR03MB4476.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: /RBh7LZp1I+/40nRbwxLfAyLquUff7wvh8EMQj8xYr7ZxtjOuFlYBmWxdaLkjeEhOPweRaES5VXzfIIDJ693YVbxzNvZ7VkjFzljAR8evAS2EdkKB5c7UVFHjjmE8F9x3ahMK8aZsigUwetJn0cx4Cj+VisNQzOFvbKM9MIXnUJGkPfpEkoad1It/ZXV7bQ5wdP2r01LWCNJEOyKdOXbmfRY50rTKU/wwpB4oF5RZkxBWfUHXDGUiKxlBtAvYdlHHDGrlYtfnimgYrsQ1aYF0wDffPpxYhEA3h74L1nbLliZN7rDVSES5X2Vvc8e5lkEican26kVOhLnEv11vTwMSeSd9dU69q0LREPWXs1ABxzDNW8sTpHuLitFifgaqi8etuJ7sDdRLsMin5CgDA2yxqB/CY0lGnXRME9PbPw645pTnWvcUhmPKoZldRidhBQO2uv0+hyMUxjpngv9LYkC8WX5SRQriRy46lJ4Iz9vbZegTBp7KqPPafm359ijMDwYKUChS4XKridNlDcThJGT11wzZuODhIKnmfkpD58kWR0JuL5rdMRymVJlt+X3tuy3gRytw9OgI0YZynP2g18ecHVumzAvs7Fm+d5IN+1wL2+YlDr+ACAa6JiSjhKLknL+/tJAHY+N5E9S3mFeVZ5rOg==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(83380400001)(8676002)(26005)(66946007)(54906003)(8936002)(2906002)(5660300002)(6916009)(186003)(6496006)(85182001)(6486002)(956004)(53546011)(508600001)(9686003)(6666004)(66476007)(82960400001)(66556008)(4326008)(86362001)(38100700002)(316002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d3JYRzlHWmt0WXdKQU1uUlphRkhFVmxDVFJjWCs2STlNelA1bGpmNjVjSllC?=
 =?utf-8?B?M2U0KzBtUDRJcENiUU1ZYmNrMGFZeE45NU1GdXdxd2t6RzVqeFJzWSsvZjQ5?=
 =?utf-8?B?OVNKbVV0anVrcjhNbFlMUC9EUmlKb0FDYmF2d29JdVFIVzE4NG5NenZ2MVE1?=
 =?utf-8?B?aFduREJ0bUVMUDkyNm9UaU1GZWtoK1Y1eHl2L0JwRmpHZkttQkxUT2o5bm1y?=
 =?utf-8?B?TVRzVmZLaTVhOEhLUGUvYVhIazJFNGN2MnROUjVLdmVsQmZqQVdBaTlJWXdm?=
 =?utf-8?B?OFpvRDZKU0lITU9PRm5Ua2dRenNobHVVc2hyeVNkS3JCQXVvTm5BSzkvVzdQ?=
 =?utf-8?B?aVZXVjBUN0QwMVRnb0NOVWdpZW53VnplVkRYR2xtUk1QM2piaTVJakUzdW92?=
 =?utf-8?B?SlhSS2dTTWphN2pxUlJqSS9teU9MS29YTUc2V1ZLWWk4WnVHdnRkdVB6czIx?=
 =?utf-8?B?dS80OVVrZmtLZmRUZ2hvRWcrUEF2cGY3KzNoVnFnekVndHlTYjBhaGdlZDA4?=
 =?utf-8?B?dmlyZmgvMDRMYk1RbXlwMzN2V1RTYWlXc1dEZkZ0aFZXRU5hb3paeUZMekcx?=
 =?utf-8?B?cXNyaDhVSzNuVzdPUWQwVmg3d2lRSUNkNFluQ2NmdUNhS1F3MHMrRlBXd3lz?=
 =?utf-8?B?Q2RWdVR3VmFMdzZyWEpXVXEzdThsNlIzZEIxUjFpRitqa3RJcDNZR2QrYUxZ?=
 =?utf-8?B?ZTFhK3VxZW5oQ2V4TmpNQmkvQ1E2a3JSaFpEREhyR2p4a0I4dzJJejV6NjN2?=
 =?utf-8?B?QmRWS3VTekxTTS9LYkdKS2hXckFBTGdqOTdGdFhTMkUrUnM5RUlqVDNTdmt2?=
 =?utf-8?B?STZzMm45R1FiL0ZZMStFQ1BKQTdoK3BpaFhwNU8rNlhyTXZET1lpeS8yVGdI?=
 =?utf-8?B?cDFrcE5RNDFPMWpaVnpRNmtTdUVaNWdtQkhpZlBDZXlRR09iOHo5VGhwMnp0?=
 =?utf-8?B?amMzTXpiS1F4cG5oUnZ4RkVQV3RSRHA5T3d5SEZKdm9ldWVPakdndmpTUnln?=
 =?utf-8?B?NXRLU0lUZmI0UGN2anZYTnBsRjlhMFNjbHV1UEVzL1hmMWI1em9McWl1Rllp?=
 =?utf-8?B?dElQZWRISXU3S0RJdlR3M0k5c2s2WjBUMndCRXBGWHBXZzhiRGFuN28va3o3?=
 =?utf-8?B?a1A0WllqeGR3K2plUjhnKzBGcUFpQThHQ3o4LzdNNVFEeVVneVl4VGJTS0la?=
 =?utf-8?B?dXVWL0hhWXF1TXRkeXhObW44WXFJUGo0c294dk1WVUU3U1ExeFg5ZzNpckN3?=
 =?utf-8?B?R3J5bnJJeUFjU3dWQ0JWRlFJT1Roc0hSaTBFbGpEbHhLUFNtYTNLL0NwSTFD?=
 =?utf-8?B?Tk52VkVneWgxTmY0NGxGSjFmR3Q5aks3bHI4M0xHL2JBM1hIYXVxZE81cGdR?=
 =?utf-8?B?YzU0TjVEcmdDdWRlUTh6RlorRnRQbW1rR0UyTjdiaGdDMWF6a2Nhdm42bnBT?=
 =?utf-8?B?Y1pyeVVUSjEwVVNXajFKZktTR3EwREdudEZhZFJBeUJBeDVHWWhzb1VJOERl?=
 =?utf-8?B?YS9xb2xZcVZOaEtmUEpVbnBhMGlNWDBUQUFYejNWTGs1b3hUNksveVk0NWYw?=
 =?utf-8?B?YXRaSEZwWWl2bURJL2c0ZitFdW9WK253R1ZTdG1qcXZUTkh6ZVhILzRvSE5t?=
 =?utf-8?B?MzExNTFlRzRJQ0QzWm5XbitHTFJsMHBJUUI0NmozUHJRQTNESnQ3Q3lQanhK?=
 =?utf-8?B?KzVDWXJGOHlreFV4RGFSY2FINHgvMWhQK2FqZG85ejJ3WCtsdnJ3cHNjcWh0?=
 =?utf-8?Q?TAdrPLu9OIWFOOoU6/F3oVrB/5674VMseOigy1Z?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 0f216ec7-f83e-4265-bfb4-08d9924dd18b
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2021 15:41:57.7789
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: RZXj6IxURiXZibqI6BKa0YHsWZ/+EMR499qCfyUX7SoJgPl3rTjSaa8+oZoaLPYruf+BRlN7su6Dg3Rob344dQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4476
X-OriginatorOrg: citrix.com

On Mon, Oct 18, 2021 at 04:37:27PM +0200, Jan Beulich wrote:
> On 18.10.2021 16:26, Roger Pau Monné wrote:
> > On Wed, Sep 29, 2021 at 11:42:54AM +0200, Jan Beulich wrote:
> >> While it was me to add them, I'm afraid I don't see justification for
> >> the assertions: A vCPU may very well have got preempted while in user
> >> mode. Limit compat guest user mode stack dumps to the containing page
> >> (like is done when using do_page_walk()), and suppress their dumping
> >> altogether for 64-bit Dom0.
> > 
> > I'm slightly lost by this last sentence...
> > 
> >> @@ -328,7 +329,12 @@ static void show_guest_stack(struct vcpu
> >>      {
> >>          struct vcpu *vcpu;
> >>  
> >> -        ASSERT(guest_kernel_mode(v, regs));
> >> +        if ( !guest_kernel_mode(v, regs) )
> >> +        {
> >> +            printk("User mode stack\n");
> >> +            return;
> >> +        }
> > 
> > ...as you seem to unconditionally prevent the dump regardless of
> > whether it's dom0 or domU as long as it's not a kernel stack?
> 
> Well, Dom0 comes into play by way of me talking about debug key '0'.
> I've replaced "Dom0" by "domains" in the sentence.

Thanks, with that:

Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>

> > I assume when running in PV 64bit mode user-space could be executing a
> > 32bit program and hence Xen could then misprint the stack as a 64bit
> > one?
> 
> That's not a primary concern, I would think. The real problem is
> do_page_walk() doing
> 
>     unsigned long mfn = pagetable_get_pfn(v->arch.guest_table);
> 
> first thing: No consideration of guest user mode here at all. And
> I didn't want to teach it without real need.

Oh, indeed. It would need to use guest_table_user at least.

Roger.


From xen-devel-bounces@lists.xenproject.org Mon Oct 18 15:56:41 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Oct 2021 15:56:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.212483.370360 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcV05-00087B-UW; Mon, 18 Oct 2021 15:56:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 212483.370360; Mon, 18 Oct 2021 15:56:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcV05-000874-Ql; Mon, 18 Oct 2021 15:56:33 +0000
Received: by outflank-mailman (input) for mailman id 212483;
 Mon, 18 Oct 2021 15:56:33 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mcV04-00086u-VK; Mon, 18 Oct 2021 15:56:32 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mcV04-0008Rj-Ql; Mon, 18 Oct 2021 15:56:32 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mcV04-000112-9z; Mon, 18 Oct 2021 15:56:32 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mcV04-00086q-9V; Mon, 18 Oct 2021 15:56:32 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=iwaABtJyhOEvzYDkikKC9r/YjT+G4lnSHEx6JYudHHw=; b=xxvHyGNkgbQtVRtf9UCe2sVimo
	LC58i2uMF4oWic5M+1ASWATmqGSMpU4tdo+Uu0+PJ5hBCHel8n1bkevDZlYNRucecPI3D/e43O2tH
	nrUpWELBFWuXG8K/oV042NhIlER9nMAuasBB6opVUIW+XE4yJG0bpQNwrb/j2f3m9r9Y=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165635-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 165635: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=c11b8d25fbe9c0155e91409594ea6701008409ed
X-Osstest-Versions-That:
    xen=52d0847d7c6972baa74156f14ee8544f5aba1d2d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 18 Oct 2021 15:56:32 +0000

flight 165635 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165635/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  c11b8d25fbe9c0155e91409594ea6701008409ed
baseline version:
 xen                  52d0847d7c6972baa74156f14ee8544f5aba1d2d

Last test of basis   165530  2021-10-15 20:00:27 Z    2 days
Testing same since   165635  2021-10-18 13:00:26 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Jan Beulich <jbeulich@suse.com>
  Roger Pau Monné <roger.pau@citrix.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   52d0847d7c..c11b8d25fb  c11b8d25fbe9c0155e91409594ea6701008409ed -> smoke


From xen-devel-bounces@lists.xenproject.org Mon Oct 18 18:15:06 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Oct 2021 18:15:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.212509.370374 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcXA0-0005SX-38; Mon, 18 Oct 2021 18:14:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 212509.370374; Mon, 18 Oct 2021 18:14:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcX9z-0005SQ-V7; Mon, 18 Oct 2021 18:14:55 +0000
Received: by outflank-mailman (input) for mailman id 212509;
 Mon, 18 Oct 2021 18:14:54 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mcX9y-0005SG-FQ; Mon, 18 Oct 2021 18:14:54 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mcX9y-0002r1-8W; Mon, 18 Oct 2021 18:14:54 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mcX9x-00061x-V9; Mon, 18 Oct 2021 18:14:54 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mcX9x-0002r7-Ud; Mon, 18 Oct 2021 18:14:53 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=q5QK8wKp4OBWQYDrsPkEBthM2QzevLY+R9DAY3s8CuU=; b=MrpYdEwkLxqv4pyEO/eghqjrOj
	9vcS+YpHYO58zSHa51VcZ+sM7PTp84+wA/P4szre36MV/GmMyXCt98NZIb87z4pQV3/Mi5oPqxcbR
	T403ykL7I7ido6cghAXSvfpRVexzNwlvc+m2BuXaZmu1L2rzYJa94F5lFh6WIb/JmpmI=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165637-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 165637: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=210869834639c1150b1f016e2022472a55cdd884
X-Osstest-Versions-That:
    ovmf=f10a112f08f3fb4a92c3d22f069f6066a12db3be
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 18 Oct 2021 18:14:53 +0000

flight 165637 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165637/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 210869834639c1150b1f016e2022472a55cdd884
baseline version:
 ovmf                 f10a112f08f3fb4a92c3d22f069f6066a12db3be

Last test of basis   165531  2021-10-15 22:11:21 Z    2 days
Testing same since   165637  2021-10-18 13:41:07 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Marvin Häuser <mhaeuser@posteo.de>
  Shi Steven <steven.shi@intel.com>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   f10a112f08..2108698346  210869834639c1150b1f016e2022472a55cdd884 -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Mon Oct 18 18:32:59 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Oct 2021 18:32:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.212517.370388 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcXRO-0007uQ-Jc; Mon, 18 Oct 2021 18:32:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 212517.370388; Mon, 18 Oct 2021 18:32:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcXRO-0007uJ-GT; Mon, 18 Oct 2021 18:32:54 +0000
Received: by outflank-mailman (input) for mailman id 212517;
 Mon, 18 Oct 2021 18:32:52 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mcXRM-0007uD-KO
 for xen-devel@lists.xenproject.org; Mon, 18 Oct 2021 18:32:52 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mcXRM-00039e-59; Mon, 18 Oct 2021 18:32:52 +0000
Received: from [54.239.6.185] (helo=[192.168.19.91])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mcXRL-0005hd-Uc; Mon, 18 Oct 2021 18:32:52 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=FpD3UpnW9Nxhki4OwA10RgZLqjawutR26jY2yHoHd+M=; b=w2vv1l16LOk2xMYreNIeZdWATm
	neblr/Gob4E5eBjM+DfsTiN68wol8/MlLWd50C4m7TZh7L/DHfv3Y5aOnWImIaWhMjdXfwbnqFPlx
	SqW8MmCUSMtq9WRz3kR92mdNjMKkgqPOd/hSwYUkDyzLL3PIr/GfMFPtuKx04rnUPHHw=;
Message-ID: <69d6abd2-55e4-e821-1aaa-828cc49baae6@xen.org>
Date: Mon, 18 Oct 2021 19:32:48 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.2.0
Subject: Re: [PATCH v3 11/11] xen/arm: Translate virtual PCI bus topology for
 guests
To: Oleksandr Andrushchenko <andr2000@gmail.com>,
 xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org, oleksandr_tyshchenko@epam.com,
 volodymyr_babchuk@epam.com, Artem_Mygaiev@epam.com, roger.pau@citrix.com,
 jbeulich@suse.com, bertrand.marquis@arm.com, rahul.singh@arm.com,
 Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
References: <20210930075223.860329-1-andr2000@gmail.com>
 <20210930075223.860329-12-andr2000@gmail.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20210930075223.860329-12-andr2000@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Oleksandr,

On 30/09/2021 08:52, Oleksandr Andrushchenko wrote:
> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> 
> There are three  originators for the PCI configuration space access:
> 1. The domain that owns physical host bridge: MMIO handlers are
> there so we can update vPCI register handlers with the values
> written by the hardware domain, e.g. physical view of the registers
> vs guest's view on the configuration space.
> 2. Guest access to the passed through PCI devices: we need to properly
> map virtual bus topology to the physical one, e.g. pass the configuration
> space access to the corresponding physical devices.
> 3. Emulated host PCI bridge access. It doesn't exist in the physical
> topology, e.g. it can't be mapped to some physical host bridge.
> So, all access to the host bridge itself needs to be trapped and
> emulated.
> 
> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> 
> ---
> Since v2:
>   - pass struct domain instead of struct vcpu
>   - constify arguments where possible
>   - gate relevant code with CONFIG_HAS_VPCI_GUEST_SUPPORT
> New in v2
> ---
>   xen/arch/arm/domain.c         |  1 +
>   xen/arch/arm/vpci.c           | 86 +++++++++++++++++++++++++++++++----
>   xen/arch/arm/vpci.h           |  3 ++
>   xen/drivers/passthrough/pci.c | 25 ++++++++++
>   xen/include/asm-arm/pci.h     |  1 +
>   xen/include/xen/pci.h         |  1 +
>   xen/include/xen/sched.h       |  2 +
>   7 files changed, 111 insertions(+), 8 deletions(-)
> 
> diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
> index fa6fcc5e467c..095671742ad8 100644
> --- a/xen/arch/arm/domain.c
> +++ b/xen/arch/arm/domain.c
> @@ -797,6 +797,7 @@ void arch_domain_destroy(struct domain *d)
>                          get_order_from_bytes(d->arch.efi_acpi_len));
>   #endif
>       domain_io_free(d);
> +    domain_vpci_free(d);
>   }
>   
>   void arch_domain_shutdown(struct domain *d)
> diff --git a/xen/arch/arm/vpci.c b/xen/arch/arm/vpci.c
> index 5d6c29c8dcd9..26ec2fa7cf2d 100644
> --- a/xen/arch/arm/vpci.c
> +++ b/xen/arch/arm/vpci.c
> @@ -17,6 +17,14 @@
>   
>   #define REGISTER_OFFSET(addr)  ( (addr) & 0x00000fff)
>   
> +struct vpci_mmio_priv {
> +    /*
> +     * Set to true if the MMIO handlers were set up for the emulated
> +     * ECAM host PCI bridge.
> +     */
> +    bool is_virt_ecam;
> +};
> +
>   /* Do some sanity checks. */
>   static bool vpci_mmio_access_allowed(unsigned int reg, unsigned int len)
>   {
> @@ -38,6 +46,7 @@ static int vpci_mmio_read(struct vcpu *v, mmio_info_t *info,
>       pci_sbdf_t sbdf;
>       unsigned long data = ~0UL;
>       unsigned int size = 1U << info->dabt.size;
> +    struct vpci_mmio_priv *priv = (struct vpci_mmio_priv *)p;

This cast is unnecessary. Same...

>   
>       sbdf.sbdf = MMCFG_BDF(info->gpa);
>       reg = REGISTER_OFFSET(info->gpa);
> @@ -45,6 +54,13 @@ static int vpci_mmio_read(struct vcpu *v, mmio_info_t *info,
>       if ( !vpci_mmio_access_allowed(reg, size) )
>           return 0;
>   
> +    /*
> +     * For the passed through devices we need to map their virtual SBDF
> +     * to the physical PCI device being passed through.
> +     */
> +    if ( priv->is_virt_ecam && !pci_translate_virtual_device(v->domain, &sbdf) )
> +            return 1;
> +
>       data = vpci_read(sbdf, reg, min(4u, size));
>       if ( size == 8 )
>           data |= (uint64_t)vpci_read(sbdf, reg + 4, 4) << 32;
> @@ -61,6 +77,7 @@ static int vpci_mmio_write(struct vcpu *v, mmio_info_t *info,
>       pci_sbdf_t sbdf;
>       unsigned long data = r;
>       unsigned int size = 1U << info->dabt.size;
> +    struct vpci_mmio_priv *priv = (struct vpci_mmio_priv *)p;

... here. But is it meant to be modified? If not, then I think you want 
to turn it to add a const in both cases.

>   
>       sbdf.sbdf = MMCFG_BDF(info->gpa);
>       reg = REGISTER_OFFSET(info->gpa);
> @@ -68,6 +85,13 @@ static int vpci_mmio_write(struct vcpu *v, mmio_info_t *info,
>       if ( !vpci_mmio_access_allowed(reg, size) )
>           return 0;
>   
> +    /*
> +     * For the passed through devices we need to map their virtual SBDF
> +     * to the physical PCI device being passed through.
> +     */
> +    if ( priv->is_virt_ecam && !pci_translate_virtual_device(v->domain, &sbdf) )
> +            return 1;
> +
>       vpci_write(sbdf, reg, min(4u, size), data);
>       if ( size == 8 )
>           vpci_write(sbdf, reg + 4, 4, data >> 32);
> @@ -80,13 +104,48 @@ static const struct mmio_handler_ops vpci_mmio_handler = {
>       .write = vpci_mmio_write,
>   };
>   
> +/*
> + * There are three  originators for the PCI configuration space access:
> + * 1. The domain that owns physical host bridge: MMIO handlers are
> + *    there so we can update vPCI register handlers with the values
> + *    written by the hardware domain, e.g. physical view of the registers/
> + *    configuration space.
> + * 2. Guest access to the passed through PCI devices: we need to properly
> + *    map virtual bus topology to the physical one, e.g. pass the configuration
> + *    space access to the corresponding physical devices.
> + * 3. Emulated host PCI bridge access. It doesn't exist in the physical
> + *    topology, e.g. it can't be mapped to some physical host bridge.
> + *    So, all access to the host bridge itself needs to be trapped and
> + *    emulated.
> + */
>   static int vpci_setup_mmio_handler(struct domain *d,
>                                      struct pci_host_bridge *bridge)
>   {
> -    struct pci_config_window *cfg = bridge->cfg;
> +    struct vpci_mmio_priv *priv;
> +
> +    priv = xzalloc(struct vpci_mmio_priv);
> +    if ( !priv )
> +        return -ENOMEM;
> +
> +    priv->is_virt_ecam = !is_hardware_domain(d);
>   
> -    register_mmio_handler(d, &vpci_mmio_handler,
> -                          cfg->phys_addr, cfg->size, NULL);
> +    if ( is_hardware_domain(d) )
> +    {
> +        struct pci_config_window *cfg = bridge->cfg;
> +
> +        bridge->mmio_priv = priv;
> +        register_mmio_handler(d, &vpci_mmio_handler,
> +                              cfg->phys_addr, cfg->size,
> +                              priv);
> +    }
> +    else
> +    {
> +        d->vpci_mmio_priv = priv;

Something feels odd to me in this code. The if ( !is_hardware_domain(d) 
) part seems to suggests that this can be called on multiple bridge. But 
here you are directly assigning priv to d->vpci_mmio_priv.

The call...

> +        /* Guest domains use what is programmed in their device tree. */
> +        register_mmio_handler(d, &vpci_mmio_handler,
> +                              GUEST_VPCI_ECAM_BASE, GUEST_VPCI_ECAM_SIZE,
> +                              priv);
> +    }
>       return 0;
>   }
>   
> @@ -95,14 +154,25 @@ int domain_vpci_init(struct domain *d)
>       if ( !has_vpci(d) )
>           return 0;
>   
> +    return pci_host_iterate_bridges(d, vpci_setup_mmio_handler);

... here seems to confirm that you may (in theory) have multiple 
bridges. So the 'else' would want some rework to avoid assuming a single 
bridge.

> diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci.c
> index 5b963d75d1ba..b7dffb769cfd 100644
> --- a/xen/drivers/passthrough/pci.c
> +++ b/xen/drivers/passthrough/pci.c
> @@ -889,6 +889,31 @@ int pci_remove_virtual_device(struct domain *d, const struct pci_dev *pdev)
>       xfree(vdev);
>       return 0;
>   }
> +
> +/*
> + * Find the physical device which is mapped to the virtual device
> + * and translate virtual SBDF to the physical one.
> + */
> +bool pci_translate_virtual_device(const struct domain *d, pci_sbdf_t *sbdf)
> +{
> +    struct vpci_dev *vdev;
> +    bool found = false;
> +
> +    pcidevs_lock();
> +    list_for_each_entry ( vdev, &d->vdev_list, list )

I haven't looked at the rest of the series yet. But I am a bit concerned 
to see code to iterate through a list accessible by the guest.
   1) What safety mechanism do we have in place to ensure that the list 
is going to be small
   2) If there is a limit, do we have any documentation on top of this 
limit to make clear this can't be bumped without removing the list?

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Mon Oct 18 19:23:29 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Oct 2021 19:23:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.212532.370398 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcYE7-0004p9-Gh; Mon, 18 Oct 2021 19:23:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 212532.370398; Mon, 18 Oct 2021 19:23:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcYE7-0004p2-Dc; Mon, 18 Oct 2021 19:23:15 +0000
Received: by outflank-mailman (input) for mailman id 212532;
 Mon, 18 Oct 2021 19:23:14 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mcYE6-0004os-4L; Mon, 18 Oct 2021 19:23:14 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mcYE5-0003yz-Uk; Mon, 18 Oct 2021 19:23:13 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mcYE5-0001fU-J0; Mon, 18 Oct 2021 19:23:13 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mcYE5-0002sA-IW; Mon, 18 Oct 2021 19:23:13 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=N+F1GKGHKyjoj212QkPZ9iCJGB4XoMk7HQoxhm+hPys=; b=dDa1NkFVPUBxQXkm2n2nQq08TA
	IpvAoR6Tkk5KRdm6/KwLYU1RcreLRWfG4Dz6jLZUfj6LT5KWIxsaoPUhGdOA9olP9uhWid/46Qnef
	VGhZOUs5rlPjnYN42DcjJPCEKBNUDJQtEcKr36wkweBnvaYkUg2r5Xytd9T9qm4ngT78=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165638-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 165638: regressions - FAIL
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-xl-qemuu-debianhvm-amd64:leak-check/basis(11):fail:regression
    xen-unstable-smoke:test-amd64-amd64-libvirt:leak-check/basis(11):fail:regression
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:leak-check/basis(11):fail:regression
    xen-unstable-smoke:test-armhf-armhf-xl:leak-check/basis(11):fail:regression
X-Osstest-Versions-This:
    xen=3ae80dea4601764818d1e5b84bd1e4479c0d4790
X-Osstest-Versions-That:
    xen=c11b8d25fbe9c0155e91409594ea6701008409ed
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 18 Oct 2021 19:23:13 +0000

flight 165638 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165638/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-amd64-amd64-xl-qemuu-debianhvm-amd64 11 leak-check/basis(11) fail REGR. vs. 165635
 test-amd64-amd64-libvirt     11 leak-check/basis(11)     fail REGR. vs. 165635
 test-arm64-arm64-xl-xsm      11 leak-check/basis(11)     fail REGR. vs. 165635
 test-armhf-armhf-xl          11 leak-check/basis(11)     fail REGR. vs. 165635

version targeted for testing:
 xen                  3ae80dea4601764818d1e5b84bd1e4479c0d4790
baseline version:
 xen                  c11b8d25fbe9c0155e91409594ea6701008409ed

Last test of basis   165635  2021-10-18 13:00:26 Z    0 days
Testing same since   165638  2021-10-18 16:01:36 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Ian Jackson <iwj@xenproject.org>
  Juergen Gross <jgross@suse.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          fail    
 test-arm64-arm64-xl-xsm                                      fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    fail    
 test-amd64-amd64-libvirt                                     fail    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

------------------------------------------------------------
commit 3ae80dea4601764818d1e5b84bd1e4479c0d4790
Author: Juergen Gross <jgross@suse.com>
Date:   Fri Sep 10 07:55:17 2021 +0200

    stubdom: disable building pv-grub
    
    The stubdom based pv-grub is using a very outdated version of grub
    (0.97) and should not be used any longer. Mainline grub has support for
    PV guests for a long time now, so that should be used as a boot loader
    of a PV domain.
    
    So disable building pv-grub per default. In case someone really wants
    to continue using it he/she can still use a pv-grub binary from an older
    Xen version or manually enable building it via:
    
      configure --enable-pv-grub
    
    [ This was already disabled in osstest by 8dee6e333622
      "make-flight: Drop pvgrub (pvgrub1) tests" -iwj ]
    
    Signed-off-by: Juergen Gross <jgross@suse.com>
    Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
    Acked-by: Ian Jackson <iwj@xenproject.org>
    Release-Acked-by: Ian Jackson <iwj@xenproject.org>

commit 9cfeb83cbe23a873de512211d7ecd989348b9df0
Author: Juergen Gross <jgross@suse.com>
Date:   Tue Oct 12 15:41:48 2021 +0200

    tools/xenstore: set open file descriptor limit for xenstored
    
    Add a configuration item for the maximum number of open file
    descriptors xenstored should be allowed to have.
    
    The default should be "unlimited" in order not to restrict xenstored
    in the number of domains it can support, but unfortunately the kernel
    is normally limiting the maximum value via /proc/sys/fs/nr_open [1],
    [2]. So check that file to exist and if it does, limit the maximum
    value to the one specified by /proc/sys/fs/nr_open.
    
    As an aid for the admin configuring the value add a comment specifying
    the common needs of xenstored for the different domain types.
    
    [1]: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=60fd760fb9ff7034360bab7137c917c0330628c2
    [2]: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=0c2d64fb6cae9aae480f6a46cfe79f8d7d48b59f
    
    Signed-off-by: Juergen Gross <jgross@suse.com>
    Reviewed-by: Ian Jackson <iwj@xenproject.org>
    Release-Acked-by: Ian Jackson <iwj@xenproject.org>

commit f282182af32939107d47943aba242d3189ec6f90
Author: Juergen Gross <jgross@suse.com>
Date:   Tue Oct 12 15:41:47 2021 +0200

    tools/xenstore: set oom score for xenstore daemon on Linux
    
    Xenstored is absolutely mandatory for a Xen host and it can't be
    restarted, so being killed by OOM-killer in case of memory shortage is
    to be avoided.
    
    Set /proc/$pid/oom_score_adj (if available) per default to -500 (this
    translates to 50% of dom0 memory size) in order to allow xenstored to
    use large amounts of memory without being killed.
    
    The percentage of dom0 memory above which the oom killer is allowed to
    kill xenstored can be set via XENSTORED_OOM_MEM_THRESHOLD in
    xencommons.
    
    Make sure the pid file isn't a left-over from a previous run delete it
    before starting xenstored.
    
    Signed-off-by: Juergen Gross <jgross@suse.com>
    Reviewed-by: Ian Jackson <iwj@xenproject.org>
    Release-Acked-by: Ian Jackson <iwj@xenproject.org>
(qemu changes not included)


From xen-devel-bounces@lists.xenproject.org Mon Oct 18 20:32:41 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Oct 2021 20:32:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.212542.370416 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcZJ2-0003aJ-IM; Mon, 18 Oct 2021 20:32:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 212542.370416; Mon, 18 Oct 2021 20:32:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcZJ2-0003aC-Eo; Mon, 18 Oct 2021 20:32:24 +0000
Received: by outflank-mailman (input) for mailman id 212542;
 Mon, 18 Oct 2021 20:32:23 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=6TaT=PG=infradead.org=mcgrof@srs-us1.protection.inumbo.net>)
 id 1mcZJ1-0003a6-DY
 for xen-devel@lists.xenproject.org; Mon, 18 Oct 2021 20:32:23 +0000
Received: from bombadil.infradead.org (unknown [2607:7c80:54:e::133])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 3158a153-5c1c-401e-a91f-c1dc55903999;
 Mon, 18 Oct 2021 20:32:20 +0000 (UTC)
Received: from mcgrof by bombadil.infradead.org with local (Exim 4.94.2 #2
 (Red Hat Linux)) id 1mcZIX-00HDlV-C4; Mon, 18 Oct 2021 20:31:53 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
X-Inumbo-ID: 3158a153-5c1c-401e-a91f-c1dc55903999
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type:
	MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To:
	Content-Transfer-Encoding:Content-ID:Content-Description;
	bh=OBMvbiCZ3mmK4xvpOD56mvuToBpo4s4ONuPdaMpMXso=; b=TIkzxO1O7vQd0T1PMQ31eP873s
	pPHNaKNwfjx7mTwD9RmpK0u2Dr52r7UfxNzSSDXj8Ur4f/57iSBP9syn65/BRLw+Qf0YqEROqC1+F
	/VG4vFcKrZ4lPNCkYzTKj7o2L7DwvWpMe/Cj9lb6MSKQzaI23JMePqdIEZskz+65OByIz865kTj2M
	S7C7JWy6K7A2w9h6miRNVROzQSV0cHn3nsz/ISMK8rBY/sbh7syYv+06of00RqsVQ7L8TnPZCsvnm
	bLR1p6dai2RCCksWMX0lknKUYeC/2U9k2JV7oYNMmdKjgqpOgr1yAHVsYweFfh4DDrfwCTLAV00Ez
	KwZhXR7g==;
Date: Mon, 18 Oct 2021 13:31:53 -0700
From: Luis Chamberlain <mcgrof@kernel.org>
To: "Martin K. Petersen" <martin.petersen@oracle.com>, axboe@kernel.dk
Cc: jejb@linux.ibm.com, agk@redhat.com, snitzer@redhat.com, colyli@suse.de,
	kent.overstreet@gmail.com, boris.ostrovsky@oracle.com,
	jgross@suse.com, sstabellini@kernel.org, roger.pau@citrix.com,
	geert@linux-m68k.org, ulf.hansson@linaro.org, tj@kernel.org,
	hare@suse.de, jdike@addtoit.com, richard@nod.at,
	anton.ivanov@cambridgegreys.com, johannes.berg@intel.com,
	krisman@collabora.com, chris.obbard@collabora.com,
	thehajime@gmail.com, zhuyifei1999@gmail.com, haris.iqbal@ionos.com,
	jinpu.wang@ionos.com, miquel.raynal@bootlin.com, vigneshr@ti.com,
	linux-mtd@lists.infradead.org, linux-scsi@vger.kernel.org,
	dm-devel@redhat.com, linux-bcache@vger.kernel.org,
	xen-devel@lists.xenproject.org, linux-m68k@lists.linux-m68k.org,
	linux-um@lists.infradead.org, linux-block@vger.kernel.org,
	linux-kernel@vger.kernel.org, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH 1/9] scsi/sd: add error handling support for add_disk()
Message-ID: <YW3ZuQv1qpIXkd5b@bombadil.infradead.org>
References: <20211015233028.2167651-1-mcgrof@kernel.org>
 <20211015233028.2167651-2-mcgrof@kernel.org>
 <yq1bl3ofjo5.fsf@ca-mkp.ca.oracle.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <yq1bl3ofjo5.fsf@ca-mkp.ca.oracle.com>
Sender: Luis Chamberlain <mcgrof@infradead.org>

On Sat, Oct 16, 2021 at 10:51:48PM -0400, Martin K. Petersen wrote:
> 
> Luis,
> 
> > We never checked for errors on add_disk() as this function returned
> > void. Now that this is fixed, use the shiny new error handling.
> >
> > As with the error handling for device_add() we follow the same logic
> > and just put the device so that cleanup is done via the
> > scsi_disk_release().
> 
> Acked-by: Martin K. Petersen <martin.petersen@oracle.com>

Thanks, would you like Jens to pick this up and the other scsi/sr patch
or are you taking it through your tree?

  Luis


From xen-devel-bounces@lists.xenproject.org Mon Oct 18 21:55:34 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Oct 2021 21:55:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.212555.370439 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcabJ-0003M9-Rg; Mon, 18 Oct 2021 21:55:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 212555.370439; Mon, 18 Oct 2021 21:55:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcabJ-0003M2-O4; Mon, 18 Oct 2021 21:55:21 +0000
Received: by outflank-mailman (input) for mailman id 212555;
 Mon, 18 Oct 2021 21:55:20 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mcabH-0003Ls-Uo; Mon, 18 Oct 2021 21:55:19 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mcabH-0006WF-Jt; Mon, 18 Oct 2021 21:55:19 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mcabH-0000dB-7X; Mon, 18 Oct 2021 21:55:19 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mcabH-00060m-6y; Mon, 18 Oct 2021 21:55:19 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=oMCmWnsSnG4cGULb2haAdRanSPJk56/3M+DAGRtI6Vk=; b=TXgPqtg4o4HHlTMJCIni1tydwm
	lLxPwUc0g1a8CWX2Z84gRYllxe2OlnW1FmDSg0w0zpPfb+uqE7QrHHTwfAK5PJRTqvqzeJIOO2nii
	JNhQo1UfNq4oW9+j31jDHUra/ZyGxjdHRfjqz8nSuaQtUfKtvzHcjOU4dwK2U1LAz6sY=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165636-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 165636: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-armhf-armhf-libvirt-raw:host-ping-check-xen:fail:heisenbug
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=519d81956ee277b4419c723adfb154603c2565ba
X-Osstest-Versions-That:
    linux=cf52ad5ff16c38a62a6536b5e7612b56794f5a5e
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 18 Oct 2021 21:55:19 +0000

flight 165636 linux-linus real [real]
flight 165643 linux-linus real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/165636/
http://logs.test-lab.xenproject.org/osstest/logs/165643/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-armhf-armhf-libvirt-raw 10 host-ping-check-xen fail pass in 165643-retest

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail in 165643 like 165632
 test-armhf-armhf-libvirt-raw 14 migrate-support-check fail in 165643 never pass
 test-amd64-amd64-xl-rtds     20 guest-localmigrate/x10       fail  like 165632
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 165632
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 165632
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165632
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165632
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 165632
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165632
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 165632
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 linux                519d81956ee277b4419c723adfb154603c2565ba
baseline version:
 linux                cf52ad5ff16c38a62a6536b5e7612b56794f5a5e

Last test of basis   165632  2021-10-18 03:40:46 Z    0 days
Testing same since   165636  2021-10-18 13:40:19 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Adam Manzanares <a.manzanares@samsung.com>
  Alex Deucher <alexander.deucher@amd.com>
  Ard Biesheuvel <ardb@kernel.org>
  Borislav Petkov <bp@suse.de>
  Christoph Hellwig <hch@lst.de>
  Cindy Lu <lulu@redhat.com>
  Cédric Le Goater <clg@kaod.org>
  Damien Le Moal <damien.lemoal@wdc.com>
  Dan Carpenter <dan.carpenter@oracle.com>
  Darrick J. Wong <djwong@kernel.org>
  Gioh Kim <gi-oh.kim@ionos.com>
  Grzegorz Kowal <custos.mentis@gmail.com>
  Halil Pasic <pasic@linux.ibm.com>
  Hans Potsch <hans.potsch@nokia.com>
  Hao Xu <haoxu@linux.alibaba.com>
  Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
  Jason Wang <jasowang@redhat.com>
  Jens Axboe <axboe@kernel.dk>
  Josh Poimboeuf <jpoimboe@redhat.com>
  Kan Liang <kan.liang@linux.intel.com>
  Keith Busch <kbusch@kernel.org>
  Linus Torvalds <torvalds@linux-foundation.org>
  Michael Ellerman <mpe@ellerman.id.au>
  Michael Forney <mforney@mforney.org>
  Michael S. Tsirkin <mst@redhat.com>
  Paolo Valente <paolo.valente@linaro.org>
  Peter Zijlstra (Intel) <peterz@infradead.org>
  Randy Dunlap <rdunlap@infradead.org>
  seeteena <s1seetee@linux.vnet.ibm.com>
  Ser Olmy <ser.olmy@protonmail.com>
  Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
  Tom Lendacky <thomas.lendacky@amd.com>
  Ville Syrjälä <ville.syrjala@linux.intel.com>
  Wang Hai <wanghai38@huawei.com>
  Wu Zongyong <wuzongyong@linux.alibaba.com>
  Yi Zhang <yi.zhang@redhat.com>
  Zhang Jianhua <chris.zjh@huawei.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 fail    
 test-amd64-amd64-xl-rtds                                     fail    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   cf52ad5ff16c..519d81956ee2  519d81956ee277b4419c723adfb154603c2565ba -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Mon Oct 18 23:25:53 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 18 Oct 2021 23:25:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.212569.370462 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcc0g-0003zz-Jb; Mon, 18 Oct 2021 23:25:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 212569.370462; Mon, 18 Oct 2021 23:25:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcc0g-0003zs-GT; Mon, 18 Oct 2021 23:25:38 +0000
Received: by outflank-mailman (input) for mailman id 212569;
 Mon, 18 Oct 2021 23:25:37 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=l/eG=PG=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1mcc0f-0003zm-6c
 for xen-devel@lists.xenproject.org; Mon, 18 Oct 2021 23:25:37 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id b2121ca2-306a-11ec-82ec-12813bfff9fa;
 Mon, 18 Oct 2021 23:25:35 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id 191C460F9D;
 Mon, 18 Oct 2021 23:25:35 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b2121ca2-306a-11ec-82ec-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1634599535;
	bh=hFE2XMKZEEaE0AdOIMQvOnc3ShElY8i3tLDTQ1Yuopg=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=k/Rrfxg3zYqRhHlyTdVxFNYK/s52dV93ICn1Ee9k50KveyLLbbujLkYaZn89CTlbL
	 AZivkgG9KhdmMhYusuHMP5fQlwS5jiWoTJue/uZTTLxRE8y7G93PEmv5XU+VXKOdWD
	 ZHsPSlGiSX+jGaO7WNUB+g3YMm2TvVYNcs2J0vL+qcCSpCahohUtdICyttJak5NZbo
	 CRXfJwe/HTsOUNy5LylWt9L2CrJzAR6gkIFf7pRyh7+TLwwU0i8e8gH54+MUdELdaU
	 B7mmPWNDKVh8haGxbyowjfwFfWrSYe3JC+5uFx3iGBzb91MJqmmG+Jm/Enh6coXTb+
	 rslSQl76X2VlQ==
Date: Mon, 18 Oct 2021 16:25:26 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Juergen Gross <jgross@suse.com>
cc: xen-devel@lists.xenproject.org, Ian Jackson <iwj@xenproject.org>, 
    Wei Liu <wl@xen.org>
Subject: Re: [PATCH v6 1/2] tools/xenstore: set oom score for xenstore daemon
 on Linux
In-Reply-To: <20211012134148.6280-2-jgross@suse.com>
Message-ID: <alpine.DEB.2.21.2110181616400.21467@sstabellini-ThinkPad-T480s>
References: <20211012134148.6280-1-jgross@suse.com> <20211012134148.6280-2-jgross@suse.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

Hi Juergen, Ian,

This patch broke gitlab-ci:

https://gitlab.com/xen-project/xen/-/jobs/1690080806

---
 * Executing: /lib/rc/sh/openrc-run.sh /lib/rc/sh/openrc-run.sh /etc/init.d/local start
 * Starting local ... *   Executing "/etc/local.d/xen.start" .../etc/xen/scripts/launch-xenstore: line 64: * 10: syntax error: operand expected (error token is "* 10")

illegal value daemon for XENSTORETYPE
---

See below about what the issue is and a potential fix.


On Tue, 12 Oct 2021, Juergen Gross wrote:
> Xenstored is absolutely mandatory for a Xen host and it can't be
> restarted, so being killed by OOM-killer in case of memory shortage is
> to be avoided.
> 
> Set /proc/$pid/oom_score_adj (if available) per default to -500 (this
> translates to 50% of dom0 memory size) in order to allow xenstored to
> use large amounts of memory without being killed.
> 
> The percentage of dom0 memory above which the oom killer is allowed to
> kill xenstored can be set via XENSTORED_OOM_MEM_THRESHOLD in
> xencommons.
> 
> Make sure the pid file isn't a left-over from a previous run delete it
> before starting xenstored.
> 
> Signed-off-by: Juergen Gross <jgross@suse.com>
> Reviewed-by: Ian Jackson <iwj@xenproject.org>
> ---
> V2:
> - set oom score from launch script (Julien Grall)
> - split off open file descriptor limit setting (Julien Grall)
> V3:
> - make oom killer threshold configurable (Julien Grall)
> V4:
> - extend comment (Ian Jackson)
> ---
>  tools/hotplug/Linux/init.d/sysconfig.xencommons.in | 9 +++++++++
>  tools/hotplug/Linux/launch-xenstore.in             | 6 ++++++
>  2 files changed, 15 insertions(+)
> 
> diff --git a/tools/hotplug/Linux/init.d/sysconfig.xencommons.in b/tools/hotplug/Linux/init.d/sysconfig.xencommons.in
> index 00cf7f91d4..b83101ab7e 100644
> --- a/tools/hotplug/Linux/init.d/sysconfig.xencommons.in
> +++ b/tools/hotplug/Linux/init.d/sysconfig.xencommons.in
> @@ -48,6 +48,15 @@ XENSTORED_ARGS=
>  # Only evaluated if XENSTORETYPE is "daemon".
>  #XENSTORED_TRACE=[yes|on|1]
>  
> +## Type: integer
> +## Default: 50
> +#
> +# Percentage of dom0 memory size the xenstore daemon can use before the
> +# OOM killer is allowed to kill it.
> +# The specified value is multiplied by -10 and echoed to
> +# /proc/PID/oom_score_adj.
> +#XENSTORED_OOM_MEM_THRESHOLD=50
> +
>  ## Type: string
>  ## Default: @LIBEXEC@/boot/xenstore-stubdom.gz
>  #
> diff --git a/tools/hotplug/Linux/launch-xenstore.in b/tools/hotplug/Linux/launch-xenstore.in
> index 019f9d6f4d..1747c96065 100644
> --- a/tools/hotplug/Linux/launch-xenstore.in
> +++ b/tools/hotplug/Linux/launch-xenstore.in
> @@ -59,11 +59,17 @@ test -f @CONFIG_DIR@/@CONFIG_LEAF_DIR@/xencommons && . @CONFIG_DIR@/@CONFIG_LEAF
>  		echo "No xenstored found"
>  		exit 1
>  	}
> +	[ -z "$XENSTORED_OOM_MEM_THRESHOLD" ] || XENSTORED_OOM_MEM_THRESHOLD=50
> +	XS_OOM_SCORE=-$(($XENSTORED_OOM_MEM_THRESHOLD * 10))

These are the problematic lines. They don't work with busybox's bash
implementation. Originally I thought it was an issue with busybox bash
implementation but it looks like they don't even work with normal bash.
Specifically the first line is an issue, it should be:

if [ -z "$XENSTORED_OOM_MEM_THRESHOLD" ]
then
    XENSTORED_OOM_MEM_THRESHOLD=50
fi

Right?


From xen-devel-bounces@lists.xenproject.org Tue Oct 19 00:43:05 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Oct 2021 00:43:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.212582.370488 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcdDO-00049s-EO; Tue, 19 Oct 2021 00:42:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 212582.370488; Tue, 19 Oct 2021 00:42:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcdDO-00049l-Aw; Tue, 19 Oct 2021 00:42:50 +0000
Received: by outflank-mailman (input) for mailman id 212582;
 Tue, 19 Oct 2021 00:42:49 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mcdDN-00049b-Rm; Tue, 19 Oct 2021 00:42:49 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mcdDN-0001Q4-IP; Tue, 19 Oct 2021 00:42:49 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mcdDN-0001Al-BO; Tue, 19 Oct 2021 00:42:49 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mcdDN-0005GE-At; Tue, 19 Oct 2021 00:42:49 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=a5Li1yhTsJtbFPmeFHPVX3b7gXAwI0/4DcZSibNwioU=; b=Ve9lsPAG4pnM1pTsKEYWyzdczz
	s8vsAl7dY9Hyx/07Ur6W27fVUMZsfzxtYAfTmvLR9BEIsAnZRifaCqFi9/PGW/ySfZrMp7AreGjni
	1QKvSkpRSA8AhnWIL5RY64ZX0y0TOgBQEoFBruvNOzXlXG0Z3PgGRGk/OZaVf8DtRsR4=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165642-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 165642: regressions - FAIL
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-xl-qemuu-debianhvm-amd64:leak-check/basis(11):fail:regression
    xen-unstable-smoke:test-amd64-amd64-libvirt:leak-check/basis(11):fail:regression
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:leak-check/basis(11):fail:regression
    xen-unstable-smoke:test-armhf-armhf-xl:leak-check/basis(11):fail:regression
X-Osstest-Versions-This:
    xen=3ae80dea4601764818d1e5b84bd1e4479c0d4790
X-Osstest-Versions-That:
    xen=c11b8d25fbe9c0155e91409594ea6701008409ed
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 19 Oct 2021 00:42:49 +0000

flight 165642 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165642/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-amd64-amd64-xl-qemuu-debianhvm-amd64 11 leak-check/basis(11) fail REGR. vs. 165635
 test-amd64-amd64-libvirt     11 leak-check/basis(11)     fail REGR. vs. 165635
 test-arm64-arm64-xl-xsm      11 leak-check/basis(11)     fail REGR. vs. 165635
 test-armhf-armhf-xl          11 leak-check/basis(11)     fail REGR. vs. 165635

version targeted for testing:
 xen                  3ae80dea4601764818d1e5b84bd1e4479c0d4790
baseline version:
 xen                  c11b8d25fbe9c0155e91409594ea6701008409ed

Last test of basis   165635  2021-10-18 13:00:26 Z    0 days
Testing same since   165638  2021-10-18 16:01:36 Z    0 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
  Ian Jackson <iwj@xenproject.org>
  Juergen Gross <jgross@suse.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          fail    
 test-arm64-arm64-xl-xsm                                      fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    fail    
 test-amd64-amd64-libvirt                                     fail    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

------------------------------------------------------------
commit 3ae80dea4601764818d1e5b84bd1e4479c0d4790
Author: Juergen Gross <jgross@suse.com>
Date:   Fri Sep 10 07:55:17 2021 +0200

    stubdom: disable building pv-grub
    
    The stubdom based pv-grub is using a very outdated version of grub
    (0.97) and should not be used any longer. Mainline grub has support for
    PV guests for a long time now, so that should be used as a boot loader
    of a PV domain.
    
    So disable building pv-grub per default. In case someone really wants
    to continue using it he/she can still use a pv-grub binary from an older
    Xen version or manually enable building it via:
    
      configure --enable-pv-grub
    
    [ This was already disabled in osstest by 8dee6e333622
      "make-flight: Drop pvgrub (pvgrub1) tests" -iwj ]
    
    Signed-off-by: Juergen Gross <jgross@suse.com>
    Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
    Acked-by: Ian Jackson <iwj@xenproject.org>
    Release-Acked-by: Ian Jackson <iwj@xenproject.org>

commit 9cfeb83cbe23a873de512211d7ecd989348b9df0
Author: Juergen Gross <jgross@suse.com>
Date:   Tue Oct 12 15:41:48 2021 +0200

    tools/xenstore: set open file descriptor limit for xenstored
    
    Add a configuration item for the maximum number of open file
    descriptors xenstored should be allowed to have.
    
    The default should be "unlimited" in order not to restrict xenstored
    in the number of domains it can support, but unfortunately the kernel
    is normally limiting the maximum value via /proc/sys/fs/nr_open [1],
    [2]. So check that file to exist and if it does, limit the maximum
    value to the one specified by /proc/sys/fs/nr_open.
    
    As an aid for the admin configuring the value add a comment specifying
    the common needs of xenstored for the different domain types.
    
    [1]: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=60fd760fb9ff7034360bab7137c917c0330628c2
    [2]: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=0c2d64fb6cae9aae480f6a46cfe79f8d7d48b59f
    
    Signed-off-by: Juergen Gross <jgross@suse.com>
    Reviewed-by: Ian Jackson <iwj@xenproject.org>
    Release-Acked-by: Ian Jackson <iwj@xenproject.org>

commit f282182af32939107d47943aba242d3189ec6f90
Author: Juergen Gross <jgross@suse.com>
Date:   Tue Oct 12 15:41:47 2021 +0200

    tools/xenstore: set oom score for xenstore daemon on Linux
    
    Xenstored is absolutely mandatory for a Xen host and it can't be
    restarted, so being killed by OOM-killer in case of memory shortage is
    to be avoided.
    
    Set /proc/$pid/oom_score_adj (if available) per default to -500 (this
    translates to 50% of dom0 memory size) in order to allow xenstored to
    use large amounts of memory without being killed.
    
    The percentage of dom0 memory above which the oom killer is allowed to
    kill xenstored can be set via XENSTORED_OOM_MEM_THRESHOLD in
    xencommons.
    
    Make sure the pid file isn't a left-over from a previous run delete it
    before starting xenstored.
    
    Signed-off-by: Juergen Gross <jgross@suse.com>
    Reviewed-by: Ian Jackson <iwj@xenproject.org>
    Release-Acked-by: Ian Jackson <iwj@xenproject.org>
(qemu changes not included)


From xen-devel-bounces@lists.xenproject.org Tue Oct 19 02:24:33 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Oct 2021 02:24:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.212598.370525 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcene-0008Ba-0D; Tue, 19 Oct 2021 02:24:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 212598.370525; Tue, 19 Oct 2021 02:24:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcend-0008BT-Sp; Tue, 19 Oct 2021 02:24:21 +0000
Received: by outflank-mailman (input) for mailman id 212598;
 Tue, 19 Oct 2021 02:24:20 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mcenc-0008BJ-EU; Tue, 19 Oct 2021 02:24:20 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mcenc-000553-7X; Tue, 19 Oct 2021 02:24:20 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mcenb-0004dP-Ti; Tue, 19 Oct 2021 02:24:20 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mcenb-00017H-TE; Tue, 19 Oct 2021 02:24:19 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=b6XG7+oF+BH3hvAw841bdDqPPY+Sy9AXbZNTusYEPlo=; b=hr0U/9jqi/gnu5/8HYBTMu3LG1
	axRvY578Ov2wRvhsaq9D13KDj1GzuYEQBOc0TPfgwdQ+xiDojC+ml+oGyzP0hUvGfqoQ4spiJJ4aq
	qytr56keZSXm8vBMxc3ZU7GgnF5e2a7mG1ywKYDfKNQmZ0G1ZmduUP13TjaiO5ddjaGw=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165639-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 165639: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=c11b8d25fbe9c0155e91409594ea6701008409ed
X-Osstest-Versions-That:
    xen=52d0847d7c6972baa74156f14ee8544f5aba1d2d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 19 Oct 2021 02:24:19 +0000

flight 165639 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165639/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 165631
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 165631
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165631
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165631
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 165631
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 165631
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 165631
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 165631
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 165631
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 165631
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165631
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 165631
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  c11b8d25fbe9c0155e91409594ea6701008409ed
baseline version:
 xen                  52d0847d7c6972baa74156f14ee8544f5aba1d2d

Last test of basis   165631  2021-10-18 01:52:55 Z    1 days
Testing same since   165639  2021-10-18 16:06:43 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Jan Beulich <jbeulich@suse.com>
  Roger Pau Monné <roger.pau@citrix.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   52d0847d7c..c11b8d25fb  c11b8d25fbe9c0155e91409594ea6701008409ed -> master


From xen-devel-bounces@lists.xenproject.org Tue Oct 19 02:53:29 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Oct 2021 02:53:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.212611.370546 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcfFi-0003DK-EK; Tue, 19 Oct 2021 02:53:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 212611.370546; Tue, 19 Oct 2021 02:53:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcfFi-0003DD-AM; Tue, 19 Oct 2021 02:53:22 +0000
Received: by outflank-mailman (input) for mailman id 212611;
 Tue, 19 Oct 2021 02:53:20 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=18+q=PH=oracle.com=martin.petersen@srs-us1.protection.inumbo.net>)
 id 1mcfFg-0003D7-6G
 for xen-devel@lists.xenproject.org; Tue, 19 Oct 2021 02:53:20 +0000
Received: from mx0a-00069f02.pphosted.com (unknown [205.220.165.32])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id b6b6e944-3087-11ec-82f4-12813bfff9fa;
 Tue, 19 Oct 2021 02:53:19 +0000 (UTC)
Received: from pps.filterd (m0246617.ppops.net [127.0.0.1])
 by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 19J2SWJl007657; 
 Tue, 19 Oct 2021 02:52:51 GMT
Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80])
 by mx0b-00069f02.pphosted.com with ESMTP id 3brnmf7xwy-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Tue, 19 Oct 2021 02:52:51 +0000
Received: from pps.filterd (userp3030.oracle.com [127.0.0.1])
 by userp3030.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 19J2VUj8014130;
 Tue, 19 Oct 2021 02:52:50 GMT
Received: from nam12-dm6-obe.outbound.protection.outlook.com
 (mail-dm6nam12lp2172.outbound.protection.outlook.com [104.47.59.172])
 by userp3030.oracle.com with ESMTP id 3bqkuwgp15-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Tue, 19 Oct 2021 02:52:50 +0000
Received: from PH0PR10MB4759.namprd10.prod.outlook.com (2603:10b6:510:3d::12)
 by PH0PR10MB5612.namprd10.prod.outlook.com (2603:10b6:510:fa::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16; Tue, 19 Oct
 2021 02:52:47 +0000
Received: from PH0PR10MB4759.namprd10.prod.outlook.com
 ([fe80::a457:48f2:991f:c349]) by PH0PR10MB4759.namprd10.prod.outlook.com
 ([fe80::a457:48f2:991f:c349%9]) with mapi id 15.20.4608.018; Tue, 19 Oct 2021
 02:52:47 +0000
Received: from ca-mkp.ca.oracle.com (138.3.201.18) by
 BL0PR02CA0117.namprd02.prod.outlook.com (2603:10b6:208:35::22) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.15 via Frontend Transport; Tue, 19 Oct 2021 02:52:47 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b6b6e944-3087-11ec-82f4-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject :
 from : message-id : references : date : in-reply-to : content-type :
 mime-version; s=corp-2021-07-09;
 bh=q5WscohXE6hl8xO2BiSNQnKNBIB9w5cD1KUepAFbGZE=;
 b=br9u4Yj1dcDMmWH+RoAkRen6gBNlmYDqlew+XZYZak/J0Zl/dHuDFDAyxmpqqSwSVW2q
 y6cudBsQB9trwfuZXeQcqMemsyY8UOV11uUFOpqgkvHCmb9/Qv+xB7W6ZJSggvel+zLV
 zZKp0tiZSe3TR4kYwAh6jqcZSu/jQMuaUjsW5vE9VOjpKs4SXdQ0wU0m0z4JOMSgc5R/
 XQCBGT/prsTo4odw0GbOyeELK9ilJl12UAoqcG8oFkDCv8/AVSmJirrQUNsSgzq2c/sB
 AF4cKsH55BQ0WNS1Wxlzj0oMl2Upk3BMFh4ujGFzjZypU5+C0xfq+ih6zl/nvG4sUoIR 7A== 
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=QL3Zc4b0LrsA3lsa/QKS9tojFOP0PoKtErWETowpu9GSGGpo1Xx1LEIYWoOBhROffgpkb+x7yJIN5vkkKHo6z7C9BNTAG/Fx/qAhFqvOJN7RjF9Z+1CLmhw4nWX0At3dJ87CNzb60h1s3X2IglfPxySAJULP1RpBUVaTPudL4rQMbMKKsFmrZEqA4RZ1dXrfTCxAhKZk/q28hHLH7NF0EjoQ/L0Ke1TBSEC5UCeUgRr8LWm4WUo9vaYt2BG1P3fSI6g9MAm7Vjq9T/d0RhAzes31onbZ3rV3lBFH+SpFu2JZ7jJUV7AYKOca5XPyGeD4+bDayxbd0sef22Vz56iDWw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=q5WscohXE6hl8xO2BiSNQnKNBIB9w5cD1KUepAFbGZE=;
 b=kkcnryQmJbx/DALsNBsBRN1f/dW6eHjjhUYUeV0akFirkrEHUA4puWZEa/LaYw5yFVv24ULNZdFiZjluvC4dCGN+7U88KLbxrKz/3UEiR0XCUMUbiBkClqom71X1dOvxYI+uAKTcXbmX5OkmpkfyIB4Lo6pQZxqRDJhbplod1teP9ATcZy/wXcRsyJIIHBMVed+TMnv655ko8oYuRFo4pOK0EIjAcNJB3ktnLuwHz+1VdSwM7reuwcqNXKW5lpbWGYBK6yQ1YGa6hRzspzA83gplP7EKa6G7//PHyDI1n9tEHZPPmoCd2eNGWcPXrBL8fif/2OjHizfy38c+yuWq1A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com;
 dkim=pass header.d=oracle.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=q5WscohXE6hl8xO2BiSNQnKNBIB9w5cD1KUepAFbGZE=;
 b=IugBsrfwGeUU/5+qjE5ynmMmg8pSs6mwMMSALUkwAXMNWg9YOJ4CCCfLdrqky9xgS0WJjVFKIakrKqibenIMko+RUNzU6odQMxB5dD5hX16wNiF+qTpRELZSDKQuidcO9ytfU9gWSBGOcgP8JdhXKoiliam7MVfZrG1Cui1mrGo=
Authentication-Results: kernel.org; dkim=none (message not signed)
 header.d=none;kernel.org; dmarc=none action=none header.from=oracle.com;
To: Luis Chamberlain <mcgrof@kernel.org>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>, axboe@kernel.dk,
        jejb@linux.ibm.com, agk@redhat.com, snitzer@redhat.com, colyli@suse.de,
        kent.overstreet@gmail.com, boris.ostrovsky@oracle.com, jgross@suse.com,
        sstabellini@kernel.org, roger.pau@citrix.com, geert@linux-m68k.org,
        ulf.hansson@linaro.org, tj@kernel.org, hare@suse.de, jdike@addtoit.com,
        richard@nod.at, anton.ivanov@cambridgegreys.com,
        johannes.berg@intel.com, krisman@collabora.com,
        chris.obbard@collabora.com, thehajime@gmail.com,
        zhuyifei1999@gmail.com, haris.iqbal@ionos.com, jinpu.wang@ionos.com,
        miquel.raynal@bootlin.com, vigneshr@ti.com,
        linux-mtd@lists.infradead.org, linux-scsi@vger.kernel.org,
        dm-devel@redhat.com, linux-bcache@vger.kernel.org,
        xen-devel@lists.xenproject.org, linux-m68k@lists.linux-m68k.org,
        linux-um@lists.infradead.org, linux-block@vger.kernel.org,
        linux-kernel@vger.kernel.org, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH 1/9] scsi/sd: add error handling support for add_disk()
From: "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq1pms1d8w4.fsf@ca-mkp.ca.oracle.com>
References: <20211015233028.2167651-1-mcgrof@kernel.org>
	<20211015233028.2167651-2-mcgrof@kernel.org>
	<yq1bl3ofjo5.fsf@ca-mkp.ca.oracle.com>
	<YW3ZuQv1qpIXkd5b@bombadil.infradead.org>
Date: Mon, 18 Oct 2021 22:52:44 -0400
In-Reply-To: <YW3ZuQv1qpIXkd5b@bombadil.infradead.org> (Luis Chamberlain's
	message of "Mon, 18 Oct 2021 13:31:53 -0700")
Content-Type: text/plain
X-ClientProxiedBy: BL0PR02CA0117.namprd02.prod.outlook.com
 (2603:10b6:208:35::22) To PH0PR10MB4759.namprd10.prod.outlook.com
 (2603:10b6:510:3d::12)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: f71b47af-e5d2-4a46-cf55-08d992ab8837
X-MS-TrafficTypeDiagnostic: PH0PR10MB5612:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: 
	<PH0PR10MB5612CBB25690C25EED7375268EBD9@PH0PR10MB5612.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7219;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 
	jGRqMuGIFJtch3sQkmWNIo3DxaSILxOgnlM6Yyr2SchOySNj8nd2dFjZeggnQrQHnf0pJTUT/ocWogUWcOcA4QXGGPCO3d3fnVvljJLK1gcuYugYQiQmpUF8gqYhyaOBJ5q3PMa5L0aNAjQ8A6UM1cytzeEK91RBVo4Lezz/KDiq9Y/nL6b8BF335UGkR6okyTJ8lxJJ5tAeYK29z4Akz6h0MWBETdXf8YUQ8zp97wk9fpQhb6x0mOoxMitCDiiuMnBvtbdFz1Zwjl3IpCMM3A/37OMVxqtyQZ+vZ/IaiAmcf7hSq41yfaswC1WkTSp5LNhaRc4rKYCU3MFaKqjwtphIYR8UPTHDjTDV0jr3xr+9F8OTWK13cvQtCRs9QItpJnbcZ/c2aqmTZe0tgeGe6d2Ky3/Lz3qNfmTLP/gaWzSZMcD7LSNlyreE9XibY65mtsWnwErdvICIPMiNZCcIODLa2bh/KsEC46hnHwazOSdGPg70JW3CMNLnYnG/sgAlTknfCp9kHKjn07jvqVLWiIHldwVKzL3fOzNdjPScVtOEo1HBH2oV59zMJakyVyfit54YaTpDwntYdO0MnslQiSGhOmLBe/JywHT9mFL5nxEWAzATsXFCgUMH2olk61DCAQ+L0SbLkWVaODezLLDPgf4npsnKRElr9/9Fur5tzsXH0UE58ao/mGzxY/IbjevFnmtc7pXnMN3TGhT8c5xr5w==
X-Forefront-Antispam-Report: 
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR10MB4759.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(6666004)(7406005)(4326008)(7416002)(558084003)(8936002)(956004)(6916009)(316002)(2906002)(7696005)(86362001)(26005)(38350700002)(38100700002)(54906003)(186003)(55016002)(8676002)(66556008)(66476007)(66946007)(5660300002)(36916002)(52116002)(508600001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?meZ11y0UqDFMVR8LwY48iHN+B2ZAJ2DS7unaUAOmJQU7p1kC0uyKI0gpGOCz?=
 =?us-ascii?Q?gsgck0SSO1gEbziQu1uWrl+Himk4wJGBH1OY5hPheMyjTgbcoiSwKIGoK58Q?=
 =?us-ascii?Q?x4Bv0cLGCehVSC+FPwGO/sQZhb3mArHLehb88qPj57a4uk77Wu5MUI6UOM0F?=
 =?us-ascii?Q?0O7P6FALq9Wp9spgA6Nf4BzthgZsQKy1YTY1Q6b3UQqimzDL64HCKL6AvAgI?=
 =?us-ascii?Q?6eVQxKFxCTXIo/DTUPICOdRi9Tx3XVbBj+OeteYg/WwZJS8PN0Rs3Da8kluO?=
 =?us-ascii?Q?4tgJJcW8fSsHbf4nlAgsD0C696KyfwXD1uKEIs++OmQTWohWQ0kKqnwtjXnt?=
 =?us-ascii?Q?N4XFQZ1lIz2ICesiP0tu/vAxBDRm9cQzx+IDvWzUbozEyZnFVVMPAl4DPAOc?=
 =?us-ascii?Q?oqH4LFRf5T6HvrJ5Iw11Ra+Y1s299n7SG8HMBRUOPy8Q07KvKwWiNmiq+9hR?=
 =?us-ascii?Q?Sdcy1uURx6A1AHnMX7mGvmFMzyPok+M+SJFXNZ6DZ+aM8AgBETwXp+/9KZis?=
 =?us-ascii?Q?NqfkW+rbNXztE9MSFsVZXXpvcxOcs6RPhqhN2soaW4FpkKde4RXxNbRVp30T?=
 =?us-ascii?Q?pWlreM7OGFjoWA0LvBuhsqbB9m7D3QQ1FddMY+QbVXGIaUP+AdPfRfmbBVEl?=
 =?us-ascii?Q?yOWq6iWvEk2vY2/zCYERhU7jeHFHoo6LKlCj+vWWr+TM0yTvYlip/UIMz4ND?=
 =?us-ascii?Q?+OR7uwDPTTidJLmDMZd3+MJf+QHKL3IeYG80KLmdmixaaZUF6Xyg62Al3Dql?=
 =?us-ascii?Q?xCflg7F087vsKPR/C889V5dOBDhbA9NKie3gyMjdXA72rJ9xtIjNBiEP9KlZ?=
 =?us-ascii?Q?QwxL/xXzxokdkA4f0C0yyJtN9XpxnHM2zeRuUbNecKIbP+S4A6WQmZ+quRuZ?=
 =?us-ascii?Q?0qz41NwM+aOvEduibJ8N74tbbKYRvRpvi1cIA1GD/LOL3bcIg45du1F1TnL8?=
 =?us-ascii?Q?SRGkAEhM48ZgaSWxbGQ/1hOQRXBtHvVF5oUpFCV5C8wMiH2uXx4kSVKllMdK?=
 =?us-ascii?Q?geoX2J9XkEkkJeHyyvU+hDP51lRTtLuE7nc2WdGn/4mqQ6bC1MJPB6uILkpi?=
 =?us-ascii?Q?kNSAvUFkprFOlioF134mXjvjEE8+tHxYjwi8WXig9QCAZJZQmcFp04tBhC6z?=
 =?us-ascii?Q?zx1QbiUN7GphDTDan1y9GrPioq4KJn7u6v6Z660EZfYqv0X2m3pGIJSiI4W5?=
 =?us-ascii?Q?P/Jn9yK41w+maH1Aab+AbY6URwpqQZXJEbTEHP4/DNN8u3413jzEXsLlOL2i?=
 =?us-ascii?Q?/dCFFzl0tenq7PK/3GMPK83gHPWsvRGAcxvcBBahfbks7TmgtnYueW0N1Htq?=
 =?us-ascii?Q?hbVqXAGYSkZLXKtP6Jl1ehtN?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f71b47af-e5d2-4a46-cf55-08d992ab8837
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2021 02:52:47.5144
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: hxwuuPShKyKXOVCuyR2GEPaEFztujWky8m0/kKzFB0dIBmxOllLsoIqtc8AkZQ5sw3Tbo/+nRP1sD53gpaCIctKMLHtP0WEm8WEs0NXOia4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB5612
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10141 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 suspectscore=0
 malwarescore=0 bulkscore=0 phishscore=0 adultscore=0 spamscore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2109230001 definitions=main-2110190013
X-Proofpoint-GUID: iauxcMEjFutpKRN5OBYZcn6MHISXq-QI
X-Proofpoint-ORIG-GUID: iauxcMEjFutpKRN5OBYZcn6MHISXq-QI


Luis,

> Thanks, would you like Jens to pick this up and the other scsi/sr patch
> or are you taking it through your tree?

Didn't think I had the relevant add_disk() patch in my baseline tree but
it turns out I do. So I queued them up.

Thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering


From xen-devel-bounces@lists.xenproject.org Tue Oct 19 03:37:38 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Oct 2021 03:37:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.212619.370557 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcfwL-0007bO-J9; Tue, 19 Oct 2021 03:37:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 212619.370557; Tue, 19 Oct 2021 03:37:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcfwL-0007bH-G9; Tue, 19 Oct 2021 03:37:25 +0000
Received: by outflank-mailman (input) for mailman id 212619;
 Tue, 19 Oct 2021 03:37:24 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mcfwK-0007b7-A5; Tue, 19 Oct 2021 03:37:24 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mcfwK-0006Nw-2j; Tue, 19 Oct 2021 03:37:24 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mcfwJ-00073X-HJ; Tue, 19 Oct 2021 03:37:23 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mcfwJ-0002oG-GW; Tue, 19 Oct 2021 03:37:23 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=ABGxX1NGrgz4eJjOeSuojW/J1tjWdGVqX6glsuy02qE=; b=hBfBNAoP8X7bS3dAUqc+gSIA5k
	K3x1aVu2wpmBBn8Gr3IdSB9Ra5taFl82Arce0oNtKDaXhml4uZR4L82QRjMnkEDEtGTjgPMkIkgYd
	iuJDFIisOwQxWnn8DYWvxFZ31C1mQmt6BJ2VCYQ9ubgR/GGg9/RXXO1J01+3+6BkQ/pY=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165652-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 165652: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=36b561623a4b8a6c7fea0b1b01f6789f2adf97e0
X-Osstest-Versions-That:
    ovmf=210869834639c1150b1f016e2022472a55cdd884
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 19 Oct 2021 03:37:23 +0000

flight 165652 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165652/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 36b561623a4b8a6c7fea0b1b01f6789f2adf97e0
baseline version:
 ovmf                 210869834639c1150b1f016e2022472a55cdd884

Last test of basis   165637  2021-10-18 13:41:07 Z    0 days
Testing same since   165652  2021-10-19 01:40:11 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Brijesh Singh <brijesh.singh@amd.com>
  Dov Murik <dovmurik@linux.ibm.com>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   2108698346..36b561623a  36b561623a4b8a6c7fea0b1b01f6789f2adf97e0 -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Tue Oct 19 04:23:28 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Oct 2021 04:23:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.212630.370577 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcgen-0004Vc-6P; Tue, 19 Oct 2021 04:23:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 212630.370577; Tue, 19 Oct 2021 04:23:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcgen-0004VV-3O; Tue, 19 Oct 2021 04:23:21 +0000
Received: by outflank-mailman (input) for mailman id 212630;
 Tue, 19 Oct 2021 04:23:20 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=d5uN=PH=suse.com=jgross@srs-us1.protection.inumbo.net>)
 id 1mcgem-0004VP-9D
 for xen-devel@lists.xenproject.org; Tue, 19 Oct 2021 04:23:20 +0000
Received: from smtp-out2.suse.de (unknown [195.135.220.29])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id d95b2a69-753f-4ece-9e7a-7ea4b3e992a0;
 Tue, 19 Oct 2021 04:23:18 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 974751FD80;
 Tue, 19 Oct 2021 04:23:17 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 414F913B04;
 Tue, 19 Oct 2021 04:23:17 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id BS4bDTVIbmGwLQAAMHmgww
 (envelope-from <jgross@suse.com>); Tue, 19 Oct 2021 04:23:17 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d95b2a69-753f-4ece-9e7a-7ea4b3e992a0
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1634617397; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=BqX/MKOaaO0VfUDWbPZmr6y2ERUMFmkmrpwGes6xJsM=;
	b=P3LDIG5wfh8HSjjF4yUSJaP/n1u/iL/36NQptL50hj1nHjqppGNedasIOQtxkvxee7Lyzo
	ZlKBf35iR4dLcCkwDLA0fAjOp6TXusVFwdB2ZYR/6UeS7c5dkUSb3YiKLlpt43/ExqLPHN
	ES/YPEXiEL3btPPFfM/+TOa/Raj6HhQ=
Subject: Re: [PATCH v6 1/2] tools/xenstore: set oom score for xenstore daemon
 on Linux
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: xen-devel@lists.xenproject.org, Ian Jackson <iwj@xenproject.org>,
 Wei Liu <wl@xen.org>
References: <20211012134148.6280-1-jgross@suse.com>
 <20211012134148.6280-2-jgross@suse.com>
 <alpine.DEB.2.21.2110181616400.21467@sstabellini-ThinkPad-T480s>
From: Juergen Gross <jgross@suse.com>
Message-ID: <01adb8a7-a4be-2171-ae4c-5dca24ce5838@suse.com>
Date: Tue, 19 Oct 2021 06:23:16 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.21.2110181616400.21467@sstabellini-ThinkPad-T480s>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="o189TqNcO0FCvgbw7MqsEXYwjfsaCPIb5"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--o189TqNcO0FCvgbw7MqsEXYwjfsaCPIb5
Content-Type: multipart/mixed; boundary="lMmq8dDo5d4KI9ry2id77zwb4lu23icPJ";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: xen-devel@lists.xenproject.org, Ian Jackson <iwj@xenproject.org>,
 Wei Liu <wl@xen.org>
Message-ID: <01adb8a7-a4be-2171-ae4c-5dca24ce5838@suse.com>
Subject: Re: [PATCH v6 1/2] tools/xenstore: set oom score for xenstore daemon
 on Linux
References: <20211012134148.6280-1-jgross@suse.com>
 <20211012134148.6280-2-jgross@suse.com>
 <alpine.DEB.2.21.2110181616400.21467@sstabellini-ThinkPad-T480s>
In-Reply-To: <alpine.DEB.2.21.2110181616400.21467@sstabellini-ThinkPad-T480s>

--lMmq8dDo5d4KI9ry2id77zwb4lu23icPJ
Content-Type: multipart/mixed;
 boundary="------------14EFCDDF60A833E78D18823C"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------14EFCDDF60A833E78D18823C
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 19.10.21 01:25, Stefano Stabellini wrote:
> Hi Juergen, Ian,
>=20
> This patch broke gitlab-ci:
>=20
> https://gitlab.com/xen-project/xen/-/jobs/1690080806
>=20
> ---
>   * Executing: /lib/rc/sh/openrc-run.sh /lib/rc/sh/openrc-run.sh /etc/i=
nit.d/local start
>   * Starting local ... *   Executing "/etc/local.d/xen.start" .../etc/x=
en/scripts/launch-xenstore: line 64: * 10: syntax error: operand expected=
 (error token is "* 10")
>=20
> illegal value daemon for XENSTORETYPE
> ---
>=20
> See below about what the issue is and a potential fix.
>=20
>=20
> On Tue, 12 Oct 2021, Juergen Gross wrote:
>> Xenstored is absolutely mandatory for a Xen host and it can't be
>> restarted, so being killed by OOM-killer in case of memory shortage is=

>> to be avoided.
>>
>> Set /proc/$pid/oom_score_adj (if available) per default to -500 (this
>> translates to 50% of dom0 memory size) in order to allow xenstored to
>> use large amounts of memory without being killed.
>>
>> The percentage of dom0 memory above which the oom killer is allowed to=

>> kill xenstored can be set via XENSTORED_OOM_MEM_THRESHOLD in
>> xencommons.
>>
>> Make sure the pid file isn't a left-over from a previous run delete it=

>> before starting xenstored.
>>
>> Signed-off-by: Juergen Gross <jgross@suse.com>
>> Reviewed-by: Ian Jackson <iwj@xenproject.org>
>> ---
>> V2:
>> - set oom score from launch script (Julien Grall)
>> - split off open file descriptor limit setting (Julien Grall)
>> V3:
>> - make oom killer threshold configurable (Julien Grall)
>> V4:
>> - extend comment (Ian Jackson)
>> ---
>>   tools/hotplug/Linux/init.d/sysconfig.xencommons.in | 9 +++++++++
>>   tools/hotplug/Linux/launch-xenstore.in             | 6 ++++++
>>   2 files changed, 15 insertions(+)
>>
>> diff --git a/tools/hotplug/Linux/init.d/sysconfig.xencommons.in b/tool=
s/hotplug/Linux/init.d/sysconfig.xencommons.in
>> index 00cf7f91d4..b83101ab7e 100644
>> --- a/tools/hotplug/Linux/init.d/sysconfig.xencommons.in
>> +++ b/tools/hotplug/Linux/init.d/sysconfig.xencommons.in
>> @@ -48,6 +48,15 @@ XENSTORED_ARGS=3D
>>   # Only evaluated if XENSTORETYPE is "daemon".
>>   #XENSTORED_TRACE=3D[yes|on|1]
>>  =20
>> +## Type: integer
>> +## Default: 50
>> +#
>> +# Percentage of dom0 memory size the xenstore daemon can use before t=
he
>> +# OOM killer is allowed to kill it.
>> +# The specified value is multiplied by -10 and echoed to
>> +# /proc/PID/oom_score_adj.
>> +#XENSTORED_OOM_MEM_THRESHOLD=3D50
>> +
>>   ## Type: string
>>   ## Default: @LIBEXEC@/boot/xenstore-stubdom.gz
>>   #
>> diff --git a/tools/hotplug/Linux/launch-xenstore.in b/tools/hotplug/Li=
nux/launch-xenstore.in
>> index 019f9d6f4d..1747c96065 100644
>> --- a/tools/hotplug/Linux/launch-xenstore.in
>> +++ b/tools/hotplug/Linux/launch-xenstore.in
>> @@ -59,11 +59,17 @@ test -f @CONFIG_DIR@/@CONFIG_LEAF_DIR@/xencommons =
&& . @CONFIG_DIR@/@CONFIG_LEAF
>>   		echo "No xenstored found"
>>   		exit 1
>>   	}
>> +	[ -z "$XENSTORED_OOM_MEM_THRESHOLD" ] || XENSTORED_OOM_MEM_THRESHOLD=
=3D50
>> +	XS_OOM_SCORE=3D-$(($XENSTORED_OOM_MEM_THRESHOLD * 10))
>=20
> These are the problematic lines. They don't work with busybox's bash
> implementation. Originally I thought it was an issue with busybox bash
> implementation but it looks like they don't even work with normal bash.=

> Specifically the first line is an issue, it should be:
>=20
> if [ -z "$XENSTORED_OOM_MEM_THRESHOLD" ]
> then
>      XENSTORED_OOM_MEM_THRESHOLD=3D50
> fi
>=20
> Right?
>=20

Oh, shame on me. Turned out that I had XENSTORED_OOM_MEM_THRESHOLD
set explicitly in my xencommons file. :-(

Patch is coming...


Juergen

Patch is coming.

--------------14EFCDDF60A833E78D18823C
Content-Type: application/pgp-keys;
 name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Transfer-Encoding: quoted-printable
Content-Description: OpenPGP public key
Content-Disposition: attachment;
 filename="OpenPGP_0xB0DE9DD628BF132F.asc"

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy=
cWx
w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O=
f8Z
d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y=
9bf
IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq=
G7/
377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR=
3Jv
c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA=
QIe
AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT=
hpw
dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0=
MbD
1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv=
oPH
Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v=
5QL
+qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ=
2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC=
QoL
BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr=
Wf0
teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC=
/nu
AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh=
ITT
d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm=
XBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz=
80h
SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC=
AcD
AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn=
FOX
gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1=
jnD
kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0=
N51
N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l=
otu
fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1=
tqS
EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA=
hsD
BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3=
g3O
ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5=
dM7
wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5=
D+j
LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm=
V2x
AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N=
Eaw
QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW=
nHI
s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR=
wgn
BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV=
bVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk=
pEd
IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA=
QAB
wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw=
Tbe
8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1=
vJz
Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8=
VGi
wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW=
svi
uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX=
zXs
ZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------14EFCDDF60A833E78D18823C--

--lMmq8dDo5d4KI9ry2id77zwb4lu23icPJ--

--o189TqNcO0FCvgbw7MqsEXYwjfsaCPIb5
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmFuSDQFAwAAAAAACgkQsN6d1ii/Ey+5
Ygf/dSqqDrKZgfod7Dv0gmb8sAie09qfQIBZN5SAYQqJub7e0oVjZ+46jGxWobUnrxS4VZlsuUQ3
dB8uTbbsUUGfvq1ngYUSc0A2BOfVd4WFQgrNe60k58Jl/0OD0TFUQVLNAJ0aUksl/Qu3vG9mr1cP
QtkraXSVzpA5vVmfaT8nc1Q5pskv97UEN+SuBJqbaJuon65an4TR6WVc1UUONog8Ny0Fw7QTRzMX
ik+tLZGCqxuU+AcKQlSDrjCa3PHZpgLS8MRnLee0R7Ky/pkvkJK9GMhi3PTX2USW7T3+dV/Z0og1
c6Bm5Pv1Yi5uHgiqcdeB6mbNltsf/nTK+uX6giXdIQ==
=RZ6o
-----END PGP SIGNATURE-----

--o189TqNcO0FCvgbw7MqsEXYwjfsaCPIb5--


From xen-devel-bounces@lists.xenproject.org Tue Oct 19 04:41:43 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Oct 2021 04:41:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.212639.370591 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcgwK-00077k-OJ; Tue, 19 Oct 2021 04:41:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 212639.370591; Tue, 19 Oct 2021 04:41:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcgwK-00077d-LN; Tue, 19 Oct 2021 04:41:28 +0000
Received: by outflank-mailman (input) for mailman id 212639;
 Tue, 19 Oct 2021 04:41:27 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=d5uN=PH=suse.com=jgross@srs-us1.protection.inumbo.net>)
 id 1mcgwJ-00077X-Ei
 for xen-devel@lists.xenproject.org; Tue, 19 Oct 2021 04:41:27 +0000
Received: from smtp-out2.suse.de (unknown [195.135.220.29])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id d124ab18-3096-11ec-82fd-12813bfff9fa;
 Tue, 19 Oct 2021 04:41:26 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 147241FD8A;
 Tue, 19 Oct 2021 04:41:25 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E2EB313C5C;
 Tue, 19 Oct 2021 04:41:24 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id lpIwNnRMbmHdMgAAMHmgww
 (envelope-from <jgross@suse.com>); Tue, 19 Oct 2021 04:41:24 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d124ab18-3096-11ec-82fd-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1634618485; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:  content-transfer-encoding:content-transfer-encoding;
	bh=Hs3bU4aT9bwXquQpTV6SvDWgRHlT2YNCRl1zv/sJFoI=;
	b=DXLVrh9obNjgFJIjuloW39HvozOu5UEXBuLxppYuO4v1b2Ekq9mPteIWLuZdTYjFTiIxgs
	BaV3sRYY7DTFyHM4IB0qcl+SKwPXySSfnuxHnkBqlxeGHH2t92DfGtXkSVlyRHCoB9/n3D
	u+NI9JuRR8rMq3EVIFP+kazupUcMyxU=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org
Cc: Juergen Gross <jgross@suse.com>,
	Ian Jackson <iwj@xenproject.org>,
	Wei Liu <wl@xen.org>
Subject: [PATCH] tools: fix oom setting of xenstored
Date: Tue, 19 Oct 2021 06:41:23 +0200
Message-Id: <20211019044123.29648-1-jgross@suse.com>
X-Mailer: git-send-email 2.26.2
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Commit f282182af32939 ("tools/xenstore: set oom score for xenstore
daemon on Linux") introduced a regression when not setting the oom
value in the xencommons file. Fix that.

Fixes: f282182af32939 ("tools/xenstore: set oom score for xenstore daemon on Linux")
Signed-off-by: Juergen Gross <jgross@suse.com>
---
 tools/hotplug/Linux/launch-xenstore.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/hotplug/Linux/launch-xenstore.in b/tools/hotplug/Linux/launch-xenstore.in
index 8438af9977..2b99b98896 100644
--- a/tools/hotplug/Linux/launch-xenstore.in
+++ b/tools/hotplug/Linux/launch-xenstore.in
@@ -60,7 +60,7 @@ test -f @CONFIG_DIR@/@CONFIG_LEAF_DIR@/xencommons && . @CONFIG_DIR@/@CONFIG_LEAF
 		echo "No xenstored found"
 		exit 1
 	}
-	[ -z "$XENSTORED_OOM_MEM_THRESHOLD" ] || XENSTORED_OOM_MEM_THRESHOLD=50
+	[ -z "$XENSTORED_OOM_MEM_THRESHOLD" ] && XENSTORED_OOM_MEM_THRESHOLD=50
 	XS_OOM_SCORE=-$(($XENSTORED_OOM_MEM_THRESHOLD * 10))
 
 	[ "$XENSTORED_MAX_OPEN_FDS" = "unlimited" ] || {
-- 
2.26.2



From xen-devel-bounces@lists.xenproject.org Tue Oct 19 05:42:42 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Oct 2021 05:42:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.212650.370604 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mchtP-0004tV-6Y; Tue, 19 Oct 2021 05:42:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 212650.370604; Tue, 19 Oct 2021 05:42:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mchtP-0004tO-3d; Tue, 19 Oct 2021 05:42:31 +0000
Received: by outflank-mailman (input) for mailman id 212650;
 Tue, 19 Oct 2021 05:42:29 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mchtN-0004tE-EQ; Tue, 19 Oct 2021 05:42:29 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mchtN-0000Ui-74; Tue, 19 Oct 2021 05:42:29 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mchtM-00034v-UJ; Tue, 19 Oct 2021 05:42:29 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mchtM-0001wx-Tk; Tue, 19 Oct 2021 05:42:28 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=JZeeO3gqkixTUvWvdJMKCfhsfb7VgkJd5KlEY+vTKQQ=; b=sbF/nIzVv96O6rjuIDq3llWXnl
	a4bqXm9MTIa5daS9AbD0NQpbsxkD5GQFfkIXX8V8cFaBzv+6juOyA7EP+zqeSn6Kjf4HRYlc9V8hL
	YkSljEUR6OsJuPJdFnrLbZc9A3uzaaVJP+wmK0R/g3Ja15GqVeo8auxsCBJb7oORNo4o=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165651-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 165651: regressions - FAIL
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-xl-qemuu-debianhvm-amd64:leak-check/basis(11):fail:regression
    xen-unstable-smoke:test-amd64-amd64-libvirt:leak-check/basis(11):fail:regression
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:leak-check/basis(11):fail:regression
    xen-unstable-smoke:test-armhf-armhf-xl:leak-check/basis(11):fail:regression
X-Osstest-Versions-This:
    xen=3ae80dea4601764818d1e5b84bd1e4479c0d4790
X-Osstest-Versions-That:
    xen=c11b8d25fbe9c0155e91409594ea6701008409ed
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 19 Oct 2021 05:42:28 +0000

flight 165651 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165651/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-amd64-amd64-xl-qemuu-debianhvm-amd64 11 leak-check/basis(11) fail REGR. vs. 165635
 test-amd64-amd64-libvirt     11 leak-check/basis(11)     fail REGR. vs. 165635
 test-arm64-arm64-xl-xsm      11 leak-check/basis(11)     fail REGR. vs. 165635
 test-armhf-armhf-xl          11 leak-check/basis(11)     fail REGR. vs. 165635

version targeted for testing:
 xen                  3ae80dea4601764818d1e5b84bd1e4479c0d4790
baseline version:
 xen                  c11b8d25fbe9c0155e91409594ea6701008409ed

Last test of basis   165635  2021-10-18 13:00:26 Z    0 days
Testing same since   165638  2021-10-18 16:01:36 Z    0 days    3 attempts

------------------------------------------------------------
People who touched revisions under test:
  Ian Jackson <iwj@xenproject.org>
  Juergen Gross <jgross@suse.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          fail    
 test-arm64-arm64-xl-xsm                                      fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    fail    
 test-amd64-amd64-libvirt                                     fail    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

------------------------------------------------------------
commit 3ae80dea4601764818d1e5b84bd1e4479c0d4790
Author: Juergen Gross <jgross@suse.com>
Date:   Fri Sep 10 07:55:17 2021 +0200

    stubdom: disable building pv-grub
    
    The stubdom based pv-grub is using a very outdated version of grub
    (0.97) and should not be used any longer. Mainline grub has support for
    PV guests for a long time now, so that should be used as a boot loader
    of a PV domain.
    
    So disable building pv-grub per default. In case someone really wants
    to continue using it he/she can still use a pv-grub binary from an older
    Xen version or manually enable building it via:
    
      configure --enable-pv-grub
    
    [ This was already disabled in osstest by 8dee6e333622
      "make-flight: Drop pvgrub (pvgrub1) tests" -iwj ]
    
    Signed-off-by: Juergen Gross <jgross@suse.com>
    Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
    Acked-by: Ian Jackson <iwj@xenproject.org>
    Release-Acked-by: Ian Jackson <iwj@xenproject.org>

commit 9cfeb83cbe23a873de512211d7ecd989348b9df0
Author: Juergen Gross <jgross@suse.com>
Date:   Tue Oct 12 15:41:48 2021 +0200

    tools/xenstore: set open file descriptor limit for xenstored
    
    Add a configuration item for the maximum number of open file
    descriptors xenstored should be allowed to have.
    
    The default should be "unlimited" in order not to restrict xenstored
    in the number of domains it can support, but unfortunately the kernel
    is normally limiting the maximum value via /proc/sys/fs/nr_open [1],
    [2]. So check that file to exist and if it does, limit the maximum
    value to the one specified by /proc/sys/fs/nr_open.
    
    As an aid for the admin configuring the value add a comment specifying
    the common needs of xenstored for the different domain types.
    
    [1]: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=60fd760fb9ff7034360bab7137c917c0330628c2
    [2]: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=0c2d64fb6cae9aae480f6a46cfe79f8d7d48b59f
    
    Signed-off-by: Juergen Gross <jgross@suse.com>
    Reviewed-by: Ian Jackson <iwj@xenproject.org>
    Release-Acked-by: Ian Jackson <iwj@xenproject.org>

commit f282182af32939107d47943aba242d3189ec6f90
Author: Juergen Gross <jgross@suse.com>
Date:   Tue Oct 12 15:41:47 2021 +0200

    tools/xenstore: set oom score for xenstore daemon on Linux
    
    Xenstored is absolutely mandatory for a Xen host and it can't be
    restarted, so being killed by OOM-killer in case of memory shortage is
    to be avoided.
    
    Set /proc/$pid/oom_score_adj (if available) per default to -500 (this
    translates to 50% of dom0 memory size) in order to allow xenstored to
    use large amounts of memory without being killed.
    
    The percentage of dom0 memory above which the oom killer is allowed to
    kill xenstored can be set via XENSTORED_OOM_MEM_THRESHOLD in
    xencommons.
    
    Make sure the pid file isn't a left-over from a previous run delete it
    before starting xenstored.
    
    Signed-off-by: Juergen Gross <jgross@suse.com>
    Reviewed-by: Ian Jackson <iwj@xenproject.org>
    Release-Acked-by: Ian Jackson <iwj@xenproject.org>
(qemu changes not included)


From xen-devel-bounces@lists.xenproject.org Tue Oct 19 06:25:53 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Oct 2021 06:25:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.212663.370631 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mciZG-0000ga-Kv; Tue, 19 Oct 2021 06:25:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 212663.370631; Tue, 19 Oct 2021 06:25:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mciZG-0000gT-H0; Tue, 19 Oct 2021 06:25:46 +0000
Received: by outflank-mailman (input) for mailman id 212663;
 Tue, 19 Oct 2021 06:25:45 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=rpT6=PH=bombadil.srs.infradead.org=BATV+3b2d0d247c9f97582818+6631+infradead.org+hch@srs-us1.protection.inumbo.net>)
 id 1mciZF-0000gN-08
 for xen-devel@lists.xenproject.org; Tue, 19 Oct 2021 06:25:45 +0000
Received: from bombadil.infradead.org (unknown [2607:7c80:54:e::133])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 053c8ac3-fc21-47b1-b44c-2e0aa810195f;
 Tue, 19 Oct 2021 06:25:42 +0000 (UTC)
Received: from 089144192247.atnat0001.highway.a1.net ([89.144.192.247]
 helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1mciZ2-000HX0-PR; Tue, 19 Oct 2021 06:25:33 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 053c8ac3-fc21-47b1-b44c-2e0aa810195f
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:
	Content-ID:Content-Description:In-Reply-To:References;
	bh=itvvQJMlOd0qMZWya439KMIYfs2Y4pBye3jHCRjN2vI=; b=0WK/Nr+5apW24kzj3x7xKVx7vx
	wHu3IfTt08GM2a8iZHSu/L7P2/ShdB2Ni0GtKL8fKLR3xR1YFpYEVR2yG283mViN4RS4WOtPE1AsY
	fI3Docjlmro2vJpJxZ7PBO2fBZ5/+JsjvnL3ZFE64BOG1RQdmSdpKP4G4/3gKfOHM6U9mh+vK1XJn
	97WTNBQbr2LqiyjavYVqnzoz6kb8iJJN4Lm8x7e+eXjXCuSAZJ5EBUYBr+4JM8DnWbQXqkRZinxII
	UKPWx44EsalOi7/NkkkU5iG9za0HK1FDaM4FdcAifoM+JFBCGcc/EQSWszLyWfS3L4P3982Y+LfCg
	0IFcnfNw==;
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	Josef Bacik <josef@toxicpanda.com>,
	David Sterba <dsterba@suse.com>,
	OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>,
	Konstantin Komarov <almaz.alexandrovich@paragon-software.com>,
	linux-block@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	linux-btrfs@vger.kernel.org,
	linux-fsdevel@vger.kernel.org,
	ntfs3@lists.linux.dev
Subject: cleanup block device inode syncing
Date: Tue, 19 Oct 2021 08:25:23 +0200
Message-Id: <20211019062530.2174626-1-hch@lst.de>
X-Mailer: git-send-email 2.30.2
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

Hi Jens,

this series refactors parts of the sync code so that we have and always
use proper helpers for syncing data cached in the block device inode.

Diffstat:
 block/bdev.c                       |   28 +++++++++++-----
 drivers/block/xen-blkback/xenbus.c |    2 -
 fs/btrfs/volumes.c                 |    2 -
 fs/fat/inode.c                     |    6 +--
 fs/internal.h                      |   11 ------
 fs/ntfs3/inode.c                   |    2 -
 fs/sync.c                          |   62 +++++++++++++------------------------
 include/linux/blkdev.h             |    9 +++++
 8 files changed, 56 insertions(+), 66 deletions(-)


From xen-devel-bounces@lists.xenproject.org Tue Oct 19 06:25:53 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Oct 2021 06:25:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.212664.370642 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mciZK-0000xP-TC; Tue, 19 Oct 2021 06:25:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 212664.370642; Tue, 19 Oct 2021 06:25:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mciZK-0000xI-Oo; Tue, 19 Oct 2021 06:25:50 +0000
Received: by outflank-mailman (input) for mailman id 212664;
 Tue, 19 Oct 2021 06:25:49 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=rpT6=PH=bombadil.srs.infradead.org=BATV+3b2d0d247c9f97582818+6631+infradead.org+hch@srs-us1.protection.inumbo.net>)
 id 1mciZJ-0000gN-Rd
 for xen-devel@lists.xenproject.org; Tue, 19 Oct 2021 06:25:49 +0000
Received: from bombadil.infradead.org (unknown [2607:7c80:54:e::133])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 329376dc-21d6-498e-b3be-65ee5089e3df;
 Tue, 19 Oct 2021 06:25:43 +0000 (UTC)
Received: from 089144192247.atnat0001.highway.a1.net ([89.144.192.247]
 helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1mciZ6-000HXN-ET; Tue, 19 Oct 2021 06:25:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 329376dc-21d6-498e-b3be-65ee5089e3df
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
	:Reply-To:Content-Type:Content-ID:Content-Description;
	bh=gFwPkwP9Zjsq1mqO3JahAc353BRcOUUl+PLqpsO72YI=; b=ZJW8aR8ndzAoILXJIyVOCHqhpJ
	ajMm/Ex3wKHJjPYAwkuWxVnN1ZhdLhRhrXsne7qfmZhPB7qgvjjNYCDO7FZ12EIoWigLug1zframs
	UBRixzbC81D0BL6MTo57Bq8G5/80zrEGJP7GFMWpKQtxi9CECpBnZJoXTHrn47Bce+ERZbkXLhAyY
	j5Yhf3yuHwHV/0O2mMEJ/nX6vwinouMvFWYzZ7f+gPpOqrZa5bdHTCDN1w1kF1hYq2uX2liHkPDSv
	inlHv0JYz9UWiqQw0mjEOiKX6X+poiKU7uiX6FUJ3QwZba9uou3CnATYwJyCONmS0KgeT7kpKCpq2
	O49/xozg==;
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	Josef Bacik <josef@toxicpanda.com>,
	David Sterba <dsterba@suse.com>,
	OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>,
	Konstantin Komarov <almaz.alexandrovich@paragon-software.com>,
	linux-block@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	linux-btrfs@vger.kernel.org,
	linux-fsdevel@vger.kernel.org,
	ntfs3@lists.linux.dev
Subject: [PATCH 1/7] fs: remove __sync_filesystem
Date: Tue, 19 Oct 2021 08:25:24 +0200
Message-Id: <20211019062530.2174626-2-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20211019062530.2174626-1-hch@lst.de>
References: <20211019062530.2174626-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

There is no clear benefit in having this helper vs just open coding it.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 fs/sync.c | 38 +++++++++++++++++---------------------
 1 file changed, 17 insertions(+), 21 deletions(-)

diff --git a/fs/sync.c b/fs/sync.c
index 1373a610dc784..0d6cdc507cb98 100644
--- a/fs/sync.c
+++ b/fs/sync.c
@@ -21,25 +21,6 @@
 #define VALID_FLAGS (SYNC_FILE_RANGE_WAIT_BEFORE|SYNC_FILE_RANGE_WRITE| \
 			SYNC_FILE_RANGE_WAIT_AFTER)
 
-/*
- * Do the filesystem syncing work. For simple filesystems
- * writeback_inodes_sb(sb) just dirties buffers with inodes so we have to
- * submit IO for these buffers via __sync_blockdev(). This also speeds up the
- * wait == 1 case since in that case write_inode() functions do
- * sync_dirty_buffer() and thus effectively write one block at a time.
- */
-static int __sync_filesystem(struct super_block *sb, int wait)
-{
-	if (wait)
-		sync_inodes_sb(sb);
-	else
-		writeback_inodes_sb(sb, WB_REASON_SYNC);
-
-	if (sb->s_op->sync_fs)
-		sb->s_op->sync_fs(sb, wait);
-	return __sync_blockdev(sb->s_bdev, wait);
-}
-
 /*
  * Write out and wait upon all dirty data associated with this
  * superblock.  Filesystem data as well as the underlying block
@@ -61,10 +42,25 @@ int sync_filesystem(struct super_block *sb)
 	if (sb_rdonly(sb))
 		return 0;
 
-	ret = __sync_filesystem(sb, 0);
+	/*
+	 * Do the filesystem syncing work.  For simple filesystems
+	 * writeback_inodes_sb(sb) just dirties buffers with inodes so we have
+	 * to submit I/O for these buffers via __sync_blockdev().  This also
+	 * speeds up the wait == 1 case since in that case write_inode()
+	 * methods call sync_dirty_buffer() and thus effectively write one block
+	 * at a time.
+	 */
+	writeback_inodes_sb(sb, WB_REASON_SYNC);
+	if (sb->s_op->sync_fs)
+		sb->s_op->sync_fs(sb, 0);
+	ret = __sync_blockdev(sb->s_bdev, 0);
 	if (ret < 0)
 		return ret;
-	return __sync_filesystem(sb, 1);
+
+	sync_inodes_sb(sb);
+	if (sb->s_op->sync_fs)
+		sb->s_op->sync_fs(sb, 1);
+	return __sync_blockdev(sb->s_bdev, 1);
 }
 EXPORT_SYMBOL(sync_filesystem);
 
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Tue Oct 19 06:25:56 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Oct 2021 06:25:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.212665.370653 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mciZQ-0001HV-4d; Tue, 19 Oct 2021 06:25:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 212665.370653; Tue, 19 Oct 2021 06:25:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mciZQ-0001HK-1H; Tue, 19 Oct 2021 06:25:56 +0000
Received: by outflank-mailman (input) for mailman id 212665;
 Tue, 19 Oct 2021 06:25:54 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=rpT6=PH=bombadil.srs.infradead.org=BATV+3b2d0d247c9f97582818+6631+infradead.org+hch@srs-us1.protection.inumbo.net>)
 id 1mciZO-0000gN-Rb
 for xen-devel@lists.xenproject.org; Tue, 19 Oct 2021 06:25:54 +0000
Received: from bombadil.infradead.org (unknown [2607:7c80:54:e::133])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id cdfd2b1c-e8d1-4f43-a210-76b089f72276;
 Tue, 19 Oct 2021 06:25:47 +0000 (UTC)
Received: from 089144192247.atnat0001.highway.a1.net ([89.144.192.247]
 helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1mciZA-000HXw-Kb; Tue, 19 Oct 2021 06:25:41 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: cdfd2b1c-e8d1-4f43-a210-76b089f72276
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
	:Reply-To:Content-Type:Content-ID:Content-Description;
	bh=qVMoniHT8GUK08EKnqJv740ihac5REoeu/3MYlJep7k=; b=cw2FWZNlpqBbTB4MdfrasfcoUP
	hUXTb6YdSKVLbQQq5eq430vJY21sLDtE7E/fqW8XCzN/7rd1aMelUYKnYJJyq0OMnL7oJXKYp3wxp
	awNLC3EsynFT5xrA8pjbHlCqxZ38emcM3sTu81z5wMUZST+8cgygormZJBzcf63vEZ/yGJlgd5pnN
	GpS9wQsLQwP2mGW0h+tuegGOgkoEy/3dqOYnf4RZ7VH8QA5mnRhj45NvYZU+Qi8DL3mdw2eL5tLHv
	FdqYrW/ugsdtsecu3mt1hMj3j9CxRLO5QmmR0VKHNLcUpUiujUAsI5/Z6wXq4l78AW6B4J2S60/UM
	VIWW6FpA==;
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	Josef Bacik <josef@toxicpanda.com>,
	David Sterba <dsterba@suse.com>,
	OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>,
	Konstantin Komarov <almaz.alexandrovich@paragon-software.com>,
	linux-block@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	linux-btrfs@vger.kernel.org,
	linux-fsdevel@vger.kernel.org,
	ntfs3@lists.linux.dev
Subject: [PATCH 2/7] block: remove __sync_blockdev
Date: Tue, 19 Oct 2021 08:25:25 +0200
Message-Id: <20211019062530.2174626-3-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20211019062530.2174626-1-hch@lst.de>
References: <20211019062530.2174626-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

Instead offer a new sync_blockdev_nowait helper for the !wait case.
This new helper is exported as it will grow modular callers in a bit.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 block/bdev.c           | 11 ++++++-----
 fs/internal.h          |  5 -----
 fs/sync.c              |  7 ++++---
 include/linux/blkdev.h |  5 +++++
 4 files changed, 15 insertions(+), 13 deletions(-)

diff --git a/block/bdev.c b/block/bdev.c
index cff0bb3a4578f..fe91209881730 100644
--- a/block/bdev.c
+++ b/block/bdev.c
@@ -185,14 +185,13 @@ int sb_min_blocksize(struct super_block *sb, int size)
 
 EXPORT_SYMBOL(sb_min_blocksize);
 
-int __sync_blockdev(struct block_device *bdev, int wait)
+int sync_blockdev_nowait(struct block_device *bdev)
 {
 	if (!bdev)
 		return 0;
-	if (!wait)
-		return filemap_flush(bdev->bd_inode->i_mapping);
-	return filemap_write_and_wait(bdev->bd_inode->i_mapping);
+	return filemap_flush(bdev->bd_inode->i_mapping);
 }
+EXPORT_SYMBOL_GPL(sync_blockdev_nowait);
 
 /*
  * Write out and wait upon all the dirty data associated with a block
@@ -200,7 +199,9 @@ int __sync_blockdev(struct block_device *bdev, int wait)
  */
 int sync_blockdev(struct block_device *bdev)
 {
-	return __sync_blockdev(bdev, 1);
+	if (!bdev)
+		return 0;
+	return filemap_write_and_wait(bdev->bd_inode->i_mapping);
 }
 EXPORT_SYMBOL(sync_blockdev);
 
diff --git a/fs/internal.h b/fs/internal.h
index 3cd065c8a66b4..b5caa16f4645d 100644
--- a/fs/internal.h
+++ b/fs/internal.h
@@ -23,7 +23,6 @@ struct pipe_inode_info;
 #ifdef CONFIG_BLOCK
 extern void __init bdev_cache_init(void);
 
-extern int __sync_blockdev(struct block_device *bdev, int wait);
 void iterate_bdevs(void (*)(struct block_device *, void *), void *);
 void emergency_thaw_bdev(struct super_block *sb);
 #else
@@ -31,10 +30,6 @@ static inline void bdev_cache_init(void)
 {
 }
 
-static inline int __sync_blockdev(struct block_device *bdev, int wait)
-{
-	return 0;
-}
 static inline void iterate_bdevs(void (*f)(struct block_device *, void *),
 		void *arg)
 {
diff --git a/fs/sync.c b/fs/sync.c
index 0d6cdc507cb98..a621089eb07ee 100644
--- a/fs/sync.c
+++ b/fs/sync.c
@@ -3,6 +3,7 @@
  * High-level sync()-related operations
  */
 
+#include <linux/blkdev.h>
 #include <linux/kernel.h>
 #include <linux/file.h>
 #include <linux/fs.h>
@@ -45,7 +46,7 @@ int sync_filesystem(struct super_block *sb)
 	/*
 	 * Do the filesystem syncing work.  For simple filesystems
 	 * writeback_inodes_sb(sb) just dirties buffers with inodes so we have
-	 * to submit I/O for these buffers via __sync_blockdev().  This also
+	 * to submit I/O for these buffers via sync_blockdev().  This also
 	 * speeds up the wait == 1 case since in that case write_inode()
 	 * methods call sync_dirty_buffer() and thus effectively write one block
 	 * at a time.
@@ -53,14 +54,14 @@ int sync_filesystem(struct super_block *sb)
 	writeback_inodes_sb(sb, WB_REASON_SYNC);
 	if (sb->s_op->sync_fs)
 		sb->s_op->sync_fs(sb, 0);
-	ret = __sync_blockdev(sb->s_bdev, 0);
+	ret = sync_blockdev_nowait(sb->s_bdev);
 	if (ret < 0)
 		return ret;
 
 	sync_inodes_sb(sb);
 	if (sb->s_op->sync_fs)
 		sb->s_op->sync_fs(sb, 1);
-	return __sync_blockdev(sb->s_bdev, 1);
+	return sync_blockdev(sb->s_bdev);
 }
 EXPORT_SYMBOL(sync_filesystem);
 
diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
index fd9771a1da096..67a3b9e04233f 100644
--- a/include/linux/blkdev.h
+++ b/include/linux/blkdev.h
@@ -1285,6 +1285,7 @@ int truncate_bdev_range(struct block_device *bdev, fmode_t mode, loff_t lstart,
 #ifdef CONFIG_BLOCK
 void invalidate_bdev(struct block_device *bdev);
 int sync_blockdev(struct block_device *bdev);
+int sync_blockdev_nowait(struct block_device *bdev);
 #else
 static inline void invalidate_bdev(struct block_device *bdev)
 {
@@ -1293,6 +1294,10 @@ static inline int sync_blockdev(struct block_device *bdev)
 {
 	return 0;
 }
+static inline int sync_blockdev_nowait(struct block_device *bdev)
+{
+	return 0;
+}
 #endif
 int fsync_bdev(struct block_device *bdev);
 
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Tue Oct 19 06:26:01 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Oct 2021 06:26:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.212667.370664 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mciZV-0001f5-En; Tue, 19 Oct 2021 06:26:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 212667.370664; Tue, 19 Oct 2021 06:26:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mciZV-0001eo-Ay; Tue, 19 Oct 2021 06:26:01 +0000
Received: by outflank-mailman (input) for mailman id 212667;
 Tue, 19 Oct 2021 06:25:59 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=rpT6=PH=bombadil.srs.infradead.org=BATV+3b2d0d247c9f97582818+6631+infradead.org+hch@srs-us1.protection.inumbo.net>)
 id 1mciZT-0000gN-Rn
 for xen-devel@lists.xenproject.org; Tue, 19 Oct 2021 06:25:59 +0000
Received: from bombadil.infradead.org (unknown [2607:7c80:54:e::133])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id ac79a240-fd27-446e-bc98-f129e3eaa0f1;
 Tue, 19 Oct 2021 06:25:50 +0000 (UTC)
Received: from 089144192247.atnat0001.highway.a1.net ([89.144.192.247]
 helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1mciZE-000HYS-Kb; Tue, 19 Oct 2021 06:25:45 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ac79a240-fd27-446e-bc98-f129e3eaa0f1
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
	:Reply-To:Content-Type:Content-ID:Content-Description;
	bh=S4CUuCzH5lqDJB4MuGXgQVUVRBAgyFaG9eQzfRY3vKs=; b=Y76U8j2/7fMjSInt7+CXGBDOhc
	CZY3kWorzZ2XPyjb2tyz44lq9E/ZVzRaAEAwhRHsFtJoldrC1Bz7ygkgOAP4PjegThAdcN59PVRnx
	EoqzxNHR8HF2r+3LHKmbkqPU3gX98CERX8a9xovUUHNUdCqzg/SaZ8TWDCI9dpEkH99+mUQYHjlvH
	OU4uFyZ0MFPNFVBHys6c+5ihObcQ9kr4ugeCnSkXlolmvravRiugyya4H7qIvrhXaNUnEmvdXsK2i
	FYUBNrrNufIVcV83q4hcD3MKW8wZif2UlfwLDuf96LNy8crV7wf6vsX/d7s75O4gXzmCvHTEGC2MF
	3/pQctLQ==;
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	Josef Bacik <josef@toxicpanda.com>,
	David Sterba <dsterba@suse.com>,
	OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>,
	Konstantin Komarov <almaz.alexandrovich@paragon-software.com>,
	linux-block@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	linux-btrfs@vger.kernel.org,
	linux-fsdevel@vger.kernel.org,
	ntfs3@lists.linux.dev
Subject: [PATCH 3/7] xen-blkback: use sync_blockdev
Date: Tue, 19 Oct 2021 08:25:26 +0200
Message-Id: <20211019062530.2174626-4-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20211019062530.2174626-1-hch@lst.de>
References: <20211019062530.2174626-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

Use sync_blockdev instead of opencoding it.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 drivers/block/xen-blkback/xenbus.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/block/xen-blkback/xenbus.c b/drivers/block/xen-blkback/xenbus.c
index 33eba3df4dd9a..914587aabca0c 100644
--- a/drivers/block/xen-blkback/xenbus.c
+++ b/drivers/block/xen-blkback/xenbus.c
@@ -98,7 +98,7 @@ static void xen_update_blkif_status(struct xen_blkif *blkif)
 		return;
 	}
 
-	err = filemap_write_and_wait(blkif->vbd.bdev->bd_inode->i_mapping);
+	err = sync_blockdev(blkif->vbd.bdev);
 	if (err) {
 		xenbus_dev_error(blkif->be->dev, err, "block flush");
 		return;
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Tue Oct 19 06:26:06 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Oct 2021 06:26:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.212669.370675 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mciZa-00024r-OS; Tue, 19 Oct 2021 06:26:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 212669.370675; Tue, 19 Oct 2021 06:26:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mciZa-00024f-KG; Tue, 19 Oct 2021 06:26:06 +0000
Received: by outflank-mailman (input) for mailman id 212669;
 Tue, 19 Oct 2021 06:26:04 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=rpT6=PH=bombadil.srs.infradead.org=BATV+3b2d0d247c9f97582818+6631+infradead.org+hch@srs-us1.protection.inumbo.net>)
 id 1mciZY-0000gN-S1
 for xen-devel@lists.xenproject.org; Tue, 19 Oct 2021 06:26:04 +0000
Received: from bombadil.infradead.org (unknown [2607:7c80:54:e::133])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 6f6ee1bd-8896-4c5b-878e-7fbc0af569d4;
 Tue, 19 Oct 2021 06:25:54 +0000 (UTC)
Received: from 089144192247.atnat0001.highway.a1.net ([89.144.192.247]
 helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1mciZI-000HaB-1X; Tue, 19 Oct 2021 06:25:48 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6f6ee1bd-8896-4c5b-878e-7fbc0af569d4
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
	:Reply-To:Content-Type:Content-ID:Content-Description;
	bh=2oPjr/CmcgLY9x84ULlH3Ff6Xbo0qFK9LD8/6togFZA=; b=NmleJeKN1g8pEYKNinAzcH1jFW
	YVzZPzhzgKyPmp7TB1Ltmv00TeeI/hto2YW37T69//rbf+Nm4+mj9nydcHUW9DrmtRpdHx8Fi/Fzo
	1NKGKe7HuNLCG/KCOJfbOkFEsBcUQW7is1N0PUDRsGRU4DXtFlkDsK/l979/BPtac6T+tGfM9xbD3
	lpv4i1Yp/wTNXV/aC+5TgkvwywJ9iElv2wuSnP/vGd3+TpVcWT4Tscb7sXljwDFbVg3Y0SAJMMs+6
	BzKCsHP8M2Yf6xLFlnmib88C7gbfz+Y0BlNlE5lfDEjfMICHGNJNMYzubZ7YdN9HwDct/4CCIEPFd
	ma7YqgQg==;
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	Josef Bacik <josef@toxicpanda.com>,
	David Sterba <dsterba@suse.com>,
	OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>,
	Konstantin Komarov <almaz.alexandrovich@paragon-software.com>,
	linux-block@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	linux-btrfs@vger.kernel.org,
	linux-fsdevel@vger.kernel.org,
	ntfs3@lists.linux.dev
Subject: [PATCH 4/7] btrfs: use sync_blockdev
Date: Tue, 19 Oct 2021 08:25:27 +0200
Message-Id: <20211019062530.2174626-5-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20211019062530.2174626-1-hch@lst.de>
References: <20211019062530.2174626-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

Use sync_blockdev instead of opencoding it.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 fs/btrfs/volumes.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
index 2ec3b8ac8fa35..b51e4b464103e 100644
--- a/fs/btrfs/volumes.c
+++ b/fs/btrfs/volumes.c
@@ -508,7 +508,7 @@ btrfs_get_bdev_and_sb(const char *device_path, fmode_t flags, void *holder,
 	}
 
 	if (flush)
-		filemap_write_and_wait((*bdev)->bd_inode->i_mapping);
+		sync_blockdev(*bdev);
 	ret = set_blocksize(*bdev, BTRFS_BDEV_BLOCKSIZE);
 	if (ret) {
 		blkdev_put(*bdev, flags);
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Tue Oct 19 06:26:11 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Oct 2021 06:26:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.212671.370686 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mciZf-0002Wx-8s; Tue, 19 Oct 2021 06:26:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 212671.370686; Tue, 19 Oct 2021 06:26:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mciZf-0002Wo-4h; Tue, 19 Oct 2021 06:26:11 +0000
Received: by outflank-mailman (input) for mailman id 212671;
 Tue, 19 Oct 2021 06:26:09 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=rpT6=PH=bombadil.srs.infradead.org=BATV+3b2d0d247c9f97582818+6631+infradead.org+hch@srs-us1.protection.inumbo.net>)
 id 1mciZd-0000gN-S1
 for xen-devel@lists.xenproject.org; Tue, 19 Oct 2021 06:26:09 +0000
Received: from bombadil.infradead.org (unknown [2607:7c80:54:e::133])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 7eb7a040-8117-43a0-b0bc-d78b51fe8bfd;
 Tue, 19 Oct 2021 06:25:57 +0000 (UTC)
Received: from 089144192247.atnat0001.highway.a1.net ([89.144.192.247]
 helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1mciZL-000Haq-Cr; Tue, 19 Oct 2021 06:25:52 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7eb7a040-8117-43a0-b0bc-d78b51fe8bfd
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
	:Reply-To:Content-Type:Content-ID:Content-Description;
	bh=6G6Emq5ChhmlcaDtzCXji8dJmryMmwXGPmCdOZlKPPY=; b=j4UB2nSod+LlsBHiimZOBDpcAy
	u6tB26X30Q2k2GBEgBacqFxiVQDVPzkRZiYu4lqEfkXIB3yzaQiuGy9S4c0VDN7/AnGFYxJmJk7eA
	/moXk9K3qVOhJ5TVQ8R8dQu/tf697hXRZazlcb0VCPamOZuuxa9DhrhL284ceHMsP1Z3Ko+i221Iq
	m40wQohw06W10smZ91d0PtMkNL5lSN2RvzsOAjlkQ7FNgMfQdw7x1VOvA5v6yJIB6JC8yZsBjuna8
	Cra8m+LDTCQRLNkntWeqLfMSwGVOwGTGNFezv1/lSkmVmL/tiGmekXUOrAS52cWwWAxcLeFw/i7C/
	JzdPpvUw==;
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	Josef Bacik <josef@toxicpanda.com>,
	David Sterba <dsterba@suse.com>,
	OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>,
	Konstantin Komarov <almaz.alexandrovich@paragon-software.com>,
	linux-block@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	linux-btrfs@vger.kernel.org,
	linux-fsdevel@vger.kernel.org,
	ntfs3@lists.linux.dev
Subject: [PATCH 5/7] fat: use sync_blockdev_nowait
Date: Tue, 19 Oct 2021 08:25:28 +0200
Message-Id: <20211019062530.2174626-6-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20211019062530.2174626-1-hch@lst.de>
References: <20211019062530.2174626-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

Use sync_blockdev_nowait instead of opencoding it.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 fs/fat/inode.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/fs/fat/inode.c b/fs/fat/inode.c
index de0c9b013a851..2fd5bfddb6958 100644
--- a/fs/fat/inode.c
+++ b/fs/fat/inode.c
@@ -1943,10 +1943,8 @@ int fat_flush_inodes(struct super_block *sb, struct inode *i1, struct inode *i2)
 		ret = writeback_inode(i1);
 	if (!ret && i2)
 		ret = writeback_inode(i2);
-	if (!ret) {
-		struct address_space *mapping = sb->s_bdev->bd_inode->i_mapping;
-		ret = filemap_flush(mapping);
-	}
+	if (!ret)
+		ret = sync_blockdev_nowait(sb->s_bdev);
 	return ret;
 }
 EXPORT_SYMBOL_GPL(fat_flush_inodes);
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Tue Oct 19 06:26:16 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Oct 2021 06:26:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.212675.370697 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mciZk-00030e-LU; Tue, 19 Oct 2021 06:26:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 212675.370697; Tue, 19 Oct 2021 06:26:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mciZk-00030X-Gs; Tue, 19 Oct 2021 06:26:16 +0000
Received: by outflank-mailman (input) for mailman id 212675;
 Tue, 19 Oct 2021 06:26:14 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=rpT6=PH=bombadil.srs.infradead.org=BATV+3b2d0d247c9f97582818+6631+infradead.org+hch@srs-us1.protection.inumbo.net>)
 id 1mciZi-0000gN-S5
 for xen-devel@lists.xenproject.org; Tue, 19 Oct 2021 06:26:14 +0000
Received: from bombadil.infradead.org (unknown [2607:7c80:54:e::133])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 4128587b-9758-48d9-9a72-f8c89ce6b4da;
 Tue, 19 Oct 2021 06:26:02 +0000 (UTC)
Received: from 089144192247.atnat0001.highway.a1.net ([89.144.192.247]
 helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1mciZO-000HcH-TJ; Tue, 19 Oct 2021 06:25:55 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4128587b-9758-48d9-9a72-f8c89ce6b4da
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
	:Reply-To:Content-Type:Content-ID:Content-Description;
	bh=DDi853FEag9qzxEvbV2OqURCgYlh/7S1dK8LyuS7zbQ=; b=omDhi7pjmT2o70QnIOulNXChKy
	4vvsfBwPdds39Wa0alTtHRCJEagmexQT86Y/350PSM/qo+0Wi7CiU5NJrLAw0XEZe6oz3SZWf0UpT
	E2gJwoqVG9RAYdb8CtGvg24knqSyGDKGe1lOkpHVUvEcA4vZIKwJJSVfpwl3AU/ZleBs6ynP9aW4N
	H3iuwKADkUKdZfqLuwPA/HFPWY/VjYvkTzOKA+b6VbKrCDup2CQ1vuFuZ2+YGM+R8ZDeqSa49os8/
	y0gb8ezk2N4vPZImbbUBLufOBzmo4VSYE86ZmJmHn5I/ja6v02SrFfrJNgIPZMj321LJdyljHmgQ/
	ehi1DZyw==;
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	Josef Bacik <josef@toxicpanda.com>,
	David Sterba <dsterba@suse.com>,
	OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>,
	Konstantin Komarov <almaz.alexandrovich@paragon-software.com>,
	linux-block@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	linux-btrfs@vger.kernel.org,
	linux-fsdevel@vger.kernel.org,
	ntfs3@lists.linux.dev
Subject: [PATCH 6/7] ntfs3: use sync_blockdev_nowait
Date: Tue, 19 Oct 2021 08:25:29 +0200
Message-Id: <20211019062530.2174626-7-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20211019062530.2174626-1-hch@lst.de>
References: <20211019062530.2174626-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

Use sync_blockdev_nowait instead of opencoding it.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 fs/ntfs3/inode.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/ntfs3/inode.c b/fs/ntfs3/inode.c
index 859951d785cb2..a87ab3ad3cd38 100644
--- a/fs/ntfs3/inode.c
+++ b/fs/ntfs3/inode.c
@@ -1046,7 +1046,7 @@ int ntfs_flush_inodes(struct super_block *sb, struct inode *i1,
 	if (!ret && i2)
 		ret = writeback_inode(i2);
 	if (!ret)
-		ret = filemap_flush(sb->s_bdev->bd_inode->i_mapping);
+		ret = sync_blockdev_nowait(sb->s_bdev);
 	return ret;
 }
 
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Tue Oct 19 06:26:22 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Oct 2021 06:26:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.212677.370707 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mciZp-0003X9-Tz; Tue, 19 Oct 2021 06:26:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 212677.370707; Tue, 19 Oct 2021 06:26:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mciZp-0003WB-Q2; Tue, 19 Oct 2021 06:26:21 +0000
Received: by outflank-mailman (input) for mailman id 212677;
 Tue, 19 Oct 2021 06:26:19 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=rpT6=PH=bombadil.srs.infradead.org=BATV+3b2d0d247c9f97582818+6631+infradead.org+hch@srs-us1.protection.inumbo.net>)
 id 1mciZn-0000gN-SF
 for xen-devel@lists.xenproject.org; Tue, 19 Oct 2021 06:26:19 +0000
Received: from bombadil.infradead.org (unknown [2607:7c80:54:e::133])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 5c7c45c5-d2ad-41d1-9a12-3ab7ef7b8ef3;
 Tue, 19 Oct 2021 06:26:04 +0000 (UTC)
Received: from 089144192247.atnat0001.highway.a1.net ([89.144.192.247]
 helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1mciZS-000Hcl-En; Tue, 19 Oct 2021 06:25:59 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5c7c45c5-d2ad-41d1-9a12-3ab7ef7b8ef3
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
	:Reply-To:Content-Type:Content-ID:Content-Description;
	bh=cXQ4VmbpQdlaz9Fmo/lMgXjRxPhGL2zNDx/ooEcOzSQ=; b=qUTsTibTDXkcY0Wb1gT1F8+GEQ
	wThkDWhya9HN4InkMFj6QODhitCXAaG/43QDQBJ6U3Fjp4vXx/IrMkQsiFzv2I8fLXPbwN0m3O8kW
	3y7sg+bvGJtDcnCctC1+jyXAR6zOLHW5NymOTgpEIeyeU8hCKHAFl5CJ0tdM5s16vvXAFwon35s8K
	gp66mA7cqSS2glu+vSh0xXVKc2bPlHL76YfAPqxfQJhxNi76HMGaYQK5ux9u/m+BsPWuIMULAfEeH
	2uYBjIGbGcMJNj/6YH0HrNfPDFNiBtgXp0j7i6zOLjoJnC3x4oA3ZJcRyztZ5rOI3ll6ebCYToKg6
	5IoYE03A==;
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	Josef Bacik <josef@toxicpanda.com>,
	David Sterba <dsterba@suse.com>,
	OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>,
	Konstantin Komarov <almaz.alexandrovich@paragon-software.com>,
	linux-block@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	linux-btrfs@vger.kernel.org,
	linux-fsdevel@vger.kernel.org,
	ntfs3@lists.linux.dev
Subject: [PATCH 7/7] block: simplify the block device syncing code
Date: Tue, 19 Oct 2021 08:25:30 +0200
Message-Id: <20211019062530.2174626-8-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20211019062530.2174626-1-hch@lst.de>
References: <20211019062530.2174626-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

Get rid of the indirections and just provide a sync_bdevs
helper for the generic sync code.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 block/bdev.c           | 17 ++++++++++++++---
 fs/internal.h          |  6 ------
 fs/sync.c              | 23 ++++-------------------
 include/linux/blkdev.h |  4 ++++
 4 files changed, 22 insertions(+), 28 deletions(-)

diff --git a/block/bdev.c b/block/bdev.c
index fe91209881730..3a8a753f970bb 100644
--- a/block/bdev.c
+++ b/block/bdev.c
@@ -1019,7 +1019,7 @@ int __invalidate_device(struct block_device *bdev, bool kill_dirty)
 }
 EXPORT_SYMBOL(__invalidate_device);
 
-void iterate_bdevs(void (*func)(struct block_device *, void *), void *arg)
+void sync_bdevs(bool wait)
 {
 	struct inode *inode, *old_inode = NULL;
 
@@ -1050,8 +1050,19 @@ void iterate_bdevs(void (*func)(struct block_device *, void *), void *arg)
 		bdev = I_BDEV(inode);
 
 		mutex_lock(&bdev->bd_disk->open_mutex);
-		if (bdev->bd_openers)
-			func(bdev, arg);
+		if (!bdev->bd_openers) {
+			; /* skip */
+		} else if (wait) {
+			/*
+			 * We keep the error status of individual mapping so
+			 * that applications can catch the writeback error using
+			 * fsync(2). See filemap_fdatawait_keep_errors() for
+			 * details.
+			 */
+			filemap_fdatawait_keep_errors(inode->i_mapping);
+		} else {
+			filemap_fdatawrite(inode->i_mapping);
+		}
 		mutex_unlock(&bdev->bd_disk->open_mutex);
 
 		spin_lock(&blockdev_superblock->s_inode_list_lock);
diff --git a/fs/internal.h b/fs/internal.h
index b5caa16f4645d..cdd83d4899bb3 100644
--- a/fs/internal.h
+++ b/fs/internal.h
@@ -23,17 +23,11 @@ struct pipe_inode_info;
 #ifdef CONFIG_BLOCK
 extern void __init bdev_cache_init(void);
 
-void iterate_bdevs(void (*)(struct block_device *, void *), void *);
 void emergency_thaw_bdev(struct super_block *sb);
 #else
 static inline void bdev_cache_init(void)
 {
 }
-
-static inline void iterate_bdevs(void (*f)(struct block_device *, void *),
-		void *arg)
-{
-}
 static inline int emergency_thaw_bdev(struct super_block *sb)
 {
 	return 0;
diff --git a/fs/sync.c b/fs/sync.c
index a621089eb07ee..3ce8e2137f310 100644
--- a/fs/sync.c
+++ b/fs/sync.c
@@ -78,21 +78,6 @@ static void sync_fs_one_sb(struct super_block *sb, void *arg)
 		sb->s_op->sync_fs(sb, *(int *)arg);
 }
 
-static void fdatawrite_one_bdev(struct block_device *bdev, void *arg)
-{
-	filemap_fdatawrite(bdev->bd_inode->i_mapping);
-}
-
-static void fdatawait_one_bdev(struct block_device *bdev, void *arg)
-{
-	/*
-	 * We keep the error status of individual mapping so that
-	 * applications can catch the writeback error using fsync(2).
-	 * See filemap_fdatawait_keep_errors() for details.
-	 */
-	filemap_fdatawait_keep_errors(bdev->bd_inode->i_mapping);
-}
-
 /*
  * Sync everything. We start by waking flusher threads so that most of
  * writeback runs on all devices in parallel. Then we sync all inodes reliably
@@ -111,8 +96,8 @@ void ksys_sync(void)
 	iterate_supers(sync_inodes_one_sb, NULL);
 	iterate_supers(sync_fs_one_sb, &nowait);
 	iterate_supers(sync_fs_one_sb, &wait);
-	iterate_bdevs(fdatawrite_one_bdev, NULL);
-	iterate_bdevs(fdatawait_one_bdev, NULL);
+	sync_bdevs(false);
+	sync_bdevs(true);
 	if (unlikely(laptop_mode))
 		laptop_sync_completion();
 }
@@ -133,10 +118,10 @@ static void do_sync_work(struct work_struct *work)
 	 */
 	iterate_supers(sync_inodes_one_sb, &nowait);
 	iterate_supers(sync_fs_one_sb, &nowait);
-	iterate_bdevs(fdatawrite_one_bdev, NULL);
+	sync_bdevs(false);
 	iterate_supers(sync_inodes_one_sb, &nowait);
 	iterate_supers(sync_fs_one_sb, &nowait);
-	iterate_bdevs(fdatawrite_one_bdev, NULL);
+	sync_bdevs(false);
 	printk("Emergency Sync complete\n");
 	kfree(work);
 }
diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
index 67a3b9e04233f..4bb9c621e0ac3 100644
--- a/include/linux/blkdev.h
+++ b/include/linux/blkdev.h
@@ -1286,6 +1286,7 @@ int truncate_bdev_range(struct block_device *bdev, fmode_t mode, loff_t lstart,
 void invalidate_bdev(struct block_device *bdev);
 int sync_blockdev(struct block_device *bdev);
 int sync_blockdev_nowait(struct block_device *bdev);
+void sync_bdevs(bool wait);
 #else
 static inline void invalidate_bdev(struct block_device *bdev)
 {
@@ -1298,6 +1299,9 @@ static inline int sync_blockdev_nowait(struct block_device *bdev)
 {
 	return 0;
 }
+static inline void sync_bdevs(bool wait)
+{
+}
 #endif
 int fsync_bdev(struct block_device *bdev);
 
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Tue Oct 19 06:37:30 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Oct 2021 06:37:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.212735.370719 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcikX-0006SX-9k; Tue, 19 Oct 2021 06:37:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 212735.370719; Tue, 19 Oct 2021 06:37:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcikX-0006SQ-50; Tue, 19 Oct 2021 06:37:25 +0000
Received: by outflank-mailman (input) for mailman id 212735;
 Tue, 19 Oct 2021 06:37:24 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mcikW-0006SG-61; Tue, 19 Oct 2021 06:37:24 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mcikW-0001VD-1C; Tue, 19 Oct 2021 06:37:24 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mcikV-00071A-Qh; Tue, 19 Oct 2021 06:37:23 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mcikV-0001GC-QD; Tue, 19 Oct 2021 06:37:23 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Message-Id:Subject:To;
	bh=NYkYaWXV1kOjPrHpgAV6zSnNbtkkC8K+peaLwfuFu7c=; b=fMiYSBVo5mvd7XH4C72mL+ZrFP
	RvTz3pGHROf5M4c1D3NP56pe9WaKogRNVf2I2Hw1cP0weO/tZrlvTDLGZ3qzoZVO86zEcwzfgSnqX
	GTR6JotVrxsyUbDEyt+mTjZwzOZSd2CZAgMeqz/tw66vmtpl5agX7BcdI8MpB5MKBkjE=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Subject: [xen-unstable-smoke bisection] complete test-amd64-amd64-xl-qemuu-debianhvm-amd64
Message-Id: <E1mcikV-0001GC-QD@osstest.test-lab.xenproject.org>
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 19 Oct 2021 06:37:23 +0000

branch xen-unstable-smoke
xenbranch xen-unstable-smoke
job test-amd64-amd64-xl-qemuu-debianhvm-amd64
testid leak-check/basis(11)

Tree: linux git://xenbits.xen.org/linux-pvops.git
Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git
Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git
Tree: qemuu git://xenbits.xen.org/qemu-xen.git
Tree: xen git://xenbits.xen.org/xen.git

*** Found and reproduced problem changeset ***

  Bug is in tree:  xen git://xenbits.xen.org/xen.git
  Bug introduced:  f282182af32939107d47943aba242d3189ec6f90
  Bug not present: c11b8d25fbe9c0155e91409594ea6701008409ed
  Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/165662/


  commit f282182af32939107d47943aba242d3189ec6f90
  Author: Juergen Gross <jgross@suse.com>
  Date:   Tue Oct 12 15:41:47 2021 +0200
  
      tools/xenstore: set oom score for xenstore daemon on Linux
      
      Xenstored is absolutely mandatory for a Xen host and it can't be
      restarted, so being killed by OOM-killer in case of memory shortage is
      to be avoided.
      
      Set /proc/$pid/oom_score_adj (if available) per default to -500 (this
      translates to 50% of dom0 memory size) in order to allow xenstored to
      use large amounts of memory without being killed.
      
      The percentage of dom0 memory above which the oom killer is allowed to
      kill xenstored can be set via XENSTORED_OOM_MEM_THRESHOLD in
      xencommons.
      
      Make sure the pid file isn't a left-over from a previous run delete it
      before starting xenstored.
      
      Signed-off-by: Juergen Gross <jgross@suse.com>
      Reviewed-by: Ian Jackson <iwj@xenproject.org>
      Release-Acked-by: Ian Jackson <iwj@xenproject.org>


For bisection revision-tuple graph see:
   http://logs.test-lab.xenproject.org/osstest/results/bisect/xen-unstable-smoke/test-amd64-amd64-xl-qemuu-debianhvm-amd64.leak-check--basis(11).html
Revision IDs in each graph node refer, respectively, to the Trees above.

----------------------------------------
Running cs-bisection-step '--graph-out=/home/logs/results/bisect/xen-unstable-smoke/test-amd64-amd64-xl-qemuu-debianhvm-amd64.leak-check--basis(11)' --summary-out=tmp/165662.bisection-summary --basis-template=165635 --blessings=real,real-bisect,real-retry xen-unstable-smoke test-amd64-amd64-xl-qemuu-debianhvm-amd64 'leak-check/basis(11)'
Searching for failure / basis pass:
 165651 fail [host=godello0] / 165635 [host=pinot0] 165530 [host=elbling1] 165527 ok.
Failure / basis pass flights: 165651 / 165527
(tree with no url: minios)
(tree with no url: ovmf)
(tree with no url: seabios)
Tree: linux git://xenbits.xen.org/linux-pvops.git
Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git
Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git
Tree: qemuu git://xenbits.xen.org/qemu-xen.git
Tree: xen git://xenbits.xen.org/xen.git
Latest c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 3ae80dea4601764818d1e5b84bd1e4479c0d4790
Basis pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 f791392f82ffe39cc1ea4c4db1d877223754a04a
Generating revisions with ./adhoc-revtuple-generator  git://xenbits.xen.org/linux-pvops.git#c3038e718a19fc596f7b1baba0f83d5146dc7784-c3038e718a19fc596f7b1baba0f83d5146dc7784 git://xenbits.xen.org/osstest/linux-firmware.git#c530a75c1e6a472b0eb9558310b518f0dfcd8860-c530a75c1e6a472b0eb9558310b518f0dfcd8860 git://xenbits.xen.org/qemu-xen-traditional.git#3d273dd05e51e5a1ffba3d98c7437ee84e8f8764-3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 git://xenbits.xen.org/qemu-xen.git#b6e539830bf45e2d7a6bd86ddfdf003\
 088b173b0-b6e539830bf45e2d7a6bd86ddfdf003088b173b0 git://xenbits.xen.org/xen.git#f791392f82ffe39cc1ea4c4db1d877223754a04a-3ae80dea4601764818d1e5b84bd1e4479c0d4790
Loaded 5001 nodes in revision graph
Searching for test results:
 165527 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 f791392f82ffe39cc1ea4c4db1d877223754a04a
 165530 [host=elbling1]
 165635 [host=pinot0]
 165638 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 3ae80dea4601764818d1e5b84bd1e4479c0d4790
 165641 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 f791392f82ffe39cc1ea4c4db1d877223754a04a
 165644 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 3ae80dea4601764818d1e5b84bd1e4479c0d4790
 165645 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 52d0847d7c6972baa74156f14ee8544f5aba1d2d
 165646 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 c11b8d25fbe9c0155e91409594ea6701008409ed
 165647 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 f282182af32939107d47943aba242d3189ec6f90
 165648 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 c11b8d25fbe9c0155e91409594ea6701008409ed
 165642 [host=chardonnay0]
 165649 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 f282182af32939107d47943aba242d3189ec6f90
 165650 [host=chardonnay0]
 165653 [host=chardonnay0]
 165655 [host=chardonnay0]
 165656 [host=chardonnay0]
 165651 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 3ae80dea4601764818d1e5b84bd1e4479c0d4790
 165659 [host=chardonnay0]
 165660 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 c11b8d25fbe9c0155e91409594ea6701008409ed
 165662 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 f282182af32939107d47943aba242d3189ec6f90
Searching for interesting versions
 Result found: flight 165527 (pass), for basis pass
 For basis failure, parent search stopping at c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 c11b8d25fbe9c0155e91409594ea6701008409ed, results HASH(0x564bc7595060) HASH(0x564bc75a4168) HASH(0x564bc75931d8) For basis failure, parent search stopping at c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830\
 bf45e2d7a6bd86ddfdf003088b173b0 52d0847d7c6972baa74156f14ee8544f5aba1d2d, results HASH(0x564bc7598770) For basis failure, parent search stopping at c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 f791392f82ffe39cc1ea4c4db1d877223754a04a, results HASH(0x564bc75945e0) HASH(0x564bc759b520) Result found: flight 165638 (fail), for basis failure (at ancestor ~90)
 Repro found: flight 165641 (pass), for basis pass
 Repro found: flight 165644 (fail), for basis failure
 0 revisions at c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 c11b8d25fbe9c0155e91409594ea6701008409ed
No revisions left to test, checking graph state.
 Result found: flight 165646 (pass), for last pass
 Result found: flight 165647 (fail), for first failure
 Repro found: flight 165648 (pass), for last pass
 Repro found: flight 165649 (fail), for first failure
 Repro found: flight 165660 (pass), for last pass
 Repro found: flight 165662 (fail), for first failure

*** Found and reproduced problem changeset ***

  Bug is in tree:  xen git://xenbits.xen.org/xen.git
  Bug introduced:  f282182af32939107d47943aba242d3189ec6f90
  Bug not present: c11b8d25fbe9c0155e91409594ea6701008409ed
  Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/165662/


  commit f282182af32939107d47943aba242d3189ec6f90
  Author: Juergen Gross <jgross@suse.com>
  Date:   Tue Oct 12 15:41:47 2021 +0200
  
      tools/xenstore: set oom score for xenstore daemon on Linux
      
      Xenstored is absolutely mandatory for a Xen host and it can't be
      restarted, so being killed by OOM-killer in case of memory shortage is
      to be avoided.
      
      Set /proc/$pid/oom_score_adj (if available) per default to -500 (this
      translates to 50% of dom0 memory size) in order to allow xenstored to
      use large amounts of memory without being killed.
      
      The percentage of dom0 memory above which the oom killer is allowed to
      kill xenstored can be set via XENSTORED_OOM_MEM_THRESHOLD in
      xencommons.
      
      Make sure the pid file isn't a left-over from a previous run delete it
      before starting xenstored.
      
      Signed-off-by: Juergen Gross <jgross@suse.com>
      Reviewed-by: Ian Jackson <iwj@xenproject.org>
      Release-Acked-by: Ian Jackson <iwj@xenproject.org>

Revision graph left in /home/logs/results/bisect/xen-unstable-smoke/test-amd64-amd64-xl-qemuu-debianhvm-amd64.leak-check--basis(11).{dot,ps,png,html,svg}.
----------------------------------------
165662: tolerable ALL FAIL

flight 165662 xen-unstable-smoke real-bisect [real]
http://logs.test-lab.xenproject.org/osstest/logs/165662/

Failures :-/ but no regressions.

Tests which did not succeed,
including tests which could not be run:
 test-amd64-amd64-xl-qemuu-debianhvm-amd64 11 leak-check/basis(11) fail baseline untested


jobs:
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    fail    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary



From xen-devel-bounces@lists.xenproject.org Tue Oct 19 06:55:03 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Oct 2021 06:55:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.212745.370735 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcj1L-0000Lu-Mp; Tue, 19 Oct 2021 06:54:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 212745.370735; Tue, 19 Oct 2021 06:54:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcj1L-0000Ln-Jb; Tue, 19 Oct 2021 06:54:47 +0000
Received: by outflank-mailman (input) for mailman id 212745;
 Tue, 19 Oct 2021 06:54:46 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=gzZp=PH=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mcj1K-0000Lh-K0
 for xen-devel@lists.xenproject.org; Tue, 19 Oct 2021 06:54:46 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 70936eb6-30a9-11ec-8301-12813bfff9fa;
 Tue, 19 Oct 2021 06:54:44 +0000 (UTC)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2052.outbound.protection.outlook.com [104.47.13.52]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-30-Cm-Xu-cPONO7WGF20K7ATA-2; Tue, 19 Oct 2021 08:54:42 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB7150.eurprd04.prod.outlook.com (2603:10a6:800:12a::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.17; Tue, 19 Oct
 2021 06:54:38 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.018; Tue, 19 Oct 2021
 06:54:38 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM5P194CA0018.EURP194.PROD.OUTLOOK.COM (2603:10a6:203:8f::28) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.15 via Frontend Transport; Tue, 19 Oct 2021 06:54:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 70936eb6-30a9-11ec-8301-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634626483;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=CKrFvbS7tBHkYCpKzYSqrGy/08dg8BMVxRhNRepJzt8=;
	b=TshYBZVWoinlRHAK3sEi8gznoemho0Ax5WuYcNCfZivD+iLwbmURmFZRqActdfzQBiUJss
	ZVVfphc+JAqe2lxAPYk3w0T4YjjV7bRyT4lq9qnOrnluZjmuXBLaSvQdAsX06fVocUDOHL
	aI3I+OPE/4jZVZQkEL7UigXNWB1MDcE=
X-MC-Unique: Cm-Xu-cPONO7WGF20K7ATA-2
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=H01QLQnivtzMGVFLHNpUIc0UGQi4vvhDtqU/9mxpsjMIPkIEcI5cYBZYKov2ju66++1FATBCEXZxi1/9j0IQ2/ZRc9WbUx3lEZsmlveiT/eyizl9ojwEPu0iMeTxUw8cNXpUioEx6AHgzhUQLxdyt2pLhyTwevjyW0TXS7TBW6CBG/mm5TRMWaIpl+5qX6mwBD7UA+71SGdlYhF/Tx8f6sBOkite6HmlMZo50vtYRT7E9YVM+QPTEU3HvtdJtVt49qHKMSXL9JXfBgWpTNm+21JNiGMpOVyYd5GI4XLfAU22QGb0BnlmbvvvZhuNepgmOEYTNNt7kXwiCiODSLU1rQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=CKrFvbS7tBHkYCpKzYSqrGy/08dg8BMVxRhNRepJzt8=;
 b=lE297hY5mhrk8XVrfSNfvkq3psBOCAN1uqLhzru0kroDUzuTz3pzuEHad1uBEXz0H2satsbnlIi4rCtXiosWGYysXCJLisR96OMWFPKf+3AdE6wOyxTwCqwq0Dms4JgMSP1sXxz0Sce8QzmXBenshTtz2H/Xe9EK/T9pxCkLDXa8887MWKEKRJoYt2NUrgSvrgJtKmYNCxYcrCVDsSHKpkIYmidDJv4rnGJoJ4SLYlnfX8qWxxotzJFNGYs7wWVToyMW0z+jAC31v8yMrz2z0tJrjDFcGKXaYkmG1JSAkrQHCxVw2krnF2Sdpid5M5mDmUG002Nlh/+bQ2EEXSo59g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [PATCH] tools: fix oom setting of xenstored
To: Juergen Gross <jgross@suse.com>
Cc: Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
References: <20211019044123.29648-1-jgross@suse.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <0c93abe3-3908-009f-efca-08000092cd4d@suse.com>
Date: Tue, 19 Oct 2021 08:54:36 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <20211019044123.29648-1-jgross@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM5P194CA0018.EURP194.PROD.OUTLOOK.COM
 (2603:10a6:203:8f::28) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 8e538191-a578-4a5b-7bd2-08d992cd517b
X-MS-TrafficTypeDiagnostic: VI1PR04MB7150:
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB715064A098FDA9D82506D0CBB3BD9@VI1PR04MB7150.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6430;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	XKSaBzh1V+9aHADfo/k1MfGZIzEkV0Gq7sK6MLaJYWqMBey/pz28qOVnAnBTUQ1KCKyW00GbdULCKPhrjwEi9yxp+XzenlOOrk/fVxWGXqQFofRg7RpvvaHjORE78awqTov/NGm1Y35Xvp+OiX5Sv16NrtLxxTloyR060Cf4zUtqYQxtxpPJ8Myh059WSWR0m2Ngskdo/RVf3ll05JRJi989EB/tpnvAhS/gvWx0Pn1qjYuKAF0TmuFR75Oml4q5NjNMIYend8LDR57zQHZypEqGJw58LyCJi5QQ0OOQZXcWQ3Ag7QKlDfIqlv+Qlup/iOGb4OsLvpn/ui8ePo5Fah69AgwwZpaCxtsLZSR7RxmX4vGQh/mQiohtHWsbzSFVvSYNogA9zFKwA2RcALPZZkKJvAFQ3p/3zA9rst17Vvccovkl80a1A53wk6wC+qqQjM69XUNf3GOb1pwQ7uV47Bm8lic5//vOAIEtO7brnBfxGa4OgfioBQOERd5OSZQJtiHPvtyucoLQkf2LMEBVfxPNDGck2S2SCqCeL+lgvZTD9/BkmUDwBwJGH2y5wgF4o/KHzz+ftNTEIJN8lb/iaTfPt1Id3WZMEWwGq4cY5VYrRg0wOsqJfvICmDe+XieuaEIVNMofVt+aNRebhy8jpPMY0yKqdeHOhMk6OYCU9dApVD8TRPOTHUgZcBKZBnIaL5+eNN6K1fQ2VuXvr6RUgHnbOaCztp7wvkzRGcQvvx0=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(2906002)(66476007)(66946007)(186003)(6486002)(956004)(86362001)(316002)(6862004)(508600001)(8676002)(38100700002)(66556008)(16576012)(53546011)(5660300002)(4744005)(2616005)(26005)(31696002)(8936002)(54906003)(37006003)(4326008)(31686004)(36756003)(6636002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?WWhYNGZHWS9HRlk4TzdBTFZ4amMrSDdGMUtlbXJnRlFLUFl1UnFVNU5sRWhE?=
 =?utf-8?B?TUJ5M3dpdWNWRE5uT3pjaXpaYWNGRXk3UXlaamhmdU1Lb1crU3NjR2RoU2xh?=
 =?utf-8?B?SlRmcWlvSCtWMFR0Q20zMGQwVVR2RWJGb1VtKy9mRmRrWnRrQ2Y4M08yY3lP?=
 =?utf-8?B?Ty96UlZya1p5aGM5U2RDZzVzaE5iUVQveVV2bTAvSC9wcFdHenkzeHltbkZC?=
 =?utf-8?B?L0VaSjd0cVkyM0I2M3pDa3E0MW5YTzdnOGk0V2pLQzhVR2VkV09WZ2QzckZu?=
 =?utf-8?B?U0ZFRzJlQVJHdE91eUhaMkVRY1F3eUc1cDN2MTNRbkl1di83UXF3czAwOGpV?=
 =?utf-8?B?ajdxWlhNc2pWdkV5R3J2VW1MbSttck1vNDEraU5LeUFERy8zbWIyemIzdkVO?=
 =?utf-8?B?UUhLdzFVTGdRNHRUSHhBR2pDTjR3Q3B5b1RDcU42MFV1YXFiczhxUDlab0gr?=
 =?utf-8?B?MEppVGg1Y2ttNHpSSFdva0l1T0V5RnNNVUlrdHZmTGRJcnRRS3E2UGp1aHFj?=
 =?utf-8?B?cUduWlZVeUtBWFQ2ZkRzekpqSDZrU3BKdWhkdkZwYmkvS28xODlzbFlKdzdo?=
 =?utf-8?B?ZGRQMDFCb1lMRVVtRUROcHA0T1N6bmEzclRCdlc0c1J4MWY1OERvdlYzRXY2?=
 =?utf-8?B?WHlsUWtJU1I4T0hhSkVmMU9YUDZPRjhPR1JUZmZuZ2pjQUxJVlQyVlF3eTc4?=
 =?utf-8?B?R01CWVpBT1VFd055bko1WGswcVZ2cDJ4LzV6TERPN21LYS8wNFA0VVg4L0Zu?=
 =?utf-8?B?bEM4NVR1ZEdDVFJ0OWVXWjhrd3JMdFBvMVRJWnhHbzZycjBESDhtREIxdHpY?=
 =?utf-8?B?N0JnMlVQdDlieHpuSEpFM0pnSm1pMVdZbHA3NzBxZjZpaU5NcXBYeFUvUWUy?=
 =?utf-8?B?ZTZ2a3c0RHFZQWxoYk9tak8vOHZGb0pNZnBSd2VNVFovbjhTeUFRcHEyYjlE?=
 =?utf-8?B?NnRQeGFoR2Zsd1IzUkx1aC8vTEtndmU2Ymd3ejBPbjlmdjNUL0lQZjF2MVJn?=
 =?utf-8?B?N0YrY0xTVEVUQTJLQm1UTkNHOVRHUUwyNmtsWVJOYVM4bXZaRkwrOElQUFhN?=
 =?utf-8?B?bGJaUTg0cCtwTmYxRWdySXBrL25iTDlJYWpGeGhLRzdPdllReUR6ZmRpdDhU?=
 =?utf-8?B?dUJpSzg1TUQvMzMxaWdPV0d0aWFwb2ZDeXE2Y0ZIWlFHamhzdEEvSi9yTHBw?=
 =?utf-8?B?VEpFY3JmU2RVUXNzdFhHMkRwbEgzRk9JSjNENkUzdkNHVldZblFGZE1EZzFu?=
 =?utf-8?B?bklyWGI1SkpSY0QwYmRKelo5L2t2K1ZrbmZaS0VCWXZTdEYvbW5rOVZqeEIz?=
 =?utf-8?B?aHd4QTNhN25LclJOb1RjamwxMzFkZXdYd0pJdGVLOVlLYmNreno3bEdEVnZw?=
 =?utf-8?B?VTVERXJPdTFVNTJEUXlaK0lqajg4VHlMQXVvNURPYjVNTWc0alNPaVJPSTVw?=
 =?utf-8?B?UHpLT0x2YzF0czV3QlJGdVUzd29BM2ZjeFJyMzBQQkZIRjB5MEFrSWV3NHZK?=
 =?utf-8?B?UitMWXo0R1pGM0pLMXI1NlBjdFM4Z0ovVytXd1ZnV3ZoZ3dUbGNyaWpaa1dL?=
 =?utf-8?B?cTBoWWs3Ry9Wb2Z2YW56Y3lZTTNzRDJJUzMvQlBqbHprN2toL0dKZUl6VHo2?=
 =?utf-8?B?VnFLSXVva09wVE9wd09rd1VKZGpaa3BqS1dVZHI3eU5YazBWbXNSZzNhNFd0?=
 =?utf-8?B?NGg3VzIvSlQzREo2dnZYYm1pZmMrb1FJWDBCdm4vc1FHSUkzZDM1VjFqNkU0?=
 =?utf-8?Q?9j/bkT3Q8S9lTUL/ntRPN/5FqnBr3RqSYoNtUAm?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8e538191-a578-4a5b-7bd2-08d992cd517b
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2021 06:54:38.5872
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: AH1GIBEjrU/WsbsUlsF9CTyKmR/m+W3PoBUoNaZ19xAdnFEC8+ycYbzVM9nUtCXULLr3YZV5Etja/xzYMWkw0w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7150

On 19.10.2021 06:41, Juergen Gross wrote:
> --- a/tools/hotplug/Linux/launch-xenstore.in
> +++ b/tools/hotplug/Linux/launch-xenstore.in
> @@ -60,7 +60,7 @@ test -f @CONFIG_DIR@/@CONFIG_LEAF_DIR@/xencommons && . @CONFIG_DIR@/@CONFIG_LEAF
>  		echo "No xenstored found"
>  		exit 1
>  	}
> -	[ -z "$XENSTORED_OOM_MEM_THRESHOLD" ] || XENSTORED_OOM_MEM_THRESHOLD=50
> +	[ -z "$XENSTORED_OOM_MEM_THRESHOLD" ] && XENSTORED_OOM_MEM_THRESHOLD=50

Is resilience against "set -e" being in effect of interest? If so I
think this would want to be

	[ -n "$XENSTORED_OOM_MEM_THRESHOLD" ] || XENSTORED_OOM_MEM_THRESHOLD=50

>  	XS_OOM_SCORE=-$(($XENSTORED_OOM_MEM_THRESHOLD * 10))

Alternatively, how about dropping the line above and using

 	XS_OOM_SCORE=-$((${XENSTORED_OOM_MEM_THRESHOLD:-50} * 10))

here?

Jan



From xen-devel-bounces@lists.xenproject.org Tue Oct 19 06:58:26 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Oct 2021 06:58:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.212729.370758 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcj4r-0001Gk-V1; Tue, 19 Oct 2021 06:58:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 212729.370758; Tue, 19 Oct 2021 06:58:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcj4r-0001G4-PL; Tue, 19 Oct 2021 06:58:25 +0000
Received: by outflank-mailman (input) for mailman id 212729;
 Tue, 19 Oct 2021 06:34:18 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=cA3S=PH=nvidia.com=chaitanyak@srs-us1.protection.inumbo.net>)
 id 1mcihW-0006NT-KV
 for xen-devel@lists.xenproject.org; Tue, 19 Oct 2021 06:34:18 +0000
Received: from NAM12-DM6-obe.outbound.protection.outlook.com (unknown
 [40.107.243.59]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 95b492a4-30a6-11ec-8301-12813bfff9fa;
 Tue, 19 Oct 2021 06:34:17 +0000 (UTC)
Received: from MW2PR12MB4667.namprd12.prod.outlook.com (2603:10b6:302:12::28)
 by MWHPR12MB1262.namprd12.prod.outlook.com (2603:10b6:300:12::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16; Tue, 19 Oct
 2021 06:34:16 +0000
Received: from MW2PR12MB4667.namprd12.prod.outlook.com
 ([fe80::3db1:105d:2524:524]) by MW2PR12MB4667.namprd12.prod.outlook.com
 ([fe80::3db1:105d:2524:524%7]) with mapi id 15.20.4608.018; Tue, 19 Oct 2021
 06:34:16 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 95b492a4-30a6-11ec-8301-12813bfff9fa
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=iWqay5/OTQTUE0xqioS84Fkb1wVKj/T3J9t+J+UcfDQ6By//tinEqRkSwzfmL+l0DyLI4GZHldU1JQLE1aRQAy6Pe2yVgXz/Xrdjoeax9m6N08DzHKAaUYfExYnUtIkt2wcfPjTbc5OMGJWj+scOCp3o+PlEroS1ZkahaOpH4EcsBgfA14lRGyy50YNPqSaE9eAFehEwVaJqjxhR6ULkZQLH1xhld2wiZCjJF2/wJ/ZN/WsRKMJrW4ic0aubE3CzY/vUF/+jAqU0DN0k6Q9Mc1jI/6+1mxIeSj29skQYQxNtDAMOavwX99AVZAOO0FXhyfpv4rbBkWKhmzUO01ZZ0g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=wGeftFVmllChdrlBg622+mYWtlVrvDYxEqmAQBvD2+8=;
 b=gwCIj6p3HRIwXdhGemke6fga0/MvPP8574dUSNFo86rNrzNTiBwv74B0AIutHKHC0GmjbbHsYeVnCSqT1wfH8RXKhJ+R+1TTKOtdo35uWD3x3DeRRvBZfkVzUoa+xKeucODcoYmv7mO0M2RmS0L5doqtYKurHc3edXhMKDlIYON3aV4+9VDQXa3h3cYsNum4WpqMhdPmdayXT19i5V6gr2rFrrj51GHpXEHszKQwvTLCGHZcozRpbGFV3edeK/oD0bIU+E8EiOcBNJmrEEgmV9EPJfvulrDjWya/5URHHXo8vNBkOVRyXsuBYwYlmx3NnBKYh0dSaaq14ZRihtdavQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com;
 dkim=pass header.d=nvidia.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;
 s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=wGeftFVmllChdrlBg622+mYWtlVrvDYxEqmAQBvD2+8=;
 b=msiiaE4C7vGEtJbvhBLwnrmDYBMz/QLqIa7fHHJ+0W1u62w1/6Pybc+p6eTFc8gajnnt4kaH5xnIdxA6J3Ejv9IuhqX2+kf++xAOtr/SNb96w19FX/cdEbwYc6SqnZQk8k1fzJtbbuzA+gABrCl3dufzsvNNFKqGORkZwndlDxs5fzFwOqL5zVLa7Q3IRM2azIyhA7b3pLPIAM2hf0qkTjfNyQ3eqBs+GJ7a5Cec6A6HmTsNIT0AdjQ9/p6mmo1kw0Wj03IdTHkudSwCVL6f04JFNzwMiJpwfTNdN2eRaqByh1+HAIRO8TGXi0XOlGRq0xpXlc0Zi7L8+m3OKt9UyQ==
From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>
CC: =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>, Josef Bacik
	<josef@toxicpanda.com>, David Sterba <dsterba@suse.com>, OGAWA Hirofumi
	<hirofumi@mail.parknet.co.jp>, Konstantin Komarov
	<almaz.alexandrovich@paragon-software.com>, "linux-block@vger.kernel.org"
	<linux-block@vger.kernel.org>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, "linux-btrfs@vger.kernel.org"
	<linux-btrfs@vger.kernel.org>, "linux-fsdevel@vger.kernel.org"
	<linux-fsdevel@vger.kernel.org>, "ntfs3@lists.linux.dev"
	<ntfs3@lists.linux.dev>
Subject: Re: [PATCH 4/7] btrfs: use sync_blockdev
Thread-Topic: [PATCH 4/7] btrfs: use sync_blockdev
Thread-Index: AQHXxLIzGX9IlGUCzEq8AQPwrekYtqvZ3UgA
Date: Tue, 19 Oct 2021 06:34:16 +0000
Message-ID: <6842781d-bb01-0f56-61e0-944cf24409c3@nvidia.com>
References: <20211019062530.2174626-1-hch@lst.de>
 <20211019062530.2174626-5-hch@lst.de>
In-Reply-To: <20211019062530.2174626-5-hch@lst.de>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.2.0
authentication-results: lst.de; dkim=none (message not signed)
 header.d=none;lst.de; dmarc=none action=none header.from=nvidia.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: d1367a1d-8eb1-4fab-3ff5-08d992ca796d
x-ms-traffictypediagnostic: MWHPR12MB1262:
x-microsoft-antispam-prvs:
 <MWHPR12MB1262EE72E5A3050331F928C8A3BD9@MWHPR12MB1262.namprd12.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:530;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 f3PR0TcO4MSjfvSW7PNcETaSNPL8Zeng/f3v8Y2/fTOXg2IcZQXoS4lv5mVwaSPSDcF1vNXbEwQRDWk/Kj8AwYEg95aLwIUtaASu7DqN+DVI7djEKhsExCBKlDTuTjLdf+Sp7OxoWelqVeyIIDv1YpKjHKy6q7T724/M7J48i7+VczivgByy7k0HCEHDYuyhqHvcviZnG4aVuT4UohfMw9RlnGMoblj/+Qo+PWSdpevnkDU746pH5095IAambayLf/799hVmewesjtFsycgrp7wl0zTdGX74Spwip4XAF6/1DEDE99vzZlYVS2bo78ki2eGxndG4DapljQKqEtD1xh2VsNX/rYnyNwCOijXXVeacuzOa5hocwxZNDVhpNzYIh0U5kSebSrSB6TvHmRW0m0Nxi5/AO31flrQ9BpXoPGxRLJoixLX8VjhmisBH/ZsRETL9mD09GmDHXf0YS5sD25AJf3tzn7rY8H9d7EIAFikqN7O8+r3R9Jk+EHIfkpzYJerDuyyIfCo5qthPNu4GKbF7ik9EpdJY3YlE50QqaFt1FMGxAApNsIkZUs/hANlX4uSUcoHEfZ5EFawYLn3vw94IRtNwY5CwpUYvoDb3P75DVM+0vFi+ro8BavhExU9prhNI90t2HtX0aq3HJpmJ7V45UART/y8iO3ng14jFRPE0fe/wi0A4dg7Si30ZtyI6Uqwz21/A3tXD5RAUaGvjaplkPwsMBPxTcqJp2dz0FKqlyLR8wylouR0dx1+ZOoYLCgjgR2glSd0ujTaQGUyIfg==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW2PR12MB4667.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(66476007)(66946007)(5660300002)(7416002)(508600001)(64756008)(83380400001)(2906002)(36756003)(6486002)(110136005)(186003)(66556008)(38070700005)(122000001)(86362001)(8936002)(53546011)(8676002)(31686004)(316002)(76116006)(54906003)(71200400001)(2616005)(6512007)(4326008)(6506007)(31696002)(91956017)(66446008)(558084003)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?MGVWUFozcFVsQm9tcWs5N0pTNlNHSVo0dHVydk1LMktiZ0Z0RkpEd2R2ZG5n?=
 =?utf-8?B?cWJwTi9jcGxreEMrRXJZdGRZdXZCVjZnOUFvMVBGTmtCT1EreDc3bXRBa0JP?=
 =?utf-8?B?Mm15amdtN3hvU0NlV00xMEdQM09VbzErWEU2R1dieE0yMDg0Zk54L1haTTdx?=
 =?utf-8?B?MnBtdDlPdzU4RkFpeGRja2lNdjRYU3lDYVpSMkhLT1RHazA4djMwZjFINWN2?=
 =?utf-8?B?QjE0ZzNXRmw2UW85UU41OEI2RTFCekhpZnJtcklUZE9JUDdFNjhCL0NVSjBv?=
 =?utf-8?B?N0M5aW94OVJwTzRYcEIxN2F1YjZpVG5YY2VsOXZ0d3pXM2FlMEdkdnRwMXdM?=
 =?utf-8?B?WkNHWmhQYVM2S3Q4d1l4azRWNGUvMU1Sa2dlSnJEcTlhc0QyS3Ivc2krWXBJ?=
 =?utf-8?B?NlRWQzFYTDhRNitoclI5eGdZZlUvcTA1Y2UyWWVENjExdnZ2UjZ4azhzdm0y?=
 =?utf-8?B?NDYwMWYxeGlLbTcwamQ0ci9jcVYrZmVraFl6M2IvdkZaam8xa1FmR0d4bEtR?=
 =?utf-8?B?bDJjVis2b0I2V1RyNzJNQ3h0Mm9DdVB0UEZIRVRMa2w0MVZ5T1grRllQcCtJ?=
 =?utf-8?B?Zng0Y285eHYwZG5iRzl0cmQ4T0ttaXVCTW02YlpuR2NERnNCQkJaTVNyak9j?=
 =?utf-8?B?bWtLZC96bm56TDluWTFiajRiVTA3NnE3aVdnTDgrWi9Gb01UMWRzM3gzSHpw?=
 =?utf-8?B?b0FtTFl5N1V5RmprYkpmNWZVQ1JZenh0Ums5dTlpaVNMeTJZdmNKZlYrSDdW?=
 =?utf-8?B?elc5M21UdFFyUEdvVVJoS3RvRHhvdkhERWNqaFIzV0pscm5Gdzd0cjVpTmVq?=
 =?utf-8?B?VWhPV2ZRRFlBcjcxa0xoVUZxckVPQ2tyOXp2UUNrWG5hTmprWW5BRDdTRzBq?=
 =?utf-8?B?UkRYU05XSXg5dDJIekUvSjd1amEvcmEycjhKc2tKTXEzc09FQ1orekhsa1FR?=
 =?utf-8?B?bXpCaVl5aEZYZXd4cGV3M0JPQjBlYm1TTDU1YlBtQW9mUVNRSy9EMS9Kem1O?=
 =?utf-8?B?ajBGc1BiRXJDWllIenJTY0NRNDF3OFdEUTdFUENoQ0p1Sy9PeS9mUnFTNWFQ?=
 =?utf-8?B?Uzc5VEVwR2hyRnZJQjR4Wm16b0lyOEVOK1d0QmhMTTAyL0txd21ZSm56RmxB?=
 =?utf-8?B?VitGcmU0UTZJTnp2YU5jU3haYnpMN3BZNFhueUdKYk85VUxTM2VxUjc2WWM2?=
 =?utf-8?B?NlFNNzhLdVpkTjN0RFdRZlo3NktRTGtiRThrcm5YQTU1NmFCeGZXMjdFSVhi?=
 =?utf-8?B?OGsxSUFGY0VqWStXT1Z2MEFJbXp2ekloWlJ3c2xlS0hDZllLeVg4eXozTnlq?=
 =?utf-8?B?WFBhQmttK2VCMXA3UmQrMm9OamQrNW1vZFRtN1lxWDJUNEVSUVNBaHVHRmRC?=
 =?utf-8?B?cnhGeXU3bUJSUlBXeFZSenVVV0VnUHo5QzFNWjhZWTJxYmZlQVdZZTBPSlRo?=
 =?utf-8?B?ZEozdGxXeDVZQ2RURnZlUGVudDl4Vkl2VGluRXIxNnorZTJzam96MVNJUmRy?=
 =?utf-8?B?b05BMVFYVmZxWldmUU9udnIySUhPell5YTlxTW9UNzFsd09hU2pJMmsyemJn?=
 =?utf-8?B?aHhyK1B6QWR3LzZrQjkyckxSUjFpL2V0M0xsWGVFckZSZFV3QWl3b1VlN2JV?=
 =?utf-8?B?QnZMMXNZZERuc0NsQlpXdEtib1JuakNTZG5BM2hubjZDaGszVG1Hc285N3Ex?=
 =?utf-8?B?U1Y2OFNHZ2gzMHdGQ0RKVUt4ampFM1lCMnhINEVJQUd4NFd4RTlVQ3VmWUor?=
 =?utf-8?B?Zm5KeFRid1BBeFp6Zi81bGpUQXM0WDBQdVpDQVpVcGxad0E5T3Y1Uy8yTFNB?=
 =?utf-8?B?cVh1SkdVNzZJRDFEV3RGdFM0azhZcjJacEFMMm5CUnBnUlVUZktkdENJQk9C?=
 =?utf-8?Q?1daHdeCZdvm6b?=
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="utf-8"
Content-ID: <9DCF089D89ECC34E89C06309AF18F139@namprd12.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MW2PR12MB4667.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d1367a1d-8eb1-4fab-3ff5-08d992ca796d
X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Oct 2021 06:34:16.6468
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 0o6ag+8hMxviGYgKOlR9X2tVwTjEtf3KJ9e1PyUh1e7chwjODKdzfJsaCT2zIKDD22YXlRNveX5YOecFnx+rBg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR12MB1262

T24gMTAvMTgvMjAyMSAxMToyNSBQTSwgQ2hyaXN0b3BoIEhlbGx3aWcgd3JvdGU6DQo+IFVzZSBz
eW5jX2Jsb2NrZGV2IGluc3RlYWQgb2Ygb3BlbmNvZGluZyBpdC4NCj4gDQo+IFNpZ25lZC1vZmYt
Ynk6IENocmlzdG9waCBIZWxsd2lnIDxoY2hAbHN0LmRlPg0KDQoNCkxvb2tzIGdvb2QuDQoNClJl
dmlld2VkLWJ5OiBDaGFpdGFueWEgS3Vsa2FybmkgPGtjaEBudmlkaWEuY29tPg0KDQoNCg==


From xen-devel-bounces@lists.xenproject.org Tue Oct 19 06:58:26 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Oct 2021 06:58:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.212725.370747 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcj4r-00016V-AT; Tue, 19 Oct 2021 06:58:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 212725.370747; Tue, 19 Oct 2021 06:58:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcj4r-00016O-6Z; Tue, 19 Oct 2021 06:58:25 +0000
Received: by outflank-mailman (input) for mailman id 212725;
 Tue, 19 Oct 2021 06:33:04 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=cA3S=PH=nvidia.com=chaitanyak@srs-us1.protection.inumbo.net>)
 id 1mcigJ-0006La-Vc
 for xen-devel@lists.xenproject.org; Tue, 19 Oct 2021 06:33:04 +0000
Received: from NAM12-DM6-obe.outbound.protection.outlook.com (unknown
 [40.107.243.80]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 6889a544-30a6-11ec-8301-12813bfff9fa;
 Tue, 19 Oct 2021 06:33:02 +0000 (UTC)
Received: from MW2PR12MB4667.namprd12.prod.outlook.com (2603:10b6:302:12::28)
 by MWHPR12MB1262.namprd12.prod.outlook.com (2603:10b6:300:12::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16; Tue, 19 Oct
 2021 06:33:00 +0000
Received: from MW2PR12MB4667.namprd12.prod.outlook.com
 ([fe80::3db1:105d:2524:524]) by MW2PR12MB4667.namprd12.prod.outlook.com
 ([fe80::3db1:105d:2524:524%7]) with mapi id 15.20.4608.018; Tue, 19 Oct 2021
 06:33:00 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6889a544-30a6-11ec-8301-12813bfff9fa
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=FNuOoiNsx1/FHJsfp54axQLE/+3bN/gl9Iux9VardD19HamvJXiJTcJv0trtYVj32hVb2P+pjRe8lpZuOV3/7CstEJc36QnJjgZPV0ZAqW+KyW3fbvwdBS53uRLMk4cDxR38IiUEm/2nmgSt0wBWBvIZkWxn/+oAGGo0lE2VdyzGuGHBivMv+XtFHh0XY/iukc74D3ZAemhvwEzFpcAve3W6AfDyE+pMV2GgnK1/uwElMVoz7smLITM6hV+cP97sz5XxmlvbN2LbAs9pKKSrf4GDiOUyRcU48Z5vu+7xpAGpzN+Bs4UsBwn21WziIRK8bmvJNo/EC0DAfB6g4v5xUQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=U2HxfBZTSi3BiVqoiVet04dkczzLVkaskpQSpA/YG+U=;
 b=gezdel1F4b1RrY9ZRyQx0khy7BUnjqBm3fXam3NrcoZ8tchV+hjPsPDJvatJCS/ZQVcFnzBwIfVGF0Teyh4xd03C9ttGjsfrQ3tivVlNway6bPJfY3PyOG365C1uRgVVSHfFuD9S8P5VitL2Al6JtTPzcixhX2sahm4glf1x4KNelos84pZP8p/oUPkKCR76I+CpQ7l22oRlLvyJZ/OyPcgQJS9LLgBXYGAdLTkD6YtnSwkhXfmMhSrUH3G4gJRek1fs8fDa491DhiB/TalGKRyoGUly/MHHSpCz8TCFxlZdfGCzZEO2vmThjiaGBiJ9vsnuuP21KVcAf0OiIsOuIQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com;
 dkim=pass header.d=nvidia.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;
 s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=U2HxfBZTSi3BiVqoiVet04dkczzLVkaskpQSpA/YG+U=;
 b=uLoSshz8N1uCxxYuEAegD3ybkP9e9o96mItwTaeWWXyccGXeoWa0fAWfJS5toPkH2vY3o90uSR52JVh6kLmeVoyLSWPlNN1n9nU0m9Q69OOmIIk/KZgpw7SxoUPtWtf59yoej/x9TS0naUSuv224ayaJynHudO6eQvGYbGCcL/xTkzKI6kewxMVZJH5S38qvCkdD5iNz9Frd3ddzowjOauitKQ7WbUyJtOnWwO3e08QHX2kcOZGYC7Dk7IeTnuLkYPxSINbcBQSZFoYIYshqKd3CIBFBeXgmLAUsofJYcgibt4VQTjNXachMPkUcYcYngex8JtyRdMlYYr3lP6KEIg==
From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>
CC: =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>, Josef Bacik
	<josef@toxicpanda.com>, David Sterba <dsterba@suse.com>, OGAWA Hirofumi
	<hirofumi@mail.parknet.co.jp>, Konstantin Komarov
	<almaz.alexandrovich@paragon-software.com>, "linux-block@vger.kernel.org"
	<linux-block@vger.kernel.org>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, "linux-btrfs@vger.kernel.org"
	<linux-btrfs@vger.kernel.org>, "linux-fsdevel@vger.kernel.org"
	<linux-fsdevel@vger.kernel.org>, "ntfs3@lists.linux.dev"
	<ntfs3@lists.linux.dev>
Subject: Re: [PATCH 1/7] fs: remove __sync_filesystem
Thread-Topic: [PATCH 1/7] fs: remove __sync_filesystem
Thread-Index: AQHXxLIm30uqtC6wVk2XNPvmvYapJKvZ3O4A
Date: Tue, 19 Oct 2021 06:33:00 +0000
Message-ID: <924759c1-be53-ac11-2f9d-18651a91a4e8@nvidia.com>
References: <20211019062530.2174626-1-hch@lst.de>
 <20211019062530.2174626-2-hch@lst.de>
In-Reply-To: <20211019062530.2174626-2-hch@lst.de>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.2.0
authentication-results: lst.de; dkim=none (message not signed)
 header.d=none;lst.de; dmarc=none action=none header.from=nvidia.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 3b6fcd47-592d-47ae-f829-08d992ca4bd5
x-ms-traffictypediagnostic: MWHPR12MB1262:
x-microsoft-antispam-prvs:
 <MWHPR12MB1262A70062E4670879E45810A3BD9@MWHPR12MB1262.namprd12.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:2958;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 JcfqeD73viFeQKJujuN8eDAn2extZwp90e+esAJnIeXbA53PiqTgGG36knjA2v/aDUxEWo2cNbAOGqdPS1GByd2fxpbqcUt+xi1tn+WfVj2UfjddRvw3errcNdq03TXZy+b0gbfRCC7dDDn5zgkRSJ2L3vbRiW/L1ksrtKubeI6kqZYHGfy9mYcZMDjm81oMNMlzdGOtAZbCaA6JGP1w+A/HXuExOIbVeRSSF2y3yeSKIB491I9SKJGEPLjs3ElW2jsJ0NWQLjHOIyKiMNpRB1PrhlDzh/Ll6VccbmbQP6N0vQIPcqNxpsd+vr5uy7CVSLAPGANYhm4FKUdy3hljjR16jH4OnR31YpXcLseD7mzcmXfGK/kU1s6q08fdJoe0pI1ZcJfFMQKhABFCbbhQ7DkpT0XcbxrAYCGI5pEdnt4k/7pmbTGUssDa1Cb24ps0HTcINvdsZ2UpLKpTmy+/tAXWszm2wXpvejf2JWWpWNKFouWME3BTHfT0k+TaaR5vso3AO9jHuJ3RVxQUB7y+aLoQlaErRTxd7ttimqeKfH3vRSKCbadWOhVCHrR6f7AGyvJd/v+F1CBKmShVtgWbXU70Ds2wGHlndTWNnfMkCC3SCCH8865mGMFVyOz6kzZu8CdO/MNZaHQvZyY3d3kZc8Tszq94L8GdMpA5Bw34Gzr0OlRCkGYl7ckpv0/8mqQ5rKtqw2eL0R7+t47PZlUQTjYyRgTaY+2wp8uQEkb+2ZItktJi7NvqBY1gcVPo4LIrVVwnMIiV1wO+n5BbfGpmwg==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW2PR12MB4667.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(66476007)(66946007)(5660300002)(7416002)(508600001)(64756008)(2906002)(36756003)(6486002)(110136005)(186003)(66556008)(38070700005)(122000001)(86362001)(8936002)(53546011)(8676002)(31686004)(316002)(76116006)(54906003)(71200400001)(2616005)(6512007)(4326008)(6506007)(31696002)(91956017)(66446008)(558084003)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?WWFHdXFJVktWVHp6SnlmUVlCSnNWQWpTNEJVb241S0IrVnhldkFHOFZlVWRm?=
 =?utf-8?B?SlZFWk51VTlzM0huT2NWQjhyOCs3Vjc3RUd1WU0wQkUyc2JYcmJTclpKMDF5?=
 =?utf-8?B?eVpwb1g1eUE5aDUzcVNDdjhaQ0NSVlJFV1dVT083NHB3OU1aTEg5QVBKVkJ4?=
 =?utf-8?B?bXh3U3BVQVBGOVk1c2piU1dQKzZWWDY1YjNOMDdueDVMNU1BZ0xiWjVkcUlQ?=
 =?utf-8?B?U3pXL2VyWWVkN3BUT2lXc0lpaWtKWlRXdS85QTZTVjBhYUtaNUdOK1F3MzVu?=
 =?utf-8?B?TGlUL21MdzVyTGltVmV0R1VlQWszUUpGdS9jejBPSExFMnNSQ1Ivd3hVT3M4?=
 =?utf-8?B?TmdseGljejRrV0hYM2xPdFpxY1pmTW1ubkhhRkRpR1VIbi9xRGNGdUw4QTBj?=
 =?utf-8?B?MjZKaCtmalY2YVhnRjByYjRWRXNnaUpsQUVlNEJkRys0VmloWTV6bU5xZENp?=
 =?utf-8?B?R3c2WDhrVHMxME40cGVEaFEvS1JWOEVYY0hzM0tpRXRUT0NQcDhSQXlFa3lI?=
 =?utf-8?B?Skh5NTRFWFljY0lXUjBmNVZYaEovRTdndDExdHF4YUR2L0RPc2UzZnY4RmlQ?=
 =?utf-8?B?RjVOdDRuclUxVm1xcVVrL2xYZSt3VHJNOVVDZW94aTNnZTJDNC9ZaGkxOXlE?=
 =?utf-8?B?YUxNYkdXRUNNVWNhTFJBdVNhTFY3bDcwUEIvK3BhNmRyRlBtb3pWbG9TbGxr?=
 =?utf-8?B?bFBCdWVlTDc3VWNjeXBWV2c0anZFZURhMThOMGxnVEIzdnJNM3YzaVliTG1h?=
 =?utf-8?B?VDJNZjJZS2hpaDNtNWg5TW9ROWdSbVRFclMvWGo3NVV1a0RaVHdKQk5kckpr?=
 =?utf-8?B?a0J2aHYvOE1WTHU1RnY2WVkwNEQ1aUxhalFUeEhqUHBCSW5WK000bUwxSkF1?=
 =?utf-8?B?Q3o1a3ZtSkMrYjg0dEdxR2FhVlZMVlRQcEVNTkhsRkpPQ2ViNThqRXFya0t6?=
 =?utf-8?B?ZVRpQTk3cldhb1ZQMkxWeTgrWStETjZJZ0NCSXQ2U2o1OEtuNCtQeDYwa0w2?=
 =?utf-8?B?aXlyZ0tVa3ovc2QwTEY3aVVYdjh6YndYRjkzZEdUWjEyWkc2U3h0TjVDZGdl?=
 =?utf-8?B?K1FFYjNnMGthNGlnZGFSSWtVY1VVV3VjNG9CaVBTdy82TzcwQ2taN0VtRlQv?=
 =?utf-8?B?YVo5dm9aRXRVVFh2MUliYkhhdUtUVXNVaWoxT0ZVWUVkSmxzUzlXbzE3RDhC?=
 =?utf-8?B?U3pzWUpiQXI5SldkU3YvSis2ZGJsV09rbVcrU0w2ME91Sm9rQ3dIR0duVW5S?=
 =?utf-8?B?bkpuVGtRTG50SXBFZmNsN095VitHSGpQY25IU1VFV1c4bHAwOVlUaTFHQVFx?=
 =?utf-8?B?RFM4Rk5xeFJYZ09YQndaeHFxdTAyZGY1dmlhNnFjOGdJV0dBNTVFZ0RudTNF?=
 =?utf-8?B?aXZKMDVKZEdsTzFiemtJaGI3RnQrQVlaY1Q3b0M1VUhOVHZaVCtYUGdLZGdj?=
 =?utf-8?B?M0dyc3JRUmVpQitxWWlKOWpqbjRRSE91YzVKMmRuQjNYL3BacWxiaUNscGI5?=
 =?utf-8?B?S3J2aVMrbVlZTTRtRGYyU1FVVnM0ZVpTZ0dTSE9HVktnUnUra3l2MDJUZjBO?=
 =?utf-8?B?ajBjVWZ1b3lnMkhUaXhkOG5qaElUM3pvYmhIWDFYN2tjY1NIaEgrcDRtS2JB?=
 =?utf-8?B?VUUwZy83enpramo4QUc4c01YT2NKbjR1M25aQjE2TVJER1NJb2ZkZytpODdD?=
 =?utf-8?B?Y3l6Qk1DRTlZcVZ5ZlloQnZOaHE3dnVzYWJRQ2w2d2lZaE54YVltN09DQmhk?=
 =?utf-8?B?UFF0cUR5SU0zbWpWMW1INFBock1tQkxmeHRiYStJOVRDY0lPTjJNbGRJeGpj?=
 =?utf-8?B?VWtheGVzcS8vK2N0NHk1NjNvSVlLbGNRd3ZjMkNYWDJJdlVpT3JoU2QxVCtX?=
 =?utf-8?Q?elYtGTzooLU5v?=
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="utf-8"
Content-ID: <C04D1511798816438A1258C6D616E890@namprd12.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MW2PR12MB4667.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3b6fcd47-592d-47ae-f829-08d992ca4bd5
X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Oct 2021 06:33:00.1849
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: G9E252Pi/21Wu/eLDh/sIa/ScWyUV8bFrsDrMrdrRM6Y6v01n7l7ccXlrNMederiUZvyhOgypFPLlVwaRJ5dQw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR12MB1262

T24gMTAvMTgvMjAyMSAxMToyNSBQTSwgQ2hyaXN0b3BoIEhlbGx3aWcgd3JvdGU6DQo+IFRoZXJl
IGlzIG5vIGNsZWFyIGJlbmVmaXQgaW4gaGF2aW5nIHRoaXMgaGVscGVyIHZzIGp1c3Qgb3BlbiBj
b2RpbmcgaXQuDQo+IA0KPiBTaWduZWQtb2ZmLWJ5OiBDaHJpc3RvcGggSGVsbHdpZyA8aGNoQGxz
dC5kZT4NCg0KRXNwZWNpYWxseSBpZiB0aGVyZSBpcyBvbmx5IG9uZSBjYWxsZXIuDQoNCkxvb2tz
IGdvb2QuDQoNClJldmlld2VkLWJ5OiBDaGFpdGFueWEgS3Vsa2FybmkgPGtjaEBudmlkaWEuY29t
Pg0KDQoNCg==


From xen-devel-bounces@lists.xenproject.org Tue Oct 19 06:58:26 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Oct 2021 06:58:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.212727.370750 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcj4r-0001A0-Ib; Tue, 19 Oct 2021 06:58:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 212727.370750; Tue, 19 Oct 2021 06:58:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcj4r-00018w-Eo; Tue, 19 Oct 2021 06:58:25 +0000
Received: by outflank-mailman (input) for mailman id 212727;
 Tue, 19 Oct 2021 06:34:02 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=cA3S=PH=nvidia.com=chaitanyak@srs-us1.protection.inumbo.net>)
 id 1mcihG-0006Ml-H7
 for xen-devel@lists.xenproject.org; Tue, 19 Oct 2021 06:34:02 +0000
Received: from NAM12-MW2-obe.outbound.protection.outlook.com (unknown
 [40.107.244.57]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 8bc86482-30a6-11ec-8301-12813bfff9fa;
 Tue, 19 Oct 2021 06:34:01 +0000 (UTC)
Received: from MW2PR12MB4667.namprd12.prod.outlook.com (2603:10b6:302:12::28)
 by MWHPR12MB1262.namprd12.prod.outlook.com (2603:10b6:300:12::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16; Tue, 19 Oct
 2021 06:33:59 +0000
Received: from MW2PR12MB4667.namprd12.prod.outlook.com
 ([fe80::3db1:105d:2524:524]) by MW2PR12MB4667.namprd12.prod.outlook.com
 ([fe80::3db1:105d:2524:524%7]) with mapi id 15.20.4608.018; Tue, 19 Oct 2021
 06:33:59 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8bc86482-30a6-11ec-8301-12813bfff9fa
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=OvNg8mtb/uabD0IaH2+x1exCG++haUzdvO7z2XqrV2/G22Py+wT/3M1r1YGaJM22NU2UYEHnr8/GCwOHvzUJUVz2frfHpH6Pfoop1iHknGIy6iK6k6S/pRFfpptpnTLqX6Jxw0A9nUWFKtc8n80QJAlkolUg34roM88wIHHuJtrkIeC9ICwdeMXRnAy1ZsF9gCg6jKMd7kF3WjXeSmbOId6uWPwCIRuaTA3R4wB5URPKghC684xkjt7nTiAPStoATGjG4rdDsbgvYGkSPxbirEH3eEmkep+1Wx+KUY0wst8ntbE8seQXno92bI0oJsQutpFBcDRSl55hkHY1xxmcsw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=6sHCdAo+VtLUo7J6kFt5L45qrwynhfPpBhRQnLVgAGw=;
 b=VxN5J2Rc3iqfBjtnYuA0O2qKf+I5iixsvjqcNICI2K15iyFXcZxLJu7SfUpprUmVweDgGaKSYWvx7H9H/gN0j6btX33j2R5sQjGY9/V2fJ33iw1XbyGmf9COtoOTv8um6t+AaPWULk9WJEFPKNOLemjiLF9t0EtgHJukIMb2B4JM4p1Xy8hupAHN5IvYaElB8HKIteQMLgYTWzn6P4hFTbzEw792WcAfO8otZNsc79wXU/o+428BgX44XWjI5Fv10z7fIkXiSbhZDCaPmmrTUL+2dL2l9RyJ7W9mmLtnr/kHhYQPwVtbm9T2XvaByS/prR0wxVZpFPhoOVlRc08STg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com;
 dkim=pass header.d=nvidia.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;
 s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=6sHCdAo+VtLUo7J6kFt5L45qrwynhfPpBhRQnLVgAGw=;
 b=XIN2bCR8PBD6qhTlMFKMTfvG2iaQmzKo1TXuMpP2nORD/LZepZr0ssPkGiw46tdnQ7mPTpYv6NnQMSJ9lu29MNWkXc0qXd46Ip9Sz5D3MsPykASdG1TigOZf7ccQLQa8m7LE3G8bHSaTMAxKpo8q2ndupZ8pka9WCGRDKw4kMGuviD3DFaHIMk56LfCpkWFg876Y+WnbaV6EtiBxfYpb0BxSRp10Ujt99lFz41xlhtnLvR/dKJ294TiSSTWBW0bLLhZQniqyoqwwHVnN/UasZAGRrYTsHbpviqJI6fkjlDxbtHu2usjiOSANU8LBVRRZW7Dzwv2bVY3bQ4JaNS1NfQ==
From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>
CC: =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>, Josef Bacik
	<josef@toxicpanda.com>, David Sterba <dsterba@suse.com>, OGAWA Hirofumi
	<hirofumi@mail.parknet.co.jp>, Konstantin Komarov
	<almaz.alexandrovich@paragon-software.com>, "linux-block@vger.kernel.org"
	<linux-block@vger.kernel.org>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, "linux-btrfs@vger.kernel.org"
	<linux-btrfs@vger.kernel.org>, "linux-fsdevel@vger.kernel.org"
	<linux-fsdevel@vger.kernel.org>, "ntfs3@lists.linux.dev"
	<ntfs3@lists.linux.dev>
Subject: Re: [PATCH 3/7] xen-blkback: use sync_blockdev
Thread-Topic: [PATCH 3/7] xen-blkback: use sync_blockdev
Thread-Index: AQHXxLIq6eQH0M7OgkOwMFPfq0tuIavZ3TSA
Date: Tue, 19 Oct 2021 06:33:59 +0000
Message-ID: <27156c5b-7e7e-b615-cada-0b99a99bf5af@nvidia.com>
References: <20211019062530.2174626-1-hch@lst.de>
 <20211019062530.2174626-4-hch@lst.de>
In-Reply-To: <20211019062530.2174626-4-hch@lst.de>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.2.0
authentication-results: lst.de; dkim=none (message not signed)
 header.d=none;lst.de; dmarc=none action=none header.from=nvidia.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 4cb4c8a7-4334-4a8c-94d2-08d992ca6f4a
x-ms-traffictypediagnostic: MWHPR12MB1262:
x-microsoft-antispam-prvs:
 <MWHPR12MB1262D3501FE45D185D58853FA3BD9@MWHPR12MB1262.namprd12.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:530;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 QZ/+2ztZi9OdZ/V5/bYDmDhPJAQNlWHohgJDWLzIyDVnAubOngi+iNlw5CRjL+cg4Aw9voAiOqWeh1hAa7IfU5YC6UD4F97MzBUqbT0Ram+kUNYf0iEzpGaPiwh/5zP2HcOmpKj4La4fNUK300PxdE2O3Z1Qqa9f7zBEixElMjz07beh+k3vCKoK2TzLYtcb3ob9MG1obfszdwHwK9970lW0gjB7EUF2Iop5qQqjiS1nViiR7QmPunHsOXpz/zri80HQelW6l0ByLPvY6Twayo7CKMqBrr+kYXO+a5goOkDTFbzMbH4WS9rPsCeBENtrFi3DY8MnXDOydhw41tOgT3XBIJuHTJiriZT/LwBxGpB7LYpsnqSEp/rosi/mjxWVjilkpknI4l3EWnYdiGa94G7adEnTXnJA4bO0h1GIBSxkXDymE5xb3pb+uJFmcsdlZEw1XlWwMz82u/DAbHWkTMgAntxtSlVo6zadnaA2nVotONopY6kx/8CZQ3uxLQip1xgpcURAO8YH89FDftC7YpIxHh2ktdAPjoWl34hH4YyyxlTnD2g+LTL2m0cqNFNdeXXHvavvJL2T6OZi27iXb70jHSZEV6H5BDL2L5PRZo7xt2L0Ui5e/SpFEqYPuJOP2mW/IcC6qpFolSxa0QoxQAxi8anmgG1z4VnYafeYobNhndRP233kQDTDQ+WWrZ6S9K+Uv38b+7I98SGDIO2+69O/4FU/JUnMuV1LQwIRSzo+s7PsRsf4zPY+aSI5R1d8sEjVgyTO/AXwvAamAATpNg==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW2PR12MB4667.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(66476007)(66946007)(5660300002)(7416002)(508600001)(64756008)(83380400001)(2906002)(36756003)(6486002)(110136005)(186003)(66556008)(38070700005)(122000001)(86362001)(8936002)(53546011)(8676002)(31686004)(316002)(76116006)(54906003)(71200400001)(2616005)(6512007)(4326008)(6506007)(31696002)(91956017)(66446008)(558084003)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?R1Y2Wml4QWlaMCsxbm1MeWtOL0JFODlpVmlNanJQYnNGYVNsK29lYWdtUFZm?=
 =?utf-8?B?eEp1UW5KaUVYaUtoT0F2bUhmd2FTL3RkSGVRQXlTelZqd0RKcUlFbGpYdzBR?=
 =?utf-8?B?WWRCNUtvV3M0QzVoOE4zczd6cUdMbjlEYi93VDYwTGNKcEtHb2lSYVU2dHJL?=
 =?utf-8?B?TjJ0Y3lwVkUyNE04OHVkRnlnblZtbjVNK3QyK0F5ZnU1eDlNYVUzT0NrYTIz?=
 =?utf-8?B?Sk9vc0hNOG1mRmhvUDk3T0hqNjZZMXpUNGh6WGVoVG9RMHJCSzhBN0Z5WWh5?=
 =?utf-8?B?T0xvU3NVOHhZZFZnYUlvaForTHc5QVlKQ3dSQjVYMWc0bjNkZzM0K01IVzI4?=
 =?utf-8?B?Z01vWkZmTlRUMkJzWUo0eW1oaHNqVzBwY2lCMDMwUUptSVlVSnljSTlya2Zu?=
 =?utf-8?B?Q3plQlByTENVZmJvQWZDbUNuK0I1Y2F1enkxNzRQQ2lmelJlR1NBR3M4U05k?=
 =?utf-8?B?ak9PRGNLTFF2VFFtT1RYWFdwNnVObGVjQXU3OHJlaHJlaDlmakJxcXZyRUNt?=
 =?utf-8?B?N0NFQ1R5UkZvN1ZDRm1ublN2QUpwSmJMajR6V3NTRWhEWm5ZMXdZK3cvemFw?=
 =?utf-8?B?OHRVa280UFBDZWxWbHN2N1NyZFBSN1FkdVh6c296T2p6L3JwaUZ4QTRUbUJR?=
 =?utf-8?B?c2EyWjFIcjc0VFV4bHZBTnV0cnVBc3k2MXhEdVVDMjh3cktud1hId21lYlJk?=
 =?utf-8?B?c3MrYWN2b2dPYWF2S0NHT21sWW01ZGh5TEF2djl6ajhuKzlySEFvNGVhWU5y?=
 =?utf-8?B?bC9ZdHdMZVF4bnJFUEFoUFhKdEUwNDlCV2VBY2FTVFpjaFlLSUVKUXU5OHEz?=
 =?utf-8?B?cUNZWDhsT0VHSzMrd0MwdkFmcjd6dVRMMjVrb0lUbmgxYXgxd1ZSRlIzU3NB?=
 =?utf-8?B?Q1E3WUtJSHRxRkZzV3RFOWNjZkpTelNDQkRHVXo3bVVEMUJzZk1DcWc5aHNM?=
 =?utf-8?B?TlhwZzAyQ0xJZUxkQ0lSd0xWdkJ4N3dwVEErOXNDY090d0FIcE84Y0J2b24x?=
 =?utf-8?B?S3dVS201bTYveTR3K1E4MWZlYUlkMnN0YTRFR0VTUlJvMURHOUJIYmtQbFEv?=
 =?utf-8?B?cjFWZHhzbjhqRldKOTVlek9XZFhSNWFEcDhqSkZ2ZWcxZDl6WVdoUExLVm1s?=
 =?utf-8?B?M0Y1MVV1VjRhQUdBMDJMMjdQNnQ0Z3JGamxrNmJ2T0JmTldoM2JkQm4vME85?=
 =?utf-8?B?aTJMSm5JQmlxT0pBV3FsQzkyUm5jaXRjd1pRQkFjMy82U3Fvak42LzhTc0Vy?=
 =?utf-8?B?ZmNhSHFHRnlzYXlsbGpQRWFsNmZIa2d1cTcxd3Uzb3dYaXVIeFpQRC83QWMy?=
 =?utf-8?B?RWFYTm1PU2hIMU9IQTRxMXdNYlNkck5RMHlFNHR2RDRQYU5DVjY5SEFHaFE5?=
 =?utf-8?B?TGJYUnFuOTM2UW8wSkR5RmdvT0ptdDlHc0JJaGw3RWU0TkdaRUxNUHdxSVYw?=
 =?utf-8?B?QS8zcmhvVUtDWmpnaXJOeVJYdFEySmhxeWZNS01HQkF4MEw5dFdQN1R2VG5p?=
 =?utf-8?B?R2IzRUFxYUc5ZTZUMlhPd3dHamNPQjMzSitVaVhWWTlYM0tBaEMzSElzTXZS?=
 =?utf-8?B?MFdGZU01Z3pCc0hwQ3J6ckdhZHRla2JpQXVzaWloeUI5MFZmL1g0NXdXSml4?=
 =?utf-8?B?U0hWbjRzaTFKN0pUbkkrZ3FUalZTT3FZQTEvZGhpZ01DRG9Ca0N5SmMvSFll?=
 =?utf-8?B?c0QycklDTjR4WldSaVlBRks3cTRxUnZwb1lIWUJBemxuUGRPVjRKdjhVbU9W?=
 =?utf-8?B?cDBTWXBMWHNRMk55aXlkSHM2YXNJam5SS0IrN1FCYSsrTlVXZnRqOGVSTjZY?=
 =?utf-8?B?dkUwb0g4VGV1ZEhCSWFESDd6c2dUZ3Q1VC9uYmhQdmYzNnlaMFQwN0VsVmxK?=
 =?utf-8?Q?FdPLpNeXo3ZLN?=
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="utf-8"
Content-ID: <3CEB5B32FC00EB449EEEEBF6C7114D49@namprd12.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MW2PR12MB4667.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4cb4c8a7-4334-4a8c-94d2-08d992ca6f4a
X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Oct 2021 06:33:59.6354
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 5upgkLaPlU2A+9aNx/n9Omls3ThilEW/7kT3Y59yuUi/DGar79NJPfGuiCU5fYW2SbbltP5Bw7rBY7w5BKhTlw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR12MB1262

T24gMTAvMTgvMjAyMSAxMToyNSBQTSwgQ2hyaXN0b3BoIEhlbGx3aWcgd3JvdGU6DQo+IFVzZSBz
eW5jX2Jsb2NrZGV2IGluc3RlYWQgb2Ygb3BlbmNvZGluZyBpdC4NCj4gDQo+IFNpZ25lZC1vZmYt
Ynk6IENocmlzdG9waCBIZWxsd2lnIDxoY2hAbHN0LmRlPg0KPiAtLS0NCg0KDQpMb29rcyBnb29k
Lg0KDQpSZXZpZXdlZC1ieTogQ2hhaXRhbnlhIEt1bGthcm5pIDxrY2hAbnZpZGlhLmNvbT4NCg0K
DQo=


From xen-devel-bounces@lists.xenproject.org Tue Oct 19 06:58:26 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Oct 2021 06:58:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.212731.370766 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcj4s-0001NM-EF; Tue, 19 Oct 2021 06:58:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 212731.370766; Tue, 19 Oct 2021 06:58:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcj4s-0001Jp-1y; Tue, 19 Oct 2021 06:58:26 +0000
Received: by outflank-mailman (input) for mailman id 212731;
 Tue, 19 Oct 2021 06:34:35 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=cA3S=PH=nvidia.com=chaitanyak@srs-us1.protection.inumbo.net>)
 id 1mcihn-0006OD-C9
 for xen-devel@lists.xenproject.org; Tue, 19 Oct 2021 06:34:35 +0000
Received: from NAM12-DM6-obe.outbound.protection.outlook.com (unknown
 [40.107.243.76]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 9f9b9f42-30a6-11ec-8301-12813bfff9fa;
 Tue, 19 Oct 2021 06:34:34 +0000 (UTC)
Received: from MW2PR12MB4667.namprd12.prod.outlook.com (2603:10b6:302:12::28)
 by MWHPR12MB1262.namprd12.prod.outlook.com (2603:10b6:300:12::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16; Tue, 19 Oct
 2021 06:34:33 +0000
Received: from MW2PR12MB4667.namprd12.prod.outlook.com
 ([fe80::3db1:105d:2524:524]) by MW2PR12MB4667.namprd12.prod.outlook.com
 ([fe80::3db1:105d:2524:524%7]) with mapi id 15.20.4608.018; Tue, 19 Oct 2021
 06:34:33 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9f9b9f42-30a6-11ec-8301-12813bfff9fa
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=H2rIFvBpBnq/amPnDVCRGflWSqb7iAURgEbStFSaG0gYsA9BqaIcbdgJimHxcRL8fg31csf+M9K/BVsT0mV4HGiGPvuupNdF1YCGEL5ioxuyqnTSHAvCa1OR4fAFeZIKe8EV4UV/fAprEONT4u6HbkqppV/0Jbl0LBqJHRgBx8/ddY7LWdBDrFo8H9vrYIKqh9JP5WJbqZrIhthbyfjUc48yywNQRzhbxFQV0PJPvd9niFj5lC4+RWXXVY3ZxrwzNI6mhFvNedGxRc3yEsOVU3GcXIW9zdUyODmZpp6eMpQmFXX2wjqbR3snTMCnoJskAYLSXkiRvEo/9G1q4PoEsw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ERawEb26Ub316UouzEdcrTsfbddk2QYr7UABbTt5SNQ=;
 b=gDRfU6RPaR8FLprhdfb0qmwhwEIasIyPhVlp1PleL3Y0f1zC7XcNruwePKUBaEOJwEC9d8lWMfo1ocdrxPmLdgTgbIUfw//OZ5BcGrDAcEaeTBwHWswhuApjqO2HtkE82wPUvQGdgsOeDfqNN5jdwOuAaN1FLf/4KPwGaz43STyX87qOCbPn4BnzRM2wZt9d9Bhrl+olDw5lnUmet5uehga80AS8BrxASYsbafV78/nrHE342mu8OwXD0+Yiau/n12Yg//NTv3kpQNPeyP/im0Ojitg4Er4tRHOmvfm7/6ckKGGM6mpO7x7Swfe8nmCWbLiOh8eV8aAGlbC+NQEI1A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com;
 dkim=pass header.d=nvidia.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;
 s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ERawEb26Ub316UouzEdcrTsfbddk2QYr7UABbTt5SNQ=;
 b=CW4fkr4OM+SfQetG5U1GdsJtrR62LS/N0LpZH732infUhUZliqYSPgK4gRfiIWxu0F7zp1O7etfiV+wd5wsIEE0g2BMZ+Vwz4FXqtn3koVDnIh9Z0TMHL3KEPpXfSvFZuI43XSPo3dwPAhErgCVUO7UfY3GynMqsjkx4sXmTtD4jzEHxxRuUOSaHlojlE0MKdajfNIasS66phtcRJuYN/dOB0oz4WmSn/ZAVOy622cNCvrZM7favT6DAZWWxkPt5irS9NAWs+kHsqU9mXZMaDI6gCxf++RmuYVOWWSo2xvIPt414iI4fIfGO3EWzxTjsdz6CpkodKecypblxMjW6wg==
From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>
CC: =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>, Josef Bacik
	<josef@toxicpanda.com>, David Sterba <dsterba@suse.com>, OGAWA Hirofumi
	<hirofumi@mail.parknet.co.jp>, Konstantin Komarov
	<almaz.alexandrovich@paragon-software.com>, "linux-block@vger.kernel.org"
	<linux-block@vger.kernel.org>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, "linux-btrfs@vger.kernel.org"
	<linux-btrfs@vger.kernel.org>, "linux-fsdevel@vger.kernel.org"
	<linux-fsdevel@vger.kernel.org>, "ntfs3@lists.linux.dev"
	<ntfs3@lists.linux.dev>
Subject: Re: [PATCH 5/7] fat: use sync_blockdev_nowait
Thread-Topic: [PATCH 5/7] fat: use sync_blockdev_nowait
Thread-Index: AQHXxLI2ACR8R5mMQkaGA6fT0JPUuqvZ3VyA
Date: Tue, 19 Oct 2021 06:34:33 +0000
Message-ID: <61925aa2-4474-354b-955e-d3dbdd6ee281@nvidia.com>
References: <20211019062530.2174626-1-hch@lst.de>
 <20211019062530.2174626-6-hch@lst.de>
In-Reply-To: <20211019062530.2174626-6-hch@lst.de>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.2.0
authentication-results: lst.de; dkim=none (message not signed)
 header.d=none;lst.de; dmarc=none action=none header.from=nvidia.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 01e17411-8278-44c4-ccf7-08d992ca8357
x-ms-traffictypediagnostic: MWHPR12MB1262:
x-microsoft-antispam-prvs:
 <MWHPR12MB1262959A5A48ACA061E47173A3BD9@MWHPR12MB1262.namprd12.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:530;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 FZaq+uyNhNsIhlSt+B39bFXbORPsiQm3v7ylnPxcFlSg8VI//t068m1xAL/nipwO/IVgzNAbLRC5ZFmSeQFh2lTghkzNn8xK0yesOeeqXZQbjtSeNQ9Fxm8w6gTud5kOZn5ORk5YsDGg4Oe3LALb6t2chic1rwu7bgOsXn7lyipx5KafmN5Mfd0XG7ARBSmtCiQbyPHGWQuXOc7JVVXzA91PovkVxH4nZD3Zp6yAULQ5d3I/0Leg+TjWyxfDXXTh95khoW6asTTqfo+CnQsAIAyGD0GuMQoiDzSFEa1zDuDPFHQlWIuFTjyutCF4y2CghfGrhDq42/EpxeAQ6jHPL7iRkgKVva36aMNm5rWfSdmJZpQdv0CEokIGQv4TsHAUsiO5OYG/YTj9cGQFBq2L7ituHHyd2/3jmZCqRvQDWNqJx5pfgTMwx3pCjWu4LTZhBCyhu2EXixxT3aCthFhaYmcNs4qEzqANIMlVJvUFqmgiy3U8XHvJa7BCGtaraorc3BHtDVaivW66pveDf/7tUo02j0NZHgw7ZV6mpud3TYOfNj7ig/SohP1H+luULnmbeTAKHqjb9RfaJw0Hm+f9I/BuHJfBIW85EhBAjQOuOIHatQ5piZNQIxW+7EbywfzsNs9Mv/MhydVfGOmXww90vJI6LCgVjadLD6hpn21PDnj64VYMWKJFaQgO+fdx7FPl88vzh1zw1pqc20Al+h8Wd7BZ+z5ktOVncEC069cN5IoAhjZVwBNMua5EFyZdiv24mKPiHF61GGcrWAe0H2D19g==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW2PR12MB4667.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(66476007)(66946007)(5660300002)(7416002)(508600001)(64756008)(83380400001)(2906002)(36756003)(6486002)(110136005)(186003)(66556008)(38070700005)(122000001)(86362001)(8936002)(53546011)(8676002)(31686004)(316002)(76116006)(54906003)(71200400001)(2616005)(6512007)(4326008)(6506007)(31696002)(91956017)(66446008)(558084003)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?ajAxRlVpb2kvMlhyY0dZcytlOVRhZEh1cFdSMC9HRTB6VGFhYkxHclBYNmds?=
 =?utf-8?B?VWllZkNzQVMrRGVSVWtFT1pKOGcrRVplaXJsd2Fzeitaa1Y2VUc2TEhzZGJO?=
 =?utf-8?B?ak9RMGtkSmJOZDk1dEVaenJ6Ykh1amUrVWNMZVZaNlZaMWVaSWdRUCswKzdW?=
 =?utf-8?B?WGtNTHlLZDZSbjFmZG5aclVVWnBZYVBob3ROZXlYb09aWDI1Ym5BQWd6M1ZD?=
 =?utf-8?B?VHFVSU0wLzUyT3JQaE8zeVAzbER1N1IybmhSWXNhNkVSaEJPclZmaGJqWEdG?=
 =?utf-8?B?WDRYT1VkbGN2K3hFOUtzS2prL2hrTTdhUGtkTHpFQjBlYzJCa0ZJaGZTV3F0?=
 =?utf-8?B?RUdqT0FteStxMFJDekY5eFJISHNxZUJqZmd2STJFNzN3WFU4RElyQ2R3NW5P?=
 =?utf-8?B?VWZsTmRhbVpsNnUxcjVnTG1aQ1ZTTlJiSkNUTU5WVWxTSkZDOWhXUUhoWVhH?=
 =?utf-8?B?N3FKQk0vQTJpMnNvNWhrZkErbGo2UjZtK1JyaVk1eVhRemR0ek91MWhmOEcv?=
 =?utf-8?B?S0ltNUNjbHZEVmJCcFJidlptZWFNSlpwUCtleWl3SjhzdGJYeUxQekhpelNY?=
 =?utf-8?B?aXBlWXE0WkovSkc1bFFQRUdva2lHMXI5UWRqOVpNaDhLemRtZUpTVzNBS3l1?=
 =?utf-8?B?N3dBdlBpZldpZUxlMnF0NS84OWhWUGVuNmhyMHFqenQ5aWx0S1N1T1poL2I4?=
 =?utf-8?B?c3hmdlFKTXdzeGpkVU5PWk5VWGxLU1RyK1NGZTYrMzhkREFaR29QZmZkYitI?=
 =?utf-8?B?USswZ1ppc0pGZE5OOENSYnE1LzJWdDRORG1RRWxUMytRa2tHM2x2ekdDTkVT?=
 =?utf-8?B?bDZvZkZEcWlvbVdudXEvWTRzTUpZcFlRMHZLNkRKT0pGRS9YNk1ndXROajgw?=
 =?utf-8?B?RzdRb2FIbVJFYzltM2RySVp4OFB0b2ttYUwvSitUMkp1YzNsTm02cjhMbHg4?=
 =?utf-8?B?V1RHR2xRRmNYSWUxa21teHpHclRXaVFFcG5yMlRQQ0ZVYWZMUmxXVUIydjF2?=
 =?utf-8?B?MWFhbmY3d29qZTBhYUhTTkE0b2p5NlJnZlRxQzI0ajIvKzNxVXhSZHVhRTZE?=
 =?utf-8?B?OGVhVnAxdmNUWDg0NlpOZFB5bWVyV1luNHluUmRpUUUzOW52TWV6NUJRZWlk?=
 =?utf-8?B?QnlOZlljMlVuNU5Da1NCV2diL1dxajJ6N0FiUW5BcUFPYVhzREpNbTc5YzU1?=
 =?utf-8?B?dVd4aVdmZzJhUGoya1FlMklvR1o4K3R5R2RnT2p4WTRxWTM3MHdCcTBDZzgz?=
 =?utf-8?B?K0JOczl5MU9rUlRrTEdpT3I2TGN4MVR6bG83a01PRklEYXE4SGhkbkdZMkFH?=
 =?utf-8?B?eUFmMEcxU2FKSHFPSENBWlFlZHRta0RsUmVSbVFiSzF2eWVsQW1XQW43cU5J?=
 =?utf-8?B?SXArOXlwc29mbmtNUTZzaWpPUFRUZ2xBZTNRVnA2SlNZeGpUWm1sVFlJRDNZ?=
 =?utf-8?B?MnZVSlRkMkgxY25TeUdTa1IwWmZvR01QM1BYUmE2QVozaE1KaGwxVmNobFRW?=
 =?utf-8?B?WUhDQTRtWDkxL1VtRzNxWWxKRjNGYW1SaFhqcmwyZXBRc3lSY05nblVmOFp2?=
 =?utf-8?B?OWxTUEVKNXp2WWdMd2xZMmRrNFlpWlh3YXBXRlVDMkxhQ1JyaUYrZ1lQMks0?=
 =?utf-8?B?WjdVUXM1MWM2RHNFMHUxcEl0RDNFSHBmVGlhc052VFNEYTJoMnpFWTF2M2Fl?=
 =?utf-8?B?Rm9zdlNrK0xBODNCSHpmai8yUXhrWC8yVUVFV3lKQTNUa2FPNTAzMUE5MEc3?=
 =?utf-8?B?RFh6OG1TWUpYWDg3UVFLWk9WWnRPdld3WWtzQ21pQ1NwMGY2akVLN2Z4Z0xW?=
 =?utf-8?B?cFo3V3RUb05LSGcrQVRPV3BKb1hpZWV3WkdFZXIzWitWelRrdFEvQzNSSHp4?=
 =?utf-8?Q?W8MOeQhDeALLE?=
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="utf-8"
Content-ID: <35034971B1C90F4DA53D773B261CC060@namprd12.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MW2PR12MB4667.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 01e17411-8278-44c4-ccf7-08d992ca8357
X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Oct 2021 06:34:33.2805
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Jn3GrIyTbjTQw9CffhtnFrF4/pmOzIc8TMUJTKkv3bQCNvff8mgcvOKNyYpXT30hNNOMdujteMyYo4qlH15b5w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR12MB1262

T24gMTAvMTgvMjAyMSAxMToyNSBQTSwgQ2hyaXN0b3BoIEhlbGx3aWcgd3JvdGU6DQo+IFVzZSBz
eW5jX2Jsb2NrZGV2X25vd2FpdCBpbnN0ZWFkIG9mIG9wZW5jb2RpbmcgaXQuDQo+IA0KPiBTaWdu
ZWQtb2ZmLWJ5OiBDaHJpc3RvcGggSGVsbHdpZyA8aGNoQGxzdC5kZT4NCj4gLS0tDQoNCkxvb2tz
IGdvb2QuDQoNClJldmlld2VkLWJ5OiBDaGFpdGFueWEgS3Vsa2FybmkgPGtjaEBudmlkaWEuY29t
Pg0KDQoNCg==


From xen-devel-bounces@lists.xenproject.org Tue Oct 19 06:58:26 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Oct 2021 06:58:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.212733.370771 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcj4s-0001U1-N0; Tue, 19 Oct 2021 06:58:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 212733.370771; Tue, 19 Oct 2021 06:58:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcj4s-0001S9-E8; Tue, 19 Oct 2021 06:58:26 +0000
Received: by outflank-mailman (input) for mailman id 212733;
 Tue, 19 Oct 2021 06:34:50 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=cA3S=PH=nvidia.com=chaitanyak@srs-us1.protection.inumbo.net>)
 id 1mcii2-0006PJ-G2
 for xen-devel@lists.xenproject.org; Tue, 19 Oct 2021 06:34:50 +0000
Received: from NAM12-DM6-obe.outbound.protection.outlook.com (unknown
 [40.107.243.87]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id a83a6c20-30a6-11ec-8301-12813bfff9fa;
 Tue, 19 Oct 2021 06:34:49 +0000 (UTC)
Received: from MW2PR12MB4667.namprd12.prod.outlook.com (2603:10b6:302:12::28)
 by MWHPR12MB1262.namprd12.prod.outlook.com (2603:10b6:300:12::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16; Tue, 19 Oct
 2021 06:34:48 +0000
Received: from MW2PR12MB4667.namprd12.prod.outlook.com
 ([fe80::3db1:105d:2524:524]) by MW2PR12MB4667.namprd12.prod.outlook.com
 ([fe80::3db1:105d:2524:524%7]) with mapi id 15.20.4608.018; Tue, 19 Oct 2021
 06:34:48 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a83a6c20-30a6-11ec-8301-12813bfff9fa
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=dZdzar/LfSCftDgFCkBSGvV2rLV7phqlr5DmCiAXxlk99o7rUbAVQQ3Nc7kV+zfBDwrqFhRJlko+gs9uSHrZLtq4gFut7Gr29/ytc1euEDqdCGSk0LP4gzlWPcnJVKfvDUEGpK67U4IorTt/Q2N0Q/ZgKW8q2jY433rQFT7O7a5Hyc1+wUr8qCQvCrDEgrDzIeCJHek7A4PfbgHhbBpz14TfKMqhcB7zCY5aAlSrG9C+1vb2pSZCpztzogg1qvBHoZxYHVf/OB8TpLr62r3MeY61cXVAPIVxxgbRUcYeKujK4RD5v6FsmosDuMXdW2ahwliSCWzv618qBMA/O5ui4A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=UVB0BvaDt9zE3GM4gUNL+r5RYPjibT54Wsp9bJYlVcE=;
 b=g6GfWdGGbZyY/XBbVJCtrFA3nNAe/YFmWpx8fv0080kEii3i4WwzSCs+q6apbO7iLuyX3aHhSUsz1ldDurgFrxXcDZSyclcIM8aeVZxVqU3/e4ftmNjYZjke3MLl7U/tJQsl8uqSbx61KrvH2TZGHT3IUIguq5pLsGFAa0rXWU8yG96R27SCwqT0aoX+SJ4Cd9Dhb6J6XE0OAxmOF6brPwHELyaHtf7bM20Og/MctTwTIj8tS9+3cimZP3NcDk0ucIMqoGqesW5zXlyMP1kIFdOx6nAUx5jLi0dVL1gYJ8SmWliZLRuqgPzZPYYexteWmuqq/73MLP/Vaz/yrsLD2Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com;
 dkim=pass header.d=nvidia.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;
 s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=UVB0BvaDt9zE3GM4gUNL+r5RYPjibT54Wsp9bJYlVcE=;
 b=JjoB/XnUp/nGAKAFSCNjmCGUS5yREA4zhpNBtdC/CaJvJkSWiC6kHMoG32c6jn6bjsmE/LqCREfWctG4W9jmmBQPs9AZPN0rmiKhn6x4xYn+O/fCIpmWk/p11b1cwHXHwVVfcnzYPMBQwyDKtE4sA4IEEgxsY1rOAG1O7sX9GmOqlObp52kZeojfGUTShV1bYmTTqFPAXk1elmPqxQBJVSZfSU8YvZB5eSUkH59DVd+127GCbNo5+ZyIO26qUTEaKd/c+uLVeWE1YdUsZAGcNjHYcoDUeMRxOetxVYFLXPDW+8NL7vyjW1jDV3Hf5FeUjNrJSeJEg28uJx/vHjEE4Q==
From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>
CC: =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>, Josef Bacik
	<josef@toxicpanda.com>, David Sterba <dsterba@suse.com>, OGAWA Hirofumi
	<hirofumi@mail.parknet.co.jp>, Konstantin Komarov
	<almaz.alexandrovich@paragon-software.com>, "linux-block@vger.kernel.org"
	<linux-block@vger.kernel.org>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, "linux-btrfs@vger.kernel.org"
	<linux-btrfs@vger.kernel.org>, "linux-fsdevel@vger.kernel.org"
	<linux-fsdevel@vger.kernel.org>, "ntfs3@lists.linux.dev"
	<ntfs3@lists.linux.dev>
Subject: Re: [PATCH 6/7] ntfs3: use sync_blockdev_nowait
Thread-Topic: [PATCH 6/7] ntfs3: use sync_blockdev_nowait
Thread-Index: AQHXxLIz65BI1YRpHk2z+emkYWW3DavZ3W4A
Date: Tue, 19 Oct 2021 06:34:48 +0000
Message-ID: <f9c71f35-e8f1-e53d-9ace-d52e439ec505@nvidia.com>
References: <20211019062530.2174626-1-hch@lst.de>
 <20211019062530.2174626-7-hch@lst.de>
In-Reply-To: <20211019062530.2174626-7-hch@lst.de>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.2.0
authentication-results: lst.de; dkim=none (message not signed)
 header.d=none;lst.de; dmarc=none action=none header.from=nvidia.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 1896f933-2378-4d5e-21e5-08d992ca8c4d
x-ms-traffictypediagnostic: MWHPR12MB1262:
x-microsoft-antispam-prvs:
 <MWHPR12MB12622CB0329537E4C6AC0DDCA3BD9@MWHPR12MB1262.namprd12.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:530;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 27kgtYJyYZ/TApZdN6tZ66Ai8suo/c7FeUX+K4eZUQbXrKYq0Q0px7/jmceiJgfdw7OdidqESWWKi2Ounb2dzzrY2Odz+vXtN7vnjnx3/YcgPOgeRk7EEi/nRGtwdyvBmn7TynFhC9HLWjlBfM5bxUkP/Oo2PzV4lXXzOfJJeD1so2xFUc1LcqsQ7mx7w7gTUugoFV56NVuQlANqgzJ9ndAlNjLz2fgya/HbYVlDFozIml0MpuZZgRafzkf7yLOeC1hRv4kRIT/P+YT3jVbpoMthTQvGTJmeuEr28pDAe0uplWXuMkcoCMOoB7v4Cv+hJ1sCiSqFgAytl5xcFkYgThhVHJytBdjhxT3/mLHmWQDVO9x8bWvSW4LCLnOltjqyAwR4dLjVVI7AT6s8u+UJlXl0wce+Rek5FLkjtzDpbXP1MEaY25D3togkD2x2QdCngMfs//RhLBUh4TMHW/qCvnmPlgNUvfrCWZephsbcWVZIdoTSgA+UuLVluVo8nYe+mz19C68H3sww3smsQtdU1gYFOl40L4WCHE8lKdoXoY7CsbWae4n1rS8LzVfO+qWyOQ+A0d/yCz3b+WcDb380dMWwIeLMUt7lbUbi0066Llx48MWjmkVVPiC/El/JBBu4vwjHy7D49HVilRR8Xs5Wm+dLtCCQtbVmMMvjPO30PZegtboLrck1oqvl7jX4JYXQS+SG+nvLGYg4bDDmpn+rke5IQu74JNpLAjKFEgbOPcpGZ/9Q13Q9N3AmKlOkXKOlT1QuxOh47XghU8FcTeF9Hw==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW2PR12MB4667.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(66476007)(66946007)(5660300002)(7416002)(508600001)(64756008)(83380400001)(2906002)(36756003)(6486002)(110136005)(186003)(66556008)(38070700005)(122000001)(86362001)(8936002)(53546011)(8676002)(31686004)(316002)(76116006)(54906003)(71200400001)(2616005)(6512007)(4326008)(6506007)(31696002)(91956017)(66446008)(558084003)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?SS9Kait2TE10Sm51MDVudmpJZnVCK051Mk1QSmp2SGh3czdmNWJhSDBCaXFk?=
 =?utf-8?B?azhWWlFoTHQrUDRka3hVaXdZcWVJbVZ3UDBRdFdTcnFSR2E4ZlliTXRCTXE3?=
 =?utf-8?B?WC9RL2VreWduSXZxWHZTSUZ4YlJMbHNIVEhYUzBWaFkzSWxDanNsTnFzY0Iv?=
 =?utf-8?B?cFd5MTNDT1h1R0pJVzZFSFRoT3hCY3UxNkJLVzBjTUNScEUvQkRSaC9JZlI1?=
 =?utf-8?B?WVJ2T2RJRGpRMmZ5WHBSQTBVWlhMbXBZRVJOSUpLSXZ5WW91RUs5dm9mRWVx?=
 =?utf-8?B?Vm0vc01KUzhkZjNxS1JUQXk4bk4vMUViMkdFbTZhckFib3FYSnllVEJMSG52?=
 =?utf-8?B?b05Fc2V1d0g2Y1pORnhscEttNExPL1JXRTRHVVFSc1NYMWVOczQ3U0VoZmpD?=
 =?utf-8?B?WTUxSHNsbThIb3pFKzVhaS9ERm03SmwzeFZQdjZJTjAzSzk5Zlp1ZGJVMzA5?=
 =?utf-8?B?MHBpN3k4QlhTMCttSGIzTnFDa3pKT2JMOW5WS1BkdVRma2xEZE15T1RtUTB5?=
 =?utf-8?B?aXQ2T3RRMG9rMWlOeFh3bTVvT09KYWtxOTBVQThNOFRKcExjbXFtQjl0cEtQ?=
 =?utf-8?B?ZHRYQ2VrTHBIZ0V3K3JCZHVvOVJLd3RjZ1RYa1ZLdWIyZHBHUzJRT3ZEQVU2?=
 =?utf-8?B?Q2RydTVLTFpPc29LT2FWcnhRVUk4MGhOY2kxL1h0cVJtdExnNE1uTnp3Y2ZL?=
 =?utf-8?B?bkpIUHZpTEZwWnJDeHoxR25MZlg5bTFWd3JQSjgyK2tsRmMxamZieUVJaVJy?=
 =?utf-8?B?elQ4ZVh5VVV5Wk1pVXhrMXZuNENrNGJJZ3U0WmVNbGhrUG5Sd0hQcVVmd3Ar?=
 =?utf-8?B?SW8zdi9MOEVHQUFtWlZCK1pCQVNEMHNDRjMzNEsveU1Pd2dBYzNjNzBUTzlh?=
 =?utf-8?B?SFUyRFJLOXFkbCtHaFFzSlpDTXpEcUM4cVkxcWxWcjduL0thQTIrRHR2RVRt?=
 =?utf-8?B?WldvMmx1VkdnUEEvenRZNm9TODFEKzhPMTBsSHdqbUY3VXBxRjA0WUV2Yi9X?=
 =?utf-8?B?WmhOVlF4VEt3Zm1VY1hMQ05lZmVQY3o2Sjk1dmdxRmFGdVRGRmd5MUZYbVFo?=
 =?utf-8?B?ZVM5YlZuellXOHAxazlUWXJPRlVEWHJVSGZsUGlxbDVzNEZWUFRVcGUyZksz?=
 =?utf-8?B?UmFTOCtjbFhZcC9ERHlHNmk0Zml3NkwvVnczRTJYbys0and4b3RtMXliOE1C?=
 =?utf-8?B?OUs3RzV2ZWFhSXkvYm11U1NoK0ZVN2VTRFBwbHpuUmNXV1JxbjU1OERiaFZr?=
 =?utf-8?B?Um5xNGppKzJZaFg0Z1N1UXg2YWptT2puNjZNZ21lZDYyUmN6MjFZMjU1eVNO?=
 =?utf-8?B?YjdaNngwQ01mK3BpaCs5eG5VeG1GaVJsRU1ZM3ZycGVhUkMzODdxN2F2VllK?=
 =?utf-8?B?VVVYRkpGb2VmMnFoK05sYm55VDZjSWxEUCt1R0E1ejVyUFQ0ak9qR3g1NTlS?=
 =?utf-8?B?NzZOeUNvU25LUC9RbGhiTndlWXNnakQrWnR2MkoxbXV5UitlVXkwZzd2dVlS?=
 =?utf-8?B?M2RVV3o3ZGlsdjRoWXBNWVBrbEt6dmJXT3FDSlp0NTAwMy9Ya2lnejVVTWJI?=
 =?utf-8?B?Rm9DWFlwZkpIVFB6TC85M1RpRm5oRFQ2aHVyNmhraWFXSVgrQXFMSzlsVHFw?=
 =?utf-8?B?MmlLK2sxZHN5ak9lZ1lBNUUySXIzbHJhYTZTejlmeTZaNW5scTBBQzhZS25E?=
 =?utf-8?B?ZjdSY1FOZUZkNkh6Nk9lUXlYVmE2aldNZlFsdHFuSHRnaWhCRU0xOHUzWEdN?=
 =?utf-8?B?ZkhTK1ZhRHNXMDVxM0h2cjRtRUVDMFZDc2lHV09XTEdxRWlOdnV3KzV6U3VQ?=
 =?utf-8?B?ZVFYaEVxam5wd0lQUWh0MzVKRmhGOHhSMDlIR1RualhkMTEraDhuYUthcDlm?=
 =?utf-8?Q?Ni2ECUBala5n0?=
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="utf-8"
Content-ID: <57B9C9764B89564A9693EC835C4BFD79@namprd12.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MW2PR12MB4667.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1896f933-2378-4d5e-21e5-08d992ca8c4d
X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Oct 2021 06:34:48.2901
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 5d3WDFPffcPfZEa4iGEgrRLJv2/C2UdJVfSj3VJimBydrV1HAVFegYoyMHYdnnGQGSlg+2ARG4I29pKzAkZYBA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR12MB1262

T24gMTAvMTgvMjAyMSAxMToyNSBQTSwgQ2hyaXN0b3BoIEhlbGx3aWcgd3JvdGU6DQo+IFVzZSBz
eW5jX2Jsb2NrZGV2X25vd2FpdCBpbnN0ZWFkIG9mIG9wZW5jb2RpbmcgaXQuDQo+IA0KPiBTaWdu
ZWQtb2ZmLWJ5OiBDaHJpc3RvcGggSGVsbHdpZyA8aGNoQGxzdC5kZT4NCg0KDQpMb29rcyBnb29k
Lg0KDQpSZXZpZXdlZC1ieTogQ2hhaXRhbnlhIEt1bGthcm5pIDxrY2hAbnZpZGlhLmNvbT4NCg0K
DQo=


From xen-devel-bounces@lists.xenproject.org Tue Oct 19 07:06:18 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Oct 2021 07:06:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.212788.370801 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcjCQ-00051H-MY; Tue, 19 Oct 2021 07:06:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 212788.370801; Tue, 19 Oct 2021 07:06:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcjCQ-00051A-JT; Tue, 19 Oct 2021 07:06:14 +0000
Received: by outflank-mailman (input) for mailman id 212788;
 Tue, 19 Oct 2021 07:06:13 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=gzZp=PH=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mcjCP-000514-P5
 for xen-devel@lists.xenproject.org; Tue, 19 Oct 2021 07:06:13 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 803f1130-0449-409b-a9cd-da52609ab954;
 Tue, 19 Oct 2021 07:06:12 +0000 (UTC)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2113.outbound.protection.outlook.com [104.47.18.113])
 (Using TLS) by relay.mimecast.com with ESMTP id
 de-mta-21-VVf3VEfGMQ-tkX_0Ck1kwA-1; Tue, 19 Oct 2021 09:06:10 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB6861.eurprd04.prod.outlook.com (2603:10a6:803:13c::9)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15; Tue, 19 Oct
 2021 07:06:08 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.018; Tue, 19 Oct 2021
 07:06:08 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6PR0502CA0069.eurprd05.prod.outlook.com (2603:10a6:20b:56::46) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.18 via Frontend
 Transport; Tue, 19 Oct 2021 07:06:08 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 803f1130-0449-409b-a9cd-da52609ab954
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634627171;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding;
	bh=5JBayWtv2/ASpal+RNSqikTv9+fbklV1NnqhvXk652E=;
	b=lKeraY7cBfz76VnBP9yTaceVbnLr4aFhERUJ/aCJA17oD8YxTI5dEGpZyRYaCqCXpY86bb
	0Wlr/ptL5skK4h0j69YDrn6qGpswiGGrV4BRQfnoZBv2p0ML5V9L1wzB4ZNrMSmv0KDTrC
	4SKmGqdEztbM34YgbUutjh42r6UJ5Wg=
X-MC-Unique: VVf3VEfGMQ-tkX_0Ck1kwA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=L/wGoJJwCCUfDujWNWB3CRIsso7hRue493859cqI+DPYtJLskdnxextDFgrtUSnb2c4lD5mYiKR0zEh7mLwrlR0WbeNHZvXkla0yZNgoCvHcqrMobEd1tLZZv6EZXrjmifHpk4Ux0Ew+H6l6V+Oovb7OO11mx4RAaoOVN9QQu832feJRIp7JpVqwblEIqPHiB0vaUmszxUz2nlEC2ZuCKVRf1MeNPNM83vw+/rt2IJ9v6ADJUziGOFzpeSf8111s0KEBImMl5ND2m+KmNS7HVDY7TeajrXTeYb8Ce++2OF1ApMDQn5vxp0ZevChfZaVctPbbBxm5LdZSBOHbbnZaqQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=5JBayWtv2/ASpal+RNSqikTv9+fbklV1NnqhvXk652E=;
 b=PfyMzThPohCtNatloUyrVDFwj4wjjwpjJg7C3z+IlqiMiaDmnmkZxwVd76NqVzI6iZFwWjKD2W3Wx7rF+R6ZeRLlL7RB6qUsQHNR18nSYc90/cEKQgVQkz2VqQ/2BbBM3JLT1UYlmsFGT6igQqxot1y6kXvWvvj6/ED4aK+mm4wHL9Upc2KqYnsKaG2vBuOizgQEJIyLa0vhV2CbwNXK2FPBhnLxfIJ5r3p3ylQrKJTLGicuu0SunFzO50Gq8BdiMLoweNSfJq3gDt6Ry7FAqNCUACEokq545ZCJt4ffK6oFMmBhbvLH0JJnfjoB4WgQeENXyqdeQyTH0MsfiGl0Dw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: citrix.com; dkim=none (message not signed)
 header.d=none;citrix.com; dmarc=none action=none header.from=suse.com;
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
Subject: [PATCH 0/2] x86: HPET PC10 quirk workaround and some cleanup
Message-ID: <9963c7a2-f880-66fc-8f12-b1ddd0619c91@suse.com>
Date: Tue, 19 Oct 2021 09:06:06 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR0502CA0069.eurprd05.prod.outlook.com
 (2603:10a6:20b:56::46) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: d0cf5188-b259-4d2c-e4b0-08d992ceecf1
X-MS-TrafficTypeDiagnostic: VI1PR04MB6861:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB686182A11B877244F5F23779B3BD9@VI1PR04MB6861.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6108;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	54TP4K1XR1sMAY5kN8cMeGMx2DQH4StTfyn4sohHrQCXjgpMeYgO3xxrHxZonbYiSDXYF3y+FqMl/XMkJbNCn5WriUavDCRI67/Zew1obhNl+cTi0mSu3yo3VX3wXXTJNJir0fIURa9cj+taXTzFXWAiptO7Wbwd7C8btP+tx8iuigeJYopEow0iGsrbROFi5IsfNCLzV9f1WJg8HSJPmzfSo/Jp81AdU9BB+8voBJniEjDDI3FPQkcP90qWL3WR1pL0jB6zp1pHRpW2GRq00Ue73ER13nrFVRcCK0BCZ5DcjCQyj17LEABCShiaeD7Mx5dGe35832KpdkPClWDkZXXehRiIGT1U4AjTxdtFcFwLlK3ttrhofpkf3AE+dgZb3cyjnY+RFoIUGqBkWS3Saw8X6gb3dB256zGQmRMGpRfaBnA3ucVXoQWo7GHMBuqi8L0yv51N0+HUOj4juK/hH3n89Qiou5G2lv2no88Q0BsBAaMgOCtP1YnD3LR8cwZHxSsOBUy5w3yX9QfP9H25uHAuJPxiPG+ASmdAuwaThZoQmwzeJ3XA2us61KI5WBXkA6WweCj0qhYxKUuF92iRUn2DohKDa9xNp4kqGijJ5q28zdHSnv6P2swvdxfgA9LLBbJtzR3ZD4OcjAjrduaScEK3EVDQ2UxJiCwCNow7Rmax/XDEybpLAyvzFVGdGkDC0TknLXiAmnKzL30CieRNAtkc8HpK5oSRrosU7c7LXnM=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(508600001)(86362001)(4744005)(8936002)(66476007)(16576012)(36756003)(66946007)(66556008)(38100700002)(956004)(31686004)(2906002)(26005)(83380400001)(316002)(186003)(31696002)(6916009)(6486002)(2616005)(54906003)(8676002)(4326008)(5660300002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?MUdVTWFQeHppcEtrL0t2V3FZUy9KL2VPSTdOTnY1Tms1dk5WZWdvRENjNXBJ?=
 =?utf-8?B?WVdYbmt1Yks4amhwNUUrOWd1WCtiZ3ZiaHZZTHp2eElGaEZTcU52ZnZOUkpW?=
 =?utf-8?B?RXRwN2VEeEdaL3krY1lZRjg4c1FJZWZjM3hCZnRVL1NtU09tOW5sTzBZc0JK?=
 =?utf-8?B?UU5CQWdkSFAvZjZuRFhIR0pHZU1uZjM2VU5CL2lxcVUvbG1RMktKRFNkZkdK?=
 =?utf-8?B?V1dBckdPL2EwMHM1cnJPT2hXUTJSRERDNTN0Zk5QQkduNjNLWEROUXBQazAz?=
 =?utf-8?B?eW1oUUJrOG9yNHVYUTVUbGcyQ1Z5enJvcmJpU1J1aC8rSnE4K1JhWTZQTHBG?=
 =?utf-8?B?K0R2L25yRXBsbmpPUGUxOWpFZkp4NlpxamJSYkMwSVI2cFIyNGtsamFIZHI0?=
 =?utf-8?B?RUszSm1BMTV1TG9MNExqRURRcjg0NjJwNzlLOFV5eS9Ea2lzME1LRkxCNVBl?=
 =?utf-8?B?aHFEY2VoVVRvVi9WUi84UGpPbm1ld0pYRFh1YmpST3pzblMvVThSS3ovbnl6?=
 =?utf-8?B?K0QxZDlveEwyRXlxNStta01Edm1Fd1lIYjlETHNZYXBsdkNSREdBRGkyWWVN?=
 =?utf-8?B?bTVtdmd3YlBrS0JPbXhMSmw0YnlXTUVCeDVxS05zRWNMTndrUlBqUXRBRnR1?=
 =?utf-8?B?K1k5UmU2UUZITHZlcVZtb1RFT2orWVB5SXNBaHQyTHcrajdqVjZzOFdmMmtD?=
 =?utf-8?B?WktQVVI5a3hxckdwdzV3a2JuU1JLd3REeWZoTTkzbEh6dnhVUVZlWU5IWXZl?=
 =?utf-8?B?MGpjVlBSaUh6V2dKVyttK3JYUzRiT2xDcFcvSDdkdmhMOGxGeTJhMGVNR21u?=
 =?utf-8?B?dHk1aUR1L3V4QXVBeldOWDIvVS9hY3Y3Qnh4dmxrTE4wK1dPSnZCNG5Wc3J2?=
 =?utf-8?B?d25ZVXJtMGFucWtWOW1Ma1FzRHhaS3VqN2JOajE4WDJrYmVzcnU0cmpQQldE?=
 =?utf-8?B?VFpoNS9jQWlkOEVoUVh5OUxwSEt0b3pBNzkwbHZJRWlVWERnWG1BVGFzN2pw?=
 =?utf-8?B?NVRkQnl3VEd6SWNhUndZRy9ZZktJRjUrT0ttcjgwelJTRWdXRS9kK2k2eTM1?=
 =?utf-8?B?aHBCMFpjSk83UzNZamp6eE90YzdvL2dWdi9sayszcitPeHhzZkpqSGNGTGx5?=
 =?utf-8?B?VnV1dGNBWUdieDJZbmo0VkcvWldLbVloSFRSMnZLK1lYUDR5M2JhK2hqNk1s?=
 =?utf-8?B?MHVYRlE2K0I3d1UvR09NNEhLYUFEd2J5MGREelV2amVPNm4rclVSWmZSajJZ?=
 =?utf-8?B?NjRzRFU0NWZpTnc3NGhGSHBSK0pzMFBXRWkybXU3OUo5VmRNWmhtbGRMbjZs?=
 =?utf-8?B?eWNxRkZHcHp0YThPcHRkTHgxVDNOa1B6R1ZBaUlUQ3pXa3M1L0p6Y0RjZnJO?=
 =?utf-8?B?djBadm45Snp6NWlwdEc0MFRPbDNCeXRINVdCU0JTRFNrNHJlSkw3aUpFOUdC?=
 =?utf-8?B?bC8razhBVDgzaU5vZUVaOXc2Qkc5R1dlTXpPNnVWdVpEK0l6ajNZVWVhU0kr?=
 =?utf-8?B?ZzBscWVXR2pNcVlmSU5obXNtL3pWR3JFajdETCsrRnJoY3VFeG1YR2svYWRN?=
 =?utf-8?B?VDBJS0pJanNVRXNpczhHaUo3dDd6dEgxemRkOUd4T2g1OG9lVndkMVlCLzRp?=
 =?utf-8?B?YjRSblB1b3BSQ1pUUjh6dGVRMmllUlU2NHhIampMdFJwT1B6R3FPUE9SVnFO?=
 =?utf-8?B?M1luNklUUGlIWXczM0JxQTd6ekpCT0FBd3lXTE1veWlHTnRXbFFuMGtRRCtV?=
 =?utf-8?Q?IgEPPIz1OQB1P78zKCPkdswcNlvs60AZvMb3ZtD?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d0cf5188-b259-4d2c-e4b0-08d992ceecf1
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2021 07:06:08.6859
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +mepTyH9NenuJ6sxYkIgCbygl83LbuB0FuajnG3X7mp+ebJbJrDQ22PC4crYas+l8uohWM7/zn46/8ZAgtC7tA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6861

The workaround is a port of a recent Linux change, replacing earlier,
never accepted attempts to follow Linux in their PCI ID based working
around of the issue. The other patch is long due cleanup that I
happened to notice along the way.

1: x86/hpet: Use another crystalball to evaluate HPET usability
2: x86: de-duplicate MONITOR/MWAIT CPUID-related definitions

Jan



From xen-devel-bounces@lists.xenproject.org Tue Oct 19 07:07:47 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Oct 2021 07:07:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.212797.370813 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcjDv-0005hX-58; Tue, 19 Oct 2021 07:07:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 212797.370813; Tue, 19 Oct 2021 07:07:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcjDv-0005hQ-1x; Tue, 19 Oct 2021 07:07:47 +0000
Received: by outflank-mailman (input) for mailman id 212797;
 Tue, 19 Oct 2021 07:07:45 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=gzZp=PH=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mcjDt-0005hI-FZ
 for xen-devel@lists.xenproject.org; Tue, 19 Oct 2021 07:07:45 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id bc409989-b4cd-49f0-b490-c1d62260e4fb;
 Tue, 19 Oct 2021 07:07:44 +0000 (UTC)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2106.outbound.protection.outlook.com [104.47.18.106])
 (Using TLS) by relay.mimecast.com with ESMTP id
 de-mta-24-z47IlcbzMImtJOKQMPbZDg-1; Tue, 19 Oct 2021 09:07:42 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB6861.eurprd04.prod.outlook.com (2603:10a6:803:13c::9)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15; Tue, 19 Oct
 2021 07:07:41 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.018; Tue, 19 Oct 2021
 07:07:41 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM5PR0201CA0015.eurprd02.prod.outlook.com (2603:10a6:203:3d::25) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15 via Frontend
 Transport; Tue, 19 Oct 2021 07:07:41 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: bc409989-b4cd-49f0-b490-c1d62260e4fb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634627263;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=2z360L9um9kv6KI2fQQvUHzI9KCJe9yeHC5hFK8unxY=;
	b=jqko8vRBtlTAE8XcEqCGNatojP79Zzb7bp0zP0YV1wnPYpFaDunjQP7Sqf57QCul3VSUoS
	1xr2lPUWR9omV1RYXRR7MmILHLAuTk3l8xEpEh0QKfDzoxSuZcwMTIRr/0X/sfDgI6nqBa
	1thvisKalcUViXRA7iREWSUrGgOgudQ=
X-MC-Unique: z47IlcbzMImtJOKQMPbZDg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ka9FAXPddY2etMqWqvrRcY/LMIlTXW2VnoTuW8kSaR2Mu3NfwbrZg18I3kApYItMYHDPMVR34OWf6HOn5AAmf8dxKpjQ3Qmc3iVNNhFDlv56AEPDpdVDg6Ry32DeU9ImM24uo81kdDFVv/osNI5V08SD7Ga22nU7GWwHjXIOgoC28QhaNDXTttnwwjj0mM9lkaXbQ1KpkU8+4SYoz9Wfchcbq2//JDcHkJVpIfqYAliWffOM+3KcV0A9TxLoDTZIBtlT3DJt33lZjDsq4j6glwkqwaxN2xsu88/golTdAd5tytoEyTI5y+xq97mLcFsJkgLhYlLBhoh8gZXuWaWupg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=2z360L9um9kv6KI2fQQvUHzI9KCJe9yeHC5hFK8unxY=;
 b=Y+4Oa9Do/D8Qf4vbSC5xtLwIv7kBpjS2hBpLtaegty1owgyxteGKoJgvwYHPbNhwitUEJ5OB64WOLz7SIjSEPKU9N0V4qh5yGGaqTN3dNoLgHUD22SDXATxhW/6KHzZbqauC+xzTCpxytuhNNCNQk6z7kCgHMk7V/WJA/YM/8utBKONUnVwMz4pSoSsh8vvCYbcJ8JeCD6aEVrSSr7VzqRduGFcvpSwicg+3aVZZpXtmcYVqaFPuTXXQN+obaf+edI1U1FHfS3iz7KEBwn84NB0yBfHrmiPoKUtJIllpBoz/8wBwCL7K8VPd5qagjFPFNrvZsFtrHBZh7c9cgvvTUQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: citrix.com; dkim=none (message not signed)
 header.d=none;citrix.com; dmarc=none action=none header.from=suse.com;
Subject: [PATCH 1/2] x86/hpet: Use another crystalball to evaluate HPET
 usability
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <9963c7a2-f880-66fc-8f12-b1ddd0619c91@suse.com>
Message-ID: <da80b8dd-177c-d27a-9a00-c9538a139d37@suse.com>
Date: Tue, 19 Oct 2021 09:07:39 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <9963c7a2-f880-66fc-8f12-b1ddd0619c91@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM5PR0201CA0015.eurprd02.prod.outlook.com
 (2603:10a6:203:3d::25) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 5484f71e-84e3-45e3-72de-08d992cf2449
X-MS-TrafficTypeDiagnostic: VI1PR04MB6861:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB686162C6DB401C8A4903641DB3BD9@VI1PR04MB6861.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:3173;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	T9DtYz6Iaktmpg0NJhLXptTRizHfhY9sVvacihpmuPq3tq0WKrBQAKvqfvXMkc9z1m16JrueVruM5ptPj77wzWS4C53DSMIMFbKCDNkLAlnI2mQZjKxy0kfl256lmQk3+0pUgtXTHfDZX979cIPE2iumOWdOjuPYrtAeXVgp6XsGnmgC0oc5RJtsTAxCWBKbm6wk2rGpJUao++PoT5StlPgLlTdLysgbbnKQQ/0E92Tyw2LUjKerVjxA/eSOSO6MX/g2f0L3QsMjSq7XabKkNhBKF6osYeUwx5GwxX0cJavzKvt7fGb9eAIQttv4dAXoWae1OYXM6zHs4izZ0eS9PdCLOHHmg4ZT41235hJPHZefQlqQk0XaBL0rnW1Oj7d6fBvrBzNVYFy5mauz0PG5lGwXMXdS89BOvvO/J2g9lc+bgMB3B3GYlv2DVNDCOPlNBFFg+BA0tBWVWY+EZVaUGO2hdefS8o8KFBMv10UZvlvw4YlY9gEX1sdMJ+SAXGd41ap0CZwdxz2BFTthq1SI6ztHjSf7ecJ8Hp3eaWr5mlTMsN1jhqu5VCFUluxcCgxk+FtMvkD+NNKTrX0M+9hIwW+rcZeuFRI5xhDKyayH32GG4hWoBS7iHZjc1NS6RcTwIU3WjkIS05otLPyc0NEdNTWp9F54TamAmJqrYrKULrq1pJLLnsCqNXcqOQm/N+xO6kNgT2bdwYmDJLIOg6MjRU5DXHpDPgH8Rfpv8D7PkT5gwWbaBe2Ane+2iPkTI786
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(508600001)(86362001)(8936002)(66476007)(16576012)(36756003)(66946007)(66556008)(38100700002)(956004)(31686004)(2906002)(26005)(83380400001)(316002)(186003)(31696002)(6916009)(6486002)(2616005)(54906003)(8676002)(4326008)(5660300002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?M2dGQkdPaDNlZStOZ2ZKTjZaNEgwSzNscEJZYVNhWis1dWZPeHFGOUxCMFhi?=
 =?utf-8?B?OTFsc3JqQWY0MEU4NkEwSHRrN2RUM3lmd3VCblJEQmNPaVV5dkM4WHJmQlJV?=
 =?utf-8?B?UDNjT053dFl1UlY4RXJVQ3FObmRnbFlObUxCNjBQWXRIVVFESFk3bWlXVDNZ?=
 =?utf-8?B?dTY1cDk5bDJqZ1J1Qnhrcm5DWTNWcWV0YVlVQjBBNTdyMURhZWVUSlNQK2Qv?=
 =?utf-8?B?dHNSZzhHSmRucnRPelhSYTM3VlhkWVA0QmEyVm9KZnF0NDR6TE9QWDRJQWV1?=
 =?utf-8?B?YnV6N0tUTEVCT0ltTkFGSHJYNWZuRHdkc0pjTU1BTm5MTU9wWDdrUStBbldO?=
 =?utf-8?B?Smh0ZDVCYXVzc2NiQ1JGZzBycHVZb0xvMkRPV25MN2VNQXJUSzEvMk82Yzdv?=
 =?utf-8?B?Zm1XZXVrc2VySnlPdjZMRldOMnJ2cjVwcjBiOEFIY0c1SFlhZEFJd1NwQ3NO?=
 =?utf-8?B?eFM5Rnk0c2Z3UjlpOVkrR3g5L2ZhYmpjd2prOFh1dXBHTWRvMVZZd1N6QkQ1?=
 =?utf-8?B?OTRMZ1RMak41V2JTK2ptN2llQXhDdmltNEQ0aWM1Nm5MYXMrMVVpUXUzakxL?=
 =?utf-8?B?R3J5MFRYVnlkRmd0WE5VcGZsTGI0UnhaV0R5YW5TWEdvb0J5cFJ1KzBtdjdu?=
 =?utf-8?B?djRmMVRoYWE5NFI0Mm9BZlRJRkdGZGhGRDdjQXlEekxmcG1uMUhCY0hpUlVR?=
 =?utf-8?B?ZGdnRUhZUGZWVmJVRitDNVJwSEljT0VzSXpsZHlHeXBOdG95eHZOVFhLU0My?=
 =?utf-8?B?ZWl3c0FYT09ESlMvTTdiUXY3NTBZdnEwcDlnYTQvcitBZ0ZBTFZKdkFNQVpS?=
 =?utf-8?B?dzRiMmZwbElxZ2VQSW9DeVEyZ3E2RS94Ny9LMDFsSzJCT21xa0ZCZ0QwazVD?=
 =?utf-8?B?VUV1OXBWak5MUXprbnhIY0EyNFU1RWZ0OFJ2OEFHaXRUMHg5S2dNZTlZNzBZ?=
 =?utf-8?B?TzJOVDZtZm85bjdEQm8vZDRqRDB1OWRJMkY3NG4yYWFrTlhjRE00Wjg4RE5D?=
 =?utf-8?B?Nnh4Y1QrME5oM21IdDkzdkFKeGRScVpPTGVraDFkcjM3VXpKakVZNnVHeUNO?=
 =?utf-8?B?Mkk3K1FDYXV6OWhpVzhWb3RpQ1l2STdDY0JWVlEvVjlEQnBzU1lwNFhZOFBR?=
 =?utf-8?B?M0pKMG1kZ3NVREdMZ2VvUTBpK2xSbFUvRzcraGIzRGtJN3pPWmVJZnM4NnZ5?=
 =?utf-8?B?cWs1QTBrU0wvcTNzbkFtdE12M3o0a1hFRzNVdURTL2JXdENPR29sUHZzWkFX?=
 =?utf-8?B?YmF6dWoyVmluMXFPYVQwS2xzSFhUWEsyb01WakR6aFpPbVRpVHdZYjA0ZWl2?=
 =?utf-8?B?ckNndjVia0hTaytpU1RudnMySHJ6WnZtVVN0OVdEQ3ZTVmZxdGRSdXB0RE9v?=
 =?utf-8?B?SXpKOW5yQmVJZkxVSzF4TDJMTlcvSGNIaGM2OXRvaWo2K0dVU3luSzhXQ3k3?=
 =?utf-8?B?RndzUDdpTS85amhrQjBVVEY2VEdpR3c5cytYSm52U3lVWVdBbzg4a0MxZnVs?=
 =?utf-8?B?RXlpVkJzUmI1TjBhSkNGVWZRNzBIQVBieEZqemVPcXl5YVZrbWhBT2NkWkpD?=
 =?utf-8?B?czkzSjFmYTFVM1psdmJPMTc2QmRXS0ZybGhoTjVTbnRwOFFndnIzeGt6aTRV?=
 =?utf-8?B?VkEzdXB3TVZCdVdUMXM0SHhBVngxQlpoRG9oNERGMGtHeUxEUFZteWdIczhT?=
 =?utf-8?B?MmVseWc1NUdaM081c3pxekpFeGFIdGFMZW1UUzJ3WTlob1VoZ0VHMmoyajFa?=
 =?utf-8?Q?qZ7BmS3XYDYkNB/ZCgi3xiJPS7AsmH6evNRf+rU?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5484f71e-84e3-45e3-72de-08d992cf2449
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2021 07:07:41.5534
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zi/aHSR4yXV0y7Zz54bM9PUYWsSI6K23SYPMDLCmqtQkzQBw7Ejd4xI6hWU6JiHf3U65OjjNRiIbjIxlcaDXBg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6861

From: Thomas Gleixner <tglx@linutronix.de>

On recent Intel systems the HPET stops working when the system reaches PC10
idle state.

The approach of adding PCI ids to the early quirks to disable HPET on
these systems is a whack a mole game which makes no sense.

Check for PC10 instead and force disable HPET if supported. The check is
overbroad as it does not take ACPI, mwait-idle enablement and command
line parameters into account. That's fine as long as there is at least
PMTIMER available to calibrate the TSC frequency. The decision can be
overruled by adding "clocksource=hpet" on the Xen command line.

Remove the related PCI quirks for affected Coffee Lake systems as they
are not longer required. That should also cover all other systems, i.e.
Ice Lake, Tiger Lake, and newer generations, which are most likely
affected by this as well.

Fixes: Yet another hardware trainwreck
Reported-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
[Linux commit: 6e3cd95234dc1eda488f4f487c281bac8fef4d9b]

I have to admit that the purpose of checking CPUID5_ECX_INTERRUPT_BREAK
is unclear to me, but I didn't want to diverge in technical aspects from
the Linux commit.

In mwait_pc10_supported(), besides some cosmetic adjustments, avoid UB
from shifting left a signed 4-bit constant by 28 bits.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
v2: Fully different replacement of "x86: avoid HPET use also on certain
    Coffee Lake H".

--- a/xen/arch/x86/time.c
+++ b/xen/arch/x86/time.c
@@ -34,6 +34,7 @@
 #include <asm/fixmap.h>
 #include <asm/guest.h>
 #include <asm/mc146818rtc.h>
+#include <asm/mwait.h>
 #include <asm/div64.h>
 #include <asm/acpi.h>
 #include <asm/hpet.h>
@@ -395,14 +396,43 @@ static int64_t __init init_hpet(struct p
             }
 
         /*
-         * Some Coffee Lake platforms have a skewed HPET timer once the SoCs
-         * entered PC10.
+         * Some Coffee Lake and later platforms have a skewed HPET timer once
+         * they entered PC10.
+         *
+         * Check whether the system supports PC10. If so force disable HPET as
+         * that stops counting in PC10. This check is overbroad as it does not
+         * take any of the following into account:
+         *
+         *	- ACPI tables
+         *	- Enablement of mwait-idle
+         *	- Command line arguments which limit mwait-idle C-state support
+         *
+         * That's perfectly fine. HPET is a piece of hardware designed by
+         * committee and the only reasons why it is still in use on modern
+         * systems is the fact that it is impossible to reliably query TSC and
+         * CPU frequency via CPUID or firmware.
+         *
+         * If HPET is functional it is useful for calibrating TSC, but this can
+         * be done via PMTIMER as well which seems to be the last remaining
+         * timer on X86/INTEL platforms that has not been completely wreckaged
+         * by feature creep.
+         *
+         * In theory HPET support should be removed altogether, but there are
+         * older systems out there which depend on it because TSC and APIC timer
+         * are dysfunctional in deeper C-states.
          */
-        if ( pci_conf_read16(PCI_SBDF(0, 0, 0, 0),
-                             PCI_VENDOR_ID) == PCI_VENDOR_ID_INTEL &&
-             pci_conf_read16(PCI_SBDF(0, 0, 0, 0),
-                             PCI_DEVICE_ID) == 0x3ec4 )
-            hpet_address = 0;
+        if ( mwait_pc10_supported() )
+        {
+            uint64_t pcfg;
+
+            rdmsrl(MSR_PKG_CST_CONFIG_CONTROL, pcfg);
+            if ( (pcfg & 0xf) < 8 )
+                /* nothing */;
+            else if ( !strcmp(opt_clocksource, pts->id) )
+                printk("HPET use requested via command line, but dysfunctional in PC10\n");
+            else
+                hpet_address = 0;
+        }
 
         if ( !hpet_address )
             printk("Disabling HPET for being unreliable\n");
--- a/xen/arch/x86/cpu/mwait-idle.c
+++ b/xen/arch/x86/cpu/mwait-idle.c
@@ -1308,3 +1308,20 @@ int __init mwait_idle_init(struct notifi
 
 	return err;
 }
+
+/* Helper function for HPET. */
+bool __init mwait_pc10_supported(void)
+{
+	unsigned int ecx, edx, dummy;
+
+	if (boot_cpu_data.x86_vendor != X86_VENDOR_INTEL ||
+	    !cpu_has_monitor ||
+	    boot_cpu_data.cpuid_level < CPUID_MWAIT_LEAF)
+		return false;
+
+	cpuid(CPUID_MWAIT_LEAF, &dummy, &dummy, &ecx, &edx);
+
+	return (ecx & CPUID5_ECX_EXTENSIONS_SUPPORTED) &&
+	       (ecx & CPUID5_ECX_INTERRUPT_BREAK) &&
+	       (edx >> 28);
+}
--- a/xen/include/asm-x86/mwait.h
+++ b/xen/include/asm-x86/mwait.h
@@ -1,6 +1,8 @@
 #ifndef __ASM_X86_MWAIT_H__
 #define __ASM_X86_MWAIT_H__
 
+#include <xen/types.h>
+
 #define MWAIT_SUBSTATE_MASK		0xf
 #define MWAIT_CSTATE_MASK		0xf
 #define MWAIT_SUBSTATE_SIZE		4
@@ -12,5 +14,6 @@
 #define MWAIT_ECX_INTERRUPT_BREAK	0x1
 
 void mwait_idle_with_hints(unsigned int eax, unsigned int ecx);
+bool mwait_pc10_supported(void);
 
 #endif /* __ASM_X86_MWAIT_H__ */



From xen-devel-bounces@lists.xenproject.org Tue Oct 19 07:08:29 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Oct 2021 07:08:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.212804.370824 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcjEb-0006Ib-E6; Tue, 19 Oct 2021 07:08:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 212804.370824; Tue, 19 Oct 2021 07:08:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcjEb-0006IU-B6; Tue, 19 Oct 2021 07:08:29 +0000
Received: by outflank-mailman (input) for mailman id 212804;
 Tue, 19 Oct 2021 07:08:28 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=gzZp=PH=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mcjEa-0006IH-2I
 for xen-devel@lists.xenproject.org; Tue, 19 Oct 2021 07:08:28 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id dfe17ab5-99b8-4b88-9497-cdc0a17bf1f5;
 Tue, 19 Oct 2021 07:08:27 +0000 (UTC)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2054.outbound.protection.outlook.com [104.47.13.54]) (Using
 TLS) by relay.mimecast.com with ESMTP id de-mta-4-7Bpm2fIYOzGrys18EFooIg-1;
 Tue, 19 Oct 2021 09:08:25 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB6861.eurprd04.prod.outlook.com (2603:10a6:803:13c::9)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15; Tue, 19 Oct
 2021 07:08:24 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.018; Tue, 19 Oct 2021
 07:08:24 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM5PR0201CA0020.eurprd02.prod.outlook.com (2603:10a6:203:3d::30) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16 via Frontend
 Transport; Tue, 19 Oct 2021 07:08:23 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: dfe17ab5-99b8-4b88-9497-cdc0a17bf1f5
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634627306;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=W9iDjP91x9uw6yyMgsmNw7ncw5R31osBpuVcl9P/JHo=;
	b=QfN91mYXz7p1zgkp+0sPUZSqjstHNMYSd16AfDiRmIN+bIVtwXpr8Q0tCwPugBPrW1vNwu
	uYqgX5wK3qKS+jssvyaiWhb81gKmuagKOi9KL5H9VkIrSEWLc/QUv1RaQ9aDmKnPtYbuvL
	br5AvF5WzTmMJzRHDHMPpZVTw+dj3BY=
X-MC-Unique: 7Bpm2fIYOzGrys18EFooIg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=NYmnxWmGXyMtV/gt4dO+u389Kx9vbr4SbyuQYKvRIdr8Ns8Cu35/UuhoG7PF9XwM+xrFMdtgs4bTjIiwh44miDxAwM1fn3CC9/etHUECSFL3ZOjiwk68IGUJzG/mMXf1CNykYpymDrrs/MTGDgy/nA8gjBjAtpkgi05HpAZ01WnGTdGIWtqUFF6p1zLsTdcSusxZjOv7XbvbqgzwnNro8SLIAfFGLc6XpWIjmojogO4fF/Cg2C6F6k486ojjyQYDo8NYJKzz6BGEPQaEAR938CmJbSECAIOepnj3ypsrSJgwl1JqrKDSql2tSl1p9ZujmRQqwFd47ilb2gp+dHqJKA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=W9iDjP91x9uw6yyMgsmNw7ncw5R31osBpuVcl9P/JHo=;
 b=aYqEd6ZkSZs8iUFYkyjzDx6wfV88uixGay4Gk1+OPuFweE1/17nn26jlPqeGwnB0BZ3c3HkTFfDNJTkA0IjN9MslCEzwcBHwFQFDYlwEe4f/mZeGxmWnfXvWWBkpMqkHYAVGAW6kb4ZxAYouYTy7x7HszOH5cARY3N+0akuHF7m0kQc7nH99H/SEdJfSdNO5SfX/kHx+E21cn9EHf55flF5cf9iSiWA65yz6HDkKRba96QSlk3k1+MMXY6PxdkCdxedR5hTAkvjxSbdAOFrgfHuEiwcsgNfNfADmVujjNIKChvnsGSdNO22caGHdEyX/1Yh+Fh5Mianb67qHNEvYcg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: citrix.com; dkim=none (message not signed)
 header.d=none;citrix.com; dmarc=none action=none header.from=suse.com;
Subject: [PATCH 2/2] x86: de-duplicate MONITOR/MWAIT CPUID-related definitions
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <9963c7a2-f880-66fc-8f12-b1ddd0619c91@suse.com>
Message-ID: <b809979b-5d43-482b-921b-65a4e203db2f@suse.com>
Date: Tue, 19 Oct 2021 09:08:22 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <9963c7a2-f880-66fc-8f12-b1ddd0619c91@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM5PR0201CA0020.eurprd02.prod.outlook.com
 (2603:10a6:203:3d::30) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 96347f4d-d916-4dfe-4973-08d992cf3db7
X-MS-TrafficTypeDiagnostic: VI1PR04MB6861:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB6861B3AEC9A63334E063B2AAB3BD9@VI1PR04MB6861.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:4941;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	YVjqP4l1zR34Qu9DUZYTho8qhXOpurt75y1uqa2cO+xFED93+zBIuLJGu3WFtM3mOfS3/fNPHHeHQm+X1Vmp+DDtrPRwR1Pn4PBbsWfnl0NwWETP/jtro0DyKbTM83u8xKkNcZeHGBlCGUWhrytaDxqQvPNuSdH7kpbJzN2Pehm1WevPtoSK5FW2c11zU75txnFwlBX6g0hNK5Jp86tByPJqWQLgUwYdikJG4SOT2drMMKklOqbKXN2iGAtfnPydkVhnsbB6i8EYc1ewS4J8jHEu5j7HF/WCJ8ZNcqvPG4Mvf6K9jYRnInCH4/MtXLZWNCpxI12HOIRHVAPTL1xNI6bNyCRhQpHetd3nw90AuY/qhMKbNrn8lSfhSdIgIsXjU1/xGki7Aee57hYKExm5lA1Pr0aUm5nBUqEhGE0+MSOUlmpwOyhEy0FMy2og/voKbcxlAd9MavdsvtHkNVReI2SXSrb5D9jUHEWrU5pcgoKPAwywgnbjM553I5JCy+/KQkoIv6aj0Jrl0O4M/j+PbcDJdoOB7Ksxcm1QcwHMFe0vOn9c6qZJVxwwURXCT0r9rJY7MkSm+N88bZd421ngHqU2zWwn7qr/5V+7D500yIeQJsOPM3sW1FFjXBtSUgQnMyPYbiNOFCelJkZbs6VDuBm6pvV6YJCsb6JCmF0qXKzW1Vdm83Ss9Nf4LtIhNKV0v3usAHPDJY/XbeW4K3qPdrbOEsPob6kZbUm+zGmq4jU=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(508600001)(86362001)(4744005)(8936002)(66476007)(16576012)(36756003)(66946007)(66556008)(38100700002)(956004)(31686004)(2906002)(26005)(316002)(186003)(31696002)(6916009)(6486002)(2616005)(54906003)(8676002)(4326008)(5660300002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?cHVlUGc2RWFZSy9RbG54Z0g5ZGJrOGFuR05wK1RDeGc0cHNqTE9DUVJpN245?=
 =?utf-8?B?d3lPU01Qb3Z1Y3cyaHRRblRzUnczRytlSmQrNTlNUGd6b3lYMDkvN2EybzJB?=
 =?utf-8?B?OGRKMkFubE8wMWNVVU5ISEFwMTBXMnZvc3JsenhsMWJnM0xyS3czTkE3Vklm?=
 =?utf-8?B?dGZUa2M5VDB2dVdicUpaeDdteFBQVytWUTlmdHNudW9jandUdGVnQTU3THhZ?=
 =?utf-8?B?aGJubkV2emsyY2ZuVFcxM1NvR25Gc2x4SVBjUFpwMjFpTndOSHorU1cwdWlD?=
 =?utf-8?B?bkI1Mmo0U2NUMlJFaUFxaW9SVTdoQ1dCL1M2b2ZYcWtxd04vR081MisxSXNF?=
 =?utf-8?B?QVdQYkJsa1daZUtlMnBZd2htaG5QZGJjNlBvUm9zQmtNWDZRUkhmejE4K3Zi?=
 =?utf-8?B?VWhqM3I0blk4TnhkUERadHh5VmZYLzFwQXlJZnJISVdXZkZSZlVYbWV6eGZB?=
 =?utf-8?B?VGh6U0h6NkxiRUdpMkJmR3cyWm5aS2c1YXpLUFF6STBDclpFTDRXZzAyRGFt?=
 =?utf-8?B?N1B5R0lNZ0R6ejk4am9IVDJxRXZmb1d6UldCaHBHNWgyZTFNZXJaSEFWOWhT?=
 =?utf-8?B?RU91L1QvNjlhbmM4Qk1pYUFjUDhhOWN5VzFHMlJyMzRwdXVEcXlJaUJlU0Fl?=
 =?utf-8?B?dWk1R2kzZnM3M1BUd3BjazhvRVNNQi80SjgrbFlxREJFWmpvMHFKdkNXdWZO?=
 =?utf-8?B?RnR1akMxQTBqRU8yK2VHY3NNaDRHc3pGSTk1alZhVEdiVHNGZGoxWm5hWmE4?=
 =?utf-8?B?WiswR052Z3c4WVNrVXE4dDFTUm4rNGNjWmVtaEl0TG0wVFVoaU9WWGltWENn?=
 =?utf-8?B?ZFFkaEd6QWtXWUFkM29MNncxb1UwWTBua3RMTHphdEN6dkFUV2E3aUozTy9u?=
 =?utf-8?B?MHpZNitIeTJlK2crcWcvTDhWcEJlWldQTi9PVlFiUHgybGN5bnF1bHhLN0JD?=
 =?utf-8?B?dXFUVHhqWCtsbXNJNUhJK2l5dzB3LzdqNGhIMC91Y2ErdDJCTzNhZEEra1Nh?=
 =?utf-8?B?ZkVON0VMejJ0aVJ1MzVnOWR1RHcwTTVZTFB5b0FoM2s0T1N5TzJQMG93VHlC?=
 =?utf-8?B?TmlHUzZGcHcxS01SYXk3Sm9UUFRZdGRVVjFsaVAzRlhoUlRNb05vTFdXNXZT?=
 =?utf-8?B?ODcxakRWRnBxeHRqNVFod0libkUzcjBYdjVjcEVpdi9lK0M5dGxJNUpvb2VC?=
 =?utf-8?B?aUNNblV3WXQ5SS84Q0w0SXBjNDV5bXhiR05IdXp0WlVWTGFubUtGcFkvOVky?=
 =?utf-8?B?djNhMm1pZVNzZGNQUXNBZmRsMEdZTXJ5TWZ1WmxkNTY3WmxobVFzQzA1N3Zi?=
 =?utf-8?B?MlpGbUtwUC9HQ0c4bWZKcVFEWDBxcUowY0traE9HRkRmUkZhVkxqZXJPUUkx?=
 =?utf-8?B?ajZxUGVRcU0vWFVJQ0JKQzA3WEtSY2I4NW5iL0UrT3JJK3dyMTV2M203bUlG?=
 =?utf-8?B?cWNHVkNQUnNLYTFEaG93U0dkS09VVkllQWdYVHVIa3BCNko0UWhYc2Vya3N6?=
 =?utf-8?B?TW9lbXpiTDBLaFp4citZa3VkcmpibzlUS1luN1hPSWs4aEUxQnhzY1VPdkVB?=
 =?utf-8?B?ZjlaRkpzZExkdStGMDlWbnl2NTVQSytSdzdrUG52aWZ1VUV3RUNWN29uU2dY?=
 =?utf-8?B?NWFIcmpSS2I1aGIvbm5RbDlaNXRSM3JNSGxieDF1SDBiTi9WNXU2bnE5bGRK?=
 =?utf-8?B?VjRrYndyRytIclpJbWNXS0ptTWZ2NklTbnovQk84OTEyQnM2Sk50MFhzblJu?=
 =?utf-8?Q?Z+w7eFeRT9XQu+rIfI6CBCIExvrkdsalnaUQKtu?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 96347f4d-d916-4dfe-4973-08d992cf3db7
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2021 07:08:24.2242
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: yVAsLxfqFr+YcxOemrIdQ1VCRfYvHC6gT9/kD6sak9PsuKAgqSFMPflAaVbP2A4eNkhpNWzgQrPVSyjvEx+5lQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6861

As of 724b55f48a6c ("x86: introduce MWAIT-based, ACPI-less CPU idle
driver") they (also) live in asm/mwait.h; no idea how I missed the
duplicates back at the time.

Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/arch/x86/acpi/lib.c
+++ b/xen/arch/x86/acpi/lib.c
@@ -24,6 +24,7 @@
 #include <xen/acpi.h>
 #include <asm/apic.h>
 #include <asm/fixmap.h>
+#include <asm/mwait.h>
 
 u32 __read_mostly acpi_smi_cmd;
 u8 __read_mostly acpi_enable_value;
--- a/xen/include/asm-x86/cpufeature.h
+++ b/xen/include/asm-x86/cpufeature.h
@@ -22,10 +22,6 @@
 #define cpu_has(c, bit)		test_bit(bit, (c)->x86_capability)
 #define boot_cpu_has(bit)	test_bit(bit, boot_cpu_data.x86_capability)
 
-#define CPUID_MWAIT_LEAF                5
-#define CPUID5_ECX_EXTENSIONS_SUPPORTED 0x1
-#define CPUID5_ECX_INTERRUPT_BREAK      0x2
-
 #define CPUID_PM_LEAF                    6
 #define CPUID6_ECX_APERFMPERF_CAPABILITY 0x1
 



From xen-devel-bounces@lists.xenproject.org Tue Oct 19 07:32:03 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Oct 2021 07:32:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.212816.370835 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcjbH-000178-BT; Tue, 19 Oct 2021 07:31:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 212816.370835; Tue, 19 Oct 2021 07:31:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcjbH-000171-8H; Tue, 19 Oct 2021 07:31:55 +0000
Received: by outflank-mailman (input) for mailman id 212816;
 Tue, 19 Oct 2021 07:31:55 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=d5uN=PH=suse.com=jgross@srs-us1.protection.inumbo.net>)
 id 1mcjbG-00016v-U5
 for xen-devel@lists.xenproject.org; Tue, 19 Oct 2021 07:31:54 +0000
Received: from smtp-out1.suse.de (unknown [195.135.220.28])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 204e53b8-c64a-4505-825c-fa849541d363;
 Tue, 19 Oct 2021 07:31:54 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 303702197E;
 Tue, 19 Oct 2021 07:31:53 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id F3C0E13CEE;
 Tue, 19 Oct 2021 07:31:52 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id 2+gnN2h0bmEccgAAMHmgww
 (envelope-from <jgross@suse.com>); Tue, 19 Oct 2021 07:31:52 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 204e53b8-c64a-4505-825c-fa849541d363
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1634628713; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=x8cUE7tOnsITujGfnLd+t6drEURh8EHS6ZYA83UMPPk=;
	b=tgqyNsBhmVaVWm+gASeoKrXHRdKu1fNKgVL/NR2pQH6nomxb2aWeZ+GZtYKPh407kSgY6b
	M4mZ0hMRAAdN3HhdGAQ6cVf+KsjQPaUGnp2UW8Lev6xLvx7/jb/MZQU5DhgAwwa9p4qweG
	qlBUrlm0zHGjZR1NyVI4z+7RL3iOjbM=
To: Jan Beulich <jbeulich@suse.com>
Cc: Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
References: <20211019044123.29648-1-jgross@suse.com>
 <0c93abe3-3908-009f-efca-08000092cd4d@suse.com>
From: Juergen Gross <jgross@suse.com>
Subject: Re: [PATCH] tools: fix oom setting of xenstored
Message-ID: <c486ebb9-7cda-da67-7122-bceb291805b3@suse.com>
Date: Tue, 19 Oct 2021 09:31:52 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <0c93abe3-3908-009f-efca-08000092cd4d@suse.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="GpF4t1dCyDbhmqfV84Jn6DMaCc4F9KeBK"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--GpF4t1dCyDbhmqfV84Jn6DMaCc4F9KeBK
Content-Type: multipart/mixed; boundary="ECDTjyHLIejfBfecnbmih8UWELNpftYrA";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
Message-ID: <c486ebb9-7cda-da67-7122-bceb291805b3@suse.com>
Subject: Re: [PATCH] tools: fix oom setting of xenstored
References: <20211019044123.29648-1-jgross@suse.com>
 <0c93abe3-3908-009f-efca-08000092cd4d@suse.com>
In-Reply-To: <0c93abe3-3908-009f-efca-08000092cd4d@suse.com>

--ECDTjyHLIejfBfecnbmih8UWELNpftYrA
Content-Type: multipart/mixed;
 boundary="------------9FE7A23CD25ED1718AB5F75B"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------9FE7A23CD25ED1718AB5F75B
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 19.10.21 08:54, Jan Beulich wrote:
> On 19.10.2021 06:41, Juergen Gross wrote:
>> --- a/tools/hotplug/Linux/launch-xenstore.in
>> +++ b/tools/hotplug/Linux/launch-xenstore.in
>> @@ -60,7 +60,7 @@ test -f @CONFIG_DIR@/@CONFIG_LEAF_DIR@/xencommons &&=
 . @CONFIG_DIR@/@CONFIG_LEAF
>>   		echo "No xenstored found"
>>   		exit 1
>>   	}
>> -	[ -z "$XENSTORED_OOM_MEM_THRESHOLD" ] || XENSTORED_OOM_MEM_THRESHOLD=
=3D50
>> +	[ -z "$XENSTORED_OOM_MEM_THRESHOLD" ] && XENSTORED_OOM_MEM_THRESHOLD=
=3D50
>=20
> Is resilience against "set -e" being in effect of interest? If so I
> think this would want to be

I don't think set -e would have a negative effect on above line. The
bash man-page tells me that:

   The shell does not exit if the command that fails is part of the
   command list immediately following a while or until keyword, part of
   the test following the if, ...

And I believe that "[ ... ]" is treated like an "if". A short test
showed that bash indeed does not exit in this case:

   ( set -e; [ -z "" ] && xx=3Dokay; echo $xx; )

This will print "okay", so bash didn't exit.

>=20
> 	[ -n "$XENSTORED_OOM_MEM_THRESHOLD" ] || XENSTORED_OOM_MEM_THRESHOLD=3D=
50
>=20
>>   	XS_OOM_SCORE=3D-$(($XENSTORED_OOM_MEM_THRESHOLD * 10))
>=20
> Alternatively, how about dropping the line above and using
>=20
>   	XS_OOM_SCORE=3D-$((${XENSTORED_OOM_MEM_THRESHOLD:-50} * 10))
>=20
> here?

This would be an option, yes.

Unless a maintainer wants me to send another patch with this change I'll
keep it as it is now.


Juergen

--------------9FE7A23CD25ED1718AB5F75B
Content-Type: application/pgp-keys;
 name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Transfer-Encoding: quoted-printable
Content-Description: OpenPGP public key
Content-Disposition: attachment;
 filename="OpenPGP_0xB0DE9DD628BF132F.asc"

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy=
cWx
w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O=
f8Z
d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y=
9bf
IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq=
G7/
377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR=
3Jv
c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA=
QIe
AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT=
hpw
dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0=
MbD
1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv=
oPH
Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v=
5QL
+qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ=
2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC=
QoL
BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr=
Wf0
teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC=
/nu
AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh=
ITT
d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm=
XBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz=
80h
SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC=
AcD
AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn=
FOX
gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1=
jnD
kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0=
N51
N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l=
otu
fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1=
tqS
EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA=
hsD
BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3=
g3O
ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5=
dM7
wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5=
D+j
LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm=
V2x
AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N=
Eaw
QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW=
nHI
s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR=
wgn
BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV=
bVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk=
pEd
IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA=
QAB
wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw=
Tbe
8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1=
vJz
Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8=
VGi
wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW=
svi
uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX=
zXs
ZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------9FE7A23CD25ED1718AB5F75B--

--ECDTjyHLIejfBfecnbmih8UWELNpftYrA--

--GpF4t1dCyDbhmqfV84Jn6DMaCc4F9KeBK
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmFudGgFAwAAAAAACgkQsN6d1ii/Ey9K
FQf/TqhSWZcGbsMBdkai3xGHJ0UmdDdqrlzz5C8mFDGk8ahGPxR8+HOM0lqgSljg8qEd3AUFIuFg
KcirtHqkGq5Zvs4WEMJuihVOpZVKIpcmMoql2zZFKSORCRWcY6xo+LTkZqAn8gluY3da7jyaOXo+
+x24XXUg3IfkWuqveHuE9u+kqW5kxLMcbYCPLdJtmZRQ8NppxDSoP2522z87JgH+zj2NtjLt1QpU
vGAjEPBgPZKXYxesFP+yelyo06wVnDIllw/3TVI0RIfjIn79MDclfZBjMlfXiUBhKKO8Y1Fsq+Wq
wm47tIOgXSOIjYKrNb9U75aHftIhLw2PzvZfXcXLJw==
=r76W
-----END PGP SIGNATURE-----

--GpF4t1dCyDbhmqfV84Jn6DMaCc4F9KeBK--


From xen-devel-bounces@lists.xenproject.org Tue Oct 19 07:46:10 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Oct 2021 07:46:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.212827.370852 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcjoz-0002hx-PH; Tue, 19 Oct 2021 07:46:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 212827.370852; Tue, 19 Oct 2021 07:46:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcjoz-0002hq-MB; Tue, 19 Oct 2021 07:46:05 +0000
Received: by outflank-mailman (input) for mailman id 212827;
 Tue, 19 Oct 2021 07:46:04 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=eXNP=PH=citrix.com=roger.pau@srs-us1.protection.inumbo.net>)
 id 1mcjoy-0002hk-6D
 for xen-devel@lists.xenproject.org; Tue, 19 Oct 2021 07:46:04 +0000
Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 9a9520d6-30b0-11ec-8305-12813bfff9fa;
 Tue, 19 Oct 2021 07:46:01 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9a9520d6-30b0-11ec-8305-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1634629561;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=kPvnOFF6e+CIHo8PKZ0IM85N6dI6NrnsASITc8qAUnA=;
  b=VlwSY/la2sqv7/ORdU/EkFFRaYSaBJlEnQOOANftRqmVH3pD/pOYHkjG
   MUqhv76MdOdTYS3PkfJwJ9M5pVaGBaxvo1vtSfk1T2+ksiuIy1xIq1N96
   JVzl7YQq11NeYRatmvd7pu3lx8pSYMBPamzwkP/Xzdoi4Z3xgk6eGPteX
   M=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: COHYvfMboBdCf91H+pn7u6lVfECoIG8Hro3ysJFb5BI6NZNi2TaSf5IkmCjd42cuRK2WQwE7OE
 oTSSCX1EQN14Lqv4YpVS/DfxswE1T5jWRN6fuy/7PDPKxoqQMeeX+9QnCPLcWvrV/sSYAVLoU0
 F1wTu/l6pVZUIBg2rHi9o21jMhY9MSq+0TgXRczrWN3YgRE/5T+4T6vA+W3Ew8RQLmndtXRFEV
 MK+I1IxWxrhf+yIi7DqOCTAnf6sVLcpnFjefcoO1RGT0VZLkXZP+6Tb3CXrJ2EC3kFJcFDRsb/
 FZ70yimKGJRrDQNEX5dnAmBs
X-SBRS: 5.1
X-MesageID: 57404957
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:3Thg3K6J9LcLWJfgmmIPLwxRtJLAchMFZxGqfqrLsTDasY5as4F+v
 jQXCGyEM/+CZmbwc952bITl/U8O78TXmtdhSwRo+XsxHi5G8cbLO4+Ufxz6V8+wwmwvb67FA
 +E2MISowBUcFyeEzvuV3zyIQUBUjclkfJKlYAL/En03FVIMpBsJ00o5wrdh298w2LBVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Zk
 dZB64fvQAUQPrDrwdo0TDAEAnF5BPgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALNs7kMZlZonh95TrYEewnUdbIRKCiCdpwgWhs3pwfQKm2i
 8wxSmVLMBjlZj1zJl4OErkXnsHzuEKgWmgNwL6SjfVuuDWCpOBr65DsL9j9atGMXd9SnEuTu
 iTB5WuRKgkCNcaUwD6M+G+EjO7TkS71VYQeGaf+/flv6HWax3caCRkffVG6vfW0hEO4V99Fb
 UcT/0IGsaE3/VeDUtr5Uhu3sXOA+BUbXrJ4Eec39QWMwar8+BuCCy4PSTspQMwrsoo6SCIn0
 neNnsj1Hnp/vbuNU3Wf+7yI6zSoNkAowXQqPHFeC1Ffup+6/d913kmnostf/LCd1975Ryqvy
 jKzrDUZ3os6kudXxvW8xAWS696znaThQgkw7wTRe2uq6AJleYKoD7CVBUjnAeVod9nBEAHQ1
 JQQs43HtrpWVMDS/MCYaLxVROnB2hqTDNHLbbeD9bEa/DOx52XrQ4lU5DxvTKuCGpdZIWG3C
 KM/VAU42XOyAJdIRfMoC25SI55zpUQFKTgDfqqEBjapSsMpHDJrBAk0OSatM5nFySDAa50XN
 5aBatqLBn0HE6lhxzfeb75DiuN2lnpgnTmNHMCTI/GbPVy2Pi79pVAtawPmUwzExPnc/FW9H
 yh3ZqNmNCmzoMWhO3KKoOb/3HgBLGQhBICeliCkXrXrH+aSI0l4U6W56ep4I+RNxv0J/s+Vr
 iDVchIJkzLX2CyYQThmn1g+MdsDq74k9illVcHtVH71s0UejXGHvP5OKcpnI+N5nAGhpNYtJ
 8Q4lwy7Kq0nYhzM+igHbIm7q4pndR+xghmJMTbjaz86F6OMjSSTkjM9VgewpiQIEAStss4y/
 ++p2g/BGMJRTAV+FsfGLvmoygrp73QanetzWWrOI8VSJxqwoNQ7dXSpg69lOdwIJDXC2iCei
 1ScDyAHqLSfuIQy6tTI2/yJ9t/7D+tkE0NGNGDH9rLqZzLC92+uzNYYAuaFdDzQTk3u/6Cma
 bkHxv3wKqRfzl1Lr5B9A/Bgyqdnv4njoLpTzwJFGnTXbgv0VuM8cyfehcQW7/9D3L5UvweyS
 3mjwNgCNOXbIt7hHX4QOBEhMraJ28YLl2SA9v8yOkj7unN6peLVTUVIMhCQoyVBN78pYpg9y
 OIstcNKuQyyjh0mboSPgixOrjneK3UBV+Mst40AAZ+tgQ0ukwkQbZvZAy7wwZeOd9QTbRV6f
 m7K3PLP1+ZG207PU3svDnycj+NSiKMHtA1O0FJfdU+CncDIh6Nv0RBcmdjtot+5EvmTPzpPB
 1VW
IronPort-HdrOrdr: A9a23:n3w5xqr3yVkcNmQ1q79YrSAaV5u4L9V00zEX/kB9WHVpm5Oj+f
 xGzc516farslossREb+expOMG7MBXhHLpOkPQs1NCZLXXbUQqTXftfBO7ZogEIdBeOk9K1uZ
 0QF5SWTeeAcmSS7vyKkDVQcexQuOVvmZrA7Yy1ogYPPGMaGJ2IrT0JcTpzencGNTWubqBJba
 Z0iPA3wAZJLh8sH7qG7zQ+LqT+juyOsKijTQ8NBhYh5gXLpTS06ITiGxzd+hsFSTtAzZor7G
 CAymXCl+uemsD+7iWZ+37Y7pxQltek4txfBPaUgsxQDjn3kA6naKloRrXHljEop+OE7kosjb
 D30lgdFvU2z0mUUnC+oBPr1QWl+DEy60X6wVvdunfnqdyRfkNwN+NxwaZiNjfJ4Uspu99xlI
 hR2XiCipZRBRTc2Azg+tnhTXhR5wmJiEtntdRWo21UUIMYZrMUh5cY5llpHJAJGz+/wJw7Ed
 NpENrX6J9tABOnhkjizyxSKeGXLzAO9k/seDlEhiXV6UkWoJlB9Tpb+CRF9U1wsq7USPF/lq
 z52+pT5ehzpmJ/V9MLOA47e7rDNoX6e2OEDIujGyWUKEg5AQO4l3fW2sR+2Aj4Qu1E8HMN8K
 6xJm+w81RCI37TNQ==
X-IronPort-AV: E=Sophos;i="5.85,383,1624334400"; 
   d="scan'208";a="57404957"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ayZblKb7YRgsl3YwDd5uWX9AwayQSGWzewf51pqNCX3zP2+19lejeu1Z065B917JLl7LY6C05/Vl4Lg3telpDBbXJvzKRvnZybje14PMUPnJckPLRLCg1qKO09knX1Vr2KnRLrMQUQeYGzz0JlR5q/gB/iEDUe5FMOnT9jcNQZSnCA2teLr8yKUwTHy5FuilfK8Ah0XWciKieWqVKKt5HO4QD/ERj+OEVGqFrvRfwjmkwMLEmDYjZf7Vz1fwM6PFvA5GXJXwOL7//HabkIOORTlpVvQJiy8B9JMWI0InLFJw1HUxXeMVLUJ6udJLJW5CNbGLxq7WVEZ526oSMpfGeg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Sz4VozwYbHuZn93oK1so7+q4bf1ox0W13ZwCcLXmpao=;
 b=Hzj8Km7bL1IeS7JhFs4dZO9G/2sfMfkL6KBTnHGBaAD5+df2CmdYsPqblWVscDzVtblz1MXF9AWGQ0RALtjQRkQ83Ch10u8s3sYLei2P98bGN1pRudjXOVwKHp9+N4zlcSnt0Omkc0/PQOmbnB7cpmwxMZOR6g08g8eD2zS5pV6OhCzrm56HeNVW7/hQCQgFSPChx0IS/4kIOUowfUM2gvaa49Mfbu4xU44YKB3rDaAtdmJI/nxNzXPBNg4K8KRVqtrMqnl4HJ2HjarJ46l+AHNlMiPADHJC3E9mFTCo1+h54scdWJSaNWThcG0nlVAGOKWjlXXlWZmsse34BxORsw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Sz4VozwYbHuZn93oK1so7+q4bf1ox0W13ZwCcLXmpao=;
 b=buFGe/wGh5G1ye9DFh77AncOXaWyHEefMDbyUpGuPfFlwWhF/hWHii0IRsK8MuLS/vcF9e2RzP0I39Y6Q/ab4VAKsGWpkVDYRSufnQ6WN8rcvQpqhJAAWvSu5c6ywfgw4wEDTJdT9+6gLjO305rVP/XoStTLMt43RgoAdO1Rmmk=
Date: Tue, 19 Oct 2021 09:45:30 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Tamas K Lengyel <tamas@tklengyel.com>
CC: Jan Beulich <jbeulich@suse.com>, Andrew Cooper
	<andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, "Ian
 Jackson" <iwj@xenproject.org>, Petre Pircalabu <ppircalabu@bitdefender.com>,
	Alexandru Isaila <aisaila@bitdefender.com>
Subject: Re: Ping: [PATCH] x86/altp2m: don't consider "active" when enabling
 failed
Message-ID: <YW53mkPnrTCCViXz@MacBook-Air-de-Roger.local>
References: <f0de7945-84df-8668-f94a-c15cd5196be3@suse.com>
 <7f947b0b-4b65-51cb-c098-edf056610fb0@suse.com>
 <CABfawhmYzu43sMSG_TD0kHhvEjQfo1S-d-iz6cqFwb4JNbjbDA@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CABfawhmYzu43sMSG_TD0kHhvEjQfo1S-d-iz6cqFwb4JNbjbDA@mail.gmail.com>
X-ClientProxiedBy: LO2P265CA0343.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:d::19) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 9a123787-e4b0-4eef-281f-08d992d4701f
X-MS-TrafficTypeDiagnostic: DM4PR03MB5965:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <DM4PR03MB596513F8622687C4D04E0FA58FBD9@DM4PR03MB5965.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:3631;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: swpZdV737Dhm0Rd1HMEzs9mXeLWucmO1N1qa3KTFTI9kvtL3xlCScIbPDPPjm2/idxr86L3FD6w6mz0R1qukCKrqKoKRRKtmUM1ca9hOQCL0p45KP+UjTa5R16MSCT5s6yOtv/WetPtuoHiNrtOgt/xaPrydvs0LZX0OVTd8X3NzUu1KX+HDZMdmQT/AriwS4rRQqZ5PAhRsBLs8YwKMJkPgeEIWXexBobCpKJeZ7FIHhylWEYjFWzKuQ08cM2cgFvL8Qdbt9m6ja4EcOgFjnhvvEhLO190E7uJRwUK+E9NmFr7VMZz7JwF9W8jTN6kIaNutdL6lnbe4XxdWZQ0mW962TMKIslbWl8EA+AiRf15DaK9Ok8FExL7Kxcn73WJKSq9f1KZHJZI88CwQFCK6Jwlya4Eg8MYZFv9M+B4CG1gc/QbVcDbcaxqYPW1P2ghy/ao8KI3ljMoGhUZyFt0u2FOoRz6vRMcMOgzfV3rKLF6WNskfKddamWOD8vDicxqSphqznoBqh/NymOoSOP27N4km4UpJgy+F8ehH8ejWriRPZ3N7/K+jSqzbxiAZC4KrdUJR7LfbOe9jixq8CbdJaBcb6KnwqJECjx8BgxY3pap3HeZgAT2nJmclJdBLGqykqw5ym5A1OXy0Bq9xRE7AEA==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(186003)(6916009)(82960400001)(86362001)(8936002)(508600001)(83380400001)(26005)(6666004)(9686003)(5660300002)(8676002)(2906002)(956004)(316002)(54906003)(4744005)(66946007)(4326008)(6496006)(53546011)(66556008)(38100700002)(85182001)(66476007)(6486002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZkdVa1NRb2E3czJPbmhsUERJbkNzallDSmY1bnVZOUprckl0VWlTbVNsYytk?=
 =?utf-8?B?U1M4M2pzZ2o5a0FmOFRjSk1tVXI0Uk5JZjBjZjQ5QWJlMWJRenVYdzdndGVE?=
 =?utf-8?B?SW1MZ0lybUJXZVpRbUEvNjBtZUxMOExXODQ0RnozbUs4VGZLQnExc1NLUEZs?=
 =?utf-8?B?MWs4Rm9KUXNIb2tudkZHZVFKZjBPTk5yUFdUeTdYY1BBV2pVa3ZseUxVTmtT?=
 =?utf-8?B?eWRWOHpRMEhkZUFVV3NIL2hDckNnT3J6a2xEUnA2ODFYQ2RRajBia0MvalY0?=
 =?utf-8?B?N2R6N0V6N0UyQ00rRXcxTHRHOEVVQndZam0xWHY2V21EaU9jRG9xd0pMZElX?=
 =?utf-8?B?blEyV0M4eWdmc2MwaStwdUpZQW1kejFpbzJpVEFFZm1DeGcrNVUwSkRwaVZj?=
 =?utf-8?B?VlNmZUJBcEs3bnRHZmdxRUZvSXBjVzBxckpZQmtIV0xXNEhVUDhGbmRQMG9X?=
 =?utf-8?B?UjdteEhTOVRudFVUVDFNRTZ0cjJFN3dvazhjVmlLWmlaQ2lld1hUb0JGb3V6?=
 =?utf-8?B?ZXVJUUdPSjlydmgrQmsrKzBNRmEzQ1l2SjhVZVBoRUpBcSs3ako3VVJEL1ZM?=
 =?utf-8?B?S2QyZ0dKUEdJdnMrMXArTHVLdWF2NjF0aitNM05SQmZIcmtQVlV5THF5Z2No?=
 =?utf-8?B?RXVMMDF1eTBhYWFENDZQclBqa1VqUUR4MFdkODZ3cEhtUDVBaGl2SGJZN3dp?=
 =?utf-8?B?SENqaXM3a252ZmgyY3FXdlhmaFlGeDFiYnhGL2Q2YW56VGE3ZnBWTW5MSFc0?=
 =?utf-8?B?a2VWdzJsZXZEbTlCOTZxbTA5RVRPa0psVVRjUzdKQTBsQnJvMUdlS3NYKzFK?=
 =?utf-8?B?UzNjVE5MRXRFNHQvRFlBRVdqR01ueVJ6Qm1VRFI2TEp0TzA1Tm9TQVkzZ1Rx?=
 =?utf-8?B?NWU0bUlOT2hPbW9aZVluVGN3UE8wUmJXaUx6cVJLMzU5cnRLTHB4MkJzeGUy?=
 =?utf-8?B?QmxCYWEvQjdqeUVzejlKalZyV0Q2WVFZWU9ZNnVTNmJoYmtETEpTcDl1MGQz?=
 =?utf-8?B?YVhjN3hKY3lFcktWWnh3UmIxY3RJVnRvMlBTTm5UNlBuZ0k0SmlLVVBpL05P?=
 =?utf-8?B?NU1DRS9sT2JaakF0NUtKbHNnS2tuQW9PcGc4MDVFRk1HOUJDelBxU0xHbDY2?=
 =?utf-8?B?cm5rSHp1SSs3MjJQWVZUU2NubU9aWGlML2NFZlliRnFJcWs4QzVFZjZ3MGRT?=
 =?utf-8?B?YjBUUWVaSXk5Q3FDOXpqaGFSc3Rhcms0S21neTFqaWo4ZHZaNk1nMHlEbkFR?=
 =?utf-8?B?d3E3a3BWV2pDNDZxN3pDTUl6aHpsaTFLYlVkK0VneE82RW5POWFGcUJ6WDdt?=
 =?utf-8?B?MVk1bnBLNDUxTldZdjZVZ1QzakVyRkt6eFdyTlpUUDJrU1dDT052SkVya1I0?=
 =?utf-8?B?bVZOZWVtaUcvMkJQVzdkOGROQm9kYk9xK0NzZlpPSzFFTUpNQmFCckhCeCtZ?=
 =?utf-8?B?dUdhRE5kN3VlbE5DenZ3Q1N3dFp6M2UrUXN0bWpmSmFoemwyYmwwR0dWbXJp?=
 =?utf-8?B?Z3dObWZYd1p0TzNrd28rbE4wVVg2VTVWNENCUEpITys5Y2h1VUJvc240a0E4?=
 =?utf-8?B?THhJLzFzV0hkUDBETHZiQW9ubjBPdzZOVXNLdkxtNDFPcG9QWEU5NFFYOWRI?=
 =?utf-8?B?MWE0VkRMOVdyVFdMTk1TU1RrMWJab2dodlB5SkhCSWR2aE1xOXZ6TXRJT0hM?=
 =?utf-8?B?aGl0WDhnWlFNcmhBc0FOMDd0V2hDQ0NvbkJBN2hid24zeHphR2dLTUxoSVBS?=
 =?utf-8?Q?3ShdoMxWC6UWkjlun0/FbMNMWPCC5/0EefNrm5a?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 9a123787-e4b0-4eef-281f-08d992d4701f
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2021 07:45:36.3668
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: YMjEa/cYEpzvrDfFXUPFYpgTzAmoU7+sI/hyLeL37z/nmtoODZWv7eJ9F5WAOum2fY6c33312u1nVOqkrxLHQQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR03MB5965
X-OriginatorOrg: citrix.com

On Mon, Oct 18, 2021 at 09:16:30AM -0400, Tamas K Lengyel wrote:
> On Mon, Oct 18, 2021 at 4:26 AM Jan Beulich <jbeulich@suse.com> wrote:
> 
> > On 25.08.2021 11:31, Jan Beulich wrote:
> > > We should not rely on guests to not use altp2m after reporting failure
> > > of HVMOP_altp2m_set_domain_state to them. Set "active" back to false in
> > > this case.
> > >
> > > Signed-off-by: Jan Beulich <jbeulich@suse.com>
> >
> > Because of their relationship, I'm also Cc-ing the vm-event maintainers /
> > reviewers: Maybe one of you would care to review this one?
> >
> > Jan
> >
> > > --- a/xen/arch/x86/hvm/hvm.c
> > > +++ b/xen/arch/x86/hvm/hvm.c
> > > @@ -4609,6 +4609,8 @@ static int do_altp2m_op(
> > >              if ( ostate )
> > >                  p2m_flush_altp2m(d);
> > >          }
> > > +        else if ( rc )
> > > +            d->arch.altp2m_active = false;
> > >
> > >          domain_unpause_except_self(d);
> > >          break;
> 
> 
> Reviewed-by: Tamas K Lengyel <tamas@tklengyel.com>

Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Tue Oct 19 07:56:23 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Oct 2021 07:56:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.212834.370862 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcjyk-0004A9-Mq; Tue, 19 Oct 2021 07:56:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 212834.370862; Tue, 19 Oct 2021 07:56:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcjyk-0004A2-Jp; Tue, 19 Oct 2021 07:56:10 +0000
Received: by outflank-mailman (input) for mailman id 212834;
 Tue, 19 Oct 2021 07:56:09 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=gzZp=PH=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mcjyj-00049w-1O
 for xen-devel@lists.xenproject.org; Tue, 19 Oct 2021 07:56:09 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 54f774bd-0fbd-4e46-8be1-71a8c4b81afe;
 Tue, 19 Oct 2021 07:56:05 +0000 (UTC)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2058.outbound.protection.outlook.com [104.47.14.58]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-18-X3EdQ8QhPy2SzI0MkVf5QQ-1; Tue, 19 Oct 2021 09:56:03 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB7149.eurprd04.prod.outlook.com (2603:10a6:800:12e::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.17; Tue, 19 Oct
 2021 07:56:01 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.018; Tue, 19 Oct 2021
 07:56:01 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 CWLP265CA0413.GBRP265.PROD.OUTLOOK.COM (2603:10a6:400:1b6::19) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.18 via Frontend Transport; Tue, 19 Oct 2021 07:56:01 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 54f774bd-0fbd-4e46-8be1-71a8c4b81afe
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634630164;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=0oQ4ASkT19buSsEkCIuyMxR9FGf/D3eiJozGaAgNrf0=;
	b=DPf+yBXWLE8mKNUGqPuSgXC8WKJkFmXLsT6iiAWsJPan2q6JJNdm+FT5hhN8FkjBtkd40v
	jhQpNoNMRGiiLVlJjlVKD6kUa+dgo9iHI7K6cmxLS7WYgeD74D9ELE4UkGTqxQ37YPvEK1
	ECBmyK4r3GJ+mQLCSoMyKfXi6IuBkFo=
X-MC-Unique: X3EdQ8QhPy2SzI0MkVf5QQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=M4Ob9U4H0rniGHlPsKOP3FHf4+h3HjyimIDCIDtQ2ak9WPPmVrlCnSty0yNfTQW50giO9eIjrjjxJtdlpy0zdKuEAGVKubDYSH6zArGyNi3DP1Jh3Rp9yP41HVU8MSyLxDVcs4T+0EUTSjLD5zagltGySTyt2TqLHkH1ZFH2I9WoWzMjQdv7lBmPwUXabcolcuMHp15ZOmaEKSkztfHKNosWBqq1x+1/nIfHrohWQuYlu0Hd/ThNp0yqfqvq92ZKJ7ZwgoaKFmeEAfneASPgINQw326PuWP8OMaUOIqfbmBQdXARcmiX5Xn7h+Qmnl04mX6hENkYZpFrxy4XJrwBTA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=0oQ4ASkT19buSsEkCIuyMxR9FGf/D3eiJozGaAgNrf0=;
 b=PfNbqBCXR17Di38f27JQ3DZ+Lk42IcLko5iuYR52bPe3n/PwHhwEXs0MFBw7YbmAAXzjP5E0MwOF2rw6x6lymHyTlo5ZGAyjxRc/+rSt5HG0H3R877Qa/uWKSur2PfPr+Os9zz8XLFoCFI6FFxJCXSq2F+luJGZB4Jqi8VrgoIddcZ79hPFbapwSQIhBEFpJx8UxiX8jcp/gC+0i+Ns8cV4CtImueS4zti/SzQPOoPeiGpO9jb/ad7lA9BkftAjG9Gr53Xd1KykMPwGNNF+JIaI/Ggwo4ASjLD4oIrvs0Wc490a46RhT5lSwtTKyzBSJGOTKAkTRtP1doqIqneSFig==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [PATCH] tools: fix oom setting of xenstored
To: Juergen Gross <jgross@suse.com>
Cc: Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
References: <20211019044123.29648-1-jgross@suse.com>
 <0c93abe3-3908-009f-efca-08000092cd4d@suse.com>
 <c486ebb9-7cda-da67-7122-bceb291805b3@suse.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <912b03a3-90df-e94e-77a9-5c673acfef04@suse.com>
Date: Tue, 19 Oct 2021 09:55:58 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <c486ebb9-7cda-da67-7122-bceb291805b3@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: CWLP265CA0413.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:400:1b6::19) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 024ebaf8-608f-4422-b166-08d992d5e4ca
X-MS-TrafficTypeDiagnostic: VI1PR04MB7149:
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB71499DCDE05E4357123F05B6B3BD9@VI1PR04MB7149.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	mwnJheP0HXvbKEBD2Yt2RJhsUqxp7owv4tW3DCQ4Jdkc5fY/WSXbom2614C4HNwz0Ok4zNRxARQjppZVBHrRRid9pmhGmMIEdA7oSxn0SYtOWHgjTCxMPTHjnbA18kaSjucrpE9/jNhoE9vmvmyj0hz3bzKty+Iqv22qJKurDBzW+V6wf6BzLgTtYwaiqJquOybC1A40jJZHQS178gWTzxwFqMuHwio2BL0Z3DwDl26QPBCvxsrD/NFGFj039VMTIokw/cXOytmrbTjBET9ZLyZWe+kjW22H0UnriSEWAq9qpwottSXh2jz2A0nTyuLynQwV6AcYErKLi6mJ66fw9Xf2lY3N9Ft/LvkDTmFKCPu0Dlt8P/Mn8rKdjxu9G+bWN2MpOp2nDcgFYthaHm7UcoMmdIkscLtyxVPobyQYgGW3FvHAoD2r6EI1s6y7lMMGpkLr8pM/5MBAhsDLu7qlOgVVkHh4K5gASdZkx3sSRz4Vuc61kfCBvoTX6MTbVWBimjvQKGkaRqmaou+6uz8l7pXJrN9aSimX4tdQTTtWQ5J+vG4oTtcDGBztpzNsZ6QDy73pQRf/ekQ1O05sS11RPaYJS1wPQXxiyA7w4GGCPXasEGu3hABtAv/C3uKbGs7qe6W6D1Bmr1M8tibVQeE3gzxhKuqyaQMlIXu15wrbIwRwJi95rS2O7WIZIMVBRtjKw3PfQ3g/WWNbqdIMgGzU9s7VFxcWKG4+5xTncuga1ZipO/w+80zWWJiID8OXk9ktIenlK/gVKWXO+vG5akYMCA==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(508600001)(53546011)(6666004)(6636002)(38100700002)(6862004)(956004)(2616005)(8676002)(4326008)(16576012)(54906003)(83380400001)(316002)(26005)(31686004)(6486002)(186003)(31696002)(66476007)(66556008)(86362001)(5660300002)(66946007)(8936002)(37006003)(2906002)(36756003)(21314003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?eURRNEZGMk1WOFNpZ1dtUE9ZVTJ4ZW9LUHducmxheHg5Vk5BQVQ0UEdoeDdy?=
 =?utf-8?B?KzY5R3dnUTk0V1NxbDgvY1Vjd0plYjRFVEVFL2ptcjk2VnRKNWVLeGdrUGRO?=
 =?utf-8?B?dXVFU3lUYWdSNzAxcVZOazFHYlNWRlhpbmJDeDlaYzRYTkZvWDFhYTR6YlFF?=
 =?utf-8?B?ZElFOVFoY0tnaGhwVmZNUVpJVDJoNGc4SDBhZ2Vmc1d3cmtUc1FTUXZBWVBK?=
 =?utf-8?B?ZHhkK1NpYVlES0VGUldyZkdTMUlyVUFMY2pqQjgzN29HdHB6RnhlNGpEOCtJ?=
 =?utf-8?B?aFgvbUE1RHQ1ZytTamxhZHNBUDBzK1JtS1VOTTZYaXNmU0dydEZsVE1zaXV0?=
 =?utf-8?B?ZGdLQWhDUGgxL1gxRWgwSWJjaUVLYXZVV2gzRmVrSUJScnFjY3RhK2VYL2V2?=
 =?utf-8?B?OTA1aVNBRVhENmJHUW5aQVM2S1l2QVZhb1l4R1h5enpkWUdjd2RjRzlmYVpU?=
 =?utf-8?B?bDcvaDYwZ0lHelhCbUdvbDRkMkZtdjJqOENsSVg0VXlDbTdodWdHODRndGFu?=
 =?utf-8?B?NGREUmVlMDJtb3krSEQ5cU11bHJQU2NmT1FvZ3hsaXd2WnUvMzg2Y2VZTVVx?=
 =?utf-8?B?YmYvclVYd21PY0ZqaWY3K3UzRVVyWEROOXl2WXkrNXhVSmZhV0Via0Uwa0hq?=
 =?utf-8?B?WHZWaFJTblhFeFhaellGcXZlVWlzM2hVNndJL0ZXYXFRd3J1WkhDbmlhc0dV?=
 =?utf-8?B?TjVxR1hBMGxtRkZQaWVXdXEzVXFjRlNZbjZ5MTZKN3hjdDlKMmYrNXBLY1dz?=
 =?utf-8?B?ZDBsRk52MkZIUnpWdm9KRnFPV0pQay9aTjdtdWY0UU5pWWE1VUVyY2M0N29T?=
 =?utf-8?B?ZEp4Z0FPZVJYalhqSEFMcU42Qng1RTFyb0tnNmFMbVh2ZzRNUkorOUVjcFM5?=
 =?utf-8?B?enpiNldENGlNMGRveml0UWxGNkUwbjkrT1BCN2hwRkg2VDBiYWFXQjRoUGgz?=
 =?utf-8?B?UmtXaU5yNFoyd09jVVlOR0w1ZytiNGdNelNYQ1VXMjZKaU5JOXBVelhuWmE4?=
 =?utf-8?B?eHhSTTIweGNlQzY4d2JVOXQrQWRQc09ldUxlY042cGNYaUVoMm1MNU1Paml2?=
 =?utf-8?B?bTJmOUgyYTBNOGkvVExXT1daY3Z1T2gwdzdHNkE5OERsdWVSOVBXTTl4WDRF?=
 =?utf-8?B?Ty96a2cwZ2V1NlJ4QWJ1QS9uUmVGK2YxdkpvUFZKR1oxUGVXay9aMGRVdEow?=
 =?utf-8?B?UUp1RnNIcXJqVTFTNEZxZU01ekZOZlhnZ0lHeldINnptT1FKaXM1V3FMNThE?=
 =?utf-8?B?dGZ0a2h4Yk1ZTUFseUxEYmttdWtzazNYdWgzMUk1TlNoNCszVkw5SG9nSDF5?=
 =?utf-8?B?LzAxWGtHQWVLa0x0Njh5cHZTZWJrS2tYbHNRdVVuRlhSZHpvekpIeUdsYlV6?=
 =?utf-8?B?Z1FYTm5NR2F4bnZ5ZUNjdU54R3hGa1BMTm90Q3FtVGVOYkZWV3h1ZCtQU0Fz?=
 =?utf-8?B?S0V5VTB6R3VleXg4cnFJM3VpL1FKRWEySkd4cDBoWnJyMzBFNEswUWVja0ZY?=
 =?utf-8?B?SCtnUFBzYSs3UGc0MGtBL3JYSWJtMGloZE1RUzNweWluQWtMQ2ZDWEpobWtC?=
 =?utf-8?B?NW5sZmdZTytIN1hzT0ZrMDAxOTdCVDAyVWtqeE44ZUVjU1IzN3BiRUhCUmU0?=
 =?utf-8?B?Q1Q4Q2xESmZJNGpBV01xdWxzVVd4YkFEQ0FvcmNCKzJpbDVsR3M1T0s1V0Fo?=
 =?utf-8?B?cHQ4Wm83Um1IN2IxSzJHbkh2RE91Q1lmSHJoYzR6S0llL0dmVHBIWHNvWGF1?=
 =?utf-8?Q?2lSfRh3AF68kqmHoRwTciOlf2AlDCearDwR7JUD?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 024ebaf8-608f-4422-b166-08d992d5e4ca
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2021 07:56:01.5073
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: sx+sNMfjWCbYeelc6MdJvM8EwJRXkThYJXaWi6TVo/OnnuxWLXBAtrpZlE0Rng8C88LRvCAPrbYhP9yUEcLywA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7149

On 19.10.2021 09:31, Juergen Gross wrote:
> On 19.10.21 08:54, Jan Beulich wrote:
>> On 19.10.2021 06:41, Juergen Gross wrote:
>>> --- a/tools/hotplug/Linux/launch-xenstore.in
>>> +++ b/tools/hotplug/Linux/launch-xenstore.in
>>> @@ -60,7 +60,7 @@ test -f @CONFIG_DIR@/@CONFIG_LEAF_DIR@/xencommons && . @CONFIG_DIR@/@CONFIG_LEAF
>>>   		echo "No xenstored found"
>>>   		exit 1
>>>   	}
>>> -	[ -z "$XENSTORED_OOM_MEM_THRESHOLD" ] || XENSTORED_OOM_MEM_THRESHOLD=50
>>> +	[ -z "$XENSTORED_OOM_MEM_THRESHOLD" ] && XENSTORED_OOM_MEM_THRESHOLD=50
>>
>> Is resilience against "set -e" being in effect of interest? If so I
>> think this would want to be
> 
> I don't think set -e would have a negative effect on above line. The
> bash man-page tells me that:
> 
>    The shell does not exit if the command that fails is part of the
>    command list immediately following a while or until keyword, part of
>    the test following the if, ...
> 
> And I believe that "[ ... ]" is treated like an "if".

I don't think so - "[ ... ]" is an equivalent of "test ...", i.e.
unrelated to whether that's an operand of "if". The question is
what effect && has, i.e. the behavior is due to what you've
hidden by using ... in your quotation: "..., and is not a part of
an AND or OR list, ...".

I think I recall constructs like the one you use not working with
"set -e" on at least some bash versions, though. Apparently this
was due to a bash bug then (or I'm misremembering, but that's not
overly likely since some of my long used scripts specifically
avoid using && in such situations).

> A short test
> showed that bash indeed does not exit in this case:
> 
>    ( set -e; [ -z "" ] && xx=okay; echo $xx; )
> 
> This will print "okay", so bash didn't exit.

Of course, because the left side of && succeeds. You'd need

   ( set -e; [ -z "xxx" ] && xx=okay; echo xx=$xx; )

and observe "xx=" getting printed. Which indeed I do observe on
the one bash version I've tried to double check. But that one's
surely newer than what I think I saw such problems on.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Oct 19 08:10:10 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Oct 2021 08:10:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.212849.370875 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mckCE-0006qV-7f; Tue, 19 Oct 2021 08:10:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 212849.370875; Tue, 19 Oct 2021 08:10:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mckCE-0006py-0p; Tue, 19 Oct 2021 08:10:06 +0000
Received: by outflank-mailman (input) for mailman id 212849;
 Tue, 19 Oct 2021 08:10:04 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=eXNP=PH=citrix.com=roger.pau@srs-us1.protection.inumbo.net>)
 id 1mckCC-0006Yr-Bc
 for xen-devel@lists.xenproject.org; Tue, 19 Oct 2021 08:10:04 +0000
Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id f5e13378-30b3-11ec-8305-12813bfff9fa;
 Tue, 19 Oct 2021 08:10:03 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f5e13378-30b3-11ec-8305-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1634631003;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=GLt4Szb22oU6HIgNJbAD50OTivns6+Vhi+hrbxF8MwQ=;
  b=Ch1TABxVskIs7BEdrxK1phy6Z6lDiqlTt9zkxPvqCKzOKnwQeB+ZaD/V
   CmH5Oxkr9L/zFctWtaUbQBWdmWZgK+B7HerltyQXQx4rPOIMzN90LnEbP
   NkKwXorqvqAgUxOq1/GLKormMBQZqozCYMGDe4IiPoyEJmKOxCkmB7j+a
   8=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: x3jiimF6kf2hFUnrYlWnrVJAXPdteawT8PzR/RTSpfFyYC2PFlliS3Uq3ZIaa6wrBUfqP3wbcU
 Rjs6Sk7WZsHliWauxf6kA/GxV4ykjO2fLKkG+LSWWgbRBcysmUKDu2tVz9w7jG9qRc4xCOmDmJ
 d17xqCWoDwSqQOGqAf4Hf38+Vcj+k9QYKwhcW3hX0MRdoA25pxN2kpt35C/XDq3U6r60qB5mPW
 T8dubCBFysa+8FC/KcwhvkQBRN8BW6EpYIML+seo9lRpFLJrZAe8q8co6SG1QvDqwkuNVuCDo+
 bIL8iIPLfZtYDVK4vIHOV/RK
X-SBRS: 5.1
X-MesageID: 55072486
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:nCUV6KzS+4NA7b0+F6t6t+fjwSrEfRIJ4+MujC+fZmUNrF6WrkUFn
 TcXXWqGMv+OZGene90iYIiy9klU75/Rm9VlTVdl+CAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx
 59DAjUVBJlsFhcwnvopW1TYhSEUOZugH9IQM8aZfHAsLeNYYH1500s6w7do2tcAbeWRWGthh
 /uj+6UzB3f9s9JEGjp8B3Wr8U4HUFza4Vv0j3RmDRx5lAa2e0o9VfrzEZqZPXrgKrS4K8bhL
 wr1IBNVyUuCl/slIovNfr8W6STmSJaKVeSFoiI+t6RPHnGuD8H9u0o2HKN0VKtZt9mGt9JAj
 5ZSr5HpcAZ3DPfRiv1FXD1+TQgraMWq+JefSZS+mcmazkmAeHrw2fR+SkoxOOX0+M4uXzsIr
 6ZBbmlQMFbT3Ipaw5riIgVort4kI8TxepsWp1lrzC3DDOZgSpfGK0nPzYIFhGhq2pAQdRrYT
 8sSdytGSznnWj1KKFEeWb5umba3pUCqJlW0r3rK/PFqsgA/1jdZwLXrddbYZNGObcFUhVqD4
 HLL+XzjBRMXP8DZziCKmlqujOLSmSLwWKoJCaa1sPVthTWuKnc7UUNMEwHh+L/g1xD4C4k3x
 1EoFjQGr5l1t1OxQ4DEXkOK+mOWp0YTf/wOOrhvgO2S8Zb87wGcD2kCazdObt06qcM7LQAXO
 k+1c8DBXmM37uXEIZ6J3vLN92nqYHlKRYMXTXZcFVNt3jX1nG0kYvsjpP5YG6mpksa9Jzj0x
 z2bxMTVr+RO1ZBVv0lXEFauvt5NmnQrZlJqjuk0djj8hu+cWGJDT9b4gbQ8xa0YRLt1tnHb4
 BA5dzG2tYji962lmi2XW/kqF7q0/fuDOzC0qQcxRMV8p27zoyT9JNA4DNRCyKFBaJZsldjBO
 xe7hO+szMULYCvCgVFfMupd9PjGPYC/TI+4B5g4n/JFY4RrdR/vwc2dTRX44owZq2B1yftXE
 c7CKa6EVC9GYYw6nGveb7pMitcDm3FhrV4/sLimlnxLJ5LFPyXLIVrEWXPTBt0EAFSs8FyEr
 YcPaZHUo/idOcWnChTqHUcoBQliBVAwBIzsqtwRceiGIwF8H3omBeOXyrQkE7GJVYwP/gsR1
 n3iCEJe1nTlgnjLdVeDZnx5Meu9Vpdjt3MreycrOA/wiXQkZI+u6oYZdoc2IuZ7pLAyk6YsQ
 qlXYdiED9ROVi/Dp2YXY67iodEwbx+snw+PYXaoOWBtY556SgXV0db4ZQ+zpjIWBy+6uJJm8
 b2t3w/WW7QZQAFmAJqEYf6j1Qrp73MchPhzTw3DJdwKIBfg941jKirQiP4rIp5TdUWfl2XCj
 wvPWEUWv+jApYMx4eLlv6Hcotf7CfZ6E2pbA3LfseS8Ox7F8zfx2oRHSuuJI2zQDTum5KW4a
 OxJ5PjgK/lbzk1Suo9xHrs3n6Iz49zj++1Twgh+RSiZal2qDvVrI2Wc3NkJvapIn+cLtQyzU
 0OJ299bJbTWZ5+1TA9PfFIoPraZyPUZujjO9vBkckz16Rh+8KeDTUgPbQKHjzZQLectPY4oq
 Qv7VBX6N+BrZsIWD+u7
IronPort-HdrOrdr: A9a23:b7WRvKw298TAAfFlVygZKrPwKL1zdoMgy1knxilNoHtuA6ulfq
 GV7ZAmPHrP4wr5N0tNpTntAsa9qBDnlaKdg7N+AV7KZmCP0gaVxepZjLfK8nnNHDD/6/4Y9Y
 oISdkaNDQoNykYsS8t2njbL+od
X-IronPort-AV: E=Sophos;i="5.85,383,1624334400"; 
   d="scan'208";a="55072486"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ImN1mTlpbholNxKP/OJ6WW0a6Sh+0vM7bJ3jC2q4ICoG2q8LoxLi5DqnXO8hMzie06F9Y4I4CHL7dL49pVIKBeomUnUit/6T35PNNXwZhA1vYoX/xx2XbzLY4QucEnDX+FsHGlvTZJYJeKG3lKReAFMvffQ/LHgDBHs1RMNyvT3nnMwjpwheoMv7aNyDNCkauTLDWinFEnyycpYzO1h5lKH1u+b1qm9UUSEra/xdPu6eB0uXxIPlmrpsenHRKyfZaXgJK/Cio4A12p69lhFb9uhlS6LtyojN6MzL1YOSLgyO56WyMdf3MLzVerMF9CcSTfacW2k1+WYfOC6UlH13vw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ew51ff4cjuK6i/x94JRSduNg2YkJI3cjcbfYpMfKBwA=;
 b=LmJoVGBrTIGxvIlVeBKkLN2s39XO4PJFIjxoG2vsyhwqBP3xCdJNnc+/xW22clylm8AS41EfVlZXrLbX7EUjBX+I8ON6hXpiTGGeNTqdMlEi0E0X5CNmsYny8UtHaQRuzZEg78lARDeknByhE3fgWzbwp/p8R8jxuJ115xItsHBdk5eDtM4Bir6i2nm7ILn/Y3Lg5UDWH55LKdM3zl0YIRuBlflppKpEzHW0nFiISX+LBaAq/hR47tj5Q/8YHQ9l2D9gtu1WY6Ql0WInc6OWa0fioPdM5EWZPw8miDr6b1uutfAImofpCv3ihSlHkqSfpQGf/Q5llN1F0DvAT+RnyA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ew51ff4cjuK6i/x94JRSduNg2YkJI3cjcbfYpMfKBwA=;
 b=bcSIRc0yTE4BFBMHrySMJaWW6JBBWv28IO7PjzQnx04TJGjTvrz5BlAs+arG5rSk8BGa25/4BUSx4Rb3By1mTFssmNWa2eR77MY4uJDX5iwbTf6fYWUSa5gU7t8M5i7IyvX4ogFLGRY0t+ToTdu0tKSWFcuw19aUwvyOtXfpK2w=
Date: Tue, 19 Oct 2021 10:09:29 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, "Andrew
 Cooper" <andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>
Subject: Re: [PATCH] x86/PoD: defer nested P2M flushes
Message-ID: <YW59OUi9tpnGccl7@MacBook-Air-de-Roger.local>
References: <e47d51c6-1b4b-2f72-6e12-070df66c30e2@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <e47d51c6-1b4b-2f72-6e12-070df66c30e2@suse.com>
X-ClientProxiedBy: LNXP265CA0044.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:5c::32) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 54b50e20-4b6b-4b5d-9f00-08d992d7c8f8
X-MS-TrafficTypeDiagnostic: DM6PR03MB3914:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <DM6PR03MB3914FF6D70B4FAACABEC68778FBD9@DM6PR03MB3914.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8273;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: WChPp0basAOu2LQ/OsHjDZoEEPW8YgJSQBgLCwOI6s6TUtXtUatGjJsLPpwcG0GMEb56vhusHvKcE9dg5Ci2qskEN2uQcawFEaAluCjHg4HluHtgmMZ1hxcqH6PM+9AAqef+Aa2BlYioeP0m3eB/Bt4Johw9anaM1kd6EOoEdv9vTNdkd1iBRzCUDRBY6AKNm2mahbdJMjSsY7PuZ+DAQvZfc7io8LWCsYzOHrX9KVRJ7OkM9Pc8tCM/BteEYlpi0HkvJWdseNctwEnNB0mGcF9S3AxC1OL678i+UxwJskRhbKGFr4Wsaq7EqzThkUD+unBXpLLXghWhtx4sBUeHLGUyuejYiASP0OcaOo+phqz1bflB0gGl20cbystxPUnHYkQv1qX69gu5AmSUyen83bZFS9YcfTrKgW7MfQeZAvbtGoDspV5sHGwlO4XljZrML8wB7Z1ZU7l391R4v6Z0NFKoUdOUOYiHSKHUh/a7YDAQQ9yhQuTTDpk4aWaonuXZkcP6gv08U6TSxM2XEWBcMxKXN/22HOFcxTljDeKZAYQexzA7zQRJuQp0AiIu0ZZ0/Hx1h5O22cr4JefdMBSzKtUWYxkq6So/hJkwSha9z5BCfSE2no6gFhfyC2YmyuiRZR7HN16suy+FUMQQFYFFWQ==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(9686003)(8936002)(107886003)(85182001)(316002)(6666004)(6916009)(83380400001)(2906002)(6486002)(956004)(86362001)(66946007)(66476007)(66556008)(6496006)(54906003)(38100700002)(8676002)(5660300002)(508600001)(186003)(82960400001)(4326008)(26005);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?a252LzVhajh2T3V3ZG1sbTF3akdrNVc4MlRuRFI5ZEZ6dGt6Ykxlb09zZ0xY?=
 =?utf-8?B?QzF3bWVTVWdXVWVuRFM4UTBTaHFZd2RXOTZxakRnNWNVSWRRVWpmMzJNOHFa?=
 =?utf-8?B?ZzJ2cVJGYzc4TUR3OTU4Zk82TGFUbTVURkIxZ1NUUXVkRGhxT3VzekZaanVN?=
 =?utf-8?B?alRjNVAxYURhcDlHTXg3WDdpb0x6ckRnd3pia0JucTR5ek9FMFZkV3NKTElV?=
 =?utf-8?B?TVdCRTFjMDl1ZWFsNWs5dUhnTFNrYzBJN0xPcllZaFhkUjZTNnZzaEdsSmtY?=
 =?utf-8?B?TWttbGZ5eE96R3VTajFFQkRJTFlTZU9CS0tsbjc0dHJNemhDanh5YzdKVlpk?=
 =?utf-8?B?TXFCSFUybmRxR3JpcFMyTVRWNldZTVppbFY2a1pFNXU3dmxzdVZ2NEhiem5R?=
 =?utf-8?B?RUs4QjRRbFRYc0Z5M3ZxK0g3RFBLM3Z3WFZpcmdLREtLUDJNZlhmNzZPSnBw?=
 =?utf-8?B?YVpQcy9SUURqcFMvWEM2ZlBrUUtrL2tBVnVUVy84QkNTditDS01ZMEpETzZo?=
 =?utf-8?B?c0tZdE5xSGVONGk2bTZ0c0VzU3BlbkJxR2Rscjl5NjhDNW9RU09rZms3WnYx?=
 =?utf-8?B?TEdpTVJ2aVgrRkxYampUNG1ZeXF6WjRqR3QvcDd0RlQ5M3F3Y0VtQWZYbFRN?=
 =?utf-8?B?WDRIVThjYklmOEdYZ01meVlPTXYxamNZSXFsbWRacDFaei9zSG5ySnpyMUlH?=
 =?utf-8?B?MStBaSt3dkNuZ2RRZXhkbGVHS0tvRXFGdEFjZUFIQi9OVFl0djM5MVY1V2h0?=
 =?utf-8?B?SmpJS3RQRmJRYjZJbElUUEx2Qml1YTVKeXVrT3NIRWVxR1BoeitLbE9qcjJw?=
 =?utf-8?B?TUNZWmZ6dTc3Sm8wOXoyVWl2U2hCODNON3BpdTYxcFdOeEFKZU9jZVVkQ0ZJ?=
 =?utf-8?B?Sy82QnFUajhWNWdJeW1ucGhGYmdmM1pEc3Q5TUFJd25VWENhVzNQSmdyc0Iz?=
 =?utf-8?B?M0J6L0dwZ2IvZjFIdEZTTEs5OHN4K0thSWJOcjdRR1VUdytzQW9FdE4yWW90?=
 =?utf-8?B?VG96TWJXSmNCdXorUlFBMlRTdWpmYVhvb1JIMkY1NHpZQ2l6Q0grY2ZtWlRz?=
 =?utf-8?B?WHNwZExTQXhzeGVHdEoyeG1sVjNUa01HcWpJemluR3ZIV1orK2hpaHlGMUJ3?=
 =?utf-8?B?NDlmVVMxYzRlVzh1VlBEMXEvKzFyWFVrUmV1L0o2YldzeHNBVGlXYTlIdlhF?=
 =?utf-8?B?ZjJvVlpFeFFEbmx4aVRtYjZaVVVBSWRSNjJTSVJzQ0lzdnNta1FpVkYzMko2?=
 =?utf-8?B?cWUwRHdOZjVvdzFqK3RXZk82aDd6azBuV3dkb1d5Z2RQVnVjNmZBaHRSZHY4?=
 =?utf-8?B?QTlJbFVYUVVxaUttYndYLzZHa0tBUXRaL0NodHF6dEp0L0dtRTZvS21HeGxz?=
 =?utf-8?B?a2RuZUJXbDNPZmMwcHVQNndkbXRraFBldmVoMndEVzE0M09TeGY4bEtWMGdS?=
 =?utf-8?B?Q0lyb3ZHZWJtVUpSN3lRUXU1WUtYY1V6WjFFanNZRVQwNHkxa2NQYjdndlZs?=
 =?utf-8?B?ZnU5cDQrVmFtYjZucXFQN0wveVBVT2xGV1RqRjhudGpocy8xT21HZ2ppd01O?=
 =?utf-8?B?OFdEOTh1UU1ZSnhwRkJXVm5lUTV2SW1XTHBFcjJ4NllEZm96dU8wdjhlREV3?=
 =?utf-8?B?czEvcGlvbnlaM0lBWGJsTDBEZVpKdkUzQlNUNldMM0NDN0NLdXpBSTN4ckdO?=
 =?utf-8?B?NTVHUXBnRzlqR24zM0VjQy9kUmhhOVlVbUhHb1BVT1JlaElYREd1SXM0OGFQ?=
 =?utf-8?Q?+EFtfAYWPFI/isk/knM8r15EZ01/23pwObsQQ6f?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 54b50e20-4b6b-4b5d-9f00-08d992d7c8f8
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2021 08:09:33.8370
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: atZWFm6wUNewYRn07oAgrw841/0fiAX6r0YimQhIW5IJnP611YX8t4EHMR9FeXzeNBNT1ku3LtlRa6afUjhGcA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB3914
X-OriginatorOrg: citrix.com

On Mon, Oct 11, 2021 at 10:17:08AM +0200, Jan Beulich wrote:
> With NPT or shadow in use, the p2m_set_entry() -> p2m_pt_set_entry() ->
> write_p2m_entry() -> p2m_flush_nestedp2m() call sequence triggers a lock
> order violation when the PoD lock is held around it. Hence such flushing
> needs to be deferred. Steal the approach from p2m_change_type_range().
> 
> Similarly for EPT I think ept_set_entry() -> ept_sync_domain() ->
> ept_sync_domain_prepare() -> p2m_flush_nestedp2m() is affected.
> 
> Reported-by: Elliott Mitchell <ehem+xen@m5p.com>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> 
> --- a/xen/arch/x86/mm/p2m-pod.c
> +++ b/xen/arch/x86/mm/p2m-pod.c
> @@ -24,6 +24,7 @@
>  #include <xen/mm.h>
>  #include <xen/sched.h>
>  #include <xen/trace.h>
> +#include <asm/hvm/nestedhvm.h>
>  #include <asm/page.h>
>  #include <asm/paging.h>
>  #include <asm/p2m.h>
> @@ -494,6 +495,13 @@ p2m_pod_offline_or_broken_replace(struct
>  static int
>  p2m_pod_zero_check_superpage(struct p2m_domain *p2m, gfn_t gfn);
>  
> +static void pod_unlock_and_flush(struct p2m_domain *p2m)
> +{
> +    pod_unlock(p2m);
> +    p2m->defer_nested_flush = false;
> +    if ( nestedhvm_enabled(p2m->domain) )
> +        p2m_flush_nestedp2m(p2m->domain);
> +}
>  
>  /*
>   * This function is needed for two reasons:
> @@ -514,6 +522,7 @@ p2m_pod_decrease_reservation(struct doma
>  
>      gfn_lock(p2m, gfn, order);
>      pod_lock(p2m);
> +    p2m->defer_nested_flush = true;
>  
>      /*
>       * If we don't have any outstanding PoD entries, let things take their
> @@ -665,7 +674,7 @@ out_entry_check:
>      }
>  
>  out_unlock:
> -    pod_unlock(p2m);
> +    pod_unlock_and_flush(p2m);
>      gfn_unlock(p2m, gfn, order);
>      return ret;
>  }
> @@ -1144,8 +1153,10 @@ p2m_pod_demand_populate(struct p2m_domai
>       * won't start until we're done.
>       */
>      if ( unlikely(d->is_dying) )
> -        goto out_fail;
> -
> +    {
> +        pod_unlock(p2m);
> +        return false;
> +    }
>  
>      /*
>       * Because PoD does not have cache list for 1GB pages, it has to remap
> @@ -1167,6 +1178,8 @@ p2m_pod_demand_populate(struct p2m_domai
>                                p2m_populate_on_demand, p2m->default_access);
>      }
>  
> +    p2m->defer_nested_flush = true;
> +
>      /* Only reclaim if we're in actual need of more cache. */
>      if ( p2m->pod.entry_count > p2m->pod.count )
>          pod_eager_reclaim(p2m);
> @@ -1229,8 +1242,9 @@ p2m_pod_demand_populate(struct p2m_domai
>          __trace_var(TRC_MEM_POD_POPULATE, 0, sizeof(t), &t);
>      }
>  
> -    pod_unlock(p2m);
> +    pod_unlock_and_flush(p2m);
>      return true;
> +
>  out_of_memory:
>      pod_unlock(p2m);

Don't you need to set defer_nested_flush = false in the out_of_memory
label? (as you don't call pod_unlock_and_flush that would do it)

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Tue Oct 19 08:17:20 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Oct 2021 08:17:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.212864.370909 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mckJ9-0007z9-85; Tue, 19 Oct 2021 08:17:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 212864.370909; Tue, 19 Oct 2021 08:17:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mckJ9-0007z2-4z; Tue, 19 Oct 2021 08:17:15 +0000
Received: by outflank-mailman (input) for mailman id 212864;
 Tue, 19 Oct 2021 08:17:14 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=gzZp=PH=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mckJ7-0007yw-UE
 for xen-devel@lists.xenproject.org; Tue, 19 Oct 2021 08:17:13 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id f6133822-30b4-11ec-8305-12813bfff9fa;
 Tue, 19 Oct 2021 08:17:13 +0000 (UTC)
Received: from EUR02-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur02lp2053.outbound.protection.outlook.com [104.47.6.53]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-22-zLLeUXrAPuSOfNmxVkJ8RA-1; Tue, 19 Oct 2021 10:17:10 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB6173.eurprd04.prod.outlook.com (2603:10a6:803:ff::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.17; Tue, 19 Oct
 2021 08:17:09 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.018; Tue, 19 Oct 2021
 08:17:09 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6PR10CA0076.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:209:8c::17) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.15 via Frontend Transport; Tue, 19 Oct 2021 08:17:08 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f6133822-30b4-11ec-8305-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634631432;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=1S/1I6DQrepmMJMZXs0L36Qo4Gpek8KEUHClCiTiwBg=;
	b=S8m+0xl/j9ry5PUbcWANIFCF7+xJvTud3yz5GuyprHa/S2CryoiLEM5g0HryhYNWaklYMR
	rClkMQEblMc5qoBXv6D74Ysam5F8cukP/OSZsa84xB1K6RWWg/4T7l2+e/J+TBzuaiOK5s
	8VBDCd5m9DlvZSVKFWoFM5N5aV1pJO8=
X-MC-Unique: zLLeUXrAPuSOfNmxVkJ8RA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=P15S3Zs8MNLeA2/lv7bfrvkFobMPQ5GNhBrpKDxXLv9WoYRpF1QDp8osnY5DZUe6p1fWNeCUriSPGrRetmdhKpQgd3Kw/u3C0GwECIbXWp16aaYfRaX6I5dm8fsrvIV3HtOXli6D13JaWUBm7Ns0IQX3vsSKCiDEhJKTKE974CON+3aem2qhqXcfUuKa1cYSINcNUGuy6tBxVatepmfJpTmFbIwJg4HyD1IjDRiMU78DHHOqkHoDUmlv6r4xAnVumjLpzD/7HlyBCyb2w7fYl9PaKgfVFGN3LjAtj7C+hp/QhJI48XfJvqy5EdJWmVUp2GsKv3LL7W2Hq67fGRklFw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=cvibTTjJ/Ho86MIUJF0vJCTQshy/ICg8hJvurCqVAgY=;
 b=Y75UtwEL0MTcTbLs6iZgTH2iwa2JEMhlY59lnlARuj3PZPB4MZ76EFREvKvDRuWDIl/AuPo+xXWLIR/MadDq7dRqD0vUg8RCfIAxI35kuvEzpQBYUM80JUUKCZWJMDH6Bbrdk0ZvK79luF4SyIFblKaSqmASSYy/msb/AJTKMFF2IC5hL7JPIYLSbVtVd4cjBeme9YXd/gL68veT66Ay4HHLS8tkWnc3DbIPb1kb3jX74tZghNCJ/gO/9msywwJg7EdRFt2EY7vzCbsd5729WSfBW2OBosi0e+ZP/GIINTjLYLJhQJDpcFuE2Y+qMVq8DunOgpJ5X61CC56HuRmNYA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: citrix.com; dkim=none (message not signed)
 header.d=none;citrix.com; dmarc=none action=none header.from=suse.com;
Subject: Re: [PATCH] x86/PoD: defer nested P2M flushes
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>
References: <e47d51c6-1b4b-2f72-6e12-070df66c30e2@suse.com>
 <YW59OUi9tpnGccl7@MacBook-Air-de-Roger.local>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <fc543483-bc67-1323-6db1-b335bbdc4238@suse.com>
Date: Tue, 19 Oct 2021 10:17:07 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <YW59OUi9tpnGccl7@MacBook-Air-de-Roger.local>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6PR10CA0076.EURPRD10.PROD.OUTLOOK.COM
 (2603:10a6:209:8c::17) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 66a23284-e201-49a1-0202-08d992d8d843
X-MS-TrafficTypeDiagnostic: VI1PR04MB6173:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB6173DD5C26010B64F76EFA41B3BD9@VI1PR04MB6173.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:1201;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	67qJtLB0gv47wUNKWrV0/ufEf8Ozc2djdv8uv6FGZBWqGWJXMeK5SJsexDw6J90XkH1e5wS9usVIJ3OnINC/DOxUdI3dXHt3lXSVMj2fXip5jUlW5uH3qM7L05U6hFIsSZE/vF1fOgJpb7KCRKbdYbztK/gCdxtoy9HvkZk4DkL8Gl0vRnYfTN4u22qx2AVJSQNJNcPdDtIaqOVqefEojO2cQUL7SnsELAhLXWR7DFGIqlmZg99un7qfNLk73KyLcGNQAo2mCgw0Mh5NqmqeaLoqziFed9JEH7sjhAvY5OxemVj/zelJKqlnPvhDZIuxAvp1kfSf4usWYHJolPo3tKTtehrdrUwMKnnbsA0kR5bvY/5KsACtERME8LH0vdGurznuXBQE7msnaEKxQJdHzNtKDmzWVMEYzaCO7PrjxeSqtKfktXN867KNOX7hotnQYMXj17UwmDTIFJ96vFvmJ/g0SDpcC3dPMW/EfbDwDjgi0wEADv3+hHIQwPG+uw4kOdX3nqHeCXXzFDB60RDmIkLMdM17rgjPfYozOzrfvzDQ0iy3AGo/ISjoICCFh9iA9JXnMnDLCC5ucpq0Wbl1MdoCUb3c6N1Xbn5WpGw7bm8aQS1NT+74IMSUbIn46Q2+HXrrVk7yJ5N8gRutbIeLDR7rTefE3bJnr8C0H/UZs2dB4O9oRppd0urc+PsfJExWrR/qOZHe0inEyjtuDlvmpYJxhgYbYvlOgOkccFyDJw4=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(66476007)(66556008)(66946007)(508600001)(38100700002)(31696002)(86362001)(53546011)(36756003)(4744005)(6916009)(8936002)(31686004)(2616005)(4326008)(16576012)(54906003)(316002)(6486002)(956004)(2906002)(26005)(5660300002)(83380400001)(8676002)(186003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?6USEdPWf9MmGOlzMFu8/nL+Qx+f5ppKk2VgLRek3tEvj6dtqKRk029dvGeAY?=
 =?us-ascii?Q?lGEHqTFfiNhlLUcJ4dWY9xQAPt6/yQFzphinz8oiQaqAPEQ1rdtptEHsW88g?=
 =?us-ascii?Q?Hr0TYuPWpLNQifMP7MuXv4wFPd7RMOVnbldGXLS3uYOBa+otLO1vSw3emGDu?=
 =?us-ascii?Q?s55FgUBB0YOCOB6taN2dDNc/j46WWUYuRKn1ANKH41E86rHzKM9hlEQU9pYA?=
 =?us-ascii?Q?ke7ZG1+wgDxPKW6J6lRRatQqYZ2a/ehR8KOVm+u3cUy5Z8rQsZsMotHDluAH?=
 =?us-ascii?Q?nHSFkA2kQzQJrkVFJJNbvzH/dVmX8YoJvWMgfQGdH0GvFWQmh4J0dhThpBFw?=
 =?us-ascii?Q?VGiO5AOF20op1hTGjxAqs7RJNil9d/DuiG7skOt0wCyZZfkoS7SeJI4KhuG8?=
 =?us-ascii?Q?zh09VWDG49r6wwyvgDlb4WvFA8hNM6vdQUGXJtEqtLr/R4v81nweM1KiJWX6?=
 =?us-ascii?Q?4tspYGDZK8qLpHdbK6O90aLIlbOwnr/LJkBTvpO3iZdhHnRAOucpy8nCGXGa?=
 =?us-ascii?Q?TYicqHmea5Wm8Nno1/V9uF4C2eoJyN1bFeCawe1D+yTdPzR2Yg6rSu+eptE4?=
 =?us-ascii?Q?IEr5+L4fogLjo8ayTdGTd+s7mvMd4h1cjRTQ9iz70+asUmfRDXXI1hND9bmz?=
 =?us-ascii?Q?1WmsuC75numdf1h3NbnxLLj+IU40bx8nJv2mLUzMUnzkTJ6XhmJBB28+y/jx?=
 =?us-ascii?Q?cO6N2uRBpQPOjjKf/+3hLwhn/ZFkKCS8W+ULDYGSS3HG9PLoPrrmSy7L4eHg?=
 =?us-ascii?Q?uhNKEUvUSfVOehbqISMZ00izwGfRb6/2S2p602eEazE1vVBW3iugiZrPzz5R?=
 =?us-ascii?Q?4EEamvDSnNPKiOfyPg/D825Srlh2VBSjuksodjimlGkUGkl2NiC8OUmocMsn?=
 =?us-ascii?Q?WvwgY2JwWR7nm+vHkk5CFMoLAS9I/v0epoEcdcAQlms1FBEEUr4UJZTLilpZ?=
 =?us-ascii?Q?Buvh08f/XZ7HoIlnACfNYDadn8lOQ0YSlIF9XhlEFBxHzpe37JUGujbCS9np?=
 =?us-ascii?Q?676oAF9zYLsiT3ahuaVlzBWjfDQ8Jw3Ah6TNME8FLLTS4Oscw/oRE2cXLjhG?=
 =?us-ascii?Q?br2VE6NnA++J8Fz8p7Vtoip2RpiejMziIq1pc2y5J5kNplN7/0Weye0nAYrv?=
 =?us-ascii?Q?CaVZNsmgu8UPY1JTRiaor4B6SrPsomck7WgWFeKNOgMUycorgWXNL530l2zJ?=
 =?us-ascii?Q?5RfRCXuPbqOca0l0uGQq/XOMXSR6kr89mtRb+c+siLDmvTTwrHAO03QOVV97?=
 =?us-ascii?Q?JZlKVjn3VJ+0nBLMkBtH9fat/opAd/l92+9L2LOR0NErT3KTBJSm0OtyJULX?=
 =?us-ascii?Q?2IXLkho5KXF1Pqc0knkssaOc?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 66a23284-e201-49a1-0202-08d992d8d843
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2021 08:17:08.9596
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: crQYIZc9yU9KA6xi3oED99HV71T2KPWJkfpskta3zrlqd8qShiL3o+XLhobR9NsJtfELGuLYvhiQlYwPdTkLew==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6173

On 19.10.2021 10:09, Roger Pau Monn=C3=A9 wrote:
> On Mon, Oct 11, 2021 at 10:17:08AM +0200, Jan Beulich wrote:
>> @@ -1229,8 +1242,9 @@ p2m_pod_demand_populate(struct p2m_domai
>>          __trace_var(TRC_MEM_POD_POPULATE, 0, sizeof(t), &t);
>>      }
>> =20
>> -    pod_unlock(p2m);
>> +    pod_unlock_and_flush(p2m);
>>      return true;
>> +
>>  out_of_memory:
>>      pod_unlock(p2m);
>=20
> Don't you need to set defer_nested_flush =3D false in the out_of_memory
> label? (as you don't call pod_unlock_and_flush that would do it)

Yes of course - thanks for spotting. I had pod_unlock_and_flush() here
too initially, and when switching back I forgot to convert rather than
just delete that.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Oct 19 08:20:05 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Oct 2021 08:20:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.212873.370926 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mckLs-0000eR-Rv; Tue, 19 Oct 2021 08:20:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 212873.370926; Tue, 19 Oct 2021 08:20:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mckLs-0000di-O0; Tue, 19 Oct 2021 08:20:04 +0000
Received: by outflank-mailman (input) for mailman id 212873;
 Tue, 19 Oct 2021 08:20:03 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=gzZp=PH=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mckLr-0000RW-7U
 for xen-devel@lists.xenproject.org; Tue, 19 Oct 2021 08:20:03 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id c84f66a5-c0aa-4c14-9141-15a758139818;
 Tue, 19 Oct 2021 08:20:02 +0000 (UTC)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2171.outbound.protection.outlook.com [104.47.17.171])
 (Using TLS) by relay.mimecast.com with ESMTP id
 de-mta-10-aQKHriRwP7-Nl3T92WmYkg-1; Tue, 19 Oct 2021 10:20:00 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB7039.eurprd04.prod.outlook.com (2603:10a6:800:12b::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.18; Tue, 19 Oct
 2021 08:19:59 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.018; Tue, 19 Oct 2021
 08:19:59 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6PR08CA0025.eurprd08.prod.outlook.com (2603:10a6:20b:c0::13) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.14 via Frontend Transport; Tue, 19 Oct 2021 08:19:59 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c84f66a5-c0aa-4c14-9141-15a758139818
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634631601;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=wLd4LSj7xY3Eb1qHGJbLjUsKx2l2uyskN8OtKLVs6ko=;
	b=IPYryWizBJsWuxU9sUT7Em/FfQN1OvkBJ/VIvVGT1ilduNRvHjLJFjWVf4/nvG+D8qpGFF
	CTo8gY9tXmAM/E8vX+jCjNNJywGBzEGDkcZdkUKvDTcBi9SYhwFjW5q6v+xDrPGEBND3fo
	3aRrY7cFDeLIoW0sgAUqR77MYiLXmhg=
X-MC-Unique: aQKHriRwP7-Nl3T92WmYkg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=E6i/2BC0MKz8Md4XeO0Um0t9hP7iTzkH5HGhHkf6zF32N6yfi9ReKl3itKkBcG7xDvEG9enAA2CLUvthpiPS6vlkOi3XY0XNRz5Id6buTF5976JuKf3Z+beGE8WvGIo9CFAPvB76wdMcRX8bJNEw06MAsQw+rqEdffkS26mBlqr6abCoea3w5ikfCVAHAE/KvS98kpA1USlrwwMBELXPa35v5RaQueUzu77OvRByby9FnIJWJVs2kjESmesfplU0uVFaQsWP8YfmBsnH2ZShTKar7go7gleNEqP/XlLywy/oxub6MIOsikRkwvKtWy8FpaasCAVTL5PGN51TM+uT7Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=baP6DYa68zhFQLDQE0GpQyqWX9/SJ38GAe8So7JQDY4=;
 b=F/VtC9kukHhaSrcXpObCq8prBsNYQbOgk+XfkCJbIE1A7sN77GlNdR9HbUmiqNKrlPr7GyRwJmvy8uvep3mR3OaCzhJ5SmuRZNzMZgacR5cw+7XXonD8bKEwyUJXc088dG2phlL3Hi1pw/KQ4h5BdWzNCRUletONBawYKd6zVXNBrgc/ykOJjwKIrtyNQo2rq4Di7m9Mz8Viob/QhhNExO37zMQ7a5O6xFNyYDj8akTprNC6rxpXCbDsyTLOyrgBP4yArGLJj1pJA53hUtdmqx/+lGOU7q0KDWYcngoMtDLhwwyhJqw5AgjjSrwym+C7w2EPiCqInLffVjDD+gE0Jg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: citrix.com; dkim=none (message not signed)
 header.d=none;citrix.com; dmarc=none action=none header.from=suse.com;
Subject: Re: [PATCH] x86/PoD: defer nested P2M flushes
From: Jan Beulich <jbeulich@suse.com>
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>
References: <e47d51c6-1b4b-2f72-6e12-070df66c30e2@suse.com>
 <YW59OUi9tpnGccl7@MacBook-Air-de-Roger.local>
 <fc543483-bc67-1323-6db1-b335bbdc4238@suse.com>
Message-ID: <65a88325-909a-7995-4ded-c9d77b386129@suse.com>
Date: Tue, 19 Oct 2021 10:19:57 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <fc543483-bc67-1323-6db1-b335bbdc4238@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6PR08CA0025.eurprd08.prod.outlook.com
 (2603:10a6:20b:c0::13) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 9fb39872-8f99-4f01-e2bb-08d992d93dfb
X-MS-TrafficTypeDiagnostic: VI1PR04MB7039:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB7039B8518846A88F5703D6E6B3BD9@VI1PR04MB7039.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:5797;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Q/oO3kYP60iNSB1sXyK2sDQ4OcY1Jaow39W1MdLUt+h4e0S+3daJrdiCoJu8NsSnVioQHV9cAcSc532NzyhtXUpWcbJg5oc1LaqVgTWB4ZcZxlLnbzMvb+0Ts35aqrZNZ4phtma2hHTdX5j8yUFHjywoCZOP+vnt7DhuTKO8fIb3sKGj30ynQ8YO0YhlOJZCjq/l22dlaP1Opz0aKmmsQdaVZHEqm1ni5IORTur34cjl17aMUDFYlWmJ4Dg9AUton8UYBHpUM6OhL/5q536q+ZzezpsE3gaix9gy0f6JHCeZ6Bf4wsu87xWYhFPSkzKbm4wwIo/cF2IB1Mxi7BWMuWWaWIAfWwpUjlGt3y6TbhI/rXxFzBFZTTi2jOuYUv5I1yEbzNk8+HdvF6j2SK8xlozLDvdmGWEfFEbsH99vpC3QZxs5Ah+5qO1aaLisBOLVboZAHVEmzdvQb9VvMO1Gy9Cey7MHYyxQQVNDmoTXonZNRzPlEIZnvAmIG14N7ah+l5TLwXwHkdyl4lmwD9hczFAP0DnUcle4lzSuosziTy5Qm20KZAxlUiNvinWUlLAhE8Lxhd5UzAj4rnfKF4ejr8aa09q2hmFnW1UA30IzExuGmmquQCqqwSuUSasd28WU7RBONJ8ZPpYel6uKxOVWn0x0fAIzWt0SWXtVxN/0sRcX5sUzwv0CJdXLIIVwVzIP9QCUw5aQr5ppE+vFKqQREEhKO9mR0g4sdnQdaS7l4ag=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(186003)(54906003)(86362001)(6486002)(956004)(2616005)(2906002)(8676002)(31686004)(31696002)(508600001)(53546011)(6916009)(66946007)(66476007)(38100700002)(5660300002)(26005)(4744005)(66556008)(4326008)(36756003)(83380400001)(316002)(8936002)(16576012)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?djxIAC+Q2NCqFXLnxiJct47hkRlOGeZejz4Fk2hr3u7jJBInUk/PclFlCN0W?=
 =?us-ascii?Q?w3EBtoWMGvbObE964TSRS4TaagAhKQ0kr+ovTq6khKCzUkf1eG+apKznmTou?=
 =?us-ascii?Q?/Yotlsbtwu5ajsb5VAgFEKCm+1X5ZpgVpLI/jp/KcLkimKqHztRpuHp7K3hs?=
 =?us-ascii?Q?7KPyaGkq0qr8iso+g5PqrN4NVJ675tAUgT6u2/0fRejy+quAnU+6Jl6+tnBs?=
 =?us-ascii?Q?DY5hD8D6Wo42eqYcY5ASx9Wb6oZR/ZFekUYRYJuLzR6Aw6m/O2Mb5nqWKCwm?=
 =?us-ascii?Q?o67sWQ7Cq59CCJwJVLKZdIcSpFB00of73AZ8t0T7GBsJjLHqruxBXkMCIG0R?=
 =?us-ascii?Q?lVf7NPe/++vf4zT9BvaJ91oJoQ88UycPo9u/GAInEg2JCNOoCpv5TZNmrAqm?=
 =?us-ascii?Q?QgBoeGJNRdKySZU+eyivuxfjV57n68/l0/3KHt83cxH0BpmyVkiFvsBi7gER?=
 =?us-ascii?Q?w6fGU5J5OL4f8N4N5Zi28zkFBMA1VYaXqaG+0kPtxuWvCkrFwWTXtDm6N4t7?=
 =?us-ascii?Q?SjKi6Q0OZWZf1lBaTecMnlY95SvHVxr1Y9Ebz54Mm7oU9rwpWMf3HAX66pM7?=
 =?us-ascii?Q?jyPbgYqRPf3l1vGZI5wLcdjT7ctYWxXoBSySwuWuGRhod61Y3AWX+H0Iv26C?=
 =?us-ascii?Q?JHL5jOGOQhGcXG2a7D8n3Nl6lItS44NCMZMzRgu9nK2Zb2Fib4rrDIv+9xyz?=
 =?us-ascii?Q?bpla+S3TfoHHLL2k6m9HdGYpI6bwowudyHoY8In4aJZ2m5FGKu+whIUW3IhW?=
 =?us-ascii?Q?63SWOzObaPwoRl7JFeMuOWqxEbbVn6/EA5LDYvRt0hOuF4ZwSsDegGBYNT0S?=
 =?us-ascii?Q?iblT6GtPg9r5lNHyPVfHFjW1yWcnWHbt5ThFiWQdp6JGBOVLLK3btZrVNW/S?=
 =?us-ascii?Q?Dwf9UQ1Ybz1P2sTdJIpJjsmDoS8C0FVI0GvzkArHz1gk5Z8MzDbkUzVNrwfa?=
 =?us-ascii?Q?srV22BwAN36xrTIBDGmC+JmDDXHJHGJ4wzyBzB2lbNFikHZTlHYMo3tTd9Jd?=
 =?us-ascii?Q?gLYOEop5Zhc9hXs5FBfWcrP/+i0bCrWHueqRfwMhGDDAX+2hBxbNquZrc2iZ?=
 =?us-ascii?Q?0X6LEct3RCtp2ziEGNF7ijzkgTBDEFYMSp27FSFr9Q1eX30PnMnpjvycGn+1?=
 =?us-ascii?Q?yRznJhK56hkxHyzvfXR4urVT5Hf880WoPRzuhbXQni6oB78SPhmBr+du/gbS?=
 =?us-ascii?Q?/X9KZ2VHiPY2MRaM1hyXddQ6bKgQtdQbcjxizZKhXX4atwiInvHEZMDNI1pa?=
 =?us-ascii?Q?IG2yF7OYpY73vgsTfQPyw9ZopAFhGL2KZsXyDA9M7fUI8qp3FIG6c3l58R+c?=
 =?us-ascii?Q?Qdy/ZvYQoiJBf5rRQ82HGYDS?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9fb39872-8f99-4f01-e2bb-08d992d93dfb
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2021 08:19:59.6231
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: UG6os5fLwHGzi2+4PSOcsfV4IKKYk9HL6z2lh0TSlIVZcMIGCTC06CevJNZSpnED6eXj1YxPzCVaFsX+M/NZLQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7039

On 19.10.2021 10:17, Jan Beulich wrote:
> On 19.10.2021 10:09, Roger Pau Monn=C3=A9 wrote:
>> On Mon, Oct 11, 2021 at 10:17:08AM +0200, Jan Beulich wrote:
>>> @@ -1229,8 +1242,9 @@ p2m_pod_demand_populate(struct p2m_domai
>>>          __trace_var(TRC_MEM_POD_POPULATE, 0, sizeof(t), &t);
>>>      }
>>> =20
>>> -    pod_unlock(p2m);
>>> +    pod_unlock_and_flush(p2m);
>>>      return true;
>>> +
>>>  out_of_memory:
>>>      pod_unlock(p2m);
>>
>> Don't you need to set defer_nested_flush =3D false in the out_of_memory
>> label? (as you don't call pod_unlock_and_flush that would do it)
>=20
> Yes of course - thanks for spotting. I had pod_unlock_and_flush() here
> too initially, and when switching back I forgot to convert rather than
> just delete that.

Oh, wait, that was on purpose: There's no point clearing the flag
when the next thing we do is invoke domain_crash(). If it wasn't
that way, I don't think I could avoid using pod_unlock_and_flush()
here as well.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Oct 19 09:07:58 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Oct 2021 09:07:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.212898.370939 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcl61-0005CY-Rd; Tue, 19 Oct 2021 09:07:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 212898.370939; Tue, 19 Oct 2021 09:07:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcl61-0005CR-OC; Tue, 19 Oct 2021 09:07:45 +0000
Received: by outflank-mailman (input) for mailman id 212898;
 Tue, 19 Oct 2021 09:07:44 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mcl60-0005CH-Pr; Tue, 19 Oct 2021 09:07:44 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mcl60-00067W-KP; Tue, 19 Oct 2021 09:07:44 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mcl60-00055n-AX; Tue, 19 Oct 2021 09:07:44 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mcl60-0006tR-A3; Tue, 19 Oct 2021 09:07:44 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=4dpZSKe6X02JCZkEvTuxCkL7FsZGfCineBexMfQeEl0=; b=piz2EkF2nBUf7HInu+gFqngRCf
	yFwu5gqDjM2uyGXV82qLOTsKqpSsgiuqLfQOujD+TZrjIMR1PURPFEZhFaUPgJudT5i2uAeBz8cSt
	aFSyr5Y7MtQS5UUcFe0dQ7BlY3dqabW5hGQFhpag7pBYDYBrFm9hw6GkL94sp0CnnDsk=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165661-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 165661: regressions - FAIL
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-xl-qemuu-debianhvm-amd64:leak-check/basis(11):fail:regression
    xen-unstable-smoke:test-amd64-amd64-libvirt:leak-check/basis(11):fail:regression
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:leak-check/basis(11):fail:regression
    xen-unstable-smoke:test-armhf-armhf-xl:leak-check/basis(11):fail:regression
X-Osstest-Versions-This:
    xen=3ae80dea4601764818d1e5b84bd1e4479c0d4790
X-Osstest-Versions-That:
    xen=c11b8d25fbe9c0155e91409594ea6701008409ed
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 19 Oct 2021 09:07:44 +0000

flight 165661 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165661/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-amd64-amd64-xl-qemuu-debianhvm-amd64 11 leak-check/basis(11) fail REGR. vs. 165635
 test-amd64-amd64-libvirt     11 leak-check/basis(11)     fail REGR. vs. 165635
 test-arm64-arm64-xl-xsm      11 leak-check/basis(11)     fail REGR. vs. 165635
 test-armhf-armhf-xl          11 leak-check/basis(11)     fail REGR. vs. 165635

version targeted for testing:
 xen                  3ae80dea4601764818d1e5b84bd1e4479c0d4790
baseline version:
 xen                  c11b8d25fbe9c0155e91409594ea6701008409ed

Last test of basis   165635  2021-10-18 13:00:26 Z    0 days
Testing same since   165638  2021-10-18 16:01:36 Z    0 days    4 attempts

------------------------------------------------------------
People who touched revisions under test:
  Ian Jackson <iwj@xenproject.org>
  Juergen Gross <jgross@suse.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          fail    
 test-arm64-arm64-xl-xsm                                      fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    fail    
 test-amd64-amd64-libvirt                                     fail    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

------------------------------------------------------------
commit 3ae80dea4601764818d1e5b84bd1e4479c0d4790
Author: Juergen Gross <jgross@suse.com>
Date:   Fri Sep 10 07:55:17 2021 +0200

    stubdom: disable building pv-grub
    
    The stubdom based pv-grub is using a very outdated version of grub
    (0.97) and should not be used any longer. Mainline grub has support for
    PV guests for a long time now, so that should be used as a boot loader
    of a PV domain.
    
    So disable building pv-grub per default. In case someone really wants
    to continue using it he/she can still use a pv-grub binary from an older
    Xen version or manually enable building it via:
    
      configure --enable-pv-grub
    
    [ This was already disabled in osstest by 8dee6e333622
      "make-flight: Drop pvgrub (pvgrub1) tests" -iwj ]
    
    Signed-off-by: Juergen Gross <jgross@suse.com>
    Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
    Acked-by: Ian Jackson <iwj@xenproject.org>
    Release-Acked-by: Ian Jackson <iwj@xenproject.org>

commit 9cfeb83cbe23a873de512211d7ecd989348b9df0
Author: Juergen Gross <jgross@suse.com>
Date:   Tue Oct 12 15:41:48 2021 +0200

    tools/xenstore: set open file descriptor limit for xenstored
    
    Add a configuration item for the maximum number of open file
    descriptors xenstored should be allowed to have.
    
    The default should be "unlimited" in order not to restrict xenstored
    in the number of domains it can support, but unfortunately the kernel
    is normally limiting the maximum value via /proc/sys/fs/nr_open [1],
    [2]. So check that file to exist and if it does, limit the maximum
    value to the one specified by /proc/sys/fs/nr_open.
    
    As an aid for the admin configuring the value add a comment specifying
    the common needs of xenstored for the different domain types.
    
    [1]: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=60fd760fb9ff7034360bab7137c917c0330628c2
    [2]: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=0c2d64fb6cae9aae480f6a46cfe79f8d7d48b59f
    
    Signed-off-by: Juergen Gross <jgross@suse.com>
    Reviewed-by: Ian Jackson <iwj@xenproject.org>
    Release-Acked-by: Ian Jackson <iwj@xenproject.org>

commit f282182af32939107d47943aba242d3189ec6f90
Author: Juergen Gross <jgross@suse.com>
Date:   Tue Oct 12 15:41:47 2021 +0200

    tools/xenstore: set oom score for xenstore daemon on Linux
    
    Xenstored is absolutely mandatory for a Xen host and it can't be
    restarted, so being killed by OOM-killer in case of memory shortage is
    to be avoided.
    
    Set /proc/$pid/oom_score_adj (if available) per default to -500 (this
    translates to 50% of dom0 memory size) in order to allow xenstored to
    use large amounts of memory without being killed.
    
    The percentage of dom0 memory above which the oom killer is allowed to
    kill xenstored can be set via XENSTORED_OOM_MEM_THRESHOLD in
    xencommons.
    
    Make sure the pid file isn't a left-over from a previous run delete it
    before starting xenstored.
    
    Signed-off-by: Juergen Gross <jgross@suse.com>
    Reviewed-by: Ian Jackson <iwj@xenproject.org>
    Release-Acked-by: Ian Jackson <iwj@xenproject.org>
(qemu changes not included)


From xen-devel-bounces@lists.xenproject.org Tue Oct 19 10:16:53 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Oct 2021 10:16:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.212932.370980 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcmAg-0004dq-HH; Tue, 19 Oct 2021 10:16:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 212932.370980; Tue, 19 Oct 2021 10:16:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcmAg-0004dj-E6; Tue, 19 Oct 2021 10:16:38 +0000
Received: by outflank-mailman (input) for mailman id 212932;
 Tue, 19 Oct 2021 10:16:36 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mcmAe-0004dZ-T5; Tue, 19 Oct 2021 10:16:36 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mcmAe-0007Ks-O2; Tue, 19 Oct 2021 10:16:36 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mcmAe-0007RA-6h; Tue, 19 Oct 2021 10:16:36 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mcmAe-0001o7-6B; Tue, 19 Oct 2021 10:16:36 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=uNiNRR5xuuN2GXwBrYFx6gVcp0gXcCSvBn6N67pV/ko=; b=Ur/N8GX/lXHeup03Y+hvgxSW3w
	TVv295FMBWQpz5xnHP2dZouyziNyuTW0l8H8xT1rjG3H5DdEhykVd1beG9vxXywr4OvPT0xYgN0Lm
	kc4whNjGEdnHcUpCSNG5Ax4rvET0zhBYCKETK6b8luqBQ7P4qCMCgDRLBA/xbeUYxhhM=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165640-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 165640: tolerable FAIL - PUSHED
X-Osstest-Failures:
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=9c050b661d3a43dfe2fd44106e559b39706d1296
X-Osstest-Versions-That:
    qemuu=c148a0572130ff485cd2249fbdd1a3260d5e10a4
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 19 Oct 2021 10:16:36 +0000

flight 165640 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165640/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165576
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165576
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 165576
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 165576
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 165576
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 165576
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 165576
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165576
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 qemuu                9c050b661d3a43dfe2fd44106e559b39706d1296
baseline version:
 qemuu                c148a0572130ff485cd2249fbdd1a3260d5e10a4

Last test of basis   165576  2021-10-17 00:06:59 Z    2 days
Testing same since   165640  2021-10-18 19:08:02 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  BALATON Zoltan <balaton@eik.bme.hu>
  Jiaxun Yang <jiaxun.yang@flygoat.com>
  Philippe Mathieu-Daudé <f4bug@amsat.org>
  Richard Henderson <richard.henderson@linaro.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/qemu-xen.git
   c148a05721..9c050b661d  9c050b661d3a43dfe2fd44106e559b39706d1296 -> upstream-tested


From xen-devel-bounces@lists.xenproject.org Tue Oct 19 10:39:57 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Oct 2021 10:39:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.212947.371004 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcmX3-00079m-IJ; Tue, 19 Oct 2021 10:39:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 212947.371004; Tue, 19 Oct 2021 10:39:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcmX3-00079f-Dd; Tue, 19 Oct 2021 10:39:45 +0000
Received: by outflank-mailman (input) for mailman id 212947;
 Tue, 19 Oct 2021 10:39:44 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=eXNP=PH=citrix.com=roger.pau@srs-us1.protection.inumbo.net>)
 id 1mcmX1-00079Z-Ts
 for xen-devel@lists.xenproject.org; Tue, 19 Oct 2021 10:39:43 +0000
Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 00c609ca-cc6a-4d8f-87f0-e73cae0f4d9d;
 Tue, 19 Oct 2021 10:39:42 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 00c609ca-cc6a-4d8f-87f0-e73cae0f4d9d
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1634639982;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=R6f87ZB9r5oCuJ6Dyq8GQuBUeCnRInzRdcauC3tGWiY=;
  b=ZWXp0+vkmNArtQ47AxiRgi26VNCu07vD4pEyKnVOtYfL747FdbpO6awU
   Xouvu+OPMwOQemyvLpfwl+RHVGr1O6VG11k5Aw51+L0wfvJmfFQV7bovh
   bYVhJG+O13N9FV5pvprLrEUmWFYrxf72zCCn4Q4rmCgQLvJXYj0XhCnx7
   U=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: 3EBZJGLoi4qLlV6fXcwGF4edLmLbk6gznL00ZqNUTTUNFp4n7c+hv95NZifF2fmiFZMOK+omVQ
 3YGWsRLGTaikmg3FIdtZz6BsH34vy1SLlkUSrHuO7UELqg7W9yMbW291VJlTkC5la9OZbPip8h
 HTrE9/SOHm7rmYIA4Hjy/sZFrzjGre9EXo4xKNmsVMx4WFMNfqsbCojO4XWL+265opm6DjtVMh
 EKqvwh6fNuoihcZXHIgwqEGylp4cZTQcZiWfHWTkFGs+DuWb7dPd6VBxbFReis5P6BXm4ipRlY
 vD3AYcUPDwuYgJdA14W6oZK5
X-SBRS: 5.1
X-MesageID: 57416952
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:ww52Z6OHVGJ4NHjvrR1xkMFynXyQoLVcMsEvi/4bfWQNrUp002cGy
 TRJWT/QP6nYZDSheIoibIm/pE8Hv5GDz9FrTAto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdpJYz/uUGuCJQUNUjMlkfZKhTr6ZUsxNbVU8En540Usyw7RRbrNA2rBVPSvc4
 bsenOWHULOV82Yc3rU8sv/rRLtH5ZweiRtA1rAMTakjUGz2zhH5OKk3N6CpR0YUd6EPdgKMq
 0Qv+5nilo/R109F5tpICd8XeGVSKlLZFVDmZna7x8FOK/WNz8A/+v9TCRYSVatYo2XXjo96x
 oUVj7PucwMYBqrjut8+FAYNRkmSPYUekFPGCX22sMjVxEzaaXr8hf5pCSnaP6VBpLwxWzsXs
 6VFdnZdNXhvhMrvqF6/YvNrick5atHiIasUu216zCGfBvEjKXzGa/iVuYYGjWpq7ixINcTUf
 ZIkW2Q0VSrBOT5XHH41VMoMl+j90xETdBUH8QnI9MLb+VP73AF3lbTgLtfRUtiLXtlO2FaVo
 Hrc+Gb0CQ1cM8aQoRKH+H+xgu7EnQvgRZkfUra/85ZXbEa7nzJJTkdMDB3i/Kf/2hXWt89jx
 1I8qnQ/8qM8pBSRYYfHWyyAp1GmhT1bRI8FewEl0z2lxq3R6gefI2ELSD9dddAr3PMLqSwWO
 kyhxIyxW2Q+2FGBYTfErO3M9GLtUcQABTZaPXdscOcT3zX0TGjfZDr0RdF/DLX9sNTxHTzhq
 9xhhHlj3+tN5SLnOqPSwLwmv95OjsSWJuLWzl+ONo5A0u+fTNT1D2BPwQODhcus1K7DEjG8U
 IEswqByFtwmA5CXjzCqS+4QBryv7PvtGGSC2gIyT8N/r27zoi7LkWVsDNdWfhcB3iEsImeBX
 aMukVkJuM870IWCPMebnL5d++x1lPO9RLwJp9jfb8ZUY4gZSeN01HoGWKJk5Ei0yBJEufhmY
 f+zKJ/wZV5HWfUP5GfnHI81jO50rh3SMEuOHPgXOTz8iuHADJNUIJ9YWGazghcRvPrV/lSFr
 YwBXyZIoj0GONDDjuDs2dd7BXgBLGQhBICwrMpSd+WZJRFhFn1nAPjUqY7NsaQ890iMvuuXr
 Hy7RGFCz1/z2S/OJQmQMygxY7LzR5dv63k8OHV0b1qv3nEiZ6ep7bseKMRrLeV2qrQ7wK4mV
 eQBduWBHu9LFmbN9QMCYMSvt4dlbhmq216DZnL3fDglcpd8bAXV4du4LBD3/SwDA3Pv58szq
 rGtzC3BRp8HS1gwBcracqv3nViwoWIciKR5WE6Reotff0Dl8Y5LLS3tj6Bof5FQeEubnjbDj
 lSYGxYVo+XJsrQZytiRiPDWtZqtHst/AlFeQzvR44GpOHSI5WGk24JBDrqFJGiPSGPu9ay+T
 uxJ1PWgYuYflVNHvocgQbZmyaUyu4nmq7NAl1k2GXzKaxKgC696I2nA1s5K7/UfyrhcsAqwe
 0SO5tgFZunZZJK7SAYcdFg/c+CO9fAIgT2Dv/06LXLz6DJz4LfaA15ZOAOBiXAFIbZ4WG//L
 TzNZCLCB9SDtycX
IronPort-HdrOrdr: A9a23:reyqYqx7GLW3zNJM/+S9KrPxv+skLtp133Aq2lEZdPULSKKlfp
 GV88jziyWZtN9wYhEdcdDpAtjnfZr5z+8J3WB3B8bfYOCGghrTEGgG1+rfKlLbakjDH4JmpM
 Ndmu1FeaLN5DtB/LbHCWuDYq4dKbC8mcjC74qurAYOPHJXguNbnnxE426gYzxLrWJ9dOME/f
 Snl616T23KQwVoUi33PAhIY8Hz4/nw0L72ax8PABAqrCGIkDOT8bb/VzyVxA0XXT9jyaortT
 GtqX222oyT99WAjjPM3W7a6Jpb3PPn19t4HcSJzuwYMC/lhAqEbJloH5eCoDc2iuey70tCqq
 iCnz4Qe+BIr1/BdGC8phXgnyHmzTYV8nfnjWSVhHPyyPaJDw4SOo5kv8Z0YxHZ400vsJVXy6
 RQxV+UsJJREFfpgDn9z8KgbWAoqmOE5V4Z1cIDhX1WVoUTLJVLq5YEwU9TGJAcWArn9YEcFv
 V0Bs203ocXTbqjVQGdgoBT+q3pYpxqdS32BXTq+/blkgS+pUoJjXfxn6ck7zE9HJFUcegN2w
 2LCNUwqFniJvVmGp6VP91xNPdfPFa9CC4kAFjiU2gPK5t3T04li6SHqondt9vaNaDh8vMJ6e
 L8uRVjxDYPR34=
X-IronPort-AV: E=Sophos;i="5.85,384,1624334400"; 
   d="scan'208";a="57416952"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=aHyzbpIRaQ2G7OED3Q1ye5vJTdqYjDIwjQwQ1HG/QP+am/vclBvS56i0fiz3tQNG7JvsqmDhAtdxNfxg2DN+CDsMc9r7jbkbqeyAMjXR3haB8sZg/LZEabMtm2iNU3+8PpQLE7ghtSTGlF1qzfSNIZJxy74a8ZW75JPGn+2984kvWQUqgND7eHwE2l9IgqXigv6dIjCpNn8VrEtjqly4V8EVGZsCusgbyaCHf2Mhj5Qv69zSPjvHZZNSfCYobWGgzS60X8YIthXUEJsAAColLNmUHeesdsMQwFWT7N0nBsJWzUY8bM6FY8TSn7YKPnoUmffQQzRQ+8JNnZPIoJ4/jg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=EFL4823SNII+1gV4BV56gIJj/Nh4nt3/c1MGH8Press=;
 b=HMzB4jOJZKb/oJ7ER7nzwgfee+YM4vKhk8+IuS372/GazgvGvT+lwBwAkj2Cff3fEXVevTlXiiZ/CeS8EMu36Jtbn1oUAnTdbg8SJutkZjzlTr5NaWumgkQSsblwst8Ux3wHaEEsfOaDEN2n0gVMy450skzecXa2F4XsJz2dtV1gGshT+WU/gtbO1dZINm6/0wFHlbV4KEsCV2Y+n4GIY1YWydb4PSNZ93+vgkdj6kQk5JFmJFNuSDR6c3XmcE01tLIKfw2/vFcdECUt7bIzoe9i9vjH7WCqfAIOL6SE9s0hob7se6h5h+YVUlNqqXZ3yzbWPMcYcQubDFH+vttg4Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=EFL4823SNII+1gV4BV56gIJj/Nh4nt3/c1MGH8Press=;
 b=F3rYooIKBCSm4blU07GztDSMOOqvJcZlad3kcdtlgn6T8d9wSQInaWliknI/tTAjO5UUjs/FVwpCOy/TDMEc2k043ep42s5S6Wna7nWvWWH/QrMqKeO4jSlXl+ge8ZxSfllUTEG/HQ059tzcPcrCGsxwEBW4wVtFSNQ35C2i1zA=
Date: Tue, 19 Oct 2021 12:39:03 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, "Andrew
 Cooper" <andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>
Subject: Re: [PATCH] x86/PoD: defer nested P2M flushes
Message-ID: <YW6gR6L0UkCm97aM@MacBook-Air-de-Roger.local>
References: <e47d51c6-1b4b-2f72-6e12-070df66c30e2@suse.com>
 <YW59OUi9tpnGccl7@MacBook-Air-de-Roger.local>
 <fc543483-bc67-1323-6db1-b335bbdc4238@suse.com>
 <65a88325-909a-7995-4ded-c9d77b386129@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <65a88325-909a-7995-4ded-c9d77b386129@suse.com>
X-ClientProxiedBy: LO4P123CA0149.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:188::10) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: b2418346-b5a0-42ac-fedc-08d992ecae93
X-MS-TrafficTypeDiagnostic: DM4PR03MB6062:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <DM4PR03MB606279BA126E0BE45117F5528FBD9@DM4PR03MB6062.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7691;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: enoD+BBcRRok/yZuv0goankJd854O1O7MCXeEgES94YdsZRh6bTigXcw//Ktdy6QKlAKDQ+wUUPzb+4EsNg8HWKKArA7lb/+rXdrWuStNTTDmmpIAkuCpDDqD+7ozX2PJbeXa6vsNvGfN4YyvBNbtpA9gGBPobfhk6cEBmErJU0WxwcyPl7oDAY1MIvrTFi44Drk3IeSFJx49OCD3IOIn6hcxLLjsmoCsWkPTFZ/hEbgZdxqWl1srWDmQBLIYGAimAguLVP7w4Yd2ecuQGR3OUcugTDsGPehpWQV3x6+jge86ZQAs1pcn/T/tW2UqcFCIrjQxiczKN5GAIIPsxHHcqvLm3fW/5vK6ZlEq0hIKlt+iaafxe/94Fw6At2/a2z/eRn10043DSUR3TlvPXuJqPCrhyPkRtUz+WkYSZCJSy1Xdq2RbJeTSdYc2gPLGAWNPBvH/UWkgxqYHWdAa/GPojyMf1qVyy0NtLFExypSn8LqvxTmPnvnx8efXRMI/3s6NXYjOgtYzK6MK5CL2TnT8epF5NCn23YU/FLuzznpB27YAMvQqWoHyVWYWvsvmID9UrixpxHZRlpXgka5XpQ3CjfWZ7XPg35CfmFQYhora++Vd/IcuFqnpdZ7WCPIH/itF0fAmRShRbClsdxCCO6WFQ==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(8676002)(66556008)(85182001)(83380400001)(66946007)(316002)(86362001)(26005)(508600001)(38100700002)(956004)(8936002)(186003)(54906003)(6916009)(66476007)(6496006)(107886003)(4326008)(6666004)(5660300002)(53546011)(2906002)(9686003)(82960400001)(6486002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eWxvZ1E3YjB5U0Y4bzF2d0s2NVozNVlnVWxJb01vOU9jemVQZ2tTMzVweFBX?=
 =?utf-8?B?RTE1MnFhK0V5Nkl2eDdxNWJ6RE1TbG1xNkhFMnNBMlJLdFcwV2s5b05QSGZP?=
 =?utf-8?B?MDEvZGhYVlVVQ1BWelRoOHFOZ003Ry9wa1praXFxRUFOcU8vNGJ5V25PK3RJ?=
 =?utf-8?B?WTZ6RG14cXR2M1g3RHdJdzBpSGJuaGhkSHMyY2FJeGtrc0JvU2ZSUmZGNFp6?=
 =?utf-8?B?bzk2MVUzejZvcTJiald0SUJzYk1LQVZQTE15ZGpPcDlkeXpGRVE2NWJJOVpY?=
 =?utf-8?B?Qk1mdUNlVTFaemtkcURCMFMyRHN0K1JuUm54ZVRzcVVnUHBodFlWU2xCeUxH?=
 =?utf-8?B?YWovUFAzeXFlSUNlSldxMlRmTEtlWkhMVGNqdHZjbGJoWWMvMzArT09rU3hD?=
 =?utf-8?B?ZklRMzNBcllNOEFLeWRvYnNVQXd2aEd2cmxWelNuSFJBdzRmM1JibTlwZ0xN?=
 =?utf-8?B?SHorZHRDTHRkaVUrNmZVOEh2aS9MVWs1cHJ1VTV0ZGxnbzVlYVFXdFdWZEpU?=
 =?utf-8?B?SUJCQWNKN2dKcWRYbUxzYlVaRWNzeEZzNG1PSTllcFBOY3RzTlQ3ZFBLazVQ?=
 =?utf-8?B?L0cxbzhVQVFsUTNzbUZ4QXVmRkxJdE85VmhkekRHVUNSeVhydzB4S2dRWG1m?=
 =?utf-8?B?VE05SDZMWjFPUkpMRG0xR3ZkZlp6Qm5RbGFYKzdsZGYwbXZ5KzhaV1hUb0g2?=
 =?utf-8?B?ZE5NSmJtNGlRUHhBYVZHK3N6S01XQVNNRGVvSUhwYTd6V2pucWo4eTY0azRJ?=
 =?utf-8?B?Z0lXazNUOTZDSTAxMTdTOEFyU3ZOTGNIZ3NiWm8xTnZGTnR5VHpRd05uY20w?=
 =?utf-8?B?eXpmdjQrVitSakNYMXVmYVdpcjVQRmZhZndrRHlCbGpVaDEzbUYxQW5pUi9J?=
 =?utf-8?B?QVc3djBxN0s5dUtVMXpKQkpuTTVrL2EyaU5aMEJSRTlSSE5QWTdRTHVzYkR6?=
 =?utf-8?B?M1N2eGYwMjJ1NFoyYkFHejFRTFp3NjJuQWRzazJFSmN1L3FCemozaVdkMFRG?=
 =?utf-8?B?dFp4d3pqcDd4V3FxQXA5UWV3QzdCMUQxWnVZZTJXRXlqcnp6MVN0SVlubmxM?=
 =?utf-8?B?TlRWa29CMnNJWGNzbVZxQi9LM09zNW84N2lGNmFpMWo1TnFKbnhsSytlR1dw?=
 =?utf-8?B?ZWV0ejRHRWJnNytybkd4WjJLU25nKzdES25EN0EyME5jTm5GclZlMGpPL011?=
 =?utf-8?B?M2xPUFN5ZVYxckFTYU5KOTB3NDhNKzJQNHFFMVllLzZTb2VSY1BLYWpsVFhM?=
 =?utf-8?B?MEQrcVVGamRNM1h3R2JjYXQvRFNwYjhENVJYNDY2YzBsVmRaNDVObk5GTzRz?=
 =?utf-8?B?VWNzdHJEbjUxVDZySHRNZzVrcHF3QWh1R1VtYjNlYnh4cjhYYndxVUQxMEov?=
 =?utf-8?B?Vk1SbFBqYzM4UFFlUHp3RUNkZmhKZUVxMytSNFZPeW00NVIrSCtwMlN5MDht?=
 =?utf-8?B?MW81ek5NZ2RFYWRHV1hBZU5XZ2RXeHhBdk9Ibzg0S2xiZmg4ZDdUMU1LV3M0?=
 =?utf-8?B?Q3pZdnpXQ0tRRUdYSmJjS25Ia1Y2OFlId2tIRGh2TVlBcXFGeXFtejlsN3Zs?=
 =?utf-8?B?WGNYYWt0K3k2L1B0eFhOb2JyZUhJZlBuN2Vwa3dieGlEc01MYUlwMlZ1THVT?=
 =?utf-8?B?K0RDMDdmK0NabTRVcWtMRGgxNlpSWVlFajgwTXVRVnpRZ0w4VHVmbjJ4aDBE?=
 =?utf-8?B?TC9QaTkwYmtqNzVnYUd2d1lzV3NiZVRYT1ZMbG16S2E2cE1QMGxkaUJ2NWFY?=
 =?utf-8?Q?PLHxsYGGZatmdRx78pUqUW8FusajGJ0Ayef4/EV?=
X-MS-Exchange-CrossTenant-Network-Message-Id: b2418346-b5a0-42ac-fedc-08d992ecae93
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2021 10:39:09.0598
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: RREVW91fJJQLVfo4huQbngAcAvvAcQd0bsVZGhD9ulvmPHS8ecm2QaciYfDqQ7R8IXqcdBXjmM7SVZC2UuVzpg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR03MB6062
X-OriginatorOrg: citrix.com

On Tue, Oct 19, 2021 at 10:19:57AM +0200, Jan Beulich wrote:
> On 19.10.2021 10:17, Jan Beulich wrote:
> > On 19.10.2021 10:09, Roger Pau Monné wrote:
> >> On Mon, Oct 11, 2021 at 10:17:08AM +0200, Jan Beulich wrote:
> >>> @@ -1229,8 +1242,9 @@ p2m_pod_demand_populate(struct p2m_domai
> >>>          __trace_var(TRC_MEM_POD_POPULATE, 0, sizeof(t), &t);
> >>>      }
> >>>  
> >>> -    pod_unlock(p2m);
> >>> +    pod_unlock_and_flush(p2m);
> >>>      return true;
> >>> +
> >>>  out_of_memory:
> >>>      pod_unlock(p2m);
> >>
> >> Don't you need to set defer_nested_flush = false in the out_of_memory
> >> label? (as you don't call pod_unlock_and_flush that would do it)
> > 
> > Yes of course - thanks for spotting. I had pod_unlock_and_flush() here
> > too initially, and when switching back I forgot to convert rather than
> > just delete that.
> 
> Oh, wait, that was on purpose: There's no point clearing the flag
> when the next thing we do is invoke domain_crash(). If it wasn't
> that way, I don't think I could avoid using pod_unlock_and_flush()
> here as well.

Oh, I see. We would need to be careful if that domain crash is ever
removed.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Tue Oct 19 10:41:32 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Oct 2021 10:41:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.212954.371021 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcmYm-00005i-AV; Tue, 19 Oct 2021 10:41:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 212954.371021; Tue, 19 Oct 2021 10:41:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcmYm-0008WK-1b; Tue, 19 Oct 2021 10:41:32 +0000
Received: by outflank-mailman (input) for mailman id 212954;
 Tue, 19 Oct 2021 10:41:29 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=XJzt=PH=arm.com=bertrand.marquis@srs-us1.protection.inumbo.net>)
 id 1mcmYj-0008TT-PC
 for xen-devel@lists.xenproject.org; Tue, 19 Oct 2021 10:41:29 +0000
Received: from foss.arm.com (unknown [217.140.110.172])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTP
 id 4b155b7f-cf77-4c6e-8dc9-7daa486107ab;
 Tue, 19 Oct 2021 10:41:28 +0000 (UTC)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A563AD6E;
 Tue, 19 Oct 2021 03:41:27 -0700 (PDT)
Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com
 [10.1.199.62])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 8FA733F70D;
 Tue, 19 Oct 2021 03:41:26 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4b155b7f-cf77-4c6e-8dc9-7daa486107ab
From: Bertrand Marquis <bertrand.marquis@arm.com>
To: xen-devel@lists.xenproject.org
Cc: iwj@xenproject.org,
	sstabellini@kernel.org,
	Oleksandr_Andrushchenko@epam.com,
	jbeulich@suse.com,
	Paul Durrant <paul@xen.org>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>
Subject: [PATCH 0/3] Fixes: PCI devices passthrough on Arm
Date: Tue, 19 Oct 2021 11:40:32 +0100
Message-Id: <cover.1634639117.git.bertrand.marquis@arm.com>
X-Mailer: git-send-email 2.25.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

This patch serie is a follow-up after various findings on d59168dc05
("xen/arm: Enable the existing x86 virtual PCI support for ARM") as of
agreed in [1].

It does the following:
- enable vpci_add_handlers on x86 and not only on arm
- remove __hwdom_init flag for vpci_add_handlers
- add missing vpci handler cleanup in error path during pci_device_add
  and pci_device_remove

[1] https://marc.info/?l=xen-devel&m=163455502020100&w=2

Bertrand Marquis (3):
  xen/arm: call vpci_add_handlers on x86
  xen/vpci: Remove __hwdom_init for vpci_add_handlers
  xen/pci: Add missing vpci handler cleanup

 xen/drivers/passthrough/pci.c | 8 ++------
 xen/drivers/vpci/vpci.c       | 2 +-
 xen/include/xen/vpci.h        | 2 ++
 3 files changed, 5 insertions(+), 7 deletions(-)

-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Tue Oct 19 10:41:32 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Oct 2021 10:41:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.212953.371014 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcmYl-0008To-T2; Tue, 19 Oct 2021 10:41:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 212953.371014; Tue, 19 Oct 2021 10:41:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcmYl-0008Th-Q0; Tue, 19 Oct 2021 10:41:31 +0000
Received: by outflank-mailman (input) for mailman id 212953;
 Tue, 19 Oct 2021 10:41:29 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=XJzt=PH=arm.com=bertrand.marquis@srs-us1.protection.inumbo.net>)
 id 1mcmYj-0008TS-ON
 for xen-devel@lists.xenproject.org; Tue, 19 Oct 2021 10:41:29 +0000
Received: from foss.arm.com (unknown [217.140.110.172])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTP
 id 1e14144a-30c9-11ec-830c-12813bfff9fa;
 Tue, 19 Oct 2021 10:41:29 +0000 (UTC)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id EF208ED1;
 Tue, 19 Oct 2021 03:41:28 -0700 (PDT)
Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com
 [10.1.199.62])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E00A33F70D;
 Tue, 19 Oct 2021 03:41:27 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1e14144a-30c9-11ec-830c-12813bfff9fa
From: Bertrand Marquis <bertrand.marquis@arm.com>
To: xen-devel@lists.xenproject.org
Cc: iwj@xenproject.org,
	sstabellini@kernel.org,
	Oleksandr_Andrushchenko@epam.com,
	jbeulich@suse.com,
	Paul Durrant <paul@xen.org>
Subject: [PATCH 1/3] xen/arm: call vpci_add_handlers on x86
Date: Tue, 19 Oct 2021 11:40:33 +0100
Message-Id: <24f88973257b7038511a0ca49a992d38b295c26f.1634639117.git.bertrand.marquis@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <cover.1634639117.git.bertrand.marquis@arm.com>
References: <cover.1634639117.git.bertrand.marquis@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Xen might not be able to discover at boot time all devices or some devices
might appear after specific actions from dom0.
In this case dom0 can use the PHYSDEVOP_pci_device_add to signal some
PCI devices to Xen.
As those devices where not known from Xen before, the vpci handlers must
be properly installed during pci_device_add for x86 PVH Dom0, in the
same way as what is done currently on arm (where Xen does not detect PCI
devices but relies on Dom0 to declare them all the time).

So this patch is removing the ifdef protecting the call to
vpci_add_handlers and the comment which was arm specific.

Suggested-by: Jan Beulich <jbeulich@suse.com>
Signed-off-by: Bertrand Marquis <bertrand.marquis@arm.com>
---
 xen/drivers/passthrough/pci.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci.c
index 35e0190796..d7e09448d1 100644
--- a/xen/drivers/passthrough/pci.c
+++ b/xen/drivers/passthrough/pci.c
@@ -756,11 +756,6 @@ int pci_add_device(u16 seg, u8 bus, u8 devfn,
     if ( !pdev->domain )
     {
         pdev->domain = hardware_domain;
-#ifdef CONFIG_ARM
-        /*
-         * On ARM PCI devices discovery will be done by Dom0. Add vpci handler
-         * when Dom0 inform XEN to add the PCI devices in XEN.
-         */
         ret = vpci_add_handlers(pdev);
         if ( ret )
         {
@@ -768,7 +763,6 @@ int pci_add_device(u16 seg, u8 bus, u8 devfn,
             pdev->domain = NULL;
             goto out;
         }
-#endif
         ret = iommu_add_device(pdev);
         if ( ret )
         {
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Tue Oct 19 10:41:36 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Oct 2021 10:41:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.212955.371037 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcmYq-0000cv-DE; Tue, 19 Oct 2021 10:41:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 212955.371037; Tue, 19 Oct 2021 10:41:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcmYq-0000ch-9u; Tue, 19 Oct 2021 10:41:36 +0000
Received: by outflank-mailman (input) for mailman id 212955;
 Tue, 19 Oct 2021 10:41:34 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=XJzt=PH=arm.com=bertrand.marquis@srs-us1.protection.inumbo.net>)
 id 1mcmYo-0008TS-Mw
 for xen-devel@lists.xenproject.org; Tue, 19 Oct 2021 10:41:34 +0000
Received: from foss.arm.com (unknown [217.140.110.172])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTP
 id 1e14144b-30c9-11ec-830c-12813bfff9fa;
 Tue, 19 Oct 2021 10:41:30 +0000 (UTC)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 78C26D6E;
 Tue, 19 Oct 2021 03:41:30 -0700 (PDT)
Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com
 [10.1.199.62])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 3FF343F70D;
 Tue, 19 Oct 2021 03:41:29 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1e14144b-30c9-11ec-830c-12813bfff9fa
From: Bertrand Marquis <bertrand.marquis@arm.com>
To: xen-devel@lists.xenproject.org
Cc: iwj@xenproject.org,
	sstabellini@kernel.org,
	Oleksandr_Andrushchenko@epam.com,
	jbeulich@suse.com,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>
Subject: [PATCH 2/3] xen/vpci: Remove __hwdom_init for vpci_add_handlers
Date: Tue, 19 Oct 2021 11:40:34 +0100
Message-Id: <33b03be7eeea521953790542eb31d5a1386d2b81.1634639117.git.bertrand.marquis@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <cover.1634639117.git.bertrand.marquis@arm.com>
References: <cover.1634639117.git.bertrand.marquis@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

vpci_add_handlers is called on during pci_device_add which can be called
at runtime through hypercall physdev_op.
Remove __hwdom_init as the call is not limited anymore to hardware
domain init.

Fixes: d59168dc05 ("xen/arm: Enable the existing x86 virtual PCI support
for ARM")
Signed-off-by: Bertrand Marquis <bertrand.marquis@arm.com>
---
 xen/drivers/vpci/vpci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/drivers/vpci/vpci.c b/xen/drivers/vpci/vpci.c
index decf7d87a1..74894bcbac 100644
--- a/xen/drivers/vpci/vpci.c
+++ b/xen/drivers/vpci/vpci.c
@@ -54,7 +54,7 @@ void vpci_remove_device(struct pci_dev *pdev)
     pdev->vpci = NULL;
 }
 
-int __hwdom_init vpci_add_handlers(struct pci_dev *pdev)
+int vpci_add_handlers(struct pci_dev *pdev)
 {
     unsigned int i;
     int rc = 0;
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Tue Oct 19 10:41:41 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Oct 2021 10:41:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.212956.371048 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcmYv-00011w-OA; Tue, 19 Oct 2021 10:41:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 212956.371048; Tue, 19 Oct 2021 10:41:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcmYv-00011m-Im; Tue, 19 Oct 2021 10:41:41 +0000
Received: by outflank-mailman (input) for mailman id 212956;
 Tue, 19 Oct 2021 10:41:39 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=XJzt=PH=arm.com=bertrand.marquis@srs-us1.protection.inumbo.net>)
 id 1mcmYt-0008TS-ND
 for xen-devel@lists.xenproject.org; Tue, 19 Oct 2021 10:41:39 +0000
Received: from foss.arm.com (unknown [217.140.110.172])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTP
 id 200a4a94-30c9-11ec-830c-12813bfff9fa;
 Tue, 19 Oct 2021 10:41:32 +0000 (UTC)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 65923D6E;
 Tue, 19 Oct 2021 03:41:32 -0700 (PDT)
Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com
 [10.1.199.62])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C80463F70D;
 Tue, 19 Oct 2021 03:41:30 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 200a4a94-30c9-11ec-830c-12813bfff9fa
From: Bertrand Marquis <bertrand.marquis@arm.com>
To: xen-devel@lists.xenproject.org
Cc: iwj@xenproject.org,
	sstabellini@kernel.org,
	Oleksandr_Andrushchenko@epam.com,
	jbeulich@suse.com,
	Paul Durrant <paul@xen.org>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>
Subject: [PATCH 3/3] xen/pci: Add missing vpci handler cleanup
Date: Tue, 19 Oct 2021 11:40:35 +0100
Message-Id: <77e42e006ec7824e9d531cf488f746c2d7545f08.1634639117.git.bertrand.marquis@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <cover.1634639117.git.bertrand.marquis@arm.com>
References: <cover.1634639117.git.bertrand.marquis@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Add missing vpci handlers cleanup during pci_device_remove and in case
of error with iommu during pci_device_add.

Add empty static inline for vpci_remove_device when CONFIG_VPCI is not
defined.

Fixes: d59168dc05 ("xen/arm: Enable the existing x86 virtual PCI support
for ARM")
Signed-off-by: Bertrand Marquis <bertrand.marquis@arm.com>
---
 xen/drivers/passthrough/pci.c | 2 ++
 xen/include/xen/vpci.h        | 2 ++
 2 files changed, 4 insertions(+)

diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci.c
index d7e09448d1..ddf08a3fae 100644
--- a/xen/drivers/passthrough/pci.c
+++ b/xen/drivers/passthrough/pci.c
@@ -766,6 +766,7 @@ int pci_add_device(u16 seg, u8 bus, u8 devfn,
         ret = iommu_add_device(pdev);
         if ( ret )
         {
+            vpci_remove_device(pdev);
             pdev->domain = NULL;
             goto out;
         }
@@ -813,6 +814,7 @@ int pci_remove_device(u16 seg, u8 bus, u8 devfn)
     list_for_each_entry ( pdev, &pseg->alldevs_list, alldevs_list )
         if ( pdev->bus == bus && pdev->devfn == devfn )
         {
+            vpci_remove_device(pdev);
             pci_cleanup_msi(pdev);
             ret = iommu_remove_device(pdev);
             if ( pdev->domain )
diff --git a/xen/include/xen/vpci.h b/xen/include/xen/vpci.h
index 6746c2589a..9ea66e033f 100644
--- a/xen/include/xen/vpci.h
+++ b/xen/include/xen/vpci.h
@@ -230,6 +230,8 @@ static inline int vpci_add_handlers(struct pci_dev *pdev)
     return 0;
 }
 
+static inline void vpci_remove_device(struct pci_dev *pdev) { }
+
 static inline void vpci_dump_msi(void) { }
 
 static inline uint32_t vpci_read(pci_sbdf_t sbdf, unsigned int reg,
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Tue Oct 19 10:42:16 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Oct 2021 10:42:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.212978.371059 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcmZU-0002It-1c; Tue, 19 Oct 2021 10:42:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 212978.371059; Tue, 19 Oct 2021 10:42:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcmZT-0002Ik-UX; Tue, 19 Oct 2021 10:42:15 +0000
Received: by outflank-mailman (input) for mailman id 212978;
 Tue, 19 Oct 2021 10:42:14 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=eXNP=PH=citrix.com=roger.pau@srs-us1.protection.inumbo.net>)
 id 1mcmZR-0002Gl-Tl
 for xen-devel@lists.xenproject.org; Tue, 19 Oct 2021 10:42:13 +0000
Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 611308a7-bb44-4d75-970e-4a6bd4f7e7bd;
 Tue, 19 Oct 2021 10:42:12 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 611308a7-bb44-4d75-970e-4a6bd4f7e7bd
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1634640132;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=AXneeOTQKsAlTcgPB1kSIh8tax+d8CpOZ0a2tjgH0E8=;
  b=XkBBr+nqs8+aCyr1QlAHoDuRz9d5tWUVf7d4J2BO6cJzfzfpJ2TRTUGI
   s69tGIbO16EB0gWZ8n0bAkjeYOG/BNoZp0VT9sEnpImBKjN7a1GsSl1sw
   nUa/s+BOADkWocUe+wXODCYn9GvWbWw198RqNIUEl5ahx9KsrqUUavN2b
   8=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: Mc2dfLteMG8BdqlyW3WA2KDOrHmOwrxl9v0Q1nXjIYIEyWJkHFMqA52lxxOVCVVJcsia8qA0GD
 +pDo8ozDOk/JYbAdZJyAVLajp7jplJrp70GdB9oBTt/KMYuA8KmM0f36AYQewq1GAucfGQLNbQ
 9PyH4b5dvaMM3sWOi26sTPZlP5oLculR/mf1C9ALOvf5Y8XsaW8ZmuSDJrWcssXvoEmvBWHiOu
 jkG+ynHggfHzigJoZTkt6V8H1Hj5VLJCF5D6T1abrqJR0E49RSuuGvGwQiduHR6UkDqLF21/yU
 gG39LXSbprL/wvc6b+BvNjYD
X-SBRS: 5.1
X-MesageID: 55082217
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:Kd0ekqolastKipLULt9xcZBZMoReBmLMYhIvgKrLsJaIsI4StFCzt
 garIBnQa6veZWChLdp+a9y19RsBsMTczN5jTFZqqC5gFCsapJuZCYyVIHmrMnLJJKUvbq7GA
 +byyDXkBJppJpMJjk71atANlZT4vE2xbuKU5NTsY0idfic5Dnd84f5fs7Rh2Ncx2YHoW1nlV
 e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL
 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9
 DlCnbCQb1xwDJTIpP0iTjtiFjx0G5xc25aSdBBTseTLp6HHW37lwvEoB0AqJ4wIvO1wBAmi9
 9RBdmpLNErawbvrnvTrEYGAhex6RCXvFJkYtXx6iynQEN4tQIzZQrWM7thdtNs1rp0TRaaEP
 ZNGAdZpRAjmTDweNHANNI1kluGTtEPuWRd0r03A8MLb5ECMlVcsgdABKuH9atGMAMlYgEucj
 mbH5HjiRAEXMsSFzjiI+W7qgfXA9Qv5Uo8PELyz9tZxnUaegGcUDXUruUCT+KfjzBTkApQGd
 hJSqnFGQbUOGFKDYvnbBESKmXq4pyEBeeBVDucc2Ruu4/+Bi+qGPVQsQjlEYd0gkcY5Qz02y
 1OE9+/U6SxTXK69Ei3FqO/Fxd+mEW1MdzVaPH5bJecQy4C7+Nlbs/7Zcjp0/EdZZPXOEjbs3
 yvCkiE6g7gC5SLg//TmpQ6Z695AS56gc+LU2uk1dj76hu+aTNT8D2BN1bQ9xawQRGp+ZgLZ1
 EXoY+DEsIgz4WilzURhutklErCz/OqiOzbBm1NpFJRJ323zoCL+LdoOuGsgfRcB3iM4ldnBO
 h+7VeR5v8c7AZdXRfUvP9LZ5zoCnMAM6ugJptiLN4ETM/CdhSeM/T10ZF744oweuBNErE3LA
 r/CKZzEJS9DUcxPlWPqL89Age5D7n1vngv7GMGkpylLJJLDPRZ5v59eawDQBg34hYvZyDjoH
 yF3Z5LblUQPDregCsQVmKZKRW03wbEALcmeg+Rcd/KZIxogH2ckCvTLxqgmdZAjlKNQ/tokN
 FngMqOB4Fag13DBNyuQbXVvNOHmUZpl9CppNi0wJ1e4nXMkZN/3vqsYcpI2e5gh9fBikqEoH
 6VUJZ3YD6QdUCnD9hQccYL58N5oeiO0iF/cJCGiejU+IcJtHlSb5t/+cwLz3yASFS7r59Amq
 rit21qDE5oOTghvFujMb/erww/jtHQRgrsqDUDJPsNSaAPn940zc379ifo+IsctLxTfx2TFi
 1bKUElA/eSU+t076tjEg6yAvryFKeomExoIBXTf4Ja3KTLeojipz7hfXbvaZjvaTm71pvmvP
 L0H0/HmPfQbt19WqI4gQa1zxKcz6taz9b9XygNoQCfCY1ixU+4yJ3CH2Y9Et7FXx68fsgyzA
 xrd9t5fMLSPGcXkDF9Oe1Z1MrXdjakZymvI8PA4AETm/ysmrrOIXHJbMwSIlCEAfqB+N5kow
 Lt5tcMbg+BlZsHG7jpSYvhoylmx
IronPort-HdrOrdr: A9a23:xPtVPa/+FMRHDNZB7Vduk+FLdb1zdoMgy1knxilNoENuHPBwxv
 rAoB1E73PJYVYqOE3Jmbi7Sc+9qFfnhONICO4qTMuftWjdyRGVxeRZjLcKrAeQfhEWmtQtsZ
 uINpIOd+EYbmIK/foSgjPIa+rIqePvmMvD6Ja8vhUdPj2CKZsQlDuRYjzrY3GeLzM2fKbReq
 Dsgfau8FGbCAoqh4mAdzU4dtmGg+eOuIPtYBYACRJiwA6SjQmw4Lq/NxSDxB8RXx5G3L9nqA
 H+4kLEz5Tml8v+5g7X1mfV4ZgTsNz9yuFbDMjJrsQOMD3jhiuheYwkcbyfuzIepv2p9T8R4Z
 bxiiZlG/42x2Laf2mzrxeo8w780Aw243un8lOciWuLm72zeBsKT+56wa5JeBrQ7EQt+Ptm1r
 hQ4m6fv51LSTvdgSXU/bHzJlJXv3vxhUBnvf8YjnRZX4dbQqRWt5Yj8ERcF4pFND7m6bogDP
 JlAKjnlbZrmGuhHjXkV1RUsZiRtixZJGbAfqFCgL3V79FupgE686NCr/Zv2Evp9/oGOtF5Dq
 r/Q/1VfBwndL5gUUtHPpZ1fSKAMB2Fffv9ChPhHb3ZLtByB5vske+83Fxn3pDmRHQ3pKFC7q
 gpFmko7VIPRw==
X-IronPort-AV: E=Sophos;i="5.85,384,1624334400"; 
   d="scan'208";a="55082217"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=CGHVDf5XsFseNvF12fl0q00RvpsXojIRG4J0/YJMVzPA/SSPp0yJpjcd/+JrKYBtOxE4bQkrS68IV551cWCRXiUeJYWQIjbmK0/peNxHYvAGnb8cyF9JOwaxoiZfwo+eY+qVcMQ5ptmDgfKg2cEmdlyw2Gm4TZm2JOU2m1m7gA9ufwdIKuN2dyTkUy1OgNqp/V4gDtEcLjeqzaphnK8dxsLdstyXbC+Z+vQp0lho6OwywvDZOZCQO0PC66nmX3RuA0w69fPkiHso2TqlDFX8pYl8r4sqYhEufWdRjTokiHlZMJ3HklaSO9asDl2keJbRW+TckPFnnHaKuTRhqpNvoA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=OsSP6w4/vLwWBbNDsKZIpXxgQHZkdvA5hsZ6H5bVsxg=;
 b=BM2oS1pEgeUdhJ6hea5y/4XamGRZv2rLftY8PlLLvLVLH20ZijZBC+AjLsgNXRvbReBJszce4tEht4VmlwcjSnTq+iNolFckqR11RtfVaX7ZV9AQ4A6g/jEA5l1DqHoHRxmeSgZBsIhiDS2Z3kOOmK2NvhQt4f3plsnJuf2lvlaCiMKK0EzeytHQtHKuC0mZbNZyogeivW1RjHp+OssbpcSo77x7peh5fHOM1sayWsDvOgxnuzsajI5ltVLoml6r6lVFmK0Sig0SMsm8W7b/V1Ot6uY/3xaTKogBaNfeOdtVPyKf+pBQqf7LNQnbesc4xmzKJpPmCCQnOEVSSdZXcg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=OsSP6w4/vLwWBbNDsKZIpXxgQHZkdvA5hsZ6H5bVsxg=;
 b=e/Gc+XaQ5CsHhwhVwUeWWOlUCbpb+ThJkzxiJCwP9c9OLWuCV7vnmHSuFFepmw0M7kvAeChX3N/gPKeUMfcf7Z3JTfczj4jPmxeW6W6RketufJFupMCNWkV657/VU75WpXRvvDCCDngisOTWkTV3vEQpH0FcWeXGhLGfcW3li+w=
Date: Tue, 19 Oct 2021 12:41:59 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Andrew
 Cooper <andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>
Subject: Re: [PATCH] x86/PoD: defer nested P2M flushes
Message-ID: <YW6g9w9XeWKsxYMV@MacBook-Air-de-Roger.local>
References: <e47d51c6-1b4b-2f72-6e12-070df66c30e2@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <e47d51c6-1b4b-2f72-6e12-070df66c30e2@suse.com>
X-ClientProxiedBy: LO2P265CA0464.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:a2::20) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 734e534e-db51-4d7b-bd9b-08d992ed170d
X-MS-TrafficTypeDiagnostic: DM4PR03MB6062:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <DM4PR03MB60621A6DA3D15641703C54E48FBD9@DM4PR03MB6062.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:5236;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: ejs1Vl9uj3wnsX2eqVgEGOs02xSvO+EvnLIcNdclAs8XHi7FpaG9VLYgas2gXlagcTVP2P3xxD9Lr2YAKc7Mj4ZroCYpX84/Anz4yzcyXeMHKRwDcQg0vRAUjioLnaa17DXqj6CUYUDjfwgAuzW/RV2l0lsFhfwYRYjpEe8CRB2TAYmKS8AUZetji6123p7CBribhQsn8/Wxe8dSzyZAwvKFOjlMu3h2vFLaiuaAShS5RP5570b+7xKMdvE7Od6mZQzSq2U9Qlv2ZkMEJ1Vcaou+EyazJUDFFOAXln5A7h1KqUjDtBfiEnb0z4EBMf9lHQTZoi6dG+QbmXKGsCr0oZBBPs5WxEwukMiC+nfaPlwB56yNGRfHGpjnZ/Wl7fpMwKQq6dOrQbr9yncOV+BZZQ+hg0k2puoGi8F2pLOpBBo4Up3nNsjtvr1v+TY/qcDKqqleXWEfhgS1QzSaqPnp77jg/Pr+05Firw/socn6QEwy5hOMhsVRTGjtsE3ord7hkIVNHcS1AwwmvcRLdOVQpdoirgDIycBgDUAvAi++TpUTfYDynKGPRe1Zve54dxaQ4y5YqDkh99N1bjl/LeLCD0ih6SjYunf2gjKtuPQ/jEG/S2HCwYinbDr/K6+I+ypNZOA6vueI45S73rZb3lqYJg==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(8676002)(66556008)(85182001)(83380400001)(66946007)(316002)(86362001)(26005)(508600001)(38100700002)(956004)(8936002)(186003)(54906003)(6916009)(66476007)(6496006)(107886003)(4326008)(6666004)(4744005)(5660300002)(2906002)(9686003)(82960400001)(6486002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YnZwSENVS0t5K2xSbGR1SFBRVG55amdhTENJQ2lTQnFITWtVOUtJQUpCSHBW?=
 =?utf-8?B?ckU5bGttNTZTTjFFaVltRGkzZ1drUXArUHBIYnp2WEluWHdKRkRMN0VlUmlZ?=
 =?utf-8?B?L1pxUWhLNXp0OS8yOEt2UUJacWV6RkY4ekpQKytST2pWSXFYY3pZc2pEd2g4?=
 =?utf-8?B?QjBVVEl2SElxQ1ExTzRlb1J6MWRVd244YWJMSFVST05udDZzMVhKMjZtYTQz?=
 =?utf-8?B?RGM5UXpwbVBOTUZlTGpaVTB1LzhtVEE0b1ROVWlGb3pMc01LSkVwWXBYbXE0?=
 =?utf-8?B?RFpxbkhQVlZGRmJKS3VwMTRQSm9UNmovU3g3d1BzUEVKQlNCM0hOQlJYcm1l?=
 =?utf-8?B?QVNEV0JhVzl3QnMvdy9YemtrWm5oSlRSbDlnRzFSaUoxc3U3VXNERXRUQ0Ev?=
 =?utf-8?B?TkZCaVhNOCtjeE0rVmRwSjBwTkVSOXczSDVNb0d0VmtHemZIcnBvUXJHSlBh?=
 =?utf-8?B?WlBJaWEzWTI2d1hUMXVHSHhiRmhOVUFHWFNUaUxDTkkrMkh5UG94bEpzREtk?=
 =?utf-8?B?M1J1WGJVeTFIMVRtVnpYb01uWHdkUGhSVEt5clhzVkt3bThONzBJYTlndzRD?=
 =?utf-8?B?cWRxT0thYlZDd09Dend6TzE1RUxqNmhpV2haM29mbGxQbGt2dEtLRGdHdk1h?=
 =?utf-8?B?dWx6MDlkKzhoaGc4dXJ3T1h0eG9NeFczNHVXOXZjVXQ3d3lhaHNYTXY0bHJT?=
 =?utf-8?B?aE1yRFdNZ0ZVNGRxUWRFcExBYytELzFNbjFpRTNRUG42SjJyZUpaazQ2L1ZO?=
 =?utf-8?B?SUtiUnlNRmRrcTNNNVZTVGFIakNqY3dnSzBLbFpyZ1oxZ2pvTzh0S29jUkNl?=
 =?utf-8?B?WitwTXVXdVQ2SGJXVDFnZ2VqTzZxRG5UL3djNE51K3M1TFdZa01FcnZGZ1Jv?=
 =?utf-8?B?aHhZR2Y4K0VRM0F2YTRFMlRETFNYYUhPMXZ4TmZjRGJJdHROT0ZaZi9uVmx1?=
 =?utf-8?B?M01GeXJZRkVTSE9mdVNKNldpSEZSc2hNWnlzbXl6V1Vsdk5nWkpyc2YxcFFo?=
 =?utf-8?B?NUpmMm41M0FhM0pxMGtodFo5dDZuYlFCUUk3RXpWd09lYUFIeVoyekxEMVZu?=
 =?utf-8?B?Z1R5TXM0dlFhQSs2ZWtmcDRJQ3BwZUdhVTBteUtDVWxmVTZXcFRHNVdxNUZL?=
 =?utf-8?B?bEw3VFJzNkp3elNpQU43b0tkT1gxZ0dkaDhUNG81YWdxVmZLWmVKOXZtZU1s?=
 =?utf-8?B?Y3N2eVpiQzNzajgyNTlDa3VJelIxdVR0YngrL2prMUNRZjZ0UTFLZWN3VVZi?=
 =?utf-8?B?VFQ3SUdjYlBPQWlWekFkcTRXUUxhaDBLbmNmV1gwaXNPYi9oUzNOanhVZmx4?=
 =?utf-8?B?a1VIVmNLSkMycm01NUhXbTdXNTdZUHhYdWdZV2JHWlIrblRyTXVTMG1lcVBT?=
 =?utf-8?B?Z0Zjai9PVEVoaUs5TDZDWWhsTmlHdVJERFRrWDh5Uy9RWjVxR3FqbnVqOVAy?=
 =?utf-8?B?TnQrVDFQMG1VUG1FM08xMzRGVEpoS25ndEx4bFV2Q3JTaWYvM2lvUFlBVjl2?=
 =?utf-8?B?QnR2YjRWeTByU1FOVXp5Vk9hQ2ZEYzF0dXVsUmhPT0JGdEwvOVVUZUc0aDZl?=
 =?utf-8?B?eFFQSGViMzdISWdKWkJSOVByMHBOVTlDanNMOG96R3BoS0p2cjNHRW04bXpo?=
 =?utf-8?B?S29Oc3kyUSt6S3BKcndNNTZQRC92Y05MK0lZQS9ieVUrdVNRT2pLeDJnK1hH?=
 =?utf-8?B?RG1tcEZtYU1wWlFmMHRuMHc0cjRhZmRSWE1wZHZvaUU4VGkyeXR0RXJIbTND?=
 =?utf-8?Q?kctYCH5Wn98aMeW+L2g3Ehqa290sVclrMooVyy8?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 734e534e-db51-4d7b-bd9b-08d992ed170d
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2021 10:42:04.2362
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: QxcEeZ/yQkxL7AbgXfuRmN+DaglKsS63eNrDWJxpZEaHwk/B8T2EWUP7zebbo/QCtWL0RnWMH1z+IjheH7TLoA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR03MB6062
X-OriginatorOrg: citrix.com

On Mon, Oct 11, 2021 at 10:17:08AM +0200, Jan Beulich wrote:
> With NPT or shadow in use, the p2m_set_entry() -> p2m_pt_set_entry() ->
> write_p2m_entry() -> p2m_flush_nestedp2m() call sequence triggers a lock
> order violation when the PoD lock is held around it. Hence such flushing
> needs to be deferred. Steal the approach from p2m_change_type_range().
> 
> Similarly for EPT I think ept_set_entry() -> ept_sync_domain() ->
> ept_sync_domain_prepare() -> p2m_flush_nestedp2m() is affected.

I'm slightly worried by this path because it doesn't seem to
acknowledge defer_nested_flush. Maybe the flag should be checked by
p2m_flush_nestedp2m instead of leaving it to the callers?

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Tue Oct 19 10:50:37 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Oct 2021 10:50:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.212995.371070 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcmhV-00040L-2B; Tue, 19 Oct 2021 10:50:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 212995.371070; Tue, 19 Oct 2021 10:50:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcmhU-00040E-VG; Tue, 19 Oct 2021 10:50:32 +0000
Received: by outflank-mailman (input) for mailman id 212995;
 Tue, 19 Oct 2021 10:50:32 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=gzZp=PH=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mcmhU-000408-1c
 for xen-devel@lists.xenproject.org; Tue, 19 Oct 2021 10:50:32 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 6087f6f6-30ca-11ec-830d-12813bfff9fa;
 Tue, 19 Oct 2021 10:50:31 +0000 (UTC)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2111.outbound.protection.outlook.com [104.47.17.111])
 (Using TLS) by relay.mimecast.com with ESMTP id
 de-mta-38-LWstARwuOue7yXa2vh4VfQ-1; Tue, 19 Oct 2021 12:50:29 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VE1PR04MB6477.eurprd04.prod.outlook.com (2603:10a6:803:11e::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.17; Tue, 19 Oct
 2021 10:50:26 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.018; Tue, 19 Oct 2021
 10:50:26 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6P195CA0045.EURP195.PROD.OUTLOOK.COM (2603:10a6:209:87::22) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.15 via Frontend Transport; Tue, 19 Oct 2021 10:50:26 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6087f6f6-30ca-11ec-830d-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634640630;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=jMBYjnG5XxXn01qbgnb576KAXNzQ7k29DDTMWTn3wFo=;
	b=eoVpWWkrEfakHPpZESTZNEpn3QF0VJqrq9UCWCe6YZAs3/yUGyxeWABiU2zEnQ9pzw6ldD
	ImGWZKhzrv49vGBfGhzKWxFWXJHuGz6td6iMUnRok5Oo5k5pfvbLpN8KDMc/fNe9CHAbZE
	m0zdHGIN8Sqghhr8Q7lbH92pZ+jY21M=
X-MC-Unique: LWstARwuOue7yXa2vh4VfQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=j4ROPjMjblziqLt4GIbz0h7jI5cc2+qJDmFPHPdFSxFSpAwMBZ/kUCX4M4lIJWSviokGZxG+HRnVorCTfvnCwTpIeyj6VM5OW3b2riL6RlvLgp8Hso5AzdHtmOs2uMFew6QGFHgZzzb90GoOq+57g7VlsOKyhGN5UdqKSne7Tvuq2/hQ+PIwWHm41VKMWjrrIi2rOcyoJnxtvwIIOXO0PNU/nt6gNM4LFsNOoZwia5Y8eHDEzRFvcJcILs+LCAay1NlCnCdxNzv7EV2o+bi+saPUhQ8tRuVMaEql6C4SuC9AMAnLJdiSOVibB0776bZauwSx3kayXTeVekwf6HIZGg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=PdSCyaJ77SNV6Fu86xcQ6jM8t+zvodwnQIieN78m3So=;
 b=ao0Yg6fYh48iYUbCHy8ASnJdrLJHxFFbJ2BshbwWyp29Fb7rj54YxR3R3XJB2Tv4O7V/+BSOF6wZWe3D64KCGStdktBeY9vtsucqh32KpAO5OSXWaO5OxgWu36vuxTPQpiX5vjU1Wc+NcAFthAoIh0WUFN4OIFYZUQe5rYooGEQWsLxlLXkPCnRr86966NBT10x3H6/bUdhS+d9hm4uTGyh6QvIQL0r6P4MdcqD056NO5S6Km+IUpBsiLYsR51wsZXMqOM052CRTbpZXoI+2/4mlYVkOQwD7c7g4Zj9rjIGRatrH1kqlmjtsxRDY9UYI8P5yEI60AZmpof1Gb9kTIQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: citrix.com; dkim=none (message not signed)
 header.d=none;citrix.com; dmarc=none action=none header.from=suse.com;
Subject: Re: [PATCH] x86/PoD: defer nested P2M flushes
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>
References: <e47d51c6-1b4b-2f72-6e12-070df66c30e2@suse.com>
 <YW59OUi9tpnGccl7@MacBook-Air-de-Roger.local>
 <fc543483-bc67-1323-6db1-b335bbdc4238@suse.com>
 <65a88325-909a-7995-4ded-c9d77b386129@suse.com>
 <YW6gR6L0UkCm97aM@MacBook-Air-de-Roger.local>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <e8f17af0-1a06-f685-bae6-6c2bef9be39e@suse.com>
Date: Tue, 19 Oct 2021 12:50:24 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <YW6gR6L0UkCm97aM@MacBook-Air-de-Roger.local>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6P195CA0045.EURP195.PROD.OUTLOOK.COM
 (2603:10a6:209:87::22) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 91ca5604-3c9e-4f15-6b7e-08d992ee4277
X-MS-TrafficTypeDiagnostic: VE1PR04MB6477:
X-Microsoft-Antispam-PRVS:
	<VE1PR04MB6477AA59CACB59047BAD9CE6B3BD9@VE1PR04MB6477.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8273;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	fBq4pLzeurDoVZIxvQIodI02Fd16KXv6WZ+X6ajYPaHBllvwBwN6EUh7JHEhXq2i+WyFLs+EyPiglCfGD8brPUE06TZyXwhOg8Wjp5t9p7mqPpju3BonSvRYSHKGCiC9ibCEiWNmpGV6eS9Lt9J5gkFGu0heOHa03/KCUL4m2lZaK9BdmkbGfKhNvsI0MuNpSDsDN3IDt+qxTr4CCLz7O3sxUlCntVmE69JOopEq0OG5RLZpU8B9vqtv1/QKFqX9BdGvGG55M9vWJpnnk+8xi2+F/8fMfqRIr48GTaOpbLZHMaYC187uYdh0xtEPZSc9VL6uYS5+Ga38eH9rmyVvYsH8A7gNpRXkL9BZy6/voI9vzgsYyCl+3Gbfrp95+kfDRjZ/NNtNrTItCqTjFo72E0vVW/I8qZQ/Fv8LR6GSbIYf42GkkO5EXxrtWONuz+oX5kdkX8bwxPbHJDGdEFyveuaq5jyZnRePDwI73WgjFziHV+A0mw8zUAbQj5/wvuRghuySZWe0rjSZJauL7EX1SBIDNx51272oVyztnrzNipH4F+P+z/s8aKi0Bh2lP6nvcYTEY5/lM4uFuDy77NYgdkxSVUgpsHFT7md6P7A2ndQoUXouV5U4t7O7RFmYHjgbD/ltTGWkyBDtf5HXWY4pTlIpipNMtvR7J6M2YlnwU1a07OLMszNpUA06wkzKZEF0SUKdF3AVEDUOwqwtLB7qgyMeEoZgCcYihpSRrsgR+7o=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(36756003)(2906002)(54906003)(16576012)(316002)(4326008)(956004)(31686004)(53546011)(508600001)(8676002)(2616005)(86362001)(66556008)(66476007)(66946007)(83380400001)(186003)(31696002)(6486002)(38100700002)(26005)(8936002)(5660300002)(6916009)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?jbVb5ELMDjk2LK2RXzVAi5WGdtaVexMkIefL3nvpyxJ7rmJDoWvQSYyHWJcA?=
 =?us-ascii?Q?lsuPycYT3BhifT6SXmTiHR4isi+m2gA6MX13wNFibGJcmgT8488cWzcmx37I?=
 =?us-ascii?Q?rT9iPn8dG8NggpnnKEi1BFXNnc0I8sM9qMJR5kTyWzXEqmyoiPZe64C5V9Z4?=
 =?us-ascii?Q?ePS3+TgNnszjgJ+zyWFwFl9c+bvAnKryBrvTRIfJ1jV1/H1HxDnoSvPx5mTw?=
 =?us-ascii?Q?QZimofnCGVSZOiVttDNrQS2kMeS+cglo4R47kVzadDY1ZcIVxiMD0WgiJe65?=
 =?us-ascii?Q?XxJYi8IJdgvuRfE0hfJHcIEabV4F+bIny/5KOCDr40rRqWXoRelzOAvwcQkK?=
 =?us-ascii?Q?/+qcuaCkVGV5Zi5s/lemlev5+wrUKqgkJb9WIMlrrpJy3A5yv08OARgwoPvx?=
 =?us-ascii?Q?WiFP+7KQcCrjsdDeN/ZtBA8O9wpfiHgA1Hmka/rUBPAUxad5S5ApNMS3A/6q?=
 =?us-ascii?Q?7h20/PhxS37So3C1XTu7ROwLev/Ero4wr+qTX7V1AthEDoc925QRnaWAcFb0?=
 =?us-ascii?Q?TExNu1TyBjQCiKzL5JSL1G1U+z6WJrFEsbAHnoeJDCEG/aW5icgx+Dn/tlIa?=
 =?us-ascii?Q?JzAV4fuIicPJLvjd0s3ildlgSiofQ6LMctM9E0UJBbvoE1Fx7skR/uhhHygt?=
 =?us-ascii?Q?aptb8H7iHjmnUrnm5DRzHMjb0WZHKRQej77CVFNyAYXfFiRjiYMVWwcIWRX/?=
 =?us-ascii?Q?Cr6Oa69++3Vmu1JOcfKxQTkvi+PZslBgB6zssAshZuSHPq+obJn9VMkXqUTK?=
 =?us-ascii?Q?xsayv0VmDTwJHmgm4FJB5UJLcW6pRRCDcq4O+r48OrDn67lMgYzECLfk6C7p?=
 =?us-ascii?Q?/WA+r8KWUEoJ3Tuu4l4GIHufE0dBdrKfskpBQblOLF6yiFeAEy+CSn2OLza3?=
 =?us-ascii?Q?e1xXYkU3JJw364wSYVAZqhSbtYoLSdtNeHoJxfW5NA3DUn2qD5+CwM1XMrsI?=
 =?us-ascii?Q?sd6+Whg5m18L428dc1S+khm4CyVhr/xfYz5rSjNyh+8SkEqU8+CT/czWE3vJ?=
 =?us-ascii?Q?ua9pXY/rik96FDGcLWBxPyjuQ8mp8cwL0Xa+OuC/Tv1b9buZK1j54dbq+r6y?=
 =?us-ascii?Q?6iVwhPFg1yw8aBejKu5JPTZjumGM4Z8hpdDGq/FTW1TzRP48wO9mt+zeY5ZW?=
 =?us-ascii?Q?p/wj0GKme6Wu7NpRAjku7p9VzssMqkGmi7OOXmFU7/jZG6PCBmuR6PsPpK5B?=
 =?us-ascii?Q?XR82ax5dTlIMtURKx3Or0MFj4K5eKB8TU5I8RUaXPo8Pa9wgPjOtyDcq7NK5?=
 =?us-ascii?Q?gB/5RcOY2yPKetJQPGgz/Wvh1bdxo9PAyDH0ZZ/nIn608C4gic2dG0CTKq5j?=
 =?us-ascii?Q?oiz1wAAxArX5gMDPFDdFGvTR?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 91ca5604-3c9e-4f15-6b7e-08d992ee4277
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2021 10:50:26.5579
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: UUPgl7JmgeDtcLPAOFgjno8ZmEhgNEOTnb9zPi9ZFYwRx95lDiobSQPVj44psMw2wdE4m2PEeFKR+tORaeAlrw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6477

On 19.10.2021 12:39, Roger Pau Monn=C3=A9 wrote:
> On Tue, Oct 19, 2021 at 10:19:57AM +0200, Jan Beulich wrote:
>> On 19.10.2021 10:17, Jan Beulich wrote:
>>> On 19.10.2021 10:09, Roger Pau Monn=C3=A9 wrote:
>>>> On Mon, Oct 11, 2021 at 10:17:08AM +0200, Jan Beulich wrote:
>>>>> @@ -1229,8 +1242,9 @@ p2m_pod_demand_populate(struct p2m_domai
>>>>>          __trace_var(TRC_MEM_POD_POPULATE, 0, sizeof(t), &t);
>>>>>      }
>>>>> =20
>>>>> -    pod_unlock(p2m);
>>>>> +    pod_unlock_and_flush(p2m);
>>>>>      return true;
>>>>> +
>>>>>  out_of_memory:
>>>>>      pod_unlock(p2m);
>>>>
>>>> Don't you need to set defer_nested_flush =3D false in the out_of_memor=
y
>>>> label? (as you don't call pod_unlock_and_flush that would do it)
>>>
>>> Yes of course - thanks for spotting. I had pod_unlock_and_flush() here
>>> too initially, and when switching back I forgot to convert rather than
>>> just delete that.
>>
>> Oh, wait, that was on purpose: There's no point clearing the flag
>> when the next thing we do is invoke domain_crash(). If it wasn't
>> that way, I don't think I could avoid using pod_unlock_and_flush()
>> here as well.
>=20
> Oh, I see. We would need to be careful if that domain crash is ever
> removed.

Well, I can change the call there as well. Doing so would seem preferable
over adding a respective comment there. I didn't do so originally because
as it stands this would be meaningless code churn. Let me know what you
think.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Oct 19 11:05:10 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Oct 2021 11:05:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.213002.371081 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcmvX-0005XR-BD; Tue, 19 Oct 2021 11:05:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 213002.371081; Tue, 19 Oct 2021 11:05:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcmvX-0005XK-7x; Tue, 19 Oct 2021 11:05:03 +0000
Received: by outflank-mailman (input) for mailman id 213002;
 Tue, 19 Oct 2021 11:05:01 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mcmvV-0005XE-KW
 for xen-devel@lists.xenproject.org; Tue, 19 Oct 2021 11:05:01 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mcmvV-0008AP-Iv
 for xen-devel@lists.xenproject.org; Tue, 19 Oct 2021 11:05:01 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mcmvV-0004qB-Hn
 for xen-devel@lists.xenproject.org; Tue, 19 Oct 2021 11:05:01 +0000
Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89)
 (envelope-from <iwj@xenproject.org>)
 id 1mcmvP-0000FM-0D; Tue, 19 Oct 2021 12:04:55 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date
	:Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From;
	bh=nnb2geRbcbSlLgx5UdzGDOidH9vfIgTEmDTEzYRrLh4=; b=bFWHsskyJYCiklS6BHMq8i+lxK
	s1HwetjJbecHc0QGHkoHb1hhkTRuTY9wUek4kvIdUP4IOMVG8vd6ShWmUzOzmhlIWo/6E5pXnfUFi
	Q1/st3Bp6SBkw2qNUN5FiKlIUNpm2gSOqrBgbsZubGkT93N0Y5sc0NvSUm3Tx0ozo3AQ=;
From: Ian Jackson <iwj@xenproject.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <24942.42582.584340.453247@mariner.uk.xensource.com>
Date: Tue, 19 Oct 2021 12:04:54 +0100
To: Jan Beulich <jbeulich@suse.com>
Cc: Juergen Gross <jgross@suse.com>,
    Wei Liu <wl@xen.org>,
    xen-devel@lists.xenproject.org
Subject: Re: [PATCH] tools: fix oom setting of xenstored
In-Reply-To: <912b03a3-90df-e94e-77a9-5c673acfef04@suse.com>
References: <20211019044123.29648-1-jgross@suse.com>
	<0c93abe3-3908-009f-efca-08000092cd4d@suse.com>
	<c486ebb9-7cda-da67-7122-bceb291805b3@suse.com>
	<912b03a3-90df-e94e-77a9-5c673acfef04@suse.com>
X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu)

Jan Beulich writes ("Re: [PATCH] tools: fix oom setting of xenstored"):
> On 19.10.2021 09:31, Juergen Gross wrote:
> > I don't think set -e would have a negative effect on above line. The
> > bash man-page tells me that:
> > 
> >    The shell does not exit if the command that fails is part of the
> >    command list immediately following a while or until keyword, part of
> >    the test following the if, ...
> > 
> > And I believe that "[ ... ]" is treated like an "if".
> 
> I don't think so - "[ ... ]" is an equivalent of "test ...", i.e.
> unrelated to whether that's an operand of "if". The question is
> what effect && has, i.e. the behavior is due to what you've
> hidden by using ... in your quotation: "..., and is not a part of
> an AND or OR list, ...".

"[ ... ]" is precisely equivalent to "test ...".  But neither of these
is eqivalent to an "if".  When the docs say "part of the test
following the if" they are using the word "test" informally.

> I think I recall constructs like the one you use not working with
> "set -e" on at least some bash versions, though. Apparently this
> was due to a bash bug then (or I'm misremembering, but that's not
> overly likely since some of my long used scripts specifically
> avoid using && in such situations).

I agree that we should avoid this && construct.  Can we not just use
conditional assignment of a default value or an if statement ?

> >    ( set -e; [ -z "" ] && xx=okay; echo $xx; )
> > 
> > This will print "okay", so bash didn't exit.
> 
> Of course, because the left side of && succeeds. You'd need
> 
>    ( set -e; [ -z "xxx" ] && xx=okay; echo xx=$xx; )
> 
> and observe "xx=" getting printed. Which indeed I do observe on
> the one bash version I've tried to double check. But that one's
> surely newer than what I think I saw such problems on.

I think this particular && and || usage is not an idiomatic way of
spelling what would normally be a conditional in shell.

I think
  try_this || try_that
is fine but
  variable_nonempty || variable=value
is strange.

I would use ${param:=default_setting} or ${param:-default}
(or perhaps the colon-less variants).

Ian.


From xen-devel-bounces@lists.xenproject.org Tue Oct 19 11:07:16 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Oct 2021 11:07:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.213011.371092 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcmxf-0006A6-NI; Tue, 19 Oct 2021 11:07:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 213011.371092; Tue, 19 Oct 2021 11:07:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcmxf-00069z-K6; Tue, 19 Oct 2021 11:07:15 +0000
Received: by outflank-mailman (input) for mailman id 213011;
 Tue, 19 Oct 2021 11:07:13 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mcmxd-00069p-TP; Tue, 19 Oct 2021 11:07:13 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mcmxd-0008DR-QA; Tue, 19 Oct 2021 11:07:13 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mcmxd-0000Gv-G8; Tue, 19 Oct 2021 11:07:13 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mcmxd-0003HX-Fd; Tue, 19 Oct 2021 11:07:13 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=1rY2b755Vwr/ziBY6G4BNPYDvcmN6ljayQ5l790Aa7k=; b=JigZ1xzpUS+Y5PAwsB9hC6AWXp
	47W91zwXgCJ5XwX1KWBAptX29frWZm8JnzxYMlZwclwNNmtqotPWGUStdJjbdTq68ng8uf9z7mAXQ
	Rsx884U13FAp76stvlS5VpFOuUHp1BXbDwNDTpaJPFWKCv7rrChShJIquNYYJzje67F8=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165657-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 165657: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=91a978ce7e0c7a327cff1d9411b0e1c9dae8824a
X-Osstest-Versions-That:
    ovmf=36b561623a4b8a6c7fea0b1b01f6789f2adf97e0
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 19 Oct 2021 11:07:13 +0000

flight 165657 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165657/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 91a978ce7e0c7a327cff1d9411b0e1c9dae8824a
baseline version:
 ovmf                 36b561623a4b8a6c7fea0b1b01f6789f2adf97e0

Last test of basis   165652  2021-10-19 01:40:11 Z    0 days
Testing same since   165657  2021-10-19 04:10:05 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Guo Dong <guo.dong@intel.com>
  Moritz Fischer <moritzf@google.com>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   36b561623a..91a978ce7e  91a978ce7e0c7a327cff1d9411b0e1c9dae8824a -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Tue Oct 19 11:12:38 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Oct 2021 11:12:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.213020.371106 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcn2o-0007b2-CX; Tue, 19 Oct 2021 11:12:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 213020.371106; Tue, 19 Oct 2021 11:12:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcn2o-0007av-85; Tue, 19 Oct 2021 11:12:34 +0000
Received: by outflank-mailman (input) for mailman id 213020;
 Tue, 19 Oct 2021 11:12:32 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mcn2m-0007ap-J7
 for xen-devel@lists.xenproject.org; Tue, 19 Oct 2021 11:12:32 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mcn2m-0008Jh-E7
 for xen-devel@lists.xenproject.org; Tue, 19 Oct 2021 11:12:32 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mcn2m-0005h6-Cy
 for xen-devel@lists.xenproject.org; Tue, 19 Oct 2021 11:12:32 +0000
Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89)
 (envelope-from <iwj@xenproject.org>)
 id 1mcn2h-0000HA-5X; Tue, 19 Oct 2021 12:12:27 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date
	:Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From;
	bh=LUe2Ak75LytPlP8rpM0g533w8devNdiFA5X4cNaR5GA=; b=48SzX5AzfpOAH6b2zo7LvmhI0Q
	MjpDK/BnIaGHDIkmPsosXbdbA9UPiIITrhw6Na+eKTSczhPDhHJLS+cc++YTizyzoXH2xtWdhbUwk
	VZXcexk8jCnK1VsQIOOwOOG+ziL6U2Y6AA+/2s7k8URH9mftMQolk2cM2QdtLuzhjiss=;
From: Ian Jackson <iwj@xenproject.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <24942.43034.758402.850001@mariner.uk.xensource.com>
Date: Tue, 19 Oct 2021 12:12:26 +0100
To: jbeulich@suse.com,
    Roger Pau =?iso-8859-1?Q?Monn=E9?= <roger.pau@citrix.com>
Cc: xen-devel@lists.xenproject.org,
    Bertrand Marquis <bertrand.marquis@arm.com>,
    sstabellini@kernel.org,
    Oleksandr_Andrushchenko@epam.com,
    Paul Durrant <paul@xen.org>
Subject: Re: [PATCH 0/3] Fixes: PCI devices passthrough on Arm
In-Reply-To: <cover.1634639117.git.bertrand.marquis@arm.com>
References: <cover.1634639117.git.bertrand.marquis@arm.com>
X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu)

Bertrand Marquis writes ("[PATCH 0/3] Fixes: PCI devices passthrough on Arm"):
> This patch serie is a follow-up after various findings on d59168dc05
> ("xen/arm: Enable the existing x86 virtual PCI support for ARM") as of
> agreed in [1].
> 
> It does the following:
> - enable vpci_add_handlers on x86 and not only on arm
> - remove __hwdom_init flag for vpci_add_handlers
> - add missing vpci handler cleanup in error path during pci_device_add
>   and pci_device_remove

Thanks.  Roger, Jan, what do you think of this ?

I have no qualms from my RM POV other than that I want a fix
resolves the concenrs previously expressed by maintainers.

Thanks,
Ian.


From xen-devel-bounces@lists.xenproject.org Tue Oct 19 11:22:00 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Oct 2021 11:22:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.213028.371117 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcnBh-0000dU-86; Tue, 19 Oct 2021 11:21:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 213028.371117; Tue, 19 Oct 2021 11:21:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcnBh-0000dN-4q; Tue, 19 Oct 2021 11:21:45 +0000
Received: by outflank-mailman (input) for mailman id 213028;
 Tue, 19 Oct 2021 11:21:44 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=d5uN=PH=suse.com=jgross@srs-us1.protection.inumbo.net>)
 id 1mcnBg-0000dH-HC
 for xen-devel@lists.xenproject.org; Tue, 19 Oct 2021 11:21:44 +0000
Received: from smtp-out1.suse.de (unknown [195.135.220.28])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id ec1c0218-679b-49d5-b6c0-69dc2d4f7723;
 Tue, 19 Oct 2021 11:21:43 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 9251621A5D;
 Tue, 19 Oct 2021 11:21:42 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 6F0AD13B64;
 Tue, 19 Oct 2021 11:21:42 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id obzHGUaqbmHvbAAAMHmgww
 (envelope-from <jgross@suse.com>); Tue, 19 Oct 2021 11:21:42 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ec1c0218-679b-49d5-b6c0-69dc2d4f7723
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1634642502; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:  content-transfer-encoding:content-transfer-encoding;
	bh=Bsjm34oU7y3pSkCQQqWxgmwlC+hZeXr6taiQjgu1WUA=;
	b=J8GtlNiEgia7Z5PVFRhYonYLv4mz4AuqppfaXY5AX71VWg5A77IlAQGqvTzQaRF9S7EOFZ
	AR+zGxCSp/rKKPTktAUujF4HZoRtpaB7cAVMR+1LzludHraZp7XWQdByiukHu6jkRRVy5/
	5ki32Y+OGNIBdeq1IfnXFk6n7LGFsNM=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org
Cc: Juergen Gross <jgross@suse.com>,
	Ian Jackson <iwj@xenproject.org>,
	Wei Liu <wl@xen.org>
Subject: [PATCH v2] tools: fix oom setting of xenstored
Date: Tue, 19 Oct 2021 13:21:40 +0200
Message-Id: <20211019112140.26988-1-jgross@suse.com>
X-Mailer: git-send-email 2.26.2
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Commit f282182af32939 ("tools/xenstore: set oom score for xenstore
daemon on Linux") introduced a regression when not setting the oom
value in the xencommons file. Fix that.

Fixes: f282182af32939 ("tools/xenstore: set oom score for xenstore daemon on Linux")
Signed-off-by: Juergen Gross <jgross@suse.com>
---
V2: use ${var:-} (Jan Beulich)
---
 tools/hotplug/Linux/launch-xenstore.in | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/tools/hotplug/Linux/launch-xenstore.in b/tools/hotplug/Linux/launch-xenstore.in
index 8438af9977..e854ca1eb8 100644
--- a/tools/hotplug/Linux/launch-xenstore.in
+++ b/tools/hotplug/Linux/launch-xenstore.in
@@ -60,8 +60,7 @@ test -f @CONFIG_DIR@/@CONFIG_LEAF_DIR@/xencommons && . @CONFIG_DIR@/@CONFIG_LEAF
 		echo "No xenstored found"
 		exit 1
 	}
-	[ -z "$XENSTORED_OOM_MEM_THRESHOLD" ] || XENSTORED_OOM_MEM_THRESHOLD=50
-	XS_OOM_SCORE=-$(($XENSTORED_OOM_MEM_THRESHOLD * 10))
+	XS_OOM_SCORE=-$((${XENSTORED_OOM_MEM_THRESHOLD:-50} * 10))
 
 	[ "$XENSTORED_MAX_OPEN_FDS" = "unlimited" ] || {
 		[ -z "${XENSTORED_MAX_OPEN_FDS//[0-9]}" ] &&
-- 
2.26.2



From xen-devel-bounces@lists.xenproject.org Tue Oct 19 11:24:23 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Oct 2021 11:24:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.213036.371131 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcnEE-0001GF-Pc; Tue, 19 Oct 2021 11:24:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 213036.371131; Tue, 19 Oct 2021 11:24:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcnEE-0001G8-L2; Tue, 19 Oct 2021 11:24:22 +0000
Received: by outflank-mailman (input) for mailman id 213036;
 Tue, 19 Oct 2021 11:24:21 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mcnED-0001G0-DS
 for xen-devel@lists.xenproject.org; Tue, 19 Oct 2021 11:24:21 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mcnED-00004q-Cj
 for xen-devel@lists.xenproject.org; Tue, 19 Oct 2021 11:24:21 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mcnED-0006bI-Bd
 for xen-devel@lists.xenproject.org; Tue, 19 Oct 2021 11:24:21 +0000
Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89)
 (envelope-from <iwj@xenproject.org>)
 id 1mcnE9-0000Jo-TR; Tue, 19 Oct 2021 12:24:17 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date
	:Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From;
	bh=uhclx5EtyiFhHum1k4PTCfxl6fWsmasFCb3BWZuVQwY=; b=suhjN5xBv/f6m39KebFXkoYaP6
	qog2jyAOusyr9wPZSdXf/0tNbOOn6i4HGTu7yl1MQFiR91QgqLyt2tkp4UpQPtlP4ctqfybCFit4/
	9n5E0J08v/EeLgCgI7MiqBJWv4AZvp6Ud7Z6s+sjKvAIJBfXmRW9C8BaCt+y9xmq+0Bg=;
From: Ian Jackson <iwj@xenproject.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <24942.43745.600566.92584@mariner.uk.xensource.com>
Date: Tue, 19 Oct 2021 12:24:17 +0100
To: Juergen Gross <jgross@suse.com>
Cc: xen-devel@lists.xenproject.org,
    Wei Liu <wl@xen.org>
Subject: Re: [PATCH v2] tools: fix oom setting of xenstored
In-Reply-To: <20211019112140.26988-1-jgross@suse.com>
References: <20211019112140.26988-1-jgross@suse.com>
X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu)

Juergen Gross writes ("[PATCH v2] tools: fix oom setting of xenstored"):
> Commit f282182af32939 ("tools/xenstore: set oom score for xenstore
> daemon on Linux") introduced a regression when not setting the oom
> value in the xencommons file. Fix that.
> 
> Fixes: f282182af32939 ("tools/xenstore: set oom score for xenstore daemon on Linux")
> Signed-off-by: Juergen Gross <jgross@suse.com>

Reviewed-by: Ian Jackson <iwj@xenproject.org>
Release-Acked-by: Ian Jackson <iwj@xenproject.org>

and pushed, thanks.

Ian.


From xen-devel-bounces@lists.xenproject.org Tue Oct 19 11:25:55 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Oct 2021 11:25:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.213045.371141 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcnFj-0001xm-7O; Tue, 19 Oct 2021 11:25:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 213045.371141; Tue, 19 Oct 2021 11:25:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcnFj-0001xf-4M; Tue, 19 Oct 2021 11:25:55 +0000
Received: by outflank-mailman (input) for mailman id 213045;
 Tue, 19 Oct 2021 11:25:54 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=gzZp=PH=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mcnFh-0001xX-Vb
 for xen-devel@lists.xenproject.org; Tue, 19 Oct 2021 11:25:54 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 5163126e-30cf-11ec-8310-12813bfff9fa;
 Tue, 19 Oct 2021 11:25:53 +0000 (UTC)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2110.outbound.protection.outlook.com [104.47.18.110])
 (Using TLS) by relay.mimecast.com with ESMTP id
 de-mta-15-CazR7_knOOWTS7Jygwp5Nw-1; Tue, 19 Oct 2021 13:25:51 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0402MB3775.eurprd04.prod.outlook.com (2603:10a6:803:1a::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.17; Tue, 19 Oct
 2021 11:25:49 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.018; Tue, 19 Oct 2021
 11:25:49 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6P194CA0041.EURP194.PROD.OUTLOOK.COM (2603:10a6:209:84::18) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.14 via Frontend Transport; Tue, 19 Oct 2021 11:25:48 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5163126e-30cf-11ec-8310-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634642752;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=Ga5BNlOutqG/yZYHaC+o3yjkXEU0eKgcGY/4M3UFTZ0=;
	b=Iijg160AxBIE9UWfYuDDx9Ogbd4Wxhn7uyb0IsTzww520P6Bqdv2IOBurBtPgekqO/LPWs
	Hhp4CWRCdrEmpGKY3SHDuzh2eyvBq2pD+wDQT1h/iSLIjgSa6rFhXGk6NjFxaztzvKdFGo
	QbR3E0NM4erf3VXRpgX3pNkyiTHK1O0=
X-MC-Unique: CazR7_knOOWTS7Jygwp5Nw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=C9nquac0T2BEmGMFm2TgYGW05DBsJmNzTsMJ2dhqkFSt6QM5mavR37+9nHWBFfHbQ22wt6yhBCWzND3Sb31McQ8yBM6WwnvR/Gr49g3SVWATB41i8/brQJppYpb4brtLS9UR2bguhFnD3y4WF+U+79WKAVxNPSWotUrOwKV2GyirIZfJVZ95OrF1FHhr8YMXGoBaB9bD1ntk1+IIqbvNCmzUCZED7maz4hJSd3RWMr+8nN3o3bqw+XevUweoRBO5Qk1siOnxtwXxSk79LzLzdSSXuRw57sBf16Ko3TVdOZ/beZasl7c+DNbh/YALpHwkrcjXJwtur5Bo0FHa2Gqozg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Ga5BNlOutqG/yZYHaC+o3yjkXEU0eKgcGY/4M3UFTZ0=;
 b=NpQnGCsLX4EzuFtNtY8E04wVTDrsqZ4VgZU2C1xBY2+KnRf1O6OUDbLVhs125z1szQ4jSTb8sPgvBfRmxYpQe3SXvyIrE+K9thP8+nMsbgNz0x9s+z5THbFFmqLOc1YZi0qa84zGC1q2sDfI1DrT7Z6D34WYEfbs2n5Kn2pqGtLqCH5BzB+4SvxmEArR4wY9MJgu0ziqA3sehc0PlBMDOHGT0iWbeaYTQtBT+ghgvsCJx2XAk0gfQ7DNmCdNqL22LSGxno5jmSeC4dfPgRiqi1GzaH9Rn/TXGl2KisV1b3c8PomaMpmuDlKAy2OjaNjlnWpFuUjITa34MZfkGwRm+g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: citrix.com; dkim=none (message not signed)
 header.d=none;citrix.com; dmarc=none action=none header.from=suse.com;
Subject: Re: [PATCH 0/3] Fixes: PCI devices passthrough on Arm
To: Ian Jackson <iwj@xenproject.org>
Cc: xen-devel@lists.xenproject.org,
 Bertrand Marquis <bertrand.marquis@arm.com>, sstabellini@kernel.org,
 Oleksandr_Andrushchenko@epam.com, Paul Durrant <paul@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <cover.1634639117.git.bertrand.marquis@arm.com>
 <24942.43034.758402.850001@mariner.uk.xensource.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <4471eef0-5dfc-876d-5f4b-e5b163032210@suse.com>
Date: Tue, 19 Oct 2021 13:25:47 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <24942.43034.758402.850001@mariner.uk.xensource.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P194CA0041.EURP194.PROD.OUTLOOK.COM
 (2603:10a6:209:84::18) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: fd51cc0b-d37d-4bbe-2e9c-08d992f3337c
X-MS-TrafficTypeDiagnostic: VI1PR0402MB3775:
X-Microsoft-Antispam-PRVS:
	<VI1PR0402MB377580A94D19B3034E6A664CB3BD9@VI1PR0402MB3775.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	slXDeyeB5aiQByNS4MKifCXftAt6oLjsR2HG/pMx8aGMT9I0CXsharHeN1jUIs9Lpo1UqNqo4SMmjb3pavfI78W8+VDus7UNYHP/vQSoeoiffwgpwPyxZoWka9DHTAIfxk4TwaV+r5JM8RrWNnVQkTd4zujYaFK1Eel27yy3aiQ++oyWdykwtMBdKztdb9kUbJoOWrM/OZE5AoRtSCPSAR62mPQ9/dzuuq8YFd+NtnU3dGyDczibJQondkidwsOIdf1yudj0We0X/Qj2FIZ8xB9bo1xXAYKm+rvBM31fI1fG2Iwlu8Zft4MSgLeIKkKnelHLIG4MCsoq23TsK3gzG2vV4+3Q4JOHSZ5dqz3+0dcelA6hnovX04SYtZ/1aSTKVCpzI5HKAZc+dyUSl7HKgbA4e6huQTIqa+K648gCCX0pfi3fb5GUU5QxVOlDfn0h2CV8r/+sYJ79ygzfA7vLwt1VHYvas3gxnvippz5Jl3oliH4C0ugraKIYW6jKMOOFLixWKIG8JLPdYHan1EjfpQu920wZjyLPAvceMMRpeKB2n9Xmos05dVeadug57HDnqiVynh709BSlI4fSW8s0S0HazHtB3nmEG53nd6I41B0H9lhgfeRSzw7pSy7c0Um9EBybnZsPTwGwxAdHdCLjYxb3SkH/vtNesR1smIiL/wuazae/NP64oxPfxEBcTSr6HJw2btAv2PCSywojd3EbiD4GmzYSYr5THbPXO7HYx+o=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(53546011)(38100700002)(54906003)(2906002)(66556008)(5660300002)(31686004)(66476007)(66946007)(8676002)(508600001)(4744005)(956004)(86362001)(8936002)(186003)(6486002)(6916009)(316002)(4326008)(2616005)(36756003)(16576012)(31696002)(26005)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?YjE0em0xaGg3VVNjQzBvZDJXL1d5bUlqRkpEV3M2OFYxQVQvSnk2OWtDa3My?=
 =?utf-8?B?M2VHUTNnTFFxRmN4RHlqbHpMNW93ZjdzUVl5cDMrNXBZTm81VzJZM2VMODFw?=
 =?utf-8?B?azVVN3hGZWlpTERHQlpxaVo4U2hRc01RN0JZUFJ6ZDh5WFNxcTZJbG8zMjNQ?=
 =?utf-8?B?RytRZDBRNklLbmdocThNWjhyQTMvdGxoeS9qSGRQaGcxbEJreTA4YWRGaG8x?=
 =?utf-8?B?Y1NieWNWa01Ub0ZNNVBiUTJCMkJTMmFkTjhWbDdxZGNFd25QOGdOTUgwdGxN?=
 =?utf-8?B?aHNkMy9adk1yemhvejFwTnNpWk1JK1NIWjM0T1diZ2tNQk1CT1hYczBybmlw?=
 =?utf-8?B?Z2tEMGJubFExM09ZNmNKSVhrVURVMFZXMUVzUDNCUlovNnZiU3c2TG9TZ1lB?=
 =?utf-8?B?dEhaa0VNdjRYWHlWK2V5OVU4UHNPdWZjam9sSEp1U0czS1QxaVNCeUQrNkgr?=
 =?utf-8?B?aXFmNDBlMDFZNHZ1dmxuQ0lyVGZJRm90ZnZwNkpvNmphSE1KUDlHN25VUHBv?=
 =?utf-8?B?bDkrdGxVakd1Q3Z2ZWE5V25uZ1dIcmtSUUdOQ05aYllMWlhMUngyVWQ4dFly?=
 =?utf-8?B?ZUEyOExycVVwdW8zTmFLWVlrWTVmeGE4NHorN2Z1MFZLeGtBS0JZczFjbWgx?=
 =?utf-8?B?U01PUjBXanpMaWZETllKdnV4U1U1Znk3bHBTMWcvZFhBS2VBTm1KQXpBUHBX?=
 =?utf-8?B?S2ZrbTZxck8vNiszR3FXN3p0cVllLzVuNkVHRVRwNTVhQ3lyMmRIQ2I1M0hl?=
 =?utf-8?B?dlUyeGIzUWl4dXhiRUtOemlURlRNSS9HNGNsc0FBSUhjUXcyaml4UzNQQWUy?=
 =?utf-8?B?VHgrUFI1ZjFGNTcrQlVJZTFDYTFhMVg4OFVidUd6dGRralFPSFJNUXZVN0k4?=
 =?utf-8?B?OHBUQmQ1WnZ5YWpkZVNGTXBMQXM3VG9aQUg4U2MrcFp3dGFTbnNScnNNMmNq?=
 =?utf-8?B?OFByb25yUjQ2a29ZZlJSSHpCYnlEWElqZVRnNzVwWnNBLzZZMEdwZ1ppMjhW?=
 =?utf-8?B?Qlk3RklmN3ZqYUZ3T05rcTRtTDR5eFhHNzM3bjM1Y1cxVmI5ZHNPRUsweGNF?=
 =?utf-8?B?OW5Ib284S0lBSFh2QSs0OTY1b2JSWmtOK2Z5OGZ6cFhMTG5Zd2RxVDF4MTVt?=
 =?utf-8?B?YWV1QUh3Nzh3Mys1dzlBRUtYeTNqQ0hGQWxMdEsvbm9sc1FlTCsrNWd4VEFT?=
 =?utf-8?B?eDYzTm1vVlNkbXNyN2h3cWhVUGFGejI5R1N0cEdsUXV2NGF5dXlGU0JIT2Vj?=
 =?utf-8?B?MHRCUHM2NHRFYzR6MStCZk9saEZ2SVJTYjQ2QjU4Y3QwTGd1YzFDcUpVNTIz?=
 =?utf-8?B?ekZnRDBEeVRpa0Nxa2VBSEIwNFRCR28va0x2aWNZbUY2N3ZZV0lJOVo5SVRl?=
 =?utf-8?B?RE1LcWVlMk43Y2haWlhQdXBmQW5qdnBVcDV4cldmNjhmTHZ4V1E3alhITnZD?=
 =?utf-8?B?QnBDSUx0cEprZWRLcHpLVmx4cE4wUUQyR1hCcXNoZjdMdFJ1M0xMK2VQNE5V?=
 =?utf-8?B?eTh6cW9YeFExSW5qc3FpU2dhSlR3SDZlNXdpSU9SVjVzUUNHSTZDZG4vMzJQ?=
 =?utf-8?B?OUJ3alV2bk9OZlZ5MER0Uk5iUHV3TStMNDZ3YjdaQlVTWVNCRDZqczBwTkFo?=
 =?utf-8?B?OFUxOFptdnozR3BYbWZ6V1o1SWpaakh0RmhJT2ErbEpBVmgyV0dpZWdXb0NR?=
 =?utf-8?B?YXkxUlh3NW4rS3Y3VnB6R21ZRGpPWTA3aUZJR2tNbkZSWVNaTWxnMm5IRWU4?=
 =?utf-8?Q?GlaBs+mb4Jz5WWw6H8HNotE9kil6CwXo6U6dX8T?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fd51cc0b-d37d-4bbe-2e9c-08d992f3337c
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2021 11:25:48.9709
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: MyuSvB2FqQKWVaxN6eQmUT0ggjy+i48a+w4EKm27pjejejVzhKRakfvkqfqvR6hqXzgiczoDL9JQpNDuJe7Rrw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3775

On 19.10.2021 13:12, Ian Jackson wrote:
> Bertrand Marquis writes ("[PATCH 0/3] Fixes: PCI devices passthrough on Arm"):
>> This patch serie is a follow-up after various findings on d59168dc05
>> ("xen/arm: Enable the existing x86 virtual PCI support for ARM") as of
>> agreed in [1].
>>
>> It does the following:
>> - enable vpci_add_handlers on x86 and not only on arm
>> - remove __hwdom_init flag for vpci_add_handlers
>> - add missing vpci handler cleanup in error path during pci_device_add
>>   and pci_device_remove
> 
> Thanks.  Roger, Jan, what do you think of this ?

I'll get to this, but at the first glance I'd say that the change in
patch 1 coming before what patch 2 does is already a problem.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Oct 19 11:31:31 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Oct 2021 11:31:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.213052.371153 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcnL5-0003OR-Th; Tue, 19 Oct 2021 11:31:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 213052.371153; Tue, 19 Oct 2021 11:31:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcnL5-0003OK-OV; Tue, 19 Oct 2021 11:31:27 +0000
Received: by outflank-mailman (input) for mailman id 213052;
 Tue, 19 Oct 2021 11:31:25 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=eXNP=PH=citrix.com=roger.pau@srs-us1.protection.inumbo.net>)
 id 1mcnL3-0003OE-Df
 for xen-devel@lists.xenproject.org; Tue, 19 Oct 2021 11:31:25 +0000
Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 51491dcc-82f4-4e6d-b3ee-7809e4dfbe3e;
 Tue, 19 Oct 2021 11:31:24 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 51491dcc-82f4-4e6d-b3ee-7809e4dfbe3e
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1634643084;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=d9c4aloUsgma8HDm99ip8r6GYEiQI6ifTi1XGOPn8SY=;
  b=ZrJHBEtDy+EJo/x/fizWOcwOVidouPfBMFd0lejKoahn2FbSR9iSTd6B
   MyAl38X3ikbhUJUMTNz9S7llPVa/O2jeT3Lt+KDh4ojhIAs3l8B/0E91t
   jGZ2rEmUMFEP2WmfkGtvxFR2N1ZtPV3URUSNU2FUe8e9aHY8nM7lJhkzZ
   Q=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: H9n8eDAfajAdqufTUgJ1IcTgJDsgphXZYAYLRtAM9Aajr3d2j3SZN5TLwsG4DvTsESHT2s8Giw
 0Q3UxOjGz5XzM6JI4gwYlzn3RVzYl/PUyiZkGyGIjy5BtgvN0gmhPjrWtdfsqJsvc6no6dOgr4
 RmJt9vWe4TFH8GjJVsA+EJyuqMBCQeP+0x6fWvmg5PDOthEHkNpRNDl/fBi8oLGfDWUXy8qRpU
 vYQoaFE5CdHH6yOBjvYedhkwCB7C2UlQMqMXKn6jDXfMXZFFlXLJRIb/HEmhV9kBuRud0VfT9d
 lqIN/1HNX+ZXSZyOaGCY5dRa
X-SBRS: 5.1
X-MesageID: 55085484
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:x+bF9K1i69j+ggoPzfbD5Qt2kn2cJEfYwER7XKvMYLTBsI5bp2YAz
 mYWC2rVa6vbZTSged93a9nn9kkCv5bVmIJhTAVtpC1hF35El5HIVI+TRqvS04J+DSFhoGZPt
 Zh2hgzodZhsJpPkS5PE3oHJ9RGQ74nRLlbHILOCan0ZqTNMEn970Es7wr9h2OaEvPDia++zk
 YKqyyHgEAfNNw5cagr4PIra9XuDFNyr0N8plgRWicJj5TcypFFMZH4rHomjLmOQf2VhNrXSq
 9Avbl2O1jixEx8FUrtJm1tgG6EAaua60QOm0hK6V0U+6/TrS+NbPqsTbZIhhUlrZzqhpd5V9
 ucQus2LUSAwApP+t+oTfgcIKnQrVUFG0OevzXmXtMWSywvNcmf2wuUoB0YzVWEa0r8pWycUr
 6VecW1TKEDY7w616OvTpu1EnMMsIdOtJIoCknph0SvYHbAtRpWrr6DiuIIAjGps1pwm8fD2b
 NUaNjEobC/6egwIYHw2N5M4lsGVvyyqG9FfgA3M/vdmi4TJ9yRu1JD9PdyTfcaFLe1Fk0Ddq
 m/Y8mDRBhABKMfZ2TeD6mirhOLEgWX8Qo16PL+y++NugVaT7ncOExBQXly+ycRVkWbnBYgZc
 RZNvHNz8+5iryRHU+URQTWCrlq6jEMTCuFINPQG1jOixKT5/VagUz1soiF6VPQqs8o/RDoP3
 1CPns/0CTEHjIB5WU5x5Z/P8mvsYXl9wXsqIHZeF1NcsoaLTJQb10qXFr5e/LiJYsoZ8N0a6
 wuBqzQinP0thMoP2rTTEbvv0m/0+MahouLY4GzqsoOZAuFRONHNi2+AswGzARN8wGCxFAnpU
 J8swJD20Qz2JcvR/BFhuc1UdF1T296LMSfHnXlkFIQ7+jKm9haLJN4LvGwufhkxaJhdKVcFh
 XM/XysLtPe/21PxNcdKj3+ZUZx2ncAM6/y0PhwrUja+SscoL1LWlM2fTUWRw3rsgCARfVIXY
 v+mnTKXJS9CU8xPlWPuL89EiOND7n1ulAv7GMGgpzz6gOX2WZJgYepcWLd4Rrtit/3sTcS82
 4s3CvZmPD0PCbygM3mJq9B7wJJjBSFTOK0aYvd/L4arCgFnBHsgG7nWx7YgcJZihKNbiqHD+
 XTVZ6OS4ACXaaTvJVrYZ3Z9RqnoWJoj/3s3MTZ1ZQSj2mQ5YJbp56AaLsNlcb4i/e1l7Ph1U
 /haJJnQXqUREmzKq2YHcJ3wjI1+bxD31wiACDWoPWokdJl6Sg2XptK9Jlnz9DMDBzacvNclp
 +HyzRvSRJcOHlwwDMvfZP+14Um2uHwRxLB7U0fSe4EBc0Tw6ol6bSf2i6Zvcc0LLBzCwBqc1
 hqXXkhE9bWc/ddt/YCQ166eroqvH+9vJWZgHjHWveSsKC3X3mu/2oscAuyGSi/QCTHv86K4a
 OQLk/ylaK8bnExHupZXGqpwyf5s/MPmorJXw1g2HHjPaFj3WLpsLmPfgJtKv6xJgLRYpRG3S
 gSE/dwDYeeFP8bsEVgwIgs5b7vciaFIy2eKtfllcl/n4CJX/aacVRQANhaBvyVRMb9pPd532
 uwmosMXt1SyhxdC3gxqVcyIG7Bg9kA9bpg=
IronPort-HdrOrdr: A9a23:ITuR465/kj/VKwsLKQPXwVmBI+orL9Y04lQ7vn2ZFiY7TiXIra
 yTdaoguCMc6AxxZJkh8erwX5VoZUmsj6KdhrNhQItKPTOWw1dASbsN0WKM+UyDJ8STzJ856U
 4kSdkDNDSSNykKsS+Z2njALz9I+rDum8rJ9ISuv0uFDzsaE52Ihz0JdDpzeXcGIjWua6BJcK
 Z1saF81kWdkDksH4mGL0hAe9KGi8zAlZrgbxJDLxk76DOWhTftzLLhCRCX0joXTjsKmN4ZgC
 f4uj28wp/mn+Cwyxfa2WOWx5NKmOH5wt8GIMCXkMAaJhjllw7tToV8XL+puiwzvYiUmRoXue
 iJhy1lE9V46nvXcG3wiRzx2zP42DJr0HPmwU/wuwqqneXJABYBT+ZRj4NQdRXUr2A6ustn7a
 5N12WF87JKEBLphk3Glpj1fiAvsnDxjWspkOYVgXAae5AZcqVtoYsW+14QOIscHRj99JssHI
 BVfYDhDc5tABGnhk3izyxSKITGZAV2Iv7GeDlNhiWt6UkUoJgjpHFog/D2nR87hdsAotd/lq
 L52gkBrsA7ciYsV9MOOA42e7rANoX8e2O+DIusGyWTKEgmAQOHl3el2sR+2AmVEKZ4u6fa3q
 6xCW9liQ==
X-IronPort-AV: E=Sophos;i="5.85,384,1624334400"; 
   d="scan'208";a="55085484"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=YZlMssREYHiCE9ONUVCpewOdKki19Dj3Ay0TVRQJSUY+dVdsMQDsIXG5i3XtCo09TYQq5qORXkbjDrOimkHR9MB87DdBmxuc2N8aTilRWUWW6ERt9pW7pyt2+jfSUaio8/5pIPfAzebmmZtsLqRNnJ1LYCstOAIuekTrs0BQMepFMTKFWyvkxM7VgEKHArzk4OvZy467rU8yCr4KYuPaY1jSkkI25ZQW9GsbzxmIs5Pd/SI38I/Agq4RrekufOeSWxouEvvNnMZtV0u2zlvoP2P0V+Akx5dzk1DADpLQqnDAkzZNgEDsxVKjFCesStsBNNu32s9+1ZSY9N99j9SfiA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=V74hYCJTI8XNv2qDJ17ZsmmKDEgzk14vxa4bRbPtGZc=;
 b=ApFjopDXFAiAEz731eodkPzcW6FAfOCjVCA2HpXbIiVHlP5l6oy9HGcjLrCM5s4XBrWXEPbZe0Go1I4rVe7oDbT8t6ow5Xoa7nDB7x3GdCGeFVfyhUxEX5CBMKRXGjZNCTeVmh5fd4qadyFIMboRt2d9Bom2oUJjP4k+QmGuF7+PCjnwpg3gvU8dQuoxLCtHRKV5wT9Vmt4Zn2vP8MRr+40JGls4dQRuCsAU/3sCGp4QuRoYesLbJZzsesJZ083LJ9FYMV3cg1SWYcn5USv8uaI4KzTrKo8FhcbgbVyjYxuW9fMA2zO82MO9Jffl7lgV5CDfIzx5s1f7E4N3smIyTg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=V74hYCJTI8XNv2qDJ17ZsmmKDEgzk14vxa4bRbPtGZc=;
 b=cKG1Oz7O5ShpHVgxl3ONDUUSv4LpPkZsvznnspa7XE1wOsbNQvB6O+EjvpNtZMOF6etxnaBlRZTplYyQ6wOY9cylL+F76Vj1a/at/0SRe9GPk8G1SRN9kuPb+H3wTEhf1gDcB8QL479tTPo7QZ6F79GgtytLvgGyFDRfbQyvZ6c=
Date: Tue, 19 Oct 2021 13:30:17 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Andrew
 Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH 1/2] x86/hpet: Use another crystalball to evaluate HPET
 usability
Message-ID: <YW6sSXMyC6t4fB62@MacBook-Air-de-Roger.local>
References: <9963c7a2-f880-66fc-8f12-b1ddd0619c91@suse.com>
 <da80b8dd-177c-d27a-9a00-c9538a139d37@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <da80b8dd-177c-d27a-9a00-c9538a139d37@suse.com>
X-ClientProxiedBy: LO4P123CA0180.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:18a::23) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 9271573d-932d-4ee8-76ca-08d992f3d704
X-MS-TrafficTypeDiagnostic: DM5PR03MB2491:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <DM5PR03MB2491E18DEAFFC55148FA7AE68FBD9@DM5PR03MB2491.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:2089;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: Qya34a3ZuGDd7a7G5kFAYL5Jq5vZ9hWf4UbnrmWOGXeIQxZRpwa7n365PFuD4BdxdBZ/F0hWPZS6QGl2TOPk1zZ/NoM2i7nF8UuvNwAOSFG9+CMy09EgHTJZ55iJO1hthlmnQ9/ZBn+DMeq4844AY5+CsJpzR5z+1ck38ixVj0aNzW8vqiooC8//974t6Pd7gmBWvgv+CTJP7FeLme5zIByGkYvCPcC4opnU0lpxJ5BOOFaeykjN3IgFk8Go+Z3mpUXM0GUsQ2K+snLU4lmMAsmgpTkwwsWSErvqwUEwYwmKE7qrHSjHAaIvrYuCtftaVindmcQTv1B/f/C4DoJLXOIZPc49Tme1IdoKsvTl9fhZY1jmWEo5s9QYF+IQdF+uZ66HXRP6mdr1vNe7bpCz27XOJQGETJrmn9tnwCzQTw4IjE8iiNnR8g6vbefEUNxn0Baqa0kSAwwimxhF0nDqYbFlEPlUlW20eBF5CgCoVuZIRaWsfATlhZrQb1bd25TdgoJpDX1oVJmJ2QzVVDM920KJNalpPL6UlMFyYCpGDeEVcwN2AX2fPuiAv43XZUDOyqby756+3y8J+rh6UWc1uAH1b0nqbZywKplLfqeTW52g+8z/Ilxk4ISKmZ4i1fjGdx3hH7RSNZtDiLjt6SKJIg==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(38100700002)(66476007)(8676002)(85182001)(66556008)(86362001)(508600001)(316002)(5660300002)(2906002)(66946007)(8936002)(6496006)(4326008)(9686003)(6916009)(6486002)(26005)(82960400001)(54906003)(83380400001)(186003)(956004)(6666004);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SUJrVnhVbHJRR1UwTTRRd3I5N1orWHpmWmVuYUpMT0h4NkdmWEFQSDJkSU8v?=
 =?utf-8?B?bkMvVW9XVFppbTk4V3hVa0U5RHlTT2tSUlpjT001RHZEQ2o4Sk1XVVphYjZ1?=
 =?utf-8?B?MlRVZWlSUkN5US9QNWtJRmRZUkkwdXZQSjNidUdLWmkwWm1aMStEVm9jaTJI?=
 =?utf-8?B?OE9adDgzZUk0bGhXbXNCeFkzSkJ0ay82OGZaWU9xdnV5RlpqVWRlZlkzenZr?=
 =?utf-8?B?a2Q3Q2hVS0Z2QVRPNUpNZzQ5SE0wN0htL2hrNDV4YTB2MFJQQkphSGhwaEps?=
 =?utf-8?B?MUpvRTYwSVpSa0tzQy9Ga2RXTW9tZk9CUjZwWnJCUHhlVm9ZYU96N29aUEJt?=
 =?utf-8?B?Vk51M2V5UGFSOW5xWjFmay9RUDY2U0RrRlNCS012ZlpXNTA1RWFwZHJ6eFI0?=
 =?utf-8?B?d1RjZHRyQjhXYmIzWVYwdkxUSlBzWHk4TjNDck90dGxDWDE5dTY5T1N4QXJT?=
 =?utf-8?B?cHdLdGQra09lME05RjVUaFFGZzRtWENNN2tLb2dlbHBNS1pIaTM2c0paMDJD?=
 =?utf-8?B?cHVxSVpVNWlGMHI0dUo4enkvK1VWVTVRNXBaSVFzKytFazczcFpEN2tGbFBw?=
 =?utf-8?B?VnhHaFFWV05HMUREdjZUbDJwcEluOGZNcGFpbTNaSWkraHhTQ20yOG5FUTR5?=
 =?utf-8?B?RjNKdndpN250bC9SUVNkVWovUDBOOXZ3T25yTzNYN0NZRWpYdFdnZGZmTUZR?=
 =?utf-8?B?czkydGFNRjhGNkZCV2lxZDN2aHRydEx4ODcrSmR2M0k3aGd0VjV1R0lESGpN?=
 =?utf-8?B?TTl1ZHBVczNzSU9xZ1I4K2MrK251MGJNL3c3eVlpdEg4dHZLai9jS2ppZEJK?=
 =?utf-8?B?bENub29acU1ra3h6a3hBK291Tk1PL2hKQ2k2UkJtWmVjNHRBS2t2MGZSa1dk?=
 =?utf-8?B?bkxjZnJ5RUJLTTBkS0ptK294d0ZITldqd3FJcW5oV21NbkRiZHdhR3ZITzVo?=
 =?utf-8?B?QkJsVi9lczU0L09yRnVqR1NqQVNZQTBiVW54RzFXa05yOE52MzFxQUFIaitV?=
 =?utf-8?B?OVRJVEtvWld5ZUFyWlJzYXNGbUIrU0Y0TjN2QWhwVUxSUnBUN0c2R3NKNmo5?=
 =?utf-8?B?R1QxWlFadkk3TDEyVlRFRFRYQ3NURGQxUWgwMlVmc3k5bncwdHVXZTU4U0oz?=
 =?utf-8?B?Q3A3SkFXWkF3NEQvK0Z5eDczRTVIMjNDaExvVjNNMjRJZldLckxEYTVXRUhF?=
 =?utf-8?B?dzRoZGN2RWdvVnFuRW02c3RpTnVXU0ZDUExLd25GZ3ZsYzhFb1crckdNSE9B?=
 =?utf-8?B?cndYanZFdm4wdk1CWlBlT3htZ0pIa09VVmZCNi9YRlQ2K3M1U2NKazlreXFu?=
 =?utf-8?B?QVdvY3d3KzhTUDliTzF1UUNqenlKUXQxNlRGeUY0T051NWViUVorQ0FXUVB0?=
 =?utf-8?B?NFhqdXdERGxzc3dPY2xuWjYxcXpKZzBuSlRHbWlzdHc2SS9wSUt5SEpoN0VC?=
 =?utf-8?B?dTZHWEZOV3NTdXNjcmRnSGszZmpzNjEwR2w5UEIzUnkvN1ByRFNGS1RTTHBS?=
 =?utf-8?B?Y2s1V01PejRKOElYbGhweU5GVzJ4ak9sNjFSRXVyVE0xVExnL3lhSGhBVkxh?=
 =?utf-8?B?bHBOVUcrREQ1Rjc3MGFUczFBSGJFMnpxUlYyODluZFRsUmhNSlMwYmx4dGRV?=
 =?utf-8?B?alpmaWRESWM0TlJBd3JXMDVMZ21tR0U1Wmh4TVZSbzJoKzlCa2NwWStoNXox?=
 =?utf-8?B?bFdVSHhLTVM4SzVtVlhtTzFkMXgyZzZVRGh5N1pCM2RuenBCck1vUGgzVmsv?=
 =?utf-8?Q?du9Krv2nsF2MZAZKeP2uwJ4nUyr7dH/iMihA45D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 9271573d-932d-4ee8-76ca-08d992f3d704
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2021 11:30:23.2942
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: i76Dh1qrzwiKaBXMkcJ/Y47Cw/IgUNnsz+5ZbgRNhzajb7txnjgg7QRl22y0Qk7sfdUYyG4d2A8IMq5ErieFjg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB2491
X-OriginatorOrg: citrix.com

On Tue, Oct 19, 2021 at 09:07:39AM +0200, Jan Beulich wrote:
> From: Thomas Gleixner <tglx@linutronix.de>
> 
> On recent Intel systems the HPET stops working when the system reaches PC10
> idle state.
> 
> The approach of adding PCI ids to the early quirks to disable HPET on
> these systems is a whack a mole game which makes no sense.
> 
> Check for PC10 instead and force disable HPET if supported. The check is
> overbroad as it does not take ACPI, mwait-idle enablement and command
> line parameters into account. That's fine as long as there is at least
> PMTIMER available to calibrate the TSC frequency. The decision can be
> overruled by adding "clocksource=hpet" on the Xen command line.
> 
> Remove the related PCI quirks for affected Coffee Lake systems as they
> are not longer required. That should also cover all other systems, i.e.
> Ice Lake, Tiger Lake, and newer generations, which are most likely
> affected by this as well.
> 
> Fixes: Yet another hardware trainwreck
> Reported-by: Jakub Kicinski <kuba@kernel.org>
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> [Linux commit: 6e3cd95234dc1eda488f4f487c281bac8fef4d9b]
> 
> I have to admit that the purpose of checking CPUID5_ECX_INTERRUPT_BREAK
> is unclear to me, but I didn't want to diverge in technical aspects from
> the Linux commit.
> 
> In mwait_pc10_supported(), besides some cosmetic adjustments, avoid UB
> from shifting left a signed 4-bit constant by 28 bits.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Acked-by: Roger Pau Monné <roger.pau@citrix.com>

Just one comment below.

> ---
> v2: Fully different replacement of "x86: avoid HPET use also on certain
>     Coffee Lake H".
> 
> --- a/xen/arch/x86/time.c
> +++ b/xen/arch/x86/time.c
> @@ -34,6 +34,7 @@
>  #include <asm/fixmap.h>
>  #include <asm/guest.h>
>  #include <asm/mc146818rtc.h>
> +#include <asm/mwait.h>
>  #include <asm/div64.h>
>  #include <asm/acpi.h>
>  #include <asm/hpet.h>
> @@ -395,14 +396,43 @@ static int64_t __init init_hpet(struct p
>              }
>  
>          /*
> -         * Some Coffee Lake platforms have a skewed HPET timer once the SoCs
> -         * entered PC10.
> +         * Some Coffee Lake and later platforms have a skewed HPET timer once
> +         * they entered PC10.
> +         *
> +         * Check whether the system supports PC10. If so force disable HPET as
> +         * that stops counting in PC10. This check is overbroad as it does not
> +         * take any of the following into account:
> +         *
> +         *	- ACPI tables
> +         *	- Enablement of mwait-idle
> +         *	- Command line arguments which limit mwait-idle C-state support
> +         *
> +         * That's perfectly fine. HPET is a piece of hardware designed by
> +         * committee and the only reasons why it is still in use on modern
> +         * systems is the fact that it is impossible to reliably query TSC and
> +         * CPU frequency via CPUID or firmware.
> +         *
> +         * If HPET is functional it is useful for calibrating TSC, but this can
> +         * be done via PMTIMER as well which seems to be the last remaining
> +         * timer on X86/INTEL platforms that has not been completely wreckaged
> +         * by feature creep.
> +         *
> +         * In theory HPET support should be removed altogether, but there are
> +         * older systems out there which depend on it because TSC and APIC timer
> +         * are dysfunctional in deeper C-states.
>           */
> -        if ( pci_conf_read16(PCI_SBDF(0, 0, 0, 0),
> -                             PCI_VENDOR_ID) == PCI_VENDOR_ID_INTEL &&
> -             pci_conf_read16(PCI_SBDF(0, 0, 0, 0),
> -                             PCI_DEVICE_ID) == 0x3ec4 )
> -            hpet_address = 0;
> +        if ( mwait_pc10_supported() )
> +        {
> +            uint64_t pcfg;
> +
> +            rdmsrl(MSR_PKG_CST_CONFIG_CONTROL, pcfg);
> +            if ( (pcfg & 0xf) < 8 )
> +                /* nothing */;
> +            else if ( !strcmp(opt_clocksource, pts->id) )
> +                printk("HPET use requested via command line, but dysfunctional in PC10\n");
> +            else
> +                hpet_address = 0;

Should we print a message that HPET is being disabled?

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Tue Oct 19 11:33:34 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Oct 2021 11:33:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.213061.371171 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcnN6-00042i-Ap; Tue, 19 Oct 2021 11:33:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 213061.371171; Tue, 19 Oct 2021 11:33:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcnN6-00042Z-7o; Tue, 19 Oct 2021 11:33:32 +0000
Received: by outflank-mailman (input) for mailman id 213061;
 Tue, 19 Oct 2021 11:33:31 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=XJzt=PH=arm.com=Bertrand.Marquis@srs-us1.protection.inumbo.net>)
 id 1mcnN5-00042T-2h
 for xen-devel@lists.xenproject.org; Tue, 19 Oct 2021 11:33:31 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com (unknown
 [2a01:111:f400:7e1a::62d])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 304f3fb8-efe7-4b91-a661-368921569df4;
 Tue, 19 Oct 2021 11:33:29 +0000 (UTC)
Received: from DB6PR07CA0058.eurprd07.prod.outlook.com (2603:10a6:6:2a::20) by
 VI1PR08MB2846.eurprd08.prod.outlook.com (2603:10a6:802:21::24) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.17; Tue, 19 Oct 2021 11:33:20 +0000
Received: from DB5EUR03FT004.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:6:2a:cafe::36) by DB6PR07CA0058.outlook.office365.com
 (2603:10a6:6:2a::20) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.9 via Frontend
 Transport; Tue, 19 Oct 2021 11:33:20 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT004.mail.protection.outlook.com (10.152.20.128) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.15 via Frontend Transport; Tue, 19 Oct 2021 11:33:20 +0000
Received: ("Tessian outbound b9598e0ead92:v103");
 Tue, 19 Oct 2021 11:33:20 +0000
Received: from 9a3c6bc55e90.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 6E9B0E14-DA6A-42CB-9BAD-612C9C5FE025.1; 
 Tue, 19 Oct 2021 11:32:41 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 9a3c6bc55e90.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Tue, 19 Oct 2021 11:32:41 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com (2603:10a6:4:74::9)
 by DB6PR0802MB2456.eurprd08.prod.outlook.com (2603:10a6:4:a1::8) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.17; Tue, 19 Oct
 2021 11:32:39 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955]) by DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955%4]) with mapi id 15.20.4608.018; Tue, 19 Oct 2021
 11:32:38 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 304f3fb8-efe7-4b91-a661-368921569df4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=dKrQOCyDCw3CZ4gHOudlzVOYZ0BMoOJTHY6Yunl+J0s=;
 b=FKIWkZszjkhoYsi7L+EkT07aFx+2acoAe4YUJEOOEWxhxTyZoDhzpw1AaBBNEnKXywEmkrj1fi2zEsbsR43+scouhrdFuVhM6rIsh+pQpjevM/R4CXkAT3vpOXJ33dZp1KKTfWMzwD4St/sv6iiAlEeEUeErdjwwz4a3dQmQMHQ=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 730a8c9e0ee2cd47
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=FSiaQqRnMFKgHi0bu84Knw6kqTjqamazJJPjZisNMDD/l2622cY9mBIrbuOyt35aLvvJeS+FjvTS9UPu7zuQM5BY0oxKuSjDAKmdvWLpzXYihgzLYx+3eErcY+RmQdkO9TfUvAIGqiuAOCCkx+KHigv8S5m0jmD84gDvnC4ww0YC+R4lh8shxtDh15RNx9w0LiWsCPO0rfyKw9gL3payTS6Fzt/NhLfa8xIyzs1VOvV/eJLMfb0EVt49SFSZtVv2RoVCxc36v8Dq//pB3KFxVKf+gK2ToqFIMuaQSci7AKnNLwdZquF35Am6aBtYwnHuB7muj9CdNaozXSnkcOzfYw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=dKrQOCyDCw3CZ4gHOudlzVOYZ0BMoOJTHY6Yunl+J0s=;
 b=i6mLHAWYIuvF8d0CLJRYiWBrzQtJzteEkfm513Mucde5xuERh6SODGCWrIE/DJX1yq5uBsEt+ti6I424Y/RWd+HrdXTdj81EdvVeT7zIFrJO4m49OzFaCjR425qb4cnmX6MxfX2IJHNEMWstdN3TZlLF/kHSJAxZZRhiJ418gx6aHSlW2F0r7O4DA8gXSjK3y60gUpU61id5AoKet7/noUnPoXfYybbckMJCKvopOHlO6YhS0bD/pYIAqnn9z8bM96oYvCTIGMfTQGpUAfycbKaaELkwVqemde4BBOstA7X8CALM7cqCEcRKHP7IAkWPTAe/30I0Hx8vDea1z3NbmA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=dKrQOCyDCw3CZ4gHOudlzVOYZ0BMoOJTHY6Yunl+J0s=;
 b=FKIWkZszjkhoYsi7L+EkT07aFx+2acoAe4YUJEOOEWxhxTyZoDhzpw1AaBBNEnKXywEmkrj1fi2zEsbsR43+scouhrdFuVhM6rIsh+pQpjevM/R4CXkAT3vpOXJ33dZp1KKTfWMzwD4St/sv6iiAlEeEUeErdjwwz4a3dQmQMHQ=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Ian Jackson <iwj@xenproject.org>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, "sstabellini@kernel.org"
	<sstabellini@kernel.org>, "Oleksandr_Andrushchenko@epam.com"
	<Oleksandr_Andrushchenko@epam.com>, Paul Durrant <paul@xen.org>,
	=?iso-8859-1?Q?Roger_Pau_Monn=E9?= <roger.pau@citrix.com>
Subject: Re: [PATCH 0/3] Fixes: PCI devices passthrough on Arm
Thread-Topic: [PATCH 0/3] Fixes: PCI devices passthrough on Arm
Thread-Index: AQHXxNXsWVtDOu3dTEyPepRQ+pXuJKvaKrkAgAADu4CAAAHpAA==
Date: Tue, 19 Oct 2021 11:32:38 +0000
Message-ID: <0B9FADC4-6375-4069-8444-43346879F585@arm.com>
References: <cover.1634639117.git.bertrand.marquis@arm.com>
 <24942.43034.758402.850001@mariner.uk.xensource.com>
 <4471eef0-5dfc-876d-5f4b-e5b163032210@suse.com>
In-Reply-To: <4471eef0-5dfc-876d-5f4b-e5b163032210@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3654.120.0.1.13)
Authentication-Results-Original: suse.com; dkim=none (message not signed)
 header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: e4642ebc-218e-495a-154f-08d992f440c1
x-ms-traffictypediagnostic: DB6PR0802MB2456:|VI1PR08MB2846:
X-Microsoft-Antispam-PRVS:
	<VI1PR08MB28463E2165C207F6102BB3969DBD9@VI1PR08MB2846.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:9508;OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 a8HstyslVcif+2r/jqJKN/VQ0FXjbHNxq/9ri6J1kjap5TItK0djjWThJ2p14bE97M36lD2+NHfKr6xNboa6NJEJZCjE3/atDgNmmPjnYUCfuN3dqvYO5MMlvJdXc6RX3hFIBjGA635un5tc1x87RG2OV1ODctiEbQqQwAa/SdVhOcZauSg6C8/PYJpqdlaXm7OKZvtf4SV1KW1AbFnmqW2/W1Cf7k6wrDAhIB8/VmGd1vTPa52dxBnmM+Ft1KIg1RagYObvlwJr8Doz3V8gNtCtI6r61sK88yt3M7jwu24VTRbjr/UGItspIcLPw//vzpTOkqNjUWW7HuT1fe4Iz4iDZlHNh7n6fVUeZXBLEUbwYaOAL9lfiHMbfGhTbxSW2M/jWcCbDGMcIcyFa568/P3EdXWbsfMRIvPkDPQVLPqzcTzuhwnI2/2KZt2Aq8IZ41by5R0uRUzCyNHCFiegrEXj/JQ+YToF/nvgNH2k2fyL4EJ2Rp3OYBEJP7jyeD9+lnhH06mLyQi4wnNCMP657EviAsVPB5mfnyE7vD+F7WIzaLM2yVUX2Jva0VCqamt1TpB6WH8dA/uNDbjP3aGRhIbo6Dcr+PN8MbhAh/LIRz1GA7Sf9t6zDKnO61ADgrLMeX6cACt4H2edq+4+L4Gs66XkE1gQLawiLlqFIiKEsjiZD8iN/etPikylyt50ORn4xz+b4e2dCgwkCeGsClv7/VsKZ1BiEUZRhz+qoBQv0KgGGzeBnEG/7ltoUJr65by2
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB6PR0801MB2024.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(76116006)(91956017)(4744005)(66446008)(66556008)(64756008)(66476007)(5660300002)(66946007)(36756003)(4326008)(71200400001)(53546011)(6486002)(508600001)(2906002)(122000001)(8936002)(38100700002)(186003)(6512007)(26005)(38070700005)(54906003)(8676002)(86362001)(6916009)(33656002)(316002)(6506007)(2616005)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="iso-8859-1"
Content-ID: <19843E7E73BCF9448A3C2E05D5B509F8@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0802MB2456
Original-Authentication-Results: suse.com; dkim=none (message not signed)
 header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT004.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	c99272b5-51f1-43b3-3c31-08d992f427ea
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	E0EgcgIkcMoqU+dy+99LREeoiqnKQSyeu7XbpvwWf52dmmi4hkdGa9GsMgRzlMg3b2XmUFinB051J6DeGkkgM+6IXL2IShvmN4AjLGez4g6VLipl/iX1HV0RZLkrCDUgA4OXJ6pfBcLYQ9PLNGx5gkuIJSOTOt9MPn960A1FQpBgyLtAmOzCQZ8JKrGbTtirEFCPCLEXBoNtfyitme5hbY88NIfcorgGGj89RHlUa72sQGFvsM59472C/i1zj4eH9QqshhEfmk1mahS/YYDmweF+mPigPVf/QER9Fczen4bBZu+NDo2D7o0kkY9mtGOdo+rMJrOvxFXx57jBZF46am+yF6ofLZoEEDbfwxE34yOED8HDNUnGyFdS/26rvxUKFwId3Nn2oh/bPewyJqL+yv5l3hdu1yvtTfRSfOCabZew4CDsmC6flfP1lDladUBeYHLQHSvlyz5006cIhpDBRpwfN92xOuAxWkRuwTZM9ltvjbu8Ze8F0d9z7PdKv467zYn21eyvPPTKCVBOxhGIxZ7FBJGfu24acRIg0xeRRkH7/wVDDyGiuKwMAlFpLn1dJOYQPLN78wTwm72pXRusAaaIiW5Rm4DNT5ocGnxrUe0XhD/kRuymwopEdAqemg4Uu6Tyuo0fgGEDrYPABqgwQp/InVi2OAX/CiTr4M3Uj5gMce5fd4aU2QT9yd3dP3RiueXTxiNiaIiOROsvqpQiOg==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(54906003)(316002)(336012)(82310400003)(36860700001)(356005)(186003)(70206006)(86362001)(6862004)(508600001)(8676002)(36756003)(2906002)(2616005)(6486002)(33656002)(4326008)(8936002)(70586007)(5660300002)(53546011)(81166007)(107886003)(26005)(6506007)(47076005)(6512007);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2021 11:33:20.5487
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: e4642ebc-218e-495a-154f-08d992f440c1
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT004.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB2846

Hi Jan,

> On 19 Oct 2021, at 12:25, Jan Beulich <jbeulich@suse.com> wrote:
>=20
> On 19.10.2021 13:12, Ian Jackson wrote:
>> Bertrand Marquis writes ("[PATCH 0/3] Fixes: PCI devices passthrough on =
Arm"):
>>> This patch serie is a follow-up after various findings on d59168dc05
>>> ("xen/arm: Enable the existing x86 virtual PCI support for ARM") as of
>>> agreed in [1].
>>>=20
>>> It does the following:
>>> - enable vpci_add_handlers on x86 and not only on arm
>>> - remove __hwdom_init flag for vpci_add_handlers
>>> - add missing vpci handler cleanup in error path during pci_device_add
>>>  and pci_device_remove
>>=20
>> Thanks.  Roger, Jan, what do you think of this ?
>=20
> I'll get to this, but at the first glance I'd say that the change in
> patch 1 coming before what patch 2 does is already a problem.

Because path 1 is actually introducing a bug solved by patch 2, I should ha=
ve thought of that.

I can either invert those 2 (or actually put patch 1 at the end) or merge p=
atch 1 and 2 together.

Bertrand

>=20
> Jan
>=20



From xen-devel-bounces@lists.xenproject.org Tue Oct 19 11:37:14 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Oct 2021 11:37:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.213069.371182 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcnQb-0004lO-W1; Tue, 19 Oct 2021 11:37:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 213069.371182; Tue, 19 Oct 2021 11:37:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcnQb-0004lH-Sa; Tue, 19 Oct 2021 11:37:09 +0000
Received: by outflank-mailman (input) for mailman id 213069;
 Tue, 19 Oct 2021 11:37:08 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=eXNP=PH=citrix.com=roger.pau@srs-us1.protection.inumbo.net>)
 id 1mcnQa-0004lB-L7
 for xen-devel@lists.xenproject.org; Tue, 19 Oct 2021 11:37:08 +0000
Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 866dfd61-ef8e-41fc-8b68-a2cd69f3fee8;
 Tue, 19 Oct 2021 11:37:07 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 866dfd61-ef8e-41fc-8b68-a2cd69f3fee8
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1634643427;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=HSfpGoXeVyJEdL7j5tcb3qMmIqIlOMQEDb5NeQ3l6FY=;
  b=PbJ2dcavGNbXGe9wVT8EYVgX+kFVo/s5LLQuyB3nhwXZtWUZvW97g2PN
   elCVhzcmaRbFALXK8YaxquYGcHJ1LatevnOLt+/Y5KORmnKpXAfFNdz1u
   a8tV6tVSmir1A+3puFB2WXoBZY1WIvcGPrvkKHryaUPzlZWtNtccB4Uow
   w=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: MsvtQEcZiY7MK5kqZ+WDFIh0RaTsNGQJBx9KPgRxXOi3jAEyb3Y3B7yMwwVJLL9JjOG04mLZtM
 LYkNETM6We4b27lTDaJNecVsI5eMMxjo0D4wYF+D27jn/Abc8XURRCIZOPryPd1Gcr20i/fyT0
 OH5tvUH1PWMIUUjB4IP5hE2FP8zskxCv8njrw+GSbLWh8FIMGpJGWfvZ7lEASxQWo9AgCAEg/e
 g3WxaMbRc/zSO2Ziqii0q3HeNbDYXngsB+1e7pPmkK5V5ArT7R4cVunrED0Qj5vacvXY07fbk9
 GaL9NE5pFLPDT8xthCAHU0fp
X-SBRS: 5.1
X-MesageID: 57420634
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:yalfCK//HxxAoSj9fS0jDrUDWHmTJUtcMsCJ2f8bNWPcYEJGY0x3x
 zZOUGnUafeDYGX0eNskPo62p0IHvcLRzYM1S1Zq+SE8E34SpcT7XtnIdU2Y0wF+jyHgoOCLy
 +1EN7Es+ehtFie0Si9AttENlFEkvU2ybuOU5NXsZ2YhGGeIdA970Ug6wrZg09Yy6TSEK1jlV
 e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH
 I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPhjw
 utV7rDoRzt3FYvuuu1BVUhfTTlXaPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us
 6ZCcXZUM07F17neLLGTE4GAguw5K8bmJsUHs2xIxjDFF/c2B5vERs0m4PcFg2tq3p4VQZ4yY
 eIfaDgxNgT+PydRK1goLKgzwf+Rr0jWJmgwRFW9+vNsvjm7IBZK+KfpGMrYfJqNX8o9tlaVo
 CfK8nr0BjkeNceD0nyV/3S0nOjNkCjnHoUIG9WQ9PRnnVmSzWw7EwANWB2wpvzRt6Klc4sBc
 QpOoHNo9PVsshzwJjXgY/GmiGyOgAZHd4JeL7MRziOvw/bSsgHHHkFRG1atd+canMMxQDUr0
 HqAkNXoGSFjvdWpdJ6NyluHhWjtYXZNfAfucQdBFFFfu4Cy/+nfmzqWFo47eJNZmOEZDt0ZL
 9qilyM5m6kIxfAC06G27DgraBr9+8CXEGbZCujRN19JDz+Vhqb5OORECnCBtJ6sybp1qHHb7
 BDofODFtIgz4WmlznDlfQn0NOjBCwy5GDPdm0VzOJIq6i6g/XWuFagJvmoieRczbJ5eJ2a5C
 KM2he+3zMUDVJdNRfQvC79d9uxwlfSwfTgbfqG8giVyjmhZK1bcoXAGib+41GHxikk8+ZzTy
 r/AGftA+U0yUPw9pBLvHr91+eZymkgWmDOCLbimnk/P+efPOxaopUItbQLmghYRt/jf/m04M
 r93aqO39vmoeL2nM3eGodBJczjn7xETXPjLliCeTcbaSiJOE2A9Ef7Bh7Qnfo1uhaNOkenUu
 Hq6XydlJJDX3BUr8C2GNSJubq3BR5F6oS5pNCAgJw/wiXMifZyu/OEUcJ5uJesr8+lqzPhVS
 fgZeprfXqQTG2qfozlNP4PgqIFCdQiwgV7cNSSSfzViLYVrQBbE+4G4c1K3pjUOFCe+qeA3v
 6akilHAWZMGSgk7VJTWZfujwkmfp38YnO4uDULELsMKIBfn8ZRwKjy3hfgyepleJRLGzzqc9
 gCXHRZH+rWd/95rqIHE3PnWoZ2oHu1yGlthM1PatbvmZzPH+meDwJNbVLradz7qS26pqr6pY
 v9Yzq+gPaRfzkpKqYd1D51i0bk6u4n0v7ZfwwlpQCfLYlCsBu8yK3WKx5AS5KhEx7sfsgqqQ
 EOfvNJdPOzRas/iFVcQIisjb/iCiq5IymWDs6xtLRWo/jJz8ZqGTV5WbkuFhyFqJbdoNJ8on
 LU6s8kM5g3j0hcnP75qVMyPG7hg+pDYb5gaiw==
IronPort-HdrOrdr: A9a23:T/NSGa5xq73WXTizMwPXwVmBI+orL9Y04lQ7vn2ZFiY7TiXIra
 yTdaoguCMc6AxxZJkh8erwX5VoZUmsj6KdhrNhQItKPTOWw1dASbsN0WKM+UyDJ8STzJ856U
 4kSdkDNDSSNykKsS+Z2njALz9I+rDum8rJ9ISuv0uFDzsaE52Ihz0JdDpzeXcGIjWua6BJcK
 Z1saF81kWdkDksH4mGL0hAe9KGi8zAlZrgbxJDLxk76DOWhTftzLLhCRCX0joXTjsKmN4ZgC
 f4uj28wp/mn+Cwyxfa2WOWx5NKmOH5wt8GIMCXkMAaJhjllw7tToV8XL+puiwzvYiUmRoXue
 iJhy1lE9V46nvXcG3wiRzx2zP42DJr0HPmwU/wuwqqneXJABYBT+ZRj4NQdRXUr2A6ustn7a
 5N12WF87JKEBLphk3Glpj1fiAvsnDxjWspkOYVgXAae5AZcqVtoYsW+14QOIscHRj99JssHI
 BVfYDhDc5tABGnhk3izyxSKITGZAV2Iv7GeDlNhiWt6UkUoJgjpHFog/D2nR87hdsAotd/lq
 L52gkBrsA7ciYsV9MOOA42e7rANoX8e2O+DIusGyWTKEgmAQOHl3el2sR+2AmVEKZ4u6fa3q
 6xCW9liQ==
X-IronPort-AV: E=Sophos;i="5.85,384,1624334400"; 
   d="scan'208";a="57420634"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=NOnuhL9DxXdWN6sKceOOinYTcXi3arOBEEVEOxvWL3d3aBiizy7vHrNFwown32sK9mpJQexn7cDZU418L47ZAqe36LhHqF0RiNzCplnh38z4Z9AJsY6PcrzRsauv1kbgIjku9BtKzTbcbQbFmzyqd/KXkqpFg2HfGke9a4S2PMe+zNza26R6Tpfvj/s2rWjErwVKGjPDq4uWAqPtsbvuAgkOLY+mcCjrZ5yy8kPv8it1xuQEGC+VtOB6iF9K2kKgtSaJWwI0paVclA3nCzo6mfTjoOd3wF3pGTSrDXQkoiSdX3YEnpNcKBAlqvPAC/dUIvJsxGBfCLbuVOt4S+FmRg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=P3yHQn77J5vmNOoEagConE3GW2TdYHmSAj2N2zafRxA=;
 b=AJhYou6vLXc47zy1UEPzOElrdnvC2Ofqf2cxnVjaqZBPxEpz6eTrPuSJOSGBbvoBS8+F14kyjrZtjpDI5DNycuD4EypWDQwJCRjdPgWHAQpu4HWYsZjOZMnrayO58fzDMmAZ1PheOFeF68oT+b5h6Av5KsIUBp5/aopfYQscIJiMM3zIu56pG7p43gOm7Cq3twMMwfJOGf2sRS/jZK9tHrRHb2YQb8XN131MBgUDBmJZaePK8ZqBBMpOO8gPN8lO6ndBxI+5w1Yi7MFf1dyW62seO4pntnVaLdhVnu75XwKMtGmPcW6T7nuYa8f5IbC7Ig+yt9JhbjUwU3qlsUQg4g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=P3yHQn77J5vmNOoEagConE3GW2TdYHmSAj2N2zafRxA=;
 b=rkVyIczwUgjyxSwL3hVYnILiYlgbOsyoHZm5BRLD9YODsAGkyuZhReMYaAZ7rooeIE/sNsAEJTwLXdYc4Vr4xVmmAo0CKVXfZgeL9oZTGmnq1m8P1OmrFbg4qh3LiXxDeURqNKbBdjx7MIWqQDDWqBoMz3rCxTZBH5B8NItrh1U=
Date: Tue, 19 Oct 2021 13:36:39 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Andrew
 Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH 2/2] x86: de-duplicate MONITOR/MWAIT CPUID-related
 definitions
Message-ID: <YW6tx43rw1SEo4fY@MacBook-Air-de-Roger.local>
References: <9963c7a2-f880-66fc-8f12-b1ddd0619c91@suse.com>
 <b809979b-5d43-482b-921b-65a4e203db2f@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <b809979b-5d43-482b-921b-65a4e203db2f@suse.com>
X-ClientProxiedBy: LO2P265CA0215.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:9e::35) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 4438aedf-9d41-4689-4b37-08d992f4ba02
X-MS-TrafficTypeDiagnostic: DM6PR03MB5337:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <DM6PR03MB53379E82F885270C2FB7DECE8FBD9@DM6PR03MB5337.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:2887;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 2tRSYT/ZDgl/sHeg6ivgYvgMCWSsA41agb3NW3sWd3zKfuqz4chaoXSxLz5oqafZfV2+g+hVNaqsK/IsDKFHD0Q2DBLtv5awjWiOI6qMkYsH6yZtLoQWXIWU5yTDV8Xnft5/kIplTykAn9fMkWX0rwvipSTPA147BBxIbGgrEaretJXgeayoJqg+IACWV8uk6iBWGWaQSyr6SvxIL/qPbvio1/Tq2tkVt+yYMRZF0B63iPWl+aqowYbOMbrMWKEYzmQCcYZVyaIjkcW5rUR8FWDTPH9BH29w+kJ+JEYyK5ful9F+Ho6/NdsJBcB+vWfJhGKU+sdkSqIEchmWZkUf8eCXMMTTrgip+jWUhBsEiK4BuewYzpEwhwsd2JD7wPDdigf06fctmo6dJzDTxTeIQ7QOexF3AtLSAH0qr6mMT0R7BMVxx9feOi1Sg18l8ZA7P+QHWwbe/GYCMbIbOckDhARKJJnAmNPBsNL/yR+vqYIDMgHhg2FcSAdAAkSX9888p7p3QM7Qvy9fWTywkiE2BaoiKOQ3ug7/lylDF0C/En2hKRsF6Z3WfTBkKb6WHexkcZw1EL0iULyC8UBI5EwmRqN1cfVH1WYuoc5OqsGjqSSbOPXv+BQiILdLW+YbyOBfZtZT4cWAo6BCYmHC3D+vQQ==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(186003)(508600001)(26005)(6666004)(8936002)(6496006)(66946007)(66476007)(4326008)(8676002)(5660300002)(82960400001)(6916009)(86362001)(38100700002)(66556008)(9686003)(2906002)(6486002)(85182001)(956004)(316002)(54906003)(4744005);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bWUrdFJ5bmlkTHBGb3hackZmVkpkKzNpLzFxOC9CbS9uTTVYTWxuRDNwbTVx?=
 =?utf-8?B?TkcxWkUzdndqWGg1QnljdkxockZsS3FGRDR6b29uSk5wUEk4NGlabEVhZUQy?=
 =?utf-8?B?TjlEVjZ6WUZzUlNrUjZSUGluMTR5WTVYUDNwT1pHUnlMOUVyZ3NzNlpISGk0?=
 =?utf-8?B?cWVsSkYzbUZHMXFhdTZQa2xlSjlQR1JXWStCckVPUWRKNmFPUGgrMkJXY2xN?=
 =?utf-8?B?LzdESFhLV0tEOUxmV29UaEFhWUhCNlE5aXpkL2NySC8rU0ZYZTB4clRsaitZ?=
 =?utf-8?B?M1VMLzJ6WGNEbzlTT2YrUm0zZTBWaTB4MCtzRkZMcWp5cWFhWjJzK0NXNzc2?=
 =?utf-8?B?WGdseERTQXZkdXVHRVNtTjE0cmw0UU9QTmhYeHpidFhnT1hMSStYT3hXZzVX?=
 =?utf-8?B?QVFqUHZOdmE2MnNUZzJqZjJBZTByREYzZkx6V1Vpa0s5MVVnTSt0N0VhbkFk?=
 =?utf-8?B?WXhFT0dJQ3BRNXQ5K0hreU56SUVyalBnWmdWNHlNMWhjVFFPRi9HRi9FU1ZZ?=
 =?utf-8?B?dWFFWWV1YlhwK0ZKaEJKUmdlaFhvdkhXSlUvR20vS1FHK3FQbkhBZ0RrUE9o?=
 =?utf-8?B?Z3lTK0w5bm04NUdvSGdsVGVaejBxTDVGdFJtbzc0SytKaHJFcU5DbW9URHNp?=
 =?utf-8?B?TXBlZzJWbEovZnBXZTZpZWFGVzkxOFBjZnJMZ3FDTVZUcVNzbVYycHhJTXpy?=
 =?utf-8?B?QVN4QmI5SStnWWluTVd5K25nMUM1Q0ZzRktZTS9sOWE0Rmk5cm9KZDg2VlNC?=
 =?utf-8?B?eHNwd0NDVkIxdEZXcytGUGhaYm4rY2J6am04a1Y1dkF6TGRUMFd6OXNCK2Yr?=
 =?utf-8?B?Z1o1USt4dG9CZkZXbmtLYUM1S3NTLzdvMXRxbTJ4YjBkV0NYSWdQZFFUWGVn?=
 =?utf-8?B?Q0tHQVJzdnNaZiszWWZFcmRJdDB2ZjJRT2s0MkNxMFBpTWRzVHF2SWdZckxu?=
 =?utf-8?B?bnBHREVaNUh2bUN2aHlOeXdHR0F2OHR5aDdhVkMyWWszUEVZdStIUC92RzFt?=
 =?utf-8?B?Q1l3ZTcyak93QndNOCtFZjJ1V1RxNjlxeU1BbnNLeWd4K3MyY29aSTJBRmNL?=
 =?utf-8?B?WVJuN0o1aGp1cjlHbmhZaGw0U0YyWmlkdVRGc3M2SzJRa1dQdFVJZVVYQisv?=
 =?utf-8?B?cktUelRxOXFiTzU2T1NKM0Y2MVdBRkZXNjV3SEVYdG9QWmwrWHA3cjJXSGU4?=
 =?utf-8?B?SGdWOVRjUWxqS3FiNStPRG13MU1iV1J1cHdPSnE3V0wrenRBQStyMFpVYjA2?=
 =?utf-8?B?S1UxTGI4S1BFSkRHZnN4WVRwblV3NHJMazlJSkRWeUk3MmJ3cjFhdVBveHM0?=
 =?utf-8?B?dzVEQlNQSWVaTFV0aHNPWGl2M3JaU3pyNmliVmg4aHVKWWpBbWhRWW5PQ01w?=
 =?utf-8?B?Z0RLeHhwTXZncEE1cnJtTXVnQnZtNE55eVVjM3d4U2Ewa1JOYis4OVlYTkw1?=
 =?utf-8?B?VWx3RHZEZ3orMlZOaXJ6SkxMOXFvend5VmZQU1R0NW4zeWhBeXlSM2srNUps?=
 =?utf-8?B?MDB3enl5ZG1uM0RFRmlvRW5xeHB3N0pISWRMRlFGSXREN044dEVZL1BxVnd4?=
 =?utf-8?B?UkJRSlNWUGYxcGpXZmsyYjdYLzBNVmVuRThNRVc2MWZoMStWUDltelB6UnM0?=
 =?utf-8?B?Sk1NM2JUK2FSTDA0QkR5bW9aK05jTEdUMnNEYXZuUWVxUFJ4dTZzdVFWSlFL?=
 =?utf-8?B?NUIrbkI3cFplUnUvTlQ3OGl0TWxxclI5cVlobTh1Wk5DKzl4c1ZzSTNIZUpH?=
 =?utf-8?Q?ifA9wKHNVBy60cRm6rNaf6jKJJ0jeYGf4VfUCUG?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 4438aedf-9d41-4689-4b37-08d992f4ba02
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2021 11:36:44.0780
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Q9kj/65VqHAlvNIAwIy0ihpts1xCPNnxw2C6HpDuQLCu7HvDTvv1DgBPIpbUko7Kgtmu9e6iFm+LMdvWCOBSJg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB5337
X-OriginatorOrg: citrix.com

On Tue, Oct 19, 2021 at 09:08:22AM +0200, Jan Beulich wrote:
> As of 724b55f48a6c ("x86: introduce MWAIT-based, ACPI-less CPU idle
> driver") they (also) live in asm/mwait.h; no idea how I missed the
> duplicates back at the time.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Acked-by: Roger Pau Monné <roger.pau@citrix.com>

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Tue Oct 19 11:58:53 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Oct 2021 11:58:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.213081.371193 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcnlW-0007C1-Q2; Tue, 19 Oct 2021 11:58:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 213081.371193; Tue, 19 Oct 2021 11:58:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcnlW-0007Bu-My; Tue, 19 Oct 2021 11:58:46 +0000
Received: by outflank-mailman (input) for mailman id 213081;
 Tue, 19 Oct 2021 11:58:45 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=gzZp=PH=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mcnlV-0007Bo-Im
 for xen-devel@lists.xenproject.org; Tue, 19 Oct 2021 11:58:45 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id e8440162-30d3-11ec-8310-12813bfff9fa;
 Tue, 19 Oct 2021 11:58:44 +0000 (UTC)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2105.outbound.protection.outlook.com [104.47.18.105])
 (Using TLS) by relay.mimecast.com with ESMTP id
 de-mta-22-JWtOaqJwMuOJ__xEu6-qAg-1; Tue, 19 Oct 2021 13:58:42 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VE1PR04MB6477.eurprd04.prod.outlook.com (2603:10a6:803:11e::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.17; Tue, 19 Oct
 2021 11:58:40 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.018; Tue, 19 Oct 2021
 11:58:40 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS9PR05CA0036.eurprd05.prod.outlook.com (2603:10a6:20b:489::20) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.14 via Frontend
 Transport; Tue, 19 Oct 2021 11:58:39 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e8440162-30d3-11ec-8310-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634644723;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=e3t5qAKT9NWcAOGqvmaO/tEUOVCc1dM24pv3gFcBevs=;
	b=jjjSb0yS3bnqoELdHMp/+x3ua8MFJrkgVR9n0J5TDDC+CZkBM8smZ87kAAYiPtBuLHI6eJ
	MUPJ0alOgjrDIhb7sZBDKwveZUCz4Gr5Bcjnqbj36AdrIWJrY5hsXbCwbaIdhHmLP7Jkmp
	AazSG7WYZ3IsTPl38u4PYnEgFRhhNm4=
X-MC-Unique: JWtOaqJwMuOJ__xEu6-qAg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=j85tR9HGhBnQWOeBcNcMSMW2y3WSoWhl/pYtpu+J/2tYSMusjitli+zf0uI8hFmf5JE8t+Vitb5Mcs/A6/NHzTwqAs+hf91ty7IHu3Hthpc+F9Cxi7Lvvvc6awvbzR2QUrj1xqo5m9XSnC+VsQ0by0XjFnL/NOseeXKorXhVYN8Li7nS28ghm5xyE0MdNPsw5PPxSzHmppiVetTRHQ1QFslLTlbb4sWEPsqOw1kRsZu68ey7lLMenrpvHAHL5ndwsVyIZaC1Oci0m1xqr1OhcX5aatIsrDEVdccAqsAw1IzPFd0CDRybEBkyAThVIAOaGFIA3DfrSxCJQ8wpQBHKew==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=wgyosl3QygnUlkHnRHQyRCmYyM6G4bogLBtPNqF/C+c=;
 b=GOsfBdvQNetY/1IMeGM67240mCYsatjuMpLqPCJDQKJufCi0treUlo4/2HqL/f67RtmpG3/feP0InRtkYX3riyG3McX9H3BRgQiYBilnqvWBIPSmbZ3inv7vdo4/gO9fQm5qAdRzqJdrytpk2fPWKsPIaLa8BLQQjB4Gu6acGC5HRBshMFjSnYOyG38gdO4YnLQUT9FQTr0g2zyMCt1OEtyzToylrrVdfjtuMlKkE3Qvf6KKLAxLFJ3W9Q3PIrXORubBCv3WjefocYWNB0YR/U6sW5uXFptELoYC9tvHuxYaL4jiPGTZzrRBSbfcnaDeF3ANoVqWEYUj/9KcoKHp7w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: citrix.com; dkim=none (message not signed)
 header.d=none;citrix.com; dmarc=none action=none header.from=suse.com;
Subject: Re: [PATCH] x86/PoD: defer nested P2M flushes
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>
References: <e47d51c6-1b4b-2f72-6e12-070df66c30e2@suse.com>
 <YW6g9w9XeWKsxYMV@MacBook-Air-de-Roger.local>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <9e444a8b-58e9-ea37-0e22-474e430be5e5@suse.com>
Date: Tue, 19 Oct 2021 13:58:38 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <YW6g9w9XeWKsxYMV@MacBook-Air-de-Roger.local>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS9PR05CA0036.eurprd05.prod.outlook.com
 (2603:10a6:20b:489::20) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 7ce63965-45d0-4545-c1ad-08d992f7ca88
X-MS-TrafficTypeDiagnostic: VE1PR04MB6477:
X-Microsoft-Antispam-PRVS:
	<VE1PR04MB64770B72B4DCECB5AC1E93A9B3BD9@VE1PR04MB6477.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:5236;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	wWjD8Hf8g8Ck5gMMj2lwkOV1KmpiMGDudPW96BkAXHSwoqO92gf+b0Xr3lzkHTKmekVYEG1igKqBGWOGKo7o0F352wa2qG/IRMCox1FP+Ue9JmkLFYPUWhn1ttfyNQ5sCgKNsOBc6IGN/VU6g1oniqu8KwQyV7KIJq61YGKpjssPuXbDyPGOcaAlcN5EO2ZKQWC6duWjn6p5S7PDGkwD1QW3MkEBENXeFLNJ+II9rijsCDg60DM25q7FStP8wxX8R0Fk/kY4bfO//RUe9t/LyZRS0m3VG+Nw/5ANJCvj2xc4RUeWSnHQAwvZPmgHGsKkzO1aWHY3zpIivgIbWHMOHZID+XKaXKNHqQMR2lUGNJZeRB2bWHi8KxLca0FZpKIh2U7gMVFCLPYu/IKIGPKDEr05efB/VYRNsyjscRPH1R8XO5Rb/tyChpWklif+JEe2/tKST8r8ohQQ1kzMOcvQzMkYlYP8FvEVVbHPCyYCGAWF2MlyCPy/3AzmLt0Eal4eyZHkicX7UMRAYh21PUyOBm7qYici3wqFq3lzQgSAua+W4MRAR++i5bk8vQc2Tkp4C2myCA+dt81Yy7u9trFU9oGgNu9/m43fFAo9WEqjvleWrHnYEDWUwUjBqLBEulbG5oC6E2m0yt2xSmf2oPxCSadmYAeDkAQdR2bUNFBxUPn9zNS1++EYuXErUUpLv+zW7X/Bax5EWiJRWJoTP5gXgwKcMLcZNfXW9wOX2yNL2Pw=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(2616005)(8676002)(66946007)(66556008)(66476007)(86362001)(508600001)(956004)(31686004)(53546011)(5660300002)(6916009)(26005)(8936002)(83380400001)(186003)(38100700002)(31696002)(6486002)(36756003)(2906002)(316002)(4326008)(16576012)(54906003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?929CfyPDD9i1gJVwtKaKG3nK0fhgEqmvbGXnA5tnbIfzvLxlpDZGVfwSj6KT?=
 =?us-ascii?Q?fS6lQzMpAxmj8HoU3r9HtEsJY9Lv3VA1wleeCR8nPzsdzBqKKcFz5dvegb86?=
 =?us-ascii?Q?D4Q/4eSB6INekZdzq4SJonei81cInl8u/7V3xBs6dUr2cp2ijivIepyBX1rl?=
 =?us-ascii?Q?u6UYbKSnMSKBUnYd1wewml929PKlwCMwL7HK9Bbyjoi1YZi1asriCPr8idlv?=
 =?us-ascii?Q?TaUchsHQkccljLtaGf+ZZXXYvY779aTTVD4+6vvAzI5WPNG0AquspU4SIRfn?=
 =?us-ascii?Q?oVPlabh1y8HzUMkb/bG9DizE8pzZ+lmN7QHp6Pq3VNkX+Ug8DRSQXX3SzN1E?=
 =?us-ascii?Q?tdl824P0vNees9jKhn3MHtAwrBfeiNKXimh4l/ocGGht82soIDzwSnErFi1r?=
 =?us-ascii?Q?gIYyV/Mg6UevcbdSvRRy7LWfFIHi57oiyGeX0mUxMcNrr/gz3OYEwasSj6I6?=
 =?us-ascii?Q?deGyr+FZcXzH/foVjbYacoDia2xULhJg9VGZ7XqCJtEKkrU7A/o+2N+3Ex7u?=
 =?us-ascii?Q?xT042f8+JDFbWk7sX1fjXRidre31oDlnNwPoJesaVE8J76cxqLh92CRGbmH9?=
 =?us-ascii?Q?Vy2WWELBQNelqfXDz3sfmfYJM7hu4rPgaBmljzOcvbOceC+BxMjRaWn38njG?=
 =?us-ascii?Q?lXDrjpkcIHhpH/vVQ+IBMAZ6/pM9ZMIc38c6GDghp7+GDkOJOZyIzTAf33n6?=
 =?us-ascii?Q?TyNnlYWZ01o52ZDM2TCeHZseNcgJZFfT6WWdykmiQLMY8U/qptW7c2XGOdeh?=
 =?us-ascii?Q?LvrEe/k+o7sxu6xhFVYy5ZJOEw9xUBtzlT1/k9ael2AjHyUKX0ghsFqRbVSE?=
 =?us-ascii?Q?e90XGKRJs+78bqvOElCb3KP2g3oO82ZkiVKg/LB1Qf3acZ4EPneUxSsukrnd?=
 =?us-ascii?Q?AQjmKVjSXQfMMtUY9nJxKY89GAiEpTBvvixVxs2mxyNfIELgzXmDOUw5FjrJ?=
 =?us-ascii?Q?F7NU/H3CCTd1r/hjs9hXYulB9TVlH4dqFJ7KgEwMCHDYWZYI0jaQb1k9T/0o?=
 =?us-ascii?Q?/T5haOVzLQvbTxWwWp1VW9H5LAwQbEH5X/A0a+gIFislCP8b94715DMf7YOI?=
 =?us-ascii?Q?bMiwbyF6XxBvOsqC4zStbo23dPoC5RvkWOqshugfAVcitszCiteJxGG8i+HG?=
 =?us-ascii?Q?3Wk+l5qqoC9JYGM0RHJ8O0LbEVh6RtMklguj4bhA98YwKuMM8x2YTKiTzqWO?=
 =?us-ascii?Q?iZL4LI88WKzoOTJfp8T3BRNz+GekP5e7pOYvTym+cLHb3FYwb0s0h4KN2U7y?=
 =?us-ascii?Q?MvdHVXfOkEaTR8XPdiy8DbF1liACdrwQ/OYPnq1IqlfXRZT5OGrrPpigv2K9?=
 =?us-ascii?Q?1ZkABwJ67oo+1ZuWdTXF/J5m?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7ce63965-45d0-4545-c1ad-08d992f7ca88
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2021 11:58:40.3612
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: PR1T47Eq6w+ehXkifTeziQMs/xgmvZBiqGWrz5K9AyTUgaJ+stAj/WObk3wFX2OKBgZp94HRspKqI/WHvqm37g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6477

On 19.10.2021 12:41, Roger Pau Monn=C3=A9 wrote:
> On Mon, Oct 11, 2021 at 10:17:08AM +0200, Jan Beulich wrote:
>> With NPT or shadow in use, the p2m_set_entry() -> p2m_pt_set_entry() ->
>> write_p2m_entry() -> p2m_flush_nestedp2m() call sequence triggers a lock
>> order violation when the PoD lock is held around it. Hence such flushing
>> needs to be deferred. Steal the approach from p2m_change_type_range().
>>
>> Similarly for EPT I think ept_set_entry() -> ept_sync_domain() ->
>> ept_sync_domain_prepare() -> p2m_flush_nestedp2m() is affected.
>=20
> I'm slightly worried by this path because it doesn't seem to
> acknowledge defer_nested_flush.

Oh, yes. Iirc I did look at that logic, write down the remark, and
then forgot to add the conditional to ept_sync_domain_prepare().
The interactions with the real (host) flush are kind of ugly there,
though - we then further depend on the ->defer_flush / ->need_flush
logic, which is EPT-only. But I think I've convinced myself that
this ought to work out.

> Maybe the flag should be checked by
> p2m_flush_nestedp2m instead of leaving it to the callers?

I'm not sure this would be a good idea, as there are more callers.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Oct 19 12:04:41 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Oct 2021 12:04:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.213094.371204 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcnrB-0000Pq-QA; Tue, 19 Oct 2021 12:04:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 213094.371204; Tue, 19 Oct 2021 12:04:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcnrB-0000Pj-MX; Tue, 19 Oct 2021 12:04:37 +0000
Received: by outflank-mailman (input) for mailman id 213094;
 Tue, 19 Oct 2021 12:04:36 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=OTOV=PH=gmail.com=ysaikiran1997@srs-us1.protection.inumbo.net>)
 id 1mcnrA-0000Pd-3j
 for xen-devel@lists.xenproject.org; Tue, 19 Oct 2021 12:04:36 +0000
Received: from mail-yb1-xb2d.google.com (unknown [2607:f8b0:4864:20::b2d])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id bac3b836-899c-446b-83fc-62e6e0ad7b43;
 Tue, 19 Oct 2021 12:04:34 +0000 (UTC)
Received: by mail-yb1-xb2d.google.com with SMTP id o134so1891181ybc.2
 for <xen-devel@lists.xenproject.org>; Tue, 19 Oct 2021 05:04:34 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: bac3b836-899c-446b-83fc-62e6e0ad7b43
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=7zJgQhUIQrg5eCINZFMpiDcYJ3sNVsxZp8iHqFYbLzw=;
        b=js0UcFx6NyR6/ckLPQOr19y+i0VRf+uCuP0GNgOaVHa00uV3X/kHt6/Y0XYsBYNE6N
         U75FFplF7ykWyMDxYXHZEcvBDEkbSu4LaKOHDzPNrYoYCEl8Lr0FK/+3OBUMkpBKSzK4
         xWP1iAeXkuJW7Mq7Fg9Ie6mDlO49bHPLudn3dQMnR3XQyA9nMtIz/b1Ighs3je9oJv8g
         0g3YeYnjrM2tSvPT08Hiy1XLgmJEqgRADyRquunZoNlPPjdBNlPL98ZkMkeW9CB7hR4M
         97yMeUoPJCJcFaO5Zk6PYTLAxbRXOPfkehwRIaO4QreX29ADKAMWwmN75NQ15Z30xdvz
         kozQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=7zJgQhUIQrg5eCINZFMpiDcYJ3sNVsxZp8iHqFYbLzw=;
        b=v689kyai3lgM28Lz36VVG68Zl43nAWdCge0bOFpse0CN4Jb1p+CUW9MN+lbqKJaleP
         n2+gkwohu4Y/aD+48+Euzo6Vx6ma97e2897Q7TrmBpFkLwspsEOnRuWJrT/Lh6gfqSjq
         363vDcSA4jfIgFkB3+WDtE4TKgY4jftYfc21QrArJYQoQkC1ndZsWPY5cM806tR3hfUQ
         Y75WrqUrD+vrWQa7EVttGi7MmQ+vF8zSK5Pq2/KsEuwV3nB5y5k3M3/5yxQPkj5lKR8U
         B9fJfaGicvenyT1Uzz1vTUG8I6Oc1wjwpMBsQQBFwaALU8tcLxr9dQD+C/rh6hRu/gLS
         FewA==
X-Gm-Message-State: AOAM531s9tYIQtGjUeDjI+S10bypenYaIR2U79syF210Zzp6tglMsJpx
	1BA6o9ugsUtXaxLznj+ZnvTXAvh9oNQKodYaKTk=
X-Google-Smtp-Source: ABdhPJz0A/ZVOB3B7unfUuxoMUnJrzG9VZBv3Tr3hH8G0FccgmI1whPia2lmM+by22SG6xNpMzhYCgbKWXPuJhHUFXI=
X-Received: by 2002:a25:2610:: with SMTP id m16mr35183968ybm.508.1634645073790;
 Tue, 19 Oct 2021 05:04:33 -0700 (PDT)
MIME-Version: 1.0
References: <33C29853-D896-4E4E-91D3-4D2FA89A9B91@hxcore.ol>
 <eb5fd47b-6bc9-2eec-7f46-9ab9a42c9f1f@xen.org> <CAEsO4uzsCnsTtTmYHAT4NN6=girCY2NHHdAHbH6GG33D7jwe_A@mail.gmail.com>
 <alpine.DEB.2.21.2109131437030.10523@sstabellini-ThinkPad-T480s>
 <CAEsO4uwpiDO2QoqLRTOxpsYM9YSPAsbX0P=gagdEy21pk1VsPQ@mail.gmail.com>
 <alpine.DEB.2.21.2109141825330.21985@sstabellini-ThinkPad-T480s>
 <CAEsO4uyjNs97Cx8n2owDk4kKTVCycji377pm7aXHcPWzeszUTw@mail.gmail.com>
 <alpine.DEB.2.21.2109301942370.3209@sstabellini-ThinkPad-T480s>
 <CAEsO4ux_AqXBeCtbwnPAdnBnVYHTur_2EfcZBTuN4QKCq4ko8Q@mail.gmail.com>
 <alpine.DEB.2.21.2110131711280.9408@sstabellini-ThinkPad-T480s>
 <CAEsO4uxo_A4pEwP6dHK8kvYtKcbSr-ewqX1v-KLsEkyHNLFyUA@mail.gmail.com> <alpine.DEB.2.21.2110141536090.9408@sstabellini-ThinkPad-T480s>
In-Reply-To: <alpine.DEB.2.21.2110141536090.9408@sstabellini-ThinkPad-T480s>
From: Sai Kiran Kumar Reddy Y <ysaikiran1997@gmail.com>
Date: Tue, 19 Oct 2021 17:34:22 +0530
Message-ID: <CAEsO4uzwNHiLEZVEy90uua9YRud=Bmj=EPhzbhyk0tsEai=UQg@mail.gmail.com>
Subject: Re: Xen Booting Problem on ARM Machine
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: Julien Grall <julien@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>, 
	Jan Beulich <jbeulich@suse.com>, Luca Fancellu <luca.fancellu@arm.com>, 
	xen-devel@lists.xenproject.org, kannan@cimware.in
Content-Type: multipart/alternative; boundary="000000000000f50b8005ceb37649"

--000000000000f50b8005ceb37649
Content-Type: text/plain; charset="UTF-8"

Hi,

Thanks for your inputs. As you have mentioned, I tried to boot Xen directly
from EFI, thereby skipping GRUB. I made sure that kernel, xen.cfg and
ramdisk are on the first FAT partition. I still get "All 128 bootinfo
membanks exhausted error". The following link has my grub.cfg config. file
and also the snapshot of the error.

Link:
https://drive.google.com/drive/folders/1o7WT5oB7UsaZBeY5m4mWSidT5NalzvvJ?usp=sharing

I feel that even with EFI bootloader, there's some issue with bootinfo mem
banks and it maynot be a bug in GRUB. Let me know your thoughts on this.

Thanks in advance,

Regards,
Sai Kiran.

On Fri, Oct 15, 2021 at 4:19 AM Stefano Stabellini <sstabellini@kernel.org>
wrote:

> On Thu, 14 Oct 2021, Sai Kiran Kumar Reddy Y wrote:
> > On Thu, Oct 14, 2021 at 5:45 AM Stefano Stabellini <
> sstabellini@kernel.org> wrote:
> >       On Wed, 13 Oct 2021, Sai Kiran Kumar Reddy Y wrote:
> >       > On Fri, Oct 1, 2021 at 8:17 AM Stefano Stabellini <
> sstabellini@kernel.org> wrote:
> >       >       Yes there are other ways but without serial is going to be
> difficult
> >       >       because you are not going to see anything until everything
> works.
> >       >
> >       >       How do you boot Xen and Dom0 exactly from EDK2? Are you
> using GRUB or
> >       >       loading Xen directly from the EDK2 prompt? Please provide
> as many
> >       >       details as possible so that I might be able to spot any
> errors.
> >       >
> >       > I am using GRUB to load Xen. In the GRUB menu, I see two
> options.
> >       > Option 1: Debian 11 with latest Linux Kernel
> >       > Option 2: Debian 11(with Xen hypervisor) with latest Kernel
> >       >
> >       >       Can you provide the Device Tree you are using? If you are
> not passing
> >       >       any Device Tree  binary explicitely, then it might be
> passed
> >       >       automatically from EDK2 to Linux/Xen. In that case, just
> boot from Linux
> >       >       then do the following to retrieve the Device Tree:
> >       >
> >       >       dtc -I fs -O dts /proc/device-tree > host.dts
> >       >
> >       >       Then please attach host.dts to this email thread.
> >       >
> >       > Yeah, you are right. It looks like LInux is booting from ACPI.
> In the bootloader menu, "Automatic ACPI configuration" is
> >       disabled. So, I
> >       > thought that Linux may be booting from Device Tree. I have tried
> the "dtc" command you mentioned. But it looks like there's
> >       no device-tree
> >       > under "/proc". I also tried to get DT info, from
> "/sys/firmware/devicetree/base" . But, there's no info. under devicetree
> >       folder. I am not
> >       > quite sure how to get the DT info, if the Linux is booting from
> ACPI. I am attaching .dsl files, that contain the acpi info.
> >
> >       OK, so it is pretty clear that even if "Automatic ACPI
> configuration" is
> >       disabled, it is still booting with ACPI.
> >
> >
> >       >       Also for your information it looks like Linux actually
> booted from ACPI,
> >       >       not from Device Tree, as you can see from all the "ACPI"
> messages in the
> >       >       kernel logs.
> >       >
> >       >       If you need to boot from ACPI, then you need to enable
> ACPI support in
> >       >       Xen, which is disabled by default. You can do that using
> make
> >       >       menuconfig.
> >       >
> >       > In the make menuconfig of Xen, I do not see any option to enable
> ACPI.
> >
> >       You definitely need to enable ACPI support in Xen, if you are
> booting
> >       from ACPI, otherwise nothing is going to work.
> >
> >       On the latest staging (https://gitlab.com/xen-project/xen) you can
> >       enable ACPI as follows:
> >
> >
> >       # export CROSS_COMPILE=/path/to/cross-compiler
> >       # export XEN_TARGET_ARCH=arm64
> >       # cd xen.git/xen
> >       # make menuconfig
> >       #   --> Configure UNSUPPORTED features
> >       #   --> Architecture Features --> ACPI
> >       # make
> >
> >
> > Hi
> >
> > I got the code from Gitlab and installed it, enabling ACPI support in
> Xen. As I reboot the system, I am able to see 2 options like before.
> > Option 1: Debian with latest kernel
> > Option 2 : Debian with Xen
> >
> > I have selected Option 2. I did not see any bootinfo membanks error.
> However, there is the following error in GRUB(just for a fraction of a
> > second).
> >
> > "Using modules provided by boot loader in FDT
> >   Xen 4.16-unstable (c/s Wed Oct 13 13 13:28:43 2021 -0700
> git:4cfab4425d) EFI Loader
> >   Couldn't obtain the File System Protocol Interface: ErrCode:
> 0x8000000000000002"
> >
> > I have enabled earlyprintk. I do not see any messages in the Serial.
> There seems to be some problem with the gitlab version of Xen.
>
> The error comes from xen/common/efi/boot.c:get_parent_handle
>
> Xen is booted as EFI binary and it is trying to load other binaries
> using the EFI File System Protocol Interface which is one of the EFI
> Boot Services.
>
> A wild guess is that somehow Grub is calling ExitBootServices, which
> closes all Boot Services interfaces, before executing Xen. It should not
> happen if Grub is executing Xen as EFI binary. I cannot explain how it
> is possible. It looks like a bug in Grub.
>
> Can you post the Grub config file that you are using?
>
>
> Usually before Grub there is the proper EFI bootloader, tipically EDK2.
> You should be able to boot Xen directly from the EFI bootloader too,
> from its prompt, just by executing "xen". You need to place the xen
> binary in the first FAT partition together with a xen.cfg config file as
> follows:
>
> ---
> options=console=com1 com1=115200 loglvl=all noreboot
> kernel=vmlinuz-3.0.31-0.4-xen [domain 0 command line options]
> ramdisk=initrd-3.0.31-0.4-xen
> ---
>
> options is to specify the Xen command line.
> kernel is to specify the Linux kernel to use and its command line.
> ramdisk is to specify the Linux ramdisk.
>
> Both kernel and ramdisk needs to be on the FAT partition too.
>
>
> That way you skip Grub and you might be able to skip any related
> problems with ExitBootServices.

--000000000000f50b8005ceb37649
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi,<div><br></div><div>Thanks for your inputs. As you have=
=C2=A0mentioned, I tried to boot Xen directly from EFI, thereby skipping GR=
UB. I made sure that kernel, xen.cfg and ramdisk are on the first FAT parti=
tion. I still get &quot;All 128 bootinfo membanks exhausted error&quot;. Th=
e following link has my grub.cfg config. file and also the snapshot of the =
error.</div><div><br></div><div>Link:=C2=A0<a href=3D"https://drive.google.=
com/drive/folders/1o7WT5oB7UsaZBeY5m4mWSidT5NalzvvJ?usp=3Dsharing">https://=
drive.google.com/drive/folders/1o7WT5oB7UsaZBeY5m4mWSidT5NalzvvJ?usp=3Dshar=
ing</a></div><div><br></div><div>I feel that even with EFI bootloader, ther=
e&#39;s some issue with bootinfo mem banks and it maynot be a bug in GRUB. =
Let me know your thoughts on this.</div><div><br></div><div>Thanks in advan=
ce,</div><div><br></div><div>Regards,</div><div>Sai Kiran.</div></div><br><=
div class=3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail_attr">On Fri, Oct=
 15, 2021 at 4:19 AM Stefano Stabellini &lt;<a href=3D"mailto:sstabellini@k=
ernel.org">sstabellini@kernel.org</a>&gt; wrote:<br></div><blockquote class=
=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rg=
b(204,204,204);padding-left:1ex">On Thu, 14 Oct 2021, Sai Kiran Kumar Reddy=
 Y wrote:<br>
&gt; On Thu, Oct 14, 2021 at 5:45 AM Stefano Stabellini &lt;<a href=3D"mail=
to:sstabellini@kernel.org" target=3D"_blank">sstabellini@kernel.org</a>&gt;=
 wrote:<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0On Wed, 13 Oct 2021, Sai Kiran Kumar Reddy Y=
 wrote:<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt; On Fri, Oct 1, 2021 at 8:17 AM Stefano =
Stabellini &lt;<a href=3D"mailto:sstabellini@kernel.org" target=3D"_blank">=
sstabellini@kernel.org</a>&gt; wrote:<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0Yes there are=
 other ways but without serial is going to be difficult<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0because you a=
re not going to see anything until everything works.<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0How do you bo=
ot Xen and Dom0 exactly from EDK2? Are you using GRUB or<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0loading Xen d=
irectly from the EDK2 prompt? Please provide as many<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0details as po=
ssible so that I might be able to spot any errors.<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt; I am using GRUB to load Xen. In the GRU=
B menu, I see two options.=C2=A0<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt; Option 1: Debian 11 with latest Linux K=
ernel<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt; Option 2: Debian 11(with Xen hypervisor=
) with latest Kernel<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt; =C2=A0<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0Can you provi=
de the Device Tree you are using? If you are not passing<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0any Device Tr=
ee=C2=A0 binary explicitely, then it might be passed<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0automatically=
 from EDK2 to Linux/Xen. In that case, just boot from Linux<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0then do the f=
ollowing to retrieve the Device Tree:<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0dtc -I fs -O =
dts /proc/device-tree &gt; host.dts<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0Then please a=
ttach host.dts to this email thread.<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt; Yeah, you are right. It looks like LInu=
x is booting from ACPI. In the bootloader menu, &quot;Automatic ACPI config=
uration&quot; is<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0disabled. So, I<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt; thought that Linux may be booting from =
Device Tree. I have tried the &quot;dtc&quot; command you mentioned. But it=
 looks like there&#39;s<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0no device-tree<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt; under &quot;/proc&quot;. I also tried t=
o get DT info, from &quot;/sys/firmware/devicetree/base&quot; . But, there&=
#39;s no info. under devicetree<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0folder. I am not<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt; quite sure how to get the DT info, if t=
he Linux is booting from ACPI. I am attaching .dsl files, that contain the =
acpi info.<br>
&gt; <br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0OK, so it is pretty clear that even if &quot=
;Automatic ACPI configuration&quot; is<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0disabled, it is still booting with ACPI.<br>
&gt; <br>
&gt; <br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0Also for your=
 information it looks like Linux actually booted from ACPI,<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0not from Devi=
ce Tree, as you can see from all the &quot;ACPI&quot; messages in the<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0kernel logs.<=
br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0If you need t=
o boot from ACPI, then you need to enable ACPI support in<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0Xen, which is=
 disabled by default. You can do that using make<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0menuconfig.<b=
r>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt; In the make menuconfig of Xen, I do not=
 see any option to enable ACPI.=C2=A0=C2=A0<br>
&gt; <br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0You definitely need to enable ACPI support i=
n Xen, if you are booting<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0from ACPI, otherwise nothing is going to wor=
k.<br>
&gt; <br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0On the latest staging (<a href=3D"https://gi=
tlab.com/xen-project/xen" rel=3D"noreferrer" target=3D"_blank">https://gitl=
ab.com/xen-project/xen</a>) you can<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0enable ACPI as follows:<br>
&gt; <br>
&gt; <br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0# export CROSS_COMPILE=3D/path/to/cross-comp=
iler<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0# export XEN_TARGET_ARCH=3Darm64<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0# cd xen.git/xen<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0# make menuconfig<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0#=C2=A0 =C2=A0--&gt; Configure UNSUPPORTED f=
eatures<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0#=C2=A0 =C2=A0--&gt; Architecture Features -=
-&gt; ACPI<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0# make<br>
&gt; <br>
&gt; <br>
&gt; Hi<br>
&gt; <br>
&gt; I got the code from Gitlab and installed it, enabling ACPI support in =
Xen. As I reboot the system, I am able to see 2 options like before.=C2=A0<=
br>
&gt; Option 1: Debian with latest kernel<br>
&gt; Option 2 : Debian with Xen<br>
&gt; <br>
&gt; I have selected Option 2. I did not see any bootinfo membanks=C2=A0err=
or. However, there is the following error in GRUB(just for a fraction of a<=
br>
&gt; second).=C2=A0<br>
&gt; <br>
&gt; &quot;Using modules provided by boot loader in FDT<br>
&gt; =C2=A0 Xen 4.16-unstable (c/s Wed Oct 13 13 13:28:43 2021 -0700 git:4c=
fab4425d) EFI Loader<br>
&gt; =C2=A0 Couldn&#39;t obtain the File System Protocol Interface: ErrCode=
: 0x8000000000000002&quot;<br>
&gt; <br>
&gt; I have enabled earlyprintk. I do not see any messages in the Serial. T=
here seems to be some problem with the gitlab version of Xen.<br>
<br>
The error comes from xen/common/efi/boot.c:get_parent_handle<br>
<br>
Xen is booted as EFI binary and it is trying to load other binaries<br>
using the EFI File System Protocol Interface which is one of the EFI<br>
Boot Services.<br>
<br>
A wild guess is that somehow Grub is calling ExitBootServices, which<br>
closes all Boot Services interfaces, before executing Xen. It should not<br=
>
happen if Grub is executing Xen as EFI binary. I cannot explain how it<br>
is possible. It looks like a bug in Grub.<br>
<br>
Can you post the Grub config file that you are using?<br>
<br>
<br>
Usually before Grub there is the proper EFI bootloader, tipically EDK2.<br>
You should be able to boot Xen directly from the EFI bootloader too,<br>
from its prompt, just by executing &quot;xen&quot;. You need to place the x=
en<br>
binary in the first FAT partition together with a xen.cfg config file as<br=
>
follows:<br>
<br>
---<br>
options=3Dconsole=3Dcom1 com1=3D115200 loglvl=3Dall noreboot<br>
kernel=3Dvmlinuz-3.0.31-0.4-xen [domain 0 command line options]<br>
ramdisk=3Dinitrd-3.0.31-0.4-xen<br>
---<br>
<br>
options is to specify the Xen command line.<br>
kernel is to specify the Linux kernel to use and its command line.<br>
ramdisk is to specify the Linux ramdisk.<br>
<br>
Both kernel and ramdisk needs to be on the FAT partition too.<br>
<br>
<br>
That way you skip Grub and you might be able to skip any related<br>
problems with ExitBootServices.</blockquote></div>

--000000000000f50b8005ceb37649--


From xen-devel-bounces@lists.xenproject.org Tue Oct 19 12:08:48 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Oct 2021 12:08:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.213101.371215 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcnvD-00017W-B6; Tue, 19 Oct 2021 12:08:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 213101.371215; Tue, 19 Oct 2021 12:08:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcnvD-00017P-7H; Tue, 19 Oct 2021 12:08:47 +0000
Received: by outflank-mailman (input) for mailman id 213101;
 Tue, 19 Oct 2021 12:08:45 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=gzZp=PH=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mcnvB-00017J-MN
 for xen-devel@lists.xenproject.org; Tue, 19 Oct 2021 12:08:45 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 4db01dc9-30d5-11ec-8310-12813bfff9fa;
 Tue, 19 Oct 2021 12:08:44 +0000 (UTC)
Received: from EUR03-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur03lp2053.outbound.protection.outlook.com [104.47.9.53]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-25-fnd0jdfXN36dk8QnpRl3nw-1; Tue, 19 Oct 2021 14:08:41 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB4846.eurprd04.prod.outlook.com (2603:10a6:803:5b::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.18; Tue, 19 Oct
 2021 12:08:40 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.018; Tue, 19 Oct 2021
 12:08:40 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6P191CA0023.EURP191.PROD.OUTLOOK.COM (2603:10a6:209:8b::36) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.16 via Frontend Transport; Tue, 19 Oct 2021 12:08:40 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4db01dc9-30d5-11ec-8310-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634645323;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=KvTy3qpsmaWkToaIQ87YCa1q9h6yaExDR4g721/Z+Qo=;
	b=aPwIoku0lueb6TLCJxhmPn5/STXi5qh2Gq9gjIpuuZzo7peGumKQx+WxBnxqEeEyLtG8xw
	o1SHj+GYVLOueEzHdtZ5En5IBQKpiI4eBs1aEL86aUEaS6t2VvbCLGuPob8KLl5r6APlg4
	yrfa7s46zUvt1Glap/AmI9Gd5ix7j6U=
X-MC-Unique: fnd0jdfXN36dk8QnpRl3nw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=j3tKPMadIpgwYskPYlpHv6HCEWmjYYppeA/uOs66YZA5LdsK8Vfo0oASSpzPCrlF+LkLkOK37A1564VclX9Mmjrg8MkbT4Kj5TOF0gftuoLwXDMXQePlPNm4rjoDUoeuywyoLK/fjjJVeBfeR2SDqUXSKIZZ7EHdektoQUcn2h0c2fArXFtuDwt0kf5M8BaHKxXC542Mx43HWMx4cFiHOLzPE3PUgRNm6lUz9CTmt3yD/wwTcemAkvjLzL413EjX5+hD82f6Tpi7ENJj7wmbOW9zeyKZV8Ym4cXxE4Dq3gw39JoJ/xIAHypyUjSVj1603ydqL5LaVpw2kF2/LgRIIA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=kCdjDF8YVZif6oyeX01pU0Njxv+3yqCRWQgr37al+KY=;
 b=mHW1f8HzhAORCKG+BD0awCdV5nxo+x0/Q1LR5mQj5ZxLb5MrcmagnFxvT9HU5RxNH3vw42ywKqRVq0DLleWttSMuEShHjDNSzYLx0y5ChlADkj1fBY41alCyEeHoQ8uilQ7EBp1OG5UqcLaJVjKd7v2jhkWbLMl773kAei+BQamENAQixAxibzmUir+lyc/Os4j+164mOBpsG8Mo4Y0OMRwwT4XK++YZ9XHZ6Lf7BRW0m1WLR8bO8Jpf0CzHmeXrj6LwuKiLOtA4z1H0y1lPnBpBb9ncNeq/SGEAFM0Yixt+2pyoMJIcDFwh7K4mObv5dkaHdX0EnyOXgGpT8Y0N+Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: xen.org; dkim=none (message not signed)
 header.d=none;xen.org; dmarc=none action=none header.from=suse.com;
Subject: Re: [PATCH 1/2] x86/hpet: Use another crystalball to evaluate HPET
 usability
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
References: <9963c7a2-f880-66fc-8f12-b1ddd0619c91@suse.com>
 <da80b8dd-177c-d27a-9a00-c9538a139d37@suse.com>
 <YW6sSXMyC6t4fB62@MacBook-Air-de-Roger.local>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <3a366ebf-61ed-7e41-193e-131540e555e4@suse.com>
Date: Tue, 19 Oct 2021 14:08:38 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <YW6sSXMyC6t4fB62@MacBook-Air-de-Roger.local>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6P191CA0023.EURP191.PROD.OUTLOOK.COM
 (2603:10a6:209:8b::36) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 0d600918-0575-46fa-4f28-08d992f93076
X-MS-TrafficTypeDiagnostic: VI1PR04MB4846:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB4846CC03418F920FDB2CFA02B3BD9@VI1PR04MB4846.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:4502;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	0von/rjG1JvY7YWQiiGe2rmCtf7gQ1/NBgK5fsok8NiJfjbORnJScRek+puazzGbX5NuKwjhClvh9TWFQt/M3aFhTg0sVSgLtLRleFnq/eHkIB81sD1Dksgac5X8fg0UxOEyVq5TZiA5siqFhuIk7ikdhT7nYi5h+JTgDEsWohkPv0+jBAlxRAh4XhhVMiOTTpASGorF+sUB/dkebVWLZa09A16He22MiANPkA19dBGAO6FuJ5+2p87uWnspw+1JSL12/wVYO1q54XRayPX4M+B9Z/0bRV92MMq9D6f4AhM5PdB22WZnviUz+gyy3BOOBN62FqxxinE4g2pJFVzadsEAkoCPvprf2jcOoB8O3cth+vqBTcGYowpBHtkuhetuxbO2moRSqBPx5wYXbBh20CxOPxnIyhaflQVdqxETQrkdpPeoE691zFz+Yxod4ALMWkq+BgbkYh/s4pYCtZ0mBgkcWIQpebXKKDPBYCA+G9EumloqNQEhkmQ2UxBjCo51nNrU5OwUTTFokF0JQVUVbwar66/i77xFz16uSvIAwBrDnsD4WQ0ZHeNB14qHR3SSujVZSSZhkruFUVT5wAgx2DGnP37DXg2+BQELkYkulmyz2k/ojgb/cK2JnJCwG+SJWzKK4sMtCvy5JCi0F9yzIiL3Rkk/qArnICgv3xgZ00U1b2wa/D4im8o7WTuVZodrTWEAslmyewzqsnvPF3KQyz0fJcCZcppZmqLCScYX/mngIqGBIJAIwT0gfsblI/8+
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(5660300002)(8676002)(26005)(66946007)(66476007)(66556008)(38100700002)(8936002)(186003)(6916009)(316002)(2906002)(16576012)(31686004)(6486002)(54906003)(36756003)(956004)(2616005)(31696002)(508600001)(86362001)(4326008)(83380400001)(53546011)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?GO/PJJFXRk5eV9J78GZITnN5w+r7qDuaWiD7pR/p1IPsQ6u0WYI4Ge9qnA/k?=
 =?us-ascii?Q?Ml2BDDA93nu3xU0/5rvEntt1MM+agnIzG52KmQ0r6Kftc7W7zphUP0OJTLTS?=
 =?us-ascii?Q?YrkWvoq9allLhR0e5UfNE/pYgeJ7nbqgJCg+/1HqYm5b8NpiJEf6sHYyWnyS?=
 =?us-ascii?Q?Y0kw/2Hx5tOfQeyV4U4xw/t6z54z0/vtbNiS5Ie9hu2hHipvw/5Ahq9GJRUm?=
 =?us-ascii?Q?c7preyKi0Smn0HgH4tNWBQA6aUFOySCTzA8f2ebYbcsvolTzvolTZaaDD6cO?=
 =?us-ascii?Q?TAxtigsK2uNN+yRLzjMHhrURgfLIp67lzFvL98NG8mH6IbWWsy6HG7x2MgfX?=
 =?us-ascii?Q?duCeQrn2rEOLRYJ+rVx7xvyLP+CMmQNFO0SDXGuEXBmBBWH67JEgJEmkE7iP?=
 =?us-ascii?Q?OpOhbiJ83jMeWKxr8EvTwwJqBQTMvMvwhaUWnLm0CCeYBf2558zdYSBeNtrX?=
 =?us-ascii?Q?CUjVGU0pFGZYmYdL1k1C7WRL1+tXDB78OU6NSJVUKd3dyBv9eKQbXU09Bixo?=
 =?us-ascii?Q?3ilwuQq+AEQ18ZEURt8wtXcdE76sYUF4qN1njpoMagGOE3Tm/eZeHmNumzum?=
 =?us-ascii?Q?GLaweKak0PZa1gWTTACkCA5SQU2JLdhjr537j+qQz7qKc29j1481pHf6vGMf?=
 =?us-ascii?Q?E/qqG6tOxpXU3gebrFPSaGdUWdXJs5TJaZ3HP7/e8AKk6pLmgmxG4vuDTFEY?=
 =?us-ascii?Q?VpgWsDQn4jqiQzilP2pgdrbxaFdSGI+kevVc9iCETg2/W93PQkbhTJfKmk+s?=
 =?us-ascii?Q?53pep09Q0aqO8QXzzYiCKoT2gXs3Ol02T+Z32rE+muGMEdsVk+B7Y/cGNrik?=
 =?us-ascii?Q?iWwcNpcw8cqC6ESSaqXCqcLLKgOR4UY6JwIwYtR7WYUY2/YKDBAmZIiJMh04?=
 =?us-ascii?Q?5AbezLM36SIMx/MEmBoHEQGHY7VN0o7vGBVWw8MOg9hrbz28TxHitH4SXKP/?=
 =?us-ascii?Q?qJjq9S/4qdmAtT5UcLfEiJFrkftNfENtwQtJgZIO/CUtwinB3f10lWFS9tir?=
 =?us-ascii?Q?CiHzvPsvObOpABw3bs8RhKwJTejZFuJ4DS0UmD5dkt4Hr87mAqM9pDMXrCI/?=
 =?us-ascii?Q?t2nRQaLB0n0IOmvDv4BD7Ovt7w1LN07x/fqP+wCMtyllHUaDnxKU08pgdvZQ?=
 =?us-ascii?Q?gCDDQ3OhCg1hcKvWrVRKA5znzcM2jV1WnF7y7w/eu405PzrFwRYUOt1YWg2w?=
 =?us-ascii?Q?45Lfd+Fcx4OygH2otJioo2f0vWUp+3qEbBqyC7YhrITHDcfutu1FLMoMs2Vh?=
 =?us-ascii?Q?MzR+k12tJUecU7mMzSUX+DywzPz7KCvogUPsprHn4Lqf9BwoBtVgM044vK8v?=
 =?us-ascii?Q?oAcUqlbv3sJAtUEXjiRffIQ2?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0d600918-0575-46fa-4f28-08d992f93076
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2021 12:08:40.8297
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ILslAFjNyN7K48W++70PcAe1n72zuRjg+S/+5pZ6NuI15B9mM1pgOdgtc9oRN7RaeQBULHLFMbEYryadcShqKA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4846

On 19.10.2021 13:30, Roger Pau Monn=C3=A9 wrote:
> On Tue, Oct 19, 2021 at 09:07:39AM +0200, Jan Beulich wrote:
>> From: Thomas Gleixner <tglx@linutronix.de>
>>
>> On recent Intel systems the HPET stops working when the system reaches P=
C10
>> idle state.
>>
>> The approach of adding PCI ids to the early quirks to disable HPET on
>> these systems is a whack a mole game which makes no sense.
>>
>> Check for PC10 instead and force disable HPET if supported. The check is
>> overbroad as it does not take ACPI, mwait-idle enablement and command
>> line parameters into account. That's fine as long as there is at least
>> PMTIMER available to calibrate the TSC frequency. The decision can be
>> overruled by adding "clocksource=3Dhpet" on the Xen command line.
>>
>> Remove the related PCI quirks for affected Coffee Lake systems as they
>> are not longer required. That should also cover all other systems, i.e.
>> Ice Lake, Tiger Lake, and newer generations, which are most likely
>> affected by this as well.
>>
>> Fixes: Yet another hardware trainwreck
>> Reported-by: Jakub Kicinski <kuba@kernel.org>
>> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
>> [Linux commit: 6e3cd95234dc1eda488f4f487c281bac8fef4d9b]
>>
>> I have to admit that the purpose of checking CPUID5_ECX_INTERRUPT_BREAK
>> is unclear to me, but I didn't want to diverge in technical aspects from
>> the Linux commit.
>>
>> In mwait_pc10_supported(), besides some cosmetic adjustments, avoid UB
>> from shifting left a signed 4-bit constant by 28 bits.
>>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>=20
> Acked-by: Roger Pau Monn=C3=A9 <roger.pau@citrix.com>

Thanks.

>> @@ -395,14 +396,43 @@ static int64_t __init init_hpet(struct p
>>              }
>> =20
>>          /*
>> -         * Some Coffee Lake platforms have a skewed HPET timer once the=
 SoCs
>> -         * entered PC10.
>> +         * Some Coffee Lake and later platforms have a skewed HPET time=
r once
>> +         * they entered PC10.
>> +         *
>> +         * Check whether the system supports PC10. If so force disable =
HPET as
>> +         * that stops counting in PC10. This check is overbroad as it d=
oes not
>> +         * take any of the following into account:
>> +         *
>> +         *	- ACPI tables
>> +         *	- Enablement of mwait-idle
>> +         *	- Command line arguments which limit mwait-idle C-state supp=
ort
>> +         *
>> +         * That's perfectly fine. HPET is a piece of hardware designed =
by
>> +         * committee and the only reasons why it is still in use on mod=
ern
>> +         * systems is the fact that it is impossible to reliably query =
TSC and
>> +         * CPU frequency via CPUID or firmware.
>> +         *
>> +         * If HPET is functional it is useful for calibrating TSC, but =
this can
>> +         * be done via PMTIMER as well which seems to be the last remai=
ning
>> +         * timer on X86/INTEL platforms that has not been completely wr=
eckaged
>> +         * by feature creep.
>> +         *
>> +         * In theory HPET support should be removed altogether, but the=
re are
>> +         * older systems out there which depend on it because TSC and A=
PIC timer
>> +         * are dysfunctional in deeper C-states.
>>           */
>> -        if ( pci_conf_read16(PCI_SBDF(0, 0, 0, 0),
>> -                             PCI_VENDOR_ID) =3D=3D PCI_VENDOR_ID_INTEL =
&&
>> -             pci_conf_read16(PCI_SBDF(0, 0, 0, 0),
>> -                             PCI_DEVICE_ID) =3D=3D 0x3ec4 )
>> -            hpet_address =3D 0;
>> +        if ( mwait_pc10_supported() )
>> +        {
>> +            uint64_t pcfg;
>> +
>> +            rdmsrl(MSR_PKG_CST_CONFIG_CONTROL, pcfg);
>> +            if ( (pcfg & 0xf) < 8 )
>> +                /* nothing */;
>> +            else if ( !strcmp(opt_clocksource, pts->id) )
>> +                printk("HPET use requested via command line, but dysfun=
ctional in PC10\n");
>> +            else
>> +                hpet_address =3D 0;
>=20
> Should we print a message that HPET is being disabled?

There is one, and it was even visible in patch context that you
did strip from your reply:

         if ( !hpet_address )
             printk("Disabling HPET for being unreliable\n");

Jan



From xen-devel-bounces@lists.xenproject.org Tue Oct 19 12:26:57 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Oct 2021 12:26:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.213113.371226 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcoCZ-0003Um-UN; Tue, 19 Oct 2021 12:26:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 213113.371226; Tue, 19 Oct 2021 12:26:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcoCZ-0003Uf-R8; Tue, 19 Oct 2021 12:26:43 +0000
Received: by outflank-mailman (input) for mailman id 213113;
 Tue, 19 Oct 2021 12:26:42 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=gzZp=PH=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mcoCY-0003UZ-56
 for xen-devel@lists.xenproject.org; Tue, 19 Oct 2021 12:26:42 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 551de835-014c-4e54-9a9f-f8611c1b0362;
 Tue, 19 Oct 2021 12:26:40 +0000 (UTC)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2105.outbound.protection.outlook.com [104.47.18.105])
 (Using TLS) by relay.mimecast.com with ESMTP id
 de-mta-19-uVXcQ2d7OOKzZLsBhZl5Dw-1; Tue, 19 Oct 2021 14:26:38 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB2958.eurprd04.prod.outlook.com (2603:10a6:802:a::29) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.17; Tue, 19 Oct
 2021 12:26:37 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.018; Tue, 19 Oct 2021
 12:26:37 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM5PR1001CA0024.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:206:2::37) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.18 via Frontend
 Transport; Tue, 19 Oct 2021 12:26:36 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 551de835-014c-4e54-9a9f-f8611c1b0362
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634646399;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=7fFu0Ope6IWazlryDmobnN2CzT23uN7rbeJ2sMJC6HA=;
	b=JmrHS4vLupYvMeR7cflhw29FGeV1aLS5QoK/8MN8b7+VUR1ISoAklxlKWX261IQiU2Y4pm
	5WHl5UE72Wb45MZ7wLPIc13oq4qmHLsfBWDnBo9ef29plFOcwwSvA+dviGb2iRQJFLuOil
	vU4bl5YXZOnHs5B0ZLMCz1M1izkwAN8=
X-MC-Unique: uVXcQ2d7OOKzZLsBhZl5Dw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=P/bEVVMFBl8dd1iGe7b9dPoSdmTuihjvcBPvkyI4jDPI9VDKe0uPUEakVMnZeNSgaiRescvJR3NUOQDXotfJ75itzGXTkFSVwQ0doc5Gwuh1LbwZ06cF4G5o0jjpnj856QQDmDScvoUuVxV67zCPsKn198SOsMvKn2iQYpS4QcTYYhwTNpMeCYw7bJrdn5X3ihlBrCv77cY9Zm70eBvWEZgiLPW0WDmPVYf+YKI2ayK31Kd6UUhRB++GR5Lrstr2Xj9Xj4GofsaiNURXyZ4xg+7iCLSqB257637sc3EHgrXCg0Gu3hmyjbuoPACFXsKSDd7LUZqc0qG9mTtl9v12EQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=7fFu0Ope6IWazlryDmobnN2CzT23uN7rbeJ2sMJC6HA=;
 b=Po5mbmHgaJjAh5EY9SH9Ipkig9GTTjGAo1XWoPMDi6NkgcEGpVHmiFOlEyk/tTcvb7D6kYNIgc2d9xfnk03xUuRa5EzUatGXkRnc/YD579kii2G6FxVNYhtIGol8lJpa+Aov0Hc7+6/88oBa4QQl742rN7/izNWAq8rwxdSUwVpBSQ2XuKGB3JcMu54sY1ZCnGJBpZPSMQo8bVfe74/FD4VoBcw5sFwC5b0uDGxf//vRqvX+id6xRxzOXWSkbkHN7q1dJWzM+G4V1uGXUm/DFEQ6AZex2bP/Zn08PZkhq98UedrOW89GXFhx1aO1wScmroNdfhM4ZZnYm46UIFDZkQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [PATCH 0/3] Fixes: PCI devices passthrough on Arm
To: Bertrand Marquis <bertrand.marquis@arm.com>
Cc: iwj@xenproject.org, sstabellini@kernel.org,
 Oleksandr_Andrushchenko@epam.com, Paul Durrant <paul@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 xen-devel@lists.xenproject.org
References: <cover.1634639117.git.bertrand.marquis@arm.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <e22e85d1-2c57-29a3-9f4b-b2754069026b@suse.com>
Date: Tue, 19 Oct 2021 14:26:35 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <cover.1634639117.git.bertrand.marquis@arm.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM5PR1001CA0024.EURPRD10.PROD.OUTLOOK.COM
 (2603:10a6:206:2::37) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 8a5ba082-7689-40df-f48b-08d992fbb21d
X-MS-TrafficTypeDiagnostic: VI1PR04MB2958:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB2958285C7D2EEBEC13CAEC0CB3BD9@VI1PR04MB2958.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	hfE1nSSNdgBsjPGtmW/Ti78CqMDavQq6pawE7Cdu6C93AfiYbOk6PKSc7JIt8pZm+dt5z7xowEsHdwZU8BZyq9BmNKQ3kDf+8JnHl54vD+fSqqR0KZRPtv8N5fOKfDtjiSol08DwXfbkoXDxTOaBV/qlA45rD6oUdoCKYpHpCVDAPtR/i+In2QRd7/v1LHGLNFZtWDeDcNN0fUwZ3neBIJ6nTih4IhMJ2ifoDqoWFNARH3z13lmI59sfiO2Kt94stmcrIuR41G5e3sBPmYhBchtSGtC1IbCo9wz/QRcg42UvwqIwY3PAxeLtBmBrQIyU8CAcT171g/oESYjIwTonAMFA81Dvg9VH0kzZR2x1w+0a7EYykvXUN3AtI1cTNhTeHuv/CKNobnj9eS4sEA+yaG5MUG4ILJ7xnYi8Ds+ZYAPO+bGeFUxIMONILZFkwBqz9WzzjRf4vuPcNa/4poc24PHQNo1tlAPg3TqKl0DpusL1lM/PYn1H/vlVBEWCbZioD6eFZHtWEAEPvlUAYAYo/E7YanYIrJ7kc9CJNAy/0bu8aoEjacV/295N6iudxypK9aYxQGfjnLBlw4WvJvlv9O+ShFwgyiazQGVRA8OEjbKeUrIo9JryRGY8zHihuKOIUQPRlkkJSXEHhuNPKIkOcFZSF5hBVcg/C/FYX/eNMiRdtgrhG0V/+RomgX3522/454JfLXDEYSvQpS/TxB7Zy/0ZNFnwxyaYmtDiwwmkZWuP8lk0xqDUARD2Mpg/+3Z0CIfgdzgv7z2ECBOzaBNdbbNhpWznoPj9miFdi24X/l0bYD0+gsbSa+CcSB8J61dq
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(36756003)(316002)(4326008)(31686004)(54906003)(38100700002)(53546011)(86362001)(2616005)(6486002)(83380400001)(16576012)(2906002)(966005)(8676002)(8936002)(26005)(508600001)(66946007)(6916009)(186003)(5660300002)(956004)(66556008)(31696002)(66476007)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?SktpdEZmNEFpcFkxekFLNHZCSGkvZFNZSm9qaGZZb1ZMZUVaR3NwNkR6L0hH?=
 =?utf-8?B?d2RobzlQd3BVYjFMbXRnK1Y0R0VmTklJc3k5Vk5EWnNRZWoycm5mZ3Zpa0w3?=
 =?utf-8?B?aGxaaitaNE5zTEZ4aC9sK0F4M1hvdkRHcTlBOW50VWtSdmxJV2Q3ZkFCMlI2?=
 =?utf-8?B?V3U3eEx3ZHRhSUFVQ3YwMjMrdkFCUFZYa0dXNmhJbjE0YkhMbGMrUHB1NTNB?=
 =?utf-8?B?b1NnK3o4WVZJNXM0VXI0RllCcVZrU3ZmR3FtWUtYTC9scm11NWYwQWVXRjNV?=
 =?utf-8?B?S2twbkVkR2RMMFFzcVRWWHpDQVBTcE9pRkRPd25oYVRrVVRUdzBjcFpvc2N5?=
 =?utf-8?B?d1hicnpJOFkvRGJaN3FQS2VDdGFtOTRoYUNrbFlnOWxDTiswUXRtZUVIczM4?=
 =?utf-8?B?RFA4NXJHKzlhVGNrZnltV3d3RVJ5YmJKd1RzUVNKZndOWTYvTVhlT1M5Q0FS?=
 =?utf-8?B?cmVSYlFjNytGZU9sQmxOS2l3U0d3Tkdmb3FBakp4bEtOK25uTitFbnRMZFVZ?=
 =?utf-8?B?RGI1M2ZsWlNtNCtXMmJvOUtHVk5pMFZNaVp4Q2taTzdiUFpYRk9rSmpZU2tZ?=
 =?utf-8?B?a25yMDZjUnRpSHRydElSSDc0R3FLeXNib3JGbTBDbUVXSTF4WnlONW9CaEdB?=
 =?utf-8?B?Uk1oaEw4ZlNZOUFCYW9XMGd5UVFWcmlleDlieUtUWnFyTjIxS1dZV2JMRkhV?=
 =?utf-8?B?U1dJbEpWSGk1T1FuQ2JZbURQY294d3lXSmMrSWZNTTB5dkZmWlRyUHZITTFu?=
 =?utf-8?B?ZU13L0dxL01adWYySW44ajc0RTR1eWhwTGhNS1dkU2RjUzZqLytNUjR2TFpR?=
 =?utf-8?B?T2VKM2RKdk9sWlp5UzlKU016SUpEYUoxTTM2cmtEWERhNmFnZ1J6eWdEWGZP?=
 =?utf-8?B?UENjOWVpRzdWK3liVWxzUkRtaHhpNVlIRFZBb0lubVhjeFpSUUVyc0V2eWVk?=
 =?utf-8?B?V2JXcjNiYUIwZ0QvbEUvcGdKQWdiRkYzMUxneWpLNUl6M2c1K3RpL1R0SEJ6?=
 =?utf-8?B?OTNGR1hsTU01MmhMUGxHWkRpOTlMQ0dOSFAzbzVaQWdLQVV1R2E0NFVVLzFG?=
 =?utf-8?B?L0ZKT3RhSDU4czlSTUxWU1VKUmRIT2VYTVRxaEwrMVcvVU94QkgyQ25ySXA1?=
 =?utf-8?B?VHFXUDNPZUNTbGNNRDJySnFlYW1rb2ZaWFhManZaeXhwSzRaQmg0OC9YM2NE?=
 =?utf-8?B?REtJZDc4TDZOakZDUVVOSDJpcE1UZDVkZVViOWlkUTE3RkNLblBoNkhxL2R2?=
 =?utf-8?B?WUNvMWRwSHpYMVNyQ2RzbCtWaHAzb1pHQTVKenp4UlkzWDZyMjZSUmVHTmdZ?=
 =?utf-8?B?NEhSZTh5OTNMZ1J6OWhDRDNUUEQwZU9XbitOU0h5eVIzK1BWTWhOV0VYN29S?=
 =?utf-8?B?TkM3elpwSTFib0psOTk5Z3ZZZUxld0cxQ0dKRE12ZTBYT3Y4RVJjVnBvazM0?=
 =?utf-8?B?N2ZsajFPZlZ1U2ZDVlVQU25rWi9HVDZzL3dxb2xuVXB3S1NhU09jalQzNk5G?=
 =?utf-8?B?MTFqWTZvNVAzTW9qNFUxZ3RNWUszUm9SRUFlOCtvQWEzSHd3eUZUMEJ4bVND?=
 =?utf-8?B?SXJSTVMrVERlYTZhZHA0ZTNNUnlhZGdWNFVkb202Q01ueVduNlBueXJvSVlX?=
 =?utf-8?B?Vlp5NEV1U1NKcXV5ZSs2ZXVWaGI5NDlnZUdNRWxaaU5MbEhodi94WnlMWWdW?=
 =?utf-8?B?ZUtkRjdMdFlacU9yeDNCbDV5emZuMXYvMm1iU3ZISFJiYjRSQnVXa2R0NG93?=
 =?utf-8?Q?+oZfGfGLKBaOeTucPPjF+RbQmnulNOD8u4q96uk?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8a5ba082-7689-40df-f48b-08d992fbb21d
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2021 12:26:37.3339
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: BeccY+1XzH4tZtfjuLE7HY5gTapgtR0v7hG14U20B2sGumnDx+r3p8L4Hfl2pk+LZFBxcDLcOKuGnG/BzC707Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB2958

On 19.10.2021 12:40, Bertrand Marquis wrote:
> This patch serie is a follow-up after various findings on d59168dc05
> ("xen/arm: Enable the existing x86 virtual PCI support for ARM") as of
> agreed in [1].
> 
> It does the following:
> - enable vpci_add_handlers on x86 and not only on arm
> - remove __hwdom_init flag for vpci_add_handlers
> - add missing vpci handler cleanup in error path during pci_device_add
>   and pci_device_remove
> 
> [1] https://marc.info/?l=xen-devel&m=163455502020100&w=2
> 
> Bertrand Marquis (3):
>   xen/arm: call vpci_add_handlers on x86
>   xen/vpci: Remove __hwdom_init for vpci_add_handlers
>   xen/pci: Add missing vpci handler cleanup

Imo all three changes need to be in a single patch. An option might be
to have first what is now patch 3, with CONFIG_ARM conditionals, which
the subsequent patch would then delete. But what is now patch 1 cannot
come before patch 2, and patch 2 alone would unduly impact x86 by
moving code from .init.text to .text for no reason. (Still it could
technically be done that way.)

But let me also comment patches 1 and 2 individually (patch 3 looks
okay, apart from the ordering issue).

Jan



From xen-devel-bounces@lists.xenproject.org Tue Oct 19 12:29:13 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Oct 2021 12:29:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.213121.371236 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcoEy-000492-CT; Tue, 19 Oct 2021 12:29:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 213121.371236; Tue, 19 Oct 2021 12:29:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcoEy-00048v-9I; Tue, 19 Oct 2021 12:29:12 +0000
Received: by outflank-mailman (input) for mailman id 213121;
 Tue, 19 Oct 2021 12:29:10 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=gzZp=PH=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mcoEw-00048n-Tk
 for xen-devel@lists.xenproject.org; Tue, 19 Oct 2021 12:29:10 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 6bd0656e-c831-442b-b01c-9588a476533a;
 Tue, 19 Oct 2021 12:29:09 +0000 (UTC)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2057.outbound.protection.outlook.com [104.47.12.57]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-31-EoBUWbC7Nkuqpf2_yIJZqg-1; Tue, 19 Oct 2021 14:29:07 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0402MB3936.eurprd04.prod.outlook.com (2603:10a6:803:23::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16; Tue, 19 Oct
 2021 12:29:05 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.018; Tue, 19 Oct 2021
 12:29:05 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS8PR04CA0124.eurprd04.prod.outlook.com (2603:10a6:20b:127::9) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.16 via Frontend Transport; Tue, 19 Oct 2021 12:29:05 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6bd0656e-c831-442b-b01c-9588a476533a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634646548;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=GomsQYhB9niBvPCzJFh9+N2L5TTVA9yHOWBNKFQVnq0=;
	b=gMwIjKgiek0vcvSGnaP0p5XaRKRZS9hR5DGu9AO5kS1z6ILbQsU6vFS1yuunxBxmtYxVZK
	E3m82QdZ40YlPIsqtHcPGiGeuwmBoYuvDlCq9i68RgMygpWEN7EW1q5Kzl+NfpLa0hfVO9
	OKU6EFBcKjemOkGHVzd0Kg4iSt6fOTg=
X-MC-Unique: EoBUWbC7Nkuqpf2_yIJZqg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=EIQWSyHsnWXezHx6blFmeD9dlFyvgOCdo3nGv3aQPgFghJkNDuk0oUak8bxnBCXU4y1hJU/qEOMA0B/WxUxN8sNSbMofi1k4l2QYBoW87pudsxudRXbxdWQiXCadE5WxWUY19XTuGVC4k9a7Hqu2/OT7HMrwh7sRWhUe2vYM+DIAgQmuVy0eIP6Bt8hGAZGOMpqQz/iq4v7n8sDuEbQD0RS73crvNTan9tXQ7679mM8N3ZrYZ0zPXUkmwPtPKW42kvldcISwxNn328Ynsf3WYNqauU2Z/Z0KEVgPfYuuPDVOv8l1+goAuPbw3HEbdsawxFHlD2dYK+p32AY3ZojZFQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=GomsQYhB9niBvPCzJFh9+N2L5TTVA9yHOWBNKFQVnq0=;
 b=KH4/WtaxsLfz6p1SLLtu1IlDg3Sq2U/gu8xLOkQCps1w2Ar4LrJZv7EcN4LyJ7H+6FLeaF2gJMDM+qRtB7ATlXM6+B2ubG5Mmje1B//HzAR3n0yZCVYl66MP6Ueoc600e3UZREihL6CNKVTn7inK0V+SIrQ1Sk6rkrcDdKCqPG9IA7UAakbcHIY/uxgf15WatYFeZPVRuDrhgt9WltogXx1VED1QSmOp5AGJtNn8ivwtOxYwAP8z2MwwsyyDLole45VXA4Z+r0PUFYprE3rAFVW0e1bTvaKxAU1MQybFwkfhr+UmsGIPZSkh5JA9qfviQy0rBkox6tStdRQR8jhfvw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [PATCH 1/3] xen/arm: call vpci_add_handlers on x86
To: Bertrand Marquis <bertrand.marquis@arm.com>
Cc: iwj@xenproject.org, sstabellini@kernel.org,
 Oleksandr_Andrushchenko@epam.com, Paul Durrant <paul@xen.org>,
 xen-devel@lists.xenproject.org
References: <cover.1634639117.git.bertrand.marquis@arm.com>
 <24f88973257b7038511a0ca49a992d38b295c26f.1634639117.git.bertrand.marquis@arm.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <00829182-6055-ea88-27c1-44e1d3c7e8fd@suse.com>
Date: Tue, 19 Oct 2021 14:29:03 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <24f88973257b7038511a0ca49a992d38b295c26f.1634639117.git.bertrand.marquis@arm.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8PR04CA0124.eurprd04.prod.outlook.com
 (2603:10a6:20b:127::9) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 2ce547d4-f0df-4186-afa8-08d992fc0a8a
X-MS-TrafficTypeDiagnostic: VI1PR0402MB3936:
X-Microsoft-Antispam-PRVS:
	<VI1PR0402MB393606DE1C2F87624573D2E4B3BD9@VI1PR0402MB3936.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7691;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	OATuE2e9qL7W5T8rXfy6QGWwAp1+x/awROt+1OVWOKAaGlW+LbscXkYSsBjEWau/qFZXRPVO7kRL9UtTAn41wSMupF25ESswNSXFyLy+nfTllT9ftRl4IqV422aj+y59iI1DzKx+QO6W+vPZg2vaJLPpFb1jZINs4JMWb11hv3+yJtHJpJQjIj8USh/nPQb1E3sUcqwbHVvcDRFg9s7aWKYAlzFHPaoVPeA4+M+aJv5y4HW+kJ/7/hZdxYpmBgm0ertR81WRVCNUGtsuLiE4nU2MlZUnEF8DQ5ikyA6w1I5g0dPU/8Xm2HfdmCswjTzPIiEQFSbPU2W04WtYdOpzJBssgd1l6xDhDyRsOLziGhTPwa6lPo5xuurzg2h2pAvKWjw2wUy2HPNzLnZJX9UmJ6zGdgNmI3gB/gUukvBnfGf9fZZ3mYfVah+qNB+QB8wZTV74pPUjYs/Kl77bfjGKIb2BJqD+JiAQtVc3nBLTrDmk3mrV3R0wNofU5TaPbxWNe6qHFiJZqGOBo+KgrvhGLwZB5ujZAjzvgP7HaUQzOt5VOYVtITAmJZ2TGFNlfcfLtF5jP7JJqUjmRtqOLCzZ3GEWpX3Lol2fl216VSwN8m/ONvK+n7fcCVs8t5Ms6EDPtBIKaLSq2z2bbdfJoW8ZlQxUKFOhF99Fpnlt1pQeVDzBf4XOevkgA8PO4TlcsFNssWXsaQc9cX38ZFYDY+EsuwzVhGd24g40ZEj3MzCcacc6mehSNPS7pejF38Zgw35G
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(4326008)(6916009)(16576012)(316002)(8936002)(8676002)(38100700002)(86362001)(31696002)(26005)(2906002)(6486002)(4744005)(53546011)(5660300002)(31686004)(186003)(956004)(508600001)(66556008)(2616005)(66476007)(66946007)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?MloyNE11azRFRGZmTHNpU3U5RTZtR3FNS05ZYlhiNDZzdkI4UjM4dE10M2RV?=
 =?utf-8?B?eGFiNVpVV01lVkZkOXFqWE1qSVpuRUlTblFhY3ZEd29wclBZb1NXR3U2REtO?=
 =?utf-8?B?T2FtMFNGYy9tbThhWHB0OG1Qb3NyR2hMN0MwMnAzVzJuc3BOSXRHWEsrZWQv?=
 =?utf-8?B?dVJ5T2NDVUxYZ2JZUjhCRDkvM1I4Ukp1aUFYWkh6UU9jWUhOUUZiV1lYbGtJ?=
 =?utf-8?B?bzRXMUNJTHpJZTZqdTgycWxtZi9ZRW9DMmEyeG1PbnphRmhiSVFWSHRZcFdv?=
 =?utf-8?B?UlhMejFjejJZSWhvTTQ0OTQ3ZklsUlExRjhNbCtPZU5tTk8yV3FseTdCcnlu?=
 =?utf-8?B?UVlNeEhHZlg0SFdWTnlSR1J6ejNVNmptb1NWMXFJaDRzUmMvRFFJUTg3LzdO?=
 =?utf-8?B?Q3l5eDdVbGJ4NjVsOE5xNkhyaUhVVy82MkdkTlR3ZVdhMkhnejIwd3AvWStK?=
 =?utf-8?B?YWx6Ui9aNEptWitFVzg3UEZNaXphS1BlWTdsblZpQnVpZ2pmNUFtYStycm1D?=
 =?utf-8?B?bE83TUtsVmRBRGlodUZxNWI4YTBUQ2ZPeGxGRkRmakFtQkNrY2ljRFhMbXNm?=
 =?utf-8?B?aHU1M3ZRcDdzSytOV2pHQWx0SmpNWmhDTURiQ3JFY2xyOHZ2NE0ySFpteWQy?=
 =?utf-8?B?KzJoQkVmbDNVZVpya2w4R2xMMEFRU1U1N2Y5M0FDR0Yxd3UrRFVQeElKZXph?=
 =?utf-8?B?WDlJVDZwd3lYKzdvbGpVa0ZLSkpicGVjUHZkc1NvVVBEWWFkYndwWVBoUVIy?=
 =?utf-8?B?bkE2SVROY04zUWxNTUFqODRCcEE1aEVQS0MveHVyQVY2OHdWRGU2M0hYYU9s?=
 =?utf-8?B?cjJWNzZrTVFkMzVmcFdFUHJ5eExRS1lMdFNLR0NCbmZwYzFTSmJVMHVvNjlm?=
 =?utf-8?B?OWg2blhSTzZCN0xzSkQ0eVQrcHhFc1J6OGRRYmVtV2k4MSs2RzQxZlFlV3Zu?=
 =?utf-8?B?aHducnBaODN2MEhJZmRja3I3VzVWYVM0YWJBQm9pN0lUSUZ2WEljRS9hUEJS?=
 =?utf-8?B?eVZjNXZ1bXUycTdTVHFuZmJNRXdHY2Fkd2VFVWh6TkloRXlQemcxbmtJalFk?=
 =?utf-8?B?bWkxUGErTnl3TnBKVzVBNG5EK21EcmMwYlp6YmpMVjZ2SkNLSXVzcXJQZXVm?=
 =?utf-8?B?aHptV3YrOEkxQ3BVdmw4cjk3NFZFamUxVWNRa1hHczFRZ1VCRm1JY1AwVGVF?=
 =?utf-8?B?Ukg1RlV0SHMzckQxc3FLeDVDOURocmxIakt3N2R0a0RxRTBHQ2tnYXNLWXRw?=
 =?utf-8?B?Qk1VSzVEZHNPUEFPNTYxQmpTVkJJTE5GVTRSZnlhcGpRaVdUYjhPRWVLQS9m?=
 =?utf-8?B?dHhQdk1iMGU5Smw2dEVtMS96OXk4UjAvQUJsa015ck5oTDB3b1hxY2ZmTnAx?=
 =?utf-8?B?NVR5anVYRnZZN2Y5YXJqVFZoaFZjUmtCRm9teEF1QjdCdzYvc092d1dQK0dB?=
 =?utf-8?B?aXU0SEo1SzRYNm9jMjkyaEFFTUIzcTVZRlU5Ky8yeG5MMmZwclFiWUJPa0Nv?=
 =?utf-8?B?L2ptL2VjK1kvTnphbzBkeWd4OHQvMis5Z0tpcnlRME1oaHE2aVkxa3diL1Bp?=
 =?utf-8?B?TWlZM3ZzcFhzcHE0UGw3ZHhIdFZKRWxVZnhtaFhaWFpoZFREZHk2UTAyYUtm?=
 =?utf-8?B?dW55WUVZaHJnQTVYL2NMWS8reXB0M3JIVU9JUmxNQWcvaCsvK1lNdklsc2RZ?=
 =?utf-8?B?N1NFTm14SkhOUWR5UHpKTEV4QnRCNzJvRjAweDcvaFQ2Uit0TUhISnRDTFVs?=
 =?utf-8?Q?E8VO7t3qQL0HZ9WE8wgJf+nbQuJZFo1WjZ5ol7G?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2ce547d4-f0df-4186-afa8-08d992fc0a8a
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2021 12:29:05.6870
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: uG57is82RD/NoIEErHryz3PFLq9xiTC8OPr43tvJbnkyMsRLP8dRJ/EXycWi/YeR0fQEXAvK/L7znPQx026gYg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3936

On 19.10.2021 12:40, Bertrand Marquis wrote:
> --- a/xen/drivers/passthrough/pci.c
> +++ b/xen/drivers/passthrough/pci.c
> @@ -756,11 +756,6 @@ int pci_add_device(u16 seg, u8 bus, u8 devfn,
>      if ( !pdev->domain )
>      {
>          pdev->domain = hardware_domain;
> -#ifdef CONFIG_ARM
> -        /*
> -         * On ARM PCI devices discovery will be done by Dom0. Add vpci handler
> -         * when Dom0 inform XEN to add the PCI devices in XEN.
> -         */
>          ret = vpci_add_handlers(pdev);

I think it wouldn't hurt to retain a (re-worded) comment here, maybe
along the lines of "For devices not discovered by Xen during boot,
add vPCI handlers when Dom0 first informs Xen about such devices."

Jan



From xen-devel-bounces@lists.xenproject.org Tue Oct 19 12:39:30 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Oct 2021 12:39:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.213130.371250 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcoOr-0005eF-Ci; Tue, 19 Oct 2021 12:39:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 213130.371250; Tue, 19 Oct 2021 12:39:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcoOr-0005e8-9Y; Tue, 19 Oct 2021 12:39:25 +0000
Received: by outflank-mailman (input) for mailman id 213130;
 Tue, 19 Oct 2021 12:39:24 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=gzZp=PH=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mcoOq-0005e0-4g
 for xen-devel@lists.xenproject.org; Tue, 19 Oct 2021 12:39:24 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 9601115a-30d9-11ec-8312-12813bfff9fa;
 Tue, 19 Oct 2021 12:39:23 +0000 (UTC)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2171.outbound.protection.outlook.com [104.47.17.171])
 (Using TLS) by relay.mimecast.com with ESMTP id
 de-mta-25-8MwZ-9bAPam7B7gPHb1kpw-1; Tue, 19 Oct 2021 14:39:21 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB6174.eurprd04.prod.outlook.com (2603:10a6:803:fa::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.17; Tue, 19 Oct
 2021 12:39:19 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.018; Tue, 19 Oct 2021
 12:39:19 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6P191CA0092.EURP191.PROD.OUTLOOK.COM (2603:10a6:209:8a::33) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.18 via Frontend Transport; Tue, 19 Oct 2021 12:39:19 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9601115a-30d9-11ec-8312-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634647162;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=T0nQ9XuYTAjbiAJ0Watq2DV5kmRmzqQrNUQSZ11A9vg=;
	b=UuZtSQSexvMDdKLtjMU9iJJnkfY9Q9MmztAAvRWGvu8FxW9TWA+7Xi6+lmuc2T/TGxoYWl
	tlxHbvwk2jINzv+9rhW6eIGzAgY2Bj71xg714qUMMT6TufldA8slxxnp9Mj6fVtz42Y6RH
	C/GqDY8LjN97ZsqsC9wgdTr95xBxWJ8=
X-MC-Unique: 8MwZ-9bAPam7B7gPHb1kpw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=DVpgu9YsZtiUyoR+QA/WFi/E6uGcflqoxDR+QrJiR2/el5QrzWB6zVR0YwcpTv5In8f+lNEtXMY2k1RiStg9MdbXeGQrGZVYnNOoLcZusUb8TCMljv9GzhJe0lVTbRgkB3/7jQBjCUFc34FD2efJqKD4uYx7vJmhrt71VWUVhhOHkZusdVMwzBTY+xE4s5HYv9kPfQYO/NeCrX4iNIWyUVBowja68Df2kti7d21rcareOz+vWMrXh9iTE7Xlc2KI4e9naMjsMVx076nws2ZsUR5YCR1r1fnDWBN0H9WNpGCmGmJLDahM1Zgvo80ECf+MerUFNR7BwBFPbBlQyUcBjg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=T0nQ9XuYTAjbiAJ0Watq2DV5kmRmzqQrNUQSZ11A9vg=;
 b=WoonGhq1SG5bA/6PcyMX/z8iEDD/ncN7lROAGL92wd0oGD75a4C9CaMdQG3oEpV1CkFjdsl0dGLbWKG7fIuCzSWFryuBiFbyr6M29n3uUjcsTxox/TV6/h8NBZqUNqXm7vMtdd7MgO0YWLocPKuEws79RJke2ZnPjtSWN+I0n7g5wXnTWEab9wfT2J7Vjg02hINjRDH/08IByqRV4x6cnqEbehYE+WXtDZkFvl8io6DdfDtamsnqzWkMr/P/AP5hT/WPSp+0GQ0trc1DhxV31xZQXbBPNKFNRDsm68PYHsIF729JhfZEJVqk/4oObehbebUdNT49oAe7Q+H6TPOYpg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [PATCH 2/3] xen/vpci: Remove __hwdom_init for vpci_add_handlers
To: Bertrand Marquis <bertrand.marquis@arm.com>
Cc: iwj@xenproject.org, sstabellini@kernel.org,
 Oleksandr_Andrushchenko@epam.com, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>, xen-devel@lists.xenproject.org
References: <cover.1634639117.git.bertrand.marquis@arm.com>
 <33b03be7eeea521953790542eb31d5a1386d2b81.1634639117.git.bertrand.marquis@arm.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <116f5313-f2a3-376b-a0a3-af0d14d82125@suse.com>
Date: Tue, 19 Oct 2021 14:39:17 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <33b03be7eeea521953790542eb31d5a1386d2b81.1634639117.git.bertrand.marquis@arm.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P191CA0092.EURP191.PROD.OUTLOOK.COM
 (2603:10a6:209:8a::33) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: bce99441-3a54-41d1-6fdf-08d992fd7875
X-MS-TrafficTypeDiagnostic: VI1PR04MB6174:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB6174246092359982D00AB495B3BD9@VI1PR04MB6174.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:5516;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	ijbxdHiixkKZPTxDQnuE8Tt/uBMy5lu2p30kcZPyv6TbcQPVpGf52gc30+DAWHZ0Dt7inJYFtguAPXKH0s3F16zdZu9Eg6ZYSWA55tlb07+SBs3oCCLbiKhweYcnoHyhmqswSjWqX7SoSaIfB3vsdsTp/gCAwWdW70MvKQJKGw8oZ2v6q/XF4oatDCPrccKFU3/cTdEPF2oTe2+aq+YJ7zkg/SW+xVtOm5EfRKV6EMR5ShiuIJiobZ0pI3POTNK+wCrMRu4NJfQTp19AZCaU+//lzWxHuUS3s4PzYH0xgAup56wS5XTwl2z/B6p1IkiB1t8lfECL3yo71sKMzVcpBTf06fgzStvLYxyTMTWVu/DIxwmYkTtdXvX7qtGATyEo94v8mOtT0cLXYCCSlzAUhtf7mj8XeQsdo97Z7C1wxlcpLvwARpojJ3ec+88/t/yfe94yno9pbENYmZ8MPPnvY7lBw2xzkLRRWwemB7OST0kn24MGwXafz+Ky+QRzvWLzkTlq1MYod99fTGAQ9xLl6AxUZ+b/8mlqMVNx+EpSjBLKyXWsJtMeqkZc4ttcmIQwO39l41BNht3T2AHsiPD5jkGYanN3PL2KKo5siwdJum5Z3/84YLeHIU1X8o6wdTSrJnU0QRdmICZLtEOPaetBHCaI5oHcOylG6BKoJWVRZOStxsMo67JJ8XTurQVa7/D75WYohjL+VshQVMwdFkN0hdcejZnQIKi3QXZOql2WKojbwJuteEVW8BpYwCi2jtOp
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(31686004)(186003)(6916009)(26005)(86362001)(2906002)(8676002)(66556008)(16576012)(31696002)(316002)(66946007)(508600001)(956004)(53546011)(8936002)(2616005)(36756003)(5660300002)(4744005)(6486002)(38100700002)(4326008)(66476007)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?L2xrdDQxS3dQVWs2emZhWFNjbG1HS1FUY0xiaG1Qdk1nTTJLcHMxQVFDcG1O?=
 =?utf-8?B?a3cwektNdlJGNk9VLzdTT2R0VFJaTUVEY04remxvUDk5OUJ1ZXFVRlZVRUs1?=
 =?utf-8?B?ejcveVo2OVFHRkJ4ckpxZllBUzRmbFJkQVlKY1ZnWlEwUEJjNEVGWkF1YzNx?=
 =?utf-8?B?VEovTkFEb3BUZ2lxSHhzaHA1SExaUUtieDFnQllZaGdIUkJLZHlZSisxWUgy?=
 =?utf-8?B?VmFnNlFmZ2lRSGV3cDEyYWJseTZGUkd3dTdVRjRUaVpVei9ZNnkzZTNNTWYx?=
 =?utf-8?B?SG4rL1JYWnFJS3lmMlJ0a0hkRERhL0l6WS9XZk11R2VxUmVBWCtNZnM1TUdx?=
 =?utf-8?B?dVJXSEFIampKVzFRUnRDQzVyMTJxQXFpdG9KdUNTUVkzOEZVUzZRZzBIMzN1?=
 =?utf-8?B?UFlPWVZ2TWJLSXVtU3hrc0JoaU0ySldyUHFmaXZLNGZOZkMzV2tsUzlSeXpa?=
 =?utf-8?B?SmpZZ1hhSEJHOE9pSjd4blFleXlzaFBCZmJRQ0RwU3pqbjIyL3RtaCtOSFBx?=
 =?utf-8?B?RE9RNXAwdm1OZHpMMzJ1UExaWUpKblpWdkxmOHNOb0FkZW45c3M2MEJFcUpa?=
 =?utf-8?B?aC8xQlMvYVhnUnVCNU9TdXZOV3d1bXNjRHFtOWpJQlNWMXlzWFM1Y3BjYmJJ?=
 =?utf-8?B?eThrQlYwRnh3a1dvc1dwb3BXUC9reG1KNURTUWhOUUNCQjdlMm1RclIxa2tU?=
 =?utf-8?B?bzFLdWlGZkJkK1dPV0k4d1dBWVhLSHd1UFBycFZqcjBQNnh2ZlFORTlnNStQ?=
 =?utf-8?B?eTdCZXdubFNPSUcwVEtpYzcwYUFqOXRSbXl0NHdUQis3VmJCaHlvRW9UYlUw?=
 =?utf-8?B?TnMvR1JhNEtReDlhemV4SDVPOWVTWVViNHdiK3dWYitYcDlXUTA0UDZGNE5K?=
 =?utf-8?B?VXlqWTZ0TTNYMTFaR25ybkxhekN4REM1NCs4WVFSQU05azJMVldqaURLMGNs?=
 =?utf-8?B?SWZUR2M4cFBjbzBhc3JtL0szcVhHcFZlNzBCNWZHMFFWNUgvT1R2QXdIQzQy?=
 =?utf-8?B?Ni9UQzVMQXhyb3AwZHB0cGlGOGJCdDdtY0VBOUZXTU1iNkpKeEQrZVhDRmVp?=
 =?utf-8?B?RCtONzBwaERZeFVuekFJR2NOdkRsYVRwanAxRHBjRzZQRnFwb2t4TC9VUmcw?=
 =?utf-8?B?dGxPUFJCcmdXaEY2dU9yNGhld00yTEordWdDd0NVVjdjNUpMVWh4bGNnSlJj?=
 =?utf-8?B?S0djcW5IUERnTXEvM2pFUjdRaEZJQjZZdGswQkZnOHE1aEc0RGpIRVFua204?=
 =?utf-8?B?R1FuVFFRT0grZzdKbzJiRWR4ZHBZc0FwYWk0YVVmTkloVm1IWmdMQ0pqKzVC?=
 =?utf-8?B?ZE1yQWZEZGJZVHZKeDl4T3U1MVRMQkpNZkc0RFVMaHBBdlo3blJETXk5b0sz?=
 =?utf-8?B?YkRIVFNXVkhYQWtzbFJhb1JJWTNBdUl1aFNjR2VWckovNU1rd256Yk5sbGRR?=
 =?utf-8?B?bXhPUDNrb2dycC9qVWVpNUY3OEdnR2EraEpyUjdMREhsbWh1dkhSWmFvTnVz?=
 =?utf-8?B?NEpLbVBvQnl5RjlhWjZjUzJHSmlEanZOQ1J4cHpZNXV6Yk9veklLTk0vdmdO?=
 =?utf-8?B?ekxyR1BhTkZTS1Rham02eXFjQ0pwQURnbzNEbUtnb1pEbEhrWmExMDh5TjlH?=
 =?utf-8?B?dUlqb0M3Zm5tQTlpOURrcXJ0bExqVCswczhpWlNyVEdnRWQ3Y1pvVjBoYXRj?=
 =?utf-8?B?VkxpUE11NlBNZzNtZzZoczI4aUZFWVc2QnhlbTJPUlV4bGs3LzJoUnVGZVR5?=
 =?utf-8?Q?hcJY8yKGnKS+IbkEZqYJcwuJuqeWcoFgCsNf/n0?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bce99441-3a54-41d1-6fdf-08d992fd7875
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2021 12:39:19.6538
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: CNaXyupmc1p6oB09G4j4O8SJjtrhJMMRH89NQeT1Pib5b3xsppPh+3h2j8ZooqfjPNQnXiTWuiBXk2kzQyoLEg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6174

On 19.10.2021 12:40, Bertrand Marquis wrote:
> --- a/xen/drivers/vpci/vpci.c
> +++ b/xen/drivers/vpci/vpci.c
> @@ -54,7 +54,7 @@ void vpci_remove_device(struct pci_dev *pdev)
>      pdev->vpci = NULL;
>  }
>  
> -int __hwdom_init vpci_add_handlers(struct pci_dev *pdev)
> +int vpci_add_handlers(struct pci_dev *pdev)

A fundamental requirement when altering section attributes is to
also check that all referenced entities are appropriately placed.
Afaict this is not the case for __start_vpci_array[], and you'll
need to also adjust linker scripts to deal with that. Further
you'd have to check that all functions referenced by that array
aren't __hwdom_init. In taking an example (init_msi()) I'm
actually surprised to find it's not marked __hwdom_init. So
maybe all is fine as far as these are concerned.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Oct 19 12:46:31 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Oct 2021 12:46:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.213143.371264 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcoVd-00078p-9L; Tue, 19 Oct 2021 12:46:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 213143.371264; Tue, 19 Oct 2021 12:46:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcoVd-00078i-5u; Tue, 19 Oct 2021 12:46:25 +0000
Received: by outflank-mailman (input) for mailman id 213143;
 Tue, 19 Oct 2021 12:46:23 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=eXNP=PH=citrix.com=roger.pau@srs-us1.protection.inumbo.net>)
 id 1mcoVb-00078c-GH
 for xen-devel@lists.xenproject.org; Tue, 19 Oct 2021 12:46:23 +0000
Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id c72277b9-a6b3-475b-a787-c0e25f2ba2f5;
 Tue, 19 Oct 2021 12:46:22 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c72277b9-a6b3-475b-a787-c0e25f2ba2f5
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1634647581;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=Qq13tI2v06rCnIBfL+4WRXae/wl9u0gFN53TeC9ttys=;
  b=RelT5FbUktWBq7T+DMqX1BVhNEaLIbSlGPW5mRCpg42zvCSbZ2TctBZ2
   7XrHRgc7qmYiZqwbP/hFkCRMJZWzLIsO8IDUeTDmbshy6NYnM2Gvho8tG
   8yl8rW1r1m0faJ4UApTnwUyQaVjgjQbgi8xP1LLlZC62e685yihhOp/xW
   o=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: bqIxOojV8NcEdnn1cJHHZAr3DHKgcnQctE7N0zFzJO61NXw1TdbPgUdXZ0Aq1GeKiM9tFohNoU
 0i3c/c72+ZMzYb9/DukF51m23ePWUobFTRLRC7INbBCqXy8T5Kvk2hJSw6IK8p0MnGmzLYQZSu
 V2H4b+CxuVIZJUtP1RYHEtQK8B3R0EFs+MBaQmKHbk5QTmlLZEzwlJJATY442LqtmfP/kQ9Y1L
 KXK6UGjdCFBhI9tVuRvjr+gSWWxSicYxK/isZ/RYR2N/E7Cz1kunEWDZCje0M1jii3+nolC8AZ
 j3RBMvL+qt550Rcfs5rRtp69
X-SBRS: 5.1
X-MesageID: 55517809
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:iqDmi6kUBHnj0DLtNNTt5SLo5gxZIURdPkR7XQ2eYbSJt1+Wr1Gzt
 xIZDD2FPfuMZTbxKNl2Pt7gp0wPu5fUxoJqTwpk/C82FSMWpZLJC+rCIxarNUt+DCFioGGLT
 Sk6QoOdRCzhZiaE/n9BClVlxJVF/fngqoDUUYYoAQgsA187IMsdoUg7wbdg2tc52YPR7z6l4
 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc
 s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4
 JZc7oKUT1sVB/HvmOUESiZDEyZTELITrdcrIVDn2SCS50jPcn+qyPRyFkAme4Yf/46bA0kXq
 6ZecmpUKEne2aTmm9pXScE17ignBNPsM44F/Glp0BnSDOo8QICFSKLPjTNd9Gpt25kRTa6PD
 yYfQQhQdSnwRD5PA1coIrA+zPaXpFfVciIN/Tp5ooJoujOOnWSdyoPFL979atGMA8JPkS6wt
 m/Aumj0HBweHNie0iaetGKhgPfVmiH2U55UE6e3ntZoilCOwm0YCDUNSEC25/K+jyaDt8l3c
 hJOvHB09O5rqRLtHoKVswCETGCs/Q9HRf5WT9EDtCKNy7PN3B2ZAUUpUWsUADA5j/MeSTsv3
 16PutrmAz1zrbGYIU6gGqeoQSCaYndNczdTDcMQZU5cuYO7+dBs5v7aZo87SPbdszHjJd3nL
 9lmRgAFjLIPkdVD6ay/+V3W695HjsmUFlBrjuk7s2TM0++YWGJHT9D3gbQ4xawZRGp8crVnl
 CJU8yR5xLtWZaxhbATXHI0w8EiBvp5pygH0j191BIUG/D+w4XOldo04yGggfxs0YpxaIWW3O
 R+7VeZtCHl7ZivCgUhfONrZNijX5fK4SYSNug78P7KinaSdhCfYpXozNCZ8LkjmkVQ2kLFXB
 HtoWZ3EMJruMow+lGDeb75EidcDn3lirUuOFcGT50n2itK2OS/KIYrpxXPTN4jVGovf+16Lm
 zueXuPXoyhivBrWMnCGr99DcwpURZX5bLivw/Fqmie4ClMOMEkqCuPLwKNnfIpgnq9PkfzP8
 G37UUhdoGcTT1WdQelTQnw8Or7pQ7hlqnc3YX4lMVqygiBxaoez9qYPMZAweOB/puBkyPd1S
 dgDetmBXasTGmiWpWxFYMmvtpFmeTSqmRmKY3ivbg8gcsMyXAfO4NLlIFfirXFcEiqtuMIii
 LS8zQeHE4EbTgFvAZ+OOvKixl+8p1YHn+d2UxeaK9VfYhy0ooNrNzbwnrk8JMRVcUfPwT6T1
 gC3BxYEpLaS/99poYeR3a3d9tWnCepzGEZeDlL317fuOHmI5HenzK9BTP2MIWLXWlTr9fjwf
 u5S1fz9bqEKxQ4Yr4pmHr935qsi/N+z9aRCxwFpEXiXPVSmDrRsfiuP0cVV7/Afw7ZYvU29W
 16V+8kcMrKMYZu3HFkULQsjT+KCyfBLxWWCsaVreB33tH1t4b6KcUROJB3d2iVSIYx8PJ4h3
 ep86tUd7Bayi0ZyP9uL5syOG79g8pDUv30bi6wn
IronPort-HdrOrdr: A9a23:KhyfwKFPWRZyZGRHpLqEEseALOsnbusQ8zAXPiBKJCC9vPb5qy
 nOpoV+6faQslwssR4b9uxoVJPvfZq+z+8R3WByB8bAYOCOggLBQL2KhbGI/9SKIVydygcy78
 Zdm6gVMqyMMbB55/yKnDVRxbwbsaa6GKPDv5ah8590JzsaDJ2Jd21Ce32m+ksdfnghObMJUK
 Cyy+BgvDSadXEefq2AdwM4t7iqnayzqHr+CyR2fyIa1A==
X-IronPort-AV: E=Sophos;i="5.87,163,1631592000"; 
   d="scan'208";a="55517809"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=mJC4lRWXUz+1B6E6lsiogV/gAmIWl3bHB4SngsGwCkEt0jlBRJSsXa7nKsisbzVdODbtmRFZyyfLGn47dLiYnOlJpK9XdBhcQG5H4rci3NKexJzbE+w43vSEj9CGRuBzCMBDGf02HL3Dg0WQNoL4J4wLLO+jdLyqupaZVLJtDJ6aLiXZHkxyXxGjV+BaxePhWVKq1wj5W1+p/ZN4Xnm5bHH1OHU6Vd7vm/6B+O3dUfGa5vEQBvIvdAk8dRbolU2SYHCCqZQ3wPJk2573AJu/Ut4fPV2XmAC57eY6lL6HYniNyP0zWqJeIKIegyLN0OJTvlqBLMoezBJSeSmtW7YO6w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=gQ+DOZS6TOyBdKU5fGxUfNiaZ+kp3h/7e1sctlHNhts=;
 b=MdD3DrErYWtckGVB8vXq0lrixpORt5HQJ3YNzMiMYRSAD5MGNt0Xx3fLp4Yov9+F27iaM6BKKoiBf+uvhKgr1T9ogd8q5bLGL3THmuIB64rkaJWABG0BbE5UKi2AqKqDUNEcdsg3v1Uvuaepa7QPukK7biKuZwsxPCGegTkCjpU9BGaDO1GLSuEu0myC2+5Ve0N0Q+2KbABsX2glbXoyqnqvHMhtK0q46HXDIHtHfhaNgT7pzmdE/D9ChJVKXL6yKJU0MY2IbTcVQck1AuvCT9q3uCcK29+fKFTKpklojJJcR+k1mYaH97C9BSxvgNPYPPwDln9KpOwgsrsWyPrG5g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=gQ+DOZS6TOyBdKU5fGxUfNiaZ+kp3h/7e1sctlHNhts=;
 b=b/0RWyJIUxWZoAuYgakDZieAP3+tC4TJa6PAF95U/iAQNIR041zgl2CgMgPs3r1bSfYb4w4sO8GBFmXb0xqRZEWoI/rMjIwBtHKMDTdeHne10Cu/DI77enBHoLCvoSFlNO5MTqiRuuQNIQYbIbVkaZG25H17EHfUCBqltQWCJpA=
Date: Tue, 19 Oct 2021 14:45:54 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, "Andrew
 Cooper" <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH 1/2] x86/hpet: Use another crystalball to evaluate HPET
 usability
Message-ID: <YW6+Av5roTErWQ/s@MacBook-Air-de-Roger.local>
References: <9963c7a2-f880-66fc-8f12-b1ddd0619c91@suse.com>
 <da80b8dd-177c-d27a-9a00-c9538a139d37@suse.com>
 <YW6sSXMyC6t4fB62@MacBook-Air-de-Roger.local>
 <3a366ebf-61ed-7e41-193e-131540e555e4@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <3a366ebf-61ed-7e41-193e-131540e555e4@suse.com>
X-ClientProxiedBy: LO2P265CA0500.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:13b::7) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 4c00ddb9-2d16-4ab0-6ca7-08d992fe6742
X-MS-TrafficTypeDiagnostic: DM6PR03MB4057:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <DM6PR03MB4057CBF4A5994B0A1045D1A78FBD9@DM6PR03MB4057.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:4502;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: FDHd2FIlhSC0O98e+qRehuXT5QKoVoeDgcuQ+1KVMdhmiIS2OLpYTnLAMdTVDoUbQsNRJjrb1YpDxVfXmPT131Xo4MwPgeD/uuOOSHdwsb5O4MZAlXVKK1kLQfPNgRtxawvNubD7mkDIf6/86Y1E5PpTDkhz48hN2KN87LqD+lSG44oNPJ/w5kE1p9chREri06qZmYmonPThvFOloHBWnyUt3qSSWebAjBjiZHITmfDVUJ0jBRa+weKjCdr+gPhuSZLofTtEGcuSrSBclwJ/AoMZqQWSyHNk4kVkwJVmQYoORF43c/QK199P/Gy3C0BdjiWMVSQ4VNtiJIW6GJIHwPSEB/R1/dXCVWxyLybJc9dotuf44+xpB83f+Vj7H7p6I+eNdttH5CJyKL09iC4vW12dtYXfnaczXktbAHOAr+PDour4SxWjKOl15IAgCbtBFd/HPPPcOeduhaq4tJOHQ5VSWedcw48VpvBnVZdI5ty47tWObL19DMOLuWAHrFqvOND46IlmTyyR6M7c0S+kG3f6nQ77thLlI8WZ4vjTSY0SSd1FU8U+l+KJ8eav+Kw4hPyFWkK9eIutS4sZyO2ggWfeSjIl5IQc54r+qqxEgmp9f8TYpFnfDg1Z9ivJzVRO33bTk9VieJBunrkFuRX+rA==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(8676002)(508600001)(8936002)(4326008)(82960400001)(83380400001)(5660300002)(9686003)(316002)(54906003)(66556008)(6666004)(85182001)(66476007)(86362001)(66946007)(26005)(2906002)(6916009)(186003)(6486002)(38100700002)(956004)(53546011)(6496006);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L0pnenZsd0g1VnY1aDBtTlpmM243c2prNFIwWXVWU2I1SERTTWMxM1FrQTRP?=
 =?utf-8?B?QnNiUldmM1dLYk5rbDA3eWpBYnkvMzJyZG10VnZXVUdDUXFBT2NzdXZKcUM2?=
 =?utf-8?B?Z0xKRFJQQTFjZ3NhOVoyWkhnUGJsbHZuNWdKUklHTGNGRXhYdnEySW9SSEt6?=
 =?utf-8?B?cmtjdS96aGZ6aWliOEJiMzVkUjJEd25IcUpuaTVFc2YySVBmQ2UvRDdJS1hP?=
 =?utf-8?B?V0VvV2ovVTRHV2luR3p3Ri8vVzUxNEpYSGFoYjlMYXBVS0lQV1pOY2g5Slpi?=
 =?utf-8?B?bUJPbWhTb3FDYVF0OGJFckpuZlg4UjlpS3owWjdJMFA3djFubGdMODlsbjNk?=
 =?utf-8?B?S0JuSTNaQ3lGUGY0K2NkS0FSNlNJWnBGMUJRaFY2ODlQS1dRUVRhVGtPVmlh?=
 =?utf-8?B?OG9vcndqdXRHT1hFTWljY1BlWDNMR3pCeC9DLzQ4bDdnaDZrb2tHbmNRNUkz?=
 =?utf-8?B?eWJLNWRGQ0YrV2VtN2FkSXkzZ09xbEUvSHB5QkR1T2lHcWFZbUpCWnhxVms3?=
 =?utf-8?B?c0gwbkx6WWx3TlZyTDVWU1g4d1N2MU9nK3k3ZlBnYVJiWWVjRW1tdnF3dS9D?=
 =?utf-8?B?N0IxWk5UL01uSVcwalo0TUhpUlNLeVhzdS8yakc3eXFlYkVGUk90SnE5UEZa?=
 =?utf-8?B?NWE3d1dMcjN0dFcyeHR1YkgxdTJNU0xBSE5uUnZiTG1BRjFqRWJkN0pxWmJ4?=
 =?utf-8?B?VnVMLzA3Sm42cVlxdjI5ZTdCcThMalVvZ1U1Sm9qM25Uc0lET0pESjZpcklB?=
 =?utf-8?B?MEQ4Z0wyaVB5TFRXMjhEbzRsZnFESUcyeC9manhBWEdDcTB6TkcrOGZnVTNE?=
 =?utf-8?B?SXNjNTlSV09XN1lWMWV0VXUrWEVtWWsybDdSS2xGYUkvNk9IN2NlUUl6MUhN?=
 =?utf-8?B?TTNCU29OV0d2VmFJcnZXZjB2MStYeTRnNU1yZk42cExVR3B2Y2VKWUp3U3VO?=
 =?utf-8?B?VkpvR3VUeTlnNjRCRjkxdHlyczFHWm12ajQ2YmFrVDNVWUhPM3pFOUNnb0Ru?=
 =?utf-8?B?ZjA4bmZLYU9NQ2ZidXVLSC9TM2EvWjVwVHRDQjZuNGxjY25oeElKQUw0S2Q1?=
 =?utf-8?B?VDc4OVc0Mi9EWE1XUlZPdnE0T280aHF3WnBSMU5LY2F0Tmh6ZTNZQS9JK25C?=
 =?utf-8?B?ekh3amVzTVQ4M0lJdkJXa3VBaVBYZ2lmVDVpbVAxYTFtNnlkYVhLZ1BFcjg0?=
 =?utf-8?B?NEF5V3NJOWlheUNQMXZFcVdXNWd3K0t1Z3U3MGlweXo4UUZqTCtPVHNRYytZ?=
 =?utf-8?B?ZUZvSEZoSmUwTjFkejFIYW4zcUN2UW1LVHVSRUt6bXoyc3NveW5ES1F4NGk3?=
 =?utf-8?B?QVErM1VQUlRFK09XMFV6VmZCOTNRbjFueTVvUHF4OENMT1FXaDNIZFBsVk5z?=
 =?utf-8?B?cjdBMjJWb0ZSREVrMzJpQytTenpEZTZqOXNqN00xYlNSMDVYS09KYjZTeXVY?=
 =?utf-8?B?TVBiY0Q5NG5JNFBJc1ZlS0pHcVRlL2hQUlNHUytBdUxoNEVKN1U2T3BqN1J4?=
 =?utf-8?B?MVY2aUoxYjZ2ZnluOC95K1dPT0g3Q0JLa1lmM3ZaYXB1cjBaK00rOVlYc0Vz?=
 =?utf-8?B?QlltdFB5VzR3cStSclpDYmRLZjh1WDk4RnpXalJ2MUZORTRCam92cWxjVmZk?=
 =?utf-8?B?S0tMQUZwZS8ycmNtVGh0N1hqMktWeHF1QmVraDZ5ZTlKR01CaTRGMWMwd2c2?=
 =?utf-8?B?cWgwN0d5REYxZWE0ek1JTnRXeS9tRkRGRzBsV0R4aVR5bU5ZM1ROa2svV0VI?=
 =?utf-8?Q?V5ctQyhsLVu5Gj6FoinTVQf16FVV06/Y4ap38Fc?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 4c00ddb9-2d16-4ab0-6ca7-08d992fe6742
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2021 12:46:00.2485
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: OV7+eKfQYsV0EyzQocqnwG6OBEm69D6kwvpGvmCc48dhMFdpWQ3h/7CsizFKUj8G+0IrtsokDoFChsdIbe0UzA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4057
X-OriginatorOrg: citrix.com

On Tue, Oct 19, 2021 at 02:08:38PM +0200, Jan Beulich wrote:
> On 19.10.2021 13:30, Roger Pau Monné wrote:
> > On Tue, Oct 19, 2021 at 09:07:39AM +0200, Jan Beulich wrote:
> >> From: Thomas Gleixner <tglx@linutronix.de>
> >>
> >> On recent Intel systems the HPET stops working when the system reaches PC10
> >> idle state.
> >>
> >> The approach of adding PCI ids to the early quirks to disable HPET on
> >> these systems is a whack a mole game which makes no sense.
> >>
> >> Check for PC10 instead and force disable HPET if supported. The check is
> >> overbroad as it does not take ACPI, mwait-idle enablement and command
> >> line parameters into account. That's fine as long as there is at least
> >> PMTIMER available to calibrate the TSC frequency. The decision can be
> >> overruled by adding "clocksource=hpet" on the Xen command line.
> >>
> >> Remove the related PCI quirks for affected Coffee Lake systems as they
> >> are not longer required. That should also cover all other systems, i.e.
> >> Ice Lake, Tiger Lake, and newer generations, which are most likely
> >> affected by this as well.
> >>
> >> Fixes: Yet another hardware trainwreck
> >> Reported-by: Jakub Kicinski <kuba@kernel.org>
> >> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> >> [Linux commit: 6e3cd95234dc1eda488f4f487c281bac8fef4d9b]
> >>
> >> I have to admit that the purpose of checking CPUID5_ECX_INTERRUPT_BREAK
> >> is unclear to me, but I didn't want to diverge in technical aspects from
> >> the Linux commit.
> >>
> >> In mwait_pc10_supported(), besides some cosmetic adjustments, avoid UB
> >> from shifting left a signed 4-bit constant by 28 bits.
> >>
> >> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> > 
> > Acked-by: Roger Pau Monné <roger.pau@citrix.com>
> 
> Thanks.
> 
> >> @@ -395,14 +396,43 @@ static int64_t __init init_hpet(struct p
> >>              }
> >>  
> >>          /*
> >> -         * Some Coffee Lake platforms have a skewed HPET timer once the SoCs
> >> -         * entered PC10.
> >> +         * Some Coffee Lake and later platforms have a skewed HPET timer once
> >> +         * they entered PC10.
> >> +         *
> >> +         * Check whether the system supports PC10. If so force disable HPET as
> >> +         * that stops counting in PC10. This check is overbroad as it does not
> >> +         * take any of the following into account:
> >> +         *
> >> +         *	- ACPI tables
> >> +         *	- Enablement of mwait-idle
> >> +         *	- Command line arguments which limit mwait-idle C-state support
> >> +         *
> >> +         * That's perfectly fine. HPET is a piece of hardware designed by
> >> +         * committee and the only reasons why it is still in use on modern
> >> +         * systems is the fact that it is impossible to reliably query TSC and
> >> +         * CPU frequency via CPUID or firmware.
> >> +         *
> >> +         * If HPET is functional it is useful for calibrating TSC, but this can
> >> +         * be done via PMTIMER as well which seems to be the last remaining
> >> +         * timer on X86/INTEL platforms that has not been completely wreckaged
> >> +         * by feature creep.
> >> +         *
> >> +         * In theory HPET support should be removed altogether, but there are
> >> +         * older systems out there which depend on it because TSC and APIC timer
> >> +         * are dysfunctional in deeper C-states.
> >>           */
> >> -        if ( pci_conf_read16(PCI_SBDF(0, 0, 0, 0),
> >> -                             PCI_VENDOR_ID) == PCI_VENDOR_ID_INTEL &&
> >> -             pci_conf_read16(PCI_SBDF(0, 0, 0, 0),
> >> -                             PCI_DEVICE_ID) == 0x3ec4 )
> >> -            hpet_address = 0;
> >> +        if ( mwait_pc10_supported() )
> >> +        {
> >> +            uint64_t pcfg;
> >> +
> >> +            rdmsrl(MSR_PKG_CST_CONFIG_CONTROL, pcfg);
> >> +            if ( (pcfg & 0xf) < 8 )
> >> +                /* nothing */;
> >> +            else if ( !strcmp(opt_clocksource, pts->id) )
> >> +                printk("HPET use requested via command line, but dysfunctional in PC10\n");
> >> +            else
> >> +                hpet_address = 0;
> > 
> > Should we print a message that HPET is being disabled?
> 
> There is one, and it was even visible in patch context that you
> did strip from your reply:

I meant something about being disabled for PC10, but I think the
generic one is fine enough.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Tue Oct 19 12:52:39 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Oct 2021 12:52:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.213150.371275 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcobb-00008J-UI; Tue, 19 Oct 2021 12:52:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 213150.371275; Tue, 19 Oct 2021 12:52:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcobb-00008C-RK; Tue, 19 Oct 2021 12:52:35 +0000
Received: by outflank-mailman (input) for mailman id 213150;
 Tue, 19 Oct 2021 12:52:34 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=gzZp=PH=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mcoba-000085-KX
 for xen-devel@lists.xenproject.org; Tue, 19 Oct 2021 12:52:34 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 6a8d6c4f-9ddb-4b5d-afbd-773410be9ff7;
 Tue, 19 Oct 2021 12:52:33 +0000 (UTC)
Received: from EUR02-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur02lp2053.outbound.protection.outlook.com [104.47.5.53]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-36-XBA-h1sFNVKL0DLYSyfNFg-1; Tue, 19 Oct 2021 14:52:31 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VE1PR04MB6672.eurprd04.prod.outlook.com (2603:10a6:803:127::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16; Tue, 19 Oct
 2021 12:52:29 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.018; Tue, 19 Oct 2021
 12:52:29 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6PR08CA0031.eurprd08.prod.outlook.com (2603:10a6:20b:c0::19) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.15 via Frontend Transport; Tue, 19 Oct 2021 12:52:28 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6a8d6c4f-9ddb-4b5d-afbd-773410be9ff7
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634647952;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding;
	bh=J6uEHd9m49ZImhQ66YKOzPW7dyQfpUbMytSt7KlyfCo=;
	b=kcLllc7YxKTaRcjZkKnFrh86Ove0fGaNETNtfj86ZLf9b0lZJn357w+MyOZbs1Z21CY5W+
	DP14TMp0bpYz7R9zCu1eAw3Cke3US1PxPYEFsrXuUhQPjwFdgKhMhiPIFOaO9eaGMW43ES
	ltRBKo4urPW3PAIPG81B+FibaZcV8HQ=
X-MC-Unique: XBA-h1sFNVKL0DLYSyfNFg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=mxl6j1Yatiqn8hiWMX/ORRIb9mgJKourLEWRGijuh+YEjSh9056MhvB2Xlea/j+ESucvaU42UvQAdPn4gVIMRi4lmD3D6jFxXPs6mPyRvUFv6ObfK+IDRRAD6gjDqhU5pEUoCaBm6Zsj65X7bRhbtYMqrV6GCMDMzhWWwgg6VKcmXywQzvCRFwaxp//1scoNcN3BjV4nnHrYj3BP6LZD5uBk2HW2NPcG2jsrkM6niHt6ICF+OXRYxLWN6Ou53w7jWaRj7c6XWsH50m8X3dd7kM1ENm9Q730AXRw5Q/pI5HsLScHWOJ4eSUyIZiOB74DYEkiIR4SteoR5vKQRMdiXGQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=J6uEHd9m49ZImhQ66YKOzPW7dyQfpUbMytSt7KlyfCo=;
 b=gSOQyhrdUMgyPMMmEnOyy7M+JwrdKRXYpzUi56lmWYiwRSwljFa3K7TMWmNJu6aSJWJJKAGszDptiUbPH/NF3o144CQxrvXW3V/DwhHkt2M5lhKfFSM/ww1kehysB+LioAjpxovgG8k9w+vk4zTko1WX5GupwfRevlwRK7dz7pHvrrJTy6S8Y+6Mjkqy8QA03yDetd+K6rn0sZuwLzCSQt7iN8MF1tjgxI63wKySLEPYbs8KIKCiJ1KYiBHaotqe8k5NNmIqXsyRnXmXupMYDD60bQFaqGpUk/uwpzIUyZ5o0TiPTQHTu+qmrd4+PLcllgXKz1ayfU4/xqWPZfsegw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: intel.com; dkim=none (message not signed)
 header.d=none;intel.com; dmarc=none action=none header.from=suse.com;
From: Jan Beulich <jbeulich@suse.com>
Subject: [PATCH v2] x86/PoD: defer nested P2M flushes
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Kevin Tian <kevin.tian@intel.com>
Message-ID: <c6f2dcd7-81e6-3fb6-0e13-3ffb95e12bc1@suse.com>
Date: Tue, 19 Oct 2021 14:52:27 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR08CA0031.eurprd08.prod.outlook.com
 (2603:10a6:20b:c0::19) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: c1ffd7bf-af3d-47ee-f14a-08d992ff4f02
X-MS-TrafficTypeDiagnostic: VE1PR04MB6672:
X-Microsoft-Antispam-PRVS:
	<VE1PR04MB6672C9E198494919EF507693B3BD9@VE1PR04MB6672.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Myas+4x6aUH//NtNEq8J2tbdDLk37RSEBZfT68ZhejiVYPLhnk64rPAm0/fSpp50YTTqXrfP7EamFLmWu6nFu1ZhRn80eK2BPwJSC0r8DLrcPzFewItIakME3i+tcHUZ1ABRpUF1/uMZ5JX8KW41DScvIPBGzS/lIVt8mpipOCw7r5Gqqs098TqAsjlTPYF3V0I8wTRDNwGvk9VWSodP8DHwAlk02luEmAdvZwSfV6O/QRAWI6Mhhto2H4hrOzw0U11rcW/1ZgTS+7zUhWtjcVNnylqJMLWkNtl5gscp68GIJ+N95qsvVTWgOZFfWcqHIs+N1Zi5kk9irjWhQRnJ4G2RPch/BSsVoW7hA378Hh6nLsMQLiv7Fey6L2rzSm36yF5o2JzAODd2irdvGsy2JobfH7bPDCaapP9ogskan5w2X9U4+5m/nNb0+eiDne7zX0ttQtBU0AFFK1uy5q1t8t9esXKSDVbYeUc+sa42LxtExEXLuj1cOiVg7BikmMyHgskdJWpXtoMTzf8VcgdSIP0rrl3OureD1ddqWe9himt2EcOJ7me1ftIIy5YjyjUugGfj3oGUoMMPaKKgSJMnZ2ipu0Gtwhdt0273B6bQ1zXkujBpUEyCRnJ8XAny3pFQdL8n886/Cl3SJzW3PRkvslYcadYGReG9HeyFS2znpIoFkGsmFuhzQDnNsXL9R50xspsR9OHGqEdaE+EddB98I7Ehi4jffjXYQ3ijpcHFEoY=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(6486002)(6916009)(26005)(66476007)(956004)(5660300002)(16576012)(2616005)(316002)(2906002)(8676002)(508600001)(66556008)(31686004)(8936002)(186003)(54906003)(66946007)(31696002)(4326008)(86362001)(83380400001)(38100700002)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?MjIxcm81aDcybGxzZDYzRjBhQkVQQjNkWTZvSmE0MnV5MkVsWFVtMVdydnha?=
 =?utf-8?B?OVR5WDJhZk5KOW1yeEM4M2tXTlBQcmRIOVdQVy9SYTdqelpMWFI4NWM2b3VE?=
 =?utf-8?B?RHdvbGl0YWoza1oxZkN1UDZyMEMvTlM2SlJxY2Vuc2wzNitKbmtLcFd5dWkx?=
 =?utf-8?B?c1BwSjFrWGtvQWhXdThIOUFQUWU4T3o2a2lXVTFlWndDQVczZSsvbHMzWU1X?=
 =?utf-8?B?V3FBYXRsWlJaUFZXZUM2Ykx1U2h2RExLbSs3NUVKT1pjWXFTTyt5MERkVXN2?=
 =?utf-8?B?WDJycjBhL1JqR2s0OUljaktuMlpLd1ZTQWY1Q2hnWElHUTdSakt0a3pRbm4x?=
 =?utf-8?B?OW5KbmVvQ0dJQ3hzMUpXZHlpOSs0VWw0QUMxVmRQNVV1V1pwcDMrTUd2RW5E?=
 =?utf-8?B?Z3lDVm00WjZDbCs1b2swWHNNUEljb1dVRmZpNE9mb1hmZUdScmpDYjMyZGdN?=
 =?utf-8?B?V2dPK3IxNkhVV0VlWm4zd1c2V1JPQmxEaVY5Zk1uNHlmM0VWRzc4TDFWRzhq?=
 =?utf-8?B?UExXMGVOb1VXcWJ5ZmdmQ0N0M2RKSUhEbnRXYngrdnFuZTMyOHZQY3krYk5p?=
 =?utf-8?B?czNOeEZCd1kvczU3OFVBUHJrKy80SHpyUzNqdlp0QTZwaFM1SDV0YUtHdXo5?=
 =?utf-8?B?Zk1ZRktnUWErY0prUk0zcHZkSkE4SnlOQU56cGJkM2xVVXErVnMrRXplZEJx?=
 =?utf-8?B?Qy82VU5WWVhNemZJL1pBd3YydE5obVZyTmlXb2I2WFlmZTNDT092aU93NVpD?=
 =?utf-8?B?dWFSMXhlMXpuajA3bHRNdTFaNXJXSmxCZVZWc2xwQy9GY2o1QmN2Mm5tN3Fx?=
 =?utf-8?B?WUpicDRucldtd002L3pEMWFxUnBNRW5aMzJnKzdZZ1RJV0JWa2NXTW83ckZG?=
 =?utf-8?B?NGNvWTdyeFQ1Qk80bHFISldQUytBSno3MHl4NVdVVUhQUXZxSDdnc2NJV2hu?=
 =?utf-8?B?Mm1iajRHNXU3eHNSTytSVFY4Q0dnY0VWWGZiWkdjSVFRcGMvNnJKRTJkM2JU?=
 =?utf-8?B?RHJqWFZFMkRJNlF2dFN0a2t5c0NnRlZXMUQ1bHdwSnptRFQycWd4UURVWktm?=
 =?utf-8?B?UFovM1NkTjdEbmRRVXY1b2VUK3BYK0VpYzJNdDhuWDBML2Z0cjBQNXlBZGJB?=
 =?utf-8?B?S0c2ZGN5OWFHcVdSejFielBadzlZYXFEZWJtS2o0WS9wZVdBQy9QVUxnSmZT?=
 =?utf-8?B?Y3g2aEhkaFc2K1ZSL3lLVlh1clhZemJ4NFppVlRwRWVxWitybXVLYjFweVlY?=
 =?utf-8?B?bGhDcmxoazQxQ3hFSU5HbDhsM1NMTEhaVHVRaGp3dUhNSUJwS1FFQTd1MzRX?=
 =?utf-8?B?U3d1QjFxRXE0Uzl2MHpncko3cG01MG1vcVhpd29IUDIyRy9oOVlEOVRNRUpj?=
 =?utf-8?B?ZXpiNG1xVExGS2FlT2h4NkR6dDJoSTZEeW9ZOWxTVEsvNWI0Z2Z0Tm5xUnRp?=
 =?utf-8?B?a1ByVGtkQWVFTU9HdjZnOFVHQTUwSVpsQ0E1cmdneWxicVl4SGdOSXZMQjEy?=
 =?utf-8?B?dHcwM2cyOFhaNUJ6MldNQU9BbXZPM2pDY0RrbENJc2ZaMEFJRG8xa0dGTEgv?=
 =?utf-8?B?R2NYOGhzVTNkL0dqMlFGbzI5RkcrOE1SdUNtMjJPRDR4Vy8vVmtMMnhpOVho?=
 =?utf-8?B?NDBZNjcrY0xxR041Z2t4VDBqbHV5cDJBSEhCT3A0TjR1MWFQdVJLZ1c4MkhC?=
 =?utf-8?B?WHBpc1JzV3Q0VElTdks1R2FTU01EbEY3V0h4cGJ4KzNUT2dvSFBnQS9MVTF4?=
 =?utf-8?Q?Led4mPWJBjtykftu8XLXVwa/oGLYJ/Y4Lyq+9t4?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c1ffd7bf-af3d-47ee-f14a-08d992ff4f02
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2021 12:52:29.0424
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 9BrpslF+kiLIRZa82eR4x1NSuDbannwVueG858N0Ft1ARmybyiI3jDDc+d+A2beJEKdgMkoSdsKq3LrQWiBF2Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6672

With NPT or shadow in use, the p2m_set_entry() -> p2m_pt_set_entry() ->
write_p2m_entry() -> p2m_flush_nestedp2m() call sequence triggers a lock
order violation when the PoD lock is held around it. Hence such flushing
needs to be deferred. Steal the approach from p2m_change_type_range().
(Note that strictly speaking the change at the out_of_memory label is
not needed, as the domain gets crashed there anyway. The change is being
made nevertheless to avoid setting up a trap from someone meaning to
deal with that case better than by domain_crash().)

Similarly for EPT I think ept_set_entry() -> ept_sync_domain() ->
ept_sync_domain_prepare() -> p2m_flush_nestedp2m() is affected. Make its
p2m_flush_nestedp2m() invocation conditional. Note that this then also
alters behavior of p2m_change_type_range() on EPT, deferring the nested
flushes there as well. I think this should have been that way from the
introduction of the flag.

Reported-by: Elliott Mitchell <ehem+xen@m5p.com>
Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
v2: Also adjust ept_sync_domain_prepare(). Also convert the flush at the
    out_of_memory label. Extend description to cover these.

--- a/xen/arch/x86/mm/p2m-ept.c
+++ b/xen/arch/x86/mm/p2m-ept.c
@@ -1253,7 +1253,7 @@ static void ept_sync_domain_prepare(stru
     {
         if ( p2m_is_nestedp2m(p2m) )
             ept = &p2m_get_hostp2m(d)->ept;
-        else
+        else if ( !p2m->defer_nested_flush )
             p2m_flush_nestedp2m(d);
     }
 
--- a/xen/arch/x86/mm/p2m-pod.c
+++ b/xen/arch/x86/mm/p2m-pod.c
@@ -24,6 +24,7 @@
 #include <xen/mm.h>
 #include <xen/sched.h>
 #include <xen/trace.h>
+#include <asm/hvm/nestedhvm.h>
 #include <asm/page.h>
 #include <asm/paging.h>
 #include <asm/p2m.h>
@@ -494,6 +495,13 @@ p2m_pod_offline_or_broken_replace(struct
 static int
 p2m_pod_zero_check_superpage(struct p2m_domain *p2m, gfn_t gfn);
 
+static void pod_unlock_and_flush(struct p2m_domain *p2m)
+{
+    pod_unlock(p2m);
+    p2m->defer_nested_flush = false;
+    if ( nestedhvm_enabled(p2m->domain) )
+        p2m_flush_nestedp2m(p2m->domain);
+}
 
 /*
  * This function is needed for two reasons:
@@ -514,6 +522,7 @@ p2m_pod_decrease_reservation(struct doma
 
     gfn_lock(p2m, gfn, order);
     pod_lock(p2m);
+    p2m->defer_nested_flush = true;
 
     /*
      * If we don't have any outstanding PoD entries, let things take their
@@ -665,7 +674,7 @@ out_entry_check:
     }
 
 out_unlock:
-    pod_unlock(p2m);
+    pod_unlock_and_flush(p2m);
     gfn_unlock(p2m, gfn, order);
     return ret;
 }
@@ -1144,8 +1153,10 @@ p2m_pod_demand_populate(struct p2m_domai
      * won't start until we're done.
      */
     if ( unlikely(d->is_dying) )
-        goto out_fail;
-
+    {
+        pod_unlock(p2m);
+        return false;
+    }
 
     /*
      * Because PoD does not have cache list for 1GB pages, it has to remap
@@ -1167,6 +1178,8 @@ p2m_pod_demand_populate(struct p2m_domai
                               p2m_populate_on_demand, p2m->default_access);
     }
 
+    p2m->defer_nested_flush = true;
+
     /* Only reclaim if we're in actual need of more cache. */
     if ( p2m->pod.entry_count > p2m->pod.count )
         pod_eager_reclaim(p2m);
@@ -1229,22 +1242,25 @@ p2m_pod_demand_populate(struct p2m_domai
         __trace_var(TRC_MEM_POD_POPULATE, 0, sizeof(t), &t);
     }
 
-    pod_unlock(p2m);
+    pod_unlock_and_flush(p2m);
     return true;
+
 out_of_memory:
-    pod_unlock(p2m);
+    pod_unlock_and_flush(p2m);
 
     printk("%s: Dom%d out of PoD memory! (tot=%"PRIu32" ents=%ld dom%d)\n",
            __func__, d->domain_id, domain_tot_pages(d),
            p2m->pod.entry_count, current->domain->domain_id);
     domain_crash(d);
     return false;
+
 out_fail:
-    pod_unlock(p2m);
+    pod_unlock_and_flush(p2m);
     return false;
+
 remap_and_retry:
     BUG_ON(order != PAGE_ORDER_2M);
-    pod_unlock(p2m);
+    pod_unlock_and_flush(p2m);
 
     /*
      * Remap this 2-meg region in singleton chunks. See the comment on the



From xen-devel-bounces@lists.xenproject.org Tue Oct 19 13:00:34 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Oct 2021 13:00:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.213157.371287 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcojE-0001fE-Pb; Tue, 19 Oct 2021 13:00:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 213157.371287; Tue, 19 Oct 2021 13:00:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcojE-0001f7-LG; Tue, 19 Oct 2021 13:00:28 +0000
Received: by outflank-mailman (input) for mailman id 213157;
 Tue, 19 Oct 2021 13:00:27 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=eXNP=PH=citrix.com=roger.pau@srs-us1.protection.inumbo.net>)
 id 1mcojD-0001f1-Rv
 for xen-devel@lists.xenproject.org; Tue, 19 Oct 2021 13:00:27 +0000
Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 86f81dae-30dc-11ec-8312-12813bfff9fa;
 Tue, 19 Oct 2021 13:00:26 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 86f81dae-30dc-11ec-8312-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1634648426;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=pt/YAwVnGg9nRt8KV7ozFdxbkmih+uN67ZqO4JrMHts=;
  b=h242+H0iXIdl+MNlOuiYmMrpazRJ+Ax8vD5z90atIqYEA9mjF1z2GCa2
   d9W601n2tGBwtDDdHDRml+whGTrtfnh3mXy42l0D+10a9cOf/dBSklcgE
   JZMoU0ZMZFAVsPMyFBx1vQzdAqFWeSK0CNlK8/Q7CSWfV+dnGbu+Lfbzh
   M=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: 3Uyc+53rYmFPmdg9srWRkJxaUv1r3ZPPbHlZzqdOoDCOD+wIwxXHfi/jxpIX1o+RxIVXigMDiT
 Kv6VvHc4Tdt27ofIAE6Mq77ouuVY1nu0jsFtMJDS6sVSDdtbuCXS9rcPuZnxyogLBE19YG4NuC
 YF6d1z/ujxm9INBXeOVtqy1gYjzt1BGQKOZQ3QMCkdCNILmAT+qs0yMBFiWVNW7JjUPV99M/QN
 yMfl2KDHA+X0ikvRdD/ZMA3m8VJ/Xy/IdtrUESA0oZFqbkcgVjPysK/qi1cs7oPD/xfuVAYB3k
 QjseJnvfOv5kb5NcB70fdZUQ
X-SBRS: 5.1
X-MesageID: 55533627
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:1x+jSKyDvmXoWvsF7HN6t+fgwSrEfRIJ4+MujC+fZmUNrF6WrkUDy
 WVLXGuOb/aNN2D1fI0gPYy1oBxUuZ7Vn4UxSABl+yAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx
 59DAjUVBJlsFhcwnvopW1TYhSEUOZugH9IQM8aZfHAuLeNYYH1500s6w7do2tUAbeWRWGthh
 /uj+6UzB3f9s9JEGjp8B3Wr8U4HUFza4Vv0j3RmDRx5lAa2e0o9VfrzEZqZPXrgKrS4K8bhL
 wr1IBNVyUuCl/slIovNfr8W6STmSJaKVeSFoiI+t6RPHnGuD8H9u0o2HKN0VKtZt9mGt9Nty
 dROpJi3cxx3L/P0s/UcaQVdHRgraMWq+JefSZS+mcmazkmAeHrw2fR+SkoxOOX0+M4uXzsIr
 6ZBbmlQMFbT3Ipaw5riIgVort4kI8TxepsWp1lrzC3DDOZgSpfGK0nPzYIFgWxr2JoRdRrYT
 8cpMjpDdEyHWjZKZFo8Irtg2+SIqkCqJlW0r3rK/PFqsgA/1jdZwLXrddbYZNGObcFUhVqD4
 HLL+XzjBRMXP8DZziCKmlqujOLSmSLwWKoJCaa1sPVthTWuKnc7UUNMEwHh+L/g1xD4C4k3x
 1EoFjQGrrQz9U+6St7HREOp/kavrx8mR99eKrhvgO2S8Zb87wGcD2kCazdObt06qcM7LQAXO
 k+1c8DBXmM37uXEIZ6J3vLN92nqYHlKRYMXTXZcFVNt3jX1nG0kYvsjpP5YG6mpksa9Jzj0x
 z2bxMTVr+RO1ZBVv0lXEFauvt5NmnQrZlJqjuk0djj8hu+cWGJDT9b4gbQ8xa0YRLt1tnHb4
 BA5dzG2tYji962lmi2XW/kqF7q0/fuDOzC0qQcxRMV8p27zoyT9JNA4DNRCyKFBaJZsldjBO
 xe7hO+szMULYCvCgVFfMupd9PjGPYC/TI+4B5g4n/JFY4RrdR/vwc2dTRX44owZq2B1yftXE
 c7CKa6EVC9GYYw6nGveb7pMitcDm3FhrV4/sLimlnxLJ5LFPyXLIVrEWXPTBt0EAFSs8FyEr
 YcPaZHUo/idOcWnChTqHUcoBQliBVAwBIzsqtwRceiGIwF8H3omBeOXyrQkE7GJVYwJzI8kJ
 1mxBR1VzkTRn3rCJVnYY3xvcuq3D51+sWg6LWonOlPxgyovZoOm7aE+cZorfOZ4qLw/nKAsF
 /RVKd+dBvlvSyjc/2hPZ5fKs4E/Jg+gghiDPnT5bWFnLYJgXQHA5vTtYhDrqHsVFiOyuMZn+
 ++g2wrXTIAtXQNnCMqKOvujw0no5SoWmf5oXluOKd5WIR2+/I9vIi33r/k2P8BTdkmTmmrEj
 16bWE5Kq/PMrok59MjyqZqF94r5QfFjGkd6HnXA6erkPyft4Wf+k5RLV/yFfG6BWTqsqrmif
 +hc09r1LOYDwARRq4N5HrtmkfA+6t/oq+MIxwhoBiyWPVGiC7cmKXiax8hf8KZKw+YB6wexX
 0uO/PhcOKmIZ5y5QAJAelJ9Y7TRz+wQlxnT8e8xcRfz6yJA9baaVVlfYkuXgytHIbopaI4oz
 I/NYiLNB9BTXvbyDuu7sw==
IronPort-HdrOrdr: A9a23:WSX/Sa0nMMgccPHcFlzvnwqjBGIkLtp133Aq2lEZdPU0SKalfq
 GV7ZYmPHDP5Ar5NEtOpTniAtjifZq/z/9ICOAqVN/OYOCPggCVxepZjbcKrQePJ8SEzJ856U
 9hGZIOc+EZDzJB/LzHCN/TKadc/DGFmprY+ds31x1WPGVXgzkL1XYANu6ceHcGIzWvVfICZf
 yhDtMsnUvYRUgq
X-IronPort-AV: E=Sophos;i="5.87,163,1631592000"; 
   d="scan'208";a="55533627"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=CExH5B6C5JQIyT3IWVJRiP1JaFERt2YODdHXcu+L3a8trlMLRkZp/i0Zffw7/2eyI+vReEQuAnfw39q+NaC4dWBJr17i/Y3D1ScB/Oel7ZUx+GVgnGgj/NJsgBR0vGbwLbOReqy5lAHrEG9v7me+46Ffw1C3jo/dAPasXFwI/HCP4gFnqDD7STS0mCq2UHXIHCEBC/bGjEEWpIxL46hw7Ms8r04AtZBBli+lScTaH7884ICPgqxQFDwxEPc4+q6CDUh7RWScXnA1FLcakOdz3qpNhfHkexd59WWMUvCWv+6XkAHH/r+8zuiKguu16PwXvOugeW0OizQNSAIJtN0wlw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=s3X1oRj1GZ0yX3GnlWRb/uo3ksPXk7NCfOQI2i8YbCU=;
 b=dSioBWjvPyNZ8wnfGWVNt5SJy55D2CaFXvWvDhfsgEwFOzUcRhX6UsN2M7GetbbyDo0Z8G7NKRMkqX9AzGrHkjOnOVMuOutHO7qK8XXX6vEsNTLGB3EwahurYLvOZtn3ZiTXTIxPlorfN4lM+ixYMaT8PsyMJVfHe0uvs//jBKmz0QopOXRXnvRYcDIal76ZEgAkQFZuqHtrI24m+ZTcl9n38MHduzNxwJPpJIOtJvqHhqYQnpnq2TDrnp2kdSf3empSOJVx4hMkPCitAyJHJRnxburGYuSqoz0dbF7qLi42xrvmuTc4DDJfTru1oYEw5HMiL14vYIMfLY1XNTTbjQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=s3X1oRj1GZ0yX3GnlWRb/uo3ksPXk7NCfOQI2i8YbCU=;
 b=cV65Aj4FmDUThw4oVje6eTBIwDcxc0xXEYB+W92ZILYyOQZnXsDslDgB9NauCNPt6K2+e/YZ9K73rjEZl/STA92az0JNEeyKY5EDE6CUwzsrWCuOzrE9aMbhXprD+t4k899I458B+ibWULptNhN9l1k3GLQCTQB6LreL987bKC8=
Date: Tue, 19 Oct 2021 14:59:54 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Andrew
 Cooper <andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>
Subject: Re: [PATCH] x86/PoD: defer nested P2M flushes
Message-ID: <YW7BSjF3DD0jl74r@MacBook-Air-de-Roger.local>
References: <e47d51c6-1b4b-2f72-6e12-070df66c30e2@suse.com>
 <YW6g9w9XeWKsxYMV@MacBook-Air-de-Roger.local>
 <9e444a8b-58e9-ea37-0e22-474e430be5e5@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <9e444a8b-58e9-ea37-0e22-474e430be5e5@suse.com>
X-ClientProxiedBy: LO4P265CA0041.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:2ac::17) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: a763be30-2ead-4fae-a70e-08d993005b20
X-MS-TrafficTypeDiagnostic: DM5PR03MB3370:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <DM5PR03MB33708E35BC1614154CF1F1218FBD9@DM5PR03MB3370.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6430;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: EcKDBAkgbkDch7KLRELtlKTHHQhA0etsCk33fTS9z0kbVARVSabAGDo15Ci3/eNnhVVm1vcyxr3EFkp+3DBTO/3BlFXA5C4BCV+UgBsKy7rBKKjy87KcdtWKLofv33hSA3bARbD7jptfGgFWFnuN3OHbMUDYdXjDrjWP1KsW1i/PA2PEeJdKP91vK9tj0S8F7O+YJIvgv1JN7RFnrBcflAHKTe+4HYOitJW5dn6U6Rnpbzoa4t105ofICnK3EWSM1EipH6o+hP1t9pO30tZM1z36mHYkeqPoae/25Kp8S9rUdEtc0eJo9Dprf/EeX7bSwVJAk8KfEZkddFVVZFpfdd/lYI3zGRAe6HLr9YhVXACx/w0KRFJM1D9gLtBSZSwsDSB9op3fUgRP9Xc3PeQQXX/gUD1i8+asx4qF45pArgmcoSj7wllaj2zTlnPsNCv3gjStmPLK4n0GI6xbJFXeMPg9E2cN42TEORId+BKFUKNCXMkfY0Xjw9VHOyJcXU2VblGy7uiX+cne0QkyrgeDhCJIN+HxRyrbD08PKWlo3NRh0EPaGmTIk85Xaxo2EU4VbEdSKU5kk/vXq4HSTf5OWjmpw110SDbAXX+LOVtBXj613h+G2tmeCiPAHKdbomKG7zTLm46YSK03leJZ50KoMg==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(9686003)(8676002)(956004)(107886003)(6486002)(2906002)(6496006)(53546011)(316002)(5660300002)(6666004)(26005)(86362001)(186003)(8936002)(4326008)(66476007)(66556008)(83380400001)(38100700002)(66946007)(54906003)(6916009)(85182001)(82960400001)(508600001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MzRGclNKZUpPODNnWDEycUhnOHUvcUdtQkZ4OWZQS3N2dS9Lb3J6K0lsK1JC?=
 =?utf-8?B?eERBMDJqTy9iTGFXaERaMkQrUjlhZDB3NWFwc1BHZDMyNnJqdkFhTXhITXBB?=
 =?utf-8?B?TlJBckdjZUNoY2RQL1Y5STl1MVduZGlzQkZwZ1FHOVZtTWw1Nnh0V1RXdDA3?=
 =?utf-8?B?NW1UMXZnUmVWMy9UMHMyOW41ZmpPb0JPdG5BUWtKVTVoc0ZndnlReFVjUTB6?=
 =?utf-8?B?bGJIZldoMFJ1UjNrOVFvNlVmTE9mWklPN0pVTHJOa0oyZFR6dWJObG1BS3Zl?=
 =?utf-8?B?cEZuY0RZRUZ3ZnYyeGI0Rks3aXZkbGV0Y2xtTjU2dDFFRzdEVHNaMU9xYXhH?=
 =?utf-8?B?L1FvckNFV1p6a1dYa0xkZHhONkZDOHA2d3lqLzJJK2h2aHB5ZkVlMVJaMzF3?=
 =?utf-8?B?Ry9kQW5tMkhHTXJpaGdNVS9UY0JndWRVVXRndHJoL2dSWGNtdjhjaDFVNjFN?=
 =?utf-8?B?SmNDZjh0RmY3ajFCQ0tRRzRYNXd1a2ZFUnpwYUZpelh4cG5EU1VXcXlhWFc1?=
 =?utf-8?B?WGxZNmFmMGpYcUZNeCtQQ2tmYWJVNkZqL1FDU0tNeXpncHdvcHpZd2lnU0k2?=
 =?utf-8?B?dnFjR1VVOUkyUi81a3NEb2ZxMDU5VHlHdUZJNUFFOFh1cHZXc01nejFSZEdt?=
 =?utf-8?B?UGQ1SmRZeWJKOTJiSURMSUNWTHUwWlErS2xzZmVQdEFiYkdsUEdCR05NS1pB?=
 =?utf-8?B?S2VYNWExZmMxMFNOaTdJc1lMaUdzZ2VIc0lhajhBdllwYnUrRTArRFFJTUcr?=
 =?utf-8?B?Wnl2cDJ2VFhaM3BtbXFGU3hTbHdFQ3FyWmNuc3NpSHZUYitPQUpmY3FaWmtu?=
 =?utf-8?B?a0o3VlM2ZHV4dFl0N1lmSU5ic2l0N2xYdzh2SGJrVVVoZkZmMWlKSjVQS0N6?=
 =?utf-8?B?R2pNa3NGQkFuODl2ZldUSTdnd1g5dUtqRTNMUjJuaS9EU0lGM1ZIWFpXdVlu?=
 =?utf-8?B?TG5sem9lMW9RQWpLeFM0NW1WaHZ0KzBJbWFtVTBuMnAwZnZhTGI2RnphSU9p?=
 =?utf-8?B?cGc1SGhXVWVGb3dSSTNQYkNmWXh5aGowK2s1RFgrNHNoV2IxRkRIdG5xd1Nw?=
 =?utf-8?B?K1JSZy9OL1hwdGVFbW9vYUNlM2RvWnAvNDRVSEdqV0taemxEeUEvMUgzYjlz?=
 =?utf-8?B?TXVFQnV6eUpXVzZKRjNvWVhHMTN1RUhEVDE2eGxVZFJJbm5YUldCRUJoTnZo?=
 =?utf-8?B?eXJVZDA0TklDZkJWN1lRYkV1Mko3b1hwL1VzOE4vbWRtd1FWK2RwREdUbUFO?=
 =?utf-8?B?YTZDZk1ySVE5UUlIdnpUdUJLOEsrVm1PZHdBdGhRT1hITGdmendmaUNQak5T?=
 =?utf-8?B?b0wzNE1qOWtFYU0zaURLVkhuZmFzTWtCa01SZWVnNnRlam10Mm52TWJDMGtF?=
 =?utf-8?B?a1RsY1BnY1VGOHQxa3JPY0MvdGEraXlGYW5jeUFOUEZreFFWNXJyMkI0MDcr?=
 =?utf-8?B?bW5DQW5zbjJMNmpEVk1kaVJYUWgyM1FpZjAyNkEyZnoya01IMmhaaS83ZTl6?=
 =?utf-8?B?UjhyZHNBRmk4M29oOE9UZldIaWJqei9NRy9JMEo5ZlFqKzB6TTRpRWN5SCta?=
 =?utf-8?B?Nkd2VS8vNnVtMDlHd2VqUWJmR0Z2WTdyN2YyZVZUZE1RVUNvMTFqRzl2aTU3?=
 =?utf-8?B?MmFKM0NnTURrQTJZczNQWG41cDJvRFNHY2U3VkRSMjV2dGx3T3BpMGNqRGtF?=
 =?utf-8?B?aWRRc2tQQjZtSklGL0xTcmJjWjRTcGJKTnBVSzRYOGU4T1FMeDlGalBQV2tY?=
 =?utf-8?Q?OkL7cOPat9a92zImxZxjRKvn2ZL5ShpWa/zm7At?=
X-MS-Exchange-CrossTenant-Network-Message-Id: a763be30-2ead-4fae-a70e-08d993005b20
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2021 12:59:58.9488
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: T1neQRh316U+AW25BOYoLq55pDIj0znJCh0HlvdlRgrWDINbZw+SaqjaQUTf0t2XJpq+7fq88cKulnKFGi9b0g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB3370
X-OriginatorOrg: citrix.com

On Tue, Oct 19, 2021 at 01:58:38PM +0200, Jan Beulich wrote:
> On 19.10.2021 12:41, Roger Pau Monné wrote:
> > On Mon, Oct 11, 2021 at 10:17:08AM +0200, Jan Beulich wrote:
> >> With NPT or shadow in use, the p2m_set_entry() -> p2m_pt_set_entry() ->
> >> write_p2m_entry() -> p2m_flush_nestedp2m() call sequence triggers a lock
> >> order violation when the PoD lock is held around it. Hence such flushing
> >> needs to be deferred. Steal the approach from p2m_change_type_range().
> >>
> >> Similarly for EPT I think ept_set_entry() -> ept_sync_domain() ->
> >> ept_sync_domain_prepare() -> p2m_flush_nestedp2m() is affected.
> > 
> > I'm slightly worried by this path because it doesn't seem to
> > acknowledge defer_nested_flush.
> 
> Oh, yes. Iirc I did look at that logic, write down the remark, and
> then forgot to add the conditional to ept_sync_domain_prepare().
> The interactions with the real (host) flush are kind of ugly there,
> though - we then further depend on the ->defer_flush / ->need_flush
> logic, which is EPT-only. But I think I've convinced myself that
> this ought to work out.
> 
> > Maybe the flag should be checked by
> > p2m_flush_nestedp2m instead of leaving it to the callers?
> 
> I'm not sure this would be a good idea, as there are more callers.

We should maybe add an ASSERT to p2m_flush_nestedp2m to make sure it's
not called with defer_nested_flush being set then, or else it's
possible for new callers of p2m_flush_nestedp2m to forget checking
defer_nested_flush.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Tue Oct 19 13:02:19 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Oct 2021 13:02:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.213168.371298 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcol0-0002K8-B1; Tue, 19 Oct 2021 13:02:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 213168.371298; Tue, 19 Oct 2021 13:02:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcol0-0002K1-6x; Tue, 19 Oct 2021 13:02:18 +0000
Received: by outflank-mailman (input) for mailman id 213168;
 Tue, 19 Oct 2021 13:02:16 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=d5uN=PH=suse.com=jgross@srs-us1.protection.inumbo.net>)
 id 1mcoky-0002Jt-Pj
 for xen-devel@lists.xenproject.org; Tue, 19 Oct 2021 13:02:16 +0000
Received: from smtp-out2.suse.de (unknown [195.135.220.29])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id c84faea2-30dc-11ec-8312-12813bfff9fa;
 Tue, 19 Oct 2021 13:02:16 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 1273C1FD32;
 Tue, 19 Oct 2021 13:02:15 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E8F2413CC9;
 Tue, 19 Oct 2021 13:02:14 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id bF2mN9bBbmGyIgAAMHmgww
 (envelope-from <jgross@suse.com>); Tue, 19 Oct 2021 13:02:14 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c84faea2-30dc-11ec-8312-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1634648535; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:  content-transfer-encoding:content-transfer-encoding;
	bh=YTVHRMRzc/pj1UF6HL+N4N8fehWh+rniyCOu3yYFgRY=;
	b=gEFgK/EYdVjVgpprQSVLewGDBEgAuwB1M03xw2ETTwnx/MAA+JlbFUUfL3eLyeG191NcCV
	QIaVUl6ZIZGQ1m7D2Kx7nUNxq1vXink+TfH4355CqWis8MD/VTDVrVbO/3YW1/QAD8tAfF
	QRRPiuKvkDhZenZbKdBhXKdXwMu4SrM=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org
Cc: iwj@xenproject.org,
	Juergen Gross <jgross@suse.com>
Subject: [PATCH] OSStest: explicitly enable building qemu-traditional
Date: Tue, 19 Oct 2021 15:02:11 +0200
Message-Id: <20211019130211.32233-1-jgross@suse.com>
X-Mailer: git-send-email 2.26.2
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

It is planned to no longer build qemu-traditional per default.

In order to be able to continue running tests with ioemu-stubdom run
configure with --enable-qemu-traditional.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 ts-xen-build | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/ts-xen-build b/ts-xen-build
index af0dd894..75fbfe0e 100755
--- a/ts-xen-build
+++ b/ts-xen-build
@@ -144,6 +144,7 @@ END
 sub build () {
     my $xend_opt= $r{enable_xend} =~ m/true/ ? "--enable-xend" : "--disable-xend";
     my $ovmf_opt= $r{enable_ovmf} =~ m/true/ ? "--enable-ovmf" : "--disable-ovmf";
+    my $qemutrad_opt = "--enable-qemu-traditional";
 
     my $configure_prefix = $r{cmdprefix_configure} // '';
     my $configure_suffix = $r{cmdsuffix_configure} // '';
@@ -157,8 +158,11 @@ sub build () {
                 if grep -q -- $ovmf_opt tools/configure ; then
                     ovmf=$ovmf_opt
                 fi
+                if grep -q -- $qemutrad_opt tools/configure ; then
+                    qemutrad=$qemutrad_opt
+                fi
 END
-               $configure_prefix ./configure --sysconfdir=/etc \$xend \$ovmf $configure_suffix @configure_args
+               $configure_prefix ./configure --sysconfdir=/etc \$xend \$ovmf \$qemutrad $configure_suffix @configure_args
 END
             fi
 END
-- 
2.26.2



From xen-devel-bounces@lists.xenproject.org Tue Oct 19 13:04:39 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Oct 2021 13:04:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.213175.371309 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mconG-0002ws-Nc; Tue, 19 Oct 2021 13:04:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 213175.371309; Tue, 19 Oct 2021 13:04:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mconG-0002wl-KX; Tue, 19 Oct 2021 13:04:38 +0000
Received: by outflank-mailman (input) for mailman id 213175;
 Tue, 19 Oct 2021 13:04:36 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mconE-0002wf-KR
 for xen-devel@lists.xenproject.org; Tue, 19 Oct 2021 13:04:36 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mconE-0001oh-I8
 for xen-devel@lists.xenproject.org; Tue, 19 Oct 2021 13:04:36 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mconE-0007HJ-H4
 for xen-devel@lists.xenproject.org; Tue, 19 Oct 2021 13:04:36 +0000
Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89)
 (envelope-from <iwj@xenproject.org>)
 id 1mconB-0000XY-35; Tue, 19 Oct 2021 14:04:33 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date
	:Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From;
	bh=Up5fdvqg8uvFQ7gAewWyL74izpNTS4bfpRQDa1qbhsY=; b=OLSF3pPpyhPyCZLmwHmqxxgdTR
	AMYunZM7xvXdboJ/ueHVNtgPMOwwCUHQqpVm8GYZkPBYQmNwJXFYR33NMGReqIVb2rYzg2c+gxtI3
	2m8X+OPeU1HsO5Jd+JO1SrtU+WepgpEYC+TouW3JR1qVn8QfhjOTb7R8nprks3XpH9BE=;
From: Ian Jackson <iwj@xenproject.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <24942.49760.686147.851391@mariner.uk.xensource.com>
Date: Tue, 19 Oct 2021 14:04:32 +0100
To: Juergen Gross <jgross@suse.com>
Cc: xen-devel@lists.xenproject.org
Subject: Re: [PATCH] OSStest: explicitly enable building qemu-traditional
In-Reply-To: <20211019130211.32233-1-jgross@suse.com>
References: <20211019130211.32233-1-jgross@suse.com>
X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu)

Juergen Gross writes ("[PATCH] OSStest: explicitly enable building qemu-traditional"):
> It is planned to no longer build qemu-traditional per default.
> 
> In order to be able to continue running tests with ioemu-stubdom run
> configure with --enable-qemu-traditional.
> 
> Signed-off-by: Juergen Gross <jgross@suse.com>

Reviewed-by: Ian Jackson <iwj@xenproject.org>

OOI, have you done any kind of test on this ?

I'm kind of inclined to just push it and let osstest's pre-production
self-test test it.

Ian.


From xen-devel-bounces@lists.xenproject.org Tue Oct 19 13:05:57 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Oct 2021 13:05:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.213181.371330 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcooV-0003oH-AF; Tue, 19 Oct 2021 13:05:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 213181.371330; Tue, 19 Oct 2021 13:05:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcooV-0003o8-7B; Tue, 19 Oct 2021 13:05:55 +0000
Received: by outflank-mailman (input) for mailman id 213181;
 Tue, 19 Oct 2021 13:05:54 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mcooU-0003jn-NT
 for xen-devel@lists.xenproject.org; Tue, 19 Oct 2021 13:05:54 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mcooS-0001pr-3r; Tue, 19 Oct 2021 13:05:52 +0000
Received: from [54.239.6.189] (helo=[192.168.0.120])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mcooR-0007OW-Tt; Tue, 19 Oct 2021 13:05:52 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=g8YXb52Ju3ZoCyKAwm/nE1Y9OgmgrAPTCcRTFPbMDfc=; b=LW3QhCWvE3l70JjMv0/KdljF6X
	i2zxMuIle6CGHOjNvjzta9uUjJ8UwfzEOppKrUBDyD+HLOvcTr6oK9ZrQvEDGZDprGzglhmMxBAxy
	xYb/LA6+byJz441dmpMV4AWE84LIYzulmYpDCRhgG14ug/u/x+mXeszNR/y+IBkS0E5w=;
Message-ID: <7f6a0b1b-c325-95c4-a9d2-2bc28ae79268@xen.org>
Date: Tue, 19 Oct 2021 14:05:49 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.2.0
Subject: Re: Xen Booting Problem on ARM Machine
To: Sai Kiran Kumar Reddy Y <ysaikiran1997@gmail.com>,
 Stefano Stabellini <sstabellini@kernel.org>
Cc: Bertrand Marquis <bertrand.marquis@arm.com>,
 Jan Beulich <jbeulich@suse.com>, Luca Fancellu <luca.fancellu@arm.com>,
 xen-devel@lists.xenproject.org, kannan@cimware.in
References: <33C29853-D896-4E4E-91D3-4D2FA89A9B91@hxcore.ol>
 <eb5fd47b-6bc9-2eec-7f46-9ab9a42c9f1f@xen.org>
 <CAEsO4uzsCnsTtTmYHAT4NN6=girCY2NHHdAHbH6GG33D7jwe_A@mail.gmail.com>
 <alpine.DEB.2.21.2109131437030.10523@sstabellini-ThinkPad-T480s>
 <CAEsO4uwpiDO2QoqLRTOxpsYM9YSPAsbX0P=gagdEy21pk1VsPQ@mail.gmail.com>
 <alpine.DEB.2.21.2109141825330.21985@sstabellini-ThinkPad-T480s>
 <CAEsO4uyjNs97Cx8n2owDk4kKTVCycji377pm7aXHcPWzeszUTw@mail.gmail.com>
 <alpine.DEB.2.21.2109301942370.3209@sstabellini-ThinkPad-T480s>
 <CAEsO4ux_AqXBeCtbwnPAdnBnVYHTur_2EfcZBTuN4QKCq4ko8Q@mail.gmail.com>
 <alpine.DEB.2.21.2110131711280.9408@sstabellini-ThinkPad-T480s>
 <CAEsO4uxo_A4pEwP6dHK8kvYtKcbSr-ewqX1v-KLsEkyHNLFyUA@mail.gmail.com>
 <alpine.DEB.2.21.2110141536090.9408@sstabellini-ThinkPad-T480s>
 <CAEsO4uzwNHiLEZVEy90uua9YRud=Bmj=EPhzbhyk0tsEai=UQg@mail.gmail.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <CAEsO4uzwNHiLEZVEy90uua9YRud=Bmj=EPhzbhyk0tsEai=UQg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit



On 19/10/2021 13:04, Sai Kiran Kumar Reddy Y wrote:
> Hi,

Hello,

> 
> Thanks for your inputs. As you have mentioned, I tried to boot Xen 
> directly from EFI, thereby skipping GRUB. I made sure that kernel, 
> xen.cfg and ramdisk are on the first FAT partition. I still get "All 128 
> bootinfo membanks exhausted error". The following link has my grub.cfg 
> config. file and also the snapshot of the error.
> 
> Link: 
> https://drive.google.com/drive/folders/1o7WT5oB7UsaZBeY5m4mWSidT5NalzvvJ?usp=sharing 
> <https://drive.google.com/drive/folders/1o7WT5oB7UsaZBeY5m4mWSidT5NalzvvJ?usp=sharing>
> 
> I feel that even with EFI bootloader, there's some issue with bootinfo 
> mem banks and it maynot be a bug in GRUB. Let me know your thoughts on this.

As I wrote a few weeks ago. Both issues ("mem banks exhausted" and 
"Cannot exit boot services") are meant to be non-fatal. So you should be 
able to continue booting Xen afterwards.

The fact you don't see any log seems to suggest that you didn't enable 
properly earlyprintk. Would you be able to post your xen/.config?

Could you also confirm which server are you using? The ACPI table seems 
to suggest this is an Ampere Altra.

Best regards,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Tue Oct 19 13:05:57 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Oct 2021 13:05:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.213180.371320 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcooU-0003Xx-2g; Tue, 19 Oct 2021 13:05:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 213180.371320; Tue, 19 Oct 2021 13:05:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcooT-0003Xq-Uv; Tue, 19 Oct 2021 13:05:53 +0000
Received: by outflank-mailman (input) for mailman id 213180;
 Tue, 19 Oct 2021 13:05:51 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=XJzt=PH=arm.com=Bertrand.Marquis@srs-us1.protection.inumbo.net>)
 id 1mcooR-0003Xg-O3
 for xen-devel@lists.xenproject.org; Tue, 19 Oct 2021 13:05:51 +0000
Received: from EUR05-AM6-obe.outbound.protection.outlook.com (unknown
 [40.107.22.67]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id fc938249-39a4-4a50-9e48-0a2e9ec84e25;
 Tue, 19 Oct 2021 13:05:50 +0000 (UTC)
Received: from AS9PR06CA0219.eurprd06.prod.outlook.com (2603:10a6:20b:45e::10)
 by DB7PR08MB3321.eurprd08.prod.outlook.com (2603:10a6:5:20::12) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.17; Tue, 19 Oct
 2021 13:05:47 +0000
Received: from AM5EUR03FT021.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:45e:cafe::f4) by AS9PR06CA0219.outlook.office365.com
 (2603:10a6:20b:45e::10) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16 via Frontend
 Transport; Tue, 19 Oct 2021 13:05:46 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM5EUR03FT021.mail.protection.outlook.com (10.152.16.105) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.15 via Frontend Transport; Tue, 19 Oct 2021 13:05:45 +0000
Received: ("Tessian outbound 8e26f7114b75:v103");
 Tue, 19 Oct 2021 13:05:45 +0000
Received: from d642cc7d897b.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 B570AB22-6B7D-48A5-AC84-F5E7472E968C.1; 
 Tue, 19 Oct 2021 13:05:38 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id d642cc7d897b.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Tue, 19 Oct 2021 13:05:38 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com (2603:10a6:4:74::9)
 by DB8PR08MB5500.eurprd08.prod.outlook.com (2603:10a6:10:11e::8) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16; Tue, 19 Oct
 2021 13:05:36 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955]) by DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955%4]) with mapi id 15.20.4608.018; Tue, 19 Oct 2021
 13:05:36 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fc938249-39a4-4a50-9e48-0a2e9ec84e25
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=a+DAAJ6yElLUOSAXT8J9gjdVlPvdfkobfHgCkZea4+Y=;
 b=fx5siJoYXLLDnTtoDbp5AQzJn4k2aSzIrRLVTX1yC46rtbdDXcwFneGoCM66Bn4EMLz4blNo86crRgrWbBxUtLBhlUT1b1Z2GCCUIBFN3usblduTIFhO11djiK0L63UHAKIjUitlLuI5EqlBo3nAlca5At27fBh+7krHScSbfJo=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 1f83d36f314adb2c
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=GZenecUtbVvSdJZ4RI1BJfSCuTGTLu+GvFMXdzt/+I2t8mvu88UdG3G9oHBYqYLFaiGp/Pds8xfFb05chVPjictrIZAEupF9j1mZtwHbY/BORcJ7yXcxLC7z42adyGPL/isM5lisYnVjOkrMc7I7ZIRu3Xn8CyPLo9S2+7gsUhVHQv5ubH6OURUaDzyIXH0cvsqBaIGjPEz+NoFpBSiNHd6TTLW1Rg+k99Ohs7/AfaCxyxfd1VUVN2ofBBCvQwHTTM0zVcmEaVd4IytfrRHPbFS8YU3k6w+NvDMJOTtLNe/S4VbTD1BjN1Fv8OVLXjGSYmYwxCr3u9SKo2wLM/KVdg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=a+DAAJ6yElLUOSAXT8J9gjdVlPvdfkobfHgCkZea4+Y=;
 b=PAyFaU8HzR8xvjN4S3bKhkHUFW+qZe93UwK3N5fQexvvEP/ajg1fIeI6wc5TD5JtBpecteUcn7Q9LkPiyMWswQOBBo/pVt6WFSS+BpzAttqWnES4bwA+TqjJQgw/byHrM4yQv1WTgunMRkPwBbJ6WioUprURq5daXRjetNjSOCHK0Sd4TZm5+7aveUDlgAcszXOYFao04OXCcFW87L3aSEymWqB5tOZkMYNYxMfvNIb9MijU5vjchwR4zkxamunXr4sdROyUBWPUAoGlhGEvTH2UH8XuOZwhW7NkmHww9q0dKCQ0qmUOBmQraDjGsKFJ4zblzrZ7ATxwEOyCS9N2aA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=a+DAAJ6yElLUOSAXT8J9gjdVlPvdfkobfHgCkZea4+Y=;
 b=fx5siJoYXLLDnTtoDbp5AQzJn4k2aSzIrRLVTX1yC46rtbdDXcwFneGoCM66Bn4EMLz4blNo86crRgrWbBxUtLBhlUT1b1Z2GCCUIBFN3usblduTIFhO11djiK0L63UHAKIjUitlLuI5EqlBo3nAlca5At27fBh+7krHScSbfJo=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "iwj@xenproject.org" <iwj@xenproject.org>, "sstabellini@kernel.org"
	<sstabellini@kernel.org>, "Oleksandr_Andrushchenko@epam.com"
	<Oleksandr_Andrushchenko@epam.com>, Paul Durrant <paul@xen.org>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH 1/3] xen/arm: call vpci_add_handlers on x86
Thread-Topic: [PATCH 1/3] xen/arm: call vpci_add_handlers on x86
Thread-Index: AQHXxNXoEqujjTQSU06NPtp38xWsdavaQCGAgAAKNYA=
Date: Tue, 19 Oct 2021 13:05:36 +0000
Message-ID: <573C3D95-6283-4B4C-86D5-0337D061F84C@arm.com>
References: <cover.1634639117.git.bertrand.marquis@arm.com>
 <24f88973257b7038511a0ca49a992d38b295c26f.1634639117.git.bertrand.marquis@arm.com>
 <00829182-6055-ea88-27c1-44e1d3c7e8fd@suse.com>
In-Reply-To: <00829182-6055-ea88-27c1-44e1d3c7e8fd@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3654.120.0.1.13)
Authentication-Results-Original: suse.com; dkim=none (message not signed)
 header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: 357e6c41-f8f6-46f4-9b0c-08d993012a09
x-ms-traffictypediagnostic: DB8PR08MB5500:|DB7PR08MB3321:
X-Microsoft-Antispam-PRVS:
	<DB7PR08MB3321A6043349B112F579BD699DBD9@DB7PR08MB3321.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:8882;OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 Vo7v1SDXBLjCkUpaWMFcgrFTUA/GtU1aNSOcoO9lPbqy7CgCWS9dhk+DGgd6O1ciUzhyjtk5ulkbGpodC5n4Hi1kmfw78ZWjV5DsFdDBKOLqxgN/7Mgr+waB6q8SuJktYH90MRg6RUIB29plA7uu/4UdHj8HOkihkovX5ldBKxfUcGybh77iGCyVpjczS19VVCA+to55bLnTRSSdi6RGBhCTMU3FTVtZ8sSKW3K1znkmhuiWhBHhhhUQKdR7fR0iGQ6OtOoZmh7PULUbEK+haO+FiD6vI6ebMVlGV7sxZsi4H2/MTQzn/+aijaiTRvab5SRLGgaq88bGdx6LpRDo3U9krhzxPqEIxPUVFKeIo83rqrVHW/wsp9WIaayMprS0wFRcj+CrjfrjBZOcJoQXptsrWtCgxUul4RG9mYaqP0JbxKXouRVToc61u4QdLLtzreppdGTsnvweP3UmR08lrWqPEex28Lvpg0c39xgD24EDkjGVtPR84Ru+K7LnMYuFE4XRGmlUFAlNZtR7+Ri14C7DD+AbrGbJrTH6VWMyFSNlPqTc6Ak5ZzvWnMUMaxsPj9PNMJDSg0lHfsDDpu5vior+p7wrXTDs5tpXrBl/JJSi9SctHpy0I023Y1R1kJMUpbkDtRQJuumkMH68jf/9iDIXTDXBjmXpxKug0lqubjEVJ3gUh/OdQz8e3KCX+xVRO2tBckEQDAAyxrqj+DWzS8NjlWf9zj09+PMzXH/N9+sr+yW5rT0eOGW0vM2PBHAK
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB6PR0801MB2024.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(54906003)(4744005)(91956017)(6506007)(76116006)(66946007)(2906002)(8676002)(316002)(66446008)(38100700002)(6486002)(66476007)(2616005)(122000001)(66556008)(4326008)(53546011)(33656002)(86362001)(8936002)(64756008)(508600001)(186003)(36756003)(6916009)(6512007)(26005)(71200400001)(5660300002)(38070700005)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="us-ascii"
Content-ID: <6EA3B06E8B6C3644B2ABF9CF18A02C09@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB5500
Original-Authentication-Results: suse.com; dkim=none (message not signed)
 header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM5EUR03FT021.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	7928ad13-d8ed-48f8-90b7-08d99301246e
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	KMjJFKDNkHyRa1wvh4Mk5BcYl90f14Cz5uXQIvYYzEFEGgIIcZSLYSyMQljrBU05Pzqn9l3VNRiis1/e/1m2i1h+hl1QvSTiXDWVc+2BmUpfHOMk5+VqXLM/IJ9FoSyqCz2nFmwMV3tqtXnm7/KFCrl2K5TKRUQru+Q0N7ZoNmkLPvrrhFI3jBCYgdHIYrPx2PEoKgi9ZJ0/48K5ZObNdtZJIkO6D1lr6ic657G0PmhlaW6w2QinnhQU0LMDc2vZ05NpYOMADKUWxP7GqshpJWf2J/q5mb6LviyJeMS760TH7lPweLMPHQLB4fWmVAYPDpB/oU6PNusXPxsTQxrgBKesmC/r8+DffbTd8lDrsHE2Zso8P+yxH+BPh/ENGgQzODBj6Kwa0YvAcwr6WTAPD9FvhO2Bv7VHHaopUYvhHi+ot7yZGmv6im5J8eZiQX6EDuftrBkoTrJoYCfG+LCF812Sm4hXwZ+MR1v/ZmUAYObMPkt9bH2bscfUMAdpPEvt596CvKixNe4KK3CU+r2a3i+2jIJC2jZlOxajK3txKaNr/hcnsBqKzjDiV3ZebV8jT/Hd3c5AQwgJuNPbLKfo5axZb/TGP5ud3xTufDYD5HFRvo8IKLpUithCnYkt9aZ3x3Dz/GZsuyJenALj5VRlRKEDSwWE1ZKCPmfXHYzclo8KN2x9Vg0tNizZIuwb435Gn0ISvY0sAFCur02knDVD3A==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(336012)(70206006)(5660300002)(356005)(8676002)(6506007)(6862004)(53546011)(86362001)(4744005)(47076005)(508600001)(6486002)(81166007)(186003)(36860700001)(316002)(33656002)(36756003)(2616005)(70586007)(82310400003)(2906002)(4326008)(6512007)(8936002)(26005)(54906003);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2021 13:05:45.8629
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 357e6c41-f8f6-46f4-9b0c-08d993012a09
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM5EUR03FT021.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3321

Hi Jan,

> On 19 Oct 2021, at 13:29, Jan Beulich <jbeulich@suse.com> wrote:
>=20
> On 19.10.2021 12:40, Bertrand Marquis wrote:
>> --- a/xen/drivers/passthrough/pci.c
>> +++ b/xen/drivers/passthrough/pci.c
>> @@ -756,11 +756,6 @@ int pci_add_device(u16 seg, u8 bus, u8 devfn,
>>     if ( !pdev->domain )
>>     {
>>         pdev->domain =3D hardware_domain;
>> -#ifdef CONFIG_ARM
>> -        /*
>> -         * On ARM PCI devices discovery will be done by Dom0. Add vpci =
handler
>> -         * when Dom0 inform XEN to add the PCI devices in XEN.
>> -         */
>>         ret =3D vpci_add_handlers(pdev);
>=20
> I think it wouldn't hurt to retain a (re-worded) comment here, maybe
> along the lines of "For devices not discovered by Xen during boot,
> add vPCI handlers when Dom0 first informs Xen about such devices."

Ok, I will add that in v2.

Cheers
Bertrand

>=20
> Jan
>=20



From xen-devel-bounces@lists.xenproject.org Tue Oct 19 13:07:58 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Oct 2021 13:07:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.213197.371342 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcoqT-0004p5-Oa; Tue, 19 Oct 2021 13:07:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 213197.371342; Tue, 19 Oct 2021 13:07:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcoqT-0004oy-LW; Tue, 19 Oct 2021 13:07:57 +0000
Received: by outflank-mailman (input) for mailman id 213197;
 Tue, 19 Oct 2021 13:07:56 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=d5uN=PH=suse.com=jgross@srs-us1.protection.inumbo.net>)
 id 1mcoqS-0004os-BU
 for xen-devel@lists.xenproject.org; Tue, 19 Oct 2021 13:07:56 +0000
Received: from smtp-out1.suse.de (unknown [195.135.220.28])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 2fc6fe03-a34d-4816-b964-1595102b2833;
 Tue, 19 Oct 2021 13:07:55 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id C8D7621A93;
 Tue, 19 Oct 2021 13:07:54 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id B1DE913CC9;
 Tue, 19 Oct 2021 13:07:54 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id QmUzKirDbmHhJQAAMHmgww
 (envelope-from <jgross@suse.com>); Tue, 19 Oct 2021 13:07:54 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2fc6fe03-a34d-4816-b964-1595102b2833
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1634648874; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=PJ6UWPgStl8cPJHXbxwStnAGwOYnh680a8RYn4T+NGA=;
	b=IzPmeWenC4Fp40o6ciUIaAiwNbkuatLDzHasiXfb86S+0sb27IPxfLrAqk9KITWl2SUEGe
	yrAiNBP8oKwkL3/kOMuz73RDb9l32Jvssh9wE2sraMnlzz79eEik1NO0vaDISCIUBYvGyy
	7GoZKf2mxRA7gsVTvEbyYWPDy6yYf6Y=
Subject: Re: [PATCH] OSStest: explicitly enable building qemu-traditional
To: Ian Jackson <iwj@xenproject.org>
Cc: xen-devel@lists.xenproject.org
References: <20211019130211.32233-1-jgross@suse.com>
 <24942.49760.686147.851391@mariner.uk.xensource.com>
From: Juergen Gross <jgross@suse.com>
Message-ID: <152bf281-6921-42bd-a87a-054056a385ff@suse.com>
Date: Tue, 19 Oct 2021 15:07:54 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <24942.49760.686147.851391@mariner.uk.xensource.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="NxW4JdUChGlCBZ4hRvHt4CqR4Wy8xR0fC"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--NxW4JdUChGlCBZ4hRvHt4CqR4Wy8xR0fC
Content-Type: multipart/mixed; boundary="87fFNOMLy7vyutFoReN2k9nty8heZcOz2";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Ian Jackson <iwj@xenproject.org>
Cc: xen-devel@lists.xenproject.org
Message-ID: <152bf281-6921-42bd-a87a-054056a385ff@suse.com>
Subject: Re: [PATCH] OSStest: explicitly enable building qemu-traditional
References: <20211019130211.32233-1-jgross@suse.com>
 <24942.49760.686147.851391@mariner.uk.xensource.com>
In-Reply-To: <24942.49760.686147.851391@mariner.uk.xensource.com>

--87fFNOMLy7vyutFoReN2k9nty8heZcOz2
Content-Type: multipart/mixed;
 boundary="------------60E24F63DAA496CBCFADFCD9"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------60E24F63DAA496CBCFADFCD9
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 19.10.21 15:04, Ian Jackson wrote:
> Juergen Gross writes ("[PATCH] OSStest: explicitly enable building qemu=
-traditional"):
>> It is planned to no longer build qemu-traditional per default.
>>
>> In order to be able to continue running tests with ioemu-stubdom run
>> configure with --enable-qemu-traditional.
>>
>> Signed-off-by: Juergen Gross <jgross@suse.com>
>=20
> Reviewed-by: Ian Jackson <iwj@xenproject.org>
>=20
> OOI, have you done any kind of test on this ?

No, this was a pure "lets do things in a similar way as the other
options" approach.

> I'm kind of inclined to just push it and let osstest's pre-production
> self-test test it.

You are in a far better position than me to decide this. :-)


Juergen

--------------60E24F63DAA496CBCFADFCD9
Content-Type: application/pgp-keys;
 name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Transfer-Encoding: quoted-printable
Content-Description: OpenPGP public key
Content-Disposition: attachment;
 filename="OpenPGP_0xB0DE9DD628BF132F.asc"

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy=
cWx
w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O=
f8Z
d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y=
9bf
IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq=
G7/
377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR=
3Jv
c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA=
QIe
AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT=
hpw
dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0=
MbD
1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv=
oPH
Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v=
5QL
+qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ=
2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC=
QoL
BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr=
Wf0
teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC=
/nu
AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh=
ITT
d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm=
XBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz=
80h
SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC=
AcD
AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn=
FOX
gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1=
jnD
kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0=
N51
N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l=
otu
fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1=
tqS
EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA=
hsD
BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3=
g3O
ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5=
dM7
wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5=
D+j
LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm=
V2x
AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N=
Eaw
QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW=
nHI
s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR=
wgn
BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV=
bVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk=
pEd
IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA=
QAB
wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw=
Tbe
8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1=
vJz
Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8=
VGi
wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW=
svi
uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX=
zXs
ZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------60E24F63DAA496CBCFADFCD9--

--87fFNOMLy7vyutFoReN2k9nty8heZcOz2--

--NxW4JdUChGlCBZ4hRvHt4CqR4Wy8xR0fC
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmFuwyoFAwAAAAAACgkQsN6d1ii/Ey/3
NQf+Kk+pYHTbPeLcMrcTV4Gij43N0lXcQ474NRu1dh0N/WqyxF6WGBaj8EgBY8E/EsLNitS6shtg
lA5jZ2k1/+f2iQwEbpex3Y4zRekPA5uwunKVZsLV7KYCPHYNntHyaDlfi0H4L3eBhN1U2ZSoMgyM
o61Wu8ZtBA4FpCyTg9ScSuodw5SKf562Moxi5Rp9A3qPQtzhWneYo4+2+x61xvKqlYhu6bg8RAzS
Cp8mQl+/3YpWsLPjbToU1DiJaKIHrNnfQnD9NVPVWLMI9cGGtOKi53Wku8w2BeOELnabIxjL7nqi
9MaW+u401IW75CZvSCH3Znl2wuepFekLUhb153/Qsg==
=vAzo
-----END PGP SIGNATURE-----

--NxW4JdUChGlCBZ4hRvHt4CqR4Wy8xR0fC--


From xen-devel-bounces@lists.xenproject.org Tue Oct 19 13:11:22 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Oct 2021 13:11:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.213205.371352 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcoti-0006GX-Cn; Tue, 19 Oct 2021 13:11:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 213205.371352; Tue, 19 Oct 2021 13:11:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcoti-0006GQ-9j; Tue, 19 Oct 2021 13:11:18 +0000
Received: by outflank-mailman (input) for mailman id 213205;
 Tue, 19 Oct 2021 13:11:16 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=XJzt=PH=arm.com=Bertrand.Marquis@srs-us1.protection.inumbo.net>)
 id 1mcotg-0006GK-BG
 for xen-devel@lists.xenproject.org; Tue, 19 Oct 2021 13:11:16 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com (unknown
 [40.107.21.83]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 1705fb75-e4f2-4088-a77c-05c733c85c3d;
 Tue, 19 Oct 2021 13:11:14 +0000 (UTC)
Received: from DU2PR04CA0335.eurprd04.prod.outlook.com (2603:10a6:10:2b4::11)
 by AS8PR08MB7338.eurprd08.prod.outlook.com (2603:10a6:20b:445::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15; Tue, 19 Oct
 2021 13:11:13 +0000
Received: from DB5EUR03FT024.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:10:2b4:cafe::ea) by DU2PR04CA0335.outlook.office365.com
 (2603:10a6:10:2b4::11) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.17 via Frontend
 Transport; Tue, 19 Oct 2021 13:11:12 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT024.mail.protection.outlook.com (10.152.20.67) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.15 via Frontend Transport; Tue, 19 Oct 2021 13:11:12 +0000
Received: ("Tessian outbound a8bfe25d7364:v103");
 Tue, 19 Oct 2021 13:11:12 +0000
Received: from fc37a889b8b2.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 154B152E-3614-4AC1-899E-7745CE50D28B.1; 
 Tue, 19 Oct 2021 13:11:06 +0000
Received: from EUR02-AM5-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id fc37a889b8b2.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Tue, 19 Oct 2021 13:11:06 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com (2603:10a6:4:74::9)
 by DB6PR0801MB1863.eurprd08.prod.outlook.com (2603:10a6:4:76::17) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.17; Tue, 19 Oct
 2021 13:11:03 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955]) by DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955%4]) with mapi id 15.20.4608.018; Tue, 19 Oct 2021
 13:11:03 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1705fb75-e4f2-4088-a77c-05c733c85c3d
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=aRcSlt9I9aogKe+yx/QllPguBBDfVQPMojSfJPX5o/A=;
 b=T5cRfDBgtgDBHJyYX5Ly+OR1LVS2aB7sGxzekET02Y+c1O+vRszw0zhtp35ewYRq6yNTZAAlfrfBSfwWudLE/HXXZbOfBq+abYkZW8/GAdbG8uX6u4E/8mPR3jihaPt2i93jekPYoS7vxbGAg5cvi2W1KlZ2Yr++KgCpGQJHlY8=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: dcee0aca3fbe1fe4
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=WE9r7RqdcZoKYCZGTSgMnH4AKick3v2qtPJ5zmUNpSsoRhMfwd98L/1hc4YxVucySPRfMtQS8l0IzZ/pa6uOrtjnYV0nYeHlDFEayU6vmZANB5LolCjp6FAJcVBPsbK36whgjOAKI0GlIz8sfVh9IPkKQ2xpifBDfnMXplGkXWqRClvEcBRNeJjCE+FR4pNrc4x0XmbBQxYdfBdaPWkhFkY6uH52QL5hA7PuX39tqlLJryHwAtBqcAuK2Zd0gQMctMpejK7Co2Csfb/xUeeTMG1fAz9L1VsYwlM5SXpPILN/GNlnsnm91eeybsunCdFWNvbHufI+XwVwReNQIzlEmA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=aRcSlt9I9aogKe+yx/QllPguBBDfVQPMojSfJPX5o/A=;
 b=j0HTqyR2+vHl7AF35FwZffLhL8exVrDehj7ZN0TqBnwwB6j/k8VXiII7rKm8Zb7qvd5SaHPzVkjYhHB+wzRfzi5xeyR0ZjR50NUnKpMUqS8Qt7Ir5okBdeujYlCrjIxm03oFrCedPRfC01IJGtNg1b//mcBf5CA7x5VYHPIAzHAC/eVVnAlKwdxBQaQHFNUxe3YABWkSyVJzsByHzRXWVgN3SWs/yXFA/+EFcUCES4uaSlolOya5P3pKsj/UwL4G9zweivpWGQel/3LPwRsUqJO//lrhJh9tSPUv3Nu7UDZ+6iC0ztB8hWMAFo4toJqNZvaTgiJtx8o+ofm/wLPdoA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=aRcSlt9I9aogKe+yx/QllPguBBDfVQPMojSfJPX5o/A=;
 b=T5cRfDBgtgDBHJyYX5Ly+OR1LVS2aB7sGxzekET02Y+c1O+vRszw0zhtp35ewYRq6yNTZAAlfrfBSfwWudLE/HXXZbOfBq+abYkZW8/GAdbG8uX6u4E/8mPR3jihaPt2i93jekPYoS7vxbGAg5cvi2W1KlZ2Yr++KgCpGQJHlY8=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "iwj@xenproject.org" <iwj@xenproject.org>, "sstabellini@kernel.org"
	<sstabellini@kernel.org>, "Oleksandr_Andrushchenko@epam.com"
	<Oleksandr_Andrushchenko@epam.com>, Paul Durrant <paul@xen.org>,
	=?iso-8859-1?Q?Roger_Pau_Monn=E9?= <roger.pau@citrix.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH 0/3] Fixes: PCI devices passthrough on Arm
Thread-Topic: [PATCH 0/3] Fixes: PCI devices passthrough on Arm
Thread-Index: AQHXxNXsWVtDOu3dTEyPepRQ+pXuJKvaP3CAgAAMbYA=
Date: Tue, 19 Oct 2021 13:11:03 +0000
Message-ID: <BEDBA4C6-CAA4-403B-88D4-06AC428DD83D@arm.com>
References: <cover.1634639117.git.bertrand.marquis@arm.com>
 <e22e85d1-2c57-29a3-9f4b-b2754069026b@suse.com>
In-Reply-To: <e22e85d1-2c57-29a3-9f4b-b2754069026b@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3654.120.0.1.13)
Authentication-Results-Original: suse.com; dkim=none (message not signed)
 header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: c7f4278d-6151-4d50-cad2-08d99301ecfc
x-ms-traffictypediagnostic: DB6PR0801MB1863:|AS8PR08MB7338:
X-Microsoft-Antispam-PRVS:
	<AS8PR08MB7338A10414E54DF48EC7DED59DBD9@AS8PR08MB7338.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:10000;OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 eAbmwK6BAFnR9Q9aD93JOry1lBJiiILohR7yF0xHxxsL6VisVrib3YMX0bNjAlzjzfNYHiaqJIeSp+sGGGSzS3fhrA2xSatf8kH742Td+n0ZDRR4hIKeUOW84aTJ0xNhpB7ANIoSs1If3qkRZMiUXYEK+oZ7ZMlmsIbuqT/bdJ7aFzBglGL+oWvT4aYU6IOV+Vmigx7E2A9QPxrXH1+w9jl3wUIqaJP9rYMaxK7parJs3Ilpop1FtCGpCcGMmtW5P6EWmO2oknz2USkzd2KT8bZawbNnagNWLZQGrJCOQnvHjnKduCVXt01r3wYfbmT7rB5rSxbUquwQw/VPpqJ+8JCDFJIZzbAO+P0Mq4ZH2YGg+U1k3wSE8JwZkTYAuONJCq0YWGgO43DPpn4z1O2ZHTnMOd18Byccu7f0BVL4PkMKfatpPdz0QmrVHW6dbLrhyZ82w66vJEforx0lpYXtCkuMmyK2SN/+kCgRHqXRt9EHpuERLebjHlbZyHIedTKRC+1Li8gmrvLEfcT709niNLH+ectwe4zNH5ZV6YnRExBouFYhLMIUI9htfHgfSl7KzV3hTeEWSzSoLUnSXjE838JWeHQ/zcl8Z4FIT75ZGj1A9D9YI0wHVA/kf+PlxDVGVT7PvGuTfh/y68Gjj1927iWQAIROJvOmZloiP17Bo6F4AjwbtX203AHF89FnFoLBw1R7UiFbY2fJiePkgam8x11Cmj278hEF0tGgWLFQUr26vxjE7DV7ip+6xUZcE8wNCnPfLp1R0eQwUkVHsUsyLWg1Eg7r+nQYvBiT5rwOawNSl3TUzHy1uzuaoZ1rLPye
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB6PR0801MB2024.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(54906003)(2616005)(2906002)(53546011)(4326008)(6916009)(6506007)(186003)(71200400001)(26005)(6512007)(33656002)(508600001)(6486002)(966005)(86362001)(91956017)(76116006)(66446008)(64756008)(66556008)(66476007)(5660300002)(316002)(8936002)(66946007)(8676002)(38100700002)(36756003)(83380400001)(122000001)(38070700005)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="iso-8859-1"
Content-ID: <3A00A48F40ADFB448688BF390B8CC8F1@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0801MB1863
Original-Authentication-Results: suse.com; dkim=none (message not signed)
 header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT024.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	38302698-1d98-4e4f-2df5-08d99301e776
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Widic5yuAOTdCvlbVJTuFZ8WJG6q9NuJ5OeLtosXp2nKIh24zYjNTHjY7jQISQ2swke75ptyFp0JxJ77b/syiOpHhlcBi35eg51TbcmHndmroMK6ascej+6R/NJJEqvNoNpEtNhpi4B+ifkyVeYJHWnRKiGfUQtZH9xyU3nlu6hhR3hs8Qec1ONaGcWe4q7uvRHeRMTIbya0MUuXe6KRYz065Jy/QeF6UROI0Y4O9ebjAmtHfYeEZMknZqZDZ0ryu6/OYybDGpHHf0SXGNBmoNEIDohhYhH4uHA5+wZLzvzvJ/2X4VoVK25jx3cmkTi8bCjKhUNqMODWME/Ruv+RcwZ9TY2mpgFwV3VnbVxacTWHMZJ8rq2jiVaQEPTcqzNzWo541KNZEakbIlgo5AYLcL5JATD6o3qdif3qU4KLODZr2qQK2M5CHgJ6Bfp4z6NC2YicEZK9tJTtIkdg6kFF1BcC2O0oI9nChHmz0v8mrMDLfx/E4PdRohNZRpOVVUBefQFnMotmCEp2mGbNTkMN+v+p+DLsf2YRxGb1cyhptlgNXQ1sLq9blLklkew48p2NJGkLpEmUnlEz/7r8pjU9r0n0btov9A5CENUO9PCZbqCLXhmnzIl334hiOieRiEiFarMgWK9dUz8nq4pZhkDtnyOFIUJuwrSMsexAQxmL3XZIdFxp4I2F2KHdeq2DZUgXMoVDuucVhI1lA5wPgMxz6iv2Nv0e/2f5ffiLOHMYjlX2f1MD4Zkc5/5Fosx9PTpxR94NpqOl2brM9pCwBPj6L3oKlU2w4KlYjhFyVsyrNVE=
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(6512007)(36756003)(36860700001)(508600001)(70206006)(5660300002)(966005)(8676002)(6486002)(70586007)(186003)(26005)(6506007)(53546011)(336012)(33656002)(8936002)(2616005)(4326008)(54906003)(316002)(86362001)(356005)(47076005)(81166007)(2906002)(83380400001)(82310400003)(6862004);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2021 13:11:12.9806
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: c7f4278d-6151-4d50-cad2-08d99301ecfc
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT024.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB7338



> On 19 Oct 2021, at 13:26, Jan Beulich <jbeulich@suse.com> wrote:
>=20
> On 19.10.2021 12:40, Bertrand Marquis wrote:
>> This patch serie is a follow-up after various findings on d59168dc05
>> ("xen/arm: Enable the existing x86 virtual PCI support for ARM") as of
>> agreed in [1].
>>=20
>> It does the following:
>> - enable vpci_add_handlers on x86 and not only on arm
>> - remove __hwdom_init flag for vpci_add_handlers
>> - add missing vpci handler cleanup in error path during pci_device_add
>>  and pci_device_remove
>>=20
>> [1] https://marc.info/?l=3Dxen-devel&m=3D163455502020100&w=3D2
>>=20
>> Bertrand Marquis (3):
>>  xen/arm: call vpci_add_handlers on x86
>>  xen/vpci: Remove __hwdom_init for vpci_add_handlers
>>  xen/pci: Add missing vpci handler cleanup
>=20
> Imo all three changes need to be in a single patch.

I will merge all changes in one patch.

> An option might be
> to have first what is now patch 3, with CONFIG_ARM conditionals, which
> the subsequent patch would then delete. But what is now patch 1 cannot
> come before patch 2, and patch 2 alone would unduly impact x86 by
> moving code from .init.text to .text for no reason. (Still it could
> technically be done that way.)
>=20
> But let me also comment patches 1 and 2 individually (patch 3 looks
> okay, apart from the ordering issue).

Thanks
Bertrand

>=20
> Jan



From xen-devel-bounces@lists.xenproject.org Tue Oct 19 13:14:34 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Oct 2021 13:14:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.213211.371364 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcowr-0006sb-S4; Tue, 19 Oct 2021 13:14:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 213211.371364; Tue, 19 Oct 2021 13:14:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcowr-0006sU-OX; Tue, 19 Oct 2021 13:14:33 +0000
Received: by outflank-mailman (input) for mailman id 213211;
 Tue, 19 Oct 2021 13:14:32 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=gzZp=PH=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mcowq-0006sO-J7
 for xen-devel@lists.xenproject.org; Tue, 19 Oct 2021 13:14:32 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 7ea90e40-30de-11ec-8312-12813bfff9fa;
 Tue, 19 Oct 2021 13:14:31 +0000 (UTC)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2174.outbound.protection.outlook.com [104.47.17.174])
 (Using TLS) by relay.mimecast.com with ESMTP id
 de-mta-27-BSV9uP-xPGucjqdc-OPwnA-1; Tue, 19 Oct 2021 15:14:29 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB5903.eurprd04.prod.outlook.com (2603:10a6:803:e0::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15; Tue, 19 Oct
 2021 13:14:28 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.018; Tue, 19 Oct 2021
 13:14:26 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM5PR0101CA0036.eurprd01.prod.exchangelabs.com (2603:10a6:206:16::49) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16 via Frontend
 Transport; Tue, 19 Oct 2021 13:14:26 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7ea90e40-30de-11ec-8312-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634649270;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=M69N8ZbxezuNVjrG5FyR3dJbltvZLSQ9BF8hIxc9x0Y=;
	b=OjN/y8fzCB6+hKZXbRsrWnCfJsFCXqNEi0zmSCGLOP2voF9TbSp8wLXQplJ5SCLTklwkmd
	lSKCn31RqmX4/u+08lh75iCv1cekcObtpsOMx9/NQOCLvo9YCgaR6l4TXQ7XAyZH4zf0mY
	y4K6CheHjYHUj9HeksxCyNwkOM0DmF4=
X-MC-Unique: BSV9uP-xPGucjqdc-OPwnA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=esrU5CZGZC52Go8ArxKlsCCPLgRiojb97vdzCYTL/X3wm+I3fCpJgMIKXjZA5lIzQbJiT5S5aCEeeFKatc2ol/Cp/yu+4H6Q9chmaywIL4zFQ9IUpP97bBsiS+2qRZIdwvZUS5PSDgUR9ks3GwYwP5uuHzyyrUxwkwBQKbX7+LiNzI6HBFu3xaLb0GpllfqQ5G0kv6/vnH+fQTfgUqaqYxE6vbVHR2qRXA39/oNcEwPL9J0wAPjBoT1/rZ2fmeZ1sru02ttD6ko6NnWMmbkg4oE2b7PFxnCm0BWlyqHBvhkXdKCVOdF/NrofODKrsJqVTtGXui6Dr7hDhc0/KBXssw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Kd3PzkoGE/6GBdKf/jroNS9Vl2nsZIfpfqb68T2MbZU=;
 b=HVBmlCpRPOkK4IST0xa6XT2M8IOAnaq8b5GIa1txzKfr6neMoy9sfLYKPLKa8RjBSLQLuuzEk1kpYnxm3cSVmSbd4U2Jmqckj8DiTMvG1A9u+QRcyJqVVRixWri+hDx3GumK1DbXfEUfT0Qqyiq7cSCOpihmSHLFgJE+OBjki2ocDDzZLp8AnRWJCbi9Du000vcn0gUOTsGITBe+qJ+7kPBw/Pqb4ODRPKWsfxcoRZYkapS6YD6KjcfJdaTjTyINhQtpaxCu/0v+XL8DhdFOfGpUqyo91YdXUMqhPF8Up55MPfXK1WQj0wj9GbgviuK/fGmRcagoroRg4s9DzmUadQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: citrix.com; dkim=none (message not signed)
 header.d=none;citrix.com; dmarc=none action=none header.from=suse.com;
Subject: Re: [PATCH] x86/PoD: defer nested P2M flushes
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>
References: <e47d51c6-1b4b-2f72-6e12-070df66c30e2@suse.com>
 <YW6g9w9XeWKsxYMV@MacBook-Air-de-Roger.local>
 <9e444a8b-58e9-ea37-0e22-474e430be5e5@suse.com>
 <YW7BSjF3DD0jl74r@MacBook-Air-de-Roger.local>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <787987c6-2fc1-1bae-f9f9-f1c806de1044@suse.com>
Date: Tue, 19 Oct 2021 15:14:25 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <YW7BSjF3DD0jl74r@MacBook-Air-de-Roger.local>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM5PR0101CA0036.eurprd01.prod.exchangelabs.com
 (2603:10a6:206:16::49) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 70499e08-b302-4e25-bc1c-08d993026071
X-MS-TrafficTypeDiagnostic: VI1PR04MB5903:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB590360DBE8B0C4895A71D2D4B3BD9@VI1PR04MB5903.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:5236;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	4fAjNFG0f2bAXXLiOy7pC+4odk/MZkS60qTIdSvO6qvMyFBhJKjN3qG/d/ejm97U2OQfhIj/9wMHeqLRfo2bIRkwR//ste1N5oDHWS5MKAQG1uo8B/se+bMa82mTCMiIUT+UnDw27g/x1GTKya+EfMyCSboOAMvw/vFBDcCCD78Hb/6zDPeLyzwqRvyMU0peGLvvyXGPehjFoNohl7+k//Njch8Vyo/AvUB/obzSmQCiM6e2xj5UZaZj9yPqySFC/pvhm36phn24v9Vd3v36suu5Tj/OV/kcHmKtawLQgvFsv06WOGxHhYyRrHA/tuCwRGspxDBfSmH520MOj4EqgAm+NLB4HNrdluCHEJ3hUOBREHel0Fr4lXMweu0nrjw+r0RTTWejyMBQNmGNwCJbIlgTcsJK5ju006HoRSV2SsFQbFtGUSxGn3kxp5b8cWUFrZ7FZANmJGzTKgbZmA7UQ1+Kxz0C76PwpjnCv0V83Ad6UwSXLU5shJt8aca+0Cnx7K7t2E+h6AozSVbKjJXkla4lbvPXT4ocUepACFqPmxgMXQjEf9v2o4kfqb4wSflzuHq/DId8ls5rd78JteImFVuazth2bNjH3mKkHYl8XC5hz9ianj+8ejCDalRAxTn2M/N8CLWGtc42aK+auMrklUG0a8OdSeNH7/lRAfNcSwEbzXAjVgPKXoqKfUWnnBGTljZDwiL9APtW/fX8qHIOxg==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(6916009)(53546011)(5660300002)(86362001)(31686004)(54906003)(186003)(38100700002)(508600001)(2616005)(26005)(16576012)(31696002)(8676002)(2906002)(66556008)(956004)(66946007)(6486002)(66476007)(316002)(83380400001)(4326008)(36756003)(8936002)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?UQ4InMKoBtLtgR3aumiz1Ed3RcoKM9/IONqKElkzSx7fLFXcFWZV1glJ2XCS?=
 =?us-ascii?Q?aHApk/CYvPQ3CG9DNpl48rOXlLIyMmKJljwCsV7nuVvDE9l39UCVq8Z4YbDJ?=
 =?us-ascii?Q?qwwxSO7L5WF9CFC6oqYGylphThpyuOX7w0kOXqMYLsmQmTT0u+RNYUFhjboX?=
 =?us-ascii?Q?gyNwxExtD5cTXO5b1LYkp/rlAL6DorR1Vj56kGL1B8Lb17vDtRpcy7Rv6u8/?=
 =?us-ascii?Q?sr3txlZF8+8cRc8vpPFD/zaUtKCuLRkVBM2PJabFVkSk0gK4Ekt6aG3IJc4Z?=
 =?us-ascii?Q?2u0ETJp9iEoz8N+UtlR1l8vaAGsyn4fIRhVuOKgkVEzYTiF9gA+kmSJo/Z/E?=
 =?us-ascii?Q?IFiHW2GKXFHlrrdO+Ujxh5ZdkH3rwsFjs7pnayzkeqxpmcE+Wsj3hX82SJn7?=
 =?us-ascii?Q?TASpZUzgNEN5MbE2TgvXeLBz658KoE7/0/owexSuKry2BA4yol3/xt2Rx8Lc?=
 =?us-ascii?Q?yec2yhZqYbKGPJjPQC9YvnlNeHBKr328ZKvBe9Pw68pTGMewnR7KOOa+1D4B?=
 =?us-ascii?Q?5ABu9Ig4Ua2wc7a7yXpUO7hkkpHYkcsaAYigQZl1T6clgxE3NItpSeKcOVnQ?=
 =?us-ascii?Q?PjUV1nkYKVCP/OU/09FSsmJQHrcTC+BF5xQqAjt2nzha0+BdF7ahpgBrcmUt?=
 =?us-ascii?Q?CkeUX1m0nnMW87JYRDgAhRWdCMiGUYQj30xvt4SNuOXnf8H71JeHVt0NjxdY?=
 =?us-ascii?Q?fe8s3bytIUsVxB4CtY/5Ajia5o6/Y+nK10Hysxe4KsbF2jpJ36sAKYP+lNw7?=
 =?us-ascii?Q?7Tr6YZ3f7y8i3laxvuFKUZDZGTaaHJWuL65nT8N5GWdY8F7Tbbcvruel2LvQ?=
 =?us-ascii?Q?q/1yabSTFWDOxl04Yqpa0vDWLSVRw/h/gRrIByHvNfyfCCCH0xI1xpimmSV9?=
 =?us-ascii?Q?rSJ4hDqQyhLX3EDe4QZ1Z4YF2nAocUqGlkkERzT49l7VRWe2XKtUt+mr9Qbv?=
 =?us-ascii?Q?alqywbrOES8l+XjxImycFvMQwzBumpO4Ld/BWG5aMyuZG2jpuaZSVXmAr7bR?=
 =?us-ascii?Q?R3eIGhQruDP2Yp9eAMIvm7mqjtpcKTo9PfGtmHfi7jZfCl5E+iG9fkV/C1HN?=
 =?us-ascii?Q?hI4lXfHxirVMIER3c7IimeUTY4Zot6QlubGZP9AP+AJRWxdnztW9V3e7h1Oe?=
 =?us-ascii?Q?ahvDT3JZOpqkDYNvbRn2bpbJ/3MbTSsb4jtwprDGbTFJfgm8g3rO6kgtCdMC?=
 =?us-ascii?Q?DaP4N/nICvrPg6s+CEO160QyAp6pK5UMdf4sDxb01n3INUwqzCds8Zu2kDRS?=
 =?us-ascii?Q?AeZ8PyYPMHF7b9I8sLetziLrkt8R4bGl673/Z2BmHcJhM/xTInS4DVRtp3pV?=
 =?us-ascii?Q?Sh+gKrTCkmjSkcph6f351qih?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 70499e08-b302-4e25-bc1c-08d993026071
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2021 13:14:26.7909
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: G5x8rAgkQbFVows9vXFnAJ5KnAK8KKXDmkCBEVQE59WdlG8IttFpL/BCW7KJ7IgEKqTranDO2zgATfWeflJcCQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5903

On 19.10.2021 14:59, Roger Pau Monn=C3=A9 wrote:
> On Tue, Oct 19, 2021 at 01:58:38PM +0200, Jan Beulich wrote:
>> On 19.10.2021 12:41, Roger Pau Monn=C3=A9 wrote:
>>> On Mon, Oct 11, 2021 at 10:17:08AM +0200, Jan Beulich wrote:
>>>> With NPT or shadow in use, the p2m_set_entry() -> p2m_pt_set_entry() -=
>
>>>> write_p2m_entry() -> p2m_flush_nestedp2m() call sequence triggers a lo=
ck
>>>> order violation when the PoD lock is held around it. Hence such flushi=
ng
>>>> needs to be deferred. Steal the approach from p2m_change_type_range().
>>>>
>>>> Similarly for EPT I think ept_set_entry() -> ept_sync_domain() ->
>>>> ept_sync_domain_prepare() -> p2m_flush_nestedp2m() is affected.
>>>
>>> I'm slightly worried by this path because it doesn't seem to
>>> acknowledge defer_nested_flush.
>>
>> Oh, yes. Iirc I did look at that logic, write down the remark, and
>> then forgot to add the conditional to ept_sync_domain_prepare().
>> The interactions with the real (host) flush are kind of ugly there,
>> though - we then further depend on the ->defer_flush / ->need_flush
>> logic, which is EPT-only. But I think I've convinced myself that
>> this ought to work out.
>>
>>> Maybe the flag should be checked by
>>> p2m_flush_nestedp2m instead of leaving it to the callers?
>>
>> I'm not sure this would be a good idea, as there are more callers.
>=20
> We should maybe add an ASSERT to p2m_flush_nestedp2m to make sure it's
> not called with defer_nested_flush being set then, or else it's
> possible for new callers of p2m_flush_nestedp2m to forget checking
> defer_nested_flush.

I'm afraid we can't do that, or at least not this easily: The flag
assumes the p2m lock to be held when it gets set. Hence callers not
holding the lock (hvm_set_efer(), nvmx_handle_invept()) may trigger
such an assert just because another CPU set the flag.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Oct 19 13:17:41 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Oct 2021 13:17:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.213217.371375 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcozm-0007W8-Ag; Tue, 19 Oct 2021 13:17:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 213217.371375; Tue, 19 Oct 2021 13:17:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcozm-0007W1-7M; Tue, 19 Oct 2021 13:17:34 +0000
Received: by outflank-mailman (input) for mailman id 213217;
 Tue, 19 Oct 2021 13:17:33 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=eXNP=PH=citrix.com=roger.pau@srs-us1.protection.inumbo.net>)
 id 1mcozl-0007Vv-KE
 for xen-devel@lists.xenproject.org; Tue, 19 Oct 2021 13:17:33 +0000
Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id ea67decc-30de-11ec-8312-12813bfff9fa;
 Tue, 19 Oct 2021 13:17:32 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ea67decc-30de-11ec-8312-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1634649452;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=4iTaz/xo+NFNzJtIKYClCdTC0sCjbo8XTUzYjtsNYEE=;
  b=RJnqZvTYhaHeYthmg+yrZ2u5cTmBbEieiqjG5+/sVhsOqBOiXVV1iQtS
   bi8LJZptQsX7mrmSEaHlRlJwvZgR6/0n7VS99ZsKwXcSxyCLRmc4Iaw4L
   +Cjx+feGJrGMTOiyogKZouM3kmpBocy3O7LxHu+8ag4wH3u/Od4A89W6Q
   Y=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: aal6IIQK3Zr7GkymtztptSSGR83gaQCkHPWdLDVLQimWbYwadwc9s5GeRZARD49NQrApJUQvo+
 GH9UiaxfzuKEdKpMNEvya+DampG5PY8wkV1uAv0/2Qc1KBmncQ0h1xktJ3IafTm35zaUtHjNVX
 9Uy+a/86g4vVCEOgI8EjZPMY5mRSUCJzu8LLr1GB8zBJa35MT5Z9IKQImMsm23kfSaJC4ErJDk
 9VZbB8E9s13q5k2tnxJYCWIDaXuwMbK+KigPJl/wzKQFSMfzxDbL7qAzec7g3+3g/n2PUf5M5m
 N9+Y9ypSQuRZxwE4Rl500Kip
X-SBRS: 5.1
X-MesageID: 55564694
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:z2JaQaP/nCz+AvzvrR0ZkMFynXyQoLVcMsEvi/4bfWQNrUohhjdUz
 WdLCmvUb/vfYGKgct8gb4Wx9E4DscfQz95rTAto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdpJYz/uUGuCJQUNUjMlkfZKhTr6bUsxNbVU8En540Usyw7VRbrNA2rBVPSvc4
 bsenOWHULOV82Yc3rU8sv/rRLtH5ZweiRtA1rAMTakjUGz2zhH5OKk3N6CpR0YUd6EPdgKMq
 0Qv+5nilo/R109F5tpICd8XeGVSKlLZFVDmZna7x8FOK/WNz8A/+v9TCRYSVatYo261mst22
 f9rjJq9cgEQM62UorUfehYNRkmSPYUekFPGCX22sMjVxEzaaXr8hf5pCSnaP6VBpLwxWzsXs
 6VFdnZdNXhvhMrvqF6/YvNrick5atHiIasUu216zCGfBvEjKXzGa/iXuIEEgmZs7ixINbHme
 ZUXVyVfVU2eaDlGZRA0MIIaguj90xETdBUH8QnI9MLb+VP71xdt2bLgNN7UfN2iRshPmEuc4
 GXc8AzRJRUXN8eWzzafxVuqivXShiPwWI8UF7qQ++ZjhRuYwWl7IA0bUx63rOe0jma6WslDM
 AoE9yw2t68w+Ue3CN7nUHWQonSJoxodUNp4CPAh5UeGza+8ywyUHHQeRzhNLtkvrtYrRCcC3
 0WM2djuAFRHsaKXYWKQ8K+OqjG/MjRTKnUNDRLoViNcvYOl+ttqyEuSEJAzS8ZZk+EZBxmr/
 zWRqzkUoYwVgPUN7qi7pWqWgRuj882hohEO2i3bWWes7wVcbYGjZpC15VWz0cusPLp1XXHa4
 yBaw5n2APQmSMjXznTUEbpl8KSBvq7daFXhbUhT847NHthH00WoepxM+3lALUNtP9dsldTBM
 RKL5105CHO+OhKXgU5Lj2CZV5tCIUvIT42NuhXogjxmOMgZmOivp3kGWKJo9zqx+HXAaIlmU
 XthTe6iDGwBFYNsxyesSuEW3NcDn35lmT6DH86jlUr+gdJygUJ5r59fYDNiichitMu5TPj9q
 Y4DZ6NmNT0OOAEBXsUn2dFKdg1bRZTKLZv3t9ZWZoa+zvlOQwkc5wvq6ep5IeRNxv0N/s+Rp
 y3VchIImTLX2CycQS3XOy8LVV8adcsmxZ7NFXd3ZgjANrlKSdvH0ZrzgLNnJOh5pbw9l6Aco
 jtsU5zoP8mjgw/volw1RZL8sJZjZFKsgwePNDCiez8xY9hrQAmhxzMuVleHGPAmAnXluM0gj
 aen0w+HE5MPSx47VJTdae61zkP3tn8YwbogU0zNK9hVWUPt7Ik1dHCh0q5pe5kBeUfZ2z+X9
 weKGhNE9+PDlJA4rYvSjqeeoob3T+YnRhhGH3PW5KqdPDXB+jbx2pdJVeuFJGiPVG799Ki4S
 /9SyvXwbK8OkFpQ6tIuGLd316MuodDoouYCnAhjGXzKaXWtC69hfSbajZUe6PUVy+YA6wWsW
 0+J9t1LApmzOZvoQAwLOQ4oTuWfzvVIyDPc2us4fRfh7yht8bvZDUgLZ0uQiDZQJadeOZ8+x
 btzo9Yf7gGyh0Z4MtuCiSwIpW2AImZZDvciv5AeRoTqlhAq2hdJZpmFUn3655SGatNtNEg2I
 2DL2Pqe1uoEnkeSIWAuEXXt3PZGgcVcsR9H+1YOOlCVl4eXnfQwxhBQrWw6Qwk9Is+rCA6v1
 ryH73FIGJg=
IronPort-HdrOrdr: A9a23:/DRkBqvKkZoO2SxEvKXGOlya7skCkoMji2hC6mlwRA09TyXGra
 +TdaUguSMc1gx9ZJhBo7G90KnpewK6yXdQ2/hqAV7CZnichILMFu9fBOTZsl/d8kHFh4tgPO
 JbAtVD4b7LfCZHZKTBkXCF+r8bqbHtmsDY5pau854ud3ATV0gJ1XYHNu/xKDwReOApP+tcKH
 LKjfA32wZINE5nJfiTNz0gZazuttfLnJXpbVovAAMm0hCHiXeN5KThGxaV8x8CW3cXqI1SvF
 Ttokjc3OGOovu7whjT2yv66IlXosLozp9mCNaXgsYYBz3wgkKDZZhnWZeFoDcpydvfomoCoZ
 3pmVMNLs5z43TeciWcpgbs4RDp1HIU53rr2Taj8A3eiP28YAh/J9tKhIpffBecwVEnpstA3K
 VC2H/cn4ZLDDvb9R6NqeTgZlVPrA6ZsHAimekcgzh0So0FcoJcqoQZ4Qd8DIoAJiTn84oqed
 MeQ/003MwmMW9yUkqp/VWGmLeXLzYO91a9MwQ/U/WuonlrdCsT9Tpc+CQd9k1wg67VBaM0o9
 gsCZ4Y542mePVmGZ6VNN1xMfdfNVa9My4kEFjiaGgPR5t3c04klfbMkcAIDaeRCds18Kc=
X-IronPort-AV: E=Sophos;i="5.87,163,1631592000"; 
   d="scan'208";a="55564694"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=CWUbwaFBO4izLyTY3mhiXqUMLNaX6ffNA7kOl2EpYja3ZmDxKfoduvG4czXXkJqSGRRJourSUfyCBMPhuHBccWE9MRM7ccPiTpVwcV0hEcgfvMnOyZVX89yO8D7ctj/6C1wZV2Jo7m2I6/eI017MCVkd7XxS0gGb5K8rHgcy4C3V3UINiiUOuUn+I+elxlu/u0iQfYUrOqM/emNhzypTVV6xQXADPvlmI6OMHzE7sfU/jRhFSd7KBo5MPznBc4zE3fYsnqaff8KzPhd2AcyTMSsG5DgZZsobuyGbGvdnc4HE1UCOU1vRctWI0ydfhUfSqLCqhg3jbdApF+TwjHK3sA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=LqMeKL7+IsnhaXtLhgzJzblM3JZ3BaIXMuZ2591rQdo=;
 b=oTxknLlVcxNFqoCAeuX2phzDXVUFdMphqX0NKaOe2x8AUPjLyo6GZgoNdKM9+2EfxYM3L2I3CznMTObrp0it4nKJZdaeNJHKsqRAjHjn8z0RAP63E9zpNEw/aAuSs9AtfWTMJ9DcvHoKmGLygtgucT+cEVwV8ZamJkBcQAzWUDXpJZPkphW2qFczKY3b6jKIMSenZcdf0luDR6vzXdL2MhZF3AKFUdFEaA8HaEvQi9FUXigrVM7gXeo3ge2/u4t4tyZ0bD3EEKOfERlcMQWrKJTPvaVKsJ3v6QvTFU16km9LGXgz/+sC3oyVDvQdgaZQ1uRv3ywjA9g7EoqTINDaeg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=LqMeKL7+IsnhaXtLhgzJzblM3JZ3BaIXMuZ2591rQdo=;
 b=CCYpRji2dCNemAnN0V2ZIto6UDrFdD9gueKzOERE7Su86/cMQpBLsOK8UAAcrvs/wDvHfousdtjlhhPBCfieSljqfSMaRh7ULTVPxCLY2qT8g7ERxx0wfK2S5/RnjTRyxF1JGYX0AyN5VQo5Yb9/rPDYHsxzlj3s75FpigF8e88=
Date: Tue, 19 Oct 2021 15:17:18 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Bertrand Marquis <bertrand.marquis@arm.com>, <iwj@xenproject.org>,
	<sstabellini@kernel.org>, <Oleksandr_Andrushchenko@epam.com>,
	<xen-devel@lists.xenproject.org>
Subject: Re: [PATCH 2/3] xen/vpci: Remove __hwdom_init for vpci_add_handlers
Message-ID: <YW7FXibf4DRS2TPa@MacBook-Air-de-Roger.local>
References: <cover.1634639117.git.bertrand.marquis@arm.com>
 <33b03be7eeea521953790542eb31d5a1386d2b81.1634639117.git.bertrand.marquis@arm.com>
 <116f5313-f2a3-376b-a0a3-af0d14d82125@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <116f5313-f2a3-376b-a0a3-af0d14d82125@suse.com>
X-ClientProxiedBy: LO2P123CA0079.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:138::12) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 9a64a685-948e-41b1-6b73-08d99302c9c1
X-MS-TrafficTypeDiagnostic: DM5PR03MB3371:
X-Microsoft-Antispam-PRVS: <DM5PR03MB3371DD27D8151E75CC0BF4288FBD9@DM5PR03MB3371.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: Dd0hYnkt9KBVsc09GIfWxrdt47iJ/5tQfzIIWpmrI7Di9181tUP6X4M3oMfNkSQMD23b0uGRnlP+xEXI4Dg3BLy7bGjQ4HLfcrE9dDWJqzmciZTY3EzdcBUXOtEl4sktnNsoZ165XfTXbpPPdXDMXJlrIqC7hXOFHcFcxgocKahckPeSSMGH3rS2Jd6RBg8tXBJ2qqGSen76aqFQX1LrwFROhDe6/EYW6MLsoFA+HEFK/DPdo/5F+I1r8/qRD1mXDZRZFq1kb201iLSoyHSf/BiTFUqcjPLPKHxRZrBjQnSHHMvXOAqpIcmfDIPNrv9p8DhKsLqKCLg77eAtjho/tCOqFJR7dVfhEBAAamusPhNLZz0kCdHZDgikgakQQSxhCaTUDfIIiIRV0zc1fD4bJuYTJSSD0gnHCV/MOZHt/leeNhBxIp1WOsMGXWTDJQxFOhgMNzlCRWkx/yAgKBYhiBilHPOwegmzeBkmcwRYXKKnKJUFkwRSA3wOVNBy3Tk4pglAQqIydEwQgf5LaPo4NY1K18SSbRPVW02Tgz/2cTR7q/nJnOonAhRKkQ5Y9M6OOM3meP502XWqolcMyKO32GrUmHIRGU1PEosQK9NN68ZnSzvXE5ifDipsZpBIWyjP8Wtsqt7XeLMbhtoSqJDcBQ==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(186003)(508600001)(9686003)(85182001)(53546011)(6496006)(8936002)(26005)(38100700002)(316002)(956004)(86362001)(5660300002)(2906002)(6916009)(6666004)(82960400001)(66556008)(66946007)(8676002)(6486002)(66476007)(4326008);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aXBrazc2d1hrdFhqaWRvME54NktwQkRzRXpMN21DUjdnZHIybXdFb1NVWFZ4?=
 =?utf-8?B?VE1NcWVxdGZOZzF4MUVJK000azZVUEwrOFZ6bDBJVTJjci92Y3RxMmJTVEVR?=
 =?utf-8?B?UDRIWVNDV0Vsb3NkRGhsejlCZVF4eWorTzlzQWN2T2NZSjhGWGtSR1NiQjk2?=
 =?utf-8?B?cFE2WmxHeVpBWDJyTm54UEF6MFdPS2tzTnZFNndHUDNSRzMwQ29Eb3NuYzkw?=
 =?utf-8?B?cjlrNUgxZDRHNXNIRGRhR1BrKzR6aCtTU1F3WENubEhSaEErR2FRRHJrS1B2?=
 =?utf-8?B?bUFtY0lTM255eFRJYXN1Vlo4K1pYVUxxa2gvNDZEQjdMcmRzeGhtMHFtZU9B?=
 =?utf-8?B?OHRmLy9lQmZvNTBDSHZNREo0WGFlMzNLQll1Y2dmRzNNR3VFWm9URGtYclJX?=
 =?utf-8?B?ZVdDQmRuRUFtYWdmSEFEVmQzd2ZlekFHbkdUVnFSVTE3a2xJN3d5Uzk5WWVp?=
 =?utf-8?B?RVlhUE9SUC9HYUdncW9jeVVkeDl3bkRBRTRIbk1CNWFhU0R6dmtpcUhFTTJX?=
 =?utf-8?B?bWcrMHZlM3NETWNUaU5Md3ovb3pRZHJTRHBEOHlnUU1MVU9VUzg5c1JDZFdZ?=
 =?utf-8?B?dFlxTEVRNll0S3ozMTdjUDIyUEdGMEFwVWVWcU5HdHBKczJ2UXc5NnBWK3dt?=
 =?utf-8?B?Z1Nkd0RIcXpuUmU1bWlISk1JOU5QNUdvUGZKcENodnVCd2FSV0NSNm9DKzFj?=
 =?utf-8?B?VlNEUzBoWUVRTjBaZTZsWWc4V05KRTlkVE1xWHY1QnVLejF4WWUzczExekJi?=
 =?utf-8?B?cGVtdlE4UVdJcUFUM2R3SW96NG5IK0k3M1ZUQjgrUHB2K1hVV0dhVjlxaFYz?=
 =?utf-8?B?elJhVUtmdS80a1kvdFlVODNjWGhDUEV1S3VldHlQOGFleWlXRS80S2FjOTNN?=
 =?utf-8?B?eVBBd280V0g5SEUxSGpGZENTZ3J1azZOSHJ3amtsZWhJbmdPRDI4RXZJMzB3?=
 =?utf-8?B?VHdsTTh0UWhSblZkYnM0QmF4aFdJdW5UemswL0g1dTBNdHAzOTBXR0p0U3By?=
 =?utf-8?B?Rk9ZTFVzZW4zd2RYZWFjOFoveE1naUVNOU5VTTY3UjgwYW84K3gxb04rT1ha?=
 =?utf-8?B?QkVMZVhONHc3RTc0eTNPWk9SclpNb3Zkd2N4ckVNMkRRRG11Q0N4aHhjU090?=
 =?utf-8?B?eUkzblNGWDNiOWk0S1Z3UjFNNGx4b1JOdFFsamt1ZTc4aFcvWDd2TklFMllQ?=
 =?utf-8?B?Yzh0ZzcwLzdjRVliZE4vaCtaSmdwWitLcDVPRWtIblJYaFEyVDlzbW83aFdT?=
 =?utf-8?B?MTlHRDM3dDZRcjVJWEJCelRYbytHN2tucDk2czNsc3o2K25LaElxNWRJNytt?=
 =?utf-8?B?Y2ZBeGVOSGVCNlVwWnhOVGg4eld5eHJ5dVh6ZTh1VWFGTlNhQVUrNWdud1Fo?=
 =?utf-8?B?bEd1a0d1QTE2dWhCYzh0dXM2ZDQ0ekdxZ3paSlFSWjUrQ0d4Q1d2WEVCNUZ4?=
 =?utf-8?B?Q1RLbFhxUERDanRJdlJRYm83bEZuNkdTbUp2KzFVN1NWR29NbGJZamRURUpK?=
 =?utf-8?B?MmJXTnBEQjlzRVBMS1FkTGNBc09NUXZRSUxhZmNMVlhLbEtYYXJ2b1lEdVE3?=
 =?utf-8?B?MmFwNzUzcGhnMTRna09HdFhhcGdpZjFjN1NCK2FEbXhaWllUWjV0SE9vYTJK?=
 =?utf-8?B?L0VDY1A3ZVIwSHRlTDNVZTdOYVcwUEJTQkVMMUtReWE3MGtrSlFMWlBTTHNU?=
 =?utf-8?B?bFg3WWJQQkhZbmNYNlkxVzkzRlc1c2g4NmlQQXNNN0I2RkhKWUlSUjNoUUh3?=
 =?utf-8?Q?nZLWC6FPsShsF3xjXDc5gJExayFUBsLfqZvdesJ?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 9a64a685-948e-41b1-6b73-08d99302c9c1
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2021 13:17:23.5751
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: UfqRYQYUhjh/Mb2UuMycHPeBtn0Mq+GCQvh9Bo6aL4Sk9wlDHmjbx1xIeXVvqgqsqgPZpBKqC7M04nK7y7/qWQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB3371
X-OriginatorOrg: citrix.com

On Tue, Oct 19, 2021 at 02:39:17PM +0200, Jan Beulich wrote:
> On 19.10.2021 12:40, Bertrand Marquis wrote:
> > --- a/xen/drivers/vpci/vpci.c
> > +++ b/xen/drivers/vpci/vpci.c
> > @@ -54,7 +54,7 @@ void vpci_remove_device(struct pci_dev *pdev)
> >      pdev->vpci = NULL;
> >  }
> >  
> > -int __hwdom_init vpci_add_handlers(struct pci_dev *pdev)
> > +int vpci_add_handlers(struct pci_dev *pdev)
> 
> A fundamental requirement when altering section attributes is to
> also check that all referenced entities are appropriately placed.
> Afaict this is not the case for __start_vpci_array[], and you'll
> need to also adjust linker scripts to deal with that.

Indeed, we need to just keep the CONFIG_LATE_HWDOM placement in
.rodata.

> Further
> you'd have to check that all functions referenced by that array
> aren't __hwdom_init. In taking an example (init_msi()) I'm
> actually surprised to find it's not marked __hwdom_init. So
> maybe all is fine as far as these are concerned.

My bad, I've forgot to mark the initializers used by
REGISTER_VPCI_INIT as __hwdom_init. I think there's no need for a
change there.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Tue Oct 19 13:20:29 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Oct 2021 13:20:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.213225.371386 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcp2a-0000aA-TP; Tue, 19 Oct 2021 13:20:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 213225.371386; Tue, 19 Oct 2021 13:20:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcp2a-0000a3-Q2; Tue, 19 Oct 2021 13:20:28 +0000
Received: by outflank-mailman (input) for mailman id 213225;
 Tue, 19 Oct 2021 13:20:27 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=gzZp=PH=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mcp2Z-0000Zx-Fi
 for xen-devel@lists.xenproject.org; Tue, 19 Oct 2021 13:20:27 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 525b3830-30df-11ec-8313-12813bfff9fa;
 Tue, 19 Oct 2021 13:20:26 +0000 (UTC)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2113.outbound.protection.outlook.com [104.47.18.113])
 (Using TLS) by relay.mimecast.com with ESMTP id
 de-mta-9-IYXunq93N2etaY-fAUdzRw-2; Tue, 19 Oct 2021 15:20:24 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15; Tue, 19 Oct
 2021 13:20:23 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.018; Tue, 19 Oct 2021
 13:20:23 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS9PR06CA0091.eurprd06.prod.outlook.com (2603:10a6:20b:465::9) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.16 via Frontend Transport; Tue, 19 Oct 2021 13:20:22 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 525b3830-30df-11ec-8313-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634649625;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=1h4maGXK48vgXp4lYGtQey0mQW8k7m+IrOltVj37+W0=;
	b=a3zzZz1q+blw2NAC5SpbIqL2zfAU9vrDJOvrc6BmvcH/kcS4BrAVmp71jCmRizUh2RfOCA
	1MKaeZ+9tmwQOW12YgJsfC37MWjYEjumffLUwnx8bYf2MFzEZXPzCmm3YdcQgNz/SGFH13
	LORPEEw2/h8+Y0H00sI04vkFeccyBO4=
X-MC-Unique: IYXunq93N2etaY-fAUdzRw-2
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=AAQ/NOvJq1CkUjEogxgRGiqWoIkgJjzEMC1PpuURZ7PQ+qV5R/f4ujtgzSzk2Xjvu4uB4JutCvHTWaSSHQ4X4lFpokgusCe1Ugbha1ihAGnGDaT9YFUJ14gSZ/vZpCVBkj9zXsvMfNb4OBrH3rUg/InfZb7wH8QpFV0xtFqbJWD9317c7N9VP+MHlSPWUDU0TGLj+JgZLDoREjt6ld6c8nrqQYi/Tv/nfljXD4XavByBqq17tmIzIpu0h+aEezdE9YnCzu/leJ/3GpIAmbRygmwfQH+Cjc3aw1eeb7ns2OHy8VVbCfpPihjwY/wKD9oxkQ7JI6NWGWyeWJRSus/qgg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=DwTV0RjdCW/IzWacBhTscGwXs8PtG7Jla/xu8yPl6x4=;
 b=FrAVaVsQNMvqgdawFt1+IznEtzXvG/jhSymS7EU71kOGqwWJNWufMI/X7GfYhcriIuRkJ8CTRXEPDu3FQa4ODGeHxenDuQX7e0wGGekKXEyMktf4EZn2f5bgXtZ1F01U5h2mTkTsOodKRIs7NkpQFPcplSorIxGuuB8OQV4vf2fTDwbFTnyehQyNAyj5yQf4cRTl3uMr7UKaZf98dkxuwEtug31jcNg9oz9rdisfNuq33odysk1Fsn40NT5DZB7QhtglkLkvXphSnsCzNb6GkB7LphcywfBHXKDkGOA4wa9sg9kLch9KFS7NVemcbFt/F/hgn8lrU6MhpCBU62iw0w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [PATCH 2/3] xen/vpci: Remove __hwdom_init for vpci_add_handlers
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: Bertrand Marquis <bertrand.marquis@arm.com>, iwj@xenproject.org,
 sstabellini@kernel.org, Oleksandr_Andrushchenko@epam.com,
 xen-devel@lists.xenproject.org
References: <cover.1634639117.git.bertrand.marquis@arm.com>
 <33b03be7eeea521953790542eb31d5a1386d2b81.1634639117.git.bertrand.marquis@arm.com>
 <116f5313-f2a3-376b-a0a3-af0d14d82125@suse.com>
 <YW7FXibf4DRS2TPa@MacBook-Air-de-Roger.local>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <317a8a4b-379d-16f3-12e1-116a8a2448f5@suse.com>
Date: Tue, 19 Oct 2021 15:20:20 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <YW7FXibf4DRS2TPa@MacBook-Air-de-Roger.local>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS9PR06CA0091.eurprd06.prod.outlook.com
 (2603:10a6:20b:465::9) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: d594bceb-e939-4bc2-ac2e-08d9930334dd
X-MS-TrafficTypeDiagnostic: VI1PR04MB5600:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB56000A1664ECA54377342F25B3BD9@VI1PR04MB5600.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	7mZ50PwMv4KcuMWxcfL+HYWH4katfSHVL06VKjMlOt/08V18fQQYPemQg+sr+31vx2nrlFByKrngiXjOT5ktxny7p+iC1fNYsG2iOAhjnra/k8dLum/0NJTTtjHYlMl8CYY0iLcR2uJVwgVQdVa0XUxS/auv4Xyl9EsDnifa+D/LWP+Uw+0tUkRSIrZFE2zWLOpIvj7f6ZSVMFQuM/WjDp8BfhuPjsVYhQYwem4PEc+qlWHT9Ec1W+NZkdXy/CTH/L9cGVA7ulNO07aqj7eNUQHLokY7y4hGIv0CnHpY/qrc4Tp8qRYcAjqDR8ZCDA/LluuJnu3KrIybt58VUjl6SHxb6IGcQPgrB/z5qIO6XTsPehGUqZ1apefxy7u+lvAmBqJNkBMCUVQQQ8QLzb14Qs33mV4k+g7LvUtolId4uDSLH9hCAxflEF0JuskUVVUHKsTf8oVvQIP8M/+QwvfD/arwHFteNAnVDK9aDDCo257rD7x/AUQXqmWXSGmPuIc7jcljl2SuC5wV2EEEMOenk90/dN5B4JHUkz7xCBqimTIfyd7l8oiXKbJshCaJkrdlGG2muomUcK/OKvHZ3TfUs6jQtJqh3kLdMuxhfbsWRGAY6UTfSFEzNE0ATCtaBWvffMfqHyh4JGdLpnxxKLJABG/H2FlreSVo/6Of8Pw0UexBXo2Q/3lUoUcWt5rmwdBKE5HRA4BmH4ZrJSYc3WdmgdiS52/il1r+oOksmwGavbXXGnXDlUfbe+zkA3YBetsY
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(8936002)(508600001)(6486002)(53546011)(4326008)(38100700002)(36756003)(6916009)(31686004)(66556008)(66946007)(8676002)(5660300002)(26005)(316002)(2906002)(2616005)(66476007)(186003)(956004)(86362001)(31696002)(16576012)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?S0h21sR5kQpdmBQQ/cIsrnDBuNQAJS2AKBuWtovQ451Yjl/JC8NlOmRtbB/f?=
 =?us-ascii?Q?eWj+KsRjHUKCDxoWrk1v9xLzY1iCOveMO8Z3qHAy+OvDOIvUW8cGjgRQlA6Y?=
 =?us-ascii?Q?7m0q3YvoPXd/cgsbs34HHWQmduNqYdThr7IXuLfEEowuKUM1hI2l91RDy87H?=
 =?us-ascii?Q?7pUGoPsXgxIb5SRa79I3mOPfSodlVG6wG+V8YZFQZActubEdq8/ae47gxjDQ?=
 =?us-ascii?Q?2SmsV8qtvuFSmBZUuAvvsIS4TLuw62U2IfTW8J9ads3YhrqGy62hsYq1jPGn?=
 =?us-ascii?Q?d4bjX0t8ghuXX6NeJKPwl6t4EUsSg9MwJeDWHGPLGO0bSyw/IILR6L+WG8SC?=
 =?us-ascii?Q?/NYXUA834/B5Kh8aHlh/XsJ6RRAMxySEq+ZKXZUaRXtaIGsACDWZOw7lHhjO?=
 =?us-ascii?Q?q+cBP9ev5X1SdAEvzF8/t/NmIu3xF74wrxOeEOxJ7Qf0AfiC+u81BESWbl0S?=
 =?us-ascii?Q?+RSQ8BkL6ogLnEIkdtGVLpUJsCi6EanD98WgzlEV/IBIaQxO3qLOKxoQ7hrh?=
 =?us-ascii?Q?6nJ9c1buiKcR5bZnVamEmL5ZBfwMFNuXsoFT3N681AWkXoNDybqLOBLMEPJb?=
 =?us-ascii?Q?sWUfChUa0wG6Vf6G7cUCLOVHJJgV3/CLTxpXgkZH3EOk+xo6MSVeCuEefoly?=
 =?us-ascii?Q?nI5yMUr2kmUOa8YUmye0/T92LwB6cnH/U2r8EWQFYcci9Om6nXA9hF4uwX0d?=
 =?us-ascii?Q?cpGsMFUXRwfeenzb+3zq792cXSHMOYwjsINPQq/+MGTMLD53QNGAU4j4W7T1?=
 =?us-ascii?Q?an6cT9EYQLou5gHEpluz3m/gameJfjlANTd0gps5zF+F/UTe58MtWn6bPwof?=
 =?us-ascii?Q?GmOa7QAHOgit7U5XIUxk13Hy2QxYMnxb506SJlJXmhxXhSzS3e+y6xi2LLOq?=
 =?us-ascii?Q?1o6kHxtlDV5YdsOFIusc6wVNR45dJGNwmcJuHKz18vybezoHeGU3XruwSmMH?=
 =?us-ascii?Q?X2vccii2Sg77q4zXVE5hIiioR3tHQgZf3F1s79A6PHi0pQIjCsOABSIC6Xmk?=
 =?us-ascii?Q?nxbdU8XuwMW6Ti2ULCRbotyw/mTaDUy6QAPSZmndfqQUSeonFzevLkLy2Ecx?=
 =?us-ascii?Q?7VxXlZQaciHj+md6xQCH2fWg41bMHbE57LJFxz0YpFbw9Ys6hkrrsKtuYoG6?=
 =?us-ascii?Q?vdi/SwHq5o2PwdFtGMZ3wBIG57wm5pm2ZuwvUKvI5xvnYaa0kjL6JykU/MNT?=
 =?us-ascii?Q?GNETqjm2KGhev53i6XXtBMlDH9ePgLkBiqio/M07VZsR9HxbyR+gTqE50Tjr?=
 =?us-ascii?Q?ch0bg7OIVXxpHok3Yq6l6JnYQadYjKZjknDDfA7sn+B1gr3wibaHD52cH+vy?=
 =?us-ascii?Q?fgUbxwhS6hzvIEFS1GcUYs0N?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d594bceb-e939-4bc2-ac2e-08d9930334dd
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2021 13:20:23.1842
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: X6+rn6mP/APttmrJGCs2cYbwzqDKkfYyC+PtuhotFLcifFKDdxGIko8BrLNQf5fHXKqf+UbfBNG9pabEQ0NO1w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5600

On 19.10.2021 15:17, Roger Pau Monn=C3=A9 wrote:
> On Tue, Oct 19, 2021 at 02:39:17PM +0200, Jan Beulich wrote:
>> On 19.10.2021 12:40, Bertrand Marquis wrote:
>>> --- a/xen/drivers/vpci/vpci.c
>>> +++ b/xen/drivers/vpci/vpci.c
>>> @@ -54,7 +54,7 @@ void vpci_remove_device(struct pci_dev *pdev)
>>>      pdev->vpci =3D NULL;
>>>  }
>>> =20
>>> -int __hwdom_init vpci_add_handlers(struct pci_dev *pdev)
>>> +int vpci_add_handlers(struct pci_dev *pdev)
>>
>> A fundamental requirement when altering section attributes is to
>> also check that all referenced entities are appropriately placed.
>> Afaict this is not the case for __start_vpci_array[], and you'll
>> need to also adjust linker scripts to deal with that.
>=20
> Indeed, we need to just keep the CONFIG_LATE_HWDOM placement in
> .rodata.
>=20
>> Further
>> you'd have to check that all functions referenced by that array
>> aren't __hwdom_init. In taking an example (init_msi()) I'm
>> actually surprised to find it's not marked __hwdom_init. So
>> maybe all is fine as far as these are concerned.
>=20
> My bad, I've forgot to mark the initializers used by
> REGISTER_VPCI_INIT as __hwdom_init. I think there's no need for a
> change there.

Not anymore, indeed. And less code churn now as a result.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Oct 19 13:37:11 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Oct 2021 13:37:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.213233.371397 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcpIa-00029l-C6; Tue, 19 Oct 2021 13:37:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 213233.371397; Tue, 19 Oct 2021 13:37:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcpIa-00029e-99; Tue, 19 Oct 2021 13:37:00 +0000
Received: by outflank-mailman (input) for mailman id 213233;
 Tue, 19 Oct 2021 13:36:59 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=eXNP=PH=citrix.com=roger.pau@srs-us1.protection.inumbo.net>)
 id 1mcpIZ-00029Y-LK
 for xen-devel@lists.xenproject.org; Tue, 19 Oct 2021 13:36:59 +0000
Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id a0eb0245-30e1-11ec-8313-12813bfff9fa;
 Tue, 19 Oct 2021 13:36:58 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a0eb0245-30e1-11ec-8313-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1634650618;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=cmK0qXktDwMwa0W/FD8snUNWKc1YfTymtFI8VqusDSQ=;
  b=IOaVjbUfXY0kP9D4TVHKP6V6JV1MWkLyy6i/QGnbsCSb0QzT8m8HIOfF
   S3B92qXfR46PG7EPf276JKUlJxRLh50o/xnHdjfS6kusGrjnbS0stnHLg
   irfBOWkncmSYOhERTTJhMx/v8+YUgq8CCw1p4ljiFBvp7l1VQ/FOKYiKN
   E=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: iubRhWCFGQinj0SChZ/HK6Dssrt5/Q4i5GUy9qaXjrX955Tg7Tobt+TFTTRzLw/MpT0QgdiYq2
 GQ2qTYrIWSN6/A24HUSnRyLsf6IxQGsYPlfXkp6aks0jJrJX35YIXpUwL3PP3Djy1CByXQ9tH8
 JA2s8fcqqNH8F25Q3jM4MGqKhNfTABowesNoLNZJjt2L6cR8UfWLh7tqgjdt7hPUx0CvYJQqAs
 HdHYK7sc6Q2Y/uwq5r+Dl9Ym1OLskn7iL8uKZNvRtSjJrzuvoCEOsgyUB0fUqT3Dv6Rdec6Ro2
 2rFqgtYmOdsZm0Te7RCwFlA9
X-SBRS: 5.1
X-MesageID: 55098273
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:1kWuCqjRN6zbSXlIy2r1jmlNX161tBcKZh0ujC45NGQN5FlHY01je
 htvUW+COPqMZmT8LY9ya97g8RsPu5HdxtRkSlRr/i5gEygb9cadCdqndUqhZCn6wu8v7a5EA
 2fyTvGacajYm1eF/k/F3oAMKRCQ7InQLlbGILes1htZGEk0F0/NtTo5w7Rg29Yx0IDia++wk
 YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq
 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx
 /1JsqK5GAULA5Tc29QQXT9VLWZ6LaFZreqvzXiX6aR/zmXDenrohf5vEFs3LcsT/eMf7WNmr
 KJCbmpXN1ba2rzwkOnTpupE36zPKOHxO4wSoDd4xCzxBvc6W5HTBa7N4Le02R9t25gfTayBP
 KL1bxJONhDcPB9NP25QDZ0MxOm5v0PAdgRh/Qf9Sa0fvDGIkV0ZPKLWGMrYfJmGSNtYmm6cp
 3na5CLpDxcCLtudxDGZtHW2iYfnnyn2RYYTH72Q7eNxjRuYwWl7NfENfQLl+7/j0Bf4Ao8Bb
 RxPksYzkUQs3EiscNCsXT+FmW7HjhMSfdduVOkq5B7Yn8I4/D2lLmQDSzdAbvkvu8k3WSEm2
 ze1oj/5OdB8mObKESzFp994uRv3YHJPdTZTOkfoWCNcu4G7yLzfmC4jWTqK/ESdtdbyBS3ri
 w6DqCwzlt3/ZuZaiv3lozgrb9+qz6UlrzLZBC2LAQpJDSsjPeZJgrBED3CBvZ6sy67CFjG8U
 IAswZT20Qz3JcjleNaxaOsMBqq1wP2OLSfRh1Vid7F4qW/xpi75I9gKvmguTKuMDiriUWW5C
 KM0kVgJjKK/wVPwNfMnC25PI5VCIVfc+STNCamPM4smjmlZfw6b5iB+DXN8LEi2+HXAZZoXY
 M/BGe71VC5yIf0+kFKeGrdMuZd2l3tW7T6CGvjGI+GPjOP2iIi9EuxebjNjr4kRscu5neki2
 4YGZpXbm0sFDoUToED/qOYuELzDFlBibbjeoM1LbO+TZA1gHWAqEfjKxr09PYdimsxoei3gr
 hlRg2dUlwjyg2PpMwKPZiwxYb/jR88n/3k6ITYtLRCj3H16OdSj66IWdp0We7g79bM8ka4oH
 qddI8jQUO5STjnn+igGacWvpoJVaxn21xmFODCoYWZjcsc4FRDJ4NLtYiDm6DIKUnisrcI7r
 rD5jlHbTJMPSh5MFsHTbP7znVq9sWJEwLB5XlfSI8kVc0LpqdA4Jyv0h/4xAscNNRScmWfKi
 1fIWU8V/LCfrZU0/d/FgbG/g72oS+YuTFBHG2T77KqtMXWI9GSU3oIdAv2DeirQVT2o9fz6N
 /lV1fz1LNYOgE1O79hnC79uwK8zu4nvqrtdwlg2FXnHdQ32WLZpI33A1shTrKxdgLRevFLuC
 E6I/9BbP5SPOd/kTwFNdFZ0MLzb2KFGgCTW4NQ0PF7+tX1+87ewWElPOwWB1X5GJ7xvPYJ5m
 eostab6MeBkZsbG5jpesh1pyg==
IronPort-HdrOrdr: A9a23:1iVk5apSNcsAjqDKjmDfeb4aV5u6L9V00zEX/kB9WHVpm5Oj+P
 xGzc526farslsssREb+OxpOMG7MBThHLpOkPMs1NCZLXTbUQqTXfpfBO7ZrQEIdBeOlNK1uZ
 0QFpSWTeeAcWSS7vyKkTVQcexQueVvmZrA7Yy1rwYPPHFXguNbnn9E426gYzNLrWJ9dPwE/f
 Snl656T23KQwVpUi33PAhJY8Hz4/nw0L72ax8PABAqrCGIkDOT8bb/VzyVxA0XXT9jyaortT
 GtqX232oyT99WAjjPM3W7a6Jpb3PPn19t4HcSJzuwYMC/lhAqEbJloH5eCoDc2iuey70tCqq
 iBnz4Qe+BIr1/BdGC8phXgnyHmzTYV8nfnjWSVhHPyyPaJDA4SOo5kv8Z0YxHZ400vsJVXy6
 RQxV+UsJJREFfpgDn9z8KgbWArqmOE5V4Z1cIDhX1WVoUTLJVLq5YEwU9TGJAcWArn9YEcFv
 V0Bs203ocWTbqjVQGagoBT+q3oYpxqdS32BnTq+/blnQS+pUoJjHfxn6ck7zA9HJFUcegM2w
 2LCNUvqFniJvVmGZ6VP91xM/dfPFa9Ny4kAFjiUmgPK5t3Tk4li6SHq4ndt9vaMqDh8vMJ6e
 P8uRVjxDcPR34=
X-IronPort-AV: E=Sophos;i="5.87,163,1631592000"; 
   d="scan'208";a="55098273"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=JdsSVBoS5wso/T9dNKVLyFbBynpbHwZPMF1VBtY8wP9g7jTHPBJNEwu4d3UNt8vV4Ru+NCxcdxynUkm5X8/uHsk//RUPu4Doh42Lhm/0ccP4sgk2pa8bcltmaIBsWfXt6klbTd1DOseEu151DPeLIkyb+JbR/ie/DbBoE2S0RVDljGL0f2oc7V+hIbFBEQ4JOupzQQ9ZK4a814y6YFrxtNSKQRXRwtEw3PTrLypJpJl++XhRnaQl/Bc4rVK/2Xe+LVLegv0lc1p+7zWs23SiL35AX5qflgaaijDDlk5u8UVJ4lhuapqahTsm3IS4NKT0OPAUKsqMgYD4VfFsVzGfyw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=shBDUF1Q0fRE3w3kAyOSmzIwuNo/dbJ/o4qvHIkdAdM=;
 b=YYjA/gykpjRdE7CVshHWJ0BW/NBTjIxJMcAfYSy+pxuTqIw/fD+CgW52vbw9/7sdyYSWfANL3RH8/+DwGUFzbAQ+ywMEVJ3jY2Kyo2TZMXkl00ayUvAqimMxVNngHYfvXbKATIlchtjaRoYII16MA9XZwZGH5CIEpHzgx8UDbfJxbnPtwU1cgAT6A4LIoAHMtUFOeaA9xuC06NFRWYfC90uxUau67+6fTpqNUl60DvdF+NsM9l3q0zqOBMRb7JQz5esWE2rvz05aciEIxoOoZw0qdFTJyWOWjdIQn8w638T+EkY/GKEsIabnKad7jGdn7QZNNgoFvLgcrPG7K9sd7g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=shBDUF1Q0fRE3w3kAyOSmzIwuNo/dbJ/o4qvHIkdAdM=;
 b=ltpVPc5+/lBlU3GPB8IuSZC97cSTBCGBA27Vqglg1qy7AJusam1gYoiHDx+3P7oMssWQ4iBzIjKBW7k+2df3ttCFnQbPc2HJm7y7mmDWhjsT/Nql9omQLDUgVfjk32ULNLje2UdIqIMqRHg6/hOAp4JWK2YJPGjXzsii1/6SCXA=
Date: Tue, 19 Oct 2021 15:36:40 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Andrew
 Cooper <andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>
Subject: Re: [PATCH] x86/PoD: defer nested P2M flushes
Message-ID: <YW7J6L4sAeFl74Az@MacBook-Air-de-Roger.local>
References: <e47d51c6-1b4b-2f72-6e12-070df66c30e2@suse.com>
 <YW6g9w9XeWKsxYMV@MacBook-Air-de-Roger.local>
 <9e444a8b-58e9-ea37-0e22-474e430be5e5@suse.com>
 <YW7BSjF3DD0jl74r@MacBook-Air-de-Roger.local>
 <787987c6-2fc1-1bae-f9f9-f1c806de1044@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <787987c6-2fc1-1bae-f9f9-f1c806de1044@suse.com>
X-ClientProxiedBy: LO4P123CA0424.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:18b::15) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 9cadb10c-bb85-4f39-5e4c-08d993057e7f
X-MS-TrafficTypeDiagnostic: DM6PR03MB5321:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <DM6PR03MB532128EAABC6B9DA9615D9178FBD9@DM6PR03MB5321.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6430;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: Cl1gQU+Gsulkfm4AfCBWWFNvg0LeqNBdL7/HX2wyYMkQTdB+LTU/MS03/VmAKBJ+kkolM3sOFVAkQV6AzJqdcydXblkDYflczZK5Tv7jbuZUYb5TINFeVahsSHoTma/BmbIr/KulYWO2wMp8ZrdZa5kceDCuxuJFXvABpAvW78fPhPZtvXq8rB9ayRtVA9V/jT6cSZ/x6mTb56oGXTMjnfeLgVKVrw8p/BTGcGiMPM352WXU7JtqJXoCSLo39ugleWujuA6T5gtXlVwyxg8oefsKxMvtdsHxwTUrWbsnNHPHeIoNXuIFEknjCl7+6cOe835vMw42+Plk6p61CoadljWwKOdsQ28zafgKzUsODXTNp+Yux6m8Ociz6GtL2Nad4nm+wVaYRduKyNq64n58/3iWV1Co+A8FPHzja/lXCrlAGN/Lm5uqevQsnIfv8PwLvojOB8xLJL6b5uLcdT6HVrFp9TDV7KdvrVRR5WiUNedkxm0EoRUu+JWiZ0ger1M1YoUaGfXx3ajjbvhJ1uMhH+efg6RhGtQkJQFe1ERGH6+wSJnQaPJQi7vbF7maDR4T7yey0+HmHn7nqGT1BILUPSAqR7yR7IIxYBP6RBL5xtsrGMbL0BZi96W6NWC0Kossx/CckDC58EQUFEWkLe/dPw==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(26005)(8936002)(6496006)(85182001)(6486002)(8676002)(86362001)(186003)(53546011)(83380400001)(6916009)(316002)(5660300002)(4326008)(508600001)(956004)(2906002)(38100700002)(54906003)(107886003)(6666004)(66946007)(66476007)(82960400001)(66556008)(9686003);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TEhRNDQyVCtQSkpaditkUmdsYk9CMmRDeVRlZVAza0lHQ3lSa2tnaDE2SHFD?=
 =?utf-8?B?V0NSTks1ckpjRU51MUZhUHcvR1ppODVFNWVYTXUzS1BYa3BmeHprdkJqbGhD?=
 =?utf-8?B?YkUramMvcHFnMklOZ3prT2pvVGxQcVRyVXkxTVBpTSthTFEvQU55ZFFLY1Js?=
 =?utf-8?B?ZnlVKzNFSE90Qm5ENGxyNnREUU5Sd3krSmJMNW9mbVR0d09FQjNuT0xmY2g1?=
 =?utf-8?B?aS9zWm1Wc1BjN2RzeUVLVm42WmxoM0V6TWkzdFgyNURqbmhreWtPOWpSOGpn?=
 =?utf-8?B?aTgzS3hBaitQdlNqWE5tNkFiaFZTYXRQSERwY0xmL3NxSXVDeDkvdGd5V0s4?=
 =?utf-8?B?WWtPNG82TGc4blpnRkhneFJ1Sm1qRHYwMCtvRi9QdWZSeXFOaWdKOGc5V2tT?=
 =?utf-8?B?bWtVUTNVTWNxV2tQK2xGZmo2UlAvVDlNRlJ1UlB5UVpVejYza1NjdDhjVEEv?=
 =?utf-8?B?K0tHU0VBWUZEbTZvbDVvZlZEOEdwSWUzYTdieHZtZm1WZ3RQamRUejB1L3pk?=
 =?utf-8?B?ZytWQzZuV0R0MnA5YWs2a1dvNURObzJ1RURvbElwUlB5TC9zTU1KVGIwWnJI?=
 =?utf-8?B?dDZKVit0N1hVY3Q5WUN4bUV2UW8zeGRGYUFabmhSbnhneHFYeTUvbEZMcUY1?=
 =?utf-8?B?dlJvYnFnQmN0b3IzWjlWVVBUYTRjeTh4N0dYK1lnZ20zUWVGajZJek1ianlL?=
 =?utf-8?B?TU1KcDhkWHZ0QU4wSm9NMm96d1BBcURKTy85R0xpTDZjam5MT2FtQ2R2Q0lR?=
 =?utf-8?B?QmhXVDdYTitkYjBFZE1qb2ljZU8wdFcvNFlhTDVuZzBNcnN2WGowOERSc2JV?=
 =?utf-8?B?S08yMm1DZjdZNFVzdEVGQWQwOFFndkM5NlplK25XOHBGcWhqOVBVOEVhQjkr?=
 =?utf-8?B?aGkyOWMwT2RORmN3RFhWOGdaV1IrazBEZWlIU2R2NWtmbUZLV0ViTnVzeGhN?=
 =?utf-8?B?Z094aG1nSGZENjFDTFNodEowOTFMNG5vWEhCaGNGbHdVeXcwbVlOL2ovMGN1?=
 =?utf-8?B?MnZZbVU4ZExINmR3WVBkRVdrd2ZPdjRkd2VyVDl6eURCRTAvekNPOTJralhZ?=
 =?utf-8?B?K1dQWmFWblNxZUxQb3BKTW9ndXRseW83dzE3cFczKzFSRVlGa3YybW84RElt?=
 =?utf-8?B?cXNEYzl6Tm1NYTVZQVVxQmRyZFFlWVNaWkpuVEprUXBSejdWcm9rV1RUYjY4?=
 =?utf-8?B?b1lBRjMyVStuaWNnVVN1LzJoWFhQdXphaE5OeG1ZOGxNV0pIMWdmQ01laEd0?=
 =?utf-8?B?UzNveFVWd2NEZGkrZldPRlVQd3ZuMWtOTjBUYk5wR1A1bEdYdmsrM2t0VDln?=
 =?utf-8?B?cUdVQXJ0RUFyUXM1bVdlWW9JVG5rbWt5a09QMFhrRFB4QkxoeUcyUHhldTdx?=
 =?utf-8?B?N003ZmVNekE2VmhLQm9zUi9XcE9RU05lOEkxYWtNM2JJWHAwMjByaVoyZ1o5?=
 =?utf-8?B?c2tJZVFnSzFCZkx2WjVvcFdLaGNFYkdsM3JMQnA5S1VUbUw0MmtMaTgxbkdW?=
 =?utf-8?B?NVB4dUh1TGhIdzVKdVBOYXkzUlRreXEvMnFXT0F6NXQyNmREeUNsNHZkUGVu?=
 =?utf-8?B?bU1mT3MwNDVUb3JoTGdVL01MVDZqbWl0UG8yUWFCall3dXlGa0FubHZmWjhE?=
 =?utf-8?B?KzNIamEzalhLSVlYTmRLQzdld1A4UDI2SU9UaTFnaHMvSUZ0dlp2b2ZEOUVa?=
 =?utf-8?B?cythTmpKdDhlZ0lMRWowc2JxQUNFdTYvaGRBRldJREJ2dEx2VnVZNG45VEFn?=
 =?utf-8?Q?1g1UjMU2DgGZAk8BSVHEI6uvraLMK0+nNmn4oye?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 9cadb10c-bb85-4f39-5e4c-08d993057e7f
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2021 13:36:45.8162
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: eo7wgEA7dh1gJyjCp8FURl0fZjkkwq40p3aVz/j9pIgk60dAFI/5JhcUKzzqAXX4wNHEwd/vcbc9D1KndgvKxw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB5321
X-OriginatorOrg: citrix.com

On Tue, Oct 19, 2021 at 03:14:25PM +0200, Jan Beulich wrote:
> On 19.10.2021 14:59, Roger Pau Monné wrote:
> > On Tue, Oct 19, 2021 at 01:58:38PM +0200, Jan Beulich wrote:
> >> On 19.10.2021 12:41, Roger Pau Monné wrote:
> >>> On Mon, Oct 11, 2021 at 10:17:08AM +0200, Jan Beulich wrote:
> >>>> With NPT or shadow in use, the p2m_set_entry() -> p2m_pt_set_entry() ->
> >>>> write_p2m_entry() -> p2m_flush_nestedp2m() call sequence triggers a lock
> >>>> order violation when the PoD lock is held around it. Hence such flushing
> >>>> needs to be deferred. Steal the approach from p2m_change_type_range().
> >>>>
> >>>> Similarly for EPT I think ept_set_entry() -> ept_sync_domain() ->
> >>>> ept_sync_domain_prepare() -> p2m_flush_nestedp2m() is affected.
> >>>
> >>> I'm slightly worried by this path because it doesn't seem to
> >>> acknowledge defer_nested_flush.
> >>
> >> Oh, yes. Iirc I did look at that logic, write down the remark, and
> >> then forgot to add the conditional to ept_sync_domain_prepare().
> >> The interactions with the real (host) flush are kind of ugly there,
> >> though - we then further depend on the ->defer_flush / ->need_flush
> >> logic, which is EPT-only. But I think I've convinced myself that
> >> this ought to work out.
> >>
> >>> Maybe the flag should be checked by
> >>> p2m_flush_nestedp2m instead of leaving it to the callers?
> >>
> >> I'm not sure this would be a good idea, as there are more callers.
> > 
> > We should maybe add an ASSERT to p2m_flush_nestedp2m to make sure it's
> > not called with defer_nested_flush being set then, or else it's
> > possible for new callers of p2m_flush_nestedp2m to forget checking
> > defer_nested_flush.
> 
> I'm afraid we can't do that, or at least not this easily: The flag
> assumes the p2m lock to be held when it gets set. Hence callers not
> holding the lock (hvm_set_efer(), nvmx_handle_invept()) may trigger
> such an assert just because another CPU set the flag.

Hm, indeed. Forcing those to take the p2m lock might be too much
overhead for the sake of correctness.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Tue Oct 19 13:42:54 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Oct 2021 13:42:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.213251.371429 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcpOH-0004Iu-FF; Tue, 19 Oct 2021 13:42:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 213251.371429; Tue, 19 Oct 2021 13:42:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcpOH-0004In-Bv; Tue, 19 Oct 2021 13:42:53 +0000
Received: by outflank-mailman (input) for mailman id 213251;
 Tue, 19 Oct 2021 13:42:51 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mcpOF-0004IV-IQ; Tue, 19 Oct 2021 13:42:51 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mcpOF-0002US-Cx; Tue, 19 Oct 2021 13:42:51 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mcpOF-0007HC-4Y; Tue, 19 Oct 2021 13:42:51 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mcpOF-0007uC-42; Tue, 19 Oct 2021 13:42:51 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=+kxlXnsunxtZ9Rj7TETCO0ElB37z2uj1ovA+l+U/3qY=; b=UrglKglpsci2QS4eCtfzThK9rh
	8GFHPlRbF7zT0CDHJRKTtcCUqHaLE9poPY7PPlkrmLlAht8R2m4Fa8fKWzQ1nSpp65g1Z2XVlDhSL
	Bu7JM5nOwGSEFOH56d27yOyjrrUo+n4FuRhPen9D8IsWrTiBvakKJi9g9nVW7UxNc/Fk=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165668-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 165668: regressions - FAIL
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-xl-qemuu-debianhvm-amd64:leak-check/basis(11):fail:regression
    xen-unstable-smoke:test-amd64-amd64-libvirt:leak-check/basis(11):fail:regression
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:leak-check/basis(11):fail:regression
    xen-unstable-smoke:test-armhf-armhf-xl:leak-check/basis(11):fail:regression
X-Osstest-Versions-This:
    xen=b7635526acffbe4ad8ad16fd92812c57742e54c2
X-Osstest-Versions-That:
    xen=c11b8d25fbe9c0155e91409594ea6701008409ed
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 19 Oct 2021 13:42:51 +0000

flight 165668 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165668/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-amd64-amd64-xl-qemuu-debianhvm-amd64 11 leak-check/basis(11) fail REGR. vs. 165635
 test-amd64-amd64-libvirt     11 leak-check/basis(11)     fail REGR. vs. 165635
 test-arm64-arm64-xl-xsm      11 leak-check/basis(11)     fail REGR. vs. 165635
 test-armhf-armhf-xl          11 leak-check/basis(11)     fail REGR. vs. 165635

version targeted for testing:
 xen                  b7635526acffbe4ad8ad16fd92812c57742e54c2
baseline version:
 xen                  c11b8d25fbe9c0155e91409594ea6701008409ed

Last test of basis   165635  2021-10-18 13:00:26 Z    1 days
Failing since        165638  2021-10-18 16:01:36 Z    0 days    5 attempts
Testing same since   165668  2021-10-19 10:00:25 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Ian Jackson <iwj@xenproject.org>
  Jan Beulich <jbeulich@suse.com>
  Juergen Gross <jgross@suse.com>
  Roger Pau Monné <roger.pau@citrix.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          fail    
 test-arm64-arm64-xl-xsm                                      fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    fail    
 test-amd64-amd64-libvirt                                     fail    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

------------------------------------------------------------
commit b7635526acffbe4ad8ad16fd92812c57742e54c2
Author: Jan Beulich <jbeulich@suse.com>
Date:   Tue Oct 19 10:08:30 2021 +0200

    x86/paging: restrict physical address width reported to guests
    
    Modern hardware may report more than 48 bits of physical address width.
    For paging-external guests our P2M implementation does not cope with
    larger values. Telling the guest of more available bits means misleading
    it into perhaps trying to actually put some page there (like was e.g.
    intermediately done in OVMF for the shared info page).
    
    While there also convert the PV check to a paging-external one (which in
    our current code base are synonyms of one another anyway).
    
    Fixes: 5dbd60e16a1f ("x86/shadow: Correct guest behaviour when creating PTEs above maxphysaddr")
    Signed-off-by: Jan Beulich <jbeulich@suse.com>
    Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>

commit 525eac931794434593c39a1d1cd739ad8b326e27
Author: Jan Beulich <jbeulich@suse.com>
Date:   Tue Oct 19 10:07:42 2021 +0200

    x86/PV: replace assertions in '0' debug key stack dumping
    
    While it was me to add them, I'm afraid I don't see justification for
    the assertions: A vCPU may very well have got preempted while in user
    mode. Limit compat guest user mode stack dumps to the containing page
    (like is done when using do_page_walk()), and suppress user mode stack
    dumping altogether for 64-bit domains.
    
    Fixes: cc0de53a903c ("x86: improve output resulting from sending '0' over serial")
    Signed-off-by: Jan Beulich <jbeulich@suse.com>
    Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>

commit 4843546fef5e024d5754f722fd01a8dfb482ac7d
Author: Jan Beulich <jbeulich@suse.com>
Date:   Tue Oct 19 10:07:00 2021 +0200

    x86/PV: make '0' debug key dump Dom0's stacks again
    
    The conversion to __get_guest() failed to account for the fact that for
    remote vCPU-s dumping gets done through a pointer obtained from
    map_domain_page(): __get_guest() arranges for (apparent) accesses to
    hypervisor space to cause #GP(0).
    
    Fixes: 6a1d72d3739e ('x86: split __{get,put}_user() into "guest" and "unsafe" variants')
    Signed-off-by: Jan Beulich <jbeulich@suse.com>
    Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>

commit 5e97b97bc254b0ee23f701a4d5a317853136d288
Author: Jan Beulich <jbeulich@suse.com>
Date:   Tue Oct 19 10:05:10 2021 +0200

    x86/altp2m: don't consider "active" when enabling failed
    
    We should not rely on guests to not use altp2m after reporting failure
    of HVMOP_altp2m_set_domain_state to them. Set "active" back to false in
    this case.
    
    Signed-off-by: Jan Beulich <jbeulich@suse.com>
    Reviewed-by: Tamas K Lengyel <tamas@tklengyel.com>
    Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>

commit d6e38eea2d806c53d976603717aebf6e5de30a1e
Author: Jan Beulich <jbeulich@suse.com>
Date:   Tue Oct 19 10:04:13 2021 +0200

    x86/AMD: make HT range dynamic for Fam17 and up
    
    At the time of d838ac2539cf ("x86: don't allow Dom0 access to the HT
    address range") documentation correctly stated that the range was
    completely fixed. For Fam17 and newer, it lives at the top of physical
    address space, though.
    
    To correctly determine the top of physical address space, we need to
    account for their physical address reduction, hence the calculation of
    paddr_bits also gets adjusted.
    
    While for paddr_bits < 40 the HT range is completely hidden, there's no
    need to suppress the range insertion in that case: It'll just have no
    real meaning.
    
    Reported-by: Igor Druzhinin <igor.druzhinin@citrix.com>
    Signed-off-by: Jan Beulich <jbeulich@suse.com>
    Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>

commit a8cddbac5051020bb4a59a7f0ea27500c51063fb
Author: Jan Beulich <jbeulich@suse.com>
Date:   Tue Oct 19 10:02:39 2021 +0200

    x86emul: de-duplicate scatters to the same linear address
    
    The SDM specifically allows for earlier writes to fully overlapping
    ranges to be dropped. If a guest did so, hvmemul_phys_mmio_access()
    would crash it if varying data was written to the same address. Detect
    overlaps early, as doing so in hvmemul_{linear,phys}_mmio_access() would
    be quite a bit more difficult. To maintain proper faulting behavior,
    instead of dropping earlier write instances of fully overlapping slots
    altogether, write the data of the final of these slots multiple times.
    (We also can't pull ahead the [single] write of the data of the last of
    the slots, clearing all involved slots' op_mask bits together, as this
    would yield incorrect results if there were intervening partially
    overlapping ones.)
    
    Note that due to cache slot use being linear address based, there's no
    similar issue with multiple writes to the same physical address (mapped
    through different linear addresses).
    
    Signed-off-by: Jan Beulich <jbeulich@suse.com>
    Acked-by: Roger Pau Monné <roger.pau@citrix.com>

commit 3ae80dea4601764818d1e5b84bd1e4479c0d4790
Author: Juergen Gross <jgross@suse.com>
Date:   Fri Sep 10 07:55:17 2021 +0200

    stubdom: disable building pv-grub
    
    The stubdom based pv-grub is using a very outdated version of grub
    (0.97) and should not be used any longer. Mainline grub has support for
    PV guests for a long time now, so that should be used as a boot loader
    of a PV domain.
    
    So disable building pv-grub per default. In case someone really wants
    to continue using it he/she can still use a pv-grub binary from an older
    Xen version or manually enable building it via:
    
      configure --enable-pv-grub
    
    [ This was already disabled in osstest by 8dee6e333622
      "make-flight: Drop pvgrub (pvgrub1) tests" -iwj ]
    
    Signed-off-by: Juergen Gross <jgross@suse.com>
    Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
    Acked-by: Ian Jackson <iwj@xenproject.org>
    Release-Acked-by: Ian Jackson <iwj@xenproject.org>

commit 9cfeb83cbe23a873de512211d7ecd989348b9df0
Author: Juergen Gross <jgross@suse.com>
Date:   Tue Oct 12 15:41:48 2021 +0200

    tools/xenstore: set open file descriptor limit for xenstored
    
    Add a configuration item for the maximum number of open file
    descriptors xenstored should be allowed to have.
    
    The default should be "unlimited" in order not to restrict xenstored
    in the number of domains it can support, but unfortunately the kernel
    is normally limiting the maximum value via /proc/sys/fs/nr_open [1],
    [2]. So check that file to exist and if it does, limit the maximum
    value to the one specified by /proc/sys/fs/nr_open.
    
    As an aid for the admin configuring the value add a comment specifying
    the common needs of xenstored for the different domain types.
    
    [1]: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=60fd760fb9ff7034360bab7137c917c0330628c2
    [2]: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=0c2d64fb6cae9aae480f6a46cfe79f8d7d48b59f
    
    Signed-off-by: Juergen Gross <jgross@suse.com>
    Reviewed-by: Ian Jackson <iwj@xenproject.org>
    Release-Acked-by: Ian Jackson <iwj@xenproject.org>

commit f282182af32939107d47943aba242d3189ec6f90
Author: Juergen Gross <jgross@suse.com>
Date:   Tue Oct 12 15:41:47 2021 +0200

    tools/xenstore: set oom score for xenstore daemon on Linux
    
    Xenstored is absolutely mandatory for a Xen host and it can't be
    restarted, so being killed by OOM-killer in case of memory shortage is
    to be avoided.
    
    Set /proc/$pid/oom_score_adj (if available) per default to -500 (this
    translates to 50% of dom0 memory size) in order to allow xenstored to
    use large amounts of memory without being killed.
    
    The percentage of dom0 memory above which the oom killer is allowed to
    kill xenstored can be set via XENSTORED_OOM_MEM_THRESHOLD in
    xencommons.
    
    Make sure the pid file isn't a left-over from a previous run delete it
    before starting xenstored.
    
    Signed-off-by: Juergen Gross <jgross@suse.com>
    Reviewed-by: Ian Jackson <iwj@xenproject.org>
    Release-Acked-by: Ian Jackson <iwj@xenproject.org>
(qemu changes not included)


From xen-devel-bounces@lists.xenproject.org Tue Oct 19 13:43:53 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Oct 2021 13:43:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.213268.371443 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcpPF-00058E-1y; Tue, 19 Oct 2021 13:43:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 213268.371443; Tue, 19 Oct 2021 13:43:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcpPE-000587-TA; Tue, 19 Oct 2021 13:43:52 +0000
Received: by outflank-mailman (input) for mailman id 213268;
 Tue, 19 Oct 2021 13:43:51 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=XJzt=PH=arm.com=Bertrand.Marquis@srs-us1.protection.inumbo.net>)
 id 1mcpPD-00057f-Jh
 for xen-devel@lists.xenproject.org; Tue, 19 Oct 2021 13:43:51 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com (unknown
 [40.107.6.52]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 971d4afa-30e2-11ec-8313-12813bfff9fa;
 Tue, 19 Oct 2021 13:43:50 +0000 (UTC)
Received: from AM6P192CA0097.EURP192.PROD.OUTLOOK.COM (2603:10a6:209:8d::38)
 by VI1PR08MB3856.eurprd08.prod.outlook.com (2603:10a6:803:c4::10) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16; Tue, 19 Oct
 2021 13:43:48 +0000
Received: from VE1EUR03FT010.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:209:8d:cafe::33) by AM6P192CA0097.outlook.office365.com
 (2603:10a6:209:8d::38) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.18 via Frontend
 Transport; Tue, 19 Oct 2021 13:43:48 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT010.mail.protection.outlook.com (10.152.18.113) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.15 via Frontend Transport; Tue, 19 Oct 2021 13:43:47 +0000
Received: ("Tessian outbound f1898412aff1:v103");
 Tue, 19 Oct 2021 13:43:47 +0000
Received: from ddb141f13b82.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 89BC8929-12C1-4253-9195-E2095B08F15D.1; 
 Tue, 19 Oct 2021 13:43:40 +0000
Received: from EUR02-HE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id ddb141f13b82.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Tue, 19 Oct 2021 13:43:40 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com (2603:10a6:4:74::9)
 by DB7PR08MB3372.eurprd08.prod.outlook.com (2603:10a6:10:4f::14) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.18; Tue, 19 Oct
 2021 13:43:37 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955]) by DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955%4]) with mapi id 15.20.4608.018; Tue, 19 Oct 2021
 13:43:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 971d4afa-30e2-11ec-8313-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=OfF4aGzbao5s2QskKfQB8lsOjZ3y/bfjYyciZvbA2rY=;
 b=6oHmzTXSn20XIQ2o7FhSDtYbVrCI8v5n+Ij2F7Na9un+owkMhGb9gtectawICQFvFe5pSAWUUr95IYbaPpa7YLmAIm7rGF/Gn/u84CQfAizKSJ4fVFpzbmLAwGX6N/nmAGfCwfk9H/rYj1/lK/iE/SREHPeYb1WkSZzn2p8nQIg=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 708c69ec7b2c79e2
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=YfJNdKV7C7rdLFAXGssU+VezxhdFyqAr7Q2IGDwKeU21N9J0Pq13K75EvuT8i4dEQ/VmZ5vMRLLUDlib1vCrGaNulbOsM5Vq2hKL0i0AT8GKd1S2bvau1pypPjifgCsMuAp/OpDPxjKeLBYmBzcTtPPVJ5zbp6uIFpRv0/5sCAnhTReRYUXLs4Oy6iC4/kzipCanGiaXHicHIinjCXyG5lXWhCIVPBmDYXgUk5iH9APR+vTrT8lOhoqjUEP1Oji0W5/8MTnx1DEPbAbj1qqNAVJKVp+gPFW8ecnx/iEqN7PjWb11LNGbEA8WxJN7gaChkaySS/bxFtylbnE8MTwEbg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=OfF4aGzbao5s2QskKfQB8lsOjZ3y/bfjYyciZvbA2rY=;
 b=Nk3hAozjSJL0i3h8cXxMU8dmCVrcT9/B+KCn54PwLeW8PRmLdSicU75ZaqdOqxwBO7jURyNpSu68uhhS70oNPJ1CPZ1dHjhOzQZ6n7NkKCXaV4Lvf695uvdruDz20EZlU6lcwAIHgw33wf7uuVJiDc2LCkpWZ8+ozMmKk14je5VsZ2OcklRjq2wcsTvgLOc13aLUBBZDcEXlljF5MmWQ+xKiL4s5IuTnt5BWnHAFQ6mHCYQxwGXHFneL3O5S7N3RvyRcG/3SCzxvQ0zrUIXTcEA3Gv7ps2REnADE2ELJSr476T99Dhb0+lBef2Vf6lCNbugp2BmgkCMrSTePToR0OQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=OfF4aGzbao5s2QskKfQB8lsOjZ3y/bfjYyciZvbA2rY=;
 b=6oHmzTXSn20XIQ2o7FhSDtYbVrCI8v5n+Ij2F7Na9un+owkMhGb9gtectawICQFvFe5pSAWUUr95IYbaPpa7YLmAIm7rGF/Gn/u84CQfAizKSJ4fVFpzbmLAwGX6N/nmAGfCwfk9H/rYj1/lK/iE/SREHPeYb1WkSZzn2p8nQIg=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>
CC: Jan Beulich <jbeulich@suse.com>, "iwj@xenproject.org"
	<iwj@xenproject.org>, "sstabellini@kernel.org" <sstabellini@kernel.org>,
	"Oleksandr_Andrushchenko@epam.com" <Oleksandr_Andrushchenko@epam.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH 2/3] xen/vpci: Remove __hwdom_init for vpci_add_handlers
Thread-Topic: [PATCH 2/3] xen/vpci: Remove __hwdom_init for vpci_add_handlers
Thread-Index: AQHXxNXruySz06Rv/0aNVGzqN8rSbavaQv2AgAAKnwCAAAdagA==
Date: Tue, 19 Oct 2021 13:43:37 +0000
Message-ID: <84BB039D-6EAD-4B4E-A56F-5961D8F9EEDA@arm.com>
References: <cover.1634639117.git.bertrand.marquis@arm.com>
 <33b03be7eeea521953790542eb31d5a1386d2b81.1634639117.git.bertrand.marquis@arm.com>
 <116f5313-f2a3-376b-a0a3-af0d14d82125@suse.com>
 <YW7FXibf4DRS2TPa@MacBook-Air-de-Roger.local>
In-Reply-To: <YW7FXibf4DRS2TPa@MacBook-Air-de-Roger.local>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3654.120.0.1.13)
Authentication-Results-Original: citrix.com; dkim=none (message not signed)
 header.d=none;citrix.com; dmarc=none action=none header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: fa571c42-bea4-413d-1178-08d993067a35
x-ms-traffictypediagnostic: DB7PR08MB3372:|VI1PR08MB3856:
X-Microsoft-Antispam-PRVS:
	<VI1PR08MB38565AEF1F17E1B71A6CD7399DBD9@VI1PR08MB3856.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:10000;OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 gQQGhlQ9pcWPxjzAOoLwYQuegvpJFUqk4BE9PEvTgwe1KLox2bkYWNsySgaDfVbJ+1HLQzXm6Rjgn0KzRggNhdU0oiqJZSFJzcgb2H0vYntvBKei3DRyqlPVJnrlNNiJ36ZZvD6YAWLodxEhcsytFrZTwkE+Tj6snya37lauRJ3Ch2M7qu0GhIIyn2tTQ1nvL6O84ErIOvLavw1yMG4cc00NYIKEsDX1LaZrpFjRyU9HS4oCRsmiXE55krC68vP9aWEUP3JjfIlPozGz2mSYbRzfRUgrlxzan7AbSJgPgXa1TYS31mUYes1CVlDc3cB2txkFZxMU1LvMjCj7F1eYlTKq1qDNx9t0hUoaI0VH0Bb7Hd/hCJd9XWPuL8PSjVNGAnPoLcpu06Mf692jIEnj5sTAJL6A/8288kRr5VVL40TKDiHdOnwW7Kb5KKZMHaMeu/qjx/6tDX2yzGSWJFpwUynKCpytTeQn8G0Y0zfjCUS1DYNjr0c6kFkPJu8MwHWmBD7VPxcQIqlvApqEZfMrsMqtd6g0tyJcYuSXL0i24YvVvQtJKfPX10pNX/zjNSfT2pwcrJH5Arqrhy1M00QYvUkmH3/xXnpZnsGBUy9aq91tfGrfyzPTv/W2oqwxOItu28qUSZQ7F3UxtyeQBnlsNNvsowLCn00BM6yQW/Y/FpKPP98/ztKdE4oWUz2SNcRZcp1WJDBij6G3M+3sJJ0ntb3LLFX0psqyHPDURVIPxbyJxKvnY4B9RSLLrshO8rWV
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB6PR0801MB2024.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(186003)(26005)(86362001)(6506007)(53546011)(122000001)(38100700002)(83380400001)(2906002)(6486002)(36756003)(6916009)(38070700005)(6512007)(66446008)(66476007)(5660300002)(316002)(8676002)(8936002)(76116006)(66946007)(64756008)(508600001)(91956017)(4326008)(66556008)(54906003)(33656002)(71200400001)(2616005)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="utf-8"
Content-ID: <1004D46FFA6F2F4FB61E3BF2B058AB58@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3372
Original-Authentication-Results: citrix.com; dkim=none (message not signed)
 header.d=none;citrix.com; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT010.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	63ea2487-935d-4846-302f-08d9930673f5
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	LNgliARpXNOOTkPOLifMGa69X8o49Gwqvo65vRHwQKbDByqsRvv4znuAWgd4R7XXTKFW7upCOmvkssuQQ/qlQBeIuETJ+coQieT9u6N/c2ldHly3JS2CyyyFQGDf2GFSIDbYR3Gh4Iz6hSsTKb/Uk3NJXm3JySHmBqqQ0k8vIFyGzSomKQtKnTypc03PYH6jL2gWKsH6yRcagoqxsHERxZtZhoYGbwAnnQPDQq6ncZ9pVsF+2K3Hwvp7IRPEOqwyoCo6mdO+ogBtG75hokevLfV36u6t6cGBm0KZ22B2D0GdOX28A2u7LWGFkAmM5eyKcY2pWB2qyhEBnTVu34cGcOrOrtKmpgjhZmUEvhPd/0dJLmcK7T0swGuUdNmLlxON5DQWfYUkmyAaaxlMGszGW2RfT2+VlVfcgDvV0srqzN6rncdnj4czf+d7lpBRAj6z0jZwkBY3iDHdTbtjq3ZGkjdLWWD+WyB6hXUw/Oq5HfbJWVDKpDr8whdp5nsJ8H64gKN0vti4iWL1bT1DoS2zG1rZMLPQBf6W9vrikCi+hUO8LBu6MyTjLtE0puRwzk7jYO9XUQuCT2khmI6+TTB+aVPc7krOPod8LJJx1j2lnWXkw6GRtkk6hDnKZBIgBGZoA4vjuZHSc5wMCJJzCgWLtM/PUkZMyo9ZYnPFBQw97kbsQ1WmaYeaC1Swx6sRfpG6dF1CDT8Po5CSpi3Xga7mPA==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(336012)(36860700001)(47076005)(356005)(2906002)(82310400003)(36756003)(6862004)(316002)(53546011)(6506007)(8676002)(81166007)(2616005)(4326008)(6486002)(26005)(86362001)(508600001)(33656002)(186003)(70586007)(5660300002)(8936002)(54906003)(70206006)(6512007)(83380400001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2021 13:43:47.7931
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: fa571c42-bea4-413d-1178-08d993067a35
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT010.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3856

SGksDQoNCj4gT24gMTkgT2N0IDIwMjEsIGF0IDE0OjE3LCBSb2dlciBQYXUgTW9ubsOpIDxyb2dl
ci5wYXVAY2l0cml4LmNvbT4gd3JvdGU6DQo+IA0KPiBPbiBUdWUsIE9jdCAxOSwgMjAyMSBhdCAw
MjozOToxN1BNICswMjAwLCBKYW4gQmV1bGljaCB3cm90ZToNCj4+IE9uIDE5LjEwLjIwMjEgMTI6
NDAsIEJlcnRyYW5kIE1hcnF1aXMgd3JvdGU6DQo+Pj4gLS0tIGEveGVuL2RyaXZlcnMvdnBjaS92
cGNpLmMNCj4+PiArKysgYi94ZW4vZHJpdmVycy92cGNpL3ZwY2kuYw0KPj4+IEBAIC01NCw3ICs1
NCw3IEBAIHZvaWQgdnBjaV9yZW1vdmVfZGV2aWNlKHN0cnVjdCBwY2lfZGV2ICpwZGV2KQ0KPj4+
ICAgICBwZGV2LT52cGNpID0gTlVMTDsNCj4+PiB9DQo+Pj4gDQo+Pj4gLWludCBfX2h3ZG9tX2lu
aXQgdnBjaV9hZGRfaGFuZGxlcnMoc3RydWN0IHBjaV9kZXYgKnBkZXYpDQo+Pj4gK2ludCB2cGNp
X2FkZF9oYW5kbGVycyhzdHJ1Y3QgcGNpX2RldiAqcGRldikNCj4+IA0KPj4gQSBmdW5kYW1lbnRh
bCByZXF1aXJlbWVudCB3aGVuIGFsdGVyaW5nIHNlY3Rpb24gYXR0cmlidXRlcyBpcyB0bw0KPj4g
YWxzbyBjaGVjayB0aGF0IGFsbCByZWZlcmVuY2VkIGVudGl0aWVzIGFyZSBhcHByb3ByaWF0ZWx5
IHBsYWNlZC4NCj4+IEFmYWljdCB0aGlzIGlzIG5vdCB0aGUgY2FzZSBmb3IgX19zdGFydF92cGNp
X2FycmF5W10sIGFuZCB5b3UnbGwNCj4+IG5lZWQgdG8gYWxzbyBhZGp1c3QgbGlua2VyIHNjcmlw
dHMgdG8gZGVhbCB3aXRoIHRoYXQuDQo+IA0KPiBJbmRlZWQsIHdlIG5lZWQgdG8ganVzdCBrZWVw
IHRoZSBDT05GSUdfTEFURV9IV0RPTSBwbGFjZW1lbnQgaW4NCj4gLnJvZGF0YS4NCg0KSSB3aWxs
IGFsc28gbmVlZCB0byByZW1vdmUgdGhlIHRlc3QgZm9yIENPTkZJR19MQVRFX0hXRE9NIGluIHRo
ZXJlDQphbmQgb25seSB0ZXN0IGZvciBDT05GSUdfSEFTX1ZQQ0kuDQpUaGlzIHdpbGwgYmUgYXBw
bGllZCB0byBib3RoIGFybSBhbmQgeDg2IGxpbmtlciBzY3JpcHQuDQoNCj4gDQo+PiBGdXJ0aGVy
DQo+PiB5b3UnZCBoYXZlIHRvIGNoZWNrIHRoYXQgYWxsIGZ1bmN0aW9ucyByZWZlcmVuY2VkIGJ5
IHRoYXQgYXJyYXkNCj4+IGFyZW4ndCBfX2h3ZG9tX2luaXQuIEluIHRha2luZyBhbiBleGFtcGxl
IChpbml0X21zaSgpKSBJJ20NCj4+IGFjdHVhbGx5IHN1cnByaXNlZCB0byBmaW5kIGl0J3Mgbm90
IG1hcmtlZCBfX2h3ZG9tX2luaXQuIFNvDQo+PiBtYXliZSBhbGwgaXMgZmluZSBhcyBmYXIgYXMg
dGhlc2UgYXJlIGNvbmNlcm5lZC4NCj4gDQo+IE15IGJhZCwgSSd2ZSBmb3Jnb3QgdG8gbWFyayB0
aGUgaW5pdGlhbGl6ZXJzIHVzZWQgYnkNCj4gUkVHSVNURVJfVlBDSV9JTklUIGFzIF9faHdkb21f
aW5pdC4gSSB0aGluayB0aGVyZSdzIG5vIG5lZWQgZm9yIGENCj4gY2hhbmdlIHRoZXJlLg0KDQpU
aGFua3MgZm9yIHRoZSBjb25maXJtYXRpb24gaGVyZS4gSSBjaGVja2VkIGluIHRoZSBjb2RlIGFu
ZCBkaWQgbm90IGZpbmQNCmFueXRoaW5nIGFuZCB3YXMgbG9va2luZyBhZ2Fpbi4gQnV0IEkgZGVm
aW5pdGVseSBtaXNzZWQgdGhlIGxpbmtlciBzY3JpcHQuDQoNCkkgd2lsbCBzZW5kIGEgdjIgc3F1
YXNoaW5nIHRoZSAzIHBhdGNoZXMgdG9nZXRoZXIgYW5kIG1vZGlmeWluZyB0aGUgbGlua2VyDQpz
Y3JpcHRzLg0KDQpUaGFua3MNCkJlcnRyYW5kDQoNCj4gDQo+IFRoYW5rcywgUm9nZXIuDQoNCg==


From xen-devel-bounces@lists.xenproject.org Tue Oct 19 13:44:17 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Oct 2021 13:44:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.213274.371453 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcpPd-0005gG-9I; Tue, 19 Oct 2021 13:44:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 213274.371453; Tue, 19 Oct 2021 13:44:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcpPd-0005g9-64; Tue, 19 Oct 2021 13:44:17 +0000
Received: by outflank-mailman (input) for mailman id 213274;
 Tue, 19 Oct 2021 13:44:16 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mcpPc-0005fv-BN
 for xen-devel@lists.xenproject.org; Tue, 19 Oct 2021 13:44:16 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mcpPc-0002Vn-Ai
 for xen-devel@lists.xenproject.org; Tue, 19 Oct 2021 13:44:16 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mcpPc-0002Gr-9j
 for xen-devel@lists.xenproject.org; Tue, 19 Oct 2021 13:44:16 +0000
Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89)
 (envelope-from <iwj@xenproject.org>)
 id 1mcpPY-0000ds-PT; Tue, 19 Oct 2021 14:44:12 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date
	:Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From;
	bh=juEucK277y+n5jFHf/HjYsH0xXpZ3XNiquL2QDnLIZE=; b=As0cRL4McjVu7xo5bQBvkE8pEY
	gdITOnXeqsCxmUI8AUB9n42cl2VHF6M3zWb5OKY+sJYBQ6HabNvKRStN6iCAOQa/azaaRb6/0APp3
	NIIEX6lTyzvnxRg3CmMLSh+7ViD6jvocXsInu3FgG1qz9r6IhqbHLBZ6F4SaYoZ6/gvM=;
From: Ian Jackson <iwj@xenproject.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <24942.52140.280917.934226@mariner.uk.xensource.com>
Date: Tue, 19 Oct 2021 14:44:12 +0100
To: Juergen Gross <jgross@suse.com>
Cc: xen-devel@lists.xenproject.org
Subject: Re: [PATCH] OSStest: explicitly enable building qemu-traditional
In-Reply-To: <152bf281-6921-42bd-a87a-054056a385ff@suse.com>
References: <20211019130211.32233-1-jgross@suse.com>
	<24942.49760.686147.851391@mariner.uk.xensource.com>
	<152bf281-6921-42bd-a87a-054056a385ff@suse.com>
X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu)

Juergen Gross writes ("Re: [PATCH] OSStest: explicitly enable building qemu-traditional"):
> On 19.10.21 15:04, Ian Jackson wrote:
> > OOI, have you done any kind of test on this ?
> 
> No, this was a pure "lets do things in a similar way as the other
> options" approach.

Right.

> > I'm kind of inclined to just push it and let osstest's pre-production
> > self-test test it.
> 
> You are in a far better position than me to decide this. :-)

I decided to run a test first :-).

I think you and I should get an email about adhoc flight 165635 when
it's complete.  I think the build log ought to show it passing the new
argument.

Thanks,
Ian.


From xen-devel-bounces@lists.xenproject.org Tue Oct 19 13:54:03 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Oct 2021 13:54:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.213290.371468 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcpYy-0007Qv-8v; Tue, 19 Oct 2021 13:53:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 213290.371468; Tue, 19 Oct 2021 13:53:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcpYy-0007Qo-47; Tue, 19 Oct 2021 13:53:56 +0000
Received: by outflank-mailman (input) for mailman id 213290;
 Tue, 19 Oct 2021 13:53:54 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=eXNP=PH=citrix.com=roger.pau@srs-us1.protection.inumbo.net>)
 id 1mcpYw-0007QP-Mx
 for xen-devel@lists.xenproject.org; Tue, 19 Oct 2021 13:53:54 +0000
Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id c08b8240-3058-4a32-b9cc-412dc7e6e00f;
 Tue, 19 Oct 2021 13:53:53 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c08b8240-3058-4a32-b9cc-412dc7e6e00f
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1634651633;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=tFSmAqZ7txEzNR+0bjfziqd/IwIpKVFMRSA+CmCqak0=;
  b=TC6q6LUNHdPGSRfU8yBUBQZ75zERw3phm1jee7yilevCSURiKK+my13t
   HEiLXQEd+UuzV5ufDOP0nbFmjQ1vpZOYWb8uT5ObdhJ+9fkBRdDnYcCU7
   tSo7C0sCjuaxdmcQIlGo3B7u7Ujoljpt2vDkaQ76rU7gqCaLrrZsucawx
   Q=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: oLQ3OfsH3woR6xV/hjKVkg+e/ex1bS3CGb7DbBrYVp3Fav1SBSTEqNyEheuggghbPtTdRudjxR
 2lKLVaW/T5BNaWDBAHAtssqq8zP++wcEwI93cwY0BLTdM7bEu11Av5gwiuoQkwgkk9nfEAMZas
 nauVVcZ6hnyWMtHQ+SrLUAENjQwzi6MHDe6Fhc2ntErk3+zZjHQMVh7gR3WNLaQjHrRaSUTPrg
 sjYfzRIj5PS7L4ZLF4ekfd6ByR3/rZFuLcqWTPPpaVGNJSoFhikBypI6uAum+j0Dldqb1so4dV
 k3gW1UZdXI46ido3PZxsfzfY
X-SBRS: 5.1
X-MesageID: 55525773
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:lRcuj6suLWomR4fQ8eVqy2GILefnVLRZMUV32f8akzHdYApBsoF/q
 tZmKWnXP/bcZ2DyKdkiOY608k8EsZaDzt8xSAFtrS5jEnlB+JbJXdiXEBz9bniYRiHhoOOLz
 Cm8hv3odp1coqr0/0/1WlTZQP0VOZigHtIQMsadUsxKbVIiGHhJZS5LwbZj29cw2InhX2thh
 PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe
 gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ
 NplqLicZyotBYr1o6dNcBteESN6I5R+9+qSSZS/mZT7I0zudnLtx7NlDV0sPJ1e8eFyaY1M3
 aVGcnZXNEnF3r/ohuLgIgVvrp1LwM3DJoQQt2sm1TjEJf0nXYrCU+PB4towMDIY250TR6uBO
 JFxhTxHQBrbbCYfJFMtVakRjPb0i3XjWDRRkQfAzUYwyzeKl1EguFT3C/LWd8KLQ4NJn0+ej
 mPA42n9RBodMbS32TeDt36hmOLLtSf6Q54JUq218OZwh1+ezXBVDwcZPXO5q/Skjk+1W/pEN
 lcZvCEpqMAPGFeDF4enGUfi+Tjd40BaC4E4//AGBB+l1474zSudPU89dX0RS94gts0yWwUS2
 Qrc9z/2PgBHvLqQQHOb076bqzKuJCQYRVM/iT84oRgtuIa7/tli5v7bZpM6SvTt14yqcd3l6
 2nS9HBWulkFsSIcO0xXF3j8iDWwuoOBcAcx4gjGNo5OxlIkPND7D2BEBF6y0BqhEGp7ZgXe1
 JTns5LHhAzrMX1rvHbdKAnqNOrxj8tpyBWG3TZS82AJrlxBAUKLc4FK+y1ZL0x0KMsCcjKBS
 BaN4l8MtMUNZCH0NP8fj2eN5yICl/iI+TPNDai8UzazSsIpKF/vEN9GNCZ8IFwBYGBzyPpia
 P93gO6nDGoACLQP8dZFb7x17FPf/QhnnTm7bcmil3yPiOPCDFbIGeZtGAbfNYgRsfLbyDg5B
 v4CbqNmPT0EC7agCsQWmKZORW03wY8TVcmn9Z0HKLTdSuekcUl4Y8LsLXoaU9UNt4xel/vS/
 2H7XUldyVHlgmbAJxnMYXdmAI4Dl74gxZ7iFSBzb1uuxVY5ZoOjsPUWe5ctJOF1/+1/1/9kC
 fICfpzYUPhITz3G/RUbbIX889M+JEj621rWMnr3eiU7cr5hWxfNpo3ucDzw+XRcFSGwr8Y//
 eGtj1uJXZoZSg1+J8/Kc/bznUiptH0QlbsqDUvFK9VeYmv2941uJ3Cjh/M7OZhUex7C2iGbx
 0CdBhJB/bvBpIo88d/og6GYrtj2T7siTxQCR2SCtOS4LyjX+Gan0LRsaufQcGCPTn7w9YWje
 f5Rk6P2PsoYkQsYqIF7Cbtqk/4zvoO9u79Aww14N3zXdFD3WKh4K3yL0MQT5K1AwrhV5Vm/V
 k6Vo4QIPLyIPIXuEUILJRpjZeOGjKlGlj7X5PUzAUP7+C4oo+bXDRQMZ0GB2H5HMb94EII52
 uNw6scZ5ju2hgcuLtvb3Dtf8H6BLyBYXqgq3n3A7FQHVub/Jol+XKHh
IronPort-HdrOrdr: A9a23:cnqHzauQg9VpD5EHx/tB2KiY7skC/oMji2hC6mlwRA09TyXGra
 +TdaUguSMc1gx9ZJhBo7G90KnpewK6yXdQ2/hqAV7EZniahILIFvAY0WKG+VPd8kLFh4xgPM
 tbAs1D4ZjLfCRHZKXBkXiF+rQbsaC6GcmT7I+0pRcdLnAbV0gj1XYANu/yKDwJeOAsP+teKH
 Pz3Lsim9L2Ek5nEfhTS0N1E9Qq4Lbw5ebbSC9DIyRixBiFjDuu5rK/Ox+E3i0GWzcK5bs562
 DKnyHw+63m6piAu1Hh/l6Wy64TtMrqy9NFCsDJos8JKg/0ggLtQIh6QbWNsB08venqwlc3l9
 vnpQsmIq1ImjzsV1DwhSGo9xjr0T4o5XOn4ViEgUH7qci8fz4+A9opv/MTTjLpr24b+P1s2q
 NC2GyU87BNCwnboSj779/UEzl3i0uduxMZ4K0upk0adbFbRK5arIQZ8k8QOowHBjjG5IcuF/
 QrJN3A5cxRbUiRYxnizylSKeSXLzEO9yq9Mww/UpT/6UkQoJk59TpY+CUnpAZDyHpnIKM0od
 gtMcxT5flzp4EtHPtA7Epoe7rBNoX3e2O/DIulGyWvKEg2AQO/l3fJ2sRB2AiLQu1D8HJgou
 WNbLtn3VRCDX4GT/f+hKF2zg==
X-IronPort-AV: E=Sophos;i="5.87,164,1631592000"; 
   d="scan'208";a="55525773"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=fGMBgv3oBp/WEWRjupC6weubtCr7wpfPFLCGck1OZTn9GxzXc6GJMbEYLKa4glgVujDlEyIey2a4mjW8aPPP/tekshMQKwI5k9KjScwpcK5Xyrls8KitCPZbeEztwk8MtUbbv3g3PXdMp7EJHU3RzpwGeiEik5yEqUOh8ozPyUkpzY6xKEFUUIDlfjhFCPGi53ariCIWbN8GPCspdqTmNMmC8hnc675+uJ3wHLnlHAH3t9YhrROPogCkY6Aa0NyeEt6jBld/FVjdpaiK56n8/gN5I5sNAXKebepsJX5nOmj1rQX322FOT8N1pWkqySK+Q2groU6fiAEqx2vmXRHosw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=yFKrmk1ZxEyJHA+8j5lD6LJLD+20vaarteCLEUr83X4=;
 b=gfo4k9jYsg5SEZMiQPAptdir9lKrElXoulr5wSwvVuevC/jw0OWr5gPOCvo1UUkKmWr9d0b1UM6fLyoACKZpOSVDSQ6439+i10nwK8Ic3t3LCYMCy9lndFMLzWegxYoJH7yS5CXiRi0qdeCGpVTpmjkgo1IWSUrXxh1/ekueA8loRSicb7Ay1ZZEYW/yrJpZRRKcccGZ7bQjRHgBPs7PXOyWtukAlrHGSDzUNgKyFvaTshx2gbpT3n9DdvRTwqwM3RbxuYzPGHe3Ky5wMpbO/Ah27rjsYooDRD7ByQoh4hWCH2K08iCUpYmR6f0Fi9GoRIAEdVzmiSiBIpz4QnUfQg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=yFKrmk1ZxEyJHA+8j5lD6LJLD+20vaarteCLEUr83X4=;
 b=JnNs0E012ThvfifLAo5MmTNcxfjDmc3vsbOpGqEEIuM/kP+8wdU7jTtI3zEAIyONgv/ms2DQ0LkvQENu5z7+KRkMk7QtJT7phJ1Q5353UhTAMWfYVw1v3CohfVGAsSpH9c8KjPUOCKub36PHDv2ZQZcluVZdNO0RSMjXumGUvBA=
Date: Tue, 19 Oct 2021 15:53:27 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Andrew
 Cooper <andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>,
	Kevin Tian <kevin.tian@intel.com>
Subject: Re: [PATCH v2] x86/PoD: defer nested P2M flushes
Message-ID: <YW7N13JsVfwwcqAl@MacBook-Air-de-Roger.local>
References: <c6f2dcd7-81e6-3fb6-0e13-3ffb95e12bc1@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <c6f2dcd7-81e6-3fb6-0e13-3ffb95e12bc1@suse.com>
X-ClientProxiedBy: LO4P123CA0324.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:197::23) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: f6bcac40-ab4a-4d12-f938-08d99307d6a0
X-MS-TrafficTypeDiagnostic: DM5PR03MB2971:
X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <DM5PR03MB29717B16E0F27B103D5221F38FBD9@DM5PR03MB2971.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 7egTzac/4oLneUaJ31RibBFGfPhuSXoI8BS/r/UTq2BuAEL6gVFUr1YFBjDvwbyCY/v0iHHl+RPgBnlrAVSlZ29RmSuJ/spJsibjH7r22+TWqhhSJwwh5E0eLAPaVLuDmVJXDD/VQkrR7dvUIO93c0wBGpxf0CQZJmLRVo2PMYUZZB3aZ0Y+ESztOA1zEThiGq5rJ2PViqNYAxBkII/oSsmJGFGPO2n/D1OceQVjmb3/XIh7QPayzTG66sIf3ZO68eXB/StodqMfDjeC1XDGjPgj9IW2UqMU09YFYfaOb4IeuIjJ6bLc5WvBd03T6m+/nK4KEfr6b34U/bwJd4QgKaCVJY15ujzCxc+EsH0OnWzVrrBSZvTToaZY0gj1PTcj0I7l47HQR/t4SeMO0Hm+oVeflA+l+j/gLGlWLFW8mEWp53SA2OYksVGfP8bpMjbTT3Yi88dk7/ZhMrexKFDe4xrQyn8sOHD+hhHn1ORsOCXE0HZCMjSfA3QNCN/4R9EGatEjG81bIVceZmmgHbsLcYSCkTSqk9Xv2G1BqSpmafI/Vq8QRv4bZ1Tuj0y3xwy9ISTFyM+qJgymwfgQc4r9swawrciUQIo6zgVwxzd2DyY8B0Zy1wMrdpImBPGms2d2IoLElXxKQLLcOtgWHw/IEQ==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(38100700002)(66476007)(8676002)(85182001)(66556008)(86362001)(5660300002)(508600001)(316002)(2906002)(66946007)(8936002)(6496006)(4326008)(9686003)(6916009)(6486002)(26005)(82960400001)(54906003)(83380400001)(186003)(956004)(6666004);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T2hURFlUQmw0ZEJ2MmdnTGJhYzJZYnczMWlJM29kUWZOUy9JRitGa044aUNJ?=
 =?utf-8?B?T2xVSlpkZUMrUmZQR1Q0M0E4OEdjSDJyY0ZmY0dmVS83M0d6ZkpKK1Z5MjFw?=
 =?utf-8?B?N0xpdDFOOEExZ1BxaDM2TjBWemR1M21tbC9QVmVKOURNeHdQYjYweWdwSlZZ?=
 =?utf-8?B?ZERHM2FlMFBtWWpxRXF2L2sxb0doVlp5TlFDNDlmbDVjYjhZNlJRQzZ2UkhZ?=
 =?utf-8?B?YkRmTG9EM3pKZDlFK092c3ptcEsxclJCQ0VYVWJDa0oyUGZaNVI3LzVtOE8v?=
 =?utf-8?B?UWxQVXArZmFoVWJKZCttVWRKTTZ4WHRrL0U1N0tkUGg4dDdQbGdYYmtEdWdW?=
 =?utf-8?B?WkdGUGxUVHl2Qjk1STI0SnVFak1uaUcremVJcGFXRUx3UWFneGhOSVM0d0N5?=
 =?utf-8?B?d3NSKzNmaUJUd0w4RGdrS3Q4MW1MbzZGS0ZxTG40bjQ4b0xVY01sdlBiOFdT?=
 =?utf-8?B?THVSSkdzWVhxeU13RU5aQkE2b0NzWUVtT0RUbld2S0dkMHJIM1A5TlA4blJB?=
 =?utf-8?B?N2dhbjRHWDJ6VldKMGJldmN4cFZDb0s2Y2Vuam5wd1lzMHdFUkhQc1ZNbnBN?=
 =?utf-8?B?TnQ4MHo5VUpNN2pTTVVscW5NdjVpOUw0bFZUc091c1d3RTNLclZrbjdXK1RH?=
 =?utf-8?B?WW9hQjdVK3R5NFhPamx4OFZIaVZVNDd6Nkp5ZjExbnhXL3d4VktjYlIwQldS?=
 =?utf-8?B?ZzloWTFNZ1V5MVI1ZjczckxLbkFacHpqMERJenZwc3UyU3p6YnJFZVRPN3B0?=
 =?utf-8?B?UEM1TWE3ZG1qTUJrdVFjZ002QlBtTnRmUlZsK0I4eVpHUGQ2OUNuL09TV09E?=
 =?utf-8?B?NFk3YWdybll0UWdWM01jRVA3c21pY3F4NThhWmo4cjZDbXJMZ0VNTWFXcFJa?=
 =?utf-8?B?d2J5UTVnQ0M5OE8yRmpqWnMrMG8wRHBLV00zd2NEdW03QmdlMzdUZG45NDFK?=
 =?utf-8?B?NkRwQzExb00xSUlzNVZWR2tOQ2FLUDNkMm9uNEI0MXZTRjU3b1JCM1NKc2hF?=
 =?utf-8?B?Y2t1QkhRSXo5NzdQYjRmMk4xN0dYU3JNemxPRnB1Tk11UlJiaUNEZTcxYWFT?=
 =?utf-8?B?RWsxdzVlUFpPc0lzK0pWN1ZiUFNyRHJRcmlxQTJlNVJWTldKYzIybUtuSEEx?=
 =?utf-8?B?WFhpWUR2Y2tqSWViYUVqbGRNVUNMdHNFRzJDcHBEWU03d2dKSjJkU2VpLzBX?=
 =?utf-8?B?OWJKRG04TEdiWE5lSDdOYjE3OFNZb1l5VmZwRWF2eXk2Sk80SHc1cWhBeWJU?=
 =?utf-8?B?QkNlVEJnWGo2ZnFueElwUjBSdDlOeU5tMVlLcWtJcnpZZjhYUWR5MFlRQVZH?=
 =?utf-8?B?ZWJtYW10eVNOYWtoSTZuVU9HWitXcnU1akNUeG5Sc3E2ZTM3MWVVMzB4cGQ2?=
 =?utf-8?B?NWJiRi8veG9ETzVYaDRmV2FBaFBCR2lncFhWYklXOTZJNjBlanNUSmJES0hh?=
 =?utf-8?B?eHpyRllPR0hHQlo3aDVvTWxqWTVqc3NiZ3hrR2gydnROcXdBbTl4SzFJTWZV?=
 =?utf-8?B?c2Z0UktCSkZxRVVrTlZOUVNLT3QvVVhraDV2RTJPZjduNGwzdTVzTTIrVkZl?=
 =?utf-8?B?TEd3em12NEVzSjRlZS9ZUHdFYmF5UmM4UHRtU253NEdyckxYNHpQK3dML1hx?=
 =?utf-8?B?T0t1Sk5LVDJxVFlFbGJIMHdSRFVrcXJRNEhMc1JIdE84YzZ4UmkyMDZ2U0Vv?=
 =?utf-8?B?MXpNUWpyTFo3RGFRcE1zd1p2UE50SVBQaW9nVkVHSnltM25tN3FVRkNvS3lh?=
 =?utf-8?Q?L1JD3OlSXCljtBW279eI0RsOj5E6IKJFT8+ldeh?=
X-MS-Exchange-CrossTenant-Network-Message-Id: f6bcac40-ab4a-4d12-f938-08d99307d6a0
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2021 13:53:32.6415
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: FEgXHRVU0fatwEPNTWxYXyoBPJsoRkeiGXjyVQM3xZLJ5kfzxcLq0q6PgdvtSJgyHPp+sk1ffk7FAAQ49YWzMw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB2971
X-OriginatorOrg: citrix.com

On Tue, Oct 19, 2021 at 02:52:27PM +0200, Jan Beulich wrote:
> With NPT or shadow in use, the p2m_set_entry() -> p2m_pt_set_entry() ->
> write_p2m_entry() -> p2m_flush_nestedp2m() call sequence triggers a lock
> order violation when the PoD lock is held around it. Hence such flushing
> needs to be deferred. Steal the approach from p2m_change_type_range().
> (Note that strictly speaking the change at the out_of_memory label is
> not needed, as the domain gets crashed there anyway. The change is being
> made nevertheless to avoid setting up a trap from someone meaning to
> deal with that case better than by domain_crash().)
> 
> Similarly for EPT I think ept_set_entry() -> ept_sync_domain() ->
> ept_sync_domain_prepare() -> p2m_flush_nestedp2m() is affected. Make its
> p2m_flush_nestedp2m() invocation conditional. Note that this then also
> alters behavior of p2m_change_type_range() on EPT, deferring the nested
> flushes there as well. I think this should have been that way from the
> introduction of the flag.
> 
> Reported-by: Elliott Mitchell <ehem+xen@m5p.com>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Acked-by: Roger Pau Monné <roger.pau@citrix.com>

> ---
> v2: Also adjust ept_sync_domain_prepare(). Also convert the flush at the
>     out_of_memory label. Extend description to cover these.
> 
> --- a/xen/arch/x86/mm/p2m-ept.c
> +++ b/xen/arch/x86/mm/p2m-ept.c
> @@ -1253,7 +1253,7 @@ static void ept_sync_domain_prepare(stru
>      {
>          if ( p2m_is_nestedp2m(p2m) )
>              ept = &p2m_get_hostp2m(d)->ept;
> -        else
> +        else if ( !p2m->defer_nested_flush )
>              p2m_flush_nestedp2m(d);

I find this model slightly concerning, as we don't actually notify the
caller that a nested flush as been deferred, so we must make sure that
whoever sets defer_nested_flush also performs a flush unconditionally
when clearing the flag.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Tue Oct 19 13:55:05 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Oct 2021 13:55:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.213297.371478 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcpa5-00084O-Kl; Tue, 19 Oct 2021 13:55:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 213297.371478; Tue, 19 Oct 2021 13:55:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcpa5-00084H-HV; Tue, 19 Oct 2021 13:55:05 +0000
Received: by outflank-mailman (input) for mailman id 213297;
 Tue, 19 Oct 2021 13:55:04 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=M2za=PH=suse.cz=dsterba@srs-us1.protection.inumbo.net>)
 id 1mcpa4-000845-55
 for xen-devel@lists.xenproject.org; Tue, 19 Oct 2021 13:55:04 +0000
Received: from smtp-out1.suse.de (unknown [195.135.220.28])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id c673987d-c9d3-42b1-8278-8f1831973172;
 Tue, 19 Oct 2021 13:55:03 +0000 (UTC)
Received: from relay2.suse.de (relay2.suse.de [149.44.160.134])
 by smtp-out1.suse.de (Postfix) with ESMTP id A63E321A99;
 Tue, 19 Oct 2021 13:55:02 +0000 (UTC)
Received: from ds.suse.cz (ds.suse.cz [10.100.12.205])
 by relay2.suse.de (Postfix) with ESMTP id 0D869A3B85;
 Tue, 19 Oct 2021 13:55:02 +0000 (UTC)
Received: by ds.suse.cz (Postfix, from userid 10065)
 id 8F6DBDA7A3; Tue, 19 Oct 2021 15:54:34 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c673987d-c9d3-42b1-8278-8f1831973172
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa;
	t=1634651702;
	h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to:
	 cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=lCAmwd04vR+8ISMPrZZs/6BPlrRsuF68LDbyHwEPntQ=;
	b=tLZsnCbfP/PE33Cg8Lb4wiLOBxR8QveId9HdyLQwr2cih36yShITfbjTETbGmX7qoPSLnV
	KpgAA8+dbLeP0XdSU+qtQz6RQ6J5EBZxRaplNcIZug7sxD7fof1K7Oihxwjp0TkV6E8qRu
	UqkFmpgJ7dUVgd+qqNHE1kGVvaHvryE=
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz;
	s=susede2_ed25519; t=1634651702;
	h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to:
	 cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=lCAmwd04vR+8ISMPrZZs/6BPlrRsuF68LDbyHwEPntQ=;
	b=eVe2N40rhMpqpW06F4v/0V4nL0bZy0/F/3sDzYIThe2zCSwt2+BtKDOwwYusSYK+iBuJ9x
	/SDiTxQlN3QaJABg==
Date: Tue, 19 Oct 2021 15:54:34 +0200
From: David Sterba <dsterba@suse.cz>
To: Christoph Hellwig <hch@lst.de>
Cc: Jens Axboe <axboe@kernel.dk>,
	Roger Pau =?iso-8859-1?Q?Monn=E9?= <roger.pau@citrix.com>,
	Josef Bacik <josef@toxicpanda.com>, David Sterba <dsterba@suse.com>,
	OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>,
	Konstantin Komarov <almaz.alexandrovich@paragon-software.com>,
	linux-block@vger.kernel.org, xen-devel@lists.xenproject.org,
	linux-btrfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	ntfs3@lists.linux.dev
Subject: Re: [PATCH 4/7] btrfs: use sync_blockdev
Message-ID: <20211019135434.GS30611@twin.jikos.cz>
Reply-To: dsterba@suse.cz
Mail-Followup-To: dsterba@suse.cz, Christoph Hellwig <hch@lst.de>,
	Jens Axboe <axboe@kernel.dk>,
	Roger Pau =?iso-8859-1?Q?Monn=E9?= <roger.pau@citrix.com>,
	Josef Bacik <josef@toxicpanda.com>, David Sterba <dsterba@suse.com>,
	OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>,
	Konstantin Komarov <almaz.alexandrovich@paragon-software.com>,
	linux-block@vger.kernel.org, xen-devel@lists.xenproject.org,
	linux-btrfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	ntfs3@lists.linux.dev
References: <20211019062530.2174626-1-hch@lst.de>
 <20211019062530.2174626-5-hch@lst.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211019062530.2174626-5-hch@lst.de>
User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12)

On Tue, Oct 19, 2021 at 08:25:27AM +0200, Christoph Hellwig wrote:
> Use sync_blockdev instead of opencoding it.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Acked-by: David Sterba <dsterba@suse.com>


From xen-devel-bounces@lists.xenproject.org Tue Oct 19 14:15:34 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Oct 2021 14:15:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.213313.371490 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcpto-0002FX-9K; Tue, 19 Oct 2021 14:15:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 213313.371490; Tue, 19 Oct 2021 14:15:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcpto-0002FQ-50; Tue, 19 Oct 2021 14:15:28 +0000
Received: by outflank-mailman (input) for mailman id 213313;
 Tue, 19 Oct 2021 14:15:26 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenbits.xen.org>) id 1mcptm-0002FK-NI
 for xen-devel@lists.xenproject.org; Tue, 19 Oct 2021 14:15:26 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenbits.xen.org>)
 id 1mcptl-00038f-Dx; Tue, 19 Oct 2021 14:15:25 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenbits.xen.org>)
 id 1mcptl-0000A9-7H; Tue, 19 Oct 2021 14:15:25 +0000
Received: from iwj by osstest.test-lab.xenproject.org with local (Exim 4.92)
 (envelope-from <iwj@xenbits.xen.org>)
 id 1mcptl-0002fM-6i; Tue, 19 Oct 2021 14:15:25 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
To: jgross@suse.com,iwj@xenproject.org,xen-devel@lists.xenproject.org
Subject: [adhoc test] 165675: truncated
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Message-Id: <E1mcptl-0002fM-6i@osstest.test-lab.xenproject.org>
From: iwj@xenbits.xen.org
Date: Tue, 19 Oct 2021 14:15:25 +0000

[adhoc play] <testing.git (HEAD detached at 14a279c4) /dev/pts/3>
harness 14a279c4: osstest: explicitly enable building qemu-traditional
165675: truncated

flight 165675 xen-unstable play [play]
http://logs.test-lab.xenproject.org/osstest/logs/165675/

Perfect :-)
All tests in this flight passed as required
baseline version:
 flight               165635

jobs:
 build-amd64                                                  truncated


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary



From xen-devel-bounces@lists.xenproject.org Tue Oct 19 15:06:48 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Oct 2021 15:06:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.213336.371507 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcqhI-0007Su-9X; Tue, 19 Oct 2021 15:06:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 213336.371507; Tue, 19 Oct 2021 15:06:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcqhI-0007Sn-6J; Tue, 19 Oct 2021 15:06:36 +0000
Received: by outflank-mailman (input) for mailman id 213336;
 Tue, 19 Oct 2021 15:06:34 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=gzZp=PH=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mcqhG-0007Sh-OU
 for xen-devel@lists.xenproject.org; Tue, 19 Oct 2021 15:06:34 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 254d152a-30ee-11ec-8317-12813bfff9fa;
 Tue, 19 Oct 2021 15:06:33 +0000 (UTC)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2105.outbound.protection.outlook.com [104.47.17.105])
 (Using TLS) by relay.mimecast.com with ESMTP id
 de-mta-21-HuxZTiYmNbW_sNA1qldx7A-1; Tue, 19 Oct 2021 17:06:31 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB4350.eurprd04.prod.outlook.com (2603:10a6:803:3e::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.17; Tue, 19 Oct
 2021 15:06:29 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.018; Tue, 19 Oct 2021
 15:06:29 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6P195CA0052.EURP195.PROD.OUTLOOK.COM (2603:10a6:209:87::29) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.15 via Frontend Transport; Tue, 19 Oct 2021 15:06:28 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 254d152a-30ee-11ec-8317-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634655992;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=+fDDAHyhygBrlo7ERUk/LHMjHLwkqKGbCYdAdI9ziJs=;
	b=mFWm+EbYNC0Sm7ffg3p8KVsZxIW5xwSPCZnxIsikfep9OEe1cJ/SO0rp2H5WYRte9iQlAv
	pGZsv9PDGbb2ltvb/X7aOUAr6vQlkywZAXGfCHL+DM/IVdzgwpM2hHsvtOHw8m1C+hJ/Hh
	dlMYsVqaaomwrnkHa+WSBFlzxHT4tyo=
X-MC-Unique: HuxZTiYmNbW_sNA1qldx7A-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ofXZC/ApXws3hlT+TTYOLRWKwDeYR9urJexLKSZtArOG3mYspNiTc54xfx7getwzV3RlOtVmZyhCODVZXLn/15TIyOO/vtstzFwP74qCHzzk2yU4OO/KD73aS6QoICUTFJeCsv2fqeoLdut8x0WwT6qTCFPa1haUFNw2g4q1kGuaXQ/3zBGhhDVLGdlH52bUX2WYhCmEK6aBTNzFCh355/MGJ1SZnpOr9qW8Wlr5/aD7iI1FPmibBg7e9L9YaDwfeWchqcVj0duM7hcQACklqnGT+0PVyyOjt+p02StDm87clcbRYikVUJ00koJh2vxi3mlwkwyu8lOZnckXocnuCQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Z8ke/QX7gNdmFCNySK5F3vO3xAjkZDmo+WEJy30JzYQ=;
 b=YO2PGdFs/w3IMj92+B493zz3dHTABbfC0Q0or9bv2N34/N6D6/PSj2G/AextrZf+ac4OedqEOvTb30HwvmCTuI9SkjmVfk2S9Y4CCEgkiZftWHW+q2UU6eF+QJu2xrF8XinJkUiUCYH1ENh6VR1rGYakQBVrE0IzQx/Vmmw98Hrf9V/Bhl9ESvbkXmeaGgah/173XEPu2GNnNaE0DY4LdsbIDYWbjN+EeAt7Fr6wQYaykc7V3mKf/aWq1tjFDbZOYFzbt19AdFUkpBe1z9/TX3zT32rYsOxUfQi7/1V+i1rUfkn7W6xBZVDU0/VixgaVR6OHo7safMtyS0DC6a9/kQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: intel.com; dkim=none (message not signed)
 header.d=none;intel.com; dmarc=none action=none header.from=suse.com;
Subject: Re: [PATCH v2] x86/PoD: defer nested P2M flushes
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Kevin Tian <kevin.tian@intel.com>
References: <c6f2dcd7-81e6-3fb6-0e13-3ffb95e12bc1@suse.com>
 <YW7N13JsVfwwcqAl@MacBook-Air-de-Roger.local>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <67220d20-9722-6566-0c6c-6166e346b09f@suse.com>
Date: Tue, 19 Oct 2021 17:06:27 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <YW7N13JsVfwwcqAl@MacBook-Air-de-Roger.local>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6P195CA0052.EURP195.PROD.OUTLOOK.COM
 (2603:10a6:209:87::29) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 86ce506a-c5ff-4c7b-fb92-08d99312075f
X-MS-TrafficTypeDiagnostic: VI1PR04MB4350:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB4350642CFF6EF49FD4DA38E4B3BD9@VI1PR04MB4350.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	3L67KOWd6W1iHpKdX6fWRLMACoN+zb004UVfQLlSA71ewiOb1eWIxMPEnpDysc+A9SGdUXhxYlfR+AsBfqEZvK9oePnO2czHdJRHct88YhCS8TAugmQucPXGtc6tEhQzCTvMUI1KbP/+wBY9/itfgu2Yc1PVjPZZnmh+Qoqa/eulSkZUzvxGfCtfCRNDpmiN9ZsarPBAKvSazpKKckNo3UneCF7pjb9LT6U/r8AwmBqK4SYZtfD+RD+DTY5GULCJsqBxlkOAhPw2pE3osZItn1fVtgZUaAWCqkeEHNAHylcw6hW/hNi+3eSZ5p3AbyOvNmRP7pwx55XQeiV2vr2XkgxYtTXj8GUtGHNgA823fPrAl78RKObk3hiJjxFxJNNMv7+RSS7i5s31/mUcSTfXpPAmz1aUt+MHzrCNq0q1EBKbbDDPFsp0+1CcMUOi1mq4rub+yRMexz9+syBG9IwPt9LtyVXMbMFxOMb90c0ySlSPno0ASPC/SISdbnUPZopcPWfSKGjLEhQD9Z/wb85K1submSJR0lqN4EFkB+27X0PU2qOItauZLv7iPGOsyPUF+1ij4bWhbSmHY3KxsEzdZDMJNIZR1fMsoP1bgGooASm/frqwHa87fCuNTHiIUiC3MvrbA8FicZ15Mk5bquDt+thp/xk4Q88Bd3o9wDvuEjWbBZn63vm/CkRT6mrufGofbJMInQQG0zxL/NpkI7Ergfwq0xWYO2Y6efJBAh/YfnY=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(16576012)(38100700002)(66946007)(6486002)(2906002)(86362001)(316002)(8936002)(5660300002)(2616005)(186003)(6916009)(83380400001)(66556008)(8676002)(53546011)(4326008)(36756003)(31696002)(508600001)(54906003)(31686004)(26005)(66476007)(956004)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?GJ7VRY/Buz9jLwBUQ94sXQbixGpasoR4UXAeoMwSzhDvaR+x3TebPcWfBAwo?=
 =?us-ascii?Q?S9Q++aiYHu1F4QwmjbK8bTq8gGE2De9Q8889+1+7PKHN3ytQXfnjRZVQAWPx?=
 =?us-ascii?Q?fURxzo4SYdreDLyTm48MfoRHealodgMvCY6OB8Q1zIwTyOgzXAp2ZGCaL28b?=
 =?us-ascii?Q?r52pxWErjkbGHI7ro3XO6CEc0YoUV0gun81IXlQBIQi2wCBYnq/aOGIqNvZi?=
 =?us-ascii?Q?Lsao2RzlG6Y+/4rLRiynNPEwR6YFynBEH4K4mVFN1peH9EOFN9gearyqmdOU?=
 =?us-ascii?Q?QBw6/+3sFJY9NhKsJ5cw6WNF6HVqciVmtnK7p76ZQp3TkmozQnJGFhXg01Ps?=
 =?us-ascii?Q?RT6QyLbpLCQioIhtwghpRHFEWUg1JkpHbq7xTB0wISOELxdggOMOHEz3RGHU?=
 =?us-ascii?Q?TsSzac8vmX9WQ/Upijl2bEcAtA9smpT4/WSjtQjpvUfb5HqaO5SQ46oP5TS0?=
 =?us-ascii?Q?WCXlEKoWr21ZPNkOm43ROAcAmkkwqmevOy3hWIZ34v2pkafrErbXw/Ud9Sdo?=
 =?us-ascii?Q?A1jvgFKtKMBVPVJKelJxgoiGlg0NC3mIgN/6GBFM5m54b+oZyWLEMWV/RLQp?=
 =?us-ascii?Q?qnz+wOAU+fitAwYuLdjTZU+04TXhJuK9Skq4sZ+o1hWDU0cSjY+w4mslIefU?=
 =?us-ascii?Q?7goY8nwZPieYHGyx8DL5nzyOOsLXvbg2HpEy3lwMOnFK2/JulZvnwalxgmlp?=
 =?us-ascii?Q?43RL2qxzmPLcdarp41neHYL0a7oXGqwWlxt1OwFYU7WlkZsfNxEkqG3pRwtj?=
 =?us-ascii?Q?aceH47okuTMC7YS3xRwKH58qgusIQFNZJEPQ8rtJGbBjjwRYKMFsAU1ZbJVj?=
 =?us-ascii?Q?JCQOT5n2dp3p7BYqffwGjiifyFT2ByHrJ6Q29FuyVqyq2RIbtf9V/Lc0qdtX?=
 =?us-ascii?Q?KWqCNaSvXfzCZYaIFylTk7mnDuEv1AucXI/zx6HiGDIvdyUH/rtQXwM+yDuP?=
 =?us-ascii?Q?YtTR9IL0yYYaEAK8FfWprUyKPRKfGeMUm4sHgr1v/9A4VdqhHwNo+5opYwH/?=
 =?us-ascii?Q?BfLUvVlDVT8TmDWdARsjlK2HlX11dxVyYI8lpky9wZvzm7koUiEUXkOGaNRn?=
 =?us-ascii?Q?6qDf1bQyQdlerMIlH1/ArYdwGobvvWOfzS62qCP/1ta+LuNdjTxCdsjQX+Uw?=
 =?us-ascii?Q?UuWnTXLbwX14zieV7iZDvcq3vxuSUU+/MMRemXi8TFkwgc45u/IZ/9KH/GBz?=
 =?us-ascii?Q?gpkvjNtKlcpdUSFjFghL/3tp8GigqvpZdZhM4upWkdpt9EFKOtxjY42sENCP?=
 =?us-ascii?Q?6wfzHptd02/xBjvaZj3dAvFkD7vgva/MwcMV1edsyaqwGCtqslFC74WW9RDs?=
 =?us-ascii?Q?tQ7RDuTHBvi20JcGHrQiJecv?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 86ce506a-c5ff-4c7b-fb92-08d99312075f
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2021 15:06:29.3610
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: xgS4G8MG6SP/V5VEKondWCjq0RNmaLswj5XOhxRlJI0RvCqsWFhcBVdrQ25PMOc/dQU1pILo4F8oVErG7XjIOw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4350

On 19.10.2021 15:53, Roger Pau Monn=C3=A9 wrote:
> On Tue, Oct 19, 2021 at 02:52:27PM +0200, Jan Beulich wrote:
>> With NPT or shadow in use, the p2m_set_entry() -> p2m_pt_set_entry() ->
>> write_p2m_entry() -> p2m_flush_nestedp2m() call sequence triggers a lock
>> order violation when the PoD lock is held around it. Hence such flushing
>> needs to be deferred. Steal the approach from p2m_change_type_range().
>> (Note that strictly speaking the change at the out_of_memory label is
>> not needed, as the domain gets crashed there anyway. The change is being
>> made nevertheless to avoid setting up a trap from someone meaning to
>> deal with that case better than by domain_crash().)
>>
>> Similarly for EPT I think ept_set_entry() -> ept_sync_domain() ->
>> ept_sync_domain_prepare() -> p2m_flush_nestedp2m() is affected. Make its
>> p2m_flush_nestedp2m() invocation conditional. Note that this then also
>> alters behavior of p2m_change_type_range() on EPT, deferring the nested
>> flushes there as well. I think this should have been that way from the
>> introduction of the flag.
>>
>> Reported-by: Elliott Mitchell <ehem+xen@m5p.com>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>=20
> Acked-by: Roger Pau Monn=C3=A9 <roger.pau@citrix.com>

Thanks.

>> --- a/xen/arch/x86/mm/p2m-ept.c
>> +++ b/xen/arch/x86/mm/p2m-ept.c
>> @@ -1253,7 +1253,7 @@ static void ept_sync_domain_prepare(stru
>>      {
>>          if ( p2m_is_nestedp2m(p2m) )
>>              ept =3D &p2m_get_hostp2m(d)->ept;
>> -        else
>> +        else if ( !p2m->defer_nested_flush )
>>              p2m_flush_nestedp2m(d);
>=20
> I find this model slightly concerning, as we don't actually notify the
> caller that a nested flush as been deferred, so we must make sure that
> whoever sets defer_nested_flush also performs a flush unconditionally
> when clearing the flag.

Well, this _is_ the model used for now. Until this change there was
just a single party setting the flag. And like here, any new party
setting the flag will also need to invoke a flush upon clearing it.
It's not clear to me what alternative model you may have in mind.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Oct 19 15:22:40 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Oct 2021 15:22:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.213347.371517 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcqwi-0001PW-Lu; Tue, 19 Oct 2021 15:22:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 213347.371517; Tue, 19 Oct 2021 15:22:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcqwi-0001PP-J0; Tue, 19 Oct 2021 15:22:32 +0000
Received: by outflank-mailman (input) for mailman id 213347;
 Tue, 19 Oct 2021 15:22:31 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mcqwh-0001PF-8l; Tue, 19 Oct 2021 15:22:31 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mcqwh-0004Hb-2K; Tue, 19 Oct 2021 15:22:31 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mcqwg-0003T9-Or; Tue, 19 Oct 2021 15:22:30 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mcqwg-0006GZ-ON; Tue, 19 Oct 2021 15:22:30 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=FyRJQXaZyb72HoprbPfuHhdm6m7NbHVbMqKsznaSHLs=; b=hfkYudP8kFUNdyGR8mGHd+WKer
	fxj0Wksd7/jZiHa6AKN2y5qz0hcC/ZsEdlW2Ibpo3UIAXePFqRub8rYAxs24MhftLO26kVZDNjY8q
	GzOWh5/xupDKuDaPC3GiIGsSHNynPMaryaQi7wUgEKUX29yD1GGuO0NxpLY2pTCukbWM=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165654-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 165654: tolerable FAIL
X-Osstest-Failures:
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=c11b8d25fbe9c0155e91409594ea6701008409ed
X-Osstest-Versions-That:
    xen=c11b8d25fbe9c0155e91409594ea6701008409ed
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 19 Oct 2021 15:22:30 +0000

flight 165654 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165654/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 165639
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 165639
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165639
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165639
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 165639
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 165639
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 165639
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 165639
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 165639
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 165639
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165639
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 165639
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  c11b8d25fbe9c0155e91409594ea6701008409ed
baseline version:
 xen                  c11b8d25fbe9c0155e91409594ea6701008409ed

Last test of basis   165654  2021-10-19 02:26:18 Z    0 days
Testing same since                          (not found)         0 attempts

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Published tested tree is already up to date.



From xen-devel-bounces@lists.xenproject.org Tue Oct 19 15:42:58 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Oct 2021 15:42:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.213361.371537 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcrGN-0003vM-Ks; Tue, 19 Oct 2021 15:42:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 213361.371537; Tue, 19 Oct 2021 15:42:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcrGN-0003vF-I2; Tue, 19 Oct 2021 15:42:51 +0000
Received: by outflank-mailman (input) for mailman id 213361;
 Tue, 19 Oct 2021 15:42:50 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mcrGM-0003v5-64; Tue, 19 Oct 2021 15:42:50 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mcrGM-0004cc-2n; Tue, 19 Oct 2021 15:42:50 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mcrGL-0004Qc-Rc; Tue, 19 Oct 2021 15:42:49 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mcrGL-0003L1-R7; Tue, 19 Oct 2021 15:42:49 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=9OlrxyvPi/nBwGZ3XfahcS9CL191mJBilVX5ryCK5Zk=; b=7HzJokiVcnY/ie2U1jfB8B2R72
	gSn4Vk3BdBeItVuo4WJZAXtDxDCAbHeORRolTzBntIeSq+hNXLM1RnU2c0tFTwfdpQO2RfBGiDFmz
	VE/myAzb10SOlNZLz4Twjc2+NuDAPdfWwSJ0i5b2eoairqV9X6BEcFXE/fNPxR8MbObQ=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165671-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 165671: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=90246a6d9f6fda3536d042d02867123caabe3aaa
X-Osstest-Versions-That:
    ovmf=91a978ce7e0c7a327cff1d9411b0e1c9dae8824a
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 19 Oct 2021 15:42:49 +0000

flight 165671 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165671/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 90246a6d9f6fda3536d042d02867123caabe3aaa
baseline version:
 ovmf                 91a978ce7e0c7a327cff1d9411b0e1c9dae8824a

Last test of basis   165657  2021-10-19 04:10:05 Z    0 days
Testing same since   165671  2021-10-19 11:10:00 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Guo Dong <guo.dong@intel.com>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   91a978ce7e..90246a6d9f  90246a6d9f6fda3536d042d02867123caabe3aaa -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Tue Oct 19 16:09:04 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Oct 2021 16:09:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.213372.371563 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcrfd-0007Hx-W7; Tue, 19 Oct 2021 16:08:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 213372.371563; Tue, 19 Oct 2021 16:08:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcrfd-0007Hm-S3; Tue, 19 Oct 2021 16:08:57 +0000
Received: by outflank-mailman (input) for mailman id 213372;
 Tue, 19 Oct 2021 16:08:56 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=XJzt=PH=arm.com=bertrand.marquis@srs-us1.protection.inumbo.net>)
 id 1mcrfc-00070r-Ku
 for xen-devel@lists.xenproject.org; Tue, 19 Oct 2021 16:08:56 +0000
Received: from foss.arm.com (unknown [217.140.110.172])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTP
 id 7488a075-20c5-49f6-b186-d28dd48277d0;
 Tue, 19 Oct 2021 16:08:51 +0000 (UTC)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 86A42ED1;
 Tue, 19 Oct 2021 09:08:51 -0700 (PDT)
Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com
 [10.1.199.62])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1AECC3F694;
 Tue, 19 Oct 2021 09:08:50 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7488a075-20c5-49f6-b186-d28dd48277d0
From: Bertrand Marquis <bertrand.marquis@arm.com>
To: xen-devel@lists.xenproject.org
Cc: iwj@xenproject.org,
	Oleksandr_Andrushchenko@epam.com,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	Wei Liu <wl@xen.org>,
	Paul Durrant <paul@xen.org>
Subject: [PATCH v2 1/1] xen/pci: Install vpci handlers on x86 and fix exit path
Date: Tue, 19 Oct 2021 17:08:28 +0100
Message-Id: <d788dcce9e344a39f6761633f0e96774ab42c2aa.1634659471.git.bertrand.marquis@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <cover.1634659471.git.bertrand.marquis@arm.com>
References: <cover.1634659471.git.bertrand.marquis@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Xen might not be able to discover at boot time all devices or some devices
might appear after specific actions from dom0.
In this case dom0 can use the PHYSDEVOP_pci_device_add to signal some
PCI devices to Xen.
As those devices where not known from Xen before, the vpci handlers must
be properly installed during pci_device_add for x86 PVH Dom0, in the
same way as what is done currently on arm (where Xen does not detect PCI
devices but relies on Dom0 to declare them all the time).

So this patch is removing the ifdef protecting the call to
vpci_add_handlers and the comment which was arm specific.

vpci_add_handlers is called on during pci_device_add which can be called
at runtime through hypercall physdev_op.
Remove __hwdom_init as the call is not limited anymore to hardware
domain init and fix linker script to only keep vpci_array in rodata
section.

Add missing vpci handlers cleanup during pci_device_remove and in case
of error with iommu during pci_device_add.

Add empty static inline for vpci_remove_device when CONFIG_VPCI is not
defined.

Fixes: d59168dc05 ("xen/arm: Enable the existing x86 virtual PCI support
for ARM")
Suggested-by: Jan Beulich <jbeulich@suse.com>
Signed-off-by: Bertrand Marquis <bertrand.marquis@arm.com>
---
Changes in v2
- add comment suggested by Jan on top of vpci_add_handlers call
- merge the 3 patches of the serie in one patch and renamed it
- fix x86 and arm linker script to only keep vpci_array in rodata and
only when CONFIG_VPCI is set.
---
 xen/arch/arm/xen.lds.S        | 9 +--------
 xen/arch/x86/xen.lds.S        | 9 +--------
 xen/drivers/passthrough/pci.c | 8 ++++----
 xen/drivers/vpci/vpci.c       | 2 +-
 xen/include/xen/vpci.h        | 2 ++
 5 files changed, 9 insertions(+), 21 deletions(-)

diff --git a/xen/arch/arm/xen.lds.S b/xen/arch/arm/xen.lds.S
index b773f91f1c..08016948ab 100644
--- a/xen/arch/arm/xen.lds.S
+++ b/xen/arch/arm/xen.lds.S
@@ -60,7 +60,7 @@ SECTIONS
        *(.proc.info)
        __proc_info_end = .;
 
-#if defined(CONFIG_HAS_VPCI) && defined(CONFIG_LATE_HWDOM)
+#ifdef CONFIG_HAS_VPCI
        . = ALIGN(POINTER_ALIGN);
        __start_vpci_array = .;
        *(SORT(.data.vpci.*))
@@ -189,13 +189,6 @@ SECTIONS
        *(.init_array)
        *(SORT(.init_array.*))
        __ctors_end = .;
-
-#if defined(CONFIG_HAS_VPCI) && !defined(CONFIG_LATE_HWDOM)
-       . = ALIGN(POINTER_ALIGN);
-       __start_vpci_array = .;
-       *(SORT(.data.vpci.*))
-       __end_vpci_array = .;
-#endif
   } :text
   __init_end_efi = .;
   . = ALIGN(STACK_SIZE);
diff --git a/xen/arch/x86/xen.lds.S b/xen/arch/x86/xen.lds.S
index 11b1da2154..87e344d4dd 100644
--- a/xen/arch/x86/xen.lds.S
+++ b/xen/arch/x86/xen.lds.S
@@ -134,7 +134,7 @@ SECTIONS
        *(.ex_table.pre)
        __stop___pre_ex_table = .;
 
-#if defined(CONFIG_HAS_VPCI) && defined(CONFIG_LATE_HWDOM)
+#ifdef CONFIG_HAS_VPCI
        . = ALIGN(POINTER_ALIGN);
        __start_vpci_array = .;
        *(SORT(.data.vpci.*))
@@ -247,13 +247,6 @@ SECTIONS
        *(.init_array)
        *(SORT(.init_array.*))
        __ctors_end = .;
-
-#if defined(CONFIG_HAS_VPCI) && !defined(CONFIG_LATE_HWDOM)
-       . = ALIGN(POINTER_ALIGN);
-       __start_vpci_array = .;
-       *(SORT(.data.vpci.*))
-       __end_vpci_array = .;
-#endif
   } PHDR(text)
 
   . = ALIGN(SECTION_ALIGN);
diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci.c
index 35e0190796..8928a1c07d 100644
--- a/xen/drivers/passthrough/pci.c
+++ b/xen/drivers/passthrough/pci.c
@@ -756,10 +756,9 @@ int pci_add_device(u16 seg, u8 bus, u8 devfn,
     if ( !pdev->domain )
     {
         pdev->domain = hardware_domain;
-#ifdef CONFIG_ARM
         /*
-         * On ARM PCI devices discovery will be done by Dom0. Add vpci handler
-         * when Dom0 inform XEN to add the PCI devices in XEN.
+         * For devices not discovered by Xen during boot, add vPCI handlers
+         * when Dom0 first informs Xen about such devices.
          */
         ret = vpci_add_handlers(pdev);
         if ( ret )
@@ -768,10 +767,10 @@ int pci_add_device(u16 seg, u8 bus, u8 devfn,
             pdev->domain = NULL;
             goto out;
         }
-#endif
         ret = iommu_add_device(pdev);
         if ( ret )
         {
+            vpci_remove_device(pdev);
             pdev->domain = NULL;
             goto out;
         }
@@ -819,6 +818,7 @@ int pci_remove_device(u16 seg, u8 bus, u8 devfn)
     list_for_each_entry ( pdev, &pseg->alldevs_list, alldevs_list )
         if ( pdev->bus == bus && pdev->devfn == devfn )
         {
+            vpci_remove_device(pdev);
             pci_cleanup_msi(pdev);
             ret = iommu_remove_device(pdev);
             if ( pdev->domain )
diff --git a/xen/drivers/vpci/vpci.c b/xen/drivers/vpci/vpci.c
index decf7d87a1..74894bcbac 100644
--- a/xen/drivers/vpci/vpci.c
+++ b/xen/drivers/vpci/vpci.c
@@ -54,7 +54,7 @@ void vpci_remove_device(struct pci_dev *pdev)
     pdev->vpci = NULL;
 }
 
-int __hwdom_init vpci_add_handlers(struct pci_dev *pdev)
+int vpci_add_handlers(struct pci_dev *pdev)
 {
     unsigned int i;
     int rc = 0;
diff --git a/xen/include/xen/vpci.h b/xen/include/xen/vpci.h
index 6746c2589a..9ea66e033f 100644
--- a/xen/include/xen/vpci.h
+++ b/xen/include/xen/vpci.h
@@ -230,6 +230,8 @@ static inline int vpci_add_handlers(struct pci_dev *pdev)
     return 0;
 }
 
+static inline void vpci_remove_device(struct pci_dev *pdev) { }
+
 static inline void vpci_dump_msi(void) { }
 
 static inline uint32_t vpci_read(pci_sbdf_t sbdf, unsigned int reg,
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Tue Oct 19 16:09:04 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Oct 2021 16:09:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.213371.371551 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcrfY-000714-NL; Tue, 19 Oct 2021 16:08:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 213371.371551; Tue, 19 Oct 2021 16:08:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcrfY-00070x-KK; Tue, 19 Oct 2021 16:08:52 +0000
Received: by outflank-mailman (input) for mailman id 213371;
 Tue, 19 Oct 2021 16:08:51 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=XJzt=PH=arm.com=bertrand.marquis@srs-us1.protection.inumbo.net>)
 id 1mcrfX-00070r-RY
 for xen-devel@lists.xenproject.org; Tue, 19 Oct 2021 16:08:51 +0000
Received: from foss.arm.com (unknown [217.140.110.172])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTP
 id a12943d4-a8b9-4cb6-8e80-eb5c673e7b72;
 Tue, 19 Oct 2021 16:08:50 +0000 (UTC)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id DB7D22F;
 Tue, 19 Oct 2021 09:08:49 -0700 (PDT)
Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com
 [10.1.199.62])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 6E46A3F694;
 Tue, 19 Oct 2021 09:08:48 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a12943d4-a8b9-4cb6-8e80-eb5c673e7b72
From: Bertrand Marquis <bertrand.marquis@arm.com>
To: xen-devel@lists.xenproject.org
Cc: iwj@xenproject.org,
	Oleksandr_Andrushchenko@epam.com,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	Wei Liu <wl@xen.org>,
	Paul Durrant <paul@xen.org>
Subject: [PATCH v2 0/1] Fixes: PCI devices passthrough on Arm
Date: Tue, 19 Oct 2021 17:08:27 +0100
Message-Id: <cover.1634659471.git.bertrand.marquis@arm.com>
X-Mailer: git-send-email 2.25.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

This patch serie is a follow-up after various findings on d59168dc05
("xen/arm: Enable the existing x86 virtual PCI support for ARM") as of
agreed in [1].

It does the following:
- enable vpci_add_handlers on x86 and not only on arm
- remove __hwdom_init flag for vpci_add_handlers
- add missing vpci handler cleanup in error path during pci_device_add
  and pci_device_remove

[1] https://marc.info/?l=xen-devel&m=163455502020100&w=2

In the second version of the serie, the 3 patches have been merged into
one single patch.

Bertrand Marquis (1):
  xen/pci: Install vpci handlers on x86 and fix exit path

 xen/arch/arm/xen.lds.S        | 9 +--------
 xen/arch/x86/xen.lds.S        | 9 +--------
 xen/drivers/passthrough/pci.c | 8 ++++----
 xen/drivers/vpci/vpci.c       | 2 +-
 xen/include/xen/vpci.h        | 2 ++
 5 files changed, 9 insertions(+), 21 deletions(-)

-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Tue Oct 19 16:15:28 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Oct 2021 16:15:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.213387.371574 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcrlr-0000az-Md; Tue, 19 Oct 2021 16:15:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 213387.371574; Tue, 19 Oct 2021 16:15:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcrlr-0000as-JQ; Tue, 19 Oct 2021 16:15:23 +0000
Received: by outflank-mailman (input) for mailman id 213387;
 Tue, 19 Oct 2021 16:15:22 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mcrlq-0000ai-Bx; Tue, 19 Oct 2021 16:15:22 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mcrlq-0005hU-6t; Tue, 19 Oct 2021 16:15:22 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mcrlp-00059i-VQ; Tue, 19 Oct 2021 16:15:22 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mcrlp-0002KI-Ut; Tue, 19 Oct 2021 16:15:21 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=BbY8CeLJ7Xhbm/Lu14CFzPvNEMDVcS3Xy6qLsu3ZBVc=; b=WUyDj4JjsTwsmCvIPzvnT5jGSp
	KXzN1Z4b7R7Av/2ie82TCE68+uPkOn0v2YZyLzKSvdl2huzLYC6oCXv06bjuQ4OiUSlaOA8QqNN++
	g+0m1h3dINVBx3YHsAppswVUfcc5krihwIWFh0UE+UL6XKn7d6BFGzLugT4yDOXhZH74=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165658-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 165658: regressions - FAIL
X-Osstest-Failures:
    libvirt:build-armhf-libvirt:libvirt-build:fail:regression
    libvirt:build-amd64-libvirt:libvirt-build:fail:regression
    libvirt:build-arm64-libvirt:libvirt-build:fail:regression
    libvirt:build-i386-libvirt:libvirt-build:fail:regression
    libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    libvirt=8eb08e0fc5fe42efd2b0a4226f2b71f183ba193b
X-Osstest-Versions-That:
    libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 19 Oct 2021 16:15:21 +0000

flight 165658 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165658/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-armhf-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-amd64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-arm64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-i386-libvirt            6 libvirt-build            fail REGR. vs. 151777

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-libvirt-vhd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a

version targeted for testing:
 libvirt              8eb08e0fc5fe42efd2b0a4226f2b71f183ba193b
baseline version:
 libvirt              2c846fa6bcc11929c9fb857a22430fb9945654ad

Last test of basis   151777  2020-07-10 04:19:19 Z  466 days
Failing since        151818  2020-07-11 04:18:52 Z  465 days  451 attempts
Testing same since   165658  2021-10-19 04:18:52 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
    Adolfo Jayme Barrientos <fitoschido@gmail.com>
  Aleksandr Alekseev <alexander.alekseev@virtuozzo.com>
  Aleksei Zakharov <zaharov@selectel.ru>
  Andika Triwidada <andika@gmail.com>
  Andrea Bolognani <abologna@redhat.com>
  Ani Sinha <ani@anisinha.ca>
  Balázs Meskó <meskobalazs@mailbox.org>
  Barrett Schonefeld <bschoney@utexas.edu>
  Bastian Germann <bastiangermann@fishpost.de>
  Bastien Orivel <bastien.orivel@diateam.net>
  BiaoXiang Ye <yebiaoxiang@huawei.com>
  Bihong Yu <yubihong@huawei.com>
  Binfeng Wu <wubinfeng@huawei.com>
  Bjoern Walk <bwalk@linux.ibm.com>
  Boris Fiuczynski <fiuczy@linux.ibm.com>
  Brian Turek <brian.turek@gmail.com>
  Bruno Haible <bruno@clisp.org>
  Chris Mayo <aklhfex@gmail.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Ehrhardt <christian.ehrhardt@canonical.com>
  Christian Kirbach <christian.kirbach@gmail.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Cole Robinson <crobinso@redhat.com>
  Collin Walling <walling@linux.ibm.com>
  Cornelia Huck <cohuck@redhat.com>
  Cédric Bosdonnat <cbosdonnat@suse.com>
  Côme Borsoi <fedora@borsoi.fr>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniel Letai <dani@letai.org.il>
  Daniel P. Berrange <berrange@redhat.com>
  Daniel P. Berrangé <berrange@redhat.com>
  Didik Supriadi <didiksupriadi41@gmail.com>
  dinglimin <dinglimin@cmss.chinamobile.com>
  Dmytro Linkin <dlinkin@nvidia.com>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Eric Farman <farman@linux.ibm.com>
  Erik Skultety <eskultet@redhat.com>
  Fabian Affolter <mail@fabian-affolter.ch>
  Fabian Freyer <fabian.freyer@physik.tu-berlin.de>
  Fabiano Fidêncio <fabiano@fidencio.org>
  Fangge Jin <fjin@redhat.com>
  Farhan Ali <alifm@linux.ibm.com>
  Fedora Weblate Translation <i18n@lists.fedoraproject.org>
  Gavi Teitz <gavi@nvidia.com>
  gongwei <gongwei@smartx.com>
  Guoyi Tu<tu.guoyi@h3c.com>
  Göran Uddeborg <goeran@uddeborg.se>
  Halil Pasic <pasic@linux.ibm.com>
  Han Han <hhan@redhat.com>
  Hao Wang <wanghao232@huawei.com>
  Hela Basa <r45xveza@pm.me>
  Helmut Grohne <helmut@subdivi.de>
  Hiroki Narukawa <hnarukaw@yahoo-corp.jp>
  Ian Wienand <iwienand@redhat.com>
  Jakob Meng <jakobmeng@web.de>
  Jamie Strandboge <jamie@canonical.com>
  Jamie Strandboge <jamie@ubuntu.com>
  Jan Kuparinen <copper_fin@hotmail.com>
  jason lee <ppark5237@gmail.com>
  Jean-Baptiste Holcroft <jean-baptiste@holcroft.fr>
  Jia Zhou <zhou.jia2@zte.com.cn>
  Jianan Gao <jgao@redhat.com>
  Jim Fehlig <jfehlig@suse.com>
  Jin Yan <jinyan12@huawei.com>
  Jinsheng Zhang <zhangjl02@inspur.com>
  Jiri Denemark <jdenemar@redhat.com>
  John Ferlan <jferlan@redhat.com>
  Jonathan Watt <jwatt@jwatt.org>
  Jonathon Jongsma <jjongsma@redhat.com>
  Julio Faracco <jcfaracco@gmail.com>
  Justin Gatzen <justin.gatzen@gmail.com>
  Ján Tomko <jtomko@redhat.com>
  Kashyap Chamarthy <kchamart@redhat.com>
  Kevin Locke <kevin@kevinlocke.name>
  Kristina Hanicova <khanicov@redhat.com>
  Laine Stump <laine@redhat.com>
  Laszlo Ersek <lersek@redhat.com>
  Lee Yarwood <lyarwood@redhat.com>
  Lei Yang <yanglei209@huawei.com>
  Liao Pingfang <liao.pingfang@zte.com.cn>
  Lin Ma <lma@suse.com>
  Lin Ma <lma@suse.de>
  Lin Ma <morecache@gmail.com>
  Liu Yiding <liuyd.fnst@fujitsu.com>
  Luke Yue <lukedyue@gmail.com>
  Luyao Zhong <luyao.zhong@intel.com>
  Marc Hartmayer <mhartmay@linux.ibm.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Markus Schade <markus.schade@hetzner.com>
  Martin Kletzander <mkletzan@redhat.com>
  Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
  Matej Cepl <mcepl@cepl.eu>
  Matt Coleman <matt@datto.com>
  Matt Coleman <mcoleman@datto.com>
  Mauro Matteo Cascella <mcascell@redhat.com>
  Meina Li <meili@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Michał Smyk <fedora@smyk.it>
  Milo Casagrande <milo@milo.name>
  Moshe Levi <moshele@nvidia.com>
  Muha Aliss <muhaaliss@gmail.com>
  Nathan <nathan95@live.it>
  Neal Gompa <ngompa13@gmail.com>
  Nick Chevsky <nchevsky@gmail.com>
  Nick Shyrokovskiy <nshyrokovskiy@gmail.com>
  Nickys Music Group <nickys.music.group@gmail.com>
  Nico Pache <npache@redhat.com>
  Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
  Olaf Hering <olaf@aepfle.de>
  Olesya Gerasimenko <gammaray@basealt.ru>
  Orion Poplawski <orion@nwra.com>
  Pany <geekpany@gmail.com>
  Patrick Magauran <patmagauran.j@gmail.com>
  Paulo de Rezende Pinatti <ppinatti@linux.ibm.com>
  Pavel Hrdina <phrdina@redhat.com>
  Peng Liang <liangpeng10@huawei.com>
  Peter Krempa <pkrempa@redhat.com>
  Pino Toscano <ptoscano@redhat.com>
  Pino Toscano <toscano.pino@tiscali.it>
  Piotr Drąg <piotrdrag@gmail.com>
  Prathamesh Chavan <pc44800@gmail.com>
  Praveen K Paladugu <prapal@linux.microsoft.com>
  Richard W.M. Jones <rjones@redhat.com>
  Ricky Tigg <ricky.tigg@gmail.com>
  Robin Lee <cheeselee@fedoraproject.org>
  Roman Bogorodskiy <bogorodskiy@gmail.com>
  Roman Bolshakov <r.bolshakov@yadro.com>
  Ryan Gahagan <rgahagan@cs.utexas.edu>
  Ryan Schmidt <git@ryandesign.com>
  Sam Hartman <hartmans@debian.org>
  Scott Shambarger <scott-libvirt@shambarger.net>
  Sebastian Mitterle <smitterl@redhat.com>
  SeongHyun Jo <caelus9536@gmail.com>
  Shalini Chellathurai Saroja <shalini@linux.ibm.com>
  Shaojun Yang <yangshaojun@phytium.com.cn>
  Shi Lei <shi_lei@massclouds.com>
  simmon <simmon@nplob.com>
  Simon Chopin <chopin.simon@gmail.com>
  Simon Gaiser <simon@invisiblethingslab.com>
  Simon Rowe <simon.rowe@nutanix.com>
  Stefan Bader <stefan.bader@canonical.com>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Berger <stefanb@linux.vnet.ibm.com>
  Stefan Hajnoczi <stefanha@gmail.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Szymon Scholz <szymonscholz@gmail.com>
  Thomas Huth <thuth@redhat.com>
  Tim Wiederhake <twiederh@redhat.com>
  Tomáš Golembiovský <tgolembi@redhat.com>
  Tomáš Janoušek <tomi@nomi.cz>
  Tuguoyi <tu.guoyi@h3c.com>
  Victor Toso <victortoso@redhat.com>
  Ville Skyttä <ville.skytta@iki.fi>
  Vinayak Kale <vkale@nvidia.com>
  Wang Xin <wangxinxin.wang@huawei.com>
  WangJian <wangjian161@huawei.com>
  Weblate <noreply@weblate.org>
  Wei Liu <liuwe@microsoft.com>
  Wei Liu <wei.liu@kernel.org>
  Wei-Chen Chen <weicche@microsoft.com>
  William Douglas <william.douglas@intel.com>
  Yalei Li <274268859@qq.com>
  Yalei Li <liyl43@chinatelecom.cn>
  Yang Fei <yangfei85@huawei.com>
  Yang Hang <yanghang44@huawei.com>
  Yanqiu Zhang <yanqzhan@redhat.com>
  Yaroslav Kargin <ykargin@virtuozzo.com>
  Yi Li <yili@winhong.com>
  Yi Wang <wang.yi59@zte.com.cn>
  Yuri Chornoivan <yurchor@ukr.net>
  Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
  zhangjl02 <zhangjl02@inspur.com>
  Zheng Chuan <zhengchuan@huawei.com>
  zhenwei pi <pizhenwei@bytedance.com>
  Zhenyu Ye <yezhenyu2@huawei.com>
  Zhenyu Zheng <zheng.zhenyu@outlook.com>
  Zhenzhong Duan <zhenzhong.duan@intel.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          fail    
 build-arm64-libvirt                                          fail    
 build-armhf-libvirt                                          fail    
 build-i386-libvirt                                           fail    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           blocked 
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-libvirt-xsm                                 blocked 
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-libvirt                                     blocked 
 test-arm64-arm64-libvirt                                     blocked 
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-libvirt-pair                                blocked 
 test-amd64-i386-libvirt-pair                                 blocked 
 test-arm64-arm64-libvirt-qcow2                               blocked 
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-libvirt-vhd                                 blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 79856 lines long.)


From xen-devel-bounces@lists.xenproject.org Tue Oct 19 17:06:06 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Oct 2021 17:06:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.213402.371593 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcsYm-0005u1-Ry; Tue, 19 Oct 2021 17:05:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 213402.371593; Tue, 19 Oct 2021 17:05:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcsYm-0005tu-P4; Tue, 19 Oct 2021 17:05:56 +0000
Received: by outflank-mailman (input) for mailman id 213402;
 Tue, 19 Oct 2021 17:05:56 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mcsYm-0005tk-0e; Tue, 19 Oct 2021 17:05:56 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mcsYl-0006X7-Ip; Tue, 19 Oct 2021 17:05:55 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mcsYl-0007yC-Ce; Tue, 19 Oct 2021 17:05:55 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mcsYl-0005TS-C9; Tue, 19 Oct 2021 17:05:55 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=vjAczbPzl/F7lFF9XDVZXjTnUimoHzmEURnsYAV+XWU=; b=OpfDqZ2xfdRrpnKDG39eZs/RFq
	d+0uBvsM6RvvMJpTbA9BJ8BD2b1bufREHijRGjxCaxa7M0RY7Xvc7RbteNe5SxvqHB19TiWXoxZB9
	ycgW+wI4WXhZPlpacQq93LIwEOltBZbYgBHSk9fV/Iv7kH0DmYU6GDw8N3SWEqcI81ok=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165676-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 165676: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=6809998c5f8f1d2e26ac9e867af8ac71e7a66cf2
X-Osstest-Versions-That:
    xen=c11b8d25fbe9c0155e91409594ea6701008409ed
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 19 Oct 2021 17:05:55 +0000

flight 165676 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165676/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  6809998c5f8f1d2e26ac9e867af8ac71e7a66cf2
baseline version:
 xen                  c11b8d25fbe9c0155e91409594ea6701008409ed

Last test of basis   165635  2021-10-18 13:00:26 Z    1 days
Failing since        165638  2021-10-18 16:01:36 Z    1 days    6 attempts
Testing same since   165676  2021-10-19 14:00:27 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Ian Jackson <iwj@xenproject.org>
  Jan Beulich <jbeulich@suse.com>
  Juergen Gross <jgross@suse.com>
  Roger Pau Monné <roger.pau@citrix.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   c11b8d25fb..6809998c5f  6809998c5f8f1d2e26ac9e867af8ac71e7a66cf2 -> smoke


From xen-devel-bounces@lists.xenproject.org Tue Oct 19 17:19:22 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Oct 2021 17:19:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.213411.371607 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcslc-0007Vs-2T; Tue, 19 Oct 2021 17:19:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 213411.371607; Tue, 19 Oct 2021 17:19:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcslb-0007Vl-Vm; Tue, 19 Oct 2021 17:19:11 +0000
Received: by outflank-mailman (input) for mailman id 213411;
 Tue, 19 Oct 2021 17:19:11 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mcslb-0007Vf-0G
 for xen-devel@lists.xenproject.org; Tue, 19 Oct 2021 17:19:11 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mcsla-0006lF-Na; Tue, 19 Oct 2021 17:19:10 +0000
Received: from [54.239.6.189] (helo=[192.168.0.120])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mcsla-0008OD-DR; Tue, 19 Oct 2021 17:19:10 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=kyK/wTNQ4cFxGRIUwYVloynCJR6nTraNDpaAy4O56wc=; b=nREUSxpM541wmPZvpIAb29ep7V
	M9S6Zlc9epyX++sK00mHhd9qpvqLgvFnCAZGYzR3ItNQi9fZj94nJYYkbhCK7yYzsGRM0ec40D01/
	QdxCUrSGNJoyXAnIFm7wzTsawbgFNUU/zZYDWm+oNQ/nDA/Uws2GE+B8YAn9LmHf/4Qo=;
Message-ID: <aa7add3d-ab03-a21f-72b7-89c11aeb8006@xen.org>
Date: Tue, 19 Oct 2021 18:19:07 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.2.0
Subject: Re: [PATCH v2 2/6] xen/arm: introduce direct-map for domUs
To: Penny Zheng <penny.zheng@arm.com>, xen-devel@lists.xenproject.org,
 sstabellini@kernel.org
Cc: Wei.Chen@arm.com, Bertrand.Marquis@arm.com
References: <20211015030945.2082898-1-penny.zheng@arm.com>
 <20211015030945.2082898-3-penny.zheng@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20211015030945.2082898-3-penny.zheng@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi Penny,

On 15/10/2021 04:09, Penny Zheng wrote:
> From: Stefano Stabellini <stefano.stabellini@xilinx.com>
> 
> Cases where domU needs direct-map memory map:
>    * IOMMU not present in the system.
>    * IOMMU disabled if it doesn't cover a specific device and all the guests
> are trusted. Thinking a mixed scenario, where a few devices with IOMMU and
> a few without, then guest DMA security still could not be totally guaranteed.
> So users may want to disable the IOMMU, to at least gain some performance
> improvement from IOMMU disabled.
>    * IOMMU disabled as a workaround when it doesn't have enough bandwidth.
> To be specific, in a few extreme situation, when multiple devices do DMA
> concurrently, these requests may exceed IOMMU's transmission capacity.
>    * IOMMU disabled when it adds too much latency on DMA. For example,
> TLB may be missing in some IOMMU hardware, which may bring latency in DMA
> progress, so users may want to disable it in some realtime scenario.
>    * Guest OS relies on the host memory layout-capablei
> 
> *WARNING:
> Users should be aware that it is not always secure to assign a DMA-capable
> device without IOMMU protection.
> The administrator should make sure that:
>   1. The device is assigned to a trusted guest.
>   2. Users have additional security mechanism on the platform.
> 
> This commit also avoids setting XEN_DOMCTL_CDF_iommu when the IOMMU is
> absent/disabled.

This change looks unrelated to the rest of this patch. Can you split in 
a separate patch?

> 
> For now, direct-map is only supported when domain on Static Allocation, that is,
> "xen.static-mem" must be also defined in the domain configuration.
> 
> This commit also introduces a new helper allocate_static_memory_11 to allocate
> static memory as guest RAM for direct-map domain.
> 
> Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>
> Signed-off-by: Penny Zheng <penny.zheng@arm.com>
> ---
>   docs/misc/arm/device-tree/booting.txt |  10 ++
>   xen/arch/arm/domain_build.c           | 215 ++++++++++++++++++++------
>   2 files changed, 179 insertions(+), 46 deletions(-)
> 
> diff --git a/docs/misc/arm/device-tree/booting.txt b/docs/misc/arm/device-tree/booting.txt
> index 71895663a4..297f8fa0c8 100644
> --- a/docs/misc/arm/device-tree/booting.txt
> +++ b/docs/misc/arm/device-tree/booting.txt
> @@ -182,6 +182,16 @@ with the following properties:
>       Both #address-cells and #size-cells need to be specified because
>       both sub-nodes (described shortly) have reg properties.
>   
> +- direct-map
> +
> +    Optional for Domain on Static Allocation.

I read this as this is mandatory when the domain doesn't use static 
allocation. So how about:

"Only available when statically allocation memory is used for the domain".

> +    An empty property to request the memory of the domain to be
> +    direct-map (guest physical address == physical address).
> +    WARNING:
> +    Users must be aware of this risk, when doing DMA-capable device assignment,
> +    direct-map guest must be trusted or have additional security mechanism,
> +    otherwise it could use the DMA engine to access any other memory area.

I find this warning a bit odd to read because the property will not turn 
off the IOMMU for the domain. This is only going to happen if the admin 
decided to do it.

 From my understanding, it is not going to be possible to assign a 
device without IOMMU unless the property 
"xen,force-assign-without-iommu" is set. This is not a mechanism 
specific to direct-map, so I would drop this WARNING here.

> +
>   Under the "xen,domain" compatible node, one or more sub-nodes are present
>   for the DomU kernel and ramdisk.
>   
> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
> index 37e2d62d47..d9118e5bc1 100644
> --- a/xen/arch/arm/domain_build.c
> +++ b/xen/arch/arm/domain_build.c
> @@ -492,8 +492,14 @@ static bool __init append_static_memory_to_bank(struct domain *d,
>   {
>       int res;
>       unsigned int nr_pages = PFN_DOWN(size);
> -    /* Infer next GFN. */
> -    gfn_t sgfn = gaddr_to_gfn(bank->start + bank->size);
> +    gfn_t sgfn;
> +
> +    if ( !is_domain_direct_mapped(d) )
> +        /* Infer next GFN when GFN != MFN. */
> +        sgfn = gaddr_to_gfn(bank->start + bank->size);
> +    else
> +        sgfn = gaddr_to_gfn(mfn_to_maddr(smfn));
> +
>   
>       res = guest_physmap_add_pages(d, sgfn, smfn, nr_pages);
>       if ( res )
> @@ -507,12 +513,69 @@ static bool __init append_static_memory_to_bank(struct domain *d,
>       return true;
>   }
>   
> -/* Allocate memory from static memory as RAM for one specific domain d. */
> +static int __init acquire_static_memory_bank(struct domain *d,
> +                                             const __be32 **cell,
> +                                             u32 addr_cells, u32 size_cells,
> +                                             paddr_t *pbase, paddr_t *psize)
> +{
> +    int res = 0;
> +
> +    device_tree_get_reg(cell, addr_cells, size_cells, pbase, psize);
> +    ASSERT(IS_ALIGNED(*pbase, PAGE_SIZE) && IS_ALIGNED(*psize, PAGE_SIZE));
> +    if ( PFN_DOWN(*psize) > UINT_MAX )
> +    {
> +        printk(XENLOG_ERR "%pd: static memory size too large: %#"PRIpaddr,
> +               d, *psize);
> +        return -EINVAL;
> +    }
> +
> +    res = acquire_domstatic_pages(d, maddr_to_mfn(*pbase), PFN_DOWN(*psize), 0);
> +    if ( res )
> +        printk(XENLOG_ERR
> +               "%pd: failed to acquire static memory: %d.\n", d, res);
> +
> +    return res;
> +}
> +
> +static int __init parse_static_mem_prop(const struct dt_device_node *node,
> +                                        u32 *addr_cells, u32 *size_cells,
> +                                        int *length, const __be32 **cell)
> +{
> +    const struct dt_property *prop;
> +
> +    prop = dt_find_property(node, "xen,static-mem", NULL);
> +    if ( !dt_property_read_u32(node, "#xen,static-mem-address-cells",
> +                               addr_cells) )
> +    {
> +        printk(XENLOG_ERR
> +               "failed to read \"#xen,static-mem-address-cells\".\n");
> +        return -EINVAL;
> +    }
> +
> +    if ( !dt_property_read_u32(node, "#xen,static-mem-size-cells",
> +                               size_cells) )
> +    {
> +        printk(XENLOG_ERR
> +               "failed to read \"#xen,static-mem-size-cells\".\n");
> +        return -EINVAL;
> +    }
> +
> +    *cell = (const __be32 *)prop->value;
> +    *length = prop->length;
> +
> +    return 0;
> +}
> +
> +/*
> + * Allocate static memory as RAM for one specific domain d.
> + * The static memory will be mapped in the guest at the usual guest
> + * memory addresses (GUEST_RAM0_BASE, GUEST_RAM1_BASE) defined by
> + * xen/include/public/arch-arm.h.
> + */
>   static void __init allocate_static_memory(struct domain *d,
>                                             struct kernel_info *kinfo,
>                                             const struct dt_device_node *node)
>   {
> -    const struct dt_property *prop;
>       u32 addr_cells, size_cells, reg_cells;
>       unsigned int nr_banks, gbank, bank = 0;
>       const uint64_t rambase[] = GUEST_RAM_BANK_BASES;
> @@ -521,61 +584,31 @@ static void __init allocate_static_memory(struct domain *d,
>       u64 tot_size = 0;
>       paddr_t pbase, psize, gsize;
>       mfn_t smfn;
> -    int res;
> +    int length;
>   
> -    prop = dt_find_property(node, "xen,static-mem", NULL);
> -    if ( !dt_property_read_u32(node, "#xen,static-mem-address-cells",
> -                               &addr_cells) )
> -    {
> -        printk(XENLOG_ERR
> -               "%pd: failed to read \"#xen,static-mem-address-cells\".\n", d);
> -        goto fail;
> -    }
> +    gbank = 0;
> +    gsize = ramsize[gbank];
> +    kinfo->mem.bank[gbank].start = rambase[gbank];

I am not sure to understand why this 3 assignments were moved earlier. I 
am not against the change, but this looks somewhat unrelated to this 
patch itself. The same...

>   
> -    if ( !dt_property_read_u32(node, "#xen,static-mem-size-cells",
> -                               &size_cells) )
> +    if ( parse_static_mem_prop(node, &addr_cells, &size_cells, &length, &cell) )
>       {
>           printk(XENLOG_ERR
> -               "%pd: failed to read \"#xen,static-mem-size-cells\".\n", d);
> +               "%pd: failed to parse \"xen,static-mem\" property.\n", d);
>           goto fail;
>       }
>       reg_cells = addr_cells + size_cells;
> -
> -    /*
> -     * The static memory will be mapped in the guest at the usual guest memory
> -     * addresses (GUEST_RAM0_BASE, GUEST_RAM1_BASE) defined by
> -     * xen/include/public/arch-arm.h.
> -     */

... applies to this comment.


But, I would suggest to move the split off of the code outside in a 
separate patch. This will make easier to review new changes vs refactoring.

> -    gbank = 0;
> -    gsize = ramsize[gbank];
> -    kinfo->mem.bank[gbank].start = rambase[gbank];
> -
> -    cell = (const __be32 *)prop->value;
> -    nr_banks = (prop->length) / (reg_cells * sizeof (u32));
> +    nr_banks = length / (reg_cells * sizeof (u32));
>   
>       for ( ; bank < nr_banks; bank++ )
>       {
> -        device_tree_get_reg(&cell, addr_cells, size_cells, &pbase, &psize);
> -        ASSERT(IS_ALIGNED(pbase, PAGE_SIZE) && IS_ALIGNED(psize, PAGE_SIZE));
> -
> -        if ( PFN_DOWN(psize) > UINT_MAX )
> -        {
> -            printk(XENLOG_ERR "%pd: static memory size too large: %#"PRIpaddr,
> -                   d, psize);
> +        if ( acquire_static_memory_bank(d, &cell, addr_cells, size_cells,
> +                                        &pbase, &psize) )
>               goto fail;
> -        }
> -        smfn = maddr_to_mfn(pbase);
> -        res = acquire_domstatic_pages(d, smfn, PFN_DOWN(psize), 0);
> -        if ( res )
> -        {
> -            printk(XENLOG_ERR
> -                   "%pd: failed to acquire static memory: %d.\n", d, res);
> -            goto fail;
> -        }
>   
>           printk(XENLOG_INFO "%pd: STATIC BANK[%u] %#"PRIpaddr"-%#"PRIpaddr"\n",
>                  d, bank, pbase, pbase + psize);
>   
> +        smfn = maddr_to_mfn(pbase);
>           while ( 1 )
>           {
>               /* Map as much as possible the static range to the guest bank */
> @@ -638,12 +671,91 @@ static void __init allocate_static_memory(struct domain *d,
>    fail:
>       panic("Failed to allocate requested static memory for domain %pd.", d);
>   }
> +
> +/*
> + * Allocate static memory as RAM for one specific domain d.
> + * The static memory will be directly mapped in the guest(Guest Physical
> + * Address == Physical Address).
> + */
> +static void __init allocate_static_memory_11(struct domain *d,
> +                                             struct kernel_info *kinfo,
> +                                             const struct dt_device_node *node)
> +{
> +    u32 addr_cells, size_cells, reg_cells;
> +    unsigned int nr_banks, gbank = 0, bank = 0;
> +    const __be32 *cell;
> +    u64 tot_size = 0;
> +    paddr_t pbase, psize;
> +    mfn_t smfn;
> +    int length;
> +
> +    if ( parse_static_mem_prop(node, &addr_cells, &size_cells, &length, &cell) )
> +    {
> +        printk(XENLOG_ERR
> +               "%pd: failed to parse \"xen,static-mem\" property.\n", d);
> +        goto fail;
> +    }
> +    reg_cells = addr_cells + size_cells;
> +    nr_banks = length / (reg_cells * sizeof (u32));
> +
> +    for ( ; bank < nr_banks; bank++ )
> +    {
> +        if ( acquire_static_memory_bank(d, &cell, addr_cells, size_cells,
> +                                        &pbase, &psize) )
> +            goto fail;
> +
> +        printk(XENLOG_INFO "%pd: STATIC BANK[%u] %#"PRIpaddr"-%#"PRIpaddr"\n",
> +               d, bank, pbase, pbase + psize);
> +
> +        /*
> +         * One guest memory bank is matched with one physical
> +         * memory bank.
> +         */
> +        smfn = maddr_to_mfn(pbase);
> +        gbank = bank;

gbank looks pointless as this is equivalent to bank. Can you drop it?

> +        kinfo->mem.bank[gbank].start = pbase;
AFAICT, nr_banks is computed from the DT property. However, our internal 
array has a fixed size. So you want to check we have enough space in the 
array to store all the banks.

> +
> +        if ( !append_static_memory_to_bank(d, &kinfo->mem.bank[gbank],
> +                                           smfn, psize) )
> +            goto fail;
> +
> +        tot_size += psize;
> +    }
> +
> +    kinfo->mem.nr_banks = ++gbank;

At the end of the loop, ++gbank == nr_banks. So how about using nr_banks 
directly?

> +
> +    kinfo->unassigned_mem -= tot_size;
> +    /*
> +     * The property 'memory' should match the amount of memory given to the
> +     * guest.
> +     * Currently, it is only possible to either acquire static memory or let
> +     * Xen allocate. *Mixing* is not supported.
> +     */
> +    if ( kinfo->unassigned_mem )
> +    {
> +        printk(XENLOG_ERR
> +               "Size of \"memory\" property doesn't match up with the sum-up of \"xen,static-mem\". Unsupported configuration.\n");
> +        goto fail;
> +    }
> +
> +    return;
> +
> + fail:
> +    panic("Failed to allocate requested static memory for direct-map domain %pd.",
> +          d);
> +}
>   #else
>   static void __init allocate_static_memory(struct domain *d,
>                                             struct kernel_info *kinfo,
>                                             const struct dt_device_node *node)
>   {
>   }
> +
> +static void __init allocate_static_memory_11(struct domain *d,
> +                                             struct kernel_info *kinfo,
> +                                             const struct dt_device_node *node)
> +{

This helper is not meant to be reachable when built with 
!CONFIG_STATIC_MEMORY. So I would add ASSERT_UNREACHABLE to catch any 
misuse.

> +}
>   #endif
>   
>   static int __init write_properties(struct domain *d, struct kernel_info *kinfo,
> @@ -2936,7 +3048,12 @@ static int __init construct_domU(struct domain *d,
>       if ( !dt_find_property(node, "xen,static-mem", NULL) )
>           allocate_memory(d, &kinfo);
>       else
> -        allocate_static_memory(d, &kinfo, node);
> +    {
> +        if ( is_domain_direct_mapped(d) )
> +            allocate_static_memory_11(d, &kinfo, node);
> +        else
> +            allocate_static_memory(d, &kinfo, node);
> +    }
>   
>       rc = prepare_dtb_domU(d, &kinfo);
>       if ( rc < 0 )
> @@ -2976,8 +3093,14 @@ void __init create_domUs(void)
>               panic("Missing property 'cpus' for domain %s\n",
>                     dt_node_name(node));
>   
> +        if ( dt_property_read_bool(node, "direct-map") )
> +            d_cfg.flags |= XEN_DOMCTL_CDF_directmap;
> +
>           if ( dt_find_compatible_node(node, NULL, "multiboot,device-tree") )
> -            d_cfg.flags |= XEN_DOMCTL_CDF_iommu;
> +        {
> +            if ( iommu_enabled )
> +                d_cfg.flags |= XEN_DOMCTL_CDF_iommu;
> +        }

As I wrote above, this change looks unrelated to this patch. Regardless 
that, the nested if (and indentation) can be avoided if you write:

if ( dt_find_compatible(....) && iommu_enabled )
  ...

>   
>           if ( !dt_property_read_u32(node, "nr_spis", &d_cfg.arch.nr_spis) )
>           {
> 

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Tue Oct 19 17:39:33 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Oct 2021 17:39:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.213421.371619 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mct58-0001XD-Ur; Tue, 19 Oct 2021 17:39:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 213421.371619; Tue, 19 Oct 2021 17:39:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mct58-0001X6-Qa; Tue, 19 Oct 2021 17:39:22 +0000
Received: by outflank-mailman (input) for mailman id 213421;
 Tue, 19 Oct 2021 17:39:21 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mct57-0001X0-13
 for xen-devel@lists.xenproject.org; Tue, 19 Oct 2021 17:39:21 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mct56-00075P-St; Tue, 19 Oct 2021 17:39:20 +0000
Received: from [54.239.6.189] (helo=[192.168.0.120])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mct56-0001g7-Ms; Tue, 19 Oct 2021 17:39:20 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=KBRlEoBodyxAPc8kv1KGXcMMFIB/yfe3/zgqF6WWHRE=; b=MIQnmD0zejofTKcI7AwbulWuem
	eLTa3oACQQ906ZjBPjgfw98D7Tsm6c5o0wTyD+yaDsHsgm2JwMSOMkRgkax/W88M4PCAeAOZfZqyR
	WI9qNy6CRfWo0JYNqh+6qZ/q7XG79z4R+EyUmplMlgzQn3M3ZR17Yx25TSbYJUS+EOqg=;
Message-ID: <1ec81b01-a843-9735-be4e-4a6f0af1b670@xen.org>
Date: Tue, 19 Oct 2021 18:39:18 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.2.0
Subject: Re: [PATCH v2 3/6] xen/arm: if direct-map domain use native addresses
 for GICv2
To: Penny Zheng <penny.zheng@arm.com>, xen-devel@lists.xenproject.org,
 sstabellini@kernel.org
Cc: Wei.Chen@arm.com, Bertrand.Marquis@arm.com
References: <20211015030945.2082898-1-penny.zheng@arm.com>
 <20211015030945.2082898-4-penny.zheng@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20211015030945.2082898-4-penny.zheng@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Penny,

On 15/10/2021 04:09, Penny Zheng wrote:
> From: Stefano Stabellini <stefano.stabellini@xilinx.com>
> 
> Today we use native addresses to map the GICv2 for Dom0 and fixed
> addresses for DomUs.
> 
> This patch changes the behavior so that native addresses are used for
> all domains that are direct-map memory map.

I would simply say: "all domains that are direct-mapped" or "all domains 
that have the memory direct-mapped".

> 
> NEW VGIC has different naming schemes, like referring distributor base
> address as vgic_dist_base, other than the dbase. So this patch also introduces
> vgic_dist_base/vgic_cpu_base accessor to access correct distributor base
> address/cpu interface base address on varied scenarios,
> 
> Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>
> Signed-off-by: Penny Zheng <penny.zheng@arm.com>
> ---
>   xen/arch/arm/domain_build.c    | 10 +++++++---
>   xen/arch/arm/vgic-v2.c         | 26 +++++++++++++++++++++-----
>   xen/arch/arm/vgic/vgic-v2.c    | 27 ++++++++++++++++++++++-----
>   xen/include/asm-arm/new_vgic.h | 10 ++++++++++
>   xen/include/asm-arm/vgic.h     | 12 +++++++++++-
>   5 files changed, 71 insertions(+), 14 deletions(-)
> 
> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
> index d9118e5bc1..6cd03e4d0f 100644
> --- a/xen/arch/arm/domain_build.c
> +++ b/xen/arch/arm/domain_build.c
> @@ -2207,8 +2207,12 @@ static int __init make_gicv2_domU_node(struct kernel_info *kinfo)
>       int res = 0;
>       __be32 reg[(GUEST_ROOT_ADDRESS_CELLS + GUEST_ROOT_SIZE_CELLS) * 2];
>       __be32 *cells;
> +    struct domain *d = kinfo->d;
> +    char buf[38];

Please add a comment explaining how the 38 was found. For an example, 
please look at the comment on top of buf in make_memory_node().

>   
> -    res = fdt_begin_node(fdt, "interrupt-controller@"__stringify(GUEST_GICD_BASE));
> +    snprintf(buf, sizeof(buf), "interrupt-controller@%"PRIx64,
> +             vgic_dist_base(&d->arch.vgic));
> +    res = fdt_begin_node(fdt, buf);
>       if ( res )
>           return res;
>   
> @@ -2230,9 +2234,9 @@ static int __init make_gicv2_domU_node(struct kernel_info *kinfo)
>   
>       cells = &reg[0];
>       dt_child_set_range(&cells, GUEST_ROOT_ADDRESS_CELLS, GUEST_ROOT_SIZE_CELLS,
> -                       GUEST_GICD_BASE, GUEST_GICD_SIZE);
> +                       vgic_dist_base(&d->arch.vgic), GUEST_GICD_SIZE);
>       dt_child_set_range(&cells, GUEST_ROOT_ADDRESS_CELLS, GUEST_ROOT_SIZE_CELLS,
> -                       GUEST_GICC_BASE, GUEST_GICC_SIZE);
> +                       vgic_cpu_base(&d->arch.vgic), GUEST_GICC_SIZE);
>   
>       res = fdt_property(fdt, "reg", reg, sizeof(reg));
>       if (res)
> diff --git a/xen/arch/arm/vgic-v2.c b/xen/arch/arm/vgic-v2.c
> index b2da886adc..a8cf8173d0 100644
> --- a/xen/arch/arm/vgic-v2.c
> +++ b/xen/arch/arm/vgic-v2.c
> @@ -652,7 +652,7 @@ static int vgic_v2_vcpu_init(struct vcpu *v)
>   static int vgic_v2_domain_init(struct domain *d)
>   {
>       int ret;
> -    paddr_t cbase, csize;
> +    paddr_t csize;
>       paddr_t vbase;
>   
>       /*
> @@ -669,10 +669,26 @@ static int vgic_v2_domain_init(struct domain *d)

The comment on top of the "if ( is_hardware_domain(d) )" needs to be 
updated because, after this patch, guests will not always use the 
virtual platform layout.

>            * Note that we assume the size of the CPU interface is always
>            * aligned to PAGE_SIZE.
>            */
> -        cbase = vgic_v2_hw.cbase;
> +        d->arch.vgic.cbase = vgic_v2_hw.cbase;
>           csize = vgic_v2_hw.csize;
>           vbase = vgic_v2_hw.vbase;
>       }
> +    else if ( is_domain_direct_mapped(d) )
> +    {
> +        /*
> +         * For non-dom0 direct_mapped guests we only map a 8kB CPU
Technically, is_hardware_domain() is not equivalent to dom0 (although, 
it is so far the case on Arm). So please avoid using "dom0" and instead 
use "hardware domain".

Also, the wording used is confusing because, from my understanding, dom0 
is not a guest (although it is a domain).

So how about:

"For all the direct-mapped domain other than the hardware domain, ...".

> +         * interface but we make sure it is at a location occupied by
> +         * the physical GIC in the host device tree.
> +         *
> +         * We need to add an offset to the virtual CPU interface base
> +         * address when the GIC is aliased to get a 8kB contiguous
> +         * region.
> +         */
> +        d->arch.vgic.dbase = vgic_v2_hw.dbase;
> +        d->arch.vgic.cbase = vgic_v2_hw.cbase + vgic_v2_hw.aliased_offset;
Couldn't we simply map the CPU interface at the GPA vgic_v2_hw.cbase?

> +        csize = GUEST_GICC_SIZE;
> +        vbase = vgic_v2_hw.vbase + vgic_v2_hw.aliased_offset;
> +    }
>       else
>       {
>           d->arch.vgic.dbase = GUEST_GICD_BASE;
> @@ -683,7 +699,7 @@ static int vgic_v2_domain_init(struct domain *d)
>            * region.
>            */
>           BUILD_BUG_ON(GUEST_GICC_SIZE != SZ_8K);
> -        cbase = GUEST_GICC_BASE;
> +        d->arch.vgic.cbase = GUEST_GICC_BASE;
>           csize = GUEST_GICC_SIZE;
>           vbase = vgic_v2_hw.vbase + vgic_v2_hw.aliased_offset;
>       }
> @@ -692,8 +708,8 @@ static int vgic_v2_domain_init(struct domain *d)
>        * Map the gic virtual cpu interface in the gic cpu interface
>        * region of the guest.
>        */
> -    ret = map_mmio_regions(d, gaddr_to_gfn(cbase), csize / PAGE_SIZE,
> -                           maddr_to_mfn(vbase));
> +    ret = map_mmio_regions(d, gaddr_to_gfn(d->arch.vgic.cbase),
> +                           csize / PAGE_SIZE, maddr_to_mfn(vbase));
>       if ( ret )
>           return ret;
>   
> diff --git a/xen/arch/arm/vgic/vgic-v2.c b/xen/arch/arm/vgic/vgic-v2.c
> index b5ba4ace87..ce1f6e4373 100644
> --- a/xen/arch/arm/vgic/vgic-v2.c
> +++ b/xen/arch/arm/vgic/vgic-v2.c
> @@ -258,7 +258,7 @@ void vgic_v2_enable(struct vcpu *vcpu)
>   int vgic_v2_map_resources(struct domain *d)
>   {
>       struct vgic_dist *dist = &d->arch.vgic;
> -    paddr_t cbase, csize;
> +    paddr_t csize;
>       paddr_t vbase;
>       int ret;
>   
> @@ -276,10 +276,27 @@ int vgic_v2_map_resources(struct domain *d)

Same remark about the comment on top of the 'if ( is_hardware_domain(d) )'.

>            * Note that we assume the size of the CPU interface is always
>            * aligned to PAGE_SIZE.
>            */
> -        cbase = gic_v2_hw_data.cbase;
> +        d->arch.vgic.vgic_cpu_base = gic_v2_hw_data.cbase;
>           csize = gic_v2_hw_data.csize;
>           vbase = gic_v2_hw_data.vbase;
>       }
> +    else if ( is_domain_direct_mapped(d) )
> +    {
> +        d->arch.vgic.vgic_dist_base = gic_v2_hw_data.dbase;
> +        /*
> +         * For non-dom0 direct_mapped guests we only map a 8kB CPU

Same remark here for the non-dom0 part.

> +         * interface but we make sure it is at a location occupied by
> +         * the physical GIC in the host device tree.
> +         *
> +         * We need to add an offset to the virtual CPU interface base
> +         * address when the GIC is aliased to get a 8kB contiguous
> +         * region.
> +         */
> +        d->arch.vgic.vgic_cpu_base = gic_v2_hw_data.cbase +
> +                                     gic_v2_hw_data.aliased_offset;

Same question here.

> +        csize = GUEST_GICC_SIZE;
> +        vbase = gic_v2_hw_data.vbase + gic_v2_hw_data.aliased_offset;
> +    }
>       else
>       {
>           d->arch.vgic.vgic_dist_base = GUEST_GICD_BASE;
> @@ -290,7 +307,7 @@ int vgic_v2_map_resources(struct domain *d)
>            * region.
>            */
>           BUILD_BUG_ON(GUEST_GICC_SIZE != SZ_8K);
> -        cbase = GUEST_GICC_BASE;
> +        d->arch.vgic.vgic_cpu_base = GUEST_GICC_BASE;
>           csize = GUEST_GICC_SIZE;
>           vbase = gic_v2_hw_data.vbase + gic_v2_hw_data.aliased_offset;
>       }
> @@ -308,8 +325,8 @@ int vgic_v2_map_resources(struct domain *d)
>        * Map the gic virtual cpu interface in the gic cpu interface
>        * region of the guest.
>        */
> -    ret = map_mmio_regions(d, gaddr_to_gfn(cbase), csize / PAGE_SIZE,
> -                           maddr_to_mfn(vbase));
> +    ret = map_mmio_regions(d, gaddr_to_gfn(d->arch.vgic.vgic_cpu_base),
> +                           csize / PAGE_SIZE, maddr_to_mfn(vbase));
>       if ( ret )
>       {
>           gdprintk(XENLOG_ERR, "Unable to remap VGIC CPU to VCPU\n");
> diff --git a/xen/include/asm-arm/new_vgic.h b/xen/include/asm-arm/new_vgic.h
> index 97d622bff6..28b0882798 100644
> --- a/xen/include/asm-arm/new_vgic.h
> +++ b/xen/include/asm-arm/new_vgic.h
> @@ -186,6 +186,16 @@ struct vgic_cpu {
>       uint32_t num_id_bits;
>   };
>   
> +static inline paddr_t vgic_cpu_base(struct vgic_dist *vgic)
> +{
> +    return vgic->vgic_cpu_base;
> +}
> +
> +static inline paddr_t vgic_dist_base(struct vgic_dist *vgic)
> +{
> +    return vgic->vgic_dist_base;
> +}
> +
>   #endif /* __ASM_ARM_NEW_VGIC_H */
>   
>   /*
> diff --git a/xen/include/asm-arm/vgic.h b/xen/include/asm-arm/vgic.h
> index 62c2ae538d..3167bbb68b 100644
> --- a/xen/include/asm-arm/vgic.h
> +++ b/xen/include/asm-arm/vgic.h
> @@ -152,6 +152,7 @@ struct vgic_dist {
>       struct pending_irq *pending_irqs;
>       /* Base address for guest GIC */
>       paddr_t dbase; /* Distributor base address */
> +    paddr_t cbase; /* CPU interface base address */
>   #ifdef CONFIG_GICV3
>       /* GIC V3 addressing */
>       /* List of contiguous occupied by the redistributors */
> @@ -271,13 +272,22 @@ static inline int REG_RANK_NR(int b, uint32_t n)
>   
>   enum gic_sgi_mode;
>   
> +static inline paddr_t vgic_cpu_base(struct vgic_dist *vgic)
> +{
> +    return vgic->cbase;
> +}
> +
> +static inline paddr_t vgic_dist_base(struct vgic_dist *vgic)
> +{
> +    return vgic->dbase;
> +}
> +
>   /*
>    * Offset of GICD_<FOO><n> with its rank, for GICD_<FOO> size <s> with
>    * <b>-bits-per-interrupt.
>    */
>   #define REG_RANK_INDEX(b, n, s) ((((n) >> s) & ((b)-1)) % 32)
>   
> -

This looks like a spurious change.

>   extern struct vcpu *vgic_get_target_vcpu(struct vcpu *v, unsigned int virq);
>   extern void vgic_remove_irq_from_queues(struct vcpu *v, struct pending_irq *p);
>   extern void gic_remove_from_lr_pending(struct vcpu *v, struct pending_irq *p);
> 

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Tue Oct 19 19:57:19 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Oct 2021 19:57:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.213432.371633 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcvEN-0006bE-0J; Tue, 19 Oct 2021 19:57:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 213432.371633; Tue, 19 Oct 2021 19:57:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcvEM-0006b7-TU; Tue, 19 Oct 2021 19:57:02 +0000
Received: by outflank-mailman (input) for mailman id 213432;
 Tue, 19 Oct 2021 19:57:01 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=YfyF=PH=oracle.com=alec.r.brown@srs-us1.protection.inumbo.net>)
 id 1mcvEL-0006b1-MA
 for xen-devel@lists.xenproject.org; Tue, 19 Oct 2021 19:57:01 +0000
Received: from mx0a-00069f02.pphosted.com (unknown [205.220.165.32])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id b7e80a2a-3116-11ec-8324-12813bfff9fa;
 Tue, 19 Oct 2021 19:56:59 +0000 (UTC)
Received: from pps.filterd (m0246627.ppops.net [127.0.0.1])
 by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 19JJ20hZ005510; 
 Tue, 19 Oct 2021 19:56:09 GMT
Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79])
 by mx0b-00069f02.pphosted.com with ESMTP id 3bsqgmmv7t-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Tue, 19 Oct 2021 19:56:08 +0000
Received: from pps.filterd (userp3020.oracle.com [127.0.0.1])
 by userp3020.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 19JJpWA1195512;
 Tue, 19 Oct 2021 19:56:04 GMT
Received: from nam12-bn8-obe.outbound.protection.outlook.com
 (mail-bn8nam12lp2177.outbound.protection.outlook.com [104.47.55.177])
 by userp3020.oracle.com with ESMTP id 3br8gsxubx-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Tue, 19 Oct 2021 19:56:04 +0000
Received: from DM6PR10MB2986.namprd10.prod.outlook.com (2603:10b6:5:6b::26) by
 DM5PR1001MB2396.namprd10.prod.outlook.com (2603:10b6:4:30::29) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.18; Tue, 19 Oct 2021 19:56:01 +0000
Received: from DM6PR10MB2986.namprd10.prod.outlook.com
 ([fe80::c5da:305e:be30:abac]) by DM6PR10MB2986.namprd10.prod.outlook.com
 ([fe80::c5da:305e:be30:abac%3]) with mapi id 15.20.4608.018; Tue, 19 Oct 2021
 19:56:01 +0000
Received: from alec-orcl (73.61.222.52) by
 MN2PR17CA0009.namprd17.prod.outlook.com (2603:10b6:208:15e::22) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.15 via Frontend
 Transport; Tue, 19 Oct 2021 19:55:58 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b7e80a2a-3116-11ec-8324-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc
 : subject : message-id : references : content-type : in-reply-to :
 mime-version; s=corp-2021-07-09;
 bh=+XR3LTOt/2W6NSg8Z8xkfFmcz8BR0yTrJbA4p1J5W6w=;
 b=jh7MmqFa7mj2mdtEDGa/wXexJXuGxB7m2zPObitG6ULUygjGdXVtMBaWakulb7bZgHKl
 e6yABbGSFpl9xI9opWgeoPfJ4nrXeqNdvayizlnO1bFZN3vtNZNJtmF5LnBDamW5cIz4
 01pbJvthH470NUUxseStAe8Gg1KKcAdXjqz7flAuszDBi16DzHi6RXnrcB2xl4yPPHZu
 v1tJwV3XINbK3iOnmhp80I5l4Kj0NOauLZfteFTGiwEe0O9Lujgm2meVZESSSTVZa8Uo
 jzwmjesdxm+dgbXmR9DYNZA5BFQCmhpElB33Uio2H3IOOb1T2yrcqeBPahVuiltRO7Uo Cg== 
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=nxOvUGJO24U50UkNmhfKAWEwudOAo8cp3qj3bBG1S5zKxIMAB2Q6xxtfCyj2k8DyoonavmipSyq5d5eR86crPUI2DADHXw5HmnlrK5ApziGpfhglN3EBrlGgfSuwrw8nqaienbXBnilSXW7+lgGHIQLDA0fzFB9wRoLyw0y0xTXUgXzO9O8wQjLCxBJjF2OntuK+zZ7j8jX+SGPjiy++I9mD+oQNygr/o7KLgoSNuDd6sDDc8mnb5w+GhKa8YAosxYGEWVQc5hUiXu62T5JFb1HOlDQRu5aNXQLGSp1g5LJeC3h1pi6QBu28OlHMwaBoaBT8NljxxdzzrLd4TCl1/w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=+XR3LTOt/2W6NSg8Z8xkfFmcz8BR0yTrJbA4p1J5W6w=;
 b=ZsEZoYkAcP8w6wXtA0AO0l31KvSW1VWkgYAV1nDHfyMwz1J+urX0uHX5lFg7wgXLIRV7GUTHv/RoWuCurZcQgb8/kwHC0yGatM11A4VYqqfTvM3E1OtzuCi6abotx8uRYcZUIh4OacPSTIIN5mNikkWsqZuLxsdgAyiEZfGjmP5rXf31LkJ0HKIs5wsI3hXfgBXTQ+4fu7FAvxiQlGxJ9ejbDUoZgA/EY3wtdhbiD91NYvf4zwXJtW4mRkKXKkp6CdYplixvqBRExa6j8cYlO8euqQzcUCuLVzMHJqiwJarmXHYs0tWAeziUB1pK6KU8sfiAog7rKm7iCw8qgMjZrw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com;
 dkim=pass header.d=oracle.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=+XR3LTOt/2W6NSg8Z8xkfFmcz8BR0yTrJbA4p1J5W6w=;
 b=ZCutfKV1MUPwDbBfTeCFkqs7mtNmSZCp2kQo517QGJeUQrfzGvnHm1vlIv3xw0o6699bfkczRJwISlWPpexd24OFo6yq9tgxu1+/cDUzcqAPr19+Z/OFt5WQlFLJVbM8YiBsZL6yf2lE2mw88J0MLTd66FoEs8yXp5S9NkVYzu4=
Authentication-Results: gmx.de; dkim=none (message not signed)
 header.d=none;gmx.de; dmarc=none action=none header.from=oracle.com;
Date: Tue, 19 Oct 2021 15:55:56 -0400
From: Alec Brown <alec.r.brown@oracle.com>
To: Heinrich Schuchardt <xypron.glpk@gmx.de>
Cc: "coreboot@coreboot.org" <coreboot@coreboot.org>,
        "grub-devel@gnu.org" <grub-devel@gnu.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "systemd-devel@lists.freedesktop.org" <systemd-devel@lists.freedesktop.org>,
        "trenchboot-devel@googlegroups.com" <trenchboot-devel@googlegroups.com>,
        "u-boot@lists.denx.de" <u-boot@lists.denx.de>,
        "x86@kernel.org" <x86@kernel.org>,
        "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        Aleksandr Burmashev <alexander.burmashev@oracle.com>,
        "allen.cryptic@gmail.com" <allen.cryptic@gmail.com>,
        "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
        "andy.shevchenko@gmail.com" <andy.shevchenko@gmail.com>,
        "ardb@kernel.org" <ardb@kernel.org>,
        "btrotter@gmail.com" <btrotter@gmail.com>,
        Daniel Kiper <daniel.kiper@oracle.com>,
        "dpsmith@apertussolutions.com" <dpsmith@apertussolutions.com>,
        Eric DeVolder <eric.devolder@oracle.com>,
        Eric Snowberg <eric.snowberg@oracle.com>,
        "frowand.list@gmail.com" <frowand.list@gmail.com>,
        "hpa@zytor.com" <hpa@zytor.com>,
        "hun@n-dimensional.de" <hun@n-dimensional.de>,
        "james.dutton@gmail.com" <james.dutton@gmail.com>,
        "javierm@redhat.com" <javierm@redhat.com>,
        Joao Martins <joao.m.martins@oracle.com>,
        "jwerner@chromium.org" <jwerner@chromium.org>,
        Kanth Ghatraju <kanth.ghatraju@oracle.com>,
        Konrad Wilk <konrad.wilk@oracle.com>,
        "krystian.hebel@3mdeb.com" <krystian.hebel@3mdeb.com>,
        "leif@nuviainc.com" <leif@nuviainc.com>,
        "lukasz.hawrylko@intel.com" <lukasz.hawrylko@intel.com>,
        "luto@amacapital.net" <luto@amacapital.net>,
        "michal.zygowski@3mdeb.com" <michal.zygowski@3mdeb.com>,
        "mjg59@google.com" <mjg59@google.com>,
        "mtottenh@akamai.com" <mtottenh@akamai.com>,
        "nico.h@gmx.de" <nico.h@gmx.de>,
        "phcoder@gmail.com" <phcoder@gmail.com>,
        "piotr.krol@3mdeb.com" <piotr.krol@3mdeb.com>,
        "pjones@redhat.com" <pjones@redhat.com>,
        "pmenzel@molgen.mpg.de" <pmenzel@molgen.mpg.de>,
        "rasmus.villemoes@prevas.dk" <rasmus.villemoes@prevas.dk>,
        "rdunlap@infradead.org" <rdunlap@infradead.org>,
        "roger.pau@citrix.com" <roger.pau@citrix.com>,
        Ross Philipson <ross.philipson@oracle.com>,
        "sjg@chromium.org" <sjg@chromium.org>,
        "trini@konsulko.com" <trini@konsulko.com>,
        "tyhicks@linux.microsoft.com" <tyhicks@linux.microsoft.com>,
        "ulrich.windl@rz.uni-regensburg.de" <ulrich.windl@rz.uni-regensburg.de>,
        "wvervoorn@eltan.com" <wvervoorn@eltan.com>,
        "rharwood@redhat.com" <rharwood@redhat.com>
Subject: Re: [SPECIFICATION RFC v3] The firmware and bootloader log
 specification
Message-ID: <YW8izCvup7gKiKGc@alec-orcl>
References: <DM6PR10MB2986A960E859A744FDC3875ABCDE9@DM6PR10MB2986.namprd10.prod.outlook.com>
 <A7F710D3-5148-4E92-9E3D-5D850AD0245F@gmx.de>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <A7F710D3-5148-4E92-9E3D-5D850AD0245F@gmx.de>
X-ClientProxiedBy: MN2PR17CA0009.namprd17.prod.outlook.com
 (2603:10b6:208:15e::22) To DM6PR10MB2986.namprd10.prod.outlook.com
 (2603:10b6:5:6b::26)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 7843de07-0e2f-44cf-44e4-08d9933a798d
X-MS-TrafficTypeDiagnostic: DM5PR1001MB2396:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: 
	<DM5PR1001MB23963AA636AFF93D4852C44ABCBD9@DM5PR1001MB2396.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 
	EbaiNoifvw7ECI9qx7Uu3gK1oc4d7yHlrysDNpLEEzdnr96/HbrzqJeKGjgHyV/1MZ/OIeARxdS2t3uxUhmc1FABkL/SKnc2SasInLgxprbwo8vTtvz5VeYqKBUDHJJSCU+lmrdaBrPzXxOL57Ia7HUx84yQp/Cb1RyGb66ljG7sJrDgje+q7CIdo5h5ySPNM/FyUZPc8agwIuV+A3UnE3H6um6fQ9AKolfGglqJ6yUgycx0af8fWp0bvFMu3mQ2+YPf9l2yGh0DMGwKpDhLKDOw1+kvSM8N7Lp0wUS+epan+2VlLmFtRQ2E1g1avjDCI1WJQcIRXrvt5gSW89HH1unqtTiMz43RQSnRkZQdggwdjYZW76oUqvgyRqKtj55Wq7ehpuSpDjjRPEYvQtIAVZAr4rVTAGVYsDorYDM301Wvrc7W5NdS3TP9QXHpk/6rRBzLZDSm86O9b7cDQ+kbJpIC5x7QZ9KFj0o0sKuMbWDLbjvzG8gzKQ3MkpfbBvy8CNFTmbOjaUqcUKYrZOxSemznmeBr3eqKZ60vTxgHQSLWesaiKZlsT0a8lH+RjY9TogGBTThaFqxAkdF7KVvjaCrDyXxcOYVD7tP6Xg25Wj4iu/PJGLLeOzB2HtKd4SvQeHQxjINjl/kgJXrQj7BT66zcFWkCn9+nwysM7tfC3RzahUQn8w/8tH0F2/w20fas1buYeoRPTbFCFqw1gLxsd7H3kaD+tykPSf4gfsa9SnySeQMS1zrXa9bAJjPKSgY/fcA7Q9E/SSOQnHa/FDYVkg==
X-Forefront-Antispam-Report: 
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR10MB2986.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(33716001)(7416002)(5660300002)(86362001)(8676002)(4326008)(7406005)(9686003)(26005)(55016002)(66946007)(966005)(2906002)(83380400001)(66476007)(66556008)(316002)(38100700002)(508600001)(54906003)(6496006)(956004)(186003)(8936002)(6916009);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?MyEAvdH5fdrP1X6Vto4tc/tRdtK9Lgup0fAo1bPDBAMlbjkKRjEr78UaD3C+?=
 =?us-ascii?Q?DM3fRPCnlEK6cLW7ZbSexY3WcDcEla+KWmTenxnDCY+OwEyv+DJ0xbKPotmA?=
 =?us-ascii?Q?I2pg4mhi7m4Mq1qtmLxJqncJfSLruFv0YHHZqvcue2YdzjTbb2p8Jnk+nKau?=
 =?us-ascii?Q?RDM3rTz5wFlKNa+VZB6/CZ7/j2HJg1pFoeiXeLqMlPFuK3z3aJ5EshmJBCXB?=
 =?us-ascii?Q?inlSIQBL0wjzwJnFDvaOmzvIcSGdmIj2//hx+7yL1Ac9KVsnTOKdnocCqBdz?=
 =?us-ascii?Q?4838bDxTvQFzIVlBBaWOcI09gSIRu/NcPVo6B/uXrHqsgG/Kljt2EJ+eevqy?=
 =?us-ascii?Q?X7arumQeTPp1/uQDgkdYcAnulHHxkIy6RATLOAxYCc2Eszn5hhoYzzzc4jB3?=
 =?us-ascii?Q?tr3dscKwlFyGxmokh3zzfkqrFYdAVEjPkzotLvxSiJrHEeElXOk6o54S/gj2?=
 =?us-ascii?Q?bD0RekrBZZkf/H2hjAS4NgSTSDMZ5dZwKG2DqIDS+qBCdECnf/V7aeMQrMLm?=
 =?us-ascii?Q?IVBIUG7Qd5buNZTJIYHtTuOPqAp2VW/kefv0udrPPRov4I2wRCRY8v9srQCK?=
 =?us-ascii?Q?aeSJHSBYrPnKIKynqmmfMmrhZG2mT3k8h8XXz4UsKkDryL1bA3SrNghSL+5L?=
 =?us-ascii?Q?Kiye5Gcr11mfDqsfy0fP7iga5le+y4CBLPcgyaUhRyQVpYrgL49sXTSbFfIX?=
 =?us-ascii?Q?CaYyxRh/UYkZVH5L0PBEFrOeDz7tI79wyrsA7X0WvAAdi37no2gcTS3Lsa7x?=
 =?us-ascii?Q?eoP4KYR27bFzafZvTFoToRpjduyyyNGvdd7pHGyExByyuxUCATro9Sm8zlnx?=
 =?us-ascii?Q?9lC94lGMUvAxY08bWnSckVrQw00V+F4py5KePJHa0POfqRPnkJlukMRLqS19?=
 =?us-ascii?Q?NbYIDmRKl7dzQemypqrZEdusoBMkqrB2A3PggQ1+EGXa4Ydls5+1MXVz7SEb?=
 =?us-ascii?Q?khTszj6rGrIEC/hQdHpSSEIqxcj940QBhI0mhyZMhBfrMQJ8UIDDGUeGS3O/?=
 =?us-ascii?Q?HcteVMiOVHgwJ5qrwYl7nAz/0kzi4oUxuyf+0w5rT6iaugGmcNCD40zMNpvL?=
 =?us-ascii?Q?il6k0lTtfk/QX49TB5O7X3e//tYqeCrlDtWaME1ln+42D3adeoTydUnSnJwv?=
 =?us-ascii?Q?t5xvk4OvwL4ZsbGloSQNxuKl3wPTuO2ljXiAy/BjJSUiiD9Xjxb3iNQc1vVL?=
 =?us-ascii?Q?ltBoyzgd3UIzAwi1BgHyr3fQHoO61/WAENodPjbLv23XuF/XfnzoAQZhLMxh?=
 =?us-ascii?Q?KHdevEFa/XI87m7zjqAiwIzN/BaUK8JXo5xI1HTl7/QtF1tWdRSJCdm1aYxB?=
 =?us-ascii?Q?nXuLIR73eZA3ccQuK2b8y9iw?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7843de07-0e2f-44cf-44e4-08d9933a798d
X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB2986.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2021 19:56:00.8931
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: alec.r.brown@oracle.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR1001MB2396
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10142 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 mlxscore=0 adultscore=0
 spamscore=0 phishscore=0 bulkscore=0 suspectscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109230001
 definitions=main-2110190114
X-Proofpoint-GUID: etKxljiA5g1qGrbHSJYzOMBhTxHuyrIR
X-Proofpoint-ORIG-GUID: etKxljiA5g1qGrbHSJYzOMBhTxHuyrIR


On Sun, Sep 19, 2021 at 12:53:35AM +0200, Heinrich Schuchardt wrote:
> 
> 
> Am 18. September 2021 18:04:13 MESZ schrieb Alec Brown <alec.r.brown@oracle.com>:
> >Hi everyone,
> >
> >I've been working on improving the specification for the firmware and bootloader
> >log that Daniel Kiper has proposed and take into account most of the suggestions
> >that were made in these threads [1], [2].
> >
> >The goal is to allow various boot components to pass logs to the running OS and
> >then to the user space for processing and analysis. These logs should be generic
> >enough so that it can work in multiple environments and be human readable.
> 
> Hello Alec,
> 
> in your mail it remains unclear which information you want to put into the log and why it is needed. I would prefer the motivation and content to be clarified before defining any interface structures.
> 
> We already the EFI_TCG2_PROTOCOL and RFC 5424 (The syslog protocol). Why do we need to start from scratch?
> 
> Best regards
> 
> Heinrich 

Hi Heinrich,

The motivation behind developing these logs was to allow TrenchBoot to be able
to view how the platform was setup during boot. We intend for our specification
to target the Bootloader and Firmware and collect logs from them, but not TPM
event logs, which is what the EFI_TCG2_PROTOCOL collects. We plan on using our
specification for the GRUB Bootloader since it will be more efficient and
flexible to use than the syslog protocol. However, if other boot components
want to use a different logging format, our bf_log_header allows them to do so.

Alec Brown

> 
> >
> >It has yet to be decided where to put the final version of this specification.
> >It should be merged into an existing specification, e.g. UEFI, ACPI, Multiboot2,
> >or be standalone, such as a part of OASIS Standards.
> >
> >Below is how the layout of these logs would store their data.
> >
> >bf_log_header:
> >               +-------------------+
> >u32            | version           |
> >u32            | size              |
> >u8[64]         | producer          |
> >u8[64]         | log_format        |
> >u64            | flags             |
> >u64            | next_bflh_addr    |
> >u64            | log_addr          |
> >u32            | log_size          |
> >               +-------------------+
> >
> >bf_log_buffer:
> >               +-------------------+
> >u32            | version           |
> >u32            | size              |
> >u8[64]         | producer          |
> >u32            | next_msg_off      |
> >bf_log_msg[l]  | msgs              |
> >               +-------------------+
> >
> >bf_log_msg:
> >               +-------------------+
> >u32            | size              |
> >u64            | ts_nsec           |
> >u32            | level             |
> >u32            | facility          |
> >u32            | msg_off           |
> >u8[n]          | type              |
> >u8[m]          | msg               |
> >               +-------------------+
> >
> >Where l is the number of msgs, n is the size of type, and m is the size of the
> >msg.
> >
> >The bf_log_header structure forms a linked list. Each bf_log_header element in
> >the linked list points to the individual log buffer and the next bf_log_header
> >element in the linked list. The first element in the linked list points to the
> >last boot component in the boot chain. The last element points to the starting
> >boot component in the boot chain. The log buffers which contain the log
> >messages are produced by the various boot components, typically from the
> >firmware to the bootloader. The log message is stored in a log format that is
> >compatible with the boot component that produced it.
> >
> >The fields in bf_log_header structure:
> >  - version: the firmware and bootloader log header version number, 1 for now,
> >  - size: the size of the bf_log_header to allow for backward compatibility if 
> >    other fields are added,
> >  - producer: the producer/firmware/bootloader/... entity, NUL terminated
> >    string, e.g. GRUB, Coreboot; the length allows for ASCII UUID storage,
> >  - log_format: the format used to record the log messages, NUL terminated
> >    string, e.g. bf_log_msg, cbmem_cons, etc.; various producers may generate
> >    logs in various formats if needed,
> >  - flags: bit field used to store information about the log state, if bit 0 has
> >    been set it means the log was truncated,
> >  - next_bflh_addr: the physical address of the next bf_log_header structure,
> >    none if zero,
> >  - log_addr: the physical address of where the log buffer is stored,
> >  - log_size: the total size of the log buffer.
> >
> >The bf_log_buffer is used to store log messages from the firmware and
> >bootloader. This format for storing messages is called the bf log format. The
> >bf_log_buffer contains the header information of the bf log format with the log
> >messages being stored in an array of bf_log_msg messages.
> >
> >The fields in bf_log_buffer structure:
> >  - version: the firmware and bootloader log version number, 1 for now,
> >  - size: the total allocated space for the bf_log_buffer including the log
> >    messages stored in msgs,
> >  - producer: the producer/firmware/bootloader/... entity, NUL terminated
> >    string, e.g. GRUB, Coreboot; the length allows for ASCII UUID storage; same
> >    as the field in bf_log_header,
> >  - next_msg_off: the byte offset from the beginning of the allocated space for
> >    bf_log_buffer to the next byte after the last bf_log_msg in msgs,
> >  - msgs: the array of log messages stored in the bf_log_msg structures.
> >
> >The fields in bf_log_msg structure:
> >  - size: the total size of the bf_log_msg entry,
> >  - ts_nsec: the timestamp in nanoseconds starting from 0 (zero); the producer
> >    using this log format defines the meaning of 0,
> >  - level: similar to the syslog meaning; used to differentiate normal log
> >    messages from debug log messages, but the exact interpretation depends on
> >    the producer,
> >  - facility: similar to the syslog meaning; used to differentiate the sources
> >    of the log messages, but the exact interpretation depends on the producer,
> >  - msg_off: the byte offset which the msg field starts in bf_log_msg,
> >  - type: the log message type; similar to facility but NUL terminated string
> >    instead of integer, but the exact interpretation depends on the producer,
> >  - msg: the log message, NUL terminated string.
> >
> >In bf_log_msg, the producers are free to use or ignore any of the level,
> >facility, and type fields. If level or facility are ignored, they should be set
> >to 0. If type is ignored, it should be set to an empty NUL terminated string.
> >
> >Since it doesn't seem possible to have each boot component using the same log
> >format, we added a log_format and log_phys_addr fields to give flexibility in
> >how logs are stored. An example of a different log format that can be used is
> >the cbmem_console log format used by coreboot:
> >
> >cbmem_console:
> >               +-------------------+
> >u32            | size              |
> >u32            | cursor            |
> >u8[m]          | body              |
> >               +-------------------+
> >
> >There is still the outstanding issue of how the logs will be sent to the OS. If
> >UEFI is used, we can use config tables. If ACPI or Device Tree is used, we can
> >use bf_log_header.next_bflh_addr to present the logs. If none of these platforms
> >are used, it becomes a lot trickier to solve this issue.
> >
> >Any suggestions are much appreciated and will be taken into consideration.
> >
> >I will be presenting this work at the LPC System Boot and Security
> >Micro-conference on the 22nd of September at 7:50 AM PDT (14:50 UTC). Come and
> >join if you want to discuss the design. The schedule for the System Boot and
> >Security Micro-conference can be found here [3].
> >
> >Thanks!
> >Alec Brown
> >
> >[1] https://lists.gnu.org/archive/html/grub-devel/2020-11/msg00100.html
> >[2] https://lists.gnu.org/archive/html/grub-devel/2020-12/msg00021.html
> >[3] https://linuxplumbersconf.org/event/11/sessions/116/#20210922


From xen-devel-bounces@lists.xenproject.org Tue Oct 19 19:57:37 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Oct 2021 19:57:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.213436.371643 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcvEv-00076C-9p; Tue, 19 Oct 2021 19:57:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 213436.371643; Tue, 19 Oct 2021 19:57:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcvEv-000765-6p; Tue, 19 Oct 2021 19:57:37 +0000
Received: by outflank-mailman (input) for mailman id 213436;
 Tue, 19 Oct 2021 19:57:35 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=YfyF=PH=oracle.com=alec.r.brown@srs-us1.protection.inumbo.net>)
 id 1mcvEt-00075f-M5
 for xen-devel@lists.xenproject.org; Tue, 19 Oct 2021 19:57:35 +0000
Received: from mx0b-00069f02.pphosted.com (unknown [205.220.177.32])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id cd43e470-3116-11ec-8324-12813bfff9fa;
 Tue, 19 Oct 2021 19:57:34 +0000 (UTC)
Received: from pps.filterd (m0246630.ppops.net [127.0.0.1])
 by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 19JJ2aBx027760; 
 Tue, 19 Oct 2021 19:57:06 GMT
Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71])
 by mx0b-00069f02.pphosted.com with ESMTP id 3bsn7kn01j-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Tue, 19 Oct 2021 19:57:05 +0000
Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1])
 by aserp3030.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 19JJon74079452;
 Tue, 19 Oct 2021 19:57:00 GMT
Received: from nam12-bn8-obe.outbound.protection.outlook.com
 (mail-bn8nam12lp2173.outbound.protection.outlook.com [104.47.55.173])
 by aserp3030.oracle.com with ESMTP id 3bqmsfb4hm-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Tue, 19 Oct 2021 19:57:00 +0000
Received: from DM6PR10MB2986.namprd10.prod.outlook.com (2603:10b6:5:6b::26) by
 DM5PR1001MB2396.namprd10.prod.outlook.com (2603:10b6:4:30::29) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.18; Tue, 19 Oct 2021 19:56:57 +0000
Received: from DM6PR10MB2986.namprd10.prod.outlook.com
 ([fe80::c5da:305e:be30:abac]) by DM6PR10MB2986.namprd10.prod.outlook.com
 ([fe80::c5da:305e:be30:abac%3]) with mapi id 15.20.4608.018; Tue, 19 Oct 2021
 19:56:57 +0000
Received: from alec-orcl (73.61.222.52) by
 BL1PR13CA0263.namprd13.prod.outlook.com (2603:10b6:208:2ba::28) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.8 via Frontend
 Transport; Tue, 19 Oct 2021 19:56:55 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: cd43e470-3116-11ec-8324-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc
 : subject : message-id : references : content-type : in-reply-to :
 mime-version; s=corp-2021-07-09;
 bh=Vm/clMDIfA9tEYzCoD6o89gy6g31+Yrx4MGs463p+uU=;
 b=ZbYPtLFy9Wzci3PLK9LZhZ6JHgBFRQ2ADvRNNrp6HLwQi75AiPzSvVxN9xCBP7l4VmMc
 6e38j2xRYH2dXbnVj0GXlYlBAL52edmES50kvvGzHwOolWOLIob/9ESW6O662DSiw1rw
 TQbRLagKNoZMxAvnJ8tXtNgGY9K9bgNqtyibjXmo/Pk5tewPQa9IRGiBuiDi1cIYkvqV
 s4KRQFpAB0NIbI8bbki4nvpJBAsa9e8VYJaNPfRzLsubRkGMihdX7sdCiDK2+E5+2ZPr
 2TR5pURAa42/HPmjBq4Qx2e7xOmG+yH6FlOhAUTno6D68FpzynQTXMZwtQaziK0gMy80 CA== 
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=exlb7lPIRdcuO1Jimpq3h+wSHXNwRYP/5fksNBKa4yg75hJJZD7SeEB52BiVb9pqI0vzsARCVIqhyavV9APAMM5d/3JdUuFJyYir+SICchekgC+PefEMvAcwt+IeyCQDm2aiGiuueywUVsC5tH5U/+eHf0xCAtwKf5PrvcSqblyHy52LM/bT+jV3mREs1l6o3iaQffe6YCKGVzKywkocjQEgDaR6gCM1FWVWTfJfMYVKVARX4gotRxCUPb7vdfi0HCBLoftj4LC+EPUcVwdVoPmjc3//0OJuthJOiF8wcewfzQ5sIIEVekPVuMa02ik3zY09DIhNwHfGepE0TfV5hQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Vm/clMDIfA9tEYzCoD6o89gy6g31+Yrx4MGs463p+uU=;
 b=XTZaveQfOKXoLA+Czm3GAm/Qkpb476O4K1yqvSzvC4UrC/lcAAXqNQ92789RGtaG0MdwSWRdTpFlqTRZn5hoHAO9kflsP+saVdBfGa+7Yz8LplXgfUEDvwzqquEe5gNWsLsvwRBQT3jN7sgFBmdfRyS8j3+tO3mIDIW90PF55XT83XeRE3Me7fUP6IsqXlpfbqbV6bPL8ZFPXo26V/A/+kt3pbkYi7TkWAX/igOTXAclZ2YW+L/C3bhS2IBN7EXR4ap7wiWIrGyQrxEpiXtpK5Ew0REtLVoWDOUa9aHCoetrWP4/Hp1oQ7CknM3DqT43pdo6zkpYL2nwGUnWx4uRHA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com;
 dkim=pass header.d=oracle.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Vm/clMDIfA9tEYzCoD6o89gy6g31+Yrx4MGs463p+uU=;
 b=q1ifXfZbNIhe63TI1M8Sdw60oGPNIL4sWIiv/74M+g/FrraTo3Npy5EkROD8fYzlA0KcWf7raZLIuoK7SgxhBmqqLB/vq7jMv8B0SrBw8lF0z9zlULeQlcs3cpCu4p5ODCzEOAH2UieOSa4hOsvhEqJIyWHbERJk8CDlQt/HGTk=
Authentication-Results: stuge.se; dkim=none (message not signed)
 header.d=none;stuge.se; dmarc=none action=none header.from=oracle.com;
Date: Tue, 19 Oct 2021 15:56:52 -0400
From: Alec Brown <alec.r.brown@oracle.com>
To: Peter Stuge <peter@stuge.se>
Cc: Heinrich Schuchardt <xypron.glpk@gmx.de>,
        "coreboot@coreboot.org" <coreboot@coreboot.org>,
        "grub-devel@gnu.org" <grub-devel@gnu.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "systemd-devel@lists.freedesktop.org" <systemd-devel@lists.freedesktop.org>,
        "trenchboot-devel@googlegroups.com" <trenchboot-devel@googlegroups.com>,
        "u-boot@lists.denx.de" <u-boot@lists.denx.de>,
        "x86@kernel.org" <x86@kernel.org>,
        "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        Aleksandr Burmashev <alexander.burmashev@oracle.com>,
        "allen.cryptic@gmail.com" <allen.cryptic@gmail.com>,
        "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
        "andy.shevchenko@gmail.com" <andy.shevchenko@gmail.com>,
        "ardb@kernel.org" <ardb@kernel.org>,
        "btrotter@gmail.com" <btrotter@gmail.com>,
        Daniel Kiper <daniel.kiper@oracle.com>,
        "dpsmith@apertussolutions.com" <dpsmith@apertussolutions.com>,
        Eric DeVolder <eric.devolder@oracle.com>,
        Eric Snowberg <eric.snowberg@oracle.com>,
        "frowand.list@gmail.com" <frowand.list@gmail.com>,
        "hpa@zytor.com" <hpa@zytor.com>,
        "hun@n-dimensional.de" <hun@n-dimensional.de>,
        "james.dutton@gmail.com" <james.dutton@gmail.com>,
        "javierm@redhat.com" <javierm@redhat.com>,
        Joao Martins <joao.m.martins@oracle.com>,
        "jwerner@chromium.org" <jwerner@chromium.org>,
        Kanth Ghatraju <kanth.ghatraju@oracle.com>,
        Konrad Wilk <konrad.wilk@oracle.com>,
        "krystian.hebel@3mdeb.com" <krystian.hebel@3mdeb.com>,
        "leif@nuviainc.co m" <leif@nuviainc.com>,
        "lukasz.hawrylko@intel.com" <lukasz.hawrylko@intel.com>,
        "luto@amacapital.net" <luto@amacapital.net>,
        "michal.zygowski@3mdeb.com" <michal.zygowski@3mdeb.com>,
        "mjg59@google.com" <mjg59@google.com>,
        "mtottenh@akamai.com" <mtottenh@akamai.com>,
        "phcoder@gmail.com" <phcoder@gmail.com>,
        "piotr.krol@3mdeb.com" <piotr.krol@3mdeb.com>,
        "pjones@redhat.com" <pjones@redhat.com>,
        "pmenzel@molgen.mpg.de" <pmenzel@molgen.mpg.de>,
        "rasmus.villemoes@prevas.dk" <rasmus.villemoes@prevas.dk>,
        "rdunlap@infradead.org" <rdunlap@infradead.org>,
        "roger.pau@citrix.com" <roger.pau@citrix.com>,
        Ross Philipson <ross.philipson@oracle.com>,
        "sjg@chromium.org" <sjg@chromium.org>,
        "trini@konsulko.com" <trini@konsulko.com>,
        "tyhicks@linux.microsoft.com" <tyhicks@linux.microsoft.com>,
        "ulrich.windl@rz.uni-regensburg.de" <ulrich.windl@rz.uni-regensburg.de>,
        "wvervoorn@eltan.com" <wvervoorn@eltan.com>,
        "rharwood@redhat.com" <rharwood@redhat.com>
Subject: Re: [External] : Re: [SPECIFICATION RFC v3] The firmware and
 bootloader log specification
Message-ID: <YW8jBOYbFFeYVtDW@alec-orcl>
References: <A7F710D3-5148-4E92-9E3D-5D850AD0245F@gmx.de>
 <DM6PR10MB2986A960E859A744FDC3875ABCDE9@DM6PR10MB2986.namprd10.prod.outlook.com>
 <20210921154021.19289.qmail@stuge.se>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210921154021.19289.qmail@stuge.se>
X-ClientProxiedBy: BL1PR13CA0263.namprd13.prod.outlook.com
 (2603:10b6:208:2ba::28) To DM6PR10MB2986.namprd10.prod.outlook.com
 (2603:10b6:5:6b::26)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 91fd845a-7531-45cb-7c32-08d9933a9b64
X-MS-TrafficTypeDiagnostic: DM5PR1001MB2396:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: 
	<DM5PR1001MB2396CC2BDF8EFDF8B7552B91BCBD9@DM5PR1001MB2396.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 
	s4yM0CZL5/N5SdOCySU8DTZZim48QHgV7bELzZjxwRoVix60or/iy5vz1tONVcoEc4JHSYn4FQZj06WlDwBXevWwrp6P50rnfOIAIwZc8qnWjVFV7vg9HXZUj3O11VdgiqRWzwXP1w16QS2WZb2eV7aGonpBz4dqMHBkBEYgFPcF9JNSSotxokly4e3q/OFA3zExwgZiOrJUPZ/LuQE8DK7assqKSs/Jhe1s0IsHHJrvzd87nHM/Q2jYDApTW5XtiZ7zQNZkPTaHcHelGuF/wI3t7sW/IO/4BA0NmO/Pg2lajJ2ymmfljN5eppGYJO79qR3O7N6dqJHVKZmu3DRvSPDEHY0HLOPLz1v2lFzsKWv0QtnzYwQ6jZzqRgaU0Erj3HOe2bAl0DW6sdEMWNtL7BOhGzAAw8Y910UhbAgV5wtF2ArfKYnpVnO4ADK0MuTe02BFHm7niADpHSJ7HbK428xKKiuYDTBSDTvqZXQuYpFJl5D9m97US3xUBORpsw5DQRwYeErhMUTPRTQ0srCNnZDXYa3SF9lqof1j8hzUKyn3KF9U5W8zwco1kii6mERMorX6lENp4KCFtM2sP5CSVLB1E4dq7irw3Aow3jSbGgxgltZEiQ65SpEgoFxzc6dA573FD5TDi/cofwa8y0Grwg==
X-Forefront-Antispam-Report: 
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR10MB2986.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(33716001)(7416002)(5660300002)(86362001)(8676002)(4326008)(7406005)(9686003)(26005)(55016002)(66946007)(2906002)(6666004)(83380400001)(66476007)(66556008)(316002)(38100700002)(508600001)(54906003)(6496006)(956004)(186003)(8936002)(6916009);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?yQ2lUxqfMcz3alIdGc8m/9fg9zKxgxv9rpp1/A9bPOM29xWJRjG4kIeyxMpu?=
 =?us-ascii?Q?/CsQkcF9ySq48R0Hpj5EReC2hTuh/ml3MNpbv0BwEPFPFhp42rtGQVvR+O8z?=
 =?us-ascii?Q?Q5q//UCgpnCGoJDthWt0mRihcdE1TZ1VZs7eFNuemurzytdRf7WI1m3JZPJj?=
 =?us-ascii?Q?1xgoPjlCnH1SimNcX/RxSucAC+AeGA0oDKSoMef8+fGS2WuuFbsIc9gpjI3u?=
 =?us-ascii?Q?q9+wsK+HLXhsQYa+KjXVDee/f/Fccs1WTXUy04j7be2pMT8HgpBrVS9pbcYS?=
 =?us-ascii?Q?MIrK6utCfP3kY+s1J9D8UUMiZu/HLSqibpUeZk8vyfzVYef+CaYvdmODwBo9?=
 =?us-ascii?Q?flUfaRRydG2armgsddS/n6iCn9WYJAU8+GhNP03kXaUzp1MGb2nGNES8dryc?=
 =?us-ascii?Q?EgXXV2v9VBJpP5vRFz56dJs4DiJ77xit1FmI3Kfdl/2OCarKoHi1fB4VHMvY?=
 =?us-ascii?Q?KHGcmJ1TY2JVBq7cadDmX+rdi948R78CmVs/Xm513qtYH9BQbMqxWo3t3d/U?=
 =?us-ascii?Q?zIG8kAC29/Vq4KuqT/KO0v3Gw0IH8uCwGCyWjca4wXGzVCBC+AJCcHUyQD8P?=
 =?us-ascii?Q?zOuccXCI4Tvb+PGvzWDvA0IxI3NI14S0hqlZyvQq48XXtd5t17xtH7DlPeju?=
 =?us-ascii?Q?7DXDMMFHysjP9YzQ+MhsMP8/WgFjy8Pw4zgYOODjGpXelS6VcI7dlQLNi6qb?=
 =?us-ascii?Q?7q6leyk4cPTsFTIiPkjWXkX9ncGjRPcNevSAJsEnbdhNZN3XWhhdjjP7Mnt7?=
 =?us-ascii?Q?ZOWqH1x+IGKA7iWBRgCkjMHy8Hu7W8nEk8B0lBHCfXoWVBO1QNxxUpnbTFNh?=
 =?us-ascii?Q?Y8P6vpcKNLq0Q0/2V+EyghHDk0sclRV5zWiVAxGHk+jJUZki6WDmJW2paHFQ?=
 =?us-ascii?Q?UiKZfYmGgBtIsrJbu8QS17WXtb9YusshU/aEXOv2Mx2ZHrc5bZC4Hty7B0dJ?=
 =?us-ascii?Q?lSBtO4dhS3CsYBXQ/VKGrGkOxtckCBM1zijVIbzdOmGT5XP/46KrWpsMF91t?=
 =?us-ascii?Q?+FrjCcH23MDd4spFAz68MlxA4ILLzqqLh2Zok2lP1wQSrj9Dx9d7F68TuouH?=
 =?us-ascii?Q?X15q3rRKk2n1ssPfa514iRQuQu1vFo1VwE/sYAUrFMTwSDxcOvW0AZVd/U3L?=
 =?us-ascii?Q?PKqqOqWIJuPiknKYuoo/s2v3xn7Jd+2XAe38bdni609+GJWObA9GxFkfoOhB?=
 =?us-ascii?Q?CtfrARTunFRriI8Pf2lpM4D1/oZxTAlhdPQxWb/oLRlHyj57KuNXyL18irCd?=
 =?us-ascii?Q?ht6PJhWkf7b2/1Hp9jHY+9Qr2ABUNao1P/MFJTVLClpH9qSZyfMx5baxdFmB?=
 =?us-ascii?Q?18xd19220lkaliOeP+Xx1Ezb?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 91fd845a-7531-45cb-7c32-08d9933a9b64
X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB2986.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2021 19:56:57.6454
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: alec.r.brown@oracle.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR1001MB2396
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10142 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 adultscore=0 malwarescore=0
 phishscore=0 mlxlogscore=999 bulkscore=0 suspectscore=0 mlxscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109230001
 definitions=main-2110190114
X-Proofpoint-ORIG-GUID: 8kaSmN8gTiMWgEgYmz3Fd0g8fjiB-dzy
X-Proofpoint-GUID: 8kaSmN8gTiMWgEgYmz3Fd0g8fjiB-dzy


On Tue, Sep 21, 2021 at 03:40:20PM +0000, Peter Stuge wrote:
> Alec Brown wrote:
> > Below is how the layout of these logs would store their data.
> > 
> > bf_log_header:
> >                +-------------------+
> > u32            | version           |
> > u32            | size              |
> > u8[64]         | producer          |
> > u8[64]         | log_format        |
> > u64            | flags             |
> > u64            | next_bflh_addr    |
> > u64            | log_addr          |
> > u32            | log_size          |
> >                +-------------------+
> 
> I suggest to include a .magic at least in bf_log_header and an
> .xor_checksum or .crc32 only in bf_log_header.
> 
> .magic doubles as endianess indicator when the structures are
> stored on movable media. (Pick an asymmetric magic bit pattern!)

This is something we will need to think about.

>  
> I suggest renaming .next_bflh_addr to .next_log_header and .log_addr
> to .log_buffer_addr.
> 
> I suggest to remove .size and .log_size:
> 
> The rationale for .size is "to allow for backward compatibility" but
> that seems redundant thanks to .version.
> 
> .log_size can be calculated from the subordinate data and is thus
> mostly an unneccessary source of potential inconsistency.

Looking back, I agree with removing .size since .version accomplishes the same
task. I'm not so sure on removing .log_size as it can be very convenient, and
.log_size won't need to be calculated every time someone wants to know the size
of the logs generated from the boot component.

> 
> 
> > bf_log_buffer:
> >                +-------------------+
> > u32            | version           |
> > u32            | size              |
> > u8[64]         | producer          |
> > u32            | next_msg_off      |
> > bf_log_msg[l]  | msgs              |
> >                +-------------------+
> 
> I suggest replacing .size and .next_msg_off with .messages containing l:
> 
> .size can then be calculated from .messages; again, reliably avoiding
> inconsistency between .size and .next_msg_off.
> 
> Allocated size doesn't seem useful if writers must anyway maintain state
> containing the starting address. If writers must be allowed to be completely
> stateless then maybe at least rename .size to .allocated_size and see below
> for discovery.
> 
> Having .messages also eliminates the need for an end-of-messages marker
> when the allocated space is not yet filled.
> 

After some thinking, it makes sense to replace the meaning of .size with the
meaning of .next_msg_off and removing .next_msg_off from the structure. This 
wouldn't be useful to store for the readers of the log.

> 
> > bf_log_msg:
> >                +-------------------+
> > u32            | size              |
> > u64            | ts_nsec           |
> > u32            | level             |
> > u32            | facility          |
> > u32            | msg_off           |
> > u8[n]          | type              |
> > u8[m]          | msg               |
> >                +-------------------+
> 
> It seems inconsistent that log_header.size and log_msg.size cover only
> the respective struct itself while log_buffer.size also covers all
> subordinate messages. Skipping all .size in this version fixes that.
> 
> And log_msg.size is not very useful since both .type and .msg have variable
> length; it's not possible to access .msg without scanning .type. Please at
> a minimum add .type_size but better yet replace .size with .type_size and
> .msg_size.
> 

You bring up some good points about the names for the fields and that they need
to be more consistent. By removing .size in bf_log_header, this should make it
more consistent.

> 
> > There is still the outstanding issue of how the logs will be sent to the OS. If
> > UEFI is used, we can use config tables. If ACPI or Device Tree is used, we can
> > use bf_log_header.next_bflh_addr to present the logs. If none of these platforms
> > are used, it becomes a lot trickier to solve this issue.
> > 
> > Any suggestions are much appreciated and will be taken into consideration.
> 
> Having bf_log_header.magic and some bf_log_header.$checksum, a strict rule
> for bf_log_header start address granularity and a strict maximum offset
> for the first header from top and/or bottom of memory allows to quickly
> discover a log in memory without explicit handover.
> 

This is something we'll have to think about some more. We aren't convinced about
using .magic for log discovery and are looking for a more explicit way of doing
this.

> 
> > LPC System Boot and Security Micro-conference on the 22nd of September
> > at 7:50 AM PDT (14:50 UTC).
> 
> Have fun! :)
> 
> 
> Heinrich Schuchardt wrote:
> > We already the EFI_TCG2_PROTOCOL and RFC 5424 (The syslog protocol).
> > Why do we need to start from scratch?
> 
> That's a good question. I guess noone wants to settle for a standard
> from somewhere else. ;)
> 
> I wouldn't mind if log_msg was a syslog transport, but I can understand
> if that's rejected because syslog messages require a lot of parsing for
> presentation while Alec's proposal seems focused on efficiency and simplicity.
> 
> It's also nice to be able to strictly mandate UTF-8 for all fields.
> (RFC 5424 allows MSG to be anything.)
> 
> 
> Kind regards
> 
> //Peter


From xen-devel-bounces@lists.xenproject.org Tue Oct 19 19:57:48 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Oct 2021 19:57:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.213439.371655 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcvF6-0007Yk-Nt; Tue, 19 Oct 2021 19:57:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 213439.371655; Tue, 19 Oct 2021 19:57:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcvF6-0007Yb-Jb; Tue, 19 Oct 2021 19:57:48 +0000
Received: by outflank-mailman (input) for mailman id 213439;
 Tue, 19 Oct 2021 19:57:47 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=9sDB=PH=kernel.org=helgaas@srs-us1.protection.inumbo.net>)
 id 1mcvF5-0007S6-9X
 for xen-devel@lists.xenproject.org; Tue, 19 Oct 2021 19:57:47 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 7a1d428a-1044-4f8f-8c69-922d6636461a;
 Tue, 19 Oct 2021 19:57:45 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id 457B9611AE;
 Tue, 19 Oct 2021 19:57:44 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7a1d428a-1044-4f8f-8c69-922d6636461a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1634673464;
	bh=pkMo2Sv7IK+wY1xa3uKP40G/Dt2Vp6/1qWdddvzz+zM=;
	h=Date:From:To:Cc:Subject:In-Reply-To:From;
	b=H+Dt6Y39I0XbmfVc5nEeyvorSyZfPiOb2DwO2J3yHXKkHAYKVVDSj/YOOzR7huBy2
	 Nfo8ZfkXcrfqt71bt5tyW29UcV2oG7OFMojYdggBox64/IZa7gmjInoc15dEuJRR69
	 4kzB+lD2J2BcN+Puwc93ZOo++PKTIfZvqPnbxilOc632TRhXIAn1FI5VJMfcpl8e8W
	 ChZc1Z6Sf0IMnuCeufqpNm42nRiX4it3u1oXb9yUYMl9rq+ykBruvU4hlu+PRmql+R
	 n8y7sSDEemfKfwu3i5j1bu1iXacZZTp6+Nq73zqj2bnl0nRH0Ah9eV9z5REwIXcT/W
	 AHuvpjfmxuUIQ==
Date: Tue, 19 Oct 2021 14:57:42 -0500
From: Bjorn Helgaas <helgaas@kernel.org>
To: Josef Johansson <josef@oderland.se>
Cc: Bjorn Helgaas <bhelgaas@google.com>, linux-pci@vger.kernel.org,
	xen-devel <xen-devel@lists.xenproject.org>,
	Jason Andryuk <jandryuk@gmail.com>,
	Thomas Gleixner <tglx@linutronix.de>, Marc Zyngier <maz@kernel.org>
Subject: Re: [PATCH] PCI/MSI: Re-add checks for skip masking MSI-X on Xen PV
Message-ID: <20211019195742.GA2394472@bhelgaas>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <859dbb71-098f-07f2-f063-4874ccc8523b@oderland.se>

[+cc Marc]

On Mon, Oct 18, 2021 at 08:22:32AM +0200, Josef Johansson wrote:
> From: Josef Johansson <josef@oderland.se>
> 
> 
> PCI/MSI: Re-add checks for skip masking MSI-X on Xen PV
>     
> 'commit fcacdfbef5a1 ("PCI/MSI: Provide a new set of mask and unmask
> functions")' introduced functions pci_msi_update_mask() and 
> pci_msix_write_vector_ctrl() that were missing checks for
> pci_msi_ignore_mask that existed in 'commit 446a98b19fd6 ("PCI/MSI: Use
> new mask/unmask functions")'. This patch adds them back since it was
> causing softlocks in amdgpu drivers under Xen.
> 
> As explained in 'commit 1a519dc7a73c ("PCI/MSI: Skip masking MSI-X
> on Xen PV")', when running as Xen PV guest, masking MSI-X is a 
> responsibility of the hypervisor.
> 
> Fixes: fcacdfbef5a1 ("PCI/MSI: Provide a new set of mask and unmask
> functions")
> Suggested-by: Jason Andryuk <jandryuk@gmail.com>
> Signed-off-by: Josef Johansson <josef@oderland.se>

fcacdfbef5a1 appeared in v5.15-rc1, and we should try to get this
fixed before v5.15.

I could merge it but would like an ack from Thomas since he wrote
fcacdfbef5a1.  He merged fcacdfbef5a1, so I wouldn't complain if the
fix followed the same path.

If I merged it (or if you were to repost it), I would drop the single
quotes around the commit citations and write the commit log in
imperative mood, as you did for the subject
(https://chris.beams.io/posts/git-commit/)

> ---
> 
> This patch solves a major issue with booting 5.15-rc1 under Xen
> with amdgpu drivers. Specifically Lenovo P14s Gen 1, AMD 4750U.
> 
> The softlock below takes about ~2-3 minutes to release, and will
> lock again if I switch between X and console, when staying in
> X I can do things without it softlock.

I don't actually see a softlock mentioned below; am I missing
something?  It's nice to include a couple lines of dmesg log to help
people connect the issue with the fix, but most of the below is not
relevant and can be easily found from the Link: tag.  Also, some of
the lines seem to be wrapped.  They're more useful when not wrapped
because grep can find them.

> I have to note that this is my first commit and PCI/MSI area is
> not my area of expertise. I tried to mimic what was
> obviously missing between the aforementioned commits. There may be
> better ways to solve this problem, or other places to put the checks.
> Should desc->msi_attrib.is_virtual be checked? It is not checked in
> 'commit 1a519dc7a73c ("PCI/MSI: Skip masking MSI-X on Xen PV")'
> 
> I should also note that my original problem with *flip done timeout*
> inside drm during suspend/resume is not solved, but with this patch
> at least the kernel boots properly.
> 
> The kernel is much more stable not running inside Xen, and much 
> more stable running pci=nomsi (under Xen). Are we missing something
> more regarding masking?

It does sound like something else is broken as well, but I have no
idea what that would be.

> The error that occurs is:
> 
> kernel: ------------[ cut here ]------------
> kernel: WARNING: CPU: 6 PID: 3754 at
> drivers/gpu/drm/amd/amdgpu/../display/amdgp
> u_dm/amdgpu_dm.c:8630 amdgpu_dm_commit_planes+0x9b4/0x9c0 [amdgpu]
> kernel: Modules linked in: nf_tables nfnetlink vfat fat intel_rapl_msr wmi_bmof
> intel_rapl_common pcspkr joydev uvcvideo k10temp sp5100_tco videobuf2_vmalloc vi
> deobuf2_memops i2c_piix4 videobuf2_v4l2 videobuf2_common videodev mc iwlwifi thi
> nkpad_acpi platform_profile ipmi_devintf ledtrig_audio ucsi_acpi cfg80211 ipmi_m
> sghandler r8169 snd typec_ucsi soundcore typec rfkill wmi video amd_pmc i2c_scmi
>  fuse xenfs ip_tables dm_thin_pool dm_persistent_data dm_bio_prison dm_crypt tru
> sted asn1_encoder hid_multitouch amdgpu crct10dif_pclmul iommu_v2 crc32_pclmul c
> rc32c_intel gpu_sched i2c_algo_bit drm_ttm_helper ttm drm_kms_helper ccp cec gha
> sh_clmulni_intel sdhci_pci xhci_pci xhci_pci_renesas serio_raw cqhci drm sdhci x
> hci_hcd mmc_core nvme ehci_pci ehci_hcd nvme_core xen_acpi_processor xen_privcmd
>  xen_pciback xen_blkback xen_gntalloc xen_gntdev xen_evtchn uinput
> kernel: CPU: 6 PID: 3754 Comm: Xorg Tainted: G   W 5.15.0-1.fc32.qubes.x86_64 #1
> kernel: Hardware name: LENOVO 20Y1S02400/20Y1S02400, BIOS R1BET61W(1.30) 12/21/
> 2020
> kernel: RIP: e030:amdgpu_dm_commit_planes+0x9b4/0x9c0 [amdgpu]
> kernel: Code: 8b 45 b0 48 c7 c7 4b fc 90 c0 4c 89 55 88 8b b0 f0 03 00 00 e8 6d
> cb ca ff 4c 8b 55 88 0f b6 55 ab 49 8b 72 08 e9 2b fa ff ff <0f> 0b e9 fa fe ff
> ff e8 40 2f 6e c1 0f 1f 44 00 00 55 b9 27 00 00
> kernel: RSP: e02b:ffffc90042d93638 EFLAGS: 00010002
> kernel: RAX: ffff888110840210 RBX: 00000000000083c1 RCX: 0000000000000466
> kernel: RDX: 0000000000000001 RSI: 0000000000000204 RDI: ffff888110840170
> kernel: RBP: ffffc90042d936f8 R08: 0000000000000002 R09: 0000000000000001
> kernel: R10: 0000000000000000 R11: ffff88810cb2e118 R12: ffff888110840210
> kernel: R13: ffff88810cb2e000 R14: ffff888103d50400 R15: ffff888103bb2c00
> kernel: FS:  0000718c6de4da40(0000) GS:ffff888140780000(0000)
> knlGS:000000000000
> 0000
> kernel: CS:  10000e030 DS: 0000 ES: 0000 CR0: 0000000080050033
> kernel: CR2: 0000726ada294000 CR3: 0000000103f0e000 CR4: 0000000000050660
> kernel: Call Trace:
> kernel:  amdgpu_dm_atomic_commit_tail+0xc3e/0x1360 [amdgpu]
> kernel:  commit_tail+0x94/0x130 [drm_kms_helper]
> kernel:  drm_atomic_helper_commit+0x113/0x140 [drm_kms_helper]
> kernel:  drm_client_modeset_commit_atomic+0x1fc/0x240 [drm]
> kernel:  drm_client_modeset_commit_locked+0x53/0x80 [drm]
> kernel:  drm_fb_helper_pan_display+0xdc/0x210 [drm_kms_helper]
> kernel:  fb_pan_display+0x83/0x100
> kernel:  fb_set_var+0x200/0x3b0
> kernel:  fbcon_blank+0x186/0x280
> kernel:  do_unblank_screen+0xaa/0x150
> kernel:  complete_change_console+0x54/0x120
> kernel:  vt_ioctl+0x31d/0x5f0
> kernel:  tty_ioctl+0x312/0x780
> kernel:  __x64_sys_ioctl+0x83/0xb0
> kernel:  do_syscall_64+0x3b/0x90
> kernel:  entry_SYSCALL_64_after_hwframe+0x44/0xae
> kernel: RIP: 0033:0x718c6e33217b
> kernel: Code: 0f 1e fa 48 8b 05 1d ad 0c 00 64 c7 00 26 00 00 00 48 c7 c0 ff ff
> ff ff c3 66 0f 1f 44 00 00 f3 0f 1e fa b8 10 00 00 00 0f 05 <48> 3d 01 f0 ff ff
> 73 01 c3 48 8b 0d ed ac 0c 00 f7 d8 64 89 01 48
> kernel: RSP: 002b:00007ffd5c6157c8 EFLAGS: 00000246 ORIG_RAX:
> 0000000000000010
> kernel: RAX: ffffffffffffffda RBX: 0000000000000001 RCX: 0000718c6e33217b
> kernel: RDX: 0000000000000001 RSI: 0000000000005605 RDI: 0000000000000014
> kernel: RBP: 000057b9b2aa93f4 R08: 0000000000000000 R09: 0000000000000001
> kernel: R10: fffffffffffff9ce R11: 0000000000000246 R12: 000057b9b2aa94b0
> kernel: R13: 000057b9b2aa94a0 R14: 000057b9b2aa93f0 R15: 00007ffd5c615844
> kernel: ---[ end trace 2c3e3998803422cb ]---
> kernel: ------------[ cut here ]------------
> kernel: WARNING: CPU: 6 PID: 3754 at
> drivers/gpu/drm/amd/amdgpu/../display/amdgp
> u_dm/amdgpu_dm.c:8217 prepare_flip_isr+0x64/0x70 [amdgpu]
> kernel: Modules linked in: nf_tables nfnetlink vfat fat intel_rapl_msr wmi_bmof
> intel_rapl_common pcspkr joydev uvcvideo k10temp sp5100_tco videobuf2_vmalloc vi
> deobuf2_memops i2c_piix4 videobuf2_v4l2 videobuf2_common videodev mc iwlwifi thi
> nkpad_acpi platform_profile ipmi_devintf ledtrig_audio ucsi_acpi cfg80211 ipmi_m
> sghandler r8169 snd typec_ucsi soundcore typec rfkill wmi video amd_pmc i2c_scmi
>  fuse xenfs ip_tables dm_thin_pool dm_persistent_data dm_bio_prison dm_crypt tru
> sted asn1_encoder hid_multitouch amdgpu crct10dif_pclmul iommu_v2 crc32_pclmul c
> rc32c_intel gpu_sched i2c_algo_bit drm_ttm_helper ttm drm_kms_helper ccp cec gha
> sh_clmulni_intel sdhci_pci xhci_pci xhci_pci_renesas serio_raw cqhci drm sdhci x
> hci_hcd mmc_core nvme ehci_pci ehci_hcd nvme_core xen_acpi_processor xen_privcmd
>  xen_pciback xen_blkback xen_gntalloc xen_gntdev xen_evtchn uinput
> kernel: CPU: 6 PID: 3754 Comm: Xorg Tainted: G W 5.15.0-1.fc32.qubes.x86_64 #1
> kernel: Hardware name: LENOVO 20Y1S02400/20Y1S02400, BIOS R1BET61W(1.30) 12/21/
> 2020
> kernel: RIP: e030:prepare_flip_isr+0x64/0x70 [amdgpu]
> kernel: Code: 00 48 c7 80 38 01 00 00 00 00 00 00 66 90 c3 8b 97 f0 03 00 00 48
> c7 c6 18 72 8d c0 48 c7 c7 90 5b a7 c0 e9 7e 6e 13 c1 0f 0b <0f> 0b eb b4 0f 1f
> 84 00 00 00 00 00 0f 1f 44 00 00 41 57 41 56 41
> kernel: RSP: e02b:ffffc90042d93630 EFLAGS: 00010086
> kernel: RAX: 0000000000000001 RBX: 00000000000083c1 RCX: 0000000000000466
> kernel: RDX: 0000000000000001 RSI: 0000000000000204 RDI: ffff88810cb2e000
> kernel: RBP: ffffc90042d936f8 R08: 0000000000000002 R09: 0000000000000001
> kernel: R10: 0000000000000000 R11: ffff88810cb2e118 R12: ffff888110840210
> kernel: R13: ffff88810cb2e000 R14: ffff888103d50400 R15: ffff888103bb2c00
> kernel: FS:  0000718c6de4da40(0000) GS:ffff888140780000(0000) knlGS:000000000000
> 0000
> kernel: CS:  10000e030 DS: 0000 ES: 0000 CR0: 0000000080050033
> kernel: CR2: 0000726ada294000 CR3: 0000000103f0e000 CR4: 0000000000050660
> kernel: Call Trace:
> kernel:  amdgpu_dm_commit_planes+0x8bd/0x9c0 [amdgpu]
> kernel:  amdgpu_dm_atomic_commit_tail+0xc3e/0x1360 [amdgpu]
> kernel:  commit_tail+0x94/0x130 [drm_kms_helper]
> kernel:  drm_atomic_helper_commit+0x113/0x140 [drm_kms_helper]
> kernel:  drm_client_modeset_commit_atomic+0x1fc/0x240 [drm]
> kernel:  drm_client_modeset_commit_locked+0x53/0x80 [drm]
> kernel:  drm_fb_helper_pan_display+0xdc/0x210 [drm_kms_helper]
> kernel:  fb_pan_display+0x83/0x100
> kernel:  fb_set_var+0x200/0x3b0
> kernel:  fbcon_blank+0x186/0x280
> kernel:  do_unblank_screen+0xaa/0x150
> kernel:  complete_change_console+0x54/0x120
> kernel:  vt_ioctl+0x31d/0x5f0
> kernel:  tty_ioctl+0x312/0x780
> kernel:  __x64_sys_ioctl+0x83/0xb0
> kernel:  do_syscall_64+0x3b/0x90
> kernel:  entry_SYSCALL_64_after_hwframe+0x44/0xae
> kernel: RIP: 0033:0x718c6e33217b
> kernel: Code: 0f 1e fa 48 8b 05 1d ad 0c 00 64 c7 00 26 00 00 00 48 c7 c0 ff ff
> ff ff c3 66 0f 1f 44 00 00 f3 0f 1e fa b8 10 00 00 00 0f 05 <48> 3d 01 f0 ff ff
> 73 01 c3 48 8b 0d ed ac 0c 00 f7 d8 64 89 01 48
> kernel: RSP: 002b:00007ffd5c6157c8 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
> kernel: RAX: ffffffffffffffda RBX: 0000000000000001 RCX: 0000718c6e33217b
> kernel: RDX: 0000000000000001 RSI: 0000000000005605 RDI: 0000000000000014
> kernel: RBP: 000057b9b2aa93f4 R08: 0000000000000000 R09: 0000000000000001
> kernel: R10: fffffffffffff9ce R11: 0000000000000246 R12: 000057b9b2aa94b0
> kernel: R13: 000057b9b2aa94a0 R14: 000057b9b2aa93f0 R15: 00007ffd5c615844
> kernel: ---[ end trace 2c3e3998803422cc ]---
> 
> It is discussed briefly at:
> https://lore.kernel.org/linux-pci/CAKf6xpvGyCKVHsvauP54=0j10fxis4XiiqBNWH+1cpkbtt_QJw@mail.gmail.com/
> 
> 
> diff --git a/drivers/pci/msi.c b/drivers/pci/msi.c
> index 0099a00af361..355b791e382f 100644
> --- a/drivers/pci/msi.c
> +++ b/drivers/pci/msi.c
> @@ -148,6 +148,9 @@ static noinline void pci_msi_update_mask(struct msi_desc *desc, u32 clear, u32 s
>  	raw_spinlock_t *lock = &desc->dev->msi_lock;
>  	unsigned long flags;
>  
> +	if (pci_msi_ignore_mask || desc->msi_attrib.is_virtual)
> +		return;
> +
>  	raw_spin_lock_irqsave(lock, flags);
>  	desc->msi_mask &= ~clear;
>  	desc->msi_mask |= set;
> @@ -181,6 +184,9 @@ static void pci_msix_write_vector_ctrl(struct msi_desc *desc, u32 ctrl)
>  {
>  	void __iomem *desc_addr = pci_msix_desc_addr(desc);
>  
> +	if (pci_msi_ignore_mask || desc->msi_attrib.is_virtual)
> +		return;
> +
>  	writel(ctrl, desc_addr + PCI_MSIX_ENTRY_VECTOR_CTRL);
>  }
> 
> --
> 2.31.1
> 


From xen-devel-bounces@lists.xenproject.org Tue Oct 19 20:15:20 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Oct 2021 20:15:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.213458.371666 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcvVv-0001ws-8N; Tue, 19 Oct 2021 20:15:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 213458.371666; Tue, 19 Oct 2021 20:15:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcvVv-0001wl-3d; Tue, 19 Oct 2021 20:15:11 +0000
Received: by outflank-mailman (input) for mailman id 213458;
 Tue, 19 Oct 2021 20:15:09 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=v1Hv=PH=oderland.se=josef@srs-us1.protection.inumbo.net>)
 id 1mcvVt-0001vs-Qk
 for xen-devel@lists.xenproject.org; Tue, 19 Oct 2021 20:15:09 +0000
Received: from office.oderland.com (unknown [91.201.60.5])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 40b7ce9c-3119-11ec-8325-12813bfff9fa;
 Tue, 19 Oct 2021 20:15:07 +0000 (UTC)
Received: from [193.180.18.161] (port=58516 helo=[10.137.0.14])
 by office.oderland.com with esmtpsa (TLS1.2) tls
 TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2)
 (envelope-from <josef@oderland.se>)
 id 1mcvVq-002OOE-Nu; Tue, 19 Oct 2021 22:15:06 +0200
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 40b7ce9c-3119-11ec-8325-12813bfff9fa
Message-ID: <906d370d-5023-e856-4ead-f0b499aded53@oderland.se>
Date: Tue, 19 Oct 2021 22:15:05 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:93.0) Gecko/20100101
 Thunderbird/93.0
Content-Language: en-US
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: linux-pci@vger.kernel.org, xen-devel <xen-devel@lists.xenproject.org>,
 Jason Andryuk <jandryuk@gmail.com>, Thomas Gleixner <tglx@linutronix.de>,
 Marc Zyngier <maz@kernel.org>
References: <20211019195742.GA2394472@bhelgaas>
From: Josef Johansson <josef@oderland.se>
Subject: Re: [PATCH] PCI/MSI: Re-add checks for skip masking MSI-X on Xen PV
In-Reply-To: <20211019195742.GA2394472@bhelgaas>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-AntiAbuse: This header was added to track abuse, please include it with any abuse report
X-AntiAbuse: Primary Hostname - office.oderland.com
X-AntiAbuse: Original Domain - lists.xenproject.org
X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12]
X-AntiAbuse: Sender Address Domain - oderland.se
X-Get-Message-Sender-Via: office.oderland.com: authenticated_id: josjoh@oderland.se
X-Authenticated-Sender: office.oderland.com: josjoh@oderland.se

On 10/19/21 21:57, Bjorn Helgaas wrote:
> [+cc Marc]
>
> On Mon, Oct 18, 2021 at 08:22:32AM +0200, Josef Johansson wrote:
>> From: Josef Johansson <josef@oderland.se>
>>
>>
>> PCI/MSI: Re-add checks for skip masking MSI-X on Xen PV
>>     
>> 'commit fcacdfbef5a1 ("PCI/MSI: Provide a new set of mask and unmask
>> functions")' introduced functions pci_msi_update_mask() and 
>> pci_msix_write_vector_ctrl() that were missing checks for
>> pci_msi_ignore_mask that existed in 'commit 446a98b19fd6 ("PCI/MSI: Use
>> new mask/unmask functions")'. This patch adds them back since it was
>> causing softlocks in amdgpu drivers under Xen.
>>
>> As explained in 'commit 1a519dc7a73c ("PCI/MSI: Skip masking MSI-X
>> on Xen PV")', when running as Xen PV guest, masking MSI-X is a 
>> responsibility of the hypervisor.
>>
>> Fixes: fcacdfbef5a1 ("PCI/MSI: Provide a new set of mask and unmask
>> functions")
>> Suggested-by: Jason Andryuk <jandryuk@gmail.com>
>> Signed-off-by: Josef Johansson <josef@oderland.se>
> fcacdfbef5a1 appeared in v5.15-rc1, and we should try to get this
> fixed before v5.15.
>
> I could merge it but would like an ack from Thomas since he wrote
> fcacdfbef5a1.  He merged fcacdfbef5a1, so I wouldn't complain if the
> fix followed the same path.
>
> If I merged it (or if you were to repost it), I would drop the single
> quotes around the commit citations and write the commit log in
> imperative mood, as you did for the subject
> (https://chris.beams.io/posts/git-commit/)

I'll make an effort to do a better commit log. Thanks for reviewing the
entry!

What is the time frame for v5.15?

>> ---
>>
>> This patch solves a major issue with booting 5.15-rc1 under Xen
>> with amdgpu drivers. Specifically Lenovo P14s Gen 1, AMD 4750U.
>>
>> The softlock below takes about ~2-3 minutes to release, and will
>> lock again if I switch between X and console, when staying in
>> X I can do things without it softlock.
> I don't actually see a softlock mentioned below; am I missing
> something?  It's nice to include a couple lines of dmesg log to help
> people connect the issue with the fix, but most of the below is not
> relevant and can be easily found from the Link: tag.  Also, some of
> the lines seem to be wrapped.  They're more useful when not wrapped
> because grep can find them.

Sorry for my lack of words here. I used deadlock when I first described
it, but since

it was released after a while, I thought softlock would be more fitting.

I'll dig a bit to try to get a better dmesg around the stacktrace. Sorry
about the wrapping,

I'm trying hard to keep those 80 chars ;-)

>> I have to note that this is my first commit and PCI/MSI area is
>> not my area of expertise. I tried to mimic what was
>> obviously missing between the aforementioned commits. There may be
>> better ways to solve this problem, or other places to put the checks.
>> Should desc->msi_attrib.is_virtual be checked? It is not checked in
>> 'commit 1a519dc7a73c ("PCI/MSI: Skip masking MSI-X on Xen PV")'
>>
>> I should also note that my original problem with *flip done timeout*
>> inside drm during suspend/resume is not solved, but with this patch
>> at least the kernel boots properly.
>>
>> The kernel is much more stable not running inside Xen, and much 
>> more stable running pci=nomsi (under Xen). Are we missing something
>> more regarding masking?
> It does sound like something else is broken as well, but I have no
> idea what that would be.

Should I take a stab at describing the issue better at hand or should we
focus on getting this

specific patch out of the way?

I have 'solved' my current problems a bit by kernel flags right now, but
I would be happy to

share my story so far.

>> The error that occurs is:
>>
>> kernel: ------------[ cut here ]------------
>> kernel: WARNING: CPU: 6 PID: 3754 at
>> drivers/gpu/drm/amd/amdgpu/../display/amdgp
>> u_dm/amdgpu_dm.c:8630 amdgpu_dm_commit_planes+0x9b4/0x9c0 [amdgpu]
>> kernel: Modules linked in: nf_tables nfnetlink vfat fat intel_rapl_msr wmi_bmof
>> intel_rapl_common pcspkr joydev uvcvideo k10temp sp5100_tco videobuf2_vmalloc vi
>> deobuf2_memops i2c_piix4 videobuf2_v4l2 videobuf2_common videodev mc iwlwifi thi
>> nkpad_acpi platform_profile ipmi_devintf ledtrig_audio ucsi_acpi cfg80211 ipmi_m
>> sghandler r8169 snd typec_ucsi soundcore typec rfkill wmi video amd_pmc i2c_scmi
>>  fuse xenfs ip_tables dm_thin_pool dm_persistent_data dm_bio_prison dm_crypt tru
>> sted asn1_encoder hid_multitouch amdgpu crct10dif_pclmul iommu_v2 crc32_pclmul c
>> rc32c_intel gpu_sched i2c_algo_bit drm_ttm_helper ttm drm_kms_helper ccp cec gha
>> sh_clmulni_intel sdhci_pci xhci_pci xhci_pci_renesas serio_raw cqhci drm sdhci x
>> hci_hcd mmc_core nvme ehci_pci ehci_hcd nvme_core xen_acpi_processor xen_privcmd
>>  xen_pciback xen_blkback xen_gntalloc xen_gntdev xen_evtchn uinput
>> kernel: CPU: 6 PID: 3754 Comm: Xorg Tainted: G   W 5.15.0-1.fc32.qubes.x86_64 #1
>> kernel: Hardware name: LENOVO 20Y1S02400/20Y1S02400, BIOS R1BET61W(1.30) 12/21/
>> 2020
>> kernel: RIP: e030:amdgpu_dm_commit_planes+0x9b4/0x9c0 [amdgpu]
>> kernel: Code: 8b 45 b0 48 c7 c7 4b fc 90 c0 4c 89 55 88 8b b0 f0 03 00 00 e8 6d
>> cb ca ff 4c 8b 55 88 0f b6 55 ab 49 8b 72 08 e9 2b fa ff ff <0f> 0b e9 fa fe ff
>> ff e8 40 2f 6e c1 0f 1f 44 00 00 55 b9 27 00 00
>> kernel: RSP: e02b:ffffc90042d93638 EFLAGS: 00010002
>> kernel: RAX: ffff888110840210 RBX: 00000000000083c1 RCX: 0000000000000466
>> kernel: RDX: 0000000000000001 RSI: 0000000000000204 RDI: ffff888110840170
>> kernel: RBP: ffffc90042d936f8 R08: 0000000000000002 R09: 0000000000000001
>> kernel: R10: 0000000000000000 R11: ffff88810cb2e118 R12: ffff888110840210
>> kernel: R13: ffff88810cb2e000 R14: ffff888103d50400 R15: ffff888103bb2c00
>> kernel: FS:  0000718c6de4da40(0000) GS:ffff888140780000(0000)
>> knlGS:000000000000
>> 0000
>> kernel: CS:  10000e030 DS: 0000 ES: 0000 CR0: 0000000080050033
>> kernel: CR2: 0000726ada294000 CR3: 0000000103f0e000 CR4: 0000000000050660
>> kernel: Call Trace:
>> kernel:  amdgpu_dm_atomic_commit_tail+0xc3e/0x1360 [amdgpu]
>> kernel:  commit_tail+0x94/0x130 [drm_kms_helper]
>> kernel:  drm_atomic_helper_commit+0x113/0x140 [drm_kms_helper]
>> kernel:  drm_client_modeset_commit_atomic+0x1fc/0x240 [drm]
>> kernel:  drm_client_modeset_commit_locked+0x53/0x80 [drm]
>> kernel:  drm_fb_helper_pan_display+0xdc/0x210 [drm_kms_helper]
>> kernel:  fb_pan_display+0x83/0x100
>> kernel:  fb_set_var+0x200/0x3b0
>> kernel:  fbcon_blank+0x186/0x280
>> kernel:  do_unblank_screen+0xaa/0x150
>> kernel:  complete_change_console+0x54/0x120
>> kernel:  vt_ioctl+0x31d/0x5f0
>> kernel:  tty_ioctl+0x312/0x780
>> kernel:  __x64_sys_ioctl+0x83/0xb0
>> kernel:  do_syscall_64+0x3b/0x90
>> kernel:  entry_SYSCALL_64_after_hwframe+0x44/0xae
>> kernel: RIP: 0033:0x718c6e33217b
>> kernel: Code: 0f 1e fa 48 8b 05 1d ad 0c 00 64 c7 00 26 00 00 00 48 c7 c0 ff ff
>> ff ff c3 66 0f 1f 44 00 00 f3 0f 1e fa b8 10 00 00 00 0f 05 <48> 3d 01 f0 ff ff
>> 73 01 c3 48 8b 0d ed ac 0c 00 f7 d8 64 89 01 48
>> kernel: RSP: 002b:00007ffd5c6157c8 EFLAGS: 00000246 ORIG_RAX:
>> 0000000000000010
>> kernel: RAX: ffffffffffffffda RBX: 0000000000000001 RCX: 0000718c6e33217b
>> kernel: RDX: 0000000000000001 RSI: 0000000000005605 RDI: 0000000000000014
>> kernel: RBP: 000057b9b2aa93f4 R08: 0000000000000000 R09: 0000000000000001
>> kernel: R10: fffffffffffff9ce R11: 0000000000000246 R12: 000057b9b2aa94b0
>> kernel: R13: 000057b9b2aa94a0 R14: 000057b9b2aa93f0 R15: 00007ffd5c615844
>> kernel: ---[ end trace 2c3e3998803422cb ]---
>> kernel: ------------[ cut here ]------------
>> kernel: WARNING: CPU: 6 PID: 3754 at
>> drivers/gpu/drm/amd/amdgpu/../display/amdgp
>> u_dm/amdgpu_dm.c:8217 prepare_flip_isr+0x64/0x70 [amdgpu]
>> kernel: Modules linked in: nf_tables nfnetlink vfat fat intel_rapl_msr wmi_bmof
>> intel_rapl_common pcspkr joydev uvcvideo k10temp sp5100_tco videobuf2_vmalloc vi
>> deobuf2_memops i2c_piix4 videobuf2_v4l2 videobuf2_common videodev mc iwlwifi thi
>> nkpad_acpi platform_profile ipmi_devintf ledtrig_audio ucsi_acpi cfg80211 ipmi_m
>> sghandler r8169 snd typec_ucsi soundcore typec rfkill wmi video amd_pmc i2c_scmi
>>  fuse xenfs ip_tables dm_thin_pool dm_persistent_data dm_bio_prison dm_crypt tru
>> sted asn1_encoder hid_multitouch amdgpu crct10dif_pclmul iommu_v2 crc32_pclmul c
>> rc32c_intel gpu_sched i2c_algo_bit drm_ttm_helper ttm drm_kms_helper ccp cec gha
>> sh_clmulni_intel sdhci_pci xhci_pci xhci_pci_renesas serio_raw cqhci drm sdhci x
>> hci_hcd mmc_core nvme ehci_pci ehci_hcd nvme_core xen_acpi_processor xen_privcmd
>>  xen_pciback xen_blkback xen_gntalloc xen_gntdev xen_evtchn uinput
>> kernel: CPU: 6 PID: 3754 Comm: Xorg Tainted: G W 5.15.0-1.fc32.qubes.x86_64 #1
>> kernel: Hardware name: LENOVO 20Y1S02400/20Y1S02400, BIOS R1BET61W(1.30) 12/21/
>> 2020
>> kernel: RIP: e030:prepare_flip_isr+0x64/0x70 [amdgpu]
>> kernel: Code: 00 48 c7 80 38 01 00 00 00 00 00 00 66 90 c3 8b 97 f0 03 00 00 48
>> c7 c6 18 72 8d c0 48 c7 c7 90 5b a7 c0 e9 7e 6e 13 c1 0f 0b <0f> 0b eb b4 0f 1f
>> 84 00 00 00 00 00 0f 1f 44 00 00 41 57 41 56 41
>> kernel: RSP: e02b:ffffc90042d93630 EFLAGS: 00010086
>> kernel: RAX: 0000000000000001 RBX: 00000000000083c1 RCX: 0000000000000466
>> kernel: RDX: 0000000000000001 RSI: 0000000000000204 RDI: ffff88810cb2e000
>> kernel: RBP: ffffc90042d936f8 R08: 0000000000000002 R09: 0000000000000001
>> kernel: R10: 0000000000000000 R11: ffff88810cb2e118 R12: ffff888110840210
>> kernel: R13: ffff88810cb2e000 R14: ffff888103d50400 R15: ffff888103bb2c00
>> kernel: FS:  0000718c6de4da40(0000) GS:ffff888140780000(0000) knlGS:000000000000
>> 0000
>> kernel: CS:  10000e030 DS: 0000 ES: 0000 CR0: 0000000080050033
>> kernel: CR2: 0000726ada294000 CR3: 0000000103f0e000 CR4: 0000000000050660
>> kernel: Call Trace:
>> kernel:  amdgpu_dm_commit_planes+0x8bd/0x9c0 [amdgpu]
>> kernel:  amdgpu_dm_atomic_commit_tail+0xc3e/0x1360 [amdgpu]
>> kernel:  commit_tail+0x94/0x130 [drm_kms_helper]
>> kernel:  drm_atomic_helper_commit+0x113/0x140 [drm_kms_helper]
>> kernel:  drm_client_modeset_commit_atomic+0x1fc/0x240 [drm]
>> kernel:  drm_client_modeset_commit_locked+0x53/0x80 [drm]
>> kernel:  drm_fb_helper_pan_display+0xdc/0x210 [drm_kms_helper]
>> kernel:  fb_pan_display+0x83/0x100
>> kernel:  fb_set_var+0x200/0x3b0
>> kernel:  fbcon_blank+0x186/0x280
>> kernel:  do_unblank_screen+0xaa/0x150
>> kernel:  complete_change_console+0x54/0x120
>> kernel:  vt_ioctl+0x31d/0x5f0
>> kernel:  tty_ioctl+0x312/0x780
>> kernel:  __x64_sys_ioctl+0x83/0xb0
>> kernel:  do_syscall_64+0x3b/0x90
>> kernel:  entry_SYSCALL_64_after_hwframe+0x44/0xae
>> kernel: RIP: 0033:0x718c6e33217b
>> kernel: Code: 0f 1e fa 48 8b 05 1d ad 0c 00 64 c7 00 26 00 00 00 48 c7 c0 ff ff
>> ff ff c3 66 0f 1f 44 00 00 f3 0f 1e fa b8 10 00 00 00 0f 05 <48> 3d 01 f0 ff ff
>> 73 01 c3 48 8b 0d ed ac 0c 00 f7 d8 64 89 01 48
>> kernel: RSP: 002b:00007ffd5c6157c8 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
>> kernel: RAX: ffffffffffffffda RBX: 0000000000000001 RCX: 0000718c6e33217b
>> kernel: RDX: 0000000000000001 RSI: 0000000000005605 RDI: 0000000000000014
>> kernel: RBP: 000057b9b2aa93f4 R08: 0000000000000000 R09: 0000000000000001
>> kernel: R10: fffffffffffff9ce R11: 0000000000000246 R12: 000057b9b2aa94b0
>> kernel: R13: 000057b9b2aa94a0 R14: 000057b9b2aa93f0 R15: 00007ffd5c615844
>> kernel: ---[ end trace 2c3e3998803422cc ]---
>>
>> It is discussed briefly at:
>> https://lore.kernel.org/linux-pci/CAKf6xpvGyCKVHsvauP54=0j10fxis4XiiqBNWH+1cpkbtt_QJw@mail.gmail.com/
>>
>>
>> diff --git a/drivers/pci/msi.c b/drivers/pci/msi.c
>> index 0099a00af361..355b791e382f 100644
>> --- a/drivers/pci/msi.c
>> +++ b/drivers/pci/msi.c
>> @@ -148,6 +148,9 @@ static noinline void pci_msi_update_mask(struct msi_desc *desc, u32 clear, u32 s
>>  	raw_spinlock_t *lock = &desc->dev->msi_lock;
>>  	unsigned long flags;
>>  
>> +	if (pci_msi_ignore_mask || desc->msi_attrib.is_virtual)
>> +		return;
>> +
>>  	raw_spin_lock_irqsave(lock, flags);
>>  	desc->msi_mask &= ~clear;
>>  	desc->msi_mask |= set;
>> @@ -181,6 +184,9 @@ static void pci_msix_write_vector_ctrl(struct msi_desc *desc, u32 ctrl)
>>  {
>>  	void __iomem *desc_addr = pci_msix_desc_addr(desc);
>>  
>> +	if (pci_msi_ignore_mask || desc->msi_attrib.is_virtual)
>> +		return;
>> +
>>  	writel(ctrl, desc_addr + PCI_MSIX_ENTRY_VECTOR_CTRL);
>>  }
>>
>> --
>> 2.31.1
>>


From xen-devel-bounces@lists.xenproject.org Tue Oct 19 20:29:15 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Oct 2021 20:29:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.213465.371677 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcvjT-0003Z2-Gg; Tue, 19 Oct 2021 20:29:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 213465.371677; Tue, 19 Oct 2021 20:29:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcvjT-0003Yv-Cz; Tue, 19 Oct 2021 20:29:11 +0000
Received: by outflank-mailman (input) for mailman id 213465;
 Tue, 19 Oct 2021 20:29:09 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=9sDB=PH=kernel.org=helgaas@srs-us1.protection.inumbo.net>)
 id 1mcvjR-0003Yo-MA
 for xen-devel@lists.xenproject.org; Tue, 19 Oct 2021 20:29:09 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 3618b936-311b-11ec-8325-12813bfff9fa;
 Tue, 19 Oct 2021 20:29:08 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id AB05A611CB;
 Tue, 19 Oct 2021 20:29:07 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3618b936-311b-11ec-8325-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1634675348;
	bh=R4jeDkw65lpfHKRy+jf4Qa1MZGoEnFadGzSBbx9BLyI=;
	h=Date:From:To:Cc:Subject:In-Reply-To:From;
	b=HW4rovQUPgerwAQsykahmmUftEQ7zv6sAe49wiQ+jS+XbBWwH2GUhzzcg+dafHNvC
	 rnkAVBONJubsdGMFY9XCoCpT+ge74YzPlRs1pnOHvyHckD1hPbq6GgQpUVBGG5omhz
	 05lSgmYcUUlO7EoAnDaHDoX1A+knXEMeiO3JwcukO5aGinkX8+MlmytCRUm1hMY64C
	 g0P7iN7ZMFBhhr435qf/iQDl6gQWM1z3DWeM89DksP7hiUPESYF69K5EHFYMM3QrT0
	 F3KRyzelJsKmAMHEiGRPsllsVJso4ksDjUqCnpNd5bhIaFT32N2MeWNZZBg8ffrsq3
	 dnIx8/mT7rIbg==
Date: Tue, 19 Oct 2021 15:29:06 -0500
From: Bjorn Helgaas <helgaas@kernel.org>
To: Josef Johansson <josef@oderland.se>
Cc: linux-pci@vger.kernel.org, xen-devel <xen-devel@lists.xenproject.org>,
	Jason Andryuk <jandryuk@gmail.com>,
	Thomas Gleixner <tglx@linutronix.de>, Marc Zyngier <maz@kernel.org>
Subject: Re: [PATCH] PCI/MSI: Re-add checks for skip masking MSI-X on Xen PV
Message-ID: <20211019202906.GA2397931@bhelgaas>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <906d370d-5023-e856-4ead-f0b499aded53@oderland.se>

On Tue, Oct 19, 2021 at 10:15:05PM +0200, Josef Johansson wrote:
> On 10/19/21 21:57, Bjorn Helgaas wrote:
> > On Mon, Oct 18, 2021 at 08:22:32AM +0200, Josef Johansson wrote:

> I'll make an effort to do a better commit log. Thanks for reviewing the
> entry!
> 
> What is the time frame for v5.15?

Soon.  v5.15-rc7 should happen Oct 24, final release likely Oct 31.
Ideally a fix would be in before the 24th.

> >> This patch solves a major issue with booting 5.15-rc1 under Xen
> >> with amdgpu drivers. Specifically Lenovo P14s Gen 1, AMD 4750U.
> >>
> >> The softlock below takes about ~2-3 minutes to release, and will
> >> lock again if I switch between X and console, when staying in
> >> X I can do things without it softlock.
> >
> > I don't actually see a softlock mentioned below; am I missing
> > something?  It's nice to include a couple lines of dmesg log to help
> > people connect the issue with the fix, but most of the below is not
> > relevant and can be easily found from the Link: tag.  Also, some of
> > the lines seem to be wrapped.  They're more useful when not wrapped
> > because grep can find them.
> 
> Sorry for my lack of words here. I used deadlock when I first
> described it, but since it was released after a while, I thought
> softlock would be more fitting.

I looked up the WARN_ON at amdgpu_dm.c:8630 but I didn't see anything
related to deadlock or soft lockup or any kind of delay:

  WARN_ON(acrtc_attach->pflip_status != AMDGPU_FLIP_NONE);

DRM folks might have an idea.

> I'll dig a bit to try to get a better dmesg around the stacktrace. Sorry
> about the wrapping,
> 
> I'm trying hard to keep those 80 chars ;-)

I appreciate that.  Commit logs should be 75 chars because git log
indents by 4.  Quotes of dmesg and the like should be unwrapped.

> >> I should also note that my original problem with *flip done timeout*
> >> inside drm during suspend/resume is not solved, but with this patch
> >> at least the kernel boots properly.
> >>
> >> The kernel is much more stable not running inside Xen, and much 
> >> more stable running pci=nomsi (under Xen). Are we missing something
> >> more regarding masking?
> > It does sound like something else is broken as well, but I have no
> > idea what that would be.
> 
> Should I take a stab at describing the issue better at hand or
> should we focus on getting this specific patch out of the way?

Unless the other issues seem related, we should dispose of this one
by itself ASAP.

> I have 'solved' my current problems a bit by kernel flags right now,
> but I would be happy to share my story so far.

Description of your workaround would be quite useful.  Probably not to
*me*, but to people who know the area (I'd start with the DRM folks).

> >> The error that occurs is:
> >>
> >> kernel: ------------[ cut here ]------------
> >> kernel: WARNING: CPU: 6 PID: 3754 at
> >> drivers/gpu/drm/amd/amdgpu/../display/amdgp
> >> u_dm/amdgpu_dm.c:8630 amdgpu_dm_commit_planes+0x9b4/0x9c0 [amdgpu]


From xen-devel-bounces@lists.xenproject.org Tue Oct 19 20:43:38 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Oct 2021 20:43:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.213478.371688 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcvxM-0005vq-0q; Tue, 19 Oct 2021 20:43:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 213478.371688; Tue, 19 Oct 2021 20:43:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcvxL-0005vj-Sz; Tue, 19 Oct 2021 20:43:31 +0000
Received: by outflank-mailman (input) for mailman id 213478;
 Tue, 19 Oct 2021 20:43:31 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mcvxL-0005vZ-Fw; Tue, 19 Oct 2021 20:43:31 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mcvxL-0001r0-AP; Tue, 19 Oct 2021 20:43:31 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mcvxL-0008Kd-02; Tue, 19 Oct 2021 20:43:31 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mcvxK-0005fP-Vr; Tue, 19 Oct 2021 20:43:30 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=7L8FgdYql6GynUBBrLePELutVpF+w+eGchmekD/TWK4=; b=51xvTu7RwSEf+q9Q+uUPTHxIaE
	ph6PRFNBO/pWXe+fPr8nAJvTAAP6pQlMoyCL/IeJBD5pY7Qe9J6QkOpBZelcjFTQ/exotLT9ZCEVM
	ME1EmMqbAtV0e81uoVRE2wY/RUnr1Ku9kayaezu2kkdACA/XSZZpIQE2gvEkNYX5OsgU=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165670-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 165670: tolerable FAIL - PUSHED
X-Osstest-Failures:
    qemu-mainline:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=362534a643b4a34bcb223996538ce9de5cdab946
X-Osstest-Versions-That:
    qemuu=9c050b661d3a43dfe2fd44106e559b39706d1296
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 19 Oct 2021 20:43:30 +0000

flight 165670 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165670/

Failures :-/ but no regressions.

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds    18 guest-start/debian.repeat fail REGR. vs. 165640

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165640
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165640
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 165640
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 165640
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 165640
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 165640
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 165640
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165640
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 qemuu                362534a643b4a34bcb223996538ce9de5cdab946
baseline version:
 qemuu                9c050b661d3a43dfe2fd44106e559b39706d1296

Last test of basis   165640  2021-10-18 19:08:02 Z    1 days
Testing same since   165670  2021-10-19 10:18:28 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Guy Yur <guyyur@gmail.com>
  Kyle Evans <kevans@FreeBSD.org>
  Mikaël Urankar <mikael.urankar@gmail.com>
  Paolo Bonzini <pbonzinni@redhat.com>
  Philippe Mathieu-Daudé <f4bug@amsat.org>
  Richard Henderson <richard.henderson@linaro.org>
  Stacey Son <sson@FreeBSD.org>
  Warner Losh <imp@bsdimp.com>
  Warner Losh <wlosh@bsdimp.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/qemu-xen.git
   9c050b661d..362534a643  362534a643b4a34bcb223996538ce9de5cdab946 -> upstream-tested


From xen-devel-bounces@lists.xenproject.org Tue Oct 19 20:48:46 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Oct 2021 20:48:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.213486.371701 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcw2M-0006fx-KY; Tue, 19 Oct 2021 20:48:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 213486.371701; Tue, 19 Oct 2021 20:48:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcw2M-0006fq-HX; Tue, 19 Oct 2021 20:48:42 +0000
Received: by outflank-mailman (input) for mailman id 213486;
 Tue, 19 Oct 2021 20:48:41 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=f1bC=PH=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1mcw2L-0006fj-26
 for xen-devel@lists.xenproject.org; Tue, 19 Oct 2021 20:48:41 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id c29bc5f0-50cd-4f74-a958-ea3fa15b80b7;
 Tue, 19 Oct 2021 20:48:40 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id 2C67D61360;
 Tue, 19 Oct 2021 20:48:39 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c29bc5f0-50cd-4f74-a958-ea3fa15b80b7
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1634676519;
	bh=ipgWwRh0pnWDy9F6yx9R3F1aglp3+TCtJ3pZSU3C/Co=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=BncH+nMXOm1nU4Y9d75Ekq3rWHicGTRHwL0HkqdtgvH4sedtQlP2g97y2ql3Swtse
	 KyqJrlGV178HTDxnHcjgIi6LNozwK/2izLN/FCO3jk2yOt+z2M1W8U61Y40XSSn6Ya
	 uwuYEXNecyfQ0JPYnu4pShFN0Uud5dpBUNQ9zT4wmZ/ZMM157S6NXkBRrH50TUM9qf
	 2KqMEyI+eCASeOJBuRuMVlPWTnyI2SXoxnBfFh4rPXM3MET7IM0FDpzcI6v6MlvKKQ
	 nPPSjqXCJvQ0xzKA0Kncd0ALRHSQieNIXokWKtmGQf96VCuqS3Vsd4in6bw7TDxiPZ
	 SUh2c2EMY5IEg==
Date: Tue, 19 Oct 2021 13:48:38 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Juergen Gross <jgross@suse.com>
cc: Stefano Stabellini <sstabellini@kernel.org>, 
    xen-devel@lists.xenproject.org, Ian Jackson <iwj@xenproject.org>, 
    Wei Liu <wl@xen.org>
Subject: Re: [PATCH v6 1/2] tools/xenstore: set oom score for xenstore daemon
 on Linux
In-Reply-To: <01adb8a7-a4be-2171-ae4c-5dca24ce5838@suse.com>
Message-ID: <alpine.DEB.2.21.2110191348160.21467@sstabellini-ThinkPad-T480s>
References: <20211012134148.6280-1-jgross@suse.com> <20211012134148.6280-2-jgross@suse.com> <alpine.DEB.2.21.2110181616400.21467@sstabellini-ThinkPad-T480s> <01adb8a7-a4be-2171-ae4c-5dca24ce5838@suse.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Tue, 19 Oct 2021, Juergen Gross wrote:
> On 19.10.21 01:25, Stefano Stabellini wrote:
> > Hi Juergen, Ian,
> > 
> > This patch broke gitlab-ci:
> > 
> > https://gitlab.com/xen-project/xen/-/jobs/1690080806
> > 
> > ---
> >   * Executing: /lib/rc/sh/openrc-run.sh /lib/rc/sh/openrc-run.sh
> > /etc/init.d/local start
> >   * Starting local ... *   Executing "/etc/local.d/xen.start"
> > .../etc/xen/scripts/launch-xenstore: line 64: * 10: syntax error: operand
> > expected (error token is "* 10")
> > 
> > illegal value daemon for XENSTORETYPE
> > ---
> > 
> > See below about what the issue is and a potential fix.
> > 
> > 
> > On Tue, 12 Oct 2021, Juergen Gross wrote:
> > > Xenstored is absolutely mandatory for a Xen host and it can't be
> > > restarted, so being killed by OOM-killer in case of memory shortage is
> > > to be avoided.
> > > 
> > > Set /proc/$pid/oom_score_adj (if available) per default to -500 (this
> > > translates to 50% of dom0 memory size) in order to allow xenstored to
> > > use large amounts of memory without being killed.
> > > 
> > > The percentage of dom0 memory above which the oom killer is allowed to
> > > kill xenstored can be set via XENSTORED_OOM_MEM_THRESHOLD in
> > > xencommons.
> > > 
> > > Make sure the pid file isn't a left-over from a previous run delete it
> > > before starting xenstored.
> > > 
> > > Signed-off-by: Juergen Gross <jgross@suse.com>
> > > Reviewed-by: Ian Jackson <iwj@xenproject.org>
> > > ---
> > > V2:
> > > - set oom score from launch script (Julien Grall)
> > > - split off open file descriptor limit setting (Julien Grall)
> > > V3:
> > > - make oom killer threshold configurable (Julien Grall)
> > > V4:
> > > - extend comment (Ian Jackson)
> > > ---
> > >   tools/hotplug/Linux/init.d/sysconfig.xencommons.in | 9 +++++++++
> > >   tools/hotplug/Linux/launch-xenstore.in             | 6 ++++++
> > >   2 files changed, 15 insertions(+)
> > > 
> > > diff --git a/tools/hotplug/Linux/init.d/sysconfig.xencommons.in
> > > b/tools/hotplug/Linux/init.d/sysconfig.xencommons.in
> > > index 00cf7f91d4..b83101ab7e 100644
> > > --- a/tools/hotplug/Linux/init.d/sysconfig.xencommons.in
> > > +++ b/tools/hotplug/Linux/init.d/sysconfig.xencommons.in
> > > @@ -48,6 +48,15 @@ XENSTORED_ARGS=
> > >   # Only evaluated if XENSTORETYPE is "daemon".
> > >   #XENSTORED_TRACE=[yes|on|1]
> > >   +## Type: integer
> > > +## Default: 50
> > > +#
> > > +# Percentage of dom0 memory size the xenstore daemon can use before the
> > > +# OOM killer is allowed to kill it.
> > > +# The specified value is multiplied by -10 and echoed to
> > > +# /proc/PID/oom_score_adj.
> > > +#XENSTORED_OOM_MEM_THRESHOLD=50
> > > +
> > >   ## Type: string
> > >   ## Default: @LIBEXEC@/boot/xenstore-stubdom.gz
> > >   #
> > > diff --git a/tools/hotplug/Linux/launch-xenstore.in
> > > b/tools/hotplug/Linux/launch-xenstore.in
> > > index 019f9d6f4d..1747c96065 100644
> > > --- a/tools/hotplug/Linux/launch-xenstore.in
> > > +++ b/tools/hotplug/Linux/launch-xenstore.in
> > > @@ -59,11 +59,17 @@ test -f @CONFIG_DIR@/@CONFIG_LEAF_DIR@/xencommons && .
> > > @CONFIG_DIR@/@CONFIG_LEAF
> > >   		echo "No xenstored found"
> > >   		exit 1
> > >   	}
> > > +	[ -z "$XENSTORED_OOM_MEM_THRESHOLD" ] ||
> > > XENSTORED_OOM_MEM_THRESHOLD=50
> > > +	XS_OOM_SCORE=-$(($XENSTORED_OOM_MEM_THRESHOLD * 10))
> > 
> > These are the problematic lines. They don't work with busybox's bash
> > implementation. Originally I thought it was an issue with busybox bash
> > implementation but it looks like they don't even work with normal bash.
> > Specifically the first line is an issue, it should be:
> > 
> > if [ -z "$XENSTORED_OOM_MEM_THRESHOLD" ]
> > then
> >      XENSTORED_OOM_MEM_THRESHOLD=50
> > fi
> > 
> > Right?
> > 
> 
> Oh, shame on me. Turned out that I had XENSTORED_OOM_MEM_THRESHOLD
> set explicitly in my xencommons file. :-(
> 
> Patch is coming...

Thanks Juergen, gitlab-ci is all green again:
https://gitlab.com/xen-project/xen/-/pipelines/391015163

Thanks!


From xen-devel-bounces@lists.xenproject.org Tue Oct 19 20:55:42 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Oct 2021 20:55:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.213494.371713 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcw94-00085l-Bs; Tue, 19 Oct 2021 20:55:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 213494.371713; Tue, 19 Oct 2021 20:55:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcw94-00085e-8b; Tue, 19 Oct 2021 20:55:38 +0000
Received: by outflank-mailman (input) for mailman id 213494;
 Tue, 19 Oct 2021 20:55:37 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=f1bC=PH=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1mcw93-00085Y-Ag
 for xen-devel@lists.xenproject.org; Tue, 19 Oct 2021 20:55:37 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id e849ab4e-311e-11ec-8326-12813bfff9fa;
 Tue, 19 Oct 2021 20:55:36 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id 0A36B6113B;
 Tue, 19 Oct 2021 20:55:34 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e849ab4e-311e-11ec-8326-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1634676935;
	bh=1R4/QUryqB7rGI56XkGGZIQs5wm16uxW64pnaL6Ns6U=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=WjVMZAI6tmRO8FzeMYyATQEBA3jsx9dAIuVQSJisJVrEufWEzM/GddMwHjipNf4h6
	 CYxWH/8rbvmmgRaxet6tjfEqWctG/Ize2PvI2F46kjatE/1Fa2ppDLTvtjvykSyfmn
	 d76i7n/rTZHfvgFn0p2A2s+bZ3MA8kVTJ0s11VnqWVXqV5pFoY57079RmLDfgtbRTd
	 W75dcVzk4/pNwxJbPKIku/Aw2czh67s/aEotBgG3TPciUeIEbUTbWEVBGe02rRW32P
	 89BszSFK3Gg0NgzTspYNH2hcgbNlU1E4R6fM13Qovw4jL8lTmmIOCu2QgdKwV5jAJe
	 tbW8u3tBUjjqA==
Date: Tue, 19 Oct 2021 13:55:34 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Julien Grall <julien@xen.org>
cc: Sai Kiran Kumar Reddy Y <ysaikiran1997@gmail.com>, 
    Stefano Stabellini <sstabellini@kernel.org>, 
    Bertrand Marquis <bertrand.marquis@arm.com>, 
    Jan Beulich <jbeulich@suse.com>, Luca Fancellu <luca.fancellu@arm.com>, 
    xen-devel@lists.xenproject.org, kannan@cimware.in
Subject: Re: Xen Booting Problem on ARM Machine
In-Reply-To: <7f6a0b1b-c325-95c4-a9d2-2bc28ae79268@xen.org>
Message-ID: <alpine.DEB.2.21.2110191351170.21467@sstabellini-ThinkPad-T480s>
References: <33C29853-D896-4E4E-91D3-4D2FA89A9B91@hxcore.ol> <eb5fd47b-6bc9-2eec-7f46-9ab9a42c9f1f@xen.org> <CAEsO4uzsCnsTtTmYHAT4NN6=girCY2NHHdAHbH6GG33D7jwe_A@mail.gmail.com> <alpine.DEB.2.21.2109131437030.10523@sstabellini-ThinkPad-T480s>
 <CAEsO4uwpiDO2QoqLRTOxpsYM9YSPAsbX0P=gagdEy21pk1VsPQ@mail.gmail.com> <alpine.DEB.2.21.2109141825330.21985@sstabellini-ThinkPad-T480s> <CAEsO4uyjNs97Cx8n2owDk4kKTVCycji377pm7aXHcPWzeszUTw@mail.gmail.com> <alpine.DEB.2.21.2109301942370.3209@sstabellini-ThinkPad-T480s>
 <CAEsO4ux_AqXBeCtbwnPAdnBnVYHTur_2EfcZBTuN4QKCq4ko8Q@mail.gmail.com> <alpine.DEB.2.21.2110131711280.9408@sstabellini-ThinkPad-T480s> <CAEsO4uxo_A4pEwP6dHK8kvYtKcbSr-ewqX1v-KLsEkyHNLFyUA@mail.gmail.com> <alpine.DEB.2.21.2110141536090.9408@sstabellini-ThinkPad-T480s>
 <CAEsO4uzwNHiLEZVEy90uua9YRud=Bmj=EPhzbhyk0tsEai=UQg@mail.gmail.com> <7f6a0b1b-c325-95c4-a9d2-2bc28ae79268@xen.org>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="8323329-59138649-1634676935=:21467"

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-59138649-1634676935=:21467
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT

On Tue, 19 Oct 2021, Julien Grall wrote:
> On 19/10/2021 13:04, Sai Kiran Kumar Reddy Y wrote:
> > Hi,
> > 
> > Thanks for your inputs. As you have mentioned, I tried to boot Xen directly
> > from EFI, thereby skipping GRUB. I made sure that kernel, xen.cfg and
> > ramdisk are on the first FAT partition. I still get "All 128 bootinfo
> > membanks exhausted error". The following link has my grub.cfg config. file
> > and also the snapshot of the error.
> > 
> > Link:
> > https://drive.google.com/drive/folders/1o7WT5oB7UsaZBeY5m4mWSidT5NalzvvJ?usp=sharing
> > <https://drive.google.com/drive/folders/1o7WT5oB7UsaZBeY5m4mWSidT5NalzvvJ?usp=sharing>
> > 
> > I feel that even with EFI bootloader, there's some issue with bootinfo mem
> > banks and it maynot be a bug in GRUB. Let me know your thoughts on this.
> 
> As I wrote a few weeks ago. Both issues ("mem banks exhausted" and "Cannot
> exit boot services") are meant to be non-fatal. So you should be able to
> continue booting Xen afterwards.
> 
> The fact you don't see any log seems to suggest that you didn't enable
> properly earlyprintk. Would you be able to post your xen/.config?

Just to add to what Julien wrote, the "Cannot exit boot services" error
is printed from here:

https://gitlab.com/xen-project/xen/-/blob/staging/xen/common/efi/boot.c#L1086

as you can see, the error is printed but the function should continue onward.


To enable earlyprintk, you need to rebuild Xen. Assuming you build on
x86:

# cd xen.git/xen
# export CROSS_COMPILE=/path/to/cross-compiler # you can skip this if you build on ARM
# export XEN_TARGET_ARCH=arm64
# make menuconfig
      --> Debugging Options --> Developer Checks
      --> Debugging Options --> Early printk

Then you select driver and base address of the UART
--8323329-59138649-1634676935=:21467--


From xen-devel-bounces@lists.xenproject.org Tue Oct 19 21:48:40 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Oct 2021 21:48:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.213505.371723 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcwyB-00054R-Ef; Tue, 19 Oct 2021 21:48:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 213505.371723; Tue, 19 Oct 2021 21:48:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcwyB-00054K-Bf; Tue, 19 Oct 2021 21:48:27 +0000
Received: by outflank-mailman (input) for mailman id 213505;
 Tue, 19 Oct 2021 21:48:26 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=v1Hv=PH=oderland.se=josef@srs-us1.protection.inumbo.net>)
 id 1mcwyA-00054E-Jc
 for xen-devel@lists.xenproject.org; Tue, 19 Oct 2021 21:48:26 +0000
Received: from office.oderland.com (unknown [91.201.60.5])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 46d7e26e-3126-11ec-8327-12813bfff9fa;
 Tue, 19 Oct 2021 21:48:21 +0000 (UTC)
Received: from [193.180.18.161] (port=58518 helo=[10.137.0.14])
 by office.oderland.com with esmtpsa (TLS1.2) tls
 TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2)
 (envelope-from <josef@oderland.se>)
 id 1mcwy4-004Yi8-In; Tue, 19 Oct 2021 23:48:20 +0200
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 46d7e26e-3126-11ec-8327-12813bfff9fa
Message-ID: <5f050b30-fa1c-8387-0d6b-a667851b34b0@oderland.se>
Date: Tue, 19 Oct 2021 23:48:19 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:93.0) Gecko/20100101
 Thunderbird/93.0
Content-Language: en-US
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: linux-pci@vger.kernel.org, xen-devel <xen-devel@lists.xenproject.org>,
 Jason Andryuk <jandryuk@gmail.com>, Thomas Gleixner <tglx@linutronix.de>,
 Marc Zyngier <maz@kernel.org>
References: <20211019202906.GA2397931@bhelgaas>
From: Josef Johansson <josef@oderland.se>
Subject: [PATCH v2] PCI/MSI: Re-add checks for skip masking MSI-X on Xen PV
In-Reply-To: <20211019202906.GA2397931@bhelgaas>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-AntiAbuse: This header was added to track abuse, please include it with any abuse report
X-AntiAbuse: Primary Hostname - office.oderland.com
X-AntiAbuse: Original Domain - lists.xenproject.org
X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12]
X-AntiAbuse: Sender Address Domain - oderland.se
X-Get-Message-Sender-Via: office.oderland.com: authenticated_id: josjoh@oderland.se
X-Authenticated-Sender: office.oderland.com: josjoh@oderland.se

From: Josef Johansson <josef@oderland.se>


PCI/MSI: Re-add checks for skip masking MSI-X on Xen PV
    
commit fcacdfbef5a1 ("PCI/MSI: Provide a new set of mask and unmask
functions") introduce functions pci_msi_update_mask() and 
pci_msix_write_vector_ctrl() that is missing checks for
pci_msi_ignore_mask that exists in commit 446a98b19fd6 ("PCI/MSI: Use
new mask/unmask functions"). Add them back since it is
causing severe lockups in amdgpu drivers under Xen during boot.

As explained in commit 1a519dc7a73c ("PCI/MSI: Skip masking MSI-X
on Xen PV"), when running as Xen PV guest, masking MSI-X is a 
responsibility of the hypervisor.

Fixes: fcacdfbef5a1 ("PCI/MSI: Provide a new set of mask and unmask
functions")
Suggested-by: Jason Andryuk <jandryuk@gmail.com>
Signed-off-by: Josef Johansson <josef@oderland.se>
---

v1
* commit log is not in the correct mood
* commit log has single quotes around the commits
* the information with what led up to the patch is lacking.

v2
* correct the mood
* correct the quotes
* add much more information.

Here I describe the current patch and what led up to it,
more on what led up to it below the first attached dmesg.

This patch solves a major issue with booting 5.15-rc1 under Xen
with amdgpu drivers. Specifically Lenovo P14s Gen 1, AMD 4750U.

During boot around when I unluck the disk the first entry of
'Fence fallback timer expired' occur, the laptop is mostly useless.

After a while the WARN_ON trace shows up and the boot process starts
again, until it again gets stuck. This pattern repeats until X boots,
after that point it's kind of ok to work in.
If I try to switch to console the same process happens.

My solution to this was at first bisecting and finding 
commit 446a98b19fd6 ("PCI/MSI: Use new mask/unmask functions") series,
reverting this commit made the boot fast again with no lockups.

Later on I tried to apply pci=nomsi as a kernel argument and that
worked fine as well, letting me compile the kernel without the revert.

I have to note that this is my first commit and PCI/MSI area is
not my area of expertise. I tried to mimic what was
obviously missing between the aforementioned commits. There may be
better ways to solve this problem, or other places to put the checks.
Should desc->msi_attrib.is_virtual be checked? It is not checked in
'commit 1a519dc7a73c ("PCI/MSI: Skip masking MSI-X on Xen PV")'

If there's anything I can try out, I'd be happy to assist.

The important bits from dmesg, with debug-configs on.

Oct 11 22:32:00 dom0 kernel: Linux version 5.15.0-1.fc32.qubes.x86_64
(user@compiler) (gcc (GCC) 10.3.1 20210422 (Red Hat 10.3.1-1), GNU ld
version 2.34-6.fc32) #14 SMP Mon Oct 11 20:12:00 UTC 2021

Oct 11 22:32:00 dom0 kernel: Command line: placeholder
root=/dev/mapper/qubes_dom0-root ro
rd.luks.uuid=luks-c8f1f8e3-a5e7-4697-b01e-b104f5a0eedb
rd.lvm.lv=qubes_dom0/root rd.lvm.lv=qubes_dom0/swap
plymouth.ignore-serial-consoles rd.driver.pre=btrfs
rd.driver.blacklist=pcspkr

[snip]

Oct 11 22:32:04 dom0 kernel: amdgpu 0000:07:00.0: [drm] fb0: amdgpu
frame buffer device
Oct 11 22:32:04 dom0 kernel: amdgpu 0000:07:00.0: amdgpu: ring gfx uses
VM inv eng 0 on hub 0
Oct 11 22:32:04 dom0 kernel: amdgpu 0000:07:00.0: amdgpu: ring
comp_1.0.0 uses VM inv eng 1 on hub 0
Oct 11 22:32:04 dom0 kernel: amdgpu 0000:07:00.0: amdgpu: ring
comp_1.1.0 uses VM inv eng 4 on hub 0
Oct 11 22:32:04 dom0 kernel: amdgpu 0000:07:00.0: amdgpu: ring
comp_1.2.0 uses VM inv eng 5 on hub 0
Oct 11 22:32:04 dom0 kernel: amdgpu 0000:07:00.0: amdgpu: ring
comp_1.3.0 uses VM inv eng 6 on hub 0
Oct 11 22:32:04 dom0 kernel: amdgpu 0000:07:00.0: amdgpu: ring
comp_1.0.1 uses VM inv eng 7 on hub 0
Oct 11 22:32:04 dom0 kernel: amdgpu 0000:07:00.0: amdgpu: ring
comp_1.1.1 uses VM inv eng 8 on hub 0
Oct 11 22:32:04 dom0 kernel: amdgpu 0000:07:00.0: amdgpu: ring
comp_1.2.1 uses VM inv eng 9 on hub 0
Oct 11 22:32:04 dom0 kernel: amdgpu 0000:07:00.0: amdgpu: ring
comp_1.3.1 uses VM inv eng 10 on hub 0
Oct 11 22:32:04 dom0 kernel: amdgpu 0000:07:00.0: amdgpu: ring kiq_2.1.0
uses VM inv eng 11 on hub 0
Oct 11 22:32:04 dom0 kernel: amdgpu 0000:07:00.0: amdgpu: ring sdma0
uses VM inv eng 0 on hub 1
Oct 11 22:32:04 dom0 kernel: amdgpu 0000:07:00.0: amdgpu: ring vcn_dec
uses VM inv eng 1 on hub 1
Oct 11 22:32:04 dom0 kernel: amdgpu 0000:07:00.0: amdgpu: ring vcn_enc0
uses VM inv eng 4 on hub 1
Oct 11 22:32:04 dom0 kernel: amdgpu 0000:07:00.0: amdgpu: ring vcn_enc1
uses VM inv eng 5 on hub 1
Oct 11 22:32:04 dom0 kernel: amdgpu 0000:07:00.0: amdgpu: ring jpeg_dec
uses VM inv eng 6 on hub 1
Oct 11 22:32:04 dom0 kernel: [drm] Initialized amdgpu 3.42.0 20150101
for 0000:07:00.0 on minor 0

[snip]

Oct 11 22:32:06 dom0 kernel: [drm] Fence fallback timer expired on ring gfx
Oct 11 22:32:07 dom0 kernel: [drm] Fence fallback timer expired on ring
comp_1.0.0
Oct 11 22:32:07 dom0 kernel: [drm] Fence fallback timer expired on ring
comp_1.1.0
Oct 11 22:32:08 dom0 kernel: [drm] Fence fallback timer expired on ring
comp_1.2.0
Oct 11 22:32:08 dom0 kernel: [drm] Fence fallback timer expired on ring
comp_1.3.0
Oct 11 22:32:09 dom0 kernel: [drm] Fence fallback timer expired on ring
comp_1.0.1
Oct 11 22:32:09 dom0 kernel: [drm] Fence fallback timer expired on ring
comp_1.1.1
Oct 11 22:32:10 dom0 kernel: [drm] Fence fallback timer expired on ring
comp_1.2.1
Oct 11 22:32:10 dom0 kernel: [drm] Fence fallback timer expired on ring
comp_1.3.1
Oct 11 22:32:11 dom0 kernel: [drm] Fence fallback timer expired on ring
sdma0
Oct 11 22:32:11 dom0 kernel: [drm] Fence fallback timer expired on ring
vcn_dec
Oct 11 22:32:12 dom0 kernel: [drm] Fence fallback timer expired on ring
vcn_enc0
Oct 11 22:32:12 dom0 kernel: amdgpu 0000:07:00.0: [drm] *ERROR* Sending
link address failed with -5
Oct 11 22:32:12 dom0 kernel: [drm] Fence fallback timer expired on ring
vcn_enc1
Oct 11 22:32:13 dom0 kernel: [drm] Fence fallback timer expired on ring
jpeg_dec
Oct 11 22:32:14 dom0 kernel: [drm:drm_atomic_helper_wait_for_flip_done
[drm_kms_helper]] *ERROR* [CRTC:67:crtc-0] flip_done timed out
[snip]

Oct 11 22:32:37 dom0 kernel: [drm:drm_crtc_commit_wait [drm]] *ERROR*
flip_done timed out
Oct 11 22:32:37 dom0 kernel:
[drm:drm_atomic_helper_wait_for_dependencies [drm_kms_helper]] *ERROR*
[CRTC:67:crtc-0] commit wait timed out
Oct 11 22:32:47 dom0 kernel: [drm:drm_crtc_commit_wait [drm]] *ERROR*
flip_done timed out
Oct 11 22:32:47 dom0 kernel:
[drm:drm_atomic_helper_wait_for_dependencies [drm_kms_helper]] *ERROR*
[CONNECTOR:78:eDP-1] commit wait timed out
Oct 11 22:32:57 dom0 kernel: [drm:drm_crtc_commit_wait [drm]] *ERROR*
flip_done timed out
Oct 11 22:32:57 dom0 kernel:
[drm:drm_atomic_helper_wait_for_dependencies [drm_kms_helper]] *ERROR*
[PLANE:55:plane-3] commit wait timed out
Oct 11 22:32:57 dom0 kernel: ------------[ cut here ]------------
Oct 11 22:32:57 dom0 kernel: WARNING: CPU: 5 PID: 1425 at
drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:8689
amdgpu_dm_commit_planes+0x98c/0x9a0 [amdgpu]
Oct 11 22:32:57 dom0 kernel: Modules linked in: intel_rapl_msr wmi_bmof
intel_rapl_common pcspkr uvcvideo videobuf2_vmalloc videobuf2_memops
joydev videobuf2_v4l2 k10temp videobuf2_common videodev sp5100_tco mc
i2c_piix4 iwlwifi cfg80211 thinkpad_acpi platform_profile ipmi_devintf
ledtrig_audio ipmi_msghandler snd r8169 ucsi_acpi soundcore typec_ucsi
rfkill typec wmi video i2c_scmi fuse xenfs ip_tables dm_thin_pool
dm_persistent_data dm_bio_prison dm_crypt trusted asn1_encoder
hid_multitouch amdgpu crct10dif_pclmul crc32_pclmul crc32c_intel
gpu_sched i2c_algo_bit drm_ttm_helper sdhci_pci ghash_clmulni_intel ttm
cqhci drm_kms_helper serio_raw cec sdhci ccp xhci_pci xhci_pci_renesas
xhci_hcd drm nvme mmc_core ehci_pci ehci_hcd nvme_core
xen_acpi_processor xen_privcmd xen_pciback xen_blkback xen_gntalloc
xen_gntdev xen_evtchn uinput
Oct 11 22:32:57 dom0 kernel: CPU: 5 PID: 1425 Comm: setfont Tainted:
G        W        --------- ---  5.15.0-1.fc32.qubes.x86_64 #14
Oct 11 22:32:57 dom0 kernel: Hardware name: LENOVO
20Y1S02400/20Y1S02400, BIOS R1BET65W(1.34 ) 06/17/2021
Oct 11 22:32:57 dom0 kernel: RIP:
e030:amdgpu_dm_commit_planes+0x98c/0x9a0 [amdgpu]
Oct 11 22:32:57 dom0 kernel: Code: 8b 45 b0 48 c7 c7 a2 bc 8c c0 4c 89
55 88 8b b0 80 05 00 00 e8 e5 04 be ff 4c 8b 55 88 0f b6 55 ab 49 8b 72
08 e9 53 fa ff ff <0f> 0b e9 e2 fe ff ff e8 78 e4 82 c1 0f 1f 84 00 00
00 00 00 0f 1f
Oct 11 22:32:57 dom0 kernel: RSP: e02b:ffffc900403e7698 EFLAGS: 00010002
Oct 11 22:32:57 dom0 kernel: RAX: ffff888110500210 RBX: 00000000000010ac
RCX: 00000000000021e8
Oct 11 22:32:57 dom0 kernel: RDX: ffff88813f418e40 RSI: ffff888110500450
RDI: ffff88810ddf0f30
Oct 11 22:32:57 dom0 kernel: RBP: ffffc900403e7758 R08: 0000000000000002
R09: 00000000000c04d8
Oct 11 22:32:57 dom0 kernel: R10: 0000000000000000 R11: 0000000000080000
R12: ffff888110500210
Oct 11 22:32:57 dom0 kernel: R13: ffff88810d35e800 R14: ffff88810dee8cc0
R15: ffff88810ddada00
Oct 11 22:32:57 dom0 kernel: FS:  00007005ac91c580(0000)
GS:ffff88813f400000(0000) knlGS:0000000000000000
Oct 11 22:32:57 dom0 kernel: CS:  10000e030 DS: 0000 ES: 0000 CR0:
0000000080050033
Oct 11 22:32:57 dom0 kernel: CR2: 000073c449584d48 CR3: 0000000104974000
CR4: 0000000000050660
Oct 11 22:32:57 dom0 kernel: Call Trace:
Oct 11 22:32:57 dom0 kernel:  amdgpu_dm_atomic_commit_tail+0xbb2/0x1200
[amdgpu]
Oct 11 22:32:57 dom0 kernel:  commit_tail+0x94/0x130 [drm_kms_helper]
Oct 11 22:32:57 dom0 kernel:  drm_atomic_helper_commit+0x136/0x160
[drm_kms_helper]
Oct 11 22:32:57 dom0 kernel: 
drm_client_modeset_commit_atomic+0x249/0x290 [drm]
Oct 11 22:32:57 dom0 kernel:  drm_client_modeset_commit_locked+0x58/0x80
[drm]
Oct 11 22:32:57 dom0 kernel:  drm_fb_helper_pan_display+0x9b/0x110
[drm_kms_helper]
Oct 11 22:32:57 dom0 kernel:  fb_pan_display+0x8f/0x110
Oct 11 22:32:57 dom0 kernel:  bit_update_start+0x1a/0x40
Oct 11 22:32:57 dom0 kernel:  fbcon_switch+0x357/0x500
Oct 11 22:32:57 dom0 kernel:  redraw_screen+0xe9/0x230
Oct 11 22:32:57 dom0 kernel:  fbcon_do_set_font+0x170/0x190
Oct 11 22:32:57 dom0 kernel:  con_font_op+0x156/0x250
Oct 11 22:32:57 dom0 kernel:  ? do_anonymous_page+0x1ec/0x3b0
Oct 11 22:32:57 dom0 kernel:  ? _copy_from_user+0x45/0x80
Oct 11 22:32:57 dom0 kernel:  vt_k_ioctl+0x1b7/0x630
Oct 11 22:32:57 dom0 kernel:  vt_ioctl+0x7d/0x660
Oct 11 22:32:57 dom0 kernel:  tty_ioctl+0x354/0x810
Oct 11 22:32:57 dom0 kernel:  ? __lock_release+0x181/0x2d0
Oct 11 22:32:57 dom0 kernel:  ? ktime_get_coarse_real_ts64+0xe/0x50
Oct 11 22:32:57 dom0 kernel:  ?
lockdep_hardirqs_on_prepare.part.0+0xbf/0x140
Oct 11 22:32:57 dom0 kernel:  ?
seqcount_lockdep_reader_access.constprop.0+0x84/0x90
Oct 11 22:32:57 dom0 kernel:  __x64_sys_ioctl+0x83/0xb0
Oct 11 22:32:57 dom0 kernel:  do_syscall_64+0x3b/0x90
Oct 11 22:32:57 dom0 kernel:  entry_SYSCALL_64_after_hwframe+0x44/0xae
Oct 11 22:32:57 dom0 kernel: RIP: 0033:0x7005ac84917b
Oct 11 22:32:57 dom0 kernel: Code: 0f 1e fa 48 8b 05 1d ad 0c 00 64 c7
00 26 00 00 00 48 c7 c0 ff ff ff ff c3 66 0f 1f 44 00 00 f3 0f 1e fa b8
10 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d ed ac 0c 00 f7
d8 64 89 01 48
Oct 11 22:32:57 dom0 kernel: RSP: 002b:00007ffc7dee5a78 EFLAGS: 00000246
ORIG_RAX: 0000000000000010
Oct 11 22:32:57 dom0 kernel: RAX: ffffffffffffffda RBX: 0000000000000010
RCX: 00007005ac84917b
Oct 11 22:32:57 dom0 kernel: RDX: 00007ffc7dee5aa0 RSI: 0000000000004b72
RDI: 0000000000000003
Oct 11 22:32:57 dom0 kernel: RBP: 0000000000000200 R08: 0000000000000010
R09: 00007005ac914a40
Oct 11 22:32:57 dom0 kernel: R10: 0000000000000072 R11: 0000000000000246
R12: 0000000000000008
Oct 11 22:32:57 dom0 kernel: R13: 0000558e251606a0 R14: 0000000000000003
R15: 00007ffc7dee5aa0
Oct 11 22:32:57 dom0 kernel: irq event stamp: 13242
Oct 11 22:32:57 dom0 kernel: hardirqs last  enabled at (13241):
[<ffffffff81df81c7>] _raw_spin_unlock_irqrestore+0x37/0x40
Oct 11 22:32:57 dom0 kernel: hardirqs last disabled at (13242):
[<ffffffff81df7fc5>] _raw_spin_lock_irqsave+0x75/0x90
Oct 11 22:32:57 dom0 kernel: softirqs last  enabled at (12464):
[<ffffffff8103b972>] fpu_clone+0x72/0x200
Oct 11 22:32:57 dom0 kernel: softirqs last disabled at (12462):
[<ffffffff8103b905>] fpu_clone+0x5/0x200
Oct 11 22:32:57 dom0 kernel: ---[ end trace 6fec6583c02534af ]---
Oct 11 22:32:57 dom0 kernel: ------------[ cut here ]------------
Oct 11 22:32:57 dom0 kernel: WARNING: CPU: 5 PID: 1425 at
drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:8276
prepare_flip_isr+0x64/0x70 [amdgpu]
Oct 11 22:32:57 dom0 kernel: Modules linked in: intel_rapl_msr wmi_bmof
intel_rapl_common pcspkr uvcvideo videobuf2_vmalloc videobuf2_memops
joydev videobuf2_v4l2 k10temp videobuf2_common videodev sp5100_tco mc
i2c_piix4 iwlwifi cfg80211 thinkpad_acpi platform_profile ipmi_devintf
ledtrig_audio ipmi_msghandler snd r8169 ucsi_acpi soundcore typec_ucsi
rfkill typec wmi video i2c_scmi fuse xenfs ip_tables dm_thin_pool
dm_persistent_data dm_bio_prison dm_crypt trusted asn1_encoder
hid_multitouch amdgpu crct10dif_pclmul crc32_pclmul crc32c_intel
gpu_sched i2c_algo_bit drm_ttm_helper sdhci_pci ghash_clmulni_intel ttm
cqhci drm_kms_helper serio_raw cec sdhci ccp xhci_pci xhci_pci_renesas
xhci_hcd drm nvme mmc_core ehci_pci ehci_hcd nvme_core
xen_acpi_processor xen_privcmd xen_pciback xen_blkback xen_gntalloc
xen_gntdev xen_evtchn uinput
Oct 11 22:32:57 dom0 kernel: CPU: 5 PID: 1425 Comm: setfont Tainted:
G        W        --------- ---  5.15.0-1.fc32.qubes.x86_64 #14
Oct 11 22:32:57 dom0 kernel: Hardware name: LENOVO
20Y1S02400/20Y1S02400, BIOS R1BET65W(1.34 ) 06/17/2021
Oct 11 22:32:57 dom0 kernel: RIP: e030:prepare_flip_isr+0x64/0x70 [amdgpu]
Oct 11 22:32:57 dom0 kernel: Code: 00 48 c7 80 38 01 00 00 00 00 00 00
66 90 c3 8b 97 80 05 00 00 48 c7 c6 d8 65 89 c0 48 c7 c7 d8 fa a1 c0 e9
0e ed 1f c1 0f 0b <0f> 0b eb b4 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00
41 57 41 56 41
Oct 11 22:32:57 dom0 kernel: RSP: e02b:ffffc900403e7690 EFLAGS: 00010082
Oct 11 22:32:57 dom0 kernel: RAX: 0000000000000001 RBX: 00000000000010ac
RCX: 00000000000021e8
Oct 11 22:32:57 dom0 kernel: RDX: ffff88813f418e40 RSI: ffff888110500450
RDI: ffff88810d35e800
Oct 11 22:32:57 dom0 kernel: RBP: ffffc900403e7758 R08: 0000000000000002
R09: 00000000000c04d8
Oct 11 22:32:57 dom0 kernel: R10: 0000000000000000 R11: 0000000000080000
R12: ffff888110500210
Oct 11 22:32:57 dom0 kernel: R13: ffff88810d35e800 R14: ffff88810dee8cc0
R15: ffff88810ddada00
Oct 11 22:32:57 dom0 kernel: FS:  00007005ac91c580(0000)
GS:ffff88813f400000(0000) knlGS:0000000000000000
Oct 11 22:32:57 dom0 kernel: CS:  10000e030 DS: 0000 ES: 0000 CR0:
0000000080050033
Oct 11 22:32:57 dom0 kernel: CR2: 000073c449584d48 CR3: 0000000104974000
CR4: 0000000000050660
Oct 11 22:32:57 dom0 kernel: Call Trace:
Oct 11 22:32:57 dom0 kernel:  amdgpu_dm_commit_planes+0x87d/0x9a0 [amdgpu]
Oct 11 22:32:57 dom0 kernel:  amdgpu_dm_atomic_commit_tail+0xbb2/0x1200
[amdgpu]
Oct 11 22:32:57 dom0 kernel:  commit_tail+0x94/0x130 [drm_kms_helper]
Oct 11 22:32:57 dom0 kernel:  drm_atomic_helper_commit+0x136/0x160
[drm_kms_helper]
Oct 11 22:32:57 dom0 kernel: 
drm_client_modeset_commit_atomic+0x249/0x290 [drm]
Oct 11 22:32:57 dom0 kernel:  drm_client_modeset_commit_locked+0x58/0x80
[drm]
Oct 11 22:32:57 dom0 kernel:  drm_fb_helper_pan_display+0x9b/0x110
[drm_kms_helper]
Oct 11 22:32:57 dom0 kernel:  fb_pan_display+0x8f/0x110
Oct 11 22:32:57 dom0 kernel:  bit_update_start+0x1a/0x40
Oct 11 22:32:57 dom0 kernel:  fbcon_switch+0x357/0x500
Oct 11 22:32:57 dom0 kernel:  redraw_screen+0xe9/0x230
Oct 11 22:32:57 dom0 kernel:  fbcon_do_set_font+0x170/0x190
Oct 11 22:32:57 dom0 kernel:  con_font_op+0x156/0x250
Oct 11 22:32:57 dom0 kernel:  ? do_anonymous_page+0x1ec/0x3b0
Oct 11 22:32:57 dom0 kernel:  ? _copy_from_user+0x45/0x80
Oct 11 22:32:57 dom0 kernel:  vt_k_ioctl+0x1b7/0x630
Oct 11 22:32:57 dom0 kernel:  vt_ioctl+0x7d/0x660
Oct 11 22:32:57 dom0 kernel:  tty_ioctl+0x354/0x810
Oct 11 22:32:57 dom0 kernel:  ? __lock_release+0x181/0x2d0
Oct 11 22:32:57 dom0 kernel:  ? ktime_get_coarse_real_ts64+0xe/0x50
Oct 11 22:32:57 dom0 kernel:  ?
lockdep_hardirqs_on_prepare.part.0+0xbf/0x140
Oct 11 22:32:57 dom0 kernel:  ?
seqcount_lockdep_reader_access.constprop.0+0x84/0x90
Oct 11 22:32:57 dom0 kernel:  __x64_sys_ioctl+0x83/0xb0
Oct 11 22:32:57 dom0 kernel:  do_syscall_64+0x3b/0x90
Oct 11 22:32:57 dom0 kernel:  entry_SYSCALL_64_after_hwframe+0x44/0xae
Oct 11 22:32:57 dom0 kernel: RIP: 0033:0x7005ac84917b
Oct 11 22:32:57 dom0 kernel: Code: 0f 1e fa 48 8b 05 1d ad 0c 00 64 c7
00 26 00 00 00 48 c7 c0 ff ff ff ff c3 66 0f 1f 44 00 00 f3 0f 1e fa b8
10 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d ed ac 0c 00 f7
d8 64 89 01 48
Oct 11 22:32:57 dom0 kernel: RSP: 002b:00007ffc7dee5a78 EFLAGS: 00000246
ORIG_RAX: 0000000000000010
Oct 11 22:32:57 dom0 kernel: RAX: ffffffffffffffda RBX: 0000000000000010
RCX: 00007005ac84917b
Oct 11 22:32:57 dom0 kernel: RDX: 00007ffc7dee5aa0 RSI: 0000000000004b72
RDI: 0000000000000003
Oct 11 22:32:57 dom0 kernel: RBP: 0000000000000200 R08: 0000000000000010
R09: 00007005ac914a40
Oct 11 22:32:57 dom0 kernel: R10: 0000000000000072 R11: 0000000000000246
R12: 0000000000000008
Oct 11 22:32:57 dom0 kernel: R13: 0000558e251606a0 R14: 0000000000000003
R15: 00007ffc7dee5aa0
Oct 11 22:32:57 dom0 kernel: irq event stamp: 13242
Oct 11 22:32:57 dom0 kernel: hardirqs last  enabled at (13241):
[<ffffffff81df81c7>] _raw_spin_unlock_irqrestore+0x37/0x40
Oct 11 22:32:57 dom0 kernel: hardirqs last disabled at (13242):
[<ffffffff81df7fc5>] _raw_spin_lock_irqsave+0x75/0x90
Oct 11 22:32:57 dom0 kernel: softirqs last  enabled at (12464):
[<ffffffff8103b972>] fpu_clone+0x72/0x200
Oct 11 22:32:57 dom0 kernel: softirqs last disabled at (12462):
[<ffffffff8103b905>] fpu_clone+0x5/0x200
Oct 11 22:32:57 dom0 kernel: ---[ end trace 6fec6583c02534b0 ]---
Oct 11 22:33:07 dom0 kernel: [drm:drm_atomic_helper_wait_for_flip_done
[drm_kms_helper]] *ERROR* [CRTC:67:crtc-0] flip_done timed out
Oct 11 22:33:18 dom0 kernel: [drm:drm_crtc_commit_wait [drm]] *ERROR*
flip_done timed out
Oct 11 22:33:18 dom0 kernel:
[drm:drm_atomic_helper_wait_for_dependencies [drm_kms_helper]] *ERROR*
[CRTC:67:crtc-0] commit wait timed out
Oct 11 22:33:28 dom0 kernel: [drm:drm_crtc_commit_wait [drm]] *ERROR*
flip_done timed out
Oct 11 22:33:28 dom0 kernel:
[drm:drm_atomic_helper_wait_for_dependencies [drm_kms_helper]] *ERROR*
[CONNECTOR:78:eDP-1] commit wait timed out
Oct 11 22:33:38 dom0 kernel: [drm:drm_crtc_commit_wait [drm]] *ERROR*
flip_done timed out
Oct 11 22:33:38 dom0 kernel:
[drm:drm_atomic_helper_wait_for_dependencies [drm_kms_helper]] *ERROR*
[PLANE:55:plane-3] commit wait timed out
Oct 11 22:33:38 dom0 kernel: ------------[ cut here ]------------
Oct 11 22:33:38 dom0 kernel: WARNING: CPU: 5 PID: 1427 at
drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:8689
amdgpu_dm_commit_planes+0x98c/0x9a0 [amdgpu]
Oct 11 22:33:38 dom0 kernel: Modules linked in: intel_rapl_msr wmi_bmof
intel_rapl_common pcspkr uvcvideo videobuf2_vmalloc videobuf2_memops
joydev videobuf2_v4l2 k10temp videobuf2_common videodev sp5100_tco mc
i2c_piix4 iwlwifi cfg80211 thinkpad_acpi platform_profile ipmi_devintf
ledtrig_audio ipmi_msghandler snd r8169 ucsi_acpi soundcore typec_ucsi
rfkill typec wmi video i2c_scmi fuse xenfs ip_tables dm_thin_pool
dm_persistent_data dm_bio_prison dm_crypt trusted asn1_encoder
hid_multitouch amdgpu crct10dif_pclmul crc32_pclmul crc32c_intel
gpu_sched i2c_algo_bit drm_ttm_helper sdhci_pci ghash_clmulni_intel ttm
cqhci drm_kms_helper serio_raw cec sdhci ccp xhci_pci xhci_pci_renesas
xhci_hcd drm nvme mmc_core ehci_pci ehci_hcd nvme_core
xen_acpi_processor xen_privcmd xen_pciback xen_blkback xen_gntalloc
xen_gntdev xen_evtchn uinput
Oct 11 22:33:38 dom0 kernel: CPU: 5 PID: 1427 Comm: setfont Tainted:
G        W        --------- ---  5.15.0-1.fc32.qubes.x86_64 #14
Oct 11 22:33:38 dom0 kernel: Hardware name: LENOVO
20Y1S02400/20Y1S02400, BIOS R1BET65W(1.34 ) 06/17/2021
Oct 11 22:33:38 dom0 kernel: RIP:
e030:amdgpu_dm_commit_planes+0x98c/0x9a0 [amdgpu]
Oct 11 22:33:38 dom0 kernel: Code: 8b 45 b0 48 c7 c7 a2 bc 8c c0 4c 89
55 88 8b b0 80 05 00 00 e8 e5 04 be ff 4c 8b 55 88 0f b6 55 ab 49 8b 72
08 e9 53 fa ff ff <0f> 0b e9 e2 fe ff ff e8 78 e4 82 c1 0f 1f 84 00 00
00 00 00 0f 1f
Oct 11 22:33:38 dom0 kernel: RSP: e02b:ffffc90041613698 EFLAGS: 00010002
Oct 11 22:33:38 dom0 kernel: RAX: ffff888110500210 RBX: 0000000000001a46
RCX: 00000000000021e8
Oct 11 22:33:38 dom0 kernel: RDX: ffff88813f418e40 RSI: ffff888110500450
RDI: ffff888106330f30
Oct 11 22:33:38 dom0 kernel: RBP: ffffc90041613758 R08: 0000000000000002
R09: 00000000000c04d8
Oct 11 22:33:38 dom0 kernel: R10: 0000000000000000 R11: 0000000000080000
R12: ffff888110500210
Oct 11 22:33:38 dom0 kernel: R13: ffff88810d35e800 R14: ffff88810c39c0c0
R15: ffff88810de78c00
Oct 11 22:33:38 dom0 kernel: FS:  0000723fc3d77580(0000)
GS:ffff88813f400000(0000) knlGS:0000000000000000
Oct 11 22:33:38 dom0 kernel: CS:  10000e030 DS: 0000 ES: 0000 CR0:
0000000080050033
Oct 11 22:33:38 dom0 kernel: CR2: 000070eb0f040520 CR3: 000000010aeaa000
CR4: 0000000000050660
Oct 11 22:33:38 dom0 kernel: Call Trace:
Oct 11 22:33:38 dom0 kernel:  amdgpu_dm_atomic_commit_tail+0xbb2/0x1200
[amdgpu]
Oct 11 22:33:38 dom0 kernel:  commit_tail+0x94/0x130 [drm_kms_helper]
Oct 11 22:33:38 dom0 kernel:  drm_atomic_helper_commit+0x136/0x160
[drm_kms_helper]
Oct 11 22:33:38 dom0 kernel: 
drm_client_modeset_commit_atomic+0x249/0x290 [drm]
Oct 11 22:33:38 dom0 kernel:  drm_client_modeset_commit_locked+0x58/0x80
[drm]
Oct 11 22:33:38 dom0 kernel:  drm_fb_helper_pan_display+0x9b/0x110
[drm_kms_helper]
Oct 11 22:33:38 dom0 kernel:  fb_pan_display+0x8f/0x110
Oct 11 22:33:38 dom0 kernel:  bit_update_start+0x1a/0x40
Oct 11 22:33:38 dom0 kernel:  fbcon_switch+0x357/0x500
Oct 11 22:33:38 dom0 kernel:  redraw_screen+0xe9/0x230
Oct 11 22:33:38 dom0 kernel:  fbcon_do_set_font+0x170/0x190
Oct 11 22:33:38 dom0 kernel:  con_font_op+0x156/0x250
Oct 11 22:33:38 dom0 kernel:  ? do_anonymous_page+0x1ec/0x3b0
Oct 11 22:33:38 dom0 kernel:  ? _copy_from_user+0x45/0x80
Oct 11 22:33:38 dom0 kernel:  vt_k_ioctl+0x1b7/0x630
Oct 11 22:33:38 dom0 kernel:  vt_ioctl+0x7d/0x660
Oct 11 22:33:38 dom0 kernel:  tty_ioctl+0x354/0x810
Oct 11 22:33:38 dom0 kernel:  ? __lock_release+0x181/0x2d0
Oct 11 22:33:38 dom0 kernel:  ? ktime_get_coarse_real_ts64+0xe/0x50
Oct 11 22:33:38 dom0 kernel:  ?
lockdep_hardirqs_on_prepare.part.0+0xbf/0x140
Oct 11 22:33:38 dom0 kernel:  ?
seqcount_lockdep_reader_access.constprop.0+0x84/0x90
Oct 11 22:33:38 dom0 kernel:  __x64_sys_ioctl+0x83/0xb0
Oct 11 22:33:38 dom0 kernel:  do_syscall_64+0x3b/0x90
Oct 11 22:33:38 dom0 kernel:  entry_SYSCALL_64_after_hwframe+0x44/0xae
Oct 11 22:33:38 dom0 kernel: RIP: 0033:0x723fc3ca417b
Oct 11 22:33:38 dom0 kernel: Code: 0f 1e fa 48 8b 05 1d ad 0c 00 64 c7
00 26 00 00 00 48 c7 c0 ff ff ff ff c3 66 0f 1f 44 00 00 f3 0f 1e fa b8
10 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d ed ac 0c 00 f7
d8 64 89 01 48
Oct 11 22:33:38 dom0 kernel: RSP: 002b:00007ffc0f3b06a8 EFLAGS: 00000246
ORIG_RAX: 0000000000000010
Oct 11 22:33:38 dom0 kernel: RAX: ffffffffffffffda RBX: 0000000000000010
RCX: 0000723fc3ca417b
Oct 11 22:33:38 dom0 kernel: RDX: 00007ffc0f3b06d0 RSI: 0000000000004b72
RDI: 0000000000000003
Oct 11 22:33:38 dom0 kernel: RBP: 0000000000000200 R08: 0000000000000010
R09: 0000723fc3d6fa40
Oct 11 22:33:38 dom0 kernel: R10: 0000000000000072 R11: 0000000000000246
R12: 0000000000000008
Oct 11 22:33:38 dom0 kernel: R13: 00005750656256a0 R14: 0000000000000003
R15: 00007ffc0f3b06d0
Oct 11 22:33:38 dom0 kernel: irq event stamp: 9426
Oct 11 22:33:38 dom0 kernel: hardirqs last  enabled at (9425):
[<ffffffff81df81c7>] _raw_spin_unlock_irqrestore+0x37/0x40
Oct 11 22:33:38 dom0 kernel: hardirqs last disabled at (9426):
[<ffffffff81df7fc5>] _raw_spin_lock_irqsave+0x75/0x90
Oct 11 22:33:38 dom0 kernel: softirqs last  enabled at (8654):
[<ffffffff8103b972>] fpu_clone+0x72/0x200
Oct 11 22:33:38 dom0 kernel: softirqs last disabled at (8652):
[<ffffffff8103b905>] fpu_clone+0x5/0x200
Oct 11 22:33:38 dom0 kernel: ---[ end trace 6fec6583c02534b1 ]---
Oct 11 22:33:38 dom0 kernel: ------------[ cut here ]------------
Oct 11 22:33:38 dom0 kernel: WARNING: CPU: 5 PID: 1427 at
drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:8276
prepare_flip_isr+0x64/0x70 [amdgpu]
Oct 11 22:33:38 dom0 kernel: Modules linked in: intel_rapl_msr wmi_bmof
intel_rapl_common pcspkr uvcvideo videobuf2_vmalloc videobuf2_memops
joydev videobuf2_v4l2 k10temp videobuf2_common videodev sp5100_tco mc
i2c_piix4 iwlwifi cfg80211 thinkpad_acpi platform_profile ipmi_devintf
ledtrig_audio ipmi_msghandler snd r8169 ucsi_acpi soundcore typec_ucsi
rfkill typec wmi video i2c_scmi fuse xenfs ip_tables dm_thin_pool
dm_persistent_data dm_bio_prison dm_crypt trusted asn1_encoder
hid_multitouch amdgpu crct10dif_pclmul crc32_pclmul crc32c_intel
gpu_sched i2c_algo_bit drm_ttm_helper sdhci_pci ghash_clmulni_intel ttm
cqhci drm_kms_helper serio_raw cec sdhci ccp xhci_pci xhci_pci_renesas
xhci_hcd drm nvme mmc_core ehci_pci ehci_hcd nvme_core
xen_acpi_processor xen_privcmd xen_pciback xen_blkback xen_gntalloc
xen_gntdev xen_evtchn uinput
Oct 11 22:33:38 dom0 kernel: CPU: 5 PID: 1427 Comm: setfont Tainted:
G        W        --------- ---  5.15.0-1.fc32.qubes.x86_64 #14
Oct 11 22:33:38 dom0 kernel: Hardware name: LENOVO
20Y1S02400/20Y1S02400, BIOS R1BET65W(1.34 ) 06/17/2021
Oct 11 22:33:38 dom0 kernel: RIP: e030:prepare_flip_isr+0x64/0x70 [amdgpu]
Oct 11 22:33:38 dom0 kernel: Code: 00 48 c7 80 38 01 00 00 00 00 00 00
66 90 c3 8b 97 80 05 00 00 48 c7 c6 d8 65 89 c0 48 c7 c7 d8 fa a1 c0 e9
0e ed 1f c1 0f 0b <0f> 0b eb b4 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00
41 57 41 56 41
Oct 11 22:33:38 dom0 kernel: RSP: e02b:ffffc90041613690 EFLAGS: 00010086
Oct 11 22:33:38 dom0 kernel: RAX: 0000000000000001 RBX: 0000000000001a46
RCX: 00000000000021e8
Oct 11 22:33:38 dom0 kernel: RDX: ffff88813f418e40 RSI: ffff888110500450
RDI: ffff88810d35e800
Oct 11 22:33:38 dom0 kernel: RBP: ffffc90041613758 R08: 0000000000000002
R09: 00000000000c04d8
Oct 11 22:33:38 dom0 kernel: R10: 0000000000000000 R11: 0000000000080000
R12: ffff888110500210
Oct 11 22:33:38 dom0 kernel: R13: ffff88810d35e800 R14: ffff88810c39c0c0
R15: ffff88810de78c00
Oct 11 22:33:38 dom0 kernel: FS:  0000723fc3d77580(0000)
GS:ffff88813f400000(0000) knlGS:0000000000000000
Oct 11 22:33:38 dom0 kernel: CS:  10000e030 DS: 0000 ES: 0000 CR0:
0000000080050033
Oct 11 22:33:38 dom0 kernel: CR2: 000070eb0f040520 CR3: 000000010aeaa000
CR4: 0000000000050660
Oct 11 22:33:38 dom0 kernel: Call Trace:
Oct 11 22:33:38 dom0 kernel:  amdgpu_dm_commit_planes+0x87d/0x9a0 [amdgpu]
Oct 11 22:33:38 dom0 kernel:  amdgpu_dm_atomic_commit_tail+0xbb2/0x1200
[amdgpu]
Oct 11 22:33:38 dom0 kernel:  commit_tail+0x94/0x130 [drm_kms_helper]
Oct 11 22:33:38 dom0 kernel:  drm_atomic_helper_commit+0x136/0x160
[drm_kms_helper]
Oct 11 22:33:38 dom0 kernel: 
drm_client_modeset_commit_atomic+0x249/0x290 [drm]
Oct 11 22:33:38 dom0 kernel:  drm_client_modeset_commit_locked+0x58/0x80
[drm]
Oct 11 22:33:38 dom0 kernel:  drm_fb_helper_pan_display+0x9b/0x110
[drm_kms_helper]
Oct 11 22:33:38 dom0 kernel:  fb_pan_display+0x8f/0x110
Oct 11 22:33:38 dom0 kernel:  bit_update_start+0x1a/0x40
Oct 11 22:33:38 dom0 kernel:  fbcon_switch+0x357/0x500
Oct 11 22:33:38 dom0 kernel:  redraw_screen+0xe9/0x230
Oct 11 22:33:38 dom0 kernel:  fbcon_do_set_font+0x170/0x190
Oct 11 22:33:38 dom0 kernel:  con_font_op+0x156/0x250
Oct 11 22:33:38 dom0 kernel:  ? do_anonymous_page+0x1ec/0x3b0
Oct 11 22:33:38 dom0 kernel:  ? _copy_from_user+0x45/0x80
Oct 11 22:33:38 dom0 kernel:  vt_k_ioctl+0x1b7/0x630
Oct 11 22:33:38 dom0 kernel:  vt_ioctl+0x7d/0x660
Oct 11 22:33:38 dom0 kernel:  tty_ioctl+0x354/0x810
Oct 11 22:33:38 dom0 kernel:  ? __lock_release+0x181/0x2d0
Oct 11 22:33:38 dom0 kernel:  ? ktime_get_coarse_real_ts64+0xe/0x50
Oct 11 22:33:38 dom0 kernel:  ?
lockdep_hardirqs_on_prepare.part.0+0xbf/0x140
Oct 11 22:33:38 dom0 kernel:  ?
seqcount_lockdep_reader_access.constprop.0+0x84/0x90
Oct 11 22:33:38 dom0 kernel:  __x64_sys_ioctl+0x83/0xb0
Oct 11 22:33:38 dom0 kernel:  do_syscall_64+0x3b/0x90
Oct 11 22:33:38 dom0 kernel:  entry_SYSCALL_64_after_hwframe+0x44/0xae
Oct 11 22:33:38 dom0 kernel: RIP: 0033:0x723fc3ca417b
Oct 11 22:33:38 dom0 kernel: Code: 0f 1e fa 48 8b 05 1d ad 0c 00 64 c7
00 26 00 00 00 48 c7 c0 ff ff ff ff c3 66 0f 1f 44 00 00 f3 0f 1e fa b8
10 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d ed ac 0c 00 f7
d8 64 89 01 48
Oct 11 22:33:38 dom0 kernel: RSP: 002b:00007ffc0f3b06a8 EFLAGS: 00000246
ORIG_RAX: 0000000000000010
Oct 11 22:33:38 dom0 kernel: RAX: ffffffffffffffda RBX: 0000000000000010
RCX: 0000723fc3ca417b
Oct 11 22:33:38 dom0 kernel: RDX: 00007ffc0f3b06d0 RSI: 0000000000004b72
RDI: 0000000000000003
Oct 11 22:33:38 dom0 kernel: RBP: 0000000000000200 R08: 0000000000000010
R09: 0000723fc3d6fa40
Oct 11 22:33:38 dom0 kernel: R10: 0000000000000072 R11: 0000000000000246
R12: 0000000000000008
Oct 11 22:33:38 dom0 kernel: R13: 00005750656256a0 R14: 0000000000000003
R15: 00007ffc0f3b06d0
Oct 11 22:33:38 dom0 kernel: irq event stamp: 9426
Oct 11 22:33:38 dom0 kernel: hardirqs last  enabled at (9425):
[<ffffffff81df81c7>] _raw_spin_unlock_irqrestore+0x37/0x40
Oct 11 22:33:38 dom0 kernel: hardirqs last disabled at (9426):
[<ffffffff81df7fc5>] _raw_spin_lock_irqsave+0x75/0x90
Oct 11 22:33:38 dom0 kernel: softirqs last  enabled at (8654):
[<ffffffff8103b972>] fpu_clone+0x72/0x200
Oct 11 22:33:38 dom0 kernel: softirqs last disabled at (8652):
[<ffffffff8103b905>] fpu_clone+0x5/0x200
Oct 11 22:33:38 dom0 kernel: ---[ end trace 6fec6583c02534b2 ]---
Oct 11 22:33:48 dom0 kernel: [drm:drm_atomic_helper_wait_for_flip_done
[drm_kms_helper]] *ERROR* [CRTC:67:crtc-0] flip_done timed out
Oct 11 22:33:49 dom0 kernel: EXT4-fs (nvme0n1p2): mounted filesystem
with ordered data mode. Opts: discard. Quota mode: none.
Oct 11 22:33:56 dom0 kernel: [drm] Fence fallback timer expired on ring
sdma0
Oct 11 22:33:59 dom0 kernel: usb 6-1: USB disconnect, device number 2
Oct 11 22:34:06 dom0 kernel: [drm:drm_crtc_commit_wait [drm]] *ERROR*
flip_done timed out
Oct 11 22:34:06 dom0 kernel:
[drm:drm_atomic_helper_wait_for_dependencies [drm_kms_helper]] *ERROR*
[CRTC:67:crtc-0] commit wait timed out
Oct 11 22:34:17 dom0 kernel: [drm:drm_crtc_commit_wait [drm]] *ERROR*
flip_done timed out
Oct 11 22:34:17 dom0 kernel:
[drm:drm_atomic_helper_wait_for_dependencies [drm_kms_helper]] *ERROR*
[CONNECTOR:78:eDP-1] commit wait timed out
Oct 11 22:34:27 dom0 kernel: [drm:drm_crtc_commit_wait [drm]] *ERROR*
flip_done timed out
Oct 11 22:34:27 dom0 kernel:
[drm:drm_atomic_helper_wait_for_dependencies [drm_kms_helper]] *ERROR*
[PLANE:55:plane-3] commit wait timed out
Oct 11 22:34:27 dom0 kernel: ------------[ cut here ]------------
Oct 11 22:34:27 dom0 kernel: WARNING: CPU: 7 PID: 2636 at
drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:8689
amdgpu_dm_commit_planes+0x98c/0x9a0 [amdgpu]
Oct 11 22:34:27 dom0 kernel: Modules linked in: nf_tables nfnetlink vfat
fat intel_rapl_msr wmi_bmof intel_rapl_common pcspkr uvcvideo
videobuf2_vmalloc videobuf2_memops joydev videobuf2_v4l2 k10temp
videobuf2_common videodev sp5100_tco mc i2c_piix4 iwlwifi cfg80211
thinkpad_acpi platform_profile ipmi_devintf ledtrig_audio
ipmi_msghandler snd r8169 ucsi_acpi soundcore typec_ucsi rfkill typec
wmi video i2c_scmi fuse xenfs ip_tables dm_thin_pool dm_persistent_data
dm_bio_prison dm_crypt trusted asn1_encoder hid_multitouch amdgpu
crct10dif_pclmul crc32_pclmul crc32c_intel gpu_sched i2c_algo_bit
drm_ttm_helper sdhci_pci ghash_clmulni_intel ttm cqhci drm_kms_helper
serio_raw cec sdhci ccp xhci_pci xhci_pci_renesas xhci_hcd drm nvme
mmc_core ehci_pci ehci_hcd nvme_core xen_acpi_processor xen_privcmd
xen_pciback xen_blkback xen_gntalloc xen_gntdev xen_evtchn uinput
Oct 11 22:34:27 dom0 kernel: CPU: 7 PID: 2636 Comm: Xorg Tainted:
G        W        --------- ---  5.15.0-1.fc32.qubes.x86_64 #14
Oct 11 22:34:27 dom0 kernel: Hardware name: LENOVO
20Y1S02400/20Y1S02400, BIOS R1BET65W(1.34 ) 06/17/2021
Oct 11 22:34:27 dom0 kernel: RIP:
e030:amdgpu_dm_commit_planes+0x98c/0x9a0 [amdgpu]
Oct 11 22:34:27 dom0 kernel: Code: 8b 45 b0 48 c7 c7 a2 bc 8c c0 4c 89
55 88 8b b0 80 05 00 00 e8 e5 04 be ff 4c 8b 55 88 0f b6 55 ab 49 8b 72
08 e9 53 fa ff ff <0f> 0b e9 e2 fe ff ff e8 78 e4 82 c1 0f 1f 84 00 00
00 00 00 0f 1f
Oct 11 22:34:27 dom0 kernel: RSP: e02b:ffffc90042d8f960 EFLAGS: 00010002
Oct 11 22:34:27 dom0 kernel: RAX: ffff888110500210 RBX: 00000000000025ad
RCX: 00000000000021e8
Oct 11 22:34:27 dom0 kernel: RDX: ffff88813f818e40 RSI: ffff888110500450
RDI: ffff888104cec3f0
Oct 11 22:34:27 dom0 kernel: RBP: ffffc90042d8fa20 R08: 0000000000000002
R09: 00000000000c04d8
Oct 11 22:34:27 dom0 kernel: R10: 0000000000000000 R11: 0000000000080000
R12: ffff888110500210
Oct 11 22:34:27 dom0 kernel: R13: ffff88810d35e800 R14: ffff88810a677cc0
R15: ffff88810a6d5c00
Oct 11 22:34:27 dom0 kernel: FS:  00007f896429fa40(0000)
GS:ffff88813f800000(0000) knlGS:0000000000000000
Oct 11 22:34:27 dom0 kernel: CS:  10000e030 DS: 0000 ES: 0000 CR0:
0000000080050033
Oct 11 22:34:27 dom0 kernel: CR2: 00007cc75690e000 CR3: 00000001062e6000
CR4: 0000000000050660
Oct 11 22:34:27 dom0 kernel: Call Trace:
Oct 11 22:34:27 dom0 kernel:  amdgpu_dm_atomic_commit_tail+0xbb2/0x1200
[amdgpu]
Oct 11 22:34:27 dom0 kernel:  commit_tail+0x94/0x130 [drm_kms_helper]
Oct 11 22:34:27 dom0 kernel:  drm_atomic_helper_commit+0x136/0x160
[drm_kms_helper]
Oct 11 22:34:27 dom0 kernel: 
drm_client_modeset_commit_atomic+0x249/0x290 [drm]
Oct 11 22:34:27 dom0 kernel:  drm_client_modeset_commit_locked+0x58/0x80
[drm]
Oct 11 22:34:27 dom0 kernel:  drm_client_modeset_commit+0x24/0x40 [drm]
Oct 11 22:34:27 dom0 kernel:  drm_fb_helper_lastclose+0x45/0x80
[drm_kms_helper]
Oct 11 22:34:27 dom0 kernel:  amdgpu_driver_lastclose_kms+0xa/0x10 [amdgpu]
Oct 11 22:34:27 dom0 kernel:  drm_release+0xe1/0x110 [drm]
Oct 11 22:34:27 dom0 kernel:  __fput+0x9d/0x260
Oct 11 22:34:27 dom0 kernel:  task_work_run+0x5c/0x90
Oct 11 22:34:27 dom0 kernel:  exit_to_user_mode_loop+0x1ce/0x1e0
Oct 11 22:34:27 dom0 kernel:  exit_to_user_mode_prepare+0xe3/0x150
Oct 11 22:34:27 dom0 kernel:  syscall_exit_to_user_mode+0x27/0x60
Oct 11 22:34:27 dom0 kernel:  do_syscall_64+0x48/0x90
Oct 11 22:34:27 dom0 kernel:  entry_SYSCALL_64_after_hwframe+0x44/0xae
Oct 11 22:34:27 dom0 kernel: RIP: 0033:0x7f896486ba17
Oct 11 22:34:27 dom0 kernel: Code: 00 00 f7 d8 64 89 02 48 c7 c0 ff ff
ff ff eb b7 0f 1f 00 f3 0f 1e fa 64 8b 04 25 18 00 00 00 85 c0 75 10 b8
03 00 00 00 0f 05 <48> 3d 00 f0 ff ff 77 41 c3 48 83 ec 18 89 7c 24 0c
e8 f3 fb ff ff
Oct 11 22:34:27 dom0 kernel: RSP: 002b:00007fff9083b528 EFLAGS: 00000246
ORIG_RAX: 0000000000000003
Oct 11 22:34:27 dom0 kernel: RAX: 0000000000000000 RBX: 00005f57edbd09f0
RCX: 00007f896486ba17
Oct 11 22:34:27 dom0 kernel: RDX: 00005f57edbb1010 RSI: 00005f57edbd0b60
RDI: 0000000000000014
Oct 11 22:34:27 dom0 kernel: RBP: 0000000000000014 R08: 0000000000000000
R09: 00007f896484fa40
Oct 11 22:34:27 dom0 kernel: R10: 00005f57eba9c302 R11: 0000000000000246
R12: 00005f57edbd0b60
Oct 11 22:34:27 dom0 kernel: R13: 00005f57edbd0a30 R14: 0000000000000000
R15: 0000000000000000
Oct 11 22:34:27 dom0 kernel: irq event stamp: 51614
Oct 11 22:34:27 dom0 kernel: hardirqs last  enabled at (51613):
[<ffffffff81df81c7>] _raw_spin_unlock_irqrestore+0x37/0x40
Oct 11 22:34:27 dom0 kernel: hardirqs last disabled at (51614):
[<ffffffff81df7fc5>] _raw_spin_lock_irqsave+0x75/0x90
Oct 11 22:34:27 dom0 kernel: softirqs last  enabled at (51264):
[<ffffffff820002f9>] __do_softirq+0x2f9/0x428
Oct 11 22:34:27 dom0 kernel: softirqs last disabled at (51257):
[<ffffffff810f50c0>] __irq_exit_rcu+0xd0/0x100
Oct 11 22:34:27 dom0 kernel: ---[ end trace 6fec6583c02534b3 ]---
Oct 11 22:34:27 dom0 kernel: ------------[ cut here ]------------
Oct 11 22:34:27 dom0 kernel: WARNING: CPU: 7 PID: 2636 at
drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:8276
prepare_flip_isr+0x64/0x70 [amdgpu]
Oct 11 22:34:27 dom0 kernel: Modules linked in: nf_tables nfnetlink vfat
fat intel_rapl_msr wmi_bmof intel_rapl_common pcspkr uvcvideo
videobuf2_vmalloc videobuf2_memops joydev videobuf2_v4l2 k10temp
videobuf2_common videodev sp5100_tco mc i2c_piix4 iwlwifi cfg80211
thinkpad_acpi platform_profile ipmi_devintf ledtrig_audio
ipmi_msghandler snd r8169 ucsi_acpi soundcore typec_ucsi rfkill typec
wmi video i2c_scmi fuse xenfs ip_tables dm_thin_pool dm_persistent_data
dm_bio_prison dm_crypt trusted asn1_encoder hid_multitouch amdgpu
crct10dif_pclmul crc32_pclmul crc32c_intel gpu_sched i2c_algo_bit
drm_ttm_helper sdhci_pci ghash_clmulni_intel ttm cqhci drm_kms_helper
serio_raw cec sdhci ccp xhci_pci xhci_pci_renesas xhci_hcd drm nvme
mmc_core ehci_pci ehci_hcd nvme_core xen_acpi_processor xen_privcmd
xen_pciback xen_blkback xen_gntalloc xen_gntdev xen_evtchn uinput
Oct 11 22:34:27 dom0 kernel: CPU: 7 PID: 2636 Comm: Xorg Tainted:
G        W        --------- ---  5.15.0-1.fc32.qubes.x86_64 #14
Oct 11 22:34:27 dom0 kernel: Hardware name: LENOVO
20Y1S02400/20Y1S02400, BIOS R1BET65W(1.34 ) 06/17/2021
Oct 11 22:34:27 dom0 kernel: RIP: e030:prepare_flip_isr+0x64/0x70 [amdgpu]
Oct 11 22:34:27 dom0 kernel: Code: 00 48 c7 80 38 01 00 00 00 00 00 00
66 90 c3 8b 97 80 05 00 00 48 c7 c6 d8 65 89 c0 48 c7 c7 d8 fa a1 c0 e9
0e ed 1f c1 0f 0b <0f> 0b eb b4 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00
41 57 41 56 41
Oct 11 22:34:27 dom0 kernel: RSP: e02b:ffffc90042d8f958 EFLAGS: 00010082
Oct 11 22:34:27 dom0 kernel: RAX: 0000000000000001 RBX: 00000000000025ad
RCX: 00000000000021e8
Oct 11 22:34:27 dom0 kernel: RDX: ffff88813f818e40 RSI: ffff888110500450
RDI: ffff88810d35e800
Oct 11 22:34:27 dom0 kernel: RBP: ffffc90042d8fa20 R08: 0000000000000002
R09: 00000000000c04d8
Oct 11 22:34:27 dom0 kernel: R10: 0000000000000000 R11: 0000000000080000
R12: ffff888110500210
Oct 11 22:34:27 dom0 kernel: R13: ffff88810d35e800 R14: ffff88810a677cc0
R15: ffff88810a6d5c00
Oct 11 22:34:27 dom0 kernel: FS:  00007f896429fa40(0000)
GS:ffff88813f800000(0000) knlGS:0000000000000000
Oct 11 22:34:27 dom0 kernel: CS:  10000e030 DS: 0000 ES: 0000 CR0:
0000000080050033
Oct 11 22:34:27 dom0 kernel: CR2: 00007cc75690e000 CR3: 00000001062e6000
CR4: 0000000000050660
Oct 11 22:34:27 dom0 kernel: Call Trace:
Oct 11 22:34:27 dom0 kernel:  amdgpu_dm_commit_planes+0x87d/0x9a0 [amdgpu]
Oct 11 22:34:27 dom0 kernel:  amdgpu_dm_atomic_commit_tail+0xbb2/0x1200
[amdgpu]
Oct 11 22:34:27 dom0 kernel:  commit_tail+0x94/0x130 [drm_kms_helper]
Oct 11 22:34:27 dom0 kernel:  drm_atomic_helper_commit+0x136/0x160
[drm_kms_helper]
Oct 11 22:34:27 dom0 kernel: 
drm_client_modeset_commit_atomic+0x249/0x290 [drm]
Oct 11 22:34:27 dom0 kernel:  drm_client_modeset_commit_locked+0x58/0x80
[drm]
Oct 11 22:34:27 dom0 kernel:  drm_client_modeset_commit+0x24/0x40 [drm]
Oct 11 22:34:27 dom0 kernel:  drm_fb_helper_lastclose+0x45/0x80
[drm_kms_helper]
Oct 11 22:34:27 dom0 kernel:  amdgpu_driver_lastclose_kms+0xa/0x10 [amdgpu]
Oct 11 22:34:27 dom0 kernel:  drm_release+0xe1/0x110 [drm]
Oct 11 22:34:27 dom0 kernel:  __fput+0x9d/0x260
Oct 11 22:34:27 dom0 kernel:  task_work_run+0x5c/0x90
Oct 11 22:34:27 dom0 kernel:  exit_to_user_mode_loop+0x1ce/0x1e0
Oct 11 22:34:27 dom0 kernel:  exit_to_user_mode_prepare+0xe3/0x150
Oct 11 22:34:27 dom0 kernel:  syscall_exit_to_user_mode+0x27/0x60
Oct 11 22:34:27 dom0 kernel:  do_syscall_64+0x48/0x90
Oct 11 22:34:27 dom0 kernel:  entry_SYSCALL_64_after_hwframe+0x44/0xae
Oct 11 22:34:27 dom0 kernel: RIP: 0033:0x7f896486ba17
Oct 11 22:34:27 dom0 kernel: Code: 00 00 f7 d8 64 89 02 48 c7 c0 ff ff
ff ff eb b7 0f 1f 00 f3 0f 1e fa 64 8b 04 25 18 00 00 00 85 c0 75 10 b8
03 00 00 00 0f 05 <48> 3d 00 f0 ff ff 77 41 c3 48 83 ec 18 89 7c 24 0c
e8 f3 fb ff ff
Oct 11 22:34:27 dom0 kernel: RSP: 002b:00007fff9083b528 EFLAGS: 00000246
ORIG_RAX: 0000000000000003
Oct 11 22:34:27 dom0 kernel: RAX: 0000000000000000 RBX: 00005f57edbd09f0
RCX: 00007f896486ba17
Oct 11 22:34:27 dom0 kernel: RDX: 00005f57edbb1010 RSI: 00005f57edbd0b60
RDI: 0000000000000014
Oct 11 22:34:27 dom0 kernel: RBP: 0000000000000014 R08: 0000000000000000
R09: 00007f896484fa40
Oct 11 22:34:27 dom0 kernel: R10: 00005f57eba9c302 R11: 0000000000000246
R12: 00005f57edbd0b60
Oct 11 22:34:27 dom0 kernel: R13: 00005f57edbd0a30 R14: 0000000000000000
R15: 0000000000000000
Oct 11 22:34:27 dom0 kernel: irq event stamp: 51614
Oct 11 22:34:27 dom0 kernel: hardirqs last  enabled at (51613):
[<ffffffff81df81c7>] _raw_spin_unlock_irqrestore+0x37/0x40
Oct 11 22:34:27 dom0 kernel: hardirqs last disabled at (51614):
[<ffffffff81df7fc5>] _raw_spin_lock_irqsave+0x75/0x90
Oct 11 22:34:27 dom0 kernel: softirqs last  enabled at (51264):
[<ffffffff820002f9>] __do_softirq+0x2f9/0x428
Oct 11 22:34:27 dom0 kernel: softirqs last disabled at (51257):
[<ffffffff810f50c0>] __irq_exit_rcu+0xd0/0x100
Oct 11 22:34:27 dom0 kernel: ---[ end trace 6fec6583c02534b4 ]---
Oct 11 22:34:37 dom0 kernel: [drm:drm_atomic_helper_wait_for_flip_done
[drm_kms_helper]] *ERROR* [CRTC:67:crtc-0] flip_done timed out
Oct 11 22:34:38 dom0 kernel: [drm] Fence fallback timer expired on ring
sdma0
Oct 11 22:34:48 dom0 kernel: [drm:drm_crtc_commit_wait [drm]] *ERROR*
flip_done timed out
Oct 11 22:34:48 dom0 kernel:
[drm:drm_atomic_helper_wait_for_dependencies [drm_kms_helper]] *ERROR*
[CRTC:67:crtc-0] commit wait timed out
Oct 11 22:34:58 dom0 kernel: [drm:drm_crtc_commit_wait [drm]] *ERROR*
flip_done timed out
Oct 11 22:34:58 dom0 kernel:
[drm:drm_atomic_helper_wait_for_dependencies [drm_kms_helper]] *ERROR*
[CONNECTOR:78:eDP-1] commit wait timed out
Oct 11 22:35:08 dom0 kernel: [drm:drm_crtc_commit_wait [drm]] *ERROR*
flip_done timed out
Oct 11 22:35:08 dom0 kernel:
[drm:drm_atomic_helper_wait_for_dependencies [drm_kms_helper]] *ERROR*
[PLANE:55:plane-3] commit wait timed out
Oct 11 22:35:08 dom0 kernel: ------------[ cut here ]------------

Full log with drm.debug=1 can be be found at the original issue
https://gitlab.freedesktop.org/drm/amd/-/issues/1715
https://gitlab.freedesktop.org/drm/amd/uploads/c91af638cb8fb5f3c25130f1edabb47e/dmesg


My original goal was to solve suspend/resume, that is why I'm testing
out v5.15. During that investigation I have found that:
* v5.15-rc2+ with pci=nomsi is quite resilient to crashing amdgpu drivers
* Compiling with CONFIG_HSA_AMD=n makes a difference, I don't believe Xen
  has proper support for HSA anyhow.
* Compiling with CONFIG_AMD_PMC=y makes a difference, apparently qiurks
  are enabled when not compiling as a module.

I did a last honest try with v5.15-rc5 with this patch applied to get more
data and I did find some more. The original problem show itself, but since
amdgpu actually describes their firmware commands now, it became less cryptic.

After this message the screen will be blank, I can still get passed the xscreensaver
but the screen is dead. With pci=nomsi applied I can after suspending the laptop
once more, get the screen back in order. This also occurs without starting X.

Oct 17 22:49:11 dom0 kernel: nvme 0000:01:00.0: saving config space at offset 0x38 (reading 0x0)
Oct 17 22:49:11 dom0 kernel: nvme 0000:01:00.0: saving config space at offset 0x3c (reading 0x1ff)
Oct 17 22:49:11 dom0 kernel: usb 4-4: reset full-speed USB device number 3 using xhci_hcd
Oct 17 22:49:11 dom0 kernel: nvme nvme0: 8/0/0 default/read/poll queues
Oct 17 22:49:11 dom0 kernel: usb 1-2: reset high-speed USB device number 2 using xhci_hcd
Oct 17 22:49:11 dom0 kernel: psmouse serio1: synaptics: queried max coordinates: x [..5678], y [..4694]
Oct 17 22:49:11 dom0 kernel: psmouse serio1: synaptics: queried min coordinates: x [1266..], y [1162..]
Oct 17 22:49:11 dom0 kernel: [drm] psp gfx command SETUP_TMR(0x5) failed and response status is (0x0)
Oct 17 22:49:11 dom0 kernel: [drm:psp_hw_start [amdgpu]] *ERROR* PSP load tmr failed!
Oct 17 22:49:11 dom0 kernel: [drm:psp_resume [amdgpu]] *ERROR* PSP resume failed
Oct 17 22:49:11 dom0 kernel: [drm:amdgpu_device_fw_loading [amdgpu]] *ERROR* resume of IP block <psp> failed -22
Oct 17 22:49:11 dom0 kernel: amdgpu 0000:07:00.0: amdgpu: amdgpu_device_ip_resume failed (-22).
Oct 17 22:49:11 dom0 kernel: PM: dpm_run_callback(): pci_pm_resume+0x0/0xe0 returns -22
Oct 17 22:49:11 dom0 kernel: amdgpu 0000:07:00.0: PM: failed to resume async: error -22
Oct 17 22:49:11 dom0 kernel: PM: resume devices took 2.422 seconds
Oct 17 22:49:11 dom0 kernel: OOM killer enabled.
Oct 17 22:49:11 dom0 kernel: Restarting tasks ... done.
Oct 17 22:49:11 dom0 kernel: PM: suspend exit

Since I also had _a lot_ of debug-flags applied I also got this neat deadlock

Oct 17 22:52:07 dom0 kernel: [Firmware Bug]: ACPI MWAIT C-state 0x0 not supported by HW (0x0)
Oct 17 22:52:07 dom0 kernel: ACPI: \_SB_.PLTF.C002: Found 3 idle states
Oct 17 22:52:07 dom0 kernel: ACPI: FW issue: working around C-state latencies out of order
Oct 17 22:52:07 dom0 kernel: CPU2 is up
Oct 17 22:52:07 dom0 kernel: ------------[ cut here ]------------
Oct 17 22:52:07 dom0 kernel: installing Xen timer for CPU 3
Oct 17 22:52:07 dom0 kernel: 
Oct 17 22:52:07 dom0 kernel: ======================================================
Oct 17 22:52:07 dom0 kernel: WARNING: possible circular locking dependency detected
Oct 17 22:52:07 dom0 kernel: 5.15.0-0.rc5.0.fc32.qubes.x86_64 #1 Tainted: G        W        --------- --- 
Oct 17 22:52:07 dom0 kernel: ------------------------------------------------------
Oct 17 22:52:07 dom0 kernel: kworker/2:0/11917 is trying to acquire lock:
Oct 17 22:52:07 dom0 kernel: ffffffff82962858 ((console_sem).lock){-...}-{2:2}, at: down_trylock+0xf/0x30
Oct 17 22:52:07 dom0 kernel: 
                             but task is already holding lock:
Oct 17 22:52:07 dom0 kernel: ffff8881406ab558 (&rq->__lock){-.-.}-{2:2}, at: raw_spin_rq_lock_nested+0x1e/0x80
Oct 17 22:52:07 dom0 kernel: 
                             which lock already depends on the new lock.
Oct 17 22:52:07 dom0 kernel: 
                             the existing dependency chain (in reverse order) is:
Oct 17 22:52:07 dom0 kernel: 
                             -> #2 (&rq->__lock){-.-.}-{2:2}:
Oct 17 22:52:07 dom0 kernel:        __lock_acquire+0x3a0/0x6b0
Oct 17 22:52:07 dom0 kernel:        lock_acquire+0xf5/0x300
Oct 17 22:52:07 dom0 kernel:        _raw_spin_lock_nested+0x2a/0x40
Oct 17 22:52:07 dom0 kernel:        raw_spin_rq_lock_nested+0x1e/0x80
Oct 17 22:52:07 dom0 kernel:        task_fork_fair+0x39/0x180
Oct 17 22:52:07 dom0 kernel:        sched_fork+0x115/0x290
Oct 17 22:52:07 dom0 kernel:        copy_process+0xd2e/0x2b80
Oct 17 22:52:07 dom0 kernel:        kernel_clone+0xa4/0x300
Oct 17 22:52:07 dom0 kernel:        kernel_thread+0x55/0x70
Oct 17 22:52:07 dom0 kernel:        rest_init+0x1e/0x280
Oct 17 22:52:07 dom0 kernel:        start_kernel+0x65d/0x69b
Oct 17 22:52:07 dom0 kernel:        xen_start_kernel+0x5fb/0x61c
Oct 17 22:52:07 dom0 kernel:        reset_early_page_tables+0x0/0x9d
Oct 17 22:52:07 dom0 kernel: 
                             -> #1 (&p->pi_lock){-.-.}-{2:2}:
Oct 17 22:52:07 dom0 kernel:        __lock_acquire+0x3a0/0x6b0
Oct 17 22:52:07 dom0 kernel:        lock_acquire+0xf5/0x300
Oct 17 22:52:07 dom0 kernel:        _raw_spin_lock_irqsave+0x48/0x60
Oct 17 22:52:07 dom0 kernel:        try_to_wake_up+0x53/0x5f0
Oct 17 22:52:07 dom0 kernel:        up+0x40/0x60
Oct 17 22:52:07 dom0 kernel:        __up_console_sem+0x56/0x70
Oct 17 22:52:07 dom0 kernel:        console_unlock+0x2ae/0x3c0
Oct 17 22:52:07 dom0 kernel:        vprintk_emit+0x141/0x160
Oct 17 22:52:07 dom0 kernel:        _printk+0x68/0x7f
Oct 17 22:52:07 dom0 kernel:        acpi_register_gsi_xen.cold+0x61/0x81
Oct 17 22:52:07 dom0 kernel:        acpi_pci_irq_enable+0xdd/0x240
Oct 17 22:52:07 dom0 kernel:        do_pci_enable_device+0x8a/0x110
Oct 17 22:52:07 dom0 kernel:        pci_enable_device_flags+0xcf/0x100
Oct 17 22:52:07 dom0 kernel:        nvme_pci_enable+0x28/0x1e0 [nvme]
Oct 17 22:52:07 dom0 kernel:        nvme_reset_work+0x61/0x490 [nvme]
Oct 17 22:52:07 dom0 kernel:        process_one_work+0x294/0x590
Oct 17 22:52:07 dom0 kernel:        worker_thread+0x49/0x310
Oct 17 22:52:07 dom0 kernel:        kthread+0x120/0x140
Oct 17 22:52:07 dom0 kernel:        ret_from_fork+0x22/0x30
Oct 17 22:52:07 dom0 kernel: 
                             -> #0 ((console_sem).lock){-...}-{2:2}:
Oct 17 22:52:07 dom0 kernel:        check_prev_add+0x8f/0xbf0
Oct 17 22:52:07 dom0 kernel:        validate_chain+0x38a/0x420
Oct 17 22:52:07 dom0 kernel:        __lock_acquire+0x3a0/0x6b0
Oct 17 22:52:07 dom0 kernel:        lock_acquire+0xf5/0x300
Oct 17 22:52:07 dom0 kernel:        _raw_spin_lock_irqsave+0x48/0x60
Oct 17 22:52:07 dom0 kernel:        down_trylock+0xf/0x30
Oct 17 22:52:07 dom0 kernel:        __down_trylock_console_sem+0x32/0xa0
Oct 17 22:52:07 dom0 kernel:        console_trylock_spinning+0x13/0x1e0
Oct 17 22:52:07 dom0 kernel:        vprintk_emit+0xa8/0x160
Oct 17 22:52:07 dom0 kernel:        _printk+0x68/0x7f
Oct 17 22:52:07 dom0 kernel:        __warn_printk+0x51/0x93
Oct 17 22:52:07 dom0 kernel:        __update_blocked_fair+0x4f4/0x510
Oct 17 22:52:07 dom0 kernel:        update_blocked_averages+0xe3/0x280
Oct 17 22:52:07 dom0 kernel:        newidle_balance+0x160/0x600
Oct 17 22:52:07 dom0 kernel:        pick_next_task_fair+0x39/0x3f0
Oct 17 22:52:07 dom0 kernel:        pick_next_task+0x4c/0xbb0
Oct 17 22:52:07 dom0 kernel:        __schedule+0x135/0x600
Oct 17 22:52:07 dom0 kernel:        schedule+0x59/0xc0
Oct 17 22:52:07 dom0 kernel:        worker_thread+0xb3/0x310
Oct 17 22:52:07 dom0 kernel:        kthread+0x120/0x140
Oct 17 22:52:07 dom0 kernel:        ret_from_fork+0x22/0x30
Oct 17 22:52:07 dom0 kernel: 
                             other info that might help us debug this:
Oct 17 22:52:07 dom0 kernel: Chain exists of:
                               (console_sem).lock --> &p->pi_lock --> &rq->__lock
Oct 17 22:52:07 dom0 kernel:  Possible unsafe locking scenario:
Oct 17 22:52:07 dom0 kernel:        CPU0                    CPU1
Oct 17 22:52:07 dom0 kernel:        ----                    ----
Oct 17 22:52:07 dom0 kernel:   lock(&rq->__lock);
Oct 17 22:52:07 dom0 kernel:                                lock(&p->pi_lock);
Oct 17 22:52:07 dom0 kernel:                                lock(&rq->__lock);
Oct 17 22:52:07 dom0 kernel:   lock((console_sem).lock);
Oct 17 22:52:07 dom0 kernel: 
                              *** DEADLOCK ***
Oct 17 22:52:07 dom0 kernel: 1 lock held by kworker/2:0/11917:
Oct 17 22:52:07 dom0 kernel:  #0: ffff8881406ab558 (&rq->__lock){-.-.}-{2:2}, at: raw_spin_rq_lock_nested+0x1e/0x80
Oct 17 22:52:07 dom0 kernel: 
                             stack backtrace:
Oct 17 22:52:07 dom0 kernel: CPU: 2 PID: 11917 Comm: kworker/2:0 Tainted: G        W        --------- ---  5.15.0-0.rc5.0.fc32.qubes.x86_64 #1
Oct 17 22:52:07 dom0 kernel: Hardware name: LENOVO 20Y1S02400/20Y1S02400, BIOS R1BET65W(1.34 ) 06/17/2021
Oct 17 22:52:07 dom0 kernel: Workqueue:  0x0 (events)
Oct 17 22:52:07 dom0 kernel: Call Trace:
Oct 17 22:52:07 dom0 kernel:  dump_stack_lvl+0x57/0x72
Oct 17 22:52:07 dom0 kernel:  check_noncircular+0x10a/0x120
Oct 17 22:52:07 dom0 kernel:  check_prev_add+0x8f/0xbf0
Oct 17 22:52:07 dom0 kernel:  ? add_chain_cache+0x10d/0x2d0
Oct 17 22:52:07 dom0 kernel:  ? load_balance+0x2b0/0x7f0
Oct 17 22:52:07 dom0 kernel:  validate_chain+0x38a/0x420
Oct 17 22:52:07 dom0 kernel:  __lock_acquire+0x3a0/0x6b0
Oct 17 22:52:07 dom0 kernel:  lock_acquire+0xf5/0x300
Oct 17 22:52:07 dom0 kernel:  ? down_trylock+0xf/0x30
Oct 17 22:52:07 dom0 kernel:  ? vprintk_emit+0xa8/0x160
Oct 17 22:52:07 dom0 kernel:  _raw_spin_lock_irqsave+0x48/0x60
Oct 17 22:52:07 dom0 kernel:  ? down_trylock+0xf/0x30
Oct 17 22:52:07 dom0 kernel:  down_trylock+0xf/0x30
Oct 17 22:52:07 dom0 kernel:  ? vprintk_emit+0xa8/0x160
Oct 17 22:52:07 dom0 kernel:  __down_trylock_console_sem+0x32/0xa0
Oct 17 22:52:07 dom0 kernel:  console_trylock_spinning+0x13/0x1e0
Oct 17 22:52:07 dom0 kernel:  vprintk_emit+0xa8/0x160
Oct 17 22:52:07 dom0 kernel:  _printk+0x68/0x7f
Oct 17 22:52:07 dom0 kernel:  ? lock_is_held_type+0xa5/0x120
Oct 17 22:52:07 dom0 kernel:  __warn_printk+0x51/0x93
Oct 17 22:52:07 dom0 kernel:  ? lock_is_held_type+0xa5/0x120
Oct 17 22:52:07 dom0 kernel:  __update_blocked_fair+0x4f4/0x510
Oct 17 22:52:07 dom0 kernel:  update_blocked_averages+0xe3/0x280
Oct 17 22:52:07 dom0 kernel:  newidle_balance+0x160/0x600
Oct 17 22:52:07 dom0 kernel:  pick_next_task_fair+0x39/0x3f0
Oct 17 22:52:07 dom0 kernel:  pick_next_task+0x4c/0xbb0
Oct 17 22:52:07 dom0 kernel:  ? dequeue_task_fair+0xd1/0x4a0
Oct 17 22:52:07 dom0 kernel:  __schedule+0x135/0x600
Oct 17 22:52:07 dom0 kernel:  schedule+0x59/0xc0
Oct 17 22:52:07 dom0 kernel:  worker_thread+0xb3/0x310
Oct 17 22:52:07 dom0 kernel:  ? process_one_work+0x590/0x590
Oct 17 22:52:07 dom0 kernel:  kthread+0x120/0x140
Oct 17 22:52:07 dom0 kernel:  ? set_kthread_struct+0x40/0x40
Oct 17 22:52:07 dom0 kernel:  ret_from_fork+0x22/0x30
Oct 17 22:52:07 dom0 kernel: cfs_rq->avg.load_avg || cfs_rq->avg.util_avg || cfs_rq->avg.runnable_avg
Oct 17 22:52:07 dom0 kernel: WARNING: CPU: 2 PID: 11917 at kernel/sched/fair.c:3339 __update_blocked_fair+0x4f4/0x510
Oct 17 22:52:07 dom0 kernel: Modules linked in: snd_seq_dummy snd_hrtimer snd_seq snd_seq_device snd_timer nf_tables nfnetlink vfat fat intel_rapl_msr think_lmi firmware_attributes_class wmi_bmof intel_rapl_common uvcvideo pcspkr videobuf2_vmalloc videobuf2_memops joydev videobuf2_v4l2 videobuf2_common sp5100_tco k10temp i2c_piix4 videodev mc iwlwifi cfg80211 ipmi_devintf ipmi_msghandler thinkpad_acpi platform_profile ledtrig_audio rfkill snd r8169 soundcore video ucsi_acpi i2c_scmi typec_ucsi wmi typec fuse xenfs ip_tables dm_thin_pool dm_persistent_data dm_bio_prison dm_crypt trusted asn1_encoder hid_multitouch amdgpu crct10dif_pclmul crc32_pclmul crc32c_intel ghash_clmulni_intel gpu_sched i2c_algo_bit serio_raw nvme ehci_pci drm_ttm_helper sdhci_pci ttm cqhci ehci_hcd drm_kms_helper sdhci nvme_core xhci_pci cec xhci_pci_renesas ccp mmc_core drm xhci_hcd xen_acpi_processor xen_privcmd xen_pciback xen_blkback xen_gntalloc xen_gntdev xen_evtchn uinput
Oct 17 22:52:07 dom0 kernel: CPU: 2 PID: 11917 Comm: kworker/2:0 Tainted: G        W        --------- ---  5.15.0-0.rc5.0.fc32.qubes.x86_64 #1
Oct 17 22:52:07 dom0 kernel: Hardware name: LENOVO 20Y1S02400/20Y1S02400, BIOS R1BET65W(1.34 ) 06/17/2021
Oct 17 22:52:07 dom0 kernel: Workqueue:  0x0 (events)
Oct 17 22:52:07 dom0 kernel: RIP: e030:__update_blocked_fair+0x4f4/0x510
Oct 17 22:52:07 dom0 kernel: Code: 01 00 00 48 89 90 08 0a 00 00 e9 e6 fc ff ff 45 31 ff e9 70 ff ff ff 48 c7 c7 c8 dc 5f 82 c6 05 a7 5f ab 01 01 e8 73 1c c4 00 <0f> 0b 41 8b 86 78 01 00 00 e9 a5 fc ff ff 66 66 2e 0f 1f 84 00 00
Oct 17 22:52:07 dom0 kernel: RSP: e02b:ffffc90040627cc0 EFLAGS: 00010082
Oct 17 22:52:07 dom0 kernel: RAX: 0000000000000000 RBX: ffff8881406abdb8 RCX: ffff888140698dd8
Oct 17 22:52:07 dom0 kernel: RDX: 00000000ffffffd8 RSI: 0000000000000027 RDI: ffff888140698dd0
Oct 17 22:52:07 dom0 kernel: RBP: ffff8881406ab780 R08: 0000000000000001 R09: 0000000000000000
Oct 17 22:52:07 dom0 kernel: R10: 0000000000000000 R11: ffffffffffffffff R12: 0000000000000010
Oct 17 22:52:07 dom0 kernel: R13: ffff8881406abf38 R14: ffff8881406ab600 R15: 0000011e9f271699
Oct 17 22:52:07 dom0 kernel: FS:  0000000000000000(0000) GS:ffff888140680000(0000) knlGS:0000000000000000
Oct 17 22:52:07 dom0 kernel: CS:  10000e030 DS: 0000 ES: 0000 CR0: 0000000080050033
Oct 17 22:52:07 dom0 kernel: CR2: 00006300c5f02360 CR3: 0000000002826000 CR4: 0000000000050660
Oct 17 22:52:07 dom0 kernel: Call Trace:
Oct 17 22:52:07 dom0 kernel:  update_blocked_averages+0xe3/0x280
Oct 17 22:52:07 dom0 kernel:  newidle_balance+0x160/0x600
Oct 17 22:52:07 dom0 kernel:  pick_next_task_fair+0x39/0x3f0
Oct 17 22:52:07 dom0 kernel:  pick_next_task+0x4c/0xbb0
Oct 17 22:52:07 dom0 kernel:  ? dequeue_task_fair+0xd1/0x4a0
Oct 17 22:52:07 dom0 kernel:  __schedule+0x135/0x600
Oct 17 22:52:07 dom0 kernel:  schedule+0x59/0xc0
Oct 17 22:52:07 dom0 kernel:  worker_thread+0xb3/0x310
Oct 17 22:52:07 dom0 kernel:  ? process_one_work+0x590/0x590
Oct 17 22:52:07 dom0 kernel:  kthread+0x120/0x140
Oct 17 22:52:07 dom0 kernel:  ? set_kthread_struct+0x40/0x40
Oct 17 22:52:07 dom0 kernel:  ret_from_fork+0x22/0x30
Oct 17 22:52:07 dom0 kernel: irq event stamp: 526
Oct 17 22:52:07 dom0 kernel: hardirqs last  enabled at (525): [<ffffffff81dfd104>] _raw_spin_unlock_irq+0x24/0x40
Oct 17 22:52:07 dom0 kernel: hardirqs last disabled at (526): [<ffffffff81df513a>] __schedule+0x3aa/0x600
Oct 17 22:52:07 dom0 kernel: softirqs last  enabled at (420): [<ffffffff811e69f1>] css_free_rwork_fn+0x71/0x350
Oct 17 22:52:07 dom0 kernel: softirqs last disabled at (418): [<ffffffff811e69d6>] css_free_rwork_fn+0x56/0x350
Oct 17 22:52:07 dom0 kernel: ---[ end trace 276648458889a290 ]---
Oct 17 22:52:07 dom0 kernel: cpu 3 spinlock event irq 79
Oct 17 22:52:07 dom0 kernel: [Firmware Bug]: ACPI MWAIT C-state 0x0 not supported by HW (0x0)
Oct 17 22:52:07 dom0 kernel: ACPI: \_SB_.PLTF.C003: Found 3 idle states
Oct 17 22:52:07 dom0 kernel: ACPI: FW issue: working around C-state latencies out of order
Oct 17 22:52:07 dom0 kernel: CPU3 is up
Oct 17 22:52:07 dom0 kernel: installing Xen timer for CPU 4
Oct 17 22:52:07 dom0 kernel: cpu 4 spinlock event irq 85
Oct 17 22:52:07 dom0 kernel: [Firmware Bug]: ACPI MWAIT C-state 0x0 not supported by HW (0x0)
Oct 17 22:52:07 dom0 kernel: ACPI: \_SB_.PLTF.C004: Found 3 idle states
Oct 17 22:52:07 dom0 kernel: ACPI: FW issue: working around C-state latencies out of order
 
Found in full:
https://gitlab.freedesktop.org/drm/amd/uploads/478771dfe18ff303f072fcac9a3da16b/setup-tmr-failed.dmesg


When booting without Xen things just work in v5.15. Here's a fresh lspci and dmesg
from a working boot without Xen:

https://gitlab.freedesktop.org/drm/amd/uploads/81059ddc533de1c7cf21fa98b76f217d/without-xen.lspci
https://gitlab.freedesktop.org/drm/amd/uploads/f3df205cbd9e9e8b769c35f374f20f9d/without-xen.dmesg

Previous mailing list discussion:
https://lore.kernel.org/linux-pci/CAKf6xpvGyCKVHsvauP54=0j10fxis4XiiqBNWH+1cpkbtt_QJw@mail.gmail.com/


diff --git a/drivers/pci/msi.c b/drivers/pci/msi.c
index 0099a00af361..355b791e382f 100644
--- a/drivers/pci/msi.c
+++ b/drivers/pci/msi.c
@@ -148,6 +148,9 @@ static noinline void pci_msi_update_mask(struct msi_desc *desc, u32 clear, u32 s
 	raw_spinlock_t *lock = &desc->dev->msi_lock;
 	unsigned long flags;
 
+	if (pci_msi_ignore_mask || desc->msi_attrib.is_virtual)
+		return;
+
 	raw_spin_lock_irqsave(lock, flags);
 	desc->msi_mask &= ~clear;
 	desc->msi_mask |= set;
@@ -181,6 +184,9 @@ static void pci_msix_write_vector_ctrl(struct msi_desc *desc, u32 ctrl)
 {
 	void __iomem *desc_addr = pci_msix_desc_addr(desc);
 
+	if (pci_msi_ignore_mask || desc->msi_attrib.is_virtual)
+		return;
+
 	writel(ctrl, desc_addr + PCI_MSIX_ENTRY_VECTOR_CTRL);
 }

--
2.31.1



From xen-devel-bounces@lists.xenproject.org Tue Oct 19 23:14:35 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Oct 2021 23:14:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.213515.371735 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcyJI-0005bK-0e; Tue, 19 Oct 2021 23:14:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 213515.371735; Tue, 19 Oct 2021 23:14:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcyJH-0005bD-SQ; Tue, 19 Oct 2021 23:14:19 +0000
Received: by outflank-mailman (input) for mailman id 213515;
 Tue, 19 Oct 2021 23:14:18 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=f1bC=PH=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1mcyJF-0005b7-RP
 for xen-devel@lists.xenproject.org; Tue, 19 Oct 2021 23:14:18 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id f1d0e151-506d-4f96-a0b8-19c485ea7b4c;
 Tue, 19 Oct 2021 23:14:16 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id 23A6260C4B;
 Tue, 19 Oct 2021 23:14:15 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f1d0e151-506d-4f96-a0b8-19c485ea7b4c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1634685255;
	bh=tOmn0olH/oeHcAtqPlzaITjq0Z12V6pTovw7fR0ubhk=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=CVzqty6WOpjaDNsKdfuxPBKPflwcXH23yoQ6O+WqaMaMGqgwrVOcDvLG+GiN/d8rb
	 I6UEkBWvfrkAyYsDc+1twFagsdSIdL2QODvmntEkImNUxnZOyDpzI04JrPB0kBM/fk
	 9fPgJ2/4qASBuXM2J4UH7KjWHPXPOxlazD1oWGjPN9+uSLW3l6SW7PA9m0lSr6vFFT
	 tDMRKWNiA+Eoz8nqWYJQJ6ExBSm2vG7onjhzu3svUptoSIpPiSth1fzZiNPkrcmt7R
	 iwvfbbZbwnVwDw1XQzSFS4o8n10i6ufUMoXBFX1Em+nK6mIj06uXPJ4zdF1G514M9z
	 8Myvm+In4LM3w==
Date: Tue, 19 Oct 2021 16:14:14 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Bertrand Marquis <bertrand.marquis@arm.com>
cc: xen-devel@lists.xenproject.org, iwj@xenproject.org, 
    Oleksandr_Andrushchenko@epam.com, 
    Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, 
    Jan Beulich <jbeulich@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>, 
    =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= <roger.pau@citrix.com>, 
    Wei Liu <wl@xen.org>, Paul Durrant <paul@xen.org>
Subject: Re: [PATCH v2 1/1] xen/pci: Install vpci handlers on x86 and fix
 exit path
In-Reply-To: <d788dcce9e344a39f6761633f0e96774ab42c2aa.1634659471.git.bertrand.marquis@arm.com>
Message-ID: <alpine.DEB.2.21.2110191538440.21467@sstabellini-ThinkPad-T480s>
References: <cover.1634659471.git.bertrand.marquis@arm.com> <d788dcce9e344a39f6761633f0e96774ab42c2aa.1634659471.git.bertrand.marquis@arm.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Tue, 19 Oct 2021, Bertrand Marquis wrote:
> Xen might not be able to discover at boot time all devices or some devices
> might appear after specific actions from dom0.
> In this case dom0 can use the PHYSDEVOP_pci_device_add to signal some
> PCI devices to Xen.
> As those devices where not known from Xen before, the vpci handlers must
> be properly installed during pci_device_add for x86 PVH Dom0, in the
> same way as what is done currently on arm (where Xen does not detect PCI
> devices but relies on Dom0 to declare them all the time).
> 
> So this patch is removing the ifdef protecting the call to
> vpci_add_handlers and the comment which was arm specific.
> 
> vpci_add_handlers is called on during pci_device_add which can be called
> at runtime through hypercall physdev_op.
> Remove __hwdom_init as the call is not limited anymore to hardware
> domain init and fix linker script to only keep vpci_array in rodata
> section.
> 
> Add missing vpci handlers cleanup during pci_device_remove and in case
> of error with iommu during pci_device_add.
> 
> Add empty static inline for vpci_remove_device when CONFIG_VPCI is not
> defined.
> 
> Fixes: d59168dc05 ("xen/arm: Enable the existing x86 virtual PCI support
> for ARM")
> Suggested-by: Jan Beulich <jbeulich@suse.com>
> Signed-off-by: Bertrand Marquis <bertrand.marquis@arm.com>

Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>


> ---
> Changes in v2
> - add comment suggested by Jan on top of vpci_add_handlers call
> - merge the 3 patches of the serie in one patch and renamed it
> - fix x86 and arm linker script to only keep vpci_array in rodata and
> only when CONFIG_VPCI is set.
> ---
>  xen/arch/arm/xen.lds.S        | 9 +--------
>  xen/arch/x86/xen.lds.S        | 9 +--------
>  xen/drivers/passthrough/pci.c | 8 ++++----
>  xen/drivers/vpci/vpci.c       | 2 +-
>  xen/include/xen/vpci.h        | 2 ++
>  5 files changed, 9 insertions(+), 21 deletions(-)
> 
> diff --git a/xen/arch/arm/xen.lds.S b/xen/arch/arm/xen.lds.S
> index b773f91f1c..08016948ab 100644
> --- a/xen/arch/arm/xen.lds.S
> +++ b/xen/arch/arm/xen.lds.S
> @@ -60,7 +60,7 @@ SECTIONS
>         *(.proc.info)
>         __proc_info_end = .;
>  
> -#if defined(CONFIG_HAS_VPCI) && defined(CONFIG_LATE_HWDOM)
> +#ifdef CONFIG_HAS_VPCI
>         . = ALIGN(POINTER_ALIGN);
>         __start_vpci_array = .;
>         *(SORT(.data.vpci.*))
> @@ -189,13 +189,6 @@ SECTIONS
>         *(.init_array)
>         *(SORT(.init_array.*))
>         __ctors_end = .;
> -
> -#if defined(CONFIG_HAS_VPCI) && !defined(CONFIG_LATE_HWDOM)
> -       . = ALIGN(POINTER_ALIGN);
> -       __start_vpci_array = .;
> -       *(SORT(.data.vpci.*))
> -       __end_vpci_array = .;
> -#endif
>    } :text
>    __init_end_efi = .;
>    . = ALIGN(STACK_SIZE);
> diff --git a/xen/arch/x86/xen.lds.S b/xen/arch/x86/xen.lds.S
> index 11b1da2154..87e344d4dd 100644
> --- a/xen/arch/x86/xen.lds.S
> +++ b/xen/arch/x86/xen.lds.S
> @@ -134,7 +134,7 @@ SECTIONS
>         *(.ex_table.pre)
>         __stop___pre_ex_table = .;
>  
> -#if defined(CONFIG_HAS_VPCI) && defined(CONFIG_LATE_HWDOM)
> +#ifdef CONFIG_HAS_VPCI
>         . = ALIGN(POINTER_ALIGN);
>         __start_vpci_array = .;
>         *(SORT(.data.vpci.*))
> @@ -247,13 +247,6 @@ SECTIONS
>         *(.init_array)
>         *(SORT(.init_array.*))
>         __ctors_end = .;
> -
> -#if defined(CONFIG_HAS_VPCI) && !defined(CONFIG_LATE_HWDOM)
> -       . = ALIGN(POINTER_ALIGN);
> -       __start_vpci_array = .;
> -       *(SORT(.data.vpci.*))
> -       __end_vpci_array = .;
> -#endif
>    } PHDR(text)
>  
>    . = ALIGN(SECTION_ALIGN);
> diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci.c
> index 35e0190796..8928a1c07d 100644
> --- a/xen/drivers/passthrough/pci.c
> +++ b/xen/drivers/passthrough/pci.c
> @@ -756,10 +756,9 @@ int pci_add_device(u16 seg, u8 bus, u8 devfn,
>      if ( !pdev->domain )
>      {
>          pdev->domain = hardware_domain;
> -#ifdef CONFIG_ARM
>          /*
> -         * On ARM PCI devices discovery will be done by Dom0. Add vpci handler
> -         * when Dom0 inform XEN to add the PCI devices in XEN.
> +         * For devices not discovered by Xen during boot, add vPCI handlers
> +         * when Dom0 first informs Xen about such devices.
>           */
>          ret = vpci_add_handlers(pdev);
>          if ( ret )
> @@ -768,10 +767,10 @@ int pci_add_device(u16 seg, u8 bus, u8 devfn,
>              pdev->domain = NULL;
>              goto out;
>          }
> -#endif
>          ret = iommu_add_device(pdev);
>          if ( ret )
>          {
> +            vpci_remove_device(pdev);
>              pdev->domain = NULL;
>              goto out;
>          }
> @@ -819,6 +818,7 @@ int pci_remove_device(u16 seg, u8 bus, u8 devfn)
>      list_for_each_entry ( pdev, &pseg->alldevs_list, alldevs_list )
>          if ( pdev->bus == bus && pdev->devfn == devfn )
>          {
> +            vpci_remove_device(pdev);
>              pci_cleanup_msi(pdev);
>              ret = iommu_remove_device(pdev);
>              if ( pdev->domain )
> diff --git a/xen/drivers/vpci/vpci.c b/xen/drivers/vpci/vpci.c
> index decf7d87a1..74894bcbac 100644
> --- a/xen/drivers/vpci/vpci.c
> +++ b/xen/drivers/vpci/vpci.c
> @@ -54,7 +54,7 @@ void vpci_remove_device(struct pci_dev *pdev)
>      pdev->vpci = NULL;
>  }
>  
> -int __hwdom_init vpci_add_handlers(struct pci_dev *pdev)
> +int vpci_add_handlers(struct pci_dev *pdev)
>  {
>      unsigned int i;
>      int rc = 0;
> diff --git a/xen/include/xen/vpci.h b/xen/include/xen/vpci.h
> index 6746c2589a..9ea66e033f 100644
> --- a/xen/include/xen/vpci.h
> +++ b/xen/include/xen/vpci.h
> @@ -230,6 +230,8 @@ static inline int vpci_add_handlers(struct pci_dev *pdev)
>      return 0;
>  }
>  
> +static inline void vpci_remove_device(struct pci_dev *pdev) { }
> +
>  static inline void vpci_dump_msi(void) { }
>  
>  static inline uint32_t vpci_read(pci_sbdf_t sbdf, unsigned int reg,
> -- 
> 2.25.1
> 


From xen-devel-bounces@lists.xenproject.org Tue Oct 19 23:34:45 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 19 Oct 2021 23:34:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.213523.371745 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcycx-00082t-Lt; Tue, 19 Oct 2021 23:34:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 213523.371745; Tue, 19 Oct 2021 23:34:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mcycx-00082m-Iu; Tue, 19 Oct 2021 23:34:39 +0000
Received: by outflank-mailman (input) for mailman id 213523;
 Tue, 19 Oct 2021 23:34:38 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=L/ih=PH=citrix.com=Andrew.Cooper3@srs-us1.protection.inumbo.net>)
 id 1mcycw-00082g-8U
 for xen-devel@lists.xenproject.org; Tue, 19 Oct 2021 23:34:38 +0000
Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 4b462d34-5745-471e-8493-fbd1e109e516;
 Tue, 19 Oct 2021 23:34:36 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4b462d34-5745-471e-8493-fbd1e109e516
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1634686475;
  h=to:cc:references:from:subject:message-id:date:
   in-reply-to:content-transfer-encoding:mime-version;
  bh=/3ZdILkZWfWQvKhXGrR49vKTNlFGMxZ8phKVGYazLn0=;
  b=PqMoG0pr6PV/vURv88xG1BOZ0rhP2xjWax3lljef2XnY8VjA0yLcKA9/
   GUAE26YlY7TUfwI6aA5Fcw6zdfQXvExDv89mfNxtEryTYACZ9H4tp1q6L
   1Zjr1dVDKpQPE1ydXCtojY6ZU1F+wAmrSPlO2XWzJJ5Gu/McVwf8dKiYD
   Y=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: P3B8VJk7g9SdpASMt2PyCc0gvC/kF6MsCXXWvKVTpCoJ05wimzfJxsoep093VvbhgsMaUDhLkX
 2L3vVEkTFgrHSNieCuwVlwzZaH0x7IV0DIEYIfZvdMv3Vs9djQgSfcnM3NeP8Ekgq+zfZ5ibs2
 JiO49384zRUKN3tlLYR9Uocoj1kZtawkbOsm1LNcEzCrox2JJCf/NTxJDjWuCni/J/e2hjOGbW
 ouNxKk++5zmwXpIZIdebavMVgVYvnbpLpXGksh2xCJkURgYcK3bzCJK3iqDfTBMWR3HXNVdWgT
 dfam8TI5KLejcjyRgTqOrXLX
X-SBRS: 5.1
X-MesageID: 57489506
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:RkfgZa7kT6GQfq6U8d+ubwxRtMTAchMFZxGqfqrLsTDasY5as4F+v
 mUaUGvQPKvZYmanctx/bIS3phkH7JPXyINqT1NlqSoyHi5G8cbLO4+Ufxz6V8+wwmwvb67FA
 +E2MISowBUcFyeEzvuV3zyIQUBUjclkfJKlYAL/En03FVAMpBsJ00o5wrdh298w3LBVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Zk
 85rrcy2aSgVDoaSxuM4TEFAMCRdBPgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALBc/nJo4A/FpnyinUF60OSpHfWaTao9Rf2V/cg+gTQqqON
 pdBN1KDajzkYhN/PGdQEKscu9WxwWDAKDRnlkm88P9fD2/7k1UqjemF3MDuUsyHQ4BZk1iVo
 krC/n/lGVcKOdqH0z2H/3mwwOjVkkvTWogfCbm5/f5Cm0CIyyoYDxh+fVqko9Gph0imQdVdJ
 kcIvC00osAa7EW2SvHtUhv+p2SL1iPwQPIJTbd8slvUjPOJvUDJXQDoUwKtdvR9r+kuFToK+
 WO5tI23Ahlw6KW2TFGko+L8QSyJBQAZKmoLZCkhRAQD4sX+rIxbsi8jXuqPA4bu0YWrQWCYL
 ySi6XFk3e1K3JFjO7CTpAif21qRSo71ohnZD+k9dlmu6R9lf8abbois5EmzAR1ofdvBEAfpU
 JTpnaGjAAEy4XOlyHPlrAYlRujBCxO53Nv02wIH834JrGzFxpJbVdoMiAyS3W8wWir+RRfnY
 VXIpSRa74JJMX2hYMdfOtzqV5p0nPC6SYy8D5g4i+aihLArKGdrGwk1PSatM53FyhBwwcnTx
 7/KGSpTMZrqIfs+l2fnLwvs+bQq2jo/1QvuqWPTlHyaPU6lTCfNE98taQLWBshgtf/siFiFo
 r53aprRoz0CAbKWX8Ui2dNKRbz8BSNgXs6eRg0+XrPrHzeK70l7Va+Kn+18I9A/90mX/8+Rl
 kyAtoZj4AOXrVXMKBmQa2Alb7XqXJ1lqmk8MzBqNlGts0XPq672hEvGX5doL7Qh6sJ5yvt4E
 6sMd8maW6wdQTXb4TUNK5L6qdU6JhisgAuPOQujYSQ+IME8F1CYpIe8c1u97jQKAwq2qdA6/
 ++q2DTETMdRXA9lFsvXNq6ilgvjoXgHletudELUOd0PKl70+Y1nJnWp3P86Ks0BMzvZwT6e2
 1rECBsUv7CV8YQ07MPIleaPqILwS7lyGU9THm/667eqNHaFojr/kNEYCOvRJGLTTmL5/qmmd
 N559fCkPa1VhktOvqp9D61vkfA06ezwquII1Q9jBnjKMQimU+syPnmc0MBTnaRR3bsF6xCuU
 0eC99QGa7WEPMTpTAwYKAY/N7nR0PgVnn/Z7OgvIVW87yhypeLVXUJXNhiKqSpcMLoqb991n
 bZ/4JYbu16llx4nEtealSQFpW2DI0sJX7gjqpxHUpTgjRAmyw0abJHRYsMsDEpjtzmY3pEWH
 wKp
IronPort-HdrOrdr: A9a23:m1sqbas5rEVpDVk/omfvHF8h7skC/4Mji2hC6mlwRA09TyXGra
 6TdaUguiMc1gx8ZJhBo7C90KnpewK5yXcH2/huAV7EZniYhILIFvAf0WKG+Vzd8kLFh5VgPM
 tbAs5D4ZjLfCVHZKXBkXqF+rQbsaG6GcmT7I+0pRodLnAJGtNdBkVCe2Gm+yVNNXl77PECZe
 OhD6R81l+dkDgsH76G7i5vZZmzmzSHruOoXTc2QzocrCWehzKh77D3VzCewxclSjtKhZMv63
 LMnQDV7riq96jT8G6c60bjq7Bt3PfxwNpKA8KBzuATNzXXkw6tIKBsQaeLsjwZqPymrHwqjN
 7PiRE9ONkb0QKeQkiF5T/WnyXw2jcn7HHvjXeenHvYuMT8AAk3DsJQ7LgpOCfx2g4FhpVRwa
 hL12WWu958FhXbhhnw4NDOSlVDile0iWBKq59Qs1VvFa8lLJNBp40W+01YVL0aGjjh1YwhGO
 5ySOnB+fdtd0+AZXyxhBgt/DWVZAV2Iv66eDlEhiTMuAIm2kyRjnFohPD3p01wsa7UEPJ/lr
 352qcBrsAEciZZV9MkOA+tKfHHfFAleii8RF56F26XXJ3vC0i93qIf349Fk91CWKZ4gafay6
 6xHG+xiwYJCgvT4Iu1rcZ2ziw=
X-IronPort-AV: E=Sophos;i="5.87,165,1631592000"; 
   d="scan'208";a="57489506"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=S0cNbWPjBniOCcoBgb3UNzXpxk/HnVR+jguERs7BSeC4nJgS7jI4f0bZP9SmAQHeJ6HD0yfkaC80ijCMeu9w7qjfIgMebXB9CJmCuNvajzbdezsU/tTiS16e8k/+Eui6fkzQ6hon6jd+sAN1Reqxe+mKnGxwNkjzF9cAdrrW61qQLNmvujluj0Y9hnswLA60USHVjTT88U7uMLGZykX3AuH/2pIq2ZHqRfJIZe9o08cGgJuhNHx7K5nyixIHBcIgsJqYIdSk251ipmTeIP4tJ8oWnGjONBg7VLKiH46QwoghRFTEnh5iv1XeKkZeZjVCNliDpvgSqE1h2n+XfCwRTQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=0tZwy9BckBcTDPJizTSESAjlQGQEun8HkD0ZtvpOMJE=;
 b=HYJ+dEalrmL0s6TW/891vYtNjCMPNMdhXUD8QdDnyrjrcyQnpQqf/elx8EgesL8eyZ4BKyYSc4pjvMKEsD0nb0y2p0GU9CnUD01+AfooEK4RikcY7GEwJjIRtlz1cDKLEQbeghl2c29z/A+/RPa6aG4JsOBP8iG9DkPZg4GcDbcudtcgpnSo3gUroMz558vU13rw6OXo4knKhNwLocauVemerQRSyjFwKhNcyQ+P6G74GKN3dePB1JuZrVEdc6cyTxN7rMJhbg7RnHOX2MCffC0N40/RHM9o2VQVLh4S78hmFRht2D6MFmhvhv8HDYSP/YIG39AvnGb5fsARC8vsvQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=0tZwy9BckBcTDPJizTSESAjlQGQEun8HkD0ZtvpOMJE=;
 b=tLQGtMwob+r8L8Wy8Zd7jv/N4a5h8JlEeDMR8J+bankVfDhzIFxvnAdCAfCzVgXGIPpW/5Pkd+qzT/IGk/GwjoknHoEdd4zAVg4hZ6VRPZQLQ06ySEIN0XyMxFjwRhOJK73u+qLAm9/PtNpWC59a9lap8ndgoJjj8P4NYCeZhMo=
To: Jan Beulich <jbeulich@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Paul Durrant <paul@xen.org>, Ian Jackson <iwj@xenproject.org>,
	=?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <d249a759-188a-d689-316a-4743922827e5@suse.com>
 <d5f76461-70d2-fc59-2213-99a093e3b57f@suse.com>
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH v8 1/6] AMD/IOMMU: obtain IVHD type to use earlier
Message-ID: <932476cb-9667-efaa-65e9-7dc4baa3dc7c@citrix.com>
Date: Wed, 20 Oct 2021 00:34:23 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <d5f76461-70d2-fc59-2213-99a093e3b57f@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Content-Language: en-GB
X-ClientProxiedBy: LO2P265CA0402.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:f::30) To BYAPR03MB3623.namprd03.prod.outlook.com
 (2603:10b6:a02:aa::12)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: dab93a2a-07e3-4aac-961b-08d99358fef3
X-MS-TrafficTypeDiagnostic: BYAPR03MB3942:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <BYAPR03MB394226B466EDEA074417D070BABD9@BYAPR03MB3942.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: RKJNIQfa5qpy0R9Lw/6zEc/VwI/DQQJLozvPSmwd652zGqv6ebl1FcfbVmTSDok1VNB9VZU9rXellm+5Grm8LFMwqR1IumSPzmYz2KwvZBAqxk5hRb+vfCtdM/DZXirTXQHVwbldAmuKIzeyFOjN3p4WjWs0AayqaQeHImdg5BDvfXURsxT46QSnvPJ8CM9QKJNAbkgBjFCyQerAWRQskMBDkWsymZaq7SXFnRy0jEb8r1mrqtQzOOzXNJghwY3JfCk64LSbHvETiYGGSerxe0lWv0Mm4OTeC52JZVgOP3VV3qGLgFDnYWDsG3KtfyGKZilERHFcVDvtPzlZgFHHIrzShiK78sFdeKj25hejMw+rJabawC8dHIIUQZfJFhp97wMj5Sqg6GYOuwn08SCgmRqJakrSNNzTgso0RAI1NIQ3kZ9gZ2NNxVSD6PV301qCOLoKW0gOlN6BgwIAYSHivqeCSf66ZXzbguprGxYyVE+lEh1LgDdTent6pIQtgkYhPOgBEfnkjTr2+mdbaIYbDprAscNWuPRY96s3vYLbQpSazo1MDQOZNBnHPbxFdcfjGZ1UJ5yoGTyQ+o5UIOHMOYDCYp8FMNqU1cJKwK1Xc8fyZEIvjA9qy2dMyozaBuw/VGe2QwygVldUS6OmGPpkxT5yOuOB/JC7yBZC9aFsetRrql6o1Ssmsgo26UPsfEK0ORjuTkXh/1Tpo+TW+GRoGDjje3qOgcTHa/AWEkKuKHg=
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(8676002)(31696002)(107886003)(6486002)(53546011)(956004)(2906002)(36756003)(316002)(86362001)(5660300002)(26005)(2616005)(186003)(16576012)(6666004)(8936002)(4326008)(66556008)(83380400001)(38100700002)(110136005)(54906003)(66476007)(66946007)(508600001)(31686004)(82960400001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VWRZRU5FcjA2QjBlQTZOQWJMamk0Q3Rob01nUHZHYWZiSkFqa05pOCs1M21L?=
 =?utf-8?B?RE9Xbml5YUJCZWZUZ0NZaHdHc3k4L3JVUm9tMDFhV21rZThGeE1pOUdPQ0l0?=
 =?utf-8?B?TVY5c3lkeFNuZkpDV2hjaHlUOHI2UmpHVVh1UjgyMWlPMG5Pa3JtZzN1NGZJ?=
 =?utf-8?B?eWp6UnliVThzYWNvV3cyc0EydnMrb2UwWTZvam1kRUlZTm9mN1RaZnZHeXhL?=
 =?utf-8?B?Smc3Y0dnQVEwZTFKNUUrNjJ5TXQ0N2VNeSswNUExRHcwRDkrMml6Q2lIeW1P?=
 =?utf-8?B?K0xjUGJlcUhMTDNxU0Q2eHkxVlRxRU0zSmkxV0JSanNoRTdiNitCVXA2enU0?=
 =?utf-8?B?cG9JSDMrMzRUMmxXTGEyd29QUmR4SmpVR3g4OUZBWG9ScmNzbHhSTER2TWMw?=
 =?utf-8?B?L05jMDc5Wm4zbXE1WG16MW9FNG1xbkdScThlRVp1M1AvMHVIaEEyMHB3VU5I?=
 =?utf-8?B?SnY3RmtieTJJNDlMbWluektXOVhjSlpzV3laeloxaFo3TUhFNGRGeEl0ZWh3?=
 =?utf-8?B?QXRCNDlySE8wVnBpQm9mY2FHeEp0OHovQ0hOMnM3bzJmdnR1TGdjRllkYzdp?=
 =?utf-8?B?M0tmd3NSd1pjbHc1dFZwcGpiN0w5OWNXRFV2STZzUnd6SzI3Vi9LWURBTncx?=
 =?utf-8?B?K0NYWThENDFkSEUvZGhyc2dMT2c3UEN4YXMvbW56WWtYbXAyd2l5T2tiTEU2?=
 =?utf-8?B?V0VteGt4MjlSNEJQQ0dURFhCZXF5WUx3eTgxN0RpZ0pCZWdPeks4U2VQMmFY?=
 =?utf-8?B?ZC9aZVNHK09sQ1VyMlg4Z2hIR2V1aGtDSWlDc3p5UFRYRjBMdnVUdW03TUMx?=
 =?utf-8?B?US9qb29wNXJDRWExSHIvMXBUMms3Tnc5cldrZW1xd1hYRmdhOHAwYkRsR3g5?=
 =?utf-8?B?WjdhSEpGOHduWGtLcjVNNkY3RUxkVFUzYU1LL2k1Y0k4ZzJsdEk4REVxZmVt?=
 =?utf-8?B?NXhoNExvU3dod0Z0TU56UVZuaDEyZnlmc2I5aUdnZVg1R0pBWXB3UzVTOFl6?=
 =?utf-8?B?WHAvRVU2MGlFRFk4d3lmTDRnWVlmMEtDQzFvV1UzRzNXRWtYWVA1NVkrQ3Vn?=
 =?utf-8?B?OCtlc2lxZUFOVElvdnFQaGdGMWJPTWhSUGh4a05xNFhEcGMxTnp2MmVwdHE5?=
 =?utf-8?B?OHlWT1lmaWlVN1FQQkpNNmpFdWZRT3dWOUpNWDZwR3NzRm5IUmdaWFp2dGcy?=
 =?utf-8?B?MzlwM1VNQ2NFd3Q1YkIvdndpNW81YjF6dllaUVBWMS9aZTd2bks0UzhseVNO?=
 =?utf-8?B?Wlo5OHRvbmdsRC95UmpJbTcxYVhGQW40TytkRVY5OGxXbUFiaVFnRzhEWVpR?=
 =?utf-8?B?SVc1aHBrN3ZlMU95QlV5RkhNV054dkFHZkpDbnkxOUgvc3loUGNnTkMxdG9v?=
 =?utf-8?B?VXpFRFMxa0VQRVVSS3lWakVQVk9IdTVONzQxeVhaNDJVQ0VQVGZJbk5udnpY?=
 =?utf-8?B?T21seHVmTnUvS2Rma29PQWR1SkZXZ2ZsN0NqUGgxQ1NGbm1jcUNsRUUzNVpS?=
 =?utf-8?B?Nm01YXBzLzVwd3pZUHErOElOOURYV3M1Z09vR1lwMVc5dFRuYUJHbTdzemN4?=
 =?utf-8?B?dHB1c2luaStVZGlYdEJ6MDBRQlNxRW1Ub1VXcjlNOHdBd0NsRXMvNVBqMS9W?=
 =?utf-8?B?QmsxbWdrOW9nckgrRXduOVNZdDlPZll5V0h3aFNtbzdzcU04cEg2bEF3aEx6?=
 =?utf-8?B?b0c2ck5UYTRBZzdTRmtzbmh3R2R2T05pUG9pdldEdFBGU3ZScy9rejZ0ZW5p?=
 =?utf-8?Q?JSnDYQyUUGl9+AZi9Qbus5+Q8HofPj6iPP2vwxA?=
X-MS-Exchange-CrossTenant-Network-Message-Id: dab93a2a-07e3-4aac-961b-08d99358fef3
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2021 23:34:29.5326
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: P66rDkDnaKkL77M/jNsofUvxpp3k3+x3weZ0wzE40mP7GawX+RUzUDaMpjLA1RdAwcjpDbDFJGPMpLx2ciGzFqERVc+Xj/FI4835ukI7vgo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB3942
X-OriginatorOrg: citrix.com

On 22/09/2021 15:36, Jan Beulich wrote:
> Doing this in amd_iommu_prepare() is too late for it, in particular, to
> be used in amd_iommu_detect_one_acpi(), as a subsequent change will want
> to do. Moving it immediately ahead of amd_iommu_detect_acpi() is
> (luckily) pretty simple, (pretty importantly) without breaking
> amd_iommu_prepare()'s logic to prevent multiple processing.
>
> This involves moving table checksumming, as
> amd_iommu_get_supported_ivhd_type() ->  get_supported_ivhd_type() will
> now be invoked before amd_iommu_detect_acpi()  -> detect_iommu_acpi(). In
> the course of doing so stop open-coding acpi_tb_checksum(), seeing that
> we have other uses of this originally ACPI-private function elsewhere in
> the tree.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

I'm afraid this breaks booting on Skylake Server.=C2=A0 Yes, really - I
didn't believe the bisection at first either.

>From a bit of debugging, I've found:

(XEN) *** acpi_dmar_init() =3D> -19
(XEN) *** amd_iommu_get_supported_ivhd_type() =3D> -19

So VT-d is disabled in firmware.=C2=A0 Oops, but something we should cope w=
ith.

Then we fall into acpi_ivrs_init(), and take the new-in-this-patch early
exit with -ENOENT too.

It turns out ...

> --- a/xen/drivers/passthrough/amd/pci_amd_iommu.c
> +++ b/xen/drivers/passthrough/amd/pci_amd_iommu.c
> @@ -179,9 +179,17 @@ static int __must_check amd_iommu_setup_
> =20
>  int __init acpi_ivrs_init(void)
>  {
> +    int rc;
> +
>      if ( !iommu_enable && !iommu_intremap )
>          return 0;
> =20
> +    rc =3D amd_iommu_get_supported_ivhd_type();
> +    if ( rc < 0 )
> +        return rc;
> +    BUG_ON(!rc);
> +    ivhd_type =3D rc;
> +
>      if ( (amd_iommu_detect_acpi() !=3D0) || (iommu_found() =3D=3D 0) )
>      {
>          iommu_intremap =3D iommu_intremap_off;
>

... we're relying on this path (now skipped) to set iommu_intremap away
from iommu_intremap_full in the "no IOMMU anywhere to be found" case.

This explains why I occasionally during failure get spew about:

(XEN) CPU0: No irq handler for vector 7a (IRQ -2147483648, LAPIC)
[=C2=A0=C2=A0 17.117518] xhci_hcd 0000:00:14.0: Error while assigning devic=
e slot ID
[=C2=A0=C2=A0 17.121114] xhci_hcd 0000:00:14.0: Max number of devices this =
xHCI
host supports is 64.
[=C2=A0=C2=A0 17.125198] usb usb1-port2: couldn't allocate usb_device
[=C2=A0 248.317462] INFO: task kworker/u32:0:7 blocked for more than 120 se=
conds.

and eventually (gone 400s) get dumped in a dracut shell.

Booting with an explicit iommu=3Dno-intremap, which clobbers
iommu_intremap during cmdline parsing, recovers the system.

This variable controls a whole lot of magic with interrupt handling.=C2=A0 =
It
should default to 0, not 2, and only become nonzero when an IOMMU is
properly established.=C2=A0 It also shouldn't be serving double duty as "wh=
at
the user wants" ahead of determining the system capabilities.

And not to open another can of worms, but our entire way of working
explodes if there are devices on the system not covered by an IOMMU.

~Andrew



From xen-devel-bounces@lists.xenproject.org Wed Oct 20 02:49:53 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Oct 2021 02:49:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.213531.371757 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1md1ff-0003jz-8a; Wed, 20 Oct 2021 02:49:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 213531.371757; Wed, 20 Oct 2021 02:49:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1md1ff-0003js-4H; Wed, 20 Oct 2021 02:49:39 +0000
Received: by outflank-mailman (input) for mailman id 213531;
 Wed, 20 Oct 2021 02:49:38 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1md1fe-0003ji-1f; Wed, 20 Oct 2021 02:49:38 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1md1fd-000291-FU; Wed, 20 Oct 2021 02:49:37 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1md1fd-0002Yy-6L; Wed, 20 Oct 2021 02:49:37 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1md1fd-00051p-5c; Wed, 20 Oct 2021 02:49:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=wnYq6KgE6+R5m+ry5zWzMx/eylO+iueiuoNwVbyStWg=; b=3UuUaGEMwkbBdwZAVxFiGXD9Ap
	2MG110uwu00JwtB6PMl9HJ4k9bOtvHJnv/lRLItVOwmaFpxyZ7VbQCLN/YrIgBd6OndGFWUO3Iz+X
	bFBILc1wmKOvf5DbuAAvViLExhnVU1u5ElowcfHMErDUnp187xmsX51lri8dJ+VZjKiw=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165679-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 165679: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=d9abdee5fd5abffd0e763e52fbfa3116de167822
X-Osstest-Versions-That:
    linux=519d81956ee277b4419c723adfb154603c2565ba
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 20 Oct 2021 02:49:37 +0000

flight 165679 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165679/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail blocked in 165636
 test-amd64-amd64-xl-rtds     20 guest-localmigrate/x10       fail  like 165636
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 165636
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 165636
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165636
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165636
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 165636
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165636
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 165636
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 linux                d9abdee5fd5abffd0e763e52fbfa3116de167822
baseline version:
 linux                519d81956ee277b4419c723adfb154603c2565ba

Last test of basis   165636  2021-10-18 13:40:19 Z    1 days
Testing same since   165679  2021-10-19 16:09:29 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  "Huang, Ying" <ying.huang@intel.com>
  Andrej Shadura <andrew.shadura@collabora.co.uk>
  Andrew Morton <akpm@linux-foundation.org>
  Arnd Bergmann <arnd@arndb.de>
  Christian Brauner <christian.brauner@ubuntu.com>
  Darrick J. Wong <djwong@kernel.org>
  Dave Hansen <dave.hansen@linux.intel.com>
  Eric Dumazet <edumazet@google.com>
  Gang He <ghe@suse.com>
  Huang Ying <ying.huang@intel.com>
  Jan Kara <jack@suse.cz>
  Joseph Qi <joseph.qi@linux.alibaba.com>
  Li  Wang <liwang@redhat.com>
  Li Wang <liwang@redhat.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Lukas Bulwahn <lukas.bulwahn@gmail.com>
  Marek Szyprowski <m.szyprowski@samsung.com>
  Matthew Wilcox (Oracle) <willy@infradead.org>
  Mel Gorman <mgorman@suse.de>
  Miaohe Lin <linmiaohe@huawei.com>
  Nadav Amit <namit@vmware.com>
  Peng Fan <peng.fan@nxp.com>
  Peter Xu <peterx@redhat.com>
  Sean Christopherson <seanjc@google.com>
  Valentin Vidic <vvidic@valentin-vidic.from.hr>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     fail    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   519d81956ee2..d9abdee5fd5a  d9abdee5fd5abffd0e763e52fbfa3116de167822 -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Wed Oct 20 05:33:27 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Oct 2021 05:33:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.213544.371779 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1md4Dz-0002aW-Fe; Wed, 20 Oct 2021 05:33:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 213544.371779; Wed, 20 Oct 2021 05:33:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1md4Dz-0002aP-CK; Wed, 20 Oct 2021 05:33:15 +0000
Received: by outflank-mailman (input) for mailman id 213544;
 Wed, 20 Oct 2021 05:33:14 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1md4Dy-0002a6-Do; Wed, 20 Oct 2021 05:33:14 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1md4Dy-0005Ph-96; Wed, 20 Oct 2021 05:33:14 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1md4Dx-0008Qd-SZ; Wed, 20 Oct 2021 05:33:13 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1md4Dx-0006vr-S4; Wed, 20 Oct 2021 05:33:13 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=aLqSIjrRnY0Yx+k+8Ypa4iiGdTnvZjycmGLw6wEBNYo=; b=IRWSYSYWaqR5PWar8rZjd43Jc2
	CbxR+szo/WGywkFhuUGqyPNqQXx0o4IuohpQ1Hih9GbedcApFVWM1WSjDxDPfiYwkV2jrhAn2tXjy
	d3efytieZJ9J7yd9TBfXQpbeWejOussR/j1DLaGNj14L23b9BKzKS6g7O59rZCqOAHdU=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165681-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 165681: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=6809998c5f8f1d2e26ac9e867af8ac71e7a66cf2
X-Osstest-Versions-That:
    xen=c11b8d25fbe9c0155e91409594ea6701008409ed
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 20 Oct 2021 05:33:13 +0000

flight 165681 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165681/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 165654
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 165654
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165654
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165654
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 165654
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 165654
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 165654
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 165654
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 165654
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 165654
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165654
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 165654
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  6809998c5f8f1d2e26ac9e867af8ac71e7a66cf2
baseline version:
 xen                  c11b8d25fbe9c0155e91409594ea6701008409ed

Last test of basis   165654  2021-10-19 02:26:18 Z    1 days
Testing same since   165681  2021-10-19 17:08:10 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Ian Jackson <iwj@xenproject.org>
  Jan Beulich <jbeulich@suse.com>
  Juergen Gross <jgross@suse.com>
  Roger Pau Monné <roger.pau@citrix.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   c11b8d25fb..6809998c5f  6809998c5f8f1d2e26ac9e867af8ac71e7a66cf2 -> master


From xen-devel-bounces@lists.xenproject.org Wed Oct 20 06:58:58 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Oct 2021 06:58:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.213561.371825 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1md5Yi-0002Gt-8z; Wed, 20 Oct 2021 06:58:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 213561.371825; Wed, 20 Oct 2021 06:58:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1md5Yi-0002Gm-5d; Wed, 20 Oct 2021 06:58:44 +0000
Received: by outflank-mailman (input) for mailman id 213561;
 Wed, 20 Oct 2021 06:58:42 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=TQMG=PI=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1md5Yg-0002Gg-TN
 for xen-devel@lists.xenproject.org; Wed, 20 Oct 2021 06:58:42 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 27bab6b6-3173-11ec-8334-12813bfff9fa;
 Wed, 20 Oct 2021 06:58:40 +0000 (UTC)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2110.outbound.protection.outlook.com [104.47.17.110])
 (Using TLS) by relay.mimecast.com with ESMTP id
 de-mta-7-Dv2qjsjDPeu7eB6GJAXJtg-1; Wed, 20 Oct 2021 08:58:38 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0401MB2335.eurprd04.prod.outlook.com (2603:10a6:800:2e::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.18; Wed, 20 Oct
 2021 06:58:36 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.018; Wed, 20 Oct 2021
 06:58:36 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS8PR04CA0058.eurprd04.prod.outlook.com (2603:10a6:20b:312::33) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.16 via Frontend
 Transport; Wed, 20 Oct 2021 06:58:36 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 27bab6b6-3173-11ec-8334-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634713119;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=aCFw5zyQpmKcvpzVhGygOzjE+PVyPhLrNzqayeQeCdo=;
	b=g1loVBC/Pwi2DDG9k6DBcFbkNxX/REwsTBcdREHuLvf+CgjJeZqFceOmJa8G9iyBvljBm1
	crCwr39gm/k0hKi3cgfESQ6UhBwrJSCBQMKNYDFv4/x1t7/KlIo4yF9bh98x//VAZimvuS
	97oFxWlqjjyQOfRUWFjUjsdCkDKs30g=
X-MC-Unique: Dv2qjsjDPeu7eB6GJAXJtg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=iriAmSeT1uGEPGj8gyTdNPAsEJ99CUm9oSLhYXjGCS+5Y+ugZ4YO5Ke7YXPbh7xsDORouS9VT+o+LfIu0EHvNLTJpVE6iiB7sdHU4wd/qQp42kOsX2QJGgJdbYj1TbB8sCxRmrqPZWLSbuB8heoMuCOQ65n6+FC3KKX7ca7RDYlXO3mQ+gYJZ8wuoKg2rOoC1tOj94JntP83bDgbEWxWglrFrle7CSeTkOWPp90sktZ2tnCg819xS+8DxHHFgivZytxFa5aIGaM+MpnwNhCL9vmF+hqG1IhYwO8/ZniW2KeDs9M4Ah9JNf3jpZwGx/xtrUmraSO1jMcF4v2dw7b03Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=3TOYEVnXzVkA5cBsykb6n9wGmV8L9yx/o1Y/39iFAG4=;
 b=nXhOReUiQkmcbSBEw39Lw/hN1lbO9CQGhuoM41zso+CFcdyBqcgBkOCwLYjuk/G04VtVoYviRr/+y2cZMsesI8VaDYbPf+nZQQfuFoFV7VD5BoKZRrVcUCQdrAeiB16hIkM5v3cCpyCeffjGvM+ODeOA95n4UL/ik0QPUflbv2K4JsbIB9m7LhnlRtvio8xcwqN/G7IFmwbObApETmkRJ6cdzVrbFQNiCtn2XORxwtf9pUtufLYBjqT6//QryydLm03IKhmX7rnvWDRJhb2ew4wUV9eBNadlmpsegI0HoWLBP9bURBFSPZOpQ3FTro98QxRaBnt6ZYP99XLeqnDCeg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [PATCH v8 1/6] AMD/IOMMU: obtain IVHD type to use earlier
To: Andrew Cooper <andrew.cooper3@citrix.com>
CC: Paul Durrant <paul@xen.org>, Ian Jackson <iwj@xenproject.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <d249a759-188a-d689-316a-4743922827e5@suse.com>
 <d5f76461-70d2-fc59-2213-99a093e3b57f@suse.com>
 <932476cb-9667-efaa-65e9-7dc4baa3dc7c@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <315e4a37-4f70-03c1-e4c7-b28ffa8bcf12@suse.com>
Date: Wed, 20 Oct 2021 08:58:34 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <932476cb-9667-efaa-65e9-7dc4baa3dc7c@citrix.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS8PR04CA0058.eurprd04.prod.outlook.com
 (2603:10a6:20b:312::33) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 788aadfd-5710-4e12-e8fa-08d9939709d5
X-MS-TrafficTypeDiagnostic: VI1PR0401MB2335:
X-Microsoft-Antispam-PRVS:
	<VI1PR0401MB2335E142D9FF78B0320250C5B3BE9@VI1PR0401MB2335.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	4jgK8jwDBa1DT9KhIrMibLAojsn/lkCg/xyXpYu7P7XWA7fHtSR58wKO3+/Y7eppVKSWYOvti6HeyYm9X2Ncb18NEOgIPJwbVVz6kT9YyJvOADpajB1L4vm/bsAWlhR/2Fj6bdDtv1zWej2oODo3QVHvmaacLlZI04cFyjRkjlKa+P7lWjs6JCxvOCJxdTkELIxQCRth1j5/2swQoGFaGaofgKDvuALzwZ/RgmhVzdhpZZEFndHhQ/KEq4LETFpdsFBXgNeJFdzdSc/bdmGY7cou3RxGqYWs1QVFxiI61h4Vz7XAWziezXoAaBVdfAymJK2xEjKZuLD3l1ri1gEDzhE2ZdAkc7rNKRfYVxBCBe63XrzD8dyJXanrIwMKpa1d4yvihia0ZpAOjT9Ph0uSi6r+GvNxrsPoITsGkcdknr40toy4uaX6RsInsyTnSyMa1Ru/HFBxaDOZW+OZ5+x8Mya/qq6C7laH0fO8rXD631X1M7D98hVnZ2ETuNwPt53JV7r5IiijzPT0ihJ3nXPBRm7w22cFfmHr87Lb1ToQnY5khO1S4kojYK7VpRBvUzsYxp54+uVKUpr5DIlMTjm/yGWMUv73NT9dPiSfjJkae6SjmqwDjBeOPjeayvtumsx5am3S6ZDwGBjFZp+WCMEmOFJSIHwm/YT2e1aRhAvzKg/vafgY+LYJ7pE/nx+cl4Qb+WAoP02BFcl/vHsNtMnwVt9Vsa0KOIqBP55bnC9gNF0=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(316002)(5660300002)(86362001)(956004)(31696002)(508600001)(2616005)(4326008)(2906002)(6486002)(54906003)(8676002)(186003)(36756003)(8936002)(26005)(31686004)(53546011)(66946007)(66476007)(83380400001)(66556008)(16576012)(38100700002)(6916009)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?QWZQcMywP2FJcuM/23G2EPaPh/+7C/Au0KBq7tp6+510ysftwOwMRYP3EoxM?=
 =?us-ascii?Q?KoC9r2KcQ0Pop2IwXJd3e4xhJVd714rkOAHiECQzsQC3VNTk0NWGRDejoVwZ?=
 =?us-ascii?Q?PNuCjX5CjMOuDK/vN2YxJv6GLBmJOj+i20u1pkE8h0Fz3znGotqrsDaFh2D6?=
 =?us-ascii?Q?8fqtZ4aakYSBcUnCfSNS+HEBTUtCJwLELaar6f78anJUBFKqwBVluS+UZnDF?=
 =?us-ascii?Q?DcJGGfXQ+oRQh26hrjsXzHDmbKSPkeVLLphb1rPN03NBRjrMvjHd2jHOKCX4?=
 =?us-ascii?Q?LL2jGuQNfqnGSAwxK53RQPyQE2bcvi6RGR9GHGKRCasep2qB779z2zAdHLoA?=
 =?us-ascii?Q?Nt0oB5mz8GeK+VzJLNqDIU+H1GhqSCn1XY0dMH+cn+Y3Y+FCF5ZH039Gy5tA?=
 =?us-ascii?Q?pWwfV4zWEMJG4XusNr2LE/asOYxmtVIAo1Bmc89st4gLjuzevGGFaOM16wAq?=
 =?us-ascii?Q?TZ8gaEGMTqE1unXe3VJAjpWcttH9v2POb7v9zy/Ij5ZLGVMSEkdIPhFEldW0?=
 =?us-ascii?Q?gm75SM7Nm3LGxO5xI5Y/ahxrflRKbHy7xA7gvNHr0Ji1KvipVKxwvDbWX+kI?=
 =?us-ascii?Q?YamYhfBI7GZufhnaQHSBmumHouyvlwo40z+51DF8Ai4qkjTrZK1uxvbBvBZG?=
 =?us-ascii?Q?xRKf+OpkhCIfqvn5M6sBtbL0Ei3GWW//Kzs3qMyIyy1jwK4l6eNGYQ2EvZ5c?=
 =?us-ascii?Q?HF/tcMQRMdY9KjWz7xUNcknP/yZDM2FZlObd0VnaT9oN5Trx0d3FEW76VY7F?=
 =?us-ascii?Q?iaUbbcvSxsIhoyHi8dikIyFydjLmzfrsZzFf/4xesKkA9lXwDBu0+jwgicK2?=
 =?us-ascii?Q?gyLZ2d0RGAaQcY0epOkCdKmixBiBBlrZ1f7bo5of9cll/P6f4w4B0KPwlrA6?=
 =?us-ascii?Q?2yHxn3/Zx2D1lFqjPsDLFsKPCpTjv+kakV87S4qsbAhKR6uQTJhW52+0+3um?=
 =?us-ascii?Q?nu9kDQS3+DRGimIAqGfovZ0HaBVsQqh+C3irhjaPRhlBADRLYrwmd/11ySXi?=
 =?us-ascii?Q?Z8eywbL6PURhFX6SZsaZmbg8ALV9oUBzH8EhUy9gLFJPnW7gmy7ONssCCVJR?=
 =?us-ascii?Q?WjdTcVWcs6FfuZGhgmcKqhBHpXpl/+cYmixJ4Yc5RY/AkO7NRE3j+TZACF4z?=
 =?us-ascii?Q?6iIjkotXX2NV0jskbnCUYGl7UMXvk2Lu6j+Lb+LsWmgtltocVyq+ubzSRzCT?=
 =?us-ascii?Q?O/YmP8z4DZrUAf67/qnoYvEiNkclSEGQ/Gjum8u/pl+kVpGh4Yhkd5Yi5mgz?=
 =?us-ascii?Q?N6GuYwnTqTMzuWghF8CGZjf+PMZpEdWcUK0mDKdmtVeRU4N1etE6UTQ4HbIg?=
 =?us-ascii?Q?pTjPyaL4Z1kGPZOQnAUmkSi0?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 788aadfd-5710-4e12-e8fa-08d9939709d5
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2021 06:58:36.5953
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jbeulich@suse.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2335

On 20.10.2021 01:34, Andrew Cooper wrote:
> On 22/09/2021 15:36, Jan Beulich wrote:
>> Doing this in amd_iommu_prepare() is too late for it, in particular, to
>> be used in amd_iommu_detect_one_acpi(), as a subsequent change will want
>> to do. Moving it immediately ahead of amd_iommu_detect_acpi() is
>> (luckily) pretty simple, (pretty importantly) without breaking
>> amd_iommu_prepare()'s logic to prevent multiple processing.
>>
>> This involves moving table checksumming, as
>> amd_iommu_get_supported_ivhd_type() ->  get_supported_ivhd_type() will
>> now be invoked before amd_iommu_detect_acpi()  -> detect_iommu_acpi(). I=
n
>> the course of doing so stop open-coding acpi_tb_checksum(), seeing that
>> we have other uses of this originally ACPI-private function elsewhere in
>> the tree.
>>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>=20
> I'm afraid this breaks booting on Skylake Server.=C2=A0 Yes, really - I
> didn't believe the bisection at first either.
>=20
> From a bit of debugging, I've found:
>=20
> (XEN) *** acpi_dmar_init() =3D> -19
> (XEN) *** amd_iommu_get_supported_ivhd_type() =3D> -19
>=20
> So VT-d is disabled in firmware.=C2=A0 Oops, but something we should cope=
 with.

I wanted to say that I definitely did test this (for a long, long
time) on Intel systems, but clearly not on one like this. I'm sure
though that I did test on IOMMU-less Intel systems, so I'm still a
bit puzzled.

> Then we fall into acpi_ivrs_init(), and take the new-in-this-patch early
> exit with -ENOENT too.
>=20
> It turns out ...
>=20
>> --- a/xen/drivers/passthrough/amd/pci_amd_iommu.c
>> +++ b/xen/drivers/passthrough/amd/pci_amd_iommu.c
>> @@ -179,9 +179,17 @@ static int __must_check amd_iommu_setup_
>> =20
>>  int __init acpi_ivrs_init(void)
>>  {
>> +    int rc;
>> +
>>      if ( !iommu_enable && !iommu_intremap )
>>          return 0;
>> =20
>> +    rc =3D amd_iommu_get_supported_ivhd_type();
>> +    if ( rc < 0 )
>> +        return rc;
>> +    BUG_ON(!rc);
>> +    ivhd_type =3D rc;
>> +
>>      if ( (amd_iommu_detect_acpi() !=3D0) || (iommu_found() =3D=3D 0) )
>>      {
>>          iommu_intremap =3D iommu_intremap_off;
>>
>=20
> ... we're relying on this path (now skipped) to set iommu_intremap away
> from iommu_intremap_full in the "no IOMMU anywhere to be found" case.
>=20
> This explains why I occasionally during failure get spew about:
>=20
> (XEN) CPU0: No irq handler for vector 7a (IRQ -2147483648, LAPIC)
> [=C2=A0=C2=A0 17.117518] xhci_hcd 0000:00:14.0: Error while assigning dev=
ice slot ID
> [=C2=A0=C2=A0 17.121114] xhci_hcd 0000:00:14.0: Max number of devices thi=
s xHCI
> host supports is 64.
> [=C2=A0=C2=A0 17.125198] usb usb1-port2: couldn't allocate usb_device
> [=C2=A0 248.317462] INFO: task kworker/u32:0:7 blocked for more than 120 =
seconds.
>=20
> and eventually (gone 400s) get dumped in a dracut shell.
>=20
> Booting with an explicit iommu=3Dno-intremap, which clobbers
> iommu_intremap during cmdline parsing, recovers the system.
>=20
> This variable controls a whole lot of magic with interrupt handling.=C2=
=A0 It
> should default to 0, not 2, and only become nonzero when an IOMMU is
> properly established.=C2=A0 It also shouldn't be serving double duty as "=
what
> the user wants" ahead of determining the system capabilities.

This would probably be too large a change at this point in time;
I'll see whether I can find something less intrusive. Unless of
course there's a patch already on xen-devel, which I didn't get
to read yet.

> And not to open another can of worms, but our entire way of working
> explodes if there are devices on the system not covered by an IOMMU.

I wouldn't be surprised, but is this something we have to expect
on non-broken systems? (I do know of broken systems giving the
appearance of uncovered devices by lacking suitable include-all
DRHD entries.)

Jan



From xen-devel-bounces@lists.xenproject.org Wed Oct 20 07:02:06 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Oct 2021 07:02:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.213571.371836 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1md5bx-0003lY-S1; Wed, 20 Oct 2021 07:02:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 213571.371836; Wed, 20 Oct 2021 07:02:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1md5bx-0003lR-OR; Wed, 20 Oct 2021 07:02:05 +0000
Received: by outflank-mailman (input) for mailman id 213571;
 Wed, 20 Oct 2021 07:02:04 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=jFZ1=PI=suse.com=jgross@srs-us1.protection.inumbo.net>)
 id 1md5bw-0003lL-Ej
 for xen-devel@lists.xenproject.org; Wed, 20 Oct 2021 07:02:04 +0000
Received: from smtp-out1.suse.de (unknown [195.135.220.28])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id a09410f0-3173-11ec-8334-12813bfff9fa;
 Wed, 20 Oct 2021 07:02:03 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 54BE321A74;
 Wed, 20 Oct 2021 07:02:02 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 0F55B13B3E;
 Wed, 20 Oct 2021 07:02:02 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id Kz11Auq+b2EgOQAAMHmgww
 (envelope-from <jgross@suse.com>); Wed, 20 Oct 2021 07:02:02 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a09410f0-3173-11ec-8334-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1634713322; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=h9ZoB+6hMxP2zkDk7PvludAkWIHhH7t4wMLONjwBzWc=;
	b=c5d8dJhggeIApdXG48qTtPahnKi0v41ajOPsuAxUSqhCjVHfPYOV+Sg9JYxbjHuIvguj3k
	ozl3no/qFP27LaMPNjBQkK1EJlqffPVqcXgarNXou90eTQ3JKbyAtdJXLT8FyYCzWHSyA1
	Fv/mu4ixaYG908HxEoTPkZ0kcvy8LY4=
Subject: Re: [PATCH 06/12] xen: generate hypercall interface related code
From: Juergen Gross <jgross@suse.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>, xen-devel@lists.xenproject.org
References: <20211015125152.25198-1-jgross@suse.com>
 <20211015125152.25198-7-jgross@suse.com>
 <e5f55c9e-5615-7d10-c86c-db1a3c724f43@suse.com>
 <e547b584-54e6-3227-82a8-ff1301eddb21@suse.com>
Message-ID: <c7f5e7eb-7558-4812-0a5b-d02683396704@suse.com>
Date: Wed, 20 Oct 2021 09:02:01 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <e547b584-54e6-3227-82a8-ff1301eddb21@suse.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="hhAQemCyejVtlRZx1jAzVDNEnIjJe97X1"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--hhAQemCyejVtlRZx1jAzVDNEnIjJe97X1
Content-Type: multipart/mixed; boundary="C1H8zA0KLldQkHWwc4oIItcvKDsCHOhsI";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>, xen-devel@lists.xenproject.org
Message-ID: <c7f5e7eb-7558-4812-0a5b-d02683396704@suse.com>
Subject: Re: [PATCH 06/12] xen: generate hypercall interface related code
References: <20211015125152.25198-1-jgross@suse.com>
 <20211015125152.25198-7-jgross@suse.com>
 <e5f55c9e-5615-7d10-c86c-db1a3c724f43@suse.com>
 <e547b584-54e6-3227-82a8-ff1301eddb21@suse.com>
In-Reply-To: <e547b584-54e6-3227-82a8-ff1301eddb21@suse.com>

--C1H8zA0KLldQkHWwc4oIItcvKDsCHOhsI
Content-Type: multipart/mixed;
 boundary="------------82210D72814A8B060B8A9EC7"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------82210D72814A8B060B8A9EC7
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 18.10.21 17:28, Juergen Gross wrote:
> On 18.10.21 14:58, Jan Beulich wrote:
>> On 15.10.2021 14:51, Juergen Gross wrote:
>>> --- a/.gitignore
>>> +++ b/.gitignore
>>> @@ -332,10 +332,12 @@ xen/include/asm-x86/asm-macros.h
>>> =C2=A0 xen/include/compat/*
>>> =C2=A0 xen/include/config/
>>> =C2=A0 xen/include/generated/
>>> +xen/include//hypercall-defs.i
>>
>> Nit: Stray double slash (unless this has a meaning I'm unaware of).
>=20
> Oh, right. No special meaning AFAIK.
>=20
>> Yet then I wonder: Shouldn't *.i be among the patterns at the top of
>> the file, like *.o is?
>=20
> Yes, I can do that. Probably via a separate patch then.

I can't do that, as we have one source file in our git tree matching
this pattern: tools/libs/stat/bindings/swig/xenstat.i is used as an
input file for swig for generating perl and python bindings. And the
=2Ei suffix seems to be the common one for swig input files.


Juergen

--------------82210D72814A8B060B8A9EC7
Content-Type: application/pgp-keys;
 name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Transfer-Encoding: quoted-printable
Content-Description: OpenPGP public key
Content-Disposition: attachment;
 filename="OpenPGP_0xB0DE9DD628BF132F.asc"

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy=
cWx
w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O=
f8Z
d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y=
9bf
IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq=
G7/
377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR=
3Jv
c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA=
QIe
AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT=
hpw
dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0=
MbD
1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv=
oPH
Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v=
5QL
+qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ=
2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC=
QoL
BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr=
Wf0
teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC=
/nu
AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh=
ITT
d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm=
XBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz=
80h
SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC=
AcD
AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn=
FOX
gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1=
jnD
kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0=
N51
N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l=
otu
fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1=
tqS
EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA=
hsD
BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3=
g3O
ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5=
dM7
wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5=
D+j
LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm=
V2x
AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N=
Eaw
QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW=
nHI
s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR=
wgn
BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV=
bVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk=
pEd
IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA=
QAB
wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw=
Tbe
8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1=
vJz
Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8=
VGi
wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW=
svi
uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX=
zXs
ZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------82210D72814A8B060B8A9EC7--

--C1H8zA0KLldQkHWwc4oIItcvKDsCHOhsI--

--hhAQemCyejVtlRZx1jAzVDNEnIjJe97X1
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmFvvukFAwAAAAAACgkQsN6d1ii/Ey/A
kwf+OmfFpQrIMrTXWPTnmAC1gGVnZ+oj0Fdb70LMZFYwpMZS1zhrfn+CVTxwoC1Mdz5oQbcNb9IN
ga8p68Y9MnGmrJyprV6OYGwxzkfIsrNHjuebagW5fl94kTwQtJBJFQF0Q2nUkoz83gT5L0jF+BsY
myCyQDezeIxzqyt8l1WNrrvVy0yi041nft2dCNH7eObwBlHTIKS8TXIJho7LS+8dWjwfRdV1ceca
Xo4UiLE5LykOrqUw9FAe4tXGQBXycK2lIMCLU7gHOYGDcq/0Kkst/MVcl3IkvVAJsGEwr6kR7PT6
HpTksoM0BgaXT8MmjAUlxC2jn2Y32f/u9RECqrp7Kg==
=nprX
-----END PGP SIGNATURE-----

--hhAQemCyejVtlRZx1jAzVDNEnIjJe97X1--


From xen-devel-bounces@lists.xenproject.org Wed Oct 20 07:12:00 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Oct 2021 07:12:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.213579.371847 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1md5lT-0005DK-Qj; Wed, 20 Oct 2021 07:11:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 213579.371847; Wed, 20 Oct 2021 07:11:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1md5lT-0005DD-Nk; Wed, 20 Oct 2021 07:11:55 +0000
Received: by outflank-mailman (input) for mailman id 213579;
 Wed, 20 Oct 2021 07:11:54 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=TQMG=PI=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1md5lS-0005D7-7u
 for xen-devel@lists.xenproject.org; Wed, 20 Oct 2021 07:11:54 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 248a5d45-a263-45d3-ac0d-9fa39f983972;
 Wed, 20 Oct 2021 07:11:53 +0000 (UTC)
Received: from EUR02-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur02lp2057.outbound.protection.outlook.com [104.47.6.57]) (Using
 TLS) by relay.mimecast.com with ESMTP id de-mta-5-JdXkZSJQOwSuTmsO7sYNlQ-2;
 Wed, 20 Oct 2021 09:11:51 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0401MB2608.eurprd04.prod.outlook.com (2603:10a6:800:4f::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.16; Wed, 20 Oct
 2021 07:11:48 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.018; Wed, 20 Oct 2021
 07:11:48 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6PR0502CA0057.eurprd05.prod.outlook.com (2603:10a6:20b:56::34) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.18 via Frontend
 Transport; Wed, 20 Oct 2021 07:11:47 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 248a5d45-a263-45d3-ac0d-9fa39f983972
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634713912;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=GDKp28/EvKyqfxGMN/hZ9fspLZSxvKmMYDZBUutqs4o=;
	b=NjDuq0j6zpCgQLc8QQk+/uJ7av9hj1gGS/CUFSN8jjr+zymtF5xD9yeO0YfBgHNUaSNjwU
	kYxBqH5gTSDpd4CsZ5J2Gz5/Q7iYd+3czPGUUJnHYpTR+JagngLxh0W2gC7Iz+xcAE3VkC
	Vby3ItpgF3iO5ViPSj1khzMIcq2m7Ms=
X-MC-Unique: JdXkZSJQOwSuTmsO7sYNlQ-2
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=QMjyUEKgVkbmj8GTGCJ7Ge3Oy4CJZMRuZRkl5mW8LHH8dGunT3qW3IFBZlHZksTmosSoJwUmfeFHsxmYWkfODpDUZV88BYNGnQ3RXHKBQkEGoWyTA1/Pi48nWMIDMwzSKQNXapsQo+aAb0ae0gj+j1l/fnDJc3atsS2MHX6jYz0a+TtcbQ9PjmAiiRCnWyYA5vhalNVyBfMXXBj15EPUuyGFqZFu97PiTa1lkKTicHzqTVf+Lqka9vwTNXZI6ye6FwxxBF1Dkdo7dJiVjpMy8RL9EzEgtjd2XOTtBULW8VAiQJlhec2EHpcQi6vlrr7HKMcVklY5ecrGnlQS+ssDHw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=i5ipr5uwL1Pptdu0/f+Uq9KEb990eKtnBM1P+A+UXq0=;
 b=cXI1Q01M/fHnVHgI/FJsd9P8DuxuPfeywTfnvM8qHo848mIY0tU5TfUw5CEDCZSvAl8ob36pp9x/QboJy5N7fWouaqnMiYE00trwHDoFCZVFXVoDfMW0CDlvUbqkckOwZTSMYGyb6IOkOl+5FnEu5psAvP2MYFw6RdrQRpI69TffkXps/wXyTW6iYDUpZInGcid5KAy/zwT4g+2lTr4TpYocZSureyzRujyCsbUulppWwJ378BdOXiyDBsMC0oIgtHsGaA5mM48DsqUmPV+zO3bMhQw5CNPElGbEjBl3wZTMn1a8KXU7LMjlQJSwurBlwCVs2QHSNTiFM35Y9uFUaw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Subject: Re: [PATCH 06/12] xen: generate hypercall interface related code
To: Juergen Gross <jgross@suse.com>
CC: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>, xen-devel@lists.xenproject.org
References: <20211015125152.25198-1-jgross@suse.com>
 <20211015125152.25198-7-jgross@suse.com>
 <e5f55c9e-5615-7d10-c86c-db1a3c724f43@suse.com>
 <e547b584-54e6-3227-82a8-ff1301eddb21@suse.com>
 <c7f5e7eb-7558-4812-0a5b-d02683396704@suse.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <52ccd0e5-249d-658d-aae1-c28ced7e1314@suse.com>
Date: Wed, 20 Oct 2021 09:11:45 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <c7f5e7eb-7558-4812-0a5b-d02683396704@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6PR0502CA0057.eurprd05.prod.outlook.com
 (2603:10a6:20b:56::34) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 05616498-1226-46af-783a-08d99398e1bb
X-MS-TrafficTypeDiagnostic: VI1PR0401MB2608:
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<VI1PR0401MB26081AD1C0B5B3A8CA78334FB3BE9@VI1PR0401MB2608.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8273;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	jGFGOI/b0MdznhvJlqnmxY5Ya989bYQnbPSBZbnDOsRKLLmlVpR4dSad43odHU8BmQN4eJQWhOm0pOIU87iYzdLFilrwi0XJvFgZCKmib7NWqSPe5AgVCc9UCFgtzglxVwRbhg0aTayvowu4znNcuDunZTUslr4UaQTfMMH1DNk+xL9pZCnTLsGK/ttMBsUSBZI4fK5mPZp9/PaDWwIVeCAAFEFvFnRF6LaiqJvRdqtOBTO+DnmVDU1b9Rxlx4/gzJbeqIOAHN/MrSGJ+3bZg5mK0dg6bYe5InDa4dW/i7ObZf1YoLMMad6lrHpbRxR/RTwvLrYz7nuDVI8jNi+UDornf4pvBHEZKll9lGT3vPB4T0UMKplOKAP6Ohj/SyniNOPtJ+VAauqEDLkOE2VXGusiMaewwiXy9LNvyXYi+Z1+0mr851qDL4LF4D/PoOFfJyGeps3pt8q8FW6kuDLoUN4ENZBGrmQKK6/vDg14jfmqzJeb5sRjTqALhU1Dztw7tlVZFCdQ/rQsAmhq+xdzkcl5f4MBowzBoJzKecYaitF1xTbJYQ1/Nn9fLvWh4zWoRd1AtTUQiWoDOHE6YlnOhdfR4pYFE3zh81y2ANBwY4y7yQAk+kAQ5r90gVLiCZjEAjUlEK8MJl+d564cd3tNa7Kjdly7UfbekdPAgy0l94raGUokCR+G4AoBx5kypN2/dG9owuPIaFiISGcNcDcnJaDCKaYjT1QL0z0QyoSuW4+cSmkRQYJ43rs98Dxt2ORC
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(54906003)(66946007)(5660300002)(31696002)(53546011)(2906002)(86362001)(6636002)(6486002)(37006003)(66476007)(66556008)(8676002)(8936002)(31686004)(26005)(16576012)(956004)(2616005)(6862004)(186003)(316002)(38100700002)(4326008)(36756003)(508600001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?CgssshSr8YISMyn9/f+reBR1daR+D4irnW+/wRPNkHf6MXmu3bXPM9h5LZvC?=
 =?us-ascii?Q?gqiHv9QSmrHTjN+7ikobyIN9vZ08OufBDYv7SgZcW8yFEg3prg0nlHqWMbzE?=
 =?us-ascii?Q?In9FErqd6iXc4jnEF1BIzDxHmDhdTkxp/PDdzCwZ2Pi0B/z2F3Ve0lFDLmBu?=
 =?us-ascii?Q?3L420fUq9uEKgidELQhAb1MadPRm+yoEppngyjnNvanONiorWlFGQ9VUcjh4?=
 =?us-ascii?Q?8ojzcyBowNuc6io8v+7MxFFovjlB6dkl3FgSR8t0CdnWWxeBUzX+eH1yfJ6Q?=
 =?us-ascii?Q?WqXkZkLNN8x7lQ75sQu47g6I5Fze7nei2VAVDYLr4F0xiwSEq10/nripi0bg?=
 =?us-ascii?Q?uACr4NS1cPGfZ89Poyk/plRTFIDKImHSzNvHOPcHHF8vrWtT+lDos7exyid3?=
 =?us-ascii?Q?IE5MNexSgEk8uz1hnkmE1weJbc6cedffgPmkUfrbQuLa95vJGw3QM5OzFvEu?=
 =?us-ascii?Q?/4GUOsoMle3TiVRWz5ELktu+ZBnMLKeX9bquiPWXgA8+IA7q6+0YOM/uZOIy?=
 =?us-ascii?Q?Qk0tnjyvakGLVaqWpk0YgM4a3x86EspBH5k5nOymCU3taqinSvw21ThLcvmi?=
 =?us-ascii?Q?+e4JxZFwUCPp9TWdUzsOEbgqRwrODHbzXVyzDXVIYLEiIJj0DCQraxN3LMUv?=
 =?us-ascii?Q?3WWpXUsM9CQzgUiA6dvSLDl0CjN9d+7J9rW0vcW0jXNIYYLNDYftDiFXkvyX?=
 =?us-ascii?Q?lsY423UxcArEAscwRhy1C2gaFx6Mz8JSBXJH/WpJS9nH6s6mtpAzqCtgeevT?=
 =?us-ascii?Q?4qhxXwa/lA5x3Nl1qQRFv0L9dn3fUQ9LqkDUAh+bvQqrA1pI+XQYZsxKrjyZ?=
 =?us-ascii?Q?wW+F+pdMzvi6uNn6o02SMG69C5UDwLHwZTVLoLxt129eizZQcZQ5oXtsJCTG?=
 =?us-ascii?Q?Jau2s2mng8+TabLI1ZVm/V1MBybc+2jOFaoWHqsdIkt3Qgumu8WfFVAXPhVm?=
 =?us-ascii?Q?oucBeT3qxoiDYzMQrQt/iIxeR4Vcl0ZcSjH7F5ogVsyDri0gBlYvqC/OguAd?=
 =?us-ascii?Q?3nfM4LfRKRwkTfCw3rp5qN0AgcjVaThzH6MTc0HmjRgxdMCofbRyoAFj1WOy?=
 =?us-ascii?Q?nqLNBJSoZa2hlJGCZYaSyC5Nqk6Bcth1vkyVFG5OZLBwncTXEB5yuawAwlOM?=
 =?us-ascii?Q?KzuRLQFT2WojYkseA8w/b5UGiwosG4OCe9kADyjvGUQYTdB7J8tj8bDldT27?=
 =?us-ascii?Q?3hF5paa1v9qugutHw7n7SFS1hilS3Zu/GLuvF1/VpEZd081Wr/9+1gBynQik?=
 =?us-ascii?Q?4Hjg3sqJwMnT4Zknyo27g+j2hVDxKjbDA4vAGP9l8ygJ/kccl30kp8d073Lg?=
 =?us-ascii?Q?hb/PrUFC2/7O7lCM1gCAaB/aoB0O/+pMrI0+dIF4vu792I4/uWNe8LUFwzzE?=
 =?us-ascii?Q?xmG2rd0Pd/bzI4/xc6uzbSv5ioiggh9YeJ0iymzAyOkI5lFDog11bwAoWFHz?=
 =?us-ascii?Q?8FNncVsNUOA=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 05616498-1226-46af-783a-08d99398e1bb
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2021 07:11:48.2366
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jbeulich@suse.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2608

On 20.10.2021 09:02, Juergen Gross wrote:
> On 18.10.21 17:28, Juergen Gross wrote:
>> On 18.10.21 14:58, Jan Beulich wrote:
>>> On 15.10.2021 14:51, Juergen Gross wrote:
>>>> --- a/.gitignore
>>>> +++ b/.gitignore
>>>> @@ -332,10 +332,12 @@ xen/include/asm-x86/asm-macros.h
>>>> =C2=A0 xen/include/compat/*
>>>> =C2=A0 xen/include/config/
>>>> =C2=A0 xen/include/generated/
>>>> +xen/include//hypercall-defs.i
>>>
>>> Nit: Stray double slash (unless this has a meaning I'm unaware of).
>>
>> Oh, right. No special meaning AFAIK.
>>
>>> Yet then I wonder: Shouldn't *.i be among the patterns at the top of
>>> the file, like *.o is?
>>
>> Yes, I can do that. Probably via a separate patch then.
>=20
> I can't do that, as we have one source file in our git tree matching
> this pattern: tools/libs/stat/bindings/swig/xenstat.i is used as an
> input file for swig for generating perl and python bindings. And the
> .i suffix seems to be the common one for swig input files.

Ugly. Since we have a rule to produce *.i in xen/Rules.mk, I think we
really should have these ignored. Perhaps a good enough reason to put
*.i in xen/.gitignore? And while at it perhaps also *.s? Unless
there's a way to specify a pattern for an entire subtree - it's not
clear to me whether xen/*.i in ./.gitignore would cover subdirs of
xen/ as well ...

Jan



From xen-devel-bounces@lists.xenproject.org Wed Oct 20 07:17:10 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Oct 2021 07:17:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.213587.371858 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1md5qS-0005rp-EO; Wed, 20 Oct 2021 07:17:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 213587.371858; Wed, 20 Oct 2021 07:17:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1md5qS-0005ri-BQ; Wed, 20 Oct 2021 07:17:04 +0000
Received: by outflank-mailman (input) for mailman id 213587;
 Wed, 20 Oct 2021 07:17:02 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=TQMG=PI=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1md5qQ-0005rc-Jp
 for xen-devel@lists.xenproject.org; Wed, 20 Oct 2021 07:17:02 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id b7f392c9-3175-11ec-8334-12813bfff9fa;
 Wed, 20 Oct 2021 07:17:01 +0000 (UTC)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2176.outbound.protection.outlook.com [104.47.17.176])
 (Using TLS) by relay.mimecast.com with ESMTP id
 de-mta-37-JrpqshxYO2ODZXrqH0xbCA-1; Wed, 20 Oct 2021 09:16:59 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0402MB3536.eurprd04.prod.outlook.com (2603:10a6:803:2::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15; Wed, 20 Oct
 2021 07:16:58 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.018; Wed, 20 Oct 2021
 07:16:57 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6PR10CA0097.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:209:8c::38) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4628.16 via Frontend Transport; Wed, 20 Oct 2021 07:16:57 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b7f392c9-3175-11ec-8334-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634714220;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=lzKpWBmNCVdXzMMpesGqb9CpcVPnwTl3L1TXTsA2oHw=;
	b=QDBWxSzUPpoZeZHqTvxbswwXz1Oj216+LEjveKFANnvalBRWHUHzLtDPj/5RYrY4HeIcEe
	hHYgzEmROaYAwdGYlHaBZA9N8E+UU3DR97PweutCX9zw7YsRBDOUp8wNtQtf5RugDADcY2
	Es79kIXmEAzpdc/uPU5ZWafOQYsSOao=
X-MC-Unique: JrpqshxYO2ODZXrqH0xbCA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=jPtOOwFZWoJF43jY7y3pXZFxbtWfETgraQ6Xd2V/otyiXITb8JclZgMXDv+VLYd+zOXuJLPOEcQVdH+vF/DR29ZnDZNUKU6JTVBoBpkiSNC9/6btrsiuWm+D/Bu92t8xsn3+x+Cai5gc6MqpcOavnrMghuv6u+hVjrpTGOjLrC/Z2NgOlpv9Mwotv4HqI+Wivufya/wlzD8PiFXxsYVuhrnFdpP2vI6T8ArxcjeX0RDoizUQCTFyIJlOf3GJfwUa0Urbtl06/8uFmPRMtcPWr0PiLF6tSNyfnvUzhqfpwnplnTo9L8G4FONB0wj14fN/810wgxQWaXusTh4pS2kboQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=lzKpWBmNCVdXzMMpesGqb9CpcVPnwTl3L1TXTsA2oHw=;
 b=kdF0UGQI0Iki4Dizn5G23oBPzi0jodhgln8oG9iLtXqWrrIc7TiXrRUBKA71YjBqyFKtx+jKQnIk7tF7XbLyBSSin9PgfUSudo2uX2w7RrDTHO7zm6wsj9bwxpJJLoq90ukXl5GRrbtX1Ks1GWfZtBpmwKpKKV2lAOapFr9grAImRicx8lnEmmnQOOViX8FZIIwiLVc00vhumsqTIdeA0YsPfitOzZKYShBRFAh+d8G0TACUHHyp6ChY5jUkYKpnmNYQlTqfYll8p5RnHl2Km3gMKTaciZ4dIcWzAh8cMYIVdttL8wxiZao9UqkxfzoRvE6D1Z+RG8armdhpuAJkgw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [PATCH v2 1/1] xen/pci: Install vpci handlers on x86 and fix exit
 path
To: Bertrand Marquis <bertrand.marquis@arm.com>
Cc: iwj@xenproject.org, Oleksandr_Andrushchenko@epam.com,
 Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>, Wei Liu
 <wl@xen.org>, Paul Durrant <paul@xen.org>, xen-devel@lists.xenproject.org
References: <cover.1634659471.git.bertrand.marquis@arm.com>
 <d788dcce9e344a39f6761633f0e96774ab42c2aa.1634659471.git.bertrand.marquis@arm.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <9f77b70f-93b8-2b54-3aa1-5de677d858cc@suse.com>
Date: Wed, 20 Oct 2021 09:16:53 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <d788dcce9e344a39f6761633f0e96774ab42c2aa.1634659471.git.bertrand.marquis@arm.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR10CA0097.EURPRD10.PROD.OUTLOOK.COM
 (2603:10a6:209:8c::38) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: c57a1ad3-3bed-4a23-fb83-08d993999a3a
X-MS-TrafficTypeDiagnostic: VI1PR0402MB3536:
X-Microsoft-Antispam-PRVS:
	<VI1PR0402MB35369A054589F576CFE3711AB3BE9@VI1PR0402MB3536.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6430;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	REw0PJxl98JAXFmYsIzIULGe/Goa5kvRPJTuhbrWa1ZLBtp5hrtOw4BNUTcV0IwAfypEkuvjQj/PR8pQk7LalI+Ep1ruRMfNc6HuKYOtJPP206zsGYx8Hrm9hP9DGw5owH0Pv/qpWBjQKpg6nsZ4cxosKk/DHfaPTNC6w0hje0ubBdjwjhNPfUBtCwEEPPsCCT81HByJkk4BKyY3mOlO9ayU0gNK0O5LeKQFEiJPSwaGZYkArj5LYqla751RC86G0j68NyMn9H6u88RfN8c72aoVv74vrXf4GNQxGHGPXkYSGYEgz/h6WlGPRQKTUvr5AlnAD/kg2zxwBagDfh2gK0ODolnX+JlpMc0iLMEpQJ9BczUlAfZHrEbD7rFzElA2aW+tdfjrVG02uJerRZjnjc5XcGWGGXAbZkGdORFlwHNRaKTt3kG37E/wgZ38KTvSpRHvvYMaQzBPz6zQljJoUS5xP+sDEgy83+HTnIeXJ4IBMIo4+bFy6rqynB/7yIJYvVlMoWJWb3cefc353AuE4wVN1mN2HVLvqBn37Rh8ybtT+dwgFePhN04aKLFtdkTfEMdbHVlMeShnC3sImzbcb3OLc9KxXaXe/jIaxhgoRIOSInu2dhRB8q87tVaJVMvVuLhl2glVowmlU/rNT4qtuQFhHQYiqkuQ64elEvcBmVoX7ZNR9jHSb1zyJxQElvF00lkapGIX0zdCH0bY4JSQ94b5bWrcybLfktveEZ/Tb30H1ZSPJADGDDdGAH0ch5aC
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(66476007)(6486002)(8936002)(66556008)(66946007)(86362001)(31696002)(2616005)(16576012)(956004)(83380400001)(7416002)(38100700002)(8676002)(6666004)(31686004)(6916009)(54906003)(36756003)(508600001)(4326008)(2906002)(316002)(5660300002)(53546011)(186003)(26005)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?OGhGZHBLZ0N1L1doM3p2eWgzeURCQXA4TTBTanNpWFJoYkR5a29IR24xT0FE?=
 =?utf-8?B?TGt6NWtmMGhmSE54N240UFQ2dzVaT1BKM2FrZEtJQzgwWFpiKys2RVJLS05w?=
 =?utf-8?B?YVdWU09OMDV2cHR3cHhReVA1WVNiZFh2UDFKTFhYZlBNRzJnUEVENlhpNXZO?=
 =?utf-8?B?V1Q2NWlXcHoxcnhaWVl0WWs4dHJHdFN6cktFWmlpbUNoRnVVVEt6bUZ5SkVn?=
 =?utf-8?B?VGxJeXRrb012UG1Fa00wcm5NeWhkMklmZmU3dTNBRE9TczNKWjV1amsybVhW?=
 =?utf-8?B?Y2JaQzdWVHNIMXBHeWlOQmNnQm1tQU1qdlhZTEgzbWlxeS83SHRDWVRpQkdj?=
 =?utf-8?B?R1c5NlBlVHNUemhCYXlkSTFjYm9VNzExV25mM2xTUzZQS3lROXR0TGRDM1Fa?=
 =?utf-8?B?TEtIWkl4eitiQmhMcEg3d0JhelVrMkZobnRlbkdTdjdTSE5zYUpkYXJQVTB5?=
 =?utf-8?B?QkdQb2VqLzlnS1V1aGZxKzBGaE04bXdYSDAvcDlWRTJKbkdCUGwyN2RoaEZi?=
 =?utf-8?B?WExaQ1BxNFhTWkRiN3dsa2N6RklRaHRrN0E3Y0h1aElEUGEyVEpCT0RLejRP?=
 =?utf-8?B?VDVCa1ZOa2ZxWUF4Q0VoVXorZXRPd3RTM1prVDY2a1RnZ3pJaEVHNzFuQkEz?=
 =?utf-8?B?d2UwMHZmbWp1MU9RL0l3VlJNL1g3aGJGeDRVaXJXbHlKRDNTVEpmVVFtYlV1?=
 =?utf-8?B?NVJhUE84UmE2eEg0MHNWdXdxam9zQWQyVjh2UjF5UEtkQ0hpQ256Uy95QzNZ?=
 =?utf-8?B?WmVON1ZFTGdVSTZvTDJlbDg2TURZWDgxZ2xDZ3JLd1piaEFYYnZPOHN1SGJK?=
 =?utf-8?B?V0Q1Rkt6b2ZoN2hxcGdQdCtQcEVSc2pRZ0tZZ2FLSjIzeW00S0FEV0Fsa3c0?=
 =?utf-8?B?S0lhZXdWbzZDT1hIeTNVL3pKZEtEM2JnVDZ1UnY5Wnd5b042dTdQSmxDdnRJ?=
 =?utf-8?B?NzdXRjlmekNwSTdpWGttU0dsVEhnM2syUzZxeHV2T0k5MW9lUHY4ZEdSZVZ4?=
 =?utf-8?B?WEFQeVFnNGR6TkExNnlmNHg4dG5qcjM4eUdQRnpBQWRjOUVweHlVSmRuSkVM?=
 =?utf-8?B?OGc5UXhVMEZvajk4NVdlNU51dmRzMENHR2ZHa2Z5YlJLODVkWC9rK2R6dUx3?=
 =?utf-8?B?MUR5eSs5eWxhMUgzNzI2NmwxaTdtN0F3WkF0QmVVMXdzNE5QbEI0ZGFFNENj?=
 =?utf-8?B?VTNjb1NvRlVRcm1FWHJpbC9DZkh1VHlhYVU3L0RDb1JKK2toQnFPeFUzUmth?=
 =?utf-8?B?ZzYzQUhuVDlvVFdydDhWVHcrNHZVZlRWdXkvN0tlSXRHN2lLM0Q0bzcwOTNr?=
 =?utf-8?B?b3NickJodzB3cHVWZ3FWblViWTl5VkQ0bzRQQWhZdHkxL0IyWnFRTi93cmNC?=
 =?utf-8?B?aUZnM2V4NEZtVU5Eb0E4cVdsZGtyaWdvRnI0bFRwQWdXUjVpRkRKYzcrTytk?=
 =?utf-8?B?SmdCeWdzR21wQy83Um83cndlcHdVUStjQXhzNlhZaE9qaFpVdnhBM3k0K0lR?=
 =?utf-8?B?WlYvaVU2NVFyOG16MXcxbWVhaWJGeTd4OE5qTEZnRzdCNUZISUpNNXdYczVR?=
 =?utf-8?B?QklEc2xHUlIwRXBTT3dKS1VIYVhLSzN0MHV2amhoMENDV3NacThlOFZqRmR4?=
 =?utf-8?B?eFpwQVBWenVjeWFod2NrZHBlUHc3UzdaOVhMTkEyOG0vWHVkOXJkZjQ3MVdu?=
 =?utf-8?B?SjVSV1NFSlJHM0FyMWlMLzlWVitFZmxxNThMSHQyRU5CWlFGZHUrTnZTRVRq?=
 =?utf-8?Q?H+82uNQpYdzIHaIHOXwUTzcomhYqRfB9UJeIjQb?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c57a1ad3-3bed-4a23-fb83-08d993999a3a
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2021 07:16:57.7721
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jbeulich@suse.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3536

On 19.10.2021 18:08, Bertrand Marquis wrote:
> Xen might not be able to discover at boot time all devices or some devices
> might appear after specific actions from dom0.
> In this case dom0 can use the PHYSDEVOP_pci_device_add to signal some
> PCI devices to Xen.
> As those devices where not known from Xen before, the vpci handlers must
> be properly installed during pci_device_add for x86 PVH Dom0, in the
> same way as what is done currently on arm (where Xen does not detect PCI
> devices but relies on Dom0 to declare them all the time).
> 
> So this patch is removing the ifdef protecting the call to
> vpci_add_handlers and the comment which was arm specific.
> 
> vpci_add_handlers is called on during pci_device_add which can be called
> at runtime through hypercall physdev_op.
> Remove __hwdom_init as the call is not limited anymore to hardware
> domain init and fix linker script to only keep vpci_array in rodata
> section.
> 
> Add missing vpci handlers cleanup during pci_device_remove and in case
> of error with iommu during pci_device_add.
> 
> Add empty static inline for vpci_remove_device when CONFIG_VPCI is not
> defined.
> 
> Fixes: d59168dc05 ("xen/arm: Enable the existing x86 virtual PCI support
> for ARM")
> Suggested-by: Jan Beulich <jbeulich@suse.com>
> Signed-off-by: Bertrand Marquis <bertrand.marquis@arm.com>

Reviewed-by: Jan Beulich <jbeulich@suse.com>

I'm inclined to suggest s/exit/error/ in the title though (and maybe
also s/path/paths/), which would be easy enough to do while committing.
But first we need Roger's ack here anyway ...

Jan



From xen-devel-bounces@lists.xenproject.org Wed Oct 20 07:18:38 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Oct 2021 07:18:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.213597.371869 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1md5rx-0006XE-Sz; Wed, 20 Oct 2021 07:18:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 213597.371869; Wed, 20 Oct 2021 07:18:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1md5rx-0006X7-Po; Wed, 20 Oct 2021 07:18:37 +0000
Received: by outflank-mailman (input) for mailman id 213597;
 Wed, 20 Oct 2021 07:18:36 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=jFZ1=PI=suse.com=jgross@srs-us1.protection.inumbo.net>)
 id 1md5rw-0006Wz-Sw
 for xen-devel@lists.xenproject.org; Wed, 20 Oct 2021 07:18:36 +0000
Received: from smtp-out1.suse.de (unknown [195.135.220.28])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 6854f230-07e9-4a5e-a695-e96d56644841;
 Wed, 20 Oct 2021 07:18:36 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 53BF421A71;
 Wed, 20 Oct 2021 07:18:35 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id D5DD613F77;
 Wed, 20 Oct 2021 07:18:34 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id 5WYnMcrCb2F/QAAAMHmgww
 (envelope-from <jgross@suse.com>); Wed, 20 Oct 2021 07:18:34 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6854f230-07e9-4a5e-a695-e96d56644841
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1634714315; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=iAQRyXnHPCQuPOhNfqeQHZjQbKH9JXABicZP+6qsUWc=;
	b=LrlJSuvfBb2UdhyZl6hnXQbLwlG/OtZqJJ5PiAYX0x7ZNLlpNx9hXiNbRkJFYiZxjILHJQ
	CSCw02KJXtlqEM3rQAMAefq3QHLUThPxcwydmSTtVdaDloWoQUqd7k5/60BcEidyK3Cp3B
	iU9CMHG/S/sJTm/6LMM/5sTCHnCkfeU=
Subject: Re: [PATCH 06/12] xen: generate hypercall interface related code
To: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>, xen-devel@lists.xenproject.org
References: <20211015125152.25198-1-jgross@suse.com>
 <20211015125152.25198-7-jgross@suse.com>
 <e5f55c9e-5615-7d10-c86c-db1a3c724f43@suse.com>
 <e547b584-54e6-3227-82a8-ff1301eddb21@suse.com>
 <c7f5e7eb-7558-4812-0a5b-d02683396704@suse.com>
 <52ccd0e5-249d-658d-aae1-c28ced7e1314@suse.com>
From: Juergen Gross <jgross@suse.com>
Message-ID: <bc1c64ce-e8cd-4000-7e78-70c35f729ec2@suse.com>
Date: Wed, 20 Oct 2021 09:18:34 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <52ccd0e5-249d-658d-aae1-c28ced7e1314@suse.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="loQb1UQImVkEjI6LXhGHypddmMt0g9KHu"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--loQb1UQImVkEjI6LXhGHypddmMt0g9KHu
Content-Type: multipart/mixed; boundary="SOHCMkLWjRC6RGVo20pqshjjdh4jNwjUE";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>, xen-devel@lists.xenproject.org
Message-ID: <bc1c64ce-e8cd-4000-7e78-70c35f729ec2@suse.com>
Subject: Re: [PATCH 06/12] xen: generate hypercall interface related code
References: <20211015125152.25198-1-jgross@suse.com>
 <20211015125152.25198-7-jgross@suse.com>
 <e5f55c9e-5615-7d10-c86c-db1a3c724f43@suse.com>
 <e547b584-54e6-3227-82a8-ff1301eddb21@suse.com>
 <c7f5e7eb-7558-4812-0a5b-d02683396704@suse.com>
 <52ccd0e5-249d-658d-aae1-c28ced7e1314@suse.com>
In-Reply-To: <52ccd0e5-249d-658d-aae1-c28ced7e1314@suse.com>

--SOHCMkLWjRC6RGVo20pqshjjdh4jNwjUE
Content-Type: multipart/mixed;
 boundary="------------4FB16F3F35E9C41DD1185983"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------4FB16F3F35E9C41DD1185983
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 20.10.21 09:11, Jan Beulich wrote:
> On 20.10.2021 09:02, Juergen Gross wrote:
>> On 18.10.21 17:28, Juergen Gross wrote:
>>> On 18.10.21 14:58, Jan Beulich wrote:
>>>> On 15.10.2021 14:51, Juergen Gross wrote:
>>>>> --- a/.gitignore
>>>>> +++ b/.gitignore
>>>>> @@ -332,10 +332,12 @@ xen/include/asm-x86/asm-macros.h
>>>>>  =C2=A0 xen/include/compat/*
>>>>>  =C2=A0 xen/include/config/
>>>>>  =C2=A0 xen/include/generated/
>>>>> +xen/include//hypercall-defs.i
>>>>
>>>> Nit: Stray double slash (unless this has a meaning I'm unaware of).
>>>
>>> Oh, right. No special meaning AFAIK.
>>>
>>>> Yet then I wonder: Shouldn't *.i be among the patterns at the top of=

>>>> the file, like *.o is?
>>>
>>> Yes, I can do that. Probably via a separate patch then.
>>
>> I can't do that, as we have one source file in our git tree matching
>> this pattern: tools/libs/stat/bindings/swig/xenstat.i is used as an
>> input file for swig for generating perl and python bindings. And the
>> .i suffix seems to be the common one for swig input files.
>=20
> Ugly. Since we have a rule to produce *.i in xen/Rules.mk, I think we
> really should have these ignored. Perhaps a good enough reason to put
> *.i in xen/.gitignore? And while at it perhaps also *.s? Unless
> there's a way to specify a pattern for an entire subtree - it's not
> clear to me whether xen/*.i in ./.gitignore would cover subdirs of
> xen/ as well ...

xen/**/*.i will do that. From the gitignore syntax description:

   A slash followed by two consecutive asterisks then a slash matches
   zero or more directories. For example, "a/**/b" matches "a/b",
   "a/x/b", "a/x/y/b" and so on.

So I'll go with adding xen/**/*.i and xen/**/*.s to .gitignore.


Juergen

--------------4FB16F3F35E9C41DD1185983
Content-Type: application/pgp-keys;
 name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Transfer-Encoding: quoted-printable
Content-Description: OpenPGP public key
Content-Disposition: attachment;
 filename="OpenPGP_0xB0DE9DD628BF132F.asc"

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy=
cWx
w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O=
f8Z
d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y=
9bf
IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq=
G7/
377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR=
3Jv
c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA=
QIe
AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT=
hpw
dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0=
MbD
1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv=
oPH
Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v=
5QL
+qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ=
2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC=
QoL
BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr=
Wf0
teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC=
/nu
AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh=
ITT
d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm=
XBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz=
80h
SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC=
AcD
AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn=
FOX
gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1=
jnD
kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0=
N51
N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l=
otu
fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1=
tqS
EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA=
hsD
BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3=
g3O
ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5=
dM7
wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5=
D+j
LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm=
V2x
AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N=
Eaw
QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW=
nHI
s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR=
wgn
BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV=
bVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk=
pEd
IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA=
QAB
wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw=
Tbe
8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1=
vJz
Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8=
VGi
wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW=
svi
uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX=
zXs
ZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------4FB16F3F35E9C41DD1185983--

--SOHCMkLWjRC6RGVo20pqshjjdh4jNwjUE--

--loQb1UQImVkEjI6LXhGHypddmMt0g9KHu
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmFvwsoFAwAAAAAACgkQsN6d1ii/Ey+i
iQf/Vi+dp/2Vhl+ph3UOZ16ecTAVsjHeByD8YUZ30DtXoqqdqdP6rxLL9qxXowMze56S7Hlg8OjH
9Vu3xNNmYEZce6vPvi6Aa2J+gBP6D+WBq4wtGfSZEhg27sv53HpjwdC0hPbIqDN0G59K0GcdXs5A
Afv5bG07VgY3S4+pGS8bBrNEC8bfDLCNbdmxdkA6AENyEFeKfihMhd1sdrxEgLIYe7ZiptaddCZe
dpqgWcpJopKnxOhLt+j3CJlXP0a/rUBvtzUSnWOTKEpAHeqABkGs8tGq2uIRNh6tVlkgMsiNUTg2
OmZ4UaqH/aApDrNDQVwygqeK7U7fVmkfjKqT/BNWGw==
=GzOu
-----END PGP SIGNATURE-----

--loQb1UQImVkEjI6LXhGHypddmMt0g9KHu--


From xen-devel-bounces@lists.xenproject.org Wed Oct 20 07:20:32 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Oct 2021 07:20:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.213604.371880 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1md5to-0007tv-8i; Wed, 20 Oct 2021 07:20:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 213604.371880; Wed, 20 Oct 2021 07:20:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1md5to-0007to-5d; Wed, 20 Oct 2021 07:20:32 +0000
Received: by outflank-mailman (input) for mailman id 213604;
 Wed, 20 Oct 2021 07:20:31 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=faDG=PI=arm.com=Bertrand.Marquis@srs-us1.protection.inumbo.net>)
 id 1md5tn-0007tg-7n
 for xen-devel@lists.xenproject.org; Wed, 20 Oct 2021 07:20:31 +0000
Received: from EUR03-DB5-obe.outbound.protection.outlook.com (unknown
 [2a01:111:f400:fe0a::616])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id bc51d7f0-8b85-492f-b806-c0a0734cce56;
 Wed, 20 Oct 2021 07:20:29 +0000 (UTC)
Received: from AM6P191CA0021.EURP191.PROD.OUTLOOK.COM (2603:10a6:209:8b::34)
 by PAXPR08MB7017.eurprd08.prod.outlook.com (2603:10a6:102:1df::21) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.16; Wed, 20 Oct
 2021 07:20:13 +0000
Received: from AM5EUR03FT033.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:209:8b:cafe::d1) by AM6P191CA0021.outlook.office365.com
 (2603:10a6:209:8b::34) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.18 via Frontend
 Transport; Wed, 20 Oct 2021 07:20:13 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM5EUR03FT033.mail.protection.outlook.com (10.152.16.99) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.15 via Frontend Transport; Wed, 20 Oct 2021 07:20:12 +0000
Received: ("Tessian outbound d5def7722ff7:v103");
 Wed, 20 Oct 2021 07:20:12 +0000
Received: from b8c3f0b3de5c.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 257286E2-135B-43D7-89E6-6A77AB12B1C1.1; 
 Wed, 20 Oct 2021 07:20:06 +0000
Received: from EUR03-DB5-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id b8c3f0b3de5c.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Wed, 20 Oct 2021 07:20:06 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com (2603:10a6:4:74::9)
 by DBAPR08MB5669.eurprd08.prod.outlook.com (2603:10a6:10:1ac::12) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.16; Wed, 20 Oct
 2021 07:20:05 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955]) by DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955%4]) with mapi id 15.20.4608.018; Wed, 20 Oct 2021
 07:20:05 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: bc51d7f0-8b85-492f-b806-c0a0734cce56
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=pgLoShxjE0tsm+9XqRmsUpQMj7E0iZFFD1gvy2/y5Ko=;
 b=IiRuH26BPCJJQ+ugtjdB/G/8TkgAuOTOn6GXNbdhjkdF1XUNJeqoeYhjQVqaS1NfdNOuGbAtuaAIdIYqI9+BVNeMIcL+hhqIcx0UeVVYuTh2QJ8tRGkndB4P8VhvFItWw/mV4e0EQueQFWRrtvbfd+ubtsqVbRqEhHa6/zMKrfc=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: a4eeb3e3e973e77d
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ZX1BEcWDHmgE5jtJWj4/g7zT2ok2YB0w+sxuWMdRjd1shnuqg7DIN0eCEj/pkd5mrCuCxX4Dd6VzajAhT5OHEHA/O+3Sxlp3q7knsaloAd9rBWByGyJTeHhPJzSlJxoJQY1ryKGht9m7CWexTxrCeavBTVpJkxegbtP9sP7k9vicmlvm9/HoHVr2VfTkrJjo1Z4b8YaszpFcof9UlOGVScs4rzTfhaHLno79xAF0iIfF18PYpa6wbfbR7f5Ww7C6tIKGT6U3Y8x5LDDXGm2dJ4YesMWkHm9KV6/YMyGBv4XpSv9RXNKA+2LlR+WwH1+yjaZqPl4k7kK2mdriSO/mHw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=pgLoShxjE0tsm+9XqRmsUpQMj7E0iZFFD1gvy2/y5Ko=;
 b=gi1Uh/v9sYxLDfu6PtOMgJj7JIDevp5QLdbu1CNF2KV9DLIH7qxG4pwLAtFnsV6QTZgV7DJADCqaVog2QmdXttT+jMFAvcguPAe4pQ3kVG1dytGwZd2maog19PabAf2B/8iQCKXL2+CCTBHm1+XX95+b4re/3HiXetqeFlhXu2SS2D+7ACW4o7J64UVCgYYG/yg5WYWd3KTnhvQYkxbbh49IJT8vFGv84silVIuPmcUQOUpLqxecPPexgh5KBld/1RALo6Ed35dX/dfOkQicg8QCG4d1umigF9K//pKhSWUhZzZpUumCjZKHsx8HuWFXwhPzSGgkhvJjOqcvrwK1Sg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=pgLoShxjE0tsm+9XqRmsUpQMj7E0iZFFD1gvy2/y5Ko=;
 b=IiRuH26BPCJJQ+ugtjdB/G/8TkgAuOTOn6GXNbdhjkdF1XUNJeqoeYhjQVqaS1NfdNOuGbAtuaAIdIYqI9+BVNeMIcL+hhqIcx0UeVVYuTh2QJ8tRGkndB4P8VhvFItWw/mV4e0EQueQFWRrtvbfd+ubtsqVbRqEhHa6/zMKrfc=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Ian Jackson <iwj@xenproject.org>, "Oleksandr_Andrushchenko@epam.com"
	<Oleksandr_Andrushchenko@epam.com>, Stefano Stabellini
	<sstabellini@kernel.org>, Julien Grall <julien@xen.org>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
	=?iso-8859-1?Q?Roger_Pau_Monn=E9?= <roger.pau@citrix.com>, Wei Liu
	<wl@xen.org>, Paul Durrant <paul@xen.org>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v2 1/1] xen/pci: Install vpci handlers on x86 and fix exit
 path
Thread-Topic: [PATCH v2 1/1] xen/pci: Install vpci handlers on x86 and fix
 exit path
Thread-Index: AQHXxQOsddT9Ttg6SUi4XsLpyj6SjavbeuKAgAAA5YA=
Date: Wed, 20 Oct 2021 07:20:05 +0000
Message-ID: <0FC6BD8A-1805-4C10-A95C-EA199D870F06@arm.com>
References: <cover.1634659471.git.bertrand.marquis@arm.com>
 <d788dcce9e344a39f6761633f0e96774ab42c2aa.1634659471.git.bertrand.marquis@arm.com>
 <9f77b70f-93b8-2b54-3aa1-5de677d858cc@suse.com>
In-Reply-To: <9f77b70f-93b8-2b54-3aa1-5de677d858cc@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3654.120.0.1.13)
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: 2f4c90bf-ad7c-4d32-1e5b-08d9939a0ea0
x-ms-traffictypediagnostic: DBAPR08MB5669:|PAXPR08MB7017:
X-Microsoft-Antispam-PRVS:
	<PAXPR08MB701719C2E10C0D4CE90F1BA19DBE9@PAXPR08MB7017.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:7691;OLM:7691;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 Uuo3buEUWYCxv05yXtaE/WpOPT9b2jzgN7zu1O6GBaGzEf6/FVLxHqmKDKzrkgh34yQkiGS7UGXwUypX7bYvNY2JOjlSkbklYzNiQpc52OhgrWIm/JO5FDOus+4iPVDNyuRQFvqnR6QBogD2GlcINHjMXkWiHBWHzRMcD4CEWFqjcwo6hY53SG4z1mu+lUm2HQ6WwvOZV5r2Ok/1Sm0pgJFutx+TgUOJ77A52yw/NsYPB9qZC918WdbtXd58IJRj2AYTuIns21KB/G3ixVkgJR1DR+2/Z12/wO3HBiXS3xZ+OXoZaoJt+6F3xXUnokT3/xbr4VqlcV4lTDlKiOYaXb36kzvansXxqE32ceHRig80N1l31RkMZpu7yjag1FaO8u/Ft0Tn9ofchW6mZEiwxQq2beKhTJAXRqPQeAoAx58Jp5y6IH9hfU0C2sy2XAbOE7xejfShW7yP78DLpBkUvPPIlLccV6SpvDQqRlx2/UmnX50Fz2aRWH9eRNjkQJBQoDe+QR4nmrwKwZ9T1PIO7gq74nxHxct6mZggQrEzw2k7dTnszJ/bPZcsEtXy2CAtcfyY00uJfCOLu2kuI5ZDC7VlfgrJX9dWgL/Y1kgi9l5zstZr+TlKtUaXBno4fxz/Bp4R7JhZUe7uNmhCnRabi0/KqPovW0M0MD40x2GlowqdpTTGZufCdgK7pNryA52J3aVwfCcM+gqTtqmHVVtCbykncNNxUXQ6SrqRd26iu3BLkax4MPME0m43nZ+w09eg
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB6PR0801MB2024.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(508600001)(66476007)(53546011)(5660300002)(316002)(26005)(6506007)(91956017)(66556008)(64756008)(83380400001)(33656002)(66446008)(6486002)(122000001)(38100700002)(54906003)(86362001)(6512007)(76116006)(66946007)(71200400001)(36756003)(8676002)(4326008)(7416002)(8936002)(2616005)(38070700005)(6916009)(2906002)(186003)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="iso-8859-1"
Content-ID: <ADF13321F35B8747A13164C6B3438EAB@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR08MB5669
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM5EUR03FT033.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	5138217e-a413-4fe7-37c1-08d9939a0a4d
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	N/qgmvGphTQY8lQctAI56hbhNcW2BhvKSHQvnU5tZ9c5Mg10RW/MMV69A1/7g0AD2/RyaaFDwjLayPlZ4TOAvyUNyGeN2oH/VrAmL0IRSI/gi9UgegNaS0kYBbBw9rmGU/HyOP9vNX+dc0oEtU2/uMo3A/J53pp47LTEZ9wmsAbeem/JEPVRBkw7A0W/aH68aogH5rNOKuN9Yi2KEIwbEoTPlfa0NMPuoEZ8lY90lP+3jFwrkCgyRB02dupJth1ZOpBiPtvmWRJSKp1H6znRQFguD3yK6YNsElwP0uMwmuUItQQVIv34rFRIMWIDNaFxhM4jDV8iaoXzpAxRGjIhUZMl2tKJK5LydpDwkKQa5y6cMx/VP0StGoe1vOaZDOhUSEefliq4uJM6peoElM8JVGt3JHx+nyuqvhzYKnKW3ta8OVkJOgy5LMtcBJXdarLvIY8T916TxHVzHTmSRqC1PwjFYWzCm5mtzAtqFi2tdG5YT8E/nahGKGFMMuhbfZ+0FHPtOZGbHuE4tZTqPeaKuFevDBWVjOlDYKWAySeXZMJ+BTQt2qh7l6FnLKr9DxyPSGiohMH/bVib1zsCxZgtRtIONf5ycLZt/n2mtc6/SkGblau8cgAGJAkm4w7reQDaXYUCbpo+WFC8MOrBjR3gxwqiRhfBA17Ak8vqHVsIVwRHwKTQh8U0OOA5pQpz+VSqi+iNkGj3Ze43itwV79IRUw==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(86362001)(6512007)(5660300002)(36860700001)(6486002)(54906003)(8936002)(83380400001)(8676002)(47076005)(2616005)(70586007)(356005)(316002)(186003)(82310400003)(26005)(4326008)(508600001)(6862004)(70206006)(81166007)(53546011)(2906002)(336012)(6506007)(33656002)(36756003);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2021 07:20:12.8727
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 2f4c90bf-ad7c-4d32-1e5b-08d9939a0ea0
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM5EUR03FT033.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB7017

Hi,

> On 20 Oct 2021, at 08:16, Jan Beulich <jbeulich@suse.com> wrote:
>=20
> On 19.10.2021 18:08, Bertrand Marquis wrote:
>> Xen might not be able to discover at boot time all devices or some devic=
es
>> might appear after specific actions from dom0.
>> In this case dom0 can use the PHYSDEVOP_pci_device_add to signal some
>> PCI devices to Xen.
>> As those devices where not known from Xen before, the vpci handlers must
>> be properly installed during pci_device_add for x86 PVH Dom0, in the
>> same way as what is done currently on arm (where Xen does not detect PCI
>> devices but relies on Dom0 to declare them all the time).
>>=20
>> So this patch is removing the ifdef protecting the call to
>> vpci_add_handlers and the comment which was arm specific.
>>=20
>> vpci_add_handlers is called on during pci_device_add which can be called
>> at runtime through hypercall physdev_op.
>> Remove __hwdom_init as the call is not limited anymore to hardware
>> domain init and fix linker script to only keep vpci_array in rodata
>> section.
>>=20
>> Add missing vpci handlers cleanup during pci_device_remove and in case
>> of error with iommu during pci_device_add.
>>=20
>> Add empty static inline for vpci_remove_device when CONFIG_VPCI is not
>> defined.
>>=20
>> Fixes: d59168dc05 ("xen/arm: Enable the existing x86 virtual PCI support
>> for ARM")
>> Suggested-by: Jan Beulich <jbeulich@suse.com>
>> Signed-off-by: Bertrand Marquis <bertrand.marquis@arm.com>
>=20
> Reviewed-by: Jan Beulich <jbeulich@suse.com>

Thank.

>=20
> I'm inclined to suggest s/exit/error/ in the title though (and maybe
> also s/path/paths/), which would be easy enough to do while committing.

@Ian: Please tell me if this is ok to be fixed during commit.

> But first we need Roger's ack here anyway ...

Yes.

Cheers
Bertrand

>=20
> Jan



From xen-devel-bounces@lists.xenproject.org Wed Oct 20 07:28:03 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Oct 2021 07:28:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.213612.371891 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1md610-000099-24; Wed, 20 Oct 2021 07:27:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 213612.371891; Wed, 20 Oct 2021 07:27:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1md60z-000092-VE; Wed, 20 Oct 2021 07:27:57 +0000
Received: by outflank-mailman (input) for mailman id 213612;
 Wed, 20 Oct 2021 07:27:56 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=JNaw=PI=intel.com=kevin.tian@srs-us1.protection.inumbo.net>)
 id 1md60y-00008w-Ad
 for xen-devel@lists.xenproject.org; Wed, 20 Oct 2021 07:27:56 +0000
Received: from mga09.intel.com (unknown [134.134.136.24])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id e4396248-8b1e-4c55-abac-e64bf647859d;
 Wed, 20 Oct 2021 07:27:51 +0000 (UTC)
Received: from fmsmga006.fm.intel.com ([10.253.24.20])
 by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 20 Oct 2021 00:27:38 -0700
Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86])
 by fmsmga006.fm.intel.com with ESMTP; 20 Oct 2021 00:27:38 -0700
Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by
 fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2242.12; Wed, 20 Oct 2021 00:27:38 -0700
Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by
 fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2242.12; Wed, 20 Oct 2021 00:27:37 -0700
Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by
 fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2242.12 via Frontend Transport; Wed, 20 Oct 2021 00:27:37 -0700
Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.103)
 by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.1.2242.12; Wed, 20 Oct 2021 00:27:36 -0700
Received: from BN9PR11MB5433.namprd11.prod.outlook.com (2603:10b6:408:11e::13)
 by BN7PR11MB2756.namprd11.prod.outlook.com (2603:10b6:406:b4::24)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.15; Wed, 20 Oct
 2021 07:27:35 +0000
Received: from BN9PR11MB5433.namprd11.prod.outlook.com
 ([fe80::ddb7:fa7f:2cc:45df]) by BN9PR11MB5433.namprd11.prod.outlook.com
 ([fe80::ddb7:fa7f:2cc:45df%8]) with mapi id 15.20.4608.019; Wed, 20 Oct 2021
 07:27:35 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e4396248-8b1e-4c55-abac-e64bf647859d
X-IronPort-AV: E=McAfee;i="6200,9189,10142"; a="228589058"
X-IronPort-AV: E=Sophos;i="5.87,166,1631602800"; 
   d="scan'208";a="228589058"
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.87,166,1631602800"; 
   d="scan'208";a="718789594"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=en3XE2yE/lwtuWPdRf4VawYV9bx9rXiQmnAZrDhnxOEgjySGYMHBOk0ktdNeEmOnLSWHINs0bjH7g50WbZOj2RtEvaCr92ZjmjsA5ar9JE/J23m4sSYkfdILxE63+RAT/ClJQgc6WETI67k436dEHeK/F9qGCEXBTv23aB4MrKjb1JuCM7z2mCiz/+T40xgRPYyXCHeT/Ok5pr3Sm4wHkbIYdtUDK60yKdz+hekYm/NzzKXz3ghhTXlAB78nggsjT+i9FG1dQeHwzK5sesL55yi3obdssv9u9hi9X4RM3B3/AtB20eV39n3ORNAqjxuPfu3Q4rdOA3zcox1IYTUv0A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=iv5yAP3HDQy1yuUjzAtq/fyPUO3Eptuupw47x9gQ9iI=;
 b=W6rMhTfC3OmmVkKHkEoJ+wU1xtBreVj4Rw7T54/Exws56nGFWPO3WlkH45VSJiV4P9BfN8rZil+hEQDl77paTq4QUlK3temZDxHbbfEYr/S6l8jYa04avF63fKavF1+VHn1pS1wjyjRAT9iPQHFA34UHnO+xLL8XJsI9LG8Zmk01+mfa2eySBTxim15ugsYvnUPeUzIHEE/eN/dvHygJb76xF1xsnx4ucwlGBDIrhoZXyYGdyjUCo18p7Wwd0iLJqfyQeFXmY0qaDD2H55GQamlVNhWsZqa5UlkodtZGA2mWu6J4mJVIEn5jMDwmVQrmNYokcpK0x15N0Vb0d3uCEg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;
 dkim=pass header.d=intel.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com;
 s=selector2-intel-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=iv5yAP3HDQy1yuUjzAtq/fyPUO3Eptuupw47x9gQ9iI=;
 b=nlmreOCh0eE6Lka/safxLI03mhi+JFZc9BkG4emdxBk64taxg9b4MI2nmsVMDZ3ORwbNaHhvLeh12uiVDRXbOdgcQENfFE+9FUWtvNL019f0D5KkzUGF5R3gx9gjIxIjAUZ+0KBqBQ/sr0Ms+UgMsIib34JWlEmbi68uUwpAFBA=
From: "Tian, Kevin" <kevin.tian@intel.com>
To: Jan Beulich <jbeulich@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: "Cooper, Andrew" <andrew.cooper3@citrix.com>, George Dunlap
	<george.dunlap@citrix.com>, =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?=
	<roger.pau@citrix.com>
Subject: RE: [PATCH v2] x86/PoD: defer nested P2M flushes
Thread-Topic: [PATCH v2] x86/PoD: defer nested P2M flushes
Thread-Index: AQHXxOg3VYoV4RswS0ul132Ao1qT4KvbffvQ
Date: Wed, 20 Oct 2021 07:27:35 +0000
Message-ID: <BN9PR11MB54330A45289DA8B3C8DFCB5A8CBE9@BN9PR11MB5433.namprd11.prod.outlook.com>
References: <c6f2dcd7-81e6-3fb6-0e13-3ffb95e12bc1@suse.com>
In-Reply-To: <c6f2dcd7-81e6-3fb6-0e13-3ffb95e12bc1@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: suse.com; dkim=none (message not signed)
 header.d=none;suse.com; dmarc=none action=none header.from=intel.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 1326f056-060f-4ab5-a95b-08d9939b1669
x-ms-traffictypediagnostic: BN7PR11MB2756:
x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr
x-microsoft-antispam-prvs: <BN7PR11MB27563774A307CC0C432F72538CBE9@BN7PR11MB2756.namprd11.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:9508;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: qM8vj5Hck19/s9s4TQ2ZPVNoOjK8Nbho2+h17BfPE3PvlN1tiCyH30tB6EXeMc8uvJ8McaPJXu8ZLLexozX0r7IlMXnREuaET+ftMqaQSgFyodWxqqraqWKF0FEUmjRQ4grQ4gBCBKz1DLMEFiuDK5BxwrzUmNkNSX0d8NpILNjSsazOlgan1IWgK5ClpC1JlhRuOxka+L0J4KV+XP3nayjIWBpa9So0zYfs0yyqS6ssu1IjqxPEVVcUbxzdhLu6Smv64nNtiL+iAmbRgQwwPpuwZVZ6ipd2drRZ8xkg8wwZycFZFCxTAbJLyMwKh9F0eGf9LiZG+oFMVoZmXCC5hMPPqdCy1cFEFpB7Bafxg47UWl7K5h/Ts53CPD6YR4vE0xFyfqUPIpOX3Zoyyw97lG/MON/FmXwgpa6/5NdcTZX/FPW5el5oWBCdvCu7F1S0J5nElAEKVSa+ptSarmwjN0P9HE6eGYaSMGs+cQWvdIkUmf+VkICnJHdVK4/BV8E5VcE8tR573nk7pQoBI0dyGxxQZlclr7Vd3F6vWYYmcybi+U/jDwQkJOa7cuxKLqedl+X5brwnxPJho3vOdTCneVha6iIB/ufdywuBmV3bXDZdCrmJzW+WmiYv5PJmiIiFSNoatAEdTo9uav79/7fUsIshuDEmC1xTTz+vz9iSv8TBq37xbzYuOE6QmGaXK/iF6ciItobOIs8/cBqWAEPGFw==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR11MB5433.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(4326008)(66446008)(54906003)(508600001)(86362001)(186003)(64756008)(7696005)(5660300002)(122000001)(33656002)(110136005)(52536014)(316002)(83380400001)(6506007)(26005)(8936002)(38070700005)(2906002)(82960400001)(66946007)(76116006)(8676002)(38100700002)(66476007)(55016002)(66556008)(71200400001)(9686003);DIR:OUT;SFP:1102;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?WDduQ2FUVm5zMVdwbVhqTEN0NUNyejYzMndseVVtVU9Lby8wRUwwZW1IVURr?=
 =?utf-8?B?RTF6dEZCamY1b3ZkRkM5MFhYc3QvbVNKTVJPdjVpQ1F3dDNGd2RZQXE4MC9m?=
 =?utf-8?B?M0JzRHM5WnNiYUtGRG5RbUZhWWhNaFlQNTRtRUhBUzVobkFWNXdacmxRbDBa?=
 =?utf-8?B?VkFPaXJQbnBNWngyZTFkdlhzZ1dvblpzRkhuSUdENW1ORVVnWTdmMExMOVZ5?=
 =?utf-8?B?bCtFcUxPU2FBZmFhM0VVTGdVRmk3Zk00M0krQzQwSnRqak9NUVN3a053bjVt?=
 =?utf-8?B?RlBBTGpSSElEL05QZllKUW0yd3lBdXc0cUV1MmxBZUdBZjlrVkFGbm0yeDA5?=
 =?utf-8?B?NTdwVkd4MWF5NDVHemtldERoTEZ5NXZVaDNPL0xqbmhQcmZEZVRpSllLcGN0?=
 =?utf-8?B?aTVVb3AybENERForMW10bXVxc3NXRHFjL3dHRThhd0ZSY1pkSTYxVlNkUktx?=
 =?utf-8?B?M3BqUWYvdjYvVDc2MUU4dm5Vc2xNQmpGbXRWclhQc0xPU3hseUdDMExhQTla?=
 =?utf-8?B?L000TEJTV0kyQ3A5VnRHaEt5YWFvdzV5S3FQb3JBRVdPWnlHU2p6dHd5Kzd6?=
 =?utf-8?B?VkFUWS8wS2tlRUJaVmoxalFCaWJsbjFUTHYzM2ZjeTZaR2owRm8zVWxMbEE2?=
 =?utf-8?B?dUxIRkJ5NEgzeVJJaDRTcmdFWWJPbWtGTUF3RTgxQkE4bC9OZ09wRS9JejIw?=
 =?utf-8?B?V2IzZnRUWVRPZGpucUNUT3pMMGxFQmhsWHcwbTVFcW1LOWRyaEkzYklvV1ZJ?=
 =?utf-8?B?WHpWckJmYjJ5Q0luSmk4SW9takpxaExHaVFuTDZRUzhhS2t0SDhINXV4a3M2?=
 =?utf-8?B?UUc4dHZNNDBwcG5CZ05rb0hMV0hnYnpsczU0eWs0djRFc1cvZFhZSTBKTlpG?=
 =?utf-8?B?OGhwb2w0WGZ5Mm1KUDZtbmovV1pNc1UzazM5bWFNVUFHMHlUbEphVlVnaVVt?=
 =?utf-8?B?cGFLSytwNS9IRXY1ajFiZVNoRzhHSWFLZ3FCVEs5MlNwcFYyeXlEbmcxYU85?=
 =?utf-8?B?WXJjVHg3endWWnVaRC9Rc1NhNmNUVU9zTEtIemVkdVJFUnZ1RzFXaXFLQmE4?=
 =?utf-8?B?THhLK2x1YjdnOGJnODl2THFpRlU3SDUwT3dndFdJT29rTDh2SmJrcWt5N25i?=
 =?utf-8?B?STF0SE9QNGJZZC9vSWRCZzlhWkFZUDg4L2VWT21INzY4aEE1SlcxSUhhR21R?=
 =?utf-8?B?V1crbjBIalpEWmNvN0t5bnltbnNKWGkxTVpzR3czS25PNHEwL3NOZnUvcndO?=
 =?utf-8?B?bldpeWV6NXFFaDU3dXNDVWNCZjFjU1JtMUdUeHBlTytnQkVSNEtWVHRLbVdk?=
 =?utf-8?B?WHU5VTN6QmNySEJXRjlEQ0RQTjhKUG90VWVOQmZZUkQwZDlKRnE0K0hBZG9o?=
 =?utf-8?B?MmhvWHpFTVVXNkZXTUpyNFBFeGNNZXMzNDNvTmlUaFVGM05VMXYrRjFMdXlZ?=
 =?utf-8?B?MlZxOUFCWXNpenBBNkFtcWNZN2hkV1BlUGxTZ1oyb3pTZVFNUHhiQWJxMjRo?=
 =?utf-8?B?MWZyYmhxVWt4bWtKcDRPOHVTNTBvYit0cmpGREpIdjlieWlXekNHUkFQSWZ2?=
 =?utf-8?B?bEpoOUZPNElKTUlGVkVaZDhjY2xhTHFvNjJEUU0rRGNoOFJHNzJZOTdxVEk4?=
 =?utf-8?B?dS9wTmNTWEE2UjI0Y3RFY1RibWZ3eVJ3d2xlb3A0NHJrbnFSTTZ6MlBUejIw?=
 =?utf-8?B?clpXOENlT0xDRTdDSWVCMk5WRzNZclJjRFpDWmMwQ0J0dk9aREFsU0RSZnRQ?=
 =?utf-8?B?dTc3Z0NnK0ZGOENibkZhbWJBUXFJK21GZ1FhNFJhamtaK0IwOVpwSDBMNEdM?=
 =?utf-8?B?amhIbytXWWFyMjROOEtFMlo2V3pIM3c5RzdMdFE2MHdKT3p0eXdqUUgyYk1K?=
 =?utf-8?B?Mm5nbWNTck1EM01FV0xLbGxYWWhzc3VGLy9WbGZ6OFlnYURTRnlBNXYvQjdL?=
 =?utf-8?B?bE1qeHdEUjFCYk91ekZiaWhFRUZtVHBJcXVpMXlrcWFxSmludDg4VTYzMDg2?=
 =?utf-8?B?U01NTEJ0eTVHRkFPQlZ0RmpPWSt2NVNmOFhodStFaHIyZ1Qwb3VMcnVlZHYv?=
 =?utf-8?B?SlU5MGVONk93c3Zkam9Hd1lCYnp3bWxaRVNrSDVJRHk1a1kvSm5GdDgzYk95?=
 =?utf-8?B?SERCNkZ5dzBsK0NqR2JTZHpzUS9OaXZCOS9OTlFoeTJqQVY0bkcvUnJ0eWh2?=
 =?utf-8?Q?Fmzl+bwOPOo5UiT5uMNE6CU=3D?=
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5433.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1326f056-060f-4ab5-a95b-08d9939b1669
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Oct 2021 07:27:35.3807
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: m4XG30eUnoELiBVdeJ9Ny3vBZuFWNDGdBMhC9dztAWrp3y7fYki4oH3PC+odV2sooThssciRpvKJjCcqG8qxEw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR11MB2756
X-OriginatorOrg: intel.com

PiBGcm9tOiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+DQo+IFNlbnQ6IFR1ZXNkYXks
IE9jdG9iZXIgMTksIDIwMjEgODo1MiBQTQ0KPiANCj4gV2l0aCBOUFQgb3Igc2hhZG93IGluIHVz
ZSwgdGhlIHAybV9zZXRfZW50cnkoKSAtPiBwMm1fcHRfc2V0X2VudHJ5KCkgLT4NCj4gd3JpdGVf
cDJtX2VudHJ5KCkgLT4gcDJtX2ZsdXNoX25lc3RlZHAybSgpIGNhbGwgc2VxdWVuY2UgdHJpZ2dl
cnMgYSBsb2NrDQo+IG9yZGVyIHZpb2xhdGlvbiB3aGVuIHRoZSBQb0QgbG9jayBpcyBoZWxkIGFy
b3VuZCBpdC4gSGVuY2Ugc3VjaCBmbHVzaGluZw0KPiBuZWVkcyB0byBiZSBkZWZlcnJlZC4gU3Rl
YWwgdGhlIGFwcHJvYWNoIGZyb20gcDJtX2NoYW5nZV90eXBlX3JhbmdlKCkuDQo+IChOb3RlIHRo
YXQgc3RyaWN0bHkgc3BlYWtpbmcgdGhlIGNoYW5nZSBhdCB0aGUgb3V0X29mX21lbW9yeSBsYWJl
bCBpcw0KPiBub3QgbmVlZGVkLCBhcyB0aGUgZG9tYWluIGdldHMgY3Jhc2hlZCB0aGVyZSBhbnl3
YXkuIFRoZSBjaGFuZ2UgaXMgYmVpbmcNCj4gbWFkZSBuZXZlcnRoZWxlc3MgdG8gYXZvaWQgc2V0
dGluZyB1cCBhIHRyYXAgZnJvbSBzb21lb25lIG1lYW5pbmcgdG8NCj4gZGVhbCB3aXRoIHRoYXQg
Y2FzZSBiZXR0ZXIgdGhhbiBieSBkb21haW5fY3Jhc2goKS4pDQo+IA0KPiBTaW1pbGFybHkgZm9y
IEVQVCBJIHRoaW5rIGVwdF9zZXRfZW50cnkoKSAtPiBlcHRfc3luY19kb21haW4oKSAtPg0KPiBl
cHRfc3luY19kb21haW5fcHJlcGFyZSgpIC0+IHAybV9mbHVzaF9uZXN0ZWRwMm0oKSBpcyBhZmZl
Y3RlZC4gTWFrZSBpdHMNCj4gcDJtX2ZsdXNoX25lc3RlZHAybSgpIGludm9jYXRpb24gY29uZGl0
aW9uYWwuIE5vdGUgdGhhdCB0aGlzIHRoZW4gYWxzbw0KPiBhbHRlcnMgYmVoYXZpb3Igb2YgcDJt
X2NoYW5nZV90eXBlX3JhbmdlKCkgb24gRVBULCBkZWZlcnJpbmcgdGhlIG5lc3RlZA0KPiBmbHVz
aGVzIHRoZXJlIGFzIHdlbGwuIEkgdGhpbmsgdGhpcyBzaG91bGQgaGF2ZSBiZWVuIHRoYXQgd2F5
IGZyb20gdGhlDQo+IGludHJvZHVjdGlvbiBvZiB0aGUgZmxhZy4NCj4gDQo+IFJlcG9ydGVkLWJ5
OiBFbGxpb3R0IE1pdGNoZWxsIDxlaGVtK3hlbkBtNXAuY29tPg0KPiBTaWduZWQtb2ZmLWJ5OiBK
YW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+DQoNClJldmlld2VkLWJ5OiBLZXZpbiBUaWFu
IDxrZXZpbi50aWFuQGludGVsLmNvbT4NCg0KPiAtLS0NCj4gdjI6IEFsc28gYWRqdXN0IGVwdF9z
eW5jX2RvbWFpbl9wcmVwYXJlKCkuIEFsc28gY29udmVydCB0aGUgZmx1c2ggYXQgdGhlDQo+ICAg
ICBvdXRfb2ZfbWVtb3J5IGxhYmVsLiBFeHRlbmQgZGVzY3JpcHRpb24gdG8gY292ZXIgdGhlc2Uu
DQo+IA0KPiAtLS0gYS94ZW4vYXJjaC94ODYvbW0vcDJtLWVwdC5jDQo+ICsrKyBiL3hlbi9hcmNo
L3g4Ni9tbS9wMm0tZXB0LmMNCj4gQEAgLTEyNTMsNyArMTI1Myw3IEBAIHN0YXRpYyB2b2lkIGVw
dF9zeW5jX2RvbWFpbl9wcmVwYXJlKHN0cnUNCj4gICAgICB7DQo+ICAgICAgICAgIGlmICggcDJt
X2lzX25lc3RlZHAybShwMm0pICkNCj4gICAgICAgICAgICAgIGVwdCA9ICZwMm1fZ2V0X2hvc3Rw
Mm0oZCktPmVwdDsNCj4gLSAgICAgICAgZWxzZQ0KPiArICAgICAgICBlbHNlIGlmICggIXAybS0+
ZGVmZXJfbmVzdGVkX2ZsdXNoICkNCj4gICAgICAgICAgICAgIHAybV9mbHVzaF9uZXN0ZWRwMm0o
ZCk7DQo+ICAgICAgfQ0KPiANCj4gLS0tIGEveGVuL2FyY2gveDg2L21tL3AybS1wb2QuYw0KPiAr
KysgYi94ZW4vYXJjaC94ODYvbW0vcDJtLXBvZC5jDQo+IEBAIC0yNCw2ICsyNCw3IEBADQo+ICAj
aW5jbHVkZSA8eGVuL21tLmg+DQo+ICAjaW5jbHVkZSA8eGVuL3NjaGVkLmg+DQo+ICAjaW5jbHVk
ZSA8eGVuL3RyYWNlLmg+DQo+ICsjaW5jbHVkZSA8YXNtL2h2bS9uZXN0ZWRodm0uaD4NCj4gICNp
bmNsdWRlIDxhc20vcGFnZS5oPg0KPiAgI2luY2x1ZGUgPGFzbS9wYWdpbmcuaD4NCj4gICNpbmNs
dWRlIDxhc20vcDJtLmg+DQo+IEBAIC00OTQsNiArNDk1LDEzIEBAIHAybV9wb2Rfb2ZmbGluZV9v
cl9icm9rZW5fcmVwbGFjZShzdHJ1Y3QNCj4gIHN0YXRpYyBpbnQNCj4gIHAybV9wb2RfemVyb19j
aGVja19zdXBlcnBhZ2Uoc3RydWN0IHAybV9kb21haW4gKnAybSwgZ2ZuX3QgZ2ZuKTsNCj4gDQo+
ICtzdGF0aWMgdm9pZCBwb2RfdW5sb2NrX2FuZF9mbHVzaChzdHJ1Y3QgcDJtX2RvbWFpbiAqcDJt
KQ0KPiArew0KPiArICAgIHBvZF91bmxvY2socDJtKTsNCj4gKyAgICBwMm0tPmRlZmVyX25lc3Rl
ZF9mbHVzaCA9IGZhbHNlOw0KPiArICAgIGlmICggbmVzdGVkaHZtX2VuYWJsZWQocDJtLT5kb21h
aW4pICkNCj4gKyAgICAgICAgcDJtX2ZsdXNoX25lc3RlZHAybShwMm0tPmRvbWFpbik7DQo+ICt9
DQo+IA0KPiAgLyoNCj4gICAqIFRoaXMgZnVuY3Rpb24gaXMgbmVlZGVkIGZvciB0d28gcmVhc29u
czoNCj4gQEAgLTUxNCw2ICs1MjIsNyBAQCBwMm1fcG9kX2RlY3JlYXNlX3Jlc2VydmF0aW9uKHN0
cnVjdCBkb21hDQo+IA0KPiAgICAgIGdmbl9sb2NrKHAybSwgZ2ZuLCBvcmRlcik7DQo+ICAgICAg
cG9kX2xvY2socDJtKTsNCj4gKyAgICBwMm0tPmRlZmVyX25lc3RlZF9mbHVzaCA9IHRydWU7DQo+
IA0KPiAgICAgIC8qDQo+ICAgICAgICogSWYgd2UgZG9uJ3QgaGF2ZSBhbnkgb3V0c3RhbmRpbmcg
UG9EIGVudHJpZXMsIGxldCB0aGluZ3MgdGFrZSB0aGVpcg0KPiBAQCAtNjY1LDcgKzY3NCw3IEBA
IG91dF9lbnRyeV9jaGVjazoNCj4gICAgICB9DQo+IA0KPiAgb3V0X3VubG9jazoNCj4gLSAgICBw
b2RfdW5sb2NrKHAybSk7DQo+ICsgICAgcG9kX3VubG9ja19hbmRfZmx1c2gocDJtKTsNCj4gICAg
ICBnZm5fdW5sb2NrKHAybSwgZ2ZuLCBvcmRlcik7DQo+ICAgICAgcmV0dXJuIHJldDsNCj4gIH0N
Cj4gQEAgLTExNDQsOCArMTE1MywxMCBAQCBwMm1fcG9kX2RlbWFuZF9wb3B1bGF0ZShzdHJ1Y3Qg
cDJtX2RvbWFpDQo+ICAgICAgICogd29uJ3Qgc3RhcnQgdW50aWwgd2UncmUgZG9uZS4NCj4gICAg
ICAgKi8NCj4gICAgICBpZiAoIHVubGlrZWx5KGQtPmlzX2R5aW5nKSApDQo+IC0gICAgICAgIGdv
dG8gb3V0X2ZhaWw7DQo+IC0NCj4gKyAgICB7DQo+ICsgICAgICAgIHBvZF91bmxvY2socDJtKTsN
Cj4gKyAgICAgICAgcmV0dXJuIGZhbHNlOw0KPiArICAgIH0NCj4gDQo+ICAgICAgLyoNCj4gICAg
ICAgKiBCZWNhdXNlIFBvRCBkb2VzIG5vdCBoYXZlIGNhY2hlIGxpc3QgZm9yIDFHQiBwYWdlcywg
aXQgaGFzIHRvIHJlbWFwDQo+IEBAIC0xMTY3LDYgKzExNzgsOCBAQCBwMm1fcG9kX2RlbWFuZF9w
b3B1bGF0ZShzdHJ1Y3QgcDJtX2RvbWFpDQo+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICBwMm1fcG9wdWxhdGVfb25fZGVtYW5kLCBwMm0tPmRlZmF1bHRfYWNjZXNzKTsNCj4gICAgICB9
DQo+IA0KPiArICAgIHAybS0+ZGVmZXJfbmVzdGVkX2ZsdXNoID0gdHJ1ZTsNCj4gKw0KPiAgICAg
IC8qIE9ubHkgcmVjbGFpbSBpZiB3ZSdyZSBpbiBhY3R1YWwgbmVlZCBvZiBtb3JlIGNhY2hlLiAq
Lw0KPiAgICAgIGlmICggcDJtLT5wb2QuZW50cnlfY291bnQgPiBwMm0tPnBvZC5jb3VudCApDQo+
ICAgICAgICAgIHBvZF9lYWdlcl9yZWNsYWltKHAybSk7DQo+IEBAIC0xMjI5LDIyICsxMjQyLDI1
IEBAIHAybV9wb2RfZGVtYW5kX3BvcHVsYXRlKHN0cnVjdCBwMm1fZG9tYWkNCj4gICAgICAgICAg
X190cmFjZV92YXIoVFJDX01FTV9QT0RfUE9QVUxBVEUsIDAsIHNpemVvZih0KSwgJnQpOw0KPiAg
ICAgIH0NCj4gDQo+IC0gICAgcG9kX3VubG9jayhwMm0pOw0KPiArICAgIHBvZF91bmxvY2tfYW5k
X2ZsdXNoKHAybSk7DQo+ICAgICAgcmV0dXJuIHRydWU7DQo+ICsNCj4gIG91dF9vZl9tZW1vcnk6
DQo+IC0gICAgcG9kX3VubG9jayhwMm0pOw0KPiArICAgIHBvZF91bmxvY2tfYW5kX2ZsdXNoKHAy
bSk7DQo+IA0KPiAgICAgIHByaW50aygiJXM6IERvbSVkIG91dCBvZiBQb0QgbWVtb3J5ISAodG90
PSUiUFJJdTMyIiBlbnRzPSVsZA0KPiBkb20lZClcbiIsDQo+ICAgICAgICAgICAgIF9fZnVuY19f
LCBkLT5kb21haW5faWQsIGRvbWFpbl90b3RfcGFnZXMoZCksDQo+ICAgICAgICAgICAgIHAybS0+
cG9kLmVudHJ5X2NvdW50LCBjdXJyZW50LT5kb21haW4tPmRvbWFpbl9pZCk7DQo+ICAgICAgZG9t
YWluX2NyYXNoKGQpOw0KPiAgICAgIHJldHVybiBmYWxzZTsNCj4gKw0KPiAgb3V0X2ZhaWw6DQo+
IC0gICAgcG9kX3VubG9jayhwMm0pOw0KPiArICAgIHBvZF91bmxvY2tfYW5kX2ZsdXNoKHAybSk7
DQo+ICAgICAgcmV0dXJuIGZhbHNlOw0KPiArDQo+ICByZW1hcF9hbmRfcmV0cnk6DQo+ICAgICAg
QlVHX09OKG9yZGVyICE9IFBBR0VfT1JERVJfMk0pOw0KPiAtICAgIHBvZF91bmxvY2socDJtKTsN
Cj4gKyAgICBwb2RfdW5sb2NrX2FuZF9mbHVzaChwMm0pOw0KPiANCj4gICAgICAvKg0KPiAgICAg
ICAqIFJlbWFwIHRoaXMgMi1tZWcgcmVnaW9uIGluIHNpbmdsZXRvbiBjaHVua3MuIFNlZSB0aGUg
Y29tbWVudCBvbiB0aGUNCg0K


From xen-devel-bounces@lists.xenproject.org Wed Oct 20 07:50:16 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Oct 2021 07:50:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.213622.371902 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1md6MU-0003Hr-0g; Wed, 20 Oct 2021 07:50:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 213622.371902; Wed, 20 Oct 2021 07:50:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1md6MT-0003Hk-TZ; Wed, 20 Oct 2021 07:50:09 +0000
Received: by outflank-mailman (input) for mailman id 213622;
 Wed, 20 Oct 2021 07:50:08 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ou1c=PI=citrix.com=roger.pau@srs-us1.protection.inumbo.net>)
 id 1md6MR-0003Gt-Ur
 for xen-devel@lists.xenproject.org; Wed, 20 Oct 2021 07:50:08 +0000
Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 9aabb323-d9e4-40ea-861b-cd8011d9e6c7;
 Wed, 20 Oct 2021 07:50:05 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9aabb323-d9e4-40ea-861b-cd8011d9e6c7
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1634716205;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=PuqG5i4uKPxiDFeuszJOm7Kx3ast/wehPdAeohe83QA=;
  b=bkhGUzkG5owkVwsXL5p44uCsgT7w/N3RZn0lOOC+NhTZCh8bOen7i8B5
   Aij5ouzD2xIHfZxdFjcfQ2aLsaUMqkafk7BtBN8m8cpellLpWqAER3oe6
   zuS6+csvbVw/tg9EDSv2McaFz2IQdBBmKewM4ln9RmZ83mKPM0nq/GU7G
   s=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: +Dc4ICcqZs3UK+MTic9jib1wnV1RaQdzdxeiY2M8N5J1GnKylTjl3XDwm9/ylbtLxScZLqzgHX
 3Um0iuJdYYdHtjaKb7zPorTtVvKLXUt6wUwL3Oj+XzQJma0kvWJWHPYTU9Y87nOAda5wTPOC0R
 WdvW/vv1++5IIeUzaAVhKTmg/Ckl+aZWj4EPJ32R0iVEfFtl7G4s3XUbuGAS/Q7ytbRpx1R/hQ
 mcthtV0NmDVfOH2XVWu/CqFJySg63Sk8SsjLqcf94A1DMSn9z8Kg8IL6yBxfpkhk6YBC/1MNVX
 TThfXi8Eo8hwErRITQQKva72
X-SBRS: 5.1
X-MesageID: 55616917
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:dqsk36Mp6SGbV0fvrR2gkcFynXyQoLVcMsEvi/4bfWQNrUp31mAEz
 mpOWj2PbKuNamD0fIx0YYm3oEkP6J7TztQwTgto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdpJYz/uUGuCJQUNUjMlkfZKhTr6bUsxNbVU8En540Ug7w7dRbrNA2rBVPSvc4
 bsenOWHULOV82Yc3rU8sv/rRLtH5ZweiRtA1rAMTakjUGz2zhH5OKk3N6CpR0YUd6EPdgKMq
 0Qv+5nilo/R109F5tpICd8XeGVSKlLZFVDmZna7x8FOK/WNz8A/+v9TCRYSVatYoxillsgtk
 sdij7utaBoObryRubolCwYNRkmSPYUekFPGCX22sMjVxEzaaXr8hf5pCSnaP6VBpLwxWzsXs
 6VFdnZdNXhvhMrvqF6/YvNrick5atHiIasUu216zCGfBvEjKXzGa/iXu4YGjW5v7ixINcv/S
 JoaaWV/VkzrZF5lO1UrUaAArej90xETdBUH8QnI9MLb+VP78gt117T8NcvPTfaDT85Vg0Wwq
 3rP+iLyBRRyHN6CzTuI9Fq8i+mJmjn0MKoQHrCl8v9hgHWI23ceThYRUDOTufCkjmauVtQZL
 FYbkgIxqYAi+UrtScPyNzWorXjBshMCVt54F+wh9BrL2qfS+xyeBGUPUnhGctNOnMU7XyAw3
 1mF2dbgHyVysaa9QGiYsLyTqFuaODcXBX8PYzceSgkI6MWlp5s85jrUVcpqGqOxitzzGBnzz
 iqMoSx4gK8c5eYs06i45lnBjyibj57FVBMu5g7XU2Sm6St0fIegIYev7DDmAe1oddjDCAPb5
 T5dxpbYvLtm4YyxeDKlbckEBO3z9dm/FyD9nHk/DsQAqQz15Cv2FWxP2w1WKEBsO8cCXDbmZ
 k7PpA9cjKNu0GuWgbxfON3pVZx7pUT0PZG8DKqMN4sRCnRkXFbfpHkGWKKG44z6fKHAe4kEM
 pCHbd3kM38eDal2pNZdb7ZAieF1rszSKGW6eHwa8/hF+ebBDJJ2Ye1cWLdrUgzfxPnYyOky2
 40HX/ZmMz0FDIXDjtD/qOb/12wiI3khHozRoMdKbOOFKQcOMDh/UKOPn+J5IdA9xv09egL0E
 peVABMwJL3X3iWvFOl3Qio7NOOHsWhX/BrXwhDAzX73giN+MO5DHY8UdoctfKlPyQCQ5aUcc
 hXxQO3ZWq4nYm2eo1w1NMChxKQ/JEXDrV/fZEKNPWlgF6OMsiSUo7cIiCO0r3JQZsd23ONjy
 4CdOvTzG8RTHFo8UZ6KMppCDTqZ5BAgpQ67ZGORSvF7c0Tw6ol6bSv3i/48OcYXLhvfgDCd0
 m6r7d0w/IEheqc5r4vEg76qtYCsH7csF0ZWBTCDv723KTPb7iyoxooZCLSEejXUVWXV/qS+Z
 LoKk6GgYaNfxFsa4ZBhF7tLzL4l44e9rbFt0Qk5Tm7AaE6mC+08LyDej9VPrKBE2pRQpRCyB
 hCU4tBfNLjQYJHlHVcdKRALdOOG0f1IyDDe4e5seBfx5TNt/arBWkJXZkHehCtYJbpzEYUk3
 eZ+55JGt13h0kIna4/UgDpV+mKAKm07f58m7pxKUpX2jgcLy01ZZcCOACHB/5zSOc5HNVMnI
 2HIifOa1ahc3EfLb1E6CWPJgbhGnZ0LtR1HkA0CKlCOloaXj/M7xkQMozE+TwATxRRbyeNjf
 GNsMhQtd6mJ+j5pgulFXnytRF4dVEHIpBSpxgtbjnDdQmmpSnfJfT80Nuu69UwE935RI2pA9
 7aCxWe5CTvncakdBMfptZKJfxA7ceFMyw==
IronPort-HdrOrdr: A9a23:yk0qpKDSBUOfUxTlHeka55DYdb4zR+YMi2TDj3oBLyC8cqSj+f
 xG785rrCMc6QxhLE3I9urwWpVoLUmxyXcx2/h3AV7AZniQhILLFvAG0WKK+VSJcEeSygce79
 YFT0EUMrzN5C1B/KXHCX6Dc+rIruPpzEniv5an854kd3AQV0lHhz0JQzpz1ncGMjVuFN4yT4
 OG4MBKvSCtdHINYK2Adww4tsb41qf2fMiKW296O/YFhTP+8Q9BqNPBYmalNllyaUI//V9tm1
 K14TAQVMiYwo6G4w6Zymva9ZgTg9f61t5fbfb8+vQ9O3Hwjg6zaMB/V6aZvDYzydvfm2oXrA
 ==
X-IronPort-AV: E=Sophos;i="5.87,166,1631592000"; 
   d="scan'208";a="55616917"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=KaZMeU7k3/LBY7OtnfHj0YeYKyBo4ooU1BNzY1oz6G9uDADZUOghOvl7CU8G4A3qtt7/S3D25kZJryH+2lVN3zHv69VgrnWZ6jEQBxjKVKu5VE8ngEM22yLWH6VjHOtNaoScHIoFo8dHExCfJUaYOPism7cdvOUW0Ys0fs5MHWlL8WIkA8iWIFzDiVBTPFICVwQTo1IKUaVZdHiMSKcjJHNsF9VW1MXA9dU9bw+b5zZN6TMWbX/xa0GWoVSNacttLwgIWosyVf4NEkGUQ252uakuMYDXWdHLdqBL/V0nSvqFNEJdbpBY9O8m645LoTBielEXHk6sn8yqIEnCiwJ5/w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=/pKlgnD6MkN3KSMd8ywkU3dD8ruRKSqhywXbmEvrglE=;
 b=BStuLmdJpym9fRey15iDdMBrPJ8SY+53K9C8OJpTv/6EqOnT2RbtxiAAbHmM5xr3vTGXb1uSl1ZsnmycTN4tbGR7QPqxWfWdtooEnihtslt7jLhhgpVHRLmP7craoQyeJty5yakmsyudxfsP10dM9F4+BPuJOMwqiCzTWxt48IxLuPjxbeH2l9kHzQLBDKtqWAfU2EQ34JYVXuCdUnAGHFnTdEN8nJfBZWcoJmrHtehm8rY9lCy9zsI6PfvnNmdN1Wq4/igYBji/KjjUfNfJZiUVw7B0WWMkceNKLZOsKp8ti0N5SpytAf5e1JZjRUUZcDBX7PdtU67wwoamzs1CQA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=/pKlgnD6MkN3KSMd8ywkU3dD8ruRKSqhywXbmEvrglE=;
 b=QzfddKZPMveXgD2nV+O4UJuOUIDfcTbygZDvN4jzJTPV+KgBkX0YJZjT96teIqpHL6d1i28jWlSQrrCBykqXQ1z6OqU/1jAsv10hyf7wYh9HYQt/2/n6ZDgNeZYjaRAAuCK84kNc5dnnTaqLA/3Ca0KH+AFRU2D4tWGOJ7vj2Wc=
Date: Wed, 20 Oct 2021 09:49:32 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Bertrand Marquis <bertrand.marquis@arm.com>
CC: <xen-devel@lists.xenproject.org>, <iwj@xenproject.org>,
	<Oleksandr_Andrushchenko@epam.com>, Stefano Stabellini
	<sstabellini@kernel.org>, Julien Grall <julien@xen.org>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Jan Beulich <jbeulich@suse.com>, Andrew Cooper
	<andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>, Paul Durrant
	<paul@xen.org>
Subject: Re: [PATCH v2 1/1] xen/pci: Install vpci handlers on x86 and fix
 exit path
Message-ID: <YW/KDHnZHz72mjuQ@MacBook-Air-de-Roger.local>
References: <cover.1634659471.git.bertrand.marquis@arm.com>
 <d788dcce9e344a39f6761633f0e96774ab42c2aa.1634659471.git.bertrand.marquis@arm.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <d788dcce9e344a39f6761633f0e96774ab42c2aa.1634659471.git.bertrand.marquis@arm.com>
X-ClientProxiedBy: LO4P123CA0140.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:193::19) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 056c85dc-0864-4bce-9046-08d9939e2acc
X-MS-TrafficTypeDiagnostic: DM6PR03MB5084:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <DM6PR03MB508451E14B212AF0853D4C308FBE9@DM6PR03MB5084.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: Fc39iKXJEFshM7rubY8nr7KsI4Yy8rCJvm04hvP4ohAcC+nRikyZsKY3GqOFbnnfu0zNqVPuNJYvZ7p91mTYsbUpuv8QD4AqADQD+u4BcN4/6xYKajDqjPt4ttmp/UfiJW0xM3RhDbwXH7beiRz+jstmxq0esdFgrFAWGGJpVmISWSjGUfNpPpBNlHmPxT1eFJVDv1vyenj7LzxY+tqDijDSV9tEcSmcEYiTo9W1EwF5T02iNUQ83VIl0UnEtK4Aasw5DFfw7CWQ3svNHdUvAO0mLQi01FOB03fcF49bClQnk5fCp9/l34rRKGJ1SW5gz3OIVM/d247houykkcOfffD1mtgZGEmTDTU++72ozjn1f1KhheybtxL0hHRJB9p2pjbBwRFQUv5RW7RQW1By7ZCvmk5zaIxcioLpxXGjQTyQ6LDueQrAbet1PLMUpi8ksCrEIS2fSv++X24zU8F+RgEPt3XX8ir4gBd4BGDwM/t5V3grdYXsTxjYfKzR3sIhK00kiy2lWbh5nFvKg+5OAt84bJ+2+qxWSH4TLy82vS7Kr04qE9Ewkp6eWHXu/0GS+ZfVnLPRuLGH+QAYc5aVW184xUDTtqtzwindoeeFMsuhq3hyb3kwGMh8hB4kzXvJotzJEQULblfIfmJWjYEw/g==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(4326008)(6496006)(38100700002)(186003)(66556008)(82960400001)(6666004)(86362001)(508600001)(83380400001)(66476007)(9686003)(6916009)(8676002)(2906002)(66946007)(956004)(5660300002)(7416002)(85182001)(8936002)(26005)(6486002)(316002)(54906003);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MVRzQThDRk95SVlkZTVKeVAwcml6VERPeWMxZTNSR2JCWlFsWkRPMUtLd1Jt?=
 =?utf-8?B?R3c3aUhjdHQrVFJrUnhqb3lJY3hDYW9ZamRsbEllNHA5endiNHhLN1Jtc0hi?=
 =?utf-8?B?TlJPUU0vbjhJeVFwbStoSitNNW9nR2tSSHNOZFRhQ0w3ZkdaVjdISFhoQWla?=
 =?utf-8?B?WCtaZFJCaklpNjVKaGxYdzVkS0V1UFROWnVldTF1ODV1ZmhGS1gvYTR3T0lF?=
 =?utf-8?B?MkE0c1BtT3J1UlFoQ3N3RFdRSTFaQXhDL1lsWEpzcm04cTU4dU9obXVoclpV?=
 =?utf-8?B?WllBdEpEQ0dNUXBheGNkbzJqaXY3WjRvV05FaWVhN1VFQVh3ZDlNcVE5eml3?=
 =?utf-8?B?VG43b0F1S3RqOWdaMW9kZ1ZkVmIrY0JHNkRZcm9SYmxEOXlxbXBEcmFqQldN?=
 =?utf-8?B?bDVYVE8za2JXOTlzQWIrL1hGOHBkUnhPL0ZxbC9aN2dkY2ZIOEEzMFVTVHkw?=
 =?utf-8?B?Mll3WThmd041bFE0czIwaWM5b2lMbStxRCt0MENwZ2R3VDRUMzkvcE1reCtE?=
 =?utf-8?B?MG8vVjFXTHNwMnpvaEZTZGNyRTFVOW9qTWFvL2VpWE1MbmRxaXJZZFRlRDFX?=
 =?utf-8?B?cm1IeXpQSHFKbzd1Zlk5U2g2VlRubWhjcStjQWZUbTZDbWhZQitMdlhDMy85?=
 =?utf-8?B?dmlxam9KZ2xmdHRtUkMxcXdwWHk4d1pPbUpCS1BET2FRd3c3R2xqVzFzdmpK?=
 =?utf-8?B?MXl1SnI4QW5JR1BqUExOQjh0R2E1VFloMzZwSHBJQ0pOb3hBd01iYVV2Tm1C?=
 =?utf-8?B?bUhsay94NngzREg1dlZzandNaUF5Z2JJSDhWdittSFdGdnU4WWhPWmVxMW04?=
 =?utf-8?B?UlpMc3FDSTVrTFdnTFNGK2F2VGNFaTBiMCtsazlVMjVQajJnbzN1Q01hME5w?=
 =?utf-8?B?QURBRU9TR1Nhcm5jQS9QbmEzZ2ttZGZ5dm9Ec0pWTHpwWXdNUElJWGdCcTNG?=
 =?utf-8?B?R1N2VWtOWklENlF2Nnd4ek9PVnRmWU5sdmVZUUtERHRFNzM0WFVvQ0MrWXRn?=
 =?utf-8?B?OG1jc0Zna2ErSURidysxY2ZRTGtVNUxWd09pM0V5Z0hKazM2bmZqYXdpQy9W?=
 =?utf-8?B?MURGaWFHbTZOL0FwMHhUbGJ6L2dqSkpoaE1IQi9oaGFOVGpNNzZtVmh0ekVO?=
 =?utf-8?B?cFpoSmk4cDBnVng0bmVOQVI5c3JIeTdOQzM5NUYyNEh3ei9LY05aYW1vbWVU?=
 =?utf-8?B?MFBORVFqb21sSUtkZkFmeHVDOVVrdDhnZ1kwS0xoL0hLSGZyWEwzTmRVRDJq?=
 =?utf-8?B?TjJ2djV6ZXgxYnpLTlVjMWpEZlBjZ25STU9icDJmbFBqS1pnK1hkcnp4WmNZ?=
 =?utf-8?B?cjVsZEN0TmVpQVNpajltUWNpcitCbzRCaXVQRFFTR3FpeC8xWEFHQkNpTU56?=
 =?utf-8?B?SUdBZVg0ckUyTXV0NVhiVk9hSStwY1d1TytoM1VjRHlVbUNLbk1JK0Z5OFdw?=
 =?utf-8?B?YUZSSnViUjRkbnhFTm9OZVpvLzlPeUFLZ0luM3ZxT1pmRlpVc0NXT0xPL3gr?=
 =?utf-8?B?VlFKa1VOOGlwS2dmbkhLN3h6SXFadmlPclVLakVUYVFxb014UnQ1N3JQYnl2?=
 =?utf-8?B?andjNVNKdGhMa2RiNjlqT1pOZEwrZUQ1dk5WTzA5Nm15QktzZkZLTVp4eERl?=
 =?utf-8?B?ckp3N0R4TVhqTFNtMkxnZVhON2twc1hveE50Umlpc2dCWlIzeTJ6dWlXVWI3?=
 =?utf-8?B?L2F4dnpUYjRYeTZhT3ZDUzFkVmRrSXltS3kwKzNXM3lKN2pMNzVPc0t1MVVo?=
 =?utf-8?Q?KUiSwOzp8aMsfc+jrISEjhc2FpM8Kx8FBGTgO1D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 056c85dc-0864-4bce-9046-08d9939e2acc
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2021 07:49:38.3194
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: roger.pau@citrix.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB5084
X-OriginatorOrg: citrix.com

On Tue, Oct 19, 2021 at 05:08:28PM +0100, Bertrand Marquis wrote:
> Xen might not be able to discover at boot time all devices or some devices
> might appear after specific actions from dom0.
> In this case dom0 can use the PHYSDEVOP_pci_device_add to signal some
> PCI devices to Xen.
> As those devices where not known from Xen before, the vpci handlers must
> be properly installed during pci_device_add for x86 PVH Dom0, in the
> same way as what is done currently on arm (where Xen does not detect PCI
> devices but relies on Dom0 to declare them all the time).
> 
> So this patch is removing the ifdef protecting the call to
> vpci_add_handlers and the comment which was arm specific.
> 
> vpci_add_handlers is called on during pci_device_add which can be called
> at runtime through hypercall physdev_op.
> Remove __hwdom_init as the call is not limited anymore to hardware
> domain init and fix linker script to only keep vpci_array in rodata
> section.
> 
> Add missing vpci handlers cleanup during pci_device_remove and in case
> of error with iommu during pci_device_add.
> 
> Add empty static inline for vpci_remove_device when CONFIG_VPCI is not
> defined.
> 
> Fixes: d59168dc05 ("xen/arm: Enable the existing x86 virtual PCI support
> for ARM")
> Suggested-by: Jan Beulich <jbeulich@suse.com>
> Signed-off-by: Bertrand Marquis <bertrand.marquis@arm.com>
> ---
> Changes in v2
> - add comment suggested by Jan on top of vpci_add_handlers call
> - merge the 3 patches of the serie in one patch and renamed it
> - fix x86 and arm linker script to only keep vpci_array in rodata and
> only when CONFIG_VPCI is set.
> ---
>  xen/arch/arm/xen.lds.S        | 9 +--------
>  xen/arch/x86/xen.lds.S        | 9 +--------
>  xen/drivers/passthrough/pci.c | 8 ++++----
>  xen/drivers/vpci/vpci.c       | 2 +-
>  xen/include/xen/vpci.h        | 2 ++
>  5 files changed, 9 insertions(+), 21 deletions(-)
> 
> diff --git a/xen/arch/arm/xen.lds.S b/xen/arch/arm/xen.lds.S
> index b773f91f1c..08016948ab 100644
> --- a/xen/arch/arm/xen.lds.S
> +++ b/xen/arch/arm/xen.lds.S
> @@ -60,7 +60,7 @@ SECTIONS
>         *(.proc.info)
>         __proc_info_end = .;
>  
> -#if defined(CONFIG_HAS_VPCI) && defined(CONFIG_LATE_HWDOM)
> +#ifdef CONFIG_HAS_VPCI
>         . = ALIGN(POINTER_ALIGN);
>         __start_vpci_array = .;
>         *(SORT(.data.vpci.*))
> @@ -189,13 +189,6 @@ SECTIONS
>         *(.init_array)
>         *(SORT(.init_array.*))
>         __ctors_end = .;
> -
> -#if defined(CONFIG_HAS_VPCI) && !defined(CONFIG_LATE_HWDOM)
> -       . = ALIGN(POINTER_ALIGN);
> -       __start_vpci_array = .;
> -       *(SORT(.data.vpci.*))
> -       __end_vpci_array = .;
> -#endif
>    } :text
>    __init_end_efi = .;
>    . = ALIGN(STACK_SIZE);
> diff --git a/xen/arch/x86/xen.lds.S b/xen/arch/x86/xen.lds.S
> index 11b1da2154..87e344d4dd 100644
> --- a/xen/arch/x86/xen.lds.S
> +++ b/xen/arch/x86/xen.lds.S
> @@ -134,7 +134,7 @@ SECTIONS
>         *(.ex_table.pre)
>         __stop___pre_ex_table = .;
>  
> -#if defined(CONFIG_HAS_VPCI) && defined(CONFIG_LATE_HWDOM)
> +#ifdef CONFIG_HAS_VPCI
>         . = ALIGN(POINTER_ALIGN);
>         __start_vpci_array = .;
>         *(SORT(.data.vpci.*))
> @@ -247,13 +247,6 @@ SECTIONS
>         *(.init_array)
>         *(SORT(.init_array.*))
>         __ctors_end = .;
> -
> -#if defined(CONFIG_HAS_VPCI) && !defined(CONFIG_LATE_HWDOM)
> -       . = ALIGN(POINTER_ALIGN);
> -       __start_vpci_array = .;
> -       *(SORT(.data.vpci.*))
> -       __end_vpci_array = .;
> -#endif
>    } PHDR(text)
>  
>    . = ALIGN(SECTION_ALIGN);
> diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci.c
> index 35e0190796..8928a1c07d 100644
> --- a/xen/drivers/passthrough/pci.c
> +++ b/xen/drivers/passthrough/pci.c
> @@ -756,10 +756,9 @@ int pci_add_device(u16 seg, u8 bus, u8 devfn,
>      if ( !pdev->domain )
>      {
>          pdev->domain = hardware_domain;
> -#ifdef CONFIG_ARM
>          /*
> -         * On ARM PCI devices discovery will be done by Dom0. Add vpci handler
> -         * when Dom0 inform XEN to add the PCI devices in XEN.
> +         * For devices not discovered by Xen during boot, add vPCI handlers
> +         * when Dom0 first informs Xen about such devices.
>           */
>          ret = vpci_add_handlers(pdev);
>          if ( ret )
> @@ -768,10 +767,10 @@ int pci_add_device(u16 seg, u8 bus, u8 devfn,
>              pdev->domain = NULL;
>              goto out;
>          }
> -#endif
>          ret = iommu_add_device(pdev);
>          if ( ret )
>          {
> +            vpci_remove_device(pdev);
>              pdev->domain = NULL;
>              goto out;
>          }
> @@ -819,6 +818,7 @@ int pci_remove_device(u16 seg, u8 bus, u8 devfn)
>      list_for_each_entry ( pdev, &pseg->alldevs_list, alldevs_list )
>          if ( pdev->bus == bus && pdev->devfn == devfn )
>          {
> +            vpci_remove_device(pdev);

vpci_remove_device is missing a check for has_vpci(pdev->domain), as
it will unconditionally access pdev->vpci otherwise, and that would be
wrong for domains not using vpci.

It might also be good to add an ASSERT(!pdev->vpci) to
vpci_add_handlers in order to make sure there are no duplicated calls
to vpci_add_handlers, but that can be done in a separate patch.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Wed Oct 20 07:52:55 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Oct 2021 07:52:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.213631.371913 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1md6P8-0003u8-EO; Wed, 20 Oct 2021 07:52:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 213631.371913; Wed, 20 Oct 2021 07:52:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1md6P8-0003u1-BD; Wed, 20 Oct 2021 07:52:54 +0000
Received: by outflank-mailman (input) for mailman id 213631;
 Wed, 20 Oct 2021 07:52:52 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ou1c=PI=citrix.com=roger.pau@srs-us1.protection.inumbo.net>)
 id 1md6P6-0003tr-Pd
 for xen-devel@lists.xenproject.org; Wed, 20 Oct 2021 07:52:52 +0000
Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 658f3b28-ab1c-4270-abcc-59a9e4fa3ad6;
 Wed, 20 Oct 2021 07:52:51 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 658f3b28-ab1c-4270-abcc-59a9e4fa3ad6
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1634716371;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=IhSAS3rv4rKboriy4QJILijX0v9ECvxZKnz0R3A+Wok=;
  b=IEwUCzV4bJfLmLlq8Dar4VennQadZUy2ZmSAvXFYKkNlbx/p3rAUe6Ul
   qyYslr9mN2CfI10VzGhQlnwICOer0iebxFd1XCgrs8i3KMoL1rk9xGQZm
   Us2F9r9BRYgDrwGKYpBVw5G2BF1tZWO/YDzOrALRbTgzlPuQlqOcEvdAL
   I=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: 70aFUX49wuSpgjubCYB8O4odPLu1pPmzwO/83ESWJg/KE0RMyKRmShbuhrdlz1XQW0Dptp78RQ
 b2nWUIwrheCRQ3cYlPLy240ikhlkwnFz+TRMSNsfuzu1p81fCUzxg/XMuTyqWT8xYuIDWLUhWw
 crLMz7kYAS5R367uno2inlB7X3g8UqoCXs868Ut1OfH7JXDaqCV5SMsSwRcks/72IVZsvrszCi
 XMLpBSC0mTYhzbbaZ9UruL6SX6xkxAd7PthziVS8L6hmwlKvglZ/HNiqTAcLRCtaliO+IUzgIA
 u1HK30OBRlzhL2BPbGwO443I
X-SBRS: 5.1
X-MesageID: 55169651
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:SiBdzK3UXm076eGxIvbD5T52kn2cJEfYwER7XKvMYLTBsI5bpzMPy
 mMcUWjQPa3fMzbxf9xzOYy2p0IFsZDcyt5gHQNvpC1hF35El5HIVI+TRqvS04J+DSFhoGZPt
 Zh2hgzodZhsJpPkS5PE3oHJ9RGQ74nRLlbHILOCan8ZqTNMEn970Es7wbZh2+aEvPDia++zk
 YKqyyHgEAfNNw5cagr4PIra9XuDFNyr0N8plgRWicJj5TcypFFMZH4rHomjLmOQf2VhNrXSq
 9Avbl2O1jixEx8FUrtJm1tgG6EAaua60QOm0hK6V0U+6/TrS+NbPqsTbZIhhUlrZzqhpex98
 tFB9rWMVxoGGJfMldkEaxhjDHQrVUFG0OevzXmXtMWSywvNcmf2wuUoB0YzVWEa0r8pWycUr
 6VecW1TKEDY7w616OvTpu1EnMMsIdOtJIoCknph0SvYHbAtRpWrr6DiuIIBgmZu25km8fD2X
 ekrSBVufCr7Rz51HQsOMtVhmLi3ryyqG9FfgA3M/vdmi4TJ9yRy3absNpzJe9WMbcRTgkuc4
 GnB+gzREhwccdCS1zeB2natnfPU2zP2XpoIE7+1/eIsh0ecrkQRAhALUVqwodGil1WzHdlYL
 iQpFjEG9PZoshbxF5+kAkP+8CXsUgMgt8R4KdE20gWBiYPo/Ru2IFIEQwNYUN0dq5pjLdA17
 WOhk9TsDD1plbSaT3OB67uZxQ+P1TgpwXwqPnBcE1NUizX3iMRq1EiXF4c8eEKgpoStQWmY/
 tyckMQpa1z/Z+Yw3KKn4UuPvTuoopXYJuLezlSKBjz7hu+ViYjMWmBJ1bQ5xaofRGp6ZgPY1
 JThpyR4xLpSZX1qvHfVKNjh5Jnzu5643MT02DaD5aUJ+TW34GKEdotN+jx4L0oBGp9aImO3P
 h6L418JvcY70J6WgUlfOd7Z5yMClvCIKDgYfqqMMoomjmZZJWdrAx2ClWbPhjuwwSDAYIk0O
 IuBcNbEMJrpIf8P8dZCfM9EieVD7nlnnQv7HMmnpzz6gev2TCPEEt8tbQrRBt3VGYvZ+W05B
 f4EbJDUo/ieOcWjChTqHXk7dw5adiZlWMiq8aS6tIere2JbJY3oMNeIqZsJcI15haVF0ODO+
 3C2QEhDz1Tjw3bALG23hrpLM9sDhL5z8iA2OzICJ1Gt1yRxaIqj9v5HJZA2YaMm5KpoyvstF
 6sJfMCJA/JuTDXb+mtCMcmh/dI6LBn71xiTOyeFYSQke8IyTQL+5dK5LBDk8zMDD3TruJJm8
 aGgzA7SXbEKWx9mUJTNcPuqwl7o5Sodlet+UlHmON5WfEmwooFmJzao1q08It0WKAWFzTyfj
 l7EDRAdrOjLgok07NiW2vzU89b3S7NzRxMIEXPa4LC6MTjh0lCimYIQAvyVeT39VX/v/Pnwb
 +ti0PyhYuYMm0xHstQgHu8zn74+/dbmu5RT0h9gQCfQd12uB75tfiuG0M1IuvEfz7NVo1LrC
 EeG+90cMrSVIsL1VlUWIVN9POiE0PgVnBjU7Og0fxqmtHMmouLfXBUAJQSIhQxcMKBxYdEsz
 uoWscIL7xCy10gxOdGcgyEIr2mBIxTsiUn8Wk321GMztjcW9w==
IronPort-HdrOrdr: A9a23:znox0632bcw8ESG7dXVL8AqjBThyeYIsimQD101hICG9Lfb3qy
 n+ppsmPEHP5Ar5OEtBpTiBUJPwJ0800aQFnLX5Wo3SIDUO2VHYVr2KiLGC/9SOIVyaygcw79
 YFT0E6MqyOMbEYt7eL3ODbKadZ/DDvysnB7o2yvhQdL3AYV0gj1XYDNu/yKDwGeOAsP+tBKH
 Pz3Lshm9L2Ek5nEPhTS0N1ENQq4Lbw5eXbSC9DIyRixBiFjDuu5rK/Ox+E3i0GWzcK5bs562
 DKnyHw+63m6piAu17h/l6Wy64TtMrqy9NFCsDJos8JKg/0ggLtQIh6QbWNsB08venqwlc3l9
 vnpQsmIq1Imj3sV1DwhSGo9xjr0T4o5XOn4ViEgUH7qci8fz4+A9opv/MSTjLpr24b+P1s2q
 NC2GyU87BNCwnboSj779/UEzl3i0uduxMZ4Kwupk0adbFbRK5arIQZ8k8QOowHBjjG5IcuF/
 QrJN3A5cxRbUiRYxnizypSKeSXLzAO9yq9Mw8/UpT/6UkRoJk59TpZ+CUnpAZEyHpnIKM0vt
 gtMcxT5fpzp4EtHPpA7Epoe7rANoX3e2O4DIulGyWuKEg2AQO+l3fJ2sRA2AiLQu1E8HJgou
 WMbLtn3VRCMn4GT/f+h6F2zg==
X-IronPort-AV: E=Sophos;i="5.87,166,1631592000"; 
   d="scan'208";a="55169651"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=metJU38H6LbblKo8hSycTJ6dpfxeuJAFuLO8AOdpeanQbOaVJmOWlxk7E/UBR+bh5VcJd1IcFrSLWrkgr+Yv4vOif5Mp38aDKZQkDEdd+UDDPVJOuc+tkVeriG+GJN2nsgdNJYjN0O/B0PbOm7Tq1F8FwDHw9F4ywrONmU/ifUcuSMUjaRim8Q/Ef/sKU9zVdvOn5YuNG3am0NXkj1iU3e3AZf76JTxAFLBJq12voBqj8UdRiWX6LJOnCXmzgaGoa5OP5VjRS7/QazQvKTVXLEy6CYQTrH9IHIvFiGnK2dWHHuhHEmcpfqO9CPxpe1yXojLOYoqnLoc/XY+NFccNFg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Tmuztz6vwa+9JX2I2mZx5cXZbfajbLXBNtVQbjZ2Gw8=;
 b=YguayAXQHtRIgLwMC5a6tELvO1OgM80hoBZpk+s7/3OLz8tQq03CIUtCGPhKrrCqb87kMYH3AHlL+KmGZaoK5vaJ5CnflADsa1WkjJFoN0TSA6QoSddMlVP0nF6ev+Jr+iLu4Fi9ZT3fnvt12UM2dp/d+/53B/AQ73H6i4UY9kJJ5krat3m+en384+gIUQMPclQMCaLPx8z9jy925ZbUHceMlpvoE2lvJnjtskamDDoN2lNUe0jHpHknWXTlFxRbKkUP9KBzFjw0gXWOQPpI4KGSOs7mxAA5FFRwgO68iqOcJErFKone3IrQ2mpi/xlXOTU5H6rRbF0NC+JJFFdS2w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Tmuztz6vwa+9JX2I2mZx5cXZbfajbLXBNtVQbjZ2Gw8=;
 b=dPttiOLr6pFwzoczKlGFMxVJfTN1Cd8yXiti4XNMgQHBXd59HpBVt1Y6UiOXlGpGRlMb8l4zx3/6228nAgT+og9w0SVZDUMvTB9G3KMyKKe+6XAv0wKr4i29VikHBj85B+V2lGsoMg0Kn2QL4NmB7H1Zn6GXdU4UWO2h5H/aW68=
Date: Wed, 20 Oct 2021 09:52:29 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, "Andrew
 Cooper" <andrew.cooper3@citrix.com>, George Dunlap
	<george.dunlap@citrix.com>, Kevin Tian <kevin.tian@intel.com>
Subject: Re: [PATCH v2] x86/PoD: defer nested P2M flushes
Message-ID: <YW/KvT/f9KE6dTGO@MacBook-Air-de-Roger.local>
References: <c6f2dcd7-81e6-3fb6-0e13-3ffb95e12bc1@suse.com>
 <YW7N13JsVfwwcqAl@MacBook-Air-de-Roger.local>
 <67220d20-9722-6566-0c6c-6166e346b09f@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <67220d20-9722-6566-0c6c-6166e346b09f@suse.com>
X-ClientProxiedBy: LO4P123CA0261.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:194::14) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 1488fb82-b1e4-4b11-de7b-08d9939e93c6
X-MS-TrafficTypeDiagnostic: DM6PR03MB5084:
X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <DM6PR03MB5084D87F62F75CC0891F373F8FBE9@DM6PR03MB5084.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: o08jPy3erxxukcZk4ydzgYXyd0KnkkHGfl1Nsvp5Yo3d2laVwHjOk5Ypa05ZS04XGp8Ig6x4HjimMv59+Ji/1MUo0bAmLLt7AOzQRuxBTOXhGmTtSUOzxKea5JaMGiFKVnXZDvarAnGC6SNm+/pPk6MUxFoWzFOezjZmH5qJP9RUVf4fg8esN0Jzvsfj3E0DqUFkm2rl/zmGNUgr1t2iZ28tmOQ6342C833Q5SQIAfKCMieMWAIhw0h7nDvUGV9WQWfv7CQi0tW8rsXq1W4MDV2GHHkOgNQ+wwZyNDNhsZoDIcc12Y8UK5Nld91vZVASiRBNLtnKgZT3W03NyTkEHX5GFO+JI0wLlJ+3zBW0O6FApn4CvDevrcAa9WFqVolzAXJJhuBfURPWU4YFOIMx7KHP59ZB+0sGjga//9v8Sduc5KqAIGbEioPML03D/hidsH3tF7rtXxsk82qkRDrSulEDKiVjwXPvCAL89Cx3fHYJuYAaUtz6lkM9aHt3hR5Ymzgx/tvwRRXigGx/s9roW+PALPX8vIK/VWbBW1eQKpVUYrFFcdylfi53AmpGvDBfzrqu0RhDJV/oA1LD5rMIcWSs6AszH9+9tuYgtMOwXduqrr1ooyBkyKXeRTpVfjwvsniNmugvyAO8/hVGIPkKlQ==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(956004)(5660300002)(85182001)(8936002)(2906002)(66946007)(6486002)(54906003)(316002)(26005)(82960400001)(6666004)(186003)(66556008)(86362001)(508600001)(4326008)(6496006)(38100700002)(8676002)(53546011)(6916009)(83380400001)(66476007)(9686003);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RE9DVGVXUzVRKytwR2hKS2dPNVJmMDhMQkJEZFpKRFlzK3ZHYzMwaWlsZTFS?=
 =?utf-8?B?YlRkVkN4bDNQTWRXSlRtenJzTUgzZTdNaXl2TG9ZZEY3bXQzY0ZEMkd1RjdP?=
 =?utf-8?B?dG9KcVZscFNMWUdBNmM5c1FBSDNnNHpMc281eWlxQVBBMlRSdXZCRXd2M0FM?=
 =?utf-8?B?d1BXRFg0dXp2RHNGUXVHcFRpbGptczFjZ1V4U3kxVTZyYy84d3hSY1puSG1s?=
 =?utf-8?B?bC9PZm9iTjRjUDE3Mkt3SklKVDdRVXQyWGp3ZGxJckxITXRUZUlUR1E1bVZW?=
 =?utf-8?B?QUxQYnFjTko1Y1ByQWp5bXNKTVUxY0RBY1VRU2Y2enZhb0hJRW5GK0d4ZzJK?=
 =?utf-8?B?VytTS1ZPbXhzNjk0T0R0aWJ5VTV3S0lBZjVLUjFoSithaGJhdU1zcENuZ2lZ?=
 =?utf-8?B?T1pBckhYQmc3VTVHczdPSWRRQVpCckdpaHE4RlF1TTJPSmhhTCswandvQ1FK?=
 =?utf-8?B?VDJQNTgzbWtjdlQ4VStTUUQ2Z0d1SFlESnZ0MXFGeG8yb1JZNGttUk9SYW5q?=
 =?utf-8?B?dkF4Y24xbm5DdDRwOXBoNmZyTERKUW9FYzV4SklEQmE3NTlURGV0OE9CSVZt?=
 =?utf-8?B?RlBrNzlYQzFTd0JJdEh5Yll2dUJJREJTbEhhSkNFT3pKUlVaN3loZ3NIU29G?=
 =?utf-8?B?WnBFUzZ2VGpaM3JXOG1hcU1GU0EvdXRON2JUSUZHQTFING5jWFB2V2FGRzZT?=
 =?utf-8?B?U2oxeEdwclBUNlJManVHZUpGdmZrMk05UEkrbldPbE8vUlBXT01zYWtTUHAw?=
 =?utf-8?B?VnBBek1FMlVOci8vN3JXRlNDc1ZKaDhqcStoUUlWNE1kVkNOaHpYSnFLTlZR?=
 =?utf-8?B?QnRZNEd5M0ZFb3pTakQzVmRnd3RZQnlvVW11cDFsMFdNb3ZmNktUOC9UQjMr?=
 =?utf-8?B?U2hzdTZjTCt2SWtmOUNsS2hNbEdxNmdPTVdrcmtDS2cvTGpUMHVkR29PNW92?=
 =?utf-8?B?T1hyb3JqTFVCN0pPMmdxSVdqcmtvREVWY0RTeGxmZFFGMmF1eG1OdmpoOE0y?=
 =?utf-8?B?VFZXbUJWZ3dxNHYzdVpKa2VzMmN6VHExL3Jzam8wLzNRWjdyTWJFRnI5UW92?=
 =?utf-8?B?Qm5EUjBTY2JXQTVlTGlzdVllOHNqOGNpcUd0cGJBTFV0TXZVbW5oOXpOVHN3?=
 =?utf-8?B?d0lGakl4TllEOTJqQVZ0MG9hZklkeW5OYmwzSzdnUS9uazI5UkdycFYrcngr?=
 =?utf-8?B?OFF5QW43anN6TGpDT2prb3RhNGYyV3BhTzgvMlNYZUZTMXZvb05IVzg0dDdv?=
 =?utf-8?B?WWhHc3lBWXJYSTVVY2pVWE84MW1Gb2dLc3BkSHhLbjY2Yi91WTJRU29TOWZY?=
 =?utf-8?B?dDhPWVhEOGVjOFZjWlNnbzNGNEtyYmJJQTRJOTRVckRVT1ZOM0lMOVBMNVBu?=
 =?utf-8?B?OG1iWERVZDhCK3ZQUVhrSzVzSWhXdlU1SVlWa0NLWmlFd0dLMCtiRmJVeEVm?=
 =?utf-8?B?Y1B4a0FTcTFXQitDZUR0bVZHaEN4UmQvSFVqSXBkQ1BHMkJGcTJleGVIeE5Y?=
 =?utf-8?B?YTFtcnZZNmZPcmFGNXFGUXhMUUdKd01FMFZOZ3FkaG9ueWQ3MkduMklOTzQ0?=
 =?utf-8?B?QXNIdjJXNmJoTzJHNU1aUmUvdHRWWFRyL0hqemlDcEFFNVlOTmhJemRQcUZq?=
 =?utf-8?B?dnovMXFPUWlKdzlBc1RoYWVhM0VUQkJ3Ukk4NlQ3alQrK0diU3NpTERkVlRz?=
 =?utf-8?B?YjYxZkFFYm94KzR2eWpWK29QV2p4T1ZMdHlWWE5hV1FJVFN2NFFIQUhheFpH?=
 =?utf-8?Q?vVflCewv/eWSkwgqBeanbvGE9X/5V6p/Rc8N2gK?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 1488fb82-b1e4-4b11-de7b-08d9939e93c6
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2021 07:52:34.4329
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: roger.pau@citrix.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB5084
X-OriginatorOrg: citrix.com

On Tue, Oct 19, 2021 at 05:06:27PM +0200, Jan Beulich wrote:
> On 19.10.2021 15:53, Roger Pau Monné wrote:
> > On Tue, Oct 19, 2021 at 02:52:27PM +0200, Jan Beulich wrote:
> >> With NPT or shadow in use, the p2m_set_entry() -> p2m_pt_set_entry() ->
> >> write_p2m_entry() -> p2m_flush_nestedp2m() call sequence triggers a lock
> >> order violation when the PoD lock is held around it. Hence such flushing
> >> needs to be deferred. Steal the approach from p2m_change_type_range().
> >> (Note that strictly speaking the change at the out_of_memory label is
> >> not needed, as the domain gets crashed there anyway. The change is being
> >> made nevertheless to avoid setting up a trap from someone meaning to
> >> deal with that case better than by domain_crash().)
> >>
> >> Similarly for EPT I think ept_set_entry() -> ept_sync_domain() ->
> >> ept_sync_domain_prepare() -> p2m_flush_nestedp2m() is affected. Make its
> >> p2m_flush_nestedp2m() invocation conditional. Note that this then also
> >> alters behavior of p2m_change_type_range() on EPT, deferring the nested
> >> flushes there as well. I think this should have been that way from the
> >> introduction of the flag.
> >>
> >> Reported-by: Elliott Mitchell <ehem+xen@m5p.com>
> >> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> > 
> > Acked-by: Roger Pau Monné <roger.pau@citrix.com>
> 
> Thanks.
> 
> >> --- a/xen/arch/x86/mm/p2m-ept.c
> >> +++ b/xen/arch/x86/mm/p2m-ept.c
> >> @@ -1253,7 +1253,7 @@ static void ept_sync_domain_prepare(stru
> >>      {
> >>          if ( p2m_is_nestedp2m(p2m) )
> >>              ept = &p2m_get_hostp2m(d)->ept;
> >> -        else
> >> +        else if ( !p2m->defer_nested_flush )
> >>              p2m_flush_nestedp2m(d);
> > 
> > I find this model slightly concerning, as we don't actually notify the
> > caller that a nested flush as been deferred, so we must make sure that
> > whoever sets defer_nested_flush also performs a flush unconditionally
> > when clearing the flag.
> 
> Well, this _is_ the model used for now. Until this change there was
> just a single party setting the flag. And like here, any new party
> setting the flag will also need to invoke a flush upon clearing it.
> It's not clear to me what alternative model you may have in mind.

I was mostly thinking of something similar to the
defer_flush/need_flush pair, where the need for a flush is signaled in
need_flush, so setting defer_flush doesn't automatically imply a flush
when clearing it.

Anyway, this is simple enough that it doesn't warrant the use of the
more complicated logic.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Wed Oct 20 07:57:52 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Oct 2021 07:57:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.213641.371924 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1md6Tt-0004eY-77; Wed, 20 Oct 2021 07:57:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 213641.371924; Wed, 20 Oct 2021 07:57:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1md6Tt-0004eR-3S; Wed, 20 Oct 2021 07:57:49 +0000
Received: by outflank-mailman (input) for mailman id 213641;
 Wed, 20 Oct 2021 07:57:47 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=faDG=PI=arm.com=Bertrand.Marquis@srs-us1.protection.inumbo.net>)
 id 1md6Tr-0004dl-Gi
 for xen-devel@lists.xenproject.org; Wed, 20 Oct 2021 07:57:47 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com (unknown
 [40.107.8.75]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 69810a8e-317b-11ec-8334-12813bfff9fa;
 Wed, 20 Oct 2021 07:57:46 +0000 (UTC)
Received: from AM5PR0601CA0084.eurprd06.prod.outlook.com (2603:10a6:206::49)
 by AM0PR08MB3809.eurprd08.prod.outlook.com (2603:10a6:208:103::16) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16; Wed, 20 Oct
 2021 07:57:27 +0000
Received: from VE1EUR03FT017.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:206:0:cafe::11) by AM5PR0601CA0084.outlook.office365.com
 (2603:10a6:206::49) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.16 via Frontend
 Transport; Wed, 20 Oct 2021 07:57:27 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT017.mail.protection.outlook.com (10.152.18.90) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.15 via Frontend Transport; Wed, 20 Oct 2021 07:57:26 +0000
Received: ("Tessian outbound 2e7020cc8961:v103");
 Wed, 20 Oct 2021 07:57:25 +0000
Received: from bd57d53b1f03.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 1992FFF0-5A7F-4ADC-81BE-937FC5361D90.1; 
 Wed, 20 Oct 2021 07:57:19 +0000
Received: from EUR03-AM5-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id bd57d53b1f03.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Wed, 20 Oct 2021 07:57:19 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com (2603:10a6:4:74::9)
 by DB6PR0801MB2118.eurprd08.prod.outlook.com (2603:10a6:4:37::9) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.18; Wed, 20 Oct
 2021 07:57:16 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955]) by DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955%4]) with mapi id 15.20.4608.018; Wed, 20 Oct 2021
 07:57:15 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 69810a8e-317b-11ec-8334-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=oF9NWZoFT2ZhVEYK+y1R+fwzoGvu+1baArmg1NDFZ9E=;
 b=4pZINI3GScG+dBLEMffuusTFnLGbzCc04JTHfGEBaglFC0zArYLvVOQAvlPsetDQuSxKrvBRhmaGRiKPiGGKFhf1+UUyCu+4dnLhGiYR5go1V5ovANL0ZY7VBs1MUw18Z3XFbEzo9/gaevEWkBwp0vmxhWB1KosBgZQ27fr1Xp4=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 9619fd86039c0e15
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=TfYcyJ9eeG1KYwJQd0+umNvgUcBOQKe0zCndIOyNT2NENrNyDyU5ZdtX2g3Nl+8C+PRSAlkyn3WZLWgbxdtt6u7PxQaKpfI5EQAwy4vkxr2zCgO5UYaG9WynjLqKFCvPHROjdrmdVCmnoCkLpNEM+T28iz7ojw7g7eKk1CFeTt+OHZe/7tniaZ3FToBy0SmmFZjZjtptZGwR4cOV91EfdnzyAO3ZK9LkHGMzhcljg44SnT0nAeaaDbzWxmoykVIbFuQVIZPW/3Ml979gh7FSfdRF9mA2CywPB8LUQB3s7ePu8/7okDSRDxmtycZ0sPPHlWP+0ai0VLxkWpZnVCC6zA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=oF9NWZoFT2ZhVEYK+y1R+fwzoGvu+1baArmg1NDFZ9E=;
 b=MqBIM9MAww30X0P8uC6UzxJmgy40tMD0E0yVWCtkEb/E8wd3keGbAtBaOJecK4i07c9SqCZDVI8U8X9Atky/c8+/35ciNCmxg1cga6UWOy5VnfUZ3w/hKAbJFnLYZewxABqs9hOaEiUnL5M6Cyl80xyKPelhn8Y6OuO3sg2DSNE6FJrj5l3Enu2fAh+2tpxLXy+sS43+n6siRjfuqqSfWT9w5O6rlbqx3Kj1v8UmOL5R5W85kZFRIyCkNxSbTk26aV84t75UER9Epy3RV7782ergj8/bLM+hoSpjbUsAO4xNIkLZQf6Ug5reHleYRiGxcIfFr4VSA5zcgTMmJ+q6lw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=oF9NWZoFT2ZhVEYK+y1R+fwzoGvu+1baArmg1NDFZ9E=;
 b=4pZINI3GScG+dBLEMffuusTFnLGbzCc04JTHfGEBaglFC0zArYLvVOQAvlPsetDQuSxKrvBRhmaGRiKPiGGKFhf1+UUyCu+4dnLhGiYR5go1V5ovANL0ZY7VBs1MUw18Z3XFbEzo9/gaevEWkBwp0vmxhWB1KosBgZQ27fr1Xp4=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>, "iwj@xenproject.org"
	<iwj@xenproject.org>, "Oleksandr_Andrushchenko@epam.com"
	<Oleksandr_Andrushchenko@epam.com>, Stefano Stabellini
	<sstabellini@kernel.org>, Julien Grall <julien@xen.org>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Jan Beulich <jbeulich@suse.com>, Andrew Cooper
	<andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>, Paul Durrant
	<paul@xen.org>
Subject: Re: [PATCH v2 1/1] xen/pci: Install vpci handlers on x86 and fix exit
 path
Thread-Topic: [PATCH v2 1/1] xen/pci: Install vpci handlers on x86 and fix
 exit path
Thread-Index: AQHXxQOsddT9Ttg6SUi4XsLpyj6SjavbhAEAgAACKIA=
Date: Wed, 20 Oct 2021 07:57:15 +0000
Message-ID: <85549220-AF96-4913-B672-ED6795C91C3D@arm.com>
References: <cover.1634659471.git.bertrand.marquis@arm.com>
 <d788dcce9e344a39f6761633f0e96774ab42c2aa.1634659471.git.bertrand.marquis@arm.com>
 <YW/KDHnZHz72mjuQ@MacBook-Air-de-Roger.local>
In-Reply-To: <YW/KDHnZHz72mjuQ@MacBook-Air-de-Roger.local>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3654.120.0.1.13)
Authentication-Results-Original: citrix.com; dkim=none (message not signed)
 header.d=none;citrix.com; dmarc=none action=none header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: 27d9682e-499f-4c55-489d-08d9939f4205
x-ms-traffictypediagnostic: DB6PR0801MB2118:|AM0PR08MB3809:
X-Microsoft-Antispam-PRVS:
	<AM0PR08MB3809A9C7CEC0B2859D4351459DBE9@AM0PR08MB3809.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:10000;OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 Tf5d43RXJhdTSN5eWV9XhY+IFWufqk0Ta/PFk6hnBNlrvGI7IduCYf36VFb+UY7p9HNyD1BJp6Rv8YL2CZNlXRZ2Hx+VTTQuLTF05ZN3Yn1U45a6VsNSwLOBxFSfsAEHQWPtzsVpujFi59mPha1LwdXBEjX64dNRFPeaV50YUpLHohroyJAMTVyDLJlcRVMNQXIn3KhO3vbFf33NkDzR5N3Kxs20N7BAQhUZHXXqLTZ8yx8aQq85NOOKMZrb4ddJ+TB0ttNZpjlUMTgaQO7Ngo3urdEOYsFQ4ZZ+UBDKQmGMEEAp6ZtSfL2PVno9z8zn47E3DRDFpHetW/4qyVWL/wrIFlUErgq9tokF1H2ifOI6ZvbGWGew3CmdvleIp6a9gSiZurN1k5pP1klHFBLTp0Wq5QriOE3a3SoEb+x32vHjmIjMZfmv5Qp6eXnyaIOT0T9GnYNfFCM1htqhBZVcdmILOr9TL6h3Sd6g2zZzLk+u2GP7D9eY9TloOck7wxuGTGhAzZhNBXyLF7T1KHSpAmrEjHPwBejwAQNwfBo8y3xpPMdlB+iR1gatlKoaXHsPS+0Flf7T48iS+unQxP8y/GuX7Fd3YYh6XqCujtTnPo3zKz8Ax0vTrSK1fjenMjeyeyLA92zs8jlpuxDKX+9Cb0OhAY2MWpU6XNIIlprwPwtNkxc+cezEzTwqAdUduzZ8h9gzOxmyplwQr26SLPD1yhUU8JhAhGTNqlQxmQ9nT7A6rx7ZSuk6Df3KzU4j0I7I
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB6PR0801MB2024.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(316002)(64756008)(36756003)(7416002)(186003)(54906003)(2616005)(8676002)(71200400001)(122000001)(66446008)(53546011)(26005)(76116006)(6506007)(6486002)(6512007)(8936002)(38070700005)(33656002)(6916009)(4326008)(66476007)(38100700002)(83380400001)(91956017)(66946007)(66556008)(5660300002)(508600001)(86362001)(2906002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="utf-8"
Content-ID: <16957B3E07206743AF7FB9748B325A8F@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0801MB2118
Original-Authentication-Results: citrix.com; dkim=none (message not signed)
 header.d=none;citrix.com; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT017.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	5fbae755-4065-496c-47b1-08d9939f3baa
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Jh6GPxNFA1VxiTAB9wUnJS3D9psXOnx1VKEzg3DZFiMkm63RKGiVLXpELTOqbihCoxnRXpp19ERxzPVlWCOIa3caGNpI0IzvZY+I8N9mDVOonitdBxp+ktjBfz0Mn5uovyDmnbqurdDEJ5AAG7DOd3ecZbMYA39Qf/ToSenN0UToBJWYp0/obarN9o+/prSsjVsVU9oCcLFLko1PHMi3xbIFsFtR6Nt9NYM9XAoZNskz3Kq+7cwP8JwgT2ro/ba9ubbrUdE34VJ6TSAYo3c16shPWu1S1SiP1poEacFEdgznYG5Zpm9UZaR67ZNBDiM8S42wBGT+Dm16J1mGHAHq58crzzwRO/gUAhAiih2pDENDV8dCuWoKT78GSOinbME4k2WDkAGCXmlOlyy1zkOL4uyiIy+KzYzw1H7WVx1n+8/volkYYNCLUpIUxZle4b+Hm9oQdQ9LWVWeGq+w5qLHuvScJJInaVe/b62fmK2ydC6PAGXa5tg0/kMEvKWRo6Zrz6fiaw6v8CofFwHR+Bty0BJYg2hMZBc1UowIN05UzX0+nYovEEjnDRf46XzsJvYcMKq9WZZqv+TZIiKN/o3VhtjSbowwA5RaXqs/kw57RPnTcoJ8+DVolGP2l49z2W+o+99OgbWV50Ae0FPiaHqEiHQzRTM4NetckZcV81++2PK7KuALZIJSfIG5qFHcU5ovF6Gqm1QNVtALlqWsPWU8ag==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(82310400003)(33656002)(6506007)(5660300002)(26005)(336012)(83380400001)(8936002)(2906002)(70206006)(2616005)(36756003)(54906003)(81166007)(86362001)(356005)(6512007)(316002)(36860700001)(6486002)(186003)(53546011)(70586007)(508600001)(6862004)(4326008)(8676002)(47076005);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2021 07:57:26.5012
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 27d9682e-499f-4c55-489d-08d9939f4205
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT017.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3809

SGkgUm9nZXIsDQoNCj4gT24gMjAgT2N0IDIwMjEsIGF0IDA4OjQ5LCBSb2dlciBQYXUgTW9ubsOp
IDxyb2dlci5wYXVAY2l0cml4LmNvbT4gd3JvdGU6DQo+IA0KPiBPbiBUdWUsIE9jdCAxOSwgMjAy
MSBhdCAwNTowODoyOFBNICswMTAwLCBCZXJ0cmFuZCBNYXJxdWlzIHdyb3RlOg0KPj4gWGVuIG1p
Z2h0IG5vdCBiZSBhYmxlIHRvIGRpc2NvdmVyIGF0IGJvb3QgdGltZSBhbGwgZGV2aWNlcyBvciBz
b21lIGRldmljZXMNCj4+IG1pZ2h0IGFwcGVhciBhZnRlciBzcGVjaWZpYyBhY3Rpb25zIGZyb20g
ZG9tMC4NCj4+IEluIHRoaXMgY2FzZSBkb20wIGNhbiB1c2UgdGhlIFBIWVNERVZPUF9wY2lfZGV2
aWNlX2FkZCB0byBzaWduYWwgc29tZQ0KPj4gUENJIGRldmljZXMgdG8gWGVuLg0KPj4gQXMgdGhv
c2UgZGV2aWNlcyB3aGVyZSBub3Qga25vd24gZnJvbSBYZW4gYmVmb3JlLCB0aGUgdnBjaSBoYW5k
bGVycyBtdXN0DQo+PiBiZSBwcm9wZXJseSBpbnN0YWxsZWQgZHVyaW5nIHBjaV9kZXZpY2VfYWRk
IGZvciB4ODYgUFZIIERvbTAsIGluIHRoZQ0KPj4gc2FtZSB3YXkgYXMgd2hhdCBpcyBkb25lIGN1
cnJlbnRseSBvbiBhcm0gKHdoZXJlIFhlbiBkb2VzIG5vdCBkZXRlY3QgUENJDQo+PiBkZXZpY2Vz
IGJ1dCByZWxpZXMgb24gRG9tMCB0byBkZWNsYXJlIHRoZW0gYWxsIHRoZSB0aW1lKS4NCj4+IA0K
Pj4gU28gdGhpcyBwYXRjaCBpcyByZW1vdmluZyB0aGUgaWZkZWYgcHJvdGVjdGluZyB0aGUgY2Fs
bCB0bw0KPj4gdnBjaV9hZGRfaGFuZGxlcnMgYW5kIHRoZSBjb21tZW50IHdoaWNoIHdhcyBhcm0g
c3BlY2lmaWMuDQo+PiANCj4+IHZwY2lfYWRkX2hhbmRsZXJzIGlzIGNhbGxlZCBvbiBkdXJpbmcg
cGNpX2RldmljZV9hZGQgd2hpY2ggY2FuIGJlIGNhbGxlZA0KPj4gYXQgcnVudGltZSB0aHJvdWdo
IGh5cGVyY2FsbCBwaHlzZGV2X29wLg0KPj4gUmVtb3ZlIF9faHdkb21faW5pdCBhcyB0aGUgY2Fs
bCBpcyBub3QgbGltaXRlZCBhbnltb3JlIHRvIGhhcmR3YXJlDQo+PiBkb21haW4gaW5pdCBhbmQg
Zml4IGxpbmtlciBzY3JpcHQgdG8gb25seSBrZWVwIHZwY2lfYXJyYXkgaW4gcm9kYXRhDQo+PiBz
ZWN0aW9uLg0KPj4gDQo+PiBBZGQgbWlzc2luZyB2cGNpIGhhbmRsZXJzIGNsZWFudXAgZHVyaW5n
IHBjaV9kZXZpY2VfcmVtb3ZlIGFuZCBpbiBjYXNlDQo+PiBvZiBlcnJvciB3aXRoIGlvbW11IGR1
cmluZyBwY2lfZGV2aWNlX2FkZC4NCj4+IA0KPj4gQWRkIGVtcHR5IHN0YXRpYyBpbmxpbmUgZm9y
IHZwY2lfcmVtb3ZlX2RldmljZSB3aGVuIENPTkZJR19WUENJIGlzIG5vdA0KPj4gZGVmaW5lZC4N
Cj4+IA0KPj4gRml4ZXM6IGQ1OTE2OGRjMDUgKCJ4ZW4vYXJtOiBFbmFibGUgdGhlIGV4aXN0aW5n
IHg4NiB2aXJ0dWFsIFBDSSBzdXBwb3J0DQo+PiBmb3IgQVJNIikNCj4+IFN1Z2dlc3RlZC1ieTog
SmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPg0KPj4gU2lnbmVkLW9mZi1ieTogQmVydHJh
bmQgTWFycXVpcyA8YmVydHJhbmQubWFycXVpc0Bhcm0uY29tPg0KPj4gLS0tDQo+PiBDaGFuZ2Vz
IGluIHYyDQo+PiAtIGFkZCBjb21tZW50IHN1Z2dlc3RlZCBieSBKYW4gb24gdG9wIG9mIHZwY2lf
YWRkX2hhbmRsZXJzIGNhbGwNCj4+IC0gbWVyZ2UgdGhlIDMgcGF0Y2hlcyBvZiB0aGUgc2VyaWUg
aW4gb25lIHBhdGNoIGFuZCByZW5hbWVkIGl0DQo+PiAtIGZpeCB4ODYgYW5kIGFybSBsaW5rZXIg
c2NyaXB0IHRvIG9ubHkga2VlcCB2cGNpX2FycmF5IGluIHJvZGF0YSBhbmQNCj4+IG9ubHkgd2hl
biBDT05GSUdfVlBDSSBpcyBzZXQuDQo+PiAtLS0NCj4+IHhlbi9hcmNoL2FybS94ZW4ubGRzLlMg
ICAgICAgIHwgOSArLS0tLS0tLS0NCj4+IHhlbi9hcmNoL3g4Ni94ZW4ubGRzLlMgICAgICAgIHwg
OSArLS0tLS0tLS0NCj4+IHhlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL3BjaS5jIHwgOCArKysrLS0t
LQ0KPj4geGVuL2RyaXZlcnMvdnBjaS92cGNpLmMgICAgICAgfCAyICstDQo+PiB4ZW4vaW5jbHVk
ZS94ZW4vdnBjaS5oICAgICAgICB8IDIgKysNCj4+IDUgZmlsZXMgY2hhbmdlZCwgOSBpbnNlcnRp
b25zKCspLCAyMSBkZWxldGlvbnMoLSkNCj4+IA0KPj4gZGlmZiAtLWdpdCBhL3hlbi9hcmNoL2Fy
bS94ZW4ubGRzLlMgYi94ZW4vYXJjaC9hcm0veGVuLmxkcy5TDQo+PiBpbmRleCBiNzczZjkxZjFj
Li4wODAxNjk0OGFiIDEwMDY0NA0KPj4gLS0tIGEveGVuL2FyY2gvYXJtL3hlbi5sZHMuUw0KPj4g
KysrIGIveGVuL2FyY2gvYXJtL3hlbi5sZHMuUw0KPj4gQEAgLTYwLDcgKzYwLDcgQEAgU0VDVElP
TlMNCj4+ICAgICAgICAqKC5wcm9jLmluZm8pDQo+PiAgICAgICAgX19wcm9jX2luZm9fZW5kID0g
LjsNCj4+IA0KPj4gLSNpZiBkZWZpbmVkKENPTkZJR19IQVNfVlBDSSkgJiYgZGVmaW5lZChDT05G
SUdfTEFURV9IV0RPTSkNCj4+ICsjaWZkZWYgQ09ORklHX0hBU19WUENJDQo+PiAgICAgICAgLiA9
IEFMSUdOKFBPSU5URVJfQUxJR04pOw0KPj4gICAgICAgIF9fc3RhcnRfdnBjaV9hcnJheSA9IC47
DQo+PiAgICAgICAgKihTT1JUKC5kYXRhLnZwY2kuKikpDQo+PiBAQCAtMTg5LDEzICsxODksNiBA
QCBTRUNUSU9OUw0KPj4gICAgICAgICooLmluaXRfYXJyYXkpDQo+PiAgICAgICAgKihTT1JUKC5p
bml0X2FycmF5LiopKQ0KPj4gICAgICAgIF9fY3RvcnNfZW5kID0gLjsNCj4+IC0NCj4+IC0jaWYg
ZGVmaW5lZChDT05GSUdfSEFTX1ZQQ0kpICYmICFkZWZpbmVkKENPTkZJR19MQVRFX0hXRE9NKQ0K
Pj4gLSAgICAgICAuID0gQUxJR04oUE9JTlRFUl9BTElHTik7DQo+PiAtICAgICAgIF9fc3RhcnRf
dnBjaV9hcnJheSA9IC47DQo+PiAtICAgICAgICooU09SVCguZGF0YS52cGNpLiopKQ0KPj4gLSAg
ICAgICBfX2VuZF92cGNpX2FycmF5ID0gLjsNCj4+IC0jZW5kaWYNCj4+ICAgfSA6dGV4dA0KPj4g
ICBfX2luaXRfZW5kX2VmaSA9IC47DQo+PiAgIC4gPSBBTElHTihTVEFDS19TSVpFKTsNCj4+IGRp
ZmYgLS1naXQgYS94ZW4vYXJjaC94ODYveGVuLmxkcy5TIGIveGVuL2FyY2gveDg2L3hlbi5sZHMu
Uw0KPj4gaW5kZXggMTFiMWRhMjE1NC4uODdlMzQ0ZDRkZCAxMDA2NDQNCj4+IC0tLSBhL3hlbi9h
cmNoL3g4Ni94ZW4ubGRzLlMNCj4+ICsrKyBiL3hlbi9hcmNoL3g4Ni94ZW4ubGRzLlMNCj4+IEBA
IC0xMzQsNyArMTM0LDcgQEAgU0VDVElPTlMNCj4+ICAgICAgICAqKC5leF90YWJsZS5wcmUpDQo+
PiAgICAgICAgX19zdG9wX19fcHJlX2V4X3RhYmxlID0gLjsNCj4+IA0KPj4gLSNpZiBkZWZpbmVk
KENPTkZJR19IQVNfVlBDSSkgJiYgZGVmaW5lZChDT05GSUdfTEFURV9IV0RPTSkNCj4+ICsjaWZk
ZWYgQ09ORklHX0hBU19WUENJDQo+PiAgICAgICAgLiA9IEFMSUdOKFBPSU5URVJfQUxJR04pOw0K
Pj4gICAgICAgIF9fc3RhcnRfdnBjaV9hcnJheSA9IC47DQo+PiAgICAgICAgKihTT1JUKC5kYXRh
LnZwY2kuKikpDQo+PiBAQCAtMjQ3LDEzICsyNDcsNiBAQCBTRUNUSU9OUw0KPj4gICAgICAgICoo
LmluaXRfYXJyYXkpDQo+PiAgICAgICAgKihTT1JUKC5pbml0X2FycmF5LiopKQ0KPj4gICAgICAg
IF9fY3RvcnNfZW5kID0gLjsNCj4+IC0NCj4+IC0jaWYgZGVmaW5lZChDT05GSUdfSEFTX1ZQQ0kp
ICYmICFkZWZpbmVkKENPTkZJR19MQVRFX0hXRE9NKQ0KPj4gLSAgICAgICAuID0gQUxJR04oUE9J
TlRFUl9BTElHTik7DQo+PiAtICAgICAgIF9fc3RhcnRfdnBjaV9hcnJheSA9IC47DQo+PiAtICAg
ICAgICooU09SVCguZGF0YS52cGNpLiopKQ0KPj4gLSAgICAgICBfX2VuZF92cGNpX2FycmF5ID0g
LjsNCj4+IC0jZW5kaWYNCj4+ICAgfSBQSERSKHRleHQpDQo+PiANCj4+ICAgLiA9IEFMSUdOKFNF
Q1RJT05fQUxJR04pOw0KPj4gZGlmZiAtLWdpdCBhL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL3Bj
aS5jIGIveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvcGNpLmMNCj4+IGluZGV4IDM1ZTAxOTA3OTYu
Ljg5MjhhMWMwN2QgMTAwNjQ0DQo+PiAtLS0gYS94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC9wY2ku
Yw0KPj4gKysrIGIveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvcGNpLmMNCj4+IEBAIC03NTYsMTAg
Kzc1Niw5IEBAIGludCBwY2lfYWRkX2RldmljZSh1MTYgc2VnLCB1OCBidXMsIHU4IGRldmZuLA0K
Pj4gICAgIGlmICggIXBkZXYtPmRvbWFpbiApDQo+PiAgICAgew0KPj4gICAgICAgICBwZGV2LT5k
b21haW4gPSBoYXJkd2FyZV9kb21haW47DQo+PiAtI2lmZGVmIENPTkZJR19BUk0NCj4+ICAgICAg
ICAgLyoNCj4+IC0gICAgICAgICAqIE9uIEFSTSBQQ0kgZGV2aWNlcyBkaXNjb3Zlcnkgd2lsbCBi
ZSBkb25lIGJ5IERvbTAuIEFkZCB2cGNpIGhhbmRsZXINCj4+IC0gICAgICAgICAqIHdoZW4gRG9t
MCBpbmZvcm0gWEVOIHRvIGFkZCB0aGUgUENJIGRldmljZXMgaW4gWEVOLg0KPj4gKyAgICAgICAg
ICogRm9yIGRldmljZXMgbm90IGRpc2NvdmVyZWQgYnkgWGVuIGR1cmluZyBib290LCBhZGQgdlBD
SSBoYW5kbGVycw0KPj4gKyAgICAgICAgICogd2hlbiBEb20wIGZpcnN0IGluZm9ybXMgWGVuIGFi
b3V0IHN1Y2ggZGV2aWNlcy4NCj4+ICAgICAgICAgICovDQo+PiAgICAgICAgIHJldCA9IHZwY2lf
YWRkX2hhbmRsZXJzKHBkZXYpOw0KPj4gICAgICAgICBpZiAoIHJldCApDQo+PiBAQCAtNzY4LDEw
ICs3NjcsMTAgQEAgaW50IHBjaV9hZGRfZGV2aWNlKHUxNiBzZWcsIHU4IGJ1cywgdTggZGV2Zm4s
DQo+PiAgICAgICAgICAgICBwZGV2LT5kb21haW4gPSBOVUxMOw0KPj4gICAgICAgICAgICAgZ290
byBvdXQ7DQo+PiAgICAgICAgIH0NCj4+IC0jZW5kaWYNCj4+ICAgICAgICAgcmV0ID0gaW9tbXVf
YWRkX2RldmljZShwZGV2KTsNCj4+ICAgICAgICAgaWYgKCByZXQgKQ0KPj4gICAgICAgICB7DQo+
PiArICAgICAgICAgICAgdnBjaV9yZW1vdmVfZGV2aWNlKHBkZXYpOw0KPj4gICAgICAgICAgICAg
cGRldi0+ZG9tYWluID0gTlVMTDsNCj4+ICAgICAgICAgICAgIGdvdG8gb3V0Ow0KPj4gICAgICAg
ICB9DQo+PiBAQCAtODE5LDYgKzgxOCw3IEBAIGludCBwY2lfcmVtb3ZlX2RldmljZSh1MTYgc2Vn
LCB1OCBidXMsIHU4IGRldmZuKQ0KPj4gICAgIGxpc3RfZm9yX2VhY2hfZW50cnkgKCBwZGV2LCAm
cHNlZy0+YWxsZGV2c19saXN0LCBhbGxkZXZzX2xpc3QgKQ0KPj4gICAgICAgICBpZiAoIHBkZXYt
PmJ1cyA9PSBidXMgJiYgcGRldi0+ZGV2Zm4gPT0gZGV2Zm4gKQ0KPj4gICAgICAgICB7DQo+PiAr
ICAgICAgICAgICAgdnBjaV9yZW1vdmVfZGV2aWNlKHBkZXYpOw0KPiANCj4gdnBjaV9yZW1vdmVf
ZGV2aWNlIGlzIG1pc3NpbmcgYSBjaGVjayBmb3IgaGFzX3ZwY2kocGRldi0+ZG9tYWluKSwgYXMN
Cj4gaXQgd2lsbCB1bmNvbmRpdGlvbmFsbHkgYWNjZXNzIHBkZXYtPnZwY2kgb3RoZXJ3aXNlLCBh
bmQgdGhhdCB3b3VsZCBiZQ0KPiB3cm9uZyBmb3IgZG9tYWlucyBub3QgdXNpbmcgdnBjaS4NCj4g
DQo+IEl0IG1pZ2h0IGFsc28gYmUgZ29vZCB0byBhZGQgYW4gQVNTRVJUKCFwZGV2LT52cGNpKSB0
bw0KPiB2cGNpX2FkZF9oYW5kbGVycyBpbiBvcmRlciB0byBtYWtlIHN1cmUgdGhlcmUgYXJlIG5v
IGR1cGxpY2F0ZWQgY2FsbHMNCj4gdG8gdnBjaV9hZGRfaGFuZGxlcnMsIGJ1dCB0aGF0IGNhbiBi
ZSBkb25lIGluIGEgc2VwYXJhdGUgcGF0Y2guDQoNCkkgY2FuIGRvIGJvdGggaW4gdjMgKHRvZ2V0
aGVyIHdpdGggdGhlIGNoYW5nZSBvZiBpbiB0aGUgcGF0Y2ggbmFtZSkuDQoNClVubGVzcyB5b3Ug
d2FudCB0aGUgQVNTRVJUIGluIGEgZGlmZmVyZW50IHBhdGNoLCBpbiB0aGlzIGNhc2UgSSBkbyBu
b3QgdGhpbmsNCkkgY2FuIG1ha2UgYSBuZXcgcGF0Y2ggZm9yIHRoYXQuDQoNCkNhbiB5b3UgY29u
ZmlybSBpZiBJIHNob3VsZCBvciBub3QgYWRkIHRoZSBBU1NFUlQgZGlyZWN0bHkgaW4gdGhlIHBh
dGNoID8NCg0KDQpSZWdhcmRzDQpCZXJ0cmFuZA0KDQoNCj4gDQo+IFRoYW5rcywgUm9nZXIuDQoN
Cg==


From xen-devel-bounces@lists.xenproject.org Wed Oct 20 08:05:41 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Oct 2021 08:05:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.213653.371935 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1md6bK-0006d7-5e; Wed, 20 Oct 2021 08:05:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 213653.371935; Wed, 20 Oct 2021 08:05:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1md6bK-0006d0-1Y; Wed, 20 Oct 2021 08:05:30 +0000
Received: by outflank-mailman (input) for mailman id 213653;
 Wed, 20 Oct 2021 08:05:28 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ou1c=PI=citrix.com=roger.pau@srs-us1.protection.inumbo.net>)
 id 1md6bI-0006cu-A5
 for xen-devel@lists.xenproject.org; Wed, 20 Oct 2021 08:05:28 +0000
Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id a7917d1a-5f75-4bae-ae1c-92570ad36dd0;
 Wed, 20 Oct 2021 08:05:26 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a7917d1a-5f75-4bae-ae1c-92570ad36dd0
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1634717126;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=wucdKA0RygAlhaAR59IhWFX2fGhd36Ovw5uoj1QwHUM=;
  b=I2TPPM3MjlJW2uamGjTzq+hAf12ClNh4koOq3P5/KnplC5dzje8ncrT/
   4bhWKq1mIcjVKwgMGGIq82jLnYGqm7P+1c4PuTc6dLpvIM764APgrAK/x
   UbIeCo6ivIX3H+EiuEFc1Qr7YXrNKwc+ygF0eceE+mNIw54lJ7nTpuvie
   Q=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: QMIyo2Bt100lZ4u8azzn8oibuj+5kHuuf/n1BlOXUCgHgRbc6QwWuclg3f7yGwgLiq6rJyTd8c
 l0Dm5MoPNP70ELGzxf498LLLH1VJE2vNJiaP3YG0/mqgfCgE4v91q0uNwygfhSg+XwPf6BqCU+
 WUzFU5QUBjrTCuWsXKTRle3JqxthlfyAAzv/KJ/ck8xpkJVUJkIDhqQTKvA6bmv3riDjj+oZC2
 au2aYuR/p2LIyApKFrpK2x08Bk4X51/6NcVZ8M13SguyQ5cfCOARh7GUOp1H+vxHxMdbRDgBUK
 sKHxavnbOj01lpj0kUd864Xi
X-SBRS: 5.1
X-MesageID: 56007876
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:r9XlHK9xocUl41NCqqhNDrUD3XiTJUtcMsCJ2f8bNWPcYEJGY0x3n
 2cbXT+GM/aNMTT1fo9ybdmy8x8Pv5PXmtEwTAA+/yo8E34SpcT7XtnIdU2Y0wF+jyHgoOCLy
 +1EN7Es+ehtFie0Si9AttENlFEkvU2ybuOU5NXsZ2YhGmeIdA970Ug6wrZj2tYx6TSEK1jlV
 e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH
 I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPhIy
 4RPvIGpVjtqJ7SXmr0NVAZWHiZXaPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us
 6ZCcXZUM07F17neLLGTE4GAguw5K8bmJsUHs2xIxjDFF/c2B5vERs0m4PcFgm9o2ZARQ54yY
 eI9aHlIMQTkWiFUJwc6UbgRg+GorH3wJmgwRFW9+vNsvjm7IBZK+LTkLtf9YNGBQsRR2EGCq
 Qru/WvjBQoBHMeC0jfD+XWp7sffkCW+VI8MGbmQ8v9xnEbV1mEVEAcRV1awvb++kEHWc+xYL
 0sY6y8/t58Y/UagTsT+dxCgqXvCtRkZM/JLCPEz4gyJzqvS4i6aC3ICQzoHb8Yp3Oc3Wj4Cx
 lKPh8nuBzFkrPuSU3313rWeoC62OCMVBXQffiJCRgwAi/HhvYUygxTnXttlVqmvgbXdBjXY0
 z2M6i8kiN0uYdUjjvvhuwqd2nT1+8aPHlVdChjrsnyN1wAoZoe4fpOUqkHCtvQZPIGGQFSGl
 S1R8ySB19wmAZaInS2LZewCGrC1+vqIWAHhbU5T84oJrGv1pSbyFWxEyHQnfh0xa5dbEdP8S
 BaL4Vs52XNFAJe9gUabiaqKAMM20bOoK93hUv3FBjalSsksLFHZlM2CiEj54owMrKTOuf1gU
 Xt4WZz1ZZr/NUiB5GDqLwv6+eRzrh3SPUuJGfjGI+2PiNJynkK9R7YfK0epZesk9q6Cqwi92
 48BbJfUlUQHCrGmO3C/HWsvwbYidyRT6Xfe8JQ/SwJ+ClA+RDFJ5wH5kNvNhLCJb4wKz7yVr
 xlRq2dTyUblhG2vFOl5QisLVV8bZr4m9ShTFXV1ZT6AgiF/Ca7yvPZ3X8ZmJtEPqb08pcOYu
 tFYIq1s9NwUEW+Zk9ncBLGgxLFfmOOD31zeZHT7PWBjJfaNhWXho7fZQ+cmzwFXZgKfvsoiu
 bywkATdRJsIXQN5C8jKLvmoyjuMUbI1xIqehmPEfYteflvC6o9vJ3Cjh/M7OZhUex7C2iGbx
 0CdBhJB/bvBpIo88d/og6GYrtj2T7siTxQCR2SLv6yrMST6/3a4xdMSWui/Yj2ABnj//7+vZ
 LsJwqikYuEHhltDr6F1D61vkfAl/9LqqrIDllZkEXzHYk6FELRlJnXaj8BDurcUnu1SuBesW
 1LJ8d5fYO3bNMTgGV8XBQwkcuXciq1ExmiMtaw4eRyo6jV28byLVVRpEyON0CENfqFoNI4Fw
 Ps6vJJE4QKIlRd3YM2NiTpZ9jrQIyVYAbknrJwTHKTilhEvlgNZeZXZByL7vMOPZtFLPhV4K
 zOYnvOf1bFVx06EeHsvD3ndm+FagM1W6hxNyVYDIXWPm8bE2aBrjEEAr2xvQ1QH1AhD3sJyJ
 nNvZh98Kqi59jt1gNROAjK3EAZbCRzFokH8xjPlToECo5VEgoAVEFAABA==
IronPort-HdrOrdr: A9a23:ahX1dKqnKZQyQ5g42073Pn8aV5u2L9V00zEX/kB9WHVpm5Oj+f
 xGzc516farslossREb+expOMG7MBXhHLpOkPQs1NaZLXPbUQ6TTb2KgrGSpgEIdxeOktK1kJ
 0QD5SWa+eAfGSS7/yKmDVQeuxIqLLsndHK9IWuv0uFDzsaEJ2Ihz0JdDpzeXcGPTWua6BJc6
 Z1saF81kWdkDksH4mGL0hAe9KGi8zAlZrgbxJDLxk76DOWhTftzLLhCRCX0joXTjsKmN4ZgC
 f4uj28wp/mn+Cwyxfa2WOWx5NKmOH5wt8GIMCXkMAaJhjllw7tToV8XL+puiwzvYiUmRoXue
 iJhy1lE9V46nvXcG3wiRzx2zP42DJr0HPmwU/wuwqqneXJABYBT+ZRj4NQdRXUr2A6ustn7a
 5N12WF87JKEBLphk3Glpj1fiAvsnDxjWspkOYVgXAae5AZcqVtoYsW+14QOIscHRj99JssHI
 BVfYDhDc5tABGnhk3izyxSKITGZAV2Iv7GeDlNhiWt6UkUoJgjpHFog/D2nR87hdsAotd/lq
 L52gkBrsA7ciYsV9MOOA42e7rANoX8e2O+DIusGyWTKEgmAQOHl3el2sR+2AmVEKZ4u6fa3q
 6xCW9liQ==
X-IronPort-AV: E=Sophos;i="5.87,166,1631592000"; 
   d="scan'208";a="56007876"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=nI/t32u9cO+HOm5Tq9bv+HVs7pFltMCS6DwGKgPBcqNFaqFQpbhV6eVy9LSft28e80OyuloyD69nsiDifDDcblObscPQmnK9TLzjvEQjnmeMTnS5haLYmlWW0qpDSI00VMXg6zPLtbtqmygcqXauHrWCyD8P8aGYI9ocr/GXu4jlSvTxT8fTa9aYVTfPBpiijFsdZpYMiWrafL7CaajybFMrzT8fdY/z7FLBh/Uh903cvUNrOUakL48F7YOUT/8+PFcsbBguJv4eQKPHZ+QfNdFjAOLhoQKGNfpdFToqrcMYfgF3W4cKnBbvTyd0N0zG6bOW5ju2RNARee0kOK59WA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=zyOT0Pr+szytsUQEfzSP45LbnH/3LUj0vec8V00ENuM=;
 b=ZaV+fnNF0aoLYRGXK0qgsHYePV2bShuHZ8eD1fTgKUojWEPJidMkqZ0trqLfwh9YZ8lU8lVqAYh9L7knCNp741Cx8Jyrq3FmfHPQV4c1hJWOdyDraN+JdhNsogm6GTCVwBxGJ719rjsURMxx763PFYfpDyyM6Mkm0dMhG6j8oyCfc26U16zVbXA/6V+Q4x0XLfVUNYfi16ywlFy8NR1+lNm5uR4dHdUlyIvuSixekmNRLXwaEbvKilbSm1XNr/NffSHNbdmNmA1QUhCGUw4aSQL5mU+YkjOIFziWJDRBNT/ctzHu5A+WnvsmTCDkFcCThyA63nIem4sj8qpDjWhOqg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=zyOT0Pr+szytsUQEfzSP45LbnH/3LUj0vec8V00ENuM=;
 b=EPkXLr0f+ZSloRvWI2am+Z4QCZE96/TWWNnRnC89krKIsqZ9sesg0Qe8sNeiBYMgBEvexh9wRYjUtOD390T6IClDsfxLZ+Dc6otvM4Es9T4XXk565/i9r28TiUVFsfoZjJqVCA8weIQkd5bfK6qupGXcbgHf1HZghOmKBqavqQE=
Date: Wed, 20 Oct 2021 10:04:26 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>, Andrew Cooper
	<andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>,
	"Julien Grall" <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
	"Anthony PERARD" <anthony.perard@citrix.com>, Juergen Gross
	<jgross@suse.com>, Christian Lindig <christian.lindig@citrix.com>, David
 Scott <dave@recoil.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	<xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v2 2/6] gnttab: allow setting max version per-domain
Message-ID: <YW/NipJMLH0Zz05s@MacBook-Air-de-Roger.local>
References: <20210922082123.54374-1-roger.pau@citrix.com>
 <20210922082123.54374-3-roger.pau@citrix.com>
 <f5564634-5f9e-0b94-f73a-d44ae65c30f4@suse.com>
 <0b58667f-b6bc-d5b5-2dd1-0c8996367319@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <0b58667f-b6bc-d5b5-2dd1-0c8996367319@suse.com>
X-ClientProxiedBy: LO2P123CA0027.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600::15)
 To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 7228e657-e92e-4a3a-3e4f-08d993a03ee9
X-MS-TrafficTypeDiagnostic: DM6PR03MB4843:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <DM6PR03MB4843E37F1AD77E20B865B3198FBE9@DM6PR03MB4843.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: CIf+SBQ2rH308t5KiDDiEeiacyoYJaxz7X6uS1tcY9oPvRkNkghWQXXerRp9uMfe3Rm05P2hfDS3f0erQtpOUAewvojzDxGTg8FxSEjFol375x/v7/AUO2ONDZbGpgY/4l3op0IiA05pZqSmBQs2tVTfORD8wNaeamPzWffI3KOr/3fnoGdBRS0Qi/6Qzae4DDtKa+/pWjlwO9QWvBZG+nShc76e+ahNdq6TpQ+uu7VrhOoPiyAUlp0UouFCT1elYTidyyyNF3N/zR1M0JhIcaESuE18gcBAV5j3heYtNv+gNYvYZgmCSRM+ZTDOuC4ozuJSoC9HjXSrZeYY0jTjjOYiQTqyWQ1i27rWiTA+UHzQRFvPNwU92y8PvEzsSNIxr56XXj0Q5rXs1WHmU06SBH2k4ARnJq63wOuip5xl5VIv2C8HuL4prxVV4vMSIxvNQSt5owTPugtAbLnNBwRi2tKXLE5u/314wYNvQXAA5Geb7qnm7jiNGO+AMF7vg7P264rTL10uCcLnXtvCYk06HRrvyPWjxkPXiW7u5gUjtZvQMs6kMDisiuYoVqjygBv+7cbmSxX9UOGi+xkzUvJs2/LR5uDHBUGBXhHVCa3bVPb+nek6RD+jtAWoaEM3ttjwAqTvyTKWeDSesOPKwF5qBg==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(38100700002)(66476007)(85182001)(8676002)(66556008)(66946007)(86362001)(6666004)(508600001)(316002)(5660300002)(956004)(53546011)(2906002)(8936002)(6496006)(9686003)(6916009)(26005)(83380400001)(6486002)(4326008)(82960400001)(186003)(54906003);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VzZXeHY4V1dKMEo0S3FtWEpvS1h3SjlpMHdrQnZPeVQ4MzVhYnFwZkNoLzd2?=
 =?utf-8?B?MjVvTHBIT0lIS0FpWTl5T0ZweUsxWW02UnlRN2N2VEdHVFhQK3krbytKaE16?=
 =?utf-8?B?SHFQaE5ka1dJc1F3VzBPblVmMzBjMHpoY1VSMjc2WjJnZDhNaHl6bEg3VGxE?=
 =?utf-8?B?dG1OSG9scTBkdTN4d25OUHdUaG9CSnU2dGdlenJvMy9kczhUcGQ1MG1KRjJr?=
 =?utf-8?B?b2FGQ3dGVkpRMEJUeXY1TGRhVEk0RzQ2R2t4Z0ErOHdzbHJZbk5yanllYjVJ?=
 =?utf-8?B?WEFzcUk2TVIrSDY5Y0gxbzhmT0Ria3N3Y2N5UTArdVJmak9MUXZmMExJcmd0?=
 =?utf-8?B?NnM1Rkh4OUVWTWVKekQ3WDczSHc2VlZGQVJyVXVPaHo4cHZoQnVnb21Lc2Ex?=
 =?utf-8?B?L1JlMjZXRmc5ZlJWcWVTTkNXRDBIclVCRnF1bGFlN0UzZG5IYmxXUjZvc1JM?=
 =?utf-8?B?U0VDaFUxQnA0SmFvWjZrbHJlVDYwTlMyL2x1d2F0UTJYQ2JZaHZQdUI0dFBS?=
 =?utf-8?B?aHkrY1IrcEFrd1ZZM25uYzE2Y0xXZytycDBKYzkrZ2VmTHBSN1dVRlZFemQ0?=
 =?utf-8?B?bTZ6ajE0VEFsN292ZWs0Z1JqN3ZhNmw5akwvOHp3L2l1c1VSU2wrbkFKVTNB?=
 =?utf-8?B?bW0zcnRMQzlRTERkblVQRmsrZndlZFlqd0hTZVNNZnAzVkJyZGJyRm9IN3JW?=
 =?utf-8?B?K0V0UE5uM2wxVUhDcWN4OUpkSmhiU2NQeFNGUDBJTHhvZFpIbzNJbXhMOGhu?=
 =?utf-8?B?N3FTVDMzNms1S1RnTElvRzlFT3FOOS9nVlpCRjhIWkp0MW16cy9XaStUc3pR?=
 =?utf-8?B?bHUxbitFZFBjS0hqTDFSVUtCT2plemZKazFISjEzRytDbTVsN3FJdE40S3Zy?=
 =?utf-8?B?WTRYZ3ZPdGpGcUh5OFR4eDNDNlpTSXp2RFpMU1hOZnY3Wm9QRVpvREkwcVVD?=
 =?utf-8?B?WXVqd1ZZQUFIUHZUa1RGT3pFY3NSd0h3R21yTG1aR0tiVzkzUUtxcGZnVHJT?=
 =?utf-8?B?SjV3RWJ4NWJmSHlpRmROS3YvR2liemVmZElkdGhZdzhkVFZvOGdTZWhqK2hK?=
 =?utf-8?B?L3pYSWtQN0hxY09xa2dFRnB4emdpYlZsLy91akZwRG5ERWQwZjAwTGJwcEVz?=
 =?utf-8?B?RTFNZWFTdG5sTnIwM1NqY0x2VkZTOTdCaGRwdjU2b0lDVFBiMGE3aXJuTjZ3?=
 =?utf-8?B?dndkeW5ibmcycE5uWEpIUkFPaTlmYi9BSkQ5ZFhQNDkyYmpUbHZxTDMyT1Rn?=
 =?utf-8?B?clJRMmppRnk2TWpNUUE2aEt4UDNMczB1Z2c1Q3JDMkNZeFJqYjRhUmdva083?=
 =?utf-8?B?R0hGeFZzZitqS0xoMGxLVkV0SXVtWnpTSXRYYTAzdFh5a2xzaHhGS1RnNVFh?=
 =?utf-8?B?TXhSampPL25IbEFWd29ubnhZL2phTTZ3N3pNZzBkQW9oMUNzak5lQVNuY0xH?=
 =?utf-8?B?bzEvelhpMEJDbGhjMXhORjcxc2VBN1RJNWUxbmJSNmlxQU9zdmVNZVdnNHhB?=
 =?utf-8?B?WEdNQURCMFhDY0c2NmJ0aXFaeERPaXFNa2NsRlJXSEdXc3pWK0xxdFBZcWgy?=
 =?utf-8?B?TXhEenVhZWtGc1N5OGE5YW8xOTFzTXF0ZzI4c2JObnUxSnVHdE1jUGN6Mlh3?=
 =?utf-8?B?R3kwN0FsSVEyS0N3V0F4c21BR1QwbldBZ1YvVmVzcUxrTURUaWQ0bXRNWWp6?=
 =?utf-8?B?YVZtN3daK2VOZHdzWm1PM0JjQW80MENYN0RSaGM5NUlyT0M1dnpyeUFYR0dm?=
 =?utf-8?Q?1YzFMg2WX2JTXfu6xU2saiHgzcTu8vIeXdo46ew?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 7228e657-e92e-4a3a-3e4f-08d993a03ee9
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2021 08:04:31.0891
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: roger.pau@citrix.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4843
X-OriginatorOrg: citrix.com

On Fri, Oct 15, 2021 at 11:48:33AM +0200, Jan Beulich wrote:
> On 15.10.2021 11:39, Jan Beulich wrote:
> > On 22.09.2021 10:21, Roger Pau Monne wrote:
> >> --- a/xen/include/public/domctl.h
> >> +++ b/xen/include/public/domctl.h
> >> @@ -87,14 +87,22 @@ struct xen_domctl_createdomain {
> >>      /*
> >>       * Various domain limits, which impact the quantity of resources
> >>       * (global mapping space, xenheap, etc) a guest may consume.  For
> >> -     * max_grant_frames and max_maptrack_frames, < 0 means "use the
> >> -     * default maximum value in the hypervisor".
> >> +     * max_grant_frames, max_maptrack_frames and max_gnttab_version < 0
> >> +     * means "use the default maximum value in the hypervisor".
> >>       */
> >>      uint32_t max_vcpus;
> >>      uint32_t max_evtchn_port;
> >>      int32_t max_grant_frames;
> >>      int32_t max_maptrack_frames;
> >>  
> >> +/* Grant version, use low 4 bits. */
> >> +#define XEN_DOMCTL_GRANT_version_mask    0xf
> >> +#define XEN_DOMCTL_GRANT_version_default 0xf
> >> +
> >> +#define XEN_DOMCTLGRANT_MAX XEN_DOMCTL_GRANT_version_mask
> >> +
> >> +    uint32_t grant_opts;
> > 
> > As it now seems unlikely that this will make 4.16, please don't forget
> > to bump the interface version for 4.17. With that and preferably with
> > the nit above addressed, hypervisor parts:
> > Reviewed-by: Jan Beulich <jbeulich@suse.com>
> 
> Actually no, I'm afraid there is an issue with migration: If the tool
> stack remembers the "use default" setting and hands this to the new
> host, that host's default may be different from the source host's. It
> is the effective max-version that needs passing on in this case, which
> in turn requires a means to obtain the value.

Hm, my thinking was that the admin (or a higer level orchestration
tool) would already have performed the necessary adjustments to assert
the environments are compatible.

This problem already exist today where you can migrate a VM from a
host having the max default grant version to one having
gnttab=max-ver:1 without complains.

Note that adding such a check would then effectively prevent us from
lowering the default max grant version, as any incoming migration from
a previous hypervisor using the default parameters would be rejected.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Wed Oct 20 08:09:21 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Oct 2021 08:09:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.213662.371945 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1md6f2-0007K8-S7; Wed, 20 Oct 2021 08:09:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 213662.371945; Wed, 20 Oct 2021 08:09:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1md6f2-0007K1-Oz; Wed, 20 Oct 2021 08:09:20 +0000
Received: by outflank-mailman (input) for mailman id 213662;
 Wed, 20 Oct 2021 08:09:19 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ou1c=PI=citrix.com=roger.pau@srs-us1.protection.inumbo.net>)
 id 1md6f1-0007Jv-Ou
 for xen-devel@lists.xenproject.org; Wed, 20 Oct 2021 08:09:19 +0000
Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id e01e095d-3766-45b9-99cf-de3af101dcb9;
 Wed, 20 Oct 2021 08:09:17 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e01e095d-3766-45b9-99cf-de3af101dcb9
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1634717357;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=XPRBa4Xq/3Gk/xNVRMfKa4ZGJR8mMxorgEhLvJ/QwRc=;
  b=UJFXAScXYOeF2EUR8aMBhvKCQJlR+gXxd6TWXQnYLc0W6IYW21eOkoUs
   iQd1wrHTZYu2dWlyiFO9NlO5JfQl6g1MwXaTW6H6MJDP44luSJ7ojPLVj
   AtdP30Js3gBe/wAxxNDUFpFw6iiSDwbTEC/bwnNfrByoj+NJcYEPzrk2/
   k=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: 42WFowZyT0ZW7REpZp4ggEO6cV7Fzu9GGTJGDfwLPM6tZz7vQmSIDPDmh5SFznL4zCGZnq8V2J
 0Yo0i25D/wgqDzEmZVgxyLLYuqNQEuUKrfCSywjfIbtVPgcZQsS6SegQLdwkDrzhAlTPLQ9QZQ
 N7gMhe/q/+jvOVNEwlB3lWJYnKRznb4abDvLNEJZHA3TPAvOJQ3dQ+rQvJzeRAi3CivUN8Gn03
 auVww7j+1I0YOkJy9p/7vegX66iEK9r/q3LE5vTQTu4n9B6zg0kMrv4gj9k/ppZoQkSNxHUQjd
 hAnOp02+jh2XrE88HkLdmC4e
X-SBRS: 5.1
X-MesageID: 55170763
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:F2zjuKKyzKKu2+CBFE+R1JMlxSXFcZb7ZxGr2PjKsXjdYENS0mRUz
 GEXC2qDa/mMMGT2KYgnaN619k5XuJTdx4JqTwplqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s
 q3yv/GZdJhcokcxIn5BC5C5xZVG/fjgqoHUVaiUZUideSc+EH140Eo5w7Zg6mJVqYPR7z2l6
 IuaT/L3YDdJ6xYsWo7Dw/vewP/HlK2aVAIw5jTSV9gS1LPtvyB94KYkDbOwNxPFrrx8RYZWc
 QphIIaRpQs19z91Yj+sfy2SnkciGtY+NiDW4pZatjTLbrGvaUXe345iXMfwZ3u7hB2XnNBcy
 YkUpaefRFc2P6L+wbwyc1phRnQW0a1uoNcrIFC6uM2XiUbHb2Ht07NlC0Re0Y8wo7gtRzsUr
 LpBdW5LPkvra+GemdpXTsF2gcsuNo/zNZ43sXB81zDJS/0hRPgvRo2XuIYHhGhu3aiiG96BY
 ZobbAR9US3hahd1EXInL5MApMCR0yyXnzpw9wvO+PtfD3Lo5DJ21L/hId/EYOugTM9enlubj
 m/e9mG/CRYfXPSd1D6E/3SEluLJ2yThV+o6Fre16/pri1273XEIBVsdUl7TieGwl0qWS99Zb
 UsO9UIGsqwa5EGtCN7nUHWQsHOC+xIRRddUO+k78x2WjLrZ5R6DAWoJRSIHb8Yp3OccSCY2z
 FaPk5XMDCZ2rbyOYXuH8/GfqjbaESkKL0cSaCkcVwwH7tL/5oYpgXrnVc1/GaS4itn0HzDYw
 D2QqiU6wbIJgqYj8KG2/kvOhT62kbHPQhQo/QXcXm+j7QRRaZasYsqj7l2z0BpbBN/HFB/b5
 iFCwpXAqrBVZX2QqMCTaPsOHJyou6+VCxLR0UFuEKt4rxuNuEf2KOi8/wpCDEtuN88Ffxrgb
 0nSpR5d6fdvAZe6UUNkS9nuU5pynMAMAfygD6qONoMfPfCdYSfepHk2DXN8yVwBh6TFfUsXA
 pycbdq3RUgTDaBq3VJarM9MjOd1mEjSKY7VLK0XLihLM5LCOxZ5qp9faTNii9zVCove/G05F
 P4Eb6O3J+13CrGWX8Uu2dd7wao2BXY6H4vqjMdca/SOJAFrcEl4VaSNn+1wI9Y5x/0M/gstw
 p1bchUEoLYYrSafQThml1g5MO+/NXqBhSNT0dMQ0aaAhCF4PNfHAFY3fJorZ7g3nNGPPtYvJ
 8Tpj/6oW6wVIhyeomx1RcCk8ORKKUT67SrTbnHNSGVuIPZdq/nhp4aMkv3Hr3JVUEJadKIW/
 tWd6+8sacBdF188UpuONKjHIpHYlSF1pd+elnDge7F7UE7t7JJrO2r2iPo2KNsLMhLN2n2R0
 AP+PPvSjbKlT1Yd/IabiKaagZ2uFuciTENWE3OCteS9NDXA/3rlyohFCb7acTfYXWLy2aOje
 eQKkK2sbKxZxA5H49hmDrJm7aMi/N+z9bVU+RtpQSfQZFOxB7I+fnTfhZtTtrdAz6NysBetX
 h7d4cFTPLiEYZu3EFMYKAc/QP6E0PUYxmvb4fgveR2o7y5r5ruXF05VOkDU2iBaKbJ0NqIjw
 Psg55FKu1Du1EJyP4/f3C5O9mmKIngRaIkdt8kXUN3xlw4m6lBeepiAWCX4146CNodXOU4wL
 z7K2Keb3+ZAxlDPemYYHGTW2bYPnowHvR1HwQNQJ1mNndaZ1PY70AcIrGYyRwVRiB5Gz/hyK
 i5gMEgsffeC+DJhhc5iWWGwGl4eWE3FqxKpk1ZZxnfES0SIV3DWKDxvMOmAy0kV7mZAc2UJ5
 7qf0mvkDW7nccyZMvHegqK5RygPleBMyzA=
IronPort-HdrOrdr: A9a23:iDtA66GCa5iJcydLpLqFe5HXdLJyesId70hD6qkvc3Jom52j+P
 xGws526faVslYssHFJo6HnBEClewKgyXcT2/hsAV7CZnidhILMFuBfBOTZsljd8kHFh4pgPO
 JbAtdD4b7LfChHZKTBkXGF+r8bqbHtms3Y5pa9vgRQpENRGtpdBm9Ce3em+yZNNXB77PQCZf
 2hDp0tnUvfRZ1bVLX2OlA1G8z44/HbnpPvZhALQzYh9Qm1lDutrJr3CQKR0BsyWy5Ghe5Kyx
 mKryXJooGY992rwB7V0GHeq7xQhdva09NGQOiBkNIcJDnAghuhIK5hR7qBljYop/zH0idkrP
 D85zMbe+hj4XLYeW+45TPrxgnbyT4rr0TvzFeJ6EGT6vDRdXYfMY5slIhZehzW5w4Lp9dnyp
 9G2Gqfqt5+EQ7AtD6V3amKazha0m6P5VYym+8aiHJSFaEEbqVKkIAZ9ERJVL8dASPB7pw9Gu
 UGNrCd2B9vSyLeU5nlhBgq/DT1NU5DWStuA3Jy+/B96gIm3kyQlCAjtYoidnRpzuN0d3AL3Z
 WcDkzE/Is+OfP+VpgNcdvpd/HHQ1AlcSi8Ql56Hm6XYJ3vG0i94aIfs49Fqd1DRvQzve0Pcd
 L6IQtliVI=
X-IronPort-AV: E=Sophos;i="5.87,166,1631592000"; 
   d="scan'208";a="55170763"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=VzNLjj48hRNf7hhSyN7JUh6cuL3L9YelDo84r4X1zXAxb7T/M3rKPNkrkz+mtHhs2ekEq7iRw85E8E8WZuxd5pkPFgpQXUMd9I6e+Hf+3nCkLIILHnCdXIkj8Nk/RmsBYDXL6SvOzyr7ttr34kWSipteYEYgSLPCUPP1Mw7ut58ignrjxBUbfTebA4EInJORGkLF78xn+eTZhjQ+op+4vorSYD3bbB8luMLDmDeTBieA/2qa5PW+EH8dLCl8JfhGmyi4dUl2IJs4y/rS/LGg2jzkAjkY8fsTAJm6eVTv6w736hN6xk1xc0F7roA3yEzjK6WTFA+gMr1hM06Fr8fyzA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=WUeLAbaOP4QSjoUbJ+Xvmssa/tlRf+CiEwTL8sgh5TM=;
 b=M3vb7QWdiT1CJmAeCn602xqCgOJLs/Y9JUF1TcZx1dv/h0nAqHUumyz1m6+MdsR9Apyv0OJTv0a7EeIegzbXlTMSKTGJQTor/vdhDIDg6Js95FZoOkc7/1kkbY8WFiJ2pONe7xt4e0XQqVhKFSrYACLhhB8Qvln8N2CsTSzKqAlp0WlUu0IpKrVsVg4gABvuD5lU2E8JLZF9hUMQG2ibMQ9CvqfFRsK/I3cHvpCu711aJyXuzRiyYz/nYppDGW9njXhtZ4xKi7yd4YyagVvhDtnBZh7kDewcOKtdJ/Ev8HWr5QfnKg5SUyKgqmiF2ueGwH1Km8Oi5jUleeK7Au59GA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=WUeLAbaOP4QSjoUbJ+Xvmssa/tlRf+CiEwTL8sgh5TM=;
 b=VkiLsNUzZv6N7nzrc+T9IL6NZvVDAePMtp6lCy6mHNzHc/8MI45dW37+k+/ScYzXowqAD6N8Q4WbNRAIrkfEgQAXQkZEShvYw5fhAKz1si1NBKwzjkuBeD79krM4ksnNu3kLIuGPeXDvaZWSGgp9rzuEl47Tsq2xjTt0va2z3Jg=
Date: Wed, 20 Oct 2021 10:08:51 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Bertrand Marquis <Bertrand.Marquis@arm.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>, "iwj@xenproject.org"
	<iwj@xenproject.org>, "Oleksandr_Andrushchenko@epam.com"
	<Oleksandr_Andrushchenko@epam.com>, Stefano Stabellini
	<sstabellini@kernel.org>, Julien Grall <julien@xen.org>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Jan Beulich <jbeulich@suse.com>, Andrew Cooper
	<andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>, Paul Durrant
	<paul@xen.org>
Subject: Re: [PATCH v2 1/1] xen/pci: Install vpci handlers on x86 and fix
 exit path
Message-ID: <YW/Ok38nyeUlneky@MacBook-Air-de-Roger.local>
References: <cover.1634659471.git.bertrand.marquis@arm.com>
 <d788dcce9e344a39f6761633f0e96774ab42c2aa.1634659471.git.bertrand.marquis@arm.com>
 <YW/KDHnZHz72mjuQ@MacBook-Air-de-Roger.local>
 <85549220-AF96-4913-B672-ED6795C91C3D@arm.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <85549220-AF96-4913-B672-ED6795C91C3D@arm.com>
X-ClientProxiedBy: LO4P123CA0416.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:18b::7) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 5ee1565e-4f1d-4121-2767-08d993a0dd1d
X-MS-TrafficTypeDiagnostic: DM6PR03MB4843:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <DM6PR03MB4843776382412F2EBE49E9878FBE9@DM6PR03MB4843.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: VWSJQgDetG2DmNI6aqqm9l5uxfEfSdcr5AaE6WdvC0m3YQOHnExrt4ZkLJy8tuf+SQezecBf6XFd4GptyNBKpaychsUCD6/MbdKasKYwTWc2I+pEfysTcT2IvVdWbf6qMKhi+wSeQxAONQf0gGOmXPAkP/HkHaTf1MgZECOlhXEtpc4yh4gV7JBLSwvsWhsYxyXZXvWfojHc0Wul6PNDiF8eefrK1WiZvKY4dNb0G3e36JiPm8XCan6WfOTfm+3fYnPB+WdAdFIFRmoDppG//w7X2lowTRfu8aH5eIg7fMKydMR/qzaMlJua9Zi2noWktgCUuIF10WxJXmIq4O8jcW2xN9ih6QLwnSK0DpjQZGqyQXVI4xGtCSVsrWCqAh7mDI2WQH36mSS5NWHl5KB3cs9MAxh9e8ybuS/Hq89ug6DkVayV0bsYJr0r7W/kXjJA/1rFZhUVheKYyA1G62H+W6kN0dj4/rF9iojvj3j5p7L+5XRDBfnBjPtG/zwtwcTl0n5+jc/gGGlwgFGHVBUK+oSiSAagGPqsDv7yp54rb/vpWdssh/zKlyP8k/bZn6f58Oym9+DRX8uh9VVEjn43XCzWJOHZd7ihvWHdb1+pB5iN3M7nSTnb25poetWABdf6AQbbsYpAIf9bqLqJ30BUug==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(6916009)(9686003)(186003)(82960400001)(54906003)(26005)(83380400001)(6486002)(4326008)(6666004)(508600001)(956004)(53546011)(316002)(5660300002)(66556008)(8676002)(38100700002)(66476007)(85182001)(86362001)(66946007)(8936002)(7416002)(6496006)(2906002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UGp4Y1VIWk5DVFZ0cmdkaTJWQWV6RWdYMXh2TUxiUzlmUjZBL3NFeFBwYllu?=
 =?utf-8?B?MFdwVDlxZWlGYUtQVy90MUV2bXpMRS81MUp6c05jRUhJNjBPV2l4MStZem82?=
 =?utf-8?B?K1hFWXBKcy9ZVEs1cnhxZ1Rqd3pzTjB6OCtOUjdwY1cyRnBkdzNmenA1YXll?=
 =?utf-8?B?cUJvanN0OFhya3hTdEk4blBFNHNhYXpUQVowcGhYd1NDUWZ4Q0phWjRER3ZB?=
 =?utf-8?B?UlZQR1RVT2FRdWQvQnF2RmpjZG1oTjh1cXV3QnM3NTdhbzN6SFl6Z0JCVFVy?=
 =?utf-8?B?amw0TjlKaWx0cUM3MVE5NU1QNVEvVEw5cFBwR1ZHYUR3RjVMbGl4dUtSZnZw?=
 =?utf-8?B?eHc0MDhQVXJsdk1sZjZSUXZraHpXTElHVHNESWVQY1F0NkJTTEdCVFQreWhr?=
 =?utf-8?B?R0FkdFN1MnZWOU5DYklBU1NYRGFaaFVWVzAzcUtBVzZ4SzZPOU93TzVrTDdr?=
 =?utf-8?B?R25PS3p3MjZiSnN6V1JxQjYrU3M0NWtyalVPbkpid1o5WXJYQ2RWTmFxY2tX?=
 =?utf-8?B?YWlFL0orL1pUQktIR0ZGN2RZK1ZrUWNmRU1uQXhwWHk0RUlPaWRUbHRDVG5s?=
 =?utf-8?B?L0d4dnA5a3E4WTJFc2hlVGtNTFhoeEVTT2RWd1FMVTN6Zlg0K2xFamRpd3Z1?=
 =?utf-8?B?YzZJSDhxOGRsd0lXWjBrMkpjVEpEUm0yOWFwT2Uwa2NISVhyRGZ3VHJyUFlt?=
 =?utf-8?B?dmxDUVREVU9XS3dyejh1RGUyTTdQbXhzOW95S0NPUzV2dUxLSFJSaE13dEtt?=
 =?utf-8?B?RVQ4WFk1UUVVN21Qc1NteHpENVhKVkVHS2xGMS9sc1lhUDRla0dib3lac3BY?=
 =?utf-8?B?THFDTy9wTXFSbG1PU0JuY3EwQzkycUxPR0p4Y0d1UHpHVEZCMXhmVERISDRr?=
 =?utf-8?B?Z1R4ZmZLUGZUMVRocW9tTFcrc3l0UCtRUmtmVytmS2x4SUJCekhKYksyODg3?=
 =?utf-8?B?RmhFNGVTVkhGM3JpL0Z3aTVoaGFGc2loMWJYNVhuV3BMYXNmeFVuNEhLOGFa?=
 =?utf-8?B?QTZWR3VFemd6UTJrVDd6cDRMdGQwbEdJV1pVVFpFYzA1eVgyelRxOUZDOTAx?=
 =?utf-8?B?b1VlR2lraHNLZ1EwV0c2QXo3bmhtL3pyc2RUa3ovMlJFRGZLSzFjZjJZamd6?=
 =?utf-8?B?dUljQXZQWk9xTkx6VWcwSXd6L2lDYVFUYUE5WFNzVXl2eXB2VEJMdUo0RUoy?=
 =?utf-8?B?RlZKdE9neDllaUl6WTJ4SXI2RnB3VFM5eldLUldVVUxraXVrOG5lMk1QTXBV?=
 =?utf-8?B?VXBraEdrbGljdm14eXRUL0Q5bkJEQTRmd280ZTYrK3ZES3FHbHhtZzdUQVNQ?=
 =?utf-8?B?ZzZKeFozWmI4ZXRLNDU3bzh2RWNMbS9wYTRaa2Z2MmZOWUFSMjhuakcybXRm?=
 =?utf-8?B?Qm9UckppVkRGTklVbGIvaVB6Z3BsTTdhcnhBRXRPYmFNMHBCOU5DRUZGS05k?=
 =?utf-8?B?bVoxN2ZybVd2YVJBUGk5c0xYakpJSGRUazZwNkhEME9BV0J6S3kycXEyd3hM?=
 =?utf-8?B?ZGYwY0JPOUo3RVh4aFlPSHQrL1luR1ZjWkxwZ1llckJMZUNob0hLb3htNUl1?=
 =?utf-8?B?cmRhbXM4anlxMjFPbmkxdzk3Q1BYQ3Bia3NsUmRZZ3dpb0VKQXdFU3BCWi9S?=
 =?utf-8?B?a3RqSEJVd1YxNExDQUpGMmFiWTZtN3Y2Yy9vclR2QlpOYnJFcUdreEoxWTh0?=
 =?utf-8?B?RTZSeGlVdlpMSUR5Y282TEpyd3hLditCbmlYMzRhclFSUzFYKytzVGplb0hx?=
 =?utf-8?Q?+phl+HWzEu9/OYDUq+JAKr5kPNxUcWwfqQ5kT9Y?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 5ee1565e-4f1d-4121-2767-08d993a0dd1d
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2021 08:08:56.5412
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: roger.pau@citrix.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4843
X-OriginatorOrg: citrix.com

On Wed, Oct 20, 2021 at 07:57:15AM +0000, Bertrand Marquis wrote:
> Hi Roger,
> 
> > On 20 Oct 2021, at 08:49, Roger Pau Monné <roger.pau@citrix.com> wrote:
> > 
> > On Tue, Oct 19, 2021 at 05:08:28PM +0100, Bertrand Marquis wrote:
> >> Xen might not be able to discover at boot time all devices or some devices
> >> might appear after specific actions from dom0.
> >> In this case dom0 can use the PHYSDEVOP_pci_device_add to signal some
> >> PCI devices to Xen.
> >> As those devices where not known from Xen before, the vpci handlers must
> >> be properly installed during pci_device_add for x86 PVH Dom0, in the
> >> same way as what is done currently on arm (where Xen does not detect PCI
> >> devices but relies on Dom0 to declare them all the time).
> >> 
> >> So this patch is removing the ifdef protecting the call to
> >> vpci_add_handlers and the comment which was arm specific.
> >> 
> >> vpci_add_handlers is called on during pci_device_add which can be called
> >> at runtime through hypercall physdev_op.
> >> Remove __hwdom_init as the call is not limited anymore to hardware
> >> domain init and fix linker script to only keep vpci_array in rodata
> >> section.
> >> 
> >> Add missing vpci handlers cleanup during pci_device_remove and in case
> >> of error with iommu during pci_device_add.
> >> 
> >> Add empty static inline for vpci_remove_device when CONFIG_VPCI is not
> >> defined.
> >> 
> >> Fixes: d59168dc05 ("xen/arm: Enable the existing x86 virtual PCI support
> >> for ARM")
> >> Suggested-by: Jan Beulich <jbeulich@suse.com>
> >> Signed-off-by: Bertrand Marquis <bertrand.marquis@arm.com>
> >> ---
> >> Changes in v2
> >> - add comment suggested by Jan on top of vpci_add_handlers call
> >> - merge the 3 patches of the serie in one patch and renamed it
> >> - fix x86 and arm linker script to only keep vpci_array in rodata and
> >> only when CONFIG_VPCI is set.
> >> ---
> >> xen/arch/arm/xen.lds.S        | 9 +--------
> >> xen/arch/x86/xen.lds.S        | 9 +--------
> >> xen/drivers/passthrough/pci.c | 8 ++++----
> >> xen/drivers/vpci/vpci.c       | 2 +-
> >> xen/include/xen/vpci.h        | 2 ++
> >> 5 files changed, 9 insertions(+), 21 deletions(-)
> >> 
> >> diff --git a/xen/arch/arm/xen.lds.S b/xen/arch/arm/xen.lds.S
> >> index b773f91f1c..08016948ab 100644
> >> --- a/xen/arch/arm/xen.lds.S
> >> +++ b/xen/arch/arm/xen.lds.S
> >> @@ -60,7 +60,7 @@ SECTIONS
> >>        *(.proc.info)
> >>        __proc_info_end = .;
> >> 
> >> -#if defined(CONFIG_HAS_VPCI) && defined(CONFIG_LATE_HWDOM)
> >> +#ifdef CONFIG_HAS_VPCI
> >>        . = ALIGN(POINTER_ALIGN);
> >>        __start_vpci_array = .;
> >>        *(SORT(.data.vpci.*))
> >> @@ -189,13 +189,6 @@ SECTIONS
> >>        *(.init_array)
> >>        *(SORT(.init_array.*))
> >>        __ctors_end = .;
> >> -
> >> -#if defined(CONFIG_HAS_VPCI) && !defined(CONFIG_LATE_HWDOM)
> >> -       . = ALIGN(POINTER_ALIGN);
> >> -       __start_vpci_array = .;
> >> -       *(SORT(.data.vpci.*))
> >> -       __end_vpci_array = .;
> >> -#endif
> >>   } :text
> >>   __init_end_efi = .;
> >>   . = ALIGN(STACK_SIZE);
> >> diff --git a/xen/arch/x86/xen.lds.S b/xen/arch/x86/xen.lds.S
> >> index 11b1da2154..87e344d4dd 100644
> >> --- a/xen/arch/x86/xen.lds.S
> >> +++ b/xen/arch/x86/xen.lds.S
> >> @@ -134,7 +134,7 @@ SECTIONS
> >>        *(.ex_table.pre)
> >>        __stop___pre_ex_table = .;
> >> 
> >> -#if defined(CONFIG_HAS_VPCI) && defined(CONFIG_LATE_HWDOM)
> >> +#ifdef CONFIG_HAS_VPCI
> >>        . = ALIGN(POINTER_ALIGN);
> >>        __start_vpci_array = .;
> >>        *(SORT(.data.vpci.*))
> >> @@ -247,13 +247,6 @@ SECTIONS
> >>        *(.init_array)
> >>        *(SORT(.init_array.*))
> >>        __ctors_end = .;
> >> -
> >> -#if defined(CONFIG_HAS_VPCI) && !defined(CONFIG_LATE_HWDOM)
> >> -       . = ALIGN(POINTER_ALIGN);
> >> -       __start_vpci_array = .;
> >> -       *(SORT(.data.vpci.*))
> >> -       __end_vpci_array = .;
> >> -#endif
> >>   } PHDR(text)
> >> 
> >>   . = ALIGN(SECTION_ALIGN);
> >> diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci.c
> >> index 35e0190796..8928a1c07d 100644
> >> --- a/xen/drivers/passthrough/pci.c
> >> +++ b/xen/drivers/passthrough/pci.c
> >> @@ -756,10 +756,9 @@ int pci_add_device(u16 seg, u8 bus, u8 devfn,
> >>     if ( !pdev->domain )
> >>     {
> >>         pdev->domain = hardware_domain;
> >> -#ifdef CONFIG_ARM
> >>         /*
> >> -         * On ARM PCI devices discovery will be done by Dom0. Add vpci handler
> >> -         * when Dom0 inform XEN to add the PCI devices in XEN.
> >> +         * For devices not discovered by Xen during boot, add vPCI handlers
> >> +         * when Dom0 first informs Xen about such devices.
> >>          */
> >>         ret = vpci_add_handlers(pdev);
> >>         if ( ret )
> >> @@ -768,10 +767,10 @@ int pci_add_device(u16 seg, u8 bus, u8 devfn,
> >>             pdev->domain = NULL;
> >>             goto out;
> >>         }
> >> -#endif
> >>         ret = iommu_add_device(pdev);
> >>         if ( ret )
> >>         {
> >> +            vpci_remove_device(pdev);
> >>             pdev->domain = NULL;
> >>             goto out;
> >>         }
> >> @@ -819,6 +818,7 @@ int pci_remove_device(u16 seg, u8 bus, u8 devfn)
> >>     list_for_each_entry ( pdev, &pseg->alldevs_list, alldevs_list )
> >>         if ( pdev->bus == bus && pdev->devfn == devfn )
> >>         {
> >> +            vpci_remove_device(pdev);
> > 
> > vpci_remove_device is missing a check for has_vpci(pdev->domain), as
> > it will unconditionally access pdev->vpci otherwise, and that would be
> > wrong for domains not using vpci.
> > 
> > It might also be good to add an ASSERT(!pdev->vpci) to
> > vpci_add_handlers in order to make sure there are no duplicated calls
> > to vpci_add_handlers, but that can be done in a separate patch.
> 
> I can do both in v3 (together with the change of in the patch name).
> 
> Unless you want the ASSERT in a different patch, in this case I do not think
> I can make a new patch for that.
> 
> Can you confirm if I should or not add the ASSERT directly in the patch ?

I'm fine with having the assert added here: in wasn't necessary
previously as there was a single caller of vpci_add_handlers. Now that
there are multiple ones we should make sure no duplicated calls can
happen.

On a different note (and not something that should be solved here,
just wanted to raise attention to it) there's an existing TODO about
vpci_remove_device because it doesn't clean the 2nd stage mappings for
BARs. At some point we need to solve this, or else the removal of the
device is not complete.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Wed Oct 20 08:17:21 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Oct 2021 08:17:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.213669.371957 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1md6mi-0000JZ-NT; Wed, 20 Oct 2021 08:17:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 213669.371957; Wed, 20 Oct 2021 08:17:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1md6mi-0000JS-JN; Wed, 20 Oct 2021 08:17:16 +0000
Received: by outflank-mailman (input) for mailman id 213669;
 Wed, 20 Oct 2021 08:17:15 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=TQMG=PI=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1md6mh-0000JI-4p
 for xen-devel@lists.xenproject.org; Wed, 20 Oct 2021 08:17:15 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 20a0a0ce-317e-11ec-8335-12813bfff9fa;
 Wed, 20 Oct 2021 08:17:13 +0000 (UTC)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2110.outbound.protection.outlook.com [104.47.18.110])
 (Using TLS) by relay.mimecast.com with ESMTP id
 de-mta-35-jQczLQhLOeKnuQ4PHE6ygQ-1; Wed, 20 Oct 2021 10:17:11 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0402MB3934.eurprd04.prod.outlook.com (2603:10a6:803:1b::29)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.17; Wed, 20 Oct
 2021 08:17:10 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.018; Wed, 20 Oct 2021
 08:17:10 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM7PR04CA0006.eurprd04.prod.outlook.com (2603:10a6:20b:110::16) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.16 via Frontend
 Transport; Wed, 20 Oct 2021 08:17:09 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 20a0a0ce-317e-11ec-8335-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634717832;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=1A7AAVEkUu3G5VGSzwzXt4dv0FS7fR3pWsAeKGwFrbw=;
	b=KD1BWso656MAQLJum2PgKBJ0gZ9SASzrYbHFie+lda0RGNrVl+QIuzzOmLMyUXhqdfERst
	a1i7BARcx5x8MSKpm3yDouvN1oeM9QbQJEXGd3pAORbezXZ/W7tu87obBTw4ZEldzZlLTo
	qX5Y2+bqbZ1DVCvj1m/e6kmY+zOoOjg=
X-MC-Unique: jQczLQhLOeKnuQ4PHE6ygQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=XLOHohl66XEz6C38AWdog+3QSlh7/zOqw5c/tAsiB7ZrVZx6mAxcoZ5kQ/6wi+NOC4eu+WSy6upei5xKB7RMDB0MnajiVsKC34tVAiWEw2YrPNpgRLywSTOII6kP2rknGYR7vlQOYHlaCpdFHVA8Oe1EA70qP/GWiljtC2Gbk1Izp2cdPmD0rsqHxjR6ubAKR+wqu8sqIzCumG54KHbtXTlbEL1JINVQd7872e1N+ZILcOOfAUEKuOA5xZo1FOj7ikax4ltEVfnjT7/9z4PboDa0t3ELHQ2r8INJocePRCFW3+xRo5qAAr3dIsQ4GVJYepmLKSZpoyEEGQ7rIxOWYA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=cZuykuWKCYt+OY/Hy7gp+VtXnNos7YGottIWuVTw06w=;
 b=U2La5K/xYy4gc2EZEGh691bnbuMbfsI3dXfbevj4db8tg982JpN4KcGodKJgX4tH9y/JrdvVnqImVFxJkZCJtt65oWbFpmF6ZjOs3aoBcTLrRdhGdhI3ZUdWmisKTa0ibwOquOgSSnVvcz1OyqNpr5p7bl8xkBA6JMph+XOwwPcb3Tvh9zyIDlyQbuWfmJ8YTrfUl+l529C2A3aJnn0uzX5G5ODJkkVKXynSLjtO3QD53QzBOvkTbEPPcXdlK4xzCAVSRVaZnNwonBawu2Bz5P/xp3Gjn1s/rgRKlAFVBy2MX0+jIL+vQd+jv0uq9ZwUhxGJE9qBlXX7dbhB/imAVw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [PATCH v8 1/6] AMD/IOMMU: obtain IVHD type to use earlier
To: Andrew Cooper <andrew.cooper3@citrix.com>
CC: Paul Durrant <paul@xen.org>, Ian Jackson <iwj@xenproject.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <d249a759-188a-d689-316a-4743922827e5@suse.com>
 <d5f76461-70d2-fc59-2213-99a093e3b57f@suse.com>
 <932476cb-9667-efaa-65e9-7dc4baa3dc7c@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <d1dcb878-d78f-0565-4a5d-1ad539a0d531@suse.com>
Date: Wed, 20 Oct 2021 10:17:08 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <932476cb-9667-efaa-65e9-7dc4baa3dc7c@citrix.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM7PR04CA0006.eurprd04.prod.outlook.com
 (2603:10a6:20b:110::16) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: d67fba85-b829-4123-2b0b-08d993a20365
X-MS-TrafficTypeDiagnostic: VI1PR0402MB3934:
X-Microsoft-Antispam-PRVS:
	<VI1PR0402MB3934368958E9964BF6F1733CB3BE9@VI1PR0402MB3934.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	jVHDM6UgK0g5Bx/eW3DbxFyO9yhPea254hGoA80iRpdxgVQYvvKwiJZOU+LWCqLQpRk2o32r6J7PJ1JHVt4LA2y7vjcXJ1SFA1olWO/iA97+FD4hUuSfZtPFSBqe9QtA9w0b8sFVPE3fht36w6YB4vNLDiIFwa1T2mVYfcTAMI1ScUQy9GbcIofxNs+sxq9ruqAQ2B00QOeChaFLzoAeXnZ7X1JdcJp1Bh7bzXVdcBTeBhLWi1oj5KTivY6NKWoCavLcL9/XkOvPejMZ8oi5xId4bKXGXIzF0Lq9v8jziN8nzEuLFZY7ZK3RfN1XbWG00oqcTjqtfM12IVIjLIJnBOM9DE4HZHtHUpbX8tvUX/398j+zgprtQISdrmaoSMZml7wZ8fLMZKSFJX/wn9KDAMbJEiFaOlbLAooBGZWep/J74l9Ksx784fFv8ctQq5ngsWip3wI8GYxTAZFgSXv+/4x8gdxQg7aL+DYgN8tKoM2KlJW7cbJN3R/lX+QdYoc4dufOoUwReF6oL+N4ZuMXb1qMpnExh8Sd3Q2uEfIsDFxmbQAAAdu1jaWUjRPVzFVO4QCGb09U3OZNsCyrJPdXc/4YxzdIYhCzg/gX0cRbikw/sQB4K9kAdbiGzNATSsGT4FOhkmusInWKKOQ5y7lCXfCbvfyx1lO3dmRXjUjxscdMtiGpbmQ0fH3UclVAIGX7DrnWrZvSX4zhdcEV/MYsftorp79w98t6DZUUti40G1c=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(6486002)(66556008)(66476007)(8936002)(316002)(2616005)(26005)(38100700002)(186003)(956004)(16576012)(66946007)(8676002)(2906002)(31696002)(31686004)(6916009)(36756003)(4326008)(5660300002)(508600001)(83380400001)(53546011)(54906003)(86362001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?AaPNM3tycuS01p2jJUmJmcnfG3vUZ+GAqKhV57uXpKGV8U60PfOwD6e1K/jE?=
 =?us-ascii?Q?OEgkaK42WAkNXkz/w/Tm7NTF1xCWhfgRl9uW0Ml6oJvrWInoSh9StHFWOVCr?=
 =?us-ascii?Q?EhPu9duv7gZPJZtpHSkZnAwIA1fsEo5x0tG7o8z2aeRgW8yw2kflmsWgDKkQ?=
 =?us-ascii?Q?Zz1HeAYYqkWh8gCRtGdCKQKSZmI9LJv/1e4SGW5BauuXw1NsDm/6UYoKMiQi?=
 =?us-ascii?Q?jB254mzFK7r4JksJCOEAMJj8kg6GskftwXMpYnJUYsLejUal4zVCNHRkzX6T?=
 =?us-ascii?Q?IEu/oiVYqirFkXT3pUvrYak+5CaDX2iZ1DwZRO0rumRLoHF4g35k0CLlARee?=
 =?us-ascii?Q?E63qdufPYVjjshnmAfy3q8c/I6Tl+fBRi7ucnbVb8Btv1sJlXeaAUxCRff72?=
 =?us-ascii?Q?ux8n4GcW2YMVG6Y6Op8yUmr09rD3Ba2iOCze0I3syPF6pIyHRUNCY+MKmDjE?=
 =?us-ascii?Q?bNPkLIXWTVZEVjL7x8ZUS8/NRaA9g8xl6kj5wob5aBqJTu9XUHCW+dYe8usS?=
 =?us-ascii?Q?UYBYGYzcN4MqBfQe65epmCfJaPbHNiRkXdc6D4/DqNPjL1XWFzW4Qo67IPRK?=
 =?us-ascii?Q?N3RMGua/QqcKpFpZZqX1vIx8OzRfhEWMzsgpzn+u1cmG85idwKkwG1vqV8rK?=
 =?us-ascii?Q?WZAO9CcapfGPcJLjg+lWuy1UpEQ2pK8LsTZSsybLs1u1yyDSnuUm7/WTffec?=
 =?us-ascii?Q?BltvUnXayVBHJYuIEX2VYVtpJUS9kx8O40hpIcl76Nz6b//8rDVPVifwrLdB?=
 =?us-ascii?Q?iGVcGLhruSTJ7HIRQ+AxPHbqNoLhRHRFD8YIjW1PskkEuKzklrVHyb3ZKA3S?=
 =?us-ascii?Q?y5ZNi1F48En59RyBPNS2I2OCkNGUhC6JXpZ1V49OyyLnLuBZ1cxxy7zPAVEW?=
 =?us-ascii?Q?nYqRpe8Dr15GFw0iXYsC5hXp5dFc9gyIpjgMPQNN++iTD988MSZ2v4DwFMIM?=
 =?us-ascii?Q?jVrXjqXEUA4RusICM1LbWrR7br/9yE8IJHNeRE45bZL5uCTOxcpkYPm8CL35?=
 =?us-ascii?Q?B6wDH23gANNfKnzWdxQ3N/JTJxFM1FnvMvz9v8UTHsbcA/uWs5i8fTvW1KWg?=
 =?us-ascii?Q?yC66etWmZ3XmglNYiHmLAprXjEANlcY+kb6PA9mjQ/s+QfV8avDk3zVrOtP1?=
 =?us-ascii?Q?HldQZAhwW1vsiY41BTS1KKkuAszqbd50fXclDxmloPWuvRdh0P3avbRU/tD3?=
 =?us-ascii?Q?i7HkwA6qtDnft/LmgmaRGPm1E13pQC4Qi+Ym9KlDM3RI/m8Thm+lMHfoFFJ1?=
 =?us-ascii?Q?z8wCk3d5rEchaRUjIQkUlTfQoo2WahXHwjQY/7KM0QcvuJC5pYybW2OFabea?=
 =?us-ascii?Q?6I5exezkCVz5HqDDv6/ufbRM?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d67fba85-b829-4123-2b0b-08d993a20365
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2021 08:17:10.1532
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jbeulich@suse.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3934

On 20.10.2021 01:34, Andrew Cooper wrote:
> On 22/09/2021 15:36, Jan Beulich wrote:
>> Doing this in amd_iommu_prepare() is too late for it, in particular, to
>> be used in amd_iommu_detect_one_acpi(), as a subsequent change will want
>> to do. Moving it immediately ahead of amd_iommu_detect_acpi() is
>> (luckily) pretty simple, (pretty importantly) without breaking
>> amd_iommu_prepare()'s logic to prevent multiple processing.
>>
>> This involves moving table checksumming, as
>> amd_iommu_get_supported_ivhd_type() ->  get_supported_ivhd_type() will
>> now be invoked before amd_iommu_detect_acpi()  -> detect_iommu_acpi(). I=
n
>> the course of doing so stop open-coding acpi_tb_checksum(), seeing that
>> we have other uses of this originally ACPI-private function elsewhere in
>> the tree.
>>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>=20
> I'm afraid this breaks booting on Skylake Server.=C2=A0 Yes, really - I
> didn't believe the bisection at first either.

I'll be able to debug this, as by disabling VT-d on my Skylake I can
repro. But ...

> From a bit of debugging, I've found:
>=20
> (XEN) *** acpi_dmar_init() =3D> -19
> (XEN) *** amd_iommu_get_supported_ivhd_type() =3D> -19
>=20
> So VT-d is disabled in firmware.=C2=A0 Oops, but something we should cope=
 with.
>=20
> Then we fall into acpi_ivrs_init(), and take the new-in-this-patch early
> exit with -ENOENT too.
>=20
> It turns out ...
>=20
>> --- a/xen/drivers/passthrough/amd/pci_amd_iommu.c
>> +++ b/xen/drivers/passthrough/amd/pci_amd_iommu.c
>> @@ -179,9 +179,17 @@ static int __must_check amd_iommu_setup_
>> =20
>>  int __init acpi_ivrs_init(void)
>>  {
>> +    int rc;
>> +
>>      if ( !iommu_enable && !iommu_intremap )
>>          return 0;
>> =20
>> +    rc =3D amd_iommu_get_supported_ivhd_type();
>> +    if ( rc < 0 )
>> +        return rc;
>> +    BUG_ON(!rc);
>> +    ivhd_type =3D rc;
>> +
>>      if ( (amd_iommu_detect_acpi() !=3D0) || (iommu_found() =3D=3D 0) )
>>      {
>>          iommu_intremap =3D iommu_intremap_off;
>>
>=20
> ... we're relying on this path (now skipped) to set iommu_intremap away
> from iommu_intremap_full in the "no IOMMU anywhere to be found" case.

... this picture here looks incomplete, since in iommu_hardware_setup()
we have

    if ( !iommu_enabled )
        iommu_intremap =3D iommu_intremap_off;

which I don't see how it could be bypassed. Booting here fails because
of the AHCI driver not being able to obtain control of the disk, but
checking in a working setup I see it use MSI, which can't possibly be
affected by an early-boot-only wrong setting of iommu_intremap. (I can
easily believe that we have early IO-APIC setup logic going wrong when
this remains mistakenly set.)

What I'd like to avoid though is to add yet another custom writing of
iommu_intremap_off in acpi_ivrs_init(). I'd prefer to find a better
place for it, so I will want to do some debugging first. If all else
fails, the setting should at least be moved into the caller of the
function - after all switching around the order of the
acpi_{dmar,ivrs}_init() calls in acpi_iommu_init() shouldn't have any
negative effect.

Jan

> This explains why I occasionally during failure get spew about:
>=20
> (XEN) CPU0: No irq handler for vector 7a (IRQ -2147483648, LAPIC)
> [=C2=A0=C2=A0 17.117518] xhci_hcd 0000:00:14.0: Error while assigning dev=
ice slot ID
> [=C2=A0=C2=A0 17.121114] xhci_hcd 0000:00:14.0: Max number of devices thi=
s xHCI
> host supports is 64.
> [=C2=A0=C2=A0 17.125198] usb usb1-port2: couldn't allocate usb_device
> [=C2=A0 248.317462] INFO: task kworker/u32:0:7 blocked for more than 120 =
seconds.
>=20
> and eventually (gone 400s) get dumped in a dracut shell.
>=20
> Booting with an explicit iommu=3Dno-intremap, which clobbers
> iommu_intremap during cmdline parsing, recovers the system.
>=20
> This variable controls a whole lot of magic with interrupt handling.=C2=
=A0 It
> should default to 0, not 2, and only become nonzero when an IOMMU is
> properly established.=C2=A0 It also shouldn't be serving double duty as "=
what
> the user wants" ahead of determining the system capabilities.
>=20
> And not to open another can of worms, but our entire way of working
> explodes if there are devices on the system not covered by an IOMMU.
>=20
> ~Andrew
>=20



From xen-devel-bounces@lists.xenproject.org Wed Oct 20 08:25:23 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Oct 2021 08:25:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.213679.371968 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1md6uT-0001p5-LO; Wed, 20 Oct 2021 08:25:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 213679.371968; Wed, 20 Oct 2021 08:25:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1md6uT-0001oy-I5; Wed, 20 Oct 2021 08:25:17 +0000
Received: by outflank-mailman (input) for mailman id 213679;
 Wed, 20 Oct 2021 08:25:16 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=faDG=PI=arm.com=Bertrand.Marquis@srs-us1.protection.inumbo.net>)
 id 1md6uS-0001os-74
 for xen-devel@lists.xenproject.org; Wed, 20 Oct 2021 08:25:16 +0000
Received: from EUR05-AM6-obe.outbound.protection.outlook.com (unknown
 [40.107.22.54]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 404e9880-317f-11ec-8335-12813bfff9fa;
 Wed, 20 Oct 2021 08:25:15 +0000 (UTC)
Received: from DB9PR02CA0022.eurprd02.prod.outlook.com (2603:10a6:10:1d9::27)
 by DB7PR08MB2955.eurprd08.prod.outlook.com (2603:10a6:5:17::12) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.18; Wed, 20 Oct
 2021 08:25:04 +0000
Received: from DB5EUR03FT059.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:10:1d9:cafe::33) by DB9PR02CA0022.outlook.office365.com
 (2603:10a6:10:1d9::27) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15 via Frontend
 Transport; Wed, 20 Oct 2021 08:25:04 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT059.mail.protection.outlook.com (10.152.21.175) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.15 via Frontend Transport; Wed, 20 Oct 2021 08:25:04 +0000
Received: ("Tessian outbound 2e7020cc8961:v103");
 Wed, 20 Oct 2021 08:25:03 +0000
Received: from 6a91de061fc4.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 E4E6FD9B-9224-4C38-92FB-A76E56450FB3.1; 
 Wed, 20 Oct 2021 08:24:46 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 6a91de061fc4.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Wed, 20 Oct 2021 08:24:46 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com (2603:10a6:4:74::9)
 by DB7PR08MB3242.eurprd08.prod.outlook.com (2603:10a6:5:1a::31) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.18; Wed, 20 Oct
 2021 08:24:43 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955]) by DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955%4]) with mapi id 15.20.4608.018; Wed, 20 Oct 2021
 08:24:42 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 404e9880-317f-11ec-8335-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=vEE0kJ91wZ2EUQDlAMr6kKsHzEWC1mlTqI3sElifiAo=;
 b=hB0w6LS0Us7N2cLHMWCdZIHywr826jpr/bLEJNfmcRyqDcBoCAkL29ZHggxqjZ1ahY9IrYo8byyUdzzKoY+lm6U1CsJkyi+p4HUsC07kEFTWWWdtbbyXIVU8WYdYmcTWTjidkf5VzxU/c/WIf6QY0DElYvfInMNyS6iGYTfTS00=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 6d96e6681a6622aa
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=JLlOC5IGKPF7ba+BIUf7mOm26mOOfGilvzdidzsj7XaVN9SjqTWJKRbSPktBMXYObU5mU4b5fLHCdJ1+2m9Hb1LYWAGz44WbfMaG4o/N80PWjDlntVM2tO0fxBJ6z2YewvCQZ7yofetQk41M0eQiPs0fzq57ZN7mCvwr/FZ8bFgTzPLBsymny0jlqE42QHcMdJp/WIdA4/CKRvNApNIvUAzbkBfCjOngcZSKPuZDApJo4RYS7rCDn+IAJU5av8NSg71lheUhPVv3WmyDt9jzZwCKunJjUj6azFGHJpmAYawFhcyN8SvPyQfMQFvf3x0y8uamdsaEVTDCn5fGYtA07Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=vEE0kJ91wZ2EUQDlAMr6kKsHzEWC1mlTqI3sElifiAo=;
 b=Xzx916X6zItikA8kHNiRgYXtULMTlxLqLzuEgInn6o5WTkXDR2hMGc9nN+p6/e950wum5cwsMMH6u6p6D4nGWzYe4hVFwkT2o+QsWQLTL7S3Coy/Qhts0KGnU1RH9w6M0cm8TaWbako+h66AdaWn0gbpVLxL7/VLQMfVGYCrGKxCIen7tsl4KwmxvImcdI9SjX9LZ7s4lIEvaTOiNjCkF2rxCbUgTDP1V/qKK68MLy6ms9WVulHRpwVL0Ws7v/ZPOxtKbvk1Ihy5p5+V6K4x5Mp+GOYecsaMt5NV5mtzJSneBoD86BfOKPw2EbkFJ0jQW46e1ukITglMd1S0rTY/7Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=vEE0kJ91wZ2EUQDlAMr6kKsHzEWC1mlTqI3sElifiAo=;
 b=hB0w6LS0Us7N2cLHMWCdZIHywr826jpr/bLEJNfmcRyqDcBoCAkL29ZHggxqjZ1ahY9IrYo8byyUdzzKoY+lm6U1CsJkyi+p4HUsC07kEFTWWWdtbbyXIVU8WYdYmcTWTjidkf5VzxU/c/WIf6QY0DElYvfInMNyS6iGYTfTS00=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>, "iwj@xenproject.org"
	<iwj@xenproject.org>, "Oleksandr_Andrushchenko@epam.com"
	<Oleksandr_Andrushchenko@epam.com>, Stefano Stabellini
	<sstabellini@kernel.org>, Julien Grall <julien@xen.org>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Jan Beulich <jbeulich@suse.com>, Andrew Cooper
	<andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>, Paul Durrant
	<paul@xen.org>
Subject: Re: [PATCH v2 1/1] xen/pci: Install vpci handlers on x86 and fix exit
 path
Thread-Topic: [PATCH v2 1/1] xen/pci: Install vpci handlers on x86 and fix
 exit path
Thread-Index: AQHXxQOsddT9Ttg6SUi4XsLpyj6SjavbhAEAgAACKICAAAM+gIAABG4A
Date: Wed, 20 Oct 2021 08:24:42 +0000
Message-ID: <67D0191A-A7A6-4124-ACD3-39E3F1494312@arm.com>
References: <cover.1634659471.git.bertrand.marquis@arm.com>
 <d788dcce9e344a39f6761633f0e96774ab42c2aa.1634659471.git.bertrand.marquis@arm.com>
 <YW/KDHnZHz72mjuQ@MacBook-Air-de-Roger.local>
 <85549220-AF96-4913-B672-ED6795C91C3D@arm.com>
 <YW/Ok38nyeUlneky@MacBook-Air-de-Roger.local>
In-Reply-To: <YW/Ok38nyeUlneky@MacBook-Air-de-Roger.local>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3654.120.0.1.13)
Authentication-Results-Original: citrix.com; dkim=none (message not signed)
 header.d=none;citrix.com; dmarc=none action=none header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: d2261889-fe13-4417-f5c3-08d993a31dec
x-ms-traffictypediagnostic: DB7PR08MB3242:|DB7PR08MB2955:
X-Microsoft-Antispam-PRVS:
	<DB7PR08MB29554F5998B4EF33F848027F9DBE9@DB7PR08MB2955.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:9508;OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 y1+h2ejOEMbVCqVmEeDZ6l7dJOtzIFE/wI+I7rRod/IZcfRKDgF3xClbtqLaql0lPIajLOXK9NR+FaEcg5MpyAcsrpyRkkUMMifmV1bEfYJwxLfkcalJ4RoUCJL+fjbJ5bzf3lY4OKk4svJFJFu04C6nKYlhPGor7Juzgf3xHYNdrofkAw7OwWBoXdJ9B9NMEDhzVGSgjliebvvzs0JL3bxxUt1DtnnmRhEInDQj8olr/8i23bRXqEnxtbVQrilXNTINMUl8DwxnjH0sJPDOhYkUsHDvaSl5gwN5RBUYt7r4BRs3Pq8iR1yIqB7xu3FyHJy5yEaGHy+2NSdc+nDGRtieeydX1EOlY4+e4LIaasPto6EMTlE1Oobeq2yLJlXAPed/SeGk1zgNSYInZndDMvnGJtdytQ2ZvjXtP3u04KyVqvvOzM+iKvDgrq210LyvKdDIOnXyLiF/QfNCoLICRNWdfyTTD8ETiwzj/7VOsIpWIiIk+I6/rPpLkGKCtCK3XJkXDoM3Hw3QLPchAHqD1HDV2KAJ0b4kYGJoKUnOzyxxfPLvN9Z+CJW0eJ6Dire4iD0F2wJYBGS9vJ/7mMCA+5kmyVKoUBKKWXHPUXi6UILtSHFz3z8HKGLPn7C83OyAR10kfEDiHqKxqTk4RQ5fY+TJxgH/zBL2voAx3sZUO9SQgwkWslV8GJV6r4jzHMadgnvIbqPfCIIPSpeOF6qlPlBl1gCULbvunUTmfNd3HZtZTC44He3d+M5S1o5kpi2L
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB6PR0801MB2024.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(8676002)(6506007)(6486002)(5660300002)(508600001)(91956017)(4326008)(6916009)(76116006)(64756008)(66556008)(66476007)(7416002)(53546011)(186003)(8936002)(26005)(2906002)(86362001)(38100700002)(33656002)(316002)(54906003)(66946007)(2616005)(38070700005)(83380400001)(66446008)(36756003)(6512007)(122000001)(71200400001)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="utf-8"
Content-ID: <72F4B476F1D8C847942F51A155D686DD@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3242
Original-Authentication-Results: citrix.com; dkim=none (message not signed)
 header.d=none;citrix.com; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT059.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	165486a3-0707-46ba-ebea-08d993a31143
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	QRbP9ZvQ9uWyJXx/Is1F4hlxilF1V3zsCSd2Sddy5l8M2hKL9MEkmr0nOA0HzwuoCeaftsg2+tsCHR0llogtm2RkNYnQ1DplYEtUz8/yKTKL5GBiW0a5DmRGLeYU7f5yJBqZ62JeBzCrPOzIYmfYfAS+jB36wVVPz0LlkQDi228XkvutDdekSgr+cKIAI+e6/9HM44wLGkCi+j/WglXuhXOKUIXBJS5WkQPyL2CFtMoTRz8gXJ5q8jUBnT3UvMeoEpxkZkEspK6496Z9qOsJxJgputzy7jf/kqAbbnpM98gsyB514hNFwsbD3pl7egSGHVJ/4UwtDa7KEVFS+HF0yUHPrCOqzn/A/QNcJMAJPi6FLrXfYf5t0D55TEP4Qmtok6nQ7rpFoLvwYtKA2ac5LSQsL9gyzkwChBNIBPmIdTO0BFAQPgQ2x2LGb4zKowqUNEpfywBAunUgl4WzRWAhZkgp4xx61IJWqSbuSBCrwWREPp4OVmZT1j+zLoW19wsKyLeI4SfENEBBxzsRWHJXqzNYf/kHDMyYy6a7KtYwWafp2LFeXNhCVtRv5mVDbda3tcOpS/3uIEbWf+W5ACeMWwMRebTT7KrxtXvGdi7gFjL5wFrUeXMGAiY5FpC8RUI+qYA5Pr9IFRShPun1UA6RDaotRF8mkSHDxS0Y0nsLxh+8eFos37u0r7h3GLsyICtmBKG14pFVfYvvoi262jIr0A==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(2616005)(33656002)(508600001)(8676002)(6512007)(6506007)(53546011)(47076005)(82310400003)(4326008)(6862004)(356005)(6486002)(336012)(81166007)(186003)(54906003)(86362001)(8936002)(26005)(70206006)(36860700001)(70586007)(83380400001)(36756003)(316002)(2906002)(5660300002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2021 08:25:04.0556
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: d2261889-fe13-4417-f5c3-08d993a31dec
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT059.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB2955

SGkgUm9nZXIsDQoNCj4gT24gMjAgT2N0IDIwMjEsIGF0IDA5OjA4LCBSb2dlciBQYXUgTW9ubsOp
IDxyb2dlci5wYXVAY2l0cml4LmNvbT4gd3JvdGU6DQo+IA0KPiBPbiBXZWQsIE9jdCAyMCwgMjAy
MSBhdCAwNzo1NzoxNUFNICswMDAwLCBCZXJ0cmFuZCBNYXJxdWlzIHdyb3RlOg0KPj4gSGkgUm9n
ZXIsDQo+PiANCj4+PiBPbiAyMCBPY3QgMjAyMSwgYXQgMDg6NDksIFJvZ2VyIFBhdSBNb25uw6kg
PHJvZ2VyLnBhdUBjaXRyaXguY29tPiB3cm90ZToNCj4+PiANCj4+PiBPbiBUdWUsIE9jdCAxOSwg
MjAyMSBhdCAwNTowODoyOFBNICswMTAwLCBCZXJ0cmFuZCBNYXJxdWlzIHdyb3RlOg0KPj4+PiBY
ZW4gbWlnaHQgbm90IGJlIGFibGUgdG8gZGlzY292ZXIgYXQgYm9vdCB0aW1lIGFsbCBkZXZpY2Vz
IG9yIHNvbWUgZGV2aWNlcw0KPj4+PiBtaWdodCBhcHBlYXIgYWZ0ZXIgc3BlY2lmaWMgYWN0aW9u
cyBmcm9tIGRvbTAuDQo+Pj4+IEluIHRoaXMgY2FzZSBkb20wIGNhbiB1c2UgdGhlIFBIWVNERVZP
UF9wY2lfZGV2aWNlX2FkZCB0byBzaWduYWwgc29tZQ0KPj4+PiBQQ0kgZGV2aWNlcyB0byBYZW4u
DQo+Pj4+IEFzIHRob3NlIGRldmljZXMgd2hlcmUgbm90IGtub3duIGZyb20gWGVuIGJlZm9yZSwg
dGhlIHZwY2kgaGFuZGxlcnMgbXVzdA0KPj4+PiBiZSBwcm9wZXJseSBpbnN0YWxsZWQgZHVyaW5n
IHBjaV9kZXZpY2VfYWRkIGZvciB4ODYgUFZIIERvbTAsIGluIHRoZQ0KPj4+PiBzYW1lIHdheSBh
cyB3aGF0IGlzIGRvbmUgY3VycmVudGx5IG9uIGFybSAod2hlcmUgWGVuIGRvZXMgbm90IGRldGVj
dCBQQ0kNCj4+Pj4gZGV2aWNlcyBidXQgcmVsaWVzIG9uIERvbTAgdG8gZGVjbGFyZSB0aGVtIGFs
bCB0aGUgdGltZSkuDQo+Pj4+IA0KPj4+PiBTbyB0aGlzIHBhdGNoIGlzIHJlbW92aW5nIHRoZSBp
ZmRlZiBwcm90ZWN0aW5nIHRoZSBjYWxsIHRvDQo+Pj4+IHZwY2lfYWRkX2hhbmRsZXJzIGFuZCB0
aGUgY29tbWVudCB3aGljaCB3YXMgYXJtIHNwZWNpZmljLg0KPj4+PiANCj4+Pj4gdnBjaV9hZGRf
aGFuZGxlcnMgaXMgY2FsbGVkIG9uIGR1cmluZyBwY2lfZGV2aWNlX2FkZCB3aGljaCBjYW4gYmUg
Y2FsbGVkDQo+Pj4+IGF0IHJ1bnRpbWUgdGhyb3VnaCBoeXBlcmNhbGwgcGh5c2Rldl9vcC4NCj4+
Pj4gUmVtb3ZlIF9faHdkb21faW5pdCBhcyB0aGUgY2FsbCBpcyBub3QgbGltaXRlZCBhbnltb3Jl
IHRvIGhhcmR3YXJlDQo+Pj4+IGRvbWFpbiBpbml0IGFuZCBmaXggbGlua2VyIHNjcmlwdCB0byBv
bmx5IGtlZXAgdnBjaV9hcnJheSBpbiByb2RhdGENCj4+Pj4gc2VjdGlvbi4NCj4+Pj4gDQo+Pj4+
IEFkZCBtaXNzaW5nIHZwY2kgaGFuZGxlcnMgY2xlYW51cCBkdXJpbmcgcGNpX2RldmljZV9yZW1v
dmUgYW5kIGluIGNhc2UNCj4+Pj4gb2YgZXJyb3Igd2l0aCBpb21tdSBkdXJpbmcgcGNpX2Rldmlj
ZV9hZGQuDQo+Pj4+IA0KPj4+PiBBZGQgZW1wdHkgc3RhdGljIGlubGluZSBmb3IgdnBjaV9yZW1v
dmVfZGV2aWNlIHdoZW4gQ09ORklHX1ZQQ0kgaXMgbm90DQo+Pj4+IGRlZmluZWQuDQo+Pj4+IA0K
Pj4+PiBGaXhlczogZDU5MTY4ZGMwNSAoInhlbi9hcm06IEVuYWJsZSB0aGUgZXhpc3RpbmcgeDg2
IHZpcnR1YWwgUENJIHN1cHBvcnQNCj4+Pj4gZm9yIEFSTSIpDQo+Pj4+IFN1Z2dlc3RlZC1ieTog
SmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPg0KPj4+PiBTaWduZWQtb2ZmLWJ5OiBCZXJ0
cmFuZCBNYXJxdWlzIDxiZXJ0cmFuZC5tYXJxdWlzQGFybS5jb20+DQo+Pj4+IC0tLQ0KPj4+PiBD
aGFuZ2VzIGluIHYyDQo+Pj4+IC0gYWRkIGNvbW1lbnQgc3VnZ2VzdGVkIGJ5IEphbiBvbiB0b3Ag
b2YgdnBjaV9hZGRfaGFuZGxlcnMgY2FsbA0KPj4+PiAtIG1lcmdlIHRoZSAzIHBhdGNoZXMgb2Yg
dGhlIHNlcmllIGluIG9uZSBwYXRjaCBhbmQgcmVuYW1lZCBpdA0KPj4+PiAtIGZpeCB4ODYgYW5k
IGFybSBsaW5rZXIgc2NyaXB0IHRvIG9ubHkga2VlcCB2cGNpX2FycmF5IGluIHJvZGF0YSBhbmQN
Cj4+Pj4gb25seSB3aGVuIENPTkZJR19WUENJIGlzIHNldC4NCj4+Pj4gLS0tDQo+Pj4+IHhlbi9h
cmNoL2FybS94ZW4ubGRzLlMgICAgICAgIHwgOSArLS0tLS0tLS0NCj4+Pj4geGVuL2FyY2gveDg2
L3hlbi5sZHMuUyAgICAgICAgfCA5ICstLS0tLS0tLQ0KPj4+PiB4ZW4vZHJpdmVycy9wYXNzdGhy
b3VnaC9wY2kuYyB8IDggKysrKy0tLS0NCj4+Pj4geGVuL2RyaXZlcnMvdnBjaS92cGNpLmMgICAg
ICAgfCAyICstDQo+Pj4+IHhlbi9pbmNsdWRlL3hlbi92cGNpLmggICAgICAgIHwgMiArKw0KPj4+
PiA1IGZpbGVzIGNoYW5nZWQsIDkgaW5zZXJ0aW9ucygrKSwgMjEgZGVsZXRpb25zKC0pDQo+Pj4+
IA0KPj4+PiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gvYXJtL3hlbi5sZHMuUyBiL3hlbi9hcmNoL2Fy
bS94ZW4ubGRzLlMNCj4+Pj4gaW5kZXggYjc3M2Y5MWYxYy4uMDgwMTY5NDhhYiAxMDA2NDQNCj4+
Pj4gLS0tIGEveGVuL2FyY2gvYXJtL3hlbi5sZHMuUw0KPj4+PiArKysgYi94ZW4vYXJjaC9hcm0v
eGVuLmxkcy5TDQo+Pj4+IEBAIC02MCw3ICs2MCw3IEBAIFNFQ1RJT05TDQo+Pj4+ICAgICAgICoo
LnByb2MuaW5mbykNCj4+Pj4gICAgICAgX19wcm9jX2luZm9fZW5kID0gLjsNCj4+Pj4gDQo+Pj4+
IC0jaWYgZGVmaW5lZChDT05GSUdfSEFTX1ZQQ0kpICYmIGRlZmluZWQoQ09ORklHX0xBVEVfSFdE
T00pDQo+Pj4+ICsjaWZkZWYgQ09ORklHX0hBU19WUENJDQo+Pj4+ICAgICAgIC4gPSBBTElHTihQ
T0lOVEVSX0FMSUdOKTsNCj4+Pj4gICAgICAgX19zdGFydF92cGNpX2FycmF5ID0gLjsNCj4+Pj4g
ICAgICAgKihTT1JUKC5kYXRhLnZwY2kuKikpDQo+Pj4+IEBAIC0xODksMTMgKzE4OSw2IEBAIFNF
Q1RJT05TDQo+Pj4+ICAgICAgICooLmluaXRfYXJyYXkpDQo+Pj4+ICAgICAgICooU09SVCguaW5p
dF9hcnJheS4qKSkNCj4+Pj4gICAgICAgX19jdG9yc19lbmQgPSAuOw0KPj4+PiAtDQo+Pj4+IC0j
aWYgZGVmaW5lZChDT05GSUdfSEFTX1ZQQ0kpICYmICFkZWZpbmVkKENPTkZJR19MQVRFX0hXRE9N
KQ0KPj4+PiAtICAgICAgIC4gPSBBTElHTihQT0lOVEVSX0FMSUdOKTsNCj4+Pj4gLSAgICAgICBf
X3N0YXJ0X3ZwY2lfYXJyYXkgPSAuOw0KPj4+PiAtICAgICAgICooU09SVCguZGF0YS52cGNpLiop
KQ0KPj4+PiAtICAgICAgIF9fZW5kX3ZwY2lfYXJyYXkgPSAuOw0KPj4+PiAtI2VuZGlmDQo+Pj4+
ICB9IDp0ZXh0DQo+Pj4+ICBfX2luaXRfZW5kX2VmaSA9IC47DQo+Pj4+ICAuID0gQUxJR04oU1RB
Q0tfU0laRSk7DQo+Pj4+IGRpZmYgLS1naXQgYS94ZW4vYXJjaC94ODYveGVuLmxkcy5TIGIveGVu
L2FyY2gveDg2L3hlbi5sZHMuUw0KPj4+PiBpbmRleCAxMWIxZGEyMTU0Li44N2UzNDRkNGRkIDEw
MDY0NA0KPj4+PiAtLS0gYS94ZW4vYXJjaC94ODYveGVuLmxkcy5TDQo+Pj4+ICsrKyBiL3hlbi9h
cmNoL3g4Ni94ZW4ubGRzLlMNCj4+Pj4gQEAgLTEzNCw3ICsxMzQsNyBAQCBTRUNUSU9OUw0KPj4+
PiAgICAgICAqKC5leF90YWJsZS5wcmUpDQo+Pj4+ICAgICAgIF9fc3RvcF9fX3ByZV9leF90YWJs
ZSA9IC47DQo+Pj4+IA0KPj4+PiAtI2lmIGRlZmluZWQoQ09ORklHX0hBU19WUENJKSAmJiBkZWZp
bmVkKENPTkZJR19MQVRFX0hXRE9NKQ0KPj4+PiArI2lmZGVmIENPTkZJR19IQVNfVlBDSQ0KPj4+
PiAgICAgICAuID0gQUxJR04oUE9JTlRFUl9BTElHTik7DQo+Pj4+ICAgICAgIF9fc3RhcnRfdnBj
aV9hcnJheSA9IC47DQo+Pj4+ICAgICAgICooU09SVCguZGF0YS52cGNpLiopKQ0KPj4+PiBAQCAt
MjQ3LDEzICsyNDcsNiBAQCBTRUNUSU9OUw0KPj4+PiAgICAgICAqKC5pbml0X2FycmF5KQ0KPj4+
PiAgICAgICAqKFNPUlQoLmluaXRfYXJyYXkuKikpDQo+Pj4+ICAgICAgIF9fY3RvcnNfZW5kID0g
LjsNCj4+Pj4gLQ0KPj4+PiAtI2lmIGRlZmluZWQoQ09ORklHX0hBU19WUENJKSAmJiAhZGVmaW5l
ZChDT05GSUdfTEFURV9IV0RPTSkNCj4+Pj4gLSAgICAgICAuID0gQUxJR04oUE9JTlRFUl9BTElH
Tik7DQo+Pj4+IC0gICAgICAgX19zdGFydF92cGNpX2FycmF5ID0gLjsNCj4+Pj4gLSAgICAgICAq
KFNPUlQoLmRhdGEudnBjaS4qKSkNCj4+Pj4gLSAgICAgICBfX2VuZF92cGNpX2FycmF5ID0gLjsN
Cj4+Pj4gLSNlbmRpZg0KPj4+PiAgfSBQSERSKHRleHQpDQo+Pj4+IA0KPj4+PiAgLiA9IEFMSUdO
KFNFQ1RJT05fQUxJR04pOw0KPj4+PiBkaWZmIC0tZ2l0IGEveGVuL2RyaXZlcnMvcGFzc3Rocm91
Z2gvcGNpLmMgYi94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC9wY2kuYw0KPj4+PiBpbmRleCAzNWUw
MTkwNzk2Li44OTI4YTFjMDdkIDEwMDY0NA0KPj4+PiAtLS0gYS94ZW4vZHJpdmVycy9wYXNzdGhy
b3VnaC9wY2kuYw0KPj4+PiArKysgYi94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC9wY2kuYw0KPj4+
PiBAQCAtNzU2LDEwICs3NTYsOSBAQCBpbnQgcGNpX2FkZF9kZXZpY2UodTE2IHNlZywgdTggYnVz
LCB1OCBkZXZmbiwNCj4+Pj4gICAgaWYgKCAhcGRldi0+ZG9tYWluICkNCj4+Pj4gICAgew0KPj4+
PiAgICAgICAgcGRldi0+ZG9tYWluID0gaGFyZHdhcmVfZG9tYWluOw0KPj4+PiAtI2lmZGVmIENP
TkZJR19BUk0NCj4+Pj4gICAgICAgIC8qDQo+Pj4+IC0gICAgICAgICAqIE9uIEFSTSBQQ0kgZGV2
aWNlcyBkaXNjb3Zlcnkgd2lsbCBiZSBkb25lIGJ5IERvbTAuIEFkZCB2cGNpIGhhbmRsZXINCj4+
Pj4gLSAgICAgICAgICogd2hlbiBEb20wIGluZm9ybSBYRU4gdG8gYWRkIHRoZSBQQ0kgZGV2aWNl
cyBpbiBYRU4uDQo+Pj4+ICsgICAgICAgICAqIEZvciBkZXZpY2VzIG5vdCBkaXNjb3ZlcmVkIGJ5
IFhlbiBkdXJpbmcgYm9vdCwgYWRkIHZQQ0kgaGFuZGxlcnMNCj4+Pj4gKyAgICAgICAgICogd2hl
biBEb20wIGZpcnN0IGluZm9ybXMgWGVuIGFib3V0IHN1Y2ggZGV2aWNlcy4NCj4+Pj4gICAgICAg
ICAqLw0KPj4+PiAgICAgICAgcmV0ID0gdnBjaV9hZGRfaGFuZGxlcnMocGRldik7DQo+Pj4+ICAg
ICAgICBpZiAoIHJldCApDQo+Pj4+IEBAIC03NjgsMTAgKzc2NywxMCBAQCBpbnQgcGNpX2FkZF9k
ZXZpY2UodTE2IHNlZywgdTggYnVzLCB1OCBkZXZmbiwNCj4+Pj4gICAgICAgICAgICBwZGV2LT5k
b21haW4gPSBOVUxMOw0KPj4+PiAgICAgICAgICAgIGdvdG8gb3V0Ow0KPj4+PiAgICAgICAgfQ0K
Pj4+PiAtI2VuZGlmDQo+Pj4+ICAgICAgICByZXQgPSBpb21tdV9hZGRfZGV2aWNlKHBkZXYpOw0K
Pj4+PiAgICAgICAgaWYgKCByZXQgKQ0KPj4+PiAgICAgICAgew0KPj4+PiArICAgICAgICAgICAg
dnBjaV9yZW1vdmVfZGV2aWNlKHBkZXYpOw0KPj4+PiAgICAgICAgICAgIHBkZXYtPmRvbWFpbiA9
IE5VTEw7DQo+Pj4+ICAgICAgICAgICAgZ290byBvdXQ7DQo+Pj4+ICAgICAgICB9DQo+Pj4+IEBA
IC04MTksNiArODE4LDcgQEAgaW50IHBjaV9yZW1vdmVfZGV2aWNlKHUxNiBzZWcsIHU4IGJ1cywg
dTggZGV2Zm4pDQo+Pj4+ICAgIGxpc3RfZm9yX2VhY2hfZW50cnkgKCBwZGV2LCAmcHNlZy0+YWxs
ZGV2c19saXN0LCBhbGxkZXZzX2xpc3QgKQ0KPj4+PiAgICAgICAgaWYgKCBwZGV2LT5idXMgPT0g
YnVzICYmIHBkZXYtPmRldmZuID09IGRldmZuICkNCj4+Pj4gICAgICAgIHsNCj4+Pj4gKyAgICAg
ICAgICAgIHZwY2lfcmVtb3ZlX2RldmljZShwZGV2KTsNCj4+PiANCj4+PiB2cGNpX3JlbW92ZV9k
ZXZpY2UgaXMgbWlzc2luZyBhIGNoZWNrIGZvciBoYXNfdnBjaShwZGV2LT5kb21haW4pLCBhcw0K
Pj4+IGl0IHdpbGwgdW5jb25kaXRpb25hbGx5IGFjY2VzcyBwZGV2LT52cGNpIG90aGVyd2lzZSwg
YW5kIHRoYXQgd291bGQgYmUNCj4+PiB3cm9uZyBmb3IgZG9tYWlucyBub3QgdXNpbmcgdnBjaS4N
Cj4+PiANCj4+PiBJdCBtaWdodCBhbHNvIGJlIGdvb2QgdG8gYWRkIGFuIEFTU0VSVCghcGRldi0+
dnBjaSkgdG8NCj4+PiB2cGNpX2FkZF9oYW5kbGVycyBpbiBvcmRlciB0byBtYWtlIHN1cmUgdGhl
cmUgYXJlIG5vIGR1cGxpY2F0ZWQgY2FsbHMNCj4+PiB0byB2cGNpX2FkZF9oYW5kbGVycywgYnV0
IHRoYXQgY2FuIGJlIGRvbmUgaW4gYSBzZXBhcmF0ZSBwYXRjaC4NCj4+IA0KPj4gSSBjYW4gZG8g
Ym90aCBpbiB2MyAodG9nZXRoZXIgd2l0aCB0aGUgY2hhbmdlIG9mIGluIHRoZSBwYXRjaCBuYW1l
KS4NCj4+IA0KPj4gVW5sZXNzIHlvdSB3YW50IHRoZSBBU1NFUlQgaW4gYSBkaWZmZXJlbnQgcGF0
Y2gsIGluIHRoaXMgY2FzZSBJIGRvIG5vdCB0aGluaw0KPj4gSSBjYW4gbWFrZSBhIG5ldyBwYXRj
aCBmb3IgdGhhdC4NCj4+IA0KPj4gQ2FuIHlvdSBjb25maXJtIGlmIEkgc2hvdWxkIG9yIG5vdCBh
ZGQgdGhlIEFTU0VSVCBkaXJlY3RseSBpbiB0aGUgcGF0Y2ggPw0KPiANCj4gSSdtIGZpbmUgd2l0
aCBoYXZpbmcgdGhlIGFzc2VydCBhZGRlZCBoZXJlOiBpbiB3YXNuJ3QgbmVjZXNzYXJ5DQo+IHBy
ZXZpb3VzbHkgYXMgdGhlcmUgd2FzIGEgc2luZ2xlIGNhbGxlciBvZiB2cGNpX2FkZF9oYW5kbGVy
cy4gTm93IHRoYXQNCj4gdGhlcmUgYXJlIG11bHRpcGxlIG9uZXMgd2Ugc2hvdWxkIG1ha2Ugc3Vy
ZSBubyBkdXBsaWNhdGVkIGNhbGxzIGNhbg0KPiBoYXBwZW4uDQoNCk9rIEkgd2lsbCBhZGQgaXQg
dGhlbiBhbmQgc2VuZCB2MyB0aGlzIG1vcm5pbmcuDQoNCj4gDQo+IE9uIGEgZGlmZmVyZW50IG5v
dGUgKGFuZCBub3Qgc29tZXRoaW5nIHRoYXQgc2hvdWxkIGJlIHNvbHZlZCBoZXJlLA0KPiBqdXN0
IHdhbnRlZCB0byByYWlzZSBhdHRlbnRpb24gdG8gaXQpIHRoZXJlJ3MgYW4gZXhpc3RpbmcgVE9E
TyBhYm91dA0KPiB2cGNpX3JlbW92ZV9kZXZpY2UgYmVjYXVzZSBpdCBkb2Vzbid0IGNsZWFuIHRo
ZSAybmQgc3RhZ2UgbWFwcGluZ3MgZm9yDQo+IEJBUnMuIEF0IHNvbWUgcG9pbnQgd2UgbmVlZCB0
byBzb2x2ZSB0aGlzLCBvciBlbHNlIHRoZSByZW1vdmFsIG9mIHRoZQ0KPiBkZXZpY2UgaXMgbm90
IGNvbXBsZXRlLg0KDQpJIHdpbGwgdHJ5IHRvIGtlZXAgdGhhdCBpbiBtaW5kLg0KTWF5YmUgYWRk
aW5nIGEgVE9ETyBpbiB0aGUgY29kZSB3b3VsZCBiZSBhIGdvb2QgaWRlYS4NCg0KVGhhbmtzDQpC
ZXJ0cmFuZA0KDQo+IA0KPiBUaGFua3MsIFJvZ2VyLg0KDQo=


From xen-devel-bounces@lists.xenproject.org Wed Oct 20 08:28:17 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Oct 2021 08:28:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.213688.371979 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1md6xM-0002Rs-3q; Wed, 20 Oct 2021 08:28:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 213688.371979; Wed, 20 Oct 2021 08:28:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1md6xM-0002Rl-0G; Wed, 20 Oct 2021 08:28:16 +0000
Received: by outflank-mailman (input) for mailman id 213688;
 Wed, 20 Oct 2021 08:28:14 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ou1c=PI=citrix.com=roger.pau@srs-us1.protection.inumbo.net>)
 id 1md6xK-0002Rf-Ei
 for xen-devel@lists.xenproject.org; Wed, 20 Oct 2021 08:28:14 +0000
Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 6569a5ea-434c-4bb9-aa94-05d01a28d1c9;
 Wed, 20 Oct 2021 08:28:12 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6569a5ea-434c-4bb9-aa94-05d01a28d1c9
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1634718492;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=JrpICEE5d2ljyILpLqHyrbEj84NwWU1LV74QP/CuE48=;
  b=CSvDbez+NroB28yf9fpJmeRxAV6V0lbU86GIYcYuJHNygE6WUpWNs5Pg
   KJYeHq/JtTZUBKyG9vQi0VKqNa35uoYck4Iza9+/zWdJVNL8ahvZcTtLC
   VXFEPl62FgeaiU07vj5jfmGwpPcEUNzKi0MUsKL/+2mNuncRfRNLzS9PJ
   o=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: ypC2+/2a45jlLPG2ff8XNMbyu90nM4lSFsgw2KVyaaFmaE+narBh+MMsQnpre4RziGKr9fMwa5
 NyaHeVp/iVSnLR9A4v+rXv8yZ3srnA1etdNDGFb8rNtDCd29wf+KalCkgdXDhKX2dqf+Wk/GLr
 0WUSG8CKuI94h4uL/qulwROKySggK5ltw5lGZ68klNyTIomjTa7Ni4Akr27/9IubvQyGNP7TNL
 cZY/E335CZUnupvJepVVtzbhDqDwP1qCyy82gbYIItuj5D/CYFXIIYTb7u1KCL/kCAwbtvG+5g
 9mTtaYQ+9vJIiXEbIzaN4nV/
X-SBRS: 5.1
X-MesageID: 55171897
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:W/n2gK6aqE6y1tpvGamZmAxRtD3BchMFZxGqfqrLsTDasY5as4F+v
 mEWXWuHPvqLNGGhf4t1PYm2/RtU6p7czYBrHlBtrCpmHi5G8cbLO4+Ufxz6V8+wwmwvb67FA
 +E2MISowBUcFyeEzvuV3zyIQUBUjclkfJKlYAL/En03FVAMpBsJ00o5wrdh2NYw2LBVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Zk
 oVMv7+wdjUTYKiSp8AwYQR/AnpFFPgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALNs7kMZlZonh95TrYEewnUdbIRKCiCdpwgWpp2ZkeTKm2i
 8wxUGpjaDHCRhR1YVooCYAFlfeVvH7hSmgNwL6SjfVuuDWCpOBr65DTN97Sds2PVN9itE+Sr
 WLb/Ez0GhgfcteYzFKt8G+oh+LJtTP2XsQVDrLQ3vxgjUCXx2cTIAYLTlb9qv684mamUs9bA
 1wZ/Gwpt6da3FOvZsnwWVu/unHslg4RXZ9cHvM37CmJy7HI+ECJC24cVDlDZdc68sgsSlQC3
 FKTg8ngAzAptbSPUG+c7Z+dtzb0Mi8QRUcDei0sXQYD+8Pkoow4klTIVNkLOLWuktT/FDX0w
 jaLhCsznbMeiYgMzarT1XfDjjG3r57FVDkc4AnNQ3ml5QN0Yo2iT4Gw4F2d5vFFRLt1VXHY4
 iJCwZLHqrlTU9fdz0RhXdnhApnzt/ePEz3js2QxGsce0xmf5lmyJrt5tWQWyFhSDu4IfjrgY
 Un2sAxX5YNOMHbCUZKbc75dGOxxkvC+TYWNuuT8K4MUOMAoJVDvEDRGPBbIhwjQfF4QfbbT0
 HtxWf2nCmoGEuxZxT6ySvZ1PVQDl31mmz27qXwWyX2aPVuiiJy9Feht3LimNLlRAEa4TOP9q
 Yo32yyikE03bQEGSnOLmbP/1HhTRZTBObj4qtZMasmIKRd8FWcqBpf5mO16J9I7zvwPyr+Rp
 xlRv3O0LnKl2RUrzi3RMhhehE7HB84j/RrXwwR9VbpX55TTSdn2t/pOH3fGVbIm6PZi3ZZJo
 wotIK297gB0Ym2foVw1NMClxKQ7LUjDrV/ebkKNPWlkF7Y9FlOhxzMRVla2nMX4JnHs7pVWT
 nzJ/l6zfKfvsCw4UpaNNqzylw/r1ZXf8corN3b1zhBoUByE2KBhKjDrj+9xJMcJKB7ZwSCd2
 RrQChAdzdQhaadumDUQrazb/YqvDcVkGU9WQzvS4bqsbHGI9Wu/245QFu2PeGmFBm/z/ayjY
 8RTzu39b6JbzAob7dIkHuY517866vvuu6ReklZuEkLUYgn5EbhnOHSHg5VC7/Uf2r9DtAKqc
 UuT4d0Ga66RMcboHQdJdgooZ+iOz98OnTzW4ahnKUn2/nYvrrGGTV9TL1+HjykEdOl5N4Ysw
 OEAvs8K6lPg1kp2Y4je1i0NrjaCNH0NVakjp6o2Oo6zh1p50ExGbLzdFjTyvMOFZeJTPxR4O
 TSTnqfD2ehRnxKQb3opGHHR9uNBnpBS6gtSxVoPKlnVyNrIgvg7gE9Y/TgtF1kHyxxG16R4O
 3RxNl0zLqKLpm86iM9GVmGqOgdAGBzGpRChlwpXzDXUHxuyS2jADGwhIuLcrkkW/lVVciVf4
 LzFmn3uViznfZ2p0yY/MaK/RycPkTClGtX+pf2a
IronPort-HdrOrdr: A9a23:TN0WI6MWZVJpuMBcTyX155DYdb4zR+YMi2TDiHofdfUFSKClfp
 6V8cjztSWUtN4QMEtQ/uxoHJPwO080lKQFmrX5WI3NYOCIghrLEGgP1/qG/9SkIVyCygc/79
 YfT0EdMqyIMbESt6+Ti2PZYrVQseVvsprY/ds2p00dMj2CAJsQiTuRZDzrdnGfE2J9dOYE/d
 enl4F6jgvlXU5SQtWwB3EDUeSGj9rXlKj+aRpDIxI88gGBgR6h9ba/SnGjr1ojegIK5Y1n3X
 nOkgT/6Knmm/anyiXE32uWy5hNgtPuxvZKGcTJoMkILTfHjBquee1aKve/lQFwhNvqxEchkd
 HKrRtlF8Nv60nJdmXwmhfp0xmI6kdZ11bSjXujxVfzq83wQzw3T+Bbg5hCTxff4008+Plhza
 NixQuixtRqJCKFuB64y8nDVhlsmEbxi2Eli/Qvg3tWVpZbQKNNrLYY4FheHP47bW3HAbgcYa
 lT5fznlbVrmQvwVQGagoAv+q3hYp0LJGbGfqBY0fbllgS/nxhCvjwlLYIk7zM9HakGOup5Dt
 L/Q9BVfYF1P78rhJ1GdZU8qOuMeyXwqEH3QSqvyWqOLtBzB5uKke+x3IkI
X-IronPort-AV: E=Sophos;i="5.87,166,1631592000"; 
   d="scan'208";a="55171897"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=lUyNvvloIUoicSEX9BiP4YZ4zdYXdIB7qAfVCZa1D/9n4SjxgaHAYCsNQ3hMfpHK/8brgUipgj9nVRlKvHEas6wzh+pTvcBgHaVTeNOXnPZvogzL7hC7QBfWiPuzCRcOxqnr6MA7bZoPVjgxEIG2nXZ6WI4cQ6HoOSW61NieT8GBsyM/rJ3OStYon07wlAlJOY5kFkO6HKEIujgmRUa0TfvzD4CCfKr7qrRLa7CvDhPqrCp4/aOLQM10iNrgacL+3vsy2wWJSe1IEh51ks0FZ7zXCL4tJt9a4eXAo4LvyzLr6NtBlip5BB+x5KDiGp907VOc/xgFL3ZSh3BMz4e2gg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=c+TZg8WPP3akyTjvrlc+L0xyb2PkOCAI6o34wc2X8T8=;
 b=JkRDP7KZVBwDYUQG3UWKumQjJQWuHef0QkKb+Z7wgiSwQYGUbnTrjqJAtxffEiNFHQ2KwTSxNF8mggNAfqLITzDgarWiPNxSJLUCe0wsIm6WKc/ZAyo7AmPOTfhYv2PpJhOFpdqGW9IdTIuPDkEc1X5jyzXtFMP8q0JwHyKmAUn4nNz75snOi+Sf/fLDrVO1P1R+c/LNU3AtadvDpE+RYPBCYe9K7FGdcbp4n3W/oSAffdlc+pMw2Q0F9NiUetH/WACrRQlVWM9A9u08jBT70/zN4M72vs+mdVUbOuTViM+15KZnP5W8mbK/tQ/q18Ak1dGbqkyEh0WJ1wjedPfGfA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=c+TZg8WPP3akyTjvrlc+L0xyb2PkOCAI6o34wc2X8T8=;
 b=E2PNjbc4sgnvZT8KMTnp3wqCZEsGP+1hzxahGzAMxjPUZ6X1b3mSbYXoJjus0esamZge0z76Avh2kr2LolL7PTcfdf/X4u8uNSEkFl5RpZkVobJEQ5vN59GWSVxJBk2ka2KgPmQMxSPDhmrs/uGiz7fcv2zkib6ElQiWvVwt0jA=
Date: Wed, 20 Oct 2021 10:27:50 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Bertrand Marquis <bertrand.marquis@arm.com>
CC: <xen-devel@lists.xenproject.org>, <iwj@xenproject.org>,
	<Oleksandr_Andrushchenko@epam.com>, Stefano Stabellini
	<sstabellini@kernel.org>, Julien Grall <julien@xen.org>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Jan Beulich <jbeulich@suse.com>, Andrew Cooper
	<andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>, Paul Durrant
	<paul@xen.org>
Subject: Re: [PATCH v2 1/1] xen/pci: Install vpci handlers on x86 and fix
 exit path
Message-ID: <YW/TBnjCuRjm64nB@MacBook-Air-de-Roger.local>
References: <cover.1634659471.git.bertrand.marquis@arm.com>
 <d788dcce9e344a39f6761633f0e96774ab42c2aa.1634659471.git.bertrand.marquis@arm.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <d788dcce9e344a39f6761633f0e96774ab42c2aa.1634659471.git.bertrand.marquis@arm.com>
X-ClientProxiedBy: LO4P123CA0424.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:18b::15) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 4fe5cd61-0f8e-4bba-e332-08d993a38443
X-MS-TrafficTypeDiagnostic: DM5PR03MB2844:
X-Microsoft-Antispam-PRVS: <DM5PR03MB28442AFFB1615181FC1594B18FBE9@DM5PR03MB2844.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: YfmVzRbdHT+LmwbcJ+WAuaGB11KoUn3mYLQytZovykZ1ae3f7SmEADzrlvT0Z0NDzVKORT3KEd199B0lLHGXY6iA4zldLE7GzlV3MUtXtBzeVBNpk5mMtxYFtOCOJpYl+mG8BSIBfrFCuRtwNOaJ30ALdZ19IUpwZxOca9FCY0ZemNycJRNOGjWbbJvgfdaMLGWxK7FNwVpUnz6CDN6E4sJrD2l5/LGWeVWPtaNK3Or1eris9eCj6fJSuU/R6NiYF70htZ9h/iRNCbn6LTPTqsMjwrCOWEkWca0Sds+8hoNrkH/shhpCA64GiOpLAyP+EVfSaim3f9cQGnbGgJuo9rMPEsSqRSR9fVTYvlLml9w4J8SmdkWuofMMwWKijINiEmZBX1Lcr/2NK576PytCT46UHI7o1H2qjBu0b56cPYLAigrHN6UoRu27Ko01vDcba9YSUEmAXvrZCRkSouwdOmt2I2IJgtiMQ7LaK8rp3FtMVBV7J8ald6wMmL1KIHO/M2ZRNloyZ9GvHVStjkdjtLJyLJxlv3FAzJkIJi4wN9eQpfRx8MqcS44nDMpvwGI+05sO50+GT9KybGjvhJWhkn7bJmdYZIUvWbMyf0bohHi6i/ebAaNSb7/ugXPzpQeJU/hLkkGBnm/5CSw3INhK9w==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(956004)(4326008)(8936002)(6666004)(6486002)(2906002)(508600001)(316002)(5660300002)(9686003)(86362001)(8676002)(83380400001)(26005)(6916009)(66946007)(66556008)(66476007)(186003)(6496006)(85182001)(38100700002)(54906003)(7416002)(82960400001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L2hkMGI2Y09pVlpBeGpjUW1mRUFjWi92UCtWa2pjOHpSeDQzbkp6WUdzOGw4?=
 =?utf-8?B?Y2RBcS9JVHNGNHE4SzJqb1ROb2RFcGtSaHZ5KzdYUnBJS3p2T0dsUkt1Q3U4?=
 =?utf-8?B?K1p0S1Jodld2c0d0UnVLS3hpRjFDZE1FdGlJei9ETGdDTkZUaldzM3A3TDli?=
 =?utf-8?B?UWViWTI1WmF0NGVtUnJycjB6MDZQME1Ja3NneDVweTlpdmhhZlZ6OHVqc2VN?=
 =?utf-8?B?UXkySitpMVpKa1YxVlZjeFQrK1ZadUxQZ2FjV0xkOURMekhMRUg0cUdXSDFp?=
 =?utf-8?B?NFYvU1B5Q2VDUzdNUWlaN0ZZcVZxdG5zbi9QcFY1WjVjelZjOE5CUGNzQTJP?=
 =?utf-8?B?RnpaTm9xY1U5Wjh4SU5adkhnbDQ3STBLN2V1VFJmWGdvSXc4c1I3N0oreVlQ?=
 =?utf-8?B?VFpHbUorSlBzMnQwK0VyakFBMFpDNit0cmdwV1B4WWk2V2dDZTdsUW04ODRn?=
 =?utf-8?B?L1ZabStPZkcrV09RK2dYQXpnc2w0dEVFaGcxZ2ViTzdtSDNxY3pLNHErWnEv?=
 =?utf-8?B?cnNhT1JzWmlxemJKVzZLZkg5Y2JJTHZwT2VGZEVTcmFSQVhSSTdDNVNNUFNm?=
 =?utf-8?B?c2V0SlIwY3JoVUNSVW9HMExlRERQcVNsY0F4RmNnYzJNbUhRWTNrellOSXF0?=
 =?utf-8?B?ejJ0RVNTcVNMek1Jb09jRzFRODhpeDB5d1kwbnZQdWc0Ujl4d255NWk0RDhw?=
 =?utf-8?B?SGNVeDB0OThWQmNPVENrWDlPa3FVR2tLczZSOU1zRHNabWZSQ01PbzJpWE9s?=
 =?utf-8?B?T0I5ak9sbXFvYXE3SjlGeStlL0Jwdi9ydVdmUGxMUmo4VnpCZjdGdFJUNUVs?=
 =?utf-8?B?dU5pZmtKU3Q0SDNlK3Bzbm1JWGVhclM4aEYxdnVUcGlqdjBKUFNNYkJ6Q0N2?=
 =?utf-8?B?NVpwY21rYTYwaDVKZGZzMHZHRjluSFFSZkJmaTRIWkVaK3hVblBwVnlJc2l2?=
 =?utf-8?B?SnRpZjZPWG9maFovakYwM2xIU21pazl0dThXekNGNnhQdlNKYlRYSzVNamRX?=
 =?utf-8?B?VjV1VFpwSm5uTnFjVkRxaUU4Qkc0dmFpMzhiTkhKVzJiWThuN1Y5dEhsVDFp?=
 =?utf-8?B?RGhVVlBxVjZMRExLZ2tKeGNoeGJ5MERxei9ZUU12TWRORm1qcjNJa1FYL2Yx?=
 =?utf-8?B?ZEJ1ZURyOHFZUkUxQmNMSERQSnVJNVgzbklYUzRJSTRUSm1DcTNqVE1hMnJ2?=
 =?utf-8?B?bE5WSm5xOE5Gc2lBOFdJQ0FvbzhRaWtKc1RER0dZZnQ1NDQ1aEdCS3ZHcEZm?=
 =?utf-8?B?RUlPa0ZXZGRwUVVvUStlckgvd2gxUnZ0RDBoTkUzRWZOWXk3bk1GVFpCYzZx?=
 =?utf-8?B?dWhXdmJvV01GSjJaeVdPYVN3K2hzVG9wUjk3U25xNUpxd1I3TEJRMDVxL2p6?=
 =?utf-8?B?NnVsWmpRVWFNKzFWa3Y1MUhvUnRGcGdYQnBkTDJpU3hTUGZhRk04SEhZMVIz?=
 =?utf-8?B?amtqQzlEbjNyRFVlbnBUT3FDN0JoeEc1ZVhhSlJRMElrRjFLb3JTWVdIM3F0?=
 =?utf-8?B?UXNNbE5wMHFBVlZjN1R5K3doL2JOS1Fyb242SVhxcVJ4M2lBaHRoYjcxN1Ew?=
 =?utf-8?B?Z1F0V3pGTXlzRGxJU3BWdjNycnBuVGFhN0ppOWMydXMwYUhjT2ViOWY2N0Jn?=
 =?utf-8?B?cFQ1RTV6c0ZDRzl5ang5WEFSSzE0amI4VDU0aXY4Vm9qVURVQ3VXTjd6QlRy?=
 =?utf-8?B?dzRNQkZrd21wWCtHVnFyVjZKcFVpclRudVJkTkQ4a2RZZTVzZkhFNzd2QjNI?=
 =?utf-8?B?ckZKZ2ZqY2hraUx4eWNWZkhkV3pxVitKU09qMG93bGJzM29KTGRMZ3RPZnRD?=
 =?utf-8?B?YjhzeFNsSXZ6Y2VWQkdOMjlEVDdjU2ZrVGw2SFkvYWJnUjc2bXdPbUVaNDho?=
 =?utf-8?B?ajFLdVFiNUdFZ2RlLy95OGRwTGpOV1JZZXVJNWFCblI0aFBTb3lrZUcxZnNu?=
 =?utf-8?Q?lOzZepUZnEWew2IlyIE41sCpR8rt4219?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 4fe5cd61-0f8e-4bba-e332-08d993a38443
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2021 08:27:55.9511
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: roger.pau@citrix.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB2844
X-OriginatorOrg: citrix.com

On Tue, Oct 19, 2021 at 05:08:28PM +0100, Bertrand Marquis wrote:
> Xen might not be able to discover at boot time all devices or some devices
> might appear after specific actions from dom0.
> In this case dom0 can use the PHYSDEVOP_pci_device_add to signal some
> PCI devices to Xen.
> As those devices where not known from Xen before, the vpci handlers must
> be properly installed during pci_device_add for x86 PVH Dom0, in the
> same way as what is done currently on arm (where Xen does not detect PCI
> devices but relies on Dom0 to declare them all the time).
> 
> So this patch is removing the ifdef protecting the call to
> vpci_add_handlers and the comment which was arm specific.
> 
> vpci_add_handlers is called on during pci_device_add which can be called
> at runtime through hypercall physdev_op.
> Remove __hwdom_init as the call is not limited anymore to hardware
> domain init and fix linker script to only keep vpci_array in rodata
> section.
> 
> Add missing vpci handlers cleanup during pci_device_remove and in case
> of error with iommu during pci_device_add.
> 
> Add empty static inline for vpci_remove_device when CONFIG_VPCI is not
> defined.
> 
> Fixes: d59168dc05 ("xen/arm: Enable the existing x86 virtual PCI support
> for ARM")
> Suggested-by: Jan Beulich <jbeulich@suse.com>
> Signed-off-by: Bertrand Marquis <bertrand.marquis@arm.com>
> ---
> Changes in v2
> - add comment suggested by Jan on top of vpci_add_handlers call
> - merge the 3 patches of the serie in one patch and renamed it
> - fix x86 and arm linker script to only keep vpci_array in rodata and
> only when CONFIG_VPCI is set.
> ---
>  xen/arch/arm/xen.lds.S        | 9 +--------
>  xen/arch/x86/xen.lds.S        | 9 +--------
>  xen/drivers/passthrough/pci.c | 8 ++++----
>  xen/drivers/vpci/vpci.c       | 2 +-
>  xen/include/xen/vpci.h        | 2 ++
>  5 files changed, 9 insertions(+), 21 deletions(-)
> 
> diff --git a/xen/arch/arm/xen.lds.S b/xen/arch/arm/xen.lds.S
> index b773f91f1c..08016948ab 100644
> --- a/xen/arch/arm/xen.lds.S
> +++ b/xen/arch/arm/xen.lds.S
> @@ -60,7 +60,7 @@ SECTIONS
>         *(.proc.info)
>         __proc_info_end = .;
>  
> -#if defined(CONFIG_HAS_VPCI) && defined(CONFIG_LATE_HWDOM)
> +#ifdef CONFIG_HAS_VPCI
>         . = ALIGN(POINTER_ALIGN);
>         __start_vpci_array = .;
>         *(SORT(.data.vpci.*))
> @@ -189,13 +189,6 @@ SECTIONS
>         *(.init_array)
>         *(SORT(.init_array.*))
>         __ctors_end = .;
> -
> -#if defined(CONFIG_HAS_VPCI) && !defined(CONFIG_LATE_HWDOM)
> -       . = ALIGN(POINTER_ALIGN);
> -       __start_vpci_array = .;
> -       *(SORT(.data.vpci.*))
> -       __end_vpci_array = .;
> -#endif
>    } :text
>    __init_end_efi = .;
>    . = ALIGN(STACK_SIZE);
> diff --git a/xen/arch/x86/xen.lds.S b/xen/arch/x86/xen.lds.S
> index 11b1da2154..87e344d4dd 100644
> --- a/xen/arch/x86/xen.lds.S
> +++ b/xen/arch/x86/xen.lds.S
> @@ -134,7 +134,7 @@ SECTIONS
>         *(.ex_table.pre)
>         __stop___pre_ex_table = .;
>  
> -#if defined(CONFIG_HAS_VPCI) && defined(CONFIG_LATE_HWDOM)
> +#ifdef CONFIG_HAS_VPCI
>         . = ALIGN(POINTER_ALIGN);
>         __start_vpci_array = .;
>         *(SORT(.data.vpci.*))
> @@ -247,13 +247,6 @@ SECTIONS
>         *(.init_array)
>         *(SORT(.init_array.*))
>         __ctors_end = .;
> -
> -#if defined(CONFIG_HAS_VPCI) && !defined(CONFIG_LATE_HWDOM)
> -       . = ALIGN(POINTER_ALIGN);
> -       __start_vpci_array = .;
> -       *(SORT(.data.vpci.*))
> -       __end_vpci_array = .;
> -#endif
>    } PHDR(text)
>  
>    . = ALIGN(SECTION_ALIGN);
> diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci.c
> index 35e0190796..8928a1c07d 100644
> --- a/xen/drivers/passthrough/pci.c
> +++ b/xen/drivers/passthrough/pci.c
> @@ -756,10 +756,9 @@ int pci_add_device(u16 seg, u8 bus, u8 devfn,
>      if ( !pdev->domain )
>      {
>          pdev->domain = hardware_domain;
> -#ifdef CONFIG_ARM
>          /*
> -         * On ARM PCI devices discovery will be done by Dom0. Add vpci handler
> -         * when Dom0 inform XEN to add the PCI devices in XEN.
> +         * For devices not discovered by Xen during boot, add vPCI handlers
> +         * when Dom0 first informs Xen about such devices.
>           */
>          ret = vpci_add_handlers(pdev);
>          if ( ret )

Sorry to be a pain, but I think this placement of the call to
vpci_add_handlers is bogus and should instead be done strictly after
the device has been added to the hardware_domain->pdev_list list.

Otherwise the loop over domain->pdev_list (for_each_pdev) in
modify_bars won't be able to find the device and hit the assert below
it. That can happen in vpci_add_handlers as it will call init_bars
which in turn will call into modify_bars if memory decoding is enabled
for the device.

Regards, Roger.


From xen-devel-bounces@lists.xenproject.org Wed Oct 20 08:29:14 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Oct 2021 08:29:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.213696.371990 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1md6yI-000363-IT; Wed, 20 Oct 2021 08:29:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 213696.371990; Wed, 20 Oct 2021 08:29:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1md6yI-00035u-FK; Wed, 20 Oct 2021 08:29:14 +0000
Received: by outflank-mailman (input) for mailman id 213696;
 Wed, 20 Oct 2021 08:29:13 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1md6yH-00035k-1i; Wed, 20 Oct 2021 08:29:13 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1md6yG-0000bL-Qu; Wed, 20 Oct 2021 08:29:12 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1md6yG-0006C8-GV; Wed, 20 Oct 2021 08:29:12 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1md6yG-0006Ps-G0; Wed, 20 Oct 2021 08:29:12 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=XWfIeRU4KrxjL0No/VDcHTsbOn9HRUbfHhoyGnb9ouE=; b=Of3bW/nNQT8q+aoaTQzE3V6c+B
	oSKJY65UZR4+tvtwC8ORilnV2YdPQIpBXcxorCyGuwqKhZd4TAODbpIZFpJ8ihbldmYDWVFw8of0y
	eYXV2zsfZiRGqBLSoFrOedD/4nYHi7qpYC96Sicsd9x5BVRf1vJ7BQUp2r3voSU1ohpY=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165682-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 165682: tolerable FAIL - PUSHED
X-Osstest-Failures:
    qemu-mainline:test-armhf-armhf-xl-rtds:guest-stop:fail:allowable
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=50352cce138ef3b30c1cda28a4df68fff5da3202
X-Osstest-Versions-That:
    qemuu=362534a643b4a34bcb223996538ce9de5cdab946
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 20 Oct 2021 08:29:12 +0000

flight 165682 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165682/

Failures :-/ but no regressions.

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds     17 guest-stop               fail REGR. vs. 165670

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165670
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165670
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 165670
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 165670
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 165670
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 165670
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 165670
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165670
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 qemuu                50352cce138ef3b30c1cda28a4df68fff5da3202
baseline version:
 qemuu                362534a643b4a34bcb223996538ce9de5cdab946

Last test of basis   165670  2021-10-19 10:18:28 Z    0 days
Testing same since   165682  2021-10-19 21:09:14 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  David Hildenbrand <david@redhat.com>
  Juan Quintela <quintela@redhat.com>
  Leonardo Bras <leobras@redhat.com>
  Li Zhijian <lizhijian@cn.fujitsu.com>
  Lukas Straub <lukasstraub2@web.de>
  Richard Henderson <richard.henderson@linaro.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/qemu-xen.git
   362534a643..50352cce13  50352cce138ef3b30c1cda28a4df68fff5da3202 -> upstream-tested


From xen-devel-bounces@lists.xenproject.org Wed Oct 20 08:35:07 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Oct 2021 08:35:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.213705.372004 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1md73u-0004YP-8q; Wed, 20 Oct 2021 08:35:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 213705.372004; Wed, 20 Oct 2021 08:35:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1md73u-0004YI-5D; Wed, 20 Oct 2021 08:35:02 +0000
Received: by outflank-mailman (input) for mailman id 213705;
 Wed, 20 Oct 2021 08:35:01 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=TQMG=PI=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1md73t-0004YC-AU
 for xen-devel@lists.xenproject.org; Wed, 20 Oct 2021 08:35:01 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id f7c50e60-d35a-4e8f-b9f6-3956229c2e8a;
 Wed, 20 Oct 2021 08:34:59 +0000 (UTC)
Received: from EUR02-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur02lp2056.outbound.protection.outlook.com [104.47.4.56]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-23-qSRE3TtHOkiqna0FyxjSzw-1; Wed, 20 Oct 2021 10:34:57 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB3117.eurprd04.prod.outlook.com (2603:10a6:802:6::32) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.18; Wed, 20 Oct
 2021 08:34:54 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.018; Wed, 20 Oct 2021
 08:34:54 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6P192CA0104.EURP192.PROD.OUTLOOK.COM (2603:10a6:209:8d::45) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.18 via Frontend Transport; Wed, 20 Oct 2021 08:34:53 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f7c50e60-d35a-4e8f-b9f6-3956229c2e8a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634718898;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=SdQhJHhEdfB43Fooa8M80///foOXf+BWCZlA4Hz6N/Q=;
	b=IP82HdPhdGW2gzRUBXRC224WBOoBNO5mJ5fBiiToCobxcj9b8kmob8yLiaSQCGVaAyIbX1
	7vP6sd+BDn1uP7e6ENz+kud+uZ5W2dJJRQ79IfKJWOydOrbpjRYXPRy4XgUFA+6NRxCCEY
	kwTCPXCiTr4cp3N+D+JXLrkOiy2ZUrc=
X-MC-Unique: qSRE3TtHOkiqna0FyxjSzw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=eo832QnQna0cWQxF7C3s5CUFbI0rz7z4hFtCRYlIojreEgT4ju03FeXXSmghh0MAd7ioAuRUEgUyNEDfQsQHz9cnijc/6B5nYGhdie7mzDPw3TSkk9TgRyjy6DTQOcTsvg96WRDqncCzm4Ulr+b3iOEV9s9Od22gto6eMoEQGJ5XrHykWNnhcDX7IIELVwI9G2q/EEJEGOJpZmysA3K17zDTjZpaf2pazMBi9MDFDziPHPcOSaHGA8v8Bs2UcCOqhHrJMmKNOq7XgclsYotgWWxL+z8+9yEsozv0IfkpbDKLWiHTFjEK603WNdY/nVOQXvzpgajniXOXL/4a4n2lfw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=TZ8+6Pozb3p16OqmS6EHXaSK9qcum+AzoOeS59642s8=;
 b=mg/Qv4HEEZ9odQYC6WRJkA3YvMooax3riTNlihETq8Cc2lX2Tk1ANDcrlw49RCYlfzOB7VrwQjW+/6o4fc6lhZf/HEgn7nSSlWuYNMDowBflYLnMVMNADSDEBVzrcFTx1erqDm0u0HQoDkOA+ig5yQy9tddOS/vpQOdio9M3GX2MjVCxpQ5IH9BrYq7fQvjr+CbKEkNZdt291oHdBeZIuxWA6t549avRa08m+KYCYvvNqc4K/P47nCq1bl/kIOxPlc++Eyil0+ENBnHyQuXU4v2Tommk3+8I5vIb5l+tIq1bDMNPGv2WRHyoqNhqe8BOfiG3lNNhlBamOsBKU7Zw2w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: xen.org; dkim=none (message not signed)
 header.d=none;xen.org; dmarc=none action=none header.from=suse.com;
Subject: Re: [PATCH v2 1/1] xen/pci: Install vpci handlers on x86 and fix exit
 path
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>
CC: xen-devel@lists.xenproject.org, iwj@xenproject.org,
 Oleksandr_Andrushchenko@epam.com, Stefano Stabellini
 <sstabellini@kernel.org>, Julien Grall <julien@xen.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 Paul Durrant <paul@xen.org>
References: <cover.1634659471.git.bertrand.marquis@arm.com>
 <d788dcce9e344a39f6761633f0e96774ab42c2aa.1634659471.git.bertrand.marquis@arm.com>
 <YW/TBnjCuRjm64nB@MacBook-Air-de-Roger.local>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <e8f35e24-8dbe-db2c-02fd-f2290648a25a@suse.com>
Date: Wed, 20 Oct 2021 10:34:51 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <YW/TBnjCuRjm64nB@MacBook-Air-de-Roger.local>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6P192CA0104.EURP192.PROD.OUTLOOK.COM
 (2603:10a6:209:8d::45) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 44babfc0-398b-4ab3-ed29-08d993a47db6
X-MS-TrafficTypeDiagnostic: VI1PR04MB3117:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB3117C87B36669B65A87D0A9CB3BE9@VI1PR04MB3117.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	KBHgPf0JfEhD7hlhLeNQQ0888DChupMxvwP8l/XqfODQQlx8trV5j40pmPcCzfr744D47zEE8Zo4Ok1iUwOmc1aC/UYMP1nClABQzzRkKLpj9OMnTyir8NVujs391xZ/pWHT09xwoIQTPEGuUr/3zYde//ShPEzDVPpbXq/Fs6QEpEnvCqP19+t654dMSR6Mm/RoLfUqMIL2c7Ky3fQf3hUqLUfZUdB0oBFRpfjGNUHxYaCtkZfYF298xfbF5Mbzf8Gtft6BtvfMvRw+bvXWSLN9+g1nkGTRUHxUOdhU3s8rJgTTMXBjlMT0KuKizScMfw5NsfSeZ+7a3J8FrFHwkzxgILWQFZtmge0xLe66fItGauOE8XFaM6rlQicd9nxeJB5ks4wwEAsCZJS/hszHOylXbQyfelzOBYklV6kaqXnPiNK6mPyP8BsrbI53Guh9hEuicKtZeKeLZLCl5g0RTb13HL94XM/RkA9B8kYN4ECZh/M80kApyvKSCbwoXHuVvXv9WUyd4HNxswqHVdAptG/pvP3c7q7CujcsNkoXbXmnOO3YB5wbhdj3DbspUQ+QQZVV89lH4oB2tC3Q8OQ6pW1b7yzjtHlOQME26ZDq6BwExVGO5yW1tgDZhNTADbmR8x04oXTBbsIuDssKqZiNiSrYbahzwFbAB/PxGK9GEzWADEIS6BscBVafOjjQu0gaOdW/wTSIFdiGga4LhWH/NhcH1kixQoAjd4d5i9P4ln70GpJtrlWMzn7V5b3zaQKV
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(2616005)(83380400001)(54906003)(508600001)(8936002)(956004)(31696002)(110136005)(8676002)(38100700002)(53546011)(66946007)(316002)(7416002)(16576012)(66476007)(66556008)(2906002)(4326008)(86362001)(186003)(36756003)(6486002)(26005)(31686004)(5660300002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?Yuy85NORnlt519A/ccfblCjSYLBczVOWY2pyZsvTXv3wAXlopXAdnbVcyl60?=
 =?us-ascii?Q?UOmQ8WFfk38mgOXT/Cjxa7vYxXIgpk1oo+MdhHEMI5BFRZx2cnD2FtbLhsmq?=
 =?us-ascii?Q?Ucc7maHndwCSZDAehXAISVZk3BGXc2QprsjhOs7mapVezzo/kyP5zunTSxvg?=
 =?us-ascii?Q?LI7oLOmduuitCJBxmy9JijUIt/wqPEGHRjQ3QedIf2tzPJ8FWJxwjnHAei/W?=
 =?us-ascii?Q?kuO1gjRBz/DpPub0Lia3RW6vCXE1l6iCnWF8do4ww43SkKgk1UcMHgDRG7/S?=
 =?us-ascii?Q?cszIaB07El936BXE0uxNfzFhMb3acuw1azOwiAE8Ks+1isRwXta8s5eBXG5V?=
 =?us-ascii?Q?zf5W/CJCfg8BefINRuMrUZHcmsQlXoAGpjoE5ioOXQggijiplfLMQgYwx/RJ?=
 =?us-ascii?Q?8HWKriIgXnOd/+OYbu9QZJ6IjaFJ5/cCn0qK+otDMsUGKK363t/8RRtniYqi?=
 =?us-ascii?Q?YoMoWw6P70QZAkQIVAu9MGj95pc9nzbA+bkl+IhzSzHcDEoBMJV/g1I27Yeo?=
 =?us-ascii?Q?6QJ1rkOCczqVzIMFP0F3ZXA7ab+DBe/nS/kS5gAHbIJBI1h4DRePj2wYo9Lm?=
 =?us-ascii?Q?45uhDrO6+9G8PYDtjnURKZEJlYCUgMFmj2VB8c6SxvAqboJoFl2MN2SjBBdZ?=
 =?us-ascii?Q?QBcNrUDSlw/AfLOaORKIiH/FZxjPNe0S/5sTKasScobk0PmX6YXaNb8n3l+X?=
 =?us-ascii?Q?8tAc3Ng9IBgTZ13/t/s8tIydNDFxfdTF6d7ig0o3FD6FHcwx8d2WmCrrX5uu?=
 =?us-ascii?Q?SQH47yRZ+sgJBky1jRraG5Onh9Rc7Qymq+xFLybbb9bq3t5SqaB6vuC6bCsJ?=
 =?us-ascii?Q?TG2vQKMTf9kxKk86dqzvhqRBO3OqC31DBcYepLPfSskgfNK2rUGHhO3rHFHH?=
 =?us-ascii?Q?+38YT63vCw2OGb2tpJ2ORaW2Rt7kzEmdLcJavVnjAWd/cQyE5W9d7/QeX2VH?=
 =?us-ascii?Q?MrzPABKbJgbOa2dtrCpnvjHPSC9j46xzF7nA7kPP7roNUBHO7OfnrJc0Pxop?=
 =?us-ascii?Q?sSJTfTReLwxl4Ti9WeQKCuRc06NBvFmeX6mjC1m6d0hJzWKUS//FFPNI7iTj?=
 =?us-ascii?Q?AYiKPpk51EluAuvOYe8bJGbcN+dNbT+VsURBdJJDpBqzvuIfClr/hoaylK5M?=
 =?us-ascii?Q?zHMeKnFrKiy0oJoMAphH/Jx0FwRjGYmU4FNIsESwMFdLImoiOlnE7qwxB0Qe?=
 =?us-ascii?Q?+Jc7axXgnZByMj3sdGBB+ZODmYrYBTqUh2czuWPSGQip+UfhgrYzZJvaS7iM?=
 =?us-ascii?Q?l8vW8bNShlk8UgRElEXF9c6Xz8YmUWdrb9MTrQETEsyg13mmpw+rF67l3/G3?=
 =?us-ascii?Q?hE1im3MhSelaMDT28IwyXW5I?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 44babfc0-398b-4ab3-ed29-08d993a47db6
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2021 08:34:54.3335
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jbeulich@suse.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB3117

On 20.10.2021 10:27, Roger Pau Monn=C3=A9 wrote:
> On Tue, Oct 19, 2021 at 05:08:28PM +0100, Bertrand Marquis wrote:
>> Xen might not be able to discover at boot time all devices or some devic=
es
>> might appear after specific actions from dom0.
>> In this case dom0 can use the PHYSDEVOP_pci_device_add to signal some
>> PCI devices to Xen.
>> As those devices where not known from Xen before, the vpci handlers must
>> be properly installed during pci_device_add for x86 PVH Dom0, in the
>> same way as what is done currently on arm (where Xen does not detect PCI
>> devices but relies on Dom0 to declare them all the time).
>>
>> So this patch is removing the ifdef protecting the call to
>> vpci_add_handlers and the comment which was arm specific.
>>
>> vpci_add_handlers is called on during pci_device_add which can be called
>> at runtime through hypercall physdev_op.
>> Remove __hwdom_init as the call is not limited anymore to hardware
>> domain init and fix linker script to only keep vpci_array in rodata
>> section.
>>
>> Add missing vpci handlers cleanup during pci_device_remove and in case
>> of error with iommu during pci_device_add.
>>
>> Add empty static inline for vpci_remove_device when CONFIG_VPCI is not
>> defined.
>>
>> Fixes: d59168dc05 ("xen/arm: Enable the existing x86 virtual PCI support
>> for ARM")
>> Suggested-by: Jan Beulich <jbeulich@suse.com>
>> Signed-off-by: Bertrand Marquis <bertrand.marquis@arm.com>
>> ---
>> Changes in v2
>> - add comment suggested by Jan on top of vpci_add_handlers call
>> - merge the 3 patches of the serie in one patch and renamed it
>> - fix x86 and arm linker script to only keep vpci_array in rodata and
>> only when CONFIG_VPCI is set.
>> ---
>>  xen/arch/arm/xen.lds.S        | 9 +--------
>>  xen/arch/x86/xen.lds.S        | 9 +--------
>>  xen/drivers/passthrough/pci.c | 8 ++++----
>>  xen/drivers/vpci/vpci.c       | 2 +-
>>  xen/include/xen/vpci.h        | 2 ++
>>  5 files changed, 9 insertions(+), 21 deletions(-)
>>
>> diff --git a/xen/arch/arm/xen.lds.S b/xen/arch/arm/xen.lds.S
>> index b773f91f1c..08016948ab 100644
>> --- a/xen/arch/arm/xen.lds.S
>> +++ b/xen/arch/arm/xen.lds.S
>> @@ -60,7 +60,7 @@ SECTIONS
>>         *(.proc.info)
>>         __proc_info_end =3D .;
>> =20
>> -#if defined(CONFIG_HAS_VPCI) && defined(CONFIG_LATE_HWDOM)
>> +#ifdef CONFIG_HAS_VPCI
>>         . =3D ALIGN(POINTER_ALIGN);
>>         __start_vpci_array =3D .;
>>         *(SORT(.data.vpci.*))
>> @@ -189,13 +189,6 @@ SECTIONS
>>         *(.init_array)
>>         *(SORT(.init_array.*))
>>         __ctors_end =3D .;
>> -
>> -#if defined(CONFIG_HAS_VPCI) && !defined(CONFIG_LATE_HWDOM)
>> -       . =3D ALIGN(POINTER_ALIGN);
>> -       __start_vpci_array =3D .;
>> -       *(SORT(.data.vpci.*))
>> -       __end_vpci_array =3D .;
>> -#endif
>>    } :text
>>    __init_end_efi =3D .;
>>    . =3D ALIGN(STACK_SIZE);
>> diff --git a/xen/arch/x86/xen.lds.S b/xen/arch/x86/xen.lds.S
>> index 11b1da2154..87e344d4dd 100644
>> --- a/xen/arch/x86/xen.lds.S
>> +++ b/xen/arch/x86/xen.lds.S
>> @@ -134,7 +134,7 @@ SECTIONS
>>         *(.ex_table.pre)
>>         __stop___pre_ex_table =3D .;
>> =20
>> -#if defined(CONFIG_HAS_VPCI) && defined(CONFIG_LATE_HWDOM)
>> +#ifdef CONFIG_HAS_VPCI
>>         . =3D ALIGN(POINTER_ALIGN);
>>         __start_vpci_array =3D .;
>>         *(SORT(.data.vpci.*))
>> @@ -247,13 +247,6 @@ SECTIONS
>>         *(.init_array)
>>         *(SORT(.init_array.*))
>>         __ctors_end =3D .;
>> -
>> -#if defined(CONFIG_HAS_VPCI) && !defined(CONFIG_LATE_HWDOM)
>> -       . =3D ALIGN(POINTER_ALIGN);
>> -       __start_vpci_array =3D .;
>> -       *(SORT(.data.vpci.*))
>> -       __end_vpci_array =3D .;
>> -#endif
>>    } PHDR(text)
>> =20
>>    . =3D ALIGN(SECTION_ALIGN);
>> diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci=
.c
>> index 35e0190796..8928a1c07d 100644
>> --- a/xen/drivers/passthrough/pci.c
>> +++ b/xen/drivers/passthrough/pci.c
>> @@ -756,10 +756,9 @@ int pci_add_device(u16 seg, u8 bus, u8 devfn,
>>      if ( !pdev->domain )
>>      {
>>          pdev->domain =3D hardware_domain;
>> -#ifdef CONFIG_ARM
>>          /*
>> -         * On ARM PCI devices discovery will be done by Dom0. Add vpci =
handler
>> -         * when Dom0 inform XEN to add the PCI devices in XEN.
>> +         * For devices not discovered by Xen during boot, add vPCI hand=
lers
>> +         * when Dom0 first informs Xen about such devices.
>>           */
>>          ret =3D vpci_add_handlers(pdev);
>>          if ( ret )
>=20
> Sorry to be a pain, but I think this placement of the call to
> vpci_add_handlers is bogus and should instead be done strictly after
> the device has been added to the hardware_domain->pdev_list list.
>=20
> Otherwise the loop over domain->pdev_list (for_each_pdev) in
> modify_bars won't be able to find the device and hit the assert below
> it. That can happen in vpci_add_handlers as it will call init_bars
> which in turn will call into modify_bars if memory decoding is enabled
> for the device.

Oh, good point. And I should have thought of this myself, given that
I did hit that ASSERT() recently with a hidden device. FTAOD I think
this means that the list addition will need to move up (and then
would need undoing on the error path(s)).

Jan



From xen-devel-bounces@lists.xenproject.org Wed Oct 20 08:40:16 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Oct 2021 08:40:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.213713.372015 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1md78u-00062B-0Y; Wed, 20 Oct 2021 08:40:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 213713.372015; Wed, 20 Oct 2021 08:40:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1md78t-000624-TY; Wed, 20 Oct 2021 08:40:11 +0000
Received: by outflank-mailman (input) for mailman id 213713;
 Wed, 20 Oct 2021 08:40:09 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=faDG=PI=arm.com=Bertrand.Marquis@srs-us1.protection.inumbo.net>)
 id 1md78r-00061C-Rs
 for xen-devel@lists.xenproject.org; Wed, 20 Oct 2021 08:40:09 +0000
Received: from EUR02-VE1-obe.outbound.protection.outlook.com (unknown
 [2a01:111:f400:fe06::606])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 0e49cd45-e735-4e29-8cad-5f9e27a8bd98;
 Wed, 20 Oct 2021 08:40:07 +0000 (UTC)
Received: from AM6PR04CA0045.eurprd04.prod.outlook.com (2603:10a6:20b:f0::22)
 by PAXPR08MB7351.eurprd08.prod.outlook.com (2603:10a6:102:229::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.16; Wed, 20 Oct
 2021 08:40:05 +0000
Received: from AM5EUR03FT062.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:f0:cafe::7a) by AM6PR04CA0045.outlook.office365.com
 (2603:10a6:20b:f0::22) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.18 via Frontend
 Transport; Wed, 20 Oct 2021 08:40:05 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM5EUR03FT062.mail.protection.outlook.com (10.152.17.120) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.15 via Frontend Transport; Wed, 20 Oct 2021 08:40:04 +0000
Received: ("Tessian outbound 8e26f7114b75:v103");
 Wed, 20 Oct 2021 08:40:04 +0000
Received: from 5f2c7dd90d11.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 34486A6E-EA68-45D9-A60B-DDB5C15139F8.1; 
 Wed, 20 Oct 2021 08:39:57 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 5f2c7dd90d11.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Wed, 20 Oct 2021 08:39:57 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com (2603:10a6:4:74::9)
 by DBBPR08MB5963.eurprd08.prod.outlook.com (2603:10a6:10:205::21) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.16; Wed, 20 Oct
 2021 08:39:48 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955]) by DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955%4]) with mapi id 15.20.4608.018; Wed, 20 Oct 2021
 08:39:48 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0e49cd45-e735-4e29-8cad-5f9e27a8bd98
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=yxiaJzyAJ9vIPns1RUcpKVHrvDsiW+WXq7E3XhjE48E=;
 b=2dmySWhfZ+B87FwEY3jgs3kl7DCzFhBk9BPU+0PHc4sXJj+1oUFzXH0ppBUzNhgvM1wyHQBVlEHxA8hmc4PFIVsFDe/rpRornG4FR4U+6HxGMiJSd2NFVz21oqv8Nv5bU/EdfHUG2vUX6mMER60Ztv8TrYqzG69D8NlaaNrSkQk=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 3cf4241cf3efe19f
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=GScaeZS1eVfMtgrHaiXyBV5KkvQKWTjhC6bDcAJMADzxbrgg7cHDbq9/UrNOTTtelPaRYRqIGXAy89zv46UjULHoHlww1I2i0EZAvqQERFIkiijy6XeUNpY5YDD7gORBdKhknafBw1m+35L4dpvWeVXTpPc4o8gUcDu73HzmeiBEDHHvN2nd9mjo7YsrXhXRqo7rODnhrZIDduDe0XfjOS6krbV/cnUNygGEqg/I1KLu5N7wxwkYt8bjws8Wjyot+miURt+Zq5CPgOPKjkA+Lv1+57ECcE32e3nxShsMnBA6I2Tf0UZIVW0YT/vE3YNR3IrOAjaSWVD5POwKngUB5g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=yxiaJzyAJ9vIPns1RUcpKVHrvDsiW+WXq7E3XhjE48E=;
 b=k/slRj7dmjzFmld/Y/stXAhv5tOGHPTze0yLhZrl6YHetsE6C8DeLq5u1QmyF1FBK/Tvak46HQnx0Z5mbBWydBhDWg8F8llUqVHBwlFBQqaI05kkDBsRdb7HiKyhcjkCI2yR7qSP6UEFFqFlSuBPWnZnxwp1LP2Kd+5S5ovWsyI5KbneIFSyw+1Pgq7srMihYAXcsMY8Z3Ew+lgjo7DUMOETUkXioJXOOjY5dnS0UXwU7s3q2m3UOBHhz+KeuYEqyN66MHssL4pofgWxfzGCJ2cyrauJEIANe1Mi2c3AlnkkQ5cPN9GW7Spq6UzS95u4OQaRocP/cajeb58clB5TVw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=yxiaJzyAJ9vIPns1RUcpKVHrvDsiW+WXq7E3XhjE48E=;
 b=2dmySWhfZ+B87FwEY3jgs3kl7DCzFhBk9BPU+0PHc4sXJj+1oUFzXH0ppBUzNhgvM1wyHQBVlEHxA8hmc4PFIVsFDe/rpRornG4FR4U+6HxGMiJSd2NFVz21oqv8Nv5bU/EdfHUG2vUX6mMER60Ztv8TrYqzG69D8NlaaNrSkQk=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Jan Beulich <jbeulich@suse.com>
CC: =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	"iwj@xenproject.org" <iwj@xenproject.org>, "Oleksandr_Andrushchenko@epam.com"
	<Oleksandr_Andrushchenko@epam.com>, Stefano Stabellini
	<sstabellini@kernel.org>, Julien Grall <julien@xen.org>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Andrew Cooper <andrew.cooper3@citrix.com>, Wei
 Liu <wl@xen.org>, Paul Durrant <paul@xen.org>
Subject: Re: [PATCH v2 1/1] xen/pci: Install vpci handlers on x86 and fix exit
 path
Thread-Topic: [PATCH v2 1/1] xen/pci: Install vpci handlers on x86 and fix
 exit path
Thread-Index: AQHXxQOsddT9Ttg6SUi4XsLpyj6SjavbjrUAgAAB9oCAAAFiAA==
Date: Wed, 20 Oct 2021 08:39:48 +0000
Message-ID: <2FAC788E-1736-450C-B9B5-BDE93E32260E@arm.com>
References: <cover.1634659471.git.bertrand.marquis@arm.com>
 <d788dcce9e344a39f6761633f0e96774ab42c2aa.1634659471.git.bertrand.marquis@arm.com>
 <YW/TBnjCuRjm64nB@MacBook-Air-de-Roger.local>
 <e8f35e24-8dbe-db2c-02fd-f2290648a25a@suse.com>
In-Reply-To: <e8f35e24-8dbe-db2c-02fd-f2290648a25a@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3654.120.0.1.13)
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: a4456010-3d2c-4a68-a977-08d993a536d6
x-ms-traffictypediagnostic: DBBPR08MB5963:|PAXPR08MB7351:
X-Microsoft-Antispam-PRVS:
	<PAXPR08MB73514FAE2567D32AC748C6F59DBE9@PAXPR08MB7351.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:9508;OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 KUd/0fEmGxzMG+sfsuhgzzimoAV638hU73wooP7Q2akxhKmibhAF/PG3jGLl1VTD8A8ZDvvvsMS/e+vylvQiJQBiNORnEEHsgmZnsBaktuKlaz2e2rKegkw/0K9pZr5i4X7j9+IC3mqwO81D6zDxBofJkrMMP/IWHu42BxMbKaq0LlG+MRM1B6VX3f6AsMWRsafH4Ee0IY6WwehWMcY8gzbvwRiR2SI44PlHpmRjzcFzl5dNq21RamB+9JIAbUs05hx+tM7r+fyGUWOfQAP+4U5b24L2tWZVn3u7/aQ+Ecq67JGGboldHSlLqoSjfDm5yBw7jk5LGhWwufaPFEBOcRr+ZXkxmb5xYPwKRMQrt/m+xR6J/e1qwIAie494EtvBHxChE4W+rLZbRkSKO6j4ROR+Qxd0feRZgXeWiR8WUyO9GyrUIPLTkjRAjM7yrTZ6PqXNWjkAnP7wXsA2+wYUIaEjTmNDSxEIAbmHkQgFnDPZG5h3HkwFzGjRRnNEy3Pa/nI8vmzF5erdq0kE4J/+n0hRMAo4TJPcO1quhJXbR3JDD7uMnc9Ik6UrnIPU/LStJclz6E/+hvtIK0HiBnAMhBqz+X2mUAa6tPzJZG9cXvb43PVFSPShWRFuP+eMZW7jPx1hMleSgEmvGyr+1OaiFB1lCtCdwOaGtMW71Eei3UumXso0JDqlP97KJFpUQFFmwJTwslq5E0lZXQ1haaGidZZvnNjEWr0luhhmGkIo4t2D7FTkMddc69LIIzbgr+fZ
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB6PR0801MB2024.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(38070700005)(54906003)(122000001)(6512007)(83380400001)(8676002)(8936002)(66556008)(316002)(2616005)(6486002)(33656002)(5660300002)(64756008)(66446008)(66476007)(76116006)(91956017)(38100700002)(66946007)(36756003)(6916009)(4326008)(26005)(508600001)(2906002)(186003)(6506007)(53546011)(7416002)(86362001)(71200400001)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-ID: <EB8E0D7F6CA92C4895202CF572F35DDD@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB5963
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM5EUR03FT062.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	ccac6cc5-b0f1-4734-c1fb-08d993a52d52
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	/C8Qjt14wz+1Y7PgA2/GlbahwTYWWYJAS0tmMjRJMR5+DKwgxHo/NpPTOJNZ2F4H0LFzuQIYh9kg4VA8vjA6wpPtEzcaRipZKuZGhFzf+BIxG+hLJXEcd9Z3og5GgHzDS6DYUMUDT3iHZm9RDc15h2JkIuYRFia/0Z0/FcM8LOWPdpcbBTbHDe+rNEE/PxbbDJoyd6zCiNn+lr49+5B7DVP+q4kMxEH0DzHFmcMOCkuWeAlXK5A+ApUlJ6cCJF99ku7aFk7WmCW5UYIwAhiSMdmyzBm7HJYRDqrzY+LRqDARwH4VJC6XSeJ5MD46jaTO1mM96DsGGaRkDCJLfw6ZgMuVsVdW27IPEWi8SbSA3NVQPFNcQKxo+Z9NZnOsglSYCtYrWLxrwwJBf5bAGheufiFiaH1C2YkXv55IUs3GO10R4m/yuAZbf2pK6nVBUJJbW1V3NpeZRgSaCbw5mmAXZInWMKoMCKMkqw2+1WvqC6fdVWLZQrgBBY2Z22ZRcgzHJFfoTxp8cid7YTVhvwAn81uYpkOEb++aplnagG0Aja2swf+G7v1z0UfZyqViwd95S9u1+nWz4zTY7NcsA0D4Alnlf2g0sVj5ade6yx09KkTDEXHF6EAAJgrjXXeV9+OucljS76uLqRqLegFhJroMr4xz9p5RynL+VhwHFyPJ4q9alOC0vRsRJjrwSJxkgBkTOEZ3JjvJ/2LbybW6BldqAQ==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(316002)(54906003)(83380400001)(36756003)(6486002)(36860700001)(6512007)(4326008)(2616005)(186003)(26005)(6506007)(82310400003)(336012)(33656002)(81166007)(8936002)(53546011)(8676002)(70586007)(70206006)(2906002)(47076005)(508600001)(5660300002)(356005)(6862004)(86362001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2021 08:40:04.7980
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: a4456010-3d2c-4a68-a977-08d993a536d6
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM5EUR03FT062.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB7351

SGksDQoNCj4gT24gMjAgT2N0IDIwMjEsIGF0IDA5OjM0LCBKYW4gQmV1bGljaCA8amJldWxpY2hA
c3VzZS5jb20+IHdyb3RlOg0KPiANCj4gT24gMjAuMTAuMjAyMSAxMDoyNywgUm9nZXIgUGF1IE1v
bm7DqSB3cm90ZToNCj4+IE9uIFR1ZSwgT2N0IDE5LCAyMDIxIGF0IDA1OjA4OjI4UE0gKzAxMDAs
IEJlcnRyYW5kIE1hcnF1aXMgd3JvdGU6DQo+Pj4gWGVuIG1pZ2h0IG5vdCBiZSBhYmxlIHRvIGRp
c2NvdmVyIGF0IGJvb3QgdGltZSBhbGwgZGV2aWNlcyBvciBzb21lIGRldmljZXMNCj4+PiBtaWdo
dCBhcHBlYXIgYWZ0ZXIgc3BlY2lmaWMgYWN0aW9ucyBmcm9tIGRvbTAuDQo+Pj4gSW4gdGhpcyBj
YXNlIGRvbTAgY2FuIHVzZSB0aGUgUEhZU0RFVk9QX3BjaV9kZXZpY2VfYWRkIHRvIHNpZ25hbCBz
b21lDQo+Pj4gUENJIGRldmljZXMgdG8gWGVuLg0KPj4+IEFzIHRob3NlIGRldmljZXMgd2hlcmUg
bm90IGtub3duIGZyb20gWGVuIGJlZm9yZSwgdGhlIHZwY2kgaGFuZGxlcnMgbXVzdA0KPj4+IGJl
IHByb3Blcmx5IGluc3RhbGxlZCBkdXJpbmcgcGNpX2RldmljZV9hZGQgZm9yIHg4NiBQVkggRG9t
MCwgaW4gdGhlDQo+Pj4gc2FtZSB3YXkgYXMgd2hhdCBpcyBkb25lIGN1cnJlbnRseSBvbiBhcm0g
KHdoZXJlIFhlbiBkb2VzIG5vdCBkZXRlY3QgUENJDQo+Pj4gZGV2aWNlcyBidXQgcmVsaWVzIG9u
IERvbTAgdG8gZGVjbGFyZSB0aGVtIGFsbCB0aGUgdGltZSkuDQo+Pj4gDQo+Pj4gU28gdGhpcyBw
YXRjaCBpcyByZW1vdmluZyB0aGUgaWZkZWYgcHJvdGVjdGluZyB0aGUgY2FsbCB0bw0KPj4+IHZw
Y2lfYWRkX2hhbmRsZXJzIGFuZCB0aGUgY29tbWVudCB3aGljaCB3YXMgYXJtIHNwZWNpZmljLg0K
Pj4+IA0KPj4+IHZwY2lfYWRkX2hhbmRsZXJzIGlzIGNhbGxlZCBvbiBkdXJpbmcgcGNpX2Rldmlj
ZV9hZGQgd2hpY2ggY2FuIGJlIGNhbGxlZA0KPj4+IGF0IHJ1bnRpbWUgdGhyb3VnaCBoeXBlcmNh
bGwgcGh5c2Rldl9vcC4NCj4+PiBSZW1vdmUgX19od2RvbV9pbml0IGFzIHRoZSBjYWxsIGlzIG5v
dCBsaW1pdGVkIGFueW1vcmUgdG8gaGFyZHdhcmUNCj4+PiBkb21haW4gaW5pdCBhbmQgZml4IGxp
bmtlciBzY3JpcHQgdG8gb25seSBrZWVwIHZwY2lfYXJyYXkgaW4gcm9kYXRhDQo+Pj4gc2VjdGlv
bi4NCj4+PiANCj4+PiBBZGQgbWlzc2luZyB2cGNpIGhhbmRsZXJzIGNsZWFudXAgZHVyaW5nIHBj
aV9kZXZpY2VfcmVtb3ZlIGFuZCBpbiBjYXNlDQo+Pj4gb2YgZXJyb3Igd2l0aCBpb21tdSBkdXJp
bmcgcGNpX2RldmljZV9hZGQuDQo+Pj4gDQo+Pj4gQWRkIGVtcHR5IHN0YXRpYyBpbmxpbmUgZm9y
IHZwY2lfcmVtb3ZlX2RldmljZSB3aGVuIENPTkZJR19WUENJIGlzIG5vdA0KPj4+IGRlZmluZWQu
DQo+Pj4gDQo+Pj4gRml4ZXM6IGQ1OTE2OGRjMDUgKCJ4ZW4vYXJtOiBFbmFibGUgdGhlIGV4aXN0
aW5nIHg4NiB2aXJ0dWFsIFBDSSBzdXBwb3J0DQo+Pj4gZm9yIEFSTSIpDQo+Pj4gU3VnZ2VzdGVk
LWJ5OiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+DQo+Pj4gU2lnbmVkLW9mZi1ieTog
QmVydHJhbmQgTWFycXVpcyA8YmVydHJhbmQubWFycXVpc0Bhcm0uY29tPg0KPj4+IC0tLQ0KPj4+
IENoYW5nZXMgaW4gdjINCj4+PiAtIGFkZCBjb21tZW50IHN1Z2dlc3RlZCBieSBKYW4gb24gdG9w
IG9mIHZwY2lfYWRkX2hhbmRsZXJzIGNhbGwNCj4+PiAtIG1lcmdlIHRoZSAzIHBhdGNoZXMgb2Yg
dGhlIHNlcmllIGluIG9uZSBwYXRjaCBhbmQgcmVuYW1lZCBpdA0KPj4+IC0gZml4IHg4NiBhbmQg
YXJtIGxpbmtlciBzY3JpcHQgdG8gb25seSBrZWVwIHZwY2lfYXJyYXkgaW4gcm9kYXRhIGFuZA0K
Pj4+IG9ubHkgd2hlbiBDT05GSUdfVlBDSSBpcyBzZXQuDQo+Pj4gLS0tDQo+Pj4geGVuL2FyY2gv
YXJtL3hlbi5sZHMuUyAgICAgICAgfCA5ICstLS0tLS0tLQ0KPj4+IHhlbi9hcmNoL3g4Ni94ZW4u
bGRzLlMgICAgICAgIHwgOSArLS0tLS0tLS0NCj4+PiB4ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC9w
Y2kuYyB8IDggKysrKy0tLS0NCj4+PiB4ZW4vZHJpdmVycy92cGNpL3ZwY2kuYyAgICAgICB8IDIg
Ky0NCj4+PiB4ZW4vaW5jbHVkZS94ZW4vdnBjaS5oICAgICAgICB8IDIgKysNCj4+PiA1IGZpbGVz
IGNoYW5nZWQsIDkgaW5zZXJ0aW9ucygrKSwgMjEgZGVsZXRpb25zKC0pDQo+Pj4gDQo+Pj4gZGlm
ZiAtLWdpdCBhL3hlbi9hcmNoL2FybS94ZW4ubGRzLlMgYi94ZW4vYXJjaC9hcm0veGVuLmxkcy5T
DQo+Pj4gaW5kZXggYjc3M2Y5MWYxYy4uMDgwMTY5NDhhYiAxMDA2NDQNCj4+PiAtLS0gYS94ZW4v
YXJjaC9hcm0veGVuLmxkcy5TDQo+Pj4gKysrIGIveGVuL2FyY2gvYXJtL3hlbi5sZHMuUw0KPj4+
IEBAIC02MCw3ICs2MCw3IEBAIFNFQ1RJT05TDQo+Pj4gICAgICAgICooLnByb2MuaW5mbykNCj4+
PiAgICAgICAgX19wcm9jX2luZm9fZW5kID0gLjsNCj4+PiANCj4+PiAtI2lmIGRlZmluZWQoQ09O
RklHX0hBU19WUENJKSAmJiBkZWZpbmVkKENPTkZJR19MQVRFX0hXRE9NKQ0KPj4+ICsjaWZkZWYg
Q09ORklHX0hBU19WUENJDQo+Pj4gICAgICAgIC4gPSBBTElHTihQT0lOVEVSX0FMSUdOKTsNCj4+
PiAgICAgICAgX19zdGFydF92cGNpX2FycmF5ID0gLjsNCj4+PiAgICAgICAgKihTT1JUKC5kYXRh
LnZwY2kuKikpDQo+Pj4gQEAgLTE4OSwxMyArMTg5LDYgQEAgU0VDVElPTlMNCj4+PiAgICAgICAg
KiguaW5pdF9hcnJheSkNCj4+PiAgICAgICAgKihTT1JUKC5pbml0X2FycmF5LiopKQ0KPj4+ICAg
ICAgICBfX2N0b3JzX2VuZCA9IC47DQo+Pj4gLQ0KPj4+IC0jaWYgZGVmaW5lZChDT05GSUdfSEFT
X1ZQQ0kpICYmICFkZWZpbmVkKENPTkZJR19MQVRFX0hXRE9NKQ0KPj4+IC0gICAgICAgLiA9IEFM
SUdOKFBPSU5URVJfQUxJR04pOw0KPj4+IC0gICAgICAgX19zdGFydF92cGNpX2FycmF5ID0gLjsN
Cj4+PiAtICAgICAgICooU09SVCguZGF0YS52cGNpLiopKQ0KPj4+IC0gICAgICAgX19lbmRfdnBj
aV9hcnJheSA9IC47DQo+Pj4gLSNlbmRpZg0KPj4+ICAgfSA6dGV4dA0KPj4+ICAgX19pbml0X2Vu
ZF9lZmkgPSAuOw0KPj4+ICAgLiA9IEFMSUdOKFNUQUNLX1NJWkUpOw0KPj4+IGRpZmYgLS1naXQg
YS94ZW4vYXJjaC94ODYveGVuLmxkcy5TIGIveGVuL2FyY2gveDg2L3hlbi5sZHMuUw0KPj4+IGlu
ZGV4IDExYjFkYTIxNTQuLjg3ZTM0NGQ0ZGQgMTAwNjQ0DQo+Pj4gLS0tIGEveGVuL2FyY2gveDg2
L3hlbi5sZHMuUw0KPj4+ICsrKyBiL3hlbi9hcmNoL3g4Ni94ZW4ubGRzLlMNCj4+PiBAQCAtMTM0
LDcgKzEzNCw3IEBAIFNFQ1RJT05TDQo+Pj4gICAgICAgICooLmV4X3RhYmxlLnByZSkNCj4+PiAg
ICAgICAgX19zdG9wX19fcHJlX2V4X3RhYmxlID0gLjsNCj4+PiANCj4+PiAtI2lmIGRlZmluZWQo
Q09ORklHX0hBU19WUENJKSAmJiBkZWZpbmVkKENPTkZJR19MQVRFX0hXRE9NKQ0KPj4+ICsjaWZk
ZWYgQ09ORklHX0hBU19WUENJDQo+Pj4gICAgICAgIC4gPSBBTElHTihQT0lOVEVSX0FMSUdOKTsN
Cj4+PiAgICAgICAgX19zdGFydF92cGNpX2FycmF5ID0gLjsNCj4+PiAgICAgICAgKihTT1JUKC5k
YXRhLnZwY2kuKikpDQo+Pj4gQEAgLTI0NywxMyArMjQ3LDYgQEAgU0VDVElPTlMNCj4+PiAgICAg
ICAgKiguaW5pdF9hcnJheSkNCj4+PiAgICAgICAgKihTT1JUKC5pbml0X2FycmF5LiopKQ0KPj4+
ICAgICAgICBfX2N0b3JzX2VuZCA9IC47DQo+Pj4gLQ0KPj4+IC0jaWYgZGVmaW5lZChDT05GSUdf
SEFTX1ZQQ0kpICYmICFkZWZpbmVkKENPTkZJR19MQVRFX0hXRE9NKQ0KPj4+IC0gICAgICAgLiA9
IEFMSUdOKFBPSU5URVJfQUxJR04pOw0KPj4+IC0gICAgICAgX19zdGFydF92cGNpX2FycmF5ID0g
LjsNCj4+PiAtICAgICAgICooU09SVCguZGF0YS52cGNpLiopKQ0KPj4+IC0gICAgICAgX19lbmRf
dnBjaV9hcnJheSA9IC47DQo+Pj4gLSNlbmRpZg0KPj4+ICAgfSBQSERSKHRleHQpDQo+Pj4gDQo+
Pj4gICAuID0gQUxJR04oU0VDVElPTl9BTElHTik7DQo+Pj4gZGlmZiAtLWdpdCBhL3hlbi9kcml2
ZXJzL3Bhc3N0aHJvdWdoL3BjaS5jIGIveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvcGNpLmMNCj4+
PiBpbmRleCAzNWUwMTkwNzk2Li44OTI4YTFjMDdkIDEwMDY0NA0KPj4+IC0tLSBhL3hlbi9kcml2
ZXJzL3Bhc3N0aHJvdWdoL3BjaS5jDQo+Pj4gKysrIGIveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gv
cGNpLmMNCj4+PiBAQCAtNzU2LDEwICs3NTYsOSBAQCBpbnQgcGNpX2FkZF9kZXZpY2UodTE2IHNl
ZywgdTggYnVzLCB1OCBkZXZmbiwNCj4+PiAgICAgaWYgKCAhcGRldi0+ZG9tYWluICkNCj4+PiAg
ICAgew0KPj4+ICAgICAgICAgcGRldi0+ZG9tYWluID0gaGFyZHdhcmVfZG9tYWluOw0KPj4+IC0j
aWZkZWYgQ09ORklHX0FSTQ0KPj4+ICAgICAgICAgLyoNCj4+PiAtICAgICAgICAgKiBPbiBBUk0g
UENJIGRldmljZXMgZGlzY292ZXJ5IHdpbGwgYmUgZG9uZSBieSBEb20wLiBBZGQgdnBjaSBoYW5k
bGVyDQo+Pj4gLSAgICAgICAgICogd2hlbiBEb20wIGluZm9ybSBYRU4gdG8gYWRkIHRoZSBQQ0kg
ZGV2aWNlcyBpbiBYRU4uDQo+Pj4gKyAgICAgICAgICogRm9yIGRldmljZXMgbm90IGRpc2NvdmVy
ZWQgYnkgWGVuIGR1cmluZyBib290LCBhZGQgdlBDSSBoYW5kbGVycw0KPj4+ICsgICAgICAgICAq
IHdoZW4gRG9tMCBmaXJzdCBpbmZvcm1zIFhlbiBhYm91dCBzdWNoIGRldmljZXMuDQo+Pj4gICAg
ICAgICAgKi8NCj4+PiAgICAgICAgIHJldCA9IHZwY2lfYWRkX2hhbmRsZXJzKHBkZXYpOw0KPj4+
ICAgICAgICAgaWYgKCByZXQgKQ0KPj4gDQo+PiBTb3JyeSB0byBiZSBhIHBhaW4sIGJ1dCBJIHRo
aW5rIHRoaXMgcGxhY2VtZW50IG9mIHRoZSBjYWxsIHRvDQo+PiB2cGNpX2FkZF9oYW5kbGVycyBp
cyBib2d1cyBhbmQgc2hvdWxkIGluc3RlYWQgYmUgZG9uZSBzdHJpY3RseSBhZnRlcg0KPj4gdGhl
IGRldmljZSBoYXMgYmVlbiBhZGRlZCB0byB0aGUgaGFyZHdhcmVfZG9tYWluLT5wZGV2X2xpc3Qg
bGlzdC4NCj4+IA0KPj4gT3RoZXJ3aXNlIHRoZSBsb29wIG92ZXIgZG9tYWluLT5wZGV2X2xpc3Qg
KGZvcl9lYWNoX3BkZXYpIGluDQo+PiBtb2RpZnlfYmFycyB3b24ndCBiZSBhYmxlIHRvIGZpbmQg
dGhlIGRldmljZSBhbmQgaGl0IHRoZSBhc3NlcnQgYmVsb3cNCj4+IGl0LiBUaGF0IGNhbiBoYXBw
ZW4gaW4gdnBjaV9hZGRfaGFuZGxlcnMgYXMgaXQgd2lsbCBjYWxsIGluaXRfYmFycw0KPj4gd2hp
Y2ggaW4gdHVybiB3aWxsIGNhbGwgaW50byBtb2RpZnlfYmFycyBpZiBtZW1vcnkgZGVjb2Rpbmcg
aXMgZW5hYmxlZA0KPj4gZm9yIHRoZSBkZXZpY2UuDQo+IA0KPiBPaCwgZ29vZCBwb2ludC4gQW5k
IEkgc2hvdWxkIGhhdmUgdGhvdWdodCBvZiB0aGlzIG15c2VsZiwgZ2l2ZW4gdGhhdA0KPiBJIGRp
ZCBoaXQgdGhhdCBBU1NFUlQoKSByZWNlbnRseSB3aXRoIGEgaGlkZGVuIGRldmljZS4gRlRBT0Qg
SSB0aGluaw0KPiB0aGlzIG1lYW5zIHRoYXQgdGhlIGxpc3QgYWRkaXRpb24gd2lsbCBuZWVkIHRv
IG1vdmUgdXAgKGFuZCB0aGVuDQo+IHdvdWxkIG5lZWQgdW5kb2luZyBvbiB0aGUgZXJyb3IgcGF0
aChzKSkuDQoNCkFncmVlLCBJIGp1c3QgbmVlZCB0byBtYWtlIHN1cmUgdGhhdCBjYWxsaW5nIGlv
bW11X2FkZF9kZXZpY2UgaXMgbm90DQppbXBhY3RlZCBieSB0aGlzLiBJdCBpcyBwcm9iYWJseSBu
b3QgYnV0IGEgY29uZmlybWF0aW9uIHdvdWxkIGJlIGdvb2QuDQoNCkp1c3QgdG8gY29uZmlybSwg
dGhpcyBzcGVjaWZpYyBjaGFuZ2Ugd291bGQgbG9vayBsaWtlIHRoYXQ6DQpkaWZmIC0tZ2l0IGEv
eGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvcGNpLmMgYi94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC9w
Y2kuYw0KaW5kZXggODkyOGExYzA3ZC4uMGQ4YWIyZTcxNiAxMDA2NDQNCi0tLSBhL3hlbi9kcml2
ZXJzL3Bhc3N0aHJvdWdoL3BjaS5jDQorKysgYi94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC9wY2ku
Yw0KQEAgLTc1Niw2ICs3NTYsOCBAQCBpbnQgcGNpX2FkZF9kZXZpY2UodTE2IHNlZywgdTggYnVz
LCB1OCBkZXZmbiwNCiAgICAgaWYgKCAhcGRldi0+ZG9tYWluICkNCiAgICAgew0KICAgICAgICAg
cGRldi0+ZG9tYWluID0gaGFyZHdhcmVfZG9tYWluOw0KKyAgICAgICAgbGlzdF9hZGQoJnBkZXYt
PmRvbWFpbl9saXN0LCAmaGFyZHdhcmVfZG9tYWluLT5wZGV2X2xpc3QpOw0KKw0KICAgICAgICAg
LyoNCiAgICAgICAgICAqIEZvciBkZXZpY2VzIG5vdCBkaXNjb3ZlcmVkIGJ5IFhlbiBkdXJpbmcg
Ym9vdCwgYWRkIHZQQ0kgaGFuZGxlcnMNCiAgICAgICAgICAqIHdoZW4gRG9tMCBmaXJzdCBpbmZv
cm1zIFhlbiBhYm91dCBzdWNoIGRldmljZXMuDQpAQCAtNzY0LDYgKzc2Niw3IEBAIGludCBwY2lf
YWRkX2RldmljZSh1MTYgc2VnLCB1OCBidXMsIHU4IGRldmZuLA0KICAgICAgICAgaWYgKCByZXQg
KQ0KICAgICAgICAgew0KICAgICAgICAgICAgIHByaW50ayhYRU5MT0dfRVJSICJTZXR1cCBvZiB2
UENJIGZhaWxlZDogJWRcbiIsIHJldCk7DQorICAgICAgICAgICAgbGlzdF9kZWwoJnBkZXYtPmRv
bWFpbl9saXN0KTsNCiAgICAgICAgICAgICBwZGV2LT5kb21haW4gPSBOVUxMOw0KICAgICAgICAg
ICAgIGdvdG8gb3V0Ow0KICAgICAgICAgfQ0KQEAgLTc3MSwxMSArNzc0LDEwIEBAIGludCBwY2lf
YWRkX2RldmljZSh1MTYgc2VnLCB1OCBidXMsIHU4IGRldmZuLA0KICAgICAgICAgaWYgKCByZXQg
KQ0KICAgICAgICAgew0KICAgICAgICAgICAgIHZwY2lfcmVtb3ZlX2RldmljZShwZGV2KTsNCisg
ICAgICAgICAgICBsaXN0X2RlbCgmcGRldi0+ZG9tYWluX2xpc3QpOw0KICAgICAgICAgICAgIHBk
ZXYtPmRvbWFpbiA9IE5VTEw7DQogICAgICAgICAgICAgZ290byBvdXQ7DQogICAgICAgICB9DQot
DQotICAgICAgICBsaXN0X2FkZCgmcGRldi0+ZG9tYWluX2xpc3QsICZoYXJkd2FyZV9kb21haW4t
PnBkZXZfbGlzdCk7DQogICAgIH0NCiAgICAgZWxzZQ0KDQoNCkNoZWVycw0KQmVydHJhbmQNCg0K
PiANCj4gSmFuDQo+IA0KPiANCg0K


From xen-devel-bounces@lists.xenproject.org Wed Oct 20 09:08:51 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Oct 2021 09:08:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.213722.372025 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1md7aQ-0008RV-By; Wed, 20 Oct 2021 09:08:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 213722.372025; Wed, 20 Oct 2021 09:08:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1md7aQ-0008RO-8V; Wed, 20 Oct 2021 09:08:38 +0000
Received: by outflank-mailman (input) for mailman id 213722;
 Wed, 20 Oct 2021 09:08:37 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ou1c=PI=citrix.com=roger.pau@srs-us1.protection.inumbo.net>)
 id 1md7aO-0008RI-Tl
 for xen-devel@lists.xenproject.org; Wed, 20 Oct 2021 09:08:37 +0000
Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 4dcd8d80-3185-11ec-8335-12813bfff9fa;
 Wed, 20 Oct 2021 09:08:35 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4dcd8d80-3185-11ec-8335-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1634720916;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=+kD6C60QGEDF9D8DiEac5gIDV8SSJIex7m80SY2DSno=;
  b=bKVFjIafrZpiWnf9sBPQojYwgHxpaDLPJW//RrIK+u24w4edEhBHMve5
   FcrKN13JQdyx7ZD/3favCALaBmotkxKQ4dET/ux9AYXPhyxQ79T0qQh4y
   vmwt5HyJbo4olvdGRdzr03ARvGgzxV5UPKY8fQAJTqN74EAw3bZP0uzz1
   c=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: JMEpAXFCPdjWN8+R0mz6xvZefkT4ZQniu1dfoHwsLc25yEI4ymwuXyJpjXmbb2M9BAqeyoEBp3
 abfV8H3lQ+6wmQaU/uhIlUTxFmEb91gxVxyZHXZwFsVOpuBW/Dt07Xunnhn40eLRf9ciUxB5ys
 t2q3CWaqdlU/3PwQJ7vOYtoMOAFNTbAb+HFzn9699NFiuHeA5j9a4VvN+I1Paqvr5Ms8TYx7oV
 kgAbq73iAxE1C0uKZQJ7wV0QXEtKISigpyc9U1AD20YVrIgjwBvAfgkZNjmyOmsqFzq3k0KOtd
 F3XxNtVmKmdu00zpu3QFsM6j
X-SBRS: 5.1
X-MesageID: 55645276
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:/Fc0Eax3Jxq/Cl0IQxl6t+cywCrEfRIJ4+MujC+fZmUNrF6WrkVUm
 DNLXTqEaKuCNDfzf4x1PorkoxgF7cCGm98xTgRrrCAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx
 59DAjUVBJlsFhcwnvopW1TYhSEUOZugH9IQM8aZfHAuLeNYYH1500s6w7Rh2tcAbeWRWGthh
 /uj+6UzB3f9s9JEGjp8B3Wr8U4HUFza4Vv0j3RmDRx5lAa2e0o9VfrzEZqZPXrgKrS4K8bhL
 wr1IBNVyUuCl/slIovNfr8W6STmSJaKVeSFoiI+t6RPHnGuD8H9u0o2HKN0VKtZt9mGt/9A6
 49RnMKbcg0OZqzMvMJBUgR/OQgraMWq+JefSZS+mcmazkmAeHrw2fR+SkoxOOX0+M4uXzsIr
 6ZBbmlQMFbT3Ipaw5riIgVort4kI8TxepsWp1lrzC3DDOZgSpfGK0nPzYIFgmtt3J8QdRrYT
 8UWVwg/NS/PWTwVFggMT6w6jMmmmECqJlW0r3rK/PFqsgA/1jdZ0qXpMdfTUsyHQ4NShEnwj
 nnd423zDxUeNdqe4TmI6HShgqnIhyyTcLwVELq05/t7mmq5z2YYCAAVfVajqPz/gUm7M/pHI
 lEQ0jojq+417kPDZsb5dw21pjiDpBF0c9haHvA+6QqN4rHJ+AvfDW8BJhZrZcY6rsYwSXoP3
 0WQgtLyLTV1tfueTnf13qeZq3a+NDYYKUcGZDQYVk0V7t/7uoYxgxnTCNF5H8adqdn4Gir5x
 TyQmwE4i68Ols4A16i9/lfvjiqlo97CSQtdzgTIXEq14wVhfomnaoe0r1/B4p59wJ2xFwfb+
 iJewo7Hsb5IXcrleDGxrPslM4CKveqsbhbni3k3HpkF0Wis5lmJVNUFiN1hH3tBPsEBcD7vR
 UbcvwJN+ZNeVEeXgb9Lj5GZUJtyk/CxfTjxfrWNNIAWO8kuHOOS1Hg2PRb44oz7rKQ7fUjT0
 7+gesGwEW1SN61jyDenLwv2+e52nn5grY8/qJaS8vhG7VZ8TCLKIVvmGAHXBgzc0E9iiF+Jm
 zq4H5DSoyizqMWkPkHqHXc7dDjm10QTC5HssNBwfeWeOAdgE2xJI6aPmu9/Jd09xfgNz76gE
 pSBtqlwkgaXaZrvcl3iV5yeQOm3AcYXQYwTbETAwmpEK1B8ON3yvc/zhrM8fKU99fwL8BKHZ
 6JtRil0OdwWEm6v021ENfHV9dU+HDz21VPmF3f0O1AXIs8/LzElD/e5J2MDAgFVVXHp3Sb/y
 pX9vj7mrW0rHVoyV5iINarzlTtcfxE1wYpPYqcBGfEKEG3E+4l2MS3hyPgxJsAHMxLYwTWGk
 Q2RBH8lSSPl+efZKfHF2vKJqZmHCex7EhYIFmXX9+/uZyLb4nCi0clLV+PRJWLRU2b9+aODY
 +RJzq6jbK1bzQgS64csQax2ya8e5sf0o+MIxApTA3iWPU+gDaltIyfa0JAX5LFN3LJQpSC/R
 lmLpotBIbyMNc68SAwRKQMpY/6tz/YRnjWOv/05LF+jvH18/aadUFUUNB6J0XQPILxwOYIj4
 OEgpM9JtFDv1kt0ao6L13kG+X6NI3oMV7QcmqsbWIK72BA2zlxiYIDHDnOk6p+4dNgRYFIhJ
 SWZhfSeiu0ElFbCaXc6CVPEwfFZ2cYVoBlPwVIPewaJl97CiqNl1RFd621qHAFczxEB2ONvI
 Gl7cUZyIPzWrTtvgcFCWUGqGh1AW0LFqhCglQNRmT2LVVSsW0zMMHY5aLSE800u+m5BeiRWo
 eODw2H/XDe2JMz800Peg6K+RyAPmTCpyjD/pQ==
IronPort-HdrOrdr: A9a23:+mT2dawXxuwU38kPA3c1KrPwKL1zdoMgy1knxilNoHtuA6ulfq
 GV7ZAmPHrP4wr5N0tNpTntAsa9qBDnlaKdg7N+AV7KZmCP0gaVxepZjLfK8nnNHDD/6/4Y9Y
 oISdkaNDQoNykYsS8t2njbL+od
X-IronPort-AV: E=Sophos;i="5.87,166,1631592000"; 
   d="scan'208";a="55645276"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=oTpq0jLqYTK09UK/oqs4hm+GNC88g22d0HbS+d2zeeGWX+L7i8GTSASVIhGaXzzLXhJkOrW7Net16M/emiSTNTmURxSPa3/3BvSvHgCTtYeGvR7v5L5msVAO5jXlJQirg0C2eoXll1QuOFxulCKhLwXfCLu4cAW8bnfoa6XBtwPc2X1T+9yBaFf8ij8+KNOF+rFKvxTGGtoikKVJCRu1NHa9Gen3JFw8cMIKIn9ytnAs6k6qT1uwpVPe2rY7JKz1lnOASqkYiXm+2mTDmkgSRNLM874fvH3tzmK6dZh2Hkql3lTxZdZIxPsKf4fpC0B5G5Hgye1UJ1PqV9EGtsbF3A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=qQysufxIcVu0sj5uW1EiE+Sir2oDSC3TjyAutGn7T0k=;
 b=fO1AIg2Eqk7EhaL6YlcOm24o72+3et5iAz/1Som3l0q+4pVmIk46d7ctBYpylwrBlyKXETjwsrxDZxwlnK2YByCfwU2oMe1lZpNSTWxlRT1M69jYNX8mtOqU4QNbnt37pCkCRb0LaSsE9nADDvm9vAfEVyH86mrOCAVzbuZu8npDZNIWflmCFgsmgjO7rKefylMAEdFitbc92ol/Mvx+njI58KYk+hm1FKKEFUeUZKfsI3Z3h+Xje/k4XUqKbpSl2wBpKyB+iyqfUDTgeZyDB5XvFG43ZhuEPzegpQPUZ4NQ9yA83kF3MA3lTSKsR3S7IIEmrweEYg76YE2SHrujTA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=qQysufxIcVu0sj5uW1EiE+Sir2oDSC3TjyAutGn7T0k=;
 b=KdCXFbPoK9Vzh9746WASNLXgh8eT+0Gjq0LoSrkOoFeJ/8U0Q90dpMpxn91fn6siAzDfQMTknyCIGwiX5hZNCPxLkRYUUXC+kdb5b64DxBQRJ9i1wSW5lb5TQUEotnY3+wjK32O5zHcVDIddRsQ0796/U0ejYzQS7EC3o3KOQrA=
Date: Wed, 20 Oct 2021 11:08:20 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Bertrand Marquis <Bertrand.Marquis@arm.com>
CC: Jan Beulich <jbeulich@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, "iwj@xenproject.org" <iwj@xenproject.org>,
	"Oleksandr_Andrushchenko@epam.com" <Oleksandr_Andrushchenko@epam.com>,
	Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, Andrew Cooper
	<andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>, Paul Durrant
	<paul@xen.org>
Subject: Re: [PATCH v2 1/1] xen/pci: Install vpci handlers on x86 and fix
 exit path
Message-ID: <YW/chLLoxhw+gyyH@MacBook-Air-de-Roger.local>
References: <cover.1634659471.git.bertrand.marquis@arm.com>
 <d788dcce9e344a39f6761633f0e96774ab42c2aa.1634659471.git.bertrand.marquis@arm.com>
 <YW/TBnjCuRjm64nB@MacBook-Air-de-Roger.local>
 <e8f35e24-8dbe-db2c-02fd-f2290648a25a@suse.com>
 <2FAC788E-1736-450C-B9B5-BDE93E32260E@arm.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <2FAC788E-1736-450C-B9B5-BDE93E32260E@arm.com>
X-ClientProxiedBy: LO2P265CA0251.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:8a::23) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 94183f59-2481-4972-8592-08d993a92bb3
X-MS-TrafficTypeDiagnostic: DS7PR03MB5590:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <DS7PR03MB5590956B71E183B0696C54708FBE9@DS7PR03MB5590.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: OgJWT1QoKZ93FUAtcNC6/ruzzlEgZ1Mruhe/bPgzOARJnwtUg1zDjsi1UJcbDvrcOduRsrwcOToJWoh3IFGoU5UiKv3vBMPxXIPpWbv9TddCYUKUMc24mrgHEjNnoU15eMj+VNoWUMyh05mlidO4HlPQZh3Dlnrou78keYFXrzfrDsiBSV/rT041DLEv9J1guJMMgYg1mmuHBGNzeyorziyQmNA/GJLAEDCClziS70vU7ZJpNKpeb/PIHlW08oE8E4SnvZ9SAqyGqDWHwR/AhMRp/gC6m5jIz3fBeqF6jakAqT2sXlNSi9KkM6diSbuYIDHkbEUBi0HGdF2Mbae4WDVB37VBWpKVUgErN6ODptTJVoV/Tv6vNHIXQs5LaCKZJF5rhybsTRClMcbSTXUg29hwqrLam3EGiY2HikhKXbRIqbqp+1XonQj0cXiAFrYJrXgk3nbCV/9euge4APEQwrD8qHsRtQkTg9qnTRbrh5d8rVp2cg3eJw3K2d2e56kVJzyNVwrpbxk2WidGtCf4i7VtH1DKfs1sG/yFHJ14qygj1MVL3ctqZS+BXY1BTy9Alq0lg/dRJpNaLkLVyBE68DWSYFtUcKuGx5sSHTlfkpkJg9AEU6P+vE+vJh1+w2BAJ5JcKq8D/9D4MWgVZw3rlg==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(9686003)(85182001)(38100700002)(82960400001)(6496006)(2906002)(6486002)(53546011)(54906003)(66946007)(83380400001)(66556008)(8676002)(66476007)(5660300002)(86362001)(7416002)(186003)(8936002)(956004)(316002)(508600001)(26005)(6916009)(4326008);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?enRBZGlvQW5Sc0VFWTZTUzZEemk4T1hsdno1U1pxcjFqYktyM2VDUVVGcldO?=
 =?utf-8?B?NzRiMXh4S2ZpcmxHeHFobXQwekpRUFZOblpnZkdzVDByaFovanRjWDhxc282?=
 =?utf-8?B?Q25DazA4VDFJcThrTUVWQXIwNS9ZNGJxNkpGUFBRYVJGSmFhQzhkc1RWWkpM?=
 =?utf-8?B?bmpWV3YvZkpiRkoreW9ERVZQY3dueWpJTHkvZCtYL0JyNlNMQVl2ZGlKcHFq?=
 =?utf-8?B?K3lmenFKYnVUeUV6R1hjSVp1WDA0WE1zSWNJWHV5VGJhTFdJYlNGTStkMm9h?=
 =?utf-8?B?NThER1p1VFphTkdUZVFMRlhEdDdwYkEvNytzakRGS3dvZ2lIV0U4USs5NDE3?=
 =?utf-8?B?MnJ3WWM2UEtlaitKYlZBTlROUkRRTUQ5Zk1UMnBOWXpJcWpPYnk2VFN5U2JI?=
 =?utf-8?B?UG9ndWxkMUF2cHNIQW5qR3FLdXpjU3ZHL0FOMnVobW93WVZxOUVWTXFoMmRi?=
 =?utf-8?B?Mk5hN0ZiZ0dyWnVOYTkwNStrTnphWFp0YUxaR1J4dEhRakczTVJzdnhrUTZL?=
 =?utf-8?B?WjJsSnNNczNVYkZKTTRLbHJON2FJNk1rWDlmcVN3TTNtNys2Mk1xbFY2WmhU?=
 =?utf-8?B?UU5vL0pkc0cveDhiTHJEMUtrVHZ1ZjliMHhONWdSbkVmSEtiZG5FYzQxNmZw?=
 =?utf-8?B?UUNVZmRCaU4ybEo5OUsvQk9vbWMySXZWTzlyM3Z5QzZkTkpSMmVGcUVvL05D?=
 =?utf-8?B?dk1FMExRdS91UXNuZWFrS1dEenlMeFNUMW9mNWRFRS9FTTRpeXA5L2VVRE5s?=
 =?utf-8?B?RWVDbkhHbDY4UnBTRDBHYnFGQW5VcXNFRnR5aHZFK0VQVFB4dEwyQk1WZHJN?=
 =?utf-8?B?eHdrTFpSNW9MZnhtdjRNMmNsMEZRaGhlY0NsbFh4eXBDb0NpVGVFcERQN2ZD?=
 =?utf-8?B?WVJKcmtnVDJEMktTbm9sNENLQnIyVk90UVViWEJtNWwxSGU1cDNoVytVUEZP?=
 =?utf-8?B?bXBjOW5hbFpOMUo4QW9WQkxhYkFZd2FMVWV0UGRkTFhhUHZCM2xGN2xOWDl5?=
 =?utf-8?B?a1dweVY2NzBVbzljMEUrMjdDeUxmTS9lQ0xINTNpZlhFb3NIK3I3bXhkcFBU?=
 =?utf-8?B?QTEyV1c5TnZTMXZUa0ErcWpMV0VpYXFaSG1MdmxMeTlvaGI5QUVyUWp2OS83?=
 =?utf-8?B?UlV2WGxjdCs2QTBUeXhuN2d3UHJQN1hyRm5VeGhRLzZDT20xN1dOc0VjbUZ3?=
 =?utf-8?B?dWhHUE1PdmtPUFM5aGJaZGVuYXQ1dEtLT2pSZm5YRGtKbmJ0dk9kSTRGS0dN?=
 =?utf-8?B?NXlMTXBLZ1locXRtaVpwQ1h3TlNmU0hSSWJPYUhNTGZzQzI4N1MrOGUxNnFH?=
 =?utf-8?B?a055L1JoaElJRktIK2NTNkZrZkw3clpWVjNMcTBkcVRYT1dFazdOb0ZlOXFD?=
 =?utf-8?B?MDB6a0lpWThnM2xPVjlmT0xXd2lpeWxNVTlhV0Vsc0lCWXpOcjQvMC83a2o5?=
 =?utf-8?B?YzQ3ZVFqbktZaVNxbjZ6cEg2UjRBMnpKR0ROWSsxSmN4MFU3azVTUEREU2xa?=
 =?utf-8?B?NVNrK1BCbzA5OWpwcENyRzBsUjV5bWhaN1JleHhRaTNnVENrTXBYL3RvcFBu?=
 =?utf-8?B?ZWp0dlUxWGdoTUZFV3J2RkQwblRoRzJqV1FPMGhJTlJNL2ErYUZIREdSdFB2?=
 =?utf-8?B?MUdVVk8yQWkwcWlUSWNrNFY2SVM0YW9TVmtlN1hJRTMrZk5YOVBUM25GbFpv?=
 =?utf-8?B?ekJlZEZSWFpSQlppaGFrc1Q2ZVl3ektwSjNTMlYvZkFCTlYxb2ljTFNNVk5n?=
 =?utf-8?Q?BL3J+UVLfPQPMGtHVtBUVaGpMKfVaWdsNzrtf7k?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 94183f59-2481-4972-8592-08d993a92bb3
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2021 09:08:24.2772
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: roger.pau@citrix.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR03MB5590
X-OriginatorOrg: citrix.com

On Wed, Oct 20, 2021 at 08:39:48AM +0000, Bertrand Marquis wrote:
> Hi,
> 
> > On 20 Oct 2021, at 09:34, Jan Beulich <jbeulich@suse.com> wrote:
> > 
> > On 20.10.2021 10:27, Roger Pau Monné wrote:
> >> On Tue, Oct 19, 2021 at 05:08:28PM +0100, Bertrand Marquis wrote:
> >>> Xen might not be able to discover at boot time all devices or some devices
> >>> might appear after specific actions from dom0.
> >>> In this case dom0 can use the PHYSDEVOP_pci_device_add to signal some
> >>> PCI devices to Xen.
> >>> As those devices where not known from Xen before, the vpci handlers must
> >>> be properly installed during pci_device_add for x86 PVH Dom0, in the
> >>> same way as what is done currently on arm (where Xen does not detect PCI
> >>> devices but relies on Dom0 to declare them all the time).
> >>> 
> >>> So this patch is removing the ifdef protecting the call to
> >>> vpci_add_handlers and the comment which was arm specific.
> >>> 
> >>> vpci_add_handlers is called on during pci_device_add which can be called
> >>> at runtime through hypercall physdev_op.
> >>> Remove __hwdom_init as the call is not limited anymore to hardware
> >>> domain init and fix linker script to only keep vpci_array in rodata
> >>> section.
> >>> 
> >>> Add missing vpci handlers cleanup during pci_device_remove and in case
> >>> of error with iommu during pci_device_add.
> >>> 
> >>> Add empty static inline for vpci_remove_device when CONFIG_VPCI is not
> >>> defined.
> >>> 
> >>> Fixes: d59168dc05 ("xen/arm: Enable the existing x86 virtual PCI support
> >>> for ARM")
> >>> Suggested-by: Jan Beulich <jbeulich@suse.com>
> >>> Signed-off-by: Bertrand Marquis <bertrand.marquis@arm.com>
> >>> ---
> >>> Changes in v2
> >>> - add comment suggested by Jan on top of vpci_add_handlers call
> >>> - merge the 3 patches of the serie in one patch and renamed it
> >>> - fix x86 and arm linker script to only keep vpci_array in rodata and
> >>> only when CONFIG_VPCI is set.
> >>> ---
> >>> xen/arch/arm/xen.lds.S        | 9 +--------
> >>> xen/arch/x86/xen.lds.S        | 9 +--------
> >>> xen/drivers/passthrough/pci.c | 8 ++++----
> >>> xen/drivers/vpci/vpci.c       | 2 +-
> >>> xen/include/xen/vpci.h        | 2 ++
> >>> 5 files changed, 9 insertions(+), 21 deletions(-)
> >>> 
> >>> diff --git a/xen/arch/arm/xen.lds.S b/xen/arch/arm/xen.lds.S
> >>> index b773f91f1c..08016948ab 100644
> >>> --- a/xen/arch/arm/xen.lds.S
> >>> +++ b/xen/arch/arm/xen.lds.S
> >>> @@ -60,7 +60,7 @@ SECTIONS
> >>>        *(.proc.info)
> >>>        __proc_info_end = .;
> >>> 
> >>> -#if defined(CONFIG_HAS_VPCI) && defined(CONFIG_LATE_HWDOM)
> >>> +#ifdef CONFIG_HAS_VPCI
> >>>        . = ALIGN(POINTER_ALIGN);
> >>>        __start_vpci_array = .;
> >>>        *(SORT(.data.vpci.*))
> >>> @@ -189,13 +189,6 @@ SECTIONS
> >>>        *(.init_array)
> >>>        *(SORT(.init_array.*))
> >>>        __ctors_end = .;
> >>> -
> >>> -#if defined(CONFIG_HAS_VPCI) && !defined(CONFIG_LATE_HWDOM)
> >>> -       . = ALIGN(POINTER_ALIGN);
> >>> -       __start_vpci_array = .;
> >>> -       *(SORT(.data.vpci.*))
> >>> -       __end_vpci_array = .;
> >>> -#endif
> >>>   } :text
> >>>   __init_end_efi = .;
> >>>   . = ALIGN(STACK_SIZE);
> >>> diff --git a/xen/arch/x86/xen.lds.S b/xen/arch/x86/xen.lds.S
> >>> index 11b1da2154..87e344d4dd 100644
> >>> --- a/xen/arch/x86/xen.lds.S
> >>> +++ b/xen/arch/x86/xen.lds.S
> >>> @@ -134,7 +134,7 @@ SECTIONS
> >>>        *(.ex_table.pre)
> >>>        __stop___pre_ex_table = .;
> >>> 
> >>> -#if defined(CONFIG_HAS_VPCI) && defined(CONFIG_LATE_HWDOM)
> >>> +#ifdef CONFIG_HAS_VPCI
> >>>        . = ALIGN(POINTER_ALIGN);
> >>>        __start_vpci_array = .;
> >>>        *(SORT(.data.vpci.*))
> >>> @@ -247,13 +247,6 @@ SECTIONS
> >>>        *(.init_array)
> >>>        *(SORT(.init_array.*))
> >>>        __ctors_end = .;
> >>> -
> >>> -#if defined(CONFIG_HAS_VPCI) && !defined(CONFIG_LATE_HWDOM)
> >>> -       . = ALIGN(POINTER_ALIGN);
> >>> -       __start_vpci_array = .;
> >>> -       *(SORT(.data.vpci.*))
> >>> -       __end_vpci_array = .;
> >>> -#endif
> >>>   } PHDR(text)
> >>> 
> >>>   . = ALIGN(SECTION_ALIGN);
> >>> diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci.c
> >>> index 35e0190796..8928a1c07d 100644
> >>> --- a/xen/drivers/passthrough/pci.c
> >>> +++ b/xen/drivers/passthrough/pci.c
> >>> @@ -756,10 +756,9 @@ int pci_add_device(u16 seg, u8 bus, u8 devfn,
> >>>     if ( !pdev->domain )
> >>>     {
> >>>         pdev->domain = hardware_domain;
> >>> -#ifdef CONFIG_ARM
> >>>         /*
> >>> -         * On ARM PCI devices discovery will be done by Dom0. Add vpci handler
> >>> -         * when Dom0 inform XEN to add the PCI devices in XEN.
> >>> +         * For devices not discovered by Xen during boot, add vPCI handlers
> >>> +         * when Dom0 first informs Xen about such devices.
> >>>          */
> >>>         ret = vpci_add_handlers(pdev);
> >>>         if ( ret )
> >> 
> >> Sorry to be a pain, but I think this placement of the call to
> >> vpci_add_handlers is bogus and should instead be done strictly after
> >> the device has been added to the hardware_domain->pdev_list list.
> >> 
> >> Otherwise the loop over domain->pdev_list (for_each_pdev) in
> >> modify_bars won't be able to find the device and hit the assert below
> >> it. That can happen in vpci_add_handlers as it will call init_bars
> >> which in turn will call into modify_bars if memory decoding is enabled
> >> for the device.
> > 
> > Oh, good point. And I should have thought of this myself, given that
> > I did hit that ASSERT() recently with a hidden device. FTAOD I think
> > this means that the list addition will need to move up (and then
> > would need undoing on the error path(s)).
> 
> Agree, I just need to make sure that calling iommu_add_device is not
> impacted by this. It is probably not but a confirmation would be good.

LGTM. I've been looking but I don't think there's a need to do
iommu_add_device before the call to vpci_add_handlers, so the proposed
solution is fine.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Wed Oct 20 09:21:18 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Oct 2021 09:21:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.213732.372037 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1md7ma-0002Hy-Ll; Wed, 20 Oct 2021 09:21:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 213732.372037; Wed, 20 Oct 2021 09:21:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1md7ma-0002Hr-Ht; Wed, 20 Oct 2021 09:21:12 +0000
Received: by outflank-mailman (input) for mailman id 213732;
 Wed, 20 Oct 2021 09:21:11 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=TQMG=PI=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1md7mZ-0002Hl-1r
 for xen-devel@lists.xenproject.org; Wed, 20 Oct 2021 09:21:11 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 5a8e4de9-a80f-48bf-829c-7a08ae891216;
 Wed, 20 Oct 2021 09:21:10 +0000 (UTC)
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur01lp2052.outbound.protection.outlook.com [104.47.2.52]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-14-mHyoR24VOZCxTnDe3c8uIg-1; Wed, 20 Oct 2021 11:21:07 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB5744.eurprd04.prod.outlook.com (2603:10a6:803:e4::24)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.17; Wed, 20 Oct
 2021 09:21:06 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.018; Wed, 20 Oct 2021
 09:21:06 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS8PR04CA0075.eurprd04.prod.outlook.com (2603:10a6:20b:313::20) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16 via Frontend
 Transport; Wed, 20 Oct 2021 09:21:05 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5a8e4de9-a80f-48bf-829c-7a08ae891216
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634721669;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=1bOH7D0Vr12oUgSW4c12x8+l1FgfTUA7vVKwzlJcBA4=;
	b=PYjmt9j86fymQkTOT2M+eoHokr0npfXeuYE0UYnMwgu6cTy/cTDAHztPnaLiwFStKt+qVg
	e09YXvzvVFmUFnMwfGA5NPt5pyZcIYlK58/eizxdQUXdmnWSy42ouKXKPUq30auocmWiaY
	gLQQiLDAtOlyDWpcXCpy9bjWfAcb6nc=
X-MC-Unique: mHyoR24VOZCxTnDe3c8uIg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=VGcXYMwFlV8I3Fsxrhk/PQXmvQgcTwtxb2eEckLwx6nHo197Euwd3ookFES04rW6oEqwJ3ulRdpH1M6xwnOEbpJAIRSZZcws7cNOugQvGA1alD2evLD3cipuN+Bl1D3E6Xm3SswAmHgDzhVzEaGr+WsmSxy902+HZt6rj5lZKuqUUlEZJ72jZPifw7Xv2qjahMFpeOiSJNaSViyG1oQYBDft+OI1LAx6pEVBzWcDbbl17YbnH76YX0AixelQULfPthA1LLZYWXIb2p76eaFyLzwRvR8SnOqN86VAqn33DpDqAB1CPiK5H0yHwPflGb5z+fDeYjJyiR06AnHdlorwNg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=3azQUSj5yepMktjk7EyDu/U6Qk7BV3LRMNQ74C5EkA0=;
 b=AyVyBitdVBi+XhMYVOpPMjYqn68WpsKAE7slyYDb0tl9P/CGNtEFMds67BHj8N57dH0ybJBBrhw4Gjo41/F+pkl57cndHXm0Gm+3exrsisAeHg/j4X7rwvPIYhSLDo0r2f230JCsac85gY5f9sdtDDOXVlqgpI6tYb1fbie4z2F6+VFBAWn6feNdtqV+Yhv+0Czs0V8xNgqW34FKAc174zxvZu++oi23f7oBjhs6FqrlOOQQZhFVRL0Qxv501V4+yJMPNGEYm64VoxZjDn1TpeFQVs2nmn1X/WxCrw/OVzJiMXmmUML/1DDZhHrZfndr7+xrg/FFtIzDckH3DFcu6w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: xen.org; dkim=none (message not signed)
 header.d=none;xen.org; dmarc=none action=none header.from=suse.com;
Subject: Re: [PATCH v2 1/1] xen/pci: Install vpci handlers on x86 and fix exit
 path
To: Bertrand Marquis <Bertrand.Marquis@arm.com>
CC: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 "iwj@xenproject.org" <iwj@xenproject.org>,
 "Oleksandr_Andrushchenko@epam.com" <Oleksandr_Andrushchenko@epam.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 Paul Durrant <paul@xen.org>
References: <cover.1634659471.git.bertrand.marquis@arm.com>
 <d788dcce9e344a39f6761633f0e96774ab42c2aa.1634659471.git.bertrand.marquis@arm.com>
 <YW/TBnjCuRjm64nB@MacBook-Air-de-Roger.local>
 <e8f35e24-8dbe-db2c-02fd-f2290648a25a@suse.com>
 <2FAC788E-1736-450C-B9B5-BDE93E32260E@arm.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <d58fdbaf-5535-0235-4919-099c12037d31@suse.com>
Date: Wed, 20 Oct 2021 11:21:03 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <2FAC788E-1736-450C-B9B5-BDE93E32260E@arm.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS8PR04CA0075.eurprd04.prod.outlook.com
 (2603:10a6:20b:313::20) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 407d2052-8dca-4851-f5bb-08d993aaf1ae
X-MS-TrafficTypeDiagnostic: VI1PR04MB5744:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB5744BE266839C60B0F700FD2B3BE9@VI1PR04MB5744.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	AjVcIVuk8qVTIwbVuH2Ownu2rf2Zg1aI8HappjXvO1EX+Ml+Cp66CIBnZoAOhrhxM0/RGHIPRkM42Vcm+M0M3IBmIgZ5vWUbzeAxg9YEyEVkDYz3H16wxxbEt39UvLFL35S43OiG/UUP2sEkX/DXUaeBAaD8DBVDCp+zfeWBu2B608SJab/WBzBHIcJ1m3PuuTECGPiDRGcOZwg5NcAnb5h4dbWCGbdh7wvcSlyVB31WlG+bp5mqNHuKzXvoy8Y9MnFlE9kqMiEWblLT3u4/YShag8vVApFaMLlG7clf5iJJApfaWeY2XhWecCAdGfVW+yTm4XkRGAM3pEc1LIBYfO0uk4pV5zE8cv3Sh/uiB92mq9Gt4jwXNRnItAj8SxsikFHlSOzFpOxbQ1QJziNoD/ZFnxLKtgmWPTA16wklDfeNm7kSBpQ6JJWraQWwRk2yE5+Iy1JxtRejfWe4DyV2hl8gGkll7QDteLxQCNsh6EtDkVPPLPPFGX4Lcg0z299HjBkgN3TlnAAmlx5pH8v0eCQU3umIEYU085T4a/V+eP17uNSQf6qS2k7A4DK99punvs0mCzHKEZlaViEbB4FYiO5OHk0m0bNtMgn4NSJvyouNkMcEHfAy83za++GgE8pEyPy1KffkVJpI2hXPteAJ2byrrhnxTMiRw4LPZe9NuEDZDbBAbNFETrhl269T8Uva2HZNnm7cOss5tjA4wQqYTh3fMxutjIlE+Y3akkRoSiRYidXvkq/xoygvwYhIZTG4
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(6916009)(508600001)(26005)(36756003)(86362001)(66946007)(186003)(5660300002)(31686004)(16576012)(8936002)(2616005)(2906002)(8676002)(66476007)(66556008)(6486002)(4326008)(53546011)(31696002)(316002)(956004)(7416002)(54906003)(38100700002)(83380400001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?VIwVvBbwINWs8Brovm+yqY3GdFoph+Uw9K9oASbUTznJnGgPbHbsI/RQ8XA1?=
 =?us-ascii?Q?yn17HDfRDXaggU0GIHfqyWOcGaIc3Xkr3k8FJ6AuC1GapM55zFgzcs2R9Ygg?=
 =?us-ascii?Q?zTcK4d7egwzs92RCvJub5zoD3JLxO7NrhcQ1xgXrjdOJplot1KaP5C3m65Jp?=
 =?us-ascii?Q?QXpcKJfxAGwZkAxYvsBcoM0/R5Lvje+YqFhZAwH6nPCy4oNxZFaJCdkkal8g?=
 =?us-ascii?Q?5CNHP5e/bonzS6coJPs5ZjEl8n4slBmmHJpYAWTFSTEuQqfq/7kTabrEp5YS?=
 =?us-ascii?Q?LL/1Nu4+IQ01gqXBma3VxquI8IhhmJozNhWBrqJzbTUpf1wnDWtVTYOqKIbB?=
 =?us-ascii?Q?5yDrAC0DcI6nf+OX2sKLBliG259cgCiRE60Vgmo0BpXLEZL5KsBHf/Na4EaD?=
 =?us-ascii?Q?w7+B2rp2UoinMyGbe/Qba8yDfaF0VClGioCOS1v7TmJhbCh1OwLVhOjjDQo1?=
 =?us-ascii?Q?dVSKxCraFGEH1pIERamAANvhsbehLIYmRoopNNhz0wo7jUASQ4aTkwbBL6VJ?=
 =?us-ascii?Q?VVYHGYmgsG0eyLdJGUk+jtOoyW7MsLzxCNuVxKHDquo8kR1UUEjd60b2J3WS?=
 =?us-ascii?Q?8/DfONCfnn7zHtk0vRJQmmULLUxZhogTfREW6G80frTeT7FUlVKIvhelx09C?=
 =?us-ascii?Q?R7oY5uBoNU9A3npNwqo8dqLqPhdrcMJ8kRgXEp6u4ZHvULU2RGKCs4FTGmw1?=
 =?us-ascii?Q?TCdffX1QLYmI1G8AStmxmgYG8MhRhfRo/dd0+QnUBmqikp2Lqejc4Q4BskVo?=
 =?us-ascii?Q?u5Gnx9aSR9bTtSEalOa7ecCREXGnoV82edIrJvK7j3+CoPIyQL527T0JTpel?=
 =?us-ascii?Q?wxXnNGw6rTqyOOKJB59KbjKCp8UmkGGjjm2naxmIE5NATP5auhTy+3golbj+?=
 =?us-ascii?Q?bAdj+sq1L3R559NxKvCfWiQmDgDkQvsFBw0COQ/CUlrxOZbv2WE+8mWp7oVA?=
 =?us-ascii?Q?7Hz4IECUrN3+bzYFyIcVHgRUzzVo6MeeBFkB6ptb/vNOHjcpuPUhkWncvKXV?=
 =?us-ascii?Q?Tdt24nyP0rhXTJbTN0/EfMcUhO84Q0ZD7VJWKtlojgXQ3bCVR5K61rrqSu27?=
 =?us-ascii?Q?WMpcIZGFYJ57UeTFvzcQUbBpnRGUlUukd8BcSGLhh7q+stzUKPwhghc+doSk?=
 =?us-ascii?Q?yVdn6uoDp67FMNegHwiqmoT+HpXd3At2bXwufyGwAX3ch2TDfGxf2xEOiT8L?=
 =?us-ascii?Q?LiBLgqZ6GFCF6rhlDWsqIFuvuYAcyN0VF7pCEVGWaGRXhFa0sWFPdxNCZyiI?=
 =?us-ascii?Q?cjZR2l2vuKTqg0mk1JlBmjKGjXSXZIUJ6leKNL2uoXEDWiAVGzNy7Qz2z1yS?=
 =?us-ascii?Q?ts0KQyQak/9NSmvJ5Y4XlepG?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 407d2052-8dca-4851-f5bb-08d993aaf1ae
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2021 09:21:05.9923
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jbeulich@suse.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5744

On 20.10.2021 10:39, Bertrand Marquis wrote:
>> On 20 Oct 2021, at 09:34, Jan Beulich <jbeulich@suse.com> wrote:
>> On 20.10.2021 10:27, Roger Pau Monn=C3=A9 wrote:
>>> On Tue, Oct 19, 2021 at 05:08:28PM +0100, Bertrand Marquis wrote:
>>>> --- a/xen/drivers/passthrough/pci.c
>>>> +++ b/xen/drivers/passthrough/pci.c
>>>> @@ -756,10 +756,9 @@ int pci_add_device(u16 seg, u8 bus, u8 devfn,
>>>>     if ( !pdev->domain )
>>>>     {
>>>>         pdev->domain =3D hardware_domain;
>>>> -#ifdef CONFIG_ARM
>>>>         /*
>>>> -         * On ARM PCI devices discovery will be done by Dom0. Add vpc=
i handler
>>>> -         * when Dom0 inform XEN to add the PCI devices in XEN.
>>>> +         * For devices not discovered by Xen during boot, add vPCI ha=
ndlers
>>>> +         * when Dom0 first informs Xen about such devices.
>>>>          */
>>>>         ret =3D vpci_add_handlers(pdev);
>>>>         if ( ret )
>>>
>>> Sorry to be a pain, but I think this placement of the call to
>>> vpci_add_handlers is bogus and should instead be done strictly after
>>> the device has been added to the hardware_domain->pdev_list list.
>>>
>>> Otherwise the loop over domain->pdev_list (for_each_pdev) in
>>> modify_bars won't be able to find the device and hit the assert below
>>> it. That can happen in vpci_add_handlers as it will call init_bars
>>> which in turn will call into modify_bars if memory decoding is enabled
>>> for the device.
>>
>> Oh, good point. And I should have thought of this myself, given that
>> I did hit that ASSERT() recently with a hidden device. FTAOD I think
>> this means that the list addition will need to move up (and then
>> would need undoing on the error path(s)).
>=20
> Agree, I just need to make sure that calling iommu_add_device is not
> impacted by this. It is probably not but a confirmation would be good.

Like Roger, I'm unaware of any issue there. It would be odd anyway for
that (or about anything) to have a "is [not] on list" check. And the
set of list iterations is pretty limited iirc.

Jan



From xen-devel-bounces@lists.xenproject.org Wed Oct 20 09:52:57 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Oct 2021 09:52:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.213740.372048 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1md8HB-0005S0-6T; Wed, 20 Oct 2021 09:52:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 213740.372048; Wed, 20 Oct 2021 09:52:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1md8HB-0005Rt-2R; Wed, 20 Oct 2021 09:52:49 +0000
Received: by outflank-mailman (input) for mailman id 213740;
 Wed, 20 Oct 2021 09:52:47 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1md8H9-0005Rh-7Q; Wed, 20 Oct 2021 09:52:47 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1md8H8-0001zh-VH; Wed, 20 Oct 2021 09:52:46 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1md8H8-0002kO-Mt; Wed, 20 Oct 2021 09:52:46 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1md8H8-0007gN-MP; Wed, 20 Oct 2021 09:52:46 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=Zu/6lJ7vqei28YRVIhefRMMUrAKMMJ/CtNcCBvNyhz4=; b=V0Sg5meEaOW4wjC0vPu9OS1+HW
	3AxPilxbq/UNpU8mqjx4w0Llfx7rwu2lRXAdZ6HitjGmHYTXY3mezjiM53OD2bNtUqYalwg/WsuyM
	PEWvL3JtjD4YVRpDYBd1WqgvZ1gzgvM/wOKZYYHUagLELSrcMlY7WbzeWx8Yj8VmTCBg=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165686-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-coverity test] 165686: all pass - PUSHED
X-Osstest-Versions-This:
    xen=6809998c5f8f1d2e26ac9e867af8ac71e7a66cf2
X-Osstest-Versions-That:
    xen=52d0847d7c6972baa74156f14ee8544f5aba1d2d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 20 Oct 2021 09:52:46 +0000

flight 165686 xen-unstable-coverity real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165686/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 xen                  6809998c5f8f1d2e26ac9e867af8ac71e7a66cf2
baseline version:
 xen                  52d0847d7c6972baa74156f14ee8544f5aba1d2d

Last test of basis   165617  2021-10-17 09:18:30 Z    3 days
Testing same since   165686  2021-10-20 09:20:50 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Ian Jackson <iwj@xenproject.org>
  Jan Beulich <jbeulich@suse.com>
  Juergen Gross <jgross@suse.com>
  Roger Pau Monné <roger.pau@citrix.com>

jobs:
 coverity-amd64                                               pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   52d0847d7c..6809998c5f  6809998c5f8f1d2e26ac9e867af8ac71e7a66cf2 -> coverity-tested/smoke


From xen-devel-bounces@lists.xenproject.org Wed Oct 20 09:56:33 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Oct 2021 09:56:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.213749.372062 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1md8Km-00066u-NX; Wed, 20 Oct 2021 09:56:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 213749.372062; Wed, 20 Oct 2021 09:56:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1md8Km-00066n-Jn; Wed, 20 Oct 2021 09:56:32 +0000
Received: by outflank-mailman (input) for mailman id 213749;
 Wed, 20 Oct 2021 09:56:31 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1md8Kl-00066c-G4; Wed, 20 Oct 2021 09:56:31 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1md8Kl-00023n-AR; Wed, 20 Oct 2021 09:56:31 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1md8Kl-0002rc-0x; Wed, 20 Oct 2021 09:56:31 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1md8Kl-0001fs-0J; Wed, 20 Oct 2021 09:56:31 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=kT2dz2LJteEyxnvP6FKdPSY4uJbV148W+iEMnUKGLnw=; b=njgA6kpolb0oAZIiTxvYatN5Dt
	tZcqA1p9tr7e8tArRAW5krY2wzu1pw6qMVVXtP3EXDIgtolud2SG40HsjPAfueRT5m1YB8NchtVx9
	Df1po9qEEE7bmvyQyjOjG/QerQ3nzD+q9ARL97SaKxTVX/66UEF/uf96nEYFrlOhgIkc=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165685-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 165685: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=37a33f02aa1ab89f392da7d06ec3578fda1b6182
X-Osstest-Versions-That:
    ovmf=90246a6d9f6fda3536d042d02867123caabe3aaa
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 20 Oct 2021 09:56:31 +0000

flight 165685 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165685/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 37a33f02aa1ab89f392da7d06ec3578fda1b6182
baseline version:
 ovmf                 90246a6d9f6fda3536d042d02867123caabe3aaa

Last test of basis   165671  2021-10-19 11:10:00 Z    0 days
Testing same since   165685  2021-10-20 07:11:17 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Jason Lou <yun.lou@intel.com>
  Lou, Yun <Yun.Lou@intel.com>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   90246a6d9f..37a33f02aa  37a33f02aa1ab89f392da7d06ec3578fda1b6182 -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Wed Oct 20 10:05:55 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Oct 2021 10:05:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.213759.372076 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1md8Tn-0007dl-KL; Wed, 20 Oct 2021 10:05:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 213759.372076; Wed, 20 Oct 2021 10:05:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1md8Tn-0007de-Gx; Wed, 20 Oct 2021 10:05:51 +0000
Received: by outflank-mailman (input) for mailman id 213759;
 Wed, 20 Oct 2021 10:05:50 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=faDG=PI=arm.com=bertrand.marquis@srs-us1.protection.inumbo.net>)
 id 1md8Tm-0007dY-OL
 for xen-devel@lists.xenproject.org; Wed, 20 Oct 2021 10:05:50 +0000
Received: from foss.arm.com (unknown [217.140.110.172])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTP
 id 4d65871e-318d-11ec-8336-12813bfff9fa;
 Wed, 20 Oct 2021 10:05:50 +0000 (UTC)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C5A59ED1;
 Wed, 20 Oct 2021 03:05:49 -0700 (PDT)
Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com
 [10.1.199.62])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 423B03F70D;
 Wed, 20 Oct 2021 03:05:48 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4d65871e-318d-11ec-8336-12813bfff9fa
From: Bertrand Marquis <bertrand.marquis@arm.com>
To: xen-devel@lists.xenproject.org
Cc: iwj@xenproject.org,
	Oleksandr_Andrushchenko@epam.com,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	Wei Liu <wl@xen.org>,
	Paul Durrant <paul@xen.org>
Subject: [PATCH v3 0/1] Fixes: PCI devices passthrough on Arm
Date: Wed, 20 Oct 2021 11:05:36 +0100
Message-Id: <cover.1634723903.git.bertrand.marquis@arm.com>
X-Mailer: git-send-email 2.25.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

This patch serie is a follow-up after various findings on d59168dc05
("xen/arm: Enable the existing x86 virtual PCI support for ARM") as of
agreed in [1].

It does the following:
- enable vpci_add_handlers on x86 and not only on arm
- remove __hwdom_init flag for vpci_add_handlers
- add missing vpci handler cleanup in error path during pci_device_add
  and pci_device_remove

[1] https://marc.info/?l=xen-devel&m=163455502020100&w=2

In the second version of the serie, the 3 patches have been merged into
one single patch.

Bertrand Marquis (1):
  xen/pci: Install vpci handlers on x86 and fix error paths

 xen/arch/arm/xen.lds.S        |  9 +--------
 xen/arch/x86/xen.lds.S        |  9 +--------
 xen/drivers/passthrough/pci.c | 14 ++++++++------
 xen/drivers/vpci/vpci.c       |  8 +++++++-
 xen/include/xen/vpci.h        |  2 ++
 5 files changed, 19 insertions(+), 23 deletions(-)

-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Wed Oct 20 10:05:55 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Oct 2021 10:05:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.213760.372087 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1md8Tq-0007uG-Rs; Wed, 20 Oct 2021 10:05:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 213760.372087; Wed, 20 Oct 2021 10:05:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1md8Tq-0007u9-Oh; Wed, 20 Oct 2021 10:05:54 +0000
Received: by outflank-mailman (input) for mailman id 213760;
 Wed, 20 Oct 2021 10:05:52 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=faDG=PI=arm.com=bertrand.marquis@srs-us1.protection.inumbo.net>)
 id 1md8To-0007sq-Ox
 for xen-devel@lists.xenproject.org; Wed, 20 Oct 2021 10:05:52 +0000
Received: from foss.arm.com (unknown [217.140.110.172])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTP
 id c43af9f5-e5cc-4bd9-91d2-639f0220f85b;
 Wed, 20 Oct 2021 10:05:51 +0000 (UTC)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8BB1F106F;
 Wed, 20 Oct 2021 03:05:51 -0700 (PDT)
Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com
 [10.1.199.62])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 088FA3F70D;
 Wed, 20 Oct 2021 03:05:49 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c43af9f5-e5cc-4bd9-91d2-639f0220f85b
From: Bertrand Marquis <bertrand.marquis@arm.com>
To: xen-devel@lists.xenproject.org
Cc: iwj@xenproject.org,
	Oleksandr_Andrushchenko@epam.com,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	Wei Liu <wl@xen.org>,
	Paul Durrant <paul@xen.org>
Subject: [PATCH v3 1/1] xen/pci: Install vpci handlers on x86 and fix error paths
Date: Wed, 20 Oct 2021 11:05:37 +0100
Message-Id: <c82cc9c933e09806c9d043c61d92bd793060f9ab.1634723903.git.bertrand.marquis@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <cover.1634723903.git.bertrand.marquis@arm.com>
References: <cover.1634723903.git.bertrand.marquis@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Xen might not be able to discover at boot time all devices or some devices
might appear after specific actions from dom0.
In this case dom0 can use the PHYSDEVOP_pci_device_add to signal some
PCI devices to Xen.
As those devices where not known from Xen before, the vpci handlers must
be properly installed during pci_device_add for x86 PVH Dom0, in the
same way as what is done currently on arm (where Xen does not detect PCI
devices but relies on Dom0 to declare them all the time).

So this patch is removing the ifdef protecting the call to
vpci_add_handlers and the comment which was arm specific.

vpci_add_handlers is called on during pci_device_add which can be called
at runtime through hypercall physdev_op.
Remove __hwdom_init as the call is not limited anymore to hardware
domain init and fix linker script to only keep vpci_array in rodata
section.

Add missing vpci handlers cleanup during pci_device_remove and in case
of error with iommu during pci_device_add.

Move code adding the domain to the pdev domain_list as vpci_add_handlers
needs this to be set and remove it from the list in the error path.

Exit early of vpci_remove_device if the domain has no vpci support.

Add empty static inline for vpci_remove_device when CONFIG_VPCI is not
defined.

Add an ASSERT in vpci_add_handlers to check that the function is not
called twice for the same device.

Fixes: d59168dc05 ("xen/arm: Enable the existing x86 virtual PCI support
for ARM")
Suggested-by: Jan Beulich <jbeulich@suse.com>
Signed-off-by: Bertrand Marquis <bertrand.marquis@arm.com>
---
Changes in v3
- change title (s/exit/error/ and s/path/paths)
- add early exit in vpci_remove_device if the domain has no vpci support
- add ASSERT in vpci_add_handlers to check that the call is only made
once per device
- move the call adding the domain in the pdev domain list and remove it
in the error path
Changes in v2
- add comment suggested by Jan on top of vpci_add_handlers call
- merge the 3 patches of the serie in one patch and renamed it
- fix x86 and arm linker script to only keep vpci_array in rodata and
only when CONFIG_VPCI is set.
---
 xen/arch/arm/xen.lds.S        |  9 +--------
 xen/arch/x86/xen.lds.S        |  9 +--------
 xen/drivers/passthrough/pci.c | 14 ++++++++------
 xen/drivers/vpci/vpci.c       |  8 +++++++-
 xen/include/xen/vpci.h        |  2 ++
 5 files changed, 19 insertions(+), 23 deletions(-)

diff --git a/xen/arch/arm/xen.lds.S b/xen/arch/arm/xen.lds.S
index b773f91f1c..08016948ab 100644
--- a/xen/arch/arm/xen.lds.S
+++ b/xen/arch/arm/xen.lds.S
@@ -60,7 +60,7 @@ SECTIONS
        *(.proc.info)
        __proc_info_end = .;
 
-#if defined(CONFIG_HAS_VPCI) && defined(CONFIG_LATE_HWDOM)
+#ifdef CONFIG_HAS_VPCI
        . = ALIGN(POINTER_ALIGN);
        __start_vpci_array = .;
        *(SORT(.data.vpci.*))
@@ -189,13 +189,6 @@ SECTIONS
        *(.init_array)
        *(SORT(.init_array.*))
        __ctors_end = .;
-
-#if defined(CONFIG_HAS_VPCI) && !defined(CONFIG_LATE_HWDOM)
-       . = ALIGN(POINTER_ALIGN);
-       __start_vpci_array = .;
-       *(SORT(.data.vpci.*))
-       __end_vpci_array = .;
-#endif
   } :text
   __init_end_efi = .;
   . = ALIGN(STACK_SIZE);
diff --git a/xen/arch/x86/xen.lds.S b/xen/arch/x86/xen.lds.S
index 11b1da2154..87e344d4dd 100644
--- a/xen/arch/x86/xen.lds.S
+++ b/xen/arch/x86/xen.lds.S
@@ -134,7 +134,7 @@ SECTIONS
        *(.ex_table.pre)
        __stop___pre_ex_table = .;
 
-#if defined(CONFIG_HAS_VPCI) && defined(CONFIG_LATE_HWDOM)
+#ifdef CONFIG_HAS_VPCI
        . = ALIGN(POINTER_ALIGN);
        __start_vpci_array = .;
        *(SORT(.data.vpci.*))
@@ -247,13 +247,6 @@ SECTIONS
        *(.init_array)
        *(SORT(.init_array.*))
        __ctors_end = .;
-
-#if defined(CONFIG_HAS_VPCI) && !defined(CONFIG_LATE_HWDOM)
-       . = ALIGN(POINTER_ALIGN);
-       __start_vpci_array = .;
-       *(SORT(.data.vpci.*))
-       __end_vpci_array = .;
-#endif
   } PHDR(text)
 
   . = ALIGN(SECTION_ALIGN);
diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci.c
index 35e0190796..0d8ab2e716 100644
--- a/xen/drivers/passthrough/pci.c
+++ b/xen/drivers/passthrough/pci.c
@@ -756,27 +756,28 @@ int pci_add_device(u16 seg, u8 bus, u8 devfn,
     if ( !pdev->domain )
     {
         pdev->domain = hardware_domain;
-#ifdef CONFIG_ARM
+        list_add(&pdev->domain_list, &hardware_domain->pdev_list);
+
         /*
-         * On ARM PCI devices discovery will be done by Dom0. Add vpci handler
-         * when Dom0 inform XEN to add the PCI devices in XEN.
+         * For devices not discovered by Xen during boot, add vPCI handlers
+         * when Dom0 first informs Xen about such devices.
          */
         ret = vpci_add_handlers(pdev);
         if ( ret )
         {
             printk(XENLOG_ERR "Setup of vPCI failed: %d\n", ret);
+            list_del(&pdev->domain_list);
             pdev->domain = NULL;
             goto out;
         }
-#endif
         ret = iommu_add_device(pdev);
         if ( ret )
         {
+            vpci_remove_device(pdev);
+            list_del(&pdev->domain_list);
             pdev->domain = NULL;
             goto out;
         }
-
-        list_add(&pdev->domain_list, &hardware_domain->pdev_list);
     }
     else
         iommu_enable_device(pdev);
@@ -819,6 +820,7 @@ int pci_remove_device(u16 seg, u8 bus, u8 devfn)
     list_for_each_entry ( pdev, &pseg->alldevs_list, alldevs_list )
         if ( pdev->bus == bus && pdev->devfn == devfn )
         {
+            vpci_remove_device(pdev);
             pci_cleanup_msi(pdev);
             ret = iommu_remove_device(pdev);
             if ( pdev->domain )
diff --git a/xen/drivers/vpci/vpci.c b/xen/drivers/vpci/vpci.c
index decf7d87a1..657697fe34 100644
--- a/xen/drivers/vpci/vpci.c
+++ b/xen/drivers/vpci/vpci.c
@@ -37,6 +37,9 @@ extern vpci_register_init_t *const __end_vpci_array[];
 
 void vpci_remove_device(struct pci_dev *pdev)
 {
+    if ( !has_vpci(pdev->domain) )
+        return;
+
     spin_lock(&pdev->vpci->lock);
     while ( !list_empty(&pdev->vpci->handlers) )
     {
@@ -54,7 +57,7 @@ void vpci_remove_device(struct pci_dev *pdev)
     pdev->vpci = NULL;
 }
 
-int __hwdom_init vpci_add_handlers(struct pci_dev *pdev)
+int vpci_add_handlers(struct pci_dev *pdev)
 {
     unsigned int i;
     int rc = 0;
@@ -62,6 +65,9 @@ int __hwdom_init vpci_add_handlers(struct pci_dev *pdev)
     if ( !has_vpci(pdev->domain) )
         return 0;
 
+    /* We should not get here twice for the same device. */
+    ASSERT(!pdev->vpci);
+
     pdev->vpci = xzalloc(struct vpci);
     if ( !pdev->vpci )
         return -ENOMEM;
diff --git a/xen/include/xen/vpci.h b/xen/include/xen/vpci.h
index 6746c2589a..9ea66e033f 100644
--- a/xen/include/xen/vpci.h
+++ b/xen/include/xen/vpci.h
@@ -230,6 +230,8 @@ static inline int vpci_add_handlers(struct pci_dev *pdev)
     return 0;
 }
 
+static inline void vpci_remove_device(struct pci_dev *pdev) { }
+
 static inline void vpci_dump_msi(void) { }
 
 static inline uint32_t vpci_read(pci_sbdf_t sbdf, unsigned int reg,
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Wed Oct 20 10:10:59 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Oct 2021 10:10:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.213776.372098 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1md8Ya-0001G0-J9; Wed, 20 Oct 2021 10:10:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 213776.372098; Wed, 20 Oct 2021 10:10:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1md8Ya-0001Ft-FD; Wed, 20 Oct 2021 10:10:48 +0000
Received: by outflank-mailman (input) for mailman id 213776;
 Wed, 20 Oct 2021 10:10:48 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=MOn5=PI=arm.com=Hongda.Deng@srs-us1.protection.inumbo.net>)
 id 1md8YZ-0001Fn-S3
 for xen-devel@lists.xenproject.org; Wed, 20 Oct 2021 10:10:48 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com (unknown
 [40.107.21.63]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 4a3c7332-bf90-4079-bea1-394b53564784;
 Wed, 20 Oct 2021 10:10:44 +0000 (UTC)
Received: from AS9PR04CA0058.eurprd04.prod.outlook.com (2603:10a6:20b:46a::23)
 by DBBPR08MB6105.eurprd08.prod.outlook.com (2603:10a6:10:20d::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16; Wed, 20 Oct
 2021 10:10:42 +0000
Received: from VE1EUR03FT031.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:46a:cafe::e5) by AS9PR04CA0058.outlook.office365.com
 (2603:10a6:20b:46a::23) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.16 via Frontend
 Transport; Wed, 20 Oct 2021 10:10:42 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT031.mail.protection.outlook.com (10.152.18.69) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.15 via Frontend Transport; Wed, 20 Oct 2021 10:10:41 +0000
Received: ("Tessian outbound 8e26f7114b75:v103");
 Wed, 20 Oct 2021 10:10:41 +0000
Received: from 0a7e79187a79.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 CEC86D9F-CB6D-4F6C-89CE-056E4C97ADFA.1; 
 Wed, 20 Oct 2021 10:10:35 +0000
Received: from EUR01-VE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 0a7e79187a79.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Wed, 20 Oct 2021 10:10:35 +0000
Received: from AM6PR08CA0004.eurprd08.prod.outlook.com (2603:10a6:20b:b2::16)
 by HE1PR0801MB2091.eurprd08.prod.outlook.com (2603:10a6:3:51::15)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.17; Wed, 20 Oct
 2021 10:10:33 +0000
Received: from AM5EUR03FT039.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:b2:cafe::c4) by AM6PR08CA0004.outlook.office365.com
 (2603:10a6:20b:b2::16) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.16 via Frontend
 Transport; Wed, 20 Oct 2021 10:10:33 +0000
Received: from nebula.arm.com (40.67.248.234) by
 AM5EUR03FT039.mail.protection.outlook.com (10.152.17.185) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.4608.15 via Frontend Transport; Wed, 20 Oct 2021 10:10:32 +0000
Received: from AZ-NEU-EX03.Arm.com (10.251.24.31) by AZ-NEU-EX03.Arm.com
 (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.14; Wed, 20 Oct
 2021 10:10:31 +0000
Received: from hongda-OptiPlex-7070.shanghai.arm.com (10.169.190.17) by
 mail.arm.com (10.251.24.31) with Microsoft SMTP Server id 15.1.2308.14 via
 Frontend Transport; Wed, 20 Oct 2021 10:10:29 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4a3c7332-bf90-4079-bea1-394b53564784
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=WDANhBkc8QVomqkcXiK4L7RcGe5Epnl8Ui8zqFtlpS0=;
 b=5cktR1FRD/cYJ8lkrgYX8RwaEoelCobwvl35mjArdxJnJU1k5jv1dwQNRlOb3753M8xibPtkUYshPmDkBXqOGDXixijVEEijAcEs6DqSDqHHLZ7/651eajfk2cmEDZw8xUu+6rl11+LmhbMjM4g2lwZKn7l7EUKQv73z4+M7abk=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 10458c9cf0127461
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Xq6jn29Qe3uNyaOJlVfdZ2SArrEmqocEZIEom+oUO0rgFwmaKotEk21yHzylTEFcMoDZUIDrTjQkQaaIHF1EapUSH4jbTD9XCrSPVxpkSHNXzM4H2kazRwni/Qg/dlEk/sDN1GY9xldpigF6Wi+wQAAT0Li7YMz6dzfEpxplrnEc4+Gph04hDY66zfKDy2tI/6Jeiwyk1P3trwEqBHDjzNpt6NotZTIFiEE/W0d/ZnE4XP6zWBUSCg1gH9NzJyOXuoRkO7j1QMBjmmfxlDoeSZY1wPuSp1o6/hUVylleDZs8hrX79falVyre3w4LdnCAqPkq3k4V04+JTVIyBc42dQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=WDANhBkc8QVomqkcXiK4L7RcGe5Epnl8Ui8zqFtlpS0=;
 b=bNUoF2Wum/p/0KBqexyk1y7SgrSyovMExdI9KBW4XQCEzV31K3qmh+sFu5GdZZiv1d7se8q40uzcYNAr2EJtiJtHvrnFnmwlKZ6nFuDMugVi5qdxVKYSaZpVu+joZ7ASQhbsJlcFLxpvmasxV74rkuQZ1NGaLqRTCqjiL8/Exo1selmbtJDXqwJ/pvuSSPgcH6E090EQvCKz+q03Z0rg43ylA9NoA+TNLNfhPA1EW09HvS3IOZv1bMgTPN1Yh7XYwblQLnvcuDYWn6cT/ZT8XLb+TeVb1hRTRk9g07JTgKLpBo/AWVoD7IYQ3/iUxG3USkfiKT5mclIyF8nobQjeGw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=WDANhBkc8QVomqkcXiK4L7RcGe5Epnl8Ui8zqFtlpS0=;
 b=5cktR1FRD/cYJ8lkrgYX8RwaEoelCobwvl35mjArdxJnJU1k5jv1dwQNRlOb3753M8xibPtkUYshPmDkBXqOGDXixijVEEijAcEs6DqSDqHHLZ7/651eajfk2cmEDZw8xUu+6rl11+LmhbMjM4g2lwZKn7l7EUKQv73z4+M7abk=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=pass action=none
 header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 40.67.248.234 as permitted sender) receiver=protection.outlook.com;
 client-ip=40.67.248.234; helo=nebula.arm.com;
From: Hongda Deng <Hongda.Deng@arm.com>
To: <xen-devel@lists.xenproject.org>, <sstabellini@kernel.org>,
	<julien@xen.org>
CC: <Bertrand.Marquis@arm.com>, <Wei.Chen@arm.com>, <Hongda.Deng@arm.com>
Subject: [PATCH v3] xen/arm: vgic to ignore GICD ICPENDRn registers access
Date: Wed, 20 Oct 2021 18:10:21 +0800
Message-ID: <20211020101021.9793-1-Hongda.Deng@arm.com>
X-Mailer: git-send-email 2.17.1
MIME-Version: 1.0
Content-Type: text/plain
X-EOPAttributedMessage: 1
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: b3526b82-e820-41ad-0b7c-08d993b1df78
X-MS-TrafficTypeDiagnostic: HE1PR0801MB2091:|DBBPR08MB6105:
X-Microsoft-Antispam-PRVS:
	<DBBPR08MB61058BEF30EB3624FAE35CA1E6BE9@DBBPR08MB6105.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Oob-TLC-OOBClassifiers: OLM:4941;OLM:4941;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 5H0WkS0ajXlOvtauoU/cCbpztD3V/99oL3j+RqxFQ49H9hbd/2vsM9JRK/tQTdysaOtqkLJfXTAa9ZAgXTilo/qkQkzVFQPk/1fHkrmHd+2wPgOSyeQ7eSgUIRR8KDOIFYsWZS2tJXjPSII/70srQ+2BYWEGDi+xSB6y0fskJRQeI2bTh50MPFEW5T6XDziQOfI+dnrbPNzQ981JKoURnRnXklhD4JxsPhJ1A3bh1YYSowhA/Q+QbFwmjaUR8z+UYhqHgU+PVvvHUV84zKI5EX7zdRV+0wwJ81n9gA8ol0r44v5PW5wsHvtkV9LBNimi9zTogYFE23s3el1MPGg8t95kZR4N2JjUbaB50iOqNBPrIhLh1NwII8kmqvN4bkGbCQWJ72XbQ6rLiFRrY+FDJNYnoyHTY4VCrHvNNjdkoXxHdrpkmzPA3nFwDG3zXpT9qHBP1dZK69Flnx5dZ42dRKGWOS9ArEeWrEDxLuD+FC+ZA3lpsO1LM2X4A+HJ+eJJt5i4oXvf4xVfOGxwfDvBbBhRqDUvEn4/cBya28hSJcJjSclJnBC4QuqluaPkwSSL+OkYkUZNtwS6G07bQi54k0v9JYBvpao3S+2qlwyEjE85jxL2H3H2eEdYDcMB2knhsFzyCILPn2E+gRypYyxm01rjVMeuk1oa7E5zG1WZFNULc6Sw2Zk/UrxkU9yL3fczwXd8M+XwncfpWAWJ4WIkmhG/uYr8fWcYl2N1+xmPhta2e7R16BpwnBYS3L52ER+JY676px/2h0Mcd69c/hH5quYEOAopm93W67NLAvICYfg7KEtyZb+T2YlZKbFvkj0P
X-Forefront-Antispam-Report-Untrusted:
 CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(5660300002)(70586007)(70206006)(186003)(26005)(7696005)(110136005)(6666004)(966005)(54906003)(508600001)(86362001)(36756003)(8936002)(316002)(1076003)(2616005)(426003)(8676002)(81166007)(4326008)(356005)(83380400001)(82310400003)(36860700001)(2906002)(47076005)(336012)(36900700001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0801MB2091
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT031.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	b1d089a1-72d6-4c44-5e0a-08d993b1da07
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	ozfNYeKkboAcp1XSHua6lV7jQDlrc3ohJou0/GhSMK2SbZsyiTJS9ZuFsb7DVtQSBw0t3j1ALA7o732HYnwosOur5SHKPhXLADWL4bENO3DjnuGBfD3K6aVJvTXqvYK31tXZAxYJgsHTjnNR9Hm9iD0x+VjVcyQGdnfHFu0waynD0PSoHRdS+6eE8M9sc0PSl+WyBD6XRr1c4JpGPPI+zFPEB7UTvDBRt0zJdjhcjGAW1XaCts5+jXHc99Gk70VaIJMY5jVIlZLVSOLHUzPfY7Je9f6I5JiXiqQADITYH4qbxH47gWOR+6sA7mgbeYdm21ziziI5OSEGByg4y4T78NIClUanOoUN7e9Ba48kHCqjdyiQOuvNrRSrozkFE/J0yp2GbNcla7DmHFiUPStWbt7Hy2RM5NY7e/Dnjrd5U05E1fONSZzik0S2SNJ/n+VPzLUpAM8E9nUzosIM2oNH/VOM3IepT2Ztvx0D+BhxhX8ju3TEREeOOe2ni5RIDbLplCy5RAWyL4yUDNC3yS+qBQchSoaTXvzYuYTM/TRdNgBCLFQret08q8+csPXNp8JpLsWqXPTHksBCt9zqic79PPPw4G7KKpFlFvnSzArIlKCLPROZ7a0KbossfrmMnVm429SUEIRKREbtCvAVl+6liLdV7kvCyPK93pPUkGlVUUluj1Zm7AQ1zJvms3/eq58yhUcTSTSb6QGldZ5/VUQgjhPdnQLrMM4o8KPxY9qeJ4Q1f2uR+e1ADfsISCcl/hEPxV9oKiaiUvtomFbcDNJ3MM6r882WM8BaBn6EJ3Zynmw=
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(83380400001)(8676002)(26005)(81166007)(70586007)(36860700001)(110136005)(336012)(316002)(54906003)(1076003)(186003)(4326008)(86362001)(8936002)(2616005)(426003)(966005)(7696005)(508600001)(6666004)(70206006)(47076005)(2906002)(82310400003)(5660300002)(36756003);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2021 10:10:41.6247
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: b3526b82-e820-41ad-0b7c-08d993b1df78
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT031.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB6105

Currently, Xen will return IO unhandled when guests access GICD ICPENRn
registers. This will raise a data abort inside guest. For Linux Guest,
these virtual registers will not be accessed. But for Zephyr, in its
GIC initialization code, these virtual registers will be accessed. And
zephyr guest will get an IO data abort in initilization stage and enter
fatal error. Emulating ICPENDR is not easy with the existing vGIC, so
we currently ignore these virtual registers access and print a message
about whether they are already pending instead of returning unhandled.
More details can be found at [1].

[1] https://github.com/zephyrproject-rtos/zephyr/blob/eaf6cf745df3807e6e
cc941c3a30de6c179ae359/drivers/interrupt_controller/intc_gicv3.c#L274

Signed-off-by: Hongda Deng <hongda.deng@arm.com>
---
Changes since v2:
 *  Avoid to print messages when there is no pending interrupt
 *  Add helper vgic_check_inflight_irqs_pending to check pending status
 *  Print a message for each interrupt separately
Changes since v1:
 *  Check pending states by going through vcpu->arch.vgic.inflight_irqs
    instead of checking hardware registers
---
 xen/arch/arm/vgic-v2.c     | 10 ++++++----
 xen/arch/arm/vgic-v3.c     | 16 ++++++++--------
 xen/arch/arm/vgic.c        | 36 ++++++++++++++++++++++++++++++++++++
 xen/include/asm-arm/vgic.h |  3 ++-
 4 files changed, 52 insertions(+), 13 deletions(-)

diff --git a/xen/arch/arm/vgic-v2.c b/xen/arch/arm/vgic-v2.c
index b2da886adc..7c30da327c 100644
--- a/xen/arch/arm/vgic-v2.c
+++ b/xen/arch/arm/vgic-v2.c
@@ -481,10 +481,12 @@ static int vgic_v2_distr_mmio_write(struct vcpu *v, mmio_info_t *info,
 
     case VRANGE32(GICD_ICPENDR, GICD_ICPENDRN):
         if ( dabt.size != DABT_WORD ) goto bad_width;
-        printk(XENLOG_G_ERR
-               "%pv: vGICD: unhandled word write %#"PRIregister" to ICPENDR%d\n",
-               v, r, gicd_reg - GICD_ICPENDR);
-        return 0;
+        rank = vgic_rank_offset(v, 1, gicd_reg - GICD_ICPENDR, DABT_WORD);
+        if ( rank == NULL ) goto write_ignore;
+
+        vgic_check_inflight_irqs_pending(v->domain, v, rank->index, r);
+
+        goto write_ignore_32;
 
     case VRANGE32(GICD_ISACTIVER, GICD_ISACTIVERN):
         if ( dabt.size != DABT_WORD ) goto bad_width;
diff --git a/xen/arch/arm/vgic-v3.c b/xen/arch/arm/vgic-v3.c
index cb5a70c42e..4913301d22 100644
--- a/xen/arch/arm/vgic-v3.c
+++ b/xen/arch/arm/vgic-v3.c
@@ -817,10 +817,12 @@ static int __vgic_v3_distr_common_mmio_write(const char *name, struct vcpu *v,
 
     case VRANGE32(GICD_ICPENDR, GICD_ICPENDRN):
         if ( dabt.size != DABT_WORD ) goto bad_width;
-        printk(XENLOG_G_ERR
-               "%pv: %s: unhandled word write %#"PRIregister" to ICPENDR%d\n",
-               v, name, r, reg - GICD_ICPENDR);
-        return 0;
+        rank = vgic_rank_offset(v, 1, reg - GICD_ICPENDR, DABT_WORD);
+        if ( rank == NULL ) goto write_ignore;
+
+        vgic_check_inflight_irqs_pending(v->domain, v, rank->index, r);
+
+        goto write_ignore_32;
 
     case VRANGE32(GICD_ISACTIVER, GICD_ISACTIVERN):
         if ( dabt.size != DABT_WORD ) goto bad_width;
@@ -987,10 +989,8 @@ static int vgic_v3_rdistr_sgi_mmio_write(struct vcpu *v, mmio_info_t *info,
 
     case VREG32(GICR_ICPENDR0):
         if ( dabt.size != DABT_WORD ) goto bad_width;
-        printk(XENLOG_G_ERR
-               "%pv: vGICR: SGI: unhandled word write %#"PRIregister" to ICPENDR0\n",
-               v, r);
-        return 0;
+        return __vgic_v3_distr_common_mmio_write("vGICR: SGI", v,
+                                                 info, gicr_reg, r);
 
     case VREG32(GICR_IGRPMODR0):
         /* We do not implement security extensions for guests, write ignore */
diff --git a/xen/arch/arm/vgic.c b/xen/arch/arm/vgic.c
index 8f9400a519..0565557814 100644
--- a/xen/arch/arm/vgic.c
+++ b/xen/arch/arm/vgic.c
@@ -726,6 +726,42 @@ unsigned int vgic_max_vcpus(unsigned int domctl_vgic_version)
     }
 }
 
+void vgic_check_inflight_irqs_pending(struct domain *d, struct vcpu *v,
+                                      unsigned int rank, uint32_t r)
+{
+    const unsigned long mask = r;
+    unsigned int i;
+    unsigned long flags;
+    struct pending_irq *p;
+    bool private = rank == 0;
+    struct vcpu *v_target;
+
+    for_each_set_bit( i, &mask, 32 )
+    {
+        unsigned int irq = i + 32 * rank;
+
+        if ( private )
+            v_target = vgic_get_target_vcpu(v, irq);
+        else
+            v_target = vgic_get_target_vcpu(d->vcpu[0], irq);
+
+        spin_lock_irqsave(&v_target->arch.vgic.lock, flags);
+
+        p = irq_to_pending(v_target, irq);
+
+        if ( unlikely(!p) )
+        {
+            spin_unlock_irqrestore(&v_target->arch.vgic.lock, flags);
+            continue;
+        }
+
+        if ( !list_empty(&p->inflight) )
+            printk("%pv trying to clear pending interrupt %u.\n", v, irq);
+
+        spin_unlock_irqrestore(&v_target->arch.vgic.lock, flags);
+    }
+}
+
 /*
  * Local variables:
  * mode: C
diff --git a/xen/include/asm-arm/vgic.h b/xen/include/asm-arm/vgic.h
index 62c2ae538d..abcaae2969 100644
--- a/xen/include/asm-arm/vgic.h
+++ b/xen/include/asm-arm/vgic.h
@@ -298,7 +298,8 @@ extern bool vgic_to_sgi(struct vcpu *v, register_t sgir,
                         enum gic_sgi_mode irqmode, int virq,
                         const struct sgi_target *target);
 extern bool vgic_migrate_irq(struct vcpu *old, struct vcpu *new, unsigned int irq);
-
+extern void vgic_check_inflight_irqs_pending(struct domain *d, struct vcpu *v,
+                                             unsigned int rank, uint32_t r);
 #endif /* !CONFIG_NEW_VGIC */
 
 /*** Common VGIC functions used by Xen arch code ****/
-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Wed Oct 20 10:14:52 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Oct 2021 10:14:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.213784.372108 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1md8cV-0001sx-2n; Wed, 20 Oct 2021 10:14:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 213784.372108; Wed, 20 Oct 2021 10:14:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1md8cU-0001sq-W8; Wed, 20 Oct 2021 10:14:50 +0000
Received: by outflank-mailman (input) for mailman id 213784;
 Wed, 20 Oct 2021 10:14:49 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ou1c=PI=citrix.com=roger.pau@srs-us1.protection.inumbo.net>)
 id 1md8cT-0001sk-LB
 for xen-devel@lists.xenproject.org; Wed, 20 Oct 2021 10:14:49 +0000
Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id ca5a1e4a-4005-4b92-a739-72f646a788e1;
 Wed, 20 Oct 2021 10:14:47 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ca5a1e4a-4005-4b92-a739-72f646a788e1
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1634724887;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=aK8R+y53m2raK/zKeMODq5yj0t4BvxlFMUCuTs4PzmM=;
  b=Vd/Sc7riVMFhhYo6rj+tjMk/hdts69vxwhksNplESD63QMRcVyxDSvJU
   S8pkcB0o8QDLZ0DMVNILXcKYU4I6N1GUsVEJwwfXtXCOb5OWOnSiykmXf
   BpAgEfQzaMTmXhedYCiT1q/MGtjN98QFArXIMDB/vYGYliF2wIKcVfj+K
   k=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: cO6eCfkbpq8R9Rk95m+GqW/yOj2jASZLQnniskr9ymV+fjILNhsTFx6p53g81/Wi2wJ19P+657
 Mtroh7aeQrNRWRYfCmKxhjfd+JwsOXMonoiB/oMAD53TOMZNiSZ90EsXaxFmHHdr5dS5Hr+bPe
 j3enasJde0GzSZlCLbp1X++HF6QZw9+VaXD0ugfABgjRUpf54/HKZ9F8x51LlqSUpvLoTnZdMR
 8cR4ghIxqahXFgUTSP1AkD4vQ1HlKinkBVSJliRYUtF8sLAxHYKk3VaNAyY/5RWEZI9mweFG+l
 q9nT75h7Ui4SSPghJPRMVtpi
X-SBRS: 5.1
X-MesageID: 55179392
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:pthPnaAjchA29RVW/3Tlw5YqxClBgxIJ4kV8jS/XYbTApDgk1TAOn
 zBLDGuAPfeNZmChft4kb4m/pB5Q7cTVyodmQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA
 xA2M4GYRCwMo/u1Si6FatANl1ElvU2zbue6WLGs1hxZH1c+EX5500o7wobVv6Yz6TSHK1LV0
 T/Ni5W31G+Ng1aY5UpNtspvADs21BjDkGtwUm4WPJinj3eH/5UhN7oNJLnZEpfNatI88thW5
 Qr05OrREmvxp3/BAz4++1rxWhVirrX6ZWBihpfKMkQLb9crSiEai84G2PQghUh/si2jhep92
 ZJ277uPciYzZ4Odp91HTEwNe81+FfUuFL7vJHG+tYqYzlHccmuqyPJrZK00FdRGoKAtWzgIr
 KFGbmBWBvyAr7veLLaTUO5ji95lNMD2FIgepmth3XfSCvNOrZXrHviTuo4DjW1YasZmPaiPP
 uY0dzZUZyv6Ph0fEUgXOaxhtbL97pX4W2IB8w/EzUYt2EDfxRJ8+KLgO93UfpqNX8o9tkSXv
 GXd5EziHwoXcteYzFKt4n+qw+PCgy7/cIYTD6GjsO5nhkWJwW4eAwFQUkG0ydGHjUq5V8NaO
 lYj0CMkpqgv92SmVtD4GRa/pRaspQUAUtBdF+k77gClyafO5QudQG8eQVZpacMknN87QyQw0
 V2ElM+vAiZg2JWXQ3+A8rafrRupJDMYa2QFYEcsTxYB4tTliJE+iFTIVNkLOLGxps34H3f32
 T/ikcQlr+xN14hRjfz9pA2ZxWL3znTUcuIrzjzPdHif4hI+X9SCWLeJ8wH1vMl5dpnMGzFto
 0M4s8SZ6ekPC7SEmyqMXPgBEdmV2hqVDNHPqQUwR8d5plxB71bmJNoKuGgvey+FJ+5dIWexC
 HI/rz+983O60JGCVqRwf56qQ/ojyaztBLwJvdiFM4IQPPCdmOKBlRyChHJ8PUixzyDAcollY
 P93lPpA615AVcyLKxLtH48gPUcDnHxW+I8qbcmTI+6b+bSffmWJbrwOLUGDaOs0hIvd/l6Jr
 YgOb5HWk0wGOAEbXsUx2dRPRbztBSNjba0aVuQNLrLTSuaYMDBJ5wDtLUMJJNU+wvU9ehbg9
 XChQE5IoGcTdlWcQThmnktLMeu1Nb4m9CpTFXV1YT6AhihyCa7yvfx3X8ZmItEaGBlLkKcco
 w8tIJ7bXJyii13vplwgUHUKhNY8JE/121/WY3DNjfpWV8cIejElM+TMJ2PH3CIPEjC2pY05p
 bih3RncWp0NW0JpC8O+VR5l5wnZUaE1lL0gUk3WDMNUfUmwooFmJzao1q08It0WKAWFzTyfj
 l7EDRAdrOjLgok07NiW2vzU89b3S7NzThhAAm3WzbeqLi2GrGCt9pBNDbSTdjfHWWKqpKj7P
 bdJz+vxOeEslUpRt9YuCK5iyK8zvoO9p7JTwgl+Mm/MalCnVuFpLnWchJEdvaxR3L5J/wCxX
 xvXqNVdPLyIPuLjEUIQe1V5PrjSi6lMl2CLv/ovIUj86Ctmx5a9UB1fb0uWlShQDLppK4d5k
 +0vj9Ebtl6kgR0wP9fY0i0NrzaQLmYNWrkMv40BBNO5kRIiz1xPbMCOCiLy553TOdxAPlNzf
 22RjavGwb9d2lDDYzw4En2UhbhRgpEHuRZryl4eJgvWxoqZ16FvhBABoy4qSgl1zwlc17MhM
 2dmAER5OKGS8mo6n8NERW2tR1lMCRDxFpYdELfVeLk1l3WVa1E=
IronPort-HdrOrdr: A9a23:6Qezd69qgOMWT1uT80puk+DWI+orL9Y04lQ7vn2ZKCY4TiX8ra
 uTdZsguiMc5Ax+ZJhDo7C90di7IE80nKQdieN9AV7IZniEhILHFvAG0aLShxHmBi3i5qp8+M
 5bAsxD4QTLfDpHsfo=
X-IronPort-AV: E=Sophos;i="5.87,166,1631592000"; 
   d="scan'208";a="55179392"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=YltS09cgh37Ptyvwkz/0ZfCRBFnRx0J5m32lM52CIxGpfDWE3YPoliI2fn7ED0yREAhzI+U0WrPYASXW2DdQ0RetqTogJc4moj5d1NrhCkD9EuRzGQav82b/MkOb3cSyUgIb0ygBjMx0+b0WJwwFuAkQVE254LG/vAJ16TGMDHqfWDfLOLI/qkYPsHTGIVa7/rSc+/uTGul3urkY4NwdE4Q9lKDXKqMleltO0lgr+bg7Er/JEATGTGs4oMhNBA+fBThj4XW1tqvH7H3d8FHHXREnMNRZaC1hsmImjStlHBEchHJVjt3fN8tvLU6jJ3l4bse2WKpQks3GVjiCNhyr5Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=T5gS/QDqJNAXCgRJPXuOmpL95A5VZHQhorm/L8X0PAM=;
 b=l/f9ChvtjFJlQRYDZhcRtcI4ttJNQH84ZiLUScudCfRb3y54Uwb4k6e6rYyxlMbVlNJ3T2TzbtilPAIOwmOADIKbpYlkfOcnz/X068UoMSrRjPVojMhKQAGZ+2SiXvhwZ07D/AbfeUtH4EEFnyQZGn61jqnfTeF1I2ENJXrz+vq+5HBnKjM+amjJRAKV4PWKH8HOWscD0/6gUDzzubsbFAYEEMYNSU9fXAP6sqD7aKj9MKMurhSOUuYjlXNyHbQkj+4sna6K560SPTeRznEN6AvDT0n2xt/1LBx26rqOg+oWgJvmIsKSkxwqLO371kp4CzqfBtWcpbCLLQlUi6C3wA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=T5gS/QDqJNAXCgRJPXuOmpL95A5VZHQhorm/L8X0PAM=;
 b=caJnpXnv4+Q/2GyqZHppbEL29YAEmcioFwPsH7WTmD+auw8yC2OdxPzEZX/dkq1ZopX1iVv4rI2Unul+oBCMayTDzY3X60xln3V1RjaLNPWFarOON42h6R9RJtIy0EPPOfFHC61/dYXeRcKJR/f20vMUJv2ltO1YhCyTKoBnRLY=
Date: Wed, 20 Oct 2021 12:14:00 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>, Andrew Cooper
	<andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>,
	"Julien Grall" <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
	"Anthony PERARD" <anthony.perard@citrix.com>, Juergen Gross
	<jgross@suse.com>, Christian Lindig <christian.lindig@citrix.com>, David
 Scott <dave@recoil.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	<xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v2 3/6] gnttab: allow per-domain control over transitive
 grants
Message-ID: <YW/r6Dk5a79myhzy@MacBook-Air-de-Roger.local>
References: <20210922082123.54374-1-roger.pau@citrix.com>
 <20210922082123.54374-4-roger.pau@citrix.com>
 <1d741841-6aaf-1d33-e1c6-b98f77ce41fb@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <1d741841-6aaf-1d33-e1c6-b98f77ce41fb@suse.com>
X-ClientProxiedBy: LO2P265CA0184.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:a::28) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: b1512670-c306-4226-dc83-08d993b25932
X-MS-TrafficTypeDiagnostic: DM6PR03MB3836:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <DM6PR03MB38365E5E7A2ADB084A2662CB8FBE9@DM6PR03MB3836.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: XH58WLC8OOgMNStpNeg4ohxGlZ0qYD/WN9iRXFEwOaeyQFM1pkKeEb/aVPhU+RAxuGIvWkjd4cpcO/C7a5/OLooKjO5oAKZ1yACnQejx+vGGF57a0kBGeGql10sf56YFZlv9Za2eXc4cZtCx/4Uh2i8DtOiFtQArl5l050iapO6GUFMZxFvbb5/8kIYhMzs9gv6osCFGBzwBF8UzTciAaIcDyCayyowxBJDi0XnKzZdnl1nWXWcL+0FmkSjOcZRBx1GaPiwanbFRyeVqBCee2ROXkKNap5nRwfTbsLCFURIWUW0zXGOIzMx8qNQqUhehSvbJaPEo61W24ZqXdawil28hrFKTbXKNax70L5tvtJFWfZ5cS4DSacdPPqQdrMphy/12QN8ZN+lKiEZExRlmTClq4NAmiUK2YFLLsmxRiTYYBk8PgA5Q3mL+5QRa+K6P6V02I1J7d9obibNzvP720RpH5jAVc1FHwVjNTNaU9StPdM0nDJV22YOXV1ziJrw4RroXHYkmTBE0d3gYND/IuzeeMyGZzna3TRpDBJzwVGb5xK18QpEqywdMn+hKOQBEGFz0Y44p5NQtbIwl1lFKgLoxjPochCkVZKEWo33vWr4FvVp+53yrSh6YKcc91vuS4stsqSuGdrBfHwMhur5AiQ==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(186003)(66476007)(85182001)(4326008)(66556008)(66946007)(9686003)(6496006)(53546011)(508600001)(26005)(83380400001)(956004)(86362001)(316002)(54906003)(38100700002)(82960400001)(6916009)(8936002)(5660300002)(6486002)(8676002)(6666004)(2906002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?a3RXakpNcFd6akFTcDRySEtaaHNwTEREbmo3UkNMYmdnM0hENmNCYVJQY01N?=
 =?utf-8?B?TWExS2s1aTZvemNaWUUvWSt0eUFmL0N4WUF5MEg2R21RQkJ2TWRjRHBRSmdw?=
 =?utf-8?B?OVhUUFpZY1pIcXJOOXFHZklINm9RanpMSHk1NTdPV2RZM2tWbG5RcFM4UzlT?=
 =?utf-8?B?SlU1NmtaRGFTSjJxZFZOYmVBU09qYTJZMHNZT3RCaW9ZTmwvazk0cEZDMlFr?=
 =?utf-8?B?QTRuYW16eHpUUTFxY2tNcG5FRnhjMTRuMHdiWVZBZms0dnF1K3k0Vlg4OXJE?=
 =?utf-8?B?UkdXbWJkUzNwTlNKWEg0WVduSGN3eXowT2FrWTE5d0xPemhDYXhSUTJkUWNK?=
 =?utf-8?B?eWtHUThzc0pRS0d4OG9Ud2ZZRmNWcXVWNlRENXg3ZjZvV2YvbGoyZFR3MGZG?=
 =?utf-8?B?dUt5b1J6ZlV3dklEdmtlVXBLd05SbW54VDBlSHJ0S25CcGtKRkdlTUdjQmRh?=
 =?utf-8?B?eU9mSjBmZk8veFNTdWMyN05oU2dkKzlHcElQRW5Fa2U5Nnd6S3diRlVqZG0y?=
 =?utf-8?B?SXJKWVZ2ZzFNUGRhSkRWTVI3UVlJdXUva1AybnBYVGtNbklmK1JXTkJwVWRw?=
 =?utf-8?B?b0VoaUpJRnhqczdma3VJYzZrczRhVUd2bFZQMlRPNmVkcXpURWltbnFKbVRK?=
 =?utf-8?B?ZDR0SjlkSFBKdVFoY3RGSEhlWml1MGtmSSszTGIybXB3K21PQ1pOZ0poQWl6?=
 =?utf-8?B?eEV3Qnp4cDlNSEJhOXZqTnBIaVZCTlhvUnhyVmx4WW8weGdGKzVJS3pqc2py?=
 =?utf-8?B?S2psMTBkSjV4T2pmTXdpaTdIck5TR2Zua0ZYK3ZzanlnWUJSSkRjdVZxQ0VT?=
 =?utf-8?B?TDVqQ1lqM2RKZVZiYjVIZnFQSGVNNDQ5T0gyR2ZQY2xMV0NFVm44VDdUV0dM?=
 =?utf-8?B?dnhscWhaSFlNTmVDZDFPOEtHVk9IVWlzTDl1Z2JlNzB0djNrQ1ZVYkxxZHJw?=
 =?utf-8?B?cXNkdld5a09ZQWc2WDNzTFkxUlhXZHloTktGUG5waEtWV2s5MjIrTG9jMXh0?=
 =?utf-8?B?VFpORHZZdTNvWm5wZzJNVS9lUURpd3loYktqL0xTei9JL1BlVTg2UnJTTEZm?=
 =?utf-8?B?b0QrcUpiZzh3VHcvSE1PcUo2NGs0YXBuOU9oczNwWDloK2Y4cXFqdTV1TVhp?=
 =?utf-8?B?Y25EeEdMTS9XUHlxNXdkOENjbHdnMEpqLzNxbGViWlE2WW9iRkxJT0lwbWFG?=
 =?utf-8?B?M3V1QXFndzBRNUtWVnpoOHVEdWJzK1Z5SURkVURNeG9PV1BaTCt6S1FlNzJ0?=
 =?utf-8?B?aU1iYnZncXkxdEhpRFdmVFdLT0RRNjVyekszU2k4NkdLb0Z0VjdNOWVVVTRp?=
 =?utf-8?B?SHIvMklveU9UcHYyYjFHbjk5U0htcXo3Z2oxa3R4VHVzcGZhejJXYTdFQ2Ez?=
 =?utf-8?B?a3NiRGZGVVpuUDZ5bnNBSXovUUNwSEZOVDVwQTdxSHpiQ1QvWEZ0cWtqdHZ3?=
 =?utf-8?B?a3RkbUJnMlFyS0ZENjVaUVR6TVdiT2RJM1E4ckRtbnl4cFNEbGg5SGllakJo?=
 =?utf-8?B?RmoxS3dscGRaZXozQmhkVFJpUHBmWlZoT1c0ZkJ0R05KZlVMdXo0K1dQY3Fi?=
 =?utf-8?B?ZzBHQk1rbDVtUTdiZzlkN0N1Mm16UEtwYU1tSWlXcVlXYzNwd0dmNUl5QXRT?=
 =?utf-8?B?MWlKMHRGeVF3UVZDZURlU1BaRkV3NEMwRlViWHBjemoyb1pXeTBQWVZrUTZ3?=
 =?utf-8?B?aThNQlhIeG5QQ2U0S1V2UW12V0luQVYxWmhWcFRYZFFweDRUNnUxTy90TFZE?=
 =?utf-8?Q?33CNXzZCGOhfvMHdfsyW96oImAlGg7nVTtrhdxH?=
X-MS-Exchange-CrossTenant-Network-Message-Id: b1512670-c306-4226-dc83-08d993b25932
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2021 10:14:06.1225
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: roger.pau@citrix.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB3836
X-OriginatorOrg: citrix.com

On Fri, Oct 15, 2021 at 12:05:06PM +0200, Jan Beulich wrote:
> On 22.09.2021 10:21, Roger Pau Monne wrote:
> > --- a/xen/arch/arm/domain_build.c
> > +++ b/xen/arch/arm/domain_build.c
> > @@ -2649,7 +2649,8 @@ void __init create_domUs(void)
> >              .max_evtchn_port = -1,
> >              .max_grant_frames = -1,
> >              .max_maptrack_frames = -1,
> > -            .grant_opts = XEN_DOMCTL_GRANT_version_default,
> > +            .grant_opts = XEN_DOMCTL_GRANT_version_default |
> > +                          XEN_DOMCTL_GRANT_transitive,
> >          };
> >  
> >          if ( !dt_device_is_compatible(node, "xen,domain") )
> > @@ -2757,7 +2758,8 @@ void __init create_dom0(void)
> >          .max_evtchn_port = -1,
> >          .max_grant_frames = gnttab_dom0_frames(),
> >          .max_maptrack_frames = -1,
> > -        .grant_opts = XEN_DOMCTL_GRANT_version_default,
> > +        .grant_opts = XEN_DOMCTL_GRANT_version_default |
> > +                      XEN_DOMCTL_GRANT_transitive,
> >      };
> >  
> >      /* The vGIC for DOM0 is exactly emulating the hardware GIC */
> > --- a/xen/arch/x86/setup.c
> > +++ b/xen/arch/x86/setup.c
> > @@ -750,7 +750,8 @@ static struct domain *__init create_dom0(const module_t *image,
> >          .max_evtchn_port = -1,
> >          .max_grant_frames = -1,
> >          .max_maptrack_frames = -1,
> > -        .grant_opts = XEN_DOMCTL_GRANT_version_default,
> > +        .grant_opts = XEN_DOMCTL_GRANT_version_default |
> > +                      XEN_DOMCTL_GRANT_transitive,
> >          .max_vcpus = dom0_max_vcpus(),
> >          .arch = {
> >              .misc_flags = opt_dom0_msr_relaxed ? XEN_X86_MSR_RELAXED : 0,
> 
> While I can see that you make these adjustments for retaining backwards
> compatibility, I wonder if we need to, at least for Dom0. Dom0 doesn't
> normally grant anything anyway and hence would even less so use
> transitive grants. Of course then there's need to be a command line
> control to re-enable that, just in case.

dom0=gnttab-transitive, or should it be placed somewhere else?

> > @@ -1965,6 +1969,8 @@ int grant_table_init(struct domain *d, int max_grant_frames,
> >      gt->max_grant_frames = max_grant_frames;
> >      gt->max_maptrack_frames = max_maptrack_frames;
> >      gt->max_grant_version = max_grant_version;
> > +    gt->allow_transitive = !!(options & XEN_DOMCTL_GRANT_transitive) &&
> > +                           opt_transitive_grants;
> 
> No need for !! here afaics. Not even if there weren't the &&.
> 
> As to combining with the global option: I think if an admin requested
> them for a domain, this should overrule the command line option. Which
> in turn suggests that the command line option could go away at this
> point. Otherwise, if you AND both together and the guest is known to
> not work without this functionality, domain creation would instead
> better fail (or at the very least it should be logged by the tool
> stack that the request wasn't satisfied, which would require a means
> to retrieve the effective setting). IOW I would see the command line
> turning this off to trump the per-guest enabling request.

How should we go about deprecating it? It would be a bit antisocial
IMO to just drop the option, since people using it would then be
exposed to guests using transient grants if they didn't realize it
should be set in xl.conf or xl.cfg now.

> > --- a/xen/include/public/domctl.h
> > +++ b/xen/include/public/domctl.h
> > @@ -98,8 +98,11 @@ struct xen_domctl_createdomain {
> >  /* Grant version, use low 4 bits. */
> >  #define XEN_DOMCTL_GRANT_version_mask    0xf
> >  #define XEN_DOMCTL_GRANT_version_default 0xf
> > +/* Allow transitive grants. */
> > +#define _XEN_DOMCTL_GRANT_transitive     4
> > +#define XEN_DOMCTL_GRANT_transitive      (1U << _XEN_DOMCTL_GRANT_transitive)
> 
> Omit the former and have the latter be 0x10 or (1U << 4)?
> 
> > -#define XEN_DOMCTLGRANT_MAX XEN_DOMCTL_GRANT_version_mask
> > +#define XEN_DOMCTLGRANT_MAX XEN_DOMCTL_GRANT_transitive
> 
> I didn't even spot this in patch 2 - what is this intended to be used
> for? Neither there nor here I can spot any use.

Yeah, AFAICT those _MAX definitions are used by the ocaml stubs to
assert the max option available. Given how these new options are handled
in ocaml the _MAX check is not implemented, so I could like drop those
(unless there's some other tool that also depends on them).

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Wed Oct 20 10:27:58 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Oct 2021 10:27:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.213794.372120 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1md8p3-0003SN-59; Wed, 20 Oct 2021 10:27:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 213794.372120; Wed, 20 Oct 2021 10:27:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1md8p3-0003SG-1m; Wed, 20 Oct 2021 10:27:49 +0000
Received: by outflank-mailman (input) for mailman id 213794;
 Wed, 20 Oct 2021 10:27:47 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ou1c=PI=citrix.com=roger.pau@srs-us1.protection.inumbo.net>)
 id 1md8p1-0003Rp-LY
 for xen-devel@lists.xenproject.org; Wed, 20 Oct 2021 10:27:47 +0000
Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 186d7433-f8d0-4c26-836b-c1c26c679f09;
 Wed, 20 Oct 2021 10:27:46 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 186d7433-f8d0-4c26-836b-c1c26c679f09
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1634725666;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=g0oYlOXVfe9/xZ2lIN0vY5yWflgsTIOudTzzggWbILI=;
  b=NTXrvIyODsRPBkzVQZXVNM6nrmn4cEk9hGj31Sk9qftOn9S3pH1A+xYK
   qnthxBcXPIMDIG6vDX3MZE1NoRAjU3vqd/JYTrClTdVbXjnPVwrVNayFL
   Nzk8RZu9B5urJvSrCQHWtWo0j79YzhQNe0QRmdcFSsy/Ghxxad7hFPVjx
   E=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: 8ReL9pOnWMQP5Dhcw+v3YZwQayTsRRWztyUTZQ0yymdhD7k8bWGV340EnZCNStm+ztwSQkrjA8
 lP1LRadEAcvmGIlZnmHqnyiznS2AUAjkNCkHCPxD7mJGWNvsgW0l5ZNxNCZlmu2UcUKuEUBFNT
 6KE5vF1ccJibubQ1xAoLi7Nu57uuYyFhhKVY5mGtrwb//6puNFost8V3P2lqQUhoh+2nH1BOBU
 0xB3fGheVWw+nZ68Dg13Shzge3nkc63gjQEmtKzrfHUB1tSlOJ/aNhVUUqJbqNM5kR3RljF1Pr
 jldyUZeYqTEdgKJtmbAkjouy
X-SBRS: 5.1
X-MesageID: 55627253
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:qfEG1Kt6F0ESNevFN+5QQDA9iOfnVFJYMUV32f8akzHdYApBsoF/q
 tZmKWDQP/2IM2rxc9wna4zi9h4EvsfTy9ZqTVE5/3pmRCsX+JbJXdiXEBz9bniYRiHhoOOLz
 Cm8hv3odp1coqr0/0/1WlTZQP0VOZigHtIQMsadUsxKbVIiGHhJZS5LwbZj29cw24DhWmthh
 PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe
 gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ
 NplnoyWGCYLB67wo8cHYSZHHAhTY/Fv0eqSSZS/mZT7I0zudnLtx7NlDV0sPJ1e8eFyaY1M3
 aVGcnZXNEnF3r/ohuLgIgVvrp1LwM3DJoQQt2sm1TjEJf0nXYrCU+PB4towMDIY250QR6mEO
 pFxhTxHZg+bXR9+GUYrKsgjosGouyHgXCN/twfAzUYwyzeKl1EguFT3C/LrfdiNSdRQj1yvj
 GvM9GTkATkXLNWajzGC9xqEhPLLnC79cJIfEvu/7PECqF+Zy3EXCRYWfUCmuvT/gUm7M/pHI
 lEQ0jojq+417kPDZsb5dw21pjiDpBF0c8pdFag25R+AzoLQ4h2FHS4UQzhZctskucQqAzsw2
 Tehld7zGSZmtrHTTHuH76qVthu7Iy1TJmgHDQcFUgkt89TluJs0jB/EUpBkCqHdpsbuBTj6z
 jSOrS4/r7Yel8gG0+O851+vqxWoq5vSRwg5/DL+WG6/8xh5b46oYY+vwVXD5PMGJ4GcJmRtp
 1BdxZLYtrpXS8jQymrdG43hAY1F+d6uIBuNoHxWHKUa1C6fxGGsVK0OvBhXcRIB3tk/RRflZ
 0rauAV07ZBVPWe3YaIfX79dG/jG3oC7Soy7DqG8gs5mJ8ErLlferX4GiVu4hji1yCARfbcD1
 YB3mCpGJU0RDrh713KITuMZ3K5DKssWlD6LG86TI/hK19OjiJ+ppVUtbATmggMRtvrsTODpH
 zB3bZfiJ/J3C7WWX8Uv2dRPRW3m1FBibXwMl+RZd/SYPi1tE3w7BvnazNsJItI+w/oLx7+So
 inkAye0LWYTY1WddW1mjVg4MNvSsWtX9ypnbUTAw375s5TcXWpfxPhGLMZmFVXW3Odi0eR1X
 5E4lzaoWZxypsD8021FN/HV9dU6HDzy3F7mF3f1MVAXIs87LySUq4CMQ+ca3HRXZsZBnZBl+
 OPIO8KyacdrejmO++6MNqL0kQ3s5SRH8A+wNmORSuRulIzX2NECAwT6j+MtItFKLhPGxzCA0
 B2RDwteru7Iy7LZOvGT2chodq+lTLlzGFR0BW7e4erkPCXW5DP7k4RBTPyJbXbWU2atoPeuY
 uBczvfdNvwbnQkV79ogQugzla9utcHyo7J6zxh/GCmZZVqcFb49cGKN2tNCt/MRy+YB6xe2Q
 E+G5vJTJa6NZJH+CFcUKQd8NraD2PgYlyP89/MwJEmmtiZ78KDeCRdZPgWWiTwbJ7xwadt3z
 eAksc8Qygq+lht1bYrW0nEKrzyBdyVSXb8mu5cWBJ7QpjAqklwSM4bBDiLW4Y2Ub4keOEcdP
 TLJ1rHJgK5RxxSefiNrR2TNx+dUmb8HpAtOkA0ZP12Ml9fI2q030RlW/WhlRwhZ1Ewaged6O
 2wtPExpP6SeuTxvgZEbDWyrHghAAjyf+1DwlARVxDGIERHwWzyfNnA5NMaM4FsdojBVcTVs9
 b2FzHroDGTxd8br0ypuAUNoppQPlzCqGtEuTCx/I/m4Ig==
IronPort-HdrOrdr: A9a23:ET9iwq8oxIPk8F8j1DVuk+FJdb1zdoMgy1knxilNoENuHfBwxv
 rDoB1E73LJYVYqOU3Jmbi7Sc69qFfnhORICO4qTMqftWjdyRCVxeRZg7cKrAeQeREWmtQtsJ
 uINpIOdOEYbmIK/PoSgjPIaurIqePvmMvD5Za8vgdQpENRGtldBm9Ce3im+yZNNW977PQCZf
 6hDp0tnUveRZ1bVLX3OlA1G8z44/HbnpPvZhALQzYh9Qm1lDutrJr3CQKR0BsyWy5Ghe5Kyx
 mLryXJooGY992rwB7V0GHeq7xQhdva09NGQOiBkNIcJDnAghuhIK5hR7qBljYop/zH0idnrP
 D85zMbe+hj4XLYeW+45TPrxgnbyT4rr0TvzFeJ6EGT6fDRdXYfMY5slIhZehzW5w4Lp9dnyp
 9G2Gqfqt5+EQ7AtD6V3amJazha0m6P5VYym+8aiHJSFaEEbqVKkIAZ9ERJVL8dASPB7pw9Gu
 UGNrCc2B9vSyLZU5nlhBgr/DT1NU5DWituA3Jy9PB96gIm30yQlCAjtYsidnRpzuN1d3AL3Z
 WDDkzE/Is+OvP+VpgNdtvpd/HHfFAlcSi8Q156Hm6XYZ3vG0i94KIfs49Frt1DRvQzvewPcd
 L6IQpliVI=
X-IronPort-AV: E=Sophos;i="5.87,166,1631592000"; 
   d="scan'208";a="55627253"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=KyEbiE5LvwzlYl+oW/AEnl1/S5IUObS42Fbbb27oagUW/4I30C5aYHcuvRxRWgX7acrbUI8AWyGYX2ZbZmtLvdA0/UYTow5pJFaSSnDhbaHJl8ZDRFyBDqMLjUDigTpkL/BKjeXwxgmjgngO8CeFoP42iai4Ppa7E9YE2ugWH2O8ghGuPx4dRA/QwmsEKkSevSG3toggPVvIE6yX0EkG+xOByIJYJ0sjEEeREugo0mx9ggpUJw/KGI8XNrcE10xj3Jry7INBIr2A9DwUVAKWdzv/OqdtD1Ns8lv3Of79aHSqXMvhhcYhwuz5PbCRDkcubgFPzldYEee3mYeYv02c1Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=5IyDp+stLFzCj8UtIhdvIq32s5l76V2yUjZdHjCCAWk=;
 b=GZtkFqZ0c58/ijufcMih068FyrqkWwwRJYsRwwFEBY/wnnE1PA2wWyF4TR6uwSI02Umg/YXOxU3upV7kpQyZzMI5q+SuqCreueEj33bU1muRDmHKUjZSZV2T60OwAKSZbn04gFp73d34D8zptDl7TYiiIf8MB/e8Snq4p+Xhd6fUFuZHmlGxCgUcCaQWEraDnLbw8xyNjDCBplaGAdLvIryXGOaAhpZyc/MK98sfWgCZA4pDswSRyMa5V6DBrW8Fo2g3Kd6G26Ff888sETyTdzM+ezAurU17nG+Lily7HBVO+pr+RGsuA4tLS40krIbVtv1JjmjCgKOHEKKKhKwmAQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=5IyDp+stLFzCj8UtIhdvIq32s5l76V2yUjZdHjCCAWk=;
 b=mUQQnmmbVHr0CzzyS+tSZL1XdbRlLxkzjL3kY2vMywAt/9a6kd0U5cCbd2MpXDvLbRkNAEsyxNvkhVX1vW5MSHrr2aqwl73IQ7tkZ0pMOtENBMvaK0cwGrCvfQd97tXRTDx6u3bICUffC709j2r2sOzahPWF23Y8Sf7NvaGfRPA=
Date: Wed, 20 Oct 2021 12:27:08 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Bertrand Marquis <bertrand.marquis@arm.com>
CC: <xen-devel@lists.xenproject.org>, <iwj@xenproject.org>,
	<Oleksandr_Andrushchenko@epam.com>, Stefano Stabellini
	<sstabellini@kernel.org>, Julien Grall <julien@xen.org>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Jan Beulich <jbeulich@suse.com>, Andrew Cooper
	<andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>, Paul Durrant
	<paul@xen.org>
Subject: Re: [PATCH v3 1/1] xen/pci: Install vpci handlers on x86 and fix
 error paths
Message-ID: <YW/u/NZ1usX7nJYt@MacBook-Air-de-Roger.local>
References: <cover.1634723903.git.bertrand.marquis@arm.com>
 <c82cc9c933e09806c9d043c61d92bd793060f9ab.1634723903.git.bertrand.marquis@arm.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <c82cc9c933e09806c9d043c61d92bd793060f9ab.1634723903.git.bertrand.marquis@arm.com>
X-ClientProxiedBy: LO4P123CA0311.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:197::10) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 8f875cc6-cef0-46ed-fcc5-08d993b42e9c
X-MS-TrafficTypeDiagnostic: DM6PR03MB4059:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <DM6PR03MB40592BE7F935409C1F2FCC7D8FBE9@DM6PR03MB4059.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: Y5IAlaCWo/2awqKXG0iCCiTiAw3t/ken0QXlSQoX2DT8nBaFt2FblbPGyLr+j9FSXuDJU/SR0G4SeY1oDfXpGaZFXM7X1G8dpQWJpEWJsdWY703w4i3Ro0eKfoKDYiohCQcrG19GRHInVLpIol4UdNiOLOKx1lV41Kamel1XZsGlNeykcLzMj3n/hnHytcEZGUkfLDBTHdvCsAXIAEXrIQMfQnVeTLyYy0vooT6+JpIajCu132bvBvNrgwoXIMsHypIFLR/parszOJvMGww+13OYgRTqInrTfhtFS+oanrUiMqUhCoSN+RlD1RmlvvrnzaHJOvXHKvT4nJUNpeYoPsAYh/ivNdeOu6/PTJ2Y8/SXkiLwWYiC5kemCaiAol7BjoklhyYQqg3O9pIFZkVnQWRsprG25o8yUy12CnI1/rX+oP7lZfaxwd8yCTZNnioSV+B8Tq8gqQtPw0zKxJI88KJB/5MhSNbXClFYfwMMUr1j1DV1azmJzz5OTdVtznyPLDGStz6R8bmNpLRsO3em+h52/gZ9SCnMXh/fGWJgO3X/Veepdfz1EIHXzhJ2A2DKOfw1x5ec7e3fa9tPtcUGMwHCPoKYuQqN+ifS2/mckahQ1bgeIa5Ru0pjR00B+6KGV9rjF3fEgtGNaS1TTa/FLw==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(7416002)(6496006)(8936002)(82960400001)(83380400001)(26005)(54906003)(6666004)(956004)(4326008)(6486002)(86362001)(38100700002)(316002)(5660300002)(85182001)(186003)(508600001)(9686003)(66946007)(6916009)(8676002)(2906002)(66556008)(66476007);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L0xwNDZrdkJJK084eW10VS9wd0lKaGdKUWo1NnFyOStJektUUExURFNsdXFs?=
 =?utf-8?B?dEZBVW5YenEyQkxOZlgwSkVYZGZqZUgwdmR4MGJMam5xWkJJdE9MSTRTZm1a?=
 =?utf-8?B?eUg3TXlwcE8xc1FWMTc3OWRtaHFqcjV4ZFF1ZzdMb1I1VmNoZXp3ZXRIM3ZO?=
 =?utf-8?B?UmpJTjVmakx2RWhicFJDQ2hEV1pBd09ldkw1NVJJelZHM1FraC9GUE9ObTV1?=
 =?utf-8?B?OUNHSFNybXM4SVRVYWJQN05ocE8vQW9IeTJlcWJlQ0FWWEJvblkyR1FibnNL?=
 =?utf-8?B?TnM2NkZNUjVGWGhDWFZhT1JjK3NFelFrbldnL2FaMnlRMjluemxYelRNcldS?=
 =?utf-8?B?enk0NERsTTNKU1ZUeG1FYmFSNk1MK3hDSjAvZGpqSVJvL09ubzFtMm1IdGUr?=
 =?utf-8?B?dFBuS25CcEZCcFczYTVyczREME5VL1Y1RWxMbVVXNDlLc1dhdVdZVGRLYzVl?=
 =?utf-8?B?L1dZZlhuMWhhR2lqM0YxZFFUS3N5Z05pMFplc2NnZTJQS1k2dExneUVDdXNH?=
 =?utf-8?B?a1RnbTNQMzgxejYyZVhQL1ZMRWliYVZwN1ltWkcrbjArN1dxZldPTlBaWDE0?=
 =?utf-8?B?dHZneVZ1Zk1ia1BndmREMlNhNWdtS2ZuZTNvZTY4YlM1RVlncEI1bHNQT1NH?=
 =?utf-8?B?eHdYMWtZNGo2aUc0NnBzdVFKVHhKRVZFRUYyMFIrTGJWZTVQUzVZNnpjbHZm?=
 =?utf-8?B?MEx1djBiNENkTVp5VnNlWndOK0JQc20rM2IrTWpJU2poblR4bEZLb3hTczU4?=
 =?utf-8?B?dGhOQVR2dTVqV0dzaklud1JWQTB5VWJoVGtHM2N3aHhVTXRmSi9BVVhCa2VQ?=
 =?utf-8?B?alVHcDhZbWxKV2g5cDVZQnBXRmtBbVRwTXdiMnkxa3d3VE11MHRQYmQyWXRJ?=
 =?utf-8?B?ZHN5VU9POTB1TU40OXJ5RmhweEE1NXJYeFFyNzhUVHZTVjNmY1hXRU5ITWZE?=
 =?utf-8?B?bDdKaGFYa1VEYTd6SU1uNVNyZUVraXlFbGMwai9CZ2diZnBrb3ViZ0xzbXdS?=
 =?utf-8?B?elpUTGZQUXAwQ1lkcDgzZGttdUZkTzBsbWdmbzlsQWRndFFKUW1ja2JKM214?=
 =?utf-8?B?Yks5U1NkQnM2U09nUnlIeVlWeVo2azVvc1NRbzNoL0V3MUdlUnd6b0Z0UWg4?=
 =?utf-8?B?ZVZJWmxOZUx2Mlg5TnFNaFg1Nno3eUxjUkJWY1c2SUVWS0dTWTdJaVVjb2pl?=
 =?utf-8?B?SXFzaFl4U2tQVjhRNkVPUlpIaWF3cXlPZlA1eTRIZ0RnZjQ3TVpUM0JRbktz?=
 =?utf-8?B?SmJqYmhZemNqVzZ2TFJFWVdYejdyQzcyYjd5NmZtTVRCWmRzanVaaS9xOHVa?=
 =?utf-8?B?R21YVjhEZVFjTU1ubDVmdEJWT2ZNWmpOS3B0TFhOeVg3clhIRS9Nb1VDNEZU?=
 =?utf-8?B?ZGtHWVFzL3ZDeTBvSDE2Q1F2U3cwaEhuYWk0RjlSQ3pKZVVCNUNOTFJqd0hW?=
 =?utf-8?B?ZEUwQlhibk9KNTJEeXpydmpUbklocENrZ0U3ZTUwWXZxeUgxN240bXpUblEr?=
 =?utf-8?B?Qm94R3dhdDN5dWI4NXJXRE5WMVQvNEJYYjFjcFZ4bTZKYmhVSlAzeFZyU2oz?=
 =?utf-8?B?bWV6cWlhRGNFNmhhZVk3cXpqTnAxVjF5VzlhRmdBNldjOVpiVy9jTkcyZXR0?=
 =?utf-8?B?eGtza0xXVjk5a053Yy9uRjZ5N0ZYVlFrQ1crbEszaklDTzhTVjZ0NHFyVjEy?=
 =?utf-8?B?Y1FmOXNRRG5Db3NUNExxenJzclJwaTBZWWZwZ3ZEVElaUU9SSWRlRVJJanNC?=
 =?utf-8?Q?/WL0L0SwdoEr6TyJxE/2QrUR8lQ+VgAHuW/qzgJ?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 8f875cc6-cef0-46ed-fcc5-08d993b42e9c
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2021 10:27:13.7143
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: roger.pau@citrix.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4059
X-OriginatorOrg: citrix.com

On Wed, Oct 20, 2021 at 11:05:37AM +0100, Bertrand Marquis wrote:
> Xen might not be able to discover at boot time all devices or some devices
> might appear after specific actions from dom0.
> In this case dom0 can use the PHYSDEVOP_pci_device_add to signal some
> PCI devices to Xen.
> As those devices where not known from Xen before, the vpci handlers must
> be properly installed during pci_device_add for x86 PVH Dom0, in the
> same way as what is done currently on arm (where Xen does not detect PCI
> devices but relies on Dom0 to declare them all the time).
> 
> So this patch is removing the ifdef protecting the call to
> vpci_add_handlers and the comment which was arm specific.
> 
> vpci_add_handlers is called on during pci_device_add which can be called
> at runtime through hypercall physdev_op.
> Remove __hwdom_init as the call is not limited anymore to hardware
> domain init and fix linker script to only keep vpci_array in rodata
> section.
> 
> Add missing vpci handlers cleanup during pci_device_remove and in case
> of error with iommu during pci_device_add.
> 
> Move code adding the domain to the pdev domain_list as vpci_add_handlers
> needs this to be set and remove it from the list in the error path.
> 
> Exit early of vpci_remove_device if the domain has no vpci support.
> 
> Add empty static inline for vpci_remove_device when CONFIG_VPCI is not
> defined.
> 
> Add an ASSERT in vpci_add_handlers to check that the function is not
> called twice for the same device.
> 
> Fixes: d59168dc05 ("xen/arm: Enable the existing x86 virtual PCI support
> for ARM")
> Suggested-by: Jan Beulich <jbeulich@suse.com>
> Signed-off-by: Bertrand Marquis <bertrand.marquis@arm.com>

Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>

Thanks!


From xen-devel-bounces@lists.xenproject.org Wed Oct 20 10:28:48 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Oct 2021 10:28:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.213801.372130 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1md8q0-00040m-Es; Wed, 20 Oct 2021 10:28:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 213801.372130; Wed, 20 Oct 2021 10:28:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1md8q0-00040f-BZ; Wed, 20 Oct 2021 10:28:48 +0000
Received: by outflank-mailman (input) for mailman id 213801;
 Wed, 20 Oct 2021 10:28:46 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=TQMG=PI=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1md8py-00040V-MJ
 for xen-devel@lists.xenproject.org; Wed, 20 Oct 2021 10:28:46 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 80658df0-3190-11ec-833d-12813bfff9fa;
 Wed, 20 Oct 2021 10:28:44 +0000 (UTC)
Received: from EUR02-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur02lp2059.outbound.protection.outlook.com [104.47.6.59]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-19-3_Mi2KpOOaSyq7eVuczE-Q-1; Wed, 20 Oct 2021 12:28:42 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB4943.eurprd04.prod.outlook.com (2603:10a6:803:51::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.18; Wed, 20 Oct
 2021 10:28:40 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.018; Wed, 20 Oct 2021
 10:28:40 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6PR05CA0009.eurprd05.prod.outlook.com (2603:10a6:20b:2e::22) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4608.18 via Frontend Transport; Wed, 20 Oct 2021 10:28:39 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 80658df0-3190-11ec-833d-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634725723;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=aaQclbOfoQtGYQAytwUkuyo6xuuvjSo3FjzBsYvMo8U=;
	b=lVNR44SQmAm07o4ZU5RVMwuRvsWkmch+yw7RecgLONHdBTjvHj+/wdbVgGxDT+WQKqRlps
	P/2RwIRYL5aLZEL4bpqCzKCjQI5QtVI5cBMs3ke7ILWv1N4j0DCZ+QcsLRCWmtID70AGu3
	w61MUdJJyHFC3tA5fVVm30ISNyxIWBE=
X-MC-Unique: 3_Mi2KpOOaSyq7eVuczE-Q-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=JHvVMQiS2CGeH1dlBTZ2zjEfCP5ey8W4c8uqJ66jvMcSmysMrPyozm+s7u+0+Zbw/Et/xiSFR8EH1OWh/gxF+xQ+zlb/roFwNyVNfRiymSXCxp+5t3BZ+UTEmtN5olEXj2qVq9QvVHBGU0HpmA6f4jBhvIAYHv+cfNHI3qiNA3X6SkFPAEVkydqWHG29pNyHXKq9k4TgADygaDb/FG6VIVfZau+b0HPgZYwli72iuAcTZ4fifZEaDH4OBZiIoFBGcvKJEN9RnjkIWgCmjaoi+2JiUmdAl1m+WgR1yY6sijKFhp7yCjYKZIzSg3psKi/uWrw5UnGm5Pr9f6ui8abqBw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=aaQclbOfoQtGYQAytwUkuyo6xuuvjSo3FjzBsYvMo8U=;
 b=k8bmdG1oah66Sa7oMndHTzbe+p7sLwUQZPiNtAAD49yUWymEMdM8xiGc086F17Kn16xAgDZmexa1JycJWHHeiYe50pxaReG1cjhV5GcABPTpGRGLLIZLh1nLBdjIDL/AV0FXv83C6+4vs8Kry1QpRCNI/zQ85TzH19yCmJR6mPSVH7cz2yo5oBZ7KXw/brEtPVZkuhCJsiiacnSLeQ+380q1XS58MHxURirosfg/0MqjXsH2wW1endrdWRttC+5+UZyqGQBitqWvEqYHcdSE9bS+ofe591KjCF0Qtt/C4HxgPrto3AH072RhRoiBW8KqVdX7hS3ebAE0auqi2YGeTg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [PATCH v3 1/1] xen/pci: Install vpci handlers on x86 and fix
 error paths
To: Bertrand Marquis <bertrand.marquis@arm.com>
Cc: iwj@xenproject.org, Oleksandr_Andrushchenko@epam.com,
 Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>, Wei Liu
 <wl@xen.org>, Paul Durrant <paul@xen.org>, xen-devel@lists.xenproject.org
References: <cover.1634723903.git.bertrand.marquis@arm.com>
 <c82cc9c933e09806c9d043c61d92bd793060f9ab.1634723903.git.bertrand.marquis@arm.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <75cfb240-7797-ca36-3d43-77ac977f6649@suse.com>
Date: Wed, 20 Oct 2021 12:28:38 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <c82cc9c933e09806c9d043c61d92bd793060f9ab.1634723903.git.bertrand.marquis@arm.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR05CA0009.eurprd05.prod.outlook.com
 (2603:10a6:20b:2e::22) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 80e6a3d1-34db-4994-0f33-08d993b4626f
X-MS-TrafficTypeDiagnostic: VI1PR04MB4943:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB4943D83EFBFDB9AAAEC01006B3BE9@VI1PR04MB4943.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	xGE2bIsXvtAkmd2L5nupo9eGmUJzXqc6sHffj1F9dbE0GcvstOjXb1JxFuFQSul0CjhcC5YBUpWx8n7PIC/qsejvfAlbXZAOG0OTBa6TCs8Hxzt37p+bSbMy6Ay9EKGSTJYSmLC/1921xeFLQRejWoDdcTk380+nKxr5QbCTLYqUqyT3dkSJD8eXsMLTdkO6YcL+Q5Nna/P2jd61QY8WmY9wEP+bxFkFFC40KA4K/pCSrRoJBFA7ZZW5g9OPQFyopG0fwpJYdx4fSNSW2SbGJjVu47bLrAlT83dcVJgNq+ODnqRFb7cMm77CFL7Xk1m1mYsvzp7q+8FYm36Nk1XrCp4BHomyZ6eA3Kut9nw8NYDoup0gOlxVQ9aFpAEugq5IrG3LfnSRjWGA1vm58dQobOfl+fdfSbk14DTz9zRjEOBCnVI3/jsCCIbpAFAp6HVjrp23qLYd5y+lcoZMZme6Mv//KSsiK0jnPqk4jcnQDN6VXsHVU7KocWxQbjQnnKoomU9p9cEwA5r6gazE7O9kf39LgRG2NowaOXaZzq8VpaTXpWbR+KwtPcwu/5siA+woqKbDDU4LWujCl12NolVJ+OPfP5GrtN5IZtHPgtwrxCUMI51fuLU1FLvilyCbtbjXGtpy6tD7op5T8OacivAP+dDB91F3pCq2iwClUSNmrwmgEzhIrpDpaDVtKtVAx8TicC5pIvQJ5Y7mOb+tWGMW2OKYkpFf/jPcEWfggXC/R28=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(54906003)(4326008)(31686004)(5660300002)(186003)(2906002)(53546011)(66556008)(66476007)(86362001)(38100700002)(83380400001)(31696002)(36756003)(508600001)(2616005)(8676002)(956004)(66946007)(6486002)(8936002)(7416002)(16576012)(316002)(6916009)(26005)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?K3JFVWJkdkIyRXVjUXF4YUlYbklwZktIU1NHcm1wRW8rOVh2UCttem5kbTZ4?=
 =?utf-8?B?TDFTdmRNUDdJVzljbTM0a1BLd1dHbjhEZjZSU2xCWW1HOWdaa3RSTG14b2NN?=
 =?utf-8?B?TkI4TzgyZVlETDlEUXZFSmFHMVJyZ25wNzRwTVhoK2p4UnhPaVcxdFErWTVv?=
 =?utf-8?B?Y2F5ekhtTnRSUXJGNlRaUDlEUGhEV1NOZmpPTExZRHlyM3BDMTZNOFVJUG4z?=
 =?utf-8?B?M3MrNVp4NWpjMy9IN0RyUmpGQTFlaS9ORCtWTU14c29VVVlBU3ZqTU5PYU9j?=
 =?utf-8?B?bHgrZ3NlQWpFTG5BWkxlZHJPeENQRzlIbmdjM3FnQytTc053UU9tTGVOU2VV?=
 =?utf-8?B?bUJZMmNSUnBHUEg2ei81VGp2UHF6REdOMElKS3JSYTRTb0R1LzI2QUNBSkYw?=
 =?utf-8?B?NXBicHYzLys4eUVWaVlFRFlqU3hUZmFib3p6QWxIWXVFelZyWlI1T0kxQVF6?=
 =?utf-8?B?WmlhTWlHdEFwTmZiYU8yT1g5NGJQOUwvYkJRN0ZwdStxcDRjMkU5UitxRzAw?=
 =?utf-8?B?QUU1dWNoSThTMU5id01LOTdEWlRXbUlETXNvSjUycytzQ21XaU5Oalp1T1Jq?=
 =?utf-8?B?ek5vUTZpU0pXZ0V0N0xBOHRObFJVbDlSdHQzdDBqSnBqVXV6M0xObkZCbUFC?=
 =?utf-8?B?SXpSWEdubTI0ZnpZdnhFdWt3eHVxdGpjMmJHQU5iaTBCNmlZV2ZablpsdmJ5?=
 =?utf-8?B?ZDlnby9IdEVVb3JRZzRJa0dLaktnMm0yeHk1UXdETElER2JMUVoybDc2Nzhh?=
 =?utf-8?B?UEZ0RHp3THdJNHAveVk0b25ydkNYMDJpVkFYcHB0UXVOTXYxWEh6aDQ2VWNy?=
 =?utf-8?B?ZWtRZU5CU2tVblgreXo5dHhTTktxZ3JIVnd2WjgveHZyeFlNU2cxY1ZvSktk?=
 =?utf-8?B?QWt5MGdvVmMrdVFGMjc3MVhRVWFUQ0NPeE9qd0x2SzFkWmdoWTRLTGJHWXpD?=
 =?utf-8?B?SlljOTlMUi9WS3BUYm05NzNXZDh4V08zTURQU1FrME9GV0xxdm1RamE0LzVG?=
 =?utf-8?B?ckYzREQrQUxuTEl5S3ppQzcxdDBYRkkvTlF4Ync0SjBUMWZvTEFJZkQ5UUF4?=
 =?utf-8?B?WDU5NVRJU1ZwWmRmS3ZCWndqcUFVUDBQTVZZYk1zVDA0U2U3d294OEdjWjBU?=
 =?utf-8?B?bDNDei9XN2RwVE43MUcrL2kvc2t0OHZuUzFLUkVNUjIyM3RuRVBzZ2Y3dmw1?=
 =?utf-8?B?eE81Nm1JVWZtMGNvL1hNUkw4M3cySVpab1Y3Z01FZDdSV0xpWUxSRVdCblNH?=
 =?utf-8?B?cnhMdDVxTDNoWVpvdDk3WGZSaFR1anRBeEltc3pFT3paTEdlL0YrQ0o4OXNu?=
 =?utf-8?B?L0lZV01WeHhtU1VtQTY1eStlaXRZR3BNL0lwRmNFVnJIdFN5S1NLOGhGbERH?=
 =?utf-8?B?M3h5bENuajJwVTB1YVIzNE5NS1pkRDVSU0dGWTcrMlBpZzFZMGxGbDdCc0xC?=
 =?utf-8?B?U1N3ZnhIYkZRa3pycUkxeFJKcG1nZUtabm42c3dnQVZ4S21CYktWT0txcHJ1?=
 =?utf-8?B?b1d2eHpUSDI4dWM1cDhBUlZXTUV4eVlocDVHRVB6cndpQVNvNW82OFZhQkJT?=
 =?utf-8?B?Q1dGc1lPeW5CS1N1bFdMSnUwOUNTYURHK2NZak9ReW9WZndibVMrSEdBaGRB?=
 =?utf-8?B?eUF3WUU5c05zeUcyblkvUGpXNUs3V0RzLytuM3BOVEJiWlhKMVZlZ2lwQUkx?=
 =?utf-8?B?S3NIZmRzenBpQkxrR0p1YlNMeHlNekwyUUZiYU95eEorTGJFUHh3SmpoR2lx?=
 =?utf-8?Q?Bb34i7LSoPB0k2+anPuAwT/d53RLY7NkluQgEPT?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 80e6a3d1-34db-4994-0f33-08d993b4626f
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2021 10:28:40.5427
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jbeulich@suse.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4943

On 20.10.2021 12:05, Bertrand Marquis wrote:
> Xen might not be able to discover at boot time all devices or some devices
> might appear after specific actions from dom0.
> In this case dom0 can use the PHYSDEVOP_pci_device_add to signal some
> PCI devices to Xen.
> As those devices where not known from Xen before, the vpci handlers must
> be properly installed during pci_device_add for x86 PVH Dom0, in the
> same way as what is done currently on arm (where Xen does not detect PCI
> devices but relies on Dom0 to declare them all the time).
> 
> So this patch is removing the ifdef protecting the call to
> vpci_add_handlers and the comment which was arm specific.
> 
> vpci_add_handlers is called on during pci_device_add which can be called
> at runtime through hypercall physdev_op.
> Remove __hwdom_init as the call is not limited anymore to hardware
> domain init and fix linker script to only keep vpci_array in rodata
> section.
> 
> Add missing vpci handlers cleanup during pci_device_remove and in case
> of error with iommu during pci_device_add.
> 
> Move code adding the domain to the pdev domain_list as vpci_add_handlers
> needs this to be set and remove it from the list in the error path.
> 
> Exit early of vpci_remove_device if the domain has no vpci support.
> 
> Add empty static inline for vpci_remove_device when CONFIG_VPCI is not
> defined.
> 
> Add an ASSERT in vpci_add_handlers to check that the function is not
> called twice for the same device.
> 
> Fixes: d59168dc05 ("xen/arm: Enable the existing x86 virtual PCI support
> for ARM")
> Suggested-by: Jan Beulich <jbeulich@suse.com>
> Signed-off-by: Bertrand Marquis <bertrand.marquis@arm.com>

This looks to address all review comments, so
Reviewed-by: Jan Beulich <jbeulich@suse.com>

Thanks, Jan



From xen-devel-bounces@lists.xenproject.org Wed Oct 20 10:29:19 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Oct 2021 10:29:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.213807.372142 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1md8qU-0004aW-PX; Wed, 20 Oct 2021 10:29:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 213807.372142; Wed, 20 Oct 2021 10:29:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1md8qU-0004aN-L6; Wed, 20 Oct 2021 10:29:18 +0000
Received: by outflank-mailman (input) for mailman id 213807;
 Wed, 20 Oct 2021 10:29:17 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1md8qT-0004a5-6e; Wed, 20 Oct 2021 10:29:17 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1md8qS-0002hm-W0; Wed, 20 Oct 2021 10:29:17 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1md8qS-0004wi-M0; Wed, 20 Oct 2021 10:29:16 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1md8qS-0003oK-LV; Wed, 20 Oct 2021 10:29:16 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=KQF6jHPITQhCp4IuvpY5y3HEMzMeNTy//ertCF6iHqY=; b=dFewMX2XcGSxv17jMzZjLJHVlf
	JBQ3hkazeUAcGv3+3APTkzWq6zccG3AAGeA2xMBCQHoHlVOQzYkND5hKWU82jRRjwREHgIAKCEzFJ
	JLAll5OIHmee4sCMz615GnL5fM+6S9GaxDQqv78Ie83jQ5v1/N0tXDXGOSQ19lKYfBxU=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165683-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 165683: regressions - FAIL
X-Osstest-Failures:
    libvirt:build-armhf-libvirt:libvirt-build:fail:regression
    libvirt:build-amd64-libvirt:libvirt-build:fail:regression
    libvirt:build-arm64-libvirt:libvirt-build:fail:regression
    libvirt:build-i386-libvirt:libvirt-build:fail:regression
    libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    libvirt=e8b5c09a0304513b42b0598bc86820aeaa643b6b
X-Osstest-Versions-That:
    libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 20 Oct 2021 10:29:16 +0000

flight 165683 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165683/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-armhf-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-amd64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-arm64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-i386-libvirt            6 libvirt-build            fail REGR. vs. 151777

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-libvirt-vhd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a

version targeted for testing:
 libvirt              e8b5c09a0304513b42b0598bc86820aeaa643b6b
baseline version:
 libvirt              2c846fa6bcc11929c9fb857a22430fb9945654ad

Last test of basis   151777  2020-07-10 04:19:19 Z  467 days
Failing since        151818  2020-07-11 04:18:52 Z  466 days  452 attempts
Testing same since   165683  2021-10-20 04:21:15 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
    Adolfo Jayme Barrientos <fitoschido@gmail.com>
  Aleksandr Alekseev <alexander.alekseev@virtuozzo.com>
  Aleksei Zakharov <zaharov@selectel.ru>
  Andika Triwidada <andika@gmail.com>
  Andrea Bolognani <abologna@redhat.com>
  Ani Sinha <ani@anisinha.ca>
  Balázs Meskó <meskobalazs@mailbox.org>
  Barrett Schonefeld <bschoney@utexas.edu>
  Bastian Germann <bastiangermann@fishpost.de>
  Bastien Orivel <bastien.orivel@diateam.net>
  BiaoXiang Ye <yebiaoxiang@huawei.com>
  Bihong Yu <yubihong@huawei.com>
  Binfeng Wu <wubinfeng@huawei.com>
  Bjoern Walk <bwalk@linux.ibm.com>
  Boris Fiuczynski <fiuczy@linux.ibm.com>
  Brian Turek <brian.turek@gmail.com>
  Bruno Haible <bruno@clisp.org>
  Chris Mayo <aklhfex@gmail.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Ehrhardt <christian.ehrhardt@canonical.com>
  Christian Kirbach <christian.kirbach@gmail.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Cole Robinson <crobinso@redhat.com>
  Collin Walling <walling@linux.ibm.com>
  Cornelia Huck <cohuck@redhat.com>
  Cédric Bosdonnat <cbosdonnat@suse.com>
  Côme Borsoi <fedora@borsoi.fr>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniel Letai <dani@letai.org.il>
  Daniel P. Berrange <berrange@redhat.com>
  Daniel P. Berrangé <berrange@redhat.com>
  Didik Supriadi <didiksupriadi41@gmail.com>
  dinglimin <dinglimin@cmss.chinamobile.com>
  Dmytro Linkin <dlinkin@nvidia.com>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Eric Farman <farman@linux.ibm.com>
  Erik Skultety <eskultet@redhat.com>
  Fabian Affolter <mail@fabian-affolter.ch>
  Fabian Freyer <fabian.freyer@physik.tu-berlin.de>
  Fabiano Fidêncio <fabiano@fidencio.org>
  Fangge Jin <fjin@redhat.com>
  Farhan Ali <alifm@linux.ibm.com>
  Fedora Weblate Translation <i18n@lists.fedoraproject.org>
  Gavi Teitz <gavi@nvidia.com>
  gongwei <gongwei@smartx.com>
  Guoyi Tu<tu.guoyi@h3c.com>
  Göran Uddeborg <goeran@uddeborg.se>
  Halil Pasic <pasic@linux.ibm.com>
  Han Han <hhan@redhat.com>
  Hao Wang <wanghao232@huawei.com>
  Hela Basa <r45xveza@pm.me>
  Helmut Grohne <helmut@subdivi.de>
  Hiroki Narukawa <hnarukaw@yahoo-corp.jp>
  Ian Wienand <iwienand@redhat.com>
  Jakob Meng <jakobmeng@web.de>
  Jamie Strandboge <jamie@canonical.com>
  Jamie Strandboge <jamie@ubuntu.com>
  Jan Kuparinen <copper_fin@hotmail.com>
  jason lee <ppark5237@gmail.com>
  Jean-Baptiste Holcroft <jean-baptiste@holcroft.fr>
  Jia Zhou <zhou.jia2@zte.com.cn>
  Jianan Gao <jgao@redhat.com>
  Jim Fehlig <jfehlig@suse.com>
  Jin Yan <jinyan12@huawei.com>
  Jinsheng Zhang <zhangjl02@inspur.com>
  Jiri Denemark <jdenemar@redhat.com>
  John Ferlan <jferlan@redhat.com>
  Jonathan Watt <jwatt@jwatt.org>
  Jonathon Jongsma <jjongsma@redhat.com>
  Julio Faracco <jcfaracco@gmail.com>
  Justin Gatzen <justin.gatzen@gmail.com>
  Ján Tomko <jtomko@redhat.com>
  Kashyap Chamarthy <kchamart@redhat.com>
  Kevin Locke <kevin@kevinlocke.name>
  Kristina Hanicova <khanicov@redhat.com>
  Laine Stump <laine@redhat.com>
  Laszlo Ersek <lersek@redhat.com>
  Lee Yarwood <lyarwood@redhat.com>
  Lei Yang <yanglei209@huawei.com>
  Liao Pingfang <liao.pingfang@zte.com.cn>
  Lin Ma <lma@suse.com>
  Lin Ma <lma@suse.de>
  Lin Ma <morecache@gmail.com>
  Liu Yiding <liuyd.fnst@fujitsu.com>
  Luke Yue <lukedyue@gmail.com>
  Luyao Zhong <luyao.zhong@intel.com>
  Marc Hartmayer <mhartmay@linux.ibm.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Markus Schade <markus.schade@hetzner.com>
  Martin Kletzander <mkletzan@redhat.com>
  Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
  Matej Cepl <mcepl@cepl.eu>
  Matt Coleman <matt@datto.com>
  Matt Coleman <mcoleman@datto.com>
  Mauro Matteo Cascella <mcascell@redhat.com>
  Meina Li <meili@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Michał Smyk <fedora@smyk.it>
  Milo Casagrande <milo@milo.name>
  Moshe Levi <moshele@nvidia.com>
  Muha Aliss <muhaaliss@gmail.com>
  Nathan <nathan95@live.it>
  Neal Gompa <ngompa13@gmail.com>
  Nick Chevsky <nchevsky@gmail.com>
  Nick Shyrokovskiy <nshyrokovskiy@gmail.com>
  Nickys Music Group <nickys.music.group@gmail.com>
  Nico Pache <npache@redhat.com>
  Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
  Olaf Hering <olaf@aepfle.de>
  Olesya Gerasimenko <gammaray@basealt.ru>
  Orion Poplawski <orion@nwra.com>
  Pany <geekpany@gmail.com>
  Patrick Magauran <patmagauran.j@gmail.com>
  Paulo de Rezende Pinatti <ppinatti@linux.ibm.com>
  Pavel Hrdina <phrdina@redhat.com>
  Peng Liang <liangpeng10@huawei.com>
  Peter Krempa <pkrempa@redhat.com>
  Pino Toscano <ptoscano@redhat.com>
  Pino Toscano <toscano.pino@tiscali.it>
  Piotr Drąg <piotrdrag@gmail.com>
  Prathamesh Chavan <pc44800@gmail.com>
  Praveen K Paladugu <prapal@linux.microsoft.com>
  Richard W.M. Jones <rjones@redhat.com>
  Ricky Tigg <ricky.tigg@gmail.com>
  Robin Lee <cheeselee@fedoraproject.org>
  Roman Bogorodskiy <bogorodskiy@gmail.com>
  Roman Bolshakov <r.bolshakov@yadro.com>
  Ryan Gahagan <rgahagan@cs.utexas.edu>
  Ryan Schmidt <git@ryandesign.com>
  Sam Hartman <hartmans@debian.org>
  Scott Shambarger <scott-libvirt@shambarger.net>
  Sebastian Mitterle <smitterl@redhat.com>
  SeongHyun Jo <caelus9536@gmail.com>
  Shalini Chellathurai Saroja <shalini@linux.ibm.com>
  Shaojun Yang <yangshaojun@phytium.com.cn>
  Shi Lei <shi_lei@massclouds.com>
  simmon <simmon@nplob.com>
  Simon Chopin <chopin.simon@gmail.com>
  Simon Gaiser <simon@invisiblethingslab.com>
  Simon Rowe <simon.rowe@nutanix.com>
  Stefan Bader <stefan.bader@canonical.com>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Berger <stefanb@linux.vnet.ibm.com>
  Stefan Hajnoczi <stefanha@gmail.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Szymon Scholz <szymonscholz@gmail.com>
  Thomas Huth <thuth@redhat.com>
  Tim Wiederhake <twiederh@redhat.com>
  Tomáš Golembiovský <tgolembi@redhat.com>
  Tomáš Janoušek <tomi@nomi.cz>
  Tuguoyi <tu.guoyi@h3c.com>
  Victor Toso <victortoso@redhat.com>
  Ville Skyttä <ville.skytta@iki.fi>
  Vinayak Kale <vkale@nvidia.com>
  Wang Xin <wangxinxin.wang@huawei.com>
  WangJian <wangjian161@huawei.com>
  Weblate <noreply@weblate.org>
  Wei Liu <liuwe@microsoft.com>
  Wei Liu <wei.liu@kernel.org>
  Wei-Chen Chen <weicche@microsoft.com>
  William Douglas <william.douglas@intel.com>
  Yalei Li <274268859@qq.com>
  Yalei Li <liyl43@chinatelecom.cn>
  Yang Fei <yangfei85@huawei.com>
  Yang Hang <yanghang44@huawei.com>
  Yanqiu Zhang <yanqzhan@redhat.com>
  Yaroslav Kargin <ykargin@virtuozzo.com>
  Yi Li <yili@winhong.com>
  Yi Wang <wang.yi59@zte.com.cn>
  Yuri Chornoivan <yurchor@ukr.net>
  Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
  zhangjl02 <zhangjl02@inspur.com>
  Zheng Chuan <zhengchuan@huawei.com>
  zhenwei pi <pizhenwei@bytedance.com>
  Zhenyu Ye <yezhenyu2@huawei.com>
  Zhenyu Zheng <zheng.zhenyu@outlook.com>
  Zhenzhong Duan <zhenzhong.duan@intel.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          fail    
 build-arm64-libvirt                                          fail    
 build-armhf-libvirt                                          fail    
 build-i386-libvirt                                           fail    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           blocked 
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-libvirt-xsm                                 blocked 
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-libvirt                                     blocked 
 test-arm64-arm64-libvirt                                     blocked 
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-libvirt-pair                                blocked 
 test-amd64-i386-libvirt-pair                                 blocked 
 test-arm64-arm64-libvirt-qcow2                               blocked 
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-libvirt-vhd                                 blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 79900 lines long.)


From xen-devel-bounces@lists.xenproject.org Wed Oct 20 10:36:48 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Oct 2021 10:36:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.213820.372156 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1md8xg-00069V-Pj; Wed, 20 Oct 2021 10:36:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 213820.372156; Wed, 20 Oct 2021 10:36:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1md8xg-00069O-L7; Wed, 20 Oct 2021 10:36:44 +0000
Received: by outflank-mailman (input) for mailman id 213820;
 Wed, 20 Oct 2021 10:36:44 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=TQMG=PI=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1md8xg-00069I-1Y
 for xen-devel@lists.xenproject.org; Wed, 20 Oct 2021 10:36:44 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 9d0203ac-3191-11ec-833e-12813bfff9fa;
 Wed, 20 Oct 2021 10:36:42 +0000 (UTC)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2050.outbound.protection.outlook.com [104.47.12.50]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-28-fueFwKl-PsCe8okDe0HhkQ-1; Wed, 20 Oct 2021 12:36:40 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15; Wed, 20 Oct
 2021 10:36:39 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.018; Wed, 20 Oct 2021
 10:36:39 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM5PR0201CA0014.eurprd02.prod.outlook.com (2603:10a6:203:3d::24) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.16 via Frontend
 Transport; Wed, 20 Oct 2021 10:36:38 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9d0203ac-3191-11ec-833e-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634726201;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding;
	bh=fLixa5mYFXJzvVO/wWHaEgJ4h3Tnk+rcvIsAC/w20Y8=;
	b=LtU8iT+GD4VeklbB1D5LOAdT+kv7HxphNu7Etyzxf9VkzOjyyG14zHegSqx+6QMA1o74rI
	GCVrrOAXK4bLDaSCVtf387zI1GDfreq6FIg7dcyxgOVa71ISMlWlxlxQS2kOfceD7Z+QrS
	FJslRfX2tn0pD9lI70DNzzY4nB+S4KM=
X-MC-Unique: fueFwKl-PsCe8okDe0HhkQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Bf9xfbwKZW8n0gxx3Ul59ARhondWFRtYidCgviO717rkStZO5Onv0nYrpl3GRaGtjqOmfwKt+jXwsw4dw2QXApgkKy7NZR8kmHjpw30Xm5F4eb5U2edrOPUpMfU7Tj4k/CF9gRiMzYJ7hJjfQW/53QwFZ5ystdkuQz+/nOTRdeYFqJJxtoZ0RMKw8uwj6CytyhJlLHbeh+/eu28CfeCWok6e/+xpXpzD2aK/JjLqpgfMHa64LA+ZtLfib+dzVvq76DT8rGAwnNIH6FoAq8LyDyi4MAwNkxoRoXIBXbzLMLQkwcAhWaxjgWJn767RQ29BurS3+5Xcnc5t/pvmQrPXSw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=fLixa5mYFXJzvVO/wWHaEgJ4h3Tnk+rcvIsAC/w20Y8=;
 b=C6GkzYatV5+Io82mH5QMCgtZcc8Sk+SXCFVqJ+4eW7KGSx/2hns6kr9pkZ9S+XqH11WrF+PxbNraqqXy13svEnuNhjLy1bkMBE6wNzyTo2eGvwDiZRzk/b1QjZBv0ufPothXqkAA630Ild3jsf84QRwuMf/sWHhhYlBMTXExpBMWB144X11A2rTbVaKq4wq+aNYaGQuhXXm8pJvAHK1TX4rSdnpaYaIhN9cwmKBbAI7Y6bxD+mXRlH4ILkTGyOn4R81s3N/rw9mM8cEuRDqewhiOKltJ/jD0u5/JLmBH4vVY/RYiSQ4fOABpMWWNfq5xR1//3VAwMNexMcxd4rhjwQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: xen.org; dkim=none (message not signed)
 header.d=none;xen.org; dmarc=none action=none header.from=suse.com;
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Paul Durrant <paul@xen.org>
From: Jan Beulich <jbeulich@suse.com>
Subject: [PATCH] x86/IOMMU: mark IOMMU / intremap not in use when ACPI tables
 are missing
Message-ID: <684e4a04-3ef3-46be-3302-149d5ce30177@suse.com>
Date: Wed, 20 Oct 2021 12:36:37 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM5PR0201CA0014.eurprd02.prod.outlook.com
 (2603:10a6:203:3d::24) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 54beda57-2908-40bd-6f25-08d993b57fb4
X-MS-TrafficTypeDiagnostic: VI1PR04MB5600:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB56002B5E5C82D535993B99BDB3BE9@VI1PR04MB5600.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	BHzyvB7mCYMHY749Y8GnTXhHwGgUdaP4aX5NdA/fIbb2j0scvbeqoV80BgIvF+o+YUV4vZEsw+P8gwa5DbxIdG/PT5wWL8EKzWUJmTP9fK/YZlGSByq7zI5DF9rLCSYS0n4dXvNLFeaYoGcR0bpUD44FH247q7vC5bKwmbnQVb6gGCZsAM1v7noNd3+doWL3myPqsmOw3bQNFlQdslPy5ZeyyW7HztYdK/lSBiJL232Dftn7cpNZO2CmdCNaG1/ej81AwT9F/zLQ2MhUyFnujxlqJn/iZdtlMV8LrynbOJCbUGHrpgfvjTq9B6HY+V0w4iIiXASAi8ZGB0dZIg2ps4WEYbcdqVXQOooREBv3jzzMa+2spTw8tW7WxBoVjx6aA/xgqX9p9Yl12Wu1As0X3ZEQJv/+cjmLzqSLHGI36fJS9McbkbBGty1du/8t6fGkRHWteqa/XUUbgymOKbCPbMRsfYmuMZD92Q7sz2EbGQjFacZ2OGDzZ+ZTJouxHvIZHuVH2f5Ke74nHGeM04/I1aVeT+MvkqLvZzgh8pYEaPhYrruBfdoYyfRJcsoylzo4y3aRlWi2RtpRY7iKOWqzE4fU4010XkEiscFnyo/LlsmunbJmXhqiFJYkfOyNaoWaZ2Gph3Q3RNfgx0m/BE1g7i9Li8plZz9v9ufZ0mE+Yz+az5ldTw+6aWhHhhGqfsrBBGCGhejtbBvsi2KO8Qq1WuvQdjK0ZChrFeeOeoD1JNA=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(31696002)(6916009)(6486002)(66946007)(5660300002)(316002)(31686004)(66476007)(66556008)(2906002)(956004)(16576012)(54906003)(38100700002)(2616005)(186003)(86362001)(83380400001)(36756003)(8676002)(508600001)(26005)(4326008)(8936002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?WUlWZVpKcE1sVjdWcGlVR3lrbi82MG1Ld0xybXBKYXR2cDl0dmwvRVN5bzFJ?=
 =?utf-8?B?TDJVeEVPZ2VFb0haVTFSb2htY0hja0gvM0p1dnJlN0JlbkFIeXhuZ3hBZFFY?=
 =?utf-8?B?YW9uL3RTLzlZZloycDhxYnZxQ1dSMWFSR2NEWUZ5dVFacGtTcmw2TG52M2pi?=
 =?utf-8?B?NXdyV3U1clBITzc0L3FKRGdnVE9iMGxxZlQ1UzNzalJFUjZlY3dLdE42MVM3?=
 =?utf-8?B?ZHAzSXBMUlJna0NTcEowdHA0ZUhuVzBUSjVmcDVZZnliK2FFdXEwOGl0a25h?=
 =?utf-8?B?NWx6ZEF4U01BMXlvSHFKNVhJZGFrTGpjVkJqcUFMWS9jSEhuRXc2M0MvSURS?=
 =?utf-8?B?QkVlOHpBSFNhckNrZXVDR29SOVNIbTVjVUpUdVc3Mjc2bHdmRUUxUWtlaE56?=
 =?utf-8?B?L1dZTXoycVFsbmRPRC82VC8rem1oazlJNDZFNFoxUE50ZWFiNzM4U1BlRGla?=
 =?utf-8?B?SXNrbmNCakRkOWg3ckl0dXN0K042UzNjVVhhbkh4clVFUWQzUGpQVUFWREZ3?=
 =?utf-8?B?M0JSU0IxN2RyTFNXcndmbWY4dmVsMHFzejlTSkNHMER5S2RnMGVoL2xFcUJV?=
 =?utf-8?B?MmtQTXVlRGNwTDNCRGQzVTBnTEJXKzVDYVdrS3Z5OWE0aENQU0ZEcm5pYlQz?=
 =?utf-8?B?SUpTSWdTK3Z5QVZBWE5DMzVOYlFFUkVGTzd2aFJEbWZpVGlCVjJoRlJ6b09h?=
 =?utf-8?B?UkZGbUJ1VmdQUWJSdDMzOVl0V3plSFFaTEUyR0ppQ01nSzFUYXBTSVJVK0t5?=
 =?utf-8?B?VlFEdnpTTWNUbzVVdlg0eGk0VkRvZXg1RjR2R1lyM1lvTXhidWFWMzhFcjBJ?=
 =?utf-8?B?Q2pUcTlTRnUzUUJBZGlTMTZjOHZlaUE3T0lkUWFRWkdDZWVmeEV3dWEyMXgx?=
 =?utf-8?B?dVV1TytVd2hjb2s4bCs0TnF3ak5oTVZXQ2RoYkVtQXZZSTZHNllzKzV5a0xC?=
 =?utf-8?B?bThQZS9hZHAwRDkrdEFqR0R1cVRrdFhSdUZNeC93bHVqbXNVM3hiTWhuZGxu?=
 =?utf-8?B?dUFZaXpGa29DUzBLVlhIVGtaWVpNanFITzR6aVpZWGZuRGoyR1dXV09laE4x?=
 =?utf-8?B?d0FLemE3bmZWNDNtMFJFNGtLRWNwb3RnMGpBUjB5d3pzRFNKSDlISnB6UDY0?=
 =?utf-8?B?YTRFY0hLY2dUZy92cGNubmI2U29BOThEM2ZRb0ZNRmFGbjFITXl3MEt0WHJp?=
 =?utf-8?B?S1Y0WEVvcmtyNG1lMXFSRFlQb2MxYXM4Sit5cjFRem5yWkpETTZ3ZCtMbHA2?=
 =?utf-8?B?c1NEMVR1bU1kSDA4VkJ4ZWdaNWRaZktQd2ZVR2ppYmxNZFh1Q1U1akJ0L1My?=
 =?utf-8?B?N1I3MlhTeHE5dzVyT2dCNHoydDFreWZoeFhCTUw0TEErVkhhMjMxOUxkVG81?=
 =?utf-8?B?cGk0ckRDTU1HRDJyTWE2RmpyTStLc3l2YUUvLzF5Nlg3TnRGa3ZwUE1uZksr?=
 =?utf-8?B?UThTbjZDbmZ0Nlhkc211dGRVclBqd2Y5NStzckFTSHA2QTVMeTl1Ync2cG5m?=
 =?utf-8?B?R0RvcnJBTlYrdlkxZ1JkdWNFUnBEd1ZnTHNtTEtqeldzKzZzWTJFUFlDLzJM?=
 =?utf-8?B?eklrRm1IOS8yYWx4RDBTZTRHY1NlM2ROeS9WWGZIOVdaUGg2Tm15bk5takRq?=
 =?utf-8?B?bW8xTE9EV2dlcTl4SzQ0WmRwdUtsc09EWFZSTk9kVktTbnNnSFdVelJMWVFB?=
 =?utf-8?B?Sjc4WXVkbkhjNExQbkJHcVkzVkNLdVBWZmRXQkw3UHA0elp6N2piYTZCaTd3?=
 =?utf-8?Q?JoWeqwhzfH2W783EyWJJADmAdnv7nWe0tNzGPFt?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 54beda57-2908-40bd-6f25-08d993b57fb4
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2021 10:36:39.1370
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jbeulich@suse.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5600

x2apic_bsp_setup() gets called ahead of iommu_setup(), and since x2APIC
mode (physical vs clustered) depends on iommu_intremap, that variable
needs to be set to off as soon as we know we can't / won't enable the
IOMMU, i.e. in particular when
- parsing of the respective ACPI tables failed,
- "iommu=off" is in effect, but not "iommu=no-intremap".
Move the turning off of iommu_intremap from AMD specific code into
acpi_iommu_init(), accompanying it by clearing of iommu_enable.

Take the opportunity and also skip ACPI table parsing altogether when
"iommu=off" is in effect anyway.

Reported-by: Andrew Cooper <andrew.cooper3@citrix.com>
Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
I've deliberately not added a Fixes: tag here, as I'm of the opinion
that d8bd82327b0f ("AMD/IOMMU: obtain IVHD type to use earlier") only
uncovered a pre-existing anomaly. This particularly applies to the
"iommu=off" aspect. (This now allows me to remove an item from my TODO
list: I was meaning to figure out why one of my systems wouldn't come
up properly with "iommu=off", and I had never thought of combining this
with "no-intremap".)

Arguably "iommu=off" should turn off subordinate features in common
IOMMU code, but doing so in parse_iommu_param() would be wrong (as
there might be multiple "iommu=" to parse). This could be placed in
iommu_supports_x2apic(), but see the next item.

While the change here deals with apic_x2apic_probe() as called from
x2apic_bsp_setup(), the check_x2apic_preenabled() path looks to be
similarly affected. That call occurs before acpi_boot_init(), which is
what calls acpi_iommu_init(). The ordering in setup.c is in part
relatively fragile, which is why for the moment I'm still hesitant to
move the generic_apic_probe() call down. Plus I don't have easy access
to a suitable system to test this case. Thoughts?

--- a/xen/drivers/passthrough/amd/pci_amd_iommu.c
+++ b/xen/drivers/passthrough/amd/pci_amd_iommu.c
@@ -193,10 +193,7 @@ int __init acpi_ivrs_init(void)
     ivhd_type = rc;
 
     if ( (amd_iommu_detect_acpi() !=0) || (iommu_found() == 0) )
-    {
-        iommu_intremap = iommu_intremap_off;
         return -ENODEV;
-    }
 
     iommu_init_ops = &_iommu_init_ops;
 
--- a/xen/drivers/passthrough/x86/iommu.c
+++ b/xen/drivers/passthrough/x86/iommu.c
@@ -41,6 +41,23 @@ enum iommu_intremap __read_mostly iommu_
 bool __read_mostly iommu_intpost;
 #endif
 
+void __init acpi_iommu_init(void)
+{
+    if ( iommu_enable )
+    {
+        int ret = acpi_dmar_init();
+
+        if ( ret == -ENODEV )
+            ret = acpi_ivrs_init();
+
+        if ( ret )
+            iommu_enable = false;
+    }
+
+    if ( !iommu_enable )
+        iommu_intremap = iommu_intremap_off;
+}
+
 int __init iommu_hardware_setup(void)
 {
     struct IO_APIC_route_entry **ioapic_entries = NULL;
--- a/xen/include/asm-x86/acpi.h
+++ b/xen/include/asm-x86/acpi.h
@@ -141,16 +141,10 @@ extern u32 x86_acpiid_to_apicid[];
 extern u32 pmtmr_ioport;
 extern unsigned int pmtmr_width;
 
+void acpi_iommu_init(void);
 int acpi_dmar_init(void);
 int acpi_ivrs_init(void);
 
-static inline int acpi_iommu_init(void)
-{
-    int ret = acpi_dmar_init();
-
-    return ret == -ENODEV ? acpi_ivrs_init() : ret;
-}
-
 void acpi_mmcfg_init(void);
 
 /* Incremented whenever we transition through S3. Value is 1 during boot. */



From xen-devel-bounces@lists.xenproject.org Wed Oct 20 10:51:36 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Oct 2021 10:51:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.213828.372167 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1md9Bs-0008Nq-2o; Wed, 20 Oct 2021 10:51:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 213828.372167; Wed, 20 Oct 2021 10:51:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1md9Br-0008Nj-Vg; Wed, 20 Oct 2021 10:51:23 +0000
Received: by outflank-mailman (input) for mailman id 213828;
 Wed, 20 Oct 2021 10:51:22 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1md9Bq-0008Nd-T8
 for xen-devel@lists.xenproject.org; Wed, 20 Oct 2021 10:51:22 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1md9Bq-00038V-SJ
 for xen-devel@lists.xenproject.org; Wed, 20 Oct 2021 10:51:22 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1md9Bq-0004Bv-RQ
 for xen-devel@lists.xenproject.org; Wed, 20 Oct 2021 10:51:22 +0000
Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89)
 (envelope-from <iwj@xenproject.org>)
 id 1md9BZ-0003Ph-F7; Wed, 20 Oct 2021 11:51:05 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date
	:Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From;
	bh=B3hBcANhzvsjNP5kDNHVrt7uz138GVy1W5y7CdONARc=; b=TkjrROxKUcKuw8KfF6KP3Jt7Ol
	NmQ90aQL8NpKDBSwwHN6zRhVH65vVp6QX396SdWbMJBszsW5wKujzuVWr+/jBK/bJNLjkPPpAPAxX
	gAT0O30KORSZllZLSGsMTEr2LuY2hKXbBKoucwQF7XD+fqbr0sYO4FaymkLUClIbcLIk=;
From: Ian Jackson <iwj@xenproject.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <24943.62617.9207.158774@mariner.uk.xensource.com>
Date: Wed, 20 Oct 2021 11:51:05 +0100
To: Bertrand Marquis <Bertrand.Marquis@arm.com>
Cc: Jan Beulich <jbeulich@suse.com>,
    "Oleksandr_Andrushchenko\@epam.com" <Oleksandr_Andrushchenko@epam.com>,
    Stefano Stabellini <sstabellini@kernel.org>,
    Julien Grall <julien@xen.org>,
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
    Andrew Cooper <andrew.cooper3@citrix.com>,
    Roger Pau =?iso-8859-1?Q?Monn=E9?= <roger.pau@citrix.com>,
    Wei Liu <wl@xen.org>,
    Paul Durrant <paul@xen.org>,
    "xen-devel\@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v2 1/1] xen/pci: Install vpci handlers on x86 and fix exit
 path
In-Reply-To: <0FC6BD8A-1805-4C10-A95C-EA199D870F06@arm.com>
References: <cover.1634659471.git.bertrand.marquis@arm.com>
	<d788dcce9e344a39f6761633f0e96774ab42c2aa.1634659471.git.bertrand.marquis@arm.com>
	<9f77b70f-93b8-2b54-3aa1-5de677d858cc@suse.com>
	<0FC6BD8A-1805-4C10-A95C-EA199D870F06@arm.com>
X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu)

Bertrand Marquis writes ("Re: [PATCH v2 1/1] xen/pci: Install vpci handlers on x86 and fix exit path"):
> > On 20 Oct 2021, at 08:16, Jan Beulich <jbeulich@suse.com> wrote:
> > I'm inclined to suggest s/exit/error/ in the title though (and maybe
> > also s/path/paths/), which would be easy enough to do while committing.
> 
> @Ian: Please tell me if this is ok to be fixed during commit.

It's academic now, since you need a respin anyway, but I would in any
case have preferred a new version.  I find that a much better
workflow.  Expecting to make changes on commit pushes work onto
committers from submitters, which is less scaleable.

And it also ends up with committer making changes without any further
human review of any kind.  The committer must do so during an activity
which is otherwise often shallow and administrative.  This is not the
best way to get good results.

I believe I have made these points before, but perhaps not so clearly
and explicitly.  They are IMO very general.  (FTAOD I'm not saying
that making changes on commit is never appropriate, but it ought to be
exceptional.)

Thanks,
Ian.


From xen-devel-bounces@lists.xenproject.org Wed Oct 20 10:57:28 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Oct 2021 10:57:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.213838.372186 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1md9Hg-0000iZ-SL; Wed, 20 Oct 2021 10:57:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 213838.372186; Wed, 20 Oct 2021 10:57:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1md9Hg-0000iS-Oc; Wed, 20 Oct 2021 10:57:24 +0000
Received: by outflank-mailman (input) for mailman id 213838;
 Wed, 20 Oct 2021 10:57:23 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=TQMG=PI=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1md9Hf-0000iM-49
 for xen-devel@lists.xenproject.org; Wed, 20 Oct 2021 10:57:23 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 7f095c44-3194-11ec-8342-12813bfff9fa;
 Wed, 20 Oct 2021 10:57:20 +0000 (UTC)
Received: from EUR03-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur03lp2059.outbound.protection.outlook.com [104.47.10.59]) (Using
 TLS) by relay.mimecast.com with ESMTP id de-mta-4-PiSeQvcTN2C-AsAzAAkxMg-1;
 Wed, 20 Oct 2021 12:57:18 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB4192.eurprd04.prod.outlook.com (2603:10a6:803:4c::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.16; Wed, 20 Oct
 2021 10:57:14 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.018; Wed, 20 Oct 2021
 10:57:14 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM5PR0301CA0015.eurprd03.prod.outlook.com (2603:10a6:206:14::28) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.14 via Frontend
 Transport; Wed, 20 Oct 2021 10:57:13 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7f095c44-3194-11ec-8342-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634727439;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=L/eAlKevja/dq212jGYbDBU3v+bl+jBCSCxsJvbR48Y=;
	b=fptdG82or3DsJYyi4keP0NjeTQk7P7bnkPQPxS6Xnx6PVPtGdi+Kmo74wU/yyAiR9wtJmC
	KQ0RwQp6U/QzMXaah42jm/mfti5wkn5pk3XMHVNjVBq6HpzLaaGBgfOX9cEYZliI7zGQFx
	IldGv4lixY4mth2URRTXIP1krBXhS28=
X-MC-Unique: PiSeQvcTN2C-AsAzAAkxMg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=K/ZNZIAIq0q4gusYtACsVdF8GA12pvi8uYe1Jsdu8ULUWDnn7UghnIqzb8Om1YoUz4rMtzWHYITurNaJ9NO7G6VCPNaNYN7cq4gk/QxFBcIBflUQnbjE9Bmevy6aqTsWvpna2snk/6bALDqMMScxm50RfwpiM8H/LbBC7u6zJLcMC6ibXm2o64vA9xEltwAZ57+oQ61eR60Qzdd6umCoUN1k/HmpivD8ym75YgQcl26x/dk5B6l/ie+vip1XaZYaZZ+GjmB5rZdGiXMdzB8lIIPaLa7yjIH9Nxh81KVjEQVqhzRN51j4vQHvVgNcSln54Ii9lbwA500Y4la3BDS1yw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=iESsk5QfGKCSNYoDRYowdJX3usymRyJH1qOJEoXvZcs=;
 b=Z230Dykb4OK8IIrMJ3rWqUk1WQdbPQpUojbAy+28ysRdWDpj0qLNCD7A9JlxqNbQruoKXJBhYEYMlHJznmqRthHv3npNEBWnAsmcWukeniNFhckblnhmSeW08ylj/EWiFHL32pULdI8TIJcPCt1XhdYnnOpNMsuqg93YHK4X+qKvL88kmmRJEGB5VWpRUSMfGDy7sgyga4Nu/vTaeG1Dgp3tlqp/86spodsXy0G/4pDFNNUSHxSfICeLLI+s6L350Jdr84F/peokHUPO2XP7DOg7kzb4uKGVD///RyS+kF1scORtSIbwLYKS5Yv6ztGdEpUtyhzWWAc4p/BC/Cmevg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Subject: Re: [PATCH v2 2/6] gnttab: allow setting max version per-domain
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Anthony PERARD <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>,
 Christian Lindig <christian.lindig@citrix.com>, David Scott
 <dave@recoil.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 xen-devel@lists.xenproject.org
References: <20210922082123.54374-1-roger.pau@citrix.com>
 <20210922082123.54374-3-roger.pau@citrix.com>
 <f5564634-5f9e-0b94-f73a-d44ae65c30f4@suse.com>
 <0b58667f-b6bc-d5b5-2dd1-0c8996367319@suse.com>
 <YW/NipJMLH0Zz05s@MacBook-Air-de-Roger.local>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <a3d9388a-e2f5-76aa-d51a-2d74afb92bbd@suse.com>
Date: Wed, 20 Oct 2021 12:57:11 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <YW/NipJMLH0Zz05s@MacBook-Air-de-Roger.local>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM5PR0301CA0015.eurprd03.prod.outlook.com
 (2603:10a6:206:14::28) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 8eb185d9-5180-45d5-919a-08d993b85fe7
X-MS-TrafficTypeDiagnostic: VI1PR04MB4192:
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB419217B433F636411F49F08BB3BE9@VI1PR04MB4192.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	mkuqyGQ0ZdjNRBj+92YKzwUac6usUj9b88sub6GM9NrJlZSZisDo6/YNgLUDvQAv4iSTSZvznNVyi4X7cjl2LIefmq0uoE1AQ8SmvSiTW4ChI+bqWSydDw2N8JtSjj0/ZJQ/13af9CrxVEuUBBS66gpXKV//CyH3Mht7MxcE4uhoCpbTuDEPjto3s+jkBGYyXCEvd8aoicrtWqY1U5d0bzSbBpYfN2OhoYnsdFK1ZpYFfzpfVMbjawCo2L2Is/VgByI6Bd8L9iT1BCpAe22n2HA6JYFsC+AIutN/VNxoQIQQg+JQ6/sFwxXXHe6iQAbqvkOjLpadVwVx2tntBYJGFaXMIQ1p9I4uL8Pyu/2H0GA1OuGumCtNzV79bskvaylLqonldmpzJ8iH6EhMV8UpUzqwgJroMvEVONF//6H0DQY7Kh2p5DIfYgMmzkLtbYjtCmYHFL2jrG4J0W3yCADMZepSgcJkwIIRUY8G1xDGCJQ3KXS3EqWrqNGf5rBPLBKDqtqNbwKw8SwXSX9MgrDsq+pgtEpnngX9ZoOfbeI84cmQmGBvGLF+LGd45TuxYQ1zH2gQz6+rkqUU8zRaAj9qCxT4Bc4+WD16+4Not62De3NE1OEpp581VADBED1G5rF4e4IapFacT7KoH2/5T0rfwCl0fxDb4y6ggvGQmHZvzZrhDL9biR/tIuT05hMj/1Hi0LQwWWm8LIt7ICalIdqE/uVaK1TyXjz+dcfRj1DRkuODhcCst0RzbxMkQNX4dAd9
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(66946007)(6486002)(2616005)(956004)(36756003)(38100700002)(8676002)(31686004)(5660300002)(508600001)(26005)(8936002)(6916009)(53546011)(86362001)(31696002)(83380400001)(7416002)(4326008)(186003)(66556008)(66476007)(316002)(54906003)(2906002)(16576012)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?em2mPbYGRl/873zLgAhCYRUV7z9VScvS8K2Ib9fOg4XhvEZod8gcB/DA9YcM?=
 =?us-ascii?Q?BBf2nl/Kd0rt28Vz2SRl3Y0yFhEqHEa174fNl3W2FKH1uKXP0FURizIp23Em?=
 =?us-ascii?Q?v7LGE9TeeWX7Ydn5+aZYQ12aeyxDw7RcfrsjyhPvQuHmUv7ThTlhvy8vmwAn?=
 =?us-ascii?Q?BUs0pPeSaFz1MrDR2tKD57TIyQOsnjz9LMOvh4MdKE5j8/OM36NMDil7tq0f?=
 =?us-ascii?Q?6bqI2Kqg8qF293cvzLIuYKD0mhtkefMJDOWmSN4MV6MwhblQOp7UEssFvMbn?=
 =?us-ascii?Q?M4fkuiF2nWp1qn51h75knk+F/lqZ3+ipWpmn40oo/EXp+Ol0Yz8FGXRIhI/S?=
 =?us-ascii?Q?8mwfyNWn84/Mie+pwm5zaYtGZ2b1jFn63jzCEhHmTLXcRDVsooLPNyXs8xcl?=
 =?us-ascii?Q?uEF0p8J2vdcSLK1BEnFYL8acz0EHDj7soPBszxcs+tFkARrIu509nXysQDc/?=
 =?us-ascii?Q?b+J+DcggTQMD+PUmYKk2da7S/ctzq0T/J7zw3R/9xKOmKBbJwjmtmh/ILotk?=
 =?us-ascii?Q?M0Uy6VkmtpUWy79TojjwtE48PAOcUCKODEd2OMA8wZY/h0hGpKJyE5kuHSA4?=
 =?us-ascii?Q?mZS1toTsR+4SXvAhP/qQlBKf7e0Y2G9X6qmOMxAA/VkBjCubPqaxxFYNR/u3?=
 =?us-ascii?Q?WPDTa809sb/ndYh850k07H4lvK0vOqbznRaY7okJfOrtRFmhihZDEGxbBQ2e?=
 =?us-ascii?Q?G+RMY3v7xqof4SJ/Xkf9LyOn6kJoFWCaAFWzeOnSzA+OgibVu0vwcBMD5WLu?=
 =?us-ascii?Q?iK1tK2Y3blcdjHzwZyZr+/QtgOe4rJE5zruCtexeQ7sh/+sJzz5rKC9A40BC?=
 =?us-ascii?Q?ZIcyw8K5+f+lbb6sF4sYEcUP6qnOUOsfEcLkClK/4T3uBhZ+pE/7Q3DYVZ8M?=
 =?us-ascii?Q?LM2bOgovQfA+JNRQ54ApvBROX71qc04HQEAgdowIO4xMeXcyOdIE2mFoouot?=
 =?us-ascii?Q?EbBu1HGU1FNTscHTLVzgBWia+938ehef9FSzlkj+nxUnSB44+mhUsSGeIs84?=
 =?us-ascii?Q?76wQFq43C5rKycHLa2qT9Oq8XeRQBsBV0MDHRldL6OetUUJCRr8aqkdE+Yqr?=
 =?us-ascii?Q?rLVYEfiquZ88uSOO1dQVnQgKLEViaNBN0nisoFVKLv4VAnVX6eWBZVkB4Pc3?=
 =?us-ascii?Q?/WZdtdeegHbHAjyBIWgDvih0hqopUBRHedijCZMIU+X6XdcAopuBVbcItzs/?=
 =?us-ascii?Q?JMhVrFbsQxmp4P0mEOU7MVhSN9RHXi6xWEccEFD+JvUHFBI1DZHg2/evEFYF?=
 =?us-ascii?Q?SmSzZEH5QX8yeMfVZYaKcqtWG/T6FDV/+C/8QbZ7mPohzaOTi7vpEysehbQP?=
 =?us-ascii?Q?Iu5Y56b8KDnF45Hv5CQvqQI+QHVRSBIltQNj+bdQc46u7olHWgBNnhyZ8sGy?=
 =?us-ascii?Q?poTdiAwL+f/xGizbLEuJCpSdgL7Z1Ka6HMkpp5zvUacjmUwleEP8IXXWQW+7?=
 =?us-ascii?Q?ia0cQN08H+8=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8eb185d9-5180-45d5-919a-08d993b85fe7
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2021 10:57:14.3032
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jbeulich@suse.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4192

On 20.10.2021 10:04, Roger Pau Monn=C3=A9 wrote:
> On Fri, Oct 15, 2021 at 11:48:33AM +0200, Jan Beulich wrote:
>> On 15.10.2021 11:39, Jan Beulich wrote:
>>> On 22.09.2021 10:21, Roger Pau Monne wrote:
>>>> --- a/xen/include/public/domctl.h
>>>> +++ b/xen/include/public/domctl.h
>>>> @@ -87,14 +87,22 @@ struct xen_domctl_createdomain {
>>>>      /*
>>>>       * Various domain limits, which impact the quantity of resources
>>>>       * (global mapping space, xenheap, etc) a guest may consume.  For
>>>> -     * max_grant_frames and max_maptrack_frames, < 0 means "use the
>>>> -     * default maximum value in the hypervisor".
>>>> +     * max_grant_frames, max_maptrack_frames and max_gnttab_version <=
 0
>>>> +     * means "use the default maximum value in the hypervisor".
>>>>       */
>>>>      uint32_t max_vcpus;
>>>>      uint32_t max_evtchn_port;
>>>>      int32_t max_grant_frames;
>>>>      int32_t max_maptrack_frames;
>>>> =20
>>>> +/* Grant version, use low 4 bits. */
>>>> +#define XEN_DOMCTL_GRANT_version_mask    0xf
>>>> +#define XEN_DOMCTL_GRANT_version_default 0xf
>>>> +
>>>> +#define XEN_DOMCTLGRANT_MAX XEN_DOMCTL_GRANT_version_mask
>>>> +
>>>> +    uint32_t grant_opts;
>>>
>>> As it now seems unlikely that this will make 4.16, please don't forget
>>> to bump the interface version for 4.17. With that and preferably with
>>> the nit above addressed, hypervisor parts:
>>> Reviewed-by: Jan Beulich <jbeulich@suse.com>
>>
>> Actually no, I'm afraid there is an issue with migration: If the tool
>> stack remembers the "use default" setting and hands this to the new
>> host, that host's default may be different from the source host's. It
>> is the effective max-version that needs passing on in this case, which
>> in turn requires a means to obtain the value.
>=20
> Hm, my thinking was that the admin (or a higer level orchestration
> tool) would already have performed the necessary adjustments to assert
> the environments are compatible.

I don't think we can rely on this in the hypervisor. We may take this
as a prereq for proper working, but I think we ought to detect
violations and report errors in such a case.

> This problem already exist today where you can migrate a VM from a
> host having the max default grant version to one having
> gnttab=3Dmax-ver:1 without complains.

Are you sure about "without complaints"? What would a guest do if it
expects to be able to use v2, since it was able to on the prior host?

> Note that adding such a check would then effectively prevent us from
> lowering the default max grant version, as any incoming migration from
> a previous hypervisor using the default parameters would be rejected.

Right, guests would need booting anew on a such restricted host.

Jan



From xen-devel-bounces@lists.xenproject.org Wed Oct 20 11:11:29 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Oct 2021 11:11:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.213847.372197 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1md9V4-0002zn-1D; Wed, 20 Oct 2021 11:11:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 213847.372197; Wed, 20 Oct 2021 11:11:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1md9V3-0002zg-U1; Wed, 20 Oct 2021 11:11:13 +0000
Received: by outflank-mailman (input) for mailman id 213847;
 Wed, 20 Oct 2021 11:11:12 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1md9V2-0002za-MS
 for xen-devel@lists.xenproject.org; Wed, 20 Oct 2021 11:11:12 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1md9V2-0003Vv-9b; Wed, 20 Oct 2021 11:11:12 +0000
Received: from [54.239.6.185] (helo=[192.168.28.129])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1md9V2-0005uP-3I; Wed, 20 Oct 2021 11:11:12 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=4ygHepWUQ/jRTw7dl3mvhqvxKxefrRVShyiE9aHH9mw=; b=kt+39eFNQjuTwUczXr+VQKKb+n
	2Wlt1sVqymf3H6VdKJ+FIHCb4Qs5d5groXnBhr2scMAOrRu3GjTsc7vFmWpmYGA5eJchNWS1ovt/X
	yK9QGVh4N20v+Ir9dWozZ/vPDHpd12X6FvIv6t4Z5ilaChepktvO04+oJO8Fd5r3KdoA=;
Message-ID: <5319596d-c2e4-de6c-237e-62f14a7695ec@xen.org>
Date: Wed, 20 Oct 2021 12:11:09 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.2.0
Subject: Re: [PATCH v2 4/6] xen/arm: if direct-map domain use native addresses
 for GICv3
To: Penny Zheng <penny.zheng@arm.com>, xen-devel@lists.xenproject.org,
 sstabellini@kernel.org
Cc: Wei.Chen@arm.com, Bertrand.Marquis@arm.com
References: <20211015030945.2082898-1-penny.zheng@arm.com>
 <20211015030945.2082898-5-penny.zheng@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20211015030945.2082898-5-penny.zheng@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Penny,

On 15/10/2021 04:09, Penny Zheng wrote:
> From: Stefano Stabellini <stefano.stabellini@xilinx.com>
> 
> Today we use native addresses to map the GICv3 for Dom0 and fixed
> addresses for DomUs.
> 
> This patch changes the behavior so that native addresses are used for
> all direct-map domains(including Dom0).
> 
> Considering that dom0 may not always be directly mapped in the future,
> this patch introduces a new helper "is_domain_use_host_layout()" that
> wraps both two check "is_domain_direct_mapped(d) || is_hardware_domain(d)"
> for more flexible useage.

Typo: s/useage/usage/

> 
> Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>
> Signed-off-by: Penny Zheng <penny.zheng@arm.com>
> ---
>   xen/arch/arm/domain_build.c  | 46 +++++++++++++++++++++++++++---------
>   xen/arch/arm/vgic-v3.c       | 20 +++++++++-------
>   xen/include/asm-arm/domain.h |  3 +++
>   3 files changed, 50 insertions(+), 19 deletions(-)
> 
> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
> index 6cd03e4d0f..7e0ee07e06 100644
> --- a/xen/arch/arm/domain_build.c
> +++ b/xen/arch/arm/domain_build.c
> @@ -2255,16 +2255,20 @@ static int __init make_gicv2_domU_node(struct kernel_info *kinfo)
>       return res;
>   }
>   
> +#ifdef CONFIG_ARM_64

The code below is specific to the GICv3 (and not 64-bit). So this should 
be gated with CONFIG_GICV3.

Personally, I would have gated the code in a separate patch. But I am 
fine if this is added in this patch so long this is mentionned in the 
commit message.

>   static int __init make_gicv3_domU_node(struct kernel_info *kinfo)
>   {
>       void *fdt = kinfo->fdt;
>       int res = 0;
> -    __be32 reg[(GUEST_ROOT_ADDRESS_CELLS + GUEST_ROOT_SIZE_CELLS) * 2];
> +    __be32 *reg;
>       __be32 *cells;
> +    struct domain *d = kinfo->d;

AFAICT, 'd' is not going to be modified. So please add const.

> +    char buf[38];

Please explain how 38 was found. For an example, see the comment on top 
of 'buf' in make_memory_node().

> +    unsigned int i, len = 0;
>   
> -    res = fdt_begin_node(fdt, "interrupt-controller@"__stringify(GUEST_GICV3_GICD_BASE));
> -    if ( res )
> -        return res;
> +    snprintf(buf, sizeof(buf), "interrupt-controller@%"PRIx64,
> +             vgic_dist_base(&d->arch.vgic));
> +    res = fdt_begin_node(fdt, buf);

You set res but it gets overwritten just below. Were you meant to check 
the return value?

>   
>       res = fdt_property_cell(fdt, "#address-cells", 0);
>       if ( res )
> @@ -2282,35 +2286,55 @@ static int __init make_gicv3_domU_node(struct kernel_info *kinfo)
>       if ( res )
>           return res;
>   
> +    /* reg specifies all re-distributors and Distributor. */
> +    len = (GUEST_ROOT_ADDRESS_CELLS + GUEST_ROOT_SIZE_CELLS) *
> +          (d->arch.vgic.nr_regions + 1) * sizeof(__be32);
> +    reg = xmalloc_bytes(len);
> +    if ( reg == NULL )
> +        return -ENOMEM;
> +
>       cells = &reg[0];
>       dt_child_set_range(&cells, GUEST_ROOT_ADDRESS_CELLS, GUEST_ROOT_SIZE_CELLS,
> -                       GUEST_GICV3_GICD_BASE, GUEST_GICV3_GICD_SIZE);
> -    dt_child_set_range(&cells, GUEST_ROOT_ADDRESS_CELLS, GUEST_ROOT_SIZE_CELLS,
> -                       GUEST_GICV3_GICR0_BASE, GUEST_GICV3_GICR0_SIZE);
> +                       vgic_dist_base(&d->arch.vgic), GUEST_GICV3_GICD_SIZE);
>   
> -    res = fdt_property(fdt, "reg", reg, sizeof(reg));
> +    for ( i = 0;
> +          i < d->arch.vgic.nr_regions;
> +          i++, cells += (GUEST_ROOT_ADDRESS_CELLS + GUEST_ROOT_SIZE_CELLS) )

dt_child_set_range() will already update cells to the next ones. So this 
needs to be dropped.

I was expecting this to be caugt during test. So did you test this 
series with GICv3? How about the new vGIC?

> +    {
> +        dt_child_set_range(&cells,
> +                           GUEST_ROOT_ADDRESS_CELLS, GUEST_ROOT_SIZE_CELLS,
> +                           d->arch.vgic.rdist_regions[i].base,
> +                           d->arch.vgic.rdist_regions[i].size);
> +    }
> +
> +    res = fdt_property(fdt, "reg", reg, len);

I would suggest to free 'reg' right here as you don't need it 
afterwards. This will also remove the requirement to add a 'out' label 
and the addition of 'goto'.

>       if (res)
> -        return res;
> +        goto out;
>   >       res = fdt_property_cell(fdt, "linux,phandle", kinfo->phandle_gic);
>       if (res)
> -        return res;
> +        goto out;
>   
>       res = fdt_property_cell(fdt, "phandle", kinfo->phandle_gic);
>       if (res)
> -        return res;
> +        goto out;
>   
>       res = fdt_end_node(fdt);
>   
> + out:
> +    xfree(reg);
>       return res;
>   }
> +#endif
>   
>   static int __init make_gic_domU_node(struct kernel_info *kinfo)
>   {
>       switch ( kinfo->d->arch.vgic.version )
>       {
> +#ifdef CONFIG_ARM_64
>       case GIC_V3:
>           return make_gicv3_domU_node(kinfo);
> +#endif
>       case GIC_V2:
>           return make_gicv2_domU_node(kinfo);
>       default:
> diff --git a/xen/arch/arm/vgic-v3.c b/xen/arch/arm/vgic-v3.c
> index cb5a70c42e..70168ca1ac 100644
> --- a/xen/arch/arm/vgic-v3.c
> +++ b/xen/arch/arm/vgic-v3.c
> @@ -1641,14 +1641,15 @@ static inline unsigned int vgic_v3_max_rdist_count(struct domain *d)
>        * Normally there is only one GICv3 redistributor region.
>        * The GICv3 DT binding provisions for multiple regions, since there are
>        * platforms out there which need those (multi-socket systems).
> -     * For Dom0 we have to live with the MMIO layout the hardware provides,
> -     * so we have to copy the multiple regions - as the first region may not
> -     * provide enough space to hold all redistributors we need.
> +     * For direct-map domain(including dom0), we have to live with the MMIO

I find the sentence somewhat misleading because it implies that dom0 is 
is a direct-map domain (this is true today, but this merely an 
implementation details).

However, with the change below, I think it would be better to write "For 
domain using the host memory layout..." and not going into details and 
what sort of domain we refer to here. Instead...

> +     * layout the hardware provides, so we have to copy the multiple regions
> +     * - as the first region may not provide enough space to hold all
> +     * redistributors we need.
>        * However DomU get a constructed memory map, so we can go with
>        * the architected single redistributor region.
>        */
> -    return is_hardware_domain(d) ? vgic_v3_hw.nr_rdist_regions :
> -               GUEST_GICV3_RDIST_REGIONS;
> +    return is_domain_use_host_layout(d) ? vgic_v3_hw.nr_rdist_regions :
> +                                          GUEST_GICV3_RDIST_REGIONS;
>   }
>   
>   static int vgic_v3_domain_init(struct domain *d)
> @@ -1670,10 +1671,13 @@ static int vgic_v3_domain_init(struct domain *d)
>       radix_tree_init(&d->arch.vgic.pend_lpi_tree);
>   
>       /*
> -     * Domain 0 gets the hardware address.
> -     * Guests get the virtual platform layout.
> +     * Since we map the whole GICv3 register memory map(64KB) for
> +     * all guests(including DOM0), DOM0 and direct-map guests could be
> +     * treated the same way here.
> +     * direct-map domain (including Dom0) gets the hardware address.
> +     * Other guests get the virtual platform layout.
>        */
> -    if ( is_hardware_domain(d) )
> +    if ( is_domain_use_host_layout(d) )
>       {
>           unsigned int first_cpu = 0;
>   
> diff --git a/xen/include/asm-arm/domain.h b/xen/include/asm-arm/domain.h
> index fc42c6a310..e8ce3ac8d2 100644
> --- a/xen/include/asm-arm/domain.h
> +++ b/xen/include/asm-arm/domain.h
> @@ -32,6 +32,9 @@ enum domain_type {
>   /* Check if domain is direct-map memory map. */
>   #define is_domain_direct_mapped(d) (d->options & XEN_DOMCTL_CDF_directmap)
>   
> +#define is_domain_use_host_layout(d) (is_domain_direct_mapped(d) || \
> +                                      is_hardware_domain(d))

... the details should be on top of this comment. The advantage is there 
is less chance for a comment to rot.

Regarding the name, I would either drop the 'is_' or s/use/using/. My 
preference goes for the former as it makes the name sightly shorter.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Oct 20 11:38:15 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Oct 2021 11:38:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.213859.372208 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1md9v5-0005QS-9I; Wed, 20 Oct 2021 11:38:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 213859.372208; Wed, 20 Oct 2021 11:38:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1md9v5-0005QL-5U; Wed, 20 Oct 2021 11:38:07 +0000
Received: by outflank-mailman (input) for mailman id 213859;
 Wed, 20 Oct 2021 11:38:06 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1md9v4-0005QF-1W
 for xen-devel@lists.xenproject.org; Wed, 20 Oct 2021 11:38:06 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1md9v3-0003vc-R4; Wed, 20 Oct 2021 11:38:05 +0000
Received: from [54.239.6.185] (helo=[192.168.28.129])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1md9v3-0007os-Kx; Wed, 20 Oct 2021 11:38:05 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=kQjCWWtOI7g0EdEvV5l4EedgBWlhHpwyi9Wu79MEUMY=; b=22MfwAZ5nZXkwz+e5o9UKwlC/h
	d3DBFSivJoeS+prY7FWMFv7s262vdRlVMzIU0G8odIGhfo92DaB92adg7vW5iJHLbXyLDk6XWcV4y
	OhgVELmRY61mE451p7WJ/Lu/yiP1eOpVuyvR7HcHJ/ErnY91asBd4UEdb6sj8XKR9VEk=;
Message-ID: <034a0836-7bf6-8f86-0d93-38ebd8817ed2@xen.org>
Date: Wed, 20 Oct 2021 12:38:03 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.2.0
Subject: Re: [PATCH v2 5/6] xen/arm: if direct-map domain use native UART
 address and IRQ number for vPL011
To: Penny Zheng <penny.zheng@arm.com>, xen-devel@lists.xenproject.org,
 sstabellini@kernel.org
Cc: Wei.Chen@arm.com, Bertrand.Marquis@arm.com
References: <20211015030945.2082898-1-penny.zheng@arm.com>
 <20211015030945.2082898-6-penny.zheng@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20211015030945.2082898-6-penny.zheng@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Penny,

On 15/10/2021 04:09, Penny Zheng wrote:
> From: Stefano Stabellini <stefano.stabellini@xilinx.com>
> 
> We always use a fix address to map the vPL011 to domains. The address
> could be a problem for direct-map domains.
> 
> So, for domains that are directly mapped, reuse the address of the
> physical UART on the platform to avoid potential clashes.
> 
> Do the same for the virtual IRQ number: instead of always using
> GUEST_VPL011_SPI, try to reuse the physical SPI number if possible.
> 
> Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>
> Signed-off-by: Penny Zheng <penny.zheng@arm.com>
> ---
>   xen/arch/arm/domain_build.c  | 41 ++++++++++++++++++++++-----
>   xen/arch/arm/vpl011.c        | 54 +++++++++++++++++++++++++++++++-----
>   xen/include/asm-arm/vpl011.h |  2 ++
>   3 files changed, 83 insertions(+), 14 deletions(-)
> 
> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
> index 7e0ee07e06..f3e87709f6 100644
> --- a/xen/arch/arm/domain_build.c
> +++ b/xen/arch/arm/domain_build.c
> @@ -30,6 +30,7 @@
>   
>   #include <xen/irq.h>
>   #include <xen/grant_table.h>
> +#include <xen/serial.h>
>   
>   static unsigned int __initdata opt_dom0_max_vcpus;
>   integer_param("dom0_max_vcpus", opt_dom0_max_vcpus);
> @@ -2350,8 +2351,11 @@ static int __init make_vpl011_uart_node(struct kernel_info *kinfo)
>       gic_interrupt_t intr;
>       __be32 reg[GUEST_ROOT_ADDRESS_CELLS + GUEST_ROOT_SIZE_CELLS];
>       __be32 *cells;
> +    struct domain *d = kinfo->d;
> +    char buf[27];

Please explain how the '27' was found.

>   
> -    res = fdt_begin_node(fdt, "sbsa-uart@"__stringify(GUEST_PL011_BASE));
> +    snprintf(buf, sizeof(buf), "sbsa-uart@%"PRIx64, d->arch.vpl011.base_addr);
> +    res = fdt_begin_node(fdt, buf);
>       if ( res )
>           return res;
>   
> @@ -2361,14 +2365,14 @@ static int __init make_vpl011_uart_node(struct kernel_info *kinfo)
>   
>       cells = &reg[0];
>       dt_child_set_range(&cells, GUEST_ROOT_ADDRESS_CELLS,
> -                       GUEST_ROOT_SIZE_CELLS, GUEST_PL011_BASE,
> +                       GUEST_ROOT_SIZE_CELLS, d->arch.vpl011.base_addr,
>                          GUEST_PL011_SIZE);
>   
>       res = fdt_property(fdt, "reg", reg, sizeof(reg));
>       if ( res )
>           return res;
>   
> -    set_interrupt(intr, GUEST_VPL011_SPI, 0xf, DT_IRQ_TYPE_LEVEL_HIGH);
> +    set_interrupt(intr, d->arch.vpl011.virq, 0xf, DT_IRQ_TYPE_LEVEL_HIGH);
>   
>       res = fdt_property(fdt, "interrupts", intr, sizeof (intr));
>       if ( res )
> @@ -3083,6 +3087,14 @@ static int __init construct_domU(struct domain *d,
>               allocate_static_memory(d, &kinfo, node);
>       }
>   
> +    /*
> +     * Base address and irq number are needed when creating vpl011 device
> +     * tree node in prepare_dtb_domU, so initialization on related variables
> +     * shall be dealt firstly.
> +     */
> +    if ( kinfo.vpl011 )
> +        rc = domain_vpl011_init(d, NULL);
> +
>       rc = prepare_dtb_domU(d, &kinfo);
>       if ( rc < 0 )
>           return rc;
> @@ -3091,9 +3103,6 @@ static int __init construct_domU(struct domain *d,
>       if ( rc < 0 )
>           return rc;
>   
> -    if ( kinfo.vpl011 )
> -        rc = domain_vpl011_init(d, NULL);
> -
>       return rc;
>   }
>   
> @@ -3132,15 +3141,33 @@ void __init create_domUs(void)
>   
>           if ( !dt_property_read_u32(node, "nr_spis", &d_cfg.arch.nr_spis) )
>           {
> +            unsigned int vpl011_virq = GUEST_VPL011_SPI;
> +
>               d_cfg.arch.nr_spis = gic_number_lines() - 32;
>   
> +            /*
> +             * The VPL011 virq is GUEST_VPL011_SPI, unless direct-map in
> +             * set, in which case we'll try to match the hardware.

I think you want to drop "try" to avoid implying there is a fallback if 
we can't match it.

> +             *
> +             * Typically, d->arch.vpl011.virq has the vpl011 irq number
> +             * but at this point of the boot sequence it is not
> +             * initialized yet.
The last paragraph is difficult to read. We are building the domain (not 
booting!) and at this point we are still trying to figure out its 
initial configuration. IOW, the domain is not even created.

I think it would be better to say the domain is not built. So we need to 
open-code the logic to find the vIRQ. We should also probably mention 
that the logic should match the one in domain_vpl011_init().

> +             */
> +            if ( d_cfg.flags & XEN_DOMCTL_CDF_directmap )
> +            {
> +                vpl011_virq = serial_irq(SERHND_DTUART);
> +                if ( vpl011_virq < 0 )
> +                    panic("Error getting IRQ number for this serial port %d\n",
> +                          SERHND_DTUART);
> +            }
> +
>               /*
>                * vpl011 uses one emulated SPI. If vpl011 is requested, make
>                * sure that we allocate enough SPIs for it.
>                */
>               if ( dt_property_read_bool(node, "vpl011") )
>                   d_cfg.arch.nr_spis = MAX(d_cfg.arch.nr_spis,
> -                                         GUEST_VPL011_SPI - 32 + 1);
> +                                         vpl011_virq - 32 + 1);
>           }
>   
>           /*
> diff --git a/xen/arch/arm/vpl011.c b/xen/arch/arm/vpl011.c
> index 895f436cc4..2de59e584d 100644
> --- a/xen/arch/arm/vpl011.c
> +++ b/xen/arch/arm/vpl011.c
> @@ -29,6 +29,7 @@
>   #include <xen/mm.h>
>   #include <xen/sched.h>
>   #include <xen/console.h>
> +#include <xen/serial.h>
>   #include <public/domctl.h>
>   #include <public/io/console.h>
>   #include <asm/pl011-uart.h>
> @@ -71,11 +72,11 @@ static void vpl011_update_interrupt_status(struct domain *d)
>        * status bit has been set since the last time.
>        */
>       if ( uartmis & ~vpl011->shadow_uartmis )
> -        vgic_inject_irq(d, NULL, GUEST_VPL011_SPI, true);
> +        vgic_inject_irq(d, NULL, vpl011->virq, true);
>   
>       vpl011->shadow_uartmis = uartmis;
>   #else
> -    vgic_inject_irq(d, NULL, GUEST_VPL011_SPI, uartmis);
> +    vgic_inject_irq(d, NULL, vpl011->virq, uartmis);
>   #endif
>   }
>   
> @@ -347,7 +348,8 @@ static int vpl011_mmio_read(struct vcpu *v,
>                               void *priv)
>   {
>       struct hsr_dabt dabt = info->dabt;
> -    uint32_t vpl011_reg = (uint32_t)(info->gpa - GUEST_PL011_BASE);
> +    uint32_t vpl011_reg = (uint32_t)(info->gpa -
> +                                     v->domain->arch.vpl011.base_addr);
>       struct vpl011 *vpl011 = &v->domain->arch.vpl011;
>       struct domain *d = v->domain;
>       unsigned long flags;
> @@ -430,7 +432,8 @@ static int vpl011_mmio_write(struct vcpu *v,
>                                void *priv)
>   {
>       struct hsr_dabt dabt = info->dabt;
> -    uint32_t vpl011_reg = (uint32_t)(info->gpa - GUEST_PL011_BASE);
> +    uint32_t vpl011_reg = (uint32_t)(info->gpa -
> +                                     v->domain->arch.vpl011.base_addr);
>       struct vpl011 *vpl011 = &v->domain->arch.vpl011;
>       struct domain *d = v->domain;
>       unsigned long flags;
> @@ -626,6 +629,43 @@ int domain_vpl011_init(struct domain *d, struct vpl011_init_info *info)
>       if ( vpl011->backend.dom.ring_buf )
>           return -EINVAL;
>   

I would suggest to add a comment similar to the first paragraph you 
added in create_domUs(). In addition to that, it would be good to 
mention the code should stay in sync with the one in create_domUs().

> +    if ( is_domain_direct_mapped(d) )
> +    {
> +        const struct vuart_info *uart = serial_vuart_info(SERHND_DTUART);
> +        int vpl011_irq = serial_irq(SERHND_DTUART);
> +
> +        /*
> +         * Since the PL011 we emulate for the guest requires a 4KB region,
> +         * and on some Hardware (IIRC pine64), the UART MMIO region is
In fact, this is an issue that seems to be common on (old?) sunxi SoC. I 
would suggest to replace the (...) with (e.g. on some sunxi SoC).

> +         * less than 4KB, in which case, there may exist multiple devices
> +         * within the same 4KB region, here adds the following check to
> +         * prevent potential known pitfalls
> +         */
> +        if ( uart->size < GUEST_PL011_SIZE )
> +        {
> +            printk(XENLOG_ERR
> +                   "The hardware UART region is smaller than GUEST_PL011_SIZE, impossible to emulate on direct-map guests.\n");

s/on/it for/ I believe.

But i am not sure it is worth mentionning that we can't emulate it. This 
is sort of implied by the fact this returns an error. So how about:

vpl011: Can't re-use the Xen UART MMIO region as it is too small.

Note that I mention "Xen" rather than "HW" because there might be 
multiple uart on platforms. So I feel "Xen" might make it clearer which 
one we are referring to.

> +            return -EINVAL;
> +        }
> +
> +        if ( uart != NULL && vpl011_irq > 0 )

You are checking uart is not-NULL here but just before you dereference 
it. So shouldn't you move the check earlier?

> +        {
> +            vpl011->base_addr = uart->base_addr;
> +            vpl011->virq = vpl011_irq;
> +        }
> +        else
> +        {
> +            printk(XENLOG_ERR
> +                   "Unable to reuse physical UART address and irq for vPL011 on direct-mapped domain.\n");

In this case how about:

vpl011: Unable to re-use the Xen UART information

> +            return -EINVAL;
> +        }
> +    }
> +    else
> +    {
> +        vpl011->base_addr = GUEST_PL011_BASE;
> +        vpl011->virq = GUEST_VPL011_SPI;
> +    }
> +
>       /*
>        * info is NULL when the backend is in Xen.
>        * info is != NULL when the backend is in a domain.
> @@ -661,7 +701,7 @@ int domain_vpl011_init(struct domain *d, struct vpl011_init_info *info)
>           }
>       }
>   
> -    rc = vgic_reserve_virq(d, GUEST_VPL011_SPI);
> +    rc = vgic_reserve_virq(d, vpl011->virq);
>       if ( !rc )
>       {
>           rc = -EINVAL;
> @@ -673,12 +713,12 @@ int domain_vpl011_init(struct domain *d, struct vpl011_init_info *info)
>       spin_lock_init(&vpl011->lock);
>   
>       register_mmio_handler(d, &vpl011_mmio_handler,
> -                          GUEST_PL011_BASE, GUEST_PL011_SIZE, NULL);
> +                          vpl011->base_addr, GUEST_PL011_SIZE, NULL);
>   
>       return 0;
>   
>   out2:
> -    vgic_free_virq(d, GUEST_VPL011_SPI);
> +    vgic_free_virq(d, vpl011->virq);
>   
>   out1:
>       if ( vpl011->backend_in_domain )
> diff --git a/xen/include/asm-arm/vpl011.h b/xen/include/asm-arm/vpl011.h
> index e6c7ab7381..c09abcd7a9 100644
> --- a/xen/include/asm-arm/vpl011.h
> +++ b/xen/include/asm-arm/vpl011.h
> @@ -53,6 +53,8 @@ struct vpl011 {
>       uint32_t    uarticr;        /* Interrupt clear register */
>       uint32_t    uartris;        /* Raw interrupt status register */
>       uint32_t    shadow_uartmis; /* shadow masked interrupt register */
> +    paddr_t     base_addr;
> +    unsigned int virq;
>       spinlock_t  lock;
>       evtchn_port_t evtchn;
>   };
> 

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Oct 20 11:45:35 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Oct 2021 11:45:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.213867.372219 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdA2F-0006qV-1j; Wed, 20 Oct 2021 11:45:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 213867.372219; Wed, 20 Oct 2021 11:45:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdA2E-0006qO-V1; Wed, 20 Oct 2021 11:45:30 +0000
Received: by outflank-mailman (input) for mailman id 213867;
 Wed, 20 Oct 2021 11:45:29 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=jFZ1=PI=suse.com=jgross@srs-us1.protection.inumbo.net>)
 id 1mdA2D-0006qI-GS
 for xen-devel@lists.xenproject.org; Wed, 20 Oct 2021 11:45:29 +0000
Received: from smtp-out2.suse.de (unknown [195.135.220.29])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id fdbb9b73-9318-4109-9492-cdc126991f55;
 Wed, 20 Oct 2021 11:45:28 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id A3F371FDA0;
 Wed, 20 Oct 2021 11:45:27 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 2687613AFE;
 Wed, 20 Oct 2021 11:45:27 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id n5J5B1cBcGGyRQAAMHmgww
 (envelope-from <jgross@suse.com>); Wed, 20 Oct 2021 11:45:27 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fdbb9b73-9318-4109-9492-cdc126991f55
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1634730327; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=MfMr7xDgBMORSAcevQGXNZhMVrmu5n8C9a6uNTYGF8A=;
	b=GXUImd9sI+V1t42XbQtAf9oU+G2aVeUFZxpxso0Sozxdji3HfoRjDqQXseDjjraIy7OKKg
	zkyDb0nFlt0SlTjJRyP4Wb8LmgRbDmV7z5drADVDBGuXwDAs/njLoO46hGk+YTC4Bskz6A
	RmGT8iFjO/OXMb2BwAPAB0zLjSC20no=
To: Jan Beulich <jbeulich@suse.com>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>
Cc: Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Anthony PERARD <anthony.perard@citrix.com>,
 Christian Lindig <christian.lindig@citrix.com>, David Scott
 <dave@recoil.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 xen-devel@lists.xenproject.org
References: <20210922082123.54374-1-roger.pau@citrix.com>
 <20210922082123.54374-3-roger.pau@citrix.com>
 <f5564634-5f9e-0b94-f73a-d44ae65c30f4@suse.com>
 <0b58667f-b6bc-d5b5-2dd1-0c8996367319@suse.com>
 <YW/NipJMLH0Zz05s@MacBook-Air-de-Roger.local>
 <a3d9388a-e2f5-76aa-d51a-2d74afb92bbd@suse.com>
From: Juergen Gross <jgross@suse.com>
Subject: Re: [PATCH v2 2/6] gnttab: allow setting max version per-domain
Message-ID: <19c25cbf-8697-b970-91e5-195f07a5222a@suse.com>
Date: Wed, 20 Oct 2021 13:45:26 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <a3d9388a-e2f5-76aa-d51a-2d74afb92bbd@suse.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="1fkSp4VMzBO8cyJHSkWawTmj7a6yPzO6V"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--1fkSp4VMzBO8cyJHSkWawTmj7a6yPzO6V
Content-Type: multipart/mixed; boundary="YevP9PZvckMQptO720Ak6QVp5z6Y1P2Ix";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Jan Beulich <jbeulich@suse.com>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>
Cc: Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Anthony PERARD <anthony.perard@citrix.com>,
 Christian Lindig <christian.lindig@citrix.com>, David Scott
 <dave@recoil.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 xen-devel@lists.xenproject.org
Message-ID: <19c25cbf-8697-b970-91e5-195f07a5222a@suse.com>
Subject: Re: [PATCH v2 2/6] gnttab: allow setting max version per-domain
References: <20210922082123.54374-1-roger.pau@citrix.com>
 <20210922082123.54374-3-roger.pau@citrix.com>
 <f5564634-5f9e-0b94-f73a-d44ae65c30f4@suse.com>
 <0b58667f-b6bc-d5b5-2dd1-0c8996367319@suse.com>
 <YW/NipJMLH0Zz05s@MacBook-Air-de-Roger.local>
 <a3d9388a-e2f5-76aa-d51a-2d74afb92bbd@suse.com>
In-Reply-To: <a3d9388a-e2f5-76aa-d51a-2d74afb92bbd@suse.com>

--YevP9PZvckMQptO720Ak6QVp5z6Y1P2Ix
Content-Type: multipart/mixed;
 boundary="------------5EF8B48D71E8C3FA94A7414B"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------5EF8B48D71E8C3FA94A7414B
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 20.10.21 12:57, Jan Beulich wrote:
> On 20.10.2021 10:04, Roger Pau Monn=C3=A9 wrote:
>> On Fri, Oct 15, 2021 at 11:48:33AM +0200, Jan Beulich wrote:
>>> On 15.10.2021 11:39, Jan Beulich wrote:
>>>> On 22.09.2021 10:21, Roger Pau Monne wrote:
>>>>> --- a/xen/include/public/domctl.h
>>>>> +++ b/xen/include/public/domctl.h
>>>>> @@ -87,14 +87,22 @@ struct xen_domctl_createdomain {
>>>>>       /*
>>>>>        * Various domain limits, which impact the quantity of resour=
ces
>>>>>        * (global mapping space, xenheap, etc) a guest may consume. =
 For
>>>>> -     * max_grant_frames and max_maptrack_frames, < 0 means "use th=
e
>>>>> -     * default maximum value in the hypervisor".
>>>>> +     * max_grant_frames, max_maptrack_frames and max_gnttab_versio=
n < 0
>>>>> +     * means "use the default maximum value in the hypervisor".
>>>>>        */
>>>>>       uint32_t max_vcpus;
>>>>>       uint32_t max_evtchn_port;
>>>>>       int32_t max_grant_frames;
>>>>>       int32_t max_maptrack_frames;
>>>>>  =20
>>>>> +/* Grant version, use low 4 bits. */
>>>>> +#define XEN_DOMCTL_GRANT_version_mask    0xf
>>>>> +#define XEN_DOMCTL_GRANT_version_default 0xf
>>>>> +
>>>>> +#define XEN_DOMCTLGRANT_MAX XEN_DOMCTL_GRANT_version_mask
>>>>> +
>>>>> +    uint32_t grant_opts;
>>>>
>>>> As it now seems unlikely that this will make 4.16, please don't forg=
et
>>>> to bump the interface version for 4.17. With that and preferably wit=
h
>>>> the nit above addressed, hypervisor parts:
>>>> Reviewed-by: Jan Beulich <jbeulich@suse.com>
>>>
>>> Actually no, I'm afraid there is an issue with migration: If the tool=

>>> stack remembers the "use default" setting and hands this to the new
>>> host, that host's default may be different from the source host's. It=

>>> is the effective max-version that needs passing on in this case, whic=
h
>>> in turn requires a means to obtain the value.
>>
>> Hm, my thinking was that the admin (or a higer level orchestration
>> tool) would already have performed the necessary adjustments to assert=

>> the environments are compatible.
>=20
> I don't think we can rely on this in the hypervisor. We may take this
> as a prereq for proper working, but I think we ought to detect
> violations and report errors in such a case.
>=20
>> This problem already exist today where you can migrate a VM from a
>> host having the max default grant version to one having
>> gnttab=3Dmax-ver:1 without complains.
>=20
> Are you sure about "without complaints"? What would a guest do if it
> expects to be able to use v2, since it was able to on the prior host?

A Linux guest should "just work". On resume it is setting up the grant
interface again like on boot (in fact there is one difference: the
number of grant frames is kept from before suspending).

Guest transparent migration wouldn't work in such a case, and I have no
idea how other OS's will react.


Juergen

--------------5EF8B48D71E8C3FA94A7414B
Content-Type: application/pgp-keys;
 name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Transfer-Encoding: quoted-printable
Content-Description: OpenPGP public key
Content-Disposition: attachment;
 filename="OpenPGP_0xB0DE9DD628BF132F.asc"

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy=
cWx
w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O=
f8Z
d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y=
9bf
IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq=
G7/
377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR=
3Jv
c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA=
QIe
AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT=
hpw
dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0=
MbD
1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv=
oPH
Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v=
5QL
+qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ=
2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC=
QoL
BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr=
Wf0
teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC=
/nu
AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh=
ITT
d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm=
XBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz=
80h
SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC=
AcD
AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn=
FOX
gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1=
jnD
kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0=
N51
N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l=
otu
fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1=
tqS
EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA=
hsD
BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3=
g3O
ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5=
dM7
wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5=
D+j
LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm=
V2x
AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N=
Eaw
QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW=
nHI
s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR=
wgn
BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV=
bVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk=
pEd
IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA=
QAB
wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw=
Tbe
8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1=
vJz
Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8=
VGi
wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW=
svi
uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX=
zXs
ZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------5EF8B48D71E8C3FA94A7414B--

--YevP9PZvckMQptO720Ak6QVp5z6Y1P2Ix--

--1fkSp4VMzBO8cyJHSkWawTmj7a6yPzO6V
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmFwAVYFAwAAAAAACgkQsN6d1ii/Ey8J
yAf/RtkZFRGaZ/EK/IpeWaI3zct6cbONzlP4gmVKSPqG6tBTT7SoR0IyELeDOYsRnOggSBXxVizB
m2je4zOMN29inwU5aTguKGCom194fzjyZDK+u9dabO0TG1B5gOGNkFfqPDCIU0S+48Ntw9eu56kT
Wm4KB6Xc5SP6q74fZaHc3SzX03y4MFS1mJ0sOg3qQor/VLTNFPLcWOhLv9SplgBRCyU7hyoPCd/o
/n4RdLyJhV57/B4qXfPq0FuQUJRlYnrkJ136UrfH/eul9fPTaPMsZA0ad2EcY1swGVGkXTublXQe
BsgPVpxFV6JLy9Azv/SRwKYW0A0cw6ep+Kupgse5LQ==
=pDl9
-----END PGP SIGNATURE-----

--1fkSp4VMzBO8cyJHSkWawTmj7a6yPzO6V--


From xen-devel-bounces@lists.xenproject.org Wed Oct 20 11:52:13 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Oct 2021 11:52:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.213874.372230 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdA8f-0008ES-Qn; Wed, 20 Oct 2021 11:52:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 213874.372230; Wed, 20 Oct 2021 11:52:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdA8f-0008EL-M6; Wed, 20 Oct 2021 11:52:09 +0000
Received: by outflank-mailman (input) for mailman id 213874;
 Wed, 20 Oct 2021 11:52:08 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=TQMG=PI=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mdA8e-0008EF-Ai
 for xen-devel@lists.xenproject.org; Wed, 20 Oct 2021 11:52:08 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 25f9f200-319c-11ec-8342-12813bfff9fa;
 Wed, 20 Oct 2021 11:52:07 +0000 (UTC)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2105.outbound.protection.outlook.com [104.47.17.105])
 (Using TLS) by relay.mimecast.com with ESMTP id
 de-mta-9-6480qJJ3M-CVsW5LWVe9kA-2; Wed, 20 Oct 2021 13:52:05 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB5165.eurprd04.prod.outlook.com (2603:10a6:803:54::25)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16; Wed, 20 Oct
 2021 11:52:01 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.018; Wed, 20 Oct 2021
 11:52:01 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6P194CA0025.EURP194.PROD.OUTLOOK.COM (2603:10a6:209:90::38) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4628.16 via Frontend Transport; Wed, 20 Oct 2021 11:52:00 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 25f9f200-319c-11ec-8342-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634730726;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=lGPL/IRaH2ccLAhb1RGNNka/d44nqp8OCq1bQpX997s=;
	b=EuMMf4IU8Q8vyiPPCMvZ40Cs/og3715zRVIFqL3Kwgz08DYW9DD0cfP7A9+B/vFgSOETU8
	X1TiWefqjALlMERT5i44Et4iiJENQHoLF+3Ty7lWR/EfA3qsWbihFgdWEPAtahRHLVs4NM
	LD9qu7+L8DnCa0kbN2/c+FF+NxzyTR4=
X-MC-Unique: 6480qJJ3M-CVsW5LWVe9kA-2
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=flBHUXrtuHJSzVTKVOoiziNl5Nj+w1aRWH1SX5TTuwMVg0C6pMBV10Hy9SHKT5wDMyUn6ytXOGYXj1XhQrMs4Nox/ezhKC6zh/Ta9i6MkCDDZydzMEfCjT+gQuxLldu3OarUfsiMTqUROtnJLh2zZsUMbAflVUDfJ4iOnuATlE6/NVE3alJ1bI7CcaHZRX1sT065dYkb7AytAvKZzQKeuhMymF/u9jY8XDcYDAgDVRzprlJZxocEbYrZ4xaYkJJPETH2O0EQq0HtJ2Sx/Iana9qeQZ4J1PpvOuASzadRthFlPql8weXA0I+3XYXmdoouldi12GBpT9BcQm5rMLTBjg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=nIGyADdSfSN+NDJQ+OAxaOrxHI4Tg4Noe6rYwC/Nlys=;
 b=DehL5vgt7GoNi3G2Ie9ooeNhSjCADPXsvXlvucNO1MFocTDi7l49tpsWRvRnWy4EhMdJr3QyyMuu/jJCRD1w6XMJcXj2bNc5BufaVpJfzGgrXzCgIx0eari1QkRDwY0k4zyzFzlVr7/yeLVQ8aYIclvNGEZ7+Nu1Qv66H6cCZTsT/vHY9SCLxPC6OdX8wZ5GMtIOhbSY02xapPIu4nDiJ2xUG3jU3LNbfeCR5+63cXmvJiXICN7H/kQOFv9ERu9ezQAnuZFceYyF0L5otnP58qWfHgyvVlDV3z384eyAka51LAfK5WT71lPeNS+2DRb2dSNGO3o577V2BMYbrGcjVQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [PATCH v2 3/6] gnttab: allow per-domain control over transitive
 grants
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Anthony PERARD <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>,
 Christian Lindig <christian.lindig@citrix.com>, David Scott
 <dave@recoil.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 xen-devel@lists.xenproject.org
References: <20210922082123.54374-1-roger.pau@citrix.com>
 <20210922082123.54374-4-roger.pau@citrix.com>
 <1d741841-6aaf-1d33-e1c6-b98f77ce41fb@suse.com>
 <YW/r6Dk5a79myhzy@MacBook-Air-de-Roger.local>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <dc514908-a1a9-7ce1-5490-16be3f8c74a2@suse.com>
Date: Wed, 20 Oct 2021 13:51:58 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <YW/r6Dk5a79myhzy@MacBook-Air-de-Roger.local>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6P194CA0025.EURP194.PROD.OUTLOOK.COM
 (2603:10a6:209:90::38) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 169bee30-c24a-4bcb-b016-08d993c0070c
X-MS-TrafficTypeDiagnostic: VI1PR04MB5165:
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB5165E973A391F8515F583E8BB3BE9@VI1PR04MB5165.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Tumy2Hd74uszxjz+5dA6KIqt8qBEWC6M58Su1fPrejDZwYIXv6UGmbny3Q7xQhKBcIoHF6qdhAHjhF16Jg8OYcF5D+HbCaIoeJTdZGxj+KbtXfkARgPfSUwI4RnkjzXOmJTzlfquUngA5lOvWpBSlDkOPfeC1yACY0JzI1OklN9fddy2nrkBlT7Sn2DAvW2oXtgDVyQwEPT5T5dVpp3XOJIX2te3YyVyR+1TYrJR6z/3CVFHuEvE56bZjyEI4VDSGseGD+Hclj0PsEvCfIXxCZorFdYV37BdXqj7ytm6Z2EAyGtdh3x1C4ROl6oDmdv4xR9XOEkFtzYj2cgGtRABEwlY+2PUNm73jaFTzu7gf7fTCGZOyaaS9Z6mpeISrStfhGLfj3Dj4T52Fj1xDBbhYK8+8/glltNnp+ldI8Mgl4SKbmnXGtsDY1k1arzk5sU1adZHklW50PqX0L7+nCMYLlAKsGCtx742fCYYDn7QA7aYsjMOV1tx2Xitd/BTSC/RUVapsPJ3jd4A5bnKJjcFJimT0AvFi5WMcI9ZKTU0KQBpQjNJ+IO53K0NzSA7xNoXUf8/ScbKLjJNTbG882gWElpizc8ANc0pEwYTDEOOSt4engLrWJjGun+joyvS3PkncDPAsO9oBD5tF44pIYnti1lz0z6IrWBALjEyCyKOHgIYqn8KwpRZa/SZwycRivw+uIStUx2SOE//cA7nm83a95ZIXlZ2r/SDIVgAsC8RvUxGU/2oUUgHnom2HmrtUZ5x
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(2906002)(38100700002)(5660300002)(83380400001)(66476007)(66946007)(54906003)(316002)(16576012)(66556008)(86362001)(4326008)(508600001)(6486002)(2616005)(956004)(26005)(8936002)(53546011)(8676002)(6916009)(186003)(31686004)(36756003)(31696002)(7416002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?H8dKQzwxWQ/0ch0Az7lOKMYuJjcj4ja8EpxPdQtygIi3fJ/kO03tyaLii7Hi?=
 =?us-ascii?Q?ZDRyQHqZD3etcOCWmTy+6oYef2k668B1c5Ua9t9sciqJZUDEHs9bE0S06QK8?=
 =?us-ascii?Q?vP326WD21ZK5cXle+Im6tIi9OC6aGXh5yGXR5aYgUMZsnggdP3YTflvA7c19?=
 =?us-ascii?Q?fnsuudpqt8x/HThDc/6wFDLfi40RKv/pamgZ03PrcM5EhYV3o2PRfEmRD9h5?=
 =?us-ascii?Q?5FqG/xBhCplKNooiBbog/o18tB7BRabvobab8tNrGapndXtV+BQyHUSPcCEm?=
 =?us-ascii?Q?0w0IcyNKfAxTg+EZWxXZLrwDMnAD/+49d3Gmh9oCn13Z5/3fDCndZtrvvbmO?=
 =?us-ascii?Q?FOC9GpdqTJ25QlaWTPmecenVsIZpkEiXIOvUbZE73piOAKcEjfEpWRA0ufi/?=
 =?us-ascii?Q?Ml1mLQN7xYvheH41+2mdHPFGhkS42wS/ZR6OfnkHo7uY/BNkqepIEShh1YR0?=
 =?us-ascii?Q?EgJOofHf57nzX5Jk8iJuOWr3qxhZQkk/VTDypRVN/LVuJ6EsC6MCkPeSAZus?=
 =?us-ascii?Q?AHaoBTN/2NMCis5MpO5A/MkiZ4SnsZnaGpZ1FB1E5GU67OBBM8KxiXWLxYnS?=
 =?us-ascii?Q?LdRyuyTcMnWKFhuyzPoNftJgHzhrX6586j0/vfR+nUwo94hb5GC99Ba4J6oA?=
 =?us-ascii?Q?ggJwvtsdT0T2ZI5iDXwRviwVTfc76wk6i7OrNguE0E0NZhzmtmX2PNWLI1lh?=
 =?us-ascii?Q?LRFwLA7k+xEU9tREL4YVXVTda6jQGdIjsq2ZhoqLrXnifB0OuVowzd8NDOR8?=
 =?us-ascii?Q?bzJnlBdfjfAAdIlYrM5xi38KNSiBICC9rIAfE9bFs1ZIO8nITIzkYCpIqsHv?=
 =?us-ascii?Q?7pzQVKBiMbwwJWtciGM3TcVgTD3swn2sVMEadwfw+qSgNPOCWp+nY+5fEQEm?=
 =?us-ascii?Q?jxzkwv47Vy2nfsgtqSPCL2By31bYgK3CYVcQsDv0s2LTsPW4RPEm4fsBjczC?=
 =?us-ascii?Q?YOxq+dPQVzHhf6bcISYhufGV6L78p0Qwctz+tdoM4GXVOkumptVZzbSAgWpQ?=
 =?us-ascii?Q?R8PBms/nvs3c5cK/ta0z4xzJEACO3H3IqTTjn/URZjmVNK0oW5jWV8vj2PQL?=
 =?us-ascii?Q?a/9LrsM4E+EC4cLRyKBs+7gpDPD2a4bG7Gz8lqdoLgAYMW2zO0MOZL2MX+Qh?=
 =?us-ascii?Q?PKxG0cQUmjKqXpPvRLvy56uVXuOHqvhsbXsqIgVIwF/cFhRjvOo+43Qna9Sw?=
 =?us-ascii?Q?gX1fGsJs9LqRpSSS5SgWkEFipfD0VaY1Q/mwxdHb6jqiK7rk01voo1F535dr?=
 =?us-ascii?Q?x2CtkLXZ//mOyDE3Os4YARwFNFmJ6+fjwd2UPyYWW7R6wBLtznAaHsSaSrMb?=
 =?us-ascii?Q?sZl5DmIL+F7Rz0/8PnIWM3cg?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 169bee30-c24a-4bcb-b016-08d993c0070c
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2021 11:52:01.2041
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jbeulich@suse.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5165

On 20.10.2021 12:14, Roger Pau Monn=C3=A9 wrote:
> On Fri, Oct 15, 2021 at 12:05:06PM +0200, Jan Beulich wrote:
>> On 22.09.2021 10:21, Roger Pau Monne wrote:
>>> --- a/xen/arch/x86/setup.c
>>> +++ b/xen/arch/x86/setup.c
>>> @@ -750,7 +750,8 @@ static struct domain *__init create_dom0(const modu=
le_t *image,
>>>          .max_evtchn_port =3D -1,
>>>          .max_grant_frames =3D -1,
>>>          .max_maptrack_frames =3D -1,
>>> -        .grant_opts =3D XEN_DOMCTL_GRANT_version_default,
>>> +        .grant_opts =3D XEN_DOMCTL_GRANT_version_default |
>>> +                      XEN_DOMCTL_GRANT_transitive,
>>>          .max_vcpus =3D dom0_max_vcpus(),
>>>          .arch =3D {
>>>              .misc_flags =3D opt_dom0_msr_relaxed ? XEN_X86_MSR_RELAXED=
 : 0,
>>
>> While I can see that you make these adjustments for retaining backwards
>> compatibility, I wonder if we need to, at least for Dom0. Dom0 doesn't
>> normally grant anything anyway and hence would even less so use
>> transitive grants. Of course then there's need to be a command line
>> control to re-enable that, just in case.
>=20
> dom0=3Dgnttab-transitive, or should it be placed somewhere else?

That sounds like the place to have it at; at least that's where I would
have suggested to put it. One question of course is how it ought to
interact with v2 being unavailable.

>>> @@ -1965,6 +1969,8 @@ int grant_table_init(struct domain *d, int max_gr=
ant_frames,
>>>      gt->max_grant_frames =3D max_grant_frames;
>>>      gt->max_maptrack_frames =3D max_maptrack_frames;
>>>      gt->max_grant_version =3D max_grant_version;
>>> +    gt->allow_transitive =3D !!(options & XEN_DOMCTL_GRANT_transitive)=
 &&
>>> +                           opt_transitive_grants;
>>
>> No need for !! here afaics. Not even if there weren't the &&.
>>
>> As to combining with the global option: I think if an admin requested
>> them for a domain, this should overrule the command line option. Which
>> in turn suggests that the command line option could go away at this
>> point. Otherwise, if you AND both together and the guest is known to
>> not work without this functionality, domain creation would instead
>> better fail (or at the very least it should be logged by the tool
>> stack that the request wasn't satisfied, which would require a means
>> to retrieve the effective setting). IOW I would see the command line
>> turning this off to trump the per-guest enabling request.
>=20
> How should we go about deprecating it? It would be a bit antisocial
> IMO to just drop the option, since people using it would then be
> exposed to guests using transient grants if they didn't realize it
> should be set in xl.conf or xl.cfg now.

So perhaps for a transitional phase fail if the command line option
says no and the request for the guest says yes? Accompanied by a
log message warning that the command line control is going to go
away, so that people will know to adjust their guest configs?

Jan



From xen-devel-bounces@lists.xenproject.org Wed Oct 20 11:59:16 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Oct 2021 11:59:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.213883.372241 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdAFR-0000Xn-LF; Wed, 20 Oct 2021 11:59:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 213883.372241; Wed, 20 Oct 2021 11:59:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdAFR-0000Xg-Hh; Wed, 20 Oct 2021 11:59:09 +0000
Received: by outflank-mailman (input) for mailman id 213883;
 Wed, 20 Oct 2021 11:59:08 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=TQMG=PI=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mdAFQ-0000Xa-DU
 for xen-devel@lists.xenproject.org; Wed, 20 Oct 2021 11:59:08 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 76bda02b-777a-4a26-aeb2-c5fbd14d2158;
 Wed, 20 Oct 2021 11:59:07 +0000 (UTC)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2052.outbound.protection.outlook.com [104.47.14.52]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-30-JOG3K-aBNTaA7zaCglP0ww-1; Wed, 20 Oct 2021 13:59:05 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB6174.eurprd04.prod.outlook.com (2603:10a6:803:fa::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.17; Wed, 20 Oct
 2021 11:59:01 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4608.018; Wed, 20 Oct 2021
 11:59:01 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM5P194CA0012.EURP194.PROD.OUTLOOK.COM (2603:10a6:203:8f::22) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4628.16 via Frontend Transport; Wed, 20 Oct 2021 11:59:00 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 76bda02b-777a-4a26-aeb2-c5fbd14d2158
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634731146;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=6oe5YFwzDQBTv4wzm5wrQCTOqf6iST7DQnCBGT4XuHM=;
	b=bKVuqcSfAe1EUjiGaUo7GJ3wobQPGrbUghSSaOflKte3j3oPFpgMdiYYlLylYWfpzWs/j4
	9/e0iOaks9B2EnKeWqiVQlRMH4G9e+XmWMhjrj9Z36qbpSAZEeIfmU1ISaJ4N9dplAsQNc
	P8VaQNpJsj6T9LD6+uc5eV1XdSQ0hxs=
X-MC-Unique: JOG3K-aBNTaA7zaCglP0ww-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=aZrYCXklGM8ynuGUrO4LJxV4GxMPVVAe8wxZftN1B9kCU0TzHAuv1SV0e+5wLKYLQDidJo+9uu2NPFQwxLJxBHo3cvwZRCiYA0i46sKs4BnwvmRAZwJxQJJak+nWgzGvDRpWa/VE+J9eUjJ94h9O8s8J49MrFxPSMTwObgS4x6MR0n8DiQojXcpQKO/IqB0BOJqKJSv791GW0hd8+Eo/PMI8oyKWo0RNspMmWYqJ2RC7vj3bVSnJerCwaSFRX2CJVrjNmz9J2JTXZkQ811DMoiE8EsMpVi4C1eSbW/Xpj7ATEEI30w4ky4eh95uN4j0gGzfscnoyb4YEntQT2TotmA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=6oe5YFwzDQBTv4wzm5wrQCTOqf6iST7DQnCBGT4XuHM=;
 b=Rr25lw58aliCWrbtUJZvYa4m7MRuPqiaVWZ2QMS3lnKdifwJd+iZoR5HZa2I33xxUKUjbei7o2saP1I5dVuH0hT3fhQ2tZwPwjl2bXlX5sn2qF2yT07Ahcvlk49cnHD4OU3Nzgz/lYS8FiSqnLyqA9BjIFThCIaBV3DjElJlDZTo7Gn5hlRWsAynBtPDwcLvdye1/495SdjbYOZE54eSHuXjw5ZH3W3dkHA887eargpREs/oTovapHuNdaeC1Uo6GwW4+MvBfwb1OB7FsWeTixqvytF1Kuz1mItcXBOKVtQ6zJatgbfE0XfdmOVcbY/R9lrlnM2etqFutcqvcqtOmQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [PATCH v2 2/6] gnttab: allow setting max version per-domain
To: Roger Pau Monne <roger.pau@citrix.com>
Cc: Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Anthony PERARD <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>,
 Christian Lindig <christian.lindig@citrix.com>, David Scott
 <dave@recoil.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 xen-devel@lists.xenproject.org
References: <20210922082123.54374-1-roger.pau@citrix.com>
 <20210922082123.54374-3-roger.pau@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <0fddbb3a-bf7e-2a39-e20e-7994b3d74d2f@suse.com>
Date: Wed, 20 Oct 2021 13:58:59 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <20210922082123.54374-3-roger.pau@citrix.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM5P194CA0012.EURP194.PROD.OUTLOOK.COM
 (2603:10a6:203:8f::22) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 8013dc3f-464f-4040-6881-08d993c1019c
X-MS-TrafficTypeDiagnostic: VI1PR04MB6174:
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB6174DDA1024933A6BE2160FCB3BE9@VI1PR04MB6174.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	c4SIU1CAZnI3ewsqBdIdlmk8m7VnBZjEPHGVExCw90k2vSa/fpGNdEG3VcKnhyQzah3k6+FupSX4EDoPJhJXAS05mA1FaMUZGgOR7Bj0jFfPTy4MvN+vnW5U8JlJd7XFloCTKxAkOB6qX6OM6B/i9MQGSGYVKp5D4dvQjz5SSvmqhwzUSqNDda9NyQH3xBNX+Ut4MWiR3WsvpJyKvtJ/TdCZDqWFcADuWZaShbIWFZHYOF1SDFLmIX7/rTmCkxT5t8bnWj8PCXacgVoTZaU3E9U66eRbkbNxV4yxxjFmMir9QxuFSb6OfpnU70KiMiQwmDTLS8d2yaYNaMyybpKJzFZUMePP0R0MA8Us00UqZxEdK6ae4X/g04OsFX+twq7fU+K438tR5TO3lY23sLIewjGAiVOrf1j/Vd9i2Y6RzHUaIO7Psb5f/s13a3kk09Cnd7s+xaIZz4IxpL7CO0Ljag6/ZcE/cltAW21Z5qNBS1iEj8XM6aXU9HuFFo9y+7d3VcFh7CsC3WJErb9O72kfpP8fXRiofzt7hoQvLeeMe1jzuuOtqG16tAXePLLBDQOnY7zkxDmdYFuAdzgAvT36eoOsBCK2Vc20xZKGXG2YAbnkBqZyuB9CyiJgwCxDm+j/00hb13cjcVU9VFfEwAlpJ9y3kqUzfTayYXKRQB0Yq0ZqkgFnqC2CChXjplzX0yPDvpvdIuWctEKFFT/cXXsfyiz/dNv+BUOmolVef5ytgBc=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(86362001)(31686004)(26005)(186003)(6916009)(2906002)(7416002)(83380400001)(66946007)(66556008)(8676002)(31696002)(508600001)(316002)(16576012)(2616005)(6486002)(53546011)(36756003)(8936002)(4744005)(956004)(5660300002)(4326008)(38100700002)(54906003)(66476007)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?TU95SnBBZ0k1TWxvNW5iQkpnSlU2dDdvcmFBbWx5LzNKRnhNVUkwSmxBTURt?=
 =?utf-8?B?QXEra2x3YzJsdU1KVkNjZ1pjM2J2YVBYV21QS21GS2lMZzRWZUxhRFB1cDlw?=
 =?utf-8?B?Yzlma2tQazNhRkMwZXVMZGMrVmdodUxSMHkzQ3h3VW8rc0VNTDlXZW1GMXhh?=
 =?utf-8?B?S1NXTitqNERwVHU3cFVXWjdFSjlRNEZVSlJaOExvQmxpM21YUE9QSk9JN1RY?=
 =?utf-8?B?cjVtVVFBYnNIclpoUXJZbW0vZXNyK25jQWJLUFR0clIwK3pzanRET1VhaVdr?=
 =?utf-8?B?RmJ2cXI4cjJNd2F1SGVSNUNicDAwTWcxU01MRXMwdEY5eXpYNEpsQldtaGZh?=
 =?utf-8?B?aEJGVC8zY1g5Ty83U3BoY2tEcXFvRm5EYlNsMXVWbkM3WGJZVTB3TmFVVVR2?=
 =?utf-8?B?cWtsdTJOVkFJa3YzNW4rSUpJYW9QSUxVOS8wbzZFU3JOSnJ4NTRWeVFzT2xT?=
 =?utf-8?B?ZjI5cjI4UWZMK1pnMTVpV0VyejVsV3FjSkNQUVZiM212bVoyek1tNmFsRlBJ?=
 =?utf-8?B?UFR3YzMzdnFTNW1pZEtXL3IwWC82bWh2cVZ6ZmFCSGlhTk82ZERtL3VkWUtk?=
 =?utf-8?B?YUcvN1h3T2Zld293WFcraVk1SWxxSVV4eDJzMWw4VVJNQlF4SmVEVUZ5Vm5T?=
 =?utf-8?B?YWtuWEZqQ0I5NmM1c2gyeTVHSlJ4TXlldmNvOWp3dWd6NFRYNEJlSTJFUTRn?=
 =?utf-8?B?UlBwRVBiVnVSakhOTWRTRit3Y3h6cGRFVElOYVp1c2hBMTdHT1p3cnhDVzcz?=
 =?utf-8?B?SUhpRGQ0Q3lWdWhkWWNHTVBtbm1hSk9TdnZ5VDdWTi9mbmdLUy85cm9RMEZJ?=
 =?utf-8?B?RUZYWHlrT1p1b25nM2czNlFNMDhYOFpjRVEySDY5MEJTN2hFZG1nc0VNL2xm?=
 =?utf-8?B?Y0VxTEFCQTd2V0gvOFlXcEZ1NXdJSlVJVkRIY0p1am5qZWt2czdVcmw2N2gw?=
 =?utf-8?B?N3lBKzBURlZSSU9NRDFaalF6UjhaZnltbm1UbG5wL2huYlJ0Tm9LZVZIWUwv?=
 =?utf-8?B?ZUJzMDRvUWZ2QWJVS01SeXd5SmhGR0tmZlBDVnhaamxBbm1HSUEyMFhCWWVY?=
 =?utf-8?B?SWR4TkRtaGZCdkxRM0tKN2dkMEJiVWdlbVl5YnFTTTlJQnRmcW8wK2pmbkRO?=
 =?utf-8?B?Tmd4eVhJOElrS2dERDk4VlQ0ZWcrd05iK3lFQmRiWlZXc1NXajRFYWdvMy9u?=
 =?utf-8?B?V3R4T3RUWnRmbTAyMkY2REJuWWYxaG9uMmRDd3FPOUZGS1ZJZEo5VXR3OFBT?=
 =?utf-8?B?OGQ0RVM3V1JXVld6NmF1NUpOZGVyOGgxV2RhZW1pSXUzSVZVVlRaUEN3czcv?=
 =?utf-8?B?dlpKNzNrVEViRlpsREF3U0xHZEl2dXBGdE9zNnBhWUxRRFF5UWhwRzJwNzh6?=
 =?utf-8?B?SUhnTGc5V1dNYTVzL3FqR0g4SmRRZXlKSXZXdDMzVUY0NEZIbVdoWHF5NXZu?=
 =?utf-8?B?OEJDbVIvK2trbVlyTWo1NDhtMFJFOFpZQkkzckNCeW9QaVdybEpEVXVYbmJ3?=
 =?utf-8?B?RzlOclFOcVdrUnJ1dVk5Ly90Z1RpazRGV2ZoekUrYkIrV1FVbnJEREc2YjlD?=
 =?utf-8?B?RGJvY1YwUk8xRmRWa1FWRXMrRklDMUlSSHJ6NUw5cnlrVkZNampENlNJWDdx?=
 =?utf-8?B?VWdNUUlIM0xNWURHWGwxUituQTB0S28yR2pKcm1LWWovYko0bGcvZGZpaHJW?=
 =?utf-8?B?eklxd2duYk5oeUFkNVpOVmVnejVIYUxEbDc4Q1o3RmI5dDRiREVvNEM5STlV?=
 =?utf-8?Q?9DypI2334Chd/6tpSMInfuKgBH5v0OMdwUljxa1?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8013dc3f-464f-4040-6881-08d993c1019c
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2021 11:59:01.5753
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jbeulich@suse.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6174

On 22.09.2021 10:21, Roger Pau Monne wrote:
> Introduce a new domain create field so that toolstack can specify the
> maximum grant table version usable by the domain. This is plumbed into
> xl and settable by the user as max_grant_version.
> 
> Previously this was only settable on a per host basis using the
> gnttab command line option.

One further remark: Already with the command line control is was
questionable in how far people are aware that PV guests may need to
use v2, if the host has memory beyond the 16Tb address boundary. I
wonder whether permitting to restrict to v1 on such hosts isn't
counterproductive. I guess at the very least a warning may want
logging.

Jan



From xen-devel-bounces@lists.xenproject.org Wed Oct 20 12:51:59 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Oct 2021 12:51:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.213898.372252 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdB4J-0006Pd-Qf; Wed, 20 Oct 2021 12:51:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 213898.372252; Wed, 20 Oct 2021 12:51:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdB4J-0006PW-Nb; Wed, 20 Oct 2021 12:51:43 +0000
Received: by outflank-mailman (input) for mailman id 213898;
 Wed, 20 Oct 2021 12:51:42 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Avag=PI=kernel.org=maz@srs-us1.protection.inumbo.net>)
 id 1mdB4I-0006PQ-01
 for xen-devel@lists.xenproject.org; Wed, 20 Oct 2021 12:51:42 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 2fb0b4fb-9cfb-488c-8ad8-de24bb31e1b4;
 Wed, 20 Oct 2021 12:51:40 +0000 (UTC)
Received: from disco-boy.misterjones.org (disco-boy.misterjones.org
 [51.254.78.96])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by mail.kernel.org (Postfix) with ESMTPSA id 44AC060F56;
 Wed, 20 Oct 2021 12:51:40 +0000 (UTC)
Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org)
 by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2)
 (envelope-from <maz@kernel.org>)
 id 1mdB4D-000R4N-Ux; Wed, 20 Oct 2021 13:51:38 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2fb0b4fb-9cfb-488c-8ad8-de24bb31e1b4
Date: Wed, 20 Oct 2021 13:51:37 +0100
Message-ID: <877de7dfl2.wl-maz@kernel.org>
From: Marc Zyngier <maz@kernel.org>
To: Josef Johansson <josef@oderland.se>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
	linux-pci@vger.kernel.org,
	xen-devel <xen-devel@lists.xenproject.org>,
	Jason Andryuk <jandryuk@gmail.com>,
	Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH v2] PCI/MSI: Re-add checks for skip masking MSI-X on Xen PV
In-Reply-To: <5f050b30-fa1c-8387-0d6b-a667851b34b0@oderland.se>
References: <20211019202906.GA2397931@bhelgaas>
	<5f050b30-fa1c-8387-0d6b-a667851b34b0@oderland.se>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue)
 FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1
 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
X-SA-Exim-Connect-IP: 185.219.108.64
X-SA-Exim-Rcpt-To: josef@oderland.se, helgaas@kernel.org, linux-pci@vger.kernel.org, xen-devel@lists.xenproject.org, jandryuk@gmail.com, tglx@linutronix.de
X-SA-Exim-Mail-From: maz@kernel.org
X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false

On Tue, 19 Oct 2021 22:48:19 +0100,
Josef Johansson <josef@oderland.se> wrote:
> 
> From: Josef Johansson <josef@oderland.se>
> 
> 
> PCI/MSI: Re-add checks for skip masking MSI-X on Xen PV
>     
> commit fcacdfbef5a1 ("PCI/MSI: Provide a new set of mask and unmask
> functions") introduce functions pci_msi_update_mask() and 
> pci_msix_write_vector_ctrl() that is missing checks for
> pci_msi_ignore_mask that exists in commit 446a98b19fd6 ("PCI/MSI: Use
> new mask/unmask functions"). Add them back since it is
> causing severe lockups in amdgpu drivers under Xen during boot.
> 
> As explained in commit 1a519dc7a73c ("PCI/MSI: Skip masking MSI-X
> on Xen PV"), when running as Xen PV guest, masking MSI-X is a 
> responsibility of the hypervisor.
> 
> Fixes: fcacdfbef5a1 ("PCI/MSI: Provide a new set of mask and unmask
> functions")
> Suggested-by: Jason Andryuk <jandryuk@gmail.com>
> Signed-off-by: Josef Johansson <josef@oderland.se>
>

[...]

>
> diff --git a/drivers/pci/msi.c b/drivers/pci/msi.c
> index 0099a00af361..355b791e382f 100644
> --- a/drivers/pci/msi.c
> +++ b/drivers/pci/msi.c
> @@ -148,6 +148,9 @@ static noinline void pci_msi_update_mask(struct msi_desc *desc, u32 clear, u32 s
>  	raw_spinlock_t *lock = &desc->dev->msi_lock;
>  	unsigned long flags;
>  
> +	if (pci_msi_ignore_mask || desc->msi_attrib.is_virtual)
> +		return;
> +

I'd rather be consistent, and keep the check outside of
pci_msi_update_mask(), just like we do in __pci_msi_mask_desc().
Something like this instead:

diff --git a/drivers/pci/msi.c b/drivers/pci/msi.c
index 0099a00af361..6c69eab304ce 100644
--- a/drivers/pci/msi.c
+++ b/drivers/pci/msi.c
@@ -420,7 +420,8 @@ static void __pci_restore_msi_state(struct pci_dev *dev)
 	arch_restore_msi_irqs(dev);
 
 	pci_read_config_word(dev, dev->msi_cap + PCI_MSI_FLAGS, &control);
-	pci_msi_update_mask(entry, 0, 0);
+	if (!(pci_msi_ignore_mask || desc->msi_attrib.is_virtual))
+		pci_msi_update_mask(entry, 0, 0);
 	control &= ~PCI_MSI_FLAGS_QSIZE;
 	control |= (entry->msi_attrib.multiple << 4) | PCI_MSI_FLAGS_ENABLE;
 	pci_write_config_word(dev, dev->msi_cap + PCI_MSI_FLAGS, control);

But the commit message talks about MSI-X, and the above is MSI
only. Is Xen messing with the former, the latter, or both?

>  	raw_spin_lock_irqsave(lock, flags);
>  	desc->msi_mask &= ~clear;
>  	desc->msi_mask |= set;
> @@ -181,6 +184,9 @@ static void pci_msix_write_vector_ctrl(struct msi_desc *desc, u32 ctrl)
>  {
>  	void __iomem *desc_addr = pci_msix_desc_addr(desc);
>  
> +	if (pci_msi_ignore_mask || desc->msi_attrib.is_virtual)
> +		return;
> +
>  	writel(ctrl, desc_addr + PCI_MSIX_ENTRY_VECTOR_CTRL);
>  }

I have similar reservations for this one.

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.


From xen-devel-bounces@lists.xenproject.org Wed Oct 20 13:01:17 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Oct 2021 13:01:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.213905.372263 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdBDU-0007sn-OM; Wed, 20 Oct 2021 13:01:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 213905.372263; Wed, 20 Oct 2021 13:01:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdBDU-0007sg-KW; Wed, 20 Oct 2021 13:01:12 +0000
Received: by outflank-mailman (input) for mailman id 213905;
 Wed, 20 Oct 2021 13:01:11 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ou1c=PI=citrix.com=roger.pau@srs-us1.protection.inumbo.net>)
 id 1mdBDT-0007sa-1A
 for xen-devel@lists.xenproject.org; Wed, 20 Oct 2021 13:01:11 +0000
Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id c390bbd7-300a-42ee-924f-8af4b1494312;
 Wed, 20 Oct 2021 13:01:09 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c390bbd7-300a-42ee-924f-8af4b1494312
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1634734868;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=qqlWeo3wdUtdfSxGj9t1Lb1QjdDmBiVPrP9OPsAolxQ=;
  b=c6mCgy8CUCDbjGh/KLw9khKPDy5vFIQsAejWJwzKwnXr0aWx7FkQHT7Y
   qZ3b8zBkg3E+2KooEmBD4snc32AFrUk09kfAHDAFO9YR6WOUyxBRUXpW9
   ieJPmDJ7C9r8xPinoP6VGG+ryVzcplXLV2NIRcvC3sfjmcfgQj3o/NW26
   c=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: YuhvlQ/f7PaRtYvRpOqy5pbqyMtxVA4x2BSWlo8u2NSTM56kRj8RY+CggtPA3sb1Ua2HFrKrih
 FvIKNnubxMwR01FlJ69GbvouErmNx83P6F0LDEJufjAc5sSqfXJjbCaD2ACd6rNNd+UccL//eZ
 WaB69CII4D5EMsjWV0vK6uLyQ20tzStTTz8d5QEHygjSCJZEKT//cMAyQDPkKq2on/B9ewUtVu
 e4FiOLqIOE7cYutg9keMB+Luf4/psLdrlArbB35d/8xzD+hdNrLSRBkTwYKfgfxFaAXRxqGwTx
 ySeCxjifjmxSAJFy2/eTigxi
X-SBRS: 5.1
X-MesageID: 55661904
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:cSFVRqDmU/ZdThVW/3Tlw5YqxClBgxIJ4kV8jS/XYbTApDhzhDAOy
 GpOCm2BPfqDNDOmfoggYY3jp0sG6p/TnNRnQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA
 xA2M4GYRCwMo/u1Si6FatANl1ElvU2zbue6WLGs1hxZH1c+EX5500o7wobVv6Yz6TSHK1LV0
 T/Ni5W31G+Ng1aY5UpNtspvADs21BjDkGtwUm4WPJinj3eH/5UhN7oNJLnZEpfNatI88thW5
 Qr05OrREmvxp3/BAz4++1rxWhVirrX6ZWBihpfKMkQLb9crSiEai84G2PQghUh/jW2Yuf9x7
 vx06oXzDggLO/bFv90dakwNe81+FfUuFL7vJHG+tYqYzlHccmuqyPJrZK00FdRGoKAtWzgIr
 KFGbmBWBvyAr7veLLaTUO5ji95lNMD2FIgepmth3XfSCvNOrZXrHviUu4YJhGtYasZmMqeGQ
 ZsDdRFUQzfCeTFXMGlHFIpltbL97pX4W2IB8w/EzUYt2EDfxRJ8+KLgO93UfpqNX8o9tkSXv
 GXd5EziHwoXcteYzFKt4n+qw+PCgy7/cIYTD6GjsO5nhkWJwW4eAwFQUkG0ydGHjUq5V8NaO
 lYj0CMkpqgv92SmVtD4GRa/pRaspQUAUtBdF+k77gClyafO5QudQG8eQVZpacMknN87QyQw0
 V2ElM+vAiZg2JWXQ3+A8rafrRupJDMYa2QFYEcsTxYB4tTliJE+iFTIVNkLOLGxps34H3f32
 T/ikcQlr+xN14hRjfz9pA2ZxWL3znTUcuIrzgOPT0SK7iVQXdG8JMuny12A5NF5LL/MGzFto
 0M4s8SZ6ekPC7SEmyqMXPgBEdmV2hqVDNHPqQUwR8d5plxB71bmJNoKuGgvey+FJ+5dIWexC
 HI/rz+983O60JGCVqRwf56qQ/ojyaztBLwJvdiFM4IQPPCdmOKBlRyChHJ8PUixzyDAcollY
 P93lPpA615AVcyLKxLtH48gPUcDnHxW+I8qbcmTI+6b+bSffmWJbrwOLUGDaOs0hIvd/l6Jr
 YgOb5HWk0wGOAEbXsUx2dRPRbztBSNjba0aVuQNLrLTSuaYMDBJ5wDtLUMJJNU+wvU9ehbg9
 XChQE5IoGcTdlWcQThmnktLMeu1Nb4m9CpTFXV1YT6AhihyCa7yvfx3X8ZmItEaGBlLkKcco
 w8tIJ7bXJyii13vplwgUHUKhNY8JE/121/WY3DNjfpWV8cIejElM+TMJ2PH3CIPEjC2pY05p
 bih3RncWp0NW0JpC8O+VR5l5wjZUaE1lL0gUk3WDMNUfUmwooFmJzao1q08It0WKAWFzTyfj
 l7EDRAdrOjLgok07NiW2vzU89b3S7NzThhAAm3WzbeqLi2GrGCt9pBNDbSTdjfHWWKqpKj7P
 bdJz+vxOeEslUpRt9YuCK5iyK8zvoO9p7JTwgl+Mm/MalCnVuFpLnWchJEdvaxR3L5J/wCxX
 xvXqNVdPLyIPuLjEUIQe1V5PrjSi6lMl2CLv/ovIUj86Ctmx5a9UB1fb0uWlShQDLppK4d5k
 +0vj9Ebtl6kgR0wP9fY0i0NrzaQLmYNWrkMv40BBNO5kRIiz1xPbMCOCiLy553TOdxAPlNzf
 22RjavGwb9d2lDDYzw4En2UhbhRgpEHuRZryl4eJgvWxoqZ16FvhBABoy4qSgl1zwlc17MhM
 2dmAER5OKGS8mo6n8NERW2tR1lMCRDxFpYdELfVeLk1l3WVa1E=
IronPort-HdrOrdr: A9a23:BNlKhKzUo7s5reiJyJksKrPxtuskLtp133Aq2lEZdPULSKOlfp
 GV8MjziyWYtN9wYhAdcdDpAtjmfZr5z+8O3WB3B8beYOCGghrSEGgG1+XfKlLbak/DH4JmpM
 Jdmu1FeaHN5DtB/LfHCWuDYq8dKbC8mcjC74eurAYccegpUdAZ0+4QMHfkLqQcfnghOXNWLu
 v52iIRzADQBkj/I/7LTEUtbqzmnZnmhZjmaRkJC1oO7xSPtyqh7PrfHwKD1hkTfjtTyfN6mF
 K13zDR1+GGibWW2xXc32jc49B/n8bg8MJKAIiphtIOIjvhpw60bMBKWqGEvhoyvOazgWxa3e
 XkklMFBYBe+nnRdma6rV/E3BTh6i8n7zvYxVqRkRLY0IXEbQN/L/AEqZNScxPf5UZllsp7yr
 h302WQsIcSJQ/cnQzmjuK4Fi1Cpw6Rmz4PgOQTh3tQXc81c7lKt7ES+0tTDdMpAD/60oY6C+
 NjZfusqsq+SWnqLEwxg1MfguBFBh8Ib1K7qwk5y4OoOgFt7TBEJxBy/r1aop8CnKhNPaWsqd
 60dZiAr4s+PPP+W5gNc9vpcfHHeVAlfii8RV56AW6XXJ3vaEi94KIe3t0OlZWXkdozvd0PpK
 g=
X-IronPort-AV: E=Sophos;i="5.87,166,1631592000"; 
   d="scan'208";a="55661904"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=mZxTUurpOWMw2fcbSY8VfcuWrdAmDPqdsw5YKcTlekbM5DA7ZglkizxGLqSQwMY2zmzAb+TdhhUwEhooq8bFtYNf2G76JWtNz9W3BrjZQ14XfQNHSk7g2qGRDr2ctzb6UupslxjfYCXUMK0fBmPnbyUi8ung44mVE5SPfA2UyuRixHQOYsjmdam4UWSlN8k8iglZE9dRPc5qd6Rdns4xPKGBdFPBbqUwD4BQawgSKw7BoJYj2OTScyTsSkSchMgfojG+AJGh4o+nI+GxqhUyvfblHdL/Nvx49fymtOY0JUb/mEPEdFFgCr8C7xF3KhYsgvD+Trv2b4kfwqpbYuB6Zw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=bwkOrM3ew4Uag3S6vuK0AcPabEKLtKuRB2nINxKENyY=;
 b=X9iTmG2q2NGSunmI11tEzy7FItjAeILM/LyNBCvG+yi5RjDVwTrI8BBRlyh7Zk4wRQDfzBTIiINJapThTNc6+FB4cbT8AUOgfdryhM3ZsBp40BNnDhPBtdfazZe0ulpuUWdqM8KLQAFJpqHtjL49EykAwdlx5ImiaeTfpa5PJpy5WBVlaEJbDHIYSqBCYIDW35FmnyGMBFjcPTuMHH5EjQhhcO1SP+zCRloi2t9Rqd686zDZ+3EnG13EEyI80KJ9rivaz8v+Am9X5Pu5yZXKogsmL8UTH5WYqwefINJGMA7JHCgf7JEMIbCbE6+FjsfROcVy/lofyTX+IgQvlP7DCQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=bwkOrM3ew4Uag3S6vuK0AcPabEKLtKuRB2nINxKENyY=;
 b=tBm2AgSvMYuEXwbL5B+hCyVnHbzHdydwgUakdSyEUi5XKu2OVaEZdhS1DfjOhVhRYx7vFWuZGeQgR4gkN/dlZWGRmM04XN4cjJr7Jt6HWgJO+uFnKNjKnonfDIaWQlICgEiuHa8SaX6JiHWNEnrpUEmuTlcwDpuKuzdOYdBDwQ0=
Date: Wed, 20 Oct 2021 15:00:33 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>, Andrew Cooper
	<andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>, Julien
 Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>, Anthony
 PERARD <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>,
	Christian Lindig <christian.lindig@citrix.com>, David Scott
	<dave@recoil.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	<xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v2 2/6] gnttab: allow setting max version per-domain
Message-ID: <YXAS8egv+3Uzj3WZ@MacBook-Air-de-Roger.local>
References: <20210922082123.54374-1-roger.pau@citrix.com>
 <20210922082123.54374-3-roger.pau@citrix.com>
 <f5564634-5f9e-0b94-f73a-d44ae65c30f4@suse.com>
 <0b58667f-b6bc-d5b5-2dd1-0c8996367319@suse.com>
 <YW/NipJMLH0Zz05s@MacBook-Air-de-Roger.local>
 <a3d9388a-e2f5-76aa-d51a-2d74afb92bbd@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <a3d9388a-e2f5-76aa-d51a-2d74afb92bbd@suse.com>
X-ClientProxiedBy: LO4P123CA0124.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:192::21) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: f66e7e51-ce78-4d0f-17c4-08d993c99d90
X-MS-TrafficTypeDiagnostic: DS7PR03MB5463:
X-Microsoft-Antispam-PRVS: <DS7PR03MB5463E957FA103D31067B0C718FBE9@DS7PR03MB5463.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: zVt1Me/bNYMvWhZYp85e/iwIrMU1YxrPtTOTqZ0CFjfiI6Yk1poyy0rG3CuOb3L6cAoGS8Am8gHeRsIjwSvKH3j5p20fli/sS4PrHLZD/jWPgsDpTnL764Pq1h+T1p6dkxGssexvXaC0xsys4ZPWh3iqaBwKbrVj1OBZQWKBZm1qBcEEeCxVQDyC6uHAI+X/s1T1UeWHVWHDKN/1XIvvzySEpbLTd+K0Wabwe3x7/mXMvuJrLe0kWwKURw7LOkcUNjIW9+sE53JQ7yvJLP5RVck4Y2HbpmecqwXqsru3221HC0Sy6bRJBFc2foP7mvVWvIVlLfPi0frHlFuREk7wrRR9bSs8LYsiEosvHMhuEkKOagM+7Ew35jFCbxNA0D9Ad/HE0YSgrMin3xX4jF6hxidGnXGIDAMKf2bCCdonK4mJ1BNwtSaeMFtOT4SpND2QFvZrrqFpY+2e1lYbRiS1Pr2cGzMdHAsiK5uqbRMRisS3KwPTKVcSKPWjjxBwnXel2qQPCZdwPM/mgiiu3M6vosM7kppvi68RTHG49TSSvK3XNujvDBHQqwKicGX/nSJFj46E4fKCfnLbo6Nv8ynCVlcrjYVbKPWTj4PIkzDsXRIvnrY0ffAM4xdmXYFb0tQ91bJyuPos5B0QE2eSTGfT7RiwbVQR0hQmxhQpV2BKP7S12TvMPwV5PZRMoQv/vWIbvJhZB9BmsODIB4/WxK73Yg==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(38100700002)(6486002)(186003)(85182001)(2906002)(86362001)(316002)(5660300002)(54906003)(956004)(508600001)(82960400001)(66556008)(66946007)(26005)(6916009)(6496006)(4326008)(8936002)(9686003)(66476007)(8676002)(83380400001)(6666004)(53546011)(67856001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UW5JR1Y0Q21lQjFHZVBRVHEwNHhPN0I2QjRxQnd3bTZYYzBJOTd4cmlxY0Nu?=
 =?utf-8?B?dm1yMUwwMVBUTUxQUlFEdXp2cGdCSW10SUd5SEdOU29PRnF0NXN6WU80cmtz?=
 =?utf-8?B?N2RDQW1GK3k4VEsrcVRNNHFjK0FLNENuRDlOb1FVSlJYdEFhR3NqV1JORlNZ?=
 =?utf-8?B?WW01NWNxTWFERlozcC9aK0NGL0wrTXNwNWZsY1M3dWloaVo2ekNGRklNVDBU?=
 =?utf-8?B?UmJCU05JUFB1akZJVm5FNUpuTTlUREN6RlJZNk83d3FiVUJrcmVEWWp5Tzk4?=
 =?utf-8?B?QWxlL3N5NEp5QnBXanlRZk5ESWpmQWhQTEhrbmt6VTFvUzU2QTFEdENRSllo?=
 =?utf-8?B?U3lZdXN0V3RtMkxWaGVSalRNNWJlSWRwUjMvdGQwZXczRFRYYTd1cS9YSS9r?=
 =?utf-8?B?SlpzOVh3UVkyUi9VUzF0UHJiV3l4ZHQ4MW8reXJscVNTdG9kMy9wcWpjWG9i?=
 =?utf-8?B?dnh0anBQU1JQRmhNb0RtSkpzK3BYOVN0c3ArU2VETlo2dHp2ZWQrbE5GQkl3?=
 =?utf-8?B?Ky9UbFdVRGFLems2a0hEd3BmcEM2a1pmWDZIMjB5N1lucEdTYXZOQzBaaldX?=
 =?utf-8?B?bHFDNG96cGxoOW8xU2VWQkZCV2Z4cHUranlGQmlzSXZ5MVEzbFRacGMxc20y?=
 =?utf-8?B?ZjNMOGc5SjRacWd0U3hPMlhhYVAyYWo5RnMvMnpXVmVrekFCVm1oWDZsdm9U?=
 =?utf-8?B?dmZ4QXRTR3lnTnVwbTUwbW1ENDNuSVJ6MDFmVWNjNEJMbUpVYXU2Z2VhK0lW?=
 =?utf-8?B?Q1JVSWxpOHBSWkR3alpxL1k1blU2Q0paai92cE5ocitVMW9BM1J3V3BRV3E0?=
 =?utf-8?B?amVSaUxlNG9XREl3VHNkZnhvRERsWnV0S1VWMDJzeDdFa1hBbEwwTDN4R2Fi?=
 =?utf-8?B?ZERIQlFMRmczMHRwNEU5RTlXek9DaitmS1FYeHluQlZlQy9UNGZZNU9PSmhz?=
 =?utf-8?B?dXRvMzk5TnZaK3YwWEM3a3FwK0ljRXEycWthNFA4dzEzaHZ6NVBib25hL0Uz?=
 =?utf-8?B?MmRJaG1nemV5S2FIYUkvcXE4ZlNhYkZiUHl1VGMxOHpFa1lQSjUweXhoS01K?=
 =?utf-8?B?Q2REQWJaMEpvL3ZGc01Mbno5d3dzZzh4bFdkMVVNcjB2dzFiaHlWZStiMnZn?=
 =?utf-8?B?ZDhMZnBGcUp0NzN2U2I1Wk9WUVBaMHBYdk1FendZY0xORXNoVXN3OGwxVnND?=
 =?utf-8?B?Z0t6anJzaU9IcThQUmhVbkN0TVRaTE9XU0RuekV5bnZsblE3dFJHRGsyK1lM?=
 =?utf-8?B?SGRlMCs1eUp1NERseGp4clRIcVdGb0tLV3VrRmQzVnlSY1YrS0pFbmRlcEc2?=
 =?utf-8?B?RVZDdkNLdFl2b2Z5WTJKd2xwVlNvNVZlMlFXWVhlL1Z1QnB4dDZvdHZQSEJn?=
 =?utf-8?B?eUFtOGw2TDFJNkFzbVFNbGhGUzM1M0VXSUxJTUtOTWFsNzEyeS9ILysyVHNs?=
 =?utf-8?B?bkFxelBtYnFJWVlsMU1GNXI2bWpEN2xyMnRRY3YrOXBMMmxnVVlqZ1U2UUVN?=
 =?utf-8?B?eVpNV2F2WGRPK0E1UzRiam15dHoycmdDTEgwQldVOEJyaks1dXRFNm9aT3dU?=
 =?utf-8?B?UXNZdFgvTlNQNG83Tlhoc1VRenRnRXpOMG5hRWRRVStGdVV0cCt1a1JOZG9B?=
 =?utf-8?B?TkloN25JNVNzVENMeXFUTCtuRG5yUlhQQk5HYUZQS3ZTb0EzMmJDL3owZ1hm?=
 =?utf-8?B?V0ZmTUJEVUxQMUVPVTU2ci9WcWQ4NUMxNzF5NnRIY2lQRWxBWk1Ud3F1SFRL?=
 =?utf-8?B?L0p1d1B0VjZBdEtUUGg0R0NuUklkNmx6a1ZreXlWbkZhckJJT29TV3ZkWkdw?=
 =?utf-8?B?Z3FyN3lHWlRMNGFhT0JoNEN5V3Q5RGp3djl5eU10bGRkYkhEbnhvcFRQOGdv?=
 =?utf-8?B?MkV2bVprZmZ1LzdCQ092WXpQU3pjYmx0YjUzT0RLTzFwclJXenltNzV0KzVo?=
 =?utf-8?Q?21mL4oGW1YOTC03jXTrDHbnslgVFY3sO?=
X-MS-Exchange-CrossTenant-Network-Message-Id: f66e7e51-ce78-4d0f-17c4-08d993c99d90
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2021 13:00:39.2434
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: roger.pau@citrix.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR03MB5463
X-OriginatorOrg: citrix.com

On Wed, Oct 20, 2021 at 12:57:11PM +0200, Jan Beulich wrote:
> On 20.10.2021 10:04, Roger Pau Monné wrote:
> > On Fri, Oct 15, 2021 at 11:48:33AM +0200, Jan Beulich wrote:
> >> On 15.10.2021 11:39, Jan Beulich wrote:
> >>> On 22.09.2021 10:21, Roger Pau Monne wrote:
> >>>> --- a/xen/include/public/domctl.h
> >>>> +++ b/xen/include/public/domctl.h
> >>>> @@ -87,14 +87,22 @@ struct xen_domctl_createdomain {
> >>>>      /*
> >>>>       * Various domain limits, which impact the quantity of resources
> >>>>       * (global mapping space, xenheap, etc) a guest may consume.  For
> >>>> -     * max_grant_frames and max_maptrack_frames, < 0 means "use the
> >>>> -     * default maximum value in the hypervisor".
> >>>> +     * max_grant_frames, max_maptrack_frames and max_gnttab_version < 0
> >>>> +     * means "use the default maximum value in the hypervisor".
> >>>>       */
> >>>>      uint32_t max_vcpus;
> >>>>      uint32_t max_evtchn_port;
> >>>>      int32_t max_grant_frames;
> >>>>      int32_t max_maptrack_frames;
> >>>>  
> >>>> +/* Grant version, use low 4 bits. */
> >>>> +#define XEN_DOMCTL_GRANT_version_mask    0xf
> >>>> +#define XEN_DOMCTL_GRANT_version_default 0xf
> >>>> +
> >>>> +#define XEN_DOMCTLGRANT_MAX XEN_DOMCTL_GRANT_version_mask
> >>>> +
> >>>> +    uint32_t grant_opts;
> >>>
> >>> As it now seems unlikely that this will make 4.16, please don't forget
> >>> to bump the interface version for 4.17. With that and preferably with
> >>> the nit above addressed, hypervisor parts:
> >>> Reviewed-by: Jan Beulich <jbeulich@suse.com>
> >>
> >> Actually no, I'm afraid there is an issue with migration: If the tool
> >> stack remembers the "use default" setting and hands this to the new
> >> host, that host's default may be different from the source host's. It
> >> is the effective max-version that needs passing on in this case, which
> >> in turn requires a means to obtain the value.
> > 
> > Hm, my thinking was that the admin (or a higer level orchestration
> > tool) would already have performed the necessary adjustments to assert
> > the environments are compatible.
> 
> I don't think we can rely on this in the hypervisor. We may take this
> as a prereq for proper working, but I think we ought to detect
> violations and report errors in such a case.
> 
> > This problem already exist today where you can migrate a VM from a
> > host having the max default grant version to one having
> > gnttab=max-ver:1 without complains.
> 
> Are you sure about "without complaints"?

Without hypervisor complaining AFAICT, as the max grant version is
not migrated or checked in any way ATM.

> What would a guest do if it
> expects to be able to use v2, since it was able to on the prior host?

IMO any well behaved guest should be capable of handling both v1 and
v2, and lacking v2 a guest should fallback to v1 on resume, as the
grant table needs to be re-initialized anyway. I think it would be
wrong (ie: a bug) for guests to assume v2 to be present on resume
based on the fact it was present previously, as it would be wrong for
a block frontend to assume the same features to be present on resume
for example.

If a guest only supports grant v2 then I think it's up to the
administrator to set the max version explicitly in the config file and
that would be acknowledged on the destination end and migration
aborted if not supported. I think the behavior after this patch
is more user friendly that the current one, as no checks are
performed currently.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Wed Oct 20 13:12:50 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Oct 2021 13:12:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.213912.372274 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdBOe-0000tz-Qq; Wed, 20 Oct 2021 13:12:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 213912.372274; Wed, 20 Oct 2021 13:12:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdBOe-0000ts-N9; Wed, 20 Oct 2021 13:12:44 +0000
Received: by outflank-mailman (input) for mailman id 213912;
 Wed, 20 Oct 2021 13:12:43 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mdBOd-0000ti-6B; Wed, 20 Oct 2021 13:12:43 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mdBOc-0005ah-VJ; Wed, 20 Oct 2021 13:12:42 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mdBOc-0004gt-MN; Wed, 20 Oct 2021 13:12:42 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mdBOc-0006OK-Ls; Wed, 20 Oct 2021 13:12:42 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=IW9ceqUEg2h6EZBfuKfd2kFJmpv7AS6cZUWEsZcUzAA=; b=vcNKkcJ2Z1UBq4s02ulB/xRlsS
	nPN+xNuLE9e+cLQHtcqLw9/b/MOvk7I620P0Ix3I1F+r1CiSqjZJIEpBnVKWtE47ARlIFuHn5EKAM
	ReyQeqV4BWDvPptVej+ymZAOGIbwBKvCKR7ojQ3U2JjKeu4HBYOdjWerFj7b+BLzrF+c=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165688-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 165688: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=4fdf843c75d297fe892f989009b3d3e397ccfd55
X-Osstest-Versions-That:
    ovmf=37a33f02aa1ab89f392da7d06ec3578fda1b6182
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 20 Oct 2021 13:12:42 +0000

flight 165688 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165688/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 4fdf843c75d297fe892f989009b3d3e397ccfd55
baseline version:
 ovmf                 37a33f02aa1ab89f392da7d06ec3578fda1b6182

Last test of basis   165685  2021-10-20 07:11:17 Z    0 days
Testing same since   165688  2021-10-20 10:13:27 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Moritz Fischer <moritzf@google.com>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   37a33f02aa..4fdf843c75  4fdf843c75d297fe892f989009b3d3e397ccfd55 -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Wed Oct 20 13:14:24 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Oct 2021 13:14:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.213919.372288 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdBQF-0001Uj-6t; Wed, 20 Oct 2021 13:14:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 213919.372288; Wed, 20 Oct 2021 13:14:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdBQF-0001Uc-3p; Wed, 20 Oct 2021 13:14:23 +0000
Received: by outflank-mailman (input) for mailman id 213919;
 Wed, 20 Oct 2021 13:14:22 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mdBQE-0001UN-5M
 for xen-devel@lists.xenproject.org; Wed, 20 Oct 2021 13:14:22 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mdBQC-0005bn-Hz; Wed, 20 Oct 2021 13:14:20 +0000
Received: from [54.239.6.185] (helo=[192.168.28.129])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mdBQC-0006d8-B1; Wed, 20 Oct 2021 13:14:20 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=w7QZUxo74HM2JkZAyVpajt72WJzeHNi6Ca7poB+1Jf8=; b=jTKhtufYKxRXkem83QDL7kIh2p
	jIZDCsOErPaAiG4c+byabWsHtFdBbJvdNEoVasVpB8d2DnNfipjwKF79n3eTATZRs/lx1zb5zJQ/J
	u6SO5+V/8KaKufm7yJJ8jUUOK2Sffn6//D7x4dT1Tr+EBfMhTKD1WA+d2GQTNwno2PhQ=;
Message-ID: <5982b3fd-6a1a-c759-5da4-156fb50790f5@xen.org>
Date: Wed, 20 Oct 2021 14:14:17 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.2.0
Subject: Re: [PATCH v3 1/1] xen/pci: Install vpci handlers on x86 and fix
 error paths
To: Bertrand Marquis <bertrand.marquis@arm.com>,
 xen-devel@lists.xenproject.org
Cc: iwj@xenproject.org, Oleksandr_Andrushchenko@epam.com,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Jan Beulich <jbeulich@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>, Wei Liu
 <wl@xen.org>, Paul Durrant <paul@xen.org>
References: <cover.1634723903.git.bertrand.marquis@arm.com>
 <c82cc9c933e09806c9d043c61d92bd793060f9ab.1634723903.git.bertrand.marquis@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <c82cc9c933e09806c9d043c61d92bd793060f9ab.1634723903.git.bertrand.marquis@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Bertrand,

On 20/10/2021 11:05, Bertrand Marquis wrote:
> Xen might not be able to discover at boot time all devices or some devices
> might appear after specific actions from dom0.
> In this case dom0 can use the PHYSDEVOP_pci_device_add to signal some
> PCI devices to Xen.
> As those devices where not known from Xen before, the vpci handlers must
> be properly installed during pci_device_add for x86 PVH Dom0, in the
> same way as what is done currently on arm (where Xen does not detect PCI
> devices but relies on Dom0 to declare them all the time).
> 
> So this patch is removing the ifdef protecting the call to
> vpci_add_handlers and the comment which was arm specific.
> 
> vpci_add_handlers is called on during pci_device_add which can be called
> at runtime through hypercall physdev_op.
> Remove __hwdom_init as the call is not limited anymore to hardware
> domain init and fix linker script to only keep vpci_array in rodata
> section.
> 
> Add missing vpci handlers cleanup during pci_device_remove and in case
> of error with iommu during pci_device_add.
> 
> Move code adding the domain to the pdev domain_list as vpci_add_handlers
> needs this to be set and remove it from the list in the error path.
> 
> Exit early of vpci_remove_device if the domain has no vpci support.
> 
> Add empty static inline for vpci_remove_device when CONFIG_VPCI is not
> defined.
> 
> Add an ASSERT in vpci_add_handlers to check that the function is not
> called twice for the same device.
> 
> Fixes: d59168dc05 ("xen/arm: Enable the existing x86 virtual PCI support
> for ARM")
> Suggested-by: Jan Beulich <jbeulich@suse.com>
> Signed-off-by: Bertrand Marquis <bertrand.marquis@arm.com>

For the arm bits:

Acked-by: Julien Grall <jgrall@amazon.com>

Cheers,

> ---
> Changes in v3
> - change title (s/exit/error/ and s/path/paths)
> - add early exit in vpci_remove_device if the domain has no vpci support
> - add ASSERT in vpci_add_handlers to check that the call is only made
> once per device
> - move the call adding the domain in the pdev domain list and remove it
> in the error path
> Changes in v2
> - add comment suggested by Jan on top of vpci_add_handlers call
> - merge the 3 patches of the serie in one patch and renamed it
> - fix x86 and arm linker script to only keep vpci_array in rodata and
> only when CONFIG_VPCI is set.
> ---
>   xen/arch/arm/xen.lds.S        |  9 +--------
>   xen/arch/x86/xen.lds.S        |  9 +--------
>   xen/drivers/passthrough/pci.c | 14 ++++++++------
>   xen/drivers/vpci/vpci.c       |  8 +++++++-
>   xen/include/xen/vpci.h        |  2 ++
>   5 files changed, 19 insertions(+), 23 deletions(-)
> 
> diff --git a/xen/arch/arm/xen.lds.S b/xen/arch/arm/xen.lds.S
> index b773f91f1c..08016948ab 100644
> --- a/xen/arch/arm/xen.lds.S
> +++ b/xen/arch/arm/xen.lds.S
> @@ -60,7 +60,7 @@ SECTIONS
>          *(.proc.info)
>          __proc_info_end = .;
>   
> -#if defined(CONFIG_HAS_VPCI) && defined(CONFIG_LATE_HWDOM)
> +#ifdef CONFIG_HAS_VPCI
>          . = ALIGN(POINTER_ALIGN);
>          __start_vpci_array = .;
>          *(SORT(.data.vpci.*))
> @@ -189,13 +189,6 @@ SECTIONS
>          *(.init_array)
>          *(SORT(.init_array.*))
>          __ctors_end = .;
> -
> -#if defined(CONFIG_HAS_VPCI) && !defined(CONFIG_LATE_HWDOM)
> -       . = ALIGN(POINTER_ALIGN);
> -       __start_vpci_array = .;
> -       *(SORT(.data.vpci.*))
> -       __end_vpci_array = .;
> -#endif
>     } :text
>     __init_end_efi = .;
>     . = ALIGN(STACK_SIZE);
> diff --git a/xen/arch/x86/xen.lds.S b/xen/arch/x86/xen.lds.S
> index 11b1da2154..87e344d4dd 100644
> --- a/xen/arch/x86/xen.lds.S
> +++ b/xen/arch/x86/xen.lds.S
> @@ -134,7 +134,7 @@ SECTIONS
>          *(.ex_table.pre)
>          __stop___pre_ex_table = .;
>   
> -#if defined(CONFIG_HAS_VPCI) && defined(CONFIG_LATE_HWDOM)
> +#ifdef CONFIG_HAS_VPCI
>          . = ALIGN(POINTER_ALIGN);
>          __start_vpci_array = .;
>          *(SORT(.data.vpci.*))
> @@ -247,13 +247,6 @@ SECTIONS
>          *(.init_array)
>          *(SORT(.init_array.*))
>          __ctors_end = .;
> -
> -#if defined(CONFIG_HAS_VPCI) && !defined(CONFIG_LATE_HWDOM)
> -       . = ALIGN(POINTER_ALIGN);
> -       __start_vpci_array = .;
> -       *(SORT(.data.vpci.*))
> -       __end_vpci_array = .;
> -#endif
>     } PHDR(text)
>   
>     . = ALIGN(SECTION_ALIGN);
> diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci.c
> index 35e0190796..0d8ab2e716 100644
> --- a/xen/drivers/passthrough/pci.c
> +++ b/xen/drivers/passthrough/pci.c
> @@ -756,27 +756,28 @@ int pci_add_device(u16 seg, u8 bus, u8 devfn,
>       if ( !pdev->domain )
>       {
>           pdev->domain = hardware_domain;
> -#ifdef CONFIG_ARM
> +        list_add(&pdev->domain_list, &hardware_domain->pdev_list);
> +
>           /*
> -         * On ARM PCI devices discovery will be done by Dom0. Add vpci handler
> -         * when Dom0 inform XEN to add the PCI devices in XEN.
> +         * For devices not discovered by Xen during boot, add vPCI handlers
> +         * when Dom0 first informs Xen about such devices.
>            */
>           ret = vpci_add_handlers(pdev);
>           if ( ret )
>           {
>               printk(XENLOG_ERR "Setup of vPCI failed: %d\n", ret);
> +            list_del(&pdev->domain_list);
>               pdev->domain = NULL;
>               goto out;
>           }
> -#endif
>           ret = iommu_add_device(pdev);
>           if ( ret )
>           {
> +            vpci_remove_device(pdev);
> +            list_del(&pdev->domain_list);
>               pdev->domain = NULL;
>               goto out;
>           }
> -
> -        list_add(&pdev->domain_list, &hardware_domain->pdev_list);
>       }
>       else
>           iommu_enable_device(pdev);
> @@ -819,6 +820,7 @@ int pci_remove_device(u16 seg, u8 bus, u8 devfn)
>       list_for_each_entry ( pdev, &pseg->alldevs_list, alldevs_list )
>           if ( pdev->bus == bus && pdev->devfn == devfn )
>           {
> +            vpci_remove_device(pdev);
>               pci_cleanup_msi(pdev);
>               ret = iommu_remove_device(pdev);
>               if ( pdev->domain )
> diff --git a/xen/drivers/vpci/vpci.c b/xen/drivers/vpci/vpci.c
> index decf7d87a1..657697fe34 100644
> --- a/xen/drivers/vpci/vpci.c
> +++ b/xen/drivers/vpci/vpci.c
> @@ -37,6 +37,9 @@ extern vpci_register_init_t *const __end_vpci_array[];
>   
>   void vpci_remove_device(struct pci_dev *pdev)
>   {
> +    if ( !has_vpci(pdev->domain) )
> +        return;
> +
>       spin_lock(&pdev->vpci->lock);
>       while ( !list_empty(&pdev->vpci->handlers) )
>       {
> @@ -54,7 +57,7 @@ void vpci_remove_device(struct pci_dev *pdev)
>       pdev->vpci = NULL;
>   }
>   
> -int __hwdom_init vpci_add_handlers(struct pci_dev *pdev)
> +int vpci_add_handlers(struct pci_dev *pdev)
>   {
>       unsigned int i;
>       int rc = 0;
> @@ -62,6 +65,9 @@ int __hwdom_init vpci_add_handlers(struct pci_dev *pdev)
>       if ( !has_vpci(pdev->domain) )
>           return 0;
>   
> +    /* We should not get here twice for the same device. */
> +    ASSERT(!pdev->vpci);
> +
>       pdev->vpci = xzalloc(struct vpci);
>       if ( !pdev->vpci )
>           return -ENOMEM;
> diff --git a/xen/include/xen/vpci.h b/xen/include/xen/vpci.h
> index 6746c2589a..9ea66e033f 100644
> --- a/xen/include/xen/vpci.h
> +++ b/xen/include/xen/vpci.h
> @@ -230,6 +230,8 @@ static inline int vpci_add_handlers(struct pci_dev *pdev)
>       return 0;
>   }
>   
> +static inline void vpci_remove_device(struct pci_dev *pdev) { }
> +
>   static inline void vpci_dump_msi(void) { }
>   
>   static inline uint32_t vpci_read(pci_sbdf_t sbdf, unsigned int reg,
> 

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Oct 20 13:24:45 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Oct 2021 13:24:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.213930.372299 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdBaA-00032W-9N; Wed, 20 Oct 2021 13:24:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 213930.372299; Wed, 20 Oct 2021 13:24:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdBaA-00032P-6H; Wed, 20 Oct 2021 13:24:38 +0000
Received: by outflank-mailman (input) for mailman id 213930;
 Wed, 20 Oct 2021 13:24:37 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=faDG=PI=arm.com=Bertrand.Marquis@srs-us1.protection.inumbo.net>)
 id 1mdBa9-00032J-78
 for xen-devel@lists.xenproject.org; Wed, 20 Oct 2021 13:24:37 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com (unknown
 [2a01:111:f400:fe0d::62c])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id a7ad1d5e-23da-44ae-aeac-d70c10a3fd43;
 Wed, 20 Oct 2021 13:24:35 +0000 (UTC)
Received: from AM6P192CA0062.EURP192.PROD.OUTLOOK.COM (2603:10a6:209:82::39)
 by DBBPR08MB6187.eurprd08.prod.outlook.com (2603:10a6:10:209::6) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15; Wed, 20 Oct
 2021 13:24:22 +0000
Received: from VE1EUR03FT016.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:209:82:cafe::a3) by AM6P192CA0062.outlook.office365.com
 (2603:10a6:209:82::39) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.16 via Frontend
 Transport; Wed, 20 Oct 2021 13:24:22 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT016.mail.protection.outlook.com (10.152.18.115) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4628.16 via Frontend Transport; Wed, 20 Oct 2021 13:24:22 +0000
Received: ("Tessian outbound 8e26f7114b75:v103");
 Wed, 20 Oct 2021 13:24:21 +0000
Received: from d7b54d621a2b.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 BB070066-E1D8-4B4C-AE61-3AE41166E76A.1; 
 Wed, 20 Oct 2021 13:24:10 +0000
Received: from EUR03-VE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id d7b54d621a2b.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Wed, 20 Oct 2021 13:24:10 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com (2603:10a6:4:74::9)
 by DB8PR08MB4185.eurprd08.prod.outlook.com (2603:10a6:10:aa::22) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.16; Wed, 20 Oct
 2021 13:24:08 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955]) by DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955%4]) with mapi id 15.20.4608.018; Wed, 20 Oct 2021
 13:24:07 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a7ad1d5e-23da-44ae-aeac-d70c10a3fd43
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=lMnlSk7ryK/CuINV4bvRZ+yHVMIhjzh1KukZkqwxgg0=;
 b=MhXccfRgs69a0xTnUGPscQqV5qCjj8ti6XjxL3MPl72fE92/CGGLCNeM6ybZDLwud8b74DhlZ7w1b1edXiRYKlch3sD6t8xsDRd93GRbMkjisTo8zeYOVeYc2p/r01vKei7bMDsbN/WX7YdHlVv+v9z8QXIdL/G12wh6zhyXNY8=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 6cac44c3614e7c4b
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=k3knO7q7f0szjbcg7/7n4rChTPPeBDIGdfJ+AeW3Mdqers+sXZyqZstA3IF0Xnv0H/d+5XxqD3Zcz054ffLWwwDE3d6BY46sVYe6NlFc+Ny2zXRjYn59KbMHLoPdZszwOYCJ69u3eJOr/6Lch83wVUf0uZp4qVpJk5TTaShZnhXlk+0MSCQI7XMKXtazFtTHPrd8FgQt/dH8mY0zudwg00Mdkr95owakwqu18KuuHYfjhPbhuCCe+ZeGeTfrgGjdiS1BXbzoJpF8tVyk1xsAXvYbSmx6GRdcczOqQLZqwSMfBpBbwKJjVU1bZAzls6J/CeorFPdB+V+lufNOuJuj5A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=lMnlSk7ryK/CuINV4bvRZ+yHVMIhjzh1KukZkqwxgg0=;
 b=l85m5bUe6FE7mE2CpJZmw+Yq/uE2bW21OjliZfqWXTNNsY43rydgAnfV2lfFfvehbWBYdWLeqRUfACGGmjKZDAxVe0gt2YFNGV9MtAEh0y0xatcNk9LRUqpdXA21HnXyicVAn2EbpsMJahUbIqGPEf9iCTddkIcFmEj64ci7VnMrIlK6BHClKAlmT2ZbbIJt7ZnQnzkwoASvpJLGj3ij9Ka2eVfKCsm4M8tNbfH38t2kGQSYoui8O2rOrlm+Y7+nKLD9jVFEyte1lo3YT8JqKv5dnXlgo3MQPVsZzLYxCEBBBl69hLm7sefYQToWRvM+cWFFKOEsc8CZWcoZ34QCXw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=lMnlSk7ryK/CuINV4bvRZ+yHVMIhjzh1KukZkqwxgg0=;
 b=MhXccfRgs69a0xTnUGPscQqV5qCjj8ti6XjxL3MPl72fE92/CGGLCNeM6ybZDLwud8b74DhlZ7w1b1edXiRYKlch3sD6t8xsDRd93GRbMkjisTo8zeYOVeYc2p/r01vKei7bMDsbN/WX7YdHlVv+v9z8QXIdL/G12wh6zhyXNY8=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Hongda Deng <Hongda.Deng@arm.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>, Stefano Stabellini
	<sstabellini@kernel.org>, Julien Grall <julien@xen.org>, Wei Chen
	<Wei.Chen@arm.com>, Ian Jackson <iwj@xenproject.org>
Subject: Re: [PATCH v3] xen/arm: vgic to ignore GICD ICPENDRn registers access
Thread-Topic: [PATCH v3] xen/arm: vgic to ignore GICD ICPENDRn registers
 access
Thread-Index: AQHXxZrAxvKJmM1p6EelRjLGqFxZEKvb4E+A
Date: Wed, 20 Oct 2021 13:24:07 +0000
Message-ID: <87512F00-48DA-4E66-B3A8-47F48B9C6A87@arm.com>
References: <20211020101021.9793-1-Hongda.Deng@arm.com>
In-Reply-To: <20211020101021.9793-1-Hongda.Deng@arm.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3654.120.0.1.13)
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: 75674ecf-e2ca-439e-1e9b-08d993ccede9
x-ms-traffictypediagnostic: DB8PR08MB4185:|DBBPR08MB6187:
X-Microsoft-Antispam-PRVS:
	<DBBPR08MB6187D417B9ADC967B1D9AEA59DBE9@DBBPR08MB6187.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:8882;OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 0fMmHCmFYAg1JTvOuDLiSR5O2/yIh5QHqcxDgjrM/zmW3BFkp7oaELw12h9Zibr3elrPMyi2p6ZMY3cnpxjtWUT9dFXE+++lsghtOjQyiRYCxWZNasprtOKAaTBpheyG6EODOKm0t7ee65bj9SbJi50q3JP1JNvOvrd/HuDpzp5QadazHyLicoYxIgt+x9vRFfF4RrYR/wO0SYS/Bm5Q+FBLJIORHSrzMK9PpZlFcVO4W/htSw24X/kxJ/3xHdCuxu7iG9sTAwKn7YXzWGB6uKKmQjTZ5FeHXcQ76xI3KPU5NObLN+xW7xrulkyt4v85/xBjy6Xu9k/Z+DtWIhVXUw9k0B9IrIGREiv8TAh1q6Ztfqq9EpQwi1wzeb6XPjnbIdlCNOwYDN+m2FPlawsX9dI9WY/9tqyH5O/R0EYEohx7fJeLqdnLN+HrrAoJG6+I+Vq0aL052NUXN0HxVkMmzPBbkMq1cyDKUMub8NQwVrkvY+ELKPsH8ytatMXP5u0YYJxWmsnn8a7+asnOccUzu0WUHHRHLP7HhShztmrTbxptOIHw75O33Db4IBjRR4yD+uv8mkDGkeTIU8jDgrz4b4Zt88dLieqUb/Cap7tIKeZf0h9d0gnDjw9psVBdeBkxSeoJS9tsuslfVU5dXbQsqA9/tz9PF1VYvRmgsdNq6b9jZXQTrYXJgStP8/VJdLSfvKGBDiF2vDHvByqLEEf+zM9MZJwua7ey8GkvIjQoMj++vuLKYpaXIe+nHhKjKwcZCWxjhOjqsyGl0KUF7SPJLvYPZa9aVIMAEbVMlsEUNZ131d0heLlBjxSKC/Pq5ZnUTCGwapsML19XBj08S4vEGg==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB6PR0801MB2024.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(2906002)(71200400001)(508600001)(26005)(4326008)(966005)(36756003)(6506007)(53546011)(86362001)(186003)(122000001)(8676002)(8936002)(83380400001)(37006003)(6512007)(54906003)(38070700005)(66556008)(91956017)(66946007)(76116006)(64756008)(66446008)(6636002)(38100700002)(66476007)(316002)(33656002)(6486002)(6862004)(2616005)(5660300002)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="us-ascii"
Content-ID: <74F5D0303B50D34ABA35D920BAAF597F@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB4185
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT016.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	7b7c32ae-fbbd-4c3a-0e88-08d993cce556
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	yjyotJWYMO6BwaCUsgk6b8Ps3P7PfrVf1qFDSVlsvxDl5rEFBY9/7iKSQtpPZCVB7lcNLJI4++jm6oL9egh6oeMYJyqCfsqNF+qEwjMdB6/vfobHTVeFBHXBDmzOzq4NGAlYsqzI3H4syDH3iNuC0PjDnE8jIlcTwXo/LwQCuhQaF2sSXGWJVWw8L24ducxkk1WLl2nLfUISSlYjvAuZ5CQSok1GFiu0PfMzfTMMi2HCrpVdz0h7Yw9PIz5yFsYscY/SPZq+Pyw95VucU6NovY+/TXDgcGEeepPJSlfKwfN4lB6mFq21umOmdCIZ1NHTa7QHn5sEfZ8Oow8Zpbx9tyeESJM6q+sKHfLRd4nLTnBq/4LAceQoyj/NY9LGV6M7gmmGrcgEUd+g9QS+ZU+FAJyDer4V+VtQ2MBxTJEqTlQibT9GFu8hKd5qtlAWCJI6izXUi/XppkQAh+ss1epy2TFPHgATLISDQXBtkQUyBCfzYYxEttvvk32NMzFD1LXQdzomIT+KiirPGIU9bFVuxzI+ujrVK33qiq+C20yP8GXEnG2WxQOxXCM//N1OQFO5v5EXMF4GFk0P8GAFo0ed/BwU1cnn0vSBMA7dOp9AO6v/qkC5zvax2IIH0aSUGLgjBp4qzTyaQTed44qQrvD3pBZoy1Ihiv4TqiJ0eIngoHlIhXyW+uoaoHaw+5Fvomzh0wGjPqF1zBziJBulcZek6WRJMDfXHFvzx2g/K5n+OhUadPAdwbjJSTyZzAU9d2lFCMIg0nO0nJ1mK0E6FCi1d0qw+F0y5WOdZ1JbPcalta4=
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(70206006)(81166007)(54906003)(6486002)(70586007)(336012)(186003)(6506007)(356005)(5660300002)(47076005)(8676002)(82310400003)(86362001)(36860700001)(6862004)(508600001)(316002)(2906002)(33656002)(2616005)(36756003)(37006003)(83380400001)(26005)(53546011)(6512007)(4326008)(966005)(8936002)(6636002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2021 13:24:22.2302
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 75674ecf-e2ca-439e-1e9b-08d993ccede9
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT016.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB6187

Hi Hongda,

[+Ian]

> On 20 Oct 2021, at 11:10, Hongda Deng <Hongda.Deng@arm.com> wrote:
>=20
> Currently, Xen will return IO unhandled when guests access GICD ICPENRn
> registers. This will raise a data abort inside guest. For Linux Guest,
> these virtual registers will not be accessed. But for Zephyr, in its
> GIC initialization code, these virtual registers will be accessed. And
> zephyr guest will get an IO data abort in initilization stage and enter
> fatal error. Emulating ICPENDR is not easy with the existing vGIC, so
> we currently ignore these virtual registers access and print a message
> about whether they are already pending instead of returning unhandled.
> More details can be found at [1].
>=20
> [1] https://github.com/zephyrproject-rtos/zephyr/blob/eaf6cf745df3807e6e
> cc941c3a30de6c179ae359/drivers/interrupt_controller/intc_gicv3.c#L274
>=20
> Signed-off-by: Hongda Deng <hongda.deng@arm.com>
Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>

Ian this is fixing a bug in the vgic implementation which is preventing to =
run
Zephyr as a guest on top of Xen. Xen support has now been merged in Zephyr
so this is required to use it.

Could we consider adding this patch into the 4.16 release ?

Thanks
Bertrand

> ---
> Changes since v2:
> *  Avoid to print messages when there is no pending interrupt
> *  Add helper vgic_check_inflight_irqs_pending to check pending status
> *  Print a message for each interrupt separately
> Changes since v1:
> *  Check pending states by going through vcpu->arch.vgic.inflight_irqs
>    instead of checking hardware registers
> ---
> xen/arch/arm/vgic-v2.c     | 10 ++++++----
> xen/arch/arm/vgic-v3.c     | 16 ++++++++--------
> xen/arch/arm/vgic.c        | 36 ++++++++++++++++++++++++++++++++++++
> xen/include/asm-arm/vgic.h |  3 ++-
> 4 files changed, 52 insertions(+), 13 deletions(-)
>=20
> diff --git a/xen/arch/arm/vgic-v2.c b/xen/arch/arm/vgic-v2.c
> index b2da886adc..7c30da327c 100644
> --- a/xen/arch/arm/vgic-v2.c
> +++ b/xen/arch/arm/vgic-v2.c
> @@ -481,10 +481,12 @@ static int vgic_v2_distr_mmio_write(struct vcpu *v,=
 mmio_info_t *info,
>=20
>     case VRANGE32(GICD_ICPENDR, GICD_ICPENDRN):
>         if ( dabt.size !=3D DABT_WORD ) goto bad_width;
> -        printk(XENLOG_G_ERR
> -               "%pv: vGICD: unhandled word write %#"PRIregister" to ICPE=
NDR%d\n",
> -               v, r, gicd_reg - GICD_ICPENDR);
> -        return 0;
> +        rank =3D vgic_rank_offset(v, 1, gicd_reg - GICD_ICPENDR, DABT_WO=
RD);
> +        if ( rank =3D=3D NULL ) goto write_ignore;
> +
> +        vgic_check_inflight_irqs_pending(v->domain, v, rank->index, r);
> +
> +        goto write_ignore_32;
>=20
>     case VRANGE32(GICD_ISACTIVER, GICD_ISACTIVERN):
>         if ( dabt.size !=3D DABT_WORD ) goto bad_width;
> diff --git a/xen/arch/arm/vgic-v3.c b/xen/arch/arm/vgic-v3.c
> index cb5a70c42e..4913301d22 100644
> --- a/xen/arch/arm/vgic-v3.c
> +++ b/xen/arch/arm/vgic-v3.c
> @@ -817,10 +817,12 @@ static int __vgic_v3_distr_common_mmio_write(const =
char *name, struct vcpu *v,
>=20
>     case VRANGE32(GICD_ICPENDR, GICD_ICPENDRN):
>         if ( dabt.size !=3D DABT_WORD ) goto bad_width;
> -        printk(XENLOG_G_ERR
> -               "%pv: %s: unhandled word write %#"PRIregister" to ICPENDR=
%d\n",
> -               v, name, r, reg - GICD_ICPENDR);
> -        return 0;
> +        rank =3D vgic_rank_offset(v, 1, reg - GICD_ICPENDR, DABT_WORD);
> +        if ( rank =3D=3D NULL ) goto write_ignore;
> +
> +        vgic_check_inflight_irqs_pending(v->domain, v, rank->index, r);
> +
> +        goto write_ignore_32;
>=20
>     case VRANGE32(GICD_ISACTIVER, GICD_ISACTIVERN):
>         if ( dabt.size !=3D DABT_WORD ) goto bad_width;
> @@ -987,10 +989,8 @@ static int vgic_v3_rdistr_sgi_mmio_write(struct vcpu=
 *v, mmio_info_t *info,
>=20
>     case VREG32(GICR_ICPENDR0):
>         if ( dabt.size !=3D DABT_WORD ) goto bad_width;
> -        printk(XENLOG_G_ERR
> -               "%pv: vGICR: SGI: unhandled word write %#"PRIregister" to=
 ICPENDR0\n",
> -               v, r);
> -        return 0;
> +        return __vgic_v3_distr_common_mmio_write("vGICR: SGI", v,
> +                                                 info, gicr_reg, r);
>=20
>     case VREG32(GICR_IGRPMODR0):
>         /* We do not implement security extensions for guests, write igno=
re */
> diff --git a/xen/arch/arm/vgic.c b/xen/arch/arm/vgic.c
> index 8f9400a519..0565557814 100644
> --- a/xen/arch/arm/vgic.c
> +++ b/xen/arch/arm/vgic.c
> @@ -726,6 +726,42 @@ unsigned int vgic_max_vcpus(unsigned int domctl_vgic=
_version)
>     }
> }
>=20
> +void vgic_check_inflight_irqs_pending(struct domain *d, struct vcpu *v,
> +                                      unsigned int rank, uint32_t r)
> +{
> +    const unsigned long mask =3D r;
> +    unsigned int i;
> +    unsigned long flags;
> +    struct pending_irq *p;
> +    bool private =3D rank =3D=3D 0;
> +    struct vcpu *v_target;
> +
> +    for_each_set_bit( i, &mask, 32 )
> +    {
> +        unsigned int irq =3D i + 32 * rank;
> +
> +        if ( private )
> +            v_target =3D vgic_get_target_vcpu(v, irq);
> +        else
> +            v_target =3D vgic_get_target_vcpu(d->vcpu[0], irq);
> +
> +        spin_lock_irqsave(&v_target->arch.vgic.lock, flags);
> +
> +        p =3D irq_to_pending(v_target, irq);
> +
> +        if ( unlikely(!p) )
> +        {
> +            spin_unlock_irqrestore(&v_target->arch.vgic.lock, flags);
> +            continue;
> +        }
> +
> +        if ( !list_empty(&p->inflight) )
> +            printk("%pv trying to clear pending interrupt %u.\n", v, irq=
);
> +
> +        spin_unlock_irqrestore(&v_target->arch.vgic.lock, flags);
> +    }
> +}
> +
> /*
>  * Local variables:
>  * mode: C
> diff --git a/xen/include/asm-arm/vgic.h b/xen/include/asm-arm/vgic.h
> index 62c2ae538d..abcaae2969 100644
> --- a/xen/include/asm-arm/vgic.h
> +++ b/xen/include/asm-arm/vgic.h
> @@ -298,7 +298,8 @@ extern bool vgic_to_sgi(struct vcpu *v, register_t sg=
ir,
>                         enum gic_sgi_mode irqmode, int virq,
>                         const struct sgi_target *target);
> extern bool vgic_migrate_irq(struct vcpu *old, struct vcpu *new, unsigned=
 int irq);
> -
> +extern void vgic_check_inflight_irqs_pending(struct domain *d, struct vc=
pu *v,
> +                                             unsigned int rank, uint32_t=
 r);
> #endif /* !CONFIG_NEW_VGIC */
>=20
> /*** Common VGIC functions used by Xen arch code ****/
> --=20
> 2.17.1
>=20



From xen-devel-bounces@lists.xenproject.org Wed Oct 20 13:30:16 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Oct 2021 13:30:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.213936.372310 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdBfX-0004S7-U7; Wed, 20 Oct 2021 13:30:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 213936.372310; Wed, 20 Oct 2021 13:30:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdBfX-0004S0-Ql; Wed, 20 Oct 2021 13:30:11 +0000
Received: by outflank-mailman (input) for mailman id 213936;
 Wed, 20 Oct 2021 13:30:10 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mdBfW-0004Qu-6T
 for xen-devel@lists.xenproject.org; Wed, 20 Oct 2021 13:30:10 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mdBfW-0005s2-0t
 for xen-devel@lists.xenproject.org; Wed, 20 Oct 2021 13:30:10 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mdBfV-0007du-VQ
 for xen-devel@lists.xenproject.org; Wed, 20 Oct 2021 13:30:09 +0000
Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89)
 (envelope-from <iwj@xenproject.org>)
 id 1mdBfR-0003n4-1v; Wed, 20 Oct 2021 14:30:05 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date
	:Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From;
	bh=eZ6MegWRPSGQaG9q3EkdReaPvzP+i7ivEkeHV7d9fJk=; b=Ai5UmBROqeBFDABOBTuArF7Hfx
	Ed8rbYDp7Fwec2JAOMV5eKYCNJpbiuXK8Sqh0Um6O63cDYk2E3qUjkCBqCaZDp2WlRw8K4uBVOgow
	QqXtKTzU6jQsKzv4DMUBkLwTQ2zUG224bH3bImrHMwqDCRaEpw2XXpxpW9mb3XLivtYo=;
From: Ian Jackson <iwj@xenproject.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <24944.6620.647052.30281@mariner.uk.xensource.com>
Date: Wed, 20 Oct 2021 14:30:04 +0100
To: Bertrand Marquis <Bertrand.Marquis@arm.com>
Cc: Hongda Deng <Hongda.Deng@arm.com>,
    Xen-devel <xen-devel@lists.xenproject.org>,
    Stefano Stabellini <sstabellini@kernel.org>,
    Julien Grall <julien@xen.org>,
    Wei Chen <Wei.Chen@arm.com>
Subject: Re: [PATCH v3] xen/arm: vgic to ignore GICD ICPENDRn registers access
In-Reply-To: <87512F00-48DA-4E66-B3A8-47F48B9C6A87@arm.com>
References: <20211020101021.9793-1-Hongda.Deng@arm.com>
	<87512F00-48DA-4E66-B3A8-47F48B9C6A87@arm.com>
X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu)

~Bertrand Marquis writes ("Re: [PATCH v3] xen/arm: vgic to ignore GICD ICPENDRn registers access"):
> [+Ian]
> > On 20 Oct 2021, at 11:10, Hongda Deng <Hongda.Deng@arm.com> wrote:
> > 
> > Currently, Xen will return IO unhandled when guests access GICD ICPENRn
> > registers. This will raise a data abort inside guest. For Linux Guest,
> > these virtual registers will not be accessed. But for Zephyr, in its
> > GIC initialization code, these virtual registers will be accessed. And
> > zephyr guest will get an IO data abort in initilization stage and enter
> > fatal error. Emulating ICPENDR is not easy with the existing vGIC, so
> > we currently ignore these virtual registers access and print a message
> > about whether they are already pending instead of returning unhandled.
> > More details can be found at [1].
> > 
> > [1] https://github.com/zephyrproject-rtos/zephyr/blob/eaf6cf745df3807e6e
> > cc941c3a30de6c179ae359/drivers/interrupt_controller/intc_gicv3.c#L274
> > 
> > Signed-off-by: Hongda Deng <hongda.deng@arm.com>
> Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>
> 
> Ian this is fixing a bug in the vgic implementation which is preventing to run
> Zephyr as a guest on top of Xen. Xen support has now been merged in Zephyr
> so this is required to use it.
> 
> Could we consider adding this patch into the 4.16 release ?

Hi.  I'm definitely open to the idea, especially if it goes in soon.

I think this needs an ARM maintainer review, still ?

It doesn't seem entirely straightforward.  I'd like to hear from the
maintainer, to confirm that they agree it's a bugfix, and to get an
idea of the risks vs benefits of this patch.

Thanks,
Ian.


From xen-devel-bounces@lists.xenproject.org Wed Oct 20 14:01:32 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Oct 2021 14:01:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.213945.372320 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdC9b-0007fg-Cy; Wed, 20 Oct 2021 14:01:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 213945.372320; Wed, 20 Oct 2021 14:01:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdC9b-0007fZ-A5; Wed, 20 Oct 2021 14:01:15 +0000
Received: by outflank-mailman (input) for mailman id 213945;
 Wed, 20 Oct 2021 14:01:13 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mdC9Z-0007fT-Dx
 for xen-devel@lists.xenproject.org; Wed, 20 Oct 2021 14:01:13 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mdC9Z-0006WR-7F; Wed, 20 Oct 2021 14:01:13 +0000
Received: from [54.239.6.185] (helo=[192.168.28.129])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mdC9Z-0001uD-1B; Wed, 20 Oct 2021 14:01:13 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=UDLN0WY+QBoB01llYS7r/7aUZ6DRkuotoiuM3cnHUHw=; b=sPFSAcHAHLUkW4CovO3pOZGEEk
	TKHoZMVVyVWuHYoz7nyfnSAywUmtfraksGulYeP2mGcKjxs9W57GhBXjB9lp2ecCPV79yx9xHwYrO
	QVOnsIhe6GGk+74A9bdRO40Zm3VtYbcXGuy1YF1tozQliucTDK4/y7ofNIBHPwWMMe2c=;
Message-ID: <d8b62ee4-f782-439e-1f37-01d8616a8566@xen.org>
Date: Wed, 20 Oct 2021 15:01:11 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.2.0
Subject: Re: [PATCH v3] xen/arm: vgic to ignore GICD ICPENDRn registers access
To: Ian Jackson <iwj@xenproject.org>,
 Bertrand Marquis <Bertrand.Marquis@arm.com>
Cc: Hongda Deng <Hongda.Deng@arm.com>,
 Xen-devel <xen-devel@lists.xenproject.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Chen <Wei.Chen@arm.com>
References: <20211020101021.9793-1-Hongda.Deng@arm.com>
 <87512F00-48DA-4E66-B3A8-47F48B9C6A87@arm.com>
 <24944.6620.647052.30281@mariner.uk.xensource.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <24944.6620.647052.30281@mariner.uk.xensource.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Ian,

On 20/10/2021 14:30, Ian Jackson wrote:
> ~Bertrand Marquis writes ("Re: [PATCH v3] xen/arm: vgic to ignore GICD ICPENDRn registers access"):
>> [+Ian]
>>> On 20 Oct 2021, at 11:10, Hongda Deng <Hongda.Deng@arm.com> wrote:
>>>
>>> Currently, Xen will return IO unhandled when guests access GICD ICPENRn
>>> registers. This will raise a data abort inside guest. For Linux Guest,
>>> these virtual registers will not be accessed. But for Zephyr, in its
>>> GIC initialization code, these virtual registers will be accessed. And
>>> zephyr guest will get an IO data abort in initilization stage and enter
>>> fatal error. Emulating ICPENDR is not easy with the existing vGIC, so
>>> we currently ignore these virtual registers access and print a message
>>> about whether they are already pending instead of returning unhandled.
>>> More details can be found at [1].
>>>
>>> [1] https://github.com/zephyrproject-rtos/zephyr/blob/eaf6cf745df3807e6e
>>> cc941c3a30de6c179ae359/drivers/interrupt_controller/intc_gicv3.c#L274
>>>
>>> Signed-off-by: Hongda Deng <hongda.deng@arm.com>
>> Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>
>>
>> Ian this is fixing a bug in the vgic implementation which is preventing to run
>> Zephyr as a guest on top of Xen. Xen support has now been merged in Zephyr
>> so this is required to use it.
>>
>> Could we consider adding this patch into the 4.16 release ?
> 
> Hi.  I'm definitely open to the idea, especially if it goes in soon.
> 
> I think this needs an ARM maintainer review, still ?

Yes. I am planning to review it later today.

> 
> It doesn't seem entirely straightforward.  I'd like to hear from the
> maintainer, to confirm that they agree it's a bugfix, and to get an
> idea of the risks vs benefits of this patch.

TL;DR: This is a bug fix and I agree that this should be included in 4.16.

ICPENDRn are a mandatory registers of the GIC implementation. But it is 
not trivial to emulate properly with our existing vGIC. So for the past 
years, we chose the lazy approach and inject a data abort when the vCPU 
access it.

IOW, this is not a new bug fix. We haven't seen any problem before 
because most of our users were using Linux based guests. Now this is 
starting to change and therefore we are exercising paths that Linux 
never used it. In this case, we would not be able to boot Zephyr on Xen.

During boot, Zephyr will write to ICPENDR to clear all the pending 
interrupts. I am not entirely convinced that from Zephyr PoV this is a 
useful things to do because, unless you quiesced the devices, interrupts 
can become pending again right away after clearing.

I would suggest to chat with the Zephyr folks to understand why they 
need to write to ICPENDR during boot.

In any case, I am assuming there are already Zephyr OS out there. So we 
need to solve the issue in Xen.

This patch doesn't fully emulate ICPENDR. The new appropach will ignore 
access and print a message when the OS is trying to clear a pending 
interrupt.

The code itself is only walking the internal structure. So as long as 
the correct locks are held, there is no change in the emulated state.

The only difference will happen at the domain level. Now, the domain 
will be able to continue booting. We will not clear pending interrupts 
but I think this is an acceptable approach as the worst that can happen 
is the guest may receive a "spurious" interrupt.

In both cases, I think the risks are limited and I would support the 
inclusion of this patch (pending appropriate acks) in 4.16.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Oct 20 14:03:45 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Oct 2021 14:03:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.213953.372332 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdCC0-0008GM-QK; Wed, 20 Oct 2021 14:03:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 213953.372332; Wed, 20 Oct 2021 14:03:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdCC0-0008GF-N2; Wed, 20 Oct 2021 14:03:44 +0000
Received: by outflank-mailman (input) for mailman id 213953;
 Wed, 20 Oct 2021 14:03:44 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=vRSV=PI=gmail.com=jandryuk@srs-us1.protection.inumbo.net>)
 id 1mdCBz-0008G6-V2
 for xen-devel@lists.xenproject.org; Wed, 20 Oct 2021 14:03:44 +0000
Received: from mail-lj1-x22b.google.com (unknown [2a00:1450:4864:20::22b])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 2bd54665-9053-487b-8e79-0cd243680b66;
 Wed, 20 Oct 2021 14:03:43 +0000 (UTC)
Received: by mail-lj1-x22b.google.com with SMTP id o26so12819600ljj.2
 for <xen-devel@lists.xenproject.org>; Wed, 20 Oct 2021 07:03:42 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2bd54665-9053-487b-8e79-0cd243680b66
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=IzvAZhEEZNk2D8i0OBzMI0Erc+lPwUrgG7lPeht66ww=;
        b=nvLuWP9blWTMC8O2co8iofObAEe/Uw3KBpWpSwPeW7PbYKykN6NS6DuGNfsQc1hdJF
         qQMNkNsAuUNo91gabiB4ZhC26GWHeZ0wCE+7VFIW8OCR0m15WgHXlOHxOJqrfJiXqJKa
         T9FZantVOYEZtefD1zrOsGBJVKtmHct3Q4N+CdjKySCxeNpd3Ls3n+q5652UUhcmy0bD
         wo0wLMWT1CQFypDwftXOnGDVOdLlR1JC2cVXpRK4vJeQVjptqWo3sTP8bCAywNbIW3IT
         Htryo8+ctSwrg+H+cieRm76WeL19lDyBahaooYSZAoh/4tYABflbw/CrQf/HKH0INQ2F
         NjbQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=IzvAZhEEZNk2D8i0OBzMI0Erc+lPwUrgG7lPeht66ww=;
        b=3U1RXwu1r826EZviqCI0Kk+9Czr0jZymg4rysR7fm32ezPCc5azMOyyBczGiVhW9X9
         UY26RLZOfz2/6mHGdXuSkbjXiZTWqeV3a+eQD8tN6Y8Q2kreZr116woT0ItOdb4daI1+
         z/5yKdO/r+ypCOyubn5PSjE2Uk+SSohNeKFIIE58ytaRbyylCPjT7L8XmSRfRsZRDETL
         YK2p9Io2nvocuhWnDxvxQaGjx6PcR09SgvhFABFNfv0ax/FOXnDu81+HpcuNXfw2P8BK
         MAb1Olyv1QMA7GjCTjik+IpeijUHYiKpcYY5a5ISFA2AZuW0LqxQYOyeS3vwlxAbJEUN
         dmPA==
X-Gm-Message-State: AOAM533agaI0bcE+5hWps5rJnBcDvx9PE+pqrS4W4RAgjWpf8g/iKKe5
	wwBNhQtqMuvle7CajoWfl0rFPkcpYY0HYiOYI3s=
X-Google-Smtp-Source: ABdhPJyITdeKpXSmOLSbF+vxTekkL41/oKy0b7me+iwSGmPYFq4hvtYX532gltEEcHiHcxou9amIxVDBcPrxPcnCO7Y=
X-Received: by 2002:a05:651c:283:: with SMTP id b3mr13982322ljo.459.1634738620768;
 Wed, 20 Oct 2021 07:03:40 -0700 (PDT)
MIME-Version: 1.0
References: <20211019202906.GA2397931@bhelgaas> <5f050b30-fa1c-8387-0d6b-a667851b34b0@oderland.se>
 <877de7dfl2.wl-maz@kernel.org>
In-Reply-To: <877de7dfl2.wl-maz@kernel.org>
From: Jason Andryuk <jandryuk@gmail.com>
Date: Wed, 20 Oct 2021 10:03:29 -0400
Message-ID: <CAKf6xpt=ZYGyJXMwM7ccOWkx71R0O-QeLjkBF-LtdDcbSnzHsA@mail.gmail.com>
Subject: Re: [PATCH v2] PCI/MSI: Re-add checks for skip masking MSI-X on Xen PV
To: Marc Zyngier <maz@kernel.org>
Cc: Josef Johansson <josef@oderland.se>, Bjorn Helgaas <helgaas@kernel.org>, linux-pci@vger.kernel.org, 
	xen-devel <xen-devel@lists.xenproject.org>, Thomas Gleixner <tglx@linutronix.de>, 
	Juergen Gross <jgross@suse.com>, Boris Ostrovsky <boris.ostrovsky@oracle.com>
Content-Type: text/plain; charset="UTF-8"

Hi, Marc,

Adding Juergen and Boris since this involves Xen.

On Wed, Oct 20, 2021 at 8:51 AM Marc Zyngier <maz@kernel.org> wrote:
>
> On Tue, 19 Oct 2021 22:48:19 +0100,
> Josef Johansson <josef@oderland.se> wrote:
> >
> > From: Josef Johansson <josef@oderland.se>
> >
> >
> > PCI/MSI: Re-add checks for skip masking MSI-X on Xen PV
> >
> > commit fcacdfbef5a1 ("PCI/MSI: Provide a new set of mask and unmask
> > functions") introduce functions pci_msi_update_mask() and
> > pci_msix_write_vector_ctrl() that is missing checks for
> > pci_msi_ignore_mask that exists in commit 446a98b19fd6 ("PCI/MSI: Use
> > new mask/unmask functions"). Add them back since it is
> > causing severe lockups in amdgpu drivers under Xen during boot.
> >
> > As explained in commit 1a519dc7a73c ("PCI/MSI: Skip masking MSI-X
> > on Xen PV"), when running as Xen PV guest, masking MSI-X is a
> > responsibility of the hypervisor.
> >
> > Fixes: fcacdfbef5a1 ("PCI/MSI: Provide a new set of mask and unmask
> > functions")
> > Suggested-by: Jason Andryuk <jandryuk@gmail.com>
> > Signed-off-by: Josef Johansson <josef@oderland.se>
> >
>
> [...]
>
> >
> > diff --git a/drivers/pci/msi.c b/drivers/pci/msi.c
> > index 0099a00af361..355b791e382f 100644
> > --- a/drivers/pci/msi.c
> > +++ b/drivers/pci/msi.c
> > @@ -148,6 +148,9 @@ static noinline void pci_msi_update_mask(struct msi_desc *desc, u32 clear, u32 s
> >       raw_spinlock_t *lock = &desc->dev->msi_lock;
> >       unsigned long flags;
> >
> > +     if (pci_msi_ignore_mask || desc->msi_attrib.is_virtual)
> > +             return;
> > +
>
> I'd rather be consistent, and keep the check outside of
> pci_msi_update_mask(), just like we do in __pci_msi_mask_desc().
> Something like this instead:
>
> diff --git a/drivers/pci/msi.c b/drivers/pci/msi.c
> index 0099a00af361..6c69eab304ce 100644
> --- a/drivers/pci/msi.c
> +++ b/drivers/pci/msi.c
> @@ -420,7 +420,8 @@ static void __pci_restore_msi_state(struct pci_dev *dev)
>         arch_restore_msi_irqs(dev);
>
>         pci_read_config_word(dev, dev->msi_cap + PCI_MSI_FLAGS, &control);
> -       pci_msi_update_mask(entry, 0, 0);
> +       if (!(pci_msi_ignore_mask || desc->msi_attrib.is_virtual))
> +               pci_msi_update_mask(entry, 0, 0);
>         control &= ~PCI_MSI_FLAGS_QSIZE;
>         control |= (entry->msi_attrib.multiple << 4) | PCI_MSI_FLAGS_ENABLE;
>         pci_write_config_word(dev, dev->msi_cap + PCI_MSI_FLAGS, control);
>
> But the commit message talks about MSI-X, and the above is MSI
> only. Is Xen messing with the former, the latter, or both?

My understanding is pci_msi_ignore_mask covers both MSI and MSI-X for Xen.

> >       raw_spin_lock_irqsave(lock, flags);
> >       desc->msi_mask &= ~clear;
> >       desc->msi_mask |= set;
> > @@ -181,6 +184,9 @@ static void pci_msix_write_vector_ctrl(struct msi_desc *desc, u32 ctrl)
> >  {
> >       void __iomem *desc_addr = pci_msix_desc_addr(desc);
> >
> > +     if (pci_msi_ignore_mask || desc->msi_attrib.is_virtual)
> > +             return;
> > +
> >       writel(ctrl, desc_addr + PCI_MSIX_ENTRY_VECTOR_CTRL);
> >  }
>
> I have similar reservations for this one.

The problem here is some of the changes in commit 446a98b19fd6
("PCI/MSI: Use new mask/unmask functions") bypass the checks in
__pci_msi_mask_desc/__pci_msi_unmask_desc.  I've wondered if it would
be cleaner to push all the `if (pci_msi_ignore_mask)` checks down to
the place of the writes.  That keeps dropping the write local to the
write and leaves the higher level code consistent between the regular
and Xen PV cases.  I don't know where checking
desc->msi_attrib.is_virtual is appropriate.

Regards,
Jason


From xen-devel-bounces@lists.xenproject.org Wed Oct 20 14:23:04 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Oct 2021 14:23:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.213963.372342 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdCUc-0002Ct-Hj; Wed, 20 Oct 2021 14:22:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 213963.372342; Wed, 20 Oct 2021 14:22:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdCUc-0002Cm-ED; Wed, 20 Oct 2021 14:22:58 +0000
Received: by outflank-mailman (input) for mailman id 213963;
 Wed, 20 Oct 2021 14:22:57 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mdCUb-0002Cg-88
 for xen-devel@lists.xenproject.org; Wed, 20 Oct 2021 14:22:57 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mdCUa-0006uU-Uo
 for xen-devel@lists.xenproject.org; Wed, 20 Oct 2021 14:22:56 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mdCUa-0003ge-Tl
 for xen-devel@lists.xenproject.org; Wed, 20 Oct 2021 14:22:56 +0000
Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89)
 (envelope-from <iwj@xenproject.org>)
 id 1mdCUU-0003yH-7p; Wed, 20 Oct 2021 15:22:50 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date
	:Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From;
	bh=l07FE9kwsV71KqdkgrWo71pdjbY0thKVx0EQh2/c0eU=; b=y8aHh+2nPd3bjtX6taQ5okhido
	aYbAT2AhD1efmEWTACMNs3zFeZT3DGJTSs10hO8xJq8/tJCGCMzQ9QeI80zBD59Jop/93zuv+x7lX
	khUJ224cW7iFX9tru7jNxY1s2/ZMwWXbtHPoPCgt2s74O8eCH01q9clGo3j/q2TNw73g=;
From: Ian Jackson <iwj@xenproject.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <24944.9785.888660.632099@mariner.uk.xensource.com>
Date: Wed, 20 Oct 2021 15:22:49 +0100
To: Julien Grall <julien@xen.org>
Cc: Bertrand Marquis <Bertrand.Marquis@arm.com>,
    Hongda Deng <Hongda.Deng@arm.com>,
    Xen-devel <xen-devel@lists.xenproject.org>,
    Stefano Stabellini <sstabellini@kernel.org>,
    Wei Chen <Wei.Chen@arm.com>
Subject: Re: [PATCH v3] xen/arm: vgic to ignore GICD ICPENDRn registers access
In-Reply-To: <d8b62ee4-f782-439e-1f37-01d8616a8566@xen.org>
References: <20211020101021.9793-1-Hongda.Deng@arm.com>
	<87512F00-48DA-4E66-B3A8-47F48B9C6A87@arm.com>
	<24944.6620.647052.30281@mariner.uk.xensource.com>
	<d8b62ee4-f782-439e-1f37-01d8616a8566@xen.org>
X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu)

Julien Grall writes ("Re: [PATCH v3] xen/arm: vgic to ignore GICD ICPENDRn registers access"):
> TL;DR: This is a bug fix and I agree that this should be included in 4.16.

Thank you very much for the detailed and helpful reply.

Release-Acked-by: Ian Jackson <iwj@xenproject.org>


From xen-devel-bounces@lists.xenproject.org Wed Oct 20 14:45:30 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Oct 2021 14:45:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.213971.372354 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdCqK-0004Yf-CH; Wed, 20 Oct 2021 14:45:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 213971.372354; Wed, 20 Oct 2021 14:45:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdCqK-0004YY-8s; Wed, 20 Oct 2021 14:45:24 +0000
Received: by outflank-mailman (input) for mailman id 213971;
 Wed, 20 Oct 2021 14:45:22 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mdCqI-0004YS-OB
 for xen-devel@lists.xenproject.org; Wed, 20 Oct 2021 14:45:22 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mdCqI-0007QL-2C; Wed, 20 Oct 2021 14:45:22 +0000
Received: from 54-240-197-224.amazon.com ([54.240.197.224]
 helo=dev-dsk-jgrall-1b-035652ec.eu-west-1.amazon.com)
 by xenbits.xenproject.org with esmtpsa
 (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mdCqH-0005JQ-PP; Wed, 20 Oct 2021 14:45:21 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date:
	Subject:Cc:To:From; bh=mVYo4Q7l4H9spSVZovOiFSmUubsQkmmQfLszDEMKxKM=; b=VCjpvG
	Hq7+LupIfT9soPhBI4afqXvUT5iyzhD7HdwMNiIzPflys+KO9FB4Fdz9vPw8e7J6TZ7oOJ/OrmyoC
	Lk5Ei6mz5x8NowDR/lw5kc/s/OhiX4psixI3Jvdn0U0rIjxsLB+qm4f1F1S6UwsUfi4iUFeVOIvaQ
	XAurETVkrRc=;
From: Julien Grall <julien@xen.org>
To: xen-devel@lists.xenproject.org
Cc: julien@xen.org,
	Julien Grall <jgrall@amazon.com>,
	Ian Jackson <iwj@xenproject.org>,
	Wei Liu <wl@xen.org>,
	Juergen Gross <jgross@suse.com>
Subject: [PATCH for-4.16] tools/xenstored: Ignore domain we were unable to restore
Date: Wed, 20 Oct 2021 14:45:19 +0000
Message-Id: <20211020144519.10362-1-julien@xen.org>
X-Mailer: git-send-email 2.32.0
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Julien Grall <jgrall@amazon.com>

Commit 939775cfd3 "handle dying domains in live update" was meant to
handle gracefully dying domain. However, the @releaseDomain watch
will end up to be sent as soon as we finished to restore Xenstored
state.

This may be before Xen reports the domain to be dying (such as if
the guest decided to revoke access to the xenstore page). Consequently
daemon like xenconsoled will not clean-up the domain and it will be
left as a zombie.

To avoid the problem, mark the connection as ignored. This also
requires to tweak conn_can_write() and conn_can_read() to prevent
dereferencing a NULL pointer (the interface will not mapped).

The check conn->is_ignored was originally added after the callbacks
because the helpers for a socket connection may close the fd. However,
ignore_connection() will close a socket connection directly. So it is
fine to do the re-order.

Signed-off-by: Julien Grall <jgrall@amazon.com>

---

This issue was originally found when developping commit 939775cfd3.
Unfortunately, due to some miscommunication the wrong patch was sent
upstream. The approach is re-using the one we discussed back then.

This was tested by modifying Linux to revoke the Xenstore grant during
boot. Without this patch, the domain will be left after Live-Update. Note
that on a basic setup (only xenconsoled and xl watch @releaseDomain),
the domain may be cleaned on the next domain shutdown/start.

Xenstore Live-Update is so far a tech preview feature. But I would still
like to request this patch to be included in 4.16 as this was meant to
be part of the original work.
---
 tools/xenstore/xenstored_core.c   |  8 ++++----
 tools/xenstore/xenstored_core.h   |  1 +
 tools/xenstore/xenstored_domain.c | 21 ++++++++++++---------
 3 files changed, 17 insertions(+), 13 deletions(-)

diff --git a/tools/xenstore/xenstored_core.c b/tools/xenstore/xenstored_core.c
index 0d4c73d6e20c..91d093a12ea6 100644
--- a/tools/xenstore/xenstored_core.c
+++ b/tools/xenstore/xenstored_core.c
@@ -338,10 +338,10 @@ static int destroy_conn(void *_conn)
 
 static bool conn_can_read(struct connection *conn)
 {
-	if (!conn->funcs->can_read(conn))
+	if (conn->is_ignored)
 		return false;
 
-	if (conn->is_ignored)
+	if (!conn->funcs->can_read(conn))
 		return false;
 
 	/*
@@ -356,7 +356,7 @@ static bool conn_can_read(struct connection *conn)
 
 static bool conn_can_write(struct connection *conn)
 {
-	return conn->funcs->can_write(conn) && !conn->is_ignored;
+	return !conn->is_ignored && conn->funcs->can_write(conn);
 }
 
 /* This function returns index inside the array if succeed, -1 if fail */
@@ -1466,7 +1466,7 @@ static struct {
  *
  * All watches, transactions, buffers will be freed.
  */
-static void ignore_connection(struct connection *conn)
+void ignore_connection(struct connection *conn)
 {
 	struct buffered_data *out, *tmp;
 
diff --git a/tools/xenstore/xenstored_core.h b/tools/xenstore/xenstored_core.h
index 258f6ff38279..07d861d92499 100644
--- a/tools/xenstore/xenstored_core.h
+++ b/tools/xenstore/xenstored_core.h
@@ -206,6 +206,7 @@ struct node *read_node(struct connection *conn, const void *ctx,
 
 struct connection *new_connection(const struct interface_funcs *funcs);
 struct connection *get_connection_by_id(unsigned int conn_id);
+void ignore_connection(struct connection *conn);
 void check_store(void);
 void corrupt(struct connection *conn, const char *fmt, ...);
 
diff --git a/tools/xenstore/xenstored_domain.c b/tools/xenstore/xenstored_domain.c
index 47e9107c144e..d03c7d93a9e7 100644
--- a/tools/xenstore/xenstored_domain.c
+++ b/tools/xenstore/xenstored_domain.c
@@ -268,14 +268,7 @@ void check_domains(void)
 				domain->shutdown = true;
 				notify = 1;
 			}
-			/*
-			 * On Restore, we may have been unable to remap the
-			 * interface and the port. As we don't know whether
-			 * this was because of a dying domain, we need to
-			 * check if the interface and port are still valid.
-			 */
-			if (!dominfo.dying && domain->port &&
-			    domain->interface)
+			if (!dominfo.dying)
 				continue;
 		}
 		if (domain->conn) {
@@ -1303,6 +1296,17 @@ void read_state_connection(const void *ctx, const void *state)
 		if (!domain)
 			barf("domain allocation error");
 
+		conn = domain->conn;
+
+		/*
+		 * We may not have been able to restore the domain (for
+		 * instance because it revoked the Xenstore grant). We need
+		 * to keep it around to send @releaseDomain when it is
+		 * dead. So mark it as ignored.
+		 */
+		if (!domain->port || !domain->interface)
+			ignore_connection(conn);
+
 		if (sc->spec.ring.tdomid != DOMID_INVALID) {
 			tdomain = find_or_alloc_domain(ctx,
 						       sc->spec.ring.tdomid);
@@ -1311,7 +1315,6 @@ void read_state_connection(const void *ctx, const void *state)
 			talloc_reference(domain->conn, tdomain->conn);
 			domain->conn->target = tdomain->conn;
 		}
-		conn = domain->conn;
 	}
 
 	conn->conn_id = sc->conn_id;
-- 
2.32.0



From xen-devel-bounces@lists.xenproject.org Wed Oct 20 14:48:33 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Oct 2021 14:48:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.213979.372364 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdCtM-0005BJ-Q4; Wed, 20 Oct 2021 14:48:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 213979.372364; Wed, 20 Oct 2021 14:48:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdCtM-0005BC-Mx; Wed, 20 Oct 2021 14:48:32 +0000
Received: by outflank-mailman (input) for mailman id 213979;
 Wed, 20 Oct 2021 14:48:31 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mdCtL-0005B6-Gw
 for xen-devel@lists.xenproject.org; Wed, 20 Oct 2021 14:48:31 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mdCtJ-0007VQ-R4; Wed, 20 Oct 2021 14:48:29 +0000
Received: from [54.239.6.185] (helo=[192.168.28.129])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mdCtJ-0005SS-L3; Wed, 20 Oct 2021 14:48:29 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:
	References:Cc:To:From:Subject:MIME-Version:Date:Message-ID;
	bh=UwwupO7u8aeVtxcWJL1Hl3yNiRsNjMoSRB5OurzcRt8=; b=c/oFrCEulOvU6cOZOlbXVq4r9U
	XblMDdNtMQavqNhdI4/oAcBPmhMF1Pksjs2TMpXSlNz269G9uccCwXeZ4obwdMib++GMP/o5aF7T+
	zSBl+nx5cFYyO2U38hnxLxQ1T8rV5k7thAxrDaVuksgxcZ6VDaIVpQ/94Lkig1NxR+cA=;
Message-ID: <c562716d-78aa-1662-065b-65290f0ecf65@xen.org>
Date: Wed, 20 Oct 2021 15:48:27 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.2.0
Subject: Re: [PATCH v2 5/6] tools/xenstored: partially handle domains without
 a shared ring
From: Julien Grall <julien@xen.org>
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
Cc: Juergen Gross <jgross@suse.com>, xen-devel@lists.xenproject.org,
 Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>,
 raphning@amazon.co.uk, "Doebel, Bjoern" <doebel@amazon.de>
References: <20210922082123.54374-1-roger.pau@citrix.com>
 <20210922082123.54374-6-roger.pau@citrix.com>
 <0aed8667-7f31-b0fb-3358-c5fd9a5734a1@xen.org>
 <YUr+K0tg6mspyOyd@MacBook-Air-de-Roger.local>
 <69285850-4168-b30c-db47-8c0649bd1ffc@xen.org>
 <09c4bad1-99e3-5d24-873e-4aca9acd6fed@suse.com>
 <56bb55e3-ca7a-12e6-5848-84756b431846@xen.org>
 <YUwrZS3FOh+hCQle@MacBook-Air-de-Roger.local>
 <041bbb31-700f-0ebd-d255-47a4aec927d8@xen.org>
In-Reply-To: <041bbb31-700f-0ebd-d255-47a4aec927d8@xen.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi all,

On 23/09/2021 08:56, Julien Grall wrote:
> On 23/09/2021 12:23, Roger Pau Monné wrote:
>> On Wed, Sep 22, 2021 at 06:46:25PM +0500, Julien Grall wrote:
>>> I thought a bit more and looked at the code (I don't have access to a 
>>> test
>>> machine at the moment). I think there is indeed a problem.
>>>
>>> Some watchers of @releaseDomain (such as xenconsoled) will only remove a
>>> domain from their internal state when the domain is actually dead.
>>>
>>> This is based on dominfo.dying which is only set when all the 
>>> resources are
>>> relinquished and waiting for the other domains to release any 
>>> resources for
>>> that domain.
>>>
>>> The problem is Xenstore may fail to map the interface or the event 
>>> channel
>>> long before the domain is actually dead. With the current check, we 
>>> would
>>> free the allocated structure and therefore send @releaseDomain too 
>>> early. So
>>> daemon like xenconsoled, would never cleanup for the domain and leave a
>>> zombie domain. Well... until the next @releaseDomain (or 
>>> @introduceDomain
>>> for Xenconsoled) AFAICT.
>>>
>>> The revised patch is meant to solve it by just ignoring the 
>>> connection. With
>>> that approach, we would correctly notify watches when the domain is 
>>> dead.
>>
>> I think the patch provided by Julien is indeed better than the current
>> code, or else you will miss @releaseDomain events in corner cases for
>> dominfo.dying.
>>
>> I think however the patch is missing a change in the order of the
>> checks in conn_can_{read,write}, so that the is_ignored check is
>> performed before calling can_{read,write} which will try to poke at
>> the interface and trigger a fault if not mapped.
> 
> Ah good point. I originally moved the is_ignored check after the 
> callback because the socket connection can in theory be closed from 
> can_{read, write}.
> 
> However, in pratice, is_ignored is only set for socket from 
> ignore_connection() that will also close the socket.
> 
> The new use will only set is_ignored for the domain connection. So I am 
> guessing moving the check early on ought to be fine.
> 
> The alternative would be to call ignore_connection() but this feels a 
> bit weird because most of it would be a NOP as we are introducing the 
> domain.

At the end I went with re-using ignore_connection() and posted a patch 
for discussion:

https://lore.kernel.org/xen-devel/20211020144519.10362-1-julien@xen.org/T/#u

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Oct 20 15:19:39 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Oct 2021 15:19:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.213987.372375 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdDNF-0008O1-8G; Wed, 20 Oct 2021 15:19:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 213987.372375; Wed, 20 Oct 2021 15:19:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdDNF-0008Nu-4w; Wed, 20 Oct 2021 15:19:25 +0000
Received: by outflank-mailman (input) for mailman id 213987;
 Wed, 20 Oct 2021 15:19:24 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mdDND-0008Nk-Vr; Wed, 20 Oct 2021 15:19:23 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mdDND-000826-PQ; Wed, 20 Oct 2021 15:19:23 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mdDND-0002E0-GL; Wed, 20 Oct 2021 15:19:23 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mdDND-0002HU-Ft; Wed, 20 Oct 2021 15:19:23 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=e9RUXNT35J5U20cFyxGv3xyTV951rMJVY93Ol/iRBmM=; b=MREJbhfy3Ffjw5/n+sU97RDUCO
	uulveS1zVR77q1N7ilGkz6X580iLgECDey97fRUWRyR0RiTrSmSeyL2Btn+Wo63YwyN8aKDHkfaPA
	xEIBSG5eKqWclzoF1HQzDtNPfkNSfGWpEmJZmlT6bVD2z8o9yMpzTYN4YOHjLvH1g47U=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165689-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 165689: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=c12731493ae39640c4e44d9fe2029c3165f9f429
X-Osstest-Versions-That:
    xen=6809998c5f8f1d2e26ac9e867af8ac71e7a66cf2
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 20 Oct 2021 15:19:23 +0000

flight 165689 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165689/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  c12731493ae39640c4e44d9fe2029c3165f9f429
baseline version:
 xen                  6809998c5f8f1d2e26ac9e867af8ac71e7a66cf2

Last test of basis   165676  2021-10-19 14:00:27 Z    1 days
Testing same since   165689  2021-10-20 11:02:49 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Jan Beulich <jbeulich@suse.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Thomas Gleixner <tglx@linutronix.de>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   6809998c5f..c12731493a  c12731493ae39640c4e44d9fe2029c3165f9f429 -> smoke


From xen-devel-bounces@lists.xenproject.org Wed Oct 20 15:45:33 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Oct 2021 15:45:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.213997.372393 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdDmO-00037s-Da; Wed, 20 Oct 2021 15:45:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 213997.372393; Wed, 20 Oct 2021 15:45:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdDmO-00037l-Ag; Wed, 20 Oct 2021 15:45:24 +0000
Received: by outflank-mailman (input) for mailman id 213997;
 Wed, 20 Oct 2021 15:45:23 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mdDmN-00037f-Ki
 for xen-devel@lists.xenproject.org; Wed, 20 Oct 2021 15:45:23 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mdDmN-0008SW-Fy
 for xen-devel@lists.xenproject.org; Wed, 20 Oct 2021 15:45:23 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mdDmN-0001Df-Et
 for xen-devel@lists.xenproject.org; Wed, 20 Oct 2021 15:45:23 +0000
Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89)
 (envelope-from <iwj@xenproject.org>)
 id 1mdDmJ-0004If-UX; Wed, 20 Oct 2021 16:45:20 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date
	:Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From;
	bh=jcjgEwRsGmmjSzP3LNYUdjU7tG4+MlDKfHG44Xp3RFw=; b=cZ99fqUh4tWDwI+VkzhCkz0W4Q
	NyDzBATF4o54dVn8z4iJaD2Ys+ZtZX8Pp8TqF/wyqYFb9bRp+RKfn5cqG5VA6a+QXZne+PJFkciG5
	K7G/9uNkvp6cu3Sm+sV80AxCkBHQKOXDAYu3lpf5oT+GB098V1vltwqi2pd3wrUHWWf0=;
From: Ian Jackson <iwj@xenproject.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <24944.14735.525284.612126@mariner.uk.xensource.com>
Date: Wed, 20 Oct 2021 16:45:19 +0100
To: Julien Grall <julien@xen.org>
Cc: xen-devel@lists.xenproject.org,
    Julien Grall <jgrall@amazon.com>,
    Ian Jackson <iwj@xenproject.org>,
    Wei Liu <wl@xen.org>,
    Juergen Gross <jgross@suse.com>
Subject: Re: [PATCH for-4.16] tools/xenstored: Ignore domain we were unable to restore
In-Reply-To: <20211020144519.10362-1-julien@xen.org>
References: <20211020144519.10362-1-julien@xen.org>
X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu)

Julien Grall writes ("[PATCH for-4.16] tools/xenstored: Ignore domain we were unable to restore"):
> From: Julien Grall <jgrall@amazon.com>
> 
> Commit 939775cfd3 "handle dying domains in live update" was meant to
> handle gracefully dying domain. However, the @releaseDomain watch
> will end up to be sent as soon as we finished to restore Xenstored
> state.
> 
> This may be before Xen reports the domain to be dying (such as if
> the guest decided to revoke access to the xenstore page). Consequently
> daemon like xenconsoled will not clean-up the domain and it will be
> left as a zombie.
> 
> To avoid the problem, mark the connection as ignored. This also
> requires to tweak conn_can_write() and conn_can_read() to prevent
> dereferencing a NULL pointer (the interface will not mapped).
> 
> The check conn->is_ignored was originally added after the callbacks
> because the helpers for a socket connection may close the fd. However,
> ignore_connection() will close a socket connection directly. So it is
> fine to do the re-order.

Release-Acked-by: Ian Jackson <iwj@xenproject.org>


From xen-devel-bounces@lists.xenproject.org Wed Oct 20 15:56:31 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Oct 2021 15:56:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.214005.372404 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdDx5-0004Zy-Do; Wed, 20 Oct 2021 15:56:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 214005.372404; Wed, 20 Oct 2021 15:56:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdDx5-0004Zr-Av; Wed, 20 Oct 2021 15:56:27 +0000
Received: by outflank-mailman (input) for mailman id 214005;
 Wed, 20 Oct 2021 15:56:26 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=lw/m=PI=kernel.org=kuba@srs-us1.protection.inumbo.net>)
 id 1mdDx4-0004Zl-Eb
 for xen-devel@lists.xenproject.org; Wed, 20 Oct 2021 15:56:26 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id c2070466-b9f2-4a0b-832b-0045a3c1c753;
 Wed, 20 Oct 2021 15:56:25 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id 90CCE613A9;
 Wed, 20 Oct 2021 15:56:24 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c2070466-b9f2-4a0b-832b-0045a3c1c753
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1634745384;
	bh=R+swL9rmtFSenC2ia6irgU9Xg+bV/QFrmjtvxo3XbsE=;
	h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
	b=g7dmnVbOEq0DGrt2G18FaHqWKUjiiogE7RW0GmNbyB4M3tXS0BH4nYaYWeeDx9LNa
	 ncqgJkB+qH7CU0awEMRWLgSP6mttePSpz4ZY9JjXJuaC3satz0ip88ZGT1ebV2OnrU
	 RCuPbSgBARIpPJ18V8GxooYJgPHh9oiPvLuskfadSQdWjQG+b26879eVPNHkwg2h8Z
	 WyVtWxwYaSmyw2N1d3i3kI9bsMzakCU13AWlwmajuEEcnKGACcfEFSGfuIeUqsx5is
	 xKL3mOJYvhllJ7/V8F5JVnxmj+s4E0rbbmwwjY9YzuTmqiVEK1crtF6CoqNMIkzKoY
	 mE+bHAZMu6OJg==
From: Jakub Kicinski <kuba@kernel.org>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org,
	Jakub Kicinski <kuba@kernel.org>,
	wei.liu@kernel.org,
	paul@xen.org,
	boris.ostrovsky@oracle.com,
	jgross@suse.com,
	sstabellini@kernel.org,
	xen-devel@lists.xenproject.org
Subject: [PATCH net-next 01/12] net: xen: use eth_hw_addr_set()
Date: Wed, 20 Oct 2021 08:56:06 -0700
Message-Id: <20211020155617.1721694-2-kuba@kernel.org>
X-Mailer: git-send-email 2.31.1
In-Reply-To: <20211020155617.1721694-1-kuba@kernel.org>
References: <20211020155617.1721694-1-kuba@kernel.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Commit 406f42fa0d3c ("net-next: When a bond have a massive amount
of VLANs...") introduced a rbtree for faster Ethernet address look
up. To maintain netdev->dev_addr in this tree we need to make all
the writes to it got through appropriate helpers.

Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
CC: wei.liu@kernel.org
CC: paul@xen.org
CC: boris.ostrovsky@oracle.com
CC: jgross@suse.com
CC: sstabellini@kernel.org
CC: xen-devel@lists.xenproject.org
---
 drivers/net/xen-netback/interface.c | 6 ++++--
 drivers/net/xen-netfront.c          | 4 +++-
 2 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/drivers/net/xen-netback/interface.c b/drivers/net/xen-netback/interface.c
index c58996c1e230..fe8e21ad8ed9 100644
--- a/drivers/net/xen-netback/interface.c
+++ b/drivers/net/xen-netback/interface.c
@@ -494,6 +494,9 @@ static const struct net_device_ops xenvif_netdev_ops = {
 struct xenvif *xenvif_alloc(struct device *parent, domid_t domid,
 			    unsigned int handle)
 {
+	static const u8 dummy_addr[ETH_ALEN] = {
+		0xfe, 0xff, 0xff, 0xff, 0xff, 0xff,
+	};
 	int err;
 	struct net_device *dev;
 	struct xenvif *vif;
@@ -551,8 +554,7 @@ struct xenvif *xenvif_alloc(struct device *parent, domid_t domid,
 	 * stolen by an Ethernet bridge for STP purposes.
 	 * (FE:FF:FF:FF:FF:FF)
 	 */
-	eth_broadcast_addr(dev->dev_addr);
-	dev->dev_addr[0] &= ~0x01;
+	eth_hw_addr_set(dev, dummy_addr);
 
 	netif_carrier_off(dev);
 
diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c
index e31b98403f31..57437e4b8a94 100644
--- a/drivers/net/xen-netfront.c
+++ b/drivers/net/xen-netfront.c
@@ -2157,6 +2157,7 @@ static int talk_to_netback(struct xenbus_device *dev,
 	unsigned int max_queues = 0;
 	struct netfront_queue *queue = NULL;
 	unsigned int num_queues = 1;
+	u8 addr[ETH_ALEN];
 
 	info->netdev->irq = 0;
 
@@ -2170,11 +2171,12 @@ static int talk_to_netback(struct xenbus_device *dev,
 					"feature-split-event-channels", 0);
 
 	/* Read mac addr. */
-	err = xen_net_read_mac(dev, info->netdev->dev_addr);
+	err = xen_net_read_mac(dev, addr);
 	if (err) {
 		xenbus_dev_fatal(dev, err, "parsing %s/mac", dev->nodename);
 		goto out_unlocked;
 	}
+	eth_hw_addr_set(info->netdev, addr);
 
 	info->netback_has_xdp_headroom = xenbus_read_unsigned(info->xbdev->otherend,
 							      "feature-xdp-headroom", 0);
-- 
2.31.1



From xen-devel-bounces@lists.xenproject.org Wed Oct 20 16:27:58 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Oct 2021 16:27:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.214013.372415 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdERJ-0008Gx-Rs; Wed, 20 Oct 2021 16:27:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 214013.372415; Wed, 20 Oct 2021 16:27:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdERJ-0008Gq-Oz; Wed, 20 Oct 2021 16:27:41 +0000
Received: by outflank-mailman (input) for mailman id 214013;
 Wed, 20 Oct 2021 16:27:39 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mdERH-0008Gd-PV; Wed, 20 Oct 2021 16:27:39 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mdERH-0001Fu-Ji; Wed, 20 Oct 2021 16:27:39 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mdERH-0005ri-9I; Wed, 20 Oct 2021 16:27:39 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mdERH-0001DO-8k; Wed, 20 Oct 2021 16:27:39 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=HcNnM7GoLwHNVup2KZtlLEVPW2EduFLyjmwvPKnNWmw=; b=gVcPj7CnetLozvMleO/Bp9NZt5
	SlsETDKdz1gEwVMRSMx5w3XTU6rPCD72Qid7d39Cc7m69NN3IVoDH51HFZ+BlG+wTQvvgzYWBxfIq
	LkpgMZ0TLwxhbZjLTneNPu+XbtL2FUpCyWojPQW0iCY1KpJRwr4NtKd02LXu/jq54egc=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165684-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 165684: tolerable FAIL
X-Osstest-Failures:
    xen-unstable:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=6809998c5f8f1d2e26ac9e867af8ac71e7a66cf2
X-Osstest-Versions-That:
    xen=6809998c5f8f1d2e26ac9e867af8ac71e7a66cf2
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 20 Oct 2021 16:27:39 +0000

flight 165684 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165684/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 165681
 test-armhf-armhf-xl-rtds     18 guest-start/debian.repeat  fail pass in 165681

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 165681
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 165681
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165681
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165681
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 165681
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 165681
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 165681
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 165681
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 165681
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 165681
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165681
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 165681
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  6809998c5f8f1d2e26ac9e867af8ac71e7a66cf2
baseline version:
 xen                  6809998c5f8f1d2e26ac9e867af8ac71e7a66cf2

Last test of basis   165684  2021-10-20 05:36:15 Z    0 days
Testing same since                          (not found)         0 attempts

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 fail    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Published tested tree is already up to date.



From xen-devel-bounces@lists.xenproject.org Wed Oct 20 17:16:57 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Oct 2021 17:16:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.214024.372429 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdFCt-0004pd-IZ; Wed, 20 Oct 2021 17:16:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 214024.372429; Wed, 20 Oct 2021 17:16:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdFCt-0004pW-FZ; Wed, 20 Oct 2021 17:16:51 +0000
Received: by outflank-mailman (input) for mailman id 214024;
 Wed, 20 Oct 2021 17:16:50 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mdFCs-0004pM-K8; Wed, 20 Oct 2021 17:16:50 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mdFCs-000262-7X; Wed, 20 Oct 2021 17:16:50 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mdFCs-0007Uz-02; Wed, 20 Oct 2021 17:16:50 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mdFCr-0003e6-Vo; Wed, 20 Oct 2021 17:16:49 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=lGjVA4dEyyLY/QzEoiOnREoSVG3pAJq2DV4EFETrMP4=; b=kWjnK1PWT94LoTo0SZonnMzzSl
	uVWPPLAf6vsd4Lf5MV+JHl41mtMQvjgyQWTHF4LWVoyFeVC306gOmx7vbHHgKHodixxSioLX0jk73
	UU9X55qaFvZ2G9y4F4UZetBb2rp/mw19pf+90iUnhKhBd+NgEVwGkHSGewHbZRaVRRx4=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165690-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 165690: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=6893865b3010bb6192f732643c4b8ba026726d07
X-Osstest-Versions-That:
    ovmf=4fdf843c75d297fe892f989009b3d3e397ccfd55
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 20 Oct 2021 17:16:49 +0000

flight 165690 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165690/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 6893865b3010bb6192f732643c4b8ba026726d07
baseline version:
 ovmf                 4fdf843c75d297fe892f989009b3d3e397ccfd55

Last test of basis   165688  2021-10-20 10:13:27 Z    0 days
Testing same since   165690  2021-10-20 13:40:00 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Pierre Gondois <Pierre.Gondois@arm.com>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   4fdf843c75..6893865b30  6893865b3010bb6192f732643c4b8ba026726d07 -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Wed Oct 20 17:45:07 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Oct 2021 17:45:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.214033.372443 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdFe1-0007wa-RM; Wed, 20 Oct 2021 17:44:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 214033.372443; Wed, 20 Oct 2021 17:44:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdFe1-0007wT-OQ; Wed, 20 Oct 2021 17:44:53 +0000
Received: by outflank-mailman (input) for mailman id 214033;
 Wed, 20 Oct 2021 17:44:52 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mdFe0-0007wN-8D
 for xen-devel@lists.xenproject.org; Wed, 20 Oct 2021 17:44:52 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mdFe0-0002Xx-1Z; Wed, 20 Oct 2021 17:44:52 +0000
Received: from [54.239.6.185] (helo=[192.168.28.129])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mdFdz-0006Vn-Ra; Wed, 20 Oct 2021 17:44:51 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=lnUufDzmqrfkpoDsqMN6bHxloRQxnwp/dc6IOvJTuG0=; b=0DlWUPe3HT+UweE0mnRDk2nklK
	V8XakiA47PywLhrpQGO89DcaeyfwUpgTy8NF22wOHkeSB2zrqdg213JZ8o+aXqIeCY+h5Zwrq8DIn
	UZFakI11g16NhKhXD/CAcgEJ79oz8XZ0QFkG51mTW0E/wZL6GLaA4+Wrh7GJOGLpWmAc=;
Message-ID: <f856653e-b8ea-c632-be6d-5dbb1b18c5f8@xen.org>
Date: Wed, 20 Oct 2021 18:44:49 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.2.0
Subject: Re: [PATCH v3] xen/arm: vgic to ignore GICD ICPENDRn registers access
To: Hongda Deng <Hongda.Deng@arm.com>, xen-devel@lists.xenproject.org,
 sstabellini@kernel.org
Cc: Bertrand.Marquis@arm.com, Wei.Chen@arm.com
References: <20211020101021.9793-1-Hongda.Deng@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20211020101021.9793-1-Hongda.Deng@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi Hongda,

Title: I would suggest the following title:

xen/arm: vgic: Ignore write access to ICPENDR*

On 20/10/2021 11:10, Hongda Deng wrote:
> Currently, Xen will return IO unhandled when guests access GICD ICPENRn
> registers. This will raise a data abort inside guest. For Linux Guest,
> these virtual registers will not be accessed. But for Zephyr, in its
> GIC initialization code, these virtual registers will be accessed. And
> zephyr guest will get an IO data abort in initilization stage and enter
Typo: s/initilization/initialization/

I would also s/in/during the/

> fatal error. Emulating ICPENDR is not easy with the existing vGIC, so

How about s/enter fatal error/crash/?

> we currently ignore these virtual registers access and print a message

To me 'currently' refers to the existing code base (i.e. without your 
patch). In fact, this seems to be how you use 'currently' in the first 
paragraph. So how about replace "so we currently" with "rework the 
emulation to ignore...".

This seems to suggest the patch will modify both read and write access. 
However, AFAICT, only the write emulation is modified. Can this be 
clarified in the commit message?

> about whether they are already pending instead of returning unhandled.
> More details can be found at [1].
> 
> [1] https://github.com/zephyrproject-rtos/zephyr/blob/eaf6cf745df3807e6e
> cc941c3a30de6c179ae359/drivers/interrupt_controller/intc_gicv3.c#L274
> 
> Signed-off-by: Hongda Deng <hongda.deng@arm.com>
> ---
> Changes since v2:
>   *  Avoid to print messages when there is no pending interrupt
>   *  Add helper vgic_check_inflight_irqs_pending to check pending status
>   *  Print a message for each interrupt separately
> Changes since v1:
>   *  Check pending states by going through vcpu->arch.vgic.inflight_irqs
>      instead of checking hardware registers
> ---
>   xen/arch/arm/vgic-v2.c     | 10 ++++++----
>   xen/arch/arm/vgic-v3.c     | 16 ++++++++--------
>   xen/arch/arm/vgic.c        | 36 ++++++++++++++++++++++++++++++++++++
>   xen/include/asm-arm/vgic.h |  3 ++-
>   4 files changed, 52 insertions(+), 13 deletions(-)
> 
> diff --git a/xen/arch/arm/vgic-v2.c b/xen/arch/arm/vgic-v2.c
> index b2da886adc..7c30da327c 100644
> --- a/xen/arch/arm/vgic-v2.c
> +++ b/xen/arch/arm/vgic-v2.c
> @@ -481,10 +481,12 @@ static int vgic_v2_distr_mmio_write(struct vcpu *v, mmio_info_t *info,
>   
>       case VRANGE32(GICD_ICPENDR, GICD_ICPENDRN):
>           if ( dabt.size != DABT_WORD ) goto bad_width;
> -        printk(XENLOG_G_ERR
> -               "%pv: vGICD: unhandled word write %#"PRIregister" to ICPENDR%d\n",
> -               v, r, gicd_reg - GICD_ICPENDR);
> -        return 0;
> +        rank = vgic_rank_offset(v, 1, gicd_reg - GICD_ICPENDR, DABT_WORD);
> +        if ( rank == NULL ) goto write_ignore;
> +
> +        vgic_check_inflight_irqs_pending(v->domain, v, rank->index, r); > +
> +        goto write_ignore_32;

NIT: We already check the access above. So I would simply use 
"write_ignore" here.

>   
>       case VRANGE32(GICD_ISACTIVER, GICD_ISACTIVERN):
>           if ( dabt.size != DABT_WORD ) goto bad_width;
> diff --git a/xen/arch/arm/vgic-v3.c b/xen/arch/arm/vgic-v3.c
> index cb5a70c42e..4913301d22 100644
> --- a/xen/arch/arm/vgic-v3.c
> +++ b/xen/arch/arm/vgic-v3.c
> @@ -817,10 +817,12 @@ static int __vgic_v3_distr_common_mmio_write(const char *name, struct vcpu *v,
>   
>       case VRANGE32(GICD_ICPENDR, GICD_ICPENDRN):
>           if ( dabt.size != DABT_WORD ) goto bad_width;
> -        printk(XENLOG_G_ERR
> -               "%pv: %s: unhandled word write %#"PRIregister" to ICPENDR%d\n",
> -               v, name, r, reg - GICD_ICPENDR);
> -        return 0;
> +        rank = vgic_rank_offset(v, 1, reg - GICD_ICPENDR, DABT_WORD);
> +        if ( rank == NULL ) goto write_ignore;
> +
> +        vgic_check_inflight_irqs_pending(v->domain, v, rank->index, r);
> +
> +        goto write_ignore_32;

NIT: Same remark as the previous write_ignore_32.

>   
>       case VRANGE32(GICD_ISACTIVER, GICD_ISACTIVERN):
>           if ( dabt.size != DABT_WORD ) goto bad_width;
> @@ -987,10 +989,8 @@ static int vgic_v3_rdistr_sgi_mmio_write(struct vcpu *v, mmio_info_t *info,
>   
>       case VREG32(GICR_ICPENDR0):
>           if ( dabt.size != DABT_WORD ) goto bad_width;
> -        printk(XENLOG_G_ERR
> -               "%pv: vGICR: SGI: unhandled word write %#"PRIregister" to ICPENDR0\n",
> -               v, r);
> -        return 0;
> +        return __vgic_v3_distr_common_mmio_write("vGICR: SGI", v,
> +                                                 info, gicr_reg, r);
>   
>       case VREG32(GICR_IGRPMODR0):
>           /* We do not implement security extensions for guests, write ignore */
> diff --git a/xen/arch/arm/vgic.c b/xen/arch/arm/vgic.c
> index 8f9400a519..0565557814 100644
> --- a/xen/arch/arm/vgic.c
> +++ b/xen/arch/arm/vgic.c
> @@ -726,6 +726,42 @@ unsigned int vgic_max_vcpus(unsigned int domctl_vgic_version)
>       }
>   }
>   
> +void vgic_check_inflight_irqs_pending(struct domain *d, struct vcpu *v,
> +                                      unsigned int rank, uint32_t r)
> +{
> +    const unsigned long mask = r;
> +    unsigned int i;
> +    unsigned long flags;
> +    struct pending_irq *p;
> +    bool private = rank == 0;
> +    struct vcpu *v_target;

AFAIC, flags, p, v_target are only used within the loop. So please 
reduce the scope and only declare them in for_each_set_bit().

> +
> +    for_each_set_bit( i, &mask, 32 )
> +    {
> +        unsigned int irq = i + 32 * rank;
> +
> +        if ( private )
> +            v_target = vgic_get_target_vcpu(v, irq);
> +        else
> +            v_target = vgic_get_target_vcpu(d->vcpu[0], irq);

Shared interrupts can be accessed from any vCPU. So you can replace the 
4 lines with:
    v_target = vgic_get_target_vcpu(v, irq);

> +
> +        spin_lock_irqsave(&v_target->arch.vgic.lock, flags);
> +
> +        p = irq_to_pending(v_target, irq);
> +
> +        if ( unlikely(!p) )
> +        {
> +            spin_unlock_irqrestore(&v_target->arch.vgic.lock, flags);
> +            continue;
> +        }

irq_to_pending() cannot return NULL for non-LPI interrupts. But if you 
still want to check it, then the two if can be combined to something like:

if ( p && !list_empty(&p->inflight) )
   printk(...)

spin_unlock_irqrestore(...);

> +
> +        if ( !list_empty(&p->inflight) )
> +            printk("%pv trying to clear pending interrupt %u.\n", v, irq);

This wants to be a printk(XENLOG_G_WARNING ...) so the message will be 
appropriately rate-limited.

> +
> +        spin_unlock_irqrestore(&v_target->arch.vgic.lock, flags);
> +    }
> +}
> +
>   /*
>    * Local variables:
>    * mode: C
> diff --git a/xen/include/asm-arm/vgic.h b/xen/include/asm-arm/vgic.h
> index 62c2ae538d..abcaae2969 100644
> --- a/xen/include/asm-arm/vgic.h
> +++ b/xen/include/asm-arm/vgic.h
> @@ -298,7 +298,8 @@ extern bool vgic_to_sgi(struct vcpu *v, register_t sgir,
>                           enum gic_sgi_mode irqmode, int virq,
>                           const struct sgi_target *target);
>   extern bool vgic_migrate_irq(struct vcpu *old, struct vcpu *new, unsigned int irq);
> -
> +extern void vgic_check_inflight_irqs_pending(struct domain *d, struct vcpu *v,
> +                                             unsigned int rank, uint32_t r);

Please keep the newline before the #endif.

>   #endif /* !CONFIG_NEW_VGIC */
>   
>   /*** Common VGIC functions used by Xen arch code ****/
> 

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Oct 20 17:55:47 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Oct 2021 17:55:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.214041.372455 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdFoU-0000zJ-S1; Wed, 20 Oct 2021 17:55:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 214041.372455; Wed, 20 Oct 2021 17:55:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdFoU-0000zC-Ox; Wed, 20 Oct 2021 17:55:42 +0000
Received: by outflank-mailman (input) for mailman id 214041;
 Wed, 20 Oct 2021 17:55:41 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mdFoT-0000z4-Cx
 for xen-devel@lists.xenproject.org; Wed, 20 Oct 2021 17:55:41 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mdFoT-0002iS-4y; Wed, 20 Oct 2021 17:55:41 +0000
Received: from [54.239.6.185] (helo=[192.168.28.129])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mdFoS-0007Lp-VJ; Wed, 20 Oct 2021 17:55:41 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=DCzFL+DAXXexd1S4orB6X3aWwiP41BcH9Wxt/IoTMaE=; b=Ji3zmivH1oyP+ELBxw5iCCxihl
	SNY1JIOwcOvXYq//moNHP7fczM7Okj1LwzWBhnYGbROs4lv2W1RQs90J50WlPTQZRbCv53qWKz0gr
	J6dUKWmUQNI6vVoiX0V3K6lIFAUP6YyUfeYsZBB0eLtzDtcu09Vynk5/aSomRd/wUCo0=;
Message-ID: <84b84cc5-1726-ec47-e598-9a768bc29de1@xen.org>
Date: Wed, 20 Oct 2021 18:55:39 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.2.0
Subject: Re: [XEN][RFC PATCH 01/13] device tree: Remove __init from function
 type
To: Vikram Garhwal <fnu.vikram@xilinx.com>, xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <1630562763-390068-1-git-send-email-fnu.vikram@xilinx.com>
 <1630562763-390068-2-git-send-email-fnu.vikram@xilinx.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <1630562763-390068-2-git-send-email-fnu.vikram@xilinx.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Vikram,

Apologies for the late answer. I was away most of September and still 
catching up with my e-mails.

On 02/09/2021 07:05, Vikram Garhwal wrote:
> Change function type of following function to access during runtime:
>      1. handle_device_interrupt()
>      2. map_irq_to_domain()
>      3. map_range_to_domain()
>      4. unflatten_dt_node()
>      5. unflatten_device_tree()

I would prefer if the __init is removed as it get used.

> 
> Remove .init from domain_build.o and move map_range_data declaration to
> domain_build.h.
Skimming through the rest of the series, I think the function you are 
trying to use will be misplaced because you are not looking to build a 
domain. Instead, you are looking to add more devices.

So I think it would be better to move the functions outside of 
domain_build.c. One possibility would be device.c.

Cheers,

> 
> These changes are done to support the dynamic programming of a nodes where an
> overlay node will be added to fdt and unflattened node will be added to dt_host.
> Furthermore, irq and mmio mapping will be done for the added node.
> 
> Signed-off-by: Vikram Garhwal <fnu.vikram@xilinx.com>
> ---
>   xen/arch/arm/Makefile              |  2 +-
>   xen/arch/arm/domain_build.c        | 15 ++++-----------
>   xen/common/device_tree.c           | 18 +++++++++---------
>   xen/include/asm-arm/domain_build.h | 10 ++++++++++
>   xen/include/xen/device_tree.h      |  5 +++++
>   5 files changed, 29 insertions(+), 21 deletions(-)
> 
> diff --git a/xen/arch/arm/Makefile b/xen/arch/arm/Makefile
> index 3d3b97b..bef4517 100644
> --- a/xen/arch/arm/Makefile
> +++ b/xen/arch/arm/Makefile
> @@ -15,7 +15,7 @@ obj-y += decode.o
>   obj-y += device.o
>   obj-$(CONFIG_IOREQ_SERVER) += dm.o
>   obj-y += domain.o
> -obj-y += domain_build.init.o
> +obj-y += domain_build.o
>   obj-y += domctl.o
>   obj-$(CONFIG_EARLY_PRINTK) += early_printk.o
>   obj-y += gic.o
> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
> index 206038d..3a457d3 100644
> --- a/xen/arch/arm/domain_build.c
> +++ b/xen/arch/arm/domain_build.c
> @@ -47,12 +47,6 @@ static int __init parse_dom0_mem(const char *s)
>   }
>   custom_param("dom0_mem", parse_dom0_mem);
>   
> -struct map_range_data
> -{
> -    struct domain *d;
> -    p2m_type_t p2mt;
> -};
> -
>   /* Override macros from asm/page.h to make them work with mfn_t */
>   #undef virt_to_mfn
>   #define virt_to_mfn(va) _mfn(__virt_to_mfn(va))
> @@ -1144,7 +1138,7 @@ int __init make_chosen_node(const struct kernel_info *kinfo)
>       return res;
>   }
>   
> -int __init map_irq_to_domain(struct domain *d, unsigned int irq,
> +int map_irq_to_domain(struct domain *d, unsigned int irq,
>                                bool need_mapping, const char *devname)
>   {
>       int res;
> @@ -1210,7 +1204,7 @@ static int __init map_dt_irq_to_domain(const struct dt_device_node *dev,
>       return 0;
>   }
>   
> -static int __init map_range_to_domain(const struct dt_device_node *dev,
> +int map_range_to_domain(const struct dt_device_node *dev,
>                                         u64 addr, u64 len,
>                                         void *data)
>   {
> @@ -1300,9 +1294,8 @@ static int __init map_device_children(struct domain *d,
>    *   < 0 error
>    *   0   success
>    */
> -static int __init handle_device_interrupts(struct domain *d,
> -                                           struct dt_device_node *dev,
> -                                           bool need_mapping)
> +int handle_device_interrupts(struct domain *d, struct dt_device_node *dev,
> +                             bool need_mapping)
>   {
>       unsigned int i, nirq;
>       int res;
> diff --git a/xen/common/device_tree.c b/xen/common/device_tree.c
> index 03d25a8..cda21be 100644
> --- a/xen/common/device_tree.c
> +++ b/xen/common/device_tree.c
> @@ -1750,12 +1750,12 @@ int dt_count_phandle_with_args(const struct dt_device_node *np,
>    * @allnextpp: pointer to ->allnext from last allocated device_node
>    * @fpsize: Size of the node path up at the current depth.
>    */
> -static unsigned long __init unflatten_dt_node(const void *fdt,
> -                                              unsigned long mem,
> -                                              unsigned long *p,
> -                                              struct dt_device_node *dad,
> -                                              struct dt_device_node ***allnextpp,
> -                                              unsigned long fpsize)
> +static unsigned long unflatten_dt_node(const void *fdt,
> +                                unsigned long mem,
> +                                unsigned long *p,
> +                                struct dt_device_node *dad,
> +                                struct dt_device_node ***allnextpp,
> +                                unsigned long fpsize)
>   {
>       struct dt_device_node *np;
>       struct dt_property *pp, **prev_pp = NULL;
> @@ -1986,7 +1986,7 @@ static unsigned long __init unflatten_dt_node(const void *fdt,
>   }
>   
>   /**
> - * __unflatten_device_tree - create tree of device_nodes from flat blob
> + * unflatten_device_tree - create tree of device_nodes from flat blob
>    *
>    * unflattens a device-tree, creating the
>    * tree of struct device_node. It also fills the "name" and "type"
> @@ -1995,7 +1995,7 @@ static unsigned long __init unflatten_dt_node(const void *fdt,
>    * @fdt: The fdt to expand
>    * @mynodes: The device_node tree created by the call
>    */
> -static void __init __unflatten_device_tree(const void *fdt,
> +void unflatten_device_tree(const void *fdt,
>                                              struct dt_device_node **mynodes)
>   {
>       unsigned long start, mem, size;
> @@ -2118,7 +2118,7 @@ dt_find_interrupt_controller(const struct dt_device_match *matches)
>   
>   void __init dt_unflatten_host_device_tree(void)
>   {
> -    __unflatten_device_tree(device_tree_flattened, &dt_host);
> +    unflatten_device_tree(device_tree_flattened, &dt_host);
>       dt_alias_scan();
>   }
>   
> diff --git a/xen/include/asm-arm/domain_build.h b/xen/include/asm-arm/domain_build.h
> index 34ceddc..17449b1 100644
> --- a/xen/include/asm-arm/domain_build.h
> +++ b/xen/include/asm-arm/domain_build.h
> @@ -4,10 +4,20 @@
>   #include <xen/sched.h>
>   #include <asm/kernel.h>
>   
> +struct map_range_data
> +{
> +    struct domain *d;
> +    p2m_type_t p2mt;
> +};
> +
>   int map_irq_to_domain(struct domain *d, unsigned int irq,
>                         bool need_mapping, const char *devname);
>   int make_chosen_node(const struct kernel_info *kinfo);
>   void evtchn_allocate(struct domain *d);
> +int handle_device_interrupts(struct domain *d, struct dt_device_node *dev,
> +                             bool need_mapping);
> +int map_range_to_domain(const struct dt_device_node *dev, u64 addr, u64 len,
> +                        void *data);
>   
>   #ifndef CONFIG_ACPI
>   static inline int prepare_acpi(struct domain *d, struct kernel_info *kinfo)
> diff --git a/xen/include/xen/device_tree.h b/xen/include/xen/device_tree.h
> index b02696b..a4e98a7 100644
> --- a/xen/include/xen/device_tree.h
> +++ b/xen/include/xen/device_tree.h
> @@ -177,6 +177,11 @@ int device_tree_for_each_node(const void *fdt, int node,
>    */
>   void dt_unflatten_host_device_tree(void);
>   
> +/*
> + * unflatten any device tree.
> + */
> +void unflatten_device_tree(const void *fdt, struct dt_device_node **mynodes);
> +
>   /**
>    * IRQ translation callback
>    * TODO: For the moment we assume that we only have ONE
> 

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Oct 20 18:00:34 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Oct 2021 18:00:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.214049.372466 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdFtA-0002Ru-F3; Wed, 20 Oct 2021 18:00:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 214049.372466; Wed, 20 Oct 2021 18:00:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdFtA-0002Rn-BS; Wed, 20 Oct 2021 18:00:32 +0000
Received: by outflank-mailman (input) for mailman id 214049;
 Wed, 20 Oct 2021 18:00:30 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mdFt8-0002Rh-Od
 for xen-devel@lists.xenproject.org; Wed, 20 Oct 2021 18:00:30 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mdFt8-0002tZ-Ld; Wed, 20 Oct 2021 18:00:30 +0000
Received: from [54.239.6.185] (helo=[192.168.28.129])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mdFt8-0007hx-Fy; Wed, 20 Oct 2021 18:00:30 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=nk6p3GphD9fOzRbADdcK32HQ5KULYFp39jpVqY55l3s=; b=j0+cU2eRogXjos4Gz3+jgt918o
	xF/wEZuC2wCaJ+P1YGcN+MPmLKkttxr2BvQQLd8NODq90bS/YbrFVEGZvGnv7I/+3bdzZxTZFe0/n
	GRSmhQ/QKKjvz/6sKhU9jho+mcpVkJJNgV7UAwKDJUZCkPHwlpKTTJKr3WzYKsgk+iTk=;
Message-ID: <23e8372d-d921-e695-f3c3-43e0b2e198c1@xen.org>
Date: Wed, 20 Oct 2021 19:00:29 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.2.0
Subject: Re: [XEN][RFC PATCH 02/13] libfdt: Keep fdt functions after init.
To: Vikram Garhwal <fnu.vikram@xilinx.com>, xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org
References: <1630562763-390068-1-git-send-email-fnu.vikram@xilinx.com>
 <1630562763-390068-3-git-send-email-fnu.vikram@xilinx.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <1630562763-390068-3-git-send-email-fnu.vikram@xilinx.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Vikram,

On 02/09/2021 07:05, Vikram Garhwal wrote:
> Keep libfdt library functionalities after boot of hw_domain. This is done to
> access fdt library function which are required for adding device tree overlay
> nodes for dynamic programming of nodes.

AFAICT, the new feature will be mostly useful on HW with FPGA. I expect 
that some users may not want this feature (for instance because the HW 
doesn't have FPGA), so I think it would be best to introduce a new 
Kconfig to enable the new feature.

This could then be used to decide whether libfdt should be part of .init 
or not.

Cheers,

> 
> Signed-off-by: Vikram Garhwal <fnu.vikram@xilinx.com>
> ---
>   xen/common/libfdt/Makefile | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/xen/common/libfdt/Makefile b/xen/common/libfdt/Makefile
> index 6bd207c..8002f8c 100644
> --- a/xen/common/libfdt/Makefile
> +++ b/xen/common/libfdt/Makefile
> @@ -1,7 +1,6 @@
>   include Makefile.libfdt
>   
>   SECTIONS := text data $(SPECIAL_DATA_SECTIONS)
> -OBJCOPYFLAGS := $(foreach s,$(SECTIONS),--rename-section .$(s)=.init.$(s))
>   
>   obj-y += libfdt.o
>   nocov-y += libfdt.o
> 

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Oct 20 18:05:33 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Oct 2021 18:05:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.214057.372477 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdFxy-00037L-2E; Wed, 20 Oct 2021 18:05:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 214057.372477; Wed, 20 Oct 2021 18:05:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdFxx-00037E-US; Wed, 20 Oct 2021 18:05:29 +0000
Received: by outflank-mailman (input) for mailman id 214057;
 Wed, 20 Oct 2021 18:05:28 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mdFxw-000378-Hh
 for xen-devel@lists.xenproject.org; Wed, 20 Oct 2021 18:05:28 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mdFxw-0002yo-Cr; Wed, 20 Oct 2021 18:05:28 +0000
Received: from [54.239.6.185] (helo=[192.168.28.129])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mdFxw-0007yx-5f; Wed, 20 Oct 2021 18:05:28 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=vj2GTLUwQEmvicFc+ddMOBLrRf6V+4nI0eq/YzUztZg=; b=ojh4TtuAbnz0GyYWi/yNDC+/J/
	2WyqEt92Nt/Jz6eN7Z/UgzsglwkudhFNK49j1oSVhOsG2sOQucRLGw/L+Ho507cTRFhNqtpJHqHIa
	Hyr5+kqp4Wg3fEtBVGmQFsIqdMJJFmLQixIrznACiFJA/4t71qH/RLeP/p93WT4QJp+Q=;
Message-ID: <e4661f83-a1ac-3553-b281-c4123be7a04f@xen.org>
Date: Wed, 20 Oct 2021 19:05:26 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.2.0
Subject: Re: [XEN][RFC PATCH 03/13] libfdt: import fdt_overlay from Linux
To: Vikram Garhwal <fnu.vikram@xilinx.com>, xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org
References: <1630562763-390068-1-git-send-email-fnu.vikram@xilinx.com>
 <1630562763-390068-4-git-send-email-fnu.vikram@xilinx.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <1630562763-390068-4-git-send-email-fnu.vikram@xilinx.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Vikram,

On 02/09/2021 07:05, Vikram Garhwal wrote:
> Xen is missing fdt overlay functionalities. FDT overlay is required for changing
> the device tree nodes during run-time.
> 
> fdt_overlay.c file is copied from Linux tree's following patch:
> commit: 6e9c9686d826564f44c93cdd6f111b1c0a9dc224
> scripts/dtc: Update to upstream version v1.6.0-31-gcbca977ea121

This patch and the next one add quite a bit of code in libfdt. The 
directory xen/common/libfdt is pretty much a snapshot of v1.4.0 (we 
tweaked the Makefile and import 2 bug fixes).

So I would prefer if we re-sync our directory with the one in 
https://github.com/dgibson/dtc.git. v1.6.1 seems a good candidate.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Oct 20 18:09:09 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Oct 2021 18:09:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.214067.372488 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdG1T-0003o5-Ln; Wed, 20 Oct 2021 18:09:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 214067.372488; Wed, 20 Oct 2021 18:09:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdG1T-0003ny-IX; Wed, 20 Oct 2021 18:09:07 +0000
Received: by outflank-mailman (input) for mailman id 214067;
 Wed, 20 Oct 2021 18:09:06 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mdG1S-0003ns-BB
 for xen-devel@lists.xenproject.org; Wed, 20 Oct 2021 18:09:06 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mdG1S-00033s-8m; Wed, 20 Oct 2021 18:09:06 +0000
Received: from [54.239.6.185] (helo=[192.168.28.129])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mdG1S-0008B1-2n; Wed, 20 Oct 2021 18:09:06 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=N/XCGEC3DOiRnjbDfQMNBYEJ5aHPoDQ1o02xoy+36gY=; b=eZQrywKiXK3eqDwyw6z34jc5VL
	38tyI6inIdzxyBWf8k5fILqBTrPETyRM5yOI+iphbcofWKV2xxMXLnPhyqVq8iT3WL+/VppAgbfGY
	engyOGwdDuQiWSUBPDqydwRljMwtge0O3raIka1O/sN3M++t8bfNzIhXnW4ZfI3C5X5s=;
Message-ID: <997d95fa-f259-e904-88a2-97910cef101e@xen.org>
Date: Wed, 20 Oct 2021 19:09:04 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.2.0
Subject: Re: [XEN][RFC PATCH 05/13] libfdt: Change overlay_get_target() type
To: Vikram Garhwal <fnu.vikram@xilinx.com>, xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org
References: <1630562763-390068-1-git-send-email-fnu.vikram@xilinx.com>
 <1630562763-390068-6-git-send-email-fnu.vikram@xilinx.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <1630562763-390068-6-git-send-email-fnu.vikram@xilinx.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Vikram

On 02/09/2021 07:05, Vikram Garhwal wrote:
> Remove static function type from overlay_get_target().

Please explain why this is necessary. But if we really need then...

> 
> Signed-off-by: Vikram Garhwal <fnu.vikram@xilinx.com>
> ---
>   xen/common/libfdt/fdt_overlay.c | 2 +-
>   xen/include/xen/libfdt/libfdt.h | 2 ++
>   2 files changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/xen/common/libfdt/fdt_overlay.c b/xen/common/libfdt/fdt_overlay.c
> index 15a8cdb..1ffb669 100644
> --- a/xen/common/libfdt/fdt_overlay.c
> +++ b/xen/common/libfdt/fdt_overlay.c
> @@ -56,7 +56,7 @@ static uint32_t overlay_get_target_phandle(const void *fdto, int fragment)
>    *      the targeted node offset in the base device tree
>    *      Negative error code on error
>    */
> -static int overlay_get_target(const void *fdt, const void *fdto,
> +int overlay_get_target(const void *fdt, const void *fdto,
>   			      int fragment, char const **pathp)

... the function should be prefixed to fdt_*.

I would also like to avoid diverging from what the original source. So 
can this please be sent to the libfdt community first?

>   {
>   	uint32_t phandle;
> diff --git a/xen/include/xen/libfdt/libfdt.h b/xen/include/xen/libfdt/libfdt.h
> index b6c8b67..e1cc6f2 100644
> --- a/xen/include/xen/libfdt/libfdt.h
> +++ b/xen/include/xen/libfdt/libfdt.h
> @@ -1737,4 +1737,6 @@ int fdt_overlay_apply(void *fdt, void *fdto);
>   
>   const char *fdt_strerror(int errval);
>   
> +int overlay_get_target(const void *fdt, const void *fdto, int fragment,
> +                       char const **pathp);
>   #endif /* _LIBFDT_H */
> 

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Oct 20 19:57:25 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Oct 2021 19:57:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.214075.372498 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdHhw-0005Kx-MO; Wed, 20 Oct 2021 19:57:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 214075.372498; Wed, 20 Oct 2021 19:57:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdHhw-0005Kq-JK; Wed, 20 Oct 2021 19:57:04 +0000
Received: by outflank-mailman (input) for mailman id 214075;
 Wed, 20 Oct 2021 19:57:03 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=waF5=PI=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1mdHhv-0005Kk-Ie
 for xen-devel@lists.xenproject.org; Wed, 20 Oct 2021 19:57:03 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id e4343062-31df-11ec-8357-12813bfff9fa;
 Wed, 20 Oct 2021 19:57:02 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id 0FC876128E;
 Wed, 20 Oct 2021 19:57:01 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e4343062-31df-11ec-8357-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1634759821;
	bh=omdLrRF7iYsEpO+9M0zp8SgWzAseQGfKrnR8CF960DQ=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=H5IgrrCbC1RxcC6SlcPmPjIkSQe7Qf857wXqoUlOVliyewbNvrLoZgCI5BUZlXBCl
	 iNF6j3UU43bAI6Q0W00xhHlIaV/uuMa8rsuE5l28W+4rISLPm5l+IL8HhKpawCXpYp
	 aE7HN5PHgTqs+jLn337e25UEPhbfjAAZc1yCljssKBJMlChSmtMuDCDHmP4Hd+lM3t
	 WSjYI+ZhurZP5HJ4jSR2zEUgNAXQsoGfpGVFAvSduBYokocHLjpmD2HkNtCGrExRJC
	 NNSZRotZQBpUBwHiP/OHyG18n9SFtOCUUeJZqZe3RuNIPF9XW5mXTKSR6lmc/7iw5I
	 l2axrcS1OFueg==
Date: Wed, 20 Oct 2021 12:56:52 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Ian Jackson <iwj@xenproject.org>
cc: Bertrand Marquis <Bertrand.Marquis@arm.com>, 
    Jan Beulich <jbeulich@suse.com>, 
    "Oleksandr_Andrushchenko@epam.com" <Oleksandr_Andrushchenko@epam.com>, 
    Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, 
    Andrew Cooper <andrew.cooper3@citrix.com>, 
    =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= <roger.pau@citrix.com>, 
    Wei Liu <wl@xen.org>, Paul Durrant <paul@xen.org>, 
    "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v2 1/1] xen/pci: Install vpci handlers on x86 and fix
 exit path
In-Reply-To: <24943.62617.9207.158774@mariner.uk.xensource.com>
Message-ID: <alpine.DEB.2.21.2110201005460.2311@sstabellini-ThinkPad-T480s>
References: <cover.1634659471.git.bertrand.marquis@arm.com> <d788dcce9e344a39f6761633f0e96774ab42c2aa.1634659471.git.bertrand.marquis@arm.com> <9f77b70f-93b8-2b54-3aa1-5de677d858cc@suse.com> <0FC6BD8A-1805-4C10-A95C-EA199D870F06@arm.com>
 <24943.62617.9207.158774@mariner.uk.xensource.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Wed, 20 Oct 2021, Ian Jackson wrote:
> Bertrand Marquis writes ("Re: [PATCH v2 1/1] xen/pci: Install vpci handlers on x86 and fix exit path"):
> > > On 20 Oct 2021, at 08:16, Jan Beulich <jbeulich@suse.com> wrote:
> > > I'm inclined to suggest s/exit/error/ in the title though (and maybe
> > > also s/path/paths/), which would be easy enough to do while committing.
> > 
> > @Ian: Please tell me if this is ok to be fixed during commit.
> 
> It's academic now, since you need a respin anyway, but I would in any
> case have preferred a new version.  I find that a much better
> workflow.  Expecting to make changes on commit pushes work onto
> committers from submitters, which is less scaleable.
> 
> And it also ends up with committer making changes without any further
> human review of any kind.  The committer must do so during an activity
> which is otherwise often shallow and administrative.  This is not the
> best way to get good results.
> 
> I believe I have made these points before, but perhaps not so clearly
> and explicitly.  They are IMO very general.  (FTAOD I'm not saying
> that making changes on commit is never appropriate, but it ought to be
> exceptional.)

Everything you wrote makes sense and your position is perfectly valid.
At the same time let me write a different perspective on the issue. All
the committers have slightly different workflows so it is natural that
things that are better for one person might not be best for another.

When I commit a patch series often I don't simply take the patches (with
all the necessary acks) and commit them. I typically do a number of
other things:
1) check that the series has all the requested changes compared to the
   previous version
2) check that nothing else was changed unexpectedly
3) run a local build test in a variety of configurations
4) run a full gitlab-ci set of tests with the patches applied

All of the above take time. So if only a small change is required, it is
much faster for me to make the change myself on commit rather than
having to go through steps 1-4 one more time again. Of course this is
only good for small changes with no impact, e.g. code style or in-code
comments, I wouldn't want to do this for anything meaningful.


From xen-devel-bounces@lists.xenproject.org Wed Oct 20 20:02:18 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Oct 2021 20:02:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.214083.372509 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdHmx-0006ok-AB; Wed, 20 Oct 2021 20:02:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 214083.372509; Wed, 20 Oct 2021 20:02:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdHmx-0006oc-70; Wed, 20 Oct 2021 20:02:15 +0000
Received: by outflank-mailman (input) for mailman id 214083;
 Wed, 20 Oct 2021 20:02:13 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=QpeW=PI=citrix.com=Andrew.Cooper3@srs-us1.protection.inumbo.net>)
 id 1mdHmv-0006oW-K5
 for xen-devel@lists.xenproject.org; Wed, 20 Oct 2021 20:02:13 +0000
Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 9cd52f9a-31e0-11ec-8357-12813bfff9fa;
 Wed, 20 Oct 2021 20:02:12 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9cd52f9a-31e0-11ec-8357-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1634760132;
  h=to:cc:references:from:subject:message-id:date:
   in-reply-to:content-transfer-encoding:mime-version;
  bh=gwVswPp89v0uyd6Eh27m4OZBMYYEtoB19YcwSFhVui0=;
  b=HfZ712w+McHgtpMjDm9Fm5xYXeXC68QCT0yLloI78+h58wV1DgHVjc6C
   wISQlT2z/NFRI+VG7GBMcM7hUUxUlJrTdfQi4j3vmWM1FEcp3tVG12p2s
   fawgJVk5HLuhcTSUpnkXEd9A5MfheyeTZac3hVfaWbtigz4N5mTb3bxz3
   Y=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: Blg05HS9F4XGiJQNbbREtmISYgCn4OI91WC1puiHP2+SHhe3rOYo2rfCCoU0sZnGKNQuAcjQBN
 lBZVb5Hv8zU3NHfknCZpSQvFbnXSto0C2+ZnzYY8JYmJjIGTt/HKpOovsDEbslMBexgReVE64Y
 3hoIuHccmbFv5b/eHEFtxNxJZ+xdj7J4mze5p/1ia6cZ9f609TklY6uP9QJcnz8/CvYm0yVo4O
 KnK66qPl418JMlO5CTXnpeWIWQ74E6z3plw9kH4PUM+PxTURrPzdIq1SsJLLdKz9QP8KO2AxBp
 4uqDCPLo9d9Q0MT8nGVfzQiZ
X-SBRS: 5.1
X-MesageID: 55235160
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:PaU4iahjhVs4pxrY7Ejl3ydlX161lBcKZh0ujC45NGQN5FlHY01je
 htvXT/VaPqDNDamKYgnaYTlpk8OscSAndNqHQc9rX81En8b9cadCdqndUqhZCn6wu8v7a5EA
 2fyTvGacajYm1eF/k/F3oAMKRCQ7InQLlbGILes1htZGEk0F0/NtTo5w7Rg29Yy2YDja++wk
 YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq
 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx
 /1RrZe5GAt5N5bhs9ZAbAAHSX1UE6RZreqvzXiX6aR/zmXDenrohf5vEFs3LcsT/eMf7WNmr
 KJCbmpXN1ba2rzwkOnTpupE36zPKOHCOo8Ft24m5jbeFfs8GrjIQrnQ5M8e1zA17ixLNauDP
 ZFEMGQ3BPjGS0JBHw0sFb0kptryrFmvXw1oq32KuZNitgA/yyQuieOwYbI5YOeiVchT20qVu
 G/C12D4GQ0BcsySzyKf9XChjfOJmjn0MKoQHrCl8v9hgHWI23ceThYRUDOTufCkjmauVtQZL
 FYbkgIxqYAi+UrtScPyNyBUu1bd4ERaAYAJVbRntkfdkcI4/jp1GEAYVjVIOdB2vfQbbg536
 UbWxY/DKzVw5ej9pW2myp+Yqja7OC4wJGAEZDMZQQZt3+QPsL3fnTqUEY49SP/dYsndXGiqm
 WjT/XdWa6A71JZTj82GEUb7byVAT3QjZjU+4RnLRSqb5wd9aZ/Ni2eAuAWDs6gowGp0SDC8U
 Jk4dyq2sL9m4XKlznXlrAAx8FeBvart3Nr02gYHInXZ327xk0NPhKgJiN2EGG9nM9wfZRjia
 1LJtAVa6fd7ZSXxMfEpMtrrV5xzlMAM8OgJsNiOMrKihbAqLGe6ENxGPxbMjwgBbmB9+U3AB
 XtrWZn1VitLYUiW5DG3W/0cwdcWKtMWngvuqWTA503/i9K2PSfNIZ9caQfmRr1pvcus/VSOm
 /4CZpTi9vmqeLCnCsUh2dVIdg5iwLlSLc2elvG7gcbZf1E8Rz14WqSPqV7jEqQ895loei7z1
 ijVcmdTyUblhG2BLgOPa3t5b6joU4o5pnU+VRHA9370s5T6SYrwvqoZabUterwrqL5qwfJuF
 qFXcMScGPVfDD/A/m1FP5X6qYVjcjWthB6PYHX5MGRuIcY4Slyb4MLgcyvu6DIKUni9u/whr
 uDyzQjcW5cCGVhvVZ6EdPK1wlqtlnEBg+YuDVDQK9xedRy0oohnIiD8lNEtJMQIJUmRzzeWz
 V/OUxwZufPMs8k+99yQ3fKIqIKgEu1fGEtGHjaEsebqZHeCpmf6mN1OSueFezzZRVjYwqT6a
 LUH1ez4Pd0GgE1O79h2HYF0wP9s/NDovbJbkFhpRS2Zc1SxB7p8CXCaxs0T5LZVz7pUtAbqC
 EKC/t5WZeeANM//SQNDIQMkaqKI1O0OmymU5vMweR2o6Chy9buBcENTIxjT13ANcOoraNsok
 bU7pcobyw2jkR57YN+Jgxdd+3mIMnFdAb4ssYsXAdOzhwcmor2YjUcw1sMiDEmzVuhx
IronPort-HdrOrdr: A9a23:z1Ht1qhegw3bCOF2aT2xoCmkCHBQX0h13DAbv31ZSRFFG/FwyP
 rBoB1L73DJYWgqNE3I+erhBEGBKUmskaKdkrNhQ4tKOzOWx1dATbsSkbcKpgeAJ8SQzJ8n6U
 4NSdkZNDS0NykGsS+Y2njKLz9D+qj+zEnAv463pB0BPGIaCdAT0+46MHf9LqQffng3OXNTLu
 vk2iMonUvERZ1aVLXAOpFTNNKz1uEj2aiWLSIuNloC0k2jnDmo4Ln1H1yx2QofaSpGxfMH/X
 LemwL0y62/u7XjoyWsmVP73tBzop/M29FDDMuDhow8LSjtsB+hYMBEV6eZtD44jemz4BIBkc
 XKoT0nI8NvgkmhMV2dkF/I4U3NwTwu43jtxRuxhmbim9XwQHYAB89IletiA1DkwntlmOs5/L
 NA3mqfuZYSJwjHhj7B69/BUAwvvlaooFI5+NRjzEB3YM87Uvt8vIYf9ERaHNMrByTh8r0qF+
 FoEYX1+OtWS1WHdHrU11MfgOBEZk5DWytuf3Jy/vB8i1Nt7TdEJgojtY0id047hdAAo8Iu3Z
 WDDkxq/Is+BvP+I5gNXdvpevHHflAldyi8eV56EW6XYZ3vBEi93KIfwI9Frt1CK6Z4gafbpv
 z6ISVlXCgJChrTNfE=
X-IronPort-AV: E=Sophos;i="5.87,167,1631592000"; 
   d="scan'208";a="55235160"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=eJQPsfhKanwB4ZCHzfqAHOq8Ct8h7w43IY3rU4qeOsFxVitD9/ew61DV2S9wGC+ncdrcO0Tew8u6boLj0JCIsBrIUUQRia0XxF21d5ddoYI9RdNf6RP0+s9MlDPSGRQWP5Cx8Z9I4NlTBtAm/Q8B1/g8rnoc4V4X2zEIsVcDvF3PRKSAK2Hq06gwTX2WIpeZsKJwT4npau4TUQVel4NN904j2USxa8+nW6cViRAL7y1TMCEHvcKfkr7QtAgWN2ybXOfs+2qgTlILpgeMEYvgwoAvNlOdeDc4NRMGd6dqpu3sG/nly/fTPm3/zfflCnB1YD3hAz+YgmiXIu4IJk4+qA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=nTLVC7cS/lefeTZA/B6tP3IwJisz4pj7fwvDBwl2HGc=;
 b=GxGajN6bVtYljpv3PE+la7c+0DIEHTpS2+PQHfnD5/5mK2RgC5ot6qt1eE7CsTPaaKNHlDh/OjnbmdULg0+ErORwj8+INEgztBlm/KXpfskStNKqnUvhF0NwI6B+tJCH0YdTqqhkHpaIguOEfLTlApPmYHHelgAI9tO81QdgfX5kIpavJMWtLs54O19xh81v8nPVncpIbUhKxOpP/AXbV9KrPja8O7Guf3FPvs++lJxWlyyE2CrREF4WFFrpSWwzZfQLOPovHQHJp+XcX9w5hyll2yoJhurVb3FCBzgumQweeVC81RyQv9ay7JyovqROOGmDSVc8xL6ForjG9UcCAw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=nTLVC7cS/lefeTZA/B6tP3IwJisz4pj7fwvDBwl2HGc=;
 b=Cq7wRIaLkkFQQm0ffre8eFeeGUbnjYWNUBYUmPTrQpTA4+97CZdeyrM5bnqtfF4kRqfYvPqqLXQR2ZgMDp9NhaB3KyaypoKD4sLiCT0Rm9C2zJtlmd7fttcwmnf01sSZWM+RgDRNa9UOS4i2rBgX07X8wojOE3ZOppQzBkyVbAc=
To: Jan Beulich <jbeulich@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Wei Liu <wl@xen.org>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
	<roger.pau@citrix.com>, Paul Durrant <paul@xen.org>
References: <684e4a04-3ef3-46be-3302-149d5ce30177@suse.com>
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH] x86/IOMMU: mark IOMMU / intremap not in use when ACPI
 tables are missing
Message-ID: <e710cb3f-9343-f9d6-123e-287687e7bac3@citrix.com>
Date: Wed, 20 Oct 2021 21:01:51 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <684e4a04-3ef3-46be-3302-149d5ce30177@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Content-Language: en-GB
X-ClientProxiedBy: LO4P265CA0014.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:2ad::8) To BYAPR03MB3623.namprd03.prod.outlook.com
 (2603:10b6:a02:aa::12)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 7a0da519-1495-4b01-2aec-08d9940478fd
X-MS-TrafficTypeDiagnostic: SJ0PR03MB5503:
X-Microsoft-Antispam-PRVS: <SJ0PR03MB55039E720415D20E9AF97C92BABE9@SJ0PR03MB5503.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: BgNaw2ZrcZv5DNjsB64zJbuHNb4mc/6fJVDUzP2J/Md8zsvr1YoeU64yvw9J/ssPB9a/oOWUfrNWP+fHU4Y9yrEBX2es0HAuNGfVnIOgAJH6s7YijzhGWJTVHW/DcqI9dSC81KIsMJZ1TlgpaE0948kNyCkBkeICUk8b14LHsaoZElZT1l7ObgXPwJoorklePJh2Vz15c8d/PpykGkSzIdYsWbGxD9+FSdCk4bi2iSN7okmZqxnVaZ2fYtDHk5q1gj8q4GExrgW7wz+3g+Z2fM3+qay6F5ZKJ3xIjbvNEX2cfqcmqFbycR6+wTE23jOZqYZpppXQM9b3bZo4x/tlgvcC+UiDE4rhka/5sWqHDPScxbcD27ibKAMhXMiRhrMZHYYMncr6hNcspYVryl6HlxdFChmlu95oaASXioOjGuKrwVFs+7is5leLD/agi5o/mqQWNg7Mf+Vc5LISLXvTbPuksiyRe7h+5Pcu6gGfkeiF6wBKfaoN7Q/E2ApUv2bDgOldoDA4bV7+zeH/tOp/o93kgBnIwazBIPP5UW+AEhfdvRVqRxeEUg99VOmSZ6652wPD+xrG0ynX5/RsD4wprLQ6WU8IWvxkOUCzi0oAvPbyLgHYUwqPDQ9+uTSGUcW6W6Jd+FxrjwmQ0EeM9oBR/x5QXqVYR3oad4pcO6Vo45UaX6/GjW5Z5Ehudt61lSRFhS9hOkWYOz7JsOn6lvzblBBpBpjYvtChCrAAhxv6+cGj0nItePaoBE/qC/88Gomf
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(316002)(6666004)(2906002)(31686004)(8936002)(83380400001)(110136005)(2616005)(66946007)(66476007)(54906003)(66556008)(956004)(508600001)(16576012)(5660300002)(86362001)(53546011)(82960400001)(8676002)(26005)(6486002)(38100700002)(31696002)(4326008)(186003)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dTdsT3ZXd2FtK24ya0t0YmtQSHhoSlNSdGdjbEJWU1M0YndNeEJtekc2WXgy?=
 =?utf-8?B?NElCRUxHVFFSTDdlMXo1Ny82bFhhelZSaXFYTmVmQitLT1d2MEdRbzFnekU5?=
 =?utf-8?B?aG16aFpsOGJ6N00rdk1nTk53SnMxUkxNcVphZlQvZHRyeDNHVGZEUkw1WjdE?=
 =?utf-8?B?SjhTaGc5WWRwYWpRTit3NHNyMVZ2TURNMUJLRXFrRHp6T0JZVFFBZnc1TmFV?=
 =?utf-8?B?L2FDbHYxNUJFb2twVnFwNkV5YmhoeEtGUmZGVldncy9KZi9tcHovdVJENENv?=
 =?utf-8?B?SDhVdmh2M3BabUlKU1RUSUdvT2dzTkRXb1ZubnBhcEcySmtES29MbFdaSlFI?=
 =?utf-8?B?d1dFQVVFVTdwZE4yNEdla2toL0xKS01VTmNPVmhGOWlOMFNJbHFPSTYxOHd6?=
 =?utf-8?B?Ky9oMERjdWV6UzZtNXdJT0lNK1lkR1F0QWprL00rbllicXBtZi9sZE1rMDYy?=
 =?utf-8?B?ZUc5aThrVTRZMWdvQmVOQkJsKzlLMHVQT0lSTzBnKzJpdUwySkNaNnpvbnY0?=
 =?utf-8?B?SmdlQ3prMWZpY3B2dTU2N1JYbDA0ckF0VEUwZHNCbHlrQ0pGRnJveXhIaXFy?=
 =?utf-8?B?YnArWEd4WFB3WnJIdUV2RHI1ZVpQSDBKcUVHZ2pnSGRzOXkxeGtiYnVGVFRL?=
 =?utf-8?B?OS9tckx0SGN5RGlVcDltUHhtV05sTTIvd2NkVzFCTHVUSjYwWUQ1Si9JVlIr?=
 =?utf-8?B?ditCMEo4OXc5N0VSbHNlck9kclpVUHN1cURxK2p1Qk9nVlp1MFpGMzEwTEtI?=
 =?utf-8?B?NzNpZHA5MytNVTFYZGprQ3V1ejdFemRZaHdnV0J5aHM1OHZXcTM5blVYSVVq?=
 =?utf-8?B?aEtiOGFybTlzNGtrUE1mSGRveTVXODVHTEdmckVJSVVVcUtlMVRoM0wyTHQz?=
 =?utf-8?B?c1cxME85M29ORnNWcXREckg2MlgxMU4rUmh1QXh6VFJibUpiSzAvSEtrU1Yw?=
 =?utf-8?B?MkM1K2VYS1g2cCtISGhGUm9LU1FuM2VZbkZiQ3ErTElGUk53UTQ4SHFuaHRu?=
 =?utf-8?B?dDg2SncvWnlibGROQmR0UXQ5UjNPYTM0Q0JYMzJ3S201NzJNdVhjd0EvV2dk?=
 =?utf-8?B?d1ltMnpGbkRkOXQwWnBQNm5oRjI0ZHQxdjZHMTZmY3UxdlVUSkl3N3BndmxR?=
 =?utf-8?B?bWNKOUJPaE4zSzBSZWo1UGozVnVMMWNyZVVsRHFUTUwxSDE1ODh2VHVwWnJt?=
 =?utf-8?B?MXJSL0NGMVZ1WVNkeG5YcGdGNk0zQTRtaE9HT2xxOFAwYkNoQzNEZ01PVHRk?=
 =?utf-8?B?M1VVbWRJWE5ZenJudEpaTC96MDNLRTBpYVl2c0dZZ3paWU1oMGZodkRBVGNx?=
 =?utf-8?B?c0tDV01USHhwTE5JSGdaZWlJVDBWRXBDRGRBMFR2WUtlemhNUk1sR0FTN2Nx?=
 =?utf-8?B?emlQZllBcU12eW1YeW5rT1BVcjRLOWdyS28va245QkhyZ2UzQUp4STZjV2hI?=
 =?utf-8?B?WW9lVEZKWFRlcEw5cjNXRUpaeXE2TVZnWVFSUERwazRVMXAvb3R2RTZxQWFM?=
 =?utf-8?B?YnRMVGdFcUJhcnU0cWRwUmdTNHgySUhsa2UvS0JYUGVtTVVOZFRwYm5ycFUy?=
 =?utf-8?B?ZlJEbWJjWmlFVXBLSDRYMy91KzlvbGFiT2s3NEtHeHk0UVdxSnFCa3BHRUpN?=
 =?utf-8?B?TjRWWnRPTEE3VnI4WWJBaWMvOVpaWjNVRVNMdlBMc1Uwdk9xQld4UDVLY0Fm?=
 =?utf-8?B?UlczM1BPWU1pcVM1VDBOOUpvQm5TUUlMQ0xaYjcyZTVGYkxPekdZb3M1TWJq?=
 =?utf-8?Q?beaSRM5svLOFmNG1PYXPUUCtu2areyrwWDDCk07?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 7a0da519-1495-4b01-2aec-08d9940478fd
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2021 20:01:58.2292
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: andrew.cooper3@citrix.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5503
X-OriginatorOrg: citrix.com

On 20/10/2021 11:36, Jan Beulich wrote:
> x2apic_bsp_setup() gets called ahead of iommu_setup(), and since x2APIC
> mode (physical vs clustered) depends on iommu_intremap, that variable
> needs to be set to off as soon as we know we can't / won't enable the
> IOMMU, i.e. in particular when
> - parsing of the respective ACPI tables failed,
> - "iommu=3Doff" is in effect, but not "iommu=3Dno-intremap".
> Move the turning off of iommu_intremap from AMD specific code into
> acpi_iommu_init(), accompanying it by clearing of iommu_enable.
>
> Take the opportunity and also skip ACPI table parsing altogether when
> "iommu=3Doff" is in effect anyway.
>
> Reported-by: Andrew Cooper <andrew.cooper3@citrix.com>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> ---
> I've deliberately not added a Fixes: tag here, as I'm of the opinion
> that d8bd82327b0f ("AMD/IOMMU: obtain IVHD type to use earlier") only
> uncovered a pre-existing anomaly.

I agree it uncovered a pre-existing issue, but that doesn't mean a Fixes
tag should be omitted.=C2=A0 That change very concretely regressed booting =
on
some systems in their pre-existing configuration.

The commit message needs to spell out a link to d8bd82327b0f, but it's
fine to say "that commit broke it by violating an unexpected ordering
dependency, but isn't really the source of the bug".

> This particularly applies to the "iommu=3Doff" aspect.

There should be at least two Fixes tags, but I suspect trying to trace
the history of this mess is not a productive use of time.

>  (This now allows me to remove an item from my TODO
> list: I was meaning to figure out why one of my systems wouldn't come
> up properly with "iommu=3Doff", and I had never thought of combining this
> with "no-intremap".)
>
> Arguably "iommu=3Doff" should turn off subordinate features in common
> IOMMU code, but doing so in parse_iommu_param() would be wrong (as
> there might be multiple "iommu=3D" to parse). This could be placed in
> iommu_supports_x2apic(), but see the next item.

I don't think we make any claim or implication that passing the same
option twice works.=C2=A0 The problem here is the nested structure of
options, and the variable doing double duty.

>
> While the change here deals with apic_x2apic_probe() as called from
> x2apic_bsp_setup(), the check_x2apic_preenabled() path looks to be
> similarly affected. That call occurs before acpi_boot_init(), which is
> what calls acpi_iommu_init(). The ordering in setup.c is in part
> relatively fragile, which is why for the moment I'm still hesitant to
> move the generic_apic_probe() call down. Plus I don't have easy access
> to a suitable system to test this case. Thoughts?

I've written these thoughts before, but IOMMU handling it a catastrophic
mess.=C2=A0 It needs burning to the ground and redoing from scratch.

We currently have two ways of turning on the IOMMU, depending on what
firmware does, and plenty ways of crashing Xen with cmdline options
which should work, and the legacy xAPIC startup routine is after
interrupts have been enabled, leading to an attempt to rewrite
interrupts in place to remap them.=C2=A0 This in particular has lead to XSA=
s
due to trusting registers which can't be trusted, and the rewrite is
impossible to do safely.

The correct order is:
1) Parse DMAR/IVRS (but do not configure anything), MADT, current APIC
setting and cmdline arguments
2) Figure out whether we want to be in xAPIC or x2APIC mode, and whether
we need intremap.=C2=A0 Change the LAPIC setting
3) Configure the IOMMUs.=C2=A0 In particular, their interrupt needs to be
after step 2
4) Start up Xen's general IRQ infrastructure.

It's a fair chunk of work, but it will vastly simplify the boot logic
and let us delete the infinite flushing loops out of the IOMMU logic,
and we don't need any logic which has to second guess itself based on
what happened earlier on boot.

> --- a/xen/drivers/passthrough/x86/iommu.c
> +++ b/xen/drivers/passthrough/x86/iommu.c
> @@ -41,6 +41,23 @@ enum iommu_intremap __read_mostly iommu_
>  bool __read_mostly iommu_intpost;
>  #endif
> =20
> +void __init acpi_iommu_init(void)
> +{
> +    if ( iommu_enable )
> +    {
> +        int ret =3D acpi_dmar_init();
> +
> +        if ( ret =3D=3D -ENODEV )
> +            ret =3D acpi_ivrs_init();
> +
> +        if ( ret )
> +            iommu_enable =3D false;
> +    }
> +
> +    if ( !iommu_enable )
> +        iommu_intremap =3D iommu_intremap_off;
> +}

This does fix my issue, so preferably with the Fixes tag reinstated,

Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
Tested-by: Andrew Cooper <andrew.cooper3@citrix.com>

However, I don't think skipping parsing is a sensible move.=C2=A0 Intremap =
is
utterly mandatory if during boot, we discover that our APIC ID is >254,
and iommu=3Dno-intremap must be ignored in this case, or if the MADT says
we have CPUs beyond that limit and the user hasn't specified nr_cpus=3D1
or equivalent.

This applies to a future world with a sane boot order, but Xen needs to
know hardware_support_{dma,int}remapping (-> must parse the ACPI tables)
ahead of choosing whether to turn the facilities on or not.=C2=A0 Fixing th=
is
removes the double duty from variables.

~Andrew



From xen-devel-bounces@lists.xenproject.org Wed Oct 20 20:47:13 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 20 Oct 2021 20:47:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.214091.372521 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdIUM-0002Ra-Qd; Wed, 20 Oct 2021 20:47:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 214091.372521; Wed, 20 Oct 2021 20:47:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdIUM-0002RT-MN; Wed, 20 Oct 2021 20:47:06 +0000
Received: by outflank-mailman (input) for mailman id 214091;
 Wed, 20 Oct 2021 20:47:05 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mdIUK-0002RJ-VD; Wed, 20 Oct 2021 20:47:04 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mdIUK-0005mj-QM; Wed, 20 Oct 2021 20:47:04 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mdIUK-00021G-Gv; Wed, 20 Oct 2021 20:47:04 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mdIUK-0007Us-GQ; Wed, 20 Oct 2021 20:47:04 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=tHVK/Yvt16ZXUAane8ZIy906tTkLITErWOTE1b77Duw=; b=7HCK2DS8Hdq3LX5aqeOhHuLiKP
	E1avcdjhEXQRFb49fSoW2Yc09aQgQxYWsKdNZZdMSs9TQsGf4CHW1BFZlRGVQy1Kn0DC9TfXMKAMx
	HMtcg3YMKVVbOqmc0G4+b2SeavtWf5kp318lzA91LEhDuFkn0qemdb/BeFXuNDl4ZZas=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165691-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 165691: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=118da371d1ff5d8432fa299544b1ea5e7e3710f0
X-Osstest-Versions-That:
    xen=c12731493ae39640c4e44d9fe2029c3165f9f429
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 20 Oct 2021 20:47:04 +0000

flight 165691 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165691/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  118da371d1ff5d8432fa299544b1ea5e7e3710f0
baseline version:
 xen                  c12731493ae39640c4e44d9fe2029c3165f9f429

Last test of basis   165689  2021-10-20 11:02:49 Z    0 days
Testing same since   165691  2021-10-20 16:01:40 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Bertrand Marquis <bertrand.marquis@arm.com>
  Julien Grall <jgrall@amazon.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   c12731493a..118da371d1  118da371d1ff5d8432fa299544b1ea5e7e3710f0 -> smoke


From xen-devel-bounces@lists.xenproject.org Thu Oct 21 00:00:59 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Oct 2021 00:00:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.214102.372534 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdLVk-0003sy-Ch; Thu, 21 Oct 2021 00:00:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 214102.372534; Thu, 21 Oct 2021 00:00:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdLVk-0003sr-9n; Thu, 21 Oct 2021 00:00:44 +0000
Received: by outflank-mailman (input) for mailman id 214102;
 Thu, 21 Oct 2021 00:00:42 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mdLVi-0003sf-A2; Thu, 21 Oct 2021 00:00:42 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mdLVi-000191-0u; Thu, 21 Oct 2021 00:00:42 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mdLVh-0004Io-Jq; Thu, 21 Oct 2021 00:00:41 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mdLVh-0006No-JK; Thu, 21 Oct 2021 00:00:41 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=dB2GpXCnmVTvqx7o4vmPej8gX+zTY/zD7UphbswVTEY=; b=I+6FmAaN6IZgDNRnOwM0w37VHG
	VyRq9AEZdmvVI0uBST7nxHbQ6KKzwpAMj554Qp7td0Ed0JaRRyF3g0OyhJeumaymrzAxayLRZU9rD
	KmK8bk8z0fWVvfemETb8jtAor08LWGi1C+Cg6Gggu9C/P57P4Pm4y5o0E0CtMipaSPqw=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165687-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-5.4 test] 165687: regressions - FAIL
X-Osstest-Failures:
    linux-5.4:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:regression
    linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=4f508aa9dd3bde7a1c5e4e6de72abb8a03fd504a
X-Osstest-Versions-That:
    linux=ce061ef43f1dede7ee2bd907d2bf38402831e30d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 21 Oct 2021 00:00:41 +0000

flight 165687 linux-5.4 real [real]
flight 165695 linux-5.4 real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/165687/
http://logs.test-lab.xenproject.org/osstest/logs/165695/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 165616

Tests which did not succeed, but are not blocking:
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 165616
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 165616
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165616
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165616
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 165616
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165616
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 165616
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 165616
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 165616
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 165616
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 165616
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 165616
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 linux                4f508aa9dd3bde7a1c5e4e6de72abb8a03fd504a
baseline version:
 linux                ce061ef43f1dede7ee2bd907d2bf38402831e30d

Last test of basis   165616  2021-10-17 09:11:05 Z    3 days
Testing same since   165687  2021-10-20 10:13:27 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Al Viro <viro@zeniv.linux.org.uk>
  Aleksander Morgado <aleksander@aleksander.es>
  Alex Deucher <alexander.deucher@amd.com>
  Andy Shevchenko <andriy.shevchenko@linux.intel.com>
  Ard Biesheuvel <ardb@kernel.org>
  Arnd Bergmann <arnd@arndb.de>
  Aya Levin <ayal@nvidia.com>
  Bartosz Golaszewski <brgl@bgdev.pl>
  Billy Tsai <billy_tsai@aspeedtech.com>
  Borislav Petkov <bp@suse.de>
  Catalin Marinas <catalin.marinas@arm.com>
  chongjiapeng <jiapeng.chong@linux.alibaba.com>
  Chris Packham <chris.packham@alliedtelesis.co.nz>
  Christophe JAILLET <christophe.jaillet@wanadoo.fr>
  Colin Ian King <colin.king@canonical.com>
  Cédric Le Goater <clg@kaod.org>
  Damien Le Moal <damien.lemoal@wdc.com>
  Dan Carpenter <dan.carpenter@oracle.com>
  Daniele Palmas <dnlplm@gmail.com>
  Dave Airlie <airlied@redhat.com>
  David S. Miller <davem@davemloft.net>
  David Sterba <dsterba@suse.com>
  Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
  Dmitry Torokhov <dmitry.torokhov@gmail.com>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Filipe Manana <fdmanana@suse.com>
  Florian fainelli <f.fainelli@gmail.com>
  Greentime Hu <green.hu@gmail.com>
  Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  Guenter Roeck <linux@roeck-us.net>
  Guo Ren <guoren@kernel.org>
  Guo Ren <guoren@linux.alibaba.com>
  Halil Pasic <pasic@linux.ibm.com>
  Hanjun Guo <guohanjun@huawei.com>
  Hans de Goede <hdegoede@redhat.com>
  Hans Potsch <hans.potsch@nokia.com>
  Heiko Carstens <hca@linux.ibm.com>
  Herve Codina <herve.codina@bootlin.com>
  Hui Liu <hui.liu@mediatek.com>
  Hui Wang <hui.wang@canonical.com>
  Hulk Robot <hulkrobot@huawei.com>
  Ido Schimmel <idosch@nvidia.com>
  Jackie Liu <liuyun01@kylinos.cn>
  Jakub Kicinski <kuba@kernel.org>
  James Morse <james.morse@arm.com>
  Jiri Valek - 2N <valek@2n.cz>
  Johan Hovold <johan@kernel.org>
  Jon Hunter <jonathanh@nvidia.com>
  Jonas Hahnfeld <hahnjo@hahnjo.de>
  Jonathan Bell <jonathan@raspberrypi.com>
  Jonathan Cameron <Jonathan.Cameron@huawei.com>
  Kai-Heng Feng <kai.heng.feng@canonical.com>
  Kailang Yang <kailang@realtek.com>
  Linux Kernel Functional Testing <lkft@linaro.org>
  Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
  Marcelo Ricardo Leitner <mleitner@redhat.com>
  Marek Behún <kabel@kernel.org>
  Mathias Nyman <mathias.nyman@linux.intel.com>
  Michael Cullen <michael@michaelcullen.name>
  Michael Ellerman <mpe@ellerman.id.au>
  Michael S. Tsirkin <mst@redhat.com>
  Miklos Szeredi <mszeredi@redhat.com>
  Miquel Raynal <miquel.raynal@bootlin.com>
  Nanyong Sun <sunnanyong@huawei.com>
  Nikolay Martynov <mar.kolya@gmail.com>
  Pavankumar Kondeti <pkondeti@codeaurora.org>
  Qu Wenruo <wqu@suse.com>
  Reinette Chatre <reinette.chatre@intel.com>
  Rob Clark <robdclark@chromium.org>
  Roberto Sassu <roberto.sassu@huawei.com>
  Saeed Mahameed <saeedm@nvidia.com>
  Sam Ravnborg <sam@ravnborg.org>
  Sebastian Andrzej Siewior <bigeasy@linutronix.de>
  seeteena <s1seetee@linux.vnet.ibm.com>
  Shannon Nelson <snelson@pensando.io>
  Shuah Khan <skhan@linuxfoundation.org>
  Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
  Stephen Boyd <swboyd@chromium.org>
  Steven Rostedt (VMware) <rostedt@goodmis.org>
  Steven Rostedt <rostedt@goodmis.org>
  Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
  Takashi Iwai <tiwai@suse.de>
  Tom Lendacky <thomas.lendacky@amd.com>
  Tomaz Solc <tomaz.solc@tablix.org>
  Vadim Pasternak <vadimp@nvidia.com>
  Vasily Gorbik <gor@linux.ibm.com>
  Vegard Nossum <vegard.nossum@oracle.com>
  Wang Hai <wanghai38@huawei.com>
  Werner Sembach <wse@tuxedocomputers.com>
  Wim Van Sebroeck <wim@linux-watchdog.org>
  Yu-Tung Chang <mtwget@gmail.com>
  Zhang Jianhua <chris.zjh@huawei.com>
  Ziyang Xuan <william.xuanziyang@huawei.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 fail    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 1979 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Oct 21 02:48:23 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Oct 2021 02:48:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.214117.372561 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdO7i-0003o6-04; Thu, 21 Oct 2021 02:48:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 214117.372561; Thu, 21 Oct 2021 02:48:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdO7h-0003nz-Rx; Thu, 21 Oct 2021 02:48:05 +0000
Received: by outflank-mailman (input) for mailman id 214117;
 Thu, 21 Oct 2021 02:48:04 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=El98=PJ=arm.com=Hongda.Deng@srs-us1.protection.inumbo.net>)
 id 1mdO7g-0003nt-5x
 for xen-devel@lists.xenproject.org; Thu, 21 Oct 2021 02:48:04 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com (unknown
 [40.107.8.82]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 5deb5d46-96b1-4eab-b629-1d4e4e680b49;
 Thu, 21 Oct 2021 02:47:59 +0000 (UTC)
Received: from DB6PR07CA0189.eurprd07.prod.outlook.com (2603:10a6:6:42::19) by
 DBAPR08MB5622.eurprd08.prod.outlook.com (2603:10a6:10:1af::9) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4628.15; Thu, 21 Oct 2021 02:47:56 +0000
Received: from DB5EUR03FT051.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:6:42:cafe::1) by DB6PR07CA0189.outlook.office365.com
 (2603:10a6:6:42::19) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.10 via Frontend
 Transport; Thu, 21 Oct 2021 02:47:55 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT051.mail.protection.outlook.com (10.152.21.19) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4628.18 via Frontend Transport; Thu, 21 Oct 2021 02:47:55 +0000
Received: ("Tessian outbound a8bfe25d7364:v103");
 Thu, 21 Oct 2021 02:47:55 +0000
Received: from 201d0285ae59.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 B7E34C8B-9C64-4488-A66C-2F994A1E51CE.1; 
 Thu, 21 Oct 2021 02:47:50 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 201d0285ae59.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Thu, 21 Oct 2021 02:47:50 +0000
Received: from VE1PR08MB5677.eurprd08.prod.outlook.com (2603:10a6:800:1ab::17)
 by VI1PR08MB3568.eurprd08.prod.outlook.com (2603:10a6:803:7f::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.15; Thu, 21 Oct
 2021 02:47:48 +0000
Received: from VE1PR08MB5677.eurprd08.prod.outlook.com
 ([fe80::d810:52a3:dce3:4d06]) by VE1PR08MB5677.eurprd08.prod.outlook.com
 ([fe80::d810:52a3:dce3:4d06%7]) with mapi id 15.20.4608.018; Thu, 21 Oct 2021
 02:47:47 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5deb5d46-96b1-4eab-b629-1d4e4e680b49
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Wfobj8LI4D5Hic2BGFa4DKS8cPBWV+51GAEOTMfomuM=;
 b=YMMgI/vsLMUu5NE07ZgrR5WVdZSv6iFbJRUNDECEvzXRrIR10y/B45588WxKtTyoTm7nbz9dgIyDSchfZ5z0ZdVPJgWg1D+xjlRU+DUjJj41zm6FaK7JMdMz7bWG8qagW//hQhxVfHD8Yt5NYWDoTpU62eesbzfKH/QWtF3Oyn4=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=A8XCf0KtHCjJRIR70PpZfj2SElB5MgsCQ/t1ezBUssP8HcTFXCwQXsKSd9O/4stJ23DGu04rcCClaV1Q4leDo76fs+5vaPFiV8FKuSGBlRz6IXH3SGoj15x/zoSGBmXIlqkpazxXgNmGJNjWB2anE+D+eCUIeqBk4bYdNnjShrAjyG+EoYQzKpvlPauOQnBVww3Qj8CCmjYzmRrq53lH24vmDVTl4UmGotRT4TKUjQu4P6Jp71q9yxIHlBivs2kSyMaWKM7vgp0K9ClZiu9xnfJpx9W0yMW2RQ+4JjZommSrVjhNT0ZXF98UDJvzWU8A7hb/qLy8pwx7htL2JmNafg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Wfobj8LI4D5Hic2BGFa4DKS8cPBWV+51GAEOTMfomuM=;
 b=nL2rMoz7y9zCR/rKWCMPLaw4KWOdGsSqXzK2enc/0+7ZpS9gLk1sJXuSTkXj59HmdgRVt+FT9inxEuTC11sf46e1FCEf+76bH8sdAX91LC5MHuRlczyt+l3W2s9ZQw0vp5BiSReHkn6c4mFk4g3x+HzL7C9iuwvccHqzY7/iDhaFvvk/PrjczYDX2F6H/ruqDLrbUnPPJzrECVcozKGF8c9DrDRCgdjO2cjZHC+DHZh/LtwQgFvH+HohtdDACvwq8cP28O83zg1/4/mV3mO+Mqwua1AmdkRP4GSJMz9kOlJMdQZ1zV+qYMAZvonc2ALRbtgMtVtvC4xyhtp/AzYcwQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Wfobj8LI4D5Hic2BGFa4DKS8cPBWV+51GAEOTMfomuM=;
 b=YMMgI/vsLMUu5NE07ZgrR5WVdZSv6iFbJRUNDECEvzXRrIR10y/B45588WxKtTyoTm7nbz9dgIyDSchfZ5z0ZdVPJgWg1D+xjlRU+DUjJj41zm6FaK7JMdMz7bWG8qagW//hQhxVfHD8Yt5NYWDoTpU62eesbzfKH/QWtF3Oyn4=
From: Hongda Deng <Hongda.Deng@arm.com>
To: Julien Grall <julien@xen.org>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, "sstabellini@kernel.org"
	<sstabellini@kernel.org>
CC: Bertrand Marquis <Bertrand.Marquis@arm.com>, Wei Chen <Wei.Chen@arm.com>
Subject: RE: [PATCH v3] xen/arm: vgic to ignore GICD ICPENDRn registers access
Thread-Topic: [PATCH v3] xen/arm: vgic to ignore GICD ICPENDRn registers
 access
Thread-Index: AQHXxZq/5bBDOIDVfE+7v4YmxX4RTavcKSWAgACCAuA=
Date: Thu, 21 Oct 2021 02:47:47 +0000
Message-ID:
 <VE1PR08MB5677925CD0599442A5372C5EE6BF9@VE1PR08MB5677.eurprd08.prod.outlook.com>
References: <20211020101021.9793-1-Hongda.Deng@arm.com>
 <f856653e-b8ea-c632-be6d-5dbb1b18c5f8@xen.org>
In-Reply-To: <f856653e-b8ea-c632-be6d-5dbb1b18c5f8@xen.org>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: 0E06A9592C323143B88A8C08CEF67A9E.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: 0dc7460b-d896-43de-da3e-08d9943d2f59
x-ms-traffictypediagnostic: VI1PR08MB3568:|DBAPR08MB5622:
X-Microsoft-Antispam-PRVS:
	<DBAPR08MB56225DA735CB74696AC7ACE5E6BF9@DBAPR08MB5622.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:3826;OLM:3826;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 wUBpLuLbS5FC8hIpxiPjC113hAEyxGALZ6n0ys9p9gs8KuWzZWhmF+7foPHAjZUFtkv9W7Xrdm7pmB+cgVHUaoUob6fQobRbSmU8NKyzTOWkMFypcn4517vakH4VmOuxjZFv6/cKRMlUDamz6woZfq605LP3Rs+blWC0OHnO3ovNRDTJAvl8M3qiZsClpdxcy40dbPbA3C8a2i370q7hU6yXhP/jDgfwC0qncjQFAZiPm4MQoshcgDk4jEYTb9DxyDmUarQwvi0wKE/hsasU1hYldR2TZ61yyZVPlBWoCsK+WPv7Ps31g1ubis8a1xGbvkwpkQs3tNHj35Wb6VPKpllkhhn/ZLE/7g4wilWbg/eDYpbXe4LZFZhMrTLYL6HSgxFYJ+lw47nznFPdtGMpb1sv0kHF7zBzy+tqwy8D9pul+UrU7uILa5cdAfcpr0XXmpo71Oi3703ezZ6UAy4jbd3MTWmP5y5PHkOIQGx++pJI3fXea9aI9LpVq/GPopEChEOXotu23uxh27O9/iFdyrsL/moM0HRide3oxHjM4MSNNbNLGvUrBSKK0VvWilnjB1auTgqcqfLSvJklfcA+Z/0Aj3AG8yyMfY1TIqRAiC0dl4iMIvmN+FEKp892cOK2Nq2jPVtqdyFQGmhOFj8dwvBiM4JnRE83YCMKeWThNeYNs6X7IDjf4OEtdn3883f08+gzr3lGbMcrt0yBweOUComaPVYWLqVtmuE3XhquUoH9Y5WEVI9vhGQrROFpkwn87VOfaIqI5qLjpcpKr7YkSCDeBArY9HWBygHeUidUAjA=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR08MB5677.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(966005)(9686003)(55016002)(508600001)(86362001)(66476007)(52536014)(66446008)(76116006)(83380400001)(33656002)(64756008)(66556008)(66946007)(110136005)(38100700002)(54906003)(26005)(71200400001)(316002)(5660300002)(122000001)(8936002)(38070700005)(8676002)(7696005)(186003)(4326008)(53546011)(2906002)(6506007);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3568
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT051.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	1f082ec1-0126-4acf-3ed9-08d9943d2aa2
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	z9Y7ZAIx9bNh4pumWhgraOo6LsTa5pKKMQWKJxi1T43Du8/gGBKM1OMjStHvA+HwQRu4qmM1nWaaEKwr8hYM+zBZ9R15AhTqGPA1s/304FF1Xq96E3y/qzhAcrZ8Y0PF2Uf4fiAR8L5tR8dMUrHDRAnYIprQIy7KGaRg0Sy8+V95t4P7AqjWouBjPkLFmqzO4+t5DHUtkjOJ/C2AO7ufzcaPs0lNZ7qgjhNLEsemu2tFVBxvPdvpAgyhR40W/AO5GsaUP0sGTgtQnU53eJmKvia2E7Va1vUgH/DvhVrC/qffJdI+t85hj1A7u5/15u1gN2hRm3dJDg6eC/oVrKbTV35J5BEDybKS8XAcCaYDb0ZBlk4O02yosVf8XCUbB9a1teKXwffmWHkV/f5k4F2nOS0OYT0SyFi1Wh38cvXVt/Fz+9PYbstEunxwOOngbX3+OdAeS3URCJZ7TjVt1Invw2xYQw471bqiJDYJf+tIxX/wwQ2x7mtBEVaYOWj/5MxJXkjUUvNBDU62o3E+T5oqOPxPJxLqYk+tpY1y+eE4vOD82qBUMdp3bvkVs6RblvZi2JavSq/KbUCsc9Svc/NHZnsIFcbrYGJH7hMzxpMWoXbKvAl5iQrDlcPEN8W4bGQdOmkT7+OJKEz79tQY+OsVMc5oK7l/UQoXNc+ec4GuEiqQc/pB0k57sBSIj7luz6s/Ze9PgabLWy5lYC42NsJ27jAks8NDvPJRF3Tmz2RD/rPFO5i9BePhZmiTMccQCGTZdKNolfVnCoJtNX+yiAFJR/rp2iIhtAiR2MRBf2AkvFg=
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(7696005)(53546011)(4326008)(6506007)(82310400003)(316002)(9686003)(55016002)(110136005)(86362001)(54906003)(36860700001)(508600001)(966005)(5660300002)(47076005)(33656002)(81166007)(356005)(2906002)(336012)(8936002)(8676002)(186003)(83380400001)(52536014)(70206006)(26005)(70586007);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Oct 2021 02:47:55.7889
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 0dc7460b-d896-43de-da3e-08d9943d2f59
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT051.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR08MB5622

DQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogSnVsaWVuIEdyYWxsIDxq
dWxpZW5AeGVuLm9yZz4NCj4gU2VudDogMjAyMeW5tDEw5pyIMjHml6UgMTo0NQ0KPiBUbzogSG9u
Z2RhIERlbmcgPEhvbmdkYS5EZW5nQGFybS5jb20+OyB4ZW4tDQo+IGRldmVsQGxpc3RzLnhlbnBy
b2plY3Qub3JnOyBzc3RhYmVsbGluaUBrZXJuZWwub3JnDQo+IENjOiBCZXJ0cmFuZCBNYXJxdWlz
IDxCZXJ0cmFuZC5NYXJxdWlzQGFybS5jb20+OyBXZWkgQ2hlbg0KPiA8V2VpLkNoZW5AYXJtLmNv
bT4NCj4gU3ViamVjdDogUmU6IFtQQVRDSCB2M10geGVuL2FybTogdmdpYyB0byBpZ25vcmUgR0lD
RCBJQ1BFTkRSbiByZWdpc3RlcnMNCj4gYWNjZXNzDQo+IA0KPiBIaSBIb25nZGEsDQo+IA0KPiBU
aXRsZTogSSB3b3VsZCBzdWdnZXN0IHRoZSBmb2xsb3dpbmcgdGl0bGU6DQo+IA0KPiB4ZW4vYXJt
OiB2Z2ljOiBJZ25vcmUgd3JpdGUgYWNjZXNzIHRvIElDUEVORFIqDQo+IA0KDQpBZ3JlZWQuDQoN
Cj4gT24gMjAvMTAvMjAyMSAxMToxMCwgSG9uZ2RhIERlbmcgd3JvdGU6DQo+ID4gQ3VycmVudGx5
LCBYZW4gd2lsbCByZXR1cm4gSU8gdW5oYW5kbGVkIHdoZW4gZ3Vlc3RzIGFjY2VzcyBHSUNEIElD
UEVOUm4NCj4gPiByZWdpc3RlcnMuIFRoaXMgd2lsbCByYWlzZSBhIGRhdGEgYWJvcnQgaW5zaWRl
IGd1ZXN0LiBGb3IgTGludXggR3Vlc3QsDQo+ID4gdGhlc2UgdmlydHVhbCByZWdpc3RlcnMgd2ls
bCBub3QgYmUgYWNjZXNzZWQuIEJ1dCBmb3IgWmVwaHlyLCBpbiBpdHMNCj4gPiBHSUMgaW5pdGlh
bGl6YXRpb24gY29kZSwgdGhlc2UgdmlydHVhbCByZWdpc3RlcnMgd2lsbCBiZSBhY2Nlc3NlZC4g
QW5kDQo+ID4gemVwaHlyIGd1ZXN0IHdpbGwgZ2V0IGFuIElPIGRhdGEgYWJvcnQgaW4gaW5pdGls
aXphdGlvbiBzdGFnZSBhbmQgZW50ZXINCj4gVHlwbzogcy9pbml0aWxpemF0aW9uL2luaXRpYWxp
emF0aW9uLw0KPiANCj4gSSB3b3VsZCBhbHNvIHMvaW4vZHVyaW5nIHRoZS8NCj4gDQo+ID4gZmF0
YWwgZXJyb3IuIEVtdWxhdGluZyBJQ1BFTkRSIGlzIG5vdCBlYXN5IHdpdGggdGhlIGV4aXN0aW5n
IHZHSUMsIHNvDQo+IA0KPiBIb3cgYWJvdXQgcy9lbnRlciBmYXRhbCBlcnJvci9jcmFzaC8/DQo+
IA0KDQpBZ3JlZWQuDQoNCj4gPiB3ZSBjdXJyZW50bHkgaWdub3JlIHRoZXNlIHZpcnR1YWwgcmVn
aXN0ZXJzIGFjY2VzcyBhbmQgcHJpbnQgYSBtZXNzYWdlDQo+IA0KPiBUbyBtZSAnY3VycmVudGx5
JyByZWZlcnMgdG8gdGhlIGV4aXN0aW5nIGNvZGUgYmFzZSAoaS5lLiB3aXRob3V0IHlvdXINCj4g
cGF0Y2gpLiBJbiBmYWN0LCB0aGlzIHNlZW1zIHRvIGJlIGhvdyB5b3UgdXNlICdjdXJyZW50bHkn
IGluIHRoZSBmaXJzdA0KPiBwYXJhZ3JhcGguwqBTbyBob3cgYWJvdXQgcmVwbGFjZSAic28gd2Ug
Y3VycmVudGx5IiB3aXRoICJyZXdvcmsgdGhlDQo+IGVtdWxhdGlvbiB0byBpZ25vcmUuLi4iLg0K
PiANCj4gVGhpcyBzZWVtcyB0byBzdWdnZXN0IHRoZSBwYXRjaCB3aWxsIG1vZGlmeSBib3RoIHJl
YWQgYW5kIHdyaXRlIGFjY2Vzcy4NCj4gSG93ZXZlciwgQUZBSUNULCBvbmx5IHRoZSB3cml0ZSBl
bXVsYXRpb24gaXMgbW9kaWZpZWQuIENhbiB0aGlzIGJlDQo+IGNsYXJpZmllZCBpbiB0aGUgY29t
bWl0IG1lc3NhZ2U/DQo+IA0KDQpBY2suDQoNCj4gPiBhYm91dCB3aGV0aGVyIHRoZXkgYXJlIGFs
cmVhZHkgcGVuZGluZyBpbnN0ZWFkIG9mIHJldHVybmluZyB1bmhhbmRsZWQuDQo+ID4gTW9yZSBk
ZXRhaWxzIGNhbiBiZSBmb3VuZCBhdCBbMV0uDQo+ID4NCj4gPiBbMV0gaHR0cHM6Ly9naXRodWIu
Y29tL3plcGh5cnByb2plY3QtDQo+IHJ0b3MvemVwaHlyL2Jsb2IvZWFmNmNmNzQ1ZGYzODA3ZTZl
DQo+ID4gY2M5NDFjM2EzMGRlNmMxNzlhZTM1OS9kcml2ZXJzL2ludGVycnVwdF9jb250cm9sbGVy
L2ludGNfZ2ljdjMuYyNMMjc0DQo+ID4NCj4gPiBTaWduZWQtb2ZmLWJ5OiBIb25nZGEgRGVuZyA8
aG9uZ2RhLmRlbmdAYXJtLmNvbT4NCj4gPiAtLS0NCj4gPiBDaGFuZ2VzIHNpbmNlIHYyOg0KPiA+
ICAgKiAgQXZvaWQgdG8gcHJpbnQgbWVzc2FnZXMgd2hlbiB0aGVyZSBpcyBubyBwZW5kaW5nIGlu
dGVycnVwdA0KPiA+ICAgKiAgQWRkIGhlbHBlciB2Z2ljX2NoZWNrX2luZmxpZ2h0X2lycXNfcGVu
ZGluZyB0byBjaGVjayBwZW5kaW5nIHN0YXR1cw0KPiA+ICAgKiAgUHJpbnQgYSBtZXNzYWdlIGZv
ciBlYWNoIGludGVycnVwdCBzZXBhcmF0ZWx5DQo+ID4gQ2hhbmdlcyBzaW5jZSB2MToNCj4gPiAg
ICogIENoZWNrIHBlbmRpbmcgc3RhdGVzIGJ5IGdvaW5nIHRocm91Z2ggdmNwdS0+YXJjaC52Z2lj
LmluZmxpZ2h0X2lycXMNCj4gPiAgICAgIGluc3RlYWQgb2YgY2hlY2tpbmcgaGFyZHdhcmUgcmVn
aXN0ZXJzDQo+ID4gLS0tDQo+ID4gICB4ZW4vYXJjaC9hcm0vdmdpYy12Mi5jICAgICB8IDEwICsr
KysrKy0tLS0NCj4gPiAgIHhlbi9hcmNoL2FybS92Z2ljLXYzLmMgICAgIHwgMTYgKysrKysrKyst
LS0tLS0tLQ0KPiA+ICAgeGVuL2FyY2gvYXJtL3ZnaWMuYyAgICAgICAgfCAzNg0KPiArKysrKysr
KysrKysrKysrKysrKysrKysrKysrKysrKysrKysNCj4gPiAgIHhlbi9pbmNsdWRlL2FzbS1hcm0v
dmdpYy5oIHwgIDMgKystDQo+ID4gICA0IGZpbGVzIGNoYW5nZWQsIDUyIGluc2VydGlvbnMoKyks
IDEzIGRlbGV0aW9ucygtKQ0KPiA+DQo+ID4gZGlmZiAtLWdpdCBhL3hlbi9hcmNoL2FybS92Z2lj
LXYyLmMgYi94ZW4vYXJjaC9hcm0vdmdpYy12Mi5jDQo+ID4gaW5kZXggYjJkYTg4NmFkYy4uN2Mz
MGRhMzI3YyAxMDA2NDQNCj4gPiAtLS0gYS94ZW4vYXJjaC9hcm0vdmdpYy12Mi5jDQo+ID4gKysr
IGIveGVuL2FyY2gvYXJtL3ZnaWMtdjIuYw0KPiA+IEBAIC00ODEsMTAgKzQ4MSwxMiBAQCBzdGF0
aWMgaW50IHZnaWNfdjJfZGlzdHJfbW1pb193cml0ZShzdHJ1Y3QgdmNwdQ0KPiAqdiwgbW1pb19p
bmZvX3QgKmluZm8sDQo+ID4NCj4gPiAgICAgICBjYXNlIFZSQU5HRTMyKEdJQ0RfSUNQRU5EUiwg
R0lDRF9JQ1BFTkRSTik6DQo+ID4gICAgICAgICAgIGlmICggZGFidC5zaXplICE9IERBQlRfV09S
RCApIGdvdG8gYmFkX3dpZHRoOw0KPiA+IC0gICAgICAgIHByaW50ayhYRU5MT0dfR19FUlINCj4g
PiAtICAgICAgICAgICAgICAgIiVwdjogdkdJQ0Q6IHVuaGFuZGxlZCB3b3JkIHdyaXRlICUjIlBS
SXJlZ2lzdGVyIiB0bw0KPiBJQ1BFTkRSJWRcbiIsDQo+ID4gLSAgICAgICAgICAgICAgIHYsIHIs
IGdpY2RfcmVnIC0gR0lDRF9JQ1BFTkRSKTsNCj4gPiAtICAgICAgICByZXR1cm4gMDsNCj4gPiAr
ICAgICAgICByYW5rID0gdmdpY19yYW5rX29mZnNldCh2LCAxLCBnaWNkX3JlZyAtIEdJQ0RfSUNQ
RU5EUiwgREFCVF9XT1JEKTsNCj4gPiArICAgICAgICBpZiAoIHJhbmsgPT0gTlVMTCApIGdvdG8g
d3JpdGVfaWdub3JlOw0KPiA+ICsNCj4gPiArICAgICAgICB2Z2ljX2NoZWNrX2luZmxpZ2h0X2ly
cXNfcGVuZGluZyh2LT5kb21haW4sIHYsIHJhbmstPmluZGV4LCByKTsgPiArDQo+ID4gKyAgICAg
ICAgZ290byB3cml0ZV9pZ25vcmVfMzI7DQo+IA0KPiBOSVQ6IFdlIGFscmVhZHkgY2hlY2sgdGhl
IGFjY2VzcyBhYm92ZS4gU28gSSB3b3VsZCBzaW1wbHkgdXNlDQo+ICJ3cml0ZV9pZ25vcmUiIGhl
cmUuDQo+IA0KDQpBY2suDQoNCj4gPg0KPiA+ICAgICAgIGNhc2UgVlJBTkdFMzIoR0lDRF9JU0FD
VElWRVIsIEdJQ0RfSVNBQ1RJVkVSTik6DQo+ID4gICAgICAgICAgIGlmICggZGFidC5zaXplICE9
IERBQlRfV09SRCApIGdvdG8gYmFkX3dpZHRoOw0KPiA+IGRpZmYgLS1naXQgYS94ZW4vYXJjaC9h
cm0vdmdpYy12My5jIGIveGVuL2FyY2gvYXJtL3ZnaWMtdjMuYw0KPiA+IGluZGV4IGNiNWE3MGM0
MmUuLjQ5MTMzMDFkMjIgMTAwNjQ0DQo+ID4gLS0tIGEveGVuL2FyY2gvYXJtL3ZnaWMtdjMuYw0K
PiA+ICsrKyBiL3hlbi9hcmNoL2FybS92Z2ljLXYzLmMNCj4gPiBAQCAtODE3LDEwICs4MTcsMTIg
QEAgc3RhdGljIGludA0KPiBfX3ZnaWNfdjNfZGlzdHJfY29tbW9uX21taW9fd3JpdGUoY29uc3Qg
Y2hhciAqbmFtZSwgc3RydWN0IHZjcHUgKnYsDQo+ID4NCj4gPiAgICAgICBjYXNlIFZSQU5HRTMy
KEdJQ0RfSUNQRU5EUiwgR0lDRF9JQ1BFTkRSTik6DQo+ID4gICAgICAgICAgIGlmICggZGFidC5z
aXplICE9IERBQlRfV09SRCApIGdvdG8gYmFkX3dpZHRoOw0KPiA+IC0gICAgICAgIHByaW50ayhY
RU5MT0dfR19FUlINCj4gPiAtICAgICAgICAgICAgICAgIiVwdjogJXM6IHVuaGFuZGxlZCB3b3Jk
IHdyaXRlICUjIlBSSXJlZ2lzdGVyIiB0bw0KPiBJQ1BFTkRSJWRcbiIsDQo+ID4gLSAgICAgICAg
ICAgICAgIHYsIG5hbWUsIHIsIHJlZyAtIEdJQ0RfSUNQRU5EUik7DQo+ID4gLSAgICAgICAgcmV0
dXJuIDA7DQo+ID4gKyAgICAgICAgcmFuayA9IHZnaWNfcmFua19vZmZzZXQodiwgMSwgcmVnIC0g
R0lDRF9JQ1BFTkRSLCBEQUJUX1dPUkQpOw0KPiA+ICsgICAgICAgIGlmICggcmFuayA9PSBOVUxM
ICkgZ290byB3cml0ZV9pZ25vcmU7DQo+ID4gKw0KPiA+ICsgICAgICAgIHZnaWNfY2hlY2tfaW5m
bGlnaHRfaXJxc19wZW5kaW5nKHYtPmRvbWFpbiwgdiwgcmFuay0+aW5kZXgsIHIpOw0KPiA+ICsN
Cj4gPiArICAgICAgICBnb3RvIHdyaXRlX2lnbm9yZV8zMjsNCj4gDQo+IE5JVDogU2FtZSByZW1h
cmsgYXMgdGhlIHByZXZpb3VzIHdyaXRlX2lnbm9yZV8zMi4NCj4gDQoNCkFjay4NCg0KPiA+DQo+
ID4gICAgICAgY2FzZSBWUkFOR0UzMihHSUNEX0lTQUNUSVZFUiwgR0lDRF9JU0FDVElWRVJOKToN
Cj4gPiAgICAgICAgICAgaWYgKCBkYWJ0LnNpemUgIT0gREFCVF9XT1JEICkgZ290byBiYWRfd2lk
dGg7DQo+ID4gQEAgLTk4NywxMCArOTg5LDggQEAgc3RhdGljIGludCB2Z2ljX3YzX3JkaXN0cl9z
Z2lfbW1pb193cml0ZShzdHJ1Y3QNCj4gdmNwdSAqdiwgbW1pb19pbmZvX3QgKmluZm8sDQo+ID4N
Cj4gPiAgICAgICBjYXNlIFZSRUczMihHSUNSX0lDUEVORFIwKToNCj4gPiAgICAgICAgICAgaWYg
KCBkYWJ0LnNpemUgIT0gREFCVF9XT1JEICkgZ290byBiYWRfd2lkdGg7DQo+ID4gLSAgICAgICAg
cHJpbnRrKFhFTkxPR19HX0VSUg0KPiA+IC0gICAgICAgICAgICAgICAiJXB2OiB2R0lDUjogU0dJ
OiB1bmhhbmRsZWQgd29yZCB3cml0ZSAlIyJQUklyZWdpc3RlciIgdG8NCj4gSUNQRU5EUjBcbiIs
DQo+ID4gLSAgICAgICAgICAgICAgIHYsIHIpOw0KPiA+IC0gICAgICAgIHJldHVybiAwOw0KPiA+
ICsgICAgICAgIHJldHVybiBfX3ZnaWNfdjNfZGlzdHJfY29tbW9uX21taW9fd3JpdGUoInZHSUNS
OiBTR0kiLCB2LA0KPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgaW5mbywgZ2ljcl9yZWcsIHIpOw0KPiA+DQo+ID4gICAgICAgY2FzZSBWUkVHMzIo
R0lDUl9JR1JQTU9EUjApOg0KPiA+ICAgICAgICAgICAvKiBXZSBkbyBub3QgaW1wbGVtZW50IHNl
Y3VyaXR5IGV4dGVuc2lvbnMgZm9yIGd1ZXN0cywgd3JpdGUgaWdub3JlDQo+ICovDQo+ID4gZGlm
ZiAtLWdpdCBhL3hlbi9hcmNoL2FybS92Z2ljLmMgYi94ZW4vYXJjaC9hcm0vdmdpYy5jDQo+ID4g
aW5kZXggOGY5NDAwYTUxOS4uMDU2NTU1NzgxNCAxMDA2NDQNCj4gPiAtLS0gYS94ZW4vYXJjaC9h
cm0vdmdpYy5jDQo+ID4gKysrIGIveGVuL2FyY2gvYXJtL3ZnaWMuYw0KPiA+IEBAIC03MjYsNiAr
NzI2LDQyIEBAIHVuc2lnbmVkIGludCB2Z2ljX21heF92Y3B1cyh1bnNpZ25lZCBpbnQNCj4gZG9t
Y3RsX3ZnaWNfdmVyc2lvbikNCj4gPiAgICAgICB9DQo+ID4gICB9DQo+ID4NCj4gPiArdm9pZCB2
Z2ljX2NoZWNrX2luZmxpZ2h0X2lycXNfcGVuZGluZyhzdHJ1Y3QgZG9tYWluICpkLCBzdHJ1Y3Qg
dmNwdSAqdiwNCj4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB1bnNp
Z25lZCBpbnQgcmFuaywgdWludDMyX3QgcikNCj4gPiArew0KPiA+ICsgICAgY29uc3QgdW5zaWdu
ZWQgbG9uZyBtYXNrID0gcjsNCj4gPiArICAgIHVuc2lnbmVkIGludCBpOw0KPiA+ICsgICAgdW5z
aWduZWQgbG9uZyBmbGFnczsNCj4gPiArICAgIHN0cnVjdCBwZW5kaW5nX2lycSAqcDsNCj4gPiAr
ICAgIGJvb2wgcHJpdmF0ZSA9IHJhbmsgPT0gMDsNCj4gPiArICAgIHN0cnVjdCB2Y3B1ICp2X3Rh
cmdldDsNCj4gDQo+IEFGQUlDLCBmbGFncywgcCwgdl90YXJnZXQgYXJlIG9ubHkgdXNlZCB3aXRo
aW4gdGhlIGxvb3AuIFNvIHBsZWFzZQ0KPiByZWR1Y2UgdGhlIHNjb3BlIGFuZCBvbmx5IGRlY2xh
cmUgdGhlbSBpbiBmb3JfZWFjaF9zZXRfYml0KCkuDQo+IA0KDQpBY2suDQoNCj4gPiArDQo+ID4g
KyAgICBmb3JfZWFjaF9zZXRfYml0KCBpLCAmbWFzaywgMzIgKQ0KPiA+ICsgICAgew0KPiA+ICsg
ICAgICAgIHVuc2lnbmVkIGludCBpcnEgPSBpICsgMzIgKiByYW5rOw0KPiA+ICsNCj4gPiArICAg
ICAgICBpZiAoIHByaXZhdGUgKQ0KPiA+ICsgICAgICAgICAgICB2X3RhcmdldCA9IHZnaWNfZ2V0
X3RhcmdldF92Y3B1KHYsIGlycSk7DQo+ID4gKyAgICAgICAgZWxzZQ0KPiA+ICsgICAgICAgICAg
ICB2X3RhcmdldCA9IHZnaWNfZ2V0X3RhcmdldF92Y3B1KGQtPnZjcHVbMF0sIGlycSk7DQo+IA0K
PiBTaGFyZWQgaW50ZXJydXB0cyBjYW4gYmUgYWNjZXNzZWQgZnJvbSBhbnkgdkNQVS4gU28geW91
IGNhbiByZXBsYWNlIHRoZQ0KPiA0IGxpbmVzIHdpdGg6DQo+ICAgICB2X3RhcmdldCA9IHZnaWNf
Z2V0X3RhcmdldF92Y3B1KHYsIGlycSk7DQo+IA0KDQpBY2suDQpJIHRob3VnaHQgdGhhdCB2IG1h
eSBiZSBOVUxMLCBvYnZpb3VzbHkgSSB3YXMgb3ZlcnRoaW5raW5nIGFib3V0IGl0Lg0KDQo+ID4g
Kw0KPiA+ICsgICAgICAgIHNwaW5fbG9ja19pcnFzYXZlKCZ2X3RhcmdldC0+YXJjaC52Z2ljLmxv
Y2ssIGZsYWdzKTsNCj4gPiArDQo+ID4gKyAgICAgICAgcCA9IGlycV90b19wZW5kaW5nKHZfdGFy
Z2V0LCBpcnEpOw0KPiA+ICsNCj4gPiArICAgICAgICBpZiAoIHVubGlrZWx5KCFwKSApDQo+ID4g
KyAgICAgICAgew0KPiA+ICsgICAgICAgICAgICBzcGluX3VubG9ja19pcnFyZXN0b3JlKCZ2X3Rh
cmdldC0+YXJjaC52Z2ljLmxvY2ssIGZsYWdzKTsNCj4gPiArICAgICAgICAgICAgY29udGludWU7
DQo+ID4gKyAgICAgICAgfQ0KPiANCj4gaXJxX3RvX3BlbmRpbmcoKSBjYW5ub3QgcmV0dXJuIE5V
TEwgZm9yIG5vbi1MUEkgaW50ZXJydXB0cy4gQnV0IGlmIHlvdQ0KPiBzdGlsbCB3YW50IHRvIGNo
ZWNrIGl0LCB0aGVuIHRoZSB0d28gaWYgY2FuIGJlIGNvbWJpbmVkIHRvIHNvbWV0aGluZyBsaWtl
Og0KPiANCj4gaWYgKCBwICYmICFsaXN0X2VtcHR5KCZwLT5pbmZsaWdodCkgKQ0KPiAgICBwcmlu
dGsoLi4uKQ0KPiANCj4gc3Bpbl91bmxvY2tfaXJxcmVzdG9yZSguLi4pOw0KPiANCg0KQWNrLg0K
DQo+ID4gKw0KPiA+ICsgICAgICAgIGlmICggIWxpc3RfZW1wdHkoJnAtPmluZmxpZ2h0KSApDQo+
ID4gKyAgICAgICAgICAgIHByaW50aygiJXB2IHRyeWluZyB0byBjbGVhciBwZW5kaW5nIGludGVy
cnVwdCAldS5cbiIsIHYsIGlycSk7DQo+IA0KPiBUaGlzIHdhbnRzIHRvIGJlIGEgcHJpbnRrKFhF
TkxPR19HX1dBUk5JTkcgLi4uKSBzbyB0aGUgbWVzc2FnZSB3aWxsIGJlDQo+IGFwcHJvcHJpYXRl
bHkgcmF0ZS1saW1pdGVkLg0KPiANCg0KQWNrLg0KDQo+ID4gKw0KPiA+ICsgICAgICAgIHNwaW5f
dW5sb2NrX2lycXJlc3RvcmUoJnZfdGFyZ2V0LT5hcmNoLnZnaWMubG9jaywgZmxhZ3MpOw0KPiA+
ICsgICAgfQ0KPiA+ICt9DQo+ID4gKw0KPiA+ICAgLyoNCj4gPiAgICAqIExvY2FsIHZhcmlhYmxl
czoNCj4gPiAgICAqIG1vZGU6IEMNCj4gPiBkaWZmIC0tZ2l0IGEveGVuL2luY2x1ZGUvYXNtLWFy
bS92Z2ljLmggYi94ZW4vaW5jbHVkZS9hc20tYXJtL3ZnaWMuaA0KPiA+IGluZGV4IDYyYzJhZTUz
OGQuLmFiY2FhZTI5NjkgMTAwNjQ0DQo+ID4gLS0tIGEveGVuL2luY2x1ZGUvYXNtLWFybS92Z2lj
LmgNCj4gPiArKysgYi94ZW4vaW5jbHVkZS9hc20tYXJtL3ZnaWMuaA0KPiA+IEBAIC0yOTgsNyAr
Mjk4LDggQEAgZXh0ZXJuIGJvb2wgdmdpY190b19zZ2koc3RydWN0IHZjcHUgKnYsIHJlZ2lzdGVy
X3QNCj4gc2dpciwNCj4gPiAgICAgICAgICAgICAgICAgICAgICAgICAgIGVudW0gZ2ljX3NnaV9t
b2RlIGlycW1vZGUsIGludCB2aXJxLA0KPiA+ICAgICAgICAgICAgICAgICAgICAgICAgICAgY29u
c3Qgc3RydWN0IHNnaV90YXJnZXQgKnRhcmdldCk7DQo+ID4gICBleHRlcm4gYm9vbCB2Z2ljX21p
Z3JhdGVfaXJxKHN0cnVjdCB2Y3B1ICpvbGQsIHN0cnVjdCB2Y3B1ICpuZXcsIHVuc2lnbmVkDQo+
IGludCBpcnEpOw0KPiA+IC0NCj4gPiArZXh0ZXJuIHZvaWQgdmdpY19jaGVja19pbmZsaWdodF9p
cnFzX3BlbmRpbmcoc3RydWN0IGRvbWFpbiAqZCwgc3RydWN0DQo+IHZjcHUgKnYsDQo+ID4gKyAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHVuc2lnbmVkIGludCBy
YW5rLCB1aW50MzJfdCByKTsNCj4gDQo+IFBsZWFzZSBrZWVwIHRoZSBuZXdsaW5lIGJlZm9yZSB0
aGUgI2VuZGlmLg0KPiANCg0KQWNrLg0KDQo+ID4gICAjZW5kaWYgLyogIUNPTkZJR19ORVdfVkdJ
QyAqLw0KPiA+DQo+ID4gICAvKioqIENvbW1vbiBWR0lDIGZ1bmN0aW9ucyB1c2VkIGJ5IFhlbiBh
cmNoIGNvZGUgKioqKi8NCj4gPg0KPiANCj4gQ2hlZXJzLA0KPiANCj4gLS0NCj4gSnVsaWVuIEdy
YWxsDQoNClRoYW5rcyBmb3IgeW91ciBkZXRhaWxlZCBzdWdnZXN0aW9uICEgSSB3aWxsIGtlZXAg
dGhlc2UgY29kZSBwcmluY2lwbGVzIGluIG1pbmQuDQpJIHdpbGwgc2VuZCBwYXRjaCB2ZXJzaW9u
NCBBU0FQLg0KDQpDaGVlcnMsDQotLS0NCkhvbmdkYQ0KDQo=


From xen-devel-bounces@lists.xenproject.org Thu Oct 21 03:01:15 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Oct 2021 03:01:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.214129.372579 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdOKM-0006DY-BI; Thu, 21 Oct 2021 03:01:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 214129.372579; Thu, 21 Oct 2021 03:01:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdOKM-0006DR-8K; Thu, 21 Oct 2021 03:01:10 +0000
Received: by outflank-mailman (input) for mailman id 214129;
 Thu, 21 Oct 2021 03:01:08 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mdOKK-0006DF-6d; Thu, 21 Oct 2021 03:01:08 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mdOKK-0006AC-1z; Thu, 21 Oct 2021 03:01:08 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mdOKJ-0004Hx-Ms; Thu, 21 Oct 2021 03:01:07 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mdOKJ-0005iq-MM; Thu, 21 Oct 2021 03:01:07 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=/P6bFRHcYw3amyE3h9/+j0vKHSUGyNocvqPHdIA3kBo=; b=zu2lxIfdGyT40w6bFB8sF+YrlN
	XV73QT4iAURKp+/2/6GzYdhoi/xNERCILgafLYvCJCYKvrhn7BQ0hFpmKNw7VoEB5xYJoU5HEXDmj
	oQDV8H4QdF8nMY7u882ctKaVlFOg87ZsdioONWjwRfnWC/nvDF71EAotRBTf5tThz8sU=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165692-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 165692: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=c12731493ae39640c4e44d9fe2029c3165f9f429
X-Osstest-Versions-That:
    xen=6809998c5f8f1d2e26ac9e867af8ac71e7a66cf2
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 21 Oct 2021 03:01:07 +0000

flight 165692 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165692/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 165684
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 165684
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165684
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165684
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 165684
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 165684
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 165684
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 165684
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 165684
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 165684
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165684
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 165684
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  c12731493ae39640c4e44d9fe2029c3165f9f429
baseline version:
 xen                  6809998c5f8f1d2e26ac9e867af8ac71e7a66cf2

Last test of basis   165684  2021-10-20 05:36:15 Z    0 days
Testing same since   165692  2021-10-20 16:37:57 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Jan Beulich <jbeulich@suse.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Thomas Gleixner <tglx@linutronix.de>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   6809998c5f..c12731493a  c12731493ae39640c4e44d9fe2029c3165f9f429 -> master


From xen-devel-bounces@lists.xenproject.org Thu Oct 21 03:25:14 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Oct 2021 03:25:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.214137.372594 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdOhW-00006Q-EB; Thu, 21 Oct 2021 03:25:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 214137.372594; Thu, 21 Oct 2021 03:25:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdOhW-00006J-9P; Thu, 21 Oct 2021 03:25:06 +0000
Received: by outflank-mailman (input) for mailman id 214137;
 Thu, 21 Oct 2021 03:25:05 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mdOhV-000069-Nf; Thu, 21 Oct 2021 03:25:05 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mdOhV-0006WP-IM; Thu, 21 Oct 2021 03:25:05 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mdOhV-0005zs-6n; Thu, 21 Oct 2021 03:25:05 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mdOhV-0000mx-6G; Thu, 21 Oct 2021 03:25:05 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=TjWrK37T8O78FfOo5PAu464hFUfMECMbVozfCVshPcA=; b=faspzS+FTM9S7ylLHT1IuyrvHa
	jQvlwaLHNeoS7YQqrOW71j/RccYUshaE05KGITXOMyFIlFsXRTysBaZBQzJK0G5IIStHaGpx0WSXm
	OVvaAT9R4BF6ECFkzS6Oyjy9fMIqRxuYu4oUBj9/EWZyKtDlJsXxY5f7APzNKryLppdI=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165693-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 165693: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=8e37395c3a5dceff62a5010ebbbc107f4145935c
X-Osstest-Versions-That:
    linux=d9abdee5fd5abffd0e763e52fbfa3116de167822
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 21 Oct 2021 03:25:05 +0000

flight 165693 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165693/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 165679
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 165679
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165679
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165679
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 165679
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165679
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 165679
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 165679
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 linux                8e37395c3a5dceff62a5010ebbbc107f4145935c
baseline version:
 linux                d9abdee5fd5abffd0e763e52fbfa3116de167822

Last test of basis   165679  2021-10-19 16:09:29 Z    1 days
Testing same since   165693  2021-10-20 16:40:19 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andy Shevchenko <andriy.shevchenko@linux.intel.com>
  Brendan Grieve <brendan@grieve.com.au>
  Charles Keepax <ckeepax@opensource.cirrus.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Davide Baldo <davide@baldo.me>
  Dinh Nguyen <dinguyen@kernel.org>
  Gaosheng Cui <cuigaosheng1@huawei.com>
  Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  Hans de Goede <hdegoede@redhat.com>
  Hao Xiang <hao.xiang@linux.alibaba.com>
  Janosch Frank <frankja@linux.ibm.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Marc Zyngier <maz@kernel.org>
  Marco Giunta <giun7a@gmail.com>
  Mark Brown <broonie@kernel.org>
  Paolo Bonzini <pbonzini@redhat.com>
  Paul Moore <paul@paul-moore.com>
  Peter Gonda <pgonda@google.com>
  Peter Rosin <peda@axentia.se>
  Peter Ujfalusi <peter.ujfalusi@gmail.com>
  Pierre-Louis Bossart <pierre-louis.bossart@linux.com>
  Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
  Quentin Perret <qperret@google.com>
  Randy Dunlap <rdunlap@infradead.org>
  Richard Fitzgerald <rf@opensource.cirrus.com>
  Sean Christopherson <seanjc@google.com>
  Shengjiu Wang <shengjiu.wang@nxp.com>
  Srinivasa Rao Mandadapu <srivasam@codeaurora.org>
  Stefan Binding <sbinding@opensource.cirrus.com>
  Steven Clarkson <sc@lambdal.com>
  Steven Rostedt (VMware) <rostedt@goodmis.org>
  Takashi Iwai <tiwai@suse.de>
  Tom Lendacky <thomas.lendacky@amd.com>
  Venkata Prasad Potturu <potturu@codeaurora.org>
  Will Deacon <will@kernel.org>
  Yang Yingliang <yangyingliang@huawei.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   d9abdee5fd5a..8e37395c3a5d  8e37395c3a5dceff62a5010ebbbc107f4145935c -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Thu Oct 21 03:43:47 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Oct 2021 03:43:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.214147.372608 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdOzU-0002TI-2w; Thu, 21 Oct 2021 03:43:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 214147.372608; Thu, 21 Oct 2021 03:43:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdOzT-0002TB-W0; Thu, 21 Oct 2021 03:43:39 +0000
Received: by outflank-mailman (input) for mailman id 214147;
 Thu, 21 Oct 2021 03:43:38 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Fl1r=PJ=oracle.com=martin.petersen@srs-us1.protection.inumbo.net>)
 id 1mdOzS-0002T5-Nv
 for xen-devel@lists.xenproject.org; Thu, 21 Oct 2021 03:43:38 +0000
Received: from mx0a-00069f02.pphosted.com (unknown [205.220.165.32])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 12d18a28-3221-11ec-8367-12813bfff9fa;
 Thu, 21 Oct 2021 03:43:37 +0000 (UTC)
Received: from pps.filterd (m0246629.ppops.net [127.0.0.1])
 by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 19L345vU029738; 
 Thu, 21 Oct 2021 03:43:10 GMT
Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71])
 by mx0b-00069f02.pphosted.com with ESMTP id 3btkwj3wvw-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Thu, 21 Oct 2021 03:43:10 +0000
Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1])
 by aserp3030.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 19L3etve078225;
 Thu, 21 Oct 2021 03:43:08 GMT
Received: from pps.reinject (localhost [127.0.0.1])
 by aserp3030.oracle.com with ESMTP id 3bqmshem6t-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Thu, 21 Oct 2021 03:43:08 +0000
Received: from aserp3030.oracle.com (aserp3030.oracle.com [127.0.0.1])
 by pps.reinject (8.16.0.36/8.16.0.36) with SMTP id 19L3gu8A082116;
 Thu, 21 Oct 2021 03:43:07 GMT
Received: from ca-mkp.mkp.ca.oracle.com (ca-mkp.ca.oracle.com [10.156.108.201])
 by aserp3030.oracle.com with ESMTP id 3bqmshekyd-13;
 Thu, 21 Oct 2021 03:43:07 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 12d18a28-3221-11ec-8367-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc :
 subject : date : message-id : in-reply-to : references : mime-version :
 content-type : content-transfer-encoding; s=corp-2021-07-09;
 bh=BSjTWby1MMCLQUchrOSGc4QoXnzcMZ91l35lRX12C+A=;
 b=s10GXTgGaX78Zmg+DOSDrfc0P0mwy8l94S/NZcyOPTkKyIMY2Y0KlCwxCAx31besDrcr
 gXfw3fEKtGCdejoVtEWUD00kuevcL/euKQ1b4LL0nm4E8CV6SIOFqCYP0rxj7RC74EVk
 e1PqokwRndi0pkrqAVruOVLwEN5l5viuqDFrINzci/HP18Znfe79FD5iVhadUThPY2uw
 odRGpVz8brO185YsW3tTaXuLihuEjMaflid8MLFI6u/8vn+luvxy/mDr7zofRsdPscVh
 mNLR9sg3Koj94WqKMhqpn6d0kreDZqZeu97CD8yHp5SK3EUYUYKj0bD7U5PsVZFWhw4s kA== 
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: zhuyifei1999@gmail.com, thehajime@gmail.com, hare@suse.de,
        jinpu.wang@ionos.com, jgross@suse.com, johannes.berg@intel.com,
        geert@linux-m68k.org, linux-mtd@lists.infradead.org,
        miquel.raynal@bootlin.com, axboe@kernel.dk,
        Luis Chamberlain <mcgrof@kernel.org>, jdike@addtoit.com,
        kent.overstreet@gmail.com, richard@nod.at, colyli@suse.de,
        agk@redhat.com, haris.iqbal@ionos.com, krisman@collabora.com,
        roger.pau@citrix.com, anton.ivanov@cambridgegreys.com,
        sstabellini@kernel.org, ulf.hansson@linaro.org, vigneshr@ti.com,
        chris.obbard@collabora.com, jejb@linux.ibm.com,
        boris.ostrovsky@oracle.com, tj@kernel.org, snitzer@redhat.com
Cc: "Martin K . Petersen" <martin.petersen@oracle.com>,
        linux-um@lists.infradead.org, linux-block@vger.kernel.org,
        xen-devel@lists.xenproject.org, linux-scsi@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org,
        dm-devel@redhat.com, linux-bcache@vger.kernel.org
Subject: Re: [PATCH 0/9] block: reviewed add_disk() error handling set
Date: Wed, 20 Oct 2021 23:42:44 -0400
Message-Id: <163478764105.7011.9400354892813636458.b4-ty@oracle.com>
X-Mailer: git-send-email 2.32.0
In-Reply-To: <20211015233028.2167651-1-mcgrof@kernel.org>
References: <20211015233028.2167651-1-mcgrof@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
X-Proofpoint-ORIG-GUID: BAR8nzodBeKYX4DEPTjC7SU079lshTb2
X-Proofpoint-GUID: BAR8nzodBeKYX4DEPTjC7SU079lshTb2

On Fri, 15 Oct 2021 16:30:19 -0700, Luis Chamberlain wrote:

> Jens,
> 
> I had last split up patches into 7 groups, but at this point now
> most changes are merged except a few more drivers. Instead of creating
> a new patch set for each of the 7 groups I'm creating 3 new groups of
> patches now:
> 
> [...]

Applied to 5.16/scsi-queue, thanks!

[1/9] scsi/sd: add error handling support for add_disk()
      https://git.kernel.org/mkp/scsi/c/2a7a891f4c40
[2/9] scsi/sr: add error handling support for add_disk()
      https://git.kernel.org/mkp/scsi/c/e9d658c2175b

-- 
Martin K. Petersen	Oracle Linux Engineering


From xen-devel-bounces@lists.xenproject.org Thu Oct 21 05:17:23 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Oct 2021 05:17:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.214157.372619 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdQRv-0002um-TC; Thu, 21 Oct 2021 05:17:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 214157.372619; Thu, 21 Oct 2021 05:17:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdQRv-0002uf-P0; Thu, 21 Oct 2021 05:17:07 +0000
Received: by outflank-mailman (input) for mailman id 214157;
 Thu, 21 Oct 2021 05:17:06 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mdQRu-0002uV-Re; Thu, 21 Oct 2021 05:17:06 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mdQRu-0000RZ-MK; Thu, 21 Oct 2021 05:17:06 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mdQRu-0002w3-CR; Thu, 21 Oct 2021 05:17:06 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mdQRu-0005Ve-BS; Thu, 21 Oct 2021 05:17:06 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=mB8V0seLGuNN+3+EQsemvSwbngJ9rQ2bsN5uD4Qc3OY=; b=5a1Ts5Qq03AnUMETKzywhMJ/YE
	S2+R32UeiJH1rWa2SfjISfQFt3S8bdWpdZQexGVQD+M9sytyujuFujIUByR5PuQDmAAw9zYvUoZwz
	qKh95OETzWJEq5E7FMvjwi4rByy4zhibIK7znXZx2pXBqfjzNSrTZfDOHwYY9AolON/0=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165694-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 165694: regressions - FAIL
X-Osstest-Failures:
    qemu-mainline:build-i386:xen-build:fail:regression
    qemu-mainline:build-i386-xsm:xen-build:fail:regression
    qemu-mainline:build-armhf:xen-build:fail:regression
    qemu-mainline:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-amd:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-pair:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-freebsd10-i386:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-freebsd10-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-coresched-i386-xl:build-check(1):blocked:nonblocking
    qemu-mainline:build-armhf-libvirt:build-check(1):blocked:nonblocking
    qemu-mainline:build-i386-libvirt:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-intel:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-shadow:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-vhd:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=afc9fcde55296b83f659de9da3cdf044812a6eeb
X-Osstest-Versions-That:
    qemuu=50352cce138ef3b30c1cda28a4df68fff5da3202
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 21 Oct 2021 05:17:06 +0000

flight 165694 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165694/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-i386                    6 xen-build                fail REGR. vs. 165682
 build-i386-xsm                6 xen-build                fail REGR. vs. 165682
 build-armhf                   6 xen-build                fail REGR. vs. 165682

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl           1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-credit2   1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-cubietruck  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-multivcpu  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-rtds      1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-vhd       1 build-check(1)               blocked  n/a
 test-amd64-i386-qemuu-rhel6hvm-amd  1 build-check(1)               blocked n/a
 test-amd64-i386-pair          1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-freebsd10-i386  1 build-check(1)               blocked  n/a
 test-amd64-i386-freebsd10-amd64  1 build-check(1)               blocked  n/a
 test-amd64-coresched-i386-xl  1 build-check(1)               blocked  n/a
 build-armhf-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-credit1   1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-arndale   1 build-check(1)               blocked  n/a
 test-amd64-i386-qemuu-rhel6hvm-intel  1 build-check(1)             blocked n/a
 test-amd64-i386-xl            1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-pvshim     1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-qemuu-debianhvm-amd64  1 build-check(1)         blocked n/a
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow  1 build-check(1)  blocked n/a
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm  1 build-check(1)      blocked n/a
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 1 build-check(1) blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a
 test-amd64-i386-xl-qemuu-win7-amd64  1 build-check(1)              blocked n/a
 test-amd64-i386-xl-qemuu-ws16-amd64  1 build-check(1)              blocked n/a
 test-amd64-i386-xl-shadow     1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-vhd        1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-xsm        1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165682
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165682
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165682
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 qemuu                afc9fcde55296b83f659de9da3cdf044812a6eeb
baseline version:
 qemuu                50352cce138ef3b30c1cda28a4df68fff5da3202

Last test of basis   165682  2021-10-19 21:09:14 Z    1 days
Testing same since   165694  2021-10-20 18:09:12 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Ani Sinha <ani@anisinha.ca>
  David Hildenbrand <david@redhat.com>
  Eric Auger <eric.auger@redhat.com>
  Eugenio Pérez <eperezma@redhat.com>
  Igor Mammedov <imammedo@redhat.com>
  Jason Wang <jasowang@redhat.com>
  Laurent Vivier <lvivier@redhat.com>
  Mathieu Poirier <mathieu.poirier@linaro.org>
  Michael S. Tsirkin <mst@redhat.com>
  Richard Henderson <richard.henderson@linaro.org>
  Stefan Hajnoczi <stefanha@redhat.com>
  Thomas Huth <thuth@redhat.com>
  Xueming Li <xuemingl@nvidia.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               fail    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          blocked 
 test-amd64-i386-xl                                           blocked 
 test-amd64-coresched-i386-xl                                 blocked 
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  blocked 
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       blocked 
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           blocked 
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     blocked 
 test-amd64-i386-freebsd10-amd64                              blocked 
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          blocked 
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          blocked 
 test-armhf-armhf-xl-arndale                                  blocked 
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  blocked 
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  blocked 
 test-armhf-armhf-xl-cubietruck                               blocked 
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         blocked 
 test-amd64-i386-freebsd10-i386                               blocked 
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         blocked 
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                blocked 
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         blocked 
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 blocked 
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    blocked 
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     blocked 
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              blocked 
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    blocked 
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      blocked 
 test-amd64-i386-xl-vhd                                       blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 1390 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Oct 21 05:45:41 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Oct 2021 05:45:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.214167.372636 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdQtS-00064U-7D; Thu, 21 Oct 2021 05:45:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 214167.372636; Thu, 21 Oct 2021 05:45:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdQtS-00064N-3t; Thu, 21 Oct 2021 05:45:34 +0000
Received: by outflank-mailman (input) for mailman id 214167;
 Thu, 21 Oct 2021 05:45:32 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=x3Oe=PJ=arm.com=Penny.Zheng@srs-us1.protection.inumbo.net>)
 id 1mdQtQ-00064H-Fl
 for xen-devel@lists.xenproject.org; Thu, 21 Oct 2021 05:45:32 +0000
Received: from EUR01-HE1-obe.outbound.protection.outlook.com (unknown
 [40.107.13.40]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 9f53fa72-e552-42f4-9bc4-81db9ef07c83;
 Thu, 21 Oct 2021 05:45:28 +0000 (UTC)
Received: from AS9PR0301CA0037.eurprd03.prod.outlook.com
 (2603:10a6:20b:469::22) by AM0PR08MB5123.eurprd08.prod.outlook.com
 (2603:10a6:208:15b::23) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.18; Thu, 21 Oct
 2021 05:45:26 +0000
Received: from VE1EUR03FT028.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:469:cafe::aa) by AS9PR0301CA0037.outlook.office365.com
 (2603:10a6:20b:469::22) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.16 via Frontend
 Transport; Thu, 21 Oct 2021 05:45:26 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT028.mail.protection.outlook.com (10.152.18.88) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4628.18 via Frontend Transport; Thu, 21 Oct 2021 05:45:25 +0000
Received: ("Tessian outbound b9598e0ead92:v103");
 Thu, 21 Oct 2021 05:45:25 +0000
Received: from e5a5c3e71a2e.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 4C221D81-6BA9-4554-8451-7F65E6A8F652.1; 
 Thu, 21 Oct 2021 05:45:18 +0000
Received: from EUR01-VE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id e5a5c3e71a2e.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Thu, 21 Oct 2021 05:45:18 +0000
Received: from VE1PR08MB5215.eurprd08.prod.outlook.com (2603:10a6:803:10a::33)
 by VE1PR08MB4893.eurprd08.prod.outlook.com (2603:10a6:802:aa::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.18; Thu, 21 Oct
 2021 05:45:15 +0000
Received: from VE1PR08MB5215.eurprd08.prod.outlook.com
 ([fe80::41d6:b115:3b22:2cd]) by VE1PR08MB5215.eurprd08.prod.outlook.com
 ([fe80::41d6:b115:3b22:2cd%2]) with mapi id 15.20.4608.018; Thu, 21 Oct 2021
 05:45:15 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9f53fa72-e552-42f4-9bc4-81db9ef07c83
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=GhAG0Wnce2japJMjUXCwacbhcWkRI+/V0HVpHBwsMY8=;
 b=IvWmGlfi29ktxM9L3rKCV2nc/W5XOapwqkA6rQah+KdR6491tT9S1IQBC5oG34LApXlCzUGsOsilBvL/gFJiqfJKE3ilD9OjbvfmjDLc/VVcwG+jvKNOIzYCRBeKRI3cgi5iOFbHTXeb2mbJTY8DcHVBb9N4tY+f7dDU7oyvrHk=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=cq/HOvoUZLalT5pWoe1qMeixSSg0XNm46LAys8IsEyYaGOMwQev4UScBre63IKucU5yMmo08+yVYGxebQHyFOJZ3tZ/4YQPtQq1k7HI3nmcOwqsVshl2NDRluRrrRlo1rTGr6Q1q/8Bo9RzCQJL8YreRjKMGIEzxbfmGMd6iq4+cGhkMmh2yw6roIs9pEv9es1q3upUx4JMU78XHAEzNHbbttAJzPJpK5VlIrUJiJrh5R7uzdTGCWt5ZmD+WdoRmwVAkLNJAwfqjhv6cOKxkQtOXQiuvh4HPzKweMFEhWoPRRHkQG6xzjaJ9fPmfRlxOABZObkX10pLR8ryokg1KWw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=GhAG0Wnce2japJMjUXCwacbhcWkRI+/V0HVpHBwsMY8=;
 b=ivu17AMnImK1dGjg1XOqHUyVM/WfKe2gg4jHCdWOfjgUhPtywoFgPepeAZED2023o7HY2GIL+83qbQRCOhhndSC6yeCLE68LdWZnfXv2/RLBISBAM2/H0EWHin+Adwt7rbIpozH75l2aMSNnwlF6oehjw7fmFRsz/MCFVI78k160PgLQoOzoilaDzAJLCpmSkdKPFwNaT1RAIAiHc4Z7RKpAYaTL6GSVX2ahf9LXrRcQehrDJoco0DLVZDuQZ9fX/QcNFrrbmJPJKBgmPZoby8d7ucPURakCNCSUNeVRcKnrLf1XeP0lEXqEogxvFjQANUPS8ATav6AmTMlIEbzhIA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=GhAG0Wnce2japJMjUXCwacbhcWkRI+/V0HVpHBwsMY8=;
 b=IvWmGlfi29ktxM9L3rKCV2nc/W5XOapwqkA6rQah+KdR6491tT9S1IQBC5oG34LApXlCzUGsOsilBvL/gFJiqfJKE3ilD9OjbvfmjDLc/VVcwG+jvKNOIzYCRBeKRI3cgi5iOFbHTXeb2mbJTY8DcHVBb9N4tY+f7dDU7oyvrHk=
From: Penny Zheng <Penny.Zheng@arm.com>
To: Julien Grall <julien@xen.org>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, "sstabellini@kernel.org"
	<sstabellini@kernel.org>
CC: Wei Chen <Wei.Chen@arm.com>, Bertrand Marquis <Bertrand.Marquis@arm.com>
Subject: RE: [PATCH v2 4/6] xen/arm: if direct-map domain use native addresses
 for GICv3
Thread-Topic: [PATCH v2 4/6] xen/arm: if direct-map domain use native
 addresses for GICv3
Thread-Index: AQHXxaM2b5or3oCA6EWvpYBdMZOCB6vc7adg
Date: Thu, 21 Oct 2021 05:45:15 +0000
Message-ID:
 <VE1PR08MB521539B40B27D53E4CA82E46F7BF9@VE1PR08MB5215.eurprd08.prod.outlook.com>
References: <20211015030945.2082898-1-penny.zheng@arm.com>
 <20211015030945.2082898-5-penny.zheng@arm.com>
 <5319596d-c2e4-de6c-237e-62f14a7695ec@xen.org>
In-Reply-To: <5319596d-c2e4-de6c-237e-62f14a7695ec@xen.org>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: D08A79FEDCB643459B858B0BC71B57C2.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: 14f64b27-d554-4e32-e74b-08d99455fb65
x-ms-traffictypediagnostic: VE1PR08MB4893:|AM0PR08MB5123:
X-Microsoft-Antispam-PRVS:
	<AM0PR08MB512343481912DFC333282ACEF7BF9@AM0PR08MB5123.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:3631;OLM:3631;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 f6QabpZdyyyorKntqJYnjdUNMIbK5Ext0UYPRfucmy/X2IZCMQICCEtFRzWubg8A+AkEJIAnqlS2XErgspfp3BVTd9qnf0iwkPKKimXUyxCpUk+rfbOOuDVZqGdXq/sWfU+9qXekC5fSuh9ZiDhF4bRYmrhFYprWqbOnI9ar3cayrNd1Zs9PWWbFVBPq2IUik2EwBM4JhtqiFC5DFYes5s0illjA+Q/9uW/VOUiXtt+szW0O+k7oiA4XJnpZ/utgFx7pose6JmeXGfwjuo761ew4j6pgoZQWSwVFaAKFT3O5LmB+IeepWCVdVCNzClYvUsAgs3uCivApH69f0D6s52nkwRNaGrT//iYQo0GK54XU1JP50aPSJdwRYEImUYkU7wlDFL1f2ELeTZ06bWWZR7dj0mDSPX+9rkLWuli0IjyEL/h31xM8GFeOJXOfh/fHhRQzTo4gneh8ILGmWmQask/64lDTgxyab62FZ1E2JANL4ChRwGxB+9FksN9Bs5z84ivA+knBFGlT/QEVlkUPdusWmcXdXp6DEjXI0c4tqglgf9cpMmhJJn3Hx5XPMY8A1pt3Wb36lt3dIBco9Yw4jzzMgG4UWrwOODKY/XphdVRCOLxWQP4T9Hl5yihxZgrOcw2OuYFol9fAFwKDpqOLgurdts2mBh2pC8eYHOJpB+mDePJV4eOC21Rd539EOS1gqL1F/1GNVUF25Eo+LyQTxQ==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR08MB5215.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(7696005)(508600001)(53546011)(5660300002)(6506007)(26005)(186003)(71200400001)(38100700002)(52536014)(33656002)(66476007)(64756008)(66446008)(66556008)(122000001)(66946007)(76116006)(9686003)(38070700005)(86362001)(2906002)(110136005)(54906003)(83380400001)(4326008)(55016002)(316002)(8676002)(8936002);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB4893
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT028.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	cb6241ea-c555-4238-e7a4-08d99455f504
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	ctkY6UsSiqY8MwKOBMv85Badq/mL1WR+jis3uhK+UltK9KYQ6QcBg2hO46OE/rwjz6VOEx01ECNViAZhcItD+D5YvMhF9eLGLf5L7DzT8DhO7nPHx64F31n3cPRNEuMUs/o4AonbEnOivHToO1RzsKYe2Yc/YLKstMmYtX7fQU30yW0/8gj5PGPxBYXDMwvvqdtIStqidgTPjGK7vreCUzJ49YMdsfnzAbcCykDVDSzhgP9Wc0c6HdAO0WivRO+d0FPzaIR0CboNxbkMk3c5vqtek++8z3YPqQgqggHfrG/oHG6H/ISrg6Y0HW+nrdg2BYrCHxpRO8t1n0LGNIn4y0V/39sQrzvZvY9fO6EQIkbQX53I5/Ka1UKfc5XRIfsN7lG12yfiIZwhCn3kH9IMsP+TmP2ioOi3cgiAADvZ3EfN+Qn9Q+Agdy9nNIOVTiteNGza6JLBZ8CG0VsbrEqV3uOZ5RJuafVKuA44LsDejQz4qEEsRo/FA3RU1ig3ABtWuSoqbbiLLGhOHYip6gaNQwojf4YmtiY059hOl2D2x6or01outG+tU9wIM6ikfJ+Q7G5pSSbTyoOFlItCOMK95mh3Ec074jrNLhj5bwYvrwONweFRmwjrSI2pSaQwNbXzWa1rPiSkCJ+tAg0NagW6pWmkHi4VVGRKasFBJZVdzPR0XDxjmUFb0Dh37wMnnjewM98Xd5b6EWhRhSfzbBiRFw==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(5660300002)(70206006)(70586007)(186003)(7696005)(54906003)(55016002)(316002)(356005)(83380400001)(2906002)(9686003)(8936002)(86362001)(53546011)(508600001)(52536014)(81166007)(47076005)(110136005)(82310400003)(336012)(33656002)(26005)(4326008)(8676002)(36860700001)(6506007);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Oct 2021 05:45:25.8957
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 14f64b27-d554-4e32-e74b-08d99455fb65
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT028.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB5123

SGkgSnVsaWVuDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogSnVsaWVu
IEdyYWxsIDxqdWxpZW5AeGVuLm9yZz4NCj4gU2VudDogV2VkbmVzZGF5LCBPY3RvYmVyIDIwLCAy
MDIxIDc6MTEgUE0NCj4gVG86IFBlbm55IFpoZW5nIDxQZW5ueS5aaGVuZ0Bhcm0uY29tPjsgeGVu
LWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnOw0KPiBzc3RhYmVsbGluaUBrZXJuZWwub3JnDQo+
IENjOiBXZWkgQ2hlbiA8V2VpLkNoZW5AYXJtLmNvbT47IEJlcnRyYW5kIE1hcnF1aXMNCj4gPEJl
cnRyYW5kLk1hcnF1aXNAYXJtLmNvbT4NCj4gU3ViamVjdDogUmU6IFtQQVRDSCB2MiA0LzZdIHhl
bi9hcm06IGlmIGRpcmVjdC1tYXAgZG9tYWluIHVzZSBuYXRpdmUNCj4gYWRkcmVzc2VzIGZvciBH
SUN2Mw0KPiANCj4gSGkgUGVubnksDQo+IA0KPiBPbiAxNS8xMC8yMDIxIDA0OjA5LCBQZW5ueSBa
aGVuZyB3cm90ZToNCj4gPiBGcm9tOiBTdGVmYW5vIFN0YWJlbGxpbmkgPHN0ZWZhbm8uc3RhYmVs
bGluaUB4aWxpbnguY29tPg0KPiA+DQo+ID4gVG9kYXkgd2UgdXNlIG5hdGl2ZSBhZGRyZXNzZXMg
dG8gbWFwIHRoZSBHSUN2MyBmb3IgRG9tMCBhbmQgZml4ZWQNCj4gPiBhZGRyZXNzZXMgZm9yIERv
bVVzLg0KPiA+DQo+ID4gVGhpcyBwYXRjaCBjaGFuZ2VzIHRoZSBiZWhhdmlvciBzbyB0aGF0IG5h
dGl2ZSBhZGRyZXNzZXMgYXJlIHVzZWQgZm9yDQo+ID4gYWxsIGRpcmVjdC1tYXAgZG9tYWlucyhp
bmNsdWRpbmcgRG9tMCkuDQo+ID4NCj4gPiBDb25zaWRlcmluZyB0aGF0IGRvbTAgbWF5IG5vdCBh
bHdheXMgYmUgZGlyZWN0bHkgbWFwcGVkIGluIHRoZSBmdXR1cmUsDQo+ID4gdGhpcyBwYXRjaCBp
bnRyb2R1Y2VzIGEgbmV3IGhlbHBlciAiaXNfZG9tYWluX3VzZV9ob3N0X2xheW91dCgpIiB0aGF0
DQo+ID4gd3JhcHMgYm90aCB0d28gY2hlY2sgImlzX2RvbWFpbl9kaXJlY3RfbWFwcGVkKGQpIHx8
DQo+IGlzX2hhcmR3YXJlX2RvbWFpbihkKSINCj4gPiBmb3IgbW9yZSBmbGV4aWJsZSB1c2VhZ2Uu
DQo+IA0KPiBUeXBvOiBzL3VzZWFnZS91c2FnZS8NCj4gDQo+ID4NCj4gPiBTaWduZWQtb2ZmLWJ5
OiBTdGVmYW5vIFN0YWJlbGxpbmkgPHN0ZWZhbm8uc3RhYmVsbGluaUB4aWxpbnguY29tPg0KPiA+
IFNpZ25lZC1vZmYtYnk6IFBlbm55IFpoZW5nIDxwZW5ueS56aGVuZ0Bhcm0uY29tPg0KPiA+IC0t
LQ0KPiA+ICAgeGVuL2FyY2gvYXJtL2RvbWFpbl9idWlsZC5jICB8IDQ2ICsrKysrKysrKysrKysr
KysrKysrKysrKysrKy0tLS0tLS0tLQ0KPiA+ICAgeGVuL2FyY2gvYXJtL3ZnaWMtdjMuYyAgICAg
ICB8IDIwICsrKysrKysrKy0tLS0tLS0NCj4gPiAgIHhlbi9pbmNsdWRlL2FzbS1hcm0vZG9tYWlu
LmggfCAgMyArKysNCj4gPiAgIDMgZmlsZXMgY2hhbmdlZCwgNTAgaW5zZXJ0aW9ucygrKSwgMTkg
ZGVsZXRpb25zKC0pDQo+ID4NCj4gPiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gvYXJtL2RvbWFpbl9i
dWlsZC5jIGIveGVuL2FyY2gvYXJtL2RvbWFpbl9idWlsZC5jDQo+ID4gaW5kZXggNmNkMDNlNGQw
Zi4uN2UwZWUwN2UwNiAxMDA2NDQNCj4gPiAtLS0gYS94ZW4vYXJjaC9hcm0vZG9tYWluX2J1aWxk
LmMNCj4gPiArKysgYi94ZW4vYXJjaC9hcm0vZG9tYWluX2J1aWxkLmMNCj4gPiBAQCAtMjI1NSwx
NiArMjI1NSwyMCBAQCBzdGF0aWMgaW50IF9faW5pdCBtYWtlX2dpY3YyX2RvbVVfbm9kZShzdHJ1
Y3QNCj4ga2VybmVsX2luZm8gKmtpbmZvKQ0KPiA+ICAgICAgIHJldHVybiByZXM7DQo+ID4gICB9
DQo+ID4NCj4gPiArI2lmZGVmIENPTkZJR19BUk1fNjQNCj4gDQo+IFRoZSBjb2RlIGJlbG93IGlz
IHNwZWNpZmljIHRvIHRoZSBHSUN2MyAoYW5kIG5vdCA2NC1iaXQpLiBTbyB0aGlzIHNob3VsZCBi
ZQ0KPiBnYXRlZCB3aXRoIENPTkZJR19HSUNWMy4NCj4gDQo+IFBlcnNvbmFsbHksIEkgd291bGQg
aGF2ZSBnYXRlZCB0aGUgY29kZSBpbiBhIHNlcGFyYXRlIHBhdGNoLiBCdXQgSSBhbSBmaW5lIGlm
DQo+IHRoaXMgaXMgYWRkZWQgaW4gdGhpcyBwYXRjaCBzbyBsb25nIHRoaXMgaXMgbWVudGlvbm5l
ZCBpbiB0aGUgY29tbWl0IG1lc3NhZ2UuDQo+IA0KPiA+ICAgc3RhdGljIGludCBfX2luaXQgbWFr
ZV9naWN2M19kb21VX25vZGUoc3RydWN0IGtlcm5lbF9pbmZvICpraW5mbykNCj4gPiAgIHsNCj4g
PiAgICAgICB2b2lkICpmZHQgPSBraW5mby0+ZmR0Ow0KPiA+ICAgICAgIGludCByZXMgPSAwOw0K
PiA+IC0gICAgX19iZTMyIHJlZ1soR1VFU1RfUk9PVF9BRERSRVNTX0NFTExTICsgR1VFU1RfUk9P
VF9TSVpFX0NFTExTKSAqDQo+IDJdOw0KPiA+ICsgICAgX19iZTMyICpyZWc7DQo+ID4gICAgICAg
X19iZTMyICpjZWxsczsNCj4gPiArICAgIHN0cnVjdCBkb21haW4gKmQgPSBraW5mby0+ZDsNCj4g
DQo+IEFGQUlDVCwgJ2QnIGlzIG5vdCBnb2luZyB0byBiZSBtb2RpZmllZC4gU28gcGxlYXNlIGFk
ZCBjb25zdC4NCj4gDQo+ID4gKyAgICBjaGFyIGJ1ZlszOF07DQo+IA0KPiBQbGVhc2UgZXhwbGFp
biBob3cgMzggd2FzIGZvdW5kLiBGb3IgYW4gZXhhbXBsZSwgc2VlIHRoZSBjb21tZW50IG9uIHRv
cCBvZg0KPiAnYnVmJyBpbiBtYWtlX21lbW9yeV9ub2RlKCkuDQo+IA0KPiA+ICsgICAgdW5zaWdu
ZWQgaW50IGksIGxlbiA9IDA7DQo+ID4NCj4gPiAtICAgIHJlcyA9IGZkdF9iZWdpbl9ub2RlKGZk
dCwgImludGVycnVwdC0NCj4gY29udHJvbGxlckAiX19zdHJpbmdpZnkoR1VFU1RfR0lDVjNfR0lD
RF9CQVNFKSk7DQo+ID4gLSAgICBpZiAoIHJlcyApDQo+ID4gLSAgICAgICAgcmV0dXJuIHJlczsN
Cj4gPiArICAgIHNucHJpbnRmKGJ1Ziwgc2l6ZW9mKGJ1ZiksICJpbnRlcnJ1cHQtY29udHJvbGxl
ckAlIlBSSXg2NCwNCj4gPiArICAgICAgICAgICAgIHZnaWNfZGlzdF9iYXNlKCZkLT5hcmNoLnZn
aWMpKTsNCj4gPiArICAgIHJlcyA9IGZkdF9iZWdpbl9ub2RlKGZkdCwgYnVmKTsNCj4gDQo+IFlv
dSBzZXQgcmVzIGJ1dCBpdCBnZXRzIG92ZXJ3cml0dGVuIGp1c3QgYmVsb3cuIFdlcmUgeW91IG1l
YW50IHRvIGNoZWNrIHRoZQ0KPiByZXR1cm4gdmFsdWU/DQo+IA0KPiA+DQo+ID4gICAgICAgcmVz
ID0gZmR0X3Byb3BlcnR5X2NlbGwoZmR0LCAiI2FkZHJlc3MtY2VsbHMiLCAwKTsNCj4gPiAgICAg
ICBpZiAoIHJlcyApDQo+ID4gQEAgLTIyODIsMzUgKzIyODYsNTUgQEAgc3RhdGljIGludCBfX2lu
aXQgbWFrZV9naWN2M19kb21VX25vZGUoc3RydWN0DQo+IGtlcm5lbF9pbmZvICpraW5mbykNCj4g
PiAgICAgICBpZiAoIHJlcyApDQo+ID4gICAgICAgICAgIHJldHVybiByZXM7DQo+ID4NCj4gPiAr
ICAgIC8qIHJlZyBzcGVjaWZpZXMgYWxsIHJlLWRpc3RyaWJ1dG9ycyBhbmQgRGlzdHJpYnV0b3Iu
ICovDQo+ID4gKyAgICBsZW4gPSAoR1VFU1RfUk9PVF9BRERSRVNTX0NFTExTICsgR1VFU1RfUk9P
VF9TSVpFX0NFTExTKSAqDQo+ID4gKyAgICAgICAgICAoZC0+YXJjaC52Z2ljLm5yX3JlZ2lvbnMg
KyAxKSAqIHNpemVvZihfX2JlMzIpOw0KPiA+ICsgICAgcmVnID0geG1hbGxvY19ieXRlcyhsZW4p
Ow0KPiA+ICsgICAgaWYgKCByZWcgPT0gTlVMTCApDQo+ID4gKyAgICAgICAgcmV0dXJuIC1FTk9N
RU07DQo+ID4gKw0KPiA+ICAgICAgIGNlbGxzID0gJnJlZ1swXTsNCj4gPiAgICAgICBkdF9jaGls
ZF9zZXRfcmFuZ2UoJmNlbGxzLCBHVUVTVF9ST09UX0FERFJFU1NfQ0VMTFMsDQo+IEdVRVNUX1JP
T1RfU0laRV9DRUxMUywNCj4gPiAtICAgICAgICAgICAgICAgICAgICAgICBHVUVTVF9HSUNWM19H
SUNEX0JBU0UsIEdVRVNUX0dJQ1YzX0dJQ0RfU0laRSk7DQo+ID4gLSAgICBkdF9jaGlsZF9zZXRf
cmFuZ2UoJmNlbGxzLCBHVUVTVF9ST09UX0FERFJFU1NfQ0VMTFMsDQo+IEdVRVNUX1JPT1RfU0la
RV9DRUxMUywNCj4gPiAtICAgICAgICAgICAgICAgICAgICAgICBHVUVTVF9HSUNWM19HSUNSMF9C
QVNFLCBHVUVTVF9HSUNWM19HSUNSMF9TSVpFKTsNCj4gPiArICAgICAgICAgICAgICAgICAgICAg
ICB2Z2ljX2Rpc3RfYmFzZSgmZC0+YXJjaC52Z2ljKSwNCj4gPiArIEdVRVNUX0dJQ1YzX0dJQ0Rf
U0laRSk7DQo+ID4NCj4gPiAtICAgIHJlcyA9IGZkdF9wcm9wZXJ0eShmZHQsICJyZWciLCByZWcs
IHNpemVvZihyZWcpKTsNCj4gPiArICAgIGZvciAoIGkgPSAwOw0KPiA+ICsgICAgICAgICAgaSA8
IGQtPmFyY2gudmdpYy5ucl9yZWdpb25zOw0KPiA+ICsgICAgICAgICAgaSsrLCBjZWxscyArPSAo
R1VFU1RfUk9PVF9BRERSRVNTX0NFTExTICsNCj4gPiArIEdVRVNUX1JPT1RfU0laRV9DRUxMUykg
KQ0KPiANCj4gZHRfY2hpbGRfc2V0X3JhbmdlKCkgd2lsbCBhbHJlYWR5IHVwZGF0ZSBjZWxscyB0
byB0aGUgbmV4dCBvbmVzLiBTbyB0aGlzIG5lZWRzDQo+IHRvIGJlIGRyb3BwZWQuDQo+IA0KDQpZ
b3UncmUgc28gcmlnaHQhISEgSSBjaGVja2VkIHRoZSBjb2RlIGFuZCBpdCB3aWxsIGFscmVhZHkg
cG9pbnRzIHRvIHRoZSBuZXh0IG9uZXMNCg0KPiBJIHdhcyBleHBlY3RpbmcgdGhpcyB0byBiZSBj
YXVndCBkdXJpbmcgdGVzdC4gU28gZGlkIHlvdSB0ZXN0IHRoaXMgc2VyaWVzIHdpdGgNCj4gR0lD
djM/IEhvdyBhYm91dCB0aGUgbmV3IHZHSUM/DQo+IA0KDQpZZXMsIEkgdGVzdCBpdCB3aXRoIGJv
dGggb24gY29yZSBBIGFuZCBSLiBJdCdzIHdvcmtpbmcgYW5kIEkgdGhpbmsgdGhhdCdzIGJlY2F1
c2UgdGhhdCB0aGUgcmVkaXN0cmlidXRvcg0KcmVnaW9uIHNpemUgaXMgYWx3YXlzIDEgaW4gbXkg
dGVzdCwgc28gLi4uDQoNCj4gPiArICAgIHsNCj4gPiArICAgICAgICBkdF9jaGlsZF9zZXRfcmFu
Z2UoJmNlbGxzLA0KPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICBHVUVTVF9ST09UX0FE
RFJFU1NfQ0VMTFMsIEdVRVNUX1JPT1RfU0laRV9DRUxMUywNCj4gPiArICAgICAgICAgICAgICAg
ICAgICAgICAgICAgZC0+YXJjaC52Z2ljLnJkaXN0X3JlZ2lvbnNbaV0uYmFzZSwNCj4gPiArICAg
ICAgICAgICAgICAgICAgICAgICAgICAgZC0+YXJjaC52Z2ljLnJkaXN0X3JlZ2lvbnNbaV0uc2l6
ZSk7DQo+ID4gKyAgICB9DQo+ID4gKw0KPiA+ICsgICAgcmVzID0gZmR0X3Byb3BlcnR5KGZkdCwg
InJlZyIsIHJlZywgbGVuKTsNCj4gDQo+IEkgd291bGQgc3VnZ2VzdCB0byBmcmVlICdyZWcnIHJp
Z2h0IGhlcmUgYXMgeW91IGRvbid0IG5lZWQgaXQgYWZ0ZXJ3YXJkcy4gVGhpcyB3aWxsDQo+IGFs
c28gcmVtb3ZlIHRoZSByZXF1aXJlbWVudCB0byBhZGQgYSAnb3V0JyBsYWJlbCBhbmQgdGhlIGFk
ZGl0aW9uIG9mICdnb3RvJy4NCj4gDQo+ID4gICAgICAgaWYgKHJlcykNCj4gPiAtICAgICAgICBy
ZXR1cm4gcmVzOw0KPiA+ICsgICAgICAgIGdvdG8gb3V0Ow0KPiA+ICAgPiAgICAgICByZXMgPSBm
ZHRfcHJvcGVydHlfY2VsbChmZHQsICJsaW51eCxwaGFuZGxlIiwga2luZm8tPnBoYW5kbGVfZ2lj
KTsNCj4gPiAgICAgICBpZiAocmVzKQ0KPiA+IC0gICAgICAgIHJldHVybiByZXM7DQo+ID4gKyAg
ICAgICAgZ290byBvdXQ7DQo+ID4NCj4gPiAgICAgICByZXMgPSBmZHRfcHJvcGVydHlfY2VsbChm
ZHQsICJwaGFuZGxlIiwga2luZm8tPnBoYW5kbGVfZ2ljKTsNCj4gPiAgICAgICBpZiAocmVzKQ0K
PiA+IC0gICAgICAgIHJldHVybiByZXM7DQo+ID4gKyAgICAgICAgZ290byBvdXQ7DQo+ID4NCj4g
PiAgICAgICByZXMgPSBmZHRfZW5kX25vZGUoZmR0KTsNCj4gPg0KPiA+ICsgb3V0Og0KPiA+ICsg
ICAgeGZyZWUocmVnKTsNCj4gPiAgICAgICByZXR1cm4gcmVzOw0KPiA+ICAgfQ0KPiA+ICsjZW5k
aWYNCj4gPg0KPiA+ICAgc3RhdGljIGludCBfX2luaXQgbWFrZV9naWNfZG9tVV9ub2RlKHN0cnVj
dCBrZXJuZWxfaW5mbyAqa2luZm8pDQo+ID4gICB7DQo+ID4gICAgICAgc3dpdGNoICgga2luZm8t
PmQtPmFyY2gudmdpYy52ZXJzaW9uICkNCj4gPiAgICAgICB7DQo+ID4gKyNpZmRlZiBDT05GSUdf
QVJNXzY0DQo+ID4gICAgICAgY2FzZSBHSUNfVjM6DQo+ID4gICAgICAgICAgIHJldHVybiBtYWtl
X2dpY3YzX2RvbVVfbm9kZShraW5mbyk7DQo+ID4gKyNlbmRpZg0KPiA+ICAgICAgIGNhc2UgR0lD
X1YyOg0KPiA+ICAgICAgICAgICByZXR1cm4gbWFrZV9naWN2Ml9kb21VX25vZGUoa2luZm8pOw0K
PiA+ICAgICAgIGRlZmF1bHQ6DQo+ID4gZGlmZiAtLWdpdCBhL3hlbi9hcmNoL2FybS92Z2ljLXYz
LmMgYi94ZW4vYXJjaC9hcm0vdmdpYy12My5jIGluZGV4DQo+ID4gY2I1YTcwYzQyZS4uNzAxNjhj
YTFhYyAxMDA2NDQNCj4gPiAtLS0gYS94ZW4vYXJjaC9hcm0vdmdpYy12My5jDQo+ID4gKysrIGIv
eGVuL2FyY2gvYXJtL3ZnaWMtdjMuYw0KPiA+IEBAIC0xNjQxLDE0ICsxNjQxLDE1IEBAIHN0YXRp
YyBpbmxpbmUgdW5zaWduZWQgaW50DQo+IHZnaWNfdjNfbWF4X3JkaXN0X2NvdW50KHN0cnVjdCBk
b21haW4gKmQpDQo+ID4gICAgICAgICogTm9ybWFsbHkgdGhlcmUgaXMgb25seSBvbmUgR0lDdjMg
cmVkaXN0cmlidXRvciByZWdpb24uDQo+ID4gICAgICAgICogVGhlIEdJQ3YzIERUIGJpbmRpbmcg
cHJvdmlzaW9ucyBmb3IgbXVsdGlwbGUgcmVnaW9ucywgc2luY2UgdGhlcmUgYXJlDQo+ID4gICAg
ICAgICogcGxhdGZvcm1zIG91dCB0aGVyZSB3aGljaCBuZWVkIHRob3NlIChtdWx0aS1zb2NrZXQg
c3lzdGVtcykuDQo+ID4gLSAgICAgKiBGb3IgRG9tMCB3ZSBoYXZlIHRvIGxpdmUgd2l0aCB0aGUg
TU1JTyBsYXlvdXQgdGhlIGhhcmR3YXJlIHByb3ZpZGVzLA0KPiA+IC0gICAgICogc28gd2UgaGF2
ZSB0byBjb3B5IHRoZSBtdWx0aXBsZSByZWdpb25zIC0gYXMgdGhlIGZpcnN0IHJlZ2lvbiBtYXkg
bm90DQo+ID4gLSAgICAgKiBwcm92aWRlIGVub3VnaCBzcGFjZSB0byBob2xkIGFsbCByZWRpc3Ry
aWJ1dG9ycyB3ZSBuZWVkLg0KPiA+ICsgICAgICogRm9yIGRpcmVjdC1tYXAgZG9tYWluKGluY2x1
ZGluZyBkb20wKSwgd2UgaGF2ZSB0byBsaXZlIHdpdGgNCj4gPiArIHRoZSBNTUlPDQo+IA0KPiBJ
IGZpbmQgdGhlIHNlbnRlbmNlIHNvbWV3aGF0IG1pc2xlYWRpbmcgYmVjYXVzZSBpdCBpbXBsaWVz
IHRoYXQgZG9tMCBpcyBpcyBhDQo+IGRpcmVjdC1tYXAgZG9tYWluICh0aGlzIGlzIHRydWUgdG9k
YXksIGJ1dCB0aGlzIG1lcmVseSBhbiBpbXBsZW1lbnRhdGlvbg0KPiBkZXRhaWxzKS4NCj4gDQo+
IEhvd2V2ZXIsIHdpdGggdGhlIGNoYW5nZSBiZWxvdywgSSB0aGluayBpdCB3b3VsZCBiZSBiZXR0
ZXIgdG8gd3JpdGUgIkZvcg0KPiBkb21haW4gdXNpbmcgdGhlIGhvc3QgbWVtb3J5IGxheW91dC4u
LiIgYW5kIG5vdCBnb2luZyBpbnRvIGRldGFpbHMgYW5kIHdoYXQNCj4gc29ydCBvZiBkb21haW4g
d2UgcmVmZXIgdG8gaGVyZS4gSW5zdGVhZC4uLg0KPiANCj4gPiArICAgICAqIGxheW91dCB0aGUg
aGFyZHdhcmUgcHJvdmlkZXMsIHNvIHdlIGhhdmUgdG8gY29weSB0aGUgbXVsdGlwbGUgcmVnaW9u
cw0KPiA+ICsgICAgICogLSBhcyB0aGUgZmlyc3QgcmVnaW9uIG1heSBub3QgcHJvdmlkZSBlbm91
Z2ggc3BhY2UgdG8gaG9sZCBhbGwNCj4gPiArICAgICAqIHJlZGlzdHJpYnV0b3JzIHdlIG5lZWQu
DQo+ID4gICAgICAgICogSG93ZXZlciBEb21VIGdldCBhIGNvbnN0cnVjdGVkIG1lbW9yeSBtYXAs
IHNvIHdlIGNhbiBnbyB3aXRoDQo+ID4gICAgICAgICogdGhlIGFyY2hpdGVjdGVkIHNpbmdsZSBy
ZWRpc3RyaWJ1dG9yIHJlZ2lvbi4NCj4gPiAgICAgICAgKi8NCj4gPiAtICAgIHJldHVybiBpc19o
YXJkd2FyZV9kb21haW4oZCkgPyB2Z2ljX3YzX2h3Lm5yX3JkaXN0X3JlZ2lvbnMgOg0KPiA+IC0g
ICAgICAgICAgICAgICBHVUVTVF9HSUNWM19SRElTVF9SRUdJT05TOw0KPiA+ICsgICAgcmV0dXJu
IGlzX2RvbWFpbl91c2VfaG9zdF9sYXlvdXQoZCkgPyB2Z2ljX3YzX2h3Lm5yX3JkaXN0X3JlZ2lv
bnMgOg0KPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBHVUVT
VF9HSUNWM19SRElTVF9SRUdJT05TOw0KPiA+ICAgfQ0KPiA+DQo+ID4gICBzdGF0aWMgaW50IHZn
aWNfdjNfZG9tYWluX2luaXQoc3RydWN0IGRvbWFpbiAqZCkgQEAgLTE2NzAsMTANCj4gPiArMTY3
MSwxMyBAQCBzdGF0aWMgaW50IHZnaWNfdjNfZG9tYWluX2luaXQoc3RydWN0IGRvbWFpbiAqZCkN
Cj4gPiAgICAgICByYWRpeF90cmVlX2luaXQoJmQtPmFyY2gudmdpYy5wZW5kX2xwaV90cmVlKTsN
Cj4gPg0KPiA+ICAgICAgIC8qDQo+ID4gLSAgICAgKiBEb21haW4gMCBnZXRzIHRoZSBoYXJkd2Fy
ZSBhZGRyZXNzLg0KPiA+IC0gICAgICogR3Vlc3RzIGdldCB0aGUgdmlydHVhbCBwbGF0Zm9ybSBs
YXlvdXQuDQo+ID4gKyAgICAgKiBTaW5jZSB3ZSBtYXAgdGhlIHdob2xlIEdJQ3YzIHJlZ2lzdGVy
IG1lbW9yeSBtYXAoNjRLQikgZm9yDQo+ID4gKyAgICAgKiBhbGwgZ3Vlc3RzKGluY2x1ZGluZyBE
T00wKSwgRE9NMCBhbmQgZGlyZWN0LW1hcCBndWVzdHMgY291bGQgYmUNCj4gPiArICAgICAqIHRy
ZWF0ZWQgdGhlIHNhbWUgd2F5IGhlcmUuDQo+ID4gKyAgICAgKiBkaXJlY3QtbWFwIGRvbWFpbiAo
aW5jbHVkaW5nIERvbTApIGdldHMgdGhlIGhhcmR3YXJlIGFkZHJlc3MuDQo+ID4gKyAgICAgKiBP
dGhlciBndWVzdHMgZ2V0IHRoZSB2aXJ0dWFsIHBsYXRmb3JtIGxheW91dC4NCj4gPiAgICAgICAg
Ki8NCj4gPiAtICAgIGlmICggaXNfaGFyZHdhcmVfZG9tYWluKGQpICkNCj4gPiArICAgIGlmICgg
aXNfZG9tYWluX3VzZV9ob3N0X2xheW91dChkKSApDQo+ID4gICAgICAgew0KPiA+ICAgICAgICAg
ICB1bnNpZ25lZCBpbnQgZmlyc3RfY3B1ID0gMDsNCj4gPg0KPiA+IGRpZmYgLS1naXQgYS94ZW4v
aW5jbHVkZS9hc20tYXJtL2RvbWFpbi5oDQo+ID4gYi94ZW4vaW5jbHVkZS9hc20tYXJtL2RvbWFp
bi5oIGluZGV4IGZjNDJjNmEzMTAuLmU4Y2UzYWM4ZDIgMTAwNjQ0DQo+ID4gLS0tIGEveGVuL2lu
Y2x1ZGUvYXNtLWFybS9kb21haW4uaA0KPiA+ICsrKyBiL3hlbi9pbmNsdWRlL2FzbS1hcm0vZG9t
YWluLmgNCj4gPiBAQCAtMzIsNiArMzIsOSBAQCBlbnVtIGRvbWFpbl90eXBlIHsNCj4gPiAgIC8q
IENoZWNrIGlmIGRvbWFpbiBpcyBkaXJlY3QtbWFwIG1lbW9yeSBtYXAuICovDQo+ID4gICAjZGVm
aW5lIGlzX2RvbWFpbl9kaXJlY3RfbWFwcGVkKGQpIChkLT5vcHRpb25zICYNCj4gPiBYRU5fRE9N
Q1RMX0NERl9kaXJlY3RtYXApDQo+ID4NCj4gPiArI2RlZmluZSBpc19kb21haW5fdXNlX2hvc3Rf
bGF5b3V0KGQpIChpc19kb21haW5fZGlyZWN0X21hcHBlZChkKSB8fCBcDQo+ID4gKyAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgaXNfaGFyZHdhcmVfZG9tYWluKGQpKQ0KPiAN
Cj4gLi4uIHRoZSBkZXRhaWxzIHNob3VsZCBiZSBvbiB0b3Agb2YgdGhpcyBjb21tZW50LiBUaGUg
YWR2YW50YWdlIGlzIHRoZXJlIGlzIGxlc3MNCj4gY2hhbmNlIGZvciBhIGNvbW1lbnQgdG8gcm90
Lg0KPiANCj4gUmVnYXJkaW5nIHRoZSBuYW1lLCBJIHdvdWxkIGVpdGhlciBkcm9wIHRoZSAnaXNf
JyBvciBzL3VzZS91c2luZy8uIE15DQo+IHByZWZlcmVuY2UgZ29lcyBmb3IgdGhlIGZvcm1lciBh
cyBpdCBtYWtlcyB0aGUgbmFtZSBzaWdodGx5IHNob3J0ZXIuDQo+IA0KPiBDaGVlcnMsDQo+IA0K
PiAtLQ0KPiBKdWxpZW4gR3JhbGwNCg==


From xen-devel-bounces@lists.xenproject.org Thu Oct 21 06:59:26 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Oct 2021 06:59:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.214177.372646 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdS2f-0004SE-EH; Thu, 21 Oct 2021 06:59:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 214177.372646; Thu, 21 Oct 2021 06:59:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdS2f-0004S7-BO; Thu, 21 Oct 2021 06:59:09 +0000
Received: by outflank-mailman (input) for mailman id 214177;
 Thu, 21 Oct 2021 06:59:08 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=fYzA=PJ=suse.com=jgross@srs-us1.protection.inumbo.net>)
 id 1mdS2e-0004S1-7k
 for xen-devel@lists.xenproject.org; Thu, 21 Oct 2021 06:59:08 +0000
Received: from smtp-out1.suse.de (unknown [195.135.220.28])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id d1b5e18f-db57-4ab7-8bad-308097fc38be;
 Thu, 21 Oct 2021 06:59:07 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 199EF21A64;
 Thu, 21 Oct 2021 06:59:05 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E1BE513B37;
 Thu, 21 Oct 2021 06:59:04 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id MYU0NLgPcWFKAwAAMHmgww
 (envelope-from <jgross@suse.com>); Thu, 21 Oct 2021 06:59:04 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d1b5e18f-db57-4ab7-8bad-308097fc38be
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1634799545; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=HbjWpCzjWIcJKTogpy6YTgiXPpoxy7yI15jOxA4GCSM=;
	b=SO00FLAQlX7eGrWC9rqgJHWALjrAdQ9qg5QpXbDRiIkSELlm9SiOqG+i3sdq+AEdTf0Y28
	4FIDYK7qodF4XOJ0dg0nxm7CbGId7XSRJ942Iwx/4I/4GSGTgofhAyZTq8BwKkfX4GIQIw
	/PfFouGbBWVUTXoww7v2JbVfUhxpILU=
Subject: Re: [PATCH for-4.16] tools/xenstored: Ignore domain we were unable to
 restore
To: Julien Grall <julien@xen.org>, xen-devel@lists.xenproject.org
Cc: Julien Grall <jgrall@amazon.com>, Ian Jackson <iwj@xenproject.org>,
 Wei Liu <wl@xen.org>
References: <20211020144519.10362-1-julien@xen.org>
From: Juergen Gross <jgross@suse.com>
Message-ID: <f2b61919-232b-fbd7-3d9f-c5426d92eae9@suse.com>
Date: Thu, 21 Oct 2021 08:59:04 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <20211020144519.10362-1-julien@xen.org>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="r6AOBOd7VKzpafIvghBhVkVtCUYXifUVn"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--r6AOBOd7VKzpafIvghBhVkVtCUYXifUVn
Content-Type: multipart/mixed; boundary="sEYsFn2pHMSGRHB680QoafDShgd64ZNeR";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Julien Grall <julien@xen.org>, xen-devel@lists.xenproject.org
Cc: Julien Grall <jgrall@amazon.com>, Ian Jackson <iwj@xenproject.org>,
 Wei Liu <wl@xen.org>
Message-ID: <f2b61919-232b-fbd7-3d9f-c5426d92eae9@suse.com>
Subject: Re: [PATCH for-4.16] tools/xenstored: Ignore domain we were unable to
 restore
References: <20211020144519.10362-1-julien@xen.org>
In-Reply-To: <20211020144519.10362-1-julien@xen.org>

--sEYsFn2pHMSGRHB680QoafDShgd64ZNeR
Content-Type: multipart/mixed;
 boundary="------------34B462F144439DFA08D01636"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------34B462F144439DFA08D01636
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 20.10.21 16:45, Julien Grall wrote:
> From: Julien Grall <jgrall@amazon.com>
>=20
> Commit 939775cfd3 "handle dying domains in live update" was meant to
> handle gracefully dying domain. However, the @releaseDomain watch
> will end up to be sent as soon as we finished to restore Xenstored
> state.
>=20
> This may be before Xen reports the domain to be dying (such as if
> the guest decided to revoke access to the xenstore page). Consequently
> daemon like xenconsoled will not clean-up the domain and it will be
> left as a zombie.
>=20
> To avoid the problem, mark the connection as ignored. This also
> requires to tweak conn_can_write() and conn_can_read() to prevent
> dereferencing a NULL pointer (the interface will not mapped).
>=20
> The check conn->is_ignored was originally added after the callbacks
> because the helpers for a socket connection may close the fd. However,
> ignore_connection() will close a socket connection directly. So it is
> fine to do the re-order.
>=20
> Signed-off-by: Julien Grall <jgrall@amazon.com>

Reviewed-by: Juergen Gross <jgross@suse.com>


Juergen

--------------34B462F144439DFA08D01636
Content-Type: application/pgp-keys;
 name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Transfer-Encoding: quoted-printable
Content-Description: OpenPGP public key
Content-Disposition: attachment;
 filename="OpenPGP_0xB0DE9DD628BF132F.asc"

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy=
cWx
w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O=
f8Z
d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y=
9bf
IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq=
G7/
377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR=
3Jv
c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA=
QIe
AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT=
hpw
dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0=
MbD
1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv=
oPH
Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v=
5QL
+qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ=
2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC=
QoL
BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr=
Wf0
teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC=
/nu
AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh=
ITT
d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm=
XBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz=
80h
SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC=
AcD
AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn=
FOX
gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1=
jnD
kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0=
N51
N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l=
otu
fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1=
tqS
EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA=
hsD
BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3=
g3O
ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5=
dM7
wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5=
D+j
LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm=
V2x
AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N=
Eaw
QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW=
nHI
s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR=
wgn
BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV=
bVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk=
pEd
IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA=
QAB
wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw=
Tbe
8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1=
vJz
Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8=
VGi
wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW=
svi
uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX=
zXs
ZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------34B462F144439DFA08D01636--

--sEYsFn2pHMSGRHB680QoafDShgd64ZNeR--

--r6AOBOd7VKzpafIvghBhVkVtCUYXifUVn
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmFxD7gFAwAAAAAACgkQsN6d1ii/Ey8c
HwgAhP+FtMOULPH4nGp3LS/lS/o45Ayj04juf32mhK22k4qxOGh8BENHWdFmfRfGwjSGjZ9izO8q
jWw7YXQlF9Pzjz4pd4fRbc6FIGY0euOC+1S2KQ55MmkjuWcvXi6dTeNRJz5pfXabw3t/prV29Wff
KecZnRp8H8hai/TlQsd8ZzciIVcZdiq+PVwlmb+4xjSBK47vRNFbS3BEPoJe+Iv7FFgz+17PpU7t
eq027MeTxUVMPDlqvcq2yADA6XHNX9fIfXU62m25Po+QvAkrKBe/NXxGOvyIZTaaCwTfy74aRjNj
ksxcZbvzpyudoUTabWSen+TgYhz/9J+ymo7FAUBorQ==
=hTuI
-----END PGP SIGNATURE-----

--r6AOBOd7VKzpafIvghBhVkVtCUYXifUVn--


From xen-devel-bounces@lists.xenproject.org Thu Oct 21 07:07:49 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Oct 2021 07:07:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.214185.372657 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdSB0-0005vv-9n; Thu, 21 Oct 2021 07:07:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 214185.372657; Thu, 21 Oct 2021 07:07:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdSB0-0005vo-6q; Thu, 21 Oct 2021 07:07:46 +0000
Received: by outflank-mailman (input) for mailman id 214185;
 Thu, 21 Oct 2021 07:07:44 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=P/Q/=PJ=arm.com=Luca.Fancellu@srs-us1.protection.inumbo.net>)
 id 1mdSAy-0005vi-Lz
 for xen-devel@lists.xenproject.org; Thu, 21 Oct 2021 07:07:44 +0000
Received: from EUR01-HE1-obe.outbound.protection.outlook.com (unknown
 [40.107.13.44]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 94d3ae36-323d-11ec-8369-12813bfff9fa;
 Thu, 21 Oct 2021 07:07:42 +0000 (UTC)
Received: from AM6PR08CA0025.eurprd08.prod.outlook.com (2603:10a6:20b:c0::13)
 by AM0PR08MB5252.eurprd08.prod.outlook.com (2603:10a6:208:15a::28)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.16; Thu, 21 Oct
 2021 07:07:38 +0000
Received: from VE1EUR03FT014.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:c0:cafe::ec) by AM6PR08CA0025.outlook.office365.com
 (2603:10a6:20b:c0::13) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.16 via Frontend
 Transport; Thu, 21 Oct 2021 07:07:38 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT014.mail.protection.outlook.com (10.152.19.38) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4628.18 via Frontend Transport; Thu, 21 Oct 2021 07:07:37 +0000
Received: ("Tessian outbound 16951d3c485e:v103");
 Thu, 21 Oct 2021 07:07:37 +0000
Received: from 24dd52e0a709.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 CAD76A13-EEE6-43E6-A517-1912708C63ED.1; 
 Thu, 21 Oct 2021 07:07:30 +0000
Received: from EUR02-AM5-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 24dd52e0a709.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Thu, 21 Oct 2021 07:07:30 +0000
Received: from PAXPR08MB6816.eurprd08.prod.outlook.com (2603:10a6:102:130::10)
 by PAXPR08MB6463.eurprd08.prod.outlook.com (2603:10a6:102:157::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.16; Thu, 21 Oct
 2021 07:07:27 +0000
Received: from PAXPR08MB6816.eurprd08.prod.outlook.com
 ([fe80::c1b4:db1c:376f:b697]) by PAXPR08MB6816.eurprd08.prod.outlook.com
 ([fe80::c1b4:db1c:376f:b697%9]) with mapi id 15.20.4628.018; Thu, 21 Oct 2021
 07:07:27 +0000
Received: from smtpclient.apple (217.140.106.52) by
 LO4P123CA0356.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18d::19) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4628.15 via Frontend Transport; Thu, 21 Oct 2021 07:07:26 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 94d3ae36-323d-11ec-8369-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=PIkQPWZwwrCJSTFe4KSt2/HnGoJQ9yChM5yBS1Qd+1s=;
 b=56lweWkeqBiqvite7O6JLH61X3k3yjhjQWy8bz+mGJrMu6o7BKTuVp9E678P6ODmtdcimrpG/tvnmRidXO9uyzPCpy61pbH+Ggeo3/ycVt06HOhlEdmreuOuezOclsql7YPtG5MbhC8aBAYYqrIRrA/GyGxBHM68p9DN0+NufH0=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 05cca4b21fa7ea3d
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ZAwww46x4F4Asy5GYP62ANIWwk5Km1ugnhYQfCL9UeWobvuoh+8jn8VTcFgSZsIC8tECLCuRtKvuN5iWdjrUYY+++FXl7snNpga21b9viQVI0nJUa4yPQp5eMDaKFT3rZe5Mw5alE5ZqnZt2GWqvvjYJIDcAJvCtECM9DHAevDSOLjdAWQkIt8AhFzKKRI5bh/C5njTyw7+/RL7yse7QMIzeMGSYxXqMhn5u4gz9VDcdFnx2JP06yvnsKnMnO3q25u2XJEjH4doNkijyjYFsTx6j2/rQSdpz4AniDOKIMqBQeq0FGsyRp5GXKrY+w0X5xYNxXBcSLVXkKZvW6zP87Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=PIkQPWZwwrCJSTFe4KSt2/HnGoJQ9yChM5yBS1Qd+1s=;
 b=cRQWvMYyXzGdRfAURP9PoYqOvu3OdLPGCmox/k8a9+Ws+5c7RMAxSE1ruSBk8wPVqWoJlieYj850Mp8SmxFmoZsM5dAurE0LE10cOIsqM9OGGnSbOse/qOqEgpu5urOQuRqSTbAvl6zVG9+HwVxSw6ZFtKQnL/H6IgAHGDgFXWYdymSm4PhE9Cd6Ar9lb5dyJHmmw0OTnHQiicyJwBrYb+cykB+K7nYyY2ddfAHddODyLGMR+/wXpN0AKC9+rcfhlXYSjEoZevmnzgbeB1EeO/Kig6W70ivFa/17NnF5DGSRGF7KZhDMql4PLmpCbxseDANoi7Ysqj6oD/tFVj+5PA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=PIkQPWZwwrCJSTFe4KSt2/HnGoJQ9yChM5yBS1Qd+1s=;
 b=56lweWkeqBiqvite7O6JLH61X3k3yjhjQWy8bz+mGJrMu6o7BKTuVp9E678P6ODmtdcimrpG/tvnmRidXO9uyzPCpy61pbH+Ggeo3/ycVt06HOhlEdmreuOuezOclsql7YPtG5MbhC8aBAYYqrIRrA/GyGxBHM68p9DN0+NufH0=
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
Content-Type: text/plain;
	charset=us-ascii
Subject: Re: [PATCH for-4.16] tools/xenstored: Ignore domain we were unable to
 restore
From: Luca Fancellu <luca.fancellu@arm.com>
In-Reply-To: <20211020144519.10362-1-julien@xen.org>
Date: Thu, 21 Oct 2021 08:07:23 +0100
Cc: Xen-devel <xen-devel@lists.xenproject.org>,
 Julien Grall <jgrall@amazon.com>,
 Ian Jackson <iwj@xenproject.org>,
 Wei Liu <wl@xen.org>,
 Juergen Gross <jgross@suse.com>
Content-Transfer-Encoding: quoted-printable
Message-Id: <01870077-5FE4-45D8-9716-B81C0A705DC0@arm.com>
References: <20211020144519.10362-1-julien@xen.org>
To: Julien Grall <julien@xen.org>
X-Mailer: Apple Mail (2.3654.120.0.1.13)
X-ClientProxiedBy: LO4P123CA0356.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:18d::19) To PAXPR08MB6816.eurprd08.prod.outlook.com
 (2603:10a6:102:130::10)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 1db8bab8-5b16-4b51-839f-08d994617704
X-MS-TrafficTypeDiagnostic: PAXPR08MB6463:|AM0PR08MB5252:
X-Microsoft-Antispam-PRVS:
	<AM0PR08MB525219D0BAC73F923F81A1D1E4BF9@AM0PR08MB5252.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 r41gfgMshH3K1D39tHT2Z4J1nBbulzoBDusrPjD+7bM3ozmTb9UP5NG9zdLzVgDctSlcTV9AE/oyUYpToby99OOXGP8nc8eZsGW/UxdLoK0347RsDlO2rRJHTAdNvgTrtzt4q8DLVy/aP3WB2d/q6g69uq6dGEEBPBbK+fiAAfcdgqm2dm9jJx7eWdTvSDLCaXxFF38874RYmI1JZm3e2nRLRf7kHqcomVpX4XZrCrQYoD0SERw8ILP1n2+K05fVJuXmNNUHhIZmMkDce6QRO3/KjOiv/RR+psSlfRzvg40ox5hg9PYmmM8PySZwWvTCirzooOQ4dlgFTV54G47cB5q65WJPMaLEgLjqeZBCoSxYEF6kkjM7zbfvxpIMQkNRPg2zCqL5zIxxQqMuoynWCEig2Yt76fP6eBk0ZFPwY2VAsbgvxnPPPjOfP0mUsFEbfM6j/GR+LiP5QejDNceBoOofSWG3O7R3BUVkYqBTpemUR4rwmIZnX2TKs/ZOP1lVI/lliNqoKD6h7FvoGE8KeuAOHZK974OTK4kpQ+GhT9DFnhOFAHbeEcr2IXNLgvLWpGthXzuO/Yuyp5Im/NAWqNZlATcjv/g1SIYfJSzOw0LlNQ99klyrsLnXWwhqxAzE/KadKZzfZ1WFxMqokQi5aKfZs/a797l861oaP0bX+pWVHvm/f6eh/OGxWmMVQJgpTsEARApZW5KsVeQiHZm02RG92dqbrUoewhZZIiL7C9s=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB6816.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(6666004)(5660300002)(316002)(54906003)(38100700002)(38350700002)(8936002)(2906002)(86362001)(6512007)(6486002)(26005)(83380400001)(6916009)(33656002)(956004)(2616005)(6506007)(186003)(52116002)(36756003)(8676002)(66946007)(53546011)(66476007)(4326008)(66556008)(44832011)(508600001)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6463
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT014.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	6a8a9768-cb17-4103-44bb-08d99461706f
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	7W3it6xYOJ1uqil3SZbPsgsMVgiApnPQxUbEIvrM2Ld7UTLToy1TXDx4JYJDrh0zQv1plX3KwpU2q2ze5TEAu/ZnMrbXOyN5jFIOZc/2Xu7dhKUxuQYz79Z1dmd3GexcoaR4+rZ1KDcKgoMKWjhpDsQv7iEb/9GLUnClkfDtBk+ab3QW88ob9PDuzo4n0S/WLz3tCV2oOd1veAE7fPvQ2wARzgXEVzy9w9xjtamHMY4B5tgJt2np+zERfGKD2E76ZjtsH+0rlcfqP299VRsZ5h2GYrVQpjFzDVtaH/tuEAmKnDQ3KqqWjrTldk/d4R9L0xt64r1e/o7DVffNrU398/YGc0DHYi9stphApqB/DjA1Gn92y7LUNw9ZA76wyDmX6f8RS+FISBhcDqDGu+GVxdZlVkNouF4JqH1H46KxvjjKJIJFwFF0xZCwf4QHHvRqNxn++mjyROSZT/VxzJrBEYNHkb2MnosGYyKIUx6mgxhYm6/PucgSwuiDhWnprhTZ023bvaqOvzwHXphMVwPf/ZbWCZZIvBNwW8ksLKOGx/R+KvmM7detIcDr+S65WSYV5mCSb+MrhOA2ps5ngNL1TVoJl1axuv84qer0npg3SCxBJ2eIVRDR5fhYDPa3MxZIsJs0Qi8URYhn+4apLhG3YW6iHnBj6zzuy1PxNiKVMn7Iy88B4QgEiabkyYyLE1AQlqOSb4PbYHNdCw0q6ycpmQ==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(6666004)(6506007)(508600001)(53546011)(5660300002)(83380400001)(82310400003)(36860700001)(54906003)(2616005)(316002)(44832011)(33656002)(4326008)(956004)(8676002)(186003)(6862004)(81166007)(70586007)(26005)(6512007)(336012)(107886003)(70206006)(6486002)(8936002)(356005)(47076005)(36756003)(86362001)(2906002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Oct 2021 07:07:37.8149
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 1db8bab8-5b16-4b51-839f-08d994617704
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT014.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB5252



> On 20 Oct 2021, at 15:45, Julien Grall <julien@xen.org> wrote:
>=20
> From: Julien Grall <jgrall@amazon.com>
>=20
> Commit 939775cfd3 "handle dying domains in live update" was meant to
> handle gracefully dying domain. However, the @releaseDomain watch
> will end up to be sent as soon as we finished to restore Xenstored
> state.
>=20
> This may be before Xen reports the domain to be dying (such as if
> the guest decided to revoke access to the xenstore page). Consequently
> daemon like xenconsoled will not clean-up the domain and it will be
> left as a zombie.
>=20
> To avoid the problem, mark the connection as ignored. This also
> requires to tweak conn_can_write() and conn_can_read() to prevent
> dereferencing a NULL pointer (the interface will not mapped).
>=20
> The check conn->is_ignored was originally added after the callbacks
> because the helpers for a socket connection may close the fd. However,
> ignore_connection() will close a socket connection directly. So it is
> fine to do the re-order.
>=20
> Signed-off-by: Julien Grall <jgrall@amazon.com>

Reviewed-by: Luca Fancellu <luca.fancellu@arm.com>

>=20
> ---
>=20
> This issue was originally found when developping commit 939775cfd3.
> Unfortunately, due to some miscommunication the wrong patch was sent
> upstream. The approach is re-using the one we discussed back then.
>=20
> This was tested by modifying Linux to revoke the Xenstore grant during
> boot. Without this patch, the domain will be left after Live-Update. Note
> that on a basic setup (only xenconsoled and xl watch @releaseDomain),
> the domain may be cleaned on the next domain shutdown/start.
>=20
> Xenstore Live-Update is so far a tech preview feature. But I would still
> like to request this patch to be included in 4.16 as this was meant to
> be part of the original work.
> ---
> tools/xenstore/xenstored_core.c   |  8 ++++----
> tools/xenstore/xenstored_core.h   |  1 +
> tools/xenstore/xenstored_domain.c | 21 ++++++++++++---------
> 3 files changed, 17 insertions(+), 13 deletions(-)
>=20
> diff --git a/tools/xenstore/xenstored_core.c b/tools/xenstore/xenstored_c=
ore.c
> index 0d4c73d6e20c..91d093a12ea6 100644
> --- a/tools/xenstore/xenstored_core.c
> +++ b/tools/xenstore/xenstored_core.c
> @@ -338,10 +338,10 @@ static int destroy_conn(void *_conn)
>=20
> static bool conn_can_read(struct connection *conn)
> {
> -	if (!conn->funcs->can_read(conn))
> +	if (conn->is_ignored)
> 		return false;
>=20
> -	if (conn->is_ignored)
> +	if (!conn->funcs->can_read(conn))
> 		return false;
>=20
> 	/*
> @@ -356,7 +356,7 @@ static bool conn_can_read(struct connection *conn)
>=20
> static bool conn_can_write(struct connection *conn)
> {
> -	return conn->funcs->can_write(conn) && !conn->is_ignored;
> +	return !conn->is_ignored && conn->funcs->can_write(conn);
> }
>=20
> /* This function returns index inside the array if succeed, -1 if fail */
> @@ -1466,7 +1466,7 @@ static struct {
>  *
>  * All watches, transactions, buffers will be freed.
>  */
> -static void ignore_connection(struct connection *conn)
> +void ignore_connection(struct connection *conn)
> {
> 	struct buffered_data *out, *tmp;
>=20
> diff --git a/tools/xenstore/xenstored_core.h b/tools/xenstore/xenstored_c=
ore.h
> index 258f6ff38279..07d861d92499 100644
> --- a/tools/xenstore/xenstored_core.h
> +++ b/tools/xenstore/xenstored_core.h
> @@ -206,6 +206,7 @@ struct node *read_node(struct connection *conn, const=
 void *ctx,
>=20
> struct connection *new_connection(const struct interface_funcs *funcs);
> struct connection *get_connection_by_id(unsigned int conn_id);
> +void ignore_connection(struct connection *conn);
> void check_store(void);
> void corrupt(struct connection *conn, const char *fmt, ...);
>=20
> diff --git a/tools/xenstore/xenstored_domain.c b/tools/xenstore/xenstored=
_domain.c
> index 47e9107c144e..d03c7d93a9e7 100644
> --- a/tools/xenstore/xenstored_domain.c
> +++ b/tools/xenstore/xenstored_domain.c
> @@ -268,14 +268,7 @@ void check_domains(void)
> 				domain->shutdown =3D true;
> 				notify =3D 1;
> 			}
> -			/*
> -			 * On Restore, we may have been unable to remap the
> -			 * interface and the port. As we don't know whether
> -			 * this was because of a dying domain, we need to
> -			 * check if the interface and port are still valid.
> -			 */
> -			if (!dominfo.dying && domain->port &&
> -			    domain->interface)
> +			if (!dominfo.dying)
> 				continue;
> 		}
> 		if (domain->conn) {
> @@ -1303,6 +1296,17 @@ void read_state_connection(const void *ctx, const =
void *state)
> 		if (!domain)
> 			barf("domain allocation error");
>=20
> +		conn =3D domain->conn;
> +
> +		/*
> +		 * We may not have been able to restore the domain (for
> +		 * instance because it revoked the Xenstore grant). We need
> +		 * to keep it around to send @releaseDomain when it is
> +		 * dead. So mark it as ignored.
> +		 */
> +		if (!domain->port || !domain->interface)
> +			ignore_connection(conn);
> +
> 		if (sc->spec.ring.tdomid !=3D DOMID_INVALID) {
> 			tdomain =3D find_or_alloc_domain(ctx,
> 						       sc->spec.ring.tdomid);
> @@ -1311,7 +1315,6 @@ void read_state_connection(const void *ctx, const v=
oid *state)
> 			talloc_reference(domain->conn, tdomain->conn);
> 			domain->conn->target =3D tdomain->conn;
> 		}
> -		conn =3D domain->conn;
> 	}
>=20
> 	conn->conn_id =3D sc->conn_id;
> --=20
> 2.32.0
>=20
>=20



From xen-devel-bounces@lists.xenproject.org Thu Oct 21 07:21:34 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Oct 2021 07:21:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.214195.372675 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdSOG-0008Bn-Jy; Thu, 21 Oct 2021 07:21:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 214195.372675; Thu, 21 Oct 2021 07:21:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdSOG-0008Bg-GC; Thu, 21 Oct 2021 07:21:28 +0000
Received: by outflank-mailman (input) for mailman id 214195;
 Thu, 21 Oct 2021 07:21:27 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=FF+c=PJ=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mdSOF-0008BZ-CC
 for xen-devel@lists.xenproject.org; Thu, 21 Oct 2021 07:21:27 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id eff57e2a-6a8c-4afc-8c76-c7c94b9db40f;
 Thu, 21 Oct 2021 07:21:25 +0000 (UTC)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2105.outbound.protection.outlook.com [104.47.17.105])
 (Using TLS) by relay.mimecast.com with ESMTP id
 de-mta-36-N8d0wgEwMiWpdfWgcq0TZA-1; Thu, 21 Oct 2021 09:21:23 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0402MB2701.eurprd04.prod.outlook.com (2603:10a6:800:af::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.17; Thu, 21 Oct
 2021 07:21:22 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::8062:d7cb:ca45:1898]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::8062:d7cb:ca45:1898%3]) with mapi id 15.20.4628.018; Thu, 21 Oct 2021
 07:21:22 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS9PR06CA0274.eurprd06.prod.outlook.com (2603:10a6:20b:45a::20) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.18 via Frontend
 Transport; Thu, 21 Oct 2021 07:21:21 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: eff57e2a-6a8c-4afc-8c76-c7c94b9db40f
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634800884;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=Lw1slAaPviNAhxywVC6Rle5kCW/8it3/45/OluvIRTU=;
	b=RZDuAWZgpVQWpaDZvWBo19c8CMMRrIG40fESjy2OayM6HLAjg1V71ISUUEhvpPA0FzzLlf
	8Y8R8ycRsllm7AflAt5EWrElvTPo3w/cX9QqBC5l87bS/JQbfjIBiV7Gho5IEXsSJlToxk
	JnddsSu+EBPIW9Pp8Ae+VRyRBvseiQU=
X-MC-Unique: N8d0wgEwMiWpdfWgcq0TZA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Ksx1CBZLf5qM0mdHuGSec3fPG5M4rwIwgThy2sAuAGOl+/pjS42Y+J6kC81Xdd647qsy4GJwrLCIYFC6BiLS9+31fa8TuHgJKRMjQmwZLArUydXCCL+IPdpMoHLiz8sTskW/Mw0xfIrJSDfB5teRLAABYVXCIIlaB6NqUbj8Th2u2MXKiUieQnVhYrOb0uWEftZM+towYsv7oBLKdqCVKmDJIWYwjZDTj5tp8GehJnrhanAUmcBGILTi8Kw//0f0dz/q4APQrXYfFSTq3GmOP/RJtY/RERh9VON+DkSGzKNnpLWtr7iy4KFAyXGWWIJ9sCFjkROsp1NC5OT52FqBhA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=nXc74orlkXJHT433PyHuiu8At67cdLtHOKJoZZ21Jvs=;
 b=VqD+z2Usrlyun+nouRkC+x8ZgsImB2aJkasw0/XxLfva7/UYgtYBjJkcR3DhV9PHBzSkg6yTCPXGT/Zlzw/EuU5kPp2DQq5D/GBMBP5kKrdUI90Qu6pbgh0kvqCKPPYV0ox9q4JOT8mo1zB3xx3dTokYqp9GPx7syTDxDcMDPrz108ESgABFy60rBtaks5VOE+aeeYvNZVWLCmX8ZX7I9ztjYCQ5j6u8MRaAl9ucFWjMaW2EqA0tR02z3MZmJqSUd2zX3HnTZJFc8/r6yF8oMVqkrRMsEBmvfrfcKLsBURd90uJY0zUEIoXcgcZOtJe0eiZ98+Y0pDZIHdO1DB4YTA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [PATCH] x86/IOMMU: mark IOMMU / intremap not in use when ACPI
 tables are missing
To: Andrew Cooper <andrew.cooper3@citrix.com>
CC: Wei Liu <wl@xen.org>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>, Paul Durrant <paul@xen.org>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <684e4a04-3ef3-46be-3302-149d5ce30177@suse.com>
 <e710cb3f-9343-f9d6-123e-287687e7bac3@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <50e25c02-e5c6-b04e-e21e-a8a1b53f087e@suse.com>
Date: Thu, 21 Oct 2021 09:21:20 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <e710cb3f-9343-f9d6-123e-287687e7bac3@citrix.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS9PR06CA0274.eurprd06.prod.outlook.com
 (2603:10a6:20b:45a::20) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 9fb65eef-87b6-48e5-8968-08d994636261
X-MS-TrafficTypeDiagnostic: VI1PR0402MB2701:
X-Microsoft-Antispam-PRVS:
	<VI1PR0402MB27014A9D6552BB0DF0B652DAB3BF9@VI1PR0402MB2701.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	nnfp9RLbs/BOv9cB77H9yckB4OL8B/+XhMD42L8sYLVLj3A+9IUC1QlZ/kaxiGI6+EUJ30RPLVtUifgMZ3VsmZ6H7njVrYlGTdlLd+7gCd6M4dhquK9/miiMB5uKBq1YkMY8+pj+Iq7K3j/Vb4rkjeF9CarN3K321wVyE4rKZ9s96CHXbiJJ/th1aAvX9LtjbdIrbnvfwA/7W2sO/TVSiDz6CghIBhx2rXIZqd9RVh1uXa4aS4qrN5vfnPVxBE+FmguxFKnxFh16iYTMp2+K7ZurKOrO5WEnhjoraDLk9Mkf4ot2N21eu7rJ50Gxkpa/8kdVMAZFmtolfoJyuQ8X0ocbQSfHGQachtN4U2GR0ho0fIZ7Wj+YJciLM8ovmpsvPxXPyFxoreiCMvt8erxyd1sRHeFP7Z9rjTKM4RzS95Bq9L92M46Ywf/oj5QuVz3QALXSICe9N+R+riG5vrlr0vlIcx1r/sQt51OuA/q0Tprqr7nLaacLcgsggHYl1r5LbnBbypYq1ClcNKi7EYKkpDNkNYLEcsJalTjboAsiqBo8/hOF1PC9bo45oBN+2s3bInu7oIJB95UoquwAEv7N/z88qnrTxILhgnIf0QuQQuIUuSQ1K1fPA9NgdtTP2n2hSOsu7wORfo5AvlFP6sVYWyA7Dat0rZk2VwiHt3DKSXbsDBaV5TztN5lvtmk8CVvjT5zyuxOT3o4HbSvYSLDUn1gZHmJWfh5iN7TH1nLOGZM=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(83380400001)(31686004)(53546011)(956004)(5660300002)(36756003)(2906002)(54906003)(66946007)(2616005)(508600001)(8676002)(31696002)(86362001)(316002)(6486002)(8936002)(26005)(38100700002)(6916009)(4326008)(186003)(16576012)(66476007)(66556008)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?KXufCOEqCicmRcJh9fiNFOnDimzSY4yktO0hZPG9MX213B92NGH8LZxL5IBu?=
 =?us-ascii?Q?ZsAkkLnza1wQoM8kdORxcPeYP1QKTZW/CSMlVtjTquYiNftt69TeDjra0MCH?=
 =?us-ascii?Q?EVw5htyK3sgjhnc0qzcEjevf3k0VLjNrO9i3QfuBNstZMH3rsPbbW6eNPgPa?=
 =?us-ascii?Q?O36VjFDGOweBOpIfA4W/YCHz9cpzD0s3nFZKKztUbr0rTuSI2TbOUfc9pqNv?=
 =?us-ascii?Q?zQ69Awz9aDeHAnrzOpnv2IP5wgBh+fdVDBiYiDpjMlW1LvXt2EmkZZj755tb?=
 =?us-ascii?Q?EU0iXLWoztT/Req5cD2gl2JobgqmpZmveppMwJPbCoq6vKcRvP/fNyopr42r?=
 =?us-ascii?Q?KWV+GDqXxn+8fvi9+PqbWdPpfXIEGFDPO13nOPaNAsZWwDQvTcbnl856rgjZ?=
 =?us-ascii?Q?z7XBD/Vaxv/OqqGt9MKpCgmRBylW7vqVfNpCGVwGuLooSW9jKAlQ41QtM+w0?=
 =?us-ascii?Q?ctY04x18Op339wmo4po/sJ14vccs4YSdp9zx0YyCa8CvjLdx0DsJCETl84eq?=
 =?us-ascii?Q?dfyk+2N0SJfWIMqo+9KRuRv6IW4DxyWeysuIjHmmbqT2JSFz/zqinHjyy4ED?=
 =?us-ascii?Q?0Bsm15sij2wbQ63N13U8IpBBvod8xznNuxjiGbc1ZWJDPjvBrbgh3HIZzuxb?=
 =?us-ascii?Q?nDWrwy2rCM8TQXJ1YdQQLZ+nAgwz1aJzuY4EZgoEHpyR1WUh90+geaRD/gFi?=
 =?us-ascii?Q?+QIKOSVOOwPwZ4SaizJbTRJxlSmeUgj9l/xi6FiKX912SmZA5rj1gS2xof+N?=
 =?us-ascii?Q?yMjBtihmMtIYBTOXPk5kM/iNpMD70nib/syf6Sxy+bUgwrfSoeuEdL8qZScj?=
 =?us-ascii?Q?k8m9vQWD486s/FMLzlSxyIiOd/JQUPV9DnBPJ9Ci1L73L8KEKG+uszERE7xB?=
 =?us-ascii?Q?10no1qPyYttil5sJqTkUCGsCTghOBH+ybcXO6OY83v912xNraR/URvghJaz2?=
 =?us-ascii?Q?YkZMM7s1FkciNy3BzcI6HXj2h3nqTS+0SPkFMKEbDLtkZMVJ0Vt9BO1jCW5C?=
 =?us-ascii?Q?1+NH56Wl67ByrCUFUj29vh/T8e90Fh1puKirGxozDmpXVACf2UVTsSBpAZtv?=
 =?us-ascii?Q?JOsMCdVPKmHXiL68Pgc03VsaPkJhJcpKnObxkbgEar4K5FljdguSy3bbwNBv?=
 =?us-ascii?Q?Nnn6WWRWv3nmLYjfsOzRhjIoMagcYt7VY8iLbkkCrKveDbTrnmmSrXzN65tw?=
 =?us-ascii?Q?feLMUNxCVWo5T45suc4uS4Jzz+u/1XTw5qX3B/A1rLJ9MsGYZgGyYMH7wgWE?=
 =?us-ascii?Q?AwMA8atM5RP0e5hTYi2alJadSAdmJBlAOXWh8t0BRSe/DCicHmVrHTDj0ai8?=
 =?us-ascii?Q?K5N2A3lrJ2u5+FwZS6MoVI0h?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9fb65eef-87b6-48e5-8968-08d994636261
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Oct 2021 07:21:22.4007
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jbeulich@suse.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB2701

On 20.10.2021 22:01, Andrew Cooper wrote:
> On 20/10/2021 11:36, Jan Beulich wrote:
>> x2apic_bsp_setup() gets called ahead of iommu_setup(), and since x2APIC
>> mode (physical vs clustered) depends on iommu_intremap, that variable
>> needs to be set to off as soon as we know we can't / won't enable the
>> IOMMU, i.e. in particular when
>> - parsing of the respective ACPI tables failed,
>> - "iommu=3Doff" is in effect, but not "iommu=3Dno-intremap".
>> Move the turning off of iommu_intremap from AMD specific code into
>> acpi_iommu_init(), accompanying it by clearing of iommu_enable.
>>
>> Take the opportunity and also skip ACPI table parsing altogether when
>> "iommu=3Doff" is in effect anyway.
>>
>> Reported-by: Andrew Cooper <andrew.cooper3@citrix.com>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>> ---
>> I've deliberately not added a Fixes: tag here, as I'm of the opinion
>> that d8bd82327b0f ("AMD/IOMMU: obtain IVHD type to use earlier") only
>> uncovered a pre-existing anomaly.
>=20
> I agree it uncovered a pre-existing issue, but that doesn't mean a Fixes
> tag should be omitted.=C2=A0 That change very concretely regressed bootin=
g on
> some systems in their pre-existing configuration.
>=20
> The commit message needs to spell out a link to d8bd82327b0f, but it's
> fine to say "that commit broke it by violating an unexpected ordering
> dependency, but isn't really the source of the bug".
>=20
>> This particularly applies to the "iommu=3Doff" aspect.
>=20
> There should be at least two Fixes tags, but I suspect trying to trace
> the history of this mess is not a productive use of time.
>=20
>>  (This now allows me to remove an item from my TODO
>> list: I was meaning to figure out why one of my systems wouldn't come
>> up properly with "iommu=3Doff", and I had never thought of combining thi=
s
>> with "no-intremap".)
>>
>> Arguably "iommu=3Doff" should turn off subordinate features in common
>> IOMMU code, but doing so in parse_iommu_param() would be wrong (as
>> there might be multiple "iommu=3D" to parse). This could be placed in
>> iommu_supports_x2apic(), but see the next item.
>=20
> I don't think we make any claim or implication that passing the same
> option twice works.=C2=A0 The problem here is the nested structure of
> options, and the variable doing double duty.
>=20
>>
>> While the change here deals with apic_x2apic_probe() as called from
>> x2apic_bsp_setup(), the check_x2apic_preenabled() path looks to be
>> similarly affected. That call occurs before acpi_boot_init(), which is
>> what calls acpi_iommu_init(). The ordering in setup.c is in part
>> relatively fragile, which is why for the moment I'm still hesitant to
>> move the generic_apic_probe() call down. Plus I don't have easy access
>> to a suitable system to test this case. Thoughts?
>=20
> I've written these thoughts before, but IOMMU handling it a catastrophic
> mess.=C2=A0 It needs burning to the ground and redoing from scratch.
>=20
> We currently have two ways of turning on the IOMMU, depending on what
> firmware does, and plenty ways of crashing Xen with cmdline options
> which should work, and the legacy xAPIC startup routine is after
> interrupts have been enabled, leading to an attempt to rewrite
> interrupts in place to remap them.=C2=A0 This in particular has lead to X=
SAs
> due to trusting registers which can't be trusted, and the rewrite is
> impossible to do safely.
>=20
> The correct order is:
> 1) Parse DMAR/IVRS (but do not configure anything), MADT, current APIC
> setting and cmdline arguments
> 2) Figure out whether we want to be in xAPIC or x2APIC mode, and whether
> we need intremap.=C2=A0 Change the LAPIC setting
> 3) Configure the IOMMUs.=C2=A0 In particular, their interrupt needs to be
> after step 2

Leaving aside check_x2apic_preenabled(), all of this is already the
case afaict, almost at least: We do acpi_boot_init(), later
x2apic_bsp_setup(), and yet later iommu_setup(). The only issue might
be inside x2apic_bsp_setup(), where we call iommu_enable_x2apic()
before switching to x2APIC mode. Yet we avoid setting up IOMMU
interrupts during this early stage.

Hence I think, as expressed, that the question really is whether we
can safely defer check_x2apic_preenabled() by a little bit.

> 4) Start up Xen's general IRQ infrastructure.
>=20
> It's a fair chunk of work, but it will vastly simplify the boot logic
> and let us delete the infinite flushing loops out of the IOMMU logic,
> and we don't need any logic which has to second guess itself based on
> what happened earlier on boot.
>=20
>> --- a/xen/drivers/passthrough/x86/iommu.c
>> +++ b/xen/drivers/passthrough/x86/iommu.c
>> @@ -41,6 +41,23 @@ enum iommu_intremap __read_mostly iommu_
>>  bool __read_mostly iommu_intpost;
>>  #endif
>> =20
>> +void __init acpi_iommu_init(void)
>> +{
>> +    if ( iommu_enable )
>> +    {
>> +        int ret =3D acpi_dmar_init();
>> +
>> +        if ( ret =3D=3D -ENODEV )
>> +            ret =3D acpi_ivrs_init();
>> +
>> +        if ( ret )
>> +            iommu_enable =3D false;
>> +    }
>> +
>> +    if ( !iommu_enable )
>> +        iommu_intremap =3D iommu_intremap_off;
>> +}
>=20
> This does fix my issue, so preferably with the Fixes tag reinstated,
>=20
> Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
> Tested-by: Andrew Cooper <andrew.cooper3@citrix.com>

Thanks, but I think there will need to be a v2, as per below (plus
possibly the dealing with check_x2apic_preenabled()).

> However, I don't think skipping parsing is a sensible move.=C2=A0 Intrema=
p is
> utterly mandatory if during boot, we discover that our APIC ID is >254,
> and iommu=3Dno-intremap must be ignored in this case, or if the MADT says
> we have CPUs beyond that limit and the user hasn't specified nr_cpus=3D1
> or equivalent.

Reading this made me realize that the change breaks other behavior.
The conditional really needs to be iommu_enable || iommu_intremap -
at least AMD code added in support for x2APIC already treats the
latter to not be a sub-option of the former (iov_supports_xt(),
acpi_ivrs_init()), and e.g. intel_iommu_supports_eim() also checks
the latter alone.

Overriding "iommu=3Dno-intremap" in case it's unavoidable could then
be a later change, not further affecting the function here.

Jan



From xen-devel-bounces@lists.xenproject.org Thu Oct 21 07:37:39 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Oct 2021 07:37:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.214205.372685 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdSdo-0001KS-4m; Thu, 21 Oct 2021 07:37:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 214205.372685; Thu, 21 Oct 2021 07:37:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdSdo-0001KL-1d; Thu, 21 Oct 2021 07:37:32 +0000
Received: by outflank-mailman (input) for mailman id 214205;
 Thu, 21 Oct 2021 07:37:30 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=FF+c=PJ=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mdSdm-0001KF-DF
 for xen-devel@lists.xenproject.org; Thu, 21 Oct 2021 07:37:30 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id be089830-3241-11ec-836a-12813bfff9fa;
 Thu, 21 Oct 2021 07:37:29 +0000 (UTC)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2058.outbound.protection.outlook.com [104.47.14.58]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-13-PNfUmATON7Sorso3cQxCJw-1; Thu, 21 Oct 2021 09:37:26 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0402MB3536.eurprd04.prod.outlook.com (2603:10a6:803:2::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15; Thu, 21 Oct
 2021 07:37:25 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::8062:d7cb:ca45:1898]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::8062:d7cb:ca45:1898%3]) with mapi id 15.20.4628.018; Thu, 21 Oct 2021
 07:37:25 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS9PR06CA0276.eurprd06.prod.outlook.com (2603:10a6:20b:45a::34) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16 via Frontend
 Transport; Thu, 21 Oct 2021 07:37:25 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: be089830-3241-11ec-836a-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634801848;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=USQ7yNUiDGlLiTzN8f3dMUwHzw8OTMUEoe7iirHHcZo=;
	b=U460inu1ewtMBreohvntRZ5XGVIPsY30/UypGnjsM7dwGgMH+H7zgxF//eZYc/oHvFco6o
	UUlvh8fCpMHzkuTcIf7WdWpImKGlNF2SAN6ccj1kitXjFPxthF42Z/gNRPsNFh06txixH8
	mPg3/OdoHyCYd5OnG9b8kY6dgZtpV2c=
X-MC-Unique: PNfUmATON7Sorso3cQxCJw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=VUcEP8TT0Q1ynyvnpA4BGMQu61yVQwAQHiw/zLn38YSoNU5czz0oOZEBo2gq+kBNp9G91g3A38jpw082PKFGWmeiBMZyzEy9T4KQ2aPF28wzfpLYs89Ibb4Hl81/x2XosrOhGINV0t480aatdlpawRiz/yY3HkR4qCxhNGwoptcR77QtKXyyPSI8/P18aPOgxIfyqPEZr4BRL98+YdLYJjyf40NvE4uT9YofCyZkSFjs+QohYng/SnXombzyd3r0yqTpH4itSqqqZrKsvMUU5zB0pNhw258VE6ZpPo7s6GU5iHFdv8olE1VNjdGRteMox5JXoQcq+TFj2FEcAJRYJw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=0gEpTw3//89MXNDe64M3tf+KTQ7BkEXPlF92RZax728=;
 b=KPvvDpT/L3pKaYlo0Rw6XQhkNcLv8X5rm7D+NSqiQpAAAPRBb2COwJ9uXK/NZPzDfiNBQfSo8fT6Kb+mhnHDVdQXogisFIp1Nz9d1m22wJzOUhI65Y/bGVTmSubzL9VLGRHRocFAG+gexULBNfrv+28Rf+LG5yC6kpvDkzWR3NbToMv/uwhHZIY2EvwMdn8AMzPiodnOOjI1NBVPCZM+hjoafVNhIozUduyGIfp5tks1Mv1Zylib22N1Kb7cGVU3fOkgnu6Z7RSk15CKeCt5WIKTe3Bu+XH1WWyWRODHdszWDHtS9LXEgaGHp6AMCfUOdTH8nJvh60fP4GEdPq52AQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [PATCH] x86/IOMMU: mark IOMMU / intremap not in use when ACPI
 tables are missing
From: Jan Beulich <jbeulich@suse.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
CC: Wei Liu <wl@xen.org>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>, Paul Durrant <paul@xen.org>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <684e4a04-3ef3-46be-3302-149d5ce30177@suse.com>
 <e710cb3f-9343-f9d6-123e-287687e7bac3@citrix.com>
 <50e25c02-e5c6-b04e-e21e-a8a1b53f087e@suse.com>
Message-ID: <c13f3387-92fd-e334-ce14-57ae29dcfb5b@suse.com>
Date: Thu, 21 Oct 2021 09:37:23 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <50e25c02-e5c6-b04e-e21e-a8a1b53f087e@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS9PR06CA0276.eurprd06.prod.outlook.com
 (2603:10a6:20b:45a::34) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: dd157a25-ab56-49f2-463a-08d99465a095
X-MS-TrafficTypeDiagnostic: VI1PR0402MB3536:
X-Microsoft-Antispam-PRVS:
	<VI1PR0402MB35367A0365294D9E02D63578B3BF9@VI1PR0402MB3536.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	IYRbuqdYfU3E+9Mr4hHukRL/owte1GfhIDHdaQ4Nt0xuoitejbsoHXALBuQCV8PLOq7Al+45fQOz3IFNj1xseWamZ8ujImSCPeB102q4IV+3+t9XK+eEMzRXLYe03yyJvQt48SBtHly+9eBbgsjr6xsbNakDV3bBQCUexCKCb4zwQkU6HjDUGrt/qvulGSCQdwEedy6Q+NFCB3gFVwNZow5UD09L9NG6SVLtsTZbDef93915o40KNlGRpMAnPgL8hwG8V+nkD2Tv/wloSc4ckU3kc8jFT4EXgygk2s7T3CigrWpjyBqlpH8tzeSZkJROL+Yvpscloxp2sfltQaI+og0JQEXr+PjaisWcyCVgoQZF22R52qqHIoKuGVMHrcvw38UdzwaWF7uEZgd0IsKf6A1etCcqRyi/1FEwlbWdDXzka3/Wm9Ioj7kB8FfDUJHcvjB2HW7C7CUsLcnFlcwpcMulM+JhuMXYARlyBAeIditrBNN961tSTA5IZT+XLwMZKI4cGEQLOV+i+nIpsjVXCe4ueC8HcTPFEaOQkkabeslh8CEauAVfw5Ssahjy5sqgh1kFz7uwnC37P8XtDnlMB/CIyfaQi5oGw4AyyFIJWjm4o+ZSjzxvAuqcfA2gGAoC3OzmCNIw2f368dHYh3cTNwfI7I8Z2eaxCXmXpyJFXUFKjMe8EDjvSl4eAwx1hkuOp1L2PyNMEJKwoe6EFCoPAZGgpi77FFRKJWqS0HQQ1+I=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(316002)(2906002)(4744005)(4326008)(508600001)(5660300002)(53546011)(36756003)(186003)(8676002)(31696002)(26005)(66946007)(66476007)(6486002)(8936002)(66556008)(86362001)(6916009)(956004)(16576012)(31686004)(83380400001)(2616005)(54906003)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?Wly2wVkDS+nEI3t8UOp0n2oJxfTZ50SCBbnMrPdm6xYdR8f+MjZuVlQyCrCl?=
 =?us-ascii?Q?5LdraNd+/llR5tvtTkT993JK3S8MSKSGFqoWXth7K8uSLlRDvKgbmAml+wUi?=
 =?us-ascii?Q?Nu5JfOicjL6LHK/gc1L0zDuISWIFjBIrb/ywRHX+OFkvF1mkkxI7Im/RKiVz?=
 =?us-ascii?Q?aUcg+2Y7rL2sq5wskq6TW00hysELYGKJPRZlqM29yZIKc6PvEI64BvCtJ7my?=
 =?us-ascii?Q?4KU6zAbNWu+rDNB7JW8CqoiNrtpkSeSwj228tn/qZ640RUIVS2IH1hb49Da9?=
 =?us-ascii?Q?93bv6Fo0hvnlNr1R6CiYb5LNm2WQ1VuNORVuRujxlYX50u84PRmsPF+Xs1Q1?=
 =?us-ascii?Q?aCSrGlPGHVEhLeaGkbmECujLymMGhoWgdZMADQGGXxnio6hsPlU9OBB/+HwJ?=
 =?us-ascii?Q?XzHnST519fs32iMc2Xk4aG3C2UF7evxxHQeDiVN4D5BdpcWqtwBSfAPDkcoS?=
 =?us-ascii?Q?ZUPALE6LaGO7aioNG/jhzD9zYiqs+tGHCP7yepp3Hoex8cjM2GutSvjDB+wH?=
 =?us-ascii?Q?DwyfCTbku/3+O3wNNfviGB997Mja4z3lORmo4/HlCcjnt1mStfyhWUWQQa/o?=
 =?us-ascii?Q?JvGFuLtvLfpi90+0maFoK4fzj6xGQk490OlaKV1K+ex/29wx5/BfVcnaCfz8?=
 =?us-ascii?Q?18PbPCNh7u7O7f9Z4LpMfhJLcwaBIgxXIKVOPizDtpL5kzABykY5zU0JvnjE?=
 =?us-ascii?Q?QUTj0KUeW8l+YZV8IgtfR/2jrfmBsIUQYTV9olYtw0qQewJ6/o101KajSSz5?=
 =?us-ascii?Q?jEEC6mHqeXPKBBy+mFsFTd+8ezKcSKHcJmYuLFGeOPgNmgP2+Uw2wacGJX8R?=
 =?us-ascii?Q?QuazAOpDaHghzRPB3uQG1wUjQBOVLymfUvCxx8KEJ7qbJgfuJK3LB716/Tiq?=
 =?us-ascii?Q?sqqZNJelxMeVqJYP3i7EDdTxLuB2M5PmkusL11nA/KciWOPkCmCjkYPIwMxb?=
 =?us-ascii?Q?vCg5v8GOP9TWUbMfRWm4yrczDzTZpUAiwAqzDoOjANgwa6PlSAS97inKaMEo?=
 =?us-ascii?Q?UmBvIUqtKOsQsw/PRaN4M1KKlK3uRoEpKCuh4Pmy9fVSfcMu4MkQOI+XCLIY?=
 =?us-ascii?Q?NIlwpSEDT6zgfdIEAA191HkxTnki6aWiBtE4aeWswhSq2CCpY04UHtTzeM7E?=
 =?us-ascii?Q?4zc8du9kWPfmwU9xTrdENNq9++imfMZrrX3sPAtinavt/a3jDl8a6aj5a4EL?=
 =?us-ascii?Q?+AvC3aWgfMRbdbbhIJmsctoq8aCtj3RK8lvN0kWiXiQa8lTcrTErbiligp8+?=
 =?us-ascii?Q?6ESY9VUttOyc8vLVlr4JSD+pKVbMZsnGK/fhe2Mhv05vb996kvU1RGSM+SNx?=
 =?us-ascii?Q?kqMhob5InMRanIyXn59C+VOP?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: dd157a25-ab56-49f2-463a-08d99465a095
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Oct 2021 07:37:25.7590
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jbeulich@suse.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3536

On 21.10.2021 09:21, Jan Beulich wrote:
> On 20.10.2021 22:01, Andrew Cooper wrote:
>> However, I don't think skipping parsing is a sensible move.=C2=A0 Intrem=
ap is
>> utterly mandatory if during boot, we discover that our APIC ID is >254,
>> and iommu=3Dno-intremap must be ignored in this case, or if the MADT say=
s
>> we have CPUs beyond that limit and the user hasn't specified nr_cpus=3D1
>> or equivalent.
>=20
> Reading this made me realize that the change breaks other behavior.
> The conditional really needs to be iommu_enable || iommu_intremap -
> at least AMD code added in support for x2APIC already treats the
> latter to not be a sub-option of the former (iov_supports_xt(),
> acpi_ivrs_init()), and e.g. intel_iommu_supports_eim() also checks
> the latter alone.

Actually the check in iov_supports_xt() is wrong - it needs to use
&&, not ||. I'll make a 2nd patch ...

Jan



From xen-devel-bounces@lists.xenproject.org Thu Oct 21 08:26:29 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Oct 2021 08:26:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.214218.372702 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdTOo-0006kH-6o; Thu, 21 Oct 2021 08:26:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 214218.372702; Thu, 21 Oct 2021 08:26:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdTOo-0006kA-3Y; Thu, 21 Oct 2021 08:26:06 +0000
Received: by outflank-mailman (input) for mailman id 214218;
 Thu, 21 Oct 2021 08:26:04 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=XHvE=PJ=oderland.se=josef@srs-us1.protection.inumbo.net>)
 id 1mdTOm-0006k4-Su
 for xen-devel@lists.xenproject.org; Thu, 21 Oct 2021 08:26:04 +0000
Received: from office.oderland.com (unknown [91.201.60.5])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id daa58e05-6e5b-4d7f-9d8f-cc956d2f90a8;
 Thu, 21 Oct 2021 08:26:02 +0000 (UTC)
Received: from [193.180.18.161] (port=58520 helo=[10.137.0.14])
 by office.oderland.com with esmtpsa (TLS1.2) tls
 TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2)
 (envelope-from <josef@oderland.se>)
 id 1mdTOj-000PeQ-Go; Thu, 21 Oct 2021 10:26:01 +0200
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: daa58e05-6e5b-4d7f-9d8f-cc956d2f90a8
Message-ID: <3434cb2d-4060-7969-d4c4-089c68190527@oderland.se>
Date: Thu, 21 Oct 2021 10:25:59 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:93.0) Gecko/20100101
 Thunderbird/93.0
Subject: Re: [PATCH v2] PCI/MSI: Re-add checks for skip masking MSI-X on Xen
 PV
Content-Language: en-US
To: Marc Zyngier <maz@kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>, linux-pci@vger.kernel.org,
 xen-devel <xen-devel@lists.xenproject.org>,
 Thomas Gleixner <tglx@linutronix.de>, Juergen Gross <jgross@suse.com>,
 Boris Ostrovsky <boris.ostrovsky@oracle.com>,
 Jason Andryuk <jandryuk@gmail.com>
References: <20211019202906.GA2397931@bhelgaas>
 <5f050b30-fa1c-8387-0d6b-a667851b34b0@oderland.se>
 <877de7dfl2.wl-maz@kernel.org>
 <CAKf6xpt=ZYGyJXMwM7ccOWkx71R0O-QeLjkBF-LtdDcbSnzHsA@mail.gmail.com>
From: Josef Johansson <josef@oderland.se>
In-Reply-To: <CAKf6xpt=ZYGyJXMwM7ccOWkx71R0O-QeLjkBF-LtdDcbSnzHsA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-AntiAbuse: This header was added to track abuse, please include it with any abuse report
X-AntiAbuse: Primary Hostname - office.oderland.com
X-AntiAbuse: Original Domain - lists.xenproject.org
X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12]
X-AntiAbuse: Sender Address Domain - oderland.se
X-Get-Message-Sender-Via: office.oderland.com: authenticated_id: josjoh@oderland.se
X-Authenticated-Sender: office.oderland.com: josjoh@oderland.se

On 10/20/21 16:03, Jason Andryuk wrote:
> Hi, Marc,
>
> Adding Juergen and Boris since this involves Xen.
>
> On Wed, Oct 20, 2021 at 8:51 AM Marc Zyngier <maz@kernel.org> wrote:
>> On Tue, 19 Oct 2021 22:48:19 +0100,
>> Josef Johansson <josef@oderland.se> wrote:
>>> From: Josef Johansson <josef@oderland.se>
>>>
>>>
>>> PCI/MSI: Re-add checks for skip masking MSI-X on Xen PV
>>>
>>> commit fcacdfbef5a1 ("PCI/MSI: Provide a new set of mask and unmask
>>> functions") introduce functions pci_msi_update_mask() and
>>> pci_msix_write_vector_ctrl() that is missing checks for
>>> pci_msi_ignore_mask that exists in commit 446a98b19fd6 ("PCI/MSI: Use
>>> new mask/unmask functions"). Add them back since it is
>>> causing severe lockups in amdgpu drivers under Xen during boot.
>>>
>>> As explained in commit 1a519dc7a73c ("PCI/MSI: Skip masking MSI-X
>>> on Xen PV"), when running as Xen PV guest, masking MSI-X is a
>>> responsibility of the hypervisor.
>>>
>>> Fixes: fcacdfbef5a1 ("PCI/MSI: Provide a new set of mask and unmask
>>> functions")
>>> Suggested-by: Jason Andryuk <jandryuk@gmail.com>
>>> Signed-off-by: Josef Johansson <josef@oderland.se>
>>>
>> [...]
>>
>>> diff --git a/drivers/pci/msi.c b/drivers/pci/msi.c
>>> index 0099a00af361..355b791e382f 100644
>>> --- a/drivers/pci/msi.c
>>> +++ b/drivers/pci/msi.c
>>> @@ -148,6 +148,9 @@ static noinline void pci_msi_update_mask(struct msi_desc *desc, u32 clear, u32 s
>>>       raw_spinlock_t *lock = &desc->dev->msi_lock;
>>>       unsigned long flags;
>>>
>>> +     if (pci_msi_ignore_mask || desc->msi_attrib.is_virtual)
>>> +             return;
>>> +
>> I'd rather be consistent, and keep the check outside of
>> pci_msi_update_mask(), just like we do in __pci_msi_mask_desc().
>> Something like this instead:
>>
>> diff --git a/drivers/pci/msi.c b/drivers/pci/msi.c
>> index 0099a00af361..6c69eab304ce 100644
>> --- a/drivers/pci/msi.c
>> +++ b/drivers/pci/msi.c
>> @@ -420,7 +420,8 @@ static void __pci_restore_msi_state(struct pci_dev *dev)
>>         arch_restore_msi_irqs(dev);
>>
>>         pci_read_config_word(dev, dev->msi_cap + PCI_MSI_FLAGS, &control);
>> -       pci_msi_update_mask(entry, 0, 0);
>> +       if (!(pci_msi_ignore_mask || desc->msi_attrib.is_virtual))
>> +               pci_msi_update_mask(entry, 0, 0);
>>         control &= ~PCI_MSI_FLAGS_QSIZE;
>>         control |= (entry->msi_attrib.multiple << 4) | PCI_MSI_FLAGS_ENABLE;
>>         pci_write_config_word(dev, dev->msi_cap + PCI_MSI_FLAGS, control);
>>
>> But the commit message talks about MSI-X, and the above is MSI
>> only. Is Xen messing with the former, the latter, or both?
> My understanding is pci_msi_ignore_mask covers both MSI and MSI-X for Xen.

Please let me know if I should go ahead and try it out and send in a v3
of the patch.

I'm watching for further discussion right now, just to be clear.
>>>       raw_spin_lock_irqsave(lock, flags);
>>>       desc->msi_mask &= ~clear;
>>>       desc->msi_mask |= set;
>>> @@ -181,6 +184,9 @@ static void pci_msix_write_vector_ctrl(struct msi_desc *desc, u32 ctrl)
>>>  {
>>>       void __iomem *desc_addr = pci_msix_desc_addr(desc);
>>>
>>> +     if (pci_msi_ignore_mask || desc->msi_attrib.is_virtual)
>>> +             return;
>>> +
>>>       writel(ctrl, desc_addr + PCI_MSIX_ENTRY_VECTOR_CTRL);
>>>  }
>> I have similar reservations for this one.
> The problem here is some of the changes in commit 446a98b19fd6
> ("PCI/MSI: Use new mask/unmask functions") bypass the checks in
> __pci_msi_mask_desc/__pci_msi_unmask_desc.  I've wondered if it would
> be cleaner to push all the `if (pci_msi_ignore_mask)` checks down to
> the place of the writes.  That keeps dropping the write local to the
> write and leaves the higher level code consistent between the regular
> and Xen PV cases.  I don't know where checking
> desc->msi_attrib.is_virtual is appropriate.
>
> Regards,
> Jason


From xen-devel-bounces@lists.xenproject.org Thu Oct 21 08:27:21 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Oct 2021 08:27:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.214224.372713 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdTQ0-0007IC-I4; Thu, 21 Oct 2021 08:27:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 214224.372713; Thu, 21 Oct 2021 08:27:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdTQ0-0007I5-EZ; Thu, 21 Oct 2021 08:27:20 +0000
Received: by outflank-mailman (input) for mailman id 214224;
 Thu, 21 Oct 2021 08:27:19 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mdTPz-0007Hp-10; Thu, 21 Oct 2021 08:27:19 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mdTPy-0004ER-M7; Thu, 21 Oct 2021 08:27:18 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mdTPy-0003XO-9n; Thu, 21 Oct 2021 08:27:18 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mdTPy-0006Qo-9E; Thu, 21 Oct 2021 08:27:18 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=lECCB3xSyDYzHdKyELm6sqCJyERE3nwJ7GFSgII749I=; b=Z6OaUoASxiwF19qERUGs7W1e7h
	vGMVEv7zjOVhoZfhg/5EEf65Lo2F/NURtQL6iydEFvB/9+hFoGrxaV/17Z3u8KIdrBE5+RXsRYhtr
	BOx3Rv2AOd/8DhrHgICCULboVdmDm8BN+SKP/Lp8kTVBNcoLCeC4sKTedWNlBGr4gONo=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165696-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-5.4 test] 165696: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=4f508aa9dd3bde7a1c5e4e6de72abb8a03fd504a
X-Osstest-Versions-That:
    linux=ce061ef43f1dede7ee2bd907d2bf38402831e30d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 21 Oct 2021 08:27:18 +0000

flight 165696 linux-5.4 real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165696/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 165616
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 165616
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165616
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165616
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 165616
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165616
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 165616
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 165616
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 165616
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 165616
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 165616
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 165616
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 linux                4f508aa9dd3bde7a1c5e4e6de72abb8a03fd504a
baseline version:
 linux                ce061ef43f1dede7ee2bd907d2bf38402831e30d

Last test of basis   165616  2021-10-17 09:11:05 Z    3 days
Testing same since   165687  2021-10-20 10:13:27 Z    0 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
  Al Viro <viro@zeniv.linux.org.uk>
  Aleksander Morgado <aleksander@aleksander.es>
  Alex Deucher <alexander.deucher@amd.com>
  Andy Shevchenko <andriy.shevchenko@linux.intel.com>
  Ard Biesheuvel <ardb@kernel.org>
  Arnd Bergmann <arnd@arndb.de>
  Aya Levin <ayal@nvidia.com>
  Bartosz Golaszewski <brgl@bgdev.pl>
  Billy Tsai <billy_tsai@aspeedtech.com>
  Borislav Petkov <bp@suse.de>
  Catalin Marinas <catalin.marinas@arm.com>
  chongjiapeng <jiapeng.chong@linux.alibaba.com>
  Chris Packham <chris.packham@alliedtelesis.co.nz>
  Christophe JAILLET <christophe.jaillet@wanadoo.fr>
  Colin Ian King <colin.king@canonical.com>
  Cédric Le Goater <clg@kaod.org>
  Damien Le Moal <damien.lemoal@wdc.com>
  Dan Carpenter <dan.carpenter@oracle.com>
  Daniele Palmas <dnlplm@gmail.com>
  Dave Airlie <airlied@redhat.com>
  David S. Miller <davem@davemloft.net>
  David Sterba <dsterba@suse.com>
  Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
  Dmitry Torokhov <dmitry.torokhov@gmail.com>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Filipe Manana <fdmanana@suse.com>
  Florian fainelli <f.fainelli@gmail.com>
  Greentime Hu <green.hu@gmail.com>
  Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  Guenter Roeck <linux@roeck-us.net>
  Guo Ren <guoren@kernel.org>
  Guo Ren <guoren@linux.alibaba.com>
  Halil Pasic <pasic@linux.ibm.com>
  Hanjun Guo <guohanjun@huawei.com>
  Hans de Goede <hdegoede@redhat.com>
  Hans Potsch <hans.potsch@nokia.com>
  Heiko Carstens <hca@linux.ibm.com>
  Herve Codina <herve.codina@bootlin.com>
  Hui Liu <hui.liu@mediatek.com>
  Hui Wang <hui.wang@canonical.com>
  Hulk Robot <hulkrobot@huawei.com>
  Ido Schimmel <idosch@nvidia.com>
  Jackie Liu <liuyun01@kylinos.cn>
  Jakub Kicinski <kuba@kernel.org>
  James Morse <james.morse@arm.com>
  Jiri Valek - 2N <valek@2n.cz>
  Johan Hovold <johan@kernel.org>
  Jon Hunter <jonathanh@nvidia.com>
  Jonas Hahnfeld <hahnjo@hahnjo.de>
  Jonathan Bell <jonathan@raspberrypi.com>
  Jonathan Cameron <Jonathan.Cameron@huawei.com>
  Kai-Heng Feng <kai.heng.feng@canonical.com>
  Kailang Yang <kailang@realtek.com>
  Linux Kernel Functional Testing <lkft@linaro.org>
  Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
  Marcelo Ricardo Leitner <mleitner@redhat.com>
  Marek Behún <kabel@kernel.org>
  Mathias Nyman <mathias.nyman@linux.intel.com>
  Michael Cullen <michael@michaelcullen.name>
  Michael Ellerman <mpe@ellerman.id.au>
  Michael S. Tsirkin <mst@redhat.com>
  Miklos Szeredi <mszeredi@redhat.com>
  Miquel Raynal <miquel.raynal@bootlin.com>
  Nanyong Sun <sunnanyong@huawei.com>
  Nikolay Martynov <mar.kolya@gmail.com>
  Pavankumar Kondeti <pkondeti@codeaurora.org>
  Qu Wenruo <wqu@suse.com>
  Reinette Chatre <reinette.chatre@intel.com>
  Rob Clark <robdclark@chromium.org>
  Roberto Sassu <roberto.sassu@huawei.com>
  Saeed Mahameed <saeedm@nvidia.com>
  Sam Ravnborg <sam@ravnborg.org>
  Sebastian Andrzej Siewior <bigeasy@linutronix.de>
  seeteena <s1seetee@linux.vnet.ibm.com>
  Shannon Nelson <snelson@pensando.io>
  Shuah Khan <skhan@linuxfoundation.org>
  Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
  Stephen Boyd <swboyd@chromium.org>
  Steven Rostedt (VMware) <rostedt@goodmis.org>
  Steven Rostedt <rostedt@goodmis.org>
  Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
  Takashi Iwai <tiwai@suse.de>
  Tom Lendacky <thomas.lendacky@amd.com>
  Tomaz Solc <tomaz.solc@tablix.org>
  Vadim Pasternak <vadimp@nvidia.com>
  Vasily Gorbik <gor@linux.ibm.com>
  Vegard Nossum <vegard.nossum@oracle.com>
  Wang Hai <wanghai38@huawei.com>
  Werner Sembach <wse@tuxedocomputers.com>
  Wim Van Sebroeck <wim@linux-watchdog.org>
  Yu-Tung Chang <mtwget@gmail.com>
  Zhang Jianhua <chris.zjh@huawei.com>
  Ziyang Xuan <william.xuanziyang@huawei.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   ce061ef43f1d..4f508aa9dd3b  4f508aa9dd3bde7a1c5e4e6de72abb8a03fd504a -> tested/linux-5.4


From xen-devel-bounces@lists.xenproject.org Thu Oct 21 09:04:15 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Oct 2021 09:04:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.214239.372727 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdTzd-000315-PM; Thu, 21 Oct 2021 09:04:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 214239.372727; Thu, 21 Oct 2021 09:04:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdTzd-00030y-MJ; Thu, 21 Oct 2021 09:04:09 +0000
Received: by outflank-mailman (input) for mailman id 214239;
 Thu, 21 Oct 2021 09:04:08 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mdTzc-00030s-Cb
 for xen-devel@lists.xenproject.org; Thu, 21 Oct 2021 09:04:08 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mdTzc-0004rI-6l; Thu, 21 Oct 2021 09:04:08 +0000
Received: from [54.239.6.190] (helo=[192.168.27.91])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mdTzb-0004DA-Tq; Thu, 21 Oct 2021 09:04:08 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=pA3pLUX/ci53s4QZwrl4pI8flMnEBB8vw0/4zipkqjo=; b=e4zhraTNxMFPjkNxbdsqwzHB4H
	1VeGrWABwOxBglG4Wbp42hcLRBmpSuilWT3eW67gbZIwNCJstg8L36pRLIiXTQ3+eALr1EER4tIKq
	Quddt/TY4Z6otV9GHyqmaryOQxrW6VKIoYpdQzJtpyLiV3OVDTuc3k8jf1CL+ReOHR6I=;
Message-ID: <6a32f269-57cb-111a-16a0-bcbabc208b4a@xen.org>
Date: Thu, 21 Oct 2021 10:04:06 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.2.0
Subject: Re: [XEN][RFC PATCH 06/13] device tree: Add dt_print_node_names()
To: Vikram Garhwal <fnu.vikram@xilinx.com>, xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org
References: <1630562763-390068-1-git-send-email-fnu.vikram@xilinx.com>
 <1630562763-390068-7-git-send-email-fnu.vikram@xilinx.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <1630562763-390068-7-git-send-email-fnu.vikram@xilinx.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Vikram,

On 02/09/2021 07:05, Vikram Garhwal wrote:
> Add dt_print_node_names() to print all nodes under a dt_device_node.
> dt_print_node_names() takes a dt_device_node type input and prints the node name
> of all the subsequent nodes. This is added for debugging purpose for device tree
> overlays.

I can't find any use of this function in the rest of series. While I 
understand it was helpful for you, I am not entirely convinced that we 
should add it in Xen with no-use. The code is simple enough for anyone 
to re-implement it if needed.

Cheers,

> 
> Signed-off-by: Vikram Garhwal <fnu.vikram@xilinx.com>
> ---
>   xen/common/device_tree.c      | 10 ++++++++++
>   xen/include/xen/device_tree.h |  5 +++++
>   2 files changed, 15 insertions(+)
> 
> diff --git a/xen/common/device_tree.c b/xen/common/device_tree.c
> index cda21be..bfe3191 100644
> --- a/xen/common/device_tree.c
> +++ b/xen/common/device_tree.c
> @@ -308,6 +308,16 @@ struct dt_device_node *dt_find_node_by_path(const char *path)
>       return np;
>   }
>   
> +void dt_print_node_names(struct dt_device_node *dt)
> +{
> +    struct dt_device_node *np;
> +
> +    dt_for_each_device_node(dt, np)
> +        dt_dprintk("Node name: %s Full name %s\n", np->name, np->full_name);
> +
> +    return;
> +}
> +
>   int dt_find_node_by_gpath(XEN_GUEST_HANDLE(char) u_path, uint32_t u_plen,
>                             struct dt_device_node **node)
>   {
> diff --git a/xen/include/xen/device_tree.h b/xen/include/xen/device_tree.h
> index a4e98a7..dcd96b4 100644
> --- a/xen/include/xen/device_tree.h
> +++ b/xen/include/xen/device_tree.h
> @@ -483,6 +483,11 @@ struct dt_device_node *dt_find_node_by_path(const char *path);
>   int dt_find_node_by_gpath(XEN_GUEST_HANDLE(char) u_path, uint32_t u_plen,
>                             struct dt_device_node **node);
>   
> +/*
> + * Prints all node names.
> + */
> +void dt_print_node_names(struct dt_device_node *dt);
> +
>   /**
>    * dt_get_parent - Get a node's parent if any
>    * @node: Node to get parent
> 

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Thu Oct 21 09:29:19 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Oct 2021 09:29:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.214247.372738 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdUNc-0005RQ-RM; Thu, 21 Oct 2021 09:28:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 214247.372738; Thu, 21 Oct 2021 09:28:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdUNc-0005RJ-OS; Thu, 21 Oct 2021 09:28:56 +0000
Received: by outflank-mailman (input) for mailman id 214247;
 Thu, 21 Oct 2021 09:28:55 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mdUNb-0005RA-2o
 for xen-devel@lists.xenproject.org; Thu, 21 Oct 2021 09:28:55 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mdUNZ-0005GI-Jw; Thu, 21 Oct 2021 09:28:53 +0000
Received: from [54.239.6.190] (helo=[192.168.27.91])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mdUNZ-0006Op-Ca; Thu, 21 Oct 2021 09:28:53 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=LRBC4TXvwcl54G8I9otdE70GOETYcQuz/nSsyR1gAeo=; b=hIc3iAbt3Ar9KH8YaAEc3i4jar
	sC41Q+4ubiL+9f9ocPaRcpliPCsT8xqu1m2/cd9eXXHrVErBS2f86kxJ4Ac2JEgtxqasXNq7irxQ7
	xXrRK26/gHhT9qLg9I6DmxnvWkc1hjfWJnbXVN6aZFCX3913+2ZldwwOdCgURW1ZWwYw=;
Message-ID: <99f6d6c4-bcc6-03a9-ef9b-0d01be0fd7f1@xen.org>
Date: Thu, 21 Oct 2021 10:28:50 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.2.0
Subject: xen/arm: Missing appropriate locking for the IOMMU (WAS Re: [PATCH v5
 02/11] xen/arm: Add PHYSDEVOP_pci_device_(*add/remove) support for ARM)
To: Rahul Singh <rahul.singh@arm.com>, xen-devel@lists.xenproject.org
Cc: bertrand.marquis@arm.com, Andre.Przywara@arm.com,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Jan Beulich <jbeulich@suse.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <cover.1633540842.git.rahul.singh@arm.com>
 <0dc4423b2e20c1eb40c961b211b18ed041f707b7.1633540842.git.rahul.singh@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <0dc4423b2e20c1eb40c961b211b18ed041f707b7.1633540842.git.rahul.singh@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi all,

While going through the passthrough code. I noticed that we don't have a 
common lock for the IOMMU between the PCI and DT code.

This is going to be an issue given it would technically be possible to 
add a PCI device while assigning a DT.

Rahul, Bertrand, Oleksandr, can you have a look at the issue?

Cheers,

On 06/10/2021 18:40, Rahul Singh wrote:
> Hardware domain is in charge of doing the PCI enumeration and will
> discover the PCI devices and then will communicate to XEN via hyper
> call PHYSDEVOP_pci_device_add(..) to add the PCI devices in XEN.
> 
> Also implement PHYSDEVOP_pci_device_remove(..) to remove the PCI device.
> 
> As most of the code for PHYSDEVOP_pci_device_* is the same between x86
> and ARM, move the code to a common file to avoid duplication.
> 
> There are other PHYSDEVOP_pci_device_* operations to add PCI devices.
> Currently implemented PHYSDEVOP_pci_device_remove(..) and
> PHYSDEVOP_pci_device_add(..) only as those are minimum required to
> support PCI passthrough on ARM.
> 
> Signed-off-by: Rahul Singh <rahul.singh@arm.com>
> ---
> Change in v5:
> - Move the pci_physdev_op() stub to xen/arch/arm/physdev.c.
> Change in v4:
> - Move file commom/physdev.c to drivers/pci/physdev.c
> - minor comments.
> Change in v3: Fixed minor comment.
> Change in v2:
> - Add support for PHYSDEVOP_pci_device_remove()
> - Move code to common code
> ---
> ---
>   xen/arch/arm/physdev.c        |  6 ++-
>   xen/arch/x86/physdev.c        | 52 +----------------------
>   xen/arch/x86/x86_64/physdev.c |  2 +-
>   xen/drivers/pci/Makefile      |  1 +
>   xen/drivers/pci/physdev.c     | 80 +++++++++++++++++++++++++++++++++++
>   xen/include/public/arch-arm.h |  4 +-
>   xen/include/xen/hypercall.h   |  4 ++
>   7 files changed, 96 insertions(+), 53 deletions(-)
>   create mode 100644 xen/drivers/pci/physdev.c
> 
> diff --git a/xen/arch/arm/physdev.c b/xen/arch/arm/physdev.c
> index e91355fe22..f9aa274dda 100644
> --- a/xen/arch/arm/physdev.c
> +++ b/xen/arch/arm/physdev.c
> @@ -8,13 +8,17 @@
>   #include <xen/lib.h>
>   #include <xen/errno.h>
>   #include <xen/sched.h>
> -#include <asm/hypercall.h>
> +#include <xen/hypercall.h>
>   
>   
>   int do_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
>   {
> +#ifdef CONFIG_HAS_PCI
> +    return pci_physdev_op(cmd, arg);
> +#else
>       gdprintk(XENLOG_DEBUG, "PHYSDEVOP cmd=%d: not implemented\n", cmd);
>       return -ENOSYS;
> +#endif
>   }
>   
>   /*
> diff --git a/xen/arch/x86/physdev.c b/xen/arch/x86/physdev.c
> index 23465bcd00..ea38be8b79 100644
> --- a/xen/arch/x86/physdev.c
> +++ b/xen/arch/x86/physdev.c
> @@ -12,7 +12,7 @@
>   #include <asm/io_apic.h>
>   #include <asm/msi.h>
>   #include <asm/hvm/irq.h>
> -#include <asm/hypercall.h>
> +#include <xen/hypercall.h>
>   #include <public/xen.h>
>   #include <public/physdev.h>
>   #include <xsm/xsm.h>
> @@ -480,54 +480,6 @@ ret_t do_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
>           break;
>       }
>   
> -    case PHYSDEVOP_pci_device_add: {
> -        struct physdev_pci_device_add add;
> -        struct pci_dev_info pdev_info;
> -        nodeid_t node;
> -
> -        ret = -EFAULT;
> -        if ( copy_from_guest(&add, arg, 1) != 0 )
> -            break;
> -
> -        pdev_info.is_extfn = !!(add.flags & XEN_PCI_DEV_EXTFN);
> -        if ( add.flags & XEN_PCI_DEV_VIRTFN )
> -        {
> -            pdev_info.is_virtfn = 1;
> -            pdev_info.physfn.bus = add.physfn.bus;
> -            pdev_info.physfn.devfn = add.physfn.devfn;
> -        }
> -        else
> -            pdev_info.is_virtfn = 0;
> -
> -        if ( add.flags & XEN_PCI_DEV_PXM )
> -        {
> -            uint32_t pxm;
> -            size_t optarr_off = offsetof(struct physdev_pci_device_add, optarr) /
> -                                sizeof(add.optarr[0]);
> -
> -            if ( copy_from_guest_offset(&pxm, arg, optarr_off, 1) )
> -                break;
> -
> -            node = pxm_to_node(pxm);
> -        }
> -        else
> -            node = NUMA_NO_NODE;
> -
> -        ret = pci_add_device(add.seg, add.bus, add.devfn, &pdev_info, node);
> -        break;
> -    }
> -
> -    case PHYSDEVOP_pci_device_remove: {
> -        struct physdev_pci_device dev;
> -
> -        ret = -EFAULT;
> -        if ( copy_from_guest(&dev, arg, 1) != 0 )
> -            break;
> -
> -        ret = pci_remove_device(dev.seg, dev.bus, dev.devfn);
> -        break;
> -    }
> -
>       case PHYSDEVOP_prepare_msix:
>       case PHYSDEVOP_release_msix: {
>           struct physdev_pci_device dev;
> @@ -663,7 +615,7 @@ ret_t do_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
>       }
>   
>       default:
> -        ret = -ENOSYS;
> +        ret = pci_physdev_op(cmd, arg);
>           break;
>       }
>   
> diff --git a/xen/arch/x86/x86_64/physdev.c b/xen/arch/x86/x86_64/physdev.c
> index 0a50cbd4d8..e3cbd5ebcb 100644
> --- a/xen/arch/x86/x86_64/physdev.c
> +++ b/xen/arch/x86/x86_64/physdev.c
> @@ -9,7 +9,7 @@ EMIT_FILE;
>   #include <compat/xen.h>
>   #include <compat/event_channel.h>
>   #include <compat/physdev.h>
> -#include <asm/hypercall.h>
> +#include <xen/hypercall.h>
>   
>   #define do_physdev_op compat_physdev_op
>   
> diff --git a/xen/drivers/pci/Makefile b/xen/drivers/pci/Makefile
> index a98035df4c..972c923db0 100644
> --- a/xen/drivers/pci/Makefile
> +++ b/xen/drivers/pci/Makefile
> @@ -1 +1,2 @@
>   obj-y += pci.o
> +obj-y += physdev.o
> diff --git a/xen/drivers/pci/physdev.c b/xen/drivers/pci/physdev.c
> new file mode 100644
> index 0000000000..4f3e1a96c0
> --- /dev/null
> +++ b/xen/drivers/pci/physdev.c
> @@ -0,0 +1,80 @@
> +
> +#include <xen/guest_access.h>
> +#include <xen/hypercall.h>
> +#include <xen/init.h>
> +
> +#ifndef COMPAT
> +typedef long ret_t;
> +#endif
> +
> +ret_t pci_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
> +{
> +    ret_t ret;
> +
> +    switch ( cmd )
> +    {
> +    case PHYSDEVOP_pci_device_add: {
> +        struct physdev_pci_device_add add;
> +        struct pci_dev_info pdev_info;
> +        nodeid_t node = NUMA_NO_NODE;
> +
> +        ret = -EFAULT;
> +        if ( copy_from_guest(&add, arg, 1) != 0 )
> +            break;
> +
> +        pdev_info.is_extfn = (add.flags & XEN_PCI_DEV_EXTFN);
> +        if ( add.flags & XEN_PCI_DEV_VIRTFN )
> +        {
> +            pdev_info.is_virtfn = true;
> +            pdev_info.physfn.bus = add.physfn.bus;
> +            pdev_info.physfn.devfn = add.physfn.devfn;
> +        }
> +        else
> +            pdev_info.is_virtfn = false;
> +
> +#ifdef CONFIG_NUMA
> +        if ( add.flags & XEN_PCI_DEV_PXM )
> +        {
> +            uint32_t pxm;
> +            size_t optarr_off = offsetof(struct physdev_pci_device_add, optarr) /
> +                                sizeof(add.optarr[0]);
> +
> +            if ( copy_from_guest_offset(&pxm, arg, optarr_off, 1) )
> +                break;
> +
> +            node = pxm_to_node(pxm);
> +        }
> +#endif
> +
> +        ret = pci_add_device(add.seg, add.bus, add.devfn, &pdev_info, node);
> +        break;
> +    }
> +
> +    case PHYSDEVOP_pci_device_remove: {
> +        struct physdev_pci_device dev;
> +
> +        ret = -EFAULT;
> +        if ( copy_from_guest(&dev, arg, 1) != 0 )
> +            break;
> +
> +        ret = pci_remove_device(dev.seg, dev.bus, dev.devfn);
> +        break;
> +    }
> +
> +    default:
> +        ret = -ENOSYS;
> +        break;
> +    }
> +
> +    return ret;
> +}
> +
> +/*
> + * Local variables:
> + * mode: C
> + * c-file-style: "BSD"
> + * c-basic-offset: 4
> + * tab-width: 4
> + * indent-tabs-mode: nil
> + * End:
> + */
> diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h
> index 6b5a5f818a..d46c61fca9 100644
> --- a/xen/include/public/arch-arm.h
> +++ b/xen/include/public/arch-arm.h
> @@ -107,7 +107,9 @@
>    *   All generic sub-operations
>    *
>    *  HYPERVISOR_physdev_op
> - *   No sub-operations are currenty supported
> + *   Exactly these sub-operations are supported:
> + *   PHYSDEVOP_pci_device_add
> + *   PHYSDEVOP_pci_device_remove
>    *
>    *  HYPERVISOR_sysctl
>    *   All generic sub-operations, with the exception of:
> diff --git a/xen/include/xen/hypercall.h b/xen/include/xen/hypercall.h
> index 3771487a30..07b10ec230 100644
> --- a/xen/include/xen/hypercall.h
> +++ b/xen/include/xen/hypercall.h
> @@ -45,6 +45,10 @@ extern long
>   do_platform_op(
>       XEN_GUEST_HANDLE_PARAM(xen_platform_op_t) u_xenpf_op);
>   
> +extern long
> +pci_physdev_op(
> +    int cmd, XEN_GUEST_HANDLE_PARAM(void) arg);
> +
>   /*
>    * To allow safe resume of do_memory_op() after preemption, we need to know
>    * at what point in the page list to resume. For this purpose I steal the
> 

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Thu Oct 21 09:35:04 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Oct 2021 09:35:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.214255.372750 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdUTU-0006p1-HD; Thu, 21 Oct 2021 09:35:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 214255.372750; Thu, 21 Oct 2021 09:35:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdUTU-0006ou-Ca; Thu, 21 Oct 2021 09:35:00 +0000
Received: by outflank-mailman (input) for mailman id 214255;
 Thu, 21 Oct 2021 09:34:59 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mdUTT-0006oo-4G
 for xen-devel@lists.xenproject.org; Thu, 21 Oct 2021 09:34:59 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mdUTS-0005MY-DQ; Thu, 21 Oct 2021 09:34:58 +0000
Received: from [54.239.6.190] (helo=[192.168.27.91])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mdUTS-0006y0-78; Thu, 21 Oct 2021 09:34:58 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=AWkHphHUrYUhcyB9cSpAthxNiuPulKkEyutMJrkC3PU=; b=ZzOIwzyGx4jaRYJXF+iHYuwAAa
	859D3CmHMVAJApc8kY+GRCGQkzbJwmUaJnFsBuj9nOYTSsXzET+T3sj6icdm1EMYLinQ3ygNHWYd1
	joH4HG2hBZ8+gGLbJPaHc8C1DspcI4hXbGF2I8A6JeouzuPa5p2Z1DeRH/GhUR18qGVg=;
Message-ID: <e4551e28-7405-60b4-ddea-1830e3da1925@xen.org>
Date: Thu, 21 Oct 2021 10:34:56 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.2.0
Subject: Re: [XEN][RFC PATCH 08/13] xen/iommu: Introduce
 iommu_remove_dt_devices function
To: Vikram Garhwal <fnu.vikram@xilinx.com>, xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Jan Beulich <jbeulich@suse.com>, Paul Durrant <paul@xen.org>
References: <1630562763-390068-1-git-send-email-fnu.vikram@xilinx.com>
 <1630562763-390068-9-git-send-email-fnu.vikram@xilinx.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <1630562763-390068-9-git-send-email-fnu.vikram@xilinx.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Vikram,

On 02/09/2021 07:05, Vikram Garhwal wrote:
> iommu_remove_dt_device function is introduced for supporting dynamic programming
> i.e. adding and removing a node during runtime. When user removes the device
> node, iommu_remove_dt_device() removes the device entry from smmu-masters too
> using following steps:
>      1. Find if SMMU master exists for the device node.
>      2. Remove the SMMU master.

I would prefer if this patch is split in two:
   * Part 1: Add the generic helper
   * Part 2: Implement the callback for the SMMU

> 
> Signed-off-by: Vikram Garhwal <fnu.vikram@xilinx.com>
> ---
>   xen/drivers/passthrough/arm/smmu.c    | 53 +++++++++++++++++++++++++++++++++++
>   xen/drivers/passthrough/device_tree.c | 30 ++++++++++++++++++++
>   xen/include/xen/iommu.h               |  2 ++
>   3 files changed, 85 insertions(+)
> 
> diff --git a/xen/drivers/passthrough/arm/smmu.c b/xen/drivers/passthrough/arm/smmu.c
> index c9dfc4c..7b615bc 100644
> --- a/xen/drivers/passthrough/arm/smmu.c
> +++ b/xen/drivers/passthrough/arm/smmu.c
> @@ -816,6 +816,17 @@ static int insert_smmu_master(struct arm_smmu_device *smmu,
>   	return 0;
>   }
>   
> +static int remove_smmu_master(struct arm_smmu_device *smmu,
> +			      struct arm_smmu_master *master)
> +{
> +	if (!(smmu->masters.rb_node))
> +		return -ENOENT;
> +
> +	rb_erase(&master->node, &smmu->masters);
> +
> +	return 0;
> +}
> +
>   static int arm_smmu_dt_add_device_legacy(struct arm_smmu_device *smmu,
>   					 struct device *dev,
>   					 struct iommu_fwspec *fwspec)
> @@ -853,6 +864,31 @@ static int arm_smmu_dt_add_device_legacy(struct arm_smmu_device *smmu,
>   	return insert_smmu_master(smmu, master);
>   }
>   
> +static int arm_smmu_dt_remove_device_legacy(struct arm_smmu_device *smmu,
> +					 struct device *dev)
> +{
> +	struct arm_smmu_master *master;
> +	struct device_node *dev_node = dev_get_dev_node(dev);
> +	int ret;
> +
> +	master = find_smmu_master(smmu, dev_node);
> +	if (master == NULL) {
> +		dev_err(dev,
> +			"No registrations found for master device %s\n",
> +			dev_node->name);
> +		return -EINVAL;
> +	}
> +
> +	ret = remove_smmu_master(smmu, master);

Can you add a comment why you are not clearing the dev_node->is_protected?

> +
> +	if (ret)
> +		return ret;
> +
> +	master->of_node = NULL;

NIT: This is a bit pointless to do given that you are freeing master 
right after.

> +	kfree(master);
> +	return 0;
> +}
> +
>   static int register_smmu_master(struct arm_smmu_device *smmu,
>   				struct device *dev,
>   				struct of_phandle_args *masterspec)
> @@ -876,6 +912,22 @@ static int register_smmu_master(struct arm_smmu_device *smmu,
>   					     fwspec);
>   }
>   
> +static int arm_smmu_dt_remove_device_generic(u8 devfn, struct device *dev)
> +{
> +	struct arm_smmu_device *smmu;
> +	struct iommu_fwspec *fwspec;
> +
> +	fwspec = dev_iommu_fwspec_get(dev);
> +	if (fwspec == NULL)
> +		return -ENXIO;
> +
> +	smmu = find_smmu(fwspec->iommu_dev);
> +	if (smmu == NULL)
> +		return -ENXIO;
> +
> +	return arm_smmu_dt_remove_device_legacy(smmu, dev);
> +}
> +
>   static int arm_smmu_dt_add_device_generic(u8 devfn, struct device *dev)
>   {
>   	struct arm_smmu_device *smmu;
> @@ -2876,6 +2928,7 @@ static const struct iommu_ops arm_smmu_iommu_ops = {
>       .init = arm_smmu_iommu_domain_init,
>       .hwdom_init = arm_smmu_iommu_hwdom_init,
>       .add_device = arm_smmu_dt_add_device_generic,
> +    .remove_device = arm_smmu_dt_remove_device_generic,
>       .teardown = arm_smmu_iommu_domain_teardown,
>       .iotlb_flush = arm_smmu_iotlb_flush,
>       .iotlb_flush_all = arm_smmu_iotlb_flush_all,
> diff --git a/xen/drivers/passthrough/device_tree.c b/xen/drivers/passthrough/device_tree.c
> index 98f2aa0..37f4945 100644
> --- a/xen/drivers/passthrough/device_tree.c
> +++ b/xen/drivers/passthrough/device_tree.c
> @@ -127,6 +127,36 @@ int iommu_release_dt_devices(struct domain *d)
>       return 0;
>   }
>   
> +int iommu_remove_dt_device(struct dt_device_node *np)
> +{
> +    const struct iommu_ops *ops = iommu_get_ops();
> +    struct device *dev = dt_to_dev(np);
> +    int rc = 1;

You set rc to 1 but AFAICT the value is never used.

> +
> +    if ( !ops )
> +        return -EINVAL;

It would be better to return -EOPNOSUPP.

> +
> +    if ( iommu_dt_device_is_assigned(np) )
> +        return -EPERM;
> +
> +    /*
> +     * The driver which supports generic IOMMU DT bindings must have
> +     * these callback implemented.
> +     */

I think we should make ops->remove_device optional.

> +    if ( !ops->remove_device )
> +        return -EINVAL;
It would be better to return -EOPNOSUPP.

> +
> +    /*
> +     * Remove master device from the IOMMU if latter is present and available.
> +     */
> +    rc = ops->remove_device(0, dev);

This will need to be interlocked with other IOMMU request.

> +
> +    if ( rc == 0 )
> +        iommu_fwspec_free(dev);
> +
> +    return rc;
> +}
> +
>   int iommu_add_dt_device(struct dt_device_node *np)
>   {
>       const struct iommu_ops *ops = iommu_get_ops();
> diff --git a/xen/include/xen/iommu.h b/xen/include/xen/iommu.h
> index 6b2cdff..c4d5d12 100644
> --- a/xen/include/xen/iommu.h
> +++ b/xen/include/xen/iommu.h
> @@ -215,6 +215,8 @@ int iommu_release_dt_devices(struct domain *d);
>    */
>   int iommu_add_dt_device(struct dt_device_node *np);
>   
> +int iommu_remove_dt_device(struct dt_device_node *np);
> +
>   int iommu_do_dt_domctl(struct xen_domctl *, struct domain *,
>                          XEN_GUEST_HANDLE_PARAM(xen_domctl_t));
>   
> 

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Thu Oct 21 09:57:14 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Oct 2021 09:57:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.214265.372766 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdUov-0000jh-BU; Thu, 21 Oct 2021 09:57:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 214265.372766; Thu, 21 Oct 2021 09:57:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdUov-0000ja-8d; Thu, 21 Oct 2021 09:57:09 +0000
Received: by outflank-mailman (input) for mailman id 214265;
 Thu, 21 Oct 2021 09:57:08 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=FF+c=PJ=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mdUou-0000jU-Oe
 for xen-devel@lists.xenproject.org; Thu, 21 Oct 2021 09:57:08 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 4098c6c5-1b7b-4df0-bb5b-f9ee10cea8cc;
 Thu, 21 Oct 2021 09:57:07 +0000 (UTC)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2052.outbound.protection.outlook.com [104.47.14.52]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-16-WLdd5qL8PU6RCGS4byBPvw-1; Thu, 21 Oct 2021 11:57:05 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB3118.eurprd04.prod.outlook.com (2603:10a6:802:a::16) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.18; Thu, 21 Oct
 2021 09:57:03 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::8062:d7cb:ca45:1898]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::8062:d7cb:ca45:1898%3]) with mapi id 15.20.4628.018; Thu, 21 Oct 2021
 09:57:03 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS8PR04CA0138.eurprd04.prod.outlook.com (2603:10a6:20b:127::23) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.16 via Frontend
 Transport; Thu, 21 Oct 2021 09:57:03 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4098c6c5-1b7b-4df0-bb5b-f9ee10cea8cc
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634810226;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding;
	bh=58hIKBhXICJXlFTMq5AIXN6HCS3Ro5jaiuK1zsxE30Q=;
	b=GWMdwRdhypcQyWgzgN+Rpqq6GTnDR34BH8gBFQdtPsnI1CLV9U8VW41i2gQOGtvALyszaT
	iAcPOctQHqJRYNgRdli5XS/SB39TZMcYQZYIqk+IQaaQ+U/TNY5UQf4IWMZNJ+0FvZSKg5
	1Z7+kDGxNihJpCI50M4DFZncw0TPMmo=
X-MC-Unique: WLdd5qL8PU6RCGS4byBPvw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=dS/eGmSW5gaWsf5lyGXRTzwtwfxyL/wZchCBx2Vk44r24t6opTYiN0umJot8eq+xQ1pZv105nWGjD8oe7CIh/QRIBFQ3lC6cztEtpWksXfgjhbW2MzAEwTsBaXdGGd+/y2RTrd3pPPxato7OmCFfDeB38Z8+lW2mKDw8kJlfWHtxnXuHsst9H2nNqElS/pwwofgDPdjDxC6m2ws3KFX1l/1gMGsx+Ya4WgD1Ec094tZ3uJJA4pBJoQjL180S+KmUmpnjBduDdRoQOevGBc01bRvMa4l0ErfKpXrLyV6U7tebIAIWVvp7TP6UbZ5D8pBcQZw8p12A8d+lxft9wrIYLw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=58hIKBhXICJXlFTMq5AIXN6HCS3Ro5jaiuK1zsxE30Q=;
 b=oPzuywY+quxlRefm5mEbjNrYv1VLrbZ8fFLut8+BO+WHJDnm+xOvThHSP5uzLJfUUY0o5H10/4sK6E7lS0YGtoGrEqGBvD9ntCHvJcAEX2gxQqP/vjmrFHDdtGPbfH15xcdd+MEzxHcJWgcO+2vnx2xwsh4B2/KcLk0g5igFhJBThOh5MIDZkocMtHmtKi1BOO/7A8vCEsTH0/8yX0YNuay03FLFaF9a6ptX13EdCN01mFFfqo+U9HshX+eWmt7Q9VrA5Vxmx+XN2OH2PoSwe9djXUUeo7419SXaJVqgdIdJfSnENJQX27f85DGNnW7kglfwIKoWNwFAA2c5WWAlgg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Paul Durrant <paul@xen.org>
From: Jan Beulich <jbeulich@suse.com>
Subject: [PATCH v2 0/3] x86/IOMMU: enabled / intremap handling
Message-ID: <09137aa2-649f-08fb-ba68-75f8eb16fc63@suse.com>
Date: Thu, 21 Oct 2021 11:57:01 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8PR04CA0138.eurprd04.prod.outlook.com
 (2603:10a6:20b:127::23) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: a8e0f474-016d-45d0-5605-08d99479222b
X-MS-TrafficTypeDiagnostic: VI1PR04MB3118:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB31180B9823433B2BF75117C3B3BF9@VI1PR04MB3118.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7219;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	dSvVpPUmecEtI/Dhq9kqy/mjR60JRSSMNAEBf+5y4CdZh2k4LHKiGf1Iyxdm3S/8FU1cuXSUFW5Ias59/6O12uobLO4abq+GJzTHq0pYZbmgHVF8CMC8EEyeg3nR95CCM6wcO0WGlljxflMrhQVW4g7Q2K3Vz2tVsBZISprdW/wrXM5TAU6Wsds3EqzGqGlwJ4HbrAvXe8chtQGSaeE5OZhfTCMOIorT2g32cxbwBd2jCdF0SFqS7hb/4Z4fpaMryBOpRc6y2pEyfLqZhj+QoZgCQGrS1Ng1y+wfOt5s6BOgl9EeIobadxc1Vz4+B4feYs9hydrF4anDZgf/5fink8CAUqsNNSlpDrZmx1xXRf8HUsC1CpPK7b73ReYWAxhO95K8LbOf/3W4m8piAV3vFBRL8Ru3JhnpJ8I9JKDq+AhBfxJuK2SVkPgCmCrSxwimXnyJNl3cUyQa3ZZQrPD+CnMvUfA9OyihFRfXlzgQ3gKcZoGXPM5Phss9qCl46NPQwEUbxtUpipHD/tH2Tu/D6+Pwp3bWrq+IT6BYo/Q/bNj1s1Bl+eHjDMbppMHKQC3HxVk5i25THabpIEhZ3JSfDVSzRyq78iE6f1rxxOoURMYigU98hy8c5yqTx54tRrCch1ybnsczDZJfbIU0xC/0TbIEonbXX8Ikinil5Xd4mmDCtwvtHoGFfyyGqjEdqF3glq3Bh2ddXqzBkK7HtcRbo6Kg3W8wE+Mr6SVn9/CIBWM=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(36756003)(8676002)(66476007)(86362001)(2616005)(66556008)(31686004)(956004)(6486002)(8936002)(508600001)(2906002)(4744005)(66946007)(5660300002)(38100700002)(6916009)(26005)(16576012)(54906003)(4326008)(186003)(31696002)(316002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Rldxelh6WkdhMEpSN1V1dzU5aHViazUwN2QyOXJxSDNjYTJLcm45ZmpKK1M5?=
 =?utf-8?B?U01Kc2dSRVBKWG43My8vOWNjSFk0b0lCY1p6K0RDVm9HMmp2blR6cSs0cng2?=
 =?utf-8?B?OE5uQXZqckhBYStvTDlsQVFESCs1bmo2aS83VVJyeFZqVzNsL3ZjQzRsYXhu?=
 =?utf-8?B?dDZGMU8wUXV3Z3hTWWdTb3JXc3ozOFVCdTFQdUhtM2c1Q3ArZ3g0ZkpnYU9D?=
 =?utf-8?B?LzZBN2VDWi9yMzhtdEk2VkdlZk9xVVlxTGt6SlgxbjlhSXdGK2h2SGtVaUxi?=
 =?utf-8?B?NWI0QWRobWZaUllYQjFqeEdoMURkYXlIcU4vL3FLSm9IS1RQVm1zKzJQS0tK?=
 =?utf-8?B?bDVQNFBIdjYxZzdMdDR0U0d1VkhJMTNFeTdmWkhWWXNnRllmdFRwV3VEb2ha?=
 =?utf-8?B?TGpvbFFibTFDNUVFU2Zua2pMUEM2R1dHZUVFWldMYmdlNEVLeW1ZZEJLVDJx?=
 =?utf-8?B?MHBITDVnSEJQZUVIRkJ2aXhPUTlOUFo0emZuSktoT3o5V05sVTVFVllONDZH?=
 =?utf-8?B?S3hSSnFUb1FxeUdXdVRVcTc4dSszNlN4L0xOY28wWHl2Vkxyemd6cjhyTVRB?=
 =?utf-8?B?VWpJQ2phZXB5WTJNUWRsV1o5Ulc5TG44NjJFdGxtb04zSGRlK2R6QXhYVXZz?=
 =?utf-8?B?K2NYMDg3N3MxamlSQm9iOEg5WVlwUGVpcXNGS1JPUkdQMlh3UHBUVlJqTVBI?=
 =?utf-8?B?OXRsQm9uVXZUL2RFS01TVFN3VW5SY2xwTDVuNTA4OHJaeEFxT2hXQ0U0by9L?=
 =?utf-8?B?YUx3SVJzaGNHb1JMUjIyd0ZsZXRsYndhakYxd3daL3N5MUdadEZGTlRySkkx?=
 =?utf-8?B?UzI3cDk1ZmRUVXBnSGxNTGZNMk9qK3VoK29SYitUV1BZeDVSa3g3K00yN3ZP?=
 =?utf-8?B?R25VTDNCZXc0bjhIUzlqMlZxVGlCaldJYlc0WVZ3dm1jcUVIMG9kdnBoT3hp?=
 =?utf-8?B?UUVrWTNJMTV2T2VyQ3FWZFl1ZWF6MHl2a0tqNVBPcEVCb1l3YmF0Nk5ZL1F0?=
 =?utf-8?B?UXRidFRES2ZzWWgyUUdXYXlQVUllbzJKMDFLeFY4MUlxcGIvYjZienJMZVpy?=
 =?utf-8?B?WnM1Q0ZKWDMzak1wOU5USTBvaW1sSWp3SFhzUHc0SStqTGdHUjdrRzRUNnpS?=
 =?utf-8?B?UG5BQmszeUIzR2trMXZkTkx4MVpwOHkyS2Fzc0EvVHgyTDlPU05kYmt5SC8y?=
 =?utf-8?B?Tk9KSnNiMDhKSSsvS1FCMndKOFNIcnNxcDZ5eUM1UGxncEMrUGRoaWYrc0lZ?=
 =?utf-8?B?OE5rZm9CRHJJbC9HZnBXQzlFU2h4RnJJVlhHODRXSEJVTVhvQVVOWkRhcjQ2?=
 =?utf-8?B?U0U5VUp3aGs0THd5WEZrZkhGUjltNUVKVSt0VVl3UjJKUWFiNGRzZFlTeXpv?=
 =?utf-8?B?cmUrN0o5NFZxbDBWT0lCWGhFck1ydUlycVpVNS9SM2VyMllZc29kMXhrQzBH?=
 =?utf-8?B?em95SHhjVjh1cmkwQmNwUnZ6WXZIdUZod0FYVTRXanRZQVBvSXlSb3FhVUFZ?=
 =?utf-8?B?a0Y4S0ZFODFLUEFmMlpidUo0YXYvVXVkbWloQnFVYWRtNjUzMU1ubDNQUWw2?=
 =?utf-8?B?YjBNdTFVU2k0NFIvbjZrWEplMEtEM0lhM2V6SEdkV01QK2dqb1dseTlmcEUw?=
 =?utf-8?B?N0t0VU5zcmIrVnMweW85RGpTdHY4M0J0YXViWC9mN3ZISTl0RSs5MUZKMnE1?=
 =?utf-8?B?ZUtlcDdHaHkyUjlRNE1VdFZ3dG90a01pTHh0bWgwUWcyQzNsRmVRak1qZW9i?=
 =?utf-8?B?WG5FYUp4YkxrdktzcFBGMVBic3R6b3lUc1hUckM5UjU4eHIvMHc4bjJyNUhh?=
 =?utf-8?B?L1l2dlIxQnRKQWRTOWpGS0pON3diZW1rR0xTWHZFZEM0T1FXcURzUVdpbTc3?=
 =?utf-8?B?VUgzbkhnU2xWNERIU010UTRXN2Y2UlhQeStWbk9yVlNBYlI3VmZtVldKeWZQ?=
 =?utf-8?Q?Szd5g4f3GhA=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a8e0f474-016d-45d0-5605-08d99479222b
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Oct 2021 09:57:03.6244
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jbeulich@suse.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB3118

In the course of reading the response to v1 (patch 1 only) I realized
that not only that patch needs further adjustment, but that also
further changes are needed (and there's likely yet more amiss).

1: x86/IOMMU: mark IOMMU / intremap not in use when ACPI tables are missing
2: x86/APIC: avoid iommu_supports_x2apic() on error path
3: AMD/IOMMU: iommu_enable vs iommu_intremap

Jan



From xen-devel-bounces@lists.xenproject.org Thu Oct 21 09:58:27 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Oct 2021 09:58:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.214273.372778 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdUqA-0001OK-QF; Thu, 21 Oct 2021 09:58:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 214273.372778; Thu, 21 Oct 2021 09:58:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdUqA-0001OD-Mx; Thu, 21 Oct 2021 09:58:26 +0000
Received: by outflank-mailman (input) for mailman id 214273;
 Thu, 21 Oct 2021 09:58:26 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=FF+c=PJ=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mdUq9-0001O5-Vo
 for xen-devel@lists.xenproject.org; Thu, 21 Oct 2021 09:58:26 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 6e20e246-3255-11ec-8373-12813bfff9fa;
 Thu, 21 Oct 2021 09:58:25 +0000 (UTC)
Received: from EUR02-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur02lp2059.outbound.protection.outlook.com [104.47.5.59]) (Using
 TLS) by relay.mimecast.com with ESMTP id de-mta-9-Pj40-NccPdGmwrf4w8spvA-1;
 Thu, 21 Oct 2021 11:58:23 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0402MB3774.eurprd04.prod.outlook.com (2603:10a6:803:1f::28)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.18; Thu, 21 Oct
 2021 09:58:21 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::8062:d7cb:ca45:1898]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::8062:d7cb:ca45:1898%3]) with mapi id 15.20.4628.018; Thu, 21 Oct 2021
 09:58:21 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6PR08CA0017.eurprd08.prod.outlook.com (2603:10a6:20b:b2::29) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4628.16 via Frontend Transport; Thu, 21 Oct 2021 09:58:20 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6e20e246-3255-11ec-8373-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634810304;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=uNxaaOTDiAFX60qMVwLfMAPbo6sm/y2BMjhq80ooH2c=;
	b=bL+M7ndrNx3pu/ZO3Fm5pI5EpYVe2kxZRo9a3Mgb2PWWQnrqVtqMY9hpG3muOLeljH8UIz
	/RLwGD7DD5R8ZBNZM5vdk3J7uyWqTM67OELXv9nO0u5QTf1lqIqyaJfvO74lx5WoeTnLNP
	UIXNzHKHLWMRA7xyzolmCN5KlkNBwAQ=
X-MC-Unique: Pj40-NccPdGmwrf4w8spvA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=PrFCDPx4YPNSAwIAoO+aaljJpzL9dZgnV0eFuWA2kXy6sI2WFR+pjwmU+hahBkYmBXWQv2vV/vmgoHni5vDndlUw+/0bA7Py9X0Ptlo/bgf/WaXTa0UVdKMo5t9RS+K29nhl2wHpmPe/D+S8sp4Qbi5dvfYs2o/cv69BPFmTW1EcdAm3DUIEk9DVDY3JffaAvkCYrLkhUyMzc5lRe8EddOESCLmF2s0DvAjAYtwMDMnkUcnHckv5cVz7az3+wZam+92SJkknfLHy3eKP6/mCDJgCyTruq+Lwjy94sOWf48bnl4aT9mB4kocGbayThpe5YGvi8fBfL3lI+JlHaPb1Vg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=uNxaaOTDiAFX60qMVwLfMAPbo6sm/y2BMjhq80ooH2c=;
 b=BTULTezE0dM2iWBAJwfYSzz14lHmIvMLI/q47jfg0NbbNtatZivZvpIQuBjshtj5/BrrbRnmxwaVqDgphmwmrzvxK+E9o2INqTQh6lPVQu2lYJtwa00zJBrnHlz4X0eBRdc0uES7yYPkqHJ0JGzfZRqIoa9dD8YMZ6ZgknbCDiuY9GfKngabbsyAq1wLLGH4LYy0jJzkyoctX4jRUYbvCknlR9i5gTE9mNv0svY7RBNgKDo1yZ4y/tAr0vOjUCR3h7ZRiJvgNXPNv2pyjKQKN1+w37UTEz8gHBDqphAIi16lhXvw+/IG46qITm3hGTeenz+765Ih3U1EVvZHdH8i2A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Subject: [PATCH v2 1/3] x86/IOMMU: mark IOMMU / intremap not in use when ACPI
 tables are missing
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Paul Durrant <paul@xen.org>
References: <09137aa2-649f-08fb-ba68-75f8eb16fc63@suse.com>
Message-ID: <efe34081-c813-0e37-175c-8553b395e6d9@suse.com>
Date: Thu, 21 Oct 2021 11:58:18 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <09137aa2-649f-08fb-ba68-75f8eb16fc63@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR08CA0017.eurprd08.prod.outlook.com
 (2603:10a6:20b:b2::29) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 75d2a24f-161a-4bc1-ca99-08d99479506a
X-MS-TrafficTypeDiagnostic: VI1PR0402MB3774:
X-Microsoft-Antispam-PRVS:
	<VI1PR0402MB37749C533F342D78A13DBF9CB3BF9@VI1PR0402MB3774.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:2803;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	NWHrmC08xXzWVmkj2hIXws/oPAKKF291R1esl2D2uH9+3OtU5lTI5XFvnzYNZezvmIJ+GQPrSr5utrDo9t8N+jDq9/l2AHIJ0eLnK6fEntFq7wMLgaQf6p5mKwLty4hbgLuBfk2gPRQhl0VIHoOyQ2Pvv1YlL9Y3VKUpKo/4j2Zq3vdGEk5NBaa2SspFq6BNUNxlBX26rrA10MDcj1BED30alO6Ta6JP6Psc6iauQ46Swr87K7TlWscNHRQYpkDG+aviaYuV2x/tshOlGK71xbfpR4ImABNokhZ8i5pnDe+j12iXF/WyAwJlf6H8fGuC53zCjWDncGAb9WXWx/BdVq6R9hTKDhNeLzchvamZyLQYtTqaEXXSAF7km0tZrPuYzJc6f3IGgYjSFRPC+eo3H9fR5di5Ozye7OjeBDpRjdeNvfbbubSQoGcdgfsg/IRFF+tRoFibybLt6jGMLj/Q7zcLXSf9uU+ZBoTNImhcEZFx9jKBhMW0Nj2tBYavvb4Nin0x3L+RljrBYH0UzcwezfdK6sdxjEgh3tsvMToUQhDA4pmYvcDpopx2VhgSqeUayIbcmL/nmwMG/kXULW8MXop/GW6c4oh+0vdYW7jLslMFrKa/PcSO+xEhZc8qqSzD0aqi1Y2WDkxoYBZlCSu3jvYowok+ZhEi0VSpdkV7IGRCpA/PiMpD5zvJ5+br8WfY63SR84CQP4XmPPSN4OwBCp24fD+3bsUs7awqH0tXvfyXPhewQMFwyNzZsVCJBCkp
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(2906002)(316002)(36756003)(16576012)(83380400001)(86362001)(6916009)(8676002)(8936002)(31696002)(31686004)(186003)(66946007)(66476007)(66556008)(26005)(38100700002)(54906003)(4326008)(6486002)(956004)(2616005)(508600001)(5660300002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?KzhPMVJ6OGcwaCtDZmZrMTNJT0ErNWx4bFZTMTNaYTdBbnllV0t1VnpqSUZi?=
 =?utf-8?B?NmJtS09kU0VZQWlCK3kzL1BCUVlKeDRoQjlHcGFhNW5HQURNRjhaYjB5alIy?=
 =?utf-8?B?Vm95YlcycTNvam9CMmpZOTM2dzlIbndoaDFSZFRBQXlIK0dXQnVHVk1ueUFJ?=
 =?utf-8?B?NmJNVHVPTUJTTUVxV2dETkJReGdqWDcxakFlSHhmeXVNNkoyZVZVNXlrUUdh?=
 =?utf-8?B?ODBJdTVPVG5wZVdGQmJSN2NRaGpHbVd6L3pNNDFSeEkwcm9rK0lVN1N4U3V1?=
 =?utf-8?B?aTBzTW9vN1JSS2J3c0xwZDdFaTdDTFZ1OVZrTUw3ZXNYMGRmNVRJeUVjVDZ6?=
 =?utf-8?B?TG1WTXJjUzRXbWtBMndOS3JEeERGTWxmK21XZkZwT0ZwYUh5NzhBdkduSkZp?=
 =?utf-8?B?K1hlM0picTlYYSt6enJzNlpQVWhOK0F6ODhlM2QwU2p3R0prRm9XRGQyd0FB?=
 =?utf-8?B?OEQ1VlJ5M1BxRHFpWFdqZHNzVENpSkpocFJrVDVVakEzdWNGMythNmZqM0F1?=
 =?utf-8?B?ZGU2UEVINDM5cEhWRENtWE1PMGNXMnlxd0M2dkY2elo5NlVkdWJ1aVB1cm1w?=
 =?utf-8?B?d21VVlYwRll1RlZ6T1NhOUQwK2xyVmMxT29wNlFGbExHQUx0V1lkUFVEc1lx?=
 =?utf-8?B?OWhIR3lLNnZDekVYck5uK1I1ODB3WFV5UlFVbVVrb0Jvc2RsdExYZzliWTJS?=
 =?utf-8?B?OTRDenZsNTFubkZQd0RjbTZ3RFV6SDdKTlZkOFpZRkszUHhJTDJmc25RdFB2?=
 =?utf-8?B?VEF2ZjRyTFViSDIzSEVBeTdYZTJtSnF0V3lqTTJSdXlONUN6cEVuTmZVOTZj?=
 =?utf-8?B?ZTJzY3JXUUtYcG5tV1lQcnpyS1dlOE1EQ0Ewa3JJSjNwMm1pZVo0ZmMwQ2Nu?=
 =?utf-8?B?Z0g1M2FDVE0zS0ovSFg4ZW1UaE9SQlFtN0FTWFE1U1ZLaVB1YU9qOHpzRVhM?=
 =?utf-8?B?M09STE45c2JDZi9qVm9Mb2ZvenlnZk03TFJxRElJUU01N0toZERjU25UNnpL?=
 =?utf-8?B?WHNvK3B0Zmk3RjBQc2MyWEg2Sm9tQUFsL0lzRHNNYXRpejA2eW1TNGI4bXdQ?=
 =?utf-8?B?T3ZWR2M3aS9QL0loRGJPN0YrSlB0SnkvRU5lVU9Qbk9LQkpFK25Mb2Q0YzZu?=
 =?utf-8?B?bE1Kb3M0L3E2MnQ2NFIwS0JlMlpKdFFqTmVtYnllMEhwME03TWpnRDYwTnNJ?=
 =?utf-8?B?RlZkck8rcXFOUVhUOVRsdVZvLzd1bjE5UHBIUktzTFVWMmQ5TXpRQkdDS0tN?=
 =?utf-8?B?c2JEVnpUMDEzc1lvV0RVckhad1Q2MWpSUGV6NXZQeVdzVDBQM0ZKaldxNG0x?=
 =?utf-8?B?SThVS2RsZ3BtaHBtbkpvY2Z1eFg1di9vMlF5cU51R3JhcHQyOXBDQU9LTFor?=
 =?utf-8?B?RzdQK1dhajRBby8wVTZOUkpnNjNLak5kNE9MVlVjVEpBNGhHKzR1TG92czdn?=
 =?utf-8?B?bG1aQVRPb1BhNldHbWRWRlhYSU53NTNCMU5PbkFTelhHMlVIWHdMZHM4MVN6?=
 =?utf-8?B?dEw3NW96Sk80c3Jwb01ZWis4VGhubHlXT0FKTjRVTWhmMmJPQ3hHS3ltaFc4?=
 =?utf-8?B?Nkp4Z0daY0xwSmZicVh1SklzWDY0NFd4SVVKd1Znd1F0UzhENmtBYlZndjdo?=
 =?utf-8?B?MUsvTGE3eHRHbWJWOUJPTGU1dWk2VlVMdFgxV2JnR290bU5NQy80SnpNeTdN?=
 =?utf-8?B?OE1GVWRSQkU5Z2QrQXBibThicDJTN3pGVGxwNEs5aWNHb3NOa2JsdmEwRmky?=
 =?utf-8?B?SkFYcnBmMGxmdUtweHJReVE5SG9RYnpuR2hkRXk2UVdKckJGTmlwTUVGVjlD?=
 =?utf-8?B?TXhNK09jZE9UV3FYTEJoNXRxM3lOQjREUWVRcWVUNUN5NGZpbVVSUUM3aDRy?=
 =?utf-8?B?VlduZ0tjemk2cm5zVFdLRnJUYldJMFg1MFZ1Ym1tS0QwbzZnZytWSVl5VVFJ?=
 =?utf-8?Q?4c4e+K1ONf4=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 75d2a24f-161a-4bc1-ca99-08d99479506a
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Oct 2021 09:58:21.2124
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jbeulich@suse.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3774

x2apic_bsp_setup() gets called ahead of iommu_setup(), and since x2APIC
mode (physical vs clustered) depends on iommu_intremap, that variable
needs to be set to off as soon as we know we can't / won't enable
interrupt remapping, i.e. in particular when parsing of the respective
ACPI tables failed. Move the turning off of iommu_intremap from AMD
specific code into acpi_iommu_init(), accompanying it by clearing of
iommu_enable.

Take the opportunity and also fully skip ACPI table parsing logic on
VT-d when both "iommu=off" and "iommu=no-intremap" are in effect anyway,
like was already the case for AMD.

The tag below only references the commit uncovering a pre-existing
anomaly.

Fixes: d8bd82327b0f ("AMD/IOMMU: obtain IVHD type to use earlier")
Reported-by: Andrew Cooper <andrew.cooper3@citrix.com>
Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
While the change here deals with apic_x2apic_probe() as called from
x2apic_bsp_setup(), the check_x2apic_preenabled() path looks to be
similarly affected. That call occurs before acpi_boot_init(), which is
what calls acpi_iommu_init(). The ordering in setup.c is in part
relatively fragile, which is why for the moment I'm still hesitant to
move the generic_apic_probe() call down. Plus I don't have easy access
to a suitable system to test this case. Thoughts?
---
v2: Treat iommu_enable and iommu_intremap as separate options.

--- a/xen/drivers/passthrough/amd/pci_amd_iommu.c
+++ b/xen/drivers/passthrough/amd/pci_amd_iommu.c
@@ -183,9 +183,6 @@ int __init acpi_ivrs_init(void)
 {
     int rc;
 
-    if ( !iommu_enable && !iommu_intremap )
-        return 0;
-
     rc = amd_iommu_get_supported_ivhd_type();
     if ( rc < 0 )
         return rc;
@@ -193,10 +190,7 @@ int __init acpi_ivrs_init(void)
     ivhd_type = rc;
 
     if ( (amd_iommu_detect_acpi() !=0) || (iommu_found() == 0) )
-    {
-        iommu_intremap = iommu_intremap_off;
         return -ENODEV;
-    }
 
     iommu_init_ops = &_iommu_init_ops;
 
--- a/xen/drivers/passthrough/vtd/dmar.c
+++ b/xen/drivers/passthrough/vtd/dmar.c
@@ -777,11 +777,7 @@ static int __init acpi_parse_dmar(struct
     dmar = (struct acpi_table_dmar *)table;
     dmar_flags = dmar->flags;
 
-    if ( !iommu_enable && !iommu_intremap )
-    {
-        ret = -EINVAL;
-        goto out;
-    }
+    ASSERT(iommu_enable || iommu_intremap);
 
     if ( !dmar->width )
     {
--- a/xen/drivers/passthrough/x86/iommu.c
+++ b/xen/drivers/passthrough/x86/iommu.c
@@ -41,6 +41,24 @@ enum iommu_intremap __read_mostly iommu_
 bool __read_mostly iommu_intpost;
 #endif
 
+void __init acpi_iommu_init(void)
+{
+    int ret;
+
+    if ( !iommu_enable && !iommu_intremap )
+        return;
+
+    ret = acpi_dmar_init();
+    if ( ret == -ENODEV )
+        ret = acpi_ivrs_init();
+
+    if ( ret )
+    {
+        iommu_enable = false;
+        iommu_intremap = iommu_intremap_off;
+    }
+}
+
 int __init iommu_hardware_setup(void)
 {
     struct IO_APIC_route_entry **ioapic_entries = NULL;
--- a/xen/include/asm-x86/acpi.h
+++ b/xen/include/asm-x86/acpi.h
@@ -141,16 +141,10 @@ extern u32 x86_acpiid_to_apicid[];
 extern u32 pmtmr_ioport;
 extern unsigned int pmtmr_width;
 
+void acpi_iommu_init(void);
 int acpi_dmar_init(void);
 int acpi_ivrs_init(void);
 
-static inline int acpi_iommu_init(void)
-{
-    int ret = acpi_dmar_init();
-
-    return ret == -ENODEV ? acpi_ivrs_init() : ret;
-}
-
 void acpi_mmcfg_init(void);
 
 /* Incremented whenever we transition through S3. Value is 1 during boot. */



From xen-devel-bounces@lists.xenproject.org Thu Oct 21 09:58:45 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Oct 2021 09:58:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.214277.372789 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdUqT-0001rS-2M; Thu, 21 Oct 2021 09:58:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 214277.372789; Thu, 21 Oct 2021 09:58:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdUqS-0001rJ-VZ; Thu, 21 Oct 2021 09:58:44 +0000
Received: by outflank-mailman (input) for mailman id 214277;
 Thu, 21 Oct 2021 09:58:44 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=FF+c=PJ=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mdUqS-0001on-48
 for xen-devel@lists.xenproject.org; Thu, 21 Oct 2021 09:58:44 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 7902b112-3255-11ec-8373-12813bfff9fa;
 Thu, 21 Oct 2021 09:58:43 +0000 (UTC)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2054.outbound.protection.outlook.com [104.47.13.54]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-19-3A4_rDsMN8u2Mt2puvoJBA-2; Thu, 21 Oct 2021 11:58:41 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0402MB3774.eurprd04.prod.outlook.com (2603:10a6:803:1f::28)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.18; Thu, 21 Oct
 2021 09:58:40 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::8062:d7cb:ca45:1898]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::8062:d7cb:ca45:1898%3]) with mapi id 15.20.4628.018; Thu, 21 Oct 2021
 09:58:40 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6PR08CA0009.eurprd08.prod.outlook.com (2603:10a6:20b:b2::21) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4628.18 via Frontend Transport; Thu, 21 Oct 2021 09:58:39 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7902b112-3255-11ec-8373-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634810322;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=XttmN+xWknonju2h1s9l5A0Df7pJEnl/TZUURByJQLA=;
	b=ICeAUAOS4Xu+MNWRlypOGobmnnU2diSrg4UL99ckHmigZustM4noDF960x7cN5X9JSuSZu
	vryTyJrdOTvsH5G1PNLwBEfyFnYI0/aaktU/IFPLAUypnhHwC9L3gVDlJ0v7Pp5IO2gbm3
	TsFLv8teS8CIBZ4U0Rf8GBcjqzwxm6E=
X-MC-Unique: 3A4_rDsMN8u2Mt2puvoJBA-2
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=G5sDVc/gRHT0W+VbZSgFYnJgnt3F90Jo8ksNFR+qzk8wb9TXAkNEHnhigyiX63Yb2d2pJUkkmk3Cu6U7UkCpppExY2UJy4aDkDDM7aK6ePkXTZyfiJSjbxxPBm4yM0s/aYegNANwa7PUNld30tafedR7Y7OywGhGmFgJgb7fODIAPsWcBm49/x5xnNZ/xVSkg0iFDZzyK+D82Gx2sSyHlMxxBQYJdzN6jVimS4tkIvRJzOLOCfpA+rS8BvPiFg2uJB1fIPFwzOrmPAztb2GxgMphds0VFxZc/l4SIfCgEK8/IONVKJQCnK5qL6AVtVfenJtZr0IKl2OiPukBRXi8YQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=XttmN+xWknonju2h1s9l5A0Df7pJEnl/TZUURByJQLA=;
 b=MtlICZTW0X7RUmlsDDoPxdqYuDMHpIgvBeEaQiJQxN+3OgEd/8lz6k9wAJl3e5cQjQPFQ73S6bmD523t4yw4iFJB87W0vJiRBKaAOn8WykAijmdEBvTJHS9TnmFevOPzSICYfaYCc0ycHMkthWVVkc25nRaRLR+5TGPWYx/Jn4KyQPBf0h231IQDO92VAhGUqzYfsCClXUR3XL+kJGsXuJRMQGT2fIqejjpTQ0jZcE15/zqCBg67mATdUWcIhUMXv9COKve9+2nDFnjVnqOY3d9/Y/XidGqu8q420cQa5c3AsRbgYPeDOygv3jGs/m2i9GWc13SE66SfV7/cwU5xLw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Subject: [PATCH v2 2/3] x86/APIC: avoid iommu_supports_x2apic() on error path
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Paul Durrant <paul@xen.org>
References: <09137aa2-649f-08fb-ba68-75f8eb16fc63@suse.com>
Message-ID: <35f9099f-1111-1a66-83eb-bc5a3887f9aa@suse.com>
Date: Thu, 21 Oct 2021 11:58:37 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <09137aa2-649f-08fb-ba68-75f8eb16fc63@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR08CA0009.eurprd08.prod.outlook.com
 (2603:10a6:20b:b2::21) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 26e31da8-ea6d-4ee5-16d0-08d994795ba2
X-MS-TrafficTypeDiagnostic: VI1PR0402MB3774:
X-Microsoft-Antispam-PRVS:
	<VI1PR0402MB3774B884E9208F925C399677B3BF9@VI1PR0402MB3774.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	DreuMRLq0uKsKJbK3ZpSQk/O6eWn9Y/ockkK1m9BKoS2btJBR7XV6jrQITdQJ0NM1EoeVAzPwFlF7Jlrqvvld6aO6mWLm1ta0Cc8K0R/9/xsYzwSzwCt+TQR7+qOXZAx8YX3depEnhb+/C3bV5kGmXWbJOGztWYvLWUY0Zh+rWZl/DvyLWwxampyiNlhbNdqq2QdHvdrJjo6f8gQ4O3Xt5Qs4m2futV5+oOyQdTUS0Wy8pBwBvNuGMjweXj3QMsuk3TjOfYnjifSshruoz5iA7RoNpppSRhLIRoQb3ZhCGuZIMKxviRAVlxfiliuYK2+ZrCQN016Gx/zBkAdNkt4BDwWWu5lGGh/bbgBCeTJG5/jHHz00zfxX8hp5CHZYJyOPmdDyR6DcFTX6N27hqSYWSN93AHVfPc/9mCfXGHtP7D1fAzW5gCnce89wwcyf8LnuJccJ49BH4r5a/bfOrXjdnF3JGkW8v+H4Eeb58SLk9Ju0PVxEWnQbThE+9B+KJjdRBUNxdduErxD2Ov/EDNFD+mdzZC1CiN8C/8L9buyC+Z+cfODPG9VWKLMfGCTZUt0PYLjoRQpaiOdKuknATrEPoI6CaRaF5VIGuF5PFW9yupQDH7X4Ijs7BHir1/9d/2QoJFMlTzbe4HQWzl9YLdSVRFGLJdXIY2V0BSLPQxfKCP70AkkKCsXTnxUVgGNFJNp1XJkCmOzXIKmJfHj0eRHms5ZTWqG1vmBst6hgnWNEn7AlGp2dcw4tEUK2SZuK7eB
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(2906002)(316002)(36756003)(16576012)(83380400001)(86362001)(6916009)(8676002)(8936002)(31696002)(31686004)(186003)(66946007)(66476007)(66556008)(26005)(38100700002)(54906003)(4326008)(6486002)(956004)(2616005)(508600001)(5660300002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?NmtjYzAzcnRQZmRkc1RCdkRWOTVxbEhOQXZ3SWlXaWRKbkdvbEtKbThtSmFj?=
 =?utf-8?B?VXhtOXJaUzYwYUZXOHJHMGU5c1pBaUhMelkySGNuN3cyNk1wREIrU0JRN21R?=
 =?utf-8?B?dzh2enZ5ZDk1V05RYy9weUVmZmtZdkh4NjBwdjM1QmdLMzgxTzYwdTQvR2lu?=
 =?utf-8?B?UCtnMFBtQVJXOWhuODVOU1RQMFY0anpqQnZCSmNnZUpJeFdIT0xGb0dGMllB?=
 =?utf-8?B?dExpWHNsY21veTN0Rm9UcnJVS0prUFZidTgwZk15WWU2dlpxMDYycUJpTVJB?=
 =?utf-8?B?SXRQYWxoZEphU0xxZUVjRkhjcUFTV3ErcDk1eE16WmRkQmsrNXh1S0lvbXJX?=
 =?utf-8?B?MjE4bHJJalM5clB6TkY1MEJJWFI3b3RVb3VIeUZlajY4WVBBVmpOR05JbnVB?=
 =?utf-8?B?Z2VpcHVseTJtdEx1YzlSanVyRnVjeHJMSGplWVBkNXNIWnBNQjBNMXlKMkpM?=
 =?utf-8?B?UExZRDB4ak9zODkvVlMrTndrb3QzNXhDUlZVZlR4U21TelJEaXFRakIydVN1?=
 =?utf-8?B?T1pMQTRzaGFtYUs4clU4RVFnT3NiUlpyc0ltcGxtUHhiNThTbDNpZlRZMlpv?=
 =?utf-8?B?QStyeXZrRUNlclVpQXJEcFI0NFM5N0ZZcjlRRlZRd3g2R1FUQjNEZjNDYVRr?=
 =?utf-8?B?R3djWDdlRERNQXZ4S0phWk1Gc3FFVEFxVVUzQnRkTEF1MjMreFAxdTUrNytS?=
 =?utf-8?B?OG1BT2xUb0NIMmVYMGd0VzJsUGUzQ0prLy9yckljNittNEQwUC9hc1BNS0hh?=
 =?utf-8?B?aXV2ODJwUFNmbmpDNlFQakFSbGdNdWlqV09kcU1pb2pnN0VkVHBYTHowRW1p?=
 =?utf-8?B?WFpDRGhkWTFlV0FrdUluTFhSTTU3dzFWSzJVeEFjWG81NDJIbGFGdlB1N3hP?=
 =?utf-8?B?U1hKUzBIOUptaERoR0U3Qk1zbFZvZi9pR043eDZiMUhlSEpKbVp2UnJ4dGRm?=
 =?utf-8?B?dHdpcnl3RENPcWFuOGhDcHR4cGZWS2xPMFRiMG5aRGR3TEJIVzRGakIyWnV5?=
 =?utf-8?B?OFBVMmRYdFNiSEljMCtGc3BpVEtWbElSaHZ2Uk9PRjFwRVNqb3BNaTBlRTFB?=
 =?utf-8?B?cW5yaHY4b1lTMEhYVElxeVRVMzZETTQ2KzZLUFBVK25Sa0pMdVdnc2JhdEdv?=
 =?utf-8?B?UkpvVWhIRGlsNWt2Ry8rQVhJcGpKdkZKbFZiY3E3eWJFSUl5MERzVDQwNXVR?=
 =?utf-8?B?QXo2NXFaa3dWZis5TG56bEszTEhWYitRUExyQlZmY1UvUHJ5VVFYQnVxbndU?=
 =?utf-8?B?cllkckFpUTFjcWZteFdUM0Q1NWo2UzNvdXo3djA5MFIrSmRqb1lFQW9pOHZI?=
 =?utf-8?B?ZEhackx1VmFZdXZqN2laMlduVDZySE9vZTRLZDlBZkpuYXVIeXFwRGd4WHlm?=
 =?utf-8?B?Qk9iVXljNk1uazVxMTlzbUpqQk13OGRNS2RkZFFPTW1kU0h4TzhIOW5pTkJJ?=
 =?utf-8?B?SG1ESkwrUmRqM2VrRXlsL0FtMzErWFBvUE1JcmlQYld2Zi80SzNoMk5oTjZy?=
 =?utf-8?B?T0J4c09ZaFBmdWFOek9LWHFoNkp1OVdGUWs5ZFpXL1BDMGtXbWNNWjQxQnlZ?=
 =?utf-8?B?WWlMWThxcFhkbk92T0toWFdhRVlsTng0SEwxVXFIamk5bUl5Y3hOT1Z2bkNO?=
 =?utf-8?B?NmM1UVVvc1RvRlhJNDRGU0V5anZkTzBERXhmV1R4OHk2VUpuSUs5aHVtNDVK?=
 =?utf-8?B?cy9kM3lYaXk3dU5Ca0hHTWN6NEhiRzdRMUc4VTAwa1dLSnkySm1ibVpiQWVV?=
 =?utf-8?B?d1UrNFhHYnEzYmRNSVRoaWFBazNJUHF1MTh4SklDOWwyWS9NbVQxTHUxVkRM?=
 =?utf-8?B?aVdtekRHbHg0dENUOUVNbFNxeldxakxOSnNiVzZnNUtleG1tSzFlRVEyaEJE?=
 =?utf-8?B?UEM4djcvcThGdEVVczEydnR1NkFwWFl6UkUzcXVFTzhwZDl0dVJoRkUzeWNl?=
 =?utf-8?Q?o4njLMN6qgA=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 26e31da8-ea6d-4ee5-16d0-08d994795ba2
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Oct 2021 09:58:40.0148
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jbeulich@suse.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3774

The value it returns may change from true to false in case
iommu_enable_x2apic() fails and, as a side effect, clears iommu_intremap
(as can happen at least on AMD). Latch the return value from the first
invocation to replace the second one.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
v2: New.

--- a/xen/arch/x86/apic.c
+++ b/xen/arch/x86/apic.c
@@ -865,6 +865,7 @@ void x2apic_ap_setup(void)
 void __init x2apic_bsp_setup(void)
 {
     struct IO_APIC_route_entry **ioapic_entries = NULL;
+    bool iommu_x2apic;
     const char *orig_name;
 
     if ( !cpu_has_x2apic )
@@ -880,7 +881,8 @@ void __init x2apic_bsp_setup(void)
         printk("x2APIC: Already enabled by BIOS: Ignoring cmdline disable.\n");
     }
 
-    if ( iommu_supports_x2apic() )
+    iommu_x2apic = iommu_supports_x2apic();
+    if ( iommu_x2apic )
     {
         if ( (ioapic_entries = alloc_ioapic_entries()) == NULL )
         {
@@ -933,8 +935,11 @@ void __init x2apic_bsp_setup(void)
         printk("Switched to APIC driver %s\n", genapic.name);
 
 restore_out:
-    /* iommu_x2apic_enabled cannot be used here in the error case. */
-    if ( iommu_supports_x2apic() )
+    /*
+     * iommu_x2apic_enabled and iommu_supports_x2apic() cannot be used here
+     * in the error case.
+     */
+    if ( iommu_x2apic )
     {
         /*
          * NB: do not use raw mode when restoring entries if the iommu has



From xen-devel-bounces@lists.xenproject.org Thu Oct 21 09:59:12 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Oct 2021 09:59:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.214286.372800 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdUqu-0002SJ-BI; Thu, 21 Oct 2021 09:59:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 214286.372800; Thu, 21 Oct 2021 09:59:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdUqu-0002SC-87; Thu, 21 Oct 2021 09:59:12 +0000
Received: by outflank-mailman (input) for mailman id 214286;
 Thu, 21 Oct 2021 09:59:11 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=FF+c=PJ=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mdUqt-0002Qg-1H
 for xen-devel@lists.xenproject.org; Thu, 21 Oct 2021 09:59:11 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 890c88ee-3255-11ec-8373-12813bfff9fa;
 Thu, 21 Oct 2021 09:59:10 +0000 (UTC)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2057.outbound.protection.outlook.com [104.47.13.57]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-36-J4x-Q08RPByWWDtzEK-TnQ-1; Thu, 21 Oct 2021 11:59:08 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0402MB3774.eurprd04.prod.outlook.com (2603:10a6:803:1f::28)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.18; Thu, 21 Oct
 2021 09:59:04 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::8062:d7cb:ca45:1898]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::8062:d7cb:ca45:1898%3]) with mapi id 15.20.4628.018; Thu, 21 Oct 2021
 09:59:04 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6PR08CA0030.eurprd08.prod.outlook.com (2603:10a6:20b:c0::18) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4628.16 via Frontend Transport; Thu, 21 Oct 2021 09:59:03 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 890c88ee-3255-11ec-8373-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634810349;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=S8lycJUP12YSt6T5Wbpdmvdqu/DvfiQPPEOn+K5M3nA=;
	b=IXqIs+exvPtL2HhYrq8563G5iKP1ZXqQUTQdi/pJ9ueQadwubyA6jyeaCuKXeqKMlbG7xp
	p4K4JSgWmz1va+75EK780voI0yRaLSOfycJDTK+uvNeSyEZLExUYrul2eO0VbVgxcNjGkL
	0s1TVCSqD1MLmDpb6rhY3HTUAzVdY14=
X-MC-Unique: J4x-Q08RPByWWDtzEK-TnQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ZkknbpGdIEQPi/2D1frYSL30GnGufGxoJ1iLCZs/EyQlaQjZ+/6pMdlH5tBzPNDdlyj4YED4rrOmbfoO+1B5nQRKA9FTFuW19mQ4CtGxbY2g2cJrUq/hSnIm1wtigNzqZUQn2JSOIXo7qUiMK9V/tEPhTx9yaCHrStNdnAO5ptDzy5WhlXWjHmSgElLk3Jq0JwWnMDbE87fXRG406q5pFw17lkxe2q9Ztr1WVqCPTafrp2ihtotg+Q+OQxXuF1YIsSmhmwpAPBOdcpDQia0GBGJHRX0Aert5/cRirUpIf9i7SIZ2ibpwExCZLgW9BZ5ZbYgxSQHxzQYbxESRi/8ldw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=S8lycJUP12YSt6T5Wbpdmvdqu/DvfiQPPEOn+K5M3nA=;
 b=ecIZgMieWg7NVgTYkd/T5d78nEJtd9L2Srti2Ft8KJ13l0jiSzjHsmETA5ufbyt02HhuiwMRzp4w76qnaW3Zp9yp3QM9rwYwTl5ZZnesPROJkj2Qb+04ddTHDrQqzTZMQR72mCxPSLy9CjOfUSAPw7M7enHXwEs4C4+awKPVJXinsLMqZVFffdFPA26OC4Z2heKVtwUVfllcBGVCsW9lgOtMGzFe6TjeHIvrYOeFk1i4hPAIx4SoqsfwuxpZSMF4QqE0G1eF5SkpKG26+Ch8KE9FWcsH45hlSoudNuPOQPQLKqZx6WRw/7Py4tsfy+EYnxhmDfVEZooq35tpeACzJA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Subject: [PATCH v2 3/3] AMD/IOMMU: iommu_enable vs iommu_intremap
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Paul Durrant <paul@xen.org>
References: <09137aa2-649f-08fb-ba68-75f8eb16fc63@suse.com>
Message-ID: <ff7b68b2-5bba-2927-e3f0-f3062862c466@suse.com>
Date: Thu, 21 Oct 2021 11:59:02 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <09137aa2-649f-08fb-ba68-75f8eb16fc63@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR08CA0030.eurprd08.prod.outlook.com
 (2603:10a6:20b:c0::18) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: c195caa6-bb85-40d0-3d39-08d9947969fb
X-MS-TrafficTypeDiagnostic: VI1PR0402MB3774:
X-Microsoft-Antispam-PRVS:
	<VI1PR0402MB37745852517AEAA7DC615C2BB3BF9@VI1PR0402MB3774.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	ZPm5fOAi8XkcSh1CGGBD7Ni6F8RstVm148CF8bltNoqexU/0aAJ/1a449cgo6eHo51UvHbLNDXpSwKv/t8WgcEbB0/KnmARaLpRlLvRFbCwAb8laPqjpxTAgdU4csod5qIVbKGCbLRGJoHX4MWRifVmWAfgrZZUnwdbeGF34cATfEYtIk/WDqQQPGSG+72mcU874nVE6UQuJ8E4laD2C+RmF6OZw01PK3KewgMymH/0Y06SMbKARgp5R/JV2kNMJN66X4zxOQ50KVykcUKlmVYmllWKbxgFG8BvRm0qqQ3mUtj9tr861cSwjNA/BTKs+/u/xn+gPCJvgP7/7WR0OhN155NDGcl568v2LhX7QVaYlCxZPcq3QFHv1W9fXKX3kXDMcY0TSx8mJca5C2JeKi9J9VtVBjPL6xGP+14umIK2dH6Cw4yC73SmAgoaSpCHG1B31OBIQ7pR251TlJIW3MXQGvEcYCFEbnxhArQgitbdfopkNq/Vg74SmKngmrXEIpKne/v2V81tozO/lg0RWoCxzC0lN9I7aQLgh6opRoWVI2VnsTJCqjkMOqlv/7NICRmggfpp01buSlPM+jQRlHFVmz/8Y01zVqenf4g+Aj0E0NtD82MZ7F8l7zqQCZZPRany+YOJk5tEYjk4ncqMH8WBwj4S6OnvtyIPhq8a0OQWELrE22gRoq7G6NBt22iXwsXWw019DQeJy6WdvLfJXL8l5+FcgM4hUmFaZKHHv664=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(2906002)(316002)(36756003)(16576012)(83380400001)(86362001)(6916009)(8676002)(8936002)(31696002)(31686004)(186003)(66946007)(66476007)(66556008)(26005)(38100700002)(54906003)(4326008)(6486002)(956004)(2616005)(508600001)(5660300002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?dDBKdHJUOFMwZ2dvTEFGWW1mb0FXK0JqQ1ZSOHRMUHhTQjNQZUQ4MlVOdTdu?=
 =?utf-8?B?dHMvTU1qNVNSM0Zwa1ErNU9MT1FBay9PWUp1OVZZZVA1aVRSOWZ0ZldLVjVn?=
 =?utf-8?B?eFQ0N2tFWUlUTCs3bFdKbVVjRkFmNDludzlBQ3lZMHhVdTRIQlJ4cXVEVmxB?=
 =?utf-8?B?TWUvSE4yUVlYSThwR0F2MjByNE9FQ1dDTlFMZTRvb25acG45dEg5ZlVYdFlN?=
 =?utf-8?B?aUptbmV1eHVabksvaUtRNlpEcWtMNUhQTTNKejVFbTQzckhEdWpWbHFBS3Vn?=
 =?utf-8?B?VkFRQnlJY1BDTExqZGRYVFhMd1k2UGhBQUZQcTV6MTNKM0lQRUpVaFd0M3RI?=
 =?utf-8?B?bGM1V09RLzZ6L2JmT082ZkhKVWROdkNCUGZBMytJMnU2NDNuK2JZWXA0d1ZW?=
 =?utf-8?B?WjlEQUNrSTV2TnoxN2p5RGp5bzFRNU1qOHBucHd0SjliNkEzUVU3MU5NOUp4?=
 =?utf-8?B?N1A4d0UxeGxqbkdZWGRrbVMyMUxhK3d5bmJZcEpab212ZmhBUUR2RkxISjEx?=
 =?utf-8?B?ajRhbUIvWWUzNVNYWmVIaEVSLzVYQktpZ09FZkpHMFpZWU1mQW5wYjlFbkc3?=
 =?utf-8?B?b20yb1lIWDZLWExLeVFKVWJiRDhWS1d6MVF3Z1hkcEllWk5lcG1wQi9xamQ1?=
 =?utf-8?B?SGJJRFNIc0tLNDBNNDQ0SWFTRkNvOXRhV2Y3K3lmVHhPN0tBWklhY2o5a2ZB?=
 =?utf-8?B?clZPNGY1VENVeEhrWmlGNUNoUkI0bmlOM0ZUdnpyZldNTkdSRXFlYTdyQ29l?=
 =?utf-8?B?Z293bldDVWpReGlFdHpialVVZjRPUFpNYS9yeDROOFZHdDhXangxRTE2Si9p?=
 =?utf-8?B?OG5MYWQ0SlhWTTVuNloveU41bk9ib0ZUeGtOalRtOEE2Q01ud2wrODRaaXc5?=
 =?utf-8?B?Ly9tZUdWYXdzZGxxbEtVQlVlVWIxVFZhWlZvRitPWGtxN3RRbmlyYnUzUUh0?=
 =?utf-8?B?Smwvbm11eEh5YlcvcTRvV3VBQ1poV09Ta1I5TExNSlhhRHZVUktiVHIrZUNu?=
 =?utf-8?B?MU9VN1hpQ2dNWWFqN0I4NS9uWlQvM1pGQndOenlmSEI2TGZNdnlXbFo5ZjF5?=
 =?utf-8?B?eG1JdG5lTWNWL3VlbUJXTGU3SVJpSWVFTjd0R1pWdUhvbDFXd1oxa2RjOXRK?=
 =?utf-8?B?WnZEWXhPemw4TnBFQkxrZU9Gd3pqc2hOVnNXQ09VQlZDTnBaL2VKNXU5UXR4?=
 =?utf-8?B?R3FmY1dablZOS0Y1NktNUE01cjVCSTVVNEErbEZJNDBWaXlZWS9rVUpTNVkz?=
 =?utf-8?B?KzNKQ1I3dStiZTNuUzhLeWpzUmM4MWxQcUVmYUk5bnlIUEl3bnVqYXRuRmZC?=
 =?utf-8?B?VXptTExtVXpqN0Jvb1ZKTnFqZ1N3d29sNmthTW45aXdFdUVVNDJkU0MzSVFV?=
 =?utf-8?B?V1lYSlROUGhuVVBHVEg2Zi9oNmVxOVpFbG85blZFczNLWmYrMU9sM0oxdFJn?=
 =?utf-8?B?bnpwSFcwKy94V0JPYlRGWTYxajlndzlWeWlqR1BDYVhFVDIrV0JUZmtWeEU5?=
 =?utf-8?B?NEZJZkdCQm4vY005UG5rWXU2R0dzRUhqYmlISlRJQVJvSDJFazkyWmFUaHN0?=
 =?utf-8?B?Ty9zNnd1b0hmZW91bzdlb3JUNmV2Q3NBVnJISjN1TkFVcXhDZFJ0ekNlZnQ0?=
 =?utf-8?B?Y0NnK3pNZ0VZZEpxc25OUUZKd0FDYktlWWZIa2JwZXhsNDV3MzRTSEdTWXdq?=
 =?utf-8?B?VzF1V1VqYmlMK2ptVmhwZmVJdTJnS0R3S0VlQzB6eS9WdDRTZUdqQnk0bXdt?=
 =?utf-8?B?NjhXZWxSNmVyNFY3TngzL2dyL2JZaHRybi9JZUgxYTE2dXBza0pOT0lXYTUr?=
 =?utf-8?B?UkR2ZkZ3blRHR2l5cG1hWGtIZUQrU1FVWHJDaWJOM0NlQVZYc2EzTzhUV2VC?=
 =?utf-8?B?QTZTNVYrTGpuOVBMekNYQ3BXVVJzT2JmRHowRTI3eHpVcXNDcG44ODFWM0s2?=
 =?utf-8?Q?vakPb+9bRz0=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c195caa6-bb85-40d0-3d39-08d9947969fb
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Oct 2021 09:59:04.0651
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jbeulich@suse.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3774

The two are really meant to be independent settings; iov_supports_xt()
using || instead of && was simply wrong. The corrected check is,
however, redundant, just like the (correct) one in iov_detect(): These
hook functions are unreachable without acpi_ivrs_init() installing the
iommu_init_ops pointer, which it does only upon success. (Unlike for
VT-d there is no late clearing of iommu_enable due to quirks, and any
possible clearing of iommu_intremap happens only after iov_supports_xt()
has run.)

Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
In fact in iov_detect() it could be iommu_enable alone which gets
checked, but this felt overly aggressive to me. Instead I'm getting the
impression that the function may wrongly not get called when "iommu=off"
but interrupt remapping is in use: We'd not get the interrupt handler
installed, and hence interrupt remapping related events would never get
reported. (Same on VT-d, FTAOD.)

For iov_supports_xt() the question is whether, like VT-d's
intel_iommu_supports_eim(), it shouldn't rather check iommu_intremap
alone (in which case it would need to remain a check rather than getting
converted to ASSERT()).
---
v2: New.

--- a/xen/drivers/passthrough/amd/iommu_intr.c
+++ b/xen/drivers/passthrough/amd/iommu_intr.c
@@ -731,8 +731,7 @@ bool __init iov_supports_xt(void)
 {
     unsigned int apic;
 
-    if ( !iommu_enable || !iommu_intremap )
-        return false;
+    ASSERT(iommu_enable || iommu_intremap);
 
     if ( amd_iommu_prepare(true) )
         return false;
--- a/xen/drivers/passthrough/amd/pci_amd_iommu.c
+++ b/xen/drivers/passthrough/amd/pci_amd_iommu.c
@@ -199,8 +199,7 @@ int __init acpi_ivrs_init(void)
 
 static int __init iov_detect(void)
 {
-    if ( !iommu_enable && !iommu_intremap )
-        return 0;
+    ASSERT(iommu_enable || iommu_intremap);
 
     if ( (init_done ? amd_iommu_init_late()
                     : amd_iommu_init(false)) != 0 )



From xen-devel-bounces@lists.xenproject.org Thu Oct 21 10:53:20 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Oct 2021 10:53:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.214317.372810 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdVh1-0008Q0-EN; Thu, 21 Oct 2021 10:53:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 214317.372810; Thu, 21 Oct 2021 10:53:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdVh1-0008Pt-BT; Thu, 21 Oct 2021 10:53:03 +0000
Received: by outflank-mailman (input) for mailman id 214317;
 Thu, 21 Oct 2021 10:53:01 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mdVgz-0008Pn-Dh
 for xen-devel@lists.xenproject.org; Thu, 21 Oct 2021 10:53:01 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mdVgz-0006kU-Cl
 for xen-devel@lists.xenproject.org; Thu, 21 Oct 2021 10:53:01 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mdVgz-00058V-Bx
 for xen-devel@lists.xenproject.org; Thu, 21 Oct 2021 10:53:01 +0000
Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89)
 (envelope-from <iwj@xenproject.org>)
 id 1mdVgt-0006gy-To; Thu, 21 Oct 2021 11:52:55 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date
	:Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From;
	bh=chQm04WUmNUJCVLYeJBbFUJnNx5E3mZlW7cQra395ns=; b=18f68ryq6o5yWbvldJ79ZR1kYm
	51Ei7OYFTbDU9tBWqrdg4cXv1zDvpRRZrivzk4JqJ3Wp8UCH8ZBplH0LERF5AaolCrbn6Rm1dSNTa
	iIju3T/BhZI7WPRwevSvViBdVkOJyNf30pEjHfH7VJjuns4JRu4PHvhoyakKfoldKmas=;
From: Ian Jackson <iwj@xenproject.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <24945.18055.505918.627159@mariner.uk.xensource.com>
Date: Thu, 21 Oct 2021 11:52:55 +0100
To: Luca Fancellu <luca.fancellu@arm.com>
Cc: Julien Grall <julien@xen.org>,
    Xen-devel <xen-devel@lists.xenproject.org>,
    Julien Grall <jgrall@amazon.com>,
    Ian Jackson <iwj@xenproject.org>,
    Wei Liu <wl@xen.org>,
    Juergen Gross <jgross@suse.com>
Subject: Re: [PATCH for-4.16] tools/xenstored: Ignore domain we were unable to
 restore
In-Reply-To: <01870077-5FE4-45D8-9716-B81C0A705DC0@arm.com>
References: <20211020144519.10362-1-julien@xen.org>
	<01870077-5FE4-45D8-9716-B81C0A705DC0@arm.com>
X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu)

Thanks everyone, committed.

Ian.


From xen-devel-bounces@lists.xenproject.org Thu Oct 21 10:54:52 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Oct 2021 10:54:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.214323.372822 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdVil-0000YY-Rc; Thu, 21 Oct 2021 10:54:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 214323.372822; Thu, 21 Oct 2021 10:54:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdVil-0000YR-NP; Thu, 21 Oct 2021 10:54:51 +0000
Received: by outflank-mailman (input) for mailman id 214323;
 Thu, 21 Oct 2021 10:54:50 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=FF+c=PJ=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mdVik-0000YJ-Qz
 for xen-devel@lists.xenproject.org; Thu, 21 Oct 2021 10:54:50 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 122aff75-c86c-4155-b20d-b25441f06cdd;
 Thu, 21 Oct 2021 10:54:49 +0000 (UTC)
Received: from EUR02-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur02lp2054.outbound.protection.outlook.com [104.47.5.54]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-17-FcdElh5cOECQ090-z0-Qtw-1; Thu, 21 Oct 2021 12:54:47 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB4349.eurprd04.prod.outlook.com (2603:10a6:803:40::27)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.17; Thu, 21 Oct
 2021 10:54:45 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::8062:d7cb:ca45:1898]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::8062:d7cb:ca45:1898%3]) with mapi id 15.20.4628.018; Thu, 21 Oct 2021
 10:54:45 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6PR05CA0019.eurprd05.prod.outlook.com (2603:10a6:20b:2e::32) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4628.16 via Frontend Transport; Thu, 21 Oct 2021 10:54:44 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 122aff75-c86c-4155-b20d-b25441f06cdd
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634813688;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=AVFV0JJo0REmloxEXJk+jf3B2HhXTqY2T7rLcRdYZ+8=;
	b=jElzHR8KYIEbj7ammq7oFPnzkZExCBBuqFkzLLQVrlZ9laDP8LLHEVAwWBsmvoDR1HxOzV
	sA4yB9x31TupyBaWXHnSdClTvC5tCpbbSMUhb1x/VbhCLgJ203gM2Cze4RjCggmVxmbOFN
	BpRnfvmH1ghL4Cqhg4UVXpW0LgzMm+w=
X-MC-Unique: FcdElh5cOECQ090-z0-Qtw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=f1z1Ehy2JSRYPXVxHWslaZnRm2BIVpGTTBHGs54qSf8mZivc9gEiEMky5htyYSbNosGyAsK0dwQIgME86Y/61vT9wSq67Yj4fhhjEakfoq702uuMGh7O88DueN7uA74gtWXEbSCnpjGavcieyxyVRQwhHrgEwSeXzNu4Jb/nu0XPF37M79LD9ZTs150mgZTgHFskZSNg634C9HoB4wr9f/hXRIK44tdIEfTSEaLQs/MYSi93OG45srPu7G/wD5Ipo1zyF7iaCkIGz1snLCHxYFrCMvBX854fbqTpoAsuuVcJeDevwLxg7FvMaA8kOjsOUOQmnu8gz6Q9C9JoDzeYSg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=AVFV0JJo0REmloxEXJk+jf3B2HhXTqY2T7rLcRdYZ+8=;
 b=ajg7zX7Hi8uNzEiH+vX9HOy3rclYsFBPFd4ZCPc80Tn0p3NlOt2pAkpIZrefI1S6f0idiJK2Idrb7LrtGqiaRk3bJo+on+KS6sGLJ704mhJ3M1EI68X7tqvkzzmNcliJ7Jx4ysocUybxJtOymT2iQ63WnyaIh6HBhwagApiVGl/BVcKdmi6fg7xS2u5Que79fKne/TH5fX7tfdTGcWV5sUsJeHcooreH+x+y5tDyN8VxtHXiIlvYg0GdPFAdCUM+oGq4HAyk2VU2Nc2/Nrglokc/kiuiIe3235t/lelFoWcCgaJMU3GXM0g+x/UHzpi+TvADmocMP5Iy/RmylK6LWg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: citrix.com; dkim=none (message not signed)
 header.d=none;citrix.com; dmarc=none action=none header.from=suse.com;
Subject: Re: [PATCH v4 1/6] x86/PVH: improve Dom0 memory size calculation
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <cbdc93a6-e675-420c-f7e8-53aa407766ba@suse.com>
 <4684f314-2c4e-f662-bd4e-132be001da9e@suse.com>
Message-ID: <efc20786-5873-4b28-7977-577d6bd99167@suse.com>
Date: Thu, 21 Oct 2021 12:54:43 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <4684f314-2c4e-f662-bd4e-132be001da9e@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR05CA0019.eurprd05.prod.outlook.com
 (2603:10a6:20b:2e::32) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 9e51e1ad-c3d5-45df-a1d8-08d99481317b
X-MS-TrafficTypeDiagnostic: VI1PR04MB4349:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB4349897053C3B1FC4470CA7DB3BF9@VI1PR04MB4349.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:923;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Bb6+sMBLX1kQQei+EM+hqPuPgr6SQvr+zPR0xpAy7DTX8rmXdq6Ol3Q5mcon0T5uEMTDqBg16I5d22m9OGCYw1yo+ndd0w6L2fctskb2t1EaGCMuhB5J5LbwPLr8Rh6R854vJ5TUY37luFLXk26jjDd2jq/GfXrByvZ9ej823rZMiDjiLN/V1eLYYZD/OHUCJXU2bpTpPvPH/K2lmEUjmu4xOthRjHEIUChALloARi1CHi7gjBIChM/SH/qsL6b+2Tsvzolbyws1iQRxBFHUfMIMqFTiLtr7KQWf16+DaQeXwh7sdbGFrVzgK9QOTJW2Hrige/JJVQcfqeuPg5ZbJEU1xPWwCjY+D/KQ1S5xiWZo9ry6h6UvylzvCs/e4dZ/hA//1GQgD1ZVEAZLgZ7CIUhBsa+Bl947FjN9mVtDfi/vYwuiTmSdPRljCgYGqCpxUC+UNU3o2oToj1oPmf5I9xuSfPaZhZ1t8goe6J5lI1pX905kXso8EVtu9QI0Ap+5Z5WNQbcLozzEuHoDtCwvkxKBedV0WmHXiFbriUtIm638hxq8q5xtrfWiKXF6zEd1jFZXnfceX70TcOX21LtXbR6+q+Uw2a+bz7tb2w/6/4EvGwyNSiOiwglD3rhnHNcQNAbio7Wivx+0tSjPxaK2RuCiI5tLLi1CUh6X31RoR2cnnSVAwXZwSlNoQbWx/RgVn9VWhE44w2Yd/ps6qOJS9e/673fJSFwDrcQb25mWPDCV0zTxSdzZ98RNqlnEDugy5L563Zrv07U9EzP2/FJGOg==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(8676002)(316002)(38100700002)(16576012)(54906003)(4326008)(66946007)(6916009)(66556008)(186003)(31686004)(2906002)(53546011)(2616005)(8936002)(66476007)(508600001)(5660300002)(83380400001)(36756003)(6486002)(26005)(956004)(31696002)(86362001)(25903002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Q3ZIemppYk5hL1ZsR0RudUFuVnFtNFllR0h6eFZQd0UwOXN1Tm81UmxzVnRx?=
 =?utf-8?B?YlVCbkQ5cTduVTlZUjV4SEE4ZFNGUGJ5OTVsckN3cG51U0ZLV2hWQ3gzQnZH?=
 =?utf-8?B?ZkUwZHF6OVdoTW90aUY4SFJKMTJBUUsxRHdtamtuQ0g3UHVsM05TaWVSN1ov?=
 =?utf-8?B?YmhQZVpKVzNDdk9yQ0xCRFNRNXFoa1ZJYTBLdmtiNWtPQ0tsVjNTR096MGxR?=
 =?utf-8?B?bnNoV2R2T2RMWmhiUUlkUUhTSlpmQnFhRnlYeEU0NFZRK1g4UUszVkhtY0Vk?=
 =?utf-8?B?TWZoOXpSbmZzYjVxV0tBNUhCQmdQNVEwTEZOR04rbGR1OTNaaTB1ZWlkWVEw?=
 =?utf-8?B?akt3ZU1GaTZnQy9qVW9sZjIrTkdaRGhyUTR2eC9waE5naXNFS1NCd1ZjbS8y?=
 =?utf-8?B?VlhNWDkvdU92TnRvN2FzdkJSTURXYkZ0YWJsYU1mTnNVYUpGNGNpamVObzdV?=
 =?utf-8?B?eDV6SHRxY0VzMFhNTWlJUHhzdDN6b1lCSjFZNXBoZFAxTW9wcWZLalhIczhy?=
 =?utf-8?B?STBvSGdjTEtsVms4SEpyMFkvdG1iU1BOZjBtR1lDZTV0TGl2MjhScGJES2Z2?=
 =?utf-8?B?Q29UcW5yY1VpV3N6VlBmSnpVYWEzYUJiaGR4QTZOdGFhV3BjYldnaXFWU1d2?=
 =?utf-8?B?a1U5T3VocnFjSGxlWmtiZkNaaWQ1eXVPYXRYcndBL2pTWFpnMVovR3FDSkhj?=
 =?utf-8?B?OThIWUtWRkFwaHUxcHhubklzRnc4WXdqKzAzZGJhUEp4d3dIdnJ5NytvYnR3?=
 =?utf-8?B?Ylc3QlA0eVVtOGlmeEQ0ZFZiWmkzNGt5RmhQTlVqelBFTzBuaHovTDhYaEM5?=
 =?utf-8?B?TXVZdTgrc1pDQkJWUFZVdEcvL0F0TmlhbVFXd1A4bldWdTJxU1YxQTk3UkdH?=
 =?utf-8?B?N1dhNmpkNHlHd0lXQlBOd3dWR0UzWVVPektjbHNvWXo2YXROK1BZRlhnV1Zj?=
 =?utf-8?B?QWRwOHF2QlRPb2grS25XN2dyRGxFeWZoMTloUEJLTlNBNHdVZE0xWm9tS3VR?=
 =?utf-8?B?UzkxVE1UTXZDcTcvMzFnN3QrMjl0ZEhrUTJ5WUM4Z0JNUGl6V2JoT3dGSlM2?=
 =?utf-8?B?czRGa1c2cTJsSlZLdmgwQ2lDUEpsMG5HUGMrUW1mSmJIN2FrMFBsKzZXQTBS?=
 =?utf-8?B?WkVsTC9QVWczaWFWS2hyVVNBNWV3L1NjZmNEM09NYk5OL2FrRW9FWkt4S0ho?=
 =?utf-8?B?TVVzNkh5TFBpeXlXY2EyMG9Cem1NRzRwSFlBcTZ6a3VVQWZTYlRTOU5YTjZn?=
 =?utf-8?B?WlYzbkFSOXpiSmZNYzUxdklLR2R3RUFLTk1CaThYMmRxdkxuZHdsSHlKYmVN?=
 =?utf-8?B?Sk5ISTRydVAyVlg1eVVmTUpORk5QNDBrTXg5dFNRYm1nTnc4bmVmRCtiQUha?=
 =?utf-8?B?VVErYVQyUStuNTVaYkt1MGMydHB5empoc21QNDg2V0twVmFYbHArSXVzZjU5?=
 =?utf-8?B?MFVwSHNyU0lWc3g1T2krQllSeUswOHhxM2lmSG40SzJ5NTByTUREdXpDTnpM?=
 =?utf-8?B?dzlRWVFrb01MY2IxbG1IUGhZcE84WEtFTVM1YW1YRFpIaTdjWDBsN09KbG9N?=
 =?utf-8?B?QW5qVkR1U1luSjRoRUZiQ1RHTjZqTmUzNFg5dm9kNWU3aENlb0ZBTVE1R3NH?=
 =?utf-8?B?cGxkdmtUeEVZMnp3NzFIQW13TWp3eG1QVlFHc2EvUDVaU1p5Q1pwcUZLbkNm?=
 =?utf-8?B?ZUFTWE15T25Zb3FZM090djF1ZnhPbUZCZHJRdkZudGZjWDJReHQvMCtzT3lQ?=
 =?utf-8?Q?Un736UUTCowPM2JBCNMZB65KislEbIp1RNHRrqa?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9e51e1ad-c3d5-45df-a1d8-08d99481317b
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Oct 2021 10:54:45.3082
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jbeulich@suse.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4349

On 29.09.2021 15:13, Jan Beulich wrote:
> @@ -337,53 +336,65 @@ unsigned long __init dom0_compute_nr_pag
>          avail -= d->max_vcpus - 1;
>  
>      /* Reserve memory for iommu_dom0_init() (rough estimate). */
> -    if ( is_iommu_enabled(d) )
> +    if ( is_iommu_enabled(d) && !iommu_hwdom_passthrough )
>      {
>          unsigned int s;
>  
>          for ( s = 9; s < BITS_PER_LONG; s += 9 )
> -            avail -= max_pdx >> s;
> +            iommu_pages += max_pdx >> s;
> +
> +        avail -= iommu_pages;
> +    }
> +
> +    nr_pages = get_memsize(&dom0_size, avail);
> +
> +    /*
> +     * If allocation isn't specified, reserve 1/16th of available memory for
> +     * things like DMA buffers. This reservation is clamped to a maximum of
> +     * 128MB.
> +     */
> +    if ( !nr_pages )
> +    {
> +        nr_pages = avail - (pv_shim ? pv_shim_mem(avail)
> +                            : min(avail / 16, 128UL << (20 - PAGE_SHIFT)));
> +        if ( paging_mode_enabled(d) )
> +            /*
> +             * Temporary workaround message until internal (paging) memory
> +             * accounting required to build a pvh dom0 is improved.
> +             */
> +            printk("WARNING: PVH dom0 without dom0_mem set is still unstable. "
> +                   "If you get crashes during boot, try adding a dom0_mem parameter\n");
>      }
>  
> -    need_paging = is_hvm_domain(d) &&
> -        (!iommu_use_hap_pt(d) || !paging_mode_hap(d));
> -    for ( ; ; need_paging = false )
> +    if ( paging_mode_enabled(d) || opt_dom0_shadow )
>      {
> -        nr_pages = get_memsize(&dom0_size, avail);
> -        min_pages = get_memsize(&dom0_min_size, avail);
> -        max_pages = get_memsize(&dom0_max_size, avail);
> +        unsigned long cpu_pages;
>  
>          /*
> -         * If allocation isn't specified, reserve 1/16th of available memory
> -         * for things like DMA buffers. This reservation is clamped to a
> -         * maximum of 128MB.
> +         * Clamp according to min/max limits and available memory
> +         * (preliminary).
>           */
> -        if ( !nr_pages )
> -        {
> -            nr_pages = avail - (pv_shim ? pv_shim_mem(avail)
> -                                 : min(avail / 16, 128UL << (20 - PAGE_SHIFT)));

Just FYI that I've noticed only now that moving this only up is
not enough; the same also ...

> -            if ( is_hvm_domain(d) && !need_paging )
> -                /*
> -                 * Temporary workaround message until internal (paging) memory
> -                 * accounting required to build a pvh dom0 is improved.
> -                 */
> -                printk("WARNING: PVH dom0 without dom0_mem set is still unstable. "
> -                       "If you get crashes during boot, try adding a dom0_mem parameter\n");
> -        }
> -
> -
> -        /* Clamp according to min/max limits and available memory. */
> -        nr_pages = max(nr_pages, min_pages);
> -        nr_pages = min(nr_pages, max_pages);
> +        nr_pages = max(nr_pages, get_memsize(&dom0_min_size, avail));
> +        nr_pages = min(nr_pages, get_memsize(&dom0_max_size, avail));
>          nr_pages = min(nr_pages, avail);
>  
> -        if ( !need_paging )
> -            break;
> +        cpu_pages = dom0_paging_pages(d, nr_pages);
>  
> -        /* Reserve memory for shadow or HAP. */
> -        avail -= dom0_paging_pages(d, nr_pages);
> +        if ( !iommu_use_hap_pt(d) )
> +            avail -= cpu_pages;
> +        else if ( cpu_pages > iommu_pages )
> +            avail -= cpu_pages - iommu_pages;
>      }
>  
> +    nr_pages = get_memsize(&dom0_size, avail);

... is needed here, or else things won't work e.g. without any "dom0_mem=".
I'll introduce a helper function ...

Jan



From xen-devel-bounces@lists.xenproject.org Thu Oct 21 11:04:05 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Oct 2021 11:04:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.214334.372837 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdVrb-00027U-Qr; Thu, 21 Oct 2021 11:03:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 214334.372837; Thu, 21 Oct 2021 11:03:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdVrb-00027N-Nm; Thu, 21 Oct 2021 11:03:59 +0000
Received: by outflank-mailman (input) for mailman id 214334;
 Thu, 21 Oct 2021 11:03:58 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=JnKy=PJ=citrix.com=anthony.perard@srs-us1.protection.inumbo.net>)
 id 1mdVrZ-00027H-Sk
 for xen-devel@lists.xenproject.org; Thu, 21 Oct 2021 11:03:58 +0000
Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 8b0e7185-dc3e-4de0-8766-43499ee61745;
 Thu, 21 Oct 2021 11:03:56 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8b0e7185-dc3e-4de0-8766-43499ee61745
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1634814236;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=jAc6L/EmceP6wdkHmBmwI+pOrUmu0wm76d/xvVeAMCE=;
  b=Gr9Vw1iHwRKNVyvPdsTEC1uII1yBTxv/hO4x3jxYg4KKfkzNSvFfnyiw
   z8OytSacN5hB3UrfBwL6Xowt3QZnTCMn8O5V999g50oP1oyoVPAvGEweT
   U6ewmgfnz+Ys4rGMDOigQCjvcBaOg7z+VJ+q0QG8n0lEwgTGoTiGZGhNo
   g=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: Mfl9yBIUJhV7j8IEsSrifc2IGoA/OaJg+b3MbTi+psPFspdc/otsclVzIYdFfkYwQFOXZFvYQx
 4+80CwwmD8o101DASzfHJ7KArRR8jOm6ckbBvvkneeBm4Cm8YHCtIJT2TJdZbkv1aALLMfunQg
 Ykr3XavZaPwVfQuoDCINSUooSSp3TfWKZYE2r7UD5LHxXPkSKezlk1A1Ks2suOT8CpWUZyXvlE
 VlMW9a8Gg0JQLlX6NYUTgf55eI3rjTQM57h9XhiltFojW5JXxjk/dcA77+bi4tbcdWJ2foRNEY
 4uXH3wLjhJvKzZvNzv0er0q2
X-SBRS: 5.1
X-MesageID: 55711042
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:dy1PKKABX0dcnBVW/4jkw5YqxClBgxIJ4kV8jS/XYbTApGkn3jMPz
 TAYWWqPM6mKZWP0fN13YI/k9koP68Ldmt9iQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA
 xA2M4GYRCwMo/u1Si6FatANl1ElvU2zbue6WLGs1hxZH1c+EX5500s7wobVv6Yz6TSHK1LV0
 T/Ni5W31G+Ng1aY5UpNtspvADs21BjDkGtwUm4WPJinj3eH/5UhN7oNJLnZEpfNatI88thW5
 Qr05OrREmvxp3/BAz4++1rxWhVirrX6ZWBihpfKMkQLb9crSiEai84G2PQghUh/hxnWk8pT8
 IV2r7OyYhpuZIHiluQGakwNe81+FfUuFL7vJHG+tYqYzlHccmuqyPJrZK00FdRGoKAtWzgIr
 KFGbmBWBvyAr7veLLaTQ+9whsMlPY/zMZkWoH1IxjDFF/c2B5vERs0m4PcFgWhp35gSR54yY
 eISM2ZDZzeRMyZeGVMZDaoRjb6aoibgJmgwRFW9+vNsvjm7IBZK+KfpGMrYfJqNX8o9tnifo
 mXK7mHoGCYwPdaUySeG2n+0j+qJliT+MKoCGbv9+vN0jVm7wm0IFAZQRVa9ueO+iEO1R5RYM
 UN80jE1saE4+UivT9/8dx61uniJulgbQdU4O+8w5RyJy6HUyx2EHWVCRTlEAPQnq80eVTEsz
 kWOnd7iGXpoqrL9YXCA8raZqxuiNC5TKnUNDRLoViNcvYOl+ttqyEuSEJAzS8ZZk+EZBxn87
 2+GtgoG144JoswgyuLh0X7JgymV882hohEO2i3bWWes7wVcbYGjZpC15VWz0cusPLp1XXHa4
 yBaw5n2APQmSMjXznTUEbpl8KSBvq7daFXhbUhT847NHthH00WoepxM+3lALUNtP9dsldTBM
 RKL5105CHO+OhKXgU5Lj2CZV5tCIUvIT42NuhXogjxmOMUZmOivp3kGWKJo9zqx+HXAaIlmU
 XthTe6iDGwBFYNsxyesSuEW3NcDn35lmTyOGMyjkEv4itJygUJ5r59fbTNiichitMu5TPj9q
 Y4DZ6NmNT0OOAEBXsUn2dFKdg1bRZTKLZv3t9ZWZoa+zvlOQwkc5wvq6ep5IeRNxv0N/s+Rp
 y3VchIImTLX2CycQS3XOy8LVV8adcsmxZ7NFXd3ZgjANrlKSdvH0ZrzgLNtIOJ9q7A6nKUqJ
 xTHEu3Zaslypv3802x1RfHAQEZKLnxHXCqCYHioZiYRZZllS1Cb89PoZFK3piIPEjC2pY01p
 Lj5jlHXRp8KRgJDCsfKaa3wkwPt7CZFwO8iDVHVJtRzeVn39NQ4ISLGkfJqcdoHLg/Ox2XG2
 l/OUwsYv+TEv6Q87MLN2fKft46sHuYnRhhaEmDX4KyYLy7f+mb/k4ZMXPzRJWLWVX/u+bXkb
 uJQlqmuPPoClVdMkox9D7c0kv5uu4qx/+dXl102Em/KYlKnDqJbDkOHhcQf5LdQwrJ5uBetX
 h7d8NdtJrjUatjuF0QcJVR5Y73bh+0UgDTb8d88PF7+uH1s5LOCXEhfY0uMhShaIOcnOY8p2
 7586ssf6gj5gRs2KNeWyCtT8j3UfHAHVqwmsLAcAZPq1VV3mg0TP8SEB3+k+oyLZvVNLlIuc
 22di6f1jrhBwlbPLigoHn/X0OsB3ZkDtXimFrPZy4hlTjYdusIK4Q==
IronPort-HdrOrdr: A9a23:cCFQfK5agXjdluVzrwPXwWKBI+orL9Y04lQ7vn2ZFiY6TiXIra
 +TdaoguSMc0AxhJU3Jmbi7Sc29qADnhOJICOgqTPmftWzd2VdAQ7sSlrcLXVXbalXDH4JmpM
 VdmstFeZzN5DpB/LzHCWCDer5KqrTmgcOVbI/lvixQpGpRGsZdBnJCe3+m+zpNNW977PQCZf
 +hz/sCgwDlVWUcb8y9CHVAdfPEvcf3mJXvZgNDLwI76SGV5AnYqILSIly95FMzQjlPybAt/S
 zuiAri/JiutPm911v1y3LT1ZJLg9Hso+EzR/Bky/JlaAkEuDzYILiJaIfy+wzdZ9vfrmrCpe
 O85ivI+f4Dsk85MFvF+ScFkDOQrwrGo0WSt2Nwx0GT+/ARDQhKe/aoie9iA2rkwltls9dm3K
 1R2WWF85JREBPbhSz4o8PFThdwiyOP0DcfeEEo/ghiuKYlGfRsRLYkjQlo+VY7bVXHwZFiFP
 MrANDX5f5Qf1/fZ3fFvnN3yNjpWngoBB+JTkULp8TQilFt7T9E5lpdwNZakmYL9Zo7RZUB7+
 PYMr5wnLULSsMNd6pyCOoIXMPyAG3QRhDHNn6UPD3cZe06EmOIr4Sy7KQ+5emsdpBNxJwumI
 7ZWFcdrmI2c1KGM7zH4HSKyGGFfIyQZ0We9ihu3ekOhlSnfsuZDcSqciFar/ed
X-IronPort-AV: E=Sophos;i="5.87,169,1631592000"; 
   d="scan'208";a="55711042"
Date: Thu, 21 Oct 2021 12:03:43 +0100
From: Anthony PERARD <anthony.perard@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, George Dunlap
	<george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>, Julien Grall
	<julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>, Wei Liu
	<wl@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, Roger Pau
 =?iso-8859-1?Q?Monn=E9?= <roger.pau@citrix.com>,
	<xen-devel@lists.xenproject.org>
Subject: Re: [XEN PATCH v7 42/51] build: grab common EFI source files in arch
 specific dir
Message-ID: <YXFJD3LlFfbivA6Z@perard>
References: <20210824105038.1257926-1-anthony.perard@citrix.com>
 <20210824105038.1257926-43-anthony.perard@citrix.com>
 <43684fcc-f6ca-86f2-9fb1-d3d5d9dbc20d@suse.com>
 <YWmse5Sv2SFyRMdj@perard>
 <fd11108b-db66-3c0e-9a7e-a5e30b0b5b1f@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <fd11108b-db66-3c0e-9a7e-a5e30b0b5b1f@suse.com>

On Mon, Oct 18, 2021 at 10:48:26AM +0200, Jan Beulich wrote:
> On 15.10.2021 18:29, Anthony PERARD wrote:
> > On Thu, Oct 14, 2021 at 10:51:44AM +0200, Jan Beulich wrote:
> >> On 24.08.2021 12:50, Anthony PERARD wrote:
> >>> --- a/xen/arch/arm/efi/Makefile
> >>> +++ b/xen/arch/arm/efi/Makefile
> >>> @@ -1,4 +1,10 @@
> >>>  CFLAGS-y += -fshort-wchar
> >>> +CFLAGS-y += -I$(srctree)/common/efi
> >>
> >> Perhaps another opportunity for -iquote?
> > 
> > Yes.
> > 
> >>>  obj-y += boot.init.o pe.init.o ebmalloc.o runtime.o
> >>>  obj-$(CONFIG_ACPI) +=  efi-dom0.init.o
> >>> +
> >>> +$(obj)/%.c: common/efi/%.c
> >>> +	$(Q)cp -f $< $@
> >>
> >> In case both trees are on the same file system, trying to hardlink first
> >> would seem desirable. When copying, I think you should also pass -p.
> > 
> > I don't know if doing an hardlink is a good thing to do, I'm not sure of
> > the kind of issue this could bring. As for -p, I don't think it's a good
> > idea to copy the mode, ownership, and timestamps of the source file, I'd
> > rather have the timestamps that Make expect, e.i. "now".
> 
> Why would "now" be correct (or expected) in any way? The cloned file is no
> different from the original. Nevertheless I agree that -p is not ideal;
> it's just that the more fine grained option to preserve just the timestamp
> is non-standard afaik. You could try that first and fall back to -p ...
> Otherwise, failing hard linking and using "cp -p", I'm afraid I'd prefer
> symlinking despite the arguments against it that you name in the
> description.

I guess I'm missing something, is there a reason to keep/copy the
timestamps of the original files?

> Might be good to have someone else's view here as well.

Indeed.

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Thu Oct 21 11:24:47 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Oct 2021 11:24:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.214342.372848 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdWBa-0004RP-LQ; Thu, 21 Oct 2021 11:24:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 214342.372848; Thu, 21 Oct 2021 11:24:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdWBa-0004RI-H9; Thu, 21 Oct 2021 11:24:38 +0000
Received: by outflank-mailman (input) for mailman id 214342;
 Thu, 21 Oct 2021 11:24:37 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=FF+c=PJ=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mdWBZ-0004RC-DB
 for xen-devel@lists.xenproject.org; Thu, 21 Oct 2021 11:24:37 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 786762b4-3261-11ec-8376-12813bfff9fa;
 Thu, 21 Oct 2021 11:24:36 +0000 (UTC)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2051.outbound.protection.outlook.com [104.47.13.51]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-15-GDunlEHtPrSX6N289OKiWg-1; Thu, 21 Oct 2021 13:24:34 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB6174.eurprd04.prod.outlook.com (2603:10a6:803:fa::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.17; Thu, 21 Oct
 2021 11:24:30 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::8062:d7cb:ca45:1898]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::8062:d7cb:ca45:1898%3]) with mapi id 15.20.4628.018; Thu, 21 Oct 2021
 11:24:30 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6P195CA0014.EURP195.PROD.OUTLOOK.COM (2603:10a6:209:81::27) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4628.16 via Frontend Transport; Thu, 21 Oct 2021 11:24:29 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 786762b4-3261-11ec-8376-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634815475;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=28n5/3JGSx05ZTYkCn1qgK/UejdJp4oaBAIggQEUfwU=;
	b=aEpGoqho0LTPIwXINTXSpNv+U4ri7N9rSN9cGUMRZYqCRcqEVYylfsvcxFmcAWOW7oaWX8
	1y8oAJ4m8Skme+vHuFHkV9depJkd8PgVvVgla642iIU7eoTtT5ByWTBa5mmIJETlooyWZb
	bK4rI8BEKGTXslw69/gKxYocfX+aobA=
X-MC-Unique: GDunlEHtPrSX6N289OKiWg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=LVFIH6WteekwIKFBrSdvN6cGstJHdllkwOh6izis+tiJ7sqZ05rCoSazADi2yEJF8f45gWeCCxPlnVSUh4uTP4r/yDGg1rePksbGfdnHJ4q6VbGd+LAZdHGmntmzn7R4zEALfs46vt88Z/m+CbIEW/yTdWVA+Y1spJLoZyJgiQ5pozgk+5cSBcSw6hX9tMmPlsKLUwzXyM0kg0SBYk79dTidKepMqxduoyC9oYSKHXYQMDPz97XbbwzooVlhVNWPc/fnMn9JLVhVZVHWUtuZbE7fgNZ8Rjgoswe7UXuDsGd/CdsMBnSDVlkzdQSEGpgSnXnfkZjlAV01n9cWcz0guQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=28n5/3JGSx05ZTYkCn1qgK/UejdJp4oaBAIggQEUfwU=;
 b=kU8OshWG9PvWHKHEhIYFYm3T5pH4kZg2It0f0yr6cjU5OVbjLKRx1UCg+hAU6FkQwE8OAkdeVHjtJuNVPAFA0rGs6qWv0huX6rJA4SLXQQD5YjnnQ/kiDLr3i5ZN7xA4HXmm48H0AHC8EfVM3doxdWNkRle+dsTY/GQ4vN6KrciKH9PK9qyBzHxetDm/xwe+cXr1Nb4gHwVJc2EtDzHvbu2uqJ5I8IkB4w3X3Aq7hjteMxPy5VSUnqB6aCNw+shvQSPebXeb1lPzpa9hAhirHx7MZO3RBJoSmMgWtOdJLoicxJ7suF1uymdJPHeiDRHdOkiLjjUjM2Wr1Yj144qzZQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [XEN PATCH v7 42/51] build: grab common EFI source files in arch
 specific dir
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 xen-devel@lists.xenproject.org
References: <20210824105038.1257926-1-anthony.perard@citrix.com>
 <20210824105038.1257926-43-anthony.perard@citrix.com>
 <43684fcc-f6ca-86f2-9fb1-d3d5d9dbc20d@suse.com> <YWmse5Sv2SFyRMdj@perard>
 <fd11108b-db66-3c0e-9a7e-a5e30b0b5b1f@suse.com> <YXFJD3LlFfbivA6Z@perard>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <938f059d-9d08-75bd-01ee-5d442a5e9961@suse.com>
Date: Thu, 21 Oct 2021 13:24:27 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <YXFJD3LlFfbivA6Z@perard>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P195CA0014.EURP195.PROD.OUTLOOK.COM
 (2603:10a6:209:81::27) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: fab389f7-59a1-4b2f-a838-08d99485592e
X-MS-TrafficTypeDiagnostic: VI1PR04MB6174:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB61743D9459921778B3BE7FB3B3BF9@VI1PR04MB6174.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	ot7biLFmVdXH+sYDy0bpFQRzpL7foCl2XHVNkrrCDVhFQmzrEyzoIXnVvpcWwWK2VApBWyRo0TiYBvikkayg3MuTrl5MYd19jlrqZpLI0e0sfMBUMacOF9HSlJ0wM7OnrlTBWvQJSiTSkVsqmpEPuwSa/REtjYJtgLm127Gc0O2ilFm8d2h3K9PQfGR1ryQVcjl/mueVE0qIYpMPi9f4AMgh5e7z2X1PCtju1nCI8kqIu7amabzg/8uGZjGOagtNlMNoWXiv9n555oI7v3XSbiGJGF6TshHTC6OYow1QMQFdI1mPQqT7D/oC4GSul0BloEQhEUUyhDtYLh2CKc+1654+xO4SVnUeHk3tZZ0nw2EZMVvPbrToKfniDtggCRGDu/RFIDpvu54xRlsMFit76O8qNB0eVfkLjP+V2Myh0GpUO+vHew3WNeQvH3yB7QoXXmLvfYK31ZykoUCqkTJ0LTvS6DJ7HX2pUqnnhTQaALC5gVnlqyByVsobFNVoA/YBgAzsp7IkUdRDkYNmcJVAzFG7Ntw28koqdHCRh6Mz3ADlA7BmUxv7MgKH3lKoKSgkO545U5WZRgo/33nDC0RROZ+l1284yjSzZP1FXhqaRkXIdSWB60WTXSEgdMv5Km2eN0xPETD0R5RzW94HIXjRHp/K5XCRIkiynDTIVXZIzuTyLjVpCaF6F3LEVDd+qQzH5uT0Iwsp/Hg66ZWXEJ8rnJCL9AReYqQgeJQKwZ6bcn9ppY5RT0al1H5iGSHjoDuW
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(36756003)(53546011)(2616005)(5660300002)(6486002)(956004)(8936002)(508600001)(66946007)(66476007)(54906003)(38100700002)(31696002)(316002)(16576012)(4326008)(2906002)(7416002)(26005)(86362001)(31686004)(6916009)(186003)(8676002)(66556008)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?cEcyTTQ0cFpKOXRlbzUrUHQ1b3RuZVQ3dXFXbko5djd4ZlBKWC93UXRDUHN3?=
 =?utf-8?B?SG1HY2xnSDFJNHdaMFdnTnVpMlFmQ3U0TGJhYjRzN0hoRXFyUGZId0lWRjhF?=
 =?utf-8?B?VlNTZGsxRi8vK0o5czc2bDBFNFFpOWo0NmxNMmhsMUNWbllxb1FRS3BZSkRL?=
 =?utf-8?B?bTlxa1NQMlVCa0N5NTFsZ3o0N3NrVitoakUzbnh0dTZWdC9IZG1IRmhFazVt?=
 =?utf-8?B?V2oreS85QWpOVnBscnhsdXVncU1pSzlsMVVNaFY4ZmsxNTJPdjRscnRCdlc0?=
 =?utf-8?B?bVRGeHVmT2NoNjRaaDBCUkdSa3pWVnYvY0VQUXR1WWpGOXNTdkFlQjRoaVZV?=
 =?utf-8?B?N3QwZ1ZVaFd1OXZmUGNJdm9PNmhCLzJHNTlNbFZmMTdUK3dCZmQyZUdyamZL?=
 =?utf-8?B?c2Z1RUg2aEhmeE9HK2FOWS9ESno2T3RJY1VadTRiTjBTL2ZrcnRYcjFwQnZu?=
 =?utf-8?B?V0V3Rk4xOHlTbVNkZjU3aFlPT1Z4WXBlRTZvWDRpVC92bGdXY0FhaEZ5QTVz?=
 =?utf-8?B?MWlUQ0xKRWhBU2lHTlN0SXZPV1JrVElrZFlZSFI1T2VkR1N0SzRyQ0QrZndt?=
 =?utf-8?B?RWNoK2FzeVZJSFhPY1FaWG5VUjJCZjljOXpXWHU1ZFZ6dFJnV2pWL3VBMmI0?=
 =?utf-8?B?dFNtWkRGaHpJYmtrMUdlV25xbVhvS1dmcERnR2lWN3U4YWtpcGRwOXVNbnlJ?=
 =?utf-8?B?U1RBWUU0NXUrSVY0OFVEWFlvTXUrOHVLWURuN3NkYzhXMllJazNEanpCNHhF?=
 =?utf-8?B?dWs5Z1FPMG1WQ2ozTFM1NU1TU24rUk9DVTU3Z0ZXMEdBWTcrK2Vlb00vYllH?=
 =?utf-8?B?WnlxYmhiNTU5RVlLdkpkTTZqbkgwSUZhQ3FhTmZFMHowN1UxL1E5NVBKZ09E?=
 =?utf-8?B?L0w0ekVFb3piSDFwYWJsNTZ0MTgyc3pxRkJQUldqVW1jZTN2eWVmV0Y0R3Y3?=
 =?utf-8?B?T1o3aVhaYXh4dlZ2RFI3K1JBZ0RqeCtvZnBoVkRHQ013WFVWY1g3LzdZeHVR?=
 =?utf-8?B?RmR3c0xyR2FrWlhWeHdtV3U3VjNPYW9td1g2WkVsaGh1STlqWkxQMUFZMENh?=
 =?utf-8?B?U1pSNzZHUkNWMHJabjZzb2NKY29JKzN6dFNvQytwNFE2REpCZy8zeTZBNDlM?=
 =?utf-8?B?OU01bTBZZjRpRzBlY2t2M2VDL2hJNEVLTGhXWkdlTWF3amlDYlJuNm5ZbkYv?=
 =?utf-8?B?NmowdnhtTVBkMStIWGUzNHRsM0NQMWNKMmlBZW1CK3pMTm9TbVU5S2U0YkxJ?=
 =?utf-8?B?UGFqL0ZiaWlEb3F2MDRheHZtTjlOcUVhQ3RLNGE3RjNYSlJXcTZNdzZjbHEv?=
 =?utf-8?B?WkM2VVdYakhwY0oxdVlvYkRTRkY5TFRqYzJHeDBjTmJnYmU2ZStTc01HeGp6?=
 =?utf-8?B?ak9NdnUxMDIvSVN4SzNvK2IyeEpVTVNoWFArcG5QdmhQL1JpZlJiYmIwODEy?=
 =?utf-8?B?eURFajlSSHVXbkhTZEtmZTNaL3FqOWxzMW54bE1hcVVJbU9jWXltMTdZaFpx?=
 =?utf-8?B?QmVPZlFpc09oa3h4YVBOMFExaDdLTjVQb3lmU1hXY0o3Z3ozSTZCSzdhZ1ht?=
 =?utf-8?B?Nld4SGdFZEFhL2xCaWI4MHIraE04M1I2bGdWazRJVkVyTHhMQ2ZieVVlTkg3?=
 =?utf-8?B?MllvY2tVM1E0aHo5dlFTUFhCY1RsbkhXcHZCU211M2lFL015d2xTanhJWXli?=
 =?utf-8?B?dWoxUFVSV0NGVG9DaUR1ME9qTFlZY2U1QnRzN1JHVGM1a2lrUXV2Sm1tOS9G?=
 =?utf-8?Q?NQaAA+9d7T7KYfrsKmT9eOWOqu2eUlPm75vuQTs?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fab389f7-59a1-4b2f-a838-08d99485592e
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Oct 2021 11:24:29.9825
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jbeulich@suse.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6174

On 21.10.2021 13:03, Anthony PERARD wrote:
> On Mon, Oct 18, 2021 at 10:48:26AM +0200, Jan Beulich wrote:
>> On 15.10.2021 18:29, Anthony PERARD wrote:
>>> On Thu, Oct 14, 2021 at 10:51:44AM +0200, Jan Beulich wrote:
>>>> On 24.08.2021 12:50, Anthony PERARD wrote:
>>>>> --- a/xen/arch/arm/efi/Makefile
>>>>> +++ b/xen/arch/arm/efi/Makefile
>>>>> @@ -1,4 +1,10 @@
>>>>>  CFLAGS-y += -fshort-wchar
>>>>> +CFLAGS-y += -I$(srctree)/common/efi
>>>>
>>>> Perhaps another opportunity for -iquote?
>>>
>>> Yes.
>>>
>>>>>  obj-y += boot.init.o pe.init.o ebmalloc.o runtime.o
>>>>>  obj-$(CONFIG_ACPI) +=  efi-dom0.init.o
>>>>> +
>>>>> +$(obj)/%.c: common/efi/%.c
>>>>> +	$(Q)cp -f $< $@
>>>>
>>>> In case both trees are on the same file system, trying to hardlink first
>>>> would seem desirable. When copying, I think you should also pass -p.
>>>
>>> I don't know if doing an hardlink is a good thing to do, I'm not sure of
>>> the kind of issue this could bring. As for -p, I don't think it's a good
>>> idea to copy the mode, ownership, and timestamps of the source file, I'd
>>> rather have the timestamps that Make expect, e.i. "now".
>>
>> Why would "now" be correct (or expected) in any way? The cloned file is no
>> different from the original. Nevertheless I agree that -p is not ideal;
>> it's just that the more fine grained option to preserve just the timestamp
>> is non-standard afaik. You could try that first and fall back to -p ...
>> Otherwise, failing hard linking and using "cp -p", I'm afraid I'd prefer
>> symlinking despite the arguments against it that you name in the
>> description.
> 
> I guess I'm missing something, is there a reason to keep/copy the
> timestamps of the original files?

Avoidance of confusion is my main aim here. I certainly would be puzzled
to see what looks like a source file to have a time stamp much newer than
expected.

Jan



From xen-devel-bounces@lists.xenproject.org Thu Oct 21 11:41:40 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Oct 2021 11:41:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.214351.372859 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdWRx-0006mo-8Y; Thu, 21 Oct 2021 11:41:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 214351.372859; Thu, 21 Oct 2021 11:41:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdWRx-0006mh-5N; Thu, 21 Oct 2021 11:41:33 +0000
Received: by outflank-mailman (input) for mailman id 214351;
 Thu, 21 Oct 2021 11:41:32 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mdWRw-0006mX-AS; Thu, 21 Oct 2021 11:41:32 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mdWRw-0007Zx-2v; Thu, 21 Oct 2021 11:41:32 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mdWRv-00067g-Oj; Thu, 21 Oct 2021 11:41:31 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mdWRv-0004ev-OE; Thu, 21 Oct 2021 11:41:31 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=/JeIqZxUkDKsCN0+xEIc0hdIrIFc6Y7woBacbFeeJbw=; b=fumx/TNpMtYDZ3Y7CvAn+5v5Iu
	gNgsJP3hikRZtygJtuoeYqCp170yw4FguOLd+HB87l5LSpndwEi1bsv+iAOwuXCzDZN9fA3TpMAP2
	2ePOogxGqHlDtsWiPX3JNu2BsAKbO+I7Kf8xyHgGbiEL0wTbZzdDcSUs5rAzPLkZAEr0=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165702-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 165702: regressions - FAIL
X-Osstest-Failures:
    libvirt:build-armhf-libvirt:libvirt-build:fail:regression
    libvirt:build-amd64-libvirt:libvirt-build:fail:regression
    libvirt:build-i386-libvirt:libvirt-build:fail:regression
    libvirt:build-arm64-libvirt:libvirt-build:fail:regression
    libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    libvirt=2772162316dc4938cd60d19e14dabe4371188c05
X-Osstest-Versions-That:
    libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 21 Oct 2021 11:41:31 +0000

flight 165702 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165702/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-armhf-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-amd64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-i386-libvirt            6 libvirt-build            fail REGR. vs. 151777
 build-arm64-libvirt           6 libvirt-build            fail REGR. vs. 151777

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-libvirt-vhd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a

version targeted for testing:
 libvirt              2772162316dc4938cd60d19e14dabe4371188c05
baseline version:
 libvirt              2c846fa6bcc11929c9fb857a22430fb9945654ad

Last test of basis   151777  2020-07-10 04:19:19 Z  468 days
Failing since        151818  2020-07-11 04:18:52 Z  467 days  453 attempts
Testing same since   165702  2021-10-21 04:18:54 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
    Adolfo Jayme Barrientos <fitoschido@gmail.com>
  Aleksandr Alekseev <alexander.alekseev@virtuozzo.com>
  Aleksei Zakharov <zaharov@selectel.ru>
  Andika Triwidada <andika@gmail.com>
  Andrea Bolognani <abologna@redhat.com>
  Ani Sinha <ani@anisinha.ca>
  Balázs Meskó <meskobalazs@mailbox.org>
  Barrett Schonefeld <bschoney@utexas.edu>
  Bastian Germann <bastiangermann@fishpost.de>
  Bastien Orivel <bastien.orivel@diateam.net>
  BiaoXiang Ye <yebiaoxiang@huawei.com>
  Bihong Yu <yubihong@huawei.com>
  Binfeng Wu <wubinfeng@huawei.com>
  Bjoern Walk <bwalk@linux.ibm.com>
  Boris Fiuczynski <fiuczy@linux.ibm.com>
  Brian Turek <brian.turek@gmail.com>
  Bruno Haible <bruno@clisp.org>
  Chris Mayo <aklhfex@gmail.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Ehrhardt <christian.ehrhardt@canonical.com>
  Christian Kirbach <christian.kirbach@gmail.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Cole Robinson <crobinso@redhat.com>
  Collin Walling <walling@linux.ibm.com>
  Cornelia Huck <cohuck@redhat.com>
  Cédric Bosdonnat <cbosdonnat@suse.com>
  Côme Borsoi <fedora@borsoi.fr>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniel Letai <dani@letai.org.il>
  Daniel P. Berrange <berrange@redhat.com>
  Daniel P. Berrangé <berrange@redhat.com>
  Didik Supriadi <didiksupriadi41@gmail.com>
  dinglimin <dinglimin@cmss.chinamobile.com>
  Dmytro Linkin <dlinkin@nvidia.com>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Eric Farman <farman@linux.ibm.com>
  Erik Skultety <eskultet@redhat.com>
  Fabian Affolter <mail@fabian-affolter.ch>
  Fabian Freyer <fabian.freyer@physik.tu-berlin.de>
  Fabiano Fidêncio <fabiano@fidencio.org>
  Fangge Jin <fjin@redhat.com>
  Farhan Ali <alifm@linux.ibm.com>
  Fedora Weblate Translation <i18n@lists.fedoraproject.org>
  Gavi Teitz <gavi@nvidia.com>
  gongwei <gongwei@smartx.com>
  Guoyi Tu<tu.guoyi@h3c.com>
  Göran Uddeborg <goeran@uddeborg.se>
  Halil Pasic <pasic@linux.ibm.com>
  Han Han <hhan@redhat.com>
  Hao Wang <wanghao232@huawei.com>
  Hela Basa <r45xveza@pm.me>
  Helmut Grohne <helmut@subdivi.de>
  Hiroki Narukawa <hnarukaw@yahoo-corp.jp>
  Ian Wienand <iwienand@redhat.com>
  Jakob Meng <jakobmeng@web.de>
  Jamie Strandboge <jamie@canonical.com>
  Jamie Strandboge <jamie@ubuntu.com>
  Jan Kuparinen <copper_fin@hotmail.com>
  jason lee <ppark5237@gmail.com>
  Jean-Baptiste Holcroft <jean-baptiste@holcroft.fr>
  Jia Zhou <zhou.jia2@zte.com.cn>
  Jianan Gao <jgao@redhat.com>
  Jim Fehlig <jfehlig@suse.com>
  Jin Yan <jinyan12@huawei.com>
  Jinsheng Zhang <zhangjl02@inspur.com>
  Jiri Denemark <jdenemar@redhat.com>
  John Ferlan <jferlan@redhat.com>
  Jonathan Watt <jwatt@jwatt.org>
  Jonathon Jongsma <jjongsma@redhat.com>
  Julio Faracco <jcfaracco@gmail.com>
  Justin Gatzen <justin.gatzen@gmail.com>
  Ján Tomko <jtomko@redhat.com>
  Kashyap Chamarthy <kchamart@redhat.com>
  Kevin Locke <kevin@kevinlocke.name>
  Kristina Hanicova <khanicov@redhat.com>
  Laine Stump <laine@redhat.com>
  Laszlo Ersek <lersek@redhat.com>
  Lee Yarwood <lyarwood@redhat.com>
  Lei Yang <yanglei209@huawei.com>
  Liao Pingfang <liao.pingfang@zte.com.cn>
  Lin Ma <lma@suse.com>
  Lin Ma <lma@suse.de>
  Lin Ma <morecache@gmail.com>
  Liu Yiding <liuyd.fnst@fujitsu.com>
  Luke Yue <lukedyue@gmail.com>
  Luyao Zhong <luyao.zhong@intel.com>
  Marc Hartmayer <mhartmay@linux.ibm.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Markus Schade <markus.schade@hetzner.com>
  Martin Kletzander <mkletzan@redhat.com>
  Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
  Matej Cepl <mcepl@cepl.eu>
  Matt Coleman <matt@datto.com>
  Matt Coleman <mcoleman@datto.com>
  Mauro Matteo Cascella <mcascell@redhat.com>
  Meina Li <meili@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Michał Smyk <fedora@smyk.it>
  Milo Casagrande <milo@milo.name>
  Moshe Levi <moshele@nvidia.com>
  Muha Aliss <muhaaliss@gmail.com>
  Nathan <nathan95@live.it>
  Neal Gompa <ngompa13@gmail.com>
  Nick Chevsky <nchevsky@gmail.com>
  Nick Shyrokovskiy <nshyrokovskiy@gmail.com>
  Nickys Music Group <nickys.music.group@gmail.com>
  Nico Pache <npache@redhat.com>
  Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
  Olaf Hering <olaf@aepfle.de>
  Olesya Gerasimenko <gammaray@basealt.ru>
  Orion Poplawski <orion@nwra.com>
  Pany <geekpany@gmail.com>
  Patrick Magauran <patmagauran.j@gmail.com>
  Paulo de Rezende Pinatti <ppinatti@linux.ibm.com>
  Pavel Hrdina <phrdina@redhat.com>
  Peng Liang <liangpeng10@huawei.com>
  Peter Krempa <pkrempa@redhat.com>
  Pino Toscano <ptoscano@redhat.com>
  Pino Toscano <toscano.pino@tiscali.it>
  Piotr Drąg <piotrdrag@gmail.com>
  Prathamesh Chavan <pc44800@gmail.com>
  Praveen K Paladugu <prapal@linux.microsoft.com>
  Richard W.M. Jones <rjones@redhat.com>
  Ricky Tigg <ricky.tigg@gmail.com>
  Robin Lee <cheeselee@fedoraproject.org>
  Roman Bogorodskiy <bogorodskiy@gmail.com>
  Roman Bolshakov <r.bolshakov@yadro.com>
  Ryan Gahagan <rgahagan@cs.utexas.edu>
  Ryan Schmidt <git@ryandesign.com>
  Sam Hartman <hartmans@debian.org>
  Scott Shambarger <scott-libvirt@shambarger.net>
  Sebastian Mitterle <smitterl@redhat.com>
  SeongHyun Jo <caelus9536@gmail.com>
  Shalini Chellathurai Saroja <shalini@linux.ibm.com>
  Shaojun Yang <yangshaojun@phytium.com.cn>
  Shi Lei <shi_lei@massclouds.com>
  simmon <simmon@nplob.com>
  Simon Chopin <chopin.simon@gmail.com>
  Simon Gaiser <simon@invisiblethingslab.com>
  Simon Rowe <simon.rowe@nutanix.com>
  Stefan Bader <stefan.bader@canonical.com>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Berger <stefanb@linux.vnet.ibm.com>
  Stefan Hajnoczi <stefanha@gmail.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Szymon Scholz <szymonscholz@gmail.com>
  Thomas Huth <thuth@redhat.com>
  Tim Wiederhake <twiederh@redhat.com>
  Tomáš Golembiovský <tgolembi@redhat.com>
  Tomáš Janoušek <tomi@nomi.cz>
  Tuguoyi <tu.guoyi@h3c.com>
  Victor Toso <victortoso@redhat.com>
  Ville Skyttä <ville.skytta@iki.fi>
  Vinayak Kale <vkale@nvidia.com>
  Wang Xin <wangxinxin.wang@huawei.com>
  WangJian <wangjian161@huawei.com>
  Weblate <noreply@weblate.org>
  Wei Liu <liuwe@microsoft.com>
  Wei Liu <wei.liu@kernel.org>
  Wei-Chen Chen <weicche@microsoft.com>
  William Douglas <william.douglas@intel.com>
  Yalei Li <274268859@qq.com>
  Yalei Li <liyl43@chinatelecom.cn>
  Yang Fei <yangfei85@huawei.com>
  Yang Hang <yanghang44@huawei.com>
  Yanqiu Zhang <yanqzhan@redhat.com>
  Yaroslav Kargin <ykargin@virtuozzo.com>
  Yi Li <yili@winhong.com>
  Yi Wang <wang.yi59@zte.com.cn>
  Yuri Chornoivan <yurchor@ukr.net>
  Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
  zhangjl02 <zhangjl02@inspur.com>
  Zheng Chuan <zhengchuan@huawei.com>
  zhenwei pi <pizhenwei@bytedance.com>
  Zhenyu Ye <yezhenyu2@huawei.com>
  Zhenyu Zheng <zheng.zhenyu@outlook.com>
  Zhenzhong Duan <zhenzhong.duan@intel.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          fail    
 build-arm64-libvirt                                          fail    
 build-armhf-libvirt                                          fail    
 build-i386-libvirt                                           fail    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           blocked 
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-libvirt-xsm                                 blocked 
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-libvirt                                     blocked 
 test-arm64-arm64-libvirt                                     blocked 
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-libvirt-pair                                blocked 
 test-amd64-i386-libvirt-pair                                 blocked 
 test-arm64-arm64-libvirt-qcow2                               blocked 
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-libvirt-vhd                                 blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 80300 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Oct 21 11:53:22 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Oct 2021 11:53:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.214360.372872 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdWdC-0008F4-Aq; Thu, 21 Oct 2021 11:53:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 214360.372872; Thu, 21 Oct 2021 11:53:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdWdC-0008Ex-81; Thu, 21 Oct 2021 11:53:10 +0000
Received: by outflank-mailman (input) for mailman id 214360;
 Thu, 21 Oct 2021 11:53:09 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=fYzA=PJ=suse.com=jgross@srs-us1.protection.inumbo.net>)
 id 1mdWdB-0008Er-FE
 for xen-devel@lists.xenproject.org; Thu, 21 Oct 2021 11:53:09 +0000
Received: from smtp-out1.suse.de (unknown [195.135.220.28])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 75017a48-3265-11ec-8376-12813bfff9fa;
 Thu, 21 Oct 2021 11:53:08 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 7D782218B1;
 Thu, 21 Oct 2021 11:53:07 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 660F5133A6;
 Thu, 21 Oct 2021 11:53:07 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id vvawF6NUcWEkcgAAMHmgww
 (envelope-from <jgross@suse.com>); Thu, 21 Oct 2021 11:53:07 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 75017a48-3265-11ec-8376-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1634817187; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type;
	bh=Tp6cFf9CV+0py7Wah9oxllfjuQvZL1C6jr/1fO4cO1k=;
	b=YFVPU9lYQr9doAPHmPikANNacIIazkgfoOvp/4cY+L3G2nJrswcBJAA3Dg/F8PFohfJxyY
	5DfdVP6uo3AUwTSmEXadkv/ORuKvvJspmlfgjMj41Djghp9lizlWHRqkMXsUbRvtqcinAO
	0l5eQPKVSSBKu7ybwLIWmIGhoB4F1Fo=
To: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?=
 <marmarek@invisiblethingslab.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
From: Juergen Gross <jgross@suse.com>
Subject: Tentative fix for "out of PoD memory" issue
Message-ID: <912c7377-26f0-c14a-e3aa-f00a81ed5766@suse.com>
Date: Thu, 21 Oct 2021 13:53:06 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="9jicweCDwgCDyfDE1g1x9UE4MmkUUiXrs"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--9jicweCDwgCDyfDE1g1x9UE4MmkUUiXrs
Content-Type: multipart/mixed; boundary="aaXZVHuozSjg1ot6FjpsWQR04zmftmZVu";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?=
 <marmarek@invisiblethingslab.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Message-ID: <912c7377-26f0-c14a-e3aa-f00a81ed5766@suse.com>
Subject: Tentative fix for "out of PoD memory" issue

--aaXZVHuozSjg1ot6FjpsWQR04zmftmZVu
Content-Type: multipart/mixed;
 boundary="------------AB1936863D48348999C53954"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------AB1936863D48348999C53954
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

Marek,

could you please test whether the attached patch is fixing your
problem?

BTW, I don't think this couldn't happen before kernel 5.15. I guess
my modification to use a kernel thread instead of a workqueue just
made the issue more probable.

I couldn't reproduce the crash you are seeing, but the introduced
wait was 4.2 seconds on my test system (a PVH guest with 2 GB of
memory, maxmem 6 GB).


Juergen

--------------AB1936863D48348999C53954
Content-Type: text/x-patch; charset=UTF-8;
 name="0001-xen-balloon-add-late_initcall_sync-for-initial-ballo.patch"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: attachment;
 filename*0="0001-xen-balloon-add-late_initcall_sync-for-initial-ballo.pa";
 filename*1="tch"

=46rom 3ee35f6f110e2258ec94f0d1397fac8c26b41761 Mon Sep 17 00:00:00 2001
From: Juergen Gross <jgross@suse.com>
To: linux-kernel@vger.kernel.org
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: Juergen Gross <jgross@suse.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>
Cc: xen-devel@lists.xenproject.org
Date: Thu, 21 Oct 2021 12:51:06 +0200
Subject: [PATCH] xen/balloon: add late_initcall_sync() for initial balloo=
ning
 done
MIME-Version: 1.0
Content-Type: text/plain; charset=3DUTF-8
Content-Transfer-Encoding: 8bit

When running as PVH or HVM guest with actual memory < max memory the
hypervisor is using "populate on demand" in order to allow the guest
to balloon down from its maximum memory size. For this to work
correctly the guest must not touch more memory pages than its target
memory size as otherwise the PoD cache will be exhausted and the guest
is crashed as a result of that.

In extreme cases ballooning down might not be finished today before
the init process is started, which can consume lots of memory.

In order to avoid random boot crashes in such cases, add a late init
call to wait for ballooning down having finished for PVH/HVM guests.

Reported-by: Marek Marczykowski-G=C3=B3recki <marmarek@invisiblethingslab=
=2Ecom>
Signed-off-by: Juergen Gross <jgross@suse.com>
---
 drivers/xen/balloon.c | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/drivers/xen/balloon.c b/drivers/xen/balloon.c
index 3a50f097ed3e..d19b851c3d3b 100644
--- a/drivers/xen/balloon.c
+++ b/drivers/xen/balloon.c
@@ -765,3 +765,23 @@ static int __init balloon_init(void)
 	return 0;
 }
 subsys_initcall(balloon_init);
+
+static int __init balloon_wait_finish(void)
+{
+	if (!xen_domain())
+		return -ENODEV;
+
+	/* PV guests don't need to wait. */
+	if (xen_pv_domain() || !current_credit())
+		return 0;
+
+	pr_info("Waiting for initial ballooning down having finished.\n");
+
+	while (current_credit())
+		schedule_timeout_interruptible(HZ / 10);
+
+	pr_info("Initial ballooning down finished.\n");
+
+	return 0;
+}
+late_initcall_sync(balloon_wait_finish);
--=20
2.26.2


--------------AB1936863D48348999C53954
Content-Type: application/pgp-keys;
 name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Transfer-Encoding: quoted-printable
Content-Description: OpenPGP public key
Content-Disposition: attachment;
 filename="OpenPGP_0xB0DE9DD628BF132F.asc"

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy=
cWx
w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O=
f8Z
d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y=
9bf
IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq=
G7/
377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR=
3Jv
c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA=
QIe
AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT=
hpw
dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0=
MbD
1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv=
oPH
Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v=
5QL
+qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ=
2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC=
QoL
BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr=
Wf0
teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC=
/nu
AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh=
ITT
d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm=
XBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz=
80h
SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC=
AcD
AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn=
FOX
gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1=
jnD
kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0=
N51
N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l=
otu
fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1=
tqS
EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA=
hsD
BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3=
g3O
ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5=
dM7
wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5=
D+j
LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm=
V2x
AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N=
Eaw
QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW=
nHI
s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR=
wgn
BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV=
bVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk=
pEd
IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA=
QAB
wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw=
Tbe
8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1=
vJz
Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8=
VGi
wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW=
svi
uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX=
zXs
ZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------AB1936863D48348999C53954--

--aaXZVHuozSjg1ot6FjpsWQR04zmftmZVu--

--9jicweCDwgCDyfDE1g1x9UE4MmkUUiXrs
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmFxVKIFAwAAAAAACgkQsN6d1ii/Ey9+
mwf/fWDnXvMNmIeBqCHACyT8Y6EMt39qxjRdNQ+yFjJUFellmSpPpDe1PO2MqvhK41RSHA1Xjt/c
dhXB+8qZq85ngsP6ctlai5Bh6TQygvXwybD30lkvxPZkOr/vvVLZC9xmPz/e0ApwqW2MyzftV8xp
fBuMo6j5IEJd1i05/F3qB4X9Ubm4cMFRA5vjrFIMu6+W1ltbUFZpi+UoJwx5ChC/Tmt4OnDZ88Xi
F7NFT+mQlD7dEFxI9J3S8+dYrLXbwhFJx1ay1G4In9QTMvbdouokX+/e/+oB+I+08MaljV41Mo/b
Nx+2sOw7JmfpBb8GYPwJGyOyf1Ldh4jyOucFa5J/MA==
=Y3LY
-----END PGP SIGNATURE-----

--9jicweCDwgCDyfDE1g1x9UE4MmkUUiXrs--


From xen-devel-bounces@lists.xenproject.org Thu Oct 21 12:03:58 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Oct 2021 12:03:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.214372.372890 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdWnV-0001Nc-HT; Thu, 21 Oct 2021 12:03:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 214372.372890; Thu, 21 Oct 2021 12:03:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdWnV-0001NV-EQ; Thu, 21 Oct 2021 12:03:49 +0000
Received: by outflank-mailman (input) for mailman id 214372;
 Thu, 21 Oct 2021 12:03:48 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=El98=PJ=arm.com=Hongda.Deng@srs-us1.protection.inumbo.net>)
 id 1mdWnT-0001NK-UV
 for xen-devel@lists.xenproject.org; Thu, 21 Oct 2021 12:03:48 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com (unknown
 [40.107.20.47]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id f0fcaefa-3266-11ec-8376-12813bfff9fa;
 Thu, 21 Oct 2021 12:03:45 +0000 (UTC)
Received: from DU2PR04CA0205.eurprd04.prod.outlook.com (2603:10a6:10:28d::30)
 by DB7PR08MB3675.eurprd08.prod.outlook.com (2603:10a6:10:4c::22) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.18; Thu, 21 Oct
 2021 12:03:43 +0000
Received: from DB5EUR03FT062.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:10:28d:cafe::26) by DU2PR04CA0205.outlook.office365.com
 (2603:10a6:10:28d::30) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.16 via Frontend
 Transport; Thu, 21 Oct 2021 12:03:43 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT062.mail.protection.outlook.com (10.152.20.197) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4628.18 via Frontend Transport; Thu, 21 Oct 2021 12:03:43 +0000
Received: ("Tessian outbound f1898412aff1:v103");
 Thu, 21 Oct 2021 12:03:43 +0000
Received: from 277b236c3d15.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 60EE2AE5-89E6-478A-8EEB-4F02B7B90E78.1; 
 Thu, 21 Oct 2021 12:03:36 +0000
Received: from EUR01-VE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 277b236c3d15.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Thu, 21 Oct 2021 12:03:36 +0000
Received: from AM6PR0502CA0060.eurprd05.prod.outlook.com
 (2603:10a6:20b:56::37) by DBBPR08MB4283.eurprd08.prod.outlook.com
 (2603:10a6:10:c3::18) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.18; Thu, 21 Oct
 2021 12:03:34 +0000
Received: from AM5EUR03FT037.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:56:cafe::90) by AM6PR0502CA0060.outlook.office365.com
 (2603:10a6:20b:56::37) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.18 via Frontend
 Transport; Thu, 21 Oct 2021 12:03:34 +0000
Received: from nebula.arm.com (40.67.248.234) by
 AM5EUR03FT037.mail.protection.outlook.com (10.152.17.241) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.4628.18 via Frontend Transport; Thu, 21 Oct 2021 12:03:33 +0000
Received: from AZ-NEU-EX03.Arm.com (10.251.24.31) by AZ-NEU-EX04.Arm.com
 (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.14; Thu, 21 Oct
 2021 12:03:26 +0000
Received: from hongda-OptiPlex-7070.shanghai.arm.com (10.169.190.17) by
 mail.arm.com (10.251.24.31) with Microsoft SMTP Server id 15.1.2308.14 via
 Frontend Transport; Thu, 21 Oct 2021 12:03:24 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f0fcaefa-3266-11ec-8376-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=aeBrb25lkUg4ZFd7p9e/6q189g93hVFhDDKIOKHGx14=;
 b=WKPGnI9v+DRX5b2jSEJk0vlAaH63EUnSikruaPeKfhtNl37Af1cenhYApyPQY4iVjqIW+hw3Cdag5bYyqqkEnzqmC7Yn1/Rj9dEXL9T4ZiK800HylOTHfRyceeJybz8BXzABn4O9d7DmJlRIejONm1/ZAuPLyo6V5Wxi1DTgE+c=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: dfb73327011297c1
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=DTjoFus6SmyY9CzXQSh0V0seL8OVCh/57mPp3nhfwDD7unX4UyTktilUWdEjzJBn9+aV0f2rY02E2KF5jzGgO6rivk4+HWYWX341hGuaZtSGQ0yS+tNMsSkFgqnhIbHZir2dHhJFcjoP0CDD/4SbHLHGUSLA6nKWGekiEBUqxmyiAtMudy1AiurYi1Dl2I3iZOXFtueMAsXCHpwcFQVgUZ+JusJVsxJzTVykzXfLskvUdrmjYh2IVKIaMP5xYgnmqfN1YrPnb2XLm/A+I79HqTN/UtUXJqNkYyF9COONAmMkfI2ZBCtLyEsxw09PWaBeUbCXn8u/LctCIPUVyQ8cow==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=aeBrb25lkUg4ZFd7p9e/6q189g93hVFhDDKIOKHGx14=;
 b=Mx39xC8Fbi9miECHtGsA+hf99+pVJHNsiS0JS5l4pBLUMrWPV0w9xbcotIjvueHE4XaE85iM5uFkJtfKUfh2NDPpw2WOc9I/QytzPMnC/MK/M2WPj0S7rvks2BpxlAH5IPrrUnptWqy1iYnQ3G88Yyh9iQWJo9Xlch7tUpEigjayYgfeXITvDtSalujkOeWS+6c3xr5iVQciL/OqhRUI7SwMMdTZ/mKVPxnyzowp0zqZ9Q2uz5Ohn5qsI9JatqGMMxTVjK2jqQkupXIpjKHvdhGoATjFqwiAD+jVqJkQNF3ZNBhuTai4lrQVgvoiUk6rGxdVa5Y/BgSF4YmO1ybVow==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=aeBrb25lkUg4ZFd7p9e/6q189g93hVFhDDKIOKHGx14=;
 b=WKPGnI9v+DRX5b2jSEJk0vlAaH63EUnSikruaPeKfhtNl37Af1cenhYApyPQY4iVjqIW+hw3Cdag5bYyqqkEnzqmC7Yn1/Rj9dEXL9T4ZiK800HylOTHfRyceeJybz8BXzABn4O9d7DmJlRIejONm1/ZAuPLyo6V5Wxi1DTgE+c=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=pass action=none
 header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 40.67.248.234 as permitted sender) receiver=protection.outlook.com;
 client-ip=40.67.248.234; helo=nebula.arm.com;
From: Hongda Deng <Hongda.Deng@arm.com>
To: <xen-devel@lists.xenproject.org>, <sstabellini@kernel.org>,
	<julien@xen.org>
CC: <Bertrand.Marquis@arm.com>, <Wei.Chen@arm.com>, <Hongda.Deng@arm.com>
Subject: [PATCH v4] xen/arm: vgic: Ignore write access to ICPENDR*
Date: Thu, 21 Oct 2021 20:03:19 +0800
Message-ID: <20211021120319.2394-1-Hongda.Deng@arm.com>
X-Mailer: git-send-email 2.17.1
MIME-Version: 1.0
Content-Type: text/plain
X-EOPAttributedMessage: 1
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: dfd7fddb-13d0-4789-44a5-08d9948ad407
X-MS-TrafficTypeDiagnostic: DBBPR08MB4283:|DB7PR08MB3675:
X-Microsoft-Antispam-PRVS:
	<DB7PR08MB367583354CDE56728B73F513E6BF9@DB7PR08MB3675.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Oob-TLC-OOBClassifiers: OLM:6430;OLM:6430;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 HkydOcgx5QVwjzQfXA614k5VHslUMlvw/3oEQwPnmTLnEeBiuuxoy4Du+CsPRbT5aAxpslwhOgAH7I+2iSxP1GNzIYCod/muCMWP4fn/adv+pnrpWTgSygqujYoriYEYmvJdFCmLvv2f6i7YY+AQxQociO6Kw2sGQov2vOQ7yV5K+v146kkwCTiUiH5VC5X4Ug5V78WVYQHZkmsQlh+0hl4zb2KMbFbnqNpdlg2Ixc1pQBmrhrWxVZThZg4AYS8jFC2Mc/VTeZKbIrTXrSrJL3AiAxgzx/lkPoemI2WB9VBRGjSMJEaBOllX2mqxi8DQbPTFrKIo+jaXHTxdjJZseToar363oR6Fo2ga8eM0TPLV23A2aGft91i1pOqAgs2GSFwG88JCIcIYlhkh7+bImCD1EdH0Gm6iwtrXG/+oTQjcZmMvFlzGrNTqJnZjtqJYPfyMO/pvdMF/itTaW8M94rHfFKSCiKsSNv7Ap9ABl/oNcb+hb9KshpWKca3I7BbcsFYfih0os2uBSt/ETscIqYUm2fCRswJ+4un3vqctzhzV0TN/wmjxVxElCQ8oRwOVavp3YVQWV74FZDDkEufCDDIazte0bmAX/45LESbvstdDpaN13eY49FLeTKFkx17BSVlYh5IB22b7b+6ZZtjhhAA1tu+Nfx8yZpCWyquOJAZD/XVZg854drgBeCilcL1iYO5wcFd8dK8Qfs0E98nkNThAu5xH4zYRQQocpP/zRwphWoCDlmYx2OotSvTUkdkzycjW7Csmcl2F/z5Ejmsm8xW8+ANADr0fe2eMSL88vCeocHfuuxunxahUdZGwPnUg
X-Forefront-Antispam-Report-Untrusted:
 CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(36756003)(508600001)(47076005)(7696005)(2906002)(6666004)(966005)(86362001)(83380400001)(26005)(336012)(5660300002)(82310400003)(54906003)(110136005)(8676002)(8936002)(316002)(1076003)(70206006)(36860700001)(2616005)(4326008)(81166007)(70586007)(426003)(356005)(186003)(36900700001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB4283
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT062.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	6e91ccd5-8f8b-477f-0987-08d9948ace8e
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	gd7Ewwkd/4cOTEETAiQMT2Rn6zAZhfyOAly3LXZBYiosPMpbdpgxxfZypyZ7tee/KhoI6ell7rtQ0xuelaujBaF4giZk3dHzj/R4WnQ/0BkF9S2VarTINpIIoxDof9Vp42rpfmmf3AcMM4NjAhxET359ZkRHqTWKRz+KaS2I4PF34OzlRMWqJ1IqL8ACMbb00icQCLbPc/cxIOQadFgO0D/Zpii8wMxRKG7SedquaHCcR5mYRi/H+f7LDC8kXmmFMsWKDCxu3Tkohrv+SwdeuYnWBZjHiggN5QSZW/h37o5ZvdgnP2hIJT2tmjvURMRLPX+7VFn3zHN++CYporrbOnNiMGoIa6Y1oumEUWtsNrIySKBzW9+w4zKhLIo5PYAS9OnSW/e6R7d50QrTsFvkzWI7qi7QnE1QdXGSWqBJDAwlxxHZiv/8fh7oHRh8MAQVBE23D6jN6Gmv4D2Cp4Ho+Hl3Yfceu9jkO5MgVyMmo8Uz8UNn4rgyQpX6USKpAvsqCAJ7xTTmoSqgwUp2JZ3ROo+70WLOcgva8ino3/tIgIFlgBHl+m+pCd0rRINlGpeyXyHAwjpmC3a+BWHIi9sW42ED97uzSa7WT7yMTneUzjqUwYO2gyF1zgG1Vj0+R3B5CXaRFXJu+wJs4TtZJWdVgMG6PMo3TPvrFtTcUif+e1xVmZlDeRIrgEpxMKWCgI4UGlGh/krFOb2cGkkdKXwM8nXT5vJe7wF3NM0s7nDjL6KLYxdgAULC3upenx46sdghj1JVH8OOi7nqN5KFfBIDf61RLKrP4yUdzUNMBrOwDng=
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(26005)(86362001)(54906003)(70586007)(8676002)(316002)(1076003)(81166007)(6666004)(426003)(2616005)(110136005)(47076005)(4326008)(83380400001)(2906002)(36860700001)(186003)(966005)(5660300002)(8936002)(7696005)(508600001)(82310400003)(36756003)(336012)(70206006);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Oct 2021 12:03:43.3209
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: dfd7fddb-13d0-4789-44a5-08d9948ad407
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT062.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3675

Currently, Xen will return IO unhandled when guests write ICPENDR*
virtual registers, which will raise a data abort inside the guest.
For Linux guest, these virtual registers will not be accessed. But
for Zephyr, these virtual registers will be accessed during the
initialization. Zephyr guest will get an IO data abort and crash.
Emulating ICPENDR is not easy with the existing vGIC, this patch
reworks the emulation to ignore write access to ICPENDR* virtual
registers and print a message about whether they are already pending
instead of returning unhandled.
More details can be found at [1].

[1] https://github.com/zephyrproject-rtos/zephyr/blob/eaf6cf745df3807e6e
cc941c3a30de6c179ae359/drivers/interrupt_controller/intc_gicv3.c#L274

Signed-off-by: Hongda Deng <hongda.deng@arm.com>
---
Changes since v3:
 *  Commit message modification
 *  Change "goto write_ignore_32" to "goto write_ignore" to avoid double
    checking dabt.size
 *  Delete data.size check in vgic_v3_rdistr_sgi_mmio_write to avoid
    double check in __vgic_v3_distr_common_mmio_write for SGI
 *  Declare flags, p, v_target within the loop to reduce their scope
 *  Use the same vgic_get_target_vcpu(v, irq) to get v_target for SPI,
    PPI and SGI
 *  Code principle modification
Changes since v2:
 *  Avoid to print messages when there is no pending interrupt
 *  Add helper vgic_check_inflight_irqs_pending to check pending status
 *  Print a message for each interrupt separately
Changes since v1:
 *  Check pending states by going through vcpu->arch.vgic.inflight_irqs
    instead of checking hardware registers
---
 xen/arch/arm/vgic-v2.c     | 10 ++++++----
 xen/arch/arm/vgic-v3.c     | 17 ++++++++---------
 xen/arch/arm/vgic.c        | 28 ++++++++++++++++++++++++++++
 xen/include/asm-arm/vgic.h |  2 ++
 4 files changed, 44 insertions(+), 13 deletions(-)

diff --git a/xen/arch/arm/vgic-v2.c b/xen/arch/arm/vgic-v2.c
index b2da886adc..589c033eda 100644
--- a/xen/arch/arm/vgic-v2.c
+++ b/xen/arch/arm/vgic-v2.c
@@ -481,10 +481,12 @@ static int vgic_v2_distr_mmio_write(struct vcpu *v, mmio_info_t *info,
 
     case VRANGE32(GICD_ICPENDR, GICD_ICPENDRN):
         if ( dabt.size != DABT_WORD ) goto bad_width;
-        printk(XENLOG_G_ERR
-               "%pv: vGICD: unhandled word write %#"PRIregister" to ICPENDR%d\n",
-               v, r, gicd_reg - GICD_ICPENDR);
-        return 0;
+        rank = vgic_rank_offset(v, 1, gicd_reg - GICD_ICPENDR, DABT_WORD);
+        if ( rank == NULL ) goto write_ignore;
+
+        vgic_check_inflight_irqs_pending(v->domain, v, rank->index, r);
+
+        goto write_ignore;
 
     case VRANGE32(GICD_ISACTIVER, GICD_ISACTIVERN):
         if ( dabt.size != DABT_WORD ) goto bad_width;
diff --git a/xen/arch/arm/vgic-v3.c b/xen/arch/arm/vgic-v3.c
index cb5a70c42e..65bb7991a6 100644
--- a/xen/arch/arm/vgic-v3.c
+++ b/xen/arch/arm/vgic-v3.c
@@ -817,10 +817,12 @@ static int __vgic_v3_distr_common_mmio_write(const char *name, struct vcpu *v,
 
     case VRANGE32(GICD_ICPENDR, GICD_ICPENDRN):
         if ( dabt.size != DABT_WORD ) goto bad_width;
-        printk(XENLOG_G_ERR
-               "%pv: %s: unhandled word write %#"PRIregister" to ICPENDR%d\n",
-               v, name, r, reg - GICD_ICPENDR);
-        return 0;
+        rank = vgic_rank_offset(v, 1, reg - GICD_ICPENDR, DABT_WORD);
+        if ( rank == NULL ) goto write_ignore;
+
+        vgic_check_inflight_irqs_pending(v->domain, v, rank->index, r);
+
+        goto write_ignore;
 
     case VRANGE32(GICD_ISACTIVER, GICD_ISACTIVERN):
         if ( dabt.size != DABT_WORD ) goto bad_width;
@@ -986,11 +988,8 @@ static int vgic_v3_rdistr_sgi_mmio_write(struct vcpu *v, mmio_info_t *info,
                                                  info, gicr_reg, r);
 
     case VREG32(GICR_ICPENDR0):
-        if ( dabt.size != DABT_WORD ) goto bad_width;
-        printk(XENLOG_G_ERR
-               "%pv: vGICR: SGI: unhandled word write %#"PRIregister" to ICPENDR0\n",
-               v, r);
-        return 0;
+        return __vgic_v3_distr_common_mmio_write("vGICR: SGI", v,
+                                                 info, gicr_reg, r);
 
     case VREG32(GICR_IGRPMODR0):
         /* We do not implement security extensions for guests, write ignore */
diff --git a/xen/arch/arm/vgic.c b/xen/arch/arm/vgic.c
index 8f9400a519..83386cf3d5 100644
--- a/xen/arch/arm/vgic.c
+++ b/xen/arch/arm/vgic.c
@@ -726,6 +726,34 @@ unsigned int vgic_max_vcpus(unsigned int domctl_vgic_version)
     }
 }
 
+void vgic_check_inflight_irqs_pending(struct domain *d, struct vcpu *v,
+                                      unsigned int rank, uint32_t r)
+{
+    const unsigned long mask = r;
+    unsigned int i;
+
+    for_each_set_bit( i, &mask, 32 )
+    {
+        struct pending_irq *p;
+        struct vcpu *v_target;
+        unsigned long flags;
+        unsigned int irq = i + 32 * rank;
+
+        v_target = vgic_get_target_vcpu(v, irq);
+
+        spin_lock_irqsave(&v_target->arch.vgic.lock, flags);
+
+        p = irq_to_pending(v_target, irq);
+
+        if ( p && !list_empty(&p->inflight) )
+            printk(XENLOG_G_WARNING
+                   "%pv trying to clear pending interrupt %u.\n",
+                   v, irq);
+
+        spin_unlock_irqrestore(&v_target->arch.vgic.lock, flags);
+    }
+}
+
 /*
  * Local variables:
  * mode: C
diff --git a/xen/include/asm-arm/vgic.h b/xen/include/asm-arm/vgic.h
index 62c2ae538d..e69a59063a 100644
--- a/xen/include/asm-arm/vgic.h
+++ b/xen/include/asm-arm/vgic.h
@@ -298,6 +298,8 @@ extern bool vgic_to_sgi(struct vcpu *v, register_t sgir,
                         enum gic_sgi_mode irqmode, int virq,
                         const struct sgi_target *target);
 extern bool vgic_migrate_irq(struct vcpu *old, struct vcpu *new, unsigned int irq);
+extern void vgic_check_inflight_irqs_pending(struct domain *d, struct vcpu *v,
+                                             unsigned int rank, uint32_t r);
 
 #endif /* !CONFIG_NEW_VGIC */
 
-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Thu Oct 21 13:12:40 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Oct 2021 13:12:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.214381.372901 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdXrq-0007w4-Kf; Thu, 21 Oct 2021 13:12:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 214381.372901; Thu, 21 Oct 2021 13:12:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdXrq-0007vx-HE; Thu, 21 Oct 2021 13:12:22 +0000
Received: by outflank-mailman (input) for mailman id 214381;
 Thu, 21 Oct 2021 13:12:21 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=LMzw=PJ=kernel.org=kuba@srs-us1.protection.inumbo.net>)
 id 1mdXrp-0007vr-M0
 for xen-devel@lists.xenproject.org; Thu, 21 Oct 2021 13:12:21 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 41f43822-9ac3-4132-841f-7280ae5d09c8;
 Thu, 21 Oct 2021 13:12:20 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id 7375261205;
 Thu, 21 Oct 2021 13:12:19 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 41f43822-9ac3-4132-841f-7280ae5d09c8
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1634821939;
	bh=R+swL9rmtFSenC2ia6irgU9Xg+bV/QFrmjtvxo3XbsE=;
	h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
	b=iiGFiR9AtPXvLEtLJrSkKq8YyvpJD2rPBTrAhGgShZoIRr/As7wxT7ATkAAu+giE9
	 v0jGu2Q4fgaA1iISi8H/ppCDO+J14EUO1en5FtLzAFJvEcrMe+76jOdf8AVtI4oU67
	 yAxjguENrz4pzm31PVKiTHi4yqr5OPlD9xYuDANDMJ4u0brKXyOR6fEjcci8zCdIZP
	 EkKZgwdElMqwyMtW3VhSiGhyjDoih6CWeOb7ACOQd+Yy1E8JeLk02hSy59dY//po6H
	 G1csD6u/z2PDHbA4s1rGFshGa348gaaYWMhWe2Fv2ba6SgbxsnOTNnWRHKfjb9hvbV
	 ZT9fkXocwc2Fw==
From: Jakub Kicinski <kuba@kernel.org>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org,
	Jakub Kicinski <kuba@kernel.org>,
	wei.liu@kernel.org,
	paul@xen.org,
	boris.ostrovsky@oracle.com,
	jgross@suse.com,
	sstabellini@kernel.org,
	xen-devel@lists.xenproject.org
Subject: [PATCH net-next v2 01/12] net: xen: use eth_hw_addr_set()
Date: Thu, 21 Oct 2021 06:12:03 -0700
Message-Id: <20211021131214.2032925-2-kuba@kernel.org>
X-Mailer: git-send-email 2.31.1
In-Reply-To: <20211021131214.2032925-1-kuba@kernel.org>
References: <20211021131214.2032925-1-kuba@kernel.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Commit 406f42fa0d3c ("net-next: When a bond have a massive amount
of VLANs...") introduced a rbtree for faster Ethernet address look
up. To maintain netdev->dev_addr in this tree we need to make all
the writes to it got through appropriate helpers.

Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
CC: wei.liu@kernel.org
CC: paul@xen.org
CC: boris.ostrovsky@oracle.com
CC: jgross@suse.com
CC: sstabellini@kernel.org
CC: xen-devel@lists.xenproject.org
---
 drivers/net/xen-netback/interface.c | 6 ++++--
 drivers/net/xen-netfront.c          | 4 +++-
 2 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/drivers/net/xen-netback/interface.c b/drivers/net/xen-netback/interface.c
index c58996c1e230..fe8e21ad8ed9 100644
--- a/drivers/net/xen-netback/interface.c
+++ b/drivers/net/xen-netback/interface.c
@@ -494,6 +494,9 @@ static const struct net_device_ops xenvif_netdev_ops = {
 struct xenvif *xenvif_alloc(struct device *parent, domid_t domid,
 			    unsigned int handle)
 {
+	static const u8 dummy_addr[ETH_ALEN] = {
+		0xfe, 0xff, 0xff, 0xff, 0xff, 0xff,
+	};
 	int err;
 	struct net_device *dev;
 	struct xenvif *vif;
@@ -551,8 +554,7 @@ struct xenvif *xenvif_alloc(struct device *parent, domid_t domid,
 	 * stolen by an Ethernet bridge for STP purposes.
 	 * (FE:FF:FF:FF:FF:FF)
 	 */
-	eth_broadcast_addr(dev->dev_addr);
-	dev->dev_addr[0] &= ~0x01;
+	eth_hw_addr_set(dev, dummy_addr);
 
 	netif_carrier_off(dev);
 
diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c
index e31b98403f31..57437e4b8a94 100644
--- a/drivers/net/xen-netfront.c
+++ b/drivers/net/xen-netfront.c
@@ -2157,6 +2157,7 @@ static int talk_to_netback(struct xenbus_device *dev,
 	unsigned int max_queues = 0;
 	struct netfront_queue *queue = NULL;
 	unsigned int num_queues = 1;
+	u8 addr[ETH_ALEN];
 
 	info->netdev->irq = 0;
 
@@ -2170,11 +2171,12 @@ static int talk_to_netback(struct xenbus_device *dev,
 					"feature-split-event-channels", 0);
 
 	/* Read mac addr. */
-	err = xen_net_read_mac(dev, info->netdev->dev_addr);
+	err = xen_net_read_mac(dev, addr);
 	if (err) {
 		xenbus_dev_fatal(dev, err, "parsing %s/mac", dev->nodename);
 		goto out_unlocked;
 	}
+	eth_hw_addr_set(info->netdev, addr);
 
 	info->netback_has_xdp_headroom = xenbus_read_unsigned(info->xbdev->otherend,
 							      "feature-xdp-headroom", 0);
-- 
2.31.1



From xen-devel-bounces@lists.xenproject.org Thu Oct 21 13:15:46 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Oct 2021 13:15:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.214389.372912 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdXv8-00008l-4C; Thu, 21 Oct 2021 13:15:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 214389.372912; Thu, 21 Oct 2021 13:15:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdXv8-00008e-15; Thu, 21 Oct 2021 13:15:46 +0000
Received: by outflank-mailman (input) for mailman id 214389;
 Thu, 21 Oct 2021 13:15:45 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Wrrh=PJ=arm.com=Bertrand.Marquis@srs-us1.protection.inumbo.net>)
 id 1mdXv7-00008Y-1a
 for xen-devel@lists.xenproject.org; Thu, 21 Oct 2021 13:15:45 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com (unknown
 [40.107.6.83]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 32d5f673-5a69-472f-93df-f8c78dac1184;
 Thu, 21 Oct 2021 13:15:43 +0000 (UTC)
Received: from AS8PR04CA0093.eurprd04.prod.outlook.com (2603:10a6:20b:31e::8)
 by PA4PR08MB6125.eurprd08.prod.outlook.com (2603:10a6:102:e1::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.16; Thu, 21 Oct
 2021 13:15:40 +0000
Received: from VE1EUR03FT037.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:31e:cafe::1a) by AS8PR04CA0093.outlook.office365.com
 (2603:10a6:20b:31e::8) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.18 via Frontend
 Transport; Thu, 21 Oct 2021 13:15:40 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT037.mail.protection.outlook.com (10.152.19.70) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4628.18 via Frontend Transport; Thu, 21 Oct 2021 13:15:40 +0000
Received: ("Tessian outbound e27daf245730:v103");
 Thu, 21 Oct 2021 13:15:40 +0000
Received: from ac887a8fc512.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 E261F624-C81A-426D-812F-A0F21421F60D.1; 
 Thu, 21 Oct 2021 13:15:26 +0000
Received: from EUR03-AM5-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id ac887a8fc512.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Thu, 21 Oct 2021 13:15:26 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com (2603:10a6:4:74::9)
 by DB9PR08MB6825.eurprd08.prod.outlook.com (2603:10a6:10:2af::9) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.18; Thu, 21 Oct
 2021 13:15:24 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955]) by DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955%4]) with mapi id 15.20.4608.018; Thu, 21 Oct 2021
 13:15:23 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 32d5f673-5a69-472f-93df-f8c78dac1184
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=HbAihz/x6+FQaM93I6Lv4PIswepqt8mIpMxvUa2xX7o=;
 b=mKoV5ir1T3mQ6+hKm2pYUJWb/rKNUWDaXhCm32l5XjMVkwCPKVQtdqETzc2fqXf/c6e6qUv1dMofTUrjV4SSmeK3i7J53IdzpmubIUk6pTq1b4UXqGfz0VEiaD9+9u7W11+jdHiqLnI+R258QJsXjeqLBl+OfsWwSc2zHSgb3EM=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: a93e5592abe25937
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=l3pUvR67IBvRTo9fRDwgnRj2VcmCu5LSGp+PwqiWOmRJOxDN9IJNaFCrFn7aOfokXYZ2ZPpbS5OQeAePHVMWAN5OspFeHXkJTZti2qjsnIihT65zcZ8SztcL5908V3Ne32dprFBQ/o/0S+7oe5bjArBrBP4dl+zbPqbD1wDNcAt+Fr2pLDDMUzE7yIno48hIn/ozudDJrZMUAU1TPnGNFvTHpvoRRUtlYP87hS5gh1BPN+ztT1OID4zrmRyiSl8D2gwJUWzyI2opdGrR8zV84MJ5gkKFFYEI5i8Ha+R+SSIPfdnfpEOZ92QLOfgJLaYrE5BFfEQxr5X3RL+nbswYSg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=HbAihz/x6+FQaM93I6Lv4PIswepqt8mIpMxvUa2xX7o=;
 b=ggqBCoUIgAyZRVue6p19AWgks4lJQnc1304JP4AbUYGZSA+XDU+mIOItuAod6jJzJ/oYbmC/AQ3OzIemxhgL4S1m4OBRVczuQGZnD82qdxfn4LyFcpNSxqRN0tCGZ8zrF+c3KF8Po4oVD/6wsGiLO1YB4sVs+F/BrInjLKuZ/Sl8tG/HD1bl23nzeRprDzQPEbmozOwUtEyT9Ecwj9z/batsEe8rCGi0St+kcxfR8Pj4R1/GvktlJVzd3jUGAUvh2v6v37mz+2i8EVw3SOFDqMTaFOHhwzVuWvxfAjVZk/hMr2cL5pTBwBCYDSxTXO+ZnZpTeqSKG33zivO6CFWlGA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=HbAihz/x6+FQaM93I6Lv4PIswepqt8mIpMxvUa2xX7o=;
 b=mKoV5ir1T3mQ6+hKm2pYUJWb/rKNUWDaXhCm32l5XjMVkwCPKVQtdqETzc2fqXf/c6e6qUv1dMofTUrjV4SSmeK3i7J53IdzpmubIUk6pTq1b4UXqGfz0VEiaD9+9u7W11+jdHiqLnI+R258QJsXjeqLBl+OfsWwSc2zHSgb3EM=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Julien Grall <julien@xen.org>
CC: Rahul Singh <Rahul.Singh@arm.com>, Xen-devel
	<xen-devel@lists.xenproject.org>, Andre Przywara <Andre.Przywara@arm.com>,
	Stefano Stabellini <sstabellini@kernel.org>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
	Jan Beulich <jbeulich@suse.com>, Wei Liu <wl@xen.org>,
	=?iso-8859-1?Q?Roger_Pau_Monn=E9?= <roger.pau@citrix.com>
Subject: Re: xen/arm: Missing appropriate locking for the IOMMU (WAS Re:
 [PATCH v5 02/11] xen/arm: Add PHYSDEVOP_pci_device_(*add/remove) support for
 ARM)
Thread-Topic: xen/arm: Missing appropriate locking for the IOMMU (WAS Re:
 [PATCH v5 02/11] xen/arm: Add PHYSDEVOP_pci_device_(*add/remove) support for
 ARM)
Thread-Index: AQHXxl4YkvgVlFH7LEi1mWK2psfiI6vdbqqA
Date: Thu, 21 Oct 2021 13:15:21 +0000
Message-ID: <75784F90-198E-400D-877B-CF62ED69F409@arm.com>
References: <cover.1633540842.git.rahul.singh@arm.com>
 <0dc4423b2e20c1eb40c961b211b18ed041f707b7.1633540842.git.rahul.singh@arm.com>
 <99f6d6c4-bcc6-03a9-ef9b-0d01be0fd7f1@xen.org>
In-Reply-To: <99f6d6c4-bcc6-03a9-ef9b-0d01be0fd7f1@xen.org>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3654.120.0.1.13)
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: fb3e3727-ec4c-4dd7-8c9f-08d99494e15b
x-ms-traffictypediagnostic: DB9PR08MB6825:|PA4PR08MB6125:
X-Microsoft-Antispam-PRVS:
	<PA4PR08MB612507F95EA756B697EA066C9DBF9@PA4PR08MB6125.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:8882;OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 Ok0ehB27jp+A/25hOLXlfBjJhxSNdTrLn6MBkqi/3LeIcOhWrHqDluyOuAC888zhqEzr1eNF/9g1QMwo6nJijBnz7Dtk1M3FTADrTEFaE2Jsd93eaiwtFtSbWqklyKb2BCipRVKqHncdBMdBnb/c/y4xQqPjmZMRJppngeM7okgPTCAbi21hep94ZhReTTyxMvImeDFYwzJYz1eS2FyBzMN4W+PrSuua10wn9DXVOQ5uRz+YooQpr52EdXzf5EppY2K8pZs3Bv7oJgiwSgxj+sOc7eEdOLDK6+lw7isgCGo1ftZ7d2WRKfyKcCHdzZrYj/FuP0wjKrLaNVDRuqCIHG6GsdCyJXMN8I56Xh9Pav34/DZK7vJtRUp+wW3D8rFGGnGLERk17YHXF5vFmbxvkFet4AgycGAfH60m4td3bTkEkvtOTQO85qZxpMXMsZB9WOQQkWsPlJhdRH2VW6Gj7zVFBYzykSmypWXVWHcxLQVn5ytHIGQ8fc0r7vxXLZY1vle1Q87no3M4nJ3mErA0zFDJqaUMpxWRszJeZXECpDWJTM8fOiS7/jxa1cvxVgJW9txVoFnWhRXqRPwUeSdooeW++gaDujTCATWTi0A8qSgSE9+g4g+DO4jsSZ0q4K+60ZJmVvkrYmgaZoqic8gXp2u2JYcYqfiqlf6HzlJziVCgC01VYPUkZQ7CDha5raGl5XhHX0gXoqJq5modrRoWQ1c35ftR8oXWQf24ctPTl3WxTRs1r22uBdHT+RfgZ4sb
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB6PR0801MB2024.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(38100700002)(66476007)(64756008)(6506007)(66446008)(122000001)(66556008)(66946007)(508600001)(36756003)(6512007)(6916009)(91956017)(2616005)(33656002)(186003)(26005)(53546011)(76116006)(8936002)(8676002)(316002)(71200400001)(86362001)(7416002)(2906002)(6486002)(4326008)(38070700005)(83380400001)(5660300002)(54906003)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="iso-8859-1"
Content-ID: <005F5841DC1A4C4DB5D17B2C4191E22D@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB6825
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT037.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	0fb7b4d6-ffb9-4b9a-771a-08d99494d724
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	WRg8pPjamfO/YlfPo4FlYMOwfJVcHG0NlIyudg2lzck1jU9GSNqAGRaD5FXejL8ys9DryMGhokkyACQRAQ3Gbyk8UMVQY6Ku92rNqNsTEtGbfKNWcUczFGTYf/qr3yogIUlZrxsjWTUA/7x0shYs3BXN7zapMIR+aPisveEq0li7uR5KJGw014I1SIFOc2KDhaTk86S4oP4uUbp4gW8nL9+V/QODyvppzeT58Sb2TJjeDrgvxcMub5qaMOSMGQDtTmbE2fd+KyWSN2QDA1Z0Dz3N8520vdzKun+3/bHDBsagJew62S8S2Lk4W/q5EWMJBQNE6Mf5RBV6MMqwl4q8qjduTaBU4ObwE7JOx1cAC0sY3ERP8+xTbF5qBWIm9+/ET5YYovSwo5Fx1vEncXU0zcXNx3LNhVfXFr+J/diVD/2ULbrEl8X3mMhfEzXUvK2wfHqdrlZ3Wv+6fwUkAhqaPiczW1HrnYdfWnKcQG4htpdyiF4B1aAUoXqXDfVnyIcVKsSNNd8vxjzjAV4ZoiqxaMr2IUMuuXiY0vihBtemEG+ogErd2jHEnKh9Yod3u9kEaybp/6a4EFSLRs92Ig8DKG1xw2YoQ03fm9E2qTcNpcm2y2+bMR4e/qJDQ/uWA8l2u1Gdw5pJU6SmcYi0auMtpFd5mTofc+x9b/U28khs95BVZwG0UeVqhKXpbha+9vqz83TjpOCeDYvl8lJNhEd6Dg==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(83380400001)(356005)(6862004)(4326008)(53546011)(6506007)(36756003)(6486002)(47076005)(2906002)(2616005)(33656002)(82310400003)(70586007)(316002)(70206006)(107886003)(54906003)(5660300002)(86362001)(81166007)(36860700001)(336012)(508600001)(26005)(8936002)(8676002)(6512007)(186003);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Oct 2021 13:15:40.5530
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: fb3e3727-ec4c-4dd7-8c9f-08d99494e15b
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT037.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB6125

Hi Julien,

> On 21 Oct 2021, at 10:28, Julien Grall <julien@xen.org> wrote:
>=20
> Hi all,
>=20
> While going through the passthrough code. I noticed that we don't have a =
common lock for the IOMMU between the PCI and DT code.
>=20
> This is going to be an issue given it would technically be possible to ad=
d a PCI device while assigning a DT.
>=20
> Rahul, Bertrand, Oleksandr, can you have a look at the issue?

Yes we can have a look at this.

Right now pci device add is done by dom0 so I do not think we have an issue=
 in practice unless I wrongly understood something.
But for sure in theory yes we need to look at this.

Cheers
Bertrand=20

>=20
> Cheers,
>=20
> On 06/10/2021 18:40, Rahul Singh wrote:
>> Hardware domain is in charge of doing the PCI enumeration and will
>> discover the PCI devices and then will communicate to XEN via hyper
>> call PHYSDEVOP_pci_device_add(..) to add the PCI devices in XEN.
>> Also implement PHYSDEVOP_pci_device_remove(..) to remove the PCI device.
>> As most of the code for PHYSDEVOP_pci_device_* is the same between x86
>> and ARM, move the code to a common file to avoid duplication.
>> There are other PHYSDEVOP_pci_device_* operations to add PCI devices.
>> Currently implemented PHYSDEVOP_pci_device_remove(..) and
>> PHYSDEVOP_pci_device_add(..) only as those are minimum required to
>> support PCI passthrough on ARM.
>> Signed-off-by: Rahul Singh <rahul.singh@arm.com>
>> ---
>> Change in v5:
>> - Move the pci_physdev_op() stub to xen/arch/arm/physdev.c.
>> Change in v4:
>> - Move file commom/physdev.c to drivers/pci/physdev.c
>> - minor comments.
>> Change in v3: Fixed minor comment.
>> Change in v2:
>> - Add support for PHYSDEVOP_pci_device_remove()
>> - Move code to common code
>> ---
>> ---
>>  xen/arch/arm/physdev.c        |  6 ++-
>>  xen/arch/x86/physdev.c        | 52 +----------------------
>>  xen/arch/x86/x86_64/physdev.c |  2 +-
>>  xen/drivers/pci/Makefile      |  1 +
>>  xen/drivers/pci/physdev.c     | 80 +++++++++++++++++++++++++++++++++++
>>  xen/include/public/arch-arm.h |  4 +-
>>  xen/include/xen/hypercall.h   |  4 ++
>>  7 files changed, 96 insertions(+), 53 deletions(-)
>>  create mode 100644 xen/drivers/pci/physdev.c
>> diff --git a/xen/arch/arm/physdev.c b/xen/arch/arm/physdev.c
>> index e91355fe22..f9aa274dda 100644
>> --- a/xen/arch/arm/physdev.c
>> +++ b/xen/arch/arm/physdev.c
>> @@ -8,13 +8,17 @@
>>  #include <xen/lib.h>
>>  #include <xen/errno.h>
>>  #include <xen/sched.h>
>> -#include <asm/hypercall.h>
>> +#include <xen/hypercall.h>
>>      int do_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
>>  {
>> +#ifdef CONFIG_HAS_PCI
>> +    return pci_physdev_op(cmd, arg);
>> +#else
>>      gdprintk(XENLOG_DEBUG, "PHYSDEVOP cmd=3D%d: not implemented\n", cmd=
);
>>      return -ENOSYS;
>> +#endif
>>  }
>>    /*
>> diff --git a/xen/arch/x86/physdev.c b/xen/arch/x86/physdev.c
>> index 23465bcd00..ea38be8b79 100644
>> --- a/xen/arch/x86/physdev.c
>> +++ b/xen/arch/x86/physdev.c
>> @@ -12,7 +12,7 @@
>>  #include <asm/io_apic.h>
>>  #include <asm/msi.h>
>>  #include <asm/hvm/irq.h>
>> -#include <asm/hypercall.h>
>> +#include <xen/hypercall.h>
>>  #include <public/xen.h>
>>  #include <public/physdev.h>
>>  #include <xsm/xsm.h>
>> @@ -480,54 +480,6 @@ ret_t do_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM=
(void) arg)
>>          break;
>>      }
>>  -    case PHYSDEVOP_pci_device_add: {
>> -        struct physdev_pci_device_add add;
>> -        struct pci_dev_info pdev_info;
>> -        nodeid_t node;
>> -
>> -        ret =3D -EFAULT;
>> -        if ( copy_from_guest(&add, arg, 1) !=3D 0 )
>> -            break;
>> -
>> -        pdev_info.is_extfn =3D !!(add.flags & XEN_PCI_DEV_EXTFN);
>> -        if ( add.flags & XEN_PCI_DEV_VIRTFN )
>> -        {
>> -            pdev_info.is_virtfn =3D 1;
>> -            pdev_info.physfn.bus =3D add.physfn.bus;
>> -            pdev_info.physfn.devfn =3D add.physfn.devfn;
>> -        }
>> -        else
>> -            pdev_info.is_virtfn =3D 0;
>> -
>> -        if ( add.flags & XEN_PCI_DEV_PXM )
>> -        {
>> -            uint32_t pxm;
>> -            size_t optarr_off =3D offsetof(struct physdev_pci_device_ad=
d, optarr) /
>> -                                sizeof(add.optarr[0]);
>> -
>> -            if ( copy_from_guest_offset(&pxm, arg, optarr_off, 1) )
>> -                break;
>> -
>> -            node =3D pxm_to_node(pxm);
>> -        }
>> -        else
>> -            node =3D NUMA_NO_NODE;
>> -
>> -        ret =3D pci_add_device(add.seg, add.bus, add.devfn, &pdev_info,=
 node);
>> -        break;
>> -    }
>> -
>> -    case PHYSDEVOP_pci_device_remove: {
>> -        struct physdev_pci_device dev;
>> -
>> -        ret =3D -EFAULT;
>> -        if ( copy_from_guest(&dev, arg, 1) !=3D 0 )
>> -            break;
>> -
>> -        ret =3D pci_remove_device(dev.seg, dev.bus, dev.devfn);
>> -        break;
>> -    }
>> -
>>      case PHYSDEVOP_prepare_msix:
>>      case PHYSDEVOP_release_msix: {
>>          struct physdev_pci_device dev;
>> @@ -663,7 +615,7 @@ ret_t do_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(=
void) arg)
>>      }
>>        default:
>> -        ret =3D -ENOSYS;
>> +        ret =3D pci_physdev_op(cmd, arg);
>>          break;
>>      }
>>  diff --git a/xen/arch/x86/x86_64/physdev.c b/xen/arch/x86/x86_64/physde=
v.c
>> index 0a50cbd4d8..e3cbd5ebcb 100644
>> --- a/xen/arch/x86/x86_64/physdev.c
>> +++ b/xen/arch/x86/x86_64/physdev.c
>> @@ -9,7 +9,7 @@ EMIT_FILE;
>>  #include <compat/xen.h>
>>  #include <compat/event_channel.h>
>>  #include <compat/physdev.h>
>> -#include <asm/hypercall.h>
>> +#include <xen/hypercall.h>
>>    #define do_physdev_op compat_physdev_op
>>  diff --git a/xen/drivers/pci/Makefile b/xen/drivers/pci/Makefile
>> index a98035df4c..972c923db0 100644
>> --- a/xen/drivers/pci/Makefile
>> +++ b/xen/drivers/pci/Makefile
>> @@ -1 +1,2 @@
>>  obj-y +=3D pci.o
>> +obj-y +=3D physdev.o
>> diff --git a/xen/drivers/pci/physdev.c b/xen/drivers/pci/physdev.c
>> new file mode 100644
>> index 0000000000..4f3e1a96c0
>> --- /dev/null
>> +++ b/xen/drivers/pci/physdev.c
>> @@ -0,0 +1,80 @@
>> +
>> +#include <xen/guest_access.h>
>> +#include <xen/hypercall.h>
>> +#include <xen/init.h>
>> +
>> +#ifndef COMPAT
>> +typedef long ret_t;
>> +#endif
>> +
>> +ret_t pci_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
>> +{
>> +    ret_t ret;
>> +
>> +    switch ( cmd )
>> +    {
>> +    case PHYSDEVOP_pci_device_add: {
>> +        struct physdev_pci_device_add add;
>> +        struct pci_dev_info pdev_info;
>> +        nodeid_t node =3D NUMA_NO_NODE;
>> +
>> +        ret =3D -EFAULT;
>> +        if ( copy_from_guest(&add, arg, 1) !=3D 0 )
>> +            break;
>> +
>> +        pdev_info.is_extfn =3D (add.flags & XEN_PCI_DEV_EXTFN);
>> +        if ( add.flags & XEN_PCI_DEV_VIRTFN )
>> +        {
>> +            pdev_info.is_virtfn =3D true;
>> +            pdev_info.physfn.bus =3D add.physfn.bus;
>> +            pdev_info.physfn.devfn =3D add.physfn.devfn;
>> +        }
>> +        else
>> +            pdev_info.is_virtfn =3D false;
>> +
>> +#ifdef CONFIG_NUMA
>> +        if ( add.flags & XEN_PCI_DEV_PXM )
>> +        {
>> +            uint32_t pxm;
>> +            size_t optarr_off =3D offsetof(struct physdev_pci_device_ad=
d, optarr) /
>> +                                sizeof(add.optarr[0]);
>> +
>> +            if ( copy_from_guest_offset(&pxm, arg, optarr_off, 1) )
>> +                break;
>> +
>> +            node =3D pxm_to_node(pxm);
>> +        }
>> +#endif
>> +
>> +        ret =3D pci_add_device(add.seg, add.bus, add.devfn, &pdev_info,=
 node);
>> +        break;
>> +    }
>> +
>> +    case PHYSDEVOP_pci_device_remove: {
>> +        struct physdev_pci_device dev;
>> +
>> +        ret =3D -EFAULT;
>> +        if ( copy_from_guest(&dev, arg, 1) !=3D 0 )
>> +            break;
>> +
>> +        ret =3D pci_remove_device(dev.seg, dev.bus, dev.devfn);
>> +        break;
>> +    }
>> +
>> +    default:
>> +        ret =3D -ENOSYS;
>> +        break;
>> +    }
>> +
>> +    return ret;
>> +}
>> +
>> +/*
>> + * Local variables:
>> + * mode: C
>> + * c-file-style: "BSD"
>> + * c-basic-offset: 4
>> + * tab-width: 4
>> + * indent-tabs-mode: nil
>> + * End:
>> + */
>> diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm=
.h
>> index 6b5a5f818a..d46c61fca9 100644
>> --- a/xen/include/public/arch-arm.h
>> +++ b/xen/include/public/arch-arm.h
>> @@ -107,7 +107,9 @@
>>   *   All generic sub-operations
>>   *
>>   *  HYPERVISOR_physdev_op
>> - *   No sub-operations are currenty supported
>> + *   Exactly these sub-operations are supported:
>> + *   PHYSDEVOP_pci_device_add
>> + *   PHYSDEVOP_pci_device_remove
>>   *
>>   *  HYPERVISOR_sysctl
>>   *   All generic sub-operations, with the exception of:
>> diff --git a/xen/include/xen/hypercall.h b/xen/include/xen/hypercall.h
>> index 3771487a30..07b10ec230 100644
>> --- a/xen/include/xen/hypercall.h
>> +++ b/xen/include/xen/hypercall.h
>> @@ -45,6 +45,10 @@ extern long
>>  do_platform_op(
>>      XEN_GUEST_HANDLE_PARAM(xen_platform_op_t) u_xenpf_op);
>>  +extern long
>> +pci_physdev_op(
>> +    int cmd, XEN_GUEST_HANDLE_PARAM(void) arg);
>> +
>>  /*
>>   * To allow safe resume of do_memory_op() after preemption, we need to =
know
>>   * at what point in the page list to resume. For this purpose I steal t=
he
>=20
> --=20
> Julien Grall



From xen-devel-bounces@lists.xenproject.org Thu Oct 21 13:45:17 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Oct 2021 13:45:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.214399.372923 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdYNZ-0003Ms-Kp; Thu, 21 Oct 2021 13:45:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 214399.372923; Thu, 21 Oct 2021 13:45:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdYNZ-0003Ml-HF; Thu, 21 Oct 2021 13:45:09 +0000
Received: by outflank-mailman (input) for mailman id 214399;
 Thu, 21 Oct 2021 13:45:07 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=qr3f=PJ=citrix.com=roger.pau@srs-us1.protection.inumbo.net>)
 id 1mdYNX-0003Lu-F8
 for xen-devel@lists.xenproject.org; Thu, 21 Oct 2021 13:45:07 +0000
Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id f325ece4-9260-4074-bc43-23d58a20a330;
 Thu, 21 Oct 2021 13:45:05 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f325ece4-9260-4074-bc43-23d58a20a330
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1634823905;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=72kUg2ZZHwRaqGqivp7QR/Jib4R4k2Ey793AOqDKVSA=;
  b=IiAYgMNHritLNtLD6FxatpBJpZdyAUVwO14dKxPh4JQ2qzI6YeYMdZ6e
   OlufrTmq+na/kaMWzwSB41MrBgTHm+uVnNoaFMjRxSMx1qJNNgAh/Nh/b
   yqOQjKpELmqktckl13PWeD73saabzooDY0z+R6612njT0qIVIs2vBOf0n
   g=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: xGuOyD9paJCAlaZEVzqBD955AJo93agTlmHSefSNYwt6UIqLbxV9ZSKv2MIRC4aqc5EaRTC3qQ
 Gn+5nBMDxGEZUDqQTzIAXE8r6v/2Ff0jOuvQRePPB105rW+P+DHlO4cPEdw8XFSRDQZPPZrh4j
 sfsrPScGkIUl+LgTk6AwS9R9SGhgihEJt2yIZb6kW3oGp+ebXxb9S3RxKnD5YLE+BhsRXJasJn
 jQ9zaRrjfx62Mj0qbv81fiLMf7Oi5FielnaqLhx42B7izLs2tyMREMOFvOdRUwRLXXWfBvkFcf
 Ygu7YsQ8JVHXlvmZAYxbvZUZ
X-SBRS: 5.1
X-MesageID: 55742970
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:lgwmnK/6lBJ1K0kk0NoXDrUDFnmTJUtcMsCJ2f8bNWPcYEJGY0x3y
 WIbUDrQbqyMY2f0LdgjOtzgp0NS65aEmt9hG1E/rSw8E34SpcT7XtnIdU2Y0wF+jyHgoOCLy
 +1EN7Es+ehtFie0Si9AttENlFEkvU2ybuOU5NXsZ2YhGmeIdA970Ug6wrZj29Yx6TSEK1jlV
 e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH
 I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPhX0
 O9kuqWgdz0ZJ4KUpsMtfCJ8HSBxaPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us
 6ZCcXZUM07F17neLLGTE4GAguw5K8bmJsUHs2xIxjDFF/c2B5vERs0m4PcFgWhs3JERRZ4yY
 eI8ODxuTBHybCZsGXk2NMwCoM2Wp3ngJmgwRFW9+vNsvjm7IBZK+KjgNp/Zd8KHQe1Rn12Ev
 STW8mLhGBYYOdeDjz2f/RqEh/DNtTP2XpoIE7+1/eIsh0ecrkQWAQcTXEG2otG4jFC/QNNVL
 0EI+isoorM2/UbtRd74NzW6qnOZuh8XW/JLDvY3rgqKz8L8/AKxFmUCCDlbZ7QbWNQeHGJwk
 AXTxpWwWGIp4Ob9pW+hGqm8iyuIECcsPVE4VTYrFTUi0/bYhI8ygUeaJjp8K5KdgtrwEDD25
 jmFqikimrke5fI2O7WHEUPv2G30+MCYJuIhzkCOBDj9t1ImDGKwT9XwsQCz0BpWEGqOorBtV
 lA/kM+C8PtGM5iJkCGcKAnmNOD0v6jbWNEwbFgGInXAy9hP0yL8FWyzyGsnTKuMDiriUWW0C
 KM0kVgJjKK/xFPwMcdKj3uZUqzGN5TIG9X/TezzZdFTeJV3fwLv1HgwPhLPgj2xyBdzzvpX1
 XKnnSCEVyty5UNPl2Leegvg+eVzmnBWKZ37FPgXMChLIZLBPSXIGN/pwXOFb/wj7bPsnekm2
 403Cid+8D0GCLeWSnCOqeY7dAlWRVBmVcGeg5EGLYarf1s5cFzN/teMmNvNjaQ+xP8L/goJl
 1ngMnJlJK3X3yCcc1rWMyE4NtsCn/9X9BoGAMDlBn7xs1ALaoez9qYPMZwxeLgs7ut4yvBoC
 fICfq297j5nE1wrIhwRMsvwqpJMbhOuiV7cNiapemFnLZVhWxbI6pnveQ62rHsCCS++tM0fp
 by811yEHcpfFlo6VMuGOuiyy16RvGQGnL4gVUX/PdQOKl7n95JnKnKtg6Zvcd0MMxjK2hCTy
 x2SXUUDveDIroJsqIvJiKmIop2HCex7GkYGTWDX4azvbXvR/3a5wJ8GW+GNJGiPWGTx8aSkR
 ONU0/Cjb6FXwAcU69JxSu85w7g/6t3jo65h4j5lRHibPU62Dr5AI2Wd2ZUdvKN62bIE6xC9X
 ViC+4cGNOzRat/lClMYOCEscv+HiaMPgjDX4Pk4fBf66Stw8ObVWEleJUDR2ilULb8zO4I52
 +Yx/sUR7lXn2BYtN9+HiAFS9niNcSNcA/l26MlCDd+5kBcvx3FDfYfYW33/75y4YtlRNlUnf
 22Pj63YirUAnkfPfhLfz5QWMTaxUXjWhC138Q==
IronPort-HdrOrdr: A9a23:Ky3g9qqdgT5f5NunnoxyjyMaV5pOeYIsimQD101hICG9E/bo9P
 xG88536faZslossRMb8+xoSZPhfZq0z/ccirX5W43MYOCMggqVxe9Zg7ff/w==
X-IronPort-AV: E=Sophos;i="5.87,169,1631592000"; 
   d="scan'208";a="55742970"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Aa4t0YHCb+CCEVOnlbE0OMFhtT8yU2Ciszexxkm2vshwM4/nk0WdB0kxRFuHMMnE5WG73FmIcJFcZivit3MQuASeg4s9kyiYc1gsnjt57NwduAF8OjYVTgsMrxYtOQSo7yRewYLpyLIDHebZsrIlE2EYJX9J1SLD/hUzQ5QEr5tHrTpWBprOSKPIHsbK0yeqvs1meTklCArE7xWNspxv64w8GJ6Q/S2jqLaQKLZNv/iwr/5iU2GN4S6XeQhOtQUkpq77Ur6A0/pWb60catSIz/hmg6gDuIumeNCZuXanqDTDFiRhGZEOKb3cOImkbvtgqwnfznVnxavudMsOZ4jGsQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=1V3W6thCWTMKPgbT153Lf3fvyqIStFPaYavshmnXRc0=;
 b=V2rd1hGKqr8XrCpXKtl0AMKRlULdZoIXPuONiw5Bq4rccGjprHEiZXr3tiYouQMPq3OhrslKnRxfD30xLH+cNh9QpAu/ow00h2CmuG4Su8tPheV2KQziXMaI5whOurNcEr5WlYacVW6MLv9Loi2OSNOg/xKOVkKqVvwH2lhMdpV+Q/+ecZUVj3oqMN27YGTG/JeZvlbHah+n7s7j+DMJIEEKNM9Cef1zMgDX8CiXoL3LniPZ1fK4N3Qx16PCTfbN+YAvDsX9hXqtCTaUWC7qMrhhQmLFabq1FbtCGtKKGg7YbUfIQ8NNwiSfOCWHcanFNUMrfvBSHkBl5WRerHdrsg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=1V3W6thCWTMKPgbT153Lf3fvyqIStFPaYavshmnXRc0=;
 b=GnSMVBgwEcncgzRzcB55Gw5BFrBBomi1f0AIKy+0yL7rG2/n6+XIEx5GDhIkfUO9ZDBR5FCUqLJ7A6n+Z/WQoNNH4CtYjltyxlck4Lq7YWLfMpBzFXPUjxCIR8BpJOycxVo5F/TNRfg9mCm1Gd6XC5Alsesbjm2oaiku/fKu4So=
Date: Thu, 21 Oct 2021 15:44:27 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>, Marek
 =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>,
	<xen-devel@lists.xenproject.org>, Ian Jackson <iwj@xenproject.org>
Subject: Re: Ping: [PATCH] x86/xstate: reset cached register values on resume
Message-ID: <YXFuuwvFKbgkavSB@MacBook-Air-de-Roger.local>
References: <20210818113017.454251-1-marmarek@invisiblethingslab.com>
 <45de5185-b514-8c52-6922-4c587818c698@citrix.com>
 <3125583f-b965-7746-d833-c197857cd7d7@citrix.com>
 <6adf41a6-8f05-8ead-2b12-e922939955da@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <6adf41a6-8f05-8ead-2b12-e922939955da@suse.com>
X-ClientProxiedBy: LO4P123CA0122.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:192::19) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: ee7be495-eb65-4520-fe93-08d99498ea2c
X-MS-TrafficTypeDiagnostic: DM5PR03MB3147:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <DM5PR03MB31472FA8E5779CAA974996918FBF9@DM5PR03MB3147.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: AYg6CAnMgfX2cRrp2IqOF4LF6hwwqzcFS3VCofVqlZevPKw2sgsV9R5uxf7b/vdYll7NQbCXFgvKT/r6pV06cGKUa8l5MBDjOADqxnvF4m+KjTJI8sJMK5DIWU3ezSuXDhwjGnqS18vdMGJiF8qnTTCGYrOpFFSvQdY/IIhtzJwb6mnG9Kd2TgB69vQSc88Y8aECQLxpMjZJap5IQMw6atZ+mCJW9gSOCZgjadGouwuZUG7vSZUfgjJxa5FSNICYyl8sQGTHSQLGfdQi+BN4xhyL9MXKffu/jRM3dzJl2zstHxmPDDJdXm+2Klz2YbdrXtRXik5SdlDlSLAUnE0wj2+mGGUtWUqJuq3OctUt0qImXhNTycKTBng6kLxc6ZVElXdef2WvA/l0m8oHDE4bsNwDGYa4OUJJrHH5uD4Sc4K6rxG5bq9ITq6YG3WACTDCOaYXIJyv4iA7eOeAJHERbzhr/rSJrHrJUXaOJCUMY8ZENBxEwcFwV1s6sNm+ChCbq+iVmvA+ceAbZrAM42Gi8iBfEm7tO+HJXqiF70FNCZi8LMtFPmyQ4rW79BHP49MR+wqqL47xYULFkYgS30ZMWpBlhq2SAP6iITqbBgjoh5RBLmB5XbDO5DDVPBi+aVD3hLwqukeK1llsCucyvR/2Kw==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(6486002)(8676002)(316002)(83380400001)(66946007)(53546011)(4326008)(956004)(66556008)(38100700002)(26005)(85182001)(186003)(6916009)(8936002)(66574015)(2906002)(6496006)(54906003)(508600001)(9686003)(5660300002)(6666004)(86362001)(82960400001)(66476007);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dllpOVZhS2s2b3RpdXVrbm9kQ0JNNFRkUlk1R3VLUWN0a0lNMktQdXpUUmh6?=
 =?utf-8?B?emVRTHdsK0hyYllmaHpaN3Rac3hCU3IzdkhpK0dKTVhrSmNRcU94SnpSY01o?=
 =?utf-8?B?U0RIOGpMYlhJMWJuY3JUVHIxMFE4R1dqME9pUXA2cHA3SFBpVE9tQnZIZnZl?=
 =?utf-8?B?eVMwMW5yMTVnZk4yRjdQR3pxQmM5WlhxTndjeGlYdjVRUW1peGtPSUJYMWFv?=
 =?utf-8?B?L1lGT0VLVEt4QjMxODRtVnVwVm5FYlpGeWhhNExvWVgxZU1kSXlrTThiVHJY?=
 =?utf-8?B?NzdvOWVLMEJ4SlhyVi9JbXlaWjQ1dXU1ZXUwY0ZETzVhQjkzaThCdSszWjN6?=
 =?utf-8?B?NkIxZnROU010dVFteDM4V3IyU3lTN1F4M0hIcXNBZEhUb010VDgxQWdCTEMx?=
 =?utf-8?B?RGdLVVBPamRPK2xDWVZkL0taRklMeWhEMHdWamtJSXZDVHJyR1hLT2RFVTdN?=
 =?utf-8?B?cUFZdWZjeUZBNVkxYkNnaGU0dVlYd0tPYld3SWNneUFEaklmZFlhT080bjli?=
 =?utf-8?B?SFRFdHBuMnNRTFpjWUd4ZnBsaUduYXdLTWFpWmlHSFR2WWRPSWJxTFkxaXpH?=
 =?utf-8?B?Ym41cHBHeG5VYmZSVi9rZERtUU8wL3oyQ3NPTEZoSCtkNTJDK1hSUElOSVJC?=
 =?utf-8?B?cnpHdWordG5GandxK1BQZ08yc0xGcEg4dGpXOUZyQmV0NWZub0trTEFsQUh1?=
 =?utf-8?B?U1VwM1o1bjk2c3JCdlJGTXlGYXVRZkR0VWVIOWJJcm9tV3Rlb0doYk1QUlpQ?=
 =?utf-8?B?TFlKbzg3UjM0eFUxbDlGdlpBM0ZZcDZFemY2YTVYU1lvVkhaVytJbTUwNHRo?=
 =?utf-8?B?YjI4WlBmKy9YbUVCN2xsTktXbG16ZStDR2cybUt6TWN1bnRFQWJnUUYrOThv?=
 =?utf-8?B?VERaa1Rtck9JYTVrT2pPQ2NVN0RzSkR4VndZTFZKL00rcjlETWczRmpEbjFN?=
 =?utf-8?B?dTVWOVpQYWFIQmtRMGpSN21vZ3B2SzQ4UjFzZytlYmdhUGVaeGQ3NTZ2OStY?=
 =?utf-8?B?c3dHc1Naam1KVlcxVEJha09lTEJTeSthajRJRWRpV2l2MCt4ZjcrOWxJbVVo?=
 =?utf-8?B?Vm52RmtFSGxuazRIMGw5V0ZsTVRieDhiNWdEa2pIMldsTUZjYU96K1VoU1p6?=
 =?utf-8?B?Sy9BM0tFUTZpL0plR1hualF0STE1QXQ0TWREY2dCb051REgrZG5JaUYyY2NI?=
 =?utf-8?B?UC9laDlaam90VXpLQXNRbU9FL1l5clZqdEVnTTd6ZGwzVlhZd1V6eE9Vcktr?=
 =?utf-8?B?bnZCVnpySkp4aEE2K3dUcndvSE1IeW5rMjhPS201NW96WGFnQy9zYjg0cnIy?=
 =?utf-8?B?OFg2R2dxV0VPdk85NnNGZzIrKzAxY0hTY08rckxjbUV6MmVBQkM5eEpSZEdm?=
 =?utf-8?B?SkdaMlRtdDJwL2VtNzVmVGFCejZnckllSi9yUXNqdVFFdDFvRlVacFEydXpv?=
 =?utf-8?B?anlDREZHK2Z4T3VlVTVMaTZQUjdBbVlaMEw2djBRQ2hweHBiNUtRNW95REpD?=
 =?utf-8?B?bHpka1BYbUUzQ3dXNXJyWkFWNGE1aURVdkFjZm9Cek00TVhoZTBrM3o3R1lU?=
 =?utf-8?B?V0dlOWkyZXd1b3JrSTlVNEUycDBlRHN1YkYwblFQSlkyM3JpNTZDYnh4T1U2?=
 =?utf-8?B?Ri83bm4vOEVSZ3YxaFpqaDdwbi9FZWZFMnVaMTFXYXhxbWxkZ29zYmJMOEx2?=
 =?utf-8?B?UnVsTFQ5MHhkbERVNlY2bzdaSTBYdjZBSWhoZXVSWTd4OGRzdkZRdi9XRnZ2?=
 =?utf-8?Q?DtRGtjT+mdVnfdl1tZmRbKoL1nuMoH3JmvSZNv/?=
X-MS-Exchange-CrossTenant-Network-Message-Id: ee7be495-eb65-4520-fe93-08d99498ea2c
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Oct 2021 13:44:33.5906
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: roger.pau@citrix.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB3147
X-OriginatorOrg: citrix.com

On Mon, Oct 18, 2021 at 10:21:28AM +0200, Jan Beulich wrote:
> On 24.08.2021 23:11, Andrew Cooper wrote:
> > On 18/08/2021 13:44, Andrew Cooper wrote:
> >> On 18/08/2021 12:30, Marek Marczykowski-Górecki wrote:
> >>> set_xcr0() and set_msr_xss() use cached value to avoid setting the
> >>> register to the same value over and over. But suspend/resume implicitly
> >>> reset the registers and since percpu areas are not deallocated on
> >>> suspend anymore, the cache gets stale.
> >>> Reset the cache on resume, to ensure the next write will really hit the
> >>> hardware. Choose value 0, as it will never be a legitimate write to
> >>> those registers - and so, will force write (and cache update).
> >>>
> >>> Note the cache is used io get_xcr0() and get_msr_xss() too, but:
> >>> - set_xcr0() is called few lines below in xstate_init(), so it will
> >>>   update the cache with appropriate value
> >>> - get_msr_xss() is not used anywhere - and thus not before any
> >>>   set_msr_xss() that will fill the cache
> >>>
> >>> Fixes: aca2a985a55a "xen: don't free percpu areas during suspend"
> >>> Signed-off-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
> >> I'd prefer to do this differently.  As I said in the thread, there are
> >> other registers such as MSR_TSC_AUX which fall into the same category,
> >> and I'd like to make something which works systematically.
> > 
> > Ok - after some searching, I think we have problems with:
> > 
> > cpu/common.c:47:DEFINE_PER_CPU(struct cpuidmasks, cpuidmasks);
> > cpu/common.c:120:static DEFINE_PER_CPU(uint64_t, msr_misc_features);
> > msr.c:35:DEFINE_PER_CPU(uint32_t, tsc_aux);
> > xstate.c:36:static DEFINE_PER_CPU(uint64_t, xcr0);
> > xstate.c:79:static DEFINE_PER_CPU(uint64_t, xss);
> > 
> > There is also:
> > 
> > traps.c:100:DEFINE_PER_CPU(uint64_t, efer);
> > 
> > which we *almost* handle correctly, but fail to update the cache on the
> > BSP out of S3.
> > 
> > 
> > For the APIC, I think we have issues with:
> > 
> > irq.c:1083:static DEFINE_PER_CPU(struct pending_eoi,
> > pending_eoi[NR_DYNAMIC_VECTORS]);
> > 
> > because we don't defer S3 until all pending EOIs are complete.
> 
> As your planned more extensive rework appears to not have made much
> progress yet, may I suggest that we go with Marek's fix for 4.16,
> with the one adjustment I suggested alongside giving my R-b?

I think that's the only viable solution in order to avoid shipping a
broken 4.16 so we should go ahead with it.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Thu Oct 21 13:47:30 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Oct 2021 13:47:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.214407.372934 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdYPq-0003yf-1t; Thu, 21 Oct 2021 13:47:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 214407.372934; Thu, 21 Oct 2021 13:47:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdYPp-0003yY-Tt; Thu, 21 Oct 2021 13:47:29 +0000
Received: by outflank-mailman (input) for mailman id 214407;
 Thu, 21 Oct 2021 13:47:29 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mdYPp-0003yS-18
 for xen-devel@lists.xenproject.org; Thu, 21 Oct 2021 13:47:29 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mdYPn-0001a6-SM; Thu, 21 Oct 2021 13:47:27 +0000
Received: from [54.239.6.190] (helo=[192.168.27.91])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mdYPn-0003jj-Lc; Thu, 21 Oct 2021 13:47:27 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=sL0Yp17XctBCuTTfTWdQPRiDqAmRKEFyfHd35aJV8go=; b=XBtpHwOCT7XUHUtKrkY6jFEIdt
	zF5mDSfoz4ohrTjmTu1a67gjTtKMQCuB8SIYoEig1YUGla/jLWhQ0uV34xBnVOCKb527USK8xqPks
	Vip7eIDf4e0MSHYxhj3JqOmf6mJY8YRp5+4kIKWbfWOr1AtHC/ilr6A2I55NQnuRfBFQ=;
Message-ID: <f7c1a7ca-0046-9a58-1cfd-61b096248d9f@xen.org>
Date: Thu, 21 Oct 2021 14:47:24 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.2.0
Subject: Re: xen/arm: Missing appropriate locking for the IOMMU (WAS Re:
 [PATCH v5 02/11] xen/arm: Add PHYSDEVOP_pci_device_(*add/remove) support for
 ARM)
To: Bertrand Marquis <Bertrand.Marquis@arm.com>
Cc: Rahul Singh <Rahul.Singh@arm.com>,
 Xen-devel <xen-devel@lists.xenproject.org>,
 Andre Przywara <Andre.Przywara@arm.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Jan Beulich <jbeulich@suse.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <cover.1633540842.git.rahul.singh@arm.com>
 <0dc4423b2e20c1eb40c961b211b18ed041f707b7.1633540842.git.rahul.singh@arm.com>
 <99f6d6c4-bcc6-03a9-ef9b-0d01be0fd7f1@xen.org>
 <75784F90-198E-400D-877B-CF62ED69F409@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <75784F90-198E-400D-877B-CF62ED69F409@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit



On 21/10/2021 14:15, Bertrand Marquis wrote:
> Hi Julien,

Hi Bertand,

>> On 21 Oct 2021, at 10:28, Julien Grall <julien@xen.org> wrote:
>>
>> Hi all,
>>
>> While going through the passthrough code. I noticed that we don't have a common lock for the IOMMU between the PCI and DT code.
>>
>> This is going to be an issue given it would technically be possible to add a PCI device while assigning a DT.
>>
>> Rahul, Bertrand, Oleksandr, can you have a look at the issue?
> 
> Yes we can have a look at this.
> 
> Right now pci device add is done by dom0 so I do not think we have an issue in practice unless I wrongly understood something
This will depend on the XSM policy. With the default one, then yes I 
agree that only dom0 (we don't support hardware domain) can add PCI device.

However, this restriction doesn't really matter here. You would be 
relying on dom0 to do the locking and AFAIK this doesn't exist. Instead, 
the admin would have to ensure that two don't happen at the same time.

Anyway, I think Xen should take care of preventing concurrent IOMMU 
operations rather than relying on external subsystem (e.g. dom0) to do 
it. At least the Arm SMMU driver will rely the generic locking to modify 
atomically internal list.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Thu Oct 21 13:53:08 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Oct 2021 13:53:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.214417.372951 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdYVE-0005PG-O5; Thu, 21 Oct 2021 13:53:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 214417.372951; Thu, 21 Oct 2021 13:53:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdYVE-0005P9-L2; Thu, 21 Oct 2021 13:53:04 +0000
Received: by outflank-mailman (input) for mailman id 214417;
 Thu, 21 Oct 2021 13:53:03 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Wrrh=PJ=arm.com=Bertrand.Marquis@srs-us1.protection.inumbo.net>)
 id 1mdYVD-0005P3-DO
 for xen-devel@lists.xenproject.org; Thu, 21 Oct 2021 13:53:03 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com (unknown
 [40.107.6.84]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 9d8b4885-50dd-4cfa-b501-558da5ad3371;
 Thu, 21 Oct 2021 13:53:01 +0000 (UTC)
Received: from AM6PR05CA0017.eurprd05.prod.outlook.com (2603:10a6:20b:2e::30)
 by AM9PR08MB6004.eurprd08.prod.outlook.com (2603:10a6:20b:285::5)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.15; Thu, 21 Oct
 2021 13:52:58 +0000
Received: from VE1EUR03FT017.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:2e:cafe::43) by AM6PR05CA0017.outlook.office365.com
 (2603:10a6:20b:2e::30) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.18 via Frontend
 Transport; Thu, 21 Oct 2021 13:52:58 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT017.mail.protection.outlook.com (10.152.18.90) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4628.18 via Frontend Transport; Thu, 21 Oct 2021 13:52:58 +0000
Received: ("Tessian outbound f1898412aff1:v103");
 Thu, 21 Oct 2021 13:52:57 +0000
Received: from 7218f8d59259.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 DC6A1084-06D1-4605-8C3E-5CCF3532B2CA.1; 
 Thu, 21 Oct 2021 13:52:51 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 7218f8d59259.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Thu, 21 Oct 2021 13:52:51 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com (2603:10a6:4:74::9)
 by DBBPR08MB6011.eurprd08.prod.outlook.com (2603:10a6:10:209::13) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.17; Thu, 21 Oct
 2021 13:52:49 +0000
Received: from DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955]) by DB6PR0801MB2024.eurprd08.prod.outlook.com
 ([fe80::45c9:9096:a15b:6955%4]) with mapi id 15.20.4608.018; Thu, 21 Oct 2021
 13:52:49 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9d8b4885-50dd-4cfa-b501-558da5ad3371
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Jy7QlzZooPuohQZ/c26XP8x/PPZTy952CU6Q8AEgGoM=;
 b=9Rf/hVCk4rZpknblC4+huozohdIpvO7V50TZDHWoBanWiaqqhAExxJVBLWAcqLKfdR3kSBubMXYcKhmQkJYDJr75iqdm5p8aTV+bt8+p10ssyo7HztQT/aso25NM5P16oKZqQqu8uMGmtLc3SxprmN6vP72MFs/x++mTJKIfHvU=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 5fdc578a0ffd7512
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=jH5uSJv4zp0XbxY2YFn53RlfeJ5Wdc3X/4wjDBt8gxE/wp4anFZR+6cYEC8nbDmHvNq8nbP72B4ek0+uC9+E2g27qccyMZ0P8U+r8D15b5km65Fikj7w2nxNFhMhGBUDevhnb0N2FGNDeYlQSFhc0RiOUWwv4wXqiSSbL6Jld0/2VFBmxVZ5fjhhiaj1haGJ0C1cJ6fnQJREIa5lROAWbxiNGN0SVAXZ30YDF+0i2PAtOCLGj0+wfKA3kQoBfnzPB//G29SQl+dVB95HobQJYfsnXze4BqAYQW8d1Yze+xI2zTtMG1wbfsp4iAa4ftzP1AR5AgbuDPLm0ByjZC0CQQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Jy7QlzZooPuohQZ/c26XP8x/PPZTy952CU6Q8AEgGoM=;
 b=liV1KPBT/JQDhjTLtNjSuMw9SoqntC0Tbzohw5E4Bp9FqAeEScXNORTFSp64Rtra2yJ58pmBSaMEWPn6RVzzA9mvxzEUX2CO6Df0h5jmWBnn8qFkNVSqCBqM+L2BqPKIXz58r0npscfiHxlS9mFQnyRZY62SwUj5YjShCZGyQR1ZDNRKFa6ukE98STYV3TcENxWQpgfLUYBGXRtY35MgobdEjE2xTw0i5EBoKmgsmjfBTgB1FfpYoeeKT/PWJrkqYZMzkRQrQf7svpHzHmd119MTs1C6oKQh5E7MnXR/RDYQuXprcUMPEqXGVG2opYAHSNkRpyQIJLHzQrGLnGS+Mg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Jy7QlzZooPuohQZ/c26XP8x/PPZTy952CU6Q8AEgGoM=;
 b=9Rf/hVCk4rZpknblC4+huozohdIpvO7V50TZDHWoBanWiaqqhAExxJVBLWAcqLKfdR3kSBubMXYcKhmQkJYDJr75iqdm5p8aTV+bt8+p10ssyo7HztQT/aso25NM5P16oKZqQqu8uMGmtLc3SxprmN6vP72MFs/x++mTJKIfHvU=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Julien Grall <julien@xen.org>
CC: Rahul Singh <Rahul.Singh@arm.com>, Xen-devel
	<xen-devel@lists.xenproject.org>, Andre Przywara <Andre.Przywara@arm.com>,
	Stefano Stabellini <sstabellini@kernel.org>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
	Jan Beulich <jbeulich@suse.com>, Wei Liu <wl@xen.org>,
	=?iso-8859-1?Q?Roger_Pau_Monn=E9?= <roger.pau@citrix.com>
Subject: Re: xen/arm: Missing appropriate locking for the IOMMU (WAS Re:
 [PATCH v5 02/11] xen/arm: Add PHYSDEVOP_pci_device_(*add/remove) support for
 ARM)
Thread-Topic: xen/arm: Missing appropriate locking for the IOMMU (WAS Re:
 [PATCH v5 02/11] xen/arm: Add PHYSDEVOP_pci_device_(*add/remove) support for
 ARM)
Thread-Index: AQHXxl4YkvgVlFH7LEi1mWK2psfiI6vdbqqAgAAI9ACAAAGCAA==
Date: Thu, 21 Oct 2021 13:52:48 +0000
Message-ID: <CAD6B836-F5B7-451F-AE44-0AE13BB9DC56@arm.com>
References: <cover.1633540842.git.rahul.singh@arm.com>
 <0dc4423b2e20c1eb40c961b211b18ed041f707b7.1633540842.git.rahul.singh@arm.com>
 <99f6d6c4-bcc6-03a9-ef9b-0d01be0fd7f1@xen.org>
 <75784F90-198E-400D-877B-CF62ED69F409@arm.com>
 <f7c1a7ca-0046-9a58-1cfd-61b096248d9f@xen.org>
In-Reply-To: <f7c1a7ca-0046-9a58-1cfd-61b096248d9f@xen.org>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3654.120.0.1.13)
Authentication-Results-Original: xen.org; dkim=none (message not signed)
 header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: b025640d-7286-479b-5944-08d9949a171c
x-ms-traffictypediagnostic: DBBPR08MB6011:|AM9PR08MB6004:
x-ms-exchange-transport-forked: True
X-Microsoft-Antispam-PRVS:
	<AM9PR08MB600461EF87FA6EA8605EAABF9DBF9@AM9PR08MB6004.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:9508;OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 BjZN0dopFyb1JFqlvYKkL/nu9rO7t1apdaWLAj9cbSsGY5Q/pnfGje2K1qbbIqFuUlOVTAlI9pFCs+Qef3Dmg8r9wRdgv+Z3DyRUlAsicJWOFL6gmwsVVw4Mm94CE4Ta3NIkmV24cj75TZhdEzsAdrLAi+Z0CNJfQsoXba3QazZXl671cQsaBcJatm9KGQkI7H5Fxbv35wXjS5OJMf2tr8a7UrsffPOzjYg44JGpu2MJzfw4O2tLXtSO/r255xENMbU4eOt3zfO65zhZN5hvOWdpD90w+8pAJ3moW3sevGtp1eO/h5PBs3RDa+GttyVddNKfqRTPIXb189aF8lara2xRaFWjqUbU4UKlwPlkFGSp+JoS3IArmXxWwV/UXWQzyeuwH+wJkvd8ltqtuGkrgATNYNbvwmkkammd7mQibBe+flvo4aOPD5dij71ImHTIhzrSkOy4WUnYaNemiRR24HDQHLDZ1seKhI+HVY2rV/qvxGkijPTw43nPpW/iLVBrAq9ZdGMiCyXLGV2ObfubX5egG0xkx7HWsYZe2D2VIkJ9X9a+w4/qU7cnD88lQQTy9IwVG5cw824MIbpT84bs36ENvSjoVMmQMfzt2uG28j8OWA9yL/Hy056r7XFNGwvu6uqQGVpwvX1T8tDgn9e4OJdWtmah0ERJzh+FXtOZSrCbvn09sJvGytgbg+8/OLLYIIabMCsd56STXz4OC+eQnaW1S+ffl2nT54DG4JpNZ9fRPmgumrPzQ98hGhEZWQCQ
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB6PR0801MB2024.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(38100700002)(122000001)(2616005)(71200400001)(508600001)(8936002)(76116006)(54906003)(6506007)(6916009)(7416002)(8676002)(38070700005)(66946007)(186003)(64756008)(53546011)(4326008)(5660300002)(66446008)(66556008)(66476007)(33656002)(6486002)(36756003)(26005)(91956017)(2906002)(316002)(83380400001)(86362001)(6512007)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="iso-8859-1"
Content-ID: <C6D92CA85FBFE04D80F711DA8CDFDA32@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB6011
Original-Authentication-Results: xen.org; dkim=none (message not signed)
 header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT017.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	4add61de-3679-407b-c6d2-08d9949a11a5
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	6/3D6YDc+6ybiGLxG75flp/cNRlK4uv665s0hsjutJJ2NnOE+KJVzFoNfV0B1RorK/JIrMvcKCaeVfnwJJCeNArhvNlUC2HIteITT10jRtgJ7Brsbi+lI2YLAr5GBcORA7Nc+53xzQzHEl7iZzhVntIMJA/3qNrjj2blpQuwHFu6+8hI/M8ucolU+yFNw7H9TwSknwJJL5LnU+hTRI7nzBmeUtfljg+Ii5Mtszv2H1rOkGymapYoOKso8Jpbg/Aq0YksBOkBwMm28i9GRM2Qh+hivmwX2Z/6GSxU1RxSFyyJ1G9xT5yqaeI/HLVh4HkxBD+kP0D3MTnW8035c9R9oKwJjB2OuJAjO+kchJIhDaTetRidImKTnPNkflZrrsLKX0I9wvJn5e0Uex00AMK2wbqeNySewHECxt186YpgRqCyn4Mcf1XHGuHOsmtJi4DCQk0QnXh6RUsSuTwg7XZyqiL1tdxdiNfyNcwMXHEjdfJIDxatQW/y8uvSXPNcjS9K6wrtWXMwrL9IcfpsyJQ6apy/b1NARvPWQvJ+Zff5iHX0j3nTEfM1DOgCTaVELKZEVVnQiC1oVfmo8ZHkGzdiy0ltg85Ha9SMid3wiL8fBu0OgwHIZupM/XsOHdFPeo3W+W1ogIL4u7A4ZqwfzLJEAOVHmZHzOnI5JA/Hr0YRj3jSuhnvAK8BWkEQOfGeU/fandysdxR0A2d8yQhGJXJLZQ==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(36756003)(8936002)(316002)(508600001)(26005)(6862004)(86362001)(54906003)(8676002)(6512007)(36860700001)(186003)(83380400001)(70586007)(5660300002)(53546011)(6506007)(33656002)(70206006)(4326008)(2906002)(47076005)(107886003)(356005)(336012)(2616005)(6486002)(82310400003)(81166007);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Oct 2021 13:52:58.1864
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: b025640d-7286-479b-5944-08d9949a171c
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT017.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB6004

Hi Julien,

> On 21 Oct 2021, at 14:47, Julien Grall <julien@xen.org> wrote:
>=20
>=20
>=20
> On 21/10/2021 14:15, Bertrand Marquis wrote:
>> Hi Julien,
>=20
> Hi Bertand,
>=20
>>> On 21 Oct 2021, at 10:28, Julien Grall <julien@xen.org> wrote:
>>>=20
>>> Hi all,
>>>=20
>>> While going through the passthrough code. I noticed that we don't have =
a common lock for the IOMMU between the PCI and DT code.
>>>=20
>>> This is going to be an issue given it would technically be possible to =
add a PCI device while assigning a DT.
>>>=20
>>> Rahul, Bertrand, Oleksandr, can you have a look at the issue?
>> Yes we can have a look at this.
>> Right now pci device add is done by dom0 so I do not think we have an is=
sue in practice unless I wrongly understood something
> This will depend on the XSM policy. With the default one, then yes I agre=
e that only dom0 (we don't support hardware domain) can add PCI device.
>=20
> However, this restriction doesn't really matter here. You would be relyin=
g on dom0 to do the locking and AFAIK this doesn't exist. Instead, the admi=
n would have to ensure that two don't happen at the same time.
>=20
> Anyway, I think Xen should take care of preventing concurrent IOMMU opera=
tions rather than relying on external subsystem (e.g. dom0) to do it. At le=
ast the Arm SMMU driver will rely the generic locking to modify atomically =
internal list.

Agree, was just trying to make sure I understood the problem correctly.
We will check that.

Cheers
Bertrand

>=20
> Cheers,
>=20
> --=20
> Julien Grall



From xen-devel-bounces@lists.xenproject.org Thu Oct 21 13:54:56 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Oct 2021 13:54:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.214426.372961 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdYX2-00064l-7b; Thu, 21 Oct 2021 13:54:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 214426.372961; Thu, 21 Oct 2021 13:54:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdYX2-00064b-4W; Thu, 21 Oct 2021 13:54:56 +0000
Received: by outflank-mailman (input) for mailman id 214426;
 Thu, 21 Oct 2021 13:54:54 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=IwRr=PJ=invisiblethingslab.com=marmarek@srs-us1.protection.inumbo.net>)
 id 1mdYX0-00064T-AJ
 for xen-devel@lists.xenproject.org; Thu, 21 Oct 2021 13:54:54 +0000
Received: from out3-smtp.messagingengine.com (unknown [66.111.4.27])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 7730691c-3276-11ec-8378-12813bfff9fa;
 Thu, 21 Oct 2021 13:54:52 +0000 (UTC)
Received: from compute4.internal (compute4.nyi.internal [10.202.2.44])
 by mailout.nyi.internal (Postfix) with ESMTP id BD10D5C01E1;
 Thu, 21 Oct 2021 09:54:52 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute4.internal (MEProxy); Thu, 21 Oct 2021 09:54:52 -0400
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu,
 21 Oct 2021 09:54:51 -0400 (EDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7730691c-3276-11ec-8378-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:content-type:date:from:in-reply-to
	:message-id:mime-version:references:subject:to:x-me-proxy
	:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=8DfilE
	VkpFNcYiOfzwpg4aeBMtYvljaMPUNJ2ADgFkA=; b=a+ECN/TvPbf3yKz1/pizVF
	PXWCsF303artum+kRyNkZKLBST5f8vat710AnWHskPpjRFbFtn7IIHP5SmV7jhNN
	Qt7ssfcdzaj0c+0PmD+5pCUx4iTgeizaMeoj4wbQKoEWLszE3cHXWTSekBc0pueh
	VV0fiNCJS0sRBDjyu08DYuKEi4SQ+kE92RQEwK91LOl/c16dhFfdE7Yl6dFAh6fI
	LuEgo+C7JkabCzYiAOr+oBlosndkR0Fb3I4jDvLs/wn/5CTxDmIMNDa5cuzkLukx
	9UWUhLUBw2j5ZKvbu9rH/SrK0+zgRLWkT4KElasqo45ml820yxTJcxBEwXKRIJ+g
	==
X-ME-Sender: <xms:LHFxYRHId5V6447Wz3oxMi5ZrXDUWn1oNgwClwe--O9HvpQuOMfslA>
    <xme:LHFxYWWRYbdVfSr_ZY1zUuiHJDTgN8Zn7HU4teIg2OYeVJoivCDWDBI6GmwLsLHFU
    yetWdjzNN6S3A>
X-ME-Received: <xmr:LHFxYTL-p1Pr8k3M32caRg4jKlo32zEPhsvC1ljbUTLJDdoZtC5WJr15uEoFixUja0mKTtToNAONPlFHtuh3p3QnSxrDf7fp>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrvddviedgieelucetufdoteggodetrfdotf
    fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
    uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
    cujfgurhepfffhvffukfhfgggtuggjsehgtderredttdejnecuhfhrohhmpeforghrvghk
    ucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesihhnvh
    hishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpeetveff
    iefghfekhffggeeffffhgeevieektedthfehveeiheeiiedtudegfeetffenucevlhhush
    htvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrghrmhgrrhgvkhes
    ihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm
X-ME-Proxy: <xmx:LHFxYXGT44NRiCcA0v3v1pgBaCUWWvMq8wCJ0719vC3AvwjXIVd2rA>
    <xmx:LHFxYXURzcRwQ8pwHiy5QR5_0DxrUym_2Muj0afhdQTYS436dYzq7w>
    <xmx:LHFxYSMpwhdzy6SH_dMS6pdD_gc4FSi8JoDiKNDYy8uXHht0LFGoaw>
    <xmx:LHFxYeCrPmsh2F-ecnd274HcMu3F78pTY2CvWpY-zGCxcWDuua5Fug>
Date: Thu, 21 Oct 2021 15:54:48 +0200
From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
To: Juergen Gross <jgross@suse.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: Tentative fix for "out of PoD memory" issue
Message-ID: <YXFxKC4shCATB913@mail-itl>
References: <912c7377-26f0-c14a-e3aa-f00a81ed5766@suse.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="N3tx0KCYiCI/3eVV"
Content-Disposition: inline
In-Reply-To: <912c7377-26f0-c14a-e3aa-f00a81ed5766@suse.com>


--N3tx0KCYiCI/3eVV
Content-Type: multipart/mixed; protected-headers=v1;
	boundary="QsU+wNDWzJA/oy32"
Content-Disposition: inline
Date: Thu, 21 Oct 2021 15:54:48 +0200
From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
To: Juergen Gross <jgross@suse.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: Tentative fix for "out of PoD memory" issue


--QsU+wNDWzJA/oy32
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Oct 21, 2021 at 01:53:06PM +0200, Juergen Gross wrote:
> Marek,
>=20
> could you please test whether the attached patch is fixing your
> problem?

Sure. In fact, I made a similar patch in the meantime (attached) to
experiment with this a bit.

> BTW, I don't think this couldn't happen before kernel 5.15. I guess
> my modification to use a kernel thread instead of a workqueue just
> made the issue more probable.

I think you are right here. But this all looks still a bit weird.

1. baseline: 5.10.61 (before using kernel thread - which was backported to
stable branches).

Here the startup completes successfully (no "out of PoD memory"
issue) with memory=3D270MB.=20

2. 5.10.61 with added boot delay patch:
The delay is about 18s and the guest boot successfully.

3. 5.10.71 with "xen/balloon: fix cancelled balloon action" but without
delay patch:
The domain is killed during startup (in the middle of fsck, I think)

4. 5.10.74 with delay patch:
The delay is about 19s and the guest boot successfully.

Now the weird part: with memory=3D270MB with the delay patch, the balloon
delay _fails_ - state=3DBP_ECANCELED, and credit is -19712 at that time.
In both thread and workqueue balloon variants. Yet, it isn't killed (*).
But with 5.10.61, even without the delay patch, the guest starts
successfully in the end.

Also, I think there was some implicit wait for initial balloon down
before. That was the main motivation for 197ecb3802c0 "xen/balloon: add
runtime control for scrubbing ballooned out pages" - because that
initial balloon down held the system startup for some long time. Sadly,
I can't find my notes from debugging that (especially if I had written
down a stacktrace _where_ exactly it was waiting)...

> I couldn't reproduce the crash you are seeing, but the introduced
> wait was 4.2 seconds on my test system (a PVH guest with 2 GB of
> memory, maxmem 6 GB).

I'm testing it on a much more aggressive setting:
 - memory: 270 MB (the minimal that is sufficient to boot the system)
 - maxmem: 4 GB

The default settings in Qubes are:
 - memory: 400 MB
 - maxmem: 4 GB

That should explains why it happens on Qubes way more often than
elsewhere.


(*) At some point during system boot, qubes memory manager kicks in and
the VM gets more memory. But it's rather late, and definitely after it is
killed with "out of PoD memory" in other cases.

--=20
Best Regards,
Marek Marczykowski-G=C3=B3recki
Invisible Things Lab

--QsU+wNDWzJA/oy32
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment; filename="balloon-wait-5.10.61.patch"
Content-Transfer-Encoding: quoted-printable

=46rom 947818c731094a952d4955e99a23ef336daf7ab9 Mon Sep 17 00:00:00 2001
=46rom: =3D?UTF-8?q?Marek=3D20Marczykowski-G=3DC3=3DB3recki?=3D
 <marmarek@invisiblethingslab.com>
Date: Thu, 21 Oct 2021 01:10:21 +0200
Subject: [PATCH] WIP: xen/balloon: wait for initial balloon down before
 starting userspace
MIME-Version: 1.0
Content-Type: text/plain; charset=3DUTF-8
Content-Transfer-Encoding: 8bit
Organization: Invisible Things Lab
Cc: Marek Marczykowski-G=C3=B3recki <marmarek@invisiblethingslab.com>

When HVM/PVH guest with maxmem > memory, a populate on demand feature is
used. This allows the guest to see up to 'maxmem' memory, but when it
tries to use more than 'memory', it is crashed. Balloon driver should
prevent that by ballooning down the guest before it tries to use too
much memory. Unfortunately, this was done asynchronously and it wasn't
really guaranteed to be quick enough. And indeed, with recent kernel
versions, the initial balloon down process is slower and guests with
small initial 'memory' are crashed frequently by Xen.

Fix this by adding late init call that waits for the initial balloon
down to complete, before allowing any userspace to run. If that initial
balloon down fails, it is very likely that guest will be killed (as soon
as it will really use all the memory that something has allocated) -
print a message about that to aid diagnosing issues.

Signed-off-by: Marek Marczykowski-G=C3=B3recki <marmarek@invisiblethingslab=
=2Ecom>
(cherry picked from commit 9a226e669c918c98ee603ee30a1798da6434a423)
---
 drivers/xen/balloon.c | 27 ++++++++++++++++++++++++++-
 1 file changed, 26 insertions(+), 1 deletion(-)

diff --git a/drivers/xen/balloon.c b/drivers/xen/balloon.c
index b57b2067ecbf..c2a4e25a14dc 100644
--- a/drivers/xen/balloon.c
+++ b/drivers/xen/balloon.c
@@ -56,6 +56,7 @@
 #include <linux/percpu-defs.h>
 #include <linux/slab.h>
 #include <linux/sysctl.h>
+#include <linux/completion.h>
=20
 #include <asm/page.h>
 #include <asm/tlb.h>
@@ -136,6 +137,8 @@ static DEFINE_MUTEX(balloon_mutex);
 struct balloon_stats balloon_stats;
 EXPORT_SYMBOL_GPL(balloon_stats);
=20
+static DECLARE_COMPLETION(initial_balloon);
+
 /* We increase/decrease in batches which fit in a page */
 static xen_pfn_t frame_list[PAGE_SIZE / sizeof(xen_pfn_t)];
=20
@@ -501,7 +504,6 @@ static void balloon_process(struct work_struct *work)
 	enum bp_state state =3D BP_DONE;
 	long credit;
=20
-
 	do {
 		mutex_lock(&balloon_mutex);
=20
@@ -526,6 +528,15 @@ static void balloon_process(struct work_struct *work)
=20
 		state =3D update_schedule(state);
=20
+		if (credit >=3D 0)
+			complete(&initial_balloon);
+		else if (state =3D=3D BP_ECANCELED) {
+			if (!completion_done(&initial_balloon) && !xen_pv_domain())
+				pr_err("Initial balloon down failed, expect the domain to be killed wi=
th \"out of PoD memory\" error by Xen.\n");
+			complete(&initial_balloon);
+		}
+
+
 		mutex_unlock(&balloon_mutex);
=20
 		cond_resched();
@@ -677,6 +688,20 @@ static void __init balloon_add_region(unsigned long st=
art_pfn,
 }
 #endif
=20
+static int __init wait_for_initial_balloon_down(void)
+{
+	mutex_lock(&balloon_mutex);
+	/* optionally re-init completion after retrieving balloon target */
+	if (current_credit() < 0)
+		reinit_completion(&initial_balloon);
+	mutex_unlock(&balloon_mutex);
+	printk(KERN_INFO "waiting for initial balloon down %ld\n", current_credit=
());
+	wait_for_completion(&initial_balloon);
+	printk(KERN_INFO "done waiting for initial balloon down %ld\n", current_c=
redit());
+	return 0;
+}
+late_initcall(wait_for_initial_balloon_down);
+
 static int __init balloon_init(void)
 {
 	if (!xen_domain())
--=20
2.31.1


--QsU+wNDWzJA/oy32
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment; filename="balloon-wait-5.10.74.patch"
Content-Transfer-Encoding: quoted-printable

=46rom 9a226e669c918c98ee603ee30a1798da6434a423 Mon Sep 17 00:00:00 2001
=46rom: =3D?UTF-8?q?Marek=3D20Marczykowski-G=3DC3=3DB3recki?=3D
 <marmarek@invisiblethingslab.com>
Date: Thu, 21 Oct 2021 01:10:21 +0200
Subject: [PATCH] WIP: xen/balloon: wait for initial balloon down before
 starting userspace
MIME-Version: 1.0
Content-Type: text/plain; charset=3DUTF-8
Content-Transfer-Encoding: 8bit
Organization: Invisible Things Lab
Cc: Marek Marczykowski-G=C3=B3recki <marmarek@invisiblethingslab.com>

When HVM/PVH guest with maxmem > memory, a populate on demand feature is
used. This allows the guest to see up to 'maxmem' memory, but when it
tries to use more than 'memory', it is crashed. Balloon driver should
prevent that by ballooning down the guest before it tries to use too
much memory. Unfortunately, this was done asynchronously and it wasn't
really guaranteed to be quick enough. And indeed, with recent kernel
versions, the initial balloon down process is slower and guests with
small initial 'memory' are crashed frequently by Xen.

Fix this by adding late init call that waits for the initial balloon
down to complete, before allowing any userspace to run. If that initial
balloon down fails, it is very likely that guest will be killed (as soon
as it will really use all the memory that something has allocated) -
print a message about that to aid diagnosing issues.

Signed-off-by: Marek Marczykowski-G=C3=B3recki <marmarek@invisiblethingslab=
=2Ecom>
---
 drivers/xen/balloon.c | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/drivers/xen/balloon.c b/drivers/xen/balloon.c
index 1911a62a6d9c..a91d90f91c81 100644
--- a/drivers/xen/balloon.c
+++ b/drivers/xen/balloon.c
@@ -58,6 +58,7 @@
 #include <linux/percpu-defs.h>
 #include <linux/slab.h>
 #include <linux/sysctl.h>
+#include <linux/completion.h>
=20
 #include <asm/page.h>
 #include <asm/tlb.h>
@@ -140,6 +141,8 @@ static DEFINE_MUTEX(balloon_mutex);
 struct balloon_stats balloon_stats;
 EXPORT_SYMBOL_GPL(balloon_stats);
=20
+static DECLARE_COMPLETION(initial_balloon);
+
 /* We increase/decrease in batches which fit in a page */
 static xen_pfn_t frame_list[PAGE_SIZE / sizeof(xen_pfn_t)];
=20
@@ -531,6 +534,14 @@ static int balloon_thread(void *unused)
=20
 		credit =3D current_credit();
=20
+		if (credit >=3D 0)
+			complete(&initial_balloon);
+		else if (state =3D=3D BP_ECANCELED) {
+			if (!completion_done(&initial_balloon) && !xen_pv_domain())
+				pr_err("Initial balloon down failed, expect the domain to be killed wi=
th \"out of PoD memory\" error by Xen.\n");
+			complete(&initial_balloon);
+		}
+
 		wait_event_freezable_timeout(balloon_thread_wq,
 			balloon_thread_cond(state, credit), timeout);
=20
@@ -706,6 +717,20 @@ static void __init balloon_add_region(unsigned long st=
art_pfn,
 }
 #endif
=20
+static int __init wait_for_initial_balloon_down(void)
+{
+	mutex_lock(&balloon_mutex);
+	/* optionally re-init completion after retrieving balloon target */
+	if (current_credit() < 0)
+		reinit_completion(&initial_balloon);
+	mutex_unlock(&balloon_mutex);
+	printk(KERN_INFO "waiting for initial balloon down %ld\n", current_credit=
());
+	wait_for_completion(&initial_balloon);
+	printk(KERN_INFO "done waiting for initial balloon down %ld\n", current_c=
redit());
+	return 0;
+}
+late_initcall(wait_for_initial_balloon_down);
+
 static int __init balloon_init(void)
 {
 	struct task_struct *task;
--=20
2.31.1


--QsU+wNDWzJA/oy32--

--N3tx0KCYiCI/3eVV
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmFxcSkACgkQ24/THMrX
1yyjlgf8CDdkixL9JjLiXZvZzf+wK2mr+z3rJyl2EivviEYqXUiEcWUzXW7zRu5Q
fTUOzvj2yYGASrg3cC+to6+GTW9odK0Jc1tIuJWVxn2okgA+Yq3JlP7IORKeEO0T
E+/ZEwpEAA8ztCo8ZMDwlDAFNXM6q43TQh3u+ASHTXzQFFttK0MGwQaOHvQ2fzf7
GIul0UUBuekPFhlAyzeKfQm6pxq1MpQuGB/yBqWDThCnQ8yWQAx+ZQFMGQUY1wwO
BYp+fDIS9Tudrrm+t20Bb42J0DwwSSdQaRuOAwPsEahlzje7/PNtobvjvlPV0l1a
WAdVCvUTgIhXWFUGR0qpO80eiEiDOQ==
=yMm+
-----END PGP SIGNATURE-----

--N3tx0KCYiCI/3eVV--


From xen-devel-bounces@lists.xenproject.org Thu Oct 21 13:55:20 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Oct 2021 13:55:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.214429.372973 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdYXP-0006Zg-IQ; Thu, 21 Oct 2021 13:55:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 214429.372973; Thu, 21 Oct 2021 13:55:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdYXP-0006ZZ-E6; Thu, 21 Oct 2021 13:55:19 +0000
Received: by outflank-mailman (input) for mailman id 214429;
 Thu, 21 Oct 2021 13:55:18 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=JnKy=PJ=citrix.com=anthony.perard@srs-us1.protection.inumbo.net>)
 id 1mdYXO-0006Xy-04
 for xen-devel@lists.xenproject.org; Thu, 21 Oct 2021 13:55:18 +0000
Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id dd9d9a9f-41d7-438f-a1d2-5977ae7dd61e;
 Thu, 21 Oct 2021 13:55:16 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: dd9d9a9f-41d7-438f-a1d2-5977ae7dd61e
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1634824516;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=zKHXm1l5/XwOUwChoc6WGnoXB4Za8iwdKfQiFfUL2PE=;
  b=CIZQiteuhoFFHaZ/nFQZ8Dtd3aH1XEY253B9djKJgVuC8IlgpqSa8KVM
   fVXWvh+h1AuPJtLCDoCSVFHoNHpUZaKqqVTIIO/MXvV8yYYCf9yObF+AF
   1LAGdJ0uakZMVq0K4VmI1n9s2yXkdcQhNvJEPrXjabzSNmPEKx+jbKdS5
   8=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: wSm5rzul3gcQiQU6He+bUZQsx9NbquwdC62KML4PUjZgav/Z003d8zp+sob2HWRiOxmSHojPNz
 IvkDHay8ZgJCW5FH/+9tRGmhMOQ42LEM+ryrO4ccS1kFMYy+9AqgtabAKkmARXznAHsTJyvxoU
 GNFkBBa72pf3bhOb5BwNWsFkdlu4Cha7kLU/rV1coO9ATomFmgp6YZg554wHQ0gqvV3+u5+iYg
 JUvg8/gO284UzyqRBCI9mC3WdxwrCOjr6npO4wcGF8+Kj8JRqVVkogc08Eaqma22DtyyFmS2PI
 8n4CFJwkC/QQSmzp/lid4Tea
X-SBRS: 5.1
X-MesageID: 55727308
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:qIo8w6IsYEBwJsTwFE+RcJIlxSXFcZb7ZxGr2PjKsXjdYENSgjNVy
 WsXCz2GOvqJNjH8e9BxYYi3oE0OuMfUn4BnTgJlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s
 q3yv/GZdJhcokcxIn5BC5C5xZVG/fjgqoHUVaiUZUideSc+EH140Eo5wrZj6mJVqYPR7z2l6
 IuaT/L3YDdJ6xYsWo7Dw/vewP/HlK2aVAIw5jTSV9gS1LPtvyB94KYkDbOwNxPFrrx8RYZWc
 QphIIaRpQs19z91Yj+sfy2SnkciGtY+NiDW4pZatjTLbrGvaUXe345iXMfwZ3u7hB2ExPlb1
 I9HmqfzdlZzPv3Mt95FSjdhRnQW0a1uoNcrIFC6uM2XiUbHb2Ht07NlC0Re0Y8wo7gtRzsUr
 LpBdW5LPkvra+GemdpXTsFlgNgjK8/6epsSoHh6wRnSDOo8QICFSKLPjTNd9Gpt2ZoRRq6OD
 yYfQSNpbxDGPSxxBnQoNcIzhcyEoSj2cyIN/Tp5ooJoujOOnWSdyoPFL979atGMA8JPkS6wm
 GXC+GjoBwAAA/aWwzGF73GEi/fGmGXwX4d6PK218LtmjUOewkQXCQYKTh2rrP+hkEm8VtlDb
 UsO9UIGtrMu/UamSt38WRyQo3OeuBMYHd1KHIUS6guA167V6AaxHXUfQ3hKb9lOnM4pRxQ62
 1mRhdTrCDdz9rqPRhq19KqQrD60ETgYKykFfyBscOcey4C9+sdp1EuJF4s9Vv7u5jHoJd3u6
 z3RhQIi3b88to00hv+7rVDouWq1iKGcG2bZ+T7rdm6i6wp4YqusaIqp9UXX4J58EWqJcrWSl
 CNbw5bGvYjiGbnIzXbXGLxcQ9lF8t7caGWE6WODCaXN4NhEF5SLRotX/C1lbHlgNsIJaFcFi
 2eC5FsPuve/0JasBJKbgr5d6ex2ksAM9vy/D5g4i+aihLArKWdrGwk1PSatM5jFyhRErE3GE
 c7znTyQJXgbE7976zG9Wv0Q17QmrghnmziPGs2mk0z4juXFDJJwdVvjGAHTBgzexPjcyDg5D
 v4Fb5fao/mheLyWjtbrHX47cglRcClT6WHeoM1LbO+TSjeK60l6Y8I9NYgJItQ/94wMz7+g1
 ijkBidwlQqu7VWaeF7iQi0yN9vSsWNX8CtT0doEZg3zhRDOoO+Hsc8iSnfAVeN6r7Y8kaclF
 KdtlgfpKq0ndwkrMg81NfHVxLGOvjz07e5XFyb6MjU5YbB6QAnFpo3tcgf1rXFcBSurr8ou5
 ban01qDE5YEQg1jCufQae6ukAzt7SRMxroqUhuaOMRXdWXt7JNud377gMgoLpxeMh7E3Dabi
 VqbWE9KuenXroYp29DVnqTY/ZyxGu5zExMCTWnW5Lq7LwfA+W+nzdMSWeqEZ2mFBmj15L+jd
 aNeyPSlaK8Lm1NDsoxdFbd3zP1hu4uz9uEClgk9RSfFdVWmDL9kM0Kq58gXu/0f3KJdtCu3R
 lmLpotQN4KWNZ63C1UWPgckMLiOjKlGhjnI4P0pC0zm/ysrrqGfWEBfMhTQ2ixQKLx5bNEsz
 es74ZNE7gW+jlwhM8qcjzAS/GOJdyRSX6Iiv5AcIYnqlgt0lQ0SPc2CUnf7sMOVdtFBEkg2O
 TvF1qPNioNVylfGb3duR2PG2vBQhMhWtR1HpLPYy49lRjYRaicL4SBs
IronPort-HdrOrdr: A9a23:ZrDgRa4COcMbFFQ6UwPXwDLXdLJyesId70hD6qkQc3FomwKj9/
 xG/c5rsSMc7Qx6ZJhOo7+90cW7L080lqQFhLX5X43SPzUO0VHARO1fBOPZqAEIcBeOlNK1u5
 0AT0B/YueAcGSTj6zBkXWF+wBL+qj5zEiq792usUuEVWtRGsZdB58SMHfhLqVxLjM2Y6YRJd
 6nyedsgSGvQngTZtTTPAh+YwCSz+e77a4PeHQ9dmYa1DU=
X-IronPort-AV: E=Sophos;i="5.87,170,1631592000"; 
   d="scan'208";a="55727308"
Date: Thu, 21 Oct 2021 14:54:52 +0100
From: Anthony PERARD <anthony.perard@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, George Dunlap
	<george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>, Julien Grall
	<julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>, Wei Liu
	<wl@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, Roger Pau
 =?iso-8859-1?Q?Monn=E9?= <roger.pau@citrix.com>,
	<xen-devel@lists.xenproject.org>
Subject: Re: [XEN PATCH v7 42/51] build: grab common EFI source files in arch
 specific dir
Message-ID: <YXFxLJ/F9uXtTuaH@perard>
References: <20210824105038.1257926-1-anthony.perard@citrix.com>
 <20210824105038.1257926-43-anthony.perard@citrix.com>
 <43684fcc-f6ca-86f2-9fb1-d3d5d9dbc20d@suse.com>
 <YWmse5Sv2SFyRMdj@perard>
 <fd11108b-db66-3c0e-9a7e-a5e30b0b5b1f@suse.com>
 <YXFJD3LlFfbivA6Z@perard>
 <938f059d-9d08-75bd-01ee-5d442a5e9961@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <938f059d-9d08-75bd-01ee-5d442a5e9961@suse.com>

On Thu, Oct 21, 2021 at 01:24:27PM +0200, Jan Beulich wrote:
> On 21.10.2021 13:03, Anthony PERARD wrote:
> > On Mon, Oct 18, 2021 at 10:48:26AM +0200, Jan Beulich wrote:
> >> On 15.10.2021 18:29, Anthony PERARD wrote:
> >>> On Thu, Oct 14, 2021 at 10:51:44AM +0200, Jan Beulich wrote:
> >>>> On 24.08.2021 12:50, Anthony PERARD wrote:
> >>>>>  obj-y += boot.init.o pe.init.o ebmalloc.o runtime.o
> >>>>>  obj-$(CONFIG_ACPI) +=  efi-dom0.init.o
> >>>>> +
> >>>>> +$(obj)/%.c: common/efi/%.c
> >>>>> +	$(Q)cp -f $< $@
> >>>>
> >>>> In case both trees are on the same file system, trying to hardlink first
> >>>> would seem desirable. When copying, I think you should also pass -p.
> >>>
> >>> I don't know if doing an hardlink is a good thing to do, I'm not sure of
> >>> the kind of issue this could bring. As for -p, I don't think it's a good
> >>> idea to copy the mode, ownership, and timestamps of the source file, I'd
> >>> rather have the timestamps that Make expect, e.i. "now".
> >>
> >> Why would "now" be correct (or expected) in any way? The cloned file is no
> >> different from the original. Nevertheless I agree that -p is not ideal;
> >> it's just that the more fine grained option to preserve just the timestamp
> >> is non-standard afaik. You could try that first and fall back to -p ...
> >> Otherwise, failing hard linking and using "cp -p", I'm afraid I'd prefer
> >> symlinking despite the arguments against it that you name in the
> >> description.
> > 
> > I guess I'm missing something, is there a reason to keep/copy the
> > timestamps of the original files?
> 
> Avoidance of confusion is my main aim here. I certainly would be puzzled
> to see what looks like a source file to have a time stamp much newer than
> expected.

So, there isn't really anything to do with the timestamps :-). I guess
we could keep using symbolic links, but force update the link at every
build.

I've tried that:
    $(obj)/%.c: $(abs_srctree)/common/efi/%.c FORCE
        $(Q)ln -nsf $< $@

and make seems happy. The link command run every time (due to adding
FORCE), but the `CC` command isn't, so that seems good. The recipe that
would run the `CC` command check if the prerequisite are newer than the
target using $? so it doesn't matter if the rule that update the source
file as run or not.

Thanks,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Thu Oct 21 13:57:03 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Oct 2021 13:57:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.214441.372984 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdYZ4-0007I6-U7; Thu, 21 Oct 2021 13:57:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 214441.372984; Thu, 21 Oct 2021 13:57:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdYZ4-0007Hz-Qp; Thu, 21 Oct 2021 13:57:02 +0000
Received: by outflank-mailman (input) for mailman id 214441;
 Thu, 21 Oct 2021 13:57:01 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mdYZ3-0007Hn-TN; Thu, 21 Oct 2021 13:57:01 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mdYZ3-0001nB-OD; Thu, 21 Oct 2021 13:57:01 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mdYZ3-0005lR-Ej; Thu, 21 Oct 2021 13:57:01 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mdYZ3-0002ML-ED; Thu, 21 Oct 2021 13:57:01 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=BzWHCtjmXqzDCtd7W2XEXE38eodXiOKxDpNk9p5Z6nw=; b=rpO1QsXcpcbtIZeTEAGcvD9E13
	myEIGCtItack6w9qBVA2C/tLvDgi5Ze9YiZvHivM5hUUa80LHF8/xJ83G14Tb3LvcDg6xgI18M/l5
	T6moASRb0jQT69RmEIpfb5vLCSznDFn1cIIncVtrndksPJ6ERvgYUQqItIAY0uvwP5Gg=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165708-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 165708: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=98f60e5de00baf650c574c9352bb19aedb082dea
X-Osstest-Versions-That:
    xen=118da371d1ff5d8432fa299544b1ea5e7e3710f0
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 21 Oct 2021 13:57:01 +0000

flight 165708 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165708/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  98f60e5de00baf650c574c9352bb19aedb082dea
baseline version:
 xen                  118da371d1ff5d8432fa299544b1ea5e7e3710f0

Last test of basis   165691  2021-10-20 16:01:40 Z    0 days
Testing same since   165708  2021-10-21 11:01:40 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Julien Grall <jgrall@amazon.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   118da371d1..98f60e5de0  98f60e5de00baf650c574c9352bb19aedb082dea -> smoke


From xen-devel-bounces@lists.xenproject.org Thu Oct 21 14:11:10 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Oct 2021 14:11:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.214452.372998 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdYmc-0001Ec-7W; Thu, 21 Oct 2021 14:11:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 214452.372998; Thu, 21 Oct 2021 14:11:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdYmc-0001EV-3m; Thu, 21 Oct 2021 14:11:02 +0000
Received: by outflank-mailman (input) for mailman id 214452;
 Thu, 21 Oct 2021 14:11:00 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=JnKy=PJ=citrix.com=anthony.perard@srs-us1.protection.inumbo.net>)
 id 1mdYma-0001EP-MI
 for xen-devel@lists.xenproject.org; Thu, 21 Oct 2021 14:11:00 +0000
Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id b71dad9e-3278-11ec-8379-12813bfff9fa;
 Thu, 21 Oct 2021 14:10:59 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b71dad9e-3278-11ec-8379-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1634825459;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=45N65VZQcxPM9cickRp478SlWsWzibHoassEhe4ILUk=;
  b=TUwmE4FsdLUw3Q7win9/7Eb/LBOYV8xjqWHsBmF08wY4czPRca82gKMu
   XeWpmYNgSS3tgpZwHJ3i6x4K+0Xp6m84eYGAbzww9qV0Rbtoace07AhBR
   NXqhtV0vDydbCM+Op//5jNr5nVl2FSI87Zg2LfKhzwyfCF+SNbo9e7Vdh
   w=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: uIbS3Rzip1lnZpIpauQUlkpcOoON0FVDl+Q8GjGt+CBbmwAhvUr4PWOklYpn1qfwBZPaB9SQyC
 /bgw461+gdc6N6H0I8BVlx2O9q+qs96VvDiOeZSd1BrrDAlGH4MybNJ826HPmripTDNuqWaOWF
 k4ArbRld+oY7/ljtPh8fCXsQMTk9I04jWbQezOyDLTlARRddcZ9+AwsbS2yrz0pxCYq0adFtvG
 BT4mSKZOdCJot1Qhnaaf5BfnuoK+I/o2vZ3nZLxsoasvtIVRm7/k86mh7HgP5Fp7LwpAqZNPC3
 PpvXyn6UBxVlDOQaLLPyLEA5
X-SBRS: 5.1
X-MesageID: 57650170
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:YN1gbKKENJtPx//DFE+R1pMlxSXFcZb7ZxGr2PjKsXjdYENS32QOy
 mseW2yOaa2NYGr8ft93YN++8UxVscXSx9NgSVFlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s
 q3yv/GZdJhcokcxIn5BC5C5xZVG/fjgqoHUVaiUZUideSc+EH140Eo5wrZj6mJVqYPR7z2l6
 IuaT/L3YDdJ6xYsWo7Dw/vewP/HlK2aVAIw5jTSV9gS1LPtvyB94KYkDbOwNxPFrrx8RYZWc
 QphIIaRpQs19z91Yj+sfy2SnkciGtY+NiDW4pZatjTLbrGvaUXe345iXMfwZ3u7hB3TgPcuz
 9wO7KCWUAQqNJ/KyLQhUkdHRnQW0a1uoNcrIFC6uM2XiUbHb2Ht07NlC0Re0Y8wo7gtRzsUr
 LpBdW5LPkvra+GemdpXTsFlgNgjK8/6epsSoHh6wRnSDOo8QICFSKLPjTNd9Gpv2J0WRKmGD
 yYfQRVeLy7HSQVAA2dNWL8ysryCp1PjVyIN/Tp5ooJoujOOnWSdyoPFM93TYNWGA9pUmkWwo
 XjP9GD0RBodMbS39z2B9X69g/7VqgnyUokSCb6Q++ZjhRuYwWl7IBEZWVa0u/CRll+1W9UZL
 VcdvCUps8Aa5EGtC9XwQRC8iHqFpQIHHcpdFfUg7wOAwbaS5ByWbkAIViVEacAmnMYuSCY2y
 0SSmNf0GT1otqbTQnWYnp+LqRuiNC5TKnUNDQcGQhEC+MLLu5wog1TESdMLOKy/g8DxGDrw6
 yuXtyV4jLIW5eYKyKeT7V3BmyirpJXCUkgy/Aq/dnm+8gpzaYqhZoqpwVvW9/BNKMCeVFbpl
 HoZn8mT6sgeAJfLkzaCKNjhB5nwuazDameFxwcyQd9xrFxB5kJPY6gK/xYhI04qa/oiYDzqa
 n3V6VNt5cFMaS7CgbBMX6q9DMEjzK7FHNvjV+zJYtcmXqWdZDNr7wk1OhbOhzGFfFwE1PhlY
 8/CIJnE4WMyUPw/lFKLq/EhPajHL8zU7VjYQozn1FyZ2L6aaW/9pVwtYQbWML5RAE9ppmzoH
 zdj2ymil0o3vA7WOHC/HWsvwbYidyVT6Xfe8JQ/SwJ7ClA6cFzN8teIqV/bR6Rrnr5OisDD9
 WynV0lTxTLX3COcdVrXNyw7N+ywBv6TSE7X2wR2YD5EPFB4Oe6SAFo3LcNrLdHLCsQypRKLc
 xX1U5rZWakeItg20z8ccYP8vORfmOeD3mqz096eSGFnJfZIHlWRkve9J1eH3HReX0Kf6Jply
 5X9h1yzfHb2b1k7ZCogQKn0lA3ZULl0sL8aYnYk1fEJJR62r9Qzenev5hL1SulVQSj+KvKh/
 17+KX8lSSPl/ufZKfHF2vKJqZmHCex7EhYIFmXX9+/uZyLb4nCi0clLV+PRJWLRU2b9+aODY
 +RJzq6jbK1bzQgS64csQax2ya8e5sf0o+MIxApTA3iWPU+gDaltIyfa0JAX5LFN3LJQpSC/R
 lmLpotBIbyMNc68SAwRKQMpY/6tz/YRnjWOv/05LF+jvH18/aadUFUUNB6J0XQPILxwOYIj4
 OEgpM9JtFDv1kt0ao6L13kG+X6NI3oMV7QcmqsbWIK72BA2zlxiYIDHDnOk6p+4dNgRYFIhJ
 SWZhfSeiu0ElFbCaXc6CVPEwfFZ2cYVoBlPwVIPewaJl97CiqNl1RFd621qHAFczxEB2ONvI
 Gl7cUZyIPzWrTtvgcFCWUGqGh1AW0LFqhCglQNRmT2LVVSsW0zMMHY5aLSE800u+m5BeiRWo
 eODw2H/XDe2JMz800Peg6K+RyAPmTCpyjD/pQ==
IronPort-HdrOrdr: A9a23:x3LgD6tOC1dYlDSvdg1TbYyi7skDdtV00zEX/kB9WHVpmszxra
 6TddAgpHvJYVcqKRQdcL+7VZVoLUmxyXcx2/h3AV7AZniFhILLFuFfBOLZqlWKcREWtNQttp
 uIG5IObuEYZmIasS+V2maFL+o=
X-IronPort-AV: E=Sophos;i="5.87,170,1631592000"; 
   d="scan'208";a="57650170"
Date: Thu, 21 Oct 2021 15:10:35 +0100
From: Anthony PERARD <anthony.perard@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Juergen Gross <jgross@suse.com>, Andrew Cooper
	<andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>, "Ian
 Jackson" <iwj@xenproject.org>, Julien Grall <julien@xen.org>, "Stefano
 Stabellini" <sstabellini@kernel.org>, Wei Liu <wl@xen.org>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Roger Pau =?iso-8859-1?Q?Monn=E9?=
	<roger.pau@citrix.com>, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>, "Ross
 Lagerwall" <ross.lagerwall@citrix.com>, Daniel De Graaf
	<dgdegra@tycho.nsa.gov>, "Daniel P. Smith" <dpsmith@apertussolutions.com>,
	<xen-devel@lists.xenproject.org>
Subject: Re: [XEN PATCH v7 49/51] build: adding out-of-tree support to the
 xen build
Message-ID: <YXF02ztUiXXiRwxQ@perard>
References: <20210824105038.1257926-1-anthony.perard@citrix.com>
 <20210824105038.1257926-50-anthony.perard@citrix.com>
 <2aaf0858-1602-be5c-77e4-2daa7fddc534@suse.com>
 <YWmzSkLdH5wtQ77V@perard>
 <f53e4d09-9f33-6dc8-8161-156b9eca4a6b@suse.com>
 <YW1Dhn+oEwvKgj04@perard>
 <70b8f320-bcd8-b864-f9de-a7ea35d53928@suse.com>
 <5a4df707-5b12-a471-e957-1a1c43340bff@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <5a4df707-5b12-a471-e957-1a1c43340bff@suse.com>

On Mon, Oct 18, 2021 at 12:36:45PM +0200, Jan Beulich wrote:
> On 18.10.2021 12:28, Juergen Gross wrote:
> > On 18.10.21 11:51, Anthony PERARD wrote:
> >> On Mon, Oct 18, 2021 at 11:02:20AM +0200, Jan Beulich wrote:
> >>> Oh, now I'm curious as to the why here. I thought use of $(srctree)
> >>> ought to be the exception.
> >>
> >> In Linux, the use of $(srctree) is indeed the exception. This is because
> >> we have VPATH=$(srctree), so when `make` look for a prerequisite or a
> >> target it will look first in the current directory and then in
> >> $(srctree). That works fine as long as the source tree only have sources
> >> and no built files.
> >>
> >> But if we want to be able to build the pv-shim without the linkfarm and
> >> thus using out-of-tree build, we are going to need the ability to build
> >> from a non-clean source tree. I don't think another way is possible.
> > 
> > Is there any reason (apart from historical ones) to build the hypervisor
> > in $(srctree)?
> > 
> > I could see several advantages to build it in another directory as soon
> > as the build system has this capability:
> > 
> > - possibility to have a simple build target for building multiple archs
> >    (assuming the cross-tools are available), leading to probably less
> >    problems with breaking the build of "the other" architecture we are
> >    normally not working with (and in future with e.g. Risc-V being added
> >    this will be even more important)
> > 
> > - possibility to have a debug and a non-debug build in parallel (in fact
> >    at least at SUSE we are working around that by building those with an
> >    intermediate "make clean" for being able to package both variants)
> > 
> > - make clean for the hypervisor part would be just a "rm -r"
> 
> I fully agree, yet ...
> 
> > Yes, this would require us (the developers) to maybe change some habits,
> > but I think this would be better than working around the issues by
> > adding $(srctree) all over the build system.
> 
> ... developers' habits would only be my second concern here (and if that
> had been the only one, then I would not see this as a reason speaking
> against the change, but as said I've never been building from the root,
> and I've also been building sort of out-of-tree all the time). Yet while
> writing this reply I came to realize that my primary concern was wrong:
> People would not need to adjust their spec files (or alike), at least
> not as long as they consume only files living under dist/.
> 
> So, Anthony - thoughts about making the default in-tree Xen build
> actually build into, say, build/xen/?

I don't think I should be the one answering this question. It would
probably be fairly easy to do.

But, I've already got some unfinished patches which add the ability to
do in-tree and out-of-tree at the same time, so I'll propose them and we
can decide whether they are worth it or if they are too much. That is,
after we have at least the ability to do out-of-tree build.

Cheers,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Thu Oct 21 14:16:48 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Oct 2021 14:16:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.214462.373008 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdYrz-0001xn-UY; Thu, 21 Oct 2021 14:16:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 214462.373008; Thu, 21 Oct 2021 14:16:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdYrz-0001xg-RZ; Thu, 21 Oct 2021 14:16:35 +0000
Received: by outflank-mailman (input) for mailman id 214462;
 Thu, 21 Oct 2021 14:16:34 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=FF+c=PJ=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mdYry-0001xa-Iw
 for xen-devel@lists.xenproject.org; Thu, 21 Oct 2021 14:16:34 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 7d59be94-3279-11ec-8379-12813bfff9fa;
 Thu, 21 Oct 2021 14:16:32 +0000 (UTC)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2107.outbound.protection.outlook.com [104.47.17.107])
 (Using TLS) by relay.mimecast.com with ESMTP id
 de-mta-23-adw2vX9aOpeDVcU13EfUxA-1; Thu, 21 Oct 2021 16:16:30 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB6864.eurprd04.prod.outlook.com (2603:10a6:803:138::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.17; Thu, 21 Oct
 2021 14:16:28 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::8062:d7cb:ca45:1898]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::8062:d7cb:ca45:1898%3]) with mapi id 15.20.4628.018; Thu, 21 Oct 2021
 14:16:27 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM5PR0601CA0041.eurprd06.prod.outlook.com (2603:10a6:203:68::27) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.16 via Frontend
 Transport; Thu, 21 Oct 2021 14:16:26 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7d59be94-3279-11ec-8379-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634825791;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=vY5xAjw1zQP/7a0lPh85sUUKQUpYnQ73bKWEERsYhgc=;
	b=BbtQZuJKL5lCz8sQXluMzXj3ALvzIbOCQIThTgSHw58WLbVzMEhwb6c9JWDrcOGsMgCTEj
	n5z7POpbiVI8dc1SUbZfw3T0J9Py29XjHkUzqjC9KHytTfEm7c/QdKFI5FtRHnkTVMU2t7
	BbiyrbVPPJZ2kYKUYwMR6nu0F0fagUQ=
X-MC-Unique: adw2vX9aOpeDVcU13EfUxA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=L10N8byApC6lHOqR7Zpa5yIQkV54JFSvD4RQQon387y9w1OC+vmEZs2IwtkU0tQTMip/zP41upTJ6CS+s6ICRE2kg9tOnmHdVavLgK6dsaRQw+fNv3lVoiw509Uouelld2xXJxeprCJSc8jYRqMMzKjYGhnzlOhSq6wBlH/xCp66vN+v+ol9gcclIuA7ntoM5jK35npLFWafnUH/Oy6YLyNgzbIXckTqTsEqIdCvce/mT4+rBxOnozmr9KhMDxghKtvLaj7Pmxa196N9/j8hQmGuH/nkmSmlJYFsP5knlBypUOnd5pGtY3vGtU3s6b1eQ84HSLvpwgG/V97yPi1WWQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=vY5xAjw1zQP/7a0lPh85sUUKQUpYnQ73bKWEERsYhgc=;
 b=ITxGqUKo/GcETJJMsrixbSimyO18i9RVdh0vQhJgce2DotV++aEorqSaiTUFinQp1jhStjqNa+u+HVk3yKx8axXfP2VEfif6kbRSHbblhEN5YGIsx9xS/A+EwQOTmJtRIknuScRW4WVpotcFZV7DHSc49WJkPXtxSnmceZ9ic/cvYeqNkDcZl+essTq1OPvuzKyU/wo5jk7+fYwF+47ODhJ/EJ4DxnU1VEVczGW5wYCGW46PInXsZoTqbGyx2swWtWb5fZEiTEb5evexYpqCwqzX5nMKVimQWdSa5FsAv2XgfNeMCSCG1f2eYzOoWGamEUWemDzbMDrWD7YOtr5CSQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [XEN PATCH v7 42/51] build: grab common EFI source files in arch
 specific dir
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 xen-devel@lists.xenproject.org
References: <20210824105038.1257926-1-anthony.perard@citrix.com>
 <20210824105038.1257926-43-anthony.perard@citrix.com>
 <43684fcc-f6ca-86f2-9fb1-d3d5d9dbc20d@suse.com> <YWmse5Sv2SFyRMdj@perard>
 <fd11108b-db66-3c0e-9a7e-a5e30b0b5b1f@suse.com> <YXFJD3LlFfbivA6Z@perard>
 <938f059d-9d08-75bd-01ee-5d442a5e9961@suse.com> <YXFxLJ/F9uXtTuaH@perard>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <1d16dc6c-3299-88c4-a25d-c46b0bd021f3@suse.com>
Date: Thu, 21 Oct 2021 16:16:24 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <YXFxLJ/F9uXtTuaH@perard>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM5PR0601CA0041.eurprd06.prod.outlook.com
 (2603:10a6:203:68::27) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 481f1e05-0abb-4167-f24f-08d9949d5ef9
X-MS-TrafficTypeDiagnostic: VI1PR04MB6864:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB6864D61689A4D884B6FE91B2B3BF9@VI1PR04MB6864.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	MnqHlgSUUUnlOaysHQAbolFg4GFn+dHEcsc9bdgiiTWIDt0VX6WEy9yrXCOdsuBm5puvAVlzPUFfBCQXGAske/mJFxacKORi1oMplUh+J2fiQ7SjNFTQGMpwbPaXB1Z4wjKw0tHO/VIUSLHSDQBkAjludaJrhHOCydIuH3s87zMSEjLNr5rDgnhsq9TMTmqz/EDkkcIKaJjrGQgKtOcsYRQjLFANEx6v3Qy+0quI5RWSJR1QGfTNpeyy5dt8ormtcZb7g/7V097fKAY3f5dWfsb0S5LFBHPY13Pe2r5GTAd3ut1/Bqhqqk9HwQwwVStmdCpVPlDI7KfebXapX8+rldqQZRZmdDBPRj15Y495qIPu87xZ8/03wCzX0N+dEUYDpz0Wp1G4QklvlUSjmjyOvSqPYPjSsAFgsYLRWXHSkWZ9MDBUjxlKdwi16htS0TlZZ0ilbM71WPK84ZY20c/e0yv/Xk2acl4ApB1I8QBvRElPq8FQzTK5Cw7Egc8XazUU/NeJk6Wkww6WEske0An8bi+VY6guZ0nsvwVvFozyvESDFQjsCJHwCKNjieprv/rDIMFBy6LdjmuU34dD1FVfUVEasHrKB/LMjtd3nsfTBuOa6mwoWgNVG8dNtrYU/mq04AhX7qV2m5q0UBo9CyX4YI7tEJqJ7OBenwCzIGNvb5hFEf5I53Isvj1FFgc4N2hL9voDJCBHbw/7BAsALC7D3K0DL0eSaq7bnRSxxJN8Tdk=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(316002)(6486002)(2906002)(956004)(36756003)(8936002)(26005)(4326008)(7416002)(31686004)(16576012)(54906003)(86362001)(66556008)(2616005)(8676002)(66476007)(66946007)(53546011)(83380400001)(31696002)(38100700002)(186003)(5660300002)(508600001)(6916009)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?d0JVblVTdzU3aVB5dE1ySktFemlaL0o4RzBFcThNT2NmVjZXVkxmQTZwM0ph?=
 =?utf-8?B?a2lVZk1JVk5CU0JzOG5PM28rYzZJM2N6dHVMei9MOENwc2l1YmowV1pBaXdi?=
 =?utf-8?B?L3hFcTYzMlVISE5WUXFQSmNKOEkzanZkc1Y4U0RZby80UVRTUFBTeDNaWTdh?=
 =?utf-8?B?U2MzdWpiYlFwOVcxU1g5MjBHUmFUV0lKc0YvZnBudDRGN04vNkVrMTQ1MFNt?=
 =?utf-8?B?bzAxNjBYa2RpeDFkL0FzMzJJR0tsRUlROCtvUExwMFF2STJNRGVEaktlV285?=
 =?utf-8?B?TFJUa2tsd0FDTTdWSE4ybnNuQlFRQmhaWXVHRUp2TnZLMjQrWFFxSTBXNFND?=
 =?utf-8?B?NTVlQkJVeXZyRERhT2lvckRjNHJNZmdhM0NRVVFYV2g3U0xyVEh0YzRBNlpJ?=
 =?utf-8?B?OEF5bUlnY25heEduMVJEUklveDJKN3VpQTN0NGdzdEFPd2w3OVg1dUcrelFB?=
 =?utf-8?B?MmpRaDBJT0dXYlQwcHl2ZTJLcjl4a0ZYMFZkeWs4Y3hlZ21HNlhrbG1LVUZO?=
 =?utf-8?B?UXpKaForVGxyWHl6TUIrRUZLeGpHb1pmMDRaOHVZL0ZpL0krSC9mTFVKbzZi?=
 =?utf-8?B?R0tiSlc1MlFoR0djaktjVmI0eEMzdTJoK3AyQldHVWc1VldoeHh3SHpQWXk1?=
 =?utf-8?B?K3dMZytpaDFyOGZnMm42UkNyMlpEVXBSNVdmLzY5aDkxR2w3ZUZaMnhZaTZs?=
 =?utf-8?B?RS9oNDMrYVRjdE80TDJ6UUFORlpodU0wbkdJdmQrVWEwSWRsNWo5ZmxlWFhX?=
 =?utf-8?B?RHRKYmc5OFl3TG1aUWJjL1NlamhWUGVJRERmNmUyZWVJbnlhT1YxZDROUXFW?=
 =?utf-8?B?VHRvOGp6bmRTOU43WGxwNTBncWNsZkxkUytQamptVUlqK3R1S3JTamRwSWdT?=
 =?utf-8?B?bU1XdmdYZVpRdmtuTFZJOFMyM0FmMW8wemgxdVJ6OHloS0l0VGVxMXg5cVRo?=
 =?utf-8?B?Yy9jZk9BTUN3UCt1ZkNvN3dXTE1DZGRBbXM5aW40RFZEMWJQSkVoR1pQcU5s?=
 =?utf-8?B?ZWhpOEptMzVyL1lLQkl5aUpZNnowalUvcmQ3TzFESS9MSDhwRDZnVmloZjdi?=
 =?utf-8?B?SmxJNG0xNzc4V2xWOHRCZ0NJUWJPYm13dkFXeHA5RmZHWGhXZUc2Zkl4Uklm?=
 =?utf-8?B?ekg1REE5anpPMDFRVzltWmh6eG93QUltQlByRWxJaDFJYXpWS0ljUVVVdjZK?=
 =?utf-8?B?QlVCWGlXVFozZXYrWmdPV0JTUWEySE9GRnhjWVNEajVMd1QxWE9yUk5HWE9z?=
 =?utf-8?B?NnJ4elBEZkxJUGorcHlIVXlibEhNNjFybWRsREdPTkhIZnE4SWhnajN5NFgr?=
 =?utf-8?B?bk01bDBoNkZTY1NQdHpYTGxORGJRN3o3MTA1MWdTdExGUnBsamdVWFhCZTdY?=
 =?utf-8?B?K1lHcUlHRUZvQmdUSlRYdWFJT090bVVyOG9SWUluc2NTVnZVZzhKYWlrS250?=
 =?utf-8?B?L3JOYnRLZVZrM2lvblZGL0ZzeVpDV2cxL2NiZUF2WmtBSEttajh1Tloyc0dk?=
 =?utf-8?B?VzBoOFVoRnFKeDVMREpyMEdJK0ZvUldOcVUwM0xtdHB4SkVvZTlIK01WS1Bj?=
 =?utf-8?B?dFU2Q0diT3ZsZEZmVEZlR25yQ3A4c1B2MEJhemNPZGFKZnhzdXhydmswbHNH?=
 =?utf-8?B?aUh1ZHQ0WmdvaTFnZ2dlSGcyK2FlSjU4dUdHVDZBRUhqRkQxWG9mV1RINjNN?=
 =?utf-8?B?dU1WcmRmQ3lIUXJGNzc5Z01RSzZsVVc3QWNDVkV1R1pKeTJTV0E3SkljZWdl?=
 =?utf-8?Q?27BzETEz64L5Jcvoc4u4vzi+Lxi8c2MPbrf98Pi?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 481f1e05-0abb-4167-f24f-08d9949d5ef9
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Oct 2021 14:16:27.9527
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jbeulich@suse.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6864

On 21.10.2021 15:54, Anthony PERARD wrote:
> On Thu, Oct 21, 2021 at 01:24:27PM +0200, Jan Beulich wrote:
>> On 21.10.2021 13:03, Anthony PERARD wrote:
>>> On Mon, Oct 18, 2021 at 10:48:26AM +0200, Jan Beulich wrote:
>>>> On 15.10.2021 18:29, Anthony PERARD wrote:
>>>>> On Thu, Oct 14, 2021 at 10:51:44AM +0200, Jan Beulich wrote:
>>>>>> On 24.08.2021 12:50, Anthony PERARD wrote:
>>>>>>>  obj-y += boot.init.o pe.init.o ebmalloc.o runtime.o
>>>>>>>  obj-$(CONFIG_ACPI) +=  efi-dom0.init.o
>>>>>>> +
>>>>>>> +$(obj)/%.c: common/efi/%.c
>>>>>>> +	$(Q)cp -f $< $@
>>>>>>
>>>>>> In case both trees are on the same file system, trying to hardlink first
>>>>>> would seem desirable. When copying, I think you should also pass -p.
>>>>>
>>>>> I don't know if doing an hardlink is a good thing to do, I'm not sure of
>>>>> the kind of issue this could bring. As for -p, I don't think it's a good
>>>>> idea to copy the mode, ownership, and timestamps of the source file, I'd
>>>>> rather have the timestamps that Make expect, e.i. "now".
>>>>
>>>> Why would "now" be correct (or expected) in any way? The cloned file is no
>>>> different from the original. Nevertheless I agree that -p is not ideal;
>>>> it's just that the more fine grained option to preserve just the timestamp
>>>> is non-standard afaik. You could try that first and fall back to -p ...
>>>> Otherwise, failing hard linking and using "cp -p", I'm afraid I'd prefer
>>>> symlinking despite the arguments against it that you name in the
>>>> description.
>>>
>>> I guess I'm missing something, is there a reason to keep/copy the
>>> timestamps of the original files?
>>
>> Avoidance of confusion is my main aim here. I certainly would be puzzled
>> to see what looks like a source file to have a time stamp much newer than
>> expected.
> 
> So, there isn't really anything to do with the timestamps :-). I guess
> we could keep using symbolic links, but force update the link at every
> build.
> 
> I've tried that:
>     $(obj)/%.c: $(abs_srctree)/common/efi/%.c FORCE
>         $(Q)ln -nsf $< $@
> 
> and make seems happy. The link command run every time (due to adding
> FORCE), but the `CC` command isn't, so that seems good. The recipe that
> would run the `CC` command check if the prerequisite are newer than the
> target using $? so it doesn't matter if the rule that update the source
> file as run or not.

Looks okay to me.

One additional consideration, though: Linux puts a "source" link in the
build tree. If we did so as well, then that could be the only absolute
symlink that's needed. Links like the one you suggest could be relative
ones into source/. But I guess this could as well be left as a future
exercise, in case anyone cares to limit the number of absolute symlinks.

Jan



From xen-devel-bounces@lists.xenproject.org Thu Oct 21 14:36:35 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Oct 2021 14:36:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.214470.373020 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdZBE-0004Gv-KF; Thu, 21 Oct 2021 14:36:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 214470.373020; Thu, 21 Oct 2021 14:36:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdZBE-0004Go-Gy; Thu, 21 Oct 2021 14:36:28 +0000
Received: by outflank-mailman (input) for mailman id 214470;
 Thu, 21 Oct 2021 14:36:27 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mdZBD-0004GL-Eg; Thu, 21 Oct 2021 14:36:27 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mdZBD-0002Xs-6M; Thu, 21 Oct 2021 14:36:27 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mdZBC-00076l-Rj; Thu, 21 Oct 2021 14:36:26 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mdZBC-0000BW-RF; Thu, 21 Oct 2021 14:36:26 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=XmpD+3rRcIO9BsN1K7fCmiByHoFwiNQs+i9ryNDAMDg=; b=4dSv7XwTHPqVoCipLRDvkBaII9
	KUWbty2OMi0f4TYH92/DmYRJwUSVrds0A1y3OTesr0sKkSvndC03NZMuqvVkjEWRk3oEPisUSwjaV
	xzfiT1+wABAUDg+HQck4hXMhM+tIciVsLLN+949IjYj/vitjB0dF8npS+g5AOK+3f/P4=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165699-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 165699: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-unstable:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:debian-hvm-install:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:allowable
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=118da371d1ff5d8432fa299544b1ea5e7e3710f0
X-Osstest-Versions-That:
    xen=c12731493ae39640c4e44d9fe2029c3165f9f429
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 21 Oct 2021 14:36:26 +0000

flight 165699 xen-unstable real [real]
flight 165710 xen-unstable real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/165699/
http://logs.test-lab.xenproject.org/osstest/logs/165710/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 12 debian-hvm-install fail pass in 165710-retest

Regressions which are regarded as allowable (not blocking):
 test-amd64-amd64-xl-rtds     20 guest-localmigrate/x10   fail REGR. vs. 165692

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 165692
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 165692
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165692
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165692
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 165692
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 165692
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 165692
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 165692
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 165692
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 165692
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165692
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 165692
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  118da371d1ff5d8432fa299544b1ea5e7e3710f0
baseline version:
 xen                  c12731493ae39640c4e44d9fe2029c3165f9f429

Last test of basis   165692  2021-10-20 16:37:57 Z    0 days
Testing same since   165699  2021-10-21 03:03:05 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Bertrand Marquis <bertrand.marquis@arm.com>
  Julien Grall <jgrall@amazon.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        fail    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     fail    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   c12731493a..118da371d1  118da371d1ff5d8432fa299544b1ea5e7e3710f0 -> master


From xen-devel-bounces@lists.xenproject.org Thu Oct 21 14:41:40 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Oct 2021 14:41:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.214481.373033 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdZGC-0005jv-D7; Thu, 21 Oct 2021 14:41:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 214481.373033; Thu, 21 Oct 2021 14:41:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdZGC-0005jo-A7; Thu, 21 Oct 2021 14:41:36 +0000
Received: by outflank-mailman (input) for mailman id 214481;
 Thu, 21 Oct 2021 14:41:35 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=FF+c=PJ=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mdZGB-0005ji-Aa
 for xen-devel@lists.xenproject.org; Thu, 21 Oct 2021 14:41:35 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id fc367c0e-327c-11ec-837d-12813bfff9fa;
 Thu, 21 Oct 2021 14:41:33 +0000 (UTC)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2058.outbound.protection.outlook.com [104.47.12.58]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-30-43pGweL7Opax4qoQVy3wDA-1; Thu, 21 Oct 2021 16:41:31 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0402MB2701.eurprd04.prod.outlook.com (2603:10a6:800:af::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.17; Thu, 21 Oct
 2021 14:41:29 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::8062:d7cb:ca45:1898]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::8062:d7cb:ca45:1898%3]) with mapi id 15.20.4628.018; Thu, 21 Oct 2021
 14:41:28 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS9PR06CA0052.eurprd06.prod.outlook.com (2603:10a6:20b:463::20) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.18 via Frontend
 Transport; Thu, 21 Oct 2021 14:41:27 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fc367c0e-327c-11ec-837d-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634827292;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=Z9skogwIVaoE51VgiADyKu7H97fKgw3Cv0RDkANNOaQ=;
	b=FsKh6Usl8kRWZAu8601y/cxA1NQuRprtOe3OKdN/wwwsNoTWeRePDWpr9mh/fDWbiTVP+S
	3btypHJhrWCDYnyhlPFOu8QdlrQ1s8tUCKWqHiwXeFKOQp5GLMPD7sTqfDFiO6KZxFFRqp
	iWjymg5DM8L7DuRFzHj8NX8PWdRsQw4=
X-MC-Unique: 43pGweL7Opax4qoQVy3wDA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=oOMsZ28bOxf9Hp0p7BrMX2PzUULSWc8Id9CLahkPmZWur6AONk6QUof26v5ft8SPNaw3fuuYFVkJTX7FTFD531XV+xAM8CYAOtVM6o+aWMeLaDiqYTd3c+WZtvpNhWEHPTYl5RcGm/c/QaS1seP+cbUEBFZF5FTuMHHUCDr64OpYKSjAwh4k2a8LO5iYZHqANzOSG3OOwDpJC/mxxRxKL9Cnb6UNgSYq/+LUkL40F+pKqqCu1LAo8QRFu4zrwNVThuShBo1CttRycS2Hadj3uxLNSzZH8hAf8WC6e2vMFD//91s4YCS8wIacFNarD7BJPDed5yYorhPE06H5yvPU7A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Z9skogwIVaoE51VgiADyKu7H97fKgw3Cv0RDkANNOaQ=;
 b=CEvW+dsSYxsRSjFeO7IWLpGjWrGJhtEgHk4wRJKeN2Fha7CwU73bq4j4xiUd8WJC72SS9+G8HIh6abWZCRAznB/H/ISChjk4qhX/gq7eSU52pAGIz/LewVaSrVVh27n5IUTQvF887UGPf1QbSqkvkSK5VEN9DDLvOkcEYzqoy/MT8f2MZ+17qoVICB3+V0aJ4tYJ00gZqqGOShxeusy4RzppeFe+NLAQV33r7LK8V2vw8GRRC0W7KBh7QUKkj4+GHD7Cy2phfz6C7F5l3Jn8HFYrshsxoLs87ZZfnwHbrCNzqPFvJXHDqil18WEkpP4eWY82DuZBjT1ZKZt4b0xhXw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [PATCH 10/12] xen/x86: call hypercall handlers via switch
 statement
To: Juergen Gross <jgross@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>, Wei Liu
 <wl@xen.org>, xen-devel@lists.xenproject.org
References: <20211015125152.25198-1-jgross@suse.com>
 <20211015125152.25198-11-jgross@suse.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <88c3d815-912c-a92c-2e96-7eff6a454a75@suse.com>
Date: Thu, 21 Oct 2021 16:41:26 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <20211015125152.25198-11-jgross@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0052.eurprd06.prod.outlook.com
 (2603:10a6:20b:463::20) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 049d6b6c-573d-4c63-7b4d-08d994a0ddc8
X-MS-TrafficTypeDiagnostic: VI1PR0402MB2701:
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS:
	<VI1PR0402MB27018A42090A33FD5EF1A910B3BF9@VI1PR0402MB2701.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	AKel/N6GQPf4Cc+x8biAH438l4X89pP+cFarkuTNDt8RA7pB78vZx3DSpOMRT+Ec8uvPqny4U+gXJYDP5y8tvKcSgUoWzzTC9tbXyMpLQ5kEk/ycSPG5sv+g7Enb2wer1vUmKkH+UcDSMHascZ1EzABZzEilcj/x3ts6Jqi2FslL8XtIuuacOjk4yi7WQmWojMi9xwfhj47JjZu85tNjdEtMKDg5i829248Dh+C2mByR/wXpuzvr8KOmd5Ux3TV83LGYdyMB2KjxkWPF1KHpz0Pd4ttJXXGb7/gfYA4LGWOAo9lptUrXSnJ0B2ZDbB7DjcK1YlBxSmZxybEj/BZgCiMpQbfjdEgEU5aC233zR+irQCzrXEuUqaNUYDQ2VWsiTnQHJ0Wd04fyJo1o4owKskjY0mZelq6l9DlNEqiEE9Q+otHs/6ATic+Q3M7mZZ010XPdiJYv7K08NFCt6gP/jeOvJPRcUv2IfBeG6vyRq9Gc3khublj8Y+5FIa/EtiM/gYOKtuJI8Hle2kcOqSpShB522KlYLmV89eTZimqzgYa/E8dWtoZUVN02qX28vxsi/VHHn1JtrnktiOv1A7zjBmPj6SyXe9e1e2mNLQa/Sj/Z0Tmo1QcnY9BT4ifnnMSxz7dpzoj7Q23icPlp4OeFeJn85cJAFcFIvzmq8P/qcuOKNO/8fIM3cejcw1HdJl9qCmDOERBMm7/iEWnR0D8UYL8y+ZyWgDl78LlThQ2knqk=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(83380400001)(31686004)(6862004)(53546011)(5660300002)(956004)(36756003)(316002)(66946007)(2616005)(8676002)(86362001)(31696002)(2906002)(54906003)(37006003)(6486002)(8936002)(38100700002)(508600001)(6636002)(66476007)(186003)(66556008)(16576012)(26005)(4326008)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?MHltWE45STJkZS92aHEyc3BkYnNBMG5ySmh1RUNvOFY1ZHdueUpIQXpHckIz?=
 =?utf-8?B?Q2xHZG4wQWkvUnJQVXRrQU8wUG8xYUZPYWxmUml5aXFybkErWFhtQ0tXb3la?=
 =?utf-8?B?Rk1hOXI4MUg3eFY3VFN4dGhlaUxFeVEvU25aNkJKLzhJSmdPbkk0UFN0TjlR?=
 =?utf-8?B?cVE5S01jRklVTFVuU1J1VXlNK0ZwOE9TUmI3YmhyTkZRK2txQlRNbkI4ZGVm?=
 =?utf-8?B?L0N0NC9oK0xQdGhoM1k2aUxxNVlTZDQ5OHNLb0NUUVRtbi93K1lSRnQxY01R?=
 =?utf-8?B?Q3pURWczWDRQNXAzVzh6NUxBL2hFMGFyQVIzeUcvdlI1TnI4eVlvbGdaYW16?=
 =?utf-8?B?YVp5djhjUFd6Z2d1dU80cmF1TUxaNHR4bGx4bUo3djN6L05nb2NyQnhoZll0?=
 =?utf-8?B?b0VvRTk4Q1VySGRuNjFweW1nZnU1dG5EVWdoYzlDaXE2RXhVVk5nUURoOGZP?=
 =?utf-8?B?WUlCSE9EVHpuSVk0QW5zZ3E3VmRZZUwwNDBrb3c1UGQ3NjRXQ0tXcVY3eDRB?=
 =?utf-8?B?TUF6WVhRbnhldVdFSjRvUmZBbTFDeFdGQm9HRnBPdE1YTDRxbUpnRzVzY1Bo?=
 =?utf-8?B?TTdXRUxpWU0xTSswdDVCOWhnenYxeGpkcE1HU0k4SzRPdTBUcmErSDM0NXIz?=
 =?utf-8?B?cHlRbjAvMXc0YksxRmNPbHNWOEI4aXFLUHhUMy9LUGxjSm1aMUJTMXhmZHBa?=
 =?utf-8?B?ZHd2RU9JNTI5TTR2U0EveU9zandJNkJpZFlSZmErblRnd0gyTWNFRFZLSDRM?=
 =?utf-8?B?Z3ZYekN4endhRTNseGdic093WGVwaGg1bFYxN2I4QkErNm8yZ09ZNGNzTjhZ?=
 =?utf-8?B?YmRLbjRVdURsYjJua0lVcEJDRWI3TldJWW9uaGswT1hQQU95M1IwdTZvUzVp?=
 =?utf-8?B?Z3B4ZllweTZscXV4UGZVZkEwUFE3MGdRckhES3VJc2JtaHEvelZsYU85aUtC?=
 =?utf-8?B?TTBLVjJZeThQWXpVbWJINlZIWlIrR1lNaVJMZWFJK0M2cDVYNThyN2syUm5u?=
 =?utf-8?B?K2RXNXh4cjBaaG16aURLb2ttcit2WncyQXAyT3NqbXBIQTJBWWpHTExEemlv?=
 =?utf-8?B?VGNONjAxZWRTWlZZenN1YXVhMGNValZSSmZlSFp1MVdBQjNsaXdCN3R4L0k3?=
 =?utf-8?B?QzZFaFBqMDE5QXhJSTNlY2pXaDB4SWVUTkdPeG5ZVmJUOCtHL3NzNjNaZnhu?=
 =?utf-8?B?SnNlanphYWh4RVNNemQvaE1ZSTNsNnZLQnVaaHN5cXkzUitwM3FnWjVXUzVv?=
 =?utf-8?B?bUVZQzlKTTF6ajY5TzRacS9ZMFlUZWFvb3dLbXI4aWxhczBIamJTNS9jRW1Q?=
 =?utf-8?B?TE9ST1NrbTJkeHJkNmVTRG9TQWhhMWJLUWdnMVp5YnN3NHpaNXViRU9SRUhw?=
 =?utf-8?B?NjlWMHFzS0FMaGRONTFKUklrczVjUWZVVnovak5rTFpiWGpwWmFtb01scHRK?=
 =?utf-8?B?a3hBMTJMaE5MVThHRmhPZnltb09FaEFQSGE1KzNNYWx5SFUwUitmczJhcGVW?=
 =?utf-8?B?d003L3JSY0RUR0UzSDZDcVFqMklkKzN2S0NJelhDNHBEUnc3TXdXdWp3MzV6?=
 =?utf-8?B?UE4ySm9VZmo0Z04rNlZtQ3M3QjhiS0h5d2hxUnphME52OTlFdW83ckxPUDUx?=
 =?utf-8?B?TytTRjZEN1VPQ0ZMd0lWVDJ3TkVlYkRBVGtFb3Q1MFpGd1pjZnE1Y25mSWRa?=
 =?utf-8?B?cEVTQlpqbmF4emVmdVJKaEM5cFdrSkFwNm9HWFI4UVo4ZEVTMFVQZ3ZsVkZH?=
 =?utf-8?Q?4smKbS9+qypUJQZtQEt8Ca7A/RI0KBdkW8RflL6?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 049d6b6c-573d-4c63-7b4d-08d994a0ddc8
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Oct 2021 14:41:28.7716
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jbeulich@suse.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB2701

On 15.10.2021 14:51, Juergen Gross wrote:
> Instead of using a function table use the generated switch statement
> macros for calling the appropriate hypercall handlers.
> 
> This is beneficial to performance and avoids speculation issues.
> 
> With calling the handlers using the correct number of parameters now
> it is possible to do the parameter register clobbering in the NDEBUG
> case after returning from the handler. This in turn removes the only
> users of hypercall_args_table[] which can be removed now.

"removed" reads misleading to me: You really replace it by new tables,
using script-generated initializers. Also it looks like you're doubling
the data, as the same sets were previously used by pv64/hvm64 and
pv32/hvm32 respectively.

> --- a/xen/arch/x86/hvm/hypercall.c
> +++ b/xen/arch/x86/hvm/hypercall.c
> @@ -108,56 +108,10 @@ long hvm_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
>          return compat_physdev_op(cmd, arg);
>  }
>  
> -#define HYPERCALL(x)                                         \
> -    [ __HYPERVISOR_ ## x ] = { (hypercall_fn_t *) do_ ## x,  \
> -                               (hypercall_fn_t *) do_ ## x }
> -
> -#define HVM_CALL(x)                                          \
> -    [ __HYPERVISOR_ ## x ] = { (hypercall_fn_t *) hvm_ ## x, \
> -                               (hypercall_fn_t *) hvm_ ## x }
> -
> -#define COMPAT_CALL(x)                                       \
> -    [ __HYPERVISOR_ ## x ] = { (hypercall_fn_t *) do_ ## x,  \
> -                               (hypercall_fn_t *) compat_ ## x }
> -
> -static const struct {
> -    hypercall_fn_t *native, *compat;
> -} hvm_hypercall_table[] = {
> -    HVM_CALL(memory_op),
> -    COMPAT_CALL(multicall),
> -#ifdef CONFIG_GRANT_TABLE
> -    HVM_CALL(grant_table_op),
> -#endif
> -    HYPERCALL(vm_assist),
> -    COMPAT_CALL(vcpu_op),
> -    HVM_CALL(physdev_op),
> -    COMPAT_CALL(xen_version),
> -    HYPERCALL(console_io),
> -    HYPERCALL(event_channel_op),
> -    COMPAT_CALL(sched_op),
> -    COMPAT_CALL(set_timer_op),
> -    COMPAT_CALL(xsm_op),
> -    HYPERCALL(hvm_op),
> -    HYPERCALL(sysctl),
> -    HYPERCALL(domctl),
> -#ifdef CONFIG_ARGO
> -    COMPAT_CALL(argo_op),
> -#endif
> -    COMPAT_CALL(platform_op),
> -#ifdef CONFIG_PV
> -    COMPAT_CALL(mmuext_op),
> -#endif
> -    HYPERCALL(xenpmu_op),
> -    COMPAT_CALL(dm_op),
> -#ifdef CONFIG_HYPFS
> -    HYPERCALL(hypfs_op),
> +#ifndef NDEBUG
> +static unsigned char hypercall_args_64[] = hypercall_args_hvm64;
> +static unsigned char hypercall_args_32[] = hypercall_args_hvm32;

Irrespective of this being debugging-only: Const?

> @@ -239,33 +176,11 @@ int hvm_hypercall(struct cpu_user_regs *regs)
>          HVM_DBG_LOG(DBG_LEVEL_HCALL, "hcall%lu(%lx, %lx, %lx, %lx, %lx)",
>                      eax, rdi, rsi, rdx, r10, r8);
>  
> -#ifndef NDEBUG
> -        /* Deliberately corrupt parameter regs not used by this hypercall. */
> -        switch ( hypercall_args_table[eax].native )
> -        {
> -        case 0: rdi = 0xdeadbeefdeadf00dUL; fallthrough;
> -        case 1: rsi = 0xdeadbeefdeadf00dUL; fallthrough;
> -        case 2: rdx = 0xdeadbeefdeadf00dUL; fallthrough;
> -        case 3: r10 = 0xdeadbeefdeadf00dUL; fallthrough;
> -        case 4: r8 = 0xdeadbeefdeadf00dUL;
> -        }
> -#endif
> -
> -        regs->rax = hvm_hypercall_table[eax].native(rdi, rsi, rdx, r10, r8);
> +        call_handlers_hvm64(eax, regs->rax, rdi, rsi, rdx, r10, r8);
>  
>  #ifndef NDEBUG
> -        if ( !curr->hcall_preempted )
> -        {
> -            /* Deliberately corrupt parameter regs used by this hypercall. */
> -            switch ( hypercall_args_table[eax].native )
> -            {
> -            case 5: regs->r8  = 0xdeadbeefdeadf00dUL; fallthrough;
> -            case 4: regs->r10 = 0xdeadbeefdeadf00dUL; fallthrough;
> -            case 3: regs->rdx = 0xdeadbeefdeadf00dUL; fallthrough;
> -            case 2: regs->rsi = 0xdeadbeefdeadf00dUL; fallthrough;
> -            case 1: regs->rdi = 0xdeadbeefdeadf00dUL;
> -            }
> -        }
> +        if ( !curr->hcall_preempted && regs->rax != -ENOSYS )
> +            clobber_regs(regs, hypercall_args_64[eax]);

I'm not fundamentally opposed, but sadly -ENOSYS comes back also in undue
situations, e.g. various hypercalls still produce this for "unknown
sub-function". Hence the weakened clobbering wants at least mentioning,
perhaps also justifying, in the description.

> @@ -55,4 +42,34 @@ compat_common_vcpu_op(
>  
>  #endif /* CONFIG_COMPAT */
>  
> +#ifndef NDEBUG

Hmm, I was actuall hoping for the conditional to actually live ...

> +static inline void clobber_regs(struct cpu_user_regs *regs,
> +                                unsigned int nargs)
> +{

... here and ...

> +    /* Deliberately corrupt used parameter regs. */
> +    switch ( nargs )
> +    {
> +    case 5: regs->r8  = 0xdeadbeefdeadf00dUL; fallthrough;
> +    case 4: regs->r10 = 0xdeadbeefdeadf00dUL; fallthrough;
> +    case 3: regs->rdx = 0xdeadbeefdeadf00dUL; fallthrough;
> +    case 2: regs->rsi = 0xdeadbeefdeadf00dUL; fallthrough;
> +    case 1: regs->rdi = 0xdeadbeefdeadf00dUL;
> +    }
> +}
> +
> +static inline void clobber_regs32(struct cpu_user_regs *regs,
> +                                  unsigned int nargs)
> +{

... here, such that the conditionals in the .c files could go away
altogether.

> +    /* Deliberately corrupt used parameter regs. */
> +    switch ( nargs )
> +    {
> +    case 5: regs->edi = 0xdeadf00dUL; fallthrough;
> +    case 4: regs->esi = 0xdeadf00dUL; fallthrough;
> +    case 3: regs->edx = 0xdeadf00dUL; fallthrough;
> +    case 2: regs->ecx = 0xdeadf00dUL; fallthrough;
> +    case 1: regs->ebx = 0xdeadf00dUL;

No need for the UL suffixes here afaics; U ones may want to be there.

Overall, besides these mainly cosmetic aspects the main thing missing
is an approach to prioritize the handful most frequently used functions,
for them to be pulled out of the switch() so we don't depend on the
compiler's choice for the order of comparisons done.

Jan



From xen-devel-bounces@lists.xenproject.org Thu Oct 21 14:48:33 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Oct 2021 14:48:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.214490.373049 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdZMr-0006Sy-6l; Thu, 21 Oct 2021 14:48:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 214490.373049; Thu, 21 Oct 2021 14:48:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdZMr-0006Sr-3g; Thu, 21 Oct 2021 14:48:29 +0000
Received: by outflank-mailman (input) for mailman id 214490;
 Thu, 21 Oct 2021 14:48:27 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=qg64=PJ=redhat.com=armbru@srs-us1.protection.inumbo.net>)
 id 1mdZMo-0006SS-Ta
 for xen-devel@lists.xenproject.org; Thu, 21 Oct 2021 14:48:27 +0000
Received: from us-smtp-delivery-124.mimecast.com (unknown [216.205.24.124])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTP
 id 5c3d6aee-8f38-47a2-a514-991d76eaa6d2;
 Thu, 21 Oct 2021 14:48:25 +0000 (UTC)
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-175-jvXwudw-Msaou25Jd4dojA-1; Thu, 21 Oct 2021 10:48:23 -0400
Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com
 [10.5.11.16])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 04942809CD6;
 Thu, 21 Oct 2021 14:48:18 +0000 (UTC)
Received: from blackfin.pond.sub.org (ovpn-112-7.ams2.redhat.com [10.36.112.7])
 by smtp.corp.redhat.com (Postfix) with ESMTPS id 00801794DA;
 Thu, 21 Oct 2021 14:47:44 +0000 (UTC)
Received: by blackfin.pond.sub.org (Postfix, from userid 1000)
 id 7FC7211380A7; Thu, 21 Oct 2021 16:47:43 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5c3d6aee-8f38-47a2-a514-991d76eaa6d2
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1634827705;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=/30n6FzWouTq3vTyM7a5C1u2jGShyBvKIXk03n/PnVU=;
	b=KmeChHOodXo122vX2fQXuOQ13meiXM6KQNLt/2/2J7q/uauJuAmNu2d7tLyVpBf4FxVK57
	5/scYhgcXgj3wz5iaQ9jhbWe1Bhwog7HGLgcuT7+OFc5XOm+oJPazqRcf7v7aXjXRSGoXP
	vna255zfzsBpCrNqV3hUa5snYt9/8kE=
X-MC-Unique: jvXwudw-Msaou25Jd4dojA-1
From: Markus Armbruster <armbru@redhat.com>
To: Daniel P. =?utf-8?Q?Berrang=C3=A9?= <berrange@redhat.com>
Cc: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= <philmd@redhat.com>,
  qemu-devel@nongnu.org,
  Thomas Huth <thuth@redhat.com>,  Prasad J Pandit <pjp@fedoraproject.org>,
  "Michael S. Tsirkin" <mst@redhat.com>,  Paolo Bonzini
 <pbonzini@redhat.com>,  Eduardo Habkost <ehabkost@redhat.com>,  Philippe
 =?utf-8?Q?Mathieu-Daud=C3=A9?= <f4bug@amsat.org>,  Eric Blake
 <eblake@redhat.com>,  Richard
 Henderson <richard.henderson@linaro.org>,  qemu-block@nongnu.org,  Peter
 Maydell <peter.maydell@linaro.org>,  xen-devel@lists.xenproject.org
Subject: Re: [RFC PATCH 02/10] accel: Use qemu_security_policy_taint(), mark
 KVM and Xen as safe
References: <20210908232024.2399215-1-philmd@redhat.com>
	<20210908232024.2399215-3-philmd@redhat.com>
	<YTnj2M+lygKzdsgO@redhat.com>
Date: Thu, 21 Oct 2021 16:47:43 +0200
In-Reply-To: <YTnj2M+lygKzdsgO@redhat.com> ("Daniel P. =?utf-8?Q?Berrang?=
 =?utf-8?Q?=C3=A9=22's?= message of
	"Thu, 9 Sep 2021 11:37:12 +0100")
Message-ID: <87k0i6a0z4.fsf@dusky.pond.sub.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
MIME-Version: 1.0
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=armbru@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

It's been a while...

Daniel P. Berrang=C3=A9 <berrange@redhat.com> writes:

> On Thu, Sep 09, 2021 at 01:20:16AM +0200, Philippe Mathieu-Daud=C3=A9 wro=
te:
>> Add the AccelClass::secure_policy_supported field to classify
>> safe (within security boundary) vs unsafe accelerators.
>>=20
>> Signed-off-by: Philippe Mathieu-Daud=C3=A9 <philmd@redhat.com>
>> ---
>>  include/qemu/accel.h | 5 +++++
>>  accel/kvm/kvm-all.c  | 1 +
>>  accel/xen/xen-all.c  | 1 +
>>  softmmu/vl.c         | 3 +++
>>  4 files changed, 10 insertions(+)
>>=20
>> diff --git a/include/qemu/accel.h b/include/qemu/accel.h
>> index 4f4c283f6fc..895e30be0de 100644
>> --- a/include/qemu/accel.h
>> +++ b/include/qemu/accel.h
>> @@ -44,6 +44,11 @@ typedef struct AccelClass {
>>                         hwaddr start_addr, hwaddr size);
>>  #endif
>>      bool *allowed;
>> +    /*
>> +     * Whether the accelerator is withing QEMU security policy boundary=
.
>> +     * See: https://www.qemu.org/contribute/security-process/
>> +     */
>> +    bool secure_policy_supported;
>
> The security handling policy is a high level concept that is
> open to variation over time and also by downstream distro
> vendors.

Moreover, the concept of "tainting" isn't limited to "because
security".

> At a code level we should be dealing in a more fundamental
> concept. At an accelerator level we should really jsut
> declare whether or not the accelerator impl is considered
> to be secure against malicious guest code.
>
> eg
>
>     /* Whether this accelerator is secure against execution
>      * of malciious guest machine code */
>     bool secure;

What I'd like to see is a separation of "assertions", like "not meant to
serve as security boundary", and policy.  Yes, this is vague.  Take it
as food for thought.

>>      /*
>>       * Array of global properties that would be applied when specific
>>       * accelerator is chosen. It works like MachineClass.compat_props
>> diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c
>> index 0125c17edb8..eb6b9e44df2 100644
>> --- a/accel/kvm/kvm-all.c
>> +++ b/accel/kvm/kvm-all.c
>> @@ -3623,6 +3623,7 @@ static void kvm_accel_class_init(ObjectClass *oc, =
void *data)
>>      ac->init_machine =3D kvm_init;
>>      ac->has_memory =3D kvm_accel_has_memory;
>>      ac->allowed =3D &kvm_allowed;
>> +    ac->secure_policy_supported =3D true;
>> =20
>>      object_class_property_add(oc, "kernel-irqchip", "on|off|split",
>>          NULL, kvm_set_kernel_irqchip,
>> diff --git a/accel/xen/xen-all.c b/accel/xen/xen-all.c
>> index 69aa7d018b2..57867af5faf 100644
>> --- a/accel/xen/xen-all.c
>> +++ b/accel/xen/xen-all.c
>> @@ -198,6 +198,7 @@ static void xen_accel_class_init(ObjectClass *oc, vo=
id *data)
>>      ac->setup_post =3D xen_setup_post;
>>      ac->allowed =3D &xen_allowed;
>>      ac->compat_props =3D g_ptr_array_new();
>> +    ac->secure_policy_supported =3D true;
>> =20
>>      compat_props_add(ac->compat_props, compat, G_N_ELEMENTS(compat));
>> =20
>> diff --git a/softmmu/vl.c b/softmmu/vl.c
>> index 92c05ac97ee..e4f94e159c3 100644
>> --- a/softmmu/vl.c
>> +++ b/softmmu/vl.c
>> @@ -2388,6 +2388,9 @@ static int do_configure_accelerator(void *opaque, =
QemuOpts *opts, Error **errp)
>>          return 0;
>>      }
>> =20
>> +    qemu_security_policy_taint(!ac->secure_policy_supported,
>> +                               "%s accelerator", acc);
>
> We need this information to be introspectable, becuase stuff printed
> to stderr is essentially opaque to libvirt and mgmt apps above.
>
> We don't have a convenient "query-accel" command but I think this
> could possibly fit into 'query-target'. ie the TargetInfo struct
> gain a field:
> =20
>
>   ##
>   # @TargetInfo:
>   #
>   # Information describing the QEMU target.
>   #
>   # @arch: the target architecture
>   # @secure: Whether the currently active accelerator for this target
>   #          is secure against execution of malicous guest code
>   #
>   # Since: 1.2
>   ##
>   { 'struct': 'TargetInfo',
>     'data': { 'arch': 'SysEmuTarget',
>               'secure': 'bool'} }

My preferred means of introspection is QAPI schema introspection.  For
QMP, that's query-qmp-schema.  For CLI, it doesn't exist, yet.

If it did, then it would tell us that (QAPIfied) -accel takes an
argument @accel of a certain enumeration type.  We could then tack
suitable feature flags to the enumeration type's values.

If we make the feature flags "special", i.e. known to QAPI, we can then
tie them to policy, like special feature flag 'deprecated' is tied to
policy configured with -compat deprecated-{input,output}=3D...

Alternatively, leave policy to the management application.

QAPI schema feature flags plus policy are is not a *complete* solution,
just like feature flag 'deprecated' and -compat are not a complete
solution for handling use of deprecated interfaces: we can and do
deprecate usage that isn't tied to a syntactic element in the QAPI
schema.  Example: commit a9b305ba291 deprecated use of socket chardev
option wait together with server=3Dtrue.

It is, however, a solution for a sizable part of the problem with useful
properties:

* In QEMU, the code is generic (handling of feature flags, policy), and
  the non-generic stuff is declarative (feature flags in the QAPI
  schema).

* No new introspection mechanism: feature flags already exist in QAPI
  schema introspection.



From xen-devel-bounces@lists.xenproject.org Thu Oct 21 15:01:21 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Oct 2021 15:01:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.214500.373059 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdZZB-0000GY-B8; Thu, 21 Oct 2021 15:01:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 214500.373059; Thu, 21 Oct 2021 15:01:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdZZB-0000GR-7p; Thu, 21 Oct 2021 15:01:13 +0000
Received: by outflank-mailman (input) for mailman id 214500;
 Thu, 21 Oct 2021 15:01:11 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=cxSi=PJ=kernel.dk=axboe@srs-us1.protection.inumbo.net>)
 id 1mdZZ9-0000GG-7H
 for xen-devel@lists.xenproject.org; Thu, 21 Oct 2021 15:01:11 +0000
Received: from mail-oi1-x236.google.com (unknown [2607:f8b0:4864:20::236])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 4dbb49ae-4826-4ba6-89e4-527b0ed5c747;
 Thu, 21 Oct 2021 15:01:09 +0000 (UTC)
Received: by mail-oi1-x236.google.com with SMTP id q129so1252250oib.0
 for <xen-devel@lists.xenproject.org>; Thu, 21 Oct 2021 08:01:09 -0700 (PDT)
Received: from [127.0.1.1] ([2600:380:783a:c43c:af64:c142:4db7:63ac])
 by smtp.gmail.com with ESMTPSA id w18sm1173833ott.29.2021.10.21.08.01.06
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Thu, 21 Oct 2021 08:01:08 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4dbb49ae-4826-4ba6-89e4-527b0ed5c747
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=kernel-dk.20210112.gappssmtp.com; s=20210112;
        h=from:to:cc:in-reply-to:references:subject:message-id:date
         :mime-version:content-transfer-encoding;
        bh=6jnVZbBkLbnw6pFZpxUldRg4FuFfEZElhVVQao3Uy20=;
        b=ZGFMo833ta2HUfgqVLXUNHJV5pTUNb23BosrQDRrArzz1VYW1rZvujqd1q9AvwL/2L
         I3qasTS/LaOX+rTG38fA1WkYeozE1AIG6Y1LWW3KJy++pLKzaue+ysn5BR5qqBazSL3X
         IVR4Fjt0Mg/h6j4Zo8LPwJHvk9rRXi+EODiN4CZjW0a3nWKAwsxdaWUyN0Iinpv2NO0m
         dB+Q+OGRW5ZAtyv3ynB4fi22vLxF+kmJ+bRRxyM9NM8BrnQaDlNccb6EwaqBPSB/5dXE
         w0UzuwJbGrVM1iqd9niPDqAPfBdtIGPYSTrtcyZITTG5mzlvKTmg+/w7FrEp4Vj/y3G+
         Cdig==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:in-reply-to:references:subject
         :message-id:date:mime-version:content-transfer-encoding;
        bh=6jnVZbBkLbnw6pFZpxUldRg4FuFfEZElhVVQao3Uy20=;
        b=ziWhwHY6RFI3mREjYJlD/yHMyArCbVWSihnrfDrlu4OwTN4wkXOXTHFr6r4cZFGm2g
         FMIl3zsNqGowJW3WNIXq3dJZf5RrbipZOlVWSAeY1ijMFRv7/i5CtcSPZ9h/xvCe9VrZ
         78kYTRFAf+BDAdCIU+5TMpOH0QgNTQ7glcUcj1hWJpGVpVTdKUisxAd9tg85BASgD+Kq
         2tGtEyFIHWYeLaO8BaFQ/OTeQVdpGIR1BvgRscr4n/rRA5dDt7NK847TXbrlhtfHKTh7
         TZjPOFNbSEIB9fZ4e8jVTk83JsEqW1slBnQ8+goH2yRBoY1pOo4XjwRFO1mzO1RBsWYz
         1o9w==
X-Gm-Message-State: AOAM533G1pWQm582Ab4umB5a0ok+f8LQ5xIkGBQT/v7Fyh1dKBJvhTsL
	wHiKe6i51dl92HfitvFg9FsGKw==
X-Google-Smtp-Source: ABdhPJxcqYzZpw8hjWvx8wtyMAFaG+Ip962yojdp/B4kEz2Pn9lx52Qn4eX8lgw7zW26Sgpyf8s+nQ==
X-Received: by 2002:a05:6808:3c9:: with SMTP id o9mr4905862oie.20.1634828468846;
        Thu, 21 Oct 2021 08:01:08 -0700 (PDT)
From: Jens Axboe <axboe@kernel.dk>
To: thehajime@gmail.com, zhuyifei1999@gmail.com, haris.iqbal@ionos.com, johannes.berg@intel.com, roger.pau@citrix.com, miquel.raynal@bootlin.com, jdike@addtoit.com, anton.ivanov@cambridgegreys.com, geert@linux-m68k.org, krisman@collabora.com, vigneshr@ti.com, richard@nod.at, hare@suse.de, jinpu.wang@ionos.com, jgross@suse.com, sstabellini@kernel.org, ulf.hansson@linaro.org, agk@redhat.com, linux-mtd@lists.infradead.org, Luis Chamberlain <mcgrof@kernel.org>, tj@kernel.org, colyli@suse.de, jejb@linux.ibm.com, chris.obbard@collabora.com, snitzer@redhat.com, boris.ostrovsky@oracle.com, kent.overstreet@gmail.com, martin.petersen@oracle.com
Cc: linux-block@vger.kernel.org, dm-devel@redhat.com, xen-devel@lists.xenproject.org, linux-um@lists.infradead.org, linux-bcache@vger.kernel.org, linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-scsi@vger.kernel.org
In-Reply-To: <20211015233028.2167651-1-mcgrof@kernel.org>
References: <20211015233028.2167651-1-mcgrof@kernel.org>
Subject: Re: (subset) [PATCH 0/9] block: reviewed add_disk() error handling set
Message-Id: <163482846658.50565.12530170761457767964.b4-ty@kernel.dk>
Date: Thu, 21 Oct 2021 09:01:06 -0600
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

On Fri, 15 Oct 2021 16:30:19 -0700, Luis Chamberlain wrote:
> Jens,
> 
> I had last split up patches into 7 groups, but at this point now
> most changes are merged except a few more drivers. Instead of creating
> a new patch set for each of the 7 groups I'm creating 3 new groups of
> patches now:
> 
> [...]

Applied, thanks!

[3/9] dm: add add_disk() error handling
      commit: e7089f65dd51afeda5eb760506b5950d95f9ec29
[4/9] bcache: add error handling support for add_disk()
      commit: 2961c3bbcaec0ed7fb7b9a465b3796f37f2294e5
[5/9] xen-blkfront: add error handling support for add_disk()
      commit: 293a7c528803321479593d42d0898bb5a9769db1
[6/9] m68k/emu/nfblock: add error handling support for add_disk()
      commit: 21fd880d3da7564bab68979417cab7408e4f9642
[7/9] um/drivers/ubd_kern: add error handling support for add_disk()
      commit: 66638f163a2b5c5b462ca38525129b14a20117eb
[8/9] rnbd: add error handling support for add_disk()
      commit: 2e9e31bea01997450397d64da43b6675e0adb9e3
[9/9] mtd: add add_disk() error handling
      commit: 83b863f4a3f0de4ece7802d9121fed0c3e64145f

Best regards,
-- 
Jens Axboe




From xen-devel-bounces@lists.xenproject.org Thu Oct 21 15:14:25 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Oct 2021 15:14:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.214509.373071 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdZlr-0001nU-MX; Thu, 21 Oct 2021 15:14:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 214509.373071; Thu, 21 Oct 2021 15:14:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdZlr-0001nN-J8; Thu, 21 Oct 2021 15:14:19 +0000
Received: by outflank-mailman (input) for mailman id 214509;
 Thu, 21 Oct 2021 15:14:18 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mdZlq-0001nH-KX
 for xen-devel@lists.xenproject.org; Thu, 21 Oct 2021 15:14:18 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mdZlq-0003Cm-8P; Thu, 21 Oct 2021 15:14:18 +0000
Received: from [54.239.6.190] (helo=[192.168.27.91])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mdZlq-0003Kb-2B; Thu, 21 Oct 2021 15:14:18 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=izwEQwZPWo8duvHKCcWKdhhPBmkNKAIUuaDS8yf+JUI=; b=ex2Cmvd6onCiivbfJHNS65JiTJ
	sPyY58lsYAxLXGPRm4/VwVkGijH2I70d/byrfZ5m5Wcc/mVx/0+qdTGNZy1x0vCMol2dC75g1tkR5
	WCi7nW9n1SawWzHZQt3nOuCDiU1/BKEMAFs1eFIgi5SJBE7rWNT+5iSqDqHV+ry3GDoM=;
Message-ID: <e7804793-82a4-b2ac-0146-fe5bbed2bfbf@xen.org>
Date: Thu, 21 Oct 2021 16:14:15 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.2.0
Subject: [for-4.16] Re: [PATCH v4] xen/arm: vgic: Ignore write access to
 ICPENDR*
To: Hongda Deng <Hongda.Deng@arm.com>, xen-devel@lists.xenproject.org,
 sstabellini@kernel.org
Cc: Bertrand.Marquis@arm.com, Wei.Chen@arm.com,
 Ian Jackson <iwj@xenproject.org>
References: <20211021120319.2394-1-Hongda.Deng@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20211021120319.2394-1-Hongda.Deng@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hello Hongda,

On the previous version, we discussed to include the patch for 4.16. So 
please tag it with for-4.16 and CC the Release Manager (Ian). This will 
help him to track what's outstanding for the release.

On 21/10/2021 13:03, Hongda Deng wrote:
> Currently, Xen will return IO unhandled when guests write ICPENDR*
> virtual registers, which will raise a data abort inside the guest.
> For Linux guest, these virtual registers will not be accessed. But
> for Zephyr, these virtual registers will be accessed during the
> initialization. Zephyr guest will get an IO data abort and crash.
> Emulating ICPENDR is not easy with the existing vGIC, this patch
> reworks the emulation to ignore write access to ICPENDR* virtual
> registers and print a message about whether they are already pending
> instead of returning unhandled.
> More details can be found at [1].
> 
> [1] https://github.com/zephyrproject-rtos/zephyr/blob/eaf6cf745df3807e6e
> cc941c3a30de6c179ae359/drivers/interrupt_controller/intc_gicv3.c#L274
> 
> Signed-off-by: Hongda Deng <hongda.deng@arm.com>

While I agree the Reviewed-by from Bertrand should be dropped, the 
Release-acked-by from Ian is simply a way to say he is happy to include 
the patch for 4.16. So this should have been retain.

The patch looks good to me, so I can add Ian's tag on commit:

Reviewed-by: Julien Grall <jgrall@amazon.com>

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Thu Oct 21 15:20:02 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Oct 2021 15:20:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.214518.373081 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdZrB-0002TE-Bg; Thu, 21 Oct 2021 15:19:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 214518.373081; Thu, 21 Oct 2021 15:19:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdZrB-0002T7-8Z; Thu, 21 Oct 2021 15:19:49 +0000
Received: by outflank-mailman (input) for mailman id 214518;
 Thu, 21 Oct 2021 15:19:48 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=FF+c=PJ=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mdZrA-0002T1-BN
 for xen-devel@lists.xenproject.org; Thu, 21 Oct 2021 15:19:48 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 530884d3-3282-11ec-8380-12813bfff9fa;
 Thu, 21 Oct 2021 15:19:47 +0000 (UTC)
Received: from EUR03-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur03lp2050.outbound.protection.outlook.com [104.47.8.50]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-33-yNRwO1UJPOOvU8EqdHJiUw-1; Thu, 21 Oct 2021 17:19:45 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB4381.eurprd04.prod.outlook.com (2603:10a6:803:6d::30)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16; Thu, 21 Oct
 2021 15:19:44 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::8062:d7cb:ca45:1898]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::8062:d7cb:ca45:1898%3]) with mapi id 15.20.4628.018; Thu, 21 Oct 2021
 15:19:43 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6PR08CA0018.eurprd08.prod.outlook.com (2603:10a6:20b:b2::30) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4628.16 via Frontend Transport; Thu, 21 Oct 2021 15:19:43 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 530884d3-3282-11ec-8380-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634829586;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=+6x5VW58fARZKv4rS4QMHhIKpTUVzW56T5bidJfnKBw=;
	b=IymwEAyIshgwSiYVKICQ/E4sulEDJzdtmkJKhgXZfyImhxTFKNHE2RLOXnyKKe26XKc4f8
	R+mePbYOVyC8g0/3VVBfbGR5tI1fkbp820DVpQdxYgzWyeo+inQYbR8ig9QgY1e3WHntGP
	tpj3D2M2kOHQlL0XXW9EwtHinhx+TQA=
X-MC-Unique: yNRwO1UJPOOvU8EqdHJiUw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=CLM8BaiU1wZcIR6VuNg6j/5jKqllf161yOaioZ1obIzj+kXy9UuVo0DDlv+8itUBJ8A0Zw84OUX/2uz2VdIYsAgJsjd0u+hMFbzMey/bEU8uZKGEk0wXQIE5XmjZdwlx68i16ays04UDIqapxYKMVbr/wJNto9H/bWgsx7SaiPqyfkR/iCH38lkwqlTNlXuTupNen1a3WoBJM+c9bxXayt+8mBu2teTKzNWjnlUL693nu5RoD+k2+d9s9xqzVi+vPtze4iW7Gfn8F1zGEkI+tZOwUqoBDhnWwO1QtWzIzgaaN4cpg8ea14zOpWFxeDdaktdqHMvzaPa/QnhTD+7x0w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=+6x5VW58fARZKv4rS4QMHhIKpTUVzW56T5bidJfnKBw=;
 b=hr7aqMZwajnsXrvN0da767NtFHzXyPAIw3RxYFOsqgXF5Jzcu1vQo6OzluzqAm6aUp8DpGLsgyHX0a3W+AxDR9rJh1SnmoMIPE0bUm+tMHLx3tE0zCuOb+qfPvKZd8scHkwhegvWGGnHut+zEPb/22D/+hWpNVIUBsMqEmTb8SWgovOCIjKpRg9XRJl3Em5kkARmldQmvCrgrHbn3vvcvqwOt9rrpzmowWitYUntIiEsBhcBjcJ8LX1zjchWKjXea3FrDOYpQLfBAA7Rw0GdgjbjCM0Q7hAkLcEUc6mZAvT1+FakijyitZmcuRZyc3l7aEzE+4N3lOMSshQwgKyrKQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [PATCH 12/12] xen/x86: add hypercall performance counters for
 hvm, correct pv
To: Juergen Gross <jgross@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>, Wei Liu
 <wl@xen.org>, xen-devel@lists.xenproject.org
References: <20211015125152.25198-1-jgross@suse.com>
 <20211015125152.25198-13-jgross@suse.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <6570b0b9-0cde-a262-937c-b4e2e3f8e1e4@suse.com>
Date: Thu, 21 Oct 2021 17:19:41 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <20211015125152.25198-13-jgross@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR08CA0018.eurprd08.prod.outlook.com
 (2603:10a6:20b:b2::30) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 25bbde04-0a55-49f2-edc4-08d994a635c3
X-MS-TrafficTypeDiagnostic: VI1PR04MB4381:
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB4381D611A3750524C4E0366DB3BF9@VI1PR04MB4381.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	0HiwwDRq0oXqXS+pQ26JsMHEX8+CrMF2gq7nI5ePzujBwB2oqEPI6Deab1hhHMcmIAQQzfifG/2xnY9ceLuVow7mv6y8PNmUWV6aJznQw57+AYu0AFPIqYMUlJMbOANzWXHP9yh8eEM7iRS/zT5QQx/vKXV8p1H7tWJ4JLK7fiUXcpfeUaXfWNtU5hgv+p+nP4q2EryIegiPtKuwk1sbRzBHTsVvP6mdcMUqor6nKFW30GIrp6bDGU5+vgpRs0ypfPywJ+bfNqvtJGQlOMdO5opLjMFgzHo0Yqat1wVs0cjpYmcDMF41QsBgOmRgRm/Ko3wiOId/AnL9MmAfzsobbevP0sAbePCw/sdwP4iKiSsB2bH9T97vkOfmAQ60E0AVAg5FxjyrhgCGgZfnWPUVzFn0RXJDZFNzvUWVt3lLAiTjd62Oa/NcephoGP5jXhV92DaBOylRqtkHiS1/Ro0L0CsIaza/cf5BT0JSVzNnEgOJzICtD7BjX1eJEB8e8xOPSlymzhgHf+xrDcBRTjVm3XACuo5PUxCxkesfiBi14N7b/YwSix2wqJV48HTuS1wEuV+tg+S7le+j+94rqOrddxJW6azPMQmPP7vqcXoC2klcJG440OlauSa8WjeWLLGb2xlo95DVJXKHKuRaQmwsih6g+VywZX8oNw8oeGXAxLpdoMk3v93pH5nz6jZQEB6neoidij/h6rIrYi/IBP/pFpfeSoRNbuQeLA3RKJNu1XU=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(26005)(316002)(5660300002)(2616005)(4326008)(38100700002)(31696002)(66946007)(83380400001)(31686004)(6486002)(37006003)(53546011)(86362001)(6636002)(36756003)(186003)(2906002)(16576012)(508600001)(6862004)(8676002)(956004)(8936002)(54906003)(66476007)(66556008)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?OWk2dlBMRzNvT0JKc2ZHUGJ5WldtM3Z0RWQ2V0g3ZGZmVmliMDFWa0QvVWZ2?=
 =?utf-8?B?L2ZWUWQrbGlHcnpVZDdUSVRZc2RwemlPenQxZ3VIU1Q5UzlpR0tRMEl5OFNY?=
 =?utf-8?B?Y1JnZTVMc1dRdGRld0ErN2tDZmhRZUU4aUxoelJobjZVNHpUUlJnUWtBQjhn?=
 =?utf-8?B?aTNKTnFDWnAxN3JMcFZWSktIWGp3L2FwOE5Qa1g2QmZjVTRja2ZpakFUaDRZ?=
 =?utf-8?B?Tko2ekFrd3JzcXIra0FIc1VlNFA1elFtT0xBTlYrSHJJZHJVK2xUMnZWc1B3?=
 =?utf-8?B?RFRHT0hzK3JrY2JlNnpGOUVkV3BwODFHQ21nSW0xMW8yWS9lcVZkQVAzamdt?=
 =?utf-8?B?ZlhOcC9JUjN3SFdnbit2UWs4bUpqMS92aWROSWZwRFhuYWlISll6NEptTUha?=
 =?utf-8?B?eW9SQmZWbzhGbVptRTlkT3FjNU54S2hpRVh2NkdjSGd2dXJ3WVlaS1FGMStM?=
 =?utf-8?B?TFhxWmdzeUx6SElJdko1WS9lZDZWSVVXV0pXK3dTQnFRcHJMUndRMTJkeEZt?=
 =?utf-8?B?WVBwU2R4MVA2MThsVURaaVVYTTljOGsvTStLSnNrb3phaUhpZUlXdnJHWlFR?=
 =?utf-8?B?a0FNSE5qRldZS3U3WERKOUJLWjZ4MVR6Y0kxcUNTL1F2UTlsUk9uMmRNdFVC?=
 =?utf-8?B?cUJ0RW9FNE9uNWRjaGJ4K1ErVnV1Y2xCVkVUZ3NYcWJOQ0xlbk52YVVGZXBY?=
 =?utf-8?B?SCtaaXpSWkh2SnZkVjYwdnl1U3RadDFkckJYdmk2ZjVRUjAxZzlKMXBremMy?=
 =?utf-8?B?SzV3QW9FZ2p1OXRYWGUrRzhGeGxXS3pJRDVDQU1OS05oRnovaUdnMEVSUzJQ?=
 =?utf-8?B?UHN1R2lIMmZyc3VBMlhsT29FUDl5eC9QbkN2Q202S3NYVnhJR1R6SE1CRGl1?=
 =?utf-8?B?a3pFTGJtQ2xxYXlmM2VnK1YvSnZiRHpLRHM4czB6bmtPTXU2ZlBMT1pmdzVX?=
 =?utf-8?B?VUR4dkhpczIrQ0I3NzJnZ21xUS9RN09BcHUrTDF4ZWpqRW80ZXlWV3pWVEhk?=
 =?utf-8?B?Ull4ZlZ3VmdmWGFaQ2Q1SWMwTTZGdXhTbXlZTjk4MENudlZ4NThoU2F2VVJL?=
 =?utf-8?B?T0xSZEpPMlFhUEtWVW9VMTQrY3N3a3pnRk9TWTZTSksxVHhUQll4ZytucG9o?=
 =?utf-8?B?cHBSZXZTeUNKOVYrQmJ4bWUyaXdGOHkzMWhqYVZKZWNvYXhVbFdDeTUzbzNJ?=
 =?utf-8?B?WnI4SUN6T3lRaStCYTJpanRDVkdCYTF2VWVLS3BPRFQ0cDZ4bHFIS1dVandH?=
 =?utf-8?B?R044cmg5ZkJmaUlwR0hLQ0ljVTVvcVIyYU1ORnphU2JBMEsrQlFURVhWRGJ1?=
 =?utf-8?B?eFFGRzFLdU1KcWVZdUluTHpmS0tuNElKa1NQRXl2eG5rM0hGZysza01FYUJz?=
 =?utf-8?B?RVZrNHd3WDFpSHpxR1dtVnY2L3FTUzZWNlJiT0V0MHNZbDdGcUk4Q2hYSHVC?=
 =?utf-8?B?aGwrODNvYllEQWpxZC9KaGFzalVmdjhHeGNUL01hTTE2UFl6em1LbVhSV0JR?=
 =?utf-8?B?T0pLelJ5UlArQUMwKzVwSy9EUnUxNUM4cEJSVlllQ2VhbzRaNk94ZmVzUGtQ?=
 =?utf-8?B?Y2RVTDFNcTFIcHdWb0pIU3Irdzg2cHQzaWVSMFBJMENXanovZUw3dWJaTEhn?=
 =?utf-8?B?ZVd2ejNKeFhxVlAyZWFMbEY2WUNJQVIyaVdsSk9uMEFab2hJK1hPdjBibzFS?=
 =?utf-8?B?MXBoSlhoaGZLUmp5WTFJNWErbEI4REpmU1dGc0dvUHh6UDhROERZY2hWeS9X?=
 =?utf-8?Q?B2SQfoE0nFu9UYm7iCVpeqJHoV/PKOs3k0/OzVJ?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 25bbde04-0a55-49f2-edc4-08d994a635c3
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Oct 2021 15:19:43.8130
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jbeulich@suse.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4381

On 15.10.2021 14:51, Juergen Gross wrote:
> The HVM hypercall handler is missing incrementing the per hypercall
> counters. Add that.
> 
> The counters for PV are handled wrong, as they are not using
> perf_incra() with the number of the hypercall as index, but are
> incrementing the total number of hypercalls only. Fix that.

Why do you say "total number"? Isn't it that all accounting goes into
set_trap_table's slot, effectively making that slot a "total number"
despite not being labeled that way?

Also this fix renders largely redundant the calls_to_multicall counter.
Could I talk you into deleting that at the same time? (As to the "not
fully redundant": I consider it suspicious that this counter gets
incremented at the bottom of the function, not at the top.)

Finally I take it that with the Kconfig setting being under DEBUG, we
don't consider security supported builds with PERF_COUNTERS enabled.
Otherwise as a prereq I would think perfc_incra() would need teaching
of array_index_nospec().

In any event, preferably with at least the description slightly
adjusted,
Reviewed-by: Jan Beulich <jbeulich@suse.com>

Jan



From xen-devel-bounces@lists.xenproject.org Thu Oct 21 15:25:12 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Oct 2021 15:25:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.214524.373093 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdZwH-0003rK-VL; Thu, 21 Oct 2021 15:25:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 214524.373093; Thu, 21 Oct 2021 15:25:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdZwH-0003rD-SB; Thu, 21 Oct 2021 15:25:05 +0000
Received: by outflank-mailman (input) for mailman id 214524;
 Thu, 21 Oct 2021 15:25:04 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mdZwG-0003r3-Gl; Thu, 21 Oct 2021 15:25:04 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mdZwG-0003Oi-CS; Thu, 21 Oct 2021 15:25:04 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mdZwG-0000cp-4N; Thu, 21 Oct 2021 15:25:04 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mdZwG-0002Cx-3t; Thu, 21 Oct 2021 15:25:04 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=EWVvrz+Cop1Y1MUEiVNlOOXDEWF2gI5psnZa6CXWNM4=; b=bs+/l/KvtDY0f9HtoqpsH60p/l
	PJTdQrOp8mZp/HEyf8A+GM02lKHyzfkY5rz5ks86uIy96LhIaL67T+1v1FknayoizROSmbErEwupP
	qgUM7IQoNFYM7X/IYJpyqZ9Hx+SepnLNk0O2Cq4kmN4DuwvVC7zDzs/1L1tdvM+zJyvU=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165701-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 165701: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=305fd6bee0bfe1602163d1f8841954f84aa31b68
X-Osstest-Versions-That:
    ovmf=6893865b3010bb6192f732643c4b8ba026726d07
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 21 Oct 2021 15:25:04 +0000

flight 165701 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165701/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 305fd6bee0bfe1602163d1f8841954f84aa31b68
baseline version:
 ovmf                 6893865b3010bb6192f732643c4b8ba026726d07

Last test of basis   165690  2021-10-20 13:40:00 Z    1 days
Testing same since   165701  2021-10-21 03:40:20 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  IanX Kuo <ianx.kuo@intel.com>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   6893865b30..305fd6bee0  305fd6bee0bfe1602163d1f8841954f84aa31b68 -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Thu Oct 21 17:16:27 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Oct 2021 17:16:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.214539.373119 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdbfo-00060o-3E; Thu, 21 Oct 2021 17:16:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 214539.373119; Thu, 21 Oct 2021 17:16:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdbfn-00060h-Vl; Thu, 21 Oct 2021 17:16:11 +0000
Received: by outflank-mailman (input) for mailman id 214539;
 Thu, 21 Oct 2021 17:16:10 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mdbfm-00060b-FL
 for xen-devel@lists.xenproject.org; Thu, 21 Oct 2021 17:16:10 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mdbfl-0005kR-V4; Thu, 21 Oct 2021 17:16:09 +0000
Received: from [54.239.6.190] (helo=[192.168.27.91])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mdbfl-0008I4-P2; Thu, 21 Oct 2021 17:16:09 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:
	References:Cc:To:From:Subject:MIME-Version:Date:Message-ID;
	bh=MSaQ8HxK/6BgSHTIie+s5NToYoto/9DyxxeSqeay/1o=; b=JZdA/AYnIRrV34NnCamLcOtNIx
	7IOksC0nVa3pffn4L1nMT9wyokCF3pb+0jnooHoUAybWYyQzCPbkI7qY3pkSD4SSl38mczHxmJFTX
	Hjmn55vwfLjAkDhD5g2Ny6/Czyvc3vLqD1i+qPgdMSzOaGwD5T5JUt+D9dNP08sEHoJk=;
Message-ID: <5bb464f6-0b71-d419-b05c-82abdebf85e3@xen.org>
Date: Thu, 21 Oct 2021 18:16:07 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.2.0
Subject: Re: [for-4.16] Re: [PATCH v4] xen/arm: vgic: Ignore write access to
 ICPENDR*
From: Julien Grall <julien@xen.org>
To: Hongda Deng <Hongda.Deng@arm.com>, xen-devel@lists.xenproject.org,
 sstabellini@kernel.org
Cc: Bertrand.Marquis@arm.com, Wei.Chen@arm.com,
 Ian Jackson <iwj@xenproject.org>
References: <20211021120319.2394-1-Hongda.Deng@arm.com>
 <e7804793-82a4-b2ac-0146-fe5bbed2bfbf@xen.org>
In-Reply-To: <e7804793-82a4-b2ac-0146-fe5bbed2bfbf@xen.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit



On 21/10/2021 16:14, Julien Grall wrote:
> On the previous version, we discussed to include the patch for 4.16. So 
> please tag it with for-4.16 and CC the Release Manager (Ian). This will 
> help him to track what's outstanding for the release.
> 
> On 21/10/2021 13:03, Hongda Deng wrote:
>> Currently, Xen will return IO unhandled when guests write ICPENDR*
>> virtual registers, which will raise a data abort inside the guest.
>> For Linux guest, these virtual registers will not be accessed. But
>> for Zephyr, these virtual registers will be accessed during the
>> initialization. Zephyr guest will get an IO data abort and crash.
>> Emulating ICPENDR is not easy with the existing vGIC, this patch
>> reworks the emulation to ignore write access to ICPENDR* virtual
>> registers and print a message about whether they are already pending
>> instead of returning unhandled.
>> More details can be found at [1].
>>
>> [1] https://github.com/zephyrproject-rtos/zephyr/blob/eaf6cf745df3807e6e
>> cc941c3a30de6c179ae359/drivers/interrupt_controller/intc_gicv3.c#L274
>>
>> Signed-off-by: Hongda Deng <hongda.deng@arm.com>
> 
> While I agree the Reviewed-by from Bertrand should be dropped, the 
> Release-acked-by from Ian is simply a way to say he is happy to include 
> the patch for 4.16. So this should have been retain.
> 
> The patch looks good to me, so I can add Ian's tag on commit:
> 
> Reviewed-by: Julien Grall <jgrall@amazon.com>

Committed.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Thu Oct 21 17:29:24 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Oct 2021 17:29:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.214551.373134 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdbsV-0007XE-AX; Thu, 21 Oct 2021 17:29:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 214551.373134; Thu, 21 Oct 2021 17:29:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdbsV-0007X7-7K; Thu, 21 Oct 2021 17:29:19 +0000
Received: by outflank-mailman (input) for mailman id 214551;
 Thu, 21 Oct 2021 17:29:18 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mdbsU-0007Wx-Jh; Thu, 21 Oct 2021 17:29:18 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mdbsU-0005yd-Ew; Thu, 21 Oct 2021 17:29:18 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mdbsU-0005wB-7F; Thu, 21 Oct 2021 17:29:18 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mdbsU-0002et-6l; Thu, 21 Oct 2021 17:29:18 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=GV90SkThfHD56KAE/8mLTqQNMwa3fMFQLL7tUBrb8xg=; b=LT4ATVlkdnllZ0fLcD7xzhzIoe
	ocaUeaXNwCZs1Rjwdbzc7ZrUxluUUCnqjRbHezUJu5aDaUBi8TSLTxxl3ZLnEah/8JM8LqSKxJ8r/
	e5laLevrION+LOR7FyVjQbi4m8zSQb/8kXYYEZKQ1MPSfrXpZ4mJ53RSVUfI3phikqhc=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165700-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 165700: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:heisenbug
    linux-linus:test-amd64-amd64-freebsd11-amd64:guest-start/freebsd.repeat:fail:heisenbug
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=2f111a6fd5b5297b4e92f53798ca086f7c7d33a4
X-Osstest-Versions-That:
    linux=8e37395c3a5dceff62a5010ebbbc107f4145935c
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 21 Oct 2021 17:29:18 +0000

flight 165700 linux-linus real [real]
flight 165715 linux-linus real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/165700/
http://logs.test-lab.xenproject.org/osstest/logs/165715/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-arm64-arm64-xl-credit1   8 xen-boot            fail pass in 165715-retest
 test-amd64-amd64-freebsd11-amd64 21 guest-start/freebsd.repeat fail pass in 165715-retest

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-xl-credit1 15 migrate-support-check fail in 165715 never pass
 test-arm64-arm64-xl-credit1 16 saverestore-support-check fail in 165715 never pass
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 165693
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 165693
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165693
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 165693
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165693
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 165693
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 165693
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165693
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 linux                2f111a6fd5b5297b4e92f53798ca086f7c7d33a4
baseline version:
 linux                8e37395c3a5dceff62a5010ebbbc107f4145935c

Last test of basis   165693  2021-10-20 16:40:19 Z    1 days
Testing same since   165700  2021-10-21 03:27:38 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Christoph Hellwig <hch@lst.de>
  Gerald Schaefer <gerald.schaefer@linux.ibm.com>
  Hamza Mahfooz <someguy@effective-light.com>
  Ilya Dryomov <idryomov@gmail.com>
  Jeff Layton <jlayton@kernel.org>
  Linus Torvalds <torvalds@linux-foundation.org>
  Logan Gunthorpe <logang@deltatee.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             fail    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  fail    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   8e37395c3a5d..2f111a6fd5b5  2f111a6fd5b5297b4e92f53798ca086f7c7d33a4 -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Thu Oct 21 18:28:55 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Oct 2021 18:28:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.214574.373166 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdcnz-00052e-21; Thu, 21 Oct 2021 18:28:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 214574.373166; Thu, 21 Oct 2021 18:28:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdcny-00052X-V6; Thu, 21 Oct 2021 18:28:42 +0000
Received: by outflank-mailman (input) for mailman id 214574;
 Thu, 21 Oct 2021 18:28:41 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mdcnx-00052M-KH; Thu, 21 Oct 2021 18:28:41 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mdcnx-00071V-B1; Thu, 21 Oct 2021 18:28:41 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mdcnx-0008M2-1N; Thu, 21 Oct 2021 18:28:41 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mdcnx-0000PU-0x; Thu, 21 Oct 2021 18:28:41 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=cFulYsFn1Z+67YhHmeUwr4Ynl6eVXq17hT8OLrZVd8c=; b=r63tHsL1Z670DWCfkY2o97CeR1
	BGHKw/euMuYLsJVnu3hP2E4tA34xm4A3+z1jRI2M/jjKj4f6y3fG6i4ROBFFKsy6oWXzQnu+ICBQr
	eD1mGeSxhKN0qif+TDOOq1RvLszrRTWPxyNGjgJlFRothbod9pNbkE9IVtu9N7XY8h7I=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165703-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 165703: regressions - FAIL
X-Osstest-Failures:
    qemu-mainline:build-i386:xen-build:fail:regression
    qemu-mainline:build-i386-xsm:xen-build:fail:regression
    qemu-mainline:build-armhf:xen-build:fail:regression
    qemu-mainline:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-amd:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-pair:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-freebsd10-i386:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-freebsd10-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-coresched-i386-xl:build-check(1):blocked:nonblocking
    qemu-mainline:build-armhf-libvirt:build-check(1):blocked:nonblocking
    qemu-mainline:build-i386-libvirt:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-intel:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-shadow:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-vhd:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=afc9fcde55296b83f659de9da3cdf044812a6eeb
X-Osstest-Versions-That:
    qemuu=50352cce138ef3b30c1cda28a4df68fff5da3202
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 21 Oct 2021 18:28:41 +0000

flight 165703 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165703/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-i386                    6 xen-build                fail REGR. vs. 165682
 build-i386-xsm                6 xen-build                fail REGR. vs. 165682
 build-armhf                   6 xen-build                fail REGR. vs. 165682

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl           1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-credit2   1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-cubietruck  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-multivcpu  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-rtds      1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-vhd       1 build-check(1)               blocked  n/a
 test-amd64-i386-qemuu-rhel6hvm-amd  1 build-check(1)               blocked n/a
 test-amd64-i386-pair          1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-freebsd10-i386  1 build-check(1)               blocked  n/a
 test-amd64-i386-freebsd10-amd64  1 build-check(1)               blocked  n/a
 test-amd64-coresched-i386-xl  1 build-check(1)               blocked  n/a
 build-armhf-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-arndale   1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-credit1   1 build-check(1)               blocked  n/a
 test-amd64-i386-qemuu-rhel6hvm-intel  1 build-check(1)             blocked n/a
 test-amd64-i386-xl            1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-pvshim     1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-qemuu-debianhvm-amd64  1 build-check(1)         blocked n/a
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow  1 build-check(1)  blocked n/a
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm  1 build-check(1)      blocked n/a
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 1 build-check(1) blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a
 test-amd64-i386-xl-qemuu-win7-amd64  1 build-check(1)              blocked n/a
 test-amd64-i386-xl-qemuu-ws16-amd64  1 build-check(1)              blocked n/a
 test-amd64-i386-xl-shadow     1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-vhd        1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-xsm        1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165682
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165682
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165682
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 qemuu                afc9fcde55296b83f659de9da3cdf044812a6eeb
baseline version:
 qemuu                50352cce138ef3b30c1cda28a4df68fff5da3202

Last test of basis   165682  2021-10-19 21:09:14 Z    1 days
Testing same since   165694  2021-10-20 18:09:12 Z    1 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
  Ani Sinha <ani@anisinha.ca>
  David Hildenbrand <david@redhat.com>
  Eric Auger <eric.auger@redhat.com>
  Eugenio Pérez <eperezma@redhat.com>
  Igor Mammedov <imammedo@redhat.com>
  Jason Wang <jasowang@redhat.com>
  Laurent Vivier <lvivier@redhat.com>
  Mathieu Poirier <mathieu.poirier@linaro.org>
  Michael S. Tsirkin <mst@redhat.com>
  Richard Henderson <richard.henderson@linaro.org>
  Stefan Hajnoczi <stefanha@redhat.com>
  Thomas Huth <thuth@redhat.com>
  Xueming Li <xuemingl@nvidia.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               fail    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          blocked 
 test-amd64-i386-xl                                           blocked 
 test-amd64-coresched-i386-xl                                 blocked 
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  blocked 
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       blocked 
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           blocked 
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     blocked 
 test-amd64-i386-freebsd10-amd64                              blocked 
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          blocked 
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          blocked 
 test-armhf-armhf-xl-arndale                                  blocked 
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  blocked 
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  blocked 
 test-armhf-armhf-xl-cubietruck                               blocked 
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         blocked 
 test-amd64-i386-freebsd10-i386                               blocked 
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         blocked 
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                blocked 
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         blocked 
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 blocked 
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    blocked 
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     blocked 
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              blocked 
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    blocked 
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      blocked 
 test-amd64-i386-xl-vhd                                       blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 1390 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Oct 21 18:30:42 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Oct 2021 18:30:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.214582.373180 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdcpu-0006Nb-G6; Thu, 21 Oct 2021 18:30:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 214582.373180; Thu, 21 Oct 2021 18:30:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdcpu-0006NU-Cz; Thu, 21 Oct 2021 18:30:42 +0000
Received: by outflank-mailman (input) for mailman id 214582;
 Thu, 21 Oct 2021 18:30:41 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mdcps-0006NM-WF
 for xen-devel@lists.xenproject.org; Thu, 21 Oct 2021 18:30:41 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mdcpp-00073K-Bs; Thu, 21 Oct 2021 18:30:37 +0000
Received: from [54.239.6.190] (helo=[192.168.27.91])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mdcpp-0005A3-0p; Thu, 21 Oct 2021 18:30:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=xDmdELIKYqcTRmCROXLF9qemMwnOCXQs9m7o1NUuyV0=; b=o199ey6/gzoHPvUUGwcJ6wgKQO
	11izxkjcvKkJuBnZQNbG6c0TG0vwKOGXq5j1TatiAODwitALeEBwLQnitBMdbNfyvy2FC1HvMzShu
	VPCHRgAnHiXbP0rQVh0sAEdSSkpoUUu0De2MH4SclxzdFbCfksptd2HJwdwSyDp1BnV8=;
Message-ID: <13240b69-f7bb-6a64-b89c-b7c2cbb7e465@xen.org>
Date: Thu, 21 Oct 2021 19:30:34 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.2.0
Subject: Re: [XEN][RFC PATCH 10/13] xen/arm: Implement device tree node
 addition functionalities
To: Vikram Garhwal <fnu.vikram@xilinx.com>, xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Jan Beulich <jbeulich@suse.com>, Wei Liu <wl@xen.org>
References: <1630562763-390068-1-git-send-email-fnu.vikram@xilinx.com>
 <1630562763-390068-11-git-send-email-fnu.vikram@xilinx.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <1630562763-390068-11-git-send-email-fnu.vikram@xilinx.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Vikram,

On 02/09/2021 07:06, Vikram Garhwal wrote:
> Introduce domctl XEN_DOMCTL_addfpga to add a device-tree node through device

XEN_DOMCTL_* are hypercalls to manage a given domain. However, here you 
are modifying the system.

This is similar to managing PCI devices, except here we are dealing with 
platforms devices. In the case of PCI devices, we are using PHYSDEVOP_*.

If we only expect the toolstack to the call (e.g. the kernel won't use 
it directly), then it would be better to use SYSCTL_* as they are not 
stable (so we have more flexibility to modify the layout).

Furthermore, rather than introduciong 2 new sub-hypercalls for 
XEN_SYSCTL_* I would introduce a single sub-hypercall that takes a 
command (e.g. add/remove).

Regarding the name, in theory this feature is not FPGA specific. So I 
would prefer a more generic name, maybe XEN_DOMCTL_dt_overlay?

> tree overlay. This works with a device tree overlay(.dtbo) as input.
> 
> Add check_pfdt() to do sanity check on the dtbo.

 From my experience with libfdt, the library tends to consider the DTB 
to be sound. So we would have to trust what the toolstack is provided us.

So I think we need to make clear that this is basic sanity check and 
there are no expectation that we will be able to deal with a random blob.

> 
> Also, added overlay_get_node_info() to get the node's full name with path. This
> comes handy when checking node for duplication.
> 
> Each time a overlay node is added, a new fdt(memcpy of device_tree_flattened) is
> created and updated with overlay node. This updated fdt is further unflattened
> to a dt_host_new. Next, it checks if overlay node already exists in the dt_host.
> If overlay node doesn't exist then find the overlay node in dt_host_new, find
> the overlay node's parent in dt_host and add the node as child under parent in
> the dt_host. The node is attached as the last node under target parent.
> 
> Finally, add IRQs, add device to IOMMUs, set permissions and map MMIO for the
> overlay node.
> 
> When a node is added using overlay, a new entry is allocated in the
> overlay_track to keep the track of memory allocation due to addition of overlay
> node. This is helpful for freeing the memory allocated when a device tree node
> is removed with domctl XEN_DOMCTL_delfpga domctl.
> 
> Signed-off-by: Vikram Garhwal <fnu.vikram@xilinx.com>
> ---
>   xen/arch/arm/domctl.c         | 262 ++++++++++++++++++++++++++++++++++++++++++
>   xen/common/device_tree.c      |  54 +++++++++
>   xen/include/public/domctl.h   |   7 ++
>   xen/include/xen/device_tree.h |   1 +
>   4 files changed, 324 insertions(+)
> 
> diff --git a/xen/arch/arm/domctl.c b/xen/arch/arm/domctl.c
> index 5986934..0ac635f 100644
> --- a/xen/arch/arm/domctl.c
> +++ b/xen/arch/arm/domctl.c
> @@ -15,6 +15,8 @@
>   #include <xen/types.h>
>   #include <xsm/xsm.h>
>   #include <public/domctl.h>
> +/* Included for FPGA dt add. */

We don't usually write done why an header is included. So I would remove 
this comment.

> +#include <xen/libfdt/libfdt.h>
>   #include <xen/xmalloc.h>
>   #include <xen/device_tree.h>
>   #include <asm/domain_build.h>
> @@ -68,6 +70,61 @@ static int handle_vuart_init(struct domain *d,
>       return rc;
>   }
>   
> +static int check_pfdt(void *pfdt, uint32_t pfdt_size)
> +{
> +    if ( fdt_totalsize(pfdt) != pfdt_size )
> +    {
> +        printk(XENLOG_ERR "Partial FDT is not a valid Flat Device Tree\n");
> +        return -EFAULT;

I think -EINVAL is more suitable.

> +    }
> +
> +    if ( fdt_check_header(pfdt) )
> +    {
> +        printk(XENLOG_ERR "Partial FDT is not a valid Flat Device Tree\n");

The printk() is exactly the same as above. So how about combining the 
two check?

Furthemore, from the commit message, the pfdt is an overlay fdt. So 
shouldn't we have write "The overlay FDT" rather than "Partial FDT"?

> +        return -EFAULT;
> +    }
> +
> +    return 0;
> +}
> +
> +static void overlay_get_node_info(void *fdto, char *node_full_path)
> +{
> +    int fragment;
> +
> +    /*
> +     * Handle overlay nodes. But for now we are just handling one node.

Is this a limitation you plan to handle before this series is going to 
be committed?

> +     */
> +    fdt_for_each_subnode(fragment, fdto, 0)
> +    {
> +        int target;
> +        int overlay;
> +        int subnode;
> +        const char *target_path;
> +
> +        target = overlay_get_target(device_tree_flattened, fdto, fragment,
> +                                    &target_path);
> +        overlay = fdt_subnode_offset(fdto, fragment, "__overlay__");
> +
> +        fdt_for_each_subnode(subnode, fdto, overlay)
> +        {
> +            const char *node_name = fdt_get_name(fdto, subnode, NULL);
> +            int node_name_len = strlen(node_name);
> +            int target_path_len = strlen(target_path);
> +
> +            memcpy(node_full_path, target_path, target_path_len);
Looking at the caller (handle_add_fpga_overlay()), the node_full_path is 
a fixed array. What does guarantee that the array is large enough to 
target_path?

> +
> +            node_full_path[target_path_len] = '/';
> +
> +            memcpy(node_full_path + target_path_len + 1, node_name,
> +                   node_name_len);
> +
> +            node_full_path[target_path_len + 1 + node_name_len] = '\0';
> +
> +            return;
> +        }
> +    }
> +}
> +
>   /*
>    * First finds the device node to remove. Check if the device is being used by
>    * any dom and finally remove it from dt_host. IOMMU is already being taken care
> @@ -194,6 +251,181 @@ out:
>       return rc;
>   }
>   
> +/*
> + * Adds only one device node at a time under target node.
> + * We use dt_host_new to unflatten the updated device_tree_flattened. This is
> + * done to avoid the removal of device_tree generation, iomem regions mapping to
> + * DOM0 done by handle_node().

Below you are using "hardware_domain" which may or may not be dom0. So 
replace "dom0" with "hardware domain".

> + */
> +static long handle_add_fpga_overlay(void *pfdt, uint32_t pfdt_size)
> +{
> +    int rc = 0;
> +    struct dt_device_node *fpga_node;
> +    char node_full_path[128];
> +    void *fdt = xmalloc_bytes(fdt_totalsize(device_tree_flattened));

I would prefer if the xmalloc_bytes() happens closer to the check "fdt 
== NULL" below. This makes easier to link the two.

In addition to that, device_tree_flattened will be NULL when Xen is 
booting with ACPI. So we need to return an error if one try to use this 
feature on such platform.

Lastly, I think we should consider to protect all the new code under a 
config so this is not compiled by default.

> +    struct dt_device_node *dt_host_new;
> +    struct domain *d = hardware_domain;
> +    struct overlay_track *tr = NULL;
> +    int node_full_path_namelen;
> +    unsigned int naddr;
> +    unsigned int i;
> +    u64 addr, size;
> +
> +    if ( fdt == NULL )
> +        return ENOMEM;

We usually add - in from of the errno.

> +
> +    spin_lock(&overlay_lock);
> +
> +    memcpy(fdt, device_tree_flattened, fdt_totalsize(device_tree_flattened));
> +
> +    rc = check_pfdt(pfdt, pfdt_size);
> +
> +    if ( rc )
> +        goto err;
> +
> +    overlay_get_node_info(pfdt, node_full_path);

You don't really need this info until the overlay has been applied. So I 
would suggest to move this after fdt_overlay_apply().

> +
> +    rc = fdt_overlay_apply(fdt, pfdt);
> +
> +    if ( rc )
> +    {
> +        printk(XENLOG_ERR "Adding overlay node %s failed with error %d\n",
> +               node_full_path, rc);
> +        goto err;
> +    }
> +
> +    /* Check if node already exists in dt_host. */
> +    fpga_node = dt_find_node_by_path(node_full_path);
> +
> +    if ( fpga_node != NULL )
> +    {
> +        printk(XENLOG_ERR "node %s exists in device tree\n", node_full_path);
> +        rc = -EINVAL;
> +        goto err;
> +    }
> +
> +    /* Unflatten the fdt into a new dt_host. */
> +    unflatten_device_tree(fdt, &dt_host_new);

Looking at this function, there is at least a potential allocation 
failure. So it needs to be updated to propagate any error in order to 
use it in an hypercall.

Furthemore, AFAICT, the function will continue even if there are 
corrupted node. This brings back to my point above that this hypercall 
will only work with trusted DT. I am OK with that so long we written it 
clearly in the interface and documentation.

> +
> +    /* Find the newly added node in dt_host_new by it's full path. */
> +    fpga_node = _dt_find_node_by_path(dt_host_new, node_full_path);
> +
> +    if ( fpga_node == NULL )
> +    {
> +        dt_dprintk("%s node not found\n", node_full_path);
> +        rc = -EFAULT;
> +        xfree(dt_host_new);
> +        goto err;
> +    }
> +
> +    /* Just keep the node we intend to add. Remove every other node in list. */
> +    fpga_node->allnext = NULL;
> +    fpga_node->sibling = NULL;

IMHO, the two lines belong to fpga_add_node().

> +
> +    /* Add the node to dt_host. */
> +    rc = fpga_add_node(fpga_node, fpga_node->parent->full_name);
> +
> +    if ( rc )
> +    {
> +        /* Node not added in dt_host. Safe to free dt_host_new. */
> +        xfree(dt_host_new);
> +        goto err;
> +    }
> +
> +    /* Get the node from dt_host and add interrupt and IOMMUs. */
> +    fpga_node = dt_find_node_by_path(fpga_node->full_name);
> +
> +    if ( fpga_node == NULL )
> +    {
> +        /* Sanity check. But code will never come in this loop. */

There is no loop here. So what did you mean?

> +        printk(XENLOG_ERR "Cannot find %s node under updated dt_host\n",
> +               fpga_node->name);
> +        goto remove_node;
> +    }
> +

The code below is pretty much a copy of handle_device(). Can you look to 
re-use it?

> +    /* First let's handle the interrupts. */
> +    rc = handle_device_interrupts(d, fpga_node, false);
> +
> +    if ( rc )
> +    {
> +        printk(XENLOG_G_ERR "Interrupt failed\n");
> +        goto remove_node;
> +    }
> +
> +    /* Add device to IOMMUs */
> +    rc = iommu_add_dt_device(fpga_node);
> +
> +    if ( rc < 0 )
> +    {
> +        printk(XENLOG_G_ERR "Failed to add %s to the IOMMU\n",
> +               dt_node_full_name(fpga_node));
> +        goto remove_node;
> +    }
> +
> +    /* Set permissions. */
> +    naddr = dt_number_of_address(fpga_node);
> +
> +    dt_dprintk("%s passthrough = %d naddr = %u\n",
> +               dt_node_full_name(fpga_node), false, naddr);
> +
> +    /* Give permission and map MMIOs */
> +    for ( i = 0; i < naddr; i++ )
> +    {
> +        struct map_range_data mr_data = { .d = d, .p2mt = p2m_mmio_direct_c };
> +        rc = dt_device_get_address(fpga_node, i, &addr, &size);
> +        if ( rc )
> +        {
> +            printk(XENLOG_ERR "Unable to retrieve address %u for %s\n",
> +                   i, dt_node_full_name(fpga_node));
> +            goto remove_node;
> +        }
> +
> +        rc = map_range_to_domain(fpga_node, addr, size, &mr_data);
> +        if ( rc )
> +            goto remove_node;
> +    }
> +
> +    /* This will happen if everything above goes right. */
> +    tr = xzalloc(struct overlay_track);

xzalloc() can fail. So you need to check the return.

> +    tr->dt_host_new = dt_host_new;

Looking at the code above, dt_host_new is pretty much a full copy of the 
DT + the overlay. From my understanding, the flat device-tree can be up 
to 2MB, therefore the unflatten one is likely bigger.

So to me this seems quite a waste of memory. Can we look to only keep in 
memory the nodes we need?

> +    node_full_path_namelen = strlen(node_full_path);
> +    tr->node_fullname = xmalloc_bytes(node_full_path_namelen + 1);
> +
> +    if ( tr->node_fullname == NULL )
> +    {
> +        rc = -ENOMEM;
> +        goto remove_node;
> +    }
> +
> +    memcpy(tr->node_fullname, node_full_path, node_full_path_namelen);
> +    tr->node_fullname[node_full_path_namelen] = '\0';
> +
> +    INIT_LIST_HEAD(&tr->entry);
> +    list_add_tail(&tr->entry, &overlay_tracker);
> +
> +err:
> +    spin_unlock(&overlay_lock);
> +    xfree(fdt);
> +    return rc;
> +
> +/*
> + * Failure case. We need to remove the node, free tracker(if tr exists) and
> + * dt_host_new. As the tracker is not in list yet so it doesn't get freed in
> + * handle_del_fpga_nodes() and due to that dt_host_new will not get freed so we
> + * we free tracker and dt_host_new here.
> + */
> +remove_node:
> +    spin_unlock(&overlay_lock);
> +    handle_del_fpga_nodes(node_full_path);
> +    xfree(dt_host_new);
> +
> +    if ( tr )
> +        xfree(tr);
> +
> +    xfree(fdt);
> +    return rc;
> +}
> +
>   long arch_do_domctl(struct xen_domctl *domctl, struct domain *d,
>                       XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_domctl)
>   {
> @@ -323,6 +555,36 @@ long arch_do_domctl(struct xen_domctl *domctl, struct domain *d,
>           return rc;
>       }
>   
> +    case XEN_DOMCTL_addfpga:
> +    {
> +        void *pfdt;
> +        int rc;
> +
> +        if ( domctl->u.fpga_add_dt.pfdt_size > 0 )
> +            pfdt = xmalloc_bytes(domctl->u.fpga_add_dt.pfdt_size);

Can we limit the size of the blob?

> +        else
> +            return -EINVAL;
> +
> +        if ( pfdt == NULL )
> +            return -ENOMEM;
> +
> +        rc = copy_from_guest(pfdt, domctl->u.fpga_add_dt.pfdt,
> +                             domctl->u.fpga_add_dt.pfdt_size);
> +        if ( rc )
> +        {
> +            gprintk(XENLOG_ERR, "copy from guest failed\n");
> +            xfree(pfdt);
> +
> +            return -EFAULT;
> +        }
> +
> +        rc = handle_add_fpga_overlay(pfdt, domctl->u.fpga_add_dt.pfdt_size);
> +
> +        xfree(pfdt);
> +
> +        return rc;
> +    }
> +
>       case XEN_DOMCTL_delfpga:
>       {
>           char *full_dt_node_path;
> diff --git a/xen/common/device_tree.c b/xen/common/device_tree.c
> index 04f2578..d062c17 100644
> --- a/xen/common/device_tree.c
> +++ b/xen/common/device_tree.c
> @@ -324,6 +324,60 @@ void dt_print_node_names(struct dt_device_node *dt)
>       return;
>   }
>   
> +int fpga_add_node(struct dt_device_node *fpga_node,
> +                  const char *parent_node_path)
> +{
> +    struct dt_device_node *parent_node;
> +    struct dt_device_node *np;
> +    struct dt_device_node *next_node;
> +    struct dt_device_node *new_node;
> +
> +    parent_node = dt_find_node_by_path(parent_node_path);
> +
> +    new_node = fpga_node;
> +
> +    if ( new_node == NULL )
> +        return -EINVAL;
> +
> +    if ( parent_node == NULL )
> +    {
> +        dt_dprintk("Node not found. Partial dtb will not be added");
> +        return -EINVAL;
> +    }
> +
> +    /*
> +     * If node is found. We can attach the fpga_node as a child of the
> +     * parent node.
> +     */
> +
> +    for ( np = parent_node->child; np->sibling != NULL; np = np->sibling )
> +    {

I would suggest to clearify in the comment what this loop is for. This 
would make easier to understand that the body of the loop is left empty 
on purpose.

> +    }
> +
> +    /*
> +     * Before attaching also check if the parent node of fpga_node is also
> +     * same named as parent.
> +     */
> +    next_node = np->allnext;
> +
> +    new_node->parent = parent_node;
> +    np->sibling = new_node;
> +    np->allnext = new_node;
> +
> +    /*
> +     * Reach at the end of fpga_node.
> +     * TODO: Remove this loop as we are just adding one node for now.

For clarification, by "one node", do you mean top-level node or are you 
saying this node has no child?

> +     */
> +    for ( np = new_node; np->allnext != NULL; np = np->allnext )
> +    {
> +    }
> +
> +    /* Now plug next_node at the end of fpga_node. */
> +    np->allnext = next_node;
> +
> +    return 0;
> +}
> +
>   int fpga_del_node(struct dt_device_node *device_node)
>   {
>       struct dt_device_node *np;
> diff --git a/xen/include/public/domctl.h b/xen/include/public/domctl.h
> index b1b8efd..ce4667e 100644
> --- a/xen/include/public/domctl.h
> +++ b/xen/include/public/domctl.h
> @@ -1175,6 +1175,11 @@ struct xen_domctl_fpga_del_dt {
>       uint32_t size;
>   };
>   
> +/* XEN_DOMCTL_fpga_add. */

Please add some documentation about the new hypercall.

> +struct xen_domctl_fpga_add_dt {
> +    XEN_GUEST_HANDLE_64(void) pfdt;
> +    uint32_t pfdt_size;  /* Partial dtb size. */
> +};
>   
>   struct xen_domctl {
>       uint32_t cmd;
> @@ -1261,6 +1266,7 @@ struct xen_domctl {
>   #define XEN_DOMCTL_get_cpu_policy                82
>   #define XEN_DOMCTL_set_cpu_policy                83
>   #define XEN_DOMCTL_vmtrace_op                    84
> +#define XEN_DOMCTL_addfpga                      85
>   #define XEN_DOMCTL_delfpga                      86
>   #define XEN_DOMCTL_gdbsx_guestmemio            1000
>   #define XEN_DOMCTL_gdbsx_pausevcpu             1001
> @@ -1323,6 +1329,7 @@ struct xen_domctl {
>           struct xen_domctl_psr_alloc         psr_alloc;
>           struct xen_domctl_vuart_op          vuart_op;
>           struct xen_domctl_vmtrace_op        vmtrace_op;
> +        struct xen_domctl_fpga_add_dt       fpga_add_dt;
>           struct xen_domctl_fpga_del_dt       fpga_del_dt;
>           uint8_t                             pad[128];
>       } u;
> diff --git a/xen/include/xen/device_tree.h b/xen/include/xen/device_tree.h
> index eb7f645..4c8dec6 100644
> --- a/xen/include/xen/device_tree.h
> +++ b/xen/include/xen/device_tree.h
> @@ -496,6 +496,7 @@ int dt_find_node_by_gpath(XEN_GUEST_HANDLE(char) u_path, uint32_t u_plen,
>    * Prints all node names.
>    */
>   void dt_print_node_names(struct dt_device_node *dt);
> +int fpga_add_node(struct dt_device_node *fpga_node, const char *parent_node);
>   int fpga_del_node(struct dt_device_node *device_node);
>   
>   /**
> 

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Thu Oct 21 20:01:14 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Oct 2021 20:01:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.214593.373191 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdeFK-0006Nx-7W; Thu, 21 Oct 2021 20:01:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 214593.373191; Thu, 21 Oct 2021 20:01:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdeFK-0006Nq-40; Thu, 21 Oct 2021 20:01:02 +0000
Received: by outflank-mailman (input) for mailman id 214593;
 Thu, 21 Oct 2021 20:01:01 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mdeFJ-0006Ng-G2; Thu, 21 Oct 2021 20:01:01 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mdeFJ-0000C1-9f; Thu, 21 Oct 2021 20:01:01 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mdeFJ-00057r-1W; Thu, 21 Oct 2021 20:01:01 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mdeFJ-0000gq-10; Thu, 21 Oct 2021 20:01:01 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=fnJCnZdGeIhnqnoDD6pfnOb1yxnmPQrjWtKqjPAmTCA=; b=B5UeiSQeRi41pkrVSGiwbIm9ce
	2UhwlFrdE79Od/NuQn4Bvluy1LS0StaL05gC/PRHBGHBkZzC62apJtny1SDGhgWkSQtWFU6iZWp3M
	CtWZMGoxYImpARx/EokJ5otP0R03whAXxyJ1EqslY6IQQbhFT/jpzqgaomxX531AyPxs=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165714-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 165714: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=2f286930a8280f4d817460020110009938f695b6
X-Osstest-Versions-That:
    ovmf=305fd6bee0bfe1602163d1f8841954f84aa31b68
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 21 Oct 2021 20:01:01 +0000

flight 165714 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165714/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 2f286930a8280f4d817460020110009938f695b6
baseline version:
 ovmf                 305fd6bee0bfe1602163d1f8841954f84aa31b68

Last test of basis   165701  2021-10-21 03:40:20 Z    0 days
Testing same since   165714  2021-10-21 15:40:13 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abdul Lateef Attar <AbdulLateef.Attar@amd.com>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   305fd6bee0..2f286930a8  2f286930a8280f4d817460020110009938f695b6 -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Thu Oct 21 22:14:50 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Oct 2021 22:14:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.214607.373217 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdgKM-0001Et-8R; Thu, 21 Oct 2021 22:14:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 214607.373217; Thu, 21 Oct 2021 22:14:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdgKM-0001Em-5S; Thu, 21 Oct 2021 22:14:22 +0000
Received: by outflank-mailman (input) for mailman id 214607;
 Thu, 21 Oct 2021 22:14:21 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mdgKK-0001Ec-Ui; Thu, 21 Oct 2021 22:14:20 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mdgKK-0002Pg-QA; Thu, 21 Oct 2021 22:14:20 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mdgKK-0003bi-J7; Thu, 21 Oct 2021 22:14:20 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mdgKK-0001LJ-Ic; Thu, 21 Oct 2021 22:14:20 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=xKhO3EBQjZdgjn6FdoL56svqJ6rtpCQVQvLs9Vmm/t8=; b=a1JCgxq4t1MrUJ/p92sC3u+hEf
	n6Eh5j4mBdim7zc74dD0eiCoe9OwowLQahXxD3qLTvNL0AsdbjEDi2/w3lEAAAstXuMHt5FqKtIYK
	MEXl2wsK9uYEOaWfmEnE7x3h4Ngoln1BcuyUcga3Xr08ZlVqAEPDvi83CWuBojMMD8cA=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165719-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 165719: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=23ec1ebc8acbfd2bf06f6085a776f0db923f9fa9
X-Osstest-Versions-That:
    xen=98f60e5de00baf650c574c9352bb19aedb082dea
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 21 Oct 2021 22:14:20 +0000

flight 165719 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165719/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  23ec1ebc8acbfd2bf06f6085a776f0db923f9fa9
baseline version:
 xen                  98f60e5de00baf650c574c9352bb19aedb082dea

Last test of basis   165708  2021-10-21 11:01:40 Z    0 days
Testing same since   165719  2021-10-21 18:00:27 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Hongda Deng <hongda.deng@arm.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   98f60e5de0..23ec1ebc8a  23ec1ebc8acbfd2bf06f6085a776f0db923f9fa9 -> smoke


From xen-devel-bounces@lists.xenproject.org Thu Oct 21 23:08:41 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Oct 2021 23:08:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.214616.373231 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdhAp-0006Cd-BI; Thu, 21 Oct 2021 23:08:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 214616.373231; Thu, 21 Oct 2021 23:08:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdhAp-0006CW-7h; Thu, 21 Oct 2021 23:08:35 +0000
Received: by outflank-mailman (input) for mailman id 214616;
 Thu, 21 Oct 2021 23:08:34 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=FXrv=PJ=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1mdhAo-0006CQ-EX
 for xen-devel@lists.xenproject.org; Thu, 21 Oct 2021 23:08:34 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 897cc301-9859-46c3-9059-fec2dc71b232;
 Thu, 21 Oct 2021 23:08:33 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id A7688610EA;
 Thu, 21 Oct 2021 23:08:32 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 897cc301-9859-46c3-9059-fec2dc71b232
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1634857713;
	bh=fu5FSK0nfBCvtW4RDWEEmy3EjlarFXwEa5zENq/8TwM=;
	h=Date:From:To:cc:Subject:From;
	b=BLDqVOmHOLJ+yovmewxxQFBRxWgZwsHG7vUbyGfDZ3ZTrwWq6y5LfOXdyXIWo5j8Q
	 ranG+zS8/QWcX8l66+JCNfaQafsEbjNTFQtkRbEeiCh+Skk8BWVbH7hgK2mtIrdfbv
	 laUew1F7bHw1ulki4/E9P7Z1/mU1k4fVRmNgKVIttZMBZLf4rsFXEBRm3+zIW9/4V/
	 un+Xu3wh5rZJMrRdqarLH9j63kl9JwJ3eAR+fY7L+Pi4+otsBtFQ3sBFYjxUlYqJjn
	 vwHmHVRXRaCohGr6a0dehI4zSEhTGj+rFCgevhcv+pHM01P9vrptxTfSLIX6u7Abe7
	 cnbBQ75654wAg==
Date: Thu, 21 Oct 2021 16:08:31 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: xen-devel@lists.xenproject.org
cc: sstabellini@kernel.org, iwj@xenproject.org, cardoe@cardoe.com, wl@xen.org, 
    andrew.cooper3@citrix.com, anthony.perard@citrix.com
Subject: [PATCH 0/3] automation: introduce an x86_64 Dom0/DomU test
Message-ID: <alpine.DEB.2.21.2110210831470.2311@sstabellini-ThinkPad-T480s>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

Hi all,

This small patch series introduces a new QEMU-based test to Gitlab-CI.
It uses QEMU to emulate an x86_64 machine and run Xen, Dom0 and start a
DomU. It is very similar to the existing qemu-alpine-arm64-gcc test but
based on x86_64 rather than ARM64. I think it is important because all
the other x86_64 gitlab-ci tests we currently have are more narrow and
based on XTF. This would be the first end-to-end x86_64 test in
gitlab-ci.

To make it happen, we need an Alpine Linux rootfs and a Linux kernel.
The first two patches introduce them to gitlab-ci. Note that actually
nothing will get build during gitlab-ci runs, it has already been done
beforehand and uploaded as containers. They only import *existing*
containers and binaries into a gitlab-ci run, thus, they cannot fail.
The risk to the release of the first two patches is as close to zero as
possible.

The last patch is the one introducing a new test. This one can fail.
However, it is a new test at the end of the pipeline: it doesn't impact
the existing tests. In the worst case, the test will fail and the whole
pipeline will be marked as "failed" but looking at the jobs all the
other will continue to be marked as successful. In short, if it fails,
we can simply ignore it. Also, at the moment it is actually succeeding.

Cheers,

Stefano


Stefano Stabellini (3):
      automation: add x86_64 alpine 3.12 test-artifact
      automation: Linux 5.10.74 test-artifact
      automation: add a QEMU based x86_64 Dom0/DomU test

 automation/gitlab-ci/build.yaml                    | 24 ++++++
 automation/gitlab-ci/test.yaml                     | 24 ++++++
 automation/scripts/qemu-alpine-x86_64.sh           | 92 ++++++++++++++++++++++
 automation/tests-artifacts/alpine/3.12.dockerfile  | 68 ++++++++++++++++
 .../tests-artifacts/kernel/5.10.74.dockerfile      | 38 +++++++++
 5 files changed, 246 insertions(+)
 create mode 100644 automation/scripts/qemu-alpine-x86_64.sh
 create mode 100644 automation/tests-artifacts/alpine/3.12.dockerfile
 create mode 100644 automation/tests-artifacts/kernel/5.10.74.dockerfile


From xen-devel-bounces@lists.xenproject.org Thu Oct 21 23:10:53 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Oct 2021 23:10:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.214623.373242 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdhD2-0007Y0-OH; Thu, 21 Oct 2021 23:10:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 214623.373242; Thu, 21 Oct 2021 23:10:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdhD2-0007Xt-LG; Thu, 21 Oct 2021 23:10:52 +0000
Received: by outflank-mailman (input) for mailman id 214623;
 Thu, 21 Oct 2021 23:10:51 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=FXrv=PJ=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1mdhD1-0007Xm-P4
 for xen-devel@lists.xenproject.org; Thu, 21 Oct 2021 23:10:51 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id c14df914-64e6-4d8a-8d74-40ae67ce2d83;
 Thu, 21 Oct 2021 23:10:50 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id 03B7A610EA;
 Thu, 21 Oct 2021 23:10:49 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c14df914-64e6-4d8a-8d74-40ae67ce2d83
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1634857850;
	bh=+84313eWlrORG+Up0MBqnoQCkpcNEW5LOpum5NNFz1Y=;
	h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
	b=CcOiyJckIwNtGdIPBIGB7Ht3P9HLMdYMeshqCtht7U3X6nhqBMkMO1wtkkDZnjnHk
	 Q18oeZuhsVJJRNzn8UFAKtyUKOAG0F/o3BpqP6n7CsfPxkpCyhlYrd2IfYE1IT1lJV
	 rHK5pN2wUM/2qfelhjCvIBCvcj26T6+QLbBJIu5GIGRo5lgcjkNW6GMV0Y65TiLwJB
	 gprCAltQFCoKq7sgb0VaKELDIxDeNzGpc8uDJNi5ofAZBX6+qSgYXE73kh31xVtNyo
	 7ByNiod6ZcpHl9AJo6kDrUCHjDWMiC1TXdGbtUNO0/5FnkTkaM/UJ1nh56S4GoFtZd
	 UHPPpSiDR5lzw==
From: Stefano Stabellini <sstabellini@kernel.org>
To: xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org,
	iwj@xenproject.org,
	cardoe@cardoe.com,
	wl@xen.org,
	andrew.cooper3@citrix.com,
	anthony.perard@citrix.com,
	Stefano Stabellini <stefano.stabellini@xilinx.com>
Subject: [PATCH 1/3] automation: add x86_64 alpine 3.12 test-artifact
Date: Thu, 21 Oct 2021 16:08:37 -0700
Message-Id: <20211021230839.10794-1-sstabellini@kernel.org>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <alpine.DEB.2.21.2110210831470.2311@sstabellini-ThinkPad-T480s>
References: <alpine.DEB.2.21.2110210831470.2311@sstabellini-ThinkPad-T480s>

From: Stefano Stabellini <stefano.stabellini@xilinx.com>

It is the same as the existing ARM64 alpine 3.12 test-artifact. It is
used to export an Alpine rootfs for Dom0 used for testing.

Also add the exporting job to build.yaml so that the binaries can be
used during gitlab-ci runs.

Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>
---
 automation/gitlab-ci/build.yaml               | 13 ++++
 .../tests-artifacts/alpine/3.12.dockerfile    | 68 +++++++++++++++++++
 2 files changed, 81 insertions(+)
 create mode 100644 automation/tests-artifacts/alpine/3.12.dockerfile

diff --git a/automation/gitlab-ci/build.yaml b/automation/gitlab-ci/build.yaml
index d177da1710..76b73beead 100644
--- a/automation/gitlab-ci/build.yaml
+++ b/automation/gitlab-ci/build.yaml
@@ -596,3 +596,16 @@ qemu-system-aarch64-5.2.0-arm64-export:
   tags:
     - arm64
 
+
+# x86_64 test artifacts
+
+alpine-3.12-rootfs-export:
+  stage: build
+  image: registry.gitlab.com/xen-project/xen/tests-artifacts/alpine:3.12
+  script:
+    - mkdir binaries && cp /initrd.tar.gz binaries/initrd.tar.gz
+  artifacts:
+    paths:
+      - binaries/initrd.tar.gz
+  tags:
+    - x86_64
diff --git a/automation/tests-artifacts/alpine/3.12.dockerfile b/automation/tests-artifacts/alpine/3.12.dockerfile
new file mode 100644
index 0000000000..fbc26b9e36
--- /dev/null
+++ b/automation/tests-artifacts/alpine/3.12.dockerfile
@@ -0,0 +1,68 @@
+FROM alpine:3.12
+LABEL maintainer.name="The Xen Project" \
+      maintainer.email="xen-devel@lists.xenproject.org"
+
+ENV USER root
+
+RUN mkdir /build
+WORKDIR /build
+
+RUN \
+  # apk
+  apk update && \
+  \
+  # xen runtime deps
+  apk add musl && \
+  apk add openrc && \
+  apk add busybox && \
+  apk add sudo && \
+  apk add dbus && \
+  apk add bash && \
+  apk add python2 && \
+  # gettext for Xen < 4.13
+  apk add gettext && \
+  apk add zlib && \
+  apk add ncurses && \
+  apk add texinfo && \
+  apk add yajl && \
+  apk add libaio && \
+  apk add xz-dev && \
+  apk add util-linux && \
+  apk add argp-standalone && \
+  apk add libfdt && \
+  apk add glib && \
+  apk add pixman && \
+  apk add curl && \
+  apk add udev && \
+  \
+  # Xen
+  cd / && \
+  # Minimal ramdisk environment in case of cpio output
+  rc-update add udev && \
+  rc-update add udev-trigger && \
+  rc-update add udev-settle && \
+  rc-update add networking sysinit && \
+  rc-update add loopback sysinit && \
+  rc-update add bootmisc boot && \
+  rc-update add devfs sysinit && \
+  rc-update add dmesg sysinit && \
+  rc-update add hostname boot && \
+  rc-update add hwclock boot && \
+  rc-update add hwdrivers sysinit && \
+  rc-update add killprocs shutdown && \
+  rc-update add modloop sysinit && \
+  rc-update add modules boot && \
+  rc-update add mount-ro shutdown && \
+  rc-update add savecache shutdown && \
+  rc-update add sysctl boot && \
+  rc-update add local default && \
+  cp -a /sbin/init /init && \
+  echo "ttyS0" >> /etc/securetty && \
+  echo "hvc0" >> /etc/securetty && \
+  echo "ttyS0::respawn:/sbin/getty -L ttyS0 115200 vt100" >> /etc/inittab && \
+  echo "hvc0::respawn:/sbin/getty -L hvc0 115200 vt100" >> /etc/inittab && \
+  passwd -d "root" root && \
+  \
+  # Create rootfs
+  cd / && \
+  tar cvzf /initrd.tar.gz bin dev etc home init lib mnt opt root sbin usr var
-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Thu Oct 21 23:10:54 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Oct 2021 23:10:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.214624.373252 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdhD3-0007oI-Vm; Thu, 21 Oct 2021 23:10:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 214624.373252; Thu, 21 Oct 2021 23:10:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdhD3-0007o7-Sm; Thu, 21 Oct 2021 23:10:53 +0000
Received: by outflank-mailman (input) for mailman id 214624;
 Thu, 21 Oct 2021 23:10:52 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=FXrv=PJ=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1mdhD2-0007Xs-PJ
 for xen-devel@lists.xenproject.org; Thu, 21 Oct 2021 23:10:52 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 22683254-32c4-11ec-839a-12813bfff9fa;
 Thu, 21 Oct 2021 23:10:51 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id E27646135F;
 Thu, 21 Oct 2021 23:10:50 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 22683254-32c4-11ec-839a-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1634857851;
	bh=anK1IWiowWa3QzIYeypqJDTgghewGZPtlPhXiip9xco=;
	h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
	b=ezVGuG4czhHVfzMxnuxYuS7wD9FUREil9i8auRTkT+zoQoBCO0VmLjTUEUUHKYpRu
	 QwGYf/OT+wQHcHOaSGSehlaR5V+mMqR2AsracPkE51kIRagBcuRypbRXpTc9JQFrNZ
	 shC3AxgbeigS79UThEIytULUs/GtUoddIO53OzbZ42moU7EAIgEOJc+SgrwAMQtbk2
	 hhzGIaC3jtDINfiIZwdcQ1wH4HWifx1aSjCqBV3w9PpgyDQRgeMLnEQTntOiqVotlu
	 uhder5mNnsvtVZw9nw9PVu3S3eIIKsJHuL6o5INJqoAWf2PzyWv3RS5ckhZXEKfGXo
	 a1cNoZNgUFMUg==
From: Stefano Stabellini <sstabellini@kernel.org>
To: xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org,
	iwj@xenproject.org,
	cardoe@cardoe.com,
	wl@xen.org,
	andrew.cooper3@citrix.com,
	anthony.perard@citrix.com,
	Stefano Stabellini <stefano.stabellini@xilinx.com>
Subject: [PATCH 2/3] automation: Linux 5.10.74 test-artifact
Date: Thu, 21 Oct 2021 16:08:38 -0700
Message-Id: <20211021230839.10794-2-sstabellini@kernel.org>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <alpine.DEB.2.21.2110210831470.2311@sstabellini-ThinkPad-T480s>
References: <alpine.DEB.2.21.2110210831470.2311@sstabellini-ThinkPad-T480s>

From: Stefano Stabellini <stefano.stabellini@xilinx.com>

Build a 5.10 kernel to be used as Dom0 and DomU kernel for testing. This
is almost the same as the existing ARM64 recipe for Linux 5.9, the
only differences are:
- upgrade to latest 5.10.x stable
- force Xen modules to built-in (on ARM it was already done by defconfig)

Also add the exporting job to build.yaml so that the binary can be used
during gitlab-ci runs.

Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>
---
 automation/gitlab-ci/build.yaml               | 11 ++++++
 .../tests-artifacts/kernel/5.10.74.dockerfile | 38 +++++++++++++++++++
 2 files changed, 49 insertions(+)
 create mode 100644 automation/tests-artifacts/kernel/5.10.74.dockerfile

diff --git a/automation/gitlab-ci/build.yaml b/automation/gitlab-ci/build.yaml
index 76b73beead..0034c50950 100644
--- a/automation/gitlab-ci/build.yaml
+++ b/automation/gitlab-ci/build.yaml
@@ -609,3 +609,14 @@ alpine-3.12-rootfs-export:
       - binaries/initrd.tar.gz
   tags:
     - x86_64
+
+kernel-5.10.74-export:
+  stage: build
+  image: registry.gitlab.com/xen-project/xen/tests-artifacts/kernel:5.10.74
+  script:
+    - mkdir binaries && cp /bzImage binaries/bzImage
+  artifacts:
+    paths:
+      - binaries/bzImage
+  tags:
+    - x86_64
diff --git a/automation/tests-artifacts/kernel/5.10.74.dockerfile b/automation/tests-artifacts/kernel/5.10.74.dockerfile
new file mode 100644
index 0000000000..f2dbbecf74
--- /dev/null
+++ b/automation/tests-artifacts/kernel/5.10.74.dockerfile
@@ -0,0 +1,38 @@
+FROM debian:unstable
+LABEL maintainer.name="The Xen Project" \
+      maintainer.email="xen-devel@lists.xenproject.org"
+
+ENV DEBIAN_FRONTEND=noninteractive
+ENV LINUX_VERSION=5.10.74
+ENV USER root
+
+RUN mkdir /build
+WORKDIR /build
+
+# build depends
+RUN apt-get update && \
+    apt-get --quiet --yes install \
+        build-essential \
+        libssl-dev \
+        bc \
+        curl \
+        flex \
+        bison \
+        libelf-dev \
+        && \
+    \
+    # Build the kernel
+    curl -fsSLO https://cdn.kernel.org/pub/linux/kernel/v5.x/linux-"$LINUX_VERSION".tar.xz && \
+    tar xvJf linux-"$LINUX_VERSION".tar.xz && \
+    cd linux-"$LINUX_VERSION" && \
+    make defconfig && \
+    make xen.config && \
+    cp .config .config.orig && \
+    cat .config.orig | grep XEN | grep =m |sed 's/=m/=y/g' >> .config && \
+    make -j$(nproc) bzImage && \
+    cp arch/x86/boot/bzImage / && \
+    cd /build && \
+    rm -rf linux-"$LINUX_VERSION"* && \
+    apt-get autoremove -y && \
+    apt-get clean && \
+    rm -rf /var/lib/apt/lists* /tmp/* /var/tmp/*
-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Thu Oct 21 23:10:58 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 21 Oct 2021 23:10:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.214625.373264 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdhD8-00088U-9I; Thu, 21 Oct 2021 23:10:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 214625.373264; Thu, 21 Oct 2021 23:10:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdhD8-00088E-6A; Thu, 21 Oct 2021 23:10:58 +0000
Received: by outflank-mailman (input) for mailman id 214625;
 Thu, 21 Oct 2021 23:10:56 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=FXrv=PJ=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1mdhD6-0007Xm-O5
 for xen-devel@lists.xenproject.org; Thu, 21 Oct 2021 23:10:56 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id c94a67ca-c12f-450b-964a-6adb2a594ca5;
 Thu, 21 Oct 2021 23:10:52 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id 54A6561373;
 Thu, 21 Oct 2021 23:10:51 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c94a67ca-c12f-450b-964a-6adb2a594ca5
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1634857851;
	bh=YswbYpMZWjEYIwFrC7BrzOxPcxKPcBIQvyXpCeVmPQA=;
	h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
	b=q9hclV/CKlksJd4GBd67fnd34oGL+eafXlZ6ngGV3UNBZXAe6kI5Ngm0IbtL42d7o
	 ej2k/qoOnFC3tlWiweDe138r+PXxiiaFvC8hNN+GtvNFoIkjBBJ2Ypqyhhr5mpT4c7
	 FnKFMVav+hH72/iLbN2IlkSidEZNgQyPZEzxi1tPfAgshwHbhs8iRS9ZyRBK8oN5L4
	 TKyKn4s0gSK1gl3nyQr0v6PRpOOAgV0dDUB2pS2ZwEOMFi+FRUyZgbpIEbtyvpAxkX
	 GI/Nw8eMwgq0znpv2WPm/ZXlCud9OiuJs6u73g+ZW/kGrrYZjSzHz7DKroWZvKSmx5
	 xIQsUCKFIt0Dg==
From: Stefano Stabellini <sstabellini@kernel.org>
To: xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org,
	iwj@xenproject.org,
	cardoe@cardoe.com,
	wl@xen.org,
	andrew.cooper3@citrix.com,
	anthony.perard@citrix.com,
	Stefano Stabellini <stefano.stabellini@xilinx.com>
Subject: [PATCH 3/3] automation: add a QEMU based x86_64 Dom0/DomU test
Date: Thu, 21 Oct 2021 16:08:39 -0700
Message-Id: <20211021230839.10794-3-sstabellini@kernel.org>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <alpine.DEB.2.21.2110210831470.2311@sstabellini-ThinkPad-T480s>
References: <alpine.DEB.2.21.2110210831470.2311@sstabellini-ThinkPad-T480s>

From: Stefano Stabellini <stefano.stabellini@xilinx.com>

Introduce a test based on QEMU to run Xen, Dom0 and start a DomU.
This is similar to the existing qemu-alpine-arm64.sh script and test.
The only differences are:
- use Debian's qemu-system-x86_64 (on ARM we build our own)
- use ipxe instead of u-boot and ImageBuilder

Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>
---
 automation/gitlab-ci/test.yaml           | 24 +++++++
 automation/scripts/qemu-alpine-x86_64.sh | 92 ++++++++++++++++++++++++
 2 files changed, 116 insertions(+)
 create mode 100644 automation/scripts/qemu-alpine-x86_64.sh

diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.yaml
index 91a10febbf..c1d67ec4b5 100644
--- a/automation/gitlab-ci/test.yaml
+++ b/automation/gitlab-ci/test.yaml
@@ -47,6 +47,30 @@ qemu-alpine-arm64-gcc:
     - /^coverity-tested\/.*/
     - /^stable-.*/
 
+qemu-alpine-x86_64-gcc:
+  stage: test
+  image: registry.gitlab.com/xen-project/xen/${CONTAINER}
+  variables:
+    CONTAINER: debian:unstable
+  script:
+    - ./automation/scripts/qemu-alpine-x86_64.sh 2>&1 | tee qemu-smoke-arm64.log
+  dependencies:
+    - alpine-3.12-gcc
+    - alpine-3.12-rootfs-export
+    - kernel-5.10.74-export
+  artifacts:
+    paths:
+      - smoke.serial
+      - '*.log'
+    when: always
+  tags:
+    - x86_64
+  except:
+    - master
+    - smoke
+    - /^coverity-tested\/.*/
+    - /^stable-.*/
+
 qemu-smoke-arm64-gcc:
   stage: test
   image: registry.gitlab.com/xen-project/xen/${CONTAINER}
diff --git a/automation/scripts/qemu-alpine-x86_64.sh b/automation/scripts/qemu-alpine-x86_64.sh
new file mode 100644
index 0000000000..41b05210d6
--- /dev/null
+++ b/automation/scripts/qemu-alpine-x86_64.sh
@@ -0,0 +1,92 @@
+#!/bin/bash
+
+set -ex
+
+apt-get -qy update
+apt-get -qy install --no-install-recommends qemu-system-x86 \
+                                            cpio \
+                                            curl \
+                                            busybox-static
+
+# DomU Busybox
+cd binaries
+mkdir -p initrd
+mkdir -p initrd/bin
+mkdir -p initrd/sbin
+mkdir -p initrd/etc
+mkdir -p initrd/dev
+mkdir -p initrd/proc
+mkdir -p initrd/sys
+mkdir -p initrd/lib
+mkdir -p initrd/var
+mkdir -p initrd/mnt
+cp /bin/busybox initrd/bin/busybox
+initrd/bin/busybox --install initrd/bin
+echo "#!/bin/sh
+
+mount -t proc proc /proc
+mount -t sysfs sysfs /sys
+mount -t devtmpfs devtmpfs /dev
+/bin/sh" > initrd/init
+chmod +x initrd/init
+cd initrd
+find . | cpio --create --format='newc' | gzip > ../initrd.cpio.gz
+cd ..
+
+mkdir -p rootfs
+cd rootfs
+tar xvzf ../initrd.tar.gz
+mkdir proc
+mkdir run
+mkdir srv
+mkdir sys
+rm var/run
+cp -ar ../dist/install/* .
+mv ../initrd.cpio.gz ./root
+cp ../bzImage ./root
+echo "name=\"test\"
+memory=512
+vcpus=1
+kernel=\"/root/bzImage\"
+ramdisk=\"/root/initrd.cpio.gz\"
+extra=\"console=hvc0 root=/dev/ram0 rdinit=/bin/sh\"
+" > root/test.cfg
+echo "#!/bin/bash
+
+export LD_LIBRARY_PATH=/usr/local/lib
+bash /etc/init.d/xencommons start
+
+xl list
+
+xl create -c /root/test.cfg
+
+" > etc/local.d/xen.start
+chmod +x etc/local.d/xen.start
+echo "rc_verbose=yes" >> etc/rc.conf
+find . |cpio -H newc -o|gzip > ../xen-rootfs.cpio.gz
+cd ../..
+
+cat >> binaries/pxelinux.0 <<- EOF
+#!ipxe
+
+kernel xen console=com1
+module bzImage console=hvc0
+module xen-rootfs.cpio.gz
+boot
+EOF
+
+# Run the test
+rm -f smoke.serial
+set +e
+timeout -k 1 720 \
+qemu-system-x86_64 \
+    -cpu qemu64,+svm \
+    -m 2G -smp 2 \
+    -monitor none -serial stdio \
+    -nographic \
+    -device virtio-net-pci,netdev=n0 \
+    -netdev user,id=n0,tftp=binaries,bootfile=/pxelinux.0 |& tee smoke.serial
+
+set -e
+(grep -q "Domain-0" smoke.serial && grep -q "BusyBox" smoke.serial) || exit 1
+exit 0
-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Fri Oct 22 01:52:23 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Oct 2021 01:52:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.214656.373287 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdjj5-0000Vq-3J; Fri, 22 Oct 2021 01:52:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 214656.373287; Fri, 22 Oct 2021 01:52:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdjj4-0000Vi-Ul; Fri, 22 Oct 2021 01:52:06 +0000
Received: by outflank-mailman (input) for mailman id 214656;
 Fri, 22 Oct 2021 01:52:05 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mdjj2-0000VY-WB; Fri, 22 Oct 2021 01:52:05 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mdjj2-00089n-MW; Fri, 22 Oct 2021 01:52:04 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mdjj2-0002PI-Bw; Fri, 22 Oct 2021 01:52:04 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mdjj2-0002ww-BK; Fri, 22 Oct 2021 01:52:04 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=usWzOIUKvDjD576vUqnhlZ25+h4VRfaJEawBLIDdBQ0=; b=d0MKGIsGI+BJvjHUhuNngyKd6F
	OzhGo93ekf065SPkJnFZpHPWuySAbVqiJzsej3+rWVoY8DfpwqRShblIMJJibC1oX37nbD3mvMBki
	sh38Vz5a4ntzf55vI6yISidVn3GYsqF0TxDKnX8PGiHxv19GM1LWIgSdY8e/cNE9mp4I=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165721-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 165721: regressions - FAIL
X-Osstest-Failures:
    qemu-mainline:build-i386:xen-build:fail:regression
    qemu-mainline:build-i386-xsm:xen-build:fail:regression
    qemu-mainline:build-armhf:xen-build:fail:regression
    qemu-mainline:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-amd:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-pair:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-freebsd10-i386:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-freebsd10-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-coresched-i386-xl:build-check(1):blocked:nonblocking
    qemu-mainline:build-armhf-libvirt:build-check(1):blocked:nonblocking
    qemu-mainline:build-i386-libvirt:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-intel:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-shadow:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-vhd:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=e016b58f6ed2e07bde45da7d6792b6c93879a3cf
X-Osstest-Versions-That:
    qemuu=50352cce138ef3b30c1cda28a4df68fff5da3202
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 22 Oct 2021 01:52:04 +0000

flight 165721 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165721/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-i386                    6 xen-build                fail REGR. vs. 165682
 build-i386-xsm                6 xen-build                fail REGR. vs. 165682
 build-armhf                   6 xen-build                fail REGR. vs. 165682

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl           1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-credit2   1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-cubietruck  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-multivcpu  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-rtds      1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-vhd       1 build-check(1)               blocked  n/a
 test-amd64-i386-qemuu-rhel6hvm-amd  1 build-check(1)               blocked n/a
 test-amd64-i386-pair          1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-freebsd10-i386  1 build-check(1)               blocked  n/a
 test-amd64-i386-freebsd10-amd64  1 build-check(1)               blocked  n/a
 test-amd64-coresched-i386-xl  1 build-check(1)               blocked  n/a
 build-armhf-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-credit1   1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-arndale   1 build-check(1)               blocked  n/a
 test-amd64-i386-qemuu-rhel6hvm-intel  1 build-check(1)             blocked n/a
 test-amd64-i386-xl            1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-pvshim     1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-qemuu-debianhvm-amd64  1 build-check(1)         blocked n/a
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow  1 build-check(1)  blocked n/a
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm  1 build-check(1)      blocked n/a
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 1 build-check(1) blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a
 test-amd64-i386-xl-qemuu-win7-amd64  1 build-check(1)              blocked n/a
 test-amd64-i386-xl-qemuu-ws16-amd64  1 build-check(1)              blocked n/a
 test-amd64-i386-xl-shadow     1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-vhd        1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-xsm        1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165682
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165682
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165682
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 qemuu                e016b58f6ed2e07bde45da7d6792b6c93879a3cf
baseline version:
 qemuu                50352cce138ef3b30c1cda28a4df68fff5da3202

Last test of basis   165682  2021-10-19 21:09:14 Z    2 days
Failing since        165694  2021-10-20 18:09:12 Z    1 days    3 attempts
Testing same since   165721  2021-10-21 18:38:04 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Ani Sinha <ani@anisinha.ca>
  BALATON Zoltan <balaton@eik.bme.hu>
  Cédric Le Goater <clg@kaod.org>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  David Gibson <david@gibson.dropbear.id.au>
  David Hildenbrand <david@redhat.com>
  Eric Auger <eric.auger@redhat.com>
  Eugenio Pérez <eperezma@redhat.com>
  Gustavo Romero <gromero@linux.ibm.com>
  Igor Mammedov <imammedo@redhat.com>
  Jason Wang <jasowang@redhat.com>
  Laurent Vivier <lvivier@redhat.com>
  Matheus Ferst <matheus.ferst@eldorado.org.br>
  Mathieu Poirier <mathieu.poirier@linaro.org>
  Michael S. Tsirkin <mst@redhat.com>
  Philippe Mathieu-Daudé <f4bug@amsat.org>
  Philippe Mathieu-Daudé <philmd@redhat.com>
  Richard Henderson <richard.henderson@linaro.org>
  Stefan Hajnoczi <stefanha@redhat.com>
  Thomas Huth <thuth@redhat.com>
  Xueming Li <xuemingl@nvidia.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               fail    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          blocked 
 test-amd64-i386-xl                                           blocked 
 test-amd64-coresched-i386-xl                                 blocked 
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  blocked 
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       blocked 
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           blocked 
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     blocked 
 test-amd64-i386-freebsd10-amd64                              blocked 
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          blocked 
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          blocked 
 test-armhf-armhf-xl-arndale                                  blocked 
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  blocked 
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  blocked 
 test-armhf-armhf-xl-cubietruck                               blocked 
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         blocked 
 test-amd64-i386-freebsd10-i386                               blocked 
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         blocked 
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                blocked 
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         blocked 
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 blocked 
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    blocked 
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     blocked 
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              blocked 
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    blocked 
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      blocked 
 test-amd64-i386-xl-vhd                                       blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 1869 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Oct 22 03:11:04 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Oct 2021 03:11:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.214667.373301 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdkxE-0008Oe-0B; Fri, 22 Oct 2021 03:10:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 214667.373301; Fri, 22 Oct 2021 03:10:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdkxD-0008OX-TU; Fri, 22 Oct 2021 03:10:47 +0000
Received: by outflank-mailman (input) for mailman id 214667;
 Fri, 22 Oct 2021 03:10:46 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mdkxC-0008ON-SE; Fri, 22 Oct 2021 03:10:46 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mdkxC-0001S6-GY; Fri, 22 Oct 2021 03:10:46 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mdkxC-0004uc-1v; Fri, 22 Oct 2021 03:10:46 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mdkxC-0007rD-1Q; Fri, 22 Oct 2021 03:10:46 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=4YuqAwVCdlYdCSnmJyMedxCHkjfoOYl+I1pAqNPDGfE=; b=uiVsTO/vcTHB6wPx4YqweD1tot
	OxD+OALnY+W0ZppLAZ6Pu7KuZAZkAbfsiqK2TyvCergXTiaKxyEBjUWYbQZLEU/RRsVJeOQzDc/3M
	fTWkFSrsVtU/7JK6MWnaByIxojrSyA7Ve122rxL2a833s3/RJU6CU9fLrxIse4RYlyQA=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165712-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 165712: regressions - FAIL
X-Osstest-Failures:
    xen-unstable:test-amd64-amd64-examine:memdisk-try-append:fail:regression
    xen-unstable:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=98f60e5de00baf650c574c9352bb19aedb082dea
X-Osstest-Versions-That:
    xen=118da371d1ff5d8432fa299544b1ea5e7e3710f0
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 22 Oct 2021 03:10:46 +0000

flight 165712 xen-unstable real [real]
flight 165727 xen-unstable real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/165712/
http://logs.test-lab.xenproject.org/osstest/logs/165727/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-amd64-amd64-examine      4 memdisk-try-append       fail REGR. vs. 165699

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-rtds     20 guest-localmigrate/x10       fail  like 165699
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 165699
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 165699
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165699
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165699
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 165699
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 165699
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 165699
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 165699
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 165699
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 165699
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165699
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 165699
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  98f60e5de00baf650c574c9352bb19aedb082dea
baseline version:
 xen                  118da371d1ff5d8432fa299544b1ea5e7e3710f0

Last test of basis   165699  2021-10-21 03:03:05 Z    1 days
Testing same since   165712  2021-10-21 15:08:08 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Julien Grall <jgrall@amazon.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     fail    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

------------------------------------------------------------
commit 98f60e5de00baf650c574c9352bb19aedb082dea
Author: Julien Grall <jgrall@amazon.com>
Date:   Wed Oct 20 14:45:19 2021 +0000

    tools/xenstored: Ignore domain we were unable to restore
    
    Commit 939775cfd3 "handle dying domains in live update" was meant to
    handle gracefully dying domain. However, the @releaseDomain watch
    will end up to be sent as soon as we finished to restore Xenstored
    state.
    
    This may be before Xen reports the domain to be dying (such as if
    the guest decided to revoke access to the xenstore page). Consequently
    daemon like xenconsoled will not clean-up the domain and it will be
    left as a zombie.
    
    To avoid the problem, mark the connection as ignored. This also
    requires to tweak conn_can_write() and conn_can_read() to prevent
    dereferencing a NULL pointer (the interface will not mapped).
    
    The check conn->is_ignored was originally added after the callbacks
    because the helpers for a socket connection may close the fd. However,
    ignore_connection() will close a socket connection directly. So it is
    fine to do the re-order.
    
    Signed-off-by: Julien Grall <jgrall@amazon.com>
    Release-Acked-by: Ian Jackson <iwj@xenproject.org>
    Reviewed-by: Juergen Gross <jgross@suse.com>
    Reviewed-by: Luca Fancellu <luca.fancellu@arm.com>
(qemu changes not included)


From xen-devel-bounces@lists.xenproject.org Fri Oct 22 03:59:50 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Oct 2021 03:59:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.214690.373345 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdliZ-0004F8-De; Fri, 22 Oct 2021 03:59:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 214690.373345; Fri, 22 Oct 2021 03:59:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdliZ-0004F1-9d; Fri, 22 Oct 2021 03:59:43 +0000
Received: by outflank-mailman (input) for mailman id 214690;
 Fri, 22 Oct 2021 03:59:42 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=rhvd=PK=arm.com=Hongda.Deng@srs-us1.protection.inumbo.net>)
 id 1mdliX-0004Ev-T6
 for xen-devel@lists.xenproject.org; Fri, 22 Oct 2021 03:59:42 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com (unknown
 [40.107.7.44]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 15c49f2a-4046-450b-ab12-c911635d9163;
 Fri, 22 Oct 2021 03:59:38 +0000 (UTC)
Received: from AS9PR06CA0014.eurprd06.prod.outlook.com (2603:10a6:20b:462::8)
 by VI1PR08MB2654.eurprd08.prod.outlook.com (2603:10a6:802:25::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.18; Fri, 22 Oct
 2021 03:59:35 +0000
Received: from VE1EUR03FT019.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:462:cafe::a0) by AS9PR06CA0014.outlook.office365.com
 (2603:10a6:20b:462::8) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.18 via Frontend
 Transport; Fri, 22 Oct 2021 03:59:34 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT019.mail.protection.outlook.com (10.152.18.153) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4628.16 via Frontend Transport; Fri, 22 Oct 2021 03:59:34 +0000
Received: ("Tessian outbound 8e26f7114b75:v103");
 Fri, 22 Oct 2021 03:59:34 +0000
Received: from c25474b878db.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 24968092-B4EE-48C0-8D08-96E731F2FBC7.1; 
 Fri, 22 Oct 2021 03:59:28 +0000
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id c25474b878db.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 22 Oct 2021 03:59:28 +0000
Received: from VE1PR08MB5677.eurprd08.prod.outlook.com (2603:10a6:800:1ab::17)
 by VE1PR08MB5231.eurprd08.prod.outlook.com (2603:10a6:802:a1::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.18; Fri, 22 Oct
 2021 03:59:24 +0000
Received: from VE1PR08MB5677.eurprd08.prod.outlook.com
 ([fe80::d810:52a3:dce3:4d06]) by VE1PR08MB5677.eurprd08.prod.outlook.com
 ([fe80::d810:52a3:dce3:4d06%7]) with mapi id 15.20.4608.018; Fri, 22 Oct 2021
 03:59:24 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 15c49f2a-4046-450b-ab12-c911635d9163
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=+Z6jLoJFWKltuxsykmIa1UGsMxyjOXZSLrfdGE4TlOw=;
 b=sTUEfvNdFNahQnUH2z//kHjJu8sKTyE8Wpa+LyKf0V/dEbjOa/bynDS1Z36kDcFkGIFZI1AflB6KUFYieerjsqMX03S2IUAdckV3gWvD6WmKkKYh7sCShdGVnfRYy3UvIP79nVRDzp5sp9rGQf2JZVQuvFP8HTrSXktDdp0mIz4=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was
 verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass
 action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Gegl8JnWOD2jBdBGK/ACzYaLVHoZYZKJSCcaVRH+BG1NtQSkSPtEOr8zVMGFf3E11P5JNeIR/T0y6Gxnu9ud8Itykzk1+cFNcToGMQjU1qgGX5n+BVGlYwGZv4EEe9MvHByIdEa3Z2plriXPgeoiVdfaMnD4MiLn3IC+nYM+egcPEhKHrLygpmb8I7qwSZhs9BxRXlThGKUA89p1KRhSQM49jaTW/HuzSt5PSlIKU4dOeb3NlXaUf66of/3GRV/WWPbCBX1ootFwgNOiYPe1hStfngZ4p0LY+wq6BHUZzWhtUka3s658LtQnSx4GydL1T4KJ73bWjeJWAr9EGD8IgA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=+Z6jLoJFWKltuxsykmIa1UGsMxyjOXZSLrfdGE4TlOw=;
 b=TYE3rR58ZUrxHpMJPo/JsdBMpSks1UkeI9MVTeeeRANIEw8hqkDpzVKRk/8AYXNdT9DabPUrzN0OhVYeByDuXXe7cEs3MpQI+LkIdtI6S7SvbKXJVOeUy9DSni74wi/fGTUjPepsxfcm+TFjrmNMwz+piLQwvu8C9g4qRg//g7C3lXqPqExApZrCxDJjp5QS6IhfzXtWrcuJZ1RDfmrewPMhtqfQYE1vG288k+Mj3peyRED0VYYVGRYBNJXQfEVTMhlo2Fr+V5TgojIbu2tsgApVceud5iWE6XPLjh4uoiHaUpWE7iCWs6PyG4GOiKLg2z9alln0C3CHjxdorlDY2Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=+Z6jLoJFWKltuxsykmIa1UGsMxyjOXZSLrfdGE4TlOw=;
 b=sTUEfvNdFNahQnUH2z//kHjJu8sKTyE8Wpa+LyKf0V/dEbjOa/bynDS1Z36kDcFkGIFZI1AflB6KUFYieerjsqMX03S2IUAdckV3gWvD6WmKkKYh7sCShdGVnfRYy3UvIP79nVRDzp5sp9rGQf2JZVQuvFP8HTrSXktDdp0mIz4=
From: Hongda Deng <Hongda.Deng@arm.com>
To: Julien Grall <julien@xen.org>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, "sstabellini@kernel.org"
	<sstabellini@kernel.org>
CC: Bertrand Marquis <Bertrand.Marquis@arm.com>, Wei Chen <Wei.Chen@arm.com>,
	Ian Jackson <iwj@xenproject.org>
Subject: RE: [for-4.16] Re: [PATCH v4] xen/arm: vgic: Ignore write access to
 ICPENDR*
Thread-Topic: [for-4.16] Re: [PATCH v4] xen/arm: vgic: Ignore write access to
 ICPENDR*
Thread-Index: AQHXxnOw130F/XXfpEO1c6gHtggnravdj7eAgAAiDICAALKBsA==
Date: Fri, 22 Oct 2021 03:59:23 +0000
Message-ID:
 <VE1PR08MB5677A51519ADA1EE66D19C58E6809@VE1PR08MB5677.eurprd08.prod.outlook.com>
References: <20211021120319.2394-1-Hongda.Deng@arm.com>
 <e7804793-82a4-b2ac-0146-fe5bbed2bfbf@xen.org>
 <5bb464f6-0b71-d419-b05c-82abdebf85e3@xen.org>
In-Reply-To: <5bb464f6-0b71-d419-b05c-82abdebf85e3@xen.org>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: 631D0F1D41B7B744AEBE04DC34A20CE2.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: f8ba0f3c-3085-4829-2b37-08d995105c10
x-ms-traffictypediagnostic: VE1PR08MB5231:|VI1PR08MB2654:
X-Microsoft-Antispam-PRVS:
	<VI1PR08MB2654F068F65CEB2A1F9667B9E6809@VI1PR08MB2654.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:9508;OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 355MZ06+0Ns9NgGAF3ItzbJLCZUZtE+C0nTloFuXsDxvmizkiJEa5XW/8m/AMKpbKLo8/Umm77cZEBSC2CtNqe/q89LMfT5rh7a9xKCfKsr1c3zWmjWwJvsAr0Cv9wQBC0pa8bPdZgqvdo+J9hFmR0vEagEPEsskWKD8vJfHin/2dMKqcjL0ODXv7NdasEoManHNvBDvlE6ZXfwUbKZoctn/fKhXYiW29OOEGPYEDn2smz+GXY1suC9h0qQI5XdDJnUFGEIfzH0CxPWarCJxQEC679K/vHha7oxmM1xlLgyfrjD/fHb9/AKZ5akwj8EJOr3qVLOilc4/CkYm0xvUGT7b//EbtvPs9AHwtq0SbZNLab5R0yC0uU/IP5QFnnY2N35geaicJFI+Ics0xqB/dyJ1dlAOeDyXXRHFkPpnt5rSca9mut10wNyz8k0m2rKiEAM2XWcqEawi9JbWvYbB+4RapXKSE2/BbVoF1kA7ucSq+TZkJcx4+jxlVqQ0sFu9mvOe4KGcJKTyNK37SFQfzuwhqrbC/ck4ZEb8CUKwIYQhrnwNRkBNOHx123NymQryZEY6sJpKeS8SE671WSv5kUnq5ySA2A1G8ATDo6OzQtlxE930i+tmRD4TRFp0RsFYPl4w8YhzHOC3k9ln7ymI9IUkp3pwFts3M1Fclewfxzir8V1h55Gh8j5SWdBbZW8onIeDNyWjcJReop2G49HpwHu39sMFeZtxpA/9RTI+/K5AOX5VaLBRnI4ZmU+e563+wvTGkITuUG+jG+3VNrcuYD+lKENWV0rNuXOZKAEYg9E=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR08MB5677.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(122000001)(26005)(38100700002)(52536014)(5660300002)(7696005)(54906003)(316002)(83380400001)(4326008)(186003)(66946007)(33656002)(110136005)(9686003)(55016002)(6506007)(64756008)(66446008)(2906002)(508600001)(53546011)(66556008)(86362001)(38070700005)(66476007)(8936002)(8676002)(76116006)(71200400001)(966005);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5231
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT019.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	a9b53db0-1bef-412a-deb5-08d9951055da
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	EzSBhR4TpAtj4+EyWGbsOC9nI5xPg/Mx3vvnm6xkl7f1vXBgcyxFoNiKXnnBEvxUQy+TDJwxzFHTXIeKPbo7P1oZQ9L1D3BGmG+uRagJS7Eqj/9Zwo/V+jmayTmaUssA1tiTn82yKzegYwZ6EJSCW9Ns54ao5telsLLtglygfr0ru90xGVl4CPg04N53gdcgvidGB1Q2ovXFvqYVHi66ijHqM5KMsCKIQj+aB9PdEERt3GzE6l0z89eyZI4gPcDqpEc9T8JpCOdHjGSeEhFDJJGw+PDfLLlY1iojTLE9vmsS/ynDAZDuiwm/Xi7cXKEf2mjM3LpJHzhd4Y8atpDXLJq1avCdyG2rWiLNWgQx7tflrU97Ftg7Cz+64Sospt6oiBxtFmcnIPm9mWBVyc6wuWAoKGIsUrkUegMlVeUfM5SsxFWR9qZpI/P6cZO1A44NNujHI2y8+R0Hwgw2+05JxMJfc2HgrFL6aGZHwdRZHkJBHpI5yR7xoQzaODDScemVkXxrbk3wAHRp4KCnUU0k6nX1+TGM0O+zZ8X7Oj4ysDkj3wHRLjfHgCe2e0IV8+3GJxnJDE74TGQxGi/Lb7RnNKzKKqW8Lc/NPxiG3vra3sfBaLeLVhaV/rJ6B6J7I6hGuJ2Jw5OvuSqpd0UQzfdSVJrxfJSdeh5HLAVCjL/3I9puo976ODC61+nFOTdtqT9gtTHU533+Ss4f5Wo36x8i5bY7ssBdztTdfgKky0O25s0Y4EJcKzgiyBfi4jz2rDtuGyDQLhd2yA8P7QCglcZLl3nqUG6KY6ompmPsXKCaf48=
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(316002)(966005)(52536014)(8936002)(110136005)(9686003)(186003)(8676002)(26005)(356005)(4326008)(70586007)(5660300002)(83380400001)(54906003)(2906002)(36860700001)(55016002)(7696005)(6506007)(33656002)(82310400003)(53546011)(47076005)(81166007)(86362001)(70206006)(336012)(508600001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Oct 2021 03:59:34.4445
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: f8ba0f3c-3085-4829-2b37-08d995105c10
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT019.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB2654

SGksDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogSnVsaWVuIEdyYWxs
IDxqdWxpZW5AeGVuLm9yZz4NCj4gU2VudDogMjAyMeW5tDEw5pyIMjLml6UgMToxNg0KPiBUbzog
SG9uZ2RhIERlbmcgPEhvbmdkYS5EZW5nQGFybS5jb20+OyB4ZW4tZGV2ZWxAbGlzdHMueGVucHJv
amVjdC5vcmc7DQo+IHNzdGFiZWxsaW5pQGtlcm5lbC5vcmcNCj4gQ2M6IEJlcnRyYW5kIE1hcnF1
aXMgPEJlcnRyYW5kLk1hcnF1aXNAYXJtLmNvbT47IFdlaSBDaGVuDQo+IDxXZWkuQ2hlbkBhcm0u
Y29tPjsgSWFuIEphY2tzb24gPGl3akB4ZW5wcm9qZWN0Lm9yZz4NCj4gU3ViamVjdDogUmU6IFtm
b3ItNC4xNl0gUmU6IFtQQVRDSCB2NF0geGVuL2FybTogdmdpYzogSWdub3JlIHdyaXRlIGFjY2Vz
cyB0bw0KPiBJQ1BFTkRSKg0KPiANCj4gDQo+IA0KPiBPbiAyMS8xMC8yMDIxIDE2OjE0LCBKdWxp
ZW4gR3JhbGwgd3JvdGU6DQo+ID4gT24gdGhlIHByZXZpb3VzIHZlcnNpb24sIHdlIGRpc2N1c3Nl
ZCB0byBpbmNsdWRlIHRoZSBwYXRjaCBmb3IgNC4xNi4gU28NCj4gPiBwbGVhc2UgdGFnIGl0IHdp
dGggZm9yLTQuMTYgYW5kIENDIHRoZSBSZWxlYXNlIE1hbmFnZXIgKElhbikuIFRoaXMgd2lsbA0K
PiA+IGhlbHAgaGltIHRvIHRyYWNrIHdoYXQncyBvdXRzdGFuZGluZyBmb3IgdGhlIHJlbGVhc2Uu
DQo+ID4NCj4gPiBPbiAyMS8xMC8yMDIxIDEzOjAzLCBIb25nZGEgRGVuZyB3cm90ZToNCj4gPj4g
Q3VycmVudGx5LCBYZW4gd2lsbCByZXR1cm4gSU8gdW5oYW5kbGVkIHdoZW4gZ3Vlc3RzIHdyaXRl
IElDUEVORFIqDQo+ID4+IHZpcnR1YWwgcmVnaXN0ZXJzLCB3aGljaCB3aWxsIHJhaXNlIGEgZGF0
YSBhYm9ydCBpbnNpZGUgdGhlIGd1ZXN0Lg0KPiA+PiBGb3IgTGludXggZ3Vlc3QsIHRoZXNlIHZp
cnR1YWwgcmVnaXN0ZXJzIHdpbGwgbm90IGJlIGFjY2Vzc2VkLiBCdXQNCj4gPj4gZm9yIFplcGh5
ciwgdGhlc2UgdmlydHVhbCByZWdpc3RlcnMgd2lsbCBiZSBhY2Nlc3NlZCBkdXJpbmcgdGhlDQo+
ID4+IGluaXRpYWxpemF0aW9uLiBaZXBoeXIgZ3Vlc3Qgd2lsbCBnZXQgYW4gSU8gZGF0YSBhYm9y
dCBhbmQgY3Jhc2guDQo+ID4+IEVtdWxhdGluZyBJQ1BFTkRSIGlzIG5vdCBlYXN5IHdpdGggdGhl
IGV4aXN0aW5nIHZHSUMsIHRoaXMgcGF0Y2gNCj4gPj4gcmV3b3JrcyB0aGUgZW11bGF0aW9uIHRv
IGlnbm9yZSB3cml0ZSBhY2Nlc3MgdG8gSUNQRU5EUiogdmlydHVhbA0KPiA+PiByZWdpc3RlcnMg
YW5kIHByaW50IGEgbWVzc2FnZSBhYm91dCB3aGV0aGVyIHRoZXkgYXJlIGFscmVhZHkgcGVuZGlu
Zw0KPiA+PiBpbnN0ZWFkIG9mIHJldHVybmluZyB1bmhhbmRsZWQuDQo+ID4+IE1vcmUgZGV0YWls
cyBjYW4gYmUgZm91bmQgYXQgWzFdLg0KPiA+Pg0KPiA+PiBbMV0gaHR0cHM6Ly9naXRodWIuY29t
L3plcGh5cnByb2plY3QtcnRvcy96ZXBoeXIvYmxvYi9lYWY2Y2Y3NDVkZjM4MDdlNmUNCj4gPj4g
Y2M5NDFjM2EzMGRlNmMxNzlhZTM1OS9kcml2ZXJzL2ludGVycnVwdF9jb250cm9sbGVyL2ludGNf
Z2ljdjMuYyNMMjc0DQo+ID4+DQo+ID4+IFNpZ25lZC1vZmYtYnk6IEhvbmdkYSBEZW5nIDxob25n
ZGEuZGVuZ0Bhcm0uY29tPg0KPiA+DQo+ID4gV2hpbGUgSSBhZ3JlZSB0aGUgUmV2aWV3ZWQtYnkg
ZnJvbSBCZXJ0cmFuZCBzaG91bGQgYmUgZHJvcHBlZCwgdGhlDQo+ID4gUmVsZWFzZS1hY2tlZC1i
eSBmcm9tIElhbiBpcyBzaW1wbHkgYSB3YXkgdG8gc2F5IGhlIGlzIGhhcHB5IHRvIGluY2x1ZGUN
Cj4gPiB0aGUgcGF0Y2ggZm9yIDQuMTYuIFNvIHRoaXMgc2hvdWxkIGhhdmUgYmVlbiByZXRhaW4u
DQo+ID4NCj4gPiBUaGUgcGF0Y2ggbG9va3MgZ29vZCB0byBtZSwgc28gSSBjYW4gYWRkIElhbidz
IHRhZyBvbiBjb21taXQ6DQo+ID4NCj4gPiBSZXZpZXdlZC1ieTogSnVsaWVuIEdyYWxsIDxqZ3Jh
bGxAYW1hem9uLmNvbT4NCj4gDQo+IENvbW1pdHRlZC4NCj4gDQo+IENoZWVycywNCj4gDQo+IC0t
DQo+IEp1bGllbiBHcmFsbA0KDQpUaGFuayB5b3UgIQ0KDQpJIGp1c3QgbGVhcm5lZCB0aGF0IEkg
c2hvdWxkIGFkZCAiUmV2aWV3ZWQtYnkiIGFuZCAiIFJlbGVhc2UtYWNrZWQtYnkiIHRhZ3MgYmFz
ZWQgb24gcHJldmlvdXMNCnBhdGNoZXMsIHNvcnJ5IGZvciB0aGF0LCBJIHdpbGwga2VlcCBpdCBp
biBtaW5kLg0KDQpDaGVlcnMsDQoNCi0tLQ0KSG9uZ2RhDQo=


From xen-devel-bounces@lists.xenproject.org Fri Oct 22 04:10:11 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Oct 2021 04:10:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.214568.373359 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdlse-0006Z1-FC; Fri, 22 Oct 2021 04:10:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 214568.373359; Fri, 22 Oct 2021 04:10:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdlse-0006Yu-BP; Fri, 22 Oct 2021 04:10:08 +0000
Received: by outflank-mailman (input) for mailman id 214568;
 Thu, 21 Oct 2021 18:15:28 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=IF2L=PJ=intel.com=lucas.demarchi@srs-us1.protection.inumbo.net>)
 id 1mdcbA-00047r-O1
 for xen-devel@lists.xenproject.org; Thu, 21 Oct 2021 18:15:28 +0000
Received: from mga01.intel.com (unknown [192.55.52.88])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id dcd78c22-329a-11ec-8389-12813bfff9fa;
 Thu, 21 Oct 2021 18:15:26 +0000 (UTC)
Received: from orsmga001.jf.intel.com ([10.7.209.18])
 by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 21 Oct 2021 11:15:19 -0700
Received: from lucas-s2600cw.jf.intel.com ([10.165.21.202])
 by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 21 Oct 2021 11:15:19 -0700
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: dcd78c22-329a-11ec-8389-12813bfff9fa
X-IronPort-AV: E=McAfee;i="6200,9189,10144"; a="252606741"
X-IronPort-AV: E=Sophos;i="5.87,170,1631602800"; 
   d="scan'208";a="252606741"
X-IronPort-AV: E=Sophos;i="5.87,170,1631602800"; 
   d="scan'208";a="527582103"
From: Lucas De Marchi <lucas.demarchi@intel.com>
To: intel-gfx@lists.freedesktop.org,
	dri-devel@lists.freedesktop.org,
	x86@kernel.org
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	linux-kernel@vger.kernel.org,
	linux-arch@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: [PATCH 0/2] Nuke PAGE_KERNEL_IO
Date: Thu, 21 Oct 2021 11:15:09 -0700
Message-Id: <20211021181511.1533377-1-lucas.demarchi@intel.com>
X-Mailer: git-send-email 2.33.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Last user of PAGE_KERNEL_IO is the i915 driver. While removing it from
there as we seek to bring the driver to other architectures, Daniel
suggested that we could finish the cleanup and remove it altogether,
through the tip tree. So here I'm sending both commits needed for that.

Lucas De Marchi (2):
  drm/i915/gem: stop using PAGE_KERNEL_IO
  x86/mm: nuke PAGE_KERNEL_IO

 arch/x86/include/asm/fixmap.h             | 2 +-
 arch/x86/include/asm/pgtable_types.h      | 7 -------
 arch/x86/mm/ioremap.c                     | 2 +-
 arch/x86/xen/setup.c                      | 2 +-
 drivers/gpu/drm/i915/gem/i915_gem_pages.c | 4 ++--
 include/asm-generic/fixmap.h              | 2 +-
 6 files changed, 6 insertions(+), 13 deletions(-)

-- 
2.33.1



From xen-devel-bounces@lists.xenproject.org Fri Oct 22 04:10:11 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Oct 2021 04:10:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.214572.373370 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdlsf-0006iy-2Z; Fri, 22 Oct 2021 04:10:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 214572.373370; Fri, 22 Oct 2021 04:10:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdlse-0006fO-Qv; Fri, 22 Oct 2021 04:10:08 +0000
Received: by outflank-mailman (input) for mailman id 214572;
 Thu, 21 Oct 2021 18:15:38 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=IF2L=PJ=intel.com=lucas.demarchi@srs-us1.protection.inumbo.net>)
 id 1mdcbK-00047r-L5
 for xen-devel@lists.xenproject.org; Thu, 21 Oct 2021 18:15:38 +0000
Received: from mga01.intel.com (unknown [192.55.52.88])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id deddc37e-329a-11ec-8389-12813bfff9fa;
 Thu, 21 Oct 2021 18:15:29 +0000 (UTC)
Received: from orsmga001.jf.intel.com ([10.7.209.18])
 by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 21 Oct 2021 11:15:19 -0700
Received: from lucas-s2600cw.jf.intel.com ([10.165.21.202])
 by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 21 Oct 2021 11:15:19 -0700
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: deddc37e-329a-11ec-8389-12813bfff9fa
X-IronPort-AV: E=McAfee;i="6200,9189,10144"; a="252606745"
X-IronPort-AV: E=Sophos;i="5.87,170,1631602800"; 
   d="scan'208";a="252606745"
X-IronPort-AV: E=Sophos;i="5.87,170,1631602800"; 
   d="scan'208";a="527582109"
From: Lucas De Marchi <lucas.demarchi@intel.com>
To: intel-gfx@lists.freedesktop.org,
	dri-devel@lists.freedesktop.org,
	x86@kernel.org
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	linux-kernel@vger.kernel.org,
	linux-arch@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: [PATCH 2/2] x86/mm: nuke PAGE_KERNEL_IO
Date: Thu, 21 Oct 2021 11:15:11 -0700
Message-Id: <20211021181511.1533377-3-lucas.demarchi@intel.com>
X-Mailer: git-send-email 2.33.1
In-Reply-To: <20211021181511.1533377-1-lucas.demarchi@intel.com>
References: <20211021181511.1533377-1-lucas.demarchi@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

PAGE_KERNEL_IO is only defined for x86 and nowadays is the same as
PAGE_KERNEL. It was different for some time, OR'ing a `_PAGE_IOMAP` flag
in commit be43d72835ba ("x86: add _PAGE_IOMAP pte flag for IO
mappings").  This got removed in commit f955371ca9d3 ("x86: remove the
Xen-specific _PAGE_IOMAP PTE flag"), so today they are just the same.

With the last users outside arch/x86 being remove we can now remove
PAGE_KERNEL_IO.

Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
---
 arch/x86/include/asm/fixmap.h        | 2 +-
 arch/x86/include/asm/pgtable_types.h | 7 -------
 arch/x86/mm/ioremap.c                | 2 +-
 arch/x86/xen/setup.c                 | 2 +-
 include/asm-generic/fixmap.h         | 2 +-
 5 files changed, 4 insertions(+), 11 deletions(-)

diff --git a/arch/x86/include/asm/fixmap.h b/arch/x86/include/asm/fixmap.h
index d0dcefb5cc59..5e186a69db10 100644
--- a/arch/x86/include/asm/fixmap.h
+++ b/arch/x86/include/asm/fixmap.h
@@ -173,7 +173,7 @@ static inline void __set_fixmap(enum fixed_addresses idx,
  * supported for MMIO addresses, so make sure that the memory encryption
  * mask is not part of the page attributes.
  */
-#define FIXMAP_PAGE_NOCACHE PAGE_KERNEL_IO_NOCACHE
+#define FIXMAP_PAGE_NOCACHE PAGE_KERNEL_NOCACHE
 
 /*
  * Early memremap routines used for in-place encryption. The mappings created
diff --git a/arch/x86/include/asm/pgtable_types.h b/arch/x86/include/asm/pgtable_types.h
index 40497a9020c6..a87224767ff3 100644
--- a/arch/x86/include/asm/pgtable_types.h
+++ b/arch/x86/include/asm/pgtable_types.h
@@ -199,10 +199,6 @@ enum page_cache_mode {
 #define __PAGE_KERNEL_WP	 (__PP|__RW|   0|___A|__NX|___D|   0|___G| __WP)
 
 
-#define __PAGE_KERNEL_IO		__PAGE_KERNEL
-#define __PAGE_KERNEL_IO_NOCACHE	__PAGE_KERNEL_NOCACHE
-
-
 #ifndef __ASSEMBLY__
 
 #define __PAGE_KERNEL_ENC	(__PAGE_KERNEL    | _ENC)
@@ -223,9 +219,6 @@ enum page_cache_mode {
 #define PAGE_KERNEL_LARGE_EXEC	__pgprot_mask(__PAGE_KERNEL_LARGE_EXEC | _ENC)
 #define PAGE_KERNEL_VVAR	__pgprot_mask(__PAGE_KERNEL_VVAR       | _ENC)
 
-#define PAGE_KERNEL_IO		__pgprot_mask(__PAGE_KERNEL_IO)
-#define PAGE_KERNEL_IO_NOCACHE	__pgprot_mask(__PAGE_KERNEL_IO_NOCACHE)
-
 #endif	/* __ASSEMBLY__ */
 
 /*         xwr */
diff --git a/arch/x86/mm/ioremap.c b/arch/x86/mm/ioremap.c
index 026031b3b782..3102dda4b152 100644
--- a/arch/x86/mm/ioremap.c
+++ b/arch/x86/mm/ioremap.c
@@ -243,7 +243,7 @@ __ioremap_caller(resource_size_t phys_addr, unsigned long size,
 	 * make sure the memory encryption attribute is enabled in the
 	 * resulting mapping.
 	 */
-	prot = PAGE_KERNEL_IO;
+	prot = PAGE_KERNEL;
 	if ((io_desc.flags & IORES_MAP_ENCRYPTED) || encrypted)
 		prot = pgprot_encrypted(prot);
 
diff --git a/arch/x86/xen/setup.c b/arch/x86/xen/setup.c
index 8bfc10330107..5dc0771a50f3 100644
--- a/arch/x86/xen/setup.c
+++ b/arch/x86/xen/setup.c
@@ -435,7 +435,7 @@ static unsigned long __init xen_set_identity_and_remap_chunk(
 	for (pfn = start_pfn; pfn <= max_pfn_mapped && pfn < end_pfn; pfn++)
 		(void)HYPERVISOR_update_va_mapping(
 			(unsigned long)__va(pfn << PAGE_SHIFT),
-			mfn_pte(pfn, PAGE_KERNEL_IO), 0);
+			mfn_pte(pfn, PAGE_KERNEL), 0);
 
 	return remap_pfn;
 }
diff --git a/include/asm-generic/fixmap.h b/include/asm-generic/fixmap.h
index 8cc7b09c1bc7..f1b0c6f3d0be 100644
--- a/include/asm-generic/fixmap.h
+++ b/include/asm-generic/fixmap.h
@@ -54,7 +54,7 @@ static inline unsigned long virt_to_fix(const unsigned long vaddr)
 #define FIXMAP_PAGE_NOCACHE PAGE_KERNEL_NOCACHE
 #endif
 #ifndef FIXMAP_PAGE_IO
-#define FIXMAP_PAGE_IO PAGE_KERNEL_IO
+#define FIXMAP_PAGE_IO PAGE_KERNEL
 #endif
 #ifndef FIXMAP_PAGE_CLEAR
 #define FIXMAP_PAGE_CLEAR __pgprot(0)
-- 
2.33.1



From xen-devel-bounces@lists.xenproject.org Fri Oct 22 04:10:11 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Oct 2021 04:10:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.214570.373365 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdlse-0006cW-Oq; Fri, 22 Oct 2021 04:10:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 214570.373365; Fri, 22 Oct 2021 04:10:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdlse-0006bg-Il; Fri, 22 Oct 2021 04:10:08 +0000
Received: by outflank-mailman (input) for mailman id 214570;
 Thu, 21 Oct 2021 18:15:33 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=IF2L=PJ=intel.com=lucas.demarchi@srs-us1.protection.inumbo.net>)
 id 1mdcbF-00047r-Kp
 for xen-devel@lists.xenproject.org; Thu, 21 Oct 2021 18:15:33 +0000
Received: from mga01.intel.com (unknown [192.55.52.88])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id ded26fba-329a-11ec-8389-12813bfff9fa;
 Thu, 21 Oct 2021 18:15:28 +0000 (UTC)
Received: from orsmga001.jf.intel.com ([10.7.209.18])
 by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 21 Oct 2021 11:15:19 -0700
Received: from lucas-s2600cw.jf.intel.com ([10.165.21.202])
 by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 21 Oct 2021 11:15:19 -0700
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ded26fba-329a-11ec-8389-12813bfff9fa
X-IronPort-AV: E=McAfee;i="6200,9189,10144"; a="252606742"
X-IronPort-AV: E=Sophos;i="5.87,170,1631602800"; 
   d="scan'208";a="252606742"
X-IronPort-AV: E=Sophos;i="5.87,170,1631602800"; 
   d="scan'208";a="527582106"
From: Lucas De Marchi <lucas.demarchi@intel.com>
To: intel-gfx@lists.freedesktop.org,
	dri-devel@lists.freedesktop.org,
	x86@kernel.org
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	linux-kernel@vger.kernel.org,
	linux-arch@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: [PATCH 1/2] drm/i915/gem: stop using PAGE_KERNEL_IO
Date: Thu, 21 Oct 2021 11:15:10 -0700
Message-Id: <20211021181511.1533377-2-lucas.demarchi@intel.com>
X-Mailer: git-send-email 2.33.1
In-Reply-To: <20211021181511.1533377-1-lucas.demarchi@intel.com>
References: <20211021181511.1533377-1-lucas.demarchi@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

PAGE_KERNEL_IO is only defined for x86 and nowadays is the same as
PAGE_KERNEL. It was different for some time, OR'ing a `_PAGE_IOMAP` flag
in commit be43d72835ba ("x86: add _PAGE_IOMAP pte flag for IO
mappings").  This got removed in commit f955371ca9d3 ("x86: remove the
Xen-specific _PAGE_IOMAP PTE flag"), so today they are just the same.

This is the same that was done in commit ac96b5566926 ("io-mapping.h:
s/PAGE_KERNEL_IO/PAGE_KERNEL/").

There is a subsequent commit with
'Fixes: ac96b5566926 ("io-mapping.h: s/PAGE_KERNEL_IO/PAGE_KERNEL/")' -
but that is not relevant here since is it's actually fixing the different
names for pgprot_writecombine(), which we also don't have today since
all archs expose pgprot_writecombine(). Microblaze, mentioned in that
discussion, gained pgprot_writecombine() in
commit 97ccedd793ac ("microblaze: Provide pgprot_device/writecombine
macros for nommu").

So, just use PAGE_KERNEL, and just use pgprot_writecombine().

Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/20211020090625.1037517-1-lucas.demarchi@intel.com
---
 drivers/gpu/drm/i915/gem/i915_gem_pages.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/gem/i915_gem_pages.c b/drivers/gpu/drm/i915/gem/i915_gem_pages.c
index 8eb1c3a6fc9c..68fe1837ef54 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_pages.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_pages.c
@@ -289,7 +289,7 @@ static void *i915_gem_object_map_page(struct drm_i915_gem_object *obj,
 		pgprot = PAGE_KERNEL;
 		break;
 	case I915_MAP_WC:
-		pgprot = pgprot_writecombine(PAGE_KERNEL_IO);
+		pgprot = pgprot_writecombine(PAGE_KERNEL);
 		break;
 	}
 
@@ -333,7 +333,7 @@ static void *i915_gem_object_map_pfn(struct drm_i915_gem_object *obj,
 	i = 0;
 	for_each_sgt_daddr(addr, iter, obj->mm.pages)
 		pfns[i++] = (iomap + addr) >> PAGE_SHIFT;
-	vaddr = vmap_pfn(pfns, n_pfn, pgprot_writecombine(PAGE_KERNEL_IO));
+	vaddr = vmap_pfn(pfns, n_pfn, pgprot_writecombine(PAGE_KERNEL));
 	if (pfns != stack)
 		kvfree(pfns);
 
-- 
2.33.1



From xen-devel-bounces@lists.xenproject.org Fri Oct 22 05:59:45 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Oct 2021 05:59:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.214733.373443 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdnaU-0000lH-Ur; Fri, 22 Oct 2021 05:59:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 214733.373443; Fri, 22 Oct 2021 05:59:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdnaU-0000lA-RN; Fri, 22 Oct 2021 05:59:30 +0000
Received: by outflank-mailman (input) for mailman id 214733;
 Fri, 22 Oct 2021 05:59:29 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=KgL4=PK=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mdnaT-0000l4-B7
 for xen-devel@lists.xenproject.org; Fri, 22 Oct 2021 05:59:29 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 370ebe1a-32fd-11ec-83aa-12813bfff9fa;
 Fri, 22 Oct 2021 05:59:28 +0000 (UTC)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2169.outbound.protection.outlook.com [104.47.17.169])
 (Using TLS) by relay.mimecast.com with ESMTP id
 de-mta-10-ILsiVrxSN0aI0f4EwSbVxA-1; Fri, 22 Oct 2021 07:59:25 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB4351.eurprd04.prod.outlook.com (2603:10a6:803:49::33)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.18; Fri, 22 Oct
 2021 05:59:24 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::8062:d7cb:ca45:1898]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::8062:d7cb:ca45:1898%3]) with mapi id 15.20.4628.018; Fri, 22 Oct 2021
 05:59:23 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS9PR06CA0284.eurprd06.prod.outlook.com (2603:10a6:20b:45a::27) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.18 via Frontend
 Transport; Fri, 22 Oct 2021 05:59:23 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 370ebe1a-32fd-11ec-83aa-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634882367;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=ooAiu42OjOtMgI5grSxQUzr+M00R2QwtZHSiOu261VM=;
	b=G9lw1GDeZe1yQnjKUawrvPIJ2tfvynR3JdD1DqWj2MFTU4gbDQkLkHX/LxjrFHFuGLjrgC
	U9VuB/bxScXaVVVJcwydkW/SWQ70J1bl6Wjz2FbYpvq+i7ZBw45Skq1y74o9Sji2r3ulHK
	mlg5NWBQjr3QgtsatRpvXgp8W+XU758=
X-MC-Unique: ILsiVrxSN0aI0f4EwSbVxA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Ez1WLYeOY5rZ48KDwU7oiXOi1Y0RMvvzY3irRzc8o/lHgCogUcwIXTSdMwMPl5c3DP/Pkl6hKPC/0RHX+Wcx7+XVbw1b27UywIOmPQ8jO2VZqYqVGydIjQ4upD5QTKtRCYJ44pmT5S8zV6L0DXt0gFpGzWwxXiBMtCHJ0JLba2PE+So2hXRGLk3G2L848oO0yqTcPEEXmOvJ/j7iVybCgm8uc7h3RFrLFuqgmqzo7Asrh+Iqvz18mP/Dgo460qGkS0PA/Iz90Kpb18nh53pNjuLIAiYU7KoQu4XxErdwVo4R5pcp1B1sQfEB6oUZ5aqpClyZHwJQZcSRBSLCYVY6NQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ooAiu42OjOtMgI5grSxQUzr+M00R2QwtZHSiOu261VM=;
 b=bCl6ncrZrggjoc/w+EHHf++IeX07tyf8n8JtpqjmZFfnSCNj4h0Cdnk9pfhhsSVBln4affM9oADC9MQTsJh1pT32tcXbpl6FZJh+hrfG13DgWCiNiV5J1Al0gvPaWS7XGOG92tzCbN6zxmjDTc3O0iu29itDpiT1/aaXmMkvM3luRquF6HL9LOJ5xb7UK090C+gNCQDrF/oW5eMKD8ZunvpQQX08zn8MvEIcM7hPFkX7ofaMSJJjnHQoFy4I0NAN1Uarp8fEDyjwahhSk4oINSYixdDkD8w5r369kP9sG3JTYF+UixCT7cUOumDRL5LZZ7u6IJ4m7l8HbfrJ+O1vNA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Subject: Re: [PATCH v2 1/3] x86/IOMMU: mark IOMMU / intremap not in use when
 ACPI tables are missing
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Paul Durrant <paul@xen.org>, Kevin Tian <kevin.tian@intel.com>
References: <09137aa2-649f-08fb-ba68-75f8eb16fc63@suse.com>
 <efe34081-c813-0e37-175c-8553b395e6d9@suse.com>
Message-ID: <ffe7f130-9034-50d0-ab0a-06933dde88d8@suse.com>
Date: Fri, 22 Oct 2021 07:59:20 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <efe34081-c813-0e37-175c-8553b395e6d9@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0284.eurprd06.prod.outlook.com
 (2603:10a6:20b:45a::27) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 5c025cbe-455e-4d87-001a-08d9952118fe
X-MS-TrafficTypeDiagnostic: VI1PR04MB4351:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB4351334789CB5B7ABE6CBA27B3809@VI1PR04MB4351.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:2803;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	CNaEhsv4OolMTj9KrGty/W98PnHdJ27HfAIcVcRPZXJTZ+1b7xcvC5t7MN4rsHS1LLEluXr/Zto7+TfgPqR+ZSu9h7zV0vUS6dXUlnq0/m4XTHmXpIDnl7irqFF7D7lo75pFuXOkDzYdo/kP6LCYV5CtNEbFELgNBI4/JlKIqSRFW7bfyQD5d2JmpqsfkFe2UGwwoe8mbEOQECsQfh9y9HKfeGGLhjUdcmg8GsqPfHfcPQIRUOv97V2HdW52MIxongL1fXL0LA6/8efgTLv6iC+hhyk2HQkzbdwJEu7TK1gLI6fn7VQiwfKXSy+5Jh1LGML6r25Yjd6KhCBXBnFnpGAI/scILuIU6fmlJw9mhs1J9wpQVFlo0jju7wtIKuBR5LdIXNaMr4eciB04sBf8zP8at5DwGjXUM9VesJ+PKx/wt9jOzWwH+hjainmto5+mfzD/Z3Yjlss8xw2cBnvPcxbceRPOxqBZdfo73IiAsARvNh3B1JJVc8eJs7x/AweM3BkTFi4oSZX40e2UkIyP8249EImCDHP+KidcddfW+ysKaeY7p1POPuVxpTMnDKPTod/Ay1FGiVPG4yGkbboMzpm0jKk/yi/RJlnQ3Sf86CXXbQ4mTpRi8xXcme9DyZjcDytoYz4udq0xe0JSwRv5VuZhKa/csXfLsFJ87sqiU5f1yXDk7JRjFlYp1+tdqepAqdlPMgYy5eZt0YQqzOWo8rtfm7V6qIvzdQBsj/dI/+o=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(26005)(6486002)(53546011)(66476007)(66556008)(66946007)(54906003)(38100700002)(508600001)(956004)(4326008)(2616005)(186003)(5660300002)(2906002)(316002)(16576012)(86362001)(83380400001)(36756003)(31686004)(6916009)(31696002)(8676002)(8936002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?T0lKa1BSeUJPMTB2dXZJSkluKzNPY05BK3dlMmw3bWRZNEZXTHhLdHYvSDh5?=
 =?utf-8?B?ejZHTFg4UzRQSVpERzBwMDRTK0JaanFuSzVuUXE3cXBxWmVCeitmU3lkSk9O?=
 =?utf-8?B?WFJpN0M5L3BmOTlvbWlHcjBYNHRNdGtGOHV5RUNlOHlpZUl6S0NNbUU2L3hF?=
 =?utf-8?B?YXJCRHdrMysvYU55OEpkWU5uOFhTK1hJRVNxTURKNlJGUXRsUlJ4MjNnQ2ZN?=
 =?utf-8?B?eVJQUXQ3SUpiMzVKOWFVL3EyUU41amtkZExuZGRnV0hHejZBTmhHSURma2FN?=
 =?utf-8?B?SzlkV2NHc2JRbjM3RXV0RktjaXFjUXJhK3V6cjBuMlhjUVpuMWFWcm8zZTMr?=
 =?utf-8?B?Qk9rbm9vUnVlejlTTnlaaWlFcGRZZS8wM3FNd2ZsZ1dsNGdZSUU1eUd4ckJk?=
 =?utf-8?B?bE12eGpZWk9sVlMwcnB1TUpRNTNiejNhSG1KTjBxSy9GLzVDcUJQenR3Nk5F?=
 =?utf-8?B?TmJReWJlZGh4YVBHVUNxSzZ5WGN6L0M1ZHE1czVKMHRKeWhWcDAyVSs4Q3VO?=
 =?utf-8?B?ZFJGS3BhN2tna25OVHRjU0FQdUFsMncvN1l2NXFzTmJLcC9neEN1UzBYRjIz?=
 =?utf-8?B?c2s4VHl5TlRzcWVHc2MyN0UxeGlXcHBsclpYUEVMWDhqT0ZTajNSVk05OUw4?=
 =?utf-8?B?ZEthSWdqQ2NOekN3ZmhPeWZOOTZ3MTV2ZE1ONE1CRzNhZzIvZ1ZRd2dzTTBS?=
 =?utf-8?B?NVRSa1QweXFNUDZRcDRWK0FSd05GNDgzK2x2eW5ZdlN6R0tNemFjU2VmTmxs?=
 =?utf-8?B?cTkxN2lQcjN0OEk0RWpySGgxaXNxNktDVUZpNFJIRWRvTW5Sb2pWWktpZ3lC?=
 =?utf-8?B?RTNLZm03elR5aWRLVzVVVWFCWHNTc01rTkZHZ3UzTlk3OGpIMHl0TFFIOW4x?=
 =?utf-8?B?emV5dHpNaCsrbWVha3FNcE1Jd0lwMzBkcTIrQktlU0I4bEJiek0zd25KY2pD?=
 =?utf-8?B?RHM4M1A5MGJYQkpRc0xIY0Izc3JWKzRKcGhhUjk1L1RKZFpvdVVKUVJubCtn?=
 =?utf-8?B?NDRmazNWdGVZWWZPaDBnd1hFYnBqWWZyMkNXRHNHcHYvTGI4c1lJVEQzdEFL?=
 =?utf-8?B?aTJ3UmRVUy9hUmw5UmszcENLTm9LckRVUC82YUxLMlFvMUtVZ1BYNXhQRmlv?=
 =?utf-8?B?R2pxVkt2TjNTaFF1T0hEVVpGRy9rNnZlajNvTTlaR1cxMGN5TzBnaXZVZ1ZE?=
 =?utf-8?B?a0xweVdJaUdkN1NBRWZPTzNZbE51ZzZFK2U3WmFJQU8zOUdlVDViSFQyTk01?=
 =?utf-8?B?cXNUT2dseFRxWVBVSExzcFY2cVNtblpkT3JSVEVLREVBOEhtTWlxWVNLL3Fa?=
 =?utf-8?B?SGw3d1RsaGk0ZTMrVVcrdkd5NC90N3pyZnNqTEFMcE9QS3FjWUp0UWxjbUhk?=
 =?utf-8?B?WWFFaFNrK0ZOTDFtTGsxODJGcGpNbVhNTVRGRFhsbXlham5XcElDVE50d05E?=
 =?utf-8?B?V09NeDIvdVkybGlJTWo2YUpFNEpCb3ZreDF6bzdGbDc4WUE4c2hTaklza1lt?=
 =?utf-8?B?QWJ0cVFwNG1Nc28wMGRIT3I4bFM0N1FVSjByM3h6eUIxak00elVta2tLTDZR?=
 =?utf-8?B?ejdNUWRoMm5yL1ZwMk9aeTZSQ2U0ZWluTDJWYnFnYXpqUUdmMk5YYVhxa0xU?=
 =?utf-8?B?SEg4UlNab3ZqUDZhM0c4aFdFN053aExIQTlkQkpTNGhLSHdvRXY1VzJEMXYx?=
 =?utf-8?B?cXozVDBQWTcrSVQ2N1JENUZ0eTJjbk9GRDZSTUNEaWVWNXp5M2VCbEkrc3lH?=
 =?utf-8?B?Ym92ZSticUwzYUkrQWJ2R1JFbTRkejZ4UDlRVkcyYVJlSlRjWHV0WDdXbVhT?=
 =?utf-8?B?dUxOcWloSTZGY3JKajkvdTdYc3FLOHRBVWpFdFN3dC9QSHVhanBuM0tJdlo3?=
 =?utf-8?B?SUJtSkZocmRkMk84ZHFTeDZFdkpZUW1UV1p3S2ErRHM2ZkhHcE01TzhYc1hF?=
 =?utf-8?Q?PPd07rwSt5s=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5c025cbe-455e-4d87-001a-08d9952118fe
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Oct 2021 05:59:23.7443
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jbeulich@suse.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4351

On 21.10.2021 11:58, Jan Beulich wrote:
> x2apic_bsp_setup() gets called ahead of iommu_setup(), and since x2APIC
> mode (physical vs clustered) depends on iommu_intremap, that variable
> needs to be set to off as soon as we know we can't / won't enable
> interrupt remapping, i.e. in particular when parsing of the respective
> ACPI tables failed. Move the turning off of iommu_intremap from AMD
> specific code into acpi_iommu_init(), accompanying it by clearing of
> iommu_enable.
> 
> Take the opportunity and also fully skip ACPI table parsing logic on
> VT-d when both "iommu=off" and "iommu=no-intremap" are in effect anyway,
> like was already the case for AMD.
> 
> The tag below only references the commit uncovering a pre-existing
> anomaly.
> 
> Fixes: d8bd82327b0f ("AMD/IOMMU: obtain IVHD type to use earlier")
> Reported-by: Andrew Cooper <andrew.cooper3@citrix.com>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Ouch, forgot to Cc Kevin; now added.

Jan

> ---
> While the change here deals with apic_x2apic_probe() as called from
> x2apic_bsp_setup(), the check_x2apic_preenabled() path looks to be
> similarly affected. That call occurs before acpi_boot_init(), which is
> what calls acpi_iommu_init(). The ordering in setup.c is in part
> relatively fragile, which is why for the moment I'm still hesitant to
> move the generic_apic_probe() call down. Plus I don't have easy access
> to a suitable system to test this case. Thoughts?
> ---
> v2: Treat iommu_enable and iommu_intremap as separate options.
> 
> --- a/xen/drivers/passthrough/amd/pci_amd_iommu.c
> +++ b/xen/drivers/passthrough/amd/pci_amd_iommu.c
> @@ -183,9 +183,6 @@ int __init acpi_ivrs_init(void)
>  {
>      int rc;
>  
> -    if ( !iommu_enable && !iommu_intremap )
> -        return 0;
> -
>      rc = amd_iommu_get_supported_ivhd_type();
>      if ( rc < 0 )
>          return rc;
> @@ -193,10 +190,7 @@ int __init acpi_ivrs_init(void)
>      ivhd_type = rc;
>  
>      if ( (amd_iommu_detect_acpi() !=0) || (iommu_found() == 0) )
> -    {
> -        iommu_intremap = iommu_intremap_off;
>          return -ENODEV;
> -    }
>  
>      iommu_init_ops = &_iommu_init_ops;
>  
> --- a/xen/drivers/passthrough/vtd/dmar.c
> +++ b/xen/drivers/passthrough/vtd/dmar.c
> @@ -777,11 +777,7 @@ static int __init acpi_parse_dmar(struct
>      dmar = (struct acpi_table_dmar *)table;
>      dmar_flags = dmar->flags;
>  
> -    if ( !iommu_enable && !iommu_intremap )
> -    {
> -        ret = -EINVAL;
> -        goto out;
> -    }
> +    ASSERT(iommu_enable || iommu_intremap);
>  
>      if ( !dmar->width )
>      {
> --- a/xen/drivers/passthrough/x86/iommu.c
> +++ b/xen/drivers/passthrough/x86/iommu.c
> @@ -41,6 +41,24 @@ enum iommu_intremap __read_mostly iommu_
>  bool __read_mostly iommu_intpost;
>  #endif
>  
> +void __init acpi_iommu_init(void)
> +{
> +    int ret;
> +
> +    if ( !iommu_enable && !iommu_intremap )
> +        return;
> +
> +    ret = acpi_dmar_init();
> +    if ( ret == -ENODEV )
> +        ret = acpi_ivrs_init();
> +
> +    if ( ret )
> +    {
> +        iommu_enable = false;
> +        iommu_intremap = iommu_intremap_off;
> +    }
> +}
> +
>  int __init iommu_hardware_setup(void)
>  {
>      struct IO_APIC_route_entry **ioapic_entries = NULL;
> --- a/xen/include/asm-x86/acpi.h
> +++ b/xen/include/asm-x86/acpi.h
> @@ -141,16 +141,10 @@ extern u32 x86_acpiid_to_apicid[];
>  extern u32 pmtmr_ioport;
>  extern unsigned int pmtmr_width;
>  
> +void acpi_iommu_init(void);
>  int acpi_dmar_init(void);
>  int acpi_ivrs_init(void);
>  
> -static inline int acpi_iommu_init(void)
> -{
> -    int ret = acpi_dmar_init();
> -
> -    return ret == -ENODEV ? acpi_ivrs_init() : ret;
> -}
> -
>  void acpi_mmcfg_init(void);
>  
>  /* Incremented whenever we transition through S3. Value is 1 during boot. */
> 
> 



From xen-devel-bounces@lists.xenproject.org Fri Oct 22 06:49:12 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Oct 2021 06:49:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.214750.373477 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdoMW-0005ux-6k; Fri, 22 Oct 2021 06:49:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 214750.373477; Fri, 22 Oct 2021 06:49:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdoMW-0005uq-3v; Fri, 22 Oct 2021 06:49:08 +0000
Received: by outflank-mailman (input) for mailman id 214750;
 Fri, 22 Oct 2021 06:49:06 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=e5cR=PK=suse.com=jgross@srs-us1.protection.inumbo.net>)
 id 1mdoMU-0005ue-Ir
 for xen-devel@lists.xenproject.org; Fri, 22 Oct 2021 06:49:06 +0000
Received: from smtp-out1.suse.de (unknown [195.135.220.28])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id e2a407ff-7f6a-4be6-ab1b-09ebb5566a99;
 Fri, 22 Oct 2021 06:49:05 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 8D2452197F;
 Fri, 22 Oct 2021 06:49:04 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1A09513AAD;
 Fri, 22 Oct 2021 06:49:04 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id jpEMBeBecmEIEwAAMHmgww
 (envelope-from <jgross@suse.com>); Fri, 22 Oct 2021 06:49:04 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e2a407ff-7f6a-4be6-ab1b-09ebb5566a99
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1634885344; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:  content-transfer-encoding:content-transfer-encoding;
	bh=vdb5nLtyp5tIbT7/OLrVEaSBnq6naUGZA07AQT86v2c=;
	b=PMNO7u+JK4lsjHIAmHQ/NYSH6PSDWxW5oi4qSzEsVw9p0v6RgIf1dw5L1M0yxZnnPmUE42
	bEdzMHkjaPHjMsStRKaaW/VG+AFY5hngJA838Yw55Zrc0gCY9ILGst8rEWSnr+azo7IRtQ
	wVKKkBy8OqPGObfHmn8PuQkefgkgXAA=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org,
	linux-input@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	dri-devel@lists.freedesktop.org,
	linux-fbdev@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org
Cc: Juergen Gross <jgross@suse.com>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>,
	David Airlie <airlied@linux.ie>,
	Daniel Vetter <daniel@ffwll.ch>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jiri Slaby <jirislaby@kernel.org>,
	Jaroslav Kysela <perex@perex.cz>,
	Takashi Iwai <tiwai@suse.com>,
	alsa-devel@alsa-project.org
Subject: [PATCH 0/5] xen: cleanup detection of non-essential pv devices
Date: Fri, 22 Oct 2021 08:47:55 +0200
Message-Id: <20211022064800.14978-1-jgross@suse.com>
X-Mailer: git-send-email 2.26.2
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Today the non-essential pv devices are hard coded in the xenbus driver
and this list is lacking multiple entries.

This series reworks the detection logic of non-essential devices by
adding a flag for that purpose to struct xenbus_driver.

Juergen Gross (5):
  xen: add "not_essential" flag to struct xenbus_driver
  xen: flag xen_drm_front to be not essential for system boot
  xen: flag hvc_xen to be not essential for system boot
  xen: flag pvcalls-front to be not essential for system boot
  xen: flag xen_snd_front to be not essential for system boot

 drivers/gpu/drm/xen/xen_drm_front.c        |  1 +
 drivers/input/misc/xen-kbdfront.c          |  1 +
 drivers/tty/hvc/hvc_xen.c                  |  1 +
 drivers/video/fbdev/xen-fbfront.c          |  1 +
 drivers/xen/pvcalls-front.c                |  1 +
 drivers/xen/xenbus/xenbus_probe_frontend.c | 14 +++-----------
 include/xen/xenbus.h                       |  1 +
 sound/xen/xen_snd_front.c                  |  1 +
 8 files changed, 10 insertions(+), 11 deletions(-)

-- 
2.26.2



From xen-devel-bounces@lists.xenproject.org Fri Oct 22 06:49:12 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Oct 2021 06:49:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.214752.373499 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdoMa-0006Si-Q5; Fri, 22 Oct 2021 06:49:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 214752.373499; Fri, 22 Oct 2021 06:49:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdoMa-0006SZ-Mz; Fri, 22 Oct 2021 06:49:12 +0000
Received: by outflank-mailman (input) for mailman id 214752;
 Fri, 22 Oct 2021 06:49:11 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=e5cR=PK=suse.com=jgross@srs-us1.protection.inumbo.net>)
 id 1mdoMZ-0005ue-DA
 for xen-devel@lists.xenproject.org; Fri, 22 Oct 2021 06:49:11 +0000
Received: from smtp-out2.suse.de (unknown [195.135.220.29])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 40aec6ac-90d0-4ea7-ad84-6d5d02bd43c6;
 Fri, 22 Oct 2021 06:49:05 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 21C651FD59;
 Fri, 22 Oct 2021 06:49:05 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id D810413AAD;
 Fri, 22 Oct 2021 06:49:04 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id yCmFM+BecmEIEwAAMHmgww
 (envelope-from <jgross@suse.com>); Fri, 22 Oct 2021 06:49:04 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 40aec6ac-90d0-4ea7-ad84-6d5d02bd43c6
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1634885345; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=80mOxk7OisLv8eTtTaoe81+q4mcgaLTrWwkMlhEogsw=;
	b=Y8s49wATwiV6ccraCQUa+ld+V54ty1XPZFYJwJ60XapgZj5bSnABkO44U1HpMqfeRnvSWM
	uW0I7W9S1o26EQZyD8UaYpPk7EcHaeQgRPdRS2ZmbSlW0cfsaBEx25FwtSU+hilKwCJfy5
	tsHcDZ7CYxP32C+ElsGFh95BERckVzY=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org,
	dri-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org
Cc: Juergen Gross <jgross@suse.com>,
	Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>,
	David Airlie <airlied@linux.ie>,
	Daniel Vetter <daniel@ffwll.ch>
Subject: [PATCH 2/5] xen: flag xen_drm_front to be not essential for system boot
Date: Fri, 22 Oct 2021 08:47:57 +0200
Message-Id: <20211022064800.14978-3-jgross@suse.com>
X-Mailer: git-send-email 2.26.2
In-Reply-To: <20211022064800.14978-1-jgross@suse.com>
References: <20211022064800.14978-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Similar to the virtual frame buffer (vfb) the pv display driver is not
essential for booting the system. Set the respective flag.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 drivers/gpu/drm/xen/xen_drm_front.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/xen/xen_drm_front.c b/drivers/gpu/drm/xen/xen_drm_front.c
index 9f14d99c763c..bc7605324db3 100644
--- a/drivers/gpu/drm/xen/xen_drm_front.c
+++ b/drivers/gpu/drm/xen/xen_drm_front.c
@@ -773,6 +773,7 @@ static struct xenbus_driver xen_driver = {
 	.probe = xen_drv_probe,
 	.remove = xen_drv_remove,
 	.otherend_changed = displback_changed,
+	.not_essential = true,
 };
 
 static int __init xen_drv_init(void)
-- 
2.26.2



From xen-devel-bounces@lists.xenproject.org Fri Oct 22 06:49:12 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Oct 2021 06:49:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.214751.373483 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdoMW-0005yP-GP; Fri, 22 Oct 2021 06:49:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 214751.373483; Fri, 22 Oct 2021 06:49:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdoMW-0005xs-Ce; Fri, 22 Oct 2021 06:49:08 +0000
Received: by outflank-mailman (input) for mailman id 214751;
 Fri, 22 Oct 2021 06:49:07 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=e5cR=PK=suse.com=jgross@srs-us1.protection.inumbo.net>)
 id 1mdoMV-0005uk-B0
 for xen-devel@lists.xenproject.org; Fri, 22 Oct 2021 06:49:07 +0000
Received: from smtp-out1.suse.de (unknown [195.135.220.28])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 25f39ae0-3304-11ec-83ad-12813bfff9fa;
 Fri, 22 Oct 2021 06:49:06 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id D0BB121983;
 Fri, 22 Oct 2021 06:49:04 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 92EEA13C79;
 Fri, 22 Oct 2021 06:49:04 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id AF+wIuBecmEIEwAAMHmgww
 (envelope-from <jgross@suse.com>); Fri, 22 Oct 2021 06:49:04 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 25f39ae0-3304-11ec-83ad-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1634885344; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=kLjFhRTaZVh+922MiISGe9xKfsnF1lnWNXu00NonX3Y=;
	b=Yz8ovdFyj3/pte4s30R5bKNii8Dj0Cui8WBkly6EcM+9mbjl8dcoRZskne4zX9d2rhTnSM
	nSZJZNU8MNvgJ0hVKAWx33tvmv06DzvqeJSYABc5kbSCmE3JCkFNf0szyoGGdajX9441j+
	iwpYYIVKuMs8a9+feAbvot98kgyfm38=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org,
	linux-input@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	dri-devel@lists.freedesktop.org,
	linux-fbdev@vger.kernel.org
Cc: Juergen Gross <jgross@suse.com>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>
Subject: [PATCH 1/5] xen: add "not_essential" flag to struct xenbus_driver
Date: Fri, 22 Oct 2021 08:47:56 +0200
Message-Id: <20211022064800.14978-2-jgross@suse.com>
X-Mailer: git-send-email 2.26.2
In-Reply-To: <20211022064800.14978-1-jgross@suse.com>
References: <20211022064800.14978-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

When booting the xenbus driver will wait for PV devices to have
connected to their backends before continuing. The timeout is different
between essential and non-essential devices.

Non-essential devices are identified by their nodenames directly in the
xenbus driver, which requires to update this list in case a new device
type being non-essential is added (this was missed for several types
in the past).

In order to avoid this problem, add a "not_essential" flag to struct
xenbus_driver which can be set to "true" by the respective frontend.

Set this flag for the frontends currently regarded to be not essential
(vkbs and vfb) and use it for testing in the xenbus driver.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 drivers/input/misc/xen-kbdfront.c          |  1 +
 drivers/video/fbdev/xen-fbfront.c          |  1 +
 drivers/xen/xenbus/xenbus_probe_frontend.c | 14 +++-----------
 include/xen/xenbus.h                       |  1 +
 4 files changed, 6 insertions(+), 11 deletions(-)

diff --git a/drivers/input/misc/xen-kbdfront.c b/drivers/input/misc/xen-kbdfront.c
index 4ff5cd2a6d8d..3d17a0b3fe51 100644
--- a/drivers/input/misc/xen-kbdfront.c
+++ b/drivers/input/misc/xen-kbdfront.c
@@ -542,6 +542,7 @@ static struct xenbus_driver xenkbd_driver = {
 	.remove = xenkbd_remove,
 	.resume = xenkbd_resume,
 	.otherend_changed = xenkbd_backend_changed,
+	.not_essential = true,
 };
 
 static int __init xenkbd_init(void)
diff --git a/drivers/video/fbdev/xen-fbfront.c b/drivers/video/fbdev/xen-fbfront.c
index 5ec51445bee8..6826f986da43 100644
--- a/drivers/video/fbdev/xen-fbfront.c
+++ b/drivers/video/fbdev/xen-fbfront.c
@@ -695,6 +695,7 @@ static struct xenbus_driver xenfb_driver = {
 	.remove = xenfb_remove,
 	.resume = xenfb_resume,
 	.otherend_changed = xenfb_backend_changed,
+	.not_essential = true,
 };
 
 static int __init xenfb_init(void)
diff --git a/drivers/xen/xenbus/xenbus_probe_frontend.c b/drivers/xen/xenbus/xenbus_probe_frontend.c
index 480944606a3c..07b010a68fcf 100644
--- a/drivers/xen/xenbus/xenbus_probe_frontend.c
+++ b/drivers/xen/xenbus/xenbus_probe_frontend.c
@@ -211,19 +211,11 @@ static int is_device_connecting(struct device *dev, void *data, bool ignore_none
 	if (drv && (dev->driver != drv))
 		return 0;
 
-	if (ignore_nonessential) {
-		/* With older QEMU, for PVonHVM guests the guest config files
-		 * could contain: vfb = [ 'vnc=1, vnclisten=0.0.0.0']
-		 * which is nonsensical as there is no PV FB (there can be
-		 * a PVKB) running as HVM guest. */
+	xendrv = to_xenbus_driver(dev->driver);
 
-		if ((strncmp(xendev->nodename, "device/vkbd", 11) == 0))
-			return 0;
+	if (ignore_nonessential && xendrv->not_essential)
+		return 0;
 
-		if ((strncmp(xendev->nodename, "device/vfb", 10) == 0))
-			return 0;
-	}
-	xendrv = to_xenbus_driver(dev->driver);
 	return (xendev->state < XenbusStateConnected ||
 		(xendev->state == XenbusStateConnected &&
 		 xendrv->is_ready && !xendrv->is_ready(xendev)));
diff --git a/include/xen/xenbus.h b/include/xen/xenbus.h
index b94074c82772..b13eb86395e0 100644
--- a/include/xen/xenbus.h
+++ b/include/xen/xenbus.h
@@ -112,6 +112,7 @@ struct xenbus_driver {
 	const char *name;       /* defaults to ids[0].devicetype */
 	const struct xenbus_device_id *ids;
 	bool allow_rebind; /* avoid setting xenstore closed during remove */
+	bool not_essential;     /* is not mandatory for boot progress */
 	int (*probe)(struct xenbus_device *dev,
 		     const struct xenbus_device_id *id);
 	void (*otherend_changed)(struct xenbus_device *dev,
-- 
2.26.2



From xen-devel-bounces@lists.xenproject.org Fri Oct 22 06:49:13 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Oct 2021 06:49:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.214753.373505 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdoMb-0006Vu-7q; Fri, 22 Oct 2021 06:49:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 214753.373505; Fri, 22 Oct 2021 06:49:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdoMb-0006Uu-0D; Fri, 22 Oct 2021 06:49:13 +0000
Received: by outflank-mailman (input) for mailman id 214753;
 Fri, 22 Oct 2021 06:49:12 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=e5cR=PK=suse.com=jgross@srs-us1.protection.inumbo.net>)
 id 1mdoMa-0005uk-6I
 for xen-devel@lists.xenproject.org; Fri, 22 Oct 2021 06:49:12 +0000
Received: from smtp-out1.suse.de (unknown [195.135.220.28])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 25f39ae1-3304-11ec-83ad-12813bfff9fa;
 Fri, 22 Oct 2021 06:49:06 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id E3BC221990;
 Fri, 22 Oct 2021 06:49:05 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id A440413AAD;
 Fri, 22 Oct 2021 06:49:05 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id AC3KJuFecmEIEwAAMHmgww
 (envelope-from <jgross@suse.com>); Fri, 22 Oct 2021 06:49:05 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 25f39ae1-3304-11ec-83ad-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1634885345; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=GAsfBSRBhYlwXE3GyHCt8Ao1r3itvvqFCqQg0v1jsus=;
	b=SdSUM0FodxI8IXPl1XHMXJhVw3Me2pABjtUdj1hKPdqshPqCIsAAXZqsRZO1aUudUaxmtl
	JuhtTn1OVnzf6RV7Te3zCJgEJIA3GyWHiKamnv57aSsq/rEENoQ9shSlnVgKz/g5U4u9/L
	hCTdddL//8JOOmVeoYV+a8q+iqYfjdY=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org,
	linux-kernel@vger.kernel.org
Cc: Juergen Gross <jgross@suse.com>,
	Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>,
	Jaroslav Kysela <perex@perex.cz>,
	Takashi Iwai <tiwai@suse.com>,
	alsa-devel@alsa-project.org
Subject: [PATCH 5/5] xen: flag xen_snd_front to be not essential for system boot
Date: Fri, 22 Oct 2021 08:48:00 +0200
Message-Id: <20211022064800.14978-6-jgross@suse.com>
X-Mailer: git-send-email 2.26.2
In-Reply-To: <20211022064800.14978-1-jgross@suse.com>
References: <20211022064800.14978-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

The Xen pv sound driver is not essential for booting. Set the respective
flag.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 sound/xen/xen_snd_front.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/xen/xen_snd_front.c b/sound/xen/xen_snd_front.c
index 2cb0a19be2b8..7be9fbcf788f 100644
--- a/sound/xen/xen_snd_front.c
+++ b/sound/xen/xen_snd_front.c
@@ -358,6 +358,7 @@ static struct xenbus_driver xen_driver = {
 	.probe = xen_drv_probe,
 	.remove = xen_drv_remove,
 	.otherend_changed = sndback_changed,
+	.not_essential = true;
 };
 
 static int __init xen_drv_init(void)
-- 
2.26.2



From xen-devel-bounces@lists.xenproject.org Fri Oct 22 06:49:17 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Oct 2021 06:49:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.214754.373522 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdoMf-00076H-Cj; Fri, 22 Oct 2021 06:49:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 214754.373522; Fri, 22 Oct 2021 06:49:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdoMf-000766-9T; Fri, 22 Oct 2021 06:49:17 +0000
Received: by outflank-mailman (input) for mailman id 214754;
 Fri, 22 Oct 2021 06:49:16 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=e5cR=PK=suse.com=jgross@srs-us1.protection.inumbo.net>)
 id 1mdoMe-0005ue-DF
 for xen-devel@lists.xenproject.org; Fri, 22 Oct 2021 06:49:16 +0000
Received: from smtp-out1.suse.de (unknown [195.135.220.28])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id d2eba9bc-ae27-4240-bf2d-f7c2d54967da;
 Fri, 22 Oct 2021 06:49:06 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 5F30621987;
 Fri, 22 Oct 2021 06:49:05 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 27AD313AAD;
 Fri, 22 Oct 2021 06:49:05 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id 4MdyCOFecmEIEwAAMHmgww
 (envelope-from <jgross@suse.com>); Fri, 22 Oct 2021 06:49:05 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d2eba9bc-ae27-4240-bf2d-f7c2d54967da
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1634885345; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=ZGFLBrnqymYc576QWcBAPp39DNchapbOqDccE+bC2B4=;
	b=nPoFYAlsG8eI8QkyTtJ/jdrD187CIaKEB4Pi66VrVfFl0vcOszW9dWtjskMIuFJmaWrTGi
	j5DMQGG6b282uRpPenKQornG6hFnM1Y1PwxQUDx58+8xV9Pkkwpo1qiiW0HR7Vfe9t76Zf
	vrKs9+fZVIPp2gILTgfmowX+yujaT6s=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-kernel@vger.kernel.org
Cc: Juergen Gross <jgross@suse.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jiri Slaby <jirislaby@kernel.org>
Subject: [PATCH 3/5] xen: flag hvc_xen to be not essential for system boot
Date: Fri, 22 Oct 2021 08:47:58 +0200
Message-Id: <20211022064800.14978-4-jgross@suse.com>
X-Mailer: git-send-email 2.26.2
In-Reply-To: <20211022064800.14978-1-jgross@suse.com>
References: <20211022064800.14978-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

The Xen pv console driver is not essential for boot. Set the respective
flag.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 drivers/tty/hvc/hvc_xen.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/tty/hvc/hvc_xen.c b/drivers/tty/hvc/hvc_xen.c
index f0bf01ea069a..71e0dd2c0ce5 100644
--- a/drivers/tty/hvc/hvc_xen.c
+++ b/drivers/tty/hvc/hvc_xen.c
@@ -522,6 +522,7 @@ static struct xenbus_driver xencons_driver = {
 	.remove = xencons_remove,
 	.resume = xencons_resume,
 	.otherend_changed = xencons_backend_changed,
+	.not_essential = true,
 };
 #endif /* CONFIG_HVC_XEN_FRONTEND */
 
-- 
2.26.2



From xen-devel-bounces@lists.xenproject.org Fri Oct 22 06:49:22 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Oct 2021 06:49:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.214755.373533 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdoMk-0007Z1-Pf; Fri, 22 Oct 2021 06:49:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 214755.373533; Fri, 22 Oct 2021 06:49:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdoMk-0007Yq-JH; Fri, 22 Oct 2021 06:49:22 +0000
Received: by outflank-mailman (input) for mailman id 214755;
 Fri, 22 Oct 2021 06:49:21 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=e5cR=PK=suse.com=jgross@srs-us1.protection.inumbo.net>)
 id 1mdoMj-0005ue-DR
 for xen-devel@lists.xenproject.org; Fri, 22 Oct 2021 06:49:21 +0000
Received: from smtp-out1.suse.de (unknown [195.135.220.28])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id dba67d48-c507-464b-97ae-1222a0b714e5;
 Fri, 22 Oct 2021 06:49:06 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 9DF4C2198E;
 Fri, 22 Oct 2021 06:49:05 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 6568D13AAD;
 Fri, 22 Oct 2021 06:49:05 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id wPeAF+FecmEIEwAAMHmgww
 (envelope-from <jgross@suse.com>); Fri, 22 Oct 2021 06:49:05 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: dba67d48-c507-464b-97ae-1222a0b714e5
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1634885345; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=vnxbzvurCjT2IqnAol4LJCGAE156WX5VeQqShoJna+g=;
	b=arr7onqkOvxuEnq7ukxpmkmHGtBkavXlM1ESYmb6I/z38M8/3yUyk2mdS1JKreote2CCOb
	XGmKmzUyWyJarT9sI1LC7htdlhCC8eaKPQu3HfSDJ9ok7Pwa5Pky8ydweK6YEyv/R+ffMv
	WopDNPjgRNqtEFPzR/chBqrhaH0i4dU=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org,
	linux-kernel@vger.kernel.org
Cc: Juergen Gross <jgross@suse.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>
Subject: [PATCH 4/5] xen: flag pvcalls-front to be not essential for system boot
Date: Fri, 22 Oct 2021 08:47:59 +0200
Message-Id: <20211022064800.14978-5-jgross@suse.com>
X-Mailer: git-send-email 2.26.2
In-Reply-To: <20211022064800.14978-1-jgross@suse.com>
References: <20211022064800.14978-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

The Xen pvcalls device is not essential for booting. Set the respective
flag.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 drivers/xen/pvcalls-front.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/xen/pvcalls-front.c b/drivers/xen/pvcalls-front.c
index 7984645b5956..3c9ae156b597 100644
--- a/drivers/xen/pvcalls-front.c
+++ b/drivers/xen/pvcalls-front.c
@@ -1275,6 +1275,7 @@ static struct xenbus_driver pvcalls_front_driver = {
 	.probe = pvcalls_front_probe,
 	.remove = pvcalls_front_remove,
 	.otherend_changed = pvcalls_front_changed,
+	.not_essential = true,
 };
 
 static int __init pvcalls_frontend_init(void)
-- 
2.26.2



From xen-devel-bounces@lists.xenproject.org Fri Oct 22 07:09:59 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Oct 2021 07:09:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.214793.373553 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdogU-0002rH-OR; Fri, 22 Oct 2021 07:09:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 214793.373553; Fri, 22 Oct 2021 07:09:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdogU-0002rA-K1; Fri, 22 Oct 2021 07:09:46 +0000
Received: by outflank-mailman (input) for mailman id 214793;
 Fri, 22 Oct 2021 07:09:46 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mdogU-0002r1-Bw; Fri, 22 Oct 2021 07:09:46 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mdogU-00062s-7w; Fri, 22 Oct 2021 07:09:46 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mdogT-0007QE-Ug; Fri, 22 Oct 2021 07:09:46 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mdogT-00046o-U7; Fri, 22 Oct 2021 07:09:45 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=JbpcahJO7VgN7xE43aAS5fY4kabg64EfREgRr7JMFG0=; b=A7AJMcjjunynh1m8or2+xfwOcG
	MUxBHWmmkZISD7HVvmwg2H+HIcW5rp/+9RX35+nSTZv639hfSIMXhua5UTzFTvyMTwMR4ML9YODod
	VaPgGnKXqaRssfxSqxKIvjrJxGM1oDO0x0cT+LNbCry1GDsJkhIoPY8VzSOIKQcxcKFc=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165726-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 165726: regressions - FAIL
X-Osstest-Failures:
    qemu-mainline:build-i386:xen-build:fail:regression
    qemu-mainline:build-i386-xsm:xen-build:fail:regression
    qemu-mainline:build-armhf:xen-build:fail:regression
    qemu-mainline:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-amd:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-pair:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-freebsd10-i386:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-freebsd10-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-coresched-i386-xl:build-check(1):blocked:nonblocking
    qemu-mainline:build-armhf-libvirt:build-check(1):blocked:nonblocking
    qemu-mainline:build-i386-libvirt:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-intel:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-shadow:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-vhd:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=4c127fdbe81d66e7cafed90908d0fd1f6f2a6cd0
X-Osstest-Versions-That:
    qemuu=50352cce138ef3b30c1cda28a4df68fff5da3202
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 22 Oct 2021 07:09:45 +0000

flight 165726 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165726/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-i386                    6 xen-build                fail REGR. vs. 165682
 build-i386-xsm                6 xen-build                fail REGR. vs. 165682
 build-armhf                   6 xen-build                fail REGR. vs. 165682

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl           1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-credit2   1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-cubietruck  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-multivcpu  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-rtds      1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-vhd       1 build-check(1)               blocked  n/a
 test-amd64-i386-qemuu-rhel6hvm-amd  1 build-check(1)               blocked n/a
 test-amd64-i386-pair          1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-freebsd10-i386  1 build-check(1)               blocked  n/a
 test-amd64-i386-freebsd10-amd64  1 build-check(1)               blocked  n/a
 test-amd64-coresched-i386-xl  1 build-check(1)               blocked  n/a
 build-armhf-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-arndale   1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-credit1   1 build-check(1)               blocked  n/a
 test-amd64-i386-qemuu-rhel6hvm-intel  1 build-check(1)             blocked n/a
 test-amd64-i386-xl            1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-pvshim     1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-qemuu-debianhvm-amd64  1 build-check(1)         blocked n/a
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow  1 build-check(1)  blocked n/a
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm  1 build-check(1)      blocked n/a
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 1 build-check(1) blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a
 test-amd64-i386-xl-qemuu-win7-amd64  1 build-check(1)              blocked n/a
 test-amd64-i386-xl-qemuu-ws16-amd64  1 build-check(1)              blocked n/a
 test-amd64-i386-xl-shadow     1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-vhd        1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-xsm        1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165682
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165682
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165682
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 qemuu                4c127fdbe81d66e7cafed90908d0fd1f6f2a6cd0
baseline version:
 qemuu                50352cce138ef3b30c1cda28a4df68fff5da3202

Last test of basis   165682  2021-10-19 21:09:14 Z    2 days
Failing since        165694  2021-10-20 18:09:12 Z    1 days    4 attempts
Testing same since   165726  2021-10-22 01:53:07 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Jones <drjones@redhat.com>
  Ani Sinha <ani@anisinha.ca>
  BALATON Zoltan <balaton@eik.bme.hu>
  Cédric Le Goater <clg@kaod.org>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  David Gibson <david@gibson.dropbear.id.au>
  David Hildenbrand <david@redhat.com>
  Eric Auger <eric.auger@redhat.com>
  Eugenio Pérez <eperezma@redhat.com>
  Gavin Shan <gshan@redhat.com>
  Gustavo Romero <gromero@linux.ibm.com>
  Igor Mammedov <imammedo@redhat.com>
  Jason Wang <jasowang@redhat.com>
  Laurent Vivier <lvivier@redhat.com>
  Luc Michel <lmichel@kalray.eu>
  Matheus Ferst <matheus.ferst@eldorado.org.br>
  Mathieu Poirier <mathieu.poirier@linaro.org>
  Michael S. Tsirkin <mst@redhat.com>
  Philippe Mathieu-Daudé <f4bug@amsat.org>
  Philippe Mathieu-Daudé <philmd@redhat.com>
  Richard Henderson <richard.henderson@linaro.org>
  Shuuichirou Ishii <ishii.shuuichir@fujitsu.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Thomas Huth <thuth@redhat.com>
  Xueming Li <xuemingl@nvidia.com>
  Yanan Wang <wangyanan55@huawei.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               fail    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          blocked 
 test-amd64-i386-xl                                           blocked 
 test-amd64-coresched-i386-xl                                 blocked 
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  blocked 
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       blocked 
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           blocked 
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     blocked 
 test-amd64-i386-freebsd10-amd64                              blocked 
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          blocked 
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          blocked 
 test-armhf-armhf-xl-arndale                                  blocked 
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  blocked 
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  blocked 
 test-armhf-armhf-xl-cubietruck                               blocked 
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         blocked 
 test-amd64-i386-freebsd10-i386                               blocked 
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         blocked 
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                blocked 
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         blocked 
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 blocked 
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    blocked 
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     blocked 
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              blocked 
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    blocked 
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      blocked 
 test-amd64-i386-xl-vhd                                       blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 2492 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Oct 22 07:17:21 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Oct 2021 07:17:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.214804.373570 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdonl-0004M1-Lt; Fri, 22 Oct 2021 07:17:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 214804.373570; Fri, 22 Oct 2021 07:17:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdonl-0004Lu-If; Fri, 22 Oct 2021 07:17:17 +0000
Received: by outflank-mailman (input) for mailman id 214804;
 Fri, 22 Oct 2021 07:17:16 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=KgL4=PK=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mdonk-0004Lo-8X
 for xen-devel@lists.xenproject.org; Fri, 22 Oct 2021 07:17:16 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 55318682-e34a-490f-ad26-14eefc316db2;
 Fri, 22 Oct 2021 07:17:15 +0000 (UTC)
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur01lp2053.outbound.protection.outlook.com [104.47.2.53]) (Using
 TLS) by relay.mimecast.com with ESMTP id
 de-mta-16-f5U7pMleNFCLQ2fFYNgoXg-1; Fri, 22 Oct 2021 09:17:13 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VE1PR04MB6480.eurprd04.prod.outlook.com (2603:10a6:803:11d::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16; Fri, 22 Oct
 2021 07:17:12 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::8062:d7cb:ca45:1898]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::8062:d7cb:ca45:1898%3]) with mapi id 15.20.4628.018; Fri, 22 Oct 2021
 07:17:12 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6P195CA0011.EURP195.PROD.OUTLOOK.COM (2603:10a6:209:81::24) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4628.16 via Frontend Transport; Fri, 22 Oct 2021 07:17:11 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 55318682-e34a-490f-ad26-14eefc316db2
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634887034;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=DLofXp8OMf2csGMCRx6v5ksl2kwJoumIqOk1JvxTuFA=;
	b=O1ESBE4owwmus7sP0A1ARmH3ZSsYmpgWNvwNG6pyAdO9gE4FeIUPq71+VNLDAoRW+ab8e2
	/PFW0ZxaSDQgwxauDiW1lcJ6DkSjpKHFlFQaj5zTXU++tMVPhVNpmUs+L4U6MUQ7TBl/jc
	tv8nKo5Xn4qBOivz4Fx0cK9G8uzz4vI=
X-MC-Unique: f5U7pMleNFCLQ2fFYNgoXg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Gcaea3sootJs5pf9XkMrUokjo+B0RU6X46Z17KMMADgNMMCKsyjqMXp8N4Q42BNYGpfTzXhhU7Z15pOTEl0e7MW9EPrkMUwX6vwU4uBg8kvhprxHAoxbosMeS1gnr2gVPj/IUAK1AbzuIwwfIEqH5McE1FT8tzjFeFAdmZO5jRlsK31mduadc1WBqzF05LkYg6iFe9/RqXhun1IzLYluPBqItMVV/+wmlCoKd3amCShf520cUjgr2c2SDUuh6bIGLgYF71PTm85aXJMRcm6LSUVN/CHo+n+qbv/x3++ay9yuiFA6chdbg+tI2o37zyiGhVa/6QULVdyeu2rhWq7rqg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=DLofXp8OMf2csGMCRx6v5ksl2kwJoumIqOk1JvxTuFA=;
 b=och8vhGv6SlSWRk2GLttm6MpywEyYTShIhakt+YHGvgTA5yvPeiNkkbqpmJZVBqsEqkmgc/cPgOLAJvv1bKKGn9gz+c8F5cMiMUrn5+bOOy9S85eM8NcSLH1LqfVOx7JK0TuAPESDGCQm57ny1OGn1pOZWLMJSd0d96M3jAN1N7y2ky9uLnCJXVYCPMGu92EiARblad5aLf/+F/I1Lw8Nr1N/z9BLjMyCNCGPQYZUISMZ8PDb/+S1XrRacO9osxZrH4WhYaBGkSrBZ0lcQR/6QksIS6SYAZXn0iboH0QnaULrYBOkHvrS/WfbTrfBRYcNp95QiZtyLiZ9UihFa48dg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=suse.com;
Subject: Re: [xen-unstable test] 165712: regressions - FAIL
To: osstest service owner <osstest-admin@xenproject.org>
References: <osstest-165712-mainreport@xen.org>
Cc: xen-devel@lists.xenproject.org
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <9b994413-d9cb-dfaf-0ffc-327c8f34096a@suse.com>
Date: Fri, 22 Oct 2021 09:17:09 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <osstest-165712-mainreport@xen.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P195CA0011.EURP195.PROD.OUTLOOK.COM
 (2603:10a6:209:81::24) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 087d1784-8463-4d73-7fb5-08d9952bf79a
X-MS-TrafficTypeDiagnostic: VE1PR04MB6480:
X-Microsoft-Antispam-PRVS:
	<VE1PR04MB6480508FEC202F6F26D2FB1EB3809@VE1PR04MB6480.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	acrYMWGGBx/1U1Hmn79gUsNVQcOsThKgM44oThYhT/xkRmAzEnoXHAbJyB/QUT81gNu8F0vVE7olfELTMwGqfiRem9nMpspJy2XPLsYOnBBVfzxlUwTzw+tfQBSCJMCt9AsL8Zn9Rt86MtJhQs7Gggm9BEL+q6WmIiaimxX/PkNbx+/itKyeajAg4sqcNyWO4oAbi7ZkWa3rinwZ4hOwT4QM2fWI7rOzowXSBtuK7bGFHfsCyO2PYgzMAVEvvm4dG1Wub/olgP2JLURQ2S7bA8E1bgmDcNPE4dzQSCWvZH1jcaafCojnemyjK8/wq0s0OGRTHLGh3dj5Spo6UbQyhmvpH9s0AapPSFXXvagAhyC6SUbbx3LZyP1B/rXpoVziq7tiC6LJ6oflJD3i1f2ZysZmR0BtEimOBgrqttcUy0DMJFj68oiHILpflpuq0FwVPHXfM8RRMDlGveejzTmM1xkVwVkHAJDNTFGAm6NlMV/tOUDVLbx+EO6mgWa6pNXB08F9tGC1RLL+5a+4u0LwP1xP4jBTsS7Cpt03QcmvgrzP7nFxaYMiumcSA634+Sl8J37dWaYChq4hXZnaUBY2r9Ckl7iLrEp+FO0ln4sMMoEZAsCd5uVMTwdAphJH4y2znOW3kkX+zhPi9w7wx1no7OrH4YmJATr5KUwmDFaciZHGp3ojN9Ol99c1KSdSZ3NyWnBS2VoByDNENJQKZH9LyDcZ2nSdzbc2h1MXr92QfVSJmkG0JjCUt5zONB+ES5IruexkzOu1WhDvcmhS5vAexrK+36WsXZiaa9JWX4gFXMLNmmpHC4suAR/bX6q9zTnS7oHzjyrmCXB12oIC4Ofd+6e91G1IA8HgXAurMMvsWrU=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(956004)(316002)(66556008)(16576012)(508600001)(66476007)(6916009)(31696002)(8676002)(8936002)(186003)(26005)(83380400001)(36756003)(966005)(2906002)(31686004)(5660300002)(53546011)(2616005)(86362001)(4326008)(66946007)(38100700002)(6486002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?a2tMNC9HSEZiVTIxVnVtY0VhcURkQ1AyYm5ZUWpDbnZ0VnhMUUhSaTNndlRq?=
 =?utf-8?B?MTJiWnZ2OVNKQTBGRGM2U252V09rVld4d3g2eUN6S2ZoVEhDMVFjL0ZLZTFy?=
 =?utf-8?B?cWROcmlzcmwyZWFNNFE4VlFUNDE2T1VjS3dRb09OS0NRYmt6bllKbGJRdjBs?=
 =?utf-8?B?NWh0R0N6RjdxeXdtQ1dIb08xdGNGTk4xWnR0T3J0WTJkblNuT0MxelJXTzJB?=
 =?utf-8?B?WWZJSUU1bmVwU0ZjaE1hVmJoL3JFQ0luZWJJZVZjb1JsYS9rSUFvckcwNkVT?=
 =?utf-8?B?ZmdjZWdrVFJ3YTRwUFl2SkRvdnRRaG9KZGd0UEJZWWdFcUh5bjZIRzNKKzRC?=
 =?utf-8?B?VnlWbXNibVZ2ZElSdVNBa2xJUDQwNGg5S0pnVk9HamVuVnZzZnhpbE4reDgy?=
 =?utf-8?B?dVZEdzMwdnkzNmQ1KzhQYXkyc3lJdFlab1Z4aUNtYlZPZHNqY2pTUkllUkpH?=
 =?utf-8?B?andVTUhVYk1NQ2JZMzBQdjQzR0EzWkFPODJBNHorVTk4SEIxSXRTaUVVSVhs?=
 =?utf-8?B?Tldvc0FUK0w1MmJadVlhb24rb1NMTzBhdHJOT0FDWGMyMlFLSVhKeWl2dUpE?=
 =?utf-8?B?S0EyS2k0UkViajhsZW1TdVJGakJoVVpMeGhKQ3ZrbHJNQlVGOUM1eHl3SGM2?=
 =?utf-8?B?RUk1Y0hXY3Bnenk4RlNEc3Z6NkFEVm1RVCs2R1dyZW1uNUwwdjNBZXQ1bkhX?=
 =?utf-8?B?Nmh2ZkVKQnNnN1UrYkhJcHltY1VlQm9HeTZ4VlVWR0lTT3laeWtCRWRzcURl?=
 =?utf-8?B?ampmY3hoM1VIWThGNGRtRXh3N2JSWnFKOEhSWDc5RWt0bDFObDdITmdmbGd3?=
 =?utf-8?B?YU56NWpORVkrVlMvMXgxcitBZHE1VFdyYy9wVmJPeEpRQTNjc0hwUk41Q2s2?=
 =?utf-8?B?TDZkbytyWXRKOHpSL1VkaUFLMW9sUmtTNS9kTnlNUnF6TmV0czRRSU9YcnZV?=
 =?utf-8?B?Q3FReTllelcrRDJVVmlob0VVUHBnQVBpYWxCbEpPdWNvZi9tL1V1SHF1cldL?=
 =?utf-8?B?NGVGamdHWW5jejg5eGlKSlB4c0JwY2t6ejJDVC8vY080Vy9vUWRvMU9LbVZW?=
 =?utf-8?B?b3hsTGowWnhnZkI1ODZFUGV0dGlLOXBuc0I0TEQ0disya2hJbXBvMzBYMHNt?=
 =?utf-8?B?cUlveXF3TVJHNDkwQjJJWjhNc09LdTBFY1A1aFF1U3pYOW1XZ3FqNjF3U0dv?=
 =?utf-8?B?Slp1WUMzVEZSNEhvL1J3a1VUZFVKa1Z3ZE0yR3FlR0NkcGpQM2wrek5kVUFY?=
 =?utf-8?B?Z3F2c3l0OXNBMDBBNEpienRhekdvUUJ2SE1hR01QTG9qazFIbHdLeWZXeHlv?=
 =?utf-8?B?WGxMZFk3YW1oQkRPZFdZNjlQZ0o2WWMrUHRqeVlBSGZzSmdaU0kxQmlJVVo4?=
 =?utf-8?B?MC9Hb1pHOW5hQW1DSHRVU1lpSXk0YWg4VWo3cWNlUDNQYXc5SXR1WjdDN1dC?=
 =?utf-8?B?bE5ZWk5MeHVjVXd0SG01cnlwOFlWZFhUZ05qTlN0R1l1THpJS1k5Ti9zVnlQ?=
 =?utf-8?B?RExWRUlqYTZoZmtCeEE4WEtoNloyanBrZHZoMGdTTEJCcGtJUDVXODVuTjJV?=
 =?utf-8?B?NmNFcDk3MktoRkVOV3lPUlp4aTN5TVZsbXJ3OVlZYVB5dUloaEJnZ1V3UEN1?=
 =?utf-8?B?ci9TTHRXOFA5NTZoZlVyUzNuZEpTZGQxYUpJOGZ4NGdDQ0hyblRENVhiMEJ5?=
 =?utf-8?B?YmZjSkZPcGVQQ0FJNTFHUGJJRzJuc04zWmhOV2tNajJyTzI5SWU4VHRqZjBW?=
 =?utf-8?Q?LEAF6D4mikkcfFYiujGSJezPGxcT/5R199tSnzJ?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 087d1784-8463-4d73-7fb5-08d9952bf79a
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Oct 2021 07:17:12.1544
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jbeulich@suse.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6480

On 22.10.2021 05:10, osstest service owner wrote:
> flight 165712 xen-unstable real [real]
> flight 165727 xen-unstable real-retest [real]
> http://logs.test-lab.xenproject.org/osstest/logs/165712/
> http://logs.test-lab.xenproject.org/osstest/logs/165727/
> 
> Regressions :-(
> 
> Tests which did not succeed and are blocking,
> including tests which could not be run:
>  test-amd64-amd64-examine      4 memdisk-try-append       fail REGR. vs. 165699

As suspected it would (in reply to flight 165539's report), the issue
has now re-surfaced:

Oct 21 15:48:46.003369  Downloading NBP file...
Oct 21 15:48:46.003385 
Oct 21 15:48:46.063364   Succeed to download NBP file.
Oct 21 15:48:46.063382 error: serial port `0' isn't found.
Oct 21 15:48:46.159379 
error: can't find command `timeout'.
Oct 21 15:48:46.171404 
error: can't find command `label'.
Oct 21 15:48:46.171420 
error: can't find command `menu'.
Oct 21 15:48:46.171430 
error: can't find command `menu'.
Oct 21 15:48:46.183366 
error: can't find command `kernel'.
Oct 21 15:48:46.183383 
alloc magic is broken at 0x7a59fac0: 0
Oct 21 15:48:46.207389 
Aborted. Press any key to exit.error: you need to load the kernel first.

Jan



From xen-devel-bounces@lists.xenproject.org Fri Oct 22 07:24:53 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Oct 2021 07:24:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.214812.373581 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdov2-0005lo-F3; Fri, 22 Oct 2021 07:24:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 214812.373581; Fri, 22 Oct 2021 07:24:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdov2-0005lh-Ba; Fri, 22 Oct 2021 07:24:48 +0000
Received: by outflank-mailman (input) for mailman id 214812;
 Fri, 22 Oct 2021 07:24:47 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=KgL4=PK=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mdov1-0005lb-CQ
 for xen-devel@lists.xenproject.org; Fri, 22 Oct 2021 07:24:47 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 62994078-b034-483d-a5e5-e01efd457295;
 Fri, 22 Oct 2021 07:24:46 +0000 (UTC)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2113.outbound.protection.outlook.com [104.47.17.113])
 (Using TLS) by relay.mimecast.com with ESMTP id
 de-mta-11-m3b__l39NUGNKSFgU8FKrQ-2; Fri, 22 Oct 2021 09:24:43 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0402MB3773.eurprd04.prod.outlook.com (2603:10a6:803:1c::27)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.18; Fri, 22 Oct
 2021 07:24:41 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::8062:d7cb:ca45:1898]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::8062:d7cb:ca45:1898%3]) with mapi id 15.20.4628.018; Fri, 22 Oct 2021
 07:24:41 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6PR08CA0026.eurprd08.prod.outlook.com (2603:10a6:20b:c0::14) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4628.16 via Frontend Transport; Fri, 22 Oct 2021 07:24:39 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 62994078-b034-483d-a5e5-e01efd457295
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634887485;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=+5aA5JWunl6cDqlrP3RRxmbEkj409sVyOwlDKFt7cS0=;
	b=WzbQBjllQSyI0ARbHsYNNTA6qb/y7X9GQ8F0z3mH8XX7HMsPaJcKxFYrqYedCTGFiAvQHR
	uCZj2Ha/uvvUlNbVcKnx7HEwltJLvu+fevDFAwNhTegALwAuEZTuFiKe8g8ATLhpOl8lLr
	HAj8c/O7vd8NjG5Y293vFFexjIehPsE=
X-MC-Unique: m3b__l39NUGNKSFgU8FKrQ-2
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=aXoOIjkVHXyH5VWCgjKdEjml89yYP7/LIcWtUHQLKHKKAaBuw/FztvcuwYAdNTDeSY1QOWeIjsk4/FFzXRg5dt3LGhrgnzihSpiqlCtX6KrdMbbBIxNHJoEisJM7BBE5534nrcjXDgyaEEqfIU4CWTw1rQWR6RDX1S7/f2B/7GKapnpH2MQ4ZJhFiA/PK5D3/jBmZasLnM/svcOU6s4ZkII1gHKG/dU4d36hnTXelswSMfP9jgRltVwb3ZJ1Iz2bO7UxwnN9pnTAQGubWi8s5n2RTq9VBcHYhZkXf39yCXbwrfcEaMkg8K+TCraZcJnH7U4jOBZj1hTuYIkp2m4y3g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=+5aA5JWunl6cDqlrP3RRxmbEkj409sVyOwlDKFt7cS0=;
 b=GxOR6EOi9zZFXx4heDfh7T7WIJHUbnEwKGjf2jWrKGiBO1ffakSznMxsMluYZnTNc14j4vUvzkQcLZgCkZn4ars43i2k8VKpBd2MpAqTyAjCWoTRwSxvgHfhOveGh0BYSb5QTc2gssMvIZdLtQKpJFhJ9jZMg2ZUlXx+yfwdPIutOKOB+O3kFu94Il4K+6YznmkkL+njLzsg5Odz2wT7NBmAN9WYoPqWIHBJvHtxJ0sT4ew1EhGXOsQkUen/4fA6qiKzg9jtYtF1tCC0L+LPWA7LULUrOgEmkPJYCDQcl7gBbfXU6buJYwSqHYB1Q6pRvZJoG9kdsLrWOfaKGMMSKA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Subject: Re: [PATCH 0/5] xen: cleanup detection of non-essential pv devices
To: Juergen Gross <jgross@suse.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
 Boris Ostrovsky <boris.ostrovsky@oracle.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>,
 David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Jiri Slaby <jirislaby@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
 Takashi Iwai <tiwai@suse.com>, alsa-devel@alsa-project.org,
 xen-devel@lists.xenproject.org, linux-input@vger.kernel.org,
 linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
 linux-fbdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
References: <20211022064800.14978-1-jgross@suse.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <c4f534f1-8f07-085e-6a10-edbeb884d1a4@suse.com>
Date: Fri, 22 Oct 2021 09:24:38 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <20211022064800.14978-1-jgross@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR08CA0026.eurprd08.prod.outlook.com
 (2603:10a6:20b:c0::14) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: cc72ac65-a16c-4d9c-8173-08d9952d0344
X-MS-TrafficTypeDiagnostic: VI1PR0402MB3773:
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<VI1PR0402MB377313A7B9A58A00D8058630B3809@VI1PR0402MB3773.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7219;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	eijGHaq8+NVKXLDZhehKwUeaePIgKPgdNtejen1dJaLMwLom6gN6l47L2jjlP2OHc3/ZKyR9bNw8qrZZ6Ryr9Y26a80XkUL/24rCTNLMj830Th1VAf14Vf/c6bJE1cFldGgjdII0mwwT56T2eDgHJNREnjeZ9Y6Q61Rfc3XdExTvCrvBkcQb7V8c2j2TrCPjTNwga6cEm7JjvWcDBf61wzSZUajzKTPMDU6uDxlgq/5sXrPY45swTMpsq8sYbVZyQuUG5TN6zua6eS05HpxSrRk0QwJL9mLXu6B9x89ljwnULfXtgVLmfsIVsU+BJ7HekTPigHxtjTwDaFMj8wFyzZGp6eBWnEHe/kJhSY/9qS/ETyD+IhNb769awtoTAqvZxIHZRfDV4Oqn2++hHi2eSmhHgqchQXD0a8dJZiA7tcWWH87ATijpe5YqT/byWDk/IvAV7jlvh+5M4tqX9G/4ph0BeJb/t7iA6Aym8ekhI/4B8K9EVHy5MfuCaKa99TZkCz7DGR970jEZhWymnsRtQ+9JcxwlFgAQVL4AV6XZXOaSEKFu+q1py/wmH41hblBUDB3yFHkRGSzo6Lpta2lc/ZuLD6J5N+QEeshoPkGc8F9BeWjYHSKEklMEJ4IeaJLMIW3tEu2e1dNuAYtc/7Az1rF3D+mDVyh6ioEGxUtDXATfQz3AylIsGYDNWLVXswvQv9k0UttmJy8+SzbMC0h2WMJLGj2GK/t1F5OxgWMKYKL104t4+voxDSuDzFyeJ/4L
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(86362001)(54906003)(31686004)(8936002)(16576012)(2616005)(38100700002)(8676002)(5660300002)(6862004)(66556008)(4326008)(66476007)(316002)(6486002)(37006003)(508600001)(956004)(186003)(6636002)(53546011)(31696002)(7416002)(26005)(2906002)(36756003)(83380400001)(4744005)(66946007)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?c3Ztb0lBL1IyZ0N1N1VWTDg0Z05tOFlRWTRkSmFINWxuZ1gvSDhBVE5JMFB6?=
 =?utf-8?B?L1BaSGZPVGc0VmZjeUh3aVhDZkc3WDRmYmNlTHVSZEpZdFNPbkJrTVZwOHhq?=
 =?utf-8?B?aWNGd01QQTdObE9NZGtzcGFxcHJpeFErc1lEa0NsakkyUzVOYmsvNWVZOHpK?=
 =?utf-8?B?MWxqTmgwcHoyc0s2SERhNzhtMWwxeEQxWU9XRGF1RTJuYUpyU2lZL3Frb3cz?=
 =?utf-8?B?T2hzWDlpcXF1R0o4eUt5aktsUXhzT01qL3RsWUREQ3JoN2FONklNKzV2RDRW?=
 =?utf-8?B?bk1NWmcrb0NPOUszN2Z2OEl0V2JXN2Jsc1pXOFBacytCUW1MckFLb1FtRmRO?=
 =?utf-8?B?WHhnUE5jOUViUFNIVWxwTld6cS9paFowWllJU1RoMUhGRzluWVlzaVNRc1N0?=
 =?utf-8?B?VzJMbXJZWmozQ1dtZ2RUb2VMem5zd2F2Z0tIcnRGUXlNM0hEZlZtNjE4TEtK?=
 =?utf-8?B?T3pwM3RyVllNcm9LWDhQTFlNbFlrd2N1R0VSRXZiU3Jjd1VxV2hYdXhTRi8y?=
 =?utf-8?B?U2RzOHBtbkZQRk9LUFNpMVhhUnVMSnMycVE2bmJOYmU3MmpocHg4YWJMRTZ4?=
 =?utf-8?B?Z0FqNWxDVno2bGUxWHFlOWRzWVBjL2lUZERTM1ZWSnFjRERqaldtQ29NaHZN?=
 =?utf-8?B?ZXZLR00wT09mUElQNzVrdDY4S05sWE5iQmkwRlhUSmM2VGNScmd2Qk1tQ1Zn?=
 =?utf-8?B?djcrZlR0ejBwdHdGTUFtSDVFeDBYZUg1em9GY1NQV2FPcWdxMHJaeUZtYkVB?=
 =?utf-8?B?bHFzbEFzMllLZDFmYVN1bHpMZ0lDOUs4VUpTRTFjTUNEeHhISFZvcVhEeGF1?=
 =?utf-8?B?dTdHSFJiakZNWmR3dmc3TTg5d2dtYlZKeDEzVzdiOU9sUWNEOEdVMW9vY1BH?=
 =?utf-8?B?cDhPTHljcnhnNkFPbnZwb21kMmdJVnpZY2REbXJhNTByYTRKclNGNXNEZVJE?=
 =?utf-8?B?MkhOZHJFNW5vTEZOQm5rM3pkeGVtbmtrOXhDaUZLbU85RUM3VlMwYjBCaktJ?=
 =?utf-8?B?bzZRSFdxMW1TSGVtZ0JjZDNnSnk0dXQ3SXY1K0FFbkhYUEQ2V1l5M3RaTXFr?=
 =?utf-8?B?Qlc5YUwyTWFnK1ZZcnYwa01wdjFKMnI2NTM4MVJtRnBiZDc0NEF6M1FhVkZG?=
 =?utf-8?B?a0NQM1hyM3VzYTRyWlZyS2pGYmIraDY4RUZDRWtIT2VOZ2ZKWkZGb3BObW1Y?=
 =?utf-8?B?RnQ0eE54cmFZKys5aTFTSm1STng1TlcvTzNQZE9XaEJwVW5wVmJtNTJwVnM3?=
 =?utf-8?B?enQrTkgxaFhmT1NVWHFCdC9qQi9iYlRwT0F4WmVFVTJaZENxdWtSSjNHczFk?=
 =?utf-8?B?dzJMTUxFZFZqLy9uOFFYTXFtd3BQSE5vYy83dXpTNXFwQU0veTFCem94Tisv?=
 =?utf-8?B?WmNPV0F6YWV1S0U3SXFlUDlINlFQZWliOEZqZ1BhRzRPYXVBNlB2dTllUEEw?=
 =?utf-8?B?RVRMTE1MUU1YUGRKY3Vyak1pYkhobTNKR0wyTjNDMVplYWNMUXpINzduWFZF?=
 =?utf-8?B?UHQ5Yzcxc0hRTlltUC8zdTg4MFZrbGx4M21DY3g3NzRkVUVKc0ozSHZ2TjNP?=
 =?utf-8?B?YkZlS0xuSjFjSWhUSXE0RlFIcWFLemxYZEFIVVowUThocjh4bloyWUNpSndU?=
 =?utf-8?B?djVuUHB4aWdoZEV2ODg5dFlRL1l4RGhTd2htYzlicjR1dDZYS0VLOE5Ta1pn?=
 =?utf-8?B?KytUbG9vSUh0VGZvSGhFbVNQYTlwNXV0cElTWGNtb3A5YkZsODMxVGs1OHRm?=
 =?utf-8?B?VFJPQ2I4dG9NUU1xbVUzcGZSMVcyMHlpTU9JZXk1L2hSa0JWaEZXeUhpYk5S?=
 =?utf-8?B?SFlvU0JLaEFTR2F2MlhCOUtlYjB4TXRpaHB6N1ZjcVNaTlI4aFNuV0J5SXJM?=
 =?utf-8?B?VFlsKyt1UG9aSldtbVVVanFkandENWQzUEJwSWphQXpLTEJvM0NkaC9qRzUr?=
 =?utf-8?Q?YhrCTgfmS1s=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cc72ac65-a16c-4d9c-8173-08d9952d0344
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Oct 2021 07:24:41.2263
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jbeulich@suse.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3773

On 22.10.2021 08:47, Juergen Gross wrote:
> Today the non-essential pv devices are hard coded in the xenbus driver
> and this list is lacking multiple entries.
> 
> This series reworks the detection logic of non-essential devices by
> adding a flag for that purpose to struct xenbus_driver.

I'm wondering whether it wouldn't better be the other way around: The
(hopefully few) essential ones get flagged, thus also making it more
prominent during patch review that a flag gets added (and justification
provided), instead of having to spot the lack of a flag getting set.

Jan



From xen-devel-bounces@lists.xenproject.org Fri Oct 22 07:24:58 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Oct 2021 07:24:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.214813.373592 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdovC-00065K-Nz; Fri, 22 Oct 2021 07:24:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 214813.373592; Fri, 22 Oct 2021 07:24:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdovC-00065B-K8; Fri, 22 Oct 2021 07:24:58 +0000
Received: by outflank-mailman (input) for mailman id 214813;
 Fri, 22 Oct 2021 07:24:57 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=uKjo=PK=epam.com=prvs=09292fbf9b=oleksandr_andrushchenko@srs-us1.protection.inumbo.net>)
 id 1mdovB-00064T-7P
 for xen-devel@lists.xenproject.org; Fri, 22 Oct 2021 07:24:57 +0000
Received: from mx0b-0039f301.pphosted.com (unknown [148.163.137.242])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 4da5310d-7e42-4127-9d4a-7c43971ca86b;
 Fri, 22 Oct 2021 07:24:56 +0000 (UTC)
Received: from pps.filterd (m0174681.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 19M73nBQ010281; 
 Fri, 22 Oct 2021 07:24:53 GMT
Received: from eur02-ve1-obe.outbound.protection.outlook.com
 (mail-ve1eur02lp2057.outbound.protection.outlook.com [104.47.6.57])
 by mx0b-0039f301.pphosted.com with ESMTP id 3burjyr1su-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Fri, 22 Oct 2021 07:24:53 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by AM0PR03MB5940.eurprd03.prod.outlook.com (2603:10a6:208:15a::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.18; Fri, 22 Oct
 2021 07:24:51 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::c038:e032:595a:651]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::c038:e032:595a:651%8]) with mapi id 15.20.4628.018; Fri, 22 Oct 2021
 07:24:51 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4da5310d-7e42-4127-9d4a-7c43971ca86b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=WnRBkMG+2euy8J8zNoitLPCHvkHB1fAT453TEggDPKBIY09v/qFITF0ldr4CObPmxsR/9IMZPDW+e77Rg7wBq6Go7a86o5Fi+Ij30ZqMtWlDrKf82nii2f1og18WzlBs/mmvZ8hEkW0cboQjvWGq5VCwjKAme0xcWWcVUIZXr3UwlqXP6NLLV6dcOZStP40jSPfoSAA8l/9kngSN+EFD4BfixQpb1uUXH9aXxUPaGKa3aHJwmMyXGmfUOwKEHFW6Fq2leKIMe/04P5HbkpHOIlW+1LsfvqAb+Cr+5TrFW8ZLoliYAVgsDM22oVipkPXaQwcV+SfBzEXeE94lEbsRUw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ImDmBO/Zg0RkZF9Xvf0lQkTb0mSLH2BIKOqkes4c+5k=;
 b=G7fH1QKLaZ+4q8h0hpt0w9WgEoXHLiAeIsV9zAEqigyoyzzcVUcz5lR1XVJz7V3aJEbOC7kbkO8FnEH+oRRoTYbpv4X5hPYGed9DgaqnYWxE76H2Y4A6gXm/qwKZwKjXrFKQaIfXQzPRfDir6eS8xt/Un0mBnmq5vvvkofe7e9BEHPm8nzZ1MLOjhR+ON7X+069zmHevZVTvv20X9htrGPWnEqLhFlin0iAFjKvGk5QKa1kV6DeO6yrMgFxYIGR7JbRmsacFZGR2Ua8iRP4dYXP7OFxsrx/mneyQNCWPqp2xUD1w8ovB2Yvlj3C+wJ0F7qaO/qW6E5XYYELwyX9F1g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ImDmBO/Zg0RkZF9Xvf0lQkTb0mSLH2BIKOqkes4c+5k=;
 b=VS2sFtOfQElNIiktqvaMYKr4dq3w0x4gAnzCatzQzIs8TQcm1yZaoVOUYFkWVmO7/l3GXdk0rG7sNCELlwohkcD81+sSr+SNBvg7vArpwcqDQoah90xeMmKp8b3J6P0x/MzGGirsMCLkqX5hRTkYNs0PZbF6UdiYlWs1sjjko8wEes56zkkE0Odm9I0DgIX78ndFBOyDO5V40hG7jzg+x1WhWET7ltobw/hYE3aNj9Xbb1UIMph+s/z6qnWLODLIdZWF1uzLH3c4/znCt9rZKRQhDLkHf2866Urg3lfaZFgug/6opSA0U4u4Pi6WzVM5w3IB8hEbD1T8cROmfhSkog==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Juergen Gross <jgross@suse.com>,
        "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>,
        "dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
        "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>
CC: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>,
        David Airlie
	<airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH 2/5] xen: flag xen_drm_front to be not essential for
 system boot
Thread-Topic: [PATCH 2/5] xen: flag xen_drm_front to be not essential for
 system boot
Thread-Index: AQHXxxDqTORWeHdr+U+rFmdTnLsW1KvenauA
Date: Fri, 22 Oct 2021 07:24:51 +0000
Message-ID: <63cfe3bb-93cf-2c5a-f33c-8f81d738c249@epam.com>
References: <20211022064800.14978-1-jgross@suse.com>
 <20211022064800.14978-3-jgross@suse.com>
In-Reply-To: <20211022064800.14978-3-jgross@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 99a71d77-93d6-45ed-9a89-08d9952d0996
x-ms-traffictypediagnostic: AM0PR03MB5940:
x-microsoft-antispam-prvs: 
 <AM0PR03MB5940E2FD6F852DE4AAFF64DBE7809@AM0PR03MB5940.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:4303;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 fyJxnzigc6FWLbOlEv92G3q95IH0qqCTn88Cixytfqi19a7zfQ9FLMFOjHRE/aL4ZCqzyxULByeJReSZYL58pMEYEU3dZG6f/F+Bs2HQ4gEg3wBkUNS9GwCaa+4TZhk68IxtRInTKhwQRMEM+IbUfGHTy+psDjp58sRc2AFuKrQgl/gwkOKYtZyKc03TfmN9YlJbp1Sc6BeLbX/1VcKMCCn7fwjLLECTsRwSymVxElk3Ikagj6tK0nGn8yXzZfXR8Ch+GdBseB/wAC9zqe7o62pTLEhGm6i7DTrARmUya5ElX5pvszoeLufFw3Z0SRkdGGM8nOqFqVuGj11do9pQpefLc2xOCvEtZDk+xQh0bjjv3zjlYyQBj9O1gNuiftpt549X1HBb8cVt7moQb6LSXdfhPHutwahoAKnVWGi0NNIyKBPyaFWCIMECtO8GTK18H09fwj3tUJPZJoiwOBqyxWj8qih0fVcafByxP+81it2dHKM9TDK3ZiUDHh5vUEMrkDewHJjRcIg0ELyM15dzvWA8Laa/QH7QYt5r4YWf/SlcvtEltyrDqc8TFGjVd4N1UY9e6WqlCLhg6ScH2S0un8P2XwPUVmTNMqW7DcopkBupROvct30W6gqyojIXfDpuRDa2i61iBngZzuHujShWK4K8BREubkODr3hMex6691QeEEJkXD0OSjH7czKdvqLxqQIbCMCBSk1sYkkimqNehmJbQyl7dDdwFnCLHjxwBVT3b4S0UIJulcCLMx5XcHGd
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(4326008)(186003)(66476007)(76116006)(4744005)(6486002)(66946007)(2616005)(26005)(66556008)(91956017)(6506007)(8676002)(53546011)(71200400001)(5660300002)(8936002)(122000001)(38100700002)(2906002)(38070700005)(54906003)(110136005)(36756003)(6512007)(31686004)(31696002)(508600001)(64756008)(66446008)(86362001)(316002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?WmVSRkdjV0diYzlZZ05wWUlLQUtTMHZyV2trOVQ4TmNqZi9YZzZBeE1iYzhF?=
 =?utf-8?B?dnJ6NDNyMEU5MlQ3cjd5MStzR3oxamhBT0Q4UTdWZkYyaFBWUUU0UGFjK3F6?=
 =?utf-8?B?RUZLVVg2b2U2cVpYcWxzT2V5VGhRbThoYXFTSHJKRFNQNCtULysyY3g1MWU5?=
 =?utf-8?B?c3VKNTMzR0JSQzJqL3AyTUFLdWxnYXhrckt6YlJLYlU4enZTUU8vbkl2MW0z?=
 =?utf-8?B?eU9PUkJ3Sm4yWVI5MXFmSkdMMktGWHVSb3dCdmExSkRVcjFkY3AxdU1pOHd6?=
 =?utf-8?B?UXdHT3lkakVKTFNQRUx5blBwdmRtUkFDYUFhOHBKWFp3TTRXeXViSUdiT1BS?=
 =?utf-8?B?dUlqcGZ2YlNCYUdPU3RwWjc5YlVZcTF0ZXhkVlVJdXVNV0hKRi92T3kyUUNt?=
 =?utf-8?B?NG9hTm5RZFNyS2ViVXBCaXg1b2hVeGlBZmlJbGFwKy9HT0kvMzI5L3JHcTFn?=
 =?utf-8?B?bWpKRXBKNUU5QVlYU2tyNFZKemVIZ3F2S0h2d0N4Wk9uWEJnMlloZUN1azE4?=
 =?utf-8?B?WDk4RllxajVlcFNlZ2plQUxlc0taSWhyMjJGTVhqYllIWGZhNitvajhUeGln?=
 =?utf-8?B?NXJST0xxdGpJS0xteEtRcDA4Y2pOUWROaDdJSjVlc0dMN3dlV3owMU1Ed1Qz?=
 =?utf-8?B?Y245Ym1wVjVXeG1oNnlDRjJGUTc0V05PWStEakl4TFh6anl6YXpyc2paQUYy?=
 =?utf-8?B?OVgyMU9GS0J4eVNWQXdZYWRxSytpUHlBazJZcG1KSGFjcG96dHZpSWVkaEhx?=
 =?utf-8?B?VTEyMFRNS2RtZTVLUGxjQk1DS3VUcUtHcG5VTXVSK3dLL1JleWI1L0FSNGdO?=
 =?utf-8?B?SHd0R2ZiUEE5YUljVUZYb044ZmI3ejFpaFgxMDZHRmQyMU1BbzRCeFJvM0d3?=
 =?utf-8?B?S0R5bjM0aFBKOFVCdEVQR1VBMFJ4eGh3QTR5dlk3VUt4bHl0ZFg5UTZEdloy?=
 =?utf-8?B?UjNqY2FrUm1obHRNUmZnT3RIL0Y3ZHAvLzUxT0pnZHBWSnl0dkFFS0JKZU5j?=
 =?utf-8?B?dlpZSGZVZ001ODB1a0Q0OGpVS1dqZC9ReEhoOGZtbGV6Q0I4YTRRL2lRQ1Z0?=
 =?utf-8?B?NUVyL2oxd1dzS1dYemtxSDd4Rlh1cnY2d3hiYnhyVU9QU1YrSXNQUE52cnZn?=
 =?utf-8?B?YnUwMktySjFuMjhiNUpMalQ0UVpxb2t3QnRMT3BrNWJCWjVZODFVdVVFNEpu?=
 =?utf-8?B?Ni9FMHpsdlN5aHh3amlLOHZyWEdybDFYQXlkeHV5R3dtK2p0akhMejN5SXRl?=
 =?utf-8?B?YUVnVHJWS25xbS9Qd3A4VXFqeVhWK0VOUnI5YzI2dEg5NjVoY0pMaW93YXY2?=
 =?utf-8?B?QlpIREtQcGZmZ003amgwYVEra1ZzQnVFQWcyaHNWemYxQ05QcDkrdFlJZ1NV?=
 =?utf-8?B?OSt2U0FwMXhCYmhSelp2Y3NEaEg0OVVKQndXQkFqWlNYR1ErdWVkWlkvaEtM?=
 =?utf-8?B?OThFcnVjR0VVc1EzQnkxVVRlTlR1WldSYmpCTExTQ1NvblNIY1RvYWVOQXVR?=
 =?utf-8?B?VFNnaXRqMjVCK2ljUW9qbTNvOXE1QlVseW85ZGxMUG84RTdYUnArbnNoNnNT?=
 =?utf-8?B?dndPSWFJVTlyWUlpdXRvWC81ZC9TcG5iSkVpbzZpZ2VrV0tKQ2JLRDI5ZmZk?=
 =?utf-8?B?MkZUVVNPV0plVXpESXNnQzZlbXNBSEttWkphRFdtOTFCT1h2TDNnUncwYUlV?=
 =?utf-8?B?dEl0NTlVL3RpbHpyRFA3aDdtS3RQamNPK2xCMFExbnJxVG1LQjFrWHlkd2NW?=
 =?utf-8?B?UCszMUlxNUl5N294N09RMGlWTURmdlh5ZUZDUWR6bnRNWmhBd3VzQ0kxNXRx?=
 =?utf-8?B?Njl0aU5HMndBZlJqWTM4ZHFZRlRDN1FRZ2ExN2o0b1ZGZTRxTHV4L0lmVk5w?=
 =?utf-8?B?Y084L2hSOEV2UkxJNm83ME1xNEhURGJvYWE3KzhNN0tzKzJZYytLNVFSUFEz?=
 =?utf-8?B?SUdXc2FnSWtpVkZTdHJyd2R4MndyTFQ1M3VTMXpUSGVwNzhkdEZ5bmNtRUZn?=
 =?utf-8?B?UDE1S2pPMk93PT0=?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <B410ABFF3F727A47B21676DF15EA1DE1@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 99a71d77-93d6-45ed-9a89-08d9952d0996
X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Oct 2021 07:24:51.6119
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Oleksandr_Andrushchenko@epam.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR03MB5940
X-Proofpoint-GUID: zbwEZ-90WaMM4tze-hqmI4wxp5BTC7zD
X-Proofpoint-ORIG-GUID: zbwEZ-90WaMM4tze-hqmI4wxp5BTC7zD
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475
 definitions=2021-10-22_02,2021-10-21_02,2020-04-07_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1011 bulkscore=0
 mlxlogscore=999 lowpriorityscore=0 spamscore=0 impostorscore=0
 phishscore=0 malwarescore=0 mlxscore=0 adultscore=0 priorityscore=1501
 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2109230001 definitions=main-2110220039

SGksIEp1ZXJnZW4hDQoNCk9uIDIyLjEwLjIxIDA5OjQ3LCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0K
PiBTaW1pbGFyIHRvIHRoZSB2aXJ0dWFsIGZyYW1lIGJ1ZmZlciAodmZiKSB0aGUgcHYgZGlzcGxh
eSBkcml2ZXIgaXMgbm90DQo+IGVzc2VudGlhbCBmb3IgYm9vdGluZyB0aGUgc3lzdGVtLiBTZXQg
dGhlIHJlc3BlY3RpdmUgZmxhZy4NCj4NCj4gU2lnbmVkLW9mZi1ieTogSnVlcmdlbiBHcm9zcyA8
amdyb3NzQHN1c2UuY29tPg0KUmV2aWV3ZWQtYnk6IE9sZWtzYW5kciBBbmRydXNoY2hlbmtvIDxv
bGVrc2FuZHJfYW5kcnVzaGNoZW5rb0BlcGFtLmNvbT4NCj4gLS0tDQo+ICAgZHJpdmVycy9ncHUv
ZHJtL3hlbi94ZW5fZHJtX2Zyb250LmMgfCAxICsNCj4gICAxIGZpbGUgY2hhbmdlZCwgMSBpbnNl
cnRpb24oKykNCj4NCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS94ZW4veGVuX2RybV9m
cm9udC5jIGIvZHJpdmVycy9ncHUvZHJtL3hlbi94ZW5fZHJtX2Zyb250LmMNCj4gaW5kZXggOWYx
NGQ5OWM3NjNjLi5iYzc2MDUzMjRkYjMgMTAwNjQ0DQo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS94
ZW4veGVuX2RybV9mcm9udC5jDQo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS94ZW4veGVuX2RybV9m
cm9udC5jDQo+IEBAIC03NzMsNiArNzczLDcgQEAgc3RhdGljIHN0cnVjdCB4ZW5idXNfZHJpdmVy
IHhlbl9kcml2ZXIgPSB7DQo+ICAgCS5wcm9iZSA9IHhlbl9kcnZfcHJvYmUsDQo+ICAgCS5yZW1v
dmUgPSB4ZW5fZHJ2X3JlbW92ZSwNCj4gICAJLm90aGVyZW5kX2NoYW5nZWQgPSBkaXNwbGJhY2tf
Y2hhbmdlZCwNCj4gKwkubm90X2Vzc2VudGlhbCA9IHRydWUsDQo+ICAgfTsNCj4gICANCj4gICBz
dGF0aWMgaW50IF9faW5pdCB4ZW5fZHJ2X2luaXQodm9pZCkNCg==


From xen-devel-bounces@lists.xenproject.org Fri Oct 22 07:25:33 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Oct 2021 07:25:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.214824.373603 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdovl-0006w6-6M; Fri, 22 Oct 2021 07:25:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 214824.373603; Fri, 22 Oct 2021 07:25:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdovl-0006vz-21; Fri, 22 Oct 2021 07:25:33 +0000
Received: by outflank-mailman (input) for mailman id 214824;
 Fri, 22 Oct 2021 07:25:31 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=uKjo=PK=epam.com=prvs=09292fbf9b=oleksandr_andrushchenko@srs-us1.protection.inumbo.net>)
 id 1mdovj-0006vn-MR
 for xen-devel@lists.xenproject.org; Fri, 22 Oct 2021 07:25:31 +0000
Received: from mx0b-0039f301.pphosted.com (unknown [148.163.137.242])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 3c8e6708-3309-11ec-83ad-12813bfff9fa;
 Fri, 22 Oct 2021 07:25:30 +0000 (UTC)
Received: from pps.filterd (m0174680.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 19M5wWMQ023336; 
 Fri, 22 Oct 2021 07:25:25 GMT
Received: from eur02-ve1-obe.outbound.protection.outlook.com
 (mail-ve1eur02lp2059.outbound.protection.outlook.com [104.47.6.59])
 by mx0b-0039f301.pphosted.com with ESMTP id 3bunn5rf6x-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Fri, 22 Oct 2021 07:25:25 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by AM0PR03MB4435.eurprd03.prod.outlook.com (2603:10a6:208:c1::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.16; Fri, 22 Oct
 2021 07:25:23 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::c038:e032:595a:651]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::c038:e032:595a:651%8]) with mapi id 15.20.4628.018; Fri, 22 Oct 2021
 07:25:23 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3c8e6708-3309-11ec-83ad-12813bfff9fa
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=hvAg5VLA0QexZBDKo1xzZrN8QqZnus4T6KJ8qkhYidBxBzNwA7eqs6etxq+7XTxe7TO/NFYEjr/fT0+iDDA3OfJw+8rtsp4AW5hhVhfN6n2iV4zra2DM7n5bfTnETOj930TwPWe1pXAeHTa6rW9XcsD4Lhws64NY1p/k7EVglmWOCFgSlVXHScIpT98rP5jbRvfu3koYd3gc6lHQ3nf/7eSwo+vmPd43ljW8oE9af9ACCRcjpTYD2Tnl1YqrUVnxfTxNOFFjHjAu9siQVxQq+2BF9mrHI0bRhXNReM1VJ8J60HOjKcFowK0wDtmQqNSc5hbpZ3xVEghzS6ojJw5FzA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=jLCxGFdrRrSjwiyE8ZcGGyGgi12ZesPYhYo90XKatdM=;
 b=DBA8uwpD0/jUpQSS1zbKaiO0/VCOuOidLtVnNdg3ZPYXM8F2uX90TxcNLEYJPk4wsCUmO3n+ldvdszsdvkBF4rfK7lkn5uidu5/2Z1ZbdMItq5fQRULfJfakpmwXfXDsCYKpJwt6W9CO9Y4tBSeptH56JgFv4iXgJcnWopPpU80Dpp1C50R1wuIfWy7BUelVHsgTjYNo4U22HtaL6BQMsb1ogy69FoMlE25Dlsp3yaSyNo7iTlK4uPYzB6AdqjRyuuD6m696utrW1fpDLOrDT2Zux87HpE0aLQ5qcmqMGnsus+BzvXOiIoL4dMXGDbdmMTQ6vbPXPz0Tx2JloPppQg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=jLCxGFdrRrSjwiyE8ZcGGyGgi12ZesPYhYo90XKatdM=;
 b=wx0Zv4RBH/XYVo88iQI9sDW1TtfZGXaI+Y9iKXyZqsLMDwfDqwvLLS2ipK3gohV1KxtJ06sNZ7hNESf+Q2qqI/iQniN9xgUUOQwjDn5Ff42d9T9XWl8Pepy5B0jq9mf6UynU0Q1m+LDmzWWvi8LN8MeRXMrybysJdcVl8qXGZS+xVUrDj5bBLtlqFMsy5ls4L2fd//3E4Avn3HKyHMpQAUZI3MK8U0W5KUla4onPjumjKm5wrORzBk9oXnfljzC3KmDVzEsxZnnfZcnsYqvh6pu1u188bR5/ZxSDChCEU9N67IfFgr0uTVIsCgmQ0FH0QP5i09SNZ2uAxXZ1WS0ZtQ==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Juergen Gross <jgross@suse.com>,
        "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>,
        "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>
CC: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>,
        Jaroslav
 Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
        "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>
Subject: Re: [PATCH 5/5] xen: flag xen_snd_front to be not essential for
 system boot
Thread-Topic: [PATCH 5/5] xen: flag xen_snd_front to be not essential for
 system boot
Thread-Index: AQHXxxDrXTppQLCDQ02hFy/t0k8Um6vendAA
Date: Fri, 22 Oct 2021 07:25:23 +0000
Message-ID: <72b951c4-5a84-d68a-b718-3d20f2704ffd@epam.com>
References: <20211022064800.14978-1-jgross@suse.com>
 <20211022064800.14978-6-jgross@suse.com>
In-Reply-To: <20211022064800.14978-6-jgross@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 652d601a-42bb-4b96-2e11-08d9952d1c57
x-ms-traffictypediagnostic: AM0PR03MB4435:
x-microsoft-antispam-prvs: 
 <AM0PR03MB44355F131A147E25B0F8215EE7809@AM0PR03MB4435.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:3513;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 8d1yuKJoYKLni1ly1gNKy8VkRtuzgWAZziVLdPmBb8ak/Vpz4D0acvr3TusF/DU5r/w1MJHu7iPoneye00M8MHgZeIuXKZ35d5k3UWQSK2D+d0HZD6JLeZ+d3SEw3E0mZH9RYSow/O4/ReWw2bxbVCbA8HbWR1kqo/SrNiC/K9/oF3tojqofgwUHf5HgVmAq9sDg6O4uOkAyrbkz8W1xYOTjk6d9H2+TG9OTSN/FUVNxIUXMh2t4th7+JIIlt9aBDn1xxSMTy+5uuS/l/bCT7xzNFiQ0qU92wxddQD84bWFu2qV5uYZbxCggo/AjfyKiGUQGtvOg0MnRKKSJ0HCwk/kNgNIT653EFymitPRjxYgfB2jfTl90yu9pLNdfYigx8Pc2X3DZCESEbkDGO1aoSDUjIBi926oXAJTUx5SttIUYBCV010Q6HDF/8D7Smg2Mb+q9pzOu6QbVFIZLeuu0DIPM9azuHoospNjQAnmYXq1zMEEPamyIrMzJeyZoLPm2dKTCK+ZQfMDeOR7db+eyzA4b45qxQM/GWafk1+fsCcZt5ze9tJUwt6dXOQ3DfYe+yYGQSjB5AEmQL3+g+kEEEM3EWPypkxO8Q53Z3zQwAjPqaYE3R7JDdcT6Z75U84smhR+B1Njpz2XW6+KWSL82RvjlycOulNLwXH3NUT9Sp/ZrSysm1quj9OxIVgp38zD3Gh4acqNm0kidBJ1+uvzaAmrxXn6VxZ1CaXVq7ZkOcs/qH0ni13JzjjwrMAeeWUlp
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(2906002)(186003)(122000001)(6486002)(38070700005)(54906003)(110136005)(316002)(36756003)(71200400001)(4326008)(64756008)(66946007)(31696002)(91956017)(76116006)(66556008)(66446008)(66476007)(2616005)(6506007)(53546011)(31686004)(5660300002)(4744005)(6512007)(26005)(8936002)(508600001)(8676002)(38100700002)(86362001)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?dWpKcE5uSFpxMnpIcXl4VEV4VjMwRDA1MGNnZ0pYZy9NNG1lTFB6M3VPNjhY?=
 =?utf-8?B?L0xTcjI1UjR0K0oyRW9zejNGYjJxSWdSYm54THpQTTdTRzhlUG52SE1yTUxq?=
 =?utf-8?B?S0ViWm1GTnZ0ZEIxa1ZmeWhSOHVmWS93VmU3RjJrWVpYSWJRRXlZN0EvRGZh?=
 =?utf-8?B?WHZoVXBweG9JK09mdUhmNlFXQ015QWtrL2RtU2dKWjJEMUNxWGR3WUZDU3dI?=
 =?utf-8?B?Vm12eXRLQWM2OUJ5Z01GcGhZbHhKd05nS1NkQS94MmhoNWFHNm9ta2hhdUxw?=
 =?utf-8?B?bStJOHA5NVJLNmpSWVJ2cE9EQ2dLRUNKY0ZpZC9LLzZUeUl0ajIvUy91NzdD?=
 =?utf-8?B?K1oyUXhVclJMYklIdi9RT2xqZGhzUzBzN2VzbGRualFqT0dyUHZjendXN3Nm?=
 =?utf-8?B?RSt0SjEzSnNldjV4WDN6cUozdXFXMFYvQzNCOXV1QWJ6UXVEd2R0ZjFwcmtK?=
 =?utf-8?B?WlBGblcrMjlvRGsreWxkZmN1M1YraWxvUUdab2w0Qno1a1Y3UUNMc3ZESXJS?=
 =?utf-8?B?QSs1b0l2WmhnWmZMZ0VVTlNITUpLd2dUY2pmeUpCU0Y2NEhRcUdwRlowUW5I?=
 =?utf-8?B?bkJ0ci8zUUl0YmR3cDdCTmNYRVMvek45Wjl2dm9BSVNLMGIzSm16NmpBWng1?=
 =?utf-8?B?R3Y3dDczVlNXZDgxS2ZPOG9VWk1senYyV3RJdTcvdFVVSjN4dllrVHIyN0s0?=
 =?utf-8?B?MFFPNEl6dW1xdGU4TXZDNXpMaTZ3UFBPZkc5aE55ZTMrQ1RTclBlRTBQdnpP?=
 =?utf-8?B?V2gvTUNHSDBvTlN4cXJLYjdRekV2YmpXYUVjaFB4dTFuRDZubTNOS0FQU2Nk?=
 =?utf-8?B?emJUVFFHckJnWTVzL21yWVBJOW45VkRhbzhtTm9hR0JIQXJWMzBubDEzSEhz?=
 =?utf-8?B?WjhVcmtrc1dmT09FSGI4U3hvdFpTQmJUYlI3QnBWaTU4SGJxQUlBTlJNNkZL?=
 =?utf-8?B?K3hvSnVIN1FZejlQSlN2aDJHRHZVQXV1dFZ0V2QyUG9zekpldGZPT240bU5r?=
 =?utf-8?B?T3ltWEZoQVNVYmhuVm4rYllGcFAzOUJYampZOENzZmxzckxmL3JsOFB0RFhz?=
 =?utf-8?B?eEI2dUtTWGZTaHR1RWRBU1RtcWp6Yk5TZk1xOW90cXh5M2c4L2lod2VVekNU?=
 =?utf-8?B?THVFakJGU1VqbS9JSU02NG10MFhjWVZXRzJ0ZE1WZ2kvS2ZXd0Mrdk9hWVFP?=
 =?utf-8?B?bTZ3UmhBUG9WcXZlSVlqMCtRNU10TDJPWjF1eHMydHdvZjNsODBMTEh5Sllu?=
 =?utf-8?B?VTZQdzM3amhWeGphK21EcXhOUjRXTmlNZDlDb0ZDTjErTnFSQVYydVJyczdM?=
 =?utf-8?B?UGEvMkVTUmdwazlUSjM3TEhTenA4UHBmZ1d6cUwvYkVCdUhXKzZtVE1pblNz?=
 =?utf-8?B?dlNHYWlPSENZNWVTWllVOWRjd1FzYTRMUCt1WUhJR1A3VHBEVFdCeG5XVHJr?=
 =?utf-8?B?eEYvaXBpaFRaMk9UcW1Pdkk4OUpRUXdoU1RtWmZObFZKVTc3cEtHR1NSaGIy?=
 =?utf-8?B?ckdyNmFzcG9zZkVZU2JBYlRVR1NXTVV2c25GWURDR293cGFhYVI4TVI1Ym1U?=
 =?utf-8?B?aGtKOWtXUURDeElHU0pqWDR2aEs0TCthTFd5cExHQzJHdm5yVkVnTWJiczBo?=
 =?utf-8?B?WERIUEZ2U0k4bm05cnFhOTdVSERZK1pXMUFPV2E4MnBXa0phKy9XZWpLWFlJ?=
 =?utf-8?B?N3hDSVNVSzE3cE5OK3ljNVRZTmtQZGVuY2YxNUxKaGVDWHBuSVdrMFdyVmhF?=
 =?utf-8?B?SEZrMHhLSnV2am1rMEpmUGhNM3B4SVM2ZjFLRzNEWVZEQWNqZ2tsREpBZUMr?=
 =?utf-8?B?VFUzNlFBVVVxVjFBTVo2RzZYOG9maTMyKzkwQWRFOFVSMWIzSEIzR1kzRTgx?=
 =?utf-8?B?Ym9CRTBMTnV0L2s0Qk9mRHI2TVFEdzFCYkVwa20yYUN6ZW8vaGF1SDlIdklv?=
 =?utf-8?B?d0Vwb2I1NGxwd2NYM1hiNXdlc3NoMEMxRDFhcDF3R2pGby9KYk11VFc2SHFF?=
 =?utf-8?B?Ny8relNRWnpBPT0=?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <E4540E125C24C145BE1DAC90307552A1@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 652d601a-42bb-4b96-2e11-08d9952d1c57
X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Oct 2021 07:25:23.0212
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Oleksandr_Andrushchenko@epam.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR03MB4435
X-Proofpoint-GUID: 2T-jqHXG1trwMG4SsvThidavhT1DVmpy
X-Proofpoint-ORIG-GUID: 2T-jqHXG1trwMG4SsvThidavhT1DVmpy
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475
 definitions=2021-10-22_02,2021-10-21_02,2020-04-07_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 phishscore=0
 malwarescore=0 bulkscore=0 mlxscore=0 priorityscore=1501 adultscore=0
 clxscore=1011 lowpriorityscore=0 suspectscore=0 impostorscore=0
 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2109230001 definitions=main-2110220039

SGksIEp1ZXJnZW4hDQoNCk9uIDIyLjEwLjIxIDA5OjQ4LCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0K
PiBUaGUgWGVuIHB2IHNvdW5kIGRyaXZlciBpcyBub3QgZXNzZW50aWFsIGZvciBib290aW5nLiBT
ZXQgdGhlIHJlc3BlY3RpdmUNCj4gZmxhZy4NCj4NCj4gU2lnbmVkLW9mZi1ieTogSnVlcmdlbiBH
cm9zcyA8amdyb3NzQHN1c2UuY29tPg0KUmV2aWV3ZWQtYnk6IE9sZWtzYW5kciBBbmRydXNoY2hl
bmtvIDxvbGVrc2FuZHJfYW5kcnVzaGNoZW5rb0BlcGFtLmNvbT4NCj4gLS0tDQo+ICAgc291bmQv
eGVuL3hlbl9zbmRfZnJvbnQuYyB8IDEgKw0KPiAgIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlv
bigrKQ0KPg0KPiBkaWZmIC0tZ2l0IGEvc291bmQveGVuL3hlbl9zbmRfZnJvbnQuYyBiL3NvdW5k
L3hlbi94ZW5fc25kX2Zyb250LmMNCj4gaW5kZXggMmNiMGExOWJlMmI4Li43YmU5ZmJjZjc4OGYg
MTAwNjQ0DQo+IC0tLSBhL3NvdW5kL3hlbi94ZW5fc25kX2Zyb250LmMNCj4gKysrIGIvc291bmQv
eGVuL3hlbl9zbmRfZnJvbnQuYw0KPiBAQCAtMzU4LDYgKzM1OCw3IEBAIHN0YXRpYyBzdHJ1Y3Qg
eGVuYnVzX2RyaXZlciB4ZW5fZHJpdmVyID0gew0KPiAgIAkucHJvYmUgPSB4ZW5fZHJ2X3Byb2Jl
LA0KPiAgIAkucmVtb3ZlID0geGVuX2Rydl9yZW1vdmUsDQo+ICAgCS5vdGhlcmVuZF9jaGFuZ2Vk
ID0gc25kYmFja19jaGFuZ2VkLA0KPiArCS5ub3RfZXNzZW50aWFsID0gdHJ1ZTsNCj4gICB9Ow0K
PiAgIA0KPiAgIHN0YXRpYyBpbnQgX19pbml0IHhlbl9kcnZfaW5pdCh2b2lkKQ0K


From xen-devel-bounces@lists.xenproject.org Fri Oct 22 07:34:15 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Oct 2021 07:34:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.214837.373617 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdp46-0008Sh-3B; Fri, 22 Oct 2021 07:34:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 214837.373617; Fri, 22 Oct 2021 07:34:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdp46-0008Sa-0B; Fri, 22 Oct 2021 07:34:10 +0000
Received: by outflank-mailman (input) for mailman id 214837;
 Fri, 22 Oct 2021 07:34:08 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=e5cR=PK=suse.com=jgross@srs-us1.protection.inumbo.net>)
 id 1mdp44-0008SU-CC
 for xen-devel@lists.xenproject.org; Fri, 22 Oct 2021 07:34:08 +0000
Received: from smtp-out1.suse.de (unknown [195.135.220.28])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 84d61f12-1ab7-4f6b-99ab-b36e1507c29f;
 Fri, 22 Oct 2021 07:34:07 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 86C262197F;
 Fri, 22 Oct 2021 07:34:06 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id BEE2213C7A;
 Fri, 22 Oct 2021 07:34:05 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id /BeyLG1pcmFiKQAAMHmgww
 (envelope-from <jgross@suse.com>); Fri, 22 Oct 2021 07:34:05 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 84d61f12-1ab7-4f6b-99ab-b36e1507c29f
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1634888046; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=fnrILhOsdhDoqefufopQipvYiwZJNHEk+YhPHhT8LNs=;
	b=gVFJe/75JgdII+nyKN4CY1GDnnKavmsp03xZsagBfrhea6AJJs56+bcatktdrHVP+llPiz
	h5+uPhDyjSVhBW8XOk99QTIkmkYA9pKSdGhtODdu9hYjIBWoV6WR4I/TwKaHHSm+DuUS2m
	m+AcIZ7DdJKDMbWAzBMSMnsIV8HILls=
To: Jan Beulich <jbeulich@suse.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
 Boris Ostrovsky <boris.ostrovsky@oracle.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>,
 David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Jiri Slaby <jirislaby@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
 Takashi Iwai <tiwai@suse.com>, alsa-devel@alsa-project.org,
 xen-devel@lists.xenproject.org, linux-input@vger.kernel.org,
 linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
 linux-fbdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
References: <20211022064800.14978-1-jgross@suse.com>
 <c4f534f1-8f07-085e-6a10-edbeb884d1a4@suse.com>
From: Juergen Gross <jgross@suse.com>
Subject: Re: [PATCH 0/5] xen: cleanup detection of non-essential pv devices
Message-ID: <00ae0535-22e3-5467-9c0d-8e2f7a8793b5@suse.com>
Date: Fri, 22 Oct 2021 09:34:05 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <c4f534f1-8f07-085e-6a10-edbeb884d1a4@suse.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="YvdluBdUp3DXuRKhlN5HNuKdU3k8LezFO"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--YvdluBdUp3DXuRKhlN5HNuKdU3k8LezFO
Content-Type: multipart/mixed; boundary="aXNRS2JOiFT36L2Znoe6tP3phbNNMU6Ha";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
 Boris Ostrovsky <boris.ostrovsky@oracle.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>,
 David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Jiri Slaby <jirislaby@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
 Takashi Iwai <tiwai@suse.com>, alsa-devel@alsa-project.org,
 xen-devel@lists.xenproject.org, linux-input@vger.kernel.org,
 linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
 linux-fbdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Message-ID: <00ae0535-22e3-5467-9c0d-8e2f7a8793b5@suse.com>
Subject: Re: [PATCH 0/5] xen: cleanup detection of non-essential pv devices
References: <20211022064800.14978-1-jgross@suse.com>
 <c4f534f1-8f07-085e-6a10-edbeb884d1a4@suse.com>
In-Reply-To: <c4f534f1-8f07-085e-6a10-edbeb884d1a4@suse.com>

--aXNRS2JOiFT36L2Znoe6tP3phbNNMU6Ha
Content-Type: multipart/mixed;
 boundary="------------05C3AAE5BEB34C7C12A2BC5C"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------05C3AAE5BEB34C7C12A2BC5C
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 22.10.21 09:24, Jan Beulich wrote:
> On 22.10.2021 08:47, Juergen Gross wrote:
>> Today the non-essential pv devices are hard coded in the xenbus driver=

>> and this list is lacking multiple entries.
>>
>> This series reworks the detection logic of non-essential devices by
>> adding a flag for that purpose to struct xenbus_driver.
>=20
> I'm wondering whether it wouldn't better be the other way around: The
> (hopefully few) essential ones get flagged, thus also making it more
> prominent during patch review that a flag gets added (and justification=

> provided), instead of having to spot the lack of a flag getting set.

Not flagging a non-essential one is less problematic than not flagging
an essential driver IMO.

For some drivers I'm on the edge, BTW. The pv 9pfs driver ought to be
non-essential in most cases, but there might be use cases where it is
needed, so I didn't set its non_essential flag.

Same applies to pv-usb and maybe pv-scsi, while pv-tpm probably really
is essential.

With the current series I'm ending up with 6 non-essential drivers and
6 essential ones, so either way needs the same number of drivers
modified.


Juergen

--------------05C3AAE5BEB34C7C12A2BC5C
Content-Type: application/pgp-keys;
 name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Transfer-Encoding: quoted-printable
Content-Description: OpenPGP public key
Content-Disposition: attachment;
 filename="OpenPGP_0xB0DE9DD628BF132F.asc"

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy=
cWx
w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O=
f8Z
d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y=
9bf
IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq=
G7/
377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR=
3Jv
c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA=
QIe
AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT=
hpw
dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0=
MbD
1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv=
oPH
Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v=
5QL
+qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ=
2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC=
QoL
BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr=
Wf0
teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC=
/nu
AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh=
ITT
d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm=
XBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz=
80h
SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC=
AcD
AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn=
FOX
gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1=
jnD
kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0=
N51
N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l=
otu
fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1=
tqS
EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA=
hsD
BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3=
g3O
ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5=
dM7
wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5=
D+j
LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm=
V2x
AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N=
Eaw
QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW=
nHI
s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR=
wgn
BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV=
bVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk=
pEd
IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA=
QAB
wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw=
Tbe
8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1=
vJz
Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8=
VGi
wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW=
svi
uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX=
zXs
ZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------05C3AAE5BEB34C7C12A2BC5C--

--aXNRS2JOiFT36L2Znoe6tP3phbNNMU6Ha--

--YvdluBdUp3DXuRKhlN5HNuKdU3k8LezFO
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmFyaW0FAwAAAAAACgkQsN6d1ii/Ey+/
mQf+LFgKttHG9U1GFsmgad1/cMvgMbcyn2AcZkkzdzE0JSvS8vEwkEtPV+5/B1ZRcWHMBy0qzLUU
TZ02dm/hChDYWgZBJRHoYmtLM5HajuXj1cRrvE7UEjAVTTIA8gZTm1oCsdXg+LEFOBYydRIg5rA7
YAjr1Skcr3NEpkfHWuZuEJ9sbmOO5nMmA/hKKXu1i0P2a29m4vCMaacTtmcgZuJWdluzxbBv9swi
q91QZslhU7gX++eRN1AtZGBAZcieznQVks1BcwBu0sW3GJUBXeOoSKD4j1GH8wZ2u21W0lU2I3Pp
5aSffUxsGFOluHqmEV0LQT+DsBoXDWLWLambX0iVyA==
=JnIb
-----END PGP SIGNATURE-----

--YvdluBdUp3DXuRKhlN5HNuKdU3k8LezFO--


From xen-devel-bounces@lists.xenproject.org Fri Oct 22 08:12:48 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Oct 2021 08:12:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.214859.373652 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdpfF-0004dz-Kf; Fri, 22 Oct 2021 08:12:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 214859.373652; Fri, 22 Oct 2021 08:12:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdpfF-0004ds-HX; Fri, 22 Oct 2021 08:12:33 +0000
Received: by outflank-mailman (input) for mailman id 214859;
 Fri, 22 Oct 2021 08:12:32 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mdpfE-0004di-Lb; Fri, 22 Oct 2021 08:12:32 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mdpfE-0007fl-FT; Fri, 22 Oct 2021 08:12:32 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mdpfE-0001sz-7N; Fri, 22 Oct 2021 08:12:32 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mdpfE-0002hT-6w; Fri, 22 Oct 2021 08:12:32 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=hXtajAZIm4nwPU4A1vib44KTnnPf/vl5u00oShp5NPQ=; b=4F1Ads/y8VoOoM4MENga2ovFRx
	OBTYuN2ZazHcy7APZgMHKaY/bFCRvK+3PAuWvv1sycm1bPPAxJTir5lY9M3b1CwrsatK7FshcVwdF
	3b36t8DtHLQfH9dOi/x/cCS0Rtr09gwuEXaLWwQ0RZAj8u05FX6Rgf74LMqG4znZvYyk=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165735-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 165735: regressions - FAIL
X-Osstest-Failures:
    libvirt:build-armhf-libvirt:libvirt-build:fail:regression
    libvirt:build-amd64-libvirt:libvirt-build:fail:regression
    libvirt:build-i386-libvirt:libvirt-build:fail:regression
    libvirt:build-arm64-libvirt:libvirt-build:fail:regression
    libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    libvirt=a2c40900ed6d4098e29153f9417e061a82d132bc
X-Osstest-Versions-That:
    libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 22 Oct 2021 08:12:32 +0000

flight 165735 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165735/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-armhf-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-amd64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-i386-libvirt            6 libvirt-build            fail REGR. vs. 151777
 build-arm64-libvirt           6 libvirt-build            fail REGR. vs. 151777

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-libvirt-vhd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a

version targeted for testing:
 libvirt              a2c40900ed6d4098e29153f9417e061a82d132bc
baseline version:
 libvirt              2c846fa6bcc11929c9fb857a22430fb9945654ad

Last test of basis   151777  2020-07-10 04:19:19 Z  469 days
Failing since        151818  2020-07-11 04:18:52 Z  468 days  454 attempts
Testing same since   165735  2021-10-22 04:18:48 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
    Adolfo Jayme Barrientos <fitoschido@gmail.com>
  Aleksandr Alekseev <alexander.alekseev@virtuozzo.com>
  Aleksei Zakharov <zaharov@selectel.ru>
  Andika Triwidada <andika@gmail.com>
  Andrea Bolognani <abologna@redhat.com>
  Ani Sinha <ani@anisinha.ca>
  Balázs Meskó <meskobalazs@mailbox.org>
  Barrett Schonefeld <bschoney@utexas.edu>
  Bastian Germann <bastiangermann@fishpost.de>
  Bastien Orivel <bastien.orivel@diateam.net>
  BiaoXiang Ye <yebiaoxiang@huawei.com>
  Bihong Yu <yubihong@huawei.com>
  Binfeng Wu <wubinfeng@huawei.com>
  Bjoern Walk <bwalk@linux.ibm.com>
  Boris Fiuczynski <fiuczy@linux.ibm.com>
  Brian Turek <brian.turek@gmail.com>
  Bruno Haible <bruno@clisp.org>
  Chris Mayo <aklhfex@gmail.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Ehrhardt <christian.ehrhardt@canonical.com>
  Christian Kirbach <christian.kirbach@gmail.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Cole Robinson <crobinso@redhat.com>
  Collin Walling <walling@linux.ibm.com>
  Cornelia Huck <cohuck@redhat.com>
  Cédric Bosdonnat <cbosdonnat@suse.com>
  Côme Borsoi <fedora@borsoi.fr>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniel Letai <dani@letai.org.il>
  Daniel P. Berrange <berrange@redhat.com>
  Daniel P. Berrangé <berrange@redhat.com>
  Didik Supriadi <didiksupriadi41@gmail.com>
  dinglimin <dinglimin@cmss.chinamobile.com>
  Dmitrii Shcherbakov <dmitrii.shcherbakov@canonical.com>
  Dmytro Linkin <dlinkin@nvidia.com>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Eric Farman <farman@linux.ibm.com>
  Erik Skultety <eskultet@redhat.com>
  Fabian Affolter <mail@fabian-affolter.ch>
  Fabian Freyer <fabian.freyer@physik.tu-berlin.de>
  Fabiano Fidêncio <fabiano@fidencio.org>
  Fangge Jin <fjin@redhat.com>
  Farhan Ali <alifm@linux.ibm.com>
  Fedora Weblate Translation <i18n@lists.fedoraproject.org>
  Gavi Teitz <gavi@nvidia.com>
  gongwei <gongwei@smartx.com>
  Guoyi Tu<tu.guoyi@h3c.com>
  Göran Uddeborg <goeran@uddeborg.se>
  Halil Pasic <pasic@linux.ibm.com>
  Han Han <hhan@redhat.com>
  Hao Wang <wanghao232@huawei.com>
  Hela Basa <r45xveza@pm.me>
  Helmut Grohne <helmut@subdivi.de>
  Hiroki Narukawa <hnarukaw@yahoo-corp.jp>
  Ian Wienand <iwienand@redhat.com>
  Jakob Meng <jakobmeng@web.de>
  Jamie Strandboge <jamie@canonical.com>
  Jamie Strandboge <jamie@ubuntu.com>
  Jan Kuparinen <copper_fin@hotmail.com>
  jason lee <ppark5237@gmail.com>
  Jean-Baptiste Holcroft <jean-baptiste@holcroft.fr>
  Jia Zhou <zhou.jia2@zte.com.cn>
  Jianan Gao <jgao@redhat.com>
  Jim Fehlig <jfehlig@suse.com>
  Jin Yan <jinyan12@huawei.com>
  Jinsheng Zhang <zhangjl02@inspur.com>
  Jiri Denemark <jdenemar@redhat.com>
  John Ferlan <jferlan@redhat.com>
  Jonathan Watt <jwatt@jwatt.org>
  Jonathon Jongsma <jjongsma@redhat.com>
  Julio Faracco <jcfaracco@gmail.com>
  Justin Gatzen <justin.gatzen@gmail.com>
  Ján Tomko <jtomko@redhat.com>
  Kashyap Chamarthy <kchamart@redhat.com>
  Kevin Locke <kevin@kevinlocke.name>
  Kristina Hanicova <khanicov@redhat.com>
  Laine Stump <laine@redhat.com>
  Laszlo Ersek <lersek@redhat.com>
  Lee Yarwood <lyarwood@redhat.com>
  Lei Yang <yanglei209@huawei.com>
  Liao Pingfang <liao.pingfang@zte.com.cn>
  Lin Ma <lma@suse.com>
  Lin Ma <lma@suse.de>
  Lin Ma <morecache@gmail.com>
  Liu Yiding <liuyd.fnst@fujitsu.com>
  Luke Yue <lukedyue@gmail.com>
  Luyao Zhong <luyao.zhong@intel.com>
  Marc Hartmayer <mhartmay@linux.ibm.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Markus Schade <markus.schade@hetzner.com>
  Martin Kletzander <mkletzan@redhat.com>
  Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
  Matej Cepl <mcepl@cepl.eu>
  Matt Coleman <matt@datto.com>
  Matt Coleman <mcoleman@datto.com>
  Mauro Matteo Cascella <mcascell@redhat.com>
  Meina Li <meili@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Michał Smyk <fedora@smyk.it>
  Milo Casagrande <milo@milo.name>
  Moshe Levi <moshele@nvidia.com>
  Muha Aliss <muhaaliss@gmail.com>
  Nathan <nathan95@live.it>
  Neal Gompa <ngompa13@gmail.com>
  Nick Chevsky <nchevsky@gmail.com>
  Nick Shyrokovskiy <nshyrokovskiy@gmail.com>
  Nickys Music Group <nickys.music.group@gmail.com>
  Nico Pache <npache@redhat.com>
  Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
  Olaf Hering <olaf@aepfle.de>
  Olesya Gerasimenko <gammaray@basealt.ru>
  Orion Poplawski <orion@nwra.com>
  Pany <geekpany@gmail.com>
  Patrick Magauran <patmagauran.j@gmail.com>
  Paulo de Rezende Pinatti <ppinatti@linux.ibm.com>
  Pavel Hrdina <phrdina@redhat.com>
  Peng Liang <liangpeng10@huawei.com>
  Peter Krempa <pkrempa@redhat.com>
  Pino Toscano <ptoscano@redhat.com>
  Pino Toscano <toscano.pino@tiscali.it>
  Piotr Drąg <piotrdrag@gmail.com>
  Prathamesh Chavan <pc44800@gmail.com>
  Praveen K Paladugu <prapal@linux.microsoft.com>
  Richard W.M. Jones <rjones@redhat.com>
  Ricky Tigg <ricky.tigg@gmail.com>
  Robin Lee <cheeselee@fedoraproject.org>
  Roman Bogorodskiy <bogorodskiy@gmail.com>
  Roman Bolshakov <r.bolshakov@yadro.com>
  Ryan Gahagan <rgahagan@cs.utexas.edu>
  Ryan Schmidt <git@ryandesign.com>
  Sam Hartman <hartmans@debian.org>
  Scott Shambarger <scott-libvirt@shambarger.net>
  Sebastian Mitterle <smitterl@redhat.com>
  SeongHyun Jo <caelus9536@gmail.com>
  Shalini Chellathurai Saroja <shalini@linux.ibm.com>
  Shaojun Yang <yangshaojun@phytium.com.cn>
  Shi Lei <shi_lei@massclouds.com>
  simmon <simmon@nplob.com>
  Simon Chopin <chopin.simon@gmail.com>
  Simon Gaiser <simon@invisiblethingslab.com>
  Simon Rowe <simon.rowe@nutanix.com>
  Stefan Bader <stefan.bader@canonical.com>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Berger <stefanb@linux.vnet.ibm.com>
  Stefan Hajnoczi <stefanha@gmail.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Szymon Scholz <szymonscholz@gmail.com>
  Thomas Huth <thuth@redhat.com>
  Tim Wiederhake <twiederh@redhat.com>
  Tomáš Golembiovský <tgolembi@redhat.com>
  Tomáš Janoušek <tomi@nomi.cz>
  Tuguoyi <tu.guoyi@h3c.com>
  Victor Toso <victortoso@redhat.com>
  Ville Skyttä <ville.skytta@iki.fi>
  Vinayak Kale <vkale@nvidia.com>
  Wang Xin <wangxinxin.wang@huawei.com>
  WangJian <wangjian161@huawei.com>
  Weblate <noreply@weblate.org>
  Wei Liu <liuwe@microsoft.com>
  Wei Liu <wei.liu@kernel.org>
  Wei-Chen Chen <weicche@microsoft.com>
  William Douglas <william.douglas@intel.com>
  Yalei Li <274268859@qq.com>
  Yalei Li <liyl43@chinatelecom.cn>
  Yang Fei <yangfei85@huawei.com>
  Yang Hang <yanghang44@huawei.com>
  Yanqiu Zhang <yanqzhan@redhat.com>
  Yaroslav Kargin <ykargin@virtuozzo.com>
  Yi Li <yili@winhong.com>
  Yi Wang <wang.yi59@zte.com.cn>
  Yuri Chornoivan <yurchor@ukr.net>
  Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
  zhangjl02 <zhangjl02@inspur.com>
  Zheng Chuan <zhengchuan@huawei.com>
  zhenwei pi <pizhenwei@bytedance.com>
  Zhenyu Ye <yezhenyu2@huawei.com>
  Zhenyu Zheng <zheng.zhenyu@outlook.com>
  Zhenzhong Duan <zhenzhong.duan@intel.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          fail    
 build-arm64-libvirt                                          fail    
 build-armhf-libvirt                                          fail    
 build-i386-libvirt                                           fail    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           blocked 
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-libvirt-xsm                                 blocked 
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-libvirt                                     blocked 
 test-arm64-arm64-libvirt                                     blocked 
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-libvirt-pair                                blocked 
 test-amd64-i386-libvirt-pair                                 blocked 
 test-arm64-arm64-libvirt-qcow2                               blocked 
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-libvirt-vhd                                 blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 80380 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Oct 22 09:22:22 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Oct 2021 09:22:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.214881.373702 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdqkd-00035G-Op; Fri, 22 Oct 2021 09:22:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 214881.373702; Fri, 22 Oct 2021 09:22:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdqkd-000359-Lg; Fri, 22 Oct 2021 09:22:11 +0000
Received: by outflank-mailman (input) for mailman id 214881;
 Fri, 22 Oct 2021 09:22:10 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mdqkc-00034z-EP
 for xen-devel@lists.xenproject.org; Fri, 22 Oct 2021 09:22:10 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mdqkc-0000Rh-Df
 for xen-devel@lists.xenproject.org; Fri, 22 Oct 2021 09:22:10 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mdqkc-0001S0-CQ
 for xen-devel@lists.xenproject.org; Fri, 22 Oct 2021 09:22:10 +0000
Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89)
 (envelope-from <iwj@xenproject.org>) id 1mdqka-000121-7p
 for xen-devel@lists.xenproject.org; Fri, 22 Oct 2021 10:22:08 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:To:Date:
	Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From;
	bh=oCd8SK+N+URiKkT/8L7rieGTlsybO36V2bZXVwEfhlw=; b=6wCvqtu3VzDMXGLF8/5poy8XLL
	oGtLcyOseVJxCp0rUmpjLefIB9flCA0lUDiFqcZ7SDLLISayLTCz1vwFQnVK+h11PoC7I8YmRXcNH
	x1NRuoA6kLEiD8jSuT/ujoMT0dEfru3vH640Bd4qEAasXmMS8poKA3KO9Z1nKUeJUDoU=;
From: Ian Jackson <iwj@xenproject.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <24946.33471.667852.296915@mariner.uk.xensource.com>
Date: Fri, 22 Oct 2021 10:22:07 +0100
To: xen-devel@lists.xenproject.org
Subject: Re: [xen-unstable test] 165712: regressions - FAIL
In-Reply-To: <osstest-165712-mainreport@xen.org>
References: <osstest-165712-mainreport@xen.org>
X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu)

osstest service owner writes ("[xen-unstable test] 165712: regressions - FAIL"):
> flight 165712 xen-unstable real [real]
> flight 165727 xen-unstable real-retest [real]
> http://logs.test-lab.xenproject.org/osstest/logs/165712/
> http://logs.test-lab.xenproject.org/osstest/logs/165727/
> 
> Regressions :-(
> 
> Tests which did not succeed and are blocking,
> including tests which could not be run:
>  test-amd64-amd64-examine      4 memdisk-try-append       fail REGR. vs. 165699
> 

This was not a genuine regression.  There is an infelicity in this
particular job: it runs on any host, but only some hosts support
FreeBSD (which is what this is).  In particular the albanas have UEFI
firmware which doesn't work.

I have force pushed this.  This test will continue to run here due to
the failure.  This will do for now, but really I need to do something
more subtle.

> version targeted for testing:
>  xen                  98f60e5de00baf650c574c9352bb19aedb082dea

Ian.


From xen-devel-bounces@lists.xenproject.org Fri Oct 22 09:25:46 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Oct 2021 09:25:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.214889.373716 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdqo6-0003lJ-AX; Fri, 22 Oct 2021 09:25:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 214889.373716; Fri, 22 Oct 2021 09:25:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdqo6-0003lC-78; Fri, 22 Oct 2021 09:25:46 +0000
Received: by outflank-mailman (input) for mailman id 214889;
 Fri, 22 Oct 2021 09:25:45 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mdqo5-0003l6-7n
 for xen-devel@lists.xenproject.org; Fri, 22 Oct 2021 09:25:45 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mdqo5-0000UL-73
 for xen-devel@lists.xenproject.org; Fri, 22 Oct 2021 09:25:45 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mdqo5-0001nH-6C
 for xen-devel@lists.xenproject.org; Fri, 22 Oct 2021 09:25:45 +0000
Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89)
 (envelope-from <iwj@xenproject.org>)
 id 1mdqo2-00014n-0I; Fri, 22 Oct 2021 10:25:42 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date
	:Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From;
	bh=OzuthWXcpN0W96nr8nZ8VYNsR/P1pWvja/TTDSwOMnc=; b=ILxPezU6QMGIhbY6JZHGL/qj6d
	K3Mt9s8j7nvZhCnOk0TTEFtFcdnT+SubVgy9qefU01fQkPpawJ5G7XXTK2vZQbCuzfuWD+cu0pOCo
	j6q6nQFWV3CT/98Ox5cvWXjeksSikLst/9cwq8SRgSAgae0OOQEXlpzbVfpDf3Fq7I/0=;
From: Ian Jackson <iwj@xenproject.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <24946.33685.695365.801118@mariner.uk.xensource.com>
Date: Fri, 22 Oct 2021 10:25:41 +0100
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: xen-devel@lists.xenproject.org,
    cardoe@cardoe.com,
    wl@xen.org,
    andrew.cooper3@citrix.com,
    anthony.perard@citrix.com
Subject: Re: [PATCH 0/3] automation: introduce an x86_64 Dom0/DomU test
In-Reply-To: <alpine.DEB.2.21.2110210831470.2311@sstabellini-ThinkPad-T480s>
References: <alpine.DEB.2.21.2110210831470.2311@sstabellini-ThinkPad-T480s>
X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu)

Stefano Stabellini writes ("[PATCH 0/3] automation: introduce an x86_64 Dom0/DomU test"):
> The last patch is the one introducing a new test. This one can fail.
> However, it is a new test at the end of the pipeline: it doesn't impact
> the existing tests. In the worst case, the test will fail and the whole
> pipeline will be marked as "failed" but looking at the jobs all the
> other will continue to be marked as successful. In short, if it fails,
> we can simply ignore it. Also, at the moment it is actually succeeding.

Thanks.  For 4.16:

Release-Acked-by: Ian Jackson <iwj@xenproject.org>


From xen-devel-bounces@lists.xenproject.org Fri Oct 22 09:29:00 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Oct 2021 09:29:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.214897.373731 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdqr9-0004Oc-Rg; Fri, 22 Oct 2021 09:28:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 214897.373731; Fri, 22 Oct 2021 09:28:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdqr9-0004OV-Oa; Fri, 22 Oct 2021 09:28:55 +0000
Received: by outflank-mailman (input) for mailman id 214897;
 Fri, 22 Oct 2021 09:28:54 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=OBiv=PK=citrix.com=Andrew.Cooper3@srs-us1.protection.inumbo.net>)
 id 1mdqr7-0004OP-So
 for xen-devel@lists.xenproject.org; Fri, 22 Oct 2021 09:28:54 +0000
Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 78394744-331a-11ec-83b0-12813bfff9fa;
 Fri, 22 Oct 2021 09:28:52 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 78394744-331a-11ec-83b0-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1634894932;
  h=subject:to:cc:references:from:message-id:date:
   in-reply-to:content-transfer-encoding:mime-version;
  bh=1dmNTJLtZ88C511eeAfj50yNHRBGH1CGA3LqoJJKFq0=;
  b=Vp4+5c+eyHJrWWrwAgu9/DLXMCPQcOs93ZzR+RRV8KCcub8FxlHpnNrL
   nzKs6T3zncyVXcPKxryhqns9ln6os0RbYgc9RmpABt3hQb/IaWmaO9gKr
   oPOk7XQb4faVY5pi/B94qKTuRyzvjBGB8fHhoFGDnZTVtrE1EK2dyUpWd
   Y=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: UP/KYTxqp5H8qocDfBKCDFSlp0W5SZOXxKDiUTFhPQMj8tCNMK6IEAlw8r2spKIhOqJZhpmQLM
 E94kaYFz6jm5rWyFzisKLTEeetCgubFO6H7d8zKdnX/OyT+4a5MXMB+agYozvc0L0IOdQCIFtY
 44kH6i9Eq7S6CYnDCV3OxBEVo1yFKtXeTxKJ8HqH0rrrS8G/Pjg/G6SikPIs4i5HzkvwI0EkTL
 xHUT3F5/TQCJS17cQT1SC4YLLQ51ObbPSPPNSaTiFM0mjqSRZiFRChE3smpx3Jg29MbRx8lNC6
 M2k6qOoCFKCcazsqPRtfKHF2
X-SBRS: 5.1
X-MesageID: 55802968
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:lByUp6MYiyAPRjvvrR29kcFynXyQoLVcMsEvi/4bfWQNrUorhTAFy
 zAcCD3UOvyPMzbxc4h+bYWwoB9XvJHTn9MyQQto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdpJYz/uUGuCJQUNUjMlkfZKhTr6bUsxNbVU8En540Ug5w7RRbrNA2rBVPSvc4
 bsenOWHULOV82Yc3rU8sv/rRLtH5ZweiRtA1rAMTakjUGz2zhH5OKk3N6CpR0YUd6EPdgKMq
 0Qv+5nilo/R109F5tpICd8XeGVSKlLZFVDmZna7x8FOK/WNz8A/+v9TCRYSVatYoxHWtftoi
 /dKjqWhVy0SO63jxeEgfAYNRkmSPYUekFPGCX22sMjVxEzaaXr8hf5pCSnaP6VBpLwxWzsXs
 6VFdnZdNXhvhMrvqF6/YsBqit4uM4/AO4QHt2s75TrYEewnUdbIRKCiCdpwgWpg3pofQ6a2i
 8wxVRxSMi3ZQhZ0P2wlIqInuOKijGTgfGgNwL6SjfVuuDWCpOBr65DpMdzIapmLQ91Igm6Gq
 W/cuWf0GBcXMJqY0zXt2natgPLf2CD2QoQfEJWm+fNwxl6e3GoeDFsRT1TTifu2kEmlQPpEN
 lcZvCEpqMAa5EGtC9XwQRC8iHqFpQIHHcpdFfUg7wOAwbaS5ByWbkAIVD8EZNE4ucseQT0xy
 kTPkcnkCDBiq76JTmrb8a2bxRu4PjIUNikFfjMeShUe4MjLp5s6hRbCCN1kFcadlcbpEDv9x
 zSLqikWhLgJi8MPkaKh8jjvhzOqu4iMQAQ56xv/QG2o9EV6aZSjaoju7kLUhd5MKYeFVEjHo
 H8enMue6/4mApSElSjLS+IIdIxF/N7cbmea2wQ2WcB8qXL9oBZPYLy8/hlae21CK4UmfgTQc
 VH5ggZRy8JWAVS1OPofj52KN+wmyq3pFNLAX//Sb8ZTbpUZSDJr7B2CdmbLgDizyBlEfbUXf
 M7BK571XCly5bFPlWLuH48gPakXKjfSLI85bavwyAi7yvKgbXqRRKZt3LCmP71hsv3sTOk49
 b9i2yq2J/d3DLKWjsr/q9d7wbU2wZ4TX8yeRyt/LbbrH+aeMDt9Y8I9OJt4E2Cfo4xbl/3T4
 la2UVJCxVz0iBXvcFvRNiA/Mey/Bc0i/BrX2BDA237yhxDPhq70tM8im2YfJ+F7pISPM9YkJ
 xX6RylwKqsWEWmWk9jsRZL8sJZjZHyWafGmZEKYjMwEV8c4HWTho4a8FiO2rXVmJnfn5KMW/
 uz7viuGEMVreuiXJJuPAB5Z5wjq5iZ1dSMbdxagH+S/j221odE0cXSo06drSyzOQD2arganO
 8+tKU5wjcHGopMv8cmPgqaBroyzFPB5EFYcFG7ehYta/wGDloZ66YMfAuuOYx7HU2b4pPera
 elPlqmuO/wbhlda9YF7Fu8zn6454tLuoZ5czxhlQyqXPwj6VOs4LynUx9RLu41M2qRd5Vm8V
 HWQ94QIIr6OIs7kTgIcfVJ3cuSZ2PgIsTDO9vBpcl7i7Sp68ePfA0VfNhWBkgJHK75xPN93y
 OstopdOuQe+lgArIpCNiSUNrzaAKXkJUqMGsJAGAdC01lp3mw8aOZGFU334+pCCbdlII3IGG
 D7MifqQnalYy2rDb2E3SSrH091CiMlcoxtN1lIDeQiEw4KXmv8t0RRN2j0rVQAJnA5f2ud+N
 2U3ZU14IaKCo2VhiMRZBj3+HghAAFuS+1DryktPn2rcFhH6WmvIJWw7GOCM4EFGrD4MImkFp
 OmVmDT/TDLnXMDtxS9jC0dqpsvqQcF16gCfytusGN6IHsVibDfo6kN0ibHkd/cz7RsNuXD6
IronPort-HdrOrdr: A9a23:gQxdCKPOHnqT+MBcT1H155DYdb4zR+YMi2TDiHofdfUFSKClfp
 6V8cjztSWUtN4QMEtQ/exoS5PwPk80kqQFnbX5XI3SITUO3VHHEGgM1/qb/9SNIVyZygcZ79
 YbT0EcMqyBMbEZt7eC3ODQKb9Jq7PmgcPY9ts2jU0dKj2CA5sQnjuRYTzrcHGeKjM2YKbRWK
 Dsnfau8FGbCAoqh4mAdzQ4dtmGg+eOuIPtYBYACRJiwA6SjQmw4Lq/NxSDxB8RXx5G3L9nqA
 H+4kPEz5Tml8v+5g7X1mfV4ZgTsNz9yuFbDMjJrsQOMD3jhiuheYwkcbyfuzIepv2p9T8R4Z
 XxiiZlG/42x2Laf2mzrxeo8w780Aw243un8lOciWuLm72weBsKT+56wa5JeBrQ7EQt+Ptm1r
 hQ4m6fv51LSTvdgSXU/bHzJlFXv3vxhUBnvf8YjnRZX4dbQqRWt5Yj8ERcF4pFND7m6bogDP
 JlAKjnlbdrmGuhHjLkV1RUsZmRtixZJGbDfqFCgL3a79FupgE786NCr/Zv2Uvp9/oGOtB5Dq
 r/Q+JVfYp1P7orhJRGdZE8qPuMex7wqC33QRavyHTcZeo60iH22tTKCItc3pDcRHVP9upqpK
 j8
X-IronPort-AV: E=Sophos;i="5.87,172,1631592000"; 
   d="scan'208";a="55802968"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=EeDe+UqHNKT2FRkbUA61UPM3qnr1gsMU7dL7zD8nq4A5ciIiDVvaYncQvU2KDFg2/iIM2LFprWPYkLpt1gPMdR9w/6UvHS+09/JX+Fa1Fd5EyVPg5WBZW6nWWCuwYpoiTsVj37oP2h3+qj6/BU44kUJ+67ux4vQuTteRm0YALdn0WV72+7qCT/hAypXuXxFk/pR+NcHmsJvc3eJKeHYTQnMGCs6IpAKym6N7DH5JO1d5ZFR+p8FlUxeaytdrnn8CC5nPL4q8IeDnqW+eS+7giJ0w1uMFAspnFpZxJ06iW3r/Am303p+oxFm9dIvWTbc0tp2/ccVRXXIjnC/lvJNE8w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=1dmNTJLtZ88C511eeAfj50yNHRBGH1CGA3LqoJJKFq0=;
 b=YAC7uszzKcPzUCxcAlWmDMh+GXzviz9Nva3YTskQQh83K0Gsh3gVLmt6VtoBTH89O0zp0ZxuM9uavhjPRTiWrMiYyn9Znq9L2Ci8ngUO7ImMKGZ02Q+C23DsGMdFexUmvxCXxS6XTfOjNIPOmldd7bplVIcVTumpnPvWMQlFpx4jo12e4U0WzOqMQkE6ssYqqRXAMr98xLjEaDAHUOJfCUbCEUU/Yl6O9jmPsyARInwOLFsnOZbJznN4wkIXLbcYfUqlbJdykFxUZGotNIPIJlr1STxQAB5zkAgrKMYsuBqCEsltPvhlGbqPd4IoLW7GmfxgMhXJZ2RTu52VaDsJ5g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=1dmNTJLtZ88C511eeAfj50yNHRBGH1CGA3LqoJJKFq0=;
 b=aYqgrVg1x4VmQiPkmg/VImi8eqbXXL/kY3t4FDk5Md9+FbeWPY19Q+JYPBkidXPlCloxV5/5kzd++A4QYsA5Z18OQgQyAFbLTcqb9lE0WkcyJHcXeex0hbddI7sIoSt9YqCpA/ia4wnwfINQFPh3FbpJWrHV7G3XH9pSG8BopHk=
Subject: Re: [PATCH 1/5] xen: add "not_essential" flag to struct xenbus_driver
To: Juergen Gross <jgross@suse.com>, <xen-devel@lists.xenproject.org>,
	<linux-input@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<dri-devel@lists.freedesktop.org>, <linux-fbdev@vger.kernel.org>
CC: Dmitry Torokhov <dmitry.torokhov@gmail.com>, Boris Ostrovsky
	<boris.ostrovsky@oracle.com>, Stefano Stabellini <sstabellini@kernel.org>
References: <20211022064800.14978-1-jgross@suse.com>
 <20211022064800.14978-2-jgross@suse.com>
From: Andrew Cooper <andrew.cooper3@citrix.com>
Message-ID: <fe397fd6-a80e-d3f9-08d2-4f72ec739c0b@citrix.com>
Date: Fri, 22 Oct 2021 10:28:40 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <20211022064800.14978-2-jgross@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Content-Language: en-GB
X-ClientProxiedBy: LO4P123CA0453.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:1aa::8) To BYAPR03MB3623.namprd03.prod.outlook.com
 (2603:10b6:a02:aa::12)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 4f2d8f74-a5ac-4f29-a0a0-08d9953e59c2
X-MS-TrafficTypeDiagnostic: BYAPR03MB3863:
X-Microsoft-Antispam-PRVS: <BYAPR03MB3863EAA25284A3BF266B3555BA809@BYAPR03MB3863.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8273;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 1gQX7y+XiDMvDH4+nBlHr9uhucCGDGzH91vhTL6cZbBMllixyYS8EjpOrDdu7sQPSlWl46m+W7xCHGTgkfnq0Vhr5y5t/mT47YChr4YYlPM6TBCM4tV2A6gQoxjkkl0AMGCw/GDeYbFG9979F3VE0Y5sEg5yccsUyi6wij0WP3OUuCnIo20BWOeLLWQ/xG9UhvCUWJzB8FFBf2B1Ftzf011+7kPy9hP2KJL3pv/jmP+WIi34ZthjFgG4yjHUKajYTg8wp6zktiSpMd9qaGmopTKIeWmkTmKaDU8+1iWl+l7dSM6I/u/SBPVgfgCDEJP1LoHIi+q3DAIdewwmyMxMJOuFcNFzn34CPmjZv8FUcAQCOVHJBf7cdXXOPJRKVsMEmgP9nU4gXlqy6oOAYJrLDsYGG3NS2jdnshZNmcbsvQlHcmWuIP9pOSKW4ILCEpJniREx3cbFUxYxRI6NtwAyPKJSHBlC3tPRbKgkxbCZXsOBjBJUWHwSM0yIqp15f1+CujMWzcMOeJ2F4UQ8v8nPyEoOc01wIfp796MyRlf2KSTAyeWwZfj+PXOyZOn4YJMvjzeI2A8H428qWxGNq19crXd0yQaqp6GM4jWruMGn+8H7cyn8OpncBTYFLO8G7ZwMDVu5310p3+1RZKpS9akaDQlsvcBmwD+cyo3AiNYDb/1wTghJ+FtGY/r0jJEXtFIuoMai790qUD82LTTg6yT/kqo7e/wWyTimsNLUtiZXbZk=
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(86362001)(4326008)(186003)(66476007)(4744005)(66556008)(53546011)(316002)(31696002)(82960400001)(83380400001)(6666004)(26005)(54906003)(2616005)(8936002)(956004)(8676002)(38100700002)(66946007)(6486002)(16576012)(508600001)(5660300002)(2906002)(31686004)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eU9oRW00TDVaYWJ4am1wSFRKZHNueWhhWHhGejBiMUV6SFZGSWMzNkUzZ3dX?=
 =?utf-8?B?dVZzVnN3NDYxNlEzT2hmZ3pPWVN0OGIxVThxWVVZVkJPWXpGeUhXc3Q2bERy?=
 =?utf-8?B?eTlOaEdYTnNYNktSREhhUFhvNlVoN3JScHR4WDY2cHIyMEFTWGNZYkx3K0xU?=
 =?utf-8?B?ZythbzBhTnp1bTVkM0YxckZNOFEyQ0huQ2Y0c0pOb3BwdFZCN3l2Z0NmM3ZU?=
 =?utf-8?B?bE9idStWc1ZqN0lUbXkwYW9sb2kxNVFWMHJKSEpxYkNYMmx3RFROeW10YmpB?=
 =?utf-8?B?dERyVGUyeDBDMXZNQjNldXBHczVWVFQ3b1F2M2kzRmMvNEU5cVFjNGF0T21q?=
 =?utf-8?B?WjhGblJ1WldVci93WU1tTVBabk9YQ3JtY0Z1OFpVeDBCRGRNSGhNNDJWZEhq?=
 =?utf-8?B?b3U5WnA5VzdtdkZOWDJhNlByekpFRGVGRkcvUm1TQ3dVSGZJelJQckRmdTBV?=
 =?utf-8?B?ckJ6dUc0RFFjMHhCSG1EUWZ3WDRRSUFBaC9UNHNhL2hiWmo3M2U3eFBQWS9W?=
 =?utf-8?B?LzkyRW92WUxIV3NiUEtoejFucmNJazNBVUkxNUd3UmQzbXpDUTNVcEpiQ1ow?=
 =?utf-8?B?NncyN0tHTG9RRkFBTURScm1tZ2c5MVdqaEQvVjAxN0hsV0ZpOUxzY3NLWENR?=
 =?utf-8?B?WGE2d2Q4OWpUUVpuS0hjOVkzTTZmMTNvMlY3Ni9jMWY1TEtjTXVHL0VMUk42?=
 =?utf-8?B?K3VwMFpOUGZWTzJKTjNzRUpLNk9NYmJFZjBtaTBKaVRGNjRCS3daSlgvZTJX?=
 =?utf-8?B?cUdIWVZxanZVdS93NmZiUTluNzBNY1JBdklaQlpyeVIwTHRQZ2VKbVlRUzdX?=
 =?utf-8?B?aWN4YjNjL0NMVUhLckxTWTUwbVYzSXZyaFNNdDZmYVViNVBNSHNqcXpmcEhZ?=
 =?utf-8?B?YWNnSWk3RmFzaGNWWW1yR0plbzVIa1d1THlWdktTNUU4Z3NLUUVSUWExQWZv?=
 =?utf-8?B?U09uZ1EvcTBHUU5rU1pzdklDdVA0aDRJRjJWNzI1aFVaQ3N2MEswaGtsOWRq?=
 =?utf-8?B?d2hTUER6SXI0YTMyMVRTT0RiTTE3NUgzUk02YVNsZE0rNHo1ZmhQWGoyTVhn?=
 =?utf-8?B?am1ZYlJFQTRhSGdwakJLeDNqcDIwQmZieUtoVjA0dUNoSTdmdm96QVlMeUcv?=
 =?utf-8?B?anZIRVVwZGJDMkxOelNhM0NJdlo3MlR1TmlSMVkzWi9TanZMclhaa2lTMFFV?=
 =?utf-8?B?K2Z2RGtZUXlscnY2R3YyRm1zb3RkeUwyREs4OTNleDlyTTFlQVUySFRIc3lI?=
 =?utf-8?B?UFhmM1hvcXRkQ3ZVNXZoTjR1T3lIZnAwcFczRzFJc29NK0VIWmFzMzhqcUxI?=
 =?utf-8?B?UlFvU2xNSXlQNjA0azB4MHA1Y0RqTzNZNXdPdUkvWE50VU50TTdpT0o3a3JE?=
 =?utf-8?B?Nk1aL2ZMTDVlODRlVldVSlQvbENxWFEvaFlRUlB0Q0NLbXBPYWlNcWFxalpT?=
 =?utf-8?B?aDV6U0hpWjEyQVBFVk55MzRoN0w0cGxSbE1hVTFxWGx0MGxxQWpWcldIRjVJ?=
 =?utf-8?B?bzZvZXR4dWRjL2hick9talVHT1hXVWM0cTd3Z3AzbkZsa1dWM2NyZmYvRFla?=
 =?utf-8?B?cU1nMDBzK1V5Q2ZMNWRmS1h1N2ozcGoyampYRm9lQ0dWSVpEdVRqTldIVnd6?=
 =?utf-8?B?QVZwaGpqMm1UbEJSbUxVTkg1ak12WFpIZlBONVAycFVFOUhIWXluVnFPeVc1?=
 =?utf-8?B?VnlDU1ArUUFHTGRJNmtrOEZGS2xhTUVoUnNGd0tEemRPMU9Dem5GL3cvUDNj?=
 =?utf-8?B?czB3Zjl3em1RdHh5WUFWcTNTWSthUCtWNFVVQ3ZueHJaSENFRWJKSDhTOStU?=
 =?utf-8?B?WjU1bEpBbEU1ZXQrTmZYcmtDWm1NQlQ1OXQ0Ti9raXZGVjhRSGlCOHh6L3hS?=
 =?utf-8?B?VDltMytIM1dIOCthS0h3ZFZKU01ydDlLR3JWemVIL2dMWUs2YkpmNHJMaE5B?=
 =?utf-8?Q?iNBRo1KviLHlZd80ac5+6dKSOoMjuih5?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 4f2d8f74-a5ac-4f29-a0a0-08d9953e59c2
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Oct 2021 09:28:48.2350
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: andrew.cooper3@citrix.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB3863
X-OriginatorOrg: citrix.com

On 22/10/2021 07:47, Juergen Gross wrote:
> When booting the xenbus driver will wait for PV devices to have
> connected to their backends before continuing. The timeout is different
> between essential and non-essential devices.
>
> Non-essential devices are identified by their nodenames directly in the
> xenbus driver, which requires to update this list in case a new device
> type being non-essential is added (this was missed for several types
> in the past).
>
> In order to avoid this problem, add a "not_essential" flag to struct
> xenbus_driver which can be set to "true" by the respective frontend.
>
> Set this flag for the frontends currently regarded to be not essential
> (vkbs and vfb) and use it for testing in the xenbus driver.
>
> Signed-off-by: Juergen Gross <jgross@suse.com>

Wouldn't it be better to annotate essential?  That way, when new misc
drivers come along, they don't by default block boot.

~Andrew


From xen-devel-bounces@lists.xenproject.org Fri Oct 22 09:56:07 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Oct 2021 09:56:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.214907.373751 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdrHM-0007YG-7F; Fri, 22 Oct 2021 09:56:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 214907.373751; Fri, 22 Oct 2021 09:56:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdrHM-0007Y9-2x; Fri, 22 Oct 2021 09:56:00 +0000
Received: by outflank-mailman (input) for mailman id 214907;
 Fri, 22 Oct 2021 09:55:59 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=fDp0=PK=citrix.com=roger.pau@srs-us1.protection.inumbo.net>)
 id 1mdrHL-0007Y3-Ag
 for xen-devel@lists.xenproject.org; Fri, 22 Oct 2021 09:55:59 +0000
Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 4112113e-331e-11ec-83b1-12813bfff9fa;
 Fri, 22 Oct 2021 09:55:58 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4112113e-331e-11ec-83b1-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1634896557;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=A0+8ClT1S337zV3rUlFBZ63G/WOU6XiR8bymXu3D2vM=;
  b=bI1efhTBE4NgrASZk34pKJxzP2nTQUJkpL3gHgzNPwDIw361IvFxgy62
   XpqfVFjWHhdzGjSbZVpz4yJUsA6w7EDiyCrrofmadMeuGUN9oQd7duRr/
   tg/aLwRM/teBGo1evhVw48LHHwdUwQ/tCRaJsCRzhcSeyT/t58bVnt1oK
   M=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: 27zrPdD7SZoi4uQahePBhYstjTeG9PgCDXb4OfU3yR7csNG9h2+mo7qcSC16zNTqn0vPDvRH2b
 9zncU+d6sGOEJxHOs4rvEBuozU649PGE1DKPXk7TyP5jPo5zhZZGjvmhISsz+jVkbVp5yDoKZZ
 wuwq8mXmKckrQ/yJwBWe9ZcSLdUV8YTIFPmqu8hr6GYZhNm2mn1kmrdp3lQxFoDG7cT0Lpxweh
 28AdUenyreTKCD672WBtNCdVFdPubWp8EJeadYFEjAb9UITHPNZtrNXWVXd01vaxqz4W0FR5ff
 jnKDUb7NJnbuwaffrn3Sb7A4
X-SBRS: 5.1
X-MesageID: 55840548
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:KaGVLKBk2F6iOxVW//Lkw5YqxClBgxIJ4kV8jS/XYbTApDtw02BTz
 GIXWm7VPPeNYWCgc4p0atm1oUhT6JCHm983QQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA
 xA2M4GYRCwMo/u1Si6FatANl1ElvU2zbue6WLGs1hxZH1c+EX5500g7wYbVv6Yz6TSHK1LV0
 T/Ni5W31G+Ng1aY5UpNtspvADs21BjDkGtwUm4WPJinj3eH/5UhN7oNJLnZEpfNatI88thW5
 Qr05OrREmvxp3/BAz4++1rxWhVirrX6ZWBihpfKMkQLb9crSiEai84G2PQghUh/uxiZgdZz+
 v50hLvvVCF1B/Tz3/4MXEwNe81+FfUuFL7vJHG+tYqYzlHccmuqyPJrZK00FdRGoKAtWzgIr
 KFGbmBWBvyAr7veLLaTUO5ji95lNMD2FIgepmth3XfSCvNOrZXrHviauYcFgGdYasZmQurPa
 u8SThZUSh3NfURREVYzA7Qeg7L97pX4W2IB8w/EzUYt2EDMyCRh3b6rN8DaEvSaSMMQkkuGq
 2bu+2XiHgpcJNGZ0SCC8H+nmqnIhyyTcIAYGaC89/VqqEaO3WFVAxoTPWZXutHg1BT4AYgGb
 RVJpGx+9sDe6XBHUPHNcg2mpny2lSctfIVNNbEDsT7K0LvbtlPx6nc/chZNb9kvtckTTDMs1
 0OUk96BOQGDoIF5WlrGqe/K9WLa1Tw9aDZYP3ddHFRtD8zL+dlr1nryosBf/LlZZzEfMQr7x
 CyWt2AAjrEXgN9jO06TrA2f3WzESnQkSGcICuTrsoCNslwRiG2NPdXABb3nARBodtrxor6p5
 yBspiRmxLpSZaxhbQTUKAn3IJmn5uyeLBrXikN1Ep8q+lyFoiD4IdAMuW4ufBw0Y67onAMFh
 meJ5Wu9A7cIZBOXgVJfOdrtW6zGM4CwfTgaahwkRoUXOcUgHON21CpveVSRzwjQfLsEyskC1
 WOgWZ/0Vx4yUP0/pBLvHrt1+eJ7l0gWmDKILbimnkvP7FZrTCPMIVvzGADVNb5RAWLtiFi9z
 uuzwOPTmkwBCrWnP3GLmWPRRHhTRUUG6VnNg5U/XsaIIxZ8GXFnDPnUwLg7fJdikbgTneDNl
 kxRkGcBoLYmrXGYewiMdF55b7bjAcR2oX4hZHR+Nle0wXkzJ42o6f5HJZcweLAm8s1lzOJ1E
 KZZK5nRXKwXR2SV4SkZYLn8sJdmKEahizWRMnf3ezM4ZZNhGVDEo4e2Ygv1+SASJSOrrs9i8
 aa43wbWTMNbFQRvBcrbcty1yFa1sSRPke5+RRKQcNJSZF/t4M5hLCmo1q07JMQFKBPiwDqG1
 lnJXUdE9LeV+4JsqYvHn6GJqYutAtBSJEsCEjmJ96uyOAnb4nGnnd1KXtGXcG2PT2jz4qijO
 7lYlqmuLP0dkV9WmINgCLI3n7km7t7iqrIGnARpGHLHMwaiBr96eyTU2MBOsutGx6NDuBvwU
 UWKo4EINbKMMcLjMVgQOAt6MbjTiaBKwmHfvaYvPUH3xC5r577WA0xdMi6FhDFZMLYoYpgux
 v0suZJO5gGy4vbw3g1qUsyAG7ywE0E9
IronPort-HdrOrdr: A9a23:NiT1SKiuhsSq0E5TEc5CTS4eeHBQX2t13DAbv31ZSRFFG/FwyP
 rPoB1L737JYWgqNk3IwerwR5VpQRvnhPlICPoqTMmftWjdySWVxe5ZnPDfKlHbakjDH6tmpN
 tdmstFeZzN5DpB/LzHCWCDer5KqrTqn9HK9IXjJjVWPHxXgspbnmFE43OgYzVLrX59dOME/f
 Snl656jgvlXU5SQtWwB3EDUeSGjcbMjojabRkPAANiwBWSjBuzgYSKUySw71M7aXdi0L0i+W
 /Kn0jS/aO4qcy2zRfayiv684lWot380dFObfb8yfT9aw+cyDpAVr4RH4FqjwpF591HL2xa1u
 Ukli1QevibLUmhJ11d7yGdgzUImwxemkMKgWXo8UcL5/aJHw7TT6F69Nhkm1LimjkdlcA536
 RR022DsZ1LSRvGgSTm/tDNEwpnj0yuvBMZ4KMuZlFkIMAjgYVq3MYiFYJuYeA9NTO/7JpiHP
 hlDcna6voTeVSGb2rBtm0qxNC3RHw8EhqPX0BH46WuondrtWE8y1FdyN0Un38G+p54Q55Y5/
 7cOqAtkL1VVMcZYa90Ge9ES8qqDW7GRw7KLQupUBjaPbBCP2iIp4/84b0z6u3vcJsUzIEqkJ
 CES19cvX5aQTOnNSRP5uwDzvngehTJYd3d8LAp23EigMyPeFPCC1z2dGwT
X-IronPort-AV: E=Sophos;i="5.87,172,1631592000"; 
   d="scan'208";a="55840548"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=KU1UjmwE8w7NNPf/eQDq/30NZDZ4eJofRC5GSsqhyQEAE111MAUtTHObroV20nDdF7FJQBtQOOkNrwfsVQmhHm2HPoRaJOQPG5L2dz++6D2ZZvqDcKkojMQ55C69/1XTBYOIOzOI0TDNKKK72K6jAjIZ9qkb+PCLDHiiulcg8CmfQ8X3QxZ07S9wsxEa/1Tb4ReqfDuow9FAfxWklvjNFGnlvPxqXBaHAm/V3sM11OW+J+dS7fWfSxec79LZ8NpLuG3NdncoidUSIxMWW75c37abvmBDfCemk1UMyAVMts78tHk8O3C3RHmWQvdjiFm/2sEdGqPM7RMbCJdA3pTUZw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=UTo9TBQcK1jyKcuXW85QXab6ida/aLRFTSoVKZPUKK8=;
 b=elj+IswdSU/9jj5M70VpErrFMa3/niS4Ui3NA/idK0K7q8rN621KzebITk/K2YYeyxRPNOsELWK2V2tAo5c5L42masURCnaBFzVkY+IyVQwxZ/23PeWKj0F7TT0k/kMg6v/LNufl0MQMmr6+GoRFR9TCqHUsl0E2MN3A3L3/NUnBuUDLo1XTUaLL/oBFpMQf5Xi2hIjGlJG/5C2jc2blM8Hf/rEHPWslhEe35GR8i2E+WDkIcAwj6SrxJ/RuW24y+ODHKG7E1Zlvr6ViHBFcX5kxdKhcJt+9DIBbwC2sGAHkfABJWVruZ76AjBg8zFl6/OQLtiS96CJNj0WIUN+FtQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=UTo9TBQcK1jyKcuXW85QXab6ida/aLRFTSoVKZPUKK8=;
 b=kSDy5t02w+DIbLgFq289iWvoiv7aqkwkMqgKqYlFoGbZlC5AT7CPzxDzi2VxMkgquQGcmLHhZrK+2bwDhK8NkNIISsvafRwmRnxZv1CKEgSVBmjW6kzK0TWhz8ClfAHVKQ205WSxLOA+olFqUfc8RKrE13dwnO1iMG+eEFuEsoM=
Date: Fri, 22 Oct 2021 11:55:50 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Andrew
 Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH v4 1/6] x86/PVH: improve Dom0 memory size calculation
Message-ID: <YXKKpgSCiIXf/4R9@MacBook-Air-de-Roger.local>
References: <cbdc93a6-e675-420c-f7e8-53aa407766ba@suse.com>
 <4684f314-2c4e-f662-bd4e-132be001da9e@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <4684f314-2c4e-f662-bd4e-132be001da9e@suse.com>
X-ClientProxiedBy: LO4P123CA0277.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:195::12) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: c12af8e0-cb86-4edc-0cec-08d9954223a9
X-MS-TrafficTypeDiagnostic: DM6PR03MB4140:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <DM6PR03MB41406F1C12D517633249F8188F809@DM6PR03MB4140.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:5516;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: Pr6dyNZKWjmeHxMlTLuWxT/0DE+cUA8toXOwA4aAdPoD+pMvAwFg4N0kFDxQD/KtaSfb8YNNHPIMnbGVjKUZNylQvlZfpKFRCodaFCfBpSKzKqSWSe1JbZ4AdhaJhfWEhgaL7tmdpbE1I69wLVuf40OYuSl5l9+ATdRRRSCYXjTWQb0b8X0qrzx3hWm07Y46UAYK/dXyadgtextsf5+KGY1+SRITvPs2hgjV9Q0z63uTKoPox2ZmRH1tEJ5EKy/RUak9BzNDcDfESSuw/Pn6J2LhgF4hslCL9gVigfrvhSrx5ME/p8UwDBwHWOiNFgSrER/qGibhGIwSTak69AyxCWvu9eA3bje8Wnhyk/emqxixmKnvFjCiVOGiGgB2zmlm101iplFumgZqfgnnHIJaAxln4PpHxywzHumYSNh1mBSQ636A01mD9Lx9DOd9yHfTurz56GqfPXGRHG+PL/6z10d+4R9yLKNAsTGwxU8Tzd4Yx7MJYvGHGU2Thbm1okHeWP9iPyozMexH2TpgbUY7U81IZYfSS2OJMoJH2dvjkp7eB0qyqTXYS6bkLIfw+OW37Urcbcl40GClXw2R1TWdN8zwWED0L5Z9U6LEvtZFRkOcY29Y0S24x/fUGYQE2CFz/RbRUK9knBXeT/180xp+k9JIi4H/cMpm88RqQL0EWx8uMsT2rENMWOanRVgMztyyzgEowpZPyWY47Ijm+orl8g==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(26005)(6496006)(9686003)(66476007)(4326008)(66556008)(66946007)(2906002)(8936002)(38100700002)(8676002)(6666004)(186003)(82960400001)(6916009)(956004)(508600001)(316002)(85182001)(86362001)(5660300002)(54906003)(6486002)(83380400001)(25903002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?czByU1IwN1J2WGg5bXF4SmRiTFdiSFdSMzRSUENmZmtXRzRFRFhWSnZ1Zjdm?=
 =?utf-8?B?NFVSS2Q5UlNOclp3Y2lCYVJ1UG10QTNKNjlmeDhuV001YXBaTTUwZm50K29T?=
 =?utf-8?B?WVg1U3UwWGdRNFE3NnFOdjlxanZDWk1IOVU3QTFKVlZLeHFoZHF2bmllL2k1?=
 =?utf-8?B?MVhOOUVMbk1PYkNaU3c5d0NzOTFva3lCUjZLL3EyZlBsMEl4amdpeGpkKzRP?=
 =?utf-8?B?cUVxaFltTll4MFFiRGRNNXJ1UWs2d0taRktjTDVLbnoyRk10Rjg5OUlGV2x1?=
 =?utf-8?B?V2VlWldubGVqQWpnSDBxcWJtQnVncklhNGdBR0lpYWNsM0JvZWsxM05SSURt?=
 =?utf-8?B?UktnRTlpK0lMMitqSEFPc2REQkFEMWZhbXNsQU5JNWxHWTBUL0t2cFljWmpr?=
 =?utf-8?B?V1FocDZ4ZUdJRUZhMGx4eDM3bTVmblF0S1JLaFRURjNXT0RqTWxrZkVEd3pk?=
 =?utf-8?B?Mmp2S3FlZ0pTZWFITGErU04yM2ZON2RuWExiMjVQWSszTFg2UWozaW45OGNT?=
 =?utf-8?B?RjlHQnBUYjgyejcyWGZKKzM3NFNFSkdORVRpUXE2NmhCQ2kwTk1jU0piU1FK?=
 =?utf-8?B?ZGZwcWUvRHJnSTM3MzZpbnhFaWhESTlpOEFhMEhNTis3UmNoRjB4c2wzNFln?=
 =?utf-8?B?Tm92NHVGNzNLS0xGSmRSemlpQUhBUlVwTURBTUxqaURPYWtqcDYxUDRoUUx5?=
 =?utf-8?B?LzRwVWNGVURldzJxV2hIZE5KTzVPSXQ3Z2hnd25hMXRselJQZFM5VVlHTkZt?=
 =?utf-8?B?TDg4dDhPQjRSQnlDeEVuUnJLMXFwTjV4ZENHMVdTY0RkZC90NnVUQ3RLMER5?=
 =?utf-8?B?U3VURXNPTkwvNnFlRXMvTFF3M3NWUVlzZVBJK2ZTcjZWYWZmU2JZdU8yR0FX?=
 =?utf-8?B?b3pDbkxvVFViWXB1VUpubGY4NitYMjhXWDh2em5oOUcwZXNyaVhQWGNsSnR0?=
 =?utf-8?B?ZXZYOFlrVTJGS2dXRUo2amNFUGlmTFFxOFNhWmxWUFJvMmlOdHljVlpibTJU?=
 =?utf-8?B?Z0xIRmU0eXlvWGV0amhOSmt4Y0Z0UzM0cE93NVNjTDV6WUxDeUxPcEhVWGdW?=
 =?utf-8?B?cFBDc2dINlIyM3d2dnVKTVFiWUJHcFRIQVBSTlJlZU43Z1pMT2dUcFo1RDJC?=
 =?utf-8?B?NUQzalhCcE40bEh2bDhCanA2VkRuNkdVYmVPL1VCZlhFWjBOYmdwOUJtMGZN?=
 =?utf-8?B?djlBaC9tRXVJZWlmcFlJRnNWV0NwME11amp3WDhLVnIwTzVsL1JWdG1jbWl4?=
 =?utf-8?B?OS9hZm8ra2pObTQ2bFJiV0dFb3NuMTlsRDhrbVBGME5pVXNrWi93aWZnQWta?=
 =?utf-8?B?RTVPT2RINHBBNXZPMXEyb2FuOHVCTi9QWThlTjZSdTF2dmNyVGJUWStldjJt?=
 =?utf-8?B?WWtzYVg2UDZQcm9qY3hOQmgxNkNyeC82QzdTV1IrVTdIckVrUEFsNGhUc2tD?=
 =?utf-8?B?Y1FTMlNSdTNxNVZyUW8vRFQxT1g1VXcvdXRhQmtZWnJGaTZSS0xFZEVQRGov?=
 =?utf-8?B?eURJSFR3Nk80Y1B3MUg5ZFBtUmR4em1yZG9nTVZyS3JCTk83Tnh0VENoeUtG?=
 =?utf-8?B?dGRvQUZkOGppVk1DNmpHVllyWXJxMHR6bWp6UkU0eUdZdUh4LzNqV1VVY1J6?=
 =?utf-8?B?RTZnbFRYejVHd0l1WnBCYUZUT3lKUi9hQXFCWTM1aE1mT01meUhDSm4wVmdu?=
 =?utf-8?B?eGFzWWRsdlpyakR1ejE1cXV5SkQ5VGtVZWQ2cVJoc0VJSGxId294ZHVaV1Mz?=
 =?utf-8?Q?QcjIQPM2O8NIuxhs3Pf58Yaue17hUtUkGMZLi2b?=
X-MS-Exchange-CrossTenant-Network-Message-Id: c12af8e0-cb86-4edc-0cec-08d9954223a9
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Oct 2021 09:55:54.9731
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: roger.pau@citrix.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4140
X-OriginatorOrg: citrix.com

On Wed, Sep 29, 2021 at 03:13:24PM +0200, Jan Beulich wrote:
> Assuming that the accounting for IOMMU page tables will also take care
> of the P2M needs was wrong: dom0_paging_pages() can determine a far
> higher value, high enough for the system to run out of memory while
> setting up Dom0. Hence in the case of shared page tables the larger of
> the two values needs to be used (without shared page tables the sum of
> both continues to be applicable).
> 
> To not further complicate the logic, eliminate the up-to-2-iteration
> loop in favor of doing a few calculations twice (before and after
> calling dom0_paging_pages()). While this will lead to slightly too high
> a value in "cpu_pages", it is deemed better to account a few too many
> than a few too little.
> 
> Also uniformly use paging_mode_enabled(), not is_hvm_domain().
> 
> While there also account for two further aspects in the PV case: With
> "iommu=dom0-passthrough" no IOMMU page tables would get allocated, so
> none need accounting for. And if shadow mode is to be enabled, setting
> aside a suitable amount for the P2M pool to get populated is also
> necessary (i.e. similar to the non-shared-page-tables case of PVH).
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> ---
> I wonder whether this isn't enough to drop the "PVH dom0 without
> dom0_mem" warning.
> 
> --- a/xen/arch/x86/dom0_build.c
> +++ b/xen/arch/x86/dom0_build.c
> @@ -318,8 +318,7 @@ unsigned long __init dom0_compute_nr_pag
>      struct domain *d, struct elf_dom_parms *parms, unsigned long initrd_len)
>  {
>      nodeid_t node;
> -    unsigned long avail = 0, nr_pages, min_pages, max_pages;
> -    bool need_paging;
> +    unsigned long avail = 0, nr_pages, min_pages, max_pages, iommu_pages = 0;
>  
>      /* The ordering of operands is to work around a clang5 issue. */
>      if ( CONFIG_DOM0_MEM[0] && !dom0_mem_set )
> @@ -337,53 +336,65 @@ unsigned long __init dom0_compute_nr_pag
>          avail -= d->max_vcpus - 1;
>  
>      /* Reserve memory for iommu_dom0_init() (rough estimate). */
> -    if ( is_iommu_enabled(d) )
> +    if ( is_iommu_enabled(d) && !iommu_hwdom_passthrough )
>      {
>          unsigned int s;
>  
>          for ( s = 9; s < BITS_PER_LONG; s += 9 )
> -            avail -= max_pdx >> s;
> +            iommu_pages += max_pdx >> s;
> +
> +        avail -= iommu_pages;
> +    }
> +
> +    nr_pages = get_memsize(&dom0_size, avail);
> +
> +    /*
> +     * If allocation isn't specified, reserve 1/16th of available memory for
> +     * things like DMA buffers. This reservation is clamped to a maximum of
> +     * 128MB.
> +     */
> +    if ( !nr_pages )
> +    {
> +        nr_pages = avail - (pv_shim ? pv_shim_mem(avail)
> +                            : min(avail / 16, 128UL << (20 - PAGE_SHIFT)));
> +        if ( paging_mode_enabled(d) )
> +            /*
> +             * Temporary workaround message until internal (paging) memory
> +             * accounting required to build a pvh dom0 is improved.
> +             */
> +            printk("WARNING: PVH dom0 without dom0_mem set is still unstable. "
> +                   "If you get crashes during boot, try adding a dom0_mem parameter\n");
>      }
>  
> -    need_paging = is_hvm_domain(d) &&
> -        (!iommu_use_hap_pt(d) || !paging_mode_hap(d));
> -    for ( ; ; need_paging = false )
> +    if ( paging_mode_enabled(d) || opt_dom0_shadow )

Do we also need to account for opt_pv_l1tf_hwdom in case dom0 gets
shadowing enabled during runtime?

The rest LGTM, so:

Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>

I'm also fine if you want to remove the warning message at this time.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Fri Oct 22 09:59:00 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Oct 2021 09:59:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.214916.373762 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdrKF-0008ED-N7; Fri, 22 Oct 2021 09:58:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 214916.373762; Fri, 22 Oct 2021 09:58:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdrKF-0008E4-Jx; Fri, 22 Oct 2021 09:58:59 +0000
Received: by outflank-mailman (input) for mailman id 214916;
 Fri, 22 Oct 2021 09:58:59 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=KgL4=PK=suse.com=jbeulich@srs-us1.protection.inumbo.net>)
 id 1mdrKE-0008Dy-Uv
 for xen-devel@lists.xenproject.org; Fri, 22 Oct 2021 09:58:58 +0000
Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id d6802971-196f-4baa-9d1b-072387ccf976;
 Fri, 22 Oct 2021 09:58:57 +0000 (UTC)
Received: from EUR03-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur03lp2059.outbound.protection.outlook.com [104.47.8.59]) (Using
 TLS) by relay.mimecast.com with ESMTP id de-mta-1-dvhSc-osOASuwXTUUe7U4g-1;
 Fri, 22 Oct 2021 11:58:56 +0200
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0402MB3774.eurprd04.prod.outlook.com (2603:10a6:803:1f::28)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.18; Fri, 22 Oct
 2021 09:58:55 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::8062:d7cb:ca45:1898]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::8062:d7cb:ca45:1898%3]) with mapi id 15.20.4628.018; Fri, 22 Oct 2021
 09:58:55 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 FR3P281CA0046.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4a::12) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4649.10 via Frontend Transport; Fri, 22 Oct 2021 09:58:54 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d6802971-196f-4baa-9d1b-072387ccf976
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1634896736;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=ibfLXA2zjs5qaY/Ui2As+zAh1pplesWpfV1lAoi47OU=;
	b=YEgFx0Glkoq4IGSHg3prJOgmA2jSxrgN4Woo7PFGhQfbiVBq/0lRR0JHaRk68guA2ARF9W
	oFzcwfZvKc+dNgGckYhdMBewp+eIKDQIRwxdhNBkOTvYcTw+yv+n/bVa09Z1tdt4UPtA8X
	wzuGIUqG4tdEsFXXZCA0edXNKuZMtqs=
X-MC-Unique: dvhSc-osOASuwXTUUe7U4g-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Wny2NuhX6Kd1BQXkCcHmmpYeKZb0HPenzwlvs9Pn7hmSSeie2nhyCnjjrrgaQVGvOwgbKrPdpBYLhcw3BEJed0mqktt9XrMrYuiySwxCqRD8FrpEdjEpTHC3PxpVRsjCA1zgQ0N948a0lyQGlucXuvDTfQx9fLxxu2tais1iNw/4ndmkDx8fMYBTKOP0Sc8ErWcqsB1qK/oQKVNCVFvnE+chUN4aTIKgrvis7j1/drLzVlbEedt9EFoaH1CWTcp/B5IzdK5AHSwIJzsE6ht/HiQjkM4y6kTxOyc6eg3U6vaiUVBoYocMSuovNGbtD6Uy7ddc2Vo1BkHwoxJGkd2jZQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=FenLaUIXSE7u3OniYmEEaoPqXXNQJjXPZQlKQi+YVY4=;
 b=Wz3w/zPgPVod/MkJYVEw4ENS5n35jEj6br1V5uEdELiICHLhyHH0JY0AzWGCjCElmUnRpcW/67vSP7gDnikpcBit1XlAYV1LWBmZTHu5hS1HOKGThzsezUBybBhWS4t9WOSgTyvQ5OTsvWJTnuYnHqRb8sCEstBY5wu9f1IFryswiC85zYN1Hy/TJ/sRPQ9K/eldOwNQ0w2UUgXYG+Vj1Xmy1BpMLxWjc21+VjLq7S4R6vAY5WRWcK7SjvVveH5K2eZMuNoHhvTG/ztHdE9UgBJRibnk17N+0uL71wNv3Oab/TX1rwnxgm9wo58kbAfym6mX4iyBfZXyN4NJCIu9Xw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Subject: Re: [PATCH v4 1/6] x86/PVH: improve Dom0 memory size calculation
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
References: <cbdc93a6-e675-420c-f7e8-53aa407766ba@suse.com>
 <4684f314-2c4e-f662-bd4e-132be001da9e@suse.com>
 <YXKKpgSCiIXf/4R9@MacBook-Air-de-Roger.local>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <d27114fa-ea85-b6ed-0ae1-c1598c708a72@suse.com>
Date: Fri, 22 Oct 2021 11:58:53 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <YXKKpgSCiIXf/4R9@MacBook-Air-de-Roger.local>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: FR3P281CA0046.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:4a::12) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 7ff30001-1d18-4102-2165-08d995428f06
X-MS-TrafficTypeDiagnostic: VI1PR0402MB3774:
X-Microsoft-Antispam-PRVS:
	<VI1PR0402MB377472880FBCF5A6E7A8D5FEB3809@VI1PR0402MB3774.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7691;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	B3vKCf4W7IKcWcPoTbjVolAyGTE7w3xy6Y2d5DOQpHixYzx1ZWMoO2ZnxoCnGzQSTHC/mvVZr5CjDHTI5xEVo4J5qlNC26NAgWvByawgeP8jQeFfRGa6Z+SqjSoTUJ4ocVdPdVA/uZDjSYzhiFaGjr6yKmWBrwy+YD2+EtgldYNtHq33qVRdk9qqx+ND/SGAfKYBWk2crZ9Ygmty2bycXVHqSNgYHSktIB1hMvyQcJYy4nMtZhrP9K7uwiHqPZ+z/sFw9NI1QOdLQdcWO6T29YZuhPCa82sw064flCkmMJQPXoArcGYYzeFlNmSZiM9I5gST9x0Td79KVVK8tABJ95OFSM2HYutKC94pJg/kUrqqsvO0aQaWszpUdzu6/V+DS0+gjQH63Z57NZfXCFEZv5xLYOXP1lW4zXMGrkXSKRsl5OROWTkK4fRBtDEaxmRCSgNBhHOEicFdcydltV8rEqCaVuDka2PFztgGPMHZBmgrwxBdjrRQu0FAYZ5ea8D+qrysjniqhT+kYwpCN43BTQY05aSH94uNWaorhMAolDLq9MRPW0uiVIm6l00ZWG6iFmygdhS8j8Vv6zSWAGklq29YErnuTzmwtZrW/+yu7ah+jDaf0ybQQ0MlRTwls/++xqUCphb1XXIszGSPva2N8ZlizedtjRZ7yiN4kSpmG7Lfpmc3aIsO4z+UNIR8muaNflD2rVulLmu8dxMfOVnBc7a90mZgQ6akxUsjrT9wYBHIbieCH1gqV7mD52t0DsPG9xIBCD8qyY2XSjfbTQmU/w==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(316002)(16576012)(2906002)(5660300002)(6916009)(31696002)(8936002)(8676002)(86362001)(83380400001)(31686004)(36756003)(26005)(66946007)(66476007)(53546011)(66556008)(956004)(4326008)(2616005)(186003)(508600001)(38100700002)(6486002)(54906003)(25903002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?ykiIlRITuVXoxiwyv7cCFA/9S4bglPlVjJlR5L8YNnjF7ze4gxozP7k/RteU?=
 =?us-ascii?Q?nFv07MR9xiHYRf8zFS7ZIkPiPRc5TvkNF3cnnQvzLvVD+lX8ddhH1xL1SHnQ?=
 =?us-ascii?Q?MUFdn/0m6WG0wpewcjvhHY15DLZAPtlgNiEUwdnLmohHFYjgyAmCR1EUrRLq?=
 =?us-ascii?Q?toxwSRMsaClIKLT2r6kV9IBVOUSQDsVXZMIZzRiMdapGzbsE+ojmBcCM7Ujg?=
 =?us-ascii?Q?lTod/+oa6AZdEwdj/cSjL3iK98v3cWZm9SFASOKoxqIjm7XCRBju4LS7FUrk?=
 =?us-ascii?Q?LvAH4Hd5xstiDKRUj0IfwEORLN6E5V6f7v7VurWWlBb+KUay8TwZJmSL+Rok?=
 =?us-ascii?Q?4duiYE4mG9RrYHfZqWd5Qmn89Ba/SwP8LoWPD+xg5y02lpeLq0S4Td3HEZn2?=
 =?us-ascii?Q?AdwZPXA9gTiiIMkHWMifXl8rKRBWX9IIxltDngtXgVQJgLEpvrMbb5Ti/+GZ?=
 =?us-ascii?Q?Y6IEjrNcJR98QVfQs3F7rV3FJQMNFukILJi8MaRdPcE45/h478uH+0hmK2r/?=
 =?us-ascii?Q?QxvXfJ7xlfEPNZ/rPPhMZ148JboE8EAj1SJAl2qGZrZzpaOVdx7VpAsT7rKS?=
 =?us-ascii?Q?BIuFwRoaYdCdZA6jjqFzo4LL00DI+G5J5vZseZ7QDibSp+tmVM6fE+PlfBlD?=
 =?us-ascii?Q?i84otj1zkSS52vSY1thI4q95q1/dzTxcTQttUsV2FsUQc7oSIFFOe03Ri5Zu?=
 =?us-ascii?Q?huEVWQt0q/Nco3jWthM1bK1PZNb3ARjmoq619AuK5OE3qLt1DVdMXEihulzG?=
 =?us-ascii?Q?7f6N/eqDUxBB9kXJsSSM7/aCcE9qC9EPo3146SFeXrl2Vi1dYa4voEomsk+c?=
 =?us-ascii?Q?KUIhJ1n/kR1I1v5NZ/wL974+qucXm/+GeAgs0ZEw61qAYXpYz3IUKbcS1W0a?=
 =?us-ascii?Q?PfvPRcNehU9OkVwYzDmdojQxr/q+68hEszlT0VSWMMdMk1dbpwC1RWD5eP1N?=
 =?us-ascii?Q?EH5vFaWd8f+dgMw5V0b9DCXn4+ztCJfbtyBVQtUAemDM2l5jgBBT3+mBSjOK?=
 =?us-ascii?Q?yPG+Mhq1QLplLsvsfTBGa6zO7WfyEXtJBIgl2eqKaqP4FhVCAVEV8O9Xq7FT?=
 =?us-ascii?Q?+FMEndenQfTzMeQiYXZqbJJ7ZCyhlEbU3z3qRlSCrGh7YbI4FZ5O5Q7cljZD?=
 =?us-ascii?Q?zL6UQkRuGhzo6Q0Pl1UhyvB/M5jK31p2QVMVpvGtMFTorpdMrVWSnIudeVR6?=
 =?us-ascii?Q?oZ2IiNLvTQrtDdyWshVqv+CKhgkJNh14EIh1VXkAegmBP4glV8f8G2ia0Pr9?=
 =?us-ascii?Q?zCtw2XVMF0oeWXf0pMkTpdcjWP85yXtP2GqoQiz/ctdtBmeKMT9sJKrraY9M?=
 =?us-ascii?Q?Pgm3900D6gZD3i+zOd0VlB7mNf0N9dE+3sJDH9FZBKmFpd7cM/sFsX8dgsUT?=
 =?us-ascii?Q?i6vu5MYgspMV/om4ufhjxoStJceZX3dEhZ2Z8Ab3klYwc2PV19YX4SAPIcW7?=
 =?us-ascii?Q?rkw3vBd8oj8=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7ff30001-1d18-4102-2165-08d995428f06
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Oct 2021 09:58:55.0589
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jbeulich@suse.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3774

On 22.10.2021 11:55, Roger Pau Monn=C3=A9 wrote:
> On Wed, Sep 29, 2021 at 03:13:24PM +0200, Jan Beulich wrote:
>> Assuming that the accounting for IOMMU page tables will also take care
>> of the P2M needs was wrong: dom0_paging_pages() can determine a far
>> higher value, high enough for the system to run out of memory while
>> setting up Dom0. Hence in the case of shared page tables the larger of
>> the two values needs to be used (without shared page tables the sum of
>> both continues to be applicable).
>>
>> To not further complicate the logic, eliminate the up-to-2-iteration
>> loop in favor of doing a few calculations twice (before and after
>> calling dom0_paging_pages()). While this will lead to slightly too high
>> a value in "cpu_pages", it is deemed better to account a few too many
>> than a few too little.
>>
>> Also uniformly use paging_mode_enabled(), not is_hvm_domain().
>>
>> While there also account for two further aspects in the PV case: With
>> "iommu=3Ddom0-passthrough" no IOMMU page tables would get allocated, so
>> none need accounting for. And if shadow mode is to be enabled, setting
>> aside a suitable amount for the P2M pool to get populated is also
>> necessary (i.e. similar to the non-shared-page-tables case of PVH).
>>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>> ---
>> I wonder whether this isn't enough to drop the "PVH dom0 without
>> dom0_mem" warning.
>>
>> --- a/xen/arch/x86/dom0_build.c
>> +++ b/xen/arch/x86/dom0_build.c
>> @@ -318,8 +318,7 @@ unsigned long __init dom0_compute_nr_pag
>>      struct domain *d, struct elf_dom_parms *parms, unsigned long initrd=
_len)
>>  {
>>      nodeid_t node;
>> -    unsigned long avail =3D 0, nr_pages, min_pages, max_pages;
>> -    bool need_paging;
>> +    unsigned long avail =3D 0, nr_pages, min_pages, max_pages, iommu_pa=
ges =3D 0;
>> =20
>>      /* The ordering of operands is to work around a clang5 issue. */
>>      if ( CONFIG_DOM0_MEM[0] && !dom0_mem_set )
>> @@ -337,53 +336,65 @@ unsigned long __init dom0_compute_nr_pag
>>          avail -=3D d->max_vcpus - 1;
>> =20
>>      /* Reserve memory for iommu_dom0_init() (rough estimate). */
>> -    if ( is_iommu_enabled(d) )
>> +    if ( is_iommu_enabled(d) && !iommu_hwdom_passthrough )
>>      {
>>          unsigned int s;
>> =20
>>          for ( s =3D 9; s < BITS_PER_LONG; s +=3D 9 )
>> -            avail -=3D max_pdx >> s;
>> +            iommu_pages +=3D max_pdx >> s;
>> +
>> +        avail -=3D iommu_pages;
>> +    }
>> +
>> +    nr_pages =3D get_memsize(&dom0_size, avail);
>> +
>> +    /*
>> +     * If allocation isn't specified, reserve 1/16th of available memor=
y for
>> +     * things like DMA buffers. This reservation is clamped to a maximu=
m of
>> +     * 128MB.
>> +     */
>> +    if ( !nr_pages )
>> +    {
>> +        nr_pages =3D avail - (pv_shim ? pv_shim_mem(avail)
>> +                            : min(avail / 16, 128UL << (20 - PAGE_SHIFT=
)));
>> +        if ( paging_mode_enabled(d) )
>> +            /*
>> +             * Temporary workaround message until internal (paging) mem=
ory
>> +             * accounting required to build a pvh dom0 is improved.
>> +             */
>> +            printk("WARNING: PVH dom0 without dom0_mem set is still uns=
table. "
>> +                   "If you get crashes during boot, try adding a dom0_m=
em parameter\n");
>>      }
>> =20
>> -    need_paging =3D is_hvm_domain(d) &&
>> -        (!iommu_use_hap_pt(d) || !paging_mode_hap(d));
>> -    for ( ; ; need_paging =3D false )
>> +    if ( paging_mode_enabled(d) || opt_dom0_shadow )
>=20
> Do we also need to account for opt_pv_l1tf_hwdom in case dom0 gets
> shadowing enabled during runtime?

Yes, we do, and I've added that to the check for v5 already.

> The rest LGTM, so:
>=20
> Reviewed-by: Roger Pau Monn=C3=A9 <roger.pau@citrix.com>

Thanks, but as said in a reply to this just yesterday, this is buggy,
and a v5 is going to be needed anyway.

> I'm also fine if you want to remove the warning message at this time.

Okay, will do.

Jan



From xen-devel-bounces@lists.xenproject.org Fri Oct 22 10:18:14 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Oct 2021 10:18:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.214928.373787 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdrcl-0002De-J4; Fri, 22 Oct 2021 10:18:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 214928.373787; Fri, 22 Oct 2021 10:18:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdrcl-0002DX-Fy; Fri, 22 Oct 2021 10:18:07 +0000
Received: by outflank-mailman (input) for mailman id 214928;
 Fri, 22 Oct 2021 10:18:05 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=fDp0=PK=citrix.com=roger.pau@srs-us1.protection.inumbo.net>)
 id 1mdrcj-0002DR-KY
 for xen-devel@lists.xenproject.org; Fri, 22 Oct 2021 10:18:05 +0000
Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id ee0a58e2-d60c-4d57-a1f0-cfbb03b23133;
 Fri, 22 Oct 2021 10:18:04 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ee0a58e2-d60c-4d57-a1f0-cfbb03b23133
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1634897884;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=uqizGUT6Fu/4JuQQPi92JSV5UmjKhcU1j0M0jjc86KM=;
  b=hWOnJs38jIvzI3PJeQdxPAb9NL5Yse5+cF+ZMARgt9OxdjbZqRv5BXVr
   mYYEnU1I7naZwmP+XqciweA/z/gBbnk6SlrJGKSGWT9NYgFrg6G9KvV4f
   bqo35tZgOPoOrmBGlkNvNUjFtTzP3zqEg2zPs2Se2Q0iuvSE/6NDWR8ix
   o=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: 3sZh67wHG9cgODIgrX50v550rXfpvBu4/Wr3NfKvgOEeoO6qFuo126ehEVvgXrGNbTQXIfmXFY
 B+r0HD1koYumc05RD18PVRPxdGbC+0FiWvjKubnpgcOKbit96B55QTcw4z/iMIuabi1nOo8VXv
 J9N9gFYyq/JgWCRZeyqAZ2uZYUE3mYMsUPZ+7oFiNh90ZliJcjsZiAeRkx/fr2xrTON9+d8nsq
 KW2e7lUf1y6Os9U9jq3Ej0l+sXWoqfLFvBAr3jA1AHd2027Rla8SrTsEyKSAV7ce7Oob8InvrO
 VqxdriVROumPKETgUqWXaf9c
X-SBRS: 5.1
X-MesageID: 57731633
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:y7zm7qsM3UmkQZY0LPmInAaSA+fnVI1ZMUV32f8akzHdYApBsoF/q
 tZmKTiEbP2MY2CjfNFzPI+0/BhT7JTUydc3SVdlqi9nFC1B+JbJXdiXEBz9bniYRiHhoOOLz
 Cm8hv3odp1coqr0/0/1WlTZQP0VOZigHtIQMsadUsxKbVIiGHhJZS5LwbZj29cw24LhWWthh
 PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe
 gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ
 Nplia6yaTgiDLbwl+lHS0JfKDpEF/xl0eqSSZS/mZT7I0zudnLtx7NlDV0sPJ1e8eFyaY1M3
 aVGcnZXNEnF3r/ohuLgIgVvrp1LwM3DJoQQt2sm1TjEJf0nXYrCU+PB4towMDIY258RRq+AP
 JFxhTxHUEqZXT5CJkwtLJcQw92Vu2fjMBBlpwfAzUYwyzeKl1EguFT3C/LKfvSaSMMTmVyXz
 krW8mK8DhwEOdi3zTue7mnqluLJhTn8Wo8ZCPu/7PECqF+Zy3EXCRYWfUCmuvT/gUm7M++zM
 GRNpHBo9/JrshX2EJ+tBHVUvUJooDYgadhwLOYI8z2Cx/DMuAGiHVIuHx1oPYlOWNANeRQm0
 VqAntXMDDNpsaGIRX/1yop4vQ9eKgBOcjdcPX5soR8tpoC5+tlq302nosNLSfbt1rXI9SfML
 ydmRcTUr44YitIXzO2F9FTDjiPESnPhH1NtuFu/so5I6GpEiG+Zi26AtQezARVodt/xory9U
 J4swZT2AAcmVsnlqcB1aL9RdIxFHt7cWNEmvXZhHoM66xOm8GO5cIZb7VlWfRkybpZYIGC5O
 BSO6Gu9AaO/2lPwMcebhKrqU6wXIVXIT4y5Bpg4kPIeCnSOSON31H43PhPBt4wcuEMtjbs+K
 f+mnTWEVh4n5VBc5GPuHY81iOZzrghnnD+7bc2rnnyPjOvFDFbIGOhtDbd7Rr1ghE9yiF6Oq
 Ig32grj40g3bdASlQGOoNdNdwhTcCBnbX00wuQOHtO+zsNdMDhJI9fawK87epwjmKJQl+zS+
 Wq6VFMew1367UAr4y3QApy6QL+wD5t5s1whOikgYQSh13Q5ON7956YDbZonO7Ig8bU7n/JzS
 vAEfeSGA+hOFWubq2hMM8GlodwwbgmviCKPIzGhPGo1cal/SlGb4dTjZAbuqnUDV3Llqcskr
 rS8/QrHWp5fFR96BcPbZav3nVO8tHQQgsxoWE7MLoUBcUng6tEyeSfwkuU2M4cHLhCanmmW0
 AOfABE5o+jRotBqrImV1P7c94rwSrlwBEtXGWXf/I2aDyiC8zrx25JEXcaJYSvZCDH+9pK9a
 LgH1Pr7KvAGwgpH6tIuD7ZxwKsizNLzvLsGnB98FXDGYln3WLNtJn6KgZtGuqFXn+ILvAK3X
 gSE+8VAOKXPM8TgSQZDKA0gZ+WF9PcVhjiNsqhlfBSkvHd6rOidTEFfHxiQkygMfrJ6PbQsz
 folpMNLuRe0jQAnM4regy1Zn4hWwqfsj0nzWkkmPbLW
IronPort-HdrOrdr: A9a23:aseQNKFcvdUC+6xopLqFDJHXdLJyesId70hD6qkvc3Nom52j+/
 xGws536faVslcssHFJo6HmBEClewKnyXcV2/hrAV7GZmfbUQSTXeNfBOfZsljd8mjFh5NgPM
 RbAtZD4b/LfCFHZK/BiWHSebZQo6j3zEnrv5an854Ed3AUV0gK1XYeNu/0KDwTeOEQbqBJaK
 Z0q/A37AaISDAyVICWF3MFV+/Mq5nik4/nWwcPA1oC5BOVhT2lxbbmG1zAty1uHg9n8PMHyy
 zoggb57qKsv7WSzQLd7Xba69BzlMH6wtVOKcSQgow+KynqiCyveIN9Mofy9gwdkaWK0hIHgd
 PMqxAvM4Ba7G7QRHi8pV/X1wzpwF8Vmgnf4G7dpUGmjd3yRTo8BcYEr5leaAHl500pu8w5+L
 5X3kqC3qAnQy/orWDY3ZzlRhtqnk27rT4JiugIlUFSVoMYdft4sZEfxkVIC50NdRiKp7zPKN
 MeTP002cwmMm9zNxvizytSKZ2XLzgO9y69Mwk/Upf/6UkSoJh7p3Fos/D30E1wsK7VcKM0lN
 gsBJ4Y4I2mfvVmHZ6VO91xM/dfKla9CC4kY1jiaWgOKsk8SgfwQtjMkfII2N0=
X-IronPort-AV: E=Sophos;i="5.87,172,1631592000"; 
   d="scan'208";a="57731633"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=RS+fCqgCyGg5zF1LTtOHNouGsBp1hBzQ/+htTea7YsLwFgE/6wlzv8vKX4MfrrgHS80eaJyMcEHR731K3xuRZwWKdJu4tsLsu6/k1m5elXHKDXxfkhGOSg6VbZ4KdMEfOnJ7Eg6zCaPpwuvvQz5p7+REykTHm0NrflHFCYdoJBYcZK0UxNg1PtZJhMoCpzAAJkTFzu19iAwEBdxZTT4BTSbYyKs2GD0Zctgxcg8lgxl3G8EQLtsM1Mvq/grlAZdszHW0O76f15smspvTz0VXhFxLAYHmSEfs824llSMmuraWg14dmridZXOwdguCrl7KK+p35dcX21PcGE3FvF8RLg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=sxuHHN9Arm1v4Q9NZNZy/rQ5hYYMUHQICf84d246qtg=;
 b=Ypu4NgfHLd/uQsHn6EDwpsFxqzbhJul5htS2FKG5rF1OFAS+6mBkYTZ2mtMGVWrsXWpJci0lfcCuVltZjaLGyPW5dz0nNyA9w0weHnJgbOI848wxRcvslfp3xPYKRVmUcbmNm9BxqPFDjhRZskWvgKv9pEQgS2/gonLYjQEikpz7jLuVJiHcZiesaTy8a6MXPMc1lMqgBUuzK6qo8YKgCI7cqnkaeXQIHnRQ6Y1tQctS0zSniTMDauOyrDOoR20+XJfrpAfbXCILRTsfLS9LtxTO8lEfKRS0x4S94mUhW3Z48zpkRmJN0u0JFWCto8WG/BOnVdbt1r9lF9xpIdjUdA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=sxuHHN9Arm1v4Q9NZNZy/rQ5hYYMUHQICf84d246qtg=;
 b=QVndQqOQ4w7AuOo86Wq08/UZqymWOTqP7UaY3JbfBmao2+KLi8xTtCa7FT4kDRY9vz90XkjDIbXoeFvv+5+49X0Bfxkp4E1TuNV2HZPpjJE57nyyxRzNpX+n1mN9djhVP6nnR3ai3jWDwD3PgukMPLGZqcknawINPEGloyPwmKI=
Date: Fri, 22 Oct 2021 12:17:53 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Andrew
 Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH v4 3/6] x86/PVH: permit more physdevop-s to be used by
 Dom0
Message-ID: <YXKP0ZZaBa0dve7U@MacBook-Air-de-Roger.local>
References: <cbdc93a6-e675-420c-f7e8-53aa407766ba@suse.com>
 <f7023f65-5cb7-fd2b-f320-c46a8e6e1ac1@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <f7023f65-5cb7-fd2b-f320-c46a8e6e1ac1@suse.com>
X-ClientProxiedBy: LO4P265CA0039.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:2ac::18) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 9706f205-e0a2-47f2-73d6-08d9954538df
X-MS-TrafficTypeDiagnostic: DM5PR03MB2780:
X-Microsoft-Antispam-PRVS: <DM5PR03MB27806F7EBEC5F4E32C46B3628F809@DM5PR03MB2780.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8273;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: kwoqpRWux8Q6GHpfOYNfDX5fsu6T1KhwK40J5bIeylASU9gy3Mlm98hqXU05NvgVFPC6mD6d9JI+0llJR4+b2j9j6dtFZNcQ0FwYaVqBDBzwVhAEPpJohAJNhhDc7/c+lv+YSePRXXOsn+8nmkRg6KQm9EhVFr01Ly75KKDQ2otHGgU3+HqiwWxgttlXblM6dxgVwpogwrb3nJXHIjmsZMvOjhzyS7xZcJHB3FFufatyyuLGXwZEwF7sczb/5HJlcWJIcOsLf3sPjUdRKq4Ls+eTPcrImiHOfPfytgk3e2lvbbjj19WN/nxGphZjBGRG2kEeu9lQUzkDmY2S0n2QehSSEiceSyXzOK3MAtK3OxUitaL0OaZDMDBOR4FRkMBWTYGx6NtRq8E1ruRKOVB2wACuKNGJkqV/0ZWbG6MRNw+Axuu+mAZ+3T9eYaYxZh5Bor4QEbCxzsyP9qD8FqRjTkF1/tjrsp5G3f4vwOYPmsDDYE6aDLDdSEYzlSJvqf1XVmkHUd8s5B5L0B5K51YuaAkRaOFImIWSY/A30ZoMmHuQfYFyPm34Hp8aWCZUiVKzXn5/lVeO6oNxb3EQzDkn6Tlz+YQF6ndWU3jEuN3kX1rq2ddybK3xtX6Z0kii+IjhxT1pmdKzZeWZv+C9VVsH6A==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(508600001)(6496006)(86362001)(316002)(82960400001)(54906003)(66476007)(4326008)(6486002)(66556008)(38100700002)(9686003)(26005)(83380400001)(6666004)(66946007)(2906002)(6916009)(8676002)(8936002)(85182001)(186003)(5660300002)(956004);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TjlYUDFkQ0pKdlRqRFhCVjUwcEF5d2x3dFFBVzZEenhQSVdkM2FrMDJpMm5m?=
 =?utf-8?B?M0U0M3NNVFZjMkYrMEhlWERBSi8vNURFRzJ3ZHl1YkRQVGZrMWhvT3JTVFRM?=
 =?utf-8?B?UmdFaXZuYWF2QU0xS3ppQ1JVdzJieGw5Qlp4YitWVUs3TkZyMURtaXAyVDhq?=
 =?utf-8?B?K0Jyd1dBZ0tHZ0VHOTYxUnlIWFlsTkNSbXJDcWhYYWNEekdvd2pOQy9NMXZT?=
 =?utf-8?B?NHhlZ1NqTWFnT21kbUZLRHlVQ1NFNzZ2Qlk1K1Z5OE9QR1pTa083RURPUGtI?=
 =?utf-8?B?OHJJMjRTK21VOXR0d0lBSnFYTmRmV0ZtTEwzd0hyYUFpcjVLK1Q3amZhaUta?=
 =?utf-8?B?blNxeG00YUI1K3p2SVhkZTNTOU9NbTBTNmJ3ZDZ3d3h5Slhqeklacm9lWStn?=
 =?utf-8?B?V3VRdE5UZmQ2SzlXS2tOVFZrY2xFTGJXQkRzWDhZSlcrM1FZYWVqMTdVUUE2?=
 =?utf-8?B?T1FJU2F0d3lnTSs2a09ydVNaNnc5L1lDeEdBUWlUOThNYnRKZGUramZzSlY2?=
 =?utf-8?B?WTR1bGp6cGNkN0lEc1NaQjI5VFRjSW0yTFdDNFBuN3JUcWpTT3d3WTFxWE5t?=
 =?utf-8?B?cFZhdVNsNUdTdklLaEVDbk5QOFkvZXJnSndwRTNaajFZeXppOXdPUkhodVVz?=
 =?utf-8?B?RE13QURpRVFkamZJWkRsZEZQVXBLVFJ0cGxiUkZXWHp6MUl0ekI2RmJyb0pP?=
 =?utf-8?B?QUZheW9pL3p6TFR1L2RFb20xTXJQRG8zbS9weS81ZDBRS2hWanVWd0wrVFRC?=
 =?utf-8?B?cHNuRkpEUHpRTVRGSTNYbkpSU25KVzhHWkVwZEZSQjhmRlZGU1BYNXN1d3RP?=
 =?utf-8?B?eGZsaktXblVrL0tLemZuTThHdWFNVVpNWXZ0VkJCbWgxWHlpZUR6SSszUE1j?=
 =?utf-8?B?ZlN6eWVTY3RkM1I3NkR1Mk9UZnRiZzJNTWVmMTlpRDZ2b0tOV2JkVnF1ZDgv?=
 =?utf-8?B?OHBrNTkrdTViamlMWUJNbXA5ZmxvWkpseFNNd29wRUtwbm9hYjl5ek4vZHRV?=
 =?utf-8?B?QjVQaEpEa092eUlGU1RtUHFOWWRXQVkxZTZiMzdUckFkK3JzQjNGVmRCaU9l?=
 =?utf-8?B?NWllaDNOTmRCaTJrM0JBZWRGU2ovV2RXRzdzRDd5OEl0UDc5NHQ4TWt0bjB3?=
 =?utf-8?B?T0VXVC8zai9kaFZCSGh5Zk4xKzVueVhlclN2T1lsditpUmVwTFZCL0NjWGtM?=
 =?utf-8?B?c1NSemdsamd1YjhYb0duaDg5cTA5TngrMEVXMGhCTWpQSEJXUW9lS3diTVg3?=
 =?utf-8?B?S0hIRlRUV2ZPbEdJZWk0UEdmRlZXWFladFNmOHBmMkM4UExrdllsMzdzMC9Y?=
 =?utf-8?B?aUs3Y290cy84dm5rWUV2Wnhldm1zMDlMS2hUU1RoanRNRnY4d3ZseEpFaE5i?=
 =?utf-8?B?WmxFa3FyU3lGNmltMS9HV3pRT00wbFFrTEMyaS9mMXlzc0RJaExjUWxSTDQ2?=
 =?utf-8?B?TkI5cE1uMXhOZGpZV1I4T2ZlcUw4Q0hmWUNDeTRvekpvVGFLNUFPUldBRzlr?=
 =?utf-8?B?S25UVURsZUVoZENuR2dIRGlUYWZ1dGd4M3dvTFhVSWV5ajlTUjdJbS9Sa1hX?=
 =?utf-8?B?Vk9Vb0dlbnpCcCtERGZYSHIvTnhPR1Z2amVBcE0wYUtqSk1pVHBsT08vNXV4?=
 =?utf-8?B?V0JEbU1xUXAxVXliQk5qWHVDTjNZbTJya2hzYkpjTnY5Yi9UOEIwVWZSekNU?=
 =?utf-8?B?aWt6K2F1VjdwVGxkZ1crdG5LUHZud2R4UzB5UEdZb3d2d0M1M0pUMW14NzZM?=
 =?utf-8?Q?chH0ywqma3OOfO2dbtxoirITqLxWKYd2IPkDQ3P?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 9706f205-e0a2-47f2-73d6-08d9954538df
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Oct 2021 10:17:59.1435
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: roger.pau@citrix.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB2780
X-OriginatorOrg: citrix.com

On Wed, Sep 29, 2021 at 03:14:13PM +0200, Jan Beulich wrote:
> Certain notifications of Dom0 to Xen are independent of the mode Dom0 is
> running in. Permit further PCI related ones (only their modern forms).
> Also include the USB2 debug port operation at this occasion.

Sorry, I realize now that I failed to provide a reply on the previous
patch.

> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> ---
> I'm uncertain about the has_vpci() part of the check: I would think
> is_hardware_domain() is both sufficient and concise. Without vPCI a PVH
> Dom0 won't see any PCI devices in the first place (and hence would
> effectively be non-functioning). Dropping this would in particular make
> PHYSDEVOP_dbgp_op better fit in the mix.

I agree, it's not an option to have a non-vPCI PVH dom0 anyway, and
the important restriction for those operations is the hardware domain
part.

> ---
> v3: New.
> 
> --- a/xen/arch/x86/hvm/hypercall.c
> +++ b/xen/arch/x86/hvm/hypercall.c
> @@ -94,6 +94,12 @@ static long hvm_physdev_op(int cmd, XEN_
>          break;
>  
>      case PHYSDEVOP_pci_mmcfg_reserved:
> +    case PHYSDEVOP_pci_device_add:
> +    case PHYSDEVOP_pci_device_remove:

Those are indeed fine.

> +    case PHYSDEVOP_restore_msi_ext:

While I understand the current need for this one in order to possibly
restore the MSI interrupt for the serial console, it might be a
cleaner approach to let dom0 restore the PCI state on it's own using
the native methods like it's done for initial setup.

I realize we are missing a bunch of stuff here, for once vPCI state
should be reset and put in sync with the hardware values after a
restore from suspension.

And then we likely need to either limit PHYSDEVOP_restore_msi_ext to
just restore Xen used MSI vectors, or if technically possible it would
be best from Xen to setup it's own MSI vectors when restoring without
relying on dom0.

> +    case PHYSDEVOP_dbgp_op:

This one is also fine.

> +    case PHYSDEVOP_prepare_msix:
> +    case PHYSDEVOP_release_msix:

Those two again I'm not sure should be added right now, as we still
haven't decided how pci passthrough will work from the hardware domain
PoV. I'm explicitly concerned about those two because they will mess
with the MSI-X state behind the back of vPCI, and nothing good will
came out of it.

If we really need those two in the future, code should be added so
that vPCI state is properly updated.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Fri Oct 22 10:31:12 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Oct 2021 10:31:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.214937.373805 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdrpB-0004Re-Tp; Fri, 22 Oct 2021 10:30:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 214937.373805; Fri, 22 Oct 2021 10:30:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdrpB-0004RX-QP; Fri, 22 Oct 2021 10:30:57 +0000
Received: by outflank-mailman (input) for mailman id 214937;
 Fri, 22 Oct 2021 10:30:57 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=fDp0=PK=citrix.com=roger.pau@srs-us1.protection.inumbo.net>)
 id 1mdrpB-0004RR-0n
 for xen-devel@lists.xenproject.org; Fri, 22 Oct 2021 10:30:57 +0000
Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 50f32cf9-4827-4a76-a753-febb8debdd72;
 Fri, 22 Oct 2021 10:30:55 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 50f32cf9-4827-4a76-a753-febb8debdd72
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1634898655;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=7GbyDwN/Lj03cwpelDYqAeiZLgbd7nPDhZUpxhw+Ttg=;
  b=RZoxcgMORNiicwu3dqZys5zM3zFzvwk8H3gC3d4e9KejrefutOYvagUx
   cTnQJH27ppf5iA9286kFUDbukCkMsuPTusV4/2A0o25Sv6gtdNA/dUp0V
   BBtEGOPw9RQwZhef93a3CFfBMBbfC1K9RUyNl57WK75cmZma5U6rwEj5a
   4=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: 45n/udTYUnJWbMQuCTT02mjIJyTEuS7WDx9VpVu+E0AaclpyHi7iRmcZMNW7RkjtBN74b9iAsh
 n7DEC359UIo2+qb70W+E977HjPPwcGmMddZQAPq/iCgtc4kPuclYqP+txHq+GaP7SpW19Ci1KY
 UlMcpF/Omddr+pv3mcudSOyH+jeN50JLDPXcQ14M3jLQe90zdSh1kLd4mvV+Xx7aHa7uyHXD59
 pMzUVIYpYHzYM1EpzQ1FZVFPzN50HdMUX4nlChwbROGGMTIThViBHi2qZSrRCzZDDtS6wWTkum
 s10twhRyzkJKIGJJuWOASTZT
X-SBRS: 5.1
X-MesageID: 57732291
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:iSRbCK0Nx+cUK0GudPbD5Qh2kn2cJEfYwER7XKvMYLTBsI5bp2RWx
 jdOW2/SaayNYTT2L9B+Yd+2o0tS6pWEy9VhHVc4pC1hF35El5HIVI+TRqvS04J+DSFhoGZPt
 Zh2hgzodZhsJpPkS5PE3oHJ9RGQ74nRLlbHILOCan8ZqTNMEn970Es7wbRh2OaEvPDia++zk
 YKqyyHgEAfNNw5cagr4PIra9XuDFNyr0N8plgRWicJj5TcypFFMZH4rHomjLmOQf2VhNrXSq
 9Avbl2O1jixEx8FUrtJm1tgG6EAaua60QOm0hK6V0U+6/TrS+NbPqsTbZIhhUlrZzqhk8pb9
 stS8qKMTig5E6zHyMIyYwcIOnQrVUFG0OevzXmXtMWSywvNcmf2wuUoB0YzVWEa0r8pWycUr
 6VecW1TKEDY7w616OvTpu1EnMMsIdOtJIoCknph0SvYHbAtRpWrr6DiuIAHh21q15km8fD2V
 e9GVANgaCn8TBRtMXs5A4pinuukiSyqG9FfgA3M/vdmi4TJ9yRu1JD9PdyTfcaFLe1Fk0Ddq
 m/Y8mDRBhABKMfZ2TeD6mirhOLEgWX8Qo16PL+y++NugVaT7ncOExBQXly+ycRVkWbnBYgZc
 RZNvHNz8+5iryRHU+URQTW0ulS6oAFbZeZXPP0X6Qrd7IXk/VawUz1soiF6VPQqs8o/RDoP3
 1CPns/0CTEHjIB5WU5x5Z/P8mvsYXl9wXsqIHZeF1NcsoaLTJQb10qXFr5e/LiJYsoZ8N0a6
 wuBqzQinP0thMoP2rTTEbvv0m/0+MahouLY4GzqsoOZAuFRONHNi2+AswGzARN8wGCxFAXpU
 J8swJD20Qz2JcvR/BFhuc1UdF1T296LMSfHnXlkFIQ7+jKm9haLJN4LvGEifRg5ap1ZKFcFh
 XM/XysLuPe/21PxNcdKj3+ZUZx2ncAM6/y1PhwrUja+SscoL1LWlM2fTUWRw3rsgCARfVIXY
 v+mnTKXJS9CU8xPlWPuL89EiOND7n1ulAv7GMGgpzz6gOX2WZJgYepcWLd4Rrtit/3sTcS82
 4s3CvZmPD0GAbSgOHGOrNZPRb3IRFBiba3LRwVsXrfrCiJtGX07Cu+XxrUkeod/mL9SmPuO9
 Xa4MnK0AnKl7ZEeAQnVOH1ldp31WpNz8SAyMSA2ZA760Hk/e4e/qqwYcsJvL7Ug8eViy99yT
 uUEJJrcUqgeFGyf9mRPd4T5oaxjaA+v2VCEMR26bWVtZJVnXQHIpIPpJ1O96CkUAyOrnsIiu
 Ln8hBjDSJ8OSl06XsbbYf6i1X2run0ZlL4gVkfEOIALKk7t7JJrO2r6ifpue5MALhDKxz270
 QeKAEhH+bmR8tFtqNSQ3PKKtYakFed6D3F2JWiD4ObkLzTe80qi3ZREDLSCcwfCWT6m466lf
 +hUka3xaaVVgFZQvoNgOL931qZitcD3rrpXwwk4TnXGa1OnVuFpLnWchJQds6RMwvlSuBesW
 1LJ8d5fYO3bNMTgGV8XBQwkcuXciq1ExmiMtaw4cBfg+St63LubSkEDbRCDhRtUIKZxLI54k
 /wqv9Qb6lDnhxcnWjpcYvu4K4hYwqQ8bpga
IronPort-HdrOrdr: A9a23:+qvh+q4VnWVDlRtsnQPXwVuBI+orL9Y04lQ7vn2ZFiY6TiXIra
 +TdaoguSMc6AxwZJkh8erwXpVoZUmsiKKdhrNhQYtKPTOWwldASbsC0WKM+UyEJ8STzJ846U
 4kSdkANDSSNykLsS+Z2njBLz9I+rDum8rE9ISurQYfcegpUdAa0+4QMHfrLqQcfng+OXNWLu
 v62iIRzADQB0j/I/7LSkUtbqzmnZnmhZjmaRkJC1oO7xSPtyqh7PrfHwKD1hkTfjtTyfN6mF
 K13TDR1+GGibWW2xXc32jc49B/n8bg8MJKAIiphtIOIjvhpw60bMBKWqGEvhoyvOazgWxa3+
 XkklMFBYBe+nnRdma6rV/E3BTh6i8n7zvYxVqRkRLY0IfEbQN/L/AEqZNScxPf5UZllsp7yr
 h302WQsIcSJQ/cnQzmjuK4FC1Cpw6Rmz4PgOQTh3tQXc81c7lKt7ES+0tTDdMpAD/60oY6C+
 NjZfuspMq+SWnqKkwxg1MfhOBFBh8Ib1C7qwk5y42oOgFt7TJEJxBy/r1Yop8CnKhNA6Wsqd
 60a5iBOdl1P7grhJlGdZI8qP2MeyXwqCL3QRCvyGvcZdU60lL22tTKCeYOlayXkKJh9upFpH
 2GaiIBiVIP
X-IronPort-AV: E=Sophos;i="5.87,172,1631592000"; 
   d="scan'208";a="57732291"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=GfwVvv0QDFLxpdU4xvE7CqRJBp5immZ8H4bTJ/RmATsg0tK0Hf4frww3jA+npoV8SDBY64fxDuAzacffw7HU5JNSTalHwGC3AsiNdI9K24lypagSEsGqhCxXg6ksv7IAA36qJ8rox7K/jC7NtZdz/Thh1XcLwBEfPWi1B+Ogi0mG5qoJRHcaWchp3TGucFGlkdAOR450EckNqW8h04kIPS5tYpMS/S+aJFpUu/TW6xC+WWAsadKOnXSCVZ/LcBIj0AOX7F5H/DvUoU2SM3V9Vwf7z3/PTgNqG+NeyiRR6a/J+V8I3ZlF7Uk7fJwA576zks3u9r23kqVYRtH1WFdJHQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=uoLmi8XjwYvIvNTlR2B7wn3vi07buVRKBWgAwmIbhNM=;
 b=nKchj5prBJ2W/gJRA2aYc1oSSK7uPav607h99tR/ohufGd+7MnqoA0CKfod7yehGutmTDpiRi8oOc988XsRkZb0OTEA1HpxDOpFGCBVdITCVDNg4I9jiUjpE0nfMwqQk8BQ2bW+wUPUWieEwT6EPJF0sMehN9CFyVNH4ZUKcE78a08J93gli2fHC8LYCh1VRzeN4zH5ZdyvnLjhvSDE0VwhkEv2kKz++KZ7jW6yVOvycooGY2XtZkcWO4KJp7dBYwVzugkMvI4BllIjmXvq6/bCapYHeQ0xAQwngG+hqvm93dLhMKA7w0wLmwtE7kov8wWXN+dEcb+IpuraVkcG3bQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=uoLmi8XjwYvIvNTlR2B7wn3vi07buVRKBWgAwmIbhNM=;
 b=uwIe+9aLh7O8eje4/OdKqT6PeQLJHlOVW5tWWIUVHY9HhwQrnKl4biHYK37oqCKeFh+uWuaPL/SmjCM2Qxs9Qaz8/StMyj4wHsnzEwvInYO4N+xnG3/Wv3L4tUDm994VMlYRpwuT6B9pm3V2DFZifWNbB46AlAVhpaTd0KAOknw=
Date: Fri, 22 Oct 2021 12:30:46 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, "Andrew
 Cooper" <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH v4 4/6] x86/HVM: also dump stacks from
 show_execution_state()
Message-ID: <YXKS1p1h37mF9cdL@MacBook-Air-de-Roger.local>
References: <cbdc93a6-e675-420c-f7e8-53aa407766ba@suse.com>
 <db023918-618a-d19f-e600-ee0a683a01af@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <db023918-618a-d19f-e600-ee0a683a01af@suse.com>
X-ClientProxiedBy: LO4P123CA0174.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:18a::17) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: b56774e6-e2d8-47fb-8edc-08d995470487
X-MS-TrafficTypeDiagnostic: DM5PR03MB3146:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <DM5PR03MB3146CFE2380D5DEDD92104708F809@DM5PR03MB3146.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6790;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: xjYBY6BIs8JMys9dZq5acb/+hbbmo6Enh1qjlcN1eZI/2Oay5b3bIuSucdHiJgEdz5vdMbegPJ+2vvebv76onLoQg+5PpmXxUpVJIF5j+I6JxwT7ADo2AwuIaoMWTHf4fxV0uZ/sEzhOHYV9poU1pJHmjtJaJbplGChmdZBOd6kRXFQVlWKfxtArXKYSxHV8YysEJona2oQMxFJ9WI3/W68z0xZCUPG8ji0dhG5yK769zetVH6i0DEQ1nDTspAjDFQ8olNTS4DxbBTwLS6Gf7l2Jl3lh+IN56vhR0mIXKH3779mrKySwAUiYs/SU4YSBlH8LuAVRma50uYSM1nXJj+76Wbt0MSHy518ncpC2E+fTOYaEgOTgjL1fst3sSDQ51hHYgLkwmrg8oPhnj1thp1k47kSx1OvvdiwwIbPg5SwAIEvMJfl/nQmlgLf8GLhKeiUz3nJ6+NhJcpU9Rd/szHN6AB7pi4nrtISCmij8aBHqGxDs0h37vGuofrrWo3HvWkemp1dqZxp9BztK3ULcsLwOTqtsYeVJ9gmpaJn5FQa6jPyJigbOsrzHzNXtiw1kib67MZkWpvFiscC2Ilv1rOTsDefuIviXeWxZ2NIQVqCyTC5TnneFWDtgvnVMtMtYO5+Ry81QsBFbUFolDbFZ4A==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(54906003)(316002)(86362001)(38100700002)(2906002)(4326008)(6916009)(4744005)(85182001)(8676002)(8936002)(82960400001)(956004)(66946007)(66556008)(5660300002)(508600001)(6496006)(83380400001)(6666004)(6486002)(26005)(66476007)(9686003)(186003);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q2pIUXpzUnRMSTg2aGJRdm9ISE5mQ3hLbEwza3EyNkczWkkxdHpJWUZNaU9v?=
 =?utf-8?B?N1dvdU12NTNIOHk1NjJOLzM2V05qNmxqL0xZbTNZMDgyUlU0MkZSeC9Eb1Nl?=
 =?utf-8?B?N1ZVbXg5UWhraHoyc1VpRFphZ2hIOFlGN2Q5aVlaaG1Bb0g5R04rc0pwRXgy?=
 =?utf-8?B?dng4Zm5zS1FzRmphcHNMbDh6MVd0VFpidk10Sy93YmdjcUtVSHZZRVRMQTE4?=
 =?utf-8?B?bm1hN0pFWk5tUTZTWVd5b0hjdktmZElUbUUrY2QzalNyYmdPcTYvWVFGWStu?=
 =?utf-8?B?WWMyd081d243aE1abEdBNTdCMDAvWVF0bHg1anVyVGJPMy9PZmFLRWlZOUZP?=
 =?utf-8?B?T1BzR1paQlB6amtCdnV3NnhGcktyQ09CYXErSVRQRkNQY3BBSzdTbjQ3cURO?=
 =?utf-8?B?TW9OTGZHT1JtMng5NHRUbWRSanZ5MGozMHpmOU04UStEdVNjZkR5akxVQ1pa?=
 =?utf-8?B?V2QrRFN3Sy9VaS9hS2dPQlVOQnU2c3ZPdzJSL2ptc21Ea2h2MjI2MTAvYjV3?=
 =?utf-8?B?S2R1YjIxandFV3VIRkpuMExsUG0xMkN5Nm5sQmFTenM0UU1hUWlmWFNod3dI?=
 =?utf-8?B?TDlKNTFTV0d0L0gvbVNqQUtOdEd5WmhqaXRCQUxPdXB0SlFlNTgyL0MwMS9H?=
 =?utf-8?B?UkVwSUp5ZXRKR2JRWUdHYm5VYmV4OFp0MHlxOXZXMldJTW1uZkY0WmR0VDg5?=
 =?utf-8?B?MkZsbFk4Y2RtbW5XT2RZc0RncU40ampsYkNEYlg0NFBsb21vVE4yNTBxeS9Y?=
 =?utf-8?B?ek0wNk42R213VzB3Z1dlcjhCakFuTzRqUVM3N1k3L3ZjUEp5VXdsWXcxZENl?=
 =?utf-8?B?dE52TCt5VUwwVTFRSWh1Z0VuL0doM1lkR25MR0VPMlFUNGJmSHNXK3VNRk5Q?=
 =?utf-8?B?NHBnaE5acDA3b21DTTl5MFA4bW5pRnd5NkJ2Yk5RQjhDNUR5RStKOHBSQzc0?=
 =?utf-8?B?aG5CWjExT05jaUdTaXNCQlJtMllmSksyUzhaZXQwUnlDSjFITDRoRHdQNzdw?=
 =?utf-8?B?QmhFbjc1eWtzS0VoanRLMU5QdzNBMEI5NUlMZUFzWWJRZDBSR2tvTlJmYU9l?=
 =?utf-8?B?R3dTSnh2aTlqbFNkdW5XRFlvS3J2eTZNTHZDL2lZeEVmRnB3NzIyV0RLQWdQ?=
 =?utf-8?B?bTJibWZYSzBkUENMNUFRYklMaUVrTENvUzVxYm9FWC9rV2pQeU1wbjVIRUE2?=
 =?utf-8?B?dXpuaXBydVg4VmZYb0lHVytDRm5zTmVZZnNRV01xbXUvYm5adllvMXloZnow?=
 =?utf-8?B?dHRDSG5OVEpYVTRyd0dkR0ZpRFB1L2F1KzlXYklwVHBTYU9qOGk0OHhxb0RF?=
 =?utf-8?B?Mm1mczlxREpKNytGUXJDSXY3QXN4Y1UvanpmT2pRajR2Wmd4bmhOL1lzd3BQ?=
 =?utf-8?B?Mk1VUkpuUlVjNHY2SXVSV0h0M1NJWmtSd1poOW5UNTZxeEFYdlhRTmJKWlRL?=
 =?utf-8?B?bWFJUlRiejgvY3A5ZnpvNVN1QzE4TmtOc2dObHExajNkbGRpdHZnRTRQeUlo?=
 =?utf-8?B?MjFaSUtDU2JVZWlTU25YYW9jWklQQTFFQ2ZnUDN6ekxhVmhmWjVPYVU1L2RO?=
 =?utf-8?B?VHZwZ0dCemVpeDFSUFdGNkE1ZGlkK3dJZGdONEhZSHlIT2pjSmNhMUJGbTVa?=
 =?utf-8?B?TFZJQk1tTE95b1Btd3llN1B6aXFiZFRlSEJvRFB2bktWRXlHZjViV0Zra1VK?=
 =?utf-8?B?OTh2Uk83YU5XRlhRd0YrYXpQeDNaYzhSUzJyaGlQU0lLYndFMDY5VDlSY3My?=
 =?utf-8?Q?vihL+q9C2+DK4KeV9cBrMPws482WvDt3C+70x7X?=
X-MS-Exchange-CrossTenant-Network-Message-Id: b56774e6-e2d8-47fb-8edc-08d995470487
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Oct 2021 10:30:50.2079
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: roger.pau@citrix.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB3146
X-OriginatorOrg: citrix.com

On Wed, Sep 29, 2021 at 03:14:46PM +0200, Jan Beulich wrote:
> Wire up show_hvm_stack() also on this path. Move the show_guest_stack()
> invocation out of show_stack(), rendering dead the is-HVM check there.
> 
> While separating guest and host paths, also move the show_code()
> invocation - the function bails immediately when guest_mode() returns
> "true".
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> ---
> v4: New.
> 
> --- a/xen/arch/x86/traps.c
> +++ b/xen/arch/x86/traps.c
> @@ -303,10 +303,6 @@ static void show_guest_stack(struct vcpu
>      unsigned long mask = STACK_SIZE;
>      void *stack_page = NULL;
>  
> -    /* Avoid HVM as we don't know what the stack looks like. */
> -    if ( is_hvm_vcpu(v) )
> -        return;

Might be good to keep it as an ASSERT_UNREACHABLE now.

Regardless:

Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Fri Oct 22 10:48:12 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Oct 2021 10:48:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.214948.373822 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mds5o-000645-Jt; Fri, 22 Oct 2021 10:48:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 214948.373822; Fri, 22 Oct 2021 10:48:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mds5o-00063y-Gl; Fri, 22 Oct 2021 10:48:08 +0000
Received: by outflank-mailman (input) for mailman id 214948;
 Fri, 22 Oct 2021 10:48:07 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=h+2b=PK=citrix.com=lin.liu@srs-us1.protection.inumbo.net>)
 id 1mds5n-00063m-5r
 for xen-devel@lists.xenproject.org; Fri, 22 Oct 2021 10:48:07 +0000
Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 21454dcd-711d-45f6-b2d1-d1b3b29a4406;
 Fri, 22 Oct 2021 10:48:05 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 21454dcd-711d-45f6-b2d1-d1b3b29a4406
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1634899685;
  h=from:to:cc:subject:date:message-id:mime-version:
   content-transfer-encoding;
  bh=YF8TpPaAdoSQu2GCGdxKA8fc3NP57BlDMOKMVMon5SA=;
  b=SRPYZcH8DZ2BgpR4sxy3ugOO5jQ08YDStc/RDJYlFNBZWw800VpEDiMc
   S/gjj9S+Ka9+ZpuCN6luVHxxviYBzE6Pce135efTGdfTZbZg85ttui871
   6G0IrfovZHrlYR+B7oqLETWDue+vHQAJmdRuW/nz7EHxix89/MFjb28jo
   M=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: Fx7NTsVq5WQr3Y2Q0sk06Jet0f+0FOvd65lKHSqNX5FBe4kBmI/llBnQFjK27SXTwH0WqmRz/w
 3eUTQ7JN3H4FS4yhsQYcHixbLDaYNgBInv/6vOpzvxjneYK2k8hr27zYB/8yZLdahAON4ugzDa
 VQNwsPIlSfk8hVY1I8Yz9EPRS5rg3I2PNXsSPw/cVUfQAiBzhfTH0BYHQPOjcAhXd4cXarkSgH
 HwpoTbVLSGDFk16t/hQtrJQX50uKvyaiZTDTH2HSu9xeBgA3hDlhCAU9qHV5c5cir4a5+xaVZ9
 yrwcEa6EPmqXv0pyO6a5fcop
X-SBRS: 5.1
X-MesageID: 55376142
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:1hiUSqM7bU9zSEHvrR3KkcFynXyQoLVcMsEvi/4bfWQNrUpz12ACy
 GtKUG7Vbv7YZ2r1KNwna9mw90tQ6pDWy4NgHgto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdpJYz/uUGuCJQUNUjMlkfZKhTr6bUsxNbVU8En540Ug5w7RRbrNA2rBVPSvc4
 bsenOWHULOV82Yc3rU8sv/rRLtH5ZweiRtA1rAMTakjUGz2zhH5OKk3N6CpR0YUd6EPdgKMq
 0Qv+5nilo/R109F5tpICd8XeGVSKlLZFVDmZna7x8FOK/WNz8A/+v9TCRYSVatYoxaNoPRxz
 dpdib2hcQM2b6HDstwPVzANRkmSPYUekFPGCX22sMjVxEzaaXr8hf5pCSnaP6VBpLwxWzsXs
 6VFdnZdNXhvhMrvqF6/Yu1tgIInLdTDN4IDoHBwizreCJ7KRLieHv6Vu4YEhl/cgOhQAanEZ
 uYQNwNiQwjNYwBCA1Q1MbAxybLAan7XLGQD9QP9SbAMy3PI0AV73bzpMdzUUt+HX8NYmgCfv
 G2u12f+BAsTOJqAyD6G2nW2j+TLkGXwX4d6PIO/8vlmkViC3Fs5ARcdVUa4ifShg0v4UNVaQ
 2QL/gI+oK5081akJvH/Qhm5rXisrhMaHd1KHIUS5A6Bx6XO6i6FF2MESXhHc9Vgu8goLRQ62
 1nMk973CDhHtLyOVWnb5rqStSm1OyUeMSkFfyBsZQcd+NzivIEbhwrCVMp+C7WyisDpGDb22
 HaBqy1Wr7cZgNMP1q671UvamD/qrZ/MJiY0+Qf/Tm+j9hl+ZoOue8qv81ez0BpbBN/HFB/b5
 iFCwpXAqrBVZX2QqMCTaMYJI5Wp4vmVDBzNuVpwTpUu3Qy//1f2KOi8/wpCDEtuN88Ffxrgb
 0nSpR5d6fdvAZe6UUNkS9nuU5pynMAMAfygD6qONoMfPfCdYSfepHk2DXN8yVwBh6TFfUsXA
 pycbdq3RUgTDaBq3VJarM9MjOd1mEjSKY7VLK0XLihLM5LCOxZ5qp9faTNii9zVCove/G05F
 P4Eb6O3J+13CrGWX8Uu2dd7wao2BXY6H4vqjMdca/SOJAFrcEl4VaSNke94JNw9xPkE/gstw
 p1bchUEoLYYrSafQThml1g5MO+/NXqBhSJT0dMQ0aaAhCF4PNfHAFY3fJorZ7g3nNGPPtYvJ
 8Tpj/6oW6wVIhyeomx1RcCk8ORKKUT67SrTbnHNSGVuIPZdq/nhp4aMkv3Hr3JVUEJadKIW/
 tWd6+8sacNSHlo4VJ+LMK7HIpHYlSF1pd+elnDgerF7EHgAOqAzQ8AopvNoccwKNzvZwT6Wi
 1SfDRsC/LGfqI4p6tjZw6uDqt7xQed5G0NbGUjd7Kq3anaGrjbyn9cYXbbaZy3ZWUP15L6mO
 bdfwcbjPaBVh11NqYd9TepmlPps+9v1qrZG5Q14B3GXPU+zA7ZtLyDej8lCv6FA3JFDvg6yV
 h7d89VWI+zRasjkDEQQNEwuaeHajaMYnTzb7PIUJkTm5XAooOrbABsKZxTV0X5TNrp4No8h0
 NwNgs9O5lztkAcuP/aHkjtQqzaGIEsfXvh1rZodGoLq1FYmkwkQfZzGBybqy5iTcNEQYFIyK
 zqZiaee1bRRwk3OLyg6GXTXhLcPgJ0PvFZBzUMYJkTPkd3A36dl0BpU+DUxbwJU0hQYjL4jZ
 jk1bxV4dfeU4jNlpMlfRGT9SQhOCSqQ9lH111ZUxnbSSFOlVzCVIWAwUQpXEJv1L46IkuBnw
 Yyl
IronPort-HdrOrdr: A9a23:K087u6qLDI6xqR7B7gn+Fj4aV5oneYIsimQD101hICG8cqSj+f
 xG+85rsiMc6QxhPE3I9urhBEDtex/hHP1OkOws1NWZLWrbUQKTRekIh+bfKlXbakvDH4VmtJ
 uIHZIQNDSJNykZsfrH
X-IronPort-AV: E=Sophos;i="5.87,172,1631592000"; 
   d="scan'208";a="55376142"
From: Lin Liu <lin.liu@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Lin Liu <lin.liu@citrix.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
	Daniel De Graaf <dgdegra@tycho.nsa.gov>, "Daniel P. Smith"
	<dpsmith@apertussolutions.com>, George Dunlap <george.dunlap@citrix.com>,
	"Ian Jackson" <iwj@xenproject.org>, Jan Beulich <jbeulich@suse.com>, Julien
 Grall <julien@xen.org>, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>, Ross Lagerwall
	<ross.lagerwall@citrix.com>, Stefano Stabellini <sstabellini@kernel.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, Wei Liu <wl@xen.org>
Subject: [PATCH v2 0/7] Implement byteswap and update references
Date: Fri, 22 Oct 2021 10:47:21 +0000
Message-ID: <cover.1634897942.git.lin.liu@citrix.com>
X-Mailer: git-send-email 2.27.0
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit


The swab() is massively over complicated
Simplify it with compiler builtins and fallback to plain C function
if undefined.
Update components to switch to this new swap bytes.

Lin Liu (7):
  xen: implement byteswap.h
  crypto/vmac: Simplify code with byteswap.h
  arm64/find_next_bit: Remove ext2_swab()
  arm: Switch to byteswap.h
  xen/xsm: Switch to byteswap.h
  xen: Switch to byteswap.h
  byteorder: Remove byteorder

 xen/arch/arm/alternative.c                |   2 +-
 xen/arch/arm/arm64/lib/find_next_bit.c    |  40 +----
 xen/arch/arm/arm64/livepatch.c            |   2 +-
 xen/arch/arm/kernel.c                     |   2 +-
 xen/arch/arm/vgic/vgic-mmio.c             |   2 +-
 xen/common/bitmap.c                       |   2 +-
 xen/common/gdbstub.c                      |   2 +-
 xen/common/libelf/libelf-private.h        |   8 +-
 xen/common/lz4/defs.h                     |   2 +-
 xen/common/lzo.c                          |   2 +-
 xen/common/unlzo.c                        |   2 +-
 xen/common/xz/private.h                   |   4 +-
 xen/crypto/vmac.c                         |  76 +--------
 xen/drivers/char/ehci-dbgp.c              |   2 +-
 xen/include/asm-arm/arm32/io.h            |   2 +-
 xen/include/asm-arm/arm64/io.h            |   2 +-
 xen/include/asm-arm/byteorder.h           |  16 --
 xen/include/asm-x86/byteorder.h           |  36 -----
 xen/include/asm-x86/msi.h                 |   2 +-
 xen/include/xen/bitmap.h                  |   2 +-
 xen/include/xen/byteorder/big_endian.h    | 102 ------------
 xen/include/xen/byteorder/generic.h       |  68 --------
 xen/include/xen/byteorder/little_endian.h | 102 ------------
 xen/include/xen/byteorder/swab.h          | 183 ----------------------
 xen/include/xen/byteswap.h                |  93 +++++++++++
 xen/include/xen/compiler.h                |  12 ++
 xen/include/xen/device_tree.h             |   2 +-
 xen/include/xen/libfdt/libfdt_env.h       |   2 +-
 xen/include/xen/unaligned.h               |  14 +-
 xen/lib/divmod.c                          |   2 +-
 xen/xsm/flask/ss/avtab.c                  |   2 +-
 xen/xsm/flask/ss/conditional.c            |   2 +-
 xen/xsm/flask/ss/ebitmap.c                |   2 +-
 xen/xsm/flask/ss/policydb.c               |   2 +-
 34 files changed, 150 insertions(+), 646 deletions(-)
 delete mode 100644 xen/include/asm-arm/byteorder.h
 delete mode 100644 xen/include/asm-x86/byteorder.h
 delete mode 100644 xen/include/xen/byteorder/big_endian.h
 delete mode 100644 xen/include/xen/byteorder/generic.h
 delete mode 100644 xen/include/xen/byteorder/little_endian.h
 delete mode 100644 xen/include/xen/byteorder/swab.h
 create mode 100644 xen/include/xen/byteswap.h

-- 
2.27.0



From xen-devel-bounces@lists.xenproject.org Fri Oct 22 10:48:12 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Oct 2021 10:48:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.214949.373828 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mds5o-00067a-V0; Fri, 22 Oct 2021 10:48:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 214949.373828; Fri, 22 Oct 2021 10:48:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mds5o-000672-P4; Fri, 22 Oct 2021 10:48:08 +0000
Received: by outflank-mailman (input) for mailman id 214949;
 Fri, 22 Oct 2021 10:48:07 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=h+2b=PK=citrix.com=lin.liu@srs-us1.protection.inumbo.net>)
 id 1mds5n-00063s-Ot
 for xen-devel@lists.xenproject.org; Fri, 22 Oct 2021 10:48:07 +0000
Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 899cacfa-3325-11ec-83b2-12813bfff9fa;
 Fri, 22 Oct 2021 10:48:06 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 899cacfa-3325-11ec-83b2-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1634899686;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=IFE0UJWngehF/A2SEsMzjIMw1cebKLctc7j7VVKm2kg=;
  b=DYDcyYc2cqpGUHTxjTE64aII/dVtmZZvJfdO814hzVxBmtIrZIXti2ht
   h7sLs9lHr4po4BlJ4HNgnW7yfTb28HlQ/4pc5e+WiqjWERIR4p1x5UXU/
   JkI6VtslI/kJjMk5UJANpf/r67ZejCG/uYWmCA8Zq9DOn1WdA9GIRM+Qy
   s=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: 9ODWXCtlXJsgGAcpdr47VuOgrNDlPEua4piplJW1s+UBl/uFlNhmUT04tLNIP0bkikNn7t5Hmt
 4gjBemsZz5YwqZs+MV3N+qbVlE7KNlcga3fIwiA/LmmCdwUVAQtshXMHFR/9jTCKEKOngq9zj0
 +kQAsiW/SEmaInkPqRIWCiPmzfjqxzYVjiozt8hqofY1qpjMBaXQi/7dLsMOnt/PjrCsCYCuJU
 qCM0mNQNOlXATNqHUPSzpZGv+DW05yM1JTgTEu3NJlqtdwzl9Vyd8Yv2Fi+CvDIq0/+2jbSFT1
 sSITJLNRVutURWfvnG5j84wI
X-SBRS: 5.1
X-MesageID: 55807250
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:sA+ND6AXIj/COxVW/63kw5YqxClBgxIJ4kV8jS/XYbTApD120jUFn
 zNNCmyFa/yJNmrxe91yb9m3/R4HsZWHnYI3QQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA
 xA2M4GYRCwMo/u1Si6FatANl1ElvU2zbue6WLGs1hxZH1c+EX5500g7wYbVv6Yz6TSHK1LV0
 T/Ni5W31G+Ng1aY5UpNtspvADs21BjDkGtwUm4WPJinj3eH/5UhN7oNJLnZEpfNatI88thW5
 Qr05OrREmvxp3/BAz4++1rxWhVirrX6ZWBihpfKMkQLb9crSiEai84G2PQghUh/m3LKgu1N5
 Ot3s4WSFzkXYJ3clac9akwNe81+FfUuFL7vJHG+tYqYzlHccmuqyPJrZK00FdRGoKAtWzgIr
 KFGbmBWBvyAr7veLLaTTuhqwMAiMeHgPZ8Fu2EmxjbcZRojac2eE/2Vv4IAtNs2rpBVAez8O
 88dUgtiLznyeAUMPXc6LqtryY9EgVGgKmYF+Tp5v5Ef+HPPxQZ81LzsNtv9edGQQ8hR2EGCq
 Qru/Xn9AxwcHMySz3yC6H3ErvDLtTP2XsQVDrLQ3u5nhhify3IeDDUSVECnur+ph0imQdVdJ
 kcIvC00osAa9VOpZsnwWQWip3yJtQJaXMBfe8U44gyQzqvf4y6CG3MJCDVGbbQbWNQeHGJwk
 AXTxpWwWGIp4Ob9pW+hGqm8vXTxJBUpAVE4YzYmEzU7venzrcITt0eaJjp8K5KdgtrwEDD25
 jmFqikimrke5fI2O7WHEUPv2G30+MCYJuIhzkCOBDj9t1ImDGKwT9XwsQCz0BpWEGqOorBtV
 lA/kM+C8PtGM5iJkCGcKAnmNOD0v6jbWNEwbFgGInXAy9hP0yL8FWyzyGsnTKuMDiriUWW1C
 KM0kVgJjKK/xFPwMcdKj3uZUqzGN5TIG9X/TezzZdFTeJV3fwLv1HgwPhLAgzmywBB3zPBX1
 XKnnSCEVypy5UNPl2Leegvg+eVzmnBWKZ37FfgXMChLIZLBPSXIGN/pwXOFb/wj7bPsnekm2
 403Cid+8D0GCLeWSnCOqeY7dAlWRVBmVcGeg5EGLYarf1s5cFzN/teMmNvNjaQ+xP8L/goJl
 1ngMnJlJK3X3Cyed1/SMy07NNsCn/9X9BoGAMDlBn7ws1BLXGplxP53m0IfceZ1+ep94+RzS
 vVZKcyMDu4WEmbM+igHbIm7p4tnLUz5iQWLNiujQT4+Y58/GFCZpo66JlPipHsUEy66lcoiu
 Ln8hAnVdoUOGlZ5B8HMZfPxk17o5SoBmPh/VlfjK8VIfBm+65BjLiH816dlI8wFJRjZ6CGd0
 gKaXUURqeXX+tdn+9jVn6GU6YyuFrImTEZdGmDa65ewNDXboTX/kdMRDr7QcGmEBm3u+aika
 eFE9N3GMaUKzARQro5xM7d31qZitdHhkKBXk1Z/F3LRYlX1Vr45eiua3dNCv7Fmz6NCvVfkQ
 VqG/9RXNOnbOM7hF1JNdgMpYv7aiKMRkzjWq/80PF/79Gl8+7/eCRdeOByFiSp8KrppMdx6n
 bd96ZBOswHv2AA3NtumjzxP8zXeJ3MNZKwrq5UGDdK5kQEs0FxDPcTRByKeDEtjsDmQ3p3G+
 gOpuZc=
IronPort-HdrOrdr: A9a23:lQQukavz14qfGMCrNNHCFY4O7skDTtV00zEX/kB9WHVpmszxra
 6TdZMgpHnJYVcqKQkdcL+7WJVoLUmxyXcx2/h1AV7AZniAhILLFvAA0WKK+VSJcEeSygce79
 YFT0EXMqyIMbEQt6fHCWeDfOrIuOP3kpyVuQ==
X-IronPort-AV: E=Sophos;i="5.87,172,1631592000"; 
   d="scan'208";a="55807250"
From: Lin Liu <lin.liu@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Lin Liu <lin.liu@citrix.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
	Jan Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>, "Stefano
 Stabellini" <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
Subject: [PATCH v2 1/7] xen: implement byteswap.h
Date: Fri, 22 Oct 2021 10:47:22 +0000
Message-ID: <89afdafa9020ab77b9d662bd5c8f7b2d31e53c5c.1634897942.git.lin.liu@citrix.com>
X-Mailer: git-send-email 2.27.0
In-Reply-To: <cover.1634897942.git.lin.liu@citrix.com>
References: <cover.1634897942.git.lin.liu@citrix.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

swab() is massively over complicated and can be simplified by builtins.
The compilers provide builtin function to swap bytes.
* gcc:   https://gcc.gnu.org/onlinedocs/gcc/Other-Builtins.html
* clang: https://clang.llvm.org/docs/LanguageExtensions.html
This patch simplify swab() with builtins and fallback for old compilers.

Signed-off-by: Lin Liu <lin.liu@citrix.com>
---
Cc: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: George Dunlap <george.dunlap@citrix.com>
Cc: Ian Jackson <iwj@xenproject.org>
Cc: Jan Beulich <jbeulich@suse.com>
Cc: Julien Grall <julien@xen.org>
Cc: Stefano Stabellini <sstabellini@kernel.org>
Cc: Wei Liu <wl@xen.org>
Changes in v2:
- Add fallback for compilers without __builtin_bswap
- Implement with plain C instead of macros
---
 xen/include/xen/byteswap.h | 93 ++++++++++++++++++++++++++++++++++++++
 xen/include/xen/compiler.h | 12 +++++
 2 files changed, 105 insertions(+)
 create mode 100644 xen/include/xen/byteswap.h

diff --git a/xen/include/xen/byteswap.h b/xen/include/xen/byteswap.h
new file mode 100644
index 0000000000..848a4bbaee
--- /dev/null
+++ b/xen/include/xen/byteswap.h
@@ -0,0 +1,93 @@
+#ifndef _BYTESWAP_H
+#define _BYTESWAP_H
+
+#include <xen/types.h>
+
+#if !__has_builtin(__builtin_bswap16)
+static always_inline uint16_t __builtin_bswap16(uint16_t val)
+{
+    return ((val & 0x00FF) << 8) | ((val & 0xFF00) >> 8);
+}
+#endif
+
+#if !__has_builtin(__builtin_bswap32)
+static always_inline uint32_t __builtin_bswap32(uint32_t val)
+{
+    return ((val & 0x000000FF) << 24) |
+           ((val & 0x0000FF00) <<  8) |
+           ((val & 0x00FF0000) >>  8) |
+           ((val & 0xFF000000) >> 24);
+}
+#endif
+
+#if !__has_builtin(__builtin_bswap64)
+static always_inline uint64_t __builtin_bswap64(uint64_t val)
+{
+    return ((val & 0x00000000000000FF) << 56) |
+           ((val & 0x000000000000FF00) << 40) |
+           ((val & 0x0000000000FF0000) << 24) |
+           ((val & 0x00000000FF000000) <<  8) |
+           ((val & 0x000000FF00000000) >>  8) |
+           ((val & 0x0000FF0000000000) >> 24) |
+           ((val & 0x00FF000000000000) >> 40) |
+           ((val & 0xFF00000000000000) >> 56);
+}
+#endif
+
+#define bswap16(x) __builtin_bswap16(x)
+#define bswap32(x) __builtin_bswap32(x)
+#define bswap64(x) __builtin_bswap64(x)
+
+#define bswap_ul(x) bswap##BITS_PER_LONG(x)
+
+#if __BYTE_ORDER__ == __ORDER_LITTLE_ENDIAN__
+
+#  ifndef __LITTLE_ENDIAN
+#    define __LITTLE_ENDIAN 1234
+#  endif
+
+#  ifndef __LITTLE_ENDIAN_BITFIELD
+#    define __LITTLE_ENDIAN_BITFIELD
+#  endif
+
+#  define cpu_to_le64(x) (x)
+#  define le64_to_cpu(x) (x)
+#  define cpu_to_le32(x) (x)
+#  define le32_to_cpu(x) (x)
+#  define cpu_to_le16(x) (x)
+#  define le16_to_cpu(x) (x)
+#  define cpu_to_be64(x) bswap64(x)
+#  define be64_to_cpu(x) bswap64(x)
+#  define cpu_to_be32(x) bswap32(x)
+#  define be32_to_cpu(x) bswap32(x)
+#  define cpu_to_be16(x) bswap16(x)
+#  define be16_to_cpu(x) bswap16(x)
+
+#elif __BYTE_ORDER__ == __ORDER_BIG_ENDIAN__
+
+#  ifndef __BIG_ENDIAN
+#    define __BIG_ENDIAN 4321
+#  endif
+
+#  ifndef __BIG_ENDIAN_BITFIELD
+#    define __BIG_ENDIAN_BITFIELD
+#  endif
+
+#  define cpu_to_le64(x) bswap64(x)
+#  define le64_to_cpu(x) bswap64(x)
+#  define cpu_to_le32(x) bswap32(x)
+#  define le32_to_cpu(x) bswap32(x)
+#  define cpu_to_le16(x) bswap16(x)
+#  define le16_to_cpu(x) bswap16(x)
+#  define cpu_to_be64(x) (x)
+#  define be64_to_cpu(x) (x)
+#  define cpu_to_be32(x) (x)
+#  define be32_to_cpu(x) (x)
+#  define cpu_to_be16(x) (x)
+#  define be16_to_cpu(x) (x)
+
+#else
+#  error "Unknown Endianness"
+#endif /* __BYTE_ORDER__ */
+
+#endif /* _LINUX_BITOPS_H */
diff --git a/xen/include/xen/compiler.h b/xen/include/xen/compiler.h
index 696c7eb89e..68f28082a5 100644
--- a/xen/include/xen/compiler.h
+++ b/xen/include/xen/compiler.h
@@ -179,4 +179,16 @@
 # define CLANG_DISABLE_WARN_GCC_COMPAT_END
 #endif
 
+#if (!defined(__clang__) && (__GNUC__ < 10))
+/*
+ * Backwards compatibility for GCC < 10.
+ * All supported versions of Clang support __has_builtin
+ * */
+#define __has_builtin(x) GCC_has ## x
+
+#define GCC_has__builtin_bswap16 (CONFIG_GCC_VERSION >= 40800)
+#define GCC_has__builtin_bswap32 (CONFIG_GCC_VERSION >= 40400)
+#define GCC_has__builtin_bswap64 (CONFIG_GCC_VERSION >= 40400)
+#endif
+
 #endif /* __LINUX_COMPILER_H */
-- 
2.27.0



From xen-devel-bounces@lists.xenproject.org Fri Oct 22 10:48:14 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Oct 2021 10:48:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.214950.373844 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mds5u-0006d3-59; Fri, 22 Oct 2021 10:48:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 214950.373844; Fri, 22 Oct 2021 10:48:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mds5u-0006cp-1Z; Fri, 22 Oct 2021 10:48:14 +0000
Received: by outflank-mailman (input) for mailman id 214950;
 Fri, 22 Oct 2021 10:48:11 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=h+2b=PK=citrix.com=lin.liu@srs-us1.protection.inumbo.net>)
 id 1mds5r-00063m-SC
 for xen-devel@lists.xenproject.org; Fri, 22 Oct 2021 10:48:11 +0000
Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 3dd4d950-1f2d-4743-9f3c-a27dcd40da0c;
 Fri, 22 Oct 2021 10:48:05 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3dd4d950-1f2d-4743-9f3c-a27dcd40da0c
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1634899685;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=vWYcScFFcIQEVZP3kMCIm4XAsFx3uk4EAC/JiEqA390=;
  b=QGkYz30joJGyvg1l0BRFy0aI79YAFLix6L+giFTfhjG3RHjt2er4r8lc
   kMkgOQ/mjO5PxQFvzvXzT9djVIHme611uBuF1XlmWosPJHkXVE/AWaC0E
   +Ml8ku+hGiI4RdNP4b+XkwhXmKXnAzbK8a6WLBXX7blO6AuLvAGu7Sxe5
   Q=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: MPfO+Wji9x93Dsji5f9qlta4Pv88cGaAAS+EM5FZXGK2iKhRqVvC1tjrQlIDzCZdwt7rEWuha8
 VLZjVNlhz8R9lxhIlP6hHMcQJWAfBqjVG2H9qc2JXm6WuYzCPXoZ0jBkItPp6PdnRysJNaRXIO
 uY8+KsuQEhQXBzQZESCDFsSqNqoIy/1pRSXZL/wYAba0H/zII1tu7UlSxr8p4sG6I0MOg1dGEK
 DLweIuVPdpwxyXssPDPNpBtpQ/44BpyDpVSMysQjUwytKkZ79TYHXEatLB+dulc5XFifIfMm4M
 6dfINCFFVd7YQzDPDREwpuse
X-SBRS: 5.1
X-MesageID: 57733154
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:kdxOaavWtra2khdHMvlh0CH/wufnVNFZMUV32f8akzHdYApBsoF/q
 tZmKTqDO63fMGb2co91aoS//UNXvJDVmNBnSQs4pCBmEn8S+JbJXdiXEBz9bniYRiHhoOOLz
 Cm8hv3odp1coqr0/0/1WlTZQP0VOZigHtIQMsadUsxKbVIiGHhJZS5LwbZj29cw24LhWWthh
 PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe
 gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ
 NplqayOEAhyMob2ydssdABXUGZXZaJ09+qSSZS/mZT7I0zudnLtx7NlDV0sPJ1e8eFyaY1M3
 aVGcnZXNEnF3r/ohuLgIgVvrp1LwM3DOIIZ/HVh0BnSDOo8QICFSKLPjTNd9Gpv2ZsVRKuCD
 yYfQStpchjbYDJGAH1NIqMEpfjyiEi4bwQN/Tp5ooJoujOOnWSdyoPFDt3RfdCbQNRPqWyRr
 GnG4mfRDwkTMZqUzj/t2nGrgPXGkWXkWYYRPLqi//VujRuYwWl7IB8LUVq2p9Gph0j4XMhQQ
 2QE9yxroaUs+UiDStjmQwb+sHOCpgQbWddbD6s98g7l4rHP/w+TC2wATzhAQN8rrsk7QXotz
 FDhoj/yLWUx6vvPEyvbr+rK62PpUcQIEYMcTTM0c1IKuNXImtAMvzXWQZUkOfa6vNKgTFkc3
 Au2hCQ5grwSi+sC2KO64U3LjlqQm3TZcuImzl6IBjz9v2uVcKbgPtbysQGKsp6sOa7AFgHZ1
 EXojfRy+wzn4XulryeKXPkWVI+g4/KIIVUwanY+QsF/qVxBF5OlFL28AQ2Sxm81ba7omhezO
 Sc/XD+9ArcJYBNGiocsO+qM5zwCl/SIKDgcfqm8giBySpZwbhSb2ypleFSd2Wvg+GB1z/pja
 cvCLpb0VitLYUiC8NZQb71BuVPM7ntmrV4/uLihl0j3uVZgTC79pUg53KumMblisfLsTPT9+
 NdDLcqaoyizo8WlChQ7BbU7dAhQRVBiXMieg5UOKoarf1o3cEl8WqS56e5wJORYc1F9y76gE
 oeVARQDljISRBTvdG23V5yUQOq+BMgl9StmZXBE0JTB8yFLXLtDJZw3L/MfFYTLPsQ6pRKtZ
 /VaKciGHNpVTTHLp2YUYZXn9dQwfxW3nwOeeSGiZWFnLZJnQgXI/P7ifxfuq3ZSXnbm65Nmr
 u3yzB7fTLoCWx9mUJTcZsWwwg7jpnMagu9zARfFe4EBZEX2/YF2ACXtlftrcdoUIBDOy2LCh
 QabCBsVv8fXpIox/IWbjKyItd7xQeB/AlBbDy/Q6rPvbXvW+W+qwIlhVueUfG+CCDOoqfv6P
 egMlqPyKvwKmlpOorFQKbczwPJs/cbrqp9b0h9gQCfBYWO0B+4yOXKBx8RO6PFAn+cLpQusV
 0uT0dBGIrHVatj9GVscKQd5POSO0fYYxmvb4fgveRio4SZ2+PyMUFlIPgnKgytYdeMnPIQgy
 OYnmcgX9w3g1UZ6bofY1nhZpzaWM3gNc6Q7rZVLUobkhz0ixkxGfZGBWDT954uCaokUP0QnS
 tNOaHEuW1iIKpL+TkcO
IronPort-HdrOrdr: A9a23:bcAep6sMtuPLYcOQ20HBTbLS7skDTtV00zEX/kB9WHVpmszxra
 6TdZMgpHnJYVcqKQkdcL+7WJVoLUmxyXcx2/h1AV7AZniAhILLFvAA0WKK+VSJcEeSygce79
 YFT0EXMqyIMbEQt6fHCWeDfOrIuOP3kpyVuQ==
X-IronPort-AV: E=Sophos;i="5.87,172,1631592000"; 
   d="scan'208";a="57733154"
From: Lin Liu <lin.liu@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Lin Liu <lin.liu@citrix.com>, Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Ross Lagerwall <ross.lagerwall@citrix.com>
Subject: [PATCH v2 4/7] arm: Switch to byteswap.h
Date: Fri, 22 Oct 2021 10:47:25 +0000
Message-ID: <306bc005bc3786fcbccc0a0aca3c7b22e50d8c67.1634897942.git.lin.liu@citrix.com>
X-Mailer: git-send-email 2.27.0
In-Reply-To: <cover.1634897942.git.lin.liu@citrix.com>
References: <cover.1634897942.git.lin.liu@citrix.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

Update to use byteswap.h to swap bytes.

No functional change.

Signed-off-by: Lin Liu <lin.liu@citrix.com>
---
Cc: Stefano Stabellini <sstabellini@kernel.org>
Cc: Julien Grall <julien@xen.org>
Cc: Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Ross Lagerwall <ross.lagerwall@citrix.com>
---
 xen/arch/arm/alternative.c          | 2 +-
 xen/arch/arm/arm64/livepatch.c      | 2 +-
 xen/arch/arm/kernel.c               | 2 +-
 xen/arch/arm/vgic/vgic-mmio.c       | 2 +-
 xen/include/asm-arm/arm32/io.h      | 2 +-
 xen/include/asm-arm/arm64/io.h      | 2 +-
 xen/include/xen/libfdt/libfdt_env.h | 2 +-
 7 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/xen/arch/arm/alternative.c b/xen/arch/arm/alternative.c
index 237c4e5642..0f84260ac9 100644
--- a/xen/arch/arm/alternative.c
+++ b/xen/arch/arm/alternative.c
@@ -17,6 +17,7 @@
  * along with this program.  If not, see <http://www.gnu.org/licenses/>.
  */
 
+#include <xen/byteswap.h>
 #include <xen/init.h>
 #include <xen/types.h>
 #include <xen/kernel.h>
@@ -27,7 +28,6 @@
 #include <xen/virtual_region.h>
 #include <asm/alternative.h>
 #include <asm/atomic.h>
-#include <asm/byteorder.h>
 #include <asm/cpufeature.h>
 #include <asm/insn.h>
 #include <asm/page.h>
diff --git a/xen/arch/arm/arm64/livepatch.c b/xen/arch/arm/arm64/livepatch.c
index 6ec8dc60f0..26b5729edf 100644
--- a/xen/arch/arm/arm64/livepatch.c
+++ b/xen/arch/arm/arm64/livepatch.c
@@ -3,6 +3,7 @@
  */
 
 #include <xen/bitops.h>
+#include <xen/byteswap.h>
 #include <xen/errno.h>
 #include <xen/lib.h>
 #include <xen/livepatch_elf.h>
@@ -11,7 +12,6 @@
 #include <xen/vmap.h>
 
 #include <asm/bitops.h>
-#include <asm/byteorder.h>
 #include <asm/insn.h>
 #include <asm/livepatch.h>
 
diff --git a/xen/arch/arm/kernel.c b/xen/arch/arm/kernel.c
index 8f43caa186..e89bb9cef8 100644
--- a/xen/arch/arm/kernel.c
+++ b/xen/arch/arm/kernel.c
@@ -3,6 +3,7 @@
  *
  * Copyright (C) 2011 Citrix Systems, Inc.
  */
+#include <xen/byteswap.h>
 #include <xen/domain_page.h>
 #include <xen/errno.h>
 #include <xen/guest_access.h>
@@ -14,7 +15,6 @@
 #include <xen/sched.h>
 #include <xen/vmap.h>
 
-#include <asm/byteorder.h>
 #include <asm/kernel.h>
 #include <asm/setup.h>
 
diff --git a/xen/arch/arm/vgic/vgic-mmio.c b/xen/arch/arm/vgic/vgic-mmio.c
index 5d935a7301..d9c5066246 100644
--- a/xen/arch/arm/vgic/vgic-mmio.c
+++ b/xen/arch/arm/vgic/vgic-mmio.c
@@ -13,10 +13,10 @@
  */
 
 #include <xen/bitops.h>
+#include <xen/byteswap.h>
 #include <xen/lib.h>
 #include <xen/sched.h>
 #include <asm/new_vgic.h>
-#include <asm/byteorder.h>
 
 #include "vgic.h"
 #include "vgic-mmio.h"
diff --git a/xen/include/asm-arm/arm32/io.h b/xen/include/asm-arm/arm32/io.h
index 73a879e9fb..df8547403c 100644
--- a/xen/include/asm-arm/arm32/io.h
+++ b/xen/include/asm-arm/arm32/io.h
@@ -21,8 +21,8 @@
 #ifndef _ARM_ARM32_IO_H
 #define _ARM_ARM32_IO_H
 
+#include <xen/byteswap.h>
 #include <asm/system.h>
-#include <asm/byteorder.h>
 
 static inline void __raw_writeb(u8 val, volatile void __iomem *addr)
 {
diff --git a/xen/include/asm-arm/arm64/io.h b/xen/include/asm-arm/arm64/io.h
index 30bfc78d9e..db328d9e3c 100644
--- a/xen/include/asm-arm/arm64/io.h
+++ b/xen/include/asm-arm/arm64/io.h
@@ -20,8 +20,8 @@
 #ifndef _ARM_ARM64_IO_H
 #define _ARM_ARM64_IO_H
 
+#include <xen/byteswap.h>
 #include <asm/system.h>
-#include <asm/byteorder.h>
 #include <asm/alternative.h>
 
 /*
diff --git a/xen/include/xen/libfdt/libfdt_env.h b/xen/include/xen/libfdt/libfdt_env.h
index 035bf754d2..f8ea1ea07a 100644
--- a/xen/include/xen/libfdt/libfdt_env.h
+++ b/xen/include/xen/libfdt/libfdt_env.h
@@ -1,9 +1,9 @@
 #ifndef _LIBFDT_ENV_H
 #define _LIBFDT_ENV_H
 
+#include <xen/byteswap.h>
 #include <xen/types.h>
 #include <xen/string.h>
-#include <asm/byteorder.h>
 
 typedef uint16_t fdt16_t;
 typedef uint32_t fdt32_t;
-- 
2.27.0



From xen-devel-bounces@lists.xenproject.org Fri Oct 22 10:48:14 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Oct 2021 10:48:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.214951.373848 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mds5u-0006fn-Gm; Fri, 22 Oct 2021 10:48:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 214951.373848; Fri, 22 Oct 2021 10:48:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mds5u-0006f7-As; Fri, 22 Oct 2021 10:48:14 +0000
Received: by outflank-mailman (input) for mailman id 214951;
 Fri, 22 Oct 2021 10:48:12 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=h+2b=PK=citrix.com=lin.liu@srs-us1.protection.inumbo.net>)
 id 1mds5s-00063s-J0
 for xen-devel@lists.xenproject.org; Fri, 22 Oct 2021 10:48:12 +0000
Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 8aaffa20-3325-11ec-83b2-12813bfff9fa;
 Fri, 22 Oct 2021 10:48:07 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8aaffa20-3325-11ec-83b2-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1634899687;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=KXdMTUepQc/hWgrrZYpWXrp3b/8Yk5JMcrV/PHsyXk8=;
  b=CBOnxnnSZHoq9WMG/jcYbwpGgX6tWk25cLlIj3/ck1cM0TGe8RalBcQD
   39GMHUm9YSp38uOllQXfB5yaFXHtpym8OCCy/KyPzTjuZhFdEpQRh8cGO
   DUuJDB7y33obkqD5N2xOF20ga0L5js2wSSxFBAomYBDX2qoXkAwFOcc9K
   A=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: 5mV+QcJuMbU1xqtO+XxIArH03DeejP7wBDUKBvGVXkm3MZrcF9qzgOVv4yecmboHYycM1Vflk0
 5i3hChc0YQ9YowmZezRDpSA32TSB8OCaxG+EHSxk9xZjxz5VlTa3M0Hw0XutKF0G1+hsnZVc+C
 68ze2YdqIDFWFIItGHmjSV/FaZ7K30Mr751aZwc/YPLr3OF8bpzZtLbLa8mo5yx7jJ7DTlyE/V
 uZlNdYx3Q0Zu0Ul0quvuehcm2UHx55DlBQcIgiV4YiW4ZHr6/S15RDhUN7Wv8btxjVghqrHz1L
 X62c5dseILazvfIQRis2jK9r
X-SBRS: 5.1
X-MesageID: 55807253
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:m7bC0qubxBSeGMlPh5sjBrMyKufnVIhZMUV32f8akzHdYApBsoF/q
 tZmKW3VOf/bYGvyeosnOY/j/EMG7cOGnN9qSFZo/yFkES8T+JbJXdiXEBz9bniYRiHhoOOLz
 Cm8hv3odp1coqr0/0/1WlTZQP0VOZigHtIQMsadUsxKbVIiGHhJZS5LwbZj29cw24LhWWthh
 PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe
 gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ
 Nplu8fzUAMUJvT2vstEdUB8Gid/IqJI0eqSSZS/mZT7I0zudnLtx7NlDV0sPJ1e8eFyaY1M3
 aVGcnZXNEnF3r/ohuLgIgVvrp1LwM3DOIIZ/HVh0BnSDOo8QICFSKLPjTNd9Gpt1pgRR6uFD
 yYfQTBjQw/pQAJlAWUoGZ4FnMGIqSPkcDIN/Tp5ooJoujOOnWSdyoPFPMLOf92WRe1chkuCu
 n/d5GP9Hw0bM9qEjzGC9xqEiuDDkCzhUaoOBba48bhsm1TVyWsNYDUGWF3+rfSnh0qWX9NEN
 1dS6icotbI19kGgUp/6RRLQnZKflkdCAZwKSbR8sVzTjPqPi+qEOoQaZjAaK8UiiddvfxoFj
 3nQu9rvBCNgvpTAHBpx6YyohT+1PCEUK0oLaikFURYJ7rHfnW0jsv7cZo08SPDt37UZDRm1m
 mrQ9HFv2N3/mOZSj/3jlW0rlQ5AsXQgouQd3Q7QQn6+pj1wYIqoduREAnCKsK4ecu51orSH1
 UXoevRyDshSUvlhdwTXGY3h+Y1FAd7fbFUwZnY0R/EcG8yFoSLLQGypyGgWyL1VGsgFYyT1R
 0TYpBlc4pReVFPzM/QrM97oVJRylvWxfTgAahwyRoASCnSWXFTflByCmGbKhzy9+KTSufFX1
 WinnTaEUi9BVPUPIMueTOYBy747rh3SNkuILa0XOy+PiOLEDFbMEO9tGALXMogRsfPVyC2Io
 o03H5bblH1ivBjWP3C/HXg7dgtRcxDWxPne9qRqSwJ0ClM3QT97U6aMme9Jlk4Mt/09q9okN
 0qVAidwoGcTT1WeQelTQnw8Or7pQ7hlqnc3YX4lMVqygiBxaoez9qYPMZAweOB/puBkyPd1S
 dgDetmBXasTGmiWpWxFYMmvtpFmeTSqmRmKY3ivbg8gcsMyXAfO4NLlIFfirXFcEiqtuMIii
 LS8zQeHE4EbTgFvAZ+OOvKixl+8p1YHn+d2UxeaK9VfYhy0ooNrNzbwnrk8JMRVcUfPwT6T1
 gC3BxYEpLaS/99poYeR3a3d9tWnCepzGEZeDlL317fuOHmI5HenzK9BTP2MIWLXWlTr9fjwf
 u5S1fz9bqEKxQ4Yr4pmHr935qsi/N+z9aRCxwFpEXiXPVSmDrRsfiuP0cVV7/Afw7ZYvU29W
 16V+8kcMrKMYZu3HFkULQsjT+KCyfBLxWWCsaVreB33tH1t4b6KcUROJB3d2iVSIYx8PJ4h3
 ep86tUd7Bayi0ZyP9uL5syOG79g8pDUv30bi6wn
IronPort-HdrOrdr: A9a23:Rx5Bgq8GbjfmWaIMfPxuk+DiI+orL9Y04lQ7vn2YSXRuE/Bw8P
 re5cjztCWE8wr5N0tQ+uxoVJPufZqYz+8Q3WBzB8bFYOCFghrLEGgK1+KLqFeMdxEWtNQtsp
 uIG5IOcOEYZmIbsS+V2meF+q4bsby6zJw=
X-IronPort-AV: E=Sophos;i="5.87,172,1631592000"; 
   d="scan'208";a="55807253"
From: Lin Liu <lin.liu@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Lin Liu <lin.liu@citrix.com>, Daniel De Graaf <dgdegra@tycho.nsa.gov>,
	"Daniel P. Smith" <dpsmith@apertussolutions.com>
Subject: [PATCH v2 5/7] xen/xsm: Switch to byteswap.h
Date: Fri, 22 Oct 2021 10:47:26 +0000
Message-ID: <400efbc5c394140bb01664e5847046e8c4a38ea2.1634897942.git.lin.liu@citrix.com>
X-Mailer: git-send-email 2.27.0
In-Reply-To: <cover.1634897942.git.lin.liu@citrix.com>
References: <cover.1634897942.git.lin.liu@citrix.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

Update to use byteswap.h to swap bytes

No functional change

Signed-off-by: Lin Liu <lin.liu@citrix.com>
---
Cc: Daniel De Graaf <dgdegra@tycho.nsa.gov>
Cc: "Daniel P. Smith" <dpsmith@apertussolutions.com>
---
 xen/xsm/flask/ss/avtab.c       | 2 +-
 xen/xsm/flask/ss/conditional.c | 2 +-
 xen/xsm/flask/ss/ebitmap.c     | 2 +-
 xen/xsm/flask/ss/policydb.c    | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/xen/xsm/flask/ss/avtab.c b/xen/xsm/flask/ss/avtab.c
index bfc91c8b0c..1fa796f625 100644
--- a/xen/xsm/flask/ss/avtab.c
+++ b/xen/xsm/flask/ss/avtab.c
@@ -19,8 +19,8 @@
 
 /* Ported to Xen 3.0, George Coker, <gscoker@alpha.ncsc.mil> */
 
+#include <xen/byteswap.h>
 #include <xen/lib.h>
-#include <asm/byteorder.h>
 #include <xen/types.h>
 #include <xen/xmalloc.h>
 #include <xen/errno.h>
diff --git a/xen/xsm/flask/ss/conditional.c b/xen/xsm/flask/ss/conditional.c
index 3e58aea551..059f6e07e5 100644
--- a/xen/xsm/flask/ss/conditional.c
+++ b/xen/xsm/flask/ss/conditional.c
@@ -9,7 +9,7 @@
 
 /* Ported to Xen 3.0, George Coker, <gscoker@alpha.ncsc.mil> */
 
-#include <asm/byteorder.h>
+#include <xen/byteswap.h>
 #include <xen/lib.h>
 #include <xen/types.h>
 #include <xen/errno.h>
diff --git a/xen/xsm/flask/ss/ebitmap.c b/xen/xsm/flask/ss/ebitmap.c
index e1d0a586a7..1550437c6f 100644
--- a/xen/xsm/flask/ss/ebitmap.c
+++ b/xen/xsm/flask/ss/ebitmap.c
@@ -10,7 +10,7 @@
 
 /* Ported to Xen 3.0, George Coker, <gscoker@alpha.ncsc.mil> */
 
-#include <asm/byteorder.h>
+#include <xen/byteswap.h>
 #include <xen/lib.h>
 #include <xen/xmalloc.h>
 #include <xen/errno.h>
diff --git a/xen/xsm/flask/ss/policydb.c b/xen/xsm/flask/ss/policydb.c
index 9426164353..595005c3b7 100644
--- a/xen/xsm/flask/ss/policydb.c
+++ b/xen/xsm/flask/ss/policydb.c
@@ -22,7 +22,7 @@
 
 /* Ported to Xen 3.0, George Coker, <gscoker@alpha.ncsc.mil> */
 
-#include <asm/byteorder.h>
+#include <xen/byteswap.h>
 #include <xen/lib.h>
 #include <xen/types.h>
 #include <xen/xmalloc.h>
-- 
2.27.0



From xen-devel-bounces@lists.xenproject.org Fri Oct 22 10:48:18 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Oct 2021 10:48:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.214952.373866 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mds5x-0007Fx-UL; Fri, 22 Oct 2021 10:48:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 214952.373866; Fri, 22 Oct 2021 10:48:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mds5x-0007Fh-Om; Fri, 22 Oct 2021 10:48:17 +0000
Received: by outflank-mailman (input) for mailman id 214952;
 Fri, 22 Oct 2021 10:48:16 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=h+2b=PK=citrix.com=lin.liu@srs-us1.protection.inumbo.net>)
 id 1mds5w-00063m-SN
 for xen-devel@lists.xenproject.org; Fri, 22 Oct 2021 10:48:16 +0000
Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id f06f55d9-7516-4143-8db2-48f17f8c1914;
 Fri, 22 Oct 2021 10:48:07 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f06f55d9-7516-4143-8db2-48f17f8c1914
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1634899687;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=arMkqO0Q4MIEtmu8VJig4sN6edJ7nb/bgiFiX5lqa8c=;
  b=eTJv55e3Lp+uU2aC716fPVPYRjVGdtIWgf4iSwrf/a/5IjBbkEa4wsik
   U3R6csVQorfoMOpi+JUJldRqRojW28Xx5rvfavEAqestOQyFy1Dz5kwQx
   rIzZdAbeldEYLnYxAScMzJg0AFB9x9rtLCVxzpgtMrAsscuAX0R1rG2UX
   0=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: gzgD0Aqt+8NJtKdFIeJMXLFKKycQr/Rx0IQcq1ZbxHWWR+jiKWE3ua5xfsK6L25JhTLomjrqig
 JRJJ0niuWCQYwy30tlVbiETg0H8vgG8BpmN6GIF9BKs+c5fw73K6Q2PVfgHCxl4oGJcCMaTmlN
 l9vrVLQBN8wIq4OsWIA3Iwz7IJSzkmRKYLyp7zAWsveEaJHUpl+cPcmt8ZJgQEuHkiv7kNZ6IN
 96cY7gCrGao64wenrjjVTLZLInkfkfkYmm3Q7UHfSziKGKlqY16CgKRX7UtOiij7CdOk8Ol3yV
 X53l6uT4DECkXO/8qdRdwGvZ
X-SBRS: 5.1
X-MesageID: 55376143
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:8FGM6K58AzjVO4ztE7kwegxRtNfAchMFZxGqfqrLsTDasY5as4F+v
 mUcWGCDafbZZ2L0c9kgbNni9hsOvpXcyd43TAZt/ithHi5G8cbLO4+Ufxz6V8+wwmwvb67FA
 +E2MISowBUcFyeEzvuV3zyIQUBUjclkfJKlYAL/En03FVAMpBsJ00o5wrdh2NQw27BVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Zz
 PxGkYyRRyQQGYL+qe5NSwhKIX9+IvgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALKMjteocep1lrzC3DDOZgSpfGK0nPzYIFh2hu35wVdRrYT
 +4Dcj5mTTXMWT0VAmUMMp0Rs/+xnHaqJlW0r3rK/PFqsgA/1jdZ0qXpMdfTUsyHQ4NShEnwj
 lzB+2P1ExQLLuu1wDCO8m+vruLXlCa9U4UXfJWo+/gvjFCNy2g7DBwNSUD9sfS/klS5Wd9UN
 woT4CVGhbMp6EWhQ935Xhu5iH2JpBgRX5xXCeJS1e2W4vOKuUDDXDFCF2MfLox93CMredA0/
 luglPf5JDJMiZq6e0OXpq+FvwHsOTdAeAfuehQ4ZQcC5tDipqQ6gRTOUstvHcaJszHlJd3j6
 2vV9HZm1t3/meZOjv/hpQmW3FpAs7CQFlZtjjg7SF5J+e+QiGSNXIev9UTApchJKIKUXzFtV
 1BVxpDAsoji4XyL/RFhodnh/pn1uJ5p0xWG2DaD+qXNERz3pxZPmqgLuFlDyL9BaJpsRNMQS
 Ba7VfltzJFSJmC2SqR8fpi8Dc8npYC5S4+5BqyNMYoWOcUgHONiwM2ITRTMt4wKuBN0+ZzTx
 L/BKZr8ZZrkIfQPIMWKqxc1juZwm3FWKZL7TpHn1RW3uYdyl1bOIYrpxGCmN7hjhIvd+V292
 48Ga6OilkUOOMWjM3K/2dNCcjg3wY0TWMmeRzp/LbXYfGKL2QgJVpfs/F/WU9U0xvoPzr6Vp
 i3Vt40x4AOXuEAr4D6iMhhLAI4Dl74mxZ7iFSBzb1uuxVY5ZoOjsPUWe5ctJOF1/+1/1/9kC
 fICfpzYUPhITz3G/RUbbIX889M+JEj621rWMnr3eiU7cr5hWxfNpo3ucDzw+XRcFSGwr8Y//
 eGtj1uJXZoZSg1+J8/Kc/bznUiptH0QlbsqDUvFK9VeYmv2941uJ3Cjh/M7OZhUex7C2iGbx
 0CdBhJB/bvBpIo88d/og6GYrtj2T7siTxQCR2SCtOS4LyjX+Gan0LRsaufQcGCPTn7w9YWje
 f5Rk6P2PsoYkQsYqIF7Cbtqk/4zvoO9u79Aww14N3zXdFD3WKh4K3yL0MQT5K1AwrhV5Vm/V
 k6Vo4QIPLyIPIXuEUILJRpjZeOGjKlGlj7X5PUzAUP7+C4oo+bXDRQMZ0GB2H5HMb94EII52
 uNw6scZ5ju2hgcuLtvb3Dtf8H6BLyBYXqgq3n3A7FQHVub/Jol+XKHh
IronPort-HdrOrdr: A9a23:+CjiXa7kuJroxuP+VwPXwPDXdLJyesId70hD6qhwISY6TiX+rb
 HJoB17726NtN9/YhEdcLy7VJVoBEmskKKdgrNhWotKPjOW21dARbsKheCJrgEIWReOktK1vZ
 0QCpSWY+eQMbEVt6nHCXGDYrQd/OU=
X-IronPort-AV: E=Sophos;i="5.87,172,1631592000"; 
   d="scan'208";a="55376143"
From: Lin Liu <lin.liu@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Lin Liu <lin.liu@citrix.com>, Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: [PATCH v2 3/7] arm64/find_next_bit: Remove ext2_swab()
Date: Fri, 22 Oct 2021 10:47:24 +0000
Message-ID: <ad5aba3410913496254975e1ad531708329246aa.1634897942.git.lin.liu@citrix.com>
X-Mailer: git-send-email 2.27.0
In-Reply-To: <cover.1634897942.git.lin.liu@citrix.com>
References: <cover.1634897942.git.lin.liu@citrix.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

ext2 has nothing to do with this logic.  Clean up the code with
xen/byteswap.h which now has an unsigned long helper.

No functional change.

Signed-off-by: Lin Liu <lin.liu@citrix.com>
---
Cc: Stefano Stabellini <sstabellini@kernel.org>
Cc: Julien Grall <julien@xen.org>
Cc: Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
The patches are not well tested without running environment
---
 xen/arch/arm/arm64/lib/find_next_bit.c | 40 ++++++--------------------
 1 file changed, 8 insertions(+), 32 deletions(-)

diff --git a/xen/arch/arm/arm64/lib/find_next_bit.c b/xen/arch/arm/arm64/lib/find_next_bit.c
index 8ebf8bfe97..8a7cfc0949 100644
--- a/xen/arch/arm/arm64/lib/find_next_bit.c
+++ b/xen/arch/arm/arm64/lib/find_next_bit.c
@@ -8,9 +8,9 @@
  * as published by the Free Software Foundation; either version
  * 2 of the License, or (at your option) any later version.
  */
-#include <xen/bitops.h>
 #include <asm/types.h>
-#include <asm/byteorder.h>
+#include <xen/bitops.h>
+#include <xen/byteswap.h>
 
 #ifndef find_next_bit
 /*
@@ -161,30 +161,6 @@ EXPORT_SYMBOL(find_first_zero_bit);
 
 #ifdef __BIG_ENDIAN
 
-/* include/linux/byteorder does not support "unsigned long" type */
-static inline unsigned long ext2_swabp(const unsigned long * x)
-{
-#if BITS_PER_LONG == 64
-	return (unsigned long) __swab64p((u64 *) x);
-#elif BITS_PER_LONG == 32
-	return (unsigned long) __swab32p((u32 *) x);
-#else
-#error BITS_PER_LONG not defined
-#endif
-}
-
-/* include/linux/byteorder doesn't support "unsigned long" type */
-static inline unsigned long ext2_swab(const unsigned long y)
-{
-#if BITS_PER_LONG == 64
-	return (unsigned long) __swab64((u64) y);
-#elif BITS_PER_LONG == 32
-	return (unsigned long) __swab32((u32) y);
-#else
-#error BITS_PER_LONG not defined
-#endif
-}
-
 #ifndef find_next_zero_bit_le
 unsigned long find_next_zero_bit_le(const void *addr, unsigned
 		long size, unsigned long offset)
@@ -199,7 +175,7 @@ unsigned long find_next_zero_bit_le(const void *addr, unsigned
 	size -= result;
 	offset &= (BITS_PER_LONG - 1UL);
 	if (offset) {
-		tmp = ext2_swabp(p++);
+		tmp = bswap_ul(*p++);
 		tmp |= (~0UL >> (BITS_PER_LONG - offset));
 		if (size < BITS_PER_LONG)
 			goto found_first;
@@ -217,7 +193,7 @@ unsigned long find_next_zero_bit_le(const void *addr, unsigned
 	}
 	if (!size)
 		return result;
-	tmp = ext2_swabp(p);
+	tmp = bswap_ul(*p);
 found_first:
 	tmp |= ~0UL << size;
 	if (tmp == ~0UL)	/* Are any bits zero? */
@@ -226,7 +202,7 @@ found_middle:
 	return result + ffz(tmp);
 
 found_middle_swap:
-	return result + ffz(ext2_swab(tmp));
+	return result + ffz(bswap_ul(tmp));
 }
 EXPORT_SYMBOL(find_next_zero_bit_le);
 #endif
@@ -245,7 +221,7 @@ unsigned long find_next_bit_le(const void *addr, unsigned
 	size -= result;
 	offset &= (BITS_PER_LONG - 1UL);
 	if (offset) {
-		tmp = ext2_swabp(p++);
+		tmp = bswap_ul(*p++);
 		tmp &= (~0UL << offset);
 		if (size < BITS_PER_LONG)
 			goto found_first;
@@ -264,7 +240,7 @@ unsigned long find_next_bit_le(const void *addr, unsigned
 	}
 	if (!size)
 		return result;
-	tmp = ext2_swabp(p);
+	tmp = bswap_ul(*p);
 found_first:
 	tmp &= (~0UL >> (BITS_PER_LONG - size));
 	if (tmp == 0UL)		/* Are any bits set? */
@@ -273,7 +249,7 @@ found_middle:
 	return result + __ffs(tmp);
 
 found_middle_swap:
-	return result + __ffs(ext2_swab(tmp));
+	return result + __ffs(bswap_ul(tmp));
 }
 EXPORT_SYMBOL(find_next_bit_le);
 #endif
-- 
2.27.0



From xen-devel-bounces@lists.xenproject.org Fri Oct 22 10:48:19 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Oct 2021 10:48:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.214953.373877 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mds5z-0007Wr-8P; Fri, 22 Oct 2021 10:48:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 214953.373877; Fri, 22 Oct 2021 10:48:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mds5z-0007WM-4L; Fri, 22 Oct 2021 10:48:19 +0000
Received: by outflank-mailman (input) for mailman id 214953;
 Fri, 22 Oct 2021 10:48:17 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=h+2b=PK=citrix.com=lin.liu@srs-us1.protection.inumbo.net>)
 id 1mds5x-00063s-JL
 for xen-devel@lists.xenproject.org; Fri, 22 Oct 2021 10:48:17 +0000
Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 893393e9-3325-11ec-83b2-12813bfff9fa;
 Fri, 22 Oct 2021 10:48:07 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 893393e9-3325-11ec-83b2-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1634899687;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=1OHvsWzP7gE68vduDcWmR3YdlGbvcStDaG0K0LsI1tc=;
  b=GYz/yfZWbhjSvCAnUx9E97WF0o+SmPpCEHxK8NkA1mAEag1aNGSwEQT+
   ri9lkLmfYEmqLVCZjh/i0046DGexy34UQJBcZdLyE7RHMa8txMb9OMqtW
   rddAzo3u+oDwAKxCIKmsMNnY34xoaRaTLzrVsu5AcGwBpcM+UTLJNV1Bi
   g=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: R21dHoDic8am31wi4NNutW4/f5v3voGJG2274lGVy8ycKKjz2xsmBV2dRbZ31drFKBDzkZOBef
 wCXCjGnVOVR3t9FQVsel/0Ef5cGwaBu/jNpJfs5czAYtzBJjEbBFKkC52xqQLXkYjzlM0IlR42
 OA+zU9T3O97ZY1Gn1K/R04MikW+aEyH1W2N51b0R8PgNpH8aH+YLVVXCzyovSo5yJ+ENvcaxL0
 Jm0S3l4LUT3KoghrX/nLs9E7r262w12h+1L7lBT+cKbLwcJMb/60L2EnUYLm0sOA/I3mT06F+d
 LNwyKb9pJIETzQMyRzLwGsfS
X-SBRS: 5.1
X-MesageID: 55376145
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:m+n9pamtyPKDorFQ/6E8V3Po5gwZIURdPkR7XQ2eYbSJt1+Wr1Gzt
 xIZDGmAaKvbamGkKtAjb9/iox9Qv8ODzYAxSgU9rC09FCMWpZLJC+rCIxarNUt+DCFioGGLT
 Sk6QoOdRCzhZiaE/n9BClVlxJVF/fngqoDUUYYoAQgsA187IMsdoUg7wbdg2tQy2YLR7z6l4
 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc
 s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4
 JZvrLq/WxszB4vvg/kdCRkHIQAhOoQTrdcrIVDn2SCS50jPcn+qyPRyFkAme4Yf/46bA0kXq
 6ZecmpUKEne2aTmm9pXScE17ignBM3qOsUbu2xIxjDFF/c2B5vERs0m4PcFgWxv2JkSQJ4yY
 eIXcSBKRw3lPSRfFWhOJqsZsOG2q0jgJmgwRFW9+vNsvjm7IBZK+LrnPcfRe9eKbd5IhUver
 WXDl0z7HxUbOdq32TeDtHW2iYfngifTSI8UUrqi+ZZCgUKR7nweDgUMUlm2quX/jVSxM/pPJ
 kpR9icwoKwa8E2wUsK7TxC+uGSDvBMXR5xXCeJSwBqW1qPe7gKdB24FZj1MctorsIkxXzNC/
 mGOm9TlFDl+qoq/QHiW9qqXhT6qMC1TJmgHDRLoViNcvYOl+ttqyEuSEJAzS8ZZk+EZBxmz4
 SmsozoinYw1rtUW1/+7omLm3DWF882hohEO2i3bWWes7wVcbYGjZpC15VWz0cusPLp1XXHa4
 yBaw5n2APQmSMjXznTUEbpl8KSBvq7daFXhbUhT847NHthH00WoepxM+3lALUNtP9dsldTBM
 RKL5105CHO+OhKXgU5Lj2CZV5tCIUvIT42NuhXogjxmOMQZmOivp3kGWKJo9zqx+HXAaIlmU
 XthTe6iDGwBFYNsxyesSuEW3NcDn35lmTOPHM+rl0/6gNJygUJ5r59fbDNiichitMu5TPj9q
 Y4DZ6NmNT0POAEBXsUn2dFKdg1bRZTKLZv3t9ZWZoa+zvlOQwkc5wvq6ep5IeRNxv0N/s+Rp
 y3VchIImTLX2CycQS3XOy8LVV8adcsmxZ7NFXd3ZgjANrlKSdvH0ZrzgLNuLOB5rrQ6kKYoJ
 xTHEu3Zaslypv3802x1RfHAQEZKLnxHXCqCYHioZiYRZZllS1Cb89PoZFK3piIPEjC2pY01p
 Lj5jlHXRp8KRgJDCsfKaa3wkwPt7CZFwO8iDVHVJtRzeVn39NQ4ISLGkfJqcdoHLg/Ox2XG2
 l/OUwsYv+TEv6Q87MLN2fKft46sHuYnRhhaEmDX4KyYLy7f+mb/k4ZMXPzRJWLWVX/u+bXkb
 uJQlqmuPPoClVdMkox9D7c0kv5uu4qx/+dXl102Em/KYlKnDqJbDkOHhcQf5LdQwrJ5uBetX
 h7d8NdtJrjUatjuF0QcJVR5Y73bh+0UgDTb8d88PF7+uH1s5LOCXEhfY0uMhShaIOcnOY8p2
 7586ssf6gj5gRs2KNeWyCtT8j3UfHAHVqwmsLAcAZPq1VV3mg0TP8SEB3+k+oyLZvVNLlIuc
 22di6f1jrhBwlbPLigoHn/X0OsB3ZkDtXimFrPZy4hlTjYdusIK4Q==
IronPort-HdrOrdr: A9a23:gQTE5qxa3hXD79FMeZPpKrPwFL1zdoMgy1knxilNoRw8SKKlfq
 eV7Y0mPH7P+VAssR4b+exoVJPtfZqYz+8R3WBzB8bEYOCFghrKEGgK1+KLqFeMJ8S9zJ846U
 4JSdkHNDSaNzlHZKjBjzVQa+xQouW6zA==
X-IronPort-AV: E=Sophos;i="5.87,172,1631592000"; 
   d="scan'208";a="55376145"
From: Lin Liu <lin.liu@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Lin Liu <lin.liu@citrix.com>, Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
	Jan Beulich <jbeulich@suse.com>, Wei Liu <wl@xen.org>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>
Subject: [PATCH v2 7/7] byteorder: Remove byteorder
Date: Fri, 22 Oct 2021 10:47:28 +0000
Message-ID: <e0ffd4c6db4dc1f1e0a7ef7dd6d02c49f944353c.1634897942.git.lin.liu@citrix.com>
X-Mailer: git-send-email 2.27.0
In-Reply-To: <cover.1634897942.git.lin.liu@citrix.com>
References: <cover.1634897942.git.lin.liu@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

include/xen/byteswap.h has simplify the interface, just clean
the old interface

No functional change

Signed-off-by: Lin Liu <lin.liu@citrix.com>
---
Cc: Stefano Stabellini <sstabellini@kernel.org>
Cc: Julien Grall <julien@xen.org>
Cc: Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: George Dunlap <george.dunlap@citrix.com>
Cc: Ian Jackson <iwj@xenproject.org>
Cc: Jan Beulich <jbeulich@suse.com>
Cc: Wei Liu <wl@xen.org>
Cc: "Roger Pau Monné" <roger.pau@citrix.com>
---
 xen/include/asm-arm/byteorder.h           |  16 --
 xen/include/asm-x86/byteorder.h           |  36 -----
 xen/include/xen/byteorder/big_endian.h    | 102 ------------
 xen/include/xen/byteorder/generic.h       |  68 --------
 xen/include/xen/byteorder/little_endian.h | 102 ------------
 xen/include/xen/byteorder/swab.h          | 183 ----------------------
 6 files changed, 507 deletions(-)
 delete mode 100644 xen/include/asm-arm/byteorder.h
 delete mode 100644 xen/include/asm-x86/byteorder.h
 delete mode 100644 xen/include/xen/byteorder/big_endian.h
 delete mode 100644 xen/include/xen/byteorder/generic.h
 delete mode 100644 xen/include/xen/byteorder/little_endian.h
 delete mode 100644 xen/include/xen/byteorder/swab.h

diff --git a/xen/include/asm-arm/byteorder.h b/xen/include/asm-arm/byteorder.h
deleted file mode 100644
index 9c712c4788..0000000000
--- a/xen/include/asm-arm/byteorder.h
+++ /dev/null
@@ -1,16 +0,0 @@
-#ifndef __ASM_ARM_BYTEORDER_H__
-#define __ASM_ARM_BYTEORDER_H__
-
-#define __BYTEORDER_HAS_U64__
-
-#include <xen/byteorder/little_endian.h>
-
-#endif /* __ASM_ARM_BYTEORDER_H__ */
-/*
- * Local variables:
- * mode: C
- * c-file-style: "BSD"
- * c-basic-offset: 4
- * indent-tabs-mode: nil
- * End:
- */
diff --git a/xen/include/asm-x86/byteorder.h b/xen/include/asm-x86/byteorder.h
deleted file mode 100644
index 1f77e502a5..0000000000
--- a/xen/include/asm-x86/byteorder.h
+++ /dev/null
@@ -1,36 +0,0 @@
-#ifndef __ASM_X86_BYTEORDER_H__
-#define __ASM_X86_BYTEORDER_H__
-
-#include <asm/types.h>
-#include <xen/compiler.h>
-
-static inline __attribute_const__ __u32 ___arch__swab32(__u32 x)
-{
-    asm("bswap %0" : "=r" (x) : "0" (x));
-    return x;
-}
-
-static inline __attribute_const__ __u64 ___arch__swab64(__u64 val)
-{ 
-    union { 
-        struct { __u32 a,b; } s;
-        __u64 u;
-    } v;
-    v.u = val;
-    asm("bswapl %0 ; bswapl %1 ; xchgl %0,%1" 
-        : "=r" (v.s.a), "=r" (v.s.b) 
-        : "0" (v.s.a), "1" (v.s.b)); 
-    return v.u;
-} 
-
-/* Do not define swab16.  Gcc is smart enough to recognize "C" version and
-   convert it into rotation or exhange.  */
-
-#define __arch__swab64(x) ___arch__swab64(x)
-#define __arch__swab32(x) ___arch__swab32(x)
-
-#define __BYTEORDER_HAS_U64__
-
-#include <xen/byteorder/little_endian.h>
-
-#endif /* __ASM_X86_BYTEORDER_H__ */
diff --git a/xen/include/xen/byteorder/big_endian.h b/xen/include/xen/byteorder/big_endian.h
deleted file mode 100644
index 40eb80a390..0000000000
--- a/xen/include/xen/byteorder/big_endian.h
+++ /dev/null
@@ -1,102 +0,0 @@
-#ifndef __XEN_BYTEORDER_BIG_ENDIAN_H__
-#define __XEN_BYTEORDER_BIG_ENDIAN_H__
-
-#ifndef __BIG_ENDIAN
-#define __BIG_ENDIAN 4321
-#endif
-#ifndef __BIG_ENDIAN_BITFIELD
-#define __BIG_ENDIAN_BITFIELD
-#endif
-
-#include <xen/types.h>
-#include <xen/byteorder/swab.h>
-
-#define __constant_cpu_to_le64(x) ((__force __le64)___constant_swab64((x)))
-#define __constant_le64_to_cpu(x) ___constant_swab64((__force __u64)(__le64)(x))
-#define __constant_cpu_to_le32(x) ((__force __le32)___constant_swab32((x)))
-#define __constant_le32_to_cpu(x) ___constant_swab32((__force __u32)(__le32)(x))
-#define __constant_cpu_to_le16(x) ((__force __le16)___constant_swab16((x)))
-#define __constant_le16_to_cpu(x) ___constant_swab16((__force __u16)(__le16)(x))
-#define __constant_cpu_to_be64(x) ((__force __be64)(__u64)(x))
-#define __constant_be64_to_cpu(x) ((__force __u64)(__be64)(x))
-#define __constant_cpu_to_be32(x) ((__force __be32)(__u32)(x))
-#define __constant_be32_to_cpu(x) ((__force __u32)(__be32)(x))
-#define __constant_cpu_to_be16(x) ((__force __be16)(__u16)(x))
-#define __constant_be16_to_cpu(x) ((__force __u16)(__be16)(x))
-#define __cpu_to_le64(x) ((__force __le64)__swab64((x)))
-#define __le64_to_cpu(x) __swab64((__force __u64)(__le64)(x))
-#define __cpu_to_le32(x) ((__force __le32)__swab32((x)))
-#define __le32_to_cpu(x) __swab32((__force __u32)(__le32)(x))
-#define __cpu_to_le16(x) ((__force __le16)__swab16((x)))
-#define __le16_to_cpu(x) __swab16((__force __u16)(__le16)(x))
-#define __cpu_to_be64(x) ((__force __be64)(__u64)(x))
-#define __be64_to_cpu(x) ((__force __u64)(__be64)(x))
-#define __cpu_to_be32(x) ((__force __be32)(__u32)(x))
-#define __be32_to_cpu(x) ((__force __u32)(__be32)(x))
-#define __cpu_to_be16(x) ((__force __be16)(__u16)(x))
-#define __be16_to_cpu(x) ((__force __u16)(__be16)(x))
-
-static inline __le64 __cpu_to_le64p(const __u64 *p)
-{
-    return (__force __le64)__swab64p(p);
-}
-static inline __u64 __le64_to_cpup(const __le64 *p)
-{
-    return __swab64p((__u64 *)p);
-}
-static inline __le32 __cpu_to_le32p(const __u32 *p)
-{
-    return (__force __le32)__swab32p(p);
-}
-static inline __u32 __le32_to_cpup(const __le32 *p)
-{
-    return __swab32p((__u32 *)p);
-}
-static inline __le16 __cpu_to_le16p(const __u16 *p)
-{
-    return (__force __le16)__swab16p(p);
-}
-static inline __u16 __le16_to_cpup(const __le16 *p)
-{
-    return __swab16p((__u16 *)p);
-}
-static inline __be64 __cpu_to_be64p(const __u64 *p)
-{
-    return (__force __be64)*p;
-}
-static inline __u64 __be64_to_cpup(const __be64 *p)
-{
-    return (__force __u64)*p;
-}
-static inline __be32 __cpu_to_be32p(const __u32 *p)
-{
-    return (__force __be32)*p;
-}
-static inline __u32 __be32_to_cpup(const __be32 *p)
-{
-    return (__force __u32)*p;
-}
-static inline __be16 __cpu_to_be16p(const __u16 *p)
-{
-    return (__force __be16)*p;
-}
-static inline __u16 __be16_to_cpup(const __be16 *p)
-{
-    return (__force __u16)*p;
-}
-#define __cpu_to_le64s(x) __swab64s((x))
-#define __le64_to_cpus(x) __swab64s((x))
-#define __cpu_to_le32s(x) __swab32s((x))
-#define __le32_to_cpus(x) __swab32s((x))
-#define __cpu_to_le16s(x) __swab16s((x))
-#define __le16_to_cpus(x) __swab16s((x))
-#define __cpu_to_be64s(x) do {} while (0)
-#define __be64_to_cpus(x) do {} while (0)
-#define __cpu_to_be32s(x) do {} while (0)
-#define __be32_to_cpus(x) do {} while (0)
-#define __cpu_to_be16s(x) do {} while (0)
-#define __be16_to_cpus(x) do {} while (0)
-
-#include <xen/byteorder/generic.h>
-
-#endif /* __XEN_BYTEORDER_BIG_ENDIAN_H__ */
diff --git a/xen/include/xen/byteorder/generic.h b/xen/include/xen/byteorder/generic.h
deleted file mode 100644
index 8a0006b755..0000000000
--- a/xen/include/xen/byteorder/generic.h
+++ /dev/null
@@ -1,68 +0,0 @@
-#ifndef __XEN_BYTEORDER_GENERIC_H__
-#define __XEN_BYTEORDER_GENERIC_H__
-
-/*
- * Generic Byte-reordering support
- *
- * The "... p" macros, like le64_to_cpup, can be used with pointers
- * to unaligned data, but there will be a performance penalty on 
- * some architectures.  Use get_unaligned for unaligned data.
- *
- * The following macros are to be defined by <asm/byteorder.h>:
- *
- * Conversion of XX-bit integers (16- 32- or 64-)
- * between native CPU format and little/big endian format
- * 64-bit stuff only defined for proper architectures
- *     cpu_to_[bl]eXX(__uXX x)
- *     [bl]eXX_to_cpu(__uXX x)
- *
- * The same, but takes a pointer to the value to convert
- *     cpu_to_[bl]eXXp(__uXX x)
- *     [bl]eXX_to_cpup(__uXX x)
- *
- * The same, but change in situ
- *     cpu_to_[bl]eXXs(__uXX x)
- *     [bl]eXX_to_cpus(__uXX x)
- *
- * See asm-foo/byteorder.h for examples of how to provide
- * architecture-optimized versions
- */
-
-#define cpu_to_le64 __cpu_to_le64
-#define le64_to_cpu __le64_to_cpu
-#define cpu_to_le32 __cpu_to_le32
-#define le32_to_cpu __le32_to_cpu
-#define cpu_to_le16 __cpu_to_le16
-#define le16_to_cpu __le16_to_cpu
-#define cpu_to_be64 __cpu_to_be64
-#define be64_to_cpu __be64_to_cpu
-#define cpu_to_be32 __cpu_to_be32
-#define be32_to_cpu __be32_to_cpu
-#define cpu_to_be16 __cpu_to_be16
-#define be16_to_cpu __be16_to_cpu
-#define cpu_to_le64p __cpu_to_le64p
-#define le64_to_cpup __le64_to_cpup
-#define cpu_to_le32p __cpu_to_le32p
-#define le32_to_cpup __le32_to_cpup
-#define cpu_to_le16p __cpu_to_le16p
-#define le16_to_cpup __le16_to_cpup
-#define cpu_to_be64p __cpu_to_be64p
-#define be64_to_cpup __be64_to_cpup
-#define cpu_to_be32p __cpu_to_be32p
-#define be32_to_cpup __be32_to_cpup
-#define cpu_to_be16p __cpu_to_be16p
-#define be16_to_cpup __be16_to_cpup
-#define cpu_to_le64s __cpu_to_le64s
-#define le64_to_cpus __le64_to_cpus
-#define cpu_to_le32s __cpu_to_le32s
-#define le32_to_cpus __le32_to_cpus
-#define cpu_to_le16s __cpu_to_le16s
-#define le16_to_cpus __le16_to_cpus
-#define cpu_to_be64s __cpu_to_be64s
-#define be64_to_cpus __be64_to_cpus
-#define cpu_to_be32s __cpu_to_be32s
-#define be32_to_cpus __be32_to_cpus
-#define cpu_to_be16s __cpu_to_be16s
-#define be16_to_cpus __be16_to_cpus
-
-#endif /* __XEN_BYTEORDER_GENERIC_H__ */
diff --git a/xen/include/xen/byteorder/little_endian.h b/xen/include/xen/byteorder/little_endian.h
deleted file mode 100644
index 4955632793..0000000000
--- a/xen/include/xen/byteorder/little_endian.h
+++ /dev/null
@@ -1,102 +0,0 @@
-#ifndef __XEN_BYTEORDER_LITTLE_ENDIAN_H__
-#define __XEN_BYTEORDER_LITTLE_ENDIAN_H__
-
-#ifndef __LITTLE_ENDIAN
-#define __LITTLE_ENDIAN 1234
-#endif
-#ifndef __LITTLE_ENDIAN_BITFIELD
-#define __LITTLE_ENDIAN_BITFIELD
-#endif
-
-#include <xen/types.h>
-#include <xen/byteorder/swab.h>
-
-#define __constant_cpu_to_le64(x) ((__force __le64)(__u64)(x))
-#define __constant_le64_to_cpu(x) ((__force __u64)(__le64)(x))
-#define __constant_cpu_to_le32(x) ((__force __le32)(__u32)(x))
-#define __constant_le32_to_cpu(x) ((__force __u32)(__le32)(x))
-#define __constant_cpu_to_le16(x) ((__force __le16)(__u16)(x))
-#define __constant_le16_to_cpu(x) ((__force __u16)(__le16)(x))
-#define __constant_cpu_to_be64(x) ((__force __be64)___constant_swab64((x)))
-#define __constant_be64_to_cpu(x) ___constant_swab64((__force __u64)(__be64)(x))
-#define __constant_cpu_to_be32(x) ((__force __be32)___constant_swab32((x)))
-#define __constant_be32_to_cpu(x) ___constant_swab32((__force __u32)(__be32)(x))
-#define __constant_cpu_to_be16(x) ((__force __be16)___constant_swab16((x)))
-#define __constant_be16_to_cpu(x) ___constant_swab16((__force __u16)(__be16)(x))
-#define __cpu_to_le64(x) ((__force __le64)(__u64)(x))
-#define __le64_to_cpu(x) ((__force __u64)(__le64)(x))
-#define __cpu_to_le32(x) ((__force __le32)(__u32)(x))
-#define __le32_to_cpu(x) ((__force __u32)(__le32)(x))
-#define __cpu_to_le16(x) ((__force __le16)(__u16)(x))
-#define __le16_to_cpu(x) ((__force __u16)(__le16)(x))
-#define __cpu_to_be64(x) ((__force __be64)__swab64((x)))
-#define __be64_to_cpu(x) __swab64((__force __u64)(__be64)(x))
-#define __cpu_to_be32(x) ((__force __be32)__swab32((x)))
-#define __be32_to_cpu(x) __swab32((__force __u32)(__be32)(x))
-#define __cpu_to_be16(x) ((__force __be16)__swab16((x)))
-#define __be16_to_cpu(x) __swab16((__force __u16)(__be16)(x))
-
-static inline __le64 __cpu_to_le64p(const __u64 *p)
-{
-    return (__force __le64)*p;
-}
-static inline __u64 __le64_to_cpup(const __le64 *p)
-{
-    return (__force __u64)*p;
-}
-static inline __le32 __cpu_to_le32p(const __u32 *p)
-{
-    return (__force __le32)*p;
-}
-static inline __u32 __le32_to_cpup(const __le32 *p)
-{
-    return (__force __u32)*p;
-}
-static inline __le16 __cpu_to_le16p(const __u16 *p)
-{
-    return (__force __le16)*p;
-}
-static inline __u16 __le16_to_cpup(const __le16 *p)
-{
-    return (__force __u16)*p;
-}
-static inline __be64 __cpu_to_be64p(const __u64 *p)
-{
-    return (__force __be64)__swab64p(p);
-}
-static inline __u64 __be64_to_cpup(const __be64 *p)
-{
-    return __swab64p((__u64 *)p);
-}
-static inline __be32 __cpu_to_be32p(const __u32 *p)
-{
-    return (__force __be32)__swab32p(p);
-}
-static inline __u32 __be32_to_cpup(const __be32 *p)
-{
-    return __swab32p((__u32 *)p);
-}
-static inline __be16 __cpu_to_be16p(const __u16 *p)
-{
-    return (__force __be16)__swab16p(p);
-}
-static inline __u16 __be16_to_cpup(const __be16 *p)
-{
-    return __swab16p((__u16 *)p);
-}
-#define __cpu_to_le64s(x) do {} while (0)
-#define __le64_to_cpus(x) do {} while (0)
-#define __cpu_to_le32s(x) do {} while (0)
-#define __le32_to_cpus(x) do {} while (0)
-#define __cpu_to_le16s(x) do {} while (0)
-#define __le16_to_cpus(x) do {} while (0)
-#define __cpu_to_be64s(x) __swab64s((x))
-#define __be64_to_cpus(x) __swab64s((x))
-#define __cpu_to_be32s(x) __swab32s((x))
-#define __be32_to_cpus(x) __swab32s((x))
-#define __cpu_to_be16s(x) __swab16s((x))
-#define __be16_to_cpus(x) __swab16s((x))
-
-#include <xen/byteorder/generic.h>
-
-#endif /* __XEN_BYTEORDER_LITTLE_ENDIAN_H__ */
diff --git a/xen/include/xen/byteorder/swab.h b/xen/include/xen/byteorder/swab.h
deleted file mode 100644
index b7e30f0503..0000000000
--- a/xen/include/xen/byteorder/swab.h
+++ /dev/null
@@ -1,183 +0,0 @@
-#ifndef __XEN_BYTEORDER_SWAB_H__
-#define __XEN_BYTEORDER_SWAB_H__
-
-/*
- * Byte-swapping, independently from CPU endianness
- *     swabXX[ps]?(foo)
- *
- * Francois-Rene Rideau <fare@tunes.org> 19971205
- *    separated swab functions from cpu_to_XX,
- *    to clean up support for bizarre-endian architectures.
- */
-
-/* casts are necessary for constants, because we never know how for sure
- * how U/UL/ULL map to __u16, __u32, __u64. At least not in a portable way.
- */
-#define ___swab16(x)                                    \
-({                                                      \
-    __u16 __x = (x);                                    \
-    ((__u16)(                                           \
-        (((__u16)(__x) & (__u16)0x00ffU) << 8) |        \
-        (((__u16)(__x) & (__u16)0xff00U) >> 8) ));      \
-})
-
-#define ___swab32(x)                                            \
-({                                                              \
-    __u32 __x = (x);                                            \
-    ((__u32)(                                                   \
-        (((__u32)(__x) & (__u32)0x000000ffUL) << 24) |          \
-        (((__u32)(__x) & (__u32)0x0000ff00UL) <<  8) |          \
-        (((__u32)(__x) & (__u32)0x00ff0000UL) >>  8) |          \
-        (((__u32)(__x) & (__u32)0xff000000UL) >> 24) ));        \
-})
-
-#define ___swab64(x)                                                       \
-({                                                                         \
-    __u64 __x = (x);                                                       \
-    ((__u64)(                                                              \
-        (__u64)(((__u64)(__x) & (__u64)0x00000000000000ffULL) << 56) |     \
-        (__u64)(((__u64)(__x) & (__u64)0x000000000000ff00ULL) << 40) |     \
-        (__u64)(((__u64)(__x) & (__u64)0x0000000000ff0000ULL) << 24) |     \
-        (__u64)(((__u64)(__x) & (__u64)0x00000000ff000000ULL) <<  8) |     \
-            (__u64)(((__u64)(__x) & (__u64)0x000000ff00000000ULL) >>  8) | \
-        (__u64)(((__u64)(__x) & (__u64)0x0000ff0000000000ULL) >> 24) |     \
-        (__u64)(((__u64)(__x) & (__u64)0x00ff000000000000ULL) >> 40) |     \
-        (__u64)(((__u64)(__x) & (__u64)0xff00000000000000ULL) >> 56) ));   \
-})
-
-#define ___constant_swab16(x)                   \
-    ((__u16)(                                   \
-        (((__u16)(x) & (__u16)0x00ffU) << 8) |  \
-        (((__u16)(x) & (__u16)0xff00U) >> 8) ))
-#define ___constant_swab32(x)                           \
-    ((__u32)(                                           \
-        (((__u32)(x) & (__u32)0x000000ffUL) << 24) |    \
-        (((__u32)(x) & (__u32)0x0000ff00UL) <<  8) |    \
-        (((__u32)(x) & (__u32)0x00ff0000UL) >>  8) |    \
-        (((__u32)(x) & (__u32)0xff000000UL) >> 24) ))
-#define ___constant_swab64(x)                                            \
-    ((__u64)(                                                            \
-        (__u64)(((__u64)(x) & (__u64)0x00000000000000ffULL) << 56) |     \
-        (__u64)(((__u64)(x) & (__u64)0x000000000000ff00ULL) << 40) |     \
-        (__u64)(((__u64)(x) & (__u64)0x0000000000ff0000ULL) << 24) |     \
-        (__u64)(((__u64)(x) & (__u64)0x00000000ff000000ULL) <<  8) |     \
-            (__u64)(((__u64)(x) & (__u64)0x000000ff00000000ULL) >>  8) | \
-        (__u64)(((__u64)(x) & (__u64)0x0000ff0000000000ULL) >> 24) |     \
-        (__u64)(((__u64)(x) & (__u64)0x00ff000000000000ULL) >> 40) |     \
-        (__u64)(((__u64)(x) & (__u64)0xff00000000000000ULL) >> 56) ))
-
-/*
- * provide defaults when no architecture-specific optimization is detected
- */
-#ifndef __arch__swab16
-#  define __arch__swab16(x) ({ __u16 __tmp = (x) ; ___swab16(__tmp); })
-#endif
-#ifndef __arch__swab32
-#  define __arch__swab32(x) ({ __u32 __tmp = (x) ; ___swab32(__tmp); })
-#endif
-#ifndef __arch__swab64
-#  define __arch__swab64(x) ({ __u64 __tmp = (x) ; ___swab64(__tmp); })
-#endif
-
-#ifndef __arch__swab16p
-#  define __arch__swab16p(x) __arch__swab16(*(x))
-#endif
-#ifndef __arch__swab32p
-#  define __arch__swab32p(x) __arch__swab32(*(x))
-#endif
-#ifndef __arch__swab64p
-#  define __arch__swab64p(x) __arch__swab64(*(x))
-#endif
-
-#ifndef __arch__swab16s
-#  define __arch__swab16s(x) do { *(x) = __arch__swab16p((x)); } while (0)
-#endif
-#ifndef __arch__swab32s
-#  define __arch__swab32s(x) do { *(x) = __arch__swab32p((x)); } while (0)
-#endif
-#ifndef __arch__swab64s
-#  define __arch__swab64s(x) do { *(x) = __arch__swab64p((x)); } while (0)
-#endif
-
-
-/*
- * Allow constant folding
- */
-#if defined(__GNUC__) && defined(__OPTIMIZE__)
-#  define __swab16(x) \
-(__builtin_constant_p((__u16)(x)) ? \
- ___swab16((x)) : \
- __fswab16((x)))
-#  define __swab32(x) \
-(__builtin_constant_p((__u32)(x)) ? \
- ___swab32((x)) : \
- __fswab32((x)))
-#  define __swab64(x) \
-(__builtin_constant_p((__u64)(x)) ? \
- ___swab64((x)) : \
- __fswab64((x)))
-#else
-#  define __swab16(x) __fswab16(x)
-#  define __swab32(x) __fswab32(x)
-#  define __swab64(x) __fswab64(x)
-#endif /* OPTIMIZE */
-
-
-static inline __attribute_const__ __u16 __fswab16(__u16 x)
-{
-    return __arch__swab16(x);
-}
-static inline __u16 __swab16p(const __u16 *x)
-{
-    return __arch__swab16p(x);
-}
-static inline void __swab16s(__u16 *addr)
-{
-    __arch__swab16s(addr);
-}
-
-static inline __attribute_const__ __u32 __fswab32(__u32 x)
-{
-    return __arch__swab32(x);
-}
-static inline __u32 __swab32p(const __u32 *x)
-{
-    return __arch__swab32p(x);
-}
-static inline void __swab32s(__u32 *addr)
-{
-    __arch__swab32s(addr);
-}
-
-#ifdef __BYTEORDER_HAS_U64__
-static inline __attribute_const__ __u64 __fswab64(__u64 x)
-{
-#  ifdef __SWAB_64_THRU_32__
-    __u32 h = x >> 32;
-        __u32 l = x & ((1ULL<<32)-1);
-        return (((__u64)__swab32(l)) << 32) | ((__u64)(__swab32(h)));
-#  else
-    return __arch__swab64(x);
-#  endif
-}
-static inline __u64 __swab64p(const __u64 *x)
-{
-    return __arch__swab64p(x);
-}
-static inline void __swab64s(__u64 *addr)
-{
-    __arch__swab64s(addr);
-}
-#endif /* __BYTEORDER_HAS_U64__ */
-
-#define swab16 __swab16
-#define swab32 __swab32
-#define swab64 __swab64
-#define swab16p __swab16p
-#define swab32p __swab32p
-#define swab64p __swab64p
-#define swab16s __swab16s
-#define swab32s __swab32s
-#define swab64s __swab64s
-
-#endif /* __XEN_BYTEORDER_SWAB_H__ */
-- 
2.27.0



From xen-devel-bounces@lists.xenproject.org Fri Oct 22 10:48:22 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Oct 2021 10:48:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.214954.373888 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mds62-00080Q-Oj; Fri, 22 Oct 2021 10:48:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 214954.373888; Fri, 22 Oct 2021 10:48:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mds62-0007zU-Ix; Fri, 22 Oct 2021 10:48:22 +0000
Received: by outflank-mailman (input) for mailman id 214954;
 Fri, 22 Oct 2021 10:48:21 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=h+2b=PK=citrix.com=lin.liu@srs-us1.protection.inumbo.net>)
 id 1mds61-00063m-Sc
 for xen-devel@lists.xenproject.org; Fri, 22 Oct 2021 10:48:21 +0000
Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 21720d4b-1c5e-4ff2-abb1-670f19cdc7f6;
 Fri, 22 Oct 2021 10:48:07 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 21720d4b-1c5e-4ff2-abb1-670f19cdc7f6
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1634899687;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=bfisxychtO/D4CCkbsgtm3RJ+Fi6Cv0nOU8o5cia1XU=;
  b=BcJzWJPeRZQgwteUcwD8rFvKcckb+Gx5UYJSCD1P7/G5YoBea8xEvjWI
   L91EPz1G6pFi5YeF84PryIHSYN/Bp66ofrHcjZtZAAJ2cNkUlt1fVinnu
   mZQXUFUiZV3ZK+RXAEY6xv7dNaexbmvGtltR88UVezCk/ZXzLlSFf9yxi
   A=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: cE3i5g0JyT38eH7D6JiAjqPsCSe1+kOq1dm5/wDz28TF8TagMmd0W9E9YOUmGFQ3UKXIbCpIba
 gKCXuaIhx0x7XPoq/zDzvNsIuqzjWoDdBLnlUPrqf6vLHkro4f4QRNK/xmclcOKSknCYoE1a4K
 x3hzLZyenWSRW4JrhXVGbzmWVeKHcSKAjdTtayf5k1JsI5rbO6Pk9yOBSpwpSp7dWNZNbWO7+H
 8oiB7JbhunwacKZiLP65PeTtxiViUAl27srwWVTGZwro6HqLPBQECu1Z1lbMFsvQxd2rkjLNks
 iZfvCyv0+LXCC4+Q2hptAIvr
X-SBRS: 5.1
X-MesageID: 55807252
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:88jFLaO2xRsFxBrvrR0hkMFynXyQoLVcMsEvi/4bfWQNrUom0WcAy
 GEeXTqFM/2JM2X0ft1wb43n/EJSvJCAmt9mGgto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdpJYz/uUGuCJQUNUjMlkfZKhTr6bUsxNbVU8En540Ug5w7RRbrNA2rBVPSvc4
 bsenOWHULOV82Yc3rU8sv/rRLtH5ZweiRtA1rAMTakjUGz2zhH5OKk3N6CpR0YUd6EPdgKMq
 0Qv+5nilo/R109F5tpICd8XeGVSKlLZFVDmZna7x8FOK/WNz8A/+v9TCRYSVatYozvS3Ml19
 c0Uj7qfECFwGqTKmfsSXTANRkmSPYUekFPGCX22sMjVxEzaaXr8hf5pCSnaP6VBpLwxWzsXs
 6VFdnZdNXhvhMrvqF6/Yu1tgIInLdTDN4IDoHBwizreCJ7KRLieHvWSuoUFhl/cgOhEE6/8S
 epGcQZyRzKeTV4XfUY0GJYXybLAan7XLGQD9QP9SbAMy3PI0AV73bzpMdzUUt+HX8NYmgCfv
 G2u12bkBhAXMvSPxDzD9Wij7sfQmQvrVYRUE6e3ntZ6jVvWymENBRk+UVqgveL/mkO4Q8hYK
 UEf5mwpt6da3E20TPHtUhugunmGsxUAHd1KHIUS6guA167V6AaxHXUfQ3hKb9lOiSMtbWV0j
 BnTxYqvXGEx9u3OIZ6AyluKhT3pejEREHdbXwkrFC1cx9DloZ48gDuaG76PD5WJptHyHDjxx
 RWDoy4/m6gfgKY36kmrwbzUq2nz/saRH2bZ8i2SBzj/tlooO+ZJcqTxsQCDhcusOrp1WbVoU
 JIsoMOZ8PwVRa+EkCiAUY3h95n4uq7bblUwbbNpdqTNFghBGVb/Iui8AxkkfS+F1/ronxezP
 Cc/XisKvPdu0IOCN/MfXm5II51CIVLcPdrkTOvISdFFf4J8cgSKlAk3OxXMjzy0zxh0yvxuU
 Xt+TSpKJSxGYUiA5GHuL9rxLJdxnnxurY8tbcCTI+ubPUq2OyfOFOZt3KqmZeEl9qKUyDg5A
 P4EX/ZmPy53CbWkCgGOqNZ7BQlTcRATWMCnw+QKJ7XrClc3Rwkc5wr5nOpJl3pNxP8OyI8lP
 xiVBydl9bYIrSSWcFvQMik+MO+HsFQWhStTABHA9G2AgxALCbtDJo9GH3fuVbV4puFl09BuS
 PwJJ5eJDvhVE2yV8DUBd5jt6odlcU3z1w6JOiOkZhk5foJhGFOVqoO1IFO3+XlcFDezuOs/v
 6akilHRT60cSlkwF83Rcv+ukQ+85CBPhOJoUkLUCdBPY0GwopNyIin8g6ZvccEBIBnO3BWA0
 AOSDUtKrOXBudZtotLImbqFv8GiFO4nRhhWGGzS7LCXMyjG/zX8nd8cAbjQJT2EDTH64qSvY
 +lR3srQCvxfkQYYqZd4HpZq0bk6u4nlqYhFw1k2B37MdVmqVO9teyHUwclVu6RR7bZFog/qC
 FmX89xXNLjVasPoFFkdeFgsYuiZjKxGnzDT6bI+IVng5T8x972CCB0AMx6JgS1bDb10LIJ6n
 rtx5J9Is1Sy2kgwL9KLriFI7GDdfHUPXpIuuoweHIK22BEgzUtPYMCEByL7iH1Vhw6g7qX+z
 ueouZf/
IronPort-HdrOrdr: A9a23:YzSfE6ljPtNM2bxtlocEAke+QtfpDfIW3DAbv31ZSRFFG/Fxl6
 iV/cjzsiWE8Qr5OUtQ4uxoV5PwIk80maQb3WBVB8bHYOCEghrPEGgB1/qB/9SIIUSXnYQxuZ
 uIMZIOb+EYZWIK9foSizPZLz9P+re6GdiT9ILj80s=
X-IronPort-AV: E=Sophos;i="5.87,172,1631592000"; 
   d="scan'208";a="55807252"
From: Lin Liu <lin.liu@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Lin Liu <lin.liu@citrix.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
	Jan Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>, "Stefano
 Stabellini" <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
Subject: [PATCH v2 2/7] crypto/vmac: Simplify code with byteswap.h
Date: Fri, 22 Oct 2021 10:47:23 +0000
Message-ID: <97aca2e39ff1eefdab1e0b3440929958e4b99892.1634897942.git.lin.liu@citrix.com>
X-Mailer: git-send-email 2.27.0
In-Reply-To: <cover.1634897942.git.lin.liu@citrix.com>
References: <cover.1634897942.git.lin.liu@citrix.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

This file has its own implementation of swap bytes. Clean up
the code with xen/byteswap.h.

No functional change.

Signed-off-by: Lin Liu <lin.liu@citrix.com>
---
Cc: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: George Dunlap <george.dunlap@citrix.com>
Cc: Ian Jackson <iwj@xenproject.org>
Cc: Jan Beulich <jbeulich@suse.com>
Cc: Julien Grall <julien@xen.org>
Cc: Stefano Stabellini <sstabellini@kernel.org>
Cc: Wei Liu <wl@xen.org>
---
 xen/crypto/vmac.c | 76 ++---------------------------------------------
 1 file changed, 3 insertions(+), 73 deletions(-)

diff --git a/xen/crypto/vmac.c b/xen/crypto/vmac.c
index 294dd16a52..acb4e015f5 100644
--- a/xen/crypto/vmac.c
+++ b/xen/crypto/vmac.c
@@ -8,6 +8,7 @@
 
 /* start for Xen */
 #include <xen/init.h>
+#include <xen/byteswap.h>
 #include <xen/types.h>
 #include <xen/lib.h>
 #include <crypto/vmac.h>
@@ -50,7 +51,6 @@ const uint64_t mpoly = UINT64_C(0x1fffffff1fffffff);  /* Poly key mask     */
  * MUL64: 64x64->128-bit multiplication
  * PMUL64: assumes top bits cleared on inputs
  * ADD128: 128x128->128-bit addition
- * GET_REVERSED_64: load and byte-reverse 64-bit word  
  * ----------------------------------------------------------------------- */
 
 /* ----------------------------------------------------------------------- */
@@ -68,22 +68,6 @@ const uint64_t mpoly = UINT64_C(0x1fffffff1fffffff);  /* Poly key mask     */
 
 #define PMUL64 MUL64
 
-#define GET_REVERSED_64(p)                                                \
-    ({uint64_t x;                                                         \
-     asm ("bswapq %0" : "=r" (x) : "0"(*(uint64_t *)(p))); x;})
-
-/* ----------------------------------------------------------------------- */
-#elif (__GNUC__ && __i386__)
-/* ----------------------------------------------------------------------- */
-
-#define GET_REVERSED_64(p)                                                \
-    ({ uint64_t x;                                                        \
-    uint32_t *tp = (uint32_t *)(p);                                       \
-    asm  ("bswap %%edx\n\t"                                               \
-          "bswap %%eax"                                                   \
-    : "=A"(x)                                                             \
-    : "a"(tp[1]), "d"(tp[0]));                                            \
-    x; })
 
 /* ----------------------------------------------------------------------- */
 #elif (__GNUC__ && __ppc64__)
@@ -103,37 +87,6 @@ const uint64_t mpoly = UINT64_C(0x1fffffff1fffffff);  /* Poly key mask     */
 
 #define PMUL64 MUL64
 
-#define GET_REVERSED_64(p)                                                \
-    ({ uint32_t hi, lo, *_p = (uint32_t *)(p);                            \
-       asm volatile ("lwbrx %0, %1, %2" : "=r"(lo) : "b%"(0), "r"(_p) );  \
-       asm volatile ("lwbrx %0, %1, %2" : "=r"(hi) : "b%"(4), "r"(_p) );  \
-       ((uint64_t)hi << 32) | (uint64_t)lo; } )
-
-/* ----------------------------------------------------------------------- */
-#elif (__GNUC__ && (__ppc__ || __PPC__))
-/* ----------------------------------------------------------------------- */
-
-#define GET_REVERSED_64(p)                                                \
-    ({ uint32_t hi, lo, *_p = (uint32_t *)(p);                            \
-       asm volatile ("lwbrx %0, %1, %2" : "=r"(lo) : "b%"(0), "r"(_p) );  \
-       asm volatile ("lwbrx %0, %1, %2" : "=r"(hi) : "b%"(4), "r"(_p) );  \
-       ((uint64_t)hi << 32) | (uint64_t)lo; } )
-
-/* ----------------------------------------------------------------------- */
-#elif (__GNUC__ && (__ARMEL__ || __ARM__))
-/* ----------------------------------------------------------------------- */
-
-#define bswap32(v)                                                        \
-({ uint32_t tmp,out;                                                      \
-    asm volatile(                                                         \
-        "eor    %1, %2, %2, ror #16\n"                                    \
-        "bic    %1, %1, #0x00ff0000\n"                                    \
-        "mov    %0, %2, ror #8\n"                                         \
-        "eor    %0, %0, %1, lsr #8"                                       \
-    : "=r" (out), "=&r" (tmp)                                             \
-    : "r" (v));                                                           \
-    out;})
-
 /* ----------------------------------------------------------------------- */
 #elif _MSC_VER
 /* ----------------------------------------------------------------------- */
@@ -154,11 +107,6 @@ const uint64_t mpoly = UINT64_C(0x1fffffff1fffffff);  /* Poly key mask     */
         (rh) += (ih) + ((rl) < (_il));                               \
     }
 
-#if _MSC_VER >= 1300
-#define GET_REVERSED_64(p) _byteswap_uint64(*(uint64_t *)(p))
-#pragma intrinsic(_byteswap_uint64)
-#endif
-
 #if _MSC_VER >= 1400 && \
     (!defined(__INTEL_COMPILER) || __INTEL_COMPILER >= 1000)
 #define MUL32(i1,i2)    (__emulu((uint32_t)(i1),(uint32_t)(i2)))
@@ -219,24 +167,6 @@ const uint64_t mpoly = UINT64_C(0x1fffffff1fffffff);  /* Poly key mask     */
     }
 #endif
 
-#ifndef GET_REVERSED_64
-#ifndef bswap64
-#ifndef bswap32
-#define bswap32(x)                                                        \
-  ({ uint32_t bsx = (x);                                                  \
-      ((((bsx) & 0xff000000u) >> 24) | (((bsx) & 0x00ff0000u) >>  8) |    \
-       (((bsx) & 0x0000ff00u) <<  8) | (((bsx) & 0x000000ffu) << 24)); })
-#endif
-#define bswap64(x)                                                        \
-     ({ union { uint64_t ll; uint32_t l[2]; } w, r;                       \
-         w.ll = (x);                                                      \
-         r.l[0] = bswap32 (w.l[1]);                                       \
-         r.l[1] = bswap32 (w.l[0]);                                       \
-         r.ll; })
-#endif
-#define GET_REVERSED_64(p) bswap64(*(uint64_t *)(p)) 
-#endif
-
 /* ----------------------------------------------------------------------- */
 
 #if (VMAC_PREFER_BIG_ENDIAN)
@@ -247,9 +177,9 @@ const uint64_t mpoly = UINT64_C(0x1fffffff1fffffff);  /* Poly key mask     */
 
 #if (VMAC_ARCH_BIG_ENDIAN)
 #  define get64BE(ptr) (*(uint64_t *)(ptr))
-#  define get64LE(ptr) GET_REVERSED_64(ptr)
+#  define get64LE(ptr) bswap64(*(uint64_t *)(ptr))
 #else /* assume little-endian */
-#  define get64BE(ptr) GET_REVERSED_64(ptr)
+#  define get64BE(ptr) bswap64(*(uint64_t *)(ptr))
 #  define get64LE(ptr) (*(uint64_t *)(ptr))
 #endif
 
-- 
2.27.0



From xen-devel-bounces@lists.xenproject.org Fri Oct 22 10:48:28 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Oct 2021 10:48:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.214955.373899 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mds68-0000EL-5l; Fri, 22 Oct 2021 10:48:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 214955.373899; Fri, 22 Oct 2021 10:48:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mds68-0000D6-0z; Fri, 22 Oct 2021 10:48:28 +0000
Received: by outflank-mailman (input) for mailman id 214955;
 Fri, 22 Oct 2021 10:48:26 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=h+2b=PK=citrix.com=lin.liu@srs-us1.protection.inumbo.net>)
 id 1mds66-00063m-Sr
 for xen-devel@lists.xenproject.org; Fri, 22 Oct 2021 10:48:26 +0000
Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 28c6be87-f6ea-42ef-9151-413cd568356b;
 Fri, 22 Oct 2021 10:48:08 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 28c6be87-f6ea-42ef-9151-413cd568356b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1634899688;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=k/jOhLHPZRA8Ag0Zx9f8hcyG0uLCD9lIG9NbqTmotxQ=;
  b=P5LLaymYDDd7YPzHgw8VO//tiGscp2o2P63uah3hGxrvsMT55ARBFp/p
   9vY++0HNE+WxlPloQuix8r0ZSKovztZH3SQURBpBSCitVnWMzF8/t5gji
   o5PNHYYJU8oLOkSz4/gkHNbReHFwYtR4FnEcJHreivFJ12K1q0Nu9die6
   Q=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: FVYnoo/wTcjQj0Hr19f8bSUOfLUjj69j01RWR4xcgBFEKEIcjAhmQYdt6l3l+wjkD6bnW9NPSo
 RCKh2amD6+7hRLEkbwzHJgxBzhwDseJ7E0zbajPN+p73WzP9ErRyq8ztPTUa9rOajkNVLfTE51
 OweUEt8q13ibX5emWvJ2XXWdP8ck9PQCqaX1C2+RwTdBEB/B9t7CQF8ESe24tWbpeluKD/QS3q
 jsBtQgykNf6n/q/n5xcvJlskC5/Rw8Jz2G5lWc+SB1kokBJVWhLrKC8EZolGDmtlbw/Aopu+nB
 lBxSz3aKH919eiSMYH/tCb+6
X-SBRS: 5.1
X-MesageID: 55807254
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:7ljUfaiBYtUcWl1AmEunBh4yX1615BcKZh0ujC45NGQN5FlHY01je
 htvWGyAPPzbZWuhf99xbdu1o08H6JSBmIc1QARv+XtkFyIb9cadCdqndUqhZCn6wu8v7a5EA
 2fyTvGacajYm1eF/k/F3oAMKRCQ7InQLlbGILes1htZGEk0F0/NtTo5w7Rg29Yy24Dja++wk
 YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq
 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx
 /1D7t+pTToxZ5fqt707Cj1RFSBhMqNvreqvzXiX6aR/zmXDenrohf5vEFs3LcsT/eMf7WNmr
 KJCbmpXN1ba2rzwkOnTpupE36zPKOHvPYVZvnB95TrYEewnUdbIRKCiCdpwgWpg3p8UQKq2i
 8wxWGssbAnGOExzGVoFJ88En+KlnVTSfGgNwL6SjfVuuDWCpOBr65D2K8bccNGOQcRTn26bq
 3jA8mC/BQsVXPSd1D6E/3SEluLJ2yThV+o6C7mQ5vNsxlqJyQQ7GBAQEFe2v/S9okq/QM5Eb
 VwZ/DI0qqo//1DtScPyNzW5v3ysrhMaQ8BXEeAx9EeK0KW8ywSTC3UATzVBQMc7r8JwTjsvv
 mJlhPuwW2Yp6ufMDyvAqPHE9lteJBT5M0cMPmwdSTYduuPFj9gV1zbGSNd8H6Cc24id9S7L/
 xiGqy03hrM2hMEN1rmm8V2vvw9AtqQlXSZuuV2JBjPNAhdRIdf/PdTxuAezAeNodd7BFjG8U
 G44d99yBQzkJaqGkzCRW60zFbWt6uft3Nb00AM3QcdJG9hA/ReekWFsDNNWeBgB3iUsI2aBj
 KrvVeV5vsM70JyCNvcfXm5JI552pZUM7Py8PhwuUvJAY4JqaCiM9zx0aEib0gjFyRZ3zfFjY
 MjLKZ3xXB727JiLKhLsG4/xNpdwnkgDKZ77H8inn3xLL5LODJJqdVv1GATXNb1ohE91iA7U7
 8xeJ6O3J+Z3C4XDjt3s2ddLdzgidCFjbbiv8pA/XrPTc2JORTB6Y9eMkOxJRmCQt/kM/gs+1
 irmAREwJZuWrSCvFDhmnVg6OeqxB84m8CpnVcHuVH7xs0UejU+UxP93X/MKkXMPrYSPFNZ4E
 KsIfduuGPNKRmiV8jgRd8Cl/odjaA6qlUSFOC/8OGozeJtpRgro/N74f1SwqHlSX3Tv7cZu8
 ae90g77QIYYQ1gwBsjhd//ynUi6umIQmbwuUhKQcMVTYkjl7KNjNzf10q0sO8gJJBianmma2
 g+aDA02v+7Ip4NpotDFibrd99WiEvdkH1ocFG7etO7kOS7f92ul4IlBTOfXImyNCDKqoP2vP
 LwHwev9PfsLmEdxn7B9S7s7n7gj49bPpqNBylg2Fnv8cFn2WKhrJWOL3JcTu/QVlKNZowa/R
 mmG5sJeZeeSIMrgHVMceFglY+CE2a1GkzXe961ockDz5Ssx97ubS0RCeRKLjXUFfrdyNYokx
 8YnudIXtFPj2kZ7bI7eg3AG7XmII1wBT74j58MTD4LcgwY2zk1PPM7HASjs7ZDTM9hBPyHG+
 NNPaHYuU1iE+nf/Tg==
IronPort-HdrOrdr: A9a23:Rh3HMaB6h2VVMLvlHemW55DYdb4zR+YMi2TC1yhKKCC9Ffbo7/
 xG/c5rrCMc5wxhO03I9eruBEDEewK5yXcX2/h2AV7BZniFhILAFugLhuGOrwEIWReOkdK1vZ
 0QCJSWY+eRMbEVt6jHCXGDYrMd/OU=
X-IronPort-AV: E=Sophos;i="5.87,172,1631592000"; 
   d="scan'208";a="55807254"
From: Lin Liu <lin.liu@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Lin Liu <lin.liu@citrix.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
	Jan Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>, "Stefano
 Stabellini" <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>
Subject: [PATCH v2 6/7] xen: Switch to byteswap.h
Date: Fri, 22 Oct 2021 10:47:27 +0000
Message-ID: <f5a79881bfdcef06aa950632250f551e0ec26458.1634897942.git.lin.liu@citrix.com>
X-Mailer: git-send-email 2.27.0
In-Reply-To: <cover.1634897942.git.lin.liu@citrix.com>
References: <cover.1634897942.git.lin.liu@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

Update to use byteswap.h to swap bytes.

No functional chagne.

Signed-off-by: Lin Liu <lin.liu@citrix.com>
---
Cc: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: George Dunlap <george.dunlap@citrix.com>
Cc: Ian Jackson <iwj@xenproject.org>
Cc: Jan Beulich <jbeulich@suse.com>
Cc: Julien Grall <julien@xen.org>
Cc: Stefano Stabellini <sstabellini@kernel.org>
Cc: Wei Liu <wl@xen.org>
Cc: "Roger Pau Monné" <roger.pau@citrix.com>
---
 xen/common/bitmap.c                |  2 +-
 xen/common/gdbstub.c               |  2 +-
 xen/common/libelf/libelf-private.h |  8 ++++----
 xen/common/lz4/defs.h              |  2 +-
 xen/common/lzo.c                   |  2 +-
 xen/common/unlzo.c                 |  2 +-
 xen/common/xz/private.h            |  4 ++--
 xen/drivers/char/ehci-dbgp.c       |  2 +-
 xen/include/asm-x86/msi.h          |  2 +-
 xen/include/xen/bitmap.h           |  2 +-
 xen/include/xen/device_tree.h      |  2 +-
 xen/include/xen/unaligned.h        | 14 +++++++-------
 xen/lib/divmod.c                   |  2 +-
 13 files changed, 23 insertions(+), 23 deletions(-)

diff --git a/xen/common/bitmap.c b/xen/common/bitmap.c
index 7d4551f782..be274ca04a 100644
--- a/xen/common/bitmap.c
+++ b/xen/common/bitmap.c
@@ -9,10 +9,10 @@
 #include <xen/errno.h>
 #include <xen/bitmap.h>
 #include <xen/bitops.h>
+#include <xen/byteswap.h>
 #include <xen/cpumask.h>
 #include <xen/guest_access.h>
 #include <xen/lib.h>
-#include <asm/byteorder.h>
 
 /*
  * bitmaps provide an array of bits, implemented using an an
diff --git a/xen/common/gdbstub.c b/xen/common/gdbstub.c
index 848c1f4327..3c8ed52d6b 100644
--- a/xen/common/gdbstub.c
+++ b/xen/common/gdbstub.c
@@ -33,6 +33,7 @@
 /* Resuming after we've stopped used to work, but more through luck
    than any actual intention.  It doesn't at the moment. */
 
+#include <xen/byteswap.h>
 #include <xen/lib.h>
 #include <xen/spinlock.h>
 #include <xen/serial.h>
@@ -45,7 +46,6 @@
 #include <xen/console.h>
 #include <xen/errno.h>
 #include <xen/delay.h>
-#include <asm/byteorder.h>
 
 /* Printk isn't particularly safe just after we've trapped to the
    debugger. so avoid it. */
diff --git a/xen/common/libelf/libelf-private.h b/xen/common/libelf/libelf-private.h
index 47db679966..b7089cb31b 100644
--- a/xen/common/libelf/libelf-private.h
+++ b/xen/common/libelf/libelf-private.h
@@ -17,10 +17,10 @@
 
 #ifdef __XEN__
 
+#include <xen/byteswap.h>
 #include <xen/lib.h>
 #include <xen/libelf.h>
 #include <xen/softirq.h>
-#include <asm/byteorder.h>
 #include <public/elfnote.h>
 
 /* we would like to use elf->log_callback but we can't because
@@ -31,9 +31,9 @@
    printk(fmt, ## args )
 
 #define strtoull(str, end, base) simple_strtoull(str, end, base)
-#define bswap_16(x) swab16(x)
-#define bswap_32(x) swab32(x)
-#define bswap_64(x) swab64(x)
+#define bswap_16(x) bswap16(x)
+#define bswap_32(x) bswap32(x)
+#define bswap_64(x) bswap64(x)
 
 #else /* !__XEN__ */
 
diff --git a/xen/common/lz4/defs.h b/xen/common/lz4/defs.h
index 10609f5a53..1ce4476478 100644
--- a/xen/common/lz4/defs.h
+++ b/xen/common/lz4/defs.h
@@ -9,7 +9,7 @@
  */
 
 #ifdef __XEN__
-#include <asm/byteorder.h>
+#include <xen/byteswap.h>
 #include <asm/unaligned.h>
 #else
 
diff --git a/xen/common/lzo.c b/xen/common/lzo.c
index a87c76dded..17be9675f4 100644
--- a/xen/common/lzo.c
+++ b/xen/common/lzo.c
@@ -96,7 +96,7 @@
 
 #ifdef __XEN__
 #include <xen/lib.h>
-#include <asm/byteorder.h>
+#include <xen/byteswap.h>
 #include <asm/unaligned.h>
 #else
 #define get_unaligned_le16(_p) (*(u16 *)(_p))
diff --git a/xen/common/unlzo.c b/xen/common/unlzo.c
index 74056778eb..f908d2a61f 100644
--- a/xen/common/unlzo.c
+++ b/xen/common/unlzo.c
@@ -33,7 +33,7 @@
 #include <xen/lzo.h>
 
 #ifdef __XEN__
-#include <asm/byteorder.h>
+#include <xen/byteswap.h>
 #include <asm/unaligned.h>
 #else
 
diff --git a/xen/common/xz/private.h b/xen/common/xz/private.h
index 511343fcc2..647f9699a7 100644
--- a/xen/common/xz/private.h
+++ b/xen/common/xz/private.h
@@ -12,7 +12,7 @@
 
 #ifdef __XEN__
 #include <xen/kernel.h>
-#include <asm/byteorder.h>
+#include <xen/byteswap.h>
 #include <asm/unaligned.h>
 #else
 
@@ -28,7 +28,7 @@ static inline void put_unaligned_le32(u32 val, void *p)
 
 #endif
 
-#define get_le32(p) le32_to_cpup((const uint32_t *)(p))
+#define get_le32(p) le32_to_cpu(*(const uint32_t *)(p))
 
 #define false 0
 #define true 1
diff --git a/xen/drivers/char/ehci-dbgp.c b/xen/drivers/char/ehci-dbgp.c
index c893d246de..8412da1b11 100644
--- a/xen/drivers/char/ehci-dbgp.c
+++ b/xen/drivers/char/ehci-dbgp.c
@@ -5,13 +5,13 @@
  * Linux; see the Linux source for authorship and copyrights.
  */
 
+#include <xen/byteswap.h>
 #include <xen/console.h>
 #include <xen/delay.h>
 #include <xen/errno.h>
 #include <xen/param.h>
 #include <xen/pci.h>
 #include <xen/serial.h>
-#include <asm/byteorder.h>
 #include <asm/io.h>
 #include <asm/fixmap.h>
 #include <public/physdev.h>
diff --git a/xen/include/asm-x86/msi.h b/xen/include/asm-x86/msi.h
index e228b0f3f3..277375183c 100644
--- a/xen/include/asm-x86/msi.h
+++ b/xen/include/asm-x86/msi.h
@@ -1,9 +1,9 @@
 #ifndef __ASM_MSI_H
 #define __ASM_MSI_H
 
+#include <xen/byteswap.h>
 #include <xen/cpumask.h>
 #include <xen/pci.h>
-#include <asm/byteorder.h>
 #include <asm/hvm/vmx/vmcs.h>
 
 /*
diff --git a/xen/include/xen/bitmap.h b/xen/include/xen/bitmap.h
index e9175ab54a..c44a1cb63c 100644
--- a/xen/include/xen/bitmap.h
+++ b/xen/include/xen/bitmap.h
@@ -229,7 +229,7 @@ static inline int bitmap_weight(const unsigned long *src, int nbits)
 	return __bitmap_weight(src, nbits);
 }
 
-#include <asm/byteorder.h>
+#include <xen/byteswap.h>
 
 #ifdef __LITTLE_ENDIAN
 #define BITMAP_MEM_ALIGNMENT 8
diff --git a/xen/include/xen/device_tree.h b/xen/include/xen/device_tree.h
index fd6cd00b43..4921e6b142 100644
--- a/xen/include/xen/device_tree.h
+++ b/xen/include/xen/device_tree.h
@@ -10,10 +10,10 @@
 #ifndef __XEN_DEVICE_TREE_H__
 #define __XEN_DEVICE_TREE_H__
 
-#include <asm/byteorder.h>
 #include <asm/device.h>
 #include <public/xen.h>
 #include <public/device_tree_defs.h>
+#include <xen/byteswap.h>
 #include <xen/kernel.h>
 #include <xen/string.h>
 #include <xen/types.h>
diff --git a/xen/include/xen/unaligned.h b/xen/include/xen/unaligned.h
index 0a2b16d05d..8a9ec8a0ac 100644
--- a/xen/include/xen/unaligned.h
+++ b/xen/include/xen/unaligned.h
@@ -11,8 +11,8 @@
 #define __XEN_UNALIGNED_H__
 
 #ifdef __XEN__
+#include <xen/byteswap.h>
 #include <xen/types.h>
-#include <asm/byteorder.h>
 #endif
 
 #define get_unaligned(p) (*(p))
@@ -20,7 +20,7 @@
 
 static inline uint16_t get_unaligned_be16(const void *p)
 {
-	return be16_to_cpup(p);
+	return be16_to_cpu(*(uint16_t*)p);
 }
 
 static inline void put_unaligned_be16(uint16_t val, void *p)
@@ -30,7 +30,7 @@ static inline void put_unaligned_be16(uint16_t val, void *p)
 
 static inline uint32_t get_unaligned_be32(const void *p)
 {
-	return be32_to_cpup(p);
+	return be32_to_cpu(*(uint32_t*)p);
 }
 
 static inline void put_unaligned_be32(uint32_t val, void *p)
@@ -40,7 +40,7 @@ static inline void put_unaligned_be32(uint32_t val, void *p)
 
 static inline uint64_t get_unaligned_be64(const void *p)
 {
-	return be64_to_cpup(p);
+	return be64_to_cpu(*(uint64_t*)p);
 }
 
 static inline void put_unaligned_be64(uint64_t val, void *p)
@@ -50,7 +50,7 @@ static inline void put_unaligned_be64(uint64_t val, void *p)
 
 static inline uint16_t get_unaligned_le16(const void *p)
 {
-	return le16_to_cpup(p);
+	return le16_to_cpu(*(uint16_t*)p);
 }
 
 static inline void put_unaligned_le16(uint16_t val, void *p)
@@ -60,7 +60,7 @@ static inline void put_unaligned_le16(uint16_t val, void *p)
 
 static inline uint32_t get_unaligned_le32(const void *p)
 {
-	return le32_to_cpup(p);
+	return le32_to_cpu(*(uint32_t*)p);
 }
 
 static inline void put_unaligned_le32(uint32_t val, void *p)
@@ -70,7 +70,7 @@ static inline void put_unaligned_le32(uint32_t val, void *p)
 
 static inline uint64_t get_unaligned_le64(const void *p)
 {
-	return le64_to_cpup(p);
+	return le64_to_cpu(*(uint64_t*)p);
 }
 
 static inline void put_unaligned_le64(uint64_t val, void *p)
diff --git a/xen/lib/divmod.c b/xen/lib/divmod.c
index 0be6ccc700..dfc1129cfe 100644
--- a/xen/lib/divmod.c
+++ b/xen/lib/divmod.c
@@ -1,6 +1,6 @@
+#include <xen/byteswap.h>
 #include <xen/lib.h>
 #include <xen/types.h>
-#include <asm/byteorder.h>
 
 /*
  * A couple of 64 bit operations ported from FreeBSD.
-- 
2.27.0



From xen-devel-bounces@lists.xenproject.org Fri Oct 22 11:26:27 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Oct 2021 11:26:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.215012.373925 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdsge-000640-Ja; Fri, 22 Oct 2021 11:26:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 215012.373925; Fri, 22 Oct 2021 11:26:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdsge-00063s-GU; Fri, 22 Oct 2021 11:26:12 +0000
Received: by outflank-mailman (input) for mailman id 215012;
 Fri, 22 Oct 2021 11:26:11 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=OBiv=PK=citrix.com=Andrew.Cooper3@srs-us1.protection.inumbo.net>)
 id 1mdsgd-00063m-Sg
 for xen-devel@lists.xenproject.org; Fri, 22 Oct 2021 11:26:11 +0000
Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id b4ebca68-5d81-4002-8bbf-538943c4274f;
 Fri, 22 Oct 2021 11:26:09 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b4ebca68-5d81-4002-8bbf-538943c4274f
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1634901969;
  h=subject:to:cc:references:from:message-id:date:
   in-reply-to:content-transfer-encoding:mime-version;
  bh=AAfPA40WOWEyya45gGTieJLd1u4lWcvP3ksEUlvRzfs=;
  b=a2QzHudWGKGjq+ha1Kz8Mx9B4eZWcv8uYodAaOgggrxv5loxX1vwMafz
   gV7EyDgDfjvYsTF/QoC71c/HLmRtSUMdTK0F3IHabp9bvv2vLYA1FE8Ks
   Hq7OuXbQCcti3zbbDuTkbjhIRaFHJWfv9xCSHoFJLe75Qrkp1gDM+MaU/
   4=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: DW9A3j3vcSOHlS8ptH3kp97QhuS52lX3yuuxgzsXRm4/HtnBEv7g3AtG/oLmENFIBhw9QM04pQ
 ymT9PRXb/SVrMiGRoDUJhHjiuwcb4RKNLDEPl1hz0Os+E8YhW3gxhPG30WoWJxDp3pF7wxJcQp
 Gr8FKW51SC8mcNRvYejvQ+1Z/u1faKT9q6O1cUAPEFVKCdi9Z1GdjLI4CVhcle0xC3ZlKP5/84
 qM1vfjGFW44gc9WD1/3W8UdWdCgrZ1voPIxcwyLtztrOJvF1F9KZ9glZcaqouQvZr5dB2SBzry
 yZzDGhyAvJQHW0mcCJNT+oFo
X-SBRS: 5.1
X-MesageID: 57735148
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:0l0I7Klc4lvZhidZVkN/C1/o5gwbIURdPkR7XQ2eYbSJt1+Wr1Gzt
 xIaWGqEbvqKMWL1L9gkbty38RkHscfWn9BnSwBqpH9hRCMWpZLJC+rCIxarNUt+DCFioGGLT
 Sk6QoOdRCzhZiaE/n9BClVlxJVF/fngqoDUUYYoAQgsA187IMsdoUg7wbdg2tQy2YLR7z6l4
 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc
 s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4
 ItdsZbsezwkAoP3t8gTYiZ5CAp5NrITrdcrIVDn2SCS50jPcn+qyPRyFkAme4Yf/46bA0kXq
 6ZecmpUKEne2aTmm9pXScE17ignBODtMJkSpTdLyjbBAOx9aZvCX7/L9ZlT2zJYasVmQKmBP
 JdANWoHgBLoRRFOO0k0B4MFvOaYuUnkS2129WLPqv9ii4TU5FMoi+W8WDbPQfSIT8hImkeTp
 krd4n/0RBodMbS3yCWH2mKhgPfVmiH2U55UE6e3ntZ6jVvWymENBRk+UVqgveL/mkO4Q8hYK
 UEf5mwpt6da3FOvZsnwWVu/unHslgUHR9NaHuk+6QeM4qnZ+QCUAi4DVDEpQN47sM47QxQ62
 1nPmMnmbQGDq5XMFyjbrO3N62rvZ25FdgfueBPoUyNb893p/LMIgy7hdflPHp+Kr8beHjrvl
 mXiQDcFu50fissC1qOe9F/Bgi6xqpWhcjPZ9jk7TUr+sVsnPN/Ni5iArAGBt64Zfdnxokyp5
 SBcw6CjAPYy4YZhfcBnaN4GG621/L67OTnYjE8H83IJpmn1pSDLkWy95lhDyKZV3iQsJWCBj
 Kz741o5CHpv0J2CN/Mfj2WZUJxC8EQYPY65Ps04l/IXCnSLSCeJ/Tt1eWmb1H33nU4nnMkXY
 MnALZbwVClKUf86nVJaotvxN5dxmkjSIkuIHfjGI+mPi+LCNBZ5t59VWLdxUgzJxPzd+1iEm
 zquH8CL1w9eQIXDjtr/quYuwaQxBSFjX/je8pUPHsbae1YOMDxxWpf5nOJ6E6Q4zvs9qws91
 izkMqOu4AGk3iOvxMTjQi0LVY4Dqr4m/CtlZ3R1YA70s5XhCK72hJoim1IMVeBP3MRozOJuT
 ulDfMOFA/9VTS/A9ShbZp74xLGOvjzy7e5XFyb6MjU5YbB6QAnFpo3tcgf1rXFcBSurr8ou5
 ban01qDE5YEQg1jCufQae6ukAzt7SRMxroqUhuaOMRXdWXt7JNud377gMgoLpxeMh7E3Dabi
 VqbWE9KuenXroYp29DVnqTY/ZyxGu5zExMCTWnW5Lq7LwfA+W+nzdMSWeqEZ2mFBmj15L+jd
 aNeyPSlaK8Lm1NDsoxdFbd3zP1hu4uz9uEClgk9RSfFdVWmDL9kM0Kq58gXu/0f3KJdtCu3R
 lmLpotQN4KWNZ63C1UWPgckMLiOjKlGhjnI4P0pC0zm/ysrrqGfWEBfMhTQ2ixQKLx5bNEsz
 es74ZNE7gW+jlwhM8qcjzAS/GOJdyRSX6Iiv5AcIYnqlgt0lQ0SPc2CUnf7sMOVdtFBEkg2O
 TvF1qPNioNVylfGb3duR2PG2vBQhMhWtR1HpLPYy49lRjYRaicL4SBs
IronPort-HdrOrdr: A9a23:B+dYxaMTcWctBcBcT1H155DYdb4zR+YMi2TDiHofdfUFSKClfp
 6V8cjztSWUtN4QMEtQ/exoS5PwPk80kqQFnbX5XI3SITUO3VHHEGgM1/qb/9SNIVyZygcZ79
 YbT0EcMqyBMbEZt7eC3ODQKb9Jq7PmgcPY9ts2jU0dKj2CA5sQnjuRYTzrcHGeKjM2YKbRWK
 Dsnfau8FGbCAoqh4mAdzQ4dtmGg+eOuIPtYBYACRJiwA6SjQmw4Lq/NxSDxB8RXx5G3L9nqA
 H+4kPEz5Tml8v+5g7X1mfV4ZgTsNz9yuFbDMjJrsQOMD3jhiuheYwkcbyfuzIepv2p9T8R4Z
 XxiiZlG/42x2Laf2mzrxeo8w780Aw243un8lOciWuLm72weBsKT+56wa5JeBrQ7EQt+Ptm1r
 hQ4m6fv51LSTvdgSXU/bHzJlFXv3vxhUBnvf8YjnRZX4dbQqRWt5Yj8ERcF4pFND7m6bogDP
 JlAKjnlbdrmGuhHjLkV1RUsZmRtixZJGbDfqFCgL3a79FupgE786NCr/Zv2Uvp9/oGOtB5Dq
 r/Q+JVfYp1P7orhJRGdZE8qPuMex7wqC33QRavyHTcZeo60iH22tTKCItc3pDcRHVP9upqpK
 j8
X-IronPort-AV: E=Sophos;i="5.87,172,1631592000"; 
   d="scan'208";a="57735148"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=SFFGfUzVVNhSplFmtHsomSoR6yiOSCDinn5mZ6n2uBQWFIADi3WsioMp7ZD3Dnc7PxuUogrZfC8JZ2X7tmr9MGNaH7wVUENZNlbxPg/4BEHANB+zSJj55gMoZzg/JRkwpRVrSZ9E/5FqmcW0F3Jc4e5ltyQA+PXBNwJen3byEprpt9a2ZKj5sL60BLSRJLbJ0gQVGz8UXauosGhKXteAnauWZQcaJo97ZGwr/XGq5bYsb8R+kziPfJHLZFXPKQvXLBBmSJ6t+tDbt/s30G7GHWZ2AMGTliMQZhj4CVeZbGdOWy9/1ipLid/Li9xEhYOwduHRb+nG5mhcmmXL3L6n9A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=jtw8hog5odKGwwLZXc8eLTsw5rnuoGxyp3I0UIwMhwI=;
 b=fGzSham7QhFjuFmijHKzC8slVckMTIGMRqLskjQgTL2FUm0mkTiasrtohPsUIikIE1yEKEl1o84EnxaUO+jK7kijgtXSAbD/b17CAoirTN23ft9Nq+5qs1fcLnLzLNlKkGS/9PGXZiPAxgBZj2PK9Qh8lXQysgYQk8GnvqJnfjO+XH6cOFjaYjXR5iBaNkAlFTyYmOYKeEIK6Xm/fMLikYTYoY6/rkywtJgd5s6KjmwCEkbbxaINZ72hpa2HrU217EHNz7QAN1GynheHbdPUoqE1ISbb4kBNcZ/k1d5P/pDDO+D/RL0Kdyiopf71ztq85LnrdnW9MP7DuJUutu8Wuw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=jtw8hog5odKGwwLZXc8eLTsw5rnuoGxyp3I0UIwMhwI=;
 b=Z9wz6lLgLlAhQ1xBNf5zm7Nnxe7xUmI3TPIDlFjO/kItfAsDy4eLlp1fDsSl5saZCaspF3tOhTGJ+zJdg6eUjACDOzqq85yQ1TiVU5MOtGT7PdM5ZTJYqWfv3ZD9XNOrSo31Qy9mgzUWYjMaeh3O9xHMRV8CJTP9DT/lzu6w/tI=
Subject: Re: [PATCH v2 6/7] xen: Switch to byteswap.h
To: Lin Liu <lin.liu@citrix.com>, <xen-devel@lists.xenproject.org>
CC: George Dunlap <george.dunlap@citrix.com>, Ian Jackson
	<iwj@xenproject.org>, Jan Beulich <jbeulich@suse.com>, Julien Grall
	<julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>, Wei Liu
	<wl@xen.org>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <cover.1634897942.git.lin.liu@citrix.com>
 <f5a79881bfdcef06aa950632250f551e0ec26458.1634897942.git.lin.liu@citrix.com>
From: Andrew Cooper <andrew.cooper3@citrix.com>
Message-ID: <12550694-d66d-0555-d6c9-840d68219350@citrix.com>
Date: Fri, 22 Oct 2021 12:25:52 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <f5a79881bfdcef06aa950632250f551e0ec26458.1634897942.git.lin.liu@citrix.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Content-Language: en-GB
X-ClientProxiedBy: LO2P265CA0363.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:a3::15) To BYAPR03MB3623.namprd03.prod.outlook.com
 (2603:10b6:a02:aa::12)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 379dc05e-5981-4272-5ea9-08d9954eb87a
X-MS-TrafficTypeDiagnostic: SJ0PR03MB5934:
X-Microsoft-Antispam-PRVS: <SJ0PR03MB5934049574927B27486810FABA809@SJ0PR03MB5934.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: HaZrzofHXnNwkM0ga9fmixc/8WfKxi7PsGqofKIkn7tmbzZZ6gWPDQTdwX4fvw6pf3Es1ylg2J8ClEPeRHF/+iA1CbRd6KtuikBlbQZLqmyrJel8iCQHHNDlTJLPuwbpj2ggT7TtULPVXhrT8tkW5Z6QL37FmYpt+6OJLm7uLd3b9UE8pkAVfEIdnUKmaIL7o15XilohrGHjcOxCIqW+OWBaIg1tVYFCKghOzLdz97ZB/kCVZPqa9fPVFe98nPXAclDSkcym9EQVVptKTnA1BzHdyRAwhTvVgPNlo9cFxL9oFmLXpWDh7VwSJ3BEYx85zGuBJz+VOU/Izl3XzpD8P8rCk6QIelXUMmtBpxMiHQyuRQvXBGUojSSWpSllOExC1O5PVy5EmQrHvXmYDJYiQOpLkFlFsbbhnXBa17GAk0aXATPnct/sPFW9uTHt7+UMXrB1WjkN7+EilmGLWib2E5PMtqiYTEdqoUmyPMWqYuri17VIEqoiSbTK00iWUPfoeamZz2PAQ8Ra5jA6gjCLKM9cGtoXkvTaORxuITNDgVgG0CFhLuxR1jN9guMb5dwz6TjfJ4zfp1Hl5YUY9cIFf41WY2zZCJPu/l38d6AIJG6dbmfiRyvAy5cVuP5Syu+FkjvZ5jpmTt1QnCTl/aq5ZrXR3GvxIXEp0mC0DgpAj6yVDXw0FUgztiVQdIFd2BVDXhL+roB7LCYbSqtJbapiBQCVRFcvjY2JagOyaPFoEQ2HUmniiz8k2HCkh5G438sa
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(38100700002)(8936002)(8676002)(66476007)(6666004)(5660300002)(508600001)(4326008)(54906003)(66556008)(316002)(16576012)(31686004)(66946007)(107886003)(36756003)(86362001)(83380400001)(2616005)(6486002)(26005)(956004)(186003)(31696002)(2906002)(53546011)(82960400001)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RWtaWU5NQnV4cGlUeEgzMTVEcDJ6SW55Szl3QThnTnUwQzNLeTFWNnd6QkJK?=
 =?utf-8?B?bUh5YlkxSWJ3NzdKQ2NyY0R4dkN3bEF1SHM4WFRlcVo0VDJTWnhMbi9sSUd3?=
 =?utf-8?B?bUI4Q3lRM0xac3VJcmpLemxDT3FhWG9IcWgxS3ZycW82Y3JsdmEvbHR2M2xU?=
 =?utf-8?B?SXFZdTNRRHk2aXI5OTBHZ0RzSk1TSThOT3ZVRzBJOFpRWFUwT1hYSncrL0gz?=
 =?utf-8?B?eXVkVWNJSUZxeVRnakFseEY0R2dNQmJIMG5iZXR2b1JYRG5IRTFpbUh0dkE4?=
 =?utf-8?B?WUlpb3dXZGxoWDJPZ2w1TllrZm1BN0JBczl3MFJ0YjBWUVNmYmVxTnRZc1VV?=
 =?utf-8?B?QXdwdDJxNW9YTlFaRy90eW9tL0JaVkxuUlFiaWtxMzh2QVg1V3FsWmoxT3dS?=
 =?utf-8?B?Q05MQmhTejNKRExSVFo4c2NMUHZaT3dzOGp6TzFzQ2I1eUZJOE1SajNrdmZI?=
 =?utf-8?B?dEIyZkdUL3NETm8wWWRsQzd1OXVXS3ZPdWxSc3pRdnBUVVFjT2t5WldFcTZN?=
 =?utf-8?B?SlhXbXdXdVgvMU1taHhwRkcxYXFOcmtLenVLYkJ3ZjVJM0JFOVQrNlBYS2tr?=
 =?utf-8?B?NGNPSEtZb2JTZUZDSUR6UlJNaG8xdDNqclNWZ0Urd0djSWFCdHpnRVB5bDBP?=
 =?utf-8?B?U3lKa0JDcE11WDNoZ2Roa3lLWXZWMUV5dmRYUEZaZS9tSDY4MDFvdlFVamNl?=
 =?utf-8?B?Si9QZXlhbWJUc2tDS0Y5YlRFM05TcHZ3akg3a2VOM0VXRCtVbExuRFFsL2Nx?=
 =?utf-8?B?cUQ2YTk2TU1QOVpWQkNrNjV2b2xCc3NleDdCb2o5MmxOaC9MSTRFaENOSGIy?=
 =?utf-8?B?bURBbzU5b3JkVkVJQkhmNEc4b1NSemdtcWRXRFU5SU40SnZuenkvL2h1dEdh?=
 =?utf-8?B?S3hvdUNtZENSNmNlTXZSRUFvd3QxMSs4dklTY0tWR0FLYjk0dy9yUWJrSU1N?=
 =?utf-8?B?Zk5ubG5WbjdDMXZ2KzUzMUNyUExhYnowdnJUUGlRNC9zT3NoNHBoWkljSWtx?=
 =?utf-8?B?MUsrWlBRV2ZwbGN4Ym9lbzVGUkROcFZraTU4dFAyMDZJZk5yV05UVGFTQ3lK?=
 =?utf-8?B?dkwwQUhuWjJMQXpoZGFIOXJPQWVNOVh3TWllUG5zZnBEb3V1c2RwblRQUEZq?=
 =?utf-8?B?NldzM0ZCSW9zUmxucTk2aDMxRnVUNWNMSDUra0NKcW43amJrcitOK09QNGdX?=
 =?utf-8?B?cFNoTzZNVFh4Qzcya25Tb3NZSDVpNGVrNlRuK085bDBOU2Fqb0RJbG5YbE5j?=
 =?utf-8?B?R0lQaGVQcVB4UXlwaUxFS0ZjNWt5ZlMreVlPYXFYNGNzWGszZ3d1cWd2Z3pu?=
 =?utf-8?B?bk44S0JqYit3N1Y0UTk1am56YklpU210Q0dYOW9lSm8wK3gyT0VLanNmYmdF?=
 =?utf-8?B?RlRBSkYwcUZNY0lYOFVmaVVwK2IzaFFEaUhhSTR6UDgrQms5SEwxR25kK0tz?=
 =?utf-8?B?NDE1WXpaMTgxNlVmR2hoL0ZHSVhtQkUzdlBFYUVnR0wwSlF0K1V4anpVNDVO?=
 =?utf-8?B?Zi9pOWQvc3lCWEVIRXFMSU16NENKbGFjR0VYNFVIcXlDU1p3SGJaSjJJcERX?=
 =?utf-8?B?TWw3RHZtTHZOdXNnazd1NjdRUEtZQUQ2bSs0eFJxcXBHVFVXZi8rR0NyT0NN?=
 =?utf-8?B?c2ZYTTJpYWgrS0t4aFJ4L3h5RHBuU3BhQ21DMlJQSXV4dXJUTGtlY1Ywdnoz?=
 =?utf-8?B?UzJzTzVQclhpSXVlUUlqeTNINHZGWVZhZjIwY09EcU5Qdm9WN2p3eUQwelpm?=
 =?utf-8?B?aFBWVTNDKy96d0dwLzVZNFdKWVZ5VGZBdnhSSndGMENORjNGTHdrZ29qTGxr?=
 =?utf-8?B?QzlCRHgwRTc5WjVhWXpRemtnbG5RTGxGdEk5YVdmK3NYSHpIVWZvSUp5SGhs?=
 =?utf-8?B?U0J2YUo1MDBPSklnZ1VSa21jWTFRUHVGQWlob0h1TmtucnVLTnppWWRHWHdG?=
 =?utf-8?Q?0MOqk9QK6NC6RJ5c2brciyjsgAn3CHlJ?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 379dc05e-5981-4272-5ea9-08d9954eb87a
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Oct 2021 11:25:58.6170
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: andrew.cooper3@citrix.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5934
X-OriginatorOrg: citrix.com

On 22/10/2021 11:47, Lin Liu wrote:
> Update to use byteswap.h to swap bytes.
>
> No functional chagne.
>
> Signed-off-by: Lin Liu <lin.liu@citrix.com>
> ---
> Cc: Andrew Cooper <andrew.cooper3@citrix.com>
> Cc: George Dunlap <george.dunlap@citrix.com>
> Cc: Ian Jackson <iwj@xenproject.org>
> Cc: Jan Beulich <jbeulich@suse.com>
> Cc: Julien Grall <julien@xen.org>
> Cc: Stefano Stabellini <sstabellini@kernel.org>
> Cc: Wei Liu <wl@xen.org>
> Cc: "Roger Pau Monné" <roger.pau@citrix.com>
> ---
>  xen/common/bitmap.c                |  2 +-
>  xen/common/gdbstub.c               |  2 +-
>  xen/common/libelf/libelf-private.h |  8 ++++----
>  xen/common/lz4/defs.h              |  2 +-
>  xen/common/lzo.c                   |  2 +-
>  xen/common/unlzo.c                 |  2 +-
>  xen/common/xz/private.h            |  4 ++--
>  xen/drivers/char/ehci-dbgp.c       |  2 +-
>  xen/include/asm-x86/msi.h          |  2 +-
>  xen/include/xen/bitmap.h           |  2 +-
>  xen/include/xen/device_tree.h      |  2 +-
>  xen/include/xen/unaligned.h        | 14 +++++++-------
>  xen/lib/divmod.c                   |  2 +-
>  13 files changed, 23 insertions(+), 23 deletions(-)
>
> diff --git a/xen/common/bitmap.c b/xen/common/bitmap.c
> index 7d4551f782..be274ca04a 100644
> --- a/xen/common/bitmap.c
> +++ b/xen/common/bitmap.c
> @@ -9,10 +9,10 @@
>  #include <xen/errno.h>
>  #include <xen/bitmap.h>
>  #include <xen/bitops.h>
> +#include <xen/byteswap.h>
>  #include <xen/cpumask.h>
>  #include <xen/guest_access.h>
>  #include <xen/lib.h>
> -#include <asm/byteorder.h>
>  
>  /*
>   * bitmaps provide an array of bits, implemented using an an
> diff --git a/xen/common/gdbstub.c b/xen/common/gdbstub.c
> index 848c1f4327..3c8ed52d6b 100644
> --- a/xen/common/gdbstub.c
> +++ b/xen/common/gdbstub.c
> @@ -33,6 +33,7 @@
>  /* Resuming after we've stopped used to work, but more through luck
>     than any actual intention.  It doesn't at the moment. */
>  
> +#include <xen/byteswap.h>
>  #include <xen/lib.h>
>  #include <xen/spinlock.h>
>  #include <xen/serial.h>
> @@ -45,7 +46,6 @@
>  #include <xen/console.h>
>  #include <xen/errno.h>
>  #include <xen/delay.h>
> -#include <asm/byteorder.h>
>  
>  /* Printk isn't particularly safe just after we've trapped to the
>     debugger. so avoid it. */
> diff --git a/xen/common/libelf/libelf-private.h b/xen/common/libelf/libelf-private.h
> index 47db679966..b7089cb31b 100644
> --- a/xen/common/libelf/libelf-private.h
> +++ b/xen/common/libelf/libelf-private.h
> @@ -17,10 +17,10 @@
>  
>  #ifdef __XEN__
>  
> +#include <xen/byteswap.h>
>  #include <xen/lib.h>
>  #include <xen/libelf.h>
>  #include <xen/softirq.h>
> -#include <asm/byteorder.h>
>  #include <public/elfnote.h>
>  
>  /* we would like to use elf->log_callback but we can't because
> @@ -31,9 +31,9 @@
>     printk(fmt, ## args )
>  
>  #define strtoull(str, end, base) simple_strtoull(str, end, base)
> -#define bswap_16(x) swab16(x)
> -#define bswap_32(x) swab32(x)
> -#define bswap_64(x) swab64(x)
> +#define bswap_16(x) bswap16(x)
> +#define bswap_32(x) bswap32(x)
> +#define bswap_64(x) bswap64(x)
>  
>  #else /* !__XEN__ */
>  
> diff --git a/xen/common/lz4/defs.h b/xen/common/lz4/defs.h
> index 10609f5a53..1ce4476478 100644
> --- a/xen/common/lz4/defs.h
> +++ b/xen/common/lz4/defs.h
> @@ -9,7 +9,7 @@
>   */
>  
>  #ifdef __XEN__
> -#include <asm/byteorder.h>
> +#include <xen/byteswap.h>
>  #include <asm/unaligned.h>
>  #else
>  
> diff --git a/xen/common/lzo.c b/xen/common/lzo.c
> index a87c76dded..17be9675f4 100644
> --- a/xen/common/lzo.c
> +++ b/xen/common/lzo.c
> @@ -96,7 +96,7 @@
>  
>  #ifdef __XEN__
>  #include <xen/lib.h>
> -#include <asm/byteorder.h>
> +#include <xen/byteswap.h>
>  #include <asm/unaligned.h>
>  #else
>  #define get_unaligned_le16(_p) (*(u16 *)(_p))
> diff --git a/xen/common/unlzo.c b/xen/common/unlzo.c
> index 74056778eb..f908d2a61f 100644
> --- a/xen/common/unlzo.c
> +++ b/xen/common/unlzo.c
> @@ -33,7 +33,7 @@
>  #include <xen/lzo.h>
>  
>  #ifdef __XEN__
> -#include <asm/byteorder.h>
> +#include <xen/byteswap.h>
>  #include <asm/unaligned.h>
>  #else
>  
> diff --git a/xen/common/xz/private.h b/xen/common/xz/private.h
> index 511343fcc2..647f9699a7 100644
> --- a/xen/common/xz/private.h
> +++ b/xen/common/xz/private.h
> @@ -12,7 +12,7 @@
>  
>  #ifdef __XEN__
>  #include <xen/kernel.h>
> -#include <asm/byteorder.h>
> +#include <xen/byteswap.h>
>  #include <asm/unaligned.h>
>  #else
>  
> @@ -28,7 +28,7 @@ static inline void put_unaligned_le32(u32 val, void *p)
>  
>  #endif
>  
> -#define get_le32(p) le32_to_cpup((const uint32_t *)(p))
> +#define get_le32(p) le32_to_cpu(*(const uint32_t *)(p))
>  
>  #define false 0
>  #define true 1
> diff --git a/xen/drivers/char/ehci-dbgp.c b/xen/drivers/char/ehci-dbgp.c
> index c893d246de..8412da1b11 100644
> --- a/xen/drivers/char/ehci-dbgp.c
> +++ b/xen/drivers/char/ehci-dbgp.c
> @@ -5,13 +5,13 @@
>   * Linux; see the Linux source for authorship and copyrights.
>   */
>  
> +#include <xen/byteswap.h>
>  #include <xen/console.h>
>  #include <xen/delay.h>
>  #include <xen/errno.h>
>  #include <xen/param.h>
>  #include <xen/pci.h>
>  #include <xen/serial.h>
> -#include <asm/byteorder.h>
>  #include <asm/io.h>
>  #include <asm/fixmap.h>
>  #include <public/physdev.h>
> diff --git a/xen/include/asm-x86/msi.h b/xen/include/asm-x86/msi.h
> index e228b0f3f3..277375183c 100644
> --- a/xen/include/asm-x86/msi.h
> +++ b/xen/include/asm-x86/msi.h
> @@ -1,9 +1,9 @@
>  #ifndef __ASM_MSI_H
>  #define __ASM_MSI_H
>  
> +#include <xen/byteswap.h>
>  #include <xen/cpumask.h>
>  #include <xen/pci.h>
> -#include <asm/byteorder.h>
>  #include <asm/hvm/vmx/vmcs.h>
>  
>  /*
> diff --git a/xen/include/xen/bitmap.h b/xen/include/xen/bitmap.h
> index e9175ab54a..c44a1cb63c 100644
> --- a/xen/include/xen/bitmap.h
> +++ b/xen/include/xen/bitmap.h
> @@ -229,7 +229,7 @@ static inline int bitmap_weight(const unsigned long *src, int nbits)
>  	return __bitmap_weight(src, nbits);
>  }
>  
> -#include <asm/byteorder.h>
> +#include <xen/byteswap.h>
>  
>  #ifdef __LITTLE_ENDIAN
>  #define BITMAP_MEM_ALIGNMENT 8
> diff --git a/xen/include/xen/device_tree.h b/xen/include/xen/device_tree.h
> index fd6cd00b43..4921e6b142 100644
> --- a/xen/include/xen/device_tree.h
> +++ b/xen/include/xen/device_tree.h
> @@ -10,10 +10,10 @@
>  #ifndef __XEN_DEVICE_TREE_H__
>  #define __XEN_DEVICE_TREE_H__
>  
> -#include <asm/byteorder.h>
>  #include <asm/device.h>
>  #include <public/xen.h>
>  #include <public/device_tree_defs.h>
> +#include <xen/byteswap.h>
>  #include <xen/kernel.h>
>  #include <xen/string.h>
>  #include <xen/types.h>
> diff --git a/xen/include/xen/unaligned.h b/xen/include/xen/unaligned.h
> index 0a2b16d05d..8a9ec8a0ac 100644
> --- a/xen/include/xen/unaligned.h
> +++ b/xen/include/xen/unaligned.h
> @@ -11,8 +11,8 @@
>  #define __XEN_UNALIGNED_H__
>  
>  #ifdef __XEN__
> +#include <xen/byteswap.h>
>  #include <xen/types.h>
> -#include <asm/byteorder.h>
>  #endif
>  
>  #define get_unaligned(p) (*(p))
> @@ -20,7 +20,7 @@
>  
>  static inline uint16_t get_unaligned_be16(const void *p)
>  {
> -	return be16_to_cpup(p);
> +	return be16_to_cpu(*(uint16_t*)p);

Hmm - this missed one of my pieces of internal feedback.

*(const uint16_t *)p

to get correct style and avoid casting away const.

Also, the put functions what to drop the __force and use typecasting
like this.

I can fix up on commit if there are no other concerns with the series.

~Andrew


From xen-devel-bounces@lists.xenproject.org Fri Oct 22 11:50:41 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Oct 2021 11:50:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.215026.373945 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdt48-0000p7-U0; Fri, 22 Oct 2021 11:50:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 215026.373945; Fri, 22 Oct 2021 11:50:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdt48-0000p0-Qp; Fri, 22 Oct 2021 11:50:28 +0000
Received: by outflank-mailman (input) for mailman id 215026;
 Fri, 22 Oct 2021 11:50:27 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=OBiv=PK=citrix.com=Andrew.Cooper3@srs-us1.protection.inumbo.net>)
 id 1mdt47-0000ou-7D
 for xen-devel@lists.xenproject.org; Fri, 22 Oct 2021 11:50:27 +0000
Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id f7eee51b-f5d0-4eff-b76b-64f2bbedd4c1;
 Fri, 22 Oct 2021 11:50:25 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f7eee51b-f5d0-4eff-b76b-64f2bbedd4c1
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1634903425;
  h=to:cc:references:from:subject:message-id:date:
   in-reply-to:content-transfer-encoding:mime-version;
  bh=H9bfAxHq9C4djbYaVFzfI7/T3GJLqJyrIdorviNKW4s=;
  b=KuhDQT3dsSoawAdhZQxkYiv4VzzgYsDid7nrsm1+ICi5HYd5JLgijvxV
   1e2bAn7sCYZbrXuqfeMPFiWOctFqDhCHJQOfZ6jjcFHVit7bhZqhONo+f
   lhRIaz/afb+PjvVCDn35o4j5uL7XllrM9oa7AFNu1vE4BZQ0uPQ0Ln7os
   0=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: ZQYD7joum40Hn9lLF8T0+iBYNKsH2NoTsbMUjvT1NCjzlctiHZidO1H5B4ph+Kkc2NlRVikgcF
 7pDICL3R74D72WBIbzLgRGuCPhXiN+pclvRAXFmNcY6mVDfwRb2u73v9/JdsEe6/4EjSQeBAZW
 ZF3PLV3rpBkEIFrYRgqnDfXVnCRed5aGDUEtWBMkHhX/dhsYNbjNTv0lbBleqqyeCOHbSv8UBQ
 cpCSkKlv9f7M95wRzyNeDzHvxBbaL2Xo0j0YYp0w6sjYfXXwYDqSsNiNCwXj0SsHsy3I0FNl/d
 9loWuYF+f/rGTcE9g/yz23Z5
X-SBRS: 5.1
X-MesageID: 55846986
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:9CLL0K/Zbcwtzqa96d02DrUDjXiTJUtcMsCJ2f8bNWPcYEJGY0x3y
 mQWC2HVPviJNGv3fIoiYIq08k0O7JaHydViHQs+rS88E34SpcT7XtnIdU2Y0wF+jyHgoOCLy
 +1EN7Es+ehtFie0Si9AttENlFEkvU2ybuOU5NXsZ2YhGmeIdA970Ug6wrZj2NYy6TSEK1jlV
 e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH
 I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPhg6
 YoSvLPrbD4YL73BtfQtAjkFLwBxaPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us
 6ZCcXZUM07F17neLLGTE4GAguwKKsXxMZxZkXZn1TzDVt4tQIzZQrWM7thdtNs1rp0TTaqAN
 ppHAdZpRArvTh5qBkxGNMI/l+Sx3Uf5az4E8U3A8MLb5ECMlVcsgdABKuH9e8OIbdVYmF6Co
 WDL9Hi/BQsVXPSdwzeY9nOnhsfUgDj2HokVEdWQ+uZxhVyPxkQaEBAMSUaguv69l1K/XNREb
 UcT/0IGvaU0sUCmUNT5dxm5u2Kf+A4RXcJKFO834x3LzbDbiy6VCWQJQSRIQMA3v88xAzox3
 xmGmM2BLQJotLqZWHeM7IC+pDm5OTUWBWIabCpCRgwAi/H8pKkjgxSJScxseIaulcH8Ezz0x
 zGMrQA9iq8VgMpN0L+0lXjFnjatq57hXgMzoALNUQqN7QR/foepIZOp7Vvz6uxJJ4KUCFKGu
 RA5d9O2tb5US8vXzWrUHbtLTOrBC+u53CP0kH8wQJAOrBGUym+zcK1A0GBeeXtIPZNREdP2W
 3P7tQRU7Z5VGXKla65rfo68Y/gXIbjc+cfNDa+MMIIfCnRlXErepns2PB/Pt4z4uBF0yflXB
 HuNTSq74Z/244xcxz2qW/xV77Yvwi0vrY84bcGml0r5uVZyiXj8dFvkDLdsRrxmhE9niF+Mm
 zq6Cyds408DOAEZSnKPmbP/1XhQcRAG6Wne8qS7jNKrLAt8A30GAPTM274ncIENt/0LzbuYo
 ijiChcDlQuXaZj7xeOiMCwLhFTHBs4XkJ7GFXZ0YQbAN4YLMe5DE5vzh7NoJOJ6pYSPPNZ/T
 uUfetXoPxi8Ym+vxtjpVrGk9NYKXE3y3WqmZnP5CBBiL88Ib1GYobfMI1qwnBTi+wLq7KPSV
 ZX7jViFKXfCLiw/ZPvrhAWHlgLo4yJFwb8qAyMl4LB7IS3RzWSjEASo5tcfKMAQMxTTgDyc0
 gedGxADoufR5YQy9bH0aWqs9u9FysNyQRhXGXf197GzOXWI92av29YYAu2JYSrcRCX//6D7P
 bdZyPT1MfsmmldWstUjT+Y3nPxmv9a/9aVHyglEHWnQawj5AL1XPXTbj9JEsbdAx+EFtFLuC
 F6P4NRTJZ6AJNjhTAwKPAMgY+najaMUlzDe4O4bOkL/4CMrrrOLXV8LZ0uHiTBHLaszO4Qgm
 L9ztMkT4g25qxwrLtfZ0XwEqzXSdiQNCvx1uIsbDYnnjhsQ5mtDOZGMWDXr5JyvaslXNhV4K
 DGjm6ef1a9XwVDPciRvGCGVj/Zdn5kHpDtD0EQGewaSgtPAi/I6gE9R/DAwQlgHxxlLybsua
 G1iNkkzLqSS5TZ4wsNEWjn0SQ1GARSY/G33ykcIyzKFHxX5CDSVIT1vI/uJ8WAY73lYL2pS8
 7yvwWr4VSrnIZPq1SwoVE858/HuQLSdLOEZdBxLyyhdI6QHXA==
IronPort-HdrOrdr: A9a23:fsDzPqqHVYYzd/XqvSxb+rwaV5oGeYIsimQD101hICG9E/bo7f
 xG+c5xvyMc5wx8ZJheo6HkBEDtex7hHOdOkO0s1O6ZLW7bUQiTXfpfBPXZrQEIcheWntK1s5
 0QC5SWYOeAdGSS5vyU3ODXKbcdKM7uytHKuQ6n9RdQpPZRGsNdBzESMHf8LnFL
X-IronPort-AV: E=Sophos;i="5.87,172,1631592000"; 
   d="scan'208";a="55846986"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Gtv+TO+hW8jL2ZjnDuHKXGaLKDIopgkoLfYgZnMc5wr3BiJQKuSrdj9OTA+eqvMJ5jE0Aj0y7ll7WTwoMmixnoBin2EnKlKdfSIlV7WAknHDzARmFZuA1cgxEt+o7jLdTc7tMK98F2yU1+ZgHAV8PBTukg7y+f9JcBWXRu+O6KZDl88AtFuoieWenZGRR07HoJ9i46C3lMhCD450X9Qw/RbIgIZ47RLH6+T+oSFiz45sogh12SI9VpEHBS2hfd9IOFNnSZEOcXXo8dmsqhAuqIiFt04Sgm5tFvgf+F+1U4EEK15nUT1M/BC3z0ghKs6gFxqGQEQfIRs05puWj6aCvg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=H9bfAxHq9C4djbYaVFzfI7/T3GJLqJyrIdorviNKW4s=;
 b=CrdN8ryuUEAAUSs3lM43jqmOSM7UTx9H5d8Y6vddYh6sHDbEsR3bL+2XKf/0rIC7B+sNSwzxU1rAauhpEm3bpPX4sV0O8ilVW//GpZ7cz3cNk8Q8oKYkBYimzI+6PvHwtAdApOKFVDIBaBwrjFeRFScthWghq/opRJ8Y5/0DqpjfIQ78bqEn+Vh80X+h9AFGPwNTEgqiKvJs/yMsaRbDNNeKN0wV8t7jbD2E8NZNRCnYwISmixBw47xkdJlhHThtG1vuFWZQK+UPp3XQ/DKku/ZwzUP2+LSaIpTjf0VuBIUvU4c8vQ+FIKpOdqCxbCqTT/CRHzTuDJmjwwFX4yyLbQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=H9bfAxHq9C4djbYaVFzfI7/T3GJLqJyrIdorviNKW4s=;
 b=hgf4riJRltQ6YAHmH3G0Ylszx4ByY5pq9PH/B+GY3LWCloQUqQhxWuZ7wcAN0RPQ4i/BWsspeykvxj9ihJLV3NMlLUUy7cJfHCli34mpwC7tgd8rmjj0pdxYjvz6Zm6UgXmUtFynvlItvEhx0zB5AprEj0TyWxwrLmSqi3f7vY4=
To: Lin Liu <lin.liu@citrix.com>, <xen-devel@lists.xenproject.org>
CC: Daniel De Graaf <dgdegra@tycho.nsa.gov>, "Daniel P. Smith"
	<dpsmith@apertussolutions.com>, George Dunlap <george.dunlap@citrix.com>, Ian
 Jackson <iwj@xenproject.org>, Jan Beulich <jbeulich@suse.com>, Julien Grall
	<julien@xen.org>, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	=?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>, Ross Lagerwall
	<ross.lagerwall@citrix.com>, Stefano Stabellini <sstabellini@kernel.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, Wei Liu <wl@xen.org>
References: <cover.1634897942.git.lin.liu@citrix.com>
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH v2 0/7] Implement byteswap and update references
Message-ID: <c72a5a4c-62ca-4d3b-d5c0-ce6122f924bd@citrix.com>
Date: Fri, 22 Oct 2021 12:50:14 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <cover.1634897942.git.lin.liu@citrix.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: base64
Content-Language: en-GB
X-ClientProxiedBy: LO4P123CA0022.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:151::9) To BYAPR03MB3623.namprd03.prod.outlook.com
 (2603:10b6:a02:aa::12)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: eee86203-e873-4d86-2101-08d995522070
X-MS-TrafficTypeDiagnostic: BY5PR03MB5220:
X-Microsoft-Antispam-PRVS: <BY5PR03MB522056462E1BDF48A782D0CEBA809@BY5PR03MB5220.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: fiiZZgDWJlRr2ftCtVaRbcqQrCUmSzmn2gUNE9W/0q5xW7RWopTMDYewGshC632lI/k/3n6fYBnBZavNbYbGuMzfJED6q3M2vJsztbARS1l99yo4+Pzd2xfM/L26XQGvOD8VAGQ7KqT1Yz8C/SkHup9ev1vO3qH3sxGT2RcCw9BgRmro1th7zqhszVpBhvQz4WHOeYYzecdfyD1aPN1aw6pMxrMXOft2ApKLf5BsGhxHGE4JQi4NZR9Dpmx2KNUy2KReYTgIda5UNg4v4psnFIEBT+gWJf6hxs93PyQdecn7s/wynmx1ND2ALGdnQDM5nd0oyNUO+SvSZ1igh+zmGzsadb1EdOjg4sEK0zByoDKePEPycG1zu8Xdvf9ooBayvxN3xghziQXhGTRX6aIuhC+D8yNaTB9MEBRq8da3Yfxhi0DqaORnCmQcOkeeXzhVGLQdNJ4VFAGkCGHPMzrPfbc2DBMYmMyYjiLlYDKfk+e1JYb8Pz7dbmBRFf4uq74AY4pSkBWTu+1MxPL2Q1DBEuI4Te+MJ96tqkn8Vtc8tKnZJb5EgvDVwbg+ey0RDMYf3FFV6PSGYkMH4dAZR9eGXum5ldXUV27oYNboqTChEBHtHNGR3BvHfSaRyezgitfBkv5zcKO96RkrW816Tx9KbX49le0JkyPaZHqzXvbziT/RFEAA6HahE3Y4i1lcx5DROw/c/3ZIahMaGiPLqmS87f80IsgO3gs119fNN2YUdfg1bzEQbonCoe/csJtPU55J
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(31686004)(956004)(2616005)(38100700002)(6486002)(26005)(66946007)(86362001)(82960400001)(508600001)(4326008)(83380400001)(2906002)(8936002)(5660300002)(316002)(8676002)(6666004)(36756003)(53546011)(16576012)(66556008)(7416002)(186003)(66476007)(15650500001)(54906003)(31696002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OFFjWUI0ckxVNUFlY1MyUUJCK2owR1ZCMWdLdzh4KzZqclRWanNpY2FSQm92?=
 =?utf-8?B?QlFxTDJlaWQrMGM5L3E2WHJrSXBNOFZadDQ4eUoxcjgzSFN1UzNDVFdUc0I2?=
 =?utf-8?B?dFYzVWJwQllvcFN1MVdSdHdsQUZyVGR2akYxaStrRWM2djlwMGJsTFpva3pG?=
 =?utf-8?B?Tmx1aFNLZ25BMU5lS3lkSUVrcXJqSjI5empqUEtkYlBraVI5US8xS2ZqdXVQ?=
 =?utf-8?B?ZE5RWURPb2FqQmFkaHpVaUJSUlNtYjU5a1BiUmFmL0x5TmZpK1JacVJyZW9P?=
 =?utf-8?B?eFJTbkpLVUw1eE45UURhQ2sxd21zYTdyUm96cTVjUHN2aDZWc084K29lRlZi?=
 =?utf-8?B?MGRVenp6bkNLbXUvSm16VDFGR2VHWGFyQloxRWU4anpYU2xwbFNLaFZLdU1M?=
 =?utf-8?B?WkdRQ1k0N1k0K0RaN05rdHhiVnRCNjdoZFd1TmRROTF0QjE4aWJPWk05N25Y?=
 =?utf-8?B?amUrYXhZa1Z5bGdITm5LMWlwVDV4dUp2SFVZLzNoY1ZBZDZJUGc3cHRZYmE5?=
 =?utf-8?B?RGdVODZmTG1lbktldUllYkw0dXlkeWk1SzM3cUJOZWN3Z0VWYTQxelBPMWRE?=
 =?utf-8?B?ZGg4ZDZsaUFUcHFBdUd0QkwvYmYwTjZnWWRyNnRCQ2VtOFZRTWhVbldpRk93?=
 =?utf-8?B?WG5BRzFNRGtmbkF0OG8ybGc0Rzc1allDUHV3YzczT2ZJUUpvakhSMGRVdjFw?=
 =?utf-8?B?MUpJRS9DWldYS2NoUjJ4NGpBdTZ1SmtZOGYxL0xOOW5OZDBCY25tV05pODhV?=
 =?utf-8?B?elh5UkNhTTJBQkYrRlJuK0cwMEs0TnVhaUxIOElGMTJaQlcxWUFHZHd6Zk9k?=
 =?utf-8?B?Y2pzY3BvRmc0M3NFQS9kbzQ2RjdmZU9HZXRZVDBaVitXek81MDZwMVhNTHV3?=
 =?utf-8?B?bUlUaG5yWkNybUNJNzNlVGVnZkxhMDZua1k1L0hyenYwMjFBVCs2SUkwTjF6?=
 =?utf-8?B?MVBESGtkdWdDYUF2NnZSOWhaYTF3MkxxK0Zoa21EVXRlK2twZUh6K0gwVDc0?=
 =?utf-8?B?M1hXcGRZYVJwbmxPKy8rVnBLcE8xY05ETi9UQWtpUWV0MnAyYnlCc2NkL1E3?=
 =?utf-8?B?VG1TdXlhUHhpVlhWZ3ZsZGpnNm9UcGxnVU9Za3gxWk1Kdm1la21KRWVpOGdn?=
 =?utf-8?B?MlRPd3RGWkNZYnJ4eENCbDNGbkpJY1AxNVJveTNzWmJLUjg0Zlp0NDQzQmtS?=
 =?utf-8?B?dnVuRTJPTWM5Y2VUK2JuZGdZa1ZIMTZZc0V3VUdPKzRDTlltbEJJRUhPWS9G?=
 =?utf-8?B?c2xETHZVT29rNm53MWxoOVNoTFhmeVUxSHVjclNWbEJJZ3FQVk5KMU1mSGhY?=
 =?utf-8?B?clQrVGFlWFZQdVltZ2lkQ3VrT0ZpRkEwZ1VyRTZnSFB0NjIzeWV6RVI1aDdZ?=
 =?utf-8?B?ZUNadU5TUTFsZlpua1pUMmx6NDJodnhxNlpjdlg3aUdIS3h4dXA3eVArdHNG?=
 =?utf-8?B?TVBRd3AycXM2TU9pMTNpR3BRaEF4NUlTZnFSajBjdXl2eUJMMEhBd3hKWGlL?=
 =?utf-8?B?ZDU4RGpvamdrYWxjTVJKa0pWOUJQbWU5MWxxamlOc2ZZMmgyWk1tYXhkZXdh?=
 =?utf-8?B?ZmRKWmRWamRxbk1DeTFnNzFDclpSd0ZMSm9yWE1tQnBzRjdlcnovYXhYQVJN?=
 =?utf-8?B?SXlkWXN0N3I0alo2RmpPem5FVGhVNmtuMUJSalk5WFloZmlOUGVURnZSemZF?=
 =?utf-8?B?aGNVbEkvcFpJeGcybUlsL25LSTV2S0hVL3BYYTBLZ2RZUGVxQlk0LzM1QUls?=
 =?utf-8?B?MVJCeDJZT3IycHkybXAwQ0JRT2dDUHBaOFN6dkRaZmRpb3cvSC9UVVpkK3h5?=
 =?utf-8?B?ckl3MkhaZDAveVJweGFucHJYUGVNaElzbGQ1UFkyVE9YK1dNODJwYWNTQkdG?=
 =?utf-8?B?S3RkS3NIa1dSb0tPVjY3N2NuZ3NUYkZxVkhGYjgzWkhQalJKTmkrQ0tmYld6?=
 =?utf-8?Q?yGJv6nZgfaqtgRKRbmWXeLvOcw3V7VrU?=
X-MS-Exchange-CrossTenant-Network-Message-Id: eee86203-e873-4d86-2101-08d995522070
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Oct 2021 11:50:21.4781
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: andrew.cooper3@citrix.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR03MB5220
X-OriginatorOrg: citrix.com

T24gMjIvMTAvMjAyMSAxMTo0NywgTGluIExpdSB3cm90ZToKPiBUaGUgc3dhYigpIGlzIG1hc3Np
dmVseSBvdmVyIGNvbXBsaWNhdGVkCj4gU2ltcGxpZnkgaXQgd2l0aCBjb21waWxlciBidWlsdGlu
cyBhbmQgZmFsbGJhY2sgdG8gcGxhaW4gQyBmdW5jdGlvbgo+IGlmIHVuZGVmaW5lZC4KPiBVcGRh
dGUgY29tcG9uZW50cyB0byBzd2l0Y2ggdG8gdGhpcyBuZXcgc3dhcCBieXRlcy4KPgo+IDxzbmlw
Pgo+ICAzNCBmaWxlcyBjaGFuZ2VkLCAxNTAgaW5zZXJ0aW9ucygrKSwgNjQ2IGRlbGV0aW9ucygt
KQoKSXQgaXMgd29ydGggc2F5aW5nIGEgY291cGxlIG9mIHRoaW5ncy4KCng4NidzIF9fX2FyY2hf
X3N3YWI2NCBpcyB3cm9uZy7CoCBXZWxsIC0gaXQgd2FzIG1vc3RseSBvayBmb3IgMzJiaXQKYnVp
bGRzIG9mIFhlbiwgYW5kIGlzIG5vdCBvayBmb3IgNjRiaXQgYnVpbGRzLsKgIEFzIGEgY29uc2Vx
dWVuY2UsIHRoaXMKc2VyaWVzIG5ldHMgYW4gaW1wcm92ZW1lbnQgb2Y6CgokIC4uL3NjcmlwdHMv
YmxvYXQtby1tZXRlciB4ZW4tc3ltcy1iZWZvcmUgeGVuLXN5bXMtYWZ0ZXIKYWRkL3JlbW92ZTog
MC8wIGdyb3cvc2hyaW5rOiAwLzIgdXAvZG93bjogMC8tNTQgKC01NCkKRnVuY3Rpb27CoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqAgb2xkwqDCoMKgwqAgbmV3wqDCoCBkZWx0YQplbGZfYWNjZXNzX3Vuc2lnbmVkwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgMTczwqDCoMKg
wqAgMTUxwqDCoMKgwqAgLTIyCnVubHpvwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAxMTI4wqDCoMKgIDEw
OTbCoMKgwqDCoCAtMzIKVG90YWw6IEJlZm9yZT0zODAzMzI4LCBBZnRlcj0zODAzMjc0LCBjaGcg
LTAuMDAlCgpiZWNhdXNlIHRoZSBjb2RlIGdlbmVyYXRpb24gZm9yIGJzd2FwNjQgZ29lcyBmcm9t
OgoKZmZmZjgyZDA0MDIwNTliMCA8X2Jzd2FwNjQ+OgpmZmZmODJkMDQwMjA1OWIwOsKgwqDCoCA0
OCA4OSBmOMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIG1vdsKgwqDCoCAlcmRpLCVy
YXgKZmZmZjgyZDA0MDIwNTliMzrCoMKgwqAgNDggYzEgZTggMjDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoCBzaHLCoMKgwqAgJDB4MjAsJXJheApmZmZmODJkMDQwMjA1OWI3OsKgwqDCoCAwZiBj
ZsKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGJzd2FwwqAgJWVkaQpmZmZm
ODJkMDQwMjA1OWI5OsKgwqDCoCAwZiBjOMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgIGJzd2FwwqAgJWVheApmZmZmODJkMDQwMjA1OWJiOsKgwqDCoCA5N8KgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHhjaGfCoMKgICVlYXgsJWVkaQpmZmZm
ODJkMDQwMjA1OWJjOsKgwqDCoCA0OCA4OSBjMsKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgIG1vdsKgwqDCoCAlcmF4LCVyZHgKZmZmZjgyZDA0MDIwNTliZjrCoMKgwqAgODkgZjjCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBtb3bCoMKgwqAgJWVkaSwlZWF4CmZm
ZmY4MmQwNDAyMDU5YzE6wqDCoMKgIDQ4IGMxIGUyIDIwwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqAgc2hswqDCoMKgICQweDIwLCVyZHgKZmZmZjgyZDA0MDIwNTljNTrCoMKgwqAgNDggMDkgZDDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBvcsKgwqDCoMKgICVyZHgsJXJheApmZmZm
ODJkMDQwMjA1OWM4OsKgwqDCoCBjM8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgIHJldHHCoAoKdG8KCmZmZmY4MmQwNDAyMDU5YjAgPF9ic3dhcDY0PjoKZmZmZjgy
ZDA0MDIwNTliMDrCoMKgwqAgNDggODkgZjjCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oCBtb3bCoMKgwqAgJXJkaSwlcmF4CmZmZmY4MmQwNDAyMDU5YjM6wqDCoMKgIDQ4IDBmIGM4wqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgYnN3YXDCoCAlcmF4CmZmZmY4MmQwNDAyMDU5
YjY6wqDCoMKgIGMzwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAg
cmV0ccKgCgpBbG1vc3QgYWxsIGJ5dGVzd2FwcGluZyBpcyBkb25lIG9uIDMyYml0IHF1YW50aXRp
ZXMsIG5vdCA2NCwgd2hpY2ggaXMKd2h5IHRoZSBkZWx0YSBpcyBzbyBzbWFsbC4KCkhvd2V2ZXIs
IGl0IGFsc28gZHJvcHMgNTAwIGxpbmVzIG9mIGNvZGUsIHdoaWNoIGlzIGEgZGVtb25zdHJhdGlv
biBvZgpob3cgc2lsbHkgdGhlIHN3YWIoKSBpbmZyYXN0cnVjdHVyZSB3YXMuwqAgSXQgYWxzbyBy
ZW1vdmVzIHRoZSBuZWVkIGZvcgpwZXItYXJjaCBjb2RlIHRvIGRvIGFueSBvZiB0aGlzLgoKSSdk
IHNheSBpdHMgc2FmZSB0byBnbyBpbnRvIDQuMTYsIGJ1dCBJJ2xsIHVuZGVyc3RhbmQgaWYgb3Ro
ZXJzIHdhbnQgdG8KcHVzaCBiYWNrIG9uIHRoYXQgYXQgdGhpcyBwb2ludCBpbiB0aGUgcmVsZWFz
ZS4KCn5BbmRyZXcK


From xen-devel-bounces@lists.xenproject.org Fri Oct 22 12:12:01 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Oct 2021 12:12:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.215039.373968 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdtOu-0003Ii-20; Fri, 22 Oct 2021 12:11:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 215039.373968; Fri, 22 Oct 2021 12:11:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdtOt-0003Ib-VE; Fri, 22 Oct 2021 12:11:55 +0000
Received: by outflank-mailman (input) for mailman id 215039;
 Fri, 22 Oct 2021 12:11:55 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mdtOt-0003IP-4f; Fri, 22 Oct 2021 12:11:55 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mdtOs-0003WX-U7; Fri, 22 Oct 2021 12:11:54 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mdtOs-00079z-KD; Fri, 22 Oct 2021 12:11:54 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mdtOs-0003yO-Jh; Fri, 22 Oct 2021 12:11:54 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=w6sXT7LGPSokl8BtjE52J3bP+5eXCh5wleujm9V5qT8=; b=sf84uOh176la75kwIa2iWoM/wL
	8idPyo5WGnWkYhN25n7qGkj28AnzCEEVb/KyONf3WwqYU6QcbKNhYYsDF5LkNFRA/TwSDiwHLCmBo
	hGGhwpliA5+HSAxma30yg4WpGEhDIlkJfMIK4cqnqHkqAtXBjW3q5Ri8JFhcaJ5g1RTI=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165729-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 165729: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-unstable:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=23ec1ebc8acbfd2bf06f6085a776f0db923f9fa9
X-Osstest-Versions-That:
    xen=118da371d1ff5d8432fa299544b1ea5e7e3710f0
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 22 Oct 2021 12:11:54 +0000

flight 165729 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165729/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-rtds     20 guest-localmigrate/x10       fail  like 165699
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 165699
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 165699
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165699
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165699
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 165699
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 165699
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 165699
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 165699
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 165699
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 165699
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165699
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 165699
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  23ec1ebc8acbfd2bf06f6085a776f0db923f9fa9
baseline version:
 xen                  118da371d1ff5d8432fa299544b1ea5e7e3710f0

Last test of basis   165699  2021-10-21 03:03:05 Z    1 days
Failing since        165712  2021-10-21 15:08:08 Z    0 days    2 attempts
Testing same since   165729  2021-10-22 03:18:21 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Hongda Deng <hongda.deng@arm.com>
  Julien Grall <jgrall@amazon.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     fail    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   98f60e5de0..23ec1ebc8a  23ec1ebc8acbfd2bf06f6085a776f0db923f9fa9 -> master


From xen-devel-bounces@lists.xenproject.org Fri Oct 22 12:37:26 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Oct 2021 12:37:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.215048.373989 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdtnT-0005gK-99; Fri, 22 Oct 2021 12:37:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 215048.373989; Fri, 22 Oct 2021 12:37:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdtnT-0005gD-4r; Fri, 22 Oct 2021 12:37:19 +0000
Received: by outflank-mailman (input) for mailman id 215048;
 Fri, 22 Oct 2021 12:37:17 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=VW94=PK=citrix.com=anthony.perard@srs-us1.protection.inumbo.net>)
 id 1mdtnR-0005g7-LN
 for xen-devel@lists.xenproject.org; Fri, 22 Oct 2021 12:37:17 +0000
Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id c9d83b4a-3334-11ec-83b7-12813bfff9fa;
 Fri, 22 Oct 2021 12:37:16 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c9d83b4a-3334-11ec-83b7-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1634906236;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=Sj+Ses7UlccZ5My87x/LX91y5zR4NEchAQqGR2YjoY8=;
  b=N5aGS9SHoxGH1pxYA5xkAIv8rg6id3Xf62V2SgC3iE85Uk0VnsfD0QOy
   8oTWGa58Kt46P+gPYjSA3O1+lsxCUyb3XAQotMBvDjOOWiKVaz/TVdd3y
   MtIl16Q0O8aERKymkN7kU4gpFEWd8+Kpn+e/CnEJ88FN5a0knogoHJb46
   Y=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: UE/ygPf0ut+FK14idCfwhNSOla9JYR1qOeY37FXDtAZ6ij1+AdThdG2LNVtiXBML/+aTzKQtcQ
 qRKPHBP7JJr5w/W8655PrdNRy//SrMgIqDV39XaM+VgMP914GTF9nI/V+uJZ9bL4qvBdaG1iCT
 RtZ5NRYjZif1xsXsCotsG5f3LrYrsKmnqNdj0z/tMJMInj+JKpFgW+rm7HE2KMhmNwkb4lunEv
 5VqB6q+MqD8F927XEmS53XRyYrltd7hedZMpf2wamCEtOA1h0bC9tWKyXSW852+neOsIk45quF
 zB7s42zmJVv29Qr7HpL67ubr
X-SBRS: 5.1
X-MesageID: 56216545
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:UJKzY6svoQXraeTJdZYRwDkSyefnVMRZMUV32f8akzHdYApBsoF/q
 tZmKWCEM/aLYGD3L9oiad+z8h5SuMfTmNBmSwtq+Ho8Ri0W+JbJXdiXEBz9bniYRiHhoOOLz
 Cm8hv3odp1coqr0/0/1WlTZQP0VOZigHtIQMsadUsxKbVIiGHhJZS5LwbZj29cw24LhWWthh
 PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe
 gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ
 NpllI6Cdw4Vbq7wgPUNbBgDKAhcM/Zc0eqSSZS/mZT7I0zudnLtx7NlDV0sPJ1e8eFyaY1M3
 aVGcnZXNEnF3r/ohuLgIgVvrp1LwM3DNYUDunZm3HfBAOwvW5zrSKTW/95Imjw3g6iiGN6DO
 ZBAN2czMXwsZTVlZGw+Go9vu92rvVb0Wmd060Co/oMotj27IAtZj+G2bYu9lsaxbc5chEqfq
 0rN9n71BRxcP9uaoRKa9lq8i+mJmjn0MKoJCLC2//htxkaPz2YeDBkXU1qTsfi9i0iuHdlYL
 iQ84TEypKI/8EiqSNjVXBCipnOA+BkGVLJ4A+A8rQ2A1KfQywKYHXQfCC5MbsQ8s807TiBs0
 UWG9/voGj5HoLCTUWia9LqfsXW1Iyd9EIMZTXZaF01fuYCl+dxtyEKUJjp+LEKrpvznKw/5/
 2CJkDAvl4oS1vUi9avg53mS1lpAuaP1ZgIy4wzWWEes4QV4eJOpauSU1LTL0RpTBN3GFgfZ7
 RDoj+DbtbpUVcjcy0RhVc1UROnxj8tpJgEwlrKG83MJzD+q52K4Nb5Z5DVzNS+F2e5VJGe3P
 ic/Ve5XjaK/3UdGj4crPOpd6OxwlMAM8OgJsNiOMrKihbAqLGe6ENlGPxL44owUuBFEfVsDE
 Zmaa92wKn0RFL5qyjG7L89Ej+R3lnxnmjOLHs2qp/hC7VZ4TCTJIVviGADWBt3VEYve+FmFm
 zqhH5viJ+pjvB3WPXCMrN97waEiJnknH5Hmw/G7hcbYSjeK7FoJUqeLqZt4ItQNt/0Myo/go
 yHsMmcFmQGXrSCWdm23hoVLNeqHsWBX9ilgY0TB/D+AhhAeXGpYxP5OLsVtJeB6rLALIDwdZ
 6BtRvhsy89nElzvkwnxp7GmxGC7XBj01w+IIQS/Zz0zI8xpSwDTo4e2dQrz7igeSCGwsJJm8
 bGn0wraR7sFRhhjU5mKOK7+kQvpsChPgv92UmvJPsJXJBfm/r91JnGjlfQwOcwNd0nOn2PIy
 waMDB4EjuDRuItposLRjKWJot7xQetzF0ZXBUfB6rOyOXWI92av29YYAu2JYSrcRCX//6D7P
 bdZyPT1MfsmmldWstUjT+Y3nPxmv9a2/u1U1AVpGnnPfm+HMLI4LynUx9RLu41M2qRd5Vm8V
 HWQ94QIIr6OIs7kTgIcfVJ3cuSZ2PgIsTDO9vBpcl7i7Sp68bfbA0VfOx6A1H5UILdvad53x
 O4gvIgd6hCliwpsOdGD13gG+2OJJ30GcqMmqpBFX9O71lt1kglPMc7GFyv7wJCTcNEdYEAlL
 widiLfGm7kBlFHJdGA+FCSV0OdQ7XjUVMumELPWy4y1p+f4
IronPort-HdrOrdr: A9a23:wSoM3qOpJd9jgcBcTsGjsMiBIKoaSvp037Eqv3oedfVwSL39qy
 nOpoV/6faaslsssR0b9exofZPwJk80lqQFg7X5X43DYOCOggLBR+tfBMnZsl7d8kXFh4hgPM
 xbEpSWZueeMWRH
X-IronPort-AV: E=Sophos;i="5.87,172,1631592000"; 
   d="scan'208";a="56216545"
Date: Fri, 22 Oct 2021 13:37:11 +0100
From: Anthony PERARD <anthony.perard@citrix.com>
To: Stefano Stabellini <sstabellini@kernel.org>
CC: <xen-devel@lists.xenproject.org>, <iwj@xenproject.org>,
	<cardoe@cardoe.com>, <wl@xen.org>, <andrew.cooper3@citrix.com>, "Stefano
 Stabellini" <stefano.stabellini@xilinx.com>
Subject: Re: [PATCH 1/3] automation: add x86_64 alpine 3.12 test-artifact
Message-ID: <YXKwd7hIOYuUbpx3@perard>
References: <alpine.DEB.2.21.2110210831470.2311@sstabellini-ThinkPad-T480s>
 <20211021230839.10794-1-sstabellini@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20211021230839.10794-1-sstabellini@kernel.org>

On Thu, Oct 21, 2021 at 04:08:37PM -0700, Stefano Stabellini wrote:
> From: Stefano Stabellini <stefano.stabellini@xilinx.com>
> 
> It is the same as the existing ARM64 alpine 3.12 test-artifact. It is
> used to export an Alpine rootfs for Dom0 used for testing.
> 
> Also add the exporting job to build.yaml so that the binaries can be
> used during gitlab-ci runs.
> 
> Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>
> ---

Reviewed-by: Anthony PERARD <anthony.perard@citrix.com>

This feels weird to me that we have a container just to share a file,
but I guess that works :-).

Thanks,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Fri Oct 22 12:38:50 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Oct 2021 12:38:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.215053.373999 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdtow-0006Gy-JJ; Fri, 22 Oct 2021 12:38:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 215053.373999; Fri, 22 Oct 2021 12:38:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdtow-0006Gr-GU; Fri, 22 Oct 2021 12:38:50 +0000
Received: by outflank-mailman (input) for mailman id 215053;
 Fri, 22 Oct 2021 12:38:48 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=VW94=PK=citrix.com=anthony.perard@srs-us1.protection.inumbo.net>)
 id 1mdtou-0006Ge-Mg
 for xen-devel@lists.xenproject.org; Fri, 22 Oct 2021 12:38:48 +0000
Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id f1fa3e5d-a85a-4501-8542-3602e35cf11e;
 Fri, 22 Oct 2021 12:38:47 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f1fa3e5d-a85a-4501-8542-3602e35cf11e
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1634906327;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=Z1Z6jhG085EWMEuZmmZShBtKDLuvFWfIQSNlH7YyHrM=;
  b=PuxSRd0eBfKoGHC2sdp0xC2vQXJzBYA7kXxdJ4kv6xawrhTvZm9ntmyg
   E+kU04RX3f08jp2VJlyoOriGFYgzQcta2cDzxP7uCnYw7FjWLW5M0oIKf
   mC5UBfPrfwz6qQ90vlDIilZMCN+95ztEl16NRegTbuJG87vlMJrc0UFhR
   Y=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: vujeZf3sLv9TngPJZkTuCI2jzewJYBrjtb0NPTiY035Js9sPZBeRDjI2EljOJnwA8kgSg+sUYJ
 4pn5DBpQdIId1aoCcMvhzIQqJZsU5HOZdCMFzw12djZIju6RZZuYhSprvu8xXbjKbbEjPo/B37
 X7JUzZ7pIbI+2EVPDzh4bNbEBm+cT5uwC9f+TtE2OIz5QuHfbZ/od+XzbrZN//i/7UzERkfBnx
 d0CFVc6o+tAXfN0zFHhY0PS3tGjzai+kIFJUaoaXc0OvRmzpmOythY1Fh8bSqPZvxQHvFdd+p2
 mLw4dmokHUNKAWhjIBWwmSEw
X-SBRS: 5.1
X-MesageID: 56216652
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:RPgdPqkJ+YrAZwtDG8VB4fno5gwTIURdPkR7XQ2eYbSJt1+Wr1Gzt
 xIWXm/UMvnbZWv0etpyOYW1pxwBsMWGnIJhG1Q4rys0QSMWpZLJC+rCIxarNUt+DCFioGGLT
 Sk6QoOdRCzhZiaE/n9BClVlxJVF/fngqoDUUYYoAQgsA187IMsdoUg7wbdg2tQy2YLR7z6l4
 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc
 s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4
 I9D5brvWysbB5PdqfYzVBIIDxhDEoQTrdcrIVDn2SCS50jPcn+qyPRyFkAme4Yf/46bA0kXq
 6ZecmpUKEne2aTmm9pXScE17ignBMDtIIMYvGAm1TzDBOwqaZvCX7/L9ZlT2zJYasVmQKiEP
 pRHNGAHgBLocQROIlUQGcICtvqsuWakfzwDrXuqjP9ii4TU5FMoi+W8WDbPQfSBTN9ZmUuwr
 Wvc82P0RBodMbS31j6t4n+qwOjVkkvTQ54fGrS+8bhxnFSZy2gXCRsXfUu6pfi/mgi1XNc3A
 1cP5iMkoKw29UqqZtrwRRu1pDiDpBF0c8pdFag25R+AzoLQ4h2FHS4UQzhZctskucQqAzsw2
 TehnszrLSxitqWPTnCQ/avSqim9URX5NkdbO3VCF1FcpYC+/sdj1XojU+qPDobvgI3TRiPc8
 Qm0vRksqbIY3dIy6oqSqAWvby2XmrDFSQs85wPyV22j7x9kaIPNW7FE+WQ3/t4bc97HFgjpU
 Gws3pHEtrhXXM7leDmlGb1VRNmUC+C53CowaLKFN6Iq8Cix4DaddIRU7SAWyKxBY5tcJ2GBj
 KM+v2psCH5v0JmCMfAfj2GZUZ1CIU3c+TLNDKy8gj1mOcAZSeN/1HsyDXN8Jki0+KTWrYkxO
 I2AbeGnBmsABKJswVKeHrlGje93n39unTiOFPgXKihLN5LEOBZ5rp9eaDOzgh0RtvvY8G05D
 f4PXyd19/mveLKnOXSGmWLiBVsLMWI6FfjLRz9/LYa+zv5dMDh5UZf5mOp5E6Q8xvg9vrqYr
 xmVBx4DoHKi1CKvFOl/Qi06AF8Zdc0k9ixT0O1FFQvA5kXPlq72vf5BLcNuIOF7nAGhpNYtJ
 8Q4lwy7KqwnYlz6F/41NPERdaRuK0amgxygJS2gbGRtdpJsXVWRqNTlYhHu5G8FCS/u7Zkyp
 Lip1wX6R5sfRls9UJaKOaz3l17h72IAnO9SXlfTJoUBckvb74U3eTf6ieU6Ip9QJEyblCeaz
 QufHTwRufLJ/90u6NDMiK3d99WpHuJyE1B0BW7e6brqZyDW8nD6md1LUfqSfCCbX2Txof3wa
 eJQxvD6EfsGgFcV7NYsT+c1lfozvoK9qaVbwwJoGGTwQ26qUr4wcGOb2cRvt7FWwuMLswWBR
 U/SqMJRPq+EOZ25HQdJdhYldOmKydodhiLWsaYuOEz/6SJ6oOiHXEFVM0XegSBRNuIoYoYsw
 ONns88K8Q2vzBEtN4/e3CxT8m2NKF0GUrkm6c5GUNO61FJzxwEQe4HYBw/3/IqLOodFPUQdK
 zOJgLbP2uZHzU3YfntvTXXA0IKxX3jVVMymGLPaG2m0pw==
IronPort-HdrOrdr: A9a23:3z+pua8fZUaDIbhbZkFuk+DaI+orL9Y04lQ7vn2YSXRuE/Bws/
 re+8jztCWE7Ar5N0tNpTntAsa9qDbnhPhICOoqTNKftWvdyQiVxehZhOOIqVDd8m/Fh4xgPM
 9bAtFD4bbLbWSS4/yV3DWF
X-IronPort-AV: E=Sophos;i="5.87,172,1631592000"; 
   d="scan'208";a="56216652"
Date: Fri, 22 Oct 2021 13:38:42 +0100
From: Anthony PERARD <anthony.perard@citrix.com>
To: Stefano Stabellini <sstabellini@kernel.org>
CC: <xen-devel@lists.xenproject.org>, <iwj@xenproject.org>,
	<cardoe@cardoe.com>, <wl@xen.org>, <andrew.cooper3@citrix.com>, "Stefano
 Stabellini" <stefano.stabellini@xilinx.com>
Subject: Re: [PATCH 2/3] automation: Linux 5.10.74 test-artifact
Message-ID: <YXKw0jfDkJ5RrvXX@perard>
References: <alpine.DEB.2.21.2110210831470.2311@sstabellini-ThinkPad-T480s>
 <20211021230839.10794-2-sstabellini@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20211021230839.10794-2-sstabellini@kernel.org>

On Thu, Oct 21, 2021 at 04:08:38PM -0700, Stefano Stabellini wrote:
> diff --git a/automation/tests-artifacts/kernel/5.10.74.dockerfile b/automation/tests-artifacts/kernel/5.10.74.dockerfile
> new file mode 100644
> index 0000000000..f2dbbecf74
> --- /dev/null
> +++ b/automation/tests-artifacts/kernel/5.10.74.dockerfile
> @@ -0,0 +1,38 @@
> +FROM debian:unstable
> +LABEL maintainer.name="The Xen Project" \
> +      maintainer.email="xen-devel@lists.xenproject.org"
> +
> +ENV DEBIAN_FRONTEND=noninteractive
> +ENV LINUX_VERSION=5.10.74
> +ENV USER root
> +
> +RUN mkdir /build
> +WORKDIR /build
> +
> +# build depends
> +RUN apt-get update && \
> +    apt-get --quiet --yes install \
> +        build-essential \
> +        libssl-dev \
> +        bc \
> +        curl \
> +        flex \
> +        bison \
> +        libelf-dev \
> +        && \
> +    \
> +    # Build the kernel

You could start a new docker "RUN" step to build the kernel.

> +    curl -fsSLO https://cdn.kernel.org/pub/linux/kernel/v5.x/linux-"$LINUX_VERSION".tar.xz && \
> +    tar xvJf linux-"$LINUX_VERSION".tar.xz && \
> +    cd linux-"$LINUX_VERSION" && \
> +    make defconfig && \
> +    make xen.config && \
> +    cp .config .config.orig && \
> +    cat .config.orig | grep XEN | grep =m |sed 's/=m/=y/g' >> .config && \

This command line could be replaced by:
    sed -i '/XEN/s/=m$/=y/' .config
But I guess Kconfig don't mind duplicated symbols.

> +    make -j$(nproc) bzImage && \
> +    cp arch/x86/boot/bzImage / && \
> +    cd /build && \
> +    rm -rf linux-"$LINUX_VERSION"* && \


> +    apt-get autoremove -y && \
> +    apt-get clean && \
> +    rm -rf /var/lib/apt/lists* /tmp/* /var/tmp/*

This apt cleaning stuff should be done right after `apt install`, and
thus before starting to build the kernel, I think.

Any any case:
Reviewed-by: Anthony PERARD <anthony.perard@citrix.com>

Thanks,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Fri Oct 22 12:54:52 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Oct 2021 12:54:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.215062.374010 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdu4H-00008z-2U; Fri, 22 Oct 2021 12:54:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 215062.374010; Fri, 22 Oct 2021 12:54:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdu4G-00008s-VX; Fri, 22 Oct 2021 12:54:40 +0000
Received: by outflank-mailman (input) for mailman id 215062;
 Fri, 22 Oct 2021 12:54:39 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=OBiv=PK=citrix.com=Andrew.Cooper3@srs-us1.protection.inumbo.net>)
 id 1mdu4F-00008g-K4
 for xen-devel@lists.xenproject.org; Fri, 22 Oct 2021 12:54:39 +0000
Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id c93a3fe3-d3f0-4088-89b8-8ca7af186956;
 Fri, 22 Oct 2021 12:54:38 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c93a3fe3-d3f0-4088-89b8-8ca7af186956
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1634907278;
  h=subject:to:cc:references:from:message-id:date:
   in-reply-to:content-transfer-encoding:mime-version;
  bh=PqgJfZ0r7c2j1QceRM/TNlaCm4F8iFzUs9Gbyswhd80=;
  b=FcMhs/Dqqa9Z5pffxDEAejBzg9OlMUoMA59ezyjyBGOrQaAtEqRn+QNp
   hCQUcOOMNpq1z6M1Vj6I9XwNn6W8u14IuOVZ4BG4NSXczlFU14eZHhwZ7
   K0g7eOSZh+dZ8VdeyrUGYFW6Bhd+NjphaHZIJu/Moesmo5EfF54363VVt
   0=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: 9CtR5RCnAM17l2i5BLOm3FqJi/X0dCJCNMbTWik1nd6JXaNBnE30oVt02L/qBeLbfhZ9LvhyWQ
 0bMbmxai/n4xNT2pVUMJ/oMObRBjpWCYthUPDFAEzmiCXe1gm3HTPd14SBFGWfgsq7qpzeQaS9
 SWE6IwSOjN/lIbYVwesRtb71g4Wp3xQmEz6Q5t+C0xyrpoaQ+hOl+FwIr7q40xaphQ8bz3CgJA
 Kun32UMr4zbdPFOIKRj+1q7fpiK84FrVfM6VagbI+jYPmcN8CPHuSCLDAO8CjkHfK6HopEiQTN
 cDpZ44XAiADJNzpFzZHFsWFG
X-SBRS: 5.1
X-MesageID: 55814691
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:wMed+arquVsT3Db+MGOSE9JV9R1eBmKzYhIvgKrLsJaIsI4StFCzt
 garIBmEbv+ONGOjfIh0OtyxpksF6sTcm983GlNq+y9nFCtE8ZuZCYyVIHmrMnLJJKUvbq7GA
 +byyDXkBJppJpMJjk71atANlZT4vE2xbuKU5NTsY0idfic5Dnd+4f5fs7Rh2Ncx2YLjW1nlV
 e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL
 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9
 DlCndu6FgM7Bo/uorpeA0hgKwx/ZIBKwIaSdBBTseTLp6HHW37lwvEoB0AqJ4wIvO1wBAmi9
 9RBdmpLNErawbvrnvTrEYGAhex6RCXvFKoZtmtt0nfyCvE+TIqYa67L+cVZzHE7gcUm8fP2O
 pdJMGYxPU2ojxtnYFU6CqAc28CR3GDzejhRjXe+gfIm2j2GpOB2+Oe0a4eEEjCQfu1UgUSwt
 m/A537+ABwRKJqY0zXt2mKhgKrDkD32XKoWFaak7bh6jVuL3GsRBRYKE1yhrpGRkVWiUthSL
 0gV/CsGrqUo8kGvCN7nUHWQu2KJsBcaXJxLD+Qw5QWJy6zVyxaYAmkCXnhKb9lOnNAybSwn0
 BmOhdyBLTdmqrGSRFqW/62Yqj70Mi8QRVLufgddE1FDuYO65thu0FSfFb6PDZJZkPWyE2700
 QiojhJgxOVCtfYm1vyW8Wj+1mfESofyciY54QDeX2SA5wx/ZZK4a4HA1WU3/cqsP67CEQHf5
 Clsd9y2qblUV8nUxXPlrPAlRenxv5643CvgbUmD9nXL3w+m/GK/Zshu6TV6KVYB3i0sKGKxP
 hG7Ve+84vZu0JqWgU1fP93Z5ycCl/GI+THZuhb8NIYmjn9ZL1fvwc2WTRTMt10BaWB1+U3FB
 b+VcNy3EVERArl9wTy9So81iOFwmnBinDyDHcumnnxLNIZyglbPFd/p13PVNogEAF6s+l2Jo
 76zyePao/mgbAEOSnaOqtNCRbz7BXM6GYr3u6Rqmh2reWJb9JUaI6aJm9sJItU994wMz7ug1
 iztCydwlQuk7VWaeFriV5yWQO62NXqJhSlgZnJE0JfB8yVLXLtDG49GJsJpJ+F+qbQ/pRO2J
 tFcE/i97j10Ym2v0xwWbIXnrZwkcxKuhAmUODGibiR5dJllLzElMPe+Fuc23CVRXCexq+Ukp
 LisilHSTZYZHlwwB8fKcvO/iVi2uCFFyu51WkLJJPhVeVntr9c2e3Cg0KdvLpFeMwjHyxuby
 x2SXUUSq97SrtJn69LOn62F8dukSrMsAkpAEmDHxr+qLi2GrHG7yIpNXb/QLzDQXW/54ou4Y
 uBRw62uOfELhg8S4YF9D6xq3eQ14N62/+1WyQFtHXPqaVW3C+w/finajJcX7qAUn+1Xowq7X
 E6L6+J2A7TRNZO3CkMVKSokcv+HiaMelA7N4KlnO079/iJ2ouaKCB0AIxmWhSVBB7JpK4d5k
 /w5scsb5gHj2BonNtGK0nJd+2iWdyFSVqwmstcRAZPxixptwVZHOMSOBijz6ZCJStNNLkh1f
 WPE2Puc3+xRlhjYbn4+NXnRxu4M150BtSdDwEIGO1nUyMHOgeU63UEJ/Dk6JuiPIs6rDw6n1
 rBXCnBI
IronPort-HdrOrdr: A9a23:DlhDvqiLRxea5JaUkYCW/tmJiXBQX0p13DAbv31ZSRFFG/FwyP
 rAoB1L73PJYWgqNU3I+ergBEGBKUmskaKdkrNhQotKOzOWxFdATbsSkLcKpgePJ8SQzJ8k6U
 4NSdkZNDS0NykBsS+Y2njJLz9D+qj/zEnAv463pB0MPGIaGJ2IrT0JbTpzencGNTWubqBJdq
 Z0iPA3wgZINU5nFfhSURI+Lpb+TpDw5d/bSC9DIyRixBiFjDuu5rK/Ox+E3i0GWzcK5bs562
 DKnyHw+63m6piAu1Dh/l6Wy64TtMrqy9NFCsDJos8JKg/0ggLtQIh6QbWNsB08venqwlc3l9
 vnpQsmIq1Imj/sV1DwhSGo9xjr0T4o5XOn4ViEgUH7qci8fz4+A9opv/MQTjLpr24b+P1s2q
 NC2GyU87BNCwnboSj779/UEzl3i0uduxMZ4K4upk0adbFbRK5arIQZ8k8QOowHBjjG5IcuF/
 QrJN3A5cxRbUiRYxnizyhSKeSXLzYO9yq9Mw0/UpT/6UkToJk59TpX+CUnpAZCyHpnIKM0oN
 gtMcxT5fhzp4EtHORA7dw6ML6K41r2MGTx2VKpUCba/Z48SgbwQr7Mkf4IDbKRCdY1JKVbou
 W3bLofjx9qR37T
X-IronPort-AV: E=Sophos;i="5.87,172,1631592000"; 
   d="scan'208";a="55814691"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=XXZtQGTO3nkedZcB89eahcY0mlZgPo7gICrunGX4A5FRzY+T5I2zv82SIKhanYv8MAnuy2x+lEOKIdXW2w7+D9t/pwVNY0bIDfhYMjcjw3x7cGi/qW31K+rJv6Eww71w90BWhLtLLZsUkm3pOM7Pw6yAwUXganbxSxdHLFw8HWDaDfqCXklwpv7WrSckonUzaO3gX12tRwHXngEhA5MVxY+Ajv3tVJaWyBlrVJnCK6PKhxlB+8+Aqqv4cVVDXulaWESNTss/limGKu66PkJGPHiIhJ6qVh4QCxc4WlE62OnpCP6II+tSTjcaRiqI0QSLU6KSrxbGW+KBgk3y6S3Rww==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=I++Rk0i8FU+aqtuOc8ns0kzzA/v5gBYYAPW/mgxsYOA=;
 b=UkJfp/qDGONNKbIuGk9j/GgJ2Vmrq8F2wbPX7BNxLjWYR2ddirF8yXBUysTZHhu4u/CXj000uLpxbyNsnTJL3VZOIsJRZoY4AXvtZBNfLUKkP+Fn+/bE7sPmx2FfTBtS3fkYBEV8Mjn43WDSJpXo/clSHjMS6w/kTCOHdn4daBBYkIv63JdkafRMYqvO41MiR4BU76La9u0k66pcx8O/Nyetg2NgQ49nlnRxb/geKP4cikQ5D8TdPgyzo+Zb/ppwy0QNzwhBwb2+tOWZ3+mn1IJ5801Pu2Uu0ll4WBb4ok4/kndgdX2XoQ+q6N3nA6+nnNcJVBt/RjEw4ETDQMTwlg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=I++Rk0i8FU+aqtuOc8ns0kzzA/v5gBYYAPW/mgxsYOA=;
 b=i7S+c9E6APS+lbtrx53D8Ez8kbncuhETJNHmr60aAEEisbY+/TugSc3YMCPnZyXJ68fHX3dMBaEwakDxsK/DVRHmfhekLQdX3S61XFv4YLNX3s8JMZsDqpXKPjLqOzje9vubODZENyZuriFAbrlHy0ziScd1Uchm1QFhfk3GShY=
Subject: Re: [PATCH 1/3] automation: add x86_64 alpine 3.12 test-artifact
To: Stefano Stabellini <sstabellini@kernel.org>,
	<xen-devel@lists.xenproject.org>
CC: <iwj@xenproject.org>, <cardoe@cardoe.com>, <wl@xen.org>,
	<anthony.perard@citrix.com>, Stefano Stabellini
	<stefano.stabellini@xilinx.com>
References: <alpine.DEB.2.21.2110210831470.2311@sstabellini-ThinkPad-T480s>
 <20211021230839.10794-1-sstabellini@kernel.org>
From: Andrew Cooper <andrew.cooper3@citrix.com>
Message-ID: <41a3622e-395f-096c-da7b-db3aa58c004d@citrix.com>
Date: Fri, 22 Oct 2021 13:54:27 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <20211021230839.10794-1-sstabellini@kernel.org>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Content-Language: en-GB
X-ClientProxiedBy: LO2P265CA0409.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:a0::13) To BYAPR03MB3623.namprd03.prod.outlook.com
 (2603:10b6:a02:aa::12)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 6559042d-ab46-43a4-b55e-08d9955b18f0
X-MS-TrafficTypeDiagnostic: BYAPR03MB3941:
X-Microsoft-Antispam-PRVS: <BYAPR03MB3941DE6606E5BEE0565099BABA809@BYAPR03MB3941.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7219;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: B6qNUQX4IqXaMMcaDSo19fgdWXRuUagrdmFT7/n1n7Xtlxy0K0bu0yU28xN5IK85p1L0OH1QIP6tAvc40DpTbvN4e7F4YCCl/uzU6EhJqqh4E49p33eMv4CvDoES9rszkPgYe1QsQ/ssz8A69lhKSEfeNA+Jn/v/yZ50uuFFU5gAGsy8SqZZOZeRdoV4C/bYHK3aJMoL4LVgfmB77o1vhF1owq8ueQpi4NT75jbuPHyRmASHymVqDZ0GE7GGAGjz8qYo5neViGfpZTNnYgiSRdQHHvgsnHFYDg31wTw9RJ/gX8ipZmKokNMsLwXnC9EiImhZ8+inbCqd2s3uD/1RQxjIeqfRIpt/YSJrbus3eMOyxwgzw9f/R6VoP3oDHmmsP3bvplP6k7V5aXa7tsJNucjXPuvKYvCsvOPZuBs3EJGry3LOBk2fyYks79rP1/eYxkLob2Vc6lquLgU8ju/vK06yVg+/RMJL5fmo6x2wMbkeiLyvSCAYks03lf/idxNih6R7OC0STUDmBvvdcbUoQnhq7GpZbm097PLs6AqA486nH4ojNrFu/BqMCXRyRY4Uh71Ptsm7PcKxsD8vTxTZcOIXbzBXXrmY42vql51Mt0UeeApNXYYMCxhrb5GpQz0RmRrCKEiQ/HPvxPltq+hbu4EEyHcuQTSnBF08FdSbd7NJ6cLmJaDjwCGnLaVgJTa+Xiwh0ELAsJbBcOV/LPkahBoJ1c1AKHFCARjCTxth/ho=
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(66946007)(66476007)(66556008)(4326008)(2906002)(16576012)(8936002)(86362001)(316002)(83380400001)(38100700002)(26005)(36756003)(6666004)(31696002)(31686004)(5660300002)(956004)(53546011)(82960400001)(4744005)(2616005)(186003)(508600001)(8676002)(6486002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RUN3WDQxVkRXQlZlSUJGbDlmOVZoUHdTcXZ4SE9JYU1GM3E0aHNrMzBIWkFu?=
 =?utf-8?B?L1ZoUTJBVmdSYTFJVU93ZDBObzdKS3FyZVBWOEJzekpLNUxQVTFpTk1ERk9y?=
 =?utf-8?B?KzZFOHNXZncvWEVPQkhWNlI5NXBkRXNkQy8zc1VtcnhBSmxUWmdTbkdDdGIw?=
 =?utf-8?B?MHVwVkZUYWdNaVJQaThDR29kV0NvSEFsUWdybkU0VDZJSExSM0psRmJNeVNa?=
 =?utf-8?B?QVRyaUZqWmN3U0hGVzdTVWxCWHpKN3VHbUJKbEp6eVAwekVCNzdPaGg1N25i?=
 =?utf-8?B?NFVyYm1BUDcwMXU5T3daN2gzSmRJaG9BZnR1N1E3K1JabkU4Lyt3dmhDNEtv?=
 =?utf-8?B?SmhVdDJhT2FpRlg0cUlldS9mbUhLNnJJa2VaZkpBekN2MmowMHAxdlpNQVVx?=
 =?utf-8?B?MVc2U1EvMkQyM3VKMnkzZUE5c3RKOWhmZWk3S0h4MjI1ZmR2TnBqUERXWkhJ?=
 =?utf-8?B?VlNoQWdwWVRKRHo5Z3dsZCtQYWtiWGZhdjFKZ04rUUN1SjBFWkIrdnlUK0Q0?=
 =?utf-8?B?YUVWREQybFpHM1JxUFRTalhXRyt1cDNIbHUrellVdzZOMlZleFVrVUphNWhw?=
 =?utf-8?B?WmFwZXJPdzc4cWNSNmFUWGlienZ5VGk4ZUdHWWIwaUo0SXZqcy82bFQ3aXpp?=
 =?utf-8?B?OTArM0hLdWUvbmVuYWFoTDhpMTc3TWtpZlVpdnJGU0tqOUE2dzd1ZWNobUlH?=
 =?utf-8?B?cS9HMnpENDlBbmRHM3U3bzRTV0s5TVN3Wm9FWm5TeGFxR212WEhudVlQbnBY?=
 =?utf-8?B?SzcvV2NRRjUzYVFXUEJhbndGbHZKQUQyZ3dyYUw3MS9ab3FSOGszUUw1L1RH?=
 =?utf-8?B?TDBNcGZVK1FHVjF5ODRWd3lkSk9JL0J0dmFXTVRCOVpvOTBpSE5oRHg1Q2pJ?=
 =?utf-8?B?SkQ1ZDRUWGQ0U3Y4Z3cwSWFGN0o5d0JJK0ZyOVpsNVdxVEMwTVlRWjd4cnM3?=
 =?utf-8?B?d3NablJLOVc1ZndPMWg4STVKdlhsWjdXZ0VNcFZPR01HQ0dqa3FYdUxJT21M?=
 =?utf-8?B?ZFZQY21qcWw0V1ozN0o5VmVpOXd6dXdRMkk2TjJTTXd4Zy96UmVZcDA0bTdu?=
 =?utf-8?B?bnpxT1RVV1lmOFNrMTNyUnQ1c3ZURURtczdhY0NBb0tQUmlHNkJVSU5aVnU2?=
 =?utf-8?B?WXFkN3VqM3Q3d3RmUE0wdmV4V3FWbnBaN2F2R1VQWlVDS29YdERJcmgwWGd6?=
 =?utf-8?B?MTNoN3FDYjZYa1ZIVkdFblczRGFGdFZuK29lMzIya1hxdjd5ZnBFK25Wc2xs?=
 =?utf-8?B?cXVvNEpIQmY3SndVdlEvbnVQZHVmUGcxQWhqc1B1c0VZL0tGVEtuREt6ZFNW?=
 =?utf-8?B?OTViT2VNc0F6dHFCQjlENU44WlZjYnUvSE9VZTBaNGxpSUx2eVY2SXJuL1Zp?=
 =?utf-8?B?dzI0Z080ZWxXMWdsaGFvSTA4K0JUcmt5bm5CSUowUEtBb3dSSEN2TWZBRVZy?=
 =?utf-8?B?N0pHcWgvVURqVHREcGpQOGpNYk0ybjFQSkgrSU5lbnQyVC9HL3JJSzV2d1Zl?=
 =?utf-8?B?QWMxaW5UVTNteDYvMzFqcmdqanEyK0dvUVdObUw4N0Q5OGQwRzcxTFNnakVC?=
 =?utf-8?B?RkMyZUdnY25nbWExc1owVnp5eHJKeUhSVXFpc3RWamVOZGlqcVM2RUFNRmdR?=
 =?utf-8?B?SGRnNXZKQXp3WjUrYkFXdUJodU96djVjNGZRN3dvZmprQWJlWktQcjRhM1Bx?=
 =?utf-8?B?dllzZTgvZ1MwdEtDeFNKSUFiS1o5bFhpT2U4Z0d5VWw0M1BFbkdSRUxxVGx5?=
 =?utf-8?B?QS9zZ2xmMG9NcWcvV2xpZ2J4S1BEOXpDdVpxbEdSMUNOb1lJWUtaVlc4ZG1X?=
 =?utf-8?B?LzJkcE92ZEhtKzNkVFRQelVwQXY3RmVtc1VpM1p2YlBrRGs2bTdkM0V6Zmls?=
 =?utf-8?B?Nk10Ky9KcDFqdFJMM2FFMXJXSWVEVlRIejJiN09HYkQrQXBOcVBTNThxdG5k?=
 =?utf-8?Q?C1A9tMkpxSp2cw5DbmOVEcsVDdVS3dAD?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 6559042d-ab46-43a4-b55e-08d9955b18f0
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Oct 2021 12:54:34.5225
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: andrew.cooper3@citrix.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB3941
X-OriginatorOrg: citrix.com

On 22/10/2021 00:08, Stefano Stabellini wrote:
> +RUN \
> +  # apk
> +  apk update && \
> +  \
> +  # xen runtime deps
> +  apk add musl && \
> +  apk add openrc && \
> +  apk add busybox && \
> +  apk add sudo && \
> +  apk add dbus && \
> +  apk add bash && \
> +  apk add python2 && \
> +  # gettext for Xen < 4.13
> +  apk add gettext && \

Unless we're planning on backporting this to staging-4.13, we can drop
gettext.  (That's the whole point of the comments highlighting version)

~Andrew


From xen-devel-bounces@lists.xenproject.org Fri Oct 22 13:01:05 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Oct 2021 13:01:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.215068.374022 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mduAP-0001bu-Pg; Fri, 22 Oct 2021 13:01:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 215068.374022; Fri, 22 Oct 2021 13:01:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mduAP-0001bn-Lu; Fri, 22 Oct 2021 13:01:01 +0000
Received: by outflank-mailman (input) for mailman id 215068;
 Fri, 22 Oct 2021 13:01:00 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=OBiv=PK=citrix.com=Andrew.Cooper3@srs-us1.protection.inumbo.net>)
 id 1mduAO-0001bh-9K
 for xen-devel@lists.xenproject.org; Fri, 22 Oct 2021 13:01:00 +0000
Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id f462fbe7-8c26-49a7-a497-6034438ba69d;
 Fri, 22 Oct 2021 13:00:59 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f462fbe7-8c26-49a7-a497-6034438ba69d
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1634907659;
  h=to:cc:references:from:subject:message-id:date:
   in-reply-to:content-transfer-encoding:mime-version;
  bh=7qrrWglLfZm9wjXodColNFfYak6vODQdGBXV+AfFEgA=;
  b=AiqakuVESTAx3drPPUCLUynfILL93OLOFq5YMCRU/w+Z8LSQ5t+H9Xfs
   iVD6EsGTScUovExh6gIFEM73yyFKT2qh+DehRCLCNbLglJ2qDmlvKEHtO
   14RcG2grSSAqmv5LYIALnbJkzfW3UQ9/z3plOpFv29yozqYN9U3v0+yE4
   I=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: UqWzL73xkdXDdmwk5bjX8ACNeYna+uCqMW8qQeh4o5euTTVCTFWdm70t+4iPM/C9wwyf+4m1Dc
 eryOmkfl4KjetD6sn4GeUtrvd9GFHO7woPlyXI6Yz4/1K6t2Dbsh4uDoljQYzeEu/g13fkWFVC
 eVsyyCfMAr8Oyeuktm52FzkSxgRmIj7JGBzy6iDgkasLn1pVN6es9tM7wIXooKegVVJxfegO6n
 +TIpZOo8ObMwJXDx8oHVhqdHt+E/n2WTddQhzw+kDoW5pNbmNUc7uDY49t/yginJrrw2cnUQd+
 w0+gxkgnyYx5Yr1lmvZUPU3J
X-SBRS: 5.1
X-MesageID: 56218149
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:kKE8+KmAbK2mzBjGL0j2Ewjo5gwqIURdPkR7XQ2eYbSJt1+Wr1Gzt
 xIXWmqGO/2Ma2P3c4wnPdiy90kHvsLUndBqHQc5pXs3QSMWpZLJC+rCIxarNUt+DCFioGGLT
 Sk6QoOdRCzhZiaE/n9BClVlxJVF/fngqoDUUYYoAQgsA187IMsdoUg7wbdg2tQy2YLR7z6l4
 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc
 s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4
 MhA76KWWAcGBbTNn+0gcF5qVHhAPbITrdcrIVDn2SCS50jPcn+qyPRyFkAme4Yf/46bA0kXq
 6ZecmpUKEne2aTmm9pXScE17ignBODtMJkSpTdLyjbBAOx9aZvCX7/L9ZlT2zJYasVmQKiEP
 ppANWsHgBLoOhkXGEslFZQHu7n0iV6kaTZ+o1+LnP9ii4TU5FMoi+W8WDbPQfSLWsd9jkuev
 njB/WnyHlcdLtP34SqI9Degi/HCmQv/WZkOD/uo+/hymlqRy2cPThoMWjOTuuKlg0SzX9ZeL
 U08+Sc0q6U2skuxQbHVRAG1rneCuVgHR9NaHuk+6QeM4rrV5wefFi4PSTspQMMinN87Q3otz
 FDht9jgHzBovZWeQGiR8brSpjS3URX5NkdbO3VCF1FcpYC+/sdj1XojU+qPDoaog4fLPyDw7
 AuTrS83upZUv4lS6aWkqAWvby2XmrDFSQs85wPyV22j7x9kaIPNW7FE+WQ3/t4bc97HFgjpU
 Gws3pHEtrhXXM7leDmlGb1VRNmUC+C53CowaLKFN6Iq8Cix4DaddIRU7SAWyKxBY5tcJ2GBj
 KM+v2psCH5v0JmCMfAfj2GZUZ1CIU3c+TLNDKy8gj1mOcAZSeN/1HsyDXN8Jki0+KTWrYkxO
 I2AbeGnBmsABKJswVKeHrlGje93n39unTiOFPgXKihLN5LEOBZ5rp9eaDOzgh0RtvvY8G05D
 f4PXyd19/mveLKnOXSGmWLiBVsLMWI6FfjLRz9/LYa+zv5dMDh5UZf5mOp5E6Q8xvg9vrqYr
 xmVBx4DoHKi1CKvFOl/Qi06AF8Zdc0k9ixT0O1FFQvA5kXPlq72vf5BLcNuIOF7nAGhpNYtJ
 8Q4lwy7Kq0nYhzM+igHbIm7q4pndR+xghmJMTbjaz86F6OMjSSUkjM9VgewpiQIEAStss4y/
 ++p2g/BGMJRTAV+FsfGLvmoygrp73QanetzWWrOI8VSJxqwoNQ7dXSpg69lOdwIJDXC2iCei
 1ScDyAHqLSfuIQy6tTI2/yJ9t/7D+tkE0NGNGDH9rLqZzLC92+uzNYYAuaFdDzQTk3u/6Cma
 bkHxv3wKqRfzl1Lr5B9A/Bgyqdnv4njoLpTzwJFGnTXbgv0VuM8cyfehcQW7/9D3L5UvweyS
 3mjwNgCNOXbIt7hHX4QOBEhMraJ28YLl2SA9v8yOkj7unN6peLVTUVIMhCQoyVBN78pYpg9y
 OIstcNKuQyyjh0mboSPgixOrjneK3UBV+Mst40AAZ+tgQ0ukwkQbZvZAy7wwZeOd9QTbRV6f
 m7K3PLP1+ZG207PU3svDnycj+NSiKMHtA1O0FJfdU+CncDIh6Nv0RBcmdjtot+5EvmTPzpPB
 1VW
IronPort-HdrOrdr: A9a23:le0zHKw/Sz6QCTq4FvLfKrPxvOskLtp133Aq2lEZdPULSKOlfp
 GV8MjziyWYtN9wYhAdcdDpAtjkfZquz+8L3WB3B8bfYOCGghrUEGgG1+XfKlLbalXDH4JmpM
 Bdmu1FeafN5DtB/LbHCWuDYq8dKbC8mcjC74eurAYfcegpUdAF0+4QMHfrLqQcfnghOXNWLu
 v/2iMKnUvaRZxBBf7LeEXtEtKz6uHjpdbDW1orFhQn4A6BgXeB76P7KQGR2lM7XylUybkv3G
 DZm0ihj5/T/M2T+1v57Sv+/p5WkNzuxp9qA9GNsNEcLnHJhhyzbIpsdrWetHQeof2p6nwtjN
 7Qyi1Qc/hb2jf0RCWYsBHt0w7v3HIH7GLj80aRhT/ZrcnwVFsBeoJ8rLMcViGcx1srvdl63q
 4O9XmerYBrARTJmzm4z8TUVjlx/3DE4UYKoKo2tThyQIEeYLheocg050VOCqoNGyr89cQODP
 RuNsfB//xbGGnqLkwxhlMfguBEY05DWytvGiM5y4ioOnlt7T5EJnIjtY8idixqzuN7d3FGj9
 60e5iA2os+CPP+VpgNcdvpd/HHfFAlcSi8Ql56Hm6XYJ3vG0i94KIfs49Frt1DRvQzvewPcd
 L6IQpliVI=
X-IronPort-AV: E=Sophos;i="5.87,172,1631592000"; 
   d="scan'208";a="56218149"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Cn7xK+mQ/kuLljvk5YIPKwWswjRviiXm5jEDZSuOjBFdncUFcbRFdso1Q2e+YWu1kIfHRfqAWxg1XBIVK4tjnhRhMtgh5Uk4gkhaoUzecVbUayZIynSwlaW6Ubf4DjXdUSrYFJYJpykLFWeASvqVwhnB2fxNdscdK1HdIaOzmFlS187/tIAOdKrsTD7jcM7XlZwSfB9/iO1Qh56oBKw5JMRynbgIbwcLsqGBrjQC+7ZZDyOzTJd/OCs6LzKM3Xgigc9NomH99vArEefsY9D8NCQlKigl0NdpMcS5F693LE99rMUmPaBC9hzHtRDZOfs454BJCV/pV2HnewkwzJl0wQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=C9oVjQeHOPjwhu27cRAxj83zXUe3eQo7qXwba7aAw3E=;
 b=T0QybBqrO7zsnJO6ZyDFvt+/6MGCdVI3T/kefdg3AYmE4NOw4X0ohZqWbBIW0PLA2J1+JbbPfLEaZcI9XF0SJkhyU81M2BuWvTJgBesmQoWMoGRTJYbHqb+io5GEWtX7DPSMWqETNsAJsIzWDfXal1sGePAsEP1PYA7/z/6FfrC5oAG2RnVCt/nqMYP5151EB0x1PoMBmS8ymdXAZVBlXOggJwg/UQkui/eAtmrU2DTXPcoayR1pyflnVbNUAcz0J2pEcySyxuaq64q3ZUzXQ/AvcgzDZBnBmyQRtFkUqVrcmcF4bO0z1+0AStvregf+K/yjZpOEa7JGR5QEojWfCw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=C9oVjQeHOPjwhu27cRAxj83zXUe3eQo7qXwba7aAw3E=;
 b=tssZ+LnGmUXeaAe7YYF1AdllTBMe3tqY20jsU7judPe7PVpzONynGGSc/Pxc1P1TgyNifHikOR1x2Hu1QI26oKp7qTJUADYG8xyKAl0q1WIGYqnwCJsvEgeA5hWy10+aicHpmJpoW6l+jIsOpehmwtSbiL7fJjYt0WjRBtUJ58k=
To: Stefano Stabellini <sstabellini@kernel.org>,
	<xen-devel@lists.xenproject.org>
CC: <iwj@xenproject.org>, <cardoe@cardoe.com>, <wl@xen.org>,
	<anthony.perard@citrix.com>, Stefano Stabellini
	<stefano.stabellini@xilinx.com>
References: <alpine.DEB.2.21.2110210831470.2311@sstabellini-ThinkPad-T480s>
 <20211021230839.10794-2-sstabellini@kernel.org>
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH 2/3] automation: Linux 5.10.74 test-artifact
Message-ID: <19aa9196-eb5f-22a1-206c-c9c87ee79fa9@citrix.com>
Date: Fri, 22 Oct 2021 14:00:45 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <20211021230839.10794-2-sstabellini@kernel.org>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Content-Language: en-GB
X-ClientProxiedBy: LO2P265CA0409.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:a0::13) To BYAPR03MB3623.namprd03.prod.outlook.com
 (2603:10b6:a02:aa::12)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: cdf93295-8a68-422f-c1c4-08d9955bf932
X-MS-TrafficTypeDiagnostic: BYAPR03MB4871:
X-Microsoft-Antispam-PRVS: <BYAPR03MB48711DE2CBDE74C8443B93A6BA809@BYAPR03MB4871.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:1417;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: OgLfVxOdUc6nDkYLiQoP0nTIppDuDOEgZvE23ivXGYZ1nxyve/xuDG7lrZKV/hR5Oc9q1iXT//u5Ku8yRo1UjrcamrqdH5XAoaAqTTwjGAZQpzWvJIzNnoEOPKUH1berrghw+esQvvGHMgSzlSURha1JTPuAxGjOJBmN9vDzpI2gKoRT19wl6CcuurKtxfWdxMdFXdi8A/OfwBZQSOHx+AMONH67oW7whGCKMbIDKJB2W8H5QWu7/sFQPahl2Yg0sUku4Y+ONvHPhz2m0Bi3P6l2SjnrNqeP5WXyRtpCJRSIXXDYt/S2NoQ1tPG8peKtF2GC0pegb5OjRZmoYfhmOZB7QW9qLSC9D60E5RSGcelECcGJxwYvPs+AfEJgjQj7HmOYpYCXloLL0ovjA7+p9Bh+Q9i26uX9lerkzBhIbdhg/5YWwrzFFVNIJXQFZHxG+eiVeCdvtDIy9/qovAzbkWGVWBICTaINo/gprHyP9FEe3CelwiH8oE3RpR1TkZB75u4Z1HY+yHwfRhsp8GGFCwlKxluMXJNTE+WMh+a3wGvXEGzdiDpXCJChc0Ws5QMALYAr+kt9sfPbsD598tJ0z8O5k7nv5VIbQnQFITJTY50TEiQa1NNmrsUuYmaSWx0QgIQFYR/5QoMiCJQD4oWqFPWRJC2g6v1mkauMvaFUrgAKwQ08v8YH6YF0Ix3U6MJrGDQO7jZWqxMHlTdJ33Fm+Ig9yaaxi2nZ+0N0/2LaYidE0qnhMlh8JWnR4sF+3y5zFPFSxm7grxWe02w1zvICsWJ792InRbzuZLTxS7Vfe+dujtla+WP2yR34mhYL9boH
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(8936002)(38100700002)(83380400001)(8676002)(6666004)(956004)(186003)(53546011)(508600001)(6486002)(31696002)(16576012)(316002)(82960400001)(5660300002)(66946007)(66556008)(66476007)(36756003)(86362001)(966005)(2906002)(4326008)(4744005)(2616005)(26005)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NEtDMHdjMUY0SW92VXNQbWszVEZUMVJBVERtM1BmZkxPcTdjVDg5TVJRTVdZ?=
 =?utf-8?B?WWsxM3FHYTVNUWMwclFURVBpekR5NS9JQ2RmRUdQeHh5RVNoOWFnWWE0eG5w?=
 =?utf-8?B?TkhpcW50VjF0TFptaGJVckxzbHVsSGpFdkU3SC8yZ3BSYVB0UDduMm1abDha?=
 =?utf-8?B?Ry9Nbmp5ZGdRZERuem9yZ1h2akxzdDZtNTg4Uy9uTlVwYUZLc1JPT2E4MExW?=
 =?utf-8?B?dnpkMFc1SnNIalpZWEw3VWNPdXZXTjViRXZQT05CQnNOZXRkbVl6dzJjOFFX?=
 =?utf-8?B?VXowVUVWSyt5MUxzUmt5cWMrVlZVUDg3cTJQQTY0MnpxLytIbUZpcDg3MFJF?=
 =?utf-8?B?NzRKWmJTcmJ0c2E4Z25FbzZ1NjVobTRUcUtUNEZaWTNsS2hEZ09BV3BGbitX?=
 =?utf-8?B?Nnd2a1FaT1VZelJZMURUUmxjMzVWWHVNd0ZUc1ZSeFFoSDVUaVdldlVhVlRk?=
 =?utf-8?B?aWJsMUVlNFlUWjQ2ZzVGSDR1YXJFMkI4UHJYTW5tRlhha2dyWVRhSTVZZEhm?=
 =?utf-8?B?bEpZSC9FNEZlNTgvNVViOTAzWnptZDR5YTVFMFBjalQrc0VaTm1MUE1tMkN0?=
 =?utf-8?B?NzNIR2xZaFFWdG84T1d4OEdVdHI1Qks1TkNtdkhMdTdNQXRtd3FKa1VadlJq?=
 =?utf-8?B?THhTWFovYW9rSWNZOGgrNFJYalBTTUNrN3Z4dE1tdXA0c2pEVWRSZ3hLN0FJ?=
 =?utf-8?B?Y2puSzlXM2NkM29kcFNhNW9DMkRlVjkzMFhVU1F6YkNLTC92eXhIaUwxZVIw?=
 =?utf-8?B?Wnh5eXAxemFkQk8zUGtkejhJcEY2VkMzbWdiRThTQmtRaGhYK0xxSjhNeFh3?=
 =?utf-8?B?M2dmNHFnUnZKRTdVcmVWWFhEY2VOMUNTUGZBQzRRUDJRVS9md0l4cTZXcmpp?=
 =?utf-8?B?V1lwR2lTZ3hCcEt1SERZeE1RQzN0cjFUMG4rbUhBbHdaQlhOOS91UEdEQXN4?=
 =?utf-8?B?K21GMnFxMTI2eld1Z1J5d0xVUTBFSUdHL0VaSS9zR1VKTWY3UHFVZmZqU2Jr?=
 =?utf-8?B?aEl3MVlXWC9xTHhIc1ErMVcrSFBqR0Y4OTZBaVNNVm1DMllWVmJDSHQxSVJh?=
 =?utf-8?B?azhxcjljRUJhVE5rM0ZnbG1ZdldoaHBsYWtHMERQQnJ1N3J3WC9xTWViS2Ir?=
 =?utf-8?B?SXFPOGVGSHZLclpQOERnTlJVbHhici84TTdMUm9ZbURuVUVTMjljR2p2aU42?=
 =?utf-8?B?aUs1V3FQTHJhc0o1eWc2dWlhR1hYcXlrOFpNcXFFWDRUUW5HQ0ZCL2dMUVZL?=
 =?utf-8?B?c3dZQ0ZaVlhKYnR6amZhNGRoaFVIV1JYVGlsS0J6aktTYnp2amY0NlYzbFNj?=
 =?utf-8?B?cnJjVkFwd2JGT2lKS3o4cHEwQXduOUVMM2hzUGJTQnUzWFJMSGExZEF1UitV?=
 =?utf-8?B?bXEwTTFLNnJ0NjRzUXZVM0hrRlpSNnVmTUwvODEwc2h4Vnl4enljYkdVdzhs?=
 =?utf-8?B?TFdnSCsvNzAybWFLRVNsUnBDSVVCWEZ4b24wN1lCOVBpRWt6c1ZzbVExYlpi?=
 =?utf-8?B?dmtncGVmZnluYkhETjVrOVVoeXZhTFQ3UGJqNlFMSDVmTUcwVS9LRTdXd2VG?=
 =?utf-8?B?bnhLbEt1OGJTZVQ4cm96cFQrMHp1YTBIelI0MEVBSE4vei9LdCs0dHl6QnhD?=
 =?utf-8?B?cWxydThGK2d1cGVPY3FMek04Ymd3K2dER08rODM0OG5CVGNVcGd5UW1EMUI3?=
 =?utf-8?B?U0tXVVVyK2FWblltV21oSzd2c1k1Z01TTHZrN2pQQUNNTXdtVWlETHoyWTV4?=
 =?utf-8?B?enRsMUR0Z09lV0JDWkdsT1hrMWszVEg4Slg0OEU1T2o4cWk1YmFYRC9Nbitn?=
 =?utf-8?B?Z3RJYk50bjVZR0hraU1nVlcrUStJSEd3cThBOGkwTE1ydW5ySTJQOTZ1UnV3?=
 =?utf-8?B?RXJ2UGlRSnJ2MTN1a2lKWW5WeWFRRm1salFjc29QS21xWjdCcEZNUVRVanZP?=
 =?utf-8?Q?y6QvvAegn1rAi8laq2Zim7x2DVT/WO5e?=
X-MS-Exchange-CrossTenant-Network-Message-Id: cdf93295-8a68-422f-c1c4-08d9955bf932
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Oct 2021 13:00:50.6210
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: andrew.cooper3@citrix.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB4871
X-OriginatorOrg: citrix.com

On 22/10/2021 00:08, Stefano Stabellini wrote:
> +# build depends
> +RUN apt-get update && \
> +    apt-get --quiet --yes install \
> +        build-essential \
> +        libssl-dev \
> +        bc \
> +        curl \
> +        flex \
> +        bison \
> +        libelf-dev \
> +        && \
> +    \
> +    # Build the kernel
> +    curl -fsSLO https://cdn.kernel.org/pub/linux/kernel/v5.x/linux-"$LIN=
UX_VERSION".tar.xz && \
> +    tar xvJf linux-"$LINUX_VERSION".tar.xz && \
> +    cd linux-"$LINUX_VERSION" && \
> +    make defconfig && \
> +    make xen.config && \
> +    cp .config .config.orig && \
> +    cat .config.orig | grep XEN | grep =3Dm |sed 's/=3Dm/=3Dy/g' >> .con=
fig && \
> +    make -j$(nproc) bzImage && \

defconfig is huuuuge.=C2=A0 Can we use tinyconfig instead?

Also, you want to turn off CONFIG_MODULES seeing as you only copy
bzImage to the test.

This also fixes the fact that `grep XEN` also matches CONFIG_NETXEN_NIC
which has nothing to do with Xen.

~Andrew



From xen-devel-bounces@lists.xenproject.org Fri Oct 22 13:03:26 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Oct 2021 13:03:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.215074.374033 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mduCj-0002DK-5v; Fri, 22 Oct 2021 13:03:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 215074.374033; Fri, 22 Oct 2021 13:03:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mduCj-0002DD-2v; Fri, 22 Oct 2021 13:03:25 +0000
Received: by outflank-mailman (input) for mailman id 215074;
 Fri, 22 Oct 2021 13:03:23 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=VW94=PK=citrix.com=anthony.perard@srs-us1.protection.inumbo.net>)
 id 1mduCh-0002D5-NR
 for xen-devel@lists.xenproject.org; Fri, 22 Oct 2021 13:03:23 +0000
Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 6f09a1fa-3338-11ec-83bb-12813bfff9fa;
 Fri, 22 Oct 2021 13:03:22 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6f09a1fa-3338-11ec-83bb-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1634907801;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=5LzHuJwEVZ+m+pg82cbcA7Xwz9U17b7FbC2bivN423Q=;
  b=LPc3TVaMpHMoEYK/X5uhh6Jrw6jqh7Ob8E1PHGDhK0FlRsLw/n9fvlOr
   XboOhLBmxl6oUNrfoGbIkKEs2XwfnbkZvOhOv0KsmHLnZ1rSJRLC7qfrg
   kNgrzv3SeJfDoszFXrUz1BUbgSQN+i2Rd00TrOMibI3KoCjxXKGLgCqn3
   g=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: Pvq6OVMItqwLNyTDaSTXVj2Ozhv6EQTBgd9EIPlld/79sjVrpe+OqxWPtZjyDXWL9Yog86sWL8
 OLx6eUbGCzedRCzjvrdg9G8CFvnH0sCVvjemhINAXppDHnujObw1/i62m7mcTWVzlaCd+7pLWw
 cjFhyI+Zy780IcUrEV1CDQjxMMtr+SY42Gz0NmHX/K+aaF4lMzcTC3MvDnEc5LFpOEGpqzSjPj
 H4G7gipnnhDx5WzT9xBFBtetIOMb9msQ3b1jcnLSOp98auy/jyY0JzAqvYIPLG6MqsP26cs6pu
 qeKlu4lSe9r58WuUUWn7TU7s
X-SBRS: 5.1
X-MesageID: 56218610
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:cFCs065bb33ob6W06nFlTgxRtKrAchMFZxGqfqrLsTDasY5as4F+v
 mRJXjuOO6mDazekeNggao3i8hkP6MLXzINnGQNtqSpnHi5G8cbLO4+Ufxz6V8+wwmwvb67FA
 +E2MISowBUcFyeEzvuV3zyIQUBUjclkfJKlYAL/En03FVAMpBsJ00o5wrdh2NQw27BVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Z0
 +h3t5KrRAUTP4LAwO8YCh5WFxhgIvgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALJc/3PIQZqzd4wCvQF/oOSpHfWaTao9Rf2V/cg+gTQ6yHN
 5RAMVKDajzcfzl1N10aMasds7inmSPffgdGrF288P9fD2/7k1UqjemF3MDuUteDX8lSk26Tr
 3jK+Gm/CRYfXPSAzRKV/3TqgfXA9QvgRI8cHbu/sOV2iVeewmgSDhw+RVq/oP+pzEW5Xrp3M
 FcI8yAjqawz8k2DTdTnWRC85nmesXY0S9dWVuE39gyJ4q7V+BqCQHgJSCZbb94rv9NwQiYlv
 neIgNHBFTFpqKeSS3+W6vGTtzzaBMQOBTZcP2leF1JDuoS95tFo5v7Scjp9OLWItN/7Ajzy+
 TGloHA1guwUg8oyybruqDgrnAmQjpTOSwc04CDeUWSk8h51aeaZWmC41bTIxa0fdNjBHzFtq
 FBBwpLEtLlfUvlhgQTUGL1VdIxF8cppJ9E1bbRHJJIm6yi2s0CqeYRd8VmSz284b55aJ1cFj
 KLV0D69BaO/3lP2MsebgKrrUqzGKJQM8/y/Cpg4ifIVOvBMmPevpn0GWKJp9zmFfLIQua8+I
 4yHVs2nEGwXD69qpBLvGbxBgeNymXBmnj6CLXwe8/hB+eDCDJJyYexdWGZik8hjtP/UyOkr2
 4Y32zS2J+V3D7SlP3i/HX87JlEWN3krba0aWOQMHtNv1jFOQTl7Y9eImOtJU9U8w8x9y7eZl
 lngCxQw4Aeu2hX6xfCiNykLhEXHBs0k8xrW/EUEYD6V5pTUSd/+tflFL8JqJeVPGS4K5accc
 sTpsv6oWpxnIgkrMRxHBXUkhIA9JhmtmyyUOC+pPGo2c5J6HlSb8d74ZAr/siIJC3Pv58c5p
 rSh0CLdQIYCGFs+XJqHNqr3wgPjp2UZlcJzQ1DMfotZdnLz/dU4MCf2lPI2fZ0BcE2R2juA2
 g+KKh4Evu2R8ZQt+dzEiPnc/YekGudzBGRAGGzf4erkPCXW5DP7k4RBTPyJbXbWU2atoPeuY
 uBczvfdNvwbnQkV79ogQugzla9nvonhvb5XyAhgDU7nVVXzB+MyOGSC0OlOqrZJmu1TtzypV
 x/d4dJdI7iIZp/oSQZDOAo/Y+2f/vgIgT2Ov+8tKUD36SIrrrqKVUJeY0uFhCBHdeYnNYokx
 aEqudIM6hz5gR0va47UgidR/mWKD3oBT6R46c1KXN610lImmgNYfJjRKi7q+5XeOdxDP34jL
 iKQmKef1a9XwVDPciZrGHXAtQaHaU/iZPyeIIc+Gmm0
IronPort-HdrOrdr: A9a23:6wCOj61emC3zw85DTrgP2gqjBLIkLtp133Aq2lEZdPRUGvb3qy
 mLpoV+6faUskd1ZJhOo7290cW7LU80sKQFhrX5Xo3SPjUO2lHJEGgK1+KLqFfd8m/Fh41gPM
 9bAs5D4bbLbGSS4/yU3DWF
X-IronPort-AV: E=Sophos;i="5.87,172,1631592000"; 
   d="scan'208";a="56218610"
Date: Fri, 22 Oct 2021 14:03:17 +0100
From: Anthony PERARD <anthony.perard@citrix.com>
To: Stefano Stabellini <sstabellini@kernel.org>
CC: <xen-devel@lists.xenproject.org>, <iwj@xenproject.org>,
	<cardoe@cardoe.com>, <wl@xen.org>, <andrew.cooper3@citrix.com>, "Stefano
 Stabellini" <stefano.stabellini@xilinx.com>
Subject: Re: [PATCH 3/3] automation: add a QEMU based x86_64 Dom0/DomU test
Message-ID: <YXK2lTWZHiTXIBtJ@perard>
References: <alpine.DEB.2.21.2110210831470.2311@sstabellini-ThinkPad-T480s>
 <20211021230839.10794-3-sstabellini@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20211021230839.10794-3-sstabellini@kernel.org>

On Thu, Oct 21, 2021 at 04:08:39PM -0700, Stefano Stabellini wrote:
> diff --git a/automation/scripts/qemu-alpine-x86_64.sh b/automation/scripts/qemu-alpine-x86_64.sh
> new file mode 100644
> index 0000000000..41b05210d6
> --- /dev/null
> +++ b/automation/scripts/qemu-alpine-x86_64.sh
> @@ -0,0 +1,92 @@
> +#!/bin/bash
> +
> +set -ex
> +
> +apt-get -qy update
> +apt-get -qy install --no-install-recommends qemu-system-x86 \
> +                                            cpio \
> +                                            curl \
> +                                            busybox-static

Please, don't install packages during the CI job. If you need new
packages, update the container.

That said, "curl" doesn't seems to be needed.

> +# DomU Busybox
> +cd binaries
> +mkdir -p initrd
> +mkdir -p initrd/bin
> +mkdir -p initrd/sbin
> +mkdir -p initrd/etc
> +mkdir -p initrd/dev
> +mkdir -p initrd/proc
> +mkdir -p initrd/sys
> +mkdir -p initrd/lib
> +mkdir -p initrd/var
> +mkdir -p initrd/mnt
> +cp /bin/busybox initrd/bin/busybox
> +initrd/bin/busybox --install initrd/bin
> +echo "#!/bin/sh
> +
> +mount -t proc proc /proc
> +mount -t sysfs sysfs /sys
> +mount -t devtmpfs devtmpfs /dev
> +/bin/sh" > initrd/init
> +chmod +x initrd/init
> +cd initrd
> +find . | cpio --create --format='newc' | gzip > ../initrd.cpio.gz

This isn't confusing at all, depending on the tool used to make an
archive, the resulting initrd has a different purpose :-).
    initrd.tar.gz -> dom0
    initrd.cpio.gz -> domU

> +cd ..

Maybe add a comment here saying that we are now preparing dom0 root
filesystem? (as there is one for domu)

> +mkdir -p rootfs
> +cd rootfs
> +tar xvzf ../initrd.tar.gz
> +mkdir proc
> +mkdir run
> +mkdir srv
> +mkdir sys
> +rm var/run
> +cp -ar ../dist/install/* .
> +mv ../initrd.cpio.gz ./root
> +cp ../bzImage ./root
> +echo "name=\"test\"
> +memory=512
> +vcpus=1
> +kernel=\"/root/bzImage\"
> +ramdisk=\"/root/initrd.cpio.gz\"
> +extra=\"console=hvc0 root=/dev/ram0 rdinit=/bin/sh\"
> +" > root/test.cfg
> +echo "#!/bin/bash
> +

Maybe add `set -x` ?

> +export LD_LIBRARY_PATH=/usr/local/lib
> +bash /etc/init.d/xencommons start
> +
> +xl list
> +
> +xl create -c /root/test.cfg
> +
> +" > etc/local.d/xen.start
> +chmod +x etc/local.d/xen.start
> +echo "rc_verbose=yes" >> etc/rc.conf
> +find . |cpio -H newc -o|gzip > ../xen-rootfs.cpio.gz
> +cd ../..
> +
> +cat >> binaries/pxelinux.0 <<- EOF

So, I've look at <<- meaning as I never used that before and it seems to
remove all leading tab chr from the input, yet they are no tab in the
input. So maybe use just <<EOF instead, without the dash -.

> +#!ipxe
> +
> +kernel xen console=com1
> +module bzImage console=hvc0
> +module xen-rootfs.cpio.gz
> +boot
> +EOF

Thanks,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Fri Oct 22 13:25:48 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Oct 2021 13:25:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.215088.374050 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mduYH-0004dY-81; Fri, 22 Oct 2021 13:25:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 215088.374050; Fri, 22 Oct 2021 13:25:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mduYH-0004dR-3Y; Fri, 22 Oct 2021 13:25:41 +0000
Received: by outflank-mailman (input) for mailman id 215088;
 Fri, 22 Oct 2021 13:25:40 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=fDp0=PK=citrix.com=roger.pau@srs-us1.protection.inumbo.net>)
 id 1mduYG-0004dL-8w
 for xen-devel@lists.xenproject.org; Fri, 22 Oct 2021 13:25:40 +0000
Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 8bf2a96c-333b-11ec-83bd-12813bfff9fa;
 Fri, 22 Oct 2021 13:25:39 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8bf2a96c-333b-11ec-83bd-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1634909138;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=3OhnVogEZ9DREjff4q/jbUTUQC22RXlS8PJxdLEABVA=;
  b=ePje5r9yhTtX+ezaTEWuKvNQ3qwSWQ1TI4cFbIJxD/JqZiQkXVia94Rh
   OaAMPFhjhaZy3Ggvp2+9Y+c0IBrsVdCJ4yOM7xmFTuWpmKzw6cFiVk0B1
   lA9cEJt2wGQOWE8n1nU776u7ntYazl/b3gioJ7PtU1SYIV6OhPypXgyw4
   s=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: BYHZkNO79BEQs5tsZgV5nLF06L1CvqoC/I39Dnm+1k9GlnyJY8fFX9GF/Pz0d6BRg3XB/e11nI
 s59K8UAewWadZkxUFBMDpO/QikOPUEkw5d49NSxaTPrkjEMNwVcK3ES4rB2gbpc6i6FJpZi9lG
 8oucgKMkRoAiSO+CfhT/Ibqw3yAK3pJIw7oirJkN4ftGz9faoO1ZzMHU/7IQ7/KveX9iTO15+K
 GUfr1bZFxduHSOSANLK0ZuSXhrEDlF4q9pD3dbajGV9hkIrHUrL69HJ7MbP8YjrfbuP6LW3SLS
 CpMQSoAPvaggRK+joJQxUJoF
X-SBRS: 5.1
X-MesageID: 56220844
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:cIvE66AVNV5YqBVW//Lkw5YqxClBgxIJ4kV8jS/XYbTApDsmhDADz
 DMaCDzSMv7YYjH8Ko13b4myoUgBuZ7Rztc3QQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA
 xA2M4GYRCwMo/u1Si6FatANl1ElvU2zbue6WLGs1hxZH1c+EX5500g7wYbVv6Yz6TSHK1LV0
 T/Ni5W31G+Ng1aY5UpNtspvADs21BjDkGtwUm4WPJinj3eH/5UhN7oNJLnZEpfNatI88thW5
 Qr05OrREmvxp3/BAz4++1rxWhVirrX6ZWBihpfKMkQLb9crSiEai84G2PQghUh/qgqWtMsvy
 o906J3hcQM0N4TQwuI2ekwNe81+FfUuFL7vJHG+tYqYzlHccmuqyPJrZK00FdRGoKAtWzgIr
 KFGbmBWBvyAr7veLLaTUO5ji95lNMD2FIgepmth3XfSCvNOrZXrHvuQv4cIgGtYasZmTanue
 pUrYjxVSwmRex1GBhBNFs4Pg7L97pX4W2IB8w/EzUYt2EDMyCRh3b6rN8DaEvSaSMMQkkuGq
 2bu+2XiHgpcJNGZ0SCC8H+nmqnIhyyTcIAYGaC89/VqqEaO3WFVAxoTPWZXutHg1BT4AYgGb
 RVJpGx+9sDe6XBHUPHcYAKTuyCG5CdBWotoF/AzwR3XzIH9tlPx6nc/chZNb9kvtckTTDMs1
 0OUk96BOQGDoIF5WlrGqe/K9WLa1Tw9aDZYP3ddHFRtD8zL+dlr1nryosBf/LlZZzEfMQr7x
 CyWt2AAjrEXgN9jO06TrA2f3WzESnQkSGcICuTrsoCNslwRiG2NPdXABb3nARBodtrxor6p5
 yBspiRmxLpSZaxhbQTUKAn3IJmn5uyeLBrXikN1Ep8q+lyFoiD4IdAMuW4ufBw0Y67onAMFh
 meJ5Wu9A7cIZBOXgVJfOdrtW6zGM4CwfTgaahwkRoUXOcUgHON21CpveVSRzwjQfLsEyskC1
 WOgWZ/0Vx4yUP0/pBLvHrt1+eJ7l0gWmDKILbimnkvP7FZrTCPMIVvzGADVNb5RAWLtiFi9z
 uuzwOPTmkwBCrWnP3GLmWPRRHhTRUUG6VnNg5U/XsaIIxZ8GXFnDPnUwLg7fJdikbgTneDNl
 kxRkGcBoLYmrXGYewiMdF55b7bjAcR2oX4hZHR+Nle0wXkzJ42o6f5HJZcweLAm8s1lzOJ1E
 KZZK5nRXKwXR2SV4SkZYLn8sJdmKEahizWRMnf3ezM4ZZNhGVDEo4e2Ygv1+SASJSOrrs9i8
 aa43wbWTMNbFQRvBcrbcty1yFa1sSRPke5+RRKQcNJSZF/t4M5hLCmo1q07JMQFKBPiwDqG1
 lnJXUdE9LeV+4JsqYvHn6GJqYutAtBSJEsCEjmJ96uyOAnb4nGnnd1KXtGXcG2PT2jz4qijO
 7lYlqmuLP0dkV9WmINgCLI3n7km7t7iqrIGnARpGHLHMwaiBr96eyTU2MBOsutGx6NDuBvwU
 UWKo4EINbKMMcLjMVgQOAt6MbjTiaBKwmHfvaYvPUH3xC5r577WA0xdMi6FhDFZMLYoYpgux
 v0suZJO5gGy4vbw3g1qUsyAG7ywE0E9
IronPort-HdrOrdr: A9a23:blyIT6kKrNSHzwuLsdZ73jISURfpDfPIimdD5ihNYBxZY6Wkfp
 +V88jzhCWZtN9OYhwdcLC7WZVpQRvnhPlICK0qTM2ftWjdyRCVxeRZg7cKrAeQeREWmtQtsJ
 uINpIOdeEYbmIK8/oSgjPIaurIqePvmMvD5Za8vgZQpENRGtldBm9Ce3mm+yZNNW977PQCZf
 6hDp0tnUvdRZ1bVLXxOlA1G8z44/HbnpPvZhALQzYh9Qm1lDutrJr3CQKR0BsyWy5Ghe5Kyx
 mJryXJooGY992rwB7V0GHeq7xQhdva09NGQOiBkNIcJDnAghuhIK5hR7qBljYop/zH0idhrP
 D85zMbe+hj4XLYeW+45TPrxgnbyT4rr0TvzFeJ6EGT1/DRdXYfMY5slIhZehzW5w4Lp9dnyp
 9G2Gqfqt5+EQ7AtD6V3amHazha0m6P5VYym+8aiHJSFaEEbqVKkIAZ9ERJVL8dASPB7pw9Gu
 UGNrCS2B9vSyLbU5nlhBgt/DT1NU5DXCtuA3Jy9vB96gIm3UyQlCAjtYkidnRpzuNLd3AL3Z
 WBDk1SrsA8ciYhV9MIOA4we7rGNoXze2O/DIuzGyWvKEhVAQOEl3bIiI9Fkd1CPqZ4i6cPpA
 ==
X-IronPort-AV: E=Sophos;i="5.87,172,1631592000"; 
   d="scan'208";a="56220844"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=UoFRsktqz50/DNmkdtfsrVtiYEHFANjs80TLHkQUl9Oz7Ou1bf9KAAUOv+wAfZ26bPPIj2+ti0TktjJB45TrXAjy8Jukk86q2tDrxm6V1Pdn8mt1NoEWdb9PWuDXaC7pdTeFjWpqNTuoJb5d23h4Vaaz8ZUuTn/NWg6XHtPo/C2aTXfyPwRNBt9JH/099v/OWAx3JWpnS7+7BkJVFNWus7MYyoqIcLDperqGVAdJVmnv1moAsSWFyGWR60sI6wWUu9xJ2p5XqkwrE7qFt/UeABjIQZsDtWBIeuy0782qBFEwiPk8OJ6eg6x8I0LutF1nJH50783xD5AIUjseGW+kWg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=3OhnVogEZ9DREjff4q/jbUTUQC22RXlS8PJxdLEABVA=;
 b=SmXT65/TmQZV2EcUWp2WQS3KxSm3BLQyIt8zK4SpL3nqYvJLNrTIyL7mi0K82noNjFc8acGT5RQOal7HK/CjzXZoTXcnLKMiF2Y0fYSE7aS4w2ivuqaW9xsJpIbZFeeeeGk6FTymkpGvhPzbLZTmi9bFRILSF4jq0LxHc3M3itCEhp2T2E2dpFmtp9/ci41ZxXpmYw4F7B/ln32fjqZDIJbk+0K+kVGN8jdV9zFOx/i2pu5CKafpvGCmANJ9quychzihIO6UJgoWbEZL/uJQo3qjdfVvpYn61C9cenmNl9Vv3xu9V05by8i+joUeVZ4K/fSDfPVUugkMbA2y05EpFQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=3OhnVogEZ9DREjff4q/jbUTUQC22RXlS8PJxdLEABVA=;
 b=MJVrAQiHzCzeEJ+T6ip0IF7bmJfQT2vIJjpI3crMYF9YmjGInOQhgPk/2i83CgMEueZ0p1ioveUiXFS99zTw2T11BIgpiICFuwPa9VjQgrW7qvz8W8eneInzOQo7Z0eMh0VV1uXCAZh+pmEOXyxnwGO8waI04CStrFJL/sLN1ow=
Date: Fri, 22 Oct 2021 15:25:29 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Andrew
 Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>, George Dunlap
	<george.dunlap@citrix.com>
Subject: Re: [PATCH v4 6/6] x86/P2M: relax permissions of PVH Dom0's MMIO
 entries
Message-ID: <YXK7ySGvgTvN8GPR@MacBook-Air-de-Roger.local>
References: <cbdc93a6-e675-420c-f7e8-53aa407766ba@suse.com>
 <4b8c48ba-a563-d036-d4bf-f4f8bdf0efb1@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <4b8c48ba-a563-d036-d4bf-f4f8bdf0efb1@suse.com>
X-ClientProxiedBy: LO4P123CA0287.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:195::22) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: f514f942-ea93-4768-d060-08d9955f6e71
X-MS-TrafficTypeDiagnostic: DM6PR03MB4218:
X-Microsoft-Antispam-PRVS: <DM6PR03MB421812288195A4AF4E20B9DE8F809@DM6PR03MB4218.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: JdWKFB7+PJXGKOUMxwLKdecL8vHFbvB+HDE08q5XVdnENlzaGJ4Ij08h3yZyhdOG4r6Y9TH7Y41l+5wOSJoZMH12Sng5150hO0bmDLb/SCq1hTEZPXHu88oUDDuok8DPI3nIHN29Mj8GU680H7OvD9NCMXL/SvKJBJgFjGPRPzqZXMhRsMlv4epvJBZO+Fp9t/UjrRLNbUIkBvqt2eKU6gtPNVlh99kLbBV1McJ2LEgupnbtBprx8YBDGjLGJ4nEi7AFC2INNHnQWx1okk/OL7FbXoglgJQY20ORXUDLYHkhrddFzpUfgPlf+ESYA6i1GioIAHKarD7Fmx9himZKdTGPiWQjECj1K0TjOtDRXqxiUp1LtLvrhHMBkqmV2cx2fwMZeCUSYV9OX86y8FsiVW6J9vrO4GMvYR5fJ6WP3ay3tKyrmz+0tn+aQ1+a8nGN6oy0rVri8l0LhgqiScJTU/9OgyVs6RJiP7kEp7rQUsg793IL3b/mAHtydiYCYKVLgNdMtncnGUnAmICxavrHZABo4Ri308EK52FErLK7CBDcKAKuDxzte1iQOTPUPqLGWzwpc3hSm+qirYr2R+psbm0aAoAwqRk6gsRouQpkyZDCaYgf94qc/dzOU5/nYNaszXqz/WNQ3DnfKN9iZnBWpQ==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(2906002)(316002)(5660300002)(82960400001)(6916009)(8936002)(6496006)(86362001)(83380400001)(508600001)(8676002)(26005)(85182001)(66946007)(66476007)(66556008)(4744005)(6666004)(186003)(9686003)(4326008)(956004)(107886003)(54906003)(6486002)(38100700002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L0dEZm5TSmh1M1NBSGlvN3oxS2Mwalg4QSs3YkZ0SkFKTkFVNm1LRSsvWk9P?=
 =?utf-8?B?ZUVlcjlURGd0TTNOUGtBczFMVFMyQUNMakFUbmh4UDZlYnRqYldOT1dZdFJa?=
 =?utf-8?B?dHNqSWY0TksvVjBRSGhaWUNoa2V0Z1g3TnR1VUFQdXpyNG1vUFVaVFUrM1JC?=
 =?utf-8?B?RlRxSHBwdDAwbVNxemNVZDBRNWpEV2dWQlJvK3BtTGQrR3hvYjJLTnpHeDha?=
 =?utf-8?B?NTkzYks1UDV2T2lKWjN6L2lkdVdHbldNN1hOUjJKZUwyOUZtOUxaOG5YMWJT?=
 =?utf-8?B?V2JqUGVmelQxMnBkK2xoQVNrNFdpcUc3cUVKTnJpYW5vdzZMWjFBNTBIblEw?=
 =?utf-8?B?a296SjRSSG10RzZMc1JKamh4dUlwNytQc0FQSXdoaVNDMkZVVWNuRldDTkNW?=
 =?utf-8?B?c2pQck9jaCtKeXdwOWhLblVzSlgyQS9UeGdyMDVmdkg3NlJERmJiM1VNeE5Y?=
 =?utf-8?B?aVB1UzYxbFUybzhaVnpvbjBGWjE2a2lEeWlySkdYRDRiR1Q1S3N0SnBLUkdu?=
 =?utf-8?B?RlZFcnc3TG9qN2o2bkxib1lEeGVjWXN5aDM0ZGN1anVLbUkwZWloc1ljWm1Y?=
 =?utf-8?B?OGVQQnpLY21IZFZUemxLNlNmV2RRYk9EWUYrV3VIUmwxcUJ1MzdGdCtvWEZn?=
 =?utf-8?B?MXRGY3UvRE1CUC9md2hKQ05oOE5Zblp0YmZFVG9sc252Qkl4QjhZT09Ibktp?=
 =?utf-8?B?Sk9oRXFUU2dOMS9ucHVHQ1JSdEs3bTFxMVAxU1dXcU5tY3ZJUW1CZWFLbFdx?=
 =?utf-8?B?Q3dGRHk5dFEwZXgwS3BwcjAveUt2MFZ4c3pOUDdTRGxhb0VZczRET1hOQ3R2?=
 =?utf-8?B?UHlNRFQ0WGVVekd1c0s5RlM3SWtnaDNGZUppM1RWSU84bjJ1bnBUbVhWdmsv?=
 =?utf-8?B?aDFpc2pFeTdMM3hqQTBCbk9WRytCNW1rcVlVbDg0bDRmY2QrN2NHTkdwU0xY?=
 =?utf-8?B?VU5oY1BRR25JamdCeEJIeC9sZXRWU0ZmV0llcDlGV1FmLzcwSzNtMWg2dGRU?=
 =?utf-8?B?cHkwTFlYUUpnVjZkY2JjZHNUdnBDVms5V3Y2Y3NJSmxqWStkcjlQSFhkSzdX?=
 =?utf-8?B?VkQwV2U5SC96OWVBd0RWQ3hyTGxsVEpYUzNNamJQS0tGQ25oYzdSdFN0M20w?=
 =?utf-8?B?U1I1Q0dEazJEQWxEQ01icVNBcndGRlBzREtIdGxYd0lKdVh5MC9RN202RnZ2?=
 =?utf-8?B?SVpkQUM1bkthTUYyeFkzbjh3QkVVSnZsaW42bXJwUnBka0E0aTcyR2M0M1hQ?=
 =?utf-8?B?cGJhK3YybHlPWkNxNEM3dm1sNVA4WjcvNmhWdFV1cEdVTVJPRXBkcDVIWXNm?=
 =?utf-8?B?UXc5aEk3Y3RpUTJPQmQ1OWNUeS9YSnVWL3VvTEc5emdYK0pRbjZUVkU4WWNi?=
 =?utf-8?B?RnVRVGdOZFNoOVl1Tk5DK3BQdFpwallMN3Nxem5vOU1JenBoR1lsZ01RcTFn?=
 =?utf-8?B?TDBjNStwLzcrSXplcENBTWZaa0d5WlJjeHhzZjgrM0M5VUdDY2l4ZW0zbkhx?=
 =?utf-8?B?TXFLdGNtUWI3MktEUTFpakhVR0FwclhTaVJjVjhudGhMV3Y5cXROblp5MlBl?=
 =?utf-8?B?WjJVajFuaDU1VGR6Q2Z6bWpmeXAzcmszV01sdE1hSDdabkdjZCtiQmdiZHlz?=
 =?utf-8?B?YllIRmo3bzdReDlTb3Z3WG5xMzJTdUxVRXhBYy9BeW5Sb3c0VlJtU1R3d3pX?=
 =?utf-8?B?aFRzeWh2L3cvekVlVG9sUGNuUFQwUFBKanBzYkVIbkhMZnFUUWtjcUNKc3JH?=
 =?utf-8?B?TVdmVHdxTUtvOFRIWGpiTmxiTHg0LytXNEprKzFZQjBROWwvbStRSjVCaW1r?=
 =?utf-8?B?b1lMWG0rTCtkdDRjZEU1ZHJiRFQyU3NYYVZ3WDFYMzhhQmNYektOVzNWTXRw?=
 =?utf-8?B?aFNNYTRxVnNSV291SzdFeEpidDlNWDZNY2JxMGpWcGJmRFZOeWVtVitsQW5s?=
 =?utf-8?Q?Kf09NacT7JE=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: f514f942-ea93-4768-d060-08d9955f6e71
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Oct 2021 13:25:35.8364
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: roger.pau@citrix.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4218
X-OriginatorOrg: citrix.com

On Wed, Sep 29, 2021 at 03:15:48PM +0200, Jan Beulich wrote:
> To become independent of the sequence of mapping operations, permit
> "access" to accumulate for Dom0, noting that there's not going to be an
> introspection agent for it which this might interfere with. While e.g.
> ideally only ROM regions would get mapped with X set, getting there is
> quite a bit of work. Plus the use of p2m_access_* here is abusive in the
> first place.

While doing this might be fine on Intel hardware, AMD hardware can
specify strict mapping access requirements from the IVMD flags, and
hence we should enforce those.

I think a better solution would be to not return error if the only
divergence between the current mapping and the requested one is the
access flag. We could log a message in that case about being unable to
change the access for the gfn.

This relies on the RMRR/IVMD regions being setup before any other MMIO
region, or else Xen would have to clear existing entries on that case.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Fri Oct 22 13:46:45 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Oct 2021 13:46:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.215097.374067 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdusW-000705-06; Fri, 22 Oct 2021 13:46:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 215097.374067; Fri, 22 Oct 2021 13:46:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdusV-0006zy-SX; Fri, 22 Oct 2021 13:46:35 +0000
Received: by outflank-mailman (input) for mailman id 215097;
 Fri, 22 Oct 2021 13:46:34 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mdusU-0006zo-J2; Fri, 22 Oct 2021 13:46:34 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mdusU-00059g-CI; Fri, 22 Oct 2021 13:46:34 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mdusT-0002Bj-VS; Fri, 22 Oct 2021 13:46:34 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mdusT-0000tN-Uv; Fri, 22 Oct 2021 13:46:33 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=4ZED2fR3DkiEKKvgZpFfAr6ctS5wJi7iYdeG9boEnyY=; b=5py0VX6hLzDrNx0MHjNTrdI/2h
	dHAK98Op9gZ9mSJ7mvBoyUcCC3W0CeytdLjvspbNjd33xkmYpZxBp+hZLJkvaOZu6ZweIPEH0YkXs
	u1bvig0cgcoTdHD6JDSCK2QQZfHfeOHu8li54EFErv9phGFt+QLRKenHyE9ULtkHXhds=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165743-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 165743: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=64222515138e43da1fcf288f0289ef1020427b87
X-Osstest-Versions-That:
    linux=2f111a6fd5b5297b4e92f53798ca086f7c7d33a4
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 22 Oct 2021 13:46:33 +0000

flight 165743 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165743/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 165700
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 165700
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165700
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 165700
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165700
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 165700
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 165700
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165700
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 linux                64222515138e43da1fcf288f0289ef1020427b87
baseline version:
 linux                2f111a6fd5b5297b4e92f53798ca086f7c7d33a4

Last test of basis   165700  2021-10-21 03:27:38 Z    1 days
Testing same since   165743  2021-10-22 05:43:25 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  "Eric W. Biederman" <ebiederm@xmission.com>
  Aleksander Jan Bajkowski <olek2@wp.pl>
  Anitha Chrisanthus <anitha.chrisanthus@intel.com>
  Antoine Tenart <atenart@kernel.org>
  Aswath Govindraju <a-govindraju@ti.com>
  Ayumi Nakamichi <ayumi.nakamichi.kf@renesas.com>
  Biju Das <biju.das.jz@bp.renesas.com>
  Brett Creeley <brett.creeley@intel.com>
  Caleb Connolly <caleb.connolly@linaro.org>
  Catalin Marinas <catalin.marinas@arm.com>
  Christophe JAILLET <christophe.jaillet@wanadoo.fr>
  Dan Johansen <strit@manjaro.org>
  Dave Airlie <airlied@redhat.com>
  Dave Ertman <david.m.ertman@intel.com>
  David Ahern <dsahern@kernel.org>
  David S. Miller <davem@davemloft.net>
  Davidlohr Bueso <dave@stgolabs.net>
  Davidlohr Bueso <dbueso@suse.de>
  DENG Qingfang <dqfext@gmail.com>
  Dmytro Linkin <dlinkin@nvidia.com>
  Edmund Dea <edmund.j.dea@intel.com>
  Emeel Hakim <ehakim@nvidia.com>
  Eric W. Biederman <ebiederm@xmission.com>
  Erik Ekman <erik@kryo.se>
  Eugene Crosser <crosser@average.org>
  Eugene Syromiatnikov <esyr@redhat.com>
  Florian Westphal <fw@strlen.de>
  Guangbin Huang <huangguangbin2@huawei.com>
  Gurucharan G <gurucharanx.g@intel.com>
  Hauke Mehrtens <hauke@hauke-m.de>
  Jakub Kicinski <kuba@kernel.org>
  Jeremy Kerr <jk@codeconstruct.com.au>
  Jerzy Wiktor Jurkowski <jerzy.wiktor.jurkowski@intel.com>
  Jesse Brandeburg <jesse.brandeburg@intel.com>
  Jiaran Zhang <zhangjiaran@huawei.com>
  John Stultz <john.stultz@linaro.org>
  Jordan Glover <Golden_Miller83@protonmail.ch>
  Juhee Kang <claudiajkang@gmail.com>
  Julian Anastasov <ja@ssi.bg>
  Kele Huang <huangkele@bytedance.com>
  Kim Phillips <kim.phillips@amd.com>
  Kurt Kanzenbach <kurt@linutronix.de>
  Leonard Crestez <cdleonard@gmail.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
  Maor Dickman <maord@nvidia.com>
  Marc Kleine-Budde <mkl@pengutronix.de>
  Marek Vasut <marex@denx.de>
  Mark Pearson <markpearson@lenovo.com>
  Martin Habets <habetsm.xilinx@gmail.com>
  Michael Ellerman <mpe@ellerman.id.au>
  Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
  Mike Rapoport <rppt@linux.ibm.com>
  Moshe Shemesh <moshe@nvidia.com>
  Nathan Chancellor <nathan@kernel.org>
  Nathan Lynch <nathanl@linux.ibm.com>
  Nechama Kraus <nechamax.kraus@linux.intel.com>
  Nikolay Aleksandrov <nikolay@nvidia.com>
  Oleksij Rempel <o.rempel@pengutronix.de>
  Oliver Hartkopp <socketcan@hartkopp.net>
  Oliver Neukum <oneukum@suse.com>
  Pablo Neira Ayuso <pablo@netfilter.org>
  Paul Blakey <paulb@nvidia.com>
  Paul Menzel <pmenzel@molgen.mpg.de>
  Peng Li <lipeng321@huawei.com>
  Qian Cai <quic_qiancai@quicinc.com>
  Randy Dunlap <rdunlap@infradead.org>
  Rob Clark <robdclark@chromium.org>
  Rob Clark <robdclark@gmail.com>
  Rune Kleveland <rune.kleveland@infomedia.dk>
  Saeed Mahameed <saeedm@nvidia.com>
  Sam Ravnborg <sam@ravnborg.org>
  Sasha Neftin <sasha.neftin@intel.com>
  Stefano Garzarella <sgarzare@redhat.com>
  Stephane Grosjean <s.grosjean@peak-system.com>
  Stephen Suryaputra <ssuryaextr@gmail.com>
  Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
  Tony Nguyen <anthony.l.nguyen@intel.com>
  Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
  Vegard Nossum <vegard.nossum@gmail.com>
  Vegard Nossum <vegard.nossum@oracle.com>
  Vladimir Oltean <vladimir.oltean@nxp.com>
  Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
  Wan Jiabing <wanjiabing@vivo.com>
  Xin Long <lucien.xin@gmail.com>
  Yang Yingliang <yangyingliang@huawei.com>
  Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
  Yu Zhao <yuzhao@google.com>
  Yufeng Mo <moyufeng@huawei.com>
  Yunsheng Lin <linyunsheng@huawei.com>
  Zhang Changzhong <zhangchangzhong@huawei.com>
  Zheyu Ma <zheyuma97@gmail.com>
  Ziyang Xuan <william.xuanziyang@huawei.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   2f111a6fd5b5..64222515138e  64222515138e43da1fcf288f0289ef1020427b87 -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Fri Oct 22 14:01:24 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Oct 2021 14:01:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.215109.374086 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdv6e-0000yo-GR; Fri, 22 Oct 2021 14:01:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 215109.374086; Fri, 22 Oct 2021 14:01:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdv6e-0000yh-DS; Fri, 22 Oct 2021 14:01:12 +0000
Received: by outflank-mailman (input) for mailman id 215109;
 Fri, 22 Oct 2021 14:01:10 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=OBiv=PK=citrix.com=Andrew.Cooper3@srs-us1.protection.inumbo.net>)
 id 1mdv6c-0000yb-9l
 for xen-devel@lists.xenproject.org; Fri, 22 Oct 2021 14:01:10 +0000
Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 8b47f8ba-d63d-4ed5-9d8d-88009e99c966;
 Fri, 22 Oct 2021 14:01:07 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8b47f8ba-d63d-4ed5-9d8d-88009e99c966
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1634911266;
  h=to:cc:references:from:subject:message-id:date:
   in-reply-to:content-transfer-encoding:mime-version;
  bh=TqIrvSKWU/DwVyXQpeWqTcwxT1jZB50kxJER9vdE09w=;
  b=h+jROFz5pP7zKQ6nLjPw02tDm77i0OQCwvWrjnWC2Mg8NPVgfUd4wWbr
   fs2WUzIvheJLPjsVausH58v0DiW8NM8VRTaIQPNjocVgUNFHnsf2eh9pw
   aKDuIlECOJMe1Mk8KrkusNY8aoAS8NxnQs77S0NZCHfGqyj9Ob0kPGUF/
   M=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: BoGEFxgYLxA7TKholMG4TKWeZp6yIy92zlH9nv2at2lmyv8lNZho8v7OJEf3vyXsIASnIIA5py
 Dytgn3Fv4Hh//Be/wVRLqcQX+ep8JWZ+P7AGsW5T8owM4xKk6wlViWtQ5JBtGB4UV66ZbfcsGA
 DimbUFaQ4r/E5qEFDT3eAygi+GD3cWF6ZBZNLxy7OYbEVBx4TqkMwhxPKu5yfTymGkF/kB58kE
 04fbd+xJj/d+jJlf0xzM58k4OE/1lFgtT7ultxxS0bjE66DFELiJtEmhvjxgaIadfSNYJzCAKk
 uI+uQQxZ6ywmwTI1JxEpV4GY
X-SBRS: 5.1
X-MesageID: 55390137
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:Q0xndK4RfOaYBizi4QooLgxRtKLAchMFZxGqfqrLsTDasY5as4F+v
 mQfDzuEa/zZZWHzKop2OY+1pE5TuJKDx99lHAU9rixmHi5G8cbLO4+Ufxz6V8+wwmwvb67FA
 +E2MISowBUcFyeEzvuV3zyIQUBUjclkfJKlYAL/En03FVAMpBsJ00o5wrdh2NQw2rBVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Z4
 d5EucezdBYVIor0wd5MWARXHxFEMvgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALBc/nJo4A/FpnyinUF60OSpHfWaTao9Rf2V/cg+gTQK2PP
 5NCNlKDajzGTTBOKmU6CKk3p+mR3kihXGZhl1as8P9fD2/7k1UqjemF3MDuUt6ASNhRn02Yj
 nnb5Gm/CRYfXPSe1jit4n+qnvXIny7wRMQVDrLQ3u5nhhify3IeDDUSVECnur+ph0imQdVdJ
 kcIvC00osAa60iDXtT7GRqirxaspQUAUtBdF+k77gClyafO5QudQG8eQVZpasEitcIwbSwn0
 BmOhdyBONB0mOTLEzTHrO7S9G7sf3hORYMfWcMaZSIO6tW4o7wisg7odo9ZQaWogdHFIz6ll
 lhmsxMCr7kUiMcK0YCy8lbGny+gq/D1c+Il2unEdjn6tl0hNeZJc6TtsAKBta8Rc+51W3HY5
 CBc8/Vy+tziGn1keMale+4KAK2yr8iMNDnRkDaD9LFwqmzzpRZPkW1WiQySxXuF0O5YJlcFg
 2eJ4Gu9AaO/2lPwMcebhKrqU6wXIVDIT4iNaxwtRoMmjmJNXAGG5jpyQkWbwnrglkMh+YlmZ
 8zHIZr1UiZCUvk2pNZTewv7+eV3rszZ7TiLLa0XMjz9iebODJJrYedt3KSyghARs/rf/VS9H
 yd3PMqW0RRPONASkQGMmbP/2WsidCBhbbiv8pQ/XrfafmJORTFwY9eMkOhJU9E0wMxoehLgo
 yjVtrlwkwGk2xUq6GyiNxheVV8Ydc8u9CxhZXVxZQrANrpKSd/H0ZrzvqAfJNEP3Odi0eR1X
 78CfcCBCe5IUTPJ53IWapyVkWCoXEjDadumM3X3bT4hUYRnQgCVqNbochG2rHsFDzattNt4q
 Lqlj1uJTZ0GTgVkLcDXdPPwkA/h4SlDwLp/DxnSP91eWETw64w2eSb/ueA6fpMXIhLZyzrEi
 wvPWUUEpfPAqpMe+cXSgfzWtJ+gFuZzRxIIH2TS4busGzPd+26vnd1JXOqSJGiPX2Lo4qSyI
 +5SyqikYvEAmV9Ltat6Eqpqkv1it4e++ecCw109TnvRblmtBrdxGVW83JFC5v9X27tUmQqqQ
 UbTqNNUDqqEZZH+G1kLKQt7MunajaMImiPf5OgeKVnh4HMl56KOVEhfMkXeiCFZK7cpYoopz
 f145ZwT4g27zBErLsyHnmZf8GHVdi4MVKAut5c7Bo73i1V0lgEeMMKEUiKmsouSb9hsM1UxJ
 m7GjaXPsL1Q207efidhDnPKx+dc2cwDtR0iIIXu/LhVdg4pXsMK4SA=
IronPort-HdrOrdr: A9a23:Pi2MtaDqtSEWe+DlHeg8sceALOsnbusQ8zAXPh9KJiC9I/b1qy
 nxppkmPH/P6Qr4WBkb6LW90dq7MAzhHPlOkPUs1NaZLXTbUQ6TQr2KgrGSuwEIdxeOkdK1kJ
 0QCZSWa+eAfWSS7/yKmTVQeuxIqLLskNHK9JTjJjVWPGVXgslbnnZE422gYytLrWd9dPgE/d
 anl7F6T23KQwVoUi33PAhJY8Hz4/nw0L72ax8PABAqrCGIkDOT8bb/VzyVxA0XXT9jyaortT
 GtqX232oyT99WAjjPM3W7a6Jpb3PPn19t4HcSJzuwYMC/lhAqEbJloH5eCoDc2iuey70tCqq
 iBnz4Qe+BIr1/BdGC8phXgnyHmzTYV8nfnjWSVhHPyyPaJDA4SOo5kv8Z0YxHZ400vsJVXy6
 RQxV+UsJJREFfpgDn9z8KgbWArqmOE5V4Z1cIDhX1WVoUTLJVLq5YEwU9TGJAcWArn9YEcFv
 V0Bs203ocWTbqjVQGagoBT+q3oYpxqdS32BnTq+/blnQS+pUoJjHfxn6ck7zA9HJFUcegM2w
 2LCNUvqFh0dL5iUUtKPpZ2fSKGMB2+ffvyChPnHb3GLtBNB5ufke+83F0KjNvaD6DgiqFCwa
 j8bA==
X-IronPort-AV: E=Sophos;i="5.87,173,1631592000"; 
   d="scan'208";a="55390137"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=WgVY6bS4XcRA4yQj/eYM81/4l5lN5blG0PKJl0u9qvxovi9WHu4Hg7ibwOkN6hmG0zCRW0tmU4ii69hKOzMt/TX/qTjMiz+tlWTFpeO/nJJ2V2SGmN4V4/lrg1jM8GwJwv9rfGYiYieyiQY2G6VgdnlJ/6PtGsVx9txy7LfcREYTiCkXzf2qclQjHXnvBVmtdwYhfA/KDxicxRD5sIeYtmMoMPzDwhc9P7VHNUWoBdyktuYGlEvLrCMNMaPmtpEc/Abx47+/AomqRbGQFr1CY9nHG+RwTyFc+WZUGcv/UKDlieC88A0I4sK8dCUm1A1++FYD84oGAQLnPUPPgxmqTA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=OKlQwR57eOPgWtz7lCdOmogpzFIwemmD6XTnjE4GD3g=;
 b=SAc5vFISciuMR/+csgge620rU6vf6SILx/hfFvCSGKIDKaPJtrqfE7aLzg7meA33a9XfSIilInVRL9lv2J0Nd083dvGO4fxICP0TZN5/lx1P935zJioRwVYII3Wkhph/UsTpKmieLLSnmvwKi2K/t0JZ8qg3zvPQ8Ud4GgMBYwvmGrKdl2CkikFnkL0YN2JTCcya4dcuuuQKaIc/JYIgLS6a7vAF3+rHsN6dMIILOtPK9Nt40hCBU1+r4BuMP6t6yNQT9fL6Stpmk/yTIq4FnCwltfVv8RIyJBeqYH1s91SODQjNjSC9+9yA9XFz9YXJ1qwB8LTtRsXAwunDAIwnTA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=OKlQwR57eOPgWtz7lCdOmogpzFIwemmD6XTnjE4GD3g=;
 b=CCMnsmHpssME2IjHY25QCeV3FzksqN89xxY1YhRNFPTjC21AJxJDN1rY2+7uIsUEDtz2JoTTYdjrV0EkDWRMJ7a7yeUOX6JG4fZz1Cvp6gz77WNkru6U6EzJfv/FV43PpWznl63U6O58heVOXxgqJ5BwDV1pR89cUn/GWqJrkc8=
To: Lin Liu <lin.liu@citrix.com>, <xen-devel@lists.xenproject.org>
CC: George Dunlap <george.dunlap@citrix.com>, Ian Jackson
	<iwj@xenproject.org>, Jan Beulich <jbeulich@suse.com>, Julien Grall
	<julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>, Wei Liu
	<wl@xen.org>
References: <cover.1634897942.git.lin.liu@citrix.com>
 <89afdafa9020ab77b9d662bd5c8f7b2d31e53c5c.1634897942.git.lin.liu@citrix.com>
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH v2 1/7] xen: implement byteswap.h
Message-ID: <ca9c27b5-26ef-dce5-4abd-83cb7d24241e@citrix.com>
Date: Fri, 22 Oct 2021 15:00:57 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <89afdafa9020ab77b9d662bd5c8f7b2d31e53c5c.1634897942.git.lin.liu@citrix.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Content-Language: en-GB
X-ClientProxiedBy: LO4P123CA0389.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:18f::16) To BYAPR03MB3623.namprd03.prod.outlook.com
 (2603:10b6:a02:aa::12)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 3bc363a4-95e8-4282-fd58-08d9956462d3
X-MS-TrafficTypeDiagnostic: BY5PR03MB5284:
X-Microsoft-Antispam-PRVS: <BY5PR03MB52845A161FB89A1FE27598C3BA809@BY5PR03MB5284.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6430;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: xWre6+AT0p5zY+NhsrX/LVxB33Y8j7Flio57KQ9ETWv6AFvHSEaRjqWAgnXO2o3W2ennj+9gExJUe5T+nJJdlAhIAxOfa2Xs83NxUuvaXiuVz8xgi2gygQBpXlVsc2qhf4IfnmGqqmgbR2izqIrY1qRRvWLM/so3Jx8bnB1rX92fTBv4oHQGRpibYxN2+VwZO21iuNkdeh5zxw9UEBfb51B50rziWUC7irhvpmua+a0WfTpfDMmGwZXzyRGU6+2K8Z2sWiy9pCqmMKOzoIT7hxwZNU1qCdNe6GpMe+3WZIc+Z7YShhY9JZOJan7XaI4/OJZ1nz5to7PuILdKryKcpkKWvNvGcWvfI1WJqYk4RqGBi3u+P3Gsl6m9Z+SZaWF4h6604U9PPOjZ3MGcaVDaveKD7Oq3PAhT4NKNunCCVf00dHhZvNBRMh1OQThhbaeaGOIP6wSCOrty2afuLdvpEgJIXuXhQrCzowEeMUnMbSZSdLKbsrMe6ZhYIqQ6toYyKntJCDN2Siz+EVKvj0bcqwwIh4zsgHm4N1jajVwapYv819TI93A8TN7Ewz84kiV4pk4TLghQdrZN5YCzNYaZEEggx2OVLxrp6Qq0p8UdQjSBD3fXrxz7Pxud/dB0paAsRlQ4X7R7TJzP5LTYw6MfwlD7AVc8Pv+5BL9B+L1pDYQMn8Jh7jXseQ5aIddFSifEzoqIzz87r9M6cG7mjn+ZiUMZeFyAJu6qV6LZgGSt3zgJSnS5Sn2WizW4aEBRVWnz
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(8936002)(4326008)(2616005)(66476007)(38100700002)(26005)(36756003)(2906002)(316002)(16576012)(31696002)(186003)(6486002)(508600001)(8676002)(4744005)(86362001)(66946007)(54906003)(956004)(82960400001)(66556008)(6666004)(31686004)(53546011)(83380400001)(5660300002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UTEvaDgvcUVDOVhFb3dqejIyNVFLUDFuY1dJamNQMTMrUEdrOHpWWTZiVGFL?=
 =?utf-8?B?U1RyS29VWHJVVjZLMkJJQU5uRkNMWkdQVGRPRGszOWJkQnBrOVIwSHBjVXBv?=
 =?utf-8?B?OTNwa2NTbFp4dFROelhIMXlTZUcvaHU3eTNRcUFJRlRTcmVlVExoeVFQTTNP?=
 =?utf-8?B?R3ZOdEdXU2hPQ3pVcDFhMmFibnhvT3Mwc0JheE9RbGRhSGFYc0hhNlZhaEY3?=
 =?utf-8?B?UWNCV0pUSVdkaW9MRGxieGd0emM5NFJLc0VPL3FrUWd5YnVGREJjeEhKd1hp?=
 =?utf-8?B?YmtBN0QzaXliYWJqblQ1NDZBUnhYUzN4VmFaMExoeCtwS05KUXFvWmUwZFc1?=
 =?utf-8?B?b3QxVnVKaUludEVhVlFXOCs3ZURKRVhBa3J4K3FCMGhvVkdDeGtqZ3l1L0FF?=
 =?utf-8?B?T2Z6OHZpUkFQUDhsbURjUSt6SmNjM0thSkk3SEtYU1QyN1Eyc0p2K1UrZW1w?=
 =?utf-8?B?UEpTWTIrVTdiZ2xodUNRejllTmtpQ3RKMSs1NVBRWTlNYXhPQnpVbThPQTRw?=
 =?utf-8?B?eTVuWHVrbm9IMzk0ekt0TjI5b2dERlptakEyWTFsQ2t3WStPOFNrTk9JUHpU?=
 =?utf-8?B?Q2hMa0swUU53cmpzcWIxcWE2L3BwVVkycW5NY0V5clZMOS9QdEdMUHZObnlG?=
 =?utf-8?B?TzFGL1FSM2p3YjZ2REZOamxmOUFCMmVHcUxmVk9ZcEJiekNVTEVCUUtYZ3Nj?=
 =?utf-8?B?TXdBZ1ZWNTlxTkVhZy9hR2tIcVhxZm9QL2dFczBocWdweU9CclVvNEFLcW1B?=
 =?utf-8?B?ZEtRcDQraFZTSm1Fb3p3eGsyM0dJT0NXaTExYlBsU2FLYnhxM1dDdU5oaGlC?=
 =?utf-8?B?cW8xMDh1UDdyY3FuOWRlbWFLZUVGclpkT0Jhem9MTEFmTDBvN01YRTNaS0Q4?=
 =?utf-8?B?UFBUVWYxVEZaRkxhMjVSUjdlUVNKWTl3R0J5aHZVU1ZVaXl5WExOODFUWkk5?=
 =?utf-8?B?ZFdLUjlGaGVqUWo1MG1UZzExR2pTOGNrSnVJblg0WVg5ZWpFcGx3Nm9OcVdv?=
 =?utf-8?B?TWhSV0t5OXhRazRZMTN5YTlwR21TWDBLSnNHUkhqNk9QZG9PUWNaNC8yY3c3?=
 =?utf-8?B?eUE3UjRHYWM4ZjB5RmtqbkJlUy83dU9KWUJMMFJyRnUxWDRyNkFjUHl2U05R?=
 =?utf-8?B?YjQyS2w4dnZaVkpjZEtNUHJ3a1B1VzIvVTdUSFhyVDNpOTQ3TTd0THJyRVJB?=
 =?utf-8?B?TGZGWERUVFZEOHFOcXBTVlFYaG1USUZJcVFGOGVteVhaNDF3dEVwVEMwWUlC?=
 =?utf-8?B?b1ZrQ3lsbmlJRGdUbEhNa0x3MHdZWGg0VXFoLzM4SFdHb21FdEhCd2NiKzd1?=
 =?utf-8?B?cDk4VFQrZWNRSXhScVhUZHBscDhNOTdnY1k0eDdFMVNDY1pYa3A0aFJ5eDFj?=
 =?utf-8?B?b0p0K0NGMlVNcXVQWXE2d3QrZm9nckgxS052Qk50eW5XMVdUNnU2Z2o4bFdE?=
 =?utf-8?B?TWZXUGFLVzN0ZTMvRERGelgyK2l2ZUMvR1p4ak9LVEdFYjVIUzFQbjdXbVFk?=
 =?utf-8?B?N1YzUUFJL1ZkcFQrRTNQelpVZll2U3dETDdUcjIzZkFoR0xNbnB5cktGUTgr?=
 =?utf-8?B?OVc2U090VmlHbkdwNkM4RmtuU05PS2gzbTZETm9LdFJ2aEtac3RWN3p3cTJ6?=
 =?utf-8?B?dXhnUUNPdkRDYjQ0OXQyRXYvMnJZeHM1NmVYNDI1OWNxWEQ1WktEZHppK0d2?=
 =?utf-8?B?SjJkT1RoNEd4dzRZWFVnL2IwRGhWZXNiMi95NGRIWEljZW1lM2MwT0ZSWHI1?=
 =?utf-8?B?V2dmem5oQW44NjdDVy94TlNMeU5JL1FZWGFpOWNSSWh1MnpYN0ZtS05JRmQ2?=
 =?utf-8?B?K1VHa2hVQy9BUjBOUVdNcVdiT0RqN2trbXE2eE1TNUpILzRKM0JiejVQMDhI?=
 =?utf-8?B?L2M2Q01PK3dHN29jOUlySXA1KzNFQ1A5U0Q4eHZhODJ3K1hXRXlLWU9WQzNT?=
 =?utf-8?Q?pC1EQXG5as9NM1tNWC2vl5714ru2jd8z?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 3bc363a4-95e8-4282-fd58-08d9956462d3
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Oct 2021 14:01:03.8113
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: andrew.cooper3@citrix.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR03MB5284
X-OriginatorOrg: citrix.com

On 22/10/2021 11:47, Lin Liu wrote:
> diff --git a/xen/include/xen/compiler.h b/xen/include/xen/compiler.h
> index 696c7eb89e..68f28082a5 100644
> --- a/xen/include/xen/compiler.h
> +++ b/xen/include/xen/compiler.h
> @@ -179,4 +179,16 @@
>  # define CLANG_DISABLE_WARN_GCC_COMPAT_END
>  #endif
> =20
> +#if (!defined(__clang__) && (__GNUC__ < 10))

This too lost my feedback.

It needs to be #ifndef __has_builtin because otherwise a random GCC 10
build I have fails with:

/local/security/xen.git/xen/include/xen/byteswap.h:6:19: error: missing
binary operator before token "("
=C2=A0=C2=A0=C2=A0 6 | #if !__has_builtin(__builtin_bswap16)


I suspect it was a build of GCC 10 before __has_builtin() support was
added, but either way, we should be predicating on __has_builtin itself,
not version guesswork.

~Andrew



From xen-devel-bounces@lists.xenproject.org Fri Oct 22 14:21:32 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Oct 2021 14:21:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.215115.374097 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdvQE-0003Gi-5y; Fri, 22 Oct 2021 14:21:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 215115.374097; Fri, 22 Oct 2021 14:21:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdvQE-0003Gb-2z; Fri, 22 Oct 2021 14:21:26 +0000
Received: by outflank-mailman (input) for mailman id 215115;
 Fri, 22 Oct 2021 14:21:25 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mdvQC-0003GV-W1
 for xen-devel@lists.xenproject.org; Fri, 22 Oct 2021 14:21:24 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mdvQC-0005pQ-UE
 for xen-devel@lists.xenproject.org; Fri, 22 Oct 2021 14:21:24 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mdvQC-0006sZ-T5
 for xen-devel@lists.xenproject.org; Fri, 22 Oct 2021 14:21:24 +0000
Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89)
 (envelope-from <iwj@xenproject.org>)
 id 1mdvQ9-0001lG-99; Fri, 22 Oct 2021 15:21:21 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:To:Date:
	Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From;
	bh=PH5aOSrUL+ee30CSPPXWWOGczmFCRGE5tHNa1SMU4Xg=; b=GXaUGL0FrKCGkG/ALgFAUzI6Cu
	chNQiDWrFGYU/IJX0CMcX5ZBiY9KzA6bLnQrAwYFNDUjZb1UsRez0jSFth52HZes7ozy1gAJXelB6
	28XC51uJf4m+SnJEK290ed8B9BAeU6GB/lMH7OKzFpvdFfiLhPiQ/3RJkN0Cdg4d/kZc=;
From: Ian Jackson <iwj@xenproject.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <24946.51424.880154.393018@mariner.uk.xensource.com>
Date: Fri, 22 Oct 2021 15:21:20 +0100
To: jgross@suse.com,
    xen-devel@lists.xenproject.org
Subject: Re: [adhoc test] 165675: truncated
In-Reply-To: <E1mcptl-0002fM-6i@osstest.test-lab.xenproject.org>
References: <E1mcptl-0002fM-6i@osstest.test-lab.xenproject.org>
X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu)

iwj@xenbits.xen.org writes ("[adhoc test] 165675: truncated"):
> [adhoc play] <testing.git (HEAD detached at 14a279c4) /dev/pts/3>
> harness 14a279c4: osstest: explicitly enable building qemu-traditional
> 165675: truncated
> 
> flight 165675 xen-unstable play [play]
> http://logs.test-lab.xenproject.org/osstest/logs/165675/
> 
> Perfect :-)
> All tests in this flight passed as required
> baseline version:
>  flight               165635
> 
> jobs:
>  build-amd64                                                  truncated

I looked at this log

http://logs.test-lab.xenproject.org/osstest/logs/165675/build-amd64/6.ts-xen-build.log

and

+ qemutrad=--enable-qemu-traditional
+ ./configure --sysconfdir=/etc --enable-ovmf --enable-qemu-traditional

So I have pushed your patch to osstest pretest.

Ian.


From xen-devel-bounces@lists.xenproject.org Fri Oct 22 14:45:32 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Oct 2021 14:45:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.215127.374114 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdvnS-0005fr-7f; Fri, 22 Oct 2021 14:45:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 215127.374114; Fri, 22 Oct 2021 14:45:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdvnS-0005fk-4p; Fri, 22 Oct 2021 14:45:26 +0000
Received: by outflank-mailman (input) for mailman id 215127;
 Fri, 22 Oct 2021 14:45:25 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mdvnR-0005fa-8B; Fri, 22 Oct 2021 14:45:25 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mdvnR-0006Ef-2x; Fri, 22 Oct 2021 14:45:25 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mdvnQ-0004ua-RW; Fri, 22 Oct 2021 14:45:24 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mdvnQ-0007s2-R2; Fri, 22 Oct 2021 14:45:24 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=b2V10T0oAIXt8i455P8D76VZXZ5AvkEbO1a6/K1cDH0=; b=roIrLsOOLni/kFq38NLEUyy+Uk
	w7S1+j4WozrvbwdNa6S1rqlLLhIPTitLKqaNocPE1D8nzCDbvlXS6odf5uB2i+17h1l4PtAO/pii8
	pmzTrUR70Op1s5FeKLQUXoB3elPqHHAHCUExAMGjfbu1n4zm+uOARuawEZcafOiSldBg=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165767-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 165767: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=bd5ec03d87cacc5be2de4284b092aafd4ac4eb31
X-Osstest-Versions-That:
    ovmf=2f286930a8280f4d817460020110009938f695b6
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 22 Oct 2021 14:45:24 +0000

flight 165767 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165767/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 bd5ec03d87cacc5be2de4284b092aafd4ac4eb31
baseline version:
 ovmf                 2f286930a8280f4d817460020110009938f695b6

Last test of basis   165714  2021-10-21 15:40:13 Z    0 days
Testing same since   165767  2021-10-22 10:10:33 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Gary Lin <gary.lin@hpe.com>
  Lin, Gary (HPS OE-Linux) <gary.lin@hpe.com>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   2f286930a8..bd5ec03d87  bd5ec03d87cacc5be2de4284b092aafd4ac4eb31 -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Fri Oct 22 15:47:17 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Oct 2021 15:47:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.215143.374146 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdwl6-00031g-Ue; Fri, 22 Oct 2021 15:47:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 215143.374146; Fri, 22 Oct 2021 15:47:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdwl6-00031Z-Rn; Fri, 22 Oct 2021 15:47:04 +0000
Received: by outflank-mailman (input) for mailman id 215143;
 Fri, 22 Oct 2021 15:47:04 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=xZlF=PK=apertussolutions.com=dpsmith@srs-us1.protection.inumbo.net>)
 id 1mdwl5-00031T-Ua
 for xen-devel@lists.xenproject.org; Fri, 22 Oct 2021 15:47:04 +0000
Received: from sender4-of-o51.zoho.com (unknown [136.143.188.51])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 4c0425cf-334f-11ec-83c8-12813bfff9fa;
 Fri, 22 Oct 2021 15:47:02 +0000 (UTC)
Received: from [10.10.1.24] (static-72-81-132-2.bltmmd.fios.verizon.net
 [72.81.132.2]) by mx.zohomail.com
 with SMTPS id 1634917617999463.14123576632755;
 Fri, 22 Oct 2021 08:46:57 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4c0425cf-334f-11ec-83c8-12813bfff9fa
ARC-Seal: i=1; a=rsa-sha256; t=1634917621; cv=none; 
	d=zohomail.com; s=zohoarc; 
	b=L6i8OcuXs3Gk5mZxNMMklATyInx8pZj8xfmLD/9edXNbLNBmXwuqWLphuLGJTbcTWjsHQNdwuwEL7WyBLTgaIsFEpGDOb1Ndf11kZkOk9qmTQku6G6r+zFphUopH96hq2QgftuxHTkzJfqYxTmaLBqLtR186itE89066+EhX420=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; 
	t=1634917621; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; 
	bh=wVSldqCk0cvU2+ib2AagL3niuW4Ej9KCLbBqbxcPsBM=; 
	b=OGLQrYkz3GTVQs+yIr5PPYLIZxvNNneD2nRpP7hbVPrEpKbtt9+bgUfWHIGh72AFpIlodNsxe02rWzFPFWd27plEuuoNLzVT0LhLFzdyUlMZrbRC6lp3kCsARQxDUyxzt97MACMxwZwC72dRKgyXe+MsKu9LUGFGVmz8deTqzrc=
ARC-Authentication-Results: i=1; mx.zohomail.com;
	dkim=pass  header.i=apertussolutions.com;
	spf=pass  smtp.mailfrom=dpsmith@apertussolutions.com;
	dmarc=pass header.from=<dpsmith@apertussolutions.com>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1634917621;
	s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com;
	h=Subject:To:Cc:References:From:Message-ID:Date:MIME-Version:In-Reply-To:Content-Type:Content-Transfer-Encoding;
	bh=wVSldqCk0cvU2+ib2AagL3niuW4Ej9KCLbBqbxcPsBM=;
	b=hydbCi2zLgx21dJT+d2ek1UvStvPMGgvs/i62gSG3WUVtDLX31Z7XC5tsZyYRBzO
	svEfu423tgCTRzwSb//hdCbO6kQ98yKHi1T85A55s9HOuYCAaWXMkfqzz96UjNgYEMu
	SZxj6LSWyRnoMVRde+KAUGHnY0PTyIjztIzcYMik=
Subject: Re: [PATCH v2 5/7] xen/xsm: Switch to byteswap.h
To: Lin Liu <lin.liu@citrix.com>, xen-devel@lists.xenproject.org
Cc: Daniel De Graaf <dgdegra@tycho.nsa.gov>
References: <cover.1634897942.git.lin.liu@citrix.com>
 <400efbc5c394140bb01664e5847046e8c4a38ea2.1634897942.git.lin.liu@citrix.com>
From: "Daniel P. Smith" <dpsmith@apertussolutions.com>
Message-ID: <037139aa-e274-a0fe-4d2f-10c457650d3e@apertussolutions.com>
Date: Fri, 22 Oct 2021 11:46:57 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <400efbc5c394140bb01664e5847046e8c4a38ea2.1634897942.git.lin.liu@citrix.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ZohoMailClient: External

On 10/22/21 6:47 AM, Lin Liu wrote:
> Update to use byteswap.h to swap bytes
> 
> No functional change
> 
> Signed-off-by: Lin Liu <lin.liu@citrix.com>
> ---
> Cc: Daniel De Graaf <dgdegra@tycho.nsa.gov>
> Cc: "Daniel P. Smith" <dpsmith@apertussolutions.com>
> ---
>  xen/xsm/flask/ss/avtab.c       | 2 +-
>  xen/xsm/flask/ss/conditional.c | 2 +-
>  xen/xsm/flask/ss/ebitmap.c     | 2 +-
>  xen/xsm/flask/ss/policydb.c    | 2 +-
>  4 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/xen/xsm/flask/ss/avtab.c b/xen/xsm/flask/ss/avtab.c
> index bfc91c8b0c..1fa796f625 100644
> --- a/xen/xsm/flask/ss/avtab.c
> +++ b/xen/xsm/flask/ss/avtab.c
> @@ -19,8 +19,8 @@
>  
>  /* Ported to Xen 3.0, George Coker, <gscoker@alpha.ncsc.mil> */
>  
> +#include <xen/byteswap.h>
>  #include <xen/lib.h>
> -#include <asm/byteorder.h>
>  #include <xen/types.h>
>  #include <xen/xmalloc.h>
>  #include <xen/errno.h>
> diff --git a/xen/xsm/flask/ss/conditional.c b/xen/xsm/flask/ss/conditional.c
> index 3e58aea551..059f6e07e5 100644
> --- a/xen/xsm/flask/ss/conditional.c
> +++ b/xen/xsm/flask/ss/conditional.c
> @@ -9,7 +9,7 @@
>  
>  /* Ported to Xen 3.0, George Coker, <gscoker@alpha.ncsc.mil> */
>  
> -#include <asm/byteorder.h>
> +#include <xen/byteswap.h>
>  #include <xen/lib.h>
>  #include <xen/types.h>
>  #include <xen/errno.h>
> diff --git a/xen/xsm/flask/ss/ebitmap.c b/xen/xsm/flask/ss/ebitmap.c
> index e1d0a586a7..1550437c6f 100644
> --- a/xen/xsm/flask/ss/ebitmap.c
> +++ b/xen/xsm/flask/ss/ebitmap.c
> @@ -10,7 +10,7 @@
>  
>  /* Ported to Xen 3.0, George Coker, <gscoker@alpha.ncsc.mil> */
>  
> -#include <asm/byteorder.h>
> +#include <xen/byteswap.h>
>  #include <xen/lib.h>
>  #include <xen/xmalloc.h>
>  #include <xen/errno.h>
> diff --git a/xen/xsm/flask/ss/policydb.c b/xen/xsm/flask/ss/policydb.c
> index 9426164353..595005c3b7 100644
> --- a/xen/xsm/flask/ss/policydb.c
> +++ b/xen/xsm/flask/ss/policydb.c
> @@ -22,7 +22,7 @@
>  
>  /* Ported to Xen 3.0, George Coker, <gscoker@alpha.ncsc.mil> */
>  
> -#include <asm/byteorder.h>
> +#include <xen/byteswap.h>
>  #include <xen/lib.h>
>  #include <xen/types.h>
>  #include <xen/xmalloc.h>
> 

Reviewed by: Daniel P. Smith <dpsmith@apertussolutions.com>


From xen-devel-bounces@lists.xenproject.org Fri Oct 22 15:52:39 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Oct 2021 15:52:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.215149.374158 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdwqR-0004PH-Jp; Fri, 22 Oct 2021 15:52:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 215149.374158; Fri, 22 Oct 2021 15:52:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdwqR-0004PA-Fj; Fri, 22 Oct 2021 15:52:35 +0000
Received: by outflank-mailman (input) for mailman id 215149;
 Fri, 22 Oct 2021 15:52:34 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=fDp0=PK=citrix.com=roger.pau@srs-us1.protection.inumbo.net>)
 id 1mdwqP-0004P4-W9
 for xen-devel@lists.xenproject.org; Fri, 22 Oct 2021 15:52:34 +0000
Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 10c2693e-3350-11ec-83c8-12813bfff9fa;
 Fri, 22 Oct 2021 15:52:32 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 10c2693e-3350-11ec-83c8-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1634917952;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=we2BhKjzoFXAOlmT/hBXnwuOebK7emDYZXFaU/OTAK4=;
  b=Z29s/fJxsSTUI+QR0gDjVZ4no3c03R0imUYXZp39gEdFhUIu5FhWKLnD
   Oo8Z9tj1AOCnAWyW1cYBm0o/6nXbyOoWScl/7pb2afw8PFx1CK5bO0heW
   eLA9CAPyBfFn45KmbSqN4E6xTYggBLYuxuyf7bTfu0+7y45gJQSlw3lR9
   E=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: WG48G83o0OyCUXGE+D7Lw0XObAZ2fDvlxmb2kd6cJA6nELaA61Je77OkvNmKtKiW38kzDAPH2r
 kueWSt6qt5k+VlLqge9ZsLDTbdN8zYNHD6cFwbdrZGhQSdd480gautFWyJSBZDJ9NyBDmLcXAy
 OpCOcFn4lJ+cA8/AfWt/02T+yXozDFPaWbDRwXMxxvUQHTTiULHXVqxjhOmvZbukIFdRtWFEa7
 XCs7EqcfzwP6LJCjKpwZqrM3TMDi1yUPBtHK8EUHrBGBHosZfrL2lj9JyTrSc37weZpBv9MPAy
 zUUQwRCEVbyWaLwLcRAjt+ih
X-SBRS: 5.1
X-MesageID: 57762104
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:UlRrs6n+RNzznrELmNyARjzo5gxpIURdPkR7XQ2eYbSJt1+Wr1Gzt
 xJMWWvQa6yIZGr8KIskbonip0gFvZXTx4JlGwJu/is2QiMWpZLJC+rCIxarNUt+DCFioGGLT
 Sk6QoOdRCzhZiaE/n9BClVlxJVF/fngqoDUUYYoAQgsA187IMsdoUg7wbdg2tQy2YPR7z6l4
 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc
 s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4
 I9hqZ2aRlx4B6D3k+otQUNAHBklFJQTrdcrIVDn2SCS50jPcn+qyPRyFkAme4Yf/46bA0kXq
 6ZecmpUKEne2aTmm9pXScE17ignBNPsM44F/Glp0BnSDOo8QICFSKLPjTNd9Gpv2Z4URK6CD
 yYfQWNLZQ3HPABMAW8aF7RljvyuoUbvXRQN/Tp5ooJoujOOnWSdyoPFL979atGMA8JPkS6wv
 mvb+0zpDxdcM8aQoRKH+H+xgu7EnQvgRZkfUra/85ZCkFCVg2AeFhASfV+6uuWizF6zXcpFL
 E4Z8TZoqrI9nHFHVfGkAUf++iTd+EdBBZwASIXW9T1h1IKOzxqYLGdfHwdMU9cohN1sXTMSj
 XawyoaB6SNUjJWZTneU97GxpDy0ODQIIWJqWRLoXTfp8PG4/9lt1kOnosJLVffv1IWsSG6YL
 yWi9XBm390uYdg3O7JXFLwtqwmnoYTVVUYL7wHTU3PNAuhRNdP9OdLABbQ26599wGelorup4
 Cdsdyu2trlm4XSxeMqlGrll8FaBvK7tDdEkqQQzd6TNDhz0k5JZQahe4StlOGBiOdsedDnib
 Sf74F0KuM8PZST6NfQqMupd7vjGK4C6SbwJsdiPNrJzjmVZLlfbrEmCm2bAt4wSrKTcuf5mY
 srKGSpdJX0bFb5m3FKLqxQ1itcWKtQF7TqLH/jTlk3/uZLHPSL9YepVYTOmM7FihIvZ8Vq9z
 jqqH5bTo/mpeLalOXe/HE96BQ1iEEXX8riv+pUJLLbaf1I6cIzjYteIqY4cl0Vet/09vs/D/
 22nW18ez1z6hHbdLh6NZGwlY7TqNauTZ1piYETA5H6khCouZ5iB9qAae8dldLUr7rU7n/V1U
 +MEa4OLBfEWEmbL/DEUbJ/cqo1+dUv02VLSbnT9ODVvLYR9QwHp+8P/ele9/ic5ESfq59A1p
 Ket112HTMNbFRhiFsvfdNmm00i14SoGgOt3UkaReotTdUzg/ZJEMSv0ivNrccgAJQ+anmmR1
 hqMAAderu7I+tdn/N7MjKGCjoGoD+ohQRYKQziFte67bHCI8HCizIlMVPezUQrcDG6kqr+/Y
 eh1zu3nNKFVllh9rIchQa1gyrgz5oWzquYCnBhkBnjCc3+iFqhkfiudxcBKu6BAmu1ZtA+xV
 h7d89VWI+zUasbsEVpXLws5dOWTk/oTn2CKv/gyJUz74g5x/aaGDhoOb0Xd1nQFIesnKp4hz
 McgpNUSul62hRcdO9qbijxZqjaXJXsaXqR77pwXDecHUObwJo2utXAENhLL3Q==
IronPort-HdrOrdr: A9a23:Bh2dJa82+uSXKK/Xf4puk+FEdb1zdoMgy1knxilNoENuHPBwxv
 rAoB1E73PJYVYqOE3Jmbi7Sc+9qFfnhONICO4qTMuftWjdyRGVxeRZjLcKrAeQfhEWmtQtsZ
 uINpIOd+EYbmIK/foSgjPIa+rIqePvmMvD6Ja8vhUdPj2CKZsQlDuRYjzrY3GeLzM2fKbReq
 Dsgfau8FGbCAoqh4mAdzQ4dtmGg+eOuIPtYBYACRJiwA6SjQmw4Lq/NxSDxB8RXx5G3L9nqA
 H+4kPEz5Tml8v+5g7X1mfV4ZgTsNz9yuFbDMjJrsQOMD3jhiuheYwkcbyfuzIepv2p9T8R4Z
 XxiiZlG/42x2Laf2mzrxeo8w780Aw243un8lOciWuLm72weBsKT+56wa5JeBrQ7EQt+Ptm1r
 hQ4m6fv51LSTvdgSXU/bHzJlFXv3vxhUBnvf8YjnRZX4dbQqRWt5Yj8ERcF4pFND7m6bogDP
 JlAKjnlbdrmGuhHjLkV1RUsZmRtixZJGbDfqFCgL3a79FupgE786NCr/Zv2Uvp9/oGOtB5Dq
 r/Q+JVfYp1P7orhJRGdZE8qPuMex7wqC33QRavyHTcZeo60iH22tTKCItc3pDcRHVP9upqpK
 j8
X-IronPort-AV: E=Sophos;i="5.87,173,1631592000"; 
   d="scan'208";a="57762104"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=cfVGkhvg2UWuRNCfIyLQoz12dlH308ATdsW01HiteQq5ONdE7nWTNfT2wweA66OMg7hip2/UbnSlvgLfVx0FFuQOf3JJ/ho1iazz6Le4OjtK82ytsUdHxhYm/QHasbQno8F8p3PtsGERzFf8R8HPauVW5JYiYCfCjEHpe3Fal6TcsGz/aaI5gIwqioc4aL1GaW1FzE0dpidBpnu8G5LABWDlc0TOiF2jYgOycxOL/h46cnlyglCAyLFZTJ6sHp17WT2aw3CDgu1GtPWLeD8pOMoN2oRxQ9lbPiyGc+qQDOXjCbiEyjatKlwRFx+Q6R+rqY9Y2lsk47W7xW6kh8LLEg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=eynO/FBr2tvmU3OQA65XB5VhrKHqp3got2j/tUP0p+c=;
 b=ZBbmOWKcLqekHUgvXZ8Tclrlx1uUo12FB+Nyi+0SA3aLS2P2bNkKMEHh1pJME5IsUa0rIs+c9IwsTeTJGpnXAv5y9aq/9zHKHgI0ZlcrKM0aIjT94BXsMPZYNGgx1jzHcJX+KDIHHFH9gtBV6V+8TGA1XwsQpKgz0+YZiuB9LuMX3F9cdkQKOa1jFKv9WU/tvE4W4Je5s9YFwZFnKuEAwNT98xlqT5Cy3t5iflHbJZHYwx8j3GHwJzXGIv3ToQBBKGUxkW0ly+Tcy82d+U++R9g/QmGFcRJTnuvQaGYWuolFHc9QRSGwhFGYSxP51y95+69CMYY7aLjSe4NoYiqXXA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=eynO/FBr2tvmU3OQA65XB5VhrKHqp3got2j/tUP0p+c=;
 b=Q0KYxKXjIOiqopZ8Gq+JXtGwcYQNzZfb9EVhd9TirdKgi3JfayWmWIa7LRXp0T4N20R8FMn1EARWqehIEsbwYrcEH5od+QEVVEBOYZmoEOTE4egFlx45726FO21+vwBgzLB3b3RIsIdFXHwcBgh5Ybabn/6c/3jaPgo3ATdDVIE=
Date: Fri, 22 Oct 2021 17:52:18 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, "Andrew
 Cooper" <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>, Paul Durrant
	<paul@xen.org>
Subject: Re: [PATCH v2 1/3] x86/IOMMU: mark IOMMU / intremap not in use when
 ACPI tables are missing
Message-ID: <YXLeMsuykEhSdfUg@MacBook-Air-de-Roger.local>
References: <09137aa2-649f-08fb-ba68-75f8eb16fc63@suse.com>
 <efe34081-c813-0e37-175c-8553b395e6d9@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <efe34081-c813-0e37-175c-8553b395e6d9@suse.com>
X-ClientProxiedBy: LO2P265CA0074.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:8::14) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: d2288733-4c7c-41e3-afdc-08d99573f09f
X-MS-TrafficTypeDiagnostic: DM8PR03MB6232:
X-Microsoft-Antispam-PRVS: <DM8PR03MB62324AB79B0B5CEB32A824C98F809@DM8PR03MB6232.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: t+kSxwa98EtovYCQb7In47J0VI7weVJ034PRUuDT8RzvfLMmk8SfcJSNEdq/UG7FxKBrNBqKd860mtkgVt5gsloCj3CasvF2rT4+e28Z9F7tarX35wTwWtjNCfoZFI3ce+Dr/Uz57NItsCowPwsln8T3E6JBOfHxHgtyiUN79Evm9DoG2VKe2hZjGvzeNpepkhKCxO54gebBXLMx9c2GoymWHLU0j9+B3oxtES9GM2OGQwYk398mtsas/3Ln36nanlFOg7q1+NwLT6Mm/nM+c8hXYUS0InDeOnKZKLgqxmQ6RAP9VJppYSHUgz1a7NCYFtvxHMV6iZmys8ljxl9rI3Rlkc0J0qB9uI/ldxcHSljb3wfRoMrvKGY5jZ0TX8jC/ad5SvuoctWYFzysZRNqHdjavmoFyq64vKMOegfU13ME+i+lYehuTw494GcMQdPnxvQ8Mfuy6yUTR9ZnfIk3niQ6UkfKz+2zaCWrtLLfs+3wt48Zk7m9hh15nTBkar5iHuylPx86OUsGk3Ecdz9LKpOpd6wMGMXOjyDRBQQctxeFVHHkpaRfA7I/iiLJTRCjXeoLMQ+yk2IO5A0q+yTXtOrOkez6YxPWM19LKTziqbtiMJqrP2HH7teOVcjiwFWAaFXJVr6gA3qBwiOrxTWOkw==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(186003)(316002)(5660300002)(956004)(26005)(9686003)(6916009)(85182001)(508600001)(54906003)(4326008)(82960400001)(8936002)(6496006)(6486002)(8676002)(38100700002)(2906002)(6666004)(83380400001)(86362001)(66556008)(66476007)(66946007);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K1BvV25WbjQ4S3pDN0lzeUhacGhoVER1NjlUSlBJcWNMVFZHNXUrTGVXaE1a?=
 =?utf-8?B?UVVwVGcwcUl5NWpwWm1NMXZiN1N3bkRxWGh2REx6RU9pOTdvTlduc3lOYVg2?=
 =?utf-8?B?RG1lNzBySjZRYVRqRW11dUx2dC8xNXYxL1k0ZVh1VW9ZZ0psbmtLVEQyZ3Bx?=
 =?utf-8?B?cjlIVUNmb1NXNGMrUm91K1FoSk9FelBRR3QvZHRPSUtOMnZXRDFyOTZTV0ow?=
 =?utf-8?B?OGFHOEd4UjI3ajcxbkw0QnZVQkw0dTRMS2JrOHFTV252Y2J0THI3UUEySVVu?=
 =?utf-8?B?emxFZjdETHFvclZlMWJJTW12VzFNZGtBWVMzSlNvd2hTbURrSncweml6cEhC?=
 =?utf-8?B?eGp3WFdkc0I3Um04cHdzTU1ucXE0ZnJneE1sK1Q0TkhFTHNFWkVaMmZmYzEr?=
 =?utf-8?B?VWpQZlVocDFHYXdHdWlsbmhhbkJRK0NMSFovdmJVeWVCNDIyY09ua0t1WG9o?=
 =?utf-8?B?N1p3WXZZT2pMaWpUVzNEaDJ6bmJtSlVCSmVyd3N2aDRMQjhhRFFZd1RNVjVK?=
 =?utf-8?B?a3J0bVJWMnBpTG84Ym5OTC9wVXh4cjVrZUFtWWpZQ2VTUDZlUXhNeVFYS3hh?=
 =?utf-8?B?dnFpUVNhdWZ5UmpEemRRUzZTU0xXWFZEVlIvWWV3a1F1YjliVW0wMG9qeVRy?=
 =?utf-8?B?MXVXaDhESktHVVdhL1FCdGpmbmRoNlRHMWFjNDJBTEJtZ1ZkeW5QeEFXVkxP?=
 =?utf-8?B?bFJZNjdmKzZSWkFCSUppZ2N2SmZIdWFYNDNkc2JPR3lJM0VWNWNaTnlJVE5Q?=
 =?utf-8?B?dGRhelVDaEVibnAwT0NzNENSZWJPSFFmU09VMEQ0S2FWejhmVFV6RXhtSDAw?=
 =?utf-8?B?V1JiL0h3ZGFoaUVlb0lhemtMazRVM3lYZ3UrR0JXbG5aK3NVSmdIMUswMGF5?=
 =?utf-8?B?UDQ0SFduMXc3YzZBcEdWYjR1VjhHaWdTVnZ5aXBWVWMzMGJDQ2I4TzVlb2RU?=
 =?utf-8?B?Z0lTYnpGSWZLS25nenBQMXNsK3B3d3Zqb0FCY1YxbUFCLzRiUjBjVHcvOVUr?=
 =?utf-8?B?K3FmZVhjenNjZHVKNWRtL1gzSm5xWTdDMm9EemJTQTRxaWZ6TmhDclZTWmNt?=
 =?utf-8?B?U3Z3NEl6azB2ZTRSTDlzRldNKzR0eUtzVlkwcVRRMGVXWU9qR2p5bzEwL1dO?=
 =?utf-8?B?d1BtdHozNVhNWDFKbkIxblFFZGJXd25qMkFXbVhBUXpPekFEZ2R0RUpZbmg4?=
 =?utf-8?B?cXdGUnZ0VXdSWEZmdjhuYmc3Wm14VTVOOXFJREozVkU3WTJ1YzJQOGllY09N?=
 =?utf-8?B?TExodFBqOWlGbGdSNXROTXFPZzVVZ3diVWZtODFRUDdaYlc4Y3BVQ3RENUE1?=
 =?utf-8?B?VHY5YXlhMXlmR0Vzbm1kSUsrSUVrTllOaDBuRWU2MDhRU09ES2t3SzRSeU5u?=
 =?utf-8?B?STNJMFFLWGJXSjVSbWxSOUpiY2N5cld1THlmZTB0cnZMRTNJcDF0UUpjR1Vo?=
 =?utf-8?B?MlNuTnNwcUY2SlRDNWFsbjRRa1lsS1g0M1VpbVI1THoyWGtSNnRoc2I4d1Vm?=
 =?utf-8?B?dGFBWTdYZm4ySHVlaHBvQnA3d09wUVB1K2lKdXUyV0lrOVRTdGJjRFJldVlI?=
 =?utf-8?B?ODdBa0IvN3NsZlA4T2ZRMjBlenpPYlozVHVQNEdCVHZGcEhIeHJSQndqMjdU?=
 =?utf-8?B?V3l0aElRcjBEQ1ZXVUw2SHdPTXBxb3NIeno4dVhYb0J1SVpDM3R2NU1CQ3FF?=
 =?utf-8?B?Z3Jyc3FmeUJWYWNYMUhDbDVEcTRJZVZFQlNZT2QwNlZsTmVmTlhnQjNRaEdK?=
 =?utf-8?B?bG5kNzZWanV2emE1alpZbTVCdkhKckVyTkN0bkNPeUZ1RlZrNTdVOURyOXVC?=
 =?utf-8?B?RUg2eUhreGFxZU1IYUlPSkZRQWI1cEpkY21BZlN0Smhwa243VmVTMHl0WWNR?=
 =?utf-8?B?TGlSSVRLMFRlQXdMVlNiNy91TnY3d3JnTnp3dHNQWTNEbDkyY2ROTVdGNmJ0?=
 =?utf-8?Q?oIDHAut66TrpwUWkkOU5LdheuAj1nKnQ?=
X-MS-Exchange-CrossTenant-Network-Message-Id: d2288733-4c7c-41e3-afdc-08d99573f09f
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Oct 2021 15:52:24.2461
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: roger.pau@citrix.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR03MB6232
X-OriginatorOrg: citrix.com

On Thu, Oct 21, 2021 at 11:58:18AM +0200, Jan Beulich wrote:
> x2apic_bsp_setup() gets called ahead of iommu_setup(), and since x2APIC
> mode (physical vs clustered) depends on iommu_intremap, that variable
> needs to be set to off as soon as we know we can't / won't enable
> interrupt remapping, i.e. in particular when parsing of the respective
> ACPI tables failed. Move the turning off of iommu_intremap from AMD
> specific code into acpi_iommu_init(), accompanying it by clearing of
> iommu_enable.
> 
> Take the opportunity and also fully skip ACPI table parsing logic on
> VT-d when both "iommu=off" and "iommu=no-intremap" are in effect anyway,
> like was already the case for AMD.
> 
> The tag below only references the commit uncovering a pre-existing
> anomaly.
> 
> Fixes: d8bd82327b0f ("AMD/IOMMU: obtain IVHD type to use earlier")
> Reported-by: Andrew Cooper <andrew.cooper3@citrix.com>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>

> ---
> While the change here deals with apic_x2apic_probe() as called from
> x2apic_bsp_setup(), the check_x2apic_preenabled() path looks to be
> similarly affected. That call occurs before acpi_boot_init(), which is
> what calls acpi_iommu_init(). The ordering in setup.c is in part
> relatively fragile, which is why for the moment I'm still hesitant to
> move the generic_apic_probe() call down. Plus I don't have easy access
> to a suitable system to test this case. Thoughts?

Indeed, that seems it could go quite wrong, as apic_x2apic_probe will
see iommu_intremap == iommu_intremap_full (the default value) and thus
could choose cluster mode without real interrupt remapping support.

At first sight it would seem possible to move lower down, but as you
say, this is all quite fragile. It's even made worse because we lack a
strict ordering discipline or any kind of dependency checking, so even
if we mess up the order it's likely to go unnoticed unless someone
tests on an affected system.

While we can try to solve this for the upcoming release, long term we
need a stricter ordering, either as a comment, or even better enforced
somehow in code. The x2APIC vs IOMMU ordering has bitten us multiple
times and we should see about implementing a more robust solution.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Fri Oct 22 16:14:09 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Oct 2021 16:14:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.215161.374175 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdxBG-0007MN-Ge; Fri, 22 Oct 2021 16:14:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 215161.374175; Fri, 22 Oct 2021 16:14:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdxBG-0007MG-DS; Fri, 22 Oct 2021 16:14:06 +0000
Received: by outflank-mailman (input) for mailman id 215161;
 Fri, 22 Oct 2021 16:14:04 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <ijackson@chiark.greenend.org.uk>) id 1mdxBE-0007Lg-Fl
 for xen-devel@lists.xenproject.org; Fri, 22 Oct 2021 16:14:04 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <ijackson@chiark.greenend.org.uk>) id 1mdxBE-0008IX-DA
 for xen-devel@lists.xenproject.org; Fri, 22 Oct 2021 16:14:04 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <ijackson@chiark.greenend.org.uk>) id 1mdxBE-0005pI-By
 for xen-devel@lists.xenproject.org; Fri, 22 Oct 2021 16:14:04 +0000
Received: from [172.18.45.5] (helo=zealot.relativity.greenend.org.uk)
 by mariner.uk.xensource.com with esmtp (Exim 4.89)
 (envelope-from <ijackson@chiark.greenend.org.uk>)
 id 1mdxBB-00021I-JM; Fri, 22 Oct 2021 17:14:01 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:
	Message-Id:Date:Subject:Cc:To:From;
	bh=MpBM4NNo27O2JFBnUtVOspBYEzKTZIT0qgH+kItMoMo=; b=eT3AP6DivVo5De7p3T7Lkq/2+X
	qd/FfqnGtckDzYL9qUZ2BkB3GJURJcwudRZCS236XaLjz0f30iKysR2vfaU7DdXI0oV0irJOE9yYF
	O4NIiJuyQ50maGZ1PbvA3Rj+BcqXhOeucKYAs8MjcfCEhszLCkmVyqP9lXaPMZGbUH74=;
From: Ian Jackson <iwj@xenproject.org>
To: xen-devel@lists.xenproject.org
Cc: Ian Jackson <iwj@xenproject.org>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	Jan Beulich <jbeulich@suse.com>
Subject: [OSSTEST PATCH 0/5] Only run ts-memdisk-try-append on BIOS hosts
Date: Fri, 22 Oct 2021 17:13:46 +0100
Message-Id: <20211022161351.23091-1-iwj@xenproject.org>
X-Mailer: git-send-email 2.20.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

There is an infelicity in handling of FreeBSD's "memdisk" test.

The use of this step is as part of host examination.  There, it may
fail on hosts which cannot cope with the FreeBSD version in use.  That
is OK (from a general osstest/CI POV) because each host has its own
job name and therefore its own regression tracking.  So this test
failing on those hosts is not troublesome.

But as part of the tests for osstest itself, and Xen and Linux, we
also check that host examination still works.  This is appropriate
because host examination also checks that we can retrieve accurate
serial logs, etc.

To this end many general flights have test-*-examine jobs.

Like any job, these are peripatetic.  The x86 ones might run on BIOS
hosts, or UEFI hosts.  But our support for FreeBSD does not cope with
UEFI yet.  The result is that whether this test passes or fails
depends on the host, but this is not a heisenbug which should be fixed
right away.

Sort this out as follows:

* Have the examine test only run the FreeBSD step when the host
  firmware is BIOS.  On non-FreeBSD hosts the test step will go from
  "fail" to "skip", which is appropriate.

* To make sure we catch actual regressions in this step, make a copy
  of the examine job which is always run on a BIOS host.

* While we are here, explicitly check that the examine job works on
  x86 UEFI too.


4.16 release implications:

There are two sets of changes here:

I. flight composition:

The runvar dump shows that this only adds new jobs.  I think these new
tests are good, but of course they might be broken somehow.  If they
are broken, they are new jobs which won't count as regressions, and if
they flap we can force push while we disable them again.

II. behavioural change to ts-memdisk-try-append

This change is *intended* to make the test "skip" in cases where it is
currently "fail".  I have done an ad-hoc check that this seems to DTRT
but it might be bad somehow.

However, this test is currently actually-failing on the xen-unstable
branch.  And it could be force pushed if necessary.

III. Benefits

The benefit of all this is to improve the testing for 4.16.  In
particular, the examine test ought now to run properly, and no longer
cause blockages.

I think at this stage of the release this change to osstest ought to
have a release-ack but I think I have convinced myself it's OK, so:
Release-Acked-By: Ian Jackson <iwj@xenproject.org>


Ian Jackson (5):
  make-flight: do_examine_one: add firmware argument
  ts-memdisk-try-append: Reindent (nfc)
  ts-memdisk-try-append: Enable perl warnings
  ts-memdisk-try-append: More defensive case test
  examination: skip memdisk on non-BIOS hosts, run on some BIOS hosts

 make-flight           | 23 ++++++++++++++++++++--
 mfi-common            |  1 +
 ts-memdisk-try-append | 45 +++++++++++++++++++++++++++++--------------
 3 files changed, 53 insertions(+), 16 deletions(-)

-- 
2.20.1



From xen-devel-bounces@lists.xenproject.org Fri Oct 22 16:14:09 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Oct 2021 16:14:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.215163.374185 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdxBH-0007W4-5H; Fri, 22 Oct 2021 16:14:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 215163.374185; Fri, 22 Oct 2021 16:14:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdxBG-0007Tu-UH; Fri, 22 Oct 2021 16:14:06 +0000
Received: by outflank-mailman (input) for mailman id 215163;
 Fri, 22 Oct 2021 16:14:04 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <ijackson@chiark.greenend.org.uk>) id 1mdxBE-0007Lr-No
 for xen-devel@lists.xenproject.org; Fri, 22 Oct 2021 16:14:04 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <ijackson@chiark.greenend.org.uk>) id 1mdxBE-0008If-NA
 for xen-devel@lists.xenproject.org; Fri, 22 Oct 2021 16:14:04 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <ijackson@chiark.greenend.org.uk>) id 1mdxBE-0005pf-MN
 for xen-devel@lists.xenproject.org; Fri, 22 Oct 2021 16:14:04 +0000
Received: from [172.18.45.5] (helo=zealot.relativity.greenend.org.uk)
 by mariner.uk.xensource.com with esmtp (Exim 4.89)
 (envelope-from <ijackson@chiark.greenend.org.uk>)
 id 1mdxBC-00021I-8m; Fri, 22 Oct 2021 17:14:02 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:
	References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From;
	bh=8bn2utW7cd6zKWTRhFw/fx1rt/qE6uN0b47C37/D6yQ=; b=3Gd8TmaouMRkznrHkVweNma+2v
	2HzL8XIqXD6842mEIx/5LZdEnEaUB1tYm9G0NPLv9gBBg7Fp0zjQNOOonohY+wGTrfjVYFs2BZvgH
	5aIRL9RzffpIveQ/k/OWduxx4tFqmD4hK26f2ZhZte0BODHDfY+VM17Z7gfenZ8v6l0w=;
From: Ian Jackson <iwj@xenproject.org>
To: xen-devel@lists.xenproject.org
Cc: Ian Jackson <iwj@xenproject.org>
Subject: [OSSTEST PATCH 2/5] ts-memdisk-try-append: Reindent (nfc)
Date: Fri, 22 Oct 2021 17:13:48 +0100
Message-Id: <20211022161351.23091-3-iwj@xenproject.org>
X-Mailer: git-send-email 2.20.1
In-Reply-To: <20211022161351.23091-1-iwj@xenproject.org>
References: <20211022161351.23091-1-iwj@xenproject.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Signed-off-by: Ian Jackson <iwj@xenproject.org>
---
 ts-memdisk-try-append | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/ts-memdisk-try-append b/ts-memdisk-try-append
index 4b54eff01..a35751eb3 100755
--- a/ts-memdisk-try-append
+++ b/ts-memdisk-try-append
@@ -19,17 +19,17 @@
 set -xe -o posix
 
 arch=`perl -I. -e '
-                use Osstest;
-                use Osstest::TestSupport;
+    use Osstest;
+    use Osstest::TestSupport;
 
-                tsreadconfig();
+    tsreadconfig();
 
-		our $whhost = pop @ARGV; # arg parsing bodge
-		$whhost ||= "host";
-		our $ho = selecthost($whhost);
+    our $whhost = pop @ARGV; # arg parsing bodge
+    $whhost ||= "host";
+    our $ho = selecthost($whhost);
 
-                print $ho->{Arch} or die $!;
-              ' "$@"`
+    print $ho->{Arch} or die $!;
+    ' "$@"`
 
 case "$arch" in
 amd64)
-- 
2.20.1



From xen-devel-bounces@lists.xenproject.org Fri Oct 22 16:14:09 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Oct 2021 16:14:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.215164.374193 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdxBH-0007dD-Fo; Fri, 22 Oct 2021 16:14:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 215164.374193; Fri, 22 Oct 2021 16:14:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdxBH-0007aT-8z; Fri, 22 Oct 2021 16:14:07 +0000
Received: by outflank-mailman (input) for mailman id 215164;
 Fri, 22 Oct 2021 16:14:05 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <ijackson@chiark.greenend.org.uk>) id 1mdxBF-0007Ly-0q
 for xen-devel@lists.xenproject.org; Fri, 22 Oct 2021 16:14:05 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <ijackson@chiark.greenend.org.uk>) id 1mdxBF-0008Ij-06
 for xen-devel@lists.xenproject.org; Fri, 22 Oct 2021 16:14:05 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <ijackson@chiark.greenend.org.uk>) id 1mdxBE-0005pr-VD
 for xen-devel@lists.xenproject.org; Fri, 22 Oct 2021 16:14:04 +0000
Received: from [172.18.45.5] (helo=zealot.relativity.greenend.org.uk)
 by mariner.uk.xensource.com with esmtp (Exim 4.89)
 (envelope-from <ijackson@chiark.greenend.org.uk>)
 id 1mdxBC-00021I-KX; Fri, 22 Oct 2021 17:14:02 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:
	References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From;
	bh=DcU6WEnD3l6gqqpttV87nLBzVOkZl/0MQXT5SDAWeuY=; b=hR+hvccWoeY638dgdU+ALg7LOh
	eVmLuVVkS6dJxQpkXs83HkUZ9BSPnBRofchKdcDfdGavA6uTXKOM4bpD8yCrKzC/Y+LQwKR4e17tA
	q6xaqk8BejJ79ig5kbQNu9C2mmpX2K2Eu0AIRnUjnHk3X5NIjoYIS3sbFhRwyEgmHyfI=;
From: Ian Jackson <iwj@xenproject.org>
To: xen-devel@lists.xenproject.org
Cc: Ian Jackson <iwj@xenproject.org>
Subject: [OSSTEST PATCH 3/5] ts-memdisk-try-append: Enable perl warnings
Date: Fri, 22 Oct 2021 17:13:49 +0100
Message-Id: <20211022161351.23091-4-iwj@xenproject.org>
X-Mailer: git-send-email 2.20.1
In-Reply-To: <20211022161351.23091-1-iwj@xenproject.org>
References: <20211022161351.23091-1-iwj@xenproject.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Signed-off-by: Ian Jackson <iwj@xenproject.org>
---
 ts-memdisk-try-append | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ts-memdisk-try-append b/ts-memdisk-try-append
index a35751eb3..bfb36caf7 100755
--- a/ts-memdisk-try-append
+++ b/ts-memdisk-try-append
@@ -18,7 +18,7 @@
 
 set -xe -o posix
 
-arch=`perl -I. -e '
+arch=`perl -I. -we '
     use Osstest;
     use Osstest::TestSupport;
 
-- 
2.20.1



From xen-devel-bounces@lists.xenproject.org Fri Oct 22 16:14:10 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Oct 2021 16:14:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.215165.374201 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdxBH-0007pX-Us; Fri, 22 Oct 2021 16:14:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 215165.374201; Fri, 22 Oct 2021 16:14:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdxBH-0007ly-M2; Fri, 22 Oct 2021 16:14:07 +0000
Received: by outflank-mailman (input) for mailman id 215165;
 Fri, 22 Oct 2021 16:14:05 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <ijackson@chiark.greenend.org.uk>) id 1mdxBF-0007M4-ED
 for xen-devel@lists.xenproject.org; Fri, 22 Oct 2021 16:14:05 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <ijackson@chiark.greenend.org.uk>) id 1mdxBF-0008In-DX
 for xen-devel@lists.xenproject.org; Fri, 22 Oct 2021 16:14:05 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <ijackson@chiark.greenend.org.uk>) id 1mdxBF-0005qB-CW
 for xen-devel@lists.xenproject.org; Fri, 22 Oct 2021 16:14:05 +0000
Received: from [172.18.45.5] (helo=zealot.relativity.greenend.org.uk)
 by mariner.uk.xensource.com with esmtp (Exim 4.89)
 (envelope-from <ijackson@chiark.greenend.org.uk>)
 id 1mdxBD-00021I-7G; Fri, 22 Oct 2021 17:14:03 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:
	References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From;
	bh=evtXNMnDQkLpcWEbYHSP3jP0fEmsSHHSw3jYqtKIZKU=; b=0NiaIbvAVXrTUNno86NNLkYUOH
	7FDDvu2Y7q3i2/Aiz3f81KybXT7ccHSn6A310c7rXkNoR3cITPAN5CIj8pG28y1CVhCspeICTEdlU
	rq5HDrEaKtbbtucSpSXcQJjKSEsKqHwiB2DjUcN2x7QH1Jcpmr0+gt85UDjOvOJFaHJ4=;
From: Ian Jackson <iwj@xenproject.org>
To: xen-devel@lists.xenproject.org
Cc: Ian Jackson <iwj@xenproject.org>
Subject: [OSSTEST PATCH 4/5] ts-memdisk-try-append: More defensive case test
Date: Fri, 22 Oct 2021 17:13:50 +0100
Message-Id: <20211022161351.23091-5-iwj@xenproject.org>
X-Mailer: git-send-email 2.20.1
In-Reply-To: <20211022161351.23091-1-iwj@xenproject.org>
References: <20211022161351.23091-1-iwj@xenproject.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Signed-off-by: Ian Jackson <iwj@xenproject.org>
---
 ts-memdisk-try-append | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/ts-memdisk-try-append b/ts-memdisk-try-append
index bfb36caf7..d5c12866f 100755
--- a/ts-memdisk-try-append
+++ b/ts-memdisk-try-append
@@ -34,14 +34,14 @@ arch=`perl -I. -we '
 case "$arch" in
 amd64)
     ;;
-'')
-    echo >&2 'Job arch retrieval failed?'
-    exit 1
-    ;;
-*)
+[a-z]*)
     echo "Arch $arch not supported for memdisk tests"
     exit 0
     ;;
+*)
+    echo >&2 'Job arch retrieval failed?'
+    exit 1
+    ;;
 esac
 
 if ./ts-freebsd-host-install --test-boot --record-append $@; then
-- 
2.20.1



From xen-devel-bounces@lists.xenproject.org Fri Oct 22 16:14:10 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Oct 2021 16:14:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.215166.374209 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdxBI-0007vO-DI; Fri, 22 Oct 2021 16:14:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 215166.374209; Fri, 22 Oct 2021 16:14:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdxBI-0007tS-2Q; Fri, 22 Oct 2021 16:14:08 +0000
Received: by outflank-mailman (input) for mailman id 215166;
 Fri, 22 Oct 2021 16:14:05 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <ijackson@chiark.greenend.org.uk>) id 1mdxBF-0007MA-ND
 for xen-devel@lists.xenproject.org; Fri, 22 Oct 2021 16:14:05 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <ijackson@chiark.greenend.org.uk>) id 1mdxBF-0008Ir-MW
 for xen-devel@lists.xenproject.org; Fri, 22 Oct 2021 16:14:05 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <ijackson@chiark.greenend.org.uk>) id 1mdxBF-0005qJ-Lj
 for xen-devel@lists.xenproject.org; Fri, 22 Oct 2021 16:14:05 +0000
Received: from [172.18.45.5] (helo=zealot.relativity.greenend.org.uk)
 by mariner.uk.xensource.com with esmtp (Exim 4.89)
 (envelope-from <ijackson@chiark.greenend.org.uk>)
 id 1mdxBD-00021I-Mo; Fri, 22 Oct 2021 17:14:03 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:
	References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From;
	bh=VDS6BNOrW+LwBBI6dSIzWM00hGlwk6ensvTQtDw+lVs=; b=5cjvR1b7IbCWRUqE78BBclBFNU
	p5+pYBoDLvO1Biufula2Pg8G3uFfYWeOj0DpllwreJC/SnwpPm3NmTx4ZVDQahqgQq23JWH3LodDF
	Z1h+8hfxF6vL3/3IQuLJ48AYmUJgkLTy8WjigO8y2Q+Nl7/9wT3FU16tTHCk6sEyWBL0=;
From: Ian Jackson <iwj@xenproject.org>
To: xen-devel@lists.xenproject.org
Cc: Ian Jackson <iwj@xenproject.org>
Subject: [OSSTEST PATCH 5/5] examination: skip memdisk on non-BIOS hosts, run per-firmware on x86
Date: Fri, 22 Oct 2021 17:13:51 +0100
Message-Id: <20211022161351.23091-6-iwj@xenproject.org>
X-Mailer: git-send-email 2.20.1
In-Reply-To: <20211022161351.23091-1-iwj@xenproject.org>
References: <20211022161351.23091-1-iwj@xenproject.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

This is a combination of two changes:

ts-memdisk-try-append: skip memdisk test on non-BIOS hosts

make-flight: examine: Insist on -bios and -uefi tests on x86

  This will let us skip ts-memdisk-try-append on non-bios platforms
  without risking regression.  It will also definitely spot
  regressions which will occur on any uefi host.

  standalone-generate-dump-flight-runvars reveals the changes are as
  follows:

  New jobs
     test-amd64-i386-examine-bios     test-amd64-i386-examine-uefi
     test-amd64-amd64-examine-bios    test-amd64-amd64-examine-uefi
  added everywhere that has the corresponding plain job, namely
     osstest
     linux-*
     xen-unstable

  These jobs are just like the plain jobs, except that one of
     ,PropEq:Firmware:bios:bios
     ,PropEq:Firmware:bios:uefi
  has been added to the end of all_hostflags.

Signed-off-by: Ian Jackson <iwj@xenproject.org>
---
 make-flight           |  9 +++++++++
 mfi-common            |  1 +
 ts-memdisk-try-append | 17 +++++++++++++++++
 3 files changed, 27 insertions(+)

diff --git a/make-flight b/make-flight
index acb19b113..d7eeb4ebb 100755
--- a/make-flight
+++ b/make-flight
@@ -736,6 +736,15 @@ test_matrix_do_one () {
   do_credit12_tests
 
   do_examine_one
+  case "$dom0arch" in
+    i386|amd64)
+      # Test on BIOS, which makes sure we test one where FreeBSD should
+      # work.  See ts-memdisk-try-append, and set_freebsd_runvars in
+      # mfi-common.
+      do_examine_one bios
+      do_examine_one uefi
+      ;;
+  esac
 
   # No further arm tests at the moment
   if [ $dom0arch = armhf -o $dom0arch = arm64 ]; then
diff --git a/mfi-common b/mfi-common
index 771843f05..59e712f4e 100644
--- a/mfi-common
+++ b/mfi-common
@@ -163,6 +163,7 @@ set_freebsd_runvars () {
     if [ x$no_hostflags != xtrue ]; then
         # osstest doesn't yet know how to install FreeBSD on UEFI hosts, so
         # limit the usable hardware to boxes that boot from BIOS.
+        # See also in ts-memdisk-try-append.
         freebsd_runvars="all_hostflags,=PropEq:Firmware:bios:bios"
     fi
 
diff --git a/ts-memdisk-try-append b/ts-memdisk-try-append
index d5c12866f..8fd6540b8 100755
--- a/ts-memdisk-try-append
+++ b/ts-memdisk-try-append
@@ -28,6 +28,20 @@ arch=`perl -I. -we '
     $whhost ||= "host";
     our $ho = selecthost($whhost);
 
+    if (get_target_property($ho,"firmware") ne "bios") {
+        # osstest does not yet know how to install FreeBSD on UEFI hosts
+	# See also in set_freebsd_runvars in mfi_common
+
+	# Skipping this test on non-BIOS does not lead to pushes
+	# where this test is broken, because make-flght test_matrix_do_one
+	# arranges to run this test on BIOS too.
+
+        broken("skipping memdisk because firmware is not bios",
+	       "skip");
+	print "SKIP\n" or die $!;
+	exit 0;
+    }
+
     print $ho->{Arch} or die $!;
     ' "$@"`
 
@@ -37,6 +51,9 @@ amd64)
 [a-z]*)
     echo "Arch $arch not supported for memdisk tests"
     exit 0
+SKIP)
+    echo "Step skipped."
+    exit 0
     ;;
 *)
     echo >&2 'Job arch retrieval failed?'
-- 
2.20.1



From xen-devel-bounces@lists.xenproject.org Fri Oct 22 16:14:10 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Oct 2021 16:14:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.215162.374181 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdxBG-0007Pm-Sa; Fri, 22 Oct 2021 16:14:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 215162.374181; Fri, 22 Oct 2021 16:14:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdxBG-0007O0-Ke; Fri, 22 Oct 2021 16:14:06 +0000
Received: by outflank-mailman (input) for mailman id 215162;
 Fri, 22 Oct 2021 16:14:04 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <ijackson@chiark.greenend.org.uk>) id 1mdxBE-0007Ll-J7
 for xen-devel@lists.xenproject.org; Fri, 22 Oct 2021 16:14:04 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <ijackson@chiark.greenend.org.uk>) id 1mdxBE-0008Ib-IR
 for xen-devel@lists.xenproject.org; Fri, 22 Oct 2021 16:14:04 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <ijackson@chiark.greenend.org.uk>) id 1mdxBE-0005pZ-HJ
 for xen-devel@lists.xenproject.org; Fri, 22 Oct 2021 16:14:04 +0000
Received: from [172.18.45.5] (helo=zealot.relativity.greenend.org.uk)
 by mariner.uk.xensource.com with esmtp (Exim 4.89)
 (envelope-from <ijackson@chiark.greenend.org.uk>)
 id 1mdxBB-00021I-TW; Fri, 22 Oct 2021 17:14:02 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:
	References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From;
	bh=7IUjLruFSXIBQC2SZQbBsA+xVWNefGvveU/I4eJ4VMw=; b=n3T7JFz5UR+KrQAIkiy8yxlqdX
	CdoatbDWJY6mp0Fj8Bd6cLd1nWGBB0nFHWqaaqvHeXapL8e6FxotpHX+C7qAnuYdUCbpQRjkhOLb6
	UtASnRkwfdhtgIkfHJJx2V4S4kMA6LLk+Pu/W+Nmur8YGZEKU2wdVz0WXfyHtbMLcuR8=;
From: Ian Jackson <iwj@xenproject.org>
To: xen-devel@lists.xenproject.org
Cc: Ian Jackson <iwj@xenproject.org>
Subject: [OSSTEST PATCH 1/5] make-flight: do_examine_one: add firmware argument
Date: Fri, 22 Oct 2021 17:13:47 +0100
Message-Id: <20211022161351.23091-2-iwj@xenproject.org>
X-Mailer: git-send-email 2.20.1
In-Reply-To: <20211022161351.23091-1-iwj@xenproject.org>
References: <20211022161351.23091-1-iwj@xenproject.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Nothing sets this yet.

No functional change (checked with standalone-generate-dump-flight-runvars)

Signed-off-by: Ian Jackson <iwj@xenproject.org>
---
 make-flight | 15 +++++++++++++--
 1 file changed, 13 insertions(+), 2 deletions(-)

diff --git a/make-flight b/make-flight
index ecbb195bc..acb19b113 100755
--- a/make-flight
+++ b/make-flight
@@ -687,20 +687,31 @@ do_pv_debian_tests () {
 }
 
 do_examine_one () {
+  local firmware="$1"
+
   case "$branch" in
     xen-unstable)		;; # only likely to regress on -unstable
     osstest)			;; # very likely to regress
     linux-*)			;; # often seems to regress
     *)			return	;; # stuff used for guests is irrelevant
   esac
+
+  local firmware_suffix
+  local firmware_hostflag
+  if [ "$firmware" ]; then
+    firmware_suffix=-$firmware
+    firmware_hostflag=,PropEq:Firmware:bios:$firmware
+  fi
+
   local freebsd_runvars
   # set_freebsd_runvars expects $arch to be set to the desired FreeBSD arch.
   local arch=$dom0arch
   # Pass true to not append any hostflags when creating the FreeBSD runvars.
   set_freebsd_runvars true
-  job_create_test test-$xenarch$kern-$dom0arch-examine \
+  job_create_test test-$xenarch$kern-$dom0arch-examine${firmware_suffix} \
                   host-examine-xen xl $xenarch $dom0arch \
-                  all_hostflags=$most_hostflags $freebsd_runvars
+                  all_hostflags=$most_hostflags$firmware_hostflag \
+                  $freebsd_runvars
 }
 
 test_matrix_do_one () {
-- 
2.20.1



From xen-devel-bounces@lists.xenproject.org Fri Oct 22 16:38:04 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Oct 2021 16:38:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.215199.374241 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdxYM-0004Go-48; Fri, 22 Oct 2021 16:37:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 215199.374241; Fri, 22 Oct 2021 16:37:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdxYM-0004Gh-1F; Fri, 22 Oct 2021 16:37:58 +0000
Received: by outflank-mailman (input) for mailman id 215199;
 Fri, 22 Oct 2021 16:37:56 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=VW94=PK=citrix.com=anthony.perard@srs-us1.protection.inumbo.net>)
 id 1mdxYK-0004GW-6H
 for xen-devel@lists.xenproject.org; Fri, 22 Oct 2021 16:37:56 +0000
Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 6807eb3c-3356-11ec-83c9-12813bfff9fa;
 Fri, 22 Oct 2021 16:37:55 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6807eb3c-3356-11ec-83c9-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1634920675;
  h=from:to:cc:subject:date:message-id:mime-version:
   content-transfer-encoding;
  bh=tIg+M538g0DwCkamXnfy8wOB2B6LeDFbdsRlcsn6Hog=;
  b=APMaQzChHSQDGrNZYvXRQM84yXsPQ+WmwVO/nUCQiSbGQSyeZp4Hp7qi
   3t1AIGghdA2RqZYw+JMSJnEVPAooHRve3VJ0eh/taZUTeWHXOOgk8JkHR
   XkaYon7Uh5Ueua9TKRbJEfp9o9p5NHzw81NN60H2f5Np0iHLZ8e9bu3by
   g=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: 8OyI/AG1XXA/sLHurCn3f0qzBdBktJEKfO3WVENfAYtQROWIINhjMyvPf1LgC87ZU0yGNpPf1f
 KAseH+eBRL4MoM0qeOSjN5llh+SLzYwLUxShUJGhUzqDIlpLRSJIsUBoejvww8Xy0k89JeDu8+
 5syXq4KnhQp+4kTUvicolUWvAoxtVlTRciJ3cbWylE56qZFfua3L7D/nsdfk+yfjKzJ2CsyBWp
 BNUvTnt01g/LcmFnGlEUF1lr/nCrIvNSNE64N6+gX21eu8zAgMYvli1h3fWEJPU5YICSsdtEjt
 RPix77CTPts79R27l1v7bdgy
X-SBRS: 5.1
X-MesageID: 57766901
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:yRtj/axMk2U2N2n5elV6t+fFwSrEfRIJ4+MujC+fZmUNrF6WrkUFx
 2McC2CBbPmLamCje4wkaYWxo08F6pGEyoNhGgtlqyAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx
 59DAjUVBJlsFhcwnvopW1TYhSEUOZugH9IQM8aZfHAuLeNYYH1500s6w7Rj2tUAbeWRWGthh
 /uj+6UzB3f9s9JEGjp8B3Wr8U4HUFza4Vv0j3RmDRx5lAa2e0o9VfrzEZqZPXrgKrS4K8bhL
 wr1IBNVyUuCl/slIovNfr8W6STmSJaKVeSFoiI+t6RPHnGuD8H9u0o2HKN0VKtZt9mGt+Aul
 uVGkJWKcwN3H5TyistHdQRFKhgraMWq+JefSZS+mcmazkmAeHrw2fR+SkoxOOX0+M4uXzsIr
 6ZBbmlQMFbT3Ipaw5riIgVors0lMMnsOpJZonx6xCvVJf0nXYrCU+PB4towMDIY258RQ6iPP
 5NxhTxHbg3+UwNWERQsNbllgtqBlFf7aGdYkQfAzUYwyzeKl1EguFT3C/LOYcCDT8hRmkeep
 0rF8n7/DxVcM8aQoRKO+2iggeLnlirhVIUfUra/85ZCgUKR7nweDgUMUlm2quX/jVSxM/pPJ
 kpR9icwoKwa8E2wUsK7TxC+uGSDvBMXR5xXCeJSwB6J4rrZ5UCeHGdsc9JaQIV47olsH2Vsj
 wLX2YOybdByjFGLYULCqIefiDqIAyxLDFY8dwBeaxYY2uC29enfkSnzZtpkFae0iPj8Fjfx3
 y2GoUACulkDsSIY//7kpQ6f0lpAsrCMF1RvvlyGAQpJ+ysgPNb9D7FE/2Q3+hqpwGyxdVKGo
 GQf0/aX6OQDHPlhfwTcHb1TQtlFCxuDWQAwYGKD/bF9qFxBGFb5JOi8BQ2Swm8zbq7onheyO
 CfuVft5vsM7AZdTRfYfj3iNI8or17P8Mt/uS+rZaNFDCrAoKlTbrH03Oh7IhD28+KTJrU3ZE
 c3HGSpLJS1CYZmLMRLsH7tNuVPV7nBWKZzvqWDTkE38jOv2iI+9QrYZKlqeBt3VH4vfyDg5B
 +13bpPQoz0GCbWWSnCOreY7cABbRVBmVMueg5EGKYa+zv9ORThJ5wn5muh6JeSIXs19y4/1w
 51KchUHkweu1SGddW1nqBlLMdvSYHq2llpjVQREALpi8yFLjV+H4PhNep0pU6Mg8eA/n/d4Q
 +NcI5eLA+hVSySB8DMYNMGvoItnfRWtpASPIyv6P2RvI88+H1TEqo3+Yw/i1CgSFS7r58Ewl
 KKti1HASp0ZSgU8UMuPMKCzz0m8tGQ2kf5pWxeaOcFafUjhqdA4KyH4gvItDdsLLBHPmmmT2
 wqMWE9KrujRuY4lttLOgPnc/YuuFuJ/GGtcHnXasunqZXWLoDL7zNYZAuiSfD3bWGflw4mYZ
 L1Yn6PmLfkKvFdWqI4gQbxl+r0zuon0rLhAwwU6QHiSNwa3CqltK2Wt1NVUsvEf3adQvAa7V
 x7d+tRePrnVasrpHERIeVggZ+WHk/oVhiPT/bI+J0CjvH17+7+OUENzORiQiXMCcOspYd19m
 epx6tQL7wGfiwYxNofUhy9ZwG2AM3gcXvh1rZodGoLq1lImx1wqjUYw0cMqDEVjs+lxD3Q=
IronPort-HdrOrdr: A9a23:ALPcqaG4YnZ4cu9WpLqE4seALOsnbusQ8zAXP0AYc3Nom6uj5q
 WTdZUgpHjJYVkqOU3I9ersBEDiewK/yXcW2+ks1N6ZNWGM0ldARLsSibcKqAePJ8SRzIJgPN
 9bAstDNOE=
X-IronPort-AV: E=Sophos;i="5.87,173,1631592000"; 
   d="scan'208";a="57766901"
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: <wl@xen.org>, <iwj@xenproject.org>, <sstabellini@kernel.org>,
	<andrew.cooper3@citrix.com>, Anthony PERARD <anthony.perard@citrix.com>,
	"Doug Goldstein" <cardoe@cardoe.com>
Subject: [XEN PATCH] automation: actually build with clang for ubuntu-focal-clang* jobs
Date: Fri, 22 Oct 2021 17:36:44 +0100
Message-ID: <20211022163644.547018-1-anthony.perard@citrix.com>
X-Mailer: git-send-email 2.33.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---
 automation/gitlab-ci/build.yaml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/automation/gitlab-ci/build.yaml b/automation/gitlab-ci/build.yaml
index d177da1710d7..08a43146aba8 100644
--- a/automation/gitlab-ci/build.yaml
+++ b/automation/gitlab-ci/build.yaml
@@ -429,12 +429,12 @@ ubuntu-focal-gcc-debug:
     CONTAINER: ubuntu:focal
 
 ubuntu-focal-clang:
-  extends: .gcc-x86-64-build
+  extends: .clang-x86-64-build
   variables:
     CONTAINER: ubuntu:focal
 
 ubuntu-focal-clang-debug:
-  extends: .gcc-x86-64-build-debug
+  extends: .clang-x86-64-build-debug
   variables:
     CONTAINER: ubuntu:focal
 
-- 
Anthony PERARD



From xen-devel-bounces@lists.xenproject.org Fri Oct 22 16:39:35 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Oct 2021 16:39:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.215208.374251 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdxZu-0004vi-KM; Fri, 22 Oct 2021 16:39:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 215208.374251; Fri, 22 Oct 2021 16:39:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdxZu-0004vb-HL; Fri, 22 Oct 2021 16:39:34 +0000
Received: by outflank-mailman (input) for mailman id 215208;
 Fri, 22 Oct 2021 16:39:32 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mdxZs-0004vT-J7
 for xen-devel@lists.xenproject.org; Fri, 22 Oct 2021 16:39:32 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mdxZs-0000KK-CK
 for xen-devel@lists.xenproject.org; Fri, 22 Oct 2021 16:39:32 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mdxZs-0007vB-B7
 for xen-devel@lists.xenproject.org; Fri, 22 Oct 2021 16:39:32 +0000
Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89)
 (envelope-from <iwj@xenproject.org>)
 id 1mdxZo-00028O-Q3; Fri, 22 Oct 2021 17:39:28 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date
	:Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From;
	bh=d8oRa1yNpBhV0f5hvaDdaht5jHs3LW30RkrPh7mChZ0=; b=c4p+rGTCJMTic+49NzxABVt/gJ
	mGzBkcYJYaaspHyV3RF7ZI0mZls+8Xa3NPA0mYT4YouYEAHHPm7FghTh2GQ/q8W8QMt4U/zxEABC8
	1diZtZRUpSgaFyqNA3QddEuvt800BLoz6feVq5ss3C9GHQde9iRylgZQ6hTL8Xqxd0tE=;
From: Ian Jackson <iwj@xenproject.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <24946.59712.338061.192369@mariner.uk.xensource.com>
Date: Fri, 22 Oct 2021 17:39:28 +0100
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: <xen-devel@lists.xenproject.org>,
    <wl@xen.org>,
    <sstabellini@kernel.org>,
    <andrew.cooper3@citrix.com>,
    "Doug Goldstein" <cardoe@cardoe.com>
Subject: Re: [XEN PATCH] automation: actually build with clang for ubuntu-focal-clang* jobs
In-Reply-To: <20211022163644.547018-1-anthony.perard@citrix.com>
References: <20211022163644.547018-1-anthony.perard@citrix.com>
X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu)

Anthony PERARD writes ("[XEN PATCH] automation: actually build with clang for ubuntu-focal-clang* jobs"):
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>

I think this is a "straightforawrd bugfix" so does not need a release
ack, but FTR

Release-Acked-by: Ian Jackson <iwj@xenproject.org>

Ian.


From xen-devel-bounces@lists.xenproject.org Fri Oct 22 16:57:55 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Oct 2021 16:57:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.215219.374269 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdxrT-0007Fv-7P; Fri, 22 Oct 2021 16:57:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 215219.374269; Fri, 22 Oct 2021 16:57:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mdxrT-0007Fo-49; Fri, 22 Oct 2021 16:57:43 +0000
Received: by outflank-mailman (input) for mailman id 215219;
 Fri, 22 Oct 2021 16:57:42 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=TWKL=PK=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1mdxrS-0007Fi-GG
 for xen-devel@lists.xenproject.org; Fri, 22 Oct 2021 16:57:42 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 2b209892-3359-11ec-83cb-12813bfff9fa;
 Fri, 22 Oct 2021 16:57:41 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id 7BB42611BD;
 Fri, 22 Oct 2021 16:57:40 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2b209892-3359-11ec-83cb-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1634921860;
	bh=1a0ELAvtHtixYsdtjamTsgX3oCvwUqbGOt+TmP0/jOs=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=mWAZRzlTE9Crlyv+pp8FNvdLwVZoMmSG95+6G9GtRYuwqRw9OEw1XTrUJYjuZlZZT
	 hLkGiEuokyDmG8/lQRoIwmKEz/tPZVmjxMA1TajmOFZRllCb7hL2Kynj1qdZbcYFWG
	 EVRIFufcHVITnM1L5QAQaTmr1OuW60s3GdlQ7kiDNBTpcyH2UD8ydGZQjV1GvlCea/
	 EC9oHdN1Ed/WUO3npFKNk7pA8H8DMdApx4tXUNiA8++2fvnzOyGtcks8YVC0NOHhgc
	 90lGThErLVhyqJFOBCHPJfcCObhxz/0zC5dvodN4+jrkXQOfVaS5eUCAIY+BS5icQJ
	 ts9KlzR+1PI+A==
Date: Fri, 22 Oct 2021 09:57:39 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Anthony PERARD <anthony.perard@citrix.com>
cc: xen-devel@lists.xenproject.org, wl@xen.org, iwj@xenproject.org, 
    sstabellini@kernel.org, andrew.cooper3@citrix.com, 
    Doug Goldstein <cardoe@cardoe.com>
Subject: Re: [XEN PATCH] automation: actually build with clang for
 ubuntu-focal-clang* jobs
In-Reply-To: <20211022163644.547018-1-anthony.perard@citrix.com>
Message-ID: <alpine.DEB.2.21.2110220957220.2311@sstabellini-ThinkPad-T480s>
References: <20211022163644.547018-1-anthony.perard@citrix.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Fri, 22 Oct 2021, Anthony PERARD wrote:
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>

Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>


> ---
>  automation/gitlab-ci/build.yaml | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/automation/gitlab-ci/build.yaml b/automation/gitlab-ci/build.yaml
> index d177da1710d7..08a43146aba8 100644
> --- a/automation/gitlab-ci/build.yaml
> +++ b/automation/gitlab-ci/build.yaml
> @@ -429,12 +429,12 @@ ubuntu-focal-gcc-debug:
>      CONTAINER: ubuntu:focal
>  
>  ubuntu-focal-clang:
> -  extends: .gcc-x86-64-build
> +  extends: .clang-x86-64-build
>    variables:
>      CONTAINER: ubuntu:focal
>  
>  ubuntu-focal-clang-debug:
> -  extends: .gcc-x86-64-build-debug
> +  extends: .clang-x86-64-build-debug
>    variables:
>      CONTAINER: ubuntu:focal
>  
> -- 
> Anthony PERARD
> 


From xen-devel-bounces@lists.xenproject.org Fri Oct 22 19:17:24 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Oct 2021 19:17:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.215232.374286 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1me02S-00032T-D2; Fri, 22 Oct 2021 19:17:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 215232.374286; Fri, 22 Oct 2021 19:17:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1me02S-00032M-9c; Fri, 22 Oct 2021 19:17:12 +0000
Received: by outflank-mailman (input) for mailman id 215232;
 Fri, 22 Oct 2021 19:17:10 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1me02Q-00032C-4a; Fri, 22 Oct 2021 19:17:10 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1me02P-00033X-Kq; Fri, 22 Oct 2021 19:17:09 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1me02P-0007Vo-C4; Fri, 22 Oct 2021 19:17:09 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1me02P-0004W2-Bb; Fri, 22 Oct 2021 19:17:09 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Message-Id:Subject:To;
	bh=7AXSAnZk33ZIVaNshCS1EJ/bdh1+aiv0ehWAE0BvQjY=; b=Shn77QSQv4g2iyBH2Ems2ZrJCV
	ygHbzGXOz53FRA6kN9pEEfKrm4Ibxrh39yyHgRUY3Y08Oay9NmxsEjHiF32rco6wwVnMjh5qo84e6
	sVnk86t8dVlFsq9JXHON9dSMvprzRyrJDXXXCga453NcUYspLtx1IjgCmdVJJ6yHN/Gw=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Subject: [qemu-mainline bisection] complete build-i386
Message-Id: <E1me02P-0004W2-Bb@osstest.test-lab.xenproject.org>
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 22 Oct 2021 19:17:09 +0000

branch xen-unstable
xenbranch xen-unstable
job build-i386
testid xen-build

Tree: ovmf git://xenbits.xen.org/osstest/ovmf.git
Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git
Tree: qemuu git://git.qemu.org/qemu.git
Tree: seabios git://xenbits.xen.org/osstest/seabios.git
Tree: xen git://xenbits.xen.org/xen.git

*** Found and reproduced problem changeset ***

  Bug is in tree:  qemuu git://git.qemu.org/qemu.git
  Bug introduced:  e741aff0f43343d6d91242fee1072fee376d5cce
  Bug not present: 685db13a38f7599fabd353382ff65d3c244ea641
  Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/165788/


  commit e741aff0f43343d6d91242fee1072fee376d5cce
  Author: Igor Mammedov <imammedo@redhat.com>
  Date:   Thu Sep 2 07:35:38 2021 -0400
  
      tests: qtest: add qtest_has_accel() to check if tested binary supports accelerator
      
      Currently it is not possible to create tests that have KVM as a hard
      requirement on a host that doesn't support KVM for tested target
      binary (modulo going through the trouble of compiling out
      the offending test case).
      
      Following scenario makes test fail when it's run on non x86 host:
        qemu-system-x86_64 -enable-kvm -M q35,kernel-irqchip=on -smp 1,maxcpus=288
      
      This patch introduces qtest_has_accel() to let users check if accel is
      available in advance and avoid executing non run-able test-cases.
      
      It implements detection of TCG and KVM only, the rest could be
      added later on, when we actually start testing them in qtest.
      
      Signed-off-by: Igor Mammedov <imammedo@redhat.com>
      Message-Id: <20210902113551.461632-3-imammedo@redhat.com>
      Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
      Signed-off-by: Michael S. Tsirkin <mst@redhat.com>


For bisection revision-tuple graph see:
   http://logs.test-lab.xenproject.org/osstest/results/bisect/qemu-mainline/build-i386.xen-build.html
Revision IDs in each graph node refer, respectively, to the Trees above.

----------------------------------------
Running cs-bisection-step --graph-out=/home/logs/results/bisect/qemu-mainline/build-i386.xen-build --summary-out=tmp/165788.bisection-summary --basis-template=165682 --blessings=real,real-bisect,real-retry qemu-mainline build-i386 xen-build
Searching for failure / basis pass:
 165726 fail [host=fiano0] / 165682 [host=huxelrebe0] 165670 [host=albana0] 165640 [host=huxelrebe0] 165576 [host=albana1] 165536 [host=huxelrebe0] 165529 [host=albana1] 165514 [host=fiano1] 165506 [host=fiano1] 165498 [host=huxelrebe0] 165488 [host=albana1] 165477 [host=huxelrebe0] 165468 [host=fiano1] 165442 [host=albana1] 165429 ok.
Failure / basis pass flights: 165726 / 165429
(tree with no url: minios)
Tree: ovmf git://xenbits.xen.org/osstest/ovmf.git
Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git
Tree: qemuu git://git.qemu.org/qemu.git
Tree: seabios git://xenbits.xen.org/osstest/seabios.git
Tree: xen git://xenbits.xen.org/xen.git
Latest 2f286930a8280f4d817460020110009938f695b6 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 4c127fdbe81d66e7cafed90908d0fd1f6f2a6cd0 64f37cc530f144e53c190c9e8209a51b58fd5c43 118da371d1ff5d8432fa299544b1ea5e7e3710f0
Basis pass b4da6c29f1d36031e04212f53277ce0dcba309f1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 14f12119aa675e9e28207a48b0728a2daa5b88d6 64f37cc530f144e53c190c9e8209a51b58fd5c43 192aaf7e146c0b41dbdd35ccdb13eb33ced13633
Generating revisions with ./adhoc-revtuple-generator  git://xenbits.xen.org/osstest/ovmf.git#b4da6c29f1d36031e04212f53277ce0dcba309f1-2f286930a8280f4d817460020110009938f695b6 git://xenbits.xen.org/qemu-xen-traditional.git#3d273dd05e51e5a1ffba3d98c7437ee84e8f8764-3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 git://git.qemu.org/qemu.git#14f12119aa675e9e28207a48b0728a2daa5b88d6-4c127fdbe81d66e7cafed90908d0fd1f6f2a6cd0 git://xenbits.xen.org/osstest/seabios.git#64f37cc530f144e53c190c9e8209a51b58fd5c43-64f\
 37cc530f144e53c190c9e8209a51b58fd5c43 git://xenbits.xen.org/xen.git#192aaf7e146c0b41dbdd35ccdb13eb33ced13633-118da371d1ff5d8432fa299544b1ea5e7e3710f0
>From git://cache:9419/git://git.qemu.org/qemu
   eb8f1d57bd..2c64ff92ec  master     -> origin/master
   2c64ff92ec..660efed8b3  staging    -> origin/staging
Loaded 25020 nodes in revision graph
Searching for test results:
 165429 pass b4da6c29f1d36031e04212f53277ce0dcba309f1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 14f12119aa675e9e28207a48b0728a2daa5b88d6 64f37cc530f144e53c190c9e8209a51b58fd5c43 192aaf7e146c0b41dbdd35ccdb13eb33ced13633
 165442 [host=albana1]
 165468 [host=fiano1]
 165477 [host=huxelrebe0]
 165488 [host=albana1]
 165498 [host=huxelrebe0]
 165506 [host=fiano1]
 165514 [host=fiano1]
 165529 [host=albana1]
 165536 [host=huxelrebe0]
 165576 [host=albana1]
 165640 [host=huxelrebe0]
 165670 [host=albana0]
 165682 [host=huxelrebe0]
 165694 fail irrelevant
 165704 pass b4da6c29f1d36031e04212f53277ce0dcba309f1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 14f12119aa675e9e28207a48b0728a2daa5b88d6 64f37cc530f144e53c190c9e8209a51b58fd5c43 192aaf7e146c0b41dbdd35ccdb13eb33ced13633
 165705 fail irrelevant
 165706 pass 90246a6d9f6fda3536d042d02867123caabe3aaa 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 911965ace9386e35ca022a65bb45a32fd421af3e 64f37cc530f144e53c190c9e8209a51b58fd5c43 6809998c5f8f1d2e26ac9e867af8ac71e7a66cf2
 165707 pass 210869834639c1150b1f016e2022472a55cdd884 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 2792cf20ca7eed0e354a0ed731422411faca4908 64f37cc530f144e53c190c9e8209a51b58fd5c43 3ae80dea4601764818d1e5b84bd1e4479c0d4790
 165709 pass 210869834639c1150b1f016e2022472a55cdd884 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 5abfac277d25feb5f12332422c03ea1cb21c6aa1 64f37cc530f144e53c190c9e8209a51b58fd5c43 3ae80dea4601764818d1e5b84bd1e4479c0d4790
 165711 pass f10a112f08f3fb4a92c3d22f069f6066a12db3be 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 995b87dedc78b0467f5f18bbc3546072ba97516a 64f37cc530f144e53c190c9e8209a51b58fd5c43 52d0847d7c6972baa74156f14ee8544f5aba1d2d
 165713 pass f10a112f08f3fb4a92c3d22f069f6066a12db3be 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 bec4042baefc1bfeae05b161aa17d2f57d526b60 64f37cc530f144e53c190c9e8209a51b58fd5c43 52d0847d7c6972baa74156f14ee8544f5aba1d2d
 165703 fail 6893865b3010bb6192f732643c4b8ba026726d07 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 afc9fcde55296b83f659de9da3cdf044812a6eeb 64f37cc530f144e53c190c9e8209a51b58fd5c43 c12731493ae39640c4e44d9fe2029c3165f9f429
 165716 pass f10a112f08f3fb4a92c3d22f069f6066a12db3be 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 4d1a525dfafe995a98bb486e702da09e31b68b9c 64f37cc530f144e53c190c9e8209a51b58fd5c43 f791392f82ffe39cc1ea4c4db1d877223754a04a
 165717 pass 785cfd33053f506d4a1c17100356a63f24e98f45 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 3b4da13293482134b81d71be656ec76beff73a76 64f37cc530f144e53c190c9e8209a51b58fd5c43 b75838ad6c4f42c93efee83fc2508c78641e1b57
 165718 pass 6ed6abd6c116e8599876a2876b77e172e800b13e 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 946de558354c99e1989621abe053f2ab87dc8de9 64f37cc530f144e53c190c9e8209a51b58fd5c43 9e319e5258d0274c15da2ea9355dc1569a0fa832
 165720 pass 6ed6abd6c116e8599876a2876b77e172e800b13e 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 76e366e728549b3324cc2dee6745d6a4f1af18e6 64f37cc530f144e53c190c9e8209a51b58fd5c43 a0ffee6b145933f411b1c33daa2cdd54e77b2b15
 165722 fail 6893865b3010bb6192f732643c4b8ba026726d07 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 afc9fcde55296b83f659de9da3cdf044812a6eeb 64f37cc530f144e53c190c9e8209a51b58fd5c43 c12731493ae39640c4e44d9fe2029c3165f9f429
 165723 pass ba4ae92234b1985a89b3abed221d825b8d9ef9e2 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 8be1d4ed9838f807c63695753b30865f6edc4a5c 64f37cc530f144e53c190c9e8209a51b58fd5c43 f9294486926c865a3ef11cacd7cb6b26cce6f4a4
 165724 pass f10a112f08f3fb4a92c3d22f069f6066a12db3be 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 5dacda5167560b3af8eadbce5814f60ba44b467e 64f37cc530f144e53c190c9e8209a51b58fd5c43 be4eefbce6cada21b8a17354c1f11d7865d9a603
 165721 [host=fiano1]
 165725 pass ba4ae92234b1985a89b3abed221d825b8d9ef9e2 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 81d8537cb297d57b0897797f1329e4d755a0eaf4 64f37cc530f144e53c190c9e8209a51b58fd5c43 d3b05f9b16d6ba9c550c3a35ac11ed292bf87f68
 165733 [host=fiano1]
 165740 [host=fiano1]
 165726 fail 2f286930a8280f4d817460020110009938f695b6 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 4c127fdbe81d66e7cafed90908d0fd1f6f2a6cd0 64f37cc530f144e53c190c9e8209a51b58fd5c43 118da371d1ff5d8432fa299544b1ea5e7e3710f0
 165748 [host=fiano1]
 165752 pass b4da6c29f1d36031e04212f53277ce0dcba309f1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 14f12119aa675e9e28207a48b0728a2daa5b88d6 64f37cc530f144e53c190c9e8209a51b58fd5c43 192aaf7e146c0b41dbdd35ccdb13eb33ced13633
 165761 fail 2f286930a8280f4d817460020110009938f695b6 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 4c127fdbe81d66e7cafed90908d0fd1f6f2a6cd0 64f37cc530f144e53c190c9e8209a51b58fd5c43 118da371d1ff5d8432fa299544b1ea5e7e3710f0
 165765 pass 6ed6abd6c116e8599876a2876b77e172e800b13e 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 afe5c8c5c14aff25fab6ae83957e87c717415be3 64f37cc530f144e53c190c9e8209a51b58fd5c43 4cfab4425d39f76660b4e76ba6ee4cbf0f92e7e5
 165776 pass 90246a6d9f6fda3536d042d02867123caabe3aaa 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 362534a643b4a34bcb223996538ce9de5cdab946 64f37cc530f144e53c190c9e8209a51b58fd5c43 3ae80dea4601764818d1e5b84bd1e4479c0d4790
 165777 fail 37a33f02aa1ab89f392da7d06ec3578fda1b6182 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 19d20e910a586f503994acf590d5f41c314fa4c3 64f37cc530f144e53c190c9e8209a51b58fd5c43 6809998c5f8f1d2e26ac9e867af8ac71e7a66cf2
 165778 fail 37a33f02aa1ab89f392da7d06ec3578fda1b6182 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b59a898458aea328618521be7dc180d2396c0bf4 64f37cc530f144e53c190c9e8209a51b58fd5c43 6809998c5f8f1d2e26ac9e867af8ac71e7a66cf2
 165779 pass 90246a6d9f6fda3536d042d02867123caabe3aaa 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 362534a643b4a34bcb223996538ce9de5cdab946 64f37cc530f144e53c190c9e8209a51b58fd5c43 6809998c5f8f1d2e26ac9e867af8ac71e7a66cf2
 165781 pass 37a33f02aa1ab89f392da7d06ec3578fda1b6182 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 685db13a38f7599fabd353382ff65d3c244ea641 64f37cc530f144e53c190c9e8209a51b58fd5c43 6809998c5f8f1d2e26ac9e867af8ac71e7a66cf2
 165783 fail 37a33f02aa1ab89f392da7d06ec3578fda1b6182 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 c306cdb0cc5327f336fbf9a7411f319f0717ee75 64f37cc530f144e53c190c9e8209a51b58fd5c43 6809998c5f8f1d2e26ac9e867af8ac71e7a66cf2
 165784 fail 37a33f02aa1ab89f392da7d06ec3578fda1b6182 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 e741aff0f43343d6d91242fee1072fee376d5cce 64f37cc530f144e53c190c9e8209a51b58fd5c43 6809998c5f8f1d2e26ac9e867af8ac71e7a66cf2
 165785 pass 37a33f02aa1ab89f392da7d06ec3578fda1b6182 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 685db13a38f7599fabd353382ff65d3c244ea641 64f37cc530f144e53c190c9e8209a51b58fd5c43 6809998c5f8f1d2e26ac9e867af8ac71e7a66cf2
 165786 fail 37a33f02aa1ab89f392da7d06ec3578fda1b6182 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 e741aff0f43343d6d91242fee1072fee376d5cce 64f37cc530f144e53c190c9e8209a51b58fd5c43 6809998c5f8f1d2e26ac9e867af8ac71e7a66cf2
 165787 pass 37a33f02aa1ab89f392da7d06ec3578fda1b6182 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 685db13a38f7599fabd353382ff65d3c244ea641 64f37cc530f144e53c190c9e8209a51b58fd5c43 6809998c5f8f1d2e26ac9e867af8ac71e7a66cf2
 165788 fail 37a33f02aa1ab89f392da7d06ec3578fda1b6182 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 e741aff0f43343d6d91242fee1072fee376d5cce 64f37cc530f144e53c190c9e8209a51b58fd5c43 6809998c5f8f1d2e26ac9e867af8ac71e7a66cf2
Searching for interesting versions
 Result found: flight 165429 (pass), for basis pass
 Result found: flight 165726 (fail), for basis failure
 Repro found: flight 165752 (pass), for basis pass
 Repro found: flight 165761 (fail), for basis failure
 0 revisions at 37a33f02aa1ab89f392da7d06ec3578fda1b6182 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 685db13a38f7599fabd353382ff65d3c244ea641 64f37cc530f144e53c190c9e8209a51b58fd5c43 6809998c5f8f1d2e26ac9e867af8ac71e7a66cf2
No revisions left to test, checking graph state.
 Result found: flight 165781 (pass), for last pass
 Result found: flight 165784 (fail), for first failure
 Repro found: flight 165785 (pass), for last pass
 Repro found: flight 165786 (fail), for first failure
 Repro found: flight 165787 (pass), for last pass
 Repro found: flight 165788 (fail), for first failure

*** Found and reproduced problem changeset ***

  Bug is in tree:  qemuu git://git.qemu.org/qemu.git
  Bug introduced:  e741aff0f43343d6d91242fee1072fee376d5cce
  Bug not present: 685db13a38f7599fabd353382ff65d3c244ea641
  Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/165788/


  commit e741aff0f43343d6d91242fee1072fee376d5cce
  Author: Igor Mammedov <imammedo@redhat.com>
  Date:   Thu Sep 2 07:35:38 2021 -0400
  
      tests: qtest: add qtest_has_accel() to check if tested binary supports accelerator
      
      Currently it is not possible to create tests that have KVM as a hard
      requirement on a host that doesn't support KVM for tested target
      binary (modulo going through the trouble of compiling out
      the offending test case).
      
      Following scenario makes test fail when it's run on non x86 host:
        qemu-system-x86_64 -enable-kvm -M q35,kernel-irqchip=on -smp 1,maxcpus=288
      
      This patch introduces qtest_has_accel() to let users check if accel is
      available in advance and avoid executing non run-able test-cases.
      
      It implements detection of TCG and KVM only, the rest could be
      added later on, when we actually start testing them in qtest.
      
      Signed-off-by: Igor Mammedov <imammedo@redhat.com>
      Message-Id: <20210902113551.461632-3-imammedo@redhat.com>
      Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
      Signed-off-by: Michael S. Tsirkin <mst@redhat.com>

Revision graph left in /home/logs/results/bisect/qemu-mainline/build-i386.xen-build.{dot,ps,png,html,svg}.
----------------------------------------
165788: tolerable ALL FAIL

flight 165788 qemu-mainline real-bisect [real]
http://logs.test-lab.xenproject.org/osstest/logs/165788/

Failures :-/ but no regressions.

Tests which did not succeed,
including tests which could not be run:
 build-i386                    6 xen-build               fail baseline untested


jobs:
 build-i386                                                   fail    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary



From xen-devel-bounces@lists.xenproject.org Fri Oct 22 19:33:49 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Oct 2021 19:33:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.215241.374303 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1me0IO-0005J4-Sw; Fri, 22 Oct 2021 19:33:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 215241.374303; Fri, 22 Oct 2021 19:33:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1me0IO-0005Ix-Pz; Fri, 22 Oct 2021 19:33:40 +0000
Received: by outflank-mailman (input) for mailman id 215241;
 Fri, 22 Oct 2021 19:33:39 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1me0IN-0005In-Gy; Fri, 22 Oct 2021 19:33:39 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1me0IN-0003JE-8Q; Fri, 22 Oct 2021 19:33:39 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1me0IM-00004r-Vt; Fri, 22 Oct 2021 19:33:39 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1me0IM-0001lK-VR; Fri, 22 Oct 2021 19:33:38 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=/3b9ziZ07XrZS9vF8FHMjFWBZiZJQQcdrwi9i1Bzy+0=; b=mXW6+GSLzUGCtHitg3DGeE8Ot9
	VclT8ixZa5Gw8/e6o2atn0PQ7H+qe6BqOa0F0YagXeZ58feJRTe0Ne1Mko82E3anl9DMOe5SerPUN
	t4L9mNxL+aoWc26qo3TsEu4dWrrva009ow7dMlnpTlxaSY0kCBNj5ZZLwCxAW77BxGdE=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165753-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 165753: regressions - FAIL
X-Osstest-Failures:
    qemu-mainline:build-i386:xen-build:fail:regression
    qemu-mainline:build-i386-xsm:xen-build:fail:regression
    qemu-mainline:build-armhf:xen-build:fail:regression
    qemu-mainline:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-amd:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-pair:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-freebsd10-i386:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-freebsd10-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-coresched-i386-xl:build-check(1):blocked:nonblocking
    qemu-mainline:build-armhf-libvirt:build-check(1):blocked:nonblocking
    qemu-mainline:build-i386-libvirt:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-intel:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-shadow:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-vhd:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=4c127fdbe81d66e7cafed90908d0fd1f6f2a6cd0
X-Osstest-Versions-That:
    qemuu=50352cce138ef3b30c1cda28a4df68fff5da3202
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 22 Oct 2021 19:33:38 +0000

flight 165753 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165753/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-i386                    6 xen-build                fail REGR. vs. 165682
 build-i386-xsm                6 xen-build                fail REGR. vs. 165682
 build-armhf                   6 xen-build                fail REGR. vs. 165682

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl           1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-credit2   1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-cubietruck  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-multivcpu  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-rtds      1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-vhd       1 build-check(1)               blocked  n/a
 test-amd64-i386-qemuu-rhel6hvm-amd  1 build-check(1)               blocked n/a
 test-amd64-i386-pair          1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-freebsd10-i386  1 build-check(1)               blocked  n/a
 test-amd64-i386-freebsd10-amd64  1 build-check(1)               blocked  n/a
 test-amd64-coresched-i386-xl  1 build-check(1)               blocked  n/a
 build-armhf-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-arndale   1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-credit1   1 build-check(1)               blocked  n/a
 test-amd64-i386-qemuu-rhel6hvm-intel  1 build-check(1)             blocked n/a
 test-amd64-i386-xl            1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-pvshim     1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-qemuu-debianhvm-amd64  1 build-check(1)         blocked n/a
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow  1 build-check(1)  blocked n/a
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm  1 build-check(1)      blocked n/a
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 1 build-check(1) blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a
 test-amd64-i386-xl-qemuu-win7-amd64  1 build-check(1)              blocked n/a
 test-amd64-i386-xl-qemuu-ws16-amd64  1 build-check(1)              blocked n/a
 test-amd64-i386-xl-shadow     1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-vhd        1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-xsm        1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165682
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165682
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165682
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 qemuu                4c127fdbe81d66e7cafed90908d0fd1f6f2a6cd0
baseline version:
 qemuu                50352cce138ef3b30c1cda28a4df68fff5da3202

Last test of basis   165682  2021-10-19 21:09:14 Z    2 days
Failing since        165694  2021-10-20 18:09:12 Z    2 days    5 attempts
Testing same since   165726  2021-10-22 01:53:07 Z    0 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Jones <drjones@redhat.com>
  Ani Sinha <ani@anisinha.ca>
  BALATON Zoltan <balaton@eik.bme.hu>
  Cédric Le Goater <clg@kaod.org>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  David Gibson <david@gibson.dropbear.id.au>
  David Hildenbrand <david@redhat.com>
  Eric Auger <eric.auger@redhat.com>
  Eugenio Pérez <eperezma@redhat.com>
  Gavin Shan <gshan@redhat.com>
  Gustavo Romero <gromero@linux.ibm.com>
  Igor Mammedov <imammedo@redhat.com>
  Jason Wang <jasowang@redhat.com>
  Laurent Vivier <lvivier@redhat.com>
  Luc Michel <lmichel@kalray.eu>
  Matheus Ferst <matheus.ferst@eldorado.org.br>
  Mathieu Poirier <mathieu.poirier@linaro.org>
  Michael S. Tsirkin <mst@redhat.com>
  Philippe Mathieu-Daudé <f4bug@amsat.org>
  Philippe Mathieu-Daudé <philmd@redhat.com>
  Richard Henderson <richard.henderson@linaro.org>
  Shuuichirou Ishii <ishii.shuuichir@fujitsu.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Thomas Huth <thuth@redhat.com>
  Xueming Li <xuemingl@nvidia.com>
  Yanan Wang <wangyanan55@huawei.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               fail    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          blocked 
 test-amd64-i386-xl                                           blocked 
 test-amd64-coresched-i386-xl                                 blocked 
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  blocked 
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       blocked 
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           blocked 
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     blocked 
 test-amd64-i386-freebsd10-amd64                              blocked 
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          blocked 
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          blocked 
 test-armhf-armhf-xl-arndale                                  blocked 
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  blocked 
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  blocked 
 test-armhf-armhf-xl-cubietruck                               blocked 
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         blocked 
 test-amd64-i386-freebsd10-i386                               blocked 
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         blocked 
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                blocked 
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         blocked 
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 blocked 
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    blocked 
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     blocked 
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              blocked 
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    blocked 
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      blocked 
 test-amd64-i386-xl-vhd                                       blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 2492 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Oct 22 19:41:26 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Oct 2021 19:41:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.215250.374316 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1me0Pp-0006oh-Qf; Fri, 22 Oct 2021 19:41:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 215250.374316; Fri, 22 Oct 2021 19:41:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1me0Pp-0006oa-Na; Fri, 22 Oct 2021 19:41:21 +0000
Received: by outflank-mailman (input) for mailman id 215250;
 Fri, 22 Oct 2021 19:41:20 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=TWKL=PK=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1me0Po-0006oT-RL
 for xen-devel@lists.xenproject.org; Fri, 22 Oct 2021 19:41:20 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 0604c333-3370-11ec-83d2-12813bfff9fa;
 Fri, 22 Oct 2021 19:41:19 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id C66A460F6E;
 Fri, 22 Oct 2021 19:41:17 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0604c333-3370-11ec-83d2-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1634931678;
	bh=ibOiUdb0fOLio36KuXa5AA9Ov6RCtUbKkgdgjoKSHhQ=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=YIrdDpMl/Pi5XwGaJ2kaVVBUzcFInD8Kh7nTDEsvFWkBVCLHEE7CuqIt7ZcxNt2yO
	 UIczft32nq5Ks6McojcaHYrrY4+TQaOdEkTWRV3AV/MlxEdzT6uhkgh3BbznCRmlA6
	 Ie9GhZG0XkyB65xia8gkBRG5GVzogZTm3DFAWhyTo2UvyGJLIDe3i/TM0QxBwX6e7T
	 oG9HaiaYJU/w4ekOFy4W+O/dmPVXHKDDEVUvOCZa86SSkpSTsO7RKH4gfUIck04b2f
	 q7nyV6sHG773DRaQCXIrWpOe1f5OwZAcf6PkOkCrCLq4BSE7ivc0INxaqP/snuPud+
	 srLBm1jFq91pQ==
Date: Fri, 22 Oct 2021 12:41:16 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Andrew Cooper <andrew.cooper3@citrix.com>
cc: Stefano Stabellini <sstabellini@kernel.org>, 
    xen-devel@lists.xenproject.org, iwj@xenproject.org, cardoe@cardoe.com, 
    wl@xen.org, anthony.perard@citrix.com, 
    Stefano Stabellini <stefano.stabellini@xilinx.com>, jgross@suse.com
Subject: Re: [PATCH 2/3] automation: Linux 5.10.74 test-artifact
In-Reply-To: <19aa9196-eb5f-22a1-206c-c9c87ee79fa9@citrix.com>
Message-ID: <alpine.DEB.2.21.2110221219300.2311@sstabellini-ThinkPad-T480s>
References: <alpine.DEB.2.21.2110210831470.2311@sstabellini-ThinkPad-T480s> <20211021230839.10794-2-sstabellini@kernel.org> <19aa9196-eb5f-22a1-206c-c9c87ee79fa9@citrix.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: multipart/mixed; BOUNDARY="8323329-1865530201-1634930389=:2311"
Content-ID: <alpine.DEB.2.21.2110221237120.2311@sstabellini-ThinkPad-T480s>

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-1865530201-1634930389=:2311
Content-Type: text/plain; CHARSET=UTF-8
Content-Transfer-Encoding: 8BIT
Content-ID: <alpine.DEB.2.21.2110221237121.2311@sstabellini-ThinkPad-T480s>

+Juergen

On Fri, 22 Oct 2021, Andrew Cooper wrote:
> On 22/10/2021 00:08, Stefano Stabellini wrote:
> > +# build depends
> > +RUN apt-get update && \
> > +    apt-get --quiet --yes install \
> > +        build-essential \
> > +        libssl-dev \
> > +        bc \
> > +        curl \
> > +        flex \
> > +        bison \
> > +        libelf-dev \
> > +        && \
> > +    \
> > +    # Build the kernel
> > +    curl -fsSLO https://cdn.kernel.org/pub/linux/kernel/v5.x/linux-"$LINUX_VERSION".tar.xz && \
> > +    tar xvJf linux-"$LINUX_VERSION".tar.xz && \
> > +    cd linux-"$LINUX_VERSION" && \
> > +    make defconfig && \
> > +    make xen.config && \
> > +    cp .config .config.orig && \
> > +    cat .config.orig | grep XEN | grep =m |sed 's/=m/=y/g' >> .config && \
> > +    make -j$(nproc) bzImage && \
> 
> defconfig is huuuuge.  Can we use tinyconfig instead?
> 
> Also, you want to turn off CONFIG_MODULES seeing as you only copy
> bzImage to the test.
> 
> This also fixes the fact that `grep XEN` also matches CONFIG_NETXEN_NIC
> which has nothing to do with Xen.

Tinyconfig would be a good idea but it crashes on QEMU with the appended
boot log. I did:

# make tinyconfig
# make xen.config
# make bzImage

Of course we could have our own tailored special kernel config for this
kernel but I like the simplicify of "make tinyconfig" or "make
defconfig" followed by "make xen.config".

Unless you know one kconfig option or two that we need to add to
tinyconfig to make it work my preference is to go with defconfig for
now.



(XEN) Xen version 4.16-unstable (sstabellini@) (gcc (Ubuntu 7.5.0-3ubuntu1~18.04) 7.5.0) debug=y Tue Oct 19 19:29:09 PDT 2021
(XEN) Latest ChangeSet: Tue Oct 19 18:19:21 2021 -0700 git:9d0c6610bf-dirty
(XEN) build-id: 204da5ded1385bd7f645957893dba95d08ffc6e2
(XEN) Bootloader: iPXE 1.20.1+ (g4bd0)
(XEN) Command line: console=com1
(XEN) Xen image load base address: 0
(XEN) Video information:
(XEN)  VGA is text mode 80x25, font 8x16
(XEN)  VBE/DDC methods: V1 V2; EDID transfer time: 1 seconds
(XEN) Disc information:
(XEN)  Found 0 MBR signatures
(XEN)  Found 0 EDD information structures
(XEN) CPU Vendor: AMD, Family 15 (0xf), Model 107 (0x6b), Stepping 1 (raw 00060fb1)
(XEN) Xen-e820 RAM map:
(XEN)  [0000000000000000, 000000000009fbff] (usable)
(XEN)  [000000000009fc00, 000000000009ffff] (reserved)
(XEN)  [00000000000f0000, 00000000000fffff] (reserved)
(XEN)  [0000000000100000, 000000007ffdffff] (usable)
(XEN)  [000000007ffe0000, 000000007fffffff] (reserved)
(XEN)  [00000000fffc0000, 00000000ffffffff] (reserved)
(XEN) New Xen image base address: 0x7f800000
(XEN) System RAM: 2047MB (2096636kB)
(XEN) ACPI: RSDP 000F58D0, 0014 (r0 BOCHS )
(XEN) ACPI: RSDT 7FFE1960, 0034 (r1 BOCHS  BXPC            1 BXPC        1)
(XEN) ACPI: FACP 7FFE180C, 0074 (r1 BOCHS  BXPC            1 BXPC        1)
(XEN) ACPI: DSDT 7FFE0040, 17CC (r1 BOCHS  BXPC            1 BXPC        1)
(XEN) ACPI: FACS 7FFE0000, 0040
(XEN) ACPI: APIC 7FFE1880, 0080 (r1 BOCHS  BXPC            1 BXPC        1)
(XEN) ACPI: HPET 7FFE1900, 0038 (r1 BOCHS  BXPC            1 BXPC        1)
(XEN) ACPI: WAET 7FFE1938, 0028 (r1 BOCHS  BXPC            1 BXPC        1)
(XEN) No NUMA configuration found
(XEN) Faking a node at 0000000000000000-000000007ffe0000
(XEN) Domain heap initialised
(XEN) found SMP MP-table at 000f5ab0
(XEN) DMI 2.8 present.
(XEN) Using APIC driver default
(XEN) ACPI: PM-Timer IO Port: 0x608 (24 bits)
(XEN) ACPI: SLEEP INFO: pm1x_cnt[1:604,1:0], pm1x_evt[1:600,1:0]
(XEN) ACPI:             wakeup_vec[7ffe000c], vec_size[20]
(XEN) ACPI: Local APIC address 0xfee00000
(XEN) ACPI: IOAPIC (id[0x00] address[0xfec00000] gsi_base[0])
(XEN) IOAPIC[0]: apic_id 0, version 32, address 0xfec00000, GSI 0-23
(XEN) ACPI: INT_SRC_OVR (bus 0 bus_irq 0 global_irq 2 dfl dfl)
(XEN) ACPI: INT_SRC_OVR (bus 0 bus_irq 5 global_irq 5 high level)
(XEN) ACPI: INT_SRC_OVR (bus 0 bus_irq 9 global_irq 9 high level)
(XEN) ACPI: INT_SRC_OVR (bus 0 bus_irq 10 global_irq 10 high level)
(XEN) ACPI: INT_SRC_OVR (bus 0 bus_irq 11 global_irq 11 high level)
(XEN) ACPI: IRQ0 used by override.
(XEN) ACPI: IRQ2 used by override.
(XEN) ACPI: IRQ5 used by override.
(XEN) ACPI: IRQ9 used by override.
(XEN) ACPI: IRQ10 used by override.
(XEN) ACPI: IRQ11 used by override.
(XEN) Enabling APIC mode:  Flat.  Using 1 I/O APICs
(XEN) ACPI: HPET id: 0x8086a201 base: 0xfed00000
(XEN) Using ACPI (MADT) for SMP configuration information
(XEN) SMP: Allowing 2 CPUs (0 hotplug CPUs)
(XEN) IRQ limits: 24 GSI, 392 MSI/MSI-X
(XEN) Microcode loading not available
(XEN) No SSBD controls available
(XEN) CPU0: AMD K8 machine check reporting enabled
(XEN) Speculative mitigation facilities:
(XEN)   Hardware hints:
(XEN)   Hardware features:
(XEN)   Compiled-in support: INDIRECT_THUNK SHADOW_PAGING
(XEN)   Xen settings: BTI-Thunk LFENCE, SPEC_CTRL: No, Other: BRANCH_HARDEN
(XEN)   Support for HVM VMs: RSB
(XEN)   Support for PV VMs: RSB
(XEN)   XPTI (64-bit PV only): Dom0 disabled, DomU disabled (without PCID)
(XEN)   PV L1TF shadowing: Dom0 disabled, DomU disabled
(XEN) Using scheduler: SMP Credit Scheduler rev2 (credit2)
(XEN) Initializing Credit2 scheduler
(XEN)  load_precision_shift: 18
(XEN)  load_window_shift: 30
(XEN)  underload_balance_tolerance: 0
(XEN)  overload_balance_tolerance: -3
(XEN)  runqueues arrangement: socket
(XEN)  cap enforcement granularity: 10ms
(XEN) load tracking window length 1073741824 ns
(XEN) Platform timer is 100.000MHz HPET
(XEN) Detected 1993.167 MHz processor.
(XEN) Freed 1024kB unused BSS memory
(XEN) alt table ffff82d04048f570 -> ffff82d04049cf34
(XEN) I/O virtualisation disabled
(XEN) nr_sockets: 1
(XEN) ENABLING IO-APIC IRQs
(XEN)  -> Using new ACK method
(XEN) ..TIMER: vector=0xF0 apic1=0 pin1=2 apic2=-1 pin2=-1
(XEN) TSC only partially writable
(XEN) Allocated console ring of 16 KiB.
(XEN) mwait-idle: does not run on family 15 model 107
(XEN) HVM: ASIDs enabled.
(XEN) SVM: Supported advanced features:
(XEN)  - none
(XEN) HVM: SVM enabled
(XEN) HVM: Hardware Assisted Paging (HAP) not detected
(XEN) alt table ffff82d04048f570 -> ffff82d04049cf34
(XEN) Brought up 2 CPUs
(XEN) Scheduling granularity: cpu, 1 CPU per sched-resource
(XEN) Adding cpu 0 to runqueue 0
(XEN)  First cpu on runqueue, activating
(XEN) Adding cpu 1 to runqueue 0
(XEN) mcheck_poll: Machine check polling timer started.
(XEN) mtrr: your CPUs had inconsistent fixed MTRR settings
(XEN) mtrr: your CPUs had inconsistent variable MTRR settings
(XEN) mtrr: your CPUs had inconsistent MTRRdefType settings
(XEN) mtrr: probably your BIOS does not setup all CPUs.
(XEN) mtrr: corrected configuration.
(XEN) MTRR default type: write-back
(XEN) MTRR fixed ranges enabled:
(XEN)   00000-9ffff write-back
(XEN)   a0000-bffff uncachable
(XEN)   c0000-fffff write-protect
(XEN) MTRR variable ranges enabled:
(XEN)   0 base 0080000000 mask ff80000000 uncachable
(XEN)   1 disabled
(XEN)   2 disabled
(XEN)   3 disabled
(XEN)   4 disabled
(XEN)   5 disabled
(XEN)   6 disabled
(XEN)   7 disabled
(XEN) Running stub recovery selftests...
(XEN) Fixup #UD[0000]: ffff82d07fffe040 [ffff82d07fffe040] -> ffff82d04038e83a
(XEN) Selftest 1 failed: Opc 90 02 00 c3 expected 13[0000], got 14[0001]
(XEN) Selftest 2 failed: Opc 02 04 04 c3 expected 12[0000], got 14[0001]
(XEN) Fixup #BP[0000]: ffff82d07fffe041 [ffff82d07fffe041] -> ffff82d04038e83a
(XEN) NX (Execute Disable) protection active
(XEN) Dom0 has maximum 416 PIRQs
(XEN) *** Building a PV Dom0 ***
(XEN) ELF: phdr: paddr=0x1000000 memsz=0x8532f0
(XEN) ELF: phdr: paddr=0x1a00000 memsz=0x75000
(XEN) ELF: phdr: paddr=0x1a75000 memsz=0x1a1000
(XEN) ELF: memory: 0x1000000 -> 0x1c16000
(XEN) ELF: note: GUEST_OS = "linux"
(XEN) ELF: note: GUEST_VERSION = "2.6"
(XEN) ELF: note: XEN_VERSION = "xen-3.0"
(XEN) ELF: note: VIRT_BASE = 0xffffffff80000000
(XEN) ELF: note: INIT_P2M = 0x8000000000
(XEN) ELF: note: ENTRY = 0xffffffff81a75160
(XEN) ELF: note: HYPERCALL_PAGE = 0xffffffff81001000
(XEN) ELF: note: FEATURES = "!writable_page_tables|pae_pgdir_above_4gb"
(XEN) ELF: note: SUPPORTED_FEATURES = 0x8801
(XEN) ELF: note: PAE_MODE = "yes"
(XEN) ELF: note: LOADER = "generic"
(XEN) ELF: note: unknown (0xd)
(XEN) ELF: note: SUSPEND_CANCEL = 0x1
(XEN) ELF: note: MOD_START_PFN = 0x1
(XEN) ELF: note: HV_START_LOW = 0xffff800000000000
(XEN) ELF: note: PADDR_OFFSET = 0
(XEN) ELF: addresses:
(XEN)     virt_base        = 0xffffffff80000000
(XEN)     elf_paddr_offset = 0x0
(XEN)     virt_offset      = 0xffffffff80000000
(XEN)     virt_kstart      = 0xffffffff81000000
(XEN)     virt_kend        = 0xffffffff81c16000
(XEN)     virt_entry       = 0xffffffff81a75160
(XEN)     p2m_base         = 0x8000000000
(XEN)  Xen  kernel: 64-bit, lsb
(XEN)  Dom0 kernel: 64-bit, PAE, lsb, paddr 0x1000000 -> 0x1c16000
(XEN) PHYSICAL MEMORY ARRANGEMENT:
(XEN)  Dom0 alloc.:   000000007a000000->000000007c000000 (476919 pages to be allocated)
(XEN)  Init. ramdisk: 000000007f806000->000000007f9ffe77
(XEN) VIRTUAL MEMORY ARRANGEMENT:
(XEN)  Loaded kernel: ffffffff81000000->ffffffff81c16000
(XEN)  Phys-Mach map: 0000008000000000->00000080003b4788
(XEN)  Start info:    ffffffff81c16000->ffffffff81c164b8
(XEN)  Page tables:   ffffffff81c17000->ffffffff81c2a000
(XEN)  Boot stack:    ffffffff81c2a000->ffffffff81c2b000
(XEN)  TOTAL:         ffffffff80000000->ffffffff82000000
(XEN)  ENTRY ADDRESS: ffffffff81a75160
(XEN) Dom0 has maximum 2 VCPUs
(XEN) ELF: phdr 0 at 0xffffffff81000000 -> 0xffffffff818532f0
(XEN) ELF: phdr 1 at 0xffffffff81a00000 -> 0xffffffff81a75000
(XEN) ELF: phdr 2 at 0xffffffff81a75000 -> 0xffffffff81afcc4d
(XEN) Initial low memory virq threshold set at 0x4000 pages.
(XEN) Scrubbing Free RAM in background
(XEN) Std. Loglevel: All
(XEN) Guest Loglevel: All
(XEN) ***************************************************
(XEN) SELFTEST FAILURE: CORRECT BEHAVIOR CANNOT BE GUARANTEED
(XEN) ***************************************************
(XEN) 3... 2... 1... 
(XEN) *** Serial input to DOM0 (type 'CTRL-a' three times to switch input)
(XEN) Freed 592kB init memory
mapping kernel into physical memory
about to get started...
(XEN) emul-priv-op.c:1018:d0v0 RDMSR 0xc0010055 unimplemented
(XEN) Hardware Dom0 crashed: rebooting machine in 5 seconds.
qemu-system-x86_64: terminating on signal 2
--8323329-1865530201-1634930389=:2311--


From xen-devel-bounces@lists.xenproject.org Fri Oct 22 20:02:11 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Oct 2021 20:02:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.215257.374328 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1me0jq-0000lT-Hj; Fri, 22 Oct 2021 20:02:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 215257.374328; Fri, 22 Oct 2021 20:02:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1me0jq-0000lM-E5; Fri, 22 Oct 2021 20:02:02 +0000
Received: by outflank-mailman (input) for mailman id 215257;
 Fri, 22 Oct 2021 20:02:01 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=TWKL=PK=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1me0jp-0000lG-82
 for xen-devel@lists.xenproject.org; Fri, 22 Oct 2021 20:02:01 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 6be267c7-0935-4287-a7e3-f2a6ea70972f;
 Fri, 22 Oct 2021 20:02:00 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id 784C96112D;
 Fri, 22 Oct 2021 20:01:59 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6be267c7-0935-4287-a7e3-f2a6ea70972f
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1634932919;
	bh=/DYhirGSBd7GP55ry0LSeuAqlCQpRXPr0Mj/FbFg1jM=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=DUzoJnmCfMvIXzJCvw6PDwadqZExT2lqRE/hnoZYnbYcMjzzGdFml5Vj07y5T5KR5
	 73TS2P+iQU3tFTHULexEZGD4iG3WkzTqiCfTUfjZ5zxl0kCRaTaUMGzTPtFGxcDbfD
	 3xtj1NulWXdtlEX1B043OWD8RfJ0rw96AZcOtA+7a+cbTmmhCOsc+5sP+yG0TW2wep
	 CcnCcXG0LWQS75JUgViMNmfQD5zoVqfYLoSZxRh37GTvR6j3WUINvRjL7wPIRdvUAV
	 Ecv6R1J0ZK29VroVVonTW4X5DjunswQ2KxeTDMRFswA2W3MHtElx3Jd4sacre0GqmJ
	 hG0kHrM51/UwQ==
Date: Fri, 22 Oct 2021 13:01:58 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Andrew Cooper <andrew.cooper3@citrix.com>
cc: Stefano Stabellini <sstabellini@kernel.org>, 
    xen-devel@lists.xenproject.org, iwj@xenproject.org, cardoe@cardoe.com, 
    wl@xen.org, anthony.perard@citrix.com, 
    Stefano Stabellini <stefano.stabellini@xilinx.com>
Subject: Re: [PATCH 1/3] automation: add x86_64 alpine 3.12 test-artifact
In-Reply-To: <41a3622e-395f-096c-da7b-db3aa58c004d@citrix.com>
Message-ID: <alpine.DEB.2.21.2110221218340.2311@sstabellini-ThinkPad-T480s>
References: <alpine.DEB.2.21.2110210831470.2311@sstabellini-ThinkPad-T480s> <20211021230839.10794-1-sstabellini@kernel.org> <41a3622e-395f-096c-da7b-db3aa58c004d@citrix.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: multipart/mixed; BOUNDARY="8323329-1256529251-1634930322=:2311"
Content-ID: <alpine.DEB.2.21.2110221301140.2311@sstabellini-ThinkPad-T480s>

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-1256529251-1634930322=:2311
Content-Type: text/plain; CHARSET=UTF-8
Content-Transfer-Encoding: 8BIT
Content-ID: <alpine.DEB.2.21.2110221301141.2311@sstabellini-ThinkPad-T480s>

On Fri, 22 Oct 2021, Andrew Cooper wrote:
> On 22/10/2021 00:08, Stefano Stabellini wrote:
> > +RUN \
> > +  # apk
> > +  apk update && \
> > +  \
> > +  # xen runtime deps
> > +  apk add musl && \
> > +  apk add openrc && \
> > +  apk add busybox && \
> > +  apk add sudo && \
> > +  apk add dbus && \
> > +  apk add bash && \
> > +  apk add python2 && \
> > +  # gettext for Xen < 4.13
> > +  apk add gettext && \
> 
> Unless we're planning on backporting this to staging-4.13, we can drop
> gettext.  (That's the whole point of the comments highlighting version)

Good point, I'll make the change
--8323329-1256529251-1634930322=:2311--


From xen-devel-bounces@lists.xenproject.org Fri Oct 22 20:02:14 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Oct 2021 20:02:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.215258.374339 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1me0k2-00015A-QB; Fri, 22 Oct 2021 20:02:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 215258.374339; Fri, 22 Oct 2021 20:02:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1me0k2-000153-MI; Fri, 22 Oct 2021 20:02:14 +0000
Received: by outflank-mailman (input) for mailman id 215258;
 Fri, 22 Oct 2021 20:02:13 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=TWKL=PK=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1me0k1-00014Q-M4
 for xen-devel@lists.xenproject.org; Fri, 22 Oct 2021 20:02:13 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 108c70a5-2baa-48fc-8ec7-8fd2fcfd6c2a;
 Fri, 22 Oct 2021 20:02:12 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id 2713E60FE7;
 Fri, 22 Oct 2021 20:02:12 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 108c70a5-2baa-48fc-8ec7-8fd2fcfd6c2a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1634932932;
	bh=mXZyIPTbpRa8UpDESV+24yb8tsC39xOyc6Fd/9GCVQM=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=GUSBqhP1lYcKut1fHXRdJ69dI5qEIM6zPw6vDIPEW5vHaIJmcCoEv3rjKtRuy1sRm
	 drp+vM1lsWIeG9DkHu3lp+//oKR1A0KWkoswt809ld+TF63UwD9PakwJxJCNtrAEmb
	 V++tJ6tSmz0g73fya1/gZ+KY5paLI5eoGObfxSuqXPoQvHkUTs24DBMESINpEsXmbJ
	 pHVKlhKO9Y7ZwknKKOfcqQduruVcD4qI77CWv+XzWgdnS+ZGMqSm5dZGq6HP1MrZGL
	 HIrLT4RGcX6yZ47Jb31QQz97AlMmfJ+NDHobHl2m41RtzxqO3jUEjJPTRm/yAuf0Av
	 ix2v4SaQjzpzA==
Date: Fri, 22 Oct 2021 13:02:10 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Anthony PERARD <anthony.perard@citrix.com>
cc: Stefano Stabellini <sstabellini@kernel.org>, 
    xen-devel@lists.xenproject.org, iwj@xenproject.org, cardoe@cardoe.com, 
    wl@xen.org, andrew.cooper3@citrix.com, 
    Stefano Stabellini <stefano.stabellini@xilinx.com>
Subject: Re: [PATCH 2/3] automation: Linux 5.10.74 test-artifact
In-Reply-To: <YXKw0jfDkJ5RrvXX@perard>
Message-ID: <alpine.DEB.2.21.2110221218470.2311@sstabellini-ThinkPad-T480s>
References: <alpine.DEB.2.21.2110210831470.2311@sstabellini-ThinkPad-T480s> <20211021230839.10794-2-sstabellini@kernel.org> <YXKw0jfDkJ5RrvXX@perard>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Fri, 22 Oct 2021, Anthony PERARD wrote:
> On Thu, Oct 21, 2021 at 04:08:38PM -0700, Stefano Stabellini wrote:
> > diff --git a/automation/tests-artifacts/kernel/5.10.74.dockerfile b/automation/tests-artifacts/kernel/5.10.74.dockerfile
> > new file mode 100644
> > index 0000000000..f2dbbecf74
> > --- /dev/null
> > +++ b/automation/tests-artifacts/kernel/5.10.74.dockerfile
> > @@ -0,0 +1,38 @@
> > +FROM debian:unstable
> > +LABEL maintainer.name="The Xen Project" \
> > +      maintainer.email="xen-devel@lists.xenproject.org"
> > +
> > +ENV DEBIAN_FRONTEND=noninteractive
> > +ENV LINUX_VERSION=5.10.74
> > +ENV USER root
> > +
> > +RUN mkdir /build
> > +WORKDIR /build
> > +
> > +# build depends
> > +RUN apt-get update && \
> > +    apt-get --quiet --yes install \
> > +        build-essential \
> > +        libssl-dev \
> > +        bc \
> > +        curl \
> > +        flex \
> > +        bison \
> > +        libelf-dev \
> > +        && \
> > +    \
> > +    # Build the kernel
> 
> You could start a new docker "RUN" step to build the kernel.

OK


> > +    curl -fsSLO https://cdn.kernel.org/pub/linux/kernel/v5.x/linux-"$LINUX_VERSION".tar.xz && \
> > +    tar xvJf linux-"$LINUX_VERSION".tar.xz && \
> > +    cd linux-"$LINUX_VERSION" && \
> > +    make defconfig && \
> > +    make xen.config && \
> > +    cp .config .config.orig && \
> > +    cat .config.orig | grep XEN | grep =m |sed 's/=m/=y/g' >> .config && \
> 
> This command line could be replaced by:
>     sed -i '/XEN/s/=m$/=y/' .config
> But I guess Kconfig don't mind duplicated symbols.

Yeah the latter overwrites the former


> > +    make -j$(nproc) bzImage && \
> > +    cp arch/x86/boot/bzImage / && \
> > +    cd /build && \
> > +    rm -rf linux-"$LINUX_VERSION"* && \
> 
> 
> > +    apt-get autoremove -y && \
> > +    apt-get clean && \
> > +    rm -rf /var/lib/apt/lists* /tmp/* /var/tmp/*
> 
> This apt cleaning stuff should be done right after `apt install`, and
> thus before starting to build the kernel, I think.

OK

> Any any case:
> Reviewed-by: Anthony PERARD <anthony.perard@citrix.com>

Thanks Anthony!


From xen-devel-bounces@lists.xenproject.org Fri Oct 22 20:05:41 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Oct 2021 20:05:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.215268.374350 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1me0nM-00020A-8Y; Fri, 22 Oct 2021 20:05:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 215268.374350; Fri, 22 Oct 2021 20:05:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1me0nM-000203-5d; Fri, 22 Oct 2021 20:05:40 +0000
Received: by outflank-mailman (input) for mailman id 215268;
 Fri, 22 Oct 2021 20:05:39 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=TWKL=PK=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1me0nL-0001zx-1j
 for xen-devel@lists.xenproject.org; Fri, 22 Oct 2021 20:05:39 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 36f9dc27-aaf4-43c9-afaf-43505ab11751;
 Fri, 22 Oct 2021 20:05:37 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id 06C2560FC3;
 Fri, 22 Oct 2021 20:05:36 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 36f9dc27-aaf4-43c9-afaf-43505ab11751
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1634933137;
	bh=0ed5ashgq+RseZh1jCmDafDm8/pPUbEikonwZ4eyYa0=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=AXdsShtmhvmcmsfi2njMm3YNnvcY6FrQKL+hensDdVJdPL76C43eXteXWhIzqFjUe
	 48stFAK68dqMuPGWjFh9VzQoC/NQ8mNEgPUFx0CS5eSjFAwUXkgD3/CkDqewpzXHzL
	 yQolq7fU2DE/NifMi2GYJkxfupwF2PP7GhWn5tCrXcFCI4ia70Zcoj2fxgX1kQC9CY
	 f5NzOcmnaAJZlP3YrfANyVj3QbLT4cnxL96O/wiU0LhKiRjs6BBCDVUElh49AyuS71
	 z4QKJ0tax+r9PfmBpqm3ANoDgvltX1MwTHKEfaPK7sDN82/2QY0efojrCT2a9SUZkv
	 IxJlFwkPrLzdw==
Date: Fri, 22 Oct 2021 13:05:35 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Anthony PERARD <anthony.perard@citrix.com>
cc: Stefano Stabellini <sstabellini@kernel.org>, 
    xen-devel@lists.xenproject.org, iwj@xenproject.org, cardoe@cardoe.com, 
    wl@xen.org, andrew.cooper3@citrix.com, 
    Stefano Stabellini <stefano.stabellini@xilinx.com>
Subject: Re: [PATCH 3/3] automation: add a QEMU based x86_64 Dom0/DomU test
In-Reply-To: <YXK2lTWZHiTXIBtJ@perard>
Message-ID: <alpine.DEB.2.21.2110221219520.2311@sstabellini-ThinkPad-T480s>
References: <alpine.DEB.2.21.2110210831470.2311@sstabellini-ThinkPad-T480s> <20211021230839.10794-3-sstabellini@kernel.org> <YXK2lTWZHiTXIBtJ@perard>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Fri, 22 Oct 2021, Anthony PERARD wrote:
> On Thu, Oct 21, 2021 at 04:08:39PM -0700, Stefano Stabellini wrote:
> > diff --git a/automation/scripts/qemu-alpine-x86_64.sh b/automation/scripts/qemu-alpine-x86_64.sh
> > new file mode 100644
> > index 0000000000..41b05210d6
> > --- /dev/null
> > +++ b/automation/scripts/qemu-alpine-x86_64.sh
> > @@ -0,0 +1,92 @@
> > +#!/bin/bash
> > +
> > +set -ex
> > +
> > +apt-get -qy update
> > +apt-get -qy install --no-install-recommends qemu-system-x86 \
> > +                                            cpio \
> > +                                            curl \
> > +                                            busybox-static
> 
> Please, don't install packages during the CI job. If you need new
> packages, update the container.

The container used to run this script is the one used for the Xen build:
automation/build/debian/unstable.dockerfile, AKA
registry.gitlab.com/xen-project/xen/debian:unstable. We don't have a
specific container for the sole purpose of running tests.

Thus, I could add qemu-system-x86 to
automation/build/debian/unstable.dockerfile, but then we increase the
size of the debian unstable build container needlessly for all related
build jobs.

Or we could add one more special container just for running tests, but
then it is one more container to maintain and keep up-to-date.

This is why I chose as a compromise to keep the underlying container as
is, and just apt-get the extra 3-4 packages here. It is the same thing
we do on ARM: automation/scripts/qemu-alpine-arm64.sh. Also keep in mind
that this job is run in the "test" step where we have far fewer jobs at
the moment and the runners are not busy. (It would be different in the
"build" step where we have many jobs.)

I am not entirely sure what is the best solution overall, but for this
series at this stage I would prefer to keep the same strategy used for
the ARM tests (i.e. reuse the debian unstable build container and
apt-get the few missing packages.) If we do change the way we do it, I
would rather change both x86 and ARM at the same time.


> That said, "curl" doesn't seems to be needed.

Yeah I'll take away curl.


> > +# DomU Busybox
> > +cd binaries
> > +mkdir -p initrd
> > +mkdir -p initrd/bin
> > +mkdir -p initrd/sbin
> > +mkdir -p initrd/etc
> > +mkdir -p initrd/dev
> > +mkdir -p initrd/proc
> > +mkdir -p initrd/sys
> > +mkdir -p initrd/lib
> > +mkdir -p initrd/var
> > +mkdir -p initrd/mnt
> > +cp /bin/busybox initrd/bin/busybox
> > +initrd/bin/busybox --install initrd/bin
> > +echo "#!/bin/sh
> > +
> > +mount -t proc proc /proc
> > +mount -t sysfs sysfs /sys
> > +mount -t devtmpfs devtmpfs /dev
> > +/bin/sh" > initrd/init
> > +chmod +x initrd/init
> > +cd initrd
> > +find . | cpio --create --format='newc' | gzip > ../initrd.cpio.gz
> 
> This isn't confusing at all, depending on the tool used to make an
> archive, the resulting initrd has a different purpose :-).
>     initrd.tar.gz -> dom0
>     initrd.cpio.gz -> domU
> 
> > +cd ..
> 
> Maybe add a comment here saying that we are now preparing dom0 root
> filesystem? (as there is one for domu)

Sure I can add a comment


> > +mkdir -p rootfs
> > +cd rootfs
> > +tar xvzf ../initrd.tar.gz
> > +mkdir proc
> > +mkdir run
> > +mkdir srv
> > +mkdir sys
> > +rm var/run
> > +cp -ar ../dist/install/* .
> > +mv ../initrd.cpio.gz ./root
> > +cp ../bzImage ./root
> > +echo "name=\"test\"
> > +memory=512
> > +vcpus=1
> > +kernel=\"/root/bzImage\"
> > +ramdisk=\"/root/initrd.cpio.gz\"
> > +extra=\"console=hvc0 root=/dev/ram0 rdinit=/bin/sh\"
> > +" > root/test.cfg
> > +echo "#!/bin/bash
> > +
> 
> Maybe add `set -x` ?

OK


> > +export LD_LIBRARY_PATH=/usr/local/lib
> > +bash /etc/init.d/xencommons start
> > +
> > +xl list
> > +
> > +xl create -c /root/test.cfg
> > +
> > +" > etc/local.d/xen.start
> > +chmod +x etc/local.d/xen.start
> > +echo "rc_verbose=yes" >> etc/rc.conf
> > +find . |cpio -H newc -o|gzip > ../xen-rootfs.cpio.gz
> > +cd ../..
> > +
> > +cat >> binaries/pxelinux.0 <<- EOF
> 
> So, I've look at <<- meaning as I never used that before and it seems to
> remove all leading tab chr from the input, yet they are no tab in the
> input. So maybe use just <<EOF instead, without the dash -.

OK


> > +#!ipxe
> > +
> > +kernel xen console=com1
> > +module bzImage console=hvc0
> > +module xen-rootfs.cpio.gz
> > +boot
> > +EOF



From xen-devel-bounces@lists.xenproject.org Fri Oct 22 21:55:37 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Oct 2021 21:55:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.215282.374370 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1me2VZ-0003Yg-FE; Fri, 22 Oct 2021 21:55:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 215282.374370; Fri, 22 Oct 2021 21:55:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1me2VZ-0003YZ-C6; Fri, 22 Oct 2021 21:55:25 +0000
Received: by outflank-mailman (input) for mailman id 215282;
 Fri, 22 Oct 2021 21:55:23 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=TWKL=PK=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1me2VX-0003YT-NY
 for xen-devel@lists.xenproject.org; Fri, 22 Oct 2021 21:55:23 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id c14528dc-3382-11ec-83d8-12813bfff9fa;
 Fri, 22 Oct 2021 21:55:22 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id B1B316103E;
 Fri, 22 Oct 2021 21:55:21 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c14528dc-3382-11ec-83d8-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1634939721;
	bh=n+vbdMEFuwTpXUFzHCAvXJPchdixINluQl+quHVNYes=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=til73Gxe6FhbRABVm+GL6Bzr8Wuhr9BXYx0erqbsho7TqHrRdqUV34SGS1gjTX4kx
	 8lBV3QBnAkKvDSfg+RgLcRdg8vZONe9ddBDhvsIklYoLZx6WBtGWggHfCKMqIfDvbN
	 Rqkh+qWFwuaWiQGazlKdyLMXPSovYPeEdMir/knH1M3jvLki/HrKf0E/knMc8c5Cdn
	 BoDDz8b8xLT8xy8VkbTuBtKlD4r33gksbAaH7Ma0qPi4FMGaq9lccDPjUMR9plmt0X
	 G5X41z/14FgdvALUnZ7Hjw3SDJr+16OSsKY5FVR22o7WcgXwnwLf1SaXXxehOOsZHw
	 NcHq256N8EDsg==
Date: Fri, 22 Oct 2021 14:55:21 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Stefano Stabellini <sstabellini@kernel.org>
cc: Anthony PERARD <anthony.perard@citrix.com>, xen-devel@lists.xenproject.org, 
    wl@xen.org, iwj@xenproject.org, andrew.cooper3@citrix.com, 
    Doug Goldstein <cardoe@cardoe.com>
Subject: Re: [XEN PATCH] automation: actually build with clang for
 ubuntu-focal-clang* jobs
In-Reply-To: <alpine.DEB.2.21.2110220957220.2311@sstabellini-ThinkPad-T480s>
Message-ID: <alpine.DEB.2.21.2110221454060.2311@sstabellini-ThinkPad-T480s>
References: <20211022163644.547018-1-anthony.perard@citrix.com> <alpine.DEB.2.21.2110220957220.2311@sstabellini-ThinkPad-T480s>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Fri, 22 Oct 2021, Stefano Stabellini wrote:
> On Fri, 22 Oct 2021, Anthony PERARD wrote:
> > Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
> 
> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>

FYI I verified that the patch doesn't break gitlab-ci so as far as I am
concerned this patch can be committed any time. (I didn't commit it
myself to give more time in case someone might want to provide
additional feedback or voice any concern.)


From xen-devel-bounces@lists.xenproject.org Fri Oct 22 23:00:10 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Oct 2021 23:00:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.215294.374393 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1me3Vz-0000zH-FQ; Fri, 22 Oct 2021 22:59:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 215294.374393; Fri, 22 Oct 2021 22:59:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1me3Vz-0000zA-CR; Fri, 22 Oct 2021 22:59:55 +0000
Received: by outflank-mailman (input) for mailman id 215294;
 Fri, 22 Oct 2021 22:59:54 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=TWKL=PK=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1me3Vy-0000z4-CD
 for xen-devel@lists.xenproject.org; Fri, 22 Oct 2021 22:59:54 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id fcb1be96-5700-48b0-8fc3-537a7f2ab193;
 Fri, 22 Oct 2021 22:59:53 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id 3E51E61037;
 Fri, 22 Oct 2021 22:59:52 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fcb1be96-5700-48b0-8fc3-537a7f2ab193
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1634943592;
	bh=TNjbdCc180Gtrpx+1RGx2wC6AGhZ1voPpE1f+PBPZls=;
	h=Date:From:To:cc:Subject:From;
	b=iJaS5MmvLqJuIZFDDfFF65yfxA9s138fpyIunjK9uJ2FMWwBHAd1TQi70IEi6s2so
	 cqU/Y9XZTPiBFYZ/Bm+KkjFvMDYDrefhgq1ncGKR1FahILgARTSwCmbcTPS6cX1xhO
	 VAiPexqGyTP8e4DXtFM1ssBB0zvRJXE8AzADYCMmowauwz2zCGA7bDFRivBoCMxRlk
	 UODdwnauuieonE6XKHDBwGg2G3LbH6pxGBXI4emo3z4+0i/OcqTke15LL6JMhXKJT/
	 XytmFMVLSvYAh0wL4GtOKZK4CJze7j4+Kg6OxjY0gdU1iMCxkjQEKQXgjfKly0gshE
	 1g5rT+MM7nXIg==
Date: Fri, 22 Oct 2021 15:59:51 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: George.Dunlap@citrix.com
cc: sstabellini@kernel.org, dunlapg@umich.edu, roger.pau@citrix.com, 
    jbeulich@suse.com, committers@xenproject.org, 
    xen-devel@lists.xenproject.org
Subject: [PATCH] governance: communication channels
Message-ID: <alpine.DEB.2.21.2110221535000.2311@sstabellini-ThinkPad-T480s>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="8323329-1151137835-1634943592=:2311"

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-1151137835-1634943592=:2311
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT

Clarify that xen-devel is the only official communication channel.

Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>

diff --git a/source/communication-practice.rst b/source/communication-practice.rst
index 70f5b8c..356df7a 100644
--- a/source/communication-practice.rst
+++ b/source/communication-practice.rst
@@ -9,6 +9,22 @@ This guide provides communication Best Practice that helps you in
 * Being aware of your own and counterpart’s communication style and culture
 * Show empathy towards other community members
 
+Communication Channels
+======================
+
+All important communications and messages should be sent to the
+`xen-devel <10_>`_ mailing list, which is the only official channel for
+code submissions, acks, code reviews, and decision-making.
+
+In the modern connected world there are several other communication
+channels available at any given time, including online meetings and IRC.
+Xen Project has an IRC channel named #xendevel on the OFTC network where
+some of the regular contributors and maintainers can be found. However,
+discussions on media other than the xen-devel mailing list should be
+summarized and sent to xen-devel to reach a wider audience, for
+record-keeping, and to make code submissions, acks, and code reviews
+official.
+
 Code reviews for **reviewers** and **patch authors**
 ====================================================
 
@@ -576,3 +592,4 @@ how to avoid and resolve issues.
 .. _6: https://xenproject.org/help/irc/
 .. _8: https://en.wikipedia.org/wiki/Erin_Meyer
 .. _9: https://www.nsf.gov/attachments/134059/public/15LFW_WorkingWithMulticulturalTeams_LarsonC.pdf
+.. _10: https://lists.xenproject.org/mailman/listinfo/xen-devel
--8323329-1151137835-1634943592=:2311--


From xen-devel-bounces@lists.xenproject.org Fri Oct 22 23:33:43 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 22 Oct 2021 23:33:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.215301.374403 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1me42Z-0004un-3k; Fri, 22 Oct 2021 23:33:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 215301.374403; Fri, 22 Oct 2021 23:33:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1me42Z-0004ug-0p; Fri, 22 Oct 2021 23:33:35 +0000
Received: by outflank-mailman (input) for mailman id 215301;
 Fri, 22 Oct 2021 23:33:33 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ef1d=PK=oracle.com=dongli.zhang@srs-us1.protection.inumbo.net>)
 id 1me42X-0004ua-Cn
 for xen-devel@lists.xenproject.org; Fri, 22 Oct 2021 23:33:33 +0000
Received: from mx0b-00069f02.pphosted.com (unknown [205.220.177.32])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 77cc0758-3390-11ec-83da-12813bfff9fa;
 Fri, 22 Oct 2021 23:33:32 +0000 (UTC)
Received: from pps.filterd (m0246631.ppops.net [127.0.0.1])
 by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 19MNSYs3021619; 
 Fri, 22 Oct 2021 23:33:29 GMT
Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79])
 by mx0b-00069f02.pphosted.com with ESMTP id 3buta8bw02-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Fri, 22 Oct 2021 23:33:29 +0000
Received: from pps.filterd (userp3020.oracle.com [127.0.0.1])
 by userp3020.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 19MNFhJX151851;
 Fri, 22 Oct 2021 23:33:28 GMT
Received: from nam12-dm6-obe.outbound.protection.outlook.com
 (mail-dm6nam12lp2177.outbound.protection.outlook.com [104.47.59.177])
 by userp3020.oracle.com with ESMTP id 3br8gyp8bq-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Fri, 22 Oct 2021 23:33:27 +0000
Received: from BYAPR10MB2663.namprd10.prod.outlook.com (2603:10b6:a02:a9::20)
 by BYAPR10MB3158.namprd10.prod.outlook.com (2603:10b6:a03:15d::23)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.18; Fri, 22 Oct
 2021 23:33:25 +0000
Received: from BYAPR10MB2663.namprd10.prod.outlook.com
 ([fe80::2848:63dc:b87:8021]) by BYAPR10MB2663.namprd10.prod.outlook.com
 ([fe80::2848:63dc:b87:8021%7]) with mapi id 15.20.4628.018; Fri, 22 Oct 2021
 23:33:25 +0000
Received: from localhost.localdomain (138.3.200.16) by
 SN7PR04CA0018.namprd04.prod.outlook.com (2603:10b6:806:f2::23) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4628.16 via Frontend Transport; Fri, 22 Oct 2021 23:33:21 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 77cc0758-3390-11ec-83da-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc :
 subject : date : message-id : content-type : mime-version;
 s=corp-2021-07-09; bh=j35yrGam9kFx0sdQF8/EFufTO4tusW7M53d8jmIisWA=;
 b=IvZQZdtndduAd0PzmigXCxRMbizg0GV5oP01cE/LzjAHm8DWY4j7+/KT3RSooPSOAorv
 vEpX+G1W7ATJLf02yU003TZTHVpLfs6/6/h5YFYNxUrIjgvbTyuk7+cZZ6VW0t2TVo19
 TXCxepc8rhX13pLp3aKaHYPWS7aUWZ2+DAuuMHXLz+sJNiqwnA4FCf0NpIdAWO006o7w
 POkz/EPimshJteH3+TMoerGwjTwDFwVI5dTpH/rscLL1KPYBg5FIHKyHGXHQDiCAfbIT
 bMNHfvB5TNbacRzy3/me1xmh+4hTxvlug+QE0VgwHBlSkyMKbwoHA8mf4wtSUo5ly2YV YQ== 
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=J2NWfRL0USTVixHYA/fEQOZY78iCFuiQixcOOmyVJh0ww4RnLv9xRnxDPNfqE7OsqyecHm+fWIYLCaNmFFdBazaCVjVm3BffNK8ErXBLPH6jNziHY2RzRJ7jzHkLBIu8OXi2xaJKuWPS6NoEFQvqwqmf6JhVKocAjlGQOv8m5s9b0WEU0rbkOq2m2CNr7fNCVQGi6j3LuLKzHFtGW6IaTWLS+cIydJRjuJhC+4oG2beMy0zgQjjX/gVGBwmN3hwwKmDL0TgrI7vTXjeM8Tf/rVlqnkOA1LT3kDL5G48As+6rhNkVrrSoNh0WYSOtvDC/HGVjTlb5yx1gUj+/9m8SbA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=j35yrGam9kFx0sdQF8/EFufTO4tusW7M53d8jmIisWA=;
 b=SWX9Haufz8o42/kM9W4PGjnYNufnak0BD56hRM1D0WxnhzxuvHtF5DjZyaatNxHFotiwjtLlfIJy4n0N/DbZoGDeKZXdV14WMse0YvJKy61dK+ZAtcW6+KlbS+DDzaIBiD0XxRZWEdpTaeQxVGqdkUNifvwzCMymQPu3pwZ9ruJl981Wi38pB66GVKVqnxeKbt0g66/bUjx732tSLlXpOjZq4bK9XisAVJnwTHzL48qIWPNwJPBWnTJnkG/zrTM+zfpVtSIwgvN9iFFsYK8gjrzXSlRChZhaU9UPR9b2hpHNBRrc9yj9xvZTpZAprFadooFKUuAKNcb1yu2FEpyqnw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com;
 dkim=pass header.d=oracle.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=j35yrGam9kFx0sdQF8/EFufTO4tusW7M53d8jmIisWA=;
 b=cxISBlFtk1zkov5Kpc394gp6/UMtdFX5ThxbohpZs90TyyBdDAs7KVjkfo+zM6CgtEO75YaCVi8ZdluJyDNYATjt9IITJI48tAutnZClSfsoAHpa5zOtNzY+PSHQKuObVBF+TJzav9GC8Q9xC26+g38g+DWC/+dGBUXWGywZMnM=
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=oracle.com;
From: Dongli Zhang <dongli.zhang@oracle.com>
To: xen-devel@lists.xenproject.org, netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, boris.ostrovsky@oracle.com, jgross@suse.com,
        sstabellini@kernel.org, davem@davemloft.net, kuba@kernel.org,
        joe.jin@oracle.com
Subject: [PATCH 1/1] xen/netfront: stop tx queues during live migration
Date: Fri, 22 Oct 2021 16:31:39 -0700
Message-Id: <20211022233139.31775-1-dongli.zhang@oracle.com>
X-Mailer: git-send-email 2.17.1
Content-Type: text/plain
X-ClientProxiedBy: SN7PR04CA0018.namprd04.prod.outlook.com
 (2603:10b6:806:f2::23) To BYAPR10MB2663.namprd10.prod.outlook.com
 (2603:10b6:a02:a9::20)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 26c685e7-ce8c-48bd-553b-08d995b457ac
X-MS-TrafficTypeDiagnostic: BYAPR10MB3158:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: 
	<BYAPR10MB3158FEB990C5AA31E1B89540F0809@BYAPR10MB3158.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 
	4SisDvnLwwL6WhZhfOzYy6kd2uL6PaEyKZpAmHDad1oe27IyTbSr3N4trrhYSBDFrE5b7J8cpkdxTwEbdGmg9Jb/RbZ6TtCHo6PiSbu0rkYJGX8mpW3q+Azf1JOlXC15T3PRpEP67+XY7vpmYWSp2IuHzjeLhgjRV6oEjF6k/C1TtiB1hyB5fe7j7aI8AoMs1D2BkDxYGUBH6PEDrGhYSl4vbSsWt/Tkr8er7E1GREhWalVjyRit3/6ulu6xp/u1Xku0EhiUm4HybUcbZUGeFudKbIkfGxDkPnraCcXCKbLQKeEYvfcG5UXET8/0NFhMkICKMMyfRSEINdSpQAYa8xy9ZRhFddunP0Al3+jLCZtZMk5o5VTaRfDVeuwQnJpuls/i8DbUqagsxRfOMiTV0BQvH46tNHrCta84PtuRPKSY+LYyZGWf/gNx2Bs2jjflbg2+hL73aF0DGCqV2TuGmUiE0Zm+l8cWm8R2zxb2VaY+s++OM7f8DnQNiOWDoy+zeyfH7EDPtKG+blWsmHAtYI3cvTQ8CuUzCoMoMUHd/Xl+Ww/bDFpVXVUihBtK2o0GQJ0HzzAoL1PzDon0NTfVR2RSOOtfxDr47foPycD4GVBkZNN2R6zevBKeTKlTkGEnb4fR/yFJphqB92/PI1dyMtKHKovRFxBaMXU9IzW0RxAbmOCMm6rMKHr4YfrtizN7dPK/CnHhVgg1tnsPASA410Qg0ByFGv6UdS95bj40tFrKJX2SMpbdGLlU8saioTaRHLF5mpAdq7a0ocF2B+DMTQ==
X-Forefront-Antispam-Report: 
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB2663.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(4326008)(107886003)(26005)(966005)(66556008)(6506007)(44832011)(36756003)(8936002)(38100700002)(2616005)(66476007)(83380400001)(38350700002)(6512007)(186003)(508600001)(52116002)(6666004)(86362001)(956004)(66946007)(2906002)(316002)(1076003)(5660300002)(6486002)(8676002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?RNzASlzS9QYPAEjSzfC8dNBEI+ugMly4DYOrrlhsh5yDDoFMpamlVZc1MrPR?=
 =?us-ascii?Q?tUSVWOWD8JsyRg/Tb/cjNd+nviFFqcJk/d4qOfTbWgFDyH0WrhHJtCWmalt+?=
 =?us-ascii?Q?Uts0afnIy+F1jKNkOYWCgVaSduZhCq0zDIGGsaR/wB2IXmFmSWIs/rFttUo6?=
 =?us-ascii?Q?LuJXOylpSjO4051m2wTiWl6R3ylO8u4AZFMsDdnqZYQGmmuuwgQ0yeNKgQD5?=
 =?us-ascii?Q?JeiXpZGO0CHYWEqziPiF+XB912lf6vjB/zx2MLMGhJ4T66IVY3evgSTRZI9A?=
 =?us-ascii?Q?FGSnADFn7tS/ydC6cyi4VRubyFnfteOSspZdxsPpNQGVJu2tid7dNPen2+ln?=
 =?us-ascii?Q?36MHdfhR52S+MVHuspw1qeZRMfLdLbr/tM6CW1qJ/Xn2kZ/ns/uGOxM7U+jA?=
 =?us-ascii?Q?7dwJe2Z1IvzqLfo+q+sWCD0YfLjJqoKL3KhmHM035/VIRws7mc6Y3RFfbMf/?=
 =?us-ascii?Q?dULBm3OA/EpzdU0xw7eyB7VlB/owJ+aczqWyViVwnAN21p2RFNcoQwW0GxhQ?=
 =?us-ascii?Q?T061o5Ws4JmDI3CjVERwIe6gobsL9uHEs0H2/TSsXGbxT3XDc0UCj+CDnEdX?=
 =?us-ascii?Q?jhoHcTdo01b7kAt9n2wWM1KgKnqtuOPW237V4fibIv24vZNKRzcWXsb5WOS6?=
 =?us-ascii?Q?/AZnojeovAIBG+ueZb+x6TPVap4ADoCwEbsAcedymIbolSyZoWShHtXcPi0Y?=
 =?us-ascii?Q?GhSqaM7biitwGqfEz68f98nIgEEIMkOmNZ2ckciRrbvhqo05wezpjMy3ncIT?=
 =?us-ascii?Q?RtzC9WzVatm0YzOl6LxM+N32e0bjZUUrBlgxkJNoNjXpbW56IeYv0jrHi4G8?=
 =?us-ascii?Q?2P7H2aCDAjhfjiSlFd2YtMhGt5euiI6AlOAJu38Bc4HcwVfj7QWNVuHp9ds0?=
 =?us-ascii?Q?tvvDEtHTEC2CXaiv37ibRYtbhMfLodh7ekfGrI9uOFSsvfH6+7nBK0k3uziS?=
 =?us-ascii?Q?5s1R6yfIX+hTm72xsWobcgfHYIzkC9xfXaTgpTOxGap2HQdSP9JykvoTBYqS?=
 =?us-ascii?Q?lQeQgyirsSP+HOz/7E7OvzS7waxquxs+yPt1wJ1fxnB5OjZraaQgFLHzzro/?=
 =?us-ascii?Q?VvgeE/dAyCJMWn0d0Y/ieXhRqJCqkvD1VMU3X1k7NbIYVYWeQdaKUIBOAUib?=
 =?us-ascii?Q?7GHwydIYYBbT3TlYrprg9XS7q4BLrLkMU/NFMaW0qPJ+8zJxJZ218WQzw33L?=
 =?us-ascii?Q?BSPiIYbp13sUTUB0OMkTA5GLA08YM+Ytsr/LgvHMA0ZXk1oo/WSlARs9KPIH?=
 =?us-ascii?Q?CVeOnPG6lves749b0xdp8wUhWOfkcd9YdCjmNvGhCdBKnZ6VBtvy1m2u7Emg?=
 =?us-ascii?Q?hi0M1MamwMePKArMtDXA4XPt?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 26c685e7-ce8c-48bd-553b-08d995b457ac
X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB2663.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Oct 2021 23:33:25.1067
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: dongli.zhang@oracle.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB3158
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10145 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 mlxscore=0 adultscore=0
 spamscore=0 phishscore=0 bulkscore=0 suspectscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109230001
 definitions=main-2110220132
X-Proofpoint-GUID: mMPJ3xou-9Kck0JlV0Jax1ILnkTbs8nf
X-Proofpoint-ORIG-GUID: mMPJ3xou-9Kck0JlV0Jax1ILnkTbs8nf

The tx queues are not stopped during the live migration. As a result, the
ndo_start_xmit() may access netfront_info->queues which is freed by
talk_to_netback()->xennet_destroy_queues().

This patch is to netif_device_detach() at the beginning of xen-netfront
resuming, and netif_device_attach() at the end of resuming.

     CPU A                                CPU B

 talk_to_netback()
 -> if (info->queues)
        xennet_destroy_queues(info);
    to free netfront_info->queues

                                        xennet_start_xmit()
                                        to access netfront_info->queues

  -> err = xennet_create_queues(info, &num_queues);

The idea is borrowed from virtio-net.

Cc: Joe Jin <joe.jin@oracle.com>
Signed-off-by: Dongli Zhang <dongli.zhang@oracle.com>
---
Since I am not able to reproduce the corner case on purpose, I create a
patch to reproduce.
https://raw.githubusercontent.com/finallyjustice/patchset/master/xen-netfront-send-GARP-during-live-migration.patch

 drivers/net/xen-netfront.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c
index e31b98403f31..fc41ba95f81d 100644
--- a/drivers/net/xen-netfront.c
+++ b/drivers/net/xen-netfront.c
@@ -1730,6 +1730,10 @@ static int netfront_resume(struct xenbus_device *dev)
 
 	dev_dbg(&dev->dev, "%s\n", dev->nodename);
 
+	netif_tx_lock_bh(info->netdev);
+	netif_device_detach(info->netdev);
+	netif_tx_unlock_bh(info->netdev);
+
 	xennet_disconnect_backend(info);
 	return 0;
 }
@@ -2349,6 +2353,10 @@ static int xennet_connect(struct net_device *dev)
 	 * domain a kick because we've probably just requeued some
 	 * packets.
 	 */
+	netif_tx_lock_bh(np->netdev);
+	netif_device_attach(np->netdev);
+	netif_tx_unlock_bh(np->netdev);
+
 	netif_carrier_on(np->netdev);
 	for (j = 0; j < num_queues; ++j) {
 		queue = &np->queues[j];
-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Sat Oct 23 00:42:34 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 23 Oct 2021 00:42:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.215309.374421 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1me576-0003f8-Kv; Sat, 23 Oct 2021 00:42:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 215309.374421; Sat, 23 Oct 2021 00:42:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1me576-0003f1-Hm; Sat, 23 Oct 2021 00:42:20 +0000
Received: by outflank-mailman (input) for mailman id 215309;
 Sat, 23 Oct 2021 00:42:19 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=osa5=PL=oracle.com=boris.ostrovsky@srs-us1.protection.inumbo.net>)
 id 1me575-0003ev-BW
 for xen-devel@lists.xenproject.org; Sat, 23 Oct 2021 00:42:19 +0000
Received: from mx0b-00069f02.pphosted.com (unknown [205.220.177.32])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 6af49cfd-9256-4c1c-a08c-875fc4e9f5af;
 Sat, 23 Oct 2021 00:42:16 +0000 (UTC)
Received: from pps.filterd (m0246630.ppops.net [127.0.0.1])
 by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 19MNt43I001637; 
 Sat, 23 Oct 2021 00:42:10 GMT
Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71])
 by mx0b-00069f02.pphosted.com with ESMTP id 3bunf9cw77-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Sat, 23 Oct 2021 00:42:10 +0000
Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1])
 by aserp3030.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 19N0f2Hl063424;
 Sat, 23 Oct 2021 00:42:09 GMT
Received: from nam10-mw2-obe.outbound.protection.outlook.com
 (mail-mw2nam10lp2106.outbound.protection.outlook.com [104.47.55.106])
 by aserp3030.oracle.com with ESMTP id 3bqmsmqvsa-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Sat, 23 Oct 2021 00:42:09 +0000
Received: from BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10)
 by BLAPR10MB5329.namprd10.prod.outlook.com (2603:10b6:208:307::24)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.16; Sat, 23 Oct
 2021 00:42:07 +0000
Received: from BLAPR10MB5009.namprd10.prod.outlook.com
 ([fe80::3c49:46aa:83e1:a329]) by BLAPR10MB5009.namprd10.prod.outlook.com
 ([fe80::3c49:46aa:83e1:a329%5]) with mapi id 15.20.4628.018; Sat, 23 Oct 2021
 00:42:07 +0000
Received: from [10.74.106.110] (138.3.200.46) by
 TYAPR01CA0164.jpnprd01.prod.outlook.com (2603:1096:404:7e::32) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4628.15 via Frontend Transport; Sat, 23 Oct 2021 00:42:03 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6af49cfd-9256-4c1c-a08c-875fc4e9f5af
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date :
 subject : to : cc : references : from : in-reply-to : content-type :
 content-transfer-encoding : mime-version; s=corp-2021-07-09;
 bh=fkoGNWMcvZhvzMdOYi0uRPVpDSbkAYMas7IG6USAMXk=;
 b=BVrHmEkwAIbpZl5UXJOQPBex/ToEgYBi3fz4Vl+CCGAYmY9gvcEA9C3Zbd5cHIOHtTTn
 +dMr1x5N0YLNFu4+VcX4EectN2sEbG64WehCPQjMiP0LVXuLR5HMHB6BJUGUrhEwFRiu
 xFaxeNY7NcyL7neINjMpoFtlrlsLPcHMsu+Mghz1SvPBFhJRAmmeIBLZNRbtMwcj6qDS
 nVp1WQr+SXLh0RCcGHB16P/fWKRE/84G+Ke6JMCz4nZgOHwv2RUQi0pRZS4ib+y7wBpo
 k44ms3C5JRvkeMbcsRzlHWnCR/stcj79z9JrNFPn6Po13BMHSPXcXMPDjoGI8GB/TxMg yw== 
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=gSqf3ZYM1QginsUfazXwQlNoVyW6JzsVitdxcOn7x4zNb7+xC0SWLEaVBz/adjN6x8JPzYN+/v7Q7Oz4BQFSAWBOLx/FsG0c+ItrDlWVkPaWzA7ysYZilF2F2OHmse+TyRjRtnIcrLFaMzDW5rNoVUmp/nsCKVE2IS9wK8naxZAoa/XWtg9AJ5bGIDd9XhqyYirBkhp1/rGn3/0udTNc7bPtwDgXrT3PeQqpTS4nwpmedhinCtSXn4E77XQno4cD8qLCqSc0S6p3HkPGCgcPjEFSyw2Q+4GTSTjiRXOw8JXi78105/9HRoxKRZSudLOjOOI0pipj7D3FnGigYRIZ4Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=fkoGNWMcvZhvzMdOYi0uRPVpDSbkAYMas7IG6USAMXk=;
 b=OkmFzNT9Fi3iWVtEZ5S4Z0nKj1PTwY97PmfZrqi/y49dYzF4i+W3qxwcRy3jvCRvfePKZvmycoJikDcaYmEwJTgDZWQVV4R+Ig3o8sp1dPpWPkNoNUgn4/1m2Cs2heAzU5BhLkPlE4TZ5t/IAasKK+ucSLWXsDca8f0btFtrJWE4wLX+TugI4BDWYjE5y3oJUAbB1q0qB4XvLrIqWxGnLEeqa3MpHUMXl1zM+RyNwRilUhy3F4LxErWhpC+HnAYPEt4V3Jog7BVJ4BXzi6fhJDse8m/Dd2bS++BrXPwDiKTkRkzMlg0jMXosskZ9zu/z0wVm6wacD0vE95mB4+wyqg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com;
 dkim=pass header.d=oracle.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=fkoGNWMcvZhvzMdOYi0uRPVpDSbkAYMas7IG6USAMXk=;
 b=o4lxhzOWtvp3V4o/OLvgcGNEPYFAEa28w85zw3thiFKtxdIVHmZ65EqIzwvnabLOU1/ezzoF50/1wmfBOPBSPFtp3LZChH+0UJgE474H4jE2oBNjwtncaKSe7jM9ur47l1DRlMkJCmzXjLjsWbvAszBQf5bpzh4HOuKoUhUjrXg=
Authentication-Results: kernel.org; dkim=none (message not signed)
 header.d=none;kernel.org; dmarc=none action=none header.from=oracle.com;
Message-ID: <8fe8f4a9-2f5d-b687-279a-fe2b325d23fb@oracle.com>
Date: Fri, 22 Oct 2021 20:41:55 -0400
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.2.0
Subject: Re: [PATCH net-next v2 01/12] net: xen: use eth_hw_addr_set()
Content-Language: en-US
To: Jakub Kicinski <kuba@kernel.org>, davem@davemloft.net
Cc: netdev@vger.kernel.org, wei.liu@kernel.org, paul@xen.org, jgross@suse.com,
        sstabellini@kernel.org, xen-devel@lists.xenproject.org
References: <20211021131214.2032925-1-kuba@kernel.org>
 <20211021131214.2032925-2-kuba@kernel.org>
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
In-Reply-To: <20211021131214.2032925-2-kuba@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: TYAPR01CA0164.jpnprd01.prod.outlook.com
 (2603:1096:404:7e::32) To BLAPR10MB5009.namprd10.prod.outlook.com
 (2603:10b6:208:321::10)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: de874bab-2360-4c81-8fd2-08d995bdf0d0
X-MS-TrafficTypeDiagnostic: BLAPR10MB5329:
X-Microsoft-Antispam-PRVS: 
	<BLAPR10MB5329734B5FBED419A98525488A819@BLAPR10MB5329.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:2089;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 
	hmA8hhMMlNpx7BSvPh5VupuhTr9fxofGdZDkFfNfHXD6gslJqaa+Y1kxQvettE3yxIH11nkXgytjxMFlHxWeL91CzelUNb9qSGNsVZTzm5JxZrPRMDQx7JL+/RyEJw5qcyC9Wcg85hKB73frqJ7R2FLAAnUG1IEZCzBHbQOlqLLxLx4V8c7ArQ+95l6ZNwnoJOtAZf/rBDx/i+cQTx3prr1m+o5FUCGGTraH7ib7l+RQC+5nDgihlaD/QT6iIMe9VPtOra2re91iXGO9BbXwLzByZjFPcqw8Okmxe95X9lzwaKT8ghIvXmPXepFA3DTg9DI/cr1aE/vgF2/CjP/6zlqgFPT7uUPtPWkA66ivVPp7DBIMZ3AlbJMekIZj7KxmKqXe31zI9+Js+pt7Pf7R4qFsQQkn8Q7PcAM9ZBvyPL5rNR5o6cx9C1PXB6maXNt57Th4qoZRnXMSAobMgN4TCtuLTJ/j8jmGZ/j8Emm/3omuoeg577wy9vH+1oEmh0bUCJF4B16LUD/AQFYZ1RgkoJjcYThOcDfKM9MQsgB/HrdoOW15T8+3ylumhrD0QzkaPIHbiqMbqYpDbrgE3M3ZHNGtbSfybSJmDGNA2fLwZf8bWdka/sOdjR5mzrZF73ZVmPBmUvPXLnC/79TiZbjITkSufMcZ/ZdV3v1WCtD7Yi2NE/CyG0O/COHccH6V2bc3Ep2i8vnqUf8salVz5eNBKMurkKYE0X2cTIw6OT2uD+gKMiHHduBp57m7OQmxvJs+
X-Forefront-Antispam-Report: 
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB5009.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(53546011)(4326008)(508600001)(186003)(4744005)(6486002)(66476007)(44832011)(31686004)(66556008)(38100700002)(8676002)(86362001)(2906002)(956004)(2616005)(16576012)(316002)(66946007)(8936002)(6666004)(26005)(5660300002)(31696002)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?bVNVS0pERS9pWWwrcUdWcG1rZUY3S012cTU2TkRZbVpKMHROUjVYbkJCL0Uw?=
 =?utf-8?B?Q0daZ0JaQkNGOWdURXZqeWQxTU1CV1V2STEyZ0dIY1NVNUpkbW93R3FSb1Vp?=
 =?utf-8?B?aGxuazB2aDRUQlNxaU8rUjBSeHY0dExVVllWWk00eWhSL2lYUlFWYXM4aTMw?=
 =?utf-8?B?T1l3SDdienc2VUI4bTQ2SWV5VHVOSTU5cHdhdW9tcU5xdmdFTVVsUERiUHJK?=
 =?utf-8?B?bVhheFRmVFlRVUYxd3ZQcW1TMlhINkQyWDQwSjBvQW44dWdMbk5JQlZjblpV?=
 =?utf-8?B?TCtvVm1mMWdSSmlMcTNHcWFKakxCUFRQeU9ENmpvMEJ6M05uVHBRblNSV2x4?=
 =?utf-8?B?SlRNdWtYOS9FTDA2dGh5M0RLSVF3M0ZDemJYandhWUFaYU5aMEplUzczUU9o?=
 =?utf-8?B?VmMxbDF2MzNvWGE3VmJrYzNFRlhxSkxGZ2ZRaXdCWnpSSm1sVlVkeHVzOVlG?=
 =?utf-8?B?eEVnamtjckhwTXRqK1VYQkVGWTdqaDljSmNma3FXWmRyVWpLQ3ZBbnJQZ01C?=
 =?utf-8?B?Y0xsWHhmUzE4Vk9PRUpXdWpFajZpRW5BdU9RR2p6UFVLclF5N3g1SThFSGRE?=
 =?utf-8?B?TDR5Rk9RaitiMnFoZlFqY2ZSclR6ZzZJRm1IYVZLbjdZSDI4Z0tYT3duV1oz?=
 =?utf-8?B?VkFqVVB4RVJxMXpaVjZWTGR3N21HTG9PVXdtZmlyTytWdzdlT1Azb3hjcVhV?=
 =?utf-8?B?UHNCdk9sOXkxZm1CYzdUeEtDT3FNT1NWNDZwRkg2RUlmUStkNEpZQ296bnkr?=
 =?utf-8?B?Z2h2Wkt6dEN0YU9zdEs5Qy9LQzZqT1N0M00zNVlJTTFzdE8vdHNWWG1Ndis0?=
 =?utf-8?B?dWVVWkxSL2RUM251aUg1dHlHVUhDZURhMHlzVWdCS2hXc3p5THdEK2NScEwr?=
 =?utf-8?B?OWdNa1NpNXhsN3RjSmVWV3hXOFk1TnFFMW8zRUpyZ001MG1BUzR0alIxa2NT?=
 =?utf-8?B?dlJreWV2U3FFampJMVRYY2JUeC83TVJxdm9wTGVwcU02dmM4Qk9IYis2QVZY?=
 =?utf-8?B?cEp3QzVLRzlRdmM1cGkzbTBvdE5xbFhvbk1Ca3ZNUEQyMkRZMkJzZ3dzRHlF?=
 =?utf-8?B?dW1ZYTd0REY2VjdLTnN6dTBJWGwvNWZmdnZCSTdWVE1wMFR0VWpVenRpL2No?=
 =?utf-8?B?TFptM3hZc2xsL0s1N2tBR2dTcnllNDd0cW5QampKUHAyQU5vS3h2SGRCV214?=
 =?utf-8?B?bVNqMHM1dTlSeGo0NGNHUHphZ0lWNGNnL0dIVlMrNCs2cFhjazg0L3hXLzg3?=
 =?utf-8?B?U3RwWHM2a0pmYy8rOFBJWnVOMG91blRnSkpkVU1lVWZnTHdtaEtUVEVEMUhk?=
 =?utf-8?B?MWo0K1F5T2FkVjVXNEpqSEtVYkhLU2YrTkszK0RLYWdyTTBxUlRXbGp5ZlBw?=
 =?utf-8?B?a2xhbTFhaEtxSnhKWlV3amE0QTdXNUJFc1RtTEZ3aVVRNENsQTlZdjB2ejEy?=
 =?utf-8?B?RDRrS1J5c1k1eGthWDNkRWlUOWo0bkF5TlNuS3RPRERMTHU5Y3NHNHR5YXpl?=
 =?utf-8?B?cythcjB2clByaDBVN0lOYVlkZUMyZkd6Qk5JOE9TN3NGVlNzcVBHeENBUGw3?=
 =?utf-8?B?bkxVNlB0S3lDOUJ3Mm9mZEJlMFoySE9lUEE3RzhsM0ZmYjRWZXY0L2wzdXBL?=
 =?utf-8?B?QndIeXZLbHIyMEF5d0llRURWeDNkQ0NHTWx0YzV6N3NnSFRYWFZlQTk0bmpU?=
 =?utf-8?B?VS9uYlpiM3hXMVJLZFp2dVEwVU0rbWtDaE1hYkVUYmc4eEJpN1U3YlNLKzVq?=
 =?utf-8?B?TkdRcis1OVB1aUFyUVFDenFnWnpNRG5VYzlFS0thbHNZY2JIRG1wV21EVnh0?=
 =?utf-8?B?K2hhendMcms1RmZoUXlXQWVnMjg3eVlIS1RCNGRvVjhRV3hNZ0o0Y3IxaU5s?=
 =?utf-8?B?TVBLT2xiVmlhNUVTWnROT1RNM2IrMWlwQXJ1NStyNU1kM2EyMEc0WXBIZDIv?=
 =?utf-8?B?RVI0SUd2ZlJFVnRUUG1aVVoxeUFMcGFoTGZodHc5Umhzekt6ekhjK2tmRUVS?=
 =?utf-8?B?N1RSQ1ZENjg0OFlCZjlYbGJBa1l5Rm5GdDJTQnI2eStYK3VhNzl1TnFhRXhZ?=
 =?utf-8?B?QUt5U0lXeW9xeE9EanJhWldLaFcydGNQYmJhaS9EQUhaUXI4YWo2ZEVOMTZn?=
 =?utf-8?B?d296SldHUWowRVV6RDdFTzhDTVhQNHBjSndMNFlxWll0R1pKNjQveWVNWjl3?=
 =?utf-8?B?N21NakV2MDRSRlRkTnhiYXk0Y3FseWVSUWo4SW5NUGFmS0d4Zm5CejJVWng4?=
 =?utf-8?B?OGdYSFZDL1JPakZEeDZJNVlLZFRnPT0=?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: de874bab-2360-4c81-8fd2-08d995bdf0d0
X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Oct 2021 00:42:07.4369
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: e1GVZuB/m/LmTmEYPqHafaIHyXx5WsHNHH4s8+CZT2GUhL3u9wQIRvKBVU3rBVNFivlZ+VE7ZQMJqM3LATgrXC+lDyeZiYmEZVpt1d9spiU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB5329
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10145 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 adultscore=0 malwarescore=0
 phishscore=0 mlxlogscore=999 bulkscore=0 suspectscore=0 mlxscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109230001
 definitions=main-2110230002
X-Proofpoint-GUID: 7Lm-O9rqshsbQzcIS-vh4XS34YF3hfZW
X-Proofpoint-ORIG-GUID: 7Lm-O9rqshsbQzcIS-vh4XS34YF3hfZW


On 10/21/21 9:12 AM, Jakub Kicinski wrote:
> Commit 406f42fa0d3c ("net-next: When a bond have a massive amount
> of VLANs...") introduced a rbtree for faster Ethernet address look
> up. To maintain netdev->dev_addr in this tree we need to make all
> the writes to it got through appropriate helpers.
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>



Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>



From xen-devel-bounces@lists.xenproject.org Sat Oct 23 02:02:45 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 23 Oct 2021 02:02:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.215319.374438 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1me6Mh-000539-IG; Sat, 23 Oct 2021 02:02:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 215319.374438; Sat, 23 Oct 2021 02:02:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1me6Mh-000532-EK; Sat, 23 Oct 2021 02:02:31 +0000
Received: by outflank-mailman (input) for mailman id 215319;
 Sat, 23 Oct 2021 02:02:30 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1me6Mg-00052s-Qe; Sat, 23 Oct 2021 02:02:30 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1me6Mg-00040H-9R; Sat, 23 Oct 2021 02:02:30 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1me6Mf-0000pU-TF; Sat, 23 Oct 2021 02:02:30 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1me6Mf-0002d3-Sj; Sat, 23 Oct 2021 02:02:29 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=vZSX2pUa3nIGbJLlmMQuVgXJGcN/wthpX+vkl5PKVrs=; b=o4O0aPTtiQrOc+onnDYIe0fff/
	cqPCqQNr9oniDi1sHFon7UG5AEVYvxJv1onPrIhvkKECw9LUGM2DXWFL34I/Qxqr+1e1pivZU587g
	tvX2LxKRrzWCMgBZrRWm2TS623hv8lbaIvJQkVB7XXIDGFnXGDJjnWA2WT7ce4FDJTKk=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165790-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 165790: regressions - FAIL
X-Osstest-Failures:
    qemu-mainline:build-i386:xen-build:fail:regression
    qemu-mainline:build-i386-xsm:xen-build:fail:regression
    qemu-mainline:build-armhf:xen-build:fail:regression
    qemu-mainline:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-amd:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-pair:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-freebsd10-i386:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-freebsd10-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-coresched-i386-xl:build-check(1):blocked:nonblocking
    qemu-mainline:build-armhf-libvirt:build-check(1):blocked:nonblocking
    qemu-mainline:build-i386-libvirt:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-intel:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-shadow:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-vhd:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=2c64ff92ecef4db0169f7238a26f1124268345c8
X-Osstest-Versions-That:
    qemuu=50352cce138ef3b30c1cda28a4df68fff5da3202
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 23 Oct 2021 02:02:29 +0000

flight 165790 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165790/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-i386                    6 xen-build                fail REGR. vs. 165682
 build-i386-xsm                6 xen-build                fail REGR. vs. 165682
 build-armhf                   6 xen-build                fail REGR. vs. 165682

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl           1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-credit2   1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-cubietruck  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-multivcpu  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-rtds      1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-vhd       1 build-check(1)               blocked  n/a
 test-amd64-i386-qemuu-rhel6hvm-amd  1 build-check(1)               blocked n/a
 test-amd64-i386-pair          1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-freebsd10-i386  1 build-check(1)               blocked  n/a
 test-amd64-i386-freebsd10-amd64  1 build-check(1)               blocked  n/a
 test-amd64-coresched-i386-xl  1 build-check(1)               blocked  n/a
 build-armhf-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-arndale   1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-credit1   1 build-check(1)               blocked  n/a
 test-amd64-i386-qemuu-rhel6hvm-intel  1 build-check(1)             blocked n/a
 test-amd64-i386-xl            1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-pvshim     1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-qemuu-debianhvm-amd64  1 build-check(1)         blocked n/a
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow  1 build-check(1)  blocked n/a
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm  1 build-check(1)      blocked n/a
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 1 build-check(1) blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a
 test-amd64-i386-xl-qemuu-win7-amd64  1 build-check(1)              blocked n/a
 test-amd64-i386-xl-qemuu-ws16-amd64  1 build-check(1)              blocked n/a
 test-amd64-i386-xl-shadow     1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-vhd        1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-xsm        1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165682
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165682
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165682
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 qemuu                2c64ff92ecef4db0169f7238a26f1124268345c8
baseline version:
 qemuu                50352cce138ef3b30c1cda28a4df68fff5da3202

Last test of basis   165682  2021-10-19 21:09:14 Z    3 days
Failing since        165694  2021-10-20 18:09:12 Z    2 days    6 attempts
Testing same since   165790  2021-10-22 19:38:09 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Jones <drjones@redhat.com>
  Ani Sinha <ani@anisinha.ca>
  BALATON Zoltan <balaton@eik.bme.hu>
  Cédric Le Goater <clg@kaod.org>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  David Gibson <david@gibson.dropbear.id.au>
  David Hildenbrand <david@redhat.com>
  Eric Auger <eric.auger@redhat.com>
  Eugenio Pérez <eperezma@redhat.com>
  Gavin Shan <gshan@redhat.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Gustavo Romero <gromero@linux.ibm.com>
  Igor Mammedov <imammedo@redhat.com>
  Jason Wang <jasowang@redhat.com>
  John Wang <wangzhiqiang02@inspur.com>
  John Wang <wangzq.jn@gmail.com>
  Laurent Vivier <laurent@vivier.eu>
  Laurent Vivier <lvivier@redhat.com>
  Luc Michel <lmichel@kalray.eu>
  Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
  Matheus Ferst <matheus.ferst@eldorado.org.br>
  Mathieu Poirier <mathieu.poirier@linaro.org>
  Michael S. Tsirkin <mst@redhat.com>
  Philippe Mathieu-Daudé <f4bug@amsat.org>
  Philippe Mathieu-Daudé <philmd@redhat.com>
  Richard Henderson <richard.henderson@linaro.org>
  Shuuichirou Ishii <ishii.shuuichir@fujitsu.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Thomas Huth <thuth@redhat.com>
  Xueming Li <xuemingl@nvidia.com>
  Yanan Wang <wangyanan55@huawei.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               fail    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          blocked 
 test-amd64-i386-xl                                           blocked 
 test-amd64-coresched-i386-xl                                 blocked 
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  blocked 
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       blocked 
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           blocked 
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     blocked 
 test-amd64-i386-freebsd10-amd64                              blocked 
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          blocked 
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          blocked 
 test-armhf-armhf-xl-arndale                                  blocked 
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  blocked 
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  blocked 
 test-armhf-armhf-xl-cubietruck                               blocked 
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         blocked 
 test-amd64-i386-freebsd10-i386                               blocked 
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         blocked 
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                blocked 
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         blocked 
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 blocked 
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    blocked 
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     blocked 
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              blocked 
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    blocked 
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      blocked 
 test-amd64-i386-xl-vhd                                       blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 2838 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Oct 23 04:09:02 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 23 Oct 2021 04:09:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.215331.374458 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1me8Kw-0007cl-Ru; Sat, 23 Oct 2021 04:08:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 215331.374458; Sat, 23 Oct 2021 04:08:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1me8Kw-0007ce-Ow; Sat, 23 Oct 2021 04:08:50 +0000
Received: by outflank-mailman (input) for mailman id 215331;
 Sat, 23 Oct 2021 04:08:49 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1me8Kv-0007cU-FE; Sat, 23 Oct 2021 04:08:49 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1me8Kv-00066E-6n; Sat, 23 Oct 2021 04:08:49 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1me8Ku-0006yA-Tf; Sat, 23 Oct 2021 04:08:48 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1me8Ku-0008MM-T8; Sat, 23 Oct 2021 04:08:48 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=wumCg0lFNozto0i/PQM6k/6xl8wPQXqKI29AZ2XJvK4=; b=C1kGwCMsVjFRLzvhywXG/czqIk
	HmrviQC6T6nTBs+D2UnsRuMj4rEF3MAJfRbj6GmaKAi3gWcuzgLGCuIW8j8HG190PMuZY5x5IB/Vy
	eCgGk3jeTnu+HdIxE/vEHnaCBPkFUOaisZcYP+Z2uFICXCy1ODFD4Jk2IQ1Ua7iI24kQ=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165791-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 165791: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-armhf-armhf-examine:reboot:fail:heisenbug
    linux-linus:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=1d4590f5069bff7d41d7ed1a7e7674fb9d6d502a
X-Osstest-Versions-That:
    linux=64222515138e43da1fcf288f0289ef1020427b87
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 23 Oct 2021 04:08:48 +0000

flight 165791 linux-linus real [real]
flight 165801 linux-linus real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/165791/
http://logs.test-lab.xenproject.org/osstest/logs/165801/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-armhf-armhf-examine      8 reboot              fail pass in 165801-retest

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds    18 guest-start/debian.repeat fail REGR. vs. 165743

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 165743
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 165743
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165743
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 165743
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165743
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 165743
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 165743
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165743
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 linux                1d4590f5069bff7d41d7ed1a7e7674fb9d6d502a
baseline version:
 linux                64222515138e43da1fcf288f0289ef1020427b87

Last test of basis   165743  2021-10-22 05:43:25 Z    0 days
Testing same since   165791  2021-10-22 20:10:34 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andreas K. Huettel <andreas.huettel@ur.de>
  Chenyi Qiang <chenyi.qiang@intel.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Masahiro Kozuka <masa.koz@kozuka.jp>
  Miguel Bernal Marin <miguel.bernal.marin@linux.intel.com>
  Paolo Bonzini <pbonzini@redhat.com>
  Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  Sean Christopherson <seanjc@google.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     fail    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   64222515138e..1d4590f5069b  1d4590f5069bff7d41d7ed1a7e7674fb9d6d502a -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Sat Oct 23 07:31:20 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 23 Oct 2021 07:31:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.215346.374490 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1meBUh-0002sB-FA; Sat, 23 Oct 2021 07:31:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 215346.374490; Sat, 23 Oct 2021 07:31:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1meBUh-0002s4-By; Sat, 23 Oct 2021 07:31:07 +0000
Received: by outflank-mailman (input) for mailman id 215346;
 Sat, 23 Oct 2021 07:31:06 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1meBUg-0002ru-Av; Sat, 23 Oct 2021 07:31:06 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1meBUg-0001Qg-54; Sat, 23 Oct 2021 07:31:06 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1meBUf-00084P-Sn; Sat, 23 Oct 2021 07:31:05 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1meBUf-0003cG-SJ; Sat, 23 Oct 2021 07:31:05 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=pn2BPzpNat4cfZOWWGLY0u7qVvIh5Nt7KsluXekl2Lw=; b=jVa6X5VALHKs7tUcyDoaWtmZ2E
	bnVKO9P7D8zL9L1ujW9DXlrbfECqzmW6B+iFwjNK/UCx7NoIQDvviZK2GcIL38+Lv8s/OTroiOqkB
	Tx59RIT1VhF/I+Bu+A/Nyl7af1Ms6ULMavyq3P/s7EtMeRNfqtZfjxhynN3H8+0VkfEU=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165803-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 165803: regressions - FAIL
X-Osstest-Failures:
    libvirt:build-armhf-libvirt:libvirt-build:fail:regression
    libvirt:build-amd64-libvirt:libvirt-build:fail:regression
    libvirt:build-i386-libvirt:libvirt-build:fail:regression
    libvirt:build-arm64-libvirt:libvirt-build:fail:regression
    libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    libvirt=945942ebba943e6addd6c8163d6e38a4a7df7b8f
X-Osstest-Versions-That:
    libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 23 Oct 2021 07:31:05 +0000

flight 165803 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165803/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-armhf-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-amd64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-i386-libvirt            6 libvirt-build            fail REGR. vs. 151777
 build-arm64-libvirt           6 libvirt-build            fail REGR. vs. 151777

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-libvirt-vhd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a

version targeted for testing:
 libvirt              945942ebba943e6addd6c8163d6e38a4a7df7b8f
baseline version:
 libvirt              2c846fa6bcc11929c9fb857a22430fb9945654ad

Last test of basis   151777  2020-07-10 04:19:19 Z  470 days
Failing since        151818  2020-07-11 04:18:52 Z  469 days  455 attempts
Testing same since   165803  2021-10-23 04:19:02 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
    Adolfo Jayme Barrientos <fitoschido@gmail.com>
  Aleksandr Alekseev <alexander.alekseev@virtuozzo.com>
  Aleksei Zakharov <zaharov@selectel.ru>
  Andika Triwidada <andika@gmail.com>
  Andrea Bolognani <abologna@redhat.com>
  Ani Sinha <ani@anisinha.ca>
  Balázs Meskó <meskobalazs@mailbox.org>
  Barrett Schonefeld <bschoney@utexas.edu>
  Bastian Germann <bastiangermann@fishpost.de>
  Bastien Orivel <bastien.orivel@diateam.net>
  BiaoXiang Ye <yebiaoxiang@huawei.com>
  Bihong Yu <yubihong@huawei.com>
  Binfeng Wu <wubinfeng@huawei.com>
  Bjoern Walk <bwalk@linux.ibm.com>
  Boris Fiuczynski <fiuczy@linux.ibm.com>
  Brian Turek <brian.turek@gmail.com>
  Bruno Haible <bruno@clisp.org>
  Chris Mayo <aklhfex@gmail.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Ehrhardt <christian.ehrhardt@canonical.com>
  Christian Kirbach <christian.kirbach@gmail.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Cole Robinson <crobinso@redhat.com>
  Collin Walling <walling@linux.ibm.com>
  Cornelia Huck <cohuck@redhat.com>
  Cédric Bosdonnat <cbosdonnat@suse.com>
  Côme Borsoi <fedora@borsoi.fr>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniel Letai <dani@letai.org.il>
  Daniel P. Berrange <berrange@redhat.com>
  Daniel P. Berrangé <berrange@redhat.com>
  Didik Supriadi <didiksupriadi41@gmail.com>
  dinglimin <dinglimin@cmss.chinamobile.com>
  Dmitrii Shcherbakov <dmitrii.shcherbakov@canonical.com>
  Dmytro Linkin <dlinkin@nvidia.com>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Eric Farman <farman@linux.ibm.com>
  Erik Skultety <eskultet@redhat.com>
  Fabian Affolter <mail@fabian-affolter.ch>
  Fabian Freyer <fabian.freyer@physik.tu-berlin.de>
  Fabiano Fidêncio <fabiano@fidencio.org>
  Fangge Jin <fjin@redhat.com>
  Farhan Ali <alifm@linux.ibm.com>
  Fedora Weblate Translation <i18n@lists.fedoraproject.org>
  Gavi Teitz <gavi@nvidia.com>
  gongwei <gongwei@smartx.com>
  Guoyi Tu<tu.guoyi@h3c.com>
  Göran Uddeborg <goeran@uddeborg.se>
  Halil Pasic <pasic@linux.ibm.com>
  Han Han <hhan@redhat.com>
  Hao Wang <wanghao232@huawei.com>
  Hela Basa <r45xveza@pm.me>
  Helmut Grohne <helmut@subdivi.de>
  Hiroki Narukawa <hnarukaw@yahoo-corp.jp>
  Ian Wienand <iwienand@redhat.com>
  Jakob Meng <jakobmeng@web.de>
  Jamie Strandboge <jamie@canonical.com>
  Jamie Strandboge <jamie@ubuntu.com>
  Jan Kuparinen <copper_fin@hotmail.com>
  jason lee <ppark5237@gmail.com>
  Jean-Baptiste Holcroft <jean-baptiste@holcroft.fr>
  Jia Zhou <zhou.jia2@zte.com.cn>
  Jianan Gao <jgao@redhat.com>
  Jim Fehlig <jfehlig@suse.com>
  Jin Yan <jinyan12@huawei.com>
  Jinsheng Zhang <zhangjl02@inspur.com>
  Jiri Denemark <jdenemar@redhat.com>
  John Ferlan <jferlan@redhat.com>
  Jonathan Watt <jwatt@jwatt.org>
  Jonathon Jongsma <jjongsma@redhat.com>
  Julio Faracco <jcfaracco@gmail.com>
  Justin Gatzen <justin.gatzen@gmail.com>
  Ján Tomko <jtomko@redhat.com>
  Kashyap Chamarthy <kchamart@redhat.com>
  Kevin Locke <kevin@kevinlocke.name>
  Kristina Hanicova <khanicov@redhat.com>
  Laine Stump <laine@redhat.com>
  Laszlo Ersek <lersek@redhat.com>
  Lee Yarwood <lyarwood@redhat.com>
  Lei Yang <yanglei209@huawei.com>
  Liao Pingfang <liao.pingfang@zte.com.cn>
  Lin Ma <lma@suse.com>
  Lin Ma <lma@suse.de>
  Lin Ma <morecache@gmail.com>
  Liu Yiding <liuyd.fnst@fujitsu.com>
  Luke Yue <lukedyue@gmail.com>
  Luyao Zhong <luyao.zhong@intel.com>
  Marc Hartmayer <mhartmay@linux.ibm.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Markus Schade <markus.schade@hetzner.com>
  Martin Kletzander <mkletzan@redhat.com>
  Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
  Matej Cepl <mcepl@cepl.eu>
  Matt Coleman <matt@datto.com>
  Matt Coleman <mcoleman@datto.com>
  Mauro Matteo Cascella <mcascell@redhat.com>
  Meina Li <meili@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Michał Smyk <fedora@smyk.it>
  Milo Casagrande <milo@milo.name>
  Moshe Levi <moshele@nvidia.com>
  Muha Aliss <muhaaliss@gmail.com>
  Nathan <nathan95@live.it>
  Neal Gompa <ngompa13@gmail.com>
  Nick Chevsky <nchevsky@gmail.com>
  Nick Shyrokovskiy <nshyrokovskiy@gmail.com>
  Nickys Music Group <nickys.music.group@gmail.com>
  Nico Pache <npache@redhat.com>
  Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
  Olaf Hering <olaf@aepfle.de>
  Olesya Gerasimenko <gammaray@basealt.ru>
  Orion Poplawski <orion@nwra.com>
  Pany <geekpany@gmail.com>
  Patrick Magauran <patmagauran.j@gmail.com>
  Paulo de Rezende Pinatti <ppinatti@linux.ibm.com>
  Pavel Hrdina <phrdina@redhat.com>
  Peng Liang <liangpeng10@huawei.com>
  Peter Krempa <pkrempa@redhat.com>
  Pino Toscano <ptoscano@redhat.com>
  Pino Toscano <toscano.pino@tiscali.it>
  Piotr Drąg <piotrdrag@gmail.com>
  Prathamesh Chavan <pc44800@gmail.com>
  Praveen K Paladugu <prapal@linux.microsoft.com>
  Richard W.M. Jones <rjones@redhat.com>
  Ricky Tigg <ricky.tigg@gmail.com>
  Robin Lee <cheeselee@fedoraproject.org>
  Roman Bogorodskiy <bogorodskiy@gmail.com>
  Roman Bolshakov <r.bolshakov@yadro.com>
  Ryan Gahagan <rgahagan@cs.utexas.edu>
  Ryan Schmidt <git@ryandesign.com>
  Sam Hartman <hartmans@debian.org>
  Scott Shambarger <scott-libvirt@shambarger.net>
  Sebastian Mitterle <smitterl@redhat.com>
  SeongHyun Jo <caelus9536@gmail.com>
  Shalini Chellathurai Saroja <shalini@linux.ibm.com>
  Shaojun Yang <yangshaojun@phytium.com.cn>
  Shi Lei <shi_lei@massclouds.com>
  simmon <simmon@nplob.com>
  Simon Chopin <chopin.simon@gmail.com>
  Simon Gaiser <simon@invisiblethingslab.com>
  Simon Rowe <simon.rowe@nutanix.com>
  Stefan Bader <stefan.bader@canonical.com>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Berger <stefanb@linux.vnet.ibm.com>
  Stefan Hajnoczi <stefanha@gmail.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Szymon Scholz <szymonscholz@gmail.com>
  Thomas Huth <thuth@redhat.com>
  Tim Wiederhake <twiederh@redhat.com>
  Tomáš Golembiovský <tgolembi@redhat.com>
  Tomáš Janoušek <tomi@nomi.cz>
  Tuguoyi <tu.guoyi@h3c.com>
  Victor Toso <victortoso@redhat.com>
  Ville Skyttä <ville.skytta@iki.fi>
  Vinayak Kale <vkale@nvidia.com>
  Wang Xin <wangxinxin.wang@huawei.com>
  WangJian <wangjian161@huawei.com>
  Weblate <noreply@weblate.org>
  Wei Liu <liuwe@microsoft.com>
  Wei Liu <wei.liu@kernel.org>
  Wei-Chen Chen <weicche@microsoft.com>
  William Douglas <william.douglas@intel.com>
  Yalei Li <274268859@qq.com>
  Yalei Li <liyl43@chinatelecom.cn>
  Yang Fei <yangfei85@huawei.com>
  Yang Hang <yanghang44@huawei.com>
  Yanqiu Zhang <yanqzhan@redhat.com>
  Yaroslav Kargin <ykargin@virtuozzo.com>
  Yi Li <yili@winhong.com>
  Yi Wang <wang.yi59@zte.com.cn>
  Yuri Chornoivan <yurchor@ukr.net>
  Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
  zhangjl02 <zhangjl02@inspur.com>
  Zheng Chuan <zhengchuan@huawei.com>
  zhenwei pi <pizhenwei@bytedance.com>
  Zhenyu Ye <yezhenyu2@huawei.com>
  Zhenyu Zheng <zheng.zhenyu@outlook.com>
  Zhenzhong Duan <zhenzhong.duan@intel.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          fail    
 build-arm64-libvirt                                          fail    
 build-armhf-libvirt                                          fail    
 build-i386-libvirt                                           fail    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           blocked 
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-libvirt-xsm                                 blocked 
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-libvirt                                     blocked 
 test-arm64-arm64-libvirt                                     blocked 
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-libvirt-pair                                blocked 
 test-amd64-i386-libvirt-pair                                 blocked 
 test-arm64-arm64-libvirt-qcow2                               blocked 
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-libvirt-vhd                                 blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 80474 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Oct 23 16:46:06 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 23 Oct 2021 16:46:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.215404.374561 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1meK9V-00023u-UE; Sat, 23 Oct 2021 16:45:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 215404.374561; Sat, 23 Oct 2021 16:45:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1meK9V-00023n-R8; Sat, 23 Oct 2021 16:45:49 +0000
Received: by outflank-mailman (input) for mailman id 215404;
 Sat, 23 Oct 2021 16:45:49 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1meK9V-00023d-4K; Sat, 23 Oct 2021 16:45:49 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1meK9U-00039h-N4; Sat, 23 Oct 2021 16:45:48 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1meK9U-0001k0-EU; Sat, 23 Oct 2021 16:45:48 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1meK9U-0003CV-E1; Sat, 23 Oct 2021 16:45:48 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=mauexZe821d7vK2UhzkS34IZ8IS6vM2t+j0LUA6k3ko=; b=vY6Be0nNpvCrMqfJkLViGmj/eP
	qVr26iPRK0mtuzxRWAYX5Jiq3fSrE8qJ7LXdnLciaMX/kDnqO6UyKm4SmR1v+bheDsimgeeUSIBMm
	wEAoJuQxXe3JHob44plAetba5LiLoe/7snaY6PmMJ+P2uJXYJrSOrtdHg24xyzALj5H0=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165808-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 165808: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=62540372230ecb5318a9c8a40580a14beeb9ded0
X-Osstest-Versions-That:
    ovmf=bd5ec03d87cacc5be2de4284b092aafd4ac4eb31
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 23 Oct 2021 16:45:48 +0000

flight 165808 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165808/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 62540372230ecb5318a9c8a40580a14beeb9ded0
baseline version:
 ovmf                 bd5ec03d87cacc5be2de4284b092aafd4ac4eb31

Last test of basis   165767  2021-10-22 10:10:33 Z    1 days
Testing same since   165808  2021-10-23 08:42:15 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Ard Biesheuvel <ardb@kernel.org>
  Moritz Fischer <moritzf@google.com>
  Nhi Pham <nhi@os.amperecomputing.com>
  Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   bd5ec03d87..6254037223  62540372230ecb5318a9c8a40580a14beeb9ded0 -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Sat Oct 23 16:49:56 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 23 Oct 2021 16:49:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.215412.374574 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1meKDT-0002gx-FU; Sat, 23 Oct 2021 16:49:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 215412.374574; Sat, 23 Oct 2021 16:49:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1meKDT-0002gq-CZ; Sat, 23 Oct 2021 16:49:55 +0000
Received: by outflank-mailman (input) for mailman id 215412;
 Sat, 23 Oct 2021 16:49:53 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1meKDR-0002gg-Sq; Sat, 23 Oct 2021 16:49:53 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1meKDR-0003E0-Oi; Sat, 23 Oct 2021 16:49:53 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1meKDR-00027W-Iu; Sat, 23 Oct 2021 16:49:53 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1meKDR-0003tD-IQ; Sat, 23 Oct 2021 16:49:53 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=vN9gTE/6Ly6MlSfvIWjH66hyTsyB4HhYJ8Y1fEGo/Dw=; b=S91r1Nu22zNgn8N+Xntj7LYgiC
	fAjYUbcS1JY+/LR4eysLIugWSGih9YIz5LB74ox8l8Of3spwBxERCtY7QxNkrKVVFWiaptxSVY8Xr
	TinsYdWCKOwxYoxnvE9VB900R+MIzwo75WSMXHnIpQIOJoKTwI6tYDsYqazUuigDPgrk=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165802-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 165802: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=9c0c4d24ac000e52d55348961d3a3ba42065e0cf
X-Osstest-Versions-That:
    linux=1d4590f5069bff7d41d7ed1a7e7674fb9d6d502a
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 23 Oct 2021 16:49:53 +0000

flight 165802 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165802/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 165791
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 165791
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165791
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 165791
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165791
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 165791
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 165791
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165791
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 linux                9c0c4d24ac000e52d55348961d3a3ba42065e0cf
baseline version:
 linux                1d4590f5069bff7d41d7ed1a7e7674fb9d6d502a

Last test of basis   165791  2021-10-22 20:10:34 Z    0 days
Testing same since   165802  2021-10-23 04:10:09 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Arnd Bergmann <arnd@arndb.de>
  Jens Axboe <axboe@kernel.dk>
  Linus Torvalds <torvalds@linux-foundation.org>
  Miklos Szeredi <mszeredi@redhat.com>
  Pavel Begunkov <asml.silence@gmail.com>
  Tejun Heo <tj@kernel.org>
  Wei Liu <wei.liu@kernel.org>
  Zqiang <qiang.zhang1211@gmail.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   1d4590f5069b..9c0c4d24ac00  9c0c4d24ac000e52d55348961d3a3ba42065e0cf -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Sat Oct 23 17:22:40 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 23 Oct 2021 17:22:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.215420.374589 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1meKj3-0006cm-3E; Sat, 23 Oct 2021 17:22:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 215420.374589; Sat, 23 Oct 2021 17:22:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1meKj2-0006cf-W3; Sat, 23 Oct 2021 17:22:32 +0000
Received: by outflank-mailman (input) for mailman id 215420;
 Sat, 23 Oct 2021 17:22:31 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1meKj1-0006cV-KX; Sat, 23 Oct 2021 17:22:31 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1meKj1-0003nE-AD; Sat, 23 Oct 2021 17:22:31 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1meKj1-0004FT-0j; Sat, 23 Oct 2021 17:22:31 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1meKj1-0008NB-0F; Sat, 23 Oct 2021 17:22:31 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=MG5V2+ZEwQXoZ3M7cIqkBwTMR1A16yGXAFZzBc7FI80=; b=U9sD2BqhOC/vF3z7Is+AlwjtSI
	WJZXCOOCl4W4hHdSLke49W8Dstpu5EMvx37yX2F7oQMoH3ADdu/0wjD4CuB3iMvbZdpxAIv8OtbH5
	X+oO5C5RotWWaVw9+xpy/lvcu9IKBCYII7Qtk8LdHUww6z5c9L9GFo4Da4fjUVvRMqSs=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165798-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 165798: tolerable FAIL
X-Osstest-Failures:
    xen-unstable:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=23ec1ebc8acbfd2bf06f6085a776f0db923f9fa9
X-Osstest-Versions-That:
    xen=23ec1ebc8acbfd2bf06f6085a776f0db923f9fa9
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 23 Oct 2021 17:22:31 +0000

flight 165798 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165798/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-rtds     20 guest-localmigrate/x10       fail  like 165729
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 165729
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 165729
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165729
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165729
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 165729
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 165729
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 165729
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 165729
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 165729
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 165729
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165729
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 165729
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  23ec1ebc8acbfd2bf06f6085a776f0db923f9fa9
baseline version:
 xen                  23ec1ebc8acbfd2bf06f6085a776f0db923f9fa9

Last test of basis   165798  2021-10-23 01:51:41 Z    0 days
Testing same since                          (not found)         0 attempts

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     fail    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Published tested tree is already up to date.



From xen-devel-bounces@lists.xenproject.org Sat Oct 23 18:07:55 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 23 Oct 2021 18:07:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.215433.374609 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1meLQh-0002Qb-Sp; Sat, 23 Oct 2021 18:07:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 215433.374609; Sat, 23 Oct 2021 18:07:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1meLQh-0002QU-Pp; Sat, 23 Oct 2021 18:07:39 +0000
Received: by outflank-mailman (input) for mailman id 215433;
 Sat, 23 Oct 2021 18:07:39 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1meLQg-0002QK-Vn; Sat, 23 Oct 2021 18:07:38 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1meLQg-0004b2-N4; Sat, 23 Oct 2021 18:07:38 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1meLQg-00064q-Bx; Sat, 23 Oct 2021 18:07:38 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1meLQg-0007nM-BU; Sat, 23 Oct 2021 18:07:38 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=znihICh2Xsvs/1HuayyOmktT9M7QZtK1NDq7SjXSkBg=; b=IUJZ2iaD7Es8/PscsqnSkkg3en
	qOY8i7H+BwCHecQUVPVa3Z58ExH/GCgg9s3d5ZOAQxZ64+NvYlqaNEkZRpat6w3zcW2oCUnxdwqKW
	gKvTglHTsIEmQfIevzbfvzXt0o156n47BsA9Zy7zTLcM/lRxYYZiYY+mfjtWs9oxff2Y=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165799-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 165799: regressions - FAIL
X-Osstest-Failures:
    qemu-mainline:build-i386:xen-build:fail:regression
    qemu-mainline:build-i386-xsm:xen-build:fail:regression
    qemu-mainline:build-armhf:xen-build:fail:regression
    qemu-mainline:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-amd:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-pair:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-freebsd10-i386:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-freebsd10-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-coresched-i386-xl:build-check(1):blocked:nonblocking
    qemu-mainline:build-armhf-libvirt:build-check(1):blocked:nonblocking
    qemu-mainline:build-i386-libvirt:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-intel:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-shadow:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-vhd:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=660efed8b37aedec9b5fcc555da1f88f7d12c98a
X-Osstest-Versions-That:
    qemuu=50352cce138ef3b30c1cda28a4df68fff5da3202
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 23 Oct 2021 18:07:38 +0000

flight 165799 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165799/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-i386                    6 xen-build                fail REGR. vs. 165682
 build-i386-xsm                6 xen-build                fail REGR. vs. 165682
 build-armhf                   6 xen-build                fail REGR. vs. 165682

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl           1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-credit2   1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-cubietruck  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-multivcpu  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-rtds      1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-vhd       1 build-check(1)               blocked  n/a
 test-amd64-i386-qemuu-rhel6hvm-amd  1 build-check(1)               blocked n/a
 test-amd64-i386-pair          1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-freebsd10-i386  1 build-check(1)               blocked  n/a
 test-amd64-i386-freebsd10-amd64  1 build-check(1)               blocked  n/a
 test-amd64-coresched-i386-xl  1 build-check(1)               blocked  n/a
 build-armhf-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-credit1   1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-arndale   1 build-check(1)               blocked  n/a
 test-amd64-i386-qemuu-rhel6hvm-intel  1 build-check(1)             blocked n/a
 test-amd64-i386-xl            1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-pvshim     1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-qemuu-debianhvm-amd64  1 build-check(1)         blocked n/a
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow  1 build-check(1)  blocked n/a
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm  1 build-check(1)      blocked n/a
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 1 build-check(1) blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a
 test-amd64-i386-xl-qemuu-win7-amd64  1 build-check(1)              blocked n/a
 test-amd64-i386-xl-qemuu-ws16-amd64  1 build-check(1)              blocked n/a
 test-amd64-i386-xl-shadow     1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-vhd        1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-xsm        1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165682
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165682
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165682
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 qemuu                660efed8b37aedec9b5fcc555da1f88f7d12c98a
baseline version:
 qemuu                50352cce138ef3b30c1cda28a4df68fff5da3202

Last test of basis   165682  2021-10-19 21:09:14 Z    3 days
Failing since        165694  2021-10-20 18:09:12 Z    2 days    7 attempts
Testing same since   165799  2021-10-23 02:04:24 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Alistair Francis <alistair.francis@wdc.com>
  Andrew Jones <drjones@redhat.com>
  Ani Sinha <ani@anisinha.ca>
  BALATON Zoltan <balaton@eik.bme.hu>
  Bin Meng <bmeng.cn@gmail.com>
  Cédric Le Goater <clg@kaod.org>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  David Gibson <david@gibson.dropbear.id.au>
  David Hildenbrand <david@redhat.com>
  Eric Auger <eric.auger@redhat.com>
  Eugenio Pérez <eperezma@redhat.com>
  Frank Chang <frank.chang@sifive.com>
  Gavin Shan <gshan@redhat.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Gustavo Romero <gromero@linux.ibm.com>
  Igor Mammedov <imammedo@redhat.com>
  Jason Wang <jasowang@redhat.com>
  John Wang <wangzhiqiang02@inspur.com>
  John Wang <wangzq.jn@gmail.com>
  Laurent Vivier <laurent@vivier.eu>
  Laurent Vivier <lvivier@redhat.com>
  Luc Michel <lmichel@kalray.eu>
  Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
  Matheus Ferst <matheus.ferst@eldorado.org.br>
  Mathieu Poirier <mathieu.poirier@linaro.org>
  Michael S. Tsirkin <mst@redhat.com>
  Mingwang Li <limingwang@huawei.com>
  Philipp Tomsich <philipp.tomsich@vrull.eu>
  Philippe Mathieu-Daudé <f4bug@amsat.org>
  Philippe Mathieu-Daudé <philmd@redhat.com>
  Richard Henderson <richard.henderson@linaro.org>
  Shuuichirou Ishii <ishii.shuuichir@fujitsu.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Thomas Huth <thuth@redhat.com>
  Travis Geiselbrecht <travisg@gmail.com>
  Vincent Palatin <vpalatin@rivosinc.com>
  Xueming Li <xuemingl@nvidia.com>
  Yanan Wang <wangyanan55@huawei.com>
  Yifei Jiang <jiangyifei@huawei.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               fail    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          blocked 
 test-amd64-i386-xl                                           blocked 
 test-amd64-coresched-i386-xl                                 blocked 
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  blocked 
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       blocked 
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           blocked 
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     blocked 
 test-amd64-i386-freebsd10-amd64                              blocked 
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          blocked 
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          blocked 
 test-armhf-armhf-xl-arndale                                  blocked 
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  blocked 
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  blocked 
 test-armhf-armhf-xl-cubietruck                               blocked 
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         blocked 
 test-amd64-i386-freebsd10-i386                               blocked 
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         blocked 
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                blocked 
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         blocked 
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 blocked 
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    blocked 
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     blocked 
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              blocked 
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    blocked 
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      blocked 
 test-amd64-i386-xl-vhd                                       blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 3424 lines long.)


From xen-devel-bounces@lists.xenproject.org Sun Oct 24 00:35:33 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 24 Oct 2021 00:35:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.215450.374650 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1meRTo-0003Dw-Np; Sun, 24 Oct 2021 00:35:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 215450.374650; Sun, 24 Oct 2021 00:35:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1meRTo-0003Dp-Ko; Sun, 24 Oct 2021 00:35:16 +0000
Received: by outflank-mailman (input) for mailman id 215450;
 Sun, 24 Oct 2021 00:35:14 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1meRTm-0003Dd-L0; Sun, 24 Oct 2021 00:35:14 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1meRTm-0003Fo-DL; Sun, 24 Oct 2021 00:35:14 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1meRTm-0004sd-3I; Sun, 24 Oct 2021 00:35:14 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1meRTm-0003vI-2l; Sun, 24 Oct 2021 00:35:14 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=gNcDCgDFAzlNvXgaTgPiGMZ6u7aQ+iWYNKHoKe3q1CA=; b=cUcO7gb5YvztvyUTslA/pw90c1
	ojr7X3f8VzWyDk2ew7pXGzsk2Q+kXvPAFA8hzD5niZQVO5We9CCcuzxyI/QicQSQsCvEbbGPljcKn
	cF6AFeSecsPrdhjyW3C6Oe91OSHKTxZNYXQlPnTgECRn/+mNS2pAGkd1vetJGAoyOmkc=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165817-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 165817: regressions - FAIL
X-Osstest-Failures:
    qemu-mainline:build-i386:xen-build:fail:regression
    qemu-mainline:build-i386-xsm:xen-build:fail:regression
    qemu-mainline:build-armhf:xen-build:fail:regression
    qemu-mainline:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-amd:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-pair:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-freebsd10-i386:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-freebsd10-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-coresched-i386-xl:build-check(1):blocked:nonblocking
    qemu-mainline:build-armhf-libvirt:build-check(1):blocked:nonblocking
    qemu-mainline:build-i386-libvirt:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-intel:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-shadow:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-vhd:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=660efed8b37aedec9b5fcc555da1f88f7d12c98a
X-Osstest-Versions-That:
    qemuu=50352cce138ef3b30c1cda28a4df68fff5da3202
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 24 Oct 2021 00:35:14 +0000

flight 165817 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165817/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-i386                    6 xen-build                fail REGR. vs. 165682
 build-i386-xsm                6 xen-build                fail REGR. vs. 165682
 build-armhf                   6 xen-build                fail REGR. vs. 165682

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl           1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-credit2   1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-cubietruck  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-multivcpu  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-rtds      1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-vhd       1 build-check(1)               blocked  n/a
 test-amd64-i386-qemuu-rhel6hvm-amd  1 build-check(1)               blocked n/a
 test-amd64-i386-pair          1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-freebsd10-i386  1 build-check(1)               blocked  n/a
 test-amd64-i386-freebsd10-amd64  1 build-check(1)               blocked  n/a
 test-amd64-coresched-i386-xl  1 build-check(1)               blocked  n/a
 build-armhf-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-credit1   1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-arndale   1 build-check(1)               blocked  n/a
 test-amd64-i386-qemuu-rhel6hvm-intel  1 build-check(1)             blocked n/a
 test-amd64-i386-xl            1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-pvshim     1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-qemuu-debianhvm-amd64  1 build-check(1)         blocked n/a
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow  1 build-check(1)  blocked n/a
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm  1 build-check(1)      blocked n/a
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 1 build-check(1) blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a
 test-amd64-i386-xl-qemuu-win7-amd64  1 build-check(1)              blocked n/a
 test-amd64-i386-xl-qemuu-ws16-amd64  1 build-check(1)              blocked n/a
 test-amd64-i386-xl-shadow     1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-vhd        1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-xsm        1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165682
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165682
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165682
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 qemuu                660efed8b37aedec9b5fcc555da1f88f7d12c98a
baseline version:
 qemuu                50352cce138ef3b30c1cda28a4df68fff5da3202

Last test of basis   165682  2021-10-19 21:09:14 Z    4 days
Failing since        165694  2021-10-20 18:09:12 Z    3 days    8 attempts
Testing same since   165799  2021-10-23 02:04:24 Z    0 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
  Alistair Francis <alistair.francis@wdc.com>
  Andrew Jones <drjones@redhat.com>
  Ani Sinha <ani@anisinha.ca>
  BALATON Zoltan <balaton@eik.bme.hu>
  Bin Meng <bmeng.cn@gmail.com>
  Cédric Le Goater <clg@kaod.org>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  David Gibson <david@gibson.dropbear.id.au>
  David Hildenbrand <david@redhat.com>
  Eric Auger <eric.auger@redhat.com>
  Eugenio Pérez <eperezma@redhat.com>
  Frank Chang <frank.chang@sifive.com>
  Gavin Shan <gshan@redhat.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Gustavo Romero <gromero@linux.ibm.com>
  Igor Mammedov <imammedo@redhat.com>
  Jason Wang <jasowang@redhat.com>
  John Wang <wangzhiqiang02@inspur.com>
  John Wang <wangzq.jn@gmail.com>
  Laurent Vivier <laurent@vivier.eu>
  Laurent Vivier <lvivier@redhat.com>
  Luc Michel <lmichel@kalray.eu>
  Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
  Matheus Ferst <matheus.ferst@eldorado.org.br>
  Mathieu Poirier <mathieu.poirier@linaro.org>
  Michael S. Tsirkin <mst@redhat.com>
  Mingwang Li <limingwang@huawei.com>
  Philipp Tomsich <philipp.tomsich@vrull.eu>
  Philippe Mathieu-Daudé <f4bug@amsat.org>
  Philippe Mathieu-Daudé <philmd@redhat.com>
  Richard Henderson <richard.henderson@linaro.org>
  Shuuichirou Ishii <ishii.shuuichir@fujitsu.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Thomas Huth <thuth@redhat.com>
  Travis Geiselbrecht <travisg@gmail.com>
  Vincent Palatin <vpalatin@rivosinc.com>
  Xueming Li <xuemingl@nvidia.com>
  Yanan Wang <wangyanan55@huawei.com>
  Yifei Jiang <jiangyifei@huawei.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               fail    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          blocked 
 test-amd64-i386-xl                                           blocked 
 test-amd64-coresched-i386-xl                                 blocked 
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  blocked 
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       blocked 
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           blocked 
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     blocked 
 test-amd64-i386-freebsd10-amd64                              blocked 
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          blocked 
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          blocked 
 test-armhf-armhf-xl-arndale                                  blocked 
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  blocked 
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  blocked 
 test-armhf-armhf-xl-cubietruck                               blocked 
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         blocked 
 test-amd64-i386-freebsd10-i386                               blocked 
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         blocked 
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                blocked 
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         blocked 
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 blocked 
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    blocked 
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     blocked 
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              blocked 
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    blocked 
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      blocked 
 test-amd64-i386-xl-vhd                                       blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 3424 lines long.)


From xen-devel-bounces@lists.xenproject.org Sun Oct 24 07:36:01 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 24 Oct 2021 07:36:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.215471.374697 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1meY2l-0000S8-3p; Sun, 24 Oct 2021 07:35:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 215471.374697; Sun, 24 Oct 2021 07:35:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1meY2l-0000S1-0K; Sun, 24 Oct 2021 07:35:47 +0000
Received: by outflank-mailman (input) for mailman id 215471;
 Sun, 24 Oct 2021 07:35:45 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1meY2j-0000Rr-LC; Sun, 24 Oct 2021 07:35:45 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1meY2j-0004IW-BF; Sun, 24 Oct 2021 07:35:45 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1meY2j-0007cI-2Q; Sun, 24 Oct 2021 07:35:45 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1meY2j-0003nD-1w; Sun, 24 Oct 2021 07:35:45 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=EHm8iCdEb10oWQIz4U6RyyMs4FLzSKb/V9oWVq8T+do=; b=46d29YUPRp5pQLR2iUF1MHMK9R
	Vtr9/4VviskRneyn646g9GhOA7m8aaPCZ8Ul9fIe14rtnrVAJTv1HeXmFoz6/fYhqBoYcO8AtIGjj
	lUTm0088ftd1Y3mIwta3VKNswdbZgQRKPEGx4ZPFxk/2FgjI9HCfJAYyPm0Yvbydwot0=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165829-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 165829: regressions - FAIL
X-Osstest-Failures:
    libvirt:build-armhf-libvirt:libvirt-build:fail:regression
    libvirt:build-amd64-libvirt:libvirt-build:fail:regression
    libvirt:build-i386-libvirt:libvirt-build:fail:regression
    libvirt:build-arm64-libvirt:libvirt-build:fail:regression
    libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    libvirt=945942ebba943e6addd6c8163d6e38a4a7df7b8f
X-Osstest-Versions-That:
    libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 24 Oct 2021 07:35:45 +0000

flight 165829 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165829/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-armhf-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-amd64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-i386-libvirt            6 libvirt-build            fail REGR. vs. 151777
 build-arm64-libvirt           6 libvirt-build            fail REGR. vs. 151777

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-libvirt-vhd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a

version targeted for testing:
 libvirt              945942ebba943e6addd6c8163d6e38a4a7df7b8f
baseline version:
 libvirt              2c846fa6bcc11929c9fb857a22430fb9945654ad

Last test of basis   151777  2020-07-10 04:19:19 Z  471 days
Failing since        151818  2020-07-11 04:18:52 Z  470 days  456 attempts
Testing same since   165803  2021-10-23 04:19:02 Z    1 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
    Adolfo Jayme Barrientos <fitoschido@gmail.com>
  Aleksandr Alekseev <alexander.alekseev@virtuozzo.com>
  Aleksei Zakharov <zaharov@selectel.ru>
  Andika Triwidada <andika@gmail.com>
  Andrea Bolognani <abologna@redhat.com>
  Ani Sinha <ani@anisinha.ca>
  Balázs Meskó <meskobalazs@mailbox.org>
  Barrett Schonefeld <bschoney@utexas.edu>
  Bastian Germann <bastiangermann@fishpost.de>
  Bastien Orivel <bastien.orivel@diateam.net>
  BiaoXiang Ye <yebiaoxiang@huawei.com>
  Bihong Yu <yubihong@huawei.com>
  Binfeng Wu <wubinfeng@huawei.com>
  Bjoern Walk <bwalk@linux.ibm.com>
  Boris Fiuczynski <fiuczy@linux.ibm.com>
  Brian Turek <brian.turek@gmail.com>
  Bruno Haible <bruno@clisp.org>
  Chris Mayo <aklhfex@gmail.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Ehrhardt <christian.ehrhardt@canonical.com>
  Christian Kirbach <christian.kirbach@gmail.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Cole Robinson <crobinso@redhat.com>
  Collin Walling <walling@linux.ibm.com>
  Cornelia Huck <cohuck@redhat.com>
  Cédric Bosdonnat <cbosdonnat@suse.com>
  Côme Borsoi <fedora@borsoi.fr>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniel Letai <dani@letai.org.il>
  Daniel P. Berrange <berrange@redhat.com>
  Daniel P. Berrangé <berrange@redhat.com>
  Didik Supriadi <didiksupriadi41@gmail.com>
  dinglimin <dinglimin@cmss.chinamobile.com>
  Dmitrii Shcherbakov <dmitrii.shcherbakov@canonical.com>
  Dmytro Linkin <dlinkin@nvidia.com>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Eric Farman <farman@linux.ibm.com>
  Erik Skultety <eskultet@redhat.com>
  Fabian Affolter <mail@fabian-affolter.ch>
  Fabian Freyer <fabian.freyer@physik.tu-berlin.de>
  Fabiano Fidêncio <fabiano@fidencio.org>
  Fangge Jin <fjin@redhat.com>
  Farhan Ali <alifm@linux.ibm.com>
  Fedora Weblate Translation <i18n@lists.fedoraproject.org>
  Gavi Teitz <gavi@nvidia.com>
  gongwei <gongwei@smartx.com>
  Guoyi Tu<tu.guoyi@h3c.com>
  Göran Uddeborg <goeran@uddeborg.se>
  Halil Pasic <pasic@linux.ibm.com>
  Han Han <hhan@redhat.com>
  Hao Wang <wanghao232@huawei.com>
  Hela Basa <r45xveza@pm.me>
  Helmut Grohne <helmut@subdivi.de>
  Hiroki Narukawa <hnarukaw@yahoo-corp.jp>
  Ian Wienand <iwienand@redhat.com>
  Jakob Meng <jakobmeng@web.de>
  Jamie Strandboge <jamie@canonical.com>
  Jamie Strandboge <jamie@ubuntu.com>
  Jan Kuparinen <copper_fin@hotmail.com>
  jason lee <ppark5237@gmail.com>
  Jean-Baptiste Holcroft <jean-baptiste@holcroft.fr>
  Jia Zhou <zhou.jia2@zte.com.cn>
  Jianan Gao <jgao@redhat.com>
  Jim Fehlig <jfehlig@suse.com>
  Jin Yan <jinyan12@huawei.com>
  Jinsheng Zhang <zhangjl02@inspur.com>
  Jiri Denemark <jdenemar@redhat.com>
  John Ferlan <jferlan@redhat.com>
  Jonathan Watt <jwatt@jwatt.org>
  Jonathon Jongsma <jjongsma@redhat.com>
  Julio Faracco <jcfaracco@gmail.com>
  Justin Gatzen <justin.gatzen@gmail.com>
  Ján Tomko <jtomko@redhat.com>
  Kashyap Chamarthy <kchamart@redhat.com>
  Kevin Locke <kevin@kevinlocke.name>
  Kristina Hanicova <khanicov@redhat.com>
  Laine Stump <laine@redhat.com>
  Laszlo Ersek <lersek@redhat.com>
  Lee Yarwood <lyarwood@redhat.com>
  Lei Yang <yanglei209@huawei.com>
  Liao Pingfang <liao.pingfang@zte.com.cn>
  Lin Ma <lma@suse.com>
  Lin Ma <lma@suse.de>
  Lin Ma <morecache@gmail.com>
  Liu Yiding <liuyd.fnst@fujitsu.com>
  Luke Yue <lukedyue@gmail.com>
  Luyao Zhong <luyao.zhong@intel.com>
  Marc Hartmayer <mhartmay@linux.ibm.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Markus Schade <markus.schade@hetzner.com>
  Martin Kletzander <mkletzan@redhat.com>
  Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
  Matej Cepl <mcepl@cepl.eu>
  Matt Coleman <matt@datto.com>
  Matt Coleman <mcoleman@datto.com>
  Mauro Matteo Cascella <mcascell@redhat.com>
  Meina Li <meili@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Michał Smyk <fedora@smyk.it>
  Milo Casagrande <milo@milo.name>
  Moshe Levi <moshele@nvidia.com>
  Muha Aliss <muhaaliss@gmail.com>
  Nathan <nathan95@live.it>
  Neal Gompa <ngompa13@gmail.com>
  Nick Chevsky <nchevsky@gmail.com>
  Nick Shyrokovskiy <nshyrokovskiy@gmail.com>
  Nickys Music Group <nickys.music.group@gmail.com>
  Nico Pache <npache@redhat.com>
  Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
  Olaf Hering <olaf@aepfle.de>
  Olesya Gerasimenko <gammaray@basealt.ru>
  Orion Poplawski <orion@nwra.com>
  Pany <geekpany@gmail.com>
  Patrick Magauran <patmagauran.j@gmail.com>
  Paulo de Rezende Pinatti <ppinatti@linux.ibm.com>
  Pavel Hrdina <phrdina@redhat.com>
  Peng Liang <liangpeng10@huawei.com>
  Peter Krempa <pkrempa@redhat.com>
  Pino Toscano <ptoscano@redhat.com>
  Pino Toscano <toscano.pino@tiscali.it>
  Piotr Drąg <piotrdrag@gmail.com>
  Prathamesh Chavan <pc44800@gmail.com>
  Praveen K Paladugu <prapal@linux.microsoft.com>
  Richard W.M. Jones <rjones@redhat.com>
  Ricky Tigg <ricky.tigg@gmail.com>
  Robin Lee <cheeselee@fedoraproject.org>
  Roman Bogorodskiy <bogorodskiy@gmail.com>
  Roman Bolshakov <r.bolshakov@yadro.com>
  Ryan Gahagan <rgahagan@cs.utexas.edu>
  Ryan Schmidt <git@ryandesign.com>
  Sam Hartman <hartmans@debian.org>
  Scott Shambarger <scott-libvirt@shambarger.net>
  Sebastian Mitterle <smitterl@redhat.com>
  SeongHyun Jo <caelus9536@gmail.com>
  Shalini Chellathurai Saroja <shalini@linux.ibm.com>
  Shaojun Yang <yangshaojun@phytium.com.cn>
  Shi Lei <shi_lei@massclouds.com>
  simmon <simmon@nplob.com>
  Simon Chopin <chopin.simon@gmail.com>
  Simon Gaiser <simon@invisiblethingslab.com>
  Simon Rowe <simon.rowe@nutanix.com>
  Stefan Bader <stefan.bader@canonical.com>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Berger <stefanb@linux.vnet.ibm.com>
  Stefan Hajnoczi <stefanha@gmail.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Szymon Scholz <szymonscholz@gmail.com>
  Thomas Huth <thuth@redhat.com>
  Tim Wiederhake <twiederh@redhat.com>
  Tomáš Golembiovský <tgolembi@redhat.com>
  Tomáš Janoušek <tomi@nomi.cz>
  Tuguoyi <tu.guoyi@h3c.com>
  Victor Toso <victortoso@redhat.com>
  Ville Skyttä <ville.skytta@iki.fi>
  Vinayak Kale <vkale@nvidia.com>
  Wang Xin <wangxinxin.wang@huawei.com>
  WangJian <wangjian161@huawei.com>
  Weblate <noreply@weblate.org>
  Wei Liu <liuwe@microsoft.com>
  Wei Liu <wei.liu@kernel.org>
  Wei-Chen Chen <weicche@microsoft.com>
  William Douglas <william.douglas@intel.com>
  Yalei Li <274268859@qq.com>
  Yalei Li <liyl43@chinatelecom.cn>
  Yang Fei <yangfei85@huawei.com>
  Yang Hang <yanghang44@huawei.com>
  Yanqiu Zhang <yanqzhan@redhat.com>
  Yaroslav Kargin <ykargin@virtuozzo.com>
  Yi Li <yili@winhong.com>
  Yi Wang <wang.yi59@zte.com.cn>
  Yuri Chornoivan <yurchor@ukr.net>
  Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
  zhangjl02 <zhangjl02@inspur.com>
  Zheng Chuan <zhengchuan@huawei.com>
  zhenwei pi <pizhenwei@bytedance.com>
  Zhenyu Ye <yezhenyu2@huawei.com>
  Zhenyu Zheng <zheng.zhenyu@outlook.com>
  Zhenzhong Duan <zhenzhong.duan@intel.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          fail    
 build-arm64-libvirt                                          fail    
 build-armhf-libvirt                                          fail    
 build-i386-libvirt                                           fail    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           blocked 
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-libvirt-xsm                                 blocked 
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-libvirt                                     blocked 
 test-arm64-arm64-libvirt                                     blocked 
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-libvirt-pair                                blocked 
 test-amd64-i386-libvirt-pair                                 blocked 
 test-arm64-arm64-libvirt-qcow2                               blocked 
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-libvirt-vhd                                 blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 80474 lines long.)


From xen-devel-bounces@lists.xenproject.org Sun Oct 24 08:45:46 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 24 Oct 2021 08:45:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.215484.374717 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1meZ8H-0007WG-Mm; Sun, 24 Oct 2021 08:45:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 215484.374717; Sun, 24 Oct 2021 08:45:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1meZ8H-0007W9-JP; Sun, 24 Oct 2021 08:45:33 +0000
Received: by outflank-mailman (input) for mailman id 215484;
 Sun, 24 Oct 2021 08:45:32 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1meZ8F-0007Vz-VF; Sun, 24 Oct 2021 08:45:31 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1meZ8F-0005xW-NL; Sun, 24 Oct 2021 08:45:31 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1meZ8F-0002AK-AF; Sun, 24 Oct 2021 08:45:31 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1meZ8F-0006Yb-9k; Sun, 24 Oct 2021 08:45:31 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=cQAYOhbEzPA6hvLTpEkZDEKsGOHvY+C2hPY8bvh+cAI=; b=BZV4ckXCSrLWBbzDTO9MthFiSw
	mbHYqWsWToKyyPHsT6V5U6j9T5PDlhKV9HQD+VdOVJ6i9NdQIUJ65ERw7KGj9SyCfQRz0mJxYGYwx
	IxiX6u70+orN+xZRqPILR4i8mS+XBWTtXfwPfUPenUz2fbDgsFUjiSAI0Wvdpiq67dTM=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165823-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 165823: regressions - FAIL
X-Osstest-Failures:
    qemu-mainline:build-i386:xen-build:fail:regression
    qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:regression
    qemu-mainline:build-i386-xsm:xen-build:fail:regression
    qemu-mainline:build-armhf:xen-build:fail:regression
    qemu-mainline:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-amd:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-pair:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-freebsd10-i386:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-freebsd10-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-coresched-i386-xl:build-check(1):blocked:nonblocking
    qemu-mainline:build-armhf-libvirt:build-check(1):blocked:nonblocking
    qemu-mainline:build-i386-libvirt:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-intel:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-shadow:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-vhd:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=c5b2f559814104f4145f8bc310f4d33c7ead8f49
X-Osstest-Versions-That:
    qemuu=50352cce138ef3b30c1cda28a4df68fff5da3202
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 24 Oct 2021 08:45:31 +0000

flight 165823 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165823/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-i386                    6 xen-build                fail REGR. vs. 165682
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 165682
 build-i386-xsm                6 xen-build                fail REGR. vs. 165682
 build-armhf                   6 xen-build                fail REGR. vs. 165682

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl           1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-credit2   1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-cubietruck  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-multivcpu  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-rtds      1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-vhd       1 build-check(1)               blocked  n/a
 test-amd64-i386-qemuu-rhel6hvm-amd  1 build-check(1)               blocked n/a
 test-amd64-i386-pair          1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-freebsd10-i386  1 build-check(1)               blocked  n/a
 test-amd64-i386-freebsd10-amd64  1 build-check(1)               blocked  n/a
 test-amd64-coresched-i386-xl  1 build-check(1)               blocked  n/a
 build-armhf-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-credit1   1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-arndale   1 build-check(1)               blocked  n/a
 test-amd64-i386-qemuu-rhel6hvm-intel  1 build-check(1)             blocked n/a
 test-amd64-i386-xl            1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-pvshim     1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-qemuu-debianhvm-amd64  1 build-check(1)         blocked n/a
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow  1 build-check(1)  blocked n/a
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm  1 build-check(1)      blocked n/a
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 1 build-check(1) blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a
 test-amd64-i386-xl-qemuu-win7-amd64  1 build-check(1)              blocked n/a
 test-amd64-i386-xl-qemuu-ws16-amd64  1 build-check(1)              blocked n/a
 test-amd64-i386-xl-shadow     1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-vhd        1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-xsm        1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165682
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165682
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165682
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 qemuu                c5b2f559814104f4145f8bc310f4d33c7ead8f49
baseline version:
 qemuu                50352cce138ef3b30c1cda28a4df68fff5da3202

Last test of basis   165682  2021-10-19 21:09:14 Z    4 days
Failing since        165694  2021-10-20 18:09:12 Z    3 days    9 attempts
Testing same since   165823  2021-10-24 00:36:48 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Alistair Francis <alistair.francis@wdc.com>
  Andrew Jones <drjones@redhat.com>
  Ani Sinha <ani@anisinha.ca>
  BALATON Zoltan <balaton@eik.bme.hu>
  Bin Meng <bmeng.cn@gmail.com>
  Cédric Le Goater <clg@kaod.org>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  David Gibson <david@gibson.dropbear.id.au>
  David Hildenbrand <david@redhat.com>
  Eric Auger <eric.auger@redhat.com>
  Eugenio Pérez <eperezma@redhat.com>
  Frank Chang <frank.chang@sifive.com>
  Gavin Shan <gshan@redhat.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Greg Kurz <groug@kaod.org>
  Gustavo Romero <gromero@linux.ibm.com>
  Igor Mammedov <imammedo@redhat.com>
  Jason Wang <jasowang@redhat.com>
  John Wang <wangzhiqiang02@inspur.com>
  John Wang <wangzq.jn@gmail.com>
  Laurent Vivier <laurent@vivier.eu>
  Laurent Vivier <lvivier@redhat.com>
  Luc Michel <lmichel@kalray.eu>
  Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
  Matheus Ferst <matheus.ferst@eldorado.org.br>
  Mathieu Poirier <mathieu.poirier@linaro.org>
  Michael S. Tsirkin <mst@redhat.com>
  Mingwang Li <limingwang@huawei.com>
  Oğuz Ersen <oguzersen@protonmail.com>
  Philipp Tomsich <philipp.tomsich@vrull.eu>
  Philippe Mathieu-Daudé <f4bug@amsat.org>
  Philippe Mathieu-Daudé <philmd@redhat.com>
  Richard Henderson <richard.henderson@linaro.org>
  Shuuichirou Ishii <ishii.shuuichir@fujitsu.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Thomas Huth <thuth@redhat.com>
  Tong Ho <tong.ho@xilinx.com>
  Travis Geiselbrecht <travisg@gmail.com>
  Vincent Palatin <vpalatin@rivosinc.com>
  Xueming Li <xuemingl@nvidia.com>
  Yanan Wang <wangyanan55@huawei.com>
  Yifei Jiang <jiangyifei@huawei.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               fail    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          blocked 
 test-amd64-i386-xl                                           blocked 
 test-amd64-coresched-i386-xl                                 blocked 
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 fail    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  blocked 
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       blocked 
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           blocked 
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     blocked 
 test-amd64-i386-freebsd10-amd64                              blocked 
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          blocked 
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          blocked 
 test-armhf-armhf-xl-arndale                                  blocked 
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  blocked 
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  blocked 
 test-armhf-armhf-xl-cubietruck                               blocked 
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         blocked 
 test-amd64-i386-freebsd10-i386                               blocked 
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         blocked 
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                blocked 
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         blocked 
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 blocked 
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    blocked 
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     blocked 
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              blocked 
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    blocked 
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      blocked 
 test-amd64-i386-xl-vhd                                       blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 3631 lines long.)


From xen-devel-bounces@lists.xenproject.org Sun Oct 24 10:09:33 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 24 Oct 2021 10:09:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.215496.374737 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1meaRN-0006h0-3c; Sun, 24 Oct 2021 10:09:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 215496.374737; Sun, 24 Oct 2021 10:09:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1meaRN-0006gt-0a; Sun, 24 Oct 2021 10:09:21 +0000
Received: by outflank-mailman (input) for mailman id 215496;
 Sun, 24 Oct 2021 10:09:20 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1meaRM-0006gj-KO; Sun, 24 Oct 2021 10:09:20 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1meaRM-0007OS-CO; Sun, 24 Oct 2021 10:09:20 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1meaRM-00074j-2Z; Sun, 24 Oct 2021 10:09:20 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1meaRM-0002go-1s; Sun, 24 Oct 2021 10:09:20 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=Sd+juyZDDlyRAElDV/XkKDy07SXKKqpiX3CRTJ2c59Y=; b=iAB5RBl0u5R0tYFUP37n0Pt4r8
	C4tGTTiAUnxcGAzLrWnEa6txh8XUble5km5WUm9GyGmOpqU2NayA2ScdQnSNxJhCUTqFCfsWkokqe
	T0OdGPWSwM5tT7N3En0nbHYR15nk7KJJP6Y1k7A/xjkBlIEZui2D0RpOpuF7BVdBB5SQ=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165836-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-coverity test] 165836: all pass - PUSHED
X-Osstest-Versions-This:
    xen=23ec1ebc8acbfd2bf06f6085a776f0db923f9fa9
X-Osstest-Versions-That:
    xen=6809998c5f8f1d2e26ac9e867af8ac71e7a66cf2
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 24 Oct 2021 10:09:20 +0000

flight 165836 xen-unstable-coverity real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165836/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 xen                  23ec1ebc8acbfd2bf06f6085a776f0db923f9fa9
baseline version:
 xen                  6809998c5f8f1d2e26ac9e867af8ac71e7a66cf2

Last test of basis   165686  2021-10-20 09:20:50 Z    4 days
Testing same since   165836  2021-10-24 09:18:30 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Bertrand Marquis <bertrand.marquis@arm.com>
  Hongda Deng <hongda.deng@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Julien Grall <jgrall@amazon.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Thomas Gleixner <tglx@linutronix.de>

jobs:
 coverity-amd64                                               pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   6809998c5f..23ec1ebc8a  23ec1ebc8acbfd2bf06f6085a776f0db923f9fa9 -> coverity-tested/smoke


From xen-devel-bounces@lists.xenproject.org Sun Oct 24 10:13:11 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 24 Oct 2021 10:13:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.215504.374751 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1meaV4-00088B-OH; Sun, 24 Oct 2021 10:13:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 215504.374751; Sun, 24 Oct 2021 10:13:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1meaV4-000884-IW; Sun, 24 Oct 2021 10:13:10 +0000
Received: by outflank-mailman (input) for mailman id 215504;
 Sun, 24 Oct 2021 10:13:09 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=lf0h=PM=oderland.se=josef@srs-us1.protection.inumbo.net>)
 id 1meaV3-00087y-9u
 for xen-devel@lists.xenproject.org; Sun, 24 Oct 2021 10:13:09 +0000
Received: from office.oderland.com (unknown [91.201.60.5])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 10788d86-e798-4f5d-984b-cfe94b573988;
 Sun, 24 Oct 2021 10:12:58 +0000 (UTC)
Received: from [193.180.18.161] (port=49250 helo=[10.137.0.14])
 by office.oderland.com with esmtpsa (TLS1.2) tls
 TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2)
 (envelope-from <josef@oderland.se>)
 id 1meaUr-00FRGh-9J; Sun, 24 Oct 2021 12:12:57 +0200
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 10788d86-e798-4f5d-984b-cfe94b573988
Message-ID: <72ede4f0-c043-0fa3-0e8b-e03b23b21a75@oderland.se>
Date: Sun, 24 Oct 2021 12:12:53 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:93.0) Gecko/20100101
 Thunderbird/93.0
From: Josef Johansson <josef@oderland.se>
To: open list <linux-kernel@vger.kernel.org>,
 xen-devel <xen-devel@lists.xenproject.org>
Content-Language: en-US
Subject: Deadlock when CONFIG_LOCKDEP=y
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-AntiAbuse: This header was added to track abuse, please include it with any abuse report
X-AntiAbuse: Primary Hostname - office.oderland.com
X-AntiAbuse: Original Domain - lists.xenproject.org
X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12]
X-AntiAbuse: Sender Address Domain - oderland.se
X-Get-Message-Sender-Via: office.oderland.com: authenticated_id: josjoh@oderland.se
X-Authenticated-Sender: office.oderland.com: josjoh@oderland.se

Hi!

I'm running Qubes OS R4.1 which uses Xen as arch. Xen should be masking all
MSI/MSI-X which is why I am running through rabbit holes trying to
understand
why my laptop gets odd errors while suspend/resume.

Thus I'm building the kernel (v5.15-rc6) with a couple of debug-flags:

CONFIG_PCI_DEBUG=y
CONFIG_LOCKDEP=y
CONFIG_PROVE_LOCKING=y
CONFIG_DEBUG_SPINLOCK=y

When I do I get a massive deadlock dump during suspend/resume with the
dmesg
below. Not sure if this deadlock actually does anything, but the laptop is
usable afterwards albeit I'm not sure it's affecting irq/msi errors inside
amdgpu afterwards.

I see that different arch have workarounds when LOCKDEP is enabled, but
not Xen
from what I can tell. Is something odd here or is it just me missing
something?

For refence this is running on a Lenovo P14s with AMD Ryzen 7 Pro 4750U
that
has a Renoir chipset which uses amdgpu drivers (lspci -vvnn is also added
below).

Please advise if you would be so kind!

Regards
- Josef


dom0 kernel: cpu 4 spinlock event irq 85
dom0 kernel: [Firmware Bug]: ACPI MWAIT C-state 0x0 not supported by HW
(0x0)
dom0 kernel: ACPI: \_SB_.PLTF.C004: Found 3 idle states
dom0 kernel: ACPI: FW issue: working around C-state latencies out of order
dom0 kernel: CPU4 is up
dom0 kernel: installing Xen timer for CPU 5
dom0 kernel: cpu 5 spinlock event irq 91
dom0 kernel: [Firmware Bug]: ACPI MWAIT C-state 0x0 not supported by HW
(0x0)
dom0 kernel: ACPI: \_SB_.PLTF.C005: Found 3 idle states
dom0 kernel: ACPI: FW issue: working around C-state latencies out of order
dom0 kernel: CPU5 is up
dom0 kernel: installing Xen timer for CPU 6
dom0 kernel: cpu 6 spinlock event irq 97
dom0 kernel: [Firmware Bug]: ACPI MWAIT C-state 0x0 not supported by HW
(0x0)
dom0 kernel: ACPI: \_SB_.PLTF.C006: Found 3 idle states
dom0 kernel: ACPI: FW issue: working around C-state latencies out of order
dom0 kernel: CPU6 is up
dom0 kernel: ------------[ cut here ]------------
dom0 kernel: installing Xen timer for CPU 7
dom0 kernel:
dom0 kernel: ======================================================
dom0 kernel: WARNING: possible circular locking dependency detected
dom0 kernel: 5.15.0-0.rc6.0.fc32.qubes.x86_64 #1 Tainted: G       
W        --------- ---
dom0 kernel: ------------------------------------------------------
dom0 kernel: kworker/6:2/440 is trying to acquire lock:
dom0 kernel: ffffffff829628b8 ((console_sem).lock){-...}-{2:2}, at:
down_trylock+0xf/0x30
dom0 kernel:
                          but task is already holding lock:
dom0 kernel: ffff8881407ab558 (&rq->__lock){-.-.}-{2:2}, at:
raw_spin_rq_lock_nested+0x1e/0x80
dom0 kernel:
                          which lock already depends on the new lock.
dom0 kernel:
                          the existing dependency chain (in reverse
order) is:
dom0 kernel:
                          -> #2 (&rq->__lock){-.-.}-{2:2}:
dom0 kernel:        __lock_acquire+0x3a0/0x6b0
dom0 kernel:        lock_acquire+0xf5/0x300
dom0 kernel:        _raw_spin_lock_nested+0x2a/0x40
dom0 kernel:        raw_spin_rq_lock_nested+0x1e/0x80
dom0 kernel:        task_fork_fair+0x39/0x180
dom0 kernel:        sched_fork+0x115/0x290
dom0 kernel:        copy_process+0xd2a/0x2b70
dom0 kernel:        kernel_clone+0xa4/0x300
dom0 kernel:        kernel_thread+0x55/0x70
dom0 kernel:        rest_init+0x1e/0x280
dom0 kernel:        start_kernel+0x659/0x697
dom0 kernel:        xen_start_kernel+0x5fa/0x61b
dom0 kernel:        reset_early_page_tables+0x0/0x9d
dom0 kernel:
                          -> #1 (&p->pi_lock){-.-.}-{2:2}:
dom0 kernel:        __lock_acquire+0x3a0/0x6b0
dom0 kernel:        lock_acquire+0xf5/0x300
dom0 kernel:        _raw_spin_lock_irqsave+0x48/0x60
dom0 kernel:        try_to_wake_up+0x53/0x5f0
dom0 kernel:        up+0x40/0x60
dom0 kernel:        __up_console_sem+0x56/0x70
dom0 kernel:        console_unlock+0x2ae/0x3c0
dom0 kernel:        do_register_framebuffer+0x283/0x2f0
dom0 kernel:        register_framebuffer+0x20/0x40
dom0 kernel:        __drm_fb_helper_initial_config_and_unlock+0x94/0xc0
[drm_kms_helper]
dom0 kernel:        amdgpu_fbdev_init+0xc7/0x100 [amdgpu]
dom0 kernel:        amdgpu_device_init.cold+0x739/0xb0e [amdgpu]
dom0 kernel:        amdgpu_driver_load_kms+0x68/0x310 [amdgpu]
dom0 kernel:        amdgpu_pci_probe+0x116/0x1a0 [amdgpu]
dom0 kernel:        local_pci_probe+0x45/0x80
dom0 kernel:        pci_call_probe+0x51/0xf0
dom0 kernel:        pci_device_probe+0xa5/0xe0
dom0 kernel:        call_driver_probe+0x24/0xc0
dom0 kernel:        really_probe+0x1e7/0x310
dom0 kernel:        __driver_probe_device+0xfe/0x180
dom0 kernel:        driver_probe_device+0x1e/0x90
dom0 kernel:        __driver_attach+0xc4/0x1d0
dom0 kernel:        bus_for_each_dev+0x8c/0xd0
dom0 kernel:        bus_add_driver+0x12e/0x1f0
dom0 kernel:        driver_register+0x8f/0xe0
dom0 kernel:        do_one_initcall+0x6e/0x2f0
dom0 kernel:        do_init_module+0x5c/0x260
dom0 kernel:        __do_sys_finit_module+0xae/0x110
dom0 kernel:        do_syscall_64+0x3b/0x90
dom0 kernel:        entry_SYSCALL_64_after_hwframe+0x44/0xae
dom0 kernel:
                          -> #0 ((console_sem).lock){-...}-{2:2}:
dom0 kernel:        check_prev_add+0x8f/0xbf0
dom0 kernel:        validate_chain+0x38a/0x420
dom0 kernel:        __lock_acquire+0x3a0/0x6b0
dom0 kernel:        lock_acquire+0xf5/0x300
dom0 kernel:        _raw_spin_lock_irqsave+0x48/0x60
dom0 kernel:        down_trylock+0xf/0x30
dom0 kernel:        __down_trylock_console_sem+0x32/0xa0
dom0 kernel:        console_trylock_spinning+0x13/0x1e0
dom0 kernel:        vprintk_emit+0xa8/0x160
dom0 kernel:        _printk+0x68/0x7f
dom0 kernel:        __warn_printk+0x51/0x93
dom0 kernel:        __update_blocked_fair+0x4f4/0x510
dom0 kernel:        update_blocked_averages+0xe3/0x280
dom0 kernel:        newidle_balance+0x160/0x600
dom0 kernel:        pick_next_task_fair+0x39/0x3f0
dom0 kernel:        pick_next_task+0x4c/0xbb0
dom0 kernel:        __schedule+0x135/0x600
dom0 kernel:        schedule+0x59/0xc0
dom0 kernel:        worker_thread+0xb3/0x310
dom0 kernel:        kthread+0x120/0x140
dom0 kernel:        ret_from_fork+0x22/0x30
dom0 kernel:
                          other info that might help us debug this:
dom0 kernel: Chain exists of:
                            (console_sem).lock --> &p->pi_lock -->
&rq->__lock
dom0 kernel:  Possible unsafe locking scenario:
dom0 kernel:        CPU0                    CPU1
dom0 kernel:        ----                    ----
dom0 kernel:   lock(&rq->__lock);
dom0 kernel:                                lock(&p->pi_lock);
dom0 kernel:                                lock(&rq->__lock);
dom0 kernel:   lock((console_sem).lock);
dom0 kernel:
                           *** DEADLOCK ***
dom0 kernel: 1 lock held by kworker/6:2/440:
dom0 kernel:  #0: ffff8881407ab558 (&rq->__lock){-.-.}-{2:2}, at:
raw_spin_rq_lock_nested+0x1e/0x80
dom0 kernel:
                          stack backtrace:
dom0 kernel: CPU: 6 PID: 440 Comm: kworker/6:2 Tainted: G       
W        --------- ---  5.15.0-0.rc6.0.fc32.qubes.x86_64 #1
dom0 kernel: Hardware name: LENOVO 20Y1S02400/20Y1S02400, BIOS
R1BET65W(1.34 ) 06/17/2021
dom0 kernel: Workqueue:  0x0 (events)
dom0 kernel: Call Trace:
dom0 kernel:  dump_stack_lvl+0x57/0x72
dom0 kernel:  check_noncircular+0x10a/0x120
dom0 kernel:  check_prev_add+0x8f/0xbf0
dom0 kernel:  ? add_chain_cache+0x10d/0x2d0
dom0 kernel:  validate_chain+0x38a/0x420
dom0 kernel:  __lock_acquire+0x3a0/0x6b0
dom0 kernel:  lock_acquire+0xf5/0x300
dom0 kernel:  ? down_trylock+0xf/0x30
dom0 kernel:  ? vprintk_emit+0xa8/0x160
dom0 kernel:  _raw_spin_lock_irqsave+0x48/0x60
dom0 kernel:  ? down_trylock+0xf/0x30
dom0 kernel:  down_trylock+0xf/0x30
dom0 kernel:  ? vprintk_emit+0xa8/0x160
dom0 kernel:  __down_trylock_console_sem+0x32/0xa0
dom0 kernel:  console_trylock_spinning+0x13/0x1e0
dom0 kernel:  vprintk_emit+0xa8/0x160
dom0 kernel:  _printk+0x68/0x7f
dom0 kernel:  __warn_printk+0x51/0x93
dom0 kernel:  ? lock_is_held_type+0xa5/0x120
dom0 kernel:  __update_blocked_fair+0x4f4/0x510
dom0 kernel:  update_blocked_averages+0xe3/0x280
dom0 kernel:  newidle_balance+0x160/0x600
dom0 kernel:  pick_next_task_fair+0x39/0x3f0
dom0 kernel:  pick_next_task+0x4c/0xbb0
dom0 kernel:  ? dequeue_task_fair+0xd1/0x4a0
dom0 kernel:  __schedule+0x135/0x600
dom0 kernel:  schedule+0x59/0xc0
dom0 kernel:  worker_thread+0xb3/0x310
dom0 kernel:  ? process_one_work+0x590/0x590
dom0 kernel:  kthread+0x120/0x140
dom0 kernel:  ? set_kthread_struct+0x40/0x40
dom0 kernel:  ret_from_fork+0x22/0x30
dom0 kernel: cfs_rq->avg.load_avg || cfs_rq->avg.util_avg ||
cfs_rq->avg.runnable_avg
dom0 kernel: WARNING: CPU: 6 PID: 440 at kernel/sched/fair.c:3339
__update_blocked_fair+0x4f4/0x510
dom0 kernel: Modules linked in: snd_seq_dummy snd_hrtimer snd_seq
snd_seq_device snd_timer nf_tables nfnetlink vfat fat intel_rapl_msr
think_lmi wmi_bmof firmware_attributes_class intel_rapl_common pcspkr
uvcvideo joydev videobuf2_vmalloc videobuf2_memops videobuf2_v4l2
videobuf2_common k10temp videodev iwlwifi mc sp5100_tco i2c_piix4
cfg80211 ipmi_devintf ipmi_msghandler r8169 thinkpad_acpi
platform_profile ledtrig_audio rfkill snd soundcore video ucsi_acpi
typec_ucsi typec wmi i2c_scmi fuse xenfs ip_tables dm_thin_pool
dm_persistent_data dm_bio_prison dm_crypt trusted asn1_encoder
hid_multitouch amdgpu crct10dif_pclmul crc32_pclmul crc32c_intel
gpu_sched i2c_algo_bit drm_ttm_helper ghash_clmulni_intel ttm sdhci_pci
nvme cqhci serio_raw drm_kms_helper xhci_pci sdhci cec xhci_pci_renesas
ehci_pci mmc_core xhci_hcd drm ehci_hcd nvme_core xen_acpi_processor
xen_privcmd xen_pciback xen_blkback xen_gntalloc xen_gntdev xen_evtchn
uinput
dom0 kernel: CPU: 6 PID: 440 Comm: kworker/6:2 Tainted: G       
W        --------- ---  5.15.0-0.rc6.0.fc32.qubes.x86_64 #1
dom0 kernel: Hardware name: LENOVO 20Y1S02400/20Y1S02400, BIOS
R1BET65W(1.34 ) 06/17/2021
dom0 kernel: Workqueue:  0x0 (events)
dom0 kernel: RIP: e030:__update_blocked_fair+0x4f4/0x510
dom0 kernel: Code: 01 00 00 48 89 90 08 0a 00 00 e9 e6 fc ff ff 45 31 ff
e9 70 ff ff ff 48 c7 c7 48 dc 5f 82 c6 05 a7 5f ab 01 01 e8 93 19 c4 00
<0f> 0b 41 8b 86 78 01 00 00 e9 a5 fc ff ff 66 66 2e 0f 1f 84 00 00
dom0 kernel: RSP: e02b:ffffc900403f3cc0 EFLAGS: 00010082
dom0 kernel: RAX: 0000000000000000 RBX: ffff8881407abdb8 RCX:
ffff888140798dd8
dom0 kernel: RDX: 00000000ffffffd8 RSI: 0000000000000027 RDI:
ffff888140798dd0
dom0 kernel: RBP: ffff8881407ab780 R08: 0000000000000001 R09:
0000000000000000
dom0 kernel: R10: 0000000000000000 R11: ffffc900403f353d R12:
0000000000000030
dom0 kernel: R13: ffff8881407abf38 R14: ffff8881407ab600 R15:
0000000dfd9b4181
dom0 kernel: FS:  0000000000000000(0000) GS:ffff888140780000(0000)
knlGS:0000000000000000
dom0 kernel: CS:  10000e030 DS: 0000 ES: 0000 CR0: 0000000080050033
dom0 kernel: CR2: 000059eb0e9ecc36 CR3: 0000000002826000 CR4:
0000000000050660
dom0 kernel: Call Trace:
dom0 kernel:  update_blocked_averages+0xe3/0x280
dom0 kernel:  newidle_balance+0x160/0x600
dom0 kernel:  pick_next_task_fair+0x39/0x3f0
dom0 kernel:  pick_next_task+0x4c/0xbb0
dom0 kernel:  ? dequeue_task_fair+0xd1/0x4a0
dom0 kernel:  __schedule+0x135/0x600
dom0 kernel:  schedule+0x59/0xc0
dom0 kernel:  worker_thread+0xb3/0x310
dom0 kernel:  ? process_one_work+0x590/0x590
dom0 kernel:  kthread+0x120/0x140
dom0 kernel:  ? set_kthread_struct+0x40/0x40
dom0 kernel:  ret_from_fork+0x22/0x30
dom0 kernel: irq event stamp: 70
dom0 kernel: hardirqs last  enabled at (69): [<ffffffff81dfcdb4>]
_raw_spin_unlock_irq+0x24/0x40
dom0 kernel: hardirqs last disabled at (70): [<ffffffff81df4dea>]
__schedule+0x3aa/0x600
dom0 kernel: softirqs last  enabled at (0): [<ffffffff810f01a6>]
copy_process+0xc36/0x2b70
dom0 kernel: softirqs last disabled at (0): [<0000000000000000>] 0x0
dom0 kernel: ---[ end trace 7964a38470c363ee ]---
dom0 kernel: cpu 7 spinlock event irq 103
dom0 kernel: [Firmware Bug]: ACPI MWAIT C-state 0x0 not supported by HW
(0x0)
dom0 kernel: ACPI: \_SB_.PLTF.C007: Found 3 idle states
dom0 kernel: ACPI: FW issue: working around C-state latencies out of order
dom0 kernel: CPU7 is up
dom0 kernel: ACPI: PM: Waking up from system sleep state S3
dom0 kernel: ACPI: EC: interrupt unblocked
dom0 kernel: pci 0000:00:00.2: restoring config space at offset 0x3c
(was 0x100, writing 0x1ff)
dom0 kernel: pci 0000:00:00.2: restoring config space at offset 0x4 (was
0x100004, writing 0x100000)
--
dom0 kernel: xen_acpi_processor: (_PXX): Hypervisor error (-19) for ACPI
CPU5
dom0 kernel: xen_acpi_processor: (_PXX): Hypervisor error (-19) for ACPI
CPU7
dom0 kernel: xen_acpi_processor: (_PXX): Hypervisor error (-19) for ACPI
CPU9
dom0 kernel: xen_acpi_processor: (_PXX): Hypervisor error (-19) for ACPI
CPU11
dom0 kernel: xen_acpi_processor: (_PXX): Hypervisor error (-19) for ACPI
CPU13
dom0 kernel: xen_acpi_processor: (_PXX): Hypervisor error (-19) for ACPI
CPU15
dom0 kernel: cpu 1 spinlock event irq 67
dom0 kernel: [Firmware Bug]: ACPI MWAIT C-state 0x0 not supported by HW
(0x0)
dom0 kernel: ACPI: \_SB_.PLTF.C001: Found 3 idle states
dom0 kernel: ACPI: FW issue: working around C-state latencies out of order
dom0 kernel: CPU1 is up
dom0 kernel: installing Xen timer for CPU 2
dom0 kernel: cpu 2 spinlock event irq 73
dom0 kernel: [Firmware Bug]: ACPI MWAIT C-state 0x0 not supported by HW
(0x0)
dom0 kernel: ACPI: \_SB_.PLTF.C002: Found 3 idle states
dom0 kernel: ACPI: FW issue: working around C-state latencies out of order
dom0 kernel: CPU2 is up
dom0 kernel: ------------[ cut here ]------------
dom0 kernel: installing Xen timer for CPU 3
dom0 kernel:
dom0 kernel: ======================================================
dom0 kernel: WARNING: possible circular locking dependency detected
dom0 kernel: 5.15.0-0.rc6.0.fc32.qubes.x86_64 #1 Tainted: G       
W        --------- ---
dom0 kernel: ------------------------------------------------------
dom0 kernel: kworker/2:2/600 is trying to acquire lock:
dom0 kernel: ffffffff829628b8 ((console_sem).lock){-...}-{2:2}, at:
down_trylock+0xf/0x30
dom0 kernel:
                          but task is already holding lock:
dom0 kernel: ffff8881406ab558 (&rq->__lock){-.-.}-{2:2}, at:
raw_spin_rq_lock_nested+0x1e/0x80
dom0 kernel:
                          which lock already depends on the new lock.
dom0 kernel:
                          the existing dependency chain (in reverse
order) is:
dom0 kernel:
                          -> #2 (&rq->__lock){-.-.}-{2:2}:
dom0 kernel:        __lock_acquire+0x3a0/0x6b0
dom0 kernel:        lock_acquire+0xf5/0x300
dom0 kernel:        _raw_spin_lock_nested+0x2a/0x40
dom0 kernel:        raw_spin_rq_lock_nested+0x1e/0x80
dom0 kernel:        task_fork_fair+0x39/0x180
dom0 kernel:        sched_fork+0x115/0x290
dom0 kernel:        copy_process+0xd2a/0x2b70
dom0 kernel:        kernel_clone+0xa4/0x300
dom0 kernel:        kernel_thread+0x55/0x70
dom0 kernel:        rest_init+0x1e/0x280
dom0 kernel:        start_kernel+0x659/0x697
dom0 kernel:        xen_start_kernel+0x5fa/0x61b
dom0 kernel:        reset_early_page_tables+0x0/0x9d
dom0 kernel:
                          -> #1 (&p->pi_lock){-.-.}-{2:2}:
dom0 kernel:        __lock_acquire+0x3a0/0x6b0
dom0 kernel:        lock_acquire+0xf5/0x300
dom0 kernel:        _raw_spin_lock_irqsave+0x48/0x60
dom0 kernel:        try_to_wake_up+0x53/0x5f0
dom0 kernel:        up+0x40/0x60
dom0 kernel:        __up_console_sem+0x56/0x70
dom0 kernel:        console_unlock+0x2ae/0x3c0
dom0 kernel:        do_con_write+0x28a/0x550
dom0 kernel:        con_write+0x10/0x30
dom0 kernel:        process_output_block+0x8b/0x1a0
dom0 kernel:        n_tty_write+0x194/0x3c0
dom0 kernel:        do_tty_write+0x137/0x270
dom0 kernel:        file_tty_write.constprop.0+0x8d/0xb0
dom0 kernel:        new_sync_write+0x15f/0x1f0
dom0 kernel:        vfs_write+0x243/0x350
dom0 kernel:        ksys_write+0x70/0xf0
dom0 kernel:        do_syscall_64+0x3b/0x90
dom0 kernel:        entry_SYSCALL_64_after_hwframe+0x44/0xae
dom0 kernel:
                          -> #0 ((console_sem).lock){-...}-{2:2}:
dom0 kernel:        check_prev_add+0x8f/0xbf0
dom0 kernel:        validate_chain+0x38a/0x420
dom0 kernel:        __lock_acquire+0x3a0/0x6b0
dom0 kernel:        lock_acquire+0xf5/0x300
dom0 kernel:        _raw_spin_lock_irqsave+0x48/0x60
dom0 kernel:        down_trylock+0xf/0x30
dom0 kernel:        __down_trylock_console_sem+0x32/0xa0
dom0 kernel:        console_trylock_spinning+0x13/0x1e0
dom0 kernel:        vprintk_emit+0xa8/0x160
dom0 kernel:        _printk+0x68/0x7f
dom0 kernel:        __warn_printk+0x51/0x93
dom0 kernel:        __update_blocked_fair+0x4f4/0x510
dom0 kernel:        update_blocked_averages+0xe3/0x280
dom0 kernel:        newidle_balance+0x160/0x600
dom0 kernel:        pick_next_task_fair+0x39/0x3f0
dom0 kernel:        pick_next_task+0x4c/0xbb0
dom0 kernel:        __schedule+0x135/0x600
dom0 kernel:        schedule+0x59/0xc0
dom0 kernel:        worker_thread+0xb3/0x310
dom0 kernel:        kthread+0x120/0x140
dom0 kernel:        ret_from_fork+0x22/0x30
dom0 kernel:
                          other info that might help us debug this:
dom0 kernel: Chain exists of:
                            (console_sem).lock --> &p->pi_lock -->
&rq->__lock
dom0 kernel:  Possible unsafe locking scenario:
dom0 kernel:        CPU0                    CPU1
dom0 kernel:        ----                    ----
dom0 kernel:   lock(&rq->__lock);
dom0 kernel:                                lock(&p->pi_lock);
dom0 kernel:                                lock(&rq->__lock);
dom0 kernel:   lock((console_sem).lock);
dom0 kernel:
                           *** DEADLOCK ***
dom0 kernel: 1 lock held by kworker/2:2/600:
dom0 kernel:  #0: ffff8881406ab558 (&rq->__lock){-.-.}-{2:2}, at:
raw_spin_rq_lock_nested+0x1e/0x80
dom0 kernel:
                          stack backtrace:
dom0 kernel: CPU: 2 PID: 600 Comm: kworker/2:2 Tainted: G       
W        --------- ---  5.15.0-0.rc6.0.fc32.qubes.x86_64 #1
dom0 kernel: Hardware name: LENOVO 20Y1S02400/20Y1S02400, BIOS
R1BET65W(1.34 ) 06/17/2021
dom0 kernel: Workqueue:  0x0 (events)
dom0 kernel: Call Trace:
dom0 kernel:  dump_stack_lvl+0x57/0x72
dom0 kernel:  check_noncircular+0x10a/0x120
dom0 kernel:  check_prev_add+0x8f/0xbf0
dom0 kernel:  ? add_chain_cache+0x10d/0x2d0
dom0 kernel:  validate_chain+0x38a/0x420
dom0 kernel:  __lock_acquire+0x3a0/0x6b0
dom0 kernel:  lock_acquire+0xf5/0x300
dom0 kernel:  ? down_trylock+0xf/0x30
dom0 kernel:  ? vprintk_emit+0xa8/0x160
dom0 kernel:  _raw_spin_lock_irqsave+0x48/0x60
dom0 kernel:  ? down_trylock+0xf/0x30
dom0 kernel:  down_trylock+0xf/0x30
dom0 kernel:  ? vprintk_emit+0xa8/0x160
dom0 kernel:  __down_trylock_console_sem+0x32/0xa0
dom0 kernel:  console_trylock_spinning+0x13/0x1e0
dom0 kernel:  vprintk_emit+0xa8/0x160
dom0 kernel:  _printk+0x68/0x7f
dom0 kernel:  __warn_printk+0x51/0x93
dom0 kernel:  ? lock_is_held_type+0xa5/0x120
dom0 kernel:  __update_blocked_fair+0x4f4/0x510
dom0 kernel:  update_blocked_averages+0xe3/0x280
dom0 kernel:  newidle_balance+0x160/0x600
dom0 kernel:  pick_next_task_fair+0x39/0x3f0
dom0 kernel:  pick_next_task+0x4c/0xbb0
dom0 kernel:  ? dequeue_task_fair+0xd1/0x4a0
dom0 kernel:  __schedule+0x135/0x600
dom0 kernel:  schedule+0x59/0xc0
dom0 kernel:  worker_thread+0xb3/0x310
dom0 kernel:  ? process_one_work+0x590/0x590
dom0 kernel:  kthread+0x120/0x140
dom0 kernel:  ? set_kthread_struct+0x40/0x40
dom0 kernel:  ret_from_fork+0x22/0x30
dom0 kernel: cfs_rq->avg.load_avg || cfs_rq->avg.util_avg ||
cfs_rq->avg.runnable_avg
dom0 kernel: WARNING: CPU: 2 PID: 600 at kernel/sched/fair.c:3339
__update_blocked_fair+0x4f4/0x510
dom0 kernel: Modules linked in: snd_seq_dummy snd_hrtimer snd_seq
snd_seq_device snd_timer nf_tables nfnetlink vfat fat intel_rapl_msr
think_lmi wmi_bmof firmware_attributes_class intel_rapl_common uvcvideo
pcspkr videobuf2_vmalloc videobuf2_memops videobuf2_v4l2
videobuf2_common joydev videodev k10temp mc iwlwifi sp5100_tco cfg80211
i2c_piix4 ipmi_devintf ipmi_msghandler r8169 thinkpad_acpi
platform_profile ledtrig_audio rfkill snd soundcore video ucsi_acpi
i2c_scmi typec_ucsi typec wmi fuse xenfs ip_tables dm_thin_pool
dm_persistent_data dm_bio_prison dm_crypt trusted asn1_encoder
hid_multitouch amdgpu crct10dif_pclmul crc32_pclmul crc32c_intel
gpu_sched i2c_algo_bit drm_ttm_helper ttm drm_kms_helper
ghash_clmulni_intel cec sdhci_pci cqhci xhci_pci drm sdhci ehci_pci
xhci_pci_renesas serio_raw mmc_core xhci_hcd ehci_hcd nvme nvme_core
xen_acpi_processor xen_privcmd xen_pciback xen_blkback xen_gntalloc
xen_gntdev xen_evtchn uinput
dom0 kernel: CPU: 2 PID: 600 Comm: kworker/2:2 Tainted: G       
W        --------- ---  5.15.0-0.rc6.0.fc32.qubes.x86_64 #1
dom0 kernel: Hardware name: LENOVO 20Y1S02400/20Y1S02400, BIOS
R1BET65W(1.34 ) 06/17/2021
dom0 kernel: Workqueue:  0x0 (events)
dom0 kernel: RIP: e030:__update_blocked_fair+0x4f4/0x510
dom0 kernel: Code: 01 00 00 48 89 90 08 0a 00 00 e9 e6 fc ff ff 45 31 ff
e9 70 ff ff ff 48 c7 c7 48 dc 5f 82 c6 05 a7 5f ab 01 01 e8 93 19 c4 00
<0f> 0b 41 8b 86 78 01 00 00 e9 a5 fc ff ff 66 66 2e 0f 1f 84 00 00
dom0 kernel: RSP: e02b:ffffc90041a5fcc0 EFLAGS: 00010082
dom0 kernel: RAX: 0000000000000000 RBX: ffff8881406abdb8 RCX:
ffff888140698dd8
dom0 kernel: RDX: 00000000ffffffd8 RSI: 0000000000000027 RDI:
ffff888140698dd0
dom0 kernel: RBP: ffff8881406ab780 R08: 0000000000000001 R09:
0000000000000000
dom0 kernel: R10: 0000000000000000 R11: ffffffffffffffff R12:
0000000000000010
dom0 kernel: R13: ffff8881406abf38 R14: ffff8881406ab600 R15:
0000003411f25932
dom0 kernel: FS:  0000000000000000(0000) GS:ffff888140680000(0000)
knlGS:0000000000000000
dom0 kernel: CS:  10000e030 DS: 0000 ES: 0000 CR0: 0000000080050033
dom0 kernel: CR2: 00005dd8d8bcb416 CR3: 0000000002826000 CR4:
0000000000050660
dom0 kernel: Call Trace:
dom0 kernel:  update_blocked_averages+0xe3/0x280
dom0 kernel:  newidle_balance+0x160/0x600
dom0 kernel:  pick_next_task_fair+0x39/0x3f0
dom0 kernel:  pick_next_task+0x4c/0xbb0
dom0 kernel:  ? dequeue_task_fair+0xd1/0x4a0
dom0 kernel:  __schedule+0x135/0x600
dom0 kernel:  schedule+0x59/0xc0
dom0 kernel:  worker_thread+0xb3/0x310
dom0 kernel:  ? process_one_work+0x590/0x590
dom0 kernel:  kthread+0x120/0x140
dom0 kernel:  ? set_kthread_struct+0x40/0x40
dom0 kernel:  ret_from_fork+0x22/0x30
dom0 kernel: irq event stamp: 3192
dom0 kernel: hardirqs last  enabled at (3191): [<ffffffff81dfcdb4>]
_raw_spin_unlock_irq+0x24/0x40
dom0 kernel: hardirqs last disabled at (3192): [<ffffffff81df4dea>]
__schedule+0x3aa/0x600
dom0 kernel: softirqs last  enabled at (1788): [<ffffffff811e69a1>]
css_free_rwork_fn+0x71/0x350
dom0 kernel: softirqs last disabled at (1786): [<ffffffff811e6986>]
css_free_rwork_fn+0x56/0x350
dom0 kernel: ---[ end trace de8eced9fef0f636 ]---
dom0 kernel: cpu 3 spinlock event irq 79
dom0 kernel: [Firmware Bug]: ACPI MWAIT C-state 0x0 not supported by HW
(0x0)
dom0 kernel: ACPI: \_SB_.PLTF.C003: Found 3 idle states
dom0 kernel: ACPI: FW issue: working around C-state latencies out of order
dom0 kernel: CPU3 is up
dom0 kernel: installing Xen timer for CPU 4
dom0 kernel: cpu 4 spinlock event irq 85
dom0 kernel: [Firmware Bug]: ACPI MWAIT C-state 0x0 not supported by HW
(0x0)
dom0 kernel: ACPI: \_SB_.PLTF.C004: Found 3 idle states
dom0 kernel: ACPI: FW issue: working around C-state latencies out of order
dom0 kernel: CPU4 is up
dom0 kernel: installing Xen timer for CPU 5
dom0 kernel: cpu 5 spinlock event irq 91
dom0 kernel: [Firmware Bug]: ACPI MWAIT C-state 0x0 not supported by HW
(0x0)
dom0 kernel: ACPI: \_SB_.PLTF.C005: Found 3 idle states
dom0 kernel: ACPI: FW issue: working around C-state latencies out of order
dom0 kernel: CPU5 is up
dom0 kernel: installing Xen timer for CPU 6
dom0 kernel: cpu 6 spinlock event irq 97
dom0 kernel: [Firmware Bug]: ACPI MWAIT C-state 0x0 not supported by HW
(0x0)
dom0 kernel: ACPI: \_SB_.PLTF.C006: Found 3 idle states

===================

lspci -vvnn

===================
00:00.0 Host bridge [0600]: Advanced Micro Devices, Inc. [AMD] Renoir
Root Complex [1022:1630]
    Subsystem: Lenovo Device [17aa:5081]
    Control: I/O- Mem- BusMaster- SpecCycle- MemWINV- VGASnoop- ParErr-
Stepping- SERR- FastB2B- DisINTx-
    Status: Cap- 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort-
<TAbort- <MAbort- >SERR- <PERR- INTx-

00:00.2 IOMMU [0806]: Advanced Micro Devices, Inc. [AMD] Renoir IOMMU
[1022:1631]
    Subsystem: Lenovo Device [17aa:5081]
    Control: I/O- Mem- BusMaster- SpecCycle- MemWINV- VGASnoop- ParErr-
Stepping- SERR- FastB2B- DisINTx-
    Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort-
<TAbort- <MAbort- >SERR- <PERR- INTx-
    Interrupt: pin A routed to IRQ 255
    Capabilities: [40] Secure device <?>
    Capabilities: [64] MSI: Enable+ Count=1/4 Maskable- 64bit+
        Address: 00000000fee00000  Data: 4030
    Capabilities: [74] HyperTransport: MSI Mapping Enable+ Fixed+

00:01.0 Host bridge [0600]: Advanced Micro Devices, Inc. [AMD] Renoir
PCIe Dummy Host Bridge [1022:1632]
    Control: I/O- Mem- BusMaster- SpecCycle- MemWINV- VGASnoop- ParErr-
Stepping- SERR- FastB2B- DisINTx-
    Status: Cap- 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort-
<TAbort- <MAbort- >SERR- <PERR- INTx-

00:02.0 Host bridge [0600]: Advanced Micro Devices, Inc. [AMD] Renoir
PCIe Dummy Host Bridge [1022:1632]
    Control: I/O- Mem- BusMaster- SpecCycle- MemWINV- VGASnoop- ParErr-
Stepping- SERR- FastB2B- DisINTx-
    Status: Cap- 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort-
<TAbort- <MAbort- >SERR- <PERR- INTx-

00:02.1 PCI bridge [0604]: Advanced Micro Devices, Inc. [AMD] Renoir
PCIe GPP Bridge [1022:1634] (prog-if 00 [Normal decode])
    Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr-
Stepping- SERR- FastB2B- DisINTx+
    Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort-
<TAbort- <MAbort- >SERR- <PERR- INTx-
    Latency: 0, Cache Line Size: 32 bytes
    Interrupt: pin ? routed to IRQ 106
    Bus: primary=00, secondary=01, subordinate=01, sec-latency=0
    I/O behind bridge: [disabled]
    Memory behind bridge: fd900000-fd9fffff [size=1M]
    Prefetchable memory behind bridge: [disabled]
    Secondary status: 66MHz- FastB2B- ParErr- DEVSEL=fast >TAbort-
<TAbort- <MAbort+ <SERR- <PERR-
    BridgeCtl: Parity- SERR+ NoISA- VGA- VGA16- MAbort- >Reset- FastB2B-
        PriDiscTmr- SecDiscTmr- DiscTmrStat- DiscTmrSERREn-
    Capabilities: [50] Power Management version 3
        Flags: PMEClk- DSI- D1- D2- AuxCurrent=0mA
PME(D0+,D1-,D2-,D3hot+,D3cold+)
        Status: D0 NoSoftRst- PME-Enable- DSel=0 DScale=0 PME-
    Capabilities: [58] Express (v2) Root Port (Slot+), MSI 00
        DevCap:    MaxPayload 512 bytes, PhantFunc 0
            ExtTag+ RBE+
        DevCtl:    CorrErr- NonFatalErr- FatalErr- UnsupReq-
            RlxdOrd+ ExtTag+ PhantFunc- AuxPwr- NoSnoop+
            MaxPayload 256 bytes, MaxReadReq 512 bytes
        DevSta:    CorrErr- NonFatalErr+ FatalErr- UnsupReq+ AuxPwr-
TransPend-
        LnkCap:    Port #0, Speed 8GT/s, Width x8, ASPM L1, Exit Latency
L1 <64us
            ClockPM- Surprise- LLActRep+ BwNot+ ASPMOptComp+
        LnkCtl:    ASPM L1 Enabled; RCB 64 bytes, Disabled- CommClk+
            ExtSynch- ClockPM- AutWidDis- BWInt- AutBWInt-
        LnkSta:    Speed 8GT/s (ok), Width x4 (downgraded)
            TrErr- Train- SlotClk+ DLActive+ BWMgmt+ ABWMgmt-
        SltCap:    AttnBtn- PwrCtrl- MRL- AttnInd- PwrInd- HotPlug-
Surprise-
            Slot #0, PowerLimit 0.000W; Interlock- NoCompl+
        SltCtl:    Enable: AttnBtn- PwrFlt- MRL- PresDet- CmdCplt-
HPIrq- LinkChg-
            Control: AttnInd Unknown, PwrInd Unknown, Power- Interlock-
        SltSta:    Status: AttnBtn- PowerFlt- MRL- CmdCplt- PresDet+
Interlock-
            Changed: MRL- PresDet- LinkState+
        RootCap: CRSVisible+
        RootCtl: ErrCorrectable- ErrNon-Fatal- ErrFatal- PMEIntEna+
CRSVisible+
        RootSta: PME ReqID 0000, PMEStatus- PMEPending-
        DevCap2: Completion Timeout: Range ABCD, TimeoutDis+ NROPrPrP- LTR+
             10BitTagComp- 10BitTagReq- OBFF Not Supported, ExtFmt+
EETLPPrefix+, MaxEETLPPrefixes 1
             EmergencyPowerReduction Not Supported,
EmergencyPowerReductionInit-
             FRS- LN System CLS Not Supported, TPHComp+ ExtTPHComp- ARIFwd+
             AtomicOpsCap: Routing- 32bit+ 64bit+ 128bitCAS-
        DevCtl2: Completion Timeout: 65ms to 210ms, TimeoutDis- LTR+
OBFF Disabled, ARIFwd-
             AtomicOpsCtl: ReqEn- EgressBlck-
        LnkCap2: Supported Link Speeds: 2.5-8GT/s, Crosslink- Retimer-
2Retimers- DRS-
        LnkCtl2: Target Link Speed: 8GT/s, EnterCompliance- SpeedDis-
             Transmit Margin: Normal Operating Range,
EnterModifiedCompliance- ComplianceSOS-
             Compliance De-emphasis: -6dB
        LnkSta2: Current De-emphasis Level: -3.5dB,
EqualizationComplete+ EqualizationPhase1+
             EqualizationPhase2+ EqualizationPhase3+
LinkEqualizationRequest-
             Retimer- 2Retimers- CrosslinkRes: unsupported
    Capabilities: [a0] MSI: Enable+ Count=1/1 Maskable- 64bit+
        Address: 00000000fee00000  Data: 4000
    Capabilities: [c0] Subsystem: Lenovo Device [17aa:5081]
    Capabilities: [c8] HyperTransport: MSI Mapping Enable+ Fixed+
    Capabilities: [100 v1] Vendor Specific Information: ID=0001 Rev=1
Len=010 <?>
    Capabilities: [270 v1] Secondary PCI Express
        LnkCtl3: LnkEquIntrruptEn- PerformEqu-
        LaneErrStat: 0
    Capabilities: [2a0 v1] Access Control Services
        ACSCap:    SrcValid+ TransBlk+ ReqRedir+ CmpltRedir+
UpstreamFwd+ EgressCtrl- DirectTrans+
        ACSCtl:    SrcValid+ TransBlk- ReqRedir+ CmpltRedir+
UpstreamFwd+ EgressCtrl- DirectTrans-
    Capabilities: [370 v1] L1 PM Substates
        L1SubCap: PCI-PM_L1.2+ PCI-PM_L1.1+ ASPM_L1.2+ ASPM_L1.1+
L1_PM_Substates+
              PortCommonModeRestoreTime=24us PortTPowerOnTime=150us
        L1SubCtl1: PCI-PM_L1.2+ PCI-PM_L1.1+ ASPM_L1.2+ ASPM_L1.1+
               T_CommonMode=24us LTR1.2_Threshold=163840ns
        L1SubCtl2: T_PwrOn=150us
    Capabilities: [380 v1] Downstream Port Containment
        DpcCap:    INT Msg #0, RPExt+ PoisonedTLP+ SwTrigger+ RP PIO Log
6, DL_ActiveErr+
        DpcCtl:    Trigger:0 Cmpl- INT- ErrCor- PoisonedTLP- SwTrigger-
DL_ActiveErr-
        DpcSta:    Trigger- Reason:00 INT- RPBusy- TriggerExt:00 RP PIO
ErrPtr:1f
        Source:    0000
    Capabilities: [400 v1] Data Link Feature <?>
    Capabilities: [410 v1] Physical Layer 16.0 GT/s <?>
    Capabilities: [440 v1] Lane Margining at the Receiver <?>
    Kernel driver in use: pcieport

00:02.2 PCI bridge [0604]: Advanced Micro Devices, Inc. [AMD] Renoir
PCIe GPP Bridge [1022:1634] (prog-if 00 [Normal decode])
    Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr-
Stepping- SERR- FastB2B- DisINTx+
    Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort-
<TAbort- <MAbort- >SERR- <PERR- INTx-
    Latency: 0, Cache Line Size: 32 bytes
    Interrupt: pin ? routed to IRQ 107
    Bus: primary=00, secondary=02, subordinate=02, sec-latency=0
    I/O behind bridge: 00003000-00003fff [size=4K]
    Memory behind bridge: fd800000-fd8fffff [size=1M]
    Prefetchable memory behind bridge: [disabled]
    Secondary status: 66MHz- FastB2B- ParErr- DEVSEL=fast >TAbort-
<TAbort- <MAbort+ <SERR- <PERR-
    BridgeCtl: Parity- SERR+ NoISA- VGA- VGA16- MAbort- >Reset- FastB2B-
        PriDiscTmr- SecDiscTmr- DiscTmrStat- DiscTmrSERREn-
    Capabilities: [50] Power Management version 3
        Flags: PMEClk- DSI- D1- D2- AuxCurrent=0mA
PME(D0+,D1-,D2-,D3hot+,D3cold+)
        Status: D0 NoSoftRst- PME-Enable- DSel=0 DScale=0 PME-
    Capabilities: [58] Express (v2) Root Port (Slot+), MSI 00
        DevCap:    MaxPayload 512 bytes, PhantFunc 0
            ExtTag+ RBE+
        DevCtl:    CorrErr- NonFatalErr- FatalErr- UnsupReq-
            RlxdOrd+ ExtTag+ PhantFunc- AuxPwr- NoSnoop+
            MaxPayload 128 bytes, MaxReadReq 512 bytes
        DevSta:    CorrErr- NonFatalErr- FatalErr- UnsupReq- AuxPwr-
TransPend-
        LnkCap:    Port #5, Speed 8GT/s, Width x1, ASPM L1, Exit Latency
L1 <64us
            ClockPM- Surprise- LLActRep+ BwNot+ ASPMOptComp+
        LnkCtl:    ASPM L1 Enabled; RCB 64 bytes, Disabled- CommClk+
            ExtSynch- ClockPM- AutWidDis- BWInt- AutBWInt-
        LnkSta:    Speed 2.5GT/s (downgraded), Width x1 (ok)
            TrErr- Train- SlotClk+ DLActive+ BWMgmt- ABWMgmt-
        SltCap:    AttnBtn- PwrCtrl- MRL- AttnInd- PwrInd- HotPlug-
Surprise-
            Slot #0, PowerLimit 0.000W; Interlock- NoCompl+
        SltCtl:    Enable: AttnBtn- PwrFlt- MRL- PresDet- CmdCplt-
HPIrq- LinkChg-
            Control: AttnInd Unknown, PwrInd Unknown, Power- Interlock-
        SltSta:    Status: AttnBtn- PowerFlt- MRL- CmdCplt- PresDet+
Interlock-
            Changed: MRL- PresDet- LinkState+
        RootCap: CRSVisible+
        RootCtl: ErrCorrectable- ErrNon-Fatal- ErrFatal- PMEIntEna+
CRSVisible+
        RootSta: PME ReqID 0000, PMEStatus- PMEPending-
        DevCap2: Completion Timeout: Range ABCD, TimeoutDis+ NROPrPrP- LTR+
             10BitTagComp- 10BitTagReq- OBFF Not Supported, ExtFmt+
EETLPPrefix+, MaxEETLPPrefixes 1
             EmergencyPowerReduction Not Supported,
EmergencyPowerReductionInit-
             FRS- LN System CLS Not Supported, TPHComp+ ExtTPHComp- ARIFwd+
             AtomicOpsCap: Routing- 32bit+ 64bit+ 128bitCAS-
        DevCtl2: Completion Timeout: 65ms to 210ms, TimeoutDis- LTR+
OBFF Disabled, ARIFwd-
             AtomicOpsCtl: ReqEn- EgressBlck-
        LnkCap2: Supported Link Speeds: 2.5-8GT/s, Crosslink- Retimer-
2Retimers- DRS-
        LnkCtl2: Target Link Speed: 2.5GT/s, EnterCompliance- SpeedDis-
             Transmit Margin: Normal Operating Range,
EnterModifiedCompliance- ComplianceSOS-
             Compliance De-emphasis: -6dB
        LnkSta2: Current De-emphasis Level: -3.5dB,
EqualizationComplete- EqualizationPhase1-
             EqualizationPhase2- EqualizationPhase3-
LinkEqualizationRequest-
             Retimer- 2Retimers- CrosslinkRes: unsupported
    Capabilities: [a0] MSI: Enable+ Count=1/1 Maskable- 64bit+
        Address: 00000000fee00000  Data: 4000
    Capabilities: [c0] Subsystem: Lenovo Device [17aa:5081]
    Capabilities: [c8] HyperTransport: MSI Mapping Enable+ Fixed+
    Capabilities: [100 v1] Vendor Specific Information: ID=0001 Rev=1
Len=010 <?>
    Capabilities: [270 v1] Secondary PCI Express
        LnkCtl3: LnkEquIntrruptEn- PerformEqu-
        LaneErrStat: 0
    Capabilities: [2a0 v1] Access Control Services
        ACSCap:    SrcValid+ TransBlk+ ReqRedir+ CmpltRedir+
UpstreamFwd+ EgressCtrl- DirectTrans+
        ACSCtl:    SrcValid+ TransBlk- ReqRedir+ CmpltRedir+
UpstreamFwd+ EgressCtrl- DirectTrans-
    Capabilities: [370 v1] L1 PM Substates
        L1SubCap: PCI-PM_L1.2+ PCI-PM_L1.1+ ASPM_L1.2+ ASPM_L1.1+
L1_PM_Substates+
              PortCommonModeRestoreTime=150us PortTPowerOnTime=150us
        L1SubCtl1: PCI-PM_L1.2+ PCI-PM_L1.1+ ASPM_L1.2+ ASPM_L1.1+
               T_CommonMode=150us LTR1.2_Threshold=294912ns
        L1SubCtl2: T_PwrOn=150us
    Capabilities: [380 v1] Downstream Port Containment
        DpcCap:    INT Msg #0, RPExt+ PoisonedTLP+ SwTrigger+ RP PIO Log
6, DL_ActiveErr+
        DpcCtl:    Trigger:0 Cmpl- INT- ErrCor- PoisonedTLP- SwTrigger-
DL_ActiveErr-
        DpcSta:    Trigger- Reason:00 INT- RPBusy- TriggerExt:00 RP PIO
ErrPtr:1f
        Source:    0000
    Capabilities: [400 v1] Data Link Feature <?>
    Capabilities: [410 v1] Physical Layer 16.0 GT/s <?>
    Capabilities: [440 v1] Lane Margining at the Receiver <?>
    Kernel driver in use: pcieport

00:02.3 PCI bridge [0604]: Advanced Micro Devices, Inc. [AMD] Renoir
PCIe GPP Bridge [1022:1634] (prog-if 00 [Normal decode])
    Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr-
Stepping- SERR- FastB2B- DisINTx+
    Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort-
<TAbort- <MAbort- >SERR- <PERR- INTx-
    Latency: 0, Cache Line Size: 32 bytes
    Interrupt: pin ? routed to IRQ 108
    Bus: primary=00, secondary=03, subordinate=03, sec-latency=0
    I/O behind bridge: 00004000-00004fff [size=4K]
    Memory behind bridge: fd700000-fd7fffff [size=1M]
    Prefetchable memory behind bridge: 0000000c30000000-0000000c301fffff
[size=2M]
    Secondary status: 66MHz- FastB2B- ParErr- DEVSEL=fast >TAbort-
<TAbort- <MAbort+ <SERR- <PERR-
    BridgeCtl: Parity- SERR+ NoISA- VGA- VGA16- MAbort- >Reset- FastB2B-
        PriDiscTmr- SecDiscTmr- DiscTmrStat- DiscTmrSERREn-
    Capabilities: [50] Power Management version 3
        Flags: PMEClk- DSI- D1- D2- AuxCurrent=0mA
PME(D0+,D1-,D2-,D3hot+,D3cold+)
        Status: D0 NoSoftRst- PME-Enable- DSel=0 DScale=0 PME-
    Capabilities: [58] Express (v2) Root Port (Slot+), MSI 00
        DevCap:    MaxPayload 512 bytes, PhantFunc 0
            ExtTag+ RBE+
        DevCtl:    CorrErr- NonFatalErr- FatalErr- UnsupReq-
            RlxdOrd- ExtTag+ PhantFunc- AuxPwr- NoSnoop+
            MaxPayload 128 bytes, MaxReadReq 512 bytes
        DevSta:    CorrErr- NonFatalErr+ FatalErr- UnsupReq+ AuxPwr-
TransPend-
        LnkCap:    Port #6, Speed 8GT/s, Width x1, ASPM L1, Exit Latency
L1 <64us
            ClockPM- Surprise- LLActRep+ BwNot+ ASPMOptComp+
        LnkCtl:    ASPM L1 Enabled; RCB 64 bytes, Disabled- CommClk+
            ExtSynch- ClockPM- AutWidDis- BWInt- AutBWInt-
        LnkSta:    Speed 5GT/s (downgraded), Width x1 (ok)
            TrErr- Train- SlotClk+ DLActive+ BWMgmt+ ABWMgmt-
        SltCap:    AttnBtn- PwrCtrl- MRL- AttnInd- PwrInd- HotPlug+
Surprise+
            Slot #0, PowerLimit 0.000W; Interlock- NoCompl+
        SltCtl:    Enable: AttnBtn- PwrFlt- MRL- PresDet- CmdCplt-
HPIrq- LinkChg-
            Control: AttnInd Unknown, PwrInd Unknown, Power- Interlock-
        SltSta:    Status: AttnBtn- PowerFlt- MRL- CmdCplt- PresDet+
Interlock-
            Changed: MRL- PresDet- LinkState+
        RootCap: CRSVisible+
        RootCtl: ErrCorrectable- ErrNon-Fatal- ErrFatal- PMEIntEna+
CRSVisible+
        RootSta: PME ReqID 0000, PMEStatus- PMEPending-
        DevCap2: Completion Timeout: Range ABCD, TimeoutDis+ NROPrPrP- LTR+
             10BitTagComp- 10BitTagReq- OBFF Not Supported, ExtFmt+
EETLPPrefix+, MaxEETLPPrefixes 1
             EmergencyPowerReduction Not Supported,
EmergencyPowerReductionInit-
             FRS- LN System CLS Not Supported, TPHComp+ ExtTPHComp- ARIFwd+
             AtomicOpsCap: Routing- 32bit+ 64bit+ 128bitCAS-
        DevCtl2: Completion Timeout: 65ms to 210ms, TimeoutDis- LTR+
OBFF Disabled, ARIFwd-
             AtomicOpsCtl: ReqEn- EgressBlck-
        LnkCap2: Supported Link Speeds: 2.5-8GT/s, Crosslink- Retimer-
2Retimers- DRS-
        LnkCtl2: Target Link Speed: 5GT/s, EnterCompliance- SpeedDis-
             Transmit Margin: Normal Operating Range,
EnterModifiedCompliance- ComplianceSOS-
             Compliance De-emphasis: -6dB
        LnkSta2: Current De-emphasis Level: -3.5dB,
EqualizationComplete- EqualizationPhase1-
             EqualizationPhase2- EqualizationPhase3-
LinkEqualizationRequest-
             Retimer- 2Retimers- CrosslinkRes: unsupported
    Capabilities: [a0] MSI: Enable+ Count=1/1 Maskable- 64bit+
        Address: 00000000fee00000  Data: 4000
    Capabilities: [c0] Subsystem: Lenovo Device [17aa:5081]
    Capabilities: [c8] HyperTransport: MSI Mapping Enable+ Fixed+
    Capabilities: [100 v1] Vendor Specific Information: ID=0001 Rev=1
Len=010 <?>
    Capabilities: [270 v1] Secondary PCI Express
        LnkCtl3: LnkEquIntrruptEn- PerformEqu-
        LaneErrStat: 0
    Capabilities: [2a0 v1] Access Control Services
        ACSCap:    SrcValid+ TransBlk+ ReqRedir+ CmpltRedir+
UpstreamFwd+ EgressCtrl- DirectTrans+
        ACSCtl:    SrcValid+ TransBlk- ReqRedir+ CmpltRedir+
UpstreamFwd+ EgressCtrl- DirectTrans-
    Capabilities: [370 v1] L1 PM Substates
        L1SubCap: PCI-PM_L1.2+ PCI-PM_L1.1+ ASPM_L1.2+ ASPM_L1.1+
L1_PM_Substates+
              PortCommonModeRestoreTime=30us PortTPowerOnTime=150us
        L1SubCtl1: PCI-PM_L1.2+ PCI-PM_L1.1+ ASPM_L1.2+ ASPM_L1.1+
               T_CommonMode=30us LTR1.2_Threshold=163840ns
        L1SubCtl2: T_PwrOn=150us
    Capabilities: [380 v1] Downstream Port Containment
        DpcCap:    INT Msg #0, RPExt+ PoisonedTLP+ SwTrigger+ RP PIO Log
6, DL_ActiveErr+
        DpcCtl:    Trigger:0 Cmpl- INT- ErrCor- PoisonedTLP- SwTrigger-
DL_ActiveErr-
        DpcSta:    Trigger- Reason:00 INT- RPBusy- TriggerExt:00 RP PIO
ErrPtr:1f
        Source:    0000
    Capabilities: [400 v1] Data Link Feature <?>
    Capabilities: [410 v1] Physical Layer 16.0 GT/s <?>
    Capabilities: [440 v1] Lane Margining at the Receiver <?>
    Kernel driver in use: pcieport

00:02.4 PCI bridge [0604]: Advanced Micro Devices, Inc. [AMD] Renoir
PCIe GPP Bridge [1022:1634] (prog-if 00 [Normal decode])
    Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr-
Stepping- SERR- FastB2B- DisINTx+
    Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort-
<TAbort- <MAbort- >SERR- <PERR- INTx-
    Latency: 0, Cache Line Size: 32 bytes
    Interrupt: pin ? routed to IRQ 109
    Bus: primary=00, secondary=04, subordinate=04, sec-latency=0
    I/O behind bridge: [disabled]
    Memory behind bridge: fd600000-fd6fffff [size=1M]
    Prefetchable memory behind bridge: [disabled]
    Secondary status: 66MHz- FastB2B- ParErr- DEVSEL=fast >TAbort-
<TAbort- <MAbort+ <SERR- <PERR-
    BridgeCtl: Parity- SERR+ NoISA- VGA- VGA16- MAbort- >Reset- FastB2B-
        PriDiscTmr- SecDiscTmr- DiscTmrStat- DiscTmrSERREn-
    Capabilities: [50] Power Management version 3
        Flags: PMEClk- DSI- D1- D2- AuxCurrent=0mA
PME(D0+,D1-,D2-,D3hot+,D3cold+)
        Status: D0 NoSoftRst- PME-Enable- DSel=0 DScale=0 PME-
    Capabilities: [58] Express (v2) Root Port (Slot+), MSI 00
        DevCap:    MaxPayload 512 bytes, PhantFunc 0
            ExtTag+ RBE+
        DevCtl:    CorrErr- NonFatalErr- FatalErr- UnsupReq-
            RlxdOrd+ ExtTag+ PhantFunc- AuxPwr- NoSnoop+
            MaxPayload 128 bytes, MaxReadReq 512 bytes
        DevSta:    CorrErr- NonFatalErr- FatalErr- UnsupReq- AuxPwr-
TransPend-
        LnkCap:    Port #3, Speed 8GT/s, Width x1, ASPM L1, Exit Latency
L1 <64us
            ClockPM- Surprise- LLActRep+ BwNot+ ASPMOptComp+
        LnkCtl:    ASPM L1 Enabled; RCB 64 bytes, Disabled- CommClk+
            ExtSynch- ClockPM- AutWidDis- BWInt- AutBWInt-
        LnkSta:    Speed 2.5GT/s (downgraded), Width x1 (ok)
            TrErr- Train- SlotClk+ DLActive+ BWMgmt- ABWMgmt-
        SltCap:    AttnBtn- PwrCtrl- MRL- AttnInd- PwrInd- HotPlug-
Surprise-
            Slot #0, PowerLimit 0.000W; Interlock- NoCompl+
        SltCtl:    Enable: AttnBtn- PwrFlt- MRL- PresDet- CmdCplt-
HPIrq- LinkChg-
            Control: AttnInd Unknown, PwrInd Unknown, Power- Interlock-
        SltSta:    Status: AttnBtn- PowerFlt- MRL- CmdCplt- PresDet+
Interlock-
            Changed: MRL- PresDet- LinkState+
        RootCap: CRSVisible+
        RootCtl: ErrCorrectable- ErrNon-Fatal- ErrFatal- PMEIntEna+
CRSVisible+
        RootSta: PME ReqID 0000, PMEStatus- PMEPending-
        DevCap2: Completion Timeout: Range ABCD, TimeoutDis+ NROPrPrP- LTR+
             10BitTagComp- 10BitTagReq- OBFF Not Supported, ExtFmt+
EETLPPrefix+, MaxEETLPPrefixes 1
             EmergencyPowerReduction Not Supported,
EmergencyPowerReductionInit-
             FRS- LN System CLS Not Supported, TPHComp+ ExtTPHComp- ARIFwd+
             AtomicOpsCap: Routing- 32bit+ 64bit+ 128bitCAS-
        DevCtl2: Completion Timeout: 65ms to 210ms, TimeoutDis- LTR+
OBFF Disabled, ARIFwd-
             AtomicOpsCtl: ReqEn- EgressBlck-
        LnkCap2: Supported Link Speeds: 2.5-8GT/s, Crosslink- Retimer-
2Retimers- DRS-
        LnkCtl2: Target Link Speed: 2.5GT/s, EnterCompliance- SpeedDis-
             Transmit Margin: Normal Operating Range,
EnterModifiedCompliance- ComplianceSOS-
             Compliance De-emphasis: -6dB
        LnkSta2: Current De-emphasis Level: -3.5dB,
EqualizationComplete- EqualizationPhase1-
             EqualizationPhase2- EqualizationPhase3-
LinkEqualizationRequest-
             Retimer- 2Retimers- CrosslinkRes: unsupported
    Capabilities: [a0] MSI: Enable+ Count=1/1 Maskable- 64bit+
        Address: 00000000fee00000  Data: 4000
    Capabilities: [c0] Subsystem: Lenovo Device [17aa:5081]
    Capabilities: [c8] HyperTransport: MSI Mapping Enable+ Fixed+
    Capabilities: [100 v1] Vendor Specific Information: ID=0001 Rev=1
Len=010 <?>
    Capabilities: [270 v1] Secondary PCI Express
        LnkCtl3: LnkEquIntrruptEn- PerformEqu-
        LaneErrStat: 0
    Capabilities: [2a0 v1] Access Control Services
        ACSCap:    SrcValid+ TransBlk+ ReqRedir+ CmpltRedir+
UpstreamFwd+ EgressCtrl- DirectTrans+
        ACSCtl:    SrcValid+ TransBlk- ReqRedir+ CmpltRedir+
UpstreamFwd+ EgressCtrl- DirectTrans-
    Capabilities: [370 v1] L1 PM Substates
        L1SubCap: PCI-PM_L1.2+ PCI-PM_L1.1+ ASPM_L1.2+ ASPM_L1.1+
L1_PM_Substates+
              PortCommonModeRestoreTime=255us PortTPowerOnTime=150us
        L1SubCtl1: PCI-PM_L1.2+ PCI-PM_L1.1+ ASPM_L1.2+ ASPM_L1.1+
               T_CommonMode=255us LTR1.2_Threshold=3145728ns
        L1SubCtl2: T_PwrOn=3100us
    Capabilities: [380 v1] Downstream Port Containment
        DpcCap:    INT Msg #0, RPExt+ PoisonedTLP+ SwTrigger+ RP PIO Log
6, DL_ActiveErr+
        DpcCtl:    Trigger:0 Cmpl- INT- ErrCor- PoisonedTLP- SwTrigger-
DL_ActiveErr-
        DpcSta:    Trigger- Reason:00 INT- RPBusy- TriggerExt:00 RP PIO
ErrPtr:1f
        Source:    0000
    Capabilities: [400 v1] Data Link Feature <?>
    Capabilities: [410 v1] Physical Layer 16.0 GT/s <?>
    Capabilities: [440 v1] Lane Margining at the Receiver <?>
    Kernel driver in use: pcieport

00:02.6 PCI bridge [0604]: Advanced Micro Devices, Inc. [AMD] Renoir
PCIe GPP Bridge [1022:1634] (prog-if 00 [Normal decode])
    Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr-
Stepping- SERR- FastB2B- DisINTx+
    Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort-
<TAbort- <MAbort- >SERR- <PERR- INTx-
    Latency: 0, Cache Line Size: 32 bytes
    Interrupt: pin ? routed to IRQ 110
    Bus: primary=00, secondary=05, subordinate=05, sec-latency=0
    I/O behind bridge: 00002000-00002fff [size=4K]
    Memory behind bridge: fd500000-fd5fffff [size=1M]
    Prefetchable memory behind bridge: [disabled]
    Secondary status: 66MHz- FastB2B- ParErr- DEVSEL=fast >TAbort-
<TAbort- <MAbort+ <SERR- <PERR-
    BridgeCtl: Parity- SERR+ NoISA- VGA- VGA16- MAbort- >Reset- FastB2B-
        PriDiscTmr- SecDiscTmr- DiscTmrStat- DiscTmrSERREn-
    Capabilities: [50] Power Management version 3
        Flags: PMEClk- DSI- D1- D2- AuxCurrent=0mA
PME(D0+,D1-,D2-,D3hot+,D3cold+)
        Status: D0 NoSoftRst- PME-Enable- DSel=0 DScale=0 PME-
    Capabilities: [58] Express (v2) Root Port (Slot+), MSI 00
        DevCap:    MaxPayload 512 bytes, PhantFunc 0
            ExtTag+ RBE+
        DevCtl:    CorrErr- NonFatalErr- FatalErr- UnsupReq-
            RlxdOrd+ ExtTag+ PhantFunc- AuxPwr- NoSnoop+
            MaxPayload 128 bytes, MaxReadReq 512 bytes
        DevSta:    CorrErr- NonFatalErr- FatalErr- UnsupReq- AuxPwr-
TransPend-
        LnkCap:    Port #2, Speed 8GT/s, Width x2, ASPM L1, Exit Latency
L1 <64us
            ClockPM- Surprise- LLActRep+ BwNot+ ASPMOptComp+
        LnkCtl:    ASPM L1 Enabled; RCB 64 bytes, Disabled- CommClk+
            ExtSynch- ClockPM- AutWidDis- BWInt- AutBWInt-
        LnkSta:    Speed 2.5GT/s (downgraded), Width x1 (downgraded)
            TrErr- Train- SlotClk+ DLActive+ BWMgmt- ABWMgmt-
        SltCap:    AttnBtn- PwrCtrl- MRL- AttnInd- PwrInd- HotPlug-
Surprise-
            Slot #0, PowerLimit 0.000W; Interlock- NoCompl+
        SltCtl:    Enable: AttnBtn- PwrFlt- MRL- PresDet- CmdCplt-
HPIrq- LinkChg-
            Control: AttnInd Unknown, PwrInd Unknown, Power- Interlock-
        SltSta:    Status: AttnBtn- PowerFlt- MRL- CmdCplt- PresDet+
Interlock-
            Changed: MRL- PresDet- LinkState+
        RootCap: CRSVisible+
        RootCtl: ErrCorrectable- ErrNon-Fatal- ErrFatal- PMEIntEna+
CRSVisible+
        RootSta: PME ReqID 0000, PMEStatus- PMEPending-
        DevCap2: Completion Timeout: Range ABCD, TimeoutDis+ NROPrPrP- LTR+
             10BitTagComp- 10BitTagReq- OBFF Not Supported, ExtFmt+
EETLPPrefix+, MaxEETLPPrefixes 1
             EmergencyPowerReduction Not Supported,
EmergencyPowerReductionInit-
             FRS- LN System CLS Not Supported, TPHComp+ ExtTPHComp- ARIFwd+
             AtomicOpsCap: Routing- 32bit+ 64bit+ 128bitCAS-
        DevCtl2: Completion Timeout: 65ms to 210ms, TimeoutDis- LTR-
OBFF Disabled, ARIFwd-
             AtomicOpsCtl: ReqEn- EgressBlck-
        LnkCap2: Supported Link Speeds: 2.5-8GT/s, Crosslink- Retimer-
2Retimers- DRS-
        LnkCtl2: Target Link Speed: 2.5GT/s, EnterCompliance- SpeedDis+
             Transmit Margin: Normal Operating Range,
EnterModifiedCompliance- ComplianceSOS-
             Compliance De-emphasis: -6dB
        LnkSta2: Current De-emphasis Level: -3.5dB,
EqualizationComplete- EqualizationPhase1-
             EqualizationPhase2- EqualizationPhase3-
LinkEqualizationRequest-
             Retimer- 2Retimers- CrosslinkRes: unsupported
    Capabilities: [a0] MSI: Enable+ Count=1/1 Maskable- 64bit+
        Address: 00000000fee00000  Data: 4000
    Capabilities: [c0] Subsystem: Lenovo Device [17aa:5081]
    Capabilities: [c8] HyperTransport: MSI Mapping Enable+ Fixed+
    Capabilities: [100 v1] Vendor Specific Information: ID=0001 Rev=1
Len=010 <?>
    Capabilities: [270 v1] Secondary PCI Express
        LnkCtl3: LnkEquIntrruptEn- PerformEqu-
        LaneErrStat: 0
    Capabilities: [2a0 v1] Access Control Services
        ACSCap:    SrcValid+ TransBlk+ ReqRedir+ CmpltRedir+
UpstreamFwd+ EgressCtrl- DirectTrans+
        ACSCtl:    SrcValid+ TransBlk- ReqRedir+ CmpltRedir+
UpstreamFwd+ EgressCtrl- DirectTrans-
    Capabilities: [370 v1] L1 PM Substates
        L1SubCap: PCI-PM_L1.2+ PCI-PM_L1.1+ ASPM_L1.2+ ASPM_L1.1+
L1_PM_Substates+
              PortCommonModeRestoreTime=150us PortTPowerOnTime=150us
        L1SubCtl1: PCI-PM_L1.2+ PCI-PM_L1.1+ ASPM_L1.2+ ASPM_L1.1+
               T_CommonMode=150us LTR1.2_Threshold=294912ns
        L1SubCtl2: T_PwrOn=150us
    Capabilities: [380 v1] Downstream Port Containment
        DpcCap:    INT Msg #0, RPExt+ PoisonedTLP+ SwTrigger+ RP PIO Log
6, DL_ActiveErr+
        DpcCtl:    Trigger:0 Cmpl- INT- ErrCor- PoisonedTLP- SwTrigger-
DL_ActiveErr-
        DpcSta:    Trigger- Reason:00 INT- RPBusy- TriggerExt:00 RP PIO
ErrPtr:1f
        Source:    0000
    Capabilities: [400 v1] Data Link Feature <?>
    Capabilities: [410 v1] Physical Layer 16.0 GT/s <?>
    Capabilities: [440 v1] Lane Margining at the Receiver <?>
    Kernel driver in use: pcieport

00:02.7 PCI bridge [0604]: Advanced Micro Devices, Inc. [AMD] Renoir
PCIe GPP Bridge [1022:1634] (prog-if 00 [Normal decode])
    Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr-
Stepping- SERR- FastB2B- DisINTx+
    Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort-
<TAbort- <MAbort- >SERR- <PERR- INTx-
    Latency: 0, Cache Line Size: 32 bytes
    Interrupt: pin ? routed to IRQ 111
    Bus: primary=00, secondary=06, subordinate=06, sec-latency=0
    I/O behind bridge: [disabled]
    Memory behind bridge: fd400000-fd4fffff [size=1M]
    Prefetchable memory behind bridge: [disabled]
    Secondary status: 66MHz- FastB2B- ParErr- DEVSEL=fast >TAbort-
<TAbort- <MAbort+ <SERR- <PERR-
    BridgeCtl: Parity- SERR+ NoISA- VGA- VGA16- MAbort- >Reset- FastB2B-
        PriDiscTmr- SecDiscTmr- DiscTmrStat- DiscTmrSERREn-
    Capabilities: [50] Power Management version 3
        Flags: PMEClk- DSI- D1- D2- AuxCurrent=0mA
PME(D0+,D1-,D2-,D3hot+,D3cold+)
        Status: D0 NoSoftRst- PME-Enable- DSel=0 DScale=0 PME-
    Capabilities: [58] Express (v2) Root Port (Slot+), MSI 00
        DevCap:    MaxPayload 512 bytes, PhantFunc 0
            ExtTag+ RBE+
        DevCtl:    CorrErr- NonFatalErr- FatalErr- UnsupReq-
            RlxdOrd+ ExtTag+ PhantFunc- AuxPwr- NoSnoop+
            MaxPayload 128 bytes, MaxReadReq 512 bytes
        DevSta:    CorrErr- NonFatalErr- FatalErr- UnsupReq- AuxPwr-
TransPend-
        LnkCap:    Port #1, Speed 8GT/s, Width x2, ASPM not supported
            ClockPM- Surprise- LLActRep+ BwNot+ ASPMOptComp+
        LnkCtl:    ASPM Disabled; RCB 64 bytes, Disabled- CommClk+
            ExtSynch- ClockPM- AutWidDis- BWInt- AutBWInt-
        LnkSta:    Speed 5GT/s (downgraded), Width x1 (downgraded)
            TrErr- Train- SlotClk+ DLActive+ BWMgmt+ ABWMgmt+
        SltCap:    AttnBtn- PwrCtrl- MRL- AttnInd- PwrInd- HotPlug-
Surprise-
            Slot #0, PowerLimit 0.000W; Interlock- NoCompl+
        SltCtl:    Enable: AttnBtn- PwrFlt- MRL- PresDet- CmdCplt-
HPIrq- LinkChg-
            Control: AttnInd Unknown, PwrInd Unknown, Power- Interlock-
        SltSta:    Status: AttnBtn- PowerFlt- MRL- CmdCplt- PresDet+
Interlock-
            Changed: MRL- PresDet- LinkState+
        RootCap: CRSVisible+
        RootCtl: ErrCorrectable- ErrNon-Fatal- ErrFatal- PMEIntEna+
CRSVisible+
        RootSta: PME ReqID 0000, PMEStatus- PMEPending-
        DevCap2: Completion Timeout: Range ABCD, TimeoutDis+ NROPrPrP- LTR+
             10BitTagComp- 10BitTagReq- OBFF Not Supported, ExtFmt+
EETLPPrefix+, MaxEETLPPrefixes 1
             EmergencyPowerReduction Not Supported,
EmergencyPowerReductionInit-
             FRS- LN System CLS Not Supported, TPHComp+ ExtTPHComp- ARIFwd+
             AtomicOpsCap: Routing- 32bit+ 64bit+ 128bitCAS-
        DevCtl2: Completion Timeout: 65ms to 210ms, TimeoutDis- LTR-
OBFF Disabled, ARIFwd-
             AtomicOpsCtl: ReqEn- EgressBlck-
        LnkCap2: Supported Link Speeds: 2.5-8GT/s, Crosslink- Retimer-
2Retimers- DRS-
        LnkCtl2: Target Link Speed: 5GT/s, EnterCompliance- SpeedDis-
             Transmit Margin: Normal Operating Range,
EnterModifiedCompliance- ComplianceSOS-
             Compliance De-emphasis: -6dB
        LnkSta2: Current De-emphasis Level: -3.5dB,
EqualizationComplete- EqualizationPhase1-
             EqualizationPhase2- EqualizationPhase3-
LinkEqualizationRequest-
             Retimer- 2Retimers- CrosslinkRes: unsupported
    Capabilities: [a0] MSI: Enable+ Count=1/1 Maskable- 64bit+
        Address: 00000000fee00000  Data: 4000
    Capabilities: [c0] Subsystem: Lenovo Device [17aa:5081]
    Capabilities: [c8] HyperTransport: MSI Mapping Enable+ Fixed+
    Capabilities: [100 v1] Vendor Specific Information: ID=0001 Rev=1
Len=010 <?>
    Capabilities: [270 v1] Secondary PCI Express
        LnkCtl3: LnkEquIntrruptEn- PerformEqu-
        LaneErrStat: 0
    Capabilities: [2a0 v1] Access Control Services
        ACSCap:    SrcValid+ TransBlk+ ReqRedir+ CmpltRedir+
UpstreamFwd+ EgressCtrl- DirectTrans+
        ACSCtl:    SrcValid+ TransBlk- ReqRedir+ CmpltRedir+
UpstreamFwd+ EgressCtrl- DirectTrans-
    Capabilities: [370 v1] L1 PM Substates
        L1SubCap: PCI-PM_L1.2- PCI-PM_L1.1- ASPM_L1.2- ASPM_L1.1-
L1_PM_Substates+
        L1SubCtl1: PCI-PM_L1.2- PCI-PM_L1.1- ASPM_L1.2- ASPM_L1.1-
        L1SubCtl2:
    Capabilities: [380 v1] Downstream Port Containment
        DpcCap:    INT Msg #0, RPExt+ PoisonedTLP+ SwTrigger+ RP PIO Log
6, DL_ActiveErr+
        DpcCtl:    Trigger:0 Cmpl- INT- ErrCor- PoisonedTLP- SwTrigger-
DL_ActiveErr-
        DpcSta:    Trigger- Reason:00 INT- RPBusy- TriggerExt:00 RP PIO
ErrPtr:1f
        Source:    0000
    Capabilities: [400 v1] Data Link Feature <?>
    Capabilities: [410 v1] Physical Layer 16.0 GT/s <?>
    Capabilities: [440 v1] Lane Margining at the Receiver <?>
    Kernel driver in use: pcieport

00:08.0 Host bridge [0600]: Advanced Micro Devices, Inc. [AMD] Renoir
PCIe Dummy Host Bridge [1022:1632]
    Control: I/O- Mem- BusMaster- SpecCycle- MemWINV- VGASnoop- ParErr-
Stepping- SERR- FastB2B- DisINTx-
    Status: Cap- 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort-
<TAbort- <MAbort- >SERR- <PERR- INTx-

00:08.1 PCI bridge [0604]: Advanced Micro Devices, Inc. [AMD] Renoir
Internal PCIe GPP Bridge to Bus [1022:1635] (prog-if 00 [Normal decode])
    Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr-
Stepping- SERR- FastB2B- DisINTx+
    Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort-
<TAbort- <MAbort- >SERR- <PERR- INTx-
    Latency: 0, Cache Line Size: 32 bytes
    Interrupt: pin A routed to IRQ 112
    Bus: primary=00, secondary=07, subordinate=07, sec-latency=0
    I/O behind bridge: 00001000-00001fff [size=4K]
    Memory behind bridge: fd000000-fd3fffff [size=4M]
    Prefetchable memory behind bridge: 0000000c60000000-0000000c701fffff
[size=258M]
    Secondary status: 66MHz- FastB2B- ParErr- DEVSEL=fast >TAbort-
<TAbort- <MAbort- <SERR- <PERR-
    BridgeCtl: Parity- SERR+ NoISA- VGA- VGA16- MAbort- >Reset- FastB2B-
        PriDiscTmr- SecDiscTmr- DiscTmrStat- DiscTmrSERREn-
    Capabilities: [50] Power Management version 3
        Flags: PMEClk- DSI- D1- D2- AuxCurrent=0mA
PME(D0+,D1-,D2-,D3hot+,D3cold+)
        Status: D0 NoSoftRst- PME-Enable- DSel=0 DScale=0 PME-
    Capabilities: [58] Express (v2) Root Port (Slot-), MSI 00
        DevCap:    MaxPayload 512 bytes, PhantFunc 0
            ExtTag+ RBE+
        DevCtl:    CorrErr- NonFatalErr- FatalErr- UnsupReq-
            RlxdOrd+ ExtTag+ PhantFunc- AuxPwr- NoSnoop+
            MaxPayload 128 bytes, MaxReadReq 512 bytes
        DevSta:    CorrErr- NonFatalErr- FatalErr- UnsupReq- AuxPwr-
TransPend-
        LnkCap:    Port #0, Speed 16GT/s, Width x16, ASPM L0s L1, Exit
Latency L0s <64ns, L1 <1us
            ClockPM- Surprise- LLActRep+ BwNot+ ASPMOptComp+
        LnkCtl:    ASPM Disabled; RCB 64 bytes, Disabled- CommClk+
            ExtSynch- ClockPM- AutWidDis- BWInt- AutBWInt-
        LnkSta:    Speed 16GT/s (ok), Width x16 (ok)
            TrErr- Train- SlotClk+ DLActive+ BWMgmt+ ABWMgmt-
        RootCap: CRSVisible+
        RootCtl: ErrCorrectable- ErrNon-Fatal- ErrFatal- PMEIntEna+
CRSVisible+
        RootSta: PME ReqID 0000, PMEStatus- PMEPending-
        DevCap2: Completion Timeout: Not Supported, TimeoutDis-
NROPrPrP- LTR-
             10BitTagComp+ 10BitTagReq- OBFF Not Supported, ExtFmt+
EETLPPrefix+, MaxEETLPPrefixes 4
             EmergencyPowerReduction Not Supported,
EmergencyPowerReductionInit-
             FRS- LN System CLS Not Supported, TPHComp- ExtTPHComp- ARIFwd-
             AtomicOpsCap: Routing- 32bit- 64bit- 128bitCAS-
        DevCtl2: Completion Timeout: 50us to 50ms, TimeoutDis- LTR- OBFF
Disabled, ARIFwd-
             AtomicOpsCtl: ReqEn- EgressBlck-
        LnkCap2: Supported Link Speeds: 2.5-16GT/s, Crosslink- Retimer+
2Retimers+ DRS-
        LnkCtl2: Target Link Speed: 16GT/s, EnterCompliance- SpeedDis-
             Transmit Margin: Normal Operating Range,
EnterModifiedCompliance- ComplianceSOS-
             Compliance De-emphasis: -6dB
        LnkSta2: Current De-emphasis Level: -3.5dB,
EqualizationComplete+ EqualizationPhase1+
             EqualizationPhase2+ EqualizationPhase3+
LinkEqualizationRequest-
             Retimer- 2Retimers- CrosslinkRes: unsupported
    Capabilities: [a0] MSI: Enable+ Count=1/1 Maskable- 64bit+
        Address: 00000000fee00000  Data: 4000
    Capabilities: [c0] Subsystem: Device [5081:17aa]
    Capabilities: [100 v1] Vendor Specific Information: ID=0001 Rev=1
Len=010 <?>
    Capabilities: [270 v1] Secondary PCI Express
        LnkCtl3: LnkEquIntrruptEn- PerformEqu-
        LaneErrStat: 0
    Capabilities: [400 v1] Data Link Feature <?>
    Capabilities: [410 v1] Physical Layer 16.0 GT/s <?>
    Capabilities: [440 v1] Lane Margining at the Receiver <?>
    Kernel driver in use: pcieport

00:14.0 SMBus [0c05]: Advanced Micro Devices, Inc. [AMD] FCH SMBus
Controller [1022:790b] (rev 51)
    Subsystem: Lenovo Device [17aa:5081]
    Control: I/O- Mem- BusMaster- SpecCycle- MemWINV- VGASnoop- ParErr-
Stepping- SERR- FastB2B- DisINTx+
    Status: Cap- 66MHz+ UDF- FastB2B- ParErr- DEVSEL=medium >TAbort-
<TAbort- <MAbort- >SERR- <PERR- INTx-
    Kernel driver in use: piix4_smbus
    Kernel modules: i2c_piix4, sp5100_tco

00:14.3 ISA bridge [0601]: Advanced Micro Devices, Inc. [AMD] FCH LPC
Bridge [1022:790e] (rev 51)
    Subsystem: Lenovo Device [17aa:5081]
    Control: I/O+ Mem+ BusMaster+ SpecCycle+ MemWINV- VGASnoop- ParErr-
Stepping- SERR- FastB2B- DisINTx-
    Status: Cap- 66MHz+ UDF- FastB2B- ParErr- DEVSEL=medium >TAbort-
<TAbort- <MAbort- >SERR- <PERR- INTx-
    Latency: 0

00:18.0 Host bridge [0600]: Advanced Micro Devices, Inc. [AMD] Renoir
Device 24: Function 0 [1022:1448]
    Control: I/O- Mem- BusMaster- SpecCycle- MemWINV- VGASnoop- ParErr-
Stepping- SERR- FastB2B- DisINTx-
    Status: Cap- 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort-
<TAbort- <MAbort- >SERR- <PERR- INTx-

00:18.1 Host bridge [0600]: Advanced Micro Devices, Inc. [AMD] Renoir
Device 24: Function 1 [1022:1449]
    Control: I/O- Mem- BusMaster- SpecCycle- MemWINV- VGASnoop- ParErr-
Stepping- SERR- FastB2B- DisINTx-
    Status: Cap- 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort-
<TAbort- <MAbort- >SERR- <PERR- INTx-

00:18.2 Host bridge [0600]: Advanced Micro Devices, Inc. [AMD] Renoir
Device 24: Function 2 [1022:144a]
    Control: I/O- Mem- BusMaster- SpecCycle- MemWINV- VGASnoop- ParErr-
Stepping- SERR- FastB2B- DisINTx-
    Status: Cap- 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort-
<TAbort- <MAbort- >SERR- <PERR- INTx-

00:18.3 Host bridge [0600]: Advanced Micro Devices, Inc. [AMD] Renoir
Device 24: Function 3 [1022:144b]
    Control: I/O- Mem- BusMaster- SpecCycle- MemWINV- VGASnoop- ParErr-
Stepping- SERR- FastB2B- DisINTx-
    Status: Cap- 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort-
<TAbort- <MAbort- >SERR- <PERR- INTx-
    Kernel driver in use: k10temp
    Kernel modules: k10temp

00:18.4 Host bridge [0600]: Advanced Micro Devices, Inc. [AMD] Renoir
Device 24: Function 4 [1022:144c]
    Control: I/O- Mem- BusMaster- SpecCycle- MemWINV- VGASnoop- ParErr-
Stepping- SERR- FastB2B- DisINTx-
    Status: Cap- 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort-
<TAbort- <MAbort- >SERR- <PERR- INTx-

00:18.5 Host bridge [0600]: Advanced Micro Devices, Inc. [AMD] Renoir
Device 24: Function 5 [1022:144d]
    Control: I/O- Mem- BusMaster- SpecCycle- MemWINV- VGASnoop- ParErr-
Stepping- SERR- FastB2B- DisINTx-
    Status: Cap- 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort-
<TAbort- <MAbort- >SERR- <PERR- INTx-

00:18.6 Host bridge [0600]: Advanced Micro Devices, Inc. [AMD] Renoir
Device 24: Function 6 [1022:144e]
    Control: I/O- Mem- BusMaster- SpecCycle- MemWINV- VGASnoop- ParErr-
Stepping- SERR- FastB2B- DisINTx-
    Status: Cap- 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort-
<TAbort- <MAbort- >SERR- <PERR- INTx-

00:18.7 Host bridge [0600]: Advanced Micro Devices, Inc. [AMD] Renoir
Device 24: Function 7 [1022:144f]
    Control: I/O- Mem- BusMaster- SpecCycle- MemWINV- VGASnoop- ParErr-
Stepping- SERR- FastB2B- DisINTx-
    Status: Cap- 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort-
<TAbort- <MAbort- >SERR- <PERR- INTx-

01:00.0 Non-Volatile memory controller [0108]: SK hynix Device
[1c5c:1639] (prog-if 02 [NVM Express])
    Subsystem: SK hynix Device [1c5c:1639]
    Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr-
Stepping- SERR- FastB2B- DisINTx+
    Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort-
<TAbort- <MAbort- >SERR- <PERR- INTx-
    Latency: 0, Cache Line Size: 32 bytes
    Interrupt: pin A routed to IRQ 36
    NUMA node: 0
    Region 0: Memory at fd900000 (64-bit, non-prefetchable) [size=16K]
    Region 2: Memory at fd905000 (32-bit, non-prefetchable) [size=4K]
    Region 3: Memory at fd904000 (32-bit, non-prefetchable) [size=4K]
    Capabilities: [80] Power Management version 3
        Flags: PMEClk- DSI- D1- D2- AuxCurrent=0mA
PME(D0-,D1-,D2-,D3hot-,D3cold-)
        Status: D0 NoSoftRst+ PME-Enable- DSel=0 DScale=0 PME-
    Capabilities: [90] MSI: Enable- Count=1/16 Maskable+ 64bit+
        Address: 0000000000000000  Data: 0000
        Masking: 00000000  Pending: 00000000
    Capabilities: [b0] MSI-X: Enable+ Count=17 Masked-
        Vector table: BAR=0 offset=00002000
        PBA: BAR=0 offset=00003000
    Capabilities: [c0] Express (v2) Endpoint, MSI 00
        DevCap:    MaxPayload 256 bytes, PhantFunc 0, Latency L0s
unlimited, L1 unlimited
            ExtTag- AttnBtn- AttnInd- PwrInd- RBE+ FLReset+
SlotPowerLimit 75.000W
        DevCtl:    CorrErr+ NonFatalErr+ FatalErr+ UnsupReq+
            RlxdOrd+ ExtTag- PhantFunc- AuxPwr- NoSnoop+ FLReset-
            MaxPayload 256 bytes, MaxReadReq 512 bytes
        DevSta:    CorrErr+ NonFatalErr- FatalErr- UnsupReq+ AuxPwr-
TransPend-
        LnkCap:    Port #0, Speed 8GT/s, Width x4, ASPM L1, Exit Latency
L1 <64us
            ClockPM- Surprise- LLActRep- BwNot- ASPMOptComp+
        LnkCtl:    ASPM L1 Enabled; RCB 64 bytes, Disabled- CommClk+
            ExtSynch- ClockPM- AutWidDis- BWInt- AutBWInt-
        LnkSta:    Speed 8GT/s (ok), Width x4 (ok)
            TrErr- Train- SlotClk+ DLActive- BWMgmt- ABWMgmt-
        DevCap2: Completion Timeout: Range B, TimeoutDis+ NROPrPrP- LTR+
             10BitTagComp- 10BitTagReq- OBFF Not Supported, ExtFmt+
EETLPPrefix-
             EmergencyPowerReduction Not Supported,
EmergencyPowerReductionInit-
             FRS- TPHComp- ExtTPHComp-
             AtomicOpsCap: 32bit- 64bit- 128bitCAS-
        DevCtl2: Completion Timeout: 50us to 50ms, TimeoutDis- LTR+ OBFF
Disabled,
             AtomicOpsCtl: ReqEn-
        LnkCap2: Supported Link Speeds: 2.5-8GT/s, Crosslink- Retimer-
2Retimers- DRS-
        LnkCtl2: Target Link Speed: 8GT/s, EnterCompliance- SpeedDis-
             Transmit Margin: Normal Operating Range,
EnterModifiedCompliance- ComplianceSOS-
             Compliance De-emphasis: -6dB
        LnkSta2: Current De-emphasis Level: -3.5dB,
EqualizationComplete+ EqualizationPhase1+
             EqualizationPhase2+ EqualizationPhase3+
LinkEqualizationRequest-
             Retimer- 2Retimers- CrosslinkRes: unsupported
    Capabilities: [100 v2] Advanced Error Reporting
        UESta:    DLP- SDES- TLP- FCP- CmpltTO- CmpltAbrt- UnxCmplt-
RxOF- MalfTLP- ECRC- UnsupReq- ACSViol-
        UEMsk:    DLP- SDES- TLP- FCP- CmpltTO- CmpltAbrt- UnxCmplt-
RxOF- MalfTLP- ECRC- UnsupReq- ACSViol-
        UESvrt:    DLP+ SDES+ TLP- FCP+ CmpltTO- CmpltAbrt- UnxCmplt-
RxOF+ MalfTLP+ ECRC- UnsupReq- ACSViol-
        CESta:    RxErr- BadTLP- BadDLLP- Rollover- Timeout- AdvNonFatalErr-
        CEMsk:    RxErr- BadTLP- BadDLLP- Rollover- Timeout- AdvNonFatalErr-
        AERCap:    First Error Pointer: 00, ECRCGenCap+ ECRCGenEn-
ECRCChkCap+ ECRCChkEn-
            MultHdrRecCap- MultHdrRecEn- TLPPfxPres- HdrLogCap-
        HeaderLog: 04000001 0000210f 01010008 00000000
    Capabilities: [150 v1] Device Serial Number 00-00-00-00-00-00-00-00
    Capabilities: [160 v1] Power Budgeting <?>
    Capabilities: [1b8 v1] Latency Tolerance Reporting
        Max snoop latency: 1048576ns
        Max no snoop latency: 1048576ns
    Capabilities: [300 v1] Secondary PCI Express
        LnkCtl3: LnkEquIntrruptEn- PerformEqu-
        LaneErrStat: 0
    Capabilities: [400 v1] Vendor Specific Information: ID=0001 Rev=1
Len=010 <?>
    Capabilities: [900 v1] L1 PM Substates
        L1SubCap: PCI-PM_L1.2+ PCI-PM_L1.1+ ASPM_L1.2+ ASPM_L1.1+
L1_PM_Substates+
              PortCommonModeRestoreTime=24us PortTPowerOnTime=50us
        L1SubCtl1: PCI-PM_L1.2+ PCI-PM_L1.1+ ASPM_L1.2+ ASPM_L1.1+
               T_CommonMode=0us LTR1.2_Threshold=163840ns
        L1SubCtl2: T_PwrOn=150us
    Kernel driver in use: nvme
    Kernel modules: nvme

02:00.0 Ethernet controller [0200]: Realtek Semiconductor Co., Ltd.
RTL8111/8168/8411 PCI Express Gigabit Ethernet Controller [10ec:8168]
(rev 0e)
    Subsystem: Lenovo Device [17aa:5081]
    Control: I/O+ Mem+ BusMaster- SpecCycle- MemWINV- VGASnoop- ParErr-
Stepping- SERR- FastB2B- DisINTx-
    Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort-
<TAbort- <MAbort- >SERR- <PERR- INTx-
    Interrupt: pin A routed to IRQ 40
    Region 0: I/O ports at 3400 [size=256]
    Region 2: Memory at fd814000 (64-bit, non-prefetchable) [size=4K]
    Region 4: Memory at fd800000 (64-bit, non-prefetchable) [size=16K]
    Capabilities: [40] Power Management version 3
        Flags: PMEClk- DSI- D1+ D2+ AuxCurrent=375mA
PME(D0+,D1+,D2+,D3hot+,D3cold+)
        Status: D0 NoSoftRst+ PME-Enable- DSel=0 DScale=0 PME-
    Capabilities: [50] MSI: Enable- Count=1/1 Maskable- 64bit+
        Address: 0000000000000000  Data: 0000
    Capabilities: [70] Express (v2) Endpoint, MSI 01
        DevCap:    MaxPayload 128 bytes, PhantFunc 0, Latency L0s
unlimited, L1 <64us
            ExtTag- AttnBtn- AttnInd- PwrInd- RBE+ FLReset-
SlotPowerLimit 0.000W
        DevCtl:    CorrErr- NonFatalErr- FatalErr- UnsupReq-
            RlxdOrd+ ExtTag- PhantFunc- AuxPwr- NoSnoop-
            MaxPayload 128 bytes, MaxReadReq 512 bytes
        DevSta:    CorrErr+ NonFatalErr- FatalErr- UnsupReq+ AuxPwr+
TransPend-
        LnkCap:    Port #0, Speed 2.5GT/s, Width x1, ASPM L0s L1, Exit
Latency L0s unlimited, L1 <64us
            ClockPM+ Surprise- LLActRep- BwNot- ASPMOptComp+
        LnkCtl:    ASPM L1 Enabled; RCB 64 bytes, Disabled- CommClk+
            ExtSynch- ClockPM+ AutWidDis- BWInt- AutBWInt-
        LnkSta:    Speed 2.5GT/s (ok), Width x1 (ok)
            TrErr- Train- SlotClk+ DLActive- BWMgmt- ABWMgmt-
        DevCap2: Completion Timeout: Range ABCD, TimeoutDis+ NROPrPrP- LTR+
             10BitTagComp- 10BitTagReq- OBFF Via message/WAKE#, ExtFmt-
EETLPPrefix-
             EmergencyPowerReduction Not Supported,
EmergencyPowerReductionInit-
             FRS- TPHComp- ExtTPHComp-
             AtomicOpsCap: 32bit- 64bit- 128bitCAS-
        DevCtl2: Completion Timeout: 50us to 50ms, TimeoutDis- LTR+ OBFF
Disabled,
             AtomicOpsCtl: ReqEn-
        LnkCap2: Supported Link Speeds: 2.5GT/s, Crosslink- Retimer-
2Retimers- DRS-
        LnkCtl2: Target Link Speed: 2.5GT/s, EnterCompliance- SpeedDis-
             Transmit Margin: Normal Operating Range,
EnterModifiedCompliance- ComplianceSOS-
             Compliance De-emphasis: -6dB
        LnkSta2: Current De-emphasis Level: -6dB, EqualizationComplete-
EqualizationPhase1-
             EqualizationPhase2- EqualizationPhase3-
LinkEqualizationRequest-
             Retimer- 2Retimers- CrosslinkRes: unsupported
    Capabilities: [b0] MSI-X: Enable- Count=4 Masked-
        Vector table: BAR=4 offset=00000000
        PBA: BAR=4 offset=00000800
    Capabilities: [d0] Vital Product Data
        Not readable
    Capabilities: [100 v2] Advanced Error Reporting
        UESta:    DLP- SDES- TLP- FCP- CmpltTO- CmpltAbrt- UnxCmplt-
RxOF- MalfTLP- ECRC- UnsupReq- ACSViol-
        UEMsk:    DLP- SDES- TLP- FCP- CmpltTO- CmpltAbrt- UnxCmplt-
RxOF- MalfTLP- ECRC- UnsupReq- ACSViol-
        UESvrt:    DLP+ SDES+ TLP- FCP+ CmpltTO- CmpltAbrt- UnxCmplt-
RxOF+ MalfTLP+ ECRC- UnsupReq- ACSViol-
        CESta:    RxErr- BadTLP- BadDLLP- Rollover- Timeout- AdvNonFatalErr-
        CEMsk:    RxErr- BadTLP- BadDLLP- Rollover- Timeout- AdvNonFatalErr+
        AERCap:    First Error Pointer: 00, ECRCGenCap+ ECRCGenEn-
ECRCChkCap+ ECRCChkEn-
            MultHdrRecCap- MultHdrRecEn- TLPPfxPres- HdrLogCap-
        HeaderLog: 00000000 00000000 00000000 00000000
    Capabilities: [140 v1] Virtual Channel
        Caps:    LPEVC=0 RefClk=100ns PATEntryBits=1
        Arb:    Fixed- WRR32- WRR64- WRR128-
        Ctrl:    ArbSelect=Fixed
        Status:    InProgress-
        VC0:    Caps:    PATOffset=00 MaxTimeSlots=1 RejSnoopTrans-
            Arb:    Fixed- WRR32- WRR64- WRR128- TWRR128- WRR256-
            Ctrl:    Enable+ ID=0 ArbSelect=Fixed TC/VC=ff
            Status:    NegoPending- InProgress-
    Capabilities: [160 v1] Device Serial Number 01-00-00-00-68-4c-e0-00
    Capabilities: [170 v1] Latency Tolerance Reporting
        Max snoop latency: 1048576ns
        Max no snoop latency: 1048576ns
    Capabilities: [178 v1] L1 PM Substates
        L1SubCap: PCI-PM_L1.2+ PCI-PM_L1.1+ ASPM_L1.2+ ASPM_L1.1+
L1_PM_Substates+
              PortCommonModeRestoreTime=150us PortTPowerOnTime=150us
        L1SubCtl1: PCI-PM_L1.2+ PCI-PM_L1.1+ ASPM_L1.2+ ASPM_L1.1+
               T_CommonMode=0us LTR1.2_Threshold=294912ns
        L1SubCtl2: T_PwrOn=150us
    Kernel driver in use: pciback
    Kernel modules: r8169

02:00.1 Serial controller [0700]: Realtek Semiconductor Co., Ltd.
RTL8111xP UART #1 [10ec:816a] (rev 0e) (prog-if 02 [16550])
    Subsystem: Lenovo Device [17aa:5081]
    Control: I/O+ Mem+ BusMaster- SpecCycle- MemWINV- VGASnoop- ParErr-
Stepping- SERR- FastB2B- DisINTx-
    Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort-
<TAbort- <MAbort- >SERR- <PERR- INTx-
    Interrupt: pin B routed to IRQ 41
    Region 0: I/O ports at 3200 [size=256]
    Region 2: Memory at fd815000 (64-bit, non-prefetchable) [size=4K]
    Region 4: Memory at fd804000 (64-bit, non-prefetchable) [size=16K]
    Capabilities: [40] Power Management version 3
        Flags: PMEClk- DSI- D1+ D2+ AuxCurrent=375mA
PME(D0+,D1+,D2+,D3hot+,D3cold+)
        Status: D0 NoSoftRst+ PME-Enable- DSel=0 DScale=0 PME-
    Capabilities: [50] MSI: Enable- Count=1/1 Maskable- 64bit+
        Address: 0000000000000000  Data: 0000
    Capabilities: [70] Express (v2) Endpoint, MSI 01
        DevCap:    MaxPayload 128 bytes, PhantFunc 0, Latency L0s
unlimited, L1 <64us
            ExtTag- AttnBtn- AttnInd- PwrInd- RBE+ FLReset-
SlotPowerLimit 0.000W
        DevCtl:    CorrErr- NonFatalErr- FatalErr- UnsupReq-
            RlxdOrd+ ExtTag- PhantFunc- AuxPwr- NoSnoop-
            MaxPayload 128 bytes, MaxReadReq 512 bytes
        DevSta:    CorrErr+ NonFatalErr- FatalErr- UnsupReq+ AuxPwr+
TransPend-
        LnkCap:    Port #0, Speed 2.5GT/s, Width x1, ASPM L0s L1, Exit
Latency L0s unlimited, L1 <64us
            ClockPM+ Surprise- LLActRep- BwNot- ASPMOptComp+
        LnkCtl:    ASPM L1 Enabled; RCB 64 bytes, Disabled- CommClk+
            ExtSynch- ClockPM- AutWidDis- BWInt- AutBWInt-
        LnkSta:    Speed 2.5GT/s (ok), Width x1 (ok)
            TrErr- Train- SlotClk+ DLActive- BWMgmt- ABWMgmt-
        DevCap2: Completion Timeout: Range ABCD, TimeoutDis+ NROPrPrP- LTR+
             10BitTagComp- 10BitTagReq- OBFF Via message/WAKE#, ExtFmt-
EETLPPrefix-
             EmergencyPowerReduction Not Supported,
EmergencyPowerReductionInit-
             FRS- TPHComp- ExtTPHComp-
             AtomicOpsCap: 32bit- 64bit- 128bitCAS-
        DevCtl2: Completion Timeout: 50us to 50ms, TimeoutDis- LTR- OBFF
Disabled,
             AtomicOpsCtl: ReqEn-
        LnkSta2: Current De-emphasis Level: -6dB, EqualizationComplete-
EqualizationPhase1-
             EqualizationPhase2- EqualizationPhase3-
LinkEqualizationRequest-
             Retimer- 2Retimers- CrosslinkRes: unsupported
    Capabilities: [b0] MSI-X: Enable- Count=4 Masked-
        Vector table: BAR=4 offset=00000000
        PBA: BAR=4 offset=00000800
    Capabilities: [d0] Vital Product Data
        Not readable
    Capabilities: [100 v2] Advanced Error Reporting
        UESta:    DLP- SDES- TLP- FCP- CmpltTO- CmpltAbrt- UnxCmplt-
RxOF- MalfTLP- ECRC- UnsupReq- ACSViol-
        UEMsk:    DLP- SDES- TLP- FCP- CmpltTO- CmpltAbrt- UnxCmplt-
RxOF- MalfTLP- ECRC- UnsupReq- ACSViol-
        UESvrt:    DLP+ SDES+ TLP- FCP+ CmpltTO- CmpltAbrt- UnxCmplt-
RxOF+ MalfTLP+ ECRC- UnsupReq- ACSViol-
        CESta:    RxErr- BadTLP- BadDLLP- Rollover- Timeout- AdvNonFatalErr+
        CEMsk:    RxErr- BadTLP- BadDLLP- Rollover- Timeout- AdvNonFatalErr+
        AERCap:    First Error Pointer: 00, ECRCGenCap+ ECRCGenEn-
ECRCChkCap+ ECRCChkEn-
            MultHdrRecCap- MultHdrRecEn- TLPPfxPres- HdrLogCap-
        HeaderLog: 00000000 00000000 00000000 00000000
    Capabilities: [160 v1] Device Serial Number 00-00-00-00-00-00-00-00
    Capabilities: [170 v1] Latency Tolerance Reporting
        Max snoop latency: 1048576ns
        Max no snoop latency: 1048576ns
    Capabilities: [178 v1] L1 PM Substates
        L1SubCap: PCI-PM_L1.2+ PCI-PM_L1.1+ ASPM_L1.2+ ASPM_L1.1+
L1_PM_Substates+
              PortCommonModeRestoreTime=150us PortTPowerOnTime=150us
        L1SubCtl1: PCI-PM_L1.2+ PCI-PM_L1.1+ ASPM_L1.2+ ASPM_L1.1+
               T_CommonMode=0us LTR1.2_Threshold=294912ns
        L1SubCtl2: T_PwrOn=150us
    Kernel driver in use: serial

02:00.2 Serial controller [0700]: Realtek Semiconductor Co., Ltd.
RTL8111xP UART #2 [10ec:816b] (rev 0e) (prog-if 02 [16550])
    Subsystem: Lenovo Device [17aa:5081]
    Control: I/O+ Mem+ BusMaster- SpecCycle- MemWINV- VGASnoop- ParErr-
Stepping- SERR- FastB2B- DisINTx-
    Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort-
<TAbort- <MAbort- >SERR- <PERR- INTx-
    Interrupt: pin C routed to IRQ 42
    Region 0: I/O ports at 3100 [size=256]
    Region 2: Memory at fd816000 (64-bit, non-prefetchable) [size=4K]
    Region 4: Memory at fd808000 (64-bit, non-prefetchable) [size=16K]
    Capabilities: [40] Power Management version 3
        Flags: PMEClk- DSI- D1+ D2+ AuxCurrent=375mA
PME(D0+,D1+,D2+,D3hot+,D3cold+)
        Status: D0 NoSoftRst+ PME-Enable- DSel=0 DScale=0 PME-
    Capabilities: [50] MSI: Enable- Count=1/1 Maskable- 64bit+
        Address: 0000000000000000  Data: 0000
    Capabilities: [70] Express (v2) Endpoint, MSI 01
        DevCap:    MaxPayload 128 bytes, PhantFunc 0, Latency L0s
unlimited, L1 <64us
            ExtTag- AttnBtn- AttnInd- PwrInd- RBE+ FLReset-
SlotPowerLimit 0.000W
        DevCtl:    CorrErr- NonFatalErr- FatalErr- UnsupReq-
            RlxdOrd+ ExtTag- PhantFunc- AuxPwr- NoSnoop-
            MaxPayload 128 bytes, MaxReadReq 512 bytes
        DevSta:    CorrErr+ NonFatalErr- FatalErr- UnsupReq+ AuxPwr+
TransPend-
        LnkCap:    Port #0, Speed 2.5GT/s, Width x1, ASPM L0s L1, Exit
Latency L0s unlimited, L1 <64us
            ClockPM+ Surprise- LLActRep- BwNot- ASPMOptComp+
        LnkCtl:    ASPM L1 Enabled; RCB 64 bytes, Disabled- CommClk+
            ExtSynch- ClockPM- AutWidDis- BWInt- AutBWInt-
        LnkSta:    Speed 2.5GT/s (ok), Width x1 (ok)
            TrErr- Train- SlotClk+ DLActive- BWMgmt- ABWMgmt-
        DevCap2: Completion Timeout: Range ABCD, TimeoutDis+ NROPrPrP- LTR+
             10BitTagComp- 10BitTagReq- OBFF Via message/WAKE#, ExtFmt-
EETLPPrefix-
             EmergencyPowerReduction Not Supported,
EmergencyPowerReductionInit-
             FRS- TPHComp- ExtTPHComp-
             AtomicOpsCap: 32bit- 64bit- 128bitCAS-
        DevCtl2: Completion Timeout: 50us to 50ms, TimeoutDis- LTR- OBFF
Disabled,
             AtomicOpsCtl: ReqEn-
        LnkSta2: Current De-emphasis Level: -6dB, EqualizationComplete-
EqualizationPhase1-
             EqualizationPhase2- EqualizationPhase3-
LinkEqualizationRequest-
             Retimer- 2Retimers- CrosslinkRes: unsupported
    Capabilities: [b0] MSI-X: Enable- Count=4 Masked-
        Vector table: BAR=4 offset=00000000
        PBA: BAR=4 offset=00000800
    Capabilities: [d0] Vital Product Data
        Not readable
    Capabilities: [100 v2] Advanced Error Reporting
        UESta:    DLP- SDES- TLP- FCP- CmpltTO- CmpltAbrt- UnxCmplt-
RxOF- MalfTLP- ECRC- UnsupReq- ACSViol-
        UEMsk:    DLP- SDES- TLP- FCP- CmpltTO- CmpltAbrt- UnxCmplt-
RxOF- MalfTLP- ECRC- UnsupReq- ACSViol-
        UESvrt:    DLP+ SDES+ TLP- FCP+ CmpltTO- CmpltAbrt- UnxCmplt-
RxOF+ MalfTLP+ ECRC- UnsupReq- ACSViol-
        CESta:    RxErr- BadTLP- BadDLLP- Rollover- Timeout- AdvNonFatalErr+
        CEMsk:    RxErr- BadTLP- BadDLLP- Rollover- Timeout- AdvNonFatalErr+
        AERCap:    First Error Pointer: 00, ECRCGenCap+ ECRCGenEn-
ECRCChkCap+ ECRCChkEn-
            MultHdrRecCap- MultHdrRecEn- TLPPfxPres- HdrLogCap-
        HeaderLog: 00000000 00000000 00000000 00000000
    Capabilities: [160 v1] Device Serial Number 00-00-00-00-00-00-00-00
    Capabilities: [170 v1] Latency Tolerance Reporting
        Max snoop latency: 1048576ns
        Max no snoop latency: 1048576ns
    Capabilities: [178 v1] L1 PM Substates
        L1SubCap: PCI-PM_L1.2+ PCI-PM_L1.1+ ASPM_L1.2+ ASPM_L1.1+
L1_PM_Substates+
              PortCommonModeRestoreTime=150us PortTPowerOnTime=150us
        L1SubCtl1: PCI-PM_L1.2+ PCI-PM_L1.1+ ASPM_L1.2+ ASPM_L1.1+
               T_CommonMode=0us LTR1.2_Threshold=294912ns
        L1SubCtl2: T_PwrOn=150us
    Kernel driver in use: serial

02:00.3 IPMI Interface [0c07]: Realtek Semiconductor Co., Ltd. RTL8111xP
IPMI interface [10ec:816c] (rev 0e) (prog-if 01 [KCS])
    Subsystem: Lenovo Device [17aa:5081]
    Control: I/O- Mem- BusMaster- SpecCycle- MemWINV- VGASnoop- ParErr-
Stepping- SERR- FastB2B- DisINTx-
    Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort-
<TAbort- <MAbort- >SERR- <PERR- INTx-
    Interrupt: pin D routed to IRQ 255
    Region 0: I/O ports at 3000 [disabled] [size=256]
    Region 2: Memory at fd817000 (64-bit, non-prefetchable) [disabled]
[size=4K]
    Region 4: Memory at fd80c000 (64-bit, non-prefetchable) [disabled]
[size=16K]
    Capabilities: [40] Power Management version 3
        Flags: PMEClk- DSI- D1+ D2+ AuxCurrent=375mA
PME(D0+,D1+,D2+,D3hot+,D3cold+)
        Status: D0 NoSoftRst+ PME-Enable- DSel=0 DScale=0 PME-
    Capabilities: [50] MSI: Enable- Count=1/1 Maskable- 64bit+
        Address: 0000000000000000  Data: 0000
    Capabilities: [70] Express (v2) Endpoint, MSI 01
        DevCap:    MaxPayload 128 bytes, PhantFunc 0, Latency L0s
unlimited, L1 <64us
            ExtTag- AttnBtn- AttnInd- PwrInd- RBE+ FLReset-
SlotPowerLimit 0.000W
        DevCtl:    CorrErr- NonFatalErr- FatalErr- UnsupReq-
            RlxdOrd+ ExtTag- PhantFunc- AuxPwr- NoSnoop-
            MaxPayload 128 bytes, MaxReadReq 512 bytes
        DevSta:    CorrErr+ NonFatalErr- FatalErr- UnsupReq+ AuxPwr+
TransPend-
        LnkCap:    Port #0, Speed 2.5GT/s, Width x1, ASPM L0s L1, Exit
Latency L0s unlimited, L1 <64us
            ClockPM+ Surprise- LLActRep- BwNot- ASPMOptComp+
        LnkCtl:    ASPM L1 Enabled; RCB 64 bytes, Disabled- CommClk+
            ExtSynch- ClockPM- AutWidDis- BWInt- AutBWInt-
        LnkSta:    Speed 2.5GT/s (ok), Width x1 (ok)
            TrErr- Train- SlotClk+ DLActive- BWMgmt- ABWMgmt-
        DevCap2: Completion Timeout: Range ABCD, TimeoutDis+ NROPrPrP- LTR+
             10BitTagComp- 10BitTagReq- OBFF Via message/WAKE#, ExtFmt-
EETLPPrefix-
             EmergencyPowerReduction Not Supported,
EmergencyPowerReductionInit-
             FRS- TPHComp- ExtTPHComp-
             AtomicOpsCap: 32bit- 64bit- 128bitCAS-
        DevCtl2: Completion Timeout: 50us to 50ms, TimeoutDis- LTR- OBFF
Disabled,
             AtomicOpsCtl: ReqEn-
        LnkSta2: Current De-emphasis Level: -6dB, EqualizationComplete-
EqualizationPhase1-
             EqualizationPhase2- EqualizationPhase3-
LinkEqualizationRequest-
             Retimer- 2Retimers- CrosslinkRes: unsupported
    Capabilities: [b0] MSI-X: Enable- Count=4 Masked-
        Vector table: BAR=4 offset=00000000
        PBA: BAR=4 offset=00000800
    Capabilities: [d0] Vital Product Data
        Not readable
    Capabilities: [100 v2] Advanced Error Reporting
        UESta:    DLP- SDES- TLP- FCP- CmpltTO- CmpltAbrt- UnxCmplt-
RxOF- MalfTLP- ECRC- UnsupReq- ACSViol-
        UEMsk:    DLP- SDES- TLP- FCP- CmpltTO- CmpltAbrt- UnxCmplt-
RxOF- MalfTLP- ECRC- UnsupReq- ACSViol-
        UESvrt:    DLP+ SDES+ TLP- FCP+ CmpltTO- CmpltAbrt- UnxCmplt-
RxOF+ MalfTLP+ ECRC- UnsupReq- ACSViol-
        CESta:    RxErr- BadTLP- BadDLLP- Rollover- Timeout- AdvNonFatalErr+
        CEMsk:    RxErr- BadTLP- BadDLLP- Rollover- Timeout- AdvNonFatalErr+
        AERCap:    First Error Pointer: 00, ECRCGenCap+ ECRCGenEn-
ECRCChkCap+ ECRCChkEn-
            MultHdrRecCap- MultHdrRecEn- TLPPfxPres- HdrLogCap-
        HeaderLog: 00000000 00000000 00000000 00000000
    Capabilities: [160 v1] Device Serial Number 00-00-00-00-00-00-00-00
    Capabilities: [170 v1] Latency Tolerance Reporting
        Max snoop latency: 1048576ns
        Max no snoop latency: 1048576ns
    Capabilities: [178 v1] L1 PM Substates
        L1SubCap: PCI-PM_L1.2+ PCI-PM_L1.1+ ASPM_L1.2+ ASPM_L1.1+
L1_PM_Substates+
              PortCommonModeRestoreTime=150us PortTPowerOnTime=150us
        L1SubCtl1: PCI-PM_L1.2+ PCI-PM_L1.1+ ASPM_L1.2+ ASPM_L1.1+
               T_CommonMode=0us LTR1.2_Threshold=294912ns
        L1SubCtl2: T_PwrOn=150us
    Kernel modules: ipmi_si

02:00.4 USB controller [0c03]: Realtek Semiconductor Co., Ltd. RTL811x
EHCI host controller [10ec:816d] (rev 0e) (prog-if 20 [EHCI])
    Subsystem: Lenovo Device [17aa:5081]
    Control: I/O- Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr-
Stepping- SERR- FastB2B- DisINTx+
    Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort-
<TAbort- <MAbort- >SERR- <PERR- INTx-
    Latency: 0, Cache Line Size: 32 bytes
    Interrupt: pin D routed to IRQ 114
    Region 0: Memory at fd818000 (32-bit, non-prefetchable) [size=4K]
    Region 2: Memory at fd810000 (64-bit, non-prefetchable) [size=16K]
    Capabilities: [40] Power Management version 3
        Flags: PMEClk- DSI- D1+ D2+ AuxCurrent=375mA
PME(D0+,D1+,D2+,D3hot+,D3cold+)
        Status: D0 NoSoftRst+ PME-Enable- DSel=0 DScale=0 PME-
    Capabilities: [50] MSI: Enable+ Count=1/1 Maskable- 64bit+
        Address: 00000000fee00000  Data: 4000
    Capabilities: [70] Express (v2) Endpoint, MSI 01
        DevCap:    MaxPayload 128 bytes, PhantFunc 0, Latency L0s
unlimited, L1 <64us
            ExtTag- AttnBtn- AttnInd- PwrInd- RBE+ FLReset-
SlotPowerLimit 0.000W
        DevCtl:    CorrErr- NonFatalErr- FatalErr- UnsupReq-
            RlxdOrd+ ExtTag- PhantFunc- AuxPwr- NoSnoop-
            MaxPayload 128 bytes, MaxReadReq 512 bytes
        DevSta:    CorrErr+ NonFatalErr- FatalErr- UnsupReq+ AuxPwr+
TransPend-
        LnkCap:    Port #0, Speed 2.5GT/s, Width x1, ASPM L0s L1, Exit
Latency L0s unlimited, L1 <64us
            ClockPM+ Surprise- LLActRep- BwNot- ASPMOptComp+
        LnkCtl:    ASPM L1 Enabled; RCB 64 bytes, Disabled- CommClk+
            ExtSynch- ClockPM+ AutWidDis- BWInt- AutBWInt-
        LnkSta:    Speed 2.5GT/s (ok), Width x1 (ok)
            TrErr- Train- SlotClk+ DLActive- BWMgmt- ABWMgmt-
        DevCap2: Completion Timeout: Range ABCD, TimeoutDis+ NROPrPrP- LTR+
             10BitTagComp- 10BitTagReq- OBFF Via message/WAKE#, ExtFmt-
EETLPPrefix-
             EmergencyPowerReduction Not Supported,
EmergencyPowerReductionInit-
             FRS- TPHComp- ExtTPHComp-
             AtomicOpsCap: 32bit- 64bit- 128bitCAS-
        DevCtl2: Completion Timeout: 50us to 50ms, TimeoutDis- LTR- OBFF
Disabled,
             AtomicOpsCtl: ReqEn-
        LnkSta2: Current De-emphasis Level: -6dB, EqualizationComplete-
EqualizationPhase1-
             EqualizationPhase2- EqualizationPhase3-
LinkEqualizationRequest-
             Retimer- 2Retimers- CrosslinkRes: unsupported
    Capabilities: [b0] MSI-X: Enable- Count=4 Masked-
        Vector table: BAR=2 offset=00000000
        PBA: BAR=2 offset=00000800
    Capabilities: [d0] Vital Product Data
        Not readable
    Capabilities: [100 v2] Advanced Error Reporting
        UESta:    DLP- SDES- TLP- FCP- CmpltTO- CmpltAbrt- UnxCmplt-
RxOF- MalfTLP- ECRC- UnsupReq- ACSViol-
        UEMsk:    DLP- SDES- TLP- FCP- CmpltTO- CmpltAbrt- UnxCmplt-
RxOF- MalfTLP- ECRC- UnsupReq- ACSViol-
        UESvrt:    DLP+ SDES+ TLP- FCP+ CmpltTO- CmpltAbrt- UnxCmplt-
RxOF+ MalfTLP+ ECRC- UnsupReq- ACSViol-
        CESta:    RxErr- BadTLP- BadDLLP- Rollover- Timeout- AdvNonFatalErr+
        CEMsk:    RxErr- BadTLP- BadDLLP- Rollover- Timeout- AdvNonFatalErr+
        AERCap:    First Error Pointer: 00, ECRCGenCap+ ECRCGenEn-
ECRCChkCap+ ECRCChkEn-
            MultHdrRecCap- MultHdrRecEn- TLPPfxPres- HdrLogCap-
        HeaderLog: 00000000 00000000 00000000 00000000
    Capabilities: [160 v1] Device Serial Number 00-00-00-00-00-00-00-00
    Capabilities: [170 v1] Latency Tolerance Reporting
        Max snoop latency: 1048576ns
        Max no snoop latency: 1048576ns
    Capabilities: [178 v1] L1 PM Substates
        L1SubCap: PCI-PM_L1.2+ PCI-PM_L1.1+ ASPM_L1.2+ ASPM_L1.1+
L1_PM_Substates+
              PortCommonModeRestoreTime=150us PortTPowerOnTime=150us
        L1SubCtl1: PCI-PM_L1.2+ PCI-PM_L1.1+ ASPM_L1.2+ ASPM_L1.1+
               T_CommonMode=0us LTR1.2_Threshold=294912ns
        L1SubCtl2: T_PwrOn=150us
    Kernel driver in use: ehci-pci
    Kernel modules: ehci_pci

03:00.0 Network controller [0280]: Intel Corporation Wi-Fi 6 AX200
[8086:2723] (rev 1a)
    Subsystem: Intel Corporation Device [8086:0080]
    Control: I/O- Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr-
Stepping- SERR- FastB2B- DisINTx+
    Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort-
<TAbort- <MAbort- >SERR- <PERR- INTx-
    Latency: 0, Cache Line Size: 32 bytes
    Interrupt: pin A routed to IRQ 44
    Region 0: Memory at fd700000 (64-bit, non-prefetchable) [size=16K]
    Capabilities: [c8] Power Management version 3
        Flags: PMEClk- DSI+ D1- D2- AuxCurrent=0mA
PME(D0+,D1-,D2-,D3hot+,D3cold+)
        Status: D0 NoSoftRst+ PME-Enable- DSel=0 DScale=0 PME-
    Capabilities: [d0] MSI: Enable+ Count=1/1 Maskable- 64bit+
        Address: 00000000fee06000  Data: 4000
    Capabilities: [40] Express (v2) Endpoint, MSI 00
        DevCap:    MaxPayload 128 bytes, PhantFunc 0, Latency L0s
<512ns, L1 unlimited
            ExtTag- AttnBtn- AttnInd- PwrInd- RBE+ FLReset+
SlotPowerLimit 0.000W
        DevCtl:    CorrErr- NonFatalErr- FatalErr- UnsupReq-
            RlxdOrd- ExtTag- PhantFunc- AuxPwr+ NoSnoop+ FLReset-
            MaxPayload 128 bytes, MaxReadReq 128 bytes
        DevSta:    CorrErr- NonFatalErr- FatalErr- UnsupReq- AuxPwr+
TransPend-
        LnkCap:    Port #6, Speed 5GT/s, Width x1, ASPM L1, Exit Latency
L1 <8us
            ClockPM+ Surprise- LLActRep- BwNot- ASPMOptComp+
        LnkCtl:    ASPM L1 Enabled; RCB 64 bytes, Disabled- CommClk+
            ExtSynch- ClockPM+ AutWidDis- BWInt- AutBWInt-
        LnkSta:    Speed 5GT/s (ok), Width x1 (ok)
            TrErr- Train- SlotClk+ DLActive- BWMgmt- ABWMgmt-
        DevCap2: Completion Timeout: Range B, TimeoutDis+ NROPrPrP- LTR+
             10BitTagComp- 10BitTagReq- OBFF Via WAKE#, ExtFmt- EETLPPrefix-
             EmergencyPowerReduction Not Supported,
EmergencyPowerReductionInit-
             FRS- TPHComp- ExtTPHComp-
             AtomicOpsCap: 32bit- 64bit- 128bitCAS-
        DevCtl2: Completion Timeout: 16ms to 55ms, TimeoutDis- LTR+ OBFF
Disabled,
             AtomicOpsCtl: ReqEn-
        LnkCap2: Supported Link Speeds: 2.5-5GT/s, Crosslink- Retimer-
2Retimers- DRS-
        LnkCtl2: Target Link Speed: 5GT/s, EnterCompliance- SpeedDis-
             Transmit Margin: Normal Operating Range,
EnterModifiedCompliance- ComplianceSOS-
             Compliance De-emphasis: -6dB
        LnkSta2: Current De-emphasis Level: -6dB, EqualizationComplete-
EqualizationPhase1-
             EqualizationPhase2- EqualizationPhase3-
LinkEqualizationRequest-
             Retimer- 2Retimers- CrosslinkRes: unsupported
    Capabilities: [80] MSI-X: Enable- Count=16 Masked-
        Vector table: BAR=0 offset=00002000
        PBA: BAR=0 offset=00003000
    Capabilities: [100 v1] Advanced Error Reporting
        UESta:    DLP- SDES- TLP- FCP- CmpltTO- CmpltAbrt- UnxCmplt-
RxOF- MalfTLP- ECRC- UnsupReq- ACSViol-
        UEMsk:    DLP- SDES- TLP- FCP- CmpltTO- CmpltAbrt- UnxCmplt-
RxOF- MalfTLP- ECRC- UnsupReq- ACSViol-
        UESvrt:    DLP+ SDES+ TLP- FCP+ CmpltTO- CmpltAbrt- UnxCmplt-
RxOF+ MalfTLP+ ECRC- UnsupReq- ACSViol-
        CESta:    RxErr- BadTLP- BadDLLP- Rollover- Timeout- AdvNonFatalErr-
        CEMsk:    RxErr- BadTLP- BadDLLP- Rollover- Timeout- AdvNonFatalErr+
        AERCap:    First Error Pointer: 00, ECRCGenCap- ECRCGenEn-
ECRCChkCap- ECRCChkEn-
            MultHdrRecCap- MultHdrRecEn- TLPPfxPres- HdrLogCap-
        HeaderLog: 00000000 00000000 00000000 00000000
    Capabilities: [14c v1] Latency Tolerance Reporting
        Max snoop latency: 1048576ns
        Max no snoop latency: 1048576ns
    Capabilities: [154 v1] L1 PM Substates
        L1SubCap: PCI-PM_L1.2+ PCI-PM_L1.1+ ASPM_L1.2+ ASPM_L1.1+
L1_PM_Substates+
              PortCommonModeRestoreTime=30us PortTPowerOnTime=18us
        L1SubCtl1: PCI-PM_L1.2+ PCI-PM_L1.1+ ASPM_L1.2+ ASPM_L1.1+
               T_CommonMode=0us LTR1.2_Threshold=163840ns
        L1SubCtl2: T_PwrOn=150us
    Kernel driver in use: pciback
    Kernel modules: iwlwifi

04:00.0 SD Host controller [0805]: Genesys Logic, Inc GL9750 SD Host
Controller [17a0:9750] (rev 01) (prog-if 01)
    Subsystem: Lenovo Device [17aa:5082]
    Control: I/O- Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr-
Stepping- SERR- FastB2B- DisINTx+
    Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort-
<TAbort- <MAbort- >SERR- <PERR- INTx-
    Latency: 0, Cache Line Size: 32 bytes
    Interrupt: pin A routed to IRQ 119
    Region 0: Memory at fd600000 (32-bit, non-prefetchable) [size=4K]
    Capabilities: [80] Express (v2) Endpoint, MSI 00
        DevCap:    MaxPayload 128 bytes, PhantFunc 0, Latency L0s <4us,
L1 unlimited
            ExtTag+ AttnBtn- AttnInd- PwrInd- RBE+ FLReset-
SlotPowerLimit 0.000W
        DevCtl:    CorrErr- NonFatalErr- FatalErr- UnsupReq-
            RlxdOrd+ ExtTag+ PhantFunc- AuxPwr- NoSnoop+
            MaxPayload 128 bytes, MaxReadReq 512 bytes
        DevSta:    CorrErr+ NonFatalErr- FatalErr- UnsupReq+ AuxPwr+
TransPend-
        LnkCap:    Port #80, Speed 2.5GT/s, Width x1, ASPM L0s L1, Exit
Latency L0s <4us, L1 unlimited
            ClockPM+ Surprise- LLActRep- BwNot- ASPMOptComp+
        LnkCtl:    ASPM L1 Enabled; RCB 64 bytes, Disabled- CommClk+
            ExtSynch- ClockPM+ AutWidDis- BWInt- AutBWInt-
        LnkSta:    Speed 2.5GT/s (ok), Width x1 (ok)
            TrErr- Train- SlotClk+ DLActive- BWMgmt- ABWMgmt-
        DevCap2: Completion Timeout: Range ABCD, TimeoutDis+ NROPrPrP- LTR+
             10BitTagComp- 10BitTagReq- OBFF Via message/WAKE#, ExtFmt-
EETLPPrefix-
             EmergencyPowerReduction Not Supported,
EmergencyPowerReductionInit-
             FRS- TPHComp- ExtTPHComp-
             AtomicOpsCap: 32bit- 64bit- 128bitCAS-
        DevCtl2: Completion Timeout: 50us to 50ms, TimeoutDis- LTR+ OBFF
Disabled,
             AtomicOpsCtl: ReqEn-
        LnkCap2: Supported Link Speeds: 2.5GT/s, Crosslink- Retimer-
2Retimers- DRS-
        LnkCtl2: Target Link Speed: 2.5GT/s, EnterCompliance- SpeedDis-
             Transmit Margin: Normal Operating Range,
EnterModifiedCompliance- ComplianceSOS-
             Compliance De-emphasis: -6dB
        LnkSta2: Current De-emphasis Level: -6dB, EqualizationComplete-
EqualizationPhase1-
             EqualizationPhase2- EqualizationPhase3-
LinkEqualizationRequest-
             Retimer- 2Retimers- CrosslinkRes: unsupported
    Capabilities: [e0] MSI: Enable+ Count=1/1 Maskable- 64bit+
        Address: 00000000fee00000  Data: 4000
    Capabilities: [f8] Power Management version 3
        Flags: PMEClk- DSI- D1+ D2+ AuxCurrent=375mA
PME(D0-,D1+,D2+,D3hot+,D3cold+)
        Status: D0 NoSoftRst+ PME-Enable- DSel=0 DScale=0 PME-
    Capabilities: [100 v1] Vendor Specific Information: ID=17a0 Rev=1
Len=008 <?>
    Capabilities: [108 v1] Latency Tolerance Reporting
        Max snoop latency: 1048576ns
        Max no snoop latency: 1048576ns
    Capabilities: [110 v1] L1 PM Substates
        L1SubCap: PCI-PM_L1.2+ PCI-PM_L1.1+ ASPM_L1.2+ ASPM_L1.1+
L1_PM_Substates+
              PortCommonModeRestoreTime=255us PortTPowerOnTime=3100us
        L1SubCtl1: PCI-PM_L1.2+ PCI-PM_L1.1+ ASPM_L1.2+ ASPM_L1.1+
               T_CommonMode=0us LTR1.2_Threshold=3145728ns
        L1SubCtl2: T_PwrOn=3100us
    Capabilities: [200 v1] Advanced Error Reporting
        UESta:    DLP- SDES- TLP- FCP- CmpltTO- CmpltAbrt- UnxCmplt-
RxOF- MalfTLP- ECRC- UnsupReq- ACSViol-
        UEMsk:    DLP- SDES- TLP- FCP- CmpltTO- CmpltAbrt- UnxCmplt-
RxOF- MalfTLP- ECRC- UnsupReq- ACSViol-
        UESvrt:    DLP+ SDES+ TLP- FCP+ CmpltTO- CmpltAbrt- UnxCmplt-
RxOF+ MalfTLP+ ECRC- UnsupReq- ACSViol-
        CESta:    RxErr- BadTLP- BadDLLP- Rollover- Timeout- AdvNonFatalErr-
        CEMsk:    RxErr- BadTLP- BadDLLP- Rollover- Timeout- AdvNonFatalErr+
        AERCap:    First Error Pointer: 00, ECRCGenCap- ECRCGenEn-
ECRCChkCap- ECRCChkEn-
            MultHdrRecCap- MultHdrRecEn- TLPPfxPres- HdrLogCap-
        HeaderLog: 04000001 0000200f 04010008 1c5ad006
    Kernel driver in use: sdhci-pci
    Kernel modules: sdhci_pci

05:00.0 Ethernet controller [0200]: Realtek Semiconductor Co., Ltd.
RTL8111/8168/8411 PCI Express Gigabit Ethernet Controller [10ec:8168]
(rev 15)
    Subsystem: Lenovo Device [17aa:5081]
    Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr-
Stepping- SERR- FastB2B- DisINTx+
    Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort-
<TAbort- <MAbort- >SERR- <PERR- INTx-
    Latency: 0, Cache Line Size: 32 bytes
    Interrupt: pin A routed to IRQ 46
    Region 0: I/O ports at 2000 [size=256]
    Region 2: Memory at fd504000 (64-bit, non-prefetchable) [size=4K]
    Region 4: Memory at fd500000 (64-bit, non-prefetchable) [size=16K]
    Capabilities: [40] Power Management version 3
        Flags: PMEClk- DSI- D1+ D2+ AuxCurrent=375mA
PME(D0+,D1+,D2+,D3hot+,D3cold+)
        Status: D0 NoSoftRst+ PME-Enable- DSel=0 DScale=0 PME-
    Capabilities: [50] MSI: Enable+ Count=1/1 Maskable- 64bit+
        Address: 00000000fee0a000  Data: 4000
    Capabilities: [70] Express (v2) Endpoint, MSI 01
        DevCap:    MaxPayload 128 bytes, PhantFunc 0, Latency L0s
<512ns, L1 <64us
            ExtTag- AttnBtn- AttnInd- PwrInd- RBE+ FLReset-
SlotPowerLimit 0.000W
        DevCtl:    CorrErr- NonFatalErr- FatalErr- UnsupReq-
            RlxdOrd+ ExtTag- PhantFunc- AuxPwr- NoSnoop-
            MaxPayload 128 bytes, MaxReadReq 512 bytes
        DevSta:    CorrErr- NonFatalErr- FatalErr- UnsupReq- AuxPwr+
TransPend-
        LnkCap:    Port #0, Speed 2.5GT/s, Width x1, ASPM L0s L1, Exit
Latency L0s unlimited, L1 <64us
            ClockPM+ Surprise- LLActRep- BwNot- ASPMOptComp+
        LnkCtl:    ASPM L1 Enabled; RCB 64 bytes, Disabled- CommClk+
            ExtSynch- ClockPM+ AutWidDis- BWInt- AutBWInt-
        LnkSta:    Speed 2.5GT/s (ok), Width x1 (ok)
            TrErr- Train- SlotClk+ DLActive- BWMgmt- ABWMgmt-
        DevCap2: Completion Timeout: Range ABCD, TimeoutDis+ NROPrPrP- LTR+
             10BitTagComp- 10BitTagReq- OBFF Via message/WAKE#, ExtFmt-
EETLPPrefix-
             EmergencyPowerReduction Not Supported,
EmergencyPowerReductionInit-
             FRS- TPHComp- ExtTPHComp-
             AtomicOpsCap: 32bit- 64bit- 128bitCAS-
        DevCtl2: Completion Timeout: 50us to 50ms, TimeoutDis- LTR+ OBFF
Disabled,
             AtomicOpsCtl: ReqEn-
        LnkCap2: Supported Link Speeds: 2.5GT/s, Crosslink- Retimer-
2Retimers- DRS-
        LnkCtl2: Target Link Speed: 2.5GT/s, EnterCompliance- SpeedDis-
             Transmit Margin: Normal Operating Range,
EnterModifiedCompliance- ComplianceSOS-
             Compliance De-emphasis: -6dB
        LnkSta2: Current De-emphasis Level: -6dB, EqualizationComplete-
EqualizationPhase1-
             EqualizationPhase2- EqualizationPhase3-
LinkEqualizationRequest-
             Retimer- 2Retimers- CrosslinkRes: unsupported
    Capabilities: [b0] MSI-X: Enable- Count=4 Masked-
        Vector table: BAR=4 offset=00000000
        PBA: BAR=4 offset=00000800
    Capabilities: [100 v2] Advanced Error Reporting
        UESta:    DLP- SDES- TLP- FCP- CmpltTO- CmpltAbrt- UnxCmplt-
RxOF- MalfTLP- ECRC- UnsupReq- ACSViol-
        UEMsk:    DLP- SDES- TLP- FCP- CmpltTO- CmpltAbrt- UnxCmplt-
RxOF- MalfTLP- ECRC- UnsupReq- ACSViol-
        UESvrt:    DLP+ SDES+ TLP- FCP+ CmpltTO- CmpltAbrt- UnxCmplt-
RxOF+ MalfTLP+ ECRC- UnsupReq- ACSViol-
        CESta:    RxErr- BadTLP- BadDLLP- Rollover- Timeout- AdvNonFatalErr-
        CEMsk:    RxErr- BadTLP- BadDLLP- Rollover- Timeout- AdvNonFatalErr+
        AERCap:    First Error Pointer: 00, ECRCGenCap+ ECRCGenEn-
ECRCChkCap+ ECRCChkEn-
            MultHdrRecCap- MultHdrRecEn- TLPPfxPres- HdrLogCap-
        HeaderLog: 00000000 00000000 00000000 00000000
    Capabilities: [140 v1] Virtual Channel
        Caps:    LPEVC=0 RefClk=100ns PATEntryBits=1
        Arb:    Fixed- WRR32- WRR64- WRR128-
        Ctrl:    ArbSelect=Fixed
        Status:    InProgress-
        VC0:    Caps:    PATOffset=00 MaxTimeSlots=1 RejSnoopTrans-
            Arb:    Fixed- WRR32- WRR64- WRR128- TWRR128- WRR256-
            Ctrl:    Enable+ ID=0 ArbSelect=Fixed TC/VC=ff
            Status:    NegoPending- InProgress-
    Capabilities: [160 v1] Device Serial Number 01-00-00-00-68-4c-e0-00
    Capabilities: [170 v1] Latency Tolerance Reporting
        Max snoop latency: 1048576ns
        Max no snoop latency: 1048576ns
    Capabilities: [178 v1] L1 PM Substates
        L1SubCap: PCI-PM_L1.2+ PCI-PM_L1.1+ ASPM_L1.2+ ASPM_L1.1+
L1_PM_Substates+
              PortCommonModeRestoreTime=150us PortTPowerOnTime=150us
        L1SubCtl1: PCI-PM_L1.2+ PCI-PM_L1.1+ ASPM_L1.2+ ASPM_L1.1+
               T_CommonMode=0us LTR1.2_Threshold=294912ns
        L1SubCtl2: T_PwrOn=150us
    Kernel driver in use: pciback
    Kernel modules: r8169

06:00.0 USB controller [0c03]: Renesas Technology Corp. uPD720202 USB
3.0 Host Controller [1912:0015] (rev 02) (prog-if 30 [XHCI])
    Control: I/O- Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr-
Stepping- SERR- FastB2B- DisINTx+
    Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort-
<TAbort- <MAbort- >SERR- <PERR- INTx-
    Latency: 0, Cache Line Size: 32 bytes
    Interrupt: pin A routed to IRQ 42
    Region 0: Memory at fd400000 (64-bit, non-prefetchable) [size=8K]
    Capabilities: [50] Power Management version 3
        Flags: PMEClk- DSI- D1- D2- AuxCurrent=375mA
PME(D0+,D1-,D2-,D3hot+,D3cold+)
        Status: D0 NoSoftRst+ PME-Enable- DSel=0 DScale=0 PME-
    Capabilities: [70] MSI: Enable+ Count=1/8 Maskable- 64bit+
        Address: 00000000fee0c000  Data: 4000
    Capabilities: [90] MSI-X: Enable- Count=8 Masked-
        Vector table: BAR=0 offset=00001000
        PBA: BAR=0 offset=00001080
    Capabilities: [a0] Express (v2) Endpoint, MSI 00
        DevCap:    MaxPayload 128 bytes, PhantFunc 0, Latency L0s
unlimited, L1 unlimited
            ExtTag- AttnBtn- AttnInd- PwrInd- RBE+ FLReset-
SlotPowerLimit 0.000W
        DevCtl:    CorrErr- NonFatalErr- FatalErr- UnsupReq-
            RlxdOrd- ExtTag- PhantFunc- AuxPwr- NoSnoop+
            MaxPayload 128 bytes, MaxReadReq 512 bytes
        DevSta:    CorrErr- NonFatalErr- FatalErr- UnsupReq- AuxPwr+
TransPend-
        LnkCap:    Port #0, Speed 5GT/s, Width x1, ASPM L0s L1, Exit
Latency L0s <4us, L1 unlimited
            ClockPM+ Surprise- LLActRep- BwNot- ASPMOptComp-
        LnkCtl:    ASPM L0s Enabled; RCB 64 bytes, Disabled- CommClk+
            ExtSynch- ClockPM+ AutWidDis- BWInt- AutBWInt-
        LnkSta:    Speed 5GT/s (ok), Width x1 (ok)
            TrErr- Train- SlotClk+ DLActive- BWMgmt- ABWMgmt-
        DevCap2: Completion Timeout: Not Supported, TimeoutDis+
NROPrPrP- LTR+
             10BitTagComp- 10BitTagReq- OBFF Not Supported, ExtFmt-
EETLPPrefix-
             EmergencyPowerReduction Not Supported,
EmergencyPowerReductionInit-
             FRS- TPHComp- ExtTPHComp-
             AtomicOpsCap: 32bit- 64bit- 128bitCAS-
        DevCtl2: Completion Timeout: 50us to 50ms, TimeoutDis- LTR- OBFF
Disabled,
             AtomicOpsCtl: ReqEn-
        LnkCtl2: Target Link Speed: 5GT/s, EnterCompliance- SpeedDis-
             Transmit Margin: Normal Operating Range,
EnterModifiedCompliance- ComplianceSOS-
             Compliance De-emphasis: -6dB
        LnkSta2: Current De-emphasis Level: -3.5dB,
EqualizationComplete- EqualizationPhase1-
             EqualizationPhase2- EqualizationPhase3-
LinkEqualizationRequest-
             Retimer- 2Retimers- CrosslinkRes: unsupported
    Capabilities: [100 v1] Advanced Error Reporting
        UESta:    DLP- SDES- TLP- FCP- CmpltTO- CmpltAbrt- UnxCmplt-
RxOF- MalfTLP- ECRC- UnsupReq- ACSViol-
        UEMsk:    DLP- SDES- TLP- FCP- CmpltTO- CmpltAbrt- UnxCmplt-
RxOF- MalfTLP- ECRC- UnsupReq- ACSViol-
        UESvrt:    DLP+ SDES+ TLP- FCP+ CmpltTO- CmpltAbrt- UnxCmplt-
RxOF+ MalfTLP+ ECRC- UnsupReq- ACSViol-
        CESta:    RxErr- BadTLP- BadDLLP- Rollover- Timeout- AdvNonFatalErr-
        CEMsk:    RxErr- BadTLP- BadDLLP- Rollover- Timeout- AdvNonFatalErr+
        AERCap:    First Error Pointer: 00, ECRCGenCap- ECRCGenEn-
ECRCChkCap- ECRCChkEn-
            MultHdrRecCap- MultHdrRecEn- TLPPfxPres- HdrLogCap-
        HeaderLog: 00000000 00000000 00000000 00000000
    Capabilities: [150 v1] Latency Tolerance Reporting
        Max snoop latency: 0ns
        Max no snoop latency: 0ns
    Kernel driver in use: pciback
    Kernel modules: xhci_pci

07:00.0 VGA compatible controller [0300]: Advanced Micro Devices, Inc.
[AMD/ATI] Renoir [1002:1636] (rev d1) (prog-if 00 [VGA controller])
    Subsystem: Lenovo Device [17aa:5099]
    Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr-
Stepping- SERR- FastB2B- DisINTx+
    Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort+
<TAbort- <MAbort- >SERR- <PERR- INTx-
    Latency: 0, Cache Line Size: 32 bytes
    Interrupt: pin A routed to IRQ 38
    Region 0: Memory at c60000000 (64-bit, prefetchable) [size=256M]
    Region 2: Memory at c70000000 (64-bit, prefetchable) [size=2M]
    Region 4: I/O ports at 1000 [size=256]
    Region 5: Memory at fd300000 (32-bit, non-prefetchable) [size=512K]
    Capabilities: [48] Vendor Specific Information: Len=08 <?>
    Capabilities: [50] Power Management version 3
        Flags: PMEClk- DSI- D1- D2- AuxCurrent=0mA
PME(D0-,D1+,D2+,D3hot+,D3cold+)
        Status: D0 NoSoftRst- PME-Enable- DSel=0 DScale=0 PME-
    Capabilities: [64] Express (v2) Legacy Endpoint, MSI 00
        DevCap:    MaxPayload 256 bytes, PhantFunc 0, Latency L0s <4us,
L1 unlimited
            ExtTag+ AttnBtn- AttnInd- PwrInd- RBE+ FLReset-
        DevCtl:    CorrErr- NonFatalErr- FatalErr- UnsupReq-
            RlxdOrd+ ExtTag+ PhantFunc- AuxPwr- NoSnoop+
            MaxPayload 128 bytes, MaxReadReq 512 bytes
        DevSta:    CorrErr- NonFatalErr+ FatalErr- UnsupReq+ AuxPwr-
TransPend-
        LnkCap:    Port #0, Speed 16GT/s, Width x16, ASPM L0s L1, Exit
Latency L0s <64ns, L1 <1us
            ClockPM- Surprise- LLActRep- BwNot- ASPMOptComp+
        LnkCtl:    ASPM Disabled; RCB 64 bytes, Disabled- CommClk+
            ExtSynch- ClockPM- AutWidDis- BWInt- AutBWInt-
        LnkSta:    Speed 16GT/s (ok), Width x16 (ok)
            TrErr- Train- SlotClk+ DLActive- BWMgmt- ABWMgmt-
        DevCap2: Completion Timeout: Range ABCD, TimeoutDis+ NROPrPrP- LTR-
             10BitTagComp+ 10BitTagReq- OBFF Not Supported, ExtFmt+
EETLPPrefix+, MaxEETLPPrefixes 1
             EmergencyPowerReduction Not Supported,
EmergencyPowerReductionInit-
             FRS-
             AtomicOpsCap: 32bit- 64bit- 128bitCAS-
        DevCtl2: Completion Timeout: 50us to 50ms, TimeoutDis- LTR- OBFF
Disabled,
             AtomicOpsCtl: ReqEn-
        LnkCap2: Supported Link Speeds: 2.5-16GT/s, Crosslink- Retimer+
2Retimers+ DRS-
        LnkCtl2: Target Link Speed: 16GT/s, EnterCompliance- SpeedDis-
             Transmit Margin: Normal Operating Range,
EnterModifiedCompliance- ComplianceSOS-
             Compliance De-emphasis: -6dB
        LnkSta2: Current De-emphasis Level: -3.5dB,
EqualizationComplete+ EqualizationPhase1+
             EqualizationPhase2+ EqualizationPhase3+
LinkEqualizationRequest-
             Retimer- 2Retimers- CrosslinkRes: unsupported
    Capabilities: [a0] MSI: Enable- Count=1/4 Maskable- 64bit+
        Address: 0000000000000000  Data: 0000
    Capabilities: [c0] MSI-X: Enable+ Count=4 Masked-
        Vector table: BAR=5 offset=00042000
        PBA: BAR=5 offset=00043000
    Capabilities: [100 v1] Vendor Specific Information: ID=0001 Rev=1
Len=010 <?>
    Capabilities: [270 v1] Secondary PCI Express
        LnkCtl3: LnkEquIntrruptEn- PerformEqu-
        LaneErrStat: 0
    Capabilities: [2b0 v1] Address Translation Service (ATS)
        ATSCap:    Invalidate Queue Depth: 00
        ATSCtl:    Enable-, Smallest Translation Unit: 00
    Capabilities: [2c0 v1] Page Request Interface (PRI)
        PRICtl: Enable- Reset-
        PRISta: RF- UPRGI- Stopped+
        Page Request Capacity: 00000100, Page Request Allocation: 00000000
    Capabilities: [2d0 v1] Process Address Space ID (PASID)
        PASIDCap: Exec+ Priv+, Max PASID Width: 10
        PASIDCtl: Enable- Exec- Priv-
    Capabilities: [400 v1] Data Link Feature <?>
    Capabilities: [410 v1] Physical Layer 16.0 GT/s <?>
    Capabilities: [440 v1] Lane Margining at the Receiver <?>
    Kernel driver in use: amdgpu
    Kernel modules: amdgpu

07:00.2 Encryption controller [1080]: Advanced Micro Devices, Inc. [AMD]
Family 17h (Models 10h-1fh) Platform Security Processor [1022:15df]
    Subsystem: Lenovo Device [17aa:5081]
    Control: I/O- Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr-
Stepping- SERR- FastB2B- DisINTx+
    Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort+
<TAbort- <MAbort- >SERR- <PERR- INTx-
    Latency: 0, Cache Line Size: 32 bytes
    Interrupt: pin C routed to IRQ 36
    Region 2: Memory at fd200000 (32-bit, non-prefetchable) [size=1M]
    Region 5: Memory at fd380000 (32-bit, non-prefetchable) [size=8K]
    Capabilities: [48] Vendor Specific Information: Len=08 <?>
    Capabilities: [50] Power Management version 3
        Flags: PMEClk- DSI- D1- D2- AuxCurrent=0mA
PME(D0-,D1-,D2-,D3hot-,D3cold-)
        Status: D0 NoSoftRst+ PME-Enable- DSel=0 DScale=0 PME-
    Capabilities: [64] Express (v2) Endpoint, MSI 00
        DevCap:    MaxPayload 256 bytes, PhantFunc 0, Latency L0s <4us,
L1 unlimited
            ExtTag+ AttnBtn- AttnInd- PwrInd- RBE+ FLReset-
SlotPowerLimit 0.000W
        DevCtl:    CorrErr- NonFatalErr- FatalErr- UnsupReq-
            RlxdOrd+ ExtTag+ PhantFunc- AuxPwr- NoSnoop+
            MaxPayload 128 bytes, MaxReadReq 512 bytes
        DevSta:    CorrErr- NonFatalErr- FatalErr- UnsupReq- AuxPwr-
TransPend-
        LnkCap:    Port #0, Speed 16GT/s, Width x16, ASPM L0s L1, Exit
Latency L0s <64ns, L1 <1us
            ClockPM- Surprise- LLActRep- BwNot- ASPMOptComp+
        LnkCtl:    ASPM Disabled; RCB 64 bytes, Disabled- CommClk+
            ExtSynch- ClockPM- AutWidDis- BWInt- AutBWInt-
        LnkSta:    Speed 16GT/s (ok), Width x16 (ok)
            TrErr- Train- SlotClk+ DLActive- BWMgmt- ABWMgmt-
        DevCap2: Completion Timeout: Range ABCD, TimeoutDis+ NROPrPrP- LTR-
             10BitTagComp+ 10BitTagReq- OBFF Not Supported, ExtFmt+
EETLPPrefix+, MaxEETLPPrefixes 1
             EmergencyPowerReduction Not Supported,
EmergencyPowerReductionInit-
             FRS- TPHComp- ExtTPHComp-
             AtomicOpsCap: 32bit- 64bit- 128bitCAS-
        DevCtl2: Completion Timeout: 50us to 50ms, TimeoutDis- LTR- OBFF
Disabled,
             AtomicOpsCtl: ReqEn-
        LnkSta2: Current De-emphasis Level: -3.5dB,
EqualizationComplete- EqualizationPhase1-
             EqualizationPhase2- EqualizationPhase3-
LinkEqualizationRequest-
             Retimer- 2Retimers- CrosslinkRes: unsupported
    Capabilities: [a0] MSI: Enable- Count=1/2 Maskable- 64bit+
        Address: 0000000000000000  Data: 0000
    Capabilities: [c0] MSI-X: Enable+ Count=2 Masked-
        Vector table: BAR=5 offset=00000000
        PBA: BAR=5 offset=00001000
    Capabilities: [100 v1] Vendor Specific Information: ID=0001 Rev=1
Len=010 <?>
    Kernel driver in use: ccp
    Kernel modules: ccp

07:00.3 USB controller [0c03]: Advanced Micro Devices, Inc. [AMD] Renoir
USB 3.1 [1022:1639] (prog-if 30 [XHCI])
    Subsystem: Lenovo Device [17aa:5081]
    Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr-
Stepping- SERR- FastB2B- DisINTx+
    Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort-
<TAbort- <MAbort- >SERR- <PERR- INTx-
    Latency: 0, Cache Line Size: 32 bytes
    Interrupt: pin D routed to IRQ 37
    Region 0: Memory at fd000000 (64-bit, non-prefetchable) [size=1M]
    Capabilities: [48] Vendor Specific Information: Len=08 <?>
    Capabilities: [50] Power Management version 3
        Flags: PMEClk- DSI- D1- D2- AuxCurrent=0mA
PME(D0+,D1-,D2-,D3hot+,D3cold+)
        Status: D0 NoSoftRst- PME-Enable- DSel=0 DScale=0 PME-
    Capabilities: [64] Express (v2) Endpoint, MSI 00
        DevCap:    MaxPayload 256 bytes, PhantFunc 0, Latency L0s <4us,
L1 unlimited
            ExtTag+ AttnBtn- AttnInd- PwrInd- RBE+ FLReset-
SlotPowerLimit 0.000W
        DevCtl:    CorrErr- NonFatalErr- FatalErr- UnsupReq-
            RlxdOrd+ ExtTag+ PhantFunc- AuxPwr- NoSnoop+
            MaxPayload 128 bytes, MaxReadReq 512 bytes
        DevSta:    CorrErr- NonFatalErr- FatalErr- UnsupReq- AuxPwr-
TransPend-
        LnkCap:    Port #0, Speed 16GT/s, Width x16, ASPM L0s L1, Exit
Latency L0s <64ns, L1 <1us
            ClockPM- Surprise- LLActRep- BwNot- ASPMOptComp+
        LnkCtl:    ASPM Disabled; RCB 64 bytes, Disabled- CommClk+
            ExtSynch- ClockPM- AutWidDis- BWInt- AutBWInt-
        LnkSta:    Speed 16GT/s (ok), Width x16 (ok)
            TrErr- Train- SlotClk+ DLActive- BWMgmt- ABWMgmt-
        DevCap2: Completion Timeout: Range ABCD, TimeoutDis+ NROPrPrP- LTR-
             10BitTagComp+ 10BitTagReq- OBFF Not Supported, ExtFmt+
EETLPPrefix+, MaxEETLPPrefixes 1
             EmergencyPowerReduction Not Supported,
EmergencyPowerReductionInit-
             FRS- TPHComp- ExtTPHComp-
             AtomicOpsCap: 32bit- 64bit- 128bitCAS-
        DevCtl2: Completion Timeout: 50us to 50ms, TimeoutDis- LTR- OBFF
Disabled,
             AtomicOpsCtl: ReqEn-
        LnkSta2: Current De-emphasis Level: -3.5dB,
EqualizationComplete- EqualizationPhase1-
             EqualizationPhase2- EqualizationPhase3-
LinkEqualizationRequest-
             Retimer- 2Retimers- CrosslinkRes: unsupported
    Capabilities: [a0] MSI: Enable+ Count=1/8 Maskable- 64bit+
        Address: 00000000fee06000  Data: 4000
    Capabilities: [c0] MSI-X: Enable- Count=8 Masked-
        Vector table: BAR=0 offset=000fe000
        PBA: BAR=0 offset=000ff000
    Capabilities: [100 v1] Vendor Specific Information: ID=0001 Rev=1
Len=010 <?>
    Kernel driver in use: pciback
    Kernel modules: xhci_pci

07:00.4 USB controller [0c03]: Advanced Micro Devices, Inc. [AMD] Renoir
USB 3.1 [1022:1639] (prog-if 30 [XHCI])
    Subsystem: Lenovo Device [17aa:5081]
    Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr-
Stepping- SERR- FastB2B- DisINTx+
    Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort-
<TAbort- <MAbort- >SERR- <PERR- INTx-
    Latency: 0, Cache Line Size: 32 bytes
    Interrupt: pin A routed to IRQ 38
    Region 0: Memory at fd100000 (64-bit, non-prefetchable) [size=1M]
    Capabilities: [48] Vendor Specific Information: Len=08 <?>
    Capabilities: [50] Power Management version 3
        Flags: PMEClk- DSI- D1- D2- AuxCurrent=0mA
PME(D0+,D1-,D2-,D3hot+,D3cold+)
        Status: D0 NoSoftRst- PME-Enable- DSel=0 DScale=0 PME-
    Capabilities: [64] Express (v2) Endpoint, MSI 00
        DevCap:    MaxPayload 256 bytes, PhantFunc 0, Latency L0s <4us,
L1 unlimited
            ExtTag+ AttnBtn- AttnInd- PwrInd- RBE+ FLReset-
SlotPowerLimit 0.000W
        DevCtl:    CorrErr- NonFatalErr- FatalErr- UnsupReq-
            RlxdOrd+ ExtTag+ PhantFunc- AuxPwr- NoSnoop+
            MaxPayload 128 bytes, MaxReadReq 512 bytes
        DevSta:    CorrErr- NonFatalErr- FatalErr- UnsupReq- AuxPwr-
TransPend-
        LnkCap:    Port #0, Speed 16GT/s, Width x16, ASPM L0s L1, Exit
Latency L0s <64ns, L1 <1us
            ClockPM- Surprise- LLActRep- BwNot- ASPMOptComp+
        LnkCtl:    ASPM Disabled; RCB 64 bytes, Disabled- CommClk+
            ExtSynch- ClockPM- AutWidDis- BWInt- AutBWInt-
        LnkSta:    Speed 16GT/s (ok), Width x16 (ok)
            TrErr- Train- SlotClk+ DLActive- BWMgmt- ABWMgmt-
        DevCap2: Completion Timeout: Range ABCD, TimeoutDis+ NROPrPrP- LTR-
             10BitTagComp+ 10BitTagReq- OBFF Not Supported, ExtFmt+
EETLPPrefix+, MaxEETLPPrefixes 1
             EmergencyPowerReduction Not Supported,
EmergencyPowerReductionInit-
             FRS- TPHComp- ExtTPHComp-
             AtomicOpsCap: 32bit- 64bit- 128bitCAS-
        DevCtl2: Completion Timeout: 50us to 50ms, TimeoutDis- LTR- OBFF
Disabled,
             AtomicOpsCtl: ReqEn-
        LnkSta2: Current De-emphasis Level: -3.5dB,
EqualizationComplete- EqualizationPhase1-
             EqualizationPhase2- EqualizationPhase3-
LinkEqualizationRequest-
             Retimer- 2Retimers- CrosslinkRes: unsupported
    Capabilities: [a0] MSI: Enable+ Count=1/8 Maskable- 64bit+
        Address: 00000000fee0a000  Data: 4000
    Capabilities: [c0] MSI-X: Enable- Count=8 Masked-
        Vector table: BAR=0 offset=000fe000
        PBA: BAR=0 offset=000ff000
    Capabilities: [100 v1] Vendor Specific Information: ID=0001 Rev=1
Len=010 <?>
    Kernel driver in use: pciback
    Kernel modules: xhci_pci




From xen-devel-bounces@lists.xenproject.org Sun Oct 24 11:51:01 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 24 Oct 2021 11:51:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.215515.374768 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mec1X-0000Rl-47; Sun, 24 Oct 2021 11:50:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 215515.374768; Sun, 24 Oct 2021 11:50:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mec1X-0000Re-18; Sun, 24 Oct 2021 11:50:47 +0000
Received: by outflank-mailman (input) for mailman id 215515;
 Sun, 24 Oct 2021 11:50:45 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mec1V-0000RU-If; Sun, 24 Oct 2021 11:50:45 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mec1V-0000a7-9H; Sun, 24 Oct 2021 11:50:45 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mec1V-00045p-0y; Sun, 24 Oct 2021 11:50:45 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mec1V-00065i-0T; Sun, 24 Oct 2021 11:50:45 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=XkPG9wOJRKsmb+X2RRwxe7WFIJX8mh2Iycocp4+dM6A=; b=S3AathEUIEOIi+jwc8MUVB+FVF
	IUIKKJi8BznXlNaMpz4Fd6A37cAUp71vCqeyqoK8hW3wOQm3iI0qlL67E62OvOncVf4JP0LxiMIf7
	6p5R842ZsiYiXBZt6E0SmB0SNCDNw+0/eMtujXvw1XNAo+F555j/waPOKHW/f9KREyr0=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165827-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 165827: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=8b76f235340922a6d293bff05978ba57d3b498e1
X-Osstest-Versions-That:
    ovmf=62540372230ecb5318a9c8a40580a14beeb9ded0
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 24 Oct 2021 11:50:45 +0000

flight 165827 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165827/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 8b76f235340922a6d293bff05978ba57d3b498e1
baseline version:
 ovmf                 62540372230ecb5318a9c8a40580a14beeb9ded0

Last test of basis   165808  2021-10-23 08:42:15 Z    1 days
Testing same since   165827  2021-10-24 02:10:08 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Gerd Hoffmann <kraxel@redhat.com>
  Min Xu <min.m.xu@intel.com>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   6254037223..8b76f23534  8b76f235340922a6d293bff05978ba57d3b498e1 -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Sun Oct 24 15:09:33 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 24 Oct 2021 15:09:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.215534.374794 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mef7a-0000mY-Ph; Sun, 24 Oct 2021 15:09:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 215534.374794; Sun, 24 Oct 2021 15:09:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mef7a-0000mR-Ml; Sun, 24 Oct 2021 15:09:14 +0000
Received: by outflank-mailman (input) for mailman id 215534;
 Sun, 24 Oct 2021 15:09:13 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mef7Z-0000mH-Pp; Sun, 24 Oct 2021 15:09:13 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mef7Z-0003sX-F9; Sun, 24 Oct 2021 15:09:13 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mef7Z-00056j-3m; Sun, 24 Oct 2021 15:09:13 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mef7Z-0004Dy-3G; Sun, 24 Oct 2021 15:09:13 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=NVghSUPchpsrJ2dSp3EaP0rMdol/CoAvfIPNKE3W35Y=; b=BATOVgGcvdU5ypuwqx5lneOhEw
	qbDzhsIVooCj7Ior0xz/c+e8+ybP2UndVv7YxMuNXBXq+A16yfLh0nUN621LFL+Rruz5MqviDqTxk
	PP20u6JBG7OAP9uJ7bMMYZCzV2qM5NpZ/hJTUTi7lAcVuBP02RmdERQgAgRNZXNH8HdI=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165825-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 165825: tolerable FAIL
X-Osstest-Failures:
    xen-unstable:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=23ec1ebc8acbfd2bf06f6085a776f0db923f9fa9
X-Osstest-Versions-That:
    xen=23ec1ebc8acbfd2bf06f6085a776f0db923f9fa9
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 24 Oct 2021 15:09:13 +0000

flight 165825 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165825/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat  fail pass in 165798

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-rtds  20 guest-localmigrate/x10 fail in 165798 like 165729
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 165798
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 165798
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165798
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165798
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 165798
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 165798
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 165798
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 165798
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 165798
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 165798
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165798
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 165798
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 xen                  23ec1ebc8acbfd2bf06f6085a776f0db923f9fa9
baseline version:
 xen                  23ec1ebc8acbfd2bf06f6085a776f0db923f9fa9

Last test of basis   165825  2021-10-24 01:51:42 Z    0 days
Testing same since                          (not found)         0 attempts

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 fail    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Published tested tree is already up to date.



From xen-devel-bounces@lists.xenproject.org Sun Oct 24 15:58:40 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 24 Oct 2021 15:58:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.215542.374808 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1meftJ-0005cI-KH; Sun, 24 Oct 2021 15:58:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 215542.374808; Sun, 24 Oct 2021 15:58:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1meftJ-0005cB-Gz; Sun, 24 Oct 2021 15:58:33 +0000
Received: by outflank-mailman (input) for mailman id 215542;
 Sun, 24 Oct 2021 15:58:31 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1meftH-0005c1-TV; Sun, 24 Oct 2021 15:58:31 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1meftH-0004gQ-ON; Sun, 24 Oct 2021 15:58:31 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1meftH-00083T-EC; Sun, 24 Oct 2021 15:58:31 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1meftH-0007YN-Dh; Sun, 24 Oct 2021 15:58:31 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Message-Id:Subject:To;
	bh=o/nWDUZGoH5wmcDp84FhVHH5PKQF+w7CvKNsLqQXCuw=; b=feL7fi42dpjkQy3yhtGfKlqL1t
	+56UlAMDA8HA8UDDqkGVVdPyFhDhTXDPGkZxLF4yl0CYzkF4Vc2GcMgSnbWeZEGPdkBh3y7+Smll1
	zgmkQ3qSiSpprWv+15g/G7XZ0xtKBbzuPXIb7B8xDzf4xdTF8AO36yUIt6Wf1l2ecpNU=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Subject: [qemu-mainline bisection] complete build-i386-xsm
Message-Id: <E1meftH-0007YN-Dh@osstest.test-lab.xenproject.org>
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 24 Oct 2021 15:58:31 +0000

branch xen-unstable
xenbranch xen-unstable
job build-i386-xsm
testid xen-build

Tree: ovmf git://xenbits.xen.org/osstest/ovmf.git
Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git
Tree: qemuu git://git.qemu.org/qemu.git
Tree: seabios git://xenbits.xen.org/osstest/seabios.git
Tree: xen git://xenbits.xen.org/xen.git

*** Found and reproduced problem changeset ***

  Bug is in tree:  qemuu git://git.qemu.org/qemu.git
  Bug introduced:  e741aff0f43343d6d91242fee1072fee376d5cce
  Bug not present: 685db13a38f7599fabd353382ff65d3c244ea641
  Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/165839/


  commit e741aff0f43343d6d91242fee1072fee376d5cce
  Author: Igor Mammedov <imammedo@redhat.com>
  Date:   Thu Sep 2 07:35:38 2021 -0400
  
      tests: qtest: add qtest_has_accel() to check if tested binary supports accelerator
      
      Currently it is not possible to create tests that have KVM as a hard
      requirement on a host that doesn't support KVM for tested target
      binary (modulo going through the trouble of compiling out
      the offending test case).
      
      Following scenario makes test fail when it's run on non x86 host:
        qemu-system-x86_64 -enable-kvm -M q35,kernel-irqchip=on -smp 1,maxcpus=288
      
      This patch introduces qtest_has_accel() to let users check if accel is
      available in advance and avoid executing non run-able test-cases.
      
      It implements detection of TCG and KVM only, the rest could be
      added later on, when we actually start testing them in qtest.
      
      Signed-off-by: Igor Mammedov <imammedo@redhat.com>
      Message-Id: <20210902113551.461632-3-imammedo@redhat.com>
      Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
      Signed-off-by: Michael S. Tsirkin <mst@redhat.com>


For bisection revision-tuple graph see:
   http://logs.test-lab.xenproject.org/osstest/results/bisect/qemu-mainline/build-i386-xsm.xen-build.html
Revision IDs in each graph node refer, respectively, to the Trees above.

----------------------------------------
Running cs-bisection-step --graph-out=/home/logs/results/bisect/qemu-mainline/build-i386-xsm.xen-build --summary-out=tmp/165839.bisection-summary --basis-template=165682 --blessings=real,real-bisect,real-retry qemu-mainline build-i386-xsm xen-build
Searching for failure / basis pass:
 165823 fail [host=fiano0] / 165682 [host=huxelrebe0] 165670 [host=albana0] 165640 [host=huxelrebe0] 165576 [host=albana1] 165536 [host=huxelrebe0] 165529 [host=albana1] 165514 [host=fiano1] 165506 [host=fiano1] 165498 [host=huxelrebe0] 165488 [host=albana1] 165477 [host=albana1] 165468 [host=fiano1] 165442 [host=albana1] 165429 ok.
Failure / basis pass flights: 165823 / 165429
(tree with no url: minios)
Tree: ovmf git://xenbits.xen.org/osstest/ovmf.git
Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git
Tree: qemuu git://git.qemu.org/qemu.git
Tree: seabios git://xenbits.xen.org/osstest/seabios.git
Tree: xen git://xenbits.xen.org/xen.git
Latest 62540372230ecb5318a9c8a40580a14beeb9ded0 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 c5b2f559814104f4145f8bc310f4d33c7ead8f49 64f37cc530f144e53c190c9e8209a51b58fd5c43 23ec1ebc8acbfd2bf06f6085a776f0db923f9fa9
Basis pass b4da6c29f1d36031e04212f53277ce0dcba309f1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 14f12119aa675e9e28207a48b0728a2daa5b88d6 64f37cc530f144e53c190c9e8209a51b58fd5c43 192aaf7e146c0b41dbdd35ccdb13eb33ced13633
Generating revisions with ./adhoc-revtuple-generator  git://xenbits.xen.org/osstest/ovmf.git#b4da6c29f1d36031e04212f53277ce0dcba309f1-62540372230ecb5318a9c8a40580a14beeb9ded0 git://xenbits.xen.org/qemu-xen-traditional.git#3d273dd05e51e5a1ffba3d98c7437ee84e8f8764-3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 git://git.qemu.org/qemu.git#14f12119aa675e9e28207a48b0728a2daa5b88d6-c5b2f559814104f4145f8bc310f4d33c7ead8f49 git://xenbits.xen.org/osstest/seabios.git#64f37cc530f144e53c190c9e8209a51b58fd5c43-64f\
 37cc530f144e53c190c9e8209a51b58fd5c43 git://xenbits.xen.org/xen.git#192aaf7e146c0b41dbdd35ccdb13eb33ced13633-23ec1ebc8acbfd2bf06f6085a776f0db923f9fa9
Loaded 34889 nodes in revision graph
Searching for test results:
 165429 pass b4da6c29f1d36031e04212f53277ce0dcba309f1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 14f12119aa675e9e28207a48b0728a2daa5b88d6 64f37cc530f144e53c190c9e8209a51b58fd5c43 192aaf7e146c0b41dbdd35ccdb13eb33ced13633
 165442 [host=albana1]
 165468 [host=fiano1]
 165477 [host=albana1]
 165488 [host=albana1]
 165498 [host=huxelrebe0]
 165506 [host=fiano1]
 165514 [host=fiano1]
 165529 [host=albana1]
 165536 [host=huxelrebe0]
 165576 [host=albana1]
 165640 [host=huxelrebe0]
 165670 [host=albana0]
 165682 [host=huxelrebe0]
 165694 fail irrelevant
 165703 fail 6893865b3010bb6192f732643c4b8ba026726d07 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 afc9fcde55296b83f659de9da3cdf044812a6eeb 64f37cc530f144e53c190c9e8209a51b58fd5c43 c12731493ae39640c4e44d9fe2029c3165f9f429
 165721 [host=fiano1]
 165726 fail irrelevant
 165753 fail irrelevant
 165789 pass b4da6c29f1d36031e04212f53277ce0dcba309f1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 14f12119aa675e9e28207a48b0728a2daa5b88d6 64f37cc530f144e53c190c9e8209a51b58fd5c43 192aaf7e146c0b41dbdd35ccdb13eb33ced13633
 165792 fail irrelevant
 165794 pass 90246a6d9f6fda3536d042d02867123caabe3aaa 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 911965ace9386e35ca022a65bb45a32fd421af3e 64f37cc530f144e53c190c9e8209a51b58fd5c43 6809998c5f8f1d2e26ac9e867af8ac71e7a66cf2
 165795 pass 210869834639c1150b1f016e2022472a55cdd884 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 2792cf20ca7eed0e354a0ed731422411faca4908 64f37cc530f144e53c190c9e8209a51b58fd5c43 3ae80dea4601764818d1e5b84bd1e4479c0d4790
 165796 pass 210869834639c1150b1f016e2022472a55cdd884 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 5abfac277d25feb5f12332422c03ea1cb21c6aa1 64f37cc530f144e53c190c9e8209a51b58fd5c43 3ae80dea4601764818d1e5b84bd1e4479c0d4790
 165790 fail bd5ec03d87cacc5be2de4284b092aafd4ac4eb31 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 2c64ff92ecef4db0169f7238a26f1124268345c8 64f37cc530f144e53c190c9e8209a51b58fd5c43 23ec1ebc8acbfd2bf06f6085a776f0db923f9fa9
 165797 pass f10a112f08f3fb4a92c3d22f069f6066a12db3be 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 995b87dedc78b0467f5f18bbc3546072ba97516a 64f37cc530f144e53c190c9e8209a51b58fd5c43 52d0847d7c6972baa74156f14ee8544f5aba1d2d
 165800 pass b4da6c29f1d36031e04212f53277ce0dcba309f1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 14f12119aa675e9e28207a48b0728a2daa5b88d6 64f37cc530f144e53c190c9e8209a51b58fd5c43 192aaf7e146c0b41dbdd35ccdb13eb33ced13633
 165804 fail bd5ec03d87cacc5be2de4284b092aafd4ac4eb31 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 2c64ff92ecef4db0169f7238a26f1124268345c8 64f37cc530f144e53c190c9e8209a51b58fd5c43 23ec1ebc8acbfd2bf06f6085a776f0db923f9fa9
 165805 pass f10a112f08f3fb4a92c3d22f069f6066a12db3be 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 bec4042baefc1bfeae05b161aa17d2f57d526b60 64f37cc530f144e53c190c9e8209a51b58fd5c43 52d0847d7c6972baa74156f14ee8544f5aba1d2d
 165806 pass f10a112f08f3fb4a92c3d22f069f6066a12db3be 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 4d1a525dfafe995a98bb486e702da09e31b68b9c 64f37cc530f144e53c190c9e8209a51b58fd5c43 f791392f82ffe39cc1ea4c4db1d877223754a04a
 165807 pass 785cfd33053f506d4a1c17100356a63f24e98f45 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 3b4da13293482134b81d71be656ec76beff73a76 64f37cc530f144e53c190c9e8209a51b58fd5c43 b75838ad6c4f42c93efee83fc2508c78641e1b57
 165810 pass 6ed6abd6c116e8599876a2876b77e172e800b13e 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 946de558354c99e1989621abe053f2ab87dc8de9 64f37cc530f144e53c190c9e8209a51b58fd5c43 9e319e5258d0274c15da2ea9355dc1569a0fa832
 165811 pass 6ed6abd6c116e8599876a2876b77e172e800b13e 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 76e366e728549b3324cc2dee6745d6a4f1af18e6 64f37cc530f144e53c190c9e8209a51b58fd5c43 a0ffee6b145933f411b1c33daa2cdd54e77b2b15
 165812 pass ba4ae92234b1985a89b3abed221d825b8d9ef9e2 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 8be1d4ed9838f807c63695753b30865f6edc4a5c 64f37cc530f144e53c190c9e8209a51b58fd5c43 f9294486926c865a3ef11cacd7cb6b26cce6f4a4
 165813 pass f10a112f08f3fb4a92c3d22f069f6066a12db3be 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 5dacda5167560b3af8eadbce5814f60ba44b467e 64f37cc530f144e53c190c9e8209a51b58fd5c43 be4eefbce6cada21b8a17354c1f11d7865d9a603
 165815 pass ba4ae92234b1985a89b3abed221d825b8d9ef9e2 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 81d8537cb297d57b0897797f1329e4d755a0eaf4 64f37cc530f144e53c190c9e8209a51b58fd5c43 d3b05f9b16d6ba9c550c3a35ac11ed292bf87f68
 165799 fail bd5ec03d87cacc5be2de4284b092aafd4ac4eb31 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 660efed8b37aedec9b5fcc555da1f88f7d12c98a 64f37cc530f144e53c190c9e8209a51b58fd5c43 23ec1ebc8acbfd2bf06f6085a776f0db923f9fa9
 165816 pass 6ed6abd6c116e8599876a2876b77e172e800b13e 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 afe5c8c5c14aff25fab6ae83957e87c717415be3 64f37cc530f144e53c190c9e8209a51b58fd5c43 4cfab4425d39f76660b4e76ba6ee4cbf0f92e7e5
 165818 fail bd5ec03d87cacc5be2de4284b092aafd4ac4eb31 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 660efed8b37aedec9b5fcc555da1f88f7d12c98a 64f37cc530f144e53c190c9e8209a51b58fd5c43 23ec1ebc8acbfd2bf06f6085a776f0db923f9fa9
 165819 pass 90246a6d9f6fda3536d042d02867123caabe3aaa 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 362534a643b4a34bcb223996538ce9de5cdab946 64f37cc530f144e53c190c9e8209a51b58fd5c43 3ae80dea4601764818d1e5b84bd1e4479c0d4790
 165817 fail 62540372230ecb5318a9c8a40580a14beeb9ded0 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 660efed8b37aedec9b5fcc555da1f88f7d12c98a 64f37cc530f144e53c190c9e8209a51b58fd5c43 23ec1ebc8acbfd2bf06f6085a776f0db923f9fa9
 165820 fail 37a33f02aa1ab89f392da7d06ec3578fda1b6182 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 19d20e910a586f503994acf590d5f41c314fa4c3 64f37cc530f144e53c190c9e8209a51b58fd5c43 6809998c5f8f1d2e26ac9e867af8ac71e7a66cf2
 165822 fail 37a33f02aa1ab89f392da7d06ec3578fda1b6182 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b59a898458aea328618521be7dc180d2396c0bf4 64f37cc530f144e53c190c9e8209a51b58fd5c43 6809998c5f8f1d2e26ac9e867af8ac71e7a66cf2
 165824 pass 90246a6d9f6fda3536d042d02867123caabe3aaa 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 362534a643b4a34bcb223996538ce9de5cdab946 64f37cc530f144e53c190c9e8209a51b58fd5c43 6809998c5f8f1d2e26ac9e867af8ac71e7a66cf2
 165826 pass 37a33f02aa1ab89f392da7d06ec3578fda1b6182 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 685db13a38f7599fabd353382ff65d3c244ea641 64f37cc530f144e53c190c9e8209a51b58fd5c43 6809998c5f8f1d2e26ac9e867af8ac71e7a66cf2
 165828 fail 37a33f02aa1ab89f392da7d06ec3578fda1b6182 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 c306cdb0cc5327f336fbf9a7411f319f0717ee75 64f37cc530f144e53c190c9e8209a51b58fd5c43 6809998c5f8f1d2e26ac9e867af8ac71e7a66cf2
 165830 fail 37a33f02aa1ab89f392da7d06ec3578fda1b6182 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 e741aff0f43343d6d91242fee1072fee376d5cce 64f37cc530f144e53c190c9e8209a51b58fd5c43 6809998c5f8f1d2e26ac9e867af8ac71e7a66cf2
 165832 pass 37a33f02aa1ab89f392da7d06ec3578fda1b6182 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 685db13a38f7599fabd353382ff65d3c244ea641 64f37cc530f144e53c190c9e8209a51b58fd5c43 6809998c5f8f1d2e26ac9e867af8ac71e7a66cf2
 165823 fail 62540372230ecb5318a9c8a40580a14beeb9ded0 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 c5b2f559814104f4145f8bc310f4d33c7ead8f49 64f37cc530f144e53c190c9e8209a51b58fd5c43 23ec1ebc8acbfd2bf06f6085a776f0db923f9fa9
 165833 fail 37a33f02aa1ab89f392da7d06ec3578fda1b6182 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 e741aff0f43343d6d91242fee1072fee376d5cce 64f37cc530f144e53c190c9e8209a51b58fd5c43 6809998c5f8f1d2e26ac9e867af8ac71e7a66cf2
 165835 pass b4da6c29f1d36031e04212f53277ce0dcba309f1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 14f12119aa675e9e28207a48b0728a2daa5b88d6 64f37cc530f144e53c190c9e8209a51b58fd5c43 192aaf7e146c0b41dbdd35ccdb13eb33ced13633
 165837 fail 62540372230ecb5318a9c8a40580a14beeb9ded0 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 c5b2f559814104f4145f8bc310f4d33c7ead8f49 64f37cc530f144e53c190c9e8209a51b58fd5c43 23ec1ebc8acbfd2bf06f6085a776f0db923f9fa9
 165838 pass 37a33f02aa1ab89f392da7d06ec3578fda1b6182 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 685db13a38f7599fabd353382ff65d3c244ea641 64f37cc530f144e53c190c9e8209a51b58fd5c43 6809998c5f8f1d2e26ac9e867af8ac71e7a66cf2
 165839 fail 37a33f02aa1ab89f392da7d06ec3578fda1b6182 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 e741aff0f43343d6d91242fee1072fee376d5cce 64f37cc530f144e53c190c9e8209a51b58fd5c43 6809998c5f8f1d2e26ac9e867af8ac71e7a66cf2
Searching for interesting versions
 Result found: flight 165429 (pass), for basis pass
 Result found: flight 165823 (fail), for basis failure
 Repro found: flight 165835 (pass), for basis pass
 Repro found: flight 165837 (fail), for basis failure
 0 revisions at 37a33f02aa1ab89f392da7d06ec3578fda1b6182 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 685db13a38f7599fabd353382ff65d3c244ea641 64f37cc530f144e53c190c9e8209a51b58fd5c43 6809998c5f8f1d2e26ac9e867af8ac71e7a66cf2
No revisions left to test, checking graph state.
 Result found: flight 165826 (pass), for last pass
 Result found: flight 165830 (fail), for first failure
 Repro found: flight 165832 (pass), for last pass
 Repro found: flight 165833 (fail), for first failure
 Repro found: flight 165838 (pass), for last pass
 Repro found: flight 165839 (fail), for first failure

*** Found and reproduced problem changeset ***

  Bug is in tree:  qemuu git://git.qemu.org/qemu.git
  Bug introduced:  e741aff0f43343d6d91242fee1072fee376d5cce
  Bug not present: 685db13a38f7599fabd353382ff65d3c244ea641
  Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/165839/


  commit e741aff0f43343d6d91242fee1072fee376d5cce
  Author: Igor Mammedov <imammedo@redhat.com>
  Date:   Thu Sep 2 07:35:38 2021 -0400
  
      tests: qtest: add qtest_has_accel() to check if tested binary supports accelerator
      
      Currently it is not possible to create tests that have KVM as a hard
      requirement on a host that doesn't support KVM for tested target
      binary (modulo going through the trouble of compiling out
      the offending test case).
      
      Following scenario makes test fail when it's run on non x86 host:
        qemu-system-x86_64 -enable-kvm -M q35,kernel-irqchip=on -smp 1,maxcpus=288
      
      This patch introduces qtest_has_accel() to let users check if accel is
      available in advance and avoid executing non run-able test-cases.
      
      It implements detection of TCG and KVM only, the rest could be
      added later on, when we actually start testing them in qtest.
      
      Signed-off-by: Igor Mammedov <imammedo@redhat.com>
      Message-Id: <20210902113551.461632-3-imammedo@redhat.com>
      Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
      Signed-off-by: Michael S. Tsirkin <mst@redhat.com>

Revision graph left in /home/logs/results/bisect/qemu-mainline/build-i386-xsm.xen-build.{dot,ps,png,html,svg}.
----------------------------------------
165839: tolerable ALL FAIL

flight 165839 qemu-mainline real-bisect [real]
http://logs.test-lab.xenproject.org/osstest/logs/165839/

Failures :-/ but no regressions.

Tests which did not succeed,
including tests which could not be run:
 build-i386-xsm                6 xen-build               fail baseline untested


jobs:
 build-i386-xsm                                               fail    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary



From xen-devel-bounces@lists.xenproject.org Sun Oct 24 18:55:28 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 24 Oct 2021 18:55:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.215556.374834 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1meieI-0005FJ-9c; Sun, 24 Oct 2021 18:55:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 215556.374834; Sun, 24 Oct 2021 18:55:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1meieI-0005FC-65; Sun, 24 Oct 2021 18:55:14 +0000
Received: by outflank-mailman (input) for mailman id 215556;
 Sun, 24 Oct 2021 18:55:13 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=lf0h=PM=oderland.se=josef@srs-us1.protection.inumbo.net>)
 id 1meieH-0005F6-Nf
 for xen-devel@lists.xenproject.org; Sun, 24 Oct 2021 18:55:13 +0000
Received: from office.oderland.com (unknown [91.201.60.5])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id ea177dc6-34fb-11ec-8406-12813bfff9fa;
 Sun, 24 Oct 2021 18:55:11 +0000 (UTC)
Received: from [193.180.18.161] (port=37118 helo=[10.137.0.14])
 by office.oderland.com with esmtpsa (TLS1.2) tls
 TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2)
 (envelope-from <josef@oderland.se>)
 id 1meieD-009vkr-TP; Sun, 24 Oct 2021 20:55:09 +0200
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ea177dc6-34fb-11ec-8406-12813bfff9fa
Message-ID: <90277228-cf14-0cfa-c95e-d42e7d533353@oderland.se>
Date: Sun, 24 Oct 2021 20:55:07 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:93.0) Gecko/20100101
 Thunderbird/93.0
From: Josef Johansson <josef@oderland.se>
To: Marc Zyngier <maz@kernel.org>, Jason Andryuk <jandryuk@gmail.com>
Cc: Bjorn Helgaas <helgaas@kernel.org>, linux-pci@vger.kernel.org,
 xen-devel <xen-devel@lists.xenproject.org>,
 Thomas Gleixner <tglx@linutronix.de>, Juergen Gross <jgross@suse.com>,
 Boris Ostrovsky <boris.ostrovsky@oracle.com>
References: <20211019202906.GA2397931@bhelgaas>
 <5f050b30-fa1c-8387-0d6b-a667851b34b0@oderland.se>
 <877de7dfl2.wl-maz@kernel.org>
 <CAKf6xpt=ZYGyJXMwM7ccOWkx71R0O-QeLjkBF-LtdDcbSnzHsA@mail.gmail.com>
 <3434cb2d-4060-7969-d4c4-089c68190527@oderland.se>
Content-Language: en-US
Subject: Re: [PATCH v2] PCI/MSI: Re-add checks for skip masking MSI-X on Xen
 PV
In-Reply-To: <3434cb2d-4060-7969-d4c4-089c68190527@oderland.se>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-AntiAbuse: This header was added to track abuse, please include it with any abuse report
X-AntiAbuse: Primary Hostname - office.oderland.com
X-AntiAbuse: Original Domain - lists.xenproject.org
X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12]
X-AntiAbuse: Sender Address Domain - oderland.se
X-Get-Message-Sender-Via: office.oderland.com: authenticated_id: josjoh@oderland.se
X-Authenticated-Sender: office.oderland.com: josjoh@oderland.se

On 10/21/21 10:25, Josef Johansson wrote:
> On 10/20/21 16:03, Jason Andryuk wrote:
>> Hi, Marc,
>>
>> Adding Juergen and Boris since this involves Xen.
>>
>> On Wed, Oct 20, 2021 at 8:51 AM Marc Zyngier <maz@kernel.org> wrote:
>>> On Tue, 19 Oct 2021 22:48:19 +0100,
>>> Josef Johansson <josef@oderland.se> wrote:
>>>> From: Josef Johansson <josef@oderland.se>
>>>>
>>>>
>>>> PCI/MSI: Re-add checks for skip masking MSI-X on Xen PV
>>>>
>>>> commit fcacdfbef5a1 ("PCI/MSI: Provide a new set of mask and unmask
>>>> functions") introduce functions pci_msi_update_mask() and
>>>> pci_msix_write_vector_ctrl() that is missing checks for
>>>> pci_msi_ignore_mask that exists in commit 446a98b19fd6 ("PCI/MSI: Use
>>>> new mask/unmask functions"). Add them back since it is
>>>> causing severe lockups in amdgpu drivers under Xen during boot.
>>>>
>>>> As explained in commit 1a519dc7a73c ("PCI/MSI: Skip masking MSI-X
>>>> on Xen PV"), when running as Xen PV guest, masking MSI-X is a
>>>> responsibility of the hypervisor.
>>>>
>>>> Fixes: fcacdfbef5a1 ("PCI/MSI: Provide a new set of mask and unmask
>>>> functions")
>>>> Suggested-by: Jason Andryuk <jandryuk@gmail.com>
>>>> Signed-off-by: Josef Johansson <josef@oderland.se>
>>>>
>>> [...]
>>>
>>>> diff --git a/drivers/pci/msi.c b/drivers/pci/msi.c
>>>> index 0099a00af361..355b791e382f 100644
>>>> --- a/drivers/pci/msi.c
>>>> +++ b/drivers/pci/msi.c
>>>> @@ -148,6 +148,9 @@ static noinline void pci_msi_update_mask(struct msi_desc *desc, u32 clear, u32 s
>>>>       raw_spinlock_t *lock = &desc->dev->msi_lock;
>>>>       unsigned long flags;
>>>>
>>>> +     if (pci_msi_ignore_mask || desc->msi_attrib.is_virtual)
>>>> +             return;
>>>> +
>>> I'd rather be consistent, and keep the check outside of
>>> pci_msi_update_mask(), just like we do in __pci_msi_mask_desc().
>>> Something like this instead:
>>>
>>> diff --git a/drivers/pci/msi.c b/drivers/pci/msi.c
>>> index 0099a00af361..6c69eab304ce 100644
>>> --- a/drivers/pci/msi.c
>>> +++ b/drivers/pci/msi.c
>>> @@ -420,7 +420,8 @@ static void __pci_restore_msi_state(struct pci_dev *dev)
>>>         arch_restore_msi_irqs(dev);
>>>
>>>         pci_read_config_word(dev, dev->msi_cap + PCI_MSI_FLAGS, &control);
>>> -       pci_msi_update_mask(entry, 0, 0);
>>> +       if (!(pci_msi_ignore_mask || desc->msi_attrib.is_virtual))
>>> +               pci_msi_update_mask(entry, 0, 0);
>>>         control &= ~PCI_MSI_FLAGS_QSIZE;
>>>         control |= (entry->msi_attrib.multiple << 4) | PCI_MSI_FLAGS_ENABLE;
>>>         pci_write_config_word(dev, dev->msi_cap + PCI_MSI_FLAGS, control);
>>>
>>> But the commit message talks about MSI-X, and the above is MSI
>>> only. Is Xen messing with the former, the latter, or both?
>> My understanding is pci_msi_ignore_mask covers both MSI and MSI-X for Xen.
> Please let me know if I should go ahead and try it out and send in a v3
> of the patch.
>
> I'm watching for further discussion right now, just to be clear.

Hi,

I ended up with this patch, I also masked pci_set_mask and
pci_set_unmask, even though patching __pci_restore_msi_state and
__pci_restore_msi_state solved this problem, I found that it did not
properly make the system be able to survive flip_done timeout related
problems during suspend/resume. Would this be something you had in mind
Marc? I will make one more try with just patching
__pci_restore_msi_state and __pci_restore_msix_state just to make sure.
diff --git a/drivers/pci/msi.c b/drivers/pci/msi.c index
4b4792940e86..0b2225066778 100644 --- a/drivers/pci/msi.c +++
b/drivers/pci/msi.c @@ -420,7 +420,8 @@ static void
__pci_restore_msi_state(struct pci_dev *dev) arch_restore_msi_irqs(dev);
pci_read_config_word(dev, dev->msi_cap + PCI_MSI_FLAGS, &control); -
pci_msi_update_mask(entry, 0, 0); + if (!(pci_msi_ignore_mask ||
entry->msi_attrib.is_virtual)) + pci_msi_update_mask(entry, 0, 0);
control &= ~PCI_MSI_FLAGS_QSIZE; control |= (entry->msi_attrib.multiple
<< 4) | PCI_MSI_FLAGS_ENABLE; pci_write_config_word(dev, dev->msi_cap +
PCI_MSI_FLAGS, control); @@ -450,8 +451,9 @@ static void
__pci_restore_msix_state(struct pci_dev *dev) PCI_MSIX_FLAGS_ENABLE |
PCI_MSIX_FLAGS_MASKALL); arch_restore_msi_irqs(dev); -
for_each_pci_msi_entry(entry, dev) - pci_msix_write_vector_ctrl(entry,
entry->msix_ctrl); + if (!(pci_msi_ignore_mask ||
entry->msi_attrib.is_virtual)) + for_each_pci_msi_entry(entry, dev) +
pci_msix_write_vector_ctrl(entry, entry->msix_ctrl);
pci_msix_clear_and_set_ctrl(dev, PCI_MSIX_FLAGS_MASKALL, 0); } @@ -546,7
+548,8 @@ static int msi_capability_init(struct pci_dev *dev, int nvec,
return -ENOMEM; /* All MSIs are unmasked by default; mask them all */ -
pci_msi_mask(entry, msi_multi_mask(entry)); + if (!pci_msi_ignore_mask)
+ pci_msi_mask(entry, msi_multi_mask(entry));
list_add_tail(&entry->list, dev_to_msi_list(&dev->dev)); @@ -577,7
+580,8 @@ static int msi_capability_init(struct pci_dev *dev, int nvec,
return 0; err: - pci_msi_unmask(entry, msi_multi_mask(entry)); + if
(!pci_msi_ignore_mask) + pci_msi_unmask(entry, msi_multi_mask(entry));
free_msi_irqs(dev); return ret; } @@ -865,7 +868,8 @@ static void
pci_msi_shutdown(struct pci_dev *dev) dev->msi_enabled = 0; /* Return
the device with MSI unmasked as initial states */ - pci_msi_unmask(desc,
msi_multi_mask(desc)); + if (!pci_msi_ignore_mask) +
pci_msi_unmask(desc, msi_multi_mask(desc)); /* Restore dev->irq to its
default pin-assertion IRQ */ dev->irq = desc->msi_attrib.default_irq; @@
-950,8 +954,9 @@ static void pci_msix_shutdown(struct pci_dev *dev) } /*
Return the device with MSI-X masked as initial states */ -
for_each_pci_msi_entry(entry, dev) - pci_msix_mask(entry); + if
(!pci_msi_ignore_mask) + for_each_pci_msi_entry(entry, dev) +
pci_msix_mask(entry); pci_msix_clear_and_set_ctrl(dev,
PCI_MSIX_FLAGS_ENABLE, 0); pci_intx_for_msi(dev, 1);


>>>>       raw_spin_lock_irqsave(lock, flags);
>>>>       desc->msi_mask &= ~clear;
>>>>       desc->msi_mask |= set;
>>>> @@ -181,6 +184,9 @@ static void pci_msix_write_vector_ctrl(struct msi_desc *desc, u32 ctrl)
>>>>  {
>>>>       void __iomem *desc_addr = pci_msix_desc_addr(desc);
>>>>
>>>> +     if (pci_msi_ignore_mask || desc->msi_attrib.is_virtual)
>>>> +             return;
>>>> +
>>>>       writel(ctrl, desc_addr + PCI_MSIX_ENTRY_VECTOR_CTRL);
>>>>  }
>>> I have similar reservations for this one.
>> The problem here is some of the changes in commit 446a98b19fd6
>> ("PCI/MSI: Use new mask/unmask functions") bypass the checks in
>> __pci_msi_mask_desc/__pci_msi_unmask_desc.  I've wondered if it would
>> be cleaner to push all the `if (pci_msi_ignore_mask)` checks down to
>> the place of the writes.  That keeps dropping the write local to the
>> write and leaves the higher level code consistent between the regular
>> and Xen PV cases.  I don't know where checking
>> desc->msi_attrib.is_virtual is appropriate.

This makes sense the patch would be like so, I'm testing this out now
hoping it will

perform as good. Now the check is performed in four places

* pci_msi_update_mask

* pci_msix_mask

* pci_msix_unmask

* msix_mask_all

diff --git a/drivers/pci/msi.c b/drivers/pci/msi.c
index 4b4792940e86..6fa60ad9cba2 100644
--- a/drivers/pci/msi.c
+++ b/drivers/pci/msi.c
@@ -148,6 +148,9 @@ static noinline void pci_msi_update_mask(struct msi_desc *desc, u32 clear, u32 s
 	raw_spinlock_t *lock = &desc->dev->msi_lock;
 	unsigned long flags;
 
+	if (pci_msi_ignore_mask || desc->msi_attrib.is_virtual)
+		return;
+
 	raw_spin_lock_irqsave(lock, flags);
 	desc->msi_mask &= ~clear;
 	desc->msi_mask |= set;
@@ -186,6 +189,9 @@ static void pci_msix_write_vector_ctrl(struct msi_desc *desc, u32 ctrl)
 
 static inline void pci_msix_mask(struct msi_desc *desc)
 {
+	if (pci_msi_ignore_mask || desc->msi_attrib.is_virtual)
+		return;
+
 	desc->msix_ctrl |= PCI_MSIX_ENTRY_CTRL_MASKBIT;
 	pci_msix_write_vector_ctrl(desc, desc->msix_ctrl);
 	/* Flush write to device */
@@ -194,15 +200,15 @@ static inline void pci_msix_mask(struct msi_desc *desc)
 
 static inline void pci_msix_unmask(struct msi_desc *desc)
 {
+	if (pci_msi_ignore_mask || desc->msi_attrib.is_virtual)
+		return;
+
 	desc->msix_ctrl &= ~PCI_MSIX_ENTRY_CTRL_MASKBIT;
 	pci_msix_write_vector_ctrl(desc, desc->msix_ctrl);
 }
 
 static void __pci_msi_mask_desc(struct msi_desc *desc, u32 mask)
 {
-	if (pci_msi_ignore_mask || desc->msi_attrib.is_virtual)
-		return;
-
 	if (desc->msi_attrib.is_msix)
 		pci_msix_mask(desc);
 	else if (desc->msi_attrib.maskbit)
@@ -211,9 +217,6 @@ static void __pci_msi_mask_desc(struct msi_desc *desc, u32 mask)
 
 static void __pci_msi_unmask_desc(struct msi_desc *desc, u32 mask)
 {
-	if (pci_msi_ignore_mask || desc->msi_attrib.is_virtual)
-		return;
-
 	if (desc->msi_attrib.is_msix)
 		pci_msix_unmask(desc);
 	else if (desc->msi_attrib.maskbit)



That leaves me with a though, will this set masked, and should be checked as well?

void __pci_write_msi_msg(struct msi_desc *entry, struct msi_msg *msg)
{
        struct pci_dev *dev = msi_desc_to_pci_dev(entry);

        if (dev->current_state != PCI_D0 || pci_dev_is_disconnected(dev)) {
                /* Don't touch the hardware now */
        } else if (entry->msi_attrib.is_msix) {
                void __iomem *base = pci_msix_desc_addr(entry);
                u32 ctrl = entry->msix_ctrl;
                bool unmasked = !(ctrl & PCI_MSIX_ENTRY_CTRL_MASKBIT);

                if (entry->msi_attrib.is_virtual)
                        goto skip;

                /*
                 * The specification mandates that the entry is masked
                 * when the message is modified:
                 *
                 * "If software changes the Address or Data value of an
                 * entry while the entry is unmasked, the result is
                 * undefined."
                 */
                if (unmasked)
>>>                     pci_msix_write_vector_ctrl(entry, ctrl | PCI_MSIX_ENTRY_CTRL_MASKBIT);

>> Regards,
>> Jason


From xen-devel-bounces@lists.xenproject.org Sun Oct 24 20:20:04 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 24 Oct 2021 20:20:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.215589.374869 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mejy8-0005QH-99; Sun, 24 Oct 2021 20:19:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 215589.374869; Sun, 24 Oct 2021 20:19:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mejy8-0005QA-50; Sun, 24 Oct 2021 20:19:48 +0000
Received: by outflank-mailman (input) for mailman id 215589;
 Sun, 24 Oct 2021 20:19:46 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mejy6-0005Q0-Px; Sun, 24 Oct 2021 20:19:46 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mejy6-0001EV-Ic; Sun, 24 Oct 2021 20:19:46 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mejy6-0002TX-8F; Sun, 24 Oct 2021 20:19:46 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mejy6-0006WB-7h; Sun, 24 Oct 2021 20:19:46 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=miobQf9c5iSic0f9u/BWJbYktT8Wm+giTLxY4ZsPQAk=; b=IzPqZWpx9CPMEGolcef9Ds1L6b
	zikuDktll/+sq0M9ESgKNWY1XmumjYhK0N3Y7Pwx5ashxleNQJqO24NB9wM3LIs5Os6er7dCoM9c2
	mpY7xECrcVZyxHM3wdD30VlFF33qwveqFNVjcqrbkw16losZjCWpLYztGXxg9E7oBeDc=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165834-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 165834: regressions - FAIL
X-Osstest-Failures:
    qemu-mainline:build-i386:xen-build:fail:regression
    qemu-mainline:build-i386-xsm:xen-build:fail:regression
    qemu-mainline:build-armhf:xen-build:fail:regression
    qemu-mainline:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-amd:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-pair:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-freebsd10-i386:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-freebsd10-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-coresched-i386-xl:build-check(1):blocked:nonblocking
    qemu-mainline:build-armhf-libvirt:build-check(1):blocked:nonblocking
    qemu-mainline:build-i386-libvirt:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-intel:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-shadow:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-vhd:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=c5b2f559814104f4145f8bc310f4d33c7ead8f49
X-Osstest-Versions-That:
    qemuu=50352cce138ef3b30c1cda28a4df68fff5da3202
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 24 Oct 2021 20:19:46 +0000

flight 165834 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165834/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-i386                    6 xen-build                fail REGR. vs. 165682
 build-i386-xsm                6 xen-build                fail REGR. vs. 165682
 build-armhf                   6 xen-build                fail REGR. vs. 165682

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl           1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-credit2   1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-cubietruck  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-multivcpu  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-rtds      1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-vhd       1 build-check(1)               blocked  n/a
 test-amd64-i386-qemuu-rhel6hvm-amd  1 build-check(1)               blocked n/a
 test-amd64-i386-pair          1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-freebsd10-i386  1 build-check(1)               blocked  n/a
 test-amd64-i386-freebsd10-amd64  1 build-check(1)               blocked  n/a
 test-amd64-coresched-i386-xl  1 build-check(1)               blocked  n/a
 build-armhf-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-arndale   1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-credit1   1 build-check(1)               blocked  n/a
 test-amd64-i386-qemuu-rhel6hvm-intel  1 build-check(1)             blocked n/a
 test-amd64-i386-xl            1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-pvshim     1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-qemuu-debianhvm-amd64  1 build-check(1)         blocked n/a
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow  1 build-check(1)  blocked n/a
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm  1 build-check(1)      blocked n/a
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 1 build-check(1) blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a
 test-amd64-i386-xl-qemuu-win7-amd64  1 build-check(1)              blocked n/a
 test-amd64-i386-xl-qemuu-ws16-amd64  1 build-check(1)              blocked n/a
 test-amd64-i386-xl-shadow     1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-vhd        1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-xsm        1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165682
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165682
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165682
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 qemuu                c5b2f559814104f4145f8bc310f4d33c7ead8f49
baseline version:
 qemuu                50352cce138ef3b30c1cda28a4df68fff5da3202

Last test of basis   165682  2021-10-19 21:09:14 Z    4 days
Failing since        165694  2021-10-20 18:09:12 Z    4 days   10 attempts
Testing same since   165823  2021-10-24 00:36:48 Z    0 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
  Alistair Francis <alistair.francis@wdc.com>
  Andrew Jones <drjones@redhat.com>
  Ani Sinha <ani@anisinha.ca>
  BALATON Zoltan <balaton@eik.bme.hu>
  Bin Meng <bmeng.cn@gmail.com>
  Cédric Le Goater <clg@kaod.org>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  David Gibson <david@gibson.dropbear.id.au>
  David Hildenbrand <david@redhat.com>
  Eric Auger <eric.auger@redhat.com>
  Eugenio Pérez <eperezma@redhat.com>
  Frank Chang <frank.chang@sifive.com>
  Gavin Shan <gshan@redhat.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Greg Kurz <groug@kaod.org>
  Gustavo Romero <gromero@linux.ibm.com>
  Igor Mammedov <imammedo@redhat.com>
  Jason Wang <jasowang@redhat.com>
  John Wang <wangzhiqiang02@inspur.com>
  John Wang <wangzq.jn@gmail.com>
  Laurent Vivier <laurent@vivier.eu>
  Laurent Vivier <lvivier@redhat.com>
  Luc Michel <lmichel@kalray.eu>
  Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
  Matheus Ferst <matheus.ferst@eldorado.org.br>
  Mathieu Poirier <mathieu.poirier@linaro.org>
  Michael S. Tsirkin <mst@redhat.com>
  Mingwang Li <limingwang@huawei.com>
  Oğuz Ersen <oguzersen@protonmail.com>
  Philipp Tomsich <philipp.tomsich@vrull.eu>
  Philippe Mathieu-Daudé <f4bug@amsat.org>
  Philippe Mathieu-Daudé <philmd@redhat.com>
  Richard Henderson <richard.henderson@linaro.org>
  Shuuichirou Ishii <ishii.shuuichir@fujitsu.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Thomas Huth <thuth@redhat.com>
  Tong Ho <tong.ho@xilinx.com>
  Travis Geiselbrecht <travisg@gmail.com>
  Vincent Palatin <vpalatin@rivosinc.com>
  Xueming Li <xuemingl@nvidia.com>
  Yanan Wang <wangyanan55@huawei.com>
  Yifei Jiang <jiangyifei@huawei.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               fail    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          blocked 
 test-amd64-i386-xl                                           blocked 
 test-amd64-coresched-i386-xl                                 blocked 
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  blocked 
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       blocked 
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           blocked 
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     blocked 
 test-amd64-i386-freebsd10-amd64                              blocked 
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          blocked 
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          blocked 
 test-armhf-armhf-xl-arndale                                  blocked 
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  blocked 
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  blocked 
 test-armhf-armhf-xl-cubietruck                               blocked 
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         blocked 
 test-amd64-i386-freebsd10-i386                               blocked 
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         blocked 
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                blocked 
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         blocked 
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 blocked 
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    blocked 
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     blocked 
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              blocked 
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    blocked 
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      blocked 
 test-amd64-i386-xl-vhd                                       blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 3631 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Oct 25 00:29:12 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Oct 2021 00:29:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.215603.374895 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1menrH-0002fp-Jk; Mon, 25 Oct 2021 00:28:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 215603.374895; Mon, 25 Oct 2021 00:28:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1menrH-0002fi-EL; Mon, 25 Oct 2021 00:28:59 +0000
Received: by outflank-mailman (input) for mailman id 215603;
 Mon, 25 Oct 2021 00:28:57 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1menrF-0002fY-T6; Mon, 25 Oct 2021 00:28:57 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1menrF-0005u3-O7; Mon, 25 Oct 2021 00:28:57 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1menrF-0005nX-Br; Mon, 25 Oct 2021 00:28:57 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1menrF-0007fW-BM; Mon, 25 Oct 2021 00:28:57 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=TlS4jCZt+F0C6jLks/gjUuQA9HIdSCHp01TCr6z8M5A=; b=ZWGS4QfdYntxDCiqciyz+lL9An
	uXRg43oWBW65z+ywdSFaGRtu240NyRmnOVAyOwQ9nkUpJikfvVboFVFb56Re3OBQGJqXLNXiMNA4X
	6f3+3LZnningrP5T96/C0ZH2Is2iBsp9IZ4XLbQSRFuguAyErShs2GyZfx8pB7MAyc+4=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165841-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 165841: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=6c62666d8879238578b727f8e0a821e90c88f87e
X-Osstest-Versions-That:
    linux=9c0c4d24ac000e52d55348961d3a3ba42065e0cf
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 25 Oct 2021 00:28:57 +0000

flight 165841 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165841/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 165802
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 165802
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165802
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 165802
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165802
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 165802
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 165802
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165802
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 linux                6c62666d8879238578b727f8e0a821e90c88f87e
baseline version:
 linux                9c0c4d24ac000e52d55348961d3a3ba42065e0cf

Last test of basis   165802  2021-10-23 04:10:09 Z    1 days
Testing same since   165841  2021-10-24 17:40:42 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Adrian Hunter <adrian.hunter@intel.com>
  Andrea Parri (Microsoft) <parri.andrea@gmail.com>
  Andy Lutomirski <luto@kernel.org>
  Borislav Petkov <bp@suse.de>
  Colin Ian King <colin.king@canonical.com>
  Dexuan Cui <decui@microsoft.com>
  Dmitry Bogdanov <d.bogdanov@yadro.com>
  Hyunchul Lee <hyc.lee@gmail.com>
  Joy Gu <jgu@purestorage.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Marios Makassikis <mmakassikis@freebox.fr>
  Martin K. Petersen <martin.petersen@oracle.com>
  Mike Christie <michael.christie@oracle.com>
  Miles Chen <miles.chen@mediatek.com>
  Ming Lei <ming.lei@redhat.com>
  Namjae Jeon <linkinjeon@kernel.org>
  Peter Zijlstra (Intel) <peterz@infradead.org>
  Ralph Boehme <slow@samba.org>
  Sreekanth Reddy <sreekanth.reddy@broadcom.com>
  Steve French <stfrench@microsoft.com>
  Thomas Gleixner <tglx@linutronix.de>
  Woody Lin <woodylin@google.com>
  Yi Zhang <yi.zhang@redhat.com>
  Zheyu Ma <zheyuma97@gmail.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   9c0c4d24ac00..6c62666d8879  6c62666d8879238578b727f8e0a821e90c88f87e -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Mon Oct 25 01:25:35 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Oct 2021 01:25:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.215613.374915 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1meojv-0001y2-W1; Mon, 25 Oct 2021 01:25:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 215613.374915; Mon, 25 Oct 2021 01:25:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1meojv-0001xv-RW; Mon, 25 Oct 2021 01:25:27 +0000
Received: by outflank-mailman (input) for mailman id 215613;
 Mon, 25 Oct 2021 01:25:26 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=9eqc=PN=gmail.com=jandryuk@srs-us1.protection.inumbo.net>)
 id 1meoju-0001xp-Mp
 for xen-devel@lists.xenproject.org; Mon, 25 Oct 2021 01:25:26 +0000
Received: from mail-lf1-x12e.google.com (unknown [2a00:1450:4864:20::12e])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 52efbf3f-c06e-4b09-ae9c-7675dd2b7631;
 Mon, 25 Oct 2021 01:25:25 +0000 (UTC)
Received: by mail-lf1-x12e.google.com with SMTP id u21so9874049lff.8
 for <xen-devel@lists.xenproject.org>; Sun, 24 Oct 2021 18:25:25 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 52efbf3f-c06e-4b09-ae9c-7675dd2b7631
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=p5T2EfZYyfkG5Z23knzLOru2yfkRV1ugrXppMS5fiXY=;
        b=Ib86kGbYxPnQQ465yraknbQ9FzDUdsN6TPf0FYNMjVQ4o9TlU/LiuoeQ96nw8tSGpK
         ZyFyHdjITivDnXfzYT5Cd8pgiPWYGA1SgIkRy3wPrlyb7ghApKTQWeIRu/OIarztdebG
         TUoMFWg6oRTaIJJpxvia64iVZGUiMn3SOQ9tFEAYJtAyV32MkvH71LW+hV/W3/iO+Z47
         aMJQ/B0nRzVkHubd7seq8mX1eiEz4EXDTSUZgoel7CnqvApk0Tu1ykRTtGntcrDH//0g
         jUbl63Fb4BlO6geV1yKO6vmpxEdrfTW14vkQrBEOyhtkr3yqtZ3loBGUeaYjZ768VsYW
         QSwA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=p5T2EfZYyfkG5Z23knzLOru2yfkRV1ugrXppMS5fiXY=;
        b=Mb9uKjBxR/zB0UYB9rHRONd7WliqJWMMS68YnFt3FUY8PTnfi//LT/lRfKCMXZCwO6
         QiQCab3kDnb/jm3+22QhO/mZchFAXO9xaZ9Kf7Kko0XXGhcroqLbYy6Qh8QOCr2anP40
         EpdABzBgvFPEitQuDsJQi7M3CMBiVoVhHDdoDNjJcFGT5oQp6iq18+/QK+0M6r35DTig
         slL5pyPqxtetgkFFxZZKAuJc6U3RYt0UFFCECbPHv9jHhyP3l0EgVVIREDHKQtlrmSqG
         VsSswD7J2mODvSoEaU6iErbbpej1rnwmb/7mwdn5nOJx2UBboUkBJRlvrXLjArUxU6Tc
         sg6A==
X-Gm-Message-State: AOAM532/WeH3/ysxBApbiuKPwXsd7p8Bktt3dYXDYqJKPg8M0jV48ZvL
	ac5ouG6qJwL4nKPBg41Tq/At3fCK7+jOV4sCMEA=
X-Google-Smtp-Source: ABdhPJy6M/gmp5NOw/fxpoOY/JQYXFqfbnkhNuBYl7lMg+mAJmReG67HNIqVK4RLFOxAbBbxWLTE+SmFI33ykmdhpKo=
X-Received: by 2002:a05:6512:b21:: with SMTP id w33mr13882544lfu.447.1635125124623;
 Sun, 24 Oct 2021 18:25:24 -0700 (PDT)
MIME-Version: 1.0
References: <20211019202906.GA2397931@bhelgaas> <5f050b30-fa1c-8387-0d6b-a667851b34b0@oderland.se>
 <877de7dfl2.wl-maz@kernel.org> <CAKf6xpt=ZYGyJXMwM7ccOWkx71R0O-QeLjkBF-LtdDcbSnzHsA@mail.gmail.com>
 <3434cb2d-4060-7969-d4c4-089c68190527@oderland.se> <90277228-cf14-0cfa-c95e-d42e7d533353@oderland.se>
In-Reply-To: <90277228-cf14-0cfa-c95e-d42e7d533353@oderland.se>
From: Jason Andryuk <jandryuk@gmail.com>
Date: Sun, 24 Oct 2021 21:25:12 -0400
Message-ID: <CAKf6xpvZ8fxuBY4BZ51UZzF92zDUcvfav9_pOT7F3w-Bc8YkwA@mail.gmail.com>
Subject: Re: [PATCH v2] PCI/MSI: Re-add checks for skip masking MSI-X on Xen PV
To: Josef Johansson <josef@oderland.se>
Cc: Marc Zyngier <maz@kernel.org>, Bjorn Helgaas <helgaas@kernel.org>, linux-pci@vger.kernel.org, 
	xen-devel <xen-devel@lists.xenproject.org>, Thomas Gleixner <tglx@linutronix.de>, 
	Juergen Gross <jgross@suse.com>, Boris Ostrovsky <boris.ostrovsky@oracle.com>
Content-Type: text/plain; charset="UTF-8"

On Sun, Oct 24, 2021 at 2:55 PM Josef Johansson <josef@oderland.se> wrote:

> I ended up with this patch, I also masked pci_set_mask and
> pci_set_unmask, even though patching __pci_restore_msi_state and
> __pci_restore_msi_state solved this problem, I found that it did not
> properly make the system be able to survive flip_done timeout related
> problems during suspend/resume. Would this be something you had in mind
> Marc? I will make one more try with just patching
> __pci_restore_msi_state and __pci_restore_msix_state just to make sure.
> diff --git a/drivers/pci/msi.c b/drivers/pci/msi.c index
> 4b4792940e86..0b2225066778 100644 --- a/drivers/pci/msi.c +++
> b/drivers/pci/msi.c @@ -420,7 +420,8 @@ static void
> __pci_restore_msi_state(struct pci_dev *dev) arch_restore_msi_irqs(dev);
> pci_read_config_word(dev, dev->msi_cap + PCI_MSI_FLAGS, &control); -
> pci_msi_update_mask(entry, 0, 0); + if (!(pci_msi_ignore_mask ||
> entry->msi_attrib.is_virtual)) + pci_msi_update_mask(entry, 0, 0);
> control &= ~PCI_MSI_FLAGS_QSIZE; control |= (entry->msi_attrib.multiple

This patch was mangled.

> This makes sense the patch would be like so, I'm testing this out now
> hoping it will
>
> perform as good. Now the check is performed in four places

Close.  I'll reply with my compiled, but untested patch of what I was thinking.

> That leaves me with a though, will this set masked, and should be checked as well?
>
> void __pci_write_msi_msg(struct msi_desc *entry, struct msi_msg *msg)
> {
>         struct pci_dev *dev = msi_desc_to_pci_dev(entry);
>
>         if (dev->current_state != PCI_D0 || pci_dev_is_disconnected(dev)) {
>                 /* Don't touch the hardware now */
>         } else if (entry->msi_attrib.is_msix) {
>                 void __iomem *base = pci_msix_desc_addr(entry);
>                 u32 ctrl = entry->msix_ctrl;
>                 bool unmasked = !(ctrl & PCI_MSIX_ENTRY_CTRL_MASKBIT);
>
>                 if (entry->msi_attrib.is_virtual)
>                         goto skip;
>
>                 /*
>                  * The specification mandates that the entry is masked
>                  * when the message is modified:
>                  *
>                  * "If software changes the Address or Data value of an
>                  * entry while the entry is unmasked, the result is
>                  * undefined."
>                  */
>                 if (unmasked)
> >>>                     pci_msix_write_vector_ctrl(entry, ctrl | PCI_MSIX_ENTRY_CTRL_MASKBIT);

My patch adds a check in pci_msix_write_vector_ctrl(), but the comment
above means PV Xen's behavior may be incorrect if Linux is calling
this function and modifying the message.

Regards,
Jason


From xen-devel-bounces@lists.xenproject.org Mon Oct 25 01:26:03 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Oct 2021 01:26:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.215616.374925 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1meokV-0002V2-6p; Mon, 25 Oct 2021 01:26:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 215616.374925; Mon, 25 Oct 2021 01:26:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1meokV-0002Uv-3r; Mon, 25 Oct 2021 01:26:03 +0000
Received: by outflank-mailman (input) for mailman id 215616;
 Mon, 25 Oct 2021 01:26:01 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=9eqc=PN=gmail.com=jandryuk@srs-us1.protection.inumbo.net>)
 id 1meokT-0002Ul-G0
 for xen-devel@lists.xenproject.org; Mon, 25 Oct 2021 01:26:01 +0000
Received: from mail-qk1-x72b.google.com (unknown [2607:f8b0:4864:20::72b])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id dc59fe92-a2c6-486b-9e83-df967df2cc64;
 Mon, 25 Oct 2021 01:26:00 +0000 (UTC)
Received: by mail-qk1-x72b.google.com with SMTP id h20so10227437qko.13
 for <xen-devel@lists.xenproject.org>; Sun, 24 Oct 2021 18:26:00 -0700 (PDT)
Received: from shine.lan ([2001:470:8:67e:51e0:9342:22f6:f52e])
 by smtp.gmail.com with ESMTPSA id r186sm7786376qkf.128.2021.10.24.18.25.59
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sun, 24 Oct 2021 18:26:00 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: dc59fe92-a2c6-486b-9e83-df967df2cc64
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=VTEYBOVFC48ADDa8N43omwk7puK0joc4PFn0uiGMRcg=;
        b=jKwWtJj2+XorNlj49nPSke8a/Qft4zbyuljV+uV1cJ7UmjuQuKWRkIXvggCUofTGt2
         fVLAFa4nO7JOjDgshLvnReog5af2DO50+AKqbFHsLrCtSaIDbdw/d+yolCFh41KxOSfN
         JVrb5fOhJaDW0VdpOkD29CdgWJIRr413QXPcsaa21SPYZeWR1awOiKVnY5bYaAwYT63e
         bcdon+VyuSQ/O2n5n6MdhWxvzdZFckaSws/nc0JIcHPY8GX9nTah8n3p2z6eDL8M3BFF
         ZdhsE+C9QKoA/Bmsq03tfGHaljFw1Onk2KR26sai4r2EtPJtDmHiT1O6XklkU9XdFD90
         +Usw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=VTEYBOVFC48ADDa8N43omwk7puK0joc4PFn0uiGMRcg=;
        b=aQZbhqCZ2MqMlH3UI+2XdjpPlml9Zy5rq/kdZ2R/df8E+4cNQdjd5hlmlOt/T6QJG/
         488rcavU2utXWRnCiV8ZqLqlPtzt2ICWnGEjlBtmCTi+V7D8E5imWpOaJU90aGCO+n4o
         UzfmJVRmBX8r4Z3B1If9SzSFzvUt2o1YE9uGJhJxEOWWxfqsjp4nlv+wF4ZhyUgZekWa
         puHpB3VPM87aTc6H0TjSDS8zcywsEX9NxnW0Yi0M1vmHye9tDtM7n2FlBAFFi6lKaVLd
         TFll+Wbpj/SeTh7JypYjMJ2LcX0EcffuAcDP6KYJpgg+3wufZAO5dakmLCTABL8vrXLD
         PRVA==
X-Gm-Message-State: AOAM530OuME6GMthHu8hlAtPXxLuz4XwU8PjF3SozK7BOWqckzaUv53v
	gJVgs43jUMP5+wysGcvNZG0=
X-Google-Smtp-Source: ABdhPJxdhx9YsyD2piku1kRFpYGiExJbAde47xpWYo9zrILaPmf8HpF05Y/EzU1HwylCgQrMbg2KWQ==
X-Received: by 2002:a05:620a:45a3:: with SMTP id bp35mr11126547qkb.262.1635125160419;
        Sun, 24 Oct 2021 18:26:00 -0700 (PDT)
From: Jason Andryuk <jandryuk@gmail.com>
To: josef@oderland.se
Cc: boris.ostrovsky@oracle.com,
	helgaas@kernel.org,
	jandryuk@gmail.com,
	jgross@suse.com,
	linux-pci@vger.kernel.org,
	maz@kernel.org,
	tglx@linutronix.de,
	xen-devel@lists.xenproject.org
Subject: [PATCH] PCI/MSI: Fix masking MSI/MSI-X on Xen PV
Date: Sun, 24 Oct 2021 21:25:03 -0400
Message-Id: <20211025012503.33172-1-jandryuk@gmail.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <90277228-cf14-0cfa-c95e-d42e7d533353@oderland.se>
References: <90277228-cf14-0cfa-c95e-d42e7d533353@oderland.se>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

commit fcacdfbef5a1 ("PCI/MSI: Provide a new set of mask and unmask
functions") introduce functions pci_msi_update_mask() and
pci_msix_write_vector_ctrl() that is missing checks for
pci_msi_ignore_mask that exists in commit 446a98b19fd6 ("PCI/MSI: Use
new mask/unmask functions").  The checks are in place at the high level
__pci_msi_mask_desc()/__pci_msi_unmask_desc(), but some functions call
directly to the helpers.

Push the pci_msi_ignore_mask check down to the functions that make
the actual writes.  This keeps the logic local to the writes that need
to be bypassed.

With Xen PV, the hypervisor is responsible for masking and unmasking the
interrupts, which pci_msi_ignore_mask is used to indicate.

This change avoids lockups in amdgpu drivers under Xen during boot.

Fixes: commit 446a98b19fd6 ("PCI/MSI: Use new mask/unmask functions")
Reported-by: Josef Johansson <josef@oderland.se>
Signed-off-by: Jason Andryuk <jandryuk@gmail.com>
---
 drivers/pci/msi.c | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/drivers/pci/msi.c b/drivers/pci/msi.c
index 4b4792940e86..478536bafc39 100644
--- a/drivers/pci/msi.c
+++ b/drivers/pci/msi.c
@@ -148,6 +148,9 @@ static noinline void pci_msi_update_mask(struct msi_desc *desc, u32 clear, u32 s
 	raw_spinlock_t *lock = &desc->dev->msi_lock;
 	unsigned long flags;
 
+	if (pci_msi_ignore_mask)
+		return;
+
 	raw_spin_lock_irqsave(lock, flags);
 	desc->msi_mask &= ~clear;
 	desc->msi_mask |= set;
@@ -181,6 +184,9 @@ static void pci_msix_write_vector_ctrl(struct msi_desc *desc, u32 ctrl)
 {
 	void __iomem *desc_addr = pci_msix_desc_addr(desc);
 
+	if (pci_msi_ignore_mask)
+		return;
+
 	writel(ctrl, desc_addr + PCI_MSIX_ENTRY_VECTOR_CTRL);
 }
 
@@ -200,7 +206,7 @@ static inline void pci_msix_unmask(struct msi_desc *desc)
 
 static void __pci_msi_mask_desc(struct msi_desc *desc, u32 mask)
 {
-	if (pci_msi_ignore_mask || desc->msi_attrib.is_virtual)
+	if (desc->msi_attrib.is_virtual)
 		return;
 
 	if (desc->msi_attrib.is_msix)
@@ -211,7 +217,7 @@ static void __pci_msi_mask_desc(struct msi_desc *desc, u32 mask)
 
 static void __pci_msi_unmask_desc(struct msi_desc *desc, u32 mask)
 {
-	if (pci_msi_ignore_mask || desc->msi_attrib.is_virtual)
+	if (desc->msi_attrib.is_virtual)
 		return;
 
 	if (desc->msi_attrib.is_msix)
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Mon Oct 25 05:16:12 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Oct 2021 05:16:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.215634.374952 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mesKt-0007GF-UJ; Mon, 25 Oct 2021 05:15:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 215634.374952; Mon, 25 Oct 2021 05:15:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mesKt-0007G7-OX; Mon, 25 Oct 2021 05:15:51 +0000
Received: by outflank-mailman (input) for mailman id 215634;
 Mon, 25 Oct 2021 05:15:51 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=cRlh=PN=suse.com=jgross@srs-us1.protection.inumbo.net>)
 id 1mesKt-0007G1-FS
 for xen-devel@lists.xenproject.org; Mon, 25 Oct 2021 05:15:51 +0000
Received: from smtp-out2.suse.de (unknown [195.135.220.29])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 07f8dff7-192b-4f86-809a-29632ae868ab;
 Mon, 25 Oct 2021 05:15:50 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 905111FD34;
 Mon, 25 Oct 2021 05:15:49 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 52EB713216;
 Mon, 25 Oct 2021 05:15:49 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id 559qEoU9dmExXQAAMHmgww
 (envelope-from <jgross@suse.com>); Mon, 25 Oct 2021 05:15:49 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 07f8dff7-192b-4f86-809a-29632ae868ab
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1635138949; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=VkF58/O6rMYF7w+fW/mhWpG2ZdamDJNVtN8YuYc72cg=;
	b=trXnJpxG4YHOaOfig3UEvtz/gDmvOKfizZpWTqhTdPW71rudV5rXfOUhEwgjQH8HyAcROU
	hnn5eSSIOMZlgUkGQXnUgrXPJcw8LazOcxcZmrqMO6LZGMArkgJSRnZLOm3uUcHRsysN96
	IoBqP09vTVEnrZ8JK2mPa0+pmf32ylo=
To: Stefano Stabellini <sstabellini@kernel.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>
Cc: xen-devel@lists.xenproject.org, iwj@xenproject.org, cardoe@cardoe.com,
 wl@xen.org, anthony.perard@citrix.com,
 Stefano Stabellini <stefano.stabellini@xilinx.com>
References: <alpine.DEB.2.21.2110210831470.2311@sstabellini-ThinkPad-T480s>
 <20211021230839.10794-2-sstabellini@kernel.org>
 <19aa9196-eb5f-22a1-206c-c9c87ee79fa9@citrix.com>
 <alpine.DEB.2.21.2110221219300.2311@sstabellini-ThinkPad-T480s>
From: Juergen Gross <jgross@suse.com>
Subject: Re: [PATCH 2/3] automation: Linux 5.10.74 test-artifact
Message-ID: <d559b765-9e38-00bd-039b-9c33845b8e54@suse.com>
Date: Mon, 25 Oct 2021 07:15:48 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.21.2110221219300.2311@sstabellini-ThinkPad-T480s>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="nbcqAfpKddhmkMvvlZ0yEvivxsSipFDjd"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--nbcqAfpKddhmkMvvlZ0yEvivxsSipFDjd
Content-Type: multipart/mixed; boundary="bWDib4N95X55xsvAnbHvayXog9ReJuXwW";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Stefano Stabellini <sstabellini@kernel.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>
Cc: xen-devel@lists.xenproject.org, iwj@xenproject.org, cardoe@cardoe.com,
 wl@xen.org, anthony.perard@citrix.com,
 Stefano Stabellini <stefano.stabellini@xilinx.com>
Message-ID: <d559b765-9e38-00bd-039b-9c33845b8e54@suse.com>
Subject: Re: [PATCH 2/3] automation: Linux 5.10.74 test-artifact
References: <alpine.DEB.2.21.2110210831470.2311@sstabellini-ThinkPad-T480s>
 <20211021230839.10794-2-sstabellini@kernel.org>
 <19aa9196-eb5f-22a1-206c-c9c87ee79fa9@citrix.com>
 <alpine.DEB.2.21.2110221219300.2311@sstabellini-ThinkPad-T480s>
In-Reply-To: <alpine.DEB.2.21.2110221219300.2311@sstabellini-ThinkPad-T480s>

--bWDib4N95X55xsvAnbHvayXog9ReJuXwW
Content-Type: multipart/mixed;
 boundary="------------4A24964856533E683D482D35"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------4A24964856533E683D482D35
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 22.10.21 21:41, Stefano Stabellini wrote:
> +Juergen
>=20
> On Fri, 22 Oct 2021, Andrew Cooper wrote:
>> On 22/10/2021 00:08, Stefano Stabellini wrote:
>>> +# build depends
>>> +RUN apt-get update && \
>>> +    apt-get --quiet --yes install \
>>> +        build-essential \
>>> +        libssl-dev \
>>> +        bc \
>>> +        curl \
>>> +        flex \
>>> +        bison \
>>> +        libelf-dev \
>>> +        && \
>>> +    \
>>> +    # Build the kernel
>>> +    curl -fsSLO https://cdn.kernel.org/pub/linux/kernel/v5.x/linux-"=
$LINUX_VERSION".tar.xz && \
>>> +    tar xvJf linux-"$LINUX_VERSION".tar.xz && \
>>> +    cd linux-"$LINUX_VERSION" && \
>>> +    make defconfig && \
>>> +    make xen.config && \
>>> +    cp .config .config.orig && \
>>> +    cat .config.orig | grep XEN | grep =3Dm |sed 's/=3Dm/=3Dy/g' >> =
=2Econfig && \
>>> +    make -j$(nproc) bzImage && \
>>
>> defconfig is huuuuge.=C2=A0 Can we use tinyconfig instead?
>>
>> Also, you want to turn off CONFIG_MODULES seeing as you only copy
>> bzImage to the test.
>>
>> This also fixes the fact that `grep XEN` also matches CONFIG_NETXEN_NI=
C
>> which has nothing to do with Xen.
>=20
> Tinyconfig would be a good idea but it crashes on QEMU with the appende=
d
> boot log. I did:
>=20
> # make tinyconfig
> # make xen.config
> # make bzImage
>=20
> Of course we could have our own tailored special kernel config for this=

> kernel but I like the simplicify of "make tinyconfig" or "make
> defconfig" followed by "make xen.config".
>=20
> Unless you know one kconfig option or two that we need to add to
> tinyconfig to make it work my preference is to go with defconfig for
> now.

You will need to add the dom0 and SMP related config options at least.

I'll have a look at config.xen, which is a little bit weird: it
configures the backends, but not dom0.


Juergen

--------------4A24964856533E683D482D35
Content-Type: application/pgp-keys;
 name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Transfer-Encoding: quoted-printable
Content-Description: OpenPGP public key
Content-Disposition: attachment;
 filename="OpenPGP_0xB0DE9DD628BF132F.asc"

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy=
cWx
w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O=
f8Z
d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y=
9bf
IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq=
G7/
377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR=
3Jv
c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA=
QIe
AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT=
hpw
dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0=
MbD
1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv=
oPH
Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v=
5QL
+qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ=
2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC=
QoL
BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr=
Wf0
teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC=
/nu
AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh=
ITT
d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm=
XBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz=
80h
SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC=
AcD
AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn=
FOX
gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1=
jnD
kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0=
N51
N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l=
otu
fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1=
tqS
EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA=
hsD
BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3=
g3O
ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5=
dM7
wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5=
D+j
LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm=
V2x
AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N=
Eaw
QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW=
nHI
s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR=
wgn
BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV=
bVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk=
pEd
IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA=
QAB
wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw=
Tbe
8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1=
vJz
Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8=
VGi
wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW=
svi
uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX=
zXs
ZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------4A24964856533E683D482D35--

--bWDib4N95X55xsvAnbHvayXog9ReJuXwW--

--nbcqAfpKddhmkMvvlZ0yEvivxsSipFDjd
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmF2PYQFAwAAAAAACgkQsN6d1ii/Ey9o
Zgf/ccrmkzM8R+wIcL6v65HmdsC64c/O5bYVeqxcFMgd18f8G0NR8ivFtgGDdwGj3Lzdc2+4yz8n
QspwQAFbcYKJq20oj+VmPHY5NdT7Zn0OiqtyDGm67epkrLMmxU0zL+vwvBrwWJh9WZCDG/AhjENI
bpR8VKKA4LAQ6RsOUiAvu/rD1eJ7TD9BdQ/43041b5XGgw9lS46woRXWqMm5UR+QWHtF9PzdoeoU
RV5qBIkT+0C6bKmfZnOFqeberKnUlI4sDTe9uiqMHZh2vVxRV6sQGQD6GTUEJ4MUKi0NSVDG2r9c
Z2i5UAiB0h3WvVuhtWIdWcH0YePlhquywkqkIZHCOw==
=RdfD
-----END PGP SIGNATURE-----

--nbcqAfpKddhmkMvvlZ0yEvivxsSipFDjd--


From xen-devel-bounces@lists.xenproject.org Mon Oct 25 05:21:12 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Oct 2021 05:21:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.215641.374963 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mesQ0-0000DD-FS; Mon, 25 Oct 2021 05:21:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 215641.374963; Mon, 25 Oct 2021 05:21:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mesQ0-0000D6-CQ; Mon, 25 Oct 2021 05:21:08 +0000
Received: by outflank-mailman (input) for mailman id 215641;
 Mon, 25 Oct 2021 05:21:07 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=IWrL=PN=oracle.com=dongli.zhang@srs-us1.protection.inumbo.net>)
 id 1mesPz-0000D0-9E
 for xen-devel@lists.xenproject.org; Mon, 25 Oct 2021 05:21:07 +0000
Received: from mx0a-00069f02.pphosted.com (unknown [205.220.165.32])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 582684d6-3553-11ec-840b-12813bfff9fa;
 Mon, 25 Oct 2021 05:21:02 +0000 (UTC)
Received: from pps.filterd (m0246617.ppops.net [127.0.0.1])
 by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 19P3adJF012322; 
 Mon, 25 Oct 2021 05:20:43 GMT
Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80])
 by mx0b-00069f02.pphosted.com with ESMTP id 3bw7r0979n-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Mon, 25 Oct 2021 05:20:43 +0000
Received: from pps.filterd (userp3030.oracle.com [127.0.0.1])
 by userp3030.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 19P5FqmF023998;
 Mon, 25 Oct 2021 05:20:41 GMT
Received: from nam11-bn8-obe.outbound.protection.outlook.com
 (mail-bn8nam11lp2172.outbound.protection.outlook.com [104.47.58.172])
 by userp3030.oracle.com with ESMTP id 3bv7gtv65u-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Mon, 25 Oct 2021 05:20:41 +0000
Received: from BYAPR10MB2663.namprd10.prod.outlook.com (2603:10b6:a02:a9::20)
 by BY5PR10MB4354.namprd10.prod.outlook.com (2603:10b6:a03:20c::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.18; Mon, 25 Oct
 2021 05:20:39 +0000
Received: from BYAPR10MB2663.namprd10.prod.outlook.com
 ([fe80::2848:63dc:b87:8021]) by BYAPR10MB2663.namprd10.prod.outlook.com
 ([fe80::2848:63dc:b87:8021%7]) with mapi id 15.20.4628.020; Mon, 25 Oct 2021
 05:20:39 +0000
Received: from [IPv6:2606:b400:400:7446:8000::4e] (2606:b400:8301:1010::16aa)
 by SA0PR12CA0004.namprd12.prod.outlook.com (2603:10b6:806:6f::9) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.16 via Frontend
 Transport; Mon, 25 Oct 2021 05:20:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 582684d6-3553-11ec-840b-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc :
 references : from : message-id : date : in-reply-to : content-type :
 content-transfer-encoding : mime-version; s=corp-2021-07-09;
 bh=zRw+C1ltqjv8mAnE2AA7Jc4EUdGxJvW5/xO0T7uXZ2c=;
 b=Swk8k+8g5kmWmcY6ZEXb/AbOelzc8bVEVuyq3JVYVP13cJkYLrxb9fAgp0q9aPDlhBOJ
 7UhPFWn94fLxbW73J3YgTAWPPpEEDBsnFvbHZwkNV1QpC5JgeNckBQ5Cqqbaj64zZpwr
 8NMu8E3lF/t8tYhOZVZ0EAuk97Szhj+9mlL1wJjfptXsetTh+l08muETco2w56QMK6j1
 SMGKfLA/f47tGL4C3weXsS8QRRQpOwpCLXCAI6wGCLc8jLTWyF2G5InInmqrJO7tuJ07
 4VeLappE+VCY6W2rGBobekDpPvVo96OGH67YashA1s3TkmThvMVLLDWzB6Q57EmlFjfU Aw== 
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=FkLXV7leeT9UAFGgz4CSqc8e/oxSRsrel8Xb3+rKcABtckT67sHm2mXF27jnxm3/SBKqvFwvWFXSpMyoFVTj088zP284vOcBAabZbqdfg/H2pe4NRLb/lwMq+xwvlT1iD13T2aSC4CBsurF4/Yi7hOEE1y1S1Ftwy9eVTVZudPojcyMne3ypeBy+/0rmeC7Nc7+N4dM8/qqEuyB2RBkStd/+YLNxmFkPbxeATMbcoL+gYJYQbcMlkzE/5nwTSWdF750e35jsELo4i6GJxMdkmpEzAEpxIcU02BWOVfO8Xq0bF79PsgvrPubOZwzv50+UssL3hrW2qXZDb3MiX5fqxQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=zRw+C1ltqjv8mAnE2AA7Jc4EUdGxJvW5/xO0T7uXZ2c=;
 b=fXcesXo0NxgQMTJsNAD08/YG9AjPi6CXUoRWUOdIM0oQOCHYwrwu7d5+l2sHUV8OEBsKsV8FCDmoSTo7LoNIAwDXBWFZHrssOTAzxO47pq3+h5QwnxLaaczhiBZ30I6DEWI+Au2MIoI88oLmy/Ptnhx5G3S5Uu0u3eE6bSvGOWZ6ypp94X/DCdbDEkYoERTEfypbjikjS9g1km155I4Cy7nsoIoPESbkThAL11CBX0nyabZFMo2ViYQlcFU1OeF2xCaPxXzoBqOZHPSiiyHyYbwJgm3gnVWoyiEJyRsgHUqp3mxwlRAPiy+u137XIftLt9YSdnljbmZIBi1jnebH5A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com;
 dkim=pass header.d=oracle.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=zRw+C1ltqjv8mAnE2AA7Jc4EUdGxJvW5/xO0T7uXZ2c=;
 b=jV/IsQXnHeVxrt4KSN5oki42QGNJHZGK1+EixBP0dP6EtYAHUDFJ/8nnXGFCnzDgyRH7oNzaHDyC0x67c+NDUb25GhkQtGysdM/sxBmO0qU4QZnBLRz/MIWJ9DGTsEAOShEQSydJ91UeoQbjXvysZi+iwN88JUog3e3ltda9X+0=
Authentication-Results: oracle.com; dkim=none (message not signed)
 header.d=none;oracle.com; dmarc=none action=none header.from=oracle.com;
Subject: Re: [PATCH linux 1/2] xen: delay xen_hvm_init_time_ops() if kdump is
 boot on vcpu>=32
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
        xen-devel@lists.xenproject.org
Cc: linux-kernel@vger.kernel.org, x86@kernel.org, jgross@suse.com,
        sstabellini@kernel.org, tglx@linutronix.de, mingo@redhat.com,
        bp@alien8.de, hpa@zytor.com, andrew.cooper3@citrix.com,
        george.dunlap@citrix.com, iwj@xenproject.org, jbeulich@suse.com,
        julien@xen.org, wl@xen.org, joe.jin@oracle.com
References: <20211012072428.2569-1-dongli.zhang@oracle.com>
 <20211012072428.2569-2-dongli.zhang@oracle.com>
 <4faf461f-49ca-5f2b-a7dc-e2b47b904527@oracle.com>
From: Dongli Zhang <dongli.zhang@oracle.com>
Message-ID: <e4727868-cce2-d705-c84f-1d66204c7814@oracle.com>
Date: Sun, 24 Oct 2021 22:20:34 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.6.1
In-Reply-To: <4faf461f-49ca-5f2b-a7dc-e2b47b904527@oracle.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: SA0PR12CA0004.namprd12.prod.outlook.com
 (2603:10b6:806:6f::9) To BYAPR10MB2663.namprd10.prod.outlook.com
 (2603:10b6:a02:a9::20)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 69ec7a55-bff4-48c1-7bf2-08d997772ea5
X-MS-TrafficTypeDiagnostic: BY5PR10MB4354:
X-Microsoft-Antispam-PRVS: 
	<BY5PR10MB43549C5611F2E4BD69EF81E7F0839@BY5PR10MB4354.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 
	abZRiZ2PzzkT5CHiyzB+ROlaVtflBZIedj3crPzL6tY3v/vWTOqpZ5X+vMA34Cn8mXXKjC2JJZM6xT+SwI/dxbVImL2pW0opqfjRMBHoQ7d7Q1emxTplMlzZN9JsLD779dJnUdg4O60k69vLwwZvzpQ91lHhGs+vv9akpJpBju29dPM5myM+hPrmjZMsvFMG9HqUn5DVP9A7JVJjYcq2X3x69McQ5rLIZtaqKMANadXuFKcI020oBfBsUJ9YmxOBzrM3YdxpiXmPbzH0KRQE3YQUpFoFU5RvNGJsAF31jYgRppMZ86YO1zcGEEgcRM9hunRDHf0QO1CFYSI5Trfi7qYTdXdNu8PDjgZ6xsWQKTVCoCEmm4Y7wK12+GgvBzX+IRH2L51vhcDWsPzmupd5aMedJlkvLt64sTKy8Mnjyb6bXC052hUo52Q2vEi8RSLUjK8FfUgliFkhaYK/XtA7c5Yrck3/cE9zByhy+Qvb53LfUyDNc4jQ/Ix+/Wr+L2IhXMMmivmnEsjTudCulaiXXMuJ7gQ+bHpARSZIuwmWzpUkKFE113b8bqBadyVxUyIbjSBmkPyOOMrK0DXPmFDlVpdmVUhUcIdLJCcbf0pFBdJck2omeP0ZDc1lZVTc1xCI3QZqQPN9oY/XUHvHckLEwFqZCc8K2+W5+Mg9XeZynCkTPGd6RPiI0JQmdSjI9A0w1bGCS9OTTHiA2dkfMSrrqj6jh3eHwKKI/tQcJ3BzqrE=
X-Forefront-Antispam-Report: 
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB2663.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(8676002)(7416002)(508600001)(186003)(36756003)(44832011)(2616005)(107886003)(31686004)(6486002)(38100700002)(83380400001)(2906002)(66476007)(4326008)(5660300002)(86362001)(316002)(6666004)(31696002)(53546011)(66946007)(8936002)(66556008)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?dnNZaDQzV0J0Y0Mvc1Awc1JxVXl2YXgxWSs2RzVDQXVOdkVXaUgzQkNZaFNr?=
 =?utf-8?B?aWNLMWsrc2hMWHg5T2o1RFlIdlJkYU9tWUducUNITkdFMzZkdlNBQ1RVUDE1?=
 =?utf-8?B?R0E1VmwxRGxiS1RJYzVRb0NvQzdjb2R2MGc0QXpXV29NRWY2R1pJSTl4SExE?=
 =?utf-8?B?MDE4b2R1MnhIQ3BPS29ydXJuV1RUTUNUSXFuYXZScTdDM1dWOCtvY1Q2NlNl?=
 =?utf-8?B?QTRYUkRNSW85TU1tclNCeTB5cElkYXloOFlIa0p1TVlUUEJUektYNVBnalMz?=
 =?utf-8?B?RWl4cXNOQ1Z6ZmFnM3hSeVF3c0dpRUlnMHVRcjk2U0lqUzBkWTBJM2JrRjJl?=
 =?utf-8?B?MnUzU0NBQUxhb3JCQVJEWnlRSEw1TkdsL05tQWxFSXJXUmVpR1RIK1pOWFNR?=
 =?utf-8?B?WmpZNithM2xwYUZoOWpucUhBRGVUK1NsQWRNM1JlTFM3M0JIU2JPOC9BVk9l?=
 =?utf-8?B?Rk8zNzk2NExqdHlSSVhkemM0b0pxSDNhVzF1T0RrZkpFamozQi8zYlZqcWo2?=
 =?utf-8?B?Ym1hR0xtQWFDUUNtbUJ5S3dtT1h1RzNqR05rNHhraU1BRGU1eGRubGN6MTQv?=
 =?utf-8?B?T1F4aWhQakhjd1BJQ1ZISVJyM2lkRzdvM25VSTJjMGZIL3d5UHJDemovbk1u?=
 =?utf-8?B?dHY4TDBOc21TWlVuUnJ4eWNqV2o1bzVFWWRMOHlibmlWYkx2K1RudUlxRnVt?=
 =?utf-8?B?dlFjQStLK0dRZnRmY0lESXJYamJUUTBCUGx5aU9tbGFPR1J5cHdmUzZvUTJl?=
 =?utf-8?B?STJkU0JUSTJTOWRXbTRLZHFSS2p1NFBReWY2VVFMZVpoTkN5czNJazNyQnZD?=
 =?utf-8?B?cXlybUpaaHJzcDNieURaWEsxTkc0R1YzdWEzVTdqZ0dSeXErd083OFdpZHFa?=
 =?utf-8?B?SDl3ZHViSU11eE1YTno4enp2Yy9TOGlhYlRLY0xUL3VZQjVEeVJpTkpMYTJj?=
 =?utf-8?B?TjBXRXZUOVJDTjFFK0JxQTJjYWtYVHMvb2dsaVhaWkhlSWZVSnh3NStBMGlQ?=
 =?utf-8?B?bXl6dTlRVzB3K3dxamh0T3M3N084N01WMGJJSjhrZ3RKdkJ6VmI2WVIxQy9K?=
 =?utf-8?B?Q0liaWlHU3NmT044NmtHdW0zc1pwRTZjU2p0aGt5SHk2YmVzU1FERDVtVVdE?=
 =?utf-8?B?bUtndStybDNpUnoxREtJL1dPaXVxZi9ob1B4VWUxa0c2Vnk2bm9ZRGxYS3Rt?=
 =?utf-8?B?djlwYVpDNGJBeDdSK1VWckdsMnlOQWpnejJpaWtCUUFjQWNrT2p0Y2ZqWGZF?=
 =?utf-8?B?ekRjQkZZNFMxcGpoOWV4akh4Yk5rOUN4cXY0MDNvMDRxRjNkWldSQjdObTBa?=
 =?utf-8?B?bXpscGpKSUxSakw2ekpEYktYeGpRc2RTcHByMTdiSHVJZ1FEL2RqQW16ZDZ5?=
 =?utf-8?B?L0dENmwyOUxIQ0ZYUTJ4RWtRVVhLWHBnZmk1cXZuSGpRRHpFZ1AyTy9LRWp6?=
 =?utf-8?B?S1pZc3VKWHFZUktYbUNlcytIU3hzemd6SStrZnpnOXBORkNBc3grU0dZbXRQ?=
 =?utf-8?B?WHF5N3VBNStwTHZxY00vNDRPdjZQYW9BVnRoQW5TVGh3OGppanV3ZWN3WDMv?=
 =?utf-8?B?bFlXaXpNWU9pbnNRS3U1Y1ZhZEZmS0R3TENmdjRpRDh5bUQ1elBHdmNidnZ2?=
 =?utf-8?B?eFNyTlhNQ0tjTXF6d3lWbnQ3dkNIQ0E4YjE3UWdpdmRNTVVjbFNPS3N4bG5S?=
 =?utf-8?B?TUJxTUFubEpiQVpucEtNeWVXMkZyaW11aUVpeVF5TFd3aTJrY01wNmJBRWti?=
 =?utf-8?B?blpqajlhdlhtb3Y0d3lQTzY4cGMvZ29RcFNhTkMrejJtNzNwQkJ1YmxVSFlO?=
 =?utf-8?B?ekpsK0hDQlM0bUhQOFZrVG1IS2todnZxSmptQWQ0dlpMdXFVWWhqK3IwanNC?=
 =?utf-8?B?ZnRncjBWTGtKU2RRR0RiM0hMc3pEbVRRMkFKNS9KN0I1SStxNE9VUWRlcVpY?=
 =?utf-8?B?YzlKK3FoWkN1dEVwZVF5Yi9wWmlHaGl4SUp0WGllaXc4aFhqNnJNZmY0MXRX?=
 =?utf-8?B?WVdnVHFBdzZZblJPVGowWTRZR3VPQ3c1L0gvWlg5U2JMMDlIbEFiQjFhK2d4?=
 =?utf-8?B?TDZEeDU2ZGF4cUw3dURQa0ZXS0RybEcxUTZrczdvSDRrTnQ5aTRVZ1F6NnE0?=
 =?utf-8?B?bFZKVlFsQk8yVVNCVUVoc0JZRFBhNGx5U1l5YlY1VTJDdEVoVytyWkFLbStE?=
 =?utf-8?Q?lqEdKop19Mv4Qh6JdFf4OuwK5WvuftMu8cLELKOuG1Ho?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 69ec7a55-bff4-48c1-7bf2-08d997772ea5
X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB2663.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2021 05:20:39.1843
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: fSaXwrkX8hKQIT78nVwVzB+QS/NwOi3p8XBovCFR3Ryq0AxrTGc2d14KyrwFqfmXgSG05Ql04LsEtt7q7TQ+xQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR10MB4354
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10147 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 phishscore=0 adultscore=0
 suspectscore=0 mlxscore=0 bulkscore=0 mlxlogscore=999 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109230001
 definitions=main-2110250029
X-Proofpoint-ORIG-GUID: Jv6xc1rSMIM71tnBkZvx1F4rNsixY7bV
X-Proofpoint-GUID: Jv6xc1rSMIM71tnBkZvx1F4rNsixY7bV

Hi Boris,

On 10/12/21 10:17 AM, Boris Ostrovsky wrote:
> 
> On 10/12/21 3:24 AM, Dongli Zhang wrote:
>> The sched_clock() can be used very early since upstream
>> commit 857baa87b642 ("sched/clock: Enable sched clock early"). In addition,
>> with upstream commit 38669ba205d1 ("x86/xen/time: Output xen sched_clock
>> time from 0"), kdump kernel in Xen HVM guest may panic at very early stage
>> when accessing &__this_cpu_read(xen_vcpu)->time as in below:
> 
> 
> Please drop "upstream". It's always upstream here.
> 
> 
>> +
>> +    /*
>> +     * Only MAX_VIRT_CPUS 'vcpu_info' are embedded inside 'shared_info'
>> +     * and the VM would use them until xen_vcpu_setup() is used to
>> +     * allocate/relocate them at arbitrary address.
>> +     *
>> +     * However, when Xen HVM guest panic on vcpu >= MAX_VIRT_CPUS,
>> +     * per_cpu(xen_vcpu, cpu) is still NULL at this stage. To access
>> +     * per_cpu(xen_vcpu, cpu) via xen_clocksource_read() would panic.
>> +     *
>> +     * Therefore we delay xen_hvm_init_time_ops() to
>> +     * xen_hvm_smp_prepare_boot_cpu() when boot vcpu is >= MAX_VIRT_CPUS.
>> +     */
>> +    if (xen_vcpu_nr(0) >= MAX_VIRT_CPUS)
> 
> 
> What about always deferring this when panicing? Would that work?
> 
> 
> Deciding whether to defer based on cpu number feels a bit awkward.
> 
> 
> -boris
> 

I did some tests and I do not think this works well. I prefer to delay the
initialization only for VCPU >= 32.

This is the syslog if we always delay xen_hvm_init_time_ops(), regardless
whether VCPU >= 32.

[    0.032372] Booting paravirtualized kernel on Xen HVM
[    0.032376] clocksource: refined-jiffies: mask: 0xffffffff max_cycles:
0xffffffff, max_idle_ns: 1910969940391419 ns
[    0.037683] setup_percpu: NR_CPUS:64 nr_cpumask_bits:64 nr_cpu_ids:64
nr_node_ids:2
[    0.041876] percpu: Embedded 49 pages/cpu s162968 r8192 d29544 u262144

--> There is a clock backwards from 0.041876 to 0.000010.

[    0.000010] Built 2 zonelists, mobility grouping on.  Total pages: 2015744
[    0.000012] Policy zone: Normal
[    0.000014] Kernel command line: BOOT_IMAGE=/boot/vmlinuz-5.15.0-rc6xen+
root=UUID=2a5975ab-a059-4697-9aee-7a53ddfeea21 ro text console=ttyS0,115200n8
console=tty1 crashkernel=512M-:192M


This is because the initial pv_sched_clock is native_sched_clock(), and it
switches to xen_sched_clock() in xen_hvm_init_time_ops(). Is it fine to always
have a clock backward for non-kdump kernel?

To avoid the clock backward, we may register a dummy clocksource which always
returns 0, before xen_hvm_init_time_ops(). I do not think this is reasonable.

Thank you very much!

Dongli Zhang


From xen-devel-bounces@lists.xenproject.org Mon Oct 25 06:30:11 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Oct 2021 06:30:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.215648.374974 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1metUd-00066B-Om; Mon, 25 Oct 2021 06:29:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 215648.374974; Mon, 25 Oct 2021 06:29:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1metUd-000664-Ku; Mon, 25 Oct 2021 06:29:59 +0000
Received: by outflank-mailman (input) for mailman id 215648;
 Mon, 25 Oct 2021 06:29:58 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1metUc-00065u-3u; Mon, 25 Oct 2021 06:29:58 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1metUb-0006T8-UK; Mon, 25 Oct 2021 06:29:57 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1metUb-0007E6-Fr; Mon, 25 Oct 2021 06:29:57 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1metUb-0005UY-FK; Mon, 25 Oct 2021 06:29:57 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=jorYryFuyfiEVTzXoS+gmhhpPtTpr/mDGG1YAC/cDzM=; b=G06/F9Pl+2LkCToX72pP3RqedU
	54sIfP9G25f9W18W06KZIJ6sXM3Z3k4vujxLu2ILlpNpodLiBoVRv88DU8+RgUT2VjzF0G/M4Br3Q
	qigiYoiuOCQNYICaIXyIWxMe/Cesw57SktpuZn1NBhRbjZVCQmynFkqjhkllQacI3pik=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165845-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 165845: regressions - FAIL
X-Osstest-Failures:
    qemu-mainline:build-i386:xen-build:fail:regression
    qemu-mainline:build-i386-xsm:xen-build:fail:regression
    qemu-mainline:build-armhf:xen-build:fail:regression
    qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    qemu-mainline:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-amd:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-pair:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-freebsd10-i386:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-freebsd10-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-coresched-i386-xl:build-check(1):blocked:nonblocking
    qemu-mainline:build-armhf-libvirt:build-check(1):blocked:nonblocking
    qemu-mainline:build-i386-libvirt:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-intel:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-shadow:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-vhd:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=c5b2f559814104f4145f8bc310f4d33c7ead8f49
X-Osstest-Versions-That:
    qemuu=50352cce138ef3b30c1cda28a4df68fff5da3202
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 25 Oct 2021 06:29:57 +0000

flight 165845 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165845/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-i386                    6 xen-build                fail REGR. vs. 165682
 build-i386-xsm                6 xen-build                fail REGR. vs. 165682
 build-armhf                   6 xen-build                fail REGR. vs. 165682

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 165834

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl           1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-credit2   1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-cubietruck  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-multivcpu  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-rtds      1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-vhd       1 build-check(1)               blocked  n/a
 test-amd64-i386-qemuu-rhel6hvm-amd  1 build-check(1)               blocked n/a
 test-amd64-i386-pair          1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-freebsd10-i386  1 build-check(1)               blocked  n/a
 test-amd64-i386-freebsd10-amd64  1 build-check(1)               blocked  n/a
 test-amd64-coresched-i386-xl  1 build-check(1)               blocked  n/a
 build-armhf-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-credit1   1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-arndale   1 build-check(1)               blocked  n/a
 test-amd64-i386-qemuu-rhel6hvm-intel  1 build-check(1)             blocked n/a
 test-amd64-i386-xl            1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-pvshim     1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-qemuu-debianhvm-amd64  1 build-check(1)         blocked n/a
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow  1 build-check(1)  blocked n/a
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm  1 build-check(1)      blocked n/a
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 1 build-check(1) blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a
 test-amd64-i386-xl-qemuu-win7-amd64  1 build-check(1)              blocked n/a
 test-amd64-i386-xl-qemuu-ws16-amd64  1 build-check(1)              blocked n/a
 test-amd64-i386-xl-shadow     1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-vhd        1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-xsm        1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165682
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165682
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165682
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 qemuu                c5b2f559814104f4145f8bc310f4d33c7ead8f49
baseline version:
 qemuu                50352cce138ef3b30c1cda28a4df68fff5da3202

Last test of basis   165682  2021-10-19 21:09:14 Z    5 days
Failing since        165694  2021-10-20 18:09:12 Z    4 days   11 attempts
Testing same since   165823  2021-10-24 00:36:48 Z    1 days    3 attempts

------------------------------------------------------------
People who touched revisions under test:
  Alistair Francis <alistair.francis@wdc.com>
  Andrew Jones <drjones@redhat.com>
  Ani Sinha <ani@anisinha.ca>
  BALATON Zoltan <balaton@eik.bme.hu>
  Bin Meng <bmeng.cn@gmail.com>
  Cédric Le Goater <clg@kaod.org>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  David Gibson <david@gibson.dropbear.id.au>
  David Hildenbrand <david@redhat.com>
  Eric Auger <eric.auger@redhat.com>
  Eugenio Pérez <eperezma@redhat.com>
  Frank Chang <frank.chang@sifive.com>
  Gavin Shan <gshan@redhat.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Greg Kurz <groug@kaod.org>
  Gustavo Romero <gromero@linux.ibm.com>
  Igor Mammedov <imammedo@redhat.com>
  Jason Wang <jasowang@redhat.com>
  John Wang <wangzhiqiang02@inspur.com>
  John Wang <wangzq.jn@gmail.com>
  Laurent Vivier <laurent@vivier.eu>
  Laurent Vivier <lvivier@redhat.com>
  Luc Michel <lmichel@kalray.eu>
  Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
  Matheus Ferst <matheus.ferst@eldorado.org.br>
  Mathieu Poirier <mathieu.poirier@linaro.org>
  Michael S. Tsirkin <mst@redhat.com>
  Mingwang Li <limingwang@huawei.com>
  Oğuz Ersen <oguzersen@protonmail.com>
  Philipp Tomsich <philipp.tomsich@vrull.eu>
  Philippe Mathieu-Daudé <f4bug@amsat.org>
  Philippe Mathieu-Daudé <philmd@redhat.com>
  Richard Henderson <richard.henderson@linaro.org>
  Shuuichirou Ishii <ishii.shuuichir@fujitsu.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Thomas Huth <thuth@redhat.com>
  Tong Ho <tong.ho@xilinx.com>
  Travis Geiselbrecht <travisg@gmail.com>
  Vincent Palatin <vpalatin@rivosinc.com>
  Xueming Li <xuemingl@nvidia.com>
  Yanan Wang <wangyanan55@huawei.com>
  Yifei Jiang <jiangyifei@huawei.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               fail    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          blocked 
 test-amd64-i386-xl                                           blocked 
 test-amd64-coresched-i386-xl                                 blocked 
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 fail    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  blocked 
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       blocked 
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           blocked 
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     blocked 
 test-amd64-i386-freebsd10-amd64                              blocked 
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          blocked 
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          blocked 
 test-armhf-armhf-xl-arndale                                  blocked 
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  blocked 
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  blocked 
 test-armhf-armhf-xl-cubietruck                               blocked 
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         blocked 
 test-amd64-i386-freebsd10-i386                               blocked 
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         blocked 
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                blocked 
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         blocked 
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 blocked 
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    blocked 
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     blocked 
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              blocked 
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    blocked 
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      blocked 
 test-amd64-i386-xl-vhd                                       blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 3631 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Oct 25 07:45:25 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Oct 2021 07:45:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.215658.374987 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1meufQ-00059J-Db; Mon, 25 Oct 2021 07:45:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 215658.374987; Mon, 25 Oct 2021 07:45:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1meufQ-00059C-AE; Mon, 25 Oct 2021 07:45:12 +0000
Received: by outflank-mailman (input) for mailman id 215658;
 Mon, 25 Oct 2021 07:45:11 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=DEXr=PN=bombadil.srs.infradead.org=BATV+8af5701d0ad407599ae9+6637+infradead.org+dwmw2@srs-us1.protection.inumbo.net>)
 id 1meufO-000596-QU
 for xen-devel@lists.xenproject.org; Mon, 25 Oct 2021 07:45:11 +0000
Received: from bombadil.infradead.org (unknown [2607:7c80:54:e::133])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 310a243f-4756-4570-8785-1f510d788d70;
 Mon, 25 Oct 2021 07:45:07 +0000 (UTC)
Received: from [2001:8b0:10b:1::3ae] (helo=u3832b3a9db3152.ant.amazon.com)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1meuf9-00Ffu1-Nw; Mon, 25 Oct 2021 07:44:56 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 310a243f-4756-4570-8785-1f510d788d70
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=MIME-Version:Content-Type:References:
	In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Sender:Reply-To:
	Content-Transfer-Encoding:Content-ID:Content-Description;
	bh=cMErPvIIdoq9Hh45uvzwiEdUS8YyZBomCWfCve06I84=; b=tUIi9Nawh/RVYzEJIscyXwQL5b
	FtuZabYq8+HkEKG84mpDRNhpC401CfLpInQ351rqP3lgIRGiwZXQwXM7Fnisn76KGr576njSYzM44
	1Xw7ync5qzfUDbHiSem8w/63mGVvlsFB2/P6ZNthS5yWB7jzsFbD7W+ue5KqyuMP2dFpKbVhfwjAy
	k0agRfkGr1B60xJ2nhZ4bXEvNJZ9hvfYawFl23IyLTXsJB7akjQKuSrdZagLowfjreRaEVXvookMy
	bOliOi6d7FJdedg019nQ3ggrrOg9MRoSL/rwhxMuAk52kfYEPz4OHO2PdjIlOVul9OxeBjgKL2bRI
	LmCmcQYQ==;
Message-ID: <eb38c1d2707d03bf675d7b15f014cbe741de0998.camel@infradead.org>
Subject: Re: [PATCH] PCI/MSI: Fix masking MSI/MSI-X on Xen PV
From: David Woodhouse <dwmw2@infradead.org>
To: Jason Andryuk <jandryuk@gmail.com>, josef@oderland.se
Cc: boris.ostrovsky@oracle.com, helgaas@kernel.org, jgross@suse.com, 
	linux-pci@vger.kernel.org, maz@kernel.org, tglx@linutronix.de, 
	xen-devel@lists.xenproject.org
Date: Mon, 25 Oct 2021 08:44:52 +0100
In-Reply-To: <20211025012503.33172-1-jandryuk@gmail.com>
References: <90277228-cf14-0cfa-c95e-d42e7d533353@oderland.se>
	 <20211025012503.33172-1-jandryuk@gmail.com>
Content-Type: multipart/signed; micalg="sha-256"; protocol="application/pkcs7-signature";
	boundary="=-reJCSKIzwe5f3rgzqJN/"
User-Agent: Evolution 3.36.5-0ubuntu1 
MIME-Version: 1.0
X-SRS-Rewrite: SMTP reverse-path rewritten from <dwmw2@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html


--=-reJCSKIzwe5f3rgzqJN/
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Sun, 2021-10-24 at 21:25 -0400, Jason Andryuk wrote:
> commit fcacdfbef5a1 ("PCI/MSI: Provide a new set of mask and unmask
> functions") introduce functions pci_msi_update_mask() and
> pci_msix_write_vector_ctrl() that is missing checks for
> pci_msi_ignore_mask that exists in commit 446a98b19fd6 ("PCI/MSI: Use
> new mask/unmask functions").  The checks are in place at the high level
> __pci_msi_mask_desc()/__pci_msi_unmask_desc(), but some functions call
> directly to the helpers.
>=20
> Push the pci_msi_ignore_mask check down to the functions that make
> the actual writes.  This keeps the logic local to the writes that need
> to be bypassed.
>=20
> With Xen PV, the hypervisor is responsible for masking and unmasking the
> interrupts, which pci_msi_ignore_mask is used to indicate.

This isn't just for Xen PV; Xen HVM guests let Xen unmask the MSI for
them too.

--=-reJCSKIzwe5f3rgzqJN/
Content-Type: application/pkcs7-signature; name="smime.p7s"
Content-Disposition: attachment; filename="smime.p7s"
Content-Transfer-Encoding: base64

MIAGCSqGSIb3DQEHAqCAMIACAQExDzANBglghkgBZQMEAgEFADCABgkqhkiG9w0BBwEAAKCCECow
ggUcMIIEBKADAgECAhEA4rtJSHkq7AnpxKUY8ZlYZjANBgkqhkiG9w0BAQsFADCBlzELMAkGA1UE
BhMCR0IxGzAZBgNVBAgTEkdyZWF0ZXIgTWFuY2hlc3RlcjEQMA4GA1UEBxMHU2FsZm9yZDEaMBgG
A1UEChMRQ09NT0RPIENBIExpbWl0ZWQxPTA7BgNVBAMTNENPTU9ETyBSU0EgQ2xpZW50IEF1dGhl
bnRpY2F0aW9uIGFuZCBTZWN1cmUgRW1haWwgQ0EwHhcNMTkwMTAyMDAwMDAwWhcNMjIwMTAxMjM1
OTU5WjAkMSIwIAYJKoZIhvcNAQkBFhNkd213MkBpbmZyYWRlYWQub3JnMIIBIjANBgkqhkiG9w0B
AQEFAAOCAQ8AMIIBCgKCAQEAsv3wObLTCbUA7GJqKj9vHGf+Fa+tpkO+ZRVve9EpNsMsfXhvFpb8
RgL8vD+L133wK6csYoDU7zKiAo92FMUWaY1Hy6HqvVr9oevfTV3xhB5rQO1RHJoAfkvhy+wpjo7Q
cXuzkOpibq2YurVStHAiGqAOMGMXhcVGqPuGhcVcVzVUjsvEzAV9Po9K2rpZ52FE4rDkpDK1pBK+
uOAyOkgIg/cD8Kugav5tyapydeWMZRJQH1vMQ6OVT24CyAn2yXm2NgTQMS1mpzStP2ioPtTnszIQ
Ih7ASVzhV6csHb8Yrkx8mgllOyrt9Y2kWRRJFm/FPRNEurOeNV6lnYAXOymVJwIDAQABo4IB0zCC
Ac8wHwYDVR0jBBgwFoAUgq9sjPjF/pZhfOgfPStxSF7Ei8AwHQYDVR0OBBYEFLfuNf820LvaT4AK
xrGK3EKx1DE7MA4GA1UdDwEB/wQEAwIFoDAMBgNVHRMBAf8EAjAAMB0GA1UdJQQWMBQGCCsGAQUF
BwMEBggrBgEFBQcDAjBGBgNVHSAEPzA9MDsGDCsGAQQBsjEBAgEDBTArMCkGCCsGAQUFBwIBFh1o
dHRwczovL3NlY3VyZS5jb21vZG8ubmV0L0NQUzBaBgNVHR8EUzBRME+gTaBLhklodHRwOi8vY3Js
LmNvbW9kb2NhLmNvbS9DT01PRE9SU0FDbGllbnRBdXRoZW50aWNhdGlvbmFuZFNlY3VyZUVtYWls
Q0EuY3JsMIGLBggrBgEFBQcBAQR/MH0wVQYIKwYBBQUHMAKGSWh0dHA6Ly9jcnQuY29tb2RvY2Eu
Y29tL0NPTU9ET1JTQUNsaWVudEF1dGhlbnRpY2F0aW9uYW5kU2VjdXJlRW1haWxDQS5jcnQwJAYI
KwYBBQUHMAGGGGh0dHA6Ly9vY3NwLmNvbW9kb2NhLmNvbTAeBgNVHREEFzAVgRNkd213MkBpbmZy
YWRlYWQub3JnMA0GCSqGSIb3DQEBCwUAA4IBAQALbSykFusvvVkSIWttcEeifOGGKs7Wx2f5f45b
nv2ghcxK5URjUvCnJhg+soxOMoQLG6+nbhzzb2rLTdRVGbvjZH0fOOzq0LShq0EXsqnJbbuwJhK+
PnBtqX5O23PMHutP1l88AtVN+Rb72oSvnD+dK6708JqqUx2MAFLMevrhJRXLjKb2Mm+/8XBpEw+B
7DisN4TMlLB/d55WnT9UPNHmQ+3KFL7QrTO8hYExkU849g58Dn3Nw3oCbMUgny81ocrLlB2Z5fFG
Qu1AdNiBA+kg/UxzyJZpFbKfCITd5yX49bOriL692aMVDyqUvh8fP+T99PqorH4cIJP6OxSTdxKM
MIIFHDCCBASgAwIBAgIRAOK7SUh5KuwJ6cSlGPGZWGYwDQYJKoZIhvcNAQELBQAwgZcxCzAJBgNV
BAYTAkdCMRswGQYDVQQIExJHcmVhdGVyIE1hbmNoZXN0ZXIxEDAOBgNVBAcTB1NhbGZvcmQxGjAY
BgNVBAoTEUNPTU9ETyBDQSBMaW1pdGVkMT0wOwYDVQQDEzRDT01PRE8gUlNBIENsaWVudCBBdXRo
ZW50aWNhdGlvbiBhbmQgU2VjdXJlIEVtYWlsIENBMB4XDTE5MDEwMjAwMDAwMFoXDTIyMDEwMTIz
NTk1OVowJDEiMCAGCSqGSIb3DQEJARYTZHdtdzJAaW5mcmFkZWFkLm9yZzCCASIwDQYJKoZIhvcN
AQEBBQADggEPADCCAQoCggEBALL98Dmy0wm1AOxiaio/bxxn/hWvraZDvmUVb3vRKTbDLH14bxaW
/EYC/Lw/i9d98CunLGKA1O8yogKPdhTFFmmNR8uh6r1a/aHr301d8YQea0DtURyaAH5L4cvsKY6O
0HF7s5DqYm6tmLq1UrRwIhqgDjBjF4XFRqj7hoXFXFc1VI7LxMwFfT6PStq6WedhROKw5KQytaQS
vrjgMjpICIP3A/CroGr+bcmqcnXljGUSUB9bzEOjlU9uAsgJ9sl5tjYE0DEtZqc0rT9oqD7U57My
ECIewElc4VenLB2/GK5MfJoJZTsq7fWNpFkUSRZvxT0TRLqznjVepZ2AFzsplScCAwEAAaOCAdMw
ggHPMB8GA1UdIwQYMBaAFIKvbIz4xf6WYXzoHz0rcUhexIvAMB0GA1UdDgQWBBS37jX/NtC72k+A
CsaxitxCsdQxOzAOBgNVHQ8BAf8EBAMCBaAwDAYDVR0TAQH/BAIwADAdBgNVHSUEFjAUBggrBgEF
BQcDBAYIKwYBBQUHAwIwRgYDVR0gBD8wPTA7BgwrBgEEAbIxAQIBAwUwKzApBggrBgEFBQcCARYd
aHR0cHM6Ly9zZWN1cmUuY29tb2RvLm5ldC9DUFMwWgYDVR0fBFMwUTBPoE2gS4ZJaHR0cDovL2Ny
bC5jb21vZG9jYS5jb20vQ09NT0RPUlNBQ2xpZW50QXV0aGVudGljYXRpb25hbmRTZWN1cmVFbWFp
bENBLmNybDCBiwYIKwYBBQUHAQEEfzB9MFUGCCsGAQUFBzAChklodHRwOi8vY3J0LmNvbW9kb2Nh
LmNvbS9DT01PRE9SU0FDbGllbnRBdXRoZW50aWNhdGlvbmFuZFNlY3VyZUVtYWlsQ0EuY3J0MCQG
CCsGAQUFBzABhhhodHRwOi8vb2NzcC5jb21vZG9jYS5jb20wHgYDVR0RBBcwFYETZHdtdzJAaW5m
cmFkZWFkLm9yZzANBgkqhkiG9w0BAQsFAAOCAQEAC20spBbrL71ZEiFrbXBHonzhhirO1sdn+X+O
W579oIXMSuVEY1LwpyYYPrKMTjKECxuvp24c829qy03UVRm742R9Hzjs6tC0oatBF7KpyW27sCYS
vj5wbal+TttzzB7rT9ZfPALVTfkW+9qEr5w/nSuu9PCaqlMdjABSzHr64SUVy4ym9jJvv/FwaRMP
gew4rDeEzJSwf3eeVp0/VDzR5kPtyhS+0K0zvIWBMZFPOPYOfA59zcN6AmzFIJ8vNaHKy5QdmeXx
RkLtQHTYgQPpIP1Mc8iWaRWynwiE3ecl+PWzq4i+vdmjFQ8qlL4fHz/k/fT6qKx+HCCT+jsUk3cS
jDCCBeYwggPOoAMCAQICEGqb4Tg7/ytrnwHV2binUlYwDQYJKoZIhvcNAQEMBQAwgYUxCzAJBgNV
BAYTAkdCMRswGQYDVQQIExJHcmVhdGVyIE1hbmNoZXN0ZXIxEDAOBgNVBAcTB1NhbGZvcmQxGjAY
BgNVBAoTEUNPTU9ETyBDQSBMaW1pdGVkMSswKQYDVQQDEyJDT01PRE8gUlNBIENlcnRpZmljYXRp
b24gQXV0aG9yaXR5MB4XDTEzMDExMDAwMDAwMFoXDTI4MDEwOTIzNTk1OVowgZcxCzAJBgNVBAYT
AkdCMRswGQYDVQQIExJHcmVhdGVyIE1hbmNoZXN0ZXIxEDAOBgNVBAcTB1NhbGZvcmQxGjAYBgNV
BAoTEUNPTU9ETyBDQSBMaW1pdGVkMT0wOwYDVQQDEzRDT01PRE8gUlNBIENsaWVudCBBdXRoZW50
aWNhdGlvbiBhbmQgU2VjdXJlIEVtYWlsIENBMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKC
AQEAvrOeV6wodnVAFsc4A5jTxhh2IVDzJXkLTLWg0X06WD6cpzEup/Y0dtmEatrQPTRI5Or1u6zf
+bGBSyD9aH95dDSmeny1nxdlYCeXIoymMv6pQHJGNcIDpFDIMypVpVSRsivlJTRENf+RKwrB6vcf
WlP8dSsE3Rfywq09N0ZfxcBa39V0wsGtkGWC+eQKiz4pBZYKjrc5NOpG9qrxpZxyb4o4yNNwTqza
aPpGRqXB7IMjtf7tTmU2jqPMLxFNe1VXj9XB1rHvbRikw8lBoNoSWY66nJN/VCJv5ym6Q0mdCbDK
CMPybTjoNCQuelc0IAaO4nLUXk0BOSxSxt8kCvsUtQIDAQABo4IBPDCCATgwHwYDVR0jBBgwFoAU
u69+Aj36pvE8hI6t7jiY7NkyMtQwHQYDVR0OBBYEFIKvbIz4xf6WYXzoHz0rcUhexIvAMA4GA1Ud
DwEB/wQEAwIBhjASBgNVHRMBAf8ECDAGAQH/AgEAMBEGA1UdIAQKMAgwBgYEVR0gADBMBgNVHR8E
RTBDMEGgP6A9hjtodHRwOi8vY3JsLmNvbW9kb2NhLmNvbS9DT01PRE9SU0FDZXJ0aWZpY2F0aW9u
QXV0aG9yaXR5LmNybDBxBggrBgEFBQcBAQRlMGMwOwYIKwYBBQUHMAKGL2h0dHA6Ly9jcnQuY29t
b2RvY2EuY29tL0NPTU9ET1JTQUFkZFRydXN0Q0EuY3J0MCQGCCsGAQUFBzABhhhodHRwOi8vb2Nz
cC5jb21vZG9jYS5jb20wDQYJKoZIhvcNAQEMBQADggIBAHhcsoEoNE887l9Wzp+XVuyPomsX9vP2
SQgG1NgvNc3fQP7TcePo7EIMERoh42awGGsma65u/ITse2hKZHzT0CBxhuhb6txM1n/y78e/4ZOs
0j8CGpfb+SJA3GaBQ+394k+z3ZByWPQedXLL1OdK8aRINTsjk/H5Ns77zwbjOKkDamxlpZ4TKSDM
KVmU/PUWNMKSTvtlenlxBhh7ETrN543j/Q6qqgCWgWuMAXijnRglp9fyadqGOncjZjaaSOGTTFB+
E2pvOUtY+hPebuPtTbq7vODqzCM6ryEhNhzf+enm0zlpXK7q332nXttNtjv7VFNYG+I31gnMrwfH
M5tdhYF/8v5UY5g2xANPECTQdu9vWPoqNSGDt87b3gXb1AiGGaI06vzgkejL580ul+9hz9D0S0U4
jkhJiA7EuTecP/CFtR72uYRBcunwwH3fciPjviDDAI9SnC/2aPY8ydehzuZutLbZdRJ5PDEJM/1t
yZR2niOYihZ+FCbtf3D9mB12D4ln9icgc7CwaxpNSCPt8i/GqK2HsOgkL3VYnwtx7cJUmpvVdZ4o
gnzgXtgtdk3ShrtOS1iAN2ZBXFiRmjVzmehoMof06r1xub+85hFQzVxZx5/bRaTKTlL8YXLI8nAb
R9HWdFqzcOoB/hxfEyIQpx9/s81rgzdEZOofSlZHynoSMYIDyjCCA8YCAQEwga0wgZcxCzAJBgNV
BAYTAkdCMRswGQYDVQQIExJHcmVhdGVyIE1hbmNoZXN0ZXIxEDAOBgNVBAcTB1NhbGZvcmQxGjAY
BgNVBAoTEUNPTU9ETyBDQSBMaW1pdGVkMT0wOwYDVQQDEzRDT01PRE8gUlNBIENsaWVudCBBdXRo
ZW50aWNhdGlvbiBhbmQgU2VjdXJlIEVtYWlsIENBAhEA4rtJSHkq7AnpxKUY8ZlYZjANBglghkgB
ZQMEAgEFAKCCAe0wGAYJKoZIhvcNAQkDMQsGCSqGSIb3DQEHATAcBgkqhkiG9w0BCQUxDxcNMjEx
MDI1MDc0NDUyWjAvBgkqhkiG9w0BCQQxIgQgca4o14m6XBavZ3qJ50ol/Ll3MyklfoenTJiQAU9b
WPMwgb4GCSsGAQQBgjcQBDGBsDCBrTCBlzELMAkGA1UEBhMCR0IxGzAZBgNVBAgTEkdyZWF0ZXIg
TWFuY2hlc3RlcjEQMA4GA1UEBxMHU2FsZm9yZDEaMBgGA1UEChMRQ09NT0RPIENBIExpbWl0ZWQx
PTA7BgNVBAMTNENPTU9ETyBSU0EgQ2xpZW50IEF1dGhlbnRpY2F0aW9uIGFuZCBTZWN1cmUgRW1h
aWwgQ0ECEQDiu0lIeSrsCenEpRjxmVhmMIHABgsqhkiG9w0BCRACCzGBsKCBrTCBlzELMAkGA1UE
BhMCR0IxGzAZBgNVBAgTEkdyZWF0ZXIgTWFuY2hlc3RlcjEQMA4GA1UEBxMHU2FsZm9yZDEaMBgG
A1UEChMRQ09NT0RPIENBIExpbWl0ZWQxPTA7BgNVBAMTNENPTU9ETyBSU0EgQ2xpZW50IEF1dGhl
bnRpY2F0aW9uIGFuZCBTZWN1cmUgRW1haWwgQ0ECEQDiu0lIeSrsCenEpRjxmVhmMA0GCSqGSIb3
DQEBAQUABIIBAGDoFNCzvvAwkjGf5ghdWzpiX/HlCH9zMg+pfRj3QNwpO5/k5P8BhOy4yo2KVcb8
4miD6vRVy6INblFUSPSTiEqC0eR4ibbveYpB2Ol5mDe49eCB7wrKZZbEE/+ilH3DXn0L/OvBY2mT
Es8Gs9r9Ux6Qjmz/wg2I2w8ZF8z1p2n7w3keLs/O02LSLjCPNeg79/SVRBk/cx46+GTF5WoaJzOg
i/BZw7FdqdnpXqDL7TfOQQ6EH33sMZlMRZrbnMxlAMyR/CTXOuYCKJExo0jvFso2uqIJ/xqWpBGZ
q/dsA0UGkLoouxEcWOXtO27OAgroqShptfKBjFFdw/wDTvuvuEoAAAAAAAA=


--=-reJCSKIzwe5f3rgzqJN/--



From xen-devel-bounces@lists.xenproject.org Mon Oct 25 08:42:09 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Oct 2021 08:42:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.215669.374998 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mevYP-0002uc-QI; Mon, 25 Oct 2021 08:42:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 215669.374998; Mon, 25 Oct 2021 08:42:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mevYP-0002uV-ND; Mon, 25 Oct 2021 08:42:01 +0000
Received: by outflank-mailman (input) for mailman id 215669;
 Mon, 25 Oct 2021 08:42:00 +0000
Received: from [172.99.69.81] (helo=us1-rack-iad1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=G2Ub=PN=citrix.com=roger.pau@srs-us1.protection.inumbo.net>)
 id 1mevYO-0002uP-9f
 for xen-devel@lists.xenproject.org; Mon, 25 Oct 2021 08:42:00 +0000
Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 29850afa-d715-40db-a267-211ca8ad57b3;
 Mon, 25 Oct 2021 08:41:48 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 29850afa-d715-40db-a267-211ca8ad57b3
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1635151308;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=68+mFZW0uzDPX9wO/4RtE3gbw3KtdWkFvpoDpDAj2JE=;
  b=Wyf6uUFT7c/GVQqLkrG0f5GEXNnfV7prVUEJAr30mfWdLWkwtHUOjyiL
   rZBQ5mvWiY+T2G6x5FXEibJTUM/lvrdbWyavPD/2omqj6Eqox9HTHWqO6
   IcRg/izV7xCBc+GcP+bNCsGpPGi7MXnJ6WpaBIf1JZwyzom0zc7eIOFbh
   g=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: gzYzcB6pF+yuqzlrao5ZzTfOfky618Ec308c1N7OYuEMsCPC/ezL82AxSYQj201pCGyCVPKxN0
 w8kHVhX4GLCYnTRND99NXtRUHa2M8kuWvU4+B0ETs2Hx70dOvN4chIvC7hXdEK8abzhYpePYR/
 JQfHEpGrOsbKVzb7dJ3gOg0/ftRbgrYAI9foHPU5iIMoK5W/BxvPf9GMbfTU8d+eCZyw4oZAQg
 n53hvC3kzDOrY/QLXmgFVAEOTRgB29QUmvej+jtqRlT73RTRNKMQmuxhy5VuU9kQcTEasm0+nC
 7MvIUJqThPBO8mCUbpNKAPdK
X-SBRS: 5.1
X-MesageID: 57879429
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:vAWuKKp+n2Cz9xlImqrQ2Pw1IO1eBmL6YhIvgKrLsJaIsI4StFCzt
 garIBnQaf+PNDD1coxxOY2w8U4AuZ6Ay9YwSlBlry5nRitDoJuZCYyVIHmrMnLJJKUvbq7GA
 +byyDXkBJppJpMJjk71atANlZT4vE2xbuKU5NTsY0idfic5Dnd+4f5fs7Rh2Ncx2YLlW1nlV
 e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL
 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9
 DlCnbu1ayYAI/3toeU6UBtFLCVlMLxX3bCSdBBTseTLp6HHW37lwvEoB0AqJ4wIvO1wBAmi9
 9RBdmpLNErawbvrnvTrEYGAhex6RCXvFJkYtXx6iynQEN4tQIzZQrWM7thdtNs1rp0RTamPO
 5BIAdZpRBntSjhsM3knM40nwdiDhmDPdAZU903A8MLb5ECMlVcsgdABKuH9ZdiiVchT2EGCq
 Qru523kBjkKOdrZziCKmlqujOLSmSLwWKoJCaa1sPVthTW71mEVTREbS1a/if24kVKlHcJSL
 VQO/SgjprR081akJuQRRDXh/iTC5ERFHYMNTatqs2lh15Y4/S6+A0olZyMRSeUnk8w0WAMuz
 VKYjvbmUGkHXKKudVqR8bKdrDWXMCcTLHMfaSJscTbp8+UPs6lo0UqRFocL/Lqdy4SvQ2mpk
 m/iQD0W3u1L1aY2O7OHEUcrat5GjqPCSRIp/U3pV2ah4xIRiGWNNtHwtwazARqtKu+kori9U
 JosxpD2AAMmV8jleMmxrAIlR+nB2hp9GGeA6WOD5rF4n9hXx1atfJpL/BZ1L1pzP8APdFfBO
 RGI5FoJvMUCZCPwPcebhr5d7exwncAM8vy+DpjpgidmOMAtJGdrAgk3PSZ8IFwBYGBzyPpia
 P93gO6nDGoACLQP8dZFb7x17FPf/QhnnTm7bcmil3yPiOPCDFbIGeZtGAbfNYgRsfLbyDg5B
 v4CbqNmPT0EC7agCsQWmKZORW03wY8TXMGm9ZcPLbXdc2KL2ggJUpfs/F/oQKQ894x9nebU5
 HCtHEhezVv0n3rcLguWLHtkbdvSsVxX9xrX5AQgYgSl3WYNe4Gq4PtNfpc7Z+B/pudi0eR1X
 78OfMDZWqZDTTHO+jI8a5jhrdM9KET31FzWZyf1MiIie5NARhDS/oO2dAXY6yRTXDG8stEzo
 uP821qDE4YDXQlrEO3fdOmrkwGqpXEYle8rBxnIL9BfdV/C6o9vLyCt3PY7L9tVcUfIxyeA1
 hbQChAd/LGfr4gw+djPpKaFs4b2TLcuQhsERzHWtO/kOzPb82yvxZ57fNyJJT2NBnnp/KiCZ
 PlOy62uOvMwg1sX4ZF3FKxmzPxi6oK39aNa1AltAF7Cc0+vVuF7OnCD0MRC6v9Ny7tetVfkU
 06D4IAHa7CAOcejG18NPgs1KO+E0KhMyDXV6P00JmT85TN2o+XbARkDYUHUhXwPNqZxPaMk3
 fwl6Zwf5AGIgxY3NsqL03JP/GOWI31cC6gqu/n22mMwZtbHHr2aXaHhNw==
IronPort-HdrOrdr: A9a23:bcdF0K7orInsdGXIjwPXwVKBI+orL9Y04lQ7vn2ZFiY7TiXIra
 yTdaoguCMc6AxxZJkh8erwX5VoZUmsj6KdhrNhQItKPTOWw1dASbsN0WKM+UyDJ8STzJ856U
 4kSdkDNDSSNykKsS+Z2njALz9I+rDum8rJ9ISuv0uFDzsaE52Ihz0JdDpzeXcGIjWua6BJcK
 Z1saF81kWdkDksH46GL0hAe9KGi8zAlZrgbxJDLxk76DOWhTftzLLhCRCX0joXTjsKmN4ZgC
 T4uj28wp/mn+Cwyxfa2WOWx5NKmOH5wt8GIMCXkMAaJhjllw7tToV8XL+puiwzvYiUmRsXue
 iJhy1lE9V46nvXcG3wiRzx2zP42DJr0HPmwU/wuwqrneXJABYBT+ZRj4NQdRXUr2A6ustn7a
 5N12WF87JKEBLphk3Glpn1fiAvsnDxjWspkOYVgXAae5AZcqVtoYsW+14QOIscHRj99JssHI
 BVfY/hDc5tABCnhk3izytSKITGZAV3Iv7GeDlMhiWt6UkXoJgjpHFogPD2nR87heQAotd/lq
 P5259T5cNzp/ktHNVA7dc6MLiK41P2MGfx2UKpUBza/fI8SjnwQ6Ce2sRA2AjtQu1P8KcP
X-IronPort-AV: E=Sophos;i="5.87,179,1631592000"; 
   d="scan'208";a="57879429"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=hc3RHe8qm9+5FwwW3xwF3YX9Q5mKntb0loGyiGC74Pj9z7NHUB35VU+SiJiZ1geyiOqYc+JkpiPHLgJguZuMLY0VVkWoKALQmWpAN7HPrVP50EF/jj9Y43DB2UgpEey8HuybeB5K1PnMF7dSdUbp7xtlvEaVbQJ2fxtlUnY99dVCVOxOPvFLSZml1HaCq+LVLaMax0sn3rB3GPQc5PgCDciY66T8ri1WttQbm81qWTbUeltN9rWcRbsxx+/0UF6oDYR65sN5Quplc67h8AIx2YJrMXyeNMWOuxecNT4Bdbm9j/fk5Oc2e1koqgM4IF6i7PIjFseDzpohSkMsH2zVvQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=XcoCoCwpF0C5d/Kg1OE+tUYQhaSjK7jInv6zyutyTPs=;
 b=AfWVE8qGWU2Suod2z59nZ/xzqT8Su01DGgDaqwbDeZIaIUaGSXJw1EpJkdkCNFtS/4xecEWazDQlngIUCpMq1gNGQ+wZyi0i+hXjjnvYoIadDzuRxX0xLNVOHV10WW1qgxsq9O+8fOXUgHSoF0x4m5PDzuMis8tp/l+qzTNCLl/8EpaJy0IzYt+y26t+67XEztPRJ+NrkktH0xXd/2rwPUQbAkCXjJLqrdBXD2xXPI1hZAUQSufkqDdiE4xIBu1zzNJ1pFarVND+dbY/+wPE4EoN0YtTpfZyB15qwkbYxp4kghG4Oa+6PXGLUX+cPpCpDeEi55Fg5GT+ienWti7gVA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=XcoCoCwpF0C5d/Kg1OE+tUYQhaSjK7jInv6zyutyTPs=;
 b=kpD3aOFY5+UwwPwaPFyj1Vb153K0c7Ec6Bld3Bx0hVI3uoA7UKiR140B0ImmxGlkn9WN8UbXnco/MfFpd37uZkXfM1OPN79d7Cw75oWMJBzLf6ozYelZvpT3vHyIzzFBh2xZziA3DiVBIfV9CRIuZclTUiUYrjrSE+axO6WU9uA=
Date: Mon, 25 Oct 2021 10:41:40 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Andrew
 Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>, Paul Durrant
	<paul@xen.org>
Subject: Re: [PATCH v2 2/3] x86/APIC: avoid iommu_supports_x2apic() on error
 path
Message-ID: <YXZtxMr+MrbDcmhC@MacBook-Air-de-Roger.local>
References: <09137aa2-649f-08fb-ba68-75f8eb16fc63@suse.com>
 <35f9099f-1111-1a66-83eb-bc5a3887f9aa@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <35f9099f-1111-1a66-83eb-bc5a3887f9aa@suse.com>
X-ClientProxiedBy: MR2P264CA0066.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:500:31::30) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 4372d8a4-c67c-4354-4c47-08d997934703
X-MS-TrafficTypeDiagnostic: DM6PR03MB4538:
X-Microsoft-Antispam-PRVS: <DM6PR03MB4538582505FF7941D0AC5AEA8F839@DM6PR03MB4538.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:5516;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: ZBautpSB991bjDipLDqa/gGUhZMBKxg1Z52JoB5TYyXpI7wxwSquUoQ82SPoYnk1MuEK+muE8fEPFjFxRpGlIymC/di5z94U2Am+y1v6HyiUz1/w74lkElZMfQZ9VN1BnypuAyGM9mq2LYn1lvX/L/HUBYgTWX+naQESol805VroRN80VZOo1+6NBKsCWoO69uFiLV/Wkj7534dYyewCdmfQvUiu9En4Zn8LzdCuXS/FoGvfxnkgTKcydKHarOL29mPzd00bM7c6RTAEDjJ3lM6yh6Ao0RIuPHK/dDDmj+LEW52IjBZbZKK3LmX+tt3AnygnkdC0w+LzSbf3joNnupggHNAkJuzOSTRDJnzF/j1i4hKpx/PuJtcq1mwpOuj1bQA1QYHD6UW5aMjk2odelOoCZH57iS+eU6xxOGcGd1wdnOLelLft/rNZfFSx94hYrLDfYxByoP6+mT2gR7x6Zv5mryhepmFg55bfUVNzTD3MDJZ78oA9fI8xapSprUx0s/uqO4CjbkqZ3Buh5J4LHInzbPnFKExgI/LqSrBsbXh5Ucq6jZLDnVSKJcczVpNv7IFbcKdTvsWqh1VWBUVcaNQomUTG8vY2+8bkotF5uMDmJ3jV/fYdJcZeNzBZZoo6hVjwyp13v3N78piRrj6A91HkU7+XNmFAk+q65/1gcR6e6RuFpzaQ7TmZjwJR8FezMYc6Qdl6zm1A0cCybo3WcA==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(186003)(2906002)(38100700002)(4744005)(26005)(8676002)(6916009)(66476007)(86362001)(66946007)(6486002)(6666004)(8936002)(9686003)(5660300002)(6496006)(82960400001)(316002)(54906003)(4326008)(508600001)(956004)(66556008)(85182001)(67856001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WTQ3NlhSTDBXeEZ6M3p0QW0zQk4vQ2p5RjM3dmhSYy91MjZxTmkzWVd1U1NO?=
 =?utf-8?B?bXpQREU1UzU0VGNsSVF4MG9ZNDZmaER1amhneDhPMkhMcTcwditTb2JDSnlP?=
 =?utf-8?B?cit0WDhtVkpUYkg4bFhXa1A5dkFwUTUxQUtFSG5FRjJ2cFk5ZXJjd1M2d3FO?=
 =?utf-8?B?ZFlIbnllc05rZTVpU1pjcnhsazdhWTJwWXFva24rTk5nVnpWeU15NHZIN2ND?=
 =?utf-8?B?NXFBd1JYNFozYWg5MTBSUlFCYUFWTzJwa1Rmb3U2OWsvVEFsRGNEY2FjekdW?=
 =?utf-8?B?THdobWFDZUV4YWhzRUR5djYvWkV1eXV3cVRnaVEyUlQwK0x4czhYOTFMQnEz?=
 =?utf-8?B?QVZyelNnWVlmQ3BYTUVFYmNnSXlGOE5hT0NVNzNpV21qM0FUZHNiZnZMd2FV?=
 =?utf-8?B?RVF2aTJxb3VRQXlEZ0RJMHE5WjVWTis5R3FBTUhidGkvNWhBVHc5eTJFV0hO?=
 =?utf-8?B?Zm5YWDlETnFtbkpHMzlzaDI0cEF2L3hXTDlUWThqMUI2NUZnRXdVZzVkTVhS?=
 =?utf-8?B?eXlZSS9CYjAxeDFoelROODh6eXJHWmV4L25yd3hNTVZoemNqK2I4T3pMNklL?=
 =?utf-8?B?ODY5cFRUNDRjQitTaHRzQWdDSHdCTi8vMnp4N0lXQXdkN1FucWxKZzd5cTlR?=
 =?utf-8?B?SHc0R3JTaFJVVmdhaDByRlBXQ2NHQXZuUEVacHIyRTBtQXR2Rm92ZEpMNnd2?=
 =?utf-8?B?aGkzN1UwS0lpL1ZWNXlWeWhuNlR5SmVxaGtJYmhLRGp3b2dodTVFNVdFS21v?=
 =?utf-8?B?d3FSOGdTN2JYT01DaEZna2xxVDk1YytXdUVPVlFRa2ZkeTRzL0VWRi84b21z?=
 =?utf-8?B?WDRFZTFOTE0xdHdENE5tM1ZqaU1IUmdEamVKK0NBWjlyR09xTDVreW0vQlR6?=
 =?utf-8?B?bER3MTl4YVVIOUR3aW5VSEsyK3BkeWc0QkF5L3E5M3hwbEcwQ0lFVWxRa2V5?=
 =?utf-8?B?WHB4bXFjb0RvVHdxTnFlbVhJZU5RYzVtVWtLb2R2aktmNkRWTmI3NGJWK0Vp?=
 =?utf-8?B?OEZlanNIOWU5Tmx1cUxkdCsvdzZGbTB5ZllkUTlCd3VWaGk0QWVCVW1mM2dx?=
 =?utf-8?B?SWk0TS9uaVFPY0s4ckVsUTY2VWdYeDVmMEhINE5Oc1BuZWJSMXpKQm9PZWdO?=
 =?utf-8?B?Z3kyQ3RQdlBSUHN2TjRaR2tvWDU5bkdZYkZTQW5ocmFSMDdxaW9TZmlFaEVI?=
 =?utf-8?B?dW0zd3lwdzJYWFpJcE13WGM3Slo3clJvcGVEekJPUHVSVjdhNUNnR3A0dHQy?=
 =?utf-8?B?UDNZRkxka3RVMUZBeUlka25ENFNHbzI0L1NkVDd5TjlSOGNMUzhxYWRXejV5?=
 =?utf-8?B?Q09BamJEQklmL2JJMTdhbzlINXFjaDhneDlGQVFlNWVFNWo3Qk5jWGlHbTZ1?=
 =?utf-8?B?VXBORURMNmkzNjdkVmc4WVpKQnJsYVBGUFJ6V3ZpbTU3OXNXOGRhbUNCTHdL?=
 =?utf-8?B?RHJrMXM3NW8ydnZ6TXFTbkRUNDVmdTIvNUliOG1iRU1ENHE2NHlrcVNaZUpX?=
 =?utf-8?B?YnJnODduV254UE1SbjBwVUNmeEtKMlhVbWxzTkNta3d4RXpWZlZiT3RaWXVl?=
 =?utf-8?B?WFJLVk5uYkxTcnBocGs2cTNwZVg3bDBpZ2RPZFBIY0F3MFR6OXpFYzRZZklK?=
 =?utf-8?B?OE1wOEVpNUFjU0J3RTlmdkdXc2pBSlduQ29nU2h2WHZvRnhpN0wvenBhZ29o?=
 =?utf-8?B?VTV3ZE5JMkNadFZoa1R5bTJJSDBvUmw4WW5JOERVMzg2QVNMTmlhRDVySG1k?=
 =?utf-8?B?V1pBOTAxWVZlTTVkaVNDL3g2S2VwRE9pSXJBMnVaeFZuZCt2dlMwWU1XM2VC?=
 =?utf-8?B?dWVXRUp3emFwS3drQVNDelY0dDRnbFRIZVhTMDNnSjZvQnM3UkwvU3JaZUls?=
 =?utf-8?B?czVFenFSV1pjVGFyRnZxdEprTFl5Mk9IK2JBOGdjbTFFK3ZaMFFCR1lhbDNP?=
 =?utf-8?B?emp6WFU3OFFBSFprSU1iNHBsZjdBWWQxSC9JNGVuNEpTM0ZBM1pYcU1nNXJZ?=
 =?utf-8?B?U3RrUGNZWEdvcWZQbnZDUUhiWlNYTmNyd3ZTaGN3VWN1Tjd1YzNWbCtoZDBR?=
 =?utf-8?B?VnVYZjNtQUlsUXJuUE91VWxZaHFNQ2pnZUphc09FbEhWaXh2UkJCWXI4OEV2?=
 =?utf-8?B?NDhYK0ZmWWpaZCthaUY0U3I5MGYyTEMwUllvNVZ0V2tkRE9sYUxiNjJSU0xS?=
 =?utf-8?Q?xu9+PvcM0go7NC67QYX7o6U=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 4372d8a4-c67c-4354-4c47-08d997934703
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2021 08:41:45.8275
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: qc6O/nnaVT0c60Lrv86t4WLgQ/8B4jfNW37KOv56hi3WhaXuv17H6X3MDlI3VGCtQ3YvQQO5lQ4dNXsMD1wjkA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4538
X-OriginatorOrg: citrix.com

On Thu, Oct 21, 2021 at 11:58:37AM +0200, Jan Beulich wrote:
> The value it returns may change from true to false in case
> iommu_enable_x2apic() fails and, as a side effect, clears iommu_intremap
> (as can happen at least on AMD). Latch the return value from the first
> invocation to replace the second one.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Mon Oct 25 09:30:49 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Oct 2021 09:30:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.215678.375016 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mewJP-0007lf-Lq; Mon, 25 Oct 2021 09:30:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 215678.375016; Mon, 25 Oct 2021 09:30:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mewJP-0007lY-IV; Mon, 25 Oct 2021 09:30:35 +0000
Received: by outflank-mailman (input) for mailman id 215678;
 Mon, 25 Oct 2021 09:30:34 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=cRlh=PN=suse.com=jgross@srs-us1.protection.inumbo.net>)
 id 1mewJN-0007lS-Tj
 for xen-devel@lists.xenproject.org; Mon, 25 Oct 2021 09:30:33 +0000
Received: from smtp-out2.suse.de (unknown [195.135.220.29])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 2d62b5d0-1457-4fb0-b499-53ec4f4bc807;
 Mon, 25 Oct 2021 09:30:32 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 899A51FD34;
 Mon, 25 Oct 2021 09:30:31 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id DBF681377E;
 Mon, 25 Oct 2021 09:30:30 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id l0O2MjZ5dmHLTAAAMHmgww
 (envelope-from <jgross@suse.com>); Mon, 25 Oct 2021 09:30:30 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2d62b5d0-1457-4fb0-b499-53ec4f4bc807
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1635154231; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=KRGww6yZbI/Yt5jVmhMhFsKU1wRB0IaHQ8wTV+diPmc=;
	b=BUpWf7a6s/iFTUKqBZ0IABlQlxTbqRFhhvFbzSJW9eK5MeTIMPQv04R3Vs/9eSP8RQwZo6
	0P9Ys4O0nSz/xZc+CveKTXhCpBJGoRjxVS87pIhwU/fhwNbC2kdxUKw7Nix2ZsaE252nlg
	14bqeEgsyrlUQYpvTSd3WP5jEe2p84Q=
To: Andrew Cooper <andrew.cooper3@citrix.com>,
 xen-devel@lists.xenproject.org, linux-input@vger.kernel.org,
 linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
 linux-fbdev@vger.kernel.org
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
 Boris Ostrovsky <boris.ostrovsky@oracle.com>,
 Stefano Stabellini <sstabellini@kernel.org>
References: <20211022064800.14978-1-jgross@suse.com>
 <20211022064800.14978-2-jgross@suse.com>
 <fe397fd6-a80e-d3f9-08d2-4f72ec739c0b@citrix.com>
From: Juergen Gross <jgross@suse.com>
Subject: Re: [PATCH 1/5] xen: add "not_essential" flag to struct xenbus_driver
Message-ID: <06bf785a-c661-ce18-6e48-7077c5944890@suse.com>
Date: Mon, 25 Oct 2021 11:30:30 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <fe397fd6-a80e-d3f9-08d2-4f72ec739c0b@citrix.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="osso5FxvKknFWuti2qByayI8n0rKWIOdo"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--osso5FxvKknFWuti2qByayI8n0rKWIOdo
Content-Type: multipart/mixed; boundary="UqKrfN4EOpH1zBdeQbsH4TMElHBbnARpK";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>,
 xen-devel@lists.xenproject.org, linux-input@vger.kernel.org,
 linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
 linux-fbdev@vger.kernel.org
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
 Boris Ostrovsky <boris.ostrovsky@oracle.com>,
 Stefano Stabellini <sstabellini@kernel.org>
Message-ID: <06bf785a-c661-ce18-6e48-7077c5944890@suse.com>
Subject: Re: [PATCH 1/5] xen: add "not_essential" flag to struct xenbus_driver
References: <20211022064800.14978-1-jgross@suse.com>
 <20211022064800.14978-2-jgross@suse.com>
 <fe397fd6-a80e-d3f9-08d2-4f72ec739c0b@citrix.com>
In-Reply-To: <fe397fd6-a80e-d3f9-08d2-4f72ec739c0b@citrix.com>

--UqKrfN4EOpH1zBdeQbsH4TMElHBbnARpK
Content-Type: multipart/mixed;
 boundary="------------C02A3EE7C04771EB3B004689"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------C02A3EE7C04771EB3B004689
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 22.10.21 11:28, Andrew Cooper wrote:
> On 22/10/2021 07:47, Juergen Gross wrote:
>> When booting the xenbus driver will wait for PV devices to have
>> connected to their backends before continuing. The timeout is differen=
t
>> between essential and non-essential devices.
>>
>> Non-essential devices are identified by their nodenames directly in th=
e
>> xenbus driver, which requires to update this list in case a new device=

>> type being non-essential is added (this was missed for several types
>> in the past).
>>
>> In order to avoid this problem, add a "not_essential" flag to struct
>> xenbus_driver which can be set to "true" by the respective frontend.
>>
>> Set this flag for the frontends currently regarded to be not essential=

>> (vkbs and vfb) and use it for testing in the xenbus driver.
>>
>> Signed-off-by: Juergen Gross <jgross@suse.com>
>=20
> Wouldn't it be better to annotate essential?=C2=A0 That way, when new m=
isc
> drivers come along, they don't by default block boot.

It isn't as if new drivers would "block boot". Normally the short
timeout for all drivers of 30 seconds is more than enough for all of
them.

I'm a little bit hesitant to have a kind of "white listing" essential
drivers, as there might be different views which drivers should have
that flag. Doing this the other way round is easier: in case of
disagreement such a patch just wouldn't go in, not breaking anything
in that case.

Additionally there might be out-of-tree PV drivers, which could be
hit by not being flagged to be essential. With the not_essential flag
the situation wouldn't change for such a driver.


Juergen

--------------C02A3EE7C04771EB3B004689
Content-Type: application/pgp-keys;
 name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Transfer-Encoding: quoted-printable
Content-Description: OpenPGP public key
Content-Disposition: attachment;
 filename="OpenPGP_0xB0DE9DD628BF132F.asc"

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy=
cWx
w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O=
f8Z
d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y=
9bf
IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq=
G7/
377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR=
3Jv
c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA=
QIe
AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT=
hpw
dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0=
MbD
1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv=
oPH
Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v=
5QL
+qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ=
2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC=
QoL
BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr=
Wf0
teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC=
/nu
AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh=
ITT
d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm=
XBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz=
80h
SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC=
AcD
AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn=
FOX
gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1=
jnD
kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0=
N51
N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l=
otu
fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1=
tqS
EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA=
hsD
BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3=
g3O
ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5=
dM7
wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5=
D+j
LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm=
V2x
AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N=
Eaw
QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW=
nHI
s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR=
wgn
BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV=
bVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk=
pEd
IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA=
QAB
wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw=
Tbe
8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1=
vJz
Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8=
VGi
wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW=
svi
uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX=
zXs
ZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------C02A3EE7C04771EB3B004689--

--UqKrfN4EOpH1zBdeQbsH4TMElHBbnARpK--

--osso5FxvKknFWuti2qByayI8n0rKWIOdo
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmF2eTYFAwAAAAAACgkQsN6d1ii/Ey9O
xgf+IGDTE+YDE61LIodtFf3QJmdPssYsBAOBwYWJFs5jGT2ddgGd51lqt0gCBPxYovlxXfLf24U5
PCXgb/UPtU5R0xKq99Gc0hQonmBj8esYaqKhdldHkgfmd3E58dsJQ1bYB3Ye84SafU7sNaiKBTh0
CkXxpEhogtaP19nhjxM96AyKcVBko/kdQwH4yd9kp28zo2+rw2IU2CKQPJS0CH0IkJlVcIJAXCK/
Oa0TgXnhDwPVtH0rf2O/MDuvpSz2O29BOaa/cH3W2jhUI249Eq6k6s1KqwB0/qjqX8UddTLmVynL
Ftj+I0OdFgwzIwDaKWEJQCucvHD6inXkx+vr50ziVw==
=RfSy
-----END PGP SIGNATURE-----

--osso5FxvKknFWuti2qByayI8n0rKWIOdo--


From xen-devel-bounces@lists.xenproject.org Mon Oct 25 09:36:22 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Oct 2021 09:36:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.215687.375027 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mewOx-0008UF-Fe; Mon, 25 Oct 2021 09:36:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 215687.375027; Mon, 25 Oct 2021 09:36:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mewOx-0008U8-C1; Mon, 25 Oct 2021 09:36:19 +0000
Received: by outflank-mailman (input) for mailman id 215687;
 Mon, 25 Oct 2021 09:36:19 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mewOw-0008U2-Vn
 for xen-devel@lists.xenproject.org; Mon, 25 Oct 2021 09:36:18 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mewOw-0001hg-Sx
 for xen-devel@lists.xenproject.org; Mon, 25 Oct 2021 09:36:18 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mewOw-0002ye-Rt
 for xen-devel@lists.xenproject.org; Mon, 25 Oct 2021 09:36:18 +0000
Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89)
 (envelope-from <iwj@xenproject.org>)
 id 1mewOt-00016E-DJ; Mon, 25 Oct 2021 10:36:15 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date
	:Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From;
	bh=+r0WrWT0n7yrCi1J9JHMuoyyx+8D4LIMj353aFttoMI=; b=BnOKVnjGMItHw0fm4RaQDw0Y1m
	zjkVR4P330zU9bAawWMxjQhgmb02Ud//4Td/zl6uN68QGr/ssOAgDh1oU5BuoM0+kDFwyw5IZ+mXj
	lAJ0kmBnQmQkIVqVpbgUIH9j6KvcsI3f1ru75evhvVhVE0xklkBLNamRdwdd3phfQg6o=;
From: Ian Jackson <iwj@xenproject.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <24950.31374.956099.106459@mariner.uk.xensource.com>
Date: Mon, 25 Oct 2021 10:36:14 +0100
To: Juergen Gross <jgross@suse.com>
Cc: xen-devel@lists.xenproject.org
Subject: Re: [PATCH] OSStest: explicitly enable building qemu-traditional
In-Reply-To: <152bf281-6921-42bd-a87a-054056a385ff@suse.com>
References: <20211019130211.32233-1-jgross@suse.com>
	<24942.49760.686147.851391@mariner.uk.xensource.com>
	<152bf281-6921-42bd-a87a-054056a385ff@suse.com>
X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu)

Juergen Gross writes ("Re: [PATCH] OSStest: explicitly enable building qemu-traditional"):
> On 19.10.21 15:04, Ian Jackson wrote:
> > OOI, have you done any kind of test on this ?
> 
> No, this was a pure "lets do things in a similar way as the other
> options" approach.
> 
> > I'm kind of inclined to just push it and let osstest's pre-production
> > self-test test it.
> 
> You are in a far better position than me to decide this. :-)

Well, I did a quick test to see that it DTRT on x86 and that looked
OK.  So I pushed it to pretest.  However, unfortunately, it breaks on
ARM:

http://logs.test-lab.xenproject.org/osstest/logs/165843/build-arm64/info.html

That one gets as far as actually trying to build qemu-xen-traditional,
and then fails like this:

Unsupported CPU = aarch64
make[2]: *** [Makefile:167: subdir-all-qemu-xen-traditional-dir] Error 1

I think this needs to be made conditional.  In the perl script,
$r{arch} contains osstest's idea of the architecture (which uses
Debian arch names).

Can you send a new patch which compares $r{arch} with 'i386' and
'amd64' ?

Thanks,
Ian.


From xen-devel-bounces@lists.xenproject.org Mon Oct 25 09:38:11 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Oct 2021 09:38:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.215694.375038 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mewQk-0000gK-RX; Mon, 25 Oct 2021 09:38:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 215694.375038; Mon, 25 Oct 2021 09:38:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mewQk-0000gD-Nw; Mon, 25 Oct 2021 09:38:10 +0000
Received: by outflank-mailman (input) for mailman id 215694;
 Mon, 25 Oct 2021 09:38:09 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=1v/+=PN=epam.com=prvs=0932af52eb=oleksandr_andrushchenko@srs-us1.protection.inumbo.net>)
 id 1mewQj-0000g5-5F
 for xen-devel@lists.xenproject.org; Mon, 25 Oct 2021 09:38:09 +0000
Received: from mx0b-0039f301.pphosted.com (unknown [148.163.137.242])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id dbd9828c-b117-43d8-9a04-6059a61707aa;
 Mon, 25 Oct 2021 09:38:07 +0000 (UTC)
Received: from pps.filterd (m0174682.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 19P94cQB027774; 
 Mon, 25 Oct 2021 09:38:04 GMT
Received: from eur01-ve1-obe.outbound.protection.outlook.com
 (mail-ve1eur01lp2050.outbound.protection.outlook.com [104.47.1.50])
 by mx0b-0039f301.pphosted.com with ESMTP id 3bwrrqgb2r-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Mon, 25 Oct 2021 09:38:04 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by AM0PR03MB4883.eurprd03.prod.outlook.com (2603:10a6:208:103::23)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.16; Mon, 25 Oct
 2021 09:38:00 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::c038:e032:595a:651]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::c038:e032:595a:651%8]) with mapi id 15.20.4628.020; Mon, 25 Oct 2021
 09:38:00 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: dbd9828c-b117-43d8-9a04-6059a61707aa
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=PYyNuS/FAH1Gb8jPkEw1nnGSQDYdo0beu3R1gGMndgoYNchLJDF5+x0UfYnOD2BOlAxOFlcz8Yt3He5qCFD3K6t+9Iz47pV/j0W7R70bts8+kc3igHj+/N/dfk5qpRXoUNwAHw7IF/iQhSzm1qpsjZadxU+V+NoP/l39FUUsldUTYw5cjsAtm7ITZEAc7VKMhMqHtcw89/f5VzYvFMe7LfJw5U4QwFuPOjfn9h+k4WepeJx5DwXic9Y5wed09YIGwx58GkFsOC5dJlig14ct9O5ENrePsXQF4XFTFGOxaszmi1WPh5Cwyd4qiCTbN7Z6KsLSNkpu4eMLT1nRMVeiNQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=5t6ydvK0+SOZDzah9cAZ3VHC4XWqTsLMD6r/s+pKFJQ=;
 b=IfiDr+6+Mfng/XLk7xIm60EFOtfTA0KtX31a9aubgW3S2939sfEXEXcfz7dkvF+IskTwwSIY0OScwE3BvsYeKZG79BifYZD1CelOdI0TRQvpKi+4csN87Ow6tXmz92wj8TW0Fdq6FmPQvY5kP3zCRMum7YTIQFvHdaPu8kBKyqlzDQXjKju5UFLLLlZxjHwav8HOLaSFKvPBzBsmAQD5QMLhGyIg7cR2JyOkbLHy/rMDf8UvInj7qMU0AGfgu4xeE7bZOCa/dc5iuZI5RELFV8gHuUYoh8mx8hACJdkB5htToAxIP4lvsZ2F0BCMUOsglFDpbPi8d+XX2NCVk8BeSA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=5t6ydvK0+SOZDzah9cAZ3VHC4XWqTsLMD6r/s+pKFJQ=;
 b=Y8D8VnlQkGfv4m4fj39K3WqzGgIlQHBENk6Fu7RYBQ/EOP5ci8nylONZ9Og+eblHiYFyU1C+w41GtCJLiDjPmxlhGMde9YT7CbJ5j9RHgl41umIbkPLtM/0BPhVQvvuVSKxHB/I5OyhRsfeYoxhpseVPIDSOc//qRnZcUbqFdvggXpxgO3vSSDj5c4bmd3KcfvQBvV0+ikruRJgZD9AS/X4KdZwokR4xm3SoyZfvTCWz9fCxEwrSF4DJD6bdvvvB4OO1HQvbS8sDWNECGyLToO70COFvj4tXIK4WL4nCGau19K7WFsuzJ/gzfo+pWSS1CXc7qcM/7JA3eXxSEmKI+w==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org"
	<sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "jbeulich@suse.com" <jbeulich@suse.com>,
        "andrew.cooper3@citrix.com"
	<andrew.cooper3@citrix.com>,
        "george.dunlap@citrix.com"
	<george.dunlap@citrix.com>,
        "paul@xen.org" <paul@xen.org>,
        Bertrand Marquis
	<bertrand.marquis@arm.com>,
        Rahul Singh <rahul.singh@arm.com>,
        Oleksandr
 Andrushchenko <Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH v5 08/10] xen/arm: Setup MMIO range trap handlers for
 hardware domain
Thread-Topic: [PATCH v5 08/10] xen/arm: Setup MMIO range trap handlers for
 hardware domain
Thread-Index: AQHXvAknAgtt9sKLd0u6OFwp+HT0w6vQvTaAgBLStoA=
Date: Mon, 25 Oct 2021 09:38:00 +0000
Message-ID: <7f2a5875-69c9-b40b-287b-1355698598e5@epam.com>
References: <20211008055535.337436-1-andr2000@gmail.com>
 <20211008055535.337436-9-andr2000@gmail.com>
 <YWawvYGqIe3DwZfI@MacBook-Air-de-Roger.local>
In-Reply-To: <YWawvYGqIe3DwZfI@MacBook-Air-de-Roger.local>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 2368d4a6-80d9-4eb6-c008-08d9979b229e
x-ms-traffictypediagnostic: AM0PR03MB4883:
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <AM0PR03MB48830F2146FE1401E8A4D492E7839@AM0PR03MB4883.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:5236;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 FAGySp/HzuzpRynLEQiTpEV3UHJbBqUgt7nbTXol5Ti5yj6+59kbDDhpJMkifCZdDfzUy2BX4q6jYDmY3Q/5cQNwkP1O0AhVB0o5LYW4EYwZBSPYaY/UZjllItNcUQqkrQxHAIbFwLJomMJLYKwFTPGKpJXTQhPehFicE2Sn0qwZx6bUA5K4AizqVZPIKrABnuucEBQ8Gd3mYF4FkNyOrSjVLXmb44pA3BwBwzJ+xKZdeoG3tO/kR5DHgFQjJ2sD+nraNJQZS0WL+ycub0jQaXDQzOVk9MljwOwwBz9JoPXktfTOWWYzEcQea+/K/JFT3owHxAf313xCgTRPwr1GOl8aRZGu75+nVyOSAUpwJeoD5zYJQ7NdtGnYmYqlQvFrOuIY8GcUhF9wtrCrjVKUaNVCtr4rvw9/cU6Vde5lXBGvLKhKWoCCd2WwhmoWe9Gdl0De5u5ttTg+WfpP001bg91SkZEh2AvUgo54e2CAJ1h6br237eOK9gi3trw99ijIdIr2hX6YZZTMFIk/ZIALCMNknAtDXQhnff68jSL2vb4T8uEA8j1eXStX8HtQyOiE58WVKRAqndOhMcEco9ZzoemLYz2cTaW/lSkBOQe/Mf0Y7Sj9Kd0Wko46lWerCyVgc1uXVoiFNS3p6n5cKYsdDZaLhZmMLKG27tSQQoBl98+hzmdieSa4YH19wwkAVqNzvqEH3E+KlfWZLRM94cI9lyjBd6e1O0kA1+oFr4+fDWIUWTKIM5IHrZvEs715csVF
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(7416002)(316002)(71200400001)(107886003)(54906003)(508600001)(4326008)(26005)(2616005)(66946007)(31686004)(66556008)(6486002)(66476007)(6512007)(8676002)(186003)(122000001)(91956017)(36756003)(83380400001)(64756008)(66446008)(76116006)(6506007)(6916009)(5660300002)(38070700005)(31696002)(38100700002)(53546011)(8936002)(86362001)(2906002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?T0QvYkVxdjJYQ2drb3M2dTJVTTRKQXBDZnlCUnFaOGFuTk1pY3Jya0tSVzJN?=
 =?utf-8?B?ZDNLM09BbXdKcnlOZ0lZRDVhYXpMbEM2cWJOUldOY1pLNXVpNGEwcWpRdllD?=
 =?utf-8?B?YjNmQW0zRUxjMVpvZDh5T0pGeDRJWjl5a3NOVmtNMmZCQjVTcWNpdy94SDBx?=
 =?utf-8?B?b2tmVFRMZzgwRXVaRUZia1R2OU9KeVAyTFF2Z3RxZXR4RGFzV3phOW9VVXND?=
 =?utf-8?B?enBzOVZaNFlSMEg1RlhneGgreW5uTmVJakhGc25uZTlFVGFTMlAvVnV3bml4?=
 =?utf-8?B?dmo5cmg0NFpMOThGVitZdjNiYy92eUw5aElKclQ3MjhoQnZiME5KRWlNMCtn?=
 =?utf-8?B?TEh3bzhheEdvNVphVlRjb1pJL0VnLzk4Y1RrT0N2OGNBcCsrYVpQUE5iOVR0?=
 =?utf-8?B?a0p0MGZiYlh0VWNmVGxvdXpoczBSdFhTVjdRaW9ucTkrYjRITmpyRzBEYWU1?=
 =?utf-8?B?LzYrcmlGcVk4cmxzdjdidmVIOXF1NVNPOVFDZ0U3MmNydnJTVHFnYnJIbDJ3?=
 =?utf-8?B?UFFjeXowWGdvZFFweVdkWGhXN0V0VTB3RzZxb1BlSmIzTDV5TTdJQTdqY2tC?=
 =?utf-8?B?aFZjK1BQaWIybnlYSjhBNTBya3p5cGdqNWNGS1lmNjIrV293Y0VhY2lXcjBk?=
 =?utf-8?B?WFJDNVJDb1M2NEVUQzhpQ3o5cllsNXZyQ042dG95OC8zOTdmeENpLzJpTTZw?=
 =?utf-8?B?VXVXbDNCRURpdDdXdzZTN1ZLamdOY1ZvVE11QXNsNWlLeUtSTVc4QnlwTnRG?=
 =?utf-8?B?S3FoaVNuOVlCd1BjOTllNzEzNmE2THByNGIvS1ZGbmZJUlh0WXRUanVxOFc5?=
 =?utf-8?B?M01TeFBZQjlVN0JickUrZlZBaW5zL25QWFh5QnI3a2xUZDBHSWVNVndLcGJ6?=
 =?utf-8?B?Ui9nOC91MGhBaGs0dnZRaTZCQ20yZ09mV1BKNlIrYlZpanl6THd5Wi9GSGJo?=
 =?utf-8?B?ZU1IZkNhSzJYZDArZjIrRVZBRlZNM240REM5ckVHMU1BQzBSeDRhTjJzcDdM?=
 =?utf-8?B?QmNhS3IzTm5LbkdYNkZlV2tQcGpDRG04ZnlZSVA1Yk5ZVFJ6bFNaQmowVk5q?=
 =?utf-8?B?dXJxSXBFclpDbFVhdHZBcHZ3QlAyaDBSelVuRE1GdHRHbm1jMWZDQnI5ZWk0?=
 =?utf-8?B?alhyaGlBOVBURERUMGJVNWNqaEhDWE5nY3pDMGJCZVFVTWhMcWRaY2Nqd2V0?=
 =?utf-8?B?Zy9wdXozSEpsZyswUFY5MnQ0U3haeGdXUVB1MnI1YU5pMDlmd1dVazJIdFUr?=
 =?utf-8?B?amdVQmc5M0o3dUkycjRTMjRVRjVCemtYZVlabnhBWko4T244K0IyaVc5M0ln?=
 =?utf-8?B?QlRGZXpFUnVuOWJtWGZxWUcwRFR3ZjlhRjVVWWNiYzdwbU41S2N3TTBRYUlI?=
 =?utf-8?B?Y284RmhpNUkvdnM3Ny8ybVRjKzNBUFozUkNwUmMzYndQMzZLZFVjVlFQY3lu?=
 =?utf-8?B?eXdxSjJoQjIxcHBiSGxaOEhJWDQ0dllwYjZVMmZzZlBpM3JPNDdwNTJxdFpk?=
 =?utf-8?B?azZ6MmlsUHpDb2VZQTlJVXRJUGtsblZQYU95R0FmNzJxRzZ6Z3owUkJ2MEhk?=
 =?utf-8?B?dGI0NGtpNGowTXNkYXdlcjRHV3A1TGl3MkEvQWwrMi9pdDJ6cGl2VklMc2l3?=
 =?utf-8?B?eGp0N0JZRXNOdTA3bUROZXdCN0hIeE9FRHVNSENRYWJoWGs3Yi9WSHdOT1hp?=
 =?utf-8?B?NW81ZVBkb0ttRC9DTTM0YWpKdURaVEdTdGtZUmZMWCt2eVlGWVVQYUJvNS93?=
 =?utf-8?B?eWR0Mmt6WUlDdkRsZnU3SmRrNmI2Q3U3ZTllN08xWDZWVDdPTStGNmVudll3?=
 =?utf-8?B?RUVQL0VTdWVIWG4xQzFFc0IzQjhFZDRKcGgxb05pcGJmZUVwVnRwWnFmVWI2?=
 =?utf-8?B?NVdzTjdnV0VacDZHbzE2L0NNVk4rN1J5ekxHcG1xWGZ2ZThqMzBsMFVnM0ZD?=
 =?utf-8?B?Z04rU0VmSk5yc3owUm8rVVNjcUxhdTJhekRHeXk4VzZrWGNOWHNtdVV0VTcz?=
 =?utf-8?B?YWFXRmNrRUFPUWRGRFhOWEtPZGs0d2I3MmRxMmJ3Q3lQODlCZ2V6TkVvbkhL?=
 =?utf-8?B?akxFUXN1RzBObDh3bXVGY2tRK1pRd1BaWk40OGlwZS9JMEtnWGJMN2ExVWhJ?=
 =?utf-8?B?WWxlNENJUXRhaitRQStsWG9CMnJsWDk2OHowbUZlK2VqUkVMbngxbXY2V29l?=
 =?utf-8?B?aFVESzdCWjJqVGlRbmxuaVRMWHF0eE1Mcm5MVzFQck9tNHRSYjdMRHdwZTVu?=
 =?utf-8?B?S2pPN1h3TU9jZE5OVjBDRWM3aGdPeEJpeTFDMUxzNnBqV2FCUXZzNTQ5U3Nt?=
 =?utf-8?B?cGxmdW80VHpQSWx0OEdkcDc2cXFpTEIwY011Sy9FbEFhMlpyQm5UQT09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <0E23CD6EF932074AA5EDFAD063FC0F2E@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2368d4a6-80d9-4eb6-c008-08d9979b229e
X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Oct 2021 09:38:00.5015
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: E1cqlBrbc6S/rk5jWD2nXljldq7QWjE2bOGWUJwTZB6E/nW3VNxR9gtGlui4qXketBy/TKgMgZc38QzaSfKRfw30FlP8kfYDkeP9kjMuGktxc2o8DODP0vOaAyBVNT8J
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR03MB4883
X-Proofpoint-GUID: wKWCXAu5Fx1pdctUkslOWvQh4_pT0Yvz
X-Proofpoint-ORIG-GUID: wKWCXAu5Fx1pdctUkslOWvQh4_pT0Yvz
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475
 definitions=2021-10-25_03,2021-10-25_01,2020-04-07_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 phishscore=0
 lowpriorityscore=0 bulkscore=0 adultscore=0 impostorscore=0 suspectscore=0
 priorityscore=1501 mlxlogscore=999 malwarescore=0 mlxscore=0 spamscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109230001
 definitions=main-2110250058

SGksIFJvZ2VyIQ0KDQpPbiAxMy4xMC4yMSAxMzoxMSwgUm9nZXIgUGF1IE1vbm7DqSB3cm90ZToN
Cj4gT24gRnJpLCBPY3QgMDgsIDIwMjEgYXQgMDg6NTU6MzNBTSArMDMwMCwgT2xla3NhbmRyIEFu
ZHJ1c2hjaGVua28gd3JvdGU6DQo+PiBGcm9tOiBPbGVrc2FuZHIgQW5kcnVzaGNoZW5rbyA8b2xl
a3NhbmRyX2FuZHJ1c2hjaGVua29AZXBhbS5jb20+DQo+Pg0KPj4gSW4gb3JkZXIgZm9yIHZQQ0kg
dG8gd29yayBpdCBuZWVkcyB0byBtYWludGFpbiBndWVzdCBhbmQgaGFyZHdhcmUNCj4+IGRvbWFp
bidzIHZpZXdzIG9mIHRoZSBjb25maWd1cmF0aW9uIHNwYWNlLiBGb3IgZXhhbXBsZSwgQkFScyBh
bmQNCj4+IENPTU1BTkQgcmVnaXN0ZXJzIHJlcXVpcmUgZW11bGF0aW9uIGZvciBndWVzdHMgYW5k
IHRoZSBndWVzdCB2aWV3DQo+PiBvZiB0aGUgcmVnaXN0ZXJzIG5lZWRzIHRvIGJlIGluIHN5bmMg
d2l0aCB0aGUgcmVhbCBjb250ZW50cyBvZiB0aGUNCj4+IHJlbGV2YW50IHJlZ2lzdGVycy4gRm9y
IHRoYXQgRUNBTSBhZGRyZXNzIHNwYWNlIG5lZWRzIHRvIGFsc28gYmUNCj4+IHRyYXBwZWQgZm9y
IHRoZSBoYXJkd2FyZSBkb21haW4sIHNvIHdlIG5lZWQgdG8gaW1wbGVtZW50IFBDSSBob3N0DQo+
PiBicmlkZ2Ugc3BlY2lmaWMgY2FsbGJhY2tzIHRvIHByb3Blcmx5IHNldHVwIE1NSU8gaGFuZGxl
cnMgZm9yIHRob3NlDQo+PiByYW5nZXMgZGVwZW5kaW5nIG9uIHBhcnRpY3VsYXIgaG9zdCBicmlk
Z2UgaW1wbGVtZW50YXRpb24uDQo+Pg0KPj4gU2lnbmVkLW9mZi1ieTogT2xla3NhbmRyIEFuZHJ1
c2hjaGVua28gPG9sZWtzYW5kcl9hbmRydXNoY2hlbmtvQGVwYW0uY29tPg0KPj4gUmV2aWV3ZWQt
Ynk6IFN0ZWZhbm8gU3RhYmVsbGluaSA8c3N0YWJlbGxpbmlAa2VybmVsLm9yZz4NCj4+IFJldmll
d2VkLWJ5OiBSYWh1bCBTaW5naCA8cmFodWwuc2luZ2hAYXJtLmNvbT4NCj4+IFRlc3RlZC1ieTog
UmFodWwgU2luZ2ggPHJhaHVsLnNpbmdoQGFybS5jb20+DQo+PiAtLS0NCj4+IFNpbmNlIHYzOg0K
Pj4gLSBmaXhlZCBjb21tZW50IGZvcm1hdHRpbmcNCj4+IFNpbmNlIHYyOg0KPj4gLSByZW1vdmVk
IHVubmVlZGVkIGFzc2lnbm1lbnQgKGNvdW50ID0gMCkNCj4+IC0gcmVtb3ZlZCB1bm5lZWRlZCBo
ZWFkZXIgaW5jbHVzaW9uDQo+PiAtIHVwZGF0ZSBjb21taXQgbWVzc2FnZQ0KPj4gU2luY2UgdjE6
DQo+PiAgIC0gRHluYW1pY2FsbHkgY2FsY3VsYXRlIHRoZSBudW1iZXIgb2YgTU1JTyBoYW5kbGVy
cyByZXF1aXJlZCBmb3IgdlBDSQ0KPj4gICAgIGFuZCB1cGRhdGUgdGhlIHRvdGFsIG51bWJlciBh
Y2NvcmRpbmdseQ0KPj4gICAtIHMvY2xiL2NiDQo+PiAgIC0gRG8gbm90IGludHJvZHVjZSBhIG5l
dyBjYWxsYmFjayBmb3IgTU1JTyBoYW5kbGVyIHNldHVwDQo+PiAtLS0NCj4+ICAgeGVuL2FyY2gv
YXJtL2RvbWFpbi5jICAgICAgICAgICAgICB8ICAyICsrDQo+PiAgIHhlbi9hcmNoL2FybS9wY2kv
cGNpLWhvc3QtY29tbW9uLmMgfCAyOCArKysrKysrKysrKysrKysrKysrKysrKysNCj4+ICAgeGVu
L2FyY2gvYXJtL3ZwY2kuYyAgICAgICAgICAgICAgICB8IDM0ICsrKysrKysrKysrKysrKysrKysr
KysrKysrKysrKw0KPj4gICB4ZW4vYXJjaC9hcm0vdnBjaS5oICAgICAgICAgICAgICAgIHwgIDYg
KysrKysrDQo+PiAgIHhlbi9pbmNsdWRlL2FzbS1hcm0vcGNpLmggICAgICAgICAgfCAgNSArKysr
Kw0KPj4gICA1IGZpbGVzIGNoYW5nZWQsIDc1IGluc2VydGlvbnMoKykNCj4+DQo+PiBkaWZmIC0t
Z2l0IGEveGVuL2FyY2gvYXJtL2RvbWFpbi5jIGIveGVuL2FyY2gvYXJtL2RvbWFpbi5jDQo+PiBp
bmRleCA3OTAxMmJmNzc3NTcuLmZhNmZjYzVlNDY3YyAxMDA2NDQNCj4+IC0tLSBhL3hlbi9hcmNo
L2FybS9kb21haW4uYw0KPj4gKysrIGIveGVuL2FyY2gvYXJtL2RvbWFpbi5jDQo+PiBAQCAtNzMz
LDYgKzczMyw4IEBAIGludCBhcmNoX2RvbWFpbl9jcmVhdGUoc3RydWN0IGRvbWFpbiAqZCwNCj4+
ICAgICAgIGlmICggKHJjID0gZG9tYWluX3ZnaWNfcmVnaXN0ZXIoZCwgJmNvdW50KSkgIT0gMCAp
DQo+PiAgICAgICAgICAgZ290byBmYWlsOw0KPj4gICANCj4+ICsgICAgY291bnQgKz0gZG9tYWlu
X3ZwY2lfZ2V0X251bV9tbWlvX2hhbmRsZXJzKGQpOw0KPj4gKw0KPj4gICAgICAgaWYgKCAocmMg
PSBkb21haW5faW9faW5pdChkLCBjb3VudCArIE1BWF9JT19IQU5ETEVSKSkgIT0gMCApDQo+IElN
TyBpdCBtaWdodCBiZSBiZXR0ZXIgdG8gY29udmVydCB0aGUgZml4ZWQgYXJyYXkgaW50byBhIGxp
bmtlZCBsaXN0LA0KPiBJIGd1ZXNzIHRoaXMgbWFkZSBzZW5zZSB3aGVuIEFybSBoYWQgYSB2ZXJ5
IGxpbWl0ZWQgbnVtYmVyIG9mIG1taW8NCj4gdHJhcCBoYW5kbGVycywgYnV0IGhhdmluZyB0byBk
byBhbGwgdGhpcyBhY2NvdW50aW5nIHNlZW1zIHF1aXRlDQo+IHRlZGlvdXMgZXZlcnkgdGltZSB5
b3Ugd2FudCB0byBhZGQgbmV3IGhhbmRsZXJzLg0KWWVzLCBJIHRoaW5rIHdlIG5lZWQgdG8gZG8g
c28sIGJ1dCB0aGlzIGltcHJvdmVtZW50IHdhcyBub3QgbWVhbnQNCnRvIGJlIGluIHRoaXMgcGF0
Y2guDQo+DQo+PiAgICAgICAgICAgZ290byBmYWlsOw0KPj4gICANCj4+IGRpZmYgLS1naXQgYS94
ZW4vYXJjaC9hcm0vcGNpL3BjaS1ob3N0LWNvbW1vbi5jIGIveGVuL2FyY2gvYXJtL3BjaS9wY2kt
aG9zdC1jb21tb24uYw0KPj4gaW5kZXggNTkyYzAxYWFlNWJiLi4xZWI0ZGFhODczNjUgMTAwNjQ0
DQo+PiAtLS0gYS94ZW4vYXJjaC9hcm0vcGNpL3BjaS1ob3N0LWNvbW1vbi5jDQo+PiArKysgYi94
ZW4vYXJjaC9hcm0vcGNpL3BjaS1ob3N0LWNvbW1vbi5jDQo+PiBAQCAtMjkyLDYgKzI5MiwzNCBA
QCBzdHJ1Y3QgZHRfZGV2aWNlX25vZGUgKnBjaV9maW5kX2hvc3RfYnJpZGdlX25vZGUoc3RydWN0
IGRldmljZSAqZGV2KQ0KPj4gICAgICAgfQ0KPj4gICAgICAgcmV0dXJuIGJyaWRnZS0+ZHRfbm9k
ZTsNCj4+ICAgfQ0KPj4gKw0KPj4gK2ludCBwY2lfaG9zdF9pdGVyYXRlX2JyaWRnZXMoc3RydWN0
IGRvbWFpbiAqZCwNCj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGludCAoKmNiKShz
dHJ1Y3QgZG9tYWluICpkLA0KPj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgIHN0cnVjdCBwY2lfaG9zdF9icmlkZ2UgKmJyaWRnZSkpDQo+PiArew0KPj4gKyAgICBzdHJ1
Y3QgcGNpX2hvc3RfYnJpZGdlICpicmlkZ2U7DQo+PiArICAgIGludCBlcnI7DQo+PiArDQo+PiAr
ICAgIGxpc3RfZm9yX2VhY2hfZW50cnkoIGJyaWRnZSwgJnBjaV9ob3N0X2JyaWRnZXMsIG5vZGUg
KQ0KPj4gKyAgICB7DQo+PiArICAgICAgICBlcnIgPSBjYihkLCBicmlkZ2UpOw0KPj4gKyAgICAg
ICAgaWYgKCBlcnIgKQ0KPj4gKyAgICAgICAgICAgIHJldHVybiBlcnI7DQo+PiArICAgIH0NCj4+
ICsgICAgcmV0dXJuIDA7DQo+PiArfQ0KPj4gKw0KPj4gK2ludCBwY2lfaG9zdF9nZXRfbnVtX2Jy
aWRnZXModm9pZCkNCj4+ICt7DQo+PiArICAgIHN0cnVjdCBwY2lfaG9zdF9icmlkZ2UgKmJyaWRn
ZTsNCj4+ICsgICAgaW50IGNvdW50ID0gMDsNCj4gdW5zaWduZWQgaW50IGZvciBib3RoIHRoZSBs
b2NhbCB2YXJpYWJsZSBhbmQgdGhlIHJldHVybiB0eXBlLg0KT2sNCj4NCj4+ICsNCj4+ICsgICAg
bGlzdF9mb3JfZWFjaF9lbnRyeSggYnJpZGdlLCAmcGNpX2hvc3RfYnJpZGdlcywgbm9kZSApDQo+
PiArICAgICAgICBjb3VudCsrOw0KPj4gKw0KPj4gKyAgICByZXR1cm4gY291bnQ7DQo+PiArfQ0K
Pj4gKw0KPj4gICAvKg0KPj4gICAgKiBMb2NhbCB2YXJpYWJsZXM6DQo+PiAgICAqIG1vZGU6IEMN
Cj4+IGRpZmYgLS1naXQgYS94ZW4vYXJjaC9hcm0vdnBjaS5jIGIveGVuL2FyY2gvYXJtL3ZwY2ku
Yw0KPj4gaW5kZXggNzZjMTJiOTI4MTRmLi42ZTE3OWNkMzAxMGIgMTAwNjQ0DQo+PiAtLS0gYS94
ZW4vYXJjaC9hcm0vdnBjaS5jDQo+PiArKysgYi94ZW4vYXJjaC9hcm0vdnBjaS5jDQo+PiBAQCAt
ODAsMTcgKzgwLDUxIEBAIHN0YXRpYyBjb25zdCBzdHJ1Y3QgbW1pb19oYW5kbGVyX29wcyB2cGNp
X21taW9faGFuZGxlciA9IHsNCj4+ICAgICAgIC53cml0ZSA9IHZwY2lfbW1pb193cml0ZSwNCj4+
ICAgfTsNCj4+ICAgDQo+PiArc3RhdGljIGludCB2cGNpX3NldHVwX21taW9faGFuZGxlcihzdHJ1
Y3QgZG9tYWluICpkLA0KPj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgc3Ry
dWN0IHBjaV9ob3N0X2JyaWRnZSAqYnJpZGdlKQ0KPj4gK3sNCj4+ICsgICAgc3RydWN0IHBjaV9j
b25maWdfd2luZG93ICpjZmcgPSBicmlkZ2UtPmNmZzsNCj4+ICsNCj4+ICsgICAgcmVnaXN0ZXJf
bW1pb19oYW5kbGVyKGQsICZ2cGNpX21taW9faGFuZGxlciwNCj4+ICsgICAgICAgICAgICAgICAg
ICAgICAgICAgIGNmZy0+cGh5c19hZGRyLCBjZmctPnNpemUsIE5VTEwpOw0KPiBJJ20gY29uZnVz
ZWQgaGVyZSwgZG9uJ3QgeW91IG5lZWQgdG8gdXNlIGEgc2xpZ2h0bHkgZGlmZmVyZW50IGhhbmRs
ZXINCj4gZm9yIGRvbTAgc28gdGhhdCB5b3UgY2FuIGRpZmZlcmVudGlhdGUgYmV0d2VlbiB0aGUg
c2VnbWVudHMgb2YgdGhlDQo+IGhvc3QgYnJpZGdlcz8NCj4NCj4gQUZBSUNUIHRoZSB0cmFuc2xh
dGlvbiBkb25lIGJ5IHZwY2lfbW1pb19oYW5kbGVyIHVzaW5nIE1NQ0ZHX0JERg0KPiBhbHdheXMg
YXNzdW1lIHNlZ21lbnQgMC4NCllvdSBhcmUgYWJzb2x1dGVseSByaWdodCBoZXJlOiBJIGNhbiBz
ZXQgdXAgaHdkb20gc3BlY2lmaWMNCmhhbmRsZXJzLCBzbyBJIGNhbiBwcm9wZXJseSB0cmFuc2xh
dGUgdGhlIHNlZ21lbnQuDQpPbiB0aGUgb3RoZXIgaGFuZCwgd2hlbiB2aXJ0dWFsIGJ1cyB0b3Bv
bG9neSBhZGRlZCwgdGhlIFNCREYNCnRyYW5zbGF0aW9uIGZyb20gdmlydHVhbCB0byBwaHlzaWNh
bCBTQkRGIHJlc2lkZXMgaW4gdGhlIEFybSdzDQp2cGNpX21taW9fe3JlYWR8d3JpdGV9LCBsaWtl
IHRoZSBiZWxvdzoNCiDCoMKgwqAgaWYgKCBwcml2LT5pc192aXJ0X2VjYW0gJiYNCiDCoMKgwqDC
oMKgwqDCoMKgICF2cGNpX3RyYW5zbGF0ZV92aXJ0dWFsX2RldmljZSh2LT5kb21haW4sICZzYmRm
KSApDQogwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCByZXR1cm4gMTsNCihCVFcgSmFuIGFza2VkIGlu
IHNvbWUgb3RoZXIgY29tbWVudCB3aHkgaXQgaXMgQXJtIHNwZWNpZmljOg0KSSB0ZW5kIHRvIGtl
ZXAgaXQgQXJtIHNwZWNpZmljIHVudGlsIHRoZSBwb2ludCB3aGVuIHg4NiB3YW50cyB0aGF0DQph
cyB3ZWxsLiBVbnRpbCB0aGF0IHBvaW50IHRoZSBjb2RlLCBpZiBtb3ZlZCB0byBjb21tb24sIHdp
bGwgYmUNCnVubmVlZGVkIGFuZCBhcyBKYW4gY2FsbHMgdGhhdCAiZGVhZCIpDQpTbywgSSB0aGlu
ayB0aGF0IEkgY2FuIGV4dGVuZCB2cGNpX21taW9fe3JlYWR8d3JpdGV9IHRvIGFjY291bnQNCm9u
IHRoZSBod2RvbSBsaWtlICh2aXJ0dWFsIGJ1cyBjb2RlIGlzIHRoZSBmdXR1cmUgY29kZSk6DQoN
CnN0YXRpYyBpbnQgdnBjaV9tbWlvX3JlYWQoc3RydWN0IHZjcHUgKnYsIG1taW9faW5mb190ICpp
bmZvLA0KIMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
IHJlZ2lzdGVyX3QgKnIsIHZvaWQgKnApDQp7DQouLi4NCiDCoMKgwqAgc3RydWN0IHZwY2lfbW1p
b19wcml2ICpwcml2ID0gKHN0cnVjdCB2cGNpX21taW9fcHJpdiAqKXA7DQoNCiDCoMKgwqAgaWYg
KCBwcml2LT5pc192aXJ0X2VjYW0gKQ0KIMKgIMKgwqAgwqDCoCBzYmRmLnNiZGYgPSBNTUNGR19C
REYoaW5mby0+Z3BhKTsgLyogRm9yIHZpcnR1YWwgYnVzIHRvcG9sb2d5IHRoZSBzZWdtZW50IGlz
IGFsd2F5cyAwLiAqLw0KIMKgwqDCoCBlbHNlDQogwqDCoMKgIHsNCiDCoCDCoMKgIMKgwqAgc2Jk
Zi5zYmRmID0gTU1DRkdfQkRGKGluZm8tPmdwYSk7DQogwqDCoMKgwqDCoMKgwqAgc2JkZi5zZWcg
PSBwcml2LT5zZWdtZW50Ow0KIMKgwqDCoCB9DQogwqDCoMKgIHJlZyA9IFJFR0lTVEVSX09GRlNF
VChpbmZvLT5ncGEpOw0KDQouLi4NCiDCoMKgwqAgLyoNCiDCoMKgwqDCoCAqIEZvciB0aGUgcGFz
c2VkIHRocm91Z2ggZGV2aWNlcyB3ZSBuZWVkIHRvIG1hcCB0aGVpciB2aXJ0dWFsIFNCREYNCiDC
oMKgwqDCoCAqIHRvIHRoZSBwaHlzaWNhbCBQQ0kgZGV2aWNlIGJlaW5nIHBhc3NlZCB0aHJvdWdo
Lg0KIMKgwqDCoMKgICovDQogwqDCoMKgIGlmICggcHJpdi0+aXNfdmlydF9lY2FtICYmDQogwqDC
oMKgwqDCoMKgwqDCoCAhdnBjaV90cmFuc2xhdGVfdmlydHVhbF9kZXZpY2Uodi0+ZG9tYWluLCAm
c2JkZikgKQ0KIMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgcmV0dXJuIDE7DQoNCldpbGwgaXQgd29y
ayBmb3IgeW91Pw0KPg0KPj4gKyAgICByZXR1cm4gMDsNCj4+ICt9DQo+PiArDQo+PiAgIGludCBk
b21haW5fdnBjaV9pbml0KHN0cnVjdCBkb21haW4gKmQpDQo+PiAgIHsNCj4+ICAgICAgIGlmICgg
IWhhc192cGNpKGQpICkNCj4+ICAgICAgICAgICByZXR1cm4gMDsNCj4+ICAgDQo+PiArICAgIGlm
ICggaXNfaGFyZHdhcmVfZG9tYWluKGQpICkNCj4+ICsgICAgICAgIHJldHVybiBwY2lfaG9zdF9p
dGVyYXRlX2JyaWRnZXMoZCwgdnBjaV9zZXR1cF9tbWlvX2hhbmRsZXIpOw0KPj4gKw0KPj4gKyAg
ICAvKiBHdWVzdCBkb21haW5zIHVzZSB3aGF0IGlzIHByb2dyYW1tZWQgaW4gdGhlaXIgZGV2aWNl
IHRyZWUuICovDQo+PiAgICAgICByZWdpc3Rlcl9tbWlvX2hhbmRsZXIoZCwgJnZwY2lfbW1pb19o
YW5kbGVyLA0KPj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgIEdVRVNUX1ZQQ0lfRUNBTV9C
QVNFLCBHVUVTVF9WUENJX0VDQU1fU0laRSwgTlVMTCk7DQo+PiAgIA0KPj4gICAgICAgcmV0dXJu
IDA7DQo+PiAgIH0NCj4+ICAgDQo+PiAraW50IGRvbWFpbl92cGNpX2dldF9udW1fbW1pb19oYW5k
bGVycyhzdHJ1Y3QgZG9tYWluICpkKQ0KPj4gK3sNCj4+ICsgICAgaW50IGNvdW50Ow0KPiB1bnNp
Z25lZCBmb3IgYm90aCB0eXBlcy4NCk9rDQo+DQo+PiArDQo+PiArICAgIGlmICggaXNfaGFyZHdh
cmVfZG9tYWluKGQpICkNCj4+ICsgICAgICAgIC8qIEZvciBlYWNoIFBDSSBob3N0IGJyaWRnZSdz
IGNvbmZpZ3VyYXRpb24gc3BhY2UuICovDQo+PiArICAgICAgICBjb3VudCA9IHBjaV9ob3N0X2dl
dF9udW1fYnJpZGdlcygpOw0KPiBUaGVyZSdzIG5vIG5lZWQgdG8gdHJhcCBNU0ktWCBUYWJsZS9Q
QkEgYWNjZXNzZXMgZm9yIGRvbTAgSSBhc3N1bWU/DQpObyBuZWVkDQo+DQo+PiArICAgIGVsc2UN
Cj4+ICsgICAgICAgIC8qDQo+PiArICAgICAgICAgKiBWUENJX01TSVhfTUVNX05VTSBoYW5kbGVy
cyBmb3IgTVNJLVggdGFibGVzIHBlciBlYWNoIFBDSSBkZXZpY2UNCj4+ICsgICAgICAgICAqIGJl
aW5nIHBhc3NlZCB0aHJvdWdoLiBNYXhpbXVtIG51bWJlciBvZiBzdXBwb3J0ZWQgZGV2aWNlcw0K
Pj4gKyAgICAgICAgICogaXMgMzIgYXMgdmlydHVhbCBidXMgdG9wb2xvZ3kgZW11bGF0ZXMgdGhl
IGRldmljZXMgYXMgZW1iZWRkZWQNCj4+ICsgICAgICAgICAqIGVuZHBvaW50cy4NCj4+ICsgICAg
ICAgICAqICsxIGZvciBhIHNpbmdsZSBlbXVsYXRlZCBob3N0IGJyaWRnZSdzIGNvbmZpZ3VyYXRp
b24gc3BhY2UuDQo+PiArICAgICAgICAgKi8NCj4+ICsgICAgICAgIGNvdW50ID0gVlBDSV9NU0lY
X01FTV9OVU0gKiAzMiArIDE7DQo+IFRoZXJlJ3MgYSBzaW5nbGUgTVNJLVggbW1pbyBoYW5kbGVy
IHRoYXQgZGVhbHMgd2l0aCBib3RoIFBCQSBhbmQgTVNJWA0KPiB0YWJsZXMsIHNvIEkgZG9uJ3Qg
c2VlIHRoZSBuZWVkIHRvICogVlBDSV9NU0lYX01FTV9OVU0uDQpZZXMsIHRoYW5rIHlvdSwgaXQg
aXMgaW5kZWVkLCBzbyB0aGUgbnVtYmVyIGNhbiBiZSByZWR1Y2VkDQo+DQo+IFRoYW5rcywgUm9n
ZXIuDQpUaGFuayB5b3UsDQpPbGVrc2FuZHI=


From xen-devel-bounces@lists.xenproject.org Mon Oct 25 09:40:17 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Oct 2021 09:40:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.215702.375049 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mewSn-00022I-7j; Mon, 25 Oct 2021 09:40:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 215702.375049; Mon, 25 Oct 2021 09:40:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mewSn-00022B-4I; Mon, 25 Oct 2021 09:40:17 +0000
Received: by outflank-mailman (input) for mailman id 215702;
 Mon, 25 Oct 2021 09:40:15 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mewSl-000221-TH; Mon, 25 Oct 2021 09:40:15 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mewSl-0001m8-NI; Mon, 25 Oct 2021 09:40:15 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mewSl-0007Ie-EO; Mon, 25 Oct 2021 09:40:15 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mewSl-0000uo-Dq; Mon, 25 Oct 2021 09:40:15 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=7iQ/+KB7ColyoAKLjX8C16sSZD0I1FbhRFRD2PT7EJg=; b=PBIY+Wt2Z7BRPTNQPUUQe3BdPj
	5OWlYQF4HMiptDQ6O/2FryHU044BozzAfFRpYa9jDRX5DgT0R7X6PPalkXDE1nKJLEqyZPZnnj30q
	F1XIA8w/IdhIyZ8Gfqnu5Pr0GETy+DrPhX42BSVdO70thnPZCpBCkFTPgIlalyj33Ci4=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165848-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 165848: regressions - FAIL
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-examine:memdisk-try-append:fail:regression
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=87066fdd2e30fe9dd531125d95257c118a74617e
X-Osstest-Versions-That:
    linux=6c62666d8879238578b727f8e0a821e90c88f87e
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 25 Oct 2021 09:40:15 +0000

flight 165848 linux-linus real [real]
flight 165857 linux-linus real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/165848/
http://logs.test-lab.xenproject.org/osstest/logs/165857/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-amd64-amd64-examine      4 memdisk-try-append       fail REGR. vs. 165841

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 165841
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 165841
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165841
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 165841
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165841
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 165841
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 165841
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165841
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 linux                87066fdd2e30fe9dd531125d95257c118a74617e
baseline version:
 linux                6c62666d8879238578b727f8e0a821e90c88f87e

Last test of basis   165841  2021-10-24 17:40:42 Z    0 days
Testing same since   165848  2021-10-25 00:39:18 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Al Viro <viro@zeniv.linux.org.uk>
  Ian Kent <raven@themaw.net>
  Linus Torvalds <torvalds@linux-foundation.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

------------------------------------------------------------
commit 87066fdd2e30fe9dd531125d95257c118a74617e
Author: Linus Torvalds <torvalds@linux-foundation.org>
Date:   Sun Oct 24 09:48:33 2021 -1000

    Revert "mm/secretmem: use refcount_t instead of atomic_t"
    
    This reverts commit 110860541f443f950c1274f217a1a3e298670a33.
    
    Converting the "secretmem_users" counter to a refcount is incorrect,
    because a refcount is special in zero and can't just be incremented (but
    a count of users is not, and "no users" is actually perfectly valid and
    not a sign of a free'd resource).
    
    Reported-by: syzbot+75639e6a0331cd61d3e2@syzkaller.appspotmail.com
    Cc: Jordy Zomer <jordy@pwning.systems>
    Cc: Kees Cook <keescook@chromium.org>,
    Cc: Jordy Zomer <jordy@jordyzomer.github.io>
    Cc: James Bottomley <James.Bottomley@HansenPartnership.com>
    Cc: Mike Rapoport <rppt@kernel.org>
    Cc: Andrew Morton <akpm@linux-foundation.org>
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

commit b20078fd69a3da08d85c79b95101cf25c4afcc97
Merge: 6c62666d8879 25f54d08f12f
Author: Linus Torvalds <torvalds@linux-foundation.org>
Date:   Sun Oct 24 09:36:06 2021 -1000

    Merge branch 'fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
    
    Pull autofs fix from Al Viro:
     "Fix for a braino of mine (in getting rid of open-coded
      dentry_path_raw() in autofs a couple of cycles ago).
    
      Mea culpa...  Obvious -stable fodder"
    
    * 'fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs:
      autofs: fix wait name hash calculation in autofs_wait()

commit 25f54d08f12feb593e62cc2193fedefaf7825301
Author: Ian Kent <raven@themaw.net>
Date:   Thu Sep 23 15:13:39 2021 +0800

    autofs: fix wait name hash calculation in autofs_wait()
    
    There's a mistake in commit 2be7828c9fefc ("get rid of autofs_getpath()")
    that affects kernels from v5.13.0, basically missed because of me not
    fully testing the change for Al.
    
    The problem is that the hash calculation for the wait name qstr hasn't
    been updated to account for the change to use dentry_path_raw(). This
    prevents the correct matching an existing wait resulting in multiple
    notifications being sent to the daemon for the same mount which must
    not occur.
    
    The problem wasn't discovered earlier because it only occurs when
    multiple processes trigger a request for the same mount concurrently
    so it only shows up in more aggressive testing.
    
    Fixes: 2be7828c9fefc ("get rid of autofs_getpath()")
    Cc: stable@vger.kernel.org
    Signed-off-by: Ian Kent <raven@themaw.net>
    Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>


From xen-devel-bounces@lists.xenproject.org Mon Oct 25 09:54:51 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Oct 2021 09:54:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.215712.375063 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mewgn-0003ar-NW; Mon, 25 Oct 2021 09:54:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 215712.375063; Mon, 25 Oct 2021 09:54:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mewgn-0003ak-Jn; Mon, 25 Oct 2021 09:54:45 +0000
Received: by outflank-mailman (input) for mailman id 215712;
 Mon, 25 Oct 2021 09:54:43 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=cRlh=PN=suse.com=jgross@srs-us1.protection.inumbo.net>)
 id 1mewgl-0003ae-FA
 for xen-devel@lists.xenproject.org; Mon, 25 Oct 2021 09:54:43 +0000
Received: from smtp-out2.suse.de (unknown [195.135.220.29])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 9f3d40c7-5f3f-4c0a-8428-32388e3ea140;
 Mon, 25 Oct 2021 09:54:42 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 49CCC1FD34;
 Mon, 25 Oct 2021 09:54:41 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1FAD013B95;
 Mon, 25 Oct 2021 09:54:41 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id BBZwBuF+dmHOXAAAMHmgww
 (envelope-from <jgross@suse.com>); Mon, 25 Oct 2021 09:54:41 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9f3d40c7-5f3f-4c0a-8428-32388e3ea140
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1635155681; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:  content-transfer-encoding:content-transfer-encoding;
	bh=zuhw31BsRK3OYlO9yFpJVkgPAidWSbJ+Jnf/NuhTprs=;
	b=PqU67S0gWEPpHPUV9ZR8dF0vtFZA/Vx8mRwMyB9K2u8rG7ibxZxQ7LDgWpQfCWkKXYwKav
	irEe2IX+H9FVa/0n6MJ7e9SdlDCfJhEYGAR+V7gZ2ngefX5kdg/FEc8bIUAGu+gwOPmkFF
	iml1kNx/ZjLLvECz84YtziAINQHKjQ8=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org
Cc: iwj@xenproject.org,
	Juergen Gross <jgross@suse.com>
Subject: [PATCH v2] OSStest: explicitly enable building qemu-traditional
Date: Mon, 25 Oct 2021 11:54:38 +0200
Message-Id: <20211025095438.27599-1-jgross@suse.com>
X-Mailer: git-send-email 2.26.2
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

It is planned to no longer build qemu-traditional per default.

In order to be able to continue running tests with ioemu-stubdom run
configure with --enable-qemu-traditional.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
V2:
- set --enable-qemu-traditional on x86 only (Ian Jackson)
---
 ts-xen-build | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/ts-xen-build b/ts-xen-build
index af0dd894..fdf55521 100755
--- a/ts-xen-build
+++ b/ts-xen-build
@@ -144,6 +144,7 @@ END
 sub build () {
     my $xend_opt= $r{enable_xend} =~ m/true/ ? "--enable-xend" : "--disable-xend";
     my $ovmf_opt= $r{enable_ovmf} =~ m/true/ ? "--enable-ovmf" : "--disable-ovmf";
+    my $qemutrad_opt = $r{arch} =~ m/amd64|i386/ ? "--enable-qemu-traditional" : "";
 
     my $configure_prefix = $r{cmdprefix_configure} // '';
     my $configure_suffix = $r{cmdsuffix_configure} // '';
@@ -157,8 +158,11 @@ sub build () {
                 if grep -q -- $ovmf_opt tools/configure ; then
                     ovmf=$ovmf_opt
                 fi
+                if grep -q -- $qemutrad_opt tools/configure ; then
+                    qemutrad=$qemutrad_opt
+                fi
 END
-               $configure_prefix ./configure --sysconfdir=/etc \$xend \$ovmf $configure_suffix @configure_args
+               $configure_prefix ./configure --sysconfdir=/etc \$xend \$ovmf \$qemutrad $configure_suffix @configure_args
 END
             fi
 END
-- 
2.26.2



From xen-devel-bounces@lists.xenproject.org Mon Oct 25 10:28:43 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Oct 2021 10:28:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.215719.375073 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mexDZ-0006s3-Bt; Mon, 25 Oct 2021 10:28:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 215719.375073; Mon, 25 Oct 2021 10:28:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mexDZ-0006rw-8r; Mon, 25 Oct 2021 10:28:37 +0000
Received: by outflank-mailman (input) for mailman id 215719;
 Mon, 25 Oct 2021 10:28:36 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=G2Ub=PN=citrix.com=roger.pau@srs-us1.protection.inumbo.net>)
 id 1mexDX-0006rq-Pj
 for xen-devel@lists.xenproject.org; Mon, 25 Oct 2021 10:28:35 +0000
Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 4e5e05de-357e-11ec-840e-12813bfff9fa;
 Mon, 25 Oct 2021 10:28:34 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4e5e05de-357e-11ec-840e-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1635157714;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=5UHVpvbxo9aGSH86YC6ATiW+DPi/Zal1+tYeb4QXDKc=;
  b=N2o7r5llhuQixcs4LSTiv7feR6C9068zuRMWiEa9tBV3zitxv3ozs701
   jOSWSi4d2BAKMRc6lB82QOXBtf9rixIahOQAm2hM+eg6DL2TGQmkKragG
   EQPBEsQyWA4/NTIfqrFGdIvVkS9djgOfkApM0roRPIWxmT4R9suIfmx3M
   E=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: dp1lQhuESu1f1gcqPbZnKoPGkN7OEfOTtlW3bbdi3EEk7GaTaVqgngHwKGGcimVXykgpYy1trP
 Wpa6GiVABCmHu4jh6JreCgDHGJX5Go4fi+8fdDyUt8XDwp0iOxzXY15rXz5jsM4jKgAEdIWwKR
 BJa6Uey9WbRadM3fgZGEGoy0+0p0Snmib1HRIcttkgdz+lV+i1ct7iwz/rHZJXFgJJ7MzU/uK6
 iyE1yBmjcp/TqkYHUlvXR0Eef0SwuT3asxGH7yL6rIMUbcEgsm3rWeMTtk6WmCxCH3oeSRfUf2
 +JsR+15tNHHNM7QemGVvm8Lh
X-SBRS: 5.1
X-MesageID: 55524042
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:VB2lKKspjjWsjbDtRywVs1d6JufnVLRZMUV32f8akzHdYApBsoF/q
 tZmKTuAOq2DZjT3fNwkOom0p0gB7ZXTzd4wGwE5+SA3RH5H+JbJXdiXEBz9bniYRiHhoOOLz
 Cm8hv3odp1coqr0/0/1WlTZQP0VOZigHtIQMsadUsxKbVIiGHhJZS5LwbZj29cw24ThWWthh
 PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe
 gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ
 NplkZefclsXBrHwv9tNUCNUKhNzJ/If5+qSSZS/mZT7I0zudnLtx7NlDV0sPJ1e8eFyaY1M3
 aVGcnZXNEnF3r/ohuLgIgVvrp1LwM3DJoQQt2sm1TjEJf0nXYrCU+PB4towMDIY250TR6qGO
 5BxhTxHNAmaX0JTfXgrFZdhkf/2rEP2XDkItwfAzUYwyzeKl1EguFT3C/LKfvSaSMMTmVyXz
 kre9nn9KgEXMpqY0zXt2nCmi/LLnCj7cJkPD7D+/flv6HWDy2pWBBAIWF+TpfiillX4S99ZM
 1YT+Cclse417kPDczXmd0Tm+jje5EdaAocOVb1hgO2Q9kbKyyKSKVNYcAZdVPsZ5MwMSQUY2
 0XWxsy8UFSDr4apYX6a876Vqxa7Ni4UMXIOaEc4cOcV3zXwiNps1kyXH76PBIbw14evQWihn
 FhmuQBn3+1L5fPnwZlX6rwub9iEnZPOUhIurjveWmao/2uVj6b0OtT2tzA3ARtGRbt1r2VtX
 lBZw6ByD8hUVPlhcRBhp81WRNmUCw6tamG0vLKWN8BJG86R03CiZ5tMxzp1OV1kNM0JERewP
 hSO4FsJvs4LZCH6BUOSX25XI556pUQHPY+9Ps04k/IUOsQhHON51Hg2DaJv44wduBd1yvxuU
 XtqWc2tEWwbGcxaIMmeHI8gPUsQ7nlmnwv7HMmjpzz+iOb2TCPFGN8tbQrVBshkvfzsnekg2
 4sGXyd8404EC7OWj+i+2dN7EG3m2lBiVMCo8JQMLbDSSuekcUl4Y8LsLXoaU9UNt4xel/vS/
 2H7XUldyVHlgmbAJxnMYXdmAI4Dl74mxZ7iFSBzb1uuxVY5ZoOjsPUWe5ctJOF1/+1/1/9kC
 fICfpzYUPhITz3G/RUbbIX889M+JEj621rWMnr3eiU7cr5hWxfNpo3ucDzw+XRcFSGwr8Y//
 eGtj1uJXZoZSg1+J8/Kc/bznUiptH0QlbsqDUvFK9VeYmv2941uJ3Cjh/M7OZhUex7C2iGbx
 0CdBhJB/bvBpIo88d/og6GYrtj2T7siTxQCR2SCtOS4LyjX+Gan0LRsaufQcGCPTn7w9YWje
 f5Rk6P2PsoYkQsYqIF7Cbtqk/4zvoO9u79Aww14N3zXdFD3WKh4K3yL0MQT5K1AwrhV5Vm/V
 k6Vo4QIPLyIPIXuEUILJRpjZeOGjKlGlj7X5PUzAUP7+C4oo+bXDRQMZ0GB2H5HMb94EII52
 uNw6scZ5ju2hgcuLtvb3Dtf8H6BLyBYXqgq3n3A7FQHVub/Jol+XKHh
IronPort-HdrOrdr: A9a23:rsQMt6qWhlGyS8+4i1wCsOoaV5vNL9V00zEX/kB9WHVpm5Oj+f
 xGzc516farslossREb+expOMG7MBXhHLpOkPQs1NaZLXPbUQ6TTb2KgrGSpgEIdxeOktK1kJ
 0QD5SWa+eAfGSS7/yKmDVQeuxIqLLsndHK9IWuv0uFDzsaEJ2Ihz0JdDpzeXcGPTWua6BJc6
 Z1saF81kWdkDksH46GL0hAe9KGi8zAlZrgbxJDLxk76DOWhTftzLLhCRCX0joXTjsKmN4ZgC
 T4uj28wp/mn+Cwyxfa2WOWx5NKmOH5wt8GIMCXkMAaJhjllw7tToV8XL+puiwzvYiUmRsXue
 iJhy1lE9V46nvXcG3wiRzx2zP42DJr0HPmwU/wuwqrneXJABYBT+ZRj4NQdRXUr2A6ustn7a
 5N12WF87JKEBLphk3Glpn1fiAvsnDxjWspkOYVgXAae5AZcqVtoYsW+14QOIscHRj99JssHI
 BVfY/hDc5tABCnhk3izytSKITGZAV3Iv7GeDlMhiWt6UkXoJgjpHFogPD2nR87heQAotd/lq
 P5259T5cNzp/ktHNVA7dc6MLiK41P2MGfx2UKpUBza/fI8SjnwQ6Ce2sRA2AjtQu1P8KcP
X-IronPort-AV: E=Sophos;i="5.87,179,1631592000"; 
   d="scan'208";a="55524042"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Fykzw09+ShlFS34wtNIzZRAe+kNVWIMdNCw1XsRg4TtXAIN4PhiXQl1QEE2nbIOg/JS4hDDZXvwWt1I00jAv1xd4WnImAVtWaJHEYBdheMRybHondF1sJWViFYctcPSe2Xvam4hnfN1Ize1Q3BCyaN093KAcpdB7V031EYPzp3jSy3v5hRauuqmXMsSn5I2TTD5gYL8Cw8VDY9bo/HUhcEe3XzPNDMRmY8+goxS4bNMKuFbjKsZnyKRcECdqLx+4GXxi/m97d61gZGI85S+8D5SeoOrmTNQvWi4VOQI51r3T5Kr8sIs1GP9RhzQmvG+5z1JTvS++C9LL8ti5/59gbA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=jVjYceLCBK5cDUZH41XgQndwcnXLlc4EB6C4hRmB6Qw=;
 b=FCeOfvv/iK5jfnIFdtO08pRrA3Fzj5R0KJYNvdKkTBzV6Rk6difQmBQlasDvutT2UltUaHWlN+nUPB23aHba2IhzDA/5wgdo83CN8Dfzc530LotP95MZrW7cjPDf9bUbDO2199JAVHQI2us+eadlYM7nrFQV4LKz78kjd5U11jcWeUT3YKEALejbGOWMpfISUYvNGaPYaqJAwtoLaDCBg3+yMThyle1lBoUCC07gbGi/aGbuZZJGbl2Jjs/r7uZO36Ngz/lG0F0VRSUtDl1ZMhlwiGnvrsJOyxi6pdbm9lFnkjC2EhVn2A5Loef3Prd+pEOrkk3pSCQ5qXxvyAbswQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=jVjYceLCBK5cDUZH41XgQndwcnXLlc4EB6C4hRmB6Qw=;
 b=Sgf32TJ26yKiJMWGI5F6MisiehdyeuMIBQNL3iFiK1oMH7eAbSHjj2cUwH9WLsxwW9lqUL2naEmHHvFIC2h8dRS1PYp3YSPYOwS0HzG5AeXrh7cei2TgXn24nMte/j7+LyqaE2YVJinG16IEefhWPxW7I/07/gotxwuWiz6Egcw=
Date: Mon, 25 Oct 2021 12:28:21 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, "Andrew
 Cooper" <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>, Paul Durrant
	<paul@xen.org>
Subject: Re: [PATCH v2 3/3] AMD/IOMMU: iommu_enable vs iommu_intremap
Message-ID: <YXaGxX3J1aB39mSG@MacBook-Air-de-Roger.local>
References: <09137aa2-649f-08fb-ba68-75f8eb16fc63@suse.com>
 <ff7b68b2-5bba-2927-e3f0-f3062862c466@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <ff7b68b2-5bba-2927-e3f0-f3062862c466@suse.com>
X-ClientProxiedBy: MR1P264CA0138.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:501:51::19) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 613bf886-b190-42cf-68ec-08d997a22e9f
X-MS-TrafficTypeDiagnostic: DM6PR03MB4603:
X-Microsoft-Antispam-PRVS: <DM6PR03MB460322250C5F32CA58DEAD618F839@DM6PR03MB4603.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: erUoeE+Xp6FdC0sip4Bm/nvXj9B9cfSNWcA/UGFQQE9qbkbN4W3cqLnBQHyBV3ehLPrn0WEYxNnM1N0jyt5sjIuzE0jcveXqX5inSJ8aoatJVpmuJgQOlsEox4IUwFS+hi8CVILn3DiXt0nQQR31MIE0c2QBpBhMfKV71tn5fW7VzgxrkAek4O4dqV6rA+1FdMhoB2qJ+rlfRdUk+R4oOgoKY3OzLkCG7J6OsEpoiqAaE9tUcWXjtcIcirEcJHHTSqr9hkw85IPRl68Er5xSz5gpSo0q+LlvEFcXwAjWv6Vz6OrfPTL6tY3pNElA8/t8+v+1eFM4JMzsa6wUO7MUOgnQjF6NX32lROVabINJLF1+Zi3n6x7RkC92WGrzrqvnGbC0mMJhpdEWvuLKo6FXGrdgQxw/oVynzfE7b9loawAIdJZxARQKgZchwR4Z0eq895/A+cNW3J6DhFu6RuT4mp3npwPA3sbXCdCeOamZ+hwAkKoUiYI3GFcB8CCYa5p8I4FejJsgInLKhWob2W1+xVMYXtUsuSSu/XdJ/F4N50vtcKo8MIIFHhfveFHF5jxaYJ4X5wpXO9IGhK/DBmhUygMX6GJRyT81CaDvzvWSyc8n1EY+LI/2LdWm8SuQgAdYhHkmq1OBQoXp/vnZmq9ouw==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(956004)(38100700002)(6916009)(86362001)(186003)(6666004)(8936002)(66946007)(26005)(508600001)(83380400001)(6486002)(85182001)(2906002)(316002)(5660300002)(8676002)(6496006)(66476007)(4326008)(66556008)(54906003)(9686003)(82960400001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?b1hRSGZJNVlzU3RMMmt5WXVad01Ybjh4c05hc1dQc0xtSEM2dTNERmhwa05B?=
 =?utf-8?B?bG40aHVCUkpOWVVhNUJzempUNkpRTFh1Sk5nTVVsTTI5eUJ6Q2lKN3NNZXFJ?=
 =?utf-8?B?c3hVY0pZRk1WbGY1SlczalExVk1qUHdiS3FLY2FpR0pldmlUdElSYkIrWmZT?=
 =?utf-8?B?dnVBRDRNSm1SZkdIL2p2WDFncVVGcUhXOW9pU3ZaNnFTaGd1dVJTVEtGUFh4?=
 =?utf-8?B?WThmSU9lZGlXZTJIZjZvUmNtbU12WlFXbXdNdWNoZUg0MVhaSWptVC91dGM5?=
 =?utf-8?B?UkR4TTJmWlR2cDFHc3VWdVJQdFY2dmR2K2UwUC9uRFE0U05iNlNkYzFRWmxI?=
 =?utf-8?B?UEZPNTZRZW5GbDNEZm9INE1yb1pvUjVQUjFjSlNDeWlTRWxvRk92MUFVSWxO?=
 =?utf-8?B?Z3VCVjBYaDBIbnN0WC9iUUxsZ1BNYlBESEJuM2ZyMkdwTnFSbXdQakdRazBW?=
 =?utf-8?B?Z2VYT0g5ekFzQ2FpK2FlejJ3d3RPWHQxOU1OSzZUa0xYZjV1MnVEb2llejZt?=
 =?utf-8?B?QjFFY2xIc0wreWdjcFFNMjJieWlpamQ1NzNkMno1aS8wRkVYTTRNMFdEWEI2?=
 =?utf-8?B?b3ZMbGlmanY2aW9DWm84RnllQ1BtcFlJYitEazFyQk5qbUllbGRDNENQaCtT?=
 =?utf-8?B?c1I1T09lTjlscjJmQ0pSVTk0MVdhMTlEdnpaNkFEcW9NVE9HNnNLbTZJWTFy?=
 =?utf-8?B?NjNCVkMyLzVzVkQ1aGhRYUQvc05RUHBkZXZ3T3l4N3phR0JUOVp2bllIUzBD?=
 =?utf-8?B?cXQvMklaMm1qVzQzZ3dFSFBCL1dJVUhLbnYxSDE1ZlBJUk5EdFdaMEtLeXAr?=
 =?utf-8?B?clpOUWNnd1ZSczhjMUo5SS9KaDU1SkQzaUhMN29TSFk3M0d3M1JNOElBZCtK?=
 =?utf-8?B?Tk9PeS9jV2ZBVS9kRVI0L2duMXJEa1BMMFFPMXJTQjdxV2djK09MRHRrZjBU?=
 =?utf-8?B?dE0xQ0h0SENNZ0xMOWt3aEtYUmxJWm4wSlBpMHYwT0QvOVZLcFQxMmFQek1p?=
 =?utf-8?B?MjhJaGVtVHg2cWt0ejZBdEx1cWtBMjEwZWxITTFWN2NuYTJUeVVRV1dvRTdU?=
 =?utf-8?B?V1BDOGlWcmtkQjVlSjh0T2JacEVZemxsY0ZOQllheGp1N0RGdEE5c3hJSHM5?=
 =?utf-8?B?c1N0RU5FdnZ3c04rRXpCUXRaazh3VSsxd2dnWjM2UDM4SmkwZnpBL1RWYU1k?=
 =?utf-8?B?Y3R1T0haUTVIQzlZN1V6ZmZUU3U0UklaWHRCUzkva1FLa1IyNVBHd29lcFdN?=
 =?utf-8?B?TGtKOUU3VFJpKzdSa3ZOU1VoK0kvZlRNcno0V3JrYkh3N2JBamw0MEVsaVdx?=
 =?utf-8?B?UjRBQ0ZZK0RVMkpscUkxOE44OG1UQnF0d0RhVkgyRUpCOFNJZlhnTTVUcTBv?=
 =?utf-8?B?WWprOVo2VlgwTXU5TzBYbGVTTWdqY2pBaVpOWkh5bTdXWUEzYVRMd1laME1u?=
 =?utf-8?B?ZzFnK0lUeUVydHQyK0RMSTlFOTRsZTQ5ZnhCN1F4bm16OGpQbUo1ZGxkNlNu?=
 =?utf-8?B?TEtvREhjNktsZmFMdnhXSWVDV05uMmNwQWVCcktYWmJhb0FiLzZxUUhHT2hO?=
 =?utf-8?B?c1lyS2x1cGl4eVd0Qnh4SzNoNndMZzZWRGhXRVVlR2g3aXBZVm9STHhvV2RH?=
 =?utf-8?B?MTFkSGlxQ1dnQVJvREtHNHpMcERJZVNPVlkzdSsxb1lVMTJLVGFucVJuQWpB?=
 =?utf-8?B?YTY5REFiZzdLUHZNSktyaVJ1UmJwSzR6RnNncGIzOXBUVUhRSHo2YWExMUFH?=
 =?utf-8?B?ZTkvcmxCRXN1WWhXNjB0eGpPYXR3cDFGclJRbTdJWVdiZGZiVHVZc1pROVVK?=
 =?utf-8?B?Z3dMTEkwa2lzSVdMQ2pEbWE2UmZBdDcvTytacXhnaG5Tb2wrWFZOSjZrWkIv?=
 =?utf-8?B?QndWN0pEYVhUZGtpRWNxYWN2YXE3WFZFQVVMZzhlajBHMkczdWc1TWFPQ0xR?=
 =?utf-8?B?UzJkZkVHSmJrbmJ6dW9lWnYrTmR2RW0vTXVoSUhsSktWMGpTY0RNU0pQYXhC?=
 =?utf-8?B?Q3IwZGJlbDZhMFNVZzFVWGhpNXQ2bm9ySXVSYXlCWjdhRWpxQnhQMWZaUFE4?=
 =?utf-8?B?UTNjV1ByL0x3UzlDakgwbFV5ZTlpNnNZaW1sWC9Xei9uUlB2Z3YrS0tHRzVi?=
 =?utf-8?B?Qng3SFkvMnJuTmF1MkxZU25uclYwTkRFU2pYZjBVK1BWejlHMjJWNzZwVTRt?=
 =?utf-8?Q?YadLPNVPjt8k+8KZI3AYp6g=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 613bf886-b190-42cf-68ec-08d997a22e9f
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2021 10:28:27.4521
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: NkIwaxD15YzCfZVviQ3QSXLSYiPSeAvtH27hclQ+lQ9RNf1Z9dLfQ5fJVyVRBvi4WE6MS3fb+8Q0kJCl6hHmEQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4603
X-OriginatorOrg: citrix.com

On Thu, Oct 21, 2021 at 11:59:02AM +0200, Jan Beulich wrote:
> The two are really meant to be independent settings; iov_supports_xt()
> using || instead of && was simply wrong. The corrected check is,
> however, redundant, just like the (correct) one in iov_detect(): These
> hook functions are unreachable without acpi_ivrs_init() installing the
> iommu_init_ops pointer, which it does only upon success. (Unlike for
> VT-d there is no late clearing of iommu_enable due to quirks, and any
> possible clearing of iommu_intremap happens only after iov_supports_xt()
> has run.)
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> ---
> In fact in iov_detect() it could be iommu_enable alone which gets
> checked, but this felt overly aggressive to me. Instead I'm getting the
> impression that the function may wrongly not get called when "iommu=off"
> but interrupt remapping is in use: We'd not get the interrupt handler
> installed, and hence interrupt remapping related events would never get
> reported. (Same on VT-d, FTAOD.)

I've spend a non-trivial amount of time looking into this before
reading this note. AFAICT you could set iommu=off and still get x2APIC
enabled and relying on interrupt remapping.

> For iov_supports_xt() the question is whether, like VT-d's
> intel_iommu_supports_eim(), it shouldn't rather check iommu_intremap
> alone (in which case it would need to remain a check rather than getting
> converted to ASSERT()).

Hm, no, I don't think so. I think iommu_enable should take precedence
over iommu_intremap, and having iommu_enable == false should force
interrupt remapping to be reported as disabled. Note that disabling it
in iommu_setup is too late, as the APIC initialization will have
already taken place.

It's my reading of the command line parameter documentation that
setting iommu=off should disable all usage of the IOMMU, and that
includes the interrupt remapping support (ie: a user should not need
to set iommu=off,no-intremap)

> ---
> v2: New.
> 
> --- a/xen/drivers/passthrough/amd/iommu_intr.c
> +++ b/xen/drivers/passthrough/amd/iommu_intr.c
> @@ -731,8 +731,7 @@ bool __init iov_supports_xt(void)
>  {
>      unsigned int apic;
>  
> -    if ( !iommu_enable || !iommu_intremap )
> -        return false;
> +    ASSERT(iommu_enable || iommu_intremap);

I think this should be && in order to match my comments above.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Mon Oct 25 10:34:39 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Oct 2021 10:34:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.215726.375085 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mexJG-0008FW-1I; Mon, 25 Oct 2021 10:34:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 215726.375085; Mon, 25 Oct 2021 10:34:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mexJF-0008FP-U2; Mon, 25 Oct 2021 10:34:29 +0000
Received: by outflank-mailman (input) for mailman id 215726;
 Mon, 25 Oct 2021 10:34:29 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=G2Ub=PN=citrix.com=roger.pau@srs-us1.protection.inumbo.net>)
 id 1mexJE-0008F3-US
 for xen-devel@lists.xenproject.org; Mon, 25 Oct 2021 10:34:28 +0000
Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 20d82b3e-357f-11ec-840e-12813bfff9fa;
 Mon, 25 Oct 2021 10:34:27 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 20d82b3e-357f-11ec-840e-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1635158067;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=YSZi544C88Nob1tjO1skucxBbOSO6+3t28tJj+zrt4o=;
  b=XzYx2/ggawu5Pyr9d9KEe53uK3CMg2keR4+vH6FUUzxKP6INa12zFiG0
   Nt+WVjGHhoDhCSqCAdCHnHtank1pDrbwr4IkYMF1r4UqmNXHuy9Iut3+X
   71OCg2vyPpkh1Harn9DZ2rzh0WJnGAoCIGl1MTV9sBHfkLDYZ9h572zUC
   o=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: r8OzRXnAKkJn5Mwq6kkVEDgq/2g/ne2q9Y3pWvy45Rx9Zj0xztka3/6YnrtfrXJ+juHRO+0jLK
 N03/wMTN5PxJgvDNjHY23qmeygEjGlGILm16hNR7G7ksho+G6E1930n8Ad6enM4IePcYlc8mk1
 EtGCWhB3lR4KOSW+WC6aTLYgNyTYg08Vr+/1bcjHtOYPJkEYoKApUPyMpF3frmePEAs/qb+89z
 QTDYaZ48X4viRZACx+35aMmMbqfoTgFCWzgQsPc5dXwQ49kXbA6hSMHoBH42yazfEBSmuRe2ki
 1bjhSV6z5y+KmhpveQkIrIif
X-SBRS: 5.1
X-MesageID: 55968715
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:So8QOqvNaXfTSO7d/GpZdOHFDOfnVMBZMUV32f8akzHdYApBsoF/q
 tZmKTjTP6zZMzHxf9h3OYXi9k8AupDRzNU1TQA/+Ho0QyxG+JbJXdiXEBz9bniYRiHhoOOLz
 Cm8hv3odp1coqr0/0/1WlTZQP0VOZigHtIQMsadUsxKbVIiGHhJZS5LwbZj29cw24ThWWthh
 PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe
 gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ
 NplrsW8dAgUD6jwnadCVTd+CX1DOopp0eqSSZS/mZT7I0zudnLtx7NlDV0sPJ1e8eFyaY1M3
 aVGcnZXNEnF3r/ohuLgIgVvrp1LwM3DJoQQt2sm1TjEJf0nXYrCU+PB4towMDIY250fQ6aBP
 pdxhTxHXCbAPj5fEFotJI8sh+b1uF3/VjcfgQfAzUYwyzeKl1EguFT3C/LefdmPRNlJk1yDj
 nLL+XzjBRMXP8DZziCKmlq8i+mKkS7lVYY6ELyj6uUskFCV3nYUChAdSR28u/bRoky0Vs9bK
 kcU0jEztqV0/0uuJvHmRAGxqnOAuh8aWvJTHvc85QXLzbDbiy6VG24ARyZOQMEjtcQ2AzEmy
 ze0c8jBXGI19ufPEDTEq+nS/Wja1TUpwXEqfnYIcAQ40tzfpcJsiDzpVIpeF4map4igcd3v+
 AyioC87jrQVqMcE0aSn4FzK6w6RSoj1oh0dvVqPADr0hu9tTMv8PdbwsAmEhRpVBN/BFgHpg
 ZQSpySJAAni57m2nyuRXP5FIrit4/uUWNE3qQ8yR8d/n9hBFnjKQGyx3N2cDBoxWirnUWWwC
 KM2he+2zMQLVEZGlYctP+qM5z0ClMAM7+jNWPHOdcZpaZNsbgKB9ywGTRfOhD20yBB2wPlnY
 8fznSOQ4ZAyU/QPIN2eHL917FPW7npmmTO7qW7TlkzPPUWiiI69Fu5ebQrmghER56KYugTFm
 +uzxOPRoyizpNbWO3GNmaZKdAhiBSFiWfje9pwGHsbec1EOMDxwVJfsLUYJJtUNc1J9zbyTo
 BlQmyZwlTLCuJEwAVzbOi44MOi0A8cXQLBSFXVEAGtEEkMLOO6HxKwea4E2bf8g8ulixuRzV
 P4LZ4OLBfEnd9gN0251gUDVoNMweRK1qxiJOib5MjEzc4Q5H17C+8P+fxup/y4LV3Llucw7q
 rym9wXaXZtcGFgyUJeIMKqinwGroHwQuONuRE+UcNNdT1rhrdpxICvrg/5pf8xVcUffxiGX3
 hq9CAsDobWfuJc89dTE3PjWr4qgH+ZkMFBdGm3XseS/OSXApzLxyo5cSueYOzvaUTqsqqmlY
 OxUydD6MeEGwwkW49YtTe4zwPtntdX1prJcwgB1J1nxbgymWuF6P32L/chTrakRlLVXjhS7B
 xCU8d5ANLTXZM68SAwNJBAoZ/io3O0PnmWA9uw8JUj36XMl/LeDVkkObRCAhDYEcelwOYIhh
 +wgpNQX+0q0jR9zaoSKiSVd9mKtKH0cUvp46sFGUdGz0gd7mEtfZZH8CzPt5MDdYtpBBUAmP
 zuIifeQnL9b3EfDLyI+GHWlMTCxXnjSVMSmFGM/Gmk=
IronPort-HdrOrdr: A9a23:Dko7bKuju3LZHZY7t0L+1t9Y7skC7IMji2hC6mlwRA09TyXGra
 +TdaUguSMc1gx9ZJhBo7G90KnpewK6yXdQ2/hqAV7EZniahILIFvAY0WKG+VPd8kLFh4xgPM
 tbAs1D4ZjLfCRHZKXBkXiF+rQbsaC6GcmT7I+0pRcdLnAbV0gj1XYANu/yKDwJeOAsP+teKH
 Pz3Lsim9L2Ek5nEfhTS0N1FdTrlpnurtbLcBQGDxko5E2nii6p0qfzF1y90g0FWz1C7L8++S
 yd+jaJqpmLgrWe8FvxxmXT55NZlJ/IzcZCPtWFjowwJi/3ggilSYx9U/mpvSwzosuo9FE2+e
 O87isIDoBW0Tf8b2u1qRzi103J1ysv0WbrzRuijX7qsaXCNXsHIvsEobgcXgrS6kImst05+r
 lMxXilu51eCg6FtDjh5vDTPisa13ackD4Hq6o+nnZfWYwRZPt6tooE5n5YF58GAWbT9J0nKu
 9zF8vRjcwmP29yV0qp/VWH/ebcHEjaRny9Mw0/U42uondrdUlCvgslLJd1pAZFyHo/I6M0kd
 gsfJ4Y042mdfVmH56VMt1xNvdfOla9Mi4kD1jiVGgPNJt3c04l+KSHq4nc2omRCeg1Jd0J6d
 L8bG8=
X-IronPort-AV: E=Sophos;i="5.87,179,1631592000"; 
   d="scan'208";a="55968715"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=jvJ2v8M6GQ51E1wJ0vNjXZyBWyrWCD2wTzAcnN2iI6z5FpZUoixjYnfxIDcP2UWE5U2AnUMBItmSUqWuoDQluebjvDZgpsazKOFT7jeYiSt8TZmc2SqOitCtrREHuSCQThJZr1xOqmqcScIzEFTmnMJGV2Vb+oFJw3w2C7awE50sALg7SOVdwilj+iqyh7L3OaVRAmSsqr1/Ffc1oOEuqhhB/sjt+HHCbY6veI27ESB/rd1V7w3cjC/QE5kvtUJuTCYkVQIDY+FFC+EYI5bT6qCvzlv92o3Qui6nR0VBv5vINv9a+clNWmQkG5RNYLqYJIF5mEyxE7c06zgxMVscYQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=8nCphM0qehXxLpXMY94FrGKziRSZo2a3YJeA1Xj3s1I=;
 b=avifw8CMJLvcr0VeqtuDhwHWnadIq28VVzjFOQxpIiQyL7Ve+mCmFiq2El9F08YCJgg3Kk3muN6TD8lxJxxGHTXaryz+ZYqjrkeFeVoayDHG4FFGuHnZjqsa2e9YR0TBcyJRrV9Zx3VElmw9iwxUpWPSxZ5rDSU1S2YiewOCuULUKBEH7+Q87o+MyHzYfTlvItOugzKnZ2IEkpJ+7YVbCLn3I5IQjnlwZO0yTQsKFMEkt4DaBbREw0elOICD8Cuh337mJYTvDdece/4SAn7wX9fAWcWAB46jkoqeeRH2/tjF1PWEyGfgsQZfZGNalFXi4g1uyWteuGpEmZq22ish6A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=8nCphM0qehXxLpXMY94FrGKziRSZo2a3YJeA1Xj3s1I=;
 b=heUb22s5LuDe34sjJdO2e36kyWySnsqzk+BSw/CsmT+dGyz/Pv47zr5s5vsA29mK0OhQ3KiWZZgqeh6KPgOznOVc9sYBPrlNqJnkADRo9nyetL5UNK8rO2Hq6o8liKMWKNFiBcBMWu6FEAXelhZqqa1Xt6Lq3cKobCU064ANeDk=
Date: Mon, 25 Oct 2021 12:34:17 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Stefano Stabellini <sstabellini@kernel.org>
CC: <George.Dunlap@citrix.com>, <dunlapg@umich.edu>, <jbeulich@suse.com>,
	<committers@xenproject.org>, <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH] governance: communication channels
Message-ID: <YXaIKZD8g6kQukhF@MacBook-Air-de-Roger.local>
References: <alpine.DEB.2.21.2110221535000.2311@sstabellini-ThinkPad-T480s>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <alpine.DEB.2.21.2110221535000.2311@sstabellini-ThinkPad-T480s>
X-ClientProxiedBy: MRXP264CA0021.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:500:15::33) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: f66c1f1e-c187-4782-3f1b-08d997a3025b
X-MS-TrafficTypeDiagnostic: DM6PR03MB4763:
X-Microsoft-Antispam-PRVS: <DM6PR03MB47634EC415F0A4D01C41F4E38F839@DM6PR03MB4763.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: i4pOzQoONUHfZO+9Wr4QdnmJPLc0E7uc9nrjPJGf4jeT6/6SQvCob7z2PcMOwFsKDXasn1KOIDPZHEMFYb40yRqFKrV6rod8vgR3+CE7XKG5pN2lyiYTJXQFGNUGqPVtprTTFIQ2Ply/QYTr3JDWWSN0zcwXHRwSTCmk2B0nzE8pEqeIKWzPvTkh4atQhPhNwnbsxewTohl6yYIPrDhs1LxlA4iXBkxJ2gFiLJHkuh/qkRvm/s/kZ7HhVwfH8wIsv11GV7lCeF/g/o6f42/hgFlMu6rt68816sXpGALv6fqBbl52TZV2tUnn3IdF4Lu8X0eIr5wM9GcanderBAVSn4czwyuplp668CT5ndXZCmssYc/cATz7FDp4qYJpGP1+G/dYDd+7QopvzQUPiF+Z3OvqC5svFbnDa4fFaIwjnbbPfrxWMOYwvzSEmRrKZgw0W9x8QgzUcF9PI4Htfw13nTiI2d6WvFo7pCflTDqa3tdIM8qdyOyC3i3ih4X5/Q7GOuOPYa1goluUeb2qwDpfHMToQbuf3DAkS7yV259jaYydMN1qMB4KC0LNZ6HjTWWmkjQxy+PqDT2PJ+2WSPlEkRJYZaAw911HbBOgKUhhPX/RiUrMoUKbzjD//+bO3/pjfoDtMQ1/hMfmL0T6nzBeyA==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(316002)(5660300002)(2906002)(8676002)(83380400001)(6486002)(85182001)(4326008)(9686003)(82960400001)(6496006)(66476007)(66556008)(6916009)(86362001)(956004)(508600001)(38100700002)(26005)(186003)(6666004)(8936002)(66946007);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NkIybTIxRDlrVmVoV29zWitudjkvTDlGck1HdmkreWR1d0hiYi9wL3REN2d1?=
 =?utf-8?B?QVFRdk0xZUYwYzR5SDlrMjVDUVZabDdPanJENkl6MGdScE9NUDJ1RmZmR2Y4?=
 =?utf-8?B?S1hOMnRFYlMyYjV1RGUwUzNHVE1HaGk4RDFwaEJGZHBwTjN2aXdFdFNIT3Ur?=
 =?utf-8?B?Q0h6N0FPYy9TVEdyTllvY3ZwU25SanRSNVI0SVNjWkpnUFpkK0xraDBZdksz?=
 =?utf-8?B?NlBIMy9YcVpZM0xtL3AvUHZmYmlkTnlXcncwSkM1NFN6dkRWMnFXWUUzdjIx?=
 =?utf-8?B?ZzUyUGtlNEdseHFXUmR2QUNpK1R4Z0NOaXNWVmdwT0twcTBoTi9walZPTlo2?=
 =?utf-8?B?bDNPNjVHcW5ScVc0NkRVdHZhclpSYjkrY0EvWXdQQ2Evc2JFODhSbVI2Y0FE?=
 =?utf-8?B?VExLQWJBcFl2Q1hNcWNQbUZwMFl1UTNFWWxOQ3N5QWZZS1Z0VDdKOVpqdkM2?=
 =?utf-8?B?RWlhUkQ2ejEzYy9jSzVYYlNZWjdCejRCRXdzSWI5UEZBNHBMRmNLZy9jSjNU?=
 =?utf-8?B?cjltcmtxN0NJVGxmVTBNa2Nxakp4WkQ3MHJPMDZZSk03Z041RVhrRE5XUVZj?=
 =?utf-8?B?elRrOHdrUzhzMS9ZUFg5UGZvUTIrN1RFS1drUm02QS9iVDlTb1g2Si9wWTdV?=
 =?utf-8?B?aVlKNU4reTI1QXk3aWY1NnRldVlEamJNMm1MVXE3cDY3dHhtOVdaY2h4bXRa?=
 =?utf-8?B?ellUUGM1NEQ1VWlMSllTTjFKbk9IT0JEdEg3YUNhNlFHZG1QQzBWd1J6bkNp?=
 =?utf-8?B?ZkhzbGZHVkVIRlhmN2lLbm9IS09sS003RitmYmpyR29MbDJsM01CRGRwM1N2?=
 =?utf-8?B?VzBQSGE4U3pIK0lsSGR1eXQ4RVFjTXpVNHVUQzQxZnduL3p1MHpjZTM5TWsw?=
 =?utf-8?B?STJtUG5ORHFYb3E1N3F5dmlvTGtqTE5VWlJoL1F0V0l1WlNSOUYvbFhNMHBI?=
 =?utf-8?B?UVVTUCtHUGYxaHFiYit5T3diOHgrWnQyL3BVZ2J6WVZXTkxCU281VTJ1TmUw?=
 =?utf-8?B?Zy8wQXNnejlkUUx2WDBRZTVCZWVWRDVMakNOWWRWTElxU2VLMnpHWW1NdnlI?=
 =?utf-8?B?NXMveTliNG1KZktqb2EweG5KNnRRbVgwWFpYV3lCYUx2ZEhaY3pPQkozVnJq?=
 =?utf-8?B?ZGxGUEtTa0tNbmFMamV1VXphSVlac3NtZnBKYzB0ekNmN2tpcWdRd0sxOE1O?=
 =?utf-8?B?UDBteXlwVHRGQjBrRWJrZjIxME9RYjJSUU5pc3Y4WVozbmFWaUlYS3FxUkJi?=
 =?utf-8?B?ZWozZW5uSG5jTjA0Wm9zZm81RXFOdXFCSi9Pc041MlZLaUVWRkFLNUxZZWRH?=
 =?utf-8?B?Ulg3ZUZLdVRuQjhia053cUwvT1pMZ0YyZzR6OS8xNW1kRDBvUjJoKzNTUllr?=
 =?utf-8?B?NUZPaDYvcGg4WnhySVJjQm11di9JbzFZbklseEpmdDkxRlNZelVyVnlNbnZq?=
 =?utf-8?B?VDRQY3BZQkhtVi9nbUlIYzNnNStvWlRYYnl5aVlja1I5UXZZOWlsUjY5NWNh?=
 =?utf-8?B?enNsU3JhZzM3Lzl1c2NMZTYyMmxqem41VC91ci9xL2hmb2tkcHVwMkRqcURP?=
 =?utf-8?B?N2U3RzFJL1lpY2VtcDNSUVNaTEs1MzUrZ01YaE80WDRxMDdNNWNPbFNMb1R2?=
 =?utf-8?B?TU8xRnJVU09iMWs4QjZaV0FVUStvckpuY1M4Tzd4bzBhalh1d1VpZktSeWtL?=
 =?utf-8?B?UTIrRlAxVTYyTWlVNlNUSEdvckhwcVB2YkMycTZlQ3QrZjU4cmJ3anRsV01H?=
 =?utf-8?B?YWpMT2hVWkY3cDYxVk5lRFE1ZmQrYzQ4VTB1d1huNkIzbkMyWWZ2NTlxRW5k?=
 =?utf-8?B?MGlyUlR6eFBnaEFrSVhTazVYanEwUHpkYVBGZGF4MUIrQUtqWEp2OFppOHZY?=
 =?utf-8?B?cVlFYkZneTgxckpzNjE0MjVlZ0dnWkduZ05qYm85aXU1SHNqVVljRVNHOVk5?=
 =?utf-8?B?ampJZTZZR2YxWXZscGpSKys5Z0k4MG55VHBMYmFJb0lpUmdqU0tzdVJRUzBm?=
 =?utf-8?B?WldjUk51MHppYXFTdGJGazFXTE40R3hkNXVtKzBaZGhCeVNnT0FCUTJkTzBB?=
 =?utf-8?B?Wm5XMWNRT0NqVG1pcHQxNHd3UGgvc0g5eHB4djIzSG9tL0hxOFJhQ1lneCt2?=
 =?utf-8?B?UXRGQ0ZINFp6anlOQ2czSnJQN3VQcXQwWURUOUlKQ2xTSnZZRTZBbWo4cVJN?=
 =?utf-8?Q?13c+JZsC7NHVRYH3lPk3Sds=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: f66c1f1e-c187-4782-3f1b-08d997a3025b
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2021 10:34:22.6714
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5swE7Z9DCMH3bo1bsa9qTg/rc1T/7qJ5yAQvPHSMm8wKUjGhlxSEDso59NORYnMzy0LtrBYH+YRFbU1TGZXAiQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4763
X-OriginatorOrg: citrix.com

On Fri, Oct 22, 2021 at 03:59:51PM -0700, Stefano Stabellini wrote:
> Clarify that xen-devel is the only official communication channel.
> 
> Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>
> 
> diff --git a/source/communication-practice.rst b/source/communication-practice.rst
> index 70f5b8c..356df7a 100644
> --- a/source/communication-practice.rst
> +++ b/source/communication-practice.rst
> @@ -9,6 +9,22 @@ This guide provides communication Best Practice that helps you in
>  * Being aware of your own and counterpart’s communication style and culture
>  * Show empathy towards other community members
>  
> +Communication Channels
> +======================
> +
> +All important communications and messages should be sent to the
> +`xen-devel <10_>`_ mailing list, which is the only official channel for
> +code submissions, acks, code reviews, and decision-making.
> +
> +In the modern connected world there are several other communication
> +channels available at any given time, including online meetings and IRC.
> +Xen Project has an IRC channel named #xendevel on the OFTC network where

I would avoid mentioning #xendevel and OFTC explicitly. We had to move
networks recently and it's easy to miss this instance and thus become
stale.

The rest LGTM.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Mon Oct 25 10:55:58 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Oct 2021 10:55:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.215735.375096 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mexdw-0002DU-V4; Mon, 25 Oct 2021 10:55:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 215735.375096; Mon, 25 Oct 2021 10:55:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mexdw-0002DN-Rl; Mon, 25 Oct 2021 10:55:52 +0000
Received: by outflank-mailman (input) for mailman id 215735;
 Mon, 25 Oct 2021 10:55:50 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ol/l=PN=gmail.com=wei.liu.linux@srs-us1.protection.inumbo.net>)
 id 1mexdu-0002DG-QL
 for xen-devel@lists.xenproject.org; Mon, 25 Oct 2021 10:55:50 +0000
Received: from mail-wr1-f51.google.com (unknown [209.85.221.51])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 4b020c5a-c6c8-4d66-99bb-25b767d978ef;
 Mon, 25 Oct 2021 10:55:50 +0000 (UTC)
Received: by mail-wr1-f51.google.com with SMTP id v17so10763708wrv.9
 for <xen-devel@lists.xenproject.org>; Mon, 25 Oct 2021 03:55:50 -0700 (PDT)
Received: from liuwe-devbox-debian-v2 ([51.145.34.42])
 by smtp.gmail.com with ESMTPSA id i9sm11898253wmb.22.2021.10.25.03.55.48
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Mon, 25 Oct 2021 03:55:48 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4b020c5a-c6c8-4d66-99bb-25b767d978ef
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:date:from:to:cc:subject:message-id:references
         :mime-version:content-disposition:in-reply-to;
        bh=sXc88nZOdpcAQ5BmBbT1tLuOWdfYJcmABBeYACUNHPk=;
        b=KRVM/tLsWBxmqsxDiSeCs367cfEE9m7/HUcoMI9jEsQUSYkAH62kvQzbUXBrYHWCYN
         Lgs6obgqdM/OGpPmtqjlFrsmqr+eOr9zMRlM5AKgBuqyvTYdRLhdL0V+eI4bAe6v+Ier
         rX+zzalHqcnoDGRnpLUybx3n8ZwVRGr/0j9UyDl+o0FMLRKJUm8F+pLxShjySU+KOLmT
         /w5yPjBmOSUdHjM9dBsxrdMaE4I3xrCRDkxECNLqH4e/EGO6JiHscMrgnmPxBZ7aLN7i
         YnnKrukY80tx3ACg7ZAb52Ia+5pChXorY62B/F9afDyxH1QhLcya8POUMY+/02C0pHhb
         qrZw==
X-Gm-Message-State: AOAM532oZR0jkJfoJFr0TljynfvokponmCDxO5SkEFUXQbAPFWyBi6ay
	2hvYu1iD9QyDaw5S9A6SVF4=
X-Google-Smtp-Source: ABdhPJzEF0JvURt5NGWDas8A4vP05aaqlxtc0/bJyQQcRIs49zfFl+1/SUkK+VBL1tNg4p0jUqJRYg==
X-Received: by 2002:adf:efc7:: with SMTP id i7mr18741951wrp.410.1635159349243;
        Mon, 25 Oct 2021 03:55:49 -0700 (PDT)
Date: Mon, 25 Oct 2021 10:55:47 +0000
From: Wei Liu <wei.liu@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, wei.liu@kernel.org,
	paul@xen.org, boris.ostrovsky@oracle.com, jgross@suse.com,
	sstabellini@kernel.org, xen-devel@lists.xenproject.org
Subject: Re: [PATCH net-next v2 01/12] net: xen: use eth_hw_addr_set()
Message-ID: <20211025105547.bmmowslozg2mdjdf@liuwe-devbox-debian-v2>
References: <20211021131214.2032925-1-kuba@kernel.org>
 <20211021131214.2032925-2-kuba@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211021131214.2032925-2-kuba@kernel.org>

On Thu, Oct 21, 2021 at 06:12:03AM -0700, Jakub Kicinski wrote:
> Commit 406f42fa0d3c ("net-next: When a bond have a massive amount
> of VLANs...") introduced a rbtree for faster Ethernet address look
> up. To maintain netdev->dev_addr in this tree we need to make all
> the writes to it got through appropriate helpers.
> 
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>

Acked-by: Wei Liu <wl@xen.org>


From xen-devel-bounces@lists.xenproject.org Mon Oct 25 11:24:54 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Oct 2021 11:24:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.215746.375107 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mey5x-0005MQ-DX; Mon, 25 Oct 2021 11:24:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 215746.375107; Mon, 25 Oct 2021 11:24:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mey5x-0005MJ-9q; Mon, 25 Oct 2021 11:24:49 +0000
Received: by outflank-mailman (input) for mailman id 215746;
 Mon, 25 Oct 2021 11:24:48 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=1v/+=PN=epam.com=prvs=0932af52eb=oleksandr_andrushchenko@srs-us1.protection.inumbo.net>)
 id 1mey5w-0005MD-CW
 for xen-devel@lists.xenproject.org; Mon, 25 Oct 2021 11:24:48 +0000
Received: from mx0b-0039f301.pphosted.com (unknown [148.163.137.242])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 3beafa70-963a-47b2-a16e-d18df76c5852;
 Mon, 25 Oct 2021 11:24:46 +0000 (UTC)
Received: from pps.filterd (m0174680.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 19PAVQAd003358; 
 Mon, 25 Oct 2021 11:24:43 GMT
Received: from eur05-vi1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2169.outbound.protection.outlook.com [104.47.17.169])
 by mx0b-0039f301.pphosted.com with ESMTP id 3bwrnq8tas-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Mon, 25 Oct 2021 11:24:43 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by AM0PR03MB3876.eurprd03.prod.outlook.com (2603:10a6:208:73::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.16; Mon, 25 Oct
 2021 11:24:39 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::c038:e032:595a:651]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::c038:e032:595a:651%8]) with mapi id 15.20.4628.020; Mon, 25 Oct 2021
 11:24:39 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3beafa70-963a-47b2-a16e-d18df76c5852
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=dL6RFZYShmXXOAcNYGtygEqasjp9QiegZRnLhTsrt+w4ODwSqw+avu2ScfZ2O6Bom51/pG79zcTOI3rDGMrMmN+0+583fzTlAIMKntXeulyIGl/pNgCtkOFF2T6q3OSEpwFw9aaXieYE6APXLFoFIeZ0NhpqnlI9sWc7wXPd8fjQAa8LN7trW/r0Ep90B3pWqMKPXb8uHJmhEYqC9YncLSY9pBpKbuN3u7JB/a//G2WCldkIkTfVkVGgxYGKrGw8h/QSsQxdjPkO7uwap2yZ2YgvxEoZ4i1txhioX1U/Ow/mJKLsfIyXb7JDRvMJbIQV27hHssipk24jD1KKqZiG6Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=w/484hsSJzkabnWquya02X52W61kZ2EZqFyBuKAlHgg=;
 b=cYQLmW4NxkkcW3humPx2pfd3OjajeQtEwMuDAfalKr5IjxqIr+YVJbTEe1L1bbwwickfDRpZzSGxbrbIaQ/M2hTMTLrWXgoci7lPPkVusxWbOL+nygdLksZCA6kNx81V8yJFBiEBXoSGrfrCV9pVqpvSwXknhD2PNYEre27BG+RauO2pHPRxZaeHib1Acbdml6SOL0DfF+C0l4nxm707yRY3yXmY70QRd9Smx0NA1wlptME0N3wdBRl3ZJGouybrWRPAn5vN4WCpqhs9P0BxDh29sqnf8M0JeSWoj3bUlYkHcqK0G0ASDCiy1nIpBdgx+x8AxwK+A6jA5LWYk6s72A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=w/484hsSJzkabnWquya02X52W61kZ2EZqFyBuKAlHgg=;
 b=ZADLsEwj5wnwHS5/ow67t+LsjJS8JT95iwEg/9QEaEMHHyqICGwgz9BLQiDG5PCdQJL6/4Di5Axwcvjbks8E9IPSKs7PG813UZ6w2oC0odIny5evrMQ3m5CGboCXgeuB4fPjjGvQGijR+ecd498DRESzgVtNU887LVVN7f5pbQIYNBmbUB5BTSGI6vyotooAT/Lkq5+syJZuvRYTFUDJHarfwxks1ZPcUgfAxDSapYOIFonpOJU+zYpaaSWctv6FTjrzbSaBNzW14PtScnFhjZIPq0jFokWIun5/92Kr8WjIgxXr2r/j6nPYmoFb3mjJGNtRqdvBSLQoACXBUiY8AA==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Julien Grall <julien@xen.org>,
        "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: "sstabellini@kernel.org" <sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "roger.pau@citrix.com" <roger.pau@citrix.com>,
        "jbeulich@suse.com"
	<jbeulich@suse.com>,
        "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
        "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
        "paul@xen.org"
	<paul@xen.org>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Rahul Singh
	<rahul.singh@arm.com>,
        Oleksandr Andrushchenko
	<Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH v5 10/10] xen/arm: Process pending vPCI map/unmap
 operations
Thread-Topic: [PATCH v5 10/10] xen/arm: Process pending vPCI map/unmap
 operations
Thread-Index: AQHXvAkoZ3HMvjAU2km1yAXW+0PZkavRFnIAgBKXRgA=
Date: Mon, 25 Oct 2021 11:24:39 +0000
Message-ID: <e60a64b8-7e96-6e27-8c48-d8417a020358@epam.com>
References: <20211008055535.337436-1-andr2000@gmail.com>
 <20211008055535.337436-11-andr2000@gmail.com>
 <35cd8909-1d9b-842f-62e6-7544dcd3da4b@xen.org>
In-Reply-To: <35cd8909-1d9b-842f-62e6-7544dcd3da4b@xen.org>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 7ec35195-72b4-4135-3369-08d997aa08a1
x-ms-traffictypediagnostic: AM0PR03MB3876:
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <AM0PR03MB3876B3E7E8FB2FB5F32DACDBE7839@AM0PR03MB3876.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 RQuDAn3OcN/5JJ5E7vONYHO6x7IQyd/+NvhNmq+fVZnw/RrlaIVWZ8HvHrWvZLKRIsygDoIJOBLvgC1/f2gCvfrPpShOuyopW5lgOkwogOiyibyGYy9pZfPbFCYLxU2b+RG5BdyPhg3Lsns11sGTpgKr0iFTiaoaRMEqR9aSy8mjlxjZuyhQFIG0PTpxpQtTfZifChMZS4jIKDV6Vfcx97yv+ceTGoIxBmJXyWcdARsm0+nyft6fZop/LTtTM6NcgSrF2bNnKy2nrX3D/BuQFgzyOg2KmIB/ln6FlRUeswhP2LLCeWYA2UeMf9U3stnc9HvsAAVu+OfYfUMrW6iU7ymS0ez6WBDwhokDtjBDacw48+1NK2Eyo5BwsJ+rthlzDl1zwdy2EFT6OqGclJo99awNVWFSEBi6oULcTm1vksZpqaMfPYQp7QeVtV5aDqnYeUStFlSfacmpXucvB33LOBrRCr/dtqhQuOnS+j219poSl40an4ULfJyhRI8vVOcLtCWrNAZV3N3WDz0rZWlGxLV866jn3hkI87NId+dOzrxmTh3gMCkrocKRv0ggwzwj14tF45S7VRZoGXeMa0SZ9aVedWZcUgMe3A1TW2J+hm3izbjcAtC/75fYcUEzomgXqjp+EItWQI1pfGHjYRQWWpO5ZZRSN1MMZ9DpZ8dm0mLDTPHj+VloWyZ7n14UU3W0SxC97r73MSwTP8oEPv4OfqgdoPVg4VfogzHAwcOM/TYXvPbX9MoQ2cAZglDBBmRv
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(6512007)(4326008)(26005)(53546011)(6506007)(8676002)(83380400001)(6486002)(186003)(31696002)(107886003)(122000001)(38100700002)(2616005)(31686004)(71200400001)(91956017)(316002)(66476007)(66556008)(64756008)(66446008)(36756003)(86362001)(76116006)(7416002)(66946007)(2906002)(54906003)(110136005)(508600001)(5660300002)(38070700005)(8936002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?ZnVWbVMzZFFmeVdHeWlaM080RHgvZlNuMFhpMXJiaVJCS0xselQ2aFV6dzRa?=
 =?utf-8?B?YVE0bHplVGpDbnVvbVNCU2NpcHN6NmhucTkyaEs4M2FqOTlNZ0tRRThwdEtk?=
 =?utf-8?B?T0ZlWjNFc1RoMzFWdmdnSWF1RmdSV2pBTG5YcnNYaCt6Vzl5TWsvbzR1L08x?=
 =?utf-8?B?dTBvemlPVVI3c1JuT3o3NmI0d2RKajcyMFJNZzNHT2tWbWxvOGlFQzYvV29U?=
 =?utf-8?B?OENmTnNGQXdScU5qZXlTKzB6OUhPWStmK25HRlc0aStCNWJOcEpyMFFvQUVQ?=
 =?utf-8?B?OG01TVhTTWhYV3g2UHkzYXJ2Uy9NZTh3ejJTTU0vamtmamxsKzgzbWVTV0Fw?=
 =?utf-8?B?ZXUydFBPZkVOaXc1dmVqbzNpaU8vUkFqM0hQb1BpRU5pL213VDZ3cE83NTJS?=
 =?utf-8?B?d2E1R3JqYmdwRExpNHdQWEVQYTFPZi9HSXhnNlhRSmpvdEdqaFZoMmpTNGlw?=
 =?utf-8?B?dU5mUDFQUlplWWUxV2NwK01jVllzcWdaUWVBYmc4WWlsZVY4UHp1Z1NCU0wx?=
 =?utf-8?B?dWpXczlNNjM3NWRMczc4MVJycTlBVUNRWWxUMVdob2pNRVZvNXV5YWRqb244?=
 =?utf-8?B?U0NIR0JPcExqSXJseGI4cG5GU1JvbEE4a2VtM3AyN1lHMFJQdjlQSVFvcmRR?=
 =?utf-8?B?T0FqMXJLY2h4bUt4N1lyUzg1M25ER2RUcTZDNXdRbTlrWTFOak16TmNEMUhr?=
 =?utf-8?B?NHlsYnpjVkRzSkR5cnZwczRKT1EwV1JRVUZrWnRZOTd3SUdHMFdMdkQwMnJu?=
 =?utf-8?B?bngyQlZGekdVcVFZU1pXMjMvdzRZK1lxSytyakRETDJWZ2JaSDVKTFAwR1dV?=
 =?utf-8?B?QU1uK1dHUjNIUU1SUWxXMytwLzc3eXU4aU5yS2s3bzBROW9xUnFCbDJNRzZv?=
 =?utf-8?B?eitwaHZ3NUFKM1ppNEk3cTlMcEZ5YXlVQ1BEbEJML3RxenE1L2RLVlo0WURO?=
 =?utf-8?B?YVJ2OCsvM09aWE5YSnZRQjl6ZTJjUGdWRHF3YTNnakV2MGI5Y0F4aGo3TmNT?=
 =?utf-8?B?Y3B5dkxsUnJ2cVFsK2k5YTN6ZWluakR2RHNST1UwN0RwQUw4K2NRRXZvajhh?=
 =?utf-8?B?eVJYVmpteVRDQmpMOUc4dGpOTDF6ZDE1dVZiMTgzY2l5YWx3amo2d2VEVFMv?=
 =?utf-8?B?dTg2R0RUeWV1ZUxmTi9YR3ZuZWQyZWUzSmtUc2k1bElLMTUyV0FhQTVuZVVB?=
 =?utf-8?B?STBhdGV2bHprOTMrQ1dGeXpuMk5pWWN6MVhQTVNlRjNjaStLVjFUYUpLbWlF?=
 =?utf-8?B?d1dQM1RCcytYM2V4VUtCZ2d2eFB1cDBNRS83NzQzUHJvOXZBZjFvRkU2NWJB?=
 =?utf-8?B?QjFSeUIxWTlSUVZKejBFVWxORTNCN016NHNFaUlFN1VXVzdBK0VjOXpCbFZ4?=
 =?utf-8?B?ZjRybytVcUh0Umd1Q1BFTGhQekhTUFIxN0t0Q1FvTEtYVUpjL1lhd0wzUnkz?=
 =?utf-8?B?T0o2NllFTWoxczRqVVhJSjNjaDIxK0pSSUVmVWUrWHNWTGNRd3FzUWdKNTR2?=
 =?utf-8?B?SG5lRjA0QkZ3aUsvT0hYVUgyQXlsb29kekRmYWpHcHlERGMzd0xvdmJhVUNt?=
 =?utf-8?B?aHFyM2FKQkFBU0Y2dFEzblFKWmVWUyt6SFZ3WDNxNXZ4aFZUM3F1UStmZTBm?=
 =?utf-8?B?ZEY4NWRqYm1WRVo5MWwrbkdKRVlyejdHcGFHQTkxTEkwdzlDTXo4dWRJM3Ur?=
 =?utf-8?B?RFRuUHN4MVRwbVExYVRpNUFSUlBOTGh1ZTFudlRxeUpzRVN5WHlsanBWRlZD?=
 =?utf-8?B?N2NPdGlWWUp1RGRpYkZxZHZVclZ1cXIyeXFiWkh0THljMUlCbUxIUHFsOTNY?=
 =?utf-8?B?OTJJWXovdi9lVjV0RzJjU1BKTUpCOWlENTBYUjVzNElyTkFhSzdHeEoyZzl2?=
 =?utf-8?B?Qm5sZlJ5d29RcDhDMGRPV3RjZnIwZlRITGUrSTJ2bEYxUnBSZ280TlQ3NXlV?=
 =?utf-8?B?T1ZHU1ZGK1dGdlBtQmt1SkwwRUt2MjNjUHdSUWtnaUNKRGJ5SWtJYncxRk5F?=
 =?utf-8?B?d1hsdFdaUzA1MWRxbW4ySkh2bVU2TU5GU2F2QkM1MGVOWlBMTXlYcjc0dTVt?=
 =?utf-8?B?NEhNaXVFVnRrOFZZY25LUjdsWXArak1RVkJQaC9TZ0QvQTNwN1BsZDN1VVVv?=
 =?utf-8?B?VU5INjdwbEpUUWZadnorZG05SDBJS3JaZ21oU1MreGMxbSsxUUdKeE9CbkJz?=
 =?utf-8?B?YnJqdjF2ZmZLWmNWTDRsWnBRdEtqdTlMY2ViMGJTeGFLMGpJa0dTZ0NuUmtr?=
 =?utf-8?B?MXZKY001c2FJanpLMjlKOVJqdmpIMHg0bVJsMmMwY1VGVzhnTmtRb25WMnlv?=
 =?utf-8?B?NzJBSEFyY2E5MTRLZG8wNlhyUnYxUUE3QncxVnRoK3JtZ2VNR1VCUT09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <5A4DAC0981E0604E8F7AB0CBD7DC6AFD@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7ec35195-72b4-4135-3369-08d997aa08a1
X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Oct 2021 11:24:39.3487
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 3aR8SiK1EIJMmXf1kkbFPjjn1TnfqFGPPw/la0NFb6MvCYk1+wq8Fh4JbWzjVv4fKsaYROGKFVOMLwIkjS79BHreBNhLwM5XuFJoFo8Am4GXE2hfHY6xysPiCoQHoDuZ
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR03MB3876
X-Proofpoint-ORIG-GUID: fJsGHX9QufkQjXaQ4-EixEfO0G4zXUsZ
X-Proofpoint-GUID: fJsGHX9QufkQjXaQ4-EixEfO0G4zXUsZ
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475
 definitions=2021-10-25_04,2021-10-25_02,2020-04-07_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 mlxscore=0
 phishscore=0 spamscore=0 clxscore=1015 suspectscore=0 priorityscore=1501
 adultscore=0 mlxlogscore=999 lowpriorityscore=0 impostorscore=0
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2109230001 definitions=main-2110250070

SGksIEp1bGllbiENCg0KT24gMTMuMTAuMjEgMTg6MzAsIEp1bGllbiBHcmFsbCB3cm90ZToNCj4g
SGkgT2xla3NhbmRyLA0KPg0KPiBPbiAwOC8xMC8yMDIxIDA2OjU1LCBPbGVrc2FuZHIgQW5kcnVz
aGNoZW5rbyB3cm90ZToNCj4+IEZyb206IE9sZWtzYW5kciBBbmRydXNoY2hlbmtvIDxvbGVrc2Fu
ZHJfYW5kcnVzaGNoZW5rb0BlcGFtLmNvbT4NCj4+DQo+PiB2UENJIG1heSBtYXAgYW5kIHVubWFw
IFBDSSBkZXZpY2UgbWVtb3J5IChCQVJzKSBiZWluZyBwYXNzZWQgdGhyb3VnaCB3aGljaA0KPj4g
bWF5IHRha2UgYSBsb3Qgb2YgdGltZS4gRm9yIHRoaXMgdGhvc2Ugb3BlcmF0aW9ucyBtYXkgYmUg
ZGVmZXJyZWQgdG8gYmUNCj4+IHBlcmZvcm1lZCBsYXRlciwgc28gdGhhdCB0aGV5IGNhbiBiZSBz
YWZlbHkgcHJlZW1wdGVkLg0KPj4NCj4+IEN1cnJlbnRseSB0aGlzIGRlZmVycmVkIHByb2Nlc3Np
bmcgaXMgaGFwcGVuaW5nIGluIGNvbW1vbiBJT1JFUSBjb2RlDQo+PiB3aGljaCBkb2Vzbid0IHNl
ZW0gdG8gYmUgdGhlIHJpZ2h0IHBsYWNlIGZvciB4ODYgYW5kIGlzIGV2ZW4gbW9yZQ0KPj4gZG91
YnRmdWwgYmVjYXVzZSBJT1JFUSBtYXkgbm90IGJlIGVuYWJsZWQgZm9yIEFybSBhdCBhbGwuDQo+
PiBTbywgZm9yIEFybSB0aGUgcGVuZGluZyB2UENJIHdvcmsgbWF5IGhhdmUgbm8gY2hhbmNlIHRv
IGJlIGV4ZWN1dGVkDQo+PiBpZiB0aGUgcHJvY2Vzc2luZyBpcyBsZWZ0IGFzIGlzIGluIHRoZSBj
b21tb24gSU9SRVEgY29kZSBvbmx5Lg0KPj4gRm9yIHRoYXQgcmVhc29uIG1ha2UgdlBDSSBwcm9j
ZXNzaW5nIGhhcHBlbiBpbiBhcmNoIHNwZWNpZmljIGNvZGUuDQo+Pg0KPj4gUGxlYXNlIGJlIGF3
YXJlIHRoYXQgdGhlcmUgYXJlIGEgZmV3IG91dHN0YW5kaW5nIFRPRE9zIGFmZmVjdGluZyB0aGlz
DQo+PiBjb2RlIHBhdGgsIHNlZSB4ZW4vZHJpdmVycy92cGNpL2hlYWRlci5jOm1hcF9yYW5nZSBh
bmQNCj4+IHhlbi9kcml2ZXJzL3ZwY2kvaGVhZGVyLmM6dnBjaV9wcm9jZXNzX3BlbmRpbmcuDQo+
Pg0KPj4gU2lnbmVkLW9mZi1ieTogT2xla3NhbmRyIEFuZHJ1c2hjaGVua28gPG9sZWtzYW5kcl9h
bmRydXNoY2hlbmtvQGVwYW0uY29tPg0KPj4gW3g4NiBjaGFuZ2VzXQ0KPj4gQWNrZWQtYnk6IEph
biBCZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4+IFJldmlld2VkLWJ5OiBTdGVmYW5vIFN0
YWJlbGxpbmkgPHNzdGFiZWxsaW5pQGtlcm5lbC5vcmc+DQo+PiBSZXZpZXdlZC1ieTogUmFodWwg
U2luZ2ggPHJhaHVsLnNpbmdoQGFybS5jb20+DQo+PiBUZXN0ZWQtYnk6IFJhaHVsIFNpbmdoIDxy
YWh1bC5zaW5naEBhcm0uY29tPg0KPj4gLS0tDQo+PiBDYzogQW5kcmV3IENvb3BlciA8YW5kcmV3
LmNvb3BlcjNAY2l0cml4LmNvbT4NCj4+IENjOiBQYXVsIER1cnJhbnQgPHBhdWxAeGVuLm9yZz4N
Cj4+DQo+PiBTaW5jZSB2MjoNCj4+IMKgIC0gdXBkYXRlIGNvbW1pdCBtZXNzYWdlIHdpdGggbW9y
ZSBpbnNpZ2h0IG9uIHg4NiwgSU9SRVEgYW5kIEFybQ0KPj4gwqAgLSByZXN0b3JlZCBvcmRlciBv
ZiBpbnZvY2F0aW9uIGZvciBJT1JFUSBhbmQgdlBDSSBwcm9jZXNzaW5nIChKYW4pDQo+PiBTaW5j
ZSB2MToNCj4+IMKgIC0gTW92ZWQgdGhlIGNoZWNrIGZvciBwZW5kaW5nIHZwY2kgd29yayBmcm9t
IHRoZSBjb21tb24gSU9SRVEgY29kZQ0KPj4gwqDCoMKgIHRvIGh2bV9kb19yZXN1bWUgb24geDg2
DQo+PiDCoCAtIFJlLXdvcmtlZCB0aGUgY29kZSBmb3IgQXJtIHRvIGVuc3VyZSB3ZSBkb24ndCBt
aXNzIHBlbmRpbmcgdlBDSSB3b3JrDQo+PiAtLS0NCj4+IMKgIHhlbi9hcmNoL2FybS90cmFwcy5j
wqDCoCB8IDEzICsrKysrKysrKysrKysNCj4+IMKgIHhlbi9hcmNoL3g4Ni9odm0vaHZtLmMgfMKg
IDYgKysrKysrDQo+PiDCoCB4ZW4vY29tbW9uL2lvcmVxLmPCoMKgwqDCoCB8wqAgOSAtLS0tLS0t
LS0NCj4+IMKgIDMgZmlsZXMgY2hhbmdlZCwgMTkgaW5zZXJ0aW9ucygrKSwgOSBkZWxldGlvbnMo
LSkNCj4+DQo+PiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gvYXJtL3RyYXBzLmMgYi94ZW4vYXJjaC9h
cm0vdHJhcHMuYw0KPj4gaW5kZXggMjE5YWIzYzNmYmRlLi5iMjQ2ZjUxMDg2ZTMgMTAwNjQ0DQo+
PiAtLS0gYS94ZW4vYXJjaC9hcm0vdHJhcHMuYw0KPj4gKysrIGIveGVuL2FyY2gvYXJtL3RyYXBz
LmMNCj4+IEBAIC0zNCw2ICszNCw3IEBADQo+PiDCoCAjaW5jbHVkZSA8eGVuL3N5bWJvbHMuaD4N
Cj4+IMKgICNpbmNsdWRlIDx4ZW4vdmVyc2lvbi5oPg0KPj4gwqAgI2luY2x1ZGUgPHhlbi92aXJ0
dWFsX3JlZ2lvbi5oPg0KPj4gKyNpbmNsdWRlIDx4ZW4vdnBjaS5oPg0KPj4gwqAgwqAgI2luY2x1
ZGUgPHB1YmxpYy9zY2hlZC5oPg0KPj4gwqAgI2luY2x1ZGUgPHB1YmxpYy94ZW4uaD4NCj4+IEBA
IC0yMzA0LDYgKzIzMDUsMTggQEAgc3RhdGljIGJvb2wgY2hlY2tfZm9yX3ZjcHVfd29yayh2b2lk
KQ0KPj4gwqDCoMKgwqDCoCB9DQo+PiDCoCAjZW5kaWYNCj4+IMKgICvCoMKgwqAgaWYgKCBoYXNf
dnBjaSh2LT5kb21haW4pICkNCj4+ICvCoMKgwqAgew0KPj4gK8KgwqDCoMKgwqDCoMKgIGJvb2wg
cGVuZGluZzsNCj4+ICsNCj4+ICvCoMKgwqDCoMKgwqDCoCBsb2NhbF9pcnFfZW5hYmxlKCk7DQo+
PiArwqDCoMKgwqDCoMKgwqAgcGVuZGluZyA9IHZwY2lfcHJvY2Vzc19wZW5kaW5nKHYpOw0KPj4g
K8KgwqDCoMKgwqDCoMKgIGxvY2FsX2lycV9kaXNhYmxlKCk7DQo+PiArDQo+PiArwqDCoMKgwqDC
oMKgwqAgaWYgKCBwZW5kaW5nICkNCj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHJldHVybiB0
cnVlOw0KPj4gK8KgwqDCoCB9DQo+PiArDQo+DQo+IEkgd291bGQgcHJlZmVyIGlmIHRoaXMgYWRk
aXRpb24gaXMgbW92ZWQgYmVmb3JlIHRoZSB2Y3B1X2lvcmVxX19oYW5kbGVfY29tcGxldGlvbih2
KS4gVGhpcyBpcyB0byBhdm9pZCBkaWZmZXJlbmNlcyB3aXRoIHRoZSB4ODYgdmVyc2lvbi4NCk9r
LCB3aWxsIGRvDQoNClRoYW5rcywNCk9sZWtzYW5kcg==


From xen-devel-bounces@lists.xenproject.org Mon Oct 25 11:38:06 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Oct 2021 11:38:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.215754.375118 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1meyId-0006qi-O0; Mon, 25 Oct 2021 11:37:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 215754.375118; Mon, 25 Oct 2021 11:37:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1meyId-0006qb-It; Mon, 25 Oct 2021 11:37:55 +0000
Received: by outflank-mailman (input) for mailman id 215754;
 Mon, 25 Oct 2021 11:37:54 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=1v/+=PN=epam.com=prvs=0932af52eb=oleksandr_andrushchenko@srs-us1.protection.inumbo.net>)
 id 1meyIc-0006qV-OU
 for xen-devel@lists.xenproject.org; Mon, 25 Oct 2021 11:37:54 +0000
Received: from mx0b-0039f301.pphosted.com (unknown [148.163.137.242])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id fd0fdc8e-3587-11ec-840e-12813bfff9fa;
 Mon, 25 Oct 2021 11:37:52 +0000 (UTC)
Received: from pps.filterd (m0174680.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 19PBUmb3011445; 
 Mon, 25 Oct 2021 11:37:49 GMT
Received: from eur05-vi1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2168.outbound.protection.outlook.com [104.47.17.168])
 by mx0b-0039f301.pphosted.com with ESMTP id 3bwrnq8uvv-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Mon, 25 Oct 2021 11:37:49 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by AM0PR03MB4020.eurprd03.prod.outlook.com (2603:10a6:208:76::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.16; Mon, 25 Oct
 2021 11:37:43 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::c038:e032:595a:651]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::c038:e032:595a:651%8]) with mapi id 15.20.4628.020; Mon, 25 Oct 2021
 11:37:43 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fd0fdc8e-3587-11ec-840e-12813bfff9fa
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=IJpTJrjWYxz/qbomHWhVIYSwZyS0bljKg+XQ/OvayfAEo+YymopGAepWN+/jFw3NMMBzc2s4n1VLtKssXM9ft77LBaSel8xOmXCe+Z4E53hbQDKhACbZpUvAbrf+QWMy/ymeHyomFgP+ZMgyKNrLiIVUMTz/GgNKy/zw5nJQhGpv7lvG2fZDVzZpNwQx4+89Vi/SQt20RZOkX1pSGs0O8lP2koDvrz3DmbmUTgqlEsfaQQ7dSVufblgMZr7sStKIdDmITo0aghuuRuWKQznOYZtJlv1TvM3HRs+WLgj+z/oYUh0ani0//ik7KDdXZ6zeInH5TYIVfknx4nRr3DZaKA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=2Ax10gDsdpvUBGj5A46ExPdNfX6McwY/h20NgpeW81c=;
 b=cXFfOak4hVqev/OUO7j/Mz0v5NTkx6lRkIqcF4+AzWy7tfyq4JA6ClUXZFN2j3SudFqasgqZGFmNg2ZXaYadLVFl9U62tzJAhEWPKTaK9skD/8MaJB4PzKp3vZ3L51SdnLiOgSm2KSeFwvtoZQMRax/UMlsGfNSE4IDt1xMVnhXXo2EGxd1Dmw8CT4NEi43MXYL+S4ZDGvnFw7o4xuShrnGGDOb0Z0Ab0rol11QJLfRP/ggzgKBhVju5SARleCcbaLUvvaTjfZTmuzh1kmi6TjfDWxNgUJ1lLAj2ELU4Q4JGXRMxPKQWo0UkgRdGhX4NPaRsqXMRk9HLf0pcLeQicw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=2Ax10gDsdpvUBGj5A46ExPdNfX6McwY/h20NgpeW81c=;
 b=ZsdIFQnKREyoUaK7NtrxV8MRrsF8OrsEkEFvzxovrPH16HwNS5CuXyDkF7eKrNujoqFoyIsSet4rd/HkBRvr6wUerW7rq0YRHIdfeOsSPmbujGGN9omogw7ho+dzdX3sXn95sgSg/LNWFxqZrbCIEBeaZFGsWJE1XWJPf19Rm/foTGsZXbJofIkZRch3XJ1+F9ixJwgxUifBHuGBZVEZAatAE84oQ/7T9caOL6T//HDHBu/r3DD//XSzvMgQvuwUp371rt629leKWZW6GJV/xn1bMJoW7pXgENsboVFKbrYxPeDoPLY/q+o+ycxeVV1zQFjFuCzK8TNtuYkv3uPcUQ==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Julien Grall <julien@xen.org>,
        "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: "sstabellini@kernel.org" <sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "roger.pau@citrix.com" <roger.pau@citrix.com>,
        "jbeulich@suse.com"
	<jbeulich@suse.com>,
        "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
        "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
        "paul@xen.org"
	<paul@xen.org>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Rahul Singh
	<rahul.singh@arm.com>,
        Oleksandr Andrushchenko
	<Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH v5 09/10] xen/arm: Do not map PCI ECAM and MMIO space to
 Domain-0's p2m
Thread-Topic: [PATCH v5 09/10] xen/arm: Do not map PCI ECAM and MMIO space to
 Domain-0's p2m
Thread-Index: AQHXvAkp3d9SZd4Ne0C6z52O+cvuD6vRI24AgBKN8AA=
Date: Mon, 25 Oct 2021 11:37:43 +0000
Message-ID: <121f1c81-4385-ae12-fefc-dfa638bf1f81@epam.com>
References: <20211008055535.337436-1-andr2000@gmail.com>
 <20211008055535.337436-10-andr2000@gmail.com>
 <f5767857-a80a-fcc2-e70e-ce59ce19c8c9@xen.org>
In-Reply-To: <f5767857-a80a-fcc2-e70e-ce59ce19c8c9@xen.org>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 1585bc8e-cbc3-4621-0ff0-08d997abdc2e
x-ms-traffictypediagnostic: AM0PR03MB4020:
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <AM0PR03MB40209553F3AB3E61242F8769E7839@AM0PR03MB4020.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:3826;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 kNmknlZTV4Zi0LBeplXm3uRI0MBmnpFwbMQvxfhMClDK1YOgbbvXobcSNDF+R/49Oa2dmd4UTuJwVRbwOCfpaWO6pWD472+xhLun+cusYAslUd1JZ76utEE5mG6auysdftXiOYR6GEWc7fZ874DU96B4K1BRdBbFXl47824eYg1ykQ0XumTq9B8ADvfOj6Q5YZRXikbzFXSLiQRnSDlKqtKbjOgbenAGBKkjg+uBAJampuJTLCxiBLvjonSXHVYCEDdF0GB0YyoCCwVWrlgzUTQK6eb0O2Ir6gwpZve6Cg8YdSFYVrSzZmnbYkO1FrcDJ9Bi37p6kKadHGunZycrBgNYLXJWUHMb3+9BPoSqDF40fWn9UQ1lzTG79AkP37NtXPS5xP0+dyhk+LLurjs4fS2Ag0B+vUvJgkSyo/KCwdYq11t4y76y9eYm3fQ0QLTpashreUBXDkbW6fA+WLRDZRt18aeFrFdu08W8aCCBEf81x2Qh96b3l3OKmmbxidmh8eYy9+9vaU7RmNzuIT1iIFpFqAiyeDRhsU2UphhOah8uZY9XJEzLzgnl7Z4N3qlukEBcFhlDjxgchKRx+UsrbOkfz9MqDUikBbyJIgY63ZlifwpK4XMJB7bkv6blEmeIh0xadIsxbmgZeNFuvq4nzRgp3ct4gj7D5jj51/3hHmR27ttkDzS6cOWuxWJ/EKsCRwZi984JE3NJbqkW95GQ52/Oz9WkzRHDOCox3MOyDgVoKDFoHtjACMUozabDemlHj2nn7gs3uBGVykN5Xx5wTT9a3VeDEix3FKuf20O2mJdjcAsG5VDrl6P3dCLaNfGityCNmNJNWKK8WXq/DiBZ9BrzWW3QJD1Wc02hwRBIctRbxIjbkvfzjfgW0b6nC6fmHE8G/7LZeObAhZvOUwX0Og==
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(508600001)(91956017)(107886003)(110136005)(30864003)(26005)(6486002)(76116006)(54906003)(966005)(5660300002)(38100700002)(66446008)(86362001)(64756008)(8936002)(31686004)(66946007)(122000001)(36756003)(186003)(66476007)(7416002)(6512007)(31696002)(66556008)(2906002)(53546011)(38070700005)(316002)(6506007)(2616005)(4326008)(8676002)(71200400001)(83380400001)(39920500001)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?YUJDUGI2alI5aGtDaDQxOElpdUMxVVRqb2NlcEFwcDdLTytVUG1YRllaUG4x?=
 =?utf-8?B?OXZpRGU3dVdDdjAvNXhJaFZwcDNTa201QW4wVHh0Q1FMWUlBTy9SOTl1Zisr?=
 =?utf-8?B?U0tWYTVGSnJKNXRuVld2UDdlU1MzOFBxdUUrbDFTeUN6cTVMQ3gzNklYSi9X?=
 =?utf-8?B?MUh2S1N6Wi9ZbHdWd3gzZWs5aVV0VFVKWllmR09iakJHR2JTakR0QWR5Q1JR?=
 =?utf-8?B?d2duN2xYSG1mMW5DOXUwbzJONEE3N3I0V3hnVHF2bFJvMmlRV0FQMW9ZbE8x?=
 =?utf-8?B?Vk9xRVFsMUZHUWZUNkQwMzZVeHBaZC9nMExFNEtuc0oxcjdPUUpralVacm5o?=
 =?utf-8?B?SFB6TmFoeS9vS0NUUHAxbTBpT0FCR3hBOVhIVXNwL010dlFnTWhETVVtbHhz?=
 =?utf-8?B?b0xGSGRLOGxQZk0xR2Y3UGEvczVRZ1BRVG5EOHJjZFhibzk4Q3ZGemh3eHox?=
 =?utf-8?B?czh4Vkw4Vi8zUWVPVXcwSGlrTllKeU1JajB3QVVGZUdPSnZwMDJ3L2JvTW1z?=
 =?utf-8?B?TE5HZVdsWklBTmtkMlQrWXpRdkZxdEtEd1pmZ0cwUGlKTWI4TnVaengrdmx1?=
 =?utf-8?B?L05ZYzk1a0p1YmlXU1hkTXVlM2xJQXBaMXFSbVlVM2lpVEFieFUxa3ZnT2tN?=
 =?utf-8?B?SzNrN3ZJOS81M1JXWUgxUGlidGdJU3NyNGxhTmNxa1I5L1hoT3drd3pReFkw?=
 =?utf-8?B?TFk3YS9HU2hkc21uam5PSjZzYU9EV25NaTRMR1hIYkcvcktEZVFTc3FBZjlr?=
 =?utf-8?B?T09nNjZtQ1crbDRWTzFrd2hvK3Q1NTR3YXhiUk5qM1lkQ2tYeitQdUMyd0ZM?=
 =?utf-8?B?dkpnTjlXSTB6dzFrRVh1Q2NETVJCcTJPdkgwZkdOZlJTMVNTb01taE8wMXE0?=
 =?utf-8?B?L0pHQW9uTHBmNUtMcC9iNEpQNS9yYjAxQnF0R3FSdnNyejVaTVNpaEJUM0lo?=
 =?utf-8?B?REpTRUpxUzNCMFk0THlGSlE5bTRqMUlpaGNXY3JGM2JHT2Rwc0IrQVptVEdh?=
 =?utf-8?B?bE5IZ0FERkF1dXJvUTcxZFVqV3FqQ0RZclp1Vmo0ZS9SUGhzVllqUTdIdXMx?=
 =?utf-8?B?TC9OZFlFTmc1Mzd0ZCtwYXp0cjR6RWgrU2k4a1FJQkl0S3FIV2xUbFQ1cEt2?=
 =?utf-8?B?b2lWN1MzWHBCeHNvVE1Na25aOTRPV2xDanV2U0hPa2pwQWpDbEo1ZDhFNmFq?=
 =?utf-8?B?NFZwNWVVcHRzaE1YaW4xRFRCb1pKQ3lEWEErb1dSam93WUJQcXQ5MUFva0hN?=
 =?utf-8?B?OWtXSUFQeWFINmtjdHBNNjh4NFRObnhTeksxZEtOSHNESEx4L1BwRzRFNDQx?=
 =?utf-8?B?MVZpa3M3c24rOHgwTk53RUxEcGtSTVVocUVXcGw1b1BQcDBISThVbTJKa2or?=
 =?utf-8?B?V0ZhbmtHSkIxZDNvTzdKcmhXbW5Hc0RCV0Z0MVA3TGFZcFBTRGpjUzYrZW8w?=
 =?utf-8?B?TGlUbjg5NDN5dm9XQlNxOTZ2N2hiZ0FXN1M5ZFpVSDlCK1dFbVowSC8veTNH?=
 =?utf-8?B?c2ZhNG8xZTJGZGxPb2QwMUJ2YmFNcUQyMyt5bi9BMGw3OEZCdWFxb0NvTHZz?=
 =?utf-8?B?ZEc5YXJmTTdIRWZBRjQwcXcrTVgrSDg0K2Z6bElQQTUrb1d3WDVWei94YTFW?=
 =?utf-8?B?cXZvVFVEMnJneHFMWGN4SFB6WWRhT3BvRVM2cGdBMTB6dEZDZy9DRXl5MndL?=
 =?utf-8?B?VnJVY0RidXo4TEMrYnp2MVhhVks2MHk5OS9UYm9EUUVReHhXNXNSRC9OYlll?=
 =?utf-8?B?bTNLQTF3YnhxWXBsaHRGZFdyRG1uZzhYcDh1ZlY4ak9hcUN1Ulp0b0hYYkNt?=
 =?utf-8?B?Vmt5VEhuWCsyUnA5MDAvcTBwMTZKQkFnYXQ4dWNCenZYYndWNlZuZHBvdXdq?=
 =?utf-8?B?cEREQmZqWHBHZEtIMFRRQU5LQmRHQTdtcjcvT3VYaGdjSnl1Ynl3ZWg0aU9o?=
 =?utf-8?B?cnhvWi8waW5wV2dnTTE1WjNEcWw4eno2V29WUXNmTmFNQU9rTzhqR2xiWjFX?=
 =?utf-8?B?QWdCb2U0dFdjUmNlaUlsSFZodnlRNUUyOXB4YUJ4NkExdlBXdnRPR1Zkemkx?=
 =?utf-8?B?ZWR0VXB5NUIzYkJBRi9Vd1RlM0xwYzQvTTlicTlmNm9nWm0wWThPS1lQRmdt?=
 =?utf-8?B?dFg5L1Via3QrV0NMVXVXd1R6a2R1NFBIZUIyOVJKUC91c0YxVWY0d0o3bCtK?=
 =?utf-8?B?SnVIa0JwZmVERmxpUVJsVCtpb2x2TkVETXA3YUxCKy9iQ1Vnd3VDQzZhL21I?=
 =?utf-8?B?RzlHMVlOL04zbi82TVlmeE1ucE85MWF4TW80VGI1Nnp6YkRvb3A2NGFMYjR4?=
 =?utf-8?B?U0lJMXZGYVlmSkc4NE9ob05GMC9aMDNHMnNUMjRSbUs3Q2ZRUzVyZz09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <60153057E124F546BA98DC2D327EAF97@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1585bc8e-cbc3-4621-0ff0-08d997abdc2e
X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Oct 2021 11:37:43.8136
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: UUNzQ1fe+tQceMoGJb1CD7MoPu9l74EhpyBgBhGgNFYsR8TH7mWR9RpeVbM2Hmw+l3jpDzz0QPETeqa9TI3T80Pan5OZu4ZYUzn9/QthO2Jwf7iQzTYi0WNuBSa5gDbw
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR03MB4020
X-Proofpoint-ORIG-GUID: oBWmQ5AqW5sypOqpcAJYAIy6w0w0YZB3
X-Proofpoint-GUID: oBWmQ5AqW5sypOqpcAJYAIy6w0w0YZB3
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475
 definitions=2021-10-25_04,2021-10-25_02,2020-04-07_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 mlxscore=0
 phishscore=0 spamscore=0 clxscore=1015 suspectscore=0 priorityscore=1501
 adultscore=0 mlxlogscore=999 lowpriorityscore=0 impostorscore=0
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2109230001 definitions=main-2110250071

SGksIEp1bGllbiENCg0KT24gMTMuMTAuMjEgMTk6MTcsIEp1bGllbiBHcmFsbCB3cm90ZToNCj4g
SGkgT2xla3NhbmRyLA0KPg0KPiBPbiAwOC8xMC8yMDIxIDA2OjU1LCBPbGVrc2FuZHIgQW5kcnVz
aGNoZW5rbyB3cm90ZToNCj4+IEZyb206IE9sZWtzYW5kciBBbmRydXNoY2hlbmtvIDxvbGVrc2Fu
ZHJfYW5kcnVzaGNoZW5rb0BlcGFtLmNvbT4NCj4+DQo+PiBQQ0kgaG9zdCBicmlkZ2VzIGFyZSBz
cGVjaWFsIGRldmljZXMgaW4gdGVybXMgb2YgaW1wbGVtZW50aW5nIFBDSQ0KPj4gcGFzc3Rocm91
Z2guIEFjY29yZGluZyB0byBbMV0gdGhlIGN1cnJlbnQgaW1wbGVtZW50YXRpb24gZGVwZW5kcyBv
bg0KPj4gRG9tYWluLTAgdG8gcGVyZm9ybSB0aGUgaW5pdGlhbGl6YXRpb24gb2YgdGhlIHJlbGV2
YW50IFBDSSBob3N0DQo+PiBicmlkZ2UgaGFyZHdhcmUgYW5kIHBlcmZvcm0gUENJIGRldmljZSBl
bnVtZXJhdGlvbi4gSW4gb3JkZXIgdG8NCj4+IGFjaGlldmUgdGhhdCBvbmUgb2YgdGhlIHJlcXVp
cmVkIGNoYW5nZXMgaXMgdG8gbm90IG1hcCBhbGwgdGhlIG1lbW9yeQ0KPj4gcmFuZ2VzIGluIG1h
cF9yYW5nZV90b19kb21haW4gYXMgd2UgdHJhdmVyc2UgdGhlIGRldmljZSB0cmVlIG9uIHN0YXJ0
dXANCj4+IGFuZCBwZXJmb3JtIHNvbWUgYWRkaXRpb25hbCBjaGVja3MgaWYgdGhlIHJhbmdlIG5l
ZWRzIHRvIGJlIG1hcHBlZCB0bw0KPj4gRG9tYWluLTAuDQo+Pg0KPj4gVGhlIGdlbmVyaWMgUENJ
IGhvc3QgY29udHJvbGxlciBkZXZpY2UgdHJlZSBiaW5kaW5nIHNheXMgWzJdOg0KPj4gLSByYW5n
ZXM6IEFzIGRlc2NyaWJlZCBpbiBJRUVFIFN0ZCAxMjc1LTE5OTQsIGJ1dCBtdXN0IHByb3ZpZGUN
Cj4+IMKgwqDCoMKgwqDCoMKgwqDCoMKgIGF0IGxlYXN0IGEgZGVmaW5pdGlvbiBvZiBub24tcHJl
ZmV0Y2hhYmxlIG1lbW9yeS4gT25lDQo+PiDCoMKgwqDCoMKgwqDCoMKgwqDCoCBvciBib3RoIG9m
IHByZWZldGNoYWJsZSBNZW1vcnkgYW5kIElPIFNwYWNlIG1heSBhbHNvDQo+PiDCoMKgwqDCoMKg
wqDCoMKgwqDCoCBiZSBwcm92aWRlZC4NCj4+DQo+PiAtIHJlZ8KgwqAgOiBUaGUgQ29uZmlndXJh
dGlvbiBTcGFjZSBiYXNlIGFkZHJlc3MgYW5kIHNpemUsIGFzIGFjY2Vzc2VkDQo+PiDCoMKgwqDC
oMKgwqDCoMKgwqDCoCBmcm9tIHRoZSBwYXJlbnQgYnVzLsKgIFRoZSBiYXNlIGFkZHJlc3MgY29y
cmVzcG9uZHMgdG8NCj4+IMKgwqDCoMKgwqDCoMKgwqDCoMKgIHRoZSBmaXJzdCBidXMgaW4gdGhl
ICJidXMtcmFuZ2UiIHByb3BlcnR5LsKgIElmIG5vDQo+PiDCoMKgwqDCoMKgwqDCoMKgwqDCoCAi
YnVzLXJhbmdlIiBpcyBzcGVjaWZpZWQsIHRoaXMgd2lsbCBiZSBidXMgMCAodGhlIGRlZmF1bHQp
Lg0KPj4NCj4+IMKgRnJvbSB0aGUgYWJvdmUgbm9uZSBvZiB0aGUgbWVtb3J5IHJhbmdlcyBmcm9t
IHRoZSAicmFuZ2VzIiBwcm9wZXJ0eQ0KPg0KPiBOSVQ6IFRoZSBzcGFjZSBiZWZvcmUgIkZyb20i
IGxvb2tzIG9kZC4NCldpbGwgZml4DQo+DQo+PiBuZWVkcyB0byBiZSBtYXBwZWQgdG8gRG9tYWlu
LTAgYXQgc3RhcnR1cCBhcyBNTUlPIG1hcHBpbmcgaXMgZ29pbmcgdG8NCj4+IGJlIGhhbmRsZWQg
ZHluYW1pY2FsbHkgYnkgdlBDSSBhcyB3ZSBhc3NpZ24gUENJIGRldmljZXMsIGUuZy4gZWFjaA0K
Pj4gZGV2aWNlIGFzc2lnbmVkIHRvIERvbWFpbi0wL2d1ZXN0IHdpbGwgaGF2ZSBpdHMgTU1JT3Mg
bWFwcGVkL3VubWFwcGVkDQo+PiBhcyBuZWVkZWQgYnkgWGVuLg0KPj4NCj4+IFRoZSAicmVnIiBw
cm9wZXJ0eSBjb3ZlcnMgbm90IG9ubHkgRUNBTSBzcGFjZSwgYnV0IG1heSBhbHNvIGhhdmUgb3Ro
ZXINCj4+IHRoZW4gdGhlIGNvbmZpZ3VyYXRpb24gbWVtb3J5IHJhbmdlcyBkZXNjcmliZWQsIGZv
ciBleGFtcGxlIFszXToNCj4+IC0gcmVnOiBTaG91bGQgY29udGFpbiByY19kYmksIGNvbmZpZyBy
ZWdpc3RlcnMgbG9jYXRpb24gYW5kIGxlbmd0aC4NCj4+IC0gcmVnLW5hbWVzOiBNdXN0IGluY2x1
ZGUgdGhlIGZvbGxvd2luZyBlbnRyaWVzOg0KPj4gwqDCoMKgICJyY19kYmkiOiBjb250cm9sbGVy
IGNvbmZpZ3VyYXRpb24gcmVnaXN0ZXJzOw0KPj4gwqDCoMKgICJjb25maWciOiBQQ0llIGNvbmZp
Z3VyYXRpb24gc3BhY2UgcmVnaXN0ZXJzLg0KPj4NCj4+IFRoaXMgcGF0Y2ggbWFrZXMgaXQgcG9z
c2libGUgdG8gbm90IG1hcCBhbGwgdGhlIHJhbmdlcyBmcm9tIHRoZQ0KPj4gInJhbmdlcyIgcHJv
cGVydHkgYW5kIGFsc28gRUNBTSBmcm9tIHRoZSAicmVnIi4gQWxsIHRoZSByZXN0IGZyb20gdGhl
DQo+PiAicmVnIiBwcm9wZXJ0eSBzdGlsbCBuZWVkcyB0byBiZSBtYXBwZWQgdG8gRG9tYWluLTAs
IHNvIHRoZSBQQ0kNCj4+IGhvc3QgYnJpZGdlIHJlbWFpbnMgZnVuY3Rpb25hbCBpbiBEb21haW4t
MC4NCj4+DQo+PiBbMV0gaHR0cHM6Ly91cmxkZWZlbnNlLmNvbS92My9fX2h0dHBzOi8vbGlzdHMu
eGVucHJvamVjdC5vcmcvYXJjaGl2ZXMvaHRtbC94ZW4tZGV2ZWwvMjAyMC0wNy9tc2cwMDc3Ny5o
dG1sX187ISFHRl8yOWRiY1FJVUJQQSFoRFVBWHVpSEF4N2ZzWDZneU12bGVuMlBCNGtUbTN2V2JW
RmFUeTE5SHdwRkprU2JGWGtPU2pqcF83OHhYNlZtSENWa2NGSzM5dyQgW2xpc3RzWy5deGVucHJv
amVjdFsuXW9yZ10NCj4+IFsyXSBodHRwczovL3VybGRlZmVuc2UuY29tL3YzL19faHR0cHM6Ly93
d3cua2VybmVsLm9yZy9kb2MvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL3BjaS9o
b3N0LWdlbmVyaWMtcGNpLnR4dF9fOyEhR0ZfMjlkYmNRSVVCUEEhaERVQVh1aUhBeDdmc1g2Z3lN
dmxlbjJQQjRrVG0zdldiVkZhVHkxOUh3cEZKa1NiRlhrT1NqanBfNzh4WDZWbUhDV3J5ekVVSWck
IFtrZXJuZWxbLl1vcmddDQo+PiBbM10gaHR0cHM6Ly91cmxkZWZlbnNlLmNvbS92My9fX2h0dHBz
Oi8vd3d3Lmtlcm5lbC5vcmcvZG9jL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9w
Y2kvaGlzaWxpY29uLXBjaWUudHh0X187ISFHRl8yOWRiY1FJVUJQQSFoRFVBWHVpSEF4N2ZzWDZn
eU12bGVuMlBCNGtUbTN2V2JWRmFUeTE5SHdwRkprU2JGWGtPU2pqcF83OHhYNlZtSENXdVQzaTkx
USQgW2tlcm5lbFsuXW9yZ10NCj4+DQo+PiBTaWduZWQtb2ZmLWJ5OiBPbGVrc2FuZHIgQW5kcnVz
aGNoZW5rbyA8b2xla3NhbmRyX2FuZHJ1c2hjaGVua29AZXBhbS5jb20+DQo+PiAtLS0NCj4+IFNp
bmNlIHY0Og0KPj4gLSB1cGRhdGUgc2tpcF9tYXBwaW5nIGNvbW1lbnQNCj4+IC0gYWRkIGNvbW1l
bnQgd2h5IHdlIG5lZWQgdG8gbWFwIGludGVycnVwdHMgdG8gRG9tMA0KPj4gU2luY2UgdjM6DQo+
PiDCoCAtIHBhc3Mgc3RydWN0IG1hcF9yYW5nZV9kYXRhIHRvIG1hcF9kdF9pcnFfdG9fZG9tYWlu
DQo+PiDCoCAtIHJlbW92ZSByZWR1bmRhbnQgY2hlY2sgZnJvbSBtYXBfcmFuZ2VfdG9fZG9tYWlu
DQo+PiDCoCAtIGZpeCBoYW5kbGVfZGV2aWNlJ3MgLnNraXBfbWFwcGluZw0KPj4gU2luY2UgdjI6
DQo+PiDCoCAtIHJlbW92ZWQgY2hlY2sgaW4gbWFwX3JhbmdlX3RvX2RvbWFpbiBmb3IgUENJX0RF
Vg0KPj4gwqDCoMKgIGFuZCBtb3ZlZCBpdCB0byBoYW5kbGVfZGV2aWNlLCBzbyB0aGUgY29kZSBp
cw0KPj4gwqDCoMKgIHNpbXBsZXINCj4+IMKgIC0gcy9tYXBfcGNpX2JyaWRnZS9za2lwX21hcHBp
bmcNCj4+IMKgIC0gZXh0ZW5kZWQgY29tbWVudCBpbiBwY2lfaG9zdF9icmlkZ2VfbWFwcGluZ3MN
Cj4+IMKgIC0gbWlub3IgY29kZSByZXN0cnVjdHVyZSBpbiBjb25zdHJ1Y3RfZG9tMA0KPj4gwqAg
LSBzLy5uZWVkX3AybV9tYXBwaW5nLy5uZWVkX3AybV9od2RvbV9tYXBwaW5nIGFuZCByZWxhdGVk
DQo+PiDCoMKgwqAgY2FsbGJhY2tzDQo+PiDCoCAtIHVuc2lnbmVkIGludCBpOyBpbiBwY2lfaG9z
dF9icmlkZ2VfbWFwcGluZ3MNCj4+IFNpbmNlIHYxOg0KPj4gwqAgLSBBZGRlZCBiZXR0ZXIgZGVz
Y3JpcHRpb24gb2Ygd2h5IGFuZCB3aGF0IG5lZWRzIHRvIGJlIG1hcHBlZCBpbnRvDQo+PiDCoMKg
wqAgRG9tYWluLTAncyBwMm0gYW5kIHdoYXQgZG9lc24ndA0KPj4gwqAgLSBEbyBub3QgZG8gYW55
IG1hcHBpbmdzIGZvciBQQ0kgZGV2aWNlcyB3aGlsZSB0cmF2ZXJzaW5nIHRoZSBEVA0KPj4gwqAg
LSBXYWxrIGFsbCB0aGUgYnJpZGdlcyBhbmQgbWFrZSByZXF1aXJlZCBtYXBwaW5ncyBpbiBvbmUg
Z28NCj4+IC0tLQ0KPj4gwqAgeGVuL2FyY2gvYXJtL2RvbWFpbl9idWlsZC5jwqDCoMKgwqDCoMKg
wqAgfCA1NyArKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0NCj4+IMKgIHhlbi9hcmNoL2Fy
bS9wY2kvZWNhbS5jwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB8IDE0ICsrKysrKysrDQo+PiDCoCB4
ZW4vYXJjaC9hcm0vcGNpL3BjaS1ob3N0LWNvbW1vbi5jIHwgNDkgKysrKysrKysrKysrKysrKysr
KysrKysrKw0KPj4gwqAgeGVuL2FyY2gvYXJtL3BjaS9wY2ktaG9zdC16eW5xbXAuYyB8wqAgMSAr
DQo+PiDCoCB4ZW4vaW5jbHVkZS9hc20tYXJtL3BjaS5owqDCoMKgwqDCoMKgwqDCoMKgIHwgMTAg
KysrKysrDQo+PiDCoCB4ZW4vaW5jbHVkZS9hc20tYXJtL3NldHVwLmjCoMKgwqDCoMKgwqDCoCB8
IDEzICsrKysrKysNCj4+IMKgIDYgZmlsZXMgY2hhbmdlZCwgMTIxIGluc2VydGlvbnMoKyksIDIz
IGRlbGV0aW9ucygtKQ0KPj4NCj4+IGRpZmYgLS1naXQgYS94ZW4vYXJjaC9hcm0vZG9tYWluX2J1
aWxkLmMgYi94ZW4vYXJjaC9hcm0vZG9tYWluX2J1aWxkLmMNCj4+IGluZGV4IGI1MTE3NmIzMWJl
Zi4uMGQ2NzNiMDZhMmYzIDEwMDY0NA0KPj4gLS0tIGEveGVuL2FyY2gvYXJtL2RvbWFpbl9idWls
ZC5jDQo+PiArKysgYi94ZW4vYXJjaC9hcm0vZG9tYWluX2J1aWxkLmMNCj4+IEBAIC0xMCw3ICsx
MCw2IEBADQo+PiDCoCAjaW5jbHVkZSA8YXNtL3JlZ3MuaD4NCj4+IMKgICNpbmNsdWRlIDx4ZW4v
ZXJybm8uaD4NCj4+IMKgICNpbmNsdWRlIDx4ZW4vZXJyLmg+DQo+PiAtI2luY2x1ZGUgPHhlbi9k
ZXZpY2VfdHJlZS5oPg0KPj4gwqAgI2luY2x1ZGUgPHhlbi9saWJmZHQvbGliZmR0Lmg+DQo+PiDC
oCAjaW5jbHVkZSA8eGVuL2d1ZXN0X2FjY2Vzcy5oPg0KPj4gwqAgI2luY2x1ZGUgPHhlbi9pb2Nh
cC5oPg0KPj4gQEAgLTUxLDEyICs1MCw2IEBAIHN0YXRpYyBpbnQgX19pbml0IHBhcnNlX2RvbTBf
bWVtKGNvbnN0IGNoYXIgKnMpDQo+PiDCoCB9DQo+PiDCoCBjdXN0b21fcGFyYW0oImRvbTBfbWVt
IiwgcGFyc2VfZG9tMF9tZW0pOw0KPj4gwqAgLXN0cnVjdCBtYXBfcmFuZ2VfZGF0YQ0KPj4gLXsN
Cj4+IC3CoMKgwqAgc3RydWN0IGRvbWFpbiAqZDsNCj4+IC3CoMKgwqAgcDJtX3R5cGVfdCBwMm10
Ow0KPj4gLX07DQo+PiAtDQo+PiDCoCAvKiBPdmVycmlkZSBtYWNyb3MgZnJvbSBhc20vcGFnZS5o
IHRvIG1ha2UgdGhlbSB3b3JrIHdpdGggbWZuX3QgKi8NCj4+IMKgICN1bmRlZiB2aXJ0X3RvX21m
bg0KPj4gwqAgI2RlZmluZSB2aXJ0X3RvX21mbih2YSkgX21mbihfX3ZpcnRfdG9fbWZuKHZhKSkN
Cj4+IEBAIC0xNjYzLDEwICsxNjU2LDExIEBAIHN0YXRpYyBpbnQgX19pbml0IG1hcF9kdF9pcnFf
dG9fZG9tYWluKGNvbnN0IHN0cnVjdCBkdF9kZXZpY2Vfbm9kZSAqZGV2LA0KPj4gwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqAgY29uc3Qgc3RydWN0IGR0X2lycSAqZHRfaXJxLA0KPj4gwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqAgdm9pZCAqZGF0YSkNCj4+IMKgIHsNCj4+IC3CoMKgwqAgc3RydWN0IGRv
bWFpbiAqZCA9IGRhdGE7DQo+PiArwqDCoMKgIHN0cnVjdCBtYXBfcmFuZ2VfZGF0YSAqbXJfZGF0
YSA9IGRhdGE7DQo+PiArwqDCoMKgIHN0cnVjdCBkb21haW4gKmQgPSBtcl9kYXRhLT5kOw0KPj4g
wqDCoMKgwqDCoCB1bnNpZ25lZCBpbnQgaXJxID0gZHRfaXJxLT5pcnE7DQo+PiDCoMKgwqDCoMKg
IGludCByZXM7DQo+PiAtwqDCoMKgIGJvb2wgbmVlZF9tYXBwaW5nID0gIWR0X2RldmljZV9mb3Jf
cGFzc3Rocm91Z2goZGV2KTsNCj4+ICvCoMKgwqAgYm9vbCBuZWVkX21hcHBpbmcgPSAhbXJfZGF0
YS0+c2tpcF9tYXBwaW5nOw0KPg0KPiBCZWZvcmUsIHRoZSB2YXJpYWJsZSAnbmVlZF9tYXBwaW5n
JyB3YXMgaGVscGZ1bCB0byB1bmRlcnN0YW5kIHdoYXQgIWR0X2RldmljZV9mb3JfcGFzc3Rocm91
Z2goKS4gTm93IGl0IGZlZWxzIG9kZCB0byByZWFkLiBUaGVyZSBpcyBvbmx5IG9uZSB1c2VyLCBz
byBjYW4gdGhlIGxvY2FsIHZhcmlhYmxlIGJlIGRyb3BwZWQ/DQpPaywgSSBjYW4gZHJvcCB0aGUg
bG9jYWwgdmFyaWFibGUgYW5kIHVzZSB0aGUgdmFsdWUgZGlyZWN0bHkNCj4NCj4+IMKgIMKgwqDC
oMKgwqAgaWYgKCBpcnEgPCBOUl9MT0NBTF9JUlFTICkNCj4+IMKgwqDCoMKgwqAgew0KPj4gQEAg
LTE2OTAsMTMgKzE2ODQsMTIgQEAgc3RhdGljIGludCBfX2luaXQgbWFwX2R0X2lycV90b19kb21h
aW4oY29uc3Qgc3RydWN0IGR0X2RldmljZV9ub2RlICpkZXYsDQo+PiDCoMKgwqDCoMKgIHJldHVy
biAwOw0KPj4gwqAgfQ0KPj4gwqAgLXN0YXRpYyBpbnQgX19pbml0IG1hcF9yYW5nZV90b19kb21h
aW4oY29uc3Qgc3RydWN0IGR0X2RldmljZV9ub2RlICpkZXYsDQo+PiAtwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqAgdTY0IGFkZHIsIHU2NCBsZW4sDQo+PiAtwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgdm9pZCAqZGF0YSkN
Cj4+ICtpbnQgX19pbml0IG1hcF9yYW5nZV90b19kb21haW4oY29uc3Qgc3RydWN0IGR0X2Rldmlj
ZV9ub2RlICpkZXYsDQo+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgIHU2NCBhZGRyLCB1NjQgbGVuLCB2b2lkICpkYXRhKQ0KPj4g
wqAgew0KPj4gwqDCoMKgwqDCoCBzdHJ1Y3QgbWFwX3JhbmdlX2RhdGEgKm1yX2RhdGEgPSBkYXRh
Ow0KPj4gwqDCoMKgwqDCoCBzdHJ1Y3QgZG9tYWluICpkID0gbXJfZGF0YS0+ZDsNCj4+IC3CoMKg
wqAgYm9vbCBuZWVkX21hcHBpbmcgPSAhZHRfZGV2aWNlX2Zvcl9wYXNzdGhyb3VnaChkZXYpOw0K
Pj4gK8KgwqDCoCBib29sIG5lZWRfbWFwcGluZyA9ICFtcl9kYXRhLT5za2lwX21hcHBpbmc7DQo+
DQo+IFNhbWUgaGVyZS4NCk9rLCBJIGNhbiBkcm9wIHRoZSBsb2NhbCB2YXJpYWJsZSBhbmQgdXNl
IHRoZSB2YWx1ZSBkaXJlY3RseQ0KPg0KPj4gwqDCoMKgwqDCoCBpbnQgcmVzOw0KPj4gwqAgwqDC
oMKgwqDCoCAvKg0KPj4gQEAgLTE3NDgsMjMgKzE3NDEsMjEgQEAgc3RhdGljIGludCBfX2luaXQg
bWFwX3JhbmdlX3RvX2RvbWFpbihjb25zdCBzdHJ1Y3QgZHRfZGV2aWNlX25vZGUgKmRldiwNCj4+
IMKgwqAgKiB0aGVuIHdlIG1heSBuZWVkIHRvIHBlcmZvcm0gYWRkaXRpb25hbCBtYXBwaW5ncyBp
biBvcmRlciB0byBtYWtlDQo+PiDCoMKgICogdGhlIGNoaWxkIHJlc291cmNlcyBhdmFpbGFibGUg
dG8gZG9tYWluIDAuDQo+PiDCoMKgICovDQo+PiAtc3RhdGljIGludCBfX2luaXQgbWFwX2Rldmlj
ZV9jaGlsZHJlbihzdHJ1Y3QgZG9tYWluICpkLA0KPj4gLcKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGNvbnN0
IHN0cnVjdCBkdF9kZXZpY2Vfbm9kZSAqZGV2LA0KPj4gLcKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHAybV90
eXBlX3QgcDJtdCkNCj4+ICtzdGF0aWMgaW50IF9faW5pdCBtYXBfZGV2aWNlX2NoaWxkcmVuKGNv
bnN0IHN0cnVjdCBkdF9kZXZpY2Vfbm9kZSAqZGV2LA0KPj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHN0
cnVjdCBtYXBfcmFuZ2VfZGF0YSAqbXJfZGF0YSkNCj4+IMKgIHsNCj4+IC3CoMKgwqAgc3RydWN0
IG1hcF9yYW5nZV9kYXRhIG1yX2RhdGEgPSB7IC5kID0gZCwgLnAybXQgPSBwMm10IH07DQo+PiAt
wqDCoMKgIGludCByZXQ7DQo+PiAtDQo+PiDCoMKgwqDCoMKgIGlmICggZHRfZGV2aWNlX3R5cGVf
aXNfZXF1YWwoZGV2LCAicGNpIikgKQ0KPj4gwqDCoMKgwqDCoCB7DQo+PiArwqDCoMKgwqDCoMKg
wqAgaW50IHJldDsNCj4+ICsNCj4+IMKgwqDCoMKgwqDCoMKgwqDCoCBkdF9kcHJpbnRrKCJNYXBw
aW5nIGNoaWxkcmVuIG9mICVzIHRvIGd1ZXN0XG4iLA0KPj4gwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoCBkdF9ub2RlX2Z1bGxfbmFtZShkZXYpKTsNCj4+IMKgIC3CoMKg
wqDCoMKgwqDCoCByZXQgPSBkdF9mb3JfZWFjaF9pcnFfbWFwKGRldiwgJm1hcF9kdF9pcnFfdG9f
ZG9tYWluLCBkKTsNCj4+ICvCoMKgwqDCoMKgwqDCoCByZXQgPSBkdF9mb3JfZWFjaF9pcnFfbWFw
KGRldiwgJm1hcF9kdF9pcnFfdG9fZG9tYWluLCBtcl9kYXRhKTsNCj4+IMKgwqDCoMKgwqDCoMKg
wqDCoCBpZiAoIHJldCA8IDAgKQ0KPj4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgcmV0dXJu
IHJldDsNCj4+IMKgIC3CoMKgwqDCoMKgwqDCoCByZXQgPSBkdF9mb3JfZWFjaF9yYW5nZShkZXYs
ICZtYXBfcmFuZ2VfdG9fZG9tYWluLCAmbXJfZGF0YSk7DQo+PiArwqDCoMKgwqDCoMKgwqAgcmV0
ID0gZHRfZm9yX2VhY2hfcmFuZ2UoZGV2LCAmbWFwX3JhbmdlX3RvX2RvbWFpbiwgbXJfZGF0YSk7
DQo+PiDCoMKgwqDCoMKgwqDCoMKgwqAgaWYgKCByZXQgPCAwICkNCj4+IMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgIHJldHVybiByZXQ7DQo+PiDCoMKgwqDCoMKgIH0NCj4+IEBAIC0xODQ1LDYg
KzE4MzYsMjAgQEAgc3RhdGljIGludCBfX2luaXQgaGFuZGxlX2RldmljZShzdHJ1Y3QgZG9tYWlu
ICpkLCBzdHJ1Y3QgZHRfZGV2aWNlX25vZGUgKmRldiwNCj4+IMKgwqDCoMKgwqAgaW50IHJlczsN
Cj4+IMKgwqDCoMKgwqAgdTY0IGFkZHIsIHNpemU7DQo+PiDCoMKgwqDCoMKgIGJvb2wgbmVlZF9t
YXBwaW5nID0gIWR0X2RldmljZV9mb3JfcGFzc3Rocm91Z2goZGV2KTsNCj4NCj4gSSBmaW5kIHRo
ZSBkaWZmZXJlbmNlIGJldHdlZW4gLnNraXBfbWFwcGluZyBhbmQgdGhlIGxvY2FsIHZhcmlhYmxl
IG5lZWRfbWFwcGluZyBxdWl0ZSBwdXp6bGluZy4gV2UgYXJlIGxpa2VseSBnb2luZyB0byBtaXN1
c2UgdGhlbSBpbiB0aGUgZnV0dXJlLg0KPg0KPiBJIHRoaW5rIGl0IHdvdWxkIGJlIGNsZWFyZXIg
aWYgdGhlIGxvY2FsIHZhcmlhYmxlIGlzIHJlbmFtZWQgdG8gJ293bl9kZXZpY2UnIG9yIHNpbWls
YXIuDQpPaywgc28gbGV0IGl0IGJlIG93bl9kZXZpY2UNCj4NCj4+ICvCoMKgwqAgLyoNCj4+ICvC
oMKgwqDCoCAqIEZvciBQQ0kgcGFzc3Rocm91Z2ggd2Ugb25seSBuZWVkIHRvIHJlbWFwIHRvIERv
bTAgdGhlIGludGVycnVwdHMNCj4+ICvCoMKgwqDCoCAqIGFuZCBtZW1vcnkgcmFuZ2VzIGZyb20g
InJlZyIgcHJvcGVydHkgd2hpY2ggY292ZXIgY29udHJvbGxlcidzDQo+PiArwqDCoMKgwqAgKiBj
b25maWd1cmF0aW9uIHJlZ2lzdGVycyBhbmQgc3VjaC4gUENJZSBjb25maWd1cmF0aW9uIHNwYWNl
IHJlZ2lzdGVycw0KPj4gK8KgwqDCoMKgICogb2YgdGhlIFBDSWUgUm9vdCBDb21wbGV4IGFuZCBQ
Q0llIGFwZXJ0dXJlIHNob3VsZCBub3QgYmUgbWFwcGVkDQo+PiArwqDCoMKgwqAgKiBhdXRvbWF0
aWNhbGx5IHRvIERvbTAuDQo+PiArwqDCoMKgwqAgKi8NCj4+ICvCoMKgwqAgc3RydWN0IG1hcF9y
YW5nZV9kYXRhIG1yX2RhdGEgPSB7DQo+PiArwqDCoMKgwqDCoMKgwqAgLmQgPSBkLA0KPj4gK8Kg
wqDCoMKgwqDCoMKgIC5wMm10ID0gcDJtdCwNCj4+ICvCoMKgwqDCoMKgwqDCoCAuc2tpcF9tYXBw
aW5nID0gIW5lZWRfbWFwcGluZyB8fA0KPj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqAgKGlzX3BjaV9wYXNzdGhyb3VnaF9lbmFibGVkKCkgJiYNCj4+ICvC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgKGRldmljZV9n
ZXRfY2xhc3MoZGV2KSA9PSBERVZJQ0VfUENJKSkNCj4NCj4gVGhlIGRldmljZSBjbGFzcyBpcyBj
b25mdXNpbmcuIFdoZW4gSSBzZWUgREVWSUNFX1BDSSwgSSB0aGluayB0aGlzIGlzIGEgUENJIGRl
dmljZSB3aGVyZWFzIGhlcmUgeW91IGFyZSByZWZlcnJpbmcgdG8gdGhlIGhvc3RicmlkZ2UuDQo+
DQo+IFVuZm9ydHVuYXRlLCBJIHdhc24ndCBhYmxlIHRvIGNvbW1lbnQgb24gdGhlIG9yaWdpbmFs
IHBhdGNoIGJlZm9yZSBpdCB3YXMgY29tbWl0dGVkLiBCdXQgSSB3b3VsZCBsaWtlIHRoaXMgdG8g
YmUgcmVuYW1lZCB0byBERVZJQ0VfUENJX0hPU1RCUklER0UgZm9yIFhlbiA0LjE2LiBDYW4geW91
IHNlbmQgYSBwYXRjaD8NCk9rLCBJJ2xsIGFkZCBhIHBhdGNoIHdpdGggcy9ERVZJQ0VfUENJL0RF
VklDRV9QQ0lfSE9TVEJSSURHRQ0KPg0KPj4gK8KgwqDCoCB9Ow0KPj4gwqAgwqDCoMKgwqDCoCBu
YWRkciA9IGR0X251bWJlcl9vZl9hZGRyZXNzKGRldik7DQo+PiDCoCBAQCAtMTg4NCw3ICsxODg5
LDYgQEAgc3RhdGljIGludCBfX2luaXQgaGFuZGxlX2RldmljZShzdHJ1Y3QgZG9tYWluICpkLCBz
dHJ1Y3QgZHRfZGV2aWNlX25vZGUgKmRldiwNCj4+IMKgwqDCoMKgwqAgLyogR2l2ZSBwZXJtaXNz
aW9uIGFuZCBtYXAgTU1JT3MgKi8NCj4+IMKgwqDCoMKgwqAgZm9yICggaSA9IDA7IGkgPCBuYWRk
cjsgaSsrICkNCj4+IMKgwqDCoMKgwqAgew0KPj4gLcKgwqDCoMKgwqDCoMKgIHN0cnVjdCBtYXBf
cmFuZ2VfZGF0YSBtcl9kYXRhID0geyAuZCA9IGQsIC5wMm10ID0gcDJtdCB9Ow0KPj4gwqDCoMKg
wqDCoMKgwqDCoMKgIHJlcyA9IGR0X2RldmljZV9nZXRfYWRkcmVzcyhkZXYsIGksICZhZGRyLCAm
c2l6ZSk7DQo+PiDCoMKgwqDCoMKgwqDCoMKgwqAgaWYgKCByZXMgKQ0KPj4gwqDCoMKgwqDCoMKg
wqDCoMKgIHsNCj4+IEBAIC0xODk4LDcgKzE5MDIsNyBAQCBzdGF0aWMgaW50IF9faW5pdCBoYW5k
bGVfZGV2aWNlKHN0cnVjdCBkb21haW4gKmQsIHN0cnVjdCBkdF9kZXZpY2Vfbm9kZSAqZGV2LA0K
Pj4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgcmV0dXJuIHJlczsNCj4+IMKgwqDCoMKgwqAg
fQ0KPj4gwqAgLcKgwqDCoCByZXMgPSBtYXBfZGV2aWNlX2NoaWxkcmVuKGQsIGRldiwgcDJtdCk7
DQo+PiArwqDCoMKgIHJlcyA9IG1hcF9kZXZpY2VfY2hpbGRyZW4oZGV2LCAmbXJfZGF0YSk7DQo+
PiDCoMKgwqDCoMKgIGlmICggcmVzICkNCj4+IMKgwqDCoMKgwqDCoMKgwqDCoCByZXR1cm4gcmVz
Ow0KPj4gwqAgQEAgLTMwNTYsNyArMzA2MCwxNCBAQCBzdGF0aWMgaW50IF9faW5pdCBjb25zdHJ1
Y3RfZG9tMChzdHJ1Y3QgZG9tYWluICpkKQ0KPj4gwqDCoMKgwqDCoMKgwqDCoMKgIHJldHVybiBy
YzsNCj4+IMKgIMKgwqDCoMKgwqAgaWYgKCBhY3BpX2Rpc2FibGVkICkNCj4+ICvCoMKgwqAgew0K
Pj4gwqDCoMKgwqDCoMKgwqDCoMKgIHJjID0gcHJlcGFyZV9kdGJfaHdkb20oZCwgJmtpbmZvKTsN
Cj4+ICvCoMKgwqDCoMKgwqDCoCBpZiAoIHJjIDwgMCApDQo+PiArwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoCByZXR1cm4gcmM7DQo+PiArI2lmZGVmIENPTkZJR19IQVNfUENJDQo+PiArwqDCoMKgwqDC
oMKgwqAgcmMgPSBwY2lfaG9zdF9icmlkZ2VfbWFwcGluZ3MoZCwgcDJtX21taW9fZGlyZWN0X2Mp
Ow0KPg0KPiBJdCBpcyBub3QgY2xlYXIgdG8gbWUgd2h5IHlvdSBhcmUgcGFzc2luZyBwMm1fbW1p
b19kaXJlY3RfYyBhbmQgbm90IHAybXQgaGVyZT8NClRoZXJlIGlzIG5vIHAybXQgaW4gdGhlIGNh
bGxlciBmdW5jdGlvbiwgZS5nLiBjb25zdHJ1Y3RfZG9tMA0KPiBJZiB5b3UgcmVhbGx5IHdhbnQg
dG8gZm9yY2UgYSB0eXBlLCB0aGVuIEkgdGhpbmsgaXQgc2hvdWxkIGJlIHAybV9tbWlvX2RpcmVj
dC4NCkkganVzdCBmb2xsb3dlZCB0aGUgZGVmYXVsdHMgZm91bmQgaW46DQpzdGF0aWMgaW50IF9f
aW5pdCBwcmVwYXJlX2R0Yl9od2RvbShzdHJ1Y3QgZG9tYWluICpkLCBzdHJ1Y3Qga2VybmVsX2lu
Zm8gKmtpbmZvKQ0Kew0KIMKgwqDCoCBjb25zdCBwMm1fdHlwZV90IGRlZmF1bHRfcDJtdCA9IHAy
bV9tbWlvX2RpcmVjdF9jOw0Kd2hpY2ggaXMgYWxzbyBjYWxsZWQgZnJvbSBjb25zdHJ1Y3RfZG9t
MA0KPg0KPiBCdXQgdGhlbiB3aHkgaXMgaXQgYSBwYXJhbWV0ZXIgb2YgcGNpX2hvc3RfYnJpZGdl
X21hcHBpbmdzPyBEbyB5b3UgZXhwZWN0IHNvbWVvbmUgZWxzZSB0byBtb2RpZnkgaXQ/DQpObywg
SSBkb24ndCBleHBlY3QgdG8gbW9kaWZ5IHRoYXQsIEkganVzdCBkb24ndCB3YW50IFBDSSBjb2Rl
IHRvIG1ha2UgZGVjaXNpb25zIG9uIHRoYXQuDQpTbywgSSBmZWVsIG1vcmUgY29tZm9ydGFibGUg
aWYgdGhhdCBkZWNpc2lvbiBpcyB0YWtlbiBpbiBjb25zdHJ1Y3RfZG9tMC4NCg0KU28sIHdoYXQg
ZG8gd2Ugd2FudCBoZXJlPyBQYXNzIGFzIHBhcmFtZXRlciAodGhlbiBwMm1fbW1pb19kaXJlY3Qg
SSBndWVzcywgbm90IHAybV9tbWlvX2RpcmVjdF9jKT8NCk9yIGxldCBQQ0kgY29kZSB1c2UgcDJt
X21taW9fZGlyZWN0IGluc2lkZSBwY2lfaG9zdF9icmlkZ2VfbWFwcGluZ3M/DQo+DQo+PiArI2Vu
ZGlmDQo+PiArwqDCoMKgIH0NCj4+IMKgwqDCoMKgwqAgZWxzZQ0KPj4gwqDCoMKgwqDCoMKgwqDC
oMKgIHJjID0gcHJlcGFyZV9hY3BpKGQsICZraW5mbyk7DQo+PiDCoCBkaWZmIC0tZ2l0IGEveGVu
L2FyY2gvYXJtL3BjaS9lY2FtLmMgYi94ZW4vYXJjaC9hcm0vcGNpL2VjYW0uYw0KPj4gaW5kZXgg
NjAyZDAwNzk5YzhkLi5iODE2MjAwNzRhOTEgMTAwNjQ0DQo+PiAtLS0gYS94ZW4vYXJjaC9hcm0v
cGNpL2VjYW0uYw0KPj4gKysrIGIveGVuL2FyY2gvYXJtL3BjaS9lY2FtLmMNCj4+IEBAIC00MCw2
ICs0MCwxOSBAQCB2b2lkIF9faW9tZW0gKnBjaV9lY2FtX21hcF9idXMoc3RydWN0IHBjaV9ob3N0
X2JyaWRnZSAqYnJpZGdlLA0KPj4gwqDCoMKgwqDCoCByZXR1cm4gYmFzZSArIChQQ0lfREVWRk4y
KHNiZGYuYmRmKSA8PCBkZXZmbl9zaGlmdCkgKyB3aGVyZTsNCj4+IMKgIH0NCj4+IMKgICtib29s
IHBjaV9lY2FtX25lZWRfcDJtX2h3ZG9tX21hcHBpbmcoc3RydWN0IGRvbWFpbiAqZCwNCj4NCj4g
QUZBSUNULCB0aGlzIGlzIG9ubHkgdXNlZCBieSBib290IGNvZGUuIFNvIHlvdSB3YW50IHRvIGRv
IGFkZCBfX2luaXQuDQpNYWtlcyBzZW5zZQ0KPg0KPiBUaGlzIGlzIGFsc28gZXhwb3J0ZWQgYnV0
IG5vdCB1c2VkLiBJIHdvdWxkIHByZWZlciBpZiB3ZSBvbmx5IGV4cG9zZWQgd2hlbiB0aGUgZmly
c3QgZXh0ZXJuYWwgdXNlciB3aWxsIGJlIGludHJvZHVjZWQuDQpaeW5xTVAgaXMgdGhlIGZpcnN0
IHVzZXIgeWV0IGluIHRoaXMgcGF0Y2guIE1vcmUgdG8gY29tZSBwcm9iYWJseSBsYXRlciBvbiB3
aGVuIHdlIGFkZCBvdGhlciBob3N0IGJyaWRnZXMuDQo+DQo+PiArIHN0cnVjdCBwY2lfaG9zdF9i
cmlkZ2UgKmJyaWRnZSwNCj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgdWludDY0X3QgYWRkcikNCj4+ICt7
DQo+PiArwqDCoMKgIHN0cnVjdCBwY2lfY29uZmlnX3dpbmRvdyAqY2ZnID0gYnJpZGdlLT5jZmc7
DQo+PiArDQo+PiArwqDCoMKgIC8qDQo+PiArwqDCoMKgwqAgKiBXZSBkbyBub3Qgd2FudCBFQ0FN
IGFkZHJlc3Mgc3BhY2UgdG8gYmUgbWFwcGVkIGluIERvbWFpbi0wJ3MgcDJtLA0KPj4gK8KgwqDC
oMKgICogc28gd2UgY2FuIHRyYXAgYWNjZXNzIHRvIGl0Lg0KPj4gK8KgwqDCoMKgICovDQo+PiAr
wqDCoMKgIHJldHVybiBjZmctPnBoeXNfYWRkciAhPSBhZGRyOw0KPj4gK30NCj4+ICsNCj4+IMKg
IC8qIEVDQU0gb3BzICovDQo+PiDCoCBjb25zdCBzdHJ1Y3QgcGNpX2VjYW1fb3BzIHBjaV9nZW5l
cmljX2VjYW1fb3BzID0gew0KPj4gwqDCoMKgwqDCoCAuYnVzX3NoaWZ0wqAgPSAyMCwNCj4+IEBA
IC00Nyw2ICs2MCw3IEBAIGNvbnN0IHN0cnVjdCBwY2lfZWNhbV9vcHMgcGNpX2dlbmVyaWNfZWNh
bV9vcHMgPSB7DQo+PiDCoMKgwqDCoMKgwqDCoMKgwqAgLm1hcF9idXPCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqAgPSBwY2lfZWNhbV9tYXBfYnVzLA0KPj4gwqDCoMKgwqDCoMKgwqDCoMKg
IC5yZWFkwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgID0gcGNpX2dlbmVyaWNf
Y29uZmlnX3JlYWQsDQo+PiDCoMKgwqDCoMKgwqDCoMKgwqAgLndyaXRlwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoCA9IHBjaV9nZW5lcmljX2NvbmZpZ193cml0ZSwNCj4+ICvCoMKg
wqDCoMKgwqDCoCAubmVlZF9wMm1faHdkb21fbWFwcGluZyA9IHBjaV9lY2FtX25lZWRfcDJtX2h3
ZG9tX21hcHBpbmcsDQo+PiDCoMKgwqDCoMKgIH0NCj4+IMKgIH07DQo+PiDCoCBkaWZmIC0tZ2l0
IGEveGVuL2FyY2gvYXJtL3BjaS9wY2ktaG9zdC1jb21tb24uYyBiL3hlbi9hcmNoL2FybS9wY2kv
cGNpLWhvc3QtY29tbW9uLmMNCj4+IGluZGV4IDFlYjRkYWE4NzM2NS4uMDg1ZjA4ZTIzZTBjIDEw
MDY0NA0KPj4gLS0tIGEveGVuL2FyY2gvYXJtL3BjaS9wY2ktaG9zdC1jb21tb24uYw0KPj4gKysr
IGIveGVuL2FyY2gvYXJtL3BjaS9wY2ktaG9zdC1jb21tb24uYw0KPj4gQEAgLTE4LDYgKzE4LDcg
QEANCj4+IMKgIMKgICNpbmNsdWRlIDx4ZW4vaW5pdC5oPg0KPj4gwqAgI2luY2x1ZGUgPHhlbi9w
Y2kuaD4NCj4+ICsjaW5jbHVkZSA8YXNtL3NldHVwLmg+DQo+DQo+IEZvciBuZXcgY29kZSwgd2Ug
dXN1YWxseSBpbmNsdWRlIHhlbi8qLmggZmlyc3QgYW5kIHRoZW4gYXNtLyouaC4gVGhleSBhcmUg
dGhlbiBvcmRlciBhbHBoYWJldGljYWxseSB3aXRoaW4gdGhlbXNlbHZlcy4NCk9rDQo+DQo+PiDC
oCAjaW5jbHVkZSA8eGVuL3J3bG9jay5oPg0KPj4gwqAgI2luY2x1ZGUgPHhlbi9zY2hlZC5oPg0K
Pj4gwqAgI2luY2x1ZGUgPHhlbi92bWFwLmg+DQo+PiBAQCAtMzIwLDYgKzMyMSw1NCBAQCBpbnQg
cGNpX2hvc3RfZ2V0X251bV9icmlkZ2VzKHZvaWQpDQo+PiDCoMKgwqDCoMKgIHJldHVybiBjb3Vu
dDsNCj4+IMKgIH0NCj4+IMKgICtpbnQgX19pbml0IHBjaV9ob3N0X2JyaWRnZV9tYXBwaW5ncyhz
dHJ1Y3QgZG9tYWluICpkLCBwMm1fdHlwZV90IHAybXQpDQo+PiArew0KPj4gK8KgwqDCoCBzdHJ1
Y3QgcGNpX2hvc3RfYnJpZGdlICpicmlkZ2U7DQo+PiArwqDCoMKgIHN0cnVjdCBtYXBfcmFuZ2Vf
ZGF0YSBtcl9kYXRhID0gew0KPj4gK8KgwqDCoMKgwqDCoMKgIC5kID0gZCwNCj4+ICvCoMKgwqDC
oMKgwqDCoCAucDJtdCA9IHAybXQsDQo+PiArwqDCoMKgwqDCoMKgwqAgLnNraXBfbWFwcGluZyA9
IGZhbHNlDQo+PiArwqDCoMKgIH07DQo+PiArDQo+PiArwqDCoMKgIC8qDQo+PiArwqDCoMKgwqAg
KiBGb3IgZWFjaCBQQ0kgaG9zdCBicmlkZ2Ugd2UgbmVlZCB0byBvbmx5IG1hcCB0aG9zZSByYW5n
ZXMNCj4+ICvCoMKgwqDCoCAqIHdoaWNoIGFyZSB1c2VkIGJ5IERvbWFpbi0wIHRvIHByb3Blcmx5
IGluaXRpYWxpemUgdGhlIGJyaWRnZSwNCj4+ICvCoMKgwqDCoCAqIGUuZy4gd2UgZG8gbm90IHdh
bnQgdG8gbWFwIEVDQU0gY29uZmlndXJhdGlvbiBzcGFjZSB3aGljaCBsaXZlcyBpbg0KPj4gK8Kg
wqDCoMKgICogInJlZyIgb3IgImFzc2lnbmVkLWFkZHJlc3NlcyIgZGV2aWNlIHRyZWUgcHJvcGVy
dHksIGJ1dCB3ZSB3YW50IHRvDQo+DQo+IEFGQUlVLCAiYXNzaWduZWQtYWRkcmVzc2VzIiBpcyBv
bmx5IHJlbGV2YW50IGZvciB0aGUgY2hpbGQgb2Ygbm9kZXMgd2l0aCB0eXBlPSJwY2kiLiBUaGlz
IGlzIG5vdCB0aGUgY2FzZSBmb3IgdGhlIGhvc3RicmlkZ2VzLiBTbyBJIHRoaW5rIHlvdSB3YW50
IHRvIGRyb3AgdGhlIG1lbnRpb24gb2YgImFzc2lnbmVkLWFkZHJlc3NlcyIuDQpXaWxsIGRyb3AN
Cj4NCj4NCj4+ICvCoMKgwqDCoCAqIG1hcCBvdGhlciByZWdpb25zIG9mIHRoZSBob3N0IGJyaWRn
ZS4gVGhlIFBDSSBhcGVydHVyZSBkZWZpbmVkIGJ5DQo+PiArwqDCoMKgwqAgKiB0aGUgInJhbmdl
cyIgZGV2aWNlIHRyZWUgcHJvcGVydHkgc2hvdWxkIGFsc28gYmUgc2tpcHBlZC4NCj4+ICvCoMKg
wqDCoCAqLw0KPj4gK8KgwqDCoCBsaXN0X2Zvcl9lYWNoX2VudHJ5KCBicmlkZ2UsICZwY2lfaG9z
dF9icmlkZ2VzLCBub2RlICkNCj4+ICvCoMKgwqAgew0KPj4gK8KgwqDCoMKgwqDCoMKgIGNvbnN0
IHN0cnVjdCBkdF9kZXZpY2Vfbm9kZSAqZGV2ID0gYnJpZGdlLT5kdF9ub2RlOw0KPj4gK8KgwqDC
oMKgwqDCoMKgIHVuc2lnbmVkIGludCBpOw0KPj4gKw0KPj4gK8KgwqDCoMKgwqDCoMKgIGZvciAo
IGkgPSAwOyBpIDwgZHRfbnVtYmVyX29mX2FkZHJlc3MoZGV2KTsgaSsrICkNCj4+ICvCoMKgwqDC
oMKgwqDCoCB7DQo+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB1aW50NjRfdCBhZGRyLCBzaXpl
Ow0KPj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqAgaW50IGVycjsNCj4+ICsNCj4+ICvCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgIGVyciA9IGR0X2RldmljZV9nZXRfYWRkcmVzcyhkZXYsIGksICZhZGRy
LCAmc2l6ZSk7DQo+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBpZiAoIGVyciApDQo+PiArwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoCB7DQo+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
IHByaW50ayhYRU5MT0dfRVJSDQo+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqAgIlVuYWJsZSB0byByZXRyaWV2ZSBhZGRyZXNzIHJhbmdlIGluZGV4PSV1IGZv
ciAlc1xuIiwNCj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oCBpLCBkdF9ub2RlX2Z1bGxfbmFtZShkZXYpKTsNCj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqAgcmV0dXJuIGVycjsNCj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIH0NCj4+ICsN
Cj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGlmICggYnJpZGdlLT5vcHMtPm5lZWRfcDJtX2h3
ZG9tX21hcHBpbmcoZCwgYnJpZGdlLCBhZGRyKSApDQo+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oCB7DQo+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGVyciA9IG1hcF9yYW5nZV90
b19kb21haW4oZGV2LCBhZGRyLCBzaXplLCAmbXJfZGF0YSk7DQo+PiArwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgIGlmICggZXJyICkNCj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoCByZXR1cm4gZXJyOw0KPj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqAgfQ0K
Pj4gK8KgwqDCoMKgwqDCoMKgIH0NCj4+ICvCoMKgwqAgfQ0KPj4gKw0KPj4gK8KgwqDCoCByZXR1
cm4gMDsNCj4+ICt9DQo+PiArDQo+PiDCoCAvKg0KPj4gwqDCoCAqIExvY2FsIHZhcmlhYmxlczoN
Cj4+IMKgwqAgKiBtb2RlOiBDDQo+PiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gvYXJtL3BjaS9wY2kt
aG9zdC16eW5xbXAuYyBiL3hlbi9hcmNoL2FybS9wY2kvcGNpLWhvc3QtenlucW1wLmMNCj4+IGlu
ZGV4IDYxYTk4MDdkM2Q1OC4uNmFkMmIzMWU4MTBkIDEwMDY0NA0KPj4gLS0tIGEveGVuL2FyY2gv
YXJtL3BjaS9wY2ktaG9zdC16eW5xbXAuYw0KPj4gKysrIGIveGVuL2FyY2gvYXJtL3BjaS9wY2kt
aG9zdC16eW5xbXAuYw0KPj4gQEAgLTM0LDYgKzM0LDcgQEAgY29uc3Qgc3RydWN0IHBjaV9lY2Ft
X29wcyBud2xfcGNpZV9vcHMgPSB7DQo+PiDCoMKgwqDCoMKgwqDCoMKgwqAgLm1hcF9idXPCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgPSBwY2lfZWNhbV9tYXBfYnVzLA0KPj4gwqDCoMKg
wqDCoMKgwqDCoMKgIC5yZWFkwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgID0g
cGNpX2dlbmVyaWNfY29uZmlnX3JlYWQsDQo+PiDCoMKgwqDCoMKgwqDCoMKgwqAgLndyaXRlwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCA9IHBjaV9nZW5lcmljX2NvbmZpZ193cml0
ZSwNCj4+ICvCoMKgwqDCoMKgwqDCoCAubmVlZF9wMm1faHdkb21fbWFwcGluZyA9IHBjaV9lY2Ft
X25lZWRfcDJtX2h3ZG9tX21hcHBpbmcsDQo+PiDCoMKgwqDCoMKgIH0NCj4+IMKgIH07DQo+PiDC
oCBkaWZmIC0tZ2l0IGEveGVuL2luY2x1ZGUvYXNtLWFybS9wY2kuaCBiL3hlbi9pbmNsdWRlL2Fz
bS1hcm0vcGNpLmgNCj4+IGluZGV4IGE3MWIwZWVhOGNiOS4uYjViODVjY2QwOTM3IDEwMDY0NA0K
Pj4gLS0tIGEveGVuL2luY2x1ZGUvYXNtLWFybS9wY2kuaA0KPj4gKysrIGIveGVuL2luY2x1ZGUv
YXNtLWFybS9wY2kuaA0KPj4gQEAgLTE3LDYgKzE3LDggQEANCj4+IMKgIMKgICNpZmRlZiBDT05G
SUdfSEFTX1BDSQ0KPj4gwqAgKyNpbmNsdWRlIDxhc20vcDJtLmg+DQo+PiArDQo+PiDCoCAjZGVm
aW5lIHBjaV90b19kZXYocGNpZGV2KSAoJihwY2lkZXYpLT5hcmNoLmRldikNCj4+IMKgIMKgIGV4
dGVybiBib29sIHBjaV9wYXNzdGhyb3VnaF9lbmFibGVkOw0KPj4gQEAgLTczLDYgKzc1LDkgQEAg
c3RydWN0IHBjaV9vcHMgew0KPj4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB1
aW50MzJfdCByZWcsIHVpbnQzMl90IGxlbiwgdWludDMyX3QgKnZhbHVlKTsNCj4+IMKgwqDCoMKg
wqAgaW50ICgqd3JpdGUpKHN0cnVjdCBwY2lfaG9zdF9icmlkZ2UgKmJyaWRnZSwgcGNpX3NiZGZf
dCBzYmRmLA0KPj4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHVpbnQzMl90
IHJlZywgdWludDMyX3QgbGVuLCB1aW50MzJfdCB2YWx1ZSk7DQo+PiArwqDCoMKgIGJvb2wgKCpu
ZWVkX3AybV9od2RvbV9tYXBwaW5nKShzdHJ1Y3QgZG9tYWluICpkLA0KPj4gK8KgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
IHN0cnVjdCBwY2lfaG9zdF9icmlkZ2UgKmJyaWRnZSwNCj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB1aW50NjRf
dCBhZGRyKTsNCj4+IMKgIH07DQo+PiDCoCDCoCAvKg0KPj4gQEAgLTk2LDYgKzEwMSw5IEBAIGlu
dCBwY2lfZ2VuZXJpY19jb25maWdfd3JpdGUoc3RydWN0IHBjaV9ob3N0X2JyaWRnZSAqYnJpZGdl
LCBwY2lfc2JkZl90IHNiZGYsDQo+PiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgdWludDMyX3QgcmVnLCB1aW50MzJfdCBsZW4sIHVp
bnQzMl90IHZhbHVlKTsNCj4+IMKgIHZvaWQgX19pb21lbSAqcGNpX2VjYW1fbWFwX2J1cyhzdHJ1
Y3QgcGNpX2hvc3RfYnJpZGdlICpicmlkZ2UsDQo+PiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHBjaV9zYmRmX3Qgc2JkZiwg
dWludDMyX3Qgd2hlcmUpOw0KPj4gK2Jvb2wgcGNpX2VjYW1fbmVlZF9wMm1faHdkb21fbWFwcGlu
ZyhzdHJ1Y3QgZG9tYWluICpkLA0KPj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBzdHJ1Y3QgcGNpX2hvc3Rf
YnJpZGdlICpicmlkZ2UsDQo+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHVpbnQ2NF90IGFkZHIpOw0KPj4g
wqAgc3RydWN0IHBjaV9ob3N0X2JyaWRnZSAqcGNpX2ZpbmRfaG9zdF9icmlkZ2UodWludDE2X3Qg
c2VnbWVudCwgdWludDhfdCBidXMpOw0KPj4gwqAgaW50IHBjaV9nZXRfaG9zdF9icmlkZ2Vfc2Vn
bWVudChjb25zdCBzdHJ1Y3QgZHRfZGV2aWNlX25vZGUgKm5vZGUsDQo+PiDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgdWlu
dDE2X3QgKnNlZ21lbnQpOw0KPj4gQEAgLTExMyw2ICsxMjEsOCBAQCBpbnQgcGNpX2hvc3RfaXRl
cmF0ZV9icmlkZ2VzKHN0cnVjdCBkb21haW4gKmQsDQo+PiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgIHN0cnVjdCBwY2lfaG9zdF9icmlkZ2UgKmJyaWRnZSkpOw0KPj4gwqAgaW50IHBjaV9ob3N0
X2dldF9udW1fYnJpZGdlcyh2b2lkKTsNCj4+IMKgICtpbnQgcGNpX2hvc3RfYnJpZGdlX21hcHBp
bmdzKHN0cnVjdCBkb21haW4gKmQsIHAybV90eXBlX3QgcDJtdCk7DQo+PiArDQo+PiDCoCAjZWxz
ZcKgwqAgLyohQ09ORklHX0hBU19QQ0kqLw0KPj4gwqAgwqAgc3RydWN0IGFyY2hfcGNpX2RldiB7
IH07DQo+PiBkaWZmIC0tZ2l0IGEveGVuL2luY2x1ZGUvYXNtLWFybS9zZXR1cC5oIGIveGVuL2lu
Y2x1ZGUvYXNtLWFybS9zZXR1cC5oDQo+PiBpbmRleCA5NWRhMGI3YWI5Y2QuLjg4ZDk2NzNkYjgx
NyAxMDA2NDQNCj4+IC0tLSBhL3hlbi9pbmNsdWRlL2FzbS1hcm0vc2V0dXAuaA0KPj4gKysrIGIv
eGVuL2luY2x1ZGUvYXNtLWFybS9zZXR1cC5oDQo+PiBAQCAtMiw2ICsyLDggQEANCj4+IMKgICNk
ZWZpbmUgX19BUk1fU0VUVVBfSF8NCj4+IMKgIMKgICNpbmNsdWRlIDxwdWJsaWMvdmVyc2lvbi5o
Pg0KPj4gKyNpbmNsdWRlIDxhc20vcDJtLmg+DQo+PiArI2luY2x1ZGUgPHhlbi9kZXZpY2VfdHJl
ZS5oPg0KPj4gwqAgwqAgI2RlZmluZSBNSU5fRkRUX0FMSUdOIDgNCj4+IMKgICNkZWZpbmUgTUFY
X0ZEVF9TSVpFIFNaXzJNDQo+PiBAQCAtNzcsNiArNzksMTQgQEAgc3RydWN0IGJvb3RpbmZvIHsN
Cj4+IMKgICNlbmRpZg0KPj4gwqAgfTsNCj4+IMKgICtzdHJ1Y3QgbWFwX3JhbmdlX2RhdGENCj4+
ICt7DQo+PiArwqDCoMKgIHN0cnVjdCBkb21haW4gKmQ7DQo+PiArwqDCoMKgIHAybV90eXBlX3Qg
cDJtdDsNCj4+ICvCoMKgwqAgLyogU2V0IGlmIG1hcHBpbmcgb2YgdGhlIG1lbW9yeSByYW5nZXMg
bXVzdCBiZSBza2lwcGVkLiAqLw0KPj4gK8KgwqDCoCBib29sIHNraXBfbWFwcGluZzsNCj4+ICt9
Ow0KPj4gKw0KPj4gwqAgZXh0ZXJuIHN0cnVjdCBib290aW5mbyBib290aW5mbzsNCj4+IMKgIMKg
IGV4dGVybiBkb21pZF90IG1heF9pbml0X2RvbWlkOw0KPj4gQEAgLTEyNCw2ICsxMzQsOSBAQCB2
b2lkIGRldmljZV90cmVlX2dldF9yZWcoY29uc3QgX19iZTMyICoqY2VsbCwgdTMyIGFkZHJlc3Nf
Y2VsbHMsDQo+PiDCoCB1MzIgZGV2aWNlX3RyZWVfZ2V0X3UzMihjb25zdCB2b2lkICpmZHQsIGlu
dCBub2RlLA0KPj4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqAgY29uc3QgY2hhciAqcHJvcF9uYW1lLCB1MzIgZGZsdCk7DQo+PiDCoCAraW50IG1hcF9y
YW5nZV90b19kb21haW4oY29uc3Qgc3RydWN0IGR0X2RldmljZV9ub2RlICpkZXYsDQo+PiArwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB1NjQgYWRkciwgdTY0
IGxlbiwgdm9pZCAqZGF0YSk7DQo+PiArDQo+PiDCoCAjZW5kaWYNCj4+IMKgIC8qDQo+PiDCoMKg
ICogTG9jYWwgdmFyaWFibGVzOg0KPj4NCj4NCg==


From xen-devel-bounces@lists.xenproject.org Mon Oct 25 11:44:14 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Oct 2021 11:44:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.215764.375129 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1meyOe-0008IZ-Ew; Mon, 25 Oct 2021 11:44:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 215764.375129; Mon, 25 Oct 2021 11:44:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1meyOe-0008IS-Br; Mon, 25 Oct 2021 11:44:08 +0000
Received: by outflank-mailman (input) for mailman id 215764;
 Mon, 25 Oct 2021 11:44:06 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=G2Ub=PN=citrix.com=roger.pau@srs-us1.protection.inumbo.net>)
 id 1meyOc-0008IM-IA
 for xen-devel@lists.xenproject.org; Mon, 25 Oct 2021 11:44:06 +0000
Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id db155680-3588-11ec-840e-12813bfff9fa;
 Mon, 25 Oct 2021 11:44:05 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: db155680-3588-11ec-840e-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1635162245;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=9xI6qRiq4Un/z1/Vv7HZLttkDsz8PDALHTyqsCd2u+s=;
  b=clwFIl0Fwz7Yui5l1JSyMYaclOQIEIwUXRKIVS959xybNIp2V2PSQyt4
   d7xNgKqPbJuaSJtM5Ph/uICu17uYlu6fgGk4KL94xM7Z7kKhP+0JYtN8f
   L7r7KMVHip5aG8+EmLPs+pgXXdcdw/+rXDFsvrjrgIaO9cAv09mQNUMYl
   s=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: 1HNTxFrdlLGQSG6nsrBlF1aub7i86xExqVG8BYSniBe6OVNnBtTZHYEiZYkaYZBGA3r2YyWyU8
 ue2nT64REwiKngHsVPdcuudHUZPV7SP30PyvaCG2LOJI6t3iFwJuLNbkVBY0AoSKkwff0TlVh+
 /eSJ5Z604tYMzARz/3fK7eH9LbLIjqYImBE+lAm16e5+RssuykiCOXnnwYcmnG3LQ0vFvkzo7f
 Why8RvUo2Rn4eCwE7FcTuhvQmrKVQf50IPPniN/H3uEFMkj6vs0srf1j8RPQhvF3nC3TnljsEG
 YShpGh6PdyqzSu60VBCcM1Zi
X-SBRS: 5.1
X-MesageID: 55528886
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:cH1aQq4ppVNFFZieuTRlsQxRtEvBchMFZxGqfqrLsTDasY5as4F+v
 jYeXjrTOq7ZMGCjc94ibo6z/EoP7ZSBnIRqSVFs+CgzHi5G8cbLO4+Ufxz6V8+wwmwvb67FA
 +E2MISowBUcFyeEzvuV3zyIQUBUjclkfJKlYAL/En03FVAMpBsJ00o5wrdh2NMw2LBVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Zy
 Oxfv7ysQywTGbDzkb4yCTpyCzpcIvgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALNs7kMZlZonh95TrYEewnUdbIRKCiCdpwgWpt3JAeTai2i
 8wxVAZhNi3bOzx2BGwQN5Mag+CknyLcWmgNwL6SjfVuuDWCpOBr65DpMdzIapmSTsR9gEmVv
 CTF8n7/DxVcM8aQoRKH/WirnfTnhj7gVcQZE7jQ3vtjknWQy3YVBRlQUkG0ydGph0j7V99BJ
 kg8/is1sbN05EGtVsP6XRCzvDiDpBF0c8ZfF/0S7ACL17bO5ACYFi4IQ1ZpatUguNUnWD8C2
 VqAntevDjtq2JWZVneCrJ+Vqz2oMCQYJGNEYjULJSMH5MLurqk0gh/VSt9lHOiug7XdGTz0z
 DmDtwA9iq8VgMpN0L+0lXjNhCitvd7OVRIv4RvMXXON6Rlwb4qoIYev7DDmAe1oddjDCAPb5
 T5dxpbYvLtm4YyxeDKlQNwfFpG17d2/FyDjiARARboL7y+P5Cv2FWxP2w1WKEBsO8cCXDbmZ
 k7PpA9cjKNu0GuWgbxfON3pVZx7pUT0PZG8DKqMN4sRCnRkXFbfpHkGWKKG44z6fKHAe4kEM
 pCHbd3kM38eDal2pNZdb7ZAieF1rszSKGW6eHwa8/hF+efGDJJ2Ye1cWLdrUgzexPjcyDg5C
 /4Fa6O3J+x3CYUSmBX//48JNkwtJnMmH53woME/XrfdeVc/QDl7WqeJm+NJl2lZc0J9zLegE
 paVARcw9bYCrSefdVXiho5LMeuHsWlDQYITYnV3YAfAN4kLaoez9qYPH6bbjpF8nNGPOcVcF
 qFfE+3ZW6wnYm2ep1w1MMmsxKQ/JU/DrV/fYEKYjM0XIscIq/rhoYS/IGMCNUAmU0KKiCfJi
 +Txhl2AGcFYGVUK4QS/QKvH8m5ddEM1wYpad0DJPsNSaAPr9o1rIDb2lfg5P4cHLhCr+9dQ/
 1/+7c4wqbafrokr3sPOgKzY/Y6lH/EnRhhRHnXB7KbwPi7fpzLxzYhFWeeOXDbcSGKrp/nyO
 bQLl6nxYK8dgVJHk4tgCLI3n6gw0MTi+u1BxQN+EXSVM1nyUuF8ImOL1NVkv7FWwuMLohO/X
 0+Co4EIObiANM7/PkQWIQ4pMraK2f0Ow2GA5vUpOkTqoiRw+ePfA0lVOhCNjg1bLad0b9x5k
 btw5pZO5lXm2BQwM9uAgiRFzEi2LyQNA/c9q5UXII73kQ53mFtMVoPRV33t65aVZtQSbkRze
 m2IhLDPjqh3z1bZdyZhDmDE2OdQiMhcuB1Oy1NedV2FlsCc260y1RxVtz82Uh5U3lNM1OcqY
 jpnMEh8JKOv+TZ0hZccAzDwSl8ZXBDJqFbsz1YplXHCSxj6X2PAG2QxJOKR8R1L6GlbZDVao
 OmVxWuNvewGpy0tMv/egXJYlsE=
IronPort-HdrOrdr: A9a23:ZdN5p6nuKu/ofkq2qcj3MdPzzDPpDfPKimdD5ihNYBxZY6Wkfp
 +V8sjzhCWatN9OYh0dcLC7WJVpQRvnhPhICK0qTMqftWjdyRGVxeRZjLcKrAeQfhEWmtQtsZ
 uINpIOdOEYbmIK/PoSgjPIa+rIqePvmMvD6Ja8vhUdPT2CKZsQlDuRYjzrbHGeLzM2fKbReq
 Dsgfau8FGbCAsqh4mAdzM4dtmGg+eOuIPtYBYACRJiwA6SjQmw4Lq/NxSDxB8RXx5G3L9nqA
 H+4kDEz5Tml8v+5g7X1mfV4ZgTsNz9yuFbDMjJrsQOMD3jhiuheYwkcbyfuzIepv2p9T8R4Z
 TxiiZlG/42x2Laf2mzrxeo8w780Aw243un8lOciWuLm72xeBsKT+56wa5JeBrQ7EQt+Ptm1r
 hQ4m6fv51LSTvdgSXU/bHzJlBXv3vxhUBnvf8YjnRZX4dbQqRWt5Yj8ERcF4pFND7m6bogDP
 JlAKjnlbhrmGuhHjPkV1RUsZ6RtixZJGbCfqFCgL3b79FupgE486NCr/Zv2kvp9/oGOu95Dq
 r/Q+NVfYp1P70rhJRGdZA8qPuMex/wqC33QRevyHTcZek60iH22tXKCItc3pDfRHVP9up1pK
 j8
X-IronPort-AV: E=Sophos;i="5.87,180,1631592000"; 
   d="scan'208";a="55528886"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=n5HafTh1R15TvSoOC4LwpQIFMb0hbY8AowQa1iyOKLkMZp3GvtbjwZPxPJfbaXDDL8TUTksak7wq4l/ziJLlkXmAEu9ShWc8J/W9Oc8HWHGrMFAJf8q11NAKv5wQigSKEo2/cP9TzkQ4kqF+yYGljWSh0KJbbUpYGKszUYNc37o8tQZisvpYqDwbNbS2xJ98UK1dQVaaIkNNKhAGqAbKsCXJu+mBBHhGK/qd8kLm+bvt0d8nDUkfZRXRWl6N4IwFpnKWD8/wR0TgGlg46pefwD8MwYXqsc50TGv70Ihtl791gYPgQqhTD4ee7dJQZcH8Pyy8rHbjIzRFvDEMl3KrHg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=7FpfaW3BRyX1N9WZkadSTTzAgNcRaEKnF+r1qoySrlE=;
 b=AvpUWnQsSfNnRvaU99jyGBhnEWgvCdjcEBmVI15zDXdTZkmkupEMBpCsF/TC5o7KYWEjlXo5uvpHlML73YTjD3780eVojgIArqb4D8mv1/0VfppofBjjmUSfyYckFf2Cx+sa+ReDZOiWhAxaqClaM9D40qXffA9DjSvm3vyd88CEz+m4L2dYJeTjzFeqPFgAUoKcpOmpYhBWQxh0AZ19RORtNb7cMDsfSfo+1O88hkBSYWZ8dA645/GdstaDcUPbI8i+eXJLvU+a+rZ5A0S8eLiqj0TKyAiIoBKwmz+jiCKNpAvxNiOGXrk7zW5SjpVpe2BLQtAr9VWDTESvnAE2lA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=7FpfaW3BRyX1N9WZkadSTTzAgNcRaEKnF+r1qoySrlE=;
 b=vYSgmG+S/SbqpmPymTDMe7JEOL7oO4z6NW56wrCTShR5WdSUrn6Qxqy01usBDF5YETjn/Jb7Ah9JmGCuy5eRcnv6Fpr6wLS/EGi01G5PMlOvr056I97aItzF2SfD5QcZV7hBHbXTOJ+FONV0DgkBpjtKaei9lTWj7CMEbsdJXU8=
Date: Mon, 25 Oct 2021 13:43:55 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: David Woodhouse <dwmw2@infradead.org>
CC: Jason Andryuk <jandryuk@gmail.com>, <josef@oderland.se>,
	<boris.ostrovsky@oracle.com>, <helgaas@kernel.org>, <jgross@suse.com>,
	<linux-pci@vger.kernel.org>, <maz@kernel.org>, <tglx@linutronix.de>,
	<xen-devel@lists.xenproject.org>
Subject: Re: [PATCH] PCI/MSI: Fix masking MSI/MSI-X on Xen PV
Message-ID: <YXaYe/RF6NWFKxGj@MacBook-Air-de-Roger.local>
References: <90277228-cf14-0cfa-c95e-d42e7d533353@oderland.se>
 <20211025012503.33172-1-jandryuk@gmail.com>
 <eb38c1d2707d03bf675d7b15f014cbe741de0998.camel@infradead.org>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <eb38c1d2707d03bf675d7b15f014cbe741de0998.camel@infradead.org>
X-ClientProxiedBy: MR2P264CA0148.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:501:1::11) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 386bb8a2-1487-4169-addb-08d997acbd70
X-MS-TrafficTypeDiagnostic: DM4PR03MB5997:
X-Microsoft-Antispam-PRVS: <DM4PR03MB5997A11F8D65EB5A5BD37AAE8F839@DM4PR03MB5997.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:1186;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: fCTLK71ASZFRfJO4AmtSEEe5r3u8L4Z1Z7fRD55qd9ZpoH+Xk8cYzV1Poqdu9ML00VTiNa/7qXlZHT/Vo7hLhhhvi7w3pEAjoi9VugOgzidV7hwDnojVQgciT1sGzgivReUe7wymBI4Npp4LFl9lfBip4Tq8TbS2CidgQDxjDO5LVGQQnXfUWWzUH5Zl5ySpgSLSE5z00ge6NulsqBAi2nOWZrIABt49SJVk11MC2ziXm/SV4JWtDZzh9FrQPdsNSNA+iHmYtF9A5vVuDZ8IlewOGVRx58yPBPA0ce19gA2VPFbwJDhpqXqmyhGQMWTsA/Y598VfBCdLMS92BTX2u0cu2+qHD4zG3F9bV3Fb46mZ/jb7Ld0nEDMtpozq2h6dYBa9MpGV96goLHF/vbmlRM0Es5p6zLjm/NNkwxFtJpXm8RCowEpF++puR3qyDrWzmTxw5geJz1f53N+fVI6zhaQBsB5qF3YtVnt+x9f5zijwBbBhUL7p5U/ujuuMomljtmhhWfE19albpTAJKLogjREmLD6q/i4d7jS1tHXEvRRmIpXu9zF7r19GW5BAsPGhpeQh5W1+o5Iv3Un+wmGDfk+lNjbMTs0KTNasLdvoSLg72r9S5BeO15ppeUkKbuTuBfnFIduvG5syBEdueW9MCg==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(6486002)(66946007)(66476007)(5660300002)(2906002)(86362001)(508600001)(26005)(186003)(85182001)(4326008)(956004)(7416002)(38100700002)(316002)(4001150100001)(6496006)(9686003)(8676002)(82960400001)(8936002)(6666004)(6916009)(83380400001)(66556008);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Y25Oak1ndUIvWW5oeGwyYkppR1lES1NEYTZKTXYvTkdvWm1NbVNMTys3MWFG?=
 =?utf-8?B?RGw5YTJNVnE2UTI0V3h4Sk95M3E5YkJtY0ZIWDA1a0FEUnF6cEtpamZhVG1w?=
 =?utf-8?B?aUZrVFhWSWtCUWQ3T3hZd1ZYbm83TDBob0Mxc0VwRnMxaWxwSC95Z1grUzZW?=
 =?utf-8?B?VFRpampEc2U3eHZ4aHVmK2NCUmY2emJKMXF4c2gwOEJDSit2aXZLN0dLZ1I4?=
 =?utf-8?B?MDBMY0hDTnVCQk56TDIrYjUwdy85K0piRGljVVpjbDE2WDhVcGxreCtIc3Rt?=
 =?utf-8?B?cVFvczB5cmdFUm9HanFBRHBnd3NJZmJUSHlrQkZkMkRvWllpdUxxZzAyS3RH?=
 =?utf-8?B?T0p4TmpsYWtJVno2TjhrSW5JSmhrRXRsck0zUjkzZUdUL1V4T2o0SDgySU55?=
 =?utf-8?B?T2RWNHk5WTdSN1VVelhVSlFwdXczMU41UGprcmZNcDF6T0VxcFBCNUNIMGhu?=
 =?utf-8?B?M2pwSzR4S1NINzhpZGRjcDhHRnFxWUNwdnYzZ0IzWlhHM0gvYzMzUE85Tnp6?=
 =?utf-8?B?RVN5WENsbit3WjNLWW5lcGltUFdLaUFBN1lBOHA1ekJoVFJHU05GaFFBNTln?=
 =?utf-8?B?Vy96SUxycWJYcXIwSGdDWVdXUVpPT0tGdENaV3ZTOFlmamNEWGJTUzhyYThB?=
 =?utf-8?B?Vk9IanB5L1krTkh5Wk11U2d3c29CS3owcmRYMFgzbTc2Q1R4ZTZzeDhYZy9l?=
 =?utf-8?B?QzBEb3FXTHJpNVhOUDJvelB0N2Y1V2dSYzJmSnJ0SVJWZG5MMFE1WFk1NjZw?=
 =?utf-8?B?ZG9rVThDL0pIcC9vcVp4NUNOSGZPdXFXV0tEUnZYb0o2OWZWOE80ajczUzFT?=
 =?utf-8?B?ME1ZSkJydVlScmxpWERuaC8ramIzWnhadWhqSnRzZm0vOEkwNU9ENTVFUTZy?=
 =?utf-8?B?cWJEVkVVaUY0V3FiRXhqbXBIMTVKL3owWHlVUWlXdG9tTXpBUlUreUFpaHNG?=
 =?utf-8?B?ME1JRTFtVlZxMDlsT0hyM04rTmZCSmNxdVY3MUh3NHBjRHhJVXVLYmx0cU9Q?=
 =?utf-8?B?R2xrdzBKUCtFR2RaVzY0Q0VPdmlxUDFVQVN1dkFUZWd3OW1TY0dJRW9BbnU0?=
 =?utf-8?B?TExzSXduTEZQWFYrS3BQRWxielFPSER3dEx6MUdSMXE2ajlPbkhMTGF3RENL?=
 =?utf-8?B?MFl4Z05mZ0VZNmt0UTN6bkdacUtodVl6Y3NPSzVJaFMzMXFDTzNyQ3RTdWRY?=
 =?utf-8?B?TjB2RlJzMnVVUEJIUEMvY1ArcjFVWTVkTWlsczVTQWsrcVlaNVAvdzZUMHYy?=
 =?utf-8?B?K0o1UlordnF0R1JOSXFGLzg3N2Fnbnk0b3FkWXFQSHA1M2FPcjRnaE5mY29j?=
 =?utf-8?B?Y1FzUGxKU0V5VmRQQXNvQkw2SnkwcFBrODNPWnU1aFRmQ3BQOXI2Z3ZwYTYx?=
 =?utf-8?B?V0x5M0VxT3BRY0V6RE11TTVYdmlsbCtaMEFzY1Yza2ZldStBei92RFdUUVN2?=
 =?utf-8?B?RjRINnUxRDdoajZWZWxIY3c3VzJDeWlKa0NOd1dRaFlmeEFZTCtsMEtKa2t6?=
 =?utf-8?B?UDUyK2hCejd1NnFoc0FLemhSQVQ2L0ZlNFM0MERZNFgycHJQTElSSzVtTTdn?=
 =?utf-8?B?RUhseStyR2h1ZUFnbVhmNDkxbE9lRXNWU3J5YmViODF2cy96VmVIVlpJeUVM?=
 =?utf-8?B?MktFNEwxZGdPUUg4MVRHMnhnWmRGV1VtQXp1NGJESzNnSExvUzFDQ0kzY0pp?=
 =?utf-8?B?aTBpdWpvbDZEUWRRdXhxSEdHV25IR09XMko1d1V3YUFIbGNGSXpScU0zVGhQ?=
 =?utf-8?B?SmN1K1pSdGdMWnJEOHRSWkVCZ2U1K05jdElOSnJIbjY1WVhaTUp3LzRzYmFn?=
 =?utf-8?B?VmYvUDhJS0liRUNwMjVjc1VvdkNxekRmcVF3UWV4bzFDNzBDbDRYVFVMcVg4?=
 =?utf-8?B?ZUl2cEJ0ZXdHbitIUnFSbmZaWU5Wbkk0Q2ZzMnZNeTFQNzdoNjZ5eXZWcys4?=
 =?utf-8?B?ZDRDYXMwVFhFaTVKRjR6N0xCT3QzanEwdjdadTVaNUt4Z1ZvTHFlTW05L0wy?=
 =?utf-8?B?aGZSYjBIMTU4c1lrUmFySmM5LzhQOUphZmc4Ly8xNnduSmFON1dFYzh3L1R5?=
 =?utf-8?B?UHpUcXl1ZGwra2p1a0pEdWFBZkt2QlIvV0JYZDBCeEdyYVZLNFJxY25Hc3h4?=
 =?utf-8?B?OXROK0E3azIvS1o4cnJiMkF1aDFHajJEZEkxSmFzd0hDRlpNbG1vK3ZsV1d1?=
 =?utf-8?Q?7lmn9EEUNgSYMjsUvoB2SIk=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 386bb8a2-1487-4169-addb-08d997acbd70
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2021 11:44:02.0552
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: BFWGYLJj5W9bJgP72YE9ZvUt7pWKmFMTsgrFapJ6bH2Q+OdA4EwUWmH2ay6bR1ScOfA5BTMcB4Jcb65YEdZrWw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR03MB5997
X-OriginatorOrg: citrix.com

On Mon, Oct 25, 2021 at 08:44:52AM +0100, David Woodhouse wrote:
> On Sun, 2021-10-24 at 21:25 -0400, Jason Andryuk wrote:
> > commit fcacdfbef5a1 ("PCI/MSI: Provide a new set of mask and unmask
> > functions") introduce functions pci_msi_update_mask() and
> > pci_msix_write_vector_ctrl() that is missing checks for
> > pci_msi_ignore_mask that exists in commit 446a98b19fd6 ("PCI/MSI: Use
> > new mask/unmask functions").  The checks are in place at the high level
> > __pci_msi_mask_desc()/__pci_msi_unmask_desc(), but some functions call
> > directly to the helpers.
> > 
> > Push the pci_msi_ignore_mask check down to the functions that make
> > the actual writes.  This keeps the logic local to the writes that need
> > to be bypassed.
> > 
> > With Xen PV, the hypervisor is responsible for masking and unmasking the
> > interrupts, which pci_msi_ignore_mask is used to indicate.
> 
> This isn't just for Xen PV; Xen HVM guests let Xen unmask the MSI for
> them too.

It's kind of optional for HVM guests, as it depends on
XENFEAT_hvm_pirqs, which sadly gets unconditionally set for HVM
guests, thus dropping any benefits from having hardware assisted APIC
virtualization or posted interrupts support.

AFAICT pci_msi_ignore_mask is not (correctly) set for HVM guest when
MSI interrupts are routed over event channels.

Regards, Roger.


From xen-devel-bounces@lists.xenproject.org Mon Oct 25 11:52:12 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Oct 2021 11:52:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.215771.375140 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1meyWN-0001JE-7k; Mon, 25 Oct 2021 11:52:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 215771.375140; Mon, 25 Oct 2021 11:52:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1meyWN-0001J7-44; Mon, 25 Oct 2021 11:52:07 +0000
Received: by outflank-mailman (input) for mailman id 215771;
 Mon, 25 Oct 2021 11:52:05 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=1v/+=PN=epam.com=prvs=0932af52eb=oleksandr_andrushchenko@srs-us1.protection.inumbo.net>)
 id 1meyWL-0001J1-Oz
 for xen-devel@lists.xenproject.org; Mon, 25 Oct 2021 11:52:05 +0000
Received: from mx0a-0039f301.pphosted.com (unknown [148.163.133.242])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 26b02925-b9d7-4a5c-8c6e-48df1b6af1b0;
 Mon, 25 Oct 2021 11:52:03 +0000 (UTC)
Received: from pps.filterd (m0174676.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 19PAVjHj018300; 
 Mon, 25 Oct 2021 11:52:02 GMT
Received: from eur02-am5-obe.outbound.protection.outlook.com
 (mail-am5eur02lp2051.outbound.protection.outlook.com [104.47.4.51])
 by mx0a-0039f301.pphosted.com with ESMTP id 3bwrvagujd-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Mon, 25 Oct 2021 11:52:01 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by AM0PR03MB5009.eurprd03.prod.outlook.com (2603:10a6:208:105::33)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.18; Mon, 25 Oct
 2021 11:51:57 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::c038:e032:595a:651]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::c038:e032:595a:651%8]) with mapi id 15.20.4628.020; Mon, 25 Oct 2021
 11:51:57 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 26b02925-b9d7-4a5c-8c6e-48df1b6af1b0
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Vu11CsIGfiN2RqIulJIaMKJJTbjEiCX11z2hYYsBT16/4P9n0TErDcdOje6nfrdSoNpQxPSil/hdqTRAyofJM4VzrG1wpXKKRnB6O7yKS7XWJLG03iwHaiLZuOR0BOBnB6tUWjXeDZrf4t8BKHrZb6OSoMP7fUFThN1MuTttfkXyiRC5fhlAGmfPJGKLWgvKhAerHgyIxvgdyfi99Lh8uRhtBTYnO0g7iIhv+Vd4QNW0J14ij8GC9ezytd4PWj8G19gCYJb1T6zSSfUf9vC6TAWP4F8vWTkh6SXZbJQEwkXGi/FeXb74Kk+3JlwtUDgSqJq52XjfFsqBhJUAOeyJfA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=diyFJu3exAB9XQupRDEjylhswIDofa3cZIW7OV+c/EE=;
 b=fJrH6oiqiuEa3vDHaPujKzEoOQeDnYRmYLeIAKY44UH9+v0oHveFFVh7ydhbm9rYK/QpkUDOX3Kyfpf9Eu0nKAuHuzlxJeDiQrLCK0B3b1LBEcq41xX0eB6uTYX+bSvetZNr9nFIXMpelyKh2VmP1bFeHnWByTH3GUoHgz7sWTwYQ67kRxV95yzwTjYk93+CGM3diwZovHBv/rEUl5pGniarYicKD4tBhT709gdLfuxxYS2WjwydDI8WjJ6CTRsvsK8P6VE/WlTmu2WpTnxGnPW9VtZ2khifV9CRrUv7NWFGBgbVq/sZKujhu112+Fz4zkfyzU0pa3dg+66BkPg9uw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=diyFJu3exAB9XQupRDEjylhswIDofa3cZIW7OV+c/EE=;
 b=Vj1pFSMTEM/FUGhKQVtHWqXcBtU3yUXlDXJFXlLN3RirwnQvr+Bu8zJsvCVLkW7bVimtcdcfH5TsPuql263qhM8mpts3iAwHgJoCeepX44g8DJnXqWvlvsTYimtFxPzScnE5WLSh7Ly5VAv3uhpjcJ/Ag+hgURX1HDvoj7IWbgQrkSW40yrZlqOxlcevWWCuMtVubGq+5I+29peLupwCXX++au2s83dy3qxdBj8Yf/8uUOUhSRblwfS6IacMxrciHGrqkBCICKMxrznbne4BbwY9g4X6qJcKCe+4RehSQ1AdNBrX8OWHMWijIN4dXlIRz/zCllM49CCw0ZHVRGfOEg==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: "roger.pau@citrix.com" <roger.pau@citrix.com>
CC: "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org"
	<sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "jbeulich@suse.com" <jbeulich@suse.com>,
        Bertrand Marquis
	<bertrand.marquis@arm.com>,
        Rahul Singh <rahul.singh@arm.com>,
        Oleksandr
 Andrushchenko <Oleksandr_Andrushchenko@epam.com>,
        "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v3 06/11] vpci/header: Handle p2m range sets per BAR
Thread-Topic: [PATCH v3 06/11] vpci/header: Handle p2m range sets per BAR
Thread-Index: AQHXtdAibxRAFQhJuUO1GvFhv7aI/6vjwcoA
Date: Mon, 25 Oct 2021 11:51:57 +0000
Message-ID: <fc9de674-1000-c956-3401-103d8388d428@epam.com>
References: <20210930075223.860329-1-andr2000@gmail.com>
 <20210930075223.860329-7-andr2000@gmail.com>
In-Reply-To: <20210930075223.860329-7-andr2000@gmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 9e08ea65-3ccf-460b-a688-08d997add919
x-ms-traffictypediagnostic: AM0PR03MB5009:
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <AM0PR03MB5009223DD2A847B5358B53F7E7839@AM0PR03MB5009.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:7219;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 cnACTbQXJ9qucyQKaEbU9Wtx0KmdMJr05lvjKKv4KPpCDKfdHxAN/7ri7rfYtsXRcw5guCeyL8DZzDnTXZKtLazk0pR8To41QAhFFl6q15+5tWqIhIgpT3skmX1upEYb5NNJuTRWVyofVLlTrUAtZ3dMERJ/rwWpHdAAFR8kvPIin6KU/tZdMqbOWhLFdxrRf156l3aHCu6fnKYEMZI+rV8rdXNdVl9PROJzhYUiJDRgJQsJZyBkTB7S4J4QvNf/cSCe8Av+xfra6CjU8kA3GVmfqzKUPbZIwhoTa049F6XiNWYfBsPMvknmpS/ysXVPUB8MAIGxAtY5IISKSEpvO3TQ601u1yyu7jQIo/F1TxpYHRuiFFpoqp8dgqe9r+67YQIxi/lhJSOxbFS4jZufXUTjvIjrwPl5CwUFGBjQWo3Q6BACnfBpGHUaHWqB9j6SmBN6NB0BrMlm9Rs8Ioomgf8unlWLmcIw3qBM4kAI/s6rsRuPKKVAUM/gF+2Aj8KB0JmZZpc2GM5erW1+dqi/lYVfll+f81ottTYz+vY5T/hPHdnXXPGa6eLGb/gSuqvOYpI3PnC8je6nfxCTCsVrrBPAxMDD5gymMM+coXPwNUt17qZYDF6lKQ2xCpapx68T0pLvLUKMMiSxyuM4wknKBnRiKCdQtYs3SlqO1vCEP58DPMMsOdgx1I3KIXo9ZP7xc2DWD4BmWl5ikqOCrQMbi06VPy8GepdVkNUWr3eG4ffFGc3N/3iyDN87HQ6iHxNg
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(30864003)(53546011)(6506007)(31686004)(83380400001)(6916009)(6486002)(86362001)(4326008)(91956017)(2616005)(26005)(31696002)(122000001)(64756008)(38070700005)(186003)(54906003)(6512007)(66946007)(76116006)(316002)(2906002)(66476007)(8936002)(66556008)(66446008)(36756003)(508600001)(5660300002)(8676002)(71200400001)(38100700002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?TndpVVk1WWZ4bExkMDEydW8xVWsvNkZXemMwb0Qrcm51NkI5TVM1c0dqUmxC?=
 =?utf-8?B?YllQYTRPWitpNXRVRlgvYU1XQUNxREpvRkpUVTVmZWZaUndRVVc1MUk0YktG?=
 =?utf-8?B?SVBMM1ErQU1hWGxkTzhkRmRDV0VsMzdOWE84VjVJeXE1NEl6QVRPTzh5TUJX?=
 =?utf-8?B?bSt0bFlxaUJ5OUs4a0hCQ2hoWjlUL1VsaXBOK205eDVkeFNTZjVBY1ZuclF4?=
 =?utf-8?B?N3NQNVZsZGIwSUJaaFFWZFl6bUJId3d3WXR2SXhVcHFKRnFUZ2hheG1HKzRO?=
 =?utf-8?B?eVMxTmhna3NZbzRPRW9lOHlFblh4NURyeWxGZTBzYUU2YWpMRlJSVk1UTVJR?=
 =?utf-8?B?NmxvQ2dFc0xtQjFncllBYklvRHdJdkpWeXRMai9DV096aUJOajhucjhwbjFv?=
 =?utf-8?B?a3NRcUQ1eXE2V0Rxd0VXKy94RENVQkNmYzlSVjhWZTRJall2VnJSMnVLRXQ2?=
 =?utf-8?B?d1lINHJRQ2FUZWptN3dEcE5qdlA1ays1SkYrUHVPNHRTb2lTc3Y2bS9LWHEr?=
 =?utf-8?B?cnovVVhQZjAreGV3WDhGamxJUzFabmsrM2QvWm5YR21YUVI3QmtWUjJJWU1E?=
 =?utf-8?B?U0swdlAySjh6UDBrVWNOaWZHMWRoZGRnWTYyVk5hcjkvT3JhSDN4RVN1Tldx?=
 =?utf-8?B?RUU2RFlnWHpPUWpwWWVhaUhxVE1SL2ZuVm5tbVJET09kOXc4RUhzNmFReis0?=
 =?utf-8?B?dHVYdWxJN0JZUG1FRmYxWW9IbEN1cEtXVERQcTRCb08zYmtob1ROOE4zRlhE?=
 =?utf-8?B?Q21KWTlyQnNVeG9xalcya1BSQTV0TGk5dnVKb0J3Nmh5RmZnQWllMFdnL3F2?=
 =?utf-8?B?L0svVU45aDFxcURiWFhGTVBPUk52Q0FMQ3FudnE3djluR1YwQUxaRGR2L2Q4?=
 =?utf-8?B?Nms3TlA5N2hhWjIwbTJLQlJnK3RtbFpUeVBPc2JxazUzSmRpNkxad05PbER0?=
 =?utf-8?B?a0FBYVBlQ2VHcGprWm1HSzZsYTJtblhKMGNqVEl0SWRzd0IwcDE4U2Y4Lzd4?=
 =?utf-8?B?SzhKalRaV05iRy9hQmsvVjdJYXVkaWJWZTlVMHFFYkJXUzVzMXkwcmJHQ2cv?=
 =?utf-8?B?ZUkrQjVuMXgxOWUwRkJ5L3l4b2RkYXNNKzFWcjZNMXNLVDluQUF4WXBpYmNs?=
 =?utf-8?B?WmNqd2IvTjJLaWR1TlJCSWd4bDdIZnZsbmVFTmQ3ZUdvMm5RcDIvVmFLdTVT?=
 =?utf-8?B?NWtWbHFNQmNTQXF6djRyTzhIZ1hSUUpKVmRRTFdYUFpNNlBvNTg0eThGaTVl?=
 =?utf-8?B?Ni9KMVpRVjNPdWtOQUVtc2wyTGpwbGtQRWlwcHAyZWwrbjhYY1dHU00wSDRG?=
 =?utf-8?B?b3A0cU5KYi9zays4MDFrRFd3OVkvUmNYNFVNMGZpVTM5MThCTUFLSk1mbDVq?=
 =?utf-8?B?bUh6MitlTTdnczg2YnlvdkhHLzcwZEROVXlwVTZpZ1VrbEFPYnVSU0VKeTh6?=
 =?utf-8?B?a1lSTUxrbVBjcllqeXB6V3BLSVA0ZWhNZWZsQzFvcjF2TCs1dHNBZSttQ0kx?=
 =?utf-8?B?RXRGQjgrS0FZWXJKQnpzWWh6T0RRbHNLQU9jVS9Bb1hhcm0vY0ZpamVBOXpY?=
 =?utf-8?B?KzJ5TjdSdHc4R3M5dG5hTFAvekx1VG5uQlpZN3NPbEZINk5MdU1GSG5QaEVR?=
 =?utf-8?B?ZUU0MGN4N3BxL2QwQmdwK3VzNXdyNFNXU3FHU05MQlFRVE81cjJ0MS9DOFE0?=
 =?utf-8?B?cEZjOFVURmZnSXdmU0lMSG00dmFiS2haL0MyWWM5NmdjSnhqV2JOSGt2dHdN?=
 =?utf-8?B?L0UzTlVQbDhhMGlsbStNNExSKzdKTTRjQjRkcEFjYksxcUxaU3YxenpQcWJk?=
 =?utf-8?B?VnIxVW1EVEw2dHlBcDFod1VxR2pBK0srUHNnZTlBSFlLT3N6MmlvMGc5TzZX?=
 =?utf-8?B?Y081dURWbE5BT09OczEzY0ZwZ0VtYTc4Y3F0aHRnck9nbFNOWXVyUU4xVmxw?=
 =?utf-8?B?aXNuQ0E0NXhUbzNWV1JDTTRDUWdVdnhZNnNhdXJEQVV1TmlLTU5EMTJOc0hr?=
 =?utf-8?B?b3hmUWV5K3R2eS9pQU1BSEpFYlVwbU8rM0lpbWp0TG1FUllHK1FsakJaU2Fl?=
 =?utf-8?B?UFhVdjFzVkhGb2liZitNUHp2ZDFKRHlMZE1qelRJSEE5OXNWQmozMUN4cFNy?=
 =?utf-8?B?ME5tRHY0WjAydTRNcUpVcUlaTE1nWnNpcWxVWGRmT1FFYmxoaVZoVGxTVzVU?=
 =?utf-8?B?WkpaRm1TMVZBKzJWMFFNN3pPSFVDTzVDNmt5Tjd6U0pXUGt1WU1jYXpVYjQw?=
 =?utf-8?B?cVRydVFrVXhEODI0OHEwUFNMVSsxOW1sWmkzSWNGWmhBcVNBcDdjTEtLTlhP?=
 =?utf-8?B?dm1GN0tQNWRKVmxvbHR6MWkxRFk5VStpek15TUpEREVNK1dYaExyZz09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <B19F14507A8A624FB81FC031AD11786D@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9e08ea65-3ccf-460b-a688-08d997add919
X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Oct 2021 11:51:57.5147
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 5ZcZi4HlrlaiONT6+WxzX/FAaGjH42V29ZbqWe/xC3AYiJlFXIFPPsLETtQx/CK0iYXy7DK4LElfBCl+8ybSyt5hxhQoQhkFkY7dsdbmvhZ+okOv1pFYmqFISG9ACjBn
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR03MB5009
X-Proofpoint-GUID: tjITc_ZQjeYKLWhL1ivj1nDH-eOOJZeR
X-Proofpoint-ORIG-GUID: tjITc_ZQjeYKLWhL1ivj1nDH-eOOJZeR
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475
 definitions=2021-10-25_04,2021-10-25_02,2020-04-07_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 mlxlogscore=999
 bulkscore=0 lowpriorityscore=0 adultscore=0 malwarescore=0 spamscore=0
 impostorscore=0 mlxscore=0 priorityscore=1501 clxscore=1015 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109230001
 definitions=main-2110250073

SGksIFJvZ2VyIQ0KQ291bGQgeW91IHBsZWFzZSB0YWtlIGEgbG9vayBhdCB0aGUgYmVsb3c/DQpK
YW4gd2FzIHF1ZXN0aW9uaW5nIHRoZSBwZXIgQkFSIHJhbmdlIHNldCBhcHByb2FjaCwgc28gaXQN
CmlzIGNydWNpYWwgZm9yIHRoZSBtYWludGFpbmVyICh5b3UpIHRvIGFuc3dlciBoZXJlLg0KDQpU
aGFuayB5b3UgaW4gYWR2YW5jZSwNCk9sZWtzYW5kcg0KDQpPbiAzMC4wOS4yMSAxMDo1MiwgT2xl
a3NhbmRyIEFuZHJ1c2hjaGVua28gd3JvdGU6DQo+IEZyb206IE9sZWtzYW5kciBBbmRydXNoY2hl
bmtvIDxvbGVrc2FuZHJfYW5kcnVzaGNoZW5rb0BlcGFtLmNvbT4NCj4NCj4gSW5zdGVhZCBvZiBo
YW5kbGluZyBhIHNpbmdsZSByYW5nZSBzZXQsIHRoYXQgY29udGFpbnMgYWxsIHRoZSBtZW1vcnkN
Cj4gcmVnaW9ucyBvZiBhbGwgdGhlIEJBUnMgYW5kIFJPTSwgaGF2ZSB0aGVtIHBlciBCQVIuDQo+
DQo+IFRoaXMgaXMgaW4gcHJlcGFyYXRpb24gb2YgbWFraW5nIG5vbi1pZGVudGl0eSBtYXBwaW5n
cyBpbiBwMm0gZm9yIHRoZQ0KPiBNTUlPcy9ST00uDQo+DQo+IFNpZ25lZC1vZmYtYnk6IE9sZWtz
YW5kciBBbmRydXNoY2hlbmtvIDxvbGVrc2FuZHJfYW5kcnVzaGNoZW5rb0BlcGFtLmNvbT4NCj4g
LS0tDQo+ICAgeGVuL2RyaXZlcnMvdnBjaS9oZWFkZXIuYyB8IDE3MiArKysrKysrKysrKysrKysr
KysrKysrKysrKy0tLS0tLS0tLS0tLQ0KPiAgIHhlbi9pbmNsdWRlL3hlbi92cGNpLmggICAgfCAg
IDMgKy0NCj4gICAyIGZpbGVzIGNoYW5nZWQsIDEyMiBpbnNlcnRpb25zKCspLCA1MyBkZWxldGlv
bnMoLSkNCj4NCj4gZGlmZiAtLWdpdCBhL3hlbi9kcml2ZXJzL3ZwY2kvaGVhZGVyLmMgYi94ZW4v
ZHJpdmVycy92cGNpL2hlYWRlci5jDQo+IGluZGV4IGVjNGQyMTVmMzZmZi4uOWM2MDNkMjZkMzAy
IDEwMDY0NA0KPiAtLS0gYS94ZW4vZHJpdmVycy92cGNpL2hlYWRlci5jDQo+ICsrKyBiL3hlbi9k
cml2ZXJzL3ZwY2kvaGVhZGVyLmMNCj4gQEAgLTEzMSw0OSArMTMxLDc1IEBAIHN0YXRpYyB2b2lk
IG1vZGlmeV9kZWNvZGluZyhjb25zdCBzdHJ1Y3QgcGNpX2RldiAqcGRldiwgdWludDE2X3QgY21k
LA0KPiAgIA0KPiAgIGJvb2wgdnBjaV9wcm9jZXNzX3BlbmRpbmcoc3RydWN0IHZjcHUgKnYpDQo+
ICAgew0KPiAtICAgIGlmICggdi0+dnBjaS5tZW0gKQ0KPiArICAgIGlmICggdi0+dnBjaS5udW1f
bWVtX3JhbmdlcyApDQo+ICAgICAgIHsNCj4gICAgICAgICAgIHN0cnVjdCBtYXBfZGF0YSBkYXRh
ID0gew0KPiAgICAgICAgICAgICAgIC5kID0gdi0+ZG9tYWluLA0KPiAgICAgICAgICAgICAgIC5t
YXAgPSB2LT52cGNpLmNtZCAmIFBDSV9DT01NQU5EX01FTU9SWSwNCj4gICAgICAgICAgIH07DQo+
IC0gICAgICAgIGludCByYyA9IHJhbmdlc2V0X2NvbnN1bWVfcmFuZ2VzKHYtPnZwY2kubWVtLCBt
YXBfcmFuZ2UsICZkYXRhKTsNCj4gKyAgICAgICAgc3RydWN0IHBjaV9kZXYgKnBkZXYgPSB2LT52
cGNpLnBkZXY7DQo+ICsgICAgICAgIHN0cnVjdCB2cGNpX2hlYWRlciAqaGVhZGVyID0gJnBkZXYt
PnZwY2ktPmhlYWRlcjsNCj4gKyAgICAgICAgdW5zaWduZWQgaW50IGk7DQo+ICAgDQo+IC0gICAg
ICAgIGlmICggcmMgPT0gLUVSRVNUQVJUICkNCj4gLSAgICAgICAgICAgIHJldHVybiB0cnVlOw0K
PiArICAgICAgICBmb3IgKCBpID0gMDsgaSA8IEFSUkFZX1NJWkUoaGVhZGVyLT5iYXJzKTsgaSsr
ICkNCj4gKyAgICAgICAgew0KPiArICAgICAgICAgICAgc3RydWN0IHZwY2lfYmFyICpiYXIgPSAm
aGVhZGVyLT5iYXJzW2ldOw0KPiArICAgICAgICAgICAgaW50IHJjOw0KPiAgIA0KPiAtICAgICAg
ICBzcGluX2xvY2soJnYtPnZwY2kucGRldi0+dnBjaS0+bG9jayk7DQo+IC0gICAgICAgIC8qIERp
c2FibGUgbWVtb3J5IGRlY29kaW5nIHVuY29uZGl0aW9uYWxseSBvbiBmYWlsdXJlLiAqLw0KPiAt
ICAgICAgICBtb2RpZnlfZGVjb2Rpbmcodi0+dnBjaS5wZGV2LA0KPiAtICAgICAgICAgICAgICAg
ICAgICAgICAgcmMgPyB2LT52cGNpLmNtZCAmIH5QQ0lfQ09NTUFORF9NRU1PUlkgOiB2LT52cGNp
LmNtZCwNCj4gLSAgICAgICAgICAgICAgICAgICAgICAgICFyYyAmJiB2LT52cGNpLnJvbV9vbmx5
KTsNCj4gLSAgICAgICAgc3Bpbl91bmxvY2soJnYtPnZwY2kucGRldi0+dnBjaS0+bG9jayk7DQo+
ICsgICAgICAgICAgICBpZiAoICFiYXItPm1lbSApDQo+ICsgICAgICAgICAgICAgICAgY29udGlu
dWU7DQo+ICAgDQo+IC0gICAgICAgIHJhbmdlc2V0X2Rlc3Ryb3kodi0+dnBjaS5tZW0pOw0KPiAt
ICAgICAgICB2LT52cGNpLm1lbSA9IE5VTEw7DQo+IC0gICAgICAgIGlmICggcmMgKQ0KPiAtICAg
ICAgICAgICAgLyoNCj4gLSAgICAgICAgICAgICAqIEZJWE1FOiBpbiBjYXNlIG9mIGZhaWx1cmUg
cmVtb3ZlIHRoZSBkZXZpY2UgZnJvbSB0aGUgZG9tYWluLg0KPiAtICAgICAgICAgICAgICogTm90
ZSB0aGF0IHRoZXJlIG1pZ2h0IHN0aWxsIGJlIGxlZnRvdmVyIG1hcHBpbmdzLiBXaGlsZSB0aGlz
IGlzDQo+IC0gICAgICAgICAgICAgKiBzYWZlIGZvciBEb20wLCBmb3IgRG9tVXMgdGhlIGRvbWFp
biB3aWxsIGxpa2VseSBuZWVkIHRvIGJlDQo+IC0gICAgICAgICAgICAgKiBraWxsZWQgaW4gb3Jk
ZXIgdG8gYXZvaWQgbGVha2luZyBzdGFsZSBwMm0gbWFwcGluZ3Mgb24NCj4gLSAgICAgICAgICAg
ICAqIGZhaWx1cmUuDQo+IC0gICAgICAgICAgICAgKi8NCj4gLSAgICAgICAgICAgIHZwY2lfcmVt
b3ZlX2RldmljZSh2LT52cGNpLnBkZXYpOw0KPiArICAgICAgICAgICAgcmMgPSByYW5nZXNldF9j
b25zdW1lX3JhbmdlcyhiYXItPm1lbSwgbWFwX3JhbmdlLCAmZGF0YSk7DQo+ICsNCj4gKyAgICAg
ICAgICAgIGlmICggcmMgPT0gLUVSRVNUQVJUICkNCj4gKyAgICAgICAgICAgICAgICByZXR1cm4g
dHJ1ZTsNCj4gKw0KPiArICAgICAgICAgICAgc3Bpbl9sb2NrKCZwZGV2LT52cGNpLT5sb2NrKTsN
Cj4gKyAgICAgICAgICAgIC8qIERpc2FibGUgbWVtb3J5IGRlY29kaW5nIHVuY29uZGl0aW9uYWxs
eSBvbiBmYWlsdXJlLiAqLw0KPiArICAgICAgICAgICAgbW9kaWZ5X2RlY29kaW5nKHBkZXYsDQo+
ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgcmMgPyB2LT52cGNpLmNtZCAmIH5QQ0lfQ09N
TUFORF9NRU1PUlkgOiB2LT52cGNpLmNtZCwNCj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAhcmMgJiYgdi0+dnBjaS5yb21fb25seSk7DQo+ICsgICAgICAgICAgICBzcGluX3VubG9jaygm
cGRldi0+dnBjaS0+bG9jayk7DQo+ICsNCj4gKyAgICAgICAgICAgIHJhbmdlc2V0X2Rlc3Ryb3ko
YmFyLT5tZW0pOw0KPiArICAgICAgICAgICAgYmFyLT5tZW0gPSBOVUxMOw0KPiArICAgICAgICAg
ICAgdi0+dnBjaS5udW1fbWVtX3Jhbmdlcy0tOw0KPiArICAgICAgICAgICAgaWYgKCByYyApDQo+
ICsgICAgICAgICAgICAgICAgLyoNCj4gKyAgICAgICAgICAgICAgICAgKiBGSVhNRTogaW4gY2Fz
ZSBvZiBmYWlsdXJlIHJlbW92ZSB0aGUgZGV2aWNlIGZyb20gdGhlIGRvbWFpbi4NCj4gKyAgICAg
ICAgICAgICAgICAgKiBOb3RlIHRoYXQgdGhlcmUgbWlnaHQgc3RpbGwgYmUgbGVmdG92ZXIgbWFw
cGluZ3MuIFdoaWxlIHRoaXMgaXMNCj4gKyAgICAgICAgICAgICAgICAgKiBzYWZlIGZvciBEb20w
LCBmb3IgRG9tVXMgdGhlIGRvbWFpbiB3aWxsIGxpa2VseSBuZWVkIHRvIGJlDQo+ICsgICAgICAg
ICAgICAgICAgICoga2lsbGVkIGluIG9yZGVyIHRvIGF2b2lkIGxlYWtpbmcgc3RhbGUgcDJtIG1h
cHBpbmdzIG9uDQo+ICsgICAgICAgICAgICAgICAgICogZmFpbHVyZS4NCj4gKyAgICAgICAgICAg
ICAgICAgKi8NCj4gKyAgICAgICAgICAgICAgICB2cGNpX3JlbW92ZV9kZXZpY2UocGRldik7DQo+
ICsgICAgICAgIH0NCj4gICAgICAgfQ0KPiAgIA0KPiAgICAgICByZXR1cm4gZmFsc2U7DQo+ICAg
fQ0KPiAgIA0KPiAgIHN0YXRpYyBpbnQgX19pbml0IGFwcGx5X21hcChzdHJ1Y3QgZG9tYWluICpk
LCBjb25zdCBzdHJ1Y3QgcGNpX2RldiAqcGRldiwNCj4gLSAgICAgICAgICAgICAgICAgICAgICAg
ICAgICBzdHJ1Y3QgcmFuZ2VzZXQgKm1lbSwgdWludDE2X3QgY21kKQ0KPiArICAgICAgICAgICAg
ICAgICAgICAgICAgICAgIHVpbnQxNl90IGNtZCkNCj4gICB7DQo+ICAgICAgIHN0cnVjdCBtYXBf
ZGF0YSBkYXRhID0geyAuZCA9IGQsIC5tYXAgPSB0cnVlIH07DQo+IC0gICAgaW50IHJjOw0KPiAr
ICAgIHN0cnVjdCB2cGNpX2hlYWRlciAqaGVhZGVyID0gJnBkZXYtPnZwY2ktPmhlYWRlcjsNCj4g
KyAgICBpbnQgcmMgPSAwOw0KPiArICAgIHVuc2lnbmVkIGludCBpOw0KPiArDQo+ICsgICAgZm9y
ICggaSA9IDA7IGkgPCBBUlJBWV9TSVpFKGhlYWRlci0+YmFycyk7IGkrKyApDQo+ICsgICAgew0K
PiArICAgICAgICBzdHJ1Y3QgdnBjaV9iYXIgKmJhciA9ICZoZWFkZXItPmJhcnNbaV07DQo+ICAg
DQo+IC0gICAgd2hpbGUgKCAocmMgPSByYW5nZXNldF9jb25zdW1lX3JhbmdlcyhtZW0sIG1hcF9y
YW5nZSwgJmRhdGEpKSA9PSAtRVJFU1RBUlQgKQ0KPiAtICAgICAgICBwcm9jZXNzX3BlbmRpbmdf
c29mdGlycXMoKTsNCj4gLSAgICByYW5nZXNldF9kZXN0cm95KG1lbSk7DQo+ICsgICAgICAgIGlm
ICggIWJhci0+bWVtICkNCj4gKyAgICAgICAgICAgIGNvbnRpbnVlOw0KPiArDQo+ICsgICAgICAg
IHdoaWxlICggKHJjID0gcmFuZ2VzZXRfY29uc3VtZV9yYW5nZXMoYmFyLT5tZW0sIG1hcF9yYW5n
ZSwNCj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAmZGF0
YSkpID09IC1FUkVTVEFSVCApDQo+ICsgICAgICAgICAgICBwcm9jZXNzX3BlbmRpbmdfc29mdGly
cXMoKTsNCj4gKyAgICAgICAgcmFuZ2VzZXRfZGVzdHJveShiYXItPm1lbSk7DQo+ICsgICAgICAg
IGJhci0+bWVtID0gTlVMTDsNCj4gKyAgICB9DQo+ICAgICAgIGlmICggIXJjICkNCj4gICAgICAg
ICAgIG1vZGlmeV9kZWNvZGluZyhwZGV2LCBjbWQsIGZhbHNlKTsNCj4gICANCj4gQEAgLTE4MSw3
ICsyMDcsNyBAQCBzdGF0aWMgaW50IF9faW5pdCBhcHBseV9tYXAoc3RydWN0IGRvbWFpbiAqZCwg
Y29uc3Qgc3RydWN0IHBjaV9kZXYgKnBkZXYsDQo+ICAgfQ0KPiAgIA0KPiAgIHN0YXRpYyB2b2lk
IGRlZmVyX21hcChzdHJ1Y3QgZG9tYWluICpkLCBzdHJ1Y3QgcGNpX2RldiAqcGRldiwNCj4gLSAg
ICAgICAgICAgICAgICAgICAgICBzdHJ1Y3QgcmFuZ2VzZXQgKm1lbSwgdWludDE2X3QgY21kLCBi
b29sIHJvbV9vbmx5KQ0KPiArICAgICAgICAgICAgICAgICAgICAgIHVpbnQxNl90IGNtZCwgYm9v
bCByb21fb25seSwgdWludDhfdCBudW1fbWVtX3JhbmdlcykNCj4gICB7DQo+ICAgICAgIHN0cnVj
dCB2Y3B1ICpjdXJyID0gY3VycmVudDsNCj4gICANCj4gQEAgLTE5Miw5ICsyMTgsOSBAQCBzdGF0
aWMgdm9pZCBkZWZlcl9tYXAoc3RydWN0IGRvbWFpbiAqZCwgc3RydWN0IHBjaV9kZXYgKnBkZXYs
DQo+ICAgICAgICAqIHN0YXJ0ZWQgZm9yIHRoZSBzYW1lIGRldmljZSBpZiB0aGUgZG9tYWluIGlz
IG5vdCB3ZWxsLWJlaGF2ZWQuDQo+ICAgICAgICAqLw0KPiAgICAgICBjdXJyLT52cGNpLnBkZXYg
PSBwZGV2Ow0KPiAtICAgIGN1cnItPnZwY2kubWVtID0gbWVtOw0KPiAgICAgICBjdXJyLT52cGNp
LmNtZCA9IGNtZDsNCj4gICAgICAgY3Vyci0+dnBjaS5yb21fb25seSA9IHJvbV9vbmx5Ow0KPiAr
ICAgIGN1cnItPnZwY2kubnVtX21lbV9yYW5nZXMgPSBudW1fbWVtX3JhbmdlczsNCj4gICAgICAg
LyoNCj4gICAgICAgICogUmFpc2UgYSBzY2hlZHVsZXIgc29mdGlycSBpbiBvcmRlciB0byBwcmV2
ZW50IHRoZSBndWVzdCBmcm9tIHJlc3VtaW5nDQo+ICAgICAgICAqIGV4ZWN1dGlvbiB3aXRoIHBl
bmRpbmcgbWFwcGluZyBvcGVyYXRpb25zLCB0byB0cmlnZ2VyIHRoZSBpbnZvY2F0aW9uDQo+IEBA
IC0yMDYsNDIgKzIzMiw0NyBAQCBzdGF0aWMgdm9pZCBkZWZlcl9tYXAoc3RydWN0IGRvbWFpbiAq
ZCwgc3RydWN0IHBjaV9kZXYgKnBkZXYsDQo+ICAgc3RhdGljIGludCBtb2RpZnlfYmFycyhjb25z
dCBzdHJ1Y3QgcGNpX2RldiAqcGRldiwgdWludDE2X3QgY21kLCBib29sIHJvbV9vbmx5KQ0KPiAg
IHsNCj4gICAgICAgc3RydWN0IHZwY2lfaGVhZGVyICpoZWFkZXIgPSAmcGRldi0+dnBjaS0+aGVh
ZGVyOw0KPiAtICAgIHN0cnVjdCByYW5nZXNldCAqbWVtID0gcmFuZ2VzZXRfbmV3KE5VTEwsIE5V
TEwsIDApOw0KPiAgICAgICBzdHJ1Y3QgcGNpX2RldiAqdG1wLCAqZGV2ID0gTlVMTDsNCj4gICAg
ICAgY29uc3Qgc3RydWN0IHZwY2lfbXNpeCAqbXNpeCA9IHBkZXYtPnZwY2ktPm1zaXg7DQo+IC0g
ICAgdW5zaWduZWQgaW50IGk7DQo+ICsgICAgdW5zaWduZWQgaW50IGksIGo7DQo+ICAgICAgIGlu
dCByYzsNCj4gLQ0KPiAtICAgIGlmICggIW1lbSApDQo+IC0gICAgICAgIHJldHVybiAtRU5PTUVN
Ow0KPiArICAgIHVpbnQ4X3QgbnVtX21lbV9yYW5nZXM7DQo+ICAgDQo+ICAgICAgIC8qDQo+IC0g
ICAgICogQ3JlYXRlIGEgcmFuZ2VzZXQgdGhhdCByZXByZXNlbnRzIHRoZSBjdXJyZW50IGRldmlj
ZSBCQVJzIG1lbW9yeSByZWdpb24NCj4gKyAgICAgKiBDcmVhdGUgYSByYW5nZXNldCBwZXIgQkFS
IHRoYXQgcmVwcmVzZW50cyB0aGUgY3VycmVudCBkZXZpY2UgbWVtb3J5IHJlZ2lvbg0KPiAgICAg
ICAgKiBhbmQgY29tcGFyZSBpdCBhZ2FpbnN0IGFsbCB0aGUgY3VycmVudGx5IGFjdGl2ZSBCQVIg
bWVtb3J5IHJlZ2lvbnMuIElmDQo+ICAgICAgICAqIGFuIG92ZXJsYXAgaXMgZm91bmQsIHN1YnRy
YWN0IGl0IGZyb20gdGhlIHJlZ2lvbiB0byBiZSBtYXBwZWQvdW5tYXBwZWQuDQo+ICAgICAgICAq
DQo+IC0gICAgICogRmlyc3QgZmlsbCB0aGUgcmFuZ2VzZXQgd2l0aCBhbGwgdGhlIEJBUnMgb2Yg
dGhpcyBkZXZpY2Ugb3Igd2l0aCB0aGUgUk9NDQo+ICsgICAgICogRmlyc3QgZmlsbCB0aGUgcmFu
Z2VzZXRzIHdpdGggYWxsIHRoZSBCQVJzIG9mIHRoaXMgZGV2aWNlIG9yIHdpdGggdGhlIFJPTQ0K
PiAgICAgICAgKiBCQVIgb25seSwgZGVwZW5kaW5nIG9uIHdoZXRoZXIgdGhlIGd1ZXN0IGlzIHRv
Z2dsaW5nIHRoZSBtZW1vcnkgZGVjb2RlDQo+ICAgICAgICAqIGJpdCBvZiB0aGUgY29tbWFuZCBy
ZWdpc3Rlciwgb3IgdGhlIGVuYWJsZSBiaXQgb2YgdGhlIFJPTSBCQVIgcmVnaXN0ZXIuDQo+ICAg
ICAgICAqLw0KPiAgICAgICBmb3IgKCBpID0gMDsgaSA8IEFSUkFZX1NJWkUoaGVhZGVyLT5iYXJz
KTsgaSsrICkNCj4gICAgICAgew0KPiAtICAgICAgICBjb25zdCBzdHJ1Y3QgdnBjaV9iYXIgKmJh
ciA9ICZoZWFkZXItPmJhcnNbaV07DQo+ICsgICAgICAgIHN0cnVjdCB2cGNpX2JhciAqYmFyID0g
JmhlYWRlci0+YmFyc1tpXTsNCj4gICAgICAgICAgIHVuc2lnbmVkIGxvbmcgc3RhcnQgPSBQRk5f
RE9XTihiYXItPmFkZHIpOw0KPiAgICAgICAgICAgdW5zaWduZWQgbG9uZyBlbmQgPSBQRk5fRE9X
TihiYXItPmFkZHIgKyBiYXItPnNpemUgLSAxKTsNCj4gICANCj4gKyAgICAgICAgYmFyLT5tZW0g
PSBOVUxMOw0KPiArDQo+ICAgICAgICAgICBpZiAoICFNQVBQQUJMRV9CQVIoYmFyKSB8fA0KPiAg
ICAgICAgICAgICAgICAocm9tX29ubHkgPyBiYXItPnR5cGUgIT0gVlBDSV9CQVJfUk9NDQo+ICAg
ICAgICAgICAgICAgICAgICAgICAgICA6IChiYXItPnR5cGUgPT0gVlBDSV9CQVJfUk9NICYmICFo
ZWFkZXItPnJvbV9lbmFibGVkKSkgKQ0KPiAgICAgICAgICAgICAgIGNvbnRpbnVlOw0KPiAgIA0K
PiAtICAgICAgICByYyA9IHJhbmdlc2V0X2FkZF9yYW5nZShtZW0sIHN0YXJ0LCBlbmQpOw0KPiAr
ICAgICAgICBiYXItPm1lbSA9IHJhbmdlc2V0X25ldyhOVUxMLCBOVUxMLCAwKTsNCj4gKyAgICAg
ICAgaWYgKCAhYmFyLT5tZW0gKQ0KPiArICAgICAgICB7DQo+ICsgICAgICAgICAgICByYyA9IC1F
Tk9NRU07DQo+ICsgICAgICAgICAgICBnb3RvIGZhaWw7DQo+ICsgICAgICAgIH0NCj4gKw0KPiAr
ICAgICAgICByYyA9IHJhbmdlc2V0X2FkZF9yYW5nZShiYXItPm1lbSwgc3RhcnQsIGVuZCk7DQo+
ICAgICAgICAgICBpZiAoIHJjICkNCj4gICAgICAgICAgIHsNCj4gICAgICAgICAgICAgICBwcmlu
dGsoWEVOTE9HX0dfV0FSTklORyAiRmFpbGVkIHRvIGFkZCBbJWx4LCAlbHhdOiAlZFxuIiwNCj4g
ICAgICAgICAgICAgICAgICAgICAgc3RhcnQsIGVuZCwgcmMpOw0KPiAtICAgICAgICAgICAgcmFu
Z2VzZXRfZGVzdHJveShtZW0pOw0KPiAtICAgICAgICAgICAgcmV0dXJuIHJjOw0KPiArICAgICAg
ICAgICAgZ290byBmYWlsOw0KPiAgICAgICAgICAgfQ0KPiAgICAgICB9DQo+ICAgDQo+IEBAIC0y
NTIsMTQgKzI4MywyMSBAQCBzdGF0aWMgaW50IG1vZGlmeV9iYXJzKGNvbnN0IHN0cnVjdCBwY2lf
ZGV2ICpwZGV2LCB1aW50MTZfdCBjbWQsIGJvb2wgcm9tX29ubHkpDQo+ICAgICAgICAgICB1bnNp
Z25lZCBsb25nIGVuZCA9IFBGTl9ET1dOKHZtc2l4X3RhYmxlX2FkZHIocGRldi0+dnBjaSwgaSkg
Kw0KPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB2bXNpeF90YWJsZV9z
aXplKHBkZXYtPnZwY2ksIGkpIC0gMSk7DQo+ICAgDQo+IC0gICAgICAgIHJjID0gcmFuZ2VzZXRf
cmVtb3ZlX3JhbmdlKG1lbSwgc3RhcnQsIGVuZCk7DQo+IC0gICAgICAgIGlmICggcmMgKQ0KPiAr
ICAgICAgICBmb3IgKCBqID0gMDsgaiA8IEFSUkFZX1NJWkUoaGVhZGVyLT5iYXJzKTsgaisrICkN
Cj4gICAgICAgICAgIHsNCj4gLSAgICAgICAgICAgIHByaW50ayhYRU5MT0dfR19XQVJOSU5HDQo+
IC0gICAgICAgICAgICAgICAgICAgIkZhaWxlZCB0byByZW1vdmUgTVNJWCB0YWJsZSBbJWx4LCAl
bHhdOiAlZFxuIiwNCj4gLSAgICAgICAgICAgICAgICAgICBzdGFydCwgZW5kLCByYyk7DQo+IC0g
ICAgICAgICAgICByYW5nZXNldF9kZXN0cm95KG1lbSk7DQo+IC0gICAgICAgICAgICByZXR1cm4g
cmM7DQo+ICsgICAgICAgICAgICBjb25zdCBzdHJ1Y3QgdnBjaV9iYXIgKmJhciA9ICZoZWFkZXIt
PmJhcnNbal07DQo+ICsNCj4gKyAgICAgICAgICAgIGlmICggIWJhci0+bWVtICkNCj4gKyAgICAg
ICAgICAgICAgICBjb250aW51ZTsNCj4gKw0KPiArICAgICAgICAgICAgcmMgPSByYW5nZXNldF9y
ZW1vdmVfcmFuZ2UoYmFyLT5tZW0sIHN0YXJ0LCBlbmQpOw0KPiArICAgICAgICAgICAgaWYgKCBy
YyApDQo+ICsgICAgICAgICAgICB7DQo+ICsgICAgICAgICAgICAgICAgcHJpbnRrKFhFTkxPR19H
X1dBUk5JTkcNCj4gKyAgICAgICAgICAgICAgICAgICAgICAgIkZhaWxlZCB0byByZW1vdmUgTVNJ
WCB0YWJsZSBbJWx4LCAlbHhdOiAlZFxuIiwNCj4gKyAgICAgICAgICAgICAgICAgICAgICAgc3Rh
cnQsIGVuZCwgcmMpOw0KPiArICAgICAgICAgICAgICAgIGdvdG8gZmFpbDsNCj4gKyAgICAgICAg
ICAgIH0NCj4gICAgICAgICAgIH0NCj4gICAgICAgfQ0KPiAgIA0KPiBAQCAtMjkxLDcgKzMyOSw4
IEBAIHN0YXRpYyBpbnQgbW9kaWZ5X2JhcnMoY29uc3Qgc3RydWN0IHBjaV9kZXYgKnBkZXYsIHVp
bnQxNl90IGNtZCwgYm9vbCByb21fb25seSkNCj4gICAgICAgICAgICAgICB1bnNpZ25lZCBsb25n
IHN0YXJ0ID0gUEZOX0RPV04oYmFyLT5hZGRyKTsNCj4gICAgICAgICAgICAgICB1bnNpZ25lZCBs
b25nIGVuZCA9IFBGTl9ET1dOKGJhci0+YWRkciArIGJhci0+c2l6ZSAtIDEpOw0KPiAgIA0KPiAt
ICAgICAgICAgICAgaWYgKCAhYmFyLT5lbmFibGVkIHx8ICFyYW5nZXNldF9vdmVybGFwc19yYW5n
ZShtZW0sIHN0YXJ0LCBlbmQpIHx8DQo+ICsgICAgICAgICAgICBpZiAoICFiYXItPmVuYWJsZWQg
fHwNCj4gKyAgICAgICAgICAgICAgICAgIXJhbmdlc2V0X292ZXJsYXBzX3JhbmdlKGJhci0+bWVt
LCBzdGFydCwgZW5kKSB8fA0KPiAgICAgICAgICAgICAgICAgICAgLyoNCj4gICAgICAgICAgICAg
ICAgICAgICAqIElmIG9ubHkgdGhlIFJPTSBlbmFibGUgYml0IGlzIHRvZ2dsZWQgY2hlY2sgYWdh
aW5zdCBvdGhlcg0KPiAgICAgICAgICAgICAgICAgICAgICogQkFScyBpbiB0aGUgc2FtZSBkZXZp
Y2UgZm9yIG92ZXJsYXBzLCBidXQgbm90IGFnYWluc3QgdGhlDQo+IEBAIC0zMDAsMTMgKzMzOSwx
MiBAQCBzdGF0aWMgaW50IG1vZGlmeV9iYXJzKGNvbnN0IHN0cnVjdCBwY2lfZGV2ICpwZGV2LCB1
aW50MTZfdCBjbWQsIGJvb2wgcm9tX29ubHkpDQo+ICAgICAgICAgICAgICAgICAgICAocm9tX29u
bHkgJiYgdG1wID09IHBkZXYgJiYgYmFyLT50eXBlID09IFZQQ0lfQkFSX1JPTSkgKQ0KPiAgICAg
ICAgICAgICAgICAgICBjb250aW51ZTsNCj4gICANCj4gLSAgICAgICAgICAgIHJjID0gcmFuZ2Vz
ZXRfcmVtb3ZlX3JhbmdlKG1lbSwgc3RhcnQsIGVuZCk7DQo+ICsgICAgICAgICAgICByYyA9IHJh
bmdlc2V0X3JlbW92ZV9yYW5nZShiYXItPm1lbSwgc3RhcnQsIGVuZCk7DQo+ICAgICAgICAgICAg
ICAgaWYgKCByYyApDQo+ICAgICAgICAgICAgICAgew0KPiAgICAgICAgICAgICAgICAgICBwcmlu
dGsoWEVOTE9HX0dfV0FSTklORyAiRmFpbGVkIHRvIHJlbW92ZSBbJWx4LCAlbHhdOiAlZFxuIiwN
Cj4gICAgICAgICAgICAgICAgICAgICAgICAgIHN0YXJ0LCBlbmQsIHJjKTsNCj4gLSAgICAgICAg
ICAgICAgICByYW5nZXNldF9kZXN0cm95KG1lbSk7DQo+IC0gICAgICAgICAgICAgICAgcmV0dXJu
IHJjOw0KPiArICAgICAgICAgICAgICAgIGdvdG8gZmFpbDsNCj4gICAgICAgICAgICAgICB9DQo+
ICAgICAgICAgICB9DQo+ICAgICAgIH0NCj4gQEAgLTMyNCwxMiArMzYyLDQyIEBAIHN0YXRpYyBp
bnQgbW9kaWZ5X2JhcnMoY29uc3Qgc3RydWN0IHBjaV9kZXYgKnBkZXYsIHVpbnQxNl90IGNtZCwg
Ym9vbCByb21fb25seSkNCj4gICAgICAgICAgICAqIHdpbGwgYWx3YXlzIGJlIHRvIGVzdGFibGlz
aCBtYXBwaW5ncyBhbmQgcHJvY2VzcyBhbGwgdGhlIEJBUnMuDQo+ICAgICAgICAgICAgKi8NCj4g
ICAgICAgICAgIEFTU0VSVCgoY21kICYgUENJX0NPTU1BTkRfTUVNT1JZKSAmJiAhcm9tX29ubHkp
Ow0KPiAtICAgICAgICByZXR1cm4gYXBwbHlfbWFwKHBkZXYtPmRvbWFpbiwgcGRldiwgbWVtLCBj
bWQpOw0KPiArICAgICAgICByZXR1cm4gYXBwbHlfbWFwKHBkZXYtPmRvbWFpbiwgcGRldiwgY21k
KTsNCj4gICAgICAgfQ0KPiAgIA0KPiAtICAgIGRlZmVyX21hcChkZXYtPmRvbWFpbiwgZGV2LCBt
ZW0sIGNtZCwgcm9tX29ubHkpOw0KPiArICAgIC8qIEZpbmQgb3V0IGhvdyBtYW55IG1lbW9yeSBy
YW5nZXMgaGFzIGxlZnQgYWZ0ZXIgTVNJIGFuZCBvdmVybGFwcy4gKi8NCj4gKyAgICBudW1fbWVt
X3JhbmdlcyA9IDA7DQo+ICsgICAgZm9yICggaSA9IDA7IGkgPCBBUlJBWV9TSVpFKGhlYWRlci0+
YmFycyk7IGkrKyApDQo+ICsgICAgew0KPiArICAgICAgICBzdHJ1Y3QgdnBjaV9iYXIgKmJhciA9
ICZoZWFkZXItPmJhcnNbaV07DQo+ICsNCj4gKyAgICAgICAgaWYgKCAhcmFuZ2VzZXRfaXNfZW1w
dHkoYmFyLT5tZW0pICkNCj4gKyAgICAgICAgICAgIG51bV9tZW1fcmFuZ2VzKys7DQo+ICsgICAg
fQ0KPiArDQo+ICsgICAgLyoNCj4gKyAgICAgKiBUaGVyZSBhcmUgY2FzZXMgd2hlbiBQQ0kgZGV2
aWNlLCByb290IHBvcnQgZm9yIGV4YW1wbGUsIGhhcyBuZWl0aGVyDQo+ICsgICAgICogbWVtb3J5
IHNwYWNlIG5vciBJTy4gSW4gdGhpcyBjYXNlIFBDSSBjb21tYW5kIHJlZ2lzdGVyIHdyaXRlIGlz
DQo+ICsgICAgICogbWlzc2VkIHJlc3VsdGluZyBpbiB0aGUgdW5kZXJseWluZyBQQ0kgZGV2aWNl
IG5vdCBmdW5jdGlvbmFsLCBzbzoNCj4gKyAgICAgKiAgIC0gaWYgdGhlcmUgYXJlIG5vIHJlZ2lv
bnMgd3JpdGUgdGhlIGNvbW1hbmQgcmVnaXN0ZXIgbm93DQo+ICsgICAgICogICAtIGlmIHRoZXJl
IGFyZSByZWdpb25zIHRoZW4gZGVmZXIgd29yayBhbmQgd3JpdGUgbGF0ZXIgb24NCj4gKyAgICAg
Ki8NCj4gKyAgICBpZiAoICFudW1fbWVtX3JhbmdlcyApDQo+ICsgICAgICAgIHBjaV9jb25mX3dy
aXRlMTYocGRldi0+c2JkZiwgUENJX0NPTU1BTkQsIGNtZCk7DQo+ICsgICAgZWxzZQ0KPiArICAg
ICAgICBkZWZlcl9tYXAoZGV2LT5kb21haW4sIGRldiwgY21kLCByb21fb25seSwgbnVtX21lbV9y
YW5nZXMpOw0KPiAgIA0KPiAgICAgICByZXR1cm4gMDsNCj4gKw0KPiArZmFpbDoNCj4gKyAgICBm
b3IgKCBpID0gMDsgaSA8IEFSUkFZX1NJWkUoaGVhZGVyLT5iYXJzKTsgaSsrICkNCj4gKyAgICB7
DQo+ICsgICAgICAgIHN0cnVjdCB2cGNpX2JhciAqYmFyID0gJmhlYWRlci0+YmFyc1tpXTsNCj4g
Kw0KPiArICAgICAgICByYW5nZXNldF9kZXN0cm95KGJhci0+bWVtKTsNCj4gKyAgICAgICAgYmFy
LT5tZW0gPSBOVUxMOw0KPiArICAgIH0NCj4gKyAgICByZXR1cm4gcmM7DQo+ICAgfQ0KPiAgIA0K
PiAgIHN0YXRpYyB2b2lkIGNtZF93cml0ZShjb25zdCBzdHJ1Y3QgcGNpX2RldiAqcGRldiwgdW5z
aWduZWQgaW50IHJlZywNCj4gZGlmZiAtLWdpdCBhL3hlbi9pbmNsdWRlL3hlbi92cGNpLmggYi94
ZW4vaW5jbHVkZS94ZW4vdnBjaS5oDQo+IGluZGV4IGEwMzIwYjIyY2IzNi4uMzUyZTAyZDAxMDZk
IDEwMDY0NA0KPiAtLS0gYS94ZW4vaW5jbHVkZS94ZW4vdnBjaS5oDQo+ICsrKyBiL3hlbi9pbmNs
dWRlL3hlbi92cGNpLmgNCj4gQEAgLTgwLDYgKzgwLDcgQEAgc3RydWN0IHZwY2kgew0KPiAgICAg
ICAgICAgICAgIC8qIEd1ZXN0IHZpZXcgb2YgdGhlIEJBUi4gKi8NCj4gICAgICAgICAgICAgICB1
aW50NjRfdCBndWVzdF9hZGRyOw0KPiAgICAgICAgICAgICAgIHVpbnQ2NF90IHNpemU7DQo+ICsg
ICAgICAgICAgICBzdHJ1Y3QgcmFuZ2VzZXQgKm1lbTsNCj4gICAgICAgICAgICAgICBlbnVtIHsN
Cj4gICAgICAgICAgICAgICAgICAgVlBDSV9CQVJfRU1QVFksDQo+ICAgICAgICAgICAgICAgICAg
IFZQQ0lfQkFSX0lPLA0KPiBAQCAtMTU0LDkgKzE1NSw5IEBAIHN0cnVjdCB2cGNpIHsNCj4gICAN
Cj4gICBzdHJ1Y3QgdnBjaV92Y3B1IHsNCj4gICAgICAgLyogUGVyLXZjcHUgc3RydWN0dXJlIHRv
IHN0b3JlIHN0YXRlIHdoaWxlIHt1bn1tYXBwaW5nIG9mIFBDSSBCQVJzLiAqLw0KPiAtICAgIHN0
cnVjdCByYW5nZXNldCAqbWVtOw0KPiAgICAgICBzdHJ1Y3QgcGNpX2RldiAqcGRldjsNCj4gICAg
ICAgdWludDE2X3QgY21kOw0KPiArICAgIHVpbnQ4X3QgbnVtX21lbV9yYW5nZXM7DQo+ICAgICAg
IGJvb2wgcm9tX29ubHkgOiAxOw0KPiAgIH07DQo+ICAgDQo=


From xen-devel-bounces@lists.xenproject.org Mon Oct 25 11:53:54 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Oct 2021 11:53:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.215781.375150 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1meyY5-0001y1-My; Mon, 25 Oct 2021 11:53:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 215781.375150; Mon, 25 Oct 2021 11:53:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1meyY5-0001xu-Jo; Mon, 25 Oct 2021 11:53:53 +0000
Received: by outflank-mailman (input) for mailman id 215781;
 Mon, 25 Oct 2021 11:53:53 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=DEXr=PN=bombadil.srs.infradead.org=BATV+8af5701d0ad407599ae9+6637+infradead.org+dwmw2@srs-us1.protection.inumbo.net>)
 id 1meyY3-0001xo-T1
 for xen-devel@lists.xenproject.org; Mon, 25 Oct 2021 11:53:53 +0000
Received: from bombadil.infradead.org (unknown [2607:7c80:54:e::133])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id b21fab21-db0c-4c9c-997e-3cea66779fe9;
 Mon, 25 Oct 2021 11:53:49 +0000 (UTC)
Received: from [2001:8b0:10b:1::3ae] (helo=u3832b3a9db3152.ant.amazon.com)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1meyXn-00GJwf-3P; Mon, 25 Oct 2021 11:53:35 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b21fab21-db0c-4c9c-997e-3cea66779fe9
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=MIME-Version:Content-Type:References:
	In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Sender:Reply-To:
	Content-Transfer-Encoding:Content-ID:Content-Description;
	bh=+oTH2JSzfSRqupbRqs7ynm2uIyTp7R7BLhiwgY5HucA=; b=pJ39Xxqw50b+JXq7S4LAWVcecF
	2HhrvW9+6fNac8XIfPzd5g3uZ2ob+eGfXa9D3jf1+ILkqlZmkspPVg9HRCKw4NpM1uPSYBADiOe25
	uQMNnYd5Ulptaq7tvnIls2nwYrZjETLgHQzyFhn9uuj7Ptox1AdVHH1bPGEAC6VT4/Ak62KzzUlpC
	b2ptTTixAuFyT0flNAXpFqG7an0erom2gOHWmbwb6Ib4wDX/7FNMRC7OdMEx+ExmlkF6kCGuVxenk
	MXFCVsalqAOs/6Ipp5BzQXXKdzwZN0RJEooJHyukLi2oRbTgslfeq2ZUmTIsC0vXPGSzU9Mh8ObJL
	GGMGP5bA==;
Message-ID: <72d763d055929b8c81f0c8deab14b33bd252c946.camel@infradead.org>
Subject: Re: [PATCH] PCI/MSI: Fix masking MSI/MSI-X on Xen PV
From: David Woodhouse <dwmw2@infradead.org>
To: Roger Pau =?ISO-8859-1?Q?Monn=E9?= <roger.pau@citrix.com>
Cc: Jason Andryuk <jandryuk@gmail.com>, josef@oderland.se, 
	boris.ostrovsky@oracle.com, helgaas@kernel.org, jgross@suse.com, 
	linux-pci@vger.kernel.org, maz@kernel.org, tglx@linutronix.de, 
	xen-devel@lists.xenproject.org
Date: Mon, 25 Oct 2021 12:53:31 +0100
In-Reply-To: <YXaYe/RF6NWFKxGj@MacBook-Air-de-Roger.local>
References: <90277228-cf14-0cfa-c95e-d42e7d533353@oderland.se>
	 <20211025012503.33172-1-jandryuk@gmail.com>
	 <eb38c1d2707d03bf675d7b15f014cbe741de0998.camel@infradead.org>
	 <YXaYe/RF6NWFKxGj@MacBook-Air-de-Roger.local>
Content-Type: multipart/signed; micalg="sha-256"; protocol="application/pkcs7-signature";
	boundary="=-HSapMGvxNpR60S9yVrzB"
User-Agent: Evolution 3.36.5-0ubuntu1 
MIME-Version: 1.0
X-SRS-Rewrite: SMTP reverse-path rewritten from <dwmw2@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html


--=-HSapMGvxNpR60S9yVrzB
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, 2021-10-25 at 13:43 +0200, Roger Pau Monn=C3=A9 wrote:
> It's kind of optional for HVM guests, as it depends on
> XENFEAT_hvm_pirqs, which sadly gets unconditionally set for HVM
> guests, thus dropping any benefits from having hardware assisted APIC
> virtualization or posted interrupts support.

Indeed. After implementing PIRQ support for Xen guests running under
KVM, I spent a "happy" couple of days swearing at it because it
actually *worked* if something would just *unmask* the f***ing MSI, but
the guest inexplicably (to me) didn't do that.

Took me a while to work out that Xen itself is *snooping* on the MSI
table writes even while they are *masked*, to capture the magic MSI
message (with vector=3D=3D0) which means it's actually a PIRQ# in the
destination ID bits, and then magically unmask the MSI when the guest
binds that PIRQ to an event channel.

I did not enjoy implementing that part.

FWIW the *guest* could potentlaly be smarter here and elect not to use
PIRQs when hardware assisted vAPIC is present. Aren't there some bits
in the CPUID that Xen advertises, which indicate that?=20


--=-HSapMGvxNpR60S9yVrzB
Content-Type: application/pkcs7-signature; name="smime.p7s"
Content-Disposition: attachment; filename="smime.p7s"
Content-Transfer-Encoding: base64

MIAGCSqGSIb3DQEHAqCAMIACAQExDzANBglghkgBZQMEAgEFADCABgkqhkiG9w0BBwEAAKCCECow
ggUcMIIEBKADAgECAhEA4rtJSHkq7AnpxKUY8ZlYZjANBgkqhkiG9w0BAQsFADCBlzELMAkGA1UE
BhMCR0IxGzAZBgNVBAgTEkdyZWF0ZXIgTWFuY2hlc3RlcjEQMA4GA1UEBxMHU2FsZm9yZDEaMBgG
A1UEChMRQ09NT0RPIENBIExpbWl0ZWQxPTA7BgNVBAMTNENPTU9ETyBSU0EgQ2xpZW50IEF1dGhl
bnRpY2F0aW9uIGFuZCBTZWN1cmUgRW1haWwgQ0EwHhcNMTkwMTAyMDAwMDAwWhcNMjIwMTAxMjM1
OTU5WjAkMSIwIAYJKoZIhvcNAQkBFhNkd213MkBpbmZyYWRlYWQub3JnMIIBIjANBgkqhkiG9w0B
AQEFAAOCAQ8AMIIBCgKCAQEAsv3wObLTCbUA7GJqKj9vHGf+Fa+tpkO+ZRVve9EpNsMsfXhvFpb8
RgL8vD+L133wK6csYoDU7zKiAo92FMUWaY1Hy6HqvVr9oevfTV3xhB5rQO1RHJoAfkvhy+wpjo7Q
cXuzkOpibq2YurVStHAiGqAOMGMXhcVGqPuGhcVcVzVUjsvEzAV9Po9K2rpZ52FE4rDkpDK1pBK+
uOAyOkgIg/cD8Kugav5tyapydeWMZRJQH1vMQ6OVT24CyAn2yXm2NgTQMS1mpzStP2ioPtTnszIQ
Ih7ASVzhV6csHb8Yrkx8mgllOyrt9Y2kWRRJFm/FPRNEurOeNV6lnYAXOymVJwIDAQABo4IB0zCC
Ac8wHwYDVR0jBBgwFoAUgq9sjPjF/pZhfOgfPStxSF7Ei8AwHQYDVR0OBBYEFLfuNf820LvaT4AK
xrGK3EKx1DE7MA4GA1UdDwEB/wQEAwIFoDAMBgNVHRMBAf8EAjAAMB0GA1UdJQQWMBQGCCsGAQUF
BwMEBggrBgEFBQcDAjBGBgNVHSAEPzA9MDsGDCsGAQQBsjEBAgEDBTArMCkGCCsGAQUFBwIBFh1o
dHRwczovL3NlY3VyZS5jb21vZG8ubmV0L0NQUzBaBgNVHR8EUzBRME+gTaBLhklodHRwOi8vY3Js
LmNvbW9kb2NhLmNvbS9DT01PRE9SU0FDbGllbnRBdXRoZW50aWNhdGlvbmFuZFNlY3VyZUVtYWls
Q0EuY3JsMIGLBggrBgEFBQcBAQR/MH0wVQYIKwYBBQUHMAKGSWh0dHA6Ly9jcnQuY29tb2RvY2Eu
Y29tL0NPTU9ET1JTQUNsaWVudEF1dGhlbnRpY2F0aW9uYW5kU2VjdXJlRW1haWxDQS5jcnQwJAYI
KwYBBQUHMAGGGGh0dHA6Ly9vY3NwLmNvbW9kb2NhLmNvbTAeBgNVHREEFzAVgRNkd213MkBpbmZy
YWRlYWQub3JnMA0GCSqGSIb3DQEBCwUAA4IBAQALbSykFusvvVkSIWttcEeifOGGKs7Wx2f5f45b
nv2ghcxK5URjUvCnJhg+soxOMoQLG6+nbhzzb2rLTdRVGbvjZH0fOOzq0LShq0EXsqnJbbuwJhK+
PnBtqX5O23PMHutP1l88AtVN+Rb72oSvnD+dK6708JqqUx2MAFLMevrhJRXLjKb2Mm+/8XBpEw+B
7DisN4TMlLB/d55WnT9UPNHmQ+3KFL7QrTO8hYExkU849g58Dn3Nw3oCbMUgny81ocrLlB2Z5fFG
Qu1AdNiBA+kg/UxzyJZpFbKfCITd5yX49bOriL692aMVDyqUvh8fP+T99PqorH4cIJP6OxSTdxKM
MIIFHDCCBASgAwIBAgIRAOK7SUh5KuwJ6cSlGPGZWGYwDQYJKoZIhvcNAQELBQAwgZcxCzAJBgNV
BAYTAkdCMRswGQYDVQQIExJHcmVhdGVyIE1hbmNoZXN0ZXIxEDAOBgNVBAcTB1NhbGZvcmQxGjAY
BgNVBAoTEUNPTU9ETyBDQSBMaW1pdGVkMT0wOwYDVQQDEzRDT01PRE8gUlNBIENsaWVudCBBdXRo
ZW50aWNhdGlvbiBhbmQgU2VjdXJlIEVtYWlsIENBMB4XDTE5MDEwMjAwMDAwMFoXDTIyMDEwMTIz
NTk1OVowJDEiMCAGCSqGSIb3DQEJARYTZHdtdzJAaW5mcmFkZWFkLm9yZzCCASIwDQYJKoZIhvcN
AQEBBQADggEPADCCAQoCggEBALL98Dmy0wm1AOxiaio/bxxn/hWvraZDvmUVb3vRKTbDLH14bxaW
/EYC/Lw/i9d98CunLGKA1O8yogKPdhTFFmmNR8uh6r1a/aHr301d8YQea0DtURyaAH5L4cvsKY6O
0HF7s5DqYm6tmLq1UrRwIhqgDjBjF4XFRqj7hoXFXFc1VI7LxMwFfT6PStq6WedhROKw5KQytaQS
vrjgMjpICIP3A/CroGr+bcmqcnXljGUSUB9bzEOjlU9uAsgJ9sl5tjYE0DEtZqc0rT9oqD7U57My
ECIewElc4VenLB2/GK5MfJoJZTsq7fWNpFkUSRZvxT0TRLqznjVepZ2AFzsplScCAwEAAaOCAdMw
ggHPMB8GA1UdIwQYMBaAFIKvbIz4xf6WYXzoHz0rcUhexIvAMB0GA1UdDgQWBBS37jX/NtC72k+A
CsaxitxCsdQxOzAOBgNVHQ8BAf8EBAMCBaAwDAYDVR0TAQH/BAIwADAdBgNVHSUEFjAUBggrBgEF
BQcDBAYIKwYBBQUHAwIwRgYDVR0gBD8wPTA7BgwrBgEEAbIxAQIBAwUwKzApBggrBgEFBQcCARYd
aHR0cHM6Ly9zZWN1cmUuY29tb2RvLm5ldC9DUFMwWgYDVR0fBFMwUTBPoE2gS4ZJaHR0cDovL2Ny
bC5jb21vZG9jYS5jb20vQ09NT0RPUlNBQ2xpZW50QXV0aGVudGljYXRpb25hbmRTZWN1cmVFbWFp
bENBLmNybDCBiwYIKwYBBQUHAQEEfzB9MFUGCCsGAQUFBzAChklodHRwOi8vY3J0LmNvbW9kb2Nh
LmNvbS9DT01PRE9SU0FDbGllbnRBdXRoZW50aWNhdGlvbmFuZFNlY3VyZUVtYWlsQ0EuY3J0MCQG
CCsGAQUFBzABhhhodHRwOi8vb2NzcC5jb21vZG9jYS5jb20wHgYDVR0RBBcwFYETZHdtdzJAaW5m
cmFkZWFkLm9yZzANBgkqhkiG9w0BAQsFAAOCAQEAC20spBbrL71ZEiFrbXBHonzhhirO1sdn+X+O
W579oIXMSuVEY1LwpyYYPrKMTjKECxuvp24c829qy03UVRm742R9Hzjs6tC0oatBF7KpyW27sCYS
vj5wbal+TttzzB7rT9ZfPALVTfkW+9qEr5w/nSuu9PCaqlMdjABSzHr64SUVy4ym9jJvv/FwaRMP
gew4rDeEzJSwf3eeVp0/VDzR5kPtyhS+0K0zvIWBMZFPOPYOfA59zcN6AmzFIJ8vNaHKy5QdmeXx
RkLtQHTYgQPpIP1Mc8iWaRWynwiE3ecl+PWzq4i+vdmjFQ8qlL4fHz/k/fT6qKx+HCCT+jsUk3cS
jDCCBeYwggPOoAMCAQICEGqb4Tg7/ytrnwHV2binUlYwDQYJKoZIhvcNAQEMBQAwgYUxCzAJBgNV
BAYTAkdCMRswGQYDVQQIExJHcmVhdGVyIE1hbmNoZXN0ZXIxEDAOBgNVBAcTB1NhbGZvcmQxGjAY
BgNVBAoTEUNPTU9ETyBDQSBMaW1pdGVkMSswKQYDVQQDEyJDT01PRE8gUlNBIENlcnRpZmljYXRp
b24gQXV0aG9yaXR5MB4XDTEzMDExMDAwMDAwMFoXDTI4MDEwOTIzNTk1OVowgZcxCzAJBgNVBAYT
AkdCMRswGQYDVQQIExJHcmVhdGVyIE1hbmNoZXN0ZXIxEDAOBgNVBAcTB1NhbGZvcmQxGjAYBgNV
BAoTEUNPTU9ETyBDQSBMaW1pdGVkMT0wOwYDVQQDEzRDT01PRE8gUlNBIENsaWVudCBBdXRoZW50
aWNhdGlvbiBhbmQgU2VjdXJlIEVtYWlsIENBMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKC
AQEAvrOeV6wodnVAFsc4A5jTxhh2IVDzJXkLTLWg0X06WD6cpzEup/Y0dtmEatrQPTRI5Or1u6zf
+bGBSyD9aH95dDSmeny1nxdlYCeXIoymMv6pQHJGNcIDpFDIMypVpVSRsivlJTRENf+RKwrB6vcf
WlP8dSsE3Rfywq09N0ZfxcBa39V0wsGtkGWC+eQKiz4pBZYKjrc5NOpG9qrxpZxyb4o4yNNwTqza
aPpGRqXB7IMjtf7tTmU2jqPMLxFNe1VXj9XB1rHvbRikw8lBoNoSWY66nJN/VCJv5ym6Q0mdCbDK
CMPybTjoNCQuelc0IAaO4nLUXk0BOSxSxt8kCvsUtQIDAQABo4IBPDCCATgwHwYDVR0jBBgwFoAU
u69+Aj36pvE8hI6t7jiY7NkyMtQwHQYDVR0OBBYEFIKvbIz4xf6WYXzoHz0rcUhexIvAMA4GA1Ud
DwEB/wQEAwIBhjASBgNVHRMBAf8ECDAGAQH/AgEAMBEGA1UdIAQKMAgwBgYEVR0gADBMBgNVHR8E
RTBDMEGgP6A9hjtodHRwOi8vY3JsLmNvbW9kb2NhLmNvbS9DT01PRE9SU0FDZXJ0aWZpY2F0aW9u
QXV0aG9yaXR5LmNybDBxBggrBgEFBQcBAQRlMGMwOwYIKwYBBQUHMAKGL2h0dHA6Ly9jcnQuY29t
b2RvY2EuY29tL0NPTU9ET1JTQUFkZFRydXN0Q0EuY3J0MCQGCCsGAQUFBzABhhhodHRwOi8vb2Nz
cC5jb21vZG9jYS5jb20wDQYJKoZIhvcNAQEMBQADggIBAHhcsoEoNE887l9Wzp+XVuyPomsX9vP2
SQgG1NgvNc3fQP7TcePo7EIMERoh42awGGsma65u/ITse2hKZHzT0CBxhuhb6txM1n/y78e/4ZOs
0j8CGpfb+SJA3GaBQ+394k+z3ZByWPQedXLL1OdK8aRINTsjk/H5Ns77zwbjOKkDamxlpZ4TKSDM
KVmU/PUWNMKSTvtlenlxBhh7ETrN543j/Q6qqgCWgWuMAXijnRglp9fyadqGOncjZjaaSOGTTFB+
E2pvOUtY+hPebuPtTbq7vODqzCM6ryEhNhzf+enm0zlpXK7q332nXttNtjv7VFNYG+I31gnMrwfH
M5tdhYF/8v5UY5g2xANPECTQdu9vWPoqNSGDt87b3gXb1AiGGaI06vzgkejL580ul+9hz9D0S0U4
jkhJiA7EuTecP/CFtR72uYRBcunwwH3fciPjviDDAI9SnC/2aPY8ydehzuZutLbZdRJ5PDEJM/1t
yZR2niOYihZ+FCbtf3D9mB12D4ln9icgc7CwaxpNSCPt8i/GqK2HsOgkL3VYnwtx7cJUmpvVdZ4o
gnzgXtgtdk3ShrtOS1iAN2ZBXFiRmjVzmehoMof06r1xub+85hFQzVxZx5/bRaTKTlL8YXLI8nAb
R9HWdFqzcOoB/hxfEyIQpx9/s81rgzdEZOofSlZHynoSMYIDyjCCA8YCAQEwga0wgZcxCzAJBgNV
BAYTAkdCMRswGQYDVQQIExJHcmVhdGVyIE1hbmNoZXN0ZXIxEDAOBgNVBAcTB1NhbGZvcmQxGjAY
BgNVBAoTEUNPTU9ETyBDQSBMaW1pdGVkMT0wOwYDVQQDEzRDT01PRE8gUlNBIENsaWVudCBBdXRo
ZW50aWNhdGlvbiBhbmQgU2VjdXJlIEVtYWlsIENBAhEA4rtJSHkq7AnpxKUY8ZlYZjANBglghkgB
ZQMEAgEFAKCCAe0wGAYJKoZIhvcNAQkDMQsGCSqGSIb3DQEHATAcBgkqhkiG9w0BCQUxDxcNMjEx
MDI1MTE1MzMxWjAvBgkqhkiG9w0BCQQxIgQggaTXBBnm7WQ2rTSVzeBIJfci8SLiWd/uJjf5CowL
HpMwgb4GCSsGAQQBgjcQBDGBsDCBrTCBlzELMAkGA1UEBhMCR0IxGzAZBgNVBAgTEkdyZWF0ZXIg
TWFuY2hlc3RlcjEQMA4GA1UEBxMHU2FsZm9yZDEaMBgGA1UEChMRQ09NT0RPIENBIExpbWl0ZWQx
PTA7BgNVBAMTNENPTU9ETyBSU0EgQ2xpZW50IEF1dGhlbnRpY2F0aW9uIGFuZCBTZWN1cmUgRW1h
aWwgQ0ECEQDiu0lIeSrsCenEpRjxmVhmMIHABgsqhkiG9w0BCRACCzGBsKCBrTCBlzELMAkGA1UE
BhMCR0IxGzAZBgNVBAgTEkdyZWF0ZXIgTWFuY2hlc3RlcjEQMA4GA1UEBxMHU2FsZm9yZDEaMBgG
A1UEChMRQ09NT0RPIENBIExpbWl0ZWQxPTA7BgNVBAMTNENPTU9ETyBSU0EgQ2xpZW50IEF1dGhl
bnRpY2F0aW9uIGFuZCBTZWN1cmUgRW1haWwgQ0ECEQDiu0lIeSrsCenEpRjxmVhmMA0GCSqGSIb3
DQEBAQUABIIBAGiBQYVtuIs9gYlxj+BNwpJxzOoOKMyO9jMvwAunkdMSFXGsPnJNHS+iJbq2YOIx
qz+EzAQdC1RqDcz9bEXaOQ1LQD2wFMTcYnmn+Ga2Q/R7jYrNwi8nkaWosXnHK867XPb6qYu58cjx
SLyMTQjsKEN76m6zxR2lI9c/9nxO0ufasJRGNWRtQjeAs/l8CNosVWXGgaixL1BQaCbhigxCe+TF
Si5AqCGg65Aa3muJFaouolkwCdnOqm0Lbh4UnHTil9SRuJEMwtrNejButQL0tI7Ca9JjjBX2TUav
7PwIPuz1z6T4QPjy24y00BepjOxIdDnAsecUYBYwkhgq5LoUtXcAAAAAAAA=


--=-HSapMGvxNpR60S9yVrzB--



From xen-devel-bounces@lists.xenproject.org Mon Oct 25 12:27:45 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Oct 2021 12:27:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.215795.375162 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mez4k-0005SW-LW; Mon, 25 Oct 2021 12:27:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 215795.375162; Mon, 25 Oct 2021 12:27:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mez4k-0005SP-IW; Mon, 25 Oct 2021 12:27:38 +0000
Received: by outflank-mailman (input) for mailman id 215795;
 Mon, 25 Oct 2021 12:27:37 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=9eqc=PN=gmail.com=jandryuk@srs-us1.protection.inumbo.net>)
 id 1mez4j-0005SJ-5U
 for xen-devel@lists.xenproject.org; Mon, 25 Oct 2021 12:27:37 +0000
Received: from mail-lf1-x129.google.com (unknown [2a00:1450:4864:20::129])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 29238a89-4d51-48a1-ace4-07e9ea9cb8f0;
 Mon, 25 Oct 2021 12:27:36 +0000 (UTC)
Received: by mail-lf1-x129.google.com with SMTP id bq11so9556053lfb.10
 for <xen-devel@lists.xenproject.org>; Mon, 25 Oct 2021 05:27:36 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 29238a89-4d51-48a1-ace4-07e9ea9cb8f0
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=cWOZ10wj2v8xGCTkB4tkDGPE0ipYkZlGVNgK1wjlSKw=;
        b=iBb9cr5DvW2ttDUCpykmiohztN7R33oVN5Uzv47denlfZ3S10nnPCRIV2oR41D4oJ0
         fiUKRMDKPj8poOJOTAOwVcKq1vp/Nrru9Ooj7EMpncTk/tFPFRCdPajifeZsNkj5CUaw
         gPauzwfypIk/JVBtjptq7HigkNPjqdtii4W6RH4gOfJgW0pxzivUA6A8PX8SycbGKUTJ
         hqUhvnIhXq23gFKmOsRKmIhS7uB4TVMHfiAih56j3hNZe94fut/JT4Vr8cSxOwrbK+ff
         znQ5Tfs33QGMbPfIgz9YHGJlpe1SyAEIonzkCeTjaizM/Ygq9anFaJUTFVOnuhsLc5qJ
         mbcQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=cWOZ10wj2v8xGCTkB4tkDGPE0ipYkZlGVNgK1wjlSKw=;
        b=A0LS6IUrlnicHkf3r9oTClZUL+a7Czt/4/80Q4wGmL71bf3l09gtrLGwLd40ajp0um
         AkrbIdIkStWKP9wisKjl3LVjWGBKWUHOyi4Hl4elTsgbezIlXLwIc1D/kUEXBcvAXcsz
         /mPGP4sXh9PwRxYSrQ8jCjLjvfF+sBZ3yXb6mJszzQKWStIdVUYdfZ5AIyYmrMXtfhvm
         y//S7iPNv39LfDSDHCZIMstW2cFUupL0QIlfA3stuaLUOheV+I5BUVjVw4q/qXeBctxB
         vjKQJ1hm7kpGVRo3EHwaeYIqvmZ9wU6UxxAjbtltp3+iRwfdXKONoeTdrPiIOZ/57Zy4
         kZ6w==
X-Gm-Message-State: AOAM5322M7OhfNcZnFMWrUAn46hYu2AKQZjb+qvT7XyPLbuJX9yUOipP
	WE6Fyqut19OKmvDp3qZ/J7O+9gTbWjKwQbqQ5wg=
X-Google-Smtp-Source: ABdhPJzKdoy+jz5VQV5Ihbb1TCNijRakZIFx6FMRizoKZTvmhjIQMJT/zQWj2ePGI5xnyqAUpbTaxMlQh/TKk/n205A=
X-Received: by 2002:a05:6512:3d89:: with SMTP id k9mr7771626lfv.359.1635164855150;
 Mon, 25 Oct 2021 05:27:35 -0700 (PDT)
MIME-Version: 1.0
References: <90277228-cf14-0cfa-c95e-d42e7d533353@oderland.se> <20211025012503.33172-1-jandryuk@gmail.com>
In-Reply-To: <20211025012503.33172-1-jandryuk@gmail.com>
From: Jason Andryuk <jandryuk@gmail.com>
Date: Mon, 25 Oct 2021 08:27:23 -0400
Message-ID: <CAKf6xptSbuj3VGxzed1uPx59cA_BRJY5FDHczX744rvnTHB8Lg@mail.gmail.com>
Subject: Re: [PATCH] PCI/MSI: Fix masking MSI/MSI-X on Xen PV
To: Josef Johansson <josef@oderland.se>
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>, Bjorn Helgaas <helgaas@kernel.org>, 
	Juergen Gross <jgross@suse.com>, linux-pci@vger.kernel.org, Marc Zyngier <maz@kernel.org>, 
	Thomas Gleixner <tglx@linutronix.de>, xen-devel <xen-devel@lists.xenproject.org>
Content-Type: text/plain; charset="UTF-8"

On Sun, Oct 24, 2021 at 9:26 PM Jason Andryuk <jandryuk@gmail.com> wrote:
>
> commit fcacdfbef5a1 ("PCI/MSI: Provide a new set of mask and unmask
> functions") introduce functions pci_msi_update_mask() and
> pci_msix_write_vector_ctrl() that is missing checks for
> pci_msi_ignore_mask that exists in commit 446a98b19fd6 ("PCI/MSI: Use
> new mask/unmask functions").  The checks are in place at the high level
> __pci_msi_mask_desc()/__pci_msi_unmask_desc(), but some functions call
> directly to the helpers.
>
> Push the pci_msi_ignore_mask check down to the functions that make
> the actual writes.  This keeps the logic local to the writes that need
> to be bypassed.
>
> With Xen PV, the hypervisor is responsible for masking and unmasking the
> interrupts, which pci_msi_ignore_mask is used to indicate.
>
> This change avoids lockups in amdgpu drivers under Xen during boot.
>
> Fixes: commit 446a98b19fd6 ("PCI/MSI: Use new mask/unmask functions")
> Reported-by: Josef Johansson <josef@oderland.se>
> Signed-off-by: Jason Andryuk <jandryuk@gmail.com>
> ---

I should have written that this is untested.  If this is the desired
approach, Josef should test that it solves his boot hangs.

Regards,
Jason


From xen-devel-bounces@lists.xenproject.org Mon Oct 25 12:31:57 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Oct 2021 12:31:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.215802.375173 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mez8u-0006q5-7q; Mon, 25 Oct 2021 12:31:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 215802.375173; Mon, 25 Oct 2021 12:31:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mez8u-0006py-3e; Mon, 25 Oct 2021 12:31:56 +0000
Received: by outflank-mailman (input) for mailman id 215802;
 Mon, 25 Oct 2021 12:31:55 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=9eqc=PN=gmail.com=jandryuk@srs-us1.protection.inumbo.net>)
 id 1mez8t-0006ps-2V
 for xen-devel@lists.xenproject.org; Mon, 25 Oct 2021 12:31:55 +0000
Received: from mail-lf1-x136.google.com (unknown [2a00:1450:4864:20::136])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id fce91ae7-2e36-44a4-8970-bd11ddf32f18;
 Mon, 25 Oct 2021 12:31:54 +0000 (UTC)
Received: by mail-lf1-x136.google.com with SMTP id y26so9106494lfa.11
 for <xen-devel@lists.xenproject.org>; Mon, 25 Oct 2021 05:31:54 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fce91ae7-2e36-44a4-8970-bd11ddf32f18
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=rsXzxcxV0y5xMwXg4e7QntuXuk695o/R/LGfdUxufpA=;
        b=UclQCWoAv/aInb3BX+pcCYm0XwoRRLg80Fem/NVkw+y0qjEEcpB76FpBdjTp8vuK1l
         z50Yeu6KoK2B/7LVypXChh0LkNiwjKjm3orMDx5yOABtMiwwjkYs3NEIx7h3KxkjdDdP
         Ek7NLHytlcCgWuz6xBQYu3Q403aKF7vQuGLXhTVh6z0Pzvn+JGXltleEp250t38JzH5j
         s4EPzZTZxzd/l83xcwuR+WVOPek9mSUTXQbRelreN6AZqWyrHC3KmxczQUZfWae9+KEL
         vTq70uNd/ShSO42sqqkPdHucUQN/mJWzpyYYCytxFaJSHRB87w0ZDUWAzYEf5GEHdsqO
         ar2A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=rsXzxcxV0y5xMwXg4e7QntuXuk695o/R/LGfdUxufpA=;
        b=ZZJhaM+r4o8y49fuVVtxG8A9zE5OYpjca+VQOj/FzVn1IW+1XytBon2qhuaNpP0U6Y
         KPz6cwJKt22FCKiDY/6g3RwiMrcQjHYAdZ7Yg1ST4gVW37KwxlUW0VERU4ikCoAZwbTA
         U0vSURk/TZaP1OkDYsSNAZmB47iPmndLcvyKmqSSpbn+qt1o3excs7lRgPzCDoJ2NYQI
         qFQhD18jirSsqC0rMMUEG/q6aRWjd/v/0+0jSCYhlIj5oOB5VVYpg4JNYL4xvvJU8OvU
         csw/cTCOfFQNOkuLkP2OuuW/9WeymhA/Vfg5osLxdhxPySxR/0tEaZa8qL3g7JjIqxrY
         7w4g==
X-Gm-Message-State: AOAM533fSct46dHLpySFaK31v28Ehbjhnn7Ia0EE6Fk/UbJJ5mjhCxF4
	zqGoZCZCzoqy4458hxWBlrT6AkFnwXJzTajSrTA=
X-Google-Smtp-Source: ABdhPJzmw7j45jN5rCnXFGhqUnslOEjOY9G+jsrw/HmHox7WH0FH5oHXmcXWmHzJplbhYRjkRg+VGMR9MuRvpdL6/j4=
X-Received: by 2002:a19:7903:: with SMTP id u3mr15963739lfc.406.1635165113269;
 Mon, 25 Oct 2021 05:31:53 -0700 (PDT)
MIME-Version: 1.0
References: <90277228-cf14-0cfa-c95e-d42e7d533353@oderland.se>
 <20211025012503.33172-1-jandryuk@gmail.com> <eb38c1d2707d03bf675d7b15f014cbe741de0998.camel@infradead.org>
In-Reply-To: <eb38c1d2707d03bf675d7b15f014cbe741de0998.camel@infradead.org>
From: Jason Andryuk <jandryuk@gmail.com>
Date: Mon, 25 Oct 2021 08:31:41 -0400
Message-ID: <CAKf6xpvkF55U7Zrtx4PK=tqT8fjdmY-kZSm3WJO1gAnutnum-A@mail.gmail.com>
Subject: Re: [PATCH] PCI/MSI: Fix masking MSI/MSI-X on Xen PV
To: David Woodhouse <dwmw2@infradead.org>
Cc: Josef Johansson <josef@oderland.se>, Boris Ostrovsky <boris.ostrovsky@oracle.com>, 
	Bjorn Helgaas <helgaas@kernel.org>, Juergen Gross <jgross@suse.com>, linux-pci@vger.kernel.org, 
	Marc Zyngier <maz@kernel.org>, Thomas Gleixner <tglx@linutronix.de>, 
	xen-devel <xen-devel@lists.xenproject.org>
Content-Type: text/plain; charset="UTF-8"

On Mon, Oct 25, 2021 at 3:44 AM David Woodhouse <dwmw2@infradead.org> wrote:
>
> On Sun, 2021-10-24 at 21:25 -0400, Jason Andryuk wrote:
> > commit fcacdfbef5a1 ("PCI/MSI: Provide a new set of mask and unmask
> > functions") introduce functions pci_msi_update_mask() and
> > pci_msix_write_vector_ctrl() that is missing checks for
> > pci_msi_ignore_mask that exists in commit 446a98b19fd6 ("PCI/MSI: Use
> > new mask/unmask functions").  The checks are in place at the high level
> > __pci_msi_mask_desc()/__pci_msi_unmask_desc(), but some functions call
> > directly to the helpers.
> >
> > Push the pci_msi_ignore_mask check down to the functions that make
> > the actual writes.  This keeps the logic local to the writes that need
> > to be bypassed.
> >
> > With Xen PV, the hypervisor is responsible for masking and unmasking the
> > interrupts, which pci_msi_ignore_mask is used to indicate.
>
> This isn't just for Xen PV; Xen HVM guests let Xen unmask the MSI for
> them too.

Ah, that makes sense that Xen handles both.  I was repeating another
commit message's statement.  Oh, it looks like pci_msi_ignore_mask is
PV-specific.

Regards,
Jason


From xen-devel-bounces@lists.xenproject.org Mon Oct 25 12:59:22 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Oct 2021 12:59:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.215809.375184 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mezZF-0000ut-E8; Mon, 25 Oct 2021 12:59:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 215809.375184; Mon, 25 Oct 2021 12:59:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mezZF-0000um-As; Mon, 25 Oct 2021 12:59:09 +0000
Received: by outflank-mailman (input) for mailman id 215809;
 Mon, 25 Oct 2021 12:59:08 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=G2Ub=PN=citrix.com=roger.pau@srs-us1.protection.inumbo.net>)
 id 1mezZD-0000ug-P1
 for xen-devel@lists.xenproject.org; Mon, 25 Oct 2021 12:59:08 +0000
Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 9a3e2f40-b99a-43b9-bd55-620dbd54aaa2;
 Mon, 25 Oct 2021 12:59:06 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9a3e2f40-b99a-43b9-bd55-620dbd54aaa2
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1635166746;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=2KivBIZDND/s71bmuPR2OicjG/jSEt9jUUp6qvN9fMs=;
  b=I/aAqd/cIbej1RJ/5CUsVJR3TeIb7TPqlioR0UHu5uOqtaLIxleWQpoJ
   mzRXBSul34tOFdHtpUq+mgenw2ES4/nu086gs22S776WnSMHuOdJpeO0T
   lB82twTH7wKxYfTRMb9BUkElRsCM4qm8OxyZoRM1f3/mU1siRwCuQG4vC
   Q=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: AGlHCg7y+hIsBHbp+Xs3RBUBzT33guBx1C7xpAlQS+Xq5QvllD21Sd5xBdy8hF34zRQqFS6+04
 MoPdt1D9rpo78sJYgFgLhs71sLcaqZ/Oa0r4xNvvWflvcnXH5KwIH+rl1uF/PrBPlopCLv0Fno
 DJoXSHoQUv2EcFOcmj5f/WirQF0WKS4AF7E8/KNtzbUP87zyAY+cTVtoZ6omXTESrS8a5JzW0t
 4p1c+wdiy6Ey0ih4LPydoSMwekPze9ZRRB9XGwjgzNBE+c9+3x0cob3+m2s0onOBX65yFLkOKm
 GNoh+7pYkMpZ+G6GuXoGDn6z
X-SBRS: 5.1
X-MesageID: 56003971
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:UVSf6a/leLbhi/WRURsoDrUD83iTJUtcMsCJ2f8bNWPcYEJGY0x3y
 WIYUWjQOf+PYTegeYoiYN61oxsFupOEn9NrHlFlry88E34SpcT7XtnIdU2Y0wF+jyHgoOCLy
 +1EN7Es+ehtFie0Si9AttENlFEkvU2ybuOU5NXsZ2YhGmeIdA970Ug6wrZj39Yx6TSEK1jlV
 e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH
 I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPgyy
 NNgnJmuRjskL6Dpg+YFfzdmEiZxaPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us
 6ZCcXZUM07F17neLLGTE4GAguw5K8bmJsUHs2xIxjDFF/c2B5vERs0m4PcFgm9o3ZERRJ4yY
 eI6czk2ZwacbiYIeRAdWZgzsLysuHPWJmgwRFW9+vNsvjm7IBZK+LzsNsfFP8SBRO1LkUuC4
 GHL5WL0BlcdLtP34TiK6HW3ncfUgDj2HokVEdWQ8/d4qF6e3GoeDFsRT1TTiem0jAuyVsxSL
 2QQ+zEytu4i+UqzVN7/Uhak5nmesXY0R9VUA8U+6QeQ1rDT5QeJQGQJJhZDYdoqrt4rRhQl0
 1aIm5XiAjkHmLGKTG3H3raSoym7NSUcISkFfyBsZQkC+NTtiIY/gwjLR9BvVrW45vX1FDX/y
 jmRhCsznbMeiYgMzarT1VrAmTO34J/SUhQy+B7UT0qi9ApyYIPjbIutgWU39t4ZctzfFAPY+
 iFZxY7Ot4jiEK1higTOQOMgNbS36MqIITD5mlx3M7cf9jOirivLkZ9r3BlyI0JgM8AhcDDvY
 VPOtQ452KK/LEdGfocsPNrvU5VCIbzIUI2/DKiNP4Umjo1ZLVffpElTiVisM3cBeaTGuZo0P
 ouHao6SBHIeBLUPINGeFrpFj+FDKszTwwruqXHHI/aPjOL2iJ29E+5t3L6yggcRt/vsnekt2
 4wDX/ZmMj0GOAEEXgHZ8JQIMXcBJmUhCJb9pqR/L7DYf1M+QDtwU6eLkdvNnrCJeYwPxo8kG
 VnmAidlJKfX3yWbeW1mlFg6MNsDoqqTXVpkZHdxbD5EKlAoYJq17bd3SnfEVeJPyQCX9tYtF
 6NtU5zZWpxnE22bkxxAPciVhNEzL3yD2FPRVxdJlRBiJvaMsSSSoYS6FuYunQFTZheKWTwW+
 uzwiFiDGsFdFmyPzq/+MZqS8r94hlBE8MpaVErUONhDPkLq9YlhMSvqifErZcoLLH3+KvGyj
 m562D8U+rvApZEb6t7MifzWpoulCbImTEFbA3Pa/fC9MiyDpjivxopJUeCpezHBVTyrpPX+N
 LsNl/ysYucamFtqspZnF+o5x6wJ+Nay9aRRyR5pHSuXYg3zWK9gOHSPweJGqrZJmu1CoQKzV
 0/WootaNLyFNdnLClkUIAZ5PO2P2etNwmvZ7OgvIVW87yhypeLVXUJXNhiKqSpcMLoqb991n
 bZ/4JYbslXthAArP9CKijFv216NdnFQAb86spw6AZPwjlZ5wF91fpGBWDT954uCaosQPxByc
 COUnqfLm59V2lHGLygoDXHI0OdQ2cYOtRRNwANQLliFgIOY1Po+3RkX+jUrVAVFiB5A1rsra
 GRsMkR0I4SI/itp25cfDzz9RVkZCU3L4FH1xnsIiHbdHhuhWWH6JWEgPfqAoRIC+GVGczkHp
 LyVxQ4Ji9oxkB0dCsfqZXNYlg==
IronPort-HdrOrdr: A9a23:ZyzxJKzyBt644Ghtd7znKrPxOugkLtp133Aq2lEZdPULSL36qy
 n+ppQmPEHP6Qr5AEtQ5uxo9pPwEU80hqQFn7X5XI3SEjUO3VHEEGgM1/qY/9SRIUfDH4JmpM
 Ndmu1FeaHN5DtB/IfHCWuDYqwdKbC8mcjC6YixvhUdKD2CKZsQkjuRYTzrdHGeMTM2fabRY6
 Dsn/avyQDQHkg/X4CePD0oTuLDr9rEmNbNehgdHSMq7wGIkHeB9KP6OwLw5GZcbxp/hZMZtU
 TVmQ3w4auu99uhzAXH6mPV55NK3PP819p4AtCWgMR9EESvtu/oXvUlZ1SxhkFznAid0idtrD
 AKmWZ4Ay1H0QKUQohym2q05+Cv6kd015ao8y7ovZKqm72IeNt9MbsAuatpNiLD7Uwupdd917
 8O8V64mvNsfEn9tRW43sPPUR5ykEqyvD4Fqs48y1JicaZ2Us4NkWQ4lHklT6vo2BiKtLzOWI
 RVfZPhDL06SyLIU5iR01MfkeBFFBkIb0K7qjBugL3K79EepgEL82IIgMMYhXsO75Q7Vt1N4P
 nFKL1hkPVUQtYRdr8VPpZNfSKbMB2Hffv3ChPZHb0nLtBxB1vd75rspLkl7uCjf5IFiJM0hZ
 TaSVtd8Wo/YVjnB8GC1IBCtkmlehTzYR39jsVFo5RpsLz1Q7TmdSWFVVA1isOl5/ESGNfSVf
 q/MI9fR/XjMWztE4BU2BCWYegfFVAOFMkO/torUVOHpczGboXsq+zAaf7WYKHgFD41M1mPSk
 frnAKDbfmownrbL0MQsSKhLU8FIHaPj66YOJKqi9Qu9A==
X-IronPort-AV: E=Sophos;i="5.87,180,1631592000"; 
   d="scan'208";a="56003971"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=MfdX0Zuj8/Frnz7c5fhNQK/Vj4YPjxc9rRmK1C5xDKN8B03+CL3NyVE/p74rr5qSxj7lhLahVLq/9RN5VjrGbo/Qgw7o+3oU1FxtcWahaNh5fcZJYAZSTdtcjDRXZK4hH807fX/9FC1aPYlX5umBsTX+fgQ6NT9oWGRN8/bPo0VzF9QlreMNWVWHxbCtGlBf8EM+/LiDRMbgDbRbbNajuCXUSf1Box/YBFzr8bLH8ol08FRD48iKZ6KXLn2JxIRX7p6Z2aIsdvY9Vh7sx1QtmR4zpee1EIHpuHPXWZliLHr2x0V8MnGiWuiCj6YpXyzkA0vv9BEcNo43G3SzriNN6A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=u5HlCx1T4j1mLh8UL4lgbY+XWzMabz9h68wj0xoDXNg=;
 b=PzXDVuG7S2bjYvbNiGo097D+Tvw0A0F0ffKC70pVBcjTLXew7mf1z6xTMwDZyaAVcRmlACWnnpw+cDkI5N0LFgLN4L8Ho5CN2y5C81R4FUKkR0meolKvVaoRT31YrxYg0kSkz3hpQBkiL7DB76qgdjDoNmS9/CTTicP2kesiuCKAxaf6kIpRdkwbG9UJ9TIzeDJjL0xL5Q3C66Gb6Lt0RilJV1EyT1G/yeK1M9T135fKYTNXJTjz3w0q/KMwSELD/zT+mb4xSFFhSfpoKZWnWBloHwyuRYxUmitJ5WPAvN4iAh+m32I05Grzpr0gA+8WDIxw7oNyvp+ozloxX5iLgw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=u5HlCx1T4j1mLh8UL4lgbY+XWzMabz9h68wj0xoDXNg=;
 b=YNVIzy2T8rpM1Dc3yg6OLn5r7WFYLmSApHGV4dZEhZhDq2VwpXlzBTumcgG6KOdW10E8CXZShUvbKFrIVsyaiTiKnKhsv1rDeBOsi2vwTiXTcnMH8+DBb1GGTEKQ7DOZTXWebPZzzmmr3FwbFq/1pNUnVZJJ5DMl0aQaGQuUU7Q=
Date: Mon, 25 Oct 2021 14:58:56 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: David Woodhouse <dwmw2@infradead.org>
CC: Jason Andryuk <jandryuk@gmail.com>, <josef@oderland.se>,
	<boris.ostrovsky@oracle.com>, <helgaas@kernel.org>, <jgross@suse.com>,
	<linux-pci@vger.kernel.org>, <maz@kernel.org>, <tglx@linutronix.de>,
	<xen-devel@lists.xenproject.org>
Subject: Re: [PATCH] PCI/MSI: Fix masking MSI/MSI-X on Xen PV
Message-ID: <YXaqENqdjx0lJ+Fx@MacBook-Air-de-Roger.local>
References: <90277228-cf14-0cfa-c95e-d42e7d533353@oderland.se>
 <20211025012503.33172-1-jandryuk@gmail.com>
 <eb38c1d2707d03bf675d7b15f014cbe741de0998.camel@infradead.org>
 <YXaYe/RF6NWFKxGj@MacBook-Air-de-Roger.local>
 <72d763d055929b8c81f0c8deab14b33bd252c946.camel@infradead.org>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <72d763d055929b8c81f0c8deab14b33bd252c946.camel@infradead.org>
X-ClientProxiedBy: MR2P264CA0173.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501::12)
 To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 8f0d77db-ba27-454d-7db5-08d997b737a5
X-MS-TrafficTypeDiagnostic: DM6PR03MB3675:
X-Microsoft-Antispam-PRVS: <DM6PR03MB3675C7F0CB10528CB533D4778F839@DM6PR03MB3675.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: nCU3fhuoVvh+E1VtrL5opt3zvdy2Fc93eJqI0jE5nM6+EnR1AuhaK7MSFGyLz6Snsd64OgbH2KT9FoUUFV0SDzR4fG17VYp7Sy13Fucw1a2ZxhsAx5tvBPhjWWjVtgPzShng0TtIAWUbZks03+RAX1zgflCdWHIQ0+PAGQ9ANmBIdLYT6A1wkVnLl6g2VxbQ+xtVmV0qxL6aEZ0kcIsAasBcToJSzvykQii7uUJkim7FNCIEh0FVsVtNeO2snOrjR4iSowwRBaor/RWOjh/PseOEBXcrlxVzmA2YDWtyhxWcwJAkASa1bgDejAy9kFJb/i+SEnekCu9jBAyVsX3Qhz1O6KLV53Ae6Tk6MfkLJWQOZqIjDL4nqqIK/sTeHTdrHjgpPwkwkCLQgWgozi98XNL0M+zyXVl6dzXijz7JxMkFunDhUKUOnT6tVA+KAxc7LujNXbRnxWZTw95OIroO73HTbz+bain1YBUcV+dLSumh74yNyhBxwxvKldU+oCEU/CLU9PU1qjhKAH8HCh5Tz25lYvbDTlKOrMyP9qKfyyLg5qItkUWI53z9cb9uNneRy4ElWFXmXyGjiVSGw/kwiyX04oMEJ+V5UA5V7lEeWh2pWyrYS0p8nJluGmYzuIdR4wrXpqL14UYL1QCXDAijufujUY02iUsqt7tplVkBed4DgqIXs1EIYuilos2qR1IwMKqvuxRXmSFGAgTkMYDZeA==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(85182001)(186003)(6496006)(6666004)(82960400001)(508600001)(2906002)(86362001)(38100700002)(83380400001)(8936002)(66946007)(66476007)(66556008)(7416002)(8676002)(26005)(5660300002)(316002)(9686003)(4001150100001)(6916009)(6486002)(4326008)(956004)(67856001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RjQ0aytkN3NtTlpuMHBEWTFibFB3ak9xVUlDOHlzcHYwUTlUVmc1L1FTZlZG?=
 =?utf-8?B?eVRMY3FnQ0lnR01INkV5QWsyL1RTdkNSNzJScU9wRDE5ak1zelJxTmRpSTl0?=
 =?utf-8?B?OG1MRjcrWEQwMStCUzhrTWlhSUFvS0ptb1NLQnU1QWhkK1l5cDRrN2Y0UUIv?=
 =?utf-8?B?OW00aHYzWFJKajN1aEU5cU5zUk1mL1pNNUlDUEdLMXN4QVlsbHJQeFNwcXZB?=
 =?utf-8?B?bnB1dDBoeURlSzlNcnFtSkxzVkcvbFFuOThwV3EwUjZYc1V3cmd1TUR4UVlh?=
 =?utf-8?B?SlRIaXo0eDR4VkdhMG5MSXU4WkZGbHNLY3VwNDd5THBZS1ZLSHpCeE1SN0NI?=
 =?utf-8?B?V1YzVG9DYXNPTXhIV1d2aStzN0FKTUsyK3Vhdks0ajRIanQ4L2E5dmVFVUla?=
 =?utf-8?B?NUNxdkJyOHMzUUh6b3lHV0lDanpDOHB3d0Zlam1ZcUN6blhPNndCbVpOT2RK?=
 =?utf-8?B?Zy9KMGt1VDgzdCtKK05nbVBFMzRNeVExaWxRUGFpZ1VyYmVWT0lHTXNVK0N3?=
 =?utf-8?B?M0tZVWx3T1E1WXp2TEp6blBjOE94eG1RWnBqSVFVMk9XUG1xci9UREVtdXA5?=
 =?utf-8?B?UHhXdzFSc0FmNW9CUzlISHp4Q0hHWEZ5UkE0SmNkKzR3U0VLeDdxVjZjYktU?=
 =?utf-8?B?eFFPSGN1dUV5Z0FOZFRYaFVWbDhjNCs2QmFkWHlnTFd0dCtsL0RLZ3plWmJD?=
 =?utf-8?B?QXNPbDFsTEhzWkJRczBrQlpCbTUzR3N0NDMrbkI3MjlZT3JpbkpVUUtWcjQ4?=
 =?utf-8?B?bHJhNGZyd014Qmd0UnNjQ2VIc1FheDBJUi95QldyWllYVHNCeEoxa1BtdXRJ?=
 =?utf-8?B?UXhHeHNzSjFEWlUyK3Z4UWNJZkFFYWJOWUZTcExUdUJPd0hkQ01pNTFpZlVI?=
 =?utf-8?B?c1IxU2VGdzNMajVuVzNSalJ4aUpsZnVjd0V1VE1vZDFYQ2tlNmFkbERNZGI0?=
 =?utf-8?B?ZGpidVFaVW53UW9nVEdIRXJqRFM3c1dSSUdLTlNmYTZha1ZQdFY2OVFVNHVk?=
 =?utf-8?B?QUlqUzVxa2k1eUcxZkRxQXpRcTdLWWt5bHhuWllpUkIxM2JDWGQxUk9meWxT?=
 =?utf-8?B?YUMyQzA0OWVlMWVEOUpZVVJKbGZsd04vYnVWOFFQS2ppb1JKbitKQ1AvTFBO?=
 =?utf-8?B?bFpNbldGb2lDaDJnTGMrQU1Kc21iUk5zSzFDWjRsVEJIZVJNVGN2UE9rRlIz?=
 =?utf-8?B?MGduSXgra0I1aWxLRWc5Mlk3aDNuQWVJM2dkNlRncTkxek5aSmx5SWUxUmhu?=
 =?utf-8?B?czRDeFV6Sm9OZmVidkk1b3Y0d3Q0NUdBQ01lNVVlZEg1bTlYZ0J0cm5saGZs?=
 =?utf-8?B?TDUvYUk1cWNMUkpnQ05mRVZQSGpSWXdHOG90WmpjU0d1TXNscXJkSzZ6VjVP?=
 =?utf-8?B?blE5MnpiQ3c4bCtmNjQ0WWVnSG5JemVMMHZ4aVJ3TWZyMERXZzdvTEw2SGpE?=
 =?utf-8?B?THpkTy8yeStRQTdnanllUFdLYUtNQVNSM0E1dWdpclp2VEFLQTBQMmRPUDhM?=
 =?utf-8?B?RXkrTWVPMktycjA0SXFiUitoSjlJVGtXMjJrWVgwVk5FeThPWnBpeUpTZXVN?=
 =?utf-8?B?NkU0WkhSbjhHQUk0UWJOSTdwWEFDL1ZNVHlRYXRkOEk2cmp6cjVuU0RSUjB4?=
 =?utf-8?B?ZG5md1VHUUtoeFVXeVF0VUFmbktoekp5UmJ2ejF1bVQrQS94VjBxckJKbzRj?=
 =?utf-8?B?bVgxamRIdjMxQS9TWUZ5SW9jZFZOcXJEOEdCTXJrMGpYTW5UM2VmNmRLNFpq?=
 =?utf-8?B?OEJ5Z0FzeUgwR2lnWUo0eWVGZjAvMWoxMU1VZS9LZ2hqRjV3VVJBZjAzMkVl?=
 =?utf-8?B?TFRYMlg0TnNnd0ErQURCajdTTlVLdndXSEZacGxtL1MxMldXc1Y2cW9pVEkr?=
 =?utf-8?B?UUVVc3J5VDZqWmM3R1BJTnM1OEVtMFY2WG1ZN3NpcmNjQjUrS3BtUWozQUYw?=
 =?utf-8?B?TVd4enNOTVNEM2VmL2dVR09YTFkzbExFeDlLNGF5aE9kaW9YRkpZUUorbUZy?=
 =?utf-8?B?Sk9ycXZLMFdKcXNZNWx0cWYzb1lJWVJuTnhnSEcwelU3SDRPRTFOOFViQmhP?=
 =?utf-8?B?R1pwWEJXNnRmd1hKcDVzR29FTFAwTWVDMjV5Z3EyK0NhT20vUVJuaHRadlVG?=
 =?utf-8?B?Y1dBeXJCd05SL1VSZXNuWjJvZjIzVDlXMjJYRXNpQ2lJdFV6ZUN2MjFZMTMw?=
 =?utf-8?Q?tSxnq98UfvhIcuBjFh4Wa5Y=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 8f0d77db-ba27-454d-7db5-08d997b737a5
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2021 12:59:01.9949
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0ieeRC4EgEGJGDyA4R2IawlvL+OEvNlu/eiNKFLk7BeJ4R+aPx1Fd0b/YuFLjNo73EfhReWIi8D/QY72BLfx0Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB3675
X-OriginatorOrg: citrix.com

On Mon, Oct 25, 2021 at 12:53:31PM +0100, David Woodhouse wrote:
> On Mon, 2021-10-25 at 13:43 +0200, Roger Pau Monné wrote:
> > It's kind of optional for HVM guests, as it depends on
> > XENFEAT_hvm_pirqs, which sadly gets unconditionally set for HVM
> > guests, thus dropping any benefits from having hardware assisted APIC
> > virtualization or posted interrupts support.
> 
> Indeed. After implementing PIRQ support for Xen guests running under
> KVM, I spent a "happy" couple of days swearing at it because it
> actually *worked* if something would just *unmask* the f***ing MSI, but
> the guest inexplicably (to me) didn't do that.
> 
> Took me a while to work out that Xen itself is *snooping* on the MSI
> table writes even while they are *masked*, to capture the magic MSI
> message (with vector==0) which means it's actually a PIRQ# in the
> destination ID bits, and then magically unmask the MSI when the guest
> binds that PIRQ to an event channel.
> 
> I did not enjoy implementing that part.

I can see that. It's even better because none of this is actually
documented.

> FWIW the *guest* could potentlaly be smarter here and elect not to use
> PIRQs when hardware assisted vAPIC is present. Aren't there some bits
> in the CPUID that Xen advertises, which indicate that? 

Yes, it's in leaf 0x40000x04. FWIW, I would also be fine with removing
XENFEAT_hvm_pirqs, as I don't think diverging from the hardware
specifications gives us much benefit. We avoid a couple of vm exits
for sure, but the cost of having all those modifications in guest
OSes is not worth it.

Roger.


From xen-devel-bounces@lists.xenproject.org Mon Oct 25 13:03:08 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Oct 2021 13:03:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.215816.375195 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mezd5-0002JK-VA; Mon, 25 Oct 2021 13:03:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 215816.375195; Mon, 25 Oct 2021 13:03:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mezd5-0002JD-S8; Mon, 25 Oct 2021 13:03:07 +0000
Received: by outflank-mailman (input) for mailman id 215816;
 Mon, 25 Oct 2021 13:03:06 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=DEXr=PN=bombadil.srs.infradead.org=BATV+8af5701d0ad407599ae9+6637+infradead.org+dwmw2@srs-us1.protection.inumbo.net>)
 id 1mezd2-0002J7-3U
 for xen-devel@lists.xenproject.org; Mon, 25 Oct 2021 13:03:06 +0000
Received: from bombadil.infradead.org (unknown [2607:7c80:54:e::133])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id b71a908c-a57c-46ff-801b-c500269701c0;
 Mon, 25 Oct 2021 13:02:59 +0000 (UTC)
Received: from [2001:8b0:10b:1::3ae] (helo=u3832b3a9db3152.ant.amazon.com)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1mezcf-00GTx4-Tw; Mon, 25 Oct 2021 13:02:42 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b71a908c-a57c-46ff-801b-c500269701c0
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=MIME-Version:Content-Type:References:
	In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Sender:Reply-To:
	Content-Transfer-Encoding:Content-ID:Content-Description;
	bh=c8EMxo0D+O3WAka+vwBFAJeHYm1siAdmlyf4Bw+Pm/o=; b=vSObtoJz89BcMXvzqUC5mekD6o
	h7848MNe4YNpZHxiQrskZ7CLDyJioI5pfwiuLGeLMBDYGZTj7T3LqdUNB0w5Uk9Y21LURUxbvgNgF
	I/GnANMSErUaJamj9pQCF32g+OuWwQruRu6EbEFWIvF4J8FM6xZXL/q7COja0c46AO8O9BWdjQe4Q
	WEt6ZQOOJBm9Pkw6PiqpTCJRNgFaiREAsNgkD5umSqsJckc/l3mkVRMMi3VWWGGwe6M6yHk72VDMk
	JBUEcfRAOHB+Btp/t7pDRwJlvu0oyBwmlrcAShL9sT2LDT0v8SAuCm1IEBSndEzQdQlywn15nZlTj
	pfDKTaPg==;
Message-ID: <acaca10c50155b75c82c6370236231856b30ade4.camel@infradead.org>
Subject: Re: [PATCH] PCI/MSI: Fix masking MSI/MSI-X on Xen PV
From: David Woodhouse <dwmw2@infradead.org>
To: Roger Pau =?ISO-8859-1?Q?Monn=E9?= <roger.pau@citrix.com>
Cc: Jason Andryuk <jandryuk@gmail.com>, josef@oderland.se, 
	boris.ostrovsky@oracle.com, helgaas@kernel.org, jgross@suse.com, 
	linux-pci@vger.kernel.org, maz@kernel.org, tglx@linutronix.de, 
	xen-devel@lists.xenproject.org
Date: Mon, 25 Oct 2021 14:02:38 +0100
In-Reply-To: <YXaqENqdjx0lJ+Fx@MacBook-Air-de-Roger.local>
References: <90277228-cf14-0cfa-c95e-d42e7d533353@oderland.se>
	 <20211025012503.33172-1-jandryuk@gmail.com>
	 <eb38c1d2707d03bf675d7b15f014cbe741de0998.camel@infradead.org>
	 <YXaYe/RF6NWFKxGj@MacBook-Air-de-Roger.local>
	 <72d763d055929b8c81f0c8deab14b33bd252c946.camel@infradead.org>
	 <YXaqENqdjx0lJ+Fx@MacBook-Air-de-Roger.local>
Content-Type: multipart/signed; micalg="sha-256"; protocol="application/pkcs7-signature";
	boundary="=-V1kHLu/k0PYZMWhWaXbr"
User-Agent: Evolution 3.36.5-0ubuntu1 
MIME-Version: 1.0
X-SRS-Rewrite: SMTP reverse-path rewritten from <dwmw2@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html


--=-V1kHLu/k0PYZMWhWaXbr
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, 2021-10-25 at 14:58 +0200, Roger Pau Monn=C3=A9 wrote:
> On Mon, Oct 25, 2021 at 12:53:31PM +0100, David Woodhouse wrote:
> > On Mon, 2021-10-25 at 13:43 +0200, Roger Pau Monn=C3=A9 wrote:
> > > It's kind of optional for HVM guests, as it depends on
> > > XENFEAT_hvm_pirqs, which sadly gets unconditionally set for HVM
> > > guests, thus dropping any benefits from having hardware assisted APIC
> > > virtualization or posted interrupts support.
> >=20
> > Indeed. After implementing PIRQ support for Xen guests running under
> > KVM, I spent a "happy" couple of days swearing at it because it
> > actually *worked* if something would just *unmask* the f***ing MSI, but
> > the guest inexplicably (to me) didn't do that.
> >=20
> > Took me a while to work out that Xen itself is *snooping* on the MSI
> > table writes even while they are *masked*, to capture the magic MSI
> > message (with vector=3D=3D0) which means it's actually a PIRQ# in the
> > destination ID bits, and then magically unmask the MSI when the guest
> > binds that PIRQ to an event channel.
> >=20
> > I did not enjoy implementing that part.
>=20
> I can see that. It's even better because none of this is actually
> documented.

Indeed. I still haven't worked out if/how Xen actually *masks* the
corresponding MSI-X again. It can't do so when the evtchn is masked,
since that's just a bit in the shinfo page. So while the evtchn is
masked, the MSI can still be screaming into the void?

Perhaps it does so when the PIRQ is unbound from the evtchn?

> > FWIW the *guest* could potentlaly be smarter here and elect not to use
> > PIRQs when hardware assisted vAPIC is present. Aren't there some bits
> > in the CPUID that Xen advertises, which indicate that?=20
>=20
> Yes, it's in leaf 0x40000x04. FWIW, I would also be fine with removing
> XENFEAT_hvm_pirqs, as I don't think diverging from the hardware
> specifications gives us much benefit. We avoid a couple of vm exits
> for sure, but the cost of having all those modifications in guest
> OSes is not worth it.

These days with posted interrupts, it doesn't even save us any vmexits;
it's all that additional guest complexity just to give us *more*
vmexits than we would have had :)

--=-V1kHLu/k0PYZMWhWaXbr
Content-Type: application/pkcs7-signature; name="smime.p7s"
Content-Disposition: attachment; filename="smime.p7s"
Content-Transfer-Encoding: base64

MIAGCSqGSIb3DQEHAqCAMIACAQExDzANBglghkgBZQMEAgEFADCABgkqhkiG9w0BBwEAAKCCECow
ggUcMIIEBKADAgECAhEA4rtJSHkq7AnpxKUY8ZlYZjANBgkqhkiG9w0BAQsFADCBlzELMAkGA1UE
BhMCR0IxGzAZBgNVBAgTEkdyZWF0ZXIgTWFuY2hlc3RlcjEQMA4GA1UEBxMHU2FsZm9yZDEaMBgG
A1UEChMRQ09NT0RPIENBIExpbWl0ZWQxPTA7BgNVBAMTNENPTU9ETyBSU0EgQ2xpZW50IEF1dGhl
bnRpY2F0aW9uIGFuZCBTZWN1cmUgRW1haWwgQ0EwHhcNMTkwMTAyMDAwMDAwWhcNMjIwMTAxMjM1
OTU5WjAkMSIwIAYJKoZIhvcNAQkBFhNkd213MkBpbmZyYWRlYWQub3JnMIIBIjANBgkqhkiG9w0B
AQEFAAOCAQ8AMIIBCgKCAQEAsv3wObLTCbUA7GJqKj9vHGf+Fa+tpkO+ZRVve9EpNsMsfXhvFpb8
RgL8vD+L133wK6csYoDU7zKiAo92FMUWaY1Hy6HqvVr9oevfTV3xhB5rQO1RHJoAfkvhy+wpjo7Q
cXuzkOpibq2YurVStHAiGqAOMGMXhcVGqPuGhcVcVzVUjsvEzAV9Po9K2rpZ52FE4rDkpDK1pBK+
uOAyOkgIg/cD8Kugav5tyapydeWMZRJQH1vMQ6OVT24CyAn2yXm2NgTQMS1mpzStP2ioPtTnszIQ
Ih7ASVzhV6csHb8Yrkx8mgllOyrt9Y2kWRRJFm/FPRNEurOeNV6lnYAXOymVJwIDAQABo4IB0zCC
Ac8wHwYDVR0jBBgwFoAUgq9sjPjF/pZhfOgfPStxSF7Ei8AwHQYDVR0OBBYEFLfuNf820LvaT4AK
xrGK3EKx1DE7MA4GA1UdDwEB/wQEAwIFoDAMBgNVHRMBAf8EAjAAMB0GA1UdJQQWMBQGCCsGAQUF
BwMEBggrBgEFBQcDAjBGBgNVHSAEPzA9MDsGDCsGAQQBsjEBAgEDBTArMCkGCCsGAQUFBwIBFh1o
dHRwczovL3NlY3VyZS5jb21vZG8ubmV0L0NQUzBaBgNVHR8EUzBRME+gTaBLhklodHRwOi8vY3Js
LmNvbW9kb2NhLmNvbS9DT01PRE9SU0FDbGllbnRBdXRoZW50aWNhdGlvbmFuZFNlY3VyZUVtYWls
Q0EuY3JsMIGLBggrBgEFBQcBAQR/MH0wVQYIKwYBBQUHMAKGSWh0dHA6Ly9jcnQuY29tb2RvY2Eu
Y29tL0NPTU9ET1JTQUNsaWVudEF1dGhlbnRpY2F0aW9uYW5kU2VjdXJlRW1haWxDQS5jcnQwJAYI
KwYBBQUHMAGGGGh0dHA6Ly9vY3NwLmNvbW9kb2NhLmNvbTAeBgNVHREEFzAVgRNkd213MkBpbmZy
YWRlYWQub3JnMA0GCSqGSIb3DQEBCwUAA4IBAQALbSykFusvvVkSIWttcEeifOGGKs7Wx2f5f45b
nv2ghcxK5URjUvCnJhg+soxOMoQLG6+nbhzzb2rLTdRVGbvjZH0fOOzq0LShq0EXsqnJbbuwJhK+
PnBtqX5O23PMHutP1l88AtVN+Rb72oSvnD+dK6708JqqUx2MAFLMevrhJRXLjKb2Mm+/8XBpEw+B
7DisN4TMlLB/d55WnT9UPNHmQ+3KFL7QrTO8hYExkU849g58Dn3Nw3oCbMUgny81ocrLlB2Z5fFG
Qu1AdNiBA+kg/UxzyJZpFbKfCITd5yX49bOriL692aMVDyqUvh8fP+T99PqorH4cIJP6OxSTdxKM
MIIFHDCCBASgAwIBAgIRAOK7SUh5KuwJ6cSlGPGZWGYwDQYJKoZIhvcNAQELBQAwgZcxCzAJBgNV
BAYTAkdCMRswGQYDVQQIExJHcmVhdGVyIE1hbmNoZXN0ZXIxEDAOBgNVBAcTB1NhbGZvcmQxGjAY
BgNVBAoTEUNPTU9ETyBDQSBMaW1pdGVkMT0wOwYDVQQDEzRDT01PRE8gUlNBIENsaWVudCBBdXRo
ZW50aWNhdGlvbiBhbmQgU2VjdXJlIEVtYWlsIENBMB4XDTE5MDEwMjAwMDAwMFoXDTIyMDEwMTIz
NTk1OVowJDEiMCAGCSqGSIb3DQEJARYTZHdtdzJAaW5mcmFkZWFkLm9yZzCCASIwDQYJKoZIhvcN
AQEBBQADggEPADCCAQoCggEBALL98Dmy0wm1AOxiaio/bxxn/hWvraZDvmUVb3vRKTbDLH14bxaW
/EYC/Lw/i9d98CunLGKA1O8yogKPdhTFFmmNR8uh6r1a/aHr301d8YQea0DtURyaAH5L4cvsKY6O
0HF7s5DqYm6tmLq1UrRwIhqgDjBjF4XFRqj7hoXFXFc1VI7LxMwFfT6PStq6WedhROKw5KQytaQS
vrjgMjpICIP3A/CroGr+bcmqcnXljGUSUB9bzEOjlU9uAsgJ9sl5tjYE0DEtZqc0rT9oqD7U57My
ECIewElc4VenLB2/GK5MfJoJZTsq7fWNpFkUSRZvxT0TRLqznjVepZ2AFzsplScCAwEAAaOCAdMw
ggHPMB8GA1UdIwQYMBaAFIKvbIz4xf6WYXzoHz0rcUhexIvAMB0GA1UdDgQWBBS37jX/NtC72k+A
CsaxitxCsdQxOzAOBgNVHQ8BAf8EBAMCBaAwDAYDVR0TAQH/BAIwADAdBgNVHSUEFjAUBggrBgEF
BQcDBAYIKwYBBQUHAwIwRgYDVR0gBD8wPTA7BgwrBgEEAbIxAQIBAwUwKzApBggrBgEFBQcCARYd
aHR0cHM6Ly9zZWN1cmUuY29tb2RvLm5ldC9DUFMwWgYDVR0fBFMwUTBPoE2gS4ZJaHR0cDovL2Ny
bC5jb21vZG9jYS5jb20vQ09NT0RPUlNBQ2xpZW50QXV0aGVudGljYXRpb25hbmRTZWN1cmVFbWFp
bENBLmNybDCBiwYIKwYBBQUHAQEEfzB9MFUGCCsGAQUFBzAChklodHRwOi8vY3J0LmNvbW9kb2Nh
LmNvbS9DT01PRE9SU0FDbGllbnRBdXRoZW50aWNhdGlvbmFuZFNlY3VyZUVtYWlsQ0EuY3J0MCQG
CCsGAQUFBzABhhhodHRwOi8vb2NzcC5jb21vZG9jYS5jb20wHgYDVR0RBBcwFYETZHdtdzJAaW5m
cmFkZWFkLm9yZzANBgkqhkiG9w0BAQsFAAOCAQEAC20spBbrL71ZEiFrbXBHonzhhirO1sdn+X+O
W579oIXMSuVEY1LwpyYYPrKMTjKECxuvp24c829qy03UVRm742R9Hzjs6tC0oatBF7KpyW27sCYS
vj5wbal+TttzzB7rT9ZfPALVTfkW+9qEr5w/nSuu9PCaqlMdjABSzHr64SUVy4ym9jJvv/FwaRMP
gew4rDeEzJSwf3eeVp0/VDzR5kPtyhS+0K0zvIWBMZFPOPYOfA59zcN6AmzFIJ8vNaHKy5QdmeXx
RkLtQHTYgQPpIP1Mc8iWaRWynwiE3ecl+PWzq4i+vdmjFQ8qlL4fHz/k/fT6qKx+HCCT+jsUk3cS
jDCCBeYwggPOoAMCAQICEGqb4Tg7/ytrnwHV2binUlYwDQYJKoZIhvcNAQEMBQAwgYUxCzAJBgNV
BAYTAkdCMRswGQYDVQQIExJHcmVhdGVyIE1hbmNoZXN0ZXIxEDAOBgNVBAcTB1NhbGZvcmQxGjAY
BgNVBAoTEUNPTU9ETyBDQSBMaW1pdGVkMSswKQYDVQQDEyJDT01PRE8gUlNBIENlcnRpZmljYXRp
b24gQXV0aG9yaXR5MB4XDTEzMDExMDAwMDAwMFoXDTI4MDEwOTIzNTk1OVowgZcxCzAJBgNVBAYT
AkdCMRswGQYDVQQIExJHcmVhdGVyIE1hbmNoZXN0ZXIxEDAOBgNVBAcTB1NhbGZvcmQxGjAYBgNV
BAoTEUNPTU9ETyBDQSBMaW1pdGVkMT0wOwYDVQQDEzRDT01PRE8gUlNBIENsaWVudCBBdXRoZW50
aWNhdGlvbiBhbmQgU2VjdXJlIEVtYWlsIENBMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKC
AQEAvrOeV6wodnVAFsc4A5jTxhh2IVDzJXkLTLWg0X06WD6cpzEup/Y0dtmEatrQPTRI5Or1u6zf
+bGBSyD9aH95dDSmeny1nxdlYCeXIoymMv6pQHJGNcIDpFDIMypVpVSRsivlJTRENf+RKwrB6vcf
WlP8dSsE3Rfywq09N0ZfxcBa39V0wsGtkGWC+eQKiz4pBZYKjrc5NOpG9qrxpZxyb4o4yNNwTqza
aPpGRqXB7IMjtf7tTmU2jqPMLxFNe1VXj9XB1rHvbRikw8lBoNoSWY66nJN/VCJv5ym6Q0mdCbDK
CMPybTjoNCQuelc0IAaO4nLUXk0BOSxSxt8kCvsUtQIDAQABo4IBPDCCATgwHwYDVR0jBBgwFoAU
u69+Aj36pvE8hI6t7jiY7NkyMtQwHQYDVR0OBBYEFIKvbIz4xf6WYXzoHz0rcUhexIvAMA4GA1Ud
DwEB/wQEAwIBhjASBgNVHRMBAf8ECDAGAQH/AgEAMBEGA1UdIAQKMAgwBgYEVR0gADBMBgNVHR8E
RTBDMEGgP6A9hjtodHRwOi8vY3JsLmNvbW9kb2NhLmNvbS9DT01PRE9SU0FDZXJ0aWZpY2F0aW9u
QXV0aG9yaXR5LmNybDBxBggrBgEFBQcBAQRlMGMwOwYIKwYBBQUHMAKGL2h0dHA6Ly9jcnQuY29t
b2RvY2EuY29tL0NPTU9ET1JTQUFkZFRydXN0Q0EuY3J0MCQGCCsGAQUFBzABhhhodHRwOi8vb2Nz
cC5jb21vZG9jYS5jb20wDQYJKoZIhvcNAQEMBQADggIBAHhcsoEoNE887l9Wzp+XVuyPomsX9vP2
SQgG1NgvNc3fQP7TcePo7EIMERoh42awGGsma65u/ITse2hKZHzT0CBxhuhb6txM1n/y78e/4ZOs
0j8CGpfb+SJA3GaBQ+394k+z3ZByWPQedXLL1OdK8aRINTsjk/H5Ns77zwbjOKkDamxlpZ4TKSDM
KVmU/PUWNMKSTvtlenlxBhh7ETrN543j/Q6qqgCWgWuMAXijnRglp9fyadqGOncjZjaaSOGTTFB+
E2pvOUtY+hPebuPtTbq7vODqzCM6ryEhNhzf+enm0zlpXK7q332nXttNtjv7VFNYG+I31gnMrwfH
M5tdhYF/8v5UY5g2xANPECTQdu9vWPoqNSGDt87b3gXb1AiGGaI06vzgkejL580ul+9hz9D0S0U4
jkhJiA7EuTecP/CFtR72uYRBcunwwH3fciPjviDDAI9SnC/2aPY8ydehzuZutLbZdRJ5PDEJM/1t
yZR2niOYihZ+FCbtf3D9mB12D4ln9icgc7CwaxpNSCPt8i/GqK2HsOgkL3VYnwtx7cJUmpvVdZ4o
gnzgXtgtdk3ShrtOS1iAN2ZBXFiRmjVzmehoMof06r1xub+85hFQzVxZx5/bRaTKTlL8YXLI8nAb
R9HWdFqzcOoB/hxfEyIQpx9/s81rgzdEZOofSlZHynoSMYIDyjCCA8YCAQEwga0wgZcxCzAJBgNV
BAYTAkdCMRswGQYDVQQIExJHcmVhdGVyIE1hbmNoZXN0ZXIxEDAOBgNVBAcTB1NhbGZvcmQxGjAY
BgNVBAoTEUNPTU9ETyBDQSBMaW1pdGVkMT0wOwYDVQQDEzRDT01PRE8gUlNBIENsaWVudCBBdXRo
ZW50aWNhdGlvbiBhbmQgU2VjdXJlIEVtYWlsIENBAhEA4rtJSHkq7AnpxKUY8ZlYZjANBglghkgB
ZQMEAgEFAKCCAe0wGAYJKoZIhvcNAQkDMQsGCSqGSIb3DQEHATAcBgkqhkiG9w0BCQUxDxcNMjEx
MDI1MTMwMjM4WjAvBgkqhkiG9w0BCQQxIgQgwcYS7ZEvWujlXRlgpsmZFl95cMivIcpFYn9aUQgB
9Z0wgb4GCSsGAQQBgjcQBDGBsDCBrTCBlzELMAkGA1UEBhMCR0IxGzAZBgNVBAgTEkdyZWF0ZXIg
TWFuY2hlc3RlcjEQMA4GA1UEBxMHU2FsZm9yZDEaMBgGA1UEChMRQ09NT0RPIENBIExpbWl0ZWQx
PTA7BgNVBAMTNENPTU9ETyBSU0EgQ2xpZW50IEF1dGhlbnRpY2F0aW9uIGFuZCBTZWN1cmUgRW1h
aWwgQ0ECEQDiu0lIeSrsCenEpRjxmVhmMIHABgsqhkiG9w0BCRACCzGBsKCBrTCBlzELMAkGA1UE
BhMCR0IxGzAZBgNVBAgTEkdyZWF0ZXIgTWFuY2hlc3RlcjEQMA4GA1UEBxMHU2FsZm9yZDEaMBgG
A1UEChMRQ09NT0RPIENBIExpbWl0ZWQxPTA7BgNVBAMTNENPTU9ETyBSU0EgQ2xpZW50IEF1dGhl
bnRpY2F0aW9uIGFuZCBTZWN1cmUgRW1haWwgQ0ECEQDiu0lIeSrsCenEpRjxmVhmMA0GCSqGSIb3
DQEBAQUABIIBAAFH/ezTDAkRk3iSxoku56PXDAE3XsCZU6txNn5gvZQ6qd2jxCpwuSwUMwmmHqSS
aGTeNddLduCGderDSsYtqav8+4sVzOjwcB17DOwP2PKQ+uchRrlK242WJWpthjnezA80t+wDOKKp
yCxMXbp8IfzCJl9Sa4ctID+YQlTjHf6jlfADOoMgZf3VjreihxSfLpxT+Vxv2Y0fnYn/MHsXeuoq
Yoh6P0oa8nL6MB78c94Raj1uw8zL5rShB6g8sHr065dFrrXqvSU4C6+iGfhffNsYWhPP+ai6u9Em
zkfAa84CcIYgD1Q2uqjDPnLch2Nryd9pm1/fZEMZDRbDZXwqUv8AAAAAAAA=


--=-V1kHLu/k0PYZMWhWaXbr--



From xen-devel-bounces@lists.xenproject.org Mon Oct 25 13:15:16 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Oct 2021 13:15:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.215827.375212 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mezoj-0003rY-8e; Mon, 25 Oct 2021 13:15:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 215827.375212; Mon, 25 Oct 2021 13:15:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mezoj-0003rR-4f; Mon, 25 Oct 2021 13:15:09 +0000
Received: by outflank-mailman (input) for mailman id 215827;
 Mon, 25 Oct 2021 13:15:07 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=G2Ub=PN=citrix.com=roger.pau@srs-us1.protection.inumbo.net>)
 id 1mezoh-0003rL-6K
 for xen-devel@lists.xenproject.org; Mon, 25 Oct 2021 13:15:07 +0000
Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 9184c64c-3595-11ec-840f-12813bfff9fa;
 Mon, 25 Oct 2021 13:15:05 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9184c64c-3595-11ec-840f-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1635167705;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=6NN+HcK4pNW1+uu67L4LFJbJeM74ILo1Qa1fUmmi0MI=;
  b=e2G4MSUJ1bi8WnGKqzIlbgvYauQbulV6yRwfjrx5hxMOR6qSeeTN4lqA
   5E9ubrXHyAJ3BckwfelbIa3JQWq9zNDGlU4JKipKMocK7YctLQNFcXcxK
   BmscFEuej5qx8Kk9Dq8BDPrinRJSct1Qc3u1/RtDFzkAgugDSmftMAmFA
   0=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: TZGhpoVpHX+QUPvf4bjYRSd5GMitJBHpfyGyeCOOrzAIrgRHcwDWsEIwrZqV1gi2b3wtKF11cr
 KogPpn5KI66Ri5aTQejKSgCJoHAQz67Kyw/lyBAbMy/F3wZnCYqbEpbtHKie1WIR5BkW+vVvhb
 /odwa8Fi6EZtfoXc3j6dIVjGGEiA9cXW1RP9E40of26oEeCS+5r6XnyXaOAU0h0AikCeWaA9WY
 p7fs2wZuzr+buoKOAPrIi4N4XSBZ+EXX2BbtFhpSqv1z0wfTDjRYwxY+BrE8Kj1we6XG8VVWvH
 L1d2G/dEsPqT8hipyfIuhE7H
X-SBRS: 5.1
X-MesageID: 55969246
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:CIWwOqy6qVAMOpqbWZ96t+fTwCrEfRIJ4+MujC+fZmUNrF6WrkVRy
 WMcWm6Aa/mNYjTxKo8gPo/j9BgF6pDcyIJgSlNkqiAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx
 59DAjUVBJlsFhcwnvopW1TYhSEUOZugH9IQM8aZfHAuLeNYYH1500s6w7Rk2tcAbeWRWGthh
 /uj+6UzB3f9s9JEGjp8B3Wr8U4HUFza4Vv0j3RmDRx5lAa2e0o9VfrzEZqZPXrgKrS4K8bhL
 wr1IBNVyUuCl/slIovNfr8W6STmSJaKVeSFoiI+t6RPHnGuD8H9u0o2HKN0VKtZt9mGt/99x
 s9/np+ccysCE7PjuvYPXQdiNS4raMWq+JefSZS+mcmazkmAeHrw2fR+SkoxOOX0+M4uXzsIr
 6ZBbmlQMFbT3Ipaw5riIgVort4kI8TxepsWp1lrzC3DDOZgSpfGK0nPzYIFjWlh3JwQdRrYT
 /E6Vxc+fg//WkNGE2hIVpgXmdWajECqJlW0r3rK/PFqsgA/1jdZ2rX3LMDcfNDMQMxPh1uZv
 UrP5WG/CRYfXPSHwCeB2mKhgKnIhyyTcIAYGaC89/VqqEaO3WFVAxoTPXOhqPmkjgilWtRQK
 2Qd4C9opq83nGSpQcP6RAaQu2Ofs1gXXN84O+wl6imdx6zM+QGbC2MYCDlbZ7QOs8s7Ricj0
 FOTqNrvCSZyq72eSX+b9bC8oCu7PG4eKmpqTS0ZSQoI5fHzrYd1iQjAJv5zHajwgtDrFDXYx
 zGRsDN4l7gVldQM1aiw4RbAmT3EjpHPQhRvvl2Pdm2g5wJ9IoWiYuSA8kPH5PxNKIKYSFipv
 3UencWaqucUAvmlvTaRTeA6OaCm7veILhXRmVdqWZIm8lyF5XmneoxB5SBkE01gOM0EZDzBb
 VfavEVa45o7FHyuYKxsaoS9EfM23LPgHtToUPPTRtdWa503fwiClByCfmbJgTqryhJ11/hiZ
 9HLKq5AEEr2F4xIwDSsdcwe/YUH7Q0g6kHBV57l9TKohO/2iGGudZ8JN16Hb+Yc5ayCoRnI/
 9s3C/Zm2ymzQ8WlPXGJqd97wUQiaCFhX8iv+pM/mvure1I+QAkc5+ntLaTNkmCPt59ekfvU5
 TmDU0tcxUuXaZbveFjSNC4LhF8CW/9CQZMH0c4EYA7AN5sLO9/HAEIjm3wfJuFPyQCb5aQoJ
 8Tpgu3Zahi1dhzJ+i4Gcb72p5F4eRKgiGqmZnT+PWFnJ8QxH1STqrcImzcDEgFUXkJbUuNl+
 9WdOv7zG8JfF2yO8u6PMJpDMG9dTVBCwbkvDiMk0/FYeVn28ZgCFsACpqRfHi34Ej2anmHy/
 1/PWX8w/LCRy6dooIihrf3V9O+BTrohdne26kGGtN5awwGBpTH9qWKBOc7VFQ3guJTcofTyO
 74NlKqiYZXqXj9i6uJBLlqi9opnj/PHrL5G1AV0WnLNalWgELR7JXeam8JIs8VwKnVx4FTet
 pun9oYINLOXFtniFVJNdgMpYv7ajaMfmyXI7ORzK0L/vXcl8L2CWERUHh+NlC0Cc+clbNJ7m
 b8s6JwM9giyqhs2KdLa3CpawHuBcy4bWKI9u5BEXIKy0lg3yktPaID3AzPt5M3dcM1FN0Qne
 2fGhKfLi7lG6FDFdn4/SSrE0eZH3MxcsxFW1l4SYV+On4Od1PMw2RRQ9xUxTxhUkUobg74iZ
 DAzOhQsd6uU/jpuiMxSZEyWGllMVE+D50j861oVj2mFHUOmYXPAcT8mMuGX8UFHr28FJmpH/
 KuVwXrOWCrxeJ2jxTM7XENopqCxTdF18QGeysmrE97cQss/aDvhxKSveXAJu13sBsZo3B/Lo
 uxj/eBRb6znNHFP//1nWtfCjblAGgqZIGFiQO16+PJbFG7RTzi+xDySJh3jYchKPfHLrRe1B
 sEGyhijjPhiOPJidgwmOJM=
IronPort-HdrOrdr: A9a23:0n7zPaNFwM6DScBcTyX155DYdb4zR+YMi2TDiHofdfUFSKClfp
 6V8cjztSWUtN4QMEtQ/uxoHJPwO080lKQFmrX5WI3NYOCIghrLEGgP1/qG/9SkIVyCygc/79
 YfT0EdMqyIMbESt6+Ti2PZYrVQseVvsprY/ds2p00dMj2CAJsQiTuRZDzrdnGfE2J9dOYE/d
 enl4F6jgvlXU5SQtWwB3EDUeSGj9rXlKj+aRpDIxI88gGBgR6h9ba/SnGjr1ojegIK5Y1n3X
 nOkgT/6Knmm/anyiXE32uWy5hNgtPuxvZKGcTJoMkILTfHjBquee1aKve/lQFwhNvqxEchkd
 HKrRtlF8Nv60nJdmXwmhfp0xmI6kdZ11bSjXujxVfzq83wQzw3T+Bbg5hCTxff4008+Plhza
 NixQuixtRqJCKFuB64y8nDVhlsmEbxi2Eli/Qvg3tWVpZbQKNNrLYY4FheHP47bW3HAbgcYa
 lT5fznlbVrmQvwVQGagoAv+q3hYp0LJGbGfqBY0fbllgS/nxhCvjwlLYIk7zM9HakGOup5Dt
 L/Q9BVfYF1P78rhJ1GdZU8qOuMeyXwqEH3QSqvyWqOLtBzB5uKke+x3IkI
X-IronPort-AV: E=Sophos;i="5.87,180,1631592000"; 
   d="scan'208";a="55969246"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=eY/cjr+dMEpK50JGeBuM6LJ3uxiTCu4TD8KisEnr7tSf8pchGuhTh2oVD04G/1Rutxy1MS5xl5WzTDyhwL2OXk34/xvanVAnkTueAEZEzO46OtEAThOu98KDUqrOUxXDTfp9CJ5trSDOTIKpWQFpPk3tk7EvZdnBkRv5MqNg+ZKAaCXgAWFcM/kDNzOcOn87D/LD9Y0CNGjpzVPDdmc1wqvh8n3SAqXf12+bFf7BRiP9KH7NLqkTthSAccmdIbV4IA0ilq+n42A366BgeaWq0fI2ah5vvPtbUkQXdLuVxd7bpFny5CP9bunRh5xbLxutVw+eaBrc83j9s1weqogE9w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=FR/NR7Wlo246b1K1PEZZknQiaEr9mmqr/4Os4faUQh0=;
 b=kLUo6DyVuK2WRLWFRxGFs69uR3Lv1iGHpUhcRISLPSZN6afbD1QeJPCoHwzuVSHRrpQX0uH5RMpmPeTN8WlEqCDxkmzj5cusg+L8WvFPry7WfryjEXWsJGI+DRGY3Kpdq+/xf7yd4NAOxUwuGXZ75PfO0Pjv34dV/GwEvnKHMxHjGgU5JpAk0MqeQldSK+WFk5MjWtmvSuB8e3/0aflAPY4pWKJiYEy1/3WnjnkHEBS+KEcoOL8Zd8SDuEsv28q9pbT0d4Ol2dEjqVDAE3eGsIZJbYigMP99NMz2Zccxvs2zND6aB7X1FNb3gCTy1I4aPR6U0wtK2hnT6PzpQ2r2uA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=FR/NR7Wlo246b1K1PEZZknQiaEr9mmqr/4Os4faUQh0=;
 b=T5mXoyUCpFxsCqxZLXhMzWFlRmy06WxRMlJUeBLYYTWw2JR6cF6AxfNZV0M6BWM9GafkNMkTIJCSHNhv1JkdAQ9bdZrctHDUyOdKOOk2nR7/tNwn846WgvbMuu/5nMXAdlJPBaWjmoDZD2yFrFCPOW1wZTKHe3Nmt1/QWJXjhbE=
Date: Mon, 25 Oct 2021 15:14:53 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Oleksandr Andrushchenko <andr2000@gmail.com>
CC: <xen-devel@lists.xenproject.org>, <julien@xen.org>,
	<sstabellini@kernel.org>, <oleksandr_tyshchenko@epam.com>,
	<volodymyr_babchuk@epam.com>, <Artem_Mygaiev@epam.com>, <jbeulich@suse.com>,
	<andrew.cooper3@citrix.com>, <george.dunlap@citrix.com>, <paul@xen.org>,
	<bertrand.marquis@arm.com>, <rahul.singh@arm.com>, Oleksandr Andrushchenko
	<oleksandr_andrushchenko@epam.com>, Ian Jackson <iwj@xenproject.org>, Juergen
 Gross <jgross@suse.com>
Subject: Re: [PATCH v5 06/10] libxl: Allow removing PCI devices for all types
 of domains
Message-ID: <YXatzfvSLZc9g6BV@MacBook-Air-de-Roger.local>
References: <20211008055535.337436-1-andr2000@gmail.com>
 <20211008055535.337436-7-andr2000@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20211008055535.337436-7-andr2000@gmail.com>
X-ClientProxiedBy: MR2P264CA0096.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:500:32::36) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 94117386-1471-4e27-405d-08d997b97254
X-MS-TrafficTypeDiagnostic: DM6PR03MB4138:
X-Microsoft-Antispam-PRVS: <DM6PR03MB41382C6CCF55D492ECC88DE68F839@DM6PR03MB4138.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:3826;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: vwA6pKni9WHowaob+y+38X9V5jOT62sgkPrFAL1soauq8jAge4Sh89EGMFEp+uqBxuNOQDf1AdvCZeyTvM61qcw1sUdm2td1UAav+wgr89+GXXY5oCg2fpZxBiMFSnwZQgMjrSkLR4JOzqLodSx28QgMvsLaCL7IepEr9al23tUQSADjtkkdYCP3Xs3iZQHLNoYDvRmbNarVEHNnd9jn71dS+m89tgX9L8XlMoGrZ+0IPTq7u1V5nBUSac6J3cWFNfGmmr+1g0WeKCXMcuFZrTc9peuzJwR2NMywwE72X8z/e+s/qZFcD5pXovDPMjkqQA3VPngNoAH4IoJOpHttSp8Q+BQAL/K8Cm3GXac2MpyvxBLh3POM65aq01FIoy4fO0kQAXyiJUjgODeFhXvt5tMNm0OLYZ0mvDL5mPf4/BC5KKUcga7wg1E0HS7E1NuCSnt/2LbdYWyQrgFSR+ZQlkPhRaA8uRK3odQ003wtqcHWpXmkko+Z1fJPCiJ46/ySvxikdFxqc2+zJ5cAktPq6bztdlGim9kjmMkC8XvUljQj4u8ksZdxoEZ2phqzOwTy1CpDZK2PVRE/VT07+vaVFSvmL4ditnVEzfMJxFVzc/6ao4goPl9lcdvQTwoAcXfLGeOP0ZrPrPYF4sHbVAIZgg==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(26005)(186003)(9686003)(6486002)(316002)(86362001)(956004)(5660300002)(66946007)(54906003)(7416002)(2906002)(6916009)(6496006)(85182001)(508600001)(4326008)(66556008)(82960400001)(6666004)(4744005)(38100700002)(66476007)(8676002)(8936002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YUZrbmhYNk9FcFI3bTlKU0Eyd0o1WTRJV04xMTBkSTVoaC81L2J4TnpNdFpv?=
 =?utf-8?B?NEdiblpoeXZWOWFuOVY4UXI4Uk9rWklsWWtLcUtheUdqSjE0b2xPR2ErQlI5?=
 =?utf-8?B?Q2JSdVJWQTRwelg3YXh5N1QrUGF0OWR1SUJrdzJsNlNDalNhakdvS3NrYjBQ?=
 =?utf-8?B?VzRNZ1ROdytpZzcwYjg1M3VkdnEzOXprTXhBanROdE1nWk0xcDFpd1c3czh3?=
 =?utf-8?B?cEF2N0NqaGNzc05CSFhCanR6bitDMllta1ZpU3JEcGV5STlQdkVPeEx5c01q?=
 =?utf-8?B?Z0dIaWJOUGdHY1crRXp2dXlSWGhObnFYNUk1WXVtbXg3eUVvSER5c1kwOE5C?=
 =?utf-8?B?Tm9xSSswK0Vhbmk4dk5YMWlaaHo0UGp6YVRwWnFQZnkvdGd0RWRnWDlXVVhu?=
 =?utf-8?B?TEQzcVdQZmFaUEl6Z1d4ck9UYjdzeVB5dmxiVkkrK0hBMkVPQjdRbFJFcUhB?=
 =?utf-8?B?cDlyMVFpaG9JaUJOU00ydXR6dUcyWXIxbmE2bkFrUGp1cG83K0RuaEhyclh4?=
 =?utf-8?B?REp4SWszdEhMTk5MNERRUFpBUEg0TGIrcHVpYjBpTmk3aHlMQUx5NGd2MGNV?=
 =?utf-8?B?dm5QS0VTcDlycE5yS0FsMURqUkZNNHZtM2U1aEtvUWpHaFpFRGpGMi9oVWlw?=
 =?utf-8?B?NVZ2MkZ3eGlFTUFKWEJHU0dOT0dYbjRROU1UUENmell1VnJCMGpwUHlLemdz?=
 =?utf-8?B?MzBkT0RaY3RRUWtwb3ZXVFJNT0tSMm50NFNyb1VqMHpBOVkzR0xrSVhrNncz?=
 =?utf-8?B?enRjVmJqWnlJTW1YUytBWG9aSTk5bnIySlVrN1NwcmRXSDZYUmNCK1Z6bUpK?=
 =?utf-8?B?OHU0T29PbEVWRzRoVDdhT0QySlZmMi8xZ0FhcTFOZFhsMWR3aHhudTRIOWpK?=
 =?utf-8?B?eWFOZlBEZEFpZDZmWTc2WUc2cldmeCtnbG42WkthS2VzZFpUY0Y5emZkVkJC?=
 =?utf-8?B?dm1wS0h1S1BkQkl1R2dDNW5SclJRT3VMUTd5QjdZYzRMblgyTTlHTWd1bEtQ?=
 =?utf-8?B?QW5NQWtCclFJeEwrQkM0QkhiS3UrMXZkZi9zcE9ZelpDdGZBcjUrTEZQbWhj?=
 =?utf-8?B?U1BsYW1MZlZmQkx0QU1FSTBOQ25pSkdOT2drMXhPZzlmRXRjWlc3b3h3aDRS?=
 =?utf-8?B?Vms2bml3eml6R3JqKzZndFNZUnpRTm5NOHVoTWErcWg3VUlsZG1LN1FSdktR?=
 =?utf-8?B?NVZrbDlXRkw0dGJlVWhTMjN4aE14VW1mcGFyNjA2TCs0aWlTeSs2SzFFemUr?=
 =?utf-8?B?OWkwMlY3eERhRXZNdWdRdEE5TDh1M0MrVUE1eGs0a29UZW14alF2RXJNVHN0?=
 =?utf-8?B?Q2hvMGk0ZnlHUm9qb3BsbTlNRlBYdFQ1VWg4Z2tWTFZwODJSSjMzVVVxb3px?=
 =?utf-8?B?VWJLb2JPSE9DWmdGMnNMRU1tYzJYS2hlOGxKYVJDNU10bnFOWXdTdURBb1g3?=
 =?utf-8?B?dmcveGszZ1RMc0NDd0dXaEkrNmp1Z3QxcXVSb0ZFRU51R3NMUmxXaDN3UTcx?=
 =?utf-8?B?WElTMWNVdmF6bzl4MGdNcXh3Vnd5em9rY1UwVkZxMmdCQ1VWUndMUE4yUHZh?=
 =?utf-8?B?ZUp5OGMxVVRyV0xITFhkT1c3UUxHNXZmZFhhVzZjcUEzNFNDVmNSUTdlcEUr?=
 =?utf-8?B?WWZrRVlub2ZNelNzTVZ0d3JJa3FPQ3NvdXRsVkp3dU81SnJzMFZuQXpTWUx1?=
 =?utf-8?B?ZmNFeVg4eGgyYmNNK2VCaDBMbm1wQmkrNmp0ZHlhYjdSNFNJV0QwY3FxZFFn?=
 =?utf-8?B?MzVoWDY2VUJsWFJKM3JaZGl6d1c4T3RoazFLVXQ5QXVYMUtwRk9yWnBMb0dV?=
 =?utf-8?B?RlRvYVZVQTZ3R2FqNlowOTN2NEVPVi9EQ29UcE03L1AyZkIwUkt6MmpKekQ2?=
 =?utf-8?B?ZUt5TmgrM1BrYnR6VnRlSW9UMXFzVEtWTWdzVnZ2SXFLSG40dU5TemNEN0lN?=
 =?utf-8?B?QmNrUVAzSUVzcFc3THJLVEh4VzdHWFVBZXh6enFKRDUwSG1mQ3N1ejI5dUh0?=
 =?utf-8?B?azFxU2R5enlXN0hkSzR5L1lUZklPTXhIaXdiVldybVR6RUhiTERiQ1RqZGJW?=
 =?utf-8?B?MzdEaSs5NXhvU0RiSUFxZWlaZi9aTDROd2xlSnVtRTVjM2lVR2FPWXRkMGtk?=
 =?utf-8?B?SVNObmFGalVUUWczY2Z4MklmdTY2eXB2UFpRZlNYTFlnV01ZOXJxZ092SFRp?=
 =?utf-8?Q?cP6ob4G5R62mcDlfrMaW4Z4=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 94117386-1471-4e27-405d-08d997b97254
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2021 13:14:59.3360
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1v0dY1/a/h4otxbGd1++wh2bn8QdM5tecppDJhGCcldTQ2PK8jY7xIJpoqyHC62eHKqIW5JohJvtdDZDrE86+A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4138
X-OriginatorOrg: citrix.com

On Fri, Oct 08, 2021 at 08:55:31AM +0300, Oleksandr Andrushchenko wrote:
> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> 
> The PCI device remove path may now be used by PVH on ARM, so the
> assert is no longer valid.

I think ti might be worth saying that this is a preparatory change and
that PCI passthrough is not yet functional on Arm after it.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Mon Oct 25 13:17:53 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Oct 2021 13:17:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.215834.375223 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mezrM-0004Vh-MQ; Mon, 25 Oct 2021 13:17:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 215834.375223; Mon, 25 Oct 2021 13:17:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mezrM-0004Va-Ib; Mon, 25 Oct 2021 13:17:52 +0000
Received: by outflank-mailman (input) for mailman id 215834;
 Mon, 25 Oct 2021 13:17:50 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=1v/+=PN=epam.com=prvs=0932af52eb=oleksandr_andrushchenko@srs-us1.protection.inumbo.net>)
 id 1mezrK-0004VR-Jl
 for xen-devel@lists.xenproject.org; Mon, 25 Oct 2021 13:17:50 +0000
Received: from mx0b-0039f301.pphosted.com (unknown [148.163.137.242])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id f32f8986-3595-11ec-840f-12813bfff9fa;
 Mon, 25 Oct 2021 13:17:48 +0000 (UTC)
Received: from pps.filterd (m0174681.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 19PCYLbP013884; 
 Mon, 25 Oct 2021 13:17:46 GMT
Received: from eur01-db5-obe.outbound.protection.outlook.com
 (mail-db5eur01lp2051.outbound.protection.outlook.com [104.47.2.51])
 by mx0b-0039f301.pphosted.com with ESMTP id 3bwrmkhafs-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Mon, 25 Oct 2021 13:17:46 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by AM0PR03MB3715.eurprd03.prod.outlook.com (2603:10a6:208:43::31)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.18; Mon, 25 Oct
 2021 13:17:42 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::c038:e032:595a:651]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::c038:e032:595a:651%8]) with mapi id 15.20.4628.020; Mon, 25 Oct 2021
 13:17:41 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f32f8986-3595-11ec-840f-12813bfff9fa
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=c1FPXr8/dqMjQK+lxMvAr1PxcjqA2L96w5fVuBnwpWelQLybrLDOsZgkViZEr+umoIM/YmrU9UDY+9leyEggwSWCL1o911GYzpGEI2auYskcjTjSQMiHltPhP7h2kj5whBjUToeEQkhmVkPIzY+49qiCLBg31mMKuy8UOAyMccaY8siYj2//Upi/xMJxYwJZyTTUMpJQixUZyfCqHCIdrrWASw6cPRNU1F71KEv/9ZeuUpXekoNmLBNwvzSjundSVKVR3G0xLlACqTiO1itYC2wQ98uTAW97N+ozxfXtWpBGrBWHZgJ5IzdDb6CKMtEdI7qySKmmbHeIACVWck7BkA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=iqzGS1SaGtRcOEmrAj2q8wCwvZocm2Vum1lyjOsPydo=;
 b=nz44YzJbYj25cOhFtxN87aKmDU8Ku8RJDlte8+6O3pnkIhiykunDk/hfOKyZpwdd110Kdw8477XAU6eYndDgpdmr9PuqO1JpxP4IUeoeYhp6Ra/MHBaWXZUY+3WoXEvcyOR17VoshovMbHKzcrlYNi89xUEZ5r/QnbMnQ7/W4exozPKxu7PzKQN+rhIq9XD2qv4qXyEbwe2rOB0zbN/rbSO449TD9/Bo4a5DMxOFdDpmIz16CxAHsR4q4YrXoksFZB0e2XkNxb3H3Y5FoHnghUVBTkIGYaFpQxJ7t403tOqLQiB4G+Qpn9QsLEATyjcVVMKFaQkOD1Se14S5hvrnqw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=iqzGS1SaGtRcOEmrAj2q8wCwvZocm2Vum1lyjOsPydo=;
 b=4z5M4PZ6hN+FqkaU9ynVb0bLSLt0l3ZXqrnjLl+2ILMbfgF2ZU90yyTnAM52kScayVWchMIiLbou2SUPIlbXExUnoOGyc+dAwQNYFzt5kUyEg4QD+XCWG+sqgkGI9Xonvi2bAS+tsNiEeUSo9lWoUMqbsBHdwv4/gGP8NQzcv1Ql8gzAz1gCBWYiZILbQvxI2KMJ7cFDxPKdfN0bJiFD869XShdt4eZ3YNylR3Vj7OyjNJbt/G5aLcyDMajDga1OYHdF7HUjHcmz82npkVSwvqfcdk+U/TMjLlqD2BqJgRvheMWwr2Epn0fpW7wCpICVrofn+Utg7+MfOgI+ffwxGA==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org"
	<sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "jbeulich@suse.com" <jbeulich@suse.com>,
        "andrew.cooper3@citrix.com"
	<andrew.cooper3@citrix.com>,
        "george.dunlap@citrix.com"
	<george.dunlap@citrix.com>,
        "paul@xen.org" <paul@xen.org>,
        Bertrand Marquis
	<bertrand.marquis@arm.com>,
        Rahul Singh <rahul.singh@arm.com>, Ian Jackson
	<iwj@xenproject.org>,
        Juergen Gross <jgross@suse.com>,
        Oleksandr
 Andrushchenko <Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH v5 06/10] libxl: Allow removing PCI devices for all types
 of domains
Thread-Topic: [PATCH v5 06/10] libxl: Allow removing PCI devices for all types
 of domains
Thread-Index: AQHXvAknnKigXkenfkWfROoBKCqE16vjzIWAgAAAyAA=
Date: Mon, 25 Oct 2021 13:17:41 +0000
Message-ID: <d6f4f406-698c-deae-93a2-08ec383994ed@epam.com>
References: <20211008055535.337436-1-andr2000@gmail.com>
 <20211008055535.337436-7-andr2000@gmail.com>
 <YXatzfvSLZc9g6BV@MacBook-Air-de-Roger.local>
In-Reply-To: <YXatzfvSLZc9g6BV@MacBook-Air-de-Roger.local>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: e2c0fbed-1599-438e-a2d0-08d997b9d350
x-ms-traffictypediagnostic: AM0PR03MB3715:
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <AM0PR03MB37156EA3A2E2455AC1508664E7839@AM0PR03MB3715.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:4714;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 ADQk4mCEbWlEsO3ZEwWNmBBo8v7rixOm+V8oqW5ye6UgkKcCmsGSxRSybNVplEI859a+SlQksqaGaEgRT8h8Dd2NvQ/GICUYcR2j0nwfd8F68/DMIEXeBZOS3PD/4HpV3EyMA1EkApC0nEcHt/91yIKKWXP016zFQU4bF+JUSOSrz109T1SC1SWkwPR6qbUSrXhHriC/tNfXYoLQ6XHTd3p0SHbYfeJo8oz+d2jAe+pBg7yoLEZJ73tkxMo8tynE4XVOAbNjXpcUh9XcvXMQxfhjDFXWpRXELpRtFYZL/vahOiJS46TpcP8hmL+7ntk5EpGDj940uXq9bVagtjr8PHJwR6SFd8fegYCLCvZ19h2S0eOCxKvjPzCAPE2f6rSDC44NW5sIbCZ62bmoNsSN13hdF2doh3lnJ/Bzz1nox4sQVm+UyntB9cWi5awm18Ln/om8PXOunot/lzuzBJchL3TZrFN4QjM7fHsqmqyId3DRi9ykPQnyEhcAT6NjiaoUY5RRUWZn8qR17CIAX+xUe/4cqiTBKS9efbh2gxY1MATjVpBKHNlJonEUE+INeGWljKlxdp8ximUw6IHLKXe9n/1uQez5qNX8TqbEU5LJgzUpccD1mjaoBeA0GuMXvOC2cUHLFCyF++Z3iR7/j80Wn/3/hLEPjVWTKBqjbhlMRzzoj8703rmKqZ0Z367Bx2HBcvAgmAZEvxmpqpzQiZ9eI6eZgNGkcTYhIziTG98gUNHxi7wweM3SYzNo4f14KCjD
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(71200400001)(26005)(508600001)(5660300002)(8676002)(53546011)(6486002)(186003)(6506007)(2906002)(2616005)(7416002)(107886003)(6512007)(8936002)(4744005)(66476007)(54906003)(316002)(122000001)(31686004)(38070700005)(6916009)(64756008)(66556008)(66946007)(66446008)(38100700002)(31696002)(36756003)(91956017)(76116006)(4326008)(86362001)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?MUYwRGJpUTl4OWhCbVJkMllKcVRQdnhYdFZRTVZ2eEkrTFFqOGw4Z3dtNmRE?=
 =?utf-8?B?NHU1aXIxQ0xPdHdwUHFQcFlJR3JHT3dDaEVVcWdJVmhSYTQ1TlcwdFhjNGg2?=
 =?utf-8?B?M3psdll4dEYrcWFHMXV6Y0lFY2F4dWJ4eVNvdXdnWFZWZmpydzRSNENiY0Rp?=
 =?utf-8?B?V3VxT2ZsQWMzTzFGaDVVSmF1QjZVNDZMdFltajB2bjVUQ29JaDlpN3JLQmZH?=
 =?utf-8?B?eHI1ZHk1cS9TV0t4ejBrS1VNR2FXeDYxNGZwalZxVmtrdXNtWmpsSXdHa3dK?=
 =?utf-8?B?WjJ1NlRLZ3Z4emtDVVZnTzhwM3NzQ0lDRGRvN2NVWE5TRDFMYllLSHBBUDJP?=
 =?utf-8?B?RzdSYzdWQStmU044L2FYMExXUCtoMEpuVGlyQTJyZzJ1N09mdVovNEZLK29L?=
 =?utf-8?B?UER2VnJxb3FZZkREclA5SzZ0blJUQ25wdTdrM2toQWd0SVBQWVVob3RNaGEy?=
 =?utf-8?B?eXZ5dERReVpUMHpETzdaUWNScmo3OVJJU0wvZU9QaGJ4d1gwRUhMdnRGNzIr?=
 =?utf-8?B?bnhMSm9lSk13NWtBS2UvZDRsdU9kRFZMNEN0QVdQTTdaQzk5Si91TE1lbFdV?=
 =?utf-8?B?YUo4YlY3NXdhclpMNHNDNmE3MXpzSUFUb2pmK0ZxdU1vc0tKSEU2dEtVQS9a?=
 =?utf-8?B?azFONnlMOG9tcWtwMnkxU1BlU0VaczhSZEJaWGNnWitzckQrdFd4RHBROU1B?=
 =?utf-8?B?NGdqOERnTWMwRDhkY210QXlPUThXNDhjN1NvS01LazRkTnNObjIvZmlMc3RB?=
 =?utf-8?B?RUJvcmZaOGVEdEdaYzIzTXFNclhQbHh3UlY5RmV6OHFkNVlhMnY0WW9sZmpC?=
 =?utf-8?B?aGhreWJVOXUzSElaSFZXaWZJS1NGUDc1NnpqcHdaZVRwQmNCanVIZ0o4cXlI?=
 =?utf-8?B?dDQ1bTc2eDdSRUQ4M3liRmNiUy9Pa05lTURnajVKL2wxZmp5S1ZSTW5FVUk1?=
 =?utf-8?B?WGsxTW80WVh4RGVUVmw0ZmlXUDYrVlprZUcvTlVBckN3NUVZYnNyc1k3cnpn?=
 =?utf-8?B?QTNvSWtYUE5nQ3FrNmN1eHF3MUNId2R6TUZ1MEt6WVhsaGpDdmE5aFRVeDBs?=
 =?utf-8?B?dzgwWThlNUZqV254QWs1N3VaNk9TajJlZmJXcmQ4dU5hdlluelBqOVF0Q2w5?=
 =?utf-8?B?NktxTUJtVmw2N0xDZjZTOHUwT3QvMDl4TmpucWVKd0svTkZQWlZ3Nm5Lemtj?=
 =?utf-8?B?YzVmNnNCMkh4aU5DNjZOa1AyYzlFYTRMYkxBQ3hLbDJPWmRWdDI5dm1mTFQ2?=
 =?utf-8?B?L293alBuakNnalBVYmZ6RXBSdXZCR0VwQW9rWnR6R2FhRjN6N09vT0s3UXRG?=
 =?utf-8?B?UGZydE42VFVIaE8wLzNuYnFIWlpLY085Z2JGeU92dHdLR2lVYm1SQ3FaRFFa?=
 =?utf-8?B?Y1dXdDVCQmxzNHBVSXdOYUJGa0dnU2d3T1lsTXhqWjUyaW5ncnBUY0dkMmZR?=
 =?utf-8?B?Y21NY3NHL1pPY1A0cFo1MU8wKzU1bllPREFHQWxGM2FyZGFWdFJTMktRWkJ0?=
 =?utf-8?B?VXV5T3E3RUlCdnV4WTltSGJPVEtDZlBBZ3c0djVrYml3b0tJWDk3Mkt2Q2Z5?=
 =?utf-8?B?WGY2MzVQSUFVdkNzZlpWKzJFQnA3Z0I3cW10R0pJMmovc3M4UHJBWFozdWNu?=
 =?utf-8?B?ZVJFY2Z3WHRDVVB3SHUxRUIrbHN0WmlnVHVKRDU1ZjRUY2ZkYXluYTlTcXZO?=
 =?utf-8?B?UDlTbGVpWkFVN3ZMVHEzZTdwbnNvT0NTcTdMN1VKNXRrYVdSUTA4c2Uzankv?=
 =?utf-8?B?dzhoMUFaS3J1OUI5QktSRzJnRWtxMit3RDlGS0YxdWVlbFJkVnVtVmRUdEhi?=
 =?utf-8?B?NmtSd0V2cG4zNWZvY1JEWmNpVkk4THcyTFJ2VHRlL3hlcjE4cUY1bGZCQnZj?=
 =?utf-8?B?Zk9QSjR4OW5SWnNEVzU1VmgvR0MyN2xPSmtIT0FrQU1aYm9uTDhxNGFSUFlk?=
 =?utf-8?B?VElVUURBb3pNNFkyTnMyZEhUd3lnR2FHc0VlbnRLQU9RZnhqS3VMRTRWZENF?=
 =?utf-8?B?ZU0vVENCVEZFaHp4VENJcWxWS3pUQ1BaUHdsaEhTcGZzeXJ2OW51ZEtqVTZO?=
 =?utf-8?B?cjhsUS9YMkFZclU4TGROQ1FYRkxvaGx4aEYzTk1SV0x2S1BYcXRRU1FXNFFz?=
 =?utf-8?B?V1Fpd2FyNU9VNU9pelhvcDVNNy83Wk9vbXJFNjB2NFNrRFI4cTZDVnhjclVt?=
 =?utf-8?B?dTZhK095NjhQZ00xd09JSTQwOWUrR3lBRm5ZalNjY2lMMzNhOHVLQzMwUmRl?=
 =?utf-8?B?cUtmREpVQ1B5dTBkaFJCLzhpeThodzdJRS9tK2hBWURPdUhZWWtoMmlmVlNO?=
 =?utf-8?B?UWZBbVVkWDB6R09heVBvT2RpblAxbzBkR0sxQlZJSXIrNVhHYndsZz09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <900A2F9CDA580C43A4309987185A39E6@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e2c0fbed-1599-438e-a2d0-08d997b9d350
X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Oct 2021 13:17:41.7605
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: rEc8EEkCmIWzEyx+FWzwWdBkRghMq3UWyYvh6x69KZ4DxwtvtVzyYy1r6reX9T98d+Aa7YC+cH3OT2EF/KdXA2Rj3tZsIr7NdmnVBy61pmjCkPQjIdIdeDJ8rZ1hU0aA
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR03MB3715
X-Proofpoint-GUID: 3KTYIkw00oOPb-ZzwuHwl2iD1gacpApa
X-Proofpoint-ORIG-GUID: 3KTYIkw00oOPb-ZzwuHwl2iD1gacpApa
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475
 definitions=2021-10-25_05,2021-10-25_02,2020-04-07_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 clxscore=1015
 mlxscore=0 malwarescore=0 mlxlogscore=697 impostorscore=0 phishscore=0
 adultscore=0 lowpriorityscore=0 suspectscore=0 priorityscore=1501
 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2109230001 definitions=main-2110250082

SGksIFJvZ2VyIQ0KDQpPbiAyNS4xMC4yMSAxNjoxNCwgUm9nZXIgUGF1IE1vbm7DqSB3cm90ZToN
Cj4gT24gRnJpLCBPY3QgMDgsIDIwMjEgYXQgMDg6NTU6MzFBTSArMDMwMCwgT2xla3NhbmRyIEFu
ZHJ1c2hjaGVua28gd3JvdGU6DQo+PiBGcm9tOiBPbGVrc2FuZHIgQW5kcnVzaGNoZW5rbyA8b2xl
a3NhbmRyX2FuZHJ1c2hjaGVua29AZXBhbS5jb20+DQo+Pg0KPj4gVGhlIFBDSSBkZXZpY2UgcmVt
b3ZlIHBhdGggbWF5IG5vdyBiZSB1c2VkIGJ5IFBWSCBvbiBBUk0sIHNvIHRoZQ0KPj4gYXNzZXJ0
IGlzIG5vIGxvbmdlciB2YWxpZC4NCj4gSSB0aGluayB0aSBtaWdodCBiZSB3b3J0aCBzYXlpbmcg
dGhhdCB0aGlzIGlzIGEgcHJlcGFyYXRvcnkgY2hhbmdlIGFuZA0KPiB0aGF0IFBDSSBwYXNzdGhy
b3VnaCBpcyBub3QgeWV0IGZ1bmN0aW9uYWwgb24gQXJtIGFmdGVyIGl0Lg0KVW5mb3J0dW5hdGVs
eSB0aGlzIGNoYW5nZSBoYXMgYWxyZWFkeSBsYW5kZWQuDQo+DQo+IFRoYW5rcywgUm9nZXIuDQpU
aGFuayB5b3UsDQpPbGVrc2FuZHI=


From xen-devel-bounces@lists.xenproject.org Mon Oct 25 13:22:47 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Oct 2021 13:22:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.215842.375234 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mezw3-0005sx-AF; Mon, 25 Oct 2021 13:22:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 215842.375234; Mon, 25 Oct 2021 13:22:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mezw3-0005sq-5m; Mon, 25 Oct 2021 13:22:43 +0000
Received: by outflank-mailman (input) for mailman id 215842;
 Mon, 25 Oct 2021 13:22:42 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=G2Ub=PN=citrix.com=roger.pau@srs-us1.protection.inumbo.net>)
 id 1mezw2-0005sk-BO
 for xen-devel@lists.xenproject.org; Mon, 25 Oct 2021 13:22:42 +0000
Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id a0dde3c0-3596-11ec-840f-12813bfff9fa;
 Mon, 25 Oct 2021 13:22:40 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a0dde3c0-3596-11ec-840f-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1635168160;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=0dYutoA2H+Szw7GBOYvwjpwZNMRltC5hDnDEAM9Z5pk=;
  b=gdLNR2AKLq4/eYCRBDnWGLZVRQTpK2rfUWYbhXWsdtDh/p6XoqV+cbjW
   nf1vuGvuOWnnaL+JWWMs1VP8tkt11b85FdeOcPLRNMO3EX/MJU828UIC3
   5JXm20FjF4g546zuOt+pUrCJXkubtMmnoaqxOJ0pWm+8It+gMZ0UBdvzx
   o=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: CxEpbkzsiDagcuYOyAGPVFBeZAtQZUSU9sR9cMD5gQ0tc7IoWdlspxmfiJSCNi0/jSUYehCPr6
 G2XnzlN2093Ux3h0UeznxQymfPUeAER8UA1l0i524Iy4Inz5h8ojEHHrLUmIFVvgN65I8PIXnF
 OzDEGTVxBGx3eb0Sep7hFow+M9mRlf/XJ/NnFjJTWJqHjFV4/d/LX7C4dij3MztCmxYaO8H5SL
 Wc2v8HDSIaM6m2E6CZ/nUda3Owbai5Z//RfEiPLxpq6Kb+dZ8rVbkHWkl4rXTfW7xHRgj9X9My
 7xt1L9njHxdywoGojKCC1IRu
X-SBRS: 5.1
X-MesageID: 56375137
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:xMIyDKoQUeN27lYZw1DnZGJBQ3VeBmL9YxIvgKrLsJaIsI4StFCzt
 garIBmFaK2ONGD9Lop2ad/joUIAsZXRmtEwSwJp/31jEigWoJuZCYyVIHmrMnLJJKUvbq7GA
 +byyDXkBJppJpMJjk71atANlZT4vE2xbuKU5NTsY0idfic5Dnd+4f5fs7Rh2Ncx2YLkW1rlV
 e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL
 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9
 DlCnYW6cFk4ZIOLos8QUitfNT9ELa9AprCSdBBTseTLp6HHW37lwvEoB0AqJ4wIvO1wBAmi9
 9RBdmpLNErawbvrnvTrEYGAhex6RCXvFJkYtXx6iynQEN4tQIzZQrWM7thdtNs1rp0QRqmDP
 pFGAdZpRBHPcx9GEH0HNJ0njvWsgCH9YxxGuGvA8MLb5ECMlVcsgdABKuH9cNGQWd9cmEreo
 2vc5nn4GTkTLtnZwj2Amlq0j/LLtTP2XsQVDrLQ3vxgjUCXx2cTIAYLTlb9qv684makUtJCL
 woP+ywhrYA77kntRd74NzW6r2SDpQU0QMdLHqsx7wTl4qvL4S6JC24cVDlDZdc68sgsSlQC0
 VuEnMjgAzB1h7STRWiA7befrT60Oi89IHcLYGkPSg5ty9v+pIA+iDrfQ9AlF7S65vXlFDe1z
 z2UoSwWg7QIkdVNx6i95UrAgT+nut7OVAFdzgzRUnj/tlshTIGgbo2sr1Pc6J5oN52FR1OMu
 HwFncm27+0UC5yJ0iuXT40lNau16vOyFSzTiF9iAbEs7z2ovXWkeOh4/jZ6I0t4N9ceTjXga
 kTTpAB56YdaOT2haqofS4W1BscxxK7sD+P5R+vUZdpDZJt2XAKf9SQobkmVt10Bi2B1z/t5Y
 83CN5/xUzBKUsyL0QZaWc8E24Z113oQgln4SJHJyDK566qcYiCaHOJt3ES1Usg166aNoQPw+
 tlZNteXxxg3bNASchU74qZIcghUdSlT6YTe7pUNLLbac1UO9HQJUqeJmdscl5pZc7O5fwsi1
 kq2XVNE0xLBjHnDJBTihptLOe63A8gXQZ7WO0UR0beUN5oLPN7HAEQ3LcJfkVwbGAtLlqYcc
 hX9U5/casmjsxyek9jnUbHzrZZ5aDOgjh+UMiyubVAXJsA7GlWRooW1JlO1pEHi6xZbU+Nk8
 9VMMSuAGfI+q/lKVp6KOJpDMXvo5RDxZ96er2OXe4IOKS0AAaBhKjDrj+9fHi3/AU6r+9du7
 C7PWU1wjbCU++cdqYCV7YjZ/9bBO7YvRSJyQjiEhYtawAGHpwJPN6cbC73WFd0cPUupkJifi
 RJ9lqCsbqZfxw0U4uKR0d9DlMoD2jcmnJcDpixMF3TXdVW7TLRmJ3iNx85UsaNRgLRevGOLt
 oinoLG24J2FZ5HoFkA/Pg0gYrjR3P0YgGCKv/80PF/79Gl8+7/eCRdeOByFiSp8KrppMdx6n
 bd96ZBOswHv2AA3NtumjzxP8zjeJHI3TKh65IoRB5Xmi1R3xwgaM4DcECL//LqGd85IbhsxO
 jaRiaeb3+Zcy0POfmAdD3/I2eYB150CtAoTlA0JJkiTm8qDjfgyhUUD/TMyRwVT7xNGz+MsZ
 TQ7axwrff2Dpm46itJCUmagHxB6KCeYokGhmUEUkGD5TlWzUjCfJmMKJuvQrlsS9HhRf2YH8
 ejAmnrlSzvjYOr4wjA2BRx+s/XmQNF8ql/ClcSgE5jXFpU2e2O40KqnZG5OoBr7G8IhwkbAo
 LAyrup3bKT6Mw8WorE6VNbGhehBFkjcKTwQW+xl8YMIAXrYKWO71jW5Ikysft9Aeq7R+kiiB
 s0yfs9CWnxSDspVQuz30ULUH4JJoQ==
IronPort-HdrOrdr: A9a23:t5ckBqCSzfGlguXlHemo55DYdb4zR+YMi2TDsHoBLiC9E/bo8/
 xG+c5x6faaslossR0b9uxoW5PhfZq/z/BICOAqVN/JMTUO01HIEKhSqafk3j38C2nf24dmpM
 JdmnFFeb7N5I5B/KTH3DU=
X-IronPort-AV: E=Sophos;i="5.87,180,1631592000"; 
   d="scan'208";a="56375137"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=IJ40aC11ENc7AltmFdumDt0RYoet+EUfZ8ExjRd1ro7XPk4c/qQl2fI6tQv371Xtt0Kw4+RaIcAytP1UL0g/1IBkr7Zz9mMIaQ9Ks+FZPDS2yUC2Vh4HLpWzpBtEDgB6SD1ESQ4KBBt+2UO2ze1c173PKI9DcV/Ik7UuxLJd8yhdEqR+CYnP5PsMAdB74myw179Q0Dqerxnx6plWV51EXdHey7Or0PQtzCUuPdCtuTz3ddOKRut5xf0HsbTwtHo3eZKw1Ah3hMx4g8fHmLnEYCryRGi0s0lwMq1mtDVW24tZ7bsBKTkwjaFJQxMyJaxc4okCLbqW9WAvWS56mPWjrw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=z3XmvPIVlrJ7wzpYkZsw+kaaK2vyAPZ04wfI0gd/SsM=;
 b=Sjhgqcyit3P3bOV8Pylb1OSjl8nZ7g58xkFUO5zONXAoqoRzjWxFnFUl0KKqAped0TombCb8BXuslJGHiCpDX9QROOiRqEYSuBodcrlqOeP5BBqmWS8Njxv5A6CPs0wfE+5vGkP12TqX/6Z6Yh+KdTsUi7OhwsBRSYWe4EmX5qfj3cC5wBpUO5paSlAY1gGOEG1pPGYHN1vYcIDbdwFS0xckZXfn44bKbfxlbAI9EE7/1GG1218VmX6VdsxXYxW7yyos+ctoWAhoLhny/WUS127mLBCpRUa1V0VjRlMLlR8bqtySlpYx9VOI5HO5QA6lCL62nHCHL+Np7OfQRNjOUg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=z3XmvPIVlrJ7wzpYkZsw+kaaK2vyAPZ04wfI0gd/SsM=;
 b=evyJc3XCnUBjgDI6XGA86Ito+HRtpfQg0grc3R2lmE27m4E7bcFNVNnSbprW8GmeFJaKssJtUlmBnJt0zght20AR6pDy6Ur3HmQCh8cKEs63xsnD0YRWXJUsYg+nQ5hO1UrnLTUpqYAIeHdTjmrpFDPjqeIe1BhA4OSDcYgKd0c=
Date: Mon, 25 Oct 2021 15:22:31 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Oleksandr Andrushchenko <andr2000@gmail.com>
CC: <xen-devel@lists.xenproject.org>, <julien@xen.org>,
	<sstabellini@kernel.org>, <oleksandr_tyshchenko@epam.com>,
	<volodymyr_babchuk@epam.com>, <Artem_Mygaiev@epam.com>, <jbeulich@suse.com>,
	<andrew.cooper3@citrix.com>, <george.dunlap@citrix.com>, <paul@xen.org>,
	<bertrand.marquis@arm.com>, <rahul.singh@arm.com>, Oleksandr Andrushchenko
	<oleksandr_andrushchenko@epam.com>, Ian Jackson <iwj@xenproject.org>,
	"Juergen Gross" <jgross@suse.com>
Subject: Re: [PATCH v5 07/10] libxl: Only map legacy PCI IRQs if they are
 supported
Message-ID: <YXavl0e0zainVKT9@MacBook-Air-de-Roger.local>
References: <20211008055535.337436-1-andr2000@gmail.com>
 <20211008055535.337436-8-andr2000@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20211008055535.337436-8-andr2000@gmail.com>
X-ClientProxiedBy: MR2P264CA0191.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501::30)
 To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: b58c8d80-820d-42e3-891a-08d997ba8200
X-MS-TrafficTypeDiagnostic: DM5PR03MB2491:
X-Microsoft-Antispam-PRVS: <DM5PR03MB24912E7EE3BBDC1192D86E9E8F839@DM5PR03MB2491.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: Cm4k3ad2N/lyQUwFZ27ERtIoAd2HTWoDc+Aku3SEqC8XGwTM7zQFND5b1AVNYbYnMW2GZ3cpVNk/mzzP0YEL+nFBZt48POkQeS8edoBRcP7extLPD96TGX7QqPpCktWoqH5Nh+dEioRluWp1J6Z2wx2qNF3BfXOsEnLtMrPpUc99W3Rv033T0ExDi0omZLFgXCy7muXghYOMkw3apUB/Y1VlO/XegJszbsIdKVBc1iUjZmjY+DkVOmuYvj8ziXQpHbn4MF0eeA9GaJa0vvpm3ED0sIKYtYX44jUZmqM+jx9BFtxVF2607leZ3prrMy3ZVqxfdty6Ce7j4xPxkqLD5UMlSA1B3lGeN5uQiIkfQLmQ2GWJN5/Km0/SV3uK71KBwS9A9n/dk8/oKziECANs8nsNemw/KwOzrHsPaUt9ZTNgNZt5qknByUgE/hiDyHubdnIf9dfOUqOO/UnecEfMMkqzY0Yfl4R5G39qgh92ylW/KuUWX5dHyPDxfiNSPFcUFTmLi3qCyzBkpHsU2YWJLxBR2MZ9uOhBAzaYAOIn5IaDr9/F7hZW5Vl0aicjOOzjxvS0yHWRwSf1eEiz6T0Xio8lVGI3AqprNND9DCMbmBs4MhYEPPrnkUh/mVsyRFY7bEMF1Gd4ejIL/b2On8TXXw==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(8936002)(82960400001)(2906002)(7416002)(6486002)(8676002)(6666004)(5660300002)(4326008)(54906003)(508600001)(956004)(6496006)(66556008)(66946007)(66476007)(26005)(186003)(38100700002)(85182001)(316002)(86362001)(6916009)(9686003);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cVduN3FUV2pISkh4MU8wYTRidFFPbFh6Q3kwWlJQeDNxYzhyWktUejBielpp?=
 =?utf-8?B?WTFLa0VNbXFHeDJ0RUpMMzV4S0JEYUxDd0RIUUJHaUNCZzdUcm5BWEhwMU1O?=
 =?utf-8?B?VlZQcVpuU0taNTg4ZEdQa3dNcEZqRHI0N0RBZjRXMkNEdkdONzlxQWdxb0pn?=
 =?utf-8?B?dU5iOGNMcHRkSGFzUzBNK21ncjBTR3cxcnFDL0FuYWgyNUplUnFRWW9IY3R1?=
 =?utf-8?B?Qkx4VmpRVTNBUFlnOGVEVmJvNk8wNlhUYjFsTkxxWEhOeFI0a21ibUc3RlNW?=
 =?utf-8?B?S3lwaFlvY1pKVkFMaE1SQ0JsZVRYZmFOWmwwaEhVcmp4SXlFaC9UZWswL1Vr?=
 =?utf-8?B?bHI3ZnF5VzFaRGNnQ2VFa0w2Mi9TRkxjcnNQMmFKK1oxNTVsR3h5Tzcxb1pG?=
 =?utf-8?B?elFSMWI2V2IwQ0NobFU1T2dLcmNtdVRUbllJWXI1RWlFdXNaNVJBSzJsU2tN?=
 =?utf-8?B?Y0E3a3BLem9nUkE5UU1uM1djMjhpOXpvTkFSditHM0JxWmF6Y0w2M1V3NVNI?=
 =?utf-8?B?d0ZESmduWDlRNkJDZ0RMRmxWd3BVUkZGLy9QZmc4OEQxc1lZTERYb1VzTjUw?=
 =?utf-8?B?bTJZdkFseUVQS2l0UUFQUVNCdFB3SFRjLzVvT0NaRUdaYTlwbDY5NVNTNHhj?=
 =?utf-8?B?VkJjOEJuVHhjNG5LcStPUTNnWXB3NVdITExxRGJibmMxUkR5bnoxZnpSTlNx?=
 =?utf-8?B?VVdLYktuZDRWWnRyaGRiZVFWNjAwalJOVXZzUmFqUjhaVXg0TEhhTUpJMEx2?=
 =?utf-8?B?bGdjeEFrRGZGVTc5OTYvTTNDQ3p6K2dEdnZTK1hQNVZmUS9GVU45Vi9rcGN5?=
 =?utf-8?B?R20vNENSR0pHNFk0ZHBKVHJTOUxLRit6QTNnUlpQQ0RPN25WaThOOG8wR0w3?=
 =?utf-8?B?Mys5YXlFcDBvWDRuak9qSTRvTDhiVHVFa2RYOW90NVo1SmJJOEVKQ1JtcnNT?=
 =?utf-8?B?Y2EvOVArRXZieGFCaG5OUVZ0REh5SVEyMU01SUpubTIvazlsbFNwek9qYmZz?=
 =?utf-8?B?SFFxU0dGT3JZbThRM2w2dXZZMzdMZFRuSjdNZzZVaFdGZ201YTBpdkZrUnBU?=
 =?utf-8?B?TklOL1Y0aEE5cHZtV1NDQ2FCVmdGVVhWVWhwdWg4TDJySVpLQUdGNXRWK3NG?=
 =?utf-8?B?Y2pZQzRHbmVGNHRYV09nbzVvSTZDVDA5S0k3V2NQWklEM1YzSTNyQ3F5OVJO?=
 =?utf-8?B?dG1POVptaEhFMkUvdC9EZSs2M2UvR1NXTlFQb1dQR3RoUlpubUxUUG5DWVFV?=
 =?utf-8?B?QVlwU1FHdENKbHRreVFUU0ZuRldLenFMazd4VVVNamt2QlA3NlIwaW9jaFlp?=
 =?utf-8?B?U0EwaVl4MldJMUxXMWRtcnlnN1p2aXNRQWlJQ1UybHdReFhFdEkrZkN0cUxL?=
 =?utf-8?B?dG9uYVJiMjJsRVdzVmNNVlVxRyszWkJ0cXl6M0U2MEgxbHlGQWJKMUZzelJ2?=
 =?utf-8?B?TzE1QlRLcVhsRmJKekZ0VnVJS0psZ1dnbkpsVlpWN3F6VmhITC9oRnJpWEhV?=
 =?utf-8?B?aTYvaFhGNEEyRzAzZHhsZ21WTmVtL2lvRGVOcGc4bmdVMzc3aFFDa2FSODh0?=
 =?utf-8?B?cktDd1I5VTFOUURpQ1pMcldkRlhvSWx1NzdEUHBTajNWcUttZERvRlRrRjNs?=
 =?utf-8?B?azllYzJYN1BQU0N3SXVQOXhrSERNU2VhOEgzWnArSWNqMU5jMWtVRjlTTnhM?=
 =?utf-8?B?WU9LSmJoRkxrUHo3RGkyNVFwUUFKQkRsbXVHbit1emU5WXluVnRKM1diZnRS?=
 =?utf-8?B?bDdiNDBsZnMrajEwN1ZaQzhkcS9iMHVZa1NtSDBPbFIxRXFjL3JGa0l0U0FQ?=
 =?utf-8?B?d2czMngrc0taZXR5WlU0d2IzL09HRnNTOUNPNjZoZ1I3Z0Z2NzRvK1VLSC9S?=
 =?utf-8?B?TW90ckY3TS9mZXozVlA0ZVJBOG9qOHYyQlFncEJrblg2ZGlndkFyWUk5MlA2?=
 =?utf-8?B?QS90QmVMWUxnTkJaM2lZVExLSHJ5aTdEeUlBNW9NR1NOQm9qUnl2Vmhidnk0?=
 =?utf-8?B?YVUzZVBhZSthVC84Sm9yaERsV2IyTnZKSWVQUEJrTnJPZENSM3ZGRHk3Ky9L?=
 =?utf-8?B?aU5XMXFSM3YycWk0SFdPZDBTbkhnTEorUG5CajRiL1NFek5qR2F2SEhYL2Yy?=
 =?utf-8?B?ZWEwMk1FME9TdS9BbGVIKzg3bkdKNW43Y1VrcTc3LzRCOFV4ZitKT3FvY1NH?=
 =?utf-8?Q?n7hqjxOmRAsPkCVwWX4+Njo=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: b58c8d80-820d-42e3-891a-08d997ba8200
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2021 13:22:35.1415
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /UtYaTJ8hzEYvJ/7NApWDShraLVkickEmaYhYipDd8zGdkuHRvMsmEiJJ+i3oNTP5V0EipNIgHJdQYht/S9SsQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB2491
X-OriginatorOrg: citrix.com

On Fri, Oct 08, 2021 at 08:55:32AM +0300, Oleksandr Andrushchenko wrote:
> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> 
> Arm's PCI passthrough implementation doesn't support legacy interrupts,
> but MSI/MSI-X. This can be the case for other platforms too.
> For that reason introduce a new CONFIG_PCI_SUPP_LEGACY_IRQ and add
> it to the CFLAGS and compile the relevant code in the toolstack only if
> applicable.
> 
> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
> Reviewed-by: Rahul Singh <rahul.singh@arm.com>
> Tested-by: Rahul Singh <rahul.singh@arm.com>
> ---
> Cc: Ian Jackson <iwj@xenproject.org>
> Cc: Juergen Gross <jgross@suse.com>
> 
> Since v1:
>  - Minimized #idefery by introducing pci_supp_legacy_irq function
>    for relevant checks
> ---
>  tools/libs/light/Makefile    |  4 ++++
>  tools/libs/light/libxl_pci.c | 13 +++++++++++++
>  2 files changed, 17 insertions(+)
> 
> diff --git a/tools/libs/light/Makefile b/tools/libs/light/Makefile
> index 7d8c51d49242..bd3f6be2a183 100644
> --- a/tools/libs/light/Makefile
> +++ b/tools/libs/light/Makefile
> @@ -46,6 +46,10 @@ CFLAGS += -Wno-format-zero-length -Wmissing-declarations \
>  	-Wno-declaration-after-statement -Wformat-nonliteral
>  CFLAGS += -I.
>  
> +ifeq ($(CONFIG_X86),y)
> +CFLAGS += -DCONFIG_PCI_SUPP_LEGACY_IRQ
> +endif

TBH, since CONFIG_PCI_SUPP_LEGACY_IRQ is used in a single place in the
source I would consider just using CONFIG_X86, as I think it would be
clear enough that some arches support legacy interrupt while others
don't. Not sure it's worth going through the obfuscation of defining a
separate one.

> +
>  SRCS-$(CONFIG_X86) += libxl_cpuid.c
>  SRCS-$(CONFIG_X86) += libxl_x86.c
>  SRCS-$(CONFIG_X86) += libxl_psr.c
> diff --git a/tools/libs/light/libxl_pci.c b/tools/libs/light/libxl_pci.c
> index 59f3686fc85e..4c2d7aeefbb2 100644
> --- a/tools/libs/light/libxl_pci.c
> +++ b/tools/libs/light/libxl_pci.c
> @@ -1364,6 +1364,15 @@ static void pci_add_timeout(libxl__egc *egc, libxl__ev_time *ev,
>      pci_add_dm_done(egc, pas, rc);
>  }
>  
> +static bool pci_supp_legacy_irq(void)

A naming more inline with the PCI specification (since we insisted on
using ECAM instead of MCFG) would be intx, ie: pci_supports_intx.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Mon Oct 25 13:27:01 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Oct 2021 13:27:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.215851.375244 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mf00B-0006bH-Uk; Mon, 25 Oct 2021 13:26:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 215851.375244; Mon, 25 Oct 2021 13:26:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mf00B-0006bA-RX; Mon, 25 Oct 2021 13:26:59 +0000
Received: by outflank-mailman (input) for mailman id 215851;
 Mon, 25 Oct 2021 13:26:58 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mf00A-0006b0-Iw; Mon, 25 Oct 2021 13:26:58 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mf00A-0005kQ-Do; Mon, 25 Oct 2021 13:26:58 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mf00A-0003Bt-1u; Mon, 25 Oct 2021 13:26:58 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mf00A-0008OD-1P; Mon, 25 Oct 2021 13:26:58 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=Gmvl6jilaC/+bUa6RoW7Pr9aEXeePogfQL7lrmH7Ie0=; b=pfF2cHQ/iNBKGOVx77WDORotph
	Ftuwm/vi07+oP6LKAJ8PeS7plwYE43q5H5pAyT9CnX0zyiEF+UdFyw4d2HYl2Z8VIV1hIp2Da6igh
	GE5jgxF8mzPf7jo5MiSNnN1ib9tmx7AJNLXo2KvinE5B/Kvd9+6ayylQvWmD1rCdzMeU=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165852-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 165852: regressions - FAIL
X-Osstest-Failures:
    libvirt:build-armhf-libvirt:libvirt-build:fail:regression
    libvirt:build-amd64-libvirt:libvirt-build:fail:regression
    libvirt:build-i386-libvirt:libvirt-build:fail:regression
    libvirt:build-arm64-libvirt:libvirt-build:fail:regression
    libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    libvirt=945942ebba943e6addd6c8163d6e38a4a7df7b8f
X-Osstest-Versions-That:
    libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 25 Oct 2021 13:26:58 +0000

flight 165852 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165852/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-armhf-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-amd64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-i386-libvirt            6 libvirt-build            fail REGR. vs. 151777
 build-arm64-libvirt           6 libvirt-build            fail REGR. vs. 151777

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-libvirt-vhd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a

version targeted for testing:
 libvirt              945942ebba943e6addd6c8163d6e38a4a7df7b8f
baseline version:
 libvirt              2c846fa6bcc11929c9fb857a22430fb9945654ad

Last test of basis   151777  2020-07-10 04:19:19 Z  472 days
Failing since        151818  2020-07-11 04:18:52 Z  471 days  457 attempts
Testing same since   165803  2021-10-23 04:19:02 Z    2 days    3 attempts

------------------------------------------------------------
People who touched revisions under test:
    Adolfo Jayme Barrientos <fitoschido@gmail.com>
  Aleksandr Alekseev <alexander.alekseev@virtuozzo.com>
  Aleksei Zakharov <zaharov@selectel.ru>
  Andika Triwidada <andika@gmail.com>
  Andrea Bolognani <abologna@redhat.com>
  Ani Sinha <ani@anisinha.ca>
  Balázs Meskó <meskobalazs@mailbox.org>
  Barrett Schonefeld <bschoney@utexas.edu>
  Bastian Germann <bastiangermann@fishpost.de>
  Bastien Orivel <bastien.orivel@diateam.net>
  BiaoXiang Ye <yebiaoxiang@huawei.com>
  Bihong Yu <yubihong@huawei.com>
  Binfeng Wu <wubinfeng@huawei.com>
  Bjoern Walk <bwalk@linux.ibm.com>
  Boris Fiuczynski <fiuczy@linux.ibm.com>
  Brian Turek <brian.turek@gmail.com>
  Bruno Haible <bruno@clisp.org>
  Chris Mayo <aklhfex@gmail.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Ehrhardt <christian.ehrhardt@canonical.com>
  Christian Kirbach <christian.kirbach@gmail.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Cole Robinson <crobinso@redhat.com>
  Collin Walling <walling@linux.ibm.com>
  Cornelia Huck <cohuck@redhat.com>
  Cédric Bosdonnat <cbosdonnat@suse.com>
  Côme Borsoi <fedora@borsoi.fr>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniel Letai <dani@letai.org.il>
  Daniel P. Berrange <berrange@redhat.com>
  Daniel P. Berrangé <berrange@redhat.com>
  Didik Supriadi <didiksupriadi41@gmail.com>
  dinglimin <dinglimin@cmss.chinamobile.com>
  Dmitrii Shcherbakov <dmitrii.shcherbakov@canonical.com>
  Dmytro Linkin <dlinkin@nvidia.com>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Eric Farman <farman@linux.ibm.com>
  Erik Skultety <eskultet@redhat.com>
  Fabian Affolter <mail@fabian-affolter.ch>
  Fabian Freyer <fabian.freyer@physik.tu-berlin.de>
  Fabiano Fidêncio <fabiano@fidencio.org>
  Fangge Jin <fjin@redhat.com>
  Farhan Ali <alifm@linux.ibm.com>
  Fedora Weblate Translation <i18n@lists.fedoraproject.org>
  Gavi Teitz <gavi@nvidia.com>
  gongwei <gongwei@smartx.com>
  Guoyi Tu<tu.guoyi@h3c.com>
  Göran Uddeborg <goeran@uddeborg.se>
  Halil Pasic <pasic@linux.ibm.com>
  Han Han <hhan@redhat.com>
  Hao Wang <wanghao232@huawei.com>
  Hela Basa <r45xveza@pm.me>
  Helmut Grohne <helmut@subdivi.de>
  Hiroki Narukawa <hnarukaw@yahoo-corp.jp>
  Ian Wienand <iwienand@redhat.com>
  Jakob Meng <jakobmeng@web.de>
  Jamie Strandboge <jamie@canonical.com>
  Jamie Strandboge <jamie@ubuntu.com>
  Jan Kuparinen <copper_fin@hotmail.com>
  jason lee <ppark5237@gmail.com>
  Jean-Baptiste Holcroft <jean-baptiste@holcroft.fr>
  Jia Zhou <zhou.jia2@zte.com.cn>
  Jianan Gao <jgao@redhat.com>
  Jim Fehlig <jfehlig@suse.com>
  Jin Yan <jinyan12@huawei.com>
  Jinsheng Zhang <zhangjl02@inspur.com>
  Jiri Denemark <jdenemar@redhat.com>
  John Ferlan <jferlan@redhat.com>
  Jonathan Watt <jwatt@jwatt.org>
  Jonathon Jongsma <jjongsma@redhat.com>
  Julio Faracco <jcfaracco@gmail.com>
  Justin Gatzen <justin.gatzen@gmail.com>
  Ján Tomko <jtomko@redhat.com>
  Kashyap Chamarthy <kchamart@redhat.com>
  Kevin Locke <kevin@kevinlocke.name>
  Kristina Hanicova <khanicov@redhat.com>
  Laine Stump <laine@redhat.com>
  Laszlo Ersek <lersek@redhat.com>
  Lee Yarwood <lyarwood@redhat.com>
  Lei Yang <yanglei209@huawei.com>
  Liao Pingfang <liao.pingfang@zte.com.cn>
  Lin Ma <lma@suse.com>
  Lin Ma <lma@suse.de>
  Lin Ma <morecache@gmail.com>
  Liu Yiding <liuyd.fnst@fujitsu.com>
  Luke Yue <lukedyue@gmail.com>
  Luyao Zhong <luyao.zhong@intel.com>
  Marc Hartmayer <mhartmay@linux.ibm.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Markus Schade <markus.schade@hetzner.com>
  Martin Kletzander <mkletzan@redhat.com>
  Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
  Matej Cepl <mcepl@cepl.eu>
  Matt Coleman <matt@datto.com>
  Matt Coleman <mcoleman@datto.com>
  Mauro Matteo Cascella <mcascell@redhat.com>
  Meina Li <meili@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Michał Smyk <fedora@smyk.it>
  Milo Casagrande <milo@milo.name>
  Moshe Levi <moshele@nvidia.com>
  Muha Aliss <muhaaliss@gmail.com>
  Nathan <nathan95@live.it>
  Neal Gompa <ngompa13@gmail.com>
  Nick Chevsky <nchevsky@gmail.com>
  Nick Shyrokovskiy <nshyrokovskiy@gmail.com>
  Nickys Music Group <nickys.music.group@gmail.com>
  Nico Pache <npache@redhat.com>
  Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
  Olaf Hering <olaf@aepfle.de>
  Olesya Gerasimenko <gammaray@basealt.ru>
  Orion Poplawski <orion@nwra.com>
  Pany <geekpany@gmail.com>
  Patrick Magauran <patmagauran.j@gmail.com>
  Paulo de Rezende Pinatti <ppinatti@linux.ibm.com>
  Pavel Hrdina <phrdina@redhat.com>
  Peng Liang <liangpeng10@huawei.com>
  Peter Krempa <pkrempa@redhat.com>
  Pino Toscano <ptoscano@redhat.com>
  Pino Toscano <toscano.pino@tiscali.it>
  Piotr Drąg <piotrdrag@gmail.com>
  Prathamesh Chavan <pc44800@gmail.com>
  Praveen K Paladugu <prapal@linux.microsoft.com>
  Richard W.M. Jones <rjones@redhat.com>
  Ricky Tigg <ricky.tigg@gmail.com>
  Robin Lee <cheeselee@fedoraproject.org>
  Roman Bogorodskiy <bogorodskiy@gmail.com>
  Roman Bolshakov <r.bolshakov@yadro.com>
  Ryan Gahagan <rgahagan@cs.utexas.edu>
  Ryan Schmidt <git@ryandesign.com>
  Sam Hartman <hartmans@debian.org>
  Scott Shambarger <scott-libvirt@shambarger.net>
  Sebastian Mitterle <smitterl@redhat.com>
  SeongHyun Jo <caelus9536@gmail.com>
  Shalini Chellathurai Saroja <shalini@linux.ibm.com>
  Shaojun Yang <yangshaojun@phytium.com.cn>
  Shi Lei <shi_lei@massclouds.com>
  simmon <simmon@nplob.com>
  Simon Chopin <chopin.simon@gmail.com>
  Simon Gaiser <simon@invisiblethingslab.com>
  Simon Rowe <simon.rowe@nutanix.com>
  Stefan Bader <stefan.bader@canonical.com>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Berger <stefanb@linux.vnet.ibm.com>
  Stefan Hajnoczi <stefanha@gmail.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Szymon Scholz <szymonscholz@gmail.com>
  Thomas Huth <thuth@redhat.com>
  Tim Wiederhake <twiederh@redhat.com>
  Tomáš Golembiovský <tgolembi@redhat.com>
  Tomáš Janoušek <tomi@nomi.cz>
  Tuguoyi <tu.guoyi@h3c.com>
  Victor Toso <victortoso@redhat.com>
  Ville Skyttä <ville.skytta@iki.fi>
  Vinayak Kale <vkale@nvidia.com>
  Wang Xin <wangxinxin.wang@huawei.com>
  WangJian <wangjian161@huawei.com>
  Weblate <noreply@weblate.org>
  Wei Liu <liuwe@microsoft.com>
  Wei Liu <wei.liu@kernel.org>
  Wei-Chen Chen <weicche@microsoft.com>
  William Douglas <william.douglas@intel.com>
  Yalei Li <274268859@qq.com>
  Yalei Li <liyl43@chinatelecom.cn>
  Yang Fei <yangfei85@huawei.com>
  Yang Hang <yanghang44@huawei.com>
  Yanqiu Zhang <yanqzhan@redhat.com>
  Yaroslav Kargin <ykargin@virtuozzo.com>
  Yi Li <yili@winhong.com>
  Yi Wang <wang.yi59@zte.com.cn>
  Yuri Chornoivan <yurchor@ukr.net>
  Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
  zhangjl02 <zhangjl02@inspur.com>
  Zheng Chuan <zhengchuan@huawei.com>
  zhenwei pi <pizhenwei@bytedance.com>
  Zhenyu Ye <yezhenyu2@huawei.com>
  Zhenyu Zheng <zheng.zhenyu@outlook.com>
  Zhenzhong Duan <zhenzhong.duan@intel.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          fail    
 build-arm64-libvirt                                          fail    
 build-armhf-libvirt                                          fail    
 build-i386-libvirt                                           fail    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           blocked 
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-libvirt-xsm                                 blocked 
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-libvirt                                     blocked 
 test-arm64-arm64-libvirt                                     blocked 
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-libvirt-pair                                blocked 
 test-amd64-i386-libvirt-pair                                 blocked 
 test-arm64-arm64-libvirt-qcow2                               blocked 
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-libvirt-vhd                                 blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 80474 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Oct 25 13:38:34 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Oct 2021 13:38:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.215859.375259 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mf0BI-00084m-1k; Mon, 25 Oct 2021 13:38:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 215859.375259; Mon, 25 Oct 2021 13:38:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mf0BH-00084f-UW; Mon, 25 Oct 2021 13:38:27 +0000
Received: by outflank-mailman (input) for mailman id 215859;
 Mon, 25 Oct 2021 13:38:26 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=1v/+=PN=epam.com=prvs=0932af52eb=oleksandr_andrushchenko@srs-us1.protection.inumbo.net>)
 id 1mf0BG-00084Z-4l
 for xen-devel@lists.xenproject.org; Mon, 25 Oct 2021 13:38:26 +0000
Received: from mx0b-0039f301.pphosted.com (unknown [148.163.137.242])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id d409b51a-3598-11ec-840f-12813bfff9fa;
 Mon, 25 Oct 2021 13:38:25 +0000 (UTC)
Received: from pps.filterd (m0174683.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.0.43) with SMTP id 19PCqG9T030146;
 Mon, 25 Oct 2021 13:38:22 GMT
Received: from eur05-am6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2110.outbound.protection.outlook.com [104.47.18.110])
 by mx0b-0039f301.pphosted.com with ESMTP id 3bwrqas9sr-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Mon, 25 Oct 2021 13:38:22 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by AM0PR03MB5938.eurprd03.prod.outlook.com (2603:10a6:208:15c::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.18; Mon, 25 Oct
 2021 13:38:20 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::c038:e032:595a:651]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::c038:e032:595a:651%8]) with mapi id 15.20.4628.020; Mon, 25 Oct 2021
 13:38:19 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d409b51a-3598-11ec-840f-12813bfff9fa
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=JGdGHs4sjpjRhfiWVE1UwG0f5fIIIta/vBUHskHdL3EeG9pY8zusKupmY31xejNk4lcVRL4L/zwRqP5pNrBzgUILqq1HrWSPSvduAw4Hgty6jvCOL/vBYWrTqWlDirmbcCrEoIYAUb4giXgrMW+rNlYDycMgFa6AyT9xUnypFqAUZxYh3A9Gs2fjskucgpxACZBwTlTurOTSdUPU3nVN3aIbS8sTmzlLSj5/NG652IZWbW9BpzXiPiAUUkZ6W1dVpkW1nVdQkFqiUtUsIiC2zVDbtfsXk+1WcvROlHYh6i8Q4WFiV/eUZrLp8XNYl8cdx0R8K44Zr3S5JyA/crKymg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=46AWicN2KnpEG8Pk9f3qvbK22OkOkr2cfFWOHz3MsrM=;
 b=mjH3e14TFunEih40o+r+lWGnEJss7Qqq0OeC6Icaen5jnYNvQ1u4iNCFnJlXgWOxS2Yi22tevNYugXwpTHyIz6Mp91WRnK1BwDRx20+1ziAvb4CuVEm+PvrToSn8U93qGc0rqwFP3GxvZX6dyrHoEgRBbIY0EFqUKtNJmkOOJIxkqG8I5fq5VrT9C3g+Mii9p5ChLF1FIVi5IIpFilKGX4GMFaU/87W/BF5AxkShKBx3ttlsEewgihEtdYQT8A+VMK3mY2oUnbXxDWB69R8JZi/5snsG2XcZSZHRmkqvfw1A2KRMzlXiFaoczfdJ6wb67ntSWmH9seGpqtXTEvex6w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=46AWicN2KnpEG8Pk9f3qvbK22OkOkr2cfFWOHz3MsrM=;
 b=qX70rcJx0mmJd6MsaU5EpH1ilOZjFSE4GNv0U5K33UcbFnCqDUbOml9ef4UXkvcsDQwbfmaxHcv6rIgxG9dVxwHWRbHle9GRzSv6BZZ4z0AmXKm3mp9DnbQ1M8TjbjFk14ySC4T7SK1KCYzHn9TKDCwx08H2pPT8ekBGBZbOuvhl2Pr/sHB1HRtmgrfKsbVKpydyjvl9Mk8MGdGFpVYW2OlhmkBtz5LemgjzHeHnp9AA88x6VmZ154ZXHZrbyd44saPiJc/f8SCcTGO5wN8xc7nWh5BbYbW8nf5wtGOw7RXGsba/rhm3ZR39Cd7EOFBH0TQiXBJCiVec0RjcvbxUKg==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org"
	<sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
        "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
        "paul@xen.org"
	<paul@xen.org>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Rahul Singh
	<rahul.singh@arm.com>, Ian Jackson <iwj@xenproject.org>,
        Juergen Gross
	<jgross@suse.com>,
        Oleksandr Andrushchenko
	<Oleksandr_Andrushchenko@epam.com>,
        "jbeulich@suse.com" <jbeulich@suse.com>
Subject: Re: [PATCH v5 07/10] libxl: Only map legacy PCI IRQs if they are
 supported
Thread-Topic: [PATCH v5 07/10] libxl: Only map legacy PCI IRQs if they are
 supported
Thread-Index: AQHXvAknuuGQJumtOE+ut83tChlOwKvjzqeAgAAEa4A=
Date: Mon, 25 Oct 2021 13:38:19 +0000
Message-ID: <3de59765-6bcb-d6a1-7e23-2b85123df71d@epam.com>
References: <20211008055535.337436-1-andr2000@gmail.com>
 <20211008055535.337436-8-andr2000@gmail.com>
 <YXavl0e0zainVKT9@MacBook-Air-de-Roger.local>
In-Reply-To: <YXavl0e0zainVKT9@MacBook-Air-de-Roger.local>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 90508f97-f4a5-475e-5d7a-08d997bcb539
x-ms-traffictypediagnostic: AM0PR03MB5938:
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <AM0PR03MB5938894ADE4F64AFB0EE331DE7839@AM0PR03MB5938.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 DJIm3QBI0U2CRG5LBg+6A4TPTtmxPj3unwJ1MhakWCNOkVdRLRCOIZ/W8b5aTQvS0TnEsxK1pyZDg6fIQ1ipSK59lxSZ5hyW7OP0yuBI93Y2yQapTjsEGXIgInDOqw545+2NPSyUGAVC/zZkLxPsnsXA0KW9oN1u+lDijR/GcwNY8FKWvLBehNvr2zNqekbgDXs4fzgx/RdiNimZ0msivkl4eHgp52u/Hge9SZG+n7IgrnoO24Rukf3UbctODwNAVb16ySmKOOe33Zf3LYvYV/q4QzOaPye2FrGCXmaRJXwToJRoq9+Fa9/g9W9eozIOhUnSXp7yiKulrLFH1ZCD2YW4S7xs2lKQr48mH3PwDEtkKz5gkHUw6a16ATennQ4gDHvknOFzhcPlaEpEEPISOMxIKvOZZmBmWCK64TtmRX7eQED6HFdCIubmFq1eeBnvxaU6GADyV23qfJoOvIWEzg+b2xtqfNo0neVnZ7YFKOwmP8RkBZtbnJRiiFah5oms8gpC+PjfZ9x2oA69FB3SdimGZs/+t1FuMokd9zv5kbk+KMZ8RUDqK9qrzbbVspnbj648jFb6KVC8LboibjBl/3uxugs/7FcMebJHBoiquJDHR0gbPwn/xdvORqFpy2lv3F6QnAKLw0kuiDVVnRyxFeYGaXl/uhK2eIeSC9ipffxVvaOMDlmIqlNmz9exzr65Vi+dfuFSmcX3aq476DovY6vWTobBbxyAWEiyXUzF9YmFZ79yLfKFssBufHm5PJfZ
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(4326008)(66476007)(31696002)(26005)(7416002)(122000001)(31686004)(91956017)(2616005)(86362001)(66556008)(76116006)(6486002)(38070700005)(54906003)(6506007)(316002)(53546011)(6512007)(508600001)(2906002)(36756003)(6916009)(8676002)(66946007)(5660300002)(66446008)(71200400001)(38100700002)(64756008)(8936002)(186003)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?bnhGNTdMVVVVOHFnaElGbDVNYWorc0c2RHdseE10N01oMzg2Q2F2VFlBTmMr?=
 =?utf-8?B?a1NXcGRiN01saWlmWXdJTTBYM3Y2Z0owbEZnYTdOaGxrQTZyOEpIN1I3MWZv?=
 =?utf-8?B?UUZmTjh2UDIzUlZaQXJsNkljbmN2WkE0ZzlvSGdvbHY3QStHQUdTV2lpazlp?=
 =?utf-8?B?Zm92b3pFajU3Q3VJT2tlY01PL1R0Z3hCcm4vdkF4VlBRNFhzem9va2xNTW1G?=
 =?utf-8?B?YVpYdGRLM3IxVlhwazhIMTZsV0dFNHM1a2E0cytSVFBreGppdWJYTWEzZzZv?=
 =?utf-8?B?YSs0dmtncStXeWZ2enZkODBRdG13dmJHS3k4amxMcExucDZNa0hrVE0yTEUr?=
 =?utf-8?B?dFVEZWVpSHc0OW9PNjdmbzhhMUxRaU1LWnlleHdCY0RiUGIvUVAyTlBzcUpB?=
 =?utf-8?B?eVd0RTdTOHdUWDBsSVJkYkpPN2Y0cSttTWZBR2EwWnloRVR4NUdmUExpN2Jk?=
 =?utf-8?B?VkppV2NKTnNXRDFVQ0xyV0x4OHNEUkliNDhtUEptQ0FidVhnNkpRclgyZVRT?=
 =?utf-8?B?aEZHQjgrdHNMMG1hSitHR0kzUlo4T3U5YnVILytPNDdhOEh5L0pDcDAyRnk0?=
 =?utf-8?B?Zm9wd01nUVZnMTc4SHkzNEUxaWNNVnAzVEFrbXNKL2QraFZXdFg2NHJsc28z?=
 =?utf-8?B?cUd1QVhRSS9IQ2sxQVkrVy9URnJIRGZKaTJLc016c0VQYk1CUE9RSzhrTlp2?=
 =?utf-8?B?Vk5WVW5laEpPM2FBbXRSMndvUUtmazh0QkVWZUFOdExIUEZLdTJrcmtlcWZ5?=
 =?utf-8?B?a2ZUWkdqR3E4WUI2a1dKdnFvZ2E1YXIvSTdPY3Z0QXR0Y1RyUmZnOVNQWmI4?=
 =?utf-8?B?Ly93RUNySmVzNFN6am9BT1gyMTg3amxvMWlPV2pod2tiZk9TR281dUZtYVk3?=
 =?utf-8?B?VEgvU0JOaTBiWitkTE91WUtxczNqVmVROVZZRHpxY2NFWU1GWThHSU9CRUlC?=
 =?utf-8?B?eUE5cng4VHArdThNWTNvblNRYVFOb0pPTWhaeXBTU0g1Nm1HMUJtM1NxWHZI?=
 =?utf-8?B?RTRtY0drd0R1R0tqaFdkL3pmSHhQWkZQdDB5SGxFSE05YjRVTXRPWVFGOWp2?=
 =?utf-8?B?Q3IvN3pURElPbWV2SFJXSUROSklwSVpXWkttdTA4bTZQNUtTT0o2cGwzQmdz?=
 =?utf-8?B?aUh3OTl6cUx1S0ZGTEVydENEZmVMb3JwaVIwenlGcHVId21jZjJublR0cTFG?=
 =?utf-8?B?Qm9DMlZQRlc1ck53RlhIMmNNVnpsbWx3UCtwUjdpek1kZDZRWUMrRXFaUVJY?=
 =?utf-8?B?S0lUM1c1bVFhbXBKK1FibFFSZXBYcUhYTnVFUHFmaC9Eb0lKcWJuL0w4a2Vk?=
 =?utf-8?B?QmZFOURZbURvb0VDWW41K3RUMjRGbk1IUG9HTnAwRjMyYVlvQ3R1VWsyaDls?=
 =?utf-8?B?VnBGS3hoeTBPdVZEUEdkS2F5OHNMSjhiN1NncHdRWW1ORUhSV2JEVndYNzBP?=
 =?utf-8?B?ZjRBdjVtYnNpQWg1WXFJUUFjRVYxMEZlaVFodW9xampIb2xIeTlNSmVhb2N4?=
 =?utf-8?B?eVNsWWdzU1dDSVlWbVBxcUE4OFJiRWR1cnI2eHFDeTdCWVhCYW5mYmdVdzFU?=
 =?utf-8?B?dk9WYStHTkdNdUtUT1RwV0hqQksrd2kvNEZFQXBhdml3NVQ2Nk10VUNlMTg5?=
 =?utf-8?B?ZE1kbWJrOUo3KytlZHZ2RzVoTzVsTm1MZUtTNkxCUlBPNGR4WjU5K1pBMllS?=
 =?utf-8?B?cFA1dndYRzVJS04yUm4wNHpwR0pTZE1JRC9OSWhBNFY2TTVEQlo0V1JMQnkr?=
 =?utf-8?B?c2VsWlViVmgxZUpyWTREemMrV1lZTlpJaVZzOTNxajJKQ2tCdjJxUzA5cnlq?=
 =?utf-8?B?SysxekZLdSszdmN1Q0lvMmRwcnFSakZJaDhIWTFjVWpuRStxZDdwYThZOVpU?=
 =?utf-8?B?bkpJdDJ5WGhSYUZ2SEZvQTJPSHhuS1NMT3krN0pMb1RtVyt0dXhHWlRxbGth?=
 =?utf-8?B?Vk1uMjVObnl6aGNaYkpTaERJT01IUDhwNWxRbWRlSTY1cXI4bThsRWpIa2Yx?=
 =?utf-8?B?VktnTGhpYTBOM3BTYTF2eVBISzZ4TnNndWU0QXJTd0xJWXp3SGNPNVdGZlRL?=
 =?utf-8?B?dHZFRzA3dnJiSWNyeGttV0dJb2haQjBpQW5mTlowQTF6ZmRtcW5zOGh5WlhH?=
 =?utf-8?B?Tm85MkFLUzl2NzkxdkNXbEFGS1QvOVVkYUI0ZWY0U0xvL2R1QytqRFk1NzdB?=
 =?utf-8?B?dVIxY3N2MDBFaGhSN01IR3IzWCtqcTRnVjJabCtkUElTa3pSR0puYTVuTTVa?=
 =?utf-8?B?NFNsb2swU3IvR0lCYmdSUnNhcXVsZ05pakc4STJmYUVnR2RmVS8vTUZTMDhC?=
 =?utf-8?B?Y3lROU1pQUxmelQyNmVYYVFrMzFJU1BvZXltcDRNNXZpMDNsanRsUT09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <0AD73E97438DB24591A392BFDDBA0B5C@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 90508f97-f4a5-475e-5d7a-08d997bcb539
X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Oct 2021 13:38:19.7935
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: YmD/44Q8E3DJ/qEFVP6DiimnQx1MRr2k94uORVF7iq9udaR8e5WmRXee8j/xdrqI3liQz1xx9M+BPfl0tGyLh8KUTtOpGMGZphnnUJ6ntVS/zWTIxKltqizna7d+swgt
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR03MB5938
X-Proofpoint-GUID: TLXiWV_3G9eS5YxwSV7x0_ex1bVRYY5h
X-Proofpoint-ORIG-GUID: TLXiWV_3G9eS5YxwSV7x0_ex1bVRYY5h
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475
 definitions=2021-10-25_05,2021-10-25_02,2020-04-07_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501
 bulkscore=0 suspectscore=0 malwarescore=0 mlxscore=0 spamscore=0
 impostorscore=0 clxscore=1015 phishscore=0 mlxlogscore=999
 lowpriorityscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx
 scancount=1 engine=8.12.0-2109230001 definitions=main-2110250083

SGksIFJvZ2VyIQ0KDQpPbiAyNS4xMC4yMSAxNjoyMiwgUm9nZXIgUGF1IE1vbm7DqSB3cm90ZToN
Cj4gT24gRnJpLCBPY3QgMDgsIDIwMjEgYXQgMDg6NTU6MzJBTSArMDMwMCwgT2xla3NhbmRyIEFu
ZHJ1c2hjaGVua28gd3JvdGU6DQo+PiBGcm9tOiBPbGVrc2FuZHIgQW5kcnVzaGNoZW5rbyA8b2xl
a3NhbmRyX2FuZHJ1c2hjaGVua29AZXBhbS5jb20+DQo+Pg0KPj4gQXJtJ3MgUENJIHBhc3N0aHJv
dWdoIGltcGxlbWVudGF0aW9uIGRvZXNuJ3Qgc3VwcG9ydCBsZWdhY3kgaW50ZXJydXB0cywNCj4+
IGJ1dCBNU0kvTVNJLVguIFRoaXMgY2FuIGJlIHRoZSBjYXNlIGZvciBvdGhlciBwbGF0Zm9ybXMg
dG9vLg0KPj4gRm9yIHRoYXQgcmVhc29uIGludHJvZHVjZSBhIG5ldyBDT05GSUdfUENJX1NVUFBf
TEVHQUNZX0lSUSBhbmQgYWRkDQo+PiBpdCB0byB0aGUgQ0ZMQUdTIGFuZCBjb21waWxlIHRoZSBy
ZWxldmFudCBjb2RlIGluIHRoZSB0b29sc3RhY2sgb25seSBpZg0KPj4gYXBwbGljYWJsZS4NCj4+
DQo+PiBTaWduZWQtb2ZmLWJ5OiBPbGVrc2FuZHIgQW5kcnVzaGNoZW5rbyA8b2xla3NhbmRyX2Fu
ZHJ1c2hjaGVua29AZXBhbS5jb20+DQo+PiBSZXZpZXdlZC1ieTogU3RlZmFubyBTdGFiZWxsaW5p
IDxzc3RhYmVsbGluaUBrZXJuZWwub3JnPg0KPj4gUmV2aWV3ZWQtYnk6IFJhaHVsIFNpbmdoIDxy
YWh1bC5zaW5naEBhcm0uY29tPg0KPj4gVGVzdGVkLWJ5OiBSYWh1bCBTaW5naCA8cmFodWwuc2lu
Z2hAYXJtLmNvbT4NCj4+IC0tLQ0KPj4gQ2M6IElhbiBKYWNrc29uIDxpd2pAeGVucHJvamVjdC5v
cmc+DQo+PiBDYzogSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuY29tPg0KPj4NCj4+IFNpbmNl
IHYxOg0KPj4gICAtIE1pbmltaXplZCAjaWRlZmVyeSBieSBpbnRyb2R1Y2luZyBwY2lfc3VwcF9s
ZWdhY3lfaXJxIGZ1bmN0aW9uDQo+PiAgICAgZm9yIHJlbGV2YW50IGNoZWNrcw0KPj4gLS0tDQo+
PiAgIHRvb2xzL2xpYnMvbGlnaHQvTWFrZWZpbGUgICAgfCAgNCArKysrDQo+PiAgIHRvb2xzL2xp
YnMvbGlnaHQvbGlieGxfcGNpLmMgfCAxMyArKysrKysrKysrKysrDQo+PiAgIDIgZmlsZXMgY2hh
bmdlZCwgMTcgaW5zZXJ0aW9ucygrKQ0KPj4NCj4+IGRpZmYgLS1naXQgYS90b29scy9saWJzL2xp
Z2h0L01ha2VmaWxlIGIvdG9vbHMvbGlicy9saWdodC9NYWtlZmlsZQ0KPj4gaW5kZXggN2Q4YzUx
ZDQ5MjQyLi5iZDNmNmJlMmExODMgMTAwNjQ0DQo+PiAtLS0gYS90b29scy9saWJzL2xpZ2h0L01h
a2VmaWxlDQo+PiArKysgYi90b29scy9saWJzL2xpZ2h0L01ha2VmaWxlDQo+PiBAQCAtNDYsNiAr
NDYsMTAgQEAgQ0ZMQUdTICs9IC1Xbm8tZm9ybWF0LXplcm8tbGVuZ3RoIC1XbWlzc2luZy1kZWNs
YXJhdGlvbnMgXA0KPj4gICAJLVduby1kZWNsYXJhdGlvbi1hZnRlci1zdGF0ZW1lbnQgLVdmb3Jt
YXQtbm9ubGl0ZXJhbA0KPj4gICBDRkxBR1MgKz0gLUkuDQo+PiAgIA0KPj4gK2lmZXEgKCQoQ09O
RklHX1g4NikseSkNCj4+ICtDRkxBR1MgKz0gLURDT05GSUdfUENJX1NVUFBfTEVHQUNZX0lSUQ0K
Pj4gK2VuZGlmDQo+IFRCSCwgc2luY2UgQ09ORklHX1BDSV9TVVBQX0xFR0FDWV9JUlEgaXMgdXNl
ZCBpbiBhIHNpbmdsZSBwbGFjZSBpbiB0aGUNCj4gc291cmNlIEkgd291bGQgY29uc2lkZXIganVz
dCB1c2luZyBDT05GSUdfWDg2LCBhcyBJIHRoaW5rIGl0IHdvdWxkIGJlDQo+IGNsZWFyIGVub3Vn
aCB0aGF0IHNvbWUgYXJjaGVzIHN1cHBvcnQgbGVnYWN5IGludGVycnVwdCB3aGlsZSBvdGhlcnMN
Cj4gZG9uJ3QuIE5vdCBzdXJlIGl0J3Mgd29ydGggZ29pbmcgdGhyb3VnaCB0aGUgb2JmdXNjYXRp
b24gb2YgZGVmaW5pbmcgYQ0KPiBzZXBhcmF0ZSBvbmUuDQpUaGUgaWRlYSBiZWhpbmQgbm90IHVz
aW5nIENPTkZJR19YODYgaXMgdG8gYmUgYXJjaCBhZ25vc3RpYywNCnNvIENPTkZJR19QQ0lfU1VQ
UF9MRUdBQ1lfSVJRIG1ha2VzIG1vcmUgc2Vuc2Ugd2l0aCB0aGlzDQpyZXNwZWN0DQo+PiArDQo+
PiAgIFNSQ1MtJChDT05GSUdfWDg2KSArPSBsaWJ4bF9jcHVpZC5jDQo+PiAgIFNSQ1MtJChDT05G
SUdfWDg2KSArPSBsaWJ4bF94ODYuYw0KPj4gICBTUkNTLSQoQ09ORklHX1g4NikgKz0gbGlieGxf
cHNyLmMNCj4+IGRpZmYgLS1naXQgYS90b29scy9saWJzL2xpZ2h0L2xpYnhsX3BjaS5jIGIvdG9v
bHMvbGlicy9saWdodC9saWJ4bF9wY2kuYw0KPj4gaW5kZXggNTlmMzY4NmZjODVlLi40YzJkN2Fl
ZWZiYjIgMTAwNjQ0DQo+PiAtLS0gYS90b29scy9saWJzL2xpZ2h0L2xpYnhsX3BjaS5jDQo+PiAr
KysgYi90b29scy9saWJzL2xpZ2h0L2xpYnhsX3BjaS5jDQo+PiBAQCAtMTM2NCw2ICsxMzY0LDE1
IEBAIHN0YXRpYyB2b2lkIHBjaV9hZGRfdGltZW91dChsaWJ4bF9fZWdjICplZ2MsIGxpYnhsX19l
dl90aW1lICpldiwNCj4+ICAgICAgIHBjaV9hZGRfZG1fZG9uZShlZ2MsIHBhcywgcmMpOw0KPj4g
ICB9DQo+PiAgIA0KPj4gK3N0YXRpYyBib29sIHBjaV9zdXBwX2xlZ2FjeV9pcnEodm9pZCkNCj4g
QSBuYW1pbmcgbW9yZSBpbmxpbmUgd2l0aCB0aGUgUENJIHNwZWNpZmljYXRpb24gKHNpbmNlIHdl
IGluc2lzdGVkIG9uDQo+IHVzaW5nIEVDQU0gaW5zdGVhZCBvZiBNQ0ZHKSB3b3VsZCBiZSBpbnR4
LCBpZTogcGNpX3N1cHBvcnRzX2ludHguDQpUaGlzIHdpbGwgcmVxdWlyZSBhIGZvbGxvdyB1cCBw
YXRjaCBpZiB3ZSBhbGwgYWdyZWUgdGhpcyBjaGFuZ2UgaXMgbmVlZGVkLg0KQEphbiwgYXJlIHlv
dSBvayB3aXRoIHRoZSByZW5hbWU/DQo+DQo+IFRoYW5rcywgUm9nZXIuDQpUaGFuayB5b3UsDQpP
bGVrc2FuZHI=


From xen-devel-bounces@lists.xenproject.org Mon Oct 25 13:40:52 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Oct 2021 13:40:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.215869.375270 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mf0Db-000150-J9; Mon, 25 Oct 2021 13:40:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 215869.375270; Mon, 25 Oct 2021 13:40:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mf0Db-00014t-G4; Mon, 25 Oct 2021 13:40:51 +0000
Received: by outflank-mailman (input) for mailman id 215869;
 Mon, 25 Oct 2021 13:40:50 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=G2Ub=PN=citrix.com=roger.pau@srs-us1.protection.inumbo.net>)
 id 1mf0Da-00014n-R3
 for xen-devel@lists.xenproject.org; Mon, 25 Oct 2021 13:40:50 +0000
Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 29dfd69a-3599-11ec-840f-12813bfff9fa;
 Mon, 25 Oct 2021 13:40:49 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 29dfd69a-3599-11ec-840f-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1635169249;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=YsI8oJjNzAWb5KKJeVdtnuUKPH6GksyczH9JASNUHIs=;
  b=ISyjeEwY0RfcXrzyzffSGD0hQniaa3WSP1VbBc/dPfTzzN2b++mF6L7v
   pI11kVD7kR5ADfiBngkPOe89+kxFHMavqpMtASZ9auu9wPObDjqRf6q6C
   fWeNPawZyoYZNkO/xoOoz1hCW2Cf2yh2E6Mq7inZBfYzDingNsdnVXJgh
   A=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: YvovpOaf3zz1cZhm4TXZIb5FYcA1mmiqNsNxa10/QuVX6wrIG1zWwojKYEHpbp6z7UGWXfOUj4
 Xp3isYRXrmj9wgFM1hmO7wARjP1MNZt1fQpa1jcaaFhkYrmPTtdnG8PPwU86D1Ckm+bWhkAgvr
 99JwdQwrGRoHxe9RcvbfCPMa1aGn2VwhrbIfOccb6eQp2rpPqo5ULIJ4dAXK11H7fTqVFI+3c9
 v47vTyQIpm2YC1K7Ls/BMzbTlIRjRfJ9yThAgMI/2mcZUoOd7Raf42beAFBal0JiQFut7DDDlx
 n1CmgSpacL+yZ7mUzGaCiF+n
X-SBRS: 5.1
X-MesageID: 55541012
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:WcB8ma9pJXccK9c145EhDrUDoniTJUtcMsCJ2f8bNWPcYEJGY0x3z
 mQWWz+BbP2Ca2D8fdEkadnnoRhV7JbXy9JmGgFpqCo8E34SpcT7XtnIdU2Y0wF+jyHgoOCLy
 +1EN7Es+ehtFie0Si9AttENlFEkvU2ybuOU5NXsZ2YhGmeIdA970Ug6wrZj39Yx6TSEK1jlV
 e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH
 I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPhg9
 PtivpOXSzwDGerVnr0wWjlHFCdHaPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us
 6ZCcXZUM07F17neLLGTE4GAguw5K8bmJsUHs2xIxjDFF/c2B5vERs0m4PcFgWps35gXR54yY
 eIzdBZxNT7STSRREQgWA40UktqQvHrgJmgwRFW9+vNsvjm7IBZK+LrnPcfRe9eKbd5IhUver
 WXDl0zQGA0XMeu62DWM83+yruLXlCa9U4UXfJWg/+NuqE2ewCoUEhJ+fUGyoeS9zFW/Xd1fA
 0UO/2wlqq1a3EamVMXnVhu05nuNpAcBWsF4Gvc/rgqKz8L83QGdAWQVSy9bX/YvvsQ2WD8C2
 0eAmpXiAjkHmK2YTzeR+6mZqRu2ODMJNikSaCkcVwwH7tL/5oYpgXrnadJuE7W8iNHvLhj2z
 yqXtyg1h7gVjskj2r2y+BbMhDfEjprUSg844C3HU2Tj6Rl2DKaCY4Gr8lHd4ex3EJeCTlKBs
 X4HnOCT9OkLS5qKkUSlW/4RFbuk4/KENjz0glN1GZQlsTO39BaekZt4uW8kYh0za4BdJGGvM
 BS7VR5tCIF7LUeEQqR4RICKIeNt1K65ON3FSffSV48bCnRuTzOv8CZrbE+W+mnilkkwjK0yU
 aumndaQ4WUyUvs/kmLnLwsJ+fpynHpmnDKMLXzu503/ieL2WZKDdVsS3LJihMgC56SYvB6dz
 d9bM8abo/m0eLyjOneJmWL/wFZjEJTaOXwUg5EPHgJgClA/cI3ENxM26eh5E7GJZ4wPyo/1E
 oiVAye0MmbXi3zdMhmtYXt+cr7pVpsXhStlZnF1ZQ7yiiB7O9bHAEIjm30fJ+lPGAtLlqYcc
 hX4U5/YXqQnpsrvomx1gWbBQHxKK03w2FPm09uNazkjZZ9wLzElCfe/FjYDABImV3Lt3eNn+
 uXI/lqCHfIrGlQzZO6LOanH5w7g4hAgdBdaAhKgzi97Ix63ruCH6kXZ05cKHi37AUySlmXBj
 13NX0ZwSCuki9ZdzeQlTJus9u+BO+B/AlBbDy/c67O3PjPd5W2t3clLV+PgQNwXfDqcFHyKa
 boHwvfiHucAmVoW4YNwH6wylfA15sf1pq8cxQNhRS2ZY1OuA7JmA3+HwcgQ6fEdmu4H4VO7C
 hCV591XGbSVI8e5QlQfExUoM7aY3vYOlziMsflseBfm5DV69aasWFlJO0XekzRUKbZ4adt3w
 eootMMMxRa4jx4mboSPgixOrjzeJX0cSaQ38JodBdaz2AYsz1hDZ73aCzP3v87TO4kdbBFyL
 2bN1qTYhrlayk7TSFYJFCDAjbhHmJADmBFW11tedV6HrcXI260s1xpL/DVpEgkMlkdb0/h+M
 3RAPlFuIfnc5C9hgcVOUjz+GwxFAxHFqEX9x0FQyT/cRkisEGfMMHc8KaCG+0VAqzBQeT1S/
 be5zmf5UGm1IJGtj3VqAUM1+eb+SdFR9xHZnJH1FsuIKJA2fD75j/L8fmEPsRbmXZs8iUCvS
 TOGJwqshXkX7RItnpA=
IronPort-HdrOrdr: A9a23:afKOCqN2jRVUGcBcTsWjsMiBIKoaSvp037BN7TEXdfU1SL39qy
 nKpp8mPHDP5Ar5NEtOpTniAsm9qBHnm6KdiLN5Vd3OYOCMggqVBbAnwYz+wyDxXw3Sn9QtsJ
 uIqpIOa+EY22IK7/rH3A==
X-IronPort-AV: E=Sophos;i="5.87,180,1631592000"; 
   d="scan'208";a="55541012"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=HwOzM2AVH6BQVkRLbDkSAyPtmYE6ElYTYn80mVnO0F4cilxicuKUqPnTnyXf+lQ7tZkRCHjSxWwwjG3DA3JcrOJ28WpVbNbwUhTm6v4QVOtB2fr5ebkZK/dlXpZc2YsoqfdjMOyqpv3sytjAzzB8+ZkKOQBlpHmQMvMpolfVGCO8i2aoOS16XxMuJb47GFjna7cmHTbHr1VBcaN7yCGPpxbWAKtlzgW0Mmh/Le7W53Y0nbqLeqaVqiQsgklYpTHpJ5B64sjP8K2QTMDsRKck+6b2oWIgtxcUw0x+IFV2HiOaiAtcm2SyIXJK5dO9GNyxY4dV22lzla1RSTJDm4Dkag==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=PiIxI6WkK73yAaGqnLv3DJVEO2USAk8Ei936fAO1J94=;
 b=gLkcNHXrth72R5NZY9YuuJBVGbOmWPAp2QIHGKlIzgJse+Y/nJ3t90ex+PduiMSiJArZifu+8iVzBwCfULUcck5E2TN4XcuAMcTZojHF0U4ieBqj5weghSpwoEOH1j2iiqZNYHKBJfmooJXV56msagftOo7wxEP87q5yTadeqXqbfvOc8ELcDfFnxl9gJ292E2wlztXvWaCBKeSbvvPh5Xq+vRI8H69AgkGz5QOJq1orJYvV1qS5Y59eZPi+1s4LQ/BXmIQU43Z/EWq9B42ss/zElZsavLrPHFqpexoItcXIX4rdmdLivlqKT7vSozMc7mOiCqdBSfPUtqMISUA9MQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=PiIxI6WkK73yAaGqnLv3DJVEO2USAk8Ei936fAO1J94=;
 b=J1wwiKYM8pOR2RyCaBTwRydosANOk0+HDLAXoo9WrgfdphQRxYWgUn+ArtO6MbX21YPjhbrQDvglJEb8lMv1BqtHEDjiZvyoTuQ113Zs0Tvd237H0HScFkF9V9w+aAblBdU6Uc63uMcRJ19vpBEmvRXvyQFtcbdQbY/VBlmaa2M=
Date: Mon, 25 Oct 2021 15:40:36 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	"julien@xen.org" <julien@xen.org>, "sstabellini@kernel.org"
	<sstabellini@kernel.org>, Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Artem Mygaiev <Artem_Mygaiev@epam.com>,
	"jbeulich@suse.com" <jbeulich@suse.com>, "andrew.cooper3@citrix.com"
	<andrew.cooper3@citrix.com>, "george.dunlap@citrix.com"
	<george.dunlap@citrix.com>, "paul@xen.org" <paul@xen.org>, Bertrand Marquis
	<bertrand.marquis@arm.com>, Rahul Singh <rahul.singh@arm.com>
Subject: Re: [PATCH v5 08/10] xen/arm: Setup MMIO range trap handlers for
 hardware domain
Message-ID: <YXaz1G1mvHzZHdxM@MacBook-Air-de-Roger.local>
References: <20211008055535.337436-1-andr2000@gmail.com>
 <20211008055535.337436-9-andr2000@gmail.com>
 <YWawvYGqIe3DwZfI@MacBook-Air-de-Roger.local>
 <7f2a5875-69c9-b40b-287b-1355698598e5@epam.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <7f2a5875-69c9-b40b-287b-1355698598e5@epam.com>
X-ClientProxiedBy: PR0P264CA0284.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:100:1::32) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 2f0e123c-4858-47d6-a270-08d997bd0976
X-MS-TrafficTypeDiagnostic: DM6PR03MB3915:
X-Microsoft-Antispam-PRVS: <DM6PR03MB3915E9438745382E71C47C4E8F839@DM6PR03MB3915.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:1051;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: Zk3DNwD2OiHHiicGrvkS2CHML+dI+I+nbgvclc8Pc5JkEj4E0RD9GcJ+4HjkFx5Y7PmNNHoRmSoA9Hb8hsCZ1Vuqx46bG64dbwVOqk2LZZbMyoqEgrYSZoYn0T1GAURPZhbsgXffltUZMV++8X1hjm+LNeLNxZ24a926jEkk60fWyyGSmx19gKSECiQanwHIGblegHiwQw4B5ECFak/EWmT7SuZ9mQkGzhDicSME5pGrEyvpf6SXxFDJRJt05e8DvfgM7JFqHH6r1x2QmCDdUdH7MQRLZfqyg01NufXBmiv/Kc72WqhgjnabOBN2CPcqVVrhspbs8IwkO7Z8uTGCQBIYM/YMXXIF+wjRI2IJYX/WElNBJxcVqLcJ8bTtn1EJFvoclWc/zkCSOKt84f0Bu8Ty7NS9fx4LNWyQnoSUGfbh4+rzPp8JQ35jrE8/T+HI6m7Tx+tFIfECXnhY+HVOmSjOk/GS8ecJ0r3uwiq25LHSfQHEB2iOzhcthLhPQiqfdc5XWSDYO2pKvOvFrlj+ohw3XWFtW2NEeWWZndbvOb7N32HLiLMxrULpJuN4s/ECHgoUsh4jMfQsw41xg/UX+rmXtqE6Xifm+dePRJDivK7OvDWC0+zuuiXbW1X3aRtY5ZfGR0XLHEns8QHg/Md7hA==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(82960400001)(2906002)(956004)(85182001)(9686003)(54906003)(86362001)(26005)(6486002)(6666004)(66556008)(66476007)(6496006)(508600001)(186003)(83380400001)(53546011)(316002)(66946007)(6916009)(38100700002)(5660300002)(8676002)(8936002)(4326008)(7416002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TFBiSytUTmxhS0hickczOGFuTDJMU0U4RkV1SlQzSHJLRmVCMjBnQmZ3MWZh?=
 =?utf-8?B?SlpDUjM0YjlLSTRxeXVjZUtscjZYU1ZVVk43SHRwU3ZQQnZzQVdkOWwzRis0?=
 =?utf-8?B?dW9JTUt3dUhUektMREdzNGJMdUFVaStlUExuZkdXZmZaNUZJT1RIZUdyVVBO?=
 =?utf-8?B?cEtxd3JpdzQxbC90SERhSjcwKzV2SWFiWXluSStpS3drRU5VT3JYMW8vYmlI?=
 =?utf-8?B?V29Nc1JNb2FxNGxNZDJQQTZvYmxqcEo0TVY2a2V6bzVaaUxPVzJuZHNEM2Jh?=
 =?utf-8?B?Zy82Y2ZiWndKVWdhQndKNHdvQklxTkYzRVp2RWJoa0x4U0prQ0Y4ZDAwZkFy?=
 =?utf-8?B?ZjZFU3I3R3doQmZZYS9Mdmd4RHh0WTdEdFIwWEVXRG83cjBNbTdoVHBXNWk1?=
 =?utf-8?B?dG1HOUhnTFlTZnRlQlFlbnZwWStkK29hNGlaL0NzYmNrRUN6SEY0c2gwTkxn?=
 =?utf-8?B?R1hQMFh4MVpQUFlnb0k4R0pmMGtEazVOd284MlBDVENRQ0lOUEM3blorNnlF?=
 =?utf-8?B?Z0xWd1N4VXlUeEFUZ0dQRUxRM1NDQzZSWWJ4cEZPSklVKzdlMWxJOHYxdUFK?=
 =?utf-8?B?WFF1azVuZGRmV1hPTnlnV0QxUGMyelNYcG51a1B4bzBXdGsrSHpWUHBVcDV3?=
 =?utf-8?B?QXAyTmIxRE5vMDhvRGlpc2V1VFJlckVxd242V3QvclFzTnR2Yi9mZE05c0p0?=
 =?utf-8?B?c25Oc2tiNlExdURXZDkveVZQRGxrK1RoWmdqYS9qeHBPQWw0T3dQR1ZRa08y?=
 =?utf-8?B?UmZWYmNZdzZMcCtDLy9KSHZ6S3NobCtSb1FnT2FIV3FZOUM1RDVVeFhnc29K?=
 =?utf-8?B?azMxdHdOdExmRE00ODFHUzJYTnJSTlZ2cW9rK08rNm01YTVpOXF6NHUxd0Na?=
 =?utf-8?B?RURiWERqQ0hhVmlJY2VYSHh0NlV3MlVDMEI4ZXJYd0F6V2Mra0FyM0FCVnN3?=
 =?utf-8?B?Q0dRNVJtbkxpL1kwS0ZmanFBUXphQ1BnNmp1ZHVEdmdkcnUwQ0hpLzJrV2Va?=
 =?utf-8?B?anVueEZTMjJlV1g2WUVnN0dMRjdzUGVuRTh2Tmw4R1JJUXY5aVludlFFeUVh?=
 =?utf-8?B?aDJOV1V3bnJaWHVwamFBd3dqZnlJZEk3Vm5waUYxNmlIbENmTHFIUE13alh1?=
 =?utf-8?B?eTl4YjUxRk13N3VJeDRaMGdCdjNNV3FLQW83WCsvWHRKcnhFeUh5NjlFMkNJ?=
 =?utf-8?B?TmlsVEdHY0VQUXlmM0h3RzZjVkc1TUxERFFzRkhHYTIrYTQxcWtDWjZBaUQ2?=
 =?utf-8?B?OHdzanl4VFpxVG4zS2YyYm1lclR3b05hMWR4blBOWm1EOVRsOVFUeElTTlJZ?=
 =?utf-8?B?eDU3UVlKVitrMXdlNUllVHB2L2JOUkNXcFNORk1hMlY3QlVjSkVFeEovK0Zm?=
 =?utf-8?B?WGYrMy9hZGFFQndla1VJWWZSb2NYN0dZd3VSS3RHWTVmZ3dveStjakVzV0Uy?=
 =?utf-8?B?RHZaMUlJV1dSTlg2aTkyY2dhakZBV0dEQVBwYTBaaU42SzQ4dlY3MnR2K1Rm?=
 =?utf-8?B?N1piM2J2Umc2aGVXL211bjRnMW9GSURTL0UxZ3Irb0d2ZWU5NVJBU0JldnNm?=
 =?utf-8?B?bForNXM1MlE3WmVud3ZiaDZnTFFkcTROVDI3VUhjMG9BZGErMXhJWE5xbk1L?=
 =?utf-8?B?RmtMTzFQVlgrR2VRcFdxOFlRZEo5bkIvaEMrRDBwbDVTdmlPZm1md2x1dGls?=
 =?utf-8?B?TVhlb0xBWWdtZTdrOFl0RG5QNnUzMXd1Q0poVEw3QmlQaXlacHBiZmdqb29P?=
 =?utf-8?B?U2RSa1pNd1pOT2pIUHBPQ1NnNXpVTlBpQS84bGxHKzVDaWYwZDhLNnJHN2Zu?=
 =?utf-8?B?eGpVT2MwcWJzT0tDQ2dwZTJpMm5EalNjWXN0emIxVDNTZW1OY0V4OVNhN1pz?=
 =?utf-8?B?bTk2MEJ2NGRPRlRpSXk5RCsrZnlsUC8zRlVUMFpxMmE1S2ZRMGhsUy9KWkFT?=
 =?utf-8?B?V0FmRG1kcnpnVFBXYTZvS3pOT2VPUGM2TVkzUlJmT0dLZWZub3VtMWNCL3dv?=
 =?utf-8?B?UEpFQTh4RllvamE1YzQ0SUdoSTZES2VmR1Z1MUJsbTlmNnR5a0hVMERGbnZm?=
 =?utf-8?B?alEzR0lZWFRSYW5YcjJFa1RvTjF1TGRNY1AxQlgyV05zOEpMa1VEZmkzQTA2?=
 =?utf-8?B?d1Ziek14UTcvVVI0ZlZiR2M1R1djMkQ2YXFPM3U5dnY4ZThPVVltbzNmV25P?=
 =?utf-8?Q?rdxScJtdEuIyKcrmo6xAnQo=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 2f0e123c-4858-47d6-a270-08d997bd0976
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2021 13:40:41.7070
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: XylVrMqYygXzd7HhbDw9Ps602A0sGZP6baxJgGGvsv+xRiza9VDUlugauah0tWoH74G5wiDdoGws8t+5cdwXUw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB3915
X-OriginatorOrg: citrix.com

On Mon, Oct 25, 2021 at 09:38:00AM +0000, Oleksandr Andrushchenko wrote:
> Hi, Roger!
> 
> On 13.10.21 13:11, Roger Pau Monné wrote:
> > On Fri, Oct 08, 2021 at 08:55:33AM +0300, Oleksandr Andrushchenko wrote:
> >> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> >>
> >> In order for vPCI to work it needs to maintain guest and hardware
> >> domain's views of the configuration space. For example, BARs and
> >> COMMAND registers require emulation for guests and the guest view
> >> of the registers needs to be in sync with the real contents of the
> >> relevant registers. For that ECAM address space needs to also be
> >> trapped for the hardware domain, so we need to implement PCI host
> >> bridge specific callbacks to properly setup MMIO handlers for those
> >> ranges depending on particular host bridge implementation.
> >>
> >> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> >> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
> >> Reviewed-by: Rahul Singh <rahul.singh@arm.com>
> >> Tested-by: Rahul Singh <rahul.singh@arm.com>
> >> ---
> >> Since v3:
> >> - fixed comment formatting
> >> Since v2:
> >> - removed unneeded assignment (count = 0)
> >> - removed unneeded header inclusion
> >> - update commit message
> >> Since v1:
> >>   - Dynamically calculate the number of MMIO handlers required for vPCI
> >>     and update the total number accordingly
> >>   - s/clb/cb
> >>   - Do not introduce a new callback for MMIO handler setup
> >> ---
> >>   xen/arch/arm/domain.c              |  2 ++
> >>   xen/arch/arm/pci/pci-host-common.c | 28 ++++++++++++++++++++++++
> >>   xen/arch/arm/vpci.c                | 34 ++++++++++++++++++++++++++++++
> >>   xen/arch/arm/vpci.h                |  6 ++++++
> >>   xen/include/asm-arm/pci.h          |  5 +++++
> >>   5 files changed, 75 insertions(+)
> >>
> >> diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
> >> index 79012bf77757..fa6fcc5e467c 100644
> >> --- a/xen/arch/arm/domain.c
> >> +++ b/xen/arch/arm/domain.c
> >> @@ -733,6 +733,8 @@ int arch_domain_create(struct domain *d,
> >>       if ( (rc = domain_vgic_register(d, &count)) != 0 )
> >>           goto fail;
> >>   
> >> +    count += domain_vpci_get_num_mmio_handlers(d);
> >> +
> >>       if ( (rc = domain_io_init(d, count + MAX_IO_HANDLER)) != 0 )
> > IMO it might be better to convert the fixed array into a linked list,
> > I guess this made sense when Arm had a very limited number of mmio
> > trap handlers, but having to do all this accounting seems quite
> > tedious every time you want to add new handlers.
> Yes, I think we need to do so, but this improvement was not meant
> to be in this patch.

Ack, just wanted to raise that this model seems to be getting more
complex than just setting up a list.

> >> diff --git a/xen/arch/arm/vpci.c b/xen/arch/arm/vpci.c
> >> index 76c12b92814f..6e179cd3010b 100644
> >> --- a/xen/arch/arm/vpci.c
> >> +++ b/xen/arch/arm/vpci.c
> >> @@ -80,17 +80,51 @@ static const struct mmio_handler_ops vpci_mmio_handler = {
> >>       .write = vpci_mmio_write,
> >>   };
> >>   
> >> +static int vpci_setup_mmio_handler(struct domain *d,
> >> +                                   struct pci_host_bridge *bridge)
> >> +{
> >> +    struct pci_config_window *cfg = bridge->cfg;
> >> +
> >> +    register_mmio_handler(d, &vpci_mmio_handler,
> >> +                          cfg->phys_addr, cfg->size, NULL);
> > I'm confused here, don't you need to use a slightly different handler
> > for dom0 so that you can differentiate between the segments of the
> > host bridges?
> >
> > AFAICT the translation done by vpci_mmio_handler using MMCFG_BDF
> > always assume segment 0.
> You are absolutely right here: I can set up hwdom specific
> handlers, so I can properly translate the segment.
> On the other hand, when virtual bus topology added, the SBDF
> translation from virtual to physical SBDF resides in the Arm's
> vpci_mmio_{read|write}, like the below:
>      if ( priv->is_virt_ecam &&
>           !vpci_translate_virtual_device(v->domain, &sbdf) )
>              return 1;
> (BTW Jan asked in some other comment why it is Arm specific:
> I tend to keep it Arm specific until the point when x86 wants that
> as well. Until that point the code, if moved to common, will be
> unneeded and as Jan calls that "dead")
> So, I think that I can extend vpci_mmio_{read|write} to account
> on the hwdom like (virtual bus code is the future code):
> 
> static int vpci_mmio_read(struct vcpu *v, mmio_info_t *info,
>                            register_t *r, void *p)
> {
> ...
>      struct vpci_mmio_priv *priv = (struct vpci_mmio_priv *)p;
> 
>      if ( priv->is_virt_ecam )
>          sbdf.sbdf = MMCFG_BDF(info->gpa); /* For virtual bus topology the segment is always 0. */
>      else
>      {
>          sbdf.sbdf = MMCFG_BDF(info->gpa);
>          sbdf.seg = priv->segment;
>      }
>      reg = REGISTER_OFFSET(info->gpa);
> 
> ...
>      /*
>       * For the passed through devices we need to map their virtual SBDF
>       * to the physical PCI device being passed through.
>       */
>      if ( priv->is_virt_ecam &&
>           !vpci_translate_virtual_device(v->domain, &sbdf) )
>              return 1;
> 
> Will it work for you?

Right, I guess it could work as long as the differences between the
hardware domain and the unprivileged ones are not too big.

The nice part about having different handlers is that you avoid a
bunch of conditionals (ie: no need to check for is_virt_ecam) which
makes the code easier to follow. OTOH it could introduce more code
duplication.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Mon Oct 25 13:46:37 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Oct 2021 13:46:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.215876.375281 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mf0J8-0001kK-8m; Mon, 25 Oct 2021 13:46:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 215876.375281; Mon, 25 Oct 2021 13:46:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mf0J8-0001kD-4s; Mon, 25 Oct 2021 13:46:34 +0000
Received: by outflank-mailman (input) for mailman id 215876;
 Mon, 25 Oct 2021 13:46:33 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=G2Ub=PN=citrix.com=roger.pau@srs-us1.protection.inumbo.net>)
 id 1mf0J7-0001k7-FO
 for xen-devel@lists.xenproject.org; Mon, 25 Oct 2021 13:46:33 +0000
Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 6afeee6e-385f-442c-8fad-4ac414c064f6;
 Mon, 25 Oct 2021 13:46:31 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6afeee6e-385f-442c-8fad-4ac414c064f6
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1635169591;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=/DBKMZs0aA4zw6WSJTSZjla/q+pUYVqmhr5UKfSG3k0=;
  b=S6S0aBQn9wTGE7jiZlJrDn51KGnjXgibMGfrDorbpnLUp5eMN+9xicJz
   DryTB3utCE00y27DwRy5jJDvWdCEIyNdOojNDtZzp9AGTGR+DHotqrc+A
   zVK4vIZqpPRLMo+cNxSZEzrJ8o/7ONAnTVfvHRCeSisgKQoIKIfNRad5/
   M=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: PwBPMnbxubQsYOcLaIagNtn4GwZBb+NjNy7d6+s2v59Hy1u8M6GEilUJ2RRCYioXFYNjY27LxZ
 JmqmD4oVDPXlyB15GJ4eSodEmQkLVxmbrLuoXqMrx1IERM4sIb1RxUMRx1jT2OTBARZkTA26gR
 3aq01jSHjs5dOvOCW0EGEpAPmCh6pzr5rV3N883iXWxZlW015Orivqf1dAfxn7wOL/7QUaubcL
 CCUstlcgVX4gjzoRZZo2xgh161h/rxws/pVfqPW24C8UtmUf42RdeWXbh2VCmXipqnvQ2zDy9s
 QF2YFW5kWU2y8P0NlnIUWGyJ
X-SBRS: 5.1
X-MesageID: 57903427
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:xw6T4qzFSYhp53ih4HR6t+f+wCrEfRIJ4+MujC+fZmUNrF6WrkUDy
 TZLUGGHPf6OazHwKdoiYdnj8kgBsJ6Hx4cwTwVtrSAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx
 59DAjUVBJlsFhcwnvopW1TYhSEUOZugH9IQM8aZfHAuLeNYYH1500s6w7Rk2tcAbeWRWGthh
 /uj+6UzB3f9s9JEGjp8B3Wr8U4HUFza4Vv0j3RmDRx5lAa2e0o9VfrzEZqZPXrgKrS4K8bhL
 wr1IBNVyUuCl/slIovNfr8W6STmSJaKVeSFoiI+t6RPHnGuD8H9u0o2HKN0VKtZt9mGt4t4l
 fAV7p6PcEA4brHvmMpaDVpiOBgraMWq+JefSZS+mcmazkmAeHrw2fR+SkoxOOX0+M4uXzsIr
 6ZBbmlQMFbT3Ipaw5riIgVort4kI8TxepsWp1lrzC3DDOZgSpfGK0nPzYIHjW9r2poRdRrYT
 +AXNSdoQhXOXxNWZA5UVcscueavr3aqJlW0r3rK/PFqsgA/1jdZyrHtLd6TYd2MSsV9l1yd4
 GnB+gzRCBwAKMaWzzbD93u2n/LOhgvyQodUH7q9ntZyiUCX7nweDlsRT1TTifuzh1O6WtlfA
 1cJ4Sdopq83nGSpQcP6RAaQu2Ofs1gXXN84O+wl6imdx6zM+QGbC2MYCDlbZ7QOndUqSDkd8
 06GltLkGxRiqLSQD3ma89+8ry62OCUTBX8PY2kDVwRty8nupsQ/gwzCSv5nEbWplZvlFDfo2
 TeIoSMiwbIJgqYj8KG2/kvOhT62kbHPQhQo/QXcXm+j7QRRaZasYsqj7l2zxchHKIGVX1yQp
 k8uksKV7P0NJZyVnSnLS+IIdJmO4/uGKzTajURYI4g69z+t9nigeqhd+Dh7YkxuN64sYiT1a
 UXevQdQ4p57P3awa6JzJYWrBKwXIbPITIq/EKqON5wXP8Y3JFTvEDxSiVC4hGmwtRB3k54Gf
 obLbeWsIzFESp5M9W/jLwsC6oMDyic7zGLVYJn0yRW7zLaTDEKopac53EimNb9hsvvVyOnB2
 5MGbZHSkkQAOAHrSnCPqdZ7ELwcEZQs6XkaQeRsfemfPhEuJmglD/LAqV/KU904x/oL/gskE
 3fUZ6O59LYdrSCfQelpQio6AF8KYXqYhSljVRHAxX7yhxAejX+Htc/zjacfc7g97/BExvVpV
 fQDcMjoKq0REWmeo2xHPMGl9twKmPGXaeSmZXrNjN8XJMYIeuA00oW8IluHGNcmV3LfWTQCT
 02IiVqAHMtrq/VKB8fKcvO/p25dTlBG8N+eq3Dge4EJEG21qdACA3Wo0pcffpFdQT2el2Dy/
 1vHXn8lSRzl/tZdHC/h3vvf8e9E0oJWQyJnIoUsxe/nZXeBpjH4n94ovSThVWm1aV4YMZ6KP
 I195/r9LOcGjBBNtY99GKxs1qUw+53koLoy8+iuNC6jg42DBuwyL3+Y89NIs6ERlLZVtRHvA
 hCE+8VAOKXPM8TgSQZDKA0gZ+WF9PcVhjiNsqhlfBSkvHd6rOidTEFfHxiQkygBfrF7B5won
 LU6s8kM5g3h1hdzaoSajjpZ/ninJ2AbV/l1rYkTBYLm01J5ylxLbZHGJDXx5ZWDN4dFPkUwe
 2fGj6venbVMgEHFdiNrR3TK2ONcg7UIuQxLkwBedwjYxIKdi6ZujhNL8DkxQgBE9Tl90rp+a
 jpxKkl4BaSS5DM01sJNaH+hRlNaDxqD902vl1ZQzD/FT1OlX3DmJXEmPbrf51gQ9m9Rc2QJ/
 Lycz2q5Az/mcNuog3k3UE9h7ffiUcZw5kvJn8X+R5aJGJwzYDzEhK6yZDVX90u7UJ1p3ECX9
 /N3+OtQaLHgMX9CqqI2PICWyLAMRU3WP2dFW/xgoPsEEGy0lOteAtRSx5Rdov9wGsE=
IronPort-HdrOrdr: A9a23:RuXvT6tgBq2FfMi1D9o9s4I47skC+YMji2hC6mlwRA09TyXGra
 6TdaUguiMc1gx8ZJh5o6H6BEDyewKnyXcV2/haAV7GZmjbUQSTXfhfBOfZsl/d8k7Fh6NgPM
 VbAtBD4bTLZDAQ56ubkWqF+r4bsZ66GcuT9IPjJgJWPGdXgtZbnmBE42igYyhLbTgDIaB8OI
 uX58JBqTblU28QdN6HCn4MWPWGj8HXlbr9CCR2SyIP2U2rt3eF+bT6Gx+X0lM1SDVU24ov9m
 DDjkjQ+rijifem0RXRvlWjoKi+2eGRhOerNvb8yvT9GQ+cyTpAo74RGYFqiQpF4d1HLmxa1e
 Uk7S1Qe/iboEmhA11d6SGdpzUIlgxerUMKgGXo/kfLsIj3Qik3BNFGgp8cehzF61A4tNU5y6
 5T2XmF3qAnRC8osR6NkOQgbSsa4HZcYEBS4tI7njhaS88TebVRpYsQ8AdcF4oBBjvz7MQiHP
 N1BM/R6f5KeRfCBkqp9VVH0ZipRDA+Dx2GSk8Ntoic1CVXhmlwyw8dyNYElnkN+ZohQ91P5v
 jCMK5viLZSJ/VmJZ5VFaMEW4+6G2bNSRXDPCabJknmDrgOPzbXp5v+8NwOlZWXkVwzve4Pcb
 j6ISJlXF8JCjDT4Je1reN2Gzj2MRWAYQg=
X-IronPort-AV: E=Sophos;i="5.87,180,1631592000"; 
   d="scan'208";a="57903427"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ZUF+3i38K3dyWSUKOJcuF31XvJxydR8trmzR3afw0ZFzn0rMJebcHD6x2gCF1HDPInLalj0fJSUGjbIeTdSi9puvRi9/mOSMR98WEYRUDzFpmQWgcozJp9NDgFd7VfBL+dn/OKSJoyqzn7+c4Sxuhkyd1SZpWN7Ybfohq9QIAlEYY6fs35kMBOjU1C80cIr8SnofFwx76++bSFTWIi0Gp08wP88wYDmj8R/id80+meJk4vzi6Dgz3fRh54JMBt2uj/QIsbU3SNbLE0uAonACQgdVY1HXFvAnHNPo+8gah9089nnFYE3A27YbOwXnlCAcGaDTbl7ZE0SU5++k7ygVfg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=5Ty06Uj7JfE65tSUpt28Gf14m7X0EBKkraud9zrsoVs=;
 b=ZNQSIcaOu1eKwJF7cynoFkEjr45FlM2zwOngqOaRST2Adt8xHLttcc8MwGr53/hNlBQRsAWbgNqNUWOkkmdiVmG1eVwQQKdPZ3XbWj0UQjGCN+Lr5vv6x0d4iIfwDvye7JhWoo9FreVQFVJb25+e7lu3mddMdW04UtTCzjcxpjuztW/rUKtIIPMR9sTaKxoUwkdClbtxpTHjZQMxx6AA7/llxDxb1Uh3UPnWwzEfsVRqN0QeI5ojhnmqcaDsUJ+ZlCw4mqr6MvfDdZ4MelwpbCGvHTcc0v+1LMQLmD5GglPKoBMJeJ9xIDIKYlNV0VHyqjrqFw1RzzgEMouOWJN4hQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=5Ty06Uj7JfE65tSUpt28Gf14m7X0EBKkraud9zrsoVs=;
 b=LXgbC+x5KgYx0bEg+gQ6nzsr38DnWA64fpPkQa7hpuLiffMRU+zc0ANXYDI2+mM6bpIrZKNNE55CFOsfgJn/e5w8QNG2naR0isIsCV0n/ZL3xNTS2lX6EzpN63p5HoeGWNcx37TBHEVsQjz83hdZXCSkDJrUvKkY3K4AAosERJM=
Date: Mon, 25 Oct 2021 15:46:04 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	"julien@xen.org" <julien@xen.org>, "sstabellini@kernel.org"
	<sstabellini@kernel.org>, Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Artem Mygaiev <Artem_Mygaiev@epam.com>,
	"andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
	"george.dunlap@citrix.com" <george.dunlap@citrix.com>, "paul@xen.org"
	<paul@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>, Rahul Singh
	<rahul.singh@arm.com>, Ian Jackson <iwj@xenproject.org>, Juergen Gross
	<jgross@suse.com>, "jbeulich@suse.com" <jbeulich@suse.com>
Subject: Re: [PATCH v5 07/10] libxl: Only map legacy PCI IRQs if they are
 supported
Message-ID: <YXa1HBMCMQUDr++2@MacBook-Air-de-Roger.local>
References: <20211008055535.337436-1-andr2000@gmail.com>
 <20211008055535.337436-8-andr2000@gmail.com>
 <YXavl0e0zainVKT9@MacBook-Air-de-Roger.local>
 <3de59765-6bcb-d6a1-7e23-2b85123df71d@epam.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <3de59765-6bcb-d6a1-7e23-2b85123df71d@epam.com>
X-ClientProxiedBy: MR2P264CA0148.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:501:1::11) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: ac82045a-35de-4f85-2c27-08d997bdcd93
X-MS-TrafficTypeDiagnostic: DM6PR03MB4681:
X-Microsoft-Antispam-PRVS: <DM6PR03MB468136CCE4083E640E48E5428F839@DM6PR03MB4681.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: SKv0xCkCv/kBHALFlMY0e5nWRkCW0DUMcQtGOaxzcxrrIE7y7bmgS222aSJlvSZTC2SoWFoYTXq457JEdque8uJzoHWJeMek0iKt2SvSBu+JkluPossGcWoCTz418KPa9Sv55Ej58HmIjIRV4MyFuYpEkBL5ghp3vEv/jQ78irB4CoSmh1viZCPahEjrevCUeFsnyOKff1YaSzprJqjt+Nn6Sna8s/4/vmX07vlB3JUX4QNEeBs7YZGQ1ZGr1y0qK2sXi+q5GRW7MpbID3GcoX9hda5rlEwWpWdD26ejkwsu9bTibdS7meUjj0Lk8G99974ZxbtqupJ1Ec8oehruk8iwMZPYSaEkpfSdXPK9sDeB29tNtxgXrkGDqIv739vhFlscPjEjL9rseWx4Elms8t9M1U/VhFRFBcYV7TD5MOrwQq09o+Hqa2Uv+E0RoJhB4shJSEoVUPH8rDHiaXjQ+RLjjC+wweQyUvbns+lmkyBm6Sm+YSKGnJRE+21ZsFu457mGmrQ6r/fwZ/IXm8AIBXcjQGXezTweFek9385kKTAwrN6FSr3q+//bdcC4K/JxbfMzg3TQbAueiD6yIM2zQZNe6k3YjxkA5bsuNi+IBkMdTDzGZDJJy5tlg1D/eNQrNQTUtwCaXpImtWa0tqro5A==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(6916009)(4326008)(508600001)(53546011)(956004)(8676002)(186003)(6486002)(66556008)(2906002)(66946007)(26005)(66476007)(85182001)(54906003)(316002)(82960400001)(86362001)(7416002)(5660300002)(6666004)(6496006)(8936002)(38100700002)(9686003);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K0pGaWJ4aGowRWpsUXJDUm1Lb0IxbmJwYzMxWjRSR29Ocy9OV0dLQTRJMnZ4?=
 =?utf-8?B?YkNpdnhjMkI3SW4vQy9FMFNsVjdic1ZPeUdNbU9WRlN3ZmhPWHdYVU5RcmpM?=
 =?utf-8?B?YVhYU1dvOUxLeSt5YkVzVXVUM2lIMHdENmxpMzU0Z081clFLbjRyajAzOWpx?=
 =?utf-8?B?Mkl5Z05YNHQzZ0pwWE1rRk5MZmJ1c1RSMWd0R3dKNlRhdEVWVU1rRnc1Mll4?=
 =?utf-8?B?UFUrMmRvRTlZbEcwcFIzQTB0V1dyMEtnRHdDSGpzYnlybkJ0eVlHdTFDd0JM?=
 =?utf-8?B?WVR4UVR6bnE0T0YwT1QzTHlEUmJYc0NzOFErUG9FYW9IOWZGQ0VDODN6WE5Z?=
 =?utf-8?B?Z1lkMFVxS1R1d1dJSkhEbzJVd1dHWm1vc2tiZG9oRWxXTXpPRjlQS3dQcHhh?=
 =?utf-8?B?Tkc5aXE2THdXZUZIQWJ5SEoxdjBPb1V6TUk3ako2UU1UR205OU5tcWRQekZP?=
 =?utf-8?B?WWJJZ2FudVh6VlhPZ0YrSzBVU3RJdUpHU0l0THZtUnFETDRSWit1MjZONVpG?=
 =?utf-8?B?cHc5SkFTZDBOYlNteWVNMEEvSTZyMlhQNk5IVEVxKzF5dW5HeFQzdkpldzlz?=
 =?utf-8?B?NVJ4QW9hRDk2bU5oVVJuNVFHaWNtb04xUGhFSU1PSEhjd2JyZW1PREtFZWxj?=
 =?utf-8?B?TVdGWTRleG1hR1gvUHpLZG5ucDhwazZMeTFIQ1d3aHJVTkE0d0hFd3JMb0I1?=
 =?utf-8?B?bGw4MzIyMDR1YjBlZTRyZlRWR1MwM0NUU2tlMnU2b1QwVjZRanRiUjNqZ2FS?=
 =?utf-8?B?T3NmN1BrRGU0amcwby9WUjJLMHlPU3FqVlo4bkZDQjFkK25kWi9NQkkyUUZL?=
 =?utf-8?B?ZlYxVVkvdDFwNjNPUVdqSUZvZkM2N3pDRXMzZk5icWJzbS9zNURCaXRoWU1R?=
 =?utf-8?B?WU9vRnZjWUVTK3M1MVdIcFYwaStOd2F1VU1wSVdYc0tVbjFkb1dVSjVJVGEx?=
 =?utf-8?B?Z3JVejVnQTdSMzlrblAybjBxMWNlUDF4SXFCSXJwaFFRZXZETWUrbHczMzhP?=
 =?utf-8?B?VzUyYzNNbUVMaVptRzVILzNyc21ZOTkwUHFXaTAyMVovNU53eDVyK0t1WWZM?=
 =?utf-8?B?dmdjVEtTMkEyM3F3d2gvYnN4UXhwODNxZjZ5K242c0M4T1dPcGRpYzBJdDhP?=
 =?utf-8?B?VTBnc0k2cVZuUjl0YWJoNmg0Zm9QWlYzaXZvSFpvRTJuNHFoYm40VkZyRldT?=
 =?utf-8?B?SjBoOVUyWmlVd3FoZDFWbW11V2NOeHkxbms4clRkVGxqUUdFdG1VY1dkZ1Ba?=
 =?utf-8?B?UHhHcFdWMm0ya0NFMmVQbUhrMThoNHU1RjBhWXhMWDBoOFovNUg4S01aSlJG?=
 =?utf-8?B?ZDZ0K1BHcjZiUW5rdDhNSE5FcnVhUlF5T25zMUhUUy9FMUNCQ21WdTd2RGFB?=
 =?utf-8?B?QU9xamM1aGVEcXIzSHZUN0xyZnk1MGU1Qm1VUnhsWXNCWFlVY3Z2UEx0NU1N?=
 =?utf-8?B?cUZBZlBZbzRPd2lMdVkzVmxsaEwwWEVwSWR0b00yV3JjdGdYanI1SG80MDRk?=
 =?utf-8?B?VHVPK1F6clNtcVpsYWZWWkdSUjJ5S0ZEZitmb0JjeTRJWUEvQjh0ZUk0NUl2?=
 =?utf-8?B?Y3RNdmxaMkw1bGlsUzdsWkIrZE02eklrWTdYTmpsbHNQOWY3VlZnaVFMa3Vu?=
 =?utf-8?B?eFVRYlZ4NnRGSUZGdVZMM2dEWVBCMjdWWUlqQlBxTGQzaUhOcitqbkhlcWRY?=
 =?utf-8?B?a0tNeTF0bGJ4RWJpVDIraHdMMGIxZks1SU14SEVWTkVJR3l3Z0FlcDVYOGJ4?=
 =?utf-8?B?c2d0UGN4V3R0OUdueEhRZVJGanBpLzFKZ09sUXRpUWFsSTcyQzlvaXA3eVNp?=
 =?utf-8?B?UDVzV05UUitIcnFlZ0hEMEh4bzVEbFFqM1AvSVNRVUh2RUp0Ujd5NStSSHJl?=
 =?utf-8?B?akhEYU10MmtqMUV1NXYxV2tNWDdwdk0wOEhNRVF0bENwVE85UzZtdUVuc3JV?=
 =?utf-8?B?TU9QTVpmTEhPSXhTeEVjRHY4Z0p6VFlWUk1JSmVtYngyK3BLU0pXU3ZFajVU?=
 =?utf-8?B?T1hZV001aDBHeWFaM3FTN3NSbzV3SWN0MytBMnNTZysrTEd3eDE5ZWZRSi9m?=
 =?utf-8?B?bDRNeHArL2VVYmQ3ajJTZEtJbjMxV3ZlbkRtOGZIeFhvL0FJK3FwU01MUzJ2?=
 =?utf-8?B?U3ZlZk0zYXFLNGsydG04Z0d5bnJEMXprUjBjVGJrOUQ2c3BnZ3cvdU13d2dG?=
 =?utf-8?Q?sqqqos4+KSrZ35ojvZqRIT0=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: ac82045a-35de-4f85-2c27-08d997bdcd93
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2021 13:46:10.4607
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: wBbC4sb4bPRDm72EbJ7cs7vAMM2NDpOBEKnu1RXr+be61gNLTcBrlPdVw++XEMDtcW9SQrTJ2tjy3wDJoCvBxQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4681
X-OriginatorOrg: citrix.com

On Mon, Oct 25, 2021 at 01:38:19PM +0000, Oleksandr Andrushchenko wrote:
> Hi, Roger!
> 
> On 25.10.21 16:22, Roger Pau Monné wrote:
> > On Fri, Oct 08, 2021 at 08:55:32AM +0300, Oleksandr Andrushchenko wrote:
> >> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> >>
> >> Arm's PCI passthrough implementation doesn't support legacy interrupts,
> >> but MSI/MSI-X. This can be the case for other platforms too.
> >> For that reason introduce a new CONFIG_PCI_SUPP_LEGACY_IRQ and add
> >> it to the CFLAGS and compile the relevant code in the toolstack only if
> >> applicable.
> >>
> >> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> >> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
> >> Reviewed-by: Rahul Singh <rahul.singh@arm.com>
> >> Tested-by: Rahul Singh <rahul.singh@arm.com>
> >> ---
> >> Cc: Ian Jackson <iwj@xenproject.org>
> >> Cc: Juergen Gross <jgross@suse.com>
> >>
> >> Since v1:
> >>   - Minimized #idefery by introducing pci_supp_legacy_irq function
> >>     for relevant checks
> >> ---
> >>   tools/libs/light/Makefile    |  4 ++++
> >>   tools/libs/light/libxl_pci.c | 13 +++++++++++++
> >>   2 files changed, 17 insertions(+)
> >>
> >> diff --git a/tools/libs/light/Makefile b/tools/libs/light/Makefile
> >> index 7d8c51d49242..bd3f6be2a183 100644
> >> --- a/tools/libs/light/Makefile
> >> +++ b/tools/libs/light/Makefile
> >> @@ -46,6 +46,10 @@ CFLAGS += -Wno-format-zero-length -Wmissing-declarations \
> >>   	-Wno-declaration-after-statement -Wformat-nonliteral
> >>   CFLAGS += -I.
> >>   
> >> +ifeq ($(CONFIG_X86),y)
> >> +CFLAGS += -DCONFIG_PCI_SUPP_LEGACY_IRQ
> >> +endif
> > TBH, since CONFIG_PCI_SUPP_LEGACY_IRQ is used in a single place in the
> > source I would consider just using CONFIG_X86, as I think it would be
> > clear enough that some arches support legacy interrupt while others
> > don't. Not sure it's worth going through the obfuscation of defining a
> > separate one.
> The idea behind not using CONFIG_X86 is to be arch agnostic,
> so CONFIG_PCI_SUPP_LEGACY_IRQ makes more sense with this
> respect

I'm not going to insist, but you could have avoided modifying the
Makefile at all by just using:

static bool pci_supp_legacy_irq(void)
{
#ifdef CONFIG_X86
    return true;
#else
    return false;
#endif
}

Which IMO is clearer than the current approach since it's a single
place where CONFIG_PCI_SUPP_LEGACY_IRQ gets used.

> >> +
> >>   SRCS-$(CONFIG_X86) += libxl_cpuid.c
> >>   SRCS-$(CONFIG_X86) += libxl_x86.c
> >>   SRCS-$(CONFIG_X86) += libxl_psr.c
> >> diff --git a/tools/libs/light/libxl_pci.c b/tools/libs/light/libxl_pci.c
> >> index 59f3686fc85e..4c2d7aeefbb2 100644
> >> --- a/tools/libs/light/libxl_pci.c
> >> +++ b/tools/libs/light/libxl_pci.c
> >> @@ -1364,6 +1364,15 @@ static void pci_add_timeout(libxl__egc *egc, libxl__ev_time *ev,
> >>       pci_add_dm_done(egc, pas, rc);
> >>   }
> >>   
> >> +static bool pci_supp_legacy_irq(void)
> > A naming more inline with the PCI specification (since we insisted on
> > using ECAM instead of MCFG) would be intx, ie: pci_supports_intx.
> This will require a follow up patch if we all agree this change is needed.
> @Jan, are you ok with the rename?

Didn't realize it was already committed, in which case I guess we could
leave it as-is.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Mon Oct 25 13:47:22 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Oct 2021 13:47:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.215882.375292 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mf0Ju-0002L1-Li; Mon, 25 Oct 2021 13:47:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 215882.375292; Mon, 25 Oct 2021 13:47:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mf0Ju-0002Ku-Ie; Mon, 25 Oct 2021 13:47:22 +0000
Received: by outflank-mailman (input) for mailman id 215882;
 Mon, 25 Oct 2021 13:47:21 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=1v/+=PN=epam.com=prvs=0932af52eb=oleksandr_andrushchenko@srs-us1.protection.inumbo.net>)
 id 1mf0Jt-0002Ki-Cd
 for xen-devel@lists.xenproject.org; Mon, 25 Oct 2021 13:47:21 +0000
Received: from mx0a-0039f301.pphosted.com (unknown [148.163.133.242])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 1294bc0c-359a-11ec-840f-12813bfff9fa;
 Mon, 25 Oct 2021 13:47:19 +0000 (UTC)
Received: from pps.filterd (m0174677.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 19PCY7Ml013687; 
 Mon, 25 Oct 2021 13:47:18 GMT
Received: from eur05-am6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2113.outbound.protection.outlook.com [104.47.18.113])
 by mx0a-0039f301.pphosted.com with ESMTP id 3bwvjjrbrs-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Mon, 25 Oct 2021 13:47:17 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by VI1PR0302MB2832.eurprd03.prod.outlook.com (2603:10a6:800:e2::15)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.20; Mon, 25 Oct
 2021 13:47:15 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::c038:e032:595a:651]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::c038:e032:595a:651%8]) with mapi id 15.20.4628.020; Mon, 25 Oct 2021
 13:47:15 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1294bc0c-359a-11ec-840f-12813bfff9fa
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=GwCcdh47L8HAA3NgVYMpszVp7CNwnSdAJVWreTuguCsEAbxrC9VKCyWZD60cv71lvpUBKL/Q0QtGmH2wjzm5c9MqABPKyfGfP/ieD4cIYw1e5LJs1phdezt8ElN9Cof/9/gjBbnGfKunaIxNtEiGNxvYGRfHJrpp3OD/4X0nnwArfDPxKoHKdyDKeYDFLv0rLe8vtOrwLwlcizEUUpFK6cCG/YkVXyKGNxwktMs7EH4nwFS3IHYTKJ9yqoNFk8pHK76KAt/tgGz8b1lZV0iDLJKWMBGqrh4u34cn/ekaMvbgUsCcayUg+oVXih9hQHEq0q+rwAxTu2OMNQtXHYrqfg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=xyg6wsPFRMKyT8ZrUCcaCtMv3wa/bgZZNuZA7Gj9kpE=;
 b=IzXD7ksWT7y+Cd5ZweW3ps1hhfyKFaUP+SQYayrRvOI6DWKByCpmCJt4FuyPJ642oNqcugG9vffUaC8sqmgFipWHYLQRatZIPffLDEvcdqY/HaUYrWAEgAvEn2E0yWOZHnk67zaqJ3CVp0n/4bxwpNdEKGq6/biiowgy5voFe0iqWsIbf3532jAiHwB5gT8uG7BWzGL7KcJZSS3aPtQtrGP7ULKfR8mddIHlYq666OGWiUY8J0UXMPTDNRgRvfhj2wUsGoDV8qcmWAX37P9BrFmtFhTuGCqWzy/sAyK1Z/cR7KK/qRegQlhPz92BoxPwFFBCjeV7GQHY0gAufxDcHg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=xyg6wsPFRMKyT8ZrUCcaCtMv3wa/bgZZNuZA7Gj9kpE=;
 b=jJbIqTQhhNOd+zivgIOdkwmibDo1azdKcECkrvASoISaKYP4JYk5SuLKrntyzdYpJAtRdetWkW+l1ki8i70vUBfaZtuMvC30SobGcTGboMi+P0M/QN9bWNEvBYkve23n6U4CmzRXxiz5logCVn1c8ktvd5cNQJ6pUrfCiwuWeya1S6VLDxon4cq9UK9PyXCEhgqPnoAiaV84LJqJkB/GaPpjmx6L1rm8n7Lfztw4wa1KsIcL5lPdBsOPBp0eTJG9j65340UiltADMNHpKdJaIJAbOkJjaR44dCartGTzLN7Jbe+yMcp3BnIh1WbKaCRpnUlEZ9reYNIHi6UAcgBfkQ==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org"
	<sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "jbeulich@suse.com" <jbeulich@suse.com>,
        "andrew.cooper3@citrix.com"
	<andrew.cooper3@citrix.com>,
        "george.dunlap@citrix.com"
	<george.dunlap@citrix.com>,
        "paul@xen.org" <paul@xen.org>,
        Bertrand Marquis
	<bertrand.marquis@arm.com>,
        Rahul Singh <rahul.singh@arm.com>,
        Oleksandr
 Andrushchenko <Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH v5 08/10] xen/arm: Setup MMIO range trap handlers for
 hardware domain
Thread-Topic: [PATCH v5 08/10] xen/arm: Setup MMIO range trap handlers for
 hardware domain
Thread-Index: AQHXvAknAgtt9sKLd0u6OFwp+HT0w6vQvTaAgBLStoCAAEPJAIAAAdoA
Date: Mon, 25 Oct 2021 13:47:14 +0000
Message-ID: <22f298b7-c502-ff15-3796-117f3599bf7e@epam.com>
References: <20211008055535.337436-1-andr2000@gmail.com>
 <20211008055535.337436-9-andr2000@gmail.com>
 <YWawvYGqIe3DwZfI@MacBook-Air-de-Roger.local>
 <7f2a5875-69c9-b40b-287b-1355698598e5@epam.com>
 <YXaz1G1mvHzZHdxM@MacBook-Air-de-Roger.local>
In-Reply-To: <YXaz1G1mvHzZHdxM@MacBook-Air-de-Roger.local>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 4a9d9266-cf8d-4b94-cf8c-08d997bdf432
x-ms-traffictypediagnostic: VI1PR0302MB2832:
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <VI1PR0302MB283280E4E746D69A93F00653E7839@VI1PR0302MB2832.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:425;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 pOsZWwDrtZofDQDJn3RpV1pNtS1aWuIkOU0UjY0RM8vQatGo34t7XGF52dD9uKPXFh5GCh3XyDt3KRcLXhnpky+E01FNDNfYpvgA2e56nepo6vad7rbwfKylMh2KuH3Tf8eH6XWdvkBXgnrdMyNoe9QGX3jemi7f5ZWAeVT5Uc+gzDiX13TEpZBtzcUwvb2Ju8ru3UHvPWuzn4IA6gzc55ckcwi1LRt12wznj2DSLmw4L7rZwhRAbpS4dbcqohRQCY0fyK67lBkJh9cpvNcuaUTcE2ezsrAokn9vxWvHBwRbLpynzBrzffkEDbYe/F04Sy02fcSSK50wxRjtujjVN6Ua4M4Rw/XDL1LYMlBivdYzn21hVRthc+AzERMfyJFf9apvkAB5aYS0Rwx5eZm1PviuBve66chHeqX5GdBVXnmh5Ew0EICefTsnJRNGGr4O9U6yopHzvx/ABqPzeHWGGdRDdIQ/ac5uL8EZ0wVAqvilFW0B+QTq3h+xxi9YJbpQDgmW1AA4t5M/i7uHgra9jRFL6naiFdDOEtXmGT2j8AN8pkedQN7vAMEldjhN34xI5zs8E8KbVjdAIzhW5TcYfgNiWl6WoLxGRD/jVVX2OArhid3Kt7gAKLtd+p5m+uNt+knaMrUIuOsY/iBNCiXJYiEocY3ywXSoA3Jbgp7/UDjB+n7E5LVyyok2tOHsvpoyvy66bRJFYbVZ2doVYzjq7jnyT58QgmPdNp7ISKcPsN/1CkOaYdyI/MRX4vqJ+cfo
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(6486002)(31686004)(38070700005)(66556008)(86362001)(316002)(107886003)(6512007)(76116006)(66476007)(6916009)(38100700002)(36756003)(2906002)(64756008)(6506007)(4326008)(54906003)(53546011)(71200400001)(508600001)(26005)(66946007)(122000001)(8936002)(66446008)(91956017)(186003)(8676002)(7416002)(2616005)(5660300002)(83380400001)(31696002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?OUwzTzJ6OFVGTzNsOElwZjRSdlZLQUYyWVJ5ZzNheXZucjFkSEVyMjlJc3ZS?=
 =?utf-8?B?SmFVaDBIRVFKblZNcjBOR1pGcVRUTitQdFMxZ1l0eHBwQVp4bi9MSFFiQ3dN?=
 =?utf-8?B?N1RZaTZnNGlPeFNSQXZyaFVWRGRQbW1SR1ZIV01tUEtwakxnSHlTSTNoZmFU?=
 =?utf-8?B?U0lyVjMzOGlkaUtDdmJxdGU1NUV2ZDc5NFkvMEJDMTBiRnJBajdUVnFtUTMy?=
 =?utf-8?B?WmZLRmt3QmtqUVd5WkZsV0IyODk0NFZUN25OZWtzZTV4ZlVQWTdiV0NNaHZJ?=
 =?utf-8?B?eUc2NVFHQ0tkZHlUeDg4WXMrVkZ4NDNqcmxkQ0tzSW9Ed3E5ZTFSR2lLa2w1?=
 =?utf-8?B?MnBOWXNqaDFYRThITVpKSGxLWEtDZmcxbThRdWZVZ2xRQWVqVGhZS0h6cmd1?=
 =?utf-8?B?c2Q0WnZOMnhlOW9MRUZEdkpJbzhEakIvcmllcWp5ODkyL2dLWHRSUUVzWTdj?=
 =?utf-8?B?YlVjUlk5YUFiVmdlTlZVRXdBb2VRVmJwWExWVUlJbXFFN0JKM2dTd25pVm9h?=
 =?utf-8?B?eCt1K09zUFkzSVhhVjZ6RWl0cnVKM244azcxMGFYZmhSMUw3VTAzL3FxU2wr?=
 =?utf-8?B?anA2ckQxb1UxRGYwMmx2RFo3bVNwQ3h5UXlkMnBrMFA1eWIrbFlxYm5mZGVK?=
 =?utf-8?B?ejRPS2tJTmFnVlVTeWt4M0Y4T2xoUkUweWJ1ODZ3emQwS25NLzlxb2RNb3NF?=
 =?utf-8?B?anlTSFJQcW5ncjhPL3oxMHVIU2hUZXlzcEJTWGhDQ1NXOVpBWXVjalBBV2dH?=
 =?utf-8?B?QVpPc2t0RjU4VUVWd256dDBrcVh2VEpFRitkVFNoUHpmMGdDZ2J2T1ZwdmVM?=
 =?utf-8?B?Y0R0ejFiYnM2MWRnY2JTTHNVNm9NeFdoQ1J5c25sQ3JtRW1jT3ZxK1lBOTdB?=
 =?utf-8?B?WFpnSmhQWVA2VmdONzkxV1ZjRjIzVUlPZ1Vua0FzcHdPanQrZVZTbXg5MGJ6?=
 =?utf-8?B?RTE0SjRIOE5ubkNXQnZmM3cwYkp3U1JSRHVBU0IxNWJya2h2Z0o0d2phUTRv?=
 =?utf-8?B?a0s1MFZHT1BGOStyWVJIZjQ0NytQaEtBTEU1UUVMbWp0NjVuUUxKZzlMTzZx?=
 =?utf-8?B?RkRZM2hNRU8zTENRMmNIQlRGcUh6bCttY1ZtZEVZdG5PZ2hId1NONkRSKzJQ?=
 =?utf-8?B?eGh2OUhFMTdRc2U5R0U3bmJKaWs2NFJDNFJIeXg2MG9sNFVRMHkwNTJzVkpS?=
 =?utf-8?B?VWNRMFhvSDNINzFjVk8zYlBrMkZuSDc1RFJTNHkvUi9Fam9Zc3hvc1BFazlQ?=
 =?utf-8?B?eEUxZFdZQWUxY0UxM21CdHhlVXF4NzAvTHVhWVoxYmM1eHE1NHpsQnhydlcz?=
 =?utf-8?B?b3ovbGFMZDhpU29kV0JxU0JmdjNYYlIrRUpjTXE3QkdtSXNPY2didmZhNGc3?=
 =?utf-8?B?SVR5Zk9nWXpoczlSU2FCQ1pZMGx2MFlrQ1pvTmtibFV3bHN4ZC9uS0ZxNUhT?=
 =?utf-8?B?WHdMaHJCZGJ6VzZvaEFGZTVTQytuRUNKdTYwZFc1VXFpOE82UzNKSk0wU2pO?=
 =?utf-8?B?UkE2Yks1NkNBL3hJMUdQL1FiMUZQWHphSzI2TThTQm5iT05hMDJFdk9jbVhK?=
 =?utf-8?B?OXpIbGZVYS9XMEc1UFVFSnp3L250bGw4enJDMlBKQXF6UUZaK3pBV0NCQnlv?=
 =?utf-8?B?UGpxQWhJczRnNUNoRldlSHBGSm5heDlPSjZNTzh1SVZYTzdCQ0huSmhiRCtR?=
 =?utf-8?B?aWg5L1NBTk9wNUFUVnVsSVFDdWxZZ0xuWXNSa1pZV1hFS0w5SG9FMEs0NEpu?=
 =?utf-8?B?SVhwYUZoZG5sU2Rrb1BTSWZEZjRQcnVCVUY5blNMNFZBYWVRaUJQdzV0ODdz?=
 =?utf-8?B?TW1uQTlmVkU1aHVqMVY4Wm4yRGdoU2gzRk96T1VxOFJNcHhSc2JlbFl4Q1R3?=
 =?utf-8?B?M1dla1RJOXorUnVQdS9iTkdRczhtejNCMnEzNVBMRTFPMklyMWNzQmhoenU0?=
 =?utf-8?B?c2VZWVovWXBldGc1UThNOUhlVWx6S3RiYWZwQTlzMXNrbUU5WStpVW1ucmFa?=
 =?utf-8?B?VkM5VnJwRmJkRnk0Z05zVFhGMWM4MEI4eGIwWFJjSzVJc0ZjSWtBSUgvZVdU?=
 =?utf-8?B?UktqWG0yMjFTSUFzdmpnYi9Mb2gxUmJ5bEFyYTFCMXJsbkQ2aW5JYzQ4ckJZ?=
 =?utf-8?B?K255RUVIRTk3aElJdUgxQmx6RHRiWWZCVFlya2xmc1pCNTI1UjZia2pZL0ZY?=
 =?utf-8?B?aVRhcVp3VEJRaUtEbkZ4RjVCVTg4VExOZGd4QmhYTW9saFFPdllBajV2QVJr?=
 =?utf-8?B?MnFkbFg2c1pVeTJyOVFoUWUrV1d2R0hxY0tLQjdGb09zZ2pDZ1JXZzI1Q2Yx?=
 =?utf-8?B?L0VvRnlmWkpGRkVqVFVDQnRhb1NCbVN0dmxOdCs5QXloakxIdi9WZz09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <F321363DFFBF3E4EB0395F59B4C88A0B@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4a9d9266-cf8d-4b94-cf8c-08d997bdf432
X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Oct 2021 13:47:14.9696
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: xyucWh47CbJIrktIgwnNBh4NRDrIK2ypo8jW2e8Erd1Q3vCa0L1BmNGw7HUcrhj8FDfRGYC/NvYXe2PxHoX1SiYs8pdWUGx5kh5U8bXfBLusBcdFBwW2/TIJDNYDjrh5
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0302MB2832
X-Proofpoint-GUID: H4EsjWQTkvT46ppnfhbRQDSak0bQyaVz
X-Proofpoint-ORIG-GUID: H4EsjWQTkvT46ppnfhbRQDSak0bQyaVz
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475
 definitions=2021-10-25_05,2021-10-25_02,2020-04-07_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 bulkscore=0
 suspectscore=0 priorityscore=1501 spamscore=0 lowpriorityscore=0
 mlxscore=0 adultscore=0 clxscore=1015 impostorscore=0 mlxlogscore=999
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2109230001 definitions=main-2110250084

DQoNCk9uIDI1LjEwLjIxIDE2OjQwLCBSb2dlciBQYXUgTW9ubsOpIHdyb3RlOg0KPiBPbiBNb24s
IE9jdCAyNSwgMjAyMSBhdCAwOTozODowMEFNICswMDAwLCBPbGVrc2FuZHIgQW5kcnVzaGNoZW5r
byB3cm90ZToNCj4+IEhpLCBSb2dlciENCj4+DQo+PiBPbiAxMy4xMC4yMSAxMzoxMSwgUm9nZXIg
UGF1IE1vbm7DqSB3cm90ZToNCj4+PiBPbiBGcmksIE9jdCAwOCwgMjAyMSBhdCAwODo1NTozM0FN
ICswMzAwLCBPbGVrc2FuZHIgQW5kcnVzaGNoZW5rbyB3cm90ZToNCj4+Pj4gRnJvbTogT2xla3Nh
bmRyIEFuZHJ1c2hjaGVua28gPG9sZWtzYW5kcl9hbmRydXNoY2hlbmtvQGVwYW0uY29tPg0KPj4+
Pg0KPj4+PiBJbiBvcmRlciBmb3IgdlBDSSB0byB3b3JrIGl0IG5lZWRzIHRvIG1haW50YWluIGd1
ZXN0IGFuZCBoYXJkd2FyZQ0KPj4+PiBkb21haW4ncyB2aWV3cyBvZiB0aGUgY29uZmlndXJhdGlv
biBzcGFjZS4gRm9yIGV4YW1wbGUsIEJBUnMgYW5kDQo+Pj4+IENPTU1BTkQgcmVnaXN0ZXJzIHJl
cXVpcmUgZW11bGF0aW9uIGZvciBndWVzdHMgYW5kIHRoZSBndWVzdCB2aWV3DQo+Pj4+IG9mIHRo
ZSByZWdpc3RlcnMgbmVlZHMgdG8gYmUgaW4gc3luYyB3aXRoIHRoZSByZWFsIGNvbnRlbnRzIG9m
IHRoZQ0KPj4+PiByZWxldmFudCByZWdpc3RlcnMuIEZvciB0aGF0IEVDQU0gYWRkcmVzcyBzcGFj
ZSBuZWVkcyB0byBhbHNvIGJlDQo+Pj4+IHRyYXBwZWQgZm9yIHRoZSBoYXJkd2FyZSBkb21haW4s
IHNvIHdlIG5lZWQgdG8gaW1wbGVtZW50IFBDSSBob3N0DQo+Pj4+IGJyaWRnZSBzcGVjaWZpYyBj
YWxsYmFja3MgdG8gcHJvcGVybHkgc2V0dXAgTU1JTyBoYW5kbGVycyBmb3IgdGhvc2UNCj4+Pj4g
cmFuZ2VzIGRlcGVuZGluZyBvbiBwYXJ0aWN1bGFyIGhvc3QgYnJpZGdlIGltcGxlbWVudGF0aW9u
Lg0KPj4+Pg0KPj4+PiBTaWduZWQtb2ZmLWJ5OiBPbGVrc2FuZHIgQW5kcnVzaGNoZW5rbyA8b2xl
a3NhbmRyX2FuZHJ1c2hjaGVua29AZXBhbS5jb20+DQo+Pj4+IFJldmlld2VkLWJ5OiBTdGVmYW5v
IFN0YWJlbGxpbmkgPHNzdGFiZWxsaW5pQGtlcm5lbC5vcmc+DQo+Pj4+IFJldmlld2VkLWJ5OiBS
YWh1bCBTaW5naCA8cmFodWwuc2luZ2hAYXJtLmNvbT4NCj4+Pj4gVGVzdGVkLWJ5OiBSYWh1bCBT
aW5naCA8cmFodWwuc2luZ2hAYXJtLmNvbT4NCj4+Pj4gLS0tDQo+Pj4+IFNpbmNlIHYzOg0KPj4+
PiAtIGZpeGVkIGNvbW1lbnQgZm9ybWF0dGluZw0KPj4+PiBTaW5jZSB2MjoNCj4+Pj4gLSByZW1v
dmVkIHVubmVlZGVkIGFzc2lnbm1lbnQgKGNvdW50ID0gMCkNCj4+Pj4gLSByZW1vdmVkIHVubmVl
ZGVkIGhlYWRlciBpbmNsdXNpb24NCj4+Pj4gLSB1cGRhdGUgY29tbWl0IG1lc3NhZ2UNCj4+Pj4g
U2luY2UgdjE6DQo+Pj4+ICAgIC0gRHluYW1pY2FsbHkgY2FsY3VsYXRlIHRoZSBudW1iZXIgb2Yg
TU1JTyBoYW5kbGVycyByZXF1aXJlZCBmb3IgdlBDSQ0KPj4+PiAgICAgIGFuZCB1cGRhdGUgdGhl
IHRvdGFsIG51bWJlciBhY2NvcmRpbmdseQ0KPj4+PiAgICAtIHMvY2xiL2NiDQo+Pj4+ICAgIC0g
RG8gbm90IGludHJvZHVjZSBhIG5ldyBjYWxsYmFjayBmb3IgTU1JTyBoYW5kbGVyIHNldHVwDQo+
Pj4+IC0tLQ0KPj4+PiAgICB4ZW4vYXJjaC9hcm0vZG9tYWluLmMgICAgICAgICAgICAgIHwgIDIg
KysNCj4+Pj4gICAgeGVuL2FyY2gvYXJtL3BjaS9wY2ktaG9zdC1jb21tb24uYyB8IDI4ICsrKysr
KysrKysrKysrKysrKysrKysrKw0KPj4+PiAgICB4ZW4vYXJjaC9hcm0vdnBjaS5jICAgICAgICAg
ICAgICAgIHwgMzQgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrDQo+Pj4+ICAgIHhlbi9h
cmNoL2FybS92cGNpLmggICAgICAgICAgICAgICAgfCAgNiArKysrKysNCj4+Pj4gICAgeGVuL2lu
Y2x1ZGUvYXNtLWFybS9wY2kuaCAgICAgICAgICB8ICA1ICsrKysrDQo+Pj4+ICAgIDUgZmlsZXMg
Y2hhbmdlZCwgNzUgaW5zZXJ0aW9ucygrKQ0KPj4+Pg0KPj4+PiBkaWZmIC0tZ2l0IGEveGVuL2Fy
Y2gvYXJtL2RvbWFpbi5jIGIveGVuL2FyY2gvYXJtL2RvbWFpbi5jDQo+Pj4+IGluZGV4IDc5MDEy
YmY3Nzc1Ny4uZmE2ZmNjNWU0NjdjIDEwMDY0NA0KPj4+PiAtLS0gYS94ZW4vYXJjaC9hcm0vZG9t
YWluLmMNCj4+Pj4gKysrIGIveGVuL2FyY2gvYXJtL2RvbWFpbi5jDQo+Pj4+IEBAIC03MzMsNiAr
NzMzLDggQEAgaW50IGFyY2hfZG9tYWluX2NyZWF0ZShzdHJ1Y3QgZG9tYWluICpkLA0KPj4+PiAg
ICAgICAgaWYgKCAocmMgPSBkb21haW5fdmdpY19yZWdpc3RlcihkLCAmY291bnQpKSAhPSAwICkN
Cj4+Pj4gICAgICAgICAgICBnb3RvIGZhaWw7DQo+Pj4+ICAgIA0KPj4+PiArICAgIGNvdW50ICs9
IGRvbWFpbl92cGNpX2dldF9udW1fbW1pb19oYW5kbGVycyhkKTsNCj4+Pj4gKw0KPj4+PiAgICAg
ICAgaWYgKCAocmMgPSBkb21haW5faW9faW5pdChkLCBjb3VudCArIE1BWF9JT19IQU5ETEVSKSkg
IT0gMCApDQo+Pj4gSU1PIGl0IG1pZ2h0IGJlIGJldHRlciB0byBjb252ZXJ0IHRoZSBmaXhlZCBh
cnJheSBpbnRvIGEgbGlua2VkIGxpc3QsDQo+Pj4gSSBndWVzcyB0aGlzIG1hZGUgc2Vuc2Ugd2hl
biBBcm0gaGFkIGEgdmVyeSBsaW1pdGVkIG51bWJlciBvZiBtbWlvDQo+Pj4gdHJhcCBoYW5kbGVy
cywgYnV0IGhhdmluZyB0byBkbyBhbGwgdGhpcyBhY2NvdW50aW5nIHNlZW1zIHF1aXRlDQo+Pj4g
dGVkaW91cyBldmVyeSB0aW1lIHlvdSB3YW50IHRvIGFkZCBuZXcgaGFuZGxlcnMuDQo+PiBZZXMs
IEkgdGhpbmsgd2UgbmVlZCB0byBkbyBzbywgYnV0IHRoaXMgaW1wcm92ZW1lbnQgd2FzIG5vdCBt
ZWFudA0KPj4gdG8gYmUgaW4gdGhpcyBwYXRjaC4NCj4gQWNrLCBqdXN0IHdhbnRlZCB0byByYWlz
ZSB0aGF0IHRoaXMgbW9kZWwgc2VlbXMgdG8gYmUgZ2V0dGluZyBtb3JlDQo+IGNvbXBsZXggdGhh
biBqdXN0IHNldHRpbmcgdXAgYSBsaXN0Lg0KPg0KPj4+PiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gv
YXJtL3ZwY2kuYyBiL3hlbi9hcmNoL2FybS92cGNpLmMNCj4+Pj4gaW5kZXggNzZjMTJiOTI4MTRm
Li42ZTE3OWNkMzAxMGIgMTAwNjQ0DQo+Pj4+IC0tLSBhL3hlbi9hcmNoL2FybS92cGNpLmMNCj4+
Pj4gKysrIGIveGVuL2FyY2gvYXJtL3ZwY2kuYw0KPj4+PiBAQCAtODAsMTcgKzgwLDUxIEBAIHN0
YXRpYyBjb25zdCBzdHJ1Y3QgbW1pb19oYW5kbGVyX29wcyB2cGNpX21taW9faGFuZGxlciA9IHsN
Cj4+Pj4gICAgICAgIC53cml0ZSA9IHZwY2lfbW1pb193cml0ZSwNCj4+Pj4gICAgfTsNCj4+Pj4g
ICAgDQo+Pj4+ICtzdGF0aWMgaW50IHZwY2lfc2V0dXBfbW1pb19oYW5kbGVyKHN0cnVjdCBkb21h
aW4gKmQsDQo+Pj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHN0cnVjdCBw
Y2lfaG9zdF9icmlkZ2UgKmJyaWRnZSkNCj4+Pj4gK3sNCj4+Pj4gKyAgICBzdHJ1Y3QgcGNpX2Nv
bmZpZ193aW5kb3cgKmNmZyA9IGJyaWRnZS0+Y2ZnOw0KPj4+PiArDQo+Pj4+ICsgICAgcmVnaXN0
ZXJfbW1pb19oYW5kbGVyKGQsICZ2cGNpX21taW9faGFuZGxlciwNCj4+Pj4gKyAgICAgICAgICAg
ICAgICAgICAgICAgICAgY2ZnLT5waHlzX2FkZHIsIGNmZy0+c2l6ZSwgTlVMTCk7DQo+Pj4gSSdt
IGNvbmZ1c2VkIGhlcmUsIGRvbid0IHlvdSBuZWVkIHRvIHVzZSBhIHNsaWdodGx5IGRpZmZlcmVu
dCBoYW5kbGVyDQo+Pj4gZm9yIGRvbTAgc28gdGhhdCB5b3UgY2FuIGRpZmZlcmVudGlhdGUgYmV0
d2VlbiB0aGUgc2VnbWVudHMgb2YgdGhlDQo+Pj4gaG9zdCBicmlkZ2VzPw0KPj4+DQo+Pj4gQUZB
SUNUIHRoZSB0cmFuc2xhdGlvbiBkb25lIGJ5IHZwY2lfbW1pb19oYW5kbGVyIHVzaW5nIE1NQ0ZH
X0JERg0KPj4+IGFsd2F5cyBhc3N1bWUgc2VnbWVudCAwLg0KPj4gWW91IGFyZSBhYnNvbHV0ZWx5
IHJpZ2h0IGhlcmU6IEkgY2FuIHNldCB1cCBod2RvbSBzcGVjaWZpYw0KPj4gaGFuZGxlcnMsIHNv
IEkgY2FuIHByb3Blcmx5IHRyYW5zbGF0ZSB0aGUgc2VnbWVudC4NCj4+IE9uIHRoZSBvdGhlciBo
YW5kLCB3aGVuIHZpcnR1YWwgYnVzIHRvcG9sb2d5IGFkZGVkLCB0aGUgU0JERg0KPj4gdHJhbnNs
YXRpb24gZnJvbSB2aXJ0dWFsIHRvIHBoeXNpY2FsIFNCREYgcmVzaWRlcyBpbiB0aGUgQXJtJ3MN
Cj4+IHZwY2lfbW1pb197cmVhZHx3cml0ZX0sIGxpa2UgdGhlIGJlbG93Og0KPj4gICDCoMKgwqAg
aWYgKCBwcml2LT5pc192aXJ0X2VjYW0gJiYNCj4+ICAgwqDCoMKgwqDCoMKgwqDCoCAhdnBjaV90
cmFuc2xhdGVfdmlydHVhbF9kZXZpY2Uodi0+ZG9tYWluLCAmc2JkZikgKQ0KPj4gICDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgIHJldHVybiAxOw0KPj4gKEJUVyBKYW4gYXNrZWQgaW4gc29tZSBvdGhl
ciBjb21tZW50IHdoeSBpdCBpcyBBcm0gc3BlY2lmaWM6DQo+PiBJIHRlbmQgdG8ga2VlcCBpdCBB
cm0gc3BlY2lmaWMgdW50aWwgdGhlIHBvaW50IHdoZW4geDg2IHdhbnRzIHRoYXQNCj4+IGFzIHdl
bGwuIFVudGlsIHRoYXQgcG9pbnQgdGhlIGNvZGUsIGlmIG1vdmVkIHRvIGNvbW1vbiwgd2lsbCBi
ZQ0KPj4gdW5uZWVkZWQgYW5kIGFzIEphbiBjYWxscyB0aGF0ICJkZWFkIikNCj4+IFNvLCBJIHRo
aW5rIHRoYXQgSSBjYW4gZXh0ZW5kIHZwY2lfbW1pb197cmVhZHx3cml0ZX0gdG8gYWNjb3VudA0K
Pj4gb24gdGhlIGh3ZG9tIGxpa2UgKHZpcnR1YWwgYnVzIGNvZGUgaXMgdGhlIGZ1dHVyZSBjb2Rl
KToNCj4+DQo+PiBzdGF0aWMgaW50IHZwY2lfbW1pb19yZWFkKHN0cnVjdCB2Y3B1ICp2LCBtbWlv
X2luZm9fdCAqaW5mbywNCj4+ICAgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqAgcmVnaXN0ZXJfdCAqciwgdm9pZCAqcCkNCj4+IHsNCj4+IC4uLg0KPj4g
ICDCoMKgwqAgc3RydWN0IHZwY2lfbW1pb19wcml2ICpwcml2ID0gKHN0cnVjdCB2cGNpX21taW9f
cHJpdiAqKXA7DQo+Pg0KPj4gICDCoMKgwqAgaWYgKCBwcml2LT5pc192aXJ0X2VjYW0gKQ0KPj4g
ICDCoCDCoMKgIMKgwqAgc2JkZi5zYmRmID0gTU1DRkdfQkRGKGluZm8tPmdwYSk7IC8qIEZvciB2
aXJ0dWFsIGJ1cyB0b3BvbG9neSB0aGUgc2VnbWVudCBpcyBhbHdheXMgMC4gKi8NCj4+ICAgwqDC
oMKgIGVsc2UNCj4+ICAgwqDCoMKgIHsNCj4+ICAgwqAgwqDCoCDCoMKgIHNiZGYuc2JkZiA9IE1N
Q0ZHX0JERihpbmZvLT5ncGEpOw0KPj4gICDCoMKgwqDCoMKgwqDCoCBzYmRmLnNlZyA9IHByaXYt
PnNlZ21lbnQ7DQo+PiAgIMKgwqDCoCB9DQo+PiAgIMKgwqDCoCByZWcgPSBSRUdJU1RFUl9PRkZT
RVQoaW5mby0+Z3BhKTsNCj4+DQo+PiAuLi4NCj4+ICAgwqDCoMKgIC8qDQo+PiAgIMKgwqDCoMKg
ICogRm9yIHRoZSBwYXNzZWQgdGhyb3VnaCBkZXZpY2VzIHdlIG5lZWQgdG8gbWFwIHRoZWlyIHZp
cnR1YWwgU0JERg0KPj4gICDCoMKgwqDCoCAqIHRvIHRoZSBwaHlzaWNhbCBQQ0kgZGV2aWNlIGJl
aW5nIHBhc3NlZCB0aHJvdWdoLg0KPj4gICDCoMKgwqDCoCAqLw0KPj4gICDCoMKgwqAgaWYgKCBw
cml2LT5pc192aXJ0X2VjYW0gJiYNCj4+ICAgwqDCoMKgwqDCoMKgwqDCoCAhdnBjaV90cmFuc2xh
dGVfdmlydHVhbF9kZXZpY2Uodi0+ZG9tYWluLCAmc2JkZikgKQ0KPj4gICDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgIHJldHVybiAxOw0KPj4NCj4+IFdpbGwgaXQgd29yayBmb3IgeW91Pw0KPiBSaWdo
dCwgSSBndWVzcyBpdCBjb3VsZCB3b3JrIGFzIGxvbmcgYXMgdGhlIGRpZmZlcmVuY2VzIGJldHdl
ZW4gdGhlDQo+IGhhcmR3YXJlIGRvbWFpbiBhbmQgdGhlIHVucHJpdmlsZWdlZCBvbmVzIGFyZSBu
b3QgdG9vIGJpZy4NCj4NCj4gVGhlIG5pY2UgcGFydCBhYm91dCBoYXZpbmcgZGlmZmVyZW50IGhh
bmRsZXJzIGlzIHRoYXQgeW91IGF2b2lkIGENCj4gYnVuY2ggb2YgY29uZGl0aW9uYWxzIChpZTog
bm8gbmVlZCB0byBjaGVjayBmb3IgaXNfdmlydF9lY2FtKSB3aGljaA0KPiBtYWtlcyB0aGUgY29k
ZSBlYXNpZXIgdG8gZm9sbG93LiBPVE9IIGl0IGNvdWxkIGludHJvZHVjZSBtb3JlIGNvZGUNCj4g
ZHVwbGljYXRpb24uDQpZZXMuIFRoaXMgaXMgd2h5IEkgcHJlZmVyIGNvbmRpdGlvbmFscyBpbiB0
aGlzIHNwZWNpZmljIGNhc2UuIEhhbmRsZXJzDQphcmUgc21hbGwsIHlldCBJIGRvIG5vdCB3YW50
IHRvIGhhdmUgdHdvIHZlcnNpb25zIG9mIHRoZSBzYW1lLg0KVGhlIGhhbmRsZXJzIGJlY29tZSB1
Z2x5IGlmIHdlIHRyeSBkaXZpZGluZyB0aGVtIGludG8gY29tbW9uIHBhcnRzDQpTbywgSSdsbCBw
cm9iYWJseSBpbnRyb2R1Y2UgcHJpdiBpbiB0aGlzIHBhdGNoIGFuZCB1c2UgaXQgZm9yIHRoZSBo
d2RvbSdzDQpzZWdtZW50LiBMYXRlciBvbiwgd2hlbiB2aXJ0dWFsIGJ1cyB0b3BvbG9neSBpcyBh
ZGRlZCBmb3IgdGhlIGd1ZXN0cywNCkknbGwgdXNlIHRoZSBzYW1lIChleHRlbmRlZCkgcHJpdiB0
byBwYXNzIGd1ZXN0J3MgaW5mby4NCj4NCj4gVGhhbmtzLCBSb2dlci4NClRoYW5rIHlvdSwNCk9s
ZWtzYW5kcg==


From xen-devel-bounces@lists.xenproject.org Mon Oct 25 14:12:59 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Oct 2021 14:12:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.215893.375303 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mf0iW-0005bI-Oj; Mon, 25 Oct 2021 14:12:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 215893.375303; Mon, 25 Oct 2021 14:12:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mf0iW-0005bB-Ll; Mon, 25 Oct 2021 14:12:48 +0000
Received: by outflank-mailman (input) for mailman id 215893;
 Mon, 25 Oct 2021 14:12:47 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=G2Ub=PN=citrix.com=roger.pau@srs-us1.protection.inumbo.net>)
 id 1mf0iV-0005b5-9a
 for xen-devel@lists.xenproject.org; Mon, 25 Oct 2021 14:12:47 +0000
Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id bd8850e4-a639-448f-bf2e-3c3f515d1494;
 Mon, 25 Oct 2021 14:12:46 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: bd8850e4-a639-448f-bf2e-3c3f515d1494
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1635171165;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=EASz5039FEq4/EXI3gKv09M6id3KXQI9eF4+tgh3qxk=;
  b=ZmhU60eIDpRY1uAqcI7pps5SkKu76sZJL0rnLCXR8qR3KvltuPLtHJcM
   OBYqmLlx/Z3SVnI0KYiHGfwpOhFU6xZR599bNfWCU6oejdsKUuVm23aW4
   oJlYBPoTtR8BIz1JyhxpDfjR/laC0ZR/9yCq7siBldf5KmGv7YAKx7xEq
   4=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: raXoSIRjazv7HnrKmFEveVUWdjK8sQOxaA52f7fd4U1luQwWrZ9BaV8LAQeVSe/G+fEIeYjzNg
 wMX/zFFJypds0rZgqoRadcEF5cM25/ul3+HR5xMmwYEy/vxQBvV6oJzT+3A1dVQb6hEM9l/Xxe
 LHdNdRldPjO+2B6bP4faEvknX1XiXFdOL03fPDmLp2ceH5xkXuYNoNhdNfuzyorqgsXypCavod
 Ml+BebBk8gppIGFBbeSyqhIjpKbn0tYim+lTUo6A4UP6QX4jw9uOXdZCR/3T1VBLz1vbbVhBvI
 q0hxxX/KydOjAWeOy17Zaz8q
X-SBRS: 5.1
X-MesageID: 55544333
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:1Sb1FKPwyzpbSLnvrR3WkcFynXyQoLVcMsEvi/4bfWQNrUpx0WAAz
 TMWUG3SP6zbZGXzeN8ibY3j/UlUvJfRx4A1TQto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdpJYz/uUGuCJQUNUjMlkfZKhTr6bUsxNbVU8En540Ug+w7dRbrNA2rBVPSvc4
 bsenOWHULOV82Yc3rU8sv/rRLtH5ZweiRtA1rAMTakjUGz2zhH5OKk3N6CpR0YUd6EPdgKMq
 0Qv+5nilo/R109F5tpICd8XeGVSKlLZFVDmZna7x8FOK/WNz8A/+v9TCRYSVatYozqjhI177
 /9yj5+baz4XIbeVurUkajANRkmSPYUekFPGCX22sMjVxEzaaXr8hf5pCSnaP6VBpLwxWzsXs
 6VFdnZdNXhvhMrvqF6/YvNrick5atHiIasUu216zCGfBvEjKXzGa/iXuIMEh2xr7ixINc37a
 dIoeTNKUDTnczdIOQcoOqk8tuj90xETdBUH8QnI9MLb+VP7yA13zaioKNHUUsKFSN8TnUuCo
 G/CuWPjDXkyNtOFziGe2mmxneKJliT+MKoXHa+Q9fNwhlCXgGsJB3U+RVa95PW0lEO6c9ZeM
 FAPvDojq7Ao806mRcW7WAe3yFaYsRoMc95RFfAm8gaLy7qS7wvxLmoNSDJbecElnMAzTD0uk
 FSOmrvBCSNqr+e9SHST7L6YoDq+fy8PIgcqZygfQAUt5NXuuoU6iB6JVdsLOK64itL8ECrYw
 D2QqiU6wbIJgqYj3aKh/EuBhCmwvJ/XVQ0kzgLNV2mh40VyY4vNWmCzwQGFt7Aadt/fFwTf+
 ihf8ySD0AwQJZ6nj3GHZ88yJrKCxc+7LyeFow9WJrB0olxB5EWfVYxX5Th/ImJgPcAFZSLlb
 SfvhO9B2HNAFCD1NfEvMupdH+xvlPK6TY20CZg4e/IXOsApHDJr6h2CcqJ5M4rFq0Mrjb0kc
 amSdcKhHB724ow2kWLoGY/xPVItrx3SJF8/p7iml3xLMpLEPRZ5rIvp13PVNogEAFus+lm9z
 jqmH5LiJ+9jeOP/eDLL1oUYMEoHK3M2bbiv9ZcKL7bbeFs+QDtxYxM0/V/HU9Y190iyvryQl
 kxRp2cCkAav7ZE5AVzSApycVF8fdckm9i9qVcDdFV2px2Iice6SAFQ3LPMKkU0c3LU7l5ZcF
 qBdE+3ZW6gnYmmXqlw1MMimxKQ/JUvDuO57F3f8CNTJV8U7HFKhFx6NVlaHyRTi+QLu5Jtg+
 OX7jV2KKXfBLiw7ZPvrhDuU5wrZlVAWmf5oXluOJd9WeU7295NtJTC3hfgyS/zg4z2YrtdD/
 wrJUxoeu8fXpIo5rIvAiaye9t/7GOpiBEtKWWLc6O/uZyXd+2Oix65GUfqJIm+BBD+lpv36a
 LUH1ez4Pd0GgE1O79h2HYF0wP9s/NDovbJbkFhpRS2Zc1SxB7p8CXCaxs0T5LZVz7pUtFLuC
 EKC89VXI5uTP8bhHAJDLQYpdL3bh/oVhiPT/bI+J0CjvH17+7+OUENzORiQiXMCcOspYd19m
 ep44ZwY8Q2yjBYuI+2qtCEM+jTeNGEEXoUmqooeXN3hhD00xwwQepfbECL3vs2CMo0eLkkwL
 zaIr6PenLAAlFHaen8+GHWRj+pQgZMC5EJDwFMYfgnbn9PEgrk83QFL8CRxRQNQl00V3+V2M
 2ltFkt0OaTRoGs42JkdBzihS1NbGRmU2k3t0F9YxmTWQn6hWnHJMGBga/2G+1oU8j4EczVWl
 F1CJL0Jjdo+kBnN4xYP
IronPort-HdrOrdr: A9a23:tP8i7ampb189e0cWhTCBw8wR1FvpDfOwimdD5ihNYBxZY6Wkfp
 +V8sjzhCWatN9OYh0dcLC7WJVpQRvnhPhICK0qTMqftW7dyReVxeBZnPHfKljbehEWmdQtsJ
 uIH5IObOEYSGIK8voSgzPIY+rIouP3iJxA7N22pxwGIHAIGsMQnDuRSDzraXGeLDM2dKbRf6
 Dsn/avyQDQHkj+Oa+Adwc4tqX41pD2vaOjRSRDKw8s6QGIgz/twLnmEyKA1hNbdz9U278t/U
 XMjgS8v8yYwr6G4y6Z81WWw4VdmdPnxNcGLMuQivINIjGprgqzfoxuV5CLoThwiuCy71QBls
 XKvn4bTohOwkKUWlvwjQrm2gHm3jprw3j+yWWAiX+mmsD9TCJSMbsIuatpNj/ir2YwttB116
 xGm0iDsYBMMB/GlCPho/DVShBDjCOP0DofuN9Wq0YafZoVabdXo4Ba1lhSCo08ECXz751iOP
 VyDfvb+O1dfTqhHjHkV1FUsZ6Rt0kIb1K7qhBogL3Q79EWpgE286Ig/r1dop9an6hNDKWt5I
 z/Q+1Vff91P4krhJlGdZI8qP2MexrwqCL3QRCvyGvcZdU60lL22tXKCeYOlauXkKJh9upEpH
 2GaiIAiVIP
X-IronPort-AV: E=Sophos;i="5.87,180,1631592000"; 
   d="scan'208";a="55544333"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=CUPv6nHF07c/FoIRpmjqLN4Lb5FUIvD+vZHi9oiwanaJL0Klu8o569jggpZYzdHYHrRerJBIg5kz511hMuGw/bloE38XXycDuM1lRYtcmCa0VbO8mkDVuGYLL+xMcYycZ4uPi1hu78PWAduzFYkMyAY3rs0QnHSsUoYGeRoE0l0iMUti+aYRtc8HaoW/BgCff53oOfZ7wh6TPeDL447XQvhOrE2mAK5xpGK69gwxCx94FoEVxFMcnUPuO/hadz1w0ekpOVFw9q+XkWyObaBs2wjVE89jHOrOTfZN9fPnplCSGu44HiZdhu45p1AeLNmTgcu3EA6/uKHrYUgAm3X+Zg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=8Qb7MN/jnEZwBzzlZMq5VTbnICJ88x13Shn0e0Jmuto=;
 b=IAP3IVarYuEVv5TUnXD+sgGgBTfMum3ARH2TNTtywfkXix4/VhsVx6l+zLga2ypMlC5csJKjQWEBD0oqQbTjpCwl/KpBkSfYPe9kzetDNv1BCU5GCOUXLWT4xvnmGOa79CO16YKnkc9A5d3IYRS9evq2wQM/dz/QASi/mNtPEB9LPWKYqmMArmTJO37PzXRV2IjB9rrVUCZf2cTRGdmbqXqOFIUM/FBVUS18hYgu9sYTTNP30jWCg8a0xKSNBlxxVlc1fUX3M0mbqjwjM8vJGX4QP66ZFxnEZaffghgATNQjtk8CTG2K2+KrjF5sMRStIbOcowGRYuNH/75BL799iw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=8Qb7MN/jnEZwBzzlZMq5VTbnICJ88x13Shn0e0Jmuto=;
 b=kPWxqBXOWQP7dTuTnDUBYL3I4LYxe0ixO9MKV92NmKUc4Zn8TQrcm5OEGeVqp0/aFAWnYdVJi0403eK0EiT5phWVo+04FpDtZ6YuICSzbxcHselQFFGIcruOmaF0Sg1CikYRx/ImNq1TQrmMY+6qAloylXRD5EDfwqgNabn5tfc=
Date: Mon, 25 Oct 2021 16:12:34 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: David Woodhouse <dwmw2@infradead.org>
CC: Jason Andryuk <jandryuk@gmail.com>, <josef@oderland.se>,
	<boris.ostrovsky@oracle.com>, <helgaas@kernel.org>, <jgross@suse.com>,
	<linux-pci@vger.kernel.org>, <maz@kernel.org>, <tglx@linutronix.de>,
	<xen-devel@lists.xenproject.org>
Subject: Re: [PATCH] PCI/MSI: Fix masking MSI/MSI-X on Xen PV
Message-ID: <YXa7UtYyX7y+cCwU@MacBook-Air-de-Roger.local>
References: <90277228-cf14-0cfa-c95e-d42e7d533353@oderland.se>
 <20211025012503.33172-1-jandryuk@gmail.com>
 <eb38c1d2707d03bf675d7b15f014cbe741de0998.camel@infradead.org>
 <YXaYe/RF6NWFKxGj@MacBook-Air-de-Roger.local>
 <72d763d055929b8c81f0c8deab14b33bd252c946.camel@infradead.org>
 <YXaqENqdjx0lJ+Fx@MacBook-Air-de-Roger.local>
 <acaca10c50155b75c82c6370236231856b30ade4.camel@infradead.org>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <acaca10c50155b75c82c6370236231856b30ade4.camel@infradead.org>
X-ClientProxiedBy: MR1P264CA0045.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:501:3e::8) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: e49d1d77-392e-493b-e6a4-08d997c18144
X-MS-TrafficTypeDiagnostic: DM6PR03MB3579:
X-Microsoft-Antispam-PRVS: <DM6PR03MB3579BD22CCA0ED4057B2BD918F839@DM6PR03MB3579.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 60tQ/25SouDiWF0506mge1Bz42nFYMKiD6IOhR7Du/g5PkfmFRMpzRO5+8YiczeIlmEwK7OTEN9eafDQ4DIxlck+yGlY9zn6URG0qP11i5v5SNR1x//wQvux0DlqchJJhMU+l1N+TY49Z0aMhcbPj3rBu3vMQv4opT2jaUEx4VTe6qQRvGIhgtCkrzNlvY4LrsbBNxlrXbtsryS978xw68O5mynyPZZ9omsYrXAJ4BRr/5Pk2IexE5r5awtUb4c38Qj9FzMYceo9jhkfRLvce2njCNvFWGJOtxjy18MxgDBOajWtxwu29yRW39P3m+HudHW7rF4I+0BBi+MHip7xvMQ6c/GSRfz8hZ0TV/FtvKh1XxayWhma2mIMWsjztNQ/mlPN6N3B2+ummz4/X5OPEYW0QQUTQlLbhrEhky6WkZ3iIBeilcq4YTbHxjcYTMm/ekc273F8Dc0qozuKdiHF/gLCFbZSVqi+i29h6gtSqrBkZ8zeGuUZ+zo1467/yHVldpNgOed9qDVFfLY/GIuegxI8vVHZls/ofj+YRgDjLi2kwWHvzFynA7OQzhGbH6X9RW8dFQoSyJrKK4AgbR6Hk0WyJHZ1nioobok3/KkhMbR9DeyTRhnftWJMNeyrcgWKBNCzozxmeEKWKjGopFyCwUhbmZa/GdljcsXD2NnjLNfK7KUhGEXFwv+3vefDJmHRNAxAm3Fy2M6qCqzhQ9L0Jg==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(83380400001)(8936002)(6666004)(66556008)(26005)(316002)(82960400001)(66946007)(7416002)(38100700002)(956004)(8676002)(4001150100001)(66476007)(186003)(5660300002)(6486002)(6496006)(9686003)(85182001)(4326008)(508600001)(86362001)(2906002)(6916009)(67856001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UDUxY2JBTTJIcFExZ05wWFJoVUE4dkNGbmoyazl0ekFtWGp0bVNDQlNKRWNY?=
 =?utf-8?B?L04vNXc0bVd1bEhYKytGVTRIeXlyMkFsQ3AxdXRkczVpQWUxWldPUWt4cWQ5?=
 =?utf-8?B?RC9aRUFKbXZVa3FxVkhKaGsrb2ZDdzhwUzRNSkZ4eWxjNzZvVjFraGpWVUxj?=
 =?utf-8?B?aHpHWmlxNU5JVlN6c09vcHUyVm5keWFnZVJPSTM4clNUanNJamQrVkJZaHov?=
 =?utf-8?B?clVQRjJFeXpQaHQvblpoYkpJOS9EdW1XbTZHTG83ZkI2Wm05anNTYlRIeHpW?=
 =?utf-8?B?U3lvOHpVRmh3bWtnNTF3K2xBcTdvNm5tRFE4Wmt2TElOcGkwakxEZ0d6SzRu?=
 =?utf-8?B?RklucTZLbWFLbVhIRFhhMUpxVU50cVhIZGgvV1cyRklVL3N2aGpLOWUwYWRh?=
 =?utf-8?B?eXJPSTZjZksrVnc0MWZOQVdGODk3b3dkQnBUUTUrcVBLTXhmelhyT3lrdGZz?=
 =?utf-8?B?R1FzQ0JKWnB1SUJWMEo2SHhBa1BHTTBZQS9BajNmZXo2VVF2WEFMVG9TUjk4?=
 =?utf-8?B?Z0s0OHowUEZaZXFNOWJTcnA4MHRkYUlzejNhbTRua2c3cXBIZUZFWGpnQlpS?=
 =?utf-8?B?QmJES3NVMllOYlFmSCtkTXpnSEs4ekhyNnF0RU1DaWc0WEdOUWFidGtsTXh2?=
 =?utf-8?B?SnZWY0xKM2dFZlJFUVI1SGk3WW03VXRyNlZuVXNybXFnT1k2c1hlS25jcVQz?=
 =?utf-8?B?ZXNpS3MxK3VMZ2dlS3p0bnpLQmVKc1QvY3JyRGR6b2JWdzJkQnYxSk9GaWxl?=
 =?utf-8?B?R1JFbUxGWjhXTXhNRzNDK1BZZUxVT2ZnWnQwMklyZi8vNmVaRnNKRzNzUXB3?=
 =?utf-8?B?U2NhcGh5cTBRN2dxY1JFT1hlTDhJVUxDTTNiakhOMUppYkZ5RkhNT1JnSlE5?=
 =?utf-8?B?aFZZek1XdGxnNWF1SzZwb0FDbm9OeXVWWG5wdFptYTlKenFjQzJiUWExdWRZ?=
 =?utf-8?B?V1p4a2w5YjlvR2x3TjV0cTIveUh1b0txNllLbFNVakpHNTc3Q2N1b2RqVi83?=
 =?utf-8?B?TDhJRU5mUi8zR1BkWGFRWW9KeUVQdTFrc3RYZ2RjYzJaWVRYZ3A1Nkhwdmxv?=
 =?utf-8?B?cnowQUIxUE14am92VE5nUFBmUTZwaCtaM0xPQXBnU3BWdklaVnZCbWJSN2xv?=
 =?utf-8?B?Y3NzR25Sd0ZCS25MQm1wUVlMNWIzaldIZ3BWM3hLR3JMcTQ0ODZPaGJxQXlv?=
 =?utf-8?B?b2tsN09uZDBwREt6VnlGTWVYa0UwdGRYVnV4Yjg0U25WUGRuN0J2MFl1ZHVr?=
 =?utf-8?B?VmtTWGs5MDhKY2hVUE1qZklnSXplTVRLalRDMXlaNE94YWdBak8wM3c5Vlo0?=
 =?utf-8?B?eHQrdFJWcWMycUYwN2Ryc3JrT1cxUTZQMzNvOXRSdHFSYnV5TDJZY3ZWblhu?=
 =?utf-8?B?UlNtR3gzWUhVMys5eWl5RFo2cTJxMFBVYjJtclZRQ3pFblJKY2pQK1liNk8z?=
 =?utf-8?B?N1lFVjRrK29UR0liRTFvRkkzZGRxb0xqSXhsR211U2lsbE91L2xVS3N6dXRk?=
 =?utf-8?B?TlFrdWJSam1PdE1jSnFSakFManNlMktyVlBzK0JTUFRJMmZPUFAwN1pDaDR6?=
 =?utf-8?B?LzVhc3M0ZEh6LzZxQVRZSVBNTXJqYnZpbkk3VlhJcnppcnBmTnVpOWVXYXgz?=
 =?utf-8?B?YTZ2Q1JiRFJFTXNhWFNFNzBoenVOSHBoNHpsY1IrZ00wd09Pa3ZuajY4cXZB?=
 =?utf-8?B?d2dFQkVjRFhscGpxbzR3cmYyQ1dWRVMrTEFBV3lhaXlFOTM4emdhK1AxeFBQ?=
 =?utf-8?B?cDIzdDRIWkNhVWdUVmN3UVRBeGFsTndkVGVVLzNtRnozbmNpTTVFdHl0L1dx?=
 =?utf-8?B?ejRLWHhSanN0V1BodGF1K3lDaXhnT2JNVnZqUlE0eHJReWRzbmFXTExROG5V?=
 =?utf-8?B?ME5TUUo2QW9qMmVhUjhQbnVpbGt4RWRZK1JyWS9RT254VE9kRTRISE9BZVls?=
 =?utf-8?B?ZHk0VVF4Z1FOcGY4NkpHSzl0SHEwMW1QL0pZVEY3aFg5TUEybHNSUWthMkdY?=
 =?utf-8?B?MXNxMXNkVWtCVmgvMkk5a2xiNkYvcGJBRGwrY0duYUh6aStHenpVay9XQzh3?=
 =?utf-8?B?eFhmSHRhTlhrOXBqOFJFWThWcTZZd2xRWi9tSHFHcG4zSFBMZFNCUDBZY09B?=
 =?utf-8?B?ODFTdWJXVXJxY0pUaTRuVm11VStWQmJ6ZittNEt3dHo4bHUvV3E0QmlLYzR4?=
 =?utf-8?Q?5BIxDNRHrWJCJIOfRKzohMM=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: e49d1d77-392e-493b-e6a4-08d997c18144
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2021 14:12:40.4806
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: iv+OHK0RYpZw5Lc2jBeXn4oJJ0YjUaGmbA/akZTpJwJpURxVl4puc+Ci/wREUfHvFOyS5EdhNQk2v6BjexHpBA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB3579
X-OriginatorOrg: citrix.com

On Mon, Oct 25, 2021 at 02:02:38PM +0100, David Woodhouse wrote:
> On Mon, 2021-10-25 at 14:58 +0200, Roger Pau Monné wrote:
> > On Mon, Oct 25, 2021 at 12:53:31PM +0100, David Woodhouse wrote:
> > > On Mon, 2021-10-25 at 13:43 +0200, Roger Pau Monné wrote:
> > > > It's kind of optional for HVM guests, as it depends on
> > > > XENFEAT_hvm_pirqs, which sadly gets unconditionally set for HVM
> > > > guests, thus dropping any benefits from having hardware assisted APIC
> > > > virtualization or posted interrupts support.
> > > 
> > > Indeed. After implementing PIRQ support for Xen guests running under
> > > KVM, I spent a "happy" couple of days swearing at it because it
> > > actually *worked* if something would just *unmask* the f***ing MSI, but
> > > the guest inexplicably (to me) didn't do that.
> > > 
> > > Took me a while to work out that Xen itself is *snooping* on the MSI
> > > table writes even while they are *masked*, to capture the magic MSI
> > > message (with vector==0) which means it's actually a PIRQ# in the
> > > destination ID bits, and then magically unmask the MSI when the guest
> > > binds that PIRQ to an event channel.
> > > 
> > > I did not enjoy implementing that part.
> > 
> > I can see that. It's even better because none of this is actually
> > documented.
> 
> Indeed. I still haven't worked out if/how Xen actually *masks* the
> corresponding MSI-X again. It can't do so when the evtchn is masked,
> since that's just a bit in the shinfo page. So while the evtchn is
> masked, the MSI can still be screaming into the void?

I think so, it's quite weird because as a side effect of this mangling
Xen is transforming an edge triggered interrupt to a level triggered
one, as masked event channels belonging to MSI vectors will get set to
pending.

So it's not entirely screaming into the void because it will get
(wrongly) set as pending when masked.

> Perhaps it does so when the PIRQ is unbound from the evtchn?
> 
> > > FWIW the *guest* could potentlaly be smarter here and elect not to use
> > > PIRQs when hardware assisted vAPIC is present. Aren't there some bits
> > > in the CPUID that Xen advertises, which indicate that? 
> > 
> > Yes, it's in leaf 0x40000x04. FWIW, I would also be fine with removing
> > XENFEAT_hvm_pirqs, as I don't think diverging from the hardware
> > specifications gives us much benefit. We avoid a couple of vm exits
> > for sure, but the cost of having all those modifications in guest
> > OSes is not worth it.
> 
> These days with posted interrupts, it doesn't even save us any vmexits;
> it's all that additional guest complexity just to give us *more*
> vmexits than we would have had :)

Oh indeed. I was thinking about hardware without APIC hw
virtualization or posted interrupts.

Roger.


From xen-devel-bounces@lists.xenproject.org Mon Oct 25 14:28:38 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Oct 2021 14:28:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.215902.375314 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mf0xj-0007C9-9g; Mon, 25 Oct 2021 14:28:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 215902.375314; Mon, 25 Oct 2021 14:28:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mf0xj-0007C2-6g; Mon, 25 Oct 2021 14:28:31 +0000
Received: by outflank-mailman (input) for mailman id 215902;
 Mon, 25 Oct 2021 14:28:29 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=G2Ub=PN=citrix.com=roger.pau@srs-us1.protection.inumbo.net>)
 id 1mf0xh-0007Bw-S6
 for xen-devel@lists.xenproject.org; Mon, 25 Oct 2021 14:28:29 +0000
Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id d219d1b6-359f-11ec-840f-12813bfff9fa;
 Mon, 25 Oct 2021 14:28:28 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d219d1b6-359f-11ec-840f-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1635172108;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=t0tb06zQmmQgPB5TNz1qJRRr0PrmoaCRnjf3rBkAY8Q=;
  b=AOJ/MysYP2SRtkFeU9y187d6jPqGgnPjxQa6/6on+ArTbB9KfHVcFmXY
   /umHJOFvdksgLFT6UitXyVafFqXCi3uNI16OYUdhaVO15e41RV1CZfule
   0BY6ixuxyeXTmsdPWLnq/ZNaY7tge+nJjKx2bgvBBTYYEOUVYrYZ/aznW
   U=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: wfQ+yC/Ezc3pZlg3n535ht1Csr2W2Gv/4wmSRRhyMoooG4IHHaF/xWPu1KqEGnnA1GEYK/LwQA
 emZEhFCW2736op3lPQFX24qvjWHzNP5ZGW1gCfTQRO8z44qa8qhZb028+JcmqqArDWytOxBkq7
 luwSI5CcjBK95G8cuwKspjcyQbgiA1Moe4e+6SbKraXJKsKct3kjw+wVoasbZhEO8fuEd0kQLe
 YvfEFhcD72c8BtcdQEoky7cONjQ79OtmkNQdWRPrVc2X8Ox3K5HKX6kJU0wVLeO8Cwa0DmxPQ4
 yyzU7SwT343jMuMyKkJaHKg4
X-SBRS: 5.1
X-MesageID: 56382673
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:77QQnagqNGAw1PQsWjrpk8EZX161SBYKZh0ujC45NGQN5FlHY01je
 htvCDiPOPyDN2PxKt4nbI2w9R4Bu5CHxtJnQAs+rnsxFywb9cadCdqndUqhZCn6wu8v7a5EA
 2fyTvGacajYm1eF/k/F3oAMKRCQ7InQLlbGILes1htZGEk0F0/NtTo5w7Rg29Yy3IDga++wk
 YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq
 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx
 /1Tvo7rZgokMJTKid86YzZiDBhBbYZJreqvzXiX6aR/zmXDenrohf5vEFs3LcsT/eMf7WNmr
 KJCbmpXN1ba2rzwkOnTpupE36zPKOHxO4wSoDd4xCzxBvc6W5HTBa7N4Le02R9t2JseR6iBP
 KL1bxJ2dQ7nbA9hM2wIGb0hzcOwqHvNXmBH/Qf9Sa0fvDGIkV0ZPKLWGNDYYMCQTMNZ2EORv
 Hvb/n/RCwsfcteYzFKt22iwi+r4uDL0UYMfCpW17vdvxlaUwwQ7EhQWSF/9uvi/hU6WUshab
 UcT/0IGpK4+7hbzFoHVUBixoXrCtRkZM/JXF+A58wiLxrDj6gCVHHUfTjVBZdols+c7XTUvk
 FSOmrvBGztrt7GETGOHwb2dpziyJCs9IHcLYGkPSg5ty8nupsQ/gwzCSv5nEbWplZvlFDfo2
 TeIoSMiwbIJgqYj1a+24FTGiDKEvYXSQ0g+4QC/dmC46gJ0Yqa1aoru7kLUhd5HKIuaVVCHs
 GIzh9mF7OsOAJeOkwSAWOwIWrqu4p6tKybAiFRiG50g8TWF+HO5e41UpjZkKy9U3t0sIGGzJ
 hWJ4EUIucEVbCDCgbJLj5yZFc84loftGNrcUOHvSephWIdIS1+s83Q7DaKP5FzFnE8pmKA5H
 J6Ud8ewEHoXYZhaICqKq/Q1iuBzmHhvrY/HbdWilU7/iOvBDJKAYe5daAPmUwwv0E+TTOw5G
 f5kPMyW1w4XbuT6ZiTGmWL4BQFXdSZlbXwaRso+SwJiHuaEMDx5YxMy6el4E2CAo0iyvryQl
 kxRomcClDLCaYTvcG1mkExLZrL1RopYpnkmJyEqNlvA8yF9Otv2tP9FJsNvJ+lPGAlfIRhcF
 altlyKoWawnd9g6025FMcmVQHJKLUzDaf2y09qNP2FkIs8Iq/3h8d74ZAr/nBTi/QLs3fbSV
 4aIj1uBKbJaHlwKJJ+PNJqHkgPg1VBAybkadxaZfbFulLDErdECx9rZ1aRsfanh6Hzrm1On6
 uphKU5J9beW+9RuroihaGLth97BLtaS13FyRgHzxb23KTPb7iykx4pBW/yPZjfTSCX//6DKW
 Amf56uU3CQvkAkYvoxiPaxsyK5itdLjq6UDllZvHWnRbkTtAbRleyHU0c5Kv6xL57lYpQrpB
 R7fpogEYe2EaJH/DVocBAs5deDfh/sarSbfsKYuK0Lg6S4poLfeCRdOPwOBgTB2JaduNN932
 v8ovcMbslTtihcjPtucoDpT8mCAci4JX6k978lIC473kAs7jFpFZMWEWCPx5ZiObfRKM1Urf
 WDI1PaT2ewEyxObIXQpFHXL0e5Mvrg0uUhHnA0YOlCEutvZnftrjhdfxis6E1ZOxRJd3uMtZ
 mUybx9pJb+D9itDjdRYWzz+ABlIARCU9xCjy1YNk2GFHUCkWnaUcT84MOeJuksY73hdbn5Q+
 7TBkDTpVjPjfcfQ2CouWBE696y/HIIprgCSytq6G8mlHoUhZWu3i6CjUmMEth/7DJ5jn0bAv
 +RroL59ZKCT2fT8eEHn5112DYgtdS0=
IronPort-HdrOrdr: A9a23:5rekYK8np9YI6mIFdL9uk+DYI+orL9Y04lQ7vn2ZKCY/TiX2ra
 +TdZggtCMc6wxhOk3I++rvBEDoexq1n/MY3WB4B8bGYOCMghrKEGgN1+vf6gylMSv46eJHyK
 tsTq5bCNn9ZGIK6frH3A==
X-IronPort-AV: E=Sophos;i="5.87,180,1631592000"; 
   d="scan'208";a="56382673"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=dV/5fUcBqNpV1forc07pJN1B0HRbDXsxAXJfMbTrDr0Ggzc0ykY0jV9KoBfr35T/GNz0ifCAx9Oe3NgGQOer18TJEBrfRPRCnYSG0Jn48f+RWH+aoD7yXl8mgu9RcRRY3kfBdiuW7IkaBcHnTT0EMd8silDFk3Avd4zaEBA1BmDXMgQvAhdbuvdwoeJogbgnDxWuQK2aC/xH5xgAOopqQKHkvqjWVmXDMjJRcd/dGPnbRGjWcQaERwdc5N7/7qw9AM/XfiQUvsqQX3IwmnEh3Xb6T9T9bI6Y6rsP24UuTlvDM5E+AHr/CpoTmPQlNdKgi/+Z7OgsTU4l8LeVRD3xxg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=h+vmYW3W+r5oYDmBhfopIfv3ufDChDKH04CHssxa3rQ=;
 b=CT7KlVEavczvnxJsT42oW97YF1ZoVVIk8JAKbs7EcT4AkEKF1XVq/iAPr3BDV5135BGGxw0PMTrwuLnsIpTJKvmPLVzfvmD4gVq1olt3H4Mvu1hMD5qP5EvHoXSo/btabSeAHmes7qMhP5rjDAR/TUMuld82ZyAfZyXjo7zjOZyk95GaegpJv1NkN+MYrRUsSsMZzp5p5Vzxi5nkFFjzzvPdXn6wjkQt5igqjFv6aprfkwB+CleYMHhjGZDcxcivFHNVOhkba11TrWm8dL3Y6eKfE2FVHeq1oqjlfxVW2BHcltNN9IZO/yk6pgJ2sjp6qG8NKMJ38PB0Kq3TrakAOg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=h+vmYW3W+r5oYDmBhfopIfv3ufDChDKH04CHssxa3rQ=;
 b=PrQueacth3A3JPoZx5UjYcAeXWsV/jUh49SjJOu4l5Op/XAcIg9UCxmjUtxqpo7M2yuWBUNRfE9tUuOSjNlIXwCBAI0Ridr8uAq7FS8n90ZoAF2EAUhDDLv7VjPZPVPLPeOB44jhnMsbWOeQkMrADUf9+ZVSXRFrqe1NH2eE+9o=
Date: Mon, 25 Oct 2021 16:28:20 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: <xen-devel@lists.xenproject.org>, <julien@xen.org>,
	<sstabellini@kernel.org>, <oleksandr_tyshchenko@epam.com>,
	<volodymyr_babchuk@epam.com>, <Artem_Mygaiev@epam.com>,
	<bertrand.marquis@arm.com>, <rahul.singh@arm.com>, Oleksandr Andrushchenko
	<oleksandr_andrushchenko@epam.com>, Oleksandr Andrushchenko
	<andr2000@gmail.com>
Subject: Re: [PATCH v3 03/11] vpci/header: Move register assignments from
 init_bars
Message-ID: <YXa/BINQ4IKwg9ZE@MacBook-Air-de-Roger.local>
References: <20210930075223.860329-1-andr2000@gmail.com>
 <20210930075223.860329-4-andr2000@gmail.com>
 <YWbkZ216FbV8lBns@MacBook-Air-de-Roger.local>
 <01ce921f-cbc1-9524-0edd-47665b5db82c@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <01ce921f-cbc1-9524-0edd-47665b5db82c@suse.com>
X-ClientProxiedBy: MR1P264CA0067.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:501:3f::12) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 1dab0a69-82fd-45d9-cf05-08d997c3b4e0
X-MS-TrafficTypeDiagnostic: DM6PR03MB5178:
X-Microsoft-Antispam-PRVS: <DM6PR03MB5178A2DE45464C592DD64C448F839@DM6PR03MB5178.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: A8F2TspDzEVWZJ9OpyXnHZ/pW/CfNvg6cjgpSs8GXPnlVEEPEii7JzLkXNyhWXmJ1cxiCJGWy4A1dfi8nqLa0H85XoWwo3sj3mQKmCzSdFj0/+sJwYSmlzqPyOw/kSlf1+TiBAv+7D1QBXlLKyyNs7OUqhmjIhdmF0/CF8ehfI9q2etUFbUSdhfGdviLIeY4FYnumfEQryoT6ZJrvtoB3CF8IcRgUutAE13mXsNwVtFoPWO7WhXmacXlJHpR71nm3yfler5JwWmh3ZDGS5q/xGUD+oUa8qG8R5UG4Ww0vtgMncqB+ZPPkydxOcLGLiyxJO7NyRrhsnkpTtfacpHMIJECI6dsoqZ4urkPziLJGSLsfWHhEDM/FbsQsWahxuQsZnBsxwJJ3f/bRo+VUrOF7HCxcZz0I/G1ExARKwxdNt4jTJB95DM401qngWwLnci0UM8xeGhSZtwjz8k2a1MZTWVkQ9WYGVM7IyIhUuIIRG7x8GYfDYI1VTihDdhKnIkVtzqfeTpc2x8CQy1+bdNtwArAepgBkF2EIPh9qtU98xlqMPNvB6pEFxhbrPaDGmCupo+QNAHPMzPBagdm4ZcZcE+zeGfbUoqgLQCBewZXQteaE1a2DTNmSAF7m7UJRo7O7nLxUxT1/zOB/L+VxJl+RA==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(82960400001)(85182001)(6916009)(8936002)(186003)(86362001)(9686003)(53546011)(316002)(54906003)(6666004)(4326008)(66946007)(5660300002)(2906002)(6496006)(66556008)(66476007)(6486002)(956004)(508600001)(7416002)(38100700002)(26005)(8676002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Z2xKaWFvMnRKSGlKOVVBdTcweUppNHFXSHYrVjNOZzdxeGlXU0JpVUNJODFM?=
 =?utf-8?B?UEZsU0RXMW1zRGt3MkxmNkdrZmMxd292aG5qQjJnMlVCUWZaWTlGS3BHcGNQ?=
 =?utf-8?B?ZGxHR3FRKzB3a25sT0xZOFdHQUgyN3F6cm01cytEMmJSeFluV1pncmkxSU5a?=
 =?utf-8?B?UDVKdkFPWUMwK0M2ckJzSEozbVdyRlQzUE5aRC9PdUVzV09EWGpYVE5VbHV2?=
 =?utf-8?B?QkM0UkhkMmprZWM4TW1lMUtpS0tHN2xXVmFDNjZjUlJ2Y1oycENXa0IvN1Zk?=
 =?utf-8?B?RlNFZmdlT0F1TDdkbVlWbi9MRzF0blRZYlpKVHh4TmloY214N0RDS1RTZ1dX?=
 =?utf-8?B?ODd3NUdaOVRMK0dzMDVXdy9FSW5KeHZjN0hqQStQNE12SW9obURHaVY0bmE5?=
 =?utf-8?B?L2t1N2tqRkwwNlRHNHNJRGJEOVA5Yno0by9JMU1wZlRYNjN6L1hJSUE2WS9h?=
 =?utf-8?B?NE5nWnFDcDVnK2pjRUh4bXVpUXYzQlRvbkRFR2VoTEF3WWVUMDJrQmdRN3BT?=
 =?utf-8?B?NXlQY3pnYXU5OUQ5andsV25SRDg0U1pUTzJ1Qk5HUjhEVTVOV1FGMzRnb2pM?=
 =?utf-8?B?UlRlSHAxSU5lVHlydUVwcFNPWU1DVzV6QmpwbkdVdEsvUXRGSDRnNmIrTmh1?=
 =?utf-8?B?QTdrNmc0MjhSaEtoMlJ0Q0gwNVlxbnovVXVOaWFpNFR1VzR2MWl2VDQ2eGhV?=
 =?utf-8?B?cUZCR1dDWjI3eFRqSXkzalZLYTdwZTRwTW90SWkvSE40N1BRRjJ4S1lkU2dC?=
 =?utf-8?B?eUhGbVM5ZjFjTHRBMlJnMlZoUm5MNStwZDJpR1MrV1NuTDFZTjBjaUs5QWkz?=
 =?utf-8?B?UHFNK2JESWdmZld4UVVJZFA5OWhFOG9pbHdZTU9YejZHdUxBTmljMnNvNkNR?=
 =?utf-8?B?ZDBKUzhUWTF2bVAxa3pkN1dzMHRhYnYxOGR0NmdBODV6dHlzcDhDUG85WHR6?=
 =?utf-8?B?RzhXeERoTEY4YWQ1VS9XNkg1YStuVFlhMElWd0ZxUnJqWXF0ODdWbXZ0cm1P?=
 =?utf-8?B?NnA3S2J0bmM1bjVEdzBaSitYL1Vhcm1Sa1J4Y29vNnFJVlhYVzhzanFGc2ty?=
 =?utf-8?B?akpZWGZRTDFTMldHNzM3d0JDdWIydUhlRnZTRzhVZUFmWTV5UWpWZy90M2Np?=
 =?utf-8?B?b21lWThBUTdFSHFHWlVXTEZLR2JuRHdINGNpbTZPR2V3bnlkaWJqb2pXSEow?=
 =?utf-8?B?QnJialJ2NUhKdVFZVzE1YjRRMnI5VzBkalZkTFFUUVNnREdHRU5vWml4UUNS?=
 =?utf-8?B?elkwWXpHSTlMaG8xVSswR3YvNnJ1VFZMU2tWMmYzWmhRdmgvT01pYmErK0hT?=
 =?utf-8?B?aEVnd2d2N1dRd1ZlQXNlZ01hVk1PZ1lydkp5MTdEdURjbnpCZ0N4SUd3eitM?=
 =?utf-8?B?dlJGMGtSTFVMVFY1NVcxdlpNYnF4V0trZ0pveW4vZXc4RnVKUEI4MGhzZEhW?=
 =?utf-8?B?aHZYbjFWYTNSSDF4UFJSSGh5ckErcEZrVWUxTHk5cDVHcXp0YysvM1I3ZUwy?=
 =?utf-8?B?d1MydU9qNUgrNlJaazhCUkxOREF3QlJ1RzRjbXJHWk9iS3pXS1gyRmcvSE1t?=
 =?utf-8?B?d1FDRTFUWS8wK0dvY3c0UzJBcm16bzdndHVkT2FQbjVqbW9RdFNNOW0xMnIx?=
 =?utf-8?B?c3ZsK1hjYTJxcGR1T2FkdUpGWWtOSm9uQ3lkK1h2YWFacGo2WXVjbWs1RlA2?=
 =?utf-8?B?cjZoMG5ROEdWUTZoSGVaa1hEYmVYZndmVk5ERzI1cjhZMlRNK2ZGTDdVcHJZ?=
 =?utf-8?B?TTAyZ1ZMMkVtY21aVDFGclVNUGhRZmVxTGhYSWxSNUNrU0tjVkFLR0xvSURx?=
 =?utf-8?B?S0xpcDdvSTlvOTdBQTNVRGhKa0Nld1pxVStOd2JjVDI1NmdCK3RNQS9iVUJp?=
 =?utf-8?B?cUlPeDA0eEdWa2taby9ERytLcHd0cXhqY3oyK1FIbTFUSE9PdUJJSnVEQjFO?=
 =?utf-8?B?MXBFRHBURHYzRWdZZ2V4eUdnbGxCekRFVW5semxGak1hTGlWNXhCengySjFY?=
 =?utf-8?B?K1lSS08xNXBwbFZraHNKVVdlVXlKRnllQ0IxWGU2Tks5cUJpNmpFZnFVSFVM?=
 =?utf-8?B?R0FHSDRaaXA5ektpenZNYTVSWEU4c3RyTzZaYVFOQ0ZrSnRIUzZoTldPbmRY?=
 =?utf-8?B?OCtpcjhRK01LcUdvQ0Q0emFOWnE5alZUUTdCOGUxUkFaaFArNHl5Z3h3RktS?=
 =?utf-8?Q?3/KTpBvLeB6RsspoKk58C5Q=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 1dab0a69-82fd-45d9-cf05-08d997c3b4e0
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2021 14:28:26.1283
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5dCCt+yd7lau6pvFYJr1D06xALojgyOKzzoZv/Hgk20dDZb/7D25tMUQhGK/ovWgyEgHoRtbGEAPt3vkkBAhVw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB5178
X-OriginatorOrg: citrix.com

On Fri, Oct 15, 2021 at 08:04:56AM +0200, Jan Beulich wrote:
> On 13.10.2021 15:51, Roger Pau Monné wrote:
> > On Thu, Sep 30, 2021 at 10:52:15AM +0300, Oleksandr Andrushchenko wrote:
> >> --- a/xen/drivers/vpci/header.c
> >> +++ b/xen/drivers/vpci/header.c
> >> @@ -445,6 +445,55 @@ static void rom_write(const struct pci_dev *pdev, unsigned int reg,
> >>          rom->addr = val & PCI_ROM_ADDRESS_MASK;
> >>  }
> >>  
> >> +static int add_bar_handlers(const struct pci_dev *pdev)
> > 
> > Making this const is again misleading IMO, as you end up modifying
> > fields inside the pdev, you get away with it because vpci data is
> > stored in a pointer.
> 
> I think it was me who asked for const to be added in places like this
> one. vpci data hanging off of struct pci_dev is an implementation
> artifact imo, not an unavoidable connection. In principle the vpci
> data corresponding to a physical device could also be looked up using
> e.g. SBDF.

I was considering vPCI part an intrinsic part of the pci_dev, but I
can see you thinking otherwise. We similarly have other pieces of data
hanging off pci_dev, so I think it's hard to tell which ones as fine
to have as part of the struct vs as pointer references.

> Here the intention really is to leave the physical device unchanged;
> that's what the const documents (apart from enforcing).

Ack. I wouldn't have asked for those myself, but as said above I can
see your point.

Regards, Roger.


From xen-devel-bounces@lists.xenproject.org Mon Oct 25 15:20:32 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Oct 2021 15:20:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.215911.375331 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mf1lj-0004R7-8X; Mon, 25 Oct 2021 15:20:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 215911.375331; Mon, 25 Oct 2021 15:20:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mf1lj-0004R0-5G; Mon, 25 Oct 2021 15:20:11 +0000
Received: by outflank-mailman (input) for mailman id 215911;
 Mon, 25 Oct 2021 15:20:09 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=cQdO=PN=kernel.org=patchwork-bot+netdevbpf@srs-us1.protection.inumbo.net>)
 id 1mf1lh-0004Qu-KZ
 for xen-devel@lists.xenproject.org; Mon, 25 Oct 2021 15:20:09 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 099f91be-35a7-11ec-8412-12813bfff9fa;
 Mon, 25 Oct 2021 15:20:08 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPS id 81D8761002;
 Mon, 25 Oct 2021 15:20:07 +0000 (UTC)
Received: from pdx-korg-docbuild-2.ci.codeaurora.org (localhost.localdomain
 [127.0.0.1])
 by pdx-korg-docbuild-2.ci.codeaurora.org (Postfix) with ESMTP id 75A5160A90;
 Mon, 25 Oct 2021 15:20:07 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 099f91be-35a7-11ec-8412-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1635175207;
	bh=WM+L1dS+a4rW8Lt5WrZtY3DV1C0j4eZjE+YNZPl+PNI=;
	h=Subject:From:Date:References:In-Reply-To:To:Cc:From;
	b=IqqsIqOa4sNpaOm+nmiqIDTXTqOIcwQRyX6AoasoGwdTB/EYB/aVKAJVqBh7hTciC
	 DEPsBSkUEtor3OUpoDATqciplVT+q73mtvBgaCOY7VGFnuHEJHlJ+azlfLwisgluad
	 oQLWgARcvNABFwOoSdYMV8HGXIPh/AequFhAen1LVTGq0sUAvS1c/Z19ZDHzx7uDIT
	 fyzSrC2UYdRdEfMshKq9Tw508iZXEsb4Sc5ka5nv7PvVgFNisw5h8QoRB9sU6e0DQE
	 Wok7kpEb2GQsPncTyIndQ3Fhqdj2+EKJlMUj6CrSyz6vXQFZaTecq5upNvaJ+E3I1c
	 VBfK3kHDYcesA==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Subject: Re: [PATCH 1/1] xen/netfront: stop tx queues during live migration
From: patchwork-bot+netdevbpf@kernel.org
Message-Id: 
 <163517520747.28215.3424375634925343412.git-patchwork-notify@kernel.org>
Date: Mon, 25 Oct 2021 15:20:07 +0000
References: <20211022233139.31775-1-dongli.zhang@oracle.com>
In-Reply-To: <20211022233139.31775-1-dongli.zhang@oracle.com>
To: Dongli Zhang <dongli.zhang@oracle.com>
Cc: xen-devel@lists.xenproject.org, netdev@vger.kernel.org,
 linux-kernel@vger.kernel.org, boris.ostrovsky@oracle.com, jgross@suse.com,
 sstabellini@kernel.org, davem@davemloft.net, kuba@kernel.org,
 joe.jin@oracle.com

Hello:

This patch was applied to netdev/net.git (master)
by David S. Miller <davem@davemloft.net>:

On Fri, 22 Oct 2021 16:31:39 -0700 you wrote:
> The tx queues are not stopped during the live migration. As a result, the
> ndo_start_xmit() may access netfront_info->queues which is freed by
> talk_to_netback()->xennet_destroy_queues().
> 
> This patch is to netif_device_detach() at the beginning of xen-netfront
> resuming, and netif_device_attach() at the end of resuming.
> 
> [...]

Here is the summary with links:
  - [1/1] xen/netfront: stop tx queues during live migration
    https://git.kernel.org/netdev/net/c/042b2046d0f0

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html




From xen-devel-bounces@lists.xenproject.org Mon Oct 25 15:41:50 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Oct 2021 15:41:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.215918.375342 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mf26c-0006mH-2H; Mon, 25 Oct 2021 15:41:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 215918.375342; Mon, 25 Oct 2021 15:41:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mf26b-0006mA-UZ; Mon, 25 Oct 2021 15:41:45 +0000
Received: by outflank-mailman (input) for mailman id 215918;
 Mon, 25 Oct 2021 15:41:44 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mf26a-0006m4-J6
 for xen-devel@lists.xenproject.org; Mon, 25 Oct 2021 15:41:44 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mf26a-0008Ar-Gk
 for xen-devel@lists.xenproject.org; Mon, 25 Oct 2021 15:41:44 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mf26a-00030I-Ff
 for xen-devel@lists.xenproject.org; Mon, 25 Oct 2021 15:41:44 +0000
Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89)
 (envelope-from <iwj@xenproject.org>)
 id 1mf26L-0001nb-Hq; Mon, 25 Oct 2021 16:41:29 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date
	:Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From;
	bh=pEL+FH4801QYmbueGkAjm/7yZrw1qGwVC8mP4SJlSRs=; b=2J3i0P6Wu48J1nR/r5zDY+BK9U
	61JWeoxjLEGw/ONNJ6HmXX3j6SQm6cQrZv+fr0oUGfsy8rpYjymrc8mWqcEiGnu2OmZ+dcFOiY43A
	uwE2Ugdfj/eEssgcJ00E6QghrTvpx+FdAwYodOnvDt3ewFbhXgJ3nlmUSVu+V3oNfGts=;
From: Ian Jackson <iwj@xenproject.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <24950.53279.231480.258175@mariner.uk.xensource.com>
Date: Mon, 25 Oct 2021 16:41:19 +0100
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: Anthony PERARD <anthony.perard@citrix.com>,
    xen-devel@lists.xenproject.org,
    wl@xen.org,
    andrew.cooper3@citrix.com,
    Doug Goldstein <cardoe@cardoe.com>
Subject: Re: [XEN PATCH] automation: actually build with clang for
 ubuntu-focal-clang* jobs
In-Reply-To: <alpine.DEB.2.21.2110221454060.2311@sstabellini-ThinkPad-T480s>
References: <20211022163644.547018-1-anthony.perard@citrix.com>
	<alpine.DEB.2.21.2110220957220.2311@sstabellini-ThinkPad-T480s>
	<alpine.DEB.2.21.2110221454060.2311@sstabellini-ThinkPad-T480s>
X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu)

Stefano Stabellini writes ("Re: [XEN PATCH] automation: actually build with clang for ubuntu-focal-clang* jobs"):
> On Fri, 22 Oct 2021, Stefano Stabellini wrote:
> > On Fri, 22 Oct 2021, Anthony PERARD wrote:
> > > Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
> > 
> > Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
> 
> FYI I verified that the patch doesn't break gitlab-ci so as far as I am
> concerned this patch can be committed any time. (I didn't commit it
> myself to give more time in case someone might want to provide
> additional feedback or voice any concern.)

I have committed it.

Thanks,
Ian.


From xen-devel-bounces@lists.xenproject.org Mon Oct 25 15:45:27 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Oct 2021 15:45:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.215926.375357 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mf2AA-0007Si-KP; Mon, 25 Oct 2021 15:45:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 215926.375357; Mon, 25 Oct 2021 15:45:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mf2AA-0007Sb-Ft; Mon, 25 Oct 2021 15:45:26 +0000
Received: by outflank-mailman (input) for mailman id 215926;
 Mon, 25 Oct 2021 15:45:25 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mf2A9-0007SV-Jk
 for xen-devel@lists.xenproject.org; Mon, 25 Oct 2021 15:45:25 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mf2A9-0008Ec-IS
 for xen-devel@lists.xenproject.org; Mon, 25 Oct 2021 15:45:25 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mf2A9-0003Nl-Hb
 for xen-devel@lists.xenproject.org; Mon, 25 Oct 2021 15:45:25 +0000
Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89)
 (envelope-from <iwj@xenproject.org>)
 id 1mf29w-0001rj-11; Mon, 25 Oct 2021 16:45:12 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date
	:Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From;
	bh=R4sW0V8psbkBf+P6MfI4V87VbG1EvOABYc4iyWKuw/I=; b=BfSbj2UpIiGCRJzYqIx4cXFf4+
	+hvVlYiEpXGDILJ3hZQQWQUt3tQNDiSdf1G1SPFQ57q8KjGPmnhiqZRC+Wb3g1a8IuJ4MMK7a9SV+
	Cwo+AIzvsLE8jozCEY6eq1PO/G3/blp7y59UVaKiZqm4aIK8RsHotyLlImXfzaKoLPYU=;
From: Ian Jackson <iwj@xenproject.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <24950.53501.802356.661667@mariner.uk.xensource.com>
Date: Mon, 25 Oct 2021 16:45:01 +0100
To: Juergen Gross <jgross@suse.com>
Cc: xen-devel@lists.xenproject.org,
Subject: Re: [PATCH v2] OSStest: explicitly enable building qemu-traditional
In-Reply-To: <20211025095438.27599-1-jgross@suse.com>
References: <20211025095438.27599-1-jgross@suse.com>
X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu)

Juergen Gross writes ("[PATCH v2] OSStest: explicitly enable building qemu-traditional"):
> It is planned to no longer build qemu-traditional per default.
> 
> In order to be able to continue running tests with ioemu-stubdom run
> configure with --enable-qemu-traditional.
> 
> Signed-off-by: Juergen Gross <jgross@suse.com>

Acked-by: Ian Jackson <iwj@xenproject.org>
Release-Acked-by: Ian Jackson <iwj@xenproject.org>

And pushed to osstest pretest.  I will let you know how it goes.

Thanks,
Ian.


From xen-devel-bounces@lists.xenproject.org Mon Oct 25 15:48:23 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Oct 2021 15:48:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.215932.375367 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mf2Cx-000855-1C; Mon, 25 Oct 2021 15:48:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 215932.375367; Mon, 25 Oct 2021 15:48:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mf2Cw-00084y-UR; Mon, 25 Oct 2021 15:48:18 +0000
Received: by outflank-mailman (input) for mailman id 215932;
 Mon, 25 Oct 2021 15:48:17 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=G2Ub=PN=citrix.com=roger.pau@srs-us1.protection.inumbo.net>)
 id 1mf2Cv-00084m-Cq
 for xen-devel@lists.xenproject.org; Mon, 25 Oct 2021 15:48:17 +0000
Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 8bd302a2-de52-48e3-b937-4fbec1a48bcf;
 Mon, 25 Oct 2021 15:48:15 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8bd302a2-de52-48e3-b937-4fbec1a48bcf
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1635176895;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=12MJVt6yrc8x54FEBoKJKDIpPCbNWC4oL/WjWWexQtQ=;
  b=h5h9flex4YR2yBuIkoEWpvuwNr8reliMFbQFohph9/tRsq3pEbmTuwhl
   bhvFeYy01AlX1DVK1fIS13JYOqKyJ//dPlYkiSdcG/IJ4za4eoeSsw0WG
   vnWWBKeHGRvqE5vYKpP0Bma0S7EM+lYs1xQFjvGIH2XQQ29uwWxv1ibG/
   c=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: g2RhN9VJXAt9kwDt5f1nXqr7ukuh7JLIwOTaXSODPuMNK9AngMp+ve+3qr8TueBzs92RVcEy4r
 S/3lDwiFPC8bCuwnVboFyJi8lzq4nN7bP2Oe2lL0hH9BHCDekjLh7x/0fx19x9ldaB5nyl/TQn
 ertnyJ8Tdgv/ZtZVaulqyTv2nJ781qk6MCTgfU3OlxtOV9edSrG5mz0fXZCOpw+PGY2yoj57Q4
 yd5xn58D3qgEvBbqfNujzqDeFTU+0soMgYid1OqSIZY8C3t4kBwahuzLe/71VMpX+bmaW0JfIa
 cFQ2dL/dfZiNM4ZxeaOJpX2z
X-SBRS: 5.1
X-MesageID: 55999716
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:8wFdQ6NzPjrm84/vrR2NkcFynXyQoLVcMsEvi/4bfWQNrUom0WBUx
 zQcW2qCPPqOYjHxfoskYIrjpkoG65GHx9MwSgto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdpJYz/uUGuCJQUNUjMlkfZKhTr6bUsxNbVU8En540Ug+w7RRbrNA2rBVPSvc4
 bsenOWHULOV82Yc3rU8sv/rRLtH5ZweiRtA1rAMTakjUGz2zhH5OKk3N6CpR0YUd6EPdgKMq
 0Qv+5nilo/R109F5tpICd8XeGVSKlLZFVDmZna7x8FOK/WNz8A/+v9TCRYSVatYo2qPhepO6
 tpJiZW5EkQUL4jcuOEYTyANRkmSPYUekFPGCX22sMjVxEzaaXr8hf5pCSnaP6VBpLwxWzsXs
 6VFdnZdNXhvhMrvqF6/YvNrick5atHiIasUu216zCGfBvEjKXzGa/iXtI4Jg25u7ixINd+FS
 MMTRRN/UEzNXwVhYFc7FLA5sc790xETdBUH8QnI9MLb+VP7zgZ8zbzsO9r9YcGRSINemUPwj
 kvc42n8NTQLO9WexCSt/2qlg6nEmiaTcIgfDqGi//hmxlia3HUOCQY+XEG+5/K+jyaWXNZSK
 Fcd/CY0mqE0+Fa2Vdn2XxC+o3msswYVXpxbFOhSwBuEyrfQpR2YAGcEZjdbbZots8pebSIt0
 liFjtb4HwtlubeeSW+e3rqMpDb0Mi8QRUcSaClBQQYb7t3LpIAokgmJXttlCLSyjND+BXf32
 T/ihCE4i69J1ZZT/6q+9FHDxTmro/DhTBMx5wjRdnKo6EV+foHNT4us5FvA5PBMNrGFX0KBt
 3gJncuZxO0WBJTLnyuIKM0WB62g7fuBNDzagHZsEoMn+jDr/GSsFb28+xkneh0vaJxdP2a0P
 gmD4mu9+aO/IlP1a7VNXKC+D/gjxPOjKMXARtDRa8Z3N80ZmBC8wAliYkuZ3mbImUcqkL0iN
 ZrzTftAHUr2Gow8k2LoH7Z1PasDg3lknzuKFM+TIwGPiOLGPBaopaE53ExihwzTxJiPpxnJ6
 J5hPs+OxgQ3vAbWM3SPr9B7wbznKxEG6XHKRy5/K7brzulOQjhJ5xrtLVQJINQNokitvr2Ul
 kxRo2cBoLYFuVXJKB+RdldoY671UJB0oBoTZHJ3YA/wgyJyOd71vM/zkqfbm5F9pISPKtYvF
 5E4lzioWKwTGlwrBRxENfERU7COhDz03FnTbkJJkRA0foJ6RhyhxzMXVlCHycX6NQLu7ZFWi
 +T5jmvzGMNfLyw/XJe+QK/+lDuZ4ClC8N+eqmOVe7G/jm23q9M0Q8Ew59dqS/wxxeLrn2rKi
 V3OWkxG9IEgYeYdqbH0uExNlK/we8NWFUtGBWjLq7GwMCjR5G24xoFcFu2PeFjguKncos1Ov
 M1ZkKPxNuMphlFPv9YuGrpn1/tmtdDuu6Vb3kJvG3CSNwanDbZpI3+n28hTt/ISmu8F6FXuA
 k/fqMNHPbipOd/+FAJDLgQSceneh+ofnSPf7KppLRyitjN35reOTW5bIwKI1H5GNLJwPY58m
 bUhtcca5haRkB0vNtra3ClY+37Vdi4LUrk9t4FcC4ju01J5xlZHaJ3aKyn3/JDQNIkcbhh0e
 meZ3fOQia5dy0zOd2sIOULMhecN144TvB1qzUMZIwjbkNTymfJqjgZa9i46T1oJw0wfgf5zI
 GViK2Z8Ob6Ko2VznMFGUm2hR1NBCRme9hCjwlcFjjSEHUyhV2iLJ2whI+edukse9jsELDRc+
 biZzkfjUCrrI56tjndjBxY9pqyxV8F1+y3DhNujTpaMEJQNaDb4hrOjODgToBz9DMJt3EDKq
 IGGJgqrhXEX4cLIn5AGNg==
IronPort-HdrOrdr: A9a23:B1RJqamwNzk5MiU3qWOKWL7gjKnpDfPIimdD5ihNYBxZY6Wkfp
 +V88jzhCWZtN9OYhwdcLC7WZVpQRvnhPlICK0qTM2ftWjdyRCVxeRZg7cKrAeQeREWmtQtsJ
 uINpIOdeEYbmIK8/oSgjPIaurIqePvmMvD5Za8vgZQpENRGtldBm9Ce3mm+yZNNW977PQCZf
 6hDp0tnUvdRZ1bVLXxOlA1G8z44/HbnpPvZhALQzYh9Qm1lDutrJr3CQKR0BsyWy5Ghe5Kyx
 mJryXJooGY992rwB7V0GHeq7xQhdva09NGQOiBkNIcJDnAghuhIK5hR7qBljYop/zH0idhrP
 D85zMbe+hj4XLYeW+45TPrxgnbyT4rr0TvzFeJ6EGT1/DRdXYfMY5slIhZehzW5w4Lp9dnyp
 9G2Gqfqt5+EQ7AtD6V3amHazha0m6P5VYym+8aiHJSFaEEbqVKkIAZ9ERJVL8dASPB7pw9Gu
 UGNrCS2B9vSyLbU5nlhBgt/DT1NU5DXCtuA3Jy9vB96gIm3UyQlCAjtYkidnRpzuNLd3AL3Z
 WBDk1SrsA8ciYhV9MIOA4we7rGNoXze2O/DIuzGyWvKEhVAQOEl3bIiI9Fkd1CPqZ4i6cPpA
 ==
X-IronPort-AV: E=Sophos;i="5.87,181,1631592000"; 
   d="scan'208";a="55999716"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=mr49AvhJvE3q2GxVZHvwKL2HDkoEblkMUFLDinPFJoS3oKhKyYX51uKLUbbRMCEPG16FX93pe6o6gzWMq5pwNn+xaltBe34KWfPaYsG89ZE35S4qJMf3R1mCsEhaz15ng2eSR35GBbhfIPuB0qERnoOZ6IKAZ1Q/E1M+l5Gjq2W2KNplgMDXmkPDUkI+WZ9vfIbZcIDxdEGZXLjh5P5jtXHRAWX4a4epuRGb5Dyl5WEO2llCcw0vh+0B88YHBkOgH9a5it+iaaFYJWKQAnJWv8jZZKckXs14XRE/JOeadesddUMLxL8q1m6PY+pkA/CAvvus9JlCFdX0sOZ9uiiwWg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Dh1i9o1bNKJfQ0T4SfKY4z2f9l77ooKn2b2EAtp4JW0=;
 b=mBHSwl0uy4qtcoBYbBiB6esz5Fv4aff/BfGv37unHfB5FLpoiFc0VkqMM1Ka9IIv7Q3sNE7UoQAG2u6ZN0tMKXxJoZDet7NN/wKKbYs79bvRtrUn43NrBSD/sF889ZTrVPuz0o6mMSuZlTY2b8Sve9wupbSudBzOs0D7FbWW6Tr5jngSYzExoMnJvGDaMfH4nSFganKkvufOn4kn79f6OHxJggp/9a9SHKIaBHlI6gU3ATPDnol+oWYPkW3RxCvyUryj9EXZqbd4MiLdpxltIpLZYFlma5MUg9qa2LRjr6Ho6l4wL+7StVmxVZ16sBlyygb4tPG3nLwm2/fdGLo5eA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Dh1i9o1bNKJfQ0T4SfKY4z2f9l77ooKn2b2EAtp4JW0=;
 b=FVWqrLZYy0sM4qqGlV+zc/AOAF9Aw1e+HbFHk7FlXrAurT+MMd+QMI5lp3JIJSo4QH7LyEPSmiKA2NtUzc5hfcgkLrkoQ29Jj9rgbhgKLTmS7VQNRRQwYuDRVTiGilqYdci+P6dpUDumSkcosQefLjgu2dSl9pw86sHi3GFQ0f8=
Date: Mon, 25 Oct 2021 17:48:01 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Oleksandr Andrushchenko <andr2000@gmail.com>
CC: <xen-devel@lists.xenproject.org>, <julien@xen.org>,
	<sstabellini@kernel.org>, <oleksandr_tyshchenko@epam.com>,
	<volodymyr_babchuk@epam.com>, <Artem_Mygaiev@epam.com>, <jbeulich@suse.com>,
	<bertrand.marquis@arm.com>, <rahul.singh@arm.com>, Oleksandr Andrushchenko
	<oleksandr_andrushchenko@epam.com>
Subject: Re: [PATCH v3 04/11] vpci/header: Add and remove register handlers
 dynamically
Message-ID: <YXbRsbzLxZs94v0Z@MacBook-Air-de-Roger.local>
References: <20210930075223.860329-1-andr2000@gmail.com>
 <20210930075223.860329-5-andr2000@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20210930075223.860329-5-andr2000@gmail.com>
X-ClientProxiedBy: PR3P195CA0005.EURP195.PROD.OUTLOOK.COM
 (2603:10a6:102:b6::10) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 24ab46bf-df97-4367-ca1d-08d997ced680
X-MS-TrafficTypeDiagnostic: DM5PR03MB3291:
X-Microsoft-Antispam-PRVS: <DM5PR03MB32917016E564B11A55DD2FE98F839@DM5PR03MB3291.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 89MTW79B8+wn6svHPLceAB1u128Pcjqbgh2L64Hm1jwsXW8uTCuRPN8h0+chs3UfPHedPPN27vf5WNb3gVW4Kcmu7EryQ0vty1YHfCTgpK5dpX+7gQr33ScVQTTtm/Pm6ghR4hxX5d+4NoWs8QhJ81d7oVCuqT2s7ogQR0n+eu180tycMohitJuCc48K770uTBsU58cKdaQET70TD5WIDO734xfdIwCmC5tIeuVFOX3DtsFR3CAoXBr8n6n7I7s1UeVxn2q2ZjsnkOA7ZUfunTkwyYC012kVk+kao2YKRV+Ly7X79x+6vXfgnuGBk9iufMGY9Oa0ssVdAUYTHwSLGjG+EJlp3cgxI6O4bcjyeVHm9O7RzNfonalwUayBwQbT3hivKQ5Q1oeCJsDQQli+9Dmg3/qjfXnympauFFOAykKg1DzC+Chp0KzFBdUEsefe8HeK7VwYX2Z7Qyuv8OZB1+DCbg+IV+OLYaHI/jp1MvLp34fOd/8/KRM9oVM5+wiydKQiqhkX7Z0qdQQMfH/B2a3RE5rKyj/Kzs7ny4H9+HDkLxkvfwjiZOEv1DZhljV6l+/R2LMaKjYiH5CJ1v69f3IE0xc7GwBRB+cWGn07TcAHJsCzajKXEXKUqFrUlrMCW3ueQRvD7rs4Ag4dpXf+wQ==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(83380400001)(6916009)(956004)(186003)(82960400001)(6486002)(8676002)(26005)(38100700002)(85182001)(8936002)(5660300002)(2906002)(86362001)(7416002)(66556008)(316002)(66946007)(4326008)(66476007)(6496006)(6666004)(508600001)(9686003);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K1lUeC81Q2U5YVd5OFJLSGRnVnVaUFQwQmZIS09QY3JrcXl2SDIzQVczT3Yy?=
 =?utf-8?B?VkVLR3hwNVRXMUxvSEZzTHBScVhZZUlaWHpQckU4ZUZjVHdSekRCc3hKQ1Fx?=
 =?utf-8?B?bzhvcFNRR1YxbHNpS0tpbnU5aFhJU0pLZzdQeFBBbVZ6Q3V3NUpVWENMZDl6?=
 =?utf-8?B?cHdSNkErYjV3M0U4dm85aXQ1dFJsSFdRNGFDa2tiWENFSWVPaE56eFV3alJI?=
 =?utf-8?B?VDlHOFp4WlJqYm9tblUvSElBQTIrZ1N4R1Zra0xSVGtRSXU1Mng0OEVHQ0JQ?=
 =?utf-8?B?ZitVa2NJb25YU2FPdU9ZeDJ6c2tLOFBLWERaSng2RTlmcTJrYjFndVlFRjA5?=
 =?utf-8?B?d0krQ2ovbGhOZURFYllBUE0zdDI4am0wWnNRSEhzU0w2azBnK0llVkYvc3ND?=
 =?utf-8?B?K2phSFNpUnlLbi9MWThuaU9SMEI0bE5uWXRYQjZ3WnRZdERrK0tac3gvUjBl?=
 =?utf-8?B?c1VrcEVnNlc3TWlnbEdBcVNsVzJ3SklmVTNzdDZhbytQdkc1bnN6azlNcWtL?=
 =?utf-8?B?eDg1YVpyZG5yYnFRL1p3eWcvTXF2RnlaNnBDMEJwUFZTZ0NUS2xsdmI1RFov?=
 =?utf-8?B?UytyYXBQcjZDa0R3aEdBeU81eFM4RmdTd2VaQzRWNnRnTFFMQWRDMW9pNHRr?=
 =?utf-8?B?U2grMnU5SEh4R2xaZmRmSm1rck52elBRY1FneEJYTCtoakRYY1BvR2xoejRT?=
 =?utf-8?B?MituM2JPakpya1htclpVb1ZDL1RxK3BTMnNhMStXYmE4aW1DVGt5TW1NNWZx?=
 =?utf-8?B?RVpkVnoyd0d4ZURTTTBMdXpkUjZDamNPS0czQkZwVXJFMVV4ZVJtUVZXZnA5?=
 =?utf-8?B?dk5PK1luUTJIa2tvckxXdXo3ZlE0ZWtuWVlFWFE4RjRlRTE3OU9WNEdodXZ5?=
 =?utf-8?B?RHV6azFoTjNJSStRQ2ZEMnE2SU03MW03akc3blB1ckNyNkkvWEY3NHBITCtU?=
 =?utf-8?B?elZYY1BkOVB2QUdsSmtueWNoWTJiYzFpYjhKL04yOGtXRFZlRzdoWlYwMThF?=
 =?utf-8?B?VG5aU2prYTA2QnhUeEFxTUNuUmEyanRLWCtLN255V3VmRExiaHV0SVpiL3lK?=
 =?utf-8?B?Q0hQV1N0ZnVlM25hbHRxUWhWTXp6dnJhL1BCQm9HZWMxaXNiSFRqQ1kyc0Yr?=
 =?utf-8?B?S2FYb3NEcUcwKzNBRndiZHE0RlM2NnNIYmZ5YjF3M1hsWFlBdlVyMUc0U3V1?=
 =?utf-8?B?dUhnNFI2SVdQTktqTit4MkVoMU1GSXhwMGhWZHRDZVVoczBQMTFBOVN1eGZx?=
 =?utf-8?B?Tmo1WlMzdHJxVSt0dFlacEZhWU1KUDU2ZFpoYVViNVI1Uk1wTG1RejJJa0hq?=
 =?utf-8?B?cVRUNjhvczh3WHduVWNjZDZKeDVzaEVabmsyemMvZjAzejRseVQxNUZZZndk?=
 =?utf-8?B?Mk5JdU53RU9vWnkwb2R5SVZxR0dpdDF2SmV0Ukp4ZFJOSTQweEVNSHNMTG5r?=
 =?utf-8?B?dmJHK0lrZDF5bU1ZWjl1enIrMzBSQkdCZitqdjlVWGVTR0t1NDZOaWFPWE5B?=
 =?utf-8?B?eDBYc0pKTy9QdnhiVkF6bXZyK3NHb2JqMDdoOXVaZWNqbGZ2Ly8ydmZjRTRH?=
 =?utf-8?B?ZmY4NkFnbklPQXZLaWxaWktZN0ZCQWdINHJrTVRrM0Z1Vm5BUFdXVXE1WTR3?=
 =?utf-8?B?UCsrTXgrV1dVeWtmVHlNVHYzZTBOQ1NMbHpBQnVtZzQva0dReDhoMVRPRURt?=
 =?utf-8?B?ZnRWY1JBY3FKQTVBZ1MxOFhFZzZsZXk5ZHJmOGZhRk5Cd1NqMThUUS8rQkJs?=
 =?utf-8?B?WXJ2cHFuMEx1Wkt4bVpEWngwdXY1bW1zUWF5aElsd1RjTTIrWDVZbHRST3VJ?=
 =?utf-8?B?YWI4MlVNWFZoRm5veFdrdG1hYWtsUFRQWU5xcHVUUUFNSmdwNEphRXBqMm0r?=
 =?utf-8?B?YURMejhNUzJ3dWFCRkVrbEFwdEdLRXE1U21hRDJZN1NQdGhFeFl5MHVxM0VH?=
 =?utf-8?B?OFRhQWszcGtETER5MVRsTGw0VmlsS2ZWcGNQdHAvd1dWQ0d1WDIrVEVDOFZo?=
 =?utf-8?B?RjM4M1ZDZkljME1PMU02RlMvVWI1SFRlUHk0SXg4Sk9TeTV2OEpTWmpiSndh?=
 =?utf-8?B?dWxyZXRsTnlpbDZHQXMrR21kaUFyUFNMZTIrTzJONlVPSjM4bXRhR01Pc1N4?=
 =?utf-8?B?Z1N0d1JEakJHNmFaWm05V3kxbUNYazNpNHRpZ2VNb2dGSFB2ckh2QUlSWFBI?=
 =?utf-8?Q?TAAs4zxV1ctsRaCTY3EXHgw=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 24ab46bf-df97-4367-ca1d-08d997ced680
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2021 15:48:07.0046
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: sBZ6QUcOm9a5uoFRT0RYwTNYoeBOHdP+6chrtrPP0DtDUAkBXh+ZHCvEZ9kG6yYGe3cTnZbz+D9Qjm/ZgBOs2g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB3291
X-OriginatorOrg: citrix.com

On Thu, Sep 30, 2021 at 10:52:16AM +0300, Oleksandr Andrushchenko wrote:
> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> 
> Add relevant vpci register handlers when assigning PCI device to a domain
> and remove those when de-assigning. This allows having different
> handlers for different domains, e.g. hwdom and other guests.
> 
> Use stubs for guest domains for now.
> 
> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> 
> ---
> Since v2:
> - remove unneeded ifdefs for CONFIG_HAS_VPCI_GUEST_SUPPORT as more code
>   has been eliminated from being built on x86
> Since v1:
>  - constify struct pci_dev where possible
>  - do not open code is_system_domain()
>  - simplify some code3. simplify
>  - use gdprintk + error code instead of gprintk
>  - gate vpci_bar_{add|remove}_handlers with CONFIG_HAS_VPCI_GUEST_SUPPORT,
>    so these do not get compiled for x86
>  - removed unneeded is_system_domain check
> ---
>  xen/drivers/vpci/header.c | 72 ++++++++++++++++++++++++++++++++++-----
>  xen/drivers/vpci/vpci.c   |  4 +--
>  xen/include/xen/vpci.h    |  8 +++++
>  3 files changed, 74 insertions(+), 10 deletions(-)
> 
> diff --git a/xen/drivers/vpci/header.c b/xen/drivers/vpci/header.c
> index 3d571356397a..1ce98795fcca 100644
> --- a/xen/drivers/vpci/header.c
> +++ b/xen/drivers/vpci/header.c
> @@ -397,6 +397,17 @@ static void bar_write(const struct pci_dev *pdev, unsigned int reg,
>      pci_conf_write32(pdev->sbdf, reg, val);
>  }
>  
> +static void guest_bar_write(const struct pci_dev *pdev, unsigned int reg,
> +                            uint32_t val, void *data)
> +{
> +}
> +
> +static uint32_t guest_bar_read(const struct pci_dev *pdev, unsigned int reg,
> +                               void *data)
> +{
> +    return 0xffffffff;
> +}
> +
>  static void rom_write(const struct pci_dev *pdev, unsigned int reg,
>                        uint32_t val, void *data)
>  {
> @@ -445,14 +456,25 @@ static void rom_write(const struct pci_dev *pdev, unsigned int reg,
>          rom->addr = val & PCI_ROM_ADDRESS_MASK;
>  }
>  
> -static int add_bar_handlers(const struct pci_dev *pdev)
> +static void guest_rom_write(const struct pci_dev *pdev, unsigned int reg,
> +                            uint32_t val, void *data)
> +{
> +}
> +
> +static uint32_t guest_rom_read(const struct pci_dev *pdev, unsigned int reg,
> +                               void *data)
> +{
> +    return 0xffffffff;
> +}

FWIW, I would also be fine with introducing the code for those
handlers at the same time.

> +
> +static int add_bar_handlers(const struct pci_dev *pdev, bool is_hwdom)

I would rather use is_hardware_domain(pdev->domain) than passing a
boolean here, no need to duplicate data which is already available
from the pdev.

>  {
>      unsigned int i;
>      struct vpci_header *header = &pdev->vpci->header;
>      struct vpci_bar *bars = header->bars;
>      int rc;
>  
> -    /* Setup a handler for the command register. */
> +    /* Setup a handler for the command register: same for hwdom and guests. */
>      rc = vpci_add_register(pdev->vpci, vpci_hw_read16, cmd_write, PCI_COMMAND,
>                             2, header);
>      if ( rc )
> @@ -475,8 +497,13 @@ static int add_bar_handlers(const struct pci_dev *pdev)
>                  rom_reg = PCI_ROM_ADDRESS;
>              else
>                  rom_reg = PCI_ROM_ADDRESS1;
> -            rc = vpci_add_register(pdev->vpci, vpci_hw_read32, rom_write,
> -                                   rom_reg, 4, &bars[i]);
> +            if ( is_hwdom )
> +                rc = vpci_add_register(pdev->vpci, vpci_hw_read32, rom_write,
> +                                       rom_reg, 4, &bars[i]);
> +            else
> +                rc = vpci_add_register(pdev->vpci,
> +                                       guest_rom_read, guest_rom_write,
> +                                       rom_reg, 4, &bars[i]);

I think you could use:

else if ( IS_ENABLED(CONFIG_HAS_VPCI_GUEST_SUPPORT) )
    rc = vpci_add_register(...
else
    ASSERT_UNREACHABLE();

And then guard the guest_ handlers with CONFIG_HAS_VPCI_GUEST_SUPPORT.

>              if ( rc )
>                  return rc;
>          }
> @@ -485,8 +512,13 @@ static int add_bar_handlers(const struct pci_dev *pdev)
>              uint8_t reg = PCI_BASE_ADDRESS_0 + i * 4;
>  
>              /* This is either VPCI_BAR_MEM32 or VPCI_BAR_MEM64_{LO|HI}. */
> -            rc = vpci_add_register(pdev->vpci, vpci_hw_read32, bar_write, reg,
> -                                   4, &bars[i]);
> +            if ( is_hwdom )
> +                rc = vpci_add_register(pdev->vpci, vpci_hw_read32, bar_write,
> +                                       reg, 4, &bars[i]);
> +            else
> +                rc = vpci_add_register(pdev->vpci,
> +                                       guest_bar_read, guest_bar_write,
> +                                       reg, 4, &bars[i]);
>              if ( rc )
>                  return rc;
>          }
> @@ -520,7 +552,7 @@ static int init_bars(struct pci_dev *pdev)
>      }
>  
>      if ( pdev->ignore_bars )
> -        return add_bar_handlers(pdev);
> +        return add_bar_handlers(pdev, true);
>  
>      /* Disable memory decoding before sizing. */
>      cmd = pci_conf_read16(pdev->sbdf, PCI_COMMAND);
> @@ -582,7 +614,7 @@ static int init_bars(struct pci_dev *pdev)
>                                PCI_ROM_ADDRESS_ENABLE;
>      }
>  
> -    rc = add_bar_handlers(pdev);
> +    rc = add_bar_handlers(pdev, true);
>      if ( rc )
>      {
>          pci_conf_write16(pdev->sbdf, PCI_COMMAND, cmd);
> @@ -593,6 +625,30 @@ static int init_bars(struct pci_dev *pdev)
>  }
>  REGISTER_VPCI_INIT(init_bars, VPCI_PRIORITY_MIDDLE);
>  
> +#ifdef CONFIG_HAS_VPCI_GUEST_SUPPORT
> +int vpci_bar_add_handlers(const struct domain *d, const struct pci_dev *pdev)
> +{
> +    int rc;
> +
> +    /* Remove previously added registers. */
> +    vpci_remove_device_registers(pdev);

Shouldn't this be done by vpci_assign_device as a preparation for
assigning the device?

> +
> +    rc = add_bar_handlers(pdev, is_hardware_domain(d));

Also this model seems to assume that vPCI will require the hardware
domain to have owned the device before it being assigned to a guest,
but for example when using a PV dom0 that won't be the case, and hence
we would need the vPCI fields to be filled when assigning to a guest.

Hence I wonder whether we shouldn't do a full re-initialization when
assigning to a guest instead of this partial one.

> +    if ( rc )
> +        gdprintk(XENLOG_ERR,
> +                 "%pp: failed to add BAR handlers for dom%pd: %d\n",
> +                 &pdev->sbdf, d, rc);
> +    return rc;
> +}
> +
> +int vpci_bar_remove_handlers(const struct domain *d, const struct pci_dev *pdev)
> +{
> +    /* Remove previously added registers. */
> +    vpci_remove_device_registers(pdev);
> +    return 0;
> +}
> +#endif
> +
>  /*
>   * Local variables:
>   * mode: C
> diff --git a/xen/drivers/vpci/vpci.c b/xen/drivers/vpci/vpci.c
> index 0fe86cb30d23..702f7b5d5dda 100644
> --- a/xen/drivers/vpci/vpci.c
> +++ b/xen/drivers/vpci/vpci.c
> @@ -95,7 +95,7 @@ int vpci_assign_device(struct domain *d, const struct pci_dev *dev)
>      if ( is_system_domain(d) || !has_vpci(d) )
>          return 0;
>  
> -    return 0;
> +    return vpci_bar_add_handlers(d, dev);
>  }
>  
>  /* Notify vPCI that device is de-assigned from guest. */
> @@ -105,7 +105,7 @@ int vpci_deassign_device(struct domain *d, const struct pci_dev *dev)
>      if ( is_system_domain(d) || !has_vpci(d) )
>          return 0;
>  
> -    return 0;
> +    return vpci_bar_remove_handlers(d, dev);

I think it would be better to use something similar to
REGISTER_VPCI_INIT here, otherwise this will need to be modified every
time a new capability is handled by Xen.

Maybe we could reuse or expand REGISTER_VPCI_INIT adding another field
to be used for guest initialization?

>  }
>  #endif /* CONFIG_HAS_VPCI_GUEST_SUPPORT */
>  
> diff --git a/xen/include/xen/vpci.h b/xen/include/xen/vpci.h
> index ecc08f2c0f65..fd822c903af5 100644
> --- a/xen/include/xen/vpci.h
> +++ b/xen/include/xen/vpci.h
> @@ -57,6 +57,14 @@ uint32_t vpci_hw_read32(const struct pci_dev *pdev, unsigned int reg,
>   */
>  bool __must_check vpci_process_pending(struct vcpu *v);
>  
> +#ifdef CONFIG_HAS_VPCI_GUEST_SUPPORT
> +/* Add/remove BAR handlers for a domain. */
> +int vpci_bar_add_handlers(const struct domain *d,
> +                          const struct pci_dev *pdev);
> +int vpci_bar_remove_handlers(const struct domain *d,
> +                             const struct pci_dev *pdev);
> +#endif

This would then go away if we implement a mechanism similar to
REGISTER_VPCI_INIT.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Mon Oct 25 16:14:09 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Oct 2021 16:14:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.215942.375379 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mf2br-0003Nb-71; Mon, 25 Oct 2021 16:14:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 215942.375379; Mon, 25 Oct 2021 16:14:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mf2br-0003NU-44; Mon, 25 Oct 2021 16:14:03 +0000
Received: by outflank-mailman (input) for mailman id 215942;
 Mon, 25 Oct 2021 16:14:02 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=EMnB=PN=citrix.com=anthony.perard@srs-us1.protection.inumbo.net>)
 id 1mf2bq-0003NN-2s
 for xen-devel@lists.xenproject.org; Mon, 25 Oct 2021 16:14:02 +0000
Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id d9e43068-bf46-4968-946a-1e8a7695314a;
 Mon, 25 Oct 2021 16:14:00 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d9e43068-bf46-4968-946a-1e8a7695314a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1635178440;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=V2kGQNJ+EgiKLdOSySfJEKe1S6HLNkdjC8ouhL6tH68=;
  b=Fd6RuJOJy+TSR9QOfExu8WQbfMlonH89Url5z7ASd+UXDJWrgE5fkqKK
   awY3bvTKrwiztzqr9rSMLSUONIb8bw0ZipbRoc4DNvYm1m1gm2NmSx/V9
   Dnn8vNq2kPLnJMV1KpRS9IcRk3sYm81DPMZv1rqam+yoJ+6/4d29XIDj4
   Y=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: Q9y5wuZAzSZBvlcvOXLUh3SHtH3jJs2Geg+9gnapqfKciEFBffEXoz+B2/UUKQp5nRI5hsu61u
 Bv5escSqeqkgcAyW8TuQIqSAqz9vCfspW4wRwSFz+DgEZPb7L5j8IDcHo8zTZ4xjkArAtdNI1o
 aEx4pmIWZ4lnVQ5R+3O5imo0CFLf89iHlqb7iHYA3mgi7yxGo4e+IBjMq1nAq152ChMS818xaZ
 32mfPngg70xOzT5jsHPYXRwYv3HoFGLcwJcCjkk7GWl1Dvsta7n3Ew2dwRP7ksrboJBixgW4UG
 Xar6ATZSTQ3dkTpNl5l87j47
X-SBRS: 5.1
X-MesageID: 56395701
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:vkIvra8P6CWymq+Vb0d/DrUDF3mTJUtcMsCJ2f8bNWPcYEJGY0x3y
 GAbCDuBbK2IZDPzc95xPonjpB4DuJSAyNcxQVZtpC08E34SpcT7XtnIdU2Y0wF+jyHgoOCLy
 +1EN7Es+ehtFie0Si9AttENlFEkvU2ybuOU5NXsZ2YhGmeIdA970Ug6wrZj39Yy6TSEK1jlV
 e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH
 I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPhD7
 4ho75C/cT4YJ6j3v+sWbEVWQh5haPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us
 6ZCcXZUM07F17neLLGTE4GAguwqKtXrO4UO/Glt1zjDAd4tQIzZQrWM7thdtNs1rp0QRqeDO
 JJAAdZpRDbhfQ1WGgYHMq0/ht2DomvAS2JfiV3A8MLb5ECMlVcsgdABKuH9cdWQScJYtk2Rv
 G7B8iLyBRRyHMOb4SqI9DSrnOCntTjnVYwbErr+7eJjilCXwm0VCTUGVF+6p+n/gUm7M/pEM
 FAd8Ccqqak09WSoQ8P7Uhn+p2SL1jYMVtwVH+Ak5QWlzqvP/x3fFmUCViRGatEtqIkxXzNC/
 l6Wnfv5CDp3qrqXRHmBsLCOoluP1TM9dDFYI3VeFE1cvoel8NpbYg/zoshLIonoq4f5FgnJ8
 imPlw8xjIpPg580yPDulbzYuA6Eqp/MRw8zwwzYWGO58w90DLKYi5yUBUvztqkYct7IJrWVl
 D1dwZLGtbFRZX2YvHXVGL1lIV2/2xqS3NQwa3ZUFJ496y/lxXeneY1BiN2VDBY0aphaEdMFj
 Um6hO+w2HOxFCbyBUOUS9joYyjP8UQHPY+9Ps04lvIUPvBMmPavpUmCn3K40WH3i1QLmqoiI
 5qdesvEJS9EUvk+lGLsFr9Fi+9DKsUCKYX7H8CTI/OPiuL2WZJoYe1dbAvmgh4RtfvsTPrpH
 yZ3aJLRlkQ3vBzWaSjL648DRW3m3lBgba0aX/d/L7bZSiI/QTlJI6aIndsJJtw094wIx7yg1
 izsBSdlJK/X2CSvxfOiMSs4NtsCnP9X8BoGAMDbFQ/5iyZ4Od30svZ3mlleVeBPydGPBMVcF
 5EtE/hsyNwUItge0zhCP5T7sqJ4cxGn2VCHMya/OWBtdJ98XQ3ZvNTje1K3piUJCyO2s+o4o
 qGhiVyHEcZSGVw6AZaEcu+rwnOwoWMZxLB4UXzXL4QBY07r6oVrdXD816dlP8EWJBzf7TKGz
 ALKUwwArOzArtZtotnEjKyJtamzFO56EhYIFmXX9+/uZyLb4nCi0clLV+PRJWLRU2b9+aODY
 +RJzq6jbK1bzQgS64clSuRl16Mz4dfrtoR29AU8ESWZdUmvB5NhPmKCgZtFuJpSy+ILogCxQ
 E+OpIVXYO3bJMP/HVcNDwM5deDfh+oMkzzf4PlpckX34Ch7oOiOXUlIZkTejSVcKP1+MZ8/w
 Pdns8kTslTthh0vO9eAryZV62XTcSBQD/R57skXUN3xlw4m6lBeepiNWCb57aaGZ8hILkR3c
 CSfg7DPhugEy0fPG5bp+aMhAQaJaUwyhS13
IronPort-HdrOrdr: A9a23:pYC1yqHMfK/iPi4FpLqEEseALOsnbusQ8zAXPiBKJCC9vPb5qy
 nOpoV+6faQslwssR4b9uxoVJPvfZq+z+8R3WByB8bAYOCOggLBQL2KhbGI/9SKIVydygcy78
 Zdm6gVMqyMMbB55/yKnDVRxbwbsaa6GKPDv5ah8590JzsaDJ2Jd21Ce32m+ksdfnghObMJUK
 Cyy+BgvDSadXEefq2AdwM4t7iqnayzqHr+CyR2fyIa1A==
X-IronPort-AV: E=Sophos;i="5.87,181,1631592000"; 
   d="scan'208";a="56395701"
Date: Mon, 25 Oct 2021 17:13:54 +0100
From: Anthony PERARD <anthony.perard@citrix.com>
To: Stefano Stabellini <sstabellini@kernel.org>
CC: <xen-devel@lists.xenproject.org>, <iwj@xenproject.org>,
	<cardoe@cardoe.com>, <wl@xen.org>, <andrew.cooper3@citrix.com>, "Stefano
 Stabellini" <stefano.stabellini@xilinx.com>
Subject: Re: [PATCH 3/3] automation: add a QEMU based x86_64 Dom0/DomU test
Message-ID: <YXbXwjxHPNjSAKrG@perard>
References: <alpine.DEB.2.21.2110210831470.2311@sstabellini-ThinkPad-T480s>
 <20211021230839.10794-3-sstabellini@kernel.org>
 <YXK2lTWZHiTXIBtJ@perard>
 <alpine.DEB.2.21.2110221219520.2311@sstabellini-ThinkPad-T480s>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <alpine.DEB.2.21.2110221219520.2311@sstabellini-ThinkPad-T480s>

On Fri, Oct 22, 2021 at 01:05:35PM -0700, Stefano Stabellini wrote:
> On Fri, 22 Oct 2021, Anthony PERARD wrote:
> > On Thu, Oct 21, 2021 at 04:08:39PM -0700, Stefano Stabellini wrote:
> > > diff --git a/automation/scripts/qemu-alpine-x86_64.sh b/automation/scripts/qemu-alpine-x86_64.sh
> > > new file mode 100644
> > > index 0000000000..41b05210d6
> > > --- /dev/null
> > > +++ b/automation/scripts/qemu-alpine-x86_64.sh
> > > @@ -0,0 +1,92 @@
> > > +#!/bin/bash
> > > +
> > > +set -ex
> > > +
> > > +apt-get -qy update
> > > +apt-get -qy install --no-install-recommends qemu-system-x86 \
> > > +                                            cpio \
> > > +                                            curl \
> > > +                                            busybox-static
> > 
> > Please, don't install packages during the CI job. If you need new
> > packages, update the container.
> 
> The container used to run this script is the one used for the Xen build:
> automation/build/debian/unstable.dockerfile, AKA
> registry.gitlab.com/xen-project/xen/debian:unstable. We don't have a
> specific container for the sole purpose of running tests.

I've added qemu to our debian:stretch container recently, in order to
run the "qemu-smoke-*" tests without running apt commands. Unless more
recent software are needed, you could base the "qemu-alpine-x86*" test
on debian:stretch which might only then missing cpio and busybox. Update
of the stretch container should go smoothly as it has been done
recently.

> Thus, I could add qemu-system-x86 to
> automation/build/debian/unstable.dockerfile, but then we increase the
> size of the debian unstable build container needlessly for all related
> build jobs.

There is something I'm missing, how is it a problem to have a container
that is a bit bigger? What sort of problem could we have to deal with?
On the other hand, doing more task, installing software, downloading
anything from the internet, makes the job much less reliable. It
increase the risk of a failure do to external factors and it takes more
time to run the test.

> Or we could add one more special container just for running tests, but
> then it is one more container to maintain and keep up-to-date.
> 
> This is why I chose as a compromise to keep the underlying container as
> is, and just apt-get the extra 3-4 packages here. It is the same thing
> we do on ARM: automation/scripts/qemu-alpine-arm64.sh. Also keep in mind
> that this job is run in the "test" step where we have far fewer jobs at
> the moment and the runners are not busy. (It would be different in the
> "build" step where we have many jobs.)

I don't really see any difference between a "test" job and a "build"
jobs, both kind use the same resource/runner.

On that note, they're is something I've learned recently: "test" job
don't even have to wait for all "build" job to complete, they can run in
parallel. We would just need to replace "dependencies" by "needs":
    https://docs.gitlab.com/ee/ci/yaml/index.html#needs
But that could be an improvement for an other time and only a side note
for the patch.

> I am not entirely sure what is the best solution overall, but for this
> series at this stage I would prefer to keep the same strategy used for
> the ARM tests (i.e. reuse the debian unstable build container and
> apt-get the few missing packages.) If we do change the way we do it, I
> would rather change both x86 and ARM at the same time.

I'm pretty sure the best strategy would be to do as little as possible
during a job, download as little as possible and possibly cache as much
as possible and do as much as possible ahead of time. Feel free to
change the Arm test, but I don't think it is necessary to change the Arm
test at the same time as introducing an x86 test.

Cheers,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Mon Oct 25 16:46:32 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Oct 2021 16:46:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.215970.375408 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mf37C-0007gz-4m; Mon, 25 Oct 2021 16:46:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 215970.375408; Mon, 25 Oct 2021 16:46:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mf37C-0007gs-1k; Mon, 25 Oct 2021 16:46:26 +0000
Received: by outflank-mailman (input) for mailman id 215970;
 Mon, 25 Oct 2021 16:46:24 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=M4PP=PN=oderland.se=josef@srs-us1.protection.inumbo.net>)
 id 1mf37A-0007gl-Bq
 for xen-devel@lists.xenproject.org; Mon, 25 Oct 2021 16:46:24 +0000
Received: from office.oderland.com (unknown [91.201.60.5])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 158e2060-35b3-11ec-8417-12813bfff9fa;
 Mon, 25 Oct 2021 16:46:22 +0000 (UTC)
Received: from [193.180.18.161] (port=40536 helo=[10.137.0.14])
 by office.oderland.com with esmtpsa (TLS1.2) tls
 TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2)
 (envelope-from <josef@oderland.se>)
 id 1mf376-005OVn-VK; Mon, 25 Oct 2021 18:46:20 +0200
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 158e2060-35b3-11ec-8417-12813bfff9fa
Message-ID: <b76373a7-1e1d-3aae-66ba-09221c752c11@oderland.se>
Date: Mon, 25 Oct 2021 18:46:18 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:93.0) Gecko/20100101
 Thunderbird/93.0
Content-Language: en-US
To: Jason Andryuk <jandryuk@gmail.com>
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
 Bjorn Helgaas <helgaas@kernel.org>, Juergen Gross <jgross@suse.com>,
 linux-pci@vger.kernel.org, Marc Zyngier <maz@kernel.org>,
 Thomas Gleixner <tglx@linutronix.de>,
 xen-devel <xen-devel@lists.xenproject.org>
References: <90277228-cf14-0cfa-c95e-d42e7d533353@oderland.se>
 <20211025012503.33172-1-jandryuk@gmail.com>
 <CAKf6xptSbuj3VGxzed1uPx59cA_BRJY5FDHczX744rvnTHB8Lg@mail.gmail.com>
From: Josef Johansson <josef@oderland.se>
Subject: Re: [PATCH] PCI/MSI: Fix masking MSI/MSI-X on Xen PV
In-Reply-To: <CAKf6xptSbuj3VGxzed1uPx59cA_BRJY5FDHczX744rvnTHB8Lg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-AntiAbuse: This header was added to track abuse, please include it with any abuse report
X-AntiAbuse: Primary Hostname - office.oderland.com
X-AntiAbuse: Original Domain - lists.xenproject.org
X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12]
X-AntiAbuse: Sender Address Domain - oderland.se
X-Get-Message-Sender-Via: office.oderland.com: authenticated_id: josjoh@oderland.se
X-Authenticated-Sender: office.oderland.com: josjoh@oderland.se

On 10/25/21 14:27, Jason Andryuk wrote:
> On Sun, Oct 24, 2021 at 9:26 PM Jason Andryuk <jandryuk@gmail.com> wrote:
>> commit fcacdfbef5a1 ("PCI/MSI: Provide a new set of mask and unmask
>> functions") introduce functions pci_msi_update_mask() and
>> pci_msix_write_vector_ctrl() that is missing checks for
>> pci_msi_ignore_mask that exists in commit 446a98b19fd6 ("PCI/MSI: Use
>> new mask/unmask functions").  The checks are in place at the high level
>> __pci_msi_mask_desc()/__pci_msi_unmask_desc(), but some functions call
>> directly to the helpers.
>>
>> Push the pci_msi_ignore_mask check down to the functions that make
>> the actual writes.  This keeps the logic local to the writes that need
>> to be bypassed.
>>
>> With Xen PV, the hypervisor is responsible for masking and unmasking the
>> interrupts, which pci_msi_ignore_mask is used to indicate.
>>
>> This change avoids lockups in amdgpu drivers under Xen during boot.
>>
>> Fixes: commit 446a98b19fd6 ("PCI/MSI: Use new mask/unmask functions")
>> Reported-by: Josef Johansson <josef@oderland.se>
>> Signed-off-by: Jason Andryuk <jandryuk@gmail.com>
>> ---
> I should have written that this is untested.  If this is the desired
> approach, Josef should test that it solves his boot hangs.
>
> Regards,
> Jason

I've tested this today, both the above patch, but also my own below
where I'm patching inside __pci_write_msi_msg,
which is the outcome of the patch above.

I found that both solves the boot hang, but both have severe effects
on suspends/resume later on. The below patch without patching
__pci_write_msi_msg seems to be ideal, solves boot problems but not
causing too much others. There seems to me that there's undocumented
dragons here. Doing more test later today.

diff --git a/drivers/pci/msi.c b/drivers/pci/msi.c
index 4b4792940e86..e97eea1bc93a 100644
--- a/drivers/pci/msi.c
+++ b/drivers/pci/msi.c
@@ -148,6 +148,9 @@ static noinline void pci_msi_update_mask(struct msi_desc *desc, u32 clear, u32 s
 	raw_spinlock_t *lock = &desc->dev->msi_lock;
 	unsigned long flags;
 
+	if (pci_msi_ignore_mask || desc->msi_attrib.is_virtual)
+		return;
+
 	raw_spin_lock_irqsave(lock, flags);
 	desc->msi_mask &= ~clear;
 	desc->msi_mask |= set;
@@ -186,6 +189,9 @@ static void pci_msix_write_vector_ctrl(struct msi_desc *desc, u32 ctrl)
 
 static inline void pci_msix_mask(struct msi_desc *desc)
 {
+	if (pci_msi_ignore_mask || desc->msi_attrib.is_virtual)
+		return;
+
 	desc->msix_ctrl |= PCI_MSIX_ENTRY_CTRL_MASKBIT;
 	pci_msix_write_vector_ctrl(desc, desc->msix_ctrl);
 	/* Flush write to device */
@@ -194,15 +200,15 @@ static inline void pci_msix_mask(struct msi_desc *desc)
 
 static inline void pci_msix_unmask(struct msi_desc *desc)
 {
+	if (pci_msi_ignore_mask || desc->msi_attrib.is_virtual)
+		return;
+
 	desc->msix_ctrl &= ~PCI_MSIX_ENTRY_CTRL_MASKBIT;
 	pci_msix_write_vector_ctrl(desc, desc->msix_ctrl);
 }
 
 static void __pci_msi_mask_desc(struct msi_desc *desc, u32 mask)
 {
-	if (pci_msi_ignore_mask || desc->msi_attrib.is_virtual)
-		return;
-
 	if (desc->msi_attrib.is_msix)
 		pci_msix_mask(desc);
 	else if (desc->msi_attrib.maskbit)
@@ -211,9 +217,6 @@ static void __pci_msi_mask_desc(struct msi_desc *desc, u32 mask)
 
 static void __pci_msi_unmask_desc(struct msi_desc *desc, u32 mask)
 {
-	if (pci_msi_ignore_mask || desc->msi_attrib.is_virtual)
-		return;
-
 	if (desc->msi_attrib.is_msix)
 		pci_msix_unmask(desc);
 	else if (desc->msi_attrib.maskbit)
@@ -307,7 +310,7 @@ void __pci_write_msi_msg(struct msi_desc *entry, struct msi_msg *msg)
 		 * entry while the entry is unmasked, the result is
 		 * undefined."
 		 */
-		if (unmasked)
+		if (unmasked && !pci_msi_ignore_mask)
 			pci_msix_write_vector_ctrl(entry, ctrl | PCI_MSIX_ENTRY_CTRL_MASKBIT);
 
 		writel(msg->address_lo, base + PCI_MSIX_ENTRY_LOWER_ADDR);
@@ -450,8 +453,9 @@ static void __pci_restore_msix_state(struct pci_dev *dev)
 				PCI_MSIX_FLAGS_ENABLE | PCI_MSIX_FLAGS_MASKALL);
 
 	arch_restore_msi_irqs(dev);
-	for_each_pci_msi_entry(entry, dev)
-		pci_msix_write_vector_ctrl(entry, entry->msix_ctrl);
+	if (!(pci_msi_ignore_mask || entry->msi_attrib.is_virtual))
+		for_each_pci_msi_entry(entry, dev)
+			pci_msix_write_vector_ctrl(entry, entry->msix_ctrl);
 
 	pci_msix_clear_and_set_ctrl(dev, PCI_MSIX_FLAGS_MASKALL, 0);
 }



From xen-devel-bounces@lists.xenproject.org Mon Oct 25 17:24:38 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Oct 2021 17:24:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.215977.375419 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mf3i3-0003L4-UJ; Mon, 25 Oct 2021 17:24:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 215977.375419; Mon, 25 Oct 2021 17:24:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mf3i3-0003Kx-PY; Mon, 25 Oct 2021 17:24:31 +0000
Received: by outflank-mailman (input) for mailman id 215977;
 Mon, 25 Oct 2021 17:24:30 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mf3i2-0003Kk-3i; Mon, 25 Oct 2021 17:24:30 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mf3i1-000222-RA; Mon, 25 Oct 2021 17:24:29 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mf3i1-0006CZ-GN; Mon, 25 Oct 2021 17:24:29 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mf3i1-00046I-Fq; Mon, 25 Oct 2021 17:24:29 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=HZH/ksEv5cA+pBVPavbsdTO6P91OCWNh/+n+b4JfpPg=; b=P5RTy0omB7tMEkBTDPh45LyYHw
	GqUuPGEjKl/lf9bygSYyr+KiOQrgDOAr7AwuywWBDGjecpcYgiSomBdZhGA98nSlr0imYX328Pymn
	+4MFkEtZYrLywj9oQBz0lgAYoE01xxHugPFZd5qZa+On0VHqu5flix7K/tjVKJxaRlKw=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165850-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 165850: tolerable FAIL
X-Osstest-Failures:
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=23ec1ebc8acbfd2bf06f6085a776f0db923f9fa9
X-Osstest-Versions-That:
    xen=23ec1ebc8acbfd2bf06f6085a776f0db923f9fa9
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 25 Oct 2021 17:24:29 +0000

flight 165850 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165850/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 165825
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 165825
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165825
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165825
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 165825
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 165825
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 165825
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 165825
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 165825
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 165825
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 165825
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165825
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 xen                  23ec1ebc8acbfd2bf06f6085a776f0db923f9fa9
baseline version:
 xen                  23ec1ebc8acbfd2bf06f6085a776f0db923f9fa9

Last test of basis   165850  2021-10-25 01:51:43 Z    0 days
Testing same since                          (not found)         0 attempts

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Published tested tree is already up to date.



From xen-devel-bounces@lists.xenproject.org Mon Oct 25 17:35:59 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Oct 2021 17:35:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.215987.375432 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mf3t4-0004vd-41; Mon, 25 Oct 2021 17:35:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 215987.375432; Mon, 25 Oct 2021 17:35:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mf3t4-0004vW-0V; Mon, 25 Oct 2021 17:35:54 +0000
Received: by outflank-mailman (input) for mailman id 215987;
 Mon, 25 Oct 2021 17:35:52 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=IWrL=PN=oracle.com=dongli.zhang@srs-us1.protection.inumbo.net>)
 id 1mf3t1-0004vQ-Po
 for xen-devel@lists.xenproject.org; Mon, 25 Oct 2021 17:35:51 +0000
Received: from mx0b-00069f02.pphosted.com (unknown [205.220.177.32])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id a7d14a71-8a90-4b68-a0b5-af07ad55f5b8;
 Mon, 25 Oct 2021 17:35:48 +0000 (UTC)
Received: from pps.filterd (m0246632.ppops.net [127.0.0.1])
 by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 19PGFA7K030378; 
 Mon, 25 Oct 2021 17:35:45 GMT
Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71])
 by mx0b-00069f02.pphosted.com with ESMTP id 3bw6v1vk8f-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Mon, 25 Oct 2021 17:35:45 +0000
Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1])
 by aserp3030.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 19PHRBkq079779;
 Mon, 25 Oct 2021 17:35:44 GMT
Received: from nam10-dm6-obe.outbound.protection.outlook.com
 (mail-dm6nam10lp2107.outbound.protection.outlook.com [104.47.58.107])
 by aserp3030.oracle.com with ESMTP id 3bv8efskeg-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Mon, 25 Oct 2021 17:35:44 +0000
Received: from BYAPR10MB2663.namprd10.prod.outlook.com (2603:10b6:a02:a9::20)
 by BYAPR10MB3157.namprd10.prod.outlook.com (2603:10b6:a03:14f::26)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.18; Mon, 25 Oct
 2021 17:35:42 +0000
Received: from BYAPR10MB2663.namprd10.prod.outlook.com
 ([fe80::2848:63dc:b87:8021]) by BYAPR10MB2663.namprd10.prod.outlook.com
 ([fe80::2848:63dc:b87:8021%7]) with mapi id 15.20.4628.020; Mon, 25 Oct 2021
 17:35:42 +0000
Received: from localhost.localdomain (138.3.200.16) by
 SA9PR13CA0022.namprd13.prod.outlook.com (2603:10b6:806:21::27) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4649.11 via Frontend Transport; Mon, 25 Oct 2021 17:35:39 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a7d14a71-8a90-4b68-a0b5-af07ad55f5b8
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc :
 subject : date : message-id : content-type : mime-version;
 s=corp-2021-07-09; bh=cDImQC0g3WWbNeSuHjh5Voz2pA2wuCtC5/LKbSnoOEw=;
 b=SukbJ0kiMFquBT7kDQ93rhd5I7leU3JiSVCpaGDeWv0+d6YFt+2I+o3ZGoSvHObkm/lV
 WQ7BBzHmfSf3jpfzjO5Etnv8BbWYBTtmhkKpW7s+8E1/cyAyhgX+lLZ/KEDruZ0vDfBI
 exFzrOi3zPb8sy2akUE8SWylUgC14/E5ZKTq08GgimIQXbn/j0owqEHLQMr9OOtaSmG2
 IBARnL8rmnQcErSTTdBar1ZzS3BeeUYweNN5Ksl7XlUko7fL9YKbMJVBbUfZ9bL/hQ6L
 U+/Dq6jNvOjhfKUnGsqDTTNK0EORYv4Rev1Umr3Z3fnR0XeKrYBILKBVig1nwTde9TuH Pg== 
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=D8Y8hPWActoieUdB5z3GRtDt4X5tzri1Qw55rSS8+54l5ZKBa6F3mrVWLkP7JicownskJJ0EFOUJ3dzFo+vQZUxL8dEcfx+dEyoJpz7Ck0ApECietDFfFXBIwjyWkWhki784T3fs1rXW6UbxAyfH2U24AG+dA4ueyaRJlZ7RKiWBCC+xdzLhIkeQ2SsRX5LFgb6uQq5Y9DMLBL0Szng5+1q6d5sk3Zyg65R0NtuQZuAIBl8YNX22UX/e0dEFh0GFEzYfM1J03IKr3g50h6w9Qv5fExOYN+Rv8wbuIlW7Y7VfPUw1DGyBC4UUREzvsSthfIY89QU9dOkaMusxkkLL4A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=cDImQC0g3WWbNeSuHjh5Voz2pA2wuCtC5/LKbSnoOEw=;
 b=n4F/gBmdhfpd96i5TqXQ3c1KBx3R8XoPiPO0IL7xk+JiccisZ42XVuPXBLgDosF3uhPqsU2Al9esLD8frlXES957MvgcFx59sKw7+NBoFvNq5wLsYAwpeoQW07/HKJQh0Mpv0Xs28nyJ4vY4OGZ8QAU6RAUJSM3LtWf6RvtLsrhbkEmEB/rbyDrnd+xclnOKeHdmlighb538UdlPocw7bv+3b9gOPmhYXj6HapcTIYLX/5VyC9nptoAmXtOPXZobOElc+7HAMDWdr52Kq3/+l6mrQWW8pYvsO50/hFnhHJwP7fCnt2Pj3rKtB7Z3m/kfrAstv+Q/2ckqpDoAADr89Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com;
 dkim=pass header.d=oracle.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=cDImQC0g3WWbNeSuHjh5Voz2pA2wuCtC5/LKbSnoOEw=;
 b=fL+n4G3fqvreyT8JeaasbmsoxJCXv10QjGmTS+FHqLOmDXLIrDPCeea36hWFEBUMc9jqjv0+uDThCiV/swk8o/E+33xbUav1+EAMlGiLE8qfMXml0vfpu2tCoA9pR3EyqylcvQARBGrqZaZ5hrW0umFmAS/JnOkfsK3HHm46WnU=
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=oracle.com;
From: Dongli Zhang <dongli.zhang@oracle.com>
To: xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org, julien@xen.org, Volodymyr_Babchuk@epam.com,
        andrew.cooper3@citrix.com, george.dunlap@citrix.com,
        iwj@xenproject.org, jbeulich@suse.com, wl@xen.org, joe.jin@oracle.com
Subject: [PATCH v2 1/1] xen: update system time immediately when VCPUOP_register_vcpu_info
Date: Mon, 25 Oct 2021 10:35:23 -0700
Message-Id: <20211025173523.3647-1-dongli.zhang@oracle.com>
X-Mailer: git-send-email 2.17.1
Content-Type: text/plain
X-ClientProxiedBy: SA9PR13CA0022.namprd13.prod.outlook.com
 (2603:10b6:806:21::27) To BYAPR10MB2663.namprd10.prod.outlook.com
 (2603:10b6:a02:a9::20)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: c1cd7eee-da71-4771-0508-08d997ddde38
X-MS-TrafficTypeDiagnostic: BYAPR10MB3157:
X-Microsoft-Antispam-PRVS: 
	<BYAPR10MB31577D1FAB9543F17BD192A2F0839@BYAPR10MB3157.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8273;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 
	kfSQFX5PeH0i7Z4nctWNQdam0bUgWRs9s/KjgIgrKpxTyZZacivEwQpVdFy/28MmvKqhlmOEGEcaZ78xfVLExcNGCwnYzoVphWa3M28pW69yWcX6kBacgc2ZOvUePlzr+cr1OCdHA5xhzdLkSlSvUDZMFR7AA0jlipyjAPd2xjrrvw2ISoXI2BUbtLfFIGg9YK6AyY/AAaMZSjggIEMJS9nT9n7LdmAmcVrxsszNAD3GiqBMjKPhCbzo1DrfyHObjuEom6wWjYVsIrlbJ+o0mKpJ9WPYbbjmayibforbhEiboySN+vcZA9PvrquuJTn8XvFWYMFhHcik/9nmsf4y7b7JLI18IugbhNXMg6HD7FJ8+ekFPB8pV8b+wilstU9oClZyKmXTCCesJ/q2EjPZURQUNYXm1yWbSLLMuY4oB6QAvKkFpXds+9OECRgMbuhFJiXyzxDeJw4cRsF7o5Iq5zfckvkrylHlrpaAWQ4t7GXIWinQGk49Dm1tXHLrIMuMhwY8y3pmMhJKLV0J+gLa74XmwKC9u/9HM/vvHGoaY5R4HfS17iZCWguXrNoGW044zOck/D+gpKwpXQwXzOms30xZWzGanV4sHHUyU18tXso+SitLvEG4HWUtryv3o907yN2z+eBboHyHBL3moIRngONGaUUYw9Bvyu+uiVkOqH/AgK1PeRVMoQUV6VlydifIS2D1BVgfD4xGAOfhBv9x838l8JxsAYXepLjcDLiBl1TbYGnlVtB8e4QEd4XB87aS1AV0wY/J7DeapwUVRP6KyyqES9cByHggxvGs0Rx9/N3Jp2QnF2ln0gCiWnJIOqysz/SaEP7bxgYJI9xjtjXrjA==
X-Forefront-Antispam-Report: 
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB2663.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(2616005)(66476007)(6512007)(44832011)(956004)(966005)(2906002)(66946007)(66556008)(1076003)(5660300002)(316002)(6486002)(186003)(508600001)(52116002)(8676002)(107886003)(26005)(15650500001)(6916009)(38350700002)(36756003)(4326008)(6666004)(38100700002)(6506007)(83380400001)(8936002)(86362001)(14773001)(21314003);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?xX04tbQM2Iu5eKhUYjoUcL4Ub5QQKALnCR3/AnJ6qaenemwsLg6i08/FaUCD?=
 =?us-ascii?Q?70mBNn/nh1l3qY/MuNlDRHHptT4tXi57J3SCC9jLyLzjRQDO8yJ57KiCZ3l3?=
 =?us-ascii?Q?h9tu0h82PtJmmNbbccXlIWiXhR4t0B/41zJr3jkqRXsx+S+oZJnQYnA1lRCL?=
 =?us-ascii?Q?LYraDHtbotVaY8yxRp9Ro/Sz4Jdz3BT+iote+Ouf7zj6my1y96lXMjp6aXil?=
 =?us-ascii?Q?gJ2EIEfGOjdftXEU34UaHHYTcdaZhoA/TZiijBunUtptO0iH2Tn3u4WJqRDI?=
 =?us-ascii?Q?TSp6DoQ9EB/1oVUFET5163Yby6cF+JnYQE1xBpmbj4i5mN4jzg2o6GWOhtFI?=
 =?us-ascii?Q?qK09eEb6nunuuSURZkxFjavijQs98thibGfvDi6SnZ04z9naD/bgzDbDe5uw?=
 =?us-ascii?Q?a+FDFSXpOqaS1L1xKmR780/muMIp4M4Gs7q6tUD8dudgyqyMUJhI6sb8P0b7?=
 =?us-ascii?Q?wgMbuhrr/S97e5ZFUhUpradccP3VEx2iv00cohB7P/kVBUnOahpEsyKnhl6U?=
 =?us-ascii?Q?xTFp1jWj4nO07OyhabourHOGbng/tInI5Nd+X1qmJomL2c/dzM1hxtJpGk79?=
 =?us-ascii?Q?3xhr0Aw8y1NkOU/9FsN3q7XKliGIfUedXDIDzZsUZ+YS509Ahp85iXm4MJT3?=
 =?us-ascii?Q?717HbA/pC+FWantXWK2Eq3Z1kBu5yPw29iiZNQMVn8mDjqhb5fBNfxw6ms57?=
 =?us-ascii?Q?zh+gtDr/PKS7vgu6GyWXxugT4Xvdd2NxMNYsm5kY1SMai7l7uAVBXBrIl97z?=
 =?us-ascii?Q?zOJb4L+Yf8IQa0ntd+QKaMAg9o4lUtrJ0EI05zPxtOoYw552WfUK1fj42ua0?=
 =?us-ascii?Q?nPlqz4ozQqEarOagDN4eth63I3d51SUKUqGXGREKxCH/3pysMlgad7QpxRED?=
 =?us-ascii?Q?sQsiOvwzRWbun7pmK1t7047Xs3+lVDCCSzXUPhrBL0rq97sYf3rjjXFKGuVP?=
 =?us-ascii?Q?nOQEsiwoTsuUSdW7nSdOsfGZZ2FKsG3vckVOol6bR7P0yYwI8iEiNDD48SZS?=
 =?us-ascii?Q?EcGSGDey7LOyvW71JD2ahtUxAt84k++Ua5nDtxa71Z/sARoD5YFfCZpFixy4?=
 =?us-ascii?Q?s5JGvMVkCvX3YOmWHiAYRz4CWzg9DTIWcEIIdudv2PQALdn6/eEOJeR3ZrDd?=
 =?us-ascii?Q?P6Vw5OW6OQ355dqNUjVSq2oEqd++gOXKlO6jPGZe9P22dTwPDYtIkA9IEClQ?=
 =?us-ascii?Q?S4WF59QWQY4/F+u7Wzz6sa4SMYVLs2hv9MeY6r6mD/d1fX2QbwVqIHipsjQY?=
 =?us-ascii?Q?c51Yp1WBa/JkdQWUcazXmSHkoayFB2Nn0tnaAOeADZqeBgiqTGTdJ/hJO0MU?=
 =?us-ascii?Q?gth7vG7RRiYBlZ/juNZZuc+8sYLfIZejQXNsmML62ZOY1w8xUv+VuZSPx4wh?=
 =?us-ascii?Q?aV9rli4FWofCs7B129ZOV3K7lfuQpUjyfeqXytfJ3LU697/+AF2NbMyZtWk6?=
 =?us-ascii?Q?ZNDFR2Jw3092yiBxpgjo/ZDhjMkQ9ALQrTpjJgbW6xkbXxjimKNPCf+h5za3?=
 =?us-ascii?Q?18oYSflNMnloo2XPo0Vn/bom8xKxKvDptrpCTmyxNA+6ySbpvj3zsJqtNQq2?=
 =?us-ascii?Q?ooBR2wXNcTggdhmmVLOX0J/8IWFFKC7bME0Ql3bc72wEh4w7lD44eg2qofZw?=
 =?us-ascii?Q?+86W4qezotvkMFfpQ7/4nds=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c1cd7eee-da71-4771-0508-08d997ddde38
X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB2663.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2021 17:35:42.4923
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 9hJ11t2/vdLB2A58fNhuCw1l6VMIFkhSKkwnYJmceE6998AnZzmu3JONPaScTeIfcAn6xodgB3XDBNW/h0fHlA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB3157
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10148 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 bulkscore=0 mlxscore=0
 phishscore=0 suspectscore=0 malwarescore=0 mlxlogscore=999 spamscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109230001
 definitions=main-2110250102
X-Proofpoint-GUID: fychTKbXcvXHilXliQJiKAqZ0wrr42dF
X-Proofpoint-ORIG-GUID: fychTKbXcvXHilXliQJiKAqZ0wrr42dF

The guest may access the pv vcpu_time_info immediately after
VCPUOP_register_vcpu_info. This is to borrow the idea of
VCPUOP_register_vcpu_time_memory_area, where the
force_update_vcpu_system_time() is called immediately when the new memory
area is registered.

Otherwise, we may observe clock drift at the VM side if the VM accesses
the clocksource immediately after VCPUOP_register_vcpu_info().

Reference:
https://lists.xenproject.org/archives/html/xen-devel/2021-10/msg00571.html
Cc: Joe Jin <joe.jin@oracle.com>
Signed-off-by: Dongli Zhang <dongli.zhang@oracle.com>
---
Changed since v1:
  - Implement force_update_vcpu_system_time() for ARM
    (suggested by Jan Beulich)
    While I have tested ARM compilation with aarch64-linux-gnu-gcc, I did
    not test on ARM platform.

 xen/arch/arm/time.c        | 5 +++++
 xen/common/domain.c        | 2 ++
 xen/include/asm-arm/time.h | 2 ++
 3 files changed, 9 insertions(+)

diff --git a/xen/arch/arm/time.c b/xen/arch/arm/time.c
index 7dbd363537..dec53b5f7d 100644
--- a/xen/arch/arm/time.c
+++ b/xen/arch/arm/time.c
@@ -351,6 +351,11 @@ void update_vcpu_system_time(struct vcpu *v)
     /* XXX update shared_info->wc_* */
 }
 
+void force_update_vcpu_system_time(struct vcpu *v)
+{
+    update_vcpu_system_time(v);
+}
+
 void domain_set_time_offset(struct domain *d, int64_t time_offset_seconds)
 {
     d->time_offset.seconds = time_offset_seconds;
diff --git a/xen/common/domain.c b/xen/common/domain.c
index 8b53c49d1e..d71fcab88c 100644
--- a/xen/common/domain.c
+++ b/xen/common/domain.c
@@ -1704,6 +1704,8 @@ long do_vcpu_op(int cmd, unsigned int vcpuid, XEN_GUEST_HANDLE_PARAM(void) arg)
         rc = map_vcpu_info(v, info.mfn, info.offset);
         domain_unlock(d);
 
+        force_update_vcpu_system_time(v);
+
         break;
     }
 
diff --git a/xen/include/asm-arm/time.h b/xen/include/asm-arm/time.h
index 6b8fd839dd..4b401c1110 100644
--- a/xen/include/asm-arm/time.h
+++ b/xen/include/asm-arm/time.h
@@ -105,6 +105,8 @@ extern uint64_t ns_to_ticks(s_time_t ns);
 
 void preinit_xen_time(void);
 
+void force_update_vcpu_system_time(struct vcpu *v);
+
 #endif /* __ARM_TIME_H__ */
 /*
  * Local variables:
-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Mon Oct 25 19:21:56 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Oct 2021 19:21:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.216058.375497 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mf5XR-0001EO-3I; Mon, 25 Oct 2021 19:21:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 216058.375497; Mon, 25 Oct 2021 19:21:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mf5XR-0001EH-0L; Mon, 25 Oct 2021 19:21:41 +0000
Received: by outflank-mailman (input) for mailman id 216058;
 Mon, 25 Oct 2021 19:21:39 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=M4PP=PN=oderland.se=josef@srs-us1.protection.inumbo.net>)
 id 1mf5XP-0001EB-Mx
 for xen-devel@lists.xenproject.org; Mon, 25 Oct 2021 19:21:39 +0000
Received: from office.oderland.com (unknown [91.201.60.5])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id ea4ec7f0-27ba-4ba5-a618-ba3291ce9006;
 Mon, 25 Oct 2021 19:21:37 +0000 (UTC)
Received: from [193.180.18.161] (port=36290 helo=[10.137.0.14])
 by office.oderland.com with esmtpsa (TLS1.2) tls
 TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2)
 (envelope-from <josef@oderland.se>)
 id 1mf5XM-008zcq-FS; Mon, 25 Oct 2021 21:21:36 +0200
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ea4ec7f0-27ba-4ba5-a618-ba3291ce9006
Message-ID: <c4d27d67-1027-e72b-c5bf-5546c5b0e2e9@oderland.se>
Date: Mon, 25 Oct 2021 21:21:33 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:93.0) Gecko/20100101
 Thunderbird/93.0
Content-Language: en-US
To: Jason Andryuk <jandryuk@gmail.com>, Marc Zyngier <maz@kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>, linux-pci@vger.kernel.org,
 xen-devel <xen-devel@lists.xenproject.org>,
 Thomas Gleixner <tglx@linutronix.de>, Juergen Gross <jgross@suse.com>,
 Boris Ostrovsky <boris.ostrovsky@oracle.com>
References: <20211019202906.GA2397931@bhelgaas>
 <5f050b30-fa1c-8387-0d6b-a667851b34b0@oderland.se>
 <877de7dfl2.wl-maz@kernel.org>
 <CAKf6xpt=ZYGyJXMwM7ccOWkx71R0O-QeLjkBF-LtdDcbSnzHsA@mail.gmail.com>
 <3434cb2d-4060-7969-d4c4-089c68190527@oderland.se>
 <90277228-cf14-0cfa-c95e-d42e7d533353@oderland.se>
 <CAKf6xpvZ8fxuBY4BZ51UZzF92zDUcvfav9_pOT7F3w-Bc8YkwA@mail.gmail.com>
From: Josef Johansson <josef@oderland.se>
Subject: Re: [PATCH v2] PCI/MSI: Re-add checks for skip masking MSI-X on Xen
 PV
In-Reply-To: <CAKf6xpvZ8fxuBY4BZ51UZzF92zDUcvfav9_pOT7F3w-Bc8YkwA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-AntiAbuse: This header was added to track abuse, please include it with any abuse report
X-AntiAbuse: Primary Hostname - office.oderland.com
X-AntiAbuse: Original Domain - lists.xenproject.org
X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12]
X-AntiAbuse: Sender Address Domain - oderland.se
X-Get-Message-Sender-Via: office.oderland.com: authenticated_id: josjoh@oderland.se
X-Authenticated-Sender: office.oderland.com: josjoh@oderland.se

On 10/25/21 03:25, Jason Andryuk wrote:
> On Sun, Oct 24, 2021 at 2:55 PM Josef Johansson <josef@oderland.se> wrote:
>
>> I ended up with this patch, I also masked pci_set_mask and
>> pci_set_unmask, even though patching __pci_restore_msi_state and
>> __pci_restore_msi_state solved this problem, I found that it did not
>> properly make the system be able to survive flip_done timeout related
>> problems during suspend/resume. Would this be something you had in mind
>> Marc? I will make one more try with just patching
>> __pci_restore_msi_state and __pci_restore_msix_state just to make sure.
>> diff --git a/drivers/pci/msi.c b/drivers/pci/msi.c index
>> 4b4792940e86..0b2225066778 100644 --- a/drivers/pci/msi.c +++
>> b/drivers/pci/msi.c @@ -420,7 +420,8 @@ static void
>> __pci_restore_msi_state(struct pci_dev *dev) arch_restore_msi_irqs(dev);
>> pci_read_config_word(dev, dev->msi_cap + PCI_MSI_FLAGS, &control); -
>> pci_msi_update_mask(entry, 0, 0); + if (!(pci_msi_ignore_mask ||
>> entry->msi_attrib.is_virtual)) + pci_msi_update_mask(entry, 0, 0);
>> control &= ~PCI_MSI_FLAGS_QSIZE; control |= (entry->msi_attrib.multiple
> This patch was mangled.
Thunderbird dislikes me plenty. Let's hope this turns out better.

I ended up with this patch, I also masked pci_set_mask and
pci_set_unmask, even though patching __pci_restore_msi_state and
__pci_restore_msi_state solved this problem, I found that it did not
properly make the system be able to survive flip_done timeout related
problems during suspend/resume. Would this be something you had in mind
Marc? I will make one more try with just patching
__pci_restore_msi_state and __pci_restore_msix_state just to make sure.


diff --git a/drivers/pci/msi.c b/drivers/pci/msi.c
index 4b4792940e86..0b2225066778 100644
--- a/drivers/pci/msi.c
+++ b/drivers/pci/msi.c
@@ -420,7 +420,8 @@ static void __pci_restore_msi_state(struct pci_dev *dev)
 	arch_restore_msi_irqs(dev);
 
 	pci_read_config_word(dev, dev->msi_cap + PCI_MSI_FLAGS, &control);
-	pci_msi_update_mask(entry, 0, 0);
+	if (!(pci_msi_ignore_mask || entry->msi_attrib.is_virtual))
+		pci_msi_update_mask(entry, 0, 0);
 	control &= ~PCI_MSI_FLAGS_QSIZE;
 	control |= (entry->msi_attrib.multiple << 4) | PCI_MSI_FLAGS_ENABLE;
 	pci_write_config_word(dev, dev->msi_cap + PCI_MSI_FLAGS, control);
@@ -450,8 +451,9 @@ static void __pci_restore_msix_state(struct pci_dev *dev)
 				PCI_MSIX_FLAGS_ENABLE | PCI_MSIX_FLAGS_MASKALL);
 
 	arch_restore_msi_irqs(dev);
-	for_each_pci_msi_entry(entry, dev)
-		pci_msix_write_vector_ctrl(entry, entry->msix_ctrl);
+	if (!(pci_msi_ignore_mask || entry->msi_attrib.is_virtual))
+		for_each_pci_msi_entry(entry, dev)
+			pci_msix_write_vector_ctrl(entry, entry->msix_ctrl);
 
 	pci_msix_clear_and_set_ctrl(dev, PCI_MSIX_FLAGS_MASKALL, 0);
 }
@@ -546,7 +548,8 @@ static int msi_capability_init(struct pci_dev *dev, int nvec,
 		return -ENOMEM;
 
 	/* All MSIs are unmasked by default; mask them all */
-	pci_msi_mask(entry, msi_multi_mask(entry));
+	if (!pci_msi_ignore_mask)
+		pci_msi_mask(entry, msi_multi_mask(entry));
 
 	list_add_tail(&entry->list, dev_to_msi_list(&dev->dev));
 
@@ -577,7 +580,8 @@ static int msi_capability_init(struct pci_dev *dev, int nvec,
 	return 0;
 
 err:
-	pci_msi_unmask(entry, msi_multi_mask(entry));
+	if (!pci_msi_ignore_mask)
+		pci_msi_unmask(entry, msi_multi_mask(entry));
 	free_msi_irqs(dev);
 	return ret;
 }
@@ -865,7 +868,8 @@ static void pci_msi_shutdown(struct pci_dev *dev)
 	dev->msi_enabled = 0;
 
 	/* Return the device with MSI unmasked as initial states */
-	pci_msi_unmask(desc, msi_multi_mask(desc));
+	if (!pci_msi_ignore_mask)
+		pci_msi_unmask(desc, msi_multi_mask(desc));
 
 	/* Restore dev->irq to its default pin-assertion IRQ */
 	dev->irq = desc->msi_attrib.default_irq;
@@ -950,8 +954,9 @@ static void pci_msix_shutdown(struct pci_dev *dev)
 	}
 
 	/* Return the device with MSI-X masked as initial states */
-	for_each_pci_msi_entry(entry, dev)
-		pci_msix_mask(entry);
+	if (!pci_msi_ignore_mask)
+		for_each_pci_msi_entry(entry, dev)
+			pci_msix_mask(entry);
 
 	pci_msix_clear_and_set_ctrl(dev, PCI_MSIX_FLAGS_ENABLE, 0);
 	pci_intx_for_msi(dev, 1);



>> This makes sense the patch would be like so, I'm testing this out now
>> hoping it will
>>
>> perform as good. Now the check is performed in four places
> Close.  I'll reply with my compiled, but untested patch of what I was thinking.
>> That leaves me with a though, will this set masked, and should be checked as well?
>>
>> void __pci_write_msi_msg(struct msi_desc *entry, struct msi_msg *msg)
>> {
>>         struct pci_dev *dev = msi_desc_to_pci_dev(entry);
>>
>>         if (dev->current_state != PCI_D0 || pci_dev_is_disconnected(dev)) {
>>                 /* Don't touch the hardware now */
>>         } else if (entry->msi_attrib.is_msix) {
>>                 void __iomem *base = pci_msix_desc_addr(entry);
>>                 u32 ctrl = entry->msix_ctrl;
>>                 bool unmasked = !(ctrl & PCI_MSIX_ENTRY_CTRL_MASKBIT);
>>
>>                 if (entry->msi_attrib.is_virtual)
>>                         goto skip;
>>
>>                 /*
>>                  * The specification mandates that the entry is masked
>>                  * when the message is modified:
>>                  *
>>                  * "If software changes the Address or Data value of an
>>                  * entry while the entry is unmasked, the result is
>>                  * undefined."
>>                  */
>>                 if (unmasked)
>>>>>                     pci_msix_write_vector_ctrl(entry, ctrl | PCI_MSIX_ENTRY_CTRL_MASKBIT);
> My patch adds a check in pci_msix_write_vector_ctrl(), but the comment
> above means PV Xen's behavior may be incorrect if Linux is calling
> this function and modifying the message.
>
> Regards,
> Jason
Turns out it seems to mess things up. I'm compiling this patch right now
with config flags below ( for anyone trying the same ). It should
perform ok I hope.

CONFIG_AMD_PMC=y
#CONFIG_HSA_AMD is not set
#CONFIG_DRM_AMD_SECURE_DISPLAY is not set
#CONFIG_CRYPTO_DEV_CCP is not set

Moving checks pci_msix_mask/pci_msix_unmask to ensure that init/shutdown
gets the checks as well. Avoiding
pci_msix_write_vector_ctrl/__pci_write_msi_msg
since it seems to have odd effects, like the comment in __pci_write_msi_msg
tells us. Just applying checks in __pci_restore_msi_state and
__pci_restore_msix_state
did not do the trick.

diff --git a/drivers/pci/msi.c b/drivers/pci/msi.c
index 4b4792940e86..acf14a4708e6 100644
--- a/drivers/pci/msi.c
+++ b/drivers/pci/msi.c
@@ -186,6 +186,9 @@ static void pci_msix_write_vector_ctrl(struct msi_desc *desc, u32 ctrl)
 
 static inline void pci_msix_mask(struct msi_desc *desc)
 {
+	if (pci_msi_ignore_mask)
+		return;
+
 	desc->msix_ctrl |= PCI_MSIX_ENTRY_CTRL_MASKBIT;
 	pci_msix_write_vector_ctrl(desc, desc->msix_ctrl);
 	/* Flush write to device */
@@ -194,13 +197,16 @@ static inline void pci_msix_mask(struct msi_desc *desc)
 
 static inline void pci_msix_unmask(struct msi_desc *desc)
 {
+	if (pci_msi_ignore_mask)
+		return;
+
 	desc->msix_ctrl &= ~PCI_MSIX_ENTRY_CTRL_MASKBIT;
 	pci_msix_write_vector_ctrl(desc, desc->msix_ctrl);
 }
 
 static void __pci_msi_mask_desc(struct msi_desc *desc, u32 mask)
 {
-	if (pci_msi_ignore_mask || desc->msi_attrib.is_virtual)
+	if (desc->msi_attrib.is_virtual)
 		return;
 
 	if (desc->msi_attrib.is_msix)
@@ -211,7 +217,7 @@ static void __pci_msi_mask_desc(struct msi_desc *desc, u32 mask)
 
 static void __pci_msi_unmask_desc(struct msi_desc *desc, u32 mask)
 {
-	if (pci_msi_ignore_mask || desc->msi_attrib.is_virtual)
+	if (desc->msi_attrib.is_virtual)
 		return;
 
 	if (desc->msi_attrib.is_msix)
@@ -420,7 +426,8 @@ static void __pci_restore_msi_state(struct pci_dev *dev)
 	arch_restore_msi_irqs(dev);
 
 	pci_read_config_word(dev, dev->msi_cap + PCI_MSI_FLAGS, &control);
-	pci_msi_update_mask(entry, 0, 0);
+	if (!(pci_msi_ignore_mask || entry->msi_attrib.is_virtual))
+		pci_msi_update_mask(entry, 0, 0);
 	control &= ~PCI_MSI_FLAGS_QSIZE;
 	control |= (entry->msi_attrib.multiple << 4) | PCI_MSI_FLAGS_ENABLE;
 	pci_write_config_word(dev, dev->msi_cap + PCI_MSI_FLAGS, control);
@@ -450,8 +457,9 @@ static void __pci_restore_msix_state(struct pci_dev *dev)
 				PCI_MSIX_FLAGS_ENABLE | PCI_MSIX_FLAGS_MASKALL);
 
 	arch_restore_msi_irqs(dev);
-	for_each_pci_msi_entry(entry, dev)
-		pci_msix_write_vector_ctrl(entry, entry->msix_ctrl);
+	if (!(pci_msi_ignore_mask || entry->msi_attrib.is_virtual))
+		for_each_pci_msi_entry(entry, dev)
+			pci_msix_write_vector_ctrl(entry, entry->msix_ctrl);
 
 	pci_msix_clear_and_set_ctrl(dev, PCI_MSIX_FLAGS_MASKALL, 0);
 }

Please let me know if I should submit any of the two, or make changes to them.

Regards
- Josef



From xen-devel-bounces@lists.xenproject.org Mon Oct 25 19:45:33 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Oct 2021 19:45:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.216066.375512 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mf5uS-0003bn-5S; Mon, 25 Oct 2021 19:45:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 216066.375512; Mon, 25 Oct 2021 19:45:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mf5uS-0003bg-2E; Mon, 25 Oct 2021 19:45:28 +0000
Received: by outflank-mailman (input) for mailman id 216066;
 Mon, 25 Oct 2021 19:45:26 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mf5uQ-0003bW-Gj; Mon, 25 Oct 2021 19:45:26 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mf5uQ-0004S2-7T; Mon, 25 Oct 2021 19:45:26 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mf5uP-0005d2-TY; Mon, 25 Oct 2021 19:45:25 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mf5uP-0001ih-T4; Mon, 25 Oct 2021 19:45:25 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=UgrTVpyPjqrdbIK0QKjs/YN9dPfAxOujdH7G1LZNa5g=; b=ifE6hCaHeUnXt6fAUoqssuASH3
	X84MJ5UTggl6GgaWfG6/GLiMdpzhMgQFvAUL/9hdTBqP8ED4KZ81SePYBIqEWV3UQWTaDsS/TkNnY
	PfYRdWN7qk8iy6tSYQSSOXH0N2hHpjRW+IpthP/U0SJOma7kFA24AxUXs1xqCd4xdBoo=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165861-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 165861: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=b0fce57a6a491c120f2554ad7cc9a0c43ee5defa
X-Osstest-Versions-That:
    xen=23ec1ebc8acbfd2bf06f6085a776f0db923f9fa9
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 25 Oct 2021 19:45:25 +0000

flight 165861 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165861/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  b0fce57a6a491c120f2554ad7cc9a0c43ee5defa
baseline version:
 xen                  23ec1ebc8acbfd2bf06f6085a776f0db923f9fa9

Last test of basis   165719  2021-10-21 18:00:27 Z    4 days
Testing same since   165861  2021-10-25 16:01:42 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Anthony PERARD <anthony.perard@citrix.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   23ec1ebc8a..b0fce57a6a  b0fce57a6a491c120f2554ad7cc9a0c43ee5defa -> smoke


From xen-devel-bounces@lists.xenproject.org Mon Oct 25 20:47:40 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Oct 2021 20:47:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.216079.375532 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mf6sN-000178-0n; Mon, 25 Oct 2021 20:47:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 216079.375532; Mon, 25 Oct 2021 20:47:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mf6sM-000171-S6; Mon, 25 Oct 2021 20:47:22 +0000
Received: by outflank-mailman (input) for mailman id 216079;
 Mon, 25 Oct 2021 20:47:21 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mf6sL-00016r-Oy; Mon, 25 Oct 2021 20:47:21 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mf6sL-0005c7-Ha; Mon, 25 Oct 2021 20:47:21 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mf6sL-0007eP-88; Mon, 25 Oct 2021 20:47:21 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mf6sL-0006LJ-7e; Mon, 25 Oct 2021 20:47:21 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=5tBv19FS2iKoNIIl+txd4o2xAXvrHhDCghhU8ebLYOo=; b=uc1ayZdbmQQfsz5uOuAnih+fb6
	ct05b8mu40vZ7MZsah01nIPhdJeVD8LCSk6j0hjAXZ19u8YsH2621xe4LEU+3tooQZR1aoil9cjLR
	Z4Alh3/ATnNYOo9bTamJ9OE+9GC+KW/EsYEHqWk9Jp5nJ2D4LB/HhF5rMAvjg8FoPHeA=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165855-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 165855: regressions - FAIL
X-Osstest-Failures:
    qemu-mainline:build-i386:xen-build:fail:regression
    qemu-mainline:build-i386-xsm:xen-build:fail:regression
    qemu-mainline:build-armhf:xen-build:fail:regression
    qemu-mainline:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-amd:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-pair:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-freebsd10-i386:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-freebsd10-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-coresched-i386-xl:build-check(1):blocked:nonblocking
    qemu-mainline:build-armhf-libvirt:build-check(1):blocked:nonblocking
    qemu-mainline:build-i386-libvirt:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-intel:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-shadow:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-vhd:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=c5b2f559814104f4145f8bc310f4d33c7ead8f49
X-Osstest-Versions-That:
    qemuu=50352cce138ef3b30c1cda28a4df68fff5da3202
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 25 Oct 2021 20:47:21 +0000

flight 165855 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165855/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-i386                    6 xen-build                fail REGR. vs. 165682
 build-i386-xsm                6 xen-build                fail REGR. vs. 165682
 build-armhf                   6 xen-build                fail REGR. vs. 165682

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl           1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-credit2   1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-cubietruck  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-multivcpu  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-rtds      1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-vhd       1 build-check(1)               blocked  n/a
 test-amd64-i386-qemuu-rhel6hvm-amd  1 build-check(1)               blocked n/a
 test-amd64-i386-pair          1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-freebsd10-i386  1 build-check(1)               blocked  n/a
 test-amd64-i386-freebsd10-amd64  1 build-check(1)               blocked  n/a
 test-amd64-coresched-i386-xl  1 build-check(1)               blocked  n/a
 build-armhf-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-credit1   1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-arndale   1 build-check(1)               blocked  n/a
 test-amd64-i386-qemuu-rhel6hvm-intel  1 build-check(1)             blocked n/a
 test-amd64-i386-xl            1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-pvshim     1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-qemuu-debianhvm-amd64  1 build-check(1)         blocked n/a
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow  1 build-check(1)  blocked n/a
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm  1 build-check(1)      blocked n/a
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 1 build-check(1) blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a
 test-amd64-i386-xl-qemuu-win7-amd64  1 build-check(1)              blocked n/a
 test-amd64-i386-xl-qemuu-ws16-amd64  1 build-check(1)              blocked n/a
 test-amd64-i386-xl-shadow     1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-vhd        1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-xsm        1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165682
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165682
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165682
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 qemuu                c5b2f559814104f4145f8bc310f4d33c7ead8f49
baseline version:
 qemuu                50352cce138ef3b30c1cda28a4df68fff5da3202

Last test of basis   165682  2021-10-19 21:09:14 Z    5 days
Failing since        165694  2021-10-20 18:09:12 Z    5 days   12 attempts
Testing same since   165823  2021-10-24 00:36:48 Z    1 days    4 attempts

------------------------------------------------------------
People who touched revisions under test:
  Alistair Francis <alistair.francis@wdc.com>
  Andrew Jones <drjones@redhat.com>
  Ani Sinha <ani@anisinha.ca>
  BALATON Zoltan <balaton@eik.bme.hu>
  Bin Meng <bmeng.cn@gmail.com>
  Cédric Le Goater <clg@kaod.org>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  David Gibson <david@gibson.dropbear.id.au>
  David Hildenbrand <david@redhat.com>
  Eric Auger <eric.auger@redhat.com>
  Eugenio Pérez <eperezma@redhat.com>
  Frank Chang <frank.chang@sifive.com>
  Gavin Shan <gshan@redhat.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Greg Kurz <groug@kaod.org>
  Gustavo Romero <gromero@linux.ibm.com>
  Igor Mammedov <imammedo@redhat.com>
  Jason Wang <jasowang@redhat.com>
  John Wang <wangzhiqiang02@inspur.com>
  John Wang <wangzq.jn@gmail.com>
  Laurent Vivier <laurent@vivier.eu>
  Laurent Vivier <lvivier@redhat.com>
  Luc Michel <lmichel@kalray.eu>
  Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
  Matheus Ferst <matheus.ferst@eldorado.org.br>
  Mathieu Poirier <mathieu.poirier@linaro.org>
  Michael S. Tsirkin <mst@redhat.com>
  Mingwang Li <limingwang@huawei.com>
  Oğuz Ersen <oguzersen@protonmail.com>
  Philipp Tomsich <philipp.tomsich@vrull.eu>
  Philippe Mathieu-Daudé <f4bug@amsat.org>
  Philippe Mathieu-Daudé <philmd@redhat.com>
  Richard Henderson <richard.henderson@linaro.org>
  Shuuichirou Ishii <ishii.shuuichir@fujitsu.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Thomas Huth <thuth@redhat.com>
  Tong Ho <tong.ho@xilinx.com>
  Travis Geiselbrecht <travisg@gmail.com>
  Vincent Palatin <vpalatin@rivosinc.com>
  Xueming Li <xuemingl@nvidia.com>
  Yanan Wang <wangyanan55@huawei.com>
  Yifei Jiang <jiangyifei@huawei.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               fail    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          blocked 
 test-amd64-i386-xl                                           blocked 
 test-amd64-coresched-i386-xl                                 blocked 
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  blocked 
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       blocked 
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           blocked 
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     blocked 
 test-amd64-i386-freebsd10-amd64                              blocked 
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          blocked 
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          blocked 
 test-armhf-armhf-xl-arndale                                  blocked 
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  blocked 
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  blocked 
 test-armhf-armhf-xl-cubietruck                               blocked 
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         blocked 
 test-amd64-i386-freebsd10-i386                               blocked 
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         blocked 
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                blocked 
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         blocked 
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 blocked 
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    blocked 
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     blocked 
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              blocked 
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    blocked 
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      blocked 
 test-amd64-i386-xl-vhd                                       blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 3631 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Oct 25 22:15:37 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Oct 2021 22:15:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.216087.375545 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mf8FX-00014U-Jl; Mon, 25 Oct 2021 22:15:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 216087.375545; Mon, 25 Oct 2021 22:15:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mf8FX-00014N-Gr; Mon, 25 Oct 2021 22:15:23 +0000
Received: by outflank-mailman (input) for mailman id 216087;
 Mon, 25 Oct 2021 22:15:23 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mf8FW-00014D-W4; Mon, 25 Oct 2021 22:15:23 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mf8FW-00074r-Lg; Mon, 25 Oct 2021 22:15:22 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mf8FW-0003Gv-EQ; Mon, 25 Oct 2021 22:15:22 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mf8FW-0002Q2-Dw; Mon, 25 Oct 2021 22:15:22 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=5wAKhshuCL7HEunn8JkPRMaY+2J7tGbb3Cu2dtreOFI=; b=QykLss0opI/mgJ1v0ik32hXLxh
	O/wIIAzwoVmGen5GdBK49jgocgbUTmOh5tZK9dviE7alz4vML7IfZGS6fPKmYQVz43PRDNPd8y+pC
	FfZrA/EpSm4mq1692FKMleXMl5eKnMH+xbu2R71pkKkoEAT5FiCNy1TOwX02N2Ya7zyo=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165862-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 165862: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=b80c17b62d989ec00e528c6307c726ce6800bcc4
X-Osstest-Versions-That:
    ovmf=8b76f235340922a6d293bff05978ba57d3b498e1
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 25 Oct 2021 22:15:22 +0000

flight 165862 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165862/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 b80c17b62d989ec00e528c6307c726ce6800bcc4
baseline version:
 ovmf                 8b76f235340922a6d293bff05978ba57d3b498e1

Last test of basis   165827  2021-10-24 02:10:08 Z    1 days
Testing same since   165862  2021-10-25 17:41:18 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Guo Dong <guo.dong@intel.com>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   8b76f23534..b80c17b62d  b80c17b62d989ec00e528c6307c726ce6800bcc4 -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Mon Oct 25 22:53:25 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Oct 2021 22:53:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.216095.375559 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mf8qE-00053t-Av; Mon, 25 Oct 2021 22:53:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 216095.375559; Mon, 25 Oct 2021 22:53:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mf8qE-00053m-7y; Mon, 25 Oct 2021 22:53:18 +0000
Received: by outflank-mailman (input) for mailman id 216095;
 Mon, 25 Oct 2021 22:53:16 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=3pPZ=PN=citrix.com=Andrew.Cooper3@srs-us1.protection.inumbo.net>)
 id 1mf8qC-00053g-1E
 for xen-devel@lists.xenproject.org; Mon, 25 Oct 2021 22:53:16 +0000
Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 176f6898-4b08-4e7f-89f6-58f3c52ccdb2;
 Mon, 25 Oct 2021 22:53:14 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 176f6898-4b08-4e7f-89f6-58f3c52ccdb2
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1635202393;
  h=to:cc:references:from:subject:message-id:date:
   in-reply-to:content-transfer-encoding:mime-version;
  bh=V/nM33d6voo4983foIZGmSycJc72zb3kex2wyvJoWMY=;
  b=H13t0W8aGnakkZmOvzCUPhm9u2/4a7QPLktQZPQ/8VgOgkp3UgTpDaql
   nIZVOR+/EFNDyDNxxxNmdrjLxtnXdcqwzf7VFds2JcXSD16uMfznfsFZY
   k91NL2uApLIJidZH0ezqjXXfbkcltBDuswwe8swZn/PE/0VciGpvbnr+4
   w=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: 8czdV+MxPXHOIBlpiQrHWdAjttpwzfrEX/P8i3lxLh1m9UxAte834VHnLtay7u3/mRYqQgNL+E
 sHOG/fOAqI/5wLAnvorzMywBfDveWhRmcghPmRFzebIrt3hIRtAoqc6BwM5Z5KLzC7Ot2Q24R/
 36y1nF6XWShIOCze6U3Oy2hTrPNJspvaZmcUOnVg7azUIq1E2CLwYDMJd7JqkyAHdxrPLBXZLm
 81M0C7f6AbTEKMa06khPD90cs0TDo18+GTAN31JWWbUUk7RJS95OGkm5uoATp5Oj/IFtYmKPol
 OHMIQy00x7UAWqZkDMgRaf/u
X-SBRS: 5.1
X-MesageID: 56055495
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:Va1bhqL7QNNTgIA7FE+ROJIlxSXFcZb7ZxGr2PjKsXjdYENS12FUm
 GoaUWqAaKyKNmH9fNhzYdjip0MA7cTdxtM1GVFlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s
 q3yv/GZdJhcokcxIn5BC5C5xZVG/fjgqoHUVaiUZUideSc+EH140Eo5xrZj6mJVqYPR7z2l6
 IuaT/L3YDdJ6xYsWo7Dw/vewP/HlK2aVAIw5jTSV9gS1LPtvyB94KYkDbOwNxPFrrx8RYZWc
 QphIIaRpQs19z91Yj+sfy2SnkciGtY+NiDW4pZatjTLbrGvaUXe345iXMfwZ3u7hB3ZlYF2y
 4pWsqCwVCQGZJb2ouA0Dh1XRnQW0a1uoNcrIFC6uM2XiUbHb2Ht07NlC0Re0Y8wo7gtRzsUr
 LpBdW5LPkvra+GemdpXTsFFgMg5IdatF4QYonx6lhnSDOo8QICFSKLPjTNd9Gpu3p0TQaeDD
 yYfQTpJaD/9QTMeAE8aFK5mhNas3zrPVjIN/Tp5ooJoujOOnWSdyoPFINfTP9CHW8hRtkKZv
 X7duXT0BAkAM96SwibD9Wij7sfNly7mXIMZFJWj6+VnxlaUwwQ7CQIUfUu2p+GjjUyzUM4ZL
 FYbkgIxqYAi+UrtScPyNyBUu1bd4ERaAYAJVbRntkfdkcI4/jp1GEBURG9Ga4M9s/M2WB8Fj
 GSzpdfAWDhg5ej9pW2myp+Yqja7OC4wJGAEZDMZQQZt3+QPsL3fnTqUEY49SP/dYsndXGiqm
 WjT/XdWa6A71JZTj82GEUb7byVAT3QjZjU+4RnLRSqb5wd9aZ/Ni2eAuAWDs6gowGp0SDC8U
 Jk4dyq2sL9m4XKlznXlrAAx8FaBvK7tDdEkqQQzd6TNDhz0k5JZQahe4StlOGBiOdsedDnib
 Sf74F0KucYDbCL7PP8mMupd7vjGKoC7TbzYug38NIISMvCdiifepEmCmnJ8L0iyyRNxwMnTy
 L+QcNq2DGZyNEiU5GHeegvp6pdynnpW7TqKHfjTlk37uZLDNC/9YepUazOmM7FmhJ5oVS2Iq
 r6zwePRkE4BOAA/CwGKmbMuwacidyhnWcmt8JwJLYZu4GNOQQkcNhMY+pt4E6RNlKVJjObYu
 Ha7X05T0l3kgnPbbw6NbxhehHnHBP6TdFo3Yn4hO0iGwX8mbdr95asTbcJvL7Im6PZi3bh/S
 PxcI5eMBfFGSzLm/TUBbMai8Nw+JUrz3Q/ebTC4ZDUffoJ7Q1Cb8NHTYQaypjIFCTC6tJVir
 uT4hB/bW5cKWy9rEN3SNKC011q0sHVEwLByUkLEL8N9YkLp9IQ2eSX9guVue5MHKAnZxyvc3
 AGTWE9Kqe7Iqo4z0d/ImaHb8Nv5T7ogRhJXRjCJ46y3OC/W+nuY7bVBCOvYLyrAUG7U+bm5Y
 bkHxf/LL/Bazk1BtJBxEug3wPtmtcfvvbJT0i9tAG7PMwawErplL3SLgZtPu6lKyuMLsAe6Q
 BvSqNxTOLHPM8L5Cl8BYgEia73bh/0TnzDT69UzIVn7u3ArrObWDx0KMknekjFZIZt0LJghk
 LUot8Mh4gCijgYnb4SdhSdO+mXQdnENXs3LbH3B7FMHXubz9mx/XA==
IronPort-HdrOrdr: A9a23:mhjzfqiYhHnWfDiIOB4z7izcEHBQX0p13DAbv31ZSRFFG/FwyP
 rAoB1L73PJYWgqNU3I+ergBEGBKUmskKKdkrNhQotKOzOWxFdATbsSkLcKpgePJ8SQzJ8k6U
 4NSdkYNDS0NykBsS+Y2njJLz9D+qj/zEnAv463pB0MPGIaGJ2IrT0JbjpzencGNTWubqBJcq
 Z0iPA3xQZINU5nFfhSURI+Lpb+TpDw5d/bSC9DIyRixBiFjDuu5rK/Ox+E3i0GWzcK5bs562
 DKnyHw+63m6piAu1Dh/l6Wy64TtMrqy9NFCsDJos8JKg/0ggLtQIh6QbWNsB08venqwlc3l9
 vnpQsmIq1Imj/sV1DwhSGo9xjr0T4o5XOn4ViEgUH7qci8fz4+A9opv/MQTjLpr24b+P1s2q
 NC2GyU87BNCwnboSj779/UEzl3i0uduxMZ4K4upk0adbFbRK5arIQZ8k8QOowHBjjG5IcuF/
 QrJN3A5cxRbUiRYxnizyhSKeSXLzYO9yq9Mw0/UpT/6UkToJk59TpX+CUnpAZCyHpnIKM0oN
 gtMcxT5fhzp4EtHORA7dw6ML6K41r2MGTx2VKpUCba/Z48SgbwQr7Mkf4IDbKRCdY1JKVbou
 W3bLofjx9qR37T
X-IronPort-AV: E=Sophos;i="5.87,181,1631592000"; 
   d="scan'208";a="56055495"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=fdsUl+cwR9poEKUfJjIF1P2Rw11wB7i1Tegp+bL61T4GtUPa3ySfWF4I8AmKrXJHZBKPv37rEhgNDmEfvXmhaMfQrL8XWLyTGQ1WKf0zdixXpP9Hfy23FetCzSCFd/jZPkbSQVOtpSpBuPX1PdqTEMPQ7obM/a9Qg+Hwx01JdHUCLQdhORXHkUZvz9rIT1i96ABoCBuNPQU0MWfnJeJUmH7Kwfg/qaCQZphlY/gYQTD7eZn3aEmw6CCScznxr9v/lDHYWgylubsCn8Lj4KdnOi8XX7DLhp9YXoNrfgEoZ3cNGcg5eblPQ+0g9R52kFTT7VG2IWG1fdFYUeiCszqFyA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=V/nM33d6voo4983foIZGmSycJc72zb3kex2wyvJoWMY=;
 b=TcweYxmwqp0UD5nKIxg2utsq/jq/6TdPqKCgKhqCe3Z/D3OZKBsaIjIhyZ+oIaL9yaa8wx11H0wxxsGCiyQ7KpUAg8xbagbXUfqcV93siA/evLHRAtnc57YSvFBn1kilf6aohdDdrzj2/zwzuFyj/W9NAjbDp5jeUiWjJkw3fYjqxdkUsMYsdpyLsOSvgSdPIWmAF5iOZjl/KrVTLR+LyQ5rQdXlLJ1gUdjRRfuO/0oMJRvVK8KkfbH+O1f2ceD3Wq/m6HvcVLiJzD72ysQ86Rm/VgMiQSKT6iI51e6tPCqzeIpmHpGf+qzyMbv2uHCGLNL4eSQf8TLg4s1PjjgbWA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=V/nM33d6voo4983foIZGmSycJc72zb3kex2wyvJoWMY=;
 b=Wgf/ub7ba5TJiZ6xmlr+a/PATk+f59mHgvTlF4vLOCeMMJchmP5DTyxCck+APDQuZofw1jRJjN0BeoYXeJe4CWVlMKUcJ/OW2LOVHbQ0NP57ZBrHqi6RSl9LjqqjgX1ZP3MoWzfjrVWlr7BiBTgBs4lu/TOn3wOkSD2ThCkCB94=
To: Jan Beulich <jbeulich@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Wei Liu <wl@xen.org>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
	<roger.pau@citrix.com>, Ian Jackson <iwj@xenproject.org>
References: <9963c7a2-f880-66fc-8f12-b1ddd0619c91@suse.com>
 <da80b8dd-177c-d27a-9a00-c9538a139d37@suse.com>
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [REGRESSION] [PATCH 1/2] x86/hpet: Use another crystalball to
 evaluate HPET usability
Message-ID: <68352fc1-9ba0-1081-be50-065b212f96a3@citrix.com>
Date: Mon, 25 Oct 2021 23:53:04 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <da80b8dd-177c-d27a-9a00-c9538a139d37@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Content-Language: en-GB
X-ClientProxiedBy: LO4P123CA0252.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:1a7::23) To BYAPR03MB3623.namprd03.prod.outlook.com
 (2603:10b6:a02:aa::12)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 092f959e-80c8-40d8-4681-08d9980a37ec
X-MS-TrafficTypeDiagnostic: BY5PR03MB5249:
X-Microsoft-Antispam-PRVS: <BY5PR03MB5249D7784BFF5B433D1A373FBA839@BY5PR03MB5249.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:4714;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: JxzOoOexOI11scwwz88CiALa35e8JHCASysdwf+8X7KtZEKdKF0QRPOSvfWnk3//Pxs89nQM+pygOcrhwQhvAgDIK+LzP2RYdAJuFsDs6u33hZgSCRCos73Iw28ifMR97vqCW1EtO/DkfDtGVdP0lie7jhpEqUB68GuEDQ630ghDTR9xVDmjE6cyzR+ZUUPtvzWuOOFSqXZu4eAWqgiC4xpzwelIK4S68+zSVvvnviK2INs6bRmAJQ6g+ulvJn0UrR0s3KyO5xeKn8E264LW2EgUAbdNRIXxfs3gYm8vUz5U6enqSZy0ka6M+qjHizebFhr5AHoTowIJZ9hqutdfYGw9XZKhbV88Vl+Q9VooZk7kexWTuY8/hoqasF0bDIxLVN0EtNG+/R5YNOlWIcrzLnprKMPqmh4hZdgUyD7VStl+OWobVuXWooeL5ipefA2YlHM2uyQiXs7LFp4Fatm0Ni7kLhj5BjF3EqLGXpPDKjdHTfI47+tB4jFqSW70kPc2YUCdZFxoVF1s4qMbLYjBepTacK2Tju7mrLYcE2bfRxq8Mx6chlGfXGvb79owRbibhYbNRsjTTyrPKobYn5wZgP3CDviIEZO+F12rVXZSvy5f5aPaKeO/q0789j213RNHVGmKmxAAYDNkigKJ8O7nUeMYcvNE4fL0/oSzfVZS7QJihgtM+4BN3VAzhVd/Vlq00D5jk/rUp5Ow3zSouLUR9SF9YqZ4JGKN5GMfJoOLe+I=
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(31696002)(6666004)(54906003)(110136005)(186003)(31686004)(82960400001)(38100700002)(66946007)(83380400001)(86362001)(66556008)(66476007)(5660300002)(8936002)(316002)(2616005)(6486002)(2906002)(8676002)(26005)(36756003)(4326008)(508600001)(956004)(53546011)(16576012)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NFZkclhEMnhJNVpjK1RpQ1hEb1VsYkxBWG5BaEdudExNUjg0RnZ2cFl5a3FZ?=
 =?utf-8?B?RXFiSURMaUJOV05zNkNnczM4T1RMN1UxZTJVNnMwMVl3SmExcWhmRWFMVFli?=
 =?utf-8?B?eG1rbGRGTExjNHVVWVVxZVJ5N3dVWGUrVWM3MnRNY1drcWRCdXVvYUZwR2R2?=
 =?utf-8?B?TGJ3ZC8zZW81anVyalJzdVZGUVVYZ2JlWnNPMC8wWGlBZklpakZSKys2M1kz?=
 =?utf-8?B?MzU4YnFTQ05mTklVSG5nTzc4NU14azlXUzJZbE90SjlONmdtWGJoT1JHVVFh?=
 =?utf-8?B?QUU0NURqNUwyNmJ1b2pZY3VpU3B1WVFUaldFSVVoTllrL2N6WmxNNzFjL2l4?=
 =?utf-8?B?c09WSm9QK1dQVCtsUkloN0phM2FYMXpXTlNmVkZZRFdsbXhkRUNHUHh1ek1l?=
 =?utf-8?B?VUtMN3BKRkVSUEFFMG00VnErWTFQdm1EejFRL013Y3lpbE5FaUZKTm96QklT?=
 =?utf-8?B?aTBNY3pBYmxYckQ4OGJiWWROWmZXQXN6YythQWl4UXpBZmVFWGVVaTJrbEd2?=
 =?utf-8?B?V3FkRDQxTU8xME9SY2JkVEwwUlFRcUx2TElXcEd4NDZLdUUzUG5QUENGWGo4?=
 =?utf-8?B?VHRLOHVsTFFwejJmR3F3MzlNeHlHNUwzZ0FSbk92bWtCK1hObXM0M2ZuZHRu?=
 =?utf-8?B?K1ZqOWpGSHJLODlUb0dpVVRRR3JFaFE4eXdwVlZGaWkydFcwODRUaTB5S1JS?=
 =?utf-8?B?VGJsakRsa2Y5VmJzbEVVM1JEVVpHelAyNGxLQ0ZaZnZvQ01UbGRscHVXMGUw?=
 =?utf-8?B?aE1xQzRPMXo3Y0RmY0pldC83WDlwNEJKaVRxbndZL2t1YVhxK1N4SnZxTnFl?=
 =?utf-8?B?cEpHekJsVzcrbFlCZkdkbk5FbkdLc2lGNmc3NUpjYXlRcjRzRWpKT0VpaEQx?=
 =?utf-8?B?cVIrMjlHRDNSYklQOThqTGJTdTlWbWMzVlVIUFRGU3FGbythNTAzTzR4dWty?=
 =?utf-8?B?UlREald4NTUwdTNEeXZHc0VNRDVLZEh6M29Od29xY0RXMFM1TlMzZUlMYnZZ?=
 =?utf-8?B?ZmlmWjlvZThUVTA1MUVKS2I2enp1bHU5QVJid09Hb2tzSHVaYTNoM1h1U1hZ?=
 =?utf-8?B?VldyUEdiZDBhMGExODR3a3pUSUtUdjJwQlIxQ016Umhaa0ZiNlJSZ1N1ejNu?=
 =?utf-8?B?b2xLcXBrWjloMDNnRU9DdDFEZVdSMFREVTNzNmhBbU9VVDJYT3l1eEhTcXpo?=
 =?utf-8?B?b3ViK3VyOHNGeFhXcFUzZy9aM3MwYUpJS3E5TnFRVE52VFB6SUVPNDI2Z2Rj?=
 =?utf-8?B?aDQ5VXdTbWhzbyttcEgxRmRIR0pUWVhQV0VYbjZ6UTZEWHJFd0lHQkQ0SG1r?=
 =?utf-8?B?dGpGNFBERFBRcDlZb09uMTJJRmY3dStuZjlJWXJlUnVMUEZGZjZkVU5SYVlB?=
 =?utf-8?B?QTkrRjZOMGNyNm9kWGV0dmIxRGZUWEtrVldBaHVudXJFeWcwTE5pdjZpNEdp?=
 =?utf-8?B?aFhIRlpDQ0NmeHRWdUtWRjUzaUdENmE3K0xSYlZTSFZKRU9Td2dZSzdEZSs3?=
 =?utf-8?B?RlVPOExReGx1enFaQmU1aWdPeGNnRUVJVHNzMG1icThXMnRJckpMUnpveUgr?=
 =?utf-8?B?bjlFM0FaNHRJVWRYY1BrY3NyMnBvWmRXdVJiZEpMZEVaK0RFTkc0Nmg1c3RB?=
 =?utf-8?B?NytNNzhQODhFMUp6aHdneUxjY3luMXJKbDZaK0JzSU5udE1mcmhWYlZGSFQ0?=
 =?utf-8?B?UWJhYkloZjFSS1kwWE9lc0xEWXRtSXNoQlNORGlmazArK3A4blJLT0wvT1NE?=
 =?utf-8?B?NkJKTDY0MjRpYU5UMURmUmh2SGFPcm1Ebk5iY2pZNU5rWVVpU1JGZmJCMVQ4?=
 =?utf-8?B?Z21GTFRVQWh3Um51SzNGcWQzdWlqQ0FkQ3BDZ2pSNFQvTXFBTEh1dGhkaVlF?=
 =?utf-8?B?d2lnOXFjbHUrc3B2K2ZFNjFMbXRqd0JjZjhHQ0IyRzkvYm5nZGNDT1FnTXEv?=
 =?utf-8?B?Y3hLd0grSitLZ0RvK2JBMWxaZjRCN1lDWGtpT1RSUGpzSnNMTUVYWFMwR2gw?=
 =?utf-8?B?QlNrSjNIaUpDd3J5eUNwY3d4b0JFQjYwMHhTUGNZWUZ0Q1NZWHFma1lyVGhV?=
 =?utf-8?B?bHV2WEFPdjhhdFhhVFd1ZExGRE9ZNXFlRnl3UCtsNE5JK1d4OHhkUWdCMTNN?=
 =?utf-8?B?M2hWTkdGTU1lWHRzQ0c0bTVlTW1qWVBGZUtQbzRMSWs3N01xUHQ4elRoYmVU?=
 =?utf-8?B?cXdyNjlxWlRCNTQ4c3pBMEdkVGhEWDJYc2Rsb3JLYlhXUjFPQ3V6TGdmbFJr?=
 =?utf-8?B?NnE0dXZiSkV4bWhLV2RISkZJVjdBPT0=?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 092f959e-80c8-40d8-4681-08d9980a37ec
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2021 22:53:10.7530
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: aCilYuy7K0pQYTvz1CTg5J+dHSfYQx3cQpCpA7OE4kSQf/cuFQ5quUTjR9eaBRwuI71MkjKVwW3mV4Mo+4Om+D3WnCPpl23Z27j99CIlO8I=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR03MB5249
X-OriginatorOrg: citrix.com

On 19/10/2021 08:07, Jan Beulich wrote:
> From: Thomas Gleixner <tglx@linutronix.de>
>
> On recent Intel systems the HPET stops working when the system reaches PC=
10
> idle state.
>
> The approach of adding PCI ids to the early quirks to disable HPET on
> these systems is a whack a mole game which makes no sense.
>
> Check for PC10 instead and force disable HPET if supported. The check is
> overbroad as it does not take ACPI, mwait-idle enablement and command
> line parameters into account. That's fine as long as there is at least
> PMTIMER available to calibrate the TSC frequency. The decision can be
> overruled by adding "clocksource=3Dhpet" on the Xen command line.
>
> Remove the related PCI quirks for affected Coffee Lake systems as they
> are not longer required. That should also cover all other systems, i.e.
> Ice Lake, Tiger Lake, and newer generations, which are most likely
> affected by this as well.
>
> Fixes: Yet another hardware trainwreck
> Reported-by: Jakub Kicinski <kuba@kernel.org>
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> [Linux commit: 6e3cd95234dc1eda488f4f487c281bac8fef4d9b]
>
> I have to admit that the purpose of checking CPUID5_ECX_INTERRUPT_BREAK
> is unclear to me, but I didn't want to diverge in technical aspects from
> the Linux commit.
>
> In mwait_pc10_supported(), besides some cosmetic adjustments, avoid UB
> from shifting left a signed 4-bit constant by 28 bits.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

This breaks booting on recent Intel platforms.

Ian: Complete blocker for the release.

~Andrew



From xen-devel-bounces@lists.xenproject.org Mon Oct 25 23:13:56 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Oct 2021 23:13:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.216104.375570 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mf9A3-0007Vb-74; Mon, 25 Oct 2021 23:13:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 216104.375570; Mon, 25 Oct 2021 23:13:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mf9A3-0007VU-3Y; Mon, 25 Oct 2021 23:13:47 +0000
Received: by outflank-mailman (input) for mailman id 216104;
 Mon, 25 Oct 2021 23:13:45 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mf9A1-0007VK-LL; Mon, 25 Oct 2021 23:13:45 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mf9A1-00086F-DB; Mon, 25 Oct 2021 23:13:45 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mf9A1-0006Yc-1m; Mon, 25 Oct 2021 23:13:45 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mf9A1-0004zq-1H; Mon, 25 Oct 2021 23:13:45 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=qcISmRrs5NLem/rCabTFeuG0aXeosak9WBwWMRnx1eM=; b=afrjQigZQLSc32wqzGWnFol3MT
	Az9rE2cGStrTApRr3qG1z/IaaBNg19m/eh/ziBtyOKFTyUFwCjiGhMbQ+0R/HL7xZQIofO1SnLxUd
	zHjrH/6xUzp1cPXRzNFAgSOzesJL8x/ozuasFxyZ46ELjmXRyDmRk2FiOV/ybCi20y1A=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165858-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 165858: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-examine:memdisk-try-append:fail:heisenbug
    linux-linus:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:heisenbug
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=87066fdd2e30fe9dd531125d95257c118a74617e
X-Osstest-Versions-That:
    linux=6c62666d8879238578b727f8e0a821e90c88f87e
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 25 Oct 2021 23:13:45 +0000

flight 165858 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165858/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-examine    4 memdisk-try-append fail in 165848 pass in 165858
 test-amd64-amd64-xl-rtds     20 guest-localmigrate/x10     fail pass in 165848

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 165841
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 165841
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165841
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 165841
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165841
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 165841
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 165841
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165841
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 linux                87066fdd2e30fe9dd531125d95257c118a74617e
baseline version:
 linux                6c62666d8879238578b727f8e0a821e90c88f87e

Last test of basis   165841  2021-10-24 17:40:42 Z    1 days
Testing same since   165848  2021-10-25 00:39:18 Z    0 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
  Al Viro <viro@zeniv.linux.org.uk>
  Ian Kent <raven@themaw.net>
  Linus Torvalds <torvalds@linux-foundation.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     fail    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   6c62666d8879..87066fdd2e30  87066fdd2e30fe9dd531125d95257c118a74617e -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Mon Oct 25 23:30:18 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 25 Oct 2021 23:30:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.216114.375591 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mf9Po-00014m-Ms; Mon, 25 Oct 2021 23:30:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 216114.375591; Mon, 25 Oct 2021 23:30:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mf9Po-00014G-IU; Mon, 25 Oct 2021 23:30:04 +0000
Received: by outflank-mailman (input) for mailman id 216114;
 Mon, 25 Oct 2021 23:30:03 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=FKMe=PN=gmail.com=f.fainelli@srs-us1.protection.inumbo.net>)
 id 1mf9Pn-0000u9-DO
 for xen-devel@lists.xenproject.org; Mon, 25 Oct 2021 23:30:03 +0000
Received: from mail-pf1-x42f.google.com (unknown [2607:f8b0:4864:20::42f])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id e2d0b6e2-ad74-486a-b937-7b1019ef4549;
 Mon, 25 Oct 2021 23:30:02 +0000 (UTC)
Received: by mail-pf1-x42f.google.com with SMTP id f11so12390620pfc.12
 for <xen-devel@lists.xenproject.org>; Mon, 25 Oct 2021 16:30:02 -0700 (PDT)
Received: from [10.67.48.245] ([192.19.223.252])
 by smtp.googlemail.com with ESMTPSA id 17sm18371534pgr.10.2021.10.25.16.30.00
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Mon, 25 Oct 2021 16:30:01 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e2d0b6e2-ad74-486a-b937-7b1019ef4549
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-language:content-transfer-encoding;
        bh=OikzpJy+ulJ/iMPwSBk+Y4Qdnv1zoI4G2kzh3S5KjZM=;
        b=niw1O1xOaY9hFPDD8aUNNrjsW9u7HwlbmG6x6SNsYU3yjleoefJrZVsAm6SP8NuMjP
         o23nxHuB9LRuLkmRK2UiQTUmVNUMeI2aUdskZVzE3kgHOaWyfAnzcjpSnjQ9GFvYWsdG
         ZgdU7ewZjtu9Zxi9AwvEcfdEr5jiZmlfmbioVfyDYsHUnJ3k+v19ddXVwQV+2dzjsbm1
         rd/Foo/V5GZ7FcPhAG8S9s8VIgf78dUk+e2NSAsg0qG+bevmGflOwurxALQD2vhb0uGz
         NGYqiGIGbibAYCwIWp6EhQJ4nOKzZQZAlKnxlFMEaL9H3kiE9egr8ez2CYR1OxZeO16A
         znTw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-language
         :content-transfer-encoding;
        bh=OikzpJy+ulJ/iMPwSBk+Y4Qdnv1zoI4G2kzh3S5KjZM=;
        b=gJgSAHcq6k3k88uESSCQZeV0kwr+vaUbuiTcGm8VH+It1ECJZVAGIANRtPMLTTQcl0
         EY070JvCkLYrV3D4RSNlURQ2Iwkn9gzPjWWscvfmhFZMCl09SDIjSQ8OwYOHwooFurpC
         gOIsjvxvyTz7qNxmbUIviyrylzllFQQlL0AMyYKZpXKAoXYXDA6Zon7bWZXAy3kRjOCf
         rbKJmzMs3rjYm5vtlkggc/6ztrhEjm70pYAJZQV1iLwOLYEZNJNFkWN4sZrXzuY8YBaS
         x2wYgTul5nRCB2lJ7TxZtJhSP5dTDkFTjsFkewjS0qNclwJUSepCnlYmhE1BCmkYwf/c
         edLA==
X-Gm-Message-State: AOAM5328ARl0QRDFmh4jaWvi2VA68YQVoBU7DW0rdpH/opvni7fav3Zf
	DerLnVPwrz3Z1jbBJvCiPEQvqTN1guY=
X-Google-Smtp-Source: ABdhPJxaIKGEf2USmRDZLHOcP+kwnUC5n6wwg3jX/sVXLhqW+xa5nJ1+8RyfSCoGTxRcq20hfuuFAg==
X-Received: by 2002:a63:ab02:: with SMTP id p2mr15989657pgf.209.1635204601641;
        Mon, 25 Oct 2021 16:30:01 -0700 (PDT)
Subject: Re: [RESEND 0/5] ARM/arm64: arm_pm_restart removal
To: Lee Jones <lee.jones@linaro.org>, linux@armlinux.org.uk,
 catalin.marinas@arm.com, will@kernel.org, mark.rutland@arm.com,
 lorenzo.pieralisi@arm.com, sstabellini@kernel.org
Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
 wsa+renesas@sang-engineering.com, linux@roeck-us.net, treding@nvidia.com,
 arnd@arndb.de, xen-devel@lists.xenproject.org, patches@armlinux.org.uk
References: <20210604140357.2602028-1-lee.jones@linaro.org>
From: Florian Fainelli <f.fainelli@gmail.com>
Message-ID: <526fe66f-df08-c873-2a20-f1295e30a855@gmail.com>
Date: Mon, 25 Oct 2021 16:29:59 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
MIME-Version: 1.0
In-Reply-To: <20210604140357.2602028-1-lee.jones@linaro.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 6/4/21 7:03 AM, Lee Jones wrote:
> This is a rebase/refresh of a set sent out, reviewed,
> then forgotten about.  It's still considered useful.
> 
> Here is an excerpt from the previous attempt:
> 
>  "Hi Russell, ARM SoC maintainers,
> 
>  here's the full set of patches that remove arm_pm_restart as discussed
>  earlier. There's some background on the series in this thread:
> 
> 	https://lore.kernel.org/linux-arm-kernel/20170130110512.6943-1-thierry.reding@gmail.com/
> 
>  I also have a set of patches that build on top of this and try to add
>  something slightly more formal by adding a power/reset framework that
>  driver can register with. If we can get this series merged, I'll find
>  some time to refresh those patches and send out for review again.

What happened to this patch series? Is there any chance we will get it
included at some point? It is included in the Android13-5.10 tree AFAICT
-- 
Florian


From xen-devel-bounces@lists.xenproject.org Tue Oct 26 00:54:21 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Oct 2021 00:54:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.216123.375602 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfAj8-000158-UU; Tue, 26 Oct 2021 00:54:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 216123.375602; Tue, 26 Oct 2021 00:54:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfAj8-000151-RJ; Tue, 26 Oct 2021 00:54:06 +0000
Received: by outflank-mailman (input) for mailman id 216123;
 Tue, 26 Oct 2021 00:54:05 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=7zbS=PO=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1mfAj7-00014v-CG
 for xen-devel@lists.xenproject.org; Tue, 26 Oct 2021 00:54:05 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 0a829180-a056-46c0-a7bc-88cfcd6c9938;
 Tue, 26 Oct 2021 00:54:04 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id 57A0860E05;
 Tue, 26 Oct 2021 00:54:03 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0a829180-a056-46c0-a7bc-88cfcd6c9938
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1635209643;
	bh=HEeMVtfCyJAt2fsNPWRd9oaQjciBifhzo0h6szOps34=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=fdSvT32a/MoeOzs96dMdVUvnCOfUM5LtfIPu/Mpbpr1Bp2odig7FIXkCaYNybWN6v
	 Z9LlcWBulifYNEt0e2eiScg1gvmwpnw6NmYCmBQKSpA669Wy7lkyIxCkoCY+s2dZ3w
	 aijaN2e3FKopo07CJke6JFJ2kaQh3CMWM7Iz+HKbb5z6TioSsDqWjTcscPPN/CZoQP
	 W3LRQIfDIBC/nK9tU164ICJGakqoly169y+8G6fcaOz/cd1+nMoCuRuPwdolA7pvLB
	 Jc52nwUHJniHUF2sHg8eaNQIZcPuEHZIB3aXyrj1Zrj09L3I4Arhd3vsGpR+Ka//Fh
	 b0gXo7sMqJOkg==
Date: Mon, 25 Oct 2021 17:54:02 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Juergen Gross <jgross@suse.com>
cc: Stefano Stabellini <sstabellini@kernel.org>, 
    Andrew Cooper <andrew.cooper3@citrix.com>, xen-devel@lists.xenproject.org, 
    iwj@xenproject.org, cardoe@cardoe.com, wl@xen.org, 
    anthony.perard@citrix.com, 
    Stefano Stabellini <stefano.stabellini@xilinx.com>
Subject: Re: [PATCH 2/3] automation: Linux 5.10.74 test-artifact
In-Reply-To: <d559b765-9e38-00bd-039b-9c33845b8e54@suse.com>
Message-ID: <alpine.DEB.2.21.2110251753200.4586@sstabellini-ThinkPad-T480s>
References: <alpine.DEB.2.21.2110210831470.2311@sstabellini-ThinkPad-T480s> <20211021230839.10794-2-sstabellini@kernel.org> <19aa9196-eb5f-22a1-206c-c9c87ee79fa9@citrix.com> <alpine.DEB.2.21.2110221219300.2311@sstabellini-ThinkPad-T480s>
 <d559b765-9e38-00bd-039b-9c33845b8e54@suse.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="8323329-1591971946-1635209643=:4586"

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-1591971946-1635209643=:4586
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT

On Mon, 25 Oct 2021, Juergen Gross wrote:
> On 22.10.21 21:41, Stefano Stabellini wrote:
> > +Juergen
> > 
> > On Fri, 22 Oct 2021, Andrew Cooper wrote:
> > > On 22/10/2021 00:08, Stefano Stabellini wrote:
> > > > +# build depends
> > > > +RUN apt-get update && \
> > > > +    apt-get --quiet --yes install \
> > > > +        build-essential \
> > > > +        libssl-dev \
> > > > +        bc \
> > > > +        curl \
> > > > +        flex \
> > > > +        bison \
> > > > +        libelf-dev \
> > > > +        && \
> > > > +    \
> > > > +    # Build the kernel
> > > > +    curl -fsSLO
> > > > https://cdn.kernel.org/pub/linux/kernel/v5.x/linux-"$LINUX_VERSION".tar.xz
> > > > && \
> > > > +    tar xvJf linux-"$LINUX_VERSION".tar.xz && \
> > > > +    cd linux-"$LINUX_VERSION" && \
> > > > +    make defconfig && \
> > > > +    make xen.config && \
> > > > +    cp .config .config.orig && \
> > > > +    cat .config.orig | grep XEN | grep =m |sed 's/=m/=y/g' >> .config
> > > > && \
> > > > +    make -j$(nproc) bzImage && \
> > > 
> > > defconfig is huuuuge.  Can we use tinyconfig instead?
> > > 
> > > Also, you want to turn off CONFIG_MODULES seeing as you only copy
> > > bzImage to the test.
> > > 
> > > This also fixes the fact that `grep XEN` also matches CONFIG_NETXEN_NIC
> > > which has nothing to do with Xen.
> > 
> > Tinyconfig would be a good idea but it crashes on QEMU with the appended
> > boot log. I did:
> > 
> > # make tinyconfig
> > # make xen.config
> > # make bzImage
> > 
> > Of course we could have our own tailored special kernel config for this
> > kernel but I like the simplicify of "make tinyconfig" or "make
> > defconfig" followed by "make xen.config".
> > 
> > Unless you know one kconfig option or two that we need to add to
> > tinyconfig to make it work my preference is to go with defconfig for
> > now.
> 
> You will need to add the dom0 and SMP related config options at least.
> 
> I'll have a look at config.xen, which is a little bit weird: it
> configures the backends, but not dom0.

Thanks, it would be good if make tinyconfig && make xen.config would
just work on QEMU. In the meantime I'll keep defconfig for this test, we
can always improve later.
--8323329-1591971946-1635209643=:4586--


From xen-devel-bounces@lists.xenproject.org Tue Oct 26 01:02:41 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Oct 2021 01:02:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.216130.375613 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfArM-0004eN-Oz; Tue, 26 Oct 2021 01:02:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 216130.375613; Tue, 26 Oct 2021 01:02:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfArM-0004eG-Ll; Tue, 26 Oct 2021 01:02:36 +0000
Received: by outflank-mailman (input) for mailman id 216130;
 Tue, 26 Oct 2021 01:02:35 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=bjQH=PO=gmail.com=groeck7@srs-us1.protection.inumbo.net>)
 id 1mfArL-0004eA-NE
 for xen-devel@lists.xenproject.org; Tue, 26 Oct 2021 01:02:35 +0000
Received: from mail-ot1-x32b.google.com (unknown [2607:f8b0:4864:20::32b])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 5698fdc7-0f89-45ca-b550-58ca090f44bd;
 Tue, 26 Oct 2021 01:02:34 +0000 (UTC)
Received: by mail-ot1-x32b.google.com with SMTP id
 z5-20020a9d4685000000b005537cbe6e5aso10709192ote.1
 for <xen-devel@lists.xenproject.org>; Mon, 25 Oct 2021 18:02:34 -0700 (PDT)
Received: from server.roeck-us.net ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c])
 by smtp.gmail.com with ESMTPSA id
 o12sm3987438oti.21.2021.10.25.18.02.32
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Mon, 25 Oct 2021 18:02:33 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
X-Inumbo-ID: 5698fdc7-0f89-45ca-b550-58ca090f44bd
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=sender:subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-language:content-transfer-encoding;
        bh=QoNo/gJ6xc/Lk71yUFY24yh/oDqwuM2rlI5YSI1Io30=;
        b=GPfYmTWaHMBbwyAoKorrgVTbZsmFqlu3TOEUwGHy2OWxrtvOOFmL05VvF2U0sO6yq0
         cVG2pGChgd50T10TZSsWNX05FELD1uvjy4vLApxnevG1JaFlX/01wc7bxYRIYPX9ot1j
         mhYj1Tn0i4N36hjzzsBFrFWjLhvHNK5OzDFjtK4IGQ/3RZsFvUyASOSC146FiTC7yTWx
         HZ/+VrrW4xUyv5bJobb84DMvFKh18sl1EjBuYTM6yOx7G8gWIfIcOy/Lv+2OP97aLqdm
         kVSOnhDE6i8MzbciAdTRwtEDm22pLsFy89+ZvJOg2agEUTAHLC62rfazSXLNYffW8WL8
         azdg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:sender:subject:to:cc:references:from:message-id
         :date:user-agent:mime-version:in-reply-to:content-language
         :content-transfer-encoding;
        bh=QoNo/gJ6xc/Lk71yUFY24yh/oDqwuM2rlI5YSI1Io30=;
        b=4sX1n/9Up/4a1n+CDRgwPlENCpXOzLR1AmqrZfpiL1iYN3sfAhmJ1dgwUD+3ZEo+cP
         x7Sg1Sv20YAr66Ync/UTPMLt0mHUvkVJsFhnsQ0ASPz14uIwW3BsGGbDIktet8d4pMGP
         StiVaUoSE66V2X+4zw9Rvr4AI/snr5WOQ4qNqtX2vKgzi8NjJiPV3hGX2TBLOoc4EQ5l
         +2Fv62ox5oBRgrmTJZ3CEjYfaqEm1g6NA4829/NkH6ERvXc+/bRweXHDGDXMNO1+TVQF
         BUSGc8ddw7gc1q09EiJzTJZ1PN9KXsMil2jdsBjJJDpQZs/e8LOGX0Zlb2YKj8B866Z1
         8vXw==
X-Gm-Message-State: AOAM533SRlqrOKBSVh2zqSPk9Czr5FSBSHe/47yhoLiu7UmN2/1Dchtg
	v45W8qW2mPVjYBoUetljomU=
X-Google-Smtp-Source: ABdhPJxMlKWW+1zbC7QoBnBIjxiIfh66+rRIl5XDXf7TN2O3gbhH6mxZxLAaz09z6baWVCUcqaQD8g==
X-Received: by 2002:a9d:4616:: with SMTP id y22mr16425867ote.165.1635210154279;
        Mon, 25 Oct 2021 18:02:34 -0700 (PDT)
Sender: Guenter Roeck <groeck7@gmail.com>
Subject: Re: [RESEND 0/5] ARM/arm64: arm_pm_restart removal
To: Dmitry Osipenko <digetx@gmail.com>,
 Florian Fainelli <f.fainelli@gmail.com>, Lee Jones <lee.jones@linaro.org>,
 linux@armlinux.org.uk, catalin.marinas@arm.com, will@kernel.org,
 mark.rutland@arm.com, lorenzo.pieralisi@arm.com, sstabellini@kernel.org
Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
 wsa+renesas@sang-engineering.com, treding@nvidia.com, arnd@arndb.de,
 xen-devel@lists.xenproject.org, patches@armlinux.org.uk
References: <20210604140357.2602028-1-lee.jones@linaro.org>
 <526fe66f-df08-c873-2a20-f1295e30a855@gmail.com>
 <a4fe088f-0f13-f80f-5011-4eee2d44ef63@gmail.com>
From: Guenter Roeck <linux@roeck-us.net>
Message-ID: <321b167f-8744-9ca8-58b0-e09ff39dfa02@roeck-us.net>
Date: Mon, 25 Oct 2021 18:02:31 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
MIME-Version: 1.0
In-Reply-To: <a4fe088f-0f13-f80f-5011-4eee2d44ef63@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit

On 10/25/21 4:55 PM, Dmitry Osipenko wrote:
> 26.10.2021 02:29, Florian Fainelli пишет:
>> On 6/4/21 7:03 AM, Lee Jones wrote:
>>> This is a rebase/refresh of a set sent out, reviewed,
>>> then forgotten about.  It's still considered useful.
>>>
>>> Here is an excerpt from the previous attempt:
>>>
>>>   "Hi Russell, ARM SoC maintainers,
>>>
>>>   here's the full set of patches that remove arm_pm_restart as discussed
>>>   earlier. There's some background on the series in this thread:
>>>
>>> 	https://lore.kernel.org/linux-arm-kernel/20170130110512.6943-1-thierry.reding@gmail.com/
>>>
>>>   I also have a set of patches that build on top of this and try to add
>>>   something slightly more formal by adding a power/reset framework that
>>>   driver can register with. If we can get this series merged, I'll find
>>>   some time to refresh those patches and send out for review again.
>>
>> What happened to this patch series? Is there any chance we will get it
>> included at some point? It is included in the Android13-5.10 tree AFAICT
>>
> 
> It's in mainline since v5.14, AFAICS.
> 

Yes, indeed.

Guenter


From xen-devel-bounces@lists.xenproject.org Tue Oct 26 01:34:07 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Oct 2021 01:34:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.216139.375624 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfBLi-0007tu-E4; Tue, 26 Oct 2021 01:33:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 216139.375624; Tue, 26 Oct 2021 01:33:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfBLi-0007tn-Ae; Tue, 26 Oct 2021 01:33:58 +0000
Received: by outflank-mailman (input) for mailman id 216139;
 Tue, 26 Oct 2021 01:33:56 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=7zbS=PO=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1mfBLg-0007th-Mk
 for xen-devel@lists.xenproject.org; Tue, 26 Oct 2021 01:33:56 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id c845f46e-35fc-11ec-8420-12813bfff9fa;
 Tue, 26 Oct 2021 01:33:55 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id 608416103C;
 Tue, 26 Oct 2021 01:33:54 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c845f46e-35fc-11ec-8420-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1635212034;
	bh=3VfJPdoKXuUDd/jg96xCLhfqd8anajSYo53uu9mkuco=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=JwZcIYso3ZbZIjcBnkKAmzLR/756iC2KPbdEvXP/rFjiJRtVp5CQ1F/5+E8joNmlf
	 rGxXRbX30PtLGpZfslqbTaPrIfMo5qprmbevNP6DruyUQQam6FJK+0K9ttZlJFlKhe
	 e4e9TXhcJ5jEsj5s3Sw0apkjrHaNVGPIPwEiEfPu1ejNIsCJ0yQ9VFeXLGjxGsUFkd
	 GYW14GsxIhMnvVtZQ5K0kEl+Pkjb+S44wvPaie3+ins60cHiNnQha9CuHGO4XRuvT6
	 rPzRbC2/ERLW6DpLSbm+Ij23f1mYzzOkYpClt0XV04LX/aWG01nWbWDmgX0+xeqRQI
	 Xjcn40Ifwsj7w==
Date: Mon, 25 Oct 2021 18:33:53 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Anthony PERARD <anthony.perard@citrix.com>
cc: Stefano Stabellini <sstabellini@kernel.org>, 
    xen-devel@lists.xenproject.org, iwj@xenproject.org, cardoe@cardoe.com, 
    wl@xen.org, andrew.cooper3@citrix.com, 
    Stefano Stabellini <stefano.stabellini@xilinx.com>
Subject: Re: [PATCH 3/3] automation: add a QEMU based x86_64 Dom0/DomU test
In-Reply-To: <YXbXwjxHPNjSAKrG@perard>
Message-ID: <alpine.DEB.2.21.2110251754210.4586@sstabellini-ThinkPad-T480s>
References: <alpine.DEB.2.21.2110210831470.2311@sstabellini-ThinkPad-T480s> <20211021230839.10794-3-sstabellini@kernel.org> <YXK2lTWZHiTXIBtJ@perard> <alpine.DEB.2.21.2110221219520.2311@sstabellini-ThinkPad-T480s> <YXbXwjxHPNjSAKrG@perard>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Mon, 25 Oct 2021, Anthony PERARD wrote:
> On Fri, Oct 22, 2021 at 01:05:35PM -0700, Stefano Stabellini wrote:
> > On Fri, 22 Oct 2021, Anthony PERARD wrote:
> > > On Thu, Oct 21, 2021 at 04:08:39PM -0700, Stefano Stabellini wrote:
> > > > diff --git a/automation/scripts/qemu-alpine-x86_64.sh b/automation/scripts/qemu-alpine-x86_64.sh
> > > > new file mode 100644
> > > > index 0000000000..41b05210d6
> > > > --- /dev/null
> > > > +++ b/automation/scripts/qemu-alpine-x86_64.sh
> > > > @@ -0,0 +1,92 @@
> > > > +#!/bin/bash
> > > > +
> > > > +set -ex
> > > > +
> > > > +apt-get -qy update
> > > > +apt-get -qy install --no-install-recommends qemu-system-x86 \
> > > > +                                            cpio \
> > > > +                                            curl \
> > > > +                                            busybox-static
> > > 
> > > Please, don't install packages during the CI job. If you need new
> > > packages, update the container.
> > 
> > The container used to run this script is the one used for the Xen build:
> > automation/build/debian/unstable.dockerfile, AKA
> > registry.gitlab.com/xen-project/xen/debian:unstable. We don't have a
> > specific container for the sole purpose of running tests.
> 
> I've added qemu to our debian:stretch container recently, in order to
> run the "qemu-smoke-*" tests without running apt commands. Unless more
> recent software are needed, you could base the "qemu-alpine-x86*" test
> on debian:stretch which might only then missing cpio and busybox. Update
> of the stretch container should go smoothly as it has been done
> recently.

I am happy to use debian:stretch in this patch series. I'll make the
change. That only leaves cpio and busybox-static to apt-get which are
small. In general, I am not too happy about increasing the size of build
containers with testing binaries so I would rather not increase it any
further, see below.


> > Thus, I could add qemu-system-x86 to
> > automation/build/debian/unstable.dockerfile, but then we increase the
> > size of the debian unstable build container needlessly for all related
> > build jobs.
> 
> There is something I'm missing, how is it a problem to have a container
> that is a bit bigger? What sort of problem could we have to deal with?

It takes time to clone the container in the gitlab-ci, the bigger the
container the more time it takes. It is fetched over the network. Now we
are fetching qemu (as part of the container) 10 times during the build
although it is not needed.

There is a compromise to be made. Let's say the QEMU package is 100MB.
If we add QEMU to debian:stretch we are going to increase the overall
data usage by about 1GB, which means we are waiting to fetch 1GB of
additional data during the pipeline.

If we needed QEMU only once, then we could just apt-get it and we would
only fetch 100MB once. Although using apt-get will be a bit slower
because the deb needs to be unpacked, etc. I think that if we used QEMU
only in one test then it would be faster to apt-get it.

However in our case we are using QEMU 4 times during the tests, so
adding QEMU to debian:stretch probably made things a bit faster or at
least not slower.

Does it make sense?

This is why we should have specialized containers for the tests instead
of adding test packages to the build containers. However, today all
containers are updated manually so it would be best to make containers
automatically updatable first.  Until then I think it is OK to apt-get
stuff.


> On the other hand, doing more task, installing software, downloading
> anything from the internet, makes the job much less reliable. It
> increase the risk of a failure do to external factors and it takes more
> time to run the test.

That is fair but it is more a theoretical problem than a real issue at
the moment. In reality I haven't seen Debian's apt-get failing even a
single time in our gitlab-ci (it failed because our debian:unstable
container went out of date but that's our fault).

But we do have a severe problem at the moment with external sources: our
"git clones" keep failing during the build on x86. That is definitely
something worth improving (see my other email thread on the subject) and
it is the main problem affecting gitlab-ci at the moment, I keep having
to restart jobs almost daily to get the overall pipeline to "pass".

If you have any ideas on how to stop fetching things using "git" from
external repositories in gitlab-ci that would be fantastic :-)
The only thing I could think of to "fix it" is moving all external repos
to gitlab repositories mirrors.


> > Or we could add one more special container just for running tests, but
> > then it is one more container to maintain and keep up-to-date.
> > 
> > This is why I chose as a compromise to keep the underlying container as
> > is, and just apt-get the extra 3-4 packages here. It is the same thing
> > we do on ARM: automation/scripts/qemu-alpine-arm64.sh. Also keep in mind
> > that this job is run in the "test" step where we have far fewer jobs at
> > the moment and the runners are not busy. (It would be different in the
> > "build" step where we have many jobs.)
> 
> I don't really see any difference between a "test" job and a "build"
> jobs, both kind use the same resource/runner.
> 
> On that note, they're is something I've learned recently: "test" job
> don't even have to wait for all "build" job to complete, they can run in
> parallel. We would just need to replace "dependencies" by "needs":
>     https://docs.gitlab.com/ee/ci/yaml/index.html#needs
> But that could be an improvement for an other time and only a side note
> for the patch.

That is really cool! I didn't know about it. Yes, currently there is a
big distinction between build and test jobs because build jobs are the
bottleneck and test jobs don't start before all the build jobs finish.


> > I am not entirely sure what is the best solution overall, but for this
> > series at this stage I would prefer to keep the same strategy used for
> > the ARM tests (i.e. reuse the debian unstable build container and
> > apt-get the few missing packages.) If we do change the way we do it, I
> > would rather change both x86 and ARM at the same time.
> 
> I'm pretty sure the best strategy would be to do as little as possible
> during a job, download as little as possible and possibly cache as much
> as possible and do as much as possible ahead of time. Feel free to
> change the Arm test, but I don't think it is necessary to change the Arm
> test at the same time as introducing an x86 test.

I agree.

At the same time it would be nice to follow the same strategy between
x86 and ARM going forward: if one optimization is made for one, it is
also made for the other.


From xen-devel-bounces@lists.xenproject.org Tue Oct 26 01:37:26 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Oct 2021 01:37:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.216146.375635 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfBP2-0000A5-UZ; Tue, 26 Oct 2021 01:37:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 216146.375635; Tue, 26 Oct 2021 01:37:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfBP2-00009s-QO; Tue, 26 Oct 2021 01:37:24 +0000
Received: by outflank-mailman (input) for mailman id 216146;
 Tue, 26 Oct 2021 01:37:22 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=7zbS=PO=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1mfBP0-00009k-Pi
 for xen-devel@lists.xenproject.org; Tue, 26 Oct 2021 01:37:22 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 4360f0c3-35fd-11ec-8420-12813bfff9fa;
 Tue, 26 Oct 2021 01:37:21 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id 093FA60EBC;
 Tue, 26 Oct 2021 01:37:20 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4360f0c3-35fd-11ec-8420-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1635212241;
	bh=wqAGzrvlFE6wtuBFH9ll5fseQhx/ylvsfjmPPJUxAQc=;
	h=Date:From:To:cc:Subject:From;
	b=gktLmHmnVfYHSmlPbak7OouVwr9UpcENPgC2OEPH3Mp1b3A0wkJo84/hhlyLdVMh8
	 AgS/FACJToSsPES3hgcbpzzyqLKgX1DKh/nHA2bMQKxDVN5KEdJ5+/Lzo2ly9FK/9p
	 c6GkLSyzQU1ADIF+ecwuOxD/Kp/F8mPSl/BBEjgv444Hhs6Dwoh84j8SzeDJcxn8ek
	 Kl7tE4fnTZRgsQmvIXInuw1ZLN17Z+99jUtDeTLwhUtleKNmU9zPw03mBjO7TzA9Am
	 XpVjb6s1NnAtlIQIkdLkdNolIFyYKGBG+YljKh3P742izdyHvyh53VFLf6+EMFw3BS
	 f977Bybf6kftw==
Date: Mon, 25 Oct 2021 18:37:20 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: xen-devel@lists.xenproject.org
cc: sstabellini@kernel.org, iwj@xenproject.org, cardoe@cardoe.com, wl@xen.org, 
    andrew.cooper3@citrix.com, anthony.perard@citrix.com
Subject: [PATCH v2 0/3] automation: introduce an x86_64 Dom0/DomU test
Message-ID: <alpine.DEB.2.21.2110251836020.4586@sstabellini-ThinkPad-T480s>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

Hi all,

This small patch series introduces a new QEMU-based test to Gitlab-CI.
It uses QEMU to emulate an x86_64 machine and run Xen, Dom0 and start a
DomU. It is very similar to the existing qemu-alpine-arm64-gcc test but
based on x86_64 rather than ARM64. I think it is important because all
the other x86_64 gitlab-ci tests we currently have are more narrow and
based on XTF. This would be the first end-to-end x86_64 test in
gitlab-ci.

To make it happen, we need an Alpine Linux rootfs and a Linux kernel.
The first two patches introduce them to gitlab-ci. Note that actually
nothing will get build during gitlab-ci runs, it has already been done
beforehand and uploaded as containers. They only import *existing*
containers and binaries into a gitlab-ci run, thus, they cannot fail.
The risk to the release of the first two patches is as close to zero as
possible.

The last patch is the one introducing a new test. This one can fail.
However, it is a new test at the end of the pipeline: it doesn't impact
the existing tests. In the worst case, the test will fail and the whole
pipeline will be marked as "failed" but looking at the jobs all the
other will continue to be marked as successful. In short, if it fails,
we can simply ignore it. Also, at the moment it is actually succeeding.

Cheers,

Stefano


Stefano Stabellini (3):
      automation: add x86_64 alpine 3.12 test-artifact
      automation: Linux 5.10.74 test-artifact
      automation: add a QEMU based x86_64 Dom0/DomU test

 automation/gitlab-ci/build.yaml                    | 24 ++++++
 automation/gitlab-ci/test.yaml                     | 24 ++++++
 automation/scripts/qemu-alpine-x86_64.sh           | 95 ++++++++++++++++++++++
 automation/tests-artifacts/alpine/3.12.dockerfile  | 66 +++++++++++++++
 .../tests-artifacts/kernel/5.10.74.dockerfile      | 38 +++++++++
 5 files changed, 247 insertions(+)
 create mode 100755 automation/scripts/qemu-alpine-x86_64.sh
 create mode 100644 automation/tests-artifacts/alpine/3.12.dockerfile
 create mode 100644 automation/tests-artifacts/kernel/5.10.74.dockerfile


From xen-devel-bounces@lists.xenproject.org Tue Oct 26 01:42:09 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Oct 2021 01:42:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.216154.375656 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfBTb-0001qC-OV; Tue, 26 Oct 2021 01:42:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 216154.375656; Tue, 26 Oct 2021 01:42:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfBTb-0001q5-Ky; Tue, 26 Oct 2021 01:42:07 +0000
Received: by outflank-mailman (input) for mailman id 216154;
 Tue, 26 Oct 2021 01:42:06 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=7zbS=PO=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1mfBTa-0001bn-NF
 for xen-devel@lists.xenproject.org; Tue, 26 Oct 2021 01:42:06 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id ec74f456-35fd-11ec-8420-12813bfff9fa;
 Tue, 26 Oct 2021 01:42:05 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id A5DAB6023B;
 Tue, 26 Oct 2021 01:42:04 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ec74f456-35fd-11ec-8420-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1635212524;
	bh=Kx4e9+ekLwMR2Kc2Ru1z1j3d1ZvwiDUM6uDgREU3a9c=;
	h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
	b=tQO9I9XDiDnGpNsBda+yTd3vkdLZqNPvfNnSgwqna36qaZ+f+LKg4DQLLFanKyrcD
	 ssd0OHY8ffpNKINQxU9ygLzkLjF0xFIqsmzGoUwdT2jT32wFjegqkA0ebUthPRadXt
	 hISZSZQDCN40xfQicVvw5GxhN5JTalmX/igyqS8gqU6faU5Rp/r2Ie/6L3JlsEmwV9
	 vZozALXNktdKttsKTFwq8MRLF+y3/KN7tZwdpT/ANyAOFeXKte+1ZX+0fQOGCFChtx
	 G6tEvYMA5NuxeCb/p7VI/wznILWRaDzl85nKpa01h4FbEIY00aBRJWMeyWIrWnWIsz
	 zH/n/zaD1su0g==
From: Stefano Stabellini <sstabellini@kernel.org>
To: xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org,
	iwj@xenproject.org,
	cardoe@cardoe.com,
	wl@xen.org,
	andrew.cooper3@citrix.com,
	anthony.perard@citrix.com,
	Stefano Stabellini <stefano.stabellini@xilinx.com>
Subject: [PATCH v2 3/3] automation: add a QEMU based x86_64 Dom0/DomU test
Date: Mon, 25 Oct 2021 18:42:00 -0700
Message-Id: <20211026014200.32102-3-sstabellini@kernel.org>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <alpine.DEB.2.21.2110251836020.4586@sstabellini-ThinkPad-T480s>
References: <alpine.DEB.2.21.2110251836020.4586@sstabellini-ThinkPad-T480s>

From: Stefano Stabellini <stefano.stabellini@xilinx.com>

Introduce a test based on QEMU to run Xen, Dom0 and start a DomU.
This is similar to the existing qemu-alpine-arm64.sh script and test.
The only differences are:
- use Debian's qemu-system-x86_64 (on ARM we build our own)
- use ipxe instead of u-boot and ImageBuilder

Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>
---
apt-get is not entirely removed yet as we need cpio and busybox-static.
I am in favor of keeping them as apt-get packages because they are not
needed in the build container. At the same time I see that being small
they wouldn't increase the build container by much.

Changes in v2:
- remove curl
- add comments
- add set -x
- use debian:stretch and remove qemu
---
 automation/gitlab-ci/test.yaml           | 24 ++++++
 automation/scripts/qemu-alpine-x86_64.sh | 95 ++++++++++++++++++++++++
 2 files changed, 119 insertions(+)
 create mode 100755 automation/scripts/qemu-alpine-x86_64.sh

diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.yaml
index 91a10febbf..43d248a604 100644
--- a/automation/gitlab-ci/test.yaml
+++ b/automation/gitlab-ci/test.yaml
@@ -47,6 +47,30 @@ qemu-alpine-arm64-gcc:
     - /^coverity-tested\/.*/
     - /^stable-.*/
 
+qemu-alpine-x86_64-gcc:
+  stage: test
+  image: registry.gitlab.com/xen-project/xen/${CONTAINER}
+  variables:
+    CONTAINER: debian:stretch
+  script:
+    - ./automation/scripts/qemu-alpine-x86_64.sh 2>&1 | tee qemu-smoke-arm64.log
+  dependencies:
+    - alpine-3.12-gcc
+    - alpine-3.12-rootfs-export
+    - kernel-5.10.74-export
+  artifacts:
+    paths:
+      - smoke.serial
+      - '*.log'
+    when: always
+  tags:
+    - x86_64
+  except:
+    - master
+    - smoke
+    - /^coverity-tested\/.*/
+    - /^stable-.*/
+
 qemu-smoke-arm64-gcc:
   stage: test
   image: registry.gitlab.com/xen-project/xen/${CONTAINER}
diff --git a/automation/scripts/qemu-alpine-x86_64.sh b/automation/scripts/qemu-alpine-x86_64.sh
new file mode 100755
index 0000000000..2e9625109c
--- /dev/null
+++ b/automation/scripts/qemu-alpine-x86_64.sh
@@ -0,0 +1,95 @@
+#!/bin/bash
+
+set -ex
+
+apt-get -qy update
+apt-get -qy install --no-install-recommends cpio \
+                                            busybox-static
+
+# DomU Busybox
+cd binaries
+mkdir -p initrd
+mkdir -p initrd/bin
+mkdir -p initrd/sbin
+mkdir -p initrd/etc
+mkdir -p initrd/dev
+mkdir -p initrd/proc
+mkdir -p initrd/sys
+mkdir -p initrd/lib
+mkdir -p initrd/var
+mkdir -p initrd/mnt
+cp /bin/busybox initrd/bin/busybox
+initrd/bin/busybox --install initrd/bin
+echo "#!/bin/sh
+
+mount -t proc proc /proc
+mount -t sysfs sysfs /sys
+mount -t devtmpfs devtmpfs /dev
+/bin/sh" > initrd/init
+chmod +x initrd/init
+# DomU rootfs
+cd initrd
+find . | cpio --create --format='newc' | gzip > ../initrd.cpio.gz
+cd ..
+
+# initrd.tar.gz is Dom0 rootfs
+mkdir -p rootfs
+cd rootfs
+tar xvzf ../initrd.tar.gz
+mkdir proc
+mkdir run
+mkdir srv
+mkdir sys
+rm var/run
+cp -ar ../dist/install/* .
+mv ../initrd.cpio.gz ./root
+cp ../bzImage ./root
+echo "name=\"test\"
+memory=512
+vcpus=1
+kernel=\"/root/bzImage\"
+ramdisk=\"/root/initrd.cpio.gz\"
+extra=\"console=hvc0 root=/dev/ram0 rdinit=/bin/sh\"
+" > root/test.cfg
+echo "#!/bin/bash
+
+set -x
+
+export LD_LIBRARY_PATH=/usr/local/lib
+bash /etc/init.d/xencommons start
+
+xl list
+
+xl create -c /root/test.cfg
+
+" > etc/local.d/xen.start
+chmod +x etc/local.d/xen.start
+echo "rc_verbose=yes" >> etc/rc.conf
+# rebuild Dom0 rootfs
+find . |cpio -H newc -o|gzip > ../xen-rootfs.cpio.gz
+cd ../..
+
+cat >> binaries/pxelinux.0 << EOF
+#!ipxe
+
+kernel xen console=com1
+module bzImage console=hvc0
+module xen-rootfs.cpio.gz
+boot
+EOF
+
+# Run the test
+rm -f smoke.serial
+set +e
+timeout -k 1 720 \
+qemu-system-x86_64 \
+    -cpu qemu64,+svm \
+    -m 2G -smp 2 \
+    -monitor none -serial stdio \
+    -nographic \
+    -device virtio-net-pci,netdev=n0 \
+    -netdev user,id=n0,tftp=binaries,bootfile=/pxelinux.0 |& tee smoke.serial
+
+set -e
+(grep -q "Domain-0" smoke.serial && grep -q "BusyBox" smoke.serial) || exit 1
+exit 0
-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Tue Oct 26 01:42:09 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Oct 2021 01:42:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.216153.375646 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfBTa-0001aC-GL; Tue, 26 Oct 2021 01:42:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 216153.375646; Tue, 26 Oct 2021 01:42:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfBTa-0001a5-Ct; Tue, 26 Oct 2021 01:42:06 +0000
Received: by outflank-mailman (input) for mailman id 216153;
 Tue, 26 Oct 2021 01:42:05 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=7zbS=PO=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1mfBTZ-0001Zx-Pf
 for xen-devel@lists.xenproject.org; Tue, 26 Oct 2021 01:42:05 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id cad276e7-ccbb-4459-9680-8141b1dc6f86;
 Tue, 26 Oct 2021 01:42:04 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id CBA6961057;
 Tue, 26 Oct 2021 01:42:03 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: cad276e7-ccbb-4459-9680-8141b1dc6f86
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1635212524;
	bh=RUYwi15asB7wOfxAWOMyV7/IDOyTDsG6KU/TPjlIGvg=;
	h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
	b=s8XUPMicLG5r3scOqPlya7YGhzh58wM9xME60beOxQuz5u8dzv0C/z2OQjJV/Y/f0
	 S5StysfqBTPbylRz4V2XWGYIGzWSl20D+4mBDSjupR4Qk/qMKZrpTY3A0v80LgjgDu
	 6KRSjQnWJEfv8nfDW1JmlCTurEVNuSlxtlL/yTLJMfZGc8cIVeymP+A2l92DFA4dDz
	 +kx0YrYMldXsQV+M5VXU57rt/Mx7emBxySVPzppaGHLKhQpRLQ+SOtbkkCwl93845M
	 O1bJFZvuQue6nJq5D7xCP/ELuipXpKJLwfWqM02FUh8UU6irFTIjiz2gA0PF5mmHE5
	 tdjL6wa8kf/dw==
From: Stefano Stabellini <sstabellini@kernel.org>
To: xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org,
	iwj@xenproject.org,
	cardoe@cardoe.com,
	wl@xen.org,
	andrew.cooper3@citrix.com,
	anthony.perard@citrix.com,
	Stefano Stabellini <stefano.stabellini@xilinx.com>
Subject: [PATCH v2 1/3] automation: add x86_64 alpine 3.12 test-artifact
Date: Mon, 25 Oct 2021 18:41:58 -0700
Message-Id: <20211026014200.32102-1-sstabellini@kernel.org>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <alpine.DEB.2.21.2110251836020.4586@sstabellini-ThinkPad-T480s>
References: <alpine.DEB.2.21.2110251836020.4586@sstabellini-ThinkPad-T480s>

From: Stefano Stabellini <stefano.stabellini@xilinx.com>

It is the same as the existing ARM64 alpine 3.12 test-artifact. It is
used to export an Alpine rootfs for Dom0 used for testing.

Also add the exporting job to build.yaml so that the binaries can be
used during gitlab-ci runs.

Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>
Reviewed-by: Anthony PERARD <anthony.perard@citrix.com>
---
Changes in 2:
- remove gettext
---
 automation/gitlab-ci/build.yaml               | 13 ++++
 .../tests-artifacts/alpine/3.12.dockerfile    | 66 +++++++++++++++++++
 2 files changed, 79 insertions(+)
 create mode 100644 automation/tests-artifacts/alpine/3.12.dockerfile

diff --git a/automation/gitlab-ci/build.yaml b/automation/gitlab-ci/build.yaml
index d177da1710..76b73beead 100644
--- a/automation/gitlab-ci/build.yaml
+++ b/automation/gitlab-ci/build.yaml
@@ -596,3 +596,16 @@ qemu-system-aarch64-5.2.0-arm64-export:
   tags:
     - arm64
 
+
+# x86_64 test artifacts
+
+alpine-3.12-rootfs-export:
+  stage: build
+  image: registry.gitlab.com/xen-project/xen/tests-artifacts/alpine:3.12
+  script:
+    - mkdir binaries && cp /initrd.tar.gz binaries/initrd.tar.gz
+  artifacts:
+    paths:
+      - binaries/initrd.tar.gz
+  tags:
+    - x86_64
diff --git a/automation/tests-artifacts/alpine/3.12.dockerfile b/automation/tests-artifacts/alpine/3.12.dockerfile
new file mode 100644
index 0000000000..b3909996b4
--- /dev/null
+++ b/automation/tests-artifacts/alpine/3.12.dockerfile
@@ -0,0 +1,66 @@
+FROM alpine:3.12
+LABEL maintainer.name="The Xen Project" \
+      maintainer.email="xen-devel@lists.xenproject.org"
+
+ENV USER root
+
+RUN mkdir /build
+WORKDIR /build
+
+RUN \
+  # apk
+  apk update && \
+  \
+  # xen runtime deps
+  apk add musl && \
+  apk add openrc && \
+  apk add busybox && \
+  apk add sudo && \
+  apk add dbus && \
+  apk add bash && \
+  apk add python2 && \
+  apk add zlib && \
+  apk add ncurses && \
+  apk add texinfo && \
+  apk add yajl && \
+  apk add libaio && \
+  apk add xz-dev && \
+  apk add util-linux && \
+  apk add argp-standalone && \
+  apk add libfdt && \
+  apk add glib && \
+  apk add pixman && \
+  apk add curl && \
+  apk add udev && \
+  \
+  # Xen
+  cd / && \
+  # Minimal ramdisk environment in case of cpio output
+  rc-update add udev && \
+  rc-update add udev-trigger && \
+  rc-update add udev-settle && \
+  rc-update add networking sysinit && \
+  rc-update add loopback sysinit && \
+  rc-update add bootmisc boot && \
+  rc-update add devfs sysinit && \
+  rc-update add dmesg sysinit && \
+  rc-update add hostname boot && \
+  rc-update add hwclock boot && \
+  rc-update add hwdrivers sysinit && \
+  rc-update add killprocs shutdown && \
+  rc-update add modloop sysinit && \
+  rc-update add modules boot && \
+  rc-update add mount-ro shutdown && \
+  rc-update add savecache shutdown && \
+  rc-update add sysctl boot && \
+  rc-update add local default && \
+  cp -a /sbin/init /init && \
+  echo "ttyS0" >> /etc/securetty && \
+  echo "hvc0" >> /etc/securetty && \
+  echo "ttyS0::respawn:/sbin/getty -L ttyS0 115200 vt100" >> /etc/inittab && \
+  echo "hvc0::respawn:/sbin/getty -L hvc0 115200 vt100" >> /etc/inittab && \
+  passwd -d "root" root && \
+  \
+  # Create rootfs
+  cd / && \
+  tar cvzf /initrd.tar.gz bin dev etc home init lib mnt opt root sbin usr var
-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Tue Oct 26 01:42:12 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Oct 2021 01:42:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.216155.375668 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfBTg-0002A0-1Q; Tue, 26 Oct 2021 01:42:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 216155.375668; Tue, 26 Oct 2021 01:42:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfBTf-00029o-Tq; Tue, 26 Oct 2021 01:42:11 +0000
Received: by outflank-mailman (input) for mailman id 216155;
 Tue, 26 Oct 2021 01:42:10 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=7zbS=PO=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1mfBTe-0001Zx-Lq
 for xen-devel@lists.xenproject.org; Tue, 26 Oct 2021 01:42:10 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id c2a19dd3-c513-4b1b-80f8-6e8668b534a1;
 Tue, 26 Oct 2021 01:42:05 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id 4328160041;
 Tue, 26 Oct 2021 01:42:04 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c2a19dd3-c513-4b1b-80f8-6e8668b534a1
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1635212524;
	bh=mvnhBoB/kIkG732gUvVDI6GT3xtvGIUsrPyx8vSP5Qo=;
	h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
	b=D2hpE7ysQr7wrinGPFTuUj3vDE5AR5QMOmm/XRUx+0dmnDvWl2kpGqnWc+neNQIhg
	 NDWqqD4cqh51EeCe7I+rXCPzbC2Iz8QfM7NjGjgzI6Aa9kIOumc8r5iZKWSy1e2M1Q
	 T+UOHPADg24UOK5C7qAYepm9yunDVBv4E+4Ks6bOeRx2gaKUxb1vOohS0d1XUejnTb
	 yPKxj/cZtF7FJ80UBKPTEjyuEhRjK2Zuresu2Q+shkz5zt9aOhJkAwIXijHK53H00x
	 bklZ4lqZ2RyzNX+QuqBmkLO3dFGruQHjMsZQlcvbZ9JYl22vgZlMjHjS+Xh8iuvuS6
	 xg9n9z3PWrQVg==
From: Stefano Stabellini <sstabellini@kernel.org>
To: xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org,
	iwj@xenproject.org,
	cardoe@cardoe.com,
	wl@xen.org,
	andrew.cooper3@citrix.com,
	anthony.perard@citrix.com,
	Stefano Stabellini <stefano.stabellini@xilinx.com>
Subject: [PATCH v2 2/3] automation: Linux 5.10.74 test-artifact
Date: Mon, 25 Oct 2021 18:41:59 -0700
Message-Id: <20211026014200.32102-2-sstabellini@kernel.org>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <alpine.DEB.2.21.2110251836020.4586@sstabellini-ThinkPad-T480s>
References: <alpine.DEB.2.21.2110251836020.4586@sstabellini-ThinkPad-T480s>

From: Stefano Stabellini <stefano.stabellini@xilinx.com>

Build a 5.10 kernel to be used as Dom0 and DomU kernel for testing. This
is almost the same as the existing ARM64 recipe for Linux 5.9, the
only differences are:
- upgrade to latest 5.10.x stable
- force Xen modules to built-in (on ARM it was already done by defconfig)

Also add the exporting job to build.yaml so that the binary can be used
during gitlab-ci runs.

Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>
Reviewed-by: Anthony PERARD <anthony.perard@citrix.com>
---

Note that make tinyconfig cannot be used because it doesn't boot on QEMU

Changes in 2:
- use two RUNs
- remove apt-get cleanup earlier
---
 automation/gitlab-ci/build.yaml               | 11 ++++++
 .../tests-artifacts/kernel/5.10.74.dockerfile | 38 +++++++++++++++++++
 2 files changed, 49 insertions(+)
 create mode 100644 automation/tests-artifacts/kernel/5.10.74.dockerfile

diff --git a/automation/gitlab-ci/build.yaml b/automation/gitlab-ci/build.yaml
index 76b73beead..0034c50950 100644
--- a/automation/gitlab-ci/build.yaml
+++ b/automation/gitlab-ci/build.yaml
@@ -609,3 +609,14 @@ alpine-3.12-rootfs-export:
       - binaries/initrd.tar.gz
   tags:
     - x86_64
+
+kernel-5.10.74-export:
+  stage: build
+  image: registry.gitlab.com/xen-project/xen/tests-artifacts/kernel:5.10.74
+  script:
+    - mkdir binaries && cp /bzImage binaries/bzImage
+  artifacts:
+    paths:
+      - binaries/bzImage
+  tags:
+    - x86_64
diff --git a/automation/tests-artifacts/kernel/5.10.74.dockerfile b/automation/tests-artifacts/kernel/5.10.74.dockerfile
new file mode 100644
index 0000000000..112e27fe45
--- /dev/null
+++ b/automation/tests-artifacts/kernel/5.10.74.dockerfile
@@ -0,0 +1,38 @@
+FROM debian:unstable
+LABEL maintainer.name="The Xen Project" \
+      maintainer.email="xen-devel@lists.xenproject.org"
+
+ENV DEBIAN_FRONTEND=noninteractive
+ENV LINUX_VERSION=5.10.74
+ENV USER root
+
+RUN mkdir /build
+WORKDIR /build
+
+# build depends
+RUN apt-get update && \
+    apt-get --quiet --yes install \
+        build-essential \
+        libssl-dev \
+        bc \
+        curl \
+        flex \
+        bison \
+        libelf-dev \
+        && \
+    apt-get autoremove -y && \
+    apt-get clean && \
+    rm -rf /var/lib/apt/lists* /tmp/* /var/tmp/*
+
+# Build the kernel
+RUN curl -fsSLO https://cdn.kernel.org/pub/linux/kernel/v5.x/linux-"$LINUX_VERSION".tar.xz && \
+    tar xvJf linux-"$LINUX_VERSION".tar.xz && \
+    cd linux-"$LINUX_VERSION" && \
+    make defconfig && \
+    make xen.config && \
+    cp .config .config.orig && \
+    cat .config.orig | grep XEN | grep =m |sed 's/=m/=y/g' >> .config && \
+    make -j$(nproc) bzImage && \
+    cp arch/x86/boot/bzImage / && \
+    cd /build && \
+    rm -rf linux-"$LINUX_VERSION"*
-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Tue Oct 26 01:44:32 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Oct 2021 01:44:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.216175.375679 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfBVv-0003TK-L9; Tue, 26 Oct 2021 01:44:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 216175.375679; Tue, 26 Oct 2021 01:44:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfBVv-0003TD-GJ; Tue, 26 Oct 2021 01:44:31 +0000
Received: by outflank-mailman (input) for mailman id 216175;
 Tue, 26 Oct 2021 01:44:29 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=7zbS=PO=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1mfBVt-0003T4-GJ
 for xen-devel@lists.xenproject.org; Tue, 26 Oct 2021 01:44:29 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id d60bf211-62bd-4547-a546-6243461d811e;
 Tue, 26 Oct 2021 01:44:28 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id 0A465603E9;
 Tue, 26 Oct 2021 01:44:27 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d60bf211-62bd-4547-a546-6243461d811e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1635212668;
	bh=CShzKTB1BZiKI2Om9hU3LIJRgXqrUWH/IlmgUhPuA48=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=DfahKs6V8FtdjygH5Xr2JI2iGZE7utNdgm3SCuO614sTbE0os9Fv9vv9sIHsPoDy3
	 W87AYnQHT2bJrj3hVEceKXpHlPUb519z4mS8VPvPihrknVsYeCYAXO10aX+srxVqCx
	 si0Pw0XVofL1f7E6vbgTnPZwOIjDq++xvXchfZRsV8Sv7aq92Z0/QYEPaOA4V7NU5a
	 w4lgtKn/a3mP7sJuX8SJi/05vtJk43iJlBFWcpEDbaoosVbGVLFtFNmLN5+6HkR5RI
	 Kp4tOzM1bqQ/03IdE6ERhNRJHeIQoCTRj6xNGvEwr+e/mUvGzQiz0804S7j3WZBYqi
	 sn1sHru6aiVLA==
Date: Mon, 25 Oct 2021 18:44:27 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= <roger.pau@citrix.com>
cc: Stefano Stabellini <sstabellini@kernel.org>, George.Dunlap@citrix.com, 
    dunlapg@umich.edu, jbeulich@suse.com, committers@xenproject.org, 
    xen-devel@lists.xenproject.org
Subject: Re: [PATCH] governance: communication channels
In-Reply-To: <YXaIKZD8g6kQukhF@MacBook-Air-de-Roger.local>
Message-ID: <alpine.DEB.2.21.2110251843370.4586@sstabellini-ThinkPad-T480s>
References: <alpine.DEB.2.21.2110221535000.2311@sstabellini-ThinkPad-T480s> <YXaIKZD8g6kQukhF@MacBook-Air-de-Roger.local>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: multipart/mixed; BOUNDARY="8323329-2068739625-1635212623=:4586"
Content-ID: <alpine.DEB.2.21.2110251844230.4586@sstabellini-ThinkPad-T480s>

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-2068739625-1635212623=:4586
Content-Type: text/plain; CHARSET=UTF-8
Content-Transfer-Encoding: 8BIT
Content-ID: <alpine.DEB.2.21.2110251844231.4586@sstabellini-ThinkPad-T480s>

On Mon, 25 Oct 2021, Roger Pau Monné wrote:
> On Fri, Oct 22, 2021 at 03:59:51PM -0700, Stefano Stabellini wrote:
> > Clarify that xen-devel is the only official communication channel.
> > 
> > Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>
> > 
> > diff --git a/source/communication-practice.rst b/source/communication-practice.rst
> > index 70f5b8c..356df7a 100644
> > --- a/source/communication-practice.rst
> > +++ b/source/communication-practice.rst
> > @@ -9,6 +9,22 @@ This guide provides communication Best Practice that helps you in
> >  * Being aware of your own and counterpart’s communication style and culture
> >  * Show empathy towards other community members
> >  
> > +Communication Channels
> > +======================
> > +
> > +All important communications and messages should be sent to the
> > +`xen-devel <10_>`_ mailing list, which is the only official channel for
> > +code submissions, acks, code reviews, and decision-making.
> > +
> > +In the modern connected world there are several other communication
> > +channels available at any given time, including online meetings and IRC.
> > +Xen Project has an IRC channel named #xendevel on the OFTC network where
> 
> I would avoid mentioning #xendevel and OFTC explicitly. We had to move
> networks recently and it's easy to miss this instance and thus become
> stale.
> 
> The rest LGTM.

Makes sense.
--8323329-2068739625-1635212623=:4586--


From xen-devel-bounces@lists.xenproject.org Tue Oct 26 01:46:49 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Oct 2021 01:46:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.216181.375689 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfBY8-00046x-W8; Tue, 26 Oct 2021 01:46:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 216181.375689; Tue, 26 Oct 2021 01:46:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfBY8-00046q-TF; Tue, 26 Oct 2021 01:46:48 +0000
Received: by outflank-mailman (input) for mailman id 216181;
 Tue, 26 Oct 2021 01:46:47 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=7zbS=PO=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1mfBY7-00046k-MH
 for xen-devel@lists.xenproject.org; Tue, 26 Oct 2021 01:46:47 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id c7112447-d5dd-44cc-a0d7-9f995514aba3;
 Tue, 26 Oct 2021 01:46:46 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id 17BC0603E9;
 Tue, 26 Oct 2021 01:46:46 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c7112447-d5dd-44cc-a0d7-9f995514aba3
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1635212806;
	bh=czAYzlz5i5xgL4v0YUbKltbLhzIgGO9dgn5iEPm/gfs=;
	h=Date:From:To:cc:Subject:From;
	b=nrW6IHtVnVjwiNqGYjaLzqtlRRFiGskPIYs4tpCGDu9IZdauB0hhqe4nEDKawk+GJ
	 Syip8V0J1pfF9hDHPf+w8vAM3je7XMNTqoF1Qapb53XHTxwpSh8nO2+aZiJ4t6WRyf
	 DA3OPE0XAMJMgmGtRjJQid/8b873IdcHTUt3Y7uZ4bLoXuygWjEmivgiAaqbdbn/UE
	 X1rqe++03TrpWd3eYKyEr4sDE1ySgVXWvppJNYl7fUFhBRp9E+sg2QuJCPqCABloBt
	 xQh0ewQBuF7ZtaaIIX0YHyhJc3OK9RAtmQU7WzzQzj+6+RUqmeiWH0UL5KY1/Fv9l7
	 gvD984fvC80jg==
Date: Mon, 25 Oct 2021 18:46:45 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: George.Dunlap@citrix.com
cc: sstabellini@kernel.org, dunlapg@umich.edu, roger.pau@citrix.com, 
    jbeulich@suse.com, committers@xenproject.org, 
    xen-devel@lists.xenproject.org
Subject: [PATCH v2] governance: communication channels
Message-ID: <alpine.DEB.2.21.2110251845500.4586@sstabellini-ThinkPad-T480s>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="8323329-1104439357-1635212806=:4586"

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-1104439357-1635212806=:4586
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT

Clarify that xen-devel is the only official communication channel.

Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>

---
Changes in v2:
- remove mentions of #xendevel on OFTC

diff --git a/source/communication-practice.rst b/source/communication-practice.rst
index 70f5b8c..2ce2a4e 100644
--- a/source/communication-practice.rst
+++ b/source/communication-practice.rst
@@ -9,6 +9,20 @@ This guide provides communication Best Practice that helps you in
 * Being aware of your own and counterpart’s communication style and culture
 * Show empathy towards other community members
 
+Communication Channels
+======================
+
+All important communications and messages should be sent to the
+`xen-devel <10_>`_ mailing list, which is the only official channel for
+code submissions, acks, code reviews, and decision-making.
+
+In the modern connected world there are several other communication
+channels available at any given time, including online meetings and IRC.
+However, discussions on media other than the xen-devel mailing list
+should be summarized and sent to xen-devel to reach a wider audience,
+for record-keeping, and to make code submissions, acks, and code reviews
+official.
+
 Code reviews for **reviewers** and **patch authors**
 ====================================================
 
@@ -576,3 +590,4 @@ how to avoid and resolve issues.
 .. _6: https://xenproject.org/help/irc/
 .. _8: https://en.wikipedia.org/wiki/Erin_Meyer
 .. _9: https://www.nsf.gov/attachments/134059/public/15LFW_WorkingWithMulticulturalTeams_LarsonC.pdf
+.. _10: https://lists.xenproject.org/mailman/listinfo/xen-devel
--8323329-1104439357-1635212806=:4586--


From xen-devel-bounces@lists.xenproject.org Tue Oct 26 01:55:35 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Oct 2021 01:55:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.216187.375701 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfBgJ-0005Zv-RV; Tue, 26 Oct 2021 01:55:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 216187.375701; Tue, 26 Oct 2021 01:55:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfBgJ-0005Zo-OH; Tue, 26 Oct 2021 01:55:15 +0000
Received: by outflank-mailman (input) for mailman id 216187;
 Tue, 26 Oct 2021 01:55:14 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=izNm=PO=gmail.com=f.fainelli@srs-us1.protection.inumbo.net>)
 id 1mfBgI-0005Zi-G5
 for xen-devel@lists.xenproject.org; Tue, 26 Oct 2021 01:55:14 +0000
Received: from mail-qk1-x72c.google.com (unknown [2607:f8b0:4864:20::72c])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 9f2621b8-1156-4327-a1db-ae0b33138e89;
 Tue, 26 Oct 2021 01:55:13 +0000 (UTC)
Received: by mail-qk1-x72c.google.com with SMTP id h20so13574813qko.13
 for <xen-devel@lists.xenproject.org>; Mon, 25 Oct 2021 18:55:13 -0700 (PDT)
Received: from ?IPV6:2600:1700:dfe0:49f0:f0b4:bed7:bbf6:a2b1?
 ([2600:1700:dfe0:49f0:f0b4:bed7:bbf6:a2b1])
 by smtp.gmail.com with ESMTPSA id b2sm9291563qtg.88.2021.10.25.18.55.11
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Mon, 25 Oct 2021 18:55:12 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9f2621b8-1156-4327-a1db-ae0b33138e89
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=message-id:date:mime-version:user-agent:subject:content-language:to
         :cc:references:from:in-reply-to:content-transfer-encoding;
        bh=mCnwnbPbhYcrF9QBa5LUo8e7y29tVyuzmG2cawteQCA=;
        b=olTS1hbEonbFLujA4x2P8XYUAvZ7BmbseWok6MxtRkkecckkwKz0CEcHcKTIFXqAD1
         HysBjR0qkBfUHxMdYr2Xq5WICeG/B9+27ROdTcp0AvFcS0g4Panq/rOvWzZ2TmhkTOXG
         lSJNmzpWOQeUmYVpALraWJDQWLuUknFeO6s2pGwmj3D2HA6DehAJ7vias+zNbYSCewk1
         t7w4J7gvXmEP+Bv2hY6sasrL+NEZ/KwUlrLQqJNmU9pfR9B8LF4M7no6jIPjIBosEvfP
         akouqDz9bsBhAcLG0UbstP7ZEIAFG1yuS2OO+gWrMUchRrdLVCvwNZPt4kSFnpe7FKZl
         vh6Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:message-id:date:mime-version:user-agent:subject
         :content-language:to:cc:references:from:in-reply-to
         :content-transfer-encoding;
        bh=mCnwnbPbhYcrF9QBa5LUo8e7y29tVyuzmG2cawteQCA=;
        b=NGQ+cJx4EtJvG9JsZOEvBEda9brsrYr+0E8WChuTbFbETxjW9ofBeMnFgwdNuJKYYo
         BQD9juRrDDdoKLxwrKfLkh8svDYLxJMxAT3/WUh8/w/S4fC1YKZt4XNiJ1dDwhm2jSTT
         UKXe0LiShP2d4eVcLHGk8HQJ1Lh49L+9Z8YEWIl3I/8bkBXx21OfTDawED680pCDApGM
         l721qDet6r0Q+zy78ZGwazxpnYDeBser0q8lASfBoV28eBjDB7p2oJa0bpznmbWP3KTt
         ykaQQmDxfHklOXq7F8aZSDh6C4puQezgSxAbYnyF/FaD8++gCs2cK8NMz2AWXDTLAnOq
         Tx0w==
X-Gm-Message-State: AOAM531feOc3sBQ33VDB4SEwlYSW4Aq+WyIvOhK2zOhrgzBHvNELFz8k
	5s5bWUpDbzb3q+tobdL32u8=
X-Google-Smtp-Source: ABdhPJwolSe/hyU6zweo2PfHcxsIbYIwTjHsxR3G5XrXvY2VF2DpbOrilwEvBsvaMiIxs6LTirOehA==
X-Received: by 2002:a05:620a:25ce:: with SMTP id y14mr4685253qko.66.1635213313158;
        Mon, 25 Oct 2021 18:55:13 -0700 (PDT)
Message-ID: <f0b28cb6-be34-9b78-844c-0913592fe5f9@gmail.com>
Date: Mon, 25 Oct 2021 18:55:09 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.2.1
Subject: Re: [RESEND 0/5] ARM/arm64: arm_pm_restart removal
Content-Language: en-US
To: Guenter Roeck <linux@roeck-us.net>, Dmitry Osipenko <digetx@gmail.com>,
 Lee Jones <lee.jones@linaro.org>, linux@armlinux.org.uk,
 catalin.marinas@arm.com, will@kernel.org, mark.rutland@arm.com,
 lorenzo.pieralisi@arm.com, sstabellini@kernel.org
Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
 wsa+renesas@sang-engineering.com, treding@nvidia.com, arnd@arndb.de,
 xen-devel@lists.xenproject.org, patches@armlinux.org.uk
References: <20210604140357.2602028-1-lee.jones@linaro.org>
 <526fe66f-df08-c873-2a20-f1295e30a855@gmail.com>
 <a4fe088f-0f13-f80f-5011-4eee2d44ef63@gmail.com>
 <321b167f-8744-9ca8-58b0-e09ff39dfa02@roeck-us.net>
From: Florian Fainelli <f.fainelli@gmail.com>
In-Reply-To: <321b167f-8744-9ca8-58b0-e09ff39dfa02@roeck-us.net>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit



On 10/25/2021 6:02 PM, Guenter Roeck wrote:
> On 10/25/21 4:55 PM, Dmitry Osipenko wrote:
>> 26.10.2021 02:29, Florian Fainelli пишет:
>>> On 6/4/21 7:03 AM, Lee Jones wrote:
>>>> This is a rebase/refresh of a set sent out, reviewed,
>>>> then forgotten about.  It's still considered useful.
>>>>
>>>> Here is an excerpt from the previous attempt:
>>>>
>>>>   "Hi Russell, ARM SoC maintainers,
>>>>
>>>>   here's the full set of patches that remove arm_pm_restart as 
>>>> discussed
>>>>   earlier. There's some background on the series in this thread:
>>>>
>>>>     https://lore.kernel.org/linux-arm-kernel/20170130110512.6943-1-thierry.reding@gmail.com/ 
>>>>
>>>>
>>>>   I also have a set of patches that build on top of this and try to add
>>>>   something slightly more formal by adding a power/reset framework that
>>>>   driver can register with. If we can get this series merged, I'll find
>>>>   some time to refresh those patches and send out for review again.
>>>
>>> What happened to this patch series? Is there any chance we will get it
>>> included at some point? It is included in the Android13-5.10 tree AFAICT
>>>
>>
>> It's in mainline since v5.14, AFAICS.
>>
> 
> Yes, indeed.

Great, thanks!
-- 
Florian


From xen-devel-bounces@lists.xenproject.org Tue Oct 26 06:16:08 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Oct 2021 06:16:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.216121.375733 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfFkc-0004ie-5P; Tue, 26 Oct 2021 06:15:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 216121.375733; Tue, 26 Oct 2021 06:15:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfFkc-0004iX-1O; Tue, 26 Oct 2021 06:15:58 +0000
Received: by outflank-mailman (input) for mailman id 216121;
 Mon, 25 Oct 2021 23:55:04 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=GUz9=PN=gmail.com=digetx@srs-us1.protection.inumbo.net>)
 id 1mf9o0-0003kg-Cd
 for xen-devel@lists.xenproject.org; Mon, 25 Oct 2021 23:55:04 +0000
Received: from mail-lf1-x132.google.com (unknown [2a00:1450:4864:20::132])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 0f781176-7262-406e-858a-b0be2e992a69;
 Mon, 25 Oct 2021 23:55:03 +0000 (UTC)
Received: by mail-lf1-x132.google.com with SMTP id p16so16083309lfa.2
 for <xen-devel@lists.xenproject.org>; Mon, 25 Oct 2021 16:55:03 -0700 (PDT)
Received: from [192.168.2.145] (46-138-41-28.dynamic.spd-mgts.ru.
 [46.138.41.28])
 by smtp.googlemail.com with ESMTPSA id j12sm553517lfu.7.2021.10.25.16.55.01
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Mon, 25 Oct 2021 16:55:01 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0f781176-7262-406e-858a-b0be2e992a69
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-language:content-transfer-encoding;
        bh=aT3DJ36JdJHVIWZZjofTeLnbp7vhz92UJVeAX8pVSy0=;
        b=G40vs8yJV/u6paBEE7EhpNHsEvuPlrNfVIsKD3phU07bzJRZqUgNZo/0sLky8snNVg
         4/0jumZEmJTuXX2HXbTFxZdlKJhd130yq0rNzjvqnVnETDOjPkp/nH0zeLA9I1JTTg4i
         dOErtVJzid6/8NPURYcaeARc7gbWOnLZqo1Jjo+fEkIQ0O5iTqGzj+EHwiH6TZdE+ASk
         T3a3On9ETPMF0RaueEYF++g4MGMNpNFXDHfTAThxDmIVhvMiAwbpxAECXzljxPqboJ+r
         vFaaN6/ZWMY6BlSgYsQTdlfY/9F7NePghy3DXSOVpN2al3BJaCZuWvGjd3IZTD6TiLlr
         ljaA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-language
         :content-transfer-encoding;
        bh=aT3DJ36JdJHVIWZZjofTeLnbp7vhz92UJVeAX8pVSy0=;
        b=Y95M71MxXaLqdAwfmdqK31h1c0GDFqqJHCQA/usXUvyds2tn2KOBEQZ2KUrXAL5DIi
         CNQBJ0ys7cqUvNL7UV270Dhkl89wsd4+BUQqtjF5p7am4VQte93DVrpfDeLc6VHdaxbs
         53vWitzmhcICha35btOAlFk7tGChEVkvVTmayEdoxb+Vyh77dUCZCFa6hESmKTa3277x
         ZcU6bmM1dJ5kmXgaEQ4GsUrv4pTbqyGi9drdJX3Ac21/wFZkys9zRnrelToNFSvtlsd2
         ATnv7P96rdB2lVHT3MTZXPwPkkAFw3Rc7dq+cy05RIi9/eSZBy7Q98GZBXXVCINoD6jb
         lHlA==
X-Gm-Message-State: AOAM5309giDwSH4ThOT3X7SwQZe8CtCYKmiNxeKfy6xH4CyoRauYCcKV
	SvLhRUiJVq0TT4E74YkSm7Y=
X-Google-Smtp-Source: ABdhPJyFeyXJF+fk76OPZg46jraLMHXkxk7h8aK1t6+wPg8gTB1N4ldWUfXWhhdT2N+tukeHFo3pTQ==
X-Received: by 2002:a05:6512:2292:: with SMTP id f18mr19177414lfu.619.1635206102278;
        Mon, 25 Oct 2021 16:55:02 -0700 (PDT)
Subject: Re: [RESEND 0/5] ARM/arm64: arm_pm_restart removal
To: Florian Fainelli <f.fainelli@gmail.com>, Lee Jones
 <lee.jones@linaro.org>, linux@armlinux.org.uk, catalin.marinas@arm.com,
 will@kernel.org, mark.rutland@arm.com, lorenzo.pieralisi@arm.com,
 sstabellini@kernel.org
Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
 wsa+renesas@sang-engineering.com, linux@roeck-us.net, treding@nvidia.com,
 arnd@arndb.de, xen-devel@lists.xenproject.org, patches@armlinux.org.uk
References: <20210604140357.2602028-1-lee.jones@linaro.org>
 <526fe66f-df08-c873-2a20-f1295e30a855@gmail.com>
From: Dmitry Osipenko <digetx@gmail.com>
Message-ID: <a4fe088f-0f13-f80f-5011-4eee2d44ef63@gmail.com>
Date: Tue, 26 Oct 2021 02:55:01 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <526fe66f-df08-c873-2a20-f1295e30a855@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit

26.10.2021 02:29, Florian Fainelli пишет:
> On 6/4/21 7:03 AM, Lee Jones wrote:
>> This is a rebase/refresh of a set sent out, reviewed,
>> then forgotten about.  It's still considered useful.
>>
>> Here is an excerpt from the previous attempt:
>>
>>  "Hi Russell, ARM SoC maintainers,
>>
>>  here's the full set of patches that remove arm_pm_restart as discussed
>>  earlier. There's some background on the series in this thread:
>>
>> 	https://lore.kernel.org/linux-arm-kernel/20170130110512.6943-1-thierry.reding@gmail.com/
>>
>>  I also have a set of patches that build on top of this and try to add
>>  something slightly more formal by adding a power/reset framework that
>>  driver can register with. If we can get this series merged, I'll find
>>  some time to refresh those patches and send out for review again.
> 
> What happened to this patch series? Is there any chance we will get it
> included at some point? It is included in the Android13-5.10 tree AFAICT
> 

It's in mainline since v5.14, AFAICS.


From xen-devel-bounces@lists.xenproject.org Tue Oct 26 06:16:08 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Oct 2021 06:16:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.216199.375735 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfFkc-0004kO-D0; Tue, 26 Oct 2021 06:15:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 216199.375735; Tue, 26 Oct 2021 06:15:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfFkc-0004kG-8p; Tue, 26 Oct 2021 06:15:58 +0000
Received: by outflank-mailman (input) for mailman id 216199;
 Tue, 26 Oct 2021 03:27:58 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=LJH3=PO=iscas.ac.cn=jiasheng@srs-us1.protection.inumbo.net>)
 id 1mfD82-00064z-9H
 for xen-devel@lists.xenproject.org; Tue, 26 Oct 2021 03:27:58 +0000
Received: from cstnet.cn (unknown [159.226.251.25])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTP
 id b4a15a7e-360c-11ec-8423-12813bfff9fa;
 Tue, 26 Oct 2021 03:27:55 +0000 (UTC)
Received: from localhost.localdomain (unknown [124.16.138.128])
 by APP-05 (Coremail) with SMTP id zQCowAAH6u61dXdhPPotBQ--.46973S2;
 Tue, 26 Oct 2021 11:27:50 +0800 (CST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b4a15a7e-360c-11ec-8423-12813bfff9fa
From: Jiasheng Jiang <jiasheng@iscas.ac.cn>
To: boris.ostrovsky@oracle.com,
	jgross@suse.com,
	sstabellini@kernel.org
Cc: xen-devel@lists.xenproject.org,
	linux-kernel@vger.kernel.org,
	Jiasheng Jiang <jiasheng@iscas.ac.cn>
Subject: [PATCH] xen: Fix implicit type conversion
Date: Tue, 26 Oct 2021 03:27:48 +0000
Message-Id: <1635218868-2437564-1-git-send-email-jiasheng@iscas.ac.cn>
X-Mailer: git-send-email 2.7.4
X-CM-TRANSID:zQCowAAH6u61dXdhPPotBQ--.46973S2
X-Coremail-Antispam: 1UD129KBjvdXoWruw18Xr43urW8Gr4Uuw43trb_yoWDtFbE9r
	s0qr1xXrWvvF1qvayUKw4fZFW09w1xuayfXw1qg39xAw1Sqr47Xryjqr93Xw17GrWIyFsr
	Zw17Xr1xAryUGjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT
	9fnUUIcSsGvfJTRUUUbcAFF20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2IYs7xG
	6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8w
	A2z4x0Y4vE2Ix0cI8IcVAFwI0_Xr0_Ar1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Gr0_
	Cr1l84ACjcxK6I8E87Iv67AKxVW8Jr0_Cr1UM28EF7xvwVC2z280aVCY1x0267AKxVW8Jr
	0_Cr1UM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4xI64kE6c02F40Ex7xfMcIj
	6xIIjxv20xvE14v26r1j6r18McIj6I8E87Iv67AKxVWUJVW8JwAm72CE4IkC6x0Yz7v_Jr
	0_Gr1lF7xvr2IYc2Ij64vIr41lF7I21c0EjII2zVCS5cI20VAGYxC7MxkIecxEwVAFwVW8
	GwCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F40E14v26r
	1j6r18MI8I3I0E7480Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_JF0_Jw1lIxkGc2Ij
	64vIr41lIxAIcVC0I7IYx2IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7CjxVAFwI0_Jr
	0_Gr1lIxAIcVCF04k26cxKx2IYs7xG6rW3Jr0E3s1lIxAIcVC2z280aVAFwI0_Jr0_Gr1l
	IxAIcVC2z280aVCY1x0267AKxVWUJVW8JbIYCTnIWIevJa73UjIFyTuYvjfU84SoDUUUU
X-Originating-IP: [124.16.138.128]
X-CM-SenderInfo: pmld2xxhqjqxpvfd2hldfou0/

The variable 'i' is defined as UINT.
However in the for_each_possible_cpu, its value is assigned to -1.
That doesn't make sense and in the cpumask_next() it is implicitly
type conversed to INT.
It is universally accepted that the implicit type conversion is
terrible.
Also, having the good programming custom will set an example for
others.
Thus, it might be better to change the definition of 'i' from UINT
to INT.

Fixes: 3fac101 ("xen: Re-upload processor PM data to hypervisor after S3 resume (v2)")
Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
---
 drivers/xen/xen-acpi-processor.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/xen/xen-acpi-processor.c b/drivers/xen/xen-acpi-processor.c
index df7cab8..2551691 100644
--- a/drivers/xen/xen-acpi-processor.c
+++ b/drivers/xen/xen-acpi-processor.c
@@ -518,7 +518,7 @@ static struct syscore_ops xap_syscore_ops = {
 
 static int __init xen_acpi_processor_init(void)
 {
-	unsigned int i;
+	int i;
 	int rc;
 
 	if (!xen_initial_domain())
-- 
2.7.4



From xen-devel-bounces@lists.xenproject.org Tue Oct 26 07:13:54 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Oct 2021 07:13:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.216247.375771 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfGeZ-0002uG-TN; Tue, 26 Oct 2021 07:13:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 216247.375771; Tue, 26 Oct 2021 07:13:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfGeZ-0002u9-Q6; Tue, 26 Oct 2021 07:13:47 +0000
Received: by outflank-mailman (input) for mailman id 216247;
 Tue, 26 Oct 2021 07:13:46 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=oSYy=PO=suse.com=jgross@srs-us1.protection.inumbo.net>)
 id 1mfGeY-0002tM-KY
 for xen-devel@lists.xenproject.org; Tue, 26 Oct 2021 07:13:46 +0000
Received: from smtp-out1.suse.de (unknown [195.135.220.28])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 418fa05c-362c-11ec-8428-12813bfff9fa;
 Tue, 26 Oct 2021 07:13:45 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 6238821940;
 Tue, 26 Oct 2021 07:13:44 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id F2E5A13CCA;
 Tue, 26 Oct 2021 07:13:43 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id 7H0bOaeqd2GLLwAAMHmgww
 (envelope-from <jgross@suse.com>); Tue, 26 Oct 2021 07:13:43 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 418fa05c-362c-11ec-8428-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1635232424; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=XIm7H1NXWQguuHEZW7jiUPfL4o978yLyAtodWckzLYY=;
	b=OiXOrzavk+ZMCxE4aEaKbQH+B+PWdUpKOYJ58wshKojoNJd2V2MrgqckBz2BcivwISOdYc
	mNGAa6KfooqJ8tj9dNm3AodRvKeN+HHtrNXbAv56pQB6p91vRGmW4Wr7Krrgdd9xMiCC7g
	oz6xH+B7JV5Xnz8Dh9+YhhhkYaYWX24=
Subject: Re: [PATCH] xen: Fix implicit type conversion
To: Jiasheng Jiang <jiasheng@iscas.ac.cn>, boris.ostrovsky@oracle.com,
 sstabellini@kernel.org
Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org
References: <1635218868-2437564-1-git-send-email-jiasheng@iscas.ac.cn>
From: Juergen Gross <jgross@suse.com>
Message-ID: <b85fc46c-1c0c-87e6-3221-c13fb98856ec@suse.com>
Date: Tue, 26 Oct 2021 09:13:43 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <1635218868-2437564-1-git-send-email-jiasheng@iscas.ac.cn>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="99XBLDRORLEoblM9AoV0HXYmPlxUqqJQ8"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--99XBLDRORLEoblM9AoV0HXYmPlxUqqJQ8
Content-Type: multipart/mixed; boundary="qJkaCkRICl179ZSYKmG00kVO89yJ36MR1";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Jiasheng Jiang <jiasheng@iscas.ac.cn>, boris.ostrovsky@oracle.com,
 sstabellini@kernel.org
Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org
Message-ID: <b85fc46c-1c0c-87e6-3221-c13fb98856ec@suse.com>
Subject: Re: [PATCH] xen: Fix implicit type conversion
References: <1635218868-2437564-1-git-send-email-jiasheng@iscas.ac.cn>
In-Reply-To: <1635218868-2437564-1-git-send-email-jiasheng@iscas.ac.cn>

--qJkaCkRICl179ZSYKmG00kVO89yJ36MR1
Content-Type: multipart/mixed;
 boundary="------------BF424F510ECB9792D93575FD"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------BF424F510ECB9792D93575FD
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 26.10.21 05:27, Jiasheng Jiang wrote:
> The variable 'i' is defined as UINT.
> However in the for_each_possible_cpu, its value is assigned to -1.
> That doesn't make sense and in the cpumask_next() it is implicitly
> type conversed to INT.
> It is universally accepted that the implicit type conversion is
> terrible.
> Also, having the good programming custom will set an example for
> others.
> Thus, it might be better to change the definition of 'i' from UINT
> to INT.
>=20
> Fixes: 3fac101 ("xen: Re-upload processor PM data to hypervisor after S=
3 resume (v2)")
> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
> ---
>   drivers/xen/xen-acpi-processor.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/xen/xen-acpi-processor.c b/drivers/xen/xen-acpi-pr=
ocessor.c
> index df7cab8..2551691 100644
> --- a/drivers/xen/xen-acpi-processor.c
> +++ b/drivers/xen/xen-acpi-processor.c
> @@ -518,7 +518,7 @@ static struct syscore_ops xap_syscore_ops =3D {
>  =20
>   static int __init xen_acpi_processor_init(void)
>   {
> -	unsigned int i;
> +	int i;

I agree with the approach, but could you please fix all the other
similar issues in that file, please?

The same should be done in free_acpi_perf_data() and in
xen_upload_processor_pm_data().


Juergen

--------------BF424F510ECB9792D93575FD
Content-Type: application/pgp-keys;
 name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Transfer-Encoding: quoted-printable
Content-Description: OpenPGP public key
Content-Disposition: attachment;
 filename="OpenPGP_0xB0DE9DD628BF132F.asc"

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy=
cWx
w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O=
f8Z
d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y=
9bf
IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq=
G7/
377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR=
3Jv
c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA=
QIe
AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT=
hpw
dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0=
MbD
1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv=
oPH
Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v=
5QL
+qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ=
2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC=
QoL
BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr=
Wf0
teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC=
/nu
AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh=
ITT
d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm=
XBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz=
80h
SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC=
AcD
AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn=
FOX
gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1=
jnD
kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0=
N51
N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l=
otu
fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1=
tqS
EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA=
hsD
BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3=
g3O
ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5=
dM7
wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5=
D+j
LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm=
V2x
AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N=
Eaw
QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW=
nHI
s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR=
wgn
BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV=
bVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk=
pEd
IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA=
QAB
wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw=
Tbe
8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1=
vJz
Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8=
VGi
wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW=
svi
uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX=
zXs
ZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------BF424F510ECB9792D93575FD--

--qJkaCkRICl179ZSYKmG00kVO89yJ36MR1--

--99XBLDRORLEoblM9AoV0HXYmPlxUqqJQ8
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmF3qqcFAwAAAAAACgkQsN6d1ii/Ey+D
TwgAiaYgm6f+6d+KtD421JSmH4FGKVs85spfNEElB4K7+haiEEg2zF6Jc58dsZY5WClzZerZCakD
BovSX+M/aWTQ1p/2yvtjp4hMzcB3IQXuACXT30Z1nXMbLoIPXMmZaN60946iW3rJ70RSWjbsKzH4
OBiGZJI6KjmnO95sRjVVpLrUO+Y7uVMATRSWmH9kJQVGa41I3Gw6km5ScZncIp3K/Qh6Ahg9aUzm
Z8ZlwZu4j2I/8t0/7bfhfT7IZkMMQsLGDr4TJ+Ee79Szc/3mDQSp/xxai3EAjRufyYou+DHfrgml
LH2sOcqgBCKQ5JoSt1+kKdTSFoxCpbFHJSbXcyhyeA==
=AWwJ
-----END PGP SIGNATURE-----

--99XBLDRORLEoblM9AoV0HXYmPlxUqqJQ8--


From xen-devel-bounces@lists.xenproject.org Tue Oct 26 07:27:56 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Oct 2021 07:27:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.216255.375782 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfGs4-0004U6-B2; Tue, 26 Oct 2021 07:27:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 216255.375782; Tue, 26 Oct 2021 07:27:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfGs4-0004Tz-6K; Tue, 26 Oct 2021 07:27:44 +0000
Received: by outflank-mailman (input) for mailman id 216255;
 Tue, 26 Oct 2021 07:27:42 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Sep+=PO=arm.com=Bertrand.Marquis@srs-us1.protection.inumbo.net>)
 id 1mfGs2-0004Ta-DS
 for xen-devel@lists.xenproject.org; Tue, 26 Oct 2021 07:27:42 +0000
Received: from EUR03-AM5-obe.outbound.protection.outlook.com (unknown
 [40.107.3.79]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 33ae9a86-362e-11ec-8428-12813bfff9fa;
 Tue, 26 Oct 2021 07:27:41 +0000 (UTC)
Received: from AS9PR04CA0049.eurprd04.prod.outlook.com (2603:10a6:20b:46a::34)
 by VI1PR08MB3853.eurprd08.prod.outlook.com (2603:10a6:803:c1::31)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.18; Tue, 26 Oct
 2021 07:27:38 +0000
Received: from AM5EUR03FT049.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:46a:cafe::ac) by AS9PR04CA0049.outlook.office365.com
 (2603:10a6:20b:46a::34) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.16 via Frontend
 Transport; Tue, 26 Oct 2021 07:27:38 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM5EUR03FT049.mail.protection.outlook.com (10.152.17.130) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4628.16 via Frontend Transport; Tue, 26 Oct 2021 07:27:37 +0000
Received: ("Tessian outbound 8e26f7114b75:v103");
 Tue, 26 Oct 2021 07:27:37 +0000
Received: from a039ef808677.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 71EFBF57-0FA4-4F0C-A255-0F052432569E.1; 
 Tue, 26 Oct 2021 07:27:30 +0000
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id a039ef808677.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Tue, 26 Oct 2021 07:27:30 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25)
 by AS8PR08MB6056.eurprd08.prod.outlook.com (2603:10a6:20b:299::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.18; Tue, 26 Oct
 2021 07:27:29 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::69d7:e26:6610:ebd8]) by AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::69d7:e26:6610:ebd8%4]) with mapi id 15.20.4628.020; Tue, 26 Oct 2021
 07:27:29 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 33ae9a86-362e-11ec-8428-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=hbz1gC+yxerDSmJOGo9iWMynpiElyeY8+CzWmPlMaIA=;
 b=TVX2wC8FWpaZlt43459egi3TfqBqvyo89VMiMXqzQNq3yz6nj6wKazuoOLbSb33MQuHwf8czg8Z2nor+PhVLExu5pMxSLzdCU8VXLBNMU0mc6OfKuVewctTWemkGMZeUTpcst50XFUzSjBgT682Y59q1lMjxYYOw6JZu/M/aj2s=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: a8ec92bf9c8ee7ae
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=JO6wKx/AGehrhQl7YFU6GcapItXTPGRX5G0EiazToj9bdZ/4atVjpfVtuILd3/vGZrR8wltiNbfkznWU5/24h8IMUSYvw1K6JXD7Knyybg7vDNcYE6eM8UjZkngJd3HGgVX+uu8wXTp5uTLsa33kn/svE8K6ZIj4OzzWm4avhnI/PiP/+lA+bU52MoPIjlRKyvXq6bfYcKnTweHSZCmCX4Uah9/QRK+zwJVWXl3G9mQWUZvb/BLoLEHgdEpN/1IYUB5dnCh/nWRTApK72y3XeOSrTbYyD6bl9uKcl+Gtyf76wTseJipplSf6e7EEGsP2mAFvEJT2RAz4nBZpUkcyGA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=hbz1gC+yxerDSmJOGo9iWMynpiElyeY8+CzWmPlMaIA=;
 b=aIYnmaZtsABjTRPr7SbLOpO94VBpcMa7VhD00eP3zSrEmN45V3/DyXQ41F+bS+fvWi13an3lMshVGTZcCBiCVg8z145LHccf70svFG1y9c1TQI/SETyZjL38+RqwoBp6K5L/skozK7AOq760UsjrfFOBO9PSUM3GUbBMfwd7BeYuKHuBVvHMRTAQr7QZFv79CHNpYlgj8hmOUL13Mw76sJZQH0FwRRIrKm1onlJrtbf5+9pGmw7goGbs4CZe1uNPULms3U8W6KrVYyQNzHyb+TgHUEvCLF9tBOvJmqyQCMNDbKTu6RG0Wwcb+wjMKWRfKY6nQT07alelOoRCkJ4qeg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=hbz1gC+yxerDSmJOGo9iWMynpiElyeY8+CzWmPlMaIA=;
 b=TVX2wC8FWpaZlt43459egi3TfqBqvyo89VMiMXqzQNq3yz6nj6wKazuoOLbSb33MQuHwf8czg8Z2nor+PhVLExu5pMxSLzdCU8VXLBNMU0mc6OfKuVewctTWemkGMZeUTpcst50XFUzSjBgT682Y59q1lMjxYYOw6JZu/M/aj2s=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Stefano Stabellini <sstabellini@kernel.org>
CC: George Dunlap <George.Dunlap@citrix.com>, "dunlapg@umich.edu"
	<dunlapg@umich.edu>, "roger.pau@citrix.com" <roger.pau@citrix.com>,
	"jbeulich@suse.com" <jbeulich@suse.com>, "committers@xenproject.org"
	<committers@xenproject.org>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v2] governance: communication channels
Thread-Topic: [PATCH v2] governance: communication channels
Thread-Index: AQHXygtmvmq8MpkV4UGUOhm0oDJDQqvk4cUA
Date: Tue, 26 Oct 2021 07:27:29 +0000
Message-ID: <F3071594-3327-40B4-A0C2-D3EAD591DF74@arm.com>
References: <alpine.DEB.2.21.2110251845500.4586@sstabellini-ThinkPad-T480s>
In-Reply-To: <alpine.DEB.2.21.2110251845500.4586@sstabellini-ThinkPad-T480s>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3654.120.0.1.13)
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: d75150b0-3fd1-401d-f24f-08d998521627
x-ms-traffictypediagnostic: AS8PR08MB6056:|VI1PR08MB3853:
X-Microsoft-Antispam-PRVS:
	<VI1PR08MB3853A998722AED33B04308229D849@VI1PR08MB3853.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:8882;OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 wTGkzmNOyotU1Tm5GclIc0OtMQkshzbHdRaCtApZ+CmuQVk2XhuzgDdwQlMoV8ITQOh2H7xCmBvzmPf3ho4gGbVOk1YXGNpJJmIDTfVmdtCxyxNGglmo3PefgjJgywEXaqoIw2WvQQ6d+L/4H5TJfXcaXgYOAXmT8lxaM2vf6F/GlV9274J661Vp/xrQvXDzkq/5nCQ3nYWR8QHyKNr9kcdaK+6USN7kf997V2KKbxw6Y/ZmqhRQicZhpQp1RGEW8M9JvzISAQlEhOXqssDW8ZK4/mFgVuHiSZiOVFY2Q7QrFPjZCUZ8oW8xs417MG3SvZ9PNqdeJsbIfiMF/VQalvTXRHzhv3T6TkXIKaoJlA/4SiDR5aPvrJ1zy2SWlnpjpNwbFoioSViYEi5PYhKQjPWU8ThoVcqcBhN1dXmlCT+K/ZNX1Iskf3qPW60O5D+b+FvpvfodiAOD03vHNuwkZbo8DcOlbv75iJ8zhKcv1H2v1VIyLSIffnC7JZhEq4dhKpwEWU1XGfGWy9hm9DLbflGsVy+DfjGKW0K9DX3UWHmbmG5NPzWSAdn5pELlnJb/4/hQLQjcgG8OKAdQCOdzubrbFApwUliAD7WBr3jrIzfvyLyiQYbsIkuMQAJ56/ssTO8vqMgla/JWmO3PMsyKIjO+49/9XBYrJRRb12Y+B++4BTJVCrRqbB5e/LsM/58cxYhzMxAiNOapKIT88+ajxodjeNpP8npCR1f6TenTaazTWi525KMSPPXkncCHyNrVjF4YknFoCcBOzB+pN/EGri2x2xY2vATb5JX64EV06ZzBjM4yljPgDKqjy2NHIlEFVCoJuN+dv4UmjWLiyvp9gKNtiOIWhiU8MeTfwsBnJLQ=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(186003)(6916009)(26005)(5660300002)(86362001)(71200400001)(6512007)(91956017)(122000001)(8676002)(53546011)(2906002)(2616005)(54906003)(76116006)(966005)(36756003)(66946007)(316002)(66476007)(33656002)(66556008)(64756008)(66446008)(83380400001)(6486002)(38100700002)(4326008)(8936002)(38070700005)(508600001)(6506007)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-ID: <A260321B1F6496408564D3FA25F60218@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6056
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM5EUR03FT049.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	76c9e25f-7cd5-473a-44f7-08d998521160
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	iJPXu1eWnlKbbGcTPD+IlG6Kz74qY6HUqBXZUiNExrbml+lcf1PmLhv4aVKykUq/aQMgwmDLf/r2pQ2q3IKAd6llbV2RyFaVrKuv4N44BM7KCiegSzFuw3bPGnQhq+gxAmBHqlMZpRGGqv2+2YFtYU4Hw+tWNmf/NnW5km9J79vDbO2ec13Ps9y3bmWrz/dGPGUBEssHRAb6edthny7jS9fPKxMu26vFdeVrF2kRfOQUHbmA9ShneeMK0K4bpDohYTsBxJ1Evz1PuVhkWUF26haQ6QGyPQBkh3E8V5HKcw1cYCqUjEJ+w/C+KKLx6ZfPR+ij3mRMpzGKOoVQprQtHlY8S3Gnsi3sL8E8lki4O5YulGzJbD9Z+J7Fk7fgOPcdgPGlv3y3Apt/Uq6qbuCZYbHCGgeLuVBQi07JmWHbA5EbXprDD2rMH2pjwkeCmVlz+SdRD5t+FisPEiZEx5r0vpIND2X2rebZU2wKM2fbskaSn405fCNlkOZy17Wci7sO2KIuispX9STza46ZGX4QS2QEdFVpJdvQIbUg2jqzVoZCcC7HrH9JuaMDhXWw5j5cidSCubXdFzMTuiFpjb+aQQKKBbEG5AzkqTpTLrGR/9WP/wNx8u6oSRRj4BFl1k3qLtPXxS+Cl8xno7ToF7jw72Y1HJ98eUGBWv3DZ9GFdRYoEPP65+yLC4eES0QZEk2yWa94ZKYiZb+Ok9NIcJqQ3tnPmGyrs9XXReT2gQRSxH5RHjO8sbWE7aDJHjNRXi9S9rEHSpsy0nBAw9WpG/YaDKcpOTvE3uOX+V8rNtUpObYP5TmkhQT6alBujMHLorxk
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(6512007)(2616005)(5660300002)(36756003)(8676002)(53546011)(26005)(82310400003)(33656002)(54906003)(86362001)(356005)(508600001)(6862004)(81166007)(8936002)(6506007)(36860700001)(6486002)(47076005)(316002)(70586007)(70206006)(83380400001)(336012)(186003)(4326008)(2906002)(966005);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2021 07:27:37.5473
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: d75150b0-3fd1-401d-f24f-08d998521627
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM5EUR03FT049.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3853

SGkgU3RlZmFubywNCg0KPiBPbiAyNiBPY3QgMjAyMSwgYXQgMDI6NDYsIFN0ZWZhbm8gU3RhYmVs
bGluaSA8c3N0YWJlbGxpbmlAa2VybmVsLm9yZz4gd3JvdGU6DQo+IA0KPiBDbGFyaWZ5IHRoYXQg
eGVuLWRldmVsIGlzIHRoZSBvbmx5IG9mZmljaWFsIGNvbW11bmljYXRpb24gY2hhbm5lbC4NCj4g
DQo+IFNpZ25lZC1vZmYtYnk6IFN0ZWZhbm8gU3RhYmVsbGluaSA8c3RlZmFuby5zdGFiZWxsaW5p
QHhpbGlueC5jb20+DQpSZXZpZXdlZC1ieTogQmVydHJhbmQgTWFycXVpcyA8YmVydHJhbmQubWFy
cXVpc0Bhcm0uY29tPg0KDQpKdXN0IGZvciBteSBrbm93bGVkZ2UsIHdoZXJlIGlzIHRoaXMgZmls
ZSBzdG9yZWQgKGFzIGl0IGlzIG5vdCBpbiB4ZW4uZ2l0KSA/DQoNCkNoZWVycw0KQmVydHJhbmQN
Cg0KPiANCj4gLS0tDQo+IENoYW5nZXMgaW4gdjI6DQo+IC0gcmVtb3ZlIG1lbnRpb25zIG9mICN4
ZW5kZXZlbCBvbiBPRlRDDQo+IA0KPiBkaWZmIC0tZ2l0IGEvc291cmNlL2NvbW11bmljYXRpb24t
cHJhY3RpY2UucnN0IGIvc291cmNlL2NvbW11bmljYXRpb24tcHJhY3RpY2UucnN0DQo+IGluZGV4
IDcwZjViOGMuLjJjZTJhNGUgMTAwNjQ0DQo+IC0tLSBhL3NvdXJjZS9jb21tdW5pY2F0aW9uLXBy
YWN0aWNlLnJzdA0KPiArKysgYi9zb3VyY2UvY29tbXVuaWNhdGlvbi1wcmFjdGljZS5yc3QNCj4g
QEAgLTksNiArOSwyMCBAQCBUaGlzIGd1aWRlIHByb3ZpZGVzIGNvbW11bmljYXRpb24gQmVzdCBQ
cmFjdGljZSB0aGF0IGhlbHBzIHlvdSBpbg0KPiAqIEJlaW5nIGF3YXJlIG9mIHlvdXIgb3duIGFu
ZCBjb3VudGVycGFydOKAmXMgY29tbXVuaWNhdGlvbiBzdHlsZSBhbmQgY3VsdHVyZQ0KPiAqIFNo
b3cgZW1wYXRoeSB0b3dhcmRzIG90aGVyIGNvbW11bml0eSBtZW1iZXJzDQo+IA0KPiArQ29tbXVu
aWNhdGlvbiBDaGFubmVscw0KPiArPT09PT09PT09PT09PT09PT09PT09PQ0KPiArDQo+ICtBbGwg
aW1wb3J0YW50IGNvbW11bmljYXRpb25zIGFuZCBtZXNzYWdlcyBzaG91bGQgYmUgc2VudCB0byB0
aGUNCj4gK2B4ZW4tZGV2ZWwgPDEwXz5gXyBtYWlsaW5nIGxpc3QsIHdoaWNoIGlzIHRoZSBvbmx5
IG9mZmljaWFsIGNoYW5uZWwgZm9yDQo+ICtjb2RlIHN1Ym1pc3Npb25zLCBhY2tzLCBjb2RlIHJl
dmlld3MsIGFuZCBkZWNpc2lvbi1tYWtpbmcuDQo+ICsNCj4gK0luIHRoZSBtb2Rlcm4gY29ubmVj
dGVkIHdvcmxkIHRoZXJlIGFyZSBzZXZlcmFsIG90aGVyIGNvbW11bmljYXRpb24NCj4gK2NoYW5u
ZWxzIGF2YWlsYWJsZSBhdCBhbnkgZ2l2ZW4gdGltZSwgaW5jbHVkaW5nIG9ubGluZSBtZWV0aW5n
cyBhbmQgSVJDLg0KPiArSG93ZXZlciwgZGlzY3Vzc2lvbnMgb24gbWVkaWEgb3RoZXIgdGhhbiB0
aGUgeGVuLWRldmVsIG1haWxpbmcgbGlzdA0KPiArc2hvdWxkIGJlIHN1bW1hcml6ZWQgYW5kIHNl
bnQgdG8geGVuLWRldmVsIHRvIHJlYWNoIGEgd2lkZXIgYXVkaWVuY2UsDQo+ICtmb3IgcmVjb3Jk
LWtlZXBpbmcsIGFuZCB0byBtYWtlIGNvZGUgc3VibWlzc2lvbnMsIGFja3MsIGFuZCBjb2RlIHJl
dmlld3MNCj4gK29mZmljaWFsLg0KPiArDQo+IENvZGUgcmV2aWV3cyBmb3IgKipyZXZpZXdlcnMq
KiBhbmQgKipwYXRjaCBhdXRob3JzKioNCj4gPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PQ0KPiANCj4gQEAgLTU3NiwzICs1OTAsNCBAQCBob3cgdG8g
YXZvaWQgYW5kIHJlc29sdmUgaXNzdWVzLg0KPiAuLiBfNjogaHR0cHM6Ly94ZW5wcm9qZWN0Lm9y
Zy9oZWxwL2lyYy8NCj4gLi4gXzg6IGh0dHBzOi8vZW4ud2lraXBlZGlhLm9yZy93aWtpL0VyaW5f
TWV5ZXINCj4gLi4gXzk6IGh0dHBzOi8vd3d3Lm5zZi5nb3YvYXR0YWNobWVudHMvMTM0MDU5L3B1
YmxpYy8xNUxGV19Xb3JraW5nV2l0aE11bHRpY3VsdHVyYWxUZWFtc19MYXJzb25DLnBkZg0KPiAr
Li4gXzEwOiBodHRwczovL2xpc3RzLnhlbnByb2plY3Qub3JnL21haWxtYW4vbGlzdGluZm8veGVu
LWRldmVsDQoNCg==


From xen-devel-bounces@lists.xenproject.org Tue Oct 26 07:32:22 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Oct 2021 07:32:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.216264.375798 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfGwW-0006Fm-Ux; Tue, 26 Oct 2021 07:32:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 216264.375798; Tue, 26 Oct 2021 07:32:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfGwW-0006Ff-RS; Tue, 26 Oct 2021 07:32:20 +0000
Received: by outflank-mailman (input) for mailman id 216264;
 Tue, 26 Oct 2021 07:32:20 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=LJH3=PO=iscas.ac.cn=jiasheng@srs-us1.protection.inumbo.net>)
 id 1mfGwV-0006FZ-Th
 for xen-devel@lists.xenproject.org; Tue, 26 Oct 2021 07:32:19 +0000
Received: from cstnet.cn (unknown [159.226.251.25])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTP
 id 67de6bf0-5dcc-4160-a8a4-60959cc4a14d;
 Tue, 26 Oct 2021 07:32:16 +0000 (UTC)
Received: from localhost.localdomain (unknown [124.16.138.128])
 by APP-05 (Coremail) with SMTP id zQCowADX37_8rndhi+4zBQ--.50197S2;
 Tue, 26 Oct 2021 15:32:12 +0800 (CST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 67de6bf0-5dcc-4160-a8a4-60959cc4a14d
From: Jiasheng Jiang <jiasheng@iscas.ac.cn>
To: boris.ostrovsky@oracle.com,
	jgross@suse.com,
	sstabellini@kernel.org
Cc: xen-devel@lists.xenproject.org,
	linux-kernel@vger.kernel.org,
	Jiasheng Jiang <jiasheng@iscas.ac.cn>
Subject: [PATCH v2] xen: Fix implicit type conversion
Date: Tue, 26 Oct 2021 07:32:11 +0000
Message-Id: <1635233531-2437704-1-git-send-email-jiasheng@iscas.ac.cn>
X-Mailer: git-send-email 2.7.4
X-CM-TRANSID:zQCowADX37_8rndhi+4zBQ--.50197S2
X-Coremail-Antispam: 1UD129KBjvJXoW7Kry8CryDZF4DJrW8Ary8AFb_yoW8Xw4Dpa
	yjk34UAryrGa4qka4fJr4kuFyfGayDCrWxWwnrt39YvFn8ury0qFyfJ34Y9ryDur4rC3WI
	vrWqvr17GrsxXrJanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2
	9KBjDU0xBIdaVrnRJUUUkv14x267AKxVWUJVW8JwAFc2x0x2IEx4CE42xK8VAvwI8IcIk0
	rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2AK02
	1l84ACjcxK6xIIjxv20xvE14v26ryj6F1UM28EF7xvwVC0I7IYx2IY6xkF7I0E14v26r4j
	6F4UM28EF7xvwVC2z280aVAFwI0_Cr1j6rxdM28EF7xvwVC2z280aVCY1x0267AKxVW0oV
	Cq3wAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG6I80ewAv7VC0
	I7IYx2IY67AKxVWUJVWUGwAv7VC2z280aVAFwI0_Jr0_Gr1lOx8S6xCaFVCjc4AY6r1j6r
	4UM4x0Y48IcxkI7VAKI48JM4x0x7Aq67IIx4CEVc8vx2IErcIFxwCY02Avz4vE14v_GF4l
	42xK82IYc2Ij64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxVAqx4xG67AKxVWUJV
	WUGwC20s026x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r126r1DMIIYrxkI7VAK
	I48JMIIF0xvE2Ix0cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY6xkF7I0E14v26r1j6r
	4UMIIF0xvE42xK8VAvwI8IcIk0rVWrZr1j6s0DMIIF0xvEx4A2jsIE14v26r1j6r4UMIIF
	0xvEx4A2jsIEc7CjxVAFwI0_Gr0_Gr1UYxBIdaVFxhVjvjDU0xZFpf9x0JUh4SOUUUUU=
X-Originating-IP: [124.16.138.128]
X-CM-SenderInfo: pmld2xxhqjqxpvfd2hldfou0/

The variable 'i' is defined as UINT.
However in the for_each_possible_cpu, its value is assigned to -1.
That doesn't make sense and in the cpumask_next() it is implicitly
type conversed to INT.
It is universally accepted that the implicit type conversion is
terrible.
Also, having the good programming custom will set an example for
others.
Thus, it might be better to change the definition of 'i' from UINT
to INT.

Fixes: 3fac101 ("xen: Re-upload processor PM data to hypervisor after S3 resume (v2)")
Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
---
 drivers/xen/xen-acpi-processor.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/xen/xen-acpi-processor.c b/drivers/xen/xen-acpi-processor.c
index df7cab8..9cb61db 100644
--- a/drivers/xen/xen-acpi-processor.c
+++ b/drivers/xen/xen-acpi-processor.c
@@ -450,7 +450,7 @@ static struct acpi_processor_performance __percpu *acpi_perf_data;
 
 static void free_acpi_perf_data(void)
 {
-	unsigned int i;
+	int i;
 
 	/* Freeing a NULL pointer is OK, and alloc_percpu zeroes. */
 	for_each_possible_cpu(i)
@@ -462,7 +462,7 @@ static void free_acpi_perf_data(void)
 static int xen_upload_processor_pm_data(void)
 {
 	struct acpi_processor *pr_backup = NULL;
-	unsigned int i;
+	int i;
 	int rc = 0;
 
 	pr_info("Uploading Xen processor PM info\n");
@@ -518,7 +518,7 @@ static struct syscore_ops xap_syscore_ops = {
 
 static int __init xen_acpi_processor_init(void)
 {
-	unsigned int i;
+	int i;
 	int rc;
 
 	if (!xen_initial_domain())
-- 
2.7.4



From xen-devel-bounces@lists.xenproject.org Tue Oct 26 07:36:31 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Oct 2021 07:36:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.216271.375810 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfH0W-0006ts-FL; Tue, 26 Oct 2021 07:36:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 216271.375810; Tue, 26 Oct 2021 07:36:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfH0W-0006tl-CL; Tue, 26 Oct 2021 07:36:28 +0000
Received: by outflank-mailman (input) for mailman id 216271;
 Tue, 26 Oct 2021 07:36:26 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=oSYy=PO=suse.com=jgross@srs-us1.protection.inumbo.net>)
 id 1mfH0U-0006tf-Pp
 for xen-devel@lists.xenproject.org; Tue, 26 Oct 2021 07:36:26 +0000
Received: from smtp-out2.suse.de (unknown [195.135.220.29])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id a9ceced7-d44a-40a9-96a0-6a1f7ab28db1;
 Tue, 26 Oct 2021 07:36:25 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id A3DFB1F770;
 Tue, 26 Oct 2021 07:36:24 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 6855B13AA2;
 Tue, 26 Oct 2021 07:36:24 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id 0D+AF/ivd2EtPwAAMHmgww
 (envelope-from <jgross@suse.com>); Tue, 26 Oct 2021 07:36:24 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a9ceced7-d44a-40a9-96a0-6a1f7ab28db1
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1635233784; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=2q8lWCK00Q7JMdpveyzioGkrHrs9Z409UpLTL1vVi5M=;
	b=ocSgYb9YOwRMDtCk5jcuEm7YoWUXGSUa+PZhCUn/62uoJErNVVUkPQzac15sXPb69DOpOC
	XQ9yNeNEgZXaVf4731ZyslfsURtDqwjPM3RqOnzvMVEagGHkwqoK7dqTkdcLBCGiSWIjcE
	Rp0dZLwrcZrWgcyB9s5EbPM4opqbWiE=
Subject: Re: [PATCH v2] xen: Fix implicit type conversion
To: Jiasheng Jiang <jiasheng@iscas.ac.cn>, boris.ostrovsky@oracle.com,
 sstabellini@kernel.org
Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org
References: <1635233531-2437704-1-git-send-email-jiasheng@iscas.ac.cn>
From: Juergen Gross <jgross@suse.com>
Message-ID: <01fd083e-e9a6-c019-0a74-bf28b2982412@suse.com>
Date: Tue, 26 Oct 2021 09:36:23 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <1635233531-2437704-1-git-send-email-jiasheng@iscas.ac.cn>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="lm9BFFHiMkJvWUHXZKfYsHhXaJym50ADK"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--lm9BFFHiMkJvWUHXZKfYsHhXaJym50ADK
Content-Type: multipart/mixed; boundary="bvxUzw7Joa3Sf54C00qULpRRVokTXmDlO";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Jiasheng Jiang <jiasheng@iscas.ac.cn>, boris.ostrovsky@oracle.com,
 sstabellini@kernel.org
Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org
Message-ID: <01fd083e-e9a6-c019-0a74-bf28b2982412@suse.com>
Subject: Re: [PATCH v2] xen: Fix implicit type conversion
References: <1635233531-2437704-1-git-send-email-jiasheng@iscas.ac.cn>
In-Reply-To: <1635233531-2437704-1-git-send-email-jiasheng@iscas.ac.cn>

--bvxUzw7Joa3Sf54C00qULpRRVokTXmDlO
Content-Type: multipart/mixed;
 boundary="------------16042ACA1DC074D9E414D01F"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------16042ACA1DC074D9E414D01F
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 26.10.21 09:32, Jiasheng Jiang wrote:
> The variable 'i' is defined as UINT.
> However in the for_each_possible_cpu, its value is assigned to -1.
> That doesn't make sense and in the cpumask_next() it is implicitly
> type conversed to INT.
> It is universally accepted that the implicit type conversion is
> terrible.
> Also, having the good programming custom will set an example for
> others.
> Thus, it might be better to change the definition of 'i' from UINT
> to INT.
>=20
> Fixes: 3fac101 ("xen: Re-upload processor PM data to hypervisor after S=
3 resume (v2)")
> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>

Reviewed-by: Juergen Gross <jgross@suse.com>


Juergen


--------------16042ACA1DC074D9E414D01F
Content-Type: application/pgp-keys;
 name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Transfer-Encoding: quoted-printable
Content-Description: OpenPGP public key
Content-Disposition: attachment;
 filename="OpenPGP_0xB0DE9DD628BF132F.asc"

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy=
cWx
w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O=
f8Z
d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y=
9bf
IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq=
G7/
377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR=
3Jv
c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA=
QIe
AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT=
hpw
dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0=
MbD
1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv=
oPH
Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v=
5QL
+qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ=
2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC=
QoL
BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr=
Wf0
teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC=
/nu
AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh=
ITT
d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm=
XBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz=
80h
SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC=
AcD
AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn=
FOX
gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1=
jnD
kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0=
N51
N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l=
otu
fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1=
tqS
EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA=
hsD
BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3=
g3O
ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5=
dM7
wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5=
D+j
LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm=
V2x
AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N=
Eaw
QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW=
nHI
s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR=
wgn
BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV=
bVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk=
pEd
IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA=
QAB
wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw=
Tbe
8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1=
vJz
Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8=
VGi
wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW=
svi
uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX=
zXs
ZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------16042ACA1DC074D9E414D01F--

--bvxUzw7Joa3Sf54C00qULpRRVokTXmDlO--

--lm9BFFHiMkJvWUHXZKfYsHhXaJym50ADK
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmF3r/cFAwAAAAAACgkQsN6d1ii/Ey/+
9wf/a55IzFAX2stgWpguceaHGdr1JXmGx2n4XaWG8n39Cx8WnRQQW2D2H0++63zpres8kVAlSNhy
fXExLBTkUS/NW2djRmHUV0TjhvBZT4v8f48g1GfylCRi9ZKj3b4NJ+rSghwnQa2VE0PopYYFUEd3
lyoxOPb0F6v/5RQO/DWxL0j/qGiwN8KZAX3nPsVGXKAbr5rWd1ptndv2zgADAn6uf7dIvYUMqECq
hJTqsjMpGuti66D62dOl2BFqkrbDt7yy3ZjanLRJUgkbtQ1T4Oey44C5RbZgJvHFKBEEZRvrufHC
8e3G2uzJwan2B2kzY1xvl5ZR611Mmp4nfupA2u/hfw==
=U3j8
-----END PGP SIGNATURE-----

--lm9BFFHiMkJvWUHXZKfYsHhXaJym50ADK--


From xen-devel-bounces@lists.xenproject.org Tue Oct 26 07:51:06 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Oct 2021 07:51:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.216278.375821 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfHEZ-0000jE-P7; Tue, 26 Oct 2021 07:50:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 216278.375821; Tue, 26 Oct 2021 07:50:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfHEZ-0000j7-LL; Tue, 26 Oct 2021 07:50:59 +0000
Received: by outflank-mailman (input) for mailman id 216278;
 Tue, 26 Oct 2021 07:50:58 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=d0pl=PO=citrix.com=roger.pau@srs-us1.protection.inumbo.net>)
 id 1mfHEY-0000j1-Dy
 for xen-devel@lists.xenproject.org; Tue, 26 Oct 2021 07:50:58 +0000
Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 2a679813-00f5-4fc6-b57b-1c35dc6b8f64;
 Tue, 26 Oct 2021 07:50:56 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2a679813-00f5-4fc6-b57b-1c35dc6b8f64
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1635234656;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=XMRXnqP50uBsedac2gcVUwVfr+OkQhXNUwC+ZKzBG2k=;
  b=AtCmoQEa3lsfxB+/0uv3hiNoMQMSaxJaj6Gf4a2AGyI1EOZ0QKKrbh7N
   N/zA0/Wh9q3xLNiYOOeWQrLlopv2UvNNYriDWfHdbrzEziGR4PYe96Xx6
   kTgomTJSYqoU5kH7nT1MHnfERrHj6rQJNpcoCFFKfVbQe8Zi34oI4ZZ9V
   Y=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: WLYFi2Y4xNYx/oAemPMAM1t8EbxW5+y7Ol7bl8p6Mkc+1r69GEnc0pREjv2d2UenPWI7/+v7po
 xUqwfVrilSefHw9Rc+Tnmgix2AbSenEBJ12KxXru4bCptFvtpa4QHgaLjrLsg4F6Bc4V5/+EOY
 /TbiVV4evJlsfw8LiylnUuowESo1CxrNHkEocBdjakY8qoaL+bG0SNd3mdppJN09w7Ke0Ng1Hv
 6qohqUt340xc6UDl+i4QztXoLmosRENZ1RmZbYs6y+zxnoeIB54o+1HjggaleID7aEhT5YPN01
 /R3eksUus3KW4FptII1asyxr
X-SBRS: 5.1
X-MesageID: 56078497
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:G3Jb8a3pn/ZNVnXBhfbD5et3kn2cJEfYwER7XKvMYLTBsI5bp2dTz
 jFOUWqCbKqCYGemeNpzboWy9RwB7MfVyoBkTlQ5pC1hF35El5HIVI+TRqvS04J+DSFhoGZPt
 Zh2hgzodZhsJpPkS5PE3oHJ9RGQ74nRLlbHILOCan8ZqTNMEn970Es7wbBh2OaEvPDia++zk
 YKqyyHgEAfNNw5cagr4PIra9XuDFNyr0N8plgRWicJj5TcypFFMZH4rHomjLmOQf2VhNrXSq
 9Avbl2O1jixEx8FUrtJm1tgG6EAaua60QOm0hK6V0U+6/TrS+NbPqsTbZIhhUlrZzqhjpNez
 IR0npqMQCQYZ4fmhb8jSSB1DHQrVUFG0OevzXmXtMWSywvNcmf2wuUoB0YzVWEa0r8pWycUr
 6VecW1TKEDY7w616OvTpu1EnMMsIdOtJIoCknph0SvYHbAtRpWrr6DiuIEAg2ds158m8fD2a
 MgjZGZldUn6PRhCEVkWFZxhsfyuiSyqG9FfgA3M/vdmi4TJ9yR73aLxKtPTdpqPTN9Mg0eDj
 mvc+iLyBRRyHN6VxCeB83msrvTShi69U4UXfJWR7OJnhWq212MaCRAIfVajqPz/gUm7M/paK
 kcU8y5oqrIg+UiDR8P4GRa/pRasuRoRWMFZFeEg3wiLxrDJ+AaSBmUCTTlpZcQvsYk9QjlC/
 kWAn87tQydutrKVYXuH8/GfqjbaESoIKW4PYwcUQA1D5MPsyKkjgxSKQtt9HaqditzuBSq20
 z2MtDI5hbgYkYgMzarT1VnBjyj2/sCRZgEw7wTTGGmi62tReomhYIC57EnB2vxJJo2ZU1qps
 WANno6V6+VmJZaJmS+WSeMBBoa19u2FOz3Rh11oN5Q5/jHr8HmmFahL+y13LkptNscCeBfqb
 VXVtAcX44VcVEZGdocuPdj3UZ5zi/G9S5K1DZg4c+aifLBgNyCDrRhFY3KZ/FG0umIxyp8lA
 LqEJJPE4WkhNYxryz+/RuE42LAtxzwjyW67ea0X3yhLwpLFOybLEeZt3E+mK7ljtvvd8Vq9H
 8N3bpPSk31ivPvCjj47GGL5BWsBKmQnHtjIoshTe//rzuFOSTx5VaG5LV/MfeVYc0VpegXgo
 i7VtqxwkgOXaZj7xeKiMSgLVV8XdcwjxU/XxAR1VbpS51AtYJy08IAUfIYtcL8s+YRLlKAvE
 qBVK5zRU6QeG1wrHgjxirGm9ORfmOmD31rSb0JJnhBmJ/aMuDAlCve7J1CypUHi/wK8tNcko
 q3I6+8oacFreuiWN+6PMKjH5wro5RA1wbsuN2OVcog7UBi9q+BCdn2u5sLb1ulRcH0vMBPBj
 F3IafrZzMGQy7IIHC7h3/DY897ySLsgRSK33QDztN6LCMUTxUL6qadoW+eUZzHNEmTy/aSpf
 +JOyP/gdvYAmT53X0BUSt6HFIoyuInioaF01ANhECmZZlinEOo4cHKHwdNOputGwboA4Vm6X
 UeG+997P7SVOZy6TA5NdVR9NunTh+sJnjTy7OguJBmo7iFA47faA15ZOAOBiXIBIeItYp8l2
 +oopOUf9xe71kgxKt+Dgy0NrzaMI3UMXr8JrJYfBIO32AMnxksbOc7XCzPs4YHJYNJJaxF4L
 jiRjavEprJd2kudLCZjSSmThbJQ3M1ctgpLwVkOI0WytuDE3vJnjgdM9TkXTxhOykkV2exEJ
 WU2ZVZ+Ir+D/mk0iZEbDXysAQxIGDaQ5lf1lwkSjGTcQkSlCj7NIWk6Nbrf9UwV6TsBLD1S/
 bXew2f5Szf6Osr223JqC0JirvXiS/139xHDx5/7T5jUQcFibGq3mLKqaEoJtwDjUJE4i0Dwr
 OV3+Pp9NP/gPikKrqxnU4SX2Nz8kvxfyLCulR25wJ40IA==
IronPort-HdrOrdr: A9a23:39iHaKGa/mjUObWLpLqFDJHXdLJyesId70hD6qkvc3Nom52j+/
 xGws536faVslcssHFJo6HmBEClewKnyXcV2/hrAV7GZmfbUQSTXeNfBOfZsljd8mjFh5NgPM
 RbAtZD4b/LfCFHZK/BiWHSebZQo6j3zEnrv5an854Ed3AUV0gK1XYeNu/0KDwTeOEQbqBJaK
 Z0q/A37AaISDAyVICWF3MFV+/Mq5nik4/nWwcPA1oC5BOVhT2lxbbmG1zAty1uHg9n8PMHyy
 zoggb57qKsv7WSzQLd7Xba69BzlMH6wtVOKcSQgow+KynqiCyveIN9Mofy9gwdkaWK0hIHgd
 PMqxAvM4Ba7G7QRHi8pV/X1wzpwF8Vmgnf4G7dpUGmjd3yRTo8BcYEr5leaAHl500pu8w5+L
 5X3kqC3qAnQy/orWDY3ZzlRhtqnk27rT4JiugIlUFSVoMYdft4sZEfxkVIC50NdRiKp7zPKN
 MeTP002cwmMm9zNxvizytSKZ2XLzgO9y69Mwk/Upf/6UkSoJh7p3Fos/D30E1wsK7VcKM0lN
 gsBJ4Y4I2mfvVmHZ6VO91xM/dfKla9CC4kY1jiaWgOKsk8SgfwQtjMkfII2N0=
X-IronPort-AV: E=Sophos;i="5.87,182,1631592000"; 
   d="scan'208";a="56078497"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=QvAQvCo8FlZimrMz/X1h11h9a6xN9dEljc5UwChqNglUgAWbV+nYc/7CFs8oi57RB9TZY1Rvo7q7LunjXQKOLjI5ecBvm11wK0pG5K95Wz2p/Q/x2WVJZlxTEXeu51a1XQTZ9o2nmJP4PXHLitTofK+DDr8782QVuJ5CA5b/i/lndP3ssEHvz4fnQLBp+cclUYnBw+el7C1wc1ptIX9yK03Uib5NoakWobeLLTCN4aCnnw12tRgqWQBvEio0FVOkGUhgmaCqIwak4vP4EPy7MTjEhrYxIoKT0szmr9nlU9h988Z6dNZUZrc3BAZrjzeU45RCpOEskoox2yO9vuucaA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=gHC3fXAxMyexqu0p8bQKtwUW1tQhHhpEtL6dn1Etdos=;
 b=ZLPQ5V4rtJqFtV9JJdZmpk78sacmfvJAs514hNj+WVSVXOuWEpKwKaudM844na2J+Bn7Wry7xxmUzf95sjgCL5xsAftCvzu+UlfyJdTGSW7tmasoyXrqQaV4Hm3atB4WHkPYMivwGg/Rd8p7mHDvNQtQGjhMmovBgmmGniDGIG7mLJHyuqxyHCJtGpnEq4uRI35GCTnyfwYR3H7ElUkk6mvCN5zQSL8doTe7vHK8T17oLDdyc/7MEOL14JUlwsiP5rEC3Cy7Wcb3DbKNxJdwtDxY9rYE9N5z/tTe+oERvYbMjkWMx3J/X4p3VHIt3+FJ1tr7mu3uQAPvBPXyhP5sew==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=gHC3fXAxMyexqu0p8bQKtwUW1tQhHhpEtL6dn1Etdos=;
 b=vYGyT4r4vkr3FFznOHunB87FFK4YWe/2ArsGG3swA8IbCIzNtZbjs3cD/ks5eev5XzdS81bgkILNblh7dudpjsEYxZeFGGEthsCHW7ZdVgAsKKgH0QOyqLUJPgZYjuTDWHP6y+vWJBPTGjG8zGxKggJC+8QLgJKlTi9mbxJPEJc=
Date: Tue, 26 Oct 2021 09:50:46 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Oleksandr Andrushchenko <andr2000@gmail.com>
CC: <xen-devel@lists.xenproject.org>, <julien@xen.org>,
	<sstabellini@kernel.org>, <oleksandr_tyshchenko@epam.com>,
	<volodymyr_babchuk@epam.com>, <Artem_Mygaiev@epam.com>, <jbeulich@suse.com>,
	<bertrand.marquis@arm.com>, <rahul.singh@arm.com>, Oleksandr Andrushchenko
	<oleksandr_andrushchenko@epam.com>, Michal Orzel <michal.orzel@arm.com>
Subject: Re: [PATCH v3 05/11] vpci/header: Implement guest BAR register
 handlers
Message-ID: <YXezVjnA0E+iV1rI@MacBook-Air-de-Roger.local>
References: <20210930075223.860329-1-andr2000@gmail.com>
 <20210930075223.860329-6-andr2000@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20210930075223.860329-6-andr2000@gmail.com>
X-ClientProxiedBy: MR2P264CA0141.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:500:30::33) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: cd5d7e8a-c332-404d-8e81-08d9985555a0
X-MS-TrafficTypeDiagnostic: DM6PR03MB3577:
X-Microsoft-Antispam-PRVS: <DM6PR03MB35774C8B9A15E7C8C6E71B428F849@DM6PR03MB3577.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8273;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: TzeoxsTW3Wb/VQkzNOKqE37oYjPEQpz41/Ldxw9k700pSkkK09nnJZGw/bRs/sZ6ku26AxIxZ7YQRRnwhuRd0sz38nX9onSUTL8UtDtPfjYULsvYEP5m0hsWqZQUZ5Tj94o6On4Eqp5wSSJfPj48YraKI7WiMjWpVhHavUgsA5E1I/41mDMFzAQ03c72jPwYUBrg7tVMKhmUyArYme54a8qEi6Pdehy7KFvfhIz1r1LTRP8+tuXXPlkLWwKAVK5lzqVBSTKE0zzHjIp04dHUeBmRbzJ6bYzMZCc2Fws278R6aayNnKeYTRTGhKfVZ2ckF25rqDdV3GL7XoKKUJn1z0ylBuEXEGhw5NRT6BlFD8re+7HLdNLYifpKogxMn7TVnDXKNQsFbF77Vl7DlY6N6iGJeF2wNIL0UKL7TFdvtzWLgW/QrgY9OoaM6L2aTHW0wmE6Ji5xf+EgY7yNjslEp2ZG7agm8BzP/3v3Y2J8acofHenyWD4Eb6LMFS8VnnYEfTkDHfEAcZ3W4V1KhOaLAv8F4a9g2iGfdq2S9rjn4jUllqF3T1PllL91dT/YQyZnbd1lQr4Dz57oX8E0f7YucQPrEFdQ+lX0+i6++9UnLo70Kgp9K/mMnRCb9zryr8zJwOi917b+Q7KO5V/hOQySfjfDqjDQlM+gq3jcHQHwJDUAjTKAhG1opBjwHHHx23brUDFiyub7aarKcNYI15wvMg==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(6496006)(6916009)(4326008)(5660300002)(2906002)(82960400001)(38100700002)(66476007)(66946007)(316002)(7416002)(66556008)(54906003)(956004)(86362001)(6666004)(26005)(85182001)(186003)(8676002)(9686003)(508600001)(6486002)(83380400001)(8936002)(67856001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cWVZY2FKQXhBeS9MOEN2V3h0ZmRvUmJ2cUsvdEpmVGoxWU8rWHFreDFvWkI1?=
 =?utf-8?B?cE1kdmNnajZGc01STGcyY0ZKaVlPYmJlU1dEaHowYmhLTEVWV1drU3JCQ3dr?=
 =?utf-8?B?WXZNNUZ6TEdJSlY1Tlo5RGJsZDQvZzFkbGdxdFQyZ3hIOTlhUzEzalZKUkVZ?=
 =?utf-8?B?V1F5U2pqZTNEcjR3Zit1aDB4TnlrSldacUVxM1krTmRrU2VPY1Qya2d2c2F3?=
 =?utf-8?B?REF5MGswdjF4ZXhmREN2UUxlKzd4T3Rndjc5a08zMTdqYlNjbm5GVmozZ3lt?=
 =?utf-8?B?OWR6ZS9EcXJTOHY3cXBGWkJXSlZQUWorWnhNZzVtcnpVdi9MbStoK2h6TDFJ?=
 =?utf-8?B?SlRZRHp0K1BQeFpmdHBxbnFZTEdGT2pISHRHSHlaWDN6TFJMZ1JIa3psL0pv?=
 =?utf-8?B?RFRpQU50ZVgzazZqMmo2eVFUMjBnWkVVOGhjMFgyYTZhaiszMnArL091Rk1v?=
 =?utf-8?B?aC8vakZVWnUrQ0NMTE4vSVJUdFlNK0FHdlFGRjZLeFNuRnJadkErRWRLV1FB?=
 =?utf-8?B?RjkyQitNV2NhdmF0Wkw0NksxSXBsRUhEeVV2Y0NFbzl3V0pMSDljeXRHWG1H?=
 =?utf-8?B?dXlOVm5nYTZGMUgzZ09xeHFrcWlUNWJZUjREcDBza3hjK3lPanFEYm1kY3U5?=
 =?utf-8?B?Y3JXZS8rVWhXZzBTUmNud3lUR0swODZhYmlIdExRQTQwWUVsTjJkeEFuUnA2?=
 =?utf-8?B?YnlpcFdHYWFRVWphbko2TG1BeDJCY09oSzZVNk5raWhNcTRUSmdkUlBiVmxP?=
 =?utf-8?B?QTlMRHpPZmg5QXM3cWlyZnRhdUJ5QVhJSEgzZHpRamgyZUw1MFI1ZTJqMjVM?=
 =?utf-8?B?RlVCdnpDM25VanlJNnJkMXcrdkNDbmNSN1JtN3lrdksxZ21wVUJad3VQS01i?=
 =?utf-8?B?UE5xejduc3hkZy8zYTNIZzdFRGRrOEFnOWV3THQ3WlJzRXB5M3d0WllRNkpo?=
 =?utf-8?B?VnljWmhrZ1dBWDBKYVhRYWJ4RHdPSEU5RXRTMXdzbE9DYWNTaUxDT1FYeHRt?=
 =?utf-8?B?ZkpOR3BweVFJdU9lMHV1N1NuT2JjZ29CTGRmR1BxTjZRV1VyeXIwSUEzeDJx?=
 =?utf-8?B?S05qQUZmSElBclVXWjlaZlRNVTd2WnduYmd0dEtSNTF4RnNNS3l5RmxIRWRm?=
 =?utf-8?B?T1AySEZBUTFVbGd4eHhlbnlxd3NPL29FRlEvTGJUQzl6YmVlMFNlOStReTRt?=
 =?utf-8?B?VFNkNXJlaVk4aVVjMWZwanVmTml6Y2o1TFoyU29SL2xQcGZoUk5OR1ZTQWxX?=
 =?utf-8?B?ZEdybWhwRDNXZER2bGEwVXN0bHFmNGtkYXpsN3ZjSUhZYm15U3Zma0UwbDVn?=
 =?utf-8?B?bDRvOUdLbDVVdmRmR2E1eXladC9NbW5BV0d3T25MaU4yTnhlZ3hWeFk1c0xW?=
 =?utf-8?B?T2phL3pGRUFLQk52cXZ5MHhrbmtTcnNiUDcvd3Q1eHJIVzdxTjA0KzA0bndt?=
 =?utf-8?B?YzVkRmFIY0RNbmgwTENKbjQ1WU1TQVlDZjdoSDVNRkJYa3JabGRoUzk3VURB?=
 =?utf-8?B?dkNHYnROVzJqcStIZktzYTdEM3pkQkF3ZXRIQjN2SUNqM2o1ZW9rd3g2SFlM?=
 =?utf-8?B?ZWZVWTZpeXBjRkZVdWFtekQzSE1xcklIWU45U2JNbUpDTzBFVWhQMnJSdzdU?=
 =?utf-8?B?MDBObm0wa3cyVzBXN3dKM1BTcWU0QUllYlZsejFSRzJaSVFQRnRwd2VVMjRM?=
 =?utf-8?B?Mi9DTHZaTHlINmpObnZubHhTbFlSVmN1Uzd3WW5zYlFsTEJRVFA5TFdKc2o5?=
 =?utf-8?B?ZnhOQXJsR0JCTU4rQVBudDFwR0pWV0N5V3RrSHAzM053YTY3UnFsL1pmQStm?=
 =?utf-8?B?SVcxcXBuL1hBS3VuUG45Snl2U1g3UmhOeVZRaVM1bHRrU3R1UTd2ekZkQVoz?=
 =?utf-8?B?UWNYQVl6akEzTW5uWHZPbmY3cUZJWUtIQnVGeldaRU9GT0VvMk9BRkRKVS9t?=
 =?utf-8?B?OHZxd01oa09KYzNlcVRua2xVWlJvVGNKUjRtcktRZyt0bTBBNEZUYWJEbWpn?=
 =?utf-8?B?a2tKc2R0bHZBaEVveHNIRjA5ak4yeFJyWU94TENXRUJyUURCWW1SZ0dUY2Fk?=
 =?utf-8?B?VGoxTllhQm5PMDl5Z1VhdE1lMnpTczdlS1UzUTVFQ3hKSExBcnd0WGpsZ1N0?=
 =?utf-8?B?aGhrMkVyRnk4M1IwTTlySXpqRGU1ckt1Qml6V1hwUE90TmJCR3d1SG9oUE9y?=
 =?utf-8?Q?cMql0QpPZIwwJ0CwcrHsXiM=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: cd5d7e8a-c332-404d-8e81-08d9985555a0
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2021 07:50:52.7068
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: itwMeqlOtudUDpliWq/geYUMyNknE9qCdD09IJA8t1CZeAqTGQ+N9VgVCtI+oQPlowJ1Rd0yYBwABgfD6Au6tQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB3577
X-OriginatorOrg: citrix.com

On Thu, Sep 30, 2021 at 10:52:17AM +0300, Oleksandr Andrushchenko wrote:
> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> 
> Emulate guest BAR register values: this allows creating a guest view
> of the registers and emulates size and properties probe as it is done
> during PCI device enumeration by the guest.
> 
> ROM BAR is only handled for the hardware domain and for guest domains
> there is a stub: at the moment PCI expansion ROM is x86 only, so it
> might not be used by other architectures without emulating x86. Other
> use-cases may include using that expansion ROM before Xen boots, hence
> no emulation is needed in Xen itself. Or when a guest wants to use the
> ROM code which seems to be rare.
> 
> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> Reviewed-by: Michal Orzel <michal.orzel@arm.com>
> ---
> Since v1:
>  - re-work guest read/write to be much simpler and do more work on write
>    than read which is expected to be called more frequently
>  - removed one too obvious comment
> 
> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> ---
>  xen/drivers/vpci/header.c | 30 +++++++++++++++++++++++++++++-
>  xen/include/xen/vpci.h    |  3 +++
>  2 files changed, 32 insertions(+), 1 deletion(-)
> 
> diff --git a/xen/drivers/vpci/header.c b/xen/drivers/vpci/header.c
> index 1ce98795fcca..ec4d215f36ff 100644
> --- a/xen/drivers/vpci/header.c
> +++ b/xen/drivers/vpci/header.c
> @@ -400,12 +400,38 @@ static void bar_write(const struct pci_dev *pdev, unsigned int reg,
>  static void guest_bar_write(const struct pci_dev *pdev, unsigned int reg,
>                              uint32_t val, void *data)
>  {
> +    struct vpci_bar *bar = data;
> +    bool hi = false;
> +
> +    if ( bar->type == VPCI_BAR_MEM64_HI )
> +    {
> +        ASSERT(reg > PCI_BASE_ADDRESS_0);
> +        bar--;
> +        hi = true;
> +    }
> +    else
> +    {
> +        val &= PCI_BASE_ADDRESS_MEM_MASK;
> +        val |= bar->type == VPCI_BAR_MEM32 ? PCI_BASE_ADDRESS_MEM_TYPE_32
> +                                           : PCI_BASE_ADDRESS_MEM_TYPE_64;
> +        val |= bar->prefetchable ? PCI_BASE_ADDRESS_MEM_PREFETCH : 0;
> +    }
> +
> +    bar->guest_addr &= ~(0xffffffffull << (hi ? 32 : 0));
> +    bar->guest_addr |= (uint64_t)val << (hi ? 32 : 0);
> +
> +    bar->guest_addr &= ~(bar->size - 1) | ~PCI_BASE_ADDRESS_MEM_MASK;
>  }
>  
>  static uint32_t guest_bar_read(const struct pci_dev *pdev, unsigned int reg,
>                                 void *data)
>  {
> -    return 0xffffffff;
> +    const struct vpci_bar *bar = data;
> +
> +    if ( bar->type == VPCI_BAR_MEM64_HI )
> +        return bar->guest_addr >> 32;
> +
> +    return bar->guest_addr;

I think this is missing a check for whether the BAR is the high part
of a 64bit one? Ie:

struct vpci_bar *bar = data;
bool hi = false;

if ( bar->type == VPCI_BAR_MEM64_HI )
{
    ASSERT(reg > PCI_BASE_ADDRESS_0);
    bar--;
    hi = true;
}

return bar->guest_addr >> (hi ? 32 : 0);

Or else when accessing the high part of a 64bit BAR you will always
return 0s as it hasn't been setup by guest_bar_write.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Tue Oct 26 08:10:13 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Oct 2021 08:10:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.216290.375832 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfHX4-0003ZH-Nm; Tue, 26 Oct 2021 08:10:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 216290.375832; Tue, 26 Oct 2021 08:10:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfHX4-0003ZA-Ix; Tue, 26 Oct 2021 08:10:06 +0000
Received: by outflank-mailman (input) for mailman id 216290;
 Tue, 26 Oct 2021 08:10:06 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=93O1=PO=epam.com=prvs=093397e908=oleksandr_andrushchenko@srs-us1.protection.inumbo.net>)
 id 1mfHX3-0003Qr-Pk
 for xen-devel@lists.xenproject.org; Tue, 26 Oct 2021 08:10:05 +0000
Received: from mx0a-0039f301.pphosted.com (unknown [148.163.133.242])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 1b97bc69-73f3-4fad-80ea-ee2588785192;
 Tue, 26 Oct 2021 08:10:02 +0000 (UTC)
Received: from pps.filterd (m0174679.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 19Q84PRt005970; 
 Tue, 26 Oct 2021 08:09:58 GMT
Received: from eur05-am6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2111.outbound.protection.outlook.com [104.47.18.111])
 by mx0a-0039f301.pphosted.com with ESMTP id 3bxdubg112-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Tue, 26 Oct 2021 08:09:57 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by AM4PR0302MB2659.eurprd03.prod.outlook.com (2603:10a6:200:95::7)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.13; Tue, 26 Oct
 2021 08:09:54 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::c038:e032:595a:651]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::c038:e032:595a:651%9]) with mapi id 15.20.4649.014; Tue, 26 Oct 2021
 08:09:54 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1b97bc69-73f3-4fad-80ea-ee2588785192
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Wwawyc75NC/x56t6WWvd09V54xptgMt0ryV4GtYZhW3fipDt27byVj/W7O8w47l8xD9PwizwtZnrrhx4AY2XZ02/tF5Q8JfdNAOkgDUM0g2ROrArNTguB7oBskRDyrS5ERsVUT7MlWeEiaWrvuGnq8xreJ1iCfVYFbpINRShrc2CXAJGHmfdhZ4r+J3BC3F04Y+bYe6LEheCX4bTNj4zpdPUohoDJrzl548nQY1OB9eojtLRPxkGdqy3eYxq1c+/fP57zn6chuUtb46T6hcGImZQ0ktSTWkWl8FBQ8aVXq/qhgsRMEZy7R+H/Q/MAtTxqPsk9TgQBHNUy7iUXgjhcg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=5Ae1HhnUXreFJ83IwHXu9yctXpNNmngAQ5wJbxXDzcQ=;
 b=MbApAl8bsnilEeu6taowRu1vS8NC5u5czUaHLfXdlI8rd7JCD9UjHYuYIqPJvhyGZ3VLpyoK3Vb7A93PSqmNfaYGz8Fvc6tZJmj3bQX9/pXU5SvOuDPj1J7G5hRVzeBfC+BM9zHf1+nSmplkzGLKQkYDflc6jNkAlbCgtCk9ngw65FCJxl/LXjHogfC8m0sN0UwX1ppMWndPSpnHw/QQuR7YZ2EtkpkPx6Wqs7M6nLsrCp3eeAJWiUvxUegyVtKc9eXJabZeVMDi0TkRiTJJuaLiupDx+uRQrk3T+VxUmc18zXx16zEt76JOayhsrXD849reeYwssZLtyjIweFy1lw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=5Ae1HhnUXreFJ83IwHXu9yctXpNNmngAQ5wJbxXDzcQ=;
 b=zi4u09SotZ22Mtl/UpZpH7XXVwy7SL83jxJZ5LMts/MlERKNusw0hFIz9rNdqU4yxx3j61vNaJ2KRXUSzP55h1tnuSmuDQOsBrklJFEriazD7vuEuW4l9PTjJ5/a+EjF1R174B/Q+4bEOZXgvZVGAwcU3E+huNZpTBQWPLvZsjfvrAX7WsDgfsDmyPgs/ypw6veLTRR28ai0+fyEKQJJtzIOcMK8ypu+29t6YaRiA5z7vD7lP//FfMDWRkEkliztsHkCqlTsVtSXxWsGB08vNCMJkugeGC/ItNzEmAkZF5N29MBGKxsCcB/grZ0wy8yXWd7FJyqxTzwVIwDv9/JxlA==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org"
	<sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "jbeulich@suse.com" <jbeulich@suse.com>,
        Bertrand Marquis
	<bertrand.marquis@arm.com>,
        Rahul Singh <rahul.singh@arm.com>,
        Michal Orzel
	<michal.orzel@arm.com>,
        Oleksandr Andrushchenko
	<Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH v3 05/11] vpci/header: Implement guest BAR register
 handlers
Thread-Topic: [PATCH v3 05/11] vpci/header: Implement guest BAR register
 handlers
Thread-Index: AQHXtdAiCK9y7BK95EmkzI7JyqzOjqvlEL4AgAAFV4A=
Date: Tue, 26 Oct 2021 08:09:54 +0000
Message-ID: <150126cf-68c0-95b2-29f8-e2be61b55b54@epam.com>
References: <20210930075223.860329-1-andr2000@gmail.com>
 <20210930075223.860329-6-andr2000@gmail.com>
 <YXezVjnA0E+iV1rI@MacBook-Air-de-Roger.local>
In-Reply-To: <YXezVjnA0E+iV1rI@MacBook-Air-de-Roger.local>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 6f0196c6-7993-4b25-4e34-08d99857fe1e
x-ms-traffictypediagnostic: AM4PR0302MB2659:
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <AM4PR0302MB2659FE3BA53FF4F4E37682E3E7849@AM4PR0302MB2659.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:8882;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 68EgTuPhBrSEw2ue4Cr500uInwz+zk9V4E+ZsgNDfkLlMz0Gt2YVyB1Eo1A9+kNht2pQR2s2Z/AWWKpPcIP7xrRuorq3/8WpCG/yy4YPTLJFdxwui5rFokNcRzmyULF55+VmJtpFBvjhhis/P2PqPHTn4E7NXUdw9cysXcvV/6MmYJUNDBVzorIuU5PoTJ+61l5JzhsIuq+AJ8eQV5UdWdkfBbfIu4izD9gbx9ppwkS8SKjH2L5/DI4UWdVZut8IMPb2jmRuxLimFlX6VbLTiw4AL0TSiyUfw6G85DL8hNV6FrTJVo9a/zkFQ+Y7IVtwMSmvl4DzC0AbmFSYaH1GCHfx6+OZcRz7zIbTdwb6gWWTsMIOkOfZt9rdaSLbEV6cA3rCfAlkF6rtA2CA8c94louqhDtHR1DHc5TV135PYyDkUyKWJPwpAF2AZC2CWoMePnELkKocYsgvPHstD81KGB9a0vD3TjuqQNehoyq4PY/qCxXlJPjTMD0FZ7+eG+76AwTqROfC0iZWnPZlmWPMat2LZ1nouR+uzEd31kDYQYMOXlYAtXtM7HCxMA132a+Ph1GzURn5EWX5gUW3DqqAHGtNYz46vCHz8MC9lbSYcPnS1MvfTZsnuJIF93bKN9K4n/lVnrNnUVnCjF/PX7tEqIlZlfd2gIGSM/cSkbLDibGZdljLem7XBqj3Gqec4Z1wJF0Jvz1Uw55e/2z1Dv3eZHsvb4UYjf0nUFhRW15HMbvSVFU4kwtB0mM/EUmcyeH/
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(36756003)(71200400001)(2906002)(83380400001)(26005)(6506007)(53546011)(2616005)(38070700005)(86362001)(31696002)(54906003)(316002)(186003)(6512007)(64756008)(31686004)(6916009)(66446008)(66946007)(66556008)(66476007)(76116006)(91956017)(122000001)(38100700002)(4326008)(107886003)(8936002)(6486002)(8676002)(508600001)(5660300002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?cVNNZ0FycDkwV0w4dXFSMVMyZ216bE9YRGc1Q3c0K2RtYmZKdXEyMHZwRmNQ?=
 =?utf-8?B?dm9Uejk4LzhnMkFEdFVGbWpySW1UN1dvRWZUd0lRVHNGazI5RFdWMWJlenFx?=
 =?utf-8?B?U2lWeEY3Nkd2UkI4VnovWUM1aGloa0pjcXVDclB1dGpmQUtHUFllSkQrZ1hM?=
 =?utf-8?B?ODVxZU9yNW92U1pYU1pWSmJVY3VVcEZUWDBWbEU5c01zVnNoelplaG5jMGNR?=
 =?utf-8?B?N3BDTkI3eDQxQXU2YSthaXFLOFBtWmpJaVFNSHRndXlCWldRSUZoM0EydURM?=
 =?utf-8?B?YzFWRWZpUGlRK1lZNHJyb0diQVFQalZsekhwUTloZlRUWlhMWU5CVjNEalNl?=
 =?utf-8?B?TVoyZ1dGYzhVWlNmUkNZYnhXQXVGZG10cUFvNHhxT3pwbnRYTWU5YWdIc2oz?=
 =?utf-8?B?YVNhbXg0L1FLV2h2UXR4bEFteWthOEp6TkRlYU5Wc3UzSEZRak51bm1kdDJ0?=
 =?utf-8?B?TGtWdFdxWW9Zc0tITTNUNFlGSE1pMUExWFJaNENEdzNDODBla0xLWFVpY0N4?=
 =?utf-8?B?RWJWTUphclFoKzBXUTNnVWp5cm1wVVVtSGdvaWExcFFQK1FCclAvZWFlT1ZO?=
 =?utf-8?B?RldxaFozZ0FsYW8vMFBuaHdGemxyeXlVbm5obGlxRlQ0bElHa29rMS9rTVhl?=
 =?utf-8?B?dEZ4SENiNHJOaytTYng3WFNlODNLZWVwOG0vM0xBcklrRUdOblJOZ1pRV3Ev?=
 =?utf-8?B?S2NWZkhtWDdEUGxkUG1oUXY0VGdya1Y3YmQ0eTJNZ0pNYVNGdUdBY2dsMm1Z?=
 =?utf-8?B?TzhDaE44TzltQ2ViRkRFUWNEU1dGTUtMTHBMKzU5cklWcktyMGlaMXpJTVNQ?=
 =?utf-8?B?NE4waEdncTUvcG93YmRVbFRnZEU0RnFnV0RqbElpUERaeXdwSzQrcmxKL3Rl?=
 =?utf-8?B?UmRrOGtBS0MyWURRQXFqSitHQ2w3RlpYdlpCa3V6dm9nTWVJTUR6dDhRL3ZY?=
 =?utf-8?B?VGJuRTdsbi83aEt6VGRmM2FsU29vUnU3cDdTeXpMdDhjQXVDUTYrVHoyNGVl?=
 =?utf-8?B?L2o3TlVOZTJjT2lXUjNvZ09pZDZYbnBhZmlBSkVFYmU0M2liU3N4WG9zeWRX?=
 =?utf-8?B?cXlQaXNpelBJSk5Bbnp6R2NscGtMamhrc0RuY0hOeEJqNE1KRkJrUThsZjg2?=
 =?utf-8?B?VXR5OXJPbnVwMHV6Vm5HNHN4MWNxZmEwYW1SL2dpTVNNU1VtSDlqY1NyVTN6?=
 =?utf-8?B?Tys0TklvZHRYUjZWTFNxenJlNitPb01aYzdhdGpuMEdsTmFucUFSY2piRlZr?=
 =?utf-8?B?elpvL1R6QXlxU09qYUJtWlJzbnplcXF1SXcxVnVRd1JHenN5dTh4YXUvWU50?=
 =?utf-8?B?aCtQMHVFcXc3S1NQbjYyandFa000MnBuNVhtOEtpS1BydUtCNGtYUmpka2xS?=
 =?utf-8?B?Q1lzalYzbVd4RnB2eUxKcVBjN3lKMUt4UzJCV2ZZWlFUb05oUnh1bVRwMEpj?=
 =?utf-8?B?N1lGSllUY05GZ3JWSHkrT1pha2VIVDBJRmZodUdEeHN1LzluVFprM05SY1lU?=
 =?utf-8?B?cXVEU24vSlhYbUNGZEtpVFZCN0VEVmU0cDVWYXZqNGFya25GWEV5ZG9HMGQx?=
 =?utf-8?B?ckY0UHpKdDBoWWdwOFpqazVhNG9tQWxOeEdUcWE5amEzUW1nNnVteGM1Tmtt?=
 =?utf-8?B?ZzBXeklabFA4WFF0Qmo2N0NQOTlXVWppZGs2RmpiUm1teUZ3RzFWeWlVUFZr?=
 =?utf-8?B?UHpia3EreDF1MEx3VzFjWm1FYUtEN20wTmhTekR5RDl6aGdyMjNLVWIyVXZ2?=
 =?utf-8?B?U3gvVU5ONE8zM3R2ay84bVViK05WUzdCMm5vYWQ1MDJtemhyOXdseU1qNUFB?=
 =?utf-8?B?NUZzSEpSeTd5ODNxditsVk9yM01Cc1luT2VUb1NkU2FXQUNEUEdPZkU2OUlJ?=
 =?utf-8?B?dEdNVHljek92aFVuV0FXd0tSMWE1TDBteFQwWk1YM0RxY2l2WWlyZjVaWDZq?=
 =?utf-8?B?c1J0U1lqMmhYdkxhbFhFMnhSTUdpUkU1V21jb0lVdk5yQ1JIWkovQ0s1SkFW?=
 =?utf-8?B?TWZZYU5GaWViWE5oZWUvY29idXFiU1RMaXFCbjhkcWZZYXl4MGRrU1pVa1Jh?=
 =?utf-8?B?WW0vWXpOc1QrQVo4OTFDNmhjVVBUN3NoOU9RdzBacW11M3lLdk1OOGtGWHY5?=
 =?utf-8?B?OHFweW1nVnQzWUFZU1NyWUtuZGxZdU5qL0Fnc2M0T3FUdUxPRmQzZEF3UU9k?=
 =?utf-8?B?WmVoMzFxT0tKQ3d5a2VzdlBkdEhxNFlma3hsSmE2RlgyMmtOQyswWE5UUjgr?=
 =?utf-8?B?YTZIbmQycktNaC95cDRTVHRSK2FWVnRuV2xYdzY2Q1RrYU9NUDYrWjBkMXZU?=
 =?utf-8?B?Y0cxdUdUR1Ira2lFZjl0SHpreVBjWEVpM0FiTlhqSk9FdnJzcFRQUT09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <A6B4185DAB59A84A96ED5A0F675B3B1A@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6f0196c6-7993-4b25-4e34-08d99857fe1e
X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Oct 2021 08:09:54.0719
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: tFGY35Y/CLdtwguoFS98H21RPUPe1oqmUis+7+LSq2U9adsw1ANMy5ARlGutW7ViuYs0p9zcVya58vTjut4f1OHeEpr3o0/iRYDomY+7/umw1hZtP4D8Y1CKmjWfOVp+
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR0302MB2659
X-Proofpoint-ORIG-GUID: A3lp6RhRUNNMLzdiqcnBMIhrgB8AP7LL
X-Proofpoint-GUID: A3lp6RhRUNNMLzdiqcnBMIhrgB8AP7LL
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475
 definitions=2021-10-25_08,2021-10-25_02,2020-04-07_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 spamscore=0
 clxscore=1015 lowpriorityscore=0 adultscore=0 impostorscore=0
 malwarescore=0 bulkscore=0 phishscore=0 mlxscore=0 priorityscore=1501
 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2110260045

DQoNCk9uIDI2LjEwLjIxIDEwOjUwLCBSb2dlciBQYXUgTW9ubsOpIHdyb3RlOg0KPiBPbiBUaHUs
IFNlcCAzMCwgMjAyMSBhdCAxMDo1MjoxN0FNICswMzAwLCBPbGVrc2FuZHIgQW5kcnVzaGNoZW5r
byB3cm90ZToNCj4+IEZyb206IE9sZWtzYW5kciBBbmRydXNoY2hlbmtvIDxvbGVrc2FuZHJfYW5k
cnVzaGNoZW5rb0BlcGFtLmNvbT4NCj4+DQo+PiBFbXVsYXRlIGd1ZXN0IEJBUiByZWdpc3RlciB2
YWx1ZXM6IHRoaXMgYWxsb3dzIGNyZWF0aW5nIGEgZ3Vlc3Qgdmlldw0KPj4gb2YgdGhlIHJlZ2lz
dGVycyBhbmQgZW11bGF0ZXMgc2l6ZSBhbmQgcHJvcGVydGllcyBwcm9iZSBhcyBpdCBpcyBkb25l
DQo+PiBkdXJpbmcgUENJIGRldmljZSBlbnVtZXJhdGlvbiBieSB0aGUgZ3Vlc3QuDQo+Pg0KPj4g
Uk9NIEJBUiBpcyBvbmx5IGhhbmRsZWQgZm9yIHRoZSBoYXJkd2FyZSBkb21haW4gYW5kIGZvciBn
dWVzdCBkb21haW5zDQo+PiB0aGVyZSBpcyBhIHN0dWI6IGF0IHRoZSBtb21lbnQgUENJIGV4cGFu
c2lvbiBST00gaXMgeDg2IG9ubHksIHNvIGl0DQo+PiBtaWdodCBub3QgYmUgdXNlZCBieSBvdGhl
ciBhcmNoaXRlY3R1cmVzIHdpdGhvdXQgZW11bGF0aW5nIHg4Ni4gT3RoZXINCj4+IHVzZS1jYXNl
cyBtYXkgaW5jbHVkZSB1c2luZyB0aGF0IGV4cGFuc2lvbiBST00gYmVmb3JlIFhlbiBib290cywg
aGVuY2UNCj4+IG5vIGVtdWxhdGlvbiBpcyBuZWVkZWQgaW4gWGVuIGl0c2VsZi4gT3Igd2hlbiBh
IGd1ZXN0IHdhbnRzIHRvIHVzZSB0aGUNCj4+IFJPTSBjb2RlIHdoaWNoIHNlZW1zIHRvIGJlIHJh
cmUuDQo+Pg0KPj4gU2lnbmVkLW9mZi1ieTogT2xla3NhbmRyIEFuZHJ1c2hjaGVua28gPG9sZWtz
YW5kcl9hbmRydXNoY2hlbmtvQGVwYW0uY29tPg0KPj4gUmV2aWV3ZWQtYnk6IE1pY2hhbCBPcnpl
bCA8bWljaGFsLm9yemVsQGFybS5jb20+DQo+PiAtLS0NCj4+IFNpbmNlIHYxOg0KPj4gICAtIHJl
LXdvcmsgZ3Vlc3QgcmVhZC93cml0ZSB0byBiZSBtdWNoIHNpbXBsZXIgYW5kIGRvIG1vcmUgd29y
ayBvbiB3cml0ZQ0KPj4gICAgIHRoYW4gcmVhZCB3aGljaCBpcyBleHBlY3RlZCB0byBiZSBjYWxs
ZWQgbW9yZSBmcmVxdWVudGx5DQo+PiAgIC0gcmVtb3ZlZCBvbmUgdG9vIG9idmlvdXMgY29tbWVu
dA0KPj4NCj4+IFNpZ25lZC1vZmYtYnk6IE9sZWtzYW5kciBBbmRydXNoY2hlbmtvIDxvbGVrc2Fu
ZHJfYW5kcnVzaGNoZW5rb0BlcGFtLmNvbT4NCj4+IC0tLQ0KPj4gICB4ZW4vZHJpdmVycy92cGNp
L2hlYWRlci5jIHwgMzAgKysrKysrKysrKysrKysrKysrKysrKysrKysrKystDQo+PiAgIHhlbi9p
bmNsdWRlL3hlbi92cGNpLmggICAgfCAgMyArKysNCj4+ICAgMiBmaWxlcyBjaGFuZ2VkLCAzMiBp
bnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pDQo+Pg0KPj4gZGlmZiAtLWdpdCBhL3hlbi9kcml2
ZXJzL3ZwY2kvaGVhZGVyLmMgYi94ZW4vZHJpdmVycy92cGNpL2hlYWRlci5jDQo+PiBpbmRleCAx
Y2U5ODc5NWZjY2EuLmVjNGQyMTVmMzZmZiAxMDA2NDQNCj4+IC0tLSBhL3hlbi9kcml2ZXJzL3Zw
Y2kvaGVhZGVyLmMNCj4+ICsrKyBiL3hlbi9kcml2ZXJzL3ZwY2kvaGVhZGVyLmMNCj4+IEBAIC00
MDAsMTIgKzQwMCwzOCBAQCBzdGF0aWMgdm9pZCBiYXJfd3JpdGUoY29uc3Qgc3RydWN0IHBjaV9k
ZXYgKnBkZXYsIHVuc2lnbmVkIGludCByZWcsDQo+PiAgIHN0YXRpYyB2b2lkIGd1ZXN0X2Jhcl93
cml0ZShjb25zdCBzdHJ1Y3QgcGNpX2RldiAqcGRldiwgdW5zaWduZWQgaW50IHJlZywNCj4+ICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgIHVpbnQzMl90IHZhbCwgdm9pZCAqZGF0YSkNCj4+
ICAgew0KPj4gKyAgICBzdHJ1Y3QgdnBjaV9iYXIgKmJhciA9IGRhdGE7DQo+PiArICAgIGJvb2wg
aGkgPSBmYWxzZTsNCj4+ICsNCj4+ICsgICAgaWYgKCBiYXItPnR5cGUgPT0gVlBDSV9CQVJfTUVN
NjRfSEkgKQ0KPj4gKyAgICB7DQo+PiArICAgICAgICBBU1NFUlQocmVnID4gUENJX0JBU0VfQURE
UkVTU18wKTsNCj4+ICsgICAgICAgIGJhci0tOw0KPj4gKyAgICAgICAgaGkgPSB0cnVlOw0KPj4g
KyAgICB9DQo+PiArICAgIGVsc2UNCj4+ICsgICAgew0KPj4gKyAgICAgICAgdmFsICY9IFBDSV9C
QVNFX0FERFJFU1NfTUVNX01BU0s7DQo+PiArICAgICAgICB2YWwgfD0gYmFyLT50eXBlID09IFZQ
Q0lfQkFSX01FTTMyID8gUENJX0JBU0VfQUREUkVTU19NRU1fVFlQRV8zMg0KPj4gKyAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICA6IFBDSV9CQVNFX0FERFJFU1NfTUVN
X1RZUEVfNjQ7DQo+PiArICAgICAgICB2YWwgfD0gYmFyLT5wcmVmZXRjaGFibGUgPyBQQ0lfQkFT
RV9BRERSRVNTX01FTV9QUkVGRVRDSCA6IDA7DQo+PiArICAgIH0NCj4+ICsNCj4+ICsgICAgYmFy
LT5ndWVzdF9hZGRyICY9IH4oMHhmZmZmZmZmZnVsbCA8PCAoaGkgPyAzMiA6IDApKTsNCj4+ICsg
ICAgYmFyLT5ndWVzdF9hZGRyIHw9ICh1aW50NjRfdCl2YWwgPDwgKGhpID8gMzIgOiAwKTsNCj4+
ICsNCj4+ICsgICAgYmFyLT5ndWVzdF9hZGRyICY9IH4oYmFyLT5zaXplIC0gMSkgfCB+UENJX0JB
U0VfQUREUkVTU19NRU1fTUFTSzsNCj4+ICAgfQ0KPj4gICANCj4+ICAgc3RhdGljIHVpbnQzMl90
IGd1ZXN0X2Jhcl9yZWFkKGNvbnN0IHN0cnVjdCBwY2lfZGV2ICpwZGV2LCB1bnNpZ25lZCBpbnQg
cmVnLA0KPj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdm9pZCAqZGF0YSkNCj4+
ICAgew0KPj4gLSAgICByZXR1cm4gMHhmZmZmZmZmZjsNCj4+ICsgICAgY29uc3Qgc3RydWN0IHZw
Y2lfYmFyICpiYXIgPSBkYXRhOw0KPj4gKw0KPj4gKyAgICBpZiAoIGJhci0+dHlwZSA9PSBWUENJ
X0JBUl9NRU02NF9ISSApDQo+PiArICAgICAgICByZXR1cm4gYmFyLT5ndWVzdF9hZGRyID4+IDMy
Ow0KPj4gKw0KPj4gKyAgICByZXR1cm4gYmFyLT5ndWVzdF9hZGRyOw0KPiBJIHRoaW5rIHRoaXMg
aXMgbWlzc2luZyBhIGNoZWNrIGZvciB3aGV0aGVyIHRoZSBCQVIgaXMgdGhlIGhpZ2ggcGFydA0K
PiBvZiBhIDY0Yml0IG9uZT8gSWU6DQo+DQo+IHN0cnVjdCB2cGNpX2JhciAqYmFyID0gZGF0YTsN
Cj4gYm9vbCBoaSA9IGZhbHNlOw0KPg0KPiBpZiAoIGJhci0+dHlwZSA9PSBWUENJX0JBUl9NRU02
NF9ISSApDQo+IHsNCj4gICAgICBBU1NFUlQocmVnID4gUENJX0JBU0VfQUREUkVTU18wKTsNCj4g
ICAgICBiYXItLTsNCj4gICAgICBoaSA9IHRydWU7DQo+IH0NCj4NCj4gcmV0dXJuIGJhci0+Z3Vl
c3RfYWRkciA+PiAoaGkgPyAzMiA6IDApOw0KPg0KPiBPciBlbHNlIHdoZW4gYWNjZXNzaW5nIHRo
ZSBoaWdoIHBhcnQgb2YgYSA2NGJpdCBCQVIgeW91IHdpbGwgYWx3YXlzDQo+IHJldHVybiAwcyBh
cyBpdCBoYXNuJ3QgYmVlbiBzZXR1cCBieSBndWVzdF9iYXJfd3JpdGUuDQpZZXMsIHlvdSBhcmUg
cmlnaHQNCj4gVGhhbmtzLCBSb2dlci4NClRoYW5rIHlvdSwNCk9sZWtzYW5kcg==


From xen-devel-bounces@lists.xenproject.org Tue Oct 26 08:47:18 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Oct 2021 08:47:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.216301.375847 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfI6r-0006y6-HI; Tue, 26 Oct 2021 08:47:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 216301.375847; Tue, 26 Oct 2021 08:47:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfI6r-0006xz-EB; Tue, 26 Oct 2021 08:47:05 +0000
Received: by outflank-mailman (input) for mailman id 216301;
 Tue, 26 Oct 2021 08:47:04 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mfI6q-0006xp-AQ; Tue, 26 Oct 2021 08:47:04 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mfI6q-0004d1-3Q; Tue, 26 Oct 2021 08:47:04 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mfI6p-0001p3-Qj; Tue, 26 Oct 2021 08:47:03 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mfI6p-0007iX-QI; Tue, 26 Oct 2021 08:47:03 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=OOChzdQgjrii9ObISdNMoZ89svA5j60tfcoWDryqW2U=; b=UMaV192zFeSetfTnrXgIR/tVjb
	oFCB0R93g06oLMC27srCLlhLzVqNL39l89dCpmf4A7Ldb/uOlVCcD8KHDciJRRuQ9PBLDrz2OR53P
	gEikbdi1RmOTiw4aAt2bmYePYUwqTvDxsoEpkUvWuUvfvlSz0CnyVh8QjE2iRZYLIMcc=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165864-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 165864: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=b0fce57a6a491c120f2554ad7cc9a0c43ee5defa
X-Osstest-Versions-That:
    xen=23ec1ebc8acbfd2bf06f6085a776f0db923f9fa9
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 26 Oct 2021 08:47:03 +0000

flight 165864 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165864/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 165850
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 165850
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165850
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165850
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 165850
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 165850
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 165850
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 165850
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 165850
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 165850
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 165850
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165850
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 xen                  b0fce57a6a491c120f2554ad7cc9a0c43ee5defa
baseline version:
 xen                  23ec1ebc8acbfd2bf06f6085a776f0db923f9fa9

Last test of basis   165850  2021-10-25 01:51:43 Z    1 days
Testing same since   165864  2021-10-25 20:07:52 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Anthony PERARD <anthony.perard@citrix.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   23ec1ebc8a..b0fce57a6a  b0fce57a6a491c120f2554ad7cc9a0c43ee5defa -> master


From xen-devel-bounces@lists.xenproject.org Tue Oct 26 09:08:41 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Oct 2021 09:08:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.216312.375860 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfIRg-0000zr-Gn; Tue, 26 Oct 2021 09:08:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 216312.375860; Tue, 26 Oct 2021 09:08:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfIRg-0000zk-Dk; Tue, 26 Oct 2021 09:08:36 +0000
Received: by outflank-mailman (input) for mailman id 216312;
 Tue, 26 Oct 2021 09:08:35 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=d0pl=PO=citrix.com=roger.pau@srs-us1.protection.inumbo.net>)
 id 1mfIRf-0000ze-5g
 for xen-devel@lists.xenproject.org; Tue, 26 Oct 2021 09:08:35 +0000
Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 4a60e4e4-363c-11ec-8428-12813bfff9fa;
 Tue, 26 Oct 2021 09:08:33 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4a60e4e4-363c-11ec-8428-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1635239313;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=lBHrAXnJwyE79kBw8uElhLP6I5Ou6vvZtflZ1PvWTrM=;
  b=VuJrV8Kb8hJzHyFpbAfn/15uSlA2Ki9Xdq5glMvOaJekxKCettXdzJbw
   3ToO2ZJmjB6cXAImFn2qSdfJGfsvCQtbDDP3H7gGXG73DBu9IdunhVg+g
   hLRil25Bxz19NqL/quvO9cQy2BbYp3iwI4atyNaMTcIUhfnzHbXDGbsg9
   Q=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: S08Cj1bUdPU3NXIR830ffSn45wsowkmepDrf/BlSpPzFUaPeGUIe8G3adRpp6IS8obsbq4vqn0
 //CygMqrYlrFBx32n26kZKJPyIco5tiMMQWXKwdfAL6k7feH2wf57M7yHdhe6kCnHCZfSlTUcf
 QJm2TlL+NU4J7UdWATmzqOjdjcNpWxi9iqXpvWvReUAFW7odz9OUeDHfciQ78x2ruAkhCVRQ5k
 ca3C+MABVDW0dZtMUsIdRkyd+1xRlfS2RsdfCPuwwQ9nT58UU4zl+/RT4zjd24FqCXhT7b8wlu
 +w/K7Arb2v19SEWhxIpIxTmq
X-SBRS: 5.1
X-MesageID: 56454941
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:BIaFJKl50bH+bkywh4FmzxDo5gyjIERdPkR7XQ2eYbSJt1+Wr1Gzt
 xJJCGzVM/vfY2v8ctF/Ot608xkB7ZHdmtBiSQRvrXtmFiMWpZLJC+rCIxarNUt+DCFioGGLT
 Sk6QoOdRCzhZiaE/n9BClVlxJVF/fngqoDUUYYoAQgsA187IMsdoUg7wbdg2tQ22YLR7z6l4
 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc
 s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4
 NNur8DrcD85Aoj3udRabwNxDB1eOIQTrdcrIVDn2SCS50jPcn+qyPRyFkAme4Yf/46bA0kXq
 6ZecmpUKEne2aTmm9pXScE17ignBNPsM44F/Glp0BnSDOo8QICFSKLPjTNd9Gpu2p0STKqHD
 yYfQWF0fg/qbDJyBkksCMI4htmKnmHjWjIN/Tp5ooJoujOOnWSdyoPFMtDYZ9iLTsV9hVuDq
 yTN+GGRKjgAKNGa/h+U/Xuti/HnkDvyXcQZE7jQ3vRnmkGJz2ofThgfT0KmoOKRg1S7HdlYL
 iQ8/S4jrrM78kCxedD7Uwelu36PvhMaWN14HvUz7UeGza+8yxyQBnUACCVAbtMmnMYsQHoh0
 Vrht83uATtjobiEU0WX/72frS6xESUNJGpEbigBJSMV7t+mrIwtgxbnStd4DLXzntDzASv3w
 T2BsG45nbp7pccN27/hpQifqz2pr5nNCAUy423/XH+h7w5/TJ6oYcqv81ezxfFEIYWCR1+Np
 k8YitOe5+ADC5KKvCGVSeBLF7asj96eKyHVi1NrG5gn9hyu9mSlcIQW5ytxTHqFKe5dJ2WvO
 hWK/1oMutkDZxNGcJObfaq3KN52lpHYBejAbdHkKeZUS4dNVAquqXQGiVGr40jhl00lkKcaM
 JidcNqxAXtyNZmL3AZaVM9Gjud1nnFWKXf7AMmhlUz+gOX2iGu9EO9daDOzgvYFALRoSek/2
 +1UMNeW0F1hWen6bzi/HWU7fA1ScyZT6XwbraVqmg+/zuhORD5J5xz5m+pJl2lZc0N9zb+gw
 51FchUEoGcTfFWeQelwVlhtaan0QbF0pm8hMConMD6AgiZ4PN//vP5OJstmLNHLEdCPKtYvF
 5E4lzioWKwTGlwrBRxENfERU7COhDz03FnTbkJJkRA0foJ6RhyhxzMXVlCHycX6NQLu7ZFWi
 +T5jmvzGMNfLyw/XJe+QK/+lDuZ4ClC8N+eqmOVe7G/jm23q9M0Q8Ew59dqS/wxxeLrnGvGi
 1/NWkdG/oEgYeYdqbH0uExNlK/we8NWFUtGBWjLq7GwMCjR5G24xoFcFu2PeFjguKnco81Ov
 M1ZkKPxNuMphlFPv9YuGrpn1/tmtdDuu6Vb3kJvG3CSNwanDbZpI3+n28hTt/ISmu8F6FXuA
 k/fqMNHPbipOd/+FAJDLgQSceneh+ofnSPf7KppLRyitjN35reOTW5bIwKI1H5GNLJwPY58m
 bUhtcca5haRkB0vNtra3ClY+37Vdi4LUrk9t4FcC4ju01J5xlZHaJ3aKyn3/JDQNIkcbhh0e
 meZ3fOQia5dy0zOd2sIOULMhecN144TvB1qzUMZIwjbkNTymfJqjgZa9i46T1oJw0wfgf5zI
 GViK2Z8Ob6Ko2VznMFGUm2hR1NBCRme9hCjwlcFjjSEHUyhV2iLJ2whI+edukse9jsELDRc+
 biZzkfjUCrrI56tjndjBxY9pqyxV8F1+y3DhNujTpaMEJQNaDb4hrOjODgToBz9DMJt3EDKq
 IGGJgqrhXEX4cLIn5AGNg==
IronPort-HdrOrdr: A9a23:rNghGKilGlUK17eRFnncDfjuh3BQXzx13DAbv31ZSRFFG/FwyP
 rBoB1L73DJYWgqNE3I+erhBEGBKUmsk6KdxbNhQItKPTOWwldASbsC0WKM+UyEJ8STzJ846U
 4kSdkDNDSSNykKsS+Z2njBLz9I+rDum8rE9ISurQYccegpUdAa0+4QMHfkLqQcfng+OXNWLu
 v62iIRzADQBkj/I/7LTEUtbqzmnZnmhZjmaRkJC1oO7xSPtyqh7PrfHwKD1hkTfjtTyfN6mF
 K13zDR1+GGibWW2xXc32jc49B/n8bg8MJKAIiphtIOIjvhpw60bMBKWqGEvhoyvOazgWxa3e
 XkklMFBYBe+nnRdma6rV/E3BTh6i8n7zvYxVqRkRLY0IXEbQN/L/AEqZNScxPf5UZllsp7yr
 h302WQsIcSJQ/cnQzmjuK4Fi1Cpw6Rmz4PgOQTh3tQXc81c7lKt7ES+0tTDdMpAD/60oY6C+
 NjZfusqsq+SWnqLEwxg1MfguBFBh8Ib1K7qwk5y4OoOgFt7TBEJxBy/r1aop8CnKhNPaWsqd
 60dZiAr4s+PPP+W5gNc9vpcfHHeVAlfii8RV56AW6XXJ3vaEi94KIe3t0OlZWXkdozvd0PpK
 g=
X-IronPort-AV: E=Sophos;i="5.87,182,1631592000"; 
   d="scan'208";a="56454941"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=hXXDdjMm1JjEh7tH7WUJGURSX3/a+L9dCondF6FrEevWoheIzpenFQsdIdQO3+hd7kjOUPlcwiJULK9GU8FM0Yn2qAdfFvUy8vrWowc0JwtkSL66OCzUDTA32yMJVK7Lv297Y5APdIkChb4ntx/WrFaX4ha2Mzf7sqs4cWtPVS4TIbFI4uN63GpVXB1hLeEwC3eyo1B15JzZ0GYNI2ImVUL25fcMb0YB4W8TPURoeiIhLvuSAfeHH/bUcL3iw3WaFlGE/6umtv/ormXiJINocVNT9NLNT2bmwYd0lXkfzBRjdGQGOwCuJWPTLJ0UA8cwpkRssai+zTesdyclDeMiHQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=5pKIBBJn7BLOEhhGj5/OC5EWg4ItyB1Vw8Kdm/u2BRo=;
 b=JH/6Sif85RJX1XuiYVLowzI0AhbDudc+522MvCXEXvYXnXvufw9KJZQRjDwR3eo7fIZIXgUReokbF670/erEckkoxe6FFhkNYu1BOMLhc96KveHfD7+ErKsaCUXitXm/KnqYX2fQOO/REZEKN7YoRYmeGItZuPyFwuIaQCXFWKss+0QWGzrkOZON3hqps3ml9OHv1lwi+5vcgOMwcfxVgCAN7bW7vCTQtmvE7pn7H5SnLQovBHv0jQm7QsIu43WbudkCzyxSve5ewhaqnYEkAsYwfVMEZk4EQLH3WXCiQ8W+N0Gfe9fOqPgEfSCwWmc3JSayI9MPosDgTbsPwb0a3w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=5pKIBBJn7BLOEhhGj5/OC5EWg4ItyB1Vw8Kdm/u2BRo=;
 b=d87RPJyNrxu6gYOAwSm38rdCJW4cD3168V9P/ISUr99n/LsSnTKYx6YV657dYWHZQFnprPmkFJYQZp+ZGYtHnffFBDT9eyXO+yN3nl49xHXJ4CpQvwfX6Lxf5OwVy2G2cBCwN2EPnkLl0atczT5p6DlpeMrU8PRTAXz6ns8HOP8=
Date: Tue, 26 Oct 2021 11:08:21 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Oleksandr Andrushchenko <andr2000@gmail.com>
CC: <xen-devel@lists.xenproject.org>, <julien@xen.org>,
	<sstabellini@kernel.org>, <oleksandr_tyshchenko@epam.com>,
	<volodymyr_babchuk@epam.com>, <Artem_Mygaiev@epam.com>, <jbeulich@suse.com>,
	<bertrand.marquis@arm.com>, <rahul.singh@arm.com>, Oleksandr Andrushchenko
	<oleksandr_andrushchenko@epam.com>
Subject: Re: [PATCH v3 06/11] vpci/header: Handle p2m range sets per BAR
Message-ID: <YXfFhZ2/kX15CbLJ@MacBook-Air-de-Roger.local>
References: <20210930075223.860329-1-andr2000@gmail.com>
 <20210930075223.860329-7-andr2000@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20210930075223.860329-7-andr2000@gmail.com>
X-ClientProxiedBy: MRXP264CA0032.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:500:14::20) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: c018f0a5-b83e-43d7-363d-08d998602c4d
X-MS-TrafficTypeDiagnostic: DM6PR03MB5354:
X-Microsoft-Antispam-PRVS: <DM6PR03MB535478E932031303144D80C38F849@DM6PR03MB5354.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: Ubj5jUc9E1J6AIe+QRhuUOI0BWYGFVncGhcfGjY7jszY1QsmxYjCSz55VYpL6cHGzN1Ig9ggKXWdaoRX3f3f4s1lbAFFeUgNFmlMMdwdZ0lPzKJY9IyvBrziDWzn03I+6XAuyPGMDenTuUI0fZ1PsRNGadfc38BnmYqcqzsdO6+MOvEr4KvbnEuRtD1j4PNQORwEwzQpPW8c1QED2wrZ71pJq3wFgvP70ujDMrY5PeC+Rlr9h+jB2Id+ExWJz+y6qXN2KTDZHQa7qg34cxCYBNoIYvkk+1ubyVs0mYBStHReLCQOBcqXeeJ9qdGybJtk16AZCnVMACciLIz7V7EqLguhN/c8NvfSakx8BC45uKfCfFiTSaplYsVU/RcVNcQ5H8qSR5FUo8nsHnpLIurrQCwqz6hYp7lBwm2wqAcmtHwOrm3HoELhrXNZlQ9yNxV6JCwFDJjWbgdB+kpb14ZIaiQoLwDyyMCzIZzguAGyHexw8q62BJNEPRs3aUra9aAIhAohDIovES6Lob37abxUw00Wn6RbOuHRmbBEPQ/o+IsjrGI3WIriMzW86mDOTlBnDy/8Qop2c7+Opua+/QnPsRUVjTA+UUfvnGOzoXNlB3I8zKe0qYl7sJfAkp2AGXku9RpHVySydyPbhEJ2ShScig==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(66556008)(6916009)(66476007)(85182001)(5660300002)(9686003)(956004)(83380400001)(6666004)(186003)(8676002)(82960400001)(508600001)(316002)(66946007)(26005)(86362001)(7416002)(8936002)(4326008)(38100700002)(6496006)(30864003)(2906002)(6486002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aGVmT2s0L2JndHpwZjZJMGxUclhPYUZ1b1BWUDdpcW5lbTRtUWNuVFgrZDVx?=
 =?utf-8?B?bGx5bGhvblA0Vk15alNzZkh6UlVTaEZjbHR1RlZHYTNxcnE3em5IZUZsQ2wz?=
 =?utf-8?B?VXMwT1VrUkFpV1pjNVVIaEdodjI0MDBXV1J5SHEvaDNDWE16S1E3Ykl4S21O?=
 =?utf-8?B?L2FYWnJuTkFYa21mUHhHS09VY1hXd1BHNGgyQ3Q4VFR2K28rNjFFUkRIbU9u?=
 =?utf-8?B?TnQwUDIxVDg0QVFZMHM0bEF4OXRTd01mRm9UbGU3RnZLZnhrOHhFbmpHNitO?=
 =?utf-8?B?WTVpTHRkUHF3RWNWOG9ta0J4NWIvM3ErRWRyRFh5TmNPb1BZeWd1ejZtenVa?=
 =?utf-8?B?QUs5T29zTXdNd09GblpjZUJCdkR3L0VZbSttcGxsbG1OVXN0RTB1Rzc5a0pG?=
 =?utf-8?B?bFpoMjROdWJDbndZOVVkK1hKcXhGMDFqcWhOTlIyY25yYXpKUWthcGxpOVdQ?=
 =?utf-8?B?OVZGRzRETEhuTEE5dWVLRjNsWXJldVk2NjFzOWljV1R2OWRXR29XaXB2MGE5?=
 =?utf-8?B?WWg0Zy9PbERLU2o0ajhyOXdPb0oxSkVCVEh4TlhRVHVxbWc2N2RUb0ZZbktY?=
 =?utf-8?B?TjVxeW5SQzhVQm5mNXk4VEFGczV6aUx0amVTQ1p3akhpVm93QkM2TkIxeWN5?=
 =?utf-8?B?R1AvK0lyWUE0dmsyRGdaZE5PTElPbWdIR1QwVzdUdW5QbzExalMwQkpXdGxm?=
 =?utf-8?B?ano5ZHhXRFM5bk5KNmw1aFVnTUVjNXgxQXNsb1k3OS9sdmtxZko5cnd2T05r?=
 =?utf-8?B?WU1RQ09waytBOGhFdjBNamxLekdtQ1RnMUZ2UFRJK0Z3eldmWGU3OEpZdGxl?=
 =?utf-8?B?QW5IanJyZ1NhRnd1TDFlS2QrRThGek5VdVVoMi94eTQ5aysveG5jdlVkQzB2?=
 =?utf-8?B?b0pWb2I2dGNwYU1JQ2JUeHp4S0NlNUVudGcvWHozQnFBUmJ1MkFWQml0UFlv?=
 =?utf-8?B?cXQ4VllDLzhTbUNMMkVPc1RvTERTdVExUnVoTGR4dUNvMnNRNmZ5UERneHRo?=
 =?utf-8?B?eUxsUE5aWW5uWlRVUG44Q0JIdjBHVXhoZ0N6TmNmMkhVS29CczJXT0dqRUpR?=
 =?utf-8?B?cDR6akZnT3Q3b3NSck1mWGpWSml0QTd0VjZtcEFIYjJkazl2NG15dXVxOWw3?=
 =?utf-8?B?NlBRd0pJeVpYOVhTOG5XdFU0aEJ4S1drSXQ4WjgxdHdFb0lXaFNSOWNZSXVE?=
 =?utf-8?B?RDZGaURCcThJQTB4SkNPM1dQZUJiU0gxMnpTUi9WdXJ1MTF0RENQeHlXa09V?=
 =?utf-8?B?cHNLQ0FYRE45T2Y2MkoyU2NhMkpBc09qaDN6R2I4WnRqZzVRTG9yZ3QzWStV?=
 =?utf-8?B?RDh0OUxHZncrTUNVRUhCdi9TdXVvRzgwSTJveWpKK2JpZlZoR2hmQUlYRXBG?=
 =?utf-8?B?aldaZFhyYTJpeXcyUnJLbTE5WTJyU1ZWWVRFdlBWNUZwNVhReFBWZnhJUk1w?=
 =?utf-8?B?NTJPWC9EV3Q2OGdhK0RwUFJkZ3BDdFZnZU41QkNReHg3L1hOejBiZHhzQUZI?=
 =?utf-8?B?LzNTYlV2Nm1ZczJMc3dLRFJ2NW9sUEpxc05XYzJCcEFsL1VWeDNaMzNyeTdP?=
 =?utf-8?B?dGliZnpRbW45Vkd3SzUzMTVnNml3bWhYVzI2V2JETWg4M3FacnNNZXNyT3FB?=
 =?utf-8?B?dTJUK1JEbHhjR29XcUMzOS94UlhQV1JsR2hrU0RBbkZBL2d0NUt6UzlobSs2?=
 =?utf-8?B?elBUWnNLNHFTaXc5Q1N5c1hReVpyUXZ3Mm5DMUNlTkR6TnNiWmQrbUpPcFRl?=
 =?utf-8?B?TkdkUkM3eUQ3NHhTbmxocFZNZFMzRTd2UU9oRjZ1eTR6aGVkSUtUZnFxdVpT?=
 =?utf-8?B?VjcyeFV5b250R0c2SDN1SGF6YlF1UUNMeGRJMDduRkFCdWJEbDVvSmxPQXAw?=
 =?utf-8?B?b00vUHJDRDRweXpjZGtGaGlNSWZtbVVScXFiQzhIR3pjeEFlc2s2L2ZXWm1h?=
 =?utf-8?B?RFlxSTRlVFBINXF0L0F3ZTRacEx2TzFXYTl2bytvc1Vtc2xsbW1CSjdlVUpQ?=
 =?utf-8?B?NDlzdm9teHhmNko0QmxyZEN4alFPYys2UVFtSnlnTktTQndxTkZnc3BmTjA3?=
 =?utf-8?B?THNob2s2TCt0MVgvRGhDb2t4Ny9VZWV5dVVKRHNSMHJhbWQvaGNzMy96c0ZU?=
 =?utf-8?B?c3ovS01PYnIxaXlySVJ5bXRmL3AxNnVQT0d6SjVOaDlJV3pIdTBJWmdGZzVJ?=
 =?utf-8?Q?8ueUD4msHMYdlmynvP+Lzrw=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: c018f0a5-b83e-43d7-363d-08d998602c4d
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2021 09:08:28.0949
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: taU4jOR0Ctc3V3rS4DTPBzYn3298A5ECXf7jGqBZAN7W5FprLnCsC7SzcRUi7wCIjzJDzqrRjt8XQ1HNEg9t4w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB5354
X-OriginatorOrg: citrix.com

On Thu, Sep 30, 2021 at 10:52:18AM +0300, Oleksandr Andrushchenko wrote:
> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> 
> Instead of handling a single range set, that contains all the memory
> regions of all the BARs and ROM, have them per BAR.
> 
> This is in preparation of making non-identity mappings in p2m for the
> MMIOs/ROM.
> 
> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> ---
>  xen/drivers/vpci/header.c | 172 ++++++++++++++++++++++++++------------
>  xen/include/xen/vpci.h    |   3 +-
>  2 files changed, 122 insertions(+), 53 deletions(-)
> 
> diff --git a/xen/drivers/vpci/header.c b/xen/drivers/vpci/header.c
> index ec4d215f36ff..9c603d26d302 100644
> --- a/xen/drivers/vpci/header.c
> +++ b/xen/drivers/vpci/header.c
> @@ -131,49 +131,75 @@ static void modify_decoding(const struct pci_dev *pdev, uint16_t cmd,
>  
>  bool vpci_process_pending(struct vcpu *v)
>  {
> -    if ( v->vpci.mem )
> +    if ( v->vpci.num_mem_ranges )
>      {
>          struct map_data data = {
>              .d = v->domain,
>              .map = v->vpci.cmd & PCI_COMMAND_MEMORY,
>          };
> -        int rc = rangeset_consume_ranges(v->vpci.mem, map_range, &data);
> +        struct pci_dev *pdev = v->vpci.pdev;
> +        struct vpci_header *header = &pdev->vpci->header;
> +        unsigned int i;
>  
> -        if ( rc == -ERESTART )
> -            return true;
> +        for ( i = 0; i < ARRAY_SIZE(header->bars); i++ )
> +        {
> +            struct vpci_bar *bar = &header->bars[i];
> +            int rc;
>  
> -        spin_lock(&v->vpci.pdev->vpci->lock);
> -        /* Disable memory decoding unconditionally on failure. */
> -        modify_decoding(v->vpci.pdev,
> -                        rc ? v->vpci.cmd & ~PCI_COMMAND_MEMORY : v->vpci.cmd,
> -                        !rc && v->vpci.rom_only);
> -        spin_unlock(&v->vpci.pdev->vpci->lock);
> +            if ( !bar->mem )
> +                continue;
>  
> -        rangeset_destroy(v->vpci.mem);
> -        v->vpci.mem = NULL;
> -        if ( rc )
> -            /*
> -             * FIXME: in case of failure remove the device from the domain.
> -             * Note that there might still be leftover mappings. While this is
> -             * safe for Dom0, for DomUs the domain will likely need to be
> -             * killed in order to avoid leaking stale p2m mappings on
> -             * failure.
> -             */
> -            vpci_remove_device(v->vpci.pdev);
> +            rc = rangeset_consume_ranges(bar->mem, map_range, &data);
> +
> +            if ( rc == -ERESTART )
> +                return true;
> +
> +            spin_lock(&pdev->vpci->lock);
> +            /* Disable memory decoding unconditionally on failure. */
> +            modify_decoding(pdev,
> +                            rc ? v->vpci.cmd & ~PCI_COMMAND_MEMORY : v->vpci.cmd,
> +                            !rc && v->vpci.rom_only);
> +            spin_unlock(&pdev->vpci->lock);
> +
> +            rangeset_destroy(bar->mem);

Now that the rangesets are per-BAR we might have to consider
allocating them at initialization time and not destroying them when
empty. We could replace the NULL checks with rangeset_is_empty
instead. Not that you have to do this on this patch, but I think it's
worth mentioning.

> +            bar->mem = NULL;
> +            v->vpci.num_mem_ranges--;
> +            if ( rc )
> +                /*
> +                 * FIXME: in case of failure remove the device from the domain.
> +                 * Note that there might still be leftover mappings. While this is
> +                 * safe for Dom0, for DomUs the domain will likely need to be
> +                 * killed in order to avoid leaking stale p2m mappings on
> +                 * failure.
> +                 */
> +                vpci_remove_device(pdev);
> +        }
>      }
>  
>      return false;
>  }
>  
>  static int __init apply_map(struct domain *d, const struct pci_dev *pdev,
> -                            struct rangeset *mem, uint16_t cmd)
> +                            uint16_t cmd)
>  {
>      struct map_data data = { .d = d, .map = true };
> -    int rc;
> +    struct vpci_header *header = &pdev->vpci->header;
> +    int rc = 0;
> +    unsigned int i;
> +
> +    for ( i = 0; i < ARRAY_SIZE(header->bars); i++ )
> +    {
> +        struct vpci_bar *bar = &header->bars[i];
>  
> -    while ( (rc = rangeset_consume_ranges(mem, map_range, &data)) == -ERESTART )
> -        process_pending_softirqs();
> -    rangeset_destroy(mem);
> +        if ( !bar->mem )
> +            continue;
> +
> +        while ( (rc = rangeset_consume_ranges(bar->mem, map_range,
> +                                              &data)) == -ERESTART )
> +            process_pending_softirqs();
> +        rangeset_destroy(bar->mem);
> +        bar->mem = NULL;
> +    }
>      if ( !rc )
>          modify_decoding(pdev, cmd, false);
>  
> @@ -181,7 +207,7 @@ static int __init apply_map(struct domain *d, const struct pci_dev *pdev,
>  }
>  
>  static void defer_map(struct domain *d, struct pci_dev *pdev,
> -                      struct rangeset *mem, uint16_t cmd, bool rom_only)
> +                      uint16_t cmd, bool rom_only, uint8_t num_mem_ranges)

Like mentioned below, I don't think you need to pass the number of
BARs that need mapping changes. Iff that's strictly needed, it should
be an unsigned int.

>  {
>      struct vcpu *curr = current;
>  
> @@ -192,9 +218,9 @@ static void defer_map(struct domain *d, struct pci_dev *pdev,
>       * started for the same device if the domain is not well-behaved.
>       */
>      curr->vpci.pdev = pdev;
> -    curr->vpci.mem = mem;
>      curr->vpci.cmd = cmd;
>      curr->vpci.rom_only = rom_only;
> +    curr->vpci.num_mem_ranges = num_mem_ranges;
>      /*
>       * Raise a scheduler softirq in order to prevent the guest from resuming
>       * execution with pending mapping operations, to trigger the invocation
> @@ -206,42 +232,47 @@ static void defer_map(struct domain *d, struct pci_dev *pdev,
>  static int modify_bars(const struct pci_dev *pdev, uint16_t cmd, bool rom_only)
>  {
>      struct vpci_header *header = &pdev->vpci->header;
> -    struct rangeset *mem = rangeset_new(NULL, NULL, 0);
>      struct pci_dev *tmp, *dev = NULL;
>      const struct vpci_msix *msix = pdev->vpci->msix;
> -    unsigned int i;
> +    unsigned int i, j;
>      int rc;
> -
> -    if ( !mem )
> -        return -ENOMEM;
> +    uint8_t num_mem_ranges;
>  
>      /*
> -     * Create a rangeset that represents the current device BARs memory region
> +     * Create a rangeset per BAR that represents the current device memory region
>       * and compare it against all the currently active BAR memory regions. If
>       * an overlap is found, subtract it from the region to be mapped/unmapped.
>       *
> -     * First fill the rangeset with all the BARs of this device or with the ROM
> +     * First fill the rangesets with all the BARs of this device or with the ROM
>       * BAR only, depending on whether the guest is toggling the memory decode
>       * bit of the command register, or the enable bit of the ROM BAR register.
>       */
>      for ( i = 0; i < ARRAY_SIZE(header->bars); i++ )
>      {
> -        const struct vpci_bar *bar = &header->bars[i];
> +        struct vpci_bar *bar = &header->bars[i];
>          unsigned long start = PFN_DOWN(bar->addr);
>          unsigned long end = PFN_DOWN(bar->addr + bar->size - 1);
>  
> +        bar->mem = NULL;

Why do you need to set mem to NULL here? I think we should instead
assert that bar->mem == NULL here.

> +
>          if ( !MAPPABLE_BAR(bar) ||
>               (rom_only ? bar->type != VPCI_BAR_ROM
>                         : (bar->type == VPCI_BAR_ROM && !header->rom_enabled)) )
>              continue;
>  
> -        rc = rangeset_add_range(mem, start, end);
> +        bar->mem = rangeset_new(NULL, NULL, 0);
> +        if ( !bar->mem )
> +        {
> +            rc = -ENOMEM;
> +            goto fail;
> +        }
> +
> +        rc = rangeset_add_range(bar->mem, start, end);
>          if ( rc )
>          {
>              printk(XENLOG_G_WARNING "Failed to add [%lx, %lx]: %d\n",
>                     start, end, rc);
> -            rangeset_destroy(mem);
> -            return rc;
> +            goto fail;
>          }
>      }
>  
> @@ -252,14 +283,21 @@ static int modify_bars(const struct pci_dev *pdev, uint16_t cmd, bool rom_only)
>          unsigned long end = PFN_DOWN(vmsix_table_addr(pdev->vpci, i) +
>                                       vmsix_table_size(pdev->vpci, i) - 1);
>  
> -        rc = rangeset_remove_range(mem, start, end);
> -        if ( rc )
> +        for ( j = 0; j < ARRAY_SIZE(header->bars); j++ )
>          {
> -            printk(XENLOG_G_WARNING
> -                   "Failed to remove MSIX table [%lx, %lx]: %d\n",
> -                   start, end, rc);
> -            rangeset_destroy(mem);
> -            return rc;
> +            const struct vpci_bar *bar = &header->bars[j];
> +
> +            if ( !bar->mem )
> +                continue;
> +
> +            rc = rangeset_remove_range(bar->mem, start, end);
> +            if ( rc )
> +            {
> +                printk(XENLOG_G_WARNING
> +                       "Failed to remove MSIX table [%lx, %lx]: %d\n",
> +                       start, end, rc);
> +                goto fail;
> +            }
>          }
>      }
>  
> @@ -291,7 +329,8 @@ static int modify_bars(const struct pci_dev *pdev, uint16_t cmd, bool rom_only)
>              unsigned long start = PFN_DOWN(bar->addr);
>              unsigned long end = PFN_DOWN(bar->addr + bar->size - 1);
>  
> -            if ( !bar->enabled || !rangeset_overlaps_range(mem, start, end) ||
> +            if ( !bar->enabled ||
> +                 !rangeset_overlaps_range(bar->mem, start, end) ||
>                   /*
>                    * If only the ROM enable bit is toggled check against other
>                    * BARs in the same device for overlaps, but not against the
> @@ -300,13 +339,12 @@ static int modify_bars(const struct pci_dev *pdev, uint16_t cmd, bool rom_only)
>                   (rom_only && tmp == pdev && bar->type == VPCI_BAR_ROM) )
>                  continue;
>  
> -            rc = rangeset_remove_range(mem, start, end);
> +            rc = rangeset_remove_range(bar->mem, start, end);
>              if ( rc )
>              {
>                  printk(XENLOG_G_WARNING "Failed to remove [%lx, %lx]: %d\n",
>                         start, end, rc);
> -                rangeset_destroy(mem);
> -                return rc;
> +                goto fail;
>              }
>          }
>      }
> @@ -324,12 +362,42 @@ static int modify_bars(const struct pci_dev *pdev, uint16_t cmd, bool rom_only)
>           * will always be to establish mappings and process all the BARs.
>           */
>          ASSERT((cmd & PCI_COMMAND_MEMORY) && !rom_only);
> -        return apply_map(pdev->domain, pdev, mem, cmd);
> +        return apply_map(pdev->domain, pdev, cmd);
>      }
>  
> -    defer_map(dev->domain, dev, mem, cmd, rom_only);
> +    /* Find out how many memory ranges has left after MSI and overlaps. */
> +    num_mem_ranges = 0;
> +    for ( i = 0; i < ARRAY_SIZE(header->bars); i++ )
> +    {
> +        struct vpci_bar *bar = &header->bars[i];

There's no need to declare this local variable AFAICT, just use
header->bars[i].mem. In any case this is likely to go away if you
follow my recommendation below to just call defer_map unconditionally
like it's currently done.

> +
> +        if ( !rangeset_is_empty(bar->mem) )
> +            num_mem_ranges++;
> +    }
> +
> +    /*
> +     * There are cases when PCI device, root port for example, has neither
> +     * memory space nor IO. In this case PCI command register write is
> +     * missed resulting in the underlying PCI device not functional, so:
> +     *   - if there are no regions write the command register now
> +     *   - if there are regions then defer work and write later on
> +     */
> +    if ( !num_mem_ranges )
> +        pci_conf_write16(pdev->sbdf, PCI_COMMAND, cmd);

I think this is wrong, as not calling defer_map will prevent the
rangesets (bar[i]->mem) from being destroyed, so we are effectively
leaking memory.

You need to take a path similar to the failure one in case there are
no mappings pending, or even better just call defer_map anyway and let
it do it's thing, it should be capable of handling empty rangesets
just fine. That's how it's currently done.

> +    else
> +        defer_map(dev->domain, dev, cmd, rom_only, num_mem_ranges);
>  
>      return 0;
> +
> +fail:

We usually ask labels to be indented with one space.

> +    for ( i = 0; i < ARRAY_SIZE(header->bars); i++ )
> +    {
> +        struct vpci_bar *bar = &header->bars[i];
> +
> +        rangeset_destroy(bar->mem);
> +        bar->mem = NULL;
> +    }
> +    return rc;
>  }
>  
>  static void cmd_write(const struct pci_dev *pdev, unsigned int reg,
> diff --git a/xen/include/xen/vpci.h b/xen/include/xen/vpci.h
> index a0320b22cb36..352e02d0106d 100644
> --- a/xen/include/xen/vpci.h
> +++ b/xen/include/xen/vpci.h
> @@ -80,6 +80,7 @@ struct vpci {
>              /* Guest view of the BAR. */
>              uint64_t guest_addr;
>              uint64_t size;
> +            struct rangeset *mem;
>              enum {
>                  VPCI_BAR_EMPTY,
>                  VPCI_BAR_IO,
> @@ -154,9 +155,9 @@ struct vpci {
>  
>  struct vpci_vcpu {
>      /* Per-vcpu structure to store state while {un}mapping of PCI BARs. */
> -    struct rangeset *mem;
>      struct pci_dev *pdev;
>      uint16_t cmd;
> +    uint8_t num_mem_ranges;

AFAICT This could be a simple bool:

bool map_pending : 1;

As there's no strict need to know how many BARs have pending mappings.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Tue Oct 26 09:40:25 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Oct 2021 09:40:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.216319.375872 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfIwM-0004y2-Uu; Tue, 26 Oct 2021 09:40:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 216319.375872; Tue, 26 Oct 2021 09:40:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfIwM-0004xv-S5; Tue, 26 Oct 2021 09:40:18 +0000
Received: by outflank-mailman (input) for mailman id 216319;
 Tue, 26 Oct 2021 09:40:18 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=d0pl=PO=citrix.com=roger.pau@srs-us1.protection.inumbo.net>)
 id 1mfIwM-0004xp-24
 for xen-devel@lists.xenproject.org; Tue, 26 Oct 2021 09:40:18 +0000
Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id b9aca058-3640-11ec-8428-12813bfff9fa;
 Tue, 26 Oct 2021 09:40:16 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b9aca058-3640-11ec-8428-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1635241216;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=1H/PNyAPUuwUIhadN1jEiq6UwFgPl+4vKP8Y6Be51EE=;
  b=BUivXNcGlXG7Z0k8gT+fCcp6HEr7XTpYX/gzzLMVHePE12I2/cBz5q2H
   oqknBikgD6m2314WQJBuBm7FhCd7jxlfrWZPXoDBz+wzBs3vw8hR5cGQZ
   tjhSSheu3fs/GgREGoVUTtzmJT2F812LnP1z0V260V/hz2SL4vcIqpQd8
   4=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: 1QLIqOg2fUskHwwFZRjKRQC9EYA2fkduRWb05pEont/iC6N4u5WJMrApeyGbEPHsHZvbeaQeNW
 Dyjxosdg4VHq6n9AwNQxIsrD7cIjAFFh/WJVMwsPzCKIUvfBwfUA2vTgKDVzMpPR3Fsu19+GSp
 v+QScEyVxpHjdwRbA4GHF/Ypp7BYWx7GgWEYAjRsDhJ1v8xIfyuE8fTbpeEVX1xX2cnkbBsW3o
 CwYUPmPQ7aLvrPkfvy2ujpEdWTA9HJRXeDVwHX8chwxkQO3jir7PlJX+8E5XnKOVBny2Ic3j5D
 /ra2sgW7Az6vvb2rMzPXhriZ
X-SBRS: 5.1
X-MesageID: 57983270
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:i2VOw6MANeQbkFzvrR2zkcFynXyQoLVcMsEvi/4bfWQNrUp012EDm
 mMXDWiBaP+JamT2eo1wb4ngph4Hu8TUyoJmHQto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdpJYz/uUGuCJQUNUjMlkfZKhTr6bUsxNbVU8En540Ug9w7RRbrNA2rBVPSvc4
 bsenOWHULOV82Yc3rU8sv/rRLtH5ZweiRtA1rAMTakjUGz2zhH5OKk3N6CpR0YUd6EPdgKMq
 0Qv+5nilo/R109F5tpICd8XeGVSKlLZFVDmZna7x8FOK/WNz8A/+v9TCRYSVatYoxWlwMFsz
 dNtjLaXTC0HALfwivgiUzANRkmSPYUekFPGCX22sMjVxEzaaXr8hf5pCSnaP6VBpLwxWzsXs
 6VFdnZdNXhvhMrvqF6/YvNrick5atHiIasUu216zCGfBvEjKXzGa/iVtI8Dhmho7ixINa3nP
 NM7cQpUUDKDUjYRB1IPVrFkuPj90xETdBUH8QnI9MLb+VP7zgZ8zbzsO9r9YcGRSINemUPwj
 kvc42n8NTQLO9WexCSt/2qlg6nEmiaTcIgfDqGi//hmxlia3HUOCQY+XEG+5/K+jyaWS99Zb
 kAZ5Ccqhawz71CwCMnwWQWip3yJtQJaXMBfe8Ug4QGQzuzP4gCWBkANVDsHY9sj3Oc0WDgr2
 1mhj97vQzt1v9W9bnaQ9aydqz+oDgETIXUffi8PTQYD4N7LrZk6i1TESdMLOLWuktT/FDX0w
 jaLhCsznbMeiYgMzarT1W7AhzWgt53YVDkf7w/cXn+mxg5hbYvjbIutgXD86ftDN4+fQkO2g
 Gkfm8Oe4eYNCrmAjCWIBu4KGdmUC+2taWOGxwQ1Rt94qmrrqyXLkZ1sDC9WBGs2I9sBfx/QS
 mjWky1v/qNBIESqRPoiC26uMPgCwa/lHNXjc/nbaNtSf5R8HDO6EDFSiV24hD+1zhB9+U0rE
 dLCK5z0VCdFYUhy5GPuH7917FM9+swpKYo/r7jAxBO7zaHWWneRTboUWLdlRrFktP3ayOk5H
 tA2Cidr9/m9eLGhCsU02dRKRbzvEZTcLcuuw/G7jsbZfmJb9JgJUpc9O48JdY1/hLhynezV5
 Hy7UUIw4AOh3iCeeVXTOyEzOeKHsXNDQZUTZnREALpV8yJ7PdbHAFk3LsNfkUYbGBxLkqcvE
 qhtlzSoCfVTUDXXkwnxnrGmxLGOgC+D3FrUVwL8OWBXV8c5G2Thp4+1FiOypXJmJnfm6qMDT
 0iIi1qzrWwrHF85Uq47qZuHkjuMgJTqsLgiAxeReYIDJh6EHUoDA3WZs8Lb6vokcH3r7jCby
 xyXEVEfo+zMqJUy697HmeaPqILBLge0NhAy87Dz4enkOC/E0HCkxIMcAu+EcSqEDDH/+bm4Z
 PUTxPb5aaVVkFFPuot6MrBq0aNhuIe/++4EllxpTCfRclCmKrJ8OX3aj8NBgbJAm+1CsgysV
 0PRptQDYeeVONnoGUI6LRY+arjRzukdnzTftKxnIEjz6CJt0qCAVEFeY0uFhCBHdeMnO4I52
 +Yx/sUR7lXn2BYtN9+HiAFS9niNcSNcA/l26MlCDday2AQxy1xEbZjNMQPM4cmCO4dWL00nA
 j6In66e1b5S8VXPLigoHn/X0OsD2ZlX4EJWzEUPLkiik8begqNlxwVY9Dk6Q1gHzhhD1O4va
 GFnO1csePeL9jZswsNCQ3qtC0dKAxjAoh79zF4AlWv4SUi0VzOScD1haLjVpE1JoXhBejV7/
 a2DzDe3WDnnS8j9wy8uVBM3sPfkV9FwqlXPlc3P8x5pxHXmje4JWpOTWFc=
IronPort-HdrOrdr: A9a23:LQCaV6t8itJIDsYfcyzyvDvl7skCkIMji2hC6mlwRA09TyXGra
 6TdaUguiMc1gx8ZJhBo7C90KnpewK7yXdQ2/htAV7CZnidhILMFuBfBOTZsljd8kHFh4pgPO
 JbAtRD4b7LfClHZKTBkXGF+r8bqbHtms3Y5pa9vgdQpENRGtpdBm9Ce3im+yZNNXB77PQCZf
 2hDp0tnUveRZ1bVLXwOlA1G8z44/HbnpPvZhALQzYh9Qm1lDutrJr3CQKR0BsyWy5Ghe5Kyx
 mIryXJooGY992rwB7V0GHeq7xQhdva09NGQOiBkNIcJDnAghuhIK5hR7qBljYop/zH0idmrP
 D85zMbe+hj4XLYeW+45TPrxgnbyT4rr0TvzFeJ6EGT6PDRdXYfMY5slIhZehzW5w4Lp9dnyp
 9G2Gqfqt5+EQ7AtD6V3amIazha0m6P5VYym+8aiHJSFaEEbqVKkIAZ9ERJVL8dASPB7pw9Gu
 UGNrCT2B9vSyLYU5nlhBgs/DT1NU5DWytuA3Jy9fB96gIm3EyQlCAjtYgidnRpzuNKd3AL3Z
 WCDk1SrsA9ciYhV9MLOA4we7rFNoXze2O4DIuzGyWuKEhVAQOHl3bIiI9FkN1CPqZ4iqcPpA
 ==
X-IronPort-AV: E=Sophos;i="5.87,182,1631592000"; 
   d="scan'208";a="57983270"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=SM7u+P7Iv9TI40ypVgAj6MHMIOh1i4TUbWhrIsJQt/bA8iOlGoNABDObnDU+syIWK9uLdxjR1WkehvZHz47y+bNOExwJGZh5uMOoTHXddhDI6Qmybnlmc8Z2F3rZ9Cf/cs+ir1+WQrCnlses5cKPA9VG32IRGRQapYN10NDx68RVNLD9v5Ap1nB7mHU6yzlfl7vC7bJoFRNM4FLJJm+yxPgUGP/bvB3CerHxCRz1uoiO/38w9jRrDGti7BDhdFKZUyMCEYziC/5SRkUmIQrLx3CJeKzNsq6pyJMt9ZWu2AlW2iOFjAjq+SNybwVZ5qFKK6pViHh9briThmrWplzpZg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=1H/PNyAPUuwUIhadN1jEiq6UwFgPl+4vKP8Y6Be51EE=;
 b=FxHBa8PWnvtNkNPBVZzAoE7ldUjMVBuNKuyDHGGsno+G42jRDttNhJOhCvMpdvCmtSXD7abYgOPues/w/tL/wRdLueRURTiPsB4BzRnqXEt1MY0L9HlCHhp/KWcXWXY20tgQugyBLYWtXR51uivAT/4u8yCEjTSo9+WZov7cFVoU4+QN6uj2ytMLWA0NazRceJ0rp9z5LCDlkostLo72GFVpIeZCxsnbx5D7HUYOR8+Zeea9mGHSe6Vp/+PnnWgG6xLrpQHTCUTSdqOXgzrpNnt3QOgVhJEVuAO7hbjjClFD6ahCBeV2+7p8kfv5b7XFwSxEyxrjU5xJwwrzGWCwRA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=1H/PNyAPUuwUIhadN1jEiq6UwFgPl+4vKP8Y6Be51EE=;
 b=kuwKoJETM+FWigcWVHbo1wcWyRTu7OfkQMBeLIdiEFSv4RqL5r+cV8q3SPL9FfIW/TeVSUwFXmcNDlNuev6eQNT1IXxjuFrBwL+KQpV2AG/i3RvX5WC4Osp/EomgARODpksfyZ6VDWBgQjq2kEPPTikzWsSSXw2hmyYbq117vdA=
Date: Tue, 26 Oct 2021 11:40:06 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
CC: "julien@xen.org" <julien@xen.org>, "sstabellini@kernel.org"
	<sstabellini@kernel.org>, Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Artem Mygaiev <Artem_Mygaiev@epam.com>,
	"jbeulich@suse.com" <jbeulich@suse.com>, Bertrand Marquis
	<bertrand.marquis@arm.com>, Rahul Singh <rahul.singh@arm.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v3 06/11] vpci/header: Handle p2m range sets per BAR
Message-ID: <YXfM9mQh3DS3bpfw@MacBook-Air-de-Roger.local>
References: <20210930075223.860329-1-andr2000@gmail.com>
 <20210930075223.860329-7-andr2000@gmail.com>
 <fc9de674-1000-c956-3401-103d8388d428@epam.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <fc9de674-1000-c956-3401-103d8388d428@epam.com>
X-ClientProxiedBy: PR0P264CA0069.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:100:1d::33) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 25ebb418-5dae-472c-309c-08d998649b23
X-MS-TrafficTypeDiagnostic: DM6PR03MB4762:
X-Microsoft-Antispam-PRVS: <DM6PR03MB47624136E8450FC1646465638F849@DM6PR03MB4762.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: JIAB/Ahdlf3WDqrQg6nUGnsZxxko+tKqrPTmymIfr7g4RKrHmG4VCmuzFGqQobZx33VrDk17wffC+UaRJAEbnGZALtSjz4cZPbejpG4s5npJBtY7JhglNWBvVHKWeaiEKYp7pWitQbpVl3qM/MD20x+Zdi4uDjicev74Ml/ZTuh16bO3pcWyQGzhJQJcGqowQxpA3K/CTCRNdpWWhpFxPO1odyKeG5VUe9nEq8cYeECIKZ9YEwFGtIi4cC+2SO2qMCiRBzKQ8MohBj7VNAlxQun2E+ZL3+lOGIWs7H2obgpazQ9QtuAW9opWq+c8orJkcrLYOaH/sXzyqTpHMRRgXI5fUcniwYpRwGAFKnDO8wDVnrzomzkL2URq+lWFeHM7a8XFOHiXKThm5jOhvTJ8ctRW578vudLSFAHb6sTHVzdRlDvp+8WUWt5F8S2n4Lf4vKFcDWBUAL/MasXDKpskk3K4uowrGSLuqYxKkrmhOeXVFVotGgk9IMmtgokH+3qaY2nVnocED/+5Qw//6PXCPvlqbbG2d/8f+/Dzg+QA3zEDCP0z6JFuQs6mzy7ABSrsmqXVCDpUCwCqzbDLZMNkvtYq4CzGoT6DXdxK/r17nUfV0jsBPaJrT7Qv9aTGi4owRa36GXIH9XYh281yO6Y4pw==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(2906002)(66476007)(66946007)(956004)(66556008)(9686003)(5660300002)(186003)(82960400001)(85182001)(508600001)(8676002)(4744005)(6486002)(54906003)(38100700002)(26005)(6916009)(4326008)(6666004)(316002)(86362001)(7416002)(6496006)(8936002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L0xBYjk4WTZjTldJUTJtTCtucjF0Q0QxZHVkVXVNMlJ0cCtBRG9KT3hYVk93?=
 =?utf-8?B?eGJab093L3Q4QTc4K2g2Q1VjVlBxTGo5MkVWK0ZMY2Z1cnBTQ3FkSG81NllG?=
 =?utf-8?B?OFFNb0FacTZtQUNxampDekJxbFJYSFRnSkVoZ3NLZ2dML0cvMnVLK1JEZEpD?=
 =?utf-8?B?T0sxMldCSUxUMERNYThvSk1GVGZIZW52SjhMcjAySkdUSmR6L2VTN3R2eXQ4?=
 =?utf-8?B?NEpHUGhqMURZbHlsY3VHVFdMWGJaN2tseENBMVkvTGY4ZnFsUnZWSE5GaEU4?=
 =?utf-8?B?UjdWTjVJTk1ZV0tuUndmMGM5em5IcGFkSmx5d2thSGtzSzVnaXd5eTQ2bUJn?=
 =?utf-8?B?dXUxUDZ0NnhKSXN4RGRQMkdwSTJTcFlaTHpKUzdycGdrcjBkVUI4cFlDbmNC?=
 =?utf-8?B?OGVKMjVpeEFKcDBXbURlTDdjSmRMRDc2YUZGckJiOENtM3FpN0pnN3oxdnht?=
 =?utf-8?B?TWQ5SjM3UnF4Z2JzRXd1L29ELzJqZEI5Z0hzQzBxR3NCUll0YkVqaHdLRDQw?=
 =?utf-8?B?Q0ZzOGZ3Um5XNUozblpZL09RRHh5Y1lSZmtDaHdHMVlFV1FDMXNoeDJvRXNn?=
 =?utf-8?B?VlVFK0Z4cjZvRmprOTBnUFFqdG5BaFZELzdWWk5kWnp5RkMwMUQzcEVXbmVu?=
 =?utf-8?B?QldMUnhYa3l5TVhDMUR6TjVleVJvbm1zSy8rR2VUQVltZVBHOHBCaDltcWor?=
 =?utf-8?B?elNhN2wydDBpcEE0SktaejVUSmxGVnBFUDdzWkpkQXZZRmdtYTlLSVZqMkhq?=
 =?utf-8?B?L2M0b2lzejZMbm5URnpBOE5jYnl5STArempHT0lKVW1tS0xseFRsZFozVU1B?=
 =?utf-8?B?VUJxZ3QyUmZLWDdJT2hnY0Y0UUtkTS80QnMzeEhEWkpDRTkyNDZhUGkyei81?=
 =?utf-8?B?dXRjdVc4ZTRkQ2NYSW95YWc4MEJCdEg2cEJaSWZDSHZ2SUQycVIzNzl5S1k1?=
 =?utf-8?B?RkdMNE93RG5peUVscnJxRlZldzFPN2NOcEJ2Vk5neEpmdC9MY2dTaW45TVFJ?=
 =?utf-8?B?RXVIOWZ6WnlUaDBBR1BaVGVyUGpQSUtBSGlrQTZpMjVkSWM5R20wUE9WRlBL?=
 =?utf-8?B?OGRsQ0xDazd1cGdFWTY5UFQ2bUdOdkJoNEpUcENBT2hENUNHTlI5SG1CMno3?=
 =?utf-8?B?Rys3QXdSVjlVb2NaQms4ZmhjbWtWd1NkSVRlZjVqVEkyN2d6WFNhMHVkc1B1?=
 =?utf-8?B?TGJPdTBCWTRzazdITGg4Z25OL0JIdzU3WngwNTQvSmg4YWVocU5zeTRjRnRm?=
 =?utf-8?B?L1VmV2J4RGhnOE9UdWRSL2JTRTFTaXZRSlNDWDdxL3ZjQ2YrZ3Y3T0kzSzdJ?=
 =?utf-8?B?N1VpRHdFUVJFR2RNTERuTkNaandHcG1Nbml5S0c1L0tuaHlCbElUUVNiKzVZ?=
 =?utf-8?B?VTYzTHJEMDNUMXNXNUtzSXB6a25vUWZuODF6OTh1MVdNSXZxalJleGJCbnV5?=
 =?utf-8?B?YlYrb0I5NzY0QVFScUpPWGQ2VmpWVjQ2Q202TE9EZ3RKMUc0empXUXdaSVFL?=
 =?utf-8?B?SVVnMWVYb3VoUkN4OUZsbmExK0lFK1VUZnQ5bGRSeUNrQkZTd2FqNWtZNlIr?=
 =?utf-8?B?aDJBQ29OaEg2WVVjaEFGd25CY0dzUldMS1V3bTUzNlZQSzNGa3d4OXczVlhp?=
 =?utf-8?B?SUkzNEFxY1hjSEYyN3FtNklyeE1PbXBkSU9Qd1EvbDJ6NVYxbHFrdlFJR2RK?=
 =?utf-8?B?WlZPeFNGdllqRkFRMjNQK3hjeUQ4KzkxR01iZURpdUlhZTNQTXZyWkRVNUFm?=
 =?utf-8?B?K1pFT3JwZzlKVndraVJUSDN1L2ZKU0ZMR3g1c3BTRjFqVTlaamt1V0IvTkFw?=
 =?utf-8?B?UkxFL3JjQnJjVHN2ZUowV2pxRC91TmtqQUdXZmNEd3BsdVI0TWVqM1NXczZ6?=
 =?utf-8?B?Q1hweCtMWlZjajVTS3R3dDFNb1FRd21RMDJJNTg3ZVVCaiswWW0rRWxpYk95?=
 =?utf-8?B?aUNuM2VQZXcwOTNHR2tiZHcxTHlmQ0t1QXVMS2VCV0NnYTRiV3dGVkNZazNx?=
 =?utf-8?B?blVjcnhqVzVpb2E2b1p1ejdDVm9hVWhTb1p1Ti9xRkx6UFNGWVRHUFZrUVUy?=
 =?utf-8?B?VzVqNXMxbEV6QU93YmFCa0h3YjZUL3E4YzN3cVM3bVdjWk5rZTNJdDhQMVhP?=
 =?utf-8?B?MGU5UnVHWjB0R0trRHo1ODM3VmNYTFRoOGh5eGxadW5rcm1LQkFHa2xTaHVT?=
 =?utf-8?Q?KsEM+bfAwkGswJpV6FsnQWc=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 25ebb418-5dae-472c-309c-08d998649b23
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2021 09:40:11.9300
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: N/DNARs3ics/T3pl5gsrWT2BnDDIgAiyIY3Kuz16+c571YgcxgJgiynGRXPaf+urc+oDLrxbIogfGjXS1vCNLQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4762
X-OriginatorOrg: citrix.com

On Mon, Oct 25, 2021 at 11:51:57AM +0000, Oleksandr Andrushchenko wrote:
> Hi, Roger!
> Could you please take a look at the below?
> Jan was questioning the per BAR range set approach, so it
> is crucial for the maintainer (you) to answer here.

I'm open to suggestions to using something different than a rangeset
per BAR, but lacking any concrete proposal I think using rangesets is
fine.

One possible way might be to extend rangesets so that private data
could be stored for each rangeset range, but that would then make
merging operations impossible, likewise splitting ranges would be
troublesome.

We could then store the physical BAR address in that private data and
use the rangeset addresses as guest physical address space. It's
unclear however that this approach would be any better than just using
a rangeset per BAR.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Tue Oct 26 09:59:00 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Oct 2021 09:59:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.216330.375889 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfJEH-0006cn-Ld; Tue, 26 Oct 2021 09:58:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 216330.375889; Tue, 26 Oct 2021 09:58:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfJEH-0006cg-I3; Tue, 26 Oct 2021 09:58:49 +0000
Received: by outflank-mailman (input) for mailman id 216330;
 Tue, 26 Oct 2021 09:58:48 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mfJEG-0006cV-M5
 for xen-devel@lists.xenproject.org; Tue, 26 Oct 2021 09:58:48 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mfJEG-0005mi-Ht
 for xen-devel@lists.xenproject.org; Tue, 26 Oct 2021 09:58:48 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mfJEG-0002iN-H6
 for xen-devel@lists.xenproject.org; Tue, 26 Oct 2021 09:58:48 +0000
Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89)
 (envelope-from <iwj@xenproject.org>)
 id 1mfJE4-00042y-UU; Tue, 26 Oct 2021 10:58:37 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date
	:Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From;
	bh=o5AvDmKyZ6xTmY3nA7yLFA84JXwYikWcTf1UXXE98mo=; b=51IsbEX5xmEVjldA+cHaJ2GZD/
	E4lTGfqmAt9iTruAWTq0RcMjJCvWcyO0GgvM05lAYNDTj9uYOV9864E4ye1J6tOMaI4QLldel+QUa
	yrsGRvaeeUxNS8wys5A7CxrEJ6XGd6h2gplCs6Hs3aKdTxrPawIzSHNDXbgrh25rZ5Gg=;
From: Ian Jackson <iwj@xenproject.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <24951.53580.84970.956218@mariner.uk.xensource.com>
Date: Tue, 26 Oct 2021 10:58:36 +0100
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: George.Dunlap@citrix.com,
    dunlapg@umich.edu,
    roger.pau@citrix.com,
    jbeulich@suse.com,
    committers@xenproject.org,
    xen-devel@lists.xenproject.org
Subject: Re: [PATCH v2] governance: communication channels
In-Reply-To: <alpine.DEB.2.21.2110251845500.4586@sstabellini-ThinkPad-T480s>
References: <alpine.DEB.2.21.2110251845500.4586@sstabellini-ThinkPad-T480s>
X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu)

Stefano Stabellini writes ("[PATCH v2] governance: communication channels"):
> Clarify that xen-devel is the only official communication channel.

Reviewed-by: Ian Jackson <iwj@xenproject.org>


From xen-devel-bounces@lists.xenproject.org Tue Oct 26 10:00:01 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Oct 2021 10:00:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.216335.375900 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfJFR-0007BE-0Q; Tue, 26 Oct 2021 10:00:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 216335.375900; Tue, 26 Oct 2021 10:00:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfJFQ-0007B7-TW; Tue, 26 Oct 2021 10:00:00 +0000
Received: by outflank-mailman (input) for mailman id 216335;
 Tue, 26 Oct 2021 09:59:59 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=TejW=PO=arm.com=Jiamei.Xie@srs-us1.protection.inumbo.net>)
 id 1mfJFO-0007Az-Vx
 for xen-devel@lists.xenproject.org; Tue, 26 Oct 2021 09:59:59 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com (unknown
 [2a01:111:f400:fe0e::62d])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 20d66c3f-603b-41b1-81c7-e75b7233dfbb;
 Tue, 26 Oct 2021 09:59:55 +0000 (UTC)
Received: from DB6P192CA0018.EURP192.PROD.OUTLOOK.COM (2603:10a6:4:b8::28) by
 HE1PR0802MB2491.eurprd08.prod.outlook.com (2603:10a6:3:de::23) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4628.20; Tue, 26 Oct 2021 09:59:42 +0000
Received: from DB5EUR03FT056.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:4:b8:cafe::d1) by DB6P192CA0018.outlook.office365.com
 (2603:10a6:4:b8::28) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.14 via Frontend
 Transport; Tue, 26 Oct 2021 09:59:42 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT056.mail.protection.outlook.com (10.152.21.124) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4628.18 via Frontend Transport; Tue, 26 Oct 2021 09:59:42 +0000
Received: ("Tessian outbound e27daf245730:v103");
 Tue, 26 Oct 2021 09:59:42 +0000
Received: from fd2e5854a14c.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 D6BB2F10-D3FA-492B-8EAE-FACCFC483AE9.1; 
 Tue, 26 Oct 2021 09:59:36 +0000
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id fd2e5854a14c.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Tue, 26 Oct 2021 09:59:36 +0000
Received: from VI1PR08MB3056.eurprd08.prod.outlook.com (2603:10a6:803:3d::28)
 by VI1PR08MB3773.eurprd08.prod.outlook.com (2603:10a6:803:bb::32)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.16; Tue, 26 Oct
 2021 09:59:34 +0000
Received: from VI1PR08MB3056.eurprd08.prod.outlook.com
 ([fe80::9528:d287:4b41:1ccc]) by VI1PR08MB3056.eurprd08.prod.outlook.com
 ([fe80::9528:d287:4b41:1ccc%4]) with mapi id 15.20.4628.020; Tue, 26 Oct 2021
 09:59:34 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 20d66c3f-603b-41b1-81c7-e75b7233dfbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=7Cm63ANI/4WQOOYL0nfpEe0BCVUOgAcGdQS0zt2itOs=;
 b=UoORpYaYtQ55FWo8bxXNNVN4yPLWHmzkXZmy5LO9d5GiSY3AHZivTC/KaefkZDrA2CcaF+YJFXAwkPiWEjhMLvpDoy8AJiX5WsULsKml1afEx6tPN2H27hiPZKONVR7koYvCBxZ9PPRUK7ZP6YQwnpdcAtSLnNUzWDYFnNkYbHw=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=QBNuaObu/dVDJ1wihGLYfTQPvbL7cA4WxPdGQEQjiSJhMtt6VY8d/yj2VEY06fMxk/Xzi35REFaz3YrBlXjAS0qxHIE5gE61XVonfnD1Wz2vsfTQ3H15YRRPg5A4oEK/y6LMUyTJHLGGj69s0e7StNqao0MXzHSc48rjAHoWLe9xf2LIpLkzwjRepzptMaX/CesDxUtIiogSZVbVKCNRB4uNdzXdcGw4oNY2s95xzSu/HBDOrEJk5WMFJMnwOHPymCp8+M5vK08ZOBPJC2MBYHp+RrqXYL8KD73fm30WBUrSROGpK7OF6aABrdbj6mufpLUnZE1Kzx9/GtLrMFN7/A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=7Cm63ANI/4WQOOYL0nfpEe0BCVUOgAcGdQS0zt2itOs=;
 b=VrQ+7iXJqx0l845Ybw104crtBEQsl+uOqPbAbGmeNJYz1jzkRKjRTXdYx+Dpc/r29dIkX+hd08MASKdxSNjhjrArVMWPqqtMjZ4+DshuvtgM+P4V5/WYxUuVuVBEd9fCx3n+N5C9MzIMVGhJ1wdd/kAYhnEgIAcBHxhfLDixRnSapslklGJbrOMOAi7LMbCVf+g0P36wN4ecSH5267VucUmZY71SMy5Sqi0kVOQSBRPZ6+paWgQczNK8bCHnIDtybZt+rl1NAKI3aDQGqtgjxnXoFf1jKjOHtTlydo1iqBQWpkbEuilAzLlzM6guHEeHURfnhi9IENmNvpZoR6vGYg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=7Cm63ANI/4WQOOYL0nfpEe0BCVUOgAcGdQS0zt2itOs=;
 b=UoORpYaYtQ55FWo8bxXNNVN4yPLWHmzkXZmy5LO9d5GiSY3AHZivTC/KaefkZDrA2CcaF+YJFXAwkPiWEjhMLvpDoy8AJiX5WsULsKml1afEx6tPN2H27hiPZKONVR7koYvCBxZ9PPRUK7ZP6YQwnpdcAtSLnNUzWDYFnNkYbHw=
From: Jiamei Xie <Jiamei.Xie@arm.com>
To: Juergen Gross <jgross@suse.com>, Jiasheng Jiang <jiasheng@iscas.ac.cn>,
	"boris.ostrovsky@oracle.com" <boris.ostrovsky@oracle.com>,
	"sstabellini@kernel.org" <sstabellini@kernel.org>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2] xen: Fix implicit type conversion
Thread-Topic: [PATCH v2] xen: Fix implicit type conversion
Thread-Index: AQHXyjurcY7tN33IlE6GkuPKa9q2jKvk4+KAgAAnZaA=
Date: Tue, 26 Oct 2021 09:59:34 +0000
Message-ID:
 <VI1PR08MB30564CABD02DBB0F17BBDCDD92849@VI1PR08MB3056.eurprd08.prod.outlook.com>
References: <1635233531-2437704-1-git-send-email-jiasheng@iscas.ac.cn>
 <01fd083e-e9a6-c019-0a74-bf28b2982412@suse.com>
In-Reply-To: <01fd083e-e9a6-c019-0a74-bf28b2982412@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: EA29A9CC81D4E14583D764E12361A4D9.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: 58abb677-8382-4020-c225-08d9986754d0
x-ms-traffictypediagnostic: VI1PR08MB3773:|HE1PR0802MB2491:
X-Microsoft-Antispam-PRVS:
	<HE1PR0802MB249182065BB3CA2C4188442292849@HE1PR0802MB2491.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:6108;OLM:6108;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 uPAuM4Rgqb9FxKHTU4H2zurBOk2TCXHxY9Q86L58nGp0WTBRS0cXOAXPUNYzJuwOtOkZ2xwbF7mdcWtCYtFlXxaqCJQPzj+P9Ngx8sCvfTGXL3MqoRG6+4Z7q3EISFrFuuc52pGfnU4+04AQ2zaJGOhduQxThGmwqLNMPYoJWhqqW8MiWWliXrKvlK+6RqpdbYQfrQnC1Zqv4hZPUpNA4gKm4BaVks9IoSDeM1iY0GRoafBLq9XGHMskCh4HIEiQN+VjV7xYy+I2UCTPABOiQjiY7ae/PhZQw/JBs3IEEEm7N5DznZnFVwKxm8jOHj1VycWboJJsrizGPHtCKeAav+lKtgYX2vF08CeUOuEjEpt8Ozpd/ipSJWM5JIy6swWGDnoI1smSbhltRVdtO5fHKAB4PIdNRxDHbpZvXk5NmQWrTTrS+tjZyBM2g0zroEiqcslvMJCT5ygWJ/ohPtg0bx4x8/SsVu4WkxHodnHGUcOE4kl7YiDantXrgQ3hB2kMz95Lx9rMfFMheKXdAKCZ05s+YbKjGwhxIsGPKa2kRjLR1ej7Cbs7OCgkRycUG6FIMS0QUIomki9n/5pirm3SclZtuQHivDYeLkPWW0KfPPvdd2LnuW8VRs0ne4T7suJ5xTsaMcs4WJNbGY6c+Iqp2AGdUodgshygY0b96mvVfQ2JaaXeD1N//aBUi4N2LuW0LVP+SPqGRJxHv864oJ5S9w==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR08MB3056.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(66556008)(38070700005)(55016002)(64756008)(54906003)(86362001)(9686003)(8936002)(66476007)(38100700002)(8676002)(110136005)(2906002)(76116006)(71200400001)(5660300002)(7696005)(52536014)(33656002)(508600001)(186003)(122000001)(66446008)(316002)(83380400001)(6506007)(26005)(66946007)(4326008)(53546011);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3773
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT056.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	e2fdcc41-aa2e-4e07-bf96-08d998675076
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Rn8wOK8l8zO0x1qnXsTsHsm5HHUVM++Q7OZryVoBsOl5ssPIr/fzE94kkzOc6g7A+X7EuWT5ISVeSxxCdssBwFmSvm7pzvLt89zMg5R5n0toFzjA1qKgtIFGSD+uEO+AFKzRcwih2PVRO2aKu189wokY3vrX8pEv5Hj8snRNSLXo/izH/oYYSECP3aP7weECaiaxJIFzm9v14lJSzoEjuRLe7w2gaCZkbwJAtoEFnjvY7y31WnQBD7gVnd4Zfe46UI6YB54xISUaTYBHt4wqt06DU/VDm9fBaLk74XTOAD29Ue2bUTvUM+Cb/v1Tqbdm9ArXs6LZTxohBmupu2+dyjpOKMJpqPjkDq2IbQOdGmpzs+e5trJqfTEAt03n9RZpiGjVtm9xE4abeOjLeHyL1otVse+xcDQgHgYya73Y8jtQfnMz2WU9dS3+Xt4fc5aoeUvS2ROz66TszCEPReh4yTasl2GNfi5rK4MYruLwIJPYqQ9tGfGGZsB6pynAy5tqukvSXR3xRm+zFmYVyRJTmevx4G/Ga94XnSHDGyGImAFZDRVuLI5nqYvqtJx0uFlLNK2gKKDvTdGOgvWLfxuUo9rvxLiWK0Fma1XGX+m4+RYg1NhKF9h+1mcrAJE+Mcs5ELkR78hAw+SHpV1fFt/ReFpzKcrLEMaXGjIDAAq0UikO5G3YXNskvXO63NqGpEgZhrlF5fnRDooc0ZPLVKlqNw==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(5660300002)(107886003)(86362001)(36860700001)(33656002)(83380400001)(82310400003)(47076005)(356005)(316002)(81166007)(52536014)(336012)(110136005)(7696005)(186003)(2906002)(53546011)(6506007)(26005)(4326008)(508600001)(70206006)(8676002)(8936002)(9686003)(70586007)(54906003)(55016002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2021 09:59:42.1586
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 58abb677-8382-4020-c225-08d9986754d0
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT056.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0802MB2491

DQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogWGVuLWRldmVsIDx4ZW4t
ZGV2ZWwtYm91bmNlc0BsaXN0cy54ZW5wcm9qZWN0Lm9yZz4gT24gQmVoYWxmIE9mDQo+IEp1ZXJn
ZW4gR3Jvc3MNCj4gU2VudDogMjAyMeW5tDEw5pyIMjbml6UgMTU6MzYNCj4gVG86IEppYXNoZW5n
IEppYW5nIDxqaWFzaGVuZ0Bpc2Nhcy5hYy5jbj47IGJvcmlzLm9zdHJvdnNreUBvcmFjbGUuY29t
Ow0KPiBzc3RhYmVsbGluaUBrZXJuZWwub3JnDQo+IENjOiB4ZW4tZGV2ZWxAbGlzdHMueGVucHJv
amVjdC5vcmc7IGxpbnV4LWtlcm5lbEB2Z2VyLmtlcm5lbC5vcmcNCj4gU3ViamVjdDogUmU6IFtQ
QVRDSCB2Ml0geGVuOiBGaXggaW1wbGljaXQgdHlwZSBjb252ZXJzaW9uDQo+IA0KPiBPbiAyNi4x
MC4yMSAwOTozMiwgSmlhc2hlbmcgSmlhbmcgd3JvdGU6DQo+ID4gVGhlIHZhcmlhYmxlICdpJyBp
cyBkZWZpbmVkIGFzIFVJTlQuDQo+ID4gSG93ZXZlciBpbiB0aGUgZm9yX2VhY2hfcG9zc2libGVf
Y3B1LCBpdHMgdmFsdWUgaXMgYXNzaWduZWQgdG8gLTEuDQo+ID4gVGhhdCBkb2Vzbid0IG1ha2Ug
c2Vuc2UgYW5kIGluIHRoZSBjcHVtYXNrX25leHQoKSBpdCBpcyBpbXBsaWNpdGx5DQo+ID4gdHlw
ZSBjb252ZXJzZWQgdG8gSU5ULg0KPiA+IEl0IGlzIHVuaXZlcnNhbGx5IGFjY2VwdGVkIHRoYXQg
dGhlIGltcGxpY2l0IHR5cGUgY29udmVyc2lvbiBpcw0KPiA+IHRlcnJpYmxlLg0KPiA+IEFsc28s
IGhhdmluZyB0aGUgZ29vZCBwcm9ncmFtbWluZyBjdXN0b20gd2lsbCBzZXQgYW4gZXhhbXBsZSBm
b3INCj4gPiBvdGhlcnMuDQo+ID4gVGh1cywgaXQgbWlnaHQgYmUgYmV0dGVyIHRvIGNoYW5nZSB0
aGUgZGVmaW5pdGlvbiBvZiAnaScgZnJvbSBVSU5UDQo+ID4gdG8gSU5ULg0KPiA+DQo+ID4gRml4
ZXM6IDNmYWMxMDEgKCJ4ZW46IFJlLXVwbG9hZCBwcm9jZXNzb3IgUE0gZGF0YSB0byBoeXBlcnZp
c29yIGFmdGVyIFMzDQo+IHJlc3VtZSAodjIpIikNCj4gPiBTaWduZWQtb2ZmLWJ5OiBKaWFzaGVu
ZyBKaWFuZyA8amlhc2hlbmdAaXNjYXMuYWMuY24+DQo+IA0KPiBSZXZpZXdlZC1ieTogSnVlcmdl
biBHcm9zcyA8amdyb3NzQHN1c2UuY29tPg0KPiANCj4gDQo+IEp1ZXJnZW4NCg0KW0ppYW1laSBY
aWVdIA0KUmV2aWV3ZWQtYnk6IEppYW1laSBYaWUgPGppYW1laS54aWVAYXJtLmNvbT4NCg0K


From xen-devel-bounces@lists.xenproject.org Tue Oct 26 10:04:40 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Oct 2021 10:04:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.216344.375910 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfJJs-0000H1-JQ; Tue, 26 Oct 2021 10:04:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 216344.375910; Tue, 26 Oct 2021 10:04:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfJJs-0000Gu-G0; Tue, 26 Oct 2021 10:04:36 +0000
Received: by outflank-mailman (input) for mailman id 216344;
 Tue, 26 Oct 2021 10:04:34 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mfJJq-0000Gl-Ki
 for xen-devel@lists.xenproject.org; Tue, 26 Oct 2021 10:04:34 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mfJJq-0005yu-HA
 for xen-devel@lists.xenproject.org; Tue, 26 Oct 2021 10:04:34 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mfJJq-0003EX-G9
 for xen-devel@lists.xenproject.org; Tue, 26 Oct 2021 10:04:34 +0000
Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89)
 (envelope-from <iwj@xenproject.org>)
 id 1mfJJm-00044f-Oh; Tue, 26 Oct 2021 11:04:30 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:To:Date:
	Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From;
	bh=Yjl1rcjFEXjSLwz2EKQBWco4zIP0G975jub8mTc1d04=; b=BYJYp7ARy/9MzRC4WXu57u2GaR
	fEs+a3WvCynTYKGmxPDOlQWvMxm82KQ6x1OkO9u5Fg6IKcwl9UW/D9wceUEI809G9Pwkg6EwONoxv
	HCBxOrSLaVsfwrsi2YNFpK2FW79Ml3IsWYdGLxBM4UcPQga1j2xYHP1tFjBkbIiOUbiI=;
From: Ian Jackson <iwj@xenproject.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <24951.53934.212971.950346@mariner.uk.xensource.com>
Date: Tue, 26 Oct 2021 11:04:30 +0100
To: Juergen Gross <jgross@suse.com>,
    xen-devel@lists.xenproject.org
Subject: Re: [PATCH v2] OSStest: explicitly enable building qemu-traditional
In-Reply-To: <24950.53501.802356.661667@mariner.uk.xensource.com>
References: <20211025095438.27599-1-jgross@suse.com>
	<24950.53501.802356.661667@mariner.uk.xensource.com>
X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu)

Ian Jackson writes ("Re: [PATCH v2] OSStest: explicitly enable building qemu-traditional"):
> Juergen Gross writes ("[PATCH v2] OSStest: explicitly enable building qemu-traditional"):
> > It is planned to no longer build qemu-traditional per default.
> > 
> > In order to be able to continue running tests with ioemu-stubdom run
> > configure with --enable-qemu-traditional.
> > 
> > Signed-off-by: Juergen Gross <jgross@suse.com>
> 
> Acked-by: Ian Jackson <iwj@xenproject.org>
> Release-Acked-by: Ian Jackson <iwj@xenproject.org>
> 
> And pushed to osstest pretest.  I will let you know how it goes.

This passed the self-test (so it is in producetion), but, I observe
that it does this[1]:

                   if grep -q --  tools/configure ; then
                       qemutrad=
                   fi
   ...
   + grep -q -- tools/configure

I think this only works because the build has its stdin redirected
from /dev/null.  That's not going to change so it's not a bug but it
seems quite odd and possibly a latent bug.

Thanks,
Ian.

[1]
http://logs.test-lab.xenproject.org/osstest/logs/165863/build-arm64-xsm/6.ts-xen-build.log
http://logs.test-lab.xenproject.org/osstest/logs/165863/build-arm64-xsm/info.html


From xen-devel-bounces@lists.xenproject.org Tue Oct 26 10:30:02 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Oct 2021 10:30:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.216351.375921 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfJiO-0002h9-AU; Tue, 26 Oct 2021 10:29:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 216351.375921; Tue, 26 Oct 2021 10:29:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfJiO-0002h2-7S; Tue, 26 Oct 2021 10:29:56 +0000
Received: by outflank-mailman (input) for mailman id 216351;
 Tue, 26 Oct 2021 10:29:54 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mfJiM-0002go-RZ; Tue, 26 Oct 2021 10:29:54 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mfJiM-0006NM-Lt; Tue, 26 Oct 2021 10:29:54 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mfJiM-0007u5-Ca; Tue, 26 Oct 2021 10:29:54 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mfJiM-00081x-C8; Tue, 26 Oct 2021 10:29:54 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=ztfmCna2jR3ktll7rEDfoaRQoOKOIlGoKS/xmcR+H98=; b=epuoQoGMa79aecqh4SAwjsNXQt
	+MVdOXCVaLbeTE4u2jUP3U8KP4YcUY50XvquFLwghtPTnDaENgoQ3jD5kjU7vN+avVporVsQymfeW
	qqfFIOeznkapYGsPNbREZThtr1FuC0KX9kyo52do6C2iywpok1RBxD2SPrGxleMlVIGg=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165866-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 165866: regressions - FAIL
X-Osstest-Failures:
    qemu-mainline:build-i386:xen-build:fail:regression
    qemu-mainline:build-i386-xsm:xen-build:fail:regression
    qemu-mainline:build-armhf:xen-build:fail:regression
    qemu-mainline:test-amd64-amd64-qemuu-nested-intel:debian-hvm-install:fail:heisenbug
    qemu-mainline:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-amd:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-pair:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-freebsd10-i386:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-freebsd10-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-coresched-i386-xl:build-check(1):blocked:nonblocking
    qemu-mainline:build-armhf-libvirt:build-check(1):blocked:nonblocking
    qemu-mainline:build-i386-libvirt:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-intel:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-shadow:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-vhd:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=c5b2f559814104f4145f8bc310f4d33c7ead8f49
X-Osstest-Versions-That:
    qemuu=50352cce138ef3b30c1cda28a4df68fff5da3202
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 26 Oct 2021 10:29:54 +0000

flight 165866 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165866/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-i386                    6 xen-build                fail REGR. vs. 165682
 build-i386-xsm                6 xen-build                fail REGR. vs. 165682
 build-armhf                   6 xen-build                fail REGR. vs. 165682

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-qemuu-nested-intel 12 debian-hvm-install  fail pass in 165855

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl           1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-credit2   1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-cubietruck  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-multivcpu  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-rtds      1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-vhd       1 build-check(1)               blocked  n/a
 test-amd64-i386-qemuu-rhel6hvm-amd  1 build-check(1)               blocked n/a
 test-amd64-i386-pair          1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-freebsd10-i386  1 build-check(1)               blocked  n/a
 test-amd64-i386-freebsd10-amd64  1 build-check(1)               blocked  n/a
 test-amd64-coresched-i386-xl  1 build-check(1)               blocked  n/a
 build-armhf-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-arndale   1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-credit1   1 build-check(1)               blocked  n/a
 test-amd64-i386-qemuu-rhel6hvm-intel  1 build-check(1)             blocked n/a
 test-amd64-i386-xl            1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-pvshim     1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-qemuu-debianhvm-amd64  1 build-check(1)         blocked n/a
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow  1 build-check(1)  blocked n/a
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm  1 build-check(1)      blocked n/a
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 1 build-check(1) blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a
 test-amd64-i386-xl-qemuu-win7-amd64  1 build-check(1)              blocked n/a
 test-amd64-i386-xl-qemuu-ws16-amd64  1 build-check(1)              blocked n/a
 test-amd64-i386-xl-shadow     1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-vhd        1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-xsm        1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165682
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165682
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165682
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 qemuu                c5b2f559814104f4145f8bc310f4d33c7ead8f49
baseline version:
 qemuu                50352cce138ef3b30c1cda28a4df68fff5da3202

Last test of basis   165682  2021-10-19 21:09:14 Z    6 days
Failing since        165694  2021-10-20 18:09:12 Z    5 days   13 attempts
Testing same since   165823  2021-10-24 00:36:48 Z    2 days    5 attempts

------------------------------------------------------------
People who touched revisions under test:
  Alistair Francis <alistair.francis@wdc.com>
  Andrew Jones <drjones@redhat.com>
  Ani Sinha <ani@anisinha.ca>
  BALATON Zoltan <balaton@eik.bme.hu>
  Bin Meng <bmeng.cn@gmail.com>
  Cédric Le Goater <clg@kaod.org>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  David Gibson <david@gibson.dropbear.id.au>
  David Hildenbrand <david@redhat.com>
  Eric Auger <eric.auger@redhat.com>
  Eugenio Pérez <eperezma@redhat.com>
  Frank Chang <frank.chang@sifive.com>
  Gavin Shan <gshan@redhat.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Greg Kurz <groug@kaod.org>
  Gustavo Romero <gromero@linux.ibm.com>
  Igor Mammedov <imammedo@redhat.com>
  Jason Wang <jasowang@redhat.com>
  John Wang <wangzhiqiang02@inspur.com>
  John Wang <wangzq.jn@gmail.com>
  Laurent Vivier <laurent@vivier.eu>
  Laurent Vivier <lvivier@redhat.com>
  Luc Michel <lmichel@kalray.eu>
  Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
  Matheus Ferst <matheus.ferst@eldorado.org.br>
  Mathieu Poirier <mathieu.poirier@linaro.org>
  Michael S. Tsirkin <mst@redhat.com>
  Mingwang Li <limingwang@huawei.com>
  Oğuz Ersen <oguzersen@protonmail.com>
  Philipp Tomsich <philipp.tomsich@vrull.eu>
  Philippe Mathieu-Daudé <f4bug@amsat.org>
  Philippe Mathieu-Daudé <philmd@redhat.com>
  Richard Henderson <richard.henderson@linaro.org>
  Shuuichirou Ishii <ishii.shuuichir@fujitsu.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Thomas Huth <thuth@redhat.com>
  Tong Ho <tong.ho@xilinx.com>
  Travis Geiselbrecht <travisg@gmail.com>
  Vincent Palatin <vpalatin@rivosinc.com>
  Xueming Li <xuemingl@nvidia.com>
  Yanan Wang <wangyanan55@huawei.com>
  Yifei Jiang <jiangyifei@huawei.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               fail    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          blocked 
 test-amd64-i386-xl                                           blocked 
 test-amd64-coresched-i386-xl                                 blocked 
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  blocked 
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       blocked 
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           blocked 
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     blocked 
 test-amd64-i386-freebsd10-amd64                              blocked 
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          blocked 
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          blocked 
 test-armhf-armhf-xl-arndale                                  blocked 
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  blocked 
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  blocked 
 test-armhf-armhf-xl-cubietruck                               blocked 
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         blocked 
 test-amd64-i386-freebsd10-i386                               blocked 
 test-amd64-amd64-qemuu-nested-intel                          fail    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         blocked 
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                blocked 
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         blocked 
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 blocked 
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    blocked 
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     blocked 
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              blocked 
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    blocked 
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      blocked 
 test-amd64-i386-xl-vhd                                       blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 3631 lines long.)


From xen-devel-bounces@lists.xenproject.org Tue Oct 26 10:36:11 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Oct 2021 10:36:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.216361.375936 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfJoN-0004Am-4c; Tue, 26 Oct 2021 10:36:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 216361.375936; Tue, 26 Oct 2021 10:36:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfJoN-0004Af-1V; Tue, 26 Oct 2021 10:36:07 +0000
Received: by outflank-mailman (input) for mailman id 216361;
 Tue, 26 Oct 2021 10:36:06 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=d0pl=PO=citrix.com=roger.pau@srs-us1.protection.inumbo.net>)
 id 1mfJoL-0004AZ-Od
 for xen-devel@lists.xenproject.org; Tue, 26 Oct 2021 10:36:06 +0000
Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 221b2cdf-7f71-4f5d-8db9-7f7f8b5e79c1;
 Tue, 26 Oct 2021 10:36:03 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 221b2cdf-7f71-4f5d-8db9-7f7f8b5e79c1
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1635244563;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=6K0QuZDpLKvERMWwE3Nglbw6L07CNVdJa7H55MNjY6M=;
  b=Iezp/DiPOFiRRQnoWcbNEvKwbtHwC4avydNk6aZWwJ8nrdUUAeehFmcE
   6+Z1tca7McwIa1347rNyag48dxgXaWsoXPTlJbR7PSnLgVPLR4LuQ1QtG
   4mcafXgwL4m8zgaJkcJh7e6WRkDqeyQk9IDbOT5fiVLF0D62h/Ntv3PKL
   k=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: Jzd1dVpxVtIsLLl4oxkvx/iBUpgtGYSAWFxE5hbfce5dSaYe320Pbo5h9jVrjfO1ICQv34IU7V
 x5o1suUyG8JpjQcb1kNnL4UAyOLGGpW9S344srOnFD34resMuAvRRuRnEZDTKv4CoeeFmvfFqH
 xWqt8MKCwhO4KJjb0zQmHMCYt3a/mMxUVCFxuhO/sTSX06vGxt7htvlmvTlMDkGkH00OIPxAAU
 yU8emZHWE0ikh8ZEE5BFaqt8zW1HpBkLdYpMOFS7HbReJiQwDcwyBfGPqNjWi6bqp3OM4ffpMo
 BaxfVcs1BuTgzIXQcd5hN61s
X-SBRS: 5.1
X-MesageID: 55621280
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:rKInWaKCQ45qdlUoFE+R85MlxSXFcZb7ZxGr2PjKsXjdYENS1WMDn
 2BMXG7UbvqCZWWkLYtwO4638U5S6pbcmIVnGVBlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s
 q3yv/GZdJhcokcxIn5BC5C5xZVG/fjgqoHUVaiUZUideSc+EH140Eo5xbZj6mJVqYPR7z2l6
 IuaT/L3YDdJ6xYsWo7Dw/vewP/HlK2aVAIw5jTSV9gS1LPtvyB94KYkDbOwNxPFrrx8RYZWc
 QphIIaRpQs19z91Yj+sfy2SnkciGtY+NiDW4pZatjTLbrGvaUXe345iXMfwZ3u7hB2KluAv2
 osdtaCQVDkVFILwqNwhdhdXRnQW0a1uoNcrIFC6uM2XiUbHb2Ht07NlC0Re0Y8wo7gtRzsUr
 LpBdW5LPkvra+GemdpXTsF2gcsuNo/zNZ43sXB81zDJS/0hRPgvRo2XuIEChW1g3qiiG978Z
 cREcjNtYi3fekJqAk9LDKg9vfWn0yyXnzpw9wvO+PtfD3Lo5A573aXpMdHVUseXXsgTlUGdz
 krv5Xj0ByY/JdOWyDeb2n+0j+qJliT+MKoYGaek7PdsjBuWz3YKFRwNfVKhpL+yjUvWc9VbJ
 k8P8ywit5878kCxU8L9VB21pn2DlhMEUt8WGOo/gCmXw6rJ50CCB24LThZIctlgv8gzLRQ00
 VuOk8LsFCZYurSfQnKA9Z+ZtTq3fyMSKAcqdSICCAcI/dTniIUylQ7UCMZuFravid/4Ei22x
 CqFxAA3gbkJ15ZTj420+FnGh3SnoZ2hZgwo4gTaWEq14wU/Y5SqD6Sv7VXY9v9GIJyuUkiav
 HMEls6d68gDFZiI0ieKRY0lB6q17vyINDndh19HHJQ78TmpvXm5cuhtDCpWfRkzdJxeIHmwP
 RGV6Vg5CIJv0GWCbqZHPZDvW8QW7bXeKf7KasDsUv9Abc0kHOOYxx1GaUmV1mHrtUEjl6AjJ
 JuWGfqR4WYm5bdPl2XuGb9MuVM/7mVnnzmLHMGkp/iy+ePGPCb9dFsTDLeZggnVBou/qwLJ7
 80XCcKOzxhOOAEVSniKqdBNRbzmwH5SOHwXlyC1XrLcSuaFMDt4YxM0/V/GU9c995m5bs+So
 hmAtrZwkTITf0HvJwSQcWxEY7jyR5t5pn9TFXVyZgvxiyh6MNf/vfZ3m34LkV4Pr7QL8BKJZ
 6NdJ5Xo7gpnE2yvF8shgWnV89U5KUXDafOmNCu5ejkvF6OMtCSSkuIIijDHrXFUZgLu7JNWi
 +T5imvzHMpSLyw/XZ2+QK/+kDuMUY01xbsas73geYIIJi0BMeFCdkTMsxPAC5tcdUmanWDKi
 V3+7NVxjbClnrLZOeLh3Mish4yoD/F/DgxdGWza5qyxLi7U4iyoxooobQpCVWm1uLrc9Prwa
 ONL4ev7NfFbzl9Gv5AlS+RgzL4k5suprLhfl1w2EHLOZlWtK7VhPnjZgpUf6vwTnudU6VmsR
 0aC2thGIrHVasnrJ0EceVg+ZeOZ2PBKxjSLtaYpIF/37TNc9aacVRkAJAGFjSFQdeMnMI4sz
 eo7ltQR7giz1kgjPtqc13gG/GWQNH0QFa4gs8hCUoPsjwMqzHBEYIDdVXCqsM3eNY0UPxBzc
 DGOhafEi7BN/Wb4ciI+RSrXwO5QpZUSoxQWnlUMEEuEx4jejfgt0RwPrTluFlZJzg9K2v5YM
 3RwMxEnPr2H+jpliZQRX22oHA0dVhSV9laolgkMnWzdCUKpSnbMPCs2PuPUpBIV9GdVfz56+
 rCEyTm6DWa2LZ+phiZiC1R4r/HDTMBq8lyQkc+qKM2JAp0mbGe3maSpf2cJ90PqDM5ZaJcrf
 gW2EDKcsZHGCBM=
IronPort-HdrOrdr: A9a23:0zC8D6Mdg4i5zcBcTsWjsMiBIKoaSvp037BN7TEXdfU1SL39qy
 nKpp8mPHDP5Ar5NEtOpTniAsm9qBHnm6KdiLN5Vd3OYOCMggqVBbAnwYz+wyDxXw3Sn9QtsJ
 uIqpIOa+EY22IK7/rH3A==
X-IronPort-AV: E=Sophos;i="5.87,182,1631592000"; 
   d="scan'208";a="55621280"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ja7DKWaYVs2Y8i9A8VXVqlmNAeJiNxgk20NYwiEy7n/Zxu+qQfw9OQMfZo+VnsvX4O1G0AFqzOm9AJaRetsN5oDcaIdrLzgwnuEmlegmcpAx+VR/XE/xNjiKqbb/gGql/u8FD707P2A0mIxJ9XNKe710VAH24XX9WkFtiz/cx5mx2VabU8dvX1cwzf7TYYj7EcXZQtETOSBahnvA/1kxNZCi+n0zNbmpuN4h0YRH4ZJFBlTztAmJRKSfr7DkXCjpHAHKi8ydztXM5lRJeyBierI/OxYYN6OticWkwxJDvVyb+IYQj+8Q2nxV+9d8t3Z16nYTgYh9bW52Xvg+eQDflw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=0Vmesls1fMP5JrkhPFpoWML/guw/Cs719OE1dAa1P7g=;
 b=lbO6TuRPHX6ZubjI9f6MO6kcQQdjefW1X9I+9+4h9VuJg43VQImWtUKGh4d4PXS4vhJR67UeXf8cZipWe/rChdkteJlEodv8kyCc2UWFJ+O3ZH9MstYGkJiurlydCHzCIBMOHjONUxk5DgdXi9RHQQYxmujoxAOwdcnMaJmdDqgtbzpJnXyIQS18mecth9LApqROZYVWt0+IApEq3ewltaX2yzebYRbUpgge6T+0evy1e/jnw/84+QogJu2ddehlmVy7FPt6kQ130dTcGh3oPT539FsdaL8g5PxqRlXBw3/0J41osBY8YYPaJwWX0xwnHwY8T54Q4AvCnIrhnPj1Cw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=0Vmesls1fMP5JrkhPFpoWML/guw/Cs719OE1dAa1P7g=;
 b=paI9JEv8gLJlOiGsjNwFOsr1uvD0+ArdL0bBQ7j/x0nqrUzkMTEAwqpyCTQ7JGG9i4P9iWDyCAYhEMPIgz+tAVK+na1q4FSuPmns1WSd5zVH6Rhgr71LmVMJvrgVpFZNNlGmXOj10H/1Wcu5KlDVCY73H5eGcx1vebnR6PlQN7o=
Date: Tue, 26 Oct 2021 12:35:54 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Oleksandr Andrushchenko <andr2000@gmail.com>
CC: <xen-devel@lists.xenproject.org>, <julien@xen.org>,
	<sstabellini@kernel.org>, <oleksandr_tyshchenko@epam.com>,
	<volodymyr_babchuk@epam.com>, <Artem_Mygaiev@epam.com>, <jbeulich@suse.com>,
	<bertrand.marquis@arm.com>, <rahul.singh@arm.com>, Oleksandr Andrushchenko
	<oleksandr_andrushchenko@epam.com>
Subject: Re: [PATCH v3 07/11] vpci/header: program p2m with guest BAR view
Message-ID: <YXfaCgRpQJbBNaD2@MacBook-Air-de-Roger.local>
References: <20210930075223.860329-1-andr2000@gmail.com>
 <20210930075223.860329-8-andr2000@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20210930075223.860329-8-andr2000@gmail.com>
X-ClientProxiedBy: MR2P264CA0003.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:500:1::15) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: a3b31639-86d8-46b3-eab8-08d9986c665b
X-MS-TrafficTypeDiagnostic: DM6PR03MB4604:
X-Microsoft-Antispam-PRVS: <DM6PR03MB4604291367EA1A5D478BB4208F849@DM6PR03MB4604.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:3173;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: T+QDcsDg2DeWgJqYRo0u5NfiHnsaftKChRE1YG9oJhpTIaNcXfsuW5+Zi2r4qRe58i6PeIHImnsgME5fZO9KOqQwfn7XFPwxhJS9Bi5nT/emUgYOt6SFPx1F8z7mDkYMBrNOiWSAILRHz6dn3+cNg/KZ1NiKu2gcMQxzPZB8x+5/pTq9FQZOoAuJClSoPLnsVEohOeJEik9M2XPcAISSu/bXOWDuXu4svtRuBr3sw0yqJ0Mt8e5ShOqxfAFx/m6y25+0SOI2rtOlZ5fxN5oWeotQyRk8ZFXW4op9iX5wlyxcvXreoyD5jFh5znzWKPczkDTRgQclcpSNUxmgCWah9g7f/D+FWQf54DCxmRn/NnTefmS+ev2icnGZlnx1GS1HyKtbsPwFUiS9h9Ig/jgh03AC+kTzKBYhoMZM4ZWMpaXQpT17wB0dynyNcr7xkTDqTEwrdvn0OufCIOrLImmWNIARgYyxfhkBZZU/efVBttPmSN6uHr+0qYR66jWx24MTvRCaas0geIgsh4+SeNxo76+r1tJ/bpMl6aHMxv58GrrjULlPDLhtkcoU2YiDNh+YuLsib/Ju6DNh8QFqwcpmA6w0AR0bnv9tpk82Bd2qwtlxu2sSejV2wXrKZAskOZlJq+XfcirKkvpmVbrFBtBDDA==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(6666004)(6916009)(508600001)(7416002)(5660300002)(83380400001)(86362001)(316002)(2906002)(66556008)(6486002)(186003)(8676002)(66946007)(66476007)(956004)(8936002)(26005)(38100700002)(4326008)(85182001)(82960400001)(9686003)(6496006);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dDRjMXdWSXpYZms5VVJMMDJsMzA5NDVyMy91QlQvWlVJdEJ5OWl4TmNvZ2ty?=
 =?utf-8?B?eWw1eUszL01rMC9nejFZSyt4QUxzOEhWTUVJY205Y2ticGRtY0h2LzJra0J2?=
 =?utf-8?B?K3pwSHd0Njhhc21rVHBnMzZpOFkxVHBjaHhmemIvMCs3SytaTmlESVNqUTBq?=
 =?utf-8?B?ZjNaV2s0aTJkWXo2ZVZaZUdnaExScmZHdWNua1NOd2wxRmw0WThDcGFsMTh0?=
 =?utf-8?B?bGFrSGtpY1Q3L2h1RkVBTUtvdys0WjZ2Nmt6OHl1Y3ppTGJhYWxRaElQK1Q4?=
 =?utf-8?B?UVEzeDZiMmFPNmM4SDJoRzBRb0Q4dFFrZDB5aFdyZ2w4V0xMNjZKUTkyNklL?=
 =?utf-8?B?MmV4NWNjQmFSM0cxRzlsU0hKRm5nZXlwWU9sc2RaWGRja090WWEyQUtxcEZR?=
 =?utf-8?B?Q1J2T08wT2NDRHlqVk54WUFXazhwRklISWdqcEVLN0E4bTg2VEUyNlZGaEJ3?=
 =?utf-8?B?MGtDU3VWQ2dUU0krcmR6SS9hRHp5c2h0MmpKSC8yblo2Mm9WNzV5UEQ1VzVC?=
 =?utf-8?B?eUYxWjN0TzdtTTNXRTJWdDczMndDbXNyY3lsWllqTVVPa0Y2TXZ1YWN3TlZv?=
 =?utf-8?B?TUtJd2srTzJ5Y2xqUHZoQll0SmlnQkJNTWVwaHdyV1FyS1hXcmlmM0ZpWk5P?=
 =?utf-8?B?Vjcrck5tRE5CT2VhL2c5MkNOamk4cjFObzJTakhia2ZDd1FZbkVabnpEN1JV?=
 =?utf-8?B?MExiNk1XalNUYTBpVGMyQXA0MXhBcnY0aSsrVTJ5SElUOGIrQ2hQTDhpdlNJ?=
 =?utf-8?B?eDFiREszWUdJd1NhT3dCdkJIaDB3QjBIUHNEMFJ1R2tKZkRuR0tlbkNNYVV0?=
 =?utf-8?B?NWlmZG54dHBVMVlQaDllOGtKRjk3blR2bGNSVUplaEZuSTAzUEdxOGdGbGpR?=
 =?utf-8?B?TnlXQSt6Qm02WmRCZ1B0bjhLOG1LMWMwRUJ5cmd1YU1ESE1zWnhxazd2L0VQ?=
 =?utf-8?B?aEhJVmdqd0RRTS83YWROQjhyYUI4Z21QeTM0d1VwdUhET0ZRY3piNnBmT0l5?=
 =?utf-8?B?WmZPMlNEdUxWTTZQcnJ1N21NbVdmNjBDajFJaE1PWTR3NEtvb05ZUWY4dnIw?=
 =?utf-8?B?Wnk5WUxWYTd4QTYwZWlRWExLcHNIVUgzZ2RXYVh3ZlZLT3c5N0JQeU1Vczdr?=
 =?utf-8?B?MmM1ZWRXRDVDR0JMWERSTlVlSDN4aXJVR1pjcG5kT3pZQzZxK2tsT2V1UXZR?=
 =?utf-8?B?Tnl6dmdSQUNrYWNjVmVJT1AvNjhGNjFFNjJOclpFcld3WXJzV1RUVFVZcTc2?=
 =?utf-8?B?aUYvcUQwTlV3emdoeEZ5NHNnQ0tKSCtueHpSQzJnbTA5ZXpUajh1M3k5Ny8y?=
 =?utf-8?B?OWdlWFV2SERxZWhpL2FOYnQzdkxrTFRQZ2FUMGtGNGdOblZGUmVPelJSUnQy?=
 =?utf-8?B?cHVjOE9KSnlZWEFPSzBoTUlrV3haM0hFVklnYURSb0xxZVdQbXpNQzlOUitk?=
 =?utf-8?B?bW9rM01UL1JaQW5iQ0hLaExNR2lqS3ZRU3BvU0p2VGg3L0pMd0hjYlk1N1I5?=
 =?utf-8?B?d0ZwcW1CMUNGR2FiRmk3VU9oOC9DakgyamhsQStjeTdFN0lIdkxXeCt3OTJq?=
 =?utf-8?B?NStxTVUxbTRIWlg0RWFIakd4SHJKMzFqT3JmbFcxVXIzZnp3aEZSNjdkMm5F?=
 =?utf-8?B?V2FWcDdsbXAwVzNqMTBtYVplM1N1dFF4d29qRlNHTXlQN051YVoxaGh5YkF2?=
 =?utf-8?B?SW93cWpzNWVRY3VRYUNwV3ZQQnhFekxIK0dpVVNEUUs0NmFTN2h5V3VKSGI5?=
 =?utf-8?B?bGFrZU1ZMndzWUZ1WS9YZGtBeDQ2VGkrUGtiTS9SUnJWUXBWc1RJU2hqRzNK?=
 =?utf-8?B?aW96TVMxNitha0xMQnlDTU5pK1c1MFFIWTFuNlY1b1ZBVkR6eDRibTZFZ1Fm?=
 =?utf-8?B?THNBUXR0dGZhOEF3KzRSRUFiUUpIdnk3U2Fvb0V6czBsMjZ5alZzQXNBYjBa?=
 =?utf-8?B?L2ZORFRHcUhELzFEM29xdEVzVWxUK2t5Y3NicktscEhyTVVubUJQZ1JvMEs3?=
 =?utf-8?B?RDg0NWxBQzdhQUViTmY2TjM4U1dUdjJLdDFtZ0NieW5JQkt5OFhvd3RXbUhh?=
 =?utf-8?B?ZkoxSmV6YXVlNHBnU2xlSlRIWHR3a0E2YUxMSXZXYit0aHN6R3huTFhINzlz?=
 =?utf-8?B?elBGNllMMS9UY2ZrVG1vNnBWR1ozQ2VrMWMzejlCbEhmbzF5b1lSQzh0N0xm?=
 =?utf-8?Q?+vWeoGkl9swrob5MKINSNMI=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: a3b31639-86d8-46b3-eab8-08d9986c665b
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2021 10:35:59.3035
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 88UTVT/cHAP+5DlP33JDrXAqRKHgS+wvqLOlJcET5g8Tr56qTorh36pQFezNIK3nwfpIVk6zW+O/hrABXXSF8w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4604
X-OriginatorOrg: citrix.com

On Thu, Sep 30, 2021 at 10:52:19AM +0300, Oleksandr Andrushchenko wrote:
> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> 
> Take into account guest's BAR view and program its p2m accordingly:
> gfn is guest's view of the BAR and mfn is the physical BAR value as set
> up by the host bridge in the hardware domain.
> This way hardware doamin sees physical BAR values and guest sees
> emulated ones.
> 
> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> 
> ---
> Since v2:
> - improve readability for data.start_gfn and restructure ?: construct
> Since v1:
>  - s/MSI/MSI-X in comments
> ---
>  xen/drivers/vpci/header.c | 34 ++++++++++++++++++++++++++++++++--
>  1 file changed, 32 insertions(+), 2 deletions(-)
> 
> diff --git a/xen/drivers/vpci/header.c b/xen/drivers/vpci/header.c
> index 9c603d26d302..f23c956cde6c 100644
> --- a/xen/drivers/vpci/header.c
> +++ b/xen/drivers/vpci/header.c
> @@ -30,6 +30,10 @@
>  
>  struct map_data {
>      struct domain *d;
> +    /* Start address of the BAR as seen by the guest. */
> +    gfn_t start_gfn;
> +    /* Physical start address of the BAR. */
> +    mfn_t start_mfn;
>      bool map;
>  };
>  
> @@ -37,12 +41,28 @@ static int map_range(unsigned long s, unsigned long e, void *data,
>                       unsigned long *c)
>  {
>      const struct map_data *map = data;
> +    gfn_t start_gfn;
>      int rc;
>  
>      for ( ; ; )
>      {
>          unsigned long size = e - s + 1;
>  
> +        /*
> +         * Any BAR may have holes in its memory we want to map, e.g.
> +         * we don't want to map MSI-X regions which may be a part of that BAR,
> +         * e.g. when a single BAR is used for both MMIO and MSI-X.

IMO there are too many 'e.g.' here.

> +         * In this case MSI-X regions are subtracted from the mapping, but
> +         * map->start_gfn still points to the very beginning of the BAR.
> +         * So if there is a hole present then we need to adjust start_gfn
> +         * to reflect the fact of that substraction.
> +         */

I would simply the comment a bit:

/*
 * Ranges to be mapped don't always start at the BAR start address, as
 * there can be holes or partially consumed ranges. Account for the
 * offset of the current address from the BAR start.
 */

Apart from MSI-X related holes on x86 at least we support preemption
here, which means a range could be partially mapped before yielding.

> +        start_gfn = gfn_add(map->start_gfn, s - mfn_x(map->start_mfn));
> +
> +        printk(XENLOG_G_DEBUG
> +               "%smap [%lx, %lx] -> %#"PRI_gfn" for d%d\n",
> +               map->map ? "" : "un", s, e, gfn_x(start_gfn),
> +               map->d->domain_id);
>          /*
>           * ARM TODOs:
>           * - On ARM whether the memory is prefetchable or not should be passed
> @@ -52,8 +72,10 @@ static int map_range(unsigned long s, unsigned long e, void *data,
>           * - {un}map_mmio_regions doesn't support preemption.
>           */
>  
> -        rc = map->map ? map_mmio_regions(map->d, _gfn(s), size, _mfn(s))
> -                      : unmap_mmio_regions(map->d, _gfn(s), size, _mfn(s));
> +        rc = map->map ? map_mmio_regions(map->d, start_gfn,
> +                                         size, _mfn(s))
> +                      : unmap_mmio_regions(map->d, start_gfn,
> +                                           size, _mfn(s));
>          if ( rc == 0 )
>          {
>              *c += size;
> @@ -69,6 +91,7 @@ static int map_range(unsigned long s, unsigned long e, void *data,
>          ASSERT(rc < size);
>          *c += rc;
>          s += rc;
> +        gfn_add(map->start_gfn, rc);

I think increasing map->start_gfn is wrong here, as it would get out
of sync with map->start_mfn then, and the calculations done to obtain
start_gfn would then be wrong.

>          if ( general_preempt_check() )
>                  return -ERESTART;
>      }
> @@ -149,6 +172,10 @@ bool vpci_process_pending(struct vcpu *v)
>              if ( !bar->mem )
>                  continue;
>  
> +            data.start_gfn =
> +                 _gfn(PFN_DOWN(is_hardware_domain(v->vpci.pdev->domain)

You can just use v->domain here.

> +                               ? bar->addr : bar->guest_addr));

I would place the '?' in the line above, but that's just my taste.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Tue Oct 26 10:53:17 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Oct 2021 10:53:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.216368.375946 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfK4t-0006S4-Hk; Tue, 26 Oct 2021 10:53:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 216368.375946; Tue, 26 Oct 2021 10:53:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfK4t-0006Rx-El; Tue, 26 Oct 2021 10:53:11 +0000
Received: by outflank-mailman (input) for mailman id 216368;
 Tue, 26 Oct 2021 10:53:10 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=d0pl=PO=citrix.com=roger.pau@srs-us1.protection.inumbo.net>)
 id 1mfK4s-0006Rr-BW
 for xen-devel@lists.xenproject.org; Tue, 26 Oct 2021 10:53:10 +0000
Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 2f7f8b96-f31e-4621-8bbc-c564702a288f;
 Tue, 26 Oct 2021 10:53:09 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2f7f8b96-f31e-4621-8bbc-c564702a288f
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1635245589;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=9l3RCVUWLS7Lm2rfMcrSR7qtzG1CqCiYd/IjtJXoAI4=;
  b=JvrOB8r9pKqfOLm87PRgf/1akHO+QTg7ZFhairgH8yh6fLivYmyb7gtZ
   vcb1qkqqGfZ8rAOkTCsCnycsCstnCzHZGY0Oqqa7ngMFlI1RNzMw/ShfS
   OzXr2WwBVDOlm7bty3FAMpvjZl+jvE/IOxBFijuRKKajHoISOqVJQOXIx
   0=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: GOm1eWylw8y76vFLr18RfXqx11DTugJicEnPzwNUb8mBFTtlsFyOFOqE0SvVzsyipT6wVyn4LP
 DURzZ/+ltzSAyadmPVbdGQfTCGxFFJbL9TyjUhSiiSURw6WUaI4Xcce7Mw7rGez5rw2iQrOVaI
 Jo1GtAM7U1hDum09ol8KVU22f5LIbF3BHI3kEIAnQSB4zak5avJCkDakCamDhExl6jf7t1I11B
 tU4QPrXpgKJyHldrGxbX2whndU9PkvEd1UseFFZPv9sO9hLD0dbaOt9s8CU+ChgSe9mMFPPGjW
 dinNeZU48ADmvVWg1X8/1DGR
X-SBRS: 5.1
X-MesageID: 56461072
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:6Zl/UaCzoFmoIBVW/xLlw5YqxClBgxIJ4kV8jS/XYbTApDt23jwPm
 jNJXDuHOauJMzH1etl+aYu29UkAu5LVyN5hQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA
 xA2M4GYRCwMo/u1Si6FatANl1ElvU2zbue6WLGs1hxZH1c+EX5500w7wYbVv6Yz6TSHK1LV0
 T/Ni5W31G+Ng1aY5UpNtspvADs21BjDkGtwUm4WPJinj3eH/5UhN7oNJLnZEpfNatI88thW5
 Qr05OrREmvxp3/BAz4++1rxWhVirrX6ZWBihpfKMkQLb9crSiEai84G2PQghUh/sCmCg4p46
 u5xh43tTxo1G6TqkeQ0ekwNe81+FfUuFL7vJHG+tYqYzlHccmuqyPJrZK00FdRGoKAtWzgIr
 KFGbmBWBvyAr7veLLaTUO5ji95lNMD2FIgepmth3XfSCvNOrZXrHvuWu4YAg21YasZmN6/ON
 +kEWCtTYQmHbgZEeVsmS5cntbL97pX4W2IB8w/EzUYt2EDZwRZtyrHrPJzQc8aTWMROtk+Co
 yTN+GGRKhMQOcGbyDGF2mmxneKJliT+MKo7DqG188lPkVKax2ENIBAOXF79qv684ma7WtlfI
 khS/TA8oKwa/VauCNL6WnWQp3qJvQUVXdZKJOQ85BuQ0arf4wufBW8sQyZIbZots8pebSYj1
 kKN2cjoAzNvmLSPTDSW8bL8hTGvPSkYK0cSaClCShEKi/HzrYd2gh/RQ9JLFK+uksazCTz22
 yqNriU1m/MUl8Fj/6y98Uqd22r0jpfMRw8xoA7QWwqN8AR9Y4K0Yp2y3lLS5/1AMYWxQ0GIu
 T4PnM32xOcKAJKWnSqBWtIRDaqp7PaINj7bqVN3Fpxn/DOok1a4ZpxZ6jx6IEZvM+4HdCXvb
 UuVvhlejKK/J1PzM/UxOdjoTZ13k+6wTrwJS8w4cPJ1fpNtLgalxx1cdBOWwnzImW4lkYgWb
 MLzndmXMV4WDqFuzTyTTugb0KM2yi1W+V4/VawX3Dz8juLAPC/9paMtdQLUNLhgvfzsTBD9q
 o4Hb6O3JwNjvPoSi8U92bUYKkwWNjAFDJTypt0/mgWrc1c+Rj9J5xM8x9ocl21Zc0Z9yrigE
 pKVABYwJL/DaZrvcl3iV5ybQOmzNauTVFpiVcDWAX6m2mI4faGk57oFep08cNEPrbI4kKckH
 6BUKpXRU5yjrwgrHBxGNfHAQHFKLkz31WpiwQL8OFDTgKKMtySWo4S5L2MDBQEFDzattNtWn
 lFT/lizfHb3fCw7VJy+QKv2lzuZ5CFB8MovDxqgCoQCIy3Erdk1QxEde9dqeqng3z2YnWDEv
 +tXaD9FzdTwT3gdqomV2fnf9Nf3SIOT3CNyRgHm0Fp/DgGDlkKLyo5cSueYOzfbUWL/4qK5Y
 utJifr7NZU6cJxi6tAU/29Dwf1s6t3xiaVdywg4TnzHY07yUuFrI2Wc3NkJvapIn+cLtQyzU
 0OJ299bJbTWZ5+1TA9PfFIoPraZyPUZujjO9vBpck/00zB6oeicWkJIMhjS1CEEdOlpMJkoy
 PsKsdIN71DtkQIjN9uL13gG92mFInEafb8gs5UWXN3ihgYxkwkQap3AEC7mppqIbowUYEUtJ
 zaVgovEhqhdmRWeIyZiSyCV0LME15oUuR1MwFsTHHizm4LI1q0twRlc0TUrVQAJnB9J5P1+Z
 zpwPEpvKKTQozox3JpfX3qhEh1qDQGC/hCj0EMAkWDUQhX6VmHJK2Fha++B8FpArjBZdzlfu
 rqZ1HzkQXDhe8Sohnk+XktsqvrCS91t91KdxJD7TprdR5RqMyD4hqKOZHYTr0q1CMw8s0TLu
 O128bsicqb8LyMR//U2BoTyOW78k/xYyLiumc1cwZ4=
IronPort-HdrOrdr: A9a23:NscAM6Gf5Gtb18EepLqFDJHXdLJyesId70hD6qkvc3Nom52j+/
 xGws536faVslcssHFJo6HmBEClewKnyXcV2/hrAV7GZmfbUQSTXeNfBOfZsljd8mjFh5NgPM
 RbAtZD4b/LfCFHZK/BiWHSebZQo6j3zEnrv5an854Ed3AUV0gK1XYeNu/0KDwTeOEQbqBJaK
 Z0q/A37AaISDAyVICWF3MFV+/Mq5nik4/nWwcPA1oC5BOVhT2lxbbmG1zAty1uHg9n8PMHyy
 zoggb57qKsv7WSzQLd7Xba69BzlMH6wtVOKcSQgow+KynqiCyveIN9Mofy9gwdkaWK0hIHgd
 PMqxAvM4Ba7G7QRHi8pV/X1wzpwF8Vmgnf4G7dpUGmjd3yRTo8BcYEr5leaAHl500pu8w5+L
 5X3kqC3qAnQy/orWDY3ZzlRhtqnk27rT4JiugIlUFSVoMYdft4sZEfxkVIC50NdRiKp7zPKN
 MeTP002cwmMm9zNxvizytSKZ2XLzgO9y69Mwk/Upf/6UkSoJh7p3Fos/D30E1wsK7VcKM0lN
 gsBJ4Y4I2mfvVmHZ6VO91xM/dfKla9CC4kY1jiaWgOKsk8SgfwQtjMkfII2N0=
X-IronPort-AV: E=Sophos;i="5.87,182,1631592000"; 
   d="scan'208";a="56461072"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=TwjjJ7jCW4N/rz5FpUZE3MPzOaYqhc33Up0QHLm0Ypq67CTJED0X6FxAJO5vKUWEz1Oo7/9xcrnH0kiulNtYtCA4HubZYaHD1SglkY1sR2ubYgyrQHZiEiB/Vf5b/0lMmUyenMrA7vi0KWtg3qdYK/+Kpdkp7I20mQKKciJDbhjzDr7ZVJySGMrVl5A/OplUKcal0X/ZG46N+GRo3vAix3O+R4ocJlMJZpOc+zuUjI5/aDFpL6v9oAIzl719GPy+iMSfgMDgo5Fs5DqSSFHRMofFxxCsrvF2W0I6YlsKMZcDEeiFr0ntJ9E6mg5ryKDE8JjAQRC937QvzuuiKnRJYA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=e0DJg+hmraSsp8QGZrIvJEFGWWT2wGpKz3HFb+iX8R0=;
 b=V1rJYduwde98LvNxS2RrVs7zxhaq9NaCMbD4K25QfzXJTGGqMMz6TjK1l5WAUbj7IlrDZbVOj7wOUc9p6n4UnNoNJEPazpXYRtfcltKOcU+P48S0hYdOXF1WLN3/mj3Vw2BCHNHXUC3KWbkra3RIPx3Xq/F7xyqBM9CompLDDdavdfkIA3jm/bvRj2nJcCpXe1D4R90+/UXgRSH4mfXk1dE/owQMRBAYNKjInVPTNqkzhtzKyKgiLts7L+vBg6DucY5mdQqJ0DncBCG3SlzVZKDI2LkxdIpMIr7lRgql23lQ8A+1+hZ1GBGzoJP5i5h4q5+ZR9Zc/yHY9wqMV8lqEQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=e0DJg+hmraSsp8QGZrIvJEFGWWT2wGpKz3HFb+iX8R0=;
 b=xU9GeEmOU5ucUlD1xKhFJInUjXG/lJ/2nPuCy7OYmmeDXDfSHU+5up+6ApHmtEsfXTnQPmlgos6wAB484kqzCPSYSJtLaKBKuBU0TP8vM/2fUBpKQ3P5K2068KvCQxxVJ9PkvqHeF2rU6pYznBKsOaDdv1ZCZsa0WT5x18W0OXQ=
Date: Tue, 26 Oct 2021 12:52:55 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Oleksandr Andrushchenko <andr2000@gmail.com>
CC: <xen-devel@lists.xenproject.org>, <julien@xen.org>,
	<sstabellini@kernel.org>, <oleksandr_tyshchenko@epam.com>,
	<volodymyr_babchuk@epam.com>, <Artem_Mygaiev@epam.com>, <jbeulich@suse.com>,
	<bertrand.marquis@arm.com>, <rahul.singh@arm.com>, Oleksandr Andrushchenko
	<oleksandr_andrushchenko@epam.com>, Michal Orzel <michal.orzel@arm.com>
Subject: Re: [PATCH v3 08/11] vpci/header: Emulate PCI_COMMAND register for
 guests
Message-ID: <YXfeB1LWy6Hm81LA@MacBook-Air-de-Roger.local>
References: <20210930075223.860329-1-andr2000@gmail.com>
 <20210930075223.860329-9-andr2000@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20210930075223.860329-9-andr2000@gmail.com>
X-ClientProxiedBy: MR2P264CA0158.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:501:1::21) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 596e85d9-4f78-4652-81ed-08d9986ec6c2
X-MS-TrafficTypeDiagnostic: DM5PR03MB3068:
X-Microsoft-Antispam-PRVS: <DM5PR03MB306880D839AAE0C8741C438C8F849@DM5PR03MB3068.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8273;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 8X7QLjOHJlfPzSPFMttah1DV8ry6lIM83ChWtJmr2zuqJ6cN76Pexk1SS7t81c7VGm5YKfr0V5hoghjMQizDFI5Snsr7VSV3dpjgvZx8hGmbnPNeNvAqRCVZvkJzJ1IpUK8zxnKtzCgs+AqGUSoN9WgWrN7WDd61bf1OU4oQ8NfRpo8Fl7Tg//mL7QxKPbUoP5SWLez15dMLW6s4XQjGbpq2l540YDgFuu4T86xSXL/OAV/ls/Ts/cAwNR33t4rLPpjDigdqwhwqXK7lAm+Uk226cER3MRgGVERu0p9k0KX3ES5pnZn0X2NPdh1MMV71Yy6+aWTQusiGMj2PuBlTKxWfX6rJZcXkLN67/OSOZqT74yR0tl2BRfjuUzfbIm+82DpoM5SUh+gYCZzo9LuNErmNz0o37JM7Pa/Nr4h1eEVbPH38TdmWKEiin4ajx/sRFgFsawo4xrpmsUY6/JUwLzV8G7wnnvpXibegL4aXIaPNd6r8ibnXqSvt3Z+OMg0Sk/GaOtwc18rkVMvQeI7nevEzXUObZMWfjJEsPXg9nvzLd5k8qUlR4uIXwSWum1MU1mg2Yphx+p0RS392x8rkUrELzQLW9Z3ebYTc1VIYXAHtfCcE+EwsJ8Pj0C2DtMzg/cu9EJ2AuCElSFz/WpduJg==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(508600001)(8936002)(8676002)(956004)(6666004)(316002)(4326008)(66476007)(66556008)(85182001)(26005)(186003)(66946007)(38100700002)(6916009)(82960400001)(83380400001)(6496006)(7416002)(9686003)(2906002)(5660300002)(54906003)(86362001)(6486002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NndmL1l4MnozUDg4R1BDY01EOFRjVzhNSGlDUWUvMlhObVhWQ1d4TTErTzJJ?=
 =?utf-8?B?aUh1TVU2TlhHNUt2QnZYbWFvZjlSYzdrUkxrdUFkZUQ4TC9FUkhrZERHdlpE?=
 =?utf-8?B?WDdqNXNWSXg2cTJjc0EvMkZBRkUweVdkdEtrOEk0Y21VakR4S1k4ZnpVN3Bs?=
 =?utf-8?B?N3Y4cmpsanl3SUcyT3d5ZmRiWmM2ODRLMHJvOEt0N3g2VzZWNkRHaC9mZjY1?=
 =?utf-8?B?WmhSMkZ1cmxWQU11UUpBbUJnNnJkZmdyQnZSdGtJTW5wYmppVk9ldzFRRFpT?=
 =?utf-8?B?a2N0dGxJUlJybFZTaUk1MmNuZXNtbEQ5V3pxbTRqeVNJS25lQTQ3TVlpMDMr?=
 =?utf-8?B?dnlNbFloODdyajRaNVVuSXhwSFkzWmIyRkNDMEE0OU5tZHNhWHQ4am9GRDUw?=
 =?utf-8?B?NkxXenp4eEFMSEI5UG15UlFJYnhHQWtScS9yZXlPMDNMRGRZQXFqQ0M4cnZF?=
 =?utf-8?B?VS9ZMm85c2gwTU5JcEoxNEhEQ2JCMHozVmozdlFxeXplTzN0b0VLTHNiLy9s?=
 =?utf-8?B?c25BWVg5eGFiWWdDVUMzRDVmNmMzN2Z1YzcxYnp5Nm8rZkY2TGtPb1JCSjFp?=
 =?utf-8?B?c0hjUktuQWhMb1RkRko1RG5sL2o5b1Q0dS80YUFkY3FFanp2eCtXNHRqRHNh?=
 =?utf-8?B?V0plOHdGWnpzc2hxQzVXMmd3Sk1XSFVBd0pwT21hMzhrQ1E5Tkp2Um5DMERW?=
 =?utf-8?B?YmM2MHFyRkRmUmgySm9nWWlmMTNJYzRBN0ZlS0d0a3NxTEF1NWVPeXNOZEZM?=
 =?utf-8?B?ZFh2aWhUNzJFeHJHMGRZUGdPWkFCMWJLdEhnd0ZnYndLbjJ4Q3VsMk12K3Z4?=
 =?utf-8?B?bmFTVnY2Tm56NDdmUVJidC9VcWJ6SEJFa1RRNUxVU2NoTzN0YUoraGEyMnRW?=
 =?utf-8?B?czM3WWtQTUh2bDRwbzlqME04L1JWZXRIWDFWVUQxRGJYbVpvV1dSKzRCVTRQ?=
 =?utf-8?B?aVpmOFY5WUNDdmtrY25TNkdrU2JJWndDOVk3endnL0RyQS9SdVJWZ2xrSzhx?=
 =?utf-8?B?NVN5Uy9zMG9HbG5pM01sWlZ2R2xpZ092N0ZLNEdMTFY0U2FEV2JKSFJHRTFa?=
 =?utf-8?B?VU5zYzAvSVJpZzk2Wk85bzN2ZzBVWjV1ZVBRR3BUdy9iVStoaHFXeHcrVXVP?=
 =?utf-8?B?Mm5JWUdLNFE3aHQ2aG41SklxWTR5YWRPSGhXcVAxZ3Q4clZtQTRROEhtLy9r?=
 =?utf-8?B?WitkbkVwNVVLTVBlUVpGU0hrZ3JHN0RUWDZLcXh5V0gyV1V1bVN3Z3pqNHd3?=
 =?utf-8?B?MFExR0RBcjVKSTFoelJBbGVJNkxiQk5EVUFHTExHcU1MOXBFVFp6d3Q0YW4z?=
 =?utf-8?B?ODk1SWVoUjcwT0RWNHlNekVnamRNcDlXS1BsY1I5dHFjVDA3cnpRTEVIaGJs?=
 =?utf-8?B?TWlocmlDN3VKUCtyTERPWmh1N09hR2NOdTRxQTM1c0pjaTZUdVR5YmQ5c1kx?=
 =?utf-8?B?RlBGVVN0aGwzNlFrQkU4UGNCNG5jSDJBazJRMmt6ZjZ3YWFGZXdMWE9iRmxS?=
 =?utf-8?B?bko5eWJPa2ROUCtWbkhzQ0tDZDBCaGRzVHQ5eWRGWkJocjdjemNLTXpCalFn?=
 =?utf-8?B?T1ljcVRwYm1MNndLRSs5M0dvaGdjT0duOXY1cFpFNDlheEszVW5ubk92djc0?=
 =?utf-8?B?TWlKbGR5eXpvS0NmNmFnODY3MXFDaGlsdTVUSDFSME1iK0xqT3pBY0drK3k2?=
 =?utf-8?B?TjBSZG5LMWYreWNDR0VKWUhqNEJiME5uemlEYXVhQXgvN3Y5Q0toN2lVYWRu?=
 =?utf-8?B?dnJkSkRKTkJPMGVlRTRmaC80R1FjdDZzNktGY3pWQ2tZVnRySng4Q3NCZWlW?=
 =?utf-8?B?dzFHeEo1OFptTi9IZys0K1U2dTVEQ2w1MjJXcGtjWFhvYW01SVhBZmxCbU5m?=
 =?utf-8?B?bjB2NG0vajBDT1J0dklzT01SYm1nQjFaTk1DM0E0WDlET1pPSUVIcUdPTm5o?=
 =?utf-8?B?ZVBlUTZ1R0xDM0JtcHJqaVVlSEtxZW52K3Z0RFpTbEt4VURieUFoaDFYL3Rv?=
 =?utf-8?B?MnFKTkkwei9kYUc4YXgwc3Y1YkM2M29TK1VrS2pvUXBZRjVJWWNTL1ZkUldE?=
 =?utf-8?B?V3FJTXVHcnJQZmNOTjRtMi9RUjNqc3RCTjFzdDhFN3puR3UvVTRpOW5QVUJL?=
 =?utf-8?B?akY5ZTlXTFlSRjBkWFBWSk9LVEJtSlgwU1p1N0doR3ZvVmwrTWFtek56a0Nv?=
 =?utf-8?Q?JoLmbegodyxTRU5CZPpw/qc=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 596e85d9-4f78-4652-81ed-08d9986ec6c2
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2021 10:52:59.9948
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: pq6A5RFKAotlfnsZO0rVsrQLs+pIV8Ybqs5saQPWFYBHXQinw6GFo2kvDlGw44lSd9M+TkROxE1Wc7HNIILtGQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB3068
X-OriginatorOrg: citrix.com

On Thu, Sep 30, 2021 at 10:52:20AM +0300, Oleksandr Andrushchenko wrote:
> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> 
> Add basic emulation support for guests. At the moment only emulate
> PCI_COMMAND_INTX_DISABLE bit, the rest is not emulated yet and left
> as TODO.
> 
> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> Reviewed-by: Michal Orzel <michal.orzel@arm.com>
> ---
> New in v2
> ---
>  xen/drivers/vpci/header.c | 35 ++++++++++++++++++++++++++++++++---
>  1 file changed, 32 insertions(+), 3 deletions(-)
> 
> diff --git a/xen/drivers/vpci/header.c b/xen/drivers/vpci/header.c
> index f23c956cde6c..754aeb5a584f 100644
> --- a/xen/drivers/vpci/header.c
> +++ b/xen/drivers/vpci/header.c
> @@ -451,6 +451,32 @@ static void cmd_write(const struct pci_dev *pdev, unsigned int reg,
>          pci_conf_write16(pdev->sbdf, reg, cmd);
>  }
>  
> +static void guest_cmd_write(const struct pci_dev *pdev, unsigned int reg,
> +                            uint32_t cmd, void *data)
> +{
> +    /* TODO: Add proper emulation for all bits of the command register. */
> +
> +    if ( (cmd & PCI_COMMAND_INTX_DISABLE) == 0 )
> +    {
> +        /*
> +         * Guest wants to enable INTx. It can't be enabled if:
> +         *  - host has INTx disabled
> +         *  - MSI/MSI-X enabled
> +         */
> +        if ( pdev->vpci->msi->enabled )
> +            cmd |= PCI_COMMAND_INTX_DISABLE;
> +        else
> +        {
> +            uint16_t current_cmd = pci_conf_read16(pdev->sbdf, reg);
> +
> +            if ( current_cmd & PCI_COMMAND_INTX_DISABLE )
> +                cmd |= PCI_COMMAND_INTX_DISABLE;
> +        }

This last part should be Arm specific. On other architectures we
likely want the guest to modify INTx disable in order to select the
interrupt delivery mode for the device.

I really wonder if we should allow the guest to play with any other
bit apart from INTx disable and memory and IO decoding on the command
register.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Tue Oct 26 11:01:06 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Oct 2021 11:01:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.216377.375958 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfKCO-0007zW-E9; Tue, 26 Oct 2021 11:00:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 216377.375958; Tue, 26 Oct 2021 11:00:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfKCO-0007zP-BC; Tue, 26 Oct 2021 11:00:56 +0000
Received: by outflank-mailman (input) for mailman id 216377;
 Tue, 26 Oct 2021 11:00:54 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=d0pl=PO=citrix.com=roger.pau@srs-us1.protection.inumbo.net>)
 id 1mfKCM-0007zJ-DH
 for xen-devel@lists.xenproject.org; Tue, 26 Oct 2021 11:00:54 +0000
Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id fbbb948c-364b-11ec-842c-12813bfff9fa;
 Tue, 26 Oct 2021 11:00:52 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fbbb948c-364b-11ec-842c-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1635246052;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=r0R0FOF+jwvH0mml2ZlwQr1EkJmUnyjPKk6jHtzeQgk=;
  b=KabP234CcODJtyRKxsUcAP1g6Q/nUbOmedn29ihy9s6qWDqKMZL92EYu
   T/5EPPHOkEbrsmkvQaI3B4kz3+GMAM6F0TimkJFtIpE9hZ/Uo3qtlYWPt
   7p03JffSrKK2h3pRRJ6GQLMwMcvArntBRdLrvo+n3dP8op/t/tLOlvoXV
   8=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: OfF6JIVv5o287GeB8weKut8Wuqj3WiwXQiWL6xe67Cig4QkxIW34x5Io4cGzsrmtUIaGHDO7pV
 Ymu0LBrMgEkfGU66MAMaIzW5t8kh+HTvcE/TC/jPsPooWUUzSMvgRiQ5o1Xmg7DUXZYu0ebCOt
 T2KHJ10VdM3eZQFJFgjE3RM7yDLjQ/WHG0TcYtvATVP5dQvjIuZMDdrhywNFiVFmZzZN8v4R2N
 deGysvMJtELUDgrGsuvaZU+Ja/YS75/Leb3cGBDC0VcAfi2e7Ansinbize7CPNv/jtjdAgEOR0
 tq5aYFeF1+ZLOE+912qGQpGg
X-SBRS: 5.1
X-MesageID: 55622557
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:cNFtjqoqZKsAtRXzvOF08RBlhsxeBmIgYxIvgKrLsJaIsI4StFCzt
 garIBmOPfeINGT8Kdh1Pd/k8ktQ657WndNjGwRu/npmESMapJuZCYyVIHmrMnLJJKUvbq7GA
 +byyDXkBJppJpMJjk71atANlZT4vE2xbuKU5NTsY0idfic5Dnd+4f5fs7Rh2Ncx2YLnW1nlV
 e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL
 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9
 DlCnaXrYwIOO/fHo8JDXiFSDCEiJ5dW+6CSdBBTseTLp6HHW37lwvEoB0AqJ4wIvO1wBAmi9
 9RBdmpLNErawbvrnvTrEYGAhex6RCXvFJkYtXx6iynQEN4tQIzZQrWM7thdtNs1rp0TQ6yEO
 pdGAdZpRE36biwSHF4YMsIRlc2hr2j7Kj5ok03A8MLb5ECMlVcsgdABKuH9cNGQWd9cmEreo
 2vc5nn4GTkTLtnZwj2AmlqujOLSmSLwWKoJCaa1sPVthTW773YPBRghcEq0qPi0lGazQ9tab
 UcT/0IGqKk59EWvCN7nTRC8iHeeu1gXXN84O+o+5QKWw6zY+TGQAGQeUyVBY9wrsswxbTEy3
 1rPlNTsbRR1ub2ITTSG97GbrRu7Iy1TJmgHDQcGUA8E7t/LsIw1yBXVQb5LAKOzy9H4Bzz06
 zSLtzQlwaUei9YR0Ke29kyBhCijzrDASAIvvF2PBkqq6wp4YMiuYInAwUbc6fFMPYOIVG6Lt
 XIPm9WdxO0WBJTLnyuIKM0KGLyq/P+DPCfrnU90H5Ih+jKu/FauZYlVpjp5IS9BKd0YcDXkZ
 EvSvwJ555JJOnauK6htbOqM598ClPa6U46/D7aNM4QIMsMZmBK7ED9GXBW62kfoykMXt/8yA
 Z2EcZq2N2YZFvEypNapfNs13bguzyE44GrcQ5Hn0hiquYajiG6ppaQtawTWMLhohE+QiECMq
 YwHbprVo/lKeLSmOnG/zGIFEbwdwZHX77jNoMtLavXLHANiHGwwYxM66eJ8I9I790i5e+Ghw
 51cZqO64Aag7ZEkAV/TApyGVF8Idc0nxU/XxQR2YT6VN4ELOO5DFps3eZotZqUA/+d+1/NyR
 PRtU5zeWakWGmSeqmVNPMiVQGlemPOD3lrmAsZYSGJnI84Iq/Lho4eMkvTTGNkmUXPs6JpWT
 0yI3QLHW5sTLzmO/+6NAM9DO2iZ5CBH8MorBhOgCoAKJC3Erdg7QwSs36RfC5xddn3+Ks6yi
 l/+7eEw/rKW/efYMbDh2Mi5kmteO7EuQhYDRDKLs+3e2Ouz1jPL/LKsmd2gJFj1fGj15L+jd
 aNSyfT9O+cAh1FEr8x3FLMD8E70z4CHS2Zywls2EXPVQU6sD788cHCK0dMW7v9Gx6NDuBvwU
 UWKo4EINbKMMcLjMVgQOAt6MbjTiaBKwmHfvaYvPUH3xC5r577bA09cCAaB1X5GJ7xvPYJ7n
 ep44JwK6xaygwYBO8qdinwG7HyFK3ENCv11tpwTDILxpBAsz1VOPc7VBiPsucndYNRQKEg6Z
 DSTgfOa1bhbw0PDdVs1FGTMgrUB1chf5kgSwQZbdVqTm9fDivsm5zFr8Gw6HlZP0xFK8+NvI
 Ww3ZUd7ErqDomVzj89ZUmHyRwwYXE+F+lb8wkcinXHCSxX6TXTEKWAwNLrf/E0d9G4ALDFX8
 KvBlTTgWDfuOsrwwjEzSQhurPm6FY598QjLmcaGGcWZHsZlPWq50/H2PWdY+QH6Bc4RhVHco
 bg49el9XqT3KCoMrvBpEIKdz7kRFEiJKWEqrSuNJ0/V8bUwoA2P5AU=
IronPort-HdrOrdr: A9a23:HTiA66ERtHrLsosEpLqFDJHXdLJyesId70hD6qkvc3Nom52j+/
 xGws536faVslcssHFJo6HmBEClewKnyXcV2/hrAV7GZmfbUQSTXeNfBOfZsljd8mjFh5NgPM
 RbAtZD4b/LfCFHZK/BiWHSebZQo6j3zEnrv5an854Ed3AUV0gK1XYeNu/0KDwTeOEQbqBJaK
 Z0q/A37AaISDAyVICWF3MFV+/Mq5nik4/nWwcPA1oC5BOVhT2lxbbmG1zAty1uHg9n8PMHyy
 zoggb57qKsv7WSzQLd7Xba69BzlMH6wtVOKcSQgow+KynqiCyveIN9Mofy9gwdkaWK0hIHgd
 PMqxAvM4Ba7G7QRHi8pV/X1wzpwF8Vmgnf4G7dpUGmjd3yRTo8BcYEr5leaAHl500pu8w5+L
 5X3kqC3qAnQy/orWDY3ZzlRhtqnk27rT4JiugIlUFSVoMYdft4sZEfxkVIC50NdRiKp7zPKN
 MeTP002cwmMm9zNxvizytSKZ2XLzgO9y69Mwk/Upf/6UkSoJh7p3Fos/D30E1wsK7VcKM0lN
 gsBJ4Y4I2mfvVmHZ6VO91xM/dfKla9CC4kY1jiaWgOKsk8SgfwQtjMkfII2N0=
X-IronPort-AV: E=Sophos;i="5.87,182,1631592000"; 
   d="scan'208";a="55622557"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=gplc+HtCLxshM0mHI1x6e6ntc7UCljEqiwMfRYgZ1hWVf/ZmO9tXjMPcpTuvCo2lLP8kHorqmdcJ0xRWO6VstnCPEAM//LjOEL2R10XAToxfO+Pma/Er+/64sFwVNHVylELHEiEdeMnVhzvZTtmXVvoyid9YWOxErx+20gnkfwpwqJoRFzEZ+lJIr8itzeTNNCBVZIp1wYmTKULFQffwe9se7JIVFu2omuo1DQZ068Btd8FUib6D+DOrhimsUYeTLJZQxc2/XA1DAi1y6K8D+khy6P6as77NliRTNUhIvJJ1EpTfIbn0APIDzr5DyMUrvl70YxFVjutpzbGv3wXoFg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=GkOaU8UtNF7BOo0Q2wWPC+OdJm4CHso6jPBfDUjbrsk=;
 b=ZvNH3Ml4ZcrNNaU+8lFWt+TspGfkqnKCjpzHzfNFOk9fGxwlNRIuKaBMZJagbSuewmm8+a3xOOAV6/WtRbS+TXRxNlq5xiDk9hUJP19o2MBDG93r1zpNrf1i7m8il1XpcxOuz86RDYwBeiMRAvulqgqm6nXD0C6SUFpF9G4GDa8LGP9hSK/enkcQCTTc7DSLE87rrnlj89LrGurJbJMdAuy9yb024vrkxGu3eNo9y2plif8Yg6UVxPYUqahbS1TjiQ2yRIUfjTzn0JDM90z1rf/eOoO2lpPXcqelY7kZ3ciQJVSEr1KhJ66tnmeqA6B8fYB2BaIPwMBfCl9pmowiZg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=GkOaU8UtNF7BOo0Q2wWPC+OdJm4CHso6jPBfDUjbrsk=;
 b=EhdHmeSJDrBkzwP5FNEDy6gTFDhBNKN071pCzRViP6Ahc2HBd9QMqSUv3UsKRG3BogjEuegr+tx9Ime5vHG/bTo/RM5vvOdfxUr/Rridxtx8q4eHXmp21dtyTqYlJ7lj7fatqQ4R5UM1ZQ2zBn+/T1Te7wmAogvZbz3uZGTt1/c=
Date: Tue, 26 Oct 2021 13:00:43 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Oleksandr Andrushchenko <andr2000@gmail.com>
CC: <xen-devel@lists.xenproject.org>, <julien@xen.org>,
	<sstabellini@kernel.org>, <oleksandr_tyshchenko@epam.com>,
	<volodymyr_babchuk@epam.com>, <Artem_Mygaiev@epam.com>, <jbeulich@suse.com>,
	<bertrand.marquis@arm.com>, <rahul.singh@arm.com>, Oleksandr Andrushchenko
	<oleksandr_andrushchenko@epam.com>, Michal Orzel <michal.orzel@arm.com>
Subject: Re: [PATCH v3 09/11] vpci/header: Reset the command register when
 adding devices
Message-ID: <YXff21oTvTm7EomE@MacBook-Air-de-Roger.local>
References: <20210930075223.860329-1-andr2000@gmail.com>
 <20210930075223.860329-10-andr2000@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20210930075223.860329-10-andr2000@gmail.com>
X-ClientProxiedBy: MR1P264CA0030.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:501:2f::17) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: c4158ff7-c888-4755-be1e-08d9986fdd6d
X-MS-TrafficTypeDiagnostic: DM4PR03MB6047:
X-Microsoft-Antispam-PRVS: <DM4PR03MB6047C2BCD6AC48F99320140E8F849@DM4PR03MB6047.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8273;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: t9rYzEFaPiypkxxzbzTU3AUS5XvdwFI9T/XzPEArlKXk57zrZfs7FVzNdpLJfJSYQ4aYVulh1p6m8/cbzhzpMWGLa5QZ1Z00L37Zn21KB/atjB07yQcPYFb2E4HXNn2yRg4TyNNSNaUNnlgAgTB5lSULrsuWeVmKJG3MbeheMnLEnt1981HYRZjU3XgJOFqLSfV3NIuQ4j5Yg8/XMVcQO3OLN/clqXV9KUGFh+GHnDkhGudKoUJ6CqKilKEqhzWJ+6/kkt5X7Nfwy6Ii+lfOH1xJ8vybAz2Qo5IJBTSzF0/VyG87rADAdgjQXDOac7NGL2gyh7OPfeFrS5ay/xZt0IOSrJV7nPYDnCthdhTq86SoWZzpuv6+27HmRsq8OBdd2hiE1OoopSxBJO9u8G7ATOTlA3OM23F/xODQs9i7KCDIjo0gg7u9aaN0QreOxoXt6EIilDJY78xlFDBX9L7/amnDyzICJNUympPh3L2HFqEx9ug3RLBONucvz1PmDEgYGC3Dn0WvLiBbPej++hsNqQAOx5cbCLfQHSAjFRaJ2een0gW7JqwSpXh3Pii9Zq0PDpV982mj55ehRSa7i7MjIK+0H91U5rHfRfB6346WbnQ3LCB/ggpf767f31FQ1cUuK3Z0zv9a34AN+hqE69T/vw==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(186003)(4326008)(6916009)(26005)(66946007)(66556008)(82960400001)(508600001)(6666004)(5660300002)(2906002)(7416002)(8936002)(8676002)(956004)(6486002)(6496006)(9686003)(38100700002)(86362001)(316002)(85182001)(83380400001)(66476007)(54906003);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bFdEUzlzbUhjdE1YdGlIcnNIcEI1ZzdmeHBMTzdTVEhHM053VDFheVNYOC9u?=
 =?utf-8?B?QWZHcUNCRWlMUElXdlBrNjIyNmZ6RlJNaEJFOGhVMG50YkJ2TUx1b1ZuZnNt?=
 =?utf-8?B?ZHE3VTlpVnpMZU14TnN1L0V1TmdaUzZuLzhlQmsvRFFCb3lKT2pyVCtZcHN4?=
 =?utf-8?B?SjArWEcrUVlpLzZjQnZSR1FudEFNbWxJbm92SkN0bmkzYko2NEtNZzFYS1p3?=
 =?utf-8?B?MjhwSEE4eTQ1eU5DbXJ2ZDVYUmdIdlRPaDM0ZWdJeUlWQnB4MXBUbkxyMHRu?=
 =?utf-8?B?UUNzTTFodVh0WHpWQzFvYXpzWTdRVEhQMGVicHVjNWRVQ1l0ZHpReGJXa2Fj?=
 =?utf-8?B?MnAwRUxvY2RUWW1aUGV5UlMzMnM1VHVxVTZuN0RiY2Ztd1lFMUR1Y09Yc2M0?=
 =?utf-8?B?emc3UlNjcEp2VmlZRVgwcTBqOCtRcXQ0TFJBVUdMVCtpVTRvNWk5K1FReGhZ?=
 =?utf-8?B?enFFS1kwalpUL3pVclNtM1hnRTJCc1dEcklSSms1NnJnRGFOYkZHZEVpajlD?=
 =?utf-8?B?RytUTUhhSlQ3cS9sT1NadE0ybG1YMElLMGMvMFZuZ3BscjZXdktNM0x4L3Mv?=
 =?utf-8?B?Rmh3TmVDVTdlOTlLa3lKQ0p1WmgvQkFmM2RCS3M0NENQZXRVTTgwck9TNmVJ?=
 =?utf-8?B?U1YxTFlMVUVXeWdJOUJnMXlzVjlxM3BUWGZnMVJobDJRNDQ1WDczekZJeDVQ?=
 =?utf-8?B?N2laWjA4djV1bTI2U1Q4SStrbWJIVXlESFB6QUoxUEVOR3c1UmZUeDFOUDhO?=
 =?utf-8?B?SWk3TXR5cmhkRGEzbzY5U0xrRm1pNXFBSXlwbHYzSVY1c2p5SktPYW5KODR1?=
 =?utf-8?B?S2M4MjhpSHFERmRxbWVqaE4zTGdhaXErUVNwUUZKbjhBdjFJM2xSYUMvSFFK?=
 =?utf-8?B?cnVEbjhMNVhuaUhuR3lhSXpTSU05RnBnT21kcWNjTDhHZEp1WURQU0hRVEpU?=
 =?utf-8?B?N3UwOHl1Q1g3cWt3UDkvZHFQajFpcUFFSmhocWNITVplTFdWRWRLUnVFQUor?=
 =?utf-8?B?bnZGRjFMdGJPZ3VYdEtoNkZFdmV5bUZ2ZVJiVG9RM1pGOXF0NHF5NWo5ZVZV?=
 =?utf-8?B?VGxEaGFRYUFGUERqejYvYUVqK25hbWp2SWpRN0lQVHdseWlOdjdsN3NVZE45?=
 =?utf-8?B?MndUVUlzT2J3R2pXRFE1SW92Y0wvN3I0WTdVOG5YQk5zS0d5YU8xeTdhQm9W?=
 =?utf-8?B?YzEwK01LU0JwWnJ3YlBLQWE5RDdSdXJpaWdOVGZLNU44OWoraHRhRE92N1Vy?=
 =?utf-8?B?TFB5YTNkZG5OMnRNY2gzVW1lZ1EwMWc1LzBjSHdOS0NlVU5HRko2cjhVYUd2?=
 =?utf-8?B?NS9HSnB2UjU3aG5rK2FpRlluWmtsMDd1SDBJT2Z5VFJrQ0RhMUdIWHE0ZVpy?=
 =?utf-8?B?R2RjMm91OTF2dWhxTVk0ZHkwMWgvS3FndXYxTmNIa3F6R0hjSjRLZjdIMlVD?=
 =?utf-8?B?VVBQdTF0Z21GWFRuT3FMT1JweWprUk1FMGcyNDF6WGV0MXh2QUhuZHhYc1g4?=
 =?utf-8?B?U0tNWHVGRTNyamFYNlN5aFlYL2Fja1h4U3ZWbm51WEtkaUlaTE0yeVVGK2dE?=
 =?utf-8?B?VXdid2VZRnMycHp5bTdxb2QwL29yU2FMa2dGT0VES1pmenVDV3ZOY3k0WVZV?=
 =?utf-8?B?OVF4VmtHUVRZeThZN0VwSmdESks0VTN4VHltM1pHdGIzT21nVkdMZnAxNDdO?=
 =?utf-8?B?eS9mb0o5ZUcrQTJUTFowcEQzUDlCVmpXWDBLWXk4d2FlTmppVlgvWVlIV3lk?=
 =?utf-8?B?elBrcjVNYTdmSDNzWG5SNU9xUTcvRkN0Z0FOZUVycCt3dmsvM0xOQ0ZkNllp?=
 =?utf-8?B?SXpacWZSMkhZNlJqeEo2d1laRmQ5YlBtZEhXTzhvV3ppN0lOOWZPdlVRWVBR?=
 =?utf-8?B?WHF0eVZUMkpnM0VObWkxcS9xa3dSSTgxaUFzaUFBZ2JrbXZWcHQxam1xZ1hj?=
 =?utf-8?B?cjVCRTRRbjlLclhyQ0x2OGJINTZ2bzdKVm4vRFN4azdCQzgyb1BkTFJSdzNo?=
 =?utf-8?B?bXR5bXVlVnRmZmxkdEJZcGR2SkpOWC9UTnZiemlheG5wS2NZdlMrNjhWMUFi?=
 =?utf-8?B?a1Z5dmM5cWRUelBUNkJEWG9EcjU3NGtobmlObGg1WjNXWlk3UmJScmREK1hC?=
 =?utf-8?B?ZS9MTkxpdzJybzZaN0JuU3R6U2lqd2ZZa1QvWFVvbGVNc3NZSnQ3dEljRjVr?=
 =?utf-8?Q?WVlDT/i5HX6QIt4uMgPYKpY=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: c4158ff7-c888-4755-be1e-08d9986fdd6d
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2021 11:00:47.4300
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: xzQqWyNafj8nsDKgGnZNxnHX4ngzob3bw80rrrUBU9uoJveke0IN0pnAvqW8XNIQyyqIW13Vzsuk0j2AaeP3Kg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR03MB6047
X-OriginatorOrg: citrix.com

On Thu, Sep 30, 2021 at 10:52:21AM +0300, Oleksandr Andrushchenko wrote:
> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> 
> Reset the command register when passing through a PCI device:
> it is possible that when passing through a PCI device its memory
> decoding bits in the command register are already set. Thus, a
> guest OS may not write to the command register to update memory
> decoding, so guest mappings (guest's view of the BARs) are
> left not updated.
> 
> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> Reviewed-by: Michal Orzel <michal.orzel@arm.com>
> ---
> Since v1:
>  - do not write 0 to the command register, but respect host settings.
> ---
>  xen/drivers/vpci/header.c | 17 +++++++++++++----
>  1 file changed, 13 insertions(+), 4 deletions(-)
> 
> diff --git a/xen/drivers/vpci/header.c b/xen/drivers/vpci/header.c
> index 754aeb5a584f..70d911b147e1 100644
> --- a/xen/drivers/vpci/header.c
> +++ b/xen/drivers/vpci/header.c
> @@ -451,8 +451,7 @@ static void cmd_write(const struct pci_dev *pdev, unsigned int reg,
>          pci_conf_write16(pdev->sbdf, reg, cmd);
>  }
>  
> -static void guest_cmd_write(const struct pci_dev *pdev, unsigned int reg,
> -                            uint32_t cmd, void *data)
> +static uint32_t emulate_cmd_reg(const struct pci_dev *pdev, uint32_t cmd)
>  {
>      /* TODO: Add proper emulation for all bits of the command register. */
>  
> @@ -467,14 +466,20 @@ static void guest_cmd_write(const struct pci_dev *pdev, unsigned int reg,
>              cmd |= PCI_COMMAND_INTX_DISABLE;
>          else
>          {
> -            uint16_t current_cmd = pci_conf_read16(pdev->sbdf, reg);
> +            uint16_t current_cmd = pci_conf_read16(pdev->sbdf, PCI_COMMAND);

Either we keep reg here or we drop the parameter altogether from the
function prototype. Having one caller pass 0 while the other passing
PCI_COMMAND is confusing. The more that the parameter is now
effectively unused.

>  
>              if ( current_cmd & PCI_COMMAND_INTX_DISABLE )
>                  cmd |= PCI_COMMAND_INTX_DISABLE;
>          }
>      }
>  
> -    cmd_write(pdev, reg, cmd, data);
> +    return cmd;
> +}
> +
> +static void guest_cmd_write(const struct pci_dev *pdev, unsigned int reg,
> +                            uint32_t cmd, void *data)
> +{
> +    cmd_write(pdev, reg, emulate_cmd_reg(pdev, cmd), data);
>  }
>  
>  static void bar_write(const struct pci_dev *pdev, unsigned int reg,
> @@ -793,6 +798,10 @@ int vpci_bar_add_handlers(const struct domain *d, const struct pci_dev *pdev)
>          gdprintk(XENLOG_ERR,
>                   "%pp: failed to add BAR handlers for dom%pd: %d\n",
>                   &pdev->sbdf, d, rc);
> +
> +    /* Reset the command register with respect to host settings. */
> +    pci_conf_write16(pdev->sbdf, PCI_COMMAND, emulate_cmd_reg(pdev, 0));

I think we likely want to unset the memory and IO decoding bits from
the command register, as the guest view of the BAR address is
currently forced to 0, and not mapped into the guest p2m.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Tue Oct 26 11:33:43 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Oct 2021 11:33:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.216384.375969 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfKi1-0002lm-2F; Tue, 26 Oct 2021 11:33:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 216384.375969; Tue, 26 Oct 2021 11:33:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfKi0-0002lf-UF; Tue, 26 Oct 2021 11:33:36 +0000
Received: by outflank-mailman (input) for mailman id 216384;
 Tue, 26 Oct 2021 11:33:36 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=d0pl=PO=citrix.com=roger.pau@srs-us1.protection.inumbo.net>)
 id 1mfKi0-0002lZ-Bn
 for xen-devel@lists.xenproject.org; Tue, 26 Oct 2021 11:33:36 +0000
Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 8da313c4-3650-11ec-842c-12813bfff9fa;
 Tue, 26 Oct 2021 11:33:34 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8da313c4-3650-11ec-842c-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1635248014;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=hR8sbW2/ZnVJgEmpjl52uh49HNu615SzMqIY1hC2L10=;
  b=Sk5q4TAGRUklVvTLLpF86BPNiiD8ihzbIkHuDK/uUtK0Ofz56wVhExes
   uV1V0V4mQyJ2NfvQdBapP3LDRlq6lKhqEQlmcH322JrBbwhXsmL2TCg6L
   6UccdF25Df9o+N9Et9iBq6bPAOAzxRpPwoh7JA/t7ejJSQErXz+VmxqWM
   I=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: JoX8LU+UjWSsBCM3wpK0vk9PcgZ51da0lQ/QxonFPe2WBz6yO9FcQIlxm9pTMA0nYlo8KYfLJx
 uEgkQnXiP0dtxD7i5pdUlrZ5gWvBAfLoj7BvQ5Tb+CTV+H8seoBDnZHoKq05lhYra3XztT4mNc
 zOm9W2csJCLDojdn3gYDFtOnGobriKQkBeqxB4amiHSROzkJa9Kv3vApsNGhmR0Ye2iz0WsB3m
 wGe9kSSVYsDiynjNBFSNeSbGzFUntX5lrsYl1cshBPRiQ3r7hppVc8+7BwphxLZ5NZ8Umek8Vd
 HGUFhWZNDZJ01JmfHGLVZL57
X-SBRS: 5.1
X-MesageID: 56067662
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:cjvkDqJfgQUzlqMEFE+R85MlxSXFcZb7ZxGr2PjKsXjdYENS1zdWn
 zEXWD2BPKmIZTb0KN10bd+wp0kEvJOHy9JlTVdlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s
 q3yv/GZdJhcokcxIn5BC5C5xZVG/fjgqoHUVaiUZUideSc+EH140Eo5xbZj6mJVqYPR7z2l6
 IuaT/L3YDdJ6xYsWo7Dw/vewP/HlK2aVAIw5jTSV9gS1LPtvyB94KYkDbOwNxPFrrx8RYZWc
 QphIIaRpQs19z91Yj+sfy2SnkciGtY+NiDW4pZatjTLbrGvaUXe345iXMfwZ3u7hB2wwskoz
 NVDqaevQAJ3O6T0lcUvSDhhRnQW0a1uoNcrIFC6uM2XiUbHb2Ht07NlC0Re0Y8wo7gtRzsUr
 LpBdW5LPkvra+GemdpXTsF2gcsuNo/zNZ43sXB81zDJS/0hRPgvRo2Xu4cGg2lu3KiiG97yP
 utGcjxUKy/kbgIRMQkvIYAEh8u30yyXnzpw9wvO+PtfD3Lo5A573aXpMdHVUseXXsgTlUGdz
 krv5Xj0ByY/JdOWyDeb2n+0j+qJliT+MKoYGaek7PdsjBuWz3YKFRwNfVKhpL+yjUvWc9VbJ
 k8P8ywit5878kCxU8L9VB21pn2DlhMEUt8WGOo/gCmXw6rJ50CCB24LThZIctlgv8gzLRQ00
 VuOk8LsFCZYurSfQnKA9Z+ZtTq3fyMSKAcqdSICCAcI/dTniIUylQ7UCMZuFravid/4Ei22x
 CqFxAA3gbkJ15ZTj420+FnGh3SnoZ2hZgwo4gTaWEq14wU/Y5SqD6Sv7VXY9v9GIJyuUkiav
 HMEls6d68gDFZiI0ieKRY0lB6q17vyINDndh19HHJQ78TmpvXm5cuhtDCpWfRkzdJxeIHmwP
 RGV6Vg5CIJv0GWCVPJuOoaxBdgR0qHlS9Hsbv31XMFvW80kHOOYxx1GaUmV1mHrtUEjl6AjJ
 JuWGfqR4WYm5bdPl2XuGb9MuVM/7mVnnzmLHMGkp/iy+ePGPCb9dFsTDLeZggnVBou/qwLJ7
 80XCcKOzxhOOAEVSniKqdBNRbzmwH5SOHwXlyC1XrLcSuaFMDt4YxM0/V/GU9c995m5bs+So
 hmAtrZwkTITf0HvJwSQcWxEY7jyR5t5pn9TFXVyZgvxiyh6MNf/vfZ3m34LkV4Pr7QL8BKJZ
 6NdJ5Xo7gpnE2yvF8shgWnV89U5KUXDafOmNCu5ejkvF6OMtCSSkuIIijDHrXFUZgLu7JNWi
 +T5imvzHMpSLyw/XZ2+QK/+kDuMUY01xbsas73geYIIJi0BMeFCdkTMsxPAC5tcdUmanWDKi
 V3+7NVxjbClnrLZOeLh3Mish4yoD/F/DgxdGWza5qyxLi7U4iyoxooobQpCVWu1uLrc9Prwa
 ONL4ev7NfFbzl9Gv5AlS+RgzL4k5suprLhfl1w2EHLOZlWtK7VhPnjZgpUf6vwTnudU6VmsR
 0aC2thGIrHVasnrJ0EceVg+ZeOZ2PBKxjSLtaYpIF/37TNc9aacVRkAJAGFjSFQdeMnMI4sz
 eo7ltQR7giz1kgjPtqc13gG/GWQNH0QFa4gs8hCUoPsjwMqzHBEYIDdVXCqsM3eNY0UPxBzc
 DGOhafEi7BN/Wb4ciI+RSrXwO5QpZUSoxQWnlUMEEuEx4jejfgt0RwPrTluFlZJzg9K2v5YM
 3RwMxEnPr2H+jpliZQRX22oHA0dVhSV9laolgkMnWzdCUKpSnbMPCs2PuPUpBIV9GdVfz56+
 rCEyTm6DWa2LZ+phiZiC1R4r/HDTMBq8lyQkc+qKM2JAp0mbGe3maSpf2cJ90PqDM5ZaJcrf
 gW2EDKcsZHGCBM=
IronPort-HdrOrdr: A9a23:W3QFzKhWOvX+FAGu0+ilYtLTjXBQXz513DAbv31ZSRFFG/FwyP
 rAoB1L73PJYWgqNU3I+ergBEGBKUmskqKdxbNhR4tKPTOWw1dASbsN0WKM+UyDJ8STzJ856U
 4kSdkCNDSSNykFsS+Z2njALz9I+rDum8rJ9ISuvkuFDzsaE52Ihz0JdTpzeXcGIjWua6BJcK
 Z1saF81kadkDksH4+GL0hAe9KGi8zAlZrgbxJDLxk76DOWhTftzLLhCRCX0joXTjsKmN4ZgC
 X4uj28wp/mn+Cwyxfa2WOWx5NKmOH5wt8GIMCXkMAaJhjllw7tToV8XL+puiwzvYiUmRwXue
 iJhy1lE9V46nvXcG3wiRzx2zP42DJr0HPmwU/wuwqUneXJABYBT+ZRj4NQdRXUr2A6ustn7a
 5N12WF87JKEBLphk3Glpb1fiAvsnDxjWspkOYVgXAae5AZcqVtoYsW+14QOIscHRj99JssHI
 BVfY7hDc5tABOnhk3izypSKITGZAVwIv7GeDlPhiWt6UkWoJgjpHFogfD2nR87heUAotd/lq
 D5259T5cJzp/ktHNZA7dc6MLuK41P2MGDx2UKpUB3a/fI8SjrwQ6Ce2sRB2AjtQu1O8KcP
X-IronPort-AV: E=Sophos;i="5.87,182,1631592000"; 
   d="scan'208";a="56067662"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ilgvZ8i2Ps0S72fda82M+OVpuABCCe7A02Kw00PHWO2fSeVq18YSffp2j3h7CDTOFXB5md46M3pISGJqInhIeEM7NvpbKZu0+skS/jeaTXAuUlcU+2rqeeVmEORwtQ1kNpCcYocJAFL808PShklvBS/UWXHUsqMXM3TOA8aDG6YQEGA7kPcbwlHgE4qVqZmsJasBx0NkBNENL9lR/c2MH59/37niFpgiITSp0+Xg3ylQAeup39qud6MddKto5LApCiQK8bTNVFkrYpGjVlCxsWrEpfDM/56fg6hqz6JTqayMqSiwEQNccaVwboBS0voqEOnBEn4zod3TYjiHKlTqaA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=xV6cE3lYNLcn733a1EmyhjCDB3A2zueslC8j7tXpRTU=;
 b=BaYojEXESwFoLR2Vra5KRjmIoEyfq8bdzgEQCCiSC0YMG75mDUUlNdEhgneuDavb/fx++LGXUD/K+07NP54AMsU9QXb7bSb22VHf1ookClRemOD8DTVeT2VWklLa05X9pGBR1nB0VwntVVzbWxx0eQpTiwAqYdAogyQm4/4APofRtrVMiBOnt8FZokNBq1JcAzazgDgmGdOnjxXPzI/ylMdvpgZNkFeafkKmXR2DagZ30rXSxDfaj5dUikwL40xszv+kDv7z8w+XdSMwKprWPyIPkNe2u7jumSuy6khXvKuSw72pTsRpQtf7+tusw+0Ievhfx/vfqL7PY8ERssiYhg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=xV6cE3lYNLcn733a1EmyhjCDB3A2zueslC8j7tXpRTU=;
 b=TD33/1/FN3VQnpsv4yZtDeS6LRYV1vMmuZp0rxQ5p29ARSkZYqmRAbcFuSDAZzpgBcxW14KB7Ao+EfqK56lIuXEg6l+Qz/xYfZL6WreTdVKXTUbPrZC6FVaW/vzH8m92g6p1/HM1q0BmyZfTjZYD1AS0Y+qdDInWQy7b/euVzZc=
Date: Tue, 26 Oct 2021 13:33:23 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Oleksandr Andrushchenko <andr2000@gmail.com>
CC: <xen-devel@lists.xenproject.org>, <julien@xen.org>,
	<sstabellini@kernel.org>, <oleksandr_tyshchenko@epam.com>,
	<volodymyr_babchuk@epam.com>, <Artem_Mygaiev@epam.com>, <jbeulich@suse.com>,
	<bertrand.marquis@arm.com>, <rahul.singh@arm.com>, Oleksandr Andrushchenko
	<oleksandr_andrushchenko@epam.com>
Subject: Re: [PATCH v3 10/11] vpci: Add initial support for virtual PCI bus
 topology
Message-ID: <YXfng3PqDI6C4yxn@MacBook-Air-de-Roger.local>
References: <20210930075223.860329-1-andr2000@gmail.com>
 <20210930075223.860329-11-andr2000@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20210930075223.860329-11-andr2000@gmail.com>
X-ClientProxiedBy: MR2P264CA0025.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500::13)
 To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 23e0f3f7-7f5b-4e0d-1346-08d998746ed5
X-MS-TrafficTypeDiagnostic: DM6PR03MB4140:
X-Microsoft-Antispam-PRVS: <DM6PR03MB41400F832A023BD4597D06A68F849@DM6PR03MB4140.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: Cx3Y6kQwknZMUCdwF72QvTdf4wAbuwAvHz9Ru48ug4FUbQQO/U6U+rqgc3MVLgQsAK4GVSTmIXXsH+j98dw+0vcIRB4ggIMnX9P4sMgF3wIZDuPquY6PLbrRkYWp2YPRrNeLbzUfd+lfe7iE0/N3e+WskAExWrzgV/QEAquyq87+84jbNlr87FMpfaySKouMi4ZZZfVsub/8aGur5yNz1doiT0TQXbkZz7y8Qvlv9QxQGMAUkou/Uvck7h1Hs8ndB/c6ENdVQU+vExzVYkfLSC6a1aLt5OGHadUHQN8e0jQ56nGRivrGuP/KhjUVMQp9N2w7B2k47QkaiOJLkJ82qe/03Dbl+MKpCOuzffi1J7AT9kNDpgZbznJoDQMGuMc3071+j1EMJD6JAqTd20htCHeBSwTI1W8OjJ0GqguRk7hBUPb1PlV6jlRw4NV2B4QOpFMmifDxuzNJvLrjP8OiZBPlw0d+n503yq3j4ZR8V+jw2iwHjPR184fzVtFPu2k6N6/whg4Y2Iildr+w9WK86VRrgKzwDwaGqIDF3wIuscBEGUGvpA4cqS1YfOx43oSMGyxmqxW9xfr3PUdtJZvh0YXEeZuV3opkfAl3qsQe09iws1w0p5JB9yir23i2DdhLVil0A7gLOJv4qsGQis5MIg==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(956004)(8936002)(4326008)(26005)(85182001)(6916009)(186003)(508600001)(2906002)(5660300002)(82960400001)(8676002)(66946007)(66476007)(66556008)(7416002)(86362001)(6496006)(316002)(6666004)(83380400001)(6486002)(9686003)(38100700002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QkhzSytialhpUG5lbzZCeE9mUGRHeWMxU2Nhc05NU2oxVkJobW4weStJekxy?=
 =?utf-8?B?TGhWYUJ0UGg5Ty9QZFJMNUpKZzdGWitjNzFySDQyTzYrekRZQUYvakhacVhj?=
 =?utf-8?B?TDB2M3dkMnBMLzhzZ21BVWRyaFppeEozaVNmOGc4UExReWsralMweGlDSW9Y?=
 =?utf-8?B?ekVvQ0g3VGJHTU1wdUVnU3JROFFDdVB2VHlXZUwxOEVkQk1uMStKZ0t3UzNQ?=
 =?utf-8?B?MVFKSyswd2tkVitLd3o3Sitrck96TjVWUytTN0t1ZHY0RDRJaG00R3RMUStY?=
 =?utf-8?B?NENnK09KVVQ3ZnRQNGJ5U3h1YXJaUXpVQ201clpTK3dhRW1tb3pabkoxSHRk?=
 =?utf-8?B?OEkxai9URFNuNm45SW1TYUxvKzVWUVVud0c0TmpwS0grTHZwV04rdVR2REt4?=
 =?utf-8?B?b2h3TGNMYjZaTjJUUUNnc1F6NHhkQVlSZU5HSVZUejFXSSt3WU1DdlAyaVpz?=
 =?utf-8?B?OEduMHIvNjdkQjFNSVR4L2NzcWIrbng1SDdUcjhhOFFPYndSUVUzbW11elh6?=
 =?utf-8?B?ajMyVXhEUVE3bTFpYUpCazlIeHJUS2NFNXowZzRGM2ZsVmZxSkp2THFsYmJp?=
 =?utf-8?B?NzVNMktJdnd3WUN3WVUyTVdCRUJBOXNVTTVyNXBrOTVPYWlpcThZNDJDMkc0?=
 =?utf-8?B?dklYenpJKzAwVXpRdkhXQmhKY0hxRkJtZXhtSFdRWVZqNzhONTNVSCtaSjFL?=
 =?utf-8?B?RXV0ZnlWZ252YUc1Nnp5NU5HaTg0dDU3cDlXSmlqMzZKY2NXa3M1aUo5anM3?=
 =?utf-8?B?ZHZ6azcwSWd4OXNLUFd2MDUxMGN2b00rMzBUS2RFWEhqZ0N6T0ErR0ROSkJD?=
 =?utf-8?B?RG02VEEvY2NBYllLdUgzRzdGazEzRHFQQU92THN3OWJ4ZGhaTHYyOWNYZ3ov?=
 =?utf-8?B?RjViU0lJSlZMUlNKeVF5b2J3Tk1hc2k2UWJXa3hCcElkcEVVSFBpOC8wUDMr?=
 =?utf-8?B?MVlVN3Nmdlkrdm1DQnRjSnhaUHdPYXBuTmIxNHJUSnlnVDQzeWpnanRDTG1R?=
 =?utf-8?B?ZFQ5V3RjdGJkWDBnYVljR0lpdkZCcytZbzVsWWRBTlVVM3VHc3g4TTkyV2pN?=
 =?utf-8?B?NUhuQlJnNmtzV0g3d1psZGx6SDVqSm1BOUxDQmw3NUdzU2kvT3hXdW8ySExh?=
 =?utf-8?B?cG1DbEhtK3g4cVV1bzFuZ1RZVnBKak53VEdiZ2cwZ1JIUS9DdURDUDYrOWFB?=
 =?utf-8?B?WW9FYVpoZUt4NW94a0svKzRJUGVsNVdzNWQzem5lOXVzNTZFRk9LZjM3V0Qr?=
 =?utf-8?B?U0FlOWhJaEdQYmVYdVFTNExoOXc0WTF3OVI0ZS9CTGpuN2FoYndtRG9UbHhp?=
 =?utf-8?B?S3RvWG5teHpJa1pTUy8rTHFNSlU4czlzOGlnUzg2dXAxZmxMNGJPTm0vVFR0?=
 =?utf-8?B?dFd1aW1jKzkzSDRSMllTT3o1WTF2NjNIbkpkMXAyRllPWWh2OWEwZmlIUW1l?=
 =?utf-8?B?cWJBdGU2cGlZaU1kVkJRRGw4cFF4YkpZSGY4WTUyU2pkdEsxWHExREFscGRi?=
 =?utf-8?B?YWZtSTF0Nll1a0NHUjlRWGVHTWhPeFQ4TnhiNXdGaUNMUTNvWHJaWGYyMFU5?=
 =?utf-8?B?aC9iNzFZTURIWm1jVWc3Y2hzbytPZWxXdXEwT1BwTmN2enBIcFlxYzFYM1Y3?=
 =?utf-8?B?MXJiUjlvRElIS0lUQ0RWV2F4eUVUVHhKZmlsWmtvQjdYK2l0TU0vMnl0S0JJ?=
 =?utf-8?B?YjU4MGJmNHZ5aE9ZQ0d3RXpkQjBTNGlQNUwxakFJamM5UVFlb3l4T3dLTVd4?=
 =?utf-8?B?UHdnMndTdkxNWG1TVnFYNnFHNTM1b1BtUHNxbkNoa2dTRi91T0RCdFVTYmtD?=
 =?utf-8?B?QnBSQUxGRXR2cUcyOGtneEpWWUE5TUQzbXpKSk9DUjJ4azVrY2UvNHF6UjNH?=
 =?utf-8?B?TXFVMXI0RklBM0o2YWJyRkFnemEzS1l2QkZqcUdkTUh5MndJZndoZGNPNWh2?=
 =?utf-8?B?ankzbW1iZVorRzk4RFVCNGdaaFZBaElwck5TWW91bk1FNUdXTDcrakJkem1H?=
 =?utf-8?B?WWk3UzdDb05hV3phTzVRU2ROcjc5bFJjd2RLNzUvdzk2NFJGL2gxcWsyWVoy?=
 =?utf-8?B?cG43SFpPV1E3T0FsaTBWalREUnlsOGxLYlR6TmdZSS90b09DMUM5aGhkWlRT?=
 =?utf-8?B?b01PRFNMSXZCRkRNQkF1TFdSdVNJRU00TDhzTkNldndaUE1HN2trYjVyT0pp?=
 =?utf-8?Q?pVJ51M0qa4QIMfdO0zD3HrA=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 23e0f3f7-7f5b-4e0d-1346-08d998746ed5
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2021 11:33:29.3757
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Eaoxt/psnUyGY7ZYaczs+M6ESVFATaLUhBNY/b48/vIHXB3DLFLhFR6UQF3jt887FPe6QDsVO/bdzMO6C/vuqQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4140
X-OriginatorOrg: citrix.com

On Thu, Sep 30, 2021 at 10:52:22AM +0300, Oleksandr Andrushchenko wrote:
> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> 
> Assign SBDF to the PCI devices being passed through with bus 0.
> The resulting topology is where PCIe devices reside on the bus 0 of the
> root complex itself (embedded endpoints).
> This implementation is limited to 32 devices which are allowed on
> a single PCI bus.
> 
> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> 
> ---
> Since v2:
>  - remove casts that are (a) malformed and (b) unnecessary
>  - add new line for better readability
>  - remove CONFIG_HAS_VPCI_GUEST_SUPPORT ifdef's as the relevant vPCI
>     functions are now completely gated with this config
>  - gate common code with CONFIG_HAS_VPCI_GUEST_SUPPORT
> New in v2
> ---
>  xen/common/domain.c           |  3 ++
>  xen/drivers/passthrough/pci.c | 60 +++++++++++++++++++++++++++++++++++
>  xen/drivers/vpci/vpci.c       | 14 +++++++-
>  xen/include/xen/pci.h         | 22 +++++++++++++
>  xen/include/xen/sched.h       |  8 +++++
>  5 files changed, 106 insertions(+), 1 deletion(-)
> 
> diff --git a/xen/common/domain.c b/xen/common/domain.c
> index 40d67ec34232..e0170087612d 100644
> --- a/xen/common/domain.c
> +++ b/xen/common/domain.c
> @@ -601,6 +601,9 @@ struct domain *domain_create(domid_t domid,
>  
>  #ifdef CONFIG_HAS_PCI
>      INIT_LIST_HEAD(&d->pdev_list);
> +#ifdef CONFIG_HAS_VPCI_GUEST_SUPPORT
> +    INIT_LIST_HEAD(&d->vdev_list);
> +#endif
>  #endif
>  
>      /* All error paths can depend on the above setup. */
> diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci.c
> index 805ab86ed555..5b963d75d1ba 100644
> --- a/xen/drivers/passthrough/pci.c
> +++ b/xen/drivers/passthrough/pci.c
> @@ -831,6 +831,66 @@ int pci_remove_device(u16 seg, u8 bus, u8 devfn)
>      return ret;
>  }
>  
> +#ifdef CONFIG_HAS_VPCI_GUEST_SUPPORT
> +static struct vpci_dev *pci_find_virtual_device(const struct domain *d,
> +                                                const struct pci_dev *pdev)
> +{
> +    struct vpci_dev *vdev;
> +
> +    list_for_each_entry ( vdev, &d->vdev_list, list )
> +        if ( vdev->pdev == pdev )
> +            return vdev;
> +    return NULL;
> +}
> +
> +int pci_add_virtual_device(struct domain *d, const struct pci_dev *pdev)
> +{
> +    struct vpci_dev *vdev;
> +
> +    ASSERT(!pci_find_virtual_device(d, pdev));
> +
> +    /* Each PCI bus supports 32 devices/slots at max. */
> +    if ( d->vpci_dev_next > 31 )
> +        return -ENOSPC;
> +
> +    vdev = xzalloc(struct vpci_dev);
> +    if ( !vdev )
> +        return -ENOMEM;
> +
> +    /* We emulate a single host bridge for the guest, so segment is always 0. */
> +    vdev->seg = 0;
> +
> +    /*
> +     * The bus number is set to 0, so virtual devices are seen
> +     * as embedded endpoints behind the root complex.
> +     */
> +    vdev->bus = 0;
> +    vdev->devfn = PCI_DEVFN(d->vpci_dev_next++, 0);

This would likely be better as a bitmap where you set the bits of
in-use slots. Then you can use find_first_bit or similar to get a free
slot.

Long term you might want to allow the caller to provide a pre-selected
slot, as it's possible for users to request the device to appear at a
specific slot on the emulated bus.

> +
> +    vdev->pdev = pdev;
> +    vdev->domain = d;
> +
> +    pcidevs_lock();
> +    list_add_tail(&vdev->list, &d->vdev_list);
> +    pcidevs_unlock();
> +
> +    return 0;
> +}
> +
> +int pci_remove_virtual_device(struct domain *d, const struct pci_dev *pdev)
> +{
> +    struct vpci_dev *vdev;
> +
> +    pcidevs_lock();
> +    vdev = pci_find_virtual_device(d, pdev);
> +    if ( vdev )
> +        list_del(&vdev->list);
> +    pcidevs_unlock();
> +    xfree(vdev);
> +    return 0;
> +}
> +#endif /* CONFIG_HAS_VPCI_GUEST_SUPPORT */
> +
>  /* Caller should hold the pcidevs_lock */
>  static int deassign_device(struct domain *d, uint16_t seg, uint8_t bus,
>                             uint8_t devfn)
> diff --git a/xen/drivers/vpci/vpci.c b/xen/drivers/vpci/vpci.c
> index 702f7b5d5dda..d787f13e679e 100644
> --- a/xen/drivers/vpci/vpci.c
> +++ b/xen/drivers/vpci/vpci.c
> @@ -91,20 +91,32 @@ int __hwdom_init vpci_add_handlers(struct pci_dev *pdev)
>  /* Notify vPCI that device is assigned to guest. */
>  int vpci_assign_device(struct domain *d, const struct pci_dev *dev)
>  {
> +    int rc;
> +
>      /* It only makes sense to assign for hwdom or guest domain. */
>      if ( is_system_domain(d) || !has_vpci(d) )
>          return 0;
>  
> -    return vpci_bar_add_handlers(d, dev);
> +    rc = vpci_bar_add_handlers(d, dev);
> +    if ( rc )
> +        return rc;
> +
> +    return pci_add_virtual_device(d, dev);
>  }
>  
>  /* Notify vPCI that device is de-assigned from guest. */
>  int vpci_deassign_device(struct domain *d, const struct pci_dev *dev)
>  {
> +    int rc;
> +
>      /* It only makes sense to de-assign from hwdom or guest domain. */
>      if ( is_system_domain(d) || !has_vpci(d) )
>          return 0;
>  
> +    rc = pci_remove_virtual_device(d, dev);
> +    if ( rc )
> +        return rc;
> +
>      return vpci_bar_remove_handlers(d, dev);
>  }
>  #endif /* CONFIG_HAS_VPCI_GUEST_SUPPORT */
> diff --git a/xen/include/xen/pci.h b/xen/include/xen/pci.h
> index 43b8a0817076..33033a3a8f8d 100644
> --- a/xen/include/xen/pci.h
> +++ b/xen/include/xen/pci.h
> @@ -137,6 +137,24 @@ struct pci_dev {
>      struct vpci *vpci;
>  };
>  
> +#ifdef CONFIG_HAS_VPCI_GUEST_SUPPORT
> +struct vpci_dev {
> +    struct list_head list;
> +    /* Physical PCI device this virtual device is connected to. */
> +    const struct pci_dev *pdev;
> +    /* Virtual SBDF of the device. */
> +    union {
> +        struct {
> +            uint8_t devfn;
> +            uint8_t bus;
> +            uint16_t seg;
> +        };
> +        pci_sbdf_t sbdf;
> +    };
> +    struct domain *domain;
> +};
> +#endif

I wonder whether this is strictly needed. Won't it be enough to store
the virtual (ie: guest) sbdf inside the existing vpci struct?

It would avoid the overhead of the translation you do from pdev ->
vdev, and there doesn't seem to be anything relevant stored in
vpci_dev apart from the virtual sbdf.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Tue Oct 26 11:43:52 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Oct 2021 11:43:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.216393.375980 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfKrr-0004IT-4X; Tue, 26 Oct 2021 11:43:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 216393.375980; Tue, 26 Oct 2021 11:43:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfKrr-0004IM-1f; Tue, 26 Oct 2021 11:43:47 +0000
Received: by outflank-mailman (input) for mailman id 216393;
 Tue, 26 Oct 2021 11:43:45 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mfKrp-0004Ht-QB; Tue, 26 Oct 2021 11:43:45 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mfKrp-0007ig-J5; Tue, 26 Oct 2021 11:43:45 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mfKrp-0002AA-A2; Tue, 26 Oct 2021 11:43:45 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mfKrp-00046b-9U; Tue, 26 Oct 2021 11:43:45 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=UutaqFvbRB3e1N8Hw3kJFGNq6/p5GDD9g3YgDNfX2rI=; b=hDpo94n4wZ3ggpJSY/aXwBYFC5
	+WpHnM3DfW8ex0BziZkhwdadlfApid7pspr+U4KphGmBaWfVKXhGTTcCWC2XJb1qY3fmgBojHW2PO
	seu0GLTXlg0aYTPzeBG31tvOwV5OaGYpM73CmmF+4HBmcmRVdC7WNea+0alE+UP+194Q=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165871-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 165871: regressions - FAIL
X-Osstest-Failures:
    libvirt:build-armhf-libvirt:libvirt-build:fail:regression
    libvirt:build-amd64-libvirt:libvirt-build:fail:regression
    libvirt:build-i386-libvirt:libvirt-build:fail:regression
    libvirt:build-arm64-libvirt:libvirt-build:fail:regression
    libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    libvirt=54cf221b55d818e2191b0a85fe87c38f66dca093
X-Osstest-Versions-That:
    libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 26 Oct 2021 11:43:45 +0000

flight 165871 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165871/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-armhf-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-amd64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-i386-libvirt            6 libvirt-build            fail REGR. vs. 151777
 build-arm64-libvirt           6 libvirt-build            fail REGR. vs. 151777

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-libvirt-vhd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a

version targeted for testing:
 libvirt              54cf221b55d818e2191b0a85fe87c38f66dca093
baseline version:
 libvirt              2c846fa6bcc11929c9fb857a22430fb9945654ad

Last test of basis   151777  2020-07-10 04:19:19 Z  473 days
Failing since        151818  2020-07-11 04:18:52 Z  472 days  458 attempts
Testing same since   165871  2021-10-26 04:18:53 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
    Adolfo Jayme Barrientos <fitoschido@gmail.com>
  Aleksandr Alekseev <alexander.alekseev@virtuozzo.com>
  Aleksei Zakharov <zaharov@selectel.ru>
  Andika Triwidada <andika@gmail.com>
  Andrea Bolognani <abologna@redhat.com>
  Ani Sinha <ani@anisinha.ca>
  Balázs Meskó <meskobalazs@mailbox.org>
  Barrett Schonefeld <bschoney@utexas.edu>
  Bastian Germann <bastiangermann@fishpost.de>
  Bastien Orivel <bastien.orivel@diateam.net>
  BiaoXiang Ye <yebiaoxiang@huawei.com>
  Bihong Yu <yubihong@huawei.com>
  Binfeng Wu <wubinfeng@huawei.com>
  Bjoern Walk <bwalk@linux.ibm.com>
  Boris Fiuczynski <fiuczy@linux.ibm.com>
  Brian Turek <brian.turek@gmail.com>
  Bruno Haible <bruno@clisp.org>
  Chris Mayo <aklhfex@gmail.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Ehrhardt <christian.ehrhardt@canonical.com>
  Christian Kirbach <christian.kirbach@gmail.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Cole Robinson <crobinso@redhat.com>
  Collin Walling <walling@linux.ibm.com>
  Cornelia Huck <cohuck@redhat.com>
  Cédric Bosdonnat <cbosdonnat@suse.com>
  Côme Borsoi <fedora@borsoi.fr>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniel Letai <dani@letai.org.il>
  Daniel P. Berrange <berrange@redhat.com>
  Daniel P. Berrangé <berrange@redhat.com>
  Didik Supriadi <didiksupriadi41@gmail.com>
  dinglimin <dinglimin@cmss.chinamobile.com>
  Dmitrii Shcherbakov <dmitrii.shcherbakov@canonical.com>
  Dmytro Linkin <dlinkin@nvidia.com>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Eric Farman <farman@linux.ibm.com>
  Erik Skultety <eskultet@redhat.com>
  Fabian Affolter <mail@fabian-affolter.ch>
  Fabian Freyer <fabian.freyer@physik.tu-berlin.de>
  Fabiano Fidêncio <fabiano@fidencio.org>
  Fangge Jin <fjin@redhat.com>
  Farhan Ali <alifm@linux.ibm.com>
  Fedora Weblate Translation <i18n@lists.fedoraproject.org>
  Gavi Teitz <gavi@nvidia.com>
  gongwei <gongwei@smartx.com>
  Guoyi Tu<tu.guoyi@h3c.com>
  Göran Uddeborg <goeran@uddeborg.se>
  Halil Pasic <pasic@linux.ibm.com>
  Han Han <hhan@redhat.com>
  Hao Wang <wanghao232@huawei.com>
  Hela Basa <r45xveza@pm.me>
  Helmut Grohne <helmut@subdivi.de>
  Hiroki Narukawa <hnarukaw@yahoo-corp.jp>
  Ian Wienand <iwienand@redhat.com>
  Jakob Meng <jakobmeng@web.de>
  Jamie Strandboge <jamie@canonical.com>
  Jamie Strandboge <jamie@ubuntu.com>
  Jan Kuparinen <copper_fin@hotmail.com>
  jason lee <ppark5237@gmail.com>
  Jean-Baptiste Holcroft <jean-baptiste@holcroft.fr>
  Jia Zhou <zhou.jia2@zte.com.cn>
  Jianan Gao <jgao@redhat.com>
  Jim Fehlig <jfehlig@suse.com>
  Jin Yan <jinyan12@huawei.com>
  Jinsheng Zhang <zhangjl02@inspur.com>
  Jiri Denemark <jdenemar@redhat.com>
  John Ferlan <jferlan@redhat.com>
  Jonathan Watt <jwatt@jwatt.org>
  Jonathon Jongsma <jjongsma@redhat.com>
  Julio Faracco <jcfaracco@gmail.com>
  Justin Gatzen <justin.gatzen@gmail.com>
  Ján Tomko <jtomko@redhat.com>
  Kashyap Chamarthy <kchamart@redhat.com>
  Kevin Locke <kevin@kevinlocke.name>
  Kristina Hanicova <khanicov@redhat.com>
  Laine Stump <laine@redhat.com>
  Laszlo Ersek <lersek@redhat.com>
  Lee Yarwood <lyarwood@redhat.com>
  Lei Yang <yanglei209@huawei.com>
  Liao Pingfang <liao.pingfang@zte.com.cn>
  Lin Ma <lma@suse.com>
  Lin Ma <lma@suse.de>
  Lin Ma <morecache@gmail.com>
  Liu Yiding <liuyd.fnst@fujitsu.com>
  Luke Yue <lukedyue@gmail.com>
  Luyao Zhong <luyao.zhong@intel.com>
  Marc Hartmayer <mhartmay@linux.ibm.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Markus Schade <markus.schade@hetzner.com>
  Martin Kletzander <mkletzan@redhat.com>
  Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
  Matej Cepl <mcepl@cepl.eu>
  Matt Coleman <matt@datto.com>
  Matt Coleman <mcoleman@datto.com>
  Mauro Matteo Cascella <mcascell@redhat.com>
  Meina Li <meili@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Michał Smyk <fedora@smyk.it>
  Milo Casagrande <milo@milo.name>
  Moshe Levi <moshele@nvidia.com>
  Muha Aliss <muhaaliss@gmail.com>
  Nathan <nathan95@live.it>
  Neal Gompa <ngompa13@gmail.com>
  Nick Chevsky <nchevsky@gmail.com>
  Nick Shyrokovskiy <nshyrokovskiy@gmail.com>
  Nickys Music Group <nickys.music.group@gmail.com>
  Nico Pache <npache@redhat.com>
  Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
  Olaf Hering <olaf@aepfle.de>
  Olesya Gerasimenko <gammaray@basealt.ru>
  Or Ozeri <oro@il.ibm.com>
  Orion Poplawski <orion@nwra.com>
  Pany <geekpany@gmail.com>
  Patrick Magauran <patmagauran.j@gmail.com>
  Paulo de Rezende Pinatti <ppinatti@linux.ibm.com>
  Pavel Hrdina <phrdina@redhat.com>
  Peng Liang <liangpeng10@huawei.com>
  Peter Krempa <pkrempa@redhat.com>
  Pino Toscano <ptoscano@redhat.com>
  Pino Toscano <toscano.pino@tiscali.it>
  Piotr Drąg <piotrdrag@gmail.com>
  Prathamesh Chavan <pc44800@gmail.com>
  Praveen K Paladugu <prapal@linux.microsoft.com>
  Richard W.M. Jones <rjones@redhat.com>
  Ricky Tigg <ricky.tigg@gmail.com>
  Robin Lee <cheeselee@fedoraproject.org>
  Roman Bogorodskiy <bogorodskiy@gmail.com>
  Roman Bolshakov <r.bolshakov@yadro.com>
  Ryan Gahagan <rgahagan@cs.utexas.edu>
  Ryan Schmidt <git@ryandesign.com>
  Sam Hartman <hartmans@debian.org>
  Scott Shambarger <scott-libvirt@shambarger.net>
  Sebastian Mitterle <smitterl@redhat.com>
  SeongHyun Jo <caelus9536@gmail.com>
  Shalini Chellathurai Saroja <shalini@linux.ibm.com>
  Shaojun Yang <yangshaojun@phytium.com.cn>
  Shi Lei <shi_lei@massclouds.com>
  simmon <simmon@nplob.com>
  Simon Chopin <chopin.simon@gmail.com>
  Simon Gaiser <simon@invisiblethingslab.com>
  Simon Rowe <simon.rowe@nutanix.com>
  Stefan Bader <stefan.bader@canonical.com>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Berger <stefanb@linux.vnet.ibm.com>
  Stefan Hajnoczi <stefanha@gmail.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Szymon Scholz <szymonscholz@gmail.com>
  Thomas Huth <thuth@redhat.com>
  Tim Wiederhake <twiederh@redhat.com>
  Tomáš Golembiovský <tgolembi@redhat.com>
  Tomáš Janoušek <tomi@nomi.cz>
  Tuguoyi <tu.guoyi@h3c.com>
  Victor Toso <victortoso@redhat.com>
  Ville Skyttä <ville.skytta@iki.fi>
  Vinayak Kale <vkale@nvidia.com>
  Wang Xin <wangxinxin.wang@huawei.com>
  WangJian <wangjian161@huawei.com>
  Weblate <noreply@weblate.org>
  Wei Liu <liuwe@microsoft.com>
  Wei Liu <wei.liu@kernel.org>
  Wei-Chen Chen <weicche@microsoft.com>
  William Douglas <william.douglas@intel.com>
  Yalei Li <274268859@qq.com>
  Yalei Li <liyl43@chinatelecom.cn>
  Yang Fei <yangfei85@huawei.com>
  Yang Hang <yanghang44@huawei.com>
  Yanqiu Zhang <yanqzhan@redhat.com>
  Yaroslav Kargin <ykargin@virtuozzo.com>
  Yi Li <yili@winhong.com>
  Yi Wang <wang.yi59@zte.com.cn>
  Yuri Chornoivan <yurchor@ukr.net>
  Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
  zhangjl02 <zhangjl02@inspur.com>
  Zheng Chuan <zhengchuan@huawei.com>
  zhenwei pi <pizhenwei@bytedance.com>
  Zhenyu Ye <yezhenyu2@huawei.com>
  Zhenyu Zheng <zheng.zhenyu@outlook.com>
  Zhenzhong Duan <zhenzhong.duan@intel.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          fail    
 build-arm64-libvirt                                          fail    
 build-armhf-libvirt                                          fail    
 build-i386-libvirt                                           fail    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           blocked 
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-libvirt-xsm                                 blocked 
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-libvirt                                     blocked 
 test-arm64-arm64-libvirt                                     blocked 
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-libvirt-pair                                blocked 
 test-amd64-i386-libvirt-pair                                 blocked 
 test-arm64-arm64-libvirt-qcow2                               blocked 
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-libvirt-vhd                                 blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 81011 lines long.)


From xen-devel-bounces@lists.xenproject.org Tue Oct 26 12:11:45 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Oct 2021 12:11:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.216410.375994 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfLIk-0007ko-Sq; Tue, 26 Oct 2021 12:11:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 216410.375994; Tue, 26 Oct 2021 12:11:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfLIk-0007kh-Pk; Tue, 26 Oct 2021 12:11:34 +0000
Received: by outflank-mailman (input) for mailman id 216410;
 Tue, 26 Oct 2021 12:11:33 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mfLIj-0007kX-Hl; Tue, 26 Oct 2021 12:11:33 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mfLIj-0008Cn-9Q; Tue, 26 Oct 2021 12:11:33 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mfLIi-0003Fp-Sd; Tue, 26 Oct 2021 12:11:32 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mfLIi-0002SF-S9; Tue, 26 Oct 2021 12:11:32 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=zbGVPUdKZ1ICUyR1q/HQwudol2uWLIv3GQMYSZST33g=; b=JNyX7bZtCI1THAkAIYK+/Z2dXz
	uFJmJaISvA4XbcsEWSENAJZ+wzQRbZGY8rEXty23Ie8Put4XhgNg1+qjQWS1OnrGnFxMFFEHaWqhB
	ldajlmL0OhbBp9Fp8wxO5ChLpfJOb6Yd29WR4pJRo5/wQOddo8NCQVlOwlzhNkxDbB3M=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165868-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 165868: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=3906fe9bb7f1a2c8667ae54e967dc8690824f4ea
X-Osstest-Versions-That:
    linux=87066fdd2e30fe9dd531125d95257c118a74617e
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 26 Oct 2021 12:11:32 +0000

flight 165868 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165868/

Failures :-/ but no regressions.

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds    18 guest-start/debian.repeat fail REGR. vs. 165858

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 165858
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 165858
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165858
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 165858
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165858
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 165858
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 165858
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165858
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 linux                3906fe9bb7f1a2c8667ae54e967dc8690824f4ea
baseline version:
 linux                87066fdd2e30fe9dd531125d95257c118a74617e

Last test of basis   165858  2021-10-25 09:41:25 Z    1 days
Testing same since   165868  2021-10-25 23:39:26 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Ard Biesheuvel <ardb@kernel.org>
  Arnd Bergmann <arnd@arndb.de>
  Corentin Labbe <clabbe.montjoie@gmail.com>
  Damien Le Moal <damien.lemoal@opensource.wdc.com>
  Fabien Dessenne <fabien.dessenne@foss.st.com>
  LABBE Corentin <clabbe.montjoie@gmail.com>
  Lexi Shao <shaolexi@huawei.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Linus Walleij <linus.walleij@linaro.org>
  Masami Hiramatsu <mhiramat@kernel.org>
  Matthew Wilcox (Oracle) <willy@infradead.org>
  Nathan Chancellor <nathan@kernel.org>
  Nick Desaulniers <ndesaulniers@google.com>
  Rafał Miłecki <rafal@milecki.pl>
  Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
  Sachi King <nakato@nakato.io>
  Zheyu Ma <zheyuma97@gmail.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   87066fdd2e30..3906fe9bb7f1  3906fe9bb7f1a2c8667ae54e967dc8690824f4ea -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Tue Oct 26 12:29:35 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Oct 2021 12:29:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.216420.376014 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfLa4-0000tm-GX; Tue, 26 Oct 2021 12:29:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 216420.376014; Tue, 26 Oct 2021 12:29:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfLa4-0000tf-DD; Tue, 26 Oct 2021 12:29:28 +0000
Received: by outflank-mailman (input) for mailman id 216420;
 Tue, 26 Oct 2021 12:29:26 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=TCfe=PO=arm.com=michal.orzel@srs-us1.protection.inumbo.net>)
 id 1mfLa2-0000tZ-Ti
 for xen-devel@lists.xenproject.org; Tue, 26 Oct 2021 12:29:26 +0000
Received: from foss.arm.com (unknown [217.140.110.172])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTP
 id 98b9fba7-c59b-400c-ac58-dd57c1f87a97;
 Tue, 26 Oct 2021 12:29:24 +0000 (UTC)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9144B1FB;
 Tue, 26 Oct 2021 05:29:24 -0700 (PDT)
Received: from e123311-lin.arm.com (unknown [10.57.23.13])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0981E3F73D;
 Tue, 26 Oct 2021 05:29:22 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 98b9fba7-c59b-400c-ac58-dd57c1f87a97
From: Michal Orzel <michal.orzel@arm.com>
To: xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	bertrand.marquis@arm.com,
	Ian Jackson <iwj@xenproject.org>
Subject: [patch-4.16] arm/smmuv1,v2: Protect smmu master list with a lock
Date: Tue, 26 Oct 2021 14:29:03 +0200
Message-Id: <20211026122903.15042-1-michal.orzel@arm.com>
X-Mailer: git-send-email 2.29.0
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

If a device is added to SMMUv1/v2 from DT and PCI
at the same time, there is a concurrent access
to a smmu master list. This could lead to a
scenario where one is looking into a list that
is being modified at the same time. Add a lock
to prevent this issue.

Reuse the existing spinlock arm_smmu_devices_lock
as it is already protecting find_smmu_master.

ipmmu-smmu and smmuv3 are not impacted by this
issue as there is no access or modification of
a global resource during add_device.

Signed-off-by: Michal Orzel <michal.orzel@arm.com>
---
This patch aims for 4.16 release.
Benefits:
Remove a bug that could lead to a corruption of the
smmu master list, which would be very hard to debug.
Risks:
Overall the risk is low as we are touching init code
rather than a runtime one. In case of any issue, the
problem would be catched during system boot or guest
start.
---
 xen/drivers/passthrough/arm/smmu.c | 25 +++++++++++++++++++------
 1 file changed, 19 insertions(+), 6 deletions(-)

diff --git a/xen/drivers/passthrough/arm/smmu.c b/xen/drivers/passthrough/arm/smmu.c
index c9dfc4caa0..be62a66a28 100644
--- a/xen/drivers/passthrough/arm/smmu.c
+++ b/xen/drivers/passthrough/arm/smmu.c
@@ -820,21 +820,25 @@ static int arm_smmu_dt_add_device_legacy(struct arm_smmu_device *smmu,
 					 struct device *dev,
 					 struct iommu_fwspec *fwspec)
 {
-	int i;
+	int i, ret;
 	struct arm_smmu_master *master;
 	struct device_node *dev_node = dev_get_dev_node(dev);
 
+	spin_lock(&arm_smmu_devices_lock);
 	master = find_smmu_master(smmu, dev_node);
 	if (master) {
 		dev_err(dev,
 			"rejecting multiple registrations for master device %s\n",
 			dev_node->name);
-		return -EBUSY;
+		ret = -EBUSY;
+		goto out_unlock;
 	}
 
 	master = devm_kzalloc(dev, sizeof(*master), GFP_KERNEL);
-	if (!master)
-		return -ENOMEM;
+	if (!master) {
+		ret = -ENOMEM;
+		goto out_unlock;
+	}
 	master->of_node = dev_node;
 
 	/* Xen: Let Xen know that the device is protected by an SMMU */
@@ -846,11 +850,17 @@ static int arm_smmu_dt_add_device_legacy(struct arm_smmu_device *smmu,
 			dev_err(dev,
 				"stream ID for master device %s greater than maximum allowed (%d)\n",
 				dev_node->name, smmu->num_mapping_groups);
-			return -ERANGE;
+			ret = -ERANGE;
+			goto out_unlock;
 		}
 		master->cfg.smendx[i] = INVALID_SMENDX;
 	}
-	return insert_smmu_master(smmu, master);
+
+	ret = insert_smmu_master(smmu, master);
+
+out_unlock:
+	spin_unlock(&arm_smmu_devices_lock);
+	return ret;
 }
 
 static int register_smmu_master(struct arm_smmu_device *smmu,
@@ -2056,7 +2066,10 @@ static int arm_smmu_add_device(struct device *dev)
 	} else {
 		struct arm_smmu_master *master;
 
+		spin_lock(&arm_smmu_devices_lock);
 		master = find_smmu_master(smmu, dev->of_node);
+		spin_unlock(&arm_smmu_devices_lock);
+
 		if (!master) {
 			return -ENODEV;
 		}
-- 
2.29.0



From xen-devel-bounces@lists.xenproject.org Tue Oct 26 13:14:11 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Oct 2021 13:14:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.216427.376025 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfMH8-0005jU-T7; Tue, 26 Oct 2021 13:13:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 216427.376025; Tue, 26 Oct 2021 13:13:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfMH8-0005jN-PV; Tue, 26 Oct 2021 13:13:58 +0000
Received: by outflank-mailman (input) for mailman id 216427;
 Tue, 26 Oct 2021 13:13:57 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mfMH7-0005jD-Mh; Tue, 26 Oct 2021 13:13:57 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mfMH7-0000np-If; Tue, 26 Oct 2021 13:13:57 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mfMH7-0005fs-9q; Tue, 26 Oct 2021 13:13:57 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mfMH7-0005ku-9J; Tue, 26 Oct 2021 13:13:57 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=2M7ntxn1PebMNN0OjefNYVXAiGXe7o2QiXO3fEb0lVY=; b=mbcvUybFU/bAONpCW9nVyESDz/
	lbE1gy1dXmI2iD13l2y2oQ1DYb7cT2JPOZFsHgDZWI96f39TYgf3pE0ZVBfGmW1g/09Vo3LmZxLlb
	S45qw7GzVgIF5cX9bzW+EoTtbsqNbAT2VUQPlhs6R/zCeukzIW1twas+SUA1YFqiOo88=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165873-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 165873: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=2f6f3329add328103cb0654b71d7b814dc0c9759
X-Osstest-Versions-That:
    ovmf=b80c17b62d989ec00e528c6307c726ce6800bcc4
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 26 Oct 2021 13:13:57 +0000

flight 165873 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165873/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 2f6f3329add328103cb0654b71d7b814dc0c9759
baseline version:
 ovmf                 b80c17b62d989ec00e528c6307c726ce6800bcc4

Last test of basis   165862  2021-10-25 17:41:18 Z    0 days
Testing same since   165873  2021-10-26 05:40:10 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Yang Jie <jie.yang@intel.com>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   b80c17b62d..2f6f3329ad  2f6f3329add328103cb0654b71d7b814dc0c9759 -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Tue Oct 26 13:30:34 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Oct 2021 13:30:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.216435.376039 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfMX6-00082c-CZ; Tue, 26 Oct 2021 13:30:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 216435.376039; Tue, 26 Oct 2021 13:30:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfMX6-00082V-8Y; Tue, 26 Oct 2021 13:30:28 +0000
Received: by outflank-mailman (input) for mailman id 216435;
 Tue, 26 Oct 2021 13:30:27 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=d0pl=PO=citrix.com=roger.pau@srs-us1.protection.inumbo.net>)
 id 1mfMX4-00082P-Rq
 for xen-devel@lists.xenproject.org; Tue, 26 Oct 2021 13:30:27 +0000
Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id ae53d591-5a95-4813-89a9-3bd486385101;
 Tue, 26 Oct 2021 13:30:24 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ae53d591-5a95-4813-89a9-3bd486385101
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1635255024;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=6p036b/5ecfVrdcgdMILWvunAmwmxkKBC1CR3vFOj58=;
  b=E4nk/i+l01ppNZIa8UmC0oiFz3BUysPSqUGoInTGoMiybwZx12J8I+bS
   TurqCfvw1jBq8jx76EdsEjrzkTiZ/ChSdzeTYpi4QTMQhs18IL0xSbpEQ
   bBeoVtIlhk0DkzizLd/asrqsdag2ubaQsykfWV6yBNhPWTwwZDCthujET
   E=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: RhLxx8hBuafBKc7eFqDPHncNl4IReHDvRQNYWfdwFQz8+Dg7BOKx/hBrtB4/5WL57pDCm+EpQY
 rw0cwOma8HhPFoNH5dshdRGxtWeHQy9hRrPrSD7u5nNtJgvRMPhiS1Qvfe6K4MkqMDkLz6OhIr
 0jCQXUn6WJ7aTw5zQr+Z+fHDesscHYbzmzwF+E4V+AJMUrKmGTLA0kncJ8dEtxGq5N0HjLNado
 kCyvl6u7Runxkm35n9PddiiPPPif0TjeAMG7O9VPXjDCV+TmTWo0hnFyTB6m1YSvaCl5HboXrW
 jZv1z1Ig48zCeHUTHGn75Pag
X-SBRS: 5.1
X-MesageID: 58003630
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:rDJ0nKvOGbgPgFSXTk7W7pJwAOfnVHRYMUV32f8akzHdYApBsoF/q
 tZmKWCFOKuPYGejL9ElYNjiphlV7cOHmtBqGwtqriFjFygT+JbJXdiXEBz9bniYRiHhoOOLz
 Cm8hv3odp1coqr0/0/1WlTZQP0VOZigHtIQMsadUsxKbVIiGHhJZS5LwbZj29cw24bhWGthh
 PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe
 gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ
 NplrbKqEQkVAe7wt6dNAkl7EBpXP7BU9+qSSZS/mZT7I0zudnLtx7NlDV0sPJ1e8eFyaY1M3
 aVGcnZXNEnF3r/ohuLgIgVvrp1LwM3DJoQQt2sm1TjEJf0nXYrCU+PB4towMDIY25AWRa2AP
 JJxhTxHQQ3vTyBVEXsuVpMvpdeI13zwb2J8pwfAzUYwyzeKl1EguFT3C/LXcNGXQcRenm6Du
 3nLuW/+B3kyHcaDxD+y12Ojj+7Cgwv2QIsXUra/85ZCilCJ2nYaDhFQUFKhuOS4kWa3QdcZI
 EsRkgIpqaUx70WtQsPKVhu0umOfvhUcVtxTFMU38AiIjKHT5m6xHGEEUzoHc90gu88eTCYvk
 FSOmrvBGztrt7GETGOHwb2dpziyJCs9IHcLYGkPSg5ty8nupsQ/gwzCSv5nEbWplZvlFDfo2
 TeIoSMiwbIJgqYj3qO35wqf22qEqZ3ATwpz7QLSNkqn8wd4aYiNd4Gur1/B4p5oK4KUTUKIu
 nQerNSP9+AFDZyLlyulTf0EGfei4PPtGCbHnVdlEp0l9jKs032uZ4Zd5Hd5PkgBDyofUWa3O
 gmJ41oXvcINeivxBUNqX26vI9wE1/DuKeumat+XPoseQZtKXQ2a7i47MCZ8wFvRuEQrlKg+P
 7KSfsCtEWsWBMxb8damewsO+eR0nn5mlAs/Ubi+lk79iePPOxZ5XJ9caAPWBt3V+p9ot+k8H
 zx3DMCN1wlEGNP3Zi3a4Ob/xnhbcCBlW/gaRyFRH9NvwzaK+kl9VJc9Ipt7IuSJepi5cc+Tp
 hmAtrdwkgaXuJE+AVzihopfQL3uR41jinkwIDYhO12ls1B6P93ytfdPLspmLeh2nACG8RKTZ
 6JdE/hs/9wVEmiXk9jjRcClxGCdSPhbrV3XZHf0CNTOV5VhWxbI6rfZkvjHr0Ez4t6MnZJm+
 dWIj1qDKbJaHlgKJJuGOZqHkgLq1VBAyb0aYqc9CoQKEKka2NMxcHKZYz5eC5xkFCgvMRPAh
 1rKWExD9beWy2L3mfGQ7Z25Q06SO7IWNmJRHnXB7KbwMi/f/2G5xpRHXvrOdjfYPF4YMo34D
 QmM5/2jYvABgnhQtI9wT+Riwa4kvoO9rL5G1AV0Wn7Mag3zWL9nJ3CH2+hJt7FMmeAF6VfnB
 BrX94kII6iNNePkDEUVeFgvYNOc2KxGgTLV9/k0fhn3vXcl4LqdXExOFBCQkygBfqBtOYYoz
 L556s4b4gCykDQwNdOCgnwG/miANCVYAa4mqosbEMngjQ9ykgNOZpnVCynX5pCTaooTbhl2c
 2HM3Keb3uZS3EvPdXY3BEPh5+sFiMRcog1OwX8DO0+NxojPiMgo0UAD6j8wVAlUkElKirohJ
 mhxOkRpDqyS5DM01tNbVmWhFgwdVh2U/kv9lwkAmGHDFhT6U2XMKCs2OPqX/VBf+GVZJ2AJ8
 LadwWfjcDDrYMCugXdiBR8786TuHY5r6wnPuMG7BMDUTZA1bA3sjrKqeWdV+QDsBtk8hRGfq
 ORnlAqqhXYX6cLET3UHNrSn
IronPort-HdrOrdr: A9a23:o8WnBK5lAw7bFDJzaAPXwSyBI+orL9Y04lQ7vn2ZFiY7TiXIra
 yTdaoguCMc6AxxZJkh8erwX5VoZUmsj6KdgLNhRotKOTOJhILGFvAB0WKP+UyEJ8S6zJ8h6U
 4CSdkBNDSTNykCsS+S2mDReLxBsbr3gZxAx92ut0uFJTsaFJ2IhD0JbDpzfHcGIDWvUvECZe
 ahD4d81nGdUEVSSv7+KmgOXuDFqdGOvJX6YSQeDxpizAWVlzun5JPzDhDdh34lIn5y6IZn1V
 KAvx3y562lvf3+4hjA11XL55ATvNf60NNMCOGFl8BQADTxjQSDYphnRtS5zXoIidDqzGxvvM
 jHoh8mMcg2w3TNflutqR+o4AXk2CZG0Q6V9XaoxV/Y5eDpTjMzDMRMwahDdAHC1kYmtNZglI
 pWwmOwrfNsfF39tRW4w+KNewBhl0Kyr3Znu/UUlWZjXYwXb6IUhZAD/XlSDIwLEEvBmc8a+d
 FVfYHhDcttABCnhyizhBgs/DXsZAV+Iv6+eDlChiTPuAIm2UyQzCMjtbsidzk7hdYAoqJ/lp
 f525JT5cVzp/8tHNJA7dg6MLmK40z2MFvx2TGpUBza/J9uAQO5l3ew2sRz2N2X
X-IronPort-AV: E=Sophos;i="5.87,184,1631592000"; 
   d="scan'208";a="58003630"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=I07bkqjXEm9UWCAdGxzYGsLWs/8Pxd4/8S7hvFyv1O90loaCpLnJjPUKViTu4r3S115YWMSFyQrOoDm7ep6YeH4lwxct97ktGWQzsmVYKYIMTVU1SD6sjsE33DeuxfZCkd8wD1mzl9UFiZdABG4AS83YbZFlc9wGLGk/2H7HP5mc8RFqrFehWbEeakqyA1ajNU3oOn+kXNm6lUUCFu9nk2Ke1/Uuxmf1XC+sncIRqNhhqSCDz/1PPoXB7+10VzPadOzxjfc8B9FFpTpQtC4jnjUPs4xe0MW4EPFI7DvgPnuZb0DcW1ZzmB64Mk48pt/87y1FluivLMkH78O5e7TPcA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=9EQ6jAIADUx+fOskjNBtbeFd2h9AWqCawEeH5Zn4EMc=;
 b=ZKru4ZVg0fnq1tmqy8L088nQaPIEyJMZlFLxPO/LAxSepDcJPFclCzFx1lZbAsRfm0cN7G/Kvjy9n3zLsKmX2QYHmlInd5jWGIZogJHFWUroX1PxKQeY2L2s763nHwXJ9thp3DxzcTEyIC/bSQJVFy7rbjjdR74Gs5PLAT6GFcmSVu/i1dQy8KpfXSx9z3qCgHjoLHe6OCv7gQ38N92hI4E79L3Dl7PlVBEVruOYjkwqQmGjmn3mLyg+45yucMHJROhdnekw01rG/OEg8iHTR7mkmjlAqmt74+RqvTuOnGRgct+9OmYVh52xCUDaX9ExliGERyII597Z6OxTEJW+vw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=9EQ6jAIADUx+fOskjNBtbeFd2h9AWqCawEeH5Zn4EMc=;
 b=ZJxNjVbYy4wE4Bn8m7MgSQLzCUxTJkYOOHSiMTSFiGe3W2HCrEyzFdDqLVR6wEH5B2T+LF7hWx5YfPM0qnaL2RlL4s/SJAzUbR9kutntXQwLGCtVVQ7fkXvXZy70rCiOo+zcSKBaEvb3uEbMCW4jCzBRAivEG2AjnMCFh8TH3iE=
Date: Tue, 26 Oct 2021 15:30:13 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Oleksandr Andrushchenko <andr2000@gmail.com>
CC: <xen-devel@lists.xenproject.org>, <julien@xen.org>,
	<sstabellini@kernel.org>, <oleksandr_tyshchenko@epam.com>,
	<volodymyr_babchuk@epam.com>, <Artem_Mygaiev@epam.com>, <jbeulich@suse.com>,
	<bertrand.marquis@arm.com>, <rahul.singh@arm.com>, Oleksandr Andrushchenko
	<oleksandr_andrushchenko@epam.com>
Subject: Re: [PATCH v3 11/11] xen/arm: Translate virtual PCI bus topology for
 guests
Message-ID: <YXgC5QB2MDZlZeEZ@MacBook-Air-de-Roger.local>
References: <20210930075223.860329-1-andr2000@gmail.com>
 <20210930075223.860329-12-andr2000@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20210930075223.860329-12-andr2000@gmail.com>
X-ClientProxiedBy: MR2P264CA0086.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:500:32::26) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 06343ca5-e1ad-4086-5044-08d99884c0dc
X-MS-TrafficTypeDiagnostic: DM5PR03MB2777:
X-Microsoft-Antispam-PRVS: <DM5PR03MB27770C0986C848F9C137AEBF8F849@DM5PR03MB2777.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: sMqO1b3sP6d1sxpkynBwPS0+nUeB58w8iptdbj8Ti2DeoEKpDpTOsBdCz5jCvc+IoXElMngI4ovIkSIfAVxF7tVu0FJpWo5a2nt/TCUXPeFbUU2AqFpVDt4skbfTDyiWO6lAvrb4Myejeg/oJ4Cok2HKeP+iZ1I09FTWShdPO8QP5kxWzDHiRBa6db4m4jL986+0/2attLX1DHRULZsec/px8o32CpmWcI2ZwRuWA5awrk5+AAEEfSMe6cLBJFsVWYQZewPjeqQ+UUwS+1JDX30QnzOtv+/Of5dmI/6Tq43LA/Dyofg6l5hqKuYJNu6Fo2fJ7aHJGm8k8mtg8uzT5HF2G07CIYZ/alPODOHeQVc860urTcMTq7++T7+ynAzsLEADjHNW+Q3L6F4ImzVJF4W1kj1SprTIP3mzgte69iByrd28CcEdF1hvKngnrew02UBFmb1WqjnDcIIAzGmFZmg8sQaJgPXifNF/gLv7p4UxFNCkcswf0F3zgtDgQDkC/X5GPO0zemBc4lh9QWclsr9gHrKsQwshePu1WKLMQSDJGbREb2y3wS6LId02yZrNK3qo4YV5fBJDaeCMNQfkbZYFdVpD51ZX2Bx+RPopVpXoC0AJ4KP6SdXrZkmSWER63C9awAbtu8I+6UfvV084VQ==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(8676002)(6486002)(9686003)(82960400001)(956004)(66556008)(66946007)(66476007)(5660300002)(4326008)(26005)(38100700002)(6666004)(8936002)(508600001)(316002)(2906002)(6916009)(7416002)(6496006)(85182001)(83380400001)(186003)(86362001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bmJMbkdZZ1ZBamlBVUNTQ0I1UUNDejl1RUlOUWNnRU5EKzVUMVIzbDkzOVBx?=
 =?utf-8?B?d3FzQVczWnNOZndBR1VBWmNtbzd5V3dIdTJ3V3dzRjY1d3ZlYWFLWWRWblFp?=
 =?utf-8?B?V1JZZVNmUEV1NE5TcTl1aVdxUDY5eW9OWm5WaURjSUg0ckdMeUZlYkZNS0J1?=
 =?utf-8?B?ZGVXNHQ3T2p5U09kYWV1aUxlcTVjSFc5VENDaisvL3R0Qjg5ZkpKbnRaTzdO?=
 =?utf-8?B?UlNHNXk1UVdXUmFWRk1zUks1eDZXa2JDVitkUzNta2taN3NpRlRlNHdKbVIw?=
 =?utf-8?B?aDFqdlZmcjdNY0V1SXVmTDhZb1RyQmNIc2h0cE9QU3ZTQ0NXRTMweXY0ek1P?=
 =?utf-8?B?TlhQbkNQTmpGUXBCcFMzSHJYbDBIOU1BYm00TjFVYy9XMHR6dTZQNnFzVHFh?=
 =?utf-8?B?SnlpREc0TDMyQTFrOVkzVE9lZm1EdXhTRkNrSUNrbERTV1k0bzNCMkR6bjQ1?=
 =?utf-8?B?cU4xNDg3RXdtOGR4VGN6ZXZINEVaR1U4NlRuc3NtNFBFcURCcVBWL3d1S2ZL?=
 =?utf-8?B?eVovTy9qZ210VUF6U2JKSDZrUEpDbUFQQUR3NzAyc081NG1DVVJ5anI0UDZo?=
 =?utf-8?B?YkN2MlVITUxsNWgySlB2dGdCd210TGsreXpJK1AyOXFGcWRsNHJUemhjVzl6?=
 =?utf-8?B?VTJxc05YSnVsbHExZlFobTZUd2dJb2hwNW9Td1RQaVpMWTZNbGcwWkIyL0Iv?=
 =?utf-8?B?emh2WmpVWUlxQTR2MFNDZUd5Q2NCRG9KQ2dtNjdwVnE2Z0hWZWpCMDlZVUhi?=
 =?utf-8?B?T2ZpRHIxUmRSbHY0bFpVUzFvRDRHNUY2NXkvK21nMm0vZkZmM3V4VWFkekxu?=
 =?utf-8?B?dldqZlV6OC9oTlBESk9HYzFoSVRJZkhXVUxseUlJM1RldEsrWUppUUhYNGdr?=
 =?utf-8?B?eHBwSVVCUlRLbU5GcHV0WU45OEtYdnYxMmk5djFWYWE3VG11VkZMUkxqejRr?=
 =?utf-8?B?RHYySjhNeUNmTlZKK0FqNjRxQlZrR1ppcjF5N3JicXpuMzdjMlA2Wk93OS95?=
 =?utf-8?B?OGNLN1hSOFc0c1lRYktwVmZOTDAxeEx0N1RpbE9MdXh1YW85RjA4YlI3ZEZK?=
 =?utf-8?B?VGtTa1dPUmJrc2U2cisxOWVPT0o4VGcxTGdncU15RWY0MFVROUJla0c3WlJm?=
 =?utf-8?B?eFZlV1drcUtkbWZtK2hVS3h1VDY0TjdDSnlVV1lvQ2tlYUtCN25abkpZeTRs?=
 =?utf-8?B?L0hGN1QzbFh2aE5Hb3YvcTJPWXB5b0JCemF5VEplT05MSWRzNXYzL0FvbjQz?=
 =?utf-8?B?V3RvYUEvTHY4Ykt6OW80ZC9BYjVsOTV2b2g4VDk1N1UxWHNQMHZJdm9IdXZw?=
 =?utf-8?B?encxTHhERWlBWmtnczRPUDdLSkZWU2JCdmNrN2RsRUZXMzdKTUhCMi9sb20y?=
 =?utf-8?B?cEhpb21yRGhxSGlTSHhMUWtoNjc3VFA5ZnptbVBmdCtxeUFhR0xjcXhiWlpN?=
 =?utf-8?B?bmdYNzVwQ0VjQkx1ZG56aHVmVHlJM0hNNkFpc2F4bkp2VUpPb2xxaEtYbldS?=
 =?utf-8?B?YUpPcUJmeE1IQjVjMkFlQmswMlg3S0lLNzlhMlpMRjR6SFJmUUdzbVFGSm9z?=
 =?utf-8?B?SStYUU45S3JoQWNtT0RKeklIeE9hQ0RWT1JNREh4ZWlUVGo4SnZtTG5SN0ll?=
 =?utf-8?B?UmwyT2xCZHI4TStaYzI0VkZQOFhVMHdTT2VpVkRLVUFaS0c3OHpLRjlKQjVQ?=
 =?utf-8?B?RDlGVTloRWdHUTY0QlFpd0JDNS9MdXcrMGJXV2dpYkpVVDhLK0NzdnNGaU43?=
 =?utf-8?B?S2JENmxsV3RscGhab3pmR1N2VjdRWlFxdDE5ZjNYMnZ4U1dhRDZBMXZ5SDRU?=
 =?utf-8?B?NjNMMjNZZERTam8wZE9YamFzL0UxTHFvYnp5MkFkY1RmTU1Vcm5xTDRwVmdy?=
 =?utf-8?B?R0VYdmxUK0VjOGFNMzdWOWpmRXpOWFFjYkZHN2N0RHZ6SFM3blZvT2NaVWpn?=
 =?utf-8?B?M05oM1d3Zk1HVGdQcUNMWUM2WFZQUkh0aTNIOXJqT2daNnVWYUxEdHhXVW1u?=
 =?utf-8?B?Ri9CeTgxZ2hCNW5TV0dnSUNKamY3ck9xUlc5R1F3elc4SzdGekwxbXFzUDNG?=
 =?utf-8?B?aFdXemFxb1ZkWnZDMGFiREJoQ2ZZMitnWDlmMmhwNFg2SmVSRG53Uk5YaURR?=
 =?utf-8?B?UTBDQTZXVlBycFVQZGZnUGw3eHArS3VGV3JhS3MwVFZJemZMaGEybmE5ajE1?=
 =?utf-8?Q?QTkV9k3YKiYRkI86UMw/EHw=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 06343ca5-e1ad-4086-5044-08d99884c0dc
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2021 13:30:19.0186
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: v8nSSveaZmWMc06zpB4oSCafWlWl9ODOMebiC4Tffe4zdbZPfSVemN5xEv4Zp6CxhW2PRqrek78q1Udt9ZcwKw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB2777
X-OriginatorOrg: citrix.com

On Thu, Sep 30, 2021 at 10:52:23AM +0300, Oleksandr Andrushchenko wrote:
> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> 
> There are three  originators for the PCI configuration space access:
> 1. The domain that owns physical host bridge: MMIO handlers are
> there so we can update vPCI register handlers with the values
> written by the hardware domain, e.g. physical view of the registers
> vs guest's view on the configuration space.
> 2. Guest access to the passed through PCI devices: we need to properly
> map virtual bus topology to the physical one, e.g. pass the configuration
> space access to the corresponding physical devices.
> 3. Emulated host PCI bridge access. It doesn't exist in the physical
> topology, e.g. it can't be mapped to some physical host bridge.
> So, all access to the host bridge itself needs to be trapped and
> emulated.

I'm slightly confused by the fact that you seem to allow unprivileged
guests to use vPCI in this commit, yet there's still a concerning bit
that AFAICT has not been changed by the series.

vpci_{read,write} will passthough any access not explicitly handled by
vPCI (see the usage of vpci_{read,write}_hw). This is fine for the
hardware domain, but needs inverting for unprivileged guests: any
access not explicitly handled by vPCI needs to be dropped.

> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> 
> ---
> Since v2:
>  - pass struct domain instead of struct vcpu
>  - constify arguments where possible
>  - gate relevant code with CONFIG_HAS_VPCI_GUEST_SUPPORT
> New in v2
> ---
>  xen/arch/arm/domain.c         |  1 +
>  xen/arch/arm/vpci.c           | 86 +++++++++++++++++++++++++++++++----
>  xen/arch/arm/vpci.h           |  3 ++
>  xen/drivers/passthrough/pci.c | 25 ++++++++++
>  xen/include/asm-arm/pci.h     |  1 +
>  xen/include/xen/pci.h         |  1 +
>  xen/include/xen/sched.h       |  2 +
>  7 files changed, 111 insertions(+), 8 deletions(-)
> 
> diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
> index fa6fcc5e467c..095671742ad8 100644
> --- a/xen/arch/arm/domain.c
> +++ b/xen/arch/arm/domain.c
> @@ -797,6 +797,7 @@ void arch_domain_destroy(struct domain *d)
>                         get_order_from_bytes(d->arch.efi_acpi_len));
>  #endif
>      domain_io_free(d);
> +    domain_vpci_free(d);

It's a nit, but I think from a logical PoV this should be inverted?
You first free the handlers and then the IO infrastructure.

>  }
>  
>  void arch_domain_shutdown(struct domain *d)
> diff --git a/xen/arch/arm/vpci.c b/xen/arch/arm/vpci.c
> index 5d6c29c8dcd9..26ec2fa7cf2d 100644
> --- a/xen/arch/arm/vpci.c
> +++ b/xen/arch/arm/vpci.c
> @@ -17,6 +17,14 @@
>  
>  #define REGISTER_OFFSET(addr)  ( (addr) & 0x00000fff)
>  
> +struct vpci_mmio_priv {
> +    /*
> +     * Set to true if the MMIO handlers were set up for the emulated
> +     * ECAM host PCI bridge.
> +     */
> +    bool is_virt_ecam;
> +};

Is this strictly required? It feels a bit odd to have a structure to
store and single boolean.

I think you could replace it's usage with is_hardware_domain.

> +
>  /* Do some sanity checks. */
>  static bool vpci_mmio_access_allowed(unsigned int reg, unsigned int len)
>  {
> @@ -38,6 +46,7 @@ static int vpci_mmio_read(struct vcpu *v, mmio_info_t *info,
>      pci_sbdf_t sbdf;
>      unsigned long data = ~0UL;
>      unsigned int size = 1U << info->dabt.size;
> +    struct vpci_mmio_priv *priv = (struct vpci_mmio_priv *)p;
>  
>      sbdf.sbdf = MMCFG_BDF(info->gpa);
>      reg = REGISTER_OFFSET(info->gpa);
> @@ -45,6 +54,13 @@ static int vpci_mmio_read(struct vcpu *v, mmio_info_t *info,
>      if ( !vpci_mmio_access_allowed(reg, size) )
>          return 0;
>  
> +    /*
> +     * For the passed through devices we need to map their virtual SBDF
> +     * to the physical PCI device being passed through.
> +     */
> +    if ( priv->is_virt_ecam && !pci_translate_virtual_device(v->domain, &sbdf) )
> +            return 1;
> +
>      data = vpci_read(sbdf, reg, min(4u, size));

Given my earlier recommendation to place the virtual sbdf inside
struct vpci, it might make sense to let vpci_read do the translation
itself.

>      if ( size == 8 )
>          data |= (uint64_t)vpci_read(sbdf, reg + 4, 4) << 32;
> @@ -61,6 +77,7 @@ static int vpci_mmio_write(struct vcpu *v, mmio_info_t *info,
>      pci_sbdf_t sbdf;
>      unsigned long data = r;
>      unsigned int size = 1U << info->dabt.size;
> +    struct vpci_mmio_priv *priv = (struct vpci_mmio_priv *)p;
>  
>      sbdf.sbdf = MMCFG_BDF(info->gpa);
>      reg = REGISTER_OFFSET(info->gpa);
> @@ -68,6 +85,13 @@ static int vpci_mmio_write(struct vcpu *v, mmio_info_t *info,
>      if ( !vpci_mmio_access_allowed(reg, size) )
>          return 0;
>  
> +    /*
> +     * For the passed through devices we need to map their virtual SBDF
> +     * to the physical PCI device being passed through.
> +     */
> +    if ( priv->is_virt_ecam && !pci_translate_virtual_device(v->domain, &sbdf) )
> +            return 1;
> +
>      vpci_write(sbdf, reg, min(4u, size), data);
>      if ( size == 8 )
>          vpci_write(sbdf, reg + 4, 4, data >> 32);
> @@ -80,13 +104,48 @@ static const struct mmio_handler_ops vpci_mmio_handler = {
>      .write = vpci_mmio_write,
>  };
>  
> +/*
> + * There are three  originators for the PCI configuration space access:
> + * 1. The domain that owns physical host bridge: MMIO handlers are
> + *    there so we can update vPCI register handlers with the values
> + *    written by the hardware domain, e.g. physical view of the registers/
> + *    configuration space.
> + * 2. Guest access to the passed through PCI devices: we need to properly
> + *    map virtual bus topology to the physical one, e.g. pass the configuration
> + *    space access to the corresponding physical devices.
> + * 3. Emulated host PCI bridge access. It doesn't exist in the physical
> + *    topology, e.g. it can't be mapped to some physical host bridge.
> + *    So, all access to the host bridge itself needs to be trapped and
> + *    emulated.

I'm not sure 3. is equivalent to the other points. 1. and 2. seem to
be referring to where accesses to the config space are coming from,
while point 3. is referring to a fully emulated device in Xen (one
that doesn't have a backing pci_dev).

I'm also failing to see any fully virtual PCI device being added to
the bus for guest domains so far.

> + */
>  static int vpci_setup_mmio_handler(struct domain *d,
>                                     struct pci_host_bridge *bridge)
>  {
> -    struct pci_config_window *cfg = bridge->cfg;
> +    struct vpci_mmio_priv *priv;
> +
> +    priv = xzalloc(struct vpci_mmio_priv);
> +    if ( !priv )
> +        return -ENOMEM;
> +
> +    priv->is_virt_ecam = !is_hardware_domain(d);
>  
> -    register_mmio_handler(d, &vpci_mmio_handler,
> -                          cfg->phys_addr, cfg->size, NULL);
> +    if ( is_hardware_domain(d) )
> +    {
> +        struct pci_config_window *cfg = bridge->cfg;
> +
> +        bridge->mmio_priv = priv;
> +        register_mmio_handler(d, &vpci_mmio_handler,
> +                              cfg->phys_addr, cfg->size,
> +                              priv);
> +    }
> +    else
> +    {
> +        d->vpci_mmio_priv = priv;
> +        /* Guest domains use what is programmed in their device tree. */
> +        register_mmio_handler(d, &vpci_mmio_handler,
> +                              GUEST_VPCI_ECAM_BASE, GUEST_VPCI_ECAM_SIZE,
> +                              priv);
> +    }
>      return 0;
>  }
>  
> @@ -95,14 +154,25 @@ int domain_vpci_init(struct domain *d)
>      if ( !has_vpci(d) )
>          return 0;
>  
> +    return pci_host_iterate_bridges(d, vpci_setup_mmio_handler);

I think this is wrong for unprivileged domains: you iterate against
host bridges but just setup a single ECAM region from
GUEST_VPCI_ECAM_BASE to GUEST_VPCI_ECAM_SIZE, so you are leaking
multiple allocations of vpci_mmio_priv, and also adding a bunch of
duplicated IO handlers for the same ECAM region.

IMO you should iterate against host bridges only for the hardware
domain case. For the unpriviledged domain case there's no need to
iterate against the list of physical host bridges as you end up
exposing a fully emulated bus which bears no resemblance to the
physical setup.

> +}
> +
> +static int domain_vpci_free_cb(struct domain *d,
> +                               struct pci_host_bridge *bridge)
> +{
>      if ( is_hardware_domain(d) )
> -        return pci_host_iterate_bridges(d, vpci_setup_mmio_handler);
> +        XFREE(bridge->mmio_priv);
> +    else
> +        XFREE(d->vpci_mmio_priv);
> +    return 0;
> +}
>  
> -    /* Guest domains use what is programmed in their device tree. */
> -    register_mmio_handler(d, &vpci_mmio_handler,
> -                          GUEST_VPCI_ECAM_BASE, GUEST_VPCI_ECAM_SIZE, NULL);
> +void domain_vpci_free(struct domain *d)
> +{
> +    if ( !has_vpci(d) )
> +        return;
>  
> -    return 0;
> +    pci_host_iterate_bridges(d, domain_vpci_free_cb);

Why do we need to iterate the host bridges for unprivileged domains?
AFAICT it just causes duplicated calls to XFREE(d->vpci_mmio_priv). I
would expect something like:

static int bridge_free_cb(struct domain *d,
                          struct pci_host_bridge *bridge)
{
    ASSERT(is_hardware_domain(d));
    XFREE(bridge->mmio_priv);
    return 0;
}

void domain_vpci_free(struct domain *d)
{
    if ( !has_vpci(d) )
        return;

    if ( is_hardware_domain(d) )
        pci_host_iterate_bridges(d, bridge_free_cb);
    else
        XFREE(d->vpci_mmio_priv);
}

Albeit I think there's no need for vpci_mmio_priv in the first place.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Tue Oct 26 13:40:41 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Oct 2021 13:40:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.216444.376049 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfMgv-000187-F1; Tue, 26 Oct 2021 13:40:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 216444.376049; Tue, 26 Oct 2021 13:40:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfMgv-000180-Bt; Tue, 26 Oct 2021 13:40:37 +0000
Received: by outflank-mailman (input) for mailman id 216444;
 Tue, 26 Oct 2021 13:40:36 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=d0pl=PO=citrix.com=roger.pau@srs-us1.protection.inumbo.net>)
 id 1mfMgu-00017t-7x
 for xen-devel@lists.xenproject.org; Tue, 26 Oct 2021 13:40:36 +0000
Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 4badec3e-3662-11ec-842f-12813bfff9fa;
 Tue, 26 Oct 2021 13:40:35 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4badec3e-3662-11ec-842f-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1635255635;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=nMxPkiJhXX3eZBZt7xRyIOtdYz/D8U+ti/RFH9K9Ey8=;
  b=CyopV/XuWlTLl4/qtocfBDDat67kh1iWgx1vYqToDGqMgKfh7u1mxoIQ
   TQaaT48EFUundvjyZnroTFy+xl10nN9cXd69/ddOVNE9Yqbjp32yQqj85
   BZDYE2iCHjS1lv33uI4odufCx3B827FmFN5IVBmbg+4Xjo2HENWT1FtvS
   E=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: fex1S8MH68AzbxaCBQ2sJ9283UvenL0NBKVfw8XBYPZPaHGEe7K9W7qpJOaavCuYu/WU69TfSP
 BbtEFiCJyH8TAHqeN0Jlu4TaEIjlLpVrBZIW4kKoNmBTzoh1VndEeD9YAGojXW28/yGj+plKel
 cSwTInFM80sLxFzKq/hsQQx7o4weGMlnYn/y81zuendIRYOjc262yPZRCmR9jSreJ2urG1qM5S
 iyOU9ZyUNJFyNavNnOG8/urouvXCVAdryXZ1gHCuNXf5MtvOCQygo/7pS/dv0dOcjhVQG6fmEQ
 yLdcOtx0Fmsg4rD3i4/0isC+
X-SBRS: 5.1
X-MesageID: 56477036
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:z2NtAK7J9Ff8O3SAMIS5LgxRtLDAchMFZxGqfqrLsTDasY5as4F+v
 mQdWG3UOPfba2P0edx0O4y38R9Xvp6DnIVhGlRkpHo0Hi5G8cbLO4+Ufxz6V8+wwmwvb67FA
 +E2MISowBUcFyeEzvuV3zyIQUBUjclkfJKlYAL/En03FVAMpBsJ00o5wrdh2NAw2rBVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Zz
 81piKL3ZBcVMrzKxdk7EBADEwR1MvgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALNs7kMZlZonh95TrYEewnUdbIRKCiCdpwgWls2Z8WRqi2i
 8wxQgthUj+fWj10Y2gnVLUdkr6sun7xfGgNwL6SjfVuuDWCpOBr65DmN9/Qe8CWSN9OtlaVo
 Hrc+Gb0CQ1cM8aQoRKV/3TpiuLRkCfTXIMJCKb+5vNsmEeUxGEYFFsRT1TTifuzh1O6WtlfA
 1cJ4Sdopq83nGSwVcX0VRC8pH+CvzYfVsBWHul87xuCooLY/gCdD3ALZiNEadcm8sI6WFQXO
 kShxo2zQ2Y16fvMFCzbpuz8QS6O1TY9KncmWBFDYBs578jl/bwVzRuUTvNoH/vg5jHqIg3Yz
 zePpSk4orwci88Xyqm2lWz6byKQSovhFVFtuF2GNo6xxkYgPtT9Pt33gbTOxa8YdN7xc7WXg
 JQTdyFyBsg1BpaRiDfFfuwJGLy4jxpuGGyB2QAxd3XNGjLExpJCQWyyyG0hTKuKGpxdEdMMX
 KM0kVgJjKK/xFPwMcdKj3uZUqzGN5TIG9X/TezzZdFTeJV3fwLv1HgwPhPJjzC0wRl8wPBX1
 XKnnSGEVi5yNEia5GDuG7d1PUEDn3hWKZzvqWDTkE38jOv2iI+9QrYZKlqeBt3VH4vfyDg5B
 +13bpPQoz0GCbWWSnCOreY7cABbRVBmVMueg5EGKYa+zv9ORThJ5wn5muh6JeSIXs19y4/1w
 51KchUIlAam3iaXd17ih7IKQOqHYKuTZEkTZEQEFV2px2IiccCo6qIefIEwZr4p6Kpoyvscc
 hXPU5zo7i1nRmuV9jIDQ4P6qYA+Jh2niRjXZ3iuYSQlfo4mTAvMo4e2cgzq/SgILyy2qcph/
 OHwilKFGcIOF1Z4EcLbSPOz1Fft73ITr/1/AhnTKd5JdUSyrIUzc37tjuU6Kt0nIAnYwmfIz
 B6fBBoV/LGfo4I8/NTTq7qDqoOlT7l3EkZARjGJ5reqLyjKuGGkxNYYAuqPeDncUkLy+bmjO
 roJn62tbqVfkQ8T4YRmErttwaYv3PfVpudXnlZ+AXHGT1W3Ebc8cHOI6tZC6/9WzbhDtAroB
 k/WootGOa+EMd/OGUIKIFZ3dfyK0PwZl2WA7fkxJ0mmtiZ78KDeDBdXNhiIzidcMKF0IMUux
 uJ44Jwa7Am2ixwLNNeaj38LqzTQfyJYC6h35IsHBILLixYwzgAQaJPRPSb6/ZWTZogeKUItO
 DKV2PLPirk0KpAuqJbv+awhBdZguKk=
IronPort-HdrOrdr: A9a23:YLPcSaGZTbxGO745pLqFcpHXdLJyesId70hD6qkvc3Nom52j+/
 xGws536faVslcssHFJo6HmBEClewKnyXcT2/htAV7CZnichILMFu9fBOTZsl/d8kHFh4tgPO
 JbAtRD4b7LfClHZKTBkXCF+r8bqbHtmsDY5pav854ud3ATV0gJ1XYGNu/xKDwReOApP+tcKH
 LKjfA32AZINE5nJPiTNz0gZazuttfLnJXpbVovAAMm0hCHiXeN5KThGxaV8x8CW3cXqI1SvV
 Ttokjc3OGOovu7whjT2yv66IlXosLozp9mCNaXgsYYBz3wgkKDZZhnWZeFoDcpydvfpWoCoZ
 3pmVMNLs5z43TeciWcpgbs4RDp1HIU53rr2Taj8DLeiP28YAh/J9tKhIpffBecwVEnpstA3K
 VC2H/cn4ZLDDvb9R6NpuTgZlVPrA6ZsHAimekcgzh0So0FcoJcqoQZ4Qd8DIoAJiTn84oqed
 MeQv003MwmMm9yUkqp/FWGmLeXLzEO91a9Mwc/U/WuonhrdCsT9Tpd+CQd9k1wgq7VBaM0oN
 gsCZ4Y5o2mePVmGp6VNN1xMvdfNVa9NC4kEFjiaWgPR5t3cE4klfbMkcEIDaeRCdo18Kc=
X-IronPort-AV: E=Sophos;i="5.87,184,1631592000"; 
   d="scan'208";a="56477036"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Ob3DrVv+b9Oe76vmESdgIARPUPoxhmWPaLN/5K3sjBjMnJv/yPrViwneB97JD7nYQbzYLIhVn6nbs8rYMXDyrHDkz+XrofYHxy+KtuBKBkOhiBwYHfaa0dmzLv5v6RyoRDDDgXF0DbVYXxoDaTjrbkpDw3xK4qzXJW7asUBmNBYB1C3HVdvOzSUYROnLuq7fahBh18eF5ARTljNh80Nfl+a0rCBXYT7B7dAJBy3wgUG0OSc8WPFEBPb/YCyJV2KAC9OGw4F7RKku5JnIJH+FthQ+KJZemo5M1LCvc4twThd29UPTR9POT/JEuPxACeDrUWydFwwPMS0xvCYLVtAZRw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=tjYSvRpet7gm6YxK64R7Al/jcQCA4Ww53OXbvsIJD98=;
 b=DbEA9BSY7gZoikFDEYZbQrH+Aa3qpWeND0oOHF75Z4zz/HciZ83qRimK1LU2RQAuDILrtYOGo+1XTA4qpESp0vGxm9bGa0TmiGLAYsuLOEtqabYkISyhQwDUws1s9CDOaze7ne8mXhN8kV2fmslQlmcTSJkln5CiQBk42uCd1Sd7wfmUnn40Y/L/jOeOkPaK2XnST2wqlStI7OWgaBlj6a+zN9FDGV0yZMsNo/VZaxMIJgafLQOdlE/hOp2GJwRFhktvpcw1ODZfo/cuEO2V+JJJY4u/xTvyqeRgDtk5QK3Xwi6BPgFoJHizBtXf/TKPacLKJZ9BdRvhF+T9JlyzIQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=tjYSvRpet7gm6YxK64R7Al/jcQCA4Ww53OXbvsIJD98=;
 b=JwBFhIuUWsyjzwI4ZmvStNhwxgedap9K9jx1et47EdjgMpCMCLZZnMFjN+TdSNBNCr4UCHE8X5SlbS+oNVVyuVR8lRUFBY4QZBh7/BP/wVawISuRBetRdaOALMsCI0+K5Wz0uJ+U62R2shrN4vRFut24CooNG3TgwMmRaBEgHGM=
Date: Tue, 26 Oct 2021 15:40:26 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Stefano Stabellini <sstabellini@kernel.org>
CC: <George.Dunlap@citrix.com>, <dunlapg@umich.edu>, <jbeulich@suse.com>,
	<committers@xenproject.org>, <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v2] governance: communication channels
Message-ID: <YXgFSgHhhEpXsvpQ@MacBook-Air-de-Roger.local>
References: <alpine.DEB.2.21.2110251845500.4586@sstabellini-ThinkPad-T480s>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <alpine.DEB.2.21.2110251845500.4586@sstabellini-ThinkPad-T480s>
X-ClientProxiedBy: MRXP264CA0028.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:500:14::16) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: f78e8702-9b0b-4b8b-6165-08d998862e4f
X-MS-TrafficTypeDiagnostic: DM6PR03MB5065:
X-Microsoft-Antispam-PRVS: <DM6PR03MB5065A5F8FE809FE2FBBF6F4B8F849@DM6PR03MB5065.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:1751;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: yWXOAcJbi0ioA7KAjqhe9+oFBXqX84mPc8KjcOzngaTJk/MfyLabJBHwWipd/dinrF6f1Dg6MAvcw6wg/U6XK7twiByfhKgffwZ7WgqvyLljRPR/HDXEuyUac1dOEjlSeYqkRq9iHwbJE/7pPhQ5rvCiUfK5DGgruuZKDQ8bbCIc8iOFTvgqaM7/y6UgUhUsCpt/l3bNVhY4MpZSVIrx9LljH2dpyCkeUQ71TFaRbVWX32KfBSMhzm7VmjrTqDSVC83yJ9az+CoLG9gUaVx3x3NNu9jgZ8EposMl6ZIwZSrjQHSHZN23pdTChk9Yrm8KJnibeWDHHIF98sYzqQrj6xwz4ObtWIrRSxJRjuj28j43wBQn2K13HYz363u92UveCl22D/+B19Gn1w0oVoQfsTK3+vwkV4iURe21iQwBliidtYS/5D7q/OGlr0XHZnkmrw29UNP5Ldowy6QCBBWLxg4DbEWK3bG/PgEIrCDryMdfFjAc0ZCMcroMjxooUiLHXluXYIa/Roz/71+qRIZhgJjW6new7g38Z+C1xHsJk3n4eS3W04E2IkN+dkZ9janzyNoOpZT+dG9xF43V7acgA8vV+Iz76GvrrdNUMQti502lL7WOKaLtxnmks5KAIdWjUIGcrNKqrIfR+SgN9eOiYA==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(26005)(85182001)(6916009)(38100700002)(6666004)(8676002)(6496006)(6486002)(558084003)(508600001)(66476007)(956004)(8936002)(66946007)(5660300002)(316002)(66556008)(9686003)(4326008)(186003)(82960400001)(86362001)(2906002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?LzIyQnJySlRwdXk4aTVEVForVm9XZjlxTW5lZzJzU1RadTFFd2dWTGxXL2RX?=
 =?utf-8?B?WEpLTmJiRXNOclA5ZURKTlFWd0JGTlFsR1pVb0JoSzI0c0VIQlB6dksvY3M5?=
 =?utf-8?B?SC80cGVNMFpjL1FqdEdiWTdKanhEbUE5aGFoOHB6eE1qNFI4T04zWWVhSFhO?=
 =?utf-8?B?bDVoKzh0Y3pOQUVjT0JwZkU1czJxMTRTeElqVEtpbWlVNlhtbDNiV09ycHlI?=
 =?utf-8?B?Mk4vamhtbjdobGZuaEZ0NDh5STlvUkU2dHpqZEJRaU81VFdTVjNmU1RFNklL?=
 =?utf-8?B?MnFZZkZUNC9UN0pSU01iZnE3VnNRSnZzWUhyWWxlRkowQVMyTENXeWJ4Vi85?=
 =?utf-8?B?bkR6MnF0VVBVcTY0YlZ0MlZxK1RiVm1jeDVxNXJnNnBxY2RHNjF0Y3QvWXh3?=
 =?utf-8?B?S1N2LzJ3QWkxM0lCUUJHQUVzV0diS2kzTldaajg3U3hmbjdyWDMySURycEYw?=
 =?utf-8?B?YytnZGczaTMzTS9wWUJhd0ZibkNWTGxiYXVndzBKdko5UGIydlo2aGM2dytQ?=
 =?utf-8?B?NktuRmlLeGVtemVFSHpteTJPaGNZdmRielNaand0VzVWYkYzSjdNNGNYL0Jt?=
 =?utf-8?B?S2p0ZHBQZkxLbGI4dkRsRWc2MExVVzByZ05tNU8zZFhCWUIzOEZ5d3orTFYv?=
 =?utf-8?B?WlI2RlBBR2RCWG1UUTk5YkNPMGtyZlNNZ0I4cC9SLzRxOVU2bitNYXZPNVg0?=
 =?utf-8?B?eEpEeGhaaDBkMlkyRFRCeU1jdnJ2ekFBN1Y2VHRTOUlPZGJsaWZhbmlYeWRL?=
 =?utf-8?B?SC9xQWpMbVFGVDJJOVh6aVUxSGZaZDJMUU9naHJUNnFoMmJaNUQwNzAxU0U0?=
 =?utf-8?B?TW9SRVkvQkl4Q0VvRkVQd0taZitGVjA1Ykc3UW9yMHFyWWxGdlMzZ205MVpw?=
 =?utf-8?B?RTRnNDFLbms3bkN3SUlUSmVzbCtpWWlhQlRXRisyR1FTcUNxWmIrRG9XSVlI?=
 =?utf-8?B?TnU5QkxtWWNuMVVnWG8rQ0FobUpUdWRGYXl6dkpsTUNFOG5pdUxQcnBpcDYr?=
 =?utf-8?B?ZjdXSXQ0UDB3M2Zock9lSHpEelU5MTIxaHFLSkFiZ0NJM3d5RFlXNFB3NlMr?=
 =?utf-8?B?S1dIWDZvbDAvVnNxcUhMQ09UM25YSzMzUGRBTkU0ZVZ2dUpXMzZYWW4wV1pU?=
 =?utf-8?B?MmEyYlpPR2xiKzBxRHVhM2lKdnZaalQvRVY4ZjMxR1hTTGNvd1FlYmRJczFu?=
 =?utf-8?B?ekpNdnRLQnFmUjNURUdmeFZpdTNSV3VJRVlFWDZmVitRbk5rSWJuMGNJdGtV?=
 =?utf-8?B?ZzQ1ckpoeFltK3FydE1HWGFDL1BKWVRoY1BKMUMrdlk0ejFxcnRhUzd0dERp?=
 =?utf-8?B?UnZxeE1jUndraEF4YkhBcjRUcFpBU1orSFZwTGRZaDk4c0xsRDdvcVVvMzFq?=
 =?utf-8?B?YVhtWVdHbDRrQkR6aDVUaW1JY0F3OUpVQkhYY3psTFM0Y1hqNXpiYmR1TjlF?=
 =?utf-8?B?dEJDa1E0bW4vd3R6N3V3QWZWcjV6bVNyRGVjbWlaYk1QNm0wL1lpT1RibkdU?=
 =?utf-8?B?MFoveFNTZlhRRHdqTzBsSWxBY0J1bHNSY2lFS2VhOCtaL3B5S0RnK0dyRTNz?=
 =?utf-8?B?bkFJSG5CTkdYMlBLMHFwa3lFRWwzSmsvSXBGdDFlYW5VZXpVQXdoQ0hydDNI?=
 =?utf-8?B?NDUrL0xSVDZBaGNGcUllTDd2V01VY0ExNGE1SGErbUNqT2RYQmprSE5nb3ow?=
 =?utf-8?B?UEE1d3dVMzJYNC9ReElEOS9RNVNiNnNFNEFLbzBJTmZzcVp2dkhWeGs1UGZh?=
 =?utf-8?B?bXl6K0I0U3UyYUROTHZVaWtzYXZPZUZ4c01wY0pBTmFNSHRETGkwZmtMek5H?=
 =?utf-8?B?N1NqUnpmWjNpblJWZXpPcllVaWs5YnpTRGFpTmVxNWw5OU9lT2Y0MHJYVTNH?=
 =?utf-8?B?aTUzVGx4V0tXSDRrZU0vRmIwOEpXbWYzbXlZRGZLUEpZZ0Z6TkMwZGRHVmZ1?=
 =?utf-8?B?MHY2enNSVW9qcXhNUnMxQWxIeHVCallBSWRTZmhnTTRjUitIVGJ6Nm1IZXVk?=
 =?utf-8?B?SGJvYWpUd0RRWXN4a09hamIwQmRtSTg1bWg2WTRFRHBzd1RlOTlwK2xrQWlX?=
 =?utf-8?B?M3FMREw4d3RvOFM2Uk5Sbmo0TS8zNlN0V2wrRysrbGg5d3FDN0N6eFBMbktQ?=
 =?utf-8?B?bXZWYjd4WEVNNkQ3R1krYkZoVEN2am1oSGtlTFN2TVhQTjFjZnV2anF5bENn?=
 =?utf-8?Q?PqXsgKuhrNixDbQxXJTK9SM=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: f78e8702-9b0b-4b8b-6165-08d998862e4f
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2021 13:40:32.1879
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: pDmf15L8lwauD1a71B2+RN3kySNdAtymCL3pHTpr3JTea8vc5Khjzk+dFExQgHbspj7kQqwizGjx2d7WW6al9g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB5065
X-OriginatorOrg: citrix.com

On Mon, Oct 25, 2021 at 06:46:45PM -0700, Stefano Stabellini wrote:
> Clarify that xen-devel is the only official communication channel.
> 
> Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>

Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Tue Oct 26 13:56:59 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Oct 2021 13:56:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.216453.376067 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfMwf-0002fc-S2; Tue, 26 Oct 2021 13:56:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 216453.376067; Tue, 26 Oct 2021 13:56:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfMwf-0002fV-P0; Tue, 26 Oct 2021 13:56:53 +0000
Received: by outflank-mailman (input) for mailman id 216453;
 Tue, 26 Oct 2021 13:56:53 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=oSYy=PO=suse.com=jgross@srs-us1.protection.inumbo.net>)
 id 1mfMwf-0002fP-3p
 for xen-devel@lists.xenproject.org; Tue, 26 Oct 2021 13:56:53 +0000
Received: from smtp-out2.suse.de (unknown [195.135.220.29])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 91e8f656-3664-11ec-842f-12813bfff9fa;
 Tue, 26 Oct 2021 13:56:52 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 14CD31FCA3;
 Tue, 26 Oct 2021 13:56:51 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E78B913B06;
 Tue, 26 Oct 2021 13:56:50 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id t86+NiIJeGFEBgAAMHmgww
 (envelope-from <jgross@suse.com>); Tue, 26 Oct 2021 13:56:50 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 91e8f656-3664-11ec-842f-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1635256611; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:  content-transfer-encoding:content-transfer-encoding;
	bh=H03k2PldCmMg5lMqnhyq49VN6e7pFnyJAuAX5qZZoXg=;
	b=nHhvKuAASQcpxTJy/kZkGvd04FyiLxxPQnQbLZXm5++PoXLystNQ/OYbWhDtnxAVF4UvWo
	WejCB+3ZPrPBy948pycfbRXcPgWh4cHdiilUbQ6lCnO3qGuTBN6X0YCL5/wofV3YSJxz2T
	5Ar5Ujn6fmO4OhvNB718yH7XpfVMQc4=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org
Cc: iwj@xenproject.org,
	Juergen Gross <jgross@suse.com>
Subject: [PATCH] osstest: explicitly set either enable or disable qemu-traditional
Date: Tue, 26 Oct 2021 15:56:45 +0200
Message-Id: <20211026135645.31488-1-jgross@suse.com>
X-Mailer: git-send-email 2.26.2
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Instead of setting "--enable-qemu-traditional" or not, switch to
setting "--enable-qemu-traditional" or "--disable-qemu-traditional".

This avoids a latent bug in the disable case, as the availability
of the option is tested via grep, which will otherwise grep for
nothing.

Reported-by: Ian Jackson <iwj@xenproject.org>
Signed-off-by: Juergen Gross <jgross@suse.com>
---
 ts-xen-build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ts-xen-build b/ts-xen-build
index fdf55521..ccb2aba2 100755
--- a/ts-xen-build
+++ b/ts-xen-build
@@ -144,7 +144,7 @@ END
 sub build () {
     my $xend_opt= $r{enable_xend} =~ m/true/ ? "--enable-xend" : "--disable-xend";
     my $ovmf_opt= $r{enable_ovmf} =~ m/true/ ? "--enable-ovmf" : "--disable-ovmf";
-    my $qemutrad_opt = $r{arch} =~ m/amd64|i386/ ? "--enable-qemu-traditional" : "";
+    my $qemutrad_opt = $r{arch} =~ m/amd64|i386/ ? "--enable-qemu-traditional" : "--disable-qemu-traditional";
 
     my $configure_prefix = $r{cmdprefix_configure} // '';
     my $configure_suffix = $r{cmdsuffix_configure} // '';
-- 
2.26.2



From xen-devel-bounces@lists.xenproject.org Tue Oct 26 13:58:20 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Oct 2021 13:58:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.216458.376078 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfMy4-0003GZ-7n; Tue, 26 Oct 2021 13:58:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 216458.376078; Tue, 26 Oct 2021 13:58:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfMy4-0003GS-4k; Tue, 26 Oct 2021 13:58:20 +0000
Received: by outflank-mailman (input) for mailman id 216458;
 Tue, 26 Oct 2021 13:58:19 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=93O1=PO=epam.com=prvs=093397e908=oleksandr_andrushchenko@srs-us1.protection.inumbo.net>)
 id 1mfMy3-0003GK-4H
 for xen-devel@lists.xenproject.org; Tue, 26 Oct 2021 13:58:19 +0000
Received: from mx0b-0039f301.pphosted.com (unknown [148.163.137.242])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id c564d932-3664-11ec-842f-12813bfff9fa;
 Tue, 26 Oct 2021 13:58:17 +0000 (UTC)
Received: from pps.filterd (m0174682.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 19QDsJR5002585; 
 Tue, 26 Oct 2021 13:58:15 GMT
Received: from eur03-am5-obe.outbound.protection.outlook.com
 (mail-am5eur03lp2055.outbound.protection.outlook.com [104.47.8.55])
 by mx0b-0039f301.pphosted.com with ESMTP id 3bxjy900ha-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Tue, 26 Oct 2021 13:58:15 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by AM0PR03MB4578.eurprd03.prod.outlook.com (2603:10a6:208:c9::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.13; Tue, 26 Oct
 2021 13:57:36 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::c038:e032:595a:651]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::c038:e032:595a:651%9]) with mapi id 15.20.4649.014; Tue, 26 Oct 2021
 13:57:35 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c564d932-3664-11ec-842f-12813bfff9fa
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=a+erBh9SVxS+R0W2VO0m0tzDev03CKDFdMYg2WhIw6t/ZbhBxkUbM6ynwYngx/HAsA+/QLIihoyqqRTQpcyDbj1iNmOYQTctItvtXmhw5ViD/iWzy9bTyRJu+Mnf6cn4l+GEEsih4EFrKRKzQk1j3Ha6p3ugJ3Ru6efE1ALiHzizeaPvsxZjEKC1SOpO9Bh5GPWpFxicrQdAIONwpDDSaWDHMUqNP0f+SiWxDXgeKKUSP3ZzlRn/amCQI21wKqynv/rqUtCUkKof7f17XD0nkGXlG0eC81kJbFRSI+x+4k0MshTSl7oku4x2a8/iSwpnR0gLc6Xr4OUwpww4oGApBA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=zIb7s5kCOSYjtnadfaRWim3gDZNecKxjxc4SqU6Yfb8=;
 b=Ufpqz5Frt9ERLiqw+5xauGog1s+roti170DWZHqzycAYrc4TVJunAYuCzZgZPZiwOpo5N795ht/o4pjDiwByymNvGCQzZlEJX7ZVBsY/JEbEWS10SyZ4sC26USAKQxmZVw78kVYUwvgkBG/aXgln2Gby9uzNzsLbY/ULfPme8Zr1eAxIN6b1VnErR0p59Fe0095armoVZOHkfvl/SsrTjKlFhFE9B8CAcd6I90brtkVR29O+IBMaqFbF8etUaGYxSKSMOOpbXEFy55wCpFd0FqPMlV8+DmZVvpbNodv9k1qwb7bLJfCtokOQ9KcwprMCbB65lx6cKfvAACc6LieFlA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=zIb7s5kCOSYjtnadfaRWim3gDZNecKxjxc4SqU6Yfb8=;
 b=Vd3MWxJ6W0o9jj3+jRTbkkOlm2oJu+AJXX7j1TaSyRSrns5lPZr0GaVWRtCP8bvzUMEyQXantvSUf9oB7Hh6qOuAChuPLK8qAdXHPYnVs7vnuhTE9uXpvCy0jyAdOsi+H+PxC4F4KFT2c8btBZrbnO+bxMIkGxyYuLhAKupYHggZnR4y9zWNq1uTWepOeSNGM2kCBIWpRX4aU8JFHgHeyX62IKmvwbN4Ocq4AIUk3QfA5cBISAcCwSmPcAkX2UQGdpmImvLPFGM0z1xckwMIIRshHyTaBd+KwuLMvRNBvIiMjMkLT8AtCFCDErzH8JI6evzYSLfbYhUr3MvGm0hAlw==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org"
	<sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "jbeulich@suse.com" <jbeulich@suse.com>,
        Bertrand Marquis
	<bertrand.marquis@arm.com>,
        Rahul Singh <rahul.singh@arm.com>,
        Oleksandr
 Andrushchenko <Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH v3 11/11] xen/arm: Translate virtual PCI bus topology for
 guests
Thread-Topic: [PATCH v3 11/11] xen/arm: Translate virtual PCI bus topology for
 guests
Thread-Index: AQHXtdAlBwDHpaYUBUq6q0PlsxoTp6vlb5WAgAAHpYA=
Date: Tue, 26 Oct 2021 13:57:35 +0000
Message-ID: <6ce216ce-d25f-5016-3752-79b90a1112af@epam.com>
References: <20210930075223.860329-1-andr2000@gmail.com>
 <20210930075223.860329-12-andr2000@gmail.com>
 <YXgC5QB2MDZlZeEZ@MacBook-Air-de-Roger.local>
In-Reply-To: <YXgC5QB2MDZlZeEZ@MacBook-Air-de-Roger.local>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: a2c91701-21e4-4b45-2090-08d9988890ae
x-ms-traffictypediagnostic: AM0PR03MB4578:
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <AM0PR03MB4578553CC8319A8B65F5889AE7849@AM0PR03MB4578.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:9508;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 k95kOkoYKwtkiokk50+LdiOXowhXlHaUwEKgT0r/u5lRSdamKtOh4x1gTfRspC1guAyYjsGuhXW0yzoWacM57gl5KooS9XIJU9TpjHWCiwu/K9iiGwUDNnByNwLtIxa0JdixSXDB7Br0mCY3AeI57W5D379osn6RuLtMvYNDvRxxPoRwQrD8xO73fOeOEfpt9s+cP089OrNBdyzk1ya6QCUdJ9Jdjrya6RXS8Ik1TzoK+fWG2RSSlDyEixLSDw+gUx8ld15hBQe2Yts5n53u/CS1bTIz//v8cxfCvpMKx57H5mu67qf+9pTaEGphqJ/hKvvj/DE9477GOzLjUV0hAiJCPBJjjZxj1Yh3dc3VNEFH2eyC6q6bN12OTmGjNf9N4LGWKhplUc5TjAF1Z4+EnKOsaEF+Gv2+cORFp9D98pOri7EkdN9W0f+V5He4tWl95d5exRK5QPIye/doTm6mNOae1Rhs41If64N5x7GzrmxqV4q2BJGNX5SeBPNX6vqm1tVg7IUn3N9+09919/+PRW4fS+fyrMpcGhuztpVTUCrX+XJjMfiOX3kRH2n5w7cbWPxJECbKxfgL9cFJjWqVbaXuMReI0ZXixlaOtcUupYLN0IzkhcfEZ9WKDp7P8lJWQ0s9ZWTf8Hja4kctQTCdJgvgxVg7HDfy3OaD93hFHJiEA5KkvE+KsbyGRZ79XIAvEiOjkcyoEBcGP9Ou/+IywLx0Z/9lLzJl/AgZYX8+Rlbj8Ysvo7B/cmlYZRwld/pzCd6Ld1RWw3m7V8+1T96dU6npNpoI15Cl11QIc4hXN5Q3i64AMMStm4QLku2K/9DzilxiA45X9p7+mRIXBy2ZRg==
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(6486002)(107886003)(2906002)(54906003)(71200400001)(36756003)(6512007)(2616005)(508600001)(8676002)(66556008)(316002)(83380400001)(966005)(26005)(53546011)(4326008)(8936002)(66446008)(31696002)(38070700005)(86362001)(91956017)(31686004)(5660300002)(6916009)(76116006)(66946007)(122000001)(38100700002)(186003)(66476007)(6506007)(64756008)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?MUxrUlJKbFZSVEJEMXB3Yk5zWlB2M1hLL1ZGemI0cjA5U1JaOUMxbVoreURx?=
 =?utf-8?B?S0IrYS9BaXljUnpiTDNhKzNWUlNuN0Fwam01bXErd1ZIMG1pRzRFUWk4TzJW?=
 =?utf-8?B?NldOM3prd3dSOVhtcnE3SGhEblIxTWNud1pxME9JdFpaZWtXamNVMEN0eHQ2?=
 =?utf-8?B?ZzVhME9URFVzNTJzZ0FHMzRTV0luZGhvWWdEbE93UG1KQ3hpZWFXODlrUllx?=
 =?utf-8?B?eXcxdXY5cVRoMkRENGNFZXN1ek96QmI0U01scFR1RER3elptOVFjUkE0YlNW?=
 =?utf-8?B?cGhQQnRaV0JoUk5xRXkrVk1EZ1BrKzgvcjFzMHBudGp0VW9YUWJTUkcxNmZK?=
 =?utf-8?B?SDV3MDQwSVpCU2ozaXpCOGZxVW9DVUwrSXRESUorWnFyRXBMZ0pIUnd0eElu?=
 =?utf-8?B?NjhVTWM0N2o2OVY4Z3gxQ2VKMXV0Myt4dXdsSWRPVzRKR1VzUFVaUGYyM3Y4?=
 =?utf-8?B?Q2JUWlJXMm9zLzBtVkcvdDhRQXlKbEY1Y0FTRmFMaXdsSWRrY3J2M1NYZ2dF?=
 =?utf-8?B?MGtwU2Zmdi9YMkdtVEEweEpSTCt0VnJMZVVnZFpFeEF2NCs5TUpkOVZxeSt2?=
 =?utf-8?B?Vm1JN2J5NFF3ZjVmWXJkZDRwd0Q1T0VUbHNTVEVpTktkald3RFgxQUtsWCtY?=
 =?utf-8?B?ZUlTdUVVU053ajFVb3FDZFZhblkvcloxbHo1WE52M3RsNkkzQzhWS29FbFoz?=
 =?utf-8?B?TXpmTTN4UXYrSkpkMWh1TncrYytCMWo5cEtFTlFLQ2pRMFBGcHNhR21xbklJ?=
 =?utf-8?B?bzBNNDFiQVA3M3RHQ2VKQis1dWd2c2U1c0t3aGU4UHVTS0o0SlNRNy9LdVNr?=
 =?utf-8?B?VTNsMHlzUFB1YmViWXBBTS85clIvamU3bHZwMGk1UWYzRG4rQzlrSTVkMnNv?=
 =?utf-8?B?UTRJWmYvdU9hZElTbXdtUWQyU1d1blpmRWIyUkEycVZlVUhOODZUT2QrQjlr?=
 =?utf-8?B?ZmZOUUJvdkRhWlc1M1hxTHYxRjZxZkJkelMxTG9qNlBYa2NYRUZMZVNKbEF4?=
 =?utf-8?B?N2RhcFV0UWV6aHIreHpzaHV3V0owT2QvTmRWbFZzNXRQWGI1ejBQa2tKa2JZ?=
 =?utf-8?B?SnhOa0RSdFFLNVFpSkZlZGJEcW5yblovYXQwVGVzYzZvWVpGMkJCQ3g3RDhL?=
 =?utf-8?B?aWpzbG8xMnVjMk5aM3FHU2Iwb3dxZXQ1aVB2UDh6RW82bVY4aDN2TGI4NzNv?=
 =?utf-8?B?YTBsbG1Pb0ZGbDZIVzJKWVg0VGY2L0J0OCsyOVhLR0ZMUFpqVkdRL2U3NUZ5?=
 =?utf-8?B?VjZlekxCL1IxNitoK2IvYSs5SXZwUGtDRS92TEQ2bFdGalQ5MnUybmRVUXlk?=
 =?utf-8?B?NkxvOUZGblI5N0xvSW1vajZSdDhwNFVBMk1MZzdGMGZvaVlWTWQ2Q1JoTm5r?=
 =?utf-8?B?WmgyelVZemgwMkJmWkdUZXl2cDkzVy9ORFE3R0UrK014MHpqb2RmTHJLclAz?=
 =?utf-8?B?M3RnVHdQWUJQbWllV2VHekI2TDNJeWtxdkNsRVgvQ2RBeXRsTkpuVm91WlJx?=
 =?utf-8?B?YmFENkI5ODFGSTdsRzlkTUFFeXltbmpSYjJzMnllT3ZUMFE0YnZJaG5tanlI?=
 =?utf-8?B?NldIdjZScjBEelB5ZzJ2K0xKQ3p4Z1dWYkM5TFlGTUhTbHlpT2ZCbXE0RlZZ?=
 =?utf-8?B?eHRSQzZialdERmllQkVvZWx0citmdU0vSStzdkp4SUtzaUdCOXdRSngwVlBu?=
 =?utf-8?B?azlSWStiMmxxb2lNcitkY1lnTUFNMTRtcmVIcmZvTmt2TWwzSDlsSEM2YTlE?=
 =?utf-8?B?NEN1WHJvejVjQ0E4RENmZy9uZlVkNUx3SE45ZDMrRlVUeGUrTDcyeWRZQkMz?=
 =?utf-8?B?UHYyT1p1MDRuL0xvMWZReDhsM21tcnhmWTRvSmFJRXVBVXZHWXlaNGo1OXMy?=
 =?utf-8?B?eW9lVkk3MUIzVnJzbEkyV0NrWUJpUlpSR3NyWXVTanlSVkgyZ1pZY0FhZXlP?=
 =?utf-8?B?TmE4NXZVaEVKU1lKSEV6TXRCU2l5bTJEaGNRbzVWN05oSFlDQTAyeXZqU0dn?=
 =?utf-8?B?TnpYUHNadnVTeTVJNTcwZVZqVkt6V1VwdGphRm1PUGFjNXdySm1pVGpia2V1?=
 =?utf-8?B?c3laUjlwZ1R6Q015R010VjFLTElRUDg0SU9wWFRyemNKYy83VVdET0t1YUds?=
 =?utf-8?B?V2Jha2cydTI1VGNGSysrRm92Q2Z4dWd0WGlPM2lhalZUL3p1cUVnaSttb2VH?=
 =?utf-8?B?ZmZJVjZ2N1UwU2NiRmN5WjJ4dHdZeUg1bG5TMHBqbUNYWHo2SmVadGc2NC9w?=
 =?utf-8?B?Rko1Z0xaRjI0MHNBMy8yR0k0bDNzcElra09pWVZmM3B6SXNUOVgxdVhYWGY4?=
 =?utf-8?B?b1RDTzhlRzIyRmJOR0N4MmlaQjJJcWxRRkUwUnVURjQwWWs1N0k0UT09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <13294A9FFBEB5342A4E9A3B64211B394@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a2c91701-21e4-4b45-2090-08d9988890ae
X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Oct 2021 13:57:35.8536
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: TmPyj8Fit9v1P6lBXSmgP92ZcwWnqu5v13HP1AyHy34mtGpCKahTVswp/76Dfvu5EdvyGQkb8Uk47kotB53m7VLZor3j7uZLQLs0Hw5OnnAlfQuozVi3FTVTbHrFaA9T
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR03MB4578
X-Proofpoint-GUID: 3HBXLBYmg9d-AYtM2bGv6zZZabRw2C87
X-Proofpoint-ORIG-GUID: 3HBXLBYmg9d-AYtM2bGv6zZZabRw2C87
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475
 definitions=2021-10-26_04,2021-10-26_01,2020-04-07_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 spamscore=0
 clxscore=1015 mlxlogscore=999 impostorscore=0 suspectscore=0
 malwarescore=0 priorityscore=1501 adultscore=0 phishscore=0 bulkscore=0
 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2110260081

SGksIFJvZ2VyIQ0KDQpPbiAyNi4xMC4yMSAxNjozMCwgUm9nZXIgUGF1IE1vbm7DqSB3cm90ZToN
Cj4gZGlmZiAtLWdpdCBhL3hlbi9hcmNoL2FybS9kb21haW4uYyBiL3hlbi9hcmNoL2FybS9kb21h
aW4uYw0KPj4gaW5kZXggZmE2ZmNjNWU0NjdjLi4wOTU2NzE3NDJhZDggMTAwNjQ0DQo+PiAtLS0g
YS94ZW4vYXJjaC9hcm0vZG9tYWluLmMNCj4+ICsrKyBiL3hlbi9hcmNoL2FybS9kb21haW4uYw0K
Pj4gQEAgLTc5Nyw2ICs3OTcsNyBAQCB2b2lkIGFyY2hfZG9tYWluX2Rlc3Ryb3koc3RydWN0IGRv
bWFpbiAqZCkNCj4+ICAgICAgICAgICAgICAgICAgICAgICAgICBnZXRfb3JkZXJfZnJvbV9ieXRl
cyhkLT5hcmNoLmVmaV9hY3BpX2xlbikpOw0KPj4gICAjZW5kaWYNCj4+ICAgICAgIGRvbWFpbl9p
b19mcmVlKGQpOw0KPj4gKyAgICBkb21haW5fdnBjaV9mcmVlKGQpOw0KPiBJdCdzIGEgbml0LCBi
dXQgSSB0aGluayBmcm9tIGEgbG9naWNhbCBQb1YgdGhpcyBzaG91bGQgYmUgaW52ZXJ0ZWQ/DQo+
IFlvdSBmaXJzdCBmcmVlIHRoZSBoYW5kbGVycyBhbmQgdGhlbiB0aGUgSU8gaW5mcmFzdHJ1Y3R1
cmUuDQpJbmRlZWQsIHRoYW5rcw0KPg0KPj4gICB9DQo+PiAgIA0KPj4gICB2b2lkIGFyY2hfZG9t
YWluX3NodXRkb3duKHN0cnVjdCBkb21haW4gKmQpDQo+PiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gv
YXJtL3ZwY2kuYyBiL3hlbi9hcmNoL2FybS92cGNpLmMNCj4+IGluZGV4IDVkNmMyOWM4ZGNkOS4u
MjZlYzJmYTdjZjJkIDEwMDY0NA0KPj4gLS0tIGEveGVuL2FyY2gvYXJtL3ZwY2kuYw0KPj4gKysr
IGIveGVuL2FyY2gvYXJtL3ZwY2kuYw0KPj4gQEAgLTE3LDYgKzE3LDE0IEBADQo+PiAgIA0KPj4g
ICAjZGVmaW5lIFJFR0lTVEVSX09GRlNFVChhZGRyKSAgKCAoYWRkcikgJiAweDAwMDAwZmZmKQ0K
Pj4gICANCj4+ICtzdHJ1Y3QgdnBjaV9tbWlvX3ByaXYgew0KPj4gKyAgICAvKg0KPj4gKyAgICAg
KiBTZXQgdG8gdHJ1ZSBpZiB0aGUgTU1JTyBoYW5kbGVycyB3ZXJlIHNldCB1cCBmb3IgdGhlIGVt
dWxhdGVkDQo+PiArICAgICAqIEVDQU0gaG9zdCBQQ0kgYnJpZGdlLg0KPj4gKyAgICAgKi8NCj4+
ICsgICAgYm9vbCBpc192aXJ0X2VjYW07DQo+PiArfTsNCj4gSXMgdGhpcyBzdHJpY3RseSByZXF1
aXJlZD8gSXQgZmVlbHMgYSBiaXQgb2RkIHRvIGhhdmUgYSBzdHJ1Y3R1cmUgdG8NCj4gc3RvcmUg
YW5kIHNpbmdsZSBib29sZWFuLg0KPg0KPiBJIHRoaW5rIHlvdSBjb3VsZCByZXBsYWNlIGl0J3Mg
dXNhZ2Ugd2l0aCBpc19oYXJkd2FyZV9kb21haW4uDQpJIGFtIHdvcmtpbmcgb24gc29tZSAiZWFy
bGllciIgcGF0Y2ggZml4ZXMgWzFdIHdoaWNoIGFscmVhZHkgbmVlZHMgc29tZSBwcml2YXRlDQp0
byBiZSBwYXNzZWQgdG8gdGhlIGhhbmRsZXJzOiB3ZSBuZWVkIHRvIHNldCBzYmRmLnNlZyB0byB0
aGUgcHJvcGVyDQpob3N0IGJyaWRnZSBzZWdtZW50IGluc3RlYWQgb2YgYWx3YXlzIHNldHRpbmcg
aXQgdG8gMC4NCkFuZCB0aGVuIEkgY2FuIHBhc3MgInN0cnVjdCBwY2lfaG9zdF9icmlkZ2UgKmJy
aWRnZSIgYXMgdGhlIHByaXZhdGUgbWVtYmVyDQphbmQgdXNlIGlzX2hhcmR3YXJlX2RvbWFpbih2
LT5kb21haW4pIHRvIHNlZSBpZiB0aGlzIGlzIGd1ZXN0IG9yIGh3ZG9tLg0KU28sIEknbGwgcmVt
b3ZlIHRoZSBzdHJ1Y3R1cmUgY29tcGxldGVseQ0KDQpbc25pcF0NCg0KPj4gKyAqLw0KPj4gICBz
dGF0aWMgaW50IHZwY2lfc2V0dXBfbW1pb19oYW5kbGVyKHN0cnVjdCBkb21haW4gKmQsDQo+PiAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgc3RydWN0IHBjaV9ob3N0X2JyaWRn
ZSAqYnJpZGdlKQ0KPj4gICB7DQo+PiAtICAgIHN0cnVjdCBwY2lfY29uZmlnX3dpbmRvdyAqY2Zn
ID0gYnJpZGdlLT5jZmc7DQo+PiArICAgIHN0cnVjdCB2cGNpX21taW9fcHJpdiAqcHJpdjsNCj4+
ICsNCj4+ICsgICAgcHJpdiA9IHh6YWxsb2Moc3RydWN0IHZwY2lfbW1pb19wcml2KTsNCj4+ICsg
ICAgaWYgKCAhcHJpdiApDQo+PiArICAgICAgICByZXR1cm4gLUVOT01FTTsNCj4+ICsNCj4+ICsg
ICAgcHJpdi0+aXNfdmlydF9lY2FtID0gIWlzX2hhcmR3YXJlX2RvbWFpbihkKTsNCj4+ICAgDQo+
PiAtICAgIHJlZ2lzdGVyX21taW9faGFuZGxlcihkLCAmdnBjaV9tbWlvX2hhbmRsZXIsDQo+PiAt
ICAgICAgICAgICAgICAgICAgICAgICAgICBjZmctPnBoeXNfYWRkciwgY2ZnLT5zaXplLCBOVUxM
KTsNCj4+ICsgICAgaWYgKCBpc19oYXJkd2FyZV9kb21haW4oZCkgKQ0KPj4gKyAgICB7DQo+PiAr
ICAgICAgICBzdHJ1Y3QgcGNpX2NvbmZpZ193aW5kb3cgKmNmZyA9IGJyaWRnZS0+Y2ZnOw0KPj4g
Kw0KPj4gKyAgICAgICAgYnJpZGdlLT5tbWlvX3ByaXYgPSBwcml2Ow0KPj4gKyAgICAgICAgcmVn
aXN0ZXJfbW1pb19oYW5kbGVyKGQsICZ2cGNpX21taW9faGFuZGxlciwNCj4+ICsgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICBjZmctPnBoeXNfYWRkciwgY2ZnLT5zaXplLA0KPj4gKyAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgIHByaXYpOw0KPj4gKyAgICB9DQo+PiArICAgIGVsc2UN
Cj4+ICsgICAgew0KPj4gKyAgICAgICAgZC0+dnBjaV9tbWlvX3ByaXYgPSBwcml2Ow0KPj4gKyAg
ICAgICAgLyogR3Vlc3QgZG9tYWlucyB1c2Ugd2hhdCBpcyBwcm9ncmFtbWVkIGluIHRoZWlyIGRl
dmljZSB0cmVlLiAqLw0KPj4gKyAgICAgICAgcmVnaXN0ZXJfbW1pb19oYW5kbGVyKGQsICZ2cGNp
X21taW9faGFuZGxlciwNCj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBHVUVTVF9W
UENJX0VDQU1fQkFTRSwgR1VFU1RfVlBDSV9FQ0FNX1NJWkUsDQo+PiArICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgcHJpdik7DQo+PiArICAgIH0NCj4+ICAgICAgIHJldHVybiAwOw0KPj4g
ICB9DQo+PiAgIA0KPj4gQEAgLTk1LDE0ICsxNTQsMjUgQEAgaW50IGRvbWFpbl92cGNpX2luaXQo
c3RydWN0IGRvbWFpbiAqZCkNCj4+ICAgICAgIGlmICggIWhhc192cGNpKGQpICkNCj4+ICAgICAg
ICAgICByZXR1cm4gMDsNCj4+ICAgDQo+PiArICAgIHJldHVybiBwY2lfaG9zdF9pdGVyYXRlX2Jy
aWRnZXMoZCwgdnBjaV9zZXR1cF9tbWlvX2hhbmRsZXIpOw0KPiBJIHRoaW5rIHRoaXMgaXMgd3Jv
bmcgZm9yIHVucHJpdmlsZWdlZCBkb21haW5zOiB5b3UgaXRlcmF0ZSBhZ2FpbnN0DQo+IGhvc3Qg
YnJpZGdlcyBidXQganVzdCBzZXR1cCBhIHNpbmdsZSBFQ0FNIHJlZ2lvbiBmcm9tDQo+IEdVRVNU
X1ZQQ0lfRUNBTV9CQVNFIHRvIEdVRVNUX1ZQQ0lfRUNBTV9TSVpFLCBzbyB5b3UgYXJlIGxlYWtp
bmcNCj4gbXVsdGlwbGUgYWxsb2NhdGlvbnMgb2YgdnBjaV9tbWlvX3ByaXYsIGFuZCBhbHNvIGFk
ZGluZyBhIGJ1bmNoIG9mDQo+IGR1cGxpY2F0ZWQgSU8gaGFuZGxlcnMgZm9yIHRoZSBzYW1lIEVD
QU0gcmVnaW9uLg0KPg0KPiBJTU8geW91IHNob3VsZCBpdGVyYXRlIGFnYWluc3QgaG9zdCBicmlk
Z2VzIG9ubHkgZm9yIHRoZSBoYXJkd2FyZQ0KPiBkb21haW4gY2FzZS4gRm9yIHRoZSB1bnByaXZp
bGVkZ2VkIGRvbWFpbiBjYXNlIHRoZXJlJ3Mgbm8gbmVlZCB0bw0KPiBpdGVyYXRlIGFnYWluc3Qg
dGhlIGxpc3Qgb2YgcGh5c2ljYWwgaG9zdCBicmlkZ2VzIGFzIHlvdSBlbmQgdXANCj4gZXhwb3Np
bmcgYSBmdWxseSBlbXVsYXRlZCBidXMgd2hpY2ggYmVhcnMgbm8gcmVzZW1ibGFuY2UgdG8gdGhl
DQo+IHBoeXNpY2FsIHNldHVwLg0KWWVzLCBJIGFtIG1vdmluZyB0aGlzIGNvZGUgaW50byB0aGF0
ICJlYXJsaWVyIiBwYXRjaCBbMV0gYW5kIGFscmVhZHkNCnNwb3R0ZWQgdGhlIGxlYWs6IHRodXMg
SSBhbSBhbHNvIHJlLXdvcmtpbmcgdGhpcyBjb2RlLg0KPg0KPj4gK30NCj4+ICsNCj4+ICtzdGF0
aWMgaW50IGRvbWFpbl92cGNpX2ZyZWVfY2Ioc3RydWN0IGRvbWFpbiAqZCwNCj4+ICsgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgc3RydWN0IHBjaV9ob3N0X2JyaWRnZSAqYnJpZGdlKQ0K
Pj4gK3sNCj4+ICAgICAgIGlmICggaXNfaGFyZHdhcmVfZG9tYWluKGQpICkNCj4+IC0gICAgICAg
IHJldHVybiBwY2lfaG9zdF9pdGVyYXRlX2JyaWRnZXMoZCwgdnBjaV9zZXR1cF9tbWlvX2hhbmRs
ZXIpOw0KPj4gKyAgICAgICAgWEZSRUUoYnJpZGdlLT5tbWlvX3ByaXYpOw0KPj4gKyAgICBlbHNl
DQo+PiArICAgICAgICBYRlJFRShkLT52cGNpX21taW9fcHJpdik7DQo+PiArICAgIHJldHVybiAw
Ow0KPj4gK30NCj4+ICAgDQo+PiAtICAgIC8qIEd1ZXN0IGRvbWFpbnMgdXNlIHdoYXQgaXMgcHJv
Z3JhbW1lZCBpbiB0aGVpciBkZXZpY2UgdHJlZS4gKi8NCj4+IC0gICAgcmVnaXN0ZXJfbW1pb19o
YW5kbGVyKGQsICZ2cGNpX21taW9faGFuZGxlciwNCj4+IC0gICAgICAgICAgICAgICAgICAgICAg
ICAgIEdVRVNUX1ZQQ0lfRUNBTV9CQVNFLCBHVUVTVF9WUENJX0VDQU1fU0laRSwgTlVMTCk7DQo+
PiArdm9pZCBkb21haW5fdnBjaV9mcmVlKHN0cnVjdCBkb21haW4gKmQpDQo+PiArew0KPj4gKyAg
ICBpZiAoICFoYXNfdnBjaShkKSApDQo+PiArICAgICAgICByZXR1cm47DQo+PiAgIA0KPj4gLSAg
ICByZXR1cm4gMDsNCj4+ICsgICAgcGNpX2hvc3RfaXRlcmF0ZV9icmlkZ2VzKGQsIGRvbWFpbl92
cGNpX2ZyZWVfY2IpOw0KPiBXaHkgZG8gd2UgbmVlZCB0byBpdGVyYXRlIHRoZSBob3N0IGJyaWRn
ZXMgZm9yIHVucHJpdmlsZWdlZCBkb21haW5zPw0KTm8gbmVlZCwgSSBhbSB0YWtpbmcgY2FyZSBv
ZiB0aGlzDQo+IEFGQUlDVCBpdCBqdXN0IGNhdXNlcyBkdXBsaWNhdGVkIGNhbGxzIHRvIFhGUkVF
KGQtPnZwY2lfbW1pb19wcml2KS4gSQ0KPiB3b3VsZCBleHBlY3Qgc29tZXRoaW5nIGxpa2U6DQo+
DQo+IHN0YXRpYyBpbnQgYnJpZGdlX2ZyZWVfY2Ioc3RydWN0IGRvbWFpbiAqZCwNCj4gICAgICAg
ICAgICAgICAgICAgICAgICAgICAgc3RydWN0IHBjaV9ob3N0X2JyaWRnZSAqYnJpZGdlKQ0KPiB7
DQo+ICAgICAgQVNTRVJUKGlzX2hhcmR3YXJlX2RvbWFpbihkKSk7DQo+ICAgICAgWEZSRUUoYnJp
ZGdlLT5tbWlvX3ByaXYpOw0KPiAgICAgIHJldHVybiAwOw0KPiB9DQo+DQo+IHZvaWQgZG9tYWlu
X3ZwY2lfZnJlZShzdHJ1Y3QgZG9tYWluICpkKQ0KPiB7DQo+ICAgICAgaWYgKCAhaGFzX3ZwY2ko
ZCkgKQ0KPiAgICAgICAgICByZXR1cm47DQo+DQo+ICAgICAgaWYgKCBpc19oYXJkd2FyZV9kb21h
aW4oZCkgKQ0KPiAgICAgICAgICBwY2lfaG9zdF9pdGVyYXRlX2JyaWRnZXMoZCwgYnJpZGdlX2Zy
ZWVfY2IpOw0KPiAgICAgIGVsc2UNCj4gICAgICAgICAgWEZSRUUoZC0+dnBjaV9tbWlvX3ByaXYp
Ow0KPiB9DQo+DQo+IEFsYmVpdCBJIHRoaW5rIHRoZXJlJ3Mgbm8gbmVlZCBmb3IgdnBjaV9tbWlv
X3ByaXYgaW4gdGhlIGZpcnN0IHBsYWNlLg0KPg0KPiBUaGFua3MsIFJvZ2VyLg0KVGhhbmsgeW91
LA0KT2xla3NhbmRyDQoNClsxXSBodHRwczovL3BhdGNod29yay5rZXJuZWwub3JnL3Byb2plY3Qv
eGVuLWRldmVsL3BhdGNoLzIwMjExMDA4MDU1NTM1LjMzNzQzNi05LWFuZHIyMDAwQGdtYWlsLmNv
bS8=


From xen-devel-bounces@lists.xenproject.org Tue Oct 26 14:14:58 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Oct 2021 14:14:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.216469.376088 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfNDw-0005gR-Q9; Tue, 26 Oct 2021 14:14:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 216469.376088; Tue, 26 Oct 2021 14:14:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfNDw-0005gK-NG; Tue, 26 Oct 2021 14:14:44 +0000
Received: by outflank-mailman (input) for mailman id 216469;
 Tue, 26 Oct 2021 14:14:42 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=1pRP=PO=gmail.com=jiangshanlai@srs-us1.protection.inumbo.net>)
 id 1mfNDu-0005gE-H1
 for xen-devel@lists.xenproject.org; Tue, 26 Oct 2021 14:14:42 +0000
Received: from mail-pj1-x1036.google.com (unknown [2607:f8b0:4864:20::1036])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 871d893b-93e4-4149-90ac-bf2689792f4a;
 Tue, 26 Oct 2021 14:14:41 +0000 (UTC)
Received: by mail-pj1-x1036.google.com with SMTP id np13so11036768pjb.4
 for <xen-devel@lists.xenproject.org>; Tue, 26 Oct 2021 07:14:41 -0700 (PDT)
Received: from localhost ([47.251.3.230])
 by smtp.gmail.com with ESMTPSA id h10sm926802pfc.104.2021.10.26.07.14.39
 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
 Tue, 26 Oct 2021 07:14:39 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 871d893b-93e4-4149-90ac-bf2689792f4a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=d6cSF3siLASOQuNbVIvhuxpwn8ZXjL6+61RmHjLRG8c=;
        b=Ucl2O9k3psg2jnvS3J6hRGbgDOF4EIUioDWdfxkg4CnBvKahmPqj3OoydGkPn0NR72
         dfO1NR6Pigcnp1siQCVzfXLC4xemzs+NTfqDLwVmYoAdlfS/mW5jgHg7x30nrXEDQJ94
         LH6+pJE6+DfghqQTynIB2W3RuRb/ypGMTs7ydiEL+pxEO+o3mJmyc3QuZuWy+9abQ3Ka
         a5dJyalnHPqU65fL1zyqICOeX3uqNEVsNg9LOe9B95gfLrauPAju9rWKgbd+ipo7VPFV
         JrvaE5FDM46nTPOcyLdjFRE0OQhQCjzVpBy+c9F3gogMzuLtutIfNKsJO74uUGqgqRzw
         f51A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=d6cSF3siLASOQuNbVIvhuxpwn8ZXjL6+61RmHjLRG8c=;
        b=AY5MRoEpfyE7k9F4YAeYBqSEwo6ETdqlowPU2baT+tnCUGl0T1IS7s5TiI4MGIuqBB
         /P/xif8yXw+QQ/ZxMC1i6ypMJ3NGyLNvgVSgWCebSr5yV7sjYNyQrJ1av+Q7fZXbx6ld
         I80nGjR7kcyRWVcVu97ZxqjQhMl0s6BmNjFck+iFcRKneSzA8PfIjQmCm/r/yOLajM4g
         gQltRGa5xEqK7o+Z/4VtdJGNwms0AYt+Acl5B2V50103O8wFE3xhSqiDzVoh+UYk6CIb
         cJI/TTBMP5jKvG+VktMohaJT7u4kKhblDfwI4oI37qrblX5dGwGP975PNp0sYLB4RvDB
         cxsw==
X-Gm-Message-State: AOAM532Ls13lR8u/wTRjyXHmwo28WcLVgWWXLcBE9JLZb6bsvp1YcsUG
	PMp5gj5ByW8QvgXk04hsZJg=
X-Google-Smtp-Source: ABdhPJzRIJnffX6e9BspyBRHQkB9rRnTeGr8WfylFBrSWNzrM2VJybqn73y0Kg3/38zUXZ2Nv+vcsQ==
X-Received: by 2002:a17:90b:1e4a:: with SMTP id pi10mr29132607pjb.142.1635257680326;
        Tue, 26 Oct 2021 07:14:40 -0700 (PDT)
From: Lai Jiangshan <jiangshanlai@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: x86@kernel.org,
	Lai Jiangshan <laijs@linux.alibaba.com>,
	Jan Beulich <jbeulich@suse.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Juergen Gross <jgross@suse.com>,
	Peter Anvin <hpa@zytor.com>,
	xen-devel@lists.xenproject.org,
	Andy Lutomirski <luto@kernel.org>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>
Subject: [PATCH V4 04/50] x86/xen: Add xenpv_restore_regs_and_return_to_usermode()
Date: Tue, 26 Oct 2021 22:13:34 +0800
Message-Id: <20211026141420.17138-5-jiangshanlai@gmail.com>
X-Mailer: git-send-email 2.19.1.6.gb485710b
In-Reply-To: <20211026141420.17138-1-jiangshanlai@gmail.com>
References: <20211026141420.17138-1-jiangshanlai@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Lai Jiangshan <laijs@linux.alibaba.com>

While in the native case, PER_CPU_VAR(cpu_tss_rw + TSS_sp0) is the
trampoline stack.  But XEN pv doesn't use trampoline stack, so
PER_CPU_VAR(cpu_tss_rw + TSS_sp0) is also the kernel stack.  Hence source
and destination stacks are identical in that case, which means reusing
swapgs_restore_regs_and_return_to_usermode() in XEN pv would cause %rsp
to move up to the top of the kernel stack and leave the IRET frame below
%rsp, which is dangerous to be corrupted if #NMI / #MC hit as either of
these events occurring in the middle of the stack pushing would clobber
data on the (original) stack.

And swapgs_restore_regs_and_return_to_usermode() pushing the IRET frame
on to the original address is useless and error-prone when there is any
future attempt to modify the code.

Fixes: 7f2590a110b8 ("x86/entry/64: Use a per-CPU trampoline stack for IDT entries")
Cc: Jan Beulich <jbeulich@suse.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Juergen Gross <jgross@suse.com>
Cc: Peter Anvin <hpa@zytor.com>
Cc: xen-devel@lists.xenproject.org>
Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Signed-off-by: Lai Jiangshan <laijs@linux.alibaba.com>
---
 arch/x86/entry/entry_64.S        |  9 ++++++---
 arch/x86/entry/entry_64_compat.S |  7 ++++---
 arch/x86/xen/xen-asm.S           | 27 +++++++++++++++++++++++++++
 3 files changed, 37 insertions(+), 6 deletions(-)

diff --git a/arch/x86/entry/entry_64.S b/arch/x86/entry/entry_64.S
index 9d468c8877e2..0dde5a253dda 100644
--- a/arch/x86/entry/entry_64.S
+++ b/arch/x86/entry/entry_64.S
@@ -119,7 +119,7 @@ SYM_INNER_LABEL(entry_SYSCALL_64_after_hwframe, SYM_L_GLOBAL)
 	 * In the Xen PV case we must use iret anyway.
 	 */
 
-	ALTERNATIVE "", "jmp	swapgs_restore_regs_and_return_to_usermode", \
+	ALTERNATIVE "", "jmp xenpv_restore_regs_and_return_to_usermode", \
 		X86_FEATURE_XENPV
 
 	movq	RCX(%rsp), %rcx
@@ -286,7 +286,8 @@ SYM_CODE_START(ret_from_fork)
 	UNWIND_HINT_REGS
 	movq	%rsp, %rdi
 	call	syscall_exit_to_user_mode	/* returns with IRQs disabled */
-	jmp	swapgs_restore_regs_and_return_to_usermode
+	ALTERNATIVE "jmp swapgs_restore_regs_and_return_to_usermode",	\
+		"jmp xenpv_restore_regs_and_return_to_usermode", X86_FEATURE_XENPV
 
 1:
 	/* kernel thread */
@@ -566,6 +567,7 @@ __irqentry_text_start:
 __irqentry_text_end:
 
 SYM_CODE_START_LOCAL(common_interrupt_return)
+SYM_INNER_LABEL(xenpv_restore_regs_and_return_to_usermode, SYM_L_WEAK) /* placeholder */
 SYM_INNER_LABEL(swapgs_restore_regs_and_return_to_usermode, SYM_L_GLOBAL)
 #ifdef CONFIG_DEBUG_ENTRY
 	/* Assert that pt_regs indicates user mode. */
@@ -1055,7 +1057,8 @@ SYM_CODE_START_LOCAL(error_return)
 	DEBUG_ENTRY_ASSERT_IRQS_OFF
 	testb	$3, CS(%rsp)
 	jz	restore_regs_and_return_to_kernel
-	jmp	swapgs_restore_regs_and_return_to_usermode
+	ALTERNATIVE "jmp swapgs_restore_regs_and_return_to_usermode",	\
+		"jmp xenpv_restore_regs_and_return_to_usermode", X86_FEATURE_XENPV
 SYM_CODE_END(error_return)
 
 /*
diff --git a/arch/x86/entry/entry_64_compat.S b/arch/x86/entry/entry_64_compat.S
index 0051cf5c792d..2a4d9532dfd5 100644
--- a/arch/x86/entry/entry_64_compat.S
+++ b/arch/x86/entry/entry_64_compat.S
@@ -139,7 +139,7 @@ SYM_INNER_LABEL(entry_SYSENTER_compat_after_hwframe, SYM_L_GLOBAL)
 	call	do_SYSENTER_32
 	/* XEN PV guests always use IRET path */
 	ALTERNATIVE "testl %eax, %eax; jz swapgs_restore_regs_and_return_to_usermode", \
-		    "jmp swapgs_restore_regs_and_return_to_usermode", X86_FEATURE_XENPV
+		    "jmp xenpv_restore_regs_and_return_to_usermode", X86_FEATURE_XENPV
 	jmp	sysret32_from_system_call
 
 .Lsysenter_fix_flags:
@@ -256,7 +256,7 @@ SYM_INNER_LABEL(entry_SYSCALL_compat_after_hwframe, SYM_L_GLOBAL)
 	call	do_fast_syscall_32
 	/* XEN PV guests always use IRET path */
 	ALTERNATIVE "testl %eax, %eax; jz swapgs_restore_regs_and_return_to_usermode", \
-		    "jmp swapgs_restore_regs_and_return_to_usermode", X86_FEATURE_XENPV
+		    "jmp xenpv_restore_regs_and_return_to_usermode", X86_FEATURE_XENPV
 
 	/* Opportunistic SYSRET */
 sysret32_from_system_call:
@@ -411,5 +411,6 @@ SYM_CODE_START(entry_INT80_compat)
 
 	movq	%rsp, %rdi
 	call	do_int80_syscall_32
-	jmp	swapgs_restore_regs_and_return_to_usermode
+	ALTERNATIVE "jmp swapgs_restore_regs_and_return_to_usermode",	\
+		"jmp xenpv_restore_regs_and_return_to_usermode", X86_FEATURE_XENPV
 SYM_CODE_END(entry_INT80_compat)
diff --git a/arch/x86/xen/xen-asm.S b/arch/x86/xen/xen-asm.S
index 220dd9678494..032be1bab113 100644
--- a/arch/x86/xen/xen-asm.S
+++ b/arch/x86/xen/xen-asm.S
@@ -20,6 +20,7 @@
 
 #include <linux/init.h>
 #include <linux/linkage.h>
+#include <../entry/calling.h>
 
 .pushsection .noinstr.text, "ax"
 /*
@@ -192,6 +193,32 @@ SYM_CODE_START(xen_iret)
 	jmp hypercall_iret
 SYM_CODE_END(xen_iret)
 
+/*
+ * XEN pv doesn't use trampoline stack, PER_CPU_VAR(cpu_tss_rw + TSS_sp0) is
+ * also the kernel stack.  Reusing swapgs_restore_regs_and_return_to_usermode()
+ * in XEN pv would cause %rsp to move up to the top of the kernel stack and
+ * leave the IRET frame below %rsp, which is dangerous to be corrupted if #NMI
+ * interrupts. And swapgs_restore_regs_and_return_to_usermode() pushing the IRET
+ * frame at the same address is useless.
+ */
+SYM_CODE_START(xenpv_restore_regs_and_return_to_usermode)
+	UNWIND_HINT_REGS
+#ifdef CONFIG_DEBUG_ENTRY
+	/* Assert that pt_regs indicates user mode. */
+	testb	$3, CS(%rsp)
+	jnz	1f
+	ud2
+1:
+#endif
+	POP_REGS
+
+	/* stackleak_erase() can work safely on the kernel stack. */
+	STACKLEAK_ERASE_NOCLOBBER
+
+	addq	$8, %rsp	/* skip regs->orig_ax */
+	jmp xen_iret
+SYM_CODE_END(xenpv_restore_regs_and_return_to_usermode)
+
 /*
  * Xen handles syscall callbacks much like ordinary exceptions, which
  * means we have:
-- 
2.19.1.6.gb485710b



From xen-devel-bounces@lists.xenproject.org Tue Oct 26 15:03:41 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Oct 2021 15:03:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.216478.376100 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfNzB-0002B8-Ky; Tue, 26 Oct 2021 15:03:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 216478.376100; Tue, 26 Oct 2021 15:03:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfNzB-0002B1-HN; Tue, 26 Oct 2021 15:03:33 +0000
Received: by outflank-mailman (input) for mailman id 216478;
 Tue, 26 Oct 2021 15:03:32 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mfNzA-0002Av-CH
 for xen-devel@lists.xenproject.org; Tue, 26 Oct 2021 15:03:32 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mfNzA-0002is-BI
 for xen-devel@lists.xenproject.org; Tue, 26 Oct 2021 15:03:32 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mfNzA-00072G-AD
 for xen-devel@lists.xenproject.org; Tue, 26 Oct 2021 15:03:32 +0000
Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89)
 (envelope-from <iwj@xenproject.org>)
 id 1mfNz6-0004hm-Mb; Tue, 26 Oct 2021 16:03:28 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date
	:Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From;
	bh=UOcGou6JjWfk9xiV5fD9V5/6lQc0RcCX8tuJ3F7loLw=; b=IsFN59LVagPm+QEK1Q3s3o0pbI
	S30iLgClyyXpmDxpXe0mEkZ57Hki8W9TE7virbcXwIB+SFO5V8UqQ94dF38bb151+tHjhTL/g43EO
	/WS3lRTru6a23m7qKZvDOh981d/y0M5UXW5ve39Bvj5Z2qkljGRBVtQypRNiC7CM4x3g=;
From: Ian Jackson <iwj@xenproject.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <24952.6336.118472.417096@mariner.uk.xensource.com>
Date: Tue, 26 Oct 2021 16:03:28 +0100
To: Juergen Gross <jgross@suse.com>
Cc: xen-devel@lists.xenproject.org
Subject: Re: [PATCH] osstest: explicitly set either enable or disable qemu-traditional
In-Reply-To: <20211026135645.31488-1-jgross@suse.com>
References: <20211026135645.31488-1-jgross@suse.com>
X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu)

Juergen Gross writes ("[PATCH] osstest: explicitly set either enable or disable qemu-traditional"):
> Instead of setting "--enable-qemu-traditional" or not, switch to
> setting "--enable-qemu-traditional" or "--disable-qemu-traditional".
> 
> This avoids a latent bug in the disable case, as the availability
> of the option is tested via grep, which will otherwise grep for
> nothing.
...
> +    my $qemutrad_opt = $r{arch} =~ m/amd64|i386/ ? "--enable-qemu-traditional" : "--disable-qemu-traditional";

The effect of this is that we will now explicitly disable qemu trad on
non-x86 architectures (assuming configure supports it).  I think that
is fine.

Reviewed-by: Ian Jackson <iwj@xenproject.org>

For the avoidance of any doubt,

Release-Acked-by: Ian Jackson <iwj@xenproject.org>

too.  So I will push this now.

Thanks,
Ian.


From xen-devel-bounces@lists.xenproject.org Tue Oct 26 15:13:02 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Oct 2021 15:13:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.216485.376111 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfO8J-0003d7-CS; Tue, 26 Oct 2021 15:12:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 216485.376111; Tue, 26 Oct 2021 15:12:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfO8J-0003d0-8l; Tue, 26 Oct 2021 15:12:59 +0000
Received: by outflank-mailman (input) for mailman id 216485;
 Tue, 26 Oct 2021 15:12:58 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=d0pl=PO=citrix.com=roger.pau@srs-us1.protection.inumbo.net>)
 id 1mfO8I-0003cu-8X
 for xen-devel@lists.xenproject.org; Tue, 26 Oct 2021 15:12:58 +0000
Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 329162be-366f-11ec-8434-12813bfff9fa;
 Tue, 26 Oct 2021 15:12:56 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 329162be-366f-11ec-8434-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1635261176;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:content-transfer-encoding:mime-version;
  bh=+xnslZQGsSNnOetL2xCHxv3OHja0pt4Qnqe7WDXaqks=;
  b=M8R88nsqFcAs/Fzp1RELetM4rgmypuJKl2SlrozPwLsEswNXwqs+Ogq/
   mG8B9M00jdJfg5kwAVYmT+is19B6P3HVzYYg21muRjt66Rj0PalXHI7Kv
   tTkDxr674M8IFH2mtaAEQ6o8a0DWyH5fRGocZahO9R26YmquG//bKGCwZ
   k=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: AunLTUCF7wooD42Hyc5vxgng4D8++FjVQKvc6nTwP1+ss3TwqLw9kqcoGH+2VAtLcubmh+1onw
 ypCbI7ixzUhnHIpmh6WzMRAlkkQxwHiwIaAnowTK5MH1eRrkYai+iNFHmXBomOY0/3iptl84t7
 43vGc6/p5fsOFat33FFOBJN7Y0sbkZ40oxMz7trzWCLmISLqxN8EAwsA2gqNnAqsPrRRwnRkRz
 zU6zxN8RrKS+1L1PtA0lyzLOVwbweoEA97jg6vJSHrLXeuRQj5JFFQEAoFIY1LUi3Sz5c/vAJi
 2A7aNiK6x1aMFFqYlMOKjSJF
X-SBRS: 5.1
X-MesageID: 56108758
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:RAvE0Kjafct+xj4M3GJbTr2EX161thcKZh0ujC45NGQN5FlHY01je
 htvDTyDbPyDMWegKo0gbd619xgBu5OBm9NqTlRvqCw0Eykb9cadCdqndUqhZCn6wu8v7a5EA
 2fyTvGacajYm1eF/k/F3oAMKRCQ7InQLlbGILes1htZGEk0F0/NtTo5w7Rg29Yy34Dia++wk
 YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq
 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx
 /1U6JufSC0bEZb8nac9cD56UC1cM/xvreqvzXiX6aR/zmXDenrohf5vEFs3LcsT/eMf7WNmr
 KJCbmpXN1ba2rzwkOnTpupE36zPKOHxO4wSoDd4xCzxBvc6W5HTBa7N4Le02R9t2JkWTamDN
 6L1bxJkTwnjXEMRIWtMBYkmtuGxpmDQLidh/Qf9Sa0fvDGIkV0ZPKLWGMXRUsyHQ4NShEnwj
 mDM8nn9AxoaHMeC0jfD+XWp7sffkCW+VI8MGbmQ8v9xnEbV1mEVEAcRV1awvb++kEHWZj5EA
 xVKoGx09/F0rRH1CImmN/GlnJKalgdBXPVROd8V0zGIiYr3xCTaCkoKHxcUPbTKq/QKbTAt0
 1aImfbgCjpurKCZRBqhy1uEkd+hEXNKdTFaNEfoWSNAuoO5+Nhi0XojW/46SPbt5uAZDw0c1
 NxjQMIWvL4UkdIQn5uy+VTKklpATbCYE1ZruG07so+jhz6VhbJJhaT0tjA3Dt4ade51q2VtW
 1Bfw6CjABgmV83lqcB0aLxl8EuVz/iEKibAplVkAoMs8T+gk1b6I9sNuWEufRY4YpdVEdMMX
 KM0kVgJjKK/wVPwNfMnC25PI51ypUQfKTgVfq+NNYcfCnSAXASG4DtvdSatM5PFyyARfVUEE
 c7DK66EVC9CYYw+lWbeb7pNgNcDm3FlrUuOFM+T8vhS+efHDJJjYexeawXmgyFQxP7snTg5B
 P4FZ5fWkk4EALOlCsQVmKZKRW03wbEALcmeg+Rcd/KZIxogH2ckCvTLxqgmdZAjlKNQ/tokN
 FnjMqOB4Fag13DBNyuQbXVvNOHmUZpl9CppNi0wJ1e4nXMkZN/3vqsYcpI2e5gh9fBikqEoH
 6VUJZ3YD6QdUCnD9hQccYL58N5oeiO0iF/cJCGiejU+IcJtHlSb5t/+cwLz3yASFS7r59Amq
 rit21qDE5oOTghvFujMb/erww/jtHQRgrsqDUDJPsNSaAPn940zc379ifo+IsctLxTfx2TFi
 1bKUElA/eSU+t076tjEg6yAvryFKeomExoIBXTf4Ja3KTLeojipz7hfXbvaZjvaTm71pvmvP
 L0H0/HmPfQbt19WqI4gQa1zxKcz6taz9b9XygNoQCfCY1ixU+4yJ3CH2Y9Et7FXx68fsgyzA
 xrd9t5fMLSPGcXkDF9Oe1Z1MrXdjakZymvI8PA4AETm/ysmrrOIXHJbMwSIlCEAfqB+N5kow
 Lt5tcMbg+BlZsHG7jpSYvhoylmx
IronPort-HdrOrdr: A9a23:fffZearYgUDiGTbvvj+R4kgaV5u3L9V00zEX/kB9WHVpm5Oj+f
 xGzc516farslossREb+expOMG7MBThHPlOkPYs1NaZLXXbUQ6TTb2KgrGSugEIdxeOk9K1kJ
 0QCZSWa+eAfWSS7/yKmDVQeuxIqLLsndHK9IWuvEuFDzsaFp2Ihz0JezpzeXcGIjWua6BJcK
 Z1saF81kSdkDksH4mGL0hAe9KGi8zAlZrgbxJDLxk76DOWhTftzLLhCRCX0joXTjsKmN4ZgC
 f4uj28wp/mn+Cwyxfa2WOWx5NKmOH5wt8GIMCXkMAaJhjllw7tToV8XL+puiwzvYiUmRoXue
 iJhy1lE9V46nvXcG3wiRzx2zP42DJr0HPmwU/wuwqqneXJABYBT+ZRj4NQdRXUr2A6ustn7a
 5N12WF87JKEBLphk3Glpj1fiAvsnDxjWspkOYVgXAae5AZcqVtoYsW+14QOIscHRj99JssHI
 BVfYDhDc5tABGnhk3izyxSKITGZAV2Iv7GeDlNhiWt6UkUoJgjpHFog/D2nR87hdsAotd/lq
 L5259T5cRzp/ktHNRA7dc6MLmK41P2MGbx2RqpUC/a/YE8SjnwQs3Mkf8IDN/DQu1+8HJ1ou
 WZbG9l
X-IronPort-AV: E=Sophos;i="5.87,184,1631592000"; 
   d="scan'208";a="56108758"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=f8FrI25K6VN7YawKz6Aypq3Q3prGB1ftbqs41JojcenYdl7nPa7xjTlckLJo2LARtLwlGIk6XBDgfvQ7I36fBxV2qXAJGPwZoWYS1VSjKp1BIn4xjZAx5m6anaVDMNEQN/5PlmBL4sfdn+QizyTKD4FjFNBaGtP6fe8LvHR+GS9t/x+urDeLb+oveSwH6gAgy+QLthS9T1bgVZApFNW6LeZeSBGSVK85UVR8etYtAVmuORSLqfp9EfPba5GLgjtzLifUugHqwws6ADVk5XgHKEk0EkPqSixHE5olzZf1svi1GPHKL1HMsmqqNa5/KLLwU7dcQqAeDg3evrggmQjx9g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=uPWJh6qs7ggJoWdqKmPe85QWZtBPoSDuYY1GiEa4V8U=;
 b=jgVuFlKMfIWi2zi2Nw9qGSo4hauztSk/J05F58arQMzg4lMp1UkUrtWdDTpHdHqGK7nTJL5rHZvDBaiXMRp3LB6cp9n7dm4nzQfUtTgLkjW93ZuZrS+AYfyebEteG2T+6SCTclW+2/7DEA3Sw0Upa43oiev3/J8qLs8IXL08/yUb1ouWb90xKk5du/N60N3XxYBcqo+uAa4sVJyGY8qzZcTfhZZ+OI7HzAnzt396bOGCm955yQNCXOAbcaWg4TynxwBosoebjYxGse5DyeDBA3+fO8euvmzSLJawLFV1g+7mnx/n0taLujrgzOeSF3lJtEf4uNvZTMdD1r2JfKo5ag==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=uPWJh6qs7ggJoWdqKmPe85QWZtBPoSDuYY1GiEa4V8U=;
 b=rcPba+XylS6Oo/oJMOdT3rJOcPRJpVUebxgdMervTeQj122Nw5DMmRufHgUJUjMM14+ZOuOA5j7M+gJ3v6PP6HMH9loyImOrOOQtyKxFND2TN1hypQqmZX11Tuf1Ab+1VIvTraFfOSv2wFWQTq11+kD5J1etkWUe/BTFbnZFpJ8=
From: Roger Pau Monne <roger.pau@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Roger Pau Monne <roger.pau@citrix.com>, Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
Subject: [PATCH] x86/hpet: setup HPET even when disabled due to stopping in deep C states
Date: Tue, 26 Oct 2021 17:12:33 +0200
Message-ID: <20211026151233.57246-1-roger.pau@citrix.com>
X-Mailer: git-send-email 2.33.0
In-Reply-To: <68352fc1-9ba0-1081-be50-065b212f96a3@citrix.com>
References: <68352fc1-9ba0-1081-be50-065b212f96a3@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: MR1P264CA0014.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:501:2e::19) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: a4841d98-48a1-4fdf-d776-08d9989314b6
X-MS-TrafficTypeDiagnostic: DM5PR03MB2716:
X-Microsoft-Antispam-PRVS: <DM5PR03MB27162BCD9AB6A64CF335AE718F849@DM5PR03MB2716.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: ZKYq2GHo1eRt6jeo+9CJEm8juqo1ZoKTGC78nNZAaZIDmK2rqsUNtJLNbV8Okm3Zv6Q5x1uJfOhGZK+gA99w+jBTKNmu55pKHxra3lIAXau4kg32AYsAShHj1B/t9pfJBXX8QLpHFoNfKmYGqHoEkVLB92izf663hu/zv83dH1odWLUA9Ye/hh9J6aDDN/aIsQTDxv267sQGAGCrLBfexp0f9nJg062F+NICBo7EhJUYRXL2gjAp2WsRQ5z/e1VdGUJPUSsNQ7yuNtpbmPxyp/GzWKvSPgT/YdDk/3XyM9r7GGq869V6md4vv8vd2UVEmgWA+qCsZaA6oamYcJ2u6aqLr/vtMIJB8oXq0Vn2oQfQasY8VpbjBRviP9siDBHxLJQDlfJZEkbVMpR7gKOxsDBZE5CpKSVRxmPWszsNm+pl23DA+4TDncE9rdPxbNiughpFfthrvMQ3zZkUnCx1OEMwIG2rc/5LMiaaSCxyPZgO3fLY2dPsBYJ+z/QJSZ71p3zWIx3i5yJwek3X8A3TY43ND3atBUAHdtv1NX5/CNcZSvXRrvq4DYupL+MVOa3lHhU77Z/Y4ykMaOcwqbhg6endoWmWq21JOqEgVQYOur71KB763aWL0sgg2rrkxLpd88pEP7UaXLk+441xh27sUA==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(6916009)(83380400001)(6666004)(66476007)(66556008)(2906002)(5660300002)(2616005)(66946007)(54906003)(4326008)(38100700002)(36756003)(316002)(1076003)(508600001)(82960400001)(8676002)(6496006)(86362001)(26005)(8936002)(186003)(6486002)(956004);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NXpXRGdMclV0NVhCQklqODVGR1ZKeHN4OFBPT1Vycm9JNUZRNWticEpWaVRH?=
 =?utf-8?B?WnVQNm5ISlMzRldCR0VDRlpJR041SXNBek0ycTJ4OWtUOHZjblZ5Rlh4R2gr?=
 =?utf-8?B?ZzdYWmFJVnZXNk5hZllZNXBRSDZrdmdZU2l4b09TVG1ZRTdFcEhVWGVrRTdX?=
 =?utf-8?B?V21UZ0R6T3NxRTU1Mk52WnVTRnlHWERVa0hEVlhhVGdUdWlaZjRJSHUxZmRj?=
 =?utf-8?B?RlRITkJCVyszY2l3OTgrRnFWaEs1RFVOaHBLenN2ZFd0WE1KRExLUlcwbm93?=
 =?utf-8?B?Znp3SXhqLzZSelNnUjk2bmdDSW9KZmVpUCtZRnBaSGViWmVlQm43NWdYOGlt?=
 =?utf-8?B?MFppZUFjRk5XZ0d1SG9FaVZ0Q203Sy81ZHc3WTdNQXRWQklFNzlyV1lvVnhm?=
 =?utf-8?B?enJ6Q0Fhc2ROUVpoeUhPQk9sNUw4S0h6azhKWURUbDg4R2FiZVQ0S1VkYnl1?=
 =?utf-8?B?Mko2a3VLMWdXa0VNTVVydUd4ZWpJNVNmSkg0Vnd2cHJ1dzNBcDFVNzlQWHhj?=
 =?utf-8?B?dFZlUm81OVl6SjNOWWQ2bXZKMndHZVQ1WmlsRG5pTU9rODNsTXoxd0J4Wklm?=
 =?utf-8?B?Z2ltRFFTZE1NelU3Z1B6d2JjZ0QvYkhsWE01TkRXbmR5S2xzeXN0WTB1Rnpj?=
 =?utf-8?B?WlQrdkw2T0RkZXpQcVMrTC9SbTk0cXZPSzhXalNTd3drOUVPck5kUCtDYXZm?=
 =?utf-8?B?cUN3SmpYNVRYWUN5ZHBJNnB2blBKdHRQb0k3TDNQL2EzL0FOeDh5b0Mvdjgz?=
 =?utf-8?B?Mm9DTXVlR2JEZWRZVGFpZjAvTjBZV0Jqb2NGZDFCRGFGYmFUaUh2dVk4cUpW?=
 =?utf-8?B?elArZm02SW1uYTB1WWJ6TjZiSlllMERFa29wWDhyOS9tbUsrWWxJTS9md1Bx?=
 =?utf-8?B?cFVYTjBkT01tOVdKVDdPQTZ3cFU2Qk1NdXFiWVpoWi9RK2NWcmVRVlFBQmgy?=
 =?utf-8?B?ZS9IZEQxTi9PNEI5Q3VsVk1oZFlUQjNZazlkOGdmRlZmaGFCbEh4QjJ4Zm9Q?=
 =?utf-8?B?RUdUZFVRQmVrdUVYT0U5ckxiU2tLZE5nbzArUndPa1BqbnhYMFFRMjFQMFFX?=
 =?utf-8?B?Si9KOWhhd0JSYnJmUGVqK3pMVGx2QXJyZGcyV1d4Skh2L3pkNXhmK25QSmNP?=
 =?utf-8?B?ZXB6UVpFU3lvM0Q2NjBMeUxYZ3FEcy9XV2J5c2VSdzdNY3BIY3c5SHlaeDJa?=
 =?utf-8?B?dVNpSHQrSy9QWGkxM1NhdnJhMjdVc0dWMU55R2hDeWpuZHFFK1pzYU5SanBW?=
 =?utf-8?B?R0lFUk1aSDRYNzhIN1l6M2s5aGRIVDFzUitXOEJoelJKMDlTUy9IcmlxYmZq?=
 =?utf-8?B?bk1Rem1aSE5CVGIwaEJQdDZpQ3NGTEI3d0Rod3NkdWVLQXI1NXh5SndLb0RN?=
 =?utf-8?B?NnZnc1huNmNXYjk0ZWt2enlhc0VJL3NwWWg0OThvTzZ2Z1VVVm1JRkdua1d0?=
 =?utf-8?B?SjQvS1hXbWV5QUNPMENSaDRCZVFLcGtXZFlybmY0VW5KNlQ5NXFya0hnMjl2?=
 =?utf-8?B?bWtUVmozQVJQbXd1cFhXdU9CM214WENEUEk0d003NlluZUdTMXpCSTk4ZEVo?=
 =?utf-8?B?MU5qRVhxUmZZWHk4d0xnOHpmTHY1K1NqU2RXbFpIUUdBdWsxbVB6dkloYlZr?=
 =?utf-8?B?bTgwcERNdFFjY2txNXByRlBHN3BXZlBVYkFEQnUyTTl1eEQ3Y1FPc0Fqck8w?=
 =?utf-8?B?K0tPVmZqNGtnc2h1akpvRjlSR0NDTUlNbEJlbGhqUzF0Yk1wQkVHSzNqM3di?=
 =?utf-8?B?TzFlc01IN3lvdmhWbHduY3N6TXhGUDJ1b0NGOC8wTWJ4SFY1QUVQRTB5anho?=
 =?utf-8?B?ZDBvdDRZUzFQKy9jVXZaaTFJbVZBcXc2YUxlWWNKd1o3SGVLWkZDdGNWTVpo?=
 =?utf-8?B?emoyMjBoQ0J2UFc5aVFwRURIaXFEVFNvclJWUEd0R3hXZjF4WmpjVGwvaHpY?=
 =?utf-8?B?TFlhZzVoQXNwZXFRV3VJS2hMSWtka0pTYVVxa0pTWHNFdmZiZ3lwTFd1SVdY?=
 =?utf-8?B?bmNLV25zQjVad0FmZGRRWlRPTW44VWd3WXA0Wk1lakc2L3dCNnFFK0pGak5Z?=
 =?utf-8?B?ZUh1c3dyV3dWaDFhOXc2R1JYOURaME1qTW5oMndONGxjNDh2NFg4OWVyWnpu?=
 =?utf-8?B?d2RibWV1N000Ymo2bThRMnNvK0llbHFhejJrR2thaDR0MXh4MkJpMUswb3Fq?=
 =?utf-8?Q?yP9vFiFzlrMuLhrTETbcsPk=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: a4841d98-48a1-4fdf-d776-08d9989314b6
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2021 15:12:52.6898
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: yoKFnl9NUdvRz5lPPxPho3gL4sx+CbR2IyMR4h1bs4VAiGAnhS/soRSG2+MXGT/9f40lTRwTEzy1GJF3BLXW1w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB2716
X-OriginatorOrg: citrix.com

Always allow the HPET to be setup, but don't report a frequency back
to the platform time source probe in order to avoid it from being
selected as a valid timer if it's not usable.

Doing the setup even when not intended to be used as a platform timer
is required so that is can be used in legacy replacement mode in order
to assert the IO-APIC is capable of receiving interrupts.

Fixes: c12731493a ('x86/hpet: Use another crystalball to evaluate HPET usability')
Reported-by: Andrew Cooper <andrew.cooper3@citrix.com>
Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
 xen/arch/x86/time.c | 14 ++++++++++----
 1 file changed, 10 insertions(+), 4 deletions(-)

diff --git a/xen/arch/x86/time.c b/xen/arch/x86/time.c
index cbadaa036f..a290aba3e8 100644
--- a/xen/arch/x86/time.c
+++ b/xen/arch/x86/time.c
@@ -379,6 +379,12 @@ static int64_t __init init_hpet(struct platform_timesource *pts)
 {
     uint64_t hpet_rate, start;
     uint32_t count, target;
+    /*
+     * Allow HPET to be setup, but report a frequency of 0 so it's not selected
+     * as a timer source. This is required so it can be used in legacy
+     * replacement mode in check_timer.
+     */
+    bool disable_hpet = false;
 
     if ( hpet_address && strcmp(opt_clocksource, pts->id) &&
          cpuidle_using_deep_cstate() )
@@ -391,7 +397,7 @@ static int64_t __init init_hpet(struct platform_timesource *pts)
             case 0x0f1c:
             /* HPET on Cherry Trail platforms will halt in deep C states. */
             case 0x229c:
-                hpet_address = 0;
+                disable_hpet = true;
                 break;
             }
 
@@ -431,14 +437,14 @@ static int64_t __init init_hpet(struct platform_timesource *pts)
             else if ( !strcmp(opt_clocksource, pts->id) )
                 printk("HPET use requested via command line, but dysfunctional in PC10\n");
             else
-                hpet_address = 0;
+                disable_hpet = true;
         }
 
-        if ( !hpet_address )
+        if ( disable_hpet )
             printk("Disabling HPET for being unreliable\n");
     }
 
-    if ( (hpet_rate = hpet_setup()) == 0 )
+    if ( (hpet_rate = hpet_setup()) == 0 || disable_hpet )
         return 0;
 
     pts->frequency = hpet_rate;
-- 
2.33.0



From xen-devel-bounces@lists.xenproject.org Tue Oct 26 16:07:51 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Oct 2021 16:07:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.216513.376140 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfOzG-0001pH-Tv; Tue, 26 Oct 2021 16:07:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 216513.376140; Tue, 26 Oct 2021 16:07:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfOzG-0001pA-Q8; Tue, 26 Oct 2021 16:07:42 +0000
Received: by outflank-mailman (input) for mailman id 216513;
 Tue, 26 Oct 2021 16:07:41 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=gydQ=PO=gmail.com=olekstysh@srs-us1.protection.inumbo.net>)
 id 1mfOzF-0001p4-Dy
 for xen-devel@lists.xenproject.org; Tue, 26 Oct 2021 16:07:41 +0000
Received: from mail-ed1-x52e.google.com (unknown [2a00:1450:4864:20::52e])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 65c92945-8471-487b-8b58-668d415969e9;
 Tue, 26 Oct 2021 16:07:40 +0000 (UTC)
Received: by mail-ed1-x52e.google.com with SMTP id h7so4688458ede.8
 for <xen-devel@lists.xenproject.org>; Tue, 26 Oct 2021 09:07:40 -0700 (PDT)
Received: from otyshchenko.router ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id eu9sm4025195ejc.14.2021.10.26.09.05.19
 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
 Tue, 26 Oct 2021 09:05:20 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 65c92945-8471-487b-8b58-668d415969e9
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references;
        bh=oU+EeY72Fqxo4fuN88dML4OJjiCHzSRBLySQqfRpU6s=;
        b=EpVIsA8GKPo7dk/fZDHOCL8DXg2THekLyD8GvJ1+QSmhCGoRek4kq37MFuWeTXiRpx
         D1fz2Uxu7u1Jr82GIuHHPi3DZMBcOyePePAP1ibi9T7jyzBIFJ1aWFoaWOjyoWvE0jd7
         PMjhtJHVqDl+TlWbjSAWulUT3+fJwS9xZv9WZ0rqS3cKIXcFZA7QruaP6OCF7XDYQR9R
         SSO1vUiz9NKtvxPAaoKztcSELSAGXAuBs/iVKXwNIhMhxGtT3XKEAN164OBgah0hXQ50
         /rSS/COR3zV9a674A1N+TuaMMHk3wqS4qAaGRq97YqtSrG5+U8FHO6UnHvtVHfna5Z1X
         RJLw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references;
        bh=oU+EeY72Fqxo4fuN88dML4OJjiCHzSRBLySQqfRpU6s=;
        b=rAdBncCT7GBAr1vgXVAt5vpLjg79alkbzKZ3/wLiMgkzjXa4307D0Wo+1/kusoC5Ur
         fksvhqSnysqyf6NBzjzYFTwdDzTkXNLx0t2UzF3IUCCzuYJ1M+XjLHoLjrZ8hBwDTdb/
         8n4LMdez9/BV0mTmy9/P3VFd+gOqePo+D5yoAjLMVPIT4nfgkzAPEY4/xFbG4b0h2kmF
         ER/6y/7wGHmwv9kWWK0j3I6vue3ezaNNEoepeVff8qbnW9Cc4Egww6zsDdaJHTHA6uRY
         h4diBzSkY0jHTt5yxVlqOLWgon3KUKhovVrzy7yUgzrTBkyBwNNm+NqC/pA7bmoQEPs0
         yRsg==
X-Gm-Message-State: AOAM533cKSDhF4ENbZAozvstNTL2Q0HDlfhwfDPcg3CsXKosANIQL/Am
	yXhXjs73HqoDH4/8plUEJbfnp6BT8as=
X-Google-Smtp-Source: ABdhPJzrbtOvYqLsp3FLdTpT/Amo1B5J4A7Ys4+PXalhb9IOcwydKRsjZqHL2AH62jn9HrKJliqqFw==
X-Received: by 2002:a50:ee01:: with SMTP id g1mr22757719eds.79.1635264320421;
        Tue, 26 Oct 2021 09:05:20 -0700 (PDT)
From: Oleksandr Tyshchenko <olekstysh@gmail.com>
To: xen-devel@lists.xenproject.org,
	linux-kernel@vger.kernel.org
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>
Subject: [PATCH V2 1/4] xen/unpopulated-alloc: Drop check for virt_addr_valid() in fill_list()
Date: Tue, 26 Oct 2021 19:05:09 +0300
Message-Id: <1635264312-3796-2-git-send-email-olekstysh@gmail.com>
X-Mailer: git-send-email 2.7.4
In-Reply-To: <1635264312-3796-1-git-send-email-olekstysh@gmail.com>
References: <1635264312-3796-1-git-send-email-olekstysh@gmail.com>

From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>

If memremap_pages() succeeds the range is guaranteed to have proper page
table, there is no need for an additional virt_addr_valid() check.

Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
---
Changes RFC -> V2:
   - new patch, instead of
     "[RFC PATCH 1/2] arm64: mm: Make virt_addr_valid to check for pfn_valid again"
---
 drivers/xen/unpopulated-alloc.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/xen/unpopulated-alloc.c b/drivers/xen/unpopulated-alloc.c
index 87e6b7d..a03dc5b 100644
--- a/drivers/xen/unpopulated-alloc.c
+++ b/drivers/xen/unpopulated-alloc.c
@@ -85,7 +85,6 @@ static int fill_list(unsigned int nr_pages)
 	for (i = 0; i < alloc_pages; i++) {
 		struct page *pg = virt_to_page(vaddr + PAGE_SIZE * i);
 
-		BUG_ON(!virt_addr_valid(vaddr + PAGE_SIZE * i));
 		pg->zone_device_data = page_list;
 		page_list = pg;
 		list_count++;
-- 
2.7.4



From xen-devel-bounces@lists.xenproject.org Tue Oct 26 16:07:51 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Oct 2021 16:07:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.216514.376151 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfOzL-00025v-A5; Tue, 26 Oct 2021 16:07:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 216514.376151; Tue, 26 Oct 2021 16:07:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfOzL-00025m-6F; Tue, 26 Oct 2021 16:07:47 +0000
Received: by outflank-mailman (input) for mailman id 216514;
 Tue, 26 Oct 2021 16:07:46 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=gydQ=PO=gmail.com=olekstysh@srs-us1.protection.inumbo.net>)
 id 1mfOzK-0001p4-8v
 for xen-devel@lists.xenproject.org; Tue, 26 Oct 2021 16:07:46 +0000
Received: from mail-ed1-x535.google.com (unknown [2a00:1450:4864:20::535])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id c03a9faa-4501-4e50-b60a-a149519fe8d0;
 Tue, 26 Oct 2021 16:07:42 +0000 (UTC)
Received: by mail-ed1-x535.google.com with SMTP id h7so4689051ede.8
 for <xen-devel@lists.xenproject.org>; Tue, 26 Oct 2021 09:07:42 -0700 (PDT)
Received: from otyshchenko.router ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id eu9sm4025195ejc.14.2021.10.26.09.05.21
 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
 Tue, 26 Oct 2021 09:05:22 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c03a9faa-4501-4e50-b60a-a149519fe8d0
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references;
        bh=wgCQ3QpgBU+9Jo1johQyA8YH17F0xtomZ9AsDb/n0+k=;
        b=ErjQU0xF7MucZPckHXbirk+HxNHRkSp0ftkyRu6h2iwOhEb1+8lpFeakKm96+M1vrt
         vbgqEK316lrbPhq56wyunZz1slXFzySXAHjpl7l2X1RylcVS5UjbXcavz+df5VluZeo5
         rhqg08YnA4j2D0jcYNVpA0/aT3jPn+lsaOITDNiwlSeIGHChg+T/kdFrahVXgd0v5QnV
         b/7SP50ygKAhav42t9BKm78sXv9KGYT1kZ6ZI3AN/0kEHd2F7FnWdty0PGISoNyIfYQW
         1GEU778jvDLC9NnLu992kgqal847kKCrc3m3R2RYsoFeXGhbY9qA+qG+EkMzLsJsrCVR
         lVJQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references;
        bh=wgCQ3QpgBU+9Jo1johQyA8YH17F0xtomZ9AsDb/n0+k=;
        b=uY9AiCrvZFyNS1GjmsyuQ0CuDPsyH+5m06uA7s/UHYEVevAD801C8NU352hBe4Oeba
         7+5PAhMLIL29L+vT5+DcdpNtT7FXiQWCaG1rEaI9zaSfdB+7owRTMMT8SuXpxfhTz+Gc
         zpzKQ++3T1jqalGlVqrcRODuzwhrqsdjaBXIhNjSkVOWGS+6onJb8AUWFto7dgn7ZmrX
         u5goqJXGiBOcIdv6ARKZc5ax8o7khXjw33ch+T+LF9z6DFvDkl1fUppAqbCb3FqiZ5gY
         6qzbSDn2pRrUXBYZCI0mOHT+f4kQW6Wc721duDJNgIQyXX+cUe2TNcXWy+XLA6Mxpm54
         Noiw==
X-Gm-Message-State: AOAM533AtyyNT33ERFcOygFTt6T+UT9NxjheSf5uWwdwjUW/7UfBpsuz
	iCOfZ+UClyfjRSNq7wcomqZiE471Z3E=
X-Google-Smtp-Source: ABdhPJxHzSGaUiizFl6ReNX7rAoYCSY51GxR2/K5Ko9EJMbZTxjP/iW8YNrB1UrUQguQ3zP8KNzhvg==
X-Received: by 2002:a05:6402:190e:: with SMTP id e14mr37063692edz.20.1635264322584;
        Tue, 26 Oct 2021 09:05:22 -0700 (PDT)
From: Oleksandr Tyshchenko <olekstysh@gmail.com>
To: xen-devel@lists.xenproject.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Russell King <linux@armlinux.org.uk>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Julien Grall <julien@xen.org>
Subject: [PATCH V2 4/4] arm/xen: Read extended regions from DT and init Xen resource
Date: Tue, 26 Oct 2021 19:05:12 +0300
Message-Id: <1635264312-3796-5-git-send-email-olekstysh@gmail.com>
X-Mailer: git-send-email 2.7.4
In-Reply-To: <1635264312-3796-1-git-send-email-olekstysh@gmail.com>
References: <1635264312-3796-1-git-send-email-olekstysh@gmail.com>

From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>

This patch implements arch_xen_unpopulated_init() on Arm where
the extended regions (if any) are gathered from DT and inserted
into passed Xen resource to be used as unused address space
for Xen scratch pages by unpopulated-alloc code.

The extended region (safe range) is a region of guest physical
address space which is unused and could be safely used to create
grant/foreign mappings instead of wasting real RAM pages from
the domain memory for establishing these mappings.

The extended regions are chosen by the hypervisor at the domain
creation time and advertised to it via "reg" property under
hypervisor node in the guest device-tree. As region 0 is reserved
for grant table space (always present), the indexes for extended
regions are 1...N.

If arch_xen_unpopulated_init() fails for some reason the default
behaviour will be restored (allocate xenballooned pages).

This patch also removes XEN_UNPOPULATED_ALLOC dependency on x86.

Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
---
Changes RFC -> V2:
   - new patch, instead of
    "[RFC PATCH 2/2] xen/unpopulated-alloc: Query hypervisor to provide unallocated space"
---
 arch/arm/xen/enlighten.c | 112 +++++++++++++++++++++++++++++++++++++++++++++++
 drivers/xen/Kconfig      |   2 +-
 2 files changed, 113 insertions(+), 1 deletion(-)

diff --git a/arch/arm/xen/enlighten.c b/arch/arm/xen/enlighten.c
index dea46ec..1a1e0d3 100644
--- a/arch/arm/xen/enlighten.c
+++ b/arch/arm/xen/enlighten.c
@@ -62,6 +62,7 @@ static __read_mostly unsigned int xen_events_irq;
 static phys_addr_t xen_grant_frames;
 
 #define GRANT_TABLE_INDEX   0
+#define EXT_REGION_INDEX    1
 
 uint32_t xen_start_flags;
 EXPORT_SYMBOL(xen_start_flags);
@@ -303,6 +304,117 @@ static void __init xen_acpi_guest_init(void)
 #endif
 }
 
+#ifdef CONFIG_XEN_UNPOPULATED_ALLOC
+int arch_xen_unpopulated_init(struct resource *res)
+{
+	struct device_node *np;
+	struct resource *regs, *tmp_res;
+	uint64_t min_gpaddr = -1, max_gpaddr = 0;
+	unsigned int i, nr_reg = 0;
+	struct range mhp_range;
+	int rc;
+
+	if (!xen_domain())
+		return -ENODEV;
+
+	np = of_find_compatible_node(NULL, NULL, "xen,xen");
+	if (WARN_ON(!np))
+		return -ENODEV;
+
+	/* Skip region 0 which is reserved for grant table space */
+	while (of_get_address(np, nr_reg + EXT_REGION_INDEX, NULL, NULL))
+		nr_reg++;
+
+	if (!nr_reg) {
+		pr_err("No extended regions are found\n");
+		return -EINVAL;
+	}
+
+	regs = kcalloc(nr_reg, sizeof(*regs), GFP_KERNEL);
+	if (!regs)
+		return -ENOMEM;
+
+	/*
+	 * Create resource from extended regions provided by the hypervisor to be
+	 * used as unused address space for Xen scratch pages.
+	 */
+	for (i = 0; i < nr_reg; i++) {
+		rc = of_address_to_resource(np, i + EXT_REGION_INDEX, &regs[i]);
+		if (rc)
+			goto err;
+
+		if (max_gpaddr < regs[i].end)
+			max_gpaddr = regs[i].end;
+		if (min_gpaddr > regs[i].start)
+			min_gpaddr = regs[i].start;
+	}
+
+	/* Check whether the resource range is within the hotpluggable range */
+	mhp_range = mhp_get_pluggable_range(true);
+	if (min_gpaddr < mhp_range.start)
+		min_gpaddr = mhp_range.start;
+	if (max_gpaddr > mhp_range.end)
+		max_gpaddr = mhp_range.end;
+
+	res->start = min_gpaddr;
+	res->end = max_gpaddr;
+
+	/*
+	 * Mark holes between extended regions as unavailable. The rest of that
+	 * address space will be available for the allocation.
+	 */
+	for (i = 1; i < nr_reg; i++) {
+		resource_size_t start, end;
+
+		start = regs[i - 1].end + 1;
+		end = regs[i].start - 1;
+
+		if (start > (end + 1)) {
+			rc = -EINVAL;
+			goto err;
+		}
+
+		/* There is no hole between regions */
+		if (start == (end + 1))
+			continue;
+
+		/* Check whether the hole range is within the resource range */
+		if (start < res->start || end > res->end) {
+			if (start < res->start)
+				start = res->start;
+			if (end > res->end)
+				end = res->end;
+
+			if (start >= (end + 1))
+				continue;
+		}
+
+		tmp_res = kzalloc(sizeof(*tmp_res), GFP_KERNEL);
+		if (!tmp_res) {
+			rc = -ENOMEM;
+			goto err;
+		}
+
+		tmp_res->name = "Unavailable space";
+		tmp_res->start = start;
+		tmp_res->end = end;
+
+		rc = insert_resource(res, tmp_res);
+		if (rc) {
+			pr_err("Cannot insert resource [%llx - %llx] %d\n",
+					tmp_res->start, tmp_res->end, rc);
+			kfree(tmp_res);
+			goto err;
+		}
+	}
+
+err:
+	kfree(regs);
+
+	return rc;
+}
+#endif
+
 static void __init xen_dt_guest_init(void)
 {
 	struct device_node *xen_node;
diff --git a/drivers/xen/Kconfig b/drivers/xen/Kconfig
index 1b2c3ac..e6031fc 100644
--- a/drivers/xen/Kconfig
+++ b/drivers/xen/Kconfig
@@ -297,7 +297,7 @@ config XEN_FRONT_PGDIR_SHBUF
 
 config XEN_UNPOPULATED_ALLOC
 	bool "Use unpopulated memory ranges for guest mappings"
-	depends on X86 && ZONE_DEVICE
+	depends on ZONE_DEVICE
 	default XEN_BACKEND || XEN_GNTDEV || XEN_DOM0
 	help
 	  Use unpopulated memory ranges in order to create mappings for guest
-- 
2.7.4



From xen-devel-bounces@lists.xenproject.org Tue Oct 26 16:08:24 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Oct 2021 16:08:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.216525.376162 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfOzw-0002zh-J4; Tue, 26 Oct 2021 16:08:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 216525.376162; Tue, 26 Oct 2021 16:08:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfOzw-0002za-Fu; Tue, 26 Oct 2021 16:08:24 +0000
Received: by outflank-mailman (input) for mailman id 216525;
 Tue, 26 Oct 2021 16:08:23 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=gydQ=PO=gmail.com=olekstysh@srs-us1.protection.inumbo.net>)
 id 1mfOzu-0002xh-VM
 for xen-devel@lists.xenproject.org; Tue, 26 Oct 2021 16:08:22 +0000
Received: from mail-ed1-x52a.google.com (unknown [2a00:1450:4864:20::52a])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 43f52045-a0c7-41f1-a812-8143ae00020a;
 Tue, 26 Oct 2021 16:08:20 +0000 (UTC)
Received: by mail-ed1-x52a.google.com with SMTP id w12so9829486edd.11
 for <xen-devel@lists.xenproject.org>; Tue, 26 Oct 2021 09:08:20 -0700 (PDT)
Received: from otyshchenko.router ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id eu9sm4025195ejc.14.2021.10.26.09.05.18
 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
 Tue, 26 Oct 2021 09:05:19 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 43f52045-a0c7-41f1-a812-8143ae00020a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id;
        bh=bAVBWRDZRgubnRSuBYCl4clj0aVWREQm4G5cX+KG1p4=;
        b=IRDZVkn1hy6HTn6NCAY05VCjxdq5sZSzZ/zhkxVxmJgo79/McEOL3/iJ/d1r//8JgI
         35NahJ8ril6M+lshDWp+3AU6poeOYlGjmAXVxV0JB2UQL7Ghwxjz0h0vXbMxSRi3nhiv
         xwxv03QLNDivyn9pXc3PkfJSCC6JURlI+0JbfKbO1J8bMFt2GGA5kOsgNU/HTwVxY80e
         9OfKFDdZSXoFBP4DwuPaGMAnk0jS7qW24jrn7NgJDPscT59nn5Lffb/EvmJKmH2fJObN
         kWg+uYQvl2aryBOblgagD4nMXooTtyuPn5IHQ4xv843vNj1zyR3C10vYR4P6CImPG352
         f1Tg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id;
        bh=bAVBWRDZRgubnRSuBYCl4clj0aVWREQm4G5cX+KG1p4=;
        b=0i78pUflsEl7pzlfxFPdStbsQrVL6kr8arez70EYJwWG3nQVY2kTn2tZhD5bm7BazM
         UlYcg/Dd2taH1LPdynCca96AyONRJzKlcwqRr+vQ129Zvs6VkvEiOYzpsV8zcLg3EB90
         9PcDULkZw6KiI2oScNAn24erFZtq/vOXT4eGgpd85WEZq24wPx5s3fxmGNWluMGiEGa8
         Bk0ges2X2v7WcS+q9VFPpns+EvWAHvNJUbgiKliFuf7RCN4vx12VL7Lin5RsaFXSht9B
         8ZGMyJ8r+ZfbsSkeT7JQaj/N4ay1w4VI9ArQMokZfwn7wyggojuMJMj53OAcNfX2W73S
         QKzg==
X-Gm-Message-State: AOAM530EZfAsdexRZswoa7mzfgetOhCm1epuZGf5dToBkWREpctYcw1y
	PC+whj9HcTX9jqiQire4uNjau3HI0Iw=
X-Google-Smtp-Source: ABdhPJxtMgA2kyKQC10zrMOP8KtcHqswMqEj2qKkSjTogokVg/wr2Px2E1gCaIw0gu0zlXxwCQNP+g==
X-Received: by 2002:a17:907:76cc:: with SMTP id kf12mr18527547ejc.228.1635264319752;
        Tue, 26 Oct 2021 09:05:19 -0700 (PDT)
From: Oleksandr Tyshchenko <olekstysh@gmail.com>
To: xen-devel@lists.xenproject.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Russell King <linux@armlinux.org.uk>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Julien Grall <julien@xen.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Wei Chen <Wei.Chen@arm.com>,
	Henry Wang <Henry.Wang@arm.com>
Subject: [PATCH V2 0/4] xen: Add support of extended regions (safe ranges) on Arm
Date: Tue, 26 Oct 2021 19:05:08 +0300
Message-Id: <1635264312-3796-1-git-send-email-olekstysh@gmail.com>
X-Mailer: git-send-email 2.7.4

From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>

You can find the RFC patch series at [1].

The corresponding Xen support (for both Dom0 and DomU) is already committed and
is available in mainline Xen since the following commit:
57f87857dc2de452a796d6bad4f476510efd2aba libxl/arm: Add handling of extended regions for DomU

The extended region (safe range) is a region of guest physical address space
which is unused and could be safely used to create grant/foreign mappings instead
of ballooning out real RAM pages to obtain a physical address space for creating
these mappings (which simply results in wasting domain memory and shattering super
pages in P2M table).

The problem is that we cannot follow Linux advise which memory ranges are unused
on Arm as there might be some identity mappings in P2M table (stage 2) the guest is not
aware of or not all device I/O regions might be known (registered) by the time the guest
starts creating grant/foreign mappings. This is why we need some hints from the hypervisor
which knows all details in advance to be able to choose extended regions (which won't
clash with other resources).

The extended regions are chosen at the domain creation time and advertised to it via
"reg" property under hypervisor node in the guest device-tree [2]. As region 0 is reserved
for grant table space (always present), the indexes for extended regions are 1...N.
No device tree bindings update is needed, guest infers the presence of extended regions
from the number of regions in "reg" property.
    
Please note the following:
- The ACPI case is not covered for now
- patch series was created in a way to retain existing behavior on x86

The patch series is based on v5.15-rc7 and also available at [3], it was fully
tested on Arm64 and only compile tested on x86.

[1] https://lore.kernel.org/all/1627490656-1267-1-git-send-email-olekstysh@gmail.com/
    https://lore.kernel.org/all/1627490656-1267-2-git-send-email-olekstysh@gmail.com/

[2] https://xenbits.xen.org/gitweb/?p=xen.git;a=blob_plain;f=docs/misc/arm/device-tree/guest.txt;hb=refs/heads/master

[3] https://github.com/otyshchenko1/linux/commits/map_opt_ml5

Oleksandr Tyshchenko (4):
  xen/unpopulated-alloc: Drop check for virt_addr_valid() in fill_list()
  arm/xen: Switch to use gnttab_setup_auto_xlat_frames() for DT
  xen/unpopulated-alloc: Add mechanism to use Xen resource
  arm/xen: Read extended regions from DT and init Xen resource

 arch/arm/xen/enlighten.c        | 144 ++++++++++++++++++++++++++++++++++++++--
 drivers/xen/Kconfig             |   2 +-
 drivers/xen/unpopulated-alloc.c |  90 +++++++++++++++++++++++--
 include/xen/xen.h               |   2 +
 4 files changed, 226 insertions(+), 12 deletions(-)

-- 
2.7.4



From xen-devel-bounces@lists.xenproject.org Tue Oct 26 16:09:02 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Oct 2021 16:09:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.216530.376173 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfP0X-0003bw-Rn; Tue, 26 Oct 2021 16:09:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 216530.376173; Tue, 26 Oct 2021 16:09:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfP0X-0003bp-Og; Tue, 26 Oct 2021 16:09:01 +0000
Received: by outflank-mailman (input) for mailman id 216530;
 Tue, 26 Oct 2021 16:09:00 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=gydQ=PO=gmail.com=olekstysh@srs-us1.protection.inumbo.net>)
 id 1mfP0W-0003bh-LI
 for xen-devel@lists.xenproject.org; Tue, 26 Oct 2021 16:09:00 +0000
Received: from mail-ed1-x52e.google.com (unknown [2a00:1450:4864:20::52e])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 67cf74b4-1946-45ed-bd74-b4d35ecfedcc;
 Tue, 26 Oct 2021 16:08:59 +0000 (UTC)
Received: by mail-ed1-x52e.google.com with SMTP id g8so14517461edb.2
 for <xen-devel@lists.xenproject.org>; Tue, 26 Oct 2021 09:08:59 -0700 (PDT)
Received: from otyshchenko.router ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id eu9sm4025195ejc.14.2021.10.26.09.05.20
 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
 Tue, 26 Oct 2021 09:05:20 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 67cf74b4-1946-45ed-bd74-b4d35ecfedcc
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references;
        bh=LFIfrPhDzMtnbpEZVPATV5Kch9wCoKpxpC7Ie87gFbI=;
        b=bs16QmQOkeJH5M96StGB5D0kKi6yFSOn6Bb9Z1JxuWPs8n7m9DKoVvOrnj02v/zFzP
         xDOoHIzz+zeajJzCemByRC4cUhlUVLJVjRbHpcKMUnYABP7tE+tsTgFM1I0SHu8abRc8
         ODiLRcwwLBdfek+yo1znmX1Q9TEwfSC5fNtbn5wv1OaBbxTqRsgloUZ+TK0SbXmiGJc6
         G1GHBYDlnnzrXk8efngJ4GTPAToixurpJzxE7zWSYia37K7y1+/QPLPRYdE4AahOmGMH
         lbGNyaSdDwcEo4G2rc2sREnoAaA4RLoLBKyH/sIz8xNUN6PVFS8Z3UgSMF4X9vhzAjci
         1gnw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references;
        bh=LFIfrPhDzMtnbpEZVPATV5Kch9wCoKpxpC7Ie87gFbI=;
        b=iD7GNzZ9J4CcCOT7uKlTaknL4TGo9QEkv8fHTRCNXlueRUp7b3NYP98zjpcwm8rKqM
         7/OQ6N+U+AcOWmjkYaLQtOimo1Vg0q9yJS+UC/A3YPM+83LHdJ5dhKYOVkan9rJ5GLA3
         q1rbADx/HvaOypkCZ7GZjJl+iHmDZG0aFiW7iP/s6y2hOXv0Tmq+ifLCLLBWBxNy1drC
         Oy/Jf93t+hKpqxzouB2Qc7ilkfs4b/DBm1ABNBoiCOzmgAXHyMMJDTJx7DbDSr01RmtN
         bzIqI3Rq0xuAn6IaJatfea/6/9PZUbAWzm3JW+klCHf4nryFVDhwNUPKdhcETnXC2IYg
         YZ2g==
X-Gm-Message-State: AOAM5324Bq1qG31LYgn8t9hRwJg++0X139thanw3upylCuislM8VHTaS
	ihg3xdyjPHSLBJPz2moDQWOQkuiHnwQ=
X-Google-Smtp-Source: ABdhPJyDWvPDbHKN80B2wI0HUdKZkTQtxYSe3AhrmMT52rr89emWm0qnYTKAFM1mwoDlbefou8hA/Q==
X-Received: by 2002:a05:6402:486:: with SMTP id k6mr11970130edv.315.1635264321080;
        Tue, 26 Oct 2021 09:05:21 -0700 (PDT)
From: Oleksandr Tyshchenko <olekstysh@gmail.com>
To: xen-devel@lists.xenproject.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Russell King <linux@armlinux.org.uk>,
	Julien Grall <julien@xen.org>
Subject: [PATCH V2 2/4] arm/xen: Switch to use gnttab_setup_auto_xlat_frames() for DT
Date: Tue, 26 Oct 2021 19:05:10 +0300
Message-Id: <1635264312-3796-3-git-send-email-olekstysh@gmail.com>
X-Mailer: git-send-email 2.7.4
In-Reply-To: <1635264312-3796-1-git-send-email-olekstysh@gmail.com>
References: <1635264312-3796-1-git-send-email-olekstysh@gmail.com>

From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>

Read the start address of the grant table space from DT
(region 0).

This patch mostly restores behaviour before commit 3cf4095d7446
("arm/xen: Use xen_xlate_map_ballooned_pages to setup grant table")
but trying not to break the ACPI support added after that commit.
So the patch touches DT part only and leaves the ACPI part with
xen_xlate_map_ballooned_pages().

This is a preparation for using Xen extended region feature
where unused regions of guest physical address space (provided
by the hypervisor) will be used to create grant/foreign/whatever
mappings instead of wasting real RAM pages from the domain memory
for establishing these mappings.

The immediate benefit of this change:
- Avoid superpage shattering in Xen P2M when establishing
  stage-2 mapping (GFN <-> MFN) for the grant table space
- Avoid wasting real RAM pages (reducing the amount of memory
  usuable) for mapping grant table space
- The grant table space is always mapped at the exact
  same place (region 0 is reserved for the grant table)

Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
---
Changes RFC -> V2:
   - new patch
---
 arch/arm/xen/enlighten.c | 32 +++++++++++++++++++++++++-------
 1 file changed, 25 insertions(+), 7 deletions(-)

diff --git a/arch/arm/xen/enlighten.c b/arch/arm/xen/enlighten.c
index 7f1c106b..dea46ec 100644
--- a/arch/arm/xen/enlighten.c
+++ b/arch/arm/xen/enlighten.c
@@ -59,6 +59,9 @@ unsigned long xen_released_pages;
 struct xen_memory_region xen_extra_mem[XEN_EXTRA_MEM_MAX_REGIONS] __initdata;
 
 static __read_mostly unsigned int xen_events_irq;
+static phys_addr_t xen_grant_frames;
+
+#define GRANT_TABLE_INDEX   0
 
 uint32_t xen_start_flags;
 EXPORT_SYMBOL(xen_start_flags);
@@ -303,6 +306,7 @@ static void __init xen_acpi_guest_init(void)
 static void __init xen_dt_guest_init(void)
 {
 	struct device_node *xen_node;
+	struct resource res;
 
 	xen_node = of_find_compatible_node(NULL, NULL, "xen,xen");
 	if (!xen_node) {
@@ -310,6 +314,12 @@ static void __init xen_dt_guest_init(void)
 		return;
 	}
 
+	if (of_address_to_resource(xen_node, GRANT_TABLE_INDEX, &res)) {
+		pr_err("Xen grant table region is not found\n");
+		return;
+	}
+	xen_grant_frames = res.start;
+
 	xen_events_irq = irq_of_parse_and_map(xen_node, 0);
 }
 
@@ -317,16 +327,20 @@ static int __init xen_guest_init(void)
 {
 	struct xen_add_to_physmap xatp;
 	struct shared_info *shared_info_page = NULL;
-	int cpu;
+	int rc, cpu;
 
 	if (!xen_domain())
 		return 0;
 
 	if (!acpi_disabled)
 		xen_acpi_guest_init();
-	else
+	else {
 		xen_dt_guest_init();
 
+		if (!xen_grant_frames)
+			return -ENODEV;
+	}
+
 	if (!xen_events_irq) {
 		pr_err("Xen event channel interrupt not found\n");
 		return -ENODEV;
@@ -370,12 +384,16 @@ static int __init xen_guest_init(void)
 	for_each_possible_cpu(cpu)
 		per_cpu(xen_vcpu_id, cpu) = cpu;
 
-	xen_auto_xlat_grant_frames.count = gnttab_max_grant_frames();
-	if (xen_xlate_map_ballooned_pages(&xen_auto_xlat_grant_frames.pfn,
-					  &xen_auto_xlat_grant_frames.vaddr,
-					  xen_auto_xlat_grant_frames.count)) {
+	if (!acpi_disabled) {
+		xen_auto_xlat_grant_frames.count = gnttab_max_grant_frames();
+		rc = xen_xlate_map_ballooned_pages(&xen_auto_xlat_grant_frames.pfn,
+										   &xen_auto_xlat_grant_frames.vaddr,
+										   xen_auto_xlat_grant_frames.count);
+	} else
+		rc = gnttab_setup_auto_xlat_frames(xen_grant_frames);
+	if (rc) {
 		free_percpu(xen_vcpu_info);
-		return -ENOMEM;
+		return rc;
 	}
 	gnttab_init();
 
-- 
2.7.4



From xen-devel-bounces@lists.xenproject.org Tue Oct 26 16:09:21 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Oct 2021 16:09:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.216532.376184 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfP0r-00046L-4g; Tue, 26 Oct 2021 16:09:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 216532.376184; Tue, 26 Oct 2021 16:09:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfP0r-00046C-1b; Tue, 26 Oct 2021 16:09:21 +0000
Received: by outflank-mailman (input) for mailman id 216532;
 Tue, 26 Oct 2021 16:09:19 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=gydQ=PO=gmail.com=olekstysh@srs-us1.protection.inumbo.net>)
 id 1mfP0p-00044Y-RE
 for xen-devel@lists.xenproject.org; Tue, 26 Oct 2021 16:09:19 +0000
Received: from mail-ed1-x52e.google.com (unknown [2a00:1450:4864:20::52e])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 55fdda75-b496-4e7c-a0d1-49ce389de717;
 Tue, 26 Oct 2021 16:09:18 +0000 (UTC)
Received: by mail-ed1-x52e.google.com with SMTP id w15so15349871edc.9
 for <xen-devel@lists.xenproject.org>; Tue, 26 Oct 2021 09:09:18 -0700 (PDT)
Received: from otyshchenko.router ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id eu9sm4025195ejc.14.2021.10.26.09.05.21
 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
 Tue, 26 Oct 2021 09:05:21 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 55fdda75-b496-4e7c-a0d1-49ce389de717
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references;
        bh=ajewXwLh6uwl+3oBu0hbZUbC19wx0AYb/I/F6COPjeM=;
        b=U3N/q9FFvFCmmrpMt2cjbyrZGTWLI8aYWMuWlxVKon2BNKrVOdefe0pZcid+IOAgdh
         IHy6lv/3TRCGg/Iqh7kmoF4Fg4rHa+NqfAzaz9wRaL6CVBUvECbpOFAZU6RJESEkB98/
         Y5I9Oq4rdHccg0GEvwvD4whjflY43q2BjErpYMUBRbu2Lwf235S4qZ7o16ywxoHfpuxR
         gx0iLhzdsYDcnbF20A2x+L0EFGx8biMJmfAr6ix03XlJ+JOMk21G6/ZtFcdflkylF4KG
         uXX49KX7gu0kYMlocuPThS66RnoOFnmwRXxDBNs5db/f6mKW8ocFNgIKUqNmy+spVuvX
         O8Dg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references;
        bh=ajewXwLh6uwl+3oBu0hbZUbC19wx0AYb/I/F6COPjeM=;
        b=EnLwzEueyJnZ75/e9Jeppm2GSc2emB2/KFKqGKEGMY0q3wFy0n6BgR6P/dOAdb6KdY
         BFPIVpqvNyahbUwbHnzyZ70EDeoNeFLlHujjhMwzBfsKULPS35+d4/wSclq9M6okwSyv
         3U0Yjbzn/FKAas1T8U4Hpm78Vsx1+199XKU1iLLSywndtcRV84xYL3J2CJNw51j/EJYN
         8SUUxucipdvH9Q/5m7LUFhDOWx2GeZ9yq3TPLJquzg2DiEVkHH2xOM10+hVpaLene+HN
         Nxt3I75Lm/mhC6pxdkJ4msE2zbK/jg62rTeNXGUv8whaUartQdXT/2wyC8CcuZQdMKBa
         3vkg==
X-Gm-Message-State: AOAM531wAKnK39rOE8RNL1qhqkFal5JtI6lLY8+ZTmOW0zFnCeFreAFx
	P/WqcEuvvfS5ma7gOAu86S1yGghQ36M=
X-Google-Smtp-Source: ABdhPJyrh0WP1ZENmH/Ydn3rieWDW8GYW8YWGEy1yCC5roMzqs86ACi1TObo2NcZ97xR3N7TTReTvQ==
X-Received: by 2002:a05:6402:2808:: with SMTP id h8mr36760367ede.394.1635264321764;
        Tue, 26 Oct 2021 09:05:21 -0700 (PDT)
From: Oleksandr Tyshchenko <olekstysh@gmail.com>
To: xen-devel@lists.xenproject.org,
	linux-kernel@vger.kernel.org
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>
Subject: [PATCH V2 3/4] xen/unpopulated-alloc: Add mechanism to use Xen resource
Date: Tue, 26 Oct 2021 19:05:11 +0300
Message-Id: <1635264312-3796-4-git-send-email-olekstysh@gmail.com>
X-Mailer: git-send-email 2.7.4
In-Reply-To: <1635264312-3796-1-git-send-email-olekstysh@gmail.com>
References: <1635264312-3796-1-git-send-email-olekstysh@gmail.com>

From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>

The main reason of this change is that unpopulated-alloc
code cannot be used in its current form on Arm, but there
is a desire to reuse it to avoid wasting real RAM pages
for the grant/foreign mappings.

The problem is that system "iomem_resource" is used for
the address space allocation, but the really unallocated
space can't be figured out precisely by the domain on Arm
without hypervisor involvement. For example, not all device
I/O regions are known by the time domain starts creating
grant/foreign mappings. And following the advise from
"iomem_resource" we might end up reusing these regions by
a mistake. So, the hypervisor which maintains the P2M for
the domain is in the best position to provide unused regions
of guest physical address space which could be safely used
to create grant/foreign mappings.

Introduce new helper arch_xen_unpopulated_init() which purpose
is to create specific Xen resource based on the memory regions
provided by the hypervisor to be used as unused space for Xen
scratch pages.

If arch doesn't implement arch_xen_unpopulated_init() to
initialize Xen resource the default "iomem_resource" will be used.
So the behavior on x86 won't be changed.

Also fall back to allocate xenballooned pages (steal real RAM
pages) if we do not have any suitable resource to work with and
as the result we won't be able to provide unpopulated pages.

Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
---
Changes RFC -> V2:
   - new patch, instead of
    "[RFC PATCH 2/2] xen/unpopulated-alloc: Query hypervisor to provide unallocated space"
---
 drivers/xen/unpopulated-alloc.c | 89 +++++++++++++++++++++++++++++++++++++++--
 include/xen/xen.h               |  2 +
 2 files changed, 88 insertions(+), 3 deletions(-)

diff --git a/drivers/xen/unpopulated-alloc.c b/drivers/xen/unpopulated-alloc.c
index a03dc5b..1f1d8d8 100644
--- a/drivers/xen/unpopulated-alloc.c
+++ b/drivers/xen/unpopulated-alloc.c
@@ -8,6 +8,7 @@
 
 #include <asm/page.h>
 
+#include <xen/balloon.h>
 #include <xen/page.h>
 #include <xen/xen.h>
 
@@ -15,13 +16,29 @@ static DEFINE_MUTEX(list_lock);
 static struct page *page_list;
 static unsigned int list_count;
 
+static struct resource *target_resource;
+static struct resource xen_resource = {
+	.name = "Xen unused space",
+};
+
+/*
+ * If arch is not happy with system "iomem_resource" being used for
+ * the region allocation it can provide it's own view by initializing
+ * "xen_resource" with unused regions of guest physical address space
+ * provided by the hypervisor.
+ */
+int __weak arch_xen_unpopulated_init(struct resource *res)
+{
+	return -ENOSYS;
+}
+
 static int fill_list(unsigned int nr_pages)
 {
 	struct dev_pagemap *pgmap;
-	struct resource *res;
+	struct resource *res, *tmp_res = NULL;
 	void *vaddr;
 	unsigned int i, alloc_pages = round_up(nr_pages, PAGES_PER_SECTION);
-	int ret = -ENOMEM;
+	int ret;
 
 	res = kzalloc(sizeof(*res), GFP_KERNEL);
 	if (!res)
@@ -30,7 +47,7 @@ static int fill_list(unsigned int nr_pages)
 	res->name = "Xen scratch";
 	res->flags = IORESOURCE_MEM | IORESOURCE_BUSY;
 
-	ret = allocate_resource(&iomem_resource, res,
+	ret = allocate_resource(target_resource, res,
 				alloc_pages * PAGE_SIZE, 0, -1,
 				PAGES_PER_SECTION * PAGE_SIZE, NULL, NULL);
 	if (ret < 0) {
@@ -38,6 +55,31 @@ static int fill_list(unsigned int nr_pages)
 		goto err_resource;
 	}
 
+	/*
+	 * Reserve the region previously allocated from Xen resource to avoid
+	 * re-using it by someone else.
+	 */
+	if (target_resource != &iomem_resource) {
+		tmp_res = kzalloc(sizeof(*tmp_res), GFP_KERNEL);
+		if (!res) {
+			ret = -ENOMEM;
+			goto err_insert;
+		}
+
+		tmp_res->name = res->name;
+		tmp_res->start = res->start;
+		tmp_res->end = res->end;
+		tmp_res->flags = res->flags;
+
+		ret = insert_resource(&iomem_resource, tmp_res);
+		if (ret < 0) {
+			pr_err("Cannot insert IOMEM resource [%llx - %llx]\n",
+			       tmp_res->start, tmp_res->end);
+			kfree(tmp_res);
+			goto err_insert;
+		}
+	}
+
 	pgmap = kzalloc(sizeof(*pgmap), GFP_KERNEL);
 	if (!pgmap) {
 		ret = -ENOMEM;
@@ -95,12 +137,40 @@ static int fill_list(unsigned int nr_pages)
 err_memremap:
 	kfree(pgmap);
 err_pgmap:
+	if (tmp_res) {
+		release_resource(tmp_res);
+		kfree(tmp_res);
+	}
+err_insert:
 	release_resource(res);
 err_resource:
 	kfree(res);
 	return ret;
 }
 
+static void unpopulated_init(void)
+{
+	static bool inited = false;
+	int ret;
+
+	if (inited)
+		return;
+
+	/*
+	 * Try to initialize Xen resource the first and fall back to default
+	 * resource if arch doesn't offer one.
+	 */
+	ret = arch_xen_unpopulated_init(&xen_resource);
+	if (!ret)
+		target_resource = &xen_resource;
+	else if (ret == -ENOSYS)
+		target_resource = &iomem_resource;
+	else
+		pr_err("Cannot initialize Xen resource\n");
+
+	inited = true;
+}
+
 /**
  * xen_alloc_unpopulated_pages - alloc unpopulated pages
  * @nr_pages: Number of pages
@@ -112,6 +182,16 @@ int xen_alloc_unpopulated_pages(unsigned int nr_pages, struct page **pages)
 	unsigned int i;
 	int ret = 0;
 
+	unpopulated_init();
+
+	/*
+	 * Fall back to default behavior if we do not have any suitable resource
+	 * to allocate required region from and as the result we won't be able to
+	 * construct pages.
+	 */
+	if (!target_resource)
+		return alloc_xenballooned_pages(nr_pages, pages);
+
 	mutex_lock(&list_lock);
 	if (list_count < nr_pages) {
 		ret = fill_list(nr_pages - list_count);
@@ -159,6 +239,9 @@ void xen_free_unpopulated_pages(unsigned int nr_pages, struct page **pages)
 {
 	unsigned int i;
 
+	if (!target_resource)
+		return free_xenballooned_pages(nr_pages, pages);
+
 	mutex_lock(&list_lock);
 	for (i = 0; i < nr_pages; i++) {
 		pages[i]->zone_device_data = page_list;
diff --git a/include/xen/xen.h b/include/xen/xen.h
index 43efba0..55d2ef8 100644
--- a/include/xen/xen.h
+++ b/include/xen/xen.h
@@ -55,6 +55,8 @@ extern u64 xen_saved_max_mem_size;
 #ifdef CONFIG_XEN_UNPOPULATED_ALLOC
 int xen_alloc_unpopulated_pages(unsigned int nr_pages, struct page **pages);
 void xen_free_unpopulated_pages(unsigned int nr_pages, struct page **pages);
+struct resource;
+int arch_xen_unpopulated_init(struct resource *res);
 #else
 #define xen_alloc_unpopulated_pages alloc_xenballooned_pages
 #define xen_free_unpopulated_pages free_xenballooned_pages
-- 
2.7.4



From xen-devel-bounces@lists.xenproject.org Tue Oct 26 16:29:06 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Oct 2021 16:29:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.216552.376201 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfPJh-0006kY-T5; Tue, 26 Oct 2021 16:28:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 216552.376201; Tue, 26 Oct 2021 16:28:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfPJh-0006kR-P3; Tue, 26 Oct 2021 16:28:49 +0000
Received: by outflank-mailman (input) for mailman id 216552;
 Tue, 26 Oct 2021 16:28:48 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mfPJg-0006js-JU
 for xen-devel@lists.xenproject.org; Tue, 26 Oct 2021 16:28:48 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mfPJg-0004fJ-1v; Tue, 26 Oct 2021 16:28:48 +0000
Received: from [54.239.6.189] (helo=[10.85.97.81])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mfPJf-0004uu-Rm; Tue, 26 Oct 2021 16:28:47 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=Bx6kGXQIsK0qjZ+q2P/KQ6fNZkeu0jChjmrlYC7CoC0=; b=1bRM97NQIsT4qqt1f3PVisLPAO
	h5hFBmKwYG2tv4/TyIg/5D22QpsqEdWoe8SJYFbdXb62gHihBRZuG9iWe1pMXOg5hEkf3jGKsr9GE
	PijrUSO7Vkshl1/w2XIMZ4XjirGVD8Rn0lSLXw29xVxjBhQuRAFdFNunUs6JmC9KAHYA=;
Message-ID: <e5632a4e-db98-41b4-1045-2b3532c098fa@xen.org>
Date: Tue, 26 Oct 2021 17:28:45 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.2.1
Subject: Re: [patch-4.16] arm/smmuv1,v2: Protect smmu master list with a lock
To: Michal Orzel <michal.orzel@arm.com>, xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, bertrand.marquis@arm.com,
 Ian Jackson <iwj@xenproject.org>
References: <20211026122903.15042-1-michal.orzel@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20211026122903.15042-1-michal.orzel@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Michal,

On 26/10/2021 13:29, Michal Orzel wrote:
> If a device is added to SMMUv1/v2 from DT and PCI
> at the same time, there is a concurrent access
> to a smmu master list. This could lead to a
> scenario where one is looking into a list that
> is being modified at the same time. Add a lock
> to prevent this issue.

Did you intend to say "Hold" rather than "Add"?

> 
> Reuse the existing spinlock arm_smmu_devices_lock
> as it is already protecting find_smmu_master.
> 
> ipmmu-smmu and smmuv3 are not impacted by this
> issue as there is no access or modification of
> a global resource during add_device.
> 
> Signed-off-by: Michal Orzel <michal.orzel@arm.com>
> ---
> This patch aims for 4.16 release.
> Benefits:
> Remove a bug that could lead to a corruption of the
> smmu master list, which would be very hard to debug.

 From my understanding, this corruption would only happen with 
CONFIG_HAS_PCI. At the moment, this is a experimental feature as it is 
not fully complete.

> Risks:
> Overall the risk is low as we are touching init code
> rather than a runtime one. In case of any issue, the
> problem would be catched during system boot or guest
> start.

With the PCI feature enabled, this can be called at runtime as this 
plumbed through a PHYSDEVOP. That said, it doesn't matter here as for 
supported code (platform/DT device), this will only happen during boot.

The patch looks straighforward, so I would not mind to have it in Xen 
4.16. Ian, what do you think?

> ---
>   xen/drivers/passthrough/arm/smmu.c | 25 +++++++++++++++++++------
>   1 file changed, 19 insertions(+), 6 deletions(-)
> 
> diff --git a/xen/drivers/passthrough/arm/smmu.c b/xen/drivers/passthrough/arm/smmu.c
> index c9dfc4caa0..be62a66a28 100644
> --- a/xen/drivers/passthrough/arm/smmu.c
> +++ b/xen/drivers/passthrough/arm/smmu.c
> @@ -820,21 +820,25 @@ static int arm_smmu_dt_add_device_legacy(struct arm_smmu_device *smmu,
>   					 struct device *dev,
>   					 struct iommu_fwspec *fwspec)
>   {
> -	int i;
> +	int i, ret;
>   	struct arm_smmu_master *master;
>   	struct device_node *dev_node = dev_get_dev_node(dev);
>   
> +	spin_lock(&arm_smmu_devices_lock);
>   	master = find_smmu_master(smmu, dev_node);
>   	if (master) {
>   		dev_err(dev,
>   			"rejecting multiple registrations for master device %s\n",
>   			dev_node->name);
> -		return -EBUSY;
> +		ret = -EBUSY;
> +		goto out_unlock;
>   	}
>   
>   	master = devm_kzalloc(dev, sizeof(*master), GFP_KERNEL);
> -	if (!master)
> -		return -ENOMEM;
> +	if (!master) {
> +		ret = -ENOMEM;
> +		goto out_unlock;
> +	}
>   	master->of_node = dev_node;
>   
>   	/* Xen: Let Xen know that the device is protected by an SMMU */
> @@ -846,11 +850,17 @@ static int arm_smmu_dt_add_device_legacy(struct arm_smmu_device *smmu,
>   			dev_err(dev,
>   				"stream ID for master device %s greater than maximum allowed (%d)\n",
>   				dev_node->name, smmu->num_mapping_groups);
> -			return -ERANGE;
> +			ret = -ERANGE;
> +			goto out_unlock;
>   		}
>   		master->cfg.smendx[i] = INVALID_SMENDX;
>   	}
> -	return insert_smmu_master(smmu, master);
> +
> +	ret = insert_smmu_master(smmu, master);
> +
> +out_unlock:
> +	spin_unlock(&arm_smmu_devices_lock);

Please add a newline here.

> +	return ret;
>   }
>   
>   static int register_smmu_master(struct arm_smmu_device *smmu,
> @@ -2056,7 +2066,10 @@ static int arm_smmu_add_device(struct device *dev)
>   	} else {
>   		struct arm_smmu_master *master;
>   
> +		spin_lock(&arm_smmu_devices_lock);
>   		master = find_smmu_master(smmu, dev->of_node);
> +		spin_unlock(&arm_smmu_devices_lock);

At the moment, unlocking here is fine because we don't remove the 
device. However, there are a series to supporting removing a device (see 
[1]). So I think it would be preferable to unlock after the last use of 
'cfg'.

Looking at the code, I also noticed that the error path is not correct 
for at least the PCI device and we would leak memory. We also assume 
that Stream ID == Requester ID. Are both of them in your radar for PCI 
passthrough?

Cheers,

[1] 
https://lore.kernel.org/xen-devel/1630562763-390068-9-git-send-email-fnu.vikram@xilinx.com/

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Tue Oct 26 16:56:55 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Oct 2021 16:56:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.216561.376212 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfPkm-0001Sa-32; Tue, 26 Oct 2021 16:56:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 216561.376212; Tue, 26 Oct 2021 16:56:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfPkm-0001ST-03; Tue, 26 Oct 2021 16:56:48 +0000
Received: by outflank-mailman (input) for mailman id 216561;
 Tue, 26 Oct 2021 16:56:46 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mfPkk-0001SN-Ef
 for xen-devel@lists.xenproject.org; Tue, 26 Oct 2021 16:56:46 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mfPkk-00057y-1R; Tue, 26 Oct 2021 16:56:46 +0000
Received: from [54.239.6.189] (helo=[10.85.97.81])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mfPkj-0002jq-RW; Tue, 26 Oct 2021 16:56:45 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:
	References:Cc:To:From:Subject:MIME-Version:Date:Message-ID;
	bh=59yi+WS+p0zMmSkqI7y+44DDNHZV/+RwB8vCTdbg6Pc=; b=6/gU5Cw9vlfrn9R6UZ/wSoTJX+
	YcG7LifSt1aHUTO+mg505f0vLeZMzHhcmXZybbaweI6jV96FWwx739tLs1oDh0Z5vZe9/qENE05cN
	jlSoYsxq88hMKShExoy7ej0sCPuefNvmV+/qeoetT5K3RF57gVWucBujeiHKEQqPWCew=;
Message-ID: <70c30a6c-b779-805e-079a-41bb484894b9@xen.org>
Date: Tue, 26 Oct 2021 17:56:43 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.2.1
Subject: Re: [patch-4.16] arm/smmuv1,v2: Protect smmu master list with a lock
From: Julien Grall <julien@xen.org>
To: Michal Orzel <michal.orzel@arm.com>, xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, bertrand.marquis@arm.com,
 Ian Jackson <iwj@xenproject.org>
References: <20211026122903.15042-1-michal.orzel@arm.com>
 <e5632a4e-db98-41b4-1045-2b3532c098fa@xen.org>
In-Reply-To: <e5632a4e-db98-41b4-1045-2b3532c098fa@xen.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi,

On 26/10/2021 17:28, Julien Grall wrote:
> On 26/10/2021 13:29, Michal Orzel wrote:
>> If a device is added to SMMUv1/v2 from DT and PCI
>> at the same time, there is a concurrent access
>> to a smmu master list. This could lead to a
>> scenario where one is looking into a list that
>> is being modified at the same time. Add a lock
>> to prevent this issue.
> 
> Did you intend to say "Hold" rather than "Add"?
> 
>>
>> Reuse the existing spinlock arm_smmu_devices_lock
>> as it is already protecting find_smmu_master.
>>
>> ipmmu-smmu and smmuv3 are not impacted by this
>> issue as there is no access or modification of
>> a global resource during add_device.
>>
>> Signed-off-by: Michal Orzel <michal.orzel@arm.com>
>> ---
>> This patch aims for 4.16 release.
>> Benefits:
>> Remove a bug that could lead to a corruption of the
>> smmu master list, which would be very hard to debug.
> 
>  From my understanding, this corruption would only happen with 
> CONFIG_HAS_PCI. At the moment, this is a experimental feature as it is 
> not fully complete.

Actually, digging through the code, I noticed that iommu_add_device() 
assume that it can only be called with platform/DT. Thankfully, AFAICT, 
the function would return -ENXIO because the fwspec would not be 
allocated for PCI device.

So was this patch tested with additional patch on top?

> 
>> Risks:
>> Overall the risk is low as we are touching init code
>> rather than a runtime one. In case of any issue, the
>> problem would be catched during system boot or guest
>> start.
> 
> With the PCI feature enabled, this can be called at runtime as this 
> plumbed through a PHYSDEVOP. That said, it doesn't matter here as for 
> supported code (platform/DT device), this will only happen during boot.
> 
> The patch looks straighforward, so I would not mind to have it in Xen 
> 4.16. Ian, what do you think?
> 
>> ---
>>   xen/drivers/passthrough/arm/smmu.c | 25 +++++++++++++++++++------
>>   1 file changed, 19 insertions(+), 6 deletions(-)
>>
>> diff --git a/xen/drivers/passthrough/arm/smmu.c 
>> b/xen/drivers/passthrough/arm/smmu.c
>> index c9dfc4caa0..be62a66a28 100644
>> --- a/xen/drivers/passthrough/arm/smmu.c
>> +++ b/xen/drivers/passthrough/arm/smmu.c
>> @@ -820,21 +820,25 @@ static int arm_smmu_dt_add_device_legacy(struct 
>> arm_smmu_device *smmu,
>>                        struct device *dev,
>>                        struct iommu_fwspec *fwspec)
>>   {
>> -    int i;
>> +    int i, ret;
>>       struct arm_smmu_master *master;
>>       struct device_node *dev_node = dev_get_dev_node(dev);
>> +    spin_lock(&arm_smmu_devices_lock);
>>       master = find_smmu_master(smmu, dev_node);
>>       if (master) {
>>           dev_err(dev,
>>               "rejecting multiple registrations for master device %s\n",
>>               dev_node->name);
>> -        return -EBUSY;
>> +        ret = -EBUSY;
>> +        goto out_unlock;
>>       }
>>       master = devm_kzalloc(dev, sizeof(*master), GFP_KERNEL);
>> -    if (!master)
>> -        return -ENOMEM;
>> +    if (!master) {
>> +        ret = -ENOMEM;
>> +        goto out_unlock;
>> +    }
>>       master->of_node = dev_node;
>>       /* Xen: Let Xen know that the device is protected by an SMMU */
>> @@ -846,11 +850,17 @@ static int arm_smmu_dt_add_device_legacy(struct 
>> arm_smmu_device *smmu,
>>               dev_err(dev,
>>                   "stream ID for master device %s greater than maximum 
>> allowed (%d)\n",
>>                   dev_node->name, smmu->num_mapping_groups);
>> -            return -ERANGE;
>> +            ret = -ERANGE;
>> +            goto out_unlock;
>>           }
>>           master->cfg.smendx[i] = INVALID_SMENDX;
>>       }
>> -    return insert_smmu_master(smmu, master);
>> +
>> +    ret = insert_smmu_master(smmu, master);
>> +
>> +out_unlock:
>> +    spin_unlock(&arm_smmu_devices_lock);
> 
> Please add a newline here.
> 
>> +    return ret;
>>   }
>>   static int register_smmu_master(struct arm_smmu_device *smmu,
>> @@ -2056,7 +2066,10 @@ static int arm_smmu_add_device(struct device *dev)
>>       } else {
>>           struct arm_smmu_master *master;
>> +        spin_lock(&arm_smmu_devices_lock);
>>           master = find_smmu_master(smmu, dev->of_node);
>> +        spin_unlock(&arm_smmu_devices_lock);
> 
> At the moment, unlocking here is fine because we don't remove the 
> device. However, there are a series to supporting removing a device (see 
> [1]). So I think it would be preferable to unlock after the last use of 
> 'cfg'.
> 
> Looking at the code, I also noticed that the error path is not correct 
> for at least the PCI device and we would leak memory. We also assume 
> that Stream ID == Requester ID. Are both of them in your radar for PCI 
> passthrough?
> 
> Cheers,
> 
> [1] 
> https://lore.kernel.org/xen-devel/1630562763-390068-9-git-send-email-fnu.vikram@xilinx.com/ 
> 
> 

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Tue Oct 26 19:29:09 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Oct 2021 19:29:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.216570.376229 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfS7x-0006mU-4N; Tue, 26 Oct 2021 19:28:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 216570.376229; Tue, 26 Oct 2021 19:28:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfS7x-0006mN-1C; Tue, 26 Oct 2021 19:28:53 +0000
Received: by outflank-mailman (input) for mailman id 216570;
 Tue, 26 Oct 2021 19:28:51 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mfS7v-0006mD-UB; Tue, 26 Oct 2021 19:28:51 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mfS7v-0007eO-OF; Tue, 26 Oct 2021 19:28:51 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mfS7v-0007g0-Cr; Tue, 26 Oct 2021 19:28:51 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mfS7v-00025P-CJ; Tue, 26 Oct 2021 19:28:51 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=8+91BDQRttJ7cQmO92Cw9Z0eqQDQQiWc1UNNhXeHxVM=; b=DIz8WaFSQvx29jWYIfpkoSqWlz
	gerpCA04v/yxkg3+3wAxKqWjs8meT5UxkKAUZ5ejGXR0GT6KM4i8pZ6oaAwcKUw1//VLqMpcjkbGO
	7CZyLQFHovCiPDPOibCtuUzui+06m8QQ9qWX0IE9EwSgQyLLNzLWkMhj3cKo+Uk140UM=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165875-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 165875: tolerable FAIL
X-Osstest-Failures:
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=b0fce57a6a491c120f2554ad7cc9a0c43ee5defa
X-Osstest-Versions-That:
    xen=b0fce57a6a491c120f2554ad7cc9a0c43ee5defa
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 26 Oct 2021 19:28:51 +0000

flight 165875 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165875/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 165864
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 165864
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165864
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165864
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 165864
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 165864
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 165864
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 165864
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 165864
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 165864
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 165864
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165864
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 xen                  b0fce57a6a491c120f2554ad7cc9a0c43ee5defa
baseline version:
 xen                  b0fce57a6a491c120f2554ad7cc9a0c43ee5defa

Last test of basis   165875  2021-10-26 08:49:04 Z    0 days
Testing same since                          (not found)         0 attempts

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Published tested tree is already up to date.



From xen-devel-bounces@lists.xenproject.org Tue Oct 26 21:12:44 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Oct 2021 21:12:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.216602.376261 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfTkG-00018o-AT; Tue, 26 Oct 2021 21:12:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 216602.376261; Tue, 26 Oct 2021 21:12:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfTkG-00018h-7H; Tue, 26 Oct 2021 21:12:32 +0000
Received: by outflank-mailman (input) for mailman id 216602;
 Tue, 26 Oct 2021 21:12:30 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mfTkE-00018X-LJ; Tue, 26 Oct 2021 21:12:30 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mfTkE-000118-FP; Tue, 26 Oct 2021 21:12:30 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mfTkE-0003qD-5o; Tue, 26 Oct 2021 21:12:30 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mfTkE-00075m-5J; Tue, 26 Oct 2021 21:12:30 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=WY/OqOsO1tj8hgdqVLarx95LJlxiW6bXHfDvVcKU9Yg=; b=a42O39hpAn40yUSasCKmfNPzAp
	cc1RCLR4nB5yTwIfwmrEqtdTpXYdnDtQMTW7Qqv1h4TJsy88aoQcjMiwZtRXP6oedyMr1MHIqjPTn
	6i9j3CCUKNCIecoIsfb1rciT+F/ez2ItkGYz9A/7q097LuaKa3+7c3Czfpcgi4rpsNDY=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165877-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 165877: regressions - FAIL
X-Osstest-Failures:
    qemu-mainline:build-i386:xen-build:fail:regression
    qemu-mainline:build-i386-xsm:xen-build:fail:regression
    qemu-mainline:build-armhf:xen-build:fail:regression
    qemu-mainline:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-amd:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-pair:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-freebsd10-i386:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-freebsd10-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-coresched-i386-xl:build-check(1):blocked:nonblocking
    qemu-mainline:build-armhf-libvirt:build-check(1):blocked:nonblocking
    qemu-mainline:build-i386-libvirt:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-intel:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-shadow:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-vhd:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=c5b2f559814104f4145f8bc310f4d33c7ead8f49
X-Osstest-Versions-That:
    qemuu=50352cce138ef3b30c1cda28a4df68fff5da3202
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 26 Oct 2021 21:12:30 +0000

flight 165877 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165877/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-i386                    6 xen-build                fail REGR. vs. 165682
 build-i386-xsm                6 xen-build                fail REGR. vs. 165682
 build-armhf                   6 xen-build                fail REGR. vs. 165682

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl           1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-credit2   1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-cubietruck  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-multivcpu  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-rtds      1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-vhd       1 build-check(1)               blocked  n/a
 test-amd64-i386-qemuu-rhel6hvm-amd  1 build-check(1)               blocked n/a
 test-amd64-i386-pair          1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-freebsd10-i386  1 build-check(1)               blocked  n/a
 test-amd64-i386-freebsd10-amd64  1 build-check(1)               blocked  n/a
 test-amd64-coresched-i386-xl  1 build-check(1)               blocked  n/a
 build-armhf-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-credit1   1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-arndale   1 build-check(1)               blocked  n/a
 test-amd64-i386-qemuu-rhel6hvm-intel  1 build-check(1)             blocked n/a
 test-amd64-i386-xl            1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-pvshim     1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-qemuu-debianhvm-amd64  1 build-check(1)         blocked n/a
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow  1 build-check(1)  blocked n/a
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm  1 build-check(1)      blocked n/a
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 1 build-check(1) blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a
 test-amd64-i386-xl-qemuu-win7-amd64  1 build-check(1)              blocked n/a
 test-amd64-i386-xl-qemuu-ws16-amd64  1 build-check(1)              blocked n/a
 test-amd64-i386-xl-shadow     1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-vhd        1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-xsm        1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165682
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165682
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165682
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 qemuu                c5b2f559814104f4145f8bc310f4d33c7ead8f49
baseline version:
 qemuu                50352cce138ef3b30c1cda28a4df68fff5da3202

Last test of basis   165682  2021-10-19 21:09:14 Z    7 days
Failing since        165694  2021-10-20 18:09:12 Z    6 days   14 attempts
Testing same since   165823  2021-10-24 00:36:48 Z    2 days    6 attempts

------------------------------------------------------------
People who touched revisions under test:
  Alistair Francis <alistair.francis@wdc.com>
  Andrew Jones <drjones@redhat.com>
  Ani Sinha <ani@anisinha.ca>
  BALATON Zoltan <balaton@eik.bme.hu>
  Bin Meng <bmeng.cn@gmail.com>
  Cédric Le Goater <clg@kaod.org>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  David Gibson <david@gibson.dropbear.id.au>
  David Hildenbrand <david@redhat.com>
  Eric Auger <eric.auger@redhat.com>
  Eugenio Pérez <eperezma@redhat.com>
  Frank Chang <frank.chang@sifive.com>
  Gavin Shan <gshan@redhat.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Greg Kurz <groug@kaod.org>
  Gustavo Romero <gromero@linux.ibm.com>
  Igor Mammedov <imammedo@redhat.com>
  Jason Wang <jasowang@redhat.com>
  John Wang <wangzhiqiang02@inspur.com>
  John Wang <wangzq.jn@gmail.com>
  Laurent Vivier <laurent@vivier.eu>
  Laurent Vivier <lvivier@redhat.com>
  Luc Michel <lmichel@kalray.eu>
  Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
  Matheus Ferst <matheus.ferst@eldorado.org.br>
  Mathieu Poirier <mathieu.poirier@linaro.org>
  Michael S. Tsirkin <mst@redhat.com>
  Mingwang Li <limingwang@huawei.com>
  Oğuz Ersen <oguzersen@protonmail.com>
  Philipp Tomsich <philipp.tomsich@vrull.eu>
  Philippe Mathieu-Daudé <f4bug@amsat.org>
  Philippe Mathieu-Daudé <philmd@redhat.com>
  Richard Henderson <richard.henderson@linaro.org>
  Shuuichirou Ishii <ishii.shuuichir@fujitsu.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Thomas Huth <thuth@redhat.com>
  Tong Ho <tong.ho@xilinx.com>
  Travis Geiselbrecht <travisg@gmail.com>
  Vincent Palatin <vpalatin@rivosinc.com>
  Xueming Li <xuemingl@nvidia.com>
  Yanan Wang <wangyanan55@huawei.com>
  Yifei Jiang <jiangyifei@huawei.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               fail    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          blocked 
 test-amd64-i386-xl                                           blocked 
 test-amd64-coresched-i386-xl                                 blocked 
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  blocked 
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       blocked 
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           blocked 
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     blocked 
 test-amd64-i386-freebsd10-amd64                              blocked 
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          blocked 
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          blocked 
 test-armhf-armhf-xl-arndale                                  blocked 
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  blocked 
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  blocked 
 test-armhf-armhf-xl-cubietruck                               blocked 
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         blocked 
 test-amd64-i386-freebsd10-i386                               blocked 
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         blocked 
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                blocked 
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         blocked 
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 blocked 
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    blocked 
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     blocked 
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              blocked 
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    blocked 
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      blocked 
 test-amd64-i386-xl-vhd                                       blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 3631 lines long.)


From xen-devel-bounces@lists.xenproject.org Tue Oct 26 21:17:20 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 26 Oct 2021 21:17:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.216610.376275 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfTos-0001nf-Ue; Tue, 26 Oct 2021 21:17:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 216610.376275; Tue, 26 Oct 2021 21:17:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfTos-0001nY-R3; Tue, 26 Oct 2021 21:17:18 +0000
Received: by outflank-mailman (input) for mailman id 216610;
 Tue, 26 Oct 2021 21:17:17 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Q+Xq=PO=oderland.se=josef@srs-us1.protection.inumbo.net>)
 id 1mfTor-0001nS-Kb
 for xen-devel@lists.xenproject.org; Tue, 26 Oct 2021 21:17:17 +0000
Received: from office.oderland.com (unknown [91.201.60.5])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id eaef95f6-a11e-4d51-b727-abee67a0e147;
 Tue, 26 Oct 2021 21:17:15 +0000 (UTC)
Received: from [193.180.18.161] (port=39964 helo=[10.137.0.14])
 by office.oderland.com with esmtpsa (TLS1.2) tls
 TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2)
 (envelope-from <josef@oderland.se>)
 id 1mfToo-00AHKb-4f; Tue, 26 Oct 2021 23:17:14 +0200
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: eaef95f6-a11e-4d51-b727-abee67a0e147
Message-ID: <ad39ee7a-3c50-58c1-6e8e-e384e4d054c6@oderland.se>
Date: Tue, 26 Oct 2021 23:17:10 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:93.0) Gecko/20100101
 Thunderbird/93.0
Content-Language: en-US
From: Josef Johansson <josef@oderland.se>
To: Jason Andryuk <jandryuk@gmail.com>
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
 Bjorn Helgaas <helgaas@kernel.org>, Juergen Gross <jgross@suse.com>,
 linux-pci@vger.kernel.org, Marc Zyngier <maz@kernel.org>,
 Thomas Gleixner <tglx@linutronix.de>,
 xen-devel <xen-devel@lists.xenproject.org>
References: <90277228-cf14-0cfa-c95e-d42e7d533353@oderland.se>
 <20211025012503.33172-1-jandryuk@gmail.com>
 <CAKf6xptSbuj3VGxzed1uPx59cA_BRJY5FDHczX744rvnTHB8Lg@mail.gmail.com>
 <b76373a7-1e1d-3aae-66ba-09221c752c11@oderland.se>
Subject: Re: [PATCH] PCI/MSI: Fix masking MSI/MSI-X on Xen PV
In-Reply-To: <b76373a7-1e1d-3aae-66ba-09221c752c11@oderland.se>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-AntiAbuse: This header was added to track abuse, please include it with any abuse report
X-AntiAbuse: Primary Hostname - office.oderland.com
X-AntiAbuse: Original Domain - lists.xenproject.org
X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12]
X-AntiAbuse: Sender Address Domain - oderland.se
X-Get-Message-Sender-Via: office.oderland.com: authenticated_id: josjoh@oderland.se
X-Authenticated-Sender: office.oderland.com: josjoh@oderland.se

On 10/25/21 18:46, Josef Johansson wrote:
> On 10/25/21 14:27, Jason Andryuk wrote:
>> On Sun, Oct 24, 2021 at 9:26 PM Jason Andryuk <jandryuk@gmail.com> wrote:
>>> commit fcacdfbef5a1 ("PCI/MSI: Provide a new set of mask and unmask
>>> functions") introduce functions pci_msi_update_mask() and
>>> pci_msix_write_vector_ctrl() that is missing checks for
>>> pci_msi_ignore_mask that exists in commit 446a98b19fd6 ("PCI/MSI: Use
>>> new mask/unmask functions").  The checks are in place at the high level
>>> __pci_msi_mask_desc()/__pci_msi_unmask_desc(), but some functions call
>>> directly to the helpers.
>>>
>>> Push the pci_msi_ignore_mask check down to the functions that make
>>> the actual writes.  This keeps the logic local to the writes that need
>>> to be bypassed.
>>>
>>> With Xen PV, the hypervisor is responsible for masking and unmasking the
>>> interrupts, which pci_msi_ignore_mask is used to indicate.
>>>
>>> This change avoids lockups in amdgpu drivers under Xen during boot.
>>>
>>> Fixes: commit 446a98b19fd6 ("PCI/MSI: Use new mask/unmask functions")
>>> Reported-by: Josef Johansson <josef@oderland.se>
>>> Signed-off-by: Jason Andryuk <jandryuk@gmail.com>
>>> ---
>> I should have written that this is untested.  If this is the desired
>> approach, Josef should test that it solves his boot hangs.
>>
>> Regards,
>> Jason
> I've tested this today, both the above patch, but also my own below
> where I'm patching inside __pci_write_msi_msg,
> which is the outcome of the patch above.
I tested a lot of kernels today. To create a good baseline I compiled
without any of our patches here
and with my config flags set.

CONFIG_AMD_PMC=y
# CONFIG_HSA_AMD is not set
# CONFIG_CRYPTO_DEV_CCP is not set

The kernel stopped as before, and hung.

Test number 2 was to boot with amdgpu.msi=0.
This still resulted in a bad boot since all the xhcd drivers complained.
We can be sure that it's not amdgpu per se.

Test number 3 was with Jason's patch. It worked, but suspend/resume is
not working well.
Generally it's not behaving like other kernels do, which makes it
actually change the behavior.
Now with test 4 I tried that thought, maybe this is still a good change?
I'm deprived of a good baseline in all this, so it's very hard to
navigate between all the variables.

Test number 4 was with Jason's patch plus the amdgpu-patch below.
It worked, even suspend/resume, 2 times, but then it all crashed and
burn with quite interesting stacktraces. Are amdgpu doing it wrong here
or is it just me nitpicking?

index cc2e0c9cfe0a..f125597eb991 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c
@@ -279,17 +279,8 @@ static bool amdgpu_msi_ok(struct amdgpu_device *adev)
 
 static void amdgpu_restore_msix(struct amdgpu_device *adev)
 {
-	u16 ctrl;
-
-	pci_read_config_word(adev->pdev, adev->pdev->msix_cap + PCI_MSIX_FLAGS, &ctrl);
-	if (!(ctrl & PCI_MSIX_FLAGS_ENABLE))
-		return;
-
-	/* VF FLR */
-	ctrl &= ~PCI_MSIX_FLAGS_ENABLE;
-	pci_write_config_word(adev->pdev, adev->pdev->msix_cap + PCI_MSIX_FLAGS, ctrl);
-	ctrl |= PCI_MSIX_FLAGS_ENABLE;
-	pci_write_config_word(adev->pdev, adev->pdev->msix_cap + PCI_MSIX_FLAGS, ctrl);
+	// checks if msix is enabled also
+	pci_restore_msi_state(adev->pdev);
 }
 
 /**

During the tests I fiddled with dpm settings, and it does have an effect
one the graphical output during suspend/resume. So maybe there's
hardware problems at play here as well.

I also looked through the code before and after Thomas' changes, and I
can't see that
this patch should make any functional difference compared to before the
MSI series of patches.
It's even such that is_virtual should be checked withing vector_ctrl. I
find Jason's patch
quite nice since it really places the checks on few places making it
easier not to slip.
Compared to my attempt that even failed because I forgot one more place
to put the checks.

With that said I would really like some more tests on this with
different chipsets, on Xen.
Any takers?

What I'm seeing is that there's no readl() in pci_msix_unmask(), it was
one in the code path before.
I'm very much unsure if there should be one there though.

We can really do a better job at the documentation for
pci_msi_ignore_mask, at least in msi.c,
maybe that should be a different patch adding some comments such that
driver folks really see
the benefits of using the built in restore functions e.g.

This became so much bigger project than I thought, thanks all for
chiming in on it.


From xen-devel-bounces@lists.xenproject.org Wed Oct 27 00:09:20 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Oct 2021 00:09:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.216640.376310 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfWV5-00025B-J6; Wed, 27 Oct 2021 00:09:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 216640.376310; Wed, 27 Oct 2021 00:09:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfWV5-000254-EH; Wed, 27 Oct 2021 00:09:03 +0000
Received: by outflank-mailman (input) for mailman id 216640;
 Wed, 27 Oct 2021 00:09:01 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=uMsA=PP=citrix.com=Andrew.Cooper3@srs-us1.protection.inumbo.net>)
 id 1mfWV3-00024y-KA
 for xen-devel@lists.xenproject.org; Wed, 27 Oct 2021 00:09:01 +0000
Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 879efac2-55ba-4406-839f-9e978ba5a569;
 Wed, 27 Oct 2021 00:09:00 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 879efac2-55ba-4406-839f-9e978ba5a569
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1635293340;
  h=subject:to:cc:references:from:message-id:date:
   in-reply-to:content-transfer-encoding:mime-version;
  bh=dY7p4zfKEf51a7lsmM858uXPFZIZDnvj98syNj/Jcnc=;
  b=JqyhylsYduxf7ADIIuytypooh1LsL4eqmnfB5Os6NCYt5YcH9hYNhCxu
   Srl1uN6Zeh/jI/rMgE3PQW3IMiwrfb6gbGDqr0ei0pTYjMy+coq4vNL/5
   FoihgvQ5vnOmGQkiM1wKeA2Cb8/0DRMB3wSrmk2pRC03uch2okjfYMGRA
   0=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: SnVNSyueiUM7aVnfwZZMAFK8QXnodC/JiJHX9xq8f75iUHcHXEmcrH7EfknvVrG1RKGTynBTdq
 laTdC42MzWW85G65tdrqMlr0n+mQ999GwikkyinvLk3TXtBL1lTI0J+gsQdenGpWNaqr6cJHnU
 ZwNwn9GhpKmOrlHpv4iJKK7B2kPCBDvoFrmHfRs01RNF2C9KPYT+MsM0QQtosLa9uxjdLYNQVZ
 E8gpLwoKwzmp6f0caojG/7f0+4vQZxVYpahfroB0TakIrWSTRJ5BMMr0tZVmlSRa8O6SyPI8Oh
 IwV62RST8d9LOFXo/L7im+uF
X-SBRS: 5.1
X-MesageID: 56158697
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:ZMs88aj2xw7sgdv/9VRUtmRVX161gRcKZh0ujC45NGQN5FlHY01je
 htvWjiOOveMYGenL4hxYIyy/U0OvJaByNFqHgs++yk3Eysb9cadCdqndUqhZCn6wu8v7a5EA
 2fyTvGacajYm1eF/k/F3oAMKRCQ7InQLlbGILes1htZGEk0F0/NtTo5w7Rg29Yy34Dla++wk
 YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq
 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx
 /1Wib6OS0AsJJTnxvYFXAYHCxthL4NvreqvzXiX6aR/zmXDenrohf5vEFs3LcsT/eMf7WNmr
 KJCbmpXN1ba2rzwkOnTpupE36zPKOHCOo8Ft24m5jbeFfs8GrjIQrnQ5M8e1zA17ixLNauAP
 pdJN2swBPjGSxweEAsnA4wGoMmTlEHuTGxysX62opNitgA/yyQuieOwYbI5YOeiVchT20qVu
 G/C12D4GQ0BcsySzyKf9XChjfOJmjn0MKoQHrCl8v9hgHWI23ceThYRUDOTvv2RmkO4HdVFJ
 CQpFjEG9PZoshbxF5+kAkP+8CXsUgMgt8R4CNEY1gPKz7DtyFiLHmcbESZ7d84InZpjLdA17
 WOhk9TsDD1plbSaT3OB67uZxQ+P1TgpwXwqPnBcE1NUizX3iMRq1EiXF4c8eEKgpoStQWmY/
 tyckMQpa1z/Z+Yw3KKn4UuPvTuoopXYJuLezlSKBjz7hu+ViYjMWmBJ1bQ5xaofRGp6ZgPY1
 JThpyR4xLpWZX1qvHfUKNjh5Jnzu5643MT02DaD5aUJ+TW34GKEdotN+jx4L0oBGp9aImKzP
 xSD41sIvMI70J6WgUlfOdrZ5yMClvGIKDgYfqqMMoomjmZZLVfvEN5Sib64gDm2zRlEfVAXM
 paHa8e8ZUv2+ow8pAdas9w1iOdxrghnnDu7bcmik3yPjOrPDFbIGOxtGAbfMYgEAFas/Vy9H
 yB3bJDRlX2ykYTWP0HqzGLkBQpVciFrVMqv8p0/myzqClMOJVzNwsT5mNsJU4dkg75UhqHP+
 HS8UVVf013xmTvMLgDiV5ypQO+HsU9XoS1pMCoyE0yv3nR/M4+j4L1GL8k8fKU99fwlxvlxF
 qFXd8KFC/VJazLG5zVCMsWt8N08LEym1VCUIi6oQDkjZJo8FQbHzcDpI1n0/y4UAyvp6cZn+
 ++81hnWSIYoThh5CJqEc+qmyl685CBPmO97U0bSDMNUfUHgrNpjJyDr16dlKMAQMxTTgDCd0
 l/OUxsfoODMpa4z8cXI2v/Y/9v4TbMmExMDTWfB7LuwOS3LxUaZwNdNALSSYDTQdGLo46H+N
 +9b+O7xba8cl1FQvosiT7sylfAi58HirqNxxxh/GCmZdEyiD75tLyXU3cRLsaERlLZVtRHvB
 xCK89hef76IJNnkABgaIw98NraP0vQdmz/z6/UpIRqluH8rreTfCUgCbQORjCF9LaduNNJ3y
 Ogsj8ca9gijh0d4Kd2BlC1VqzyBI3Fov3/LbX3G7FsHUjYW92w=
IronPort-HdrOrdr: A9a23:NZ/Ze629ZZgMbN+vmSSCbAqjBSByeYIsimQD101hICG9Lfb3qy
 n+ppsmPEHP5Ar5OEtBpTiBUJPwJk80hqQFn7X5Wo3SIzUO2VHYUL2KiLGC/9SOIVyEygcw79
 YYT0E6MqyMMbEYt7eI3ODbKadZ/DDvysnB7o2yvhQdL3AZV0gj1XYeNu/yKDwHeOAsP+tdKH
 Pz3Lsim9PtQwVsUiztbUN1LtQr6ue72K7OUFojPVoK+QOOhTSn5PrTFAWZ5A4XV3dqza05+W
 bIvgTl7uH72svLhCP05iv21dB7idHhwtxMCIiljdUUECzljkKNaJ56U7OPkTgpqKWE6Uoskv
 PLvxA8Vv4DpE/5TyWQm1/AygPg2DEh5zvLzkKZu2LqpYjDSDczG6N69MlkWyqcz3BlkMB30a
 pN0W7cnYFQFwn8kCP04MWNfw12l2KvyEBS0tI7vjh6a88zebVRpYsQ8Ad+C5EbBh/374ghDa
 1HENzc3vBLalmXBkqp/lWH+ObcG0jbIy32BnTr4qeuon9rdTFCvgolLfUk7zU9HMlXcegD2w
 zGWp4Y3I2mAPVmNJ6VP91xNfdfPFa9CC4kAFjiVGgPK5t3TE4li6SHqondt9vaNaDh8vMJ6e
 L8uRVjxDYPR34=
X-IronPort-AV: E=Sophos;i="5.87,184,1631592000"; 
   d="scan'208";a="56158697"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=hwPrpBMdaAbQHo787oICEd3Vt5bcr5lg+zySf675MzSfpmAgZOj7O+vXlHbsW+7AGu9wL3ikslXsPBkVQaLacWjvcVNzG5jNs27G7GzutvRS8Y4EY9sZwthdKgC77WjHRLt0Jlwz0hvn+Bjzuc9bP4i2/mXPgV+sWePCFn8iEnHvLnR2A/9wUZmFDx7cS+c+A1cE68st4f2Qu8SQbGq3N+UNd9mvt5t5NmAnXF16wclI7LzZKcE9Q9Px26L9zoXB9MmVlh+ICaLauRsQq0mxqDCWB+E6E3yLERlfaBma+KHUYeQKV7ANiHJb60VrjMyjNUCJSQROgThzOjS/1YRcnQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=dY7p4zfKEf51a7lsmM858uXPFZIZDnvj98syNj/Jcnc=;
 b=K8lIIXNyUD3W/QxkEItOA9Zu90vRJGaBnqPkGOySmiDCRBKCNnZ2MTM5zmfiMqCkhm2lzCoaoE9QZC6ZlJzdXyfGuLcGsSSgqIpeOkPo9W71pX//Fd/ImePHtXRuQMocticuuea7QIcRtru6ZBZsbyMW+SBdNCzyho30MMHlA6jAgppjD6ikt333p57Tzjl/7bvk1yV1E02ItCahBW0iDkjIGTFDbLKCYlUAaPmX7jwF3C0i1bZNP1Oq3pFbUeFLDrednSDx6nADnkzZ3yEDHvfn7rxE/XNZQULcvtzwNYzfivGvx9mkSbJzeJXK6g6w+jbpFLjjIIO/SjJQfa1j3Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=dY7p4zfKEf51a7lsmM858uXPFZIZDnvj98syNj/Jcnc=;
 b=uBDdldmb78bWJZmayFI75q967LHJrHxAWBzruyHNmSiwRAlqPbedYpbknm7FhbfDovXZ/XdVijLRUyLgAHl4jRkab8eeKyOGcY2Dew/9BuqhbPQNo98hB6Q1nY1gTYpKmxLCMjwdShSqPT+9lgdOHkwZNw38Zw7BIktiwuOBj/c=
Subject: Re: [PATCH] x86/hpet: setup HPET even when disabled due to stopping
 in deep C states
To: Roger Pau Monne <roger.pau@citrix.com>, <xen-devel@lists.xenproject.org>
CC: Jan Beulich <jbeulich@suse.com>, Wei Liu <wl@xen.org>
References: <68352fc1-9ba0-1081-be50-065b212f96a3@citrix.com>
 <20211026151233.57246-1-roger.pau@citrix.com>
From: Andrew Cooper <andrew.cooper3@citrix.com>
Message-ID: <67ed6c84-2046-0cd6-1e68-e462ffb11592@citrix.com>
Date: Wed, 27 Oct 2021 01:08:43 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <20211026151233.57246-1-roger.pau@citrix.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Content-Language: en-GB
X-ClientProxiedBy: LO4P123CA0243.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:1a7::14) To BYAPR03MB3623.namprd03.prod.outlook.com
 (2603:10b6:a02:aa::12)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: e9a92922-0546-468d-c8d3-08d998ddf36a
X-MS-TrafficTypeDiagnostic: BYAPR03MB4677:
X-Microsoft-Antispam-PRVS: <BYAPR03MB46777331E00D8FCD352E76C6BA859@BYAPR03MB4677.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: rUPjBUnY4MHOUJZqNFMp/tUawv4wC2NkvL2ndz86BZfDfwf9F9MuXi11Qwt5TR9XeTRYc6yyzoPX2WzGkskTzldpqhJsmP18oNcGHlm6IFpGPpS1UV+3jpvRPy8ftjom7lL+HIi+Sgxz+00FaVLMbWBosjlfyNVYHEXRah0pacTMwCgofL0H+5nVV5PoHjmVfUctAVL5p+/JtGrRUxb351aPeyrYes4ThC3KyUvj3IHaC80woI8ykG5uHA9ceilQc4+eK1Nowi4VP8G0DcMuGZNQmZyIegqSAEQW4KIgTuUCoGK+JqO98rE0NVF4UeLreF0C2bQ+QZ5ChFxbsRm0Vk8NdQnByFMJtmNmR+M/NsdpQdr2rxqV2vZzO6w8kxXElRxmDQ9tUmY5MbQMicb0bXAXUeSi9sl0g26KsDSETUxSvZ61hTrfjMZU9VpQT5sqixPwf+hzON444wDaTaqCR9SOon+HIB1dimPjRrM7OleGr5IUZsUigTkFpWOIDoH+t4esB8021H5hc5n9xOLQoyqV1cxAYwMFY7On1na9TvAYyneL16igs7zZRUoRYtbPBpuDlk17/6rPUIkNOZ+vlMkn19etfTIci9es+uS4OA2fBDJg8aRRgbCG9xYDRX/FakOndFKEQlnZnwr1AZHqiEqVGh/FwNbeZ5stNVRjAFO3SeWrxdQvkztZkQ2RbS2fFd8iLS8O5XGHXRinJRtn3ka1sEBGPYAGha/3h/r45h8=
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(31696002)(36756003)(53546011)(2616005)(31686004)(186003)(54906003)(86362001)(16576012)(508600001)(8936002)(956004)(2906002)(4326008)(316002)(82960400001)(5660300002)(8676002)(26005)(4744005)(83380400001)(6666004)(6486002)(66946007)(38100700002)(66556008)(66476007)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Rnk0VC9KOE1Uc29pS09sWFZad2tFTGpmZ0pzVmNkL3RYVEVpb1J3UTYwaDBI?=
 =?utf-8?B?MjBNWFllY0pFQk5mam95NSt2aG1qcEhQd2tZR2ZJYTg2SEV5ZFozNmNMQzRL?=
 =?utf-8?B?c0p1WWRNSjZSaHdObHk2U0hKUVQ5QTY3NnZoVFhIQS9jdVZRSGFMQ2RwNDF0?=
 =?utf-8?B?OFQzQ0tFNytmL3NnU3JDcjZSVXdvUkZ4N0tKN3puVFVHMzJSR0V2NE5oNUlZ?=
 =?utf-8?B?SkFyS1M0OTFQL0NSSGhtRGwwdjNFMU13SXIycnBaU2RMZGxjVWNuYlpFNHEw?=
 =?utf-8?B?R2dEdnpvU1hUc054ZkZQZm9MakZmNjMxeWdTekEvQVRlbWxzSjJGeEtOWkdi?=
 =?utf-8?B?SXhGMjdaR09sRXFvTzg5VlR1R0pUb0tEd2FGMHVDSEwwUFJ5UE5QMnV1ajV5?=
 =?utf-8?B?Rm8xNm43SXZSMWxmMEdkYjNoZ0dlNi9hZS9LTlJuYmlra1Fmakp2Tzd3Ny9Z?=
 =?utf-8?B?RGo4ZzFMMWQva3RCZWc3L0xUdHpCQ3JyM2U1VCt1TUJNL0NQYVc1SVNQU01I?=
 =?utf-8?B?aVIyY1l2TnhlZ2w3Q3pnejU1TTVxc3dJNjlqa29LMXVYZFhTcnlEK2NhZWVY?=
 =?utf-8?B?THBwOC9tT0Q1dnZCRExKWU5OYklWZmMrczYvRnVMeXhNYmVQMW94dDJZUmYv?=
 =?utf-8?B?QTNKOVhEY1JCQm5PR1hvYTd2Z3hVbGZnUlU0TW9nQm1qaGFDOTIxcm1qQVBu?=
 =?utf-8?B?VzU2WlNkR29FRjBqMitKTEgzOFRZV0VsWjVpdVdmLzlHNW1iamdTZlNRcWF6?=
 =?utf-8?B?LzFodFoxVHMrNVhPa3BhVU9lZnhsODJqRDllem5aRVl5SDAvb2FydC9VaVVM?=
 =?utf-8?B?cUx6ZzFLT3VWLzRVa2JCYVg4d0JHYXlpZGp4VTk0dlVCWk9mdWk4WVQ3OEZj?=
 =?utf-8?B?OWVFdzEybkpKcC91MG1uL1NDWjA3dGUwVDRNZklLdEh1a2xncTNpZ3UxSHI0?=
 =?utf-8?B?amE0dUJ2SW1zMVV2N2FyeFVCem1hMEFyRUR5Vmg4eE9ROVpuclhnZDRERkJH?=
 =?utf-8?B?eTdjK2VGSmloSUZnYzZKZUptc1V2d0RTZ3RQSVZoekZGclEyRUtzWkYyTmEx?=
 =?utf-8?B?L2I2WC9wcHppc2ZzZ0s3dVk0SER5T0VEbE1BeWo1c2VsNHFwbFJJUEZxMnJZ?=
 =?utf-8?B?b210KzljR2JnN1NxWDROZXJDdmx5L2tVd0FnbUNrbTdOUjFCM1FWeXNOUUVI?=
 =?utf-8?B?ejgrWG40cVl6LzlDWGsyd1llMkh4RGVsZU8vOHVnWWxZSlpMbzlKb2x6Umh0?=
 =?utf-8?B?VVljS3g1K1BtdUUxVi9mdGlYc2JJblk2VnUxd25MNWFHSFZ1Z0x6dVNDWCsy?=
 =?utf-8?B?NnNYVnZYeWYxTUh0UXlZd3FYYjAzajlDVUp4WDd1dWp3RUdra1YwQVUyMW5L?=
 =?utf-8?B?SjVlVXc4ZlRpL3pPaUNYYkJjdEJxK1JFNXZXbkNoR0I4b1puZWZoMStSMFd5?=
 =?utf-8?B?OXowRWI1b3p3cG5aNDNBb2svVmh0TnY1TmxJYXhWamhoU3FMb2lqdGZpdzZ4?=
 =?utf-8?B?ck5IVTZYYTk4c1Nmc1BJb21LbXlHZ0wzME5VaDVCL2EzNEZrd0xrRmdTaHhi?=
 =?utf-8?B?NmtxUlJ4UVNmVXcvNkNSOTZMY0F3OHVveUJxc09TdktuUnV5bVBaaDJ1NTYz?=
 =?utf-8?B?QksxdnJTbEVDTXR5eEZNUlpsMGQwNmtVVnhXN3ZyQXBTOGtOZy9RUGpDblVa?=
 =?utf-8?B?OUxCYWVCUjlOMWtpSG41TGtQYmg0TnpYVXFqM3RISnh1QTJKSFpoYXJuUG9j?=
 =?utf-8?B?Zzc4UVZYZ3o2NEY5S2ZmdXZhcGJvY2lMTXJoWTBuNkdPMWlCWEJOVDEyaDZC?=
 =?utf-8?B?OWRRaktYYU1ndzZDcXBaK3NTTmZ4Vlppd3NUUnJXNkJ3NTlvRUZydFdSdUg0?=
 =?utf-8?B?VkRFUzJCcjdvSlBxVVF2V2ptSXlNZmlRcDVOWCs2TDZ3Uk50T2VUMThTRlVL?=
 =?utf-8?B?RW9qUldMQzN0ODNtQ2JIS2E2UE5GL2EyNCtvQWgvK3BoemhQUTdsazBsQ2Rl?=
 =?utf-8?B?ZFVxaDl0dFhqQmtuTGtDRXF6OVVVS1drY3hHaUJ5MkN1eUV0UGNva0phK2ht?=
 =?utf-8?B?R3Bpa2FUbWQ3L3BpVVBaZHFtaWVzOXNNZXFCMnNpd21nZ1pmQzBvaVJCVXlS?=
 =?utf-8?B?UUFQdlA4azFGQi9MS2ttd1hiZXlBT1Q0WkhLVzR0N1N2WHNveitna3h0SUV1?=
 =?utf-8?B?elJxSW8zdVlWano4bWYrUGlIbWp5R0x0UnRHeUw1ZER1blQveGw2aGp3Uk5r?=
 =?utf-8?B?UlRRTWQ1OEpMNTBWK1ZYWDdVNmZBPT0=?=
X-MS-Exchange-CrossTenant-Network-Message-Id: e9a92922-0546-468d-c8d3-08d998ddf36a
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Oct 2021 00:08:49.0181
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: R2GbHGRynU31xImopY1jqr8OWgJA3QT7tDVzNLL1+sN19T7VozFEAFpQRzntKZGLoO6zUzTSUM/v9drmg8DFXrJU6HiQoxQ5z3e/U2tTBSI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB4677
X-OriginatorOrg: citrix.com

On 26/10/2021 16:12, Roger Pau Monne wrote:
> Always allow the HPET to be setup, but don't report a frequency back
> to the platform time source probe in order to avoid it from being
> selected as a valid timer if it's not usable.
>
> Doing the setup even when not intended to be used as a platform timer
> is required so that is can be used in legacy replacement mode in order
> to assert the IO-APIC is capable of receiving interrupts.
>
> Fixes: c12731493a ('x86/hpet: Use another crystalball to evaluate HPET usability')
> Reported-by: Andrew Cooper <andrew.cooper3@citrix.com>
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>

Yup - does fix the regression.

Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
Tested-by: Andrew Cooper <andrew.cooper3@citrix.com>


From xen-devel-bounces@lists.xenproject.org Wed Oct 27 03:12:04 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Oct 2021 03:12:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.216654.376336 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfZLi-0004ng-5y; Wed, 27 Oct 2021 03:11:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 216654.376336; Wed, 27 Oct 2021 03:11:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfZLh-0004nY-Vq; Wed, 27 Oct 2021 03:11:33 +0000
Received: by outflank-mailman (input) for mailman id 216654;
 Wed, 27 Oct 2021 03:11:32 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mfZLg-0004nO-TX; Wed, 27 Oct 2021 03:11:32 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mfZLg-00014a-MC; Wed, 27 Oct 2021 03:11:32 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mfZLg-0005Q8-9x; Wed, 27 Oct 2021 03:11:32 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mfZLg-00007p-9P; Wed, 27 Oct 2021 03:11:32 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=Q3yi9YgrZJTic9uJbqtD12sDai3nwzg+rDgaAXJhz2I=; b=yNgkTopAT9PgM5yPYVV9MVvgTE
	RAdlKXZZvlv0HSX7JoaCgPj3nP2Ch7tBIDBysX0/TuEXbyOx2J2FU88zZTzmFZdCrofbRpLjoENoY
	aa72TmPlsUZsUWMNy79pK3o5JQu8tJPST1Hc/Lg/W3eDoyYCoUm0aVG8OJ4r++vBYHuU=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165883-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 165883: regressions - FAIL
X-Osstest-Failures:
    qemu-mainline:build-i386:xen-build:fail:regression
    qemu-mainline:build-i386-xsm:xen-build:fail:regression
    qemu-mainline:build-armhf:xen-build:fail:regression
    qemu-mainline:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-amd:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-pair:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-freebsd10-i386:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-freebsd10-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-coresched-i386-xl:build-check(1):blocked:nonblocking
    qemu-mainline:build-armhf-libvirt:build-check(1):blocked:nonblocking
    qemu-mainline:build-i386-libvirt:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-intel:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-shadow:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-vhd:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=931ce30859176f0f7daac6bac255dae5eb21284e
X-Osstest-Versions-That:
    qemuu=50352cce138ef3b30c1cda28a4df68fff5da3202
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 27 Oct 2021 03:11:32 +0000

flight 165883 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165883/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-i386                    6 xen-build                fail REGR. vs. 165682
 build-i386-xsm                6 xen-build                fail REGR. vs. 165682
 build-armhf                   6 xen-build                fail REGR. vs. 165682

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl           1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-credit2   1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-cubietruck  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-multivcpu  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-rtds      1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-vhd       1 build-check(1)               blocked  n/a
 test-amd64-i386-qemuu-rhel6hvm-amd  1 build-check(1)               blocked n/a
 test-amd64-i386-pair          1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-freebsd10-i386  1 build-check(1)               blocked  n/a
 test-amd64-i386-freebsd10-amd64  1 build-check(1)               blocked  n/a
 test-amd64-coresched-i386-xl  1 build-check(1)               blocked  n/a
 build-armhf-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-credit1   1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-arndale   1 build-check(1)               blocked  n/a
 test-amd64-i386-qemuu-rhel6hvm-intel  1 build-check(1)             blocked n/a
 test-amd64-i386-xl            1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-pvshim     1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-qemuu-debianhvm-amd64  1 build-check(1)         blocked n/a
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow  1 build-check(1)  blocked n/a
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm  1 build-check(1)      blocked n/a
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 1 build-check(1) blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a
 test-amd64-i386-xl-qemuu-win7-amd64  1 build-check(1)              blocked n/a
 test-amd64-i386-xl-qemuu-ws16-amd64  1 build-check(1)              blocked n/a
 test-amd64-i386-xl-shadow     1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-vhd        1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-xsm        1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165682
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165682
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165682
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 qemuu                931ce30859176f0f7daac6bac255dae5eb21284e
baseline version:
 qemuu                50352cce138ef3b30c1cda28a4df68fff5da3202

Last test of basis   165682  2021-10-19 21:09:14 Z    7 days
Failing since        165694  2021-10-20 18:09:12 Z    6 days   15 attempts
Testing same since   165883  2021-10-26 21:38:10 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Alistair Francis <alistair.francis@wdc.com>
  Andrew Jones <drjones@redhat.com>
  Ani Sinha <ani@anisinha.ca>
  BALATON Zoltan <balaton@eik.bme.hu>
  Bin Meng <bmeng.cn@gmail.com>
  Cédric Le Goater <clg@kaod.org>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  David Gibson <david@gibson.dropbear.id.au>
  David Hildenbrand <david@redhat.com>
  Dr. David Alan Gilbert <dgilbert@redhat.com>
  Eric Auger <eric.auger@redhat.com>
  Eugenio Pérez <eperezma@redhat.com>
  Frank Chang <frank.chang@sifive.com>
  Gavin Shan <gshan@redhat.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Greg Kurz <groug@kaod.org>
  Gustavo Romero <gromero@linux.ibm.com>
  Igor Mammedov <imammedo@redhat.com>
  Jason Wang <jasowang@redhat.com>
  John Wang <wangzhiqiang02@inspur.com>
  John Wang <wangzq.jn@gmail.com>
  Laurent Vivier <laurent@vivier.eu>
  Laurent Vivier <lvivier@redhat.com>
  Luc Michel <lmichel@kalray.eu>
  Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
  Matheus Ferst <matheus.ferst@eldorado.org.br>
  Mathieu Poirier <mathieu.poirier@linaro.org>
  Michael S. Tsirkin <mst@redhat.com>
  Mingwang Li <limingwang@huawei.com>
  Oğuz Ersen <oguzersen@protonmail.com>
  Philipp Tomsich <philipp.tomsich@vrull.eu>
  Philippe Mathieu-Daudé <f4bug@amsat.org>
  Philippe Mathieu-Daudé <philmd@redhat.com>
  Richard Henderson <richard.henderson@linaro.org>
  Shuuichirou Ishii <ishii.shuuichir@fujitsu.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Thomas Huth <thuth@redhat.com>
  Tong Ho <tong.ho@xilinx.com>
  Travis Geiselbrecht <travisg@gmail.com>
  Vincent Palatin <vpalatin@rivosinc.com>
  Vivek Goyal <vgoyal@redhat.com>
  Xueming Li <xuemingl@nvidia.com>
  Yanan Wang <wangyanan55@huawei.com>
  Yifei Jiang <jiangyifei@huawei.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               fail    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          blocked 
 test-amd64-i386-xl                                           blocked 
 test-amd64-coresched-i386-xl                                 blocked 
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  blocked 
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       blocked 
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           blocked 
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     blocked 
 test-amd64-i386-freebsd10-amd64                              blocked 
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          blocked 
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          blocked 
 test-armhf-armhf-xl-arndale                                  blocked 
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  blocked 
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  blocked 
 test-armhf-armhf-xl-cubietruck                               blocked 
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         blocked 
 test-amd64-i386-freebsd10-i386                               blocked 
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         blocked 
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                blocked 
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         blocked 
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 blocked 
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    blocked 
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     blocked 
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              blocked 
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    blocked 
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      blocked 
 test-amd64-i386-xl-vhd                                       blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 3749 lines long.)


From xen-devel-bounces@lists.xenproject.org Wed Oct 27 06:25:42 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Oct 2021 06:25:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.216664.376356 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfcN0-0005ns-VR; Wed, 27 Oct 2021 06:25:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 216664.376356; Wed, 27 Oct 2021 06:25:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfcN0-0005nl-RT; Wed, 27 Oct 2021 06:25:06 +0000
Received: by outflank-mailman (input) for mailman id 216664;
 Wed, 27 Oct 2021 06:25:04 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=t3V1=PP=bombadil.srs.infradead.org=BATV+38fc963a38e5fd54c8c1+6639+infradead.org+dwmw2@srs-us1.protection.inumbo.net>)
 id 1mfcMy-0005nf-4L
 for xen-devel@lists.xenproject.org; Wed, 27 Oct 2021 06:25:04 +0000
Received: from bombadil.infradead.org (unknown [2607:7c80:54:e::133])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 4e021e22-7e4b-441f-b44e-752d004858ba;
 Wed, 27 Oct 2021 06:25:01 +0000 (UTC)
Received: from [2001:8b0:10b:1::3ae] (helo=u3832b3a9db3152.ant.amazon.com)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1mfcMm-0041Uh-76; Wed, 27 Oct 2021 06:24:52 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4e021e22-7e4b-441f-b44e-752d004858ba
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=MIME-Version:Content-Type:References:
	In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Sender:Reply-To:
	Content-Transfer-Encoding:Content-ID:Content-Description;
	bh=s9OIF1LOOIWjOap4Z+0ARv4jSisQpi6HR05O3fSLE9M=; b=OAZT0EUWtkHuAtwBiA+wcSAUyI
	gGocJo4lme1tgjUuASWjldzYn5n6TVObit2CZuHDfay5r0owhhP9VedNJWe5aggzimy9ZRtp6GW8r
	NXaY1I3sV4TwyAddfW7gBnCCdHuSwL6VdmFU2Y+TF+iUVR0ZH6K+OlVDf7Z38Vm5yC1GJirpGg1Kx
	UQiZkyE2Y1DUtEHCdYusJ0i5Rfy4X6k6GM8VCngu56rwARAXzWMM2tTeTeZvTDaI54w/qERPa3uBQ
	PLHl6FH5wJv+RlQc98v2Mimp/QkCc3vPmwcrZ0F1DZsi6p/fNwSujtfjryz+3KKcyER5meP2S3zuQ
	3MjWwayQ==;
Message-ID: <ee23eafce1993ba7da8fdf4c03cedbcb3362ef1d.camel@infradead.org>
Subject: Re: [PATCH v2] PCI/MSI: Re-add checks for skip masking MSI-X on Xen
 PV
From: David Woodhouse <dwmw2@infradead.org>
To: Josef Johansson <josef@oderland.se>, Jason Andryuk <jandryuk@gmail.com>,
  Marc Zyngier <maz@kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>, linux-pci@vger.kernel.org, xen-devel
 <xen-devel@lists.xenproject.org>, Thomas Gleixner <tglx@linutronix.de>, 
 Juergen Gross <jgross@suse.com>, Boris Ostrovsky
 <boris.ostrovsky@oracle.com>
Date: Wed, 27 Oct 2021 07:24:49 +0100
In-Reply-To: <c4d27d67-1027-e72b-c5bf-5546c5b0e2e9@oderland.se>
References: <20211019202906.GA2397931@bhelgaas>
	 <5f050b30-fa1c-8387-0d6b-a667851b34b0@oderland.se>
	 <877de7dfl2.wl-maz@kernel.org>
	 <CAKf6xpt=ZYGyJXMwM7ccOWkx71R0O-QeLjkBF-LtdDcbSnzHsA@mail.gmail.com>
	 <3434cb2d-4060-7969-d4c4-089c68190527@oderland.se>
	 <90277228-cf14-0cfa-c95e-d42e7d533353@oderland.se>
	 <CAKf6xpvZ8fxuBY4BZ51UZzF92zDUcvfav9_pOT7F3w-Bc8YkwA@mail.gmail.com>
	 <c4d27d67-1027-e72b-c5bf-5546c5b0e2e9@oderland.se>
Content-Type: multipart/signed; micalg="sha-256"; protocol="application/pkcs7-signature";
	boundary="=-N2uIjvIfDePtsDUY+x3E"
User-Agent: Evolution 3.36.5-0ubuntu1 
MIME-Version: 1.0
X-SRS-Rewrite: SMTP reverse-path rewritten from <dwmw2@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html


--=-N2uIjvIfDePtsDUY+x3E
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, 2021-10-25 at 21:21 +0200, Josef Johansson wrote:
> +       if (!(pci_msi_ignore_mask || entry->msi_attrib.is_virtual))

Is it just me, or is that a lot easier to read if you write it as the
tautologically-identical (!pci_msi_ignore_mask && !entry->=E2=80=A6is_virtu=
al)?


> @@ -546,7 +548,8 @@ static int msi_capability_init(struct pci_dev *dev, i=
nt nvec,
>                 return -ENOMEM;

>         /* All MSIs are unmasked by default; mask them all *
> -       pci_msi_mask(entry, msi_multi_mask(entry))
> +       if (!pci_msi_ignore_mask)
> +               pci_msi_mask(entry, msi_multi_mask(entry));
>
>         list_add_tail(&entry->list, dev_to_msi_list(&dev->dev));


Hm, I thought that older kernels *did* do this part (or at least the
later ones in pci_msi*_hutdown). I was watching it when I did the Xen
hosting implementation I mentioned before; even a hack to unmask them
all when the VM was started, wasn't working because the guest would
*mask* all MSI-X, just never unmask them again.


I wonder if we should rename 'pci_msi_ignore_mask' to something with
Xen in its name because Xen is the only user of this abomination (which
fundamentally seems to require that the virtual hardware use MSI
entries even while they're masked, so hopefully nobody else would
*ever* do such a thing), and the required behaviour is very Xen-
specific.

--=-N2uIjvIfDePtsDUY+x3E
Content-Type: application/pkcs7-signature; name="smime.p7s"
Content-Disposition: attachment; filename="smime.p7s"
Content-Transfer-Encoding: base64

MIAGCSqGSIb3DQEHAqCAMIACAQExDzANBglghkgBZQMEAgEFADCABgkqhkiG9w0BBwEAAKCCECow
ggUcMIIEBKADAgECAhEA4rtJSHkq7AnpxKUY8ZlYZjANBgkqhkiG9w0BAQsFADCBlzELMAkGA1UE
BhMCR0IxGzAZBgNVBAgTEkdyZWF0ZXIgTWFuY2hlc3RlcjEQMA4GA1UEBxMHU2FsZm9yZDEaMBgG
A1UEChMRQ09NT0RPIENBIExpbWl0ZWQxPTA7BgNVBAMTNENPTU9ETyBSU0EgQ2xpZW50IEF1dGhl
bnRpY2F0aW9uIGFuZCBTZWN1cmUgRW1haWwgQ0EwHhcNMTkwMTAyMDAwMDAwWhcNMjIwMTAxMjM1
OTU5WjAkMSIwIAYJKoZIhvcNAQkBFhNkd213MkBpbmZyYWRlYWQub3JnMIIBIjANBgkqhkiG9w0B
AQEFAAOCAQ8AMIIBCgKCAQEAsv3wObLTCbUA7GJqKj9vHGf+Fa+tpkO+ZRVve9EpNsMsfXhvFpb8
RgL8vD+L133wK6csYoDU7zKiAo92FMUWaY1Hy6HqvVr9oevfTV3xhB5rQO1RHJoAfkvhy+wpjo7Q
cXuzkOpibq2YurVStHAiGqAOMGMXhcVGqPuGhcVcVzVUjsvEzAV9Po9K2rpZ52FE4rDkpDK1pBK+
uOAyOkgIg/cD8Kugav5tyapydeWMZRJQH1vMQ6OVT24CyAn2yXm2NgTQMS1mpzStP2ioPtTnszIQ
Ih7ASVzhV6csHb8Yrkx8mgllOyrt9Y2kWRRJFm/FPRNEurOeNV6lnYAXOymVJwIDAQABo4IB0zCC
Ac8wHwYDVR0jBBgwFoAUgq9sjPjF/pZhfOgfPStxSF7Ei8AwHQYDVR0OBBYEFLfuNf820LvaT4AK
xrGK3EKx1DE7MA4GA1UdDwEB/wQEAwIFoDAMBgNVHRMBAf8EAjAAMB0GA1UdJQQWMBQGCCsGAQUF
BwMEBggrBgEFBQcDAjBGBgNVHSAEPzA9MDsGDCsGAQQBsjEBAgEDBTArMCkGCCsGAQUFBwIBFh1o
dHRwczovL3NlY3VyZS5jb21vZG8ubmV0L0NQUzBaBgNVHR8EUzBRME+gTaBLhklodHRwOi8vY3Js
LmNvbW9kb2NhLmNvbS9DT01PRE9SU0FDbGllbnRBdXRoZW50aWNhdGlvbmFuZFNlY3VyZUVtYWls
Q0EuY3JsMIGLBggrBgEFBQcBAQR/MH0wVQYIKwYBBQUHMAKGSWh0dHA6Ly9jcnQuY29tb2RvY2Eu
Y29tL0NPTU9ET1JTQUNsaWVudEF1dGhlbnRpY2F0aW9uYW5kU2VjdXJlRW1haWxDQS5jcnQwJAYI
KwYBBQUHMAGGGGh0dHA6Ly9vY3NwLmNvbW9kb2NhLmNvbTAeBgNVHREEFzAVgRNkd213MkBpbmZy
YWRlYWQub3JnMA0GCSqGSIb3DQEBCwUAA4IBAQALbSykFusvvVkSIWttcEeifOGGKs7Wx2f5f45b
nv2ghcxK5URjUvCnJhg+soxOMoQLG6+nbhzzb2rLTdRVGbvjZH0fOOzq0LShq0EXsqnJbbuwJhK+
PnBtqX5O23PMHutP1l88AtVN+Rb72oSvnD+dK6708JqqUx2MAFLMevrhJRXLjKb2Mm+/8XBpEw+B
7DisN4TMlLB/d55WnT9UPNHmQ+3KFL7QrTO8hYExkU849g58Dn3Nw3oCbMUgny81ocrLlB2Z5fFG
Qu1AdNiBA+kg/UxzyJZpFbKfCITd5yX49bOriL692aMVDyqUvh8fP+T99PqorH4cIJP6OxSTdxKM
MIIFHDCCBASgAwIBAgIRAOK7SUh5KuwJ6cSlGPGZWGYwDQYJKoZIhvcNAQELBQAwgZcxCzAJBgNV
BAYTAkdCMRswGQYDVQQIExJHcmVhdGVyIE1hbmNoZXN0ZXIxEDAOBgNVBAcTB1NhbGZvcmQxGjAY
BgNVBAoTEUNPTU9ETyBDQSBMaW1pdGVkMT0wOwYDVQQDEzRDT01PRE8gUlNBIENsaWVudCBBdXRo
ZW50aWNhdGlvbiBhbmQgU2VjdXJlIEVtYWlsIENBMB4XDTE5MDEwMjAwMDAwMFoXDTIyMDEwMTIz
NTk1OVowJDEiMCAGCSqGSIb3DQEJARYTZHdtdzJAaW5mcmFkZWFkLm9yZzCCASIwDQYJKoZIhvcN
AQEBBQADggEPADCCAQoCggEBALL98Dmy0wm1AOxiaio/bxxn/hWvraZDvmUVb3vRKTbDLH14bxaW
/EYC/Lw/i9d98CunLGKA1O8yogKPdhTFFmmNR8uh6r1a/aHr301d8YQea0DtURyaAH5L4cvsKY6O
0HF7s5DqYm6tmLq1UrRwIhqgDjBjF4XFRqj7hoXFXFc1VI7LxMwFfT6PStq6WedhROKw5KQytaQS
vrjgMjpICIP3A/CroGr+bcmqcnXljGUSUB9bzEOjlU9uAsgJ9sl5tjYE0DEtZqc0rT9oqD7U57My
ECIewElc4VenLB2/GK5MfJoJZTsq7fWNpFkUSRZvxT0TRLqznjVepZ2AFzsplScCAwEAAaOCAdMw
ggHPMB8GA1UdIwQYMBaAFIKvbIz4xf6WYXzoHz0rcUhexIvAMB0GA1UdDgQWBBS37jX/NtC72k+A
CsaxitxCsdQxOzAOBgNVHQ8BAf8EBAMCBaAwDAYDVR0TAQH/BAIwADAdBgNVHSUEFjAUBggrBgEF
BQcDBAYIKwYBBQUHAwIwRgYDVR0gBD8wPTA7BgwrBgEEAbIxAQIBAwUwKzApBggrBgEFBQcCARYd
aHR0cHM6Ly9zZWN1cmUuY29tb2RvLm5ldC9DUFMwWgYDVR0fBFMwUTBPoE2gS4ZJaHR0cDovL2Ny
bC5jb21vZG9jYS5jb20vQ09NT0RPUlNBQ2xpZW50QXV0aGVudGljYXRpb25hbmRTZWN1cmVFbWFp
bENBLmNybDCBiwYIKwYBBQUHAQEEfzB9MFUGCCsGAQUFBzAChklodHRwOi8vY3J0LmNvbW9kb2Nh
LmNvbS9DT01PRE9SU0FDbGllbnRBdXRoZW50aWNhdGlvbmFuZFNlY3VyZUVtYWlsQ0EuY3J0MCQG
CCsGAQUFBzABhhhodHRwOi8vb2NzcC5jb21vZG9jYS5jb20wHgYDVR0RBBcwFYETZHdtdzJAaW5m
cmFkZWFkLm9yZzANBgkqhkiG9w0BAQsFAAOCAQEAC20spBbrL71ZEiFrbXBHonzhhirO1sdn+X+O
W579oIXMSuVEY1LwpyYYPrKMTjKECxuvp24c829qy03UVRm742R9Hzjs6tC0oatBF7KpyW27sCYS
vj5wbal+TttzzB7rT9ZfPALVTfkW+9qEr5w/nSuu9PCaqlMdjABSzHr64SUVy4ym9jJvv/FwaRMP
gew4rDeEzJSwf3eeVp0/VDzR5kPtyhS+0K0zvIWBMZFPOPYOfA59zcN6AmzFIJ8vNaHKy5QdmeXx
RkLtQHTYgQPpIP1Mc8iWaRWynwiE3ecl+PWzq4i+vdmjFQ8qlL4fHz/k/fT6qKx+HCCT+jsUk3cS
jDCCBeYwggPOoAMCAQICEGqb4Tg7/ytrnwHV2binUlYwDQYJKoZIhvcNAQEMBQAwgYUxCzAJBgNV
BAYTAkdCMRswGQYDVQQIExJHcmVhdGVyIE1hbmNoZXN0ZXIxEDAOBgNVBAcTB1NhbGZvcmQxGjAY
BgNVBAoTEUNPTU9ETyBDQSBMaW1pdGVkMSswKQYDVQQDEyJDT01PRE8gUlNBIENlcnRpZmljYXRp
b24gQXV0aG9yaXR5MB4XDTEzMDExMDAwMDAwMFoXDTI4MDEwOTIzNTk1OVowgZcxCzAJBgNVBAYT
AkdCMRswGQYDVQQIExJHcmVhdGVyIE1hbmNoZXN0ZXIxEDAOBgNVBAcTB1NhbGZvcmQxGjAYBgNV
BAoTEUNPTU9ETyBDQSBMaW1pdGVkMT0wOwYDVQQDEzRDT01PRE8gUlNBIENsaWVudCBBdXRoZW50
aWNhdGlvbiBhbmQgU2VjdXJlIEVtYWlsIENBMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKC
AQEAvrOeV6wodnVAFsc4A5jTxhh2IVDzJXkLTLWg0X06WD6cpzEup/Y0dtmEatrQPTRI5Or1u6zf
+bGBSyD9aH95dDSmeny1nxdlYCeXIoymMv6pQHJGNcIDpFDIMypVpVSRsivlJTRENf+RKwrB6vcf
WlP8dSsE3Rfywq09N0ZfxcBa39V0wsGtkGWC+eQKiz4pBZYKjrc5NOpG9qrxpZxyb4o4yNNwTqza
aPpGRqXB7IMjtf7tTmU2jqPMLxFNe1VXj9XB1rHvbRikw8lBoNoSWY66nJN/VCJv5ym6Q0mdCbDK
CMPybTjoNCQuelc0IAaO4nLUXk0BOSxSxt8kCvsUtQIDAQABo4IBPDCCATgwHwYDVR0jBBgwFoAU
u69+Aj36pvE8hI6t7jiY7NkyMtQwHQYDVR0OBBYEFIKvbIz4xf6WYXzoHz0rcUhexIvAMA4GA1Ud
DwEB/wQEAwIBhjASBgNVHRMBAf8ECDAGAQH/AgEAMBEGA1UdIAQKMAgwBgYEVR0gADBMBgNVHR8E
RTBDMEGgP6A9hjtodHRwOi8vY3JsLmNvbW9kb2NhLmNvbS9DT01PRE9SU0FDZXJ0aWZpY2F0aW9u
QXV0aG9yaXR5LmNybDBxBggrBgEFBQcBAQRlMGMwOwYIKwYBBQUHMAKGL2h0dHA6Ly9jcnQuY29t
b2RvY2EuY29tL0NPTU9ET1JTQUFkZFRydXN0Q0EuY3J0MCQGCCsGAQUFBzABhhhodHRwOi8vb2Nz
cC5jb21vZG9jYS5jb20wDQYJKoZIhvcNAQEMBQADggIBAHhcsoEoNE887l9Wzp+XVuyPomsX9vP2
SQgG1NgvNc3fQP7TcePo7EIMERoh42awGGsma65u/ITse2hKZHzT0CBxhuhb6txM1n/y78e/4ZOs
0j8CGpfb+SJA3GaBQ+394k+z3ZByWPQedXLL1OdK8aRINTsjk/H5Ns77zwbjOKkDamxlpZ4TKSDM
KVmU/PUWNMKSTvtlenlxBhh7ETrN543j/Q6qqgCWgWuMAXijnRglp9fyadqGOncjZjaaSOGTTFB+
E2pvOUtY+hPebuPtTbq7vODqzCM6ryEhNhzf+enm0zlpXK7q332nXttNtjv7VFNYG+I31gnMrwfH
M5tdhYF/8v5UY5g2xANPECTQdu9vWPoqNSGDt87b3gXb1AiGGaI06vzgkejL580ul+9hz9D0S0U4
jkhJiA7EuTecP/CFtR72uYRBcunwwH3fciPjviDDAI9SnC/2aPY8ydehzuZutLbZdRJ5PDEJM/1t
yZR2niOYihZ+FCbtf3D9mB12D4ln9icgc7CwaxpNSCPt8i/GqK2HsOgkL3VYnwtx7cJUmpvVdZ4o
gnzgXtgtdk3ShrtOS1iAN2ZBXFiRmjVzmehoMof06r1xub+85hFQzVxZx5/bRaTKTlL8YXLI8nAb
R9HWdFqzcOoB/hxfEyIQpx9/s81rgzdEZOofSlZHynoSMYIDyjCCA8YCAQEwga0wgZcxCzAJBgNV
BAYTAkdCMRswGQYDVQQIExJHcmVhdGVyIE1hbmNoZXN0ZXIxEDAOBgNVBAcTB1NhbGZvcmQxGjAY
BgNVBAoTEUNPTU9ETyBDQSBMaW1pdGVkMT0wOwYDVQQDEzRDT01PRE8gUlNBIENsaWVudCBBdXRo
ZW50aWNhdGlvbiBhbmQgU2VjdXJlIEVtYWlsIENBAhEA4rtJSHkq7AnpxKUY8ZlYZjANBglghkgB
ZQMEAgEFAKCCAe0wGAYJKoZIhvcNAQkDMQsGCSqGSIb3DQEHATAcBgkqhkiG9w0BCQUxDxcNMjEx
MDI3MDYyNDQ5WjAvBgkqhkiG9w0BCQQxIgQgpxHELRaytHjXEnTyDQGidbJLTD1NYKV3jVUuRuHL
Vs0wgb4GCSsGAQQBgjcQBDGBsDCBrTCBlzELMAkGA1UEBhMCR0IxGzAZBgNVBAgTEkdyZWF0ZXIg
TWFuY2hlc3RlcjEQMA4GA1UEBxMHU2FsZm9yZDEaMBgGA1UEChMRQ09NT0RPIENBIExpbWl0ZWQx
PTA7BgNVBAMTNENPTU9ETyBSU0EgQ2xpZW50IEF1dGhlbnRpY2F0aW9uIGFuZCBTZWN1cmUgRW1h
aWwgQ0ECEQDiu0lIeSrsCenEpRjxmVhmMIHABgsqhkiG9w0BCRACCzGBsKCBrTCBlzELMAkGA1UE
BhMCR0IxGzAZBgNVBAgTEkdyZWF0ZXIgTWFuY2hlc3RlcjEQMA4GA1UEBxMHU2FsZm9yZDEaMBgG
A1UEChMRQ09NT0RPIENBIExpbWl0ZWQxPTA7BgNVBAMTNENPTU9ETyBSU0EgQ2xpZW50IEF1dGhl
bnRpY2F0aW9uIGFuZCBTZWN1cmUgRW1haWwgQ0ECEQDiu0lIeSrsCenEpRjxmVhmMA0GCSqGSIb3
DQEBAQUABIIBAJe5gI1YQt4RDVF/z0zUGp9Ur3bIRodBm3wQg70N6Tadz/fsBjYGMp6yT4Qbyqu7
4VrdapOV/vNwge0Wa74GXq3CkvrDzJPOlMHgIhKaJwTfKvKhQp4DcQxRKyH4wWE8fOdzBtZwASQh
gk4kaqfjlQ/xfEoLEPxTBQvAiBG4ps5nDKXcToeqg3wex9a9LuXTbvHwhoW8KbX57+XO/XdPCWRh
ACBNNtFQccDOtnI3csipKKwm/uVRu2WtxN4ciLkPRe/X6695RcDTwAunvugYGYXkVnWCECna1NRe
sT0heTRfStF3da2WJLD//pXeH4ZJoRQ/SxYqsr7w5SO3JIelYZIAAAAAAAA=


--=-N2uIjvIfDePtsDUY+x3E--



From xen-devel-bounces@lists.xenproject.org Wed Oct 27 07:19:52 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Oct 2021 07:19:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.216673.376367 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfdDk-0002Xy-39; Wed, 27 Oct 2021 07:19:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 216673.376367; Wed, 27 Oct 2021 07:19:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfdDk-0002Xr-0H; Wed, 27 Oct 2021 07:19:36 +0000
Received: by outflank-mailman (input) for mailman id 216673;
 Wed, 27 Oct 2021 07:19:34 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mfdDi-0002Xe-PK; Wed, 27 Oct 2021 07:19:34 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mfdDi-0005gt-IY; Wed, 27 Oct 2021 07:19:34 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mfdDi-0007oN-A6; Wed, 27 Oct 2021 07:19:34 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mfdDi-0008OD-9f; Wed, 27 Oct 2021 07:19:34 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=8I2x9SIVOny4r5TB1U17zgiFcLImNL/cj60FlDI6GrI=; b=FWyeDBOPDhjPnYMwxBg9MWbFac
	uqJrWhkG3QwkbbCsnyIXjbuzRvXMDN2UfGaxQobLc5KG2TbH2Rh73PnzF1a3u7Hdar6nBMRkgo9LH
	j6DA0suH2bBk/G+Ihgybpfmp+tBpr2BUmBAr0sRiAZuV6T7tegoZnoAJARV+dy24KDdY=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165885-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 165885: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=d25f27432f80a800a3592db128254c8140bd71bf
X-Osstest-Versions-That:
    linux=3906fe9bb7f1a2c8667ae54e967dc8690824f4ea
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 27 Oct 2021 07:19:34 +0000

flight 165885 linux-linus real [real]
flight 165891 linux-linus real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/165885/
http://logs.test-lab.xenproject.org/osstest/logs/165891/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 165891-retest

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 165868
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 165868
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165868
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 165868
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165868
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 165868
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 165868
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165868
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 linux                d25f27432f80a800a3592db128254c8140bd71bf
baseline version:
 linux                3906fe9bb7f1a2c8667ae54e967dc8690824f4ea

Last test of basis   165868  2021-10-25 23:39:26 Z    1 days
Testing same since   165885  2021-10-26 22:40:41 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Amit Pundir <amit.pundir@linaro.org>
  Arnd Bergmann <arnd@arndb.de>
  Bastien Roucariès <rouca@debian.org>
  Bjorn Andersson <bjorn.andersson@linaro.org>
  Christoph Niedermaier <cniedermaier@dh-electronics.com>
  Clément Bœsch <u@pkh.me>
  Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
  Florian Fainelli <f.fainelli@gmail.com>
  Frieder Schrempf <frieder.schrempf@kontron.de>
  Geert Uytterhoeven <geert+renesas@glider.be>
  Jim Quinlan <jim2101024@gmail.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Maxime Ripard <maxime@cerno.tech>
  Mikko Perttunen <mperttunen@nvidia.com>
  Paweł Anikiel <pan@semihalf.com>
  Philipp Zabel <p.zabel@pengutronix.de>
  Shawn Guo <shawnguo@kernel.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 fail    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   3906fe9bb7f1..d25f27432f80  d25f27432f80a800a3592db128254c8140bd71bf -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Wed Oct 27 07:35:05 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Oct 2021 07:35:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.216681.376381 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfdST-0004o0-GY; Wed, 27 Oct 2021 07:34:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 216681.376381; Wed, 27 Oct 2021 07:34:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfdST-0004nt-Cu; Wed, 27 Oct 2021 07:34:49 +0000
Received: by outflank-mailman (input) for mailman id 216681;
 Wed, 27 Oct 2021 07:34:48 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=AFjD=PP=suse.com=jgross@srs-us1.protection.inumbo.net>)
 id 1mfdSS-0004nn-Bq
 for xen-devel@lists.xenproject.org; Wed, 27 Oct 2021 07:34:48 +0000
Received: from smtp-out2.suse.de (unknown [195.135.220.29])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 5b85071e-36f8-11ec-8454-12813bfff9fa;
 Wed, 27 Oct 2021 07:34:46 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 4FE0C1FD40;
 Wed, 27 Oct 2021 07:34:45 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1621E13FE6;
 Wed, 27 Oct 2021 07:34:45 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id DRIJBBUBeWFwdAAAMHmgww
 (envelope-from <jgross@suse.com>); Wed, 27 Oct 2021 07:34:45 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5b85071e-36f8-11ec-8454-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1635320085; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=SGsc+rKVQp8jWOqk3u1cUh9KZPpTGB48MIUoFQFk5vk=;
	b=fP5RUCRDLdpSipyVlycKwnhcjPb5Yn8T+rOLbh+ODw3Jounzo8/8YQm5MG7Y4dhPZ5gPoQ
	6Fnr1JxDczdNjAEAx72VADnCCI/wLW6fIKMc4b487FPSvB/pHFrfGMnjmQ2fNXk6uWoeOp
	dfwqQUx0284iRrdFudkMYffj6qhzh5Q=
Subject: Re: [PATCH 2/3] automation: Linux 5.10.74 test-artifact
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 xen-devel@lists.xenproject.org, iwj@xenproject.org, cardoe@cardoe.com,
 wl@xen.org, anthony.perard@citrix.com,
 Stefano Stabellini <stefano.stabellini@xilinx.com>
References: <alpine.DEB.2.21.2110210831470.2311@sstabellini-ThinkPad-T480s>
 <20211021230839.10794-2-sstabellini@kernel.org>
 <19aa9196-eb5f-22a1-206c-c9c87ee79fa9@citrix.com>
 <alpine.DEB.2.21.2110221219300.2311@sstabellini-ThinkPad-T480s>
 <d559b765-9e38-00bd-039b-9c33845b8e54@suse.com>
 <alpine.DEB.2.21.2110251753200.4586@sstabellini-ThinkPad-T480s>
From: Juergen Gross <jgross@suse.com>
Message-ID: <8c0a2a97-04ab-4836-fc35-026dd7c122a4@suse.com>
Date: Wed, 27 Oct 2021 09:34:44 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.21.2110251753200.4586@sstabellini-ThinkPad-T480s>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="tkxxSisEHe8asd35vFCr4o0fdf4cwG2VA"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--tkxxSisEHe8asd35vFCr4o0fdf4cwG2VA
Content-Type: multipart/mixed; boundary="UWGaFghLhPaMNKLKLwItKwCoNmkXuYdNs";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 xen-devel@lists.xenproject.org, iwj@xenproject.org, cardoe@cardoe.com,
 wl@xen.org, anthony.perard@citrix.com,
 Stefano Stabellini <stefano.stabellini@xilinx.com>
Message-ID: <8c0a2a97-04ab-4836-fc35-026dd7c122a4@suse.com>
Subject: Re: [PATCH 2/3] automation: Linux 5.10.74 test-artifact
References: <alpine.DEB.2.21.2110210831470.2311@sstabellini-ThinkPad-T480s>
 <20211021230839.10794-2-sstabellini@kernel.org>
 <19aa9196-eb5f-22a1-206c-c9c87ee79fa9@citrix.com>
 <alpine.DEB.2.21.2110221219300.2311@sstabellini-ThinkPad-T480s>
 <d559b765-9e38-00bd-039b-9c33845b8e54@suse.com>
 <alpine.DEB.2.21.2110251753200.4586@sstabellini-ThinkPad-T480s>
In-Reply-To: <alpine.DEB.2.21.2110251753200.4586@sstabellini-ThinkPad-T480s>

--UWGaFghLhPaMNKLKLwItKwCoNmkXuYdNs
Content-Type: multipart/mixed;
 boundary="------------CB8D8CE8FB3D64D88EE57881"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------CB8D8CE8FB3D64D88EE57881
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 26.10.21 02:54, Stefano Stabellini wrote:
> On Mon, 25 Oct 2021, Juergen Gross wrote:
>> On 22.10.21 21:41, Stefano Stabellini wrote:
>>> +Juergen
>>>
>>> On Fri, 22 Oct 2021, Andrew Cooper wrote:
>>>> On 22/10/2021 00:08, Stefano Stabellini wrote:
>>>>> +# build depends
>>>>> +RUN apt-get update && \
>>>>> +    apt-get --quiet --yes install \
>>>>> +        build-essential \
>>>>> +        libssl-dev \
>>>>> +        bc \
>>>>> +        curl \
>>>>> +        flex \
>>>>> +        bison \
>>>>> +        libelf-dev \
>>>>> +        && \
>>>>> +    \
>>>>> +    # Build the kernel
>>>>> +    curl -fsSLO
>>>>> https://cdn.kernel.org/pub/linux/kernel/v5.x/linux-"$LINUX_VERSION"=
=2Etar.xz
>>>>> && \
>>>>> +    tar xvJf linux-"$LINUX_VERSION".tar.xz && \
>>>>> +    cd linux-"$LINUX_VERSION" && \
>>>>> +    make defconfig && \
>>>>> +    make xen.config && \
>>>>> +    cp .config .config.orig && \
>>>>> +    cat .config.orig | grep XEN | grep =3Dm |sed 's/=3Dm/=3Dy/g' >=
> .config
>>>>> && \
>>>>> +    make -j$(nproc) bzImage && \
>>>>
>>>> defconfig is huuuuge.=C2=A0 Can we use tinyconfig instead?
>>>>
>>>> Also, you want to turn off CONFIG_MODULES seeing as you only copy
>>>> bzImage to the test.
>>>>
>>>> This also fixes the fact that `grep XEN` also matches CONFIG_NETXEN_=
NIC
>>>> which has nothing to do with Xen.
>>>
>>> Tinyconfig would be a good idea but it crashes on QEMU with the appen=
ded
>>> boot log. I did:
>>>
>>> # make tinyconfig
>>> # make xen.config
>>> # make bzImage
>>>
>>> Of course we could have our own tailored special kernel config for th=
is
>>> kernel but I like the simplicify of "make tinyconfig" or "make
>>> defconfig" followed by "make xen.config".
>>>
>>> Unless you know one kconfig option or two that we need to add to
>>> tinyconfig to make it work my preference is to go with defconfig for
>>> now.
>>
>> You will need to add the dom0 and SMP related config options at least.=

>>
>> I'll have a look at config.xen, which is a little bit weird: it
>> configures the backends, but not dom0.
>=20
> Thanks, it would be good if make tinyconfig && make xen.config would
> just work on QEMU. In the meantime I'll keep defconfig for this test, w=
e
> can always improve later.

Can you please test the attached patch?


Juergen

--------------CB8D8CE8FB3D64D88EE57881
Content-Type: text/x-patch; charset=UTF-8;
 name="0001-x86-xen-update-xen.config.patch"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: attachment;
 filename="0001-x86-xen-update-xen.config.patch"

=46rom 8ffe2d58a3507dfd42996a38f0de66c1e7ca2c6a Mon Sep 17 00:00:00 2001
From: Juergen Gross <jgross@suse.com>
Date: Wed, 27 Oct 2021 09:05:28 +0200
Subject: [PATCH] x86/xen: update xen.config

Update some entries in xen.config:

- add ACPI as being required for running as dom0
- add SMP for convenience
- remove HIGHMEM64G as this option no longer exists
- remove XEN_MAX_DOMAIN_MEMORY as this option no longer exists

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 arch/x86/configs/xen.config | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/arch/x86/configs/xen.config b/arch/x86/configs/xen.config
index d9fc7139fd46..e59fdb0f6b67 100644
--- a/arch/x86/configs/xen.config
+++ b/arch/x86/configs/xen.config
@@ -1,6 +1,4 @@
 # global x86 required specific stuff
-# On 32-bit HIGHMEM4G is not allowed
-CONFIG_HIGHMEM64G=3Dy
 CONFIG_64BIT=3Dy
=20
 # These enable us to allow some of the
@@ -9,12 +7,13 @@ CONFIG_HYPERVISOR_GUEST=3Dy
 CONFIG_PCI=3Dy
 CONFIG_PCI_MSI=3Dy
 CONFIG_X86_MCE=3Dy
+CONFIG_ACPI=3Dy
 CONFIG_ACPI_PROCESSOR=3Dy
 CONFIG_CPU_FREQ=3Dy
+CONFIG_SMP=3Dy
=20
 # x86 xen specific config options
 CONFIG_XEN_PVH=3Dy
-CONFIG_XEN_MAX_DOMAIN_MEMORY=3D500
 CONFIG_XEN_SAVE_RESTORE=3Dy
 # CONFIG_XEN_DEBUG_FS is not set
 CONFIG_XEN_MCE_LOG=3Dy
--=20
2.26.2


--------------CB8D8CE8FB3D64D88EE57881
Content-Type: application/pgp-keys;
 name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Transfer-Encoding: quoted-printable
Content-Description: OpenPGP public key
Content-Disposition: attachment;
 filename="OpenPGP_0xB0DE9DD628BF132F.asc"

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy=
cWx
w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O=
f8Z
d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y=
9bf
IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq=
G7/
377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR=
3Jv
c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA=
QIe
AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT=
hpw
dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0=
MbD
1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv=
oPH
Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v=
5QL
+qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ=
2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC=
QoL
BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr=
Wf0
teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC=
/nu
AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh=
ITT
d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm=
XBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz=
80h
SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC=
AcD
AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn=
FOX
gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1=
jnD
kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0=
N51
N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l=
otu
fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1=
tqS
EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA=
hsD
BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3=
g3O
ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5=
dM7
wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5=
D+j
LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm=
V2x
AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N=
Eaw
QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW=
nHI
s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR=
wgn
BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV=
bVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk=
pEd
IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA=
QAB
wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw=
Tbe
8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1=
vJz
Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8=
VGi
wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW=
svi
uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX=
zXs
ZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------CB8D8CE8FB3D64D88EE57881--

--UWGaFghLhPaMNKLKLwItKwCoNmkXuYdNs--

--tkxxSisEHe8asd35vFCr4o0fdf4cwG2VA
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmF5ARQFAwAAAAAACgkQsN6d1ii/Ey/c
vQgAhyZfg14tPMUJk4abuM+ZGOY3DP2urCyEOP4fWRI//iaWUSg5Uh6OPTBTgqv8VUJOHK1sc5SI
vTcDncRUNTeesyea/T+b+QfpqZhqOwZ/fbJo/Xggxfb8SKWsg9FWRubAsBXgglRlzEh/PV8TRm2U
EnzLhkFOJI2dG/k3HM44oJGsg0ceN3oxumALmTVRFOr+crIVLVVyE6pMSSmtmxaJf30yfkjgaVRz
OTOvEoE6mMcNBOwr8Ers4TYtd/HN83AElLtrsDBncg8pJ5jH+7m6V5u3w8WBK9ac5doLlSJNWtEn
8I3h0CO3YWAN/jbeKjlQn5/6z9uXAvY6rM/xNlb3mQ==
=6BSE
-----END PGP SIGNATURE-----

--tkxxSisEHe8asd35vFCr4o0fdf4cwG2VA--


From xen-devel-bounces@lists.xenproject.org Wed Oct 27 08:14:01 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Oct 2021 08:14:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.216693.376392 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfe47-000146-Rn; Wed, 27 Oct 2021 08:13:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 216693.376392; Wed, 27 Oct 2021 08:13:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfe47-00013z-OE; Wed, 27 Oct 2021 08:13:43 +0000
Received: by outflank-mailman (input) for mailman id 216693;
 Wed, 27 Oct 2021 08:13:43 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=EkRf=PP=oderland.se=josef@srs-us1.protection.inumbo.net>)
 id 1mfe47-00013t-32
 for xen-devel@lists.xenproject.org; Wed, 27 Oct 2021 08:13:43 +0000
Received: from office.oderland.com (unknown [91.201.60.5])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id cb6cf974-36fd-11ec-8454-12813bfff9fa;
 Wed, 27 Oct 2021 08:13:41 +0000 (UTC)
Received: from [193.180.18.161] (port=56998 helo=[10.137.0.14])
 by office.oderland.com with esmtpsa (TLS1.2) tls
 TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2)
 (envelope-from <josef@oderland.se>)
 id 1mfe44-0082c3-35; Wed, 27 Oct 2021 10:13:40 +0200
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: cb6cf974-36fd-11ec-8454-12813bfff9fa
Message-ID: <4af6ccf5-1e52-be65-0acc-cbc53b724dfe@oderland.se>
Date: Wed, 27 Oct 2021 10:13:36 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:93.0) Gecko/20100101
 Thunderbird/93.0
Subject: Re: [PATCH v2] PCI/MSI: Re-add checks for skip masking MSI-X on Xen
 PV
Content-Language: en-US
To: David Woodhouse <dwmw2@infradead.org>, Jason Andryuk
 <jandryuk@gmail.com>, Marc Zyngier <maz@kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>, linux-pci@vger.kernel.org,
 xen-devel <xen-devel@lists.xenproject.org>,
 Thomas Gleixner <tglx@linutronix.de>, Juergen Gross <jgross@suse.com>,
 Boris Ostrovsky <boris.ostrovsky@oracle.com>
References: <20211019202906.GA2397931@bhelgaas>
 <5f050b30-fa1c-8387-0d6b-a667851b34b0@oderland.se>
 <877de7dfl2.wl-maz@kernel.org>
 <CAKf6xpt=ZYGyJXMwM7ccOWkx71R0O-QeLjkBF-LtdDcbSnzHsA@mail.gmail.com>
 <3434cb2d-4060-7969-d4c4-089c68190527@oderland.se>
 <90277228-cf14-0cfa-c95e-d42e7d533353@oderland.se>
 <CAKf6xpvZ8fxuBY4BZ51UZzF92zDUcvfav9_pOT7F3w-Bc8YkwA@mail.gmail.com>
 <c4d27d67-1027-e72b-c5bf-5546c5b0e2e9@oderland.se>
 <ee23eafce1993ba7da8fdf4c03cedbcb3362ef1d.camel@infradead.org>
From: Josef Johansson <josef@oderland.se>
In-Reply-To: <ee23eafce1993ba7da8fdf4c03cedbcb3362ef1d.camel@infradead.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-AntiAbuse: This header was added to track abuse, please include it with any abuse report
X-AntiAbuse: Primary Hostname - office.oderland.com
X-AntiAbuse: Original Domain - lists.xenproject.org
X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12]
X-AntiAbuse: Sender Address Domain - oderland.se
X-Get-Message-Sender-Via: office.oderland.com: authenticated_id: josjoh@oderland.se
X-Authenticated-Sender: office.oderland.com: josjoh@oderland.se

On 10/27/21 08:24, David Woodhouse wrote:
> On Mon, 2021-10-25 at 21:21 +0200, Josef Johansson wrote:
>> +       if (!(pci_msi_ignore_mask || entry->msi_attrib.is_virtual))
> Is it just me, or is that a lot easier to read if you write it as the
> tautologically-identical (!pci_msi_ignore_mask && !entry->…is_virtual)?
Sure, the less parentheses the better.
>
>> @@ -546,7 +548,8 @@ static int msi_capability_init(struct pci_dev *dev, int nvec,
>>                 return -ENOMEM;
>>         /* All MSIs are unmasked by default; mask them all *
>> -       pci_msi_mask(entry, msi_multi_mask(entry))
>> +       if (!pci_msi_ignore_mask)
>> +               pci_msi_mask(entry, msi_multi_mask(entry));
>>
>>         list_add_tail(&entry->list, dev_to_msi_list(&dev->dev));
>
> Hm, I thought that older kernels *did* do this part (or at least the
> later ones in pci_msi*_hutdown). I was watching it when I did the Xen
> hosting implementation I mentioned before; even a hack to unmask them
> all when the VM was started, wasn't working because the guest would
> *mask* all MSI-X, just never unmask them again.
When you're saying *did* here, do you mean that they mask even though
pci_msi_ignore_mask = 0?

As I was looking through pre Thomas' changes and post, it seems that we
did indeed
check for pci_msi_ignore_mask in msi_capability_init.
>
> I wonder if we should rename 'pci_msi_ignore_mask' to something with
> Xen in its name because Xen is the only user of this abomination (which
> fundamentally seems to require that the virtual hardware use MSI
> entries even while they're masked, so hopefully nobody else would
> *ever* do such a thing), and the required behaviour is very Xen-
> specific.
Second that, i.e. pci_msi_masked_by_xen.


From xen-devel-bounces@lists.xenproject.org Wed Oct 27 08:25:48 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Oct 2021 08:25:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.216699.376402 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfeFe-0002aj-UK; Wed, 27 Oct 2021 08:25:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 216699.376402; Wed, 27 Oct 2021 08:25:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfeFe-0002ac-RO; Wed, 27 Oct 2021 08:25:38 +0000
Received: by outflank-mailman (input) for mailman id 216699;
 Wed, 27 Oct 2021 08:25:37 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=D8pr=PP=gmail.com=andr2000@srs-us1.protection.inumbo.net>)
 id 1mfeFd-0002aW-O6
 for xen-devel@lists.xenproject.org; Wed, 27 Oct 2021 08:25:37 +0000
Received: from mail-ed1-x532.google.com (unknown [2a00:1450:4864:20::532])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id d97cefca-ba38-454d-a69e-01ec514d62c0;
 Wed, 27 Oct 2021 08:25:36 +0000 (UTC)
Received: by mail-ed1-x532.google.com with SMTP id s1so7379110edd.3
 for <xen-devel@lists.xenproject.org>; Wed, 27 Oct 2021 01:25:36 -0700 (PDT)
Received: from localhost.localdomain ([185.199.97.5])
 by smtp.gmail.com with ESMTPSA id bq4sm10445845ejb.43.2021.10.27.01.25.34
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Wed, 27 Oct 2021 01:25:34 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d97cefca-ba38-454d-a69e-01ec514d62c0
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:mime-version
         :content-transfer-encoding;
        bh=40XBeXCNftA1Htax/SKjqvW6FDZwTVJ23WgtrKywO2A=;
        b=e5M3iJtfvFrqEoi4LavM3LCq1dJKMwQYRSuUlpJLnN+0hbirsQVM1+cPjfSDql6VwV
         PMXT72d66F11qk3PI2GtqLyyURucj8LzTjFfX1JJxzL+RTQ8c2owbL+U8wj/Hcpyped7
         QkN0ydd6+5Ugqea/DkldHjnk0yxQAb2HbikhnYSBrNHJUlZXvxJi49AnJMZWW77rQQvH
         /sFJ+talYB2JoxYfqTXya6dYMqZu2XCAn1omhiLWw5GpqL+yjLbCDv72qK/O6A5X15ER
         r1z5adi9NiMLRyKU9EG54JFNIClmNKxJRDO5JI0TrQ9r7T5GcyxiM0w+BRFFBWLfbEBe
         cbnQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version
         :content-transfer-encoding;
        bh=40XBeXCNftA1Htax/SKjqvW6FDZwTVJ23WgtrKywO2A=;
        b=uHA35SXVEqhSg6uxDj0cQW5az1jQFTLy1Lx/9MZuZoINDdkpdI/Ot6gsFrC4IioBSK
         6aPq+53anV+SGMvLGOGfQRSE09b3gAv7lCw25Q4uNDSvO0DIlIG3MpeKK62RT2Y3khHU
         XA2aO2nGoJeJr/NQFUnM2DqVKeimHza7msdy1oee7oPrhvkvjp+1GbVmfaZ/HBw3O74c
         srBV3RGQYoqc80m6J9M0SwgYmUnh1g1olav9VCXK5LEYpCdt1BKX2lPKgLlXH6qy7a26
         nEEnJCsh9/O1NoK1sz9BuDeTOKh6go9sYRJICwTQ16vimZeun3+5LE7xVDgwQv7yQw/O
         Ru+Q==
X-Gm-Message-State: AOAM5301fu6cwQimrATFTREMXCYDCmMqXGoYvAfN+1nxMUro7+2BW4Ia
	xAEl+6lFF7z0mEsNBm5VzwMgJQYnXkv56A==
X-Google-Smtp-Source: ABdhPJxa6yp1okF3IJP5ZcBVoHpwuKUv+gzFnb6zGnfpEO7ZQ40dTGZBLdy3XxqVFIj30clJyL6WBg==
X-Received: by 2002:a05:6402:1256:: with SMTP id l22mr11845063edw.240.1635323135397;
        Wed, 27 Oct 2021 01:25:35 -0700 (PDT)
From: Oleksandr Andrushchenko <andr2000@gmail.com>
To: xen-devel@lists.xenproject.org
Cc: julien@xen.org,
	sstabellini@kernel.org,
	iwj@xenproject.org,
	bertrand.marquis@arm.com,
	rahul.singh@arm.com,
	Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Subject: [PATCH] xen/arm: fix SBDF calculation for vPCI MMIO handlers
Date: Wed, 27 Oct 2021 11:25:33 +0300
Message-Id: <20211027082533.1406015-1-andr2000@gmail.com>
X-Mailer: git-send-email 2.25.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>

While in vPCI MMIO trap handlers for the guest PCI host bridge it is not
enough for SBDF translation to simply call VPCI_ECAM_BDF(info->gpa) as
the base address may not be aligned in the way that the translation
always work. If not adjusted with respect to the base address it may not be
able to properly convert SBDF and crashes:

(XEN) vpci_mmio_read 0000:65:1a.0 reg 8bc gpa e65d08bc
(XEN) Data Abort Trap. Syndrome=0x6
(XEN) Walking Hypervisor VA 0x467a28bc on CPU0 via TTBR 0x00000000481d5000

Fix this by adjusting the gpa with respect to the host bridge base address
in a way as it is done for x86.

Fixes: d59168dc05a5 ("xen/arm: Enable the existing x86 virtual PCI support for ARM")

Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
---
 xen/arch/arm/vpci.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/xen/arch/arm/vpci.c b/xen/arch/arm/vpci.c
index 8f40a0dec6d2..23f45386f4b3 100644
--- a/xen/arch/arm/vpci.c
+++ b/xen/arch/arm/vpci.c
@@ -24,7 +24,7 @@ static int vpci_mmio_read(struct vcpu *v, mmio_info_t *info,
     unsigned long data;
 
     /* We ignore segment part and always handle segment 0 */
-    sbdf.sbdf = VPCI_ECAM_BDF(info->gpa);
+    sbdf.sbdf = VPCI_ECAM_BDF(info->gpa - GUEST_VPCI_ECAM_BASE);
 
     if ( vpci_ecam_read(sbdf, ECAM_REG_OFFSET(info->gpa),
                         1U << info->dabt.size, &data) )
@@ -44,7 +44,7 @@ static int vpci_mmio_write(struct vcpu *v, mmio_info_t *info,
     pci_sbdf_t sbdf;
 
     /* We ignore segment part and always handle segment 0 */
-    sbdf.sbdf = VPCI_ECAM_BDF(info->gpa);
+    sbdf.sbdf = VPCI_ECAM_BDF(info->gpa - GUEST_VPCI_ECAM_BASE);
 
     return vpci_ecam_write(sbdf, ECAM_REG_OFFSET(info->gpa),
                            1U << info->dabt.size, r);
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Wed Oct 27 08:27:30 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Oct 2021 08:27:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.216705.376413 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfeHN-0003BI-AU; Wed, 27 Oct 2021 08:27:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 216705.376413; Wed, 27 Oct 2021 08:27:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfeHN-0003BB-7X; Wed, 27 Oct 2021 08:27:25 +0000
Received: by outflank-mailman (input) for mailman id 216705;
 Wed, 27 Oct 2021 08:27:23 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=hUNZ=PP=desiato.srs.infradead.org=BATV+d69366bb991552d278a6+6639+infradead.org+dwmw2@srs-us1.protection.inumbo.net>)
 id 1mfeHJ-0003Az-8S
 for xen-devel@lists.xenproject.org; Wed, 27 Oct 2021 08:27:23 +0000
Received: from desiato.infradead.org (unknown
 [2001:8b0:10b:1:d65d:64ff:fe57:4e05])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 0f90c6cd-4eff-4d10-ad05-9ada09e376a6;
 Wed, 27 Oct 2021 08:27:17 +0000 (UTC)
Received: from [2a01:4c8:1042:994a:f240:791a:356:222b] (helo=[IPv6:::1])
 by desiato.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1mfeH5-00CWGM-QL; Wed, 27 Oct 2021 08:27:08 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0f90c6cd-4eff-4d10-ad05-9ada09e376a6
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type
	:MIME-Version:Message-ID:References:In-Reply-To:Subject:CC:To:From:Date:
	Sender:Reply-To:Content-ID:Content-Description;
	bh=bKTTpLjfT+n7D7d5y1NK/WDhv2vPZZwx7SAZZ1V4Qk8=; b=p160wzfSkkAtYownhlB08CDof4
	0Rg4aZGlAEx6gTpzXTIZH5K7do2NBBrbHQNJWFYtY2bn//b17UD3/ADazi/f7hK88TcrmXkckro/v
	McbkBXEAv23iNzDU32O36DXEItsJohT6Tmky89El7yZT19Sm0h7sISOCoop2EWqbi1Zz34b19uvpe
	omQZVnECTKSI/43I2dIsfwCOm0eTtvitCjp5zz74i8CEWhVGIOSPs0PNeqFXoMt852QQwty2Edvjr
	2zdBcKS1aWMVq0w8Cqol4ektwLIETr19CKh3+00GgrYKqH0hQUW58ZwD8N0ORiL3Om5wOvwzjJ2nn
	Z4ceSGzg==;
Date: Wed, 27 Oct 2021 09:26:54 +0100
From: David Woodhouse <dwmw2@infradead.org>
To: Josef Johansson <josef@oderland.se>, Jason Andryuk <jandryuk@gmail.com>,
 Marc Zyngier <maz@kernel.org>
CC: Bjorn Helgaas <helgaas@kernel.org>, linux-pci@vger.kernel.org,
 xen-devel <xen-devel@lists.xenproject.org>,
 Thomas Gleixner <tglx@linutronix.de>, Juergen Gross <jgross@suse.com>,
 Boris Ostrovsky <boris.ostrovsky@oracle.com>
Subject: =?US-ASCII?Q?Re=3A_=5BPATCH_v2=5D_PCI/MSI=3A_Re-add_chec?= =?US-ASCII?Q?ks_for_skip_masking_MSI-X_on_Xen_PV?=
User-Agent: K-9 Mail for Android
In-Reply-To: <4af6ccf5-1e52-be65-0acc-cbc53b724dfe@oderland.se>
References: <20211019202906.GA2397931@bhelgaas> <5f050b30-fa1c-8387-0d6b-a667851b34b0@oderland.se> <877de7dfl2.wl-maz@kernel.org> <CAKf6xpt=ZYGyJXMwM7ccOWkx71R0O-QeLjkBF-LtdDcbSnzHsA@mail.gmail.com> <3434cb2d-4060-7969-d4c4-089c68190527@oderland.se> <90277228-cf14-0cfa-c95e-d42e7d533353@oderland.se> <CAKf6xpvZ8fxuBY4BZ51UZzF92zDUcvfav9_pOT7F3w-Bc8YkwA@mail.gmail.com> <c4d27d67-1027-e72b-c5bf-5546c5b0e2e9@oderland.se> <ee23eafce1993ba7da8fdf4c03cedbcb3362ef1d.camel@infradead.org> <4af6ccf5-1e52-be65-0acc-cbc53b724dfe@oderland.se>
Message-ID: <980274EA-3A57-412A-BCE9-1950989AD64E@infradead.org>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-SRS-Rewrite: SMTP reverse-path rewritten from <dwmw2@infradead.org> by desiato.infradead.org. See http://www.infradead.org/rpr.html



On 27 October 2021 09:13:36 BST, Josef Johansson <josef@oderland=2Ese> wro=
te:
>On 10/27/21 08:24, David Woodhouse wrote:
>> On Mon, 2021-10-25 at 21:21 +0200, Josef Johansson wrote:
>>> +       if (!(pci_msi_ignore_mask || entry->msi_attrib=2Eis_virtual))
>> Is it just me, or is that a lot easier to read if you write it as the
>> tautologically-identical (!pci_msi_ignore_mask && !entry->=E2=80=A6is_v=
irtual)?
>Sure, the less parentheses the better=2E
>>
>>> @@ -546,7 +548,8 @@ static int msi_capability_init(struct pci_dev *dev=
, int nvec,
>>>                 return -ENOMEM;
>>>         /* All MSIs are unmasked by default; mask them all *
>>> -       pci_msi_mask(entry, msi_multi_mask(entry))
>>> +       if (!pci_msi_ignore_mask)
>>> +               pci_msi_mask(entry, msi_multi_mask(entry));
>>>
>>>         list_add_tail(&entry->list, dev_to_msi_list(&dev->dev));
>>
>> Hm, I thought that older kernels *did* do this part (or at least the
>> later ones in pci_msi*_hutdown)=2E I was watching it when I did the Xen
>> hosting implementation I mentioned before; even a hack to unmask them
>> all when the VM was started, wasn't working because the guest would
>> *mask* all MSI-X, just never unmask them again=2E
>When you're saying *did* here, do you mean that they mask even though
>pci_msi_ignore_mask =3D 0?
>
>As I was looking through pre Thomas' changes and post, it seems that we
>did indeed
>check for pci_msi_ignore_mask in msi_capability_init=2E


Ah, maybe not so old=2E When my VMM part didn't work with standard ancient=
 distro test images I turned to a relatively current git HEAD=2E

So I was probably just unfortunate, and masking MSI under Xen at setup tim=
e was a temporary aberration; on older kernels the hack of enabling each ve=
ctor at startup might have worked?

I'll disable my eventual VMM-side fix and retest different guest kernels t=
o be sure (and to make sure I have the full permutation set for regression =
testing because regardless of how insane Xen's behaviour is, I need to fait=
hfully emulate it for every Linux kernel behaviour that existed)=2E


--=20
Sent from my Android device with K-9 Mail=2E Please excuse my brevity=2E


From xen-devel-bounces@lists.xenproject.org Wed Oct 27 08:37:58 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Oct 2021 08:37:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.216721.376443 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfeRC-0005Lj-N0; Wed, 27 Oct 2021 08:37:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 216721.376443; Wed, 27 Oct 2021 08:37:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfeRC-0005Lc-JG; Wed, 27 Oct 2021 08:37:34 +0000
Received: by outflank-mailman (input) for mailman id 216721;
 Wed, 27 Oct 2021 08:37:33 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=D8pr=PP=gmail.com=andr2000@srs-us1.protection.inumbo.net>)
 id 1mfeRB-0005LU-Lw
 for xen-devel@lists.xenproject.org; Wed, 27 Oct 2021 08:37:33 +0000
Received: from mail-ed1-x52b.google.com (unknown [2a00:1450:4864:20::52b])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 8376256a-e93e-43d8-92a3-a152ccc425bf;
 Wed, 27 Oct 2021 08:37:32 +0000 (UTC)
Received: by mail-ed1-x52b.google.com with SMTP id h7so7427422ede.8
 for <xen-devel@lists.xenproject.org>; Wed, 27 Oct 2021 01:37:32 -0700 (PDT)
Received: from localhost.localdomain ([185.199.97.5])
 by smtp.gmail.com with ESMTPSA id dt4sm10384213ejb.27.2021.10.27.01.37.30
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Wed, 27 Oct 2021 01:37:31 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8376256a-e93e-43d8-92a3-a152ccc425bf
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:mime-version
         :content-transfer-encoding;
        bh=nKdpva6p5fpUHBXlhpaAq3a17KOb7MYX4+nJD3bMK0k=;
        b=SZsQKvfK4kBNrvX2rvB1GEFu1s8yx1LwCm2WSl6VGCwSkI3QpELhP1PqED5KqmN9qD
         +Eqz+u4wF0mL3vcLupen01QticrTkajV/1YFrVL1QMoQW84v+/6SvKnAfza2wliJK+BU
         vC0gAytBbOEn/V06hMfFFfZLeHlMsIqeq8T0BuCmtzj9xqkIFlZT6CaWiuGRssk8IJEd
         XSS7P/ZStXtLo+iCPXvdYAxi1TTyx1mOR/lFVhTqT8FA2x1rxgaiL7tzO+1HW/aaysSC
         /rP8Hvmb/yXlzyzf3Pjh9W8h59nFGBTuIWDzu/uIiBmPNZytbpl3I0DKr/LRG1JWWUbf
         pONw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version
         :content-transfer-encoding;
        bh=nKdpva6p5fpUHBXlhpaAq3a17KOb7MYX4+nJD3bMK0k=;
        b=ScTETFe1VXvVlulSuHjokuIdZjWPWjvxhk3alIpS1CzDyHehFtUGN8diC7r0e2lHZU
         MWjUukkpnpsY7J6aOEgnPISSEhEuOXm9xdEU5EltNuxD4CQbVO+eDdtJRs1SwgCbEnoq
         +1e+DkKyZhpW22XsqFFXBcuyskw20oNwk9rMF59unOExThKAL+Bv3ZomZkevWeUpfYIc
         VPAlERfZFHEnEWlP454SxQiz02HQK71gBPEF4Uz+yd4THqKYa5dEX2M8SrmeNK0e/xVX
         EYx7mptiGoovgIDsmworDuFjn0tXYAEm3W+dv6eGcxKKPJDe4SPd7FUIG+PB/Ub6dGUy
         vlgw==
X-Gm-Message-State: AOAM5300/4Zo/7fS1XTeN2JI/HG3JY1HB2PRUax6hC5y9UHStMPsG8SX
	NSOAe1hVEaVUIiq7f8hmP98ASWFpSXYWiA==
X-Google-Smtp-Source: ABdhPJxIbRnfGTC7i7uLo6/WI1E3MYCAD/qD0/azXuAkcJrdj4QMZ/YwmRywiWIegl40UkZWWvomVA==
X-Received: by 2002:a05:6402:1e95:: with SMTP id f21mr18468968edf.160.1635323851935;
        Wed, 27 Oct 2021 01:37:31 -0700 (PDT)
From: Oleksandr Andrushchenko <andr2000@gmail.com>
To: xen-devel@lists.xenproject.org
Cc: julien@xen.org,
	sstabellini@kernel.org,
	iwj@xenproject.org,
	bertrand.marquis@arm.com,
	rahul.singh@arm.com,
	Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Subject: [PATCH] xen/arm: do not try to add pci-domain for disabled devices
Date: Wed, 27 Oct 2021 11:37:30 +0300
Message-Id: <20211027083730.1406947-1-andr2000@gmail.com>
X-Mailer: git-send-email 2.25.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>

If a PCI host bridge device is present in the device tree, but is
disabled, then its PCI host bridge driver was not instantiated.
This results in the following panic during Xen start:

(XEN) Device tree generation failed (-22).
(XEN)
(XEN) ****************************************
(XEN) Panic on CPU 0:
(XEN) Could not set up DOM0 guest OS
(XEN) ****************************************

Fix this by not adding linux,pci-domain property for hwdom if it is
neither available nor device enabled.

Fixes: 4cfab4425d39 ("xen/arm: Add linux,pci-domain property for hwdom if not available.")

Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
---
 xen/arch/arm/domain_build.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
index 124ade09123a..beeecf84a209 100644
--- a/xen/arch/arm/domain_build.c
+++ b/xen/arch/arm/domain_build.c
@@ -747,7 +747,8 @@ static int __init write_properties(struct domain *d, struct kernel_info *kinfo,
             return res;
     }
 
-    if ( is_pci_passthrough_enabled() && dt_device_type_is_equal(node, "pci") )
+    if ( is_pci_passthrough_enabled() && dt_device_type_is_equal(node, "pci") &&
+         dt_device_is_available(node) )
     {
         if ( !dt_find_property(node, "linux,pci-domain", NULL) )
         {
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Wed Oct 27 08:45:45 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Oct 2021 08:45:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.216745.376459 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfeYz-0007FV-Hi; Wed, 27 Oct 2021 08:45:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 216745.376459; Wed, 27 Oct 2021 08:45:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfeYz-0007FO-En; Wed, 27 Oct 2021 08:45:37 +0000
Received: by outflank-mailman (input) for mailman id 216745;
 Wed, 27 Oct 2021 08:45:36 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5kU4=PP=linutronix.de=tglx@srs-us1.protection.inumbo.net>)
 id 1mfeYx-0007FI-Fi
 for xen-devel@lists.xenproject.org; Wed, 27 Oct 2021 08:45:35 +0000
Received: from galois.linutronix.de (unknown [193.142.43.55])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 3f43c9c9-3702-11ec-8456-12813bfff9fa;
 Wed, 27 Oct 2021 08:45:34 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3f43c9c9-3702-11ec-8456-12813bfff9fa
From: Thomas Gleixner <tglx@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1635324332;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=k/OESFTM/lB7AHIqBru+EjPila2/PBI8kXu3SGoA/xs=;
	b=1O7+Xe0fRLruaNrwt8+UW83HybEoVPrPKRTGETsTswE/iA/L5454bGK3qIYEbl9hRTW9Ox
	F6I1PFpxkR0r5V6M7fHwef+wMYi6DsnfmXmZSe7xe30jDCwgnEeB6tvmDMOtGZjllIDGBq
	DzLseKGvv+IFI8p5By1CxI7Qg8WeEYRroNnVVrcwdZmq3lebirT0UaOFhsT1MjdBF1UCTv
	MF6QfB6TiAypPRSmkDrsqCelULxefGlwNtwWntgXG5A68wuszcnZA4Ody+EIMRxHjwbKt0
	t8heATqPGiqC3zT3bPdCgfm5mL9yM5ksIuo5VbOMSXTbnsp6K4dA/aP/znRisw==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1635324332;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=k/OESFTM/lB7AHIqBru+EjPila2/PBI8kXu3SGoA/xs=;
	b=xF3jfcyPV3qmiqlxQdURqI+hvdEKKydZtWMoHAKqSJp61D2nH7H+nNIm7zqY4TrS4q4QPP
	6UpaskOsn1qEC3Aw==
To: Jason Andryuk <jandryuk@gmail.com>, josef@oderland.se
Cc: boris.ostrovsky@oracle.com, helgaas@kernel.org, jandryuk@gmail.com,
 jgross@suse.com, linux-pci@vger.kernel.org, maz@kernel.org,
 xen-devel@lists.xenproject.org
Subject: Re: [PATCH] PCI/MSI: Fix masking MSI/MSI-X on Xen PV
In-Reply-To: <20211025012503.33172-1-jandryuk@gmail.com>
References: <90277228-cf14-0cfa-c95e-d42e7d533353@oderland.se>
 <20211025012503.33172-1-jandryuk@gmail.com>
Date: Wed, 27 Oct 2021 10:45:31 +0200
Message-ID: <87fssmg8k4.ffs@tglx>
MIME-Version: 1.0
Content-Type: text/plain

On Sun, Oct 24 2021 at 21:25, Jason Andryuk wrote:
> diff --git a/drivers/pci/msi.c b/drivers/pci/msi.c
> index 4b4792940e86..478536bafc39 100644
> --- a/drivers/pci/msi.c
> +++ b/drivers/pci/msi.c
> @@ -148,6 +148,9 @@ static noinline void pci_msi_update_mask(struct msi_desc *desc, u32 clear, u32 s
>  	raw_spinlock_t *lock = &desc->dev->msi_lock;
>  	unsigned long flags;
>  
> +	if (pci_msi_ignore_mask)
> +		return;
> +
>  	raw_spin_lock_irqsave(lock, flags);
>  	desc->msi_mask &= ~clear;
>  	desc->msi_mask |= set;
> @@ -181,6 +184,9 @@ static void pci_msix_write_vector_ctrl(struct msi_desc *desc, u32 ctrl)
>  {
>  	void __iomem *desc_addr = pci_msix_desc_addr(desc);
>  
> +	if (pci_msi_ignore_mask)
> +		return;
> +
>  	writel(ctrl, desc_addr + PCI_MSIX_ENTRY_VECTOR_CTRL);
>  }
>  
> @@ -200,7 +206,7 @@ static inline void pci_msix_unmask(struct msi_desc *desc)
>  
>  static void __pci_msi_mask_desc(struct msi_desc *desc, u32 mask)
>  {
> -	if (pci_msi_ignore_mask || desc->msi_attrib.is_virtual)
> +	if (desc->msi_attrib.is_virtual)
>  		return;
>  
>  	if (desc->msi_attrib.is_msix)
> @@ -211,7 +217,7 @@ static void __pci_msi_mask_desc(struct msi_desc *desc, u32 mask)
>  
>  static void __pci_msi_unmask_desc(struct msi_desc *desc, u32 mask)
>  {
> -	if (pci_msi_ignore_mask || desc->msi_attrib.is_virtual)
> +	if (desc->msi_attrib.is_virtual)
>  		return;
>  
>  	if (desc->msi_attrib.is_msix)

No, really. This is horrible and incomplete. The right thing to do is to
move the check back into the low level accessors and remove it from the
call sites simply because the low level accessors can be reached not
only from the mask/unmask functions. But the above also fails to respect
msi_attrib.maskbit... I'll send out a proper fix in a few.

Thanks,

        tglx


From xen-devel-bounces@lists.xenproject.org Wed Oct 27 09:00:04 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Oct 2021 09:00:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.216752.376471 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfemi-0000Nu-Qq; Wed, 27 Oct 2021 08:59:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 216752.376471; Wed, 27 Oct 2021 08:59:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfemi-0000Nn-Nc; Wed, 27 Oct 2021 08:59:48 +0000
Received: by outflank-mailman (input) for mailman id 216752;
 Wed, 27 Oct 2021 08:59:47 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Ie0f=PP=citrix.com=roger.pau@srs-us1.protection.inumbo.net>)
 id 1mfemh-0000Nh-KY
 for xen-devel@lists.xenproject.org; Wed, 27 Oct 2021 08:59:47 +0000
Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 3b7aa846-3704-11ec-8457-12813bfff9fa;
 Wed, 27 Oct 2021 08:59:46 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3b7aa846-3704-11ec-8457-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1635325186;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=cwB0P2NG5qga9grOdKtKddZH9tVmsVPUyX/H9XijgDk=;
  b=AoFko7xFVsinuVz0QiJSC7bx1dE0apOTLIgSnDoL3L7+y1WWYiMT2OVp
   W46jV4bKf+lDtkMULyZZVsvyQD+XY303Kpk1gfsX31Bk9ZHpDT6iMH2g5
   /ExIPlYKgfYoN/g3hI6lj6bZ5X0nqeGku4awnLXFCE3L6ir4EpvfHR9/G
   0=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: +weyhMNiRvdofmfxxBNgLI+0YDLjWy20B8eA3nI5XF7ZbYtRKwIi3gy6mjeGtfpimoDdnQZq0H
 F8q+m/mIbDfnnOtTrsfjwzlFSww/d+cuuhNEuzn2GDEd5xkrWf9CRSPhw2qcPWiSFD9Vf5Ivdk
 pntNmBibYvEAXqkk49XWJhQLhUvS9W5tBKN0TSuUtbJzXkFc4xBZHAiWgLL1ct/dAIZTQigbYq
 rEBEefc4NygalsqXYAQ+yKFk3JC1LOAHifbuiayW5Hntbgox4h7TSPNT/JEpYf3jZH/h8JMh9L
 eL2joUrwZLJ/EPum+oAGv6mF
X-SBRS: 5.1
X-MesageID: 56360092
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:x1rPqqpQa2CF4WuQp4zPHRIOrvNeBmJ8YxIvgKrLsJaIsI4StFCzt
 garIBnSPazcZ2HyLo13b9639kIOvJTXz9FjTQdq/y4xRHgV9ZuZCYyVIHmrMnLJJKUvbq7GA
 +byyDXkBJppJpMJjk71atANlZT4vE2xbuKU5NTsY0idfic5Dnd+4f5fs7Rh2Ncx2YLmW1rlV
 e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL
 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9
 DlCnZaOVAsXIPfPotY6T0lAHQ5PLIpsyIaSdBBTseTLp6HHW37lwvEoB0AqJ4wIvO1wBAmi9
 9RBdmpLNErawbvrnvTrEYGAhex6RCXvFJkYtXx6iynQEN4tQIzZQrWM7thdtNs1rp0QRqiGP
 5tDAdZpRDXCajBJJm4VM5Zkg8X4uEmucDBZ73vA8MLb5ECMlVcsgdABKuH9cNGQWd9cmEreo
 2vc5nn4GTkTLtnZwj2Amlqtme3njS79QJgVFrCz6rhtmlL77msXBR4NXF23u86wjEKkRslfI
 EwZ/CkphaUq/UntRd74NzWiqX6ZulgHWtxfE8Uz8gTLwa3Riy6JC25BQjNfZdgOsM4tWSdsx
 lKPh8nuBzFkrPuSU3313r6SoSnoYXBNBWAHbC4ACwAC5rHLu5ovhxjCStJiFq+djdDvHzz0h
 TeQo0AWhagXjMMN/7W2+xbAmT3Em3TSZldrvEONBDvjt14nIt7+D2C11bTFxfx+MYqnUAOCh
 kojh5iG4s8/HLanpBXYFY3hA4qVz/qCNTTdh3tmEJ8g6ymh9hafQGxA3N1tDBw2aphcKFcFd
 GeW4FkLvMYCYxNGeIcuO9rpY/nG25QMAjgMuhr8VdFJfoRqPDGO+CVjdCZ8NEi8zRByz8nT1
 XqdGPtA7Er264w7k1JapM9HiNfHIxzSI0uJHfgXKDz8iNKjiIa9E+ttDbd3RrlRAFm4iAvU6
 c1DEMCB1g9SVubzCgGOr9VOdw9RfSJjXMirwyCySgJlClA+cI3GI6SIqY7NhqQ/x/gF/gs21
 ijlMqOn9LYPrSKecljbApySQLjuQYx+vRoG0d8EZj6VN4wYSd/3ts83LsJvFZF+rbAL5aMkH
 pEtJpTbatwSG2uvxtjoRcSkxGCUXE/w3lzm0uvMSGVXQqOMsCSTpYC9Llq1rXBfZsd13ONny
 4CdOsrgacNrbyxpDdrMaeLpyFW0vHMHn/l1UVeOKd5WEHgAOqAwQ8AopvNoccwKNzvZwT6Wi
 1SfDRsC/LGfqI4p6tjZw6uDqt7xQed5G0NbGUjd7Kq3anaGrjbyn9cYXbbaZy3ZWUP15L6mO
 bdfwcbjPaBVh11NqYd9TepmlPps+9v1qrZG5Q14B3GXPU+zA7ZtLyDej8lCv6FA3JFDvg6yV
 h7d89VWI+zRasjkDEQQNEwuaeHajaMYnTzb7PIUJkTm5XAooOrbABsKZxTV0X5TNrp4No8h0
 NwNgs9O5lztkAcuP/aHkjtQqzaGIEsfXvh1rZodGoLq1FYmkwkQfZzGBybqy5iTcNEQYFIyK
 zqZiaee1bRRwk3OLyg6GXTXhLcPgJ0PvFZBzUMYJkTPkd3A36dl0BpU+DUxbwJU0hQYjL4jZ
 jk1bxV4dfeU4jNlpMlfRGT9SQhOCSqQ9lH111ZUxnbSSFOlVzCVIWAwUQpXEJv1L46IkuBnw
 Yyl
IronPort-HdrOrdr: A9a23:vc77aa0U2Sxn9RAXhsiRiwqjBVRyeYIsimQD101hICG9Lfb3qy
 n+ppsmPEHP5Ar5OEtBpTiBUJPwJ0800aQFnLX5XI3SJjUO3VHIEGgM1/qG/9SNIVybygcZ79
 YdT0EcMqyAMbEZt7eD3ODQKb9Jq7PrgcPY55av854ud3AQV0gJ1XYGNu/xKDwOeOApP+tfKH
 LKjfA32AZINE5nJPiTNz0gZazuttfLnJXpbVovAAMm0hCHiXeN5KThGxaV8x8CW3cXqI1SvV
 Ttokjc3OGOovu7whjT2yv66IlXosLozp9mCNaXgsYYBz3wgkKDZZhnWZeFoDcpydvfpWoCoZ
 3pmVMNLs5z43TeciWcpgbs4RDp1HIU53rr2Taj8DLeiP28YAh/J9tKhIpffBecwVEnpstA3K
 VC2H/cn4ZLDDvb9R6NpuTgZlVPrA6ZsHAimekcgzh0So0FcoJcqoQZ4Qd8DIoAJiTn84oqed
 MeQv003MwmMm9yUkqp/FWGmLeXLzEO91a9Mwc/U/WuonhrdCsT9Tpd+CQd9k1wgq7VBaM0oN
 gsCZ4Y5o2mePVmGp6VNN1xMvdfNVa9NC4kEFjiaWgPR5t3cE4klfbMkcEIDaeRCdo18Kc=
X-IronPort-AV: E=Sophos;i="5.87,186,1631592000"; 
   d="scan'208";a="56360092"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=abw4Rl+Lbp6wD1/s3+F6abC904DpeO6GqZJHT0rwdjPWsXnw7Qp/6Em2KSQYr8mhqwB3HOoYmPTgdS9JlWGYnmY7WZVojdV1aBG49PxOGh7gp1Z6hQkavrvsyP6vx1xygLKODhL35EvkcVI1eM2BDM4tc9cVgqgscxosGGTmbzUyfeGbghw6uJ7e3djzGatSm32CPO8AFPipei4pMMIXNXSp0OtWmVTltzQlFHbxYkYCupdQeecvDR9cS6oEQDJKLDCl6pJyOXx+oULTHEjhFNM2aBf+M5jnuUzs8cMrvhblojxMRFYrLRehkJW9YHNSpVrAUGO9PHuYxzLoqWHAGg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=GyLAoVOwtWSbkeX/lFS/HhTqxZ8zHxWYYphy2V88xV8=;
 b=drTfHDhvk4Wk1VPxQZBtKw5/8W5Xp+pwD//aBb/Jvg/384iVqCQKKLCSA6ukxpOrmXjIj/3orTo5ekdrvLs4tlg15wDqadgp0/MUbqqSEnzA8xVIUCwT7kt4tQa7V8Z9JCW32adfhaoEOvTcm9lSIHYgnoUeglxn7T5R1MskL7OZmG9POem1z439tBqbku8LkXsUUV9zIJdilRJR7fud52KGPhdgh0cf6VS/e//df05ZK/8Uxr1yJn65RRYiQiH5lFJ0qKL6Lw7mWIkTudybxBk/4nGhypNwtoCpec3opD0YwLco3IJl/I1hJmSavc7MuupDGYZsHHY8ExR6j4/hSA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=GyLAoVOwtWSbkeX/lFS/HhTqxZ8zHxWYYphy2V88xV8=;
 b=vgeRoPT9DdSQk3D+Dw73JbYIPyjevkIF1iv7EedRqb4kwjIZjYz2Jt6G1yHZsE4/6XsuTbisyRepxzQ8TAopSA4UxVQQKlXTVijNinC630YA/krrThLty4MoVGu8z24BDZkWJKfRosUCXRRJzUoq38B3MRIC4qKLbpnvZn+tBYs=
Date: Wed, 27 Oct 2021 10:59:36 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Oleksandr Andrushchenko <andr2000@gmail.com>
CC: <xen-devel@lists.xenproject.org>, <julien@xen.org>,
	<sstabellini@kernel.org>, <iwj@xenproject.org>, <bertrand.marquis@arm.com>,
	<rahul.singh@arm.com>, Oleksandr Andrushchenko
	<oleksandr_andrushchenko@epam.com>
Subject: Re: [PATCH] xen/arm: fix SBDF calculation for vPCI MMIO handlers
Message-ID: <YXkU+DKYmvwo+kak@Air-de-Roger>
References: <20211027082533.1406015-1-andr2000@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20211027082533.1406015-1-andr2000@gmail.com>
X-ClientProxiedBy: MR2P264CA0117.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:500:33::33) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 92feb97e-6e46-4272-4e88-08d999281c93
X-MS-TrafficTypeDiagnostic: DM6PR03MB3483:
X-Microsoft-Antispam-PRVS: <DM6PR03MB34834BD40268AD68C8B555FB8F859@DM6PR03MB3483.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 3VMVmldbQWgU3W0OldGs2JJISSnrDmqhhdHFEPYKpKj92sMWfewpc1Pc08LpjEPB1Z+MQy8hlAJ8wfJUo218bp4DY6ePxwhQEx8R00LUsrghfWpWc65TOpC8UDe2WUEy/cVvaWYzFbdAGnPoFUVvRSXi64f/pGA64T/lLSBZSoJ3Eu6GiEjGvwdV9Nb5BXJW4/HCJvR1ysksfuUUeSFHDPBGlmdOH3YcsTW077RkL673kCzeX5SgvSgZdeJtr8fVWasv2hQZuX00UmgXDc3zCNEvq3rT9xWqOhbXVoKdKwR7A5/O0BzUHkxh34yQHcIRDJ1yUBqnuJxRFJO+oV28mNfMKQqB/guxX5wEy3bFk0YHWuycHQ0JBmIJmkP3yhYdbe1MMBnP0LSiL3p+sWsX2oOv20iNiRqlgDqyNobcrpYCnZ3lpN3+4otcmaxXECT4ABE0mxjX0Au/UL9OwlJ3fLBffmjSIn1tcH6B672KyRaiNePbpxuBK8sJKhRoW8CVr+6k/pW4SoSAPmwZhggOKmvWEmjIhvspjYhkrEw5dsRaZr5XC/vrL+Ekri/K6T5mlHNmwQAkO8MdT6yVLA03gx7mhUGKSIhrFrwv+TbgOMXIlVAGiaQ8xoxbzzQ1bjh1PYeve/8LsneqZmaocw+jJqiEo31K6pofZhShCUPQBejZ/UjGUBGS63gJODvTmm177znKNPwWPFxEcNmC6SMsz/SNA/Vjwq7hAEbY34V65gM=
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(7916004)(4636009)(366004)(9686003)(6486002)(82960400001)(33716001)(8676002)(86362001)(83380400001)(66476007)(956004)(66556008)(66946007)(38100700002)(316002)(4326008)(6666004)(5660300002)(508600001)(966005)(8936002)(6916009)(6496006)(26005)(2906002)(186003)(4744005)(85182001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OE5EVVZURUlhZndDWVVXTjdnNVpIZ1JQeG5QZnQ2VnlHQlhrRXVJY2IwQWNB?=
 =?utf-8?B?WTlRSGJqUnRsNllLVXRIc2N4eitPK1hhcVArTHNjS1kvT25tMjBQSzJrL2sx?=
 =?utf-8?B?aVBiRWZCbUJRazhGeWR5YU9ORGdKdGNtTnRKaWRsdHR5OXFaS05FdVVEdm55?=
 =?utf-8?B?SG1nL0p5R2lwRFBpTXhFRXQvMitSaXZYRGFVVDUvZXhlS0lVK1g2d0JqdE1E?=
 =?utf-8?B?NHR1bS9nOXZLNjM1Y2tDb3V2RkJ5VWJFTXB6eUt1SlNabDJzR0hMSlh3ZGll?=
 =?utf-8?B?S3RxQTljN3dQWnlrbDNoQS9ySFBiWnB3S3F6NWVCcW9selpBSEU4MFBUZnZ2?=
 =?utf-8?B?UDdIUi9lQ3FOYW1NZmh5RVhkZG9ZRkhYeHpCclBvYjN5MkJ6T2FUdGhYSmJm?=
 =?utf-8?B?TWx6NVNkUUxLdjhQb0tnY1RmNWwxSnRMeUd2RnRORWVzL056N0hUNG9PTGcx?=
 =?utf-8?B?cWNORHJBbnp6T0pNMStNekxFMWJ5ZGlYRElpOEhOZlBTM0FMR3RMYVlXaUN6?=
 =?utf-8?B?ZU5qQjlMVmNpamNNOHlTN3Z5SFRqRWZUYjNCNGVoL3VkdDljQ1FGTnhnS1ZF?=
 =?utf-8?B?VE1wQnBpRWsxRE9ocGhic29kMUdhamhtOW5DSU10eTJZSXVNakFZb2Zyenp6?=
 =?utf-8?B?SDFoZytZVnV3QzhqMGRmY21LQkdqV3hHMU5Yb3Z3N3RpZHBpUnNKRk1IZ1BU?=
 =?utf-8?B?QXlPRnE3S0ZpczZJcDQzTzFWV1FIdTgrdlN0ZDhDV09aOHJ0SUFTYVpTNWgw?=
 =?utf-8?B?ekdiMXU5RFpLTk9VVk95NjE3NllvQ1FEYWVybldVb2owcitnRzYrY2daQVZa?=
 =?utf-8?B?aXFpdnNwS0tzSEZiUnJwczV1d0FTYUcvcWFDY1FjNGZWdkJRdnhwbHJhcFI0?=
 =?utf-8?B?cFJBeGVORVNMc3ZtektuS29xcmRtbkFNakszWHpCKzM1U3kzTUxHSDArRVlx?=
 =?utf-8?B?QWRLTGxYSEx3bm1ndnFJOFdpaS9PL1FzZitpOFZLak15eHNnZ0ZTeWFXQ2Ju?=
 =?utf-8?B?TE5FeUUvemVBaStvMDJmbXQvV2J4NDcwYXFlZnZiSVkvYm10bU1sVjVmanp4?=
 =?utf-8?B?Q0VtM1p2VEpCSUZHMkZkRUhEM1kxSDAxazFiWFUzSlFVaHhITmpEQTlENVp2?=
 =?utf-8?B?b1ZVb0x3T0VSVkYzQVpYN2NMTHFKc0EvaWZXZGQ3OUtlK3hOUVRSN3FBT0x0?=
 =?utf-8?B?U1FSS0l6eElNUW9EZ2daRVJmdGdqVUE5eFMyMGs1MEt4WTV1MkE2WkZBcGRZ?=
 =?utf-8?B?KytEY3k0VVNna3YrbzQ3cGg5K1NTWUc4STZCeGd2dEM1S2grSHdUdHFBWVFj?=
 =?utf-8?B?NEVjc1RtNldpSDZvZk1VQU45YVJYYU50MlBFVnJIMnd3OXg3cmd1NnN5S3VF?=
 =?utf-8?B?eE05ZWczVHF1Sk9zeFRHRUxPYWFOUGJYdjU5RURENnRZalUzbDJZaDFVdEFZ?=
 =?utf-8?B?YTlxS1FQWjV1WkZIeWhMK2sveUFqZEFhemh6Qy9nd3lkQUZuWHFBeGJ2U3hR?=
 =?utf-8?B?Z2NSWlBhWkw3ZVNqekZKemlPV1dqWnNOcXB3WWpDYW1BVFJWZVhZa3hOWmo0?=
 =?utf-8?B?S1BRand5M1F3TUxxaXBYYUdkZTVrc2FUQmxDdGFjNVFuTGx3L2xZWUtOWW9V?=
 =?utf-8?B?WStKbEQ2bTJrNnZwcStlVmc2eE12M0lKdFVubmVERGVzbW01RXBTcTBRa0pw?=
 =?utf-8?B?dDY3N3FmYWE0NXl2OEo1YnRRZHB2RFVhUmV6WEpjTnNWZlk1WGJ6NlFCQ0tM?=
 =?utf-8?B?WFVENXk0Wm5nS2pmZ1F5OEFleW55cU5XdDN6SDRXamI3RWFqNU9TZldYZHFB?=
 =?utf-8?B?dkRrWlNOVG0zeDZwbzVxNUl3cHNyakc3OEtVbnhkdnZ4UXNJN2dtKzJYOXE5?=
 =?utf-8?B?NjNzT1NRNHFzR3VlRGV2WDJ6VVRTMXhTek1hdXlDcVBYNGRJK1l6WkNBN0Zj?=
 =?utf-8?B?T1k3b2FZNW1wLzh4K2dldXllcjFscytvczJSZVI3TFJIZVNYN3ZwbUh1VldF?=
 =?utf-8?B?dFRRcGRXWkdqcDFYeDVoeWNlMkZ2aldlc0lKaFhZTWwxTm81VVRIbnBteUVW?=
 =?utf-8?B?NjFaZVkvaVFnSGtBeVhPZUhzZ1BVcmxkYks3c0ExOXVXc0llV0xJbXc4ZEls?=
 =?utf-8?B?ZWlwOGJiWTliTER4eEFNcTZaNXNJY01OMFNCdEkvNFdTWkJDbWJobm1tSUhO?=
 =?utf-8?Q?1LgV9ohZR4j4/l8FrgSzQ5Q=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 92feb97e-6e46-4272-4e88-08d999281c93
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Oct 2021 08:59:40.7540
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: GMsArLIimJrudyiwvT3ZrmmgLEQ8XoPnnjNEIBOjPRNHkXWaXVuYzihlUl0czVvu/8aCv/IRv7i1flhepuIfYw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB3483
X-OriginatorOrg: citrix.com

On Wed, Oct 27, 2021 at 11:25:33AM +0300, Oleksandr Andrushchenko wrote:
> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> 
> While in vPCI MMIO trap handlers for the guest PCI host bridge it is not
> enough for SBDF translation to simply call VPCI_ECAM_BDF(info->gpa) as
> the base address may not be aligned in the way that the translation
> always work.

I think I've already raised this during review [0]. But this is only a
problem if you change the current value of GUEST_VPCI_ECAM_BASE
AFAICT, as the current value has bits [0,27] clear.

I assume this is a problem for the hardware domain that needs to trap
random base addresses as present on hardware, but that code hasn't
been committed yet.

If that's indeed the case, please expand the commit message to contain
this information.

Thanks, Roger.

[0] https://lore.kernel.org/xen-devel/YWlnc3b0sj4akUWa@MacBook-Air-de-Roger.local/


From xen-devel-bounces@lists.xenproject.org Wed Oct 27 09:04:58 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Oct 2021 09:04:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.216760.376482 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfera-0001ru-Ie; Wed, 27 Oct 2021 09:04:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 216760.376482; Wed, 27 Oct 2021 09:04:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfera-0001rn-FR; Wed, 27 Oct 2021 09:04:50 +0000
Received: by outflank-mailman (input) for mailman id 216760;
 Wed, 27 Oct 2021 09:04:48 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=8lYk=PP=epam.com=prvs=0934bd4bd6=oleksandr_andrushchenko@srs-us1.protection.inumbo.net>)
 id 1mferY-0001rh-9v
 for xen-devel@lists.xenproject.org; Wed, 27 Oct 2021 09:04:48 +0000
Received: from mx0b-0039f301.pphosted.com (unknown [148.163.137.242])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id c93286fb-4ed4-44d5-b8ff-0c485591516b;
 Wed, 27 Oct 2021 09:04:46 +0000 (UTC)
Received: from pps.filterd (m0174680.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 19R7UDwc012695; 
 Wed, 27 Oct 2021 09:04:43 GMT
Received: from eur05-vi1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2176.outbound.protection.outlook.com [104.47.17.176])
 by mx0b-0039f301.pphosted.com with ESMTP id 3by2eggc27-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Wed, 27 Oct 2021 09:04:43 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by VI1PR0302MB2832.eurprd03.prod.outlook.com (2603:10a6:800:e2::15)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.20; Wed, 27 Oct
 2021 09:04:39 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::c038:e032:595a:651]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::c038:e032:595a:651%9]) with mapi id 15.20.4649.014; Wed, 27 Oct 2021
 09:04:39 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c93286fb-4ed4-44d5-b8ff-0c485591516b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=U0Gv+Q9cBwpSno8syZtRhOvIgsm+AvcUGhpaxfb8Ab/OrPgEnKaMfMn4yEHGG2mm3DPrBIuHr7D5IgRShqzeQ9imyazNs4JsQqNhfhEM8vN89XzqsIH4xwmSwDedSo7E3OV3xk8JilJqpa7NQ9BbLSRYn1x38QtLiRd8iJvcXtTzPzgxl+egeiE3RWJupxBJJpxBpCdiqm2HgUzTT4ljLHs1B40/v28fWL2SIOtzqVMhZVVKOZ1pqmIgcoXF+qMh07bgXtbdRA8it4RhKFIgnSudFIrbrxhDH4BRwnkCqpLg7zJDP1MfL8rD/as9bWhcCsjn3+FOyKZhLyAuY1P7BA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Dv9zJQPL3nIqemrx8qq+x7E+SZ8svFnEHALGKBzaTDE=;
 b=aiA6fuIU+6SDyUIQc6fMelFhv9XsZPObGmUKK9Y2okfgVDp3hIS/M6YFSME+mAhUcveMRw8CtC8V9vi4ZbBgfyQE5JX3ZfaslTtCFf2vteoIPL+sXFBNw04m23NoAZANLRqcjOH6I9But7VPQRvxfLl6E390tydsexjxolAWqH4jkh0Uaz9GwE/6pLkv5W3TYC6qVIyDKJ8efTlcrlKv66TPisoY+B4mvlUZo+kl7C0nDIIkosF0j+KcTzy411oTg8XVh0ryiGhc4c7nMAgxTOnGFNwD0f9yJSZJxEJd0ERQWBm8sCnQ5ZNVSZks3b1A1gPKO6TQJYw5cMG0UYZhRA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Dv9zJQPL3nIqemrx8qq+x7E+SZ8svFnEHALGKBzaTDE=;
 b=a9w05tj3SpYeDwptDfUaKhXd42GSZwueHjnpDuPbpiMVR5ARzKyJiY/y23GZOnGEnX2I4gXujbnMbkJlHCbRoXB8fmSZMnJK173rNpjCBUOFDlwRiCymI5DAmvGRF3mf+Kld3aMIPFlgoyU7I0wx3J4DApMBy1XkwyV7pSupyDlHqkYzVl0vGmXblbsrnmCLWo3WFmjJBEt1UdPjfg/Fn+2JbsfVzar67ffjiIKm/RChd492/CGIRno2C/Mhd2LCmtFw831uOp77WTEni9Kj2/oweZpvoAX/9ecM/wRazVgOs4JdHQmFjNHGFsjknINSfvfDUpoZWisnMA1pCGAGfQ==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org"
	<sstabellini@kernel.org>,
        "iwj@xenproject.org" <iwj@xenproject.org>,
        Bertrand
 Marquis <bertrand.marquis@arm.com>,
        Rahul Singh <rahul.singh@arm.com>,
        Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH] xen/arm: fix SBDF calculation for vPCI MMIO handlers
Thread-Topic: [PATCH] xen/arm: fix SBDF calculation for vPCI MMIO handlers
Thread-Index: AQHXyww6rKHs3LJru0q52eLUia+oNavmi9YAgAABaAA=
Date: Wed, 27 Oct 2021 09:04:39 +0000
Message-ID: <0bbe4d1d-421d-e816-42aa-f43581902a02@epam.com>
References: <20211027082533.1406015-1-andr2000@gmail.com>
 <YXkU+DKYmvwo+kak@Air-de-Roger>
In-Reply-To: <YXkU+DKYmvwo+kak@Air-de-Roger>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 1e3ad1fa-ae3f-467e-6b1d-08d99928ce7e
x-ms-traffictypediagnostic: VI1PR0302MB2832:
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <VI1PR0302MB2832EB9541A2BB67B25E9259E7859@VI1PR0302MB2832.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 2Q80hxgKLB7UqqNJ100srOGbP9P/VNbzQ/fENSI5VIG4VNSvJfBaEh13ntmEY4iVzxpndho2a3Ia/zuLMVLLpVYwfm7Cfd03JKEuY1zt7hWz+V6v0abOcso/61DbX3W28Ljaqbxguhb7NkQjnPVDp5LXdTiHauyWX4dtMnGXMfPtgSatSLzFZtJXltAnxyf5uu/HIlhHEVpS14KuJw1lceESOW/odc3oMETMnLP6eDPZ2hZwviAIOM9+JI5rPEvwuAOYT60jnpukK8BR41Yo8lpwFj/ppAfOIQmzPeMUuHalSc0UHqHUigRKTLleWECSXebtXVZA6p3qs/VhxkCfzrAWwrY6uc/r+YVdOc5l64hc//fozoBDiERu1hZ4kd1Sd1LKml2iWIjh92d8fk5LIXSlO9KB/UJJV60euK6BwB0L21HJoppayRb/juLFxt9xYGQTFDLYepD7/Ow7ehv/zSUmXRVJ4U4UZi71aAIxs6+B5LtvcrodR4Q3vfdIt98Xqyck745YrT8uy6VRYzyyeH/MihAVhGm/PZnAiljn8uMQK+v/MrKI6lqohpPoOS7OkwqpFd+Q9jTmGs+KpYxReqh39iSR2qvhX+8XsCFDCEtyD44Yv6oBG417KUdqQgocMy92RJbkOmi9eH3udV+GNatEa5hJo79RWRkqcO7ZxelyGTlQ2iPKMamZ3Dlpid2zBex+4xjZpN94lwXhbOSXELdi5adUtHIGvuBz8YxnHKs/6nlQmSZ5T56bdKxmOfDkinmf7PTfW02ayD/P0N1FM22+Fz1+4CnN8YVCygnALy+qUYPv5FrJbQGDw53wSY3vzXRaDhx+ETt72pYCoDrmgQ==
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(4326008)(186003)(6916009)(122000001)(66446008)(54906003)(8936002)(83380400001)(508600001)(5660300002)(31696002)(91956017)(53546011)(8676002)(26005)(66946007)(966005)(64756008)(107886003)(2616005)(66556008)(38070700005)(6486002)(71200400001)(31686004)(86362001)(6512007)(2906002)(316002)(6506007)(76116006)(36756003)(66476007)(38100700002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?bE03cThMQW9iRmRLWDRNbytMaFgxYlEwaFJEV0dUVGZiTm1rMW9kQnoxTUts?=
 =?utf-8?B?ZmxzSjZpd1dZRnE5R2U3Qnk3UHVUNzF1UWgyUlBXYXc5UDNDVnNQenkvVGZC?=
 =?utf-8?B?VWlKMUxYOEg1OTdCUmZMQmJBRTU1Q2FlWm1YdVE4N1V4RTlkS1cyRXhqc2ZK?=
 =?utf-8?B?RjJKYVNNTmNTd1ZjS2c3SzFtV0RtWFJLSzV6RWtZTHdVQUxmckZNWmJmK01q?=
 =?utf-8?B?ME83ZFhvemVoUzYzQ0p4d2RSbk5aQXVrajdDOTR6NUhkcjF2RFlpcGZwbHFY?=
 =?utf-8?B?Q2dnUWxWaEdGczZrWFZ4d3dSUXQrSHZNdTdjU3p5bEtYSDE4ZFZRUHJqajBi?=
 =?utf-8?B?ZDNHdTQ2dFBrTXoyNG1oK200TWQwZytpTThQMWppOHllNFpyd0FnWkptaWRs?=
 =?utf-8?B?ZVpWb0NCcjhPaWNoYzdVV2NvWjBjSHI1bnA4cTVGN3FzSlV5TnU1MTQ3c0Zr?=
 =?utf-8?B?QzViVnR3N1Vkc2V3WmY1MlJWQmxZVFZreVNtMjl5VUxxelFNZjRZSU9NYVhO?=
 =?utf-8?B?RGdGL3VGK0t3dVJTYzFBQStOb2RnckcyYzFZQ3FwNW9vb29UYmQrb2YrNGxE?=
 =?utf-8?B?U3Bscy9hNForS0RnSTV3c1R3a1NJZUFoSllqM2ovRy96WU91bGwycVovS1Zo?=
 =?utf-8?B?ekpUNlA2bS81cHMvWFFzOEtUN3JJSmo3WUpRaEw4UGFlMG5RRkFRU2ZBdTR2?=
 =?utf-8?B?M1RzdllsTmN4TW9icmFubzhpYlUwWElrQVpBd3ZNeCsxcTNxYVRuejRNWkJm?=
 =?utf-8?B?V01GNm1uRE9DeTRxbjMvWnlBc0U0QWhybllTUWJHZC9RbUR2ZWQrOXp1aVJH?=
 =?utf-8?B?ZTUzQUlQYVVwWnhORFhZWWFxNUwvanhrQnlWTzRBVEtNZkUwVDZpckJ6WGE1?=
 =?utf-8?B?QkE1OHZZcldodGRHSFVwS3p2SVJpQlArUUZ6OVgzdDU1cTI3cXJvZWEzT0w4?=
 =?utf-8?B?SG80VjNzN1BUWTRXMThzZWdrSE1KTTBLQmR1ZmdVVmVHS1gva1pTNjhlaXRL?=
 =?utf-8?B?YmVmUWxxdTVPYWhSSml4U1h4Y1dhS2Jzam5zd01LT2dEN1A3b2d0SDZldzgw?=
 =?utf-8?B?dFZiazhLb2J0WE90dFVJakFLangzb0NXY3I2Slh6NzZNNzE5L0JpSFNHei85?=
 =?utf-8?B?QW42UTRGdHVzeVc1bGhVM3A5RmtJSG1ZT2RKblFxalliR2pnQ2tIalplKzlh?=
 =?utf-8?B?YmFLZ0s3NllrZThFbnBleUJXZm85Um5KbUNtNjJxemI2SzNDTmJTa2ZKRmFC?=
 =?utf-8?B?MEt5TGJHWjJQQW0wOHR2dDNJQmY2WVFDazA0WXJkODVPdnpzWnlMcEgrNFVG?=
 =?utf-8?B?MDlJeTgvQlNURXJhMHUrUlp4UW9pdFhqQTd6UDVJMnZxcU83UlFFcDlOZ3ZK?=
 =?utf-8?B?OXZzU3VibG9tYlFyTTBtdmcrU2VSQXI3STVKYUJNblhVY3RLZnh1SlUzb25V?=
 =?utf-8?B?Z2FlYVBBdzNDbEJTdkwvOWt4M2RrM29JcG4xT09tdndYT0xlUndIRDlseEFL?=
 =?utf-8?B?TUtHM21ZaUJpVmlETEhmMmtnSEdtdlFLWitudlk3RzFvTWs0QXNTOStxdk5a?=
 =?utf-8?B?MUhwU2FLTndzSEVsSW1uWnpleE1ZMU04akU4L1RlRlJRM3U1VTlWbE1mbjda?=
 =?utf-8?B?Y2lvZzVJUFRNMmZDZ1Fjc2l1bFZDR21SbDJMY3FUUi9adkRadlVVcVRUdnUy?=
 =?utf-8?B?RXl1WGh4YnFYemN5c2FLdktFYnA0VTVnZHh1cEZYN2RsK29BQkZoZkZTemNv?=
 =?utf-8?B?b0ZPTUFhUEh5U2phV013QjU0bGJEZHNFRG9Rb0R5ZGdyOHRVSDZrblpHWWdh?=
 =?utf-8?B?enVmUnhBS04xOVlxeXV3UWJMSXdWMlhmTE4xeFVnMThIMnBnTTdld29FaDNu?=
 =?utf-8?B?SHpPdHlkaVlHbEtmclZaUVNnNEVINlNEZWNsNDFSWmw0c0ZuTTM4alpJRjVi?=
 =?utf-8?B?eStoT29BcFRuUGRxN2xMbUU5eTIvbDNhckUxNC9xNXpMcTVOTTlEZDE4WEdP?=
 =?utf-8?B?cWxza2llUHJ2V29YUDVIN2pLMjFzNnlwcHB2eG5MMDV4dVpzanZTSnRBWjhy?=
 =?utf-8?B?bG5QTlJsR3dlWkhER0xjcVVncnY4QmpqVHE3VXIwTGE5aDdUVjdaK0lBV3Nm?=
 =?utf-8?B?MW4wbmRyZVovYzkzZ3ZSSEVvcWw5RnBSeElnQXpqSHY5VGR1UWt3N1JQNGFu?=
 =?utf-8?B?R0p3cE1zUXYyUmZ4SnVVME5ndWtXWGNPOFdzUVh6TmJTdlhqNEV3ZWJaSHR4?=
 =?utf-8?B?SmJGRkRRRDIyaUNkSlN0UDkzdVZRMG5nSWg3TitvYjF1bDlNK0s2NEQ1RjU5?=
 =?utf-8?B?d2lNODZLUDRCNVd6d1lYK1pubHo5cWpqeGpCVW9UTUgweUp1SStvdz09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <2182E10A122A7A4791DE378501291340@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1e3ad1fa-ae3f-467e-6b1d-08d99928ce7e
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Oct 2021 09:04:39.0514
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ob+adZhv/6FzA58xNd/++HFVY8YJINlswDf+nvseq5XWt07R9PRGiWK7mZ1FPk1Y5+SZzNQuAWF3kMQ3t0SfJqoHK6MwB2Qdr62btleSSr7OGswRaLty7/D+qeKRonnY
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0302MB2832
X-Proofpoint-ORIG-GUID: j1aptlqXwf9GYLYYeySK3FMLlWIanKDY
X-Proofpoint-GUID: j1aptlqXwf9GYLYYeySK3FMLlWIanKDY
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475
 definitions=2021-10-27_02,2021-10-26_01,2020-04-07_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 impostorscore=0
 mlxlogscore=999 bulkscore=0 spamscore=0 priorityscore=1501 malwarescore=0
 adultscore=0 lowpriorityscore=0 clxscore=1015 mlxscore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2110270056

SGksIFJvZ2VyIQ0KDQpPbiAyNy4xMC4yMSAxMTo1OSwgUm9nZXIgUGF1IE1vbm7DqSB3cm90ZToN
Cj4gT24gV2VkLCBPY3QgMjcsIDIwMjEgYXQgMTE6MjU6MzNBTSArMDMwMCwgT2xla3NhbmRyIEFu
ZHJ1c2hjaGVua28gd3JvdGU6DQo+PiBGcm9tOiBPbGVrc2FuZHIgQW5kcnVzaGNoZW5rbyA8b2xl
a3NhbmRyX2FuZHJ1c2hjaGVua29AZXBhbS5jb20+DQo+Pg0KPj4gV2hpbGUgaW4gdlBDSSBNTUlP
IHRyYXAgaGFuZGxlcnMgZm9yIHRoZSBndWVzdCBQQ0kgaG9zdCBicmlkZ2UgaXQgaXMgbm90DQo+
PiBlbm91Z2ggZm9yIFNCREYgdHJhbnNsYXRpb24gdG8gc2ltcGx5IGNhbGwgVlBDSV9FQ0FNX0JE
RihpbmZvLT5ncGEpIGFzDQo+PiB0aGUgYmFzZSBhZGRyZXNzIG1heSBub3QgYmUgYWxpZ25lZCBp
biB0aGUgd2F5IHRoYXQgdGhlIHRyYW5zbGF0aW9uDQo+PiBhbHdheXMgd29yay4NCj4gSSB0aGlu
ayBJJ3ZlIGFscmVhZHkgcmFpc2VkIHRoaXMgZHVyaW5nIHJldmlldyBbMF0uIEJ1dCB0aGlzIGlz
IG9ubHkgYQ0KPiBwcm9ibGVtIGlmIHlvdSBjaGFuZ2UgdGhlIGN1cnJlbnQgdmFsdWUgb2YgR1VF
U1RfVlBDSV9FQ0FNX0JBU0UNCj4gQUZBSUNULCBhcyB0aGUgY3VycmVudCB2YWx1ZSBoYXMgYml0
cyBbMCwyN10gY2xlYXIuDQpFeGFjdGx5LCBzbyB3ZSB3ZXJlIGp1c3QgbHVja3kgbm90IHRvIGhp
dCB0aGlzIGJlZm9yZQ0KPg0KPiBJIGFzc3VtZSB0aGlzIGlzIGEgcHJvYmxlbSBmb3IgdGhlIGhh
cmR3YXJlIGRvbWFpbiB0aGF0IG5lZWRzIHRvIHRyYXANCj4gcmFuZG9tIGJhc2UgYWRkcmVzc2Vz
IGFzIHByZXNlbnQgb24gaGFyZHdhcmUsIGJ1dCB0aGF0IGNvZGUgaGFzbid0DQo+IGJlZW4gY29t
bWl0dGVkIHlldC4NClllcywgSSBhbSBmYWNpbmcgdGhpcyBvbiB0aGUgcmVhbCBIVyB3aGVuIERv
bTAncyBhY2Nlc3MgaXMgdHJhcHBlZA0KYW5kIHRoZSBiYXNlIGlzIG5vdCB0YWtlbiBpbnRvIGFj
Y291bnQuIFNvLCBJIGhhdmUgYSBwYXRjaCBmb3IgdGhlDQpmdXR1cmUgdXBzdHJlYW0gd2hpY2gg
c3VidHJhY3RzIHRoZSByZWxldmFudCBiYXNlIGZyb20gdGhlIGdwYSwNCmUuZy4gZWl0aGVyIEdV
RVNUX1ZQQ0lfRUNBTV9CQVNFIG9yIGJyaWRnZS0+Y2ZnLT5waHlzX2FkZHINCj4NCj4gSWYgdGhh
dCdzIGluZGVlZCB0aGUgY2FzZSwgcGxlYXNlIGV4cGFuZCB0aGUgY29tbWl0IG1lc3NhZ2UgdG8g
Y29udGFpbg0KPiB0aGlzIGluZm9ybWF0aW9uLg0KSSBjYW4gb25seSBtZW50aW9uIGFib3V0ICJ0
aGUgY3VycmVudCB2YWx1ZSBvZiBHVUVTVF9WUENJX0VDQU1fQkFTRQ0KQUZBSUNULCBhcyB0aGUg
Y3VycmVudCB2YWx1ZSBoYXMgYml0cyBbMCwyN10gY2xlYXIiIGFzIG9mIG5vdyBiZWNhdXNlDQpE
b20wIHRyYXBzIGFyZSBub3QgeWV0IHRoZXJlLg0KPg0KPiBUaGFua3MsIFJvZ2VyLg0KPg0KPiBb
MF0gaHR0cHM6Ly9sb3JlLmtlcm5lbC5vcmcveGVuLWRldmVsL1lXbG5jM2Iwc2o0YWtVV2FATWFj
Qm9vay1BaXItZGUtUm9nZXIubG9jYWwvDQpUaGFuayB5b3UsDQpPbGVrc2FuZHINCg0KUC5TLiBT
b3JyeSBJIGZhaWxlZCB0byBtYXJrIHRoaXMgcGF0Y2ggYXMgYSBmaXggZm9yIDQuMTYgYW5kIGV4
cGxhaW4gd2h5IGl0IGlzDQphIGdvb2QgY2FuZGlkYXRlIGZvciA0LjE2IGluY2x1c2lvbg==


From xen-devel-bounces@lists.xenproject.org Wed Oct 27 09:12:38 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Oct 2021 09:12:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.216767.376493 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfeyy-0003L4-CD; Wed, 27 Oct 2021 09:12:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 216767.376493; Wed, 27 Oct 2021 09:12:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfeyy-0003Kx-8y; Wed, 27 Oct 2021 09:12:28 +0000
Received: by outflank-mailman (input) for mailman id 216767;
 Wed, 27 Oct 2021 09:12:27 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=8lYk=PP=epam.com=prvs=0934bd4bd6=oleksandr_andrushchenko@srs-us1.protection.inumbo.net>)
 id 1mfeyw-0003Kr-WA
 for xen-devel@lists.xenproject.org; Wed, 27 Oct 2021 09:12:27 +0000
Received: from mx0a-0039f301.pphosted.com (unknown [148.163.133.242])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 0027afa8-3706-11ec-8457-12813bfff9fa;
 Wed, 27 Oct 2021 09:12:25 +0000 (UTC)
Received: from pps.filterd (m0174678.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 19R6Y1jP026938; 
 Wed, 27 Oct 2021 09:12:21 GMT
Received: from eur02-ve1-obe.outbound.protection.outlook.com
 (mail-ve1eur02lp2059.outbound.protection.outlook.com [104.47.6.59])
 by mx0a-0039f301.pphosted.com with ESMTP id 3by1m1rkx8-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Wed, 27 Oct 2021 09:12:20 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by VI1PR0302MB2830.eurprd03.prod.outlook.com (2603:10a6:800:e3::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.18; Wed, 27 Oct
 2021 09:12:15 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::c038:e032:595a:651]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::c038:e032:595a:651%9]) with mapi id 15.20.4649.014; Wed, 27 Oct 2021
 09:12:15 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0027afa8-3706-11ec-8457-12813bfff9fa
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=CPFEe62w1CQEbDkLPHbqtkunJ4Xz1x2fbBHa+e+2Y+ePj7PQaEE2Q3ThF2yiPAmErgOP66tCR2Rr8QtW3sF6lpF7F9gdmNOCEQdonlf3s0mnvYjIJ3T+IPoWsZGErJSQ1UeCDYuLN1NiL3u6kaU4+UrVJ9lb9NL2/IKZ9Ed2lJvS+YgoI0S7CVfUgQ/Ix93CLaJUcpStZb0nTgtJZdaU2iTko099c7v8TN4nm1G4KSq1oUVvn4Lsyn4lkaZ7/hO0vvZ4l021jqvijkTOqHbdM49oY9vRs3oF8M08p1VB6CniDsXgwG9DNbu0xl/4XA9IVZ0aIxgFmNoz7iVDVk5FsA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=9cTXzK1Sb5+ewj/DvvP9J6UW+QqHWp2DE6YuusLLBxk=;
 b=ocgQ18M1XaH3nJ09gIjEHUDRVcRMEHUUNbYhbm/Zl2dThV7aevADenxpmL5zQsJgI4vA9Zn1xn9ECdlmYjbwg6iAIV5r24ZuSD0ql8B6dpUemuL9EmXgRo+ltEJG9JDFJzsm2uLJex2/znk49do8LAidvEXomqy8iua3nRSTixr+ZY4NFE3sG2kmW0nbEdGDDLveKkrnII9SVqZQerbnVgaiVlUF6p9RkQ2K2JaVZylEuc5aOm5O/jp/etmh2szOBFETEA6BnH3s8z0zJURwkkOMijfIMYZfQ/wPta2yPgZIIL/ulyAc1phpB9S67F8akF3K5UCgpz+ODnhQCk+iMA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=9cTXzK1Sb5+ewj/DvvP9J6UW+QqHWp2DE6YuusLLBxk=;
 b=hBTYBHRuLcInuMeKKqiOwsVPWf8lXZ1f7OmX6AQJ0soKs4734+7/fODuz7mN+qzT9jo0ELq/jpF15IbUv5KcsfcNkPU3qadPNGnwSzJ3PvipJa5nPT1/b7hl7y+0M7GDXTqXTNGJgnrQiaIJR2hZrUSZdsi3dY6fs7tkXGUNvElr5xFhAuw056B9Bvuoep8H0rlOhiTKZ4iZagyi9qSs/w2wkEnwhhMDZUuFzGFrliAYuIuD9CXYQCRsKj/JyPhh8uhSEGl5XiYWOYormsa4J8OkapOPoPTJ65jz+LTs4yZ0fkMXFbU5NXCPH5y4Y+WpwqiAc3pClwCxsHhJtpRp4g==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org"
	<sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "jbeulich@suse.com" <jbeulich@suse.com>,
        Bertrand Marquis
	<bertrand.marquis@arm.com>,
        Rahul Singh <rahul.singh@arm.com>,
        Oleksandr
 Andrushchenko <Oleksandr_Andrushchenko@epam.com>,
        Michal Orzel
	<michal.orzel@arm.com>
Subject: Re: [PATCH v3 01/11] vpci: Make vpci registers removal a dedicated
 function
Thread-Topic: [PATCH v3 01/11] vpci: Make vpci registers removal a dedicated
 function
Thread-Index: AQHXtdAgeXiPCGUCJ0Oi6HCqPD8Y4KvQ2oUAgBXfUAA=
Date: Wed, 27 Oct 2021 09:12:14 +0000
Message-ID: <387d3729-b182-1aaf-870e-505e90141606@epam.com>
References: <20210930075223.860329-1-andr2000@gmail.com>
 <20210930075223.860329-2-andr2000@gmail.com>
 <YWa+4hsaOxuX4tWJ@MacBook-Air-de-Roger.local>
In-Reply-To: <YWa+4hsaOxuX4tWJ@MacBook-Air-de-Roger.local>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 7b6acc2e-822f-4fe5-1b63-08d99929de4a
x-ms-traffictypediagnostic: VI1PR0302MB2830:
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <VI1PR0302MB2830B51CB19AB819AC138048E7859@VI1PR0302MB2830.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:6430;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 qtWTPQrOlf6wCJ+/MPNBQ6AGXcQhWhAVkzy8xRhNEqW09c5+spptqikou6uJ0gvg1aCkWNIYkhpfbXGi3mdxvsEHV0alJNMl/K0J8K+hP42dR9gYnCFQLd8FEiNqSRrAlFRy3TEYpVUEvOYHgQpvOnsXaIhGt7v9/ecI0qZgs097R70CWispip5yAIyvybIN1ojIEEJ3+R0sL/kHWhTRUI9DrcfipEsqHPUlqtR36tDPAn+O3UqZGvX5iXX0Cu0z52a/BUVGC+UAhj8rQWhsA+1kyKpk2rSke73DZjUTfQtL+LQEVU6she46hlJzs2w3NAZpZlgiRJ7LBB7828dkWmDENG/fybs30MBPHBVZw6jAv88m5w/7MgJJMmjS/3ARATj/ixTQgYr+0YA3qowMSPzdSHGLGTBAkXlVRgliDdR+EQRebxUylmRe7FZucI1CsR5eL5WIO8GnW1XLr+ZMSeLs9gFWGVP/4/Ok6hHN9N/fiFg5cfpt+nSelc5R7axqvYNM0vrDUFq9d8ZOJ5T7UQm28vfmqPh1xS3PJLmZKJiLekM/fJW/QFSByGep3RKzXppJW9z2R0S7cNt4LtGxzVBz5hyRZHMYaiwFE49L7lnoZ9lqEYa7048e/AxNRzVzC11C3mbQcZnFwOwP7zULzAV0rizLEHP7VKJDx7LqSlgGWfIi5UHo6Ol8GR+QQSlOdXlnPnaeRbxX/pPgnPODfv/KUC7QGuVI1ne0BcOkFp9c95SlqWwmJcs6yiBEBktl
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(6512007)(66556008)(6486002)(31686004)(8936002)(53546011)(38100700002)(26005)(4326008)(76116006)(6506007)(71200400001)(5660300002)(86362001)(2906002)(316002)(66476007)(54906003)(91956017)(122000001)(31696002)(186003)(64756008)(66446008)(38070700005)(2616005)(6916009)(83380400001)(66946007)(36756003)(8676002)(508600001)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?dkRNbzY3b0FMZ1cxRGY2RlR3S2RxWFpMT3h1TUFJeTJ3WmVlbDR4ZGorOUla?=
 =?utf-8?B?Rkc2WlVpbzhrWjBsNW8zMkNnek9pS1EzWHR4RUFlSjBrVWdSOEsvUk4rMkx1?=
 =?utf-8?B?VWdlcm1IZUxlM3dNVjRWME9hV3NxRjN1RGZNaVJ0bWJVZ2RXQzYvbk43cHhV?=
 =?utf-8?B?OExOREJPNlJqY1pEZkNoa2srSmw0bmxnYlFMTFZwc0liVFREUk5IRllwTkY5?=
 =?utf-8?B?b2dqTGg4SWpyakl1Y0FjdHV6TVhTS1kxOXZuTU5OYkIvcmg3czdodC94SWRi?=
 =?utf-8?B?Y2RyTkVZL21FbzJ3bWxST3B5NytpUEVmbjcvUndacUxGOVpxaGxLR1BGOVN5?=
 =?utf-8?B?M1dhTm1tSFBXaERNazB3VU91RmZ0T1JBNXI2alVIcS9hMERZbTRraEJkQ2lD?=
 =?utf-8?B?cVpDUzF3MmFXMEFDYy9tWHd5eXBNUjdGa3Jqa054WDRUaXdmK2tCNVFISVg5?=
 =?utf-8?B?QXlhZGQxSnp4ZUFqZ2FneUNYSWV1Y1B4ZDB2WldhWXNJRTk1dzRjeVlaUFlB?=
 =?utf-8?B?bVRMSktEUFYrNWZ6UmIrNlJ4OXlHc01rNkpwTEZKeUM2VE9ZUzYraXV4eHdY?=
 =?utf-8?B?ajVrZXNOeDZsa1JMK0QyRXhEV0Fma1NQWGFiVkFsSGw2M2R0anVRUmRlTWZ6?=
 =?utf-8?B?WE94ZmlYeDNVYURLUUJ0UC9QVmluOXRjVlJDVWZQRWpuemJEZzVRd1kzNkhh?=
 =?utf-8?B?Z1pZUFJsM3dodXRPbm8vY2tpaWRQOEVFdmU1QkFWR25TSVMzd3VwN3cyc3gw?=
 =?utf-8?B?aGhyLzhDMGhmL0FOM3prZWwvelhRL2oxd2VPcUhoeEpSUkVZK0lvVTVUWmhR?=
 =?utf-8?B?T1VVWGJNYStrZ3ZvcHpYVUI1Yk5LSHdybi8xTmtNVG4yZmJBYzl4dUxFZGdY?=
 =?utf-8?B?UkhkQmc2Zk9ZUklQZ3IvSVpWVDlKb1hERVpWdDh3TG5wQURNOTRFREhEdTJI?=
 =?utf-8?B?NHl5VnNiT2VlZStYNFFPK2pEQVZGdklsWXFQd2p1dlJVRFp1Q2tDeEdPdytV?=
 =?utf-8?B?T21oL2M3dERnSStOem9mM1AyYlNwdlVEbEpWTUR3NXk0UnAyS0cvMHFDU3ZK?=
 =?utf-8?B?dEpmRU9MeG03RXdERjcxSTNyMTMxR0Z5V3d4WDJxaWptQVdQTmg1L0lGTDF6?=
 =?utf-8?B?MnlnS1lyNEd2eDJFZlJiSlJlb05aYW83R0FFSUJRdWo1bWJZV0JmZ1d3bVpr?=
 =?utf-8?B?SUlOakc4K3F2RXpqd01HZjR6cWlkcldaOHpGQWtybFlOWFBjaVZHbGhNeUY4?=
 =?utf-8?B?TEFkV0xydmRxWlpGcHpBVWVNcjMwVCt5TWtCMGpGSFlIa3VJbFJNdDZYeUVr?=
 =?utf-8?B?WFBLZENUa3BRc3hqQU1ObmtmMzhvVWNkN1pHVmNkYmh4Y3hRTFo3Mmx3SHRU?=
 =?utf-8?B?RFlyL3FHVnhIdzJ1Qmt3cEhRWXYyMllWKzd3ZHg4NHN5c3FOWnNHTXBpb0xU?=
 =?utf-8?B?YUpkcDNZcnQzeU5TMVV0NFdlTzlYT0gwVWNFWVJkOFFaeWZydHJaZ2xxdnZl?=
 =?utf-8?B?SHNCdzlBWDRxUUVEVElpWnBCKzluNkhVTTdyeDMvUVB1QlJldnVrcUZ2N2kz?=
 =?utf-8?B?V3V1SC85bVdJS1p2cmQ3WTFTMFo0a0c0cEVhdzc3MG1DN0pRc3ZaT090aGFv?=
 =?utf-8?B?TDJkR2dKSFE0VjlPb1k3dWVTSnh0Vy9NV3hNM1dVS3hFN2NvUXR0WW90L04v?=
 =?utf-8?B?MVlUNWpwQ0dWZGxqQkVIbTNKbFJEVkFPM29FSUlsZHlYL2VKakNYRU92UFJV?=
 =?utf-8?B?dGkwcVhhODhjUEpXaHg2QlZlYTE2d2RQTzVuSlRDMHJHeis3alh3MHVTaHEy?=
 =?utf-8?B?NmQxblducTdNeGpjSUdaaHBCRTVuL2U1dUZMbXpYWjkxZ3MxbmhDTHpFUUJM?=
 =?utf-8?B?TWhZaE5hVDMweWZMekNUNmV4cUZBc0pmMi9KbkFyUThWT1hrQ1pHZGxNVjZ0?=
 =?utf-8?B?RTRjblMvN1ZOQWFMSFdXdzZJZ1lDYnBjNXo2K2wwYVRLbFV2d1p2WFJSTDgw?=
 =?utf-8?B?L2hSaG44SlduanVGVndZYmhrYVF6RE5wR1dSNGNJUllSMnFObnNacStDaFNZ?=
 =?utf-8?B?REFNUHZEQlZiK202SXc1NDR0ajZWTEdrS3ZSeHdZRE5TV2VQRWhDYnJRaFdT?=
 =?utf-8?B?RVZKckZDRzVwTU4veGdWeGpDcEFrYUdqbjFUMXpxaWtISmFQNTNZUXZKTjBL?=
 =?utf-8?B?Y2xVQ2hYK013c0YwWk1aRTRzV3hMdW9sRHQ5eXBSdWlxL3EwdWlZbFJTdWtq?=
 =?utf-8?B?UVRvdTB3Nk5lcFg3SlBxdFNuandLajVOVWZXNnVGZU8vUjczVng5bmVaZjZC?=
 =?utf-8?B?SVZ1WGcvMlR4Q0k5QVNMc21DdHBOYTgrWUZSL3M2Ym1mbEtCZitkZz09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <B6663B64F77FFB409FD179092D195AB7@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7b6acc2e-822f-4fe5-1b63-08d99929de4a
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Oct 2021 09:12:15.0249
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: O7o638qslUb1euyGRjoI9FpmdIb3kKFyRNIemkm5dVMijDraI4Us7McS2KynetrPfNqUUrXQFum7btjnpeNS/finLK/Cva3MSmEn20teJHu5IU2hDY8TepS2D5reBtpo
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0302MB2830
X-Proofpoint-GUID: XYnu3R2EmAdObfk0IedEAA5OXGGctZTE
X-Proofpoint-ORIG-GUID: XYnu3R2EmAdObfk0IedEAA5OXGGctZTE
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475
 definitions=2021-10-27_02,2021-10-26_01,2020-04-07_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0
 priorityscore=1501 malwarescore=0 mlxlogscore=987 phishscore=0 spamscore=0
 lowpriorityscore=0 impostorscore=0 clxscore=1015 adultscore=0 mlxscore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2110270056

SGksIFJvZ2VyIQ0KDQpPbiAxMy4xMC4yMSAxNDoxMSwgUm9nZXIgUGF1IE1vbm7DqSB3cm90ZToN
Cj4gT24gVGh1LCBTZXAgMzAsIDIwMjEgYXQgMTA6NTI6MTNBTSArMDMwMCwgT2xla3NhbmRyIEFu
ZHJ1c2hjaGVua28gd3JvdGU6DQo+PiBGcm9tOiBPbGVrc2FuZHIgQW5kcnVzaGNoZW5rbyA8b2xl
a3NhbmRyX2FuZHJ1c2hjaGVua29AZXBhbS5jb20+DQo+Pg0KPj4gVGhpcyBpcyBpbiBwcmVwYXJh
dGlvbiBmb3IgZHluYW1pYyBhc3NpZ25tZW50IG9mIHRoZSB2cGNpIHJlZ2lzdGVyDQo+PiBoYW5k
bGVycyBkZXBlbmRpbmcgb24gdGhlIGRvbWFpbjogaHdkb20gb3IgZ3Vlc3QuDQo+Pg0KPj4gU2ln
bmVkLW9mZi1ieTogT2xla3NhbmRyIEFuZHJ1c2hjaGVua28gPG9sZWtzYW5kcl9hbmRydXNoY2hl
bmtvQGVwYW0uY29tPg0KPj4gUmV2aWV3ZWQtYnk6IE1pY2hhbCBPcnplbCA8bWljaGFsLm9yemVs
QGFybS5jb20+DQo+PiAtLS0NCj4+IFNpbmNlIHYxOg0KPj4gICAtIGNvbnN0aWZ5IHN0cnVjdCBw
Y2lfZGV2IHdoZXJlIHBvc3NpYmxlDQo+PiAtLS0NCj4+ICAgeGVuL2RyaXZlcnMvdnBjaS92cGNp
LmMgfCA3ICsrKysrKy0NCj4+ICAgeGVuL2luY2x1ZGUveGVuL3ZwY2kuaCAgfCAyICsrDQo+PiAg
IDIgZmlsZXMgY2hhbmdlZCwgOCBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pDQo+Pg0KPj4g
ZGlmZiAtLWdpdCBhL3hlbi9kcml2ZXJzL3ZwY2kvdnBjaS5jIGIveGVuL2RyaXZlcnMvdnBjaS92
cGNpLmMNCj4+IGluZGV4IGNiZDFiYWM3ZmMzMy4uMTY2NjQwMmQ1NWI4IDEwMDY0NA0KPj4gLS0t
IGEveGVuL2RyaXZlcnMvdnBjaS92cGNpLmMNCj4+ICsrKyBiL3hlbi9kcml2ZXJzL3ZwY2kvdnBj
aS5jDQo+PiBAQCAtMzUsNyArMzUsNyBAQCBleHRlcm4gdnBjaV9yZWdpc3Rlcl9pbml0X3QgKmNv
bnN0IF9fc3RhcnRfdnBjaV9hcnJheVtdOw0KPj4gICBleHRlcm4gdnBjaV9yZWdpc3Rlcl9pbml0
X3QgKmNvbnN0IF9fZW5kX3ZwY2lfYXJyYXlbXTsNCj4+ICAgI2RlZmluZSBOVU1fVlBDSV9JTklU
IChfX2VuZF92cGNpX2FycmF5IC0gX19zdGFydF92cGNpX2FycmF5KQ0KPj4gICANCj4+IC12b2lk
IHZwY2lfcmVtb3ZlX2RldmljZShzdHJ1Y3QgcGNpX2RldiAqcGRldikNCj4+ICt2b2lkIHZwY2lf
cmVtb3ZlX2RldmljZV9yZWdpc3RlcnMoY29uc3Qgc3RydWN0IHBjaV9kZXYgKnBkZXYpDQo+IE1h
a2luZyB0aGlzIGNvbnN0IGlzIGtpbmQgb2YgbWlzbGVhZGluZywgYXMgeW91IGVuZCB1cCBtb2Rp
ZnlpbmcNCj4gY29udGVudHMgb2YgdGhlIHBkZXYsIGlzIGp1c3QgdGhhdCB2cGNpIGRhdGEgaXMg
c3RvcmVkIGFzIGEgcG9pbnRlcg0KPiBpbnNpZGUgdGhlIHN0cnVjdCBzbyB5b3UgYXZvaWQgdGhl
IGVmZmVjdHMgb2YgdGhlIGNvbnN0aWZpY2F0aW9uLg0KT2ssIEkgd2lsbCByZW1vdmUgY29uc3QN
Cj4NCj4+ICAgew0KPj4gICAgICAgc3Bpbl9sb2NrKCZwZGV2LT52cGNpLT5sb2NrKTsNCj4+ICAg
ICAgIHdoaWxlICggIWxpc3RfZW1wdHkoJnBkZXYtPnZwY2ktPmhhbmRsZXJzKSApDQo+PiBAQCAt
NDgsNiArNDgsMTEgQEAgdm9pZCB2cGNpX3JlbW92ZV9kZXZpY2Uoc3RydWN0IHBjaV9kZXYgKnBk
ZXYpDQo+PiAgICAgICAgICAgeGZyZWUocik7DQo+PiAgICAgICB9DQo+PiAgICAgICBzcGluX3Vu
bG9jaygmcGRldi0+dnBjaS0+bG9jayk7DQo+PiArfQ0KPj4gKw0KPj4gK3ZvaWQgdnBjaV9yZW1v
dmVfZGV2aWNlKHN0cnVjdCBwY2lfZGV2ICpwZGV2KQ0KPj4gK3sNCj4+ICsgICAgdnBjaV9yZW1v
dmVfZGV2aWNlX3JlZ2lzdGVycyhwZGV2KTsNCj4+ICAgICAgIHhmcmVlKHBkZXYtPnZwY2ktPm1z
aXgpOw0KPj4gICAgICAgeGZyZWUocGRldi0+dnBjaS0+bXNpKTsNCj4+ICAgICAgIHhmcmVlKHBk
ZXYtPnZwY2kpOw0KPj4gZGlmZiAtLWdpdCBhL3hlbi9pbmNsdWRlL3hlbi92cGNpLmggYi94ZW4v
aW5jbHVkZS94ZW4vdnBjaS5oDQo+PiBpbmRleCA5ZjViNWQ1MmUxNTkuLjJlOTEwZDBiMWY5MCAx
MDA2NDQNCj4+IC0tLSBhL3hlbi9pbmNsdWRlL3hlbi92cGNpLmgNCj4+ICsrKyBiL3hlbi9pbmNs
dWRlL3hlbi92cGNpLmgNCj4+IEBAIC0yOCw2ICsyOCw4IEBAIGludCBfX211c3RfY2hlY2sgdnBj
aV9hZGRfaGFuZGxlcnMoc3RydWN0IHBjaV9kZXYgKmRldik7DQo+PiAgIA0KPj4gICAvKiBSZW1v
dmUgYWxsIGhhbmRsZXJzIGFuZCBmcmVlIHZwY2kgcmVsYXRlZCBzdHJ1Y3R1cmVzLiAqLw0KPj4g
ICB2b2lkIHZwY2lfcmVtb3ZlX2RldmljZShzdHJ1Y3QgcGNpX2RldiAqcGRldik7DQo+PiArLyog
UmVtb3ZlIGFsbCBoYW5kbGVycyBmb3IgdGhlIGRldmljZSBnaXZlbi4gKi8NCj4gSSB3b3VsZCBk
cm9wIHRoZSAnZ2l2ZW4nIGZvcm0gdGhlIGVuZCBvZiB0aGUgc2VudGVuY2UuLi4NClN1cmUNCj4N
Cj4+ICt2b2lkIHZwY2lfcmVtb3ZlX2RldmljZV9yZWdpc3RlcnMoY29uc3Qgc3RydWN0IHBjaV9k
ZXYgKnBkZXYpOw0KPiAuLi5hbmQgbWF5YmUgbmFtZSB0aGlzIHZwY2lfcmVtb3ZlX2RldmljZV9o
YW5kbGVycyBhcyBpdCdzIGNsZWFyZXINCj4gSU1PLg0KT2ssIHdpbGwgcmVuYW1lDQo+DQo+IFRo
YW5rcywgUm9nZXIuDQpUaGFuayB5b3UsDQpPbGVrc2FuZHI=


From xen-devel-bounces@lists.xenproject.org Wed Oct 27 09:24:14 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Oct 2021 09:24:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.216774.376503 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mffA5-0004pl-E4; Wed, 27 Oct 2021 09:23:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 216774.376503; Wed, 27 Oct 2021 09:23:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mffA5-0004pe-Av; Wed, 27 Oct 2021 09:23:57 +0000
Received: by outflank-mailman (input) for mailman id 216774;
 Wed, 27 Oct 2021 09:23:55 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Ie0f=PP=citrix.com=roger.pau@srs-us1.protection.inumbo.net>)
 id 1mffA3-0004pV-Oz
 for xen-devel@lists.xenproject.org; Wed, 27 Oct 2021 09:23:55 +0000
Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 34a7a848-878b-4eb9-bef7-079b9d0a5116;
 Wed, 27 Oct 2021 09:23:54 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 34a7a848-878b-4eb9-bef7-079b9d0a5116
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1635326634;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=IhK61ohyCJ3J+SKOaXO28vQ7vrrMr1/jcNPmr+N3S2c=;
  b=M36z9j9oJGomXpe75+MP4uWJ2jJeHma2lXTVGRW65fgmbWDHZ2QTh9lM
   hXb97A5oPpMErOqyAxo77/qOilMuPNdS7b9D6tLFPZiN7FHpz2EQ7TImz
   tlbxaRm/WLJbKxvpFcTOZcwUnOEFoDqBUvn2/IBZhFEJDKY1tABI9+u9u
   M=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: 30JGsgw1EYWZfFxYLUrdpJ8dyPBIVI/3vz+M6jZ7V/jk5sG7ag4FxzzxHCUq0/b2rX4kGU7gFP
 R7d7QTklNSPXSetjOwPau8ZqEXMxJoSouCUmPdDn5ZwuREd0EaWEDIOpHeVgkoGaTqGr7edG1m
 1gD3jAyDK+pFLiOruyYPBZbkW768r5flIr3IfGS5YRwfS/27rzGBGM62aOp8hjiYnhXROQFqWS
 D4qRIVEuDr1wMYdQovRPD7yxIayIKqXMgDzpL/xw7/8dX2uQdQsYoS6UFJDyfMFCwosj2EU5Qa
 rXCbMNsCmGLNqHlxfW3dOWEx
X-SBRS: 5.1
X-MesageID: 56732256
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:FtxOZ6DvbnZY5BVW/2Hlw5YqxClBgxIJ4kV8jS/XYbTApD4lgmdUz
 mEWC2+PP/uDZDPweY12Ody/9EsO7cOAn4RmQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA
 xA2M4GYRCwMo/u1Si6FatANl1ElvU2zbue6WLGs1hxZH1c+EX550007wobVv6Yz6TSHK1LV0
 T/Ni5W31G+Ng1aY5UpNtspvADs21BjDkGtwUm4WPJinj3eH/5UhN7oNJLnZEpfNatI88thW5
 Qr05OrREmvxp3/BAz4++1rxWhVirrX6ZWBihpfKMkQLb9crSiEai84G2PQghUh/0xeiu9J88
 eR0lKOVdVsIHYHSpNkeekwNe81+FfUuFL7vJHG+tYqYzlHccmuqyPJrZK00FdRGoKAtWzgIr
 KFGbmBWBvyAr7veLLaTUO5ji95lNMD2FIgepmth3XfSCvNOrZXrHvuVvoUCgWlYasZmOPD9X
 8ErciBWNUrQSUcfNHkJD84UtbL97pX4W2IB8w/EzUYt2EDS0w5ZwLXrKMDSeNGBWYNShEnwj
 mjL5XjjCxcWctmW0yOY82mEj/XK2yj8Xeo6DrS46/osm1yVyWw7AQcTE1C8pJGRkVWiUthSL
 0gV/CsGrqUo8kGvCN7nUHWQh3qJvQUVXdZKJMQ85BuQ0arf4wufBW8sQyZIbZots8pebSwn0
 BqFks3kARRrsaaJUjSN+7GMtzSwNCMJa2gYakcsTxYB4tTliJE+iFTIVNkLLUKupoSrQ3eqm
 WnM9XVgweVI5SIW60ml1QjlqBauq6H4dy8KwzmLf0GJ8D9EZ6fwMuRE9mPnxfpHKY+YSHyIs
 34Fh9WS4YgyMH2dqMCeaL5SRO/xtp5pJBWZ2AQ1R8BwqFxB7lb6JdgIiAySMnuFJSrtldXBW
 0TUpR9KrKFaOH+nfMebiKrgVpx0k8AM+TnjP804j+aigLAtK2drHwk0PCZ8OlwBdmB2ycnT3
 r/AKK6R4Y4yU/gP8dZPb751PUUX7i4/33jPYpvw0g6q17GTDFbMF+xYagTVPrphtfvZyOkwz
 zq5H5HSo/m4eLanChQ7DKZJdQxaRZTFLcmuwyCoSgJzClU/QzxwYxMg6bggZ5Zkj8xoehTgp
 RmAtrtj4AOn3xXvcFzSAlg6Me+Hdcsv/BoTYH13VX71iidLXGpaxPpGH3fBVeJ8r7ILID8dZ
 6RtRvhs9dwVFWueq2VHNMCsxGGgHTzy7T+z0+OeSGFXV7ZrRhDT+8+ieQ3q9SIUCTGwu9d4q
 Lqlvj43i7JZL+i7JMqJOv+p0X2run0RxLB7U0fSe4EBc0Tw6ol6bSf2i6Zvcc0LLBzCwBqc1
 hqXXkhE9bWc/ddt/Ymbn72AoqeoD/B6QhhQEV7E4OvkLiLd5Gein9NNCb7aYTDHWWro06y+f
 uEJnerkOfgKkQ8S4YpxGrpm14wk4N7rq+MIxwhoBiyTPV+qFqlhMj+N2swW7v9BwbpQuA2XX
 EOT+4YFZeXVaZ29SFNIfVgrdOWO0/0QiwL+1/VtLRWo/jJz8ZqGTV5WY0uGhhtCIeYnK4gi2
 +og5pIbslTtlhowP9+apSlI7GDQfGcYWqAqu5xGUo/mjg0nlgNLbZDGU3Kk5ZiOb5NHM1UwI
 y/Sj63H3uwOyk3Hens1NH7MwesC2she5EEUlAcPdwaTh97Ipv4rxxkAoz04QzNcwghDz+8ua
 HNgMFd4JPnW8jpl7CSZs7tAx+2V6MWlx3HM
IronPort-HdrOrdr: A9a23:xsh/ZKFtn8NS5PzJpLqFcpHXdLJyesId70hD6qkvc3Nom52j+/
 xGws536faVslcssHFJo6HmBEClewKnyXcT2/htAV7CZnichILMFu9fBOTZsl/d8kHFh4tgPO
 JbAtRD4b7LfClHZKTBkXCF+r8bqbHtmsDY5pav854ud3ATV0gJ1XYGNu/xKDwReOApP+tcKH
 LKjfA32AZINE5nJPiTNz0gZazuttfLnJXpbVovAAMm0hCHiXeN5KThGxaV8x8CW3cXqI1SvV
 Ttokjc3OGOovu7whjT2yv66IlXosLozp9mCNaXgsYYBz3wgkKDZZhnWZeFoDcpydvfpWoCoZ
 3pmVMNLs5z43TeciWcpgbs4RDp1HIU53rr2Taj8DLeiP28YAh/J9tKhIpffBecwVEnpstA3K
 VC2H/cn4ZLDDvb9R6NpuTgZlVPrA6ZsHAimekcgzh0So0FcoJcqoQZ4Qd8DIoAJiTn84oqed
 MeQv003MwmMm9yUkqp/FWGmLeXLzEO91a9Mwc/U/WuonhrdCsT9Tpd+CQd9k1wgq7VBaM0oN
 gsCZ4Y5o2mePVmGp6VNN1xMvdfNVa9NC4kEFjiaWgPR5t3cE4klfbMkcEIDaeRCdo18Kc=
X-IronPort-AV: E=Sophos;i="5.87,186,1631592000"; 
   d="scan'208";a="56732256"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=R6vGwwO1+8I0kAfL23Zd9RvAZAs6Qm+gajciVmOw64LU1ZQZ4kw1NeXYr4rjhhBpitiqt/t0oQ7whPbgt7yl8HBlZ3auXu8aOTofqy0Nv5MNzEwKrk5Ei10NoyaYp2EH4GSn3UODLAy95WMCqiH6KBL/B+YVXDYQOlXnwjDU6O8kXtvm5ANj4s85S5wiCES+D4eybBXcfHSq7ku2WKziSaEfvbyoenPjiy+UP+b04sJZmpkqRLo9uTM86bWJyJUvHRZS5bXAqkPu6Qm7oRQTPqaNPk+xwfjTsu9SCmkKbylaXMtweZPVB2P9UEnFIhFT2jFePIphzoLigY/VS38z1w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=5L8CzlgT1le84DZ9Sp6SZvczRzklAW2BzcApxY0BHK8=;
 b=dcfFfk/BIvACbYm8YVPOKHameI0frTqGOvSpu7je83fLLFcVoNohDM7VKznAhVo5hzJLOC3UtiCQuKXoK/tfRK5jx5xgwoNpvgcujnW5Sico5DOsdnUlcHRmg82btGUcoYlX07IibGJraJ25wbhOm9y2iwWyiAJsUSl4cyafSBg8C6Y6JJgiL90xsB6TBENn9uzHIe7yncOsrfT3VVv6Z5gMB2SuPzKWSC/sq20O5aCbFM0Vc5j3f/4LZR531FtO3En/UjZqx5U2qyrQQyrDfnkWakos+CrHHRTykQMCIoT5wafE8Zyl+82P9sFHy+fRYzq/Bs5xm1CJAOmNPLv54g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=5L8CzlgT1le84DZ9Sp6SZvczRzklAW2BzcApxY0BHK8=;
 b=VWXuUPd7bqH1XnhVCI5QC5zH8F0c8Ely8JOValR4F3yiYJOrLwzT4hz1Vjto4Xkem3J5rTI+4QPEhu6aBRB7RwrZ7ZjA+EuoFhWFxfdN2ZGWJXzzuemJjWZ5BgUD53xJUds+4QtDNPhncbSsHg9JXgPYglRS9qgFglF4y5zUPNU=
Date: Wed, 27 Oct 2021 11:23:46 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	"julien@xen.org" <julien@xen.org>, "sstabellini@kernel.org"
	<sstabellini@kernel.org>, "iwj@xenproject.org" <iwj@xenproject.org>, Bertrand
 Marquis <bertrand.marquis@arm.com>, Rahul Singh <rahul.singh@arm.com>
Subject: Re: [PATCH] xen/arm: fix SBDF calculation for vPCI MMIO handlers
Message-ID: <YXkaov2E5CdWRjlr@Air-de-Roger>
References: <20211027082533.1406015-1-andr2000@gmail.com>
 <YXkU+DKYmvwo+kak@Air-de-Roger>
 <0bbe4d1d-421d-e816-42aa-f43581902a02@epam.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <0bbe4d1d-421d-e816-42aa-f43581902a02@epam.com>
X-ClientProxiedBy: MR2P264CA0107.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:500:33::23) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 6b193c5e-6be5-492b-4ca7-08d9992b7d4e
X-MS-TrafficTypeDiagnostic: DM5PR03MB3370:
X-Microsoft-Antispam-PRVS: <DM5PR03MB3370068FDD3B98A1DE319DF38F859@DM5PR03MB3370.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: C1uZdeIWa+u+ulq71U6H2hMMiUNmacANfPeb6IweWSH10YtMUFdxVhRXRsfFsPsUhcoJ9R9+hJYJUeow/KWjBSt5HdmaeOKAfoiEggNLBqbs7Oj2nt2vh+MM4jFzErkFiUiHSgzgcTGdch/gD8cXELwMWSmH3AribpRBm8X3HXLCxCgI0HvutTLn75cgWp5KKuXac8m7v6FHyETlQ2267uYzTNWex6afP9RBnniMS8lxrXO7KJNWltijBs2CN4f2VGyi5QvRcrh6TmJ13vse+VeKZ9SRn7PuvOh7w2uHy4egWx6ImbRu4hB5Ob1KJhzhkl7BREv9GZB25XE+pZ/wDpyN5d2JMHrKZIwME6kzf0mhRxuTz7IHzXvMGwDf86cjbTb9r5jV1ADOqI8C9z3ng8ZHAOOvWzqZnKtc49lfllhedBk/rhhSGwivHZEtTRsE6URubNL64T0vmJSRpicNeioGKWtjSCQQtiXyqdfXPiZexAa09QTF+wOAAmSOWbHxQlkoIaG6SW6UvlBLDVgVF8Dmwr3EpcqfrniJvO41GpLZ58aZpffj+hjIVf95/fbXQ3rcz5GLQ2Crh0Ko81Zi9FIl/rw6OHJ8gI8I6vG1tXG0VREB0Y63912owsY4wRUMcL0A9mRgk4yuvYWeGkdLDA==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(7916004)(4636009)(366004)(66476007)(26005)(186003)(9686003)(6486002)(2906002)(508600001)(33716001)(956004)(316002)(66946007)(54906003)(5660300002)(6496006)(86362001)(85182001)(6916009)(53546011)(8936002)(82960400001)(4326008)(6666004)(83380400001)(66556008)(38100700002)(8676002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SlNnL1cvd2daRE1QL0l3d2F2YmJKVnRFMEN0dmdoKzl2VnpzUlNhYkdzNERz?=
 =?utf-8?B?L3gyekFrclJEUWg5aVNMUkx4S1hrMVUzVURNWGsyMGdBcHpzbzh6MUJiNGRy?=
 =?utf-8?B?RzZyWHFCaTZwcUFoRTJXd0c3WFBtSXQ1SmNWWlpBVlc0T1c0Vkx6dVh4Nldq?=
 =?utf-8?B?ZnVPYzVxdVJsNnVvN1czZHBGaGtUTnJXTVEzYkgrUWVNU1dtY1ZNZTlpVzd5?=
 =?utf-8?B?aXduc3MzcmVrSjFHZ2JMRG8rbHhhbDdpNE5ac3RrZ1IzeGhjUWZHRmhHZzBN?=
 =?utf-8?B?NWJLemtmaWYrZlFEck5DNXVHcWpIVEhnQkFsK2wzUUdkRjY1QmxhL2l3VkNh?=
 =?utf-8?B?RWpOM3lZTjd5WElEeHBXNjU2MG5tOUdYeWpmMldGdG5pQ1RCdGp1WmlpcE1W?=
 =?utf-8?B?ZnR6ZUpSeHZNUlExc3BKbzdvbEkwQkdxcXduc0ZZbUsveTZPa0Z6a09lWXNH?=
 =?utf-8?B?Uzk5UHROMmVBdTRSZXgzaHQrYzFzSStjbEJiWGdmSkJBV092NlVEb3VleHR1?=
 =?utf-8?B?ZUgyWGJXMkU1bjZTVDNSSVBpVHVHc2x6dmFKSmVtWXFIWWR5VlFoaEthaGJp?=
 =?utf-8?B?WDNkZTA2UUxUYkRSNnJxblNHMFNPY3l3dDVWSVAyazVZTnBlYXBvU0F1WlFX?=
 =?utf-8?B?RXdJRm1CWDdzcC9RQ2NpZm41MElpeUVYOVpkMVhaNWh4Z2luN045eU5JVUlk?=
 =?utf-8?B?RWFBbURZUjhqajBGNzlBaGFudis3MW0zUCtuMEtMcC9kZkltd2k5WVQxS1ho?=
 =?utf-8?B?cy9vM1F1YzRDVXhwSmFzUVpnSnVoZm5Yck5RYnNFa3VjYVF0dUhiT04zd1ZS?=
 =?utf-8?B?Y0xnUlJsb2xKNjdIS3RXTUxqRXhhR1FTcWpheE04bERPQUsvQm1rMndnTlJr?=
 =?utf-8?B?dTFoSENRNDc0Q3ZwQW9IVXBXS0J4WEkremphVTEvdXdDZ0owYThWN21xbkFa?=
 =?utf-8?B?VGxLRjBTckIrUkRIaXBWYU1FcjVURXNWbXNrYWprMkpIZDZrK3ZyN1U4ODk0?=
 =?utf-8?B?aWZLanQ2UTJMSU1zL2lFZUptU2loZjNMUzJDSlN2aUNvQlBGUE5kUWVrbUJp?=
 =?utf-8?B?Yk9ZNm1vQ0JQSkM0b0xha1JOU3A4bHFPVnVkekV3YUNSdEQzaDI1MTl5TnpW?=
 =?utf-8?B?Ym1XcE04MEdyRnpybEdURDF6S0FRRzE2c2xLVHVwMzVDMmc1S1RaQVVEeWgw?=
 =?utf-8?B?bDJWMTFyZlJpdDVIclZTYmt4SlNMZWRqVTF0VDBaVkRWNk9peFBENGRaNXRj?=
 =?utf-8?B?eUN6RU5VMTUwRTlZeWFxMVQra3dWcTdZdEZQVFhVZHNUNmROQy9IbzNFUTRp?=
 =?utf-8?B?SjgwZ2hIdGtHY25hZHh0d0EyMU9ldGg2UDhyeVZMUUh3VWRuYUpPUWJjT25N?=
 =?utf-8?B?U3Naek1ROXQ4R0JBS1U4RUxmVU0wOUo2RFhKYjZmaXNHUWpheW9HM3pSRHU1?=
 =?utf-8?B?TWRENDNvQTZmeXlJa3k2cW96WTV3eFJmWjBlNWloQTNrN2JKUnplZFp2TmZD?=
 =?utf-8?B?d2VnMGE2MGhoNm05RFRtZXZtRXRRaDZqcnFMU0N5VlQ4VmRZNW5uaGp5OUhG?=
 =?utf-8?B?VFRSd0Q1SWdrdm80bW5BM2lLVXllV0JyRE93eloxM0xUWmFUaDhmQXpscUNv?=
 =?utf-8?B?WGZJbkUzUnQ1TW9PTUJXYW5WbHRXVlhkaHpnVzF0M0pDdHNHbVBmUEtoNHI5?=
 =?utf-8?B?VUMvUnFqcWlmTlhtNVh0MzBVLzk2eWJVSVpSNXdFdHVpbGFMeEh2NXNya1Zj?=
 =?utf-8?B?TWZyY0tnKysvcVBBeUxDU3AvQ1ZZQStZeUVkb2NXZ3NwTm1OeWx0UWgwU0Q4?=
 =?utf-8?B?T05FaG10eEEzZ3pNYUcvdlVGb3Y2V1dBclJMTVR3VnlCUDNvT0lJMDIwWnRK?=
 =?utf-8?B?bEJrL2RBOUJRV3ltcmQvTFVOaVRrRk1sZHE0WWxPcDd4anRMQ0piM3ptV0lh?=
 =?utf-8?B?OENhUklLT2Y4QmxzS3RaVlhDb2lWUEEzdHhjMEdFWGt0SWg1Q2ZNdlIyVEZT?=
 =?utf-8?B?STBYS3ZNa2FNZkVXR1d6UllVM0ZvTDJ1SytLT3J5cThVdW1mVVI0Zmw4UlAz?=
 =?utf-8?B?dE9McVR3YUVlZDVtcW5xZUZiTUZiaS9YMnVkWXVUOFN1dVJwOVlRTXhoVTAw?=
 =?utf-8?B?VHF5RlN2SERleWlEdU5wQ2VVU0hXVHVCMzM1dW9uOFJqejZtSjF0cGlQNGlk?=
 =?utf-8?Q?R89yDxNXlusopbNpTajWWeU=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 6b193c5e-6be5-492b-4ca7-08d9992b7d4e
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Oct 2021 09:23:51.6962
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: k5I6G0SKVFNrje7LyvfskW3FWyGOMrIFYGyi2lgEelQAXnA+Y7X2OT6tfAijM0K+9o+P4RpCsuY6+yo6ivnK+w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB3370
X-OriginatorOrg: citrix.com

On Wed, Oct 27, 2021 at 09:04:39AM +0000, Oleksandr Andrushchenko wrote:
> Hi, Roger!
> 
> On 27.10.21 11:59, Roger Pau Monné wrote:
> > On Wed, Oct 27, 2021 at 11:25:33AM +0300, Oleksandr Andrushchenko wrote:
> >> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> >>
> >> While in vPCI MMIO trap handlers for the guest PCI host bridge it is not
> >> enough for SBDF translation to simply call VPCI_ECAM_BDF(info->gpa) as
> >> the base address may not be aligned in the way that the translation
> >> always work.
> > I think I've already raised this during review [0]. But this is only a
> > problem if you change the current value of GUEST_VPCI_ECAM_BASE
> > AFAICT, as the current value has bits [0,27] clear.
> Exactly, so we were just lucky not to hit this before
> >
> > I assume this is a problem for the hardware domain that needs to trap
> > random base addresses as present on hardware, but that code hasn't
> > been committed yet.
> Yes, I am facing this on the real HW when Dom0's access is trapped
> and the base is not taken into account. So, I have a patch for the
> future upstream which subtracts the relevant base from the gpa,
> e.g. either GUEST_VPCI_ECAM_BASE or bridge->cfg->phys_addr
> >
> > If that's indeed the case, please expand the commit message to contain
> > this information.
> I can only mention about "the current value of GUEST_VPCI_ECAM_BASE
> AFAICT, as the current value has bits [0,27] clear" as of now because
> Dom0 traps are not yet there.

Indeed, I would rather mention both cases, ie:

"This change is not strictly required given the current value of
GUEST_VPCI_ECAM_BASE which has bits 0 to 27 clear, but could cause
issues if such value is changed, or when handlers for dom0 ECAM
regions are added as those will be mapped over existing hardware
regions that could use non-aligned base addresses."

Regards, Roger.


From xen-devel-bounces@lists.xenproject.org Wed Oct 27 09:25:08 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Oct 2021 09:25:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.216781.376515 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mffB3-0005Ru-Sc; Wed, 27 Oct 2021 09:24:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 216781.376515; Wed, 27 Oct 2021 09:24:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mffB3-0005Rn-OV; Wed, 27 Oct 2021 09:24:57 +0000
Received: by outflank-mailman (input) for mailman id 216781;
 Wed, 27 Oct 2021 09:24:56 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Ie0f=PP=citrix.com=roger.pau@srs-us1.protection.inumbo.net>)
 id 1mffB2-0005RZ-2y
 for xen-devel@lists.xenproject.org; Wed, 27 Oct 2021 09:24:56 +0000
Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id be88b84c-3707-11ec-8458-12813bfff9fa;
 Wed, 27 Oct 2021 09:24:54 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: be88b84c-3707-11ec-8458-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1635326694;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=11GGaEddtHy7gl+GmoJsuUS9EKnxMwJyj6L3b0aiG/Y=;
  b=OTwlPrut0ptmi4SZ2JWxzwC3Li8eiS53HU2BAi+7/W9jsX00G8YcHkKz
   SfyV3vj+0gOr20P2qFAHkx9heRT61sNrYRX51L+eHKRHWm55CVZHfLqA9
   LLlEZmBVKEK9XcRS1CZSU68W4T3F3tubc1nWPR1djeXTx3WyNwtResGBw
   E=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: jajpmi9XpV3kCblhCV/013KNh/NqOsrKsXCTYhNX1lvBJaxw/F/MJPZ12JoPvz2/J+2VISKQcJ
 QEkEemXCXdaReCQ4wmdJs+Zs9atIZYvzKF+EQQVZkOB70Y5mQ5DRY7R/5rTYMoWovd+02sL+3Z
 IZUhC06PsAaPPUSpDs+CqxJP6ge5Q1ndJNbo0UPVwmLAhy1QZRPyuOw2eEDktoUn21sUbyv6E3
 nqE28o5ZwX0brwkdqLBjVmn59gBqO7QxzKpWUNj7FvlDutwUbn/C7ydjb7Z3h4/tRS4A7w7LD4
 H/SiQoOJDXTNgsk+X9It31HX
X-SBRS: 5.1
X-MesageID: 56361501
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:GfDF56s8Cik9ZVIGFIej1steCOfnVGZYMUV32f8akzHdYApBsoF/q
 tZmKWzQP/uNZTGgKIwkPNjn9UsGuMDSnNBmHgdvqHthEHgU+JbJXdiXEBz9bniYRiHhoOOLz
 Cm8hv3odp1coqr0/0/1WlTZQP0VOZigHtIQMsadUsxKbVIiGHhJZS5LwbZj29cw24fhWmthh
 PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe
 gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ
 Nplp7zsSAEXYaL2qcscTSUICX1FAZVZ0eqSSZS/mZT7I0zudnLtx7NlDV0sPJ1e8eFyaY1M3
 aVGcnZXNEnF3r/ohuLgIgVvrp1LwM3DJoQQt2sm1TjEJf0nXYrCU+PB4towMDIY254VQ6+DP
 5NxhTxHMTeZaTd9AkYtV5Mcs/m5jSD6XRh7kQfAzUYwyzeKl1EguFT3C/LXcNGXQcRenm6Du
 3nLuW/+B3kyHcaDxD+y12Ojj+7Cgwv2QIsXUra/85ZCilCJ2nYaDhFQUFKhuOS4kWa3QdcZI
 EsRkgIrrKMy/UjtScPvUhmQqWSB+BUbXrJ4CeQ69QXL0avS7AaxD3IBCDVGbbQOisgyQjA70
 06TqPngDzdvrb69RGqU8/GfqjbaETgYKyoOaDEJSSMB4sL/u8cjgxTXVNFhHaWpyNrvFlnY5
 DSHrzM3gbkJuucN27+m5lDMgz+qpZ/hQxY840PcWWfNxgFkYI+oYaS45F6d6uxPRK6+SlSCp
 3ECl9Kp0PEVDZqNmSqOR80ABLisof2CNVX0mkVzFpMs8zCs/X+Lfo1K5jx6YkBzPa45lSTBO
 RGJ/1kLvdkKYSXsPfQfj5+N59oC34i8FNLbCf/uX/VPfKQhblO8wBlxTBvFt4zyq3QEnaY6M
 JadVM+jC3cGFKhqpAaLq/chPawDnX9mmzuCLXzv51H+i+DGPS/KIVsQGALWNrhR0U+SnOnCH
 z+z3eOxwBJDTPa2XCDT9YMCRbzhBSlmXc6owyC7m+jqH+aHJI3DI6OOqV/CU9Y890iwqgsu1
 ivlMqO/4AGm7UAr0S3QNhhehErHBP6TV04TMy02JkqP0HM+e4up56p3X8JpJuR9q7czl6YtF
 6RtlyC87hJnEGyvF9M1NsCVkWCfXE7z2VLm09SNOWBXk2Fcq/zhpYa/I1qHGNgmBSurr8ouy
 4BMJSuAKafvsz9KVZ6MANr2lgvZlSFExIpaAhuZSvEOKR6E2NU7dETMYgoffphkxePrnWDBi
 W57wH4w+IHwnmPC2IOW2vnU/t3wSroW84gzNzCz0Ita/BLypwKL6YRBTPyJbXbaUmb187+lf
 uJb07f3N/hvobqAm9AU/29Dwf1s6t3xiaVdywg4TnzHY07yUuFrI2Wc3NkJvapIn+cLtQyzU
 0OJ299bJbTWZ5+1TA9PfFIoPraZyPUZujjO9vBpck/00zB6oeicWkJIMhjS1CEEdOlpMJkoy
 PsKsdIN71DtkQIjN9uL13gG92mFInEafb8gs5UWXN3ihgYxkwkQap3AEC7mppqIbowUYEUtJ
 zaVgovEhqhdmRWeIyZiSyCV0LME15oUuR1MwFsTHHizm4LI1q0twRlc0TUrVQAJnB9J5P1+Z
 zpwPEpvKKTQozox3JpfX3qhEh1qDQGC/hCj0EMAkWDUQhX6VmHJK2Fha++B8FpArjBZdzlfu
 rqZ1HzkQXDhe8Sohnk+XktsqvrCS91t91KdxJD7TprdR5RqMyD4hqKOZHYTr0q1CMw8s0TLu
 O128bsicqb8LyMR//U2BoTyOW78k/xYyLiumc1cwZ4=
IronPort-HdrOrdr: A9a23:F2Btlqt+uAgRkOFdwrfsGy+O7skDjNV00zEX/kB9WHVpm6yj+v
 xGUs566faUskd0ZJhEo7q90ca7Lk80maQa3WBzB8bGYOCFghrKEGgK1+KLrwEIcxeUygc379
 YDT0ERMrzN5VgRt7eG3OG7eexQvOVuJsqT9JjjJ3QGd3AVV0l5hT0JbTpyiidNNXJ77ZxSLu
 v72uN34wCOVF4wdcqBCnwMT4H41qf2fMKPW29+O/Y/gjP+9Q+V1A==
X-IronPort-AV: E=Sophos;i="5.87,186,1631592000"; 
   d="scan'208";a="56361501"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=DAU1XJhJ11R8Oh1gTfhUGqgSkZQf+IyBIxpiZQWwECuKgiaIM7DyNCUDPktg+2aX8DYkzdhQYlRiFGk4kjRhQTzTNdOGgS1D85jBaw6/yrv8auPnIXsLN523680SBA3TmXitC5A4ws3Q1A7jyie5TcrqZOJ2N6Qk9PgTQdRjopj9YOBZQfdbayzG3lWpKF0lAL5Jz5f3G7mbjzOHWX2RC0DulUjxkewVODsFjcG2zLWhkhw5Hbp+fY2KHB2K/QOCeO8gXrqs4luI3cN9GVhbw1lfFF1DZ8HXISbwmKk0T9f8EToeYxteIssn/JMSqOwHPFQLc9RB7rpufqMka+GJpg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=De6mRbBeaXJ5hE46PFVc15Mw24RA1tA2s9Bo9yHTTdo=;
 b=UgF5fuxfbt3B2qV2Nh40J+gDjBCeXQOQUOXo8dKbN88izl/4k0DZUg2SgTJaYXrHXXv8tN+NyWzL9558qa77a1lB9YdgYgMApAyWFQPd+e/r0ukMxQcVks5b/OxWVj8Xnojejum6jxfZTUn6tZLBbTWa+MpxEheEYZRZZ9zZBW8gjDzVDAqhbL3g1JZSQc5m/lV1V9gJ265VHTF4Q+IltxkYjedoTd02PK68ASW3RI7XoQ3J9LbAmOSSWkXB2gS/Xngpd31wacgI2+LZXAGd+zpTBSG8sMIN/HH5UAlceCA1N4y5OYOQpif4pLpy7dlO5CRLbwzWLPEM30Ab5SDkhA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=De6mRbBeaXJ5hE46PFVc15Mw24RA1tA2s9Bo9yHTTdo=;
 b=rHI06oer5CH3oLzaR8LDPYKCdSljnW19OIfKWlt4yeGo62KFCKZPsEBFSC+XzsBQTchJnzvpvwCk0Bsau40sxfdr9fNTUoYl9LRLyRJqQfQwMepa3SaiKO8XbmxjcKZe/Sxy9n5oLkMTHZi5vuoioDcc89Ti8PnS16zqYgzPf24=
Date: Wed, 27 Oct 2021 11:24:44 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	"julien@xen.org" <julien@xen.org>, "sstabellini@kernel.org"
	<sstabellini@kernel.org>, Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Artem Mygaiev <Artem_Mygaiev@epam.com>,
	"jbeulich@suse.com" <jbeulich@suse.com>, Bertrand Marquis
	<bertrand.marquis@arm.com>, Rahul Singh <rahul.singh@arm.com>, Michal Orzel
	<michal.orzel@arm.com>
Subject: Re: [PATCH v3 01/11] vpci: Make vpci registers removal a dedicated
 function
Message-ID: <YXka3C3x2ixNyrFE@Air-de-Roger>
References: <20210930075223.860329-1-andr2000@gmail.com>
 <20210930075223.860329-2-andr2000@gmail.com>
 <YWa+4hsaOxuX4tWJ@MacBook-Air-de-Roger.local>
 <387d3729-b182-1aaf-870e-505e90141606@epam.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <387d3729-b182-1aaf-870e-505e90141606@epam.com>
X-ClientProxiedBy: MR1P264CA0076.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:501:3f::19) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: dcd6eb02-2c85-4fe2-2874-08d9992b9fbb
X-MS-TrafficTypeDiagnostic: DM6PR03MB4684:
X-Microsoft-Antispam-PRVS: <DM6PR03MB46840BDB8A41E54EB3C5847A8F859@DM6PR03MB4684.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:4303;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: mijOUz2+lApp1ZvhghCaNXcweWHdVBrAaRI/FrU3WZNU1k1BKSMj0KbdHVesnBoANXA9wiEImbtyMTfa68LlD9TwUbM05zirHCbYP0z+tzgtHNiqd9ujpCaOr+wPNcFgEq/Kz+jcdMuz/rvtEI3ZBmPC5KJXbOg70EGHyUlCSV0DdC4mfKVTDuYtbqdJEpo33DC7lxymUV929S18GtHAiMULTJa+BXA8X4I5Cod2VDLrJIB24hJ7tNU4239kuueZfC3xAUYC9ZMm3NA8aVR3RTxWi1N5QP7t+u893ZHnEhjVFuqfVh/CqF447p3MGXpjPLSuEb0EV+QCeA8wyNRlbVWfVW7KTTcJSfhPkJ+V3EAr+iCbpSd+grRVD54mdBATf2D3RlDHjd3sgBIVNQcM0sCudgwpBdGrZEQQrD5439XEbSgtAUlJYN6jYRynhalun+do2DTBai5N88Eh14lA0vJbn3R0GQagAv6IotQQ+zGVSm6JvGt2S2Y8OUPRuVzOyTpy1HNYMI8Co0ZAuu/iIxyLfc8sKF6V29exwm/DaJ7R1zZo0HV3Wkwyau4sUPBdOEfxNWL+ldUnCUlXCzFVNoRMXTFfBP2UIkUNeS5sHaZwbWMEavXvb096kZ0WqjbOoJJiBASvfmEFCV2ME70xfg==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(7916004)(4636009)(366004)(85182001)(66946007)(54906003)(6486002)(66556008)(7416002)(66476007)(9686003)(956004)(6666004)(53546011)(6496006)(316002)(83380400001)(8676002)(6916009)(2906002)(38100700002)(186003)(26005)(5660300002)(4326008)(33716001)(8936002)(82960400001)(86362001)(508600001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SVREUmtMRWo2WFhtN3Nyc2JPL2ZZK0xoa1QrMGpxY2FqVG1PRjVPQWtQOWtM?=
 =?utf-8?B?T1cvNTRGSEdOam1VZ21jV2h5Slo5c1BVN01vNlQ4M0F0WHY0SzZoMnBhbGc5?=
 =?utf-8?B?RGt3bDY1Y2syV0xpL1pqYXRwdUNzR01SbUFSUGNBNDl1b0l6d0Q3Nlk5dktm?=
 =?utf-8?B?R05VZEN1K1h6UjBVRzRVV0VwS21aOWdEOUVKMitMZ3dWMXcwYndwRW44NUNs?=
 =?utf-8?B?V2VqVExjL2FvVHIrSFFLYmpZU1dmSkh3TkR3KzJWV3JDVElpdUdJSUdTNlg4?=
 =?utf-8?B?R2xXNGs4TStuRXJWMlhENExuNEJOeUt4K0ZjdmVxNS80dHlYQ0R2QzZJRzRx?=
 =?utf-8?B?QXNXdndKVFh0elN1TTdrWGdMMVFNK05ybkJiMDRlMHVPRlVZdVk5V3BpZ1RN?=
 =?utf-8?B?ZGczek5mSW1iNDFhWnh4cjQxTVZxUG5GKzY1Q29aU2lpSm5jUDhKZ2hGL21l?=
 =?utf-8?B?aVdRREhTSkQxajdaV3AyQ09BM083NW1mUExCU2RnUFU1MlJ1ZHpJa2t1YzFO?=
 =?utf-8?B?cEVmdGQxSjBWa2d6Sm9xaGJZS2FJYkVJT0ExZEprcVpsZHpZdVFiQkNueCtz?=
 =?utf-8?B?dEQ4S09SaDVSVVh5QjVNdzdHajIwalRsYXFxOUhTdmE3aGZHSkM0K0x4djVp?=
 =?utf-8?B?azZ1ME9TOUtRaHpaZTdPNnM3aEpsVGxXcitYTUNYdlM0eGlmSXlWQW9yVkg3?=
 =?utf-8?B?Mjdwa2RCdDNBZVhjZG8yNmhRMkh0anB3OGlEcS9qbVNXQi9Nc3pyUTJrN0Y1?=
 =?utf-8?B?bDBpc28xcXdZdUZxeGpSdzNqSnIvcENjcHhIQ3NBM0V5dXgwMHRWNEt0a2Nx?=
 =?utf-8?B?cUI4aHc4RUw2T0U5azdPdFg3SWc3Nk5rQ21STGJiL3lwLzhTeUg4a1lGdUF0?=
 =?utf-8?B?N0ZST21vdFh2Q3Nib2ppdGFwejZKL2lvZ0NjMUtwRkxQWncxQ1N5aUFEbE1E?=
 =?utf-8?B?SkFsRjV5Sk04dWlMTmM4SW1SWkgvZDhPdXZXNEhDSGNMM1VhVHEvMzFhYWdM?=
 =?utf-8?B?RGErV3VSVmQ3NGJBQnhMZ2ZtTStPMXBQZjBGVmZkZzBCNFVJOENETzd0cmk5?=
 =?utf-8?B?RTJJQ3V5enZ6UEpHaTlzZElOM2h5MlZOckxmT2lLMUFPY3F5alZvbU9iUW55?=
 =?utf-8?B?RE16MkFHZmE1UzE5Z2Q2VDVQaXAveUpWZlhkV3FRWW9maTBWL1pmNmtCcVVj?=
 =?utf-8?B?UmZDT0FNN3B3ZEVzNExtUHFmSlZIK3pyR05VVHg3NTBZbENGazRBeWVHN2NC?=
 =?utf-8?B?ZG02RE93MSt3NVZ1bnBoZ1ZPMHJmZmdmNGErNmk1eXlBSlNQL24wWUxLZity?=
 =?utf-8?B?eXFCbHVBWFV5aFRROWRjT3VJV1Q0MURFYVZCR3JaaU1oRWpPSnA0bys0S3lj?=
 =?utf-8?B?Q1RSNkRMTndYRUthSWc5eG4yVzl6bjhveGxINVNMSUltOFpGbTRvSDEzdFg2?=
 =?utf-8?B?eTFpdUdiZE1VenFOejJJYVZiQjErcXNHaXg2SmkxLzlyVEM0K2FMNUdDendC?=
 =?utf-8?B?TDRUUGVJaUlNOU8xdEVhQitDWFFKdm05bW5IV0RXOVh3NHZYYTRnVzZCWitX?=
 =?utf-8?B?djVuVkU4ZnNuTUZ4Zml1SmpxVnpENGp2c1ZYRkVmRXhRdnlyTUxLaWFaVExz?=
 =?utf-8?B?VWR5TExTUXp2cUpFQkxUWG9OT0pDQnluNTBjQ0wyVWZ4MnY5eFh0WmdHL1Rj?=
 =?utf-8?B?dHdvMnplZEFwRUdxS21Na1UyWVlmc2k2TmZiS2hqdTBMems4cGpDYWMyS2JG?=
 =?utf-8?B?YWJZbFRzcnIwczQxMStPL2dkZG50cGNSRXhycU1Lem0xMUVhN1RrZVpucXgv?=
 =?utf-8?B?WWhQQjFkR0w0Q043WUhPdFg1MnltOW8vOG5uUDNpaVlKa204K1BReU0rb1Fa?=
 =?utf-8?B?bW1CYmRQN1lkWEp1OFByUFVxNTBCOTZKQlNtd09oK0NCclRnaXFYc25xaDBk?=
 =?utf-8?B?NXpwaGMyRkIzVzk5bWpIYTk0Z1dTKzJvVGRuYTltdzhXMXJBQjdRM1NQOVJv?=
 =?utf-8?B?Sit1S3g4NjFBUENuRGIyRU1sMDE4YWQwR2RBdkRvam51cEluYWtOa0Vsd3Zo?=
 =?utf-8?B?MUg1UlpsWXVRbE5PeGdVR0NXT0J6M2o0NE50eHNsZ0w5NWtrRnBBM3FSUUdq?=
 =?utf-8?B?TEMzTDNQSVZxMTcreG1UaWtORldBQWZYbEFuSGRta2NtSnNhdzZqVS9PODll?=
 =?utf-8?Q?0eTNhHTqZeRq5mlbGApzb0U=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: dcd6eb02-2c85-4fe2-2874-08d9992b9fbb
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Oct 2021 09:24:49.4382
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: JgMdK8p2PH/4nQE+bhmLFLhxF8/Jj/FEcYmCl0q0mPGlA4OPD8RhDJjXOVMZMiKpR2gHfSN3ATJLweHOTNNHaA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4684
X-OriginatorOrg: citrix.com

On Wed, Oct 27, 2021 at 09:12:14AM +0000, Oleksandr Andrushchenko wrote:
> Hi, Roger!
> 
> On 13.10.21 14:11, Roger Pau Monné wrote:
> > On Thu, Sep 30, 2021 at 10:52:13AM +0300, Oleksandr Andrushchenko wrote:
> >> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> >>
> >> This is in preparation for dynamic assignment of the vpci register
> >> handlers depending on the domain: hwdom or guest.
> >>
> >> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> >> Reviewed-by: Michal Orzel <michal.orzel@arm.com>
> >> ---
> >> Since v1:
> >>   - constify struct pci_dev where possible
> >> ---
> >>   xen/drivers/vpci/vpci.c | 7 ++++++-
> >>   xen/include/xen/vpci.h  | 2 ++
> >>   2 files changed, 8 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/xen/drivers/vpci/vpci.c b/xen/drivers/vpci/vpci.c
> >> index cbd1bac7fc33..1666402d55b8 100644
> >> --- a/xen/drivers/vpci/vpci.c
> >> +++ b/xen/drivers/vpci/vpci.c
> >> @@ -35,7 +35,7 @@ extern vpci_register_init_t *const __start_vpci_array[];
> >>   extern vpci_register_init_t *const __end_vpci_array[];
> >>   #define NUM_VPCI_INIT (__end_vpci_array - __start_vpci_array)
> >>   
> >> -void vpci_remove_device(struct pci_dev *pdev)
> >> +void vpci_remove_device_registers(const struct pci_dev *pdev)
> > Making this const is kind of misleading, as you end up modifying
> > contents of the pdev, is just that vpci data is stored as a pointer
> > inside the struct so you avoid the effects of the constification.
> Ok, I will remove const

Jan prefers the const, so please leave it.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Wed Oct 27 09:42:00 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Oct 2021 09:42:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.216794.376526 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mffR1-0007s1-8y; Wed, 27 Oct 2021 09:41:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 216794.376526; Wed, 27 Oct 2021 09:41:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mffR1-0007ru-5s; Wed, 27 Oct 2021 09:41:27 +0000
Received: by outflank-mailman (input) for mailman id 216794;
 Wed, 27 Oct 2021 09:41:25 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=8lYk=PP=epam.com=prvs=0934bd4bd6=oleksandr_andrushchenko@srs-us1.protection.inumbo.net>)
 id 1mffQz-0007ro-6T
 for xen-devel@lists.xenproject.org; Wed, 27 Oct 2021 09:41:25 +0000
Received: from mx0b-0039f301.pphosted.com (unknown [148.163.137.242])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 8b500859-868e-4b5a-b6f5-a24f13a8cd3a;
 Wed, 27 Oct 2021 09:41:23 +0000 (UTC)
Received: from pps.filterd (m0174680.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 19R9SYsu027507; 
 Wed, 27 Oct 2021 09:41:17 GMT
Received: from eur04-db3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2052.outbound.protection.outlook.com [104.47.12.52])
 by mx0b-0039f301.pphosted.com with ESMTP id 3by2eggh5a-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Wed, 27 Oct 2021 09:41:17 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by AM9PR03MB6882.eurprd03.prod.outlook.com (2603:10a6:20b:283::8)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.14; Wed, 27 Oct
 2021 09:41:14 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::c038:e032:595a:651]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::c038:e032:595a:651%9]) with mapi id 15.20.4649.014; Wed, 27 Oct 2021
 09:41:14 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8b500859-868e-4b5a-b6f5-a24f13a8cd3a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=abl9azDnHaUtYamNfkqHcPk7m8Tr0uvt3st2JbwRpYo2FBGoH2w3FSfY6JHCyQ4//ipO2rekN+J5vF9KejqSb7CeYhGRWxvTggmkkEchknXkk+qoFpe42N4qtMm5wDF1ODeO/edOuf0O+BQ6LdRWftCVG3h8m7XZp+73gaT78Dh+NH47dOjjE6hJxbqZXiKR/4fbb2h3lgF2rjMWp+d1PQtz5u5fvl62zubclIKkcOzoHqAwAxoEJNSyuihWyCmDDYTNdbhDZv4Em19eO97RnwkvlJSeD63DboRAL3tactlcWJII0xSz9U8RUHMNKd0QlLnTVaKrdh+oMedBiFTsvA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=/Zo3f8esKNcRTrfaKmhM4Ab8eifI1HDYItbapSkXCU8=;
 b=THh1Scnn4AqDGD0lGd2gT3ov96FhebP3d1NPEY+LhCAg+B7wjv8TFDiZFP97uUJpoG+D25tVjszWMt/KWwpzSwgT2TQ8l7iMh96PUmI8XRCUVIZJhnqkjaGerX9Zd6R3VXHC4b4uquie/fn0rFb3qiSvsPpnynMeLdHziCIYKwGKv/lvpci62h/y4BWhrjdRJdswfEHRcDfT8giiRlGUDzUVffrd/N1wWUyixpxRz29KbaGJrU/aSyF2RBcNsVe+CzUjwTb1tm1J/sca4Zwcmq4OyfLUCljD8KmQ4Cs0PH3pG9VudERYES6d1ooiSBMNkVizvxYXD53XioStnTCafw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=/Zo3f8esKNcRTrfaKmhM4Ab8eifI1HDYItbapSkXCU8=;
 b=zFk2lh8XNdrx49OnQcmAm4vzxZtBToryY9Wf435ISbKpOZP+YWySw7K4baPYsXWsm4GhKOgBcncN6BKUbTzu/VFWSs2ms4uzjRUOH6cvdgCZ9QFzlFYOybgf7wk1gyHoxAA5i3dnUW4Mx5iuzHYjlaGzhjH5WUTKriGpHZWp1rHd93Iwtp5JqxOBuPldrhrgYtaEg9ryGynK7D5g1XZHgj1L86QIAH72liozjcjtDbgBYsMMo/oM1l3ijZbxYbA5YsEWWk3M7gNigMtuWSv6qv5ZqKWIsqeuLge8eA34rDtVUIgQxWzhT/ObvFpTcS73BSMRPZpt6x8+w5+xI21Jpg==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org"
	<sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "jbeulich@suse.com" <jbeulich@suse.com>,
        Bertrand Marquis
	<bertrand.marquis@arm.com>,
        Rahul Singh <rahul.singh@arm.com>,
        Michal Orzel
	<michal.orzel@arm.com>,
        Oleksandr Andrushchenko
	<Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH v3 01/11] vpci: Make vpci registers removal a dedicated
 function
Thread-Topic: [PATCH v3 01/11] vpci: Make vpci registers removal a dedicated
 function
Thread-Index: AQHXtdAgeXiPCGUCJ0Oi6HCqPD8Y4KvQ2oUAgBXfUACAAAN/AIAABJuA
Date: Wed, 27 Oct 2021 09:41:14 +0000
Message-ID: <2b1e68c3-23c3-e10b-ff80-6c73bb09f17b@epam.com>
References: <20210930075223.860329-1-andr2000@gmail.com>
 <20210930075223.860329-2-andr2000@gmail.com>
 <YWa+4hsaOxuX4tWJ@MacBook-Air-de-Roger.local>
 <387d3729-b182-1aaf-870e-505e90141606@epam.com>
 <YXka3C3x2ixNyrFE@Air-de-Roger>
In-Reply-To: <YXka3C3x2ixNyrFE@Air-de-Roger>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 3ad14ea1-e467-4f4a-5357-08d9992deaef
x-ms-traffictypediagnostic: AM9PR03MB6882:
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <AM9PR03MB688296384571CA6E0037626EE7859@AM9PR03MB6882.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:4303;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 yyNDekY+uKWXPqVQa++Tw/gskVueVrtGVQhDRju+cDS+y2yoRifrrM42uBqSitZTDcwxFBtMtJ9hnCrKfqYLsYXOykj/BnTUSLVjl0o140Y1en9g24uBF8EoCSBzD1uhpQH3W5WzAn5phW4Tw6sEJteXZ873zW/yYFc8cEUxr+1tScVpM1aw1ezG64bzWwQvqS6mll6lHPkq3RlezUr+MLwOhovugZkMeC0QWn4nBSevkK+fQyX/ctLMP4jcV7ShDUGVgfs1GSdk5Z9Fjnj8zZ/5aKeIJRfeZJV7iu3VaH7w+yxt7mwVlh6kNTLSobSJaiqW5/T4TqRLz0M0cBvPLMRZY2G1G3iyfcn/Mrv4tnDR2iJCQjW1HvTM5JJcOvo29FZOHitTJcqcVNaDuX/jJIFqLhwfm9aBfsuCDcHa/RSB0Qh0Ai1ivbbW0icjaJrvY6/zK8OY7K06nXwrW/a5U2JMCzY4zCiNxo+RYL7LXHSOuiKaQCcg5YD3j6DNMeSp8WcgZ4wBKJr2IPJ6jYCSt5RlcKnM5CYQrSyaToPSEst54rwRrDWvrw1MWwkeRafV0I515vq8WzjjdR/8m8eQoYiYuaRdRU4RcJQEcDH58HG2W0ljUs0QYvJBs7cTBUOqpBfZi4YILxA58JtqjCFdzXD58I0GEK/jXp+RfRq695w3KTCFJYTZKe2hXwaF5EKlM/VxYkWlcBbLBrw8E/KNX2zjUvsGhwvZ4VOnXIxxwUaFYxVpUk/5ehYxhFavsnjJ
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(26005)(38100700002)(76116006)(86362001)(38070700005)(186003)(122000001)(91956017)(83380400001)(54906003)(6486002)(66476007)(31696002)(66556008)(5660300002)(31686004)(66446008)(6506007)(64756008)(6916009)(66946007)(107886003)(71200400001)(6512007)(316002)(36756003)(53546011)(4326008)(2616005)(2906002)(8676002)(8936002)(508600001)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?TWMxVDlMQUROalpnSFdKNWRkRGJPM0YyaDNodkFKWWtaTWdYTFhpMXJ4VFhR?=
 =?utf-8?B?TndZeTh5YjBNdDBkTFBVanJnckJVWFRpN0NWUWtVRXBSbzJCVktOQmdsazFH?=
 =?utf-8?B?c1cra01nWTNGbi9WTzI0ay84WTB3Y2hWbS9meW1wd3R2ZkxiMkFpalhTWVpz?=
 =?utf-8?B?M09CY2dYbm45OEpjVEN0SXBZcjRsN1FUbTJpMEdRWlpicm91RVBVUFJqUm91?=
 =?utf-8?B?Z3M5VVdNL1VwclJHb1RwMWdqV0E5YjdoZkw1b3A5OVBSTHdsZUdDTnpUOHo2?=
 =?utf-8?B?Unl3NWt5MERjNnVKdm5RVDRnYXFpM3lJZXVxdUVVWVl5L2ZPVEI2K1YzTFo1?=
 =?utf-8?B?cWY3ZzRaZGtEMXYvbzZ0ZENXaUJLcm5lYjBUakQ2RGY3eTFIZ1pCVGNIeGRE?=
 =?utf-8?B?bFhSeUUwakd2dHJ2eHhCUytSdEhjTDRjVWRPOEFOeCt2dkhLaUtCcmdFSEJT?=
 =?utf-8?B?Yzc2WHBSTXJKMGJhOXNKZGFTY2x0aDdLRkhGOXpudnlzQ1ozeVdwUjBrTXZm?=
 =?utf-8?B?QTZ1SDRETVBLZ3ExVUpGU04rN3RiYkhkZSsvNngzU0hxcWFHc0VDQkZxN0Ey?=
 =?utf-8?B?LytuOHRveUlPV0tsNjZhditHbmIyaHBjUUI3K0hRRWtiN3d1RC9VY3B3RFhl?=
 =?utf-8?B?OXpHRUx6UDdicVR2d2xPY1ZjNHhaQXBhRlJZd3B5bkovd0tjbEhGSENhbzhZ?=
 =?utf-8?B?OUxrM2thWFR5RFRhUlVJMFdlNkNHOXlicEpTaVp2N0x0M1Y1WklFUndYOUxQ?=
 =?utf-8?B?Mm9sNzYzay9lOFlVK2tYQzRoUTU3ZzFQaFN2T2xFN1ZHaGxlbHNHUGF0N25a?=
 =?utf-8?B?Qjg2eFlNQlpJUHFnakRpNWF3b2dpM1NYNmszMEFYcWlGWVgwamNsOEpCeS9y?=
 =?utf-8?B?bUlxU0k0RGRXQVRwRzlsU3JLMy81K1NHVktIZ2JsY3l2VVhxdjlTY2sxQXlL?=
 =?utf-8?B?L0pqaGo2Y3luVThDY0FVYVFkWU5mSGo4Y3BzOXA1d2RNaXhVQ25ZU1JyYWNC?=
 =?utf-8?B?ZzV5RUZ0ekpvbEpVaEdRRGs2L2VKc3F1QzZXbFByYWsvVWYva2Z1OGttWUU2?=
 =?utf-8?B?TExoQjJwVXplNkI3dkdvWVN2Vk9Oc3NkbG0vMWZ0N0tYZi91b3F2YzU2WEpQ?=
 =?utf-8?B?ZERqaXkyYkE0NW02TzlUNkVVaXl1OGRUcmUxbllhL2JDaW12VUpDZ21maGIv?=
 =?utf-8?B?VldpV2VYMnFzRFNJcFFYYkgwQllmZ1lVYzMybXlzajdvT2JNWDhud3pDcWxj?=
 =?utf-8?B?alRvWnZsSXBkWkZPdG5FTmdxU29OWTZZY1BWMXpDUUowZWtKNU5mOFFlV3pZ?=
 =?utf-8?B?S3pESjZPTFAzeE9RMy8wUnJFMjVUaVNxb0JubWhlMHdLZWJKOVpqbHNBdSt1?=
 =?utf-8?B?emZ2bDU1S2N1ZEdkcy9rQi8rSHpHREJYbDZhSi9tRHJDNVV5WERycGpFOFpl?=
 =?utf-8?B?Zm80MDR2OTk5MVliK3FnK0J4TlNWWHhadnJrelFRK0xPazJ5TUdzejh4UHV4?=
 =?utf-8?B?U09Xd3UwQzJmSi90M1NndnYxS3dIb093QVBkTWsyV2diS1pRdzFPb3UvV1JW?=
 =?utf-8?B?Zi9YdkI0L2dpVVZ3WDZuNTVjUWxFMDJqTnlXTXo4YWNLS3JabVRVdVJGSnhu?=
 =?utf-8?B?SFNJajhZeGZMVVhZdWVrQnQvUmxvdE9hSUE3YWJxaFM0a1QzU0JxK0ZmMVl2?=
 =?utf-8?B?dHNUamNXRzgyOWRiNFFNRGFSMFVycnQraHdFZXlJT0R2UjBNR0tKbUhyc1Z2?=
 =?utf-8?B?ZGo5WnhpYnBzV0l5bjhMQWxQSzRhcW9vT1N5L0pERHVGaFdrMTdnTlh3OEpz?=
 =?utf-8?B?UXZ0a1BDajZGOG5Ebis1eDljZ2xSTDk4YjJhWHRtOXlJejNDcG9mWm1yZCtT?=
 =?utf-8?B?eFkybDVKc2l3T0tPaVJ3RFRMc1BoeVplY0JQZ09RSmtYVVBXeGV2WXh6NDFK?=
 =?utf-8?B?b0w3RGRUQ1B4S0Q4ZUxqWG92VEZ3bTNUNVdTOGt5Wmkvb1BHbnhCTTZnRFIx?=
 =?utf-8?B?dGQxUXFiY1FUd2UycGJ2NDFvOHJFRGU0QkJ0YkErWVUzV2dkUFBOS25RaDRB?=
 =?utf-8?B?MCt6bVNnNnZqN2Z4VWZYbnlBTXd3QVpjYXdvQVRuN2JEeW1Bak0vOGd1WnZp?=
 =?utf-8?B?cTgyNTFBY3VoMGRadFNra1NNU2ZpREk3OHU1Z0JLYkJNZ3RjU2dpaFFyM0g3?=
 =?utf-8?B?TFlQQS9JL3NpelN6WUtGTkZIbzNEMm83eDVTaHZERWZ4anhWQXFFNit1ZkVX?=
 =?utf-8?B?T3d2MlZ0VWVEeFNoRkl1VFEzc2s0Q2xLMGlMNnExTGtPK08zUEVLVDhMa05j?=
 =?utf-8?B?OERzOFNHaW0rTzIwaHQ4VVN5T0NueFBIZGx0QWkvMmhxK0t6L3FEQT09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <A6C5D9F62C1B9E43B1C3FC198021AE03@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3ad14ea1-e467-4f4a-5357-08d9992deaef
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Oct 2021 09:41:14.2143
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 2wDQriuI2hWl/NyMNpiAnXiLy5Jd6ZYsa39TplW6W2wYaDa7GApnJDJtTT0AwHn8OkWiJdFRpHEspwZjTjDlTgeklNCh6RK+bXktRe+MEalurX8CYDwOwCbKO151hJ0Q
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR03MB6882
X-Proofpoint-ORIG-GUID: JP9W_BaJN9LpeWIVd_T0SgKJqfcOrkZV
X-Proofpoint-GUID: JP9W_BaJN9LpeWIVd_T0SgKJqfcOrkZV
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475
 definitions=2021-10-27_03,2021-10-26_01,2020-04-07_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 impostorscore=0
 mlxlogscore=922 bulkscore=0 spamscore=0 priorityscore=1501 malwarescore=0
 adultscore=0 lowpriorityscore=0 clxscore=1015 mlxscore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2110270058

DQoNCk9uIDI3LjEwLjIxIDEyOjI0LCBSb2dlciBQYXUgTW9ubsOpIHdyb3RlOg0KPiBPbiBXZWQs
IE9jdCAyNywgMjAyMSBhdCAwOToxMjoxNEFNICswMDAwLCBPbGVrc2FuZHIgQW5kcnVzaGNoZW5r
byB3cm90ZToNCj4+IEhpLCBSb2dlciENCj4+DQo+PiBPbiAxMy4xMC4yMSAxNDoxMSwgUm9nZXIg
UGF1IE1vbm7DqSB3cm90ZToNCj4+PiBPbiBUaHUsIFNlcCAzMCwgMjAyMSBhdCAxMDo1MjoxM0FN
ICswMzAwLCBPbGVrc2FuZHIgQW5kcnVzaGNoZW5rbyB3cm90ZToNCj4+Pj4gRnJvbTogT2xla3Nh
bmRyIEFuZHJ1c2hjaGVua28gPG9sZWtzYW5kcl9hbmRydXNoY2hlbmtvQGVwYW0uY29tPg0KPj4+
Pg0KPj4+PiBUaGlzIGlzIGluIHByZXBhcmF0aW9uIGZvciBkeW5hbWljIGFzc2lnbm1lbnQgb2Yg
dGhlIHZwY2kgcmVnaXN0ZXINCj4+Pj4gaGFuZGxlcnMgZGVwZW5kaW5nIG9uIHRoZSBkb21haW46
IGh3ZG9tIG9yIGd1ZXN0Lg0KPj4+Pg0KPj4+PiBTaWduZWQtb2ZmLWJ5OiBPbGVrc2FuZHIgQW5k
cnVzaGNoZW5rbyA8b2xla3NhbmRyX2FuZHJ1c2hjaGVua29AZXBhbS5jb20+DQo+Pj4+IFJldmll
d2VkLWJ5OiBNaWNoYWwgT3J6ZWwgPG1pY2hhbC5vcnplbEBhcm0uY29tPg0KPj4+PiAtLS0NCj4+
Pj4gU2luY2UgdjE6DQo+Pj4+ICAgIC0gY29uc3RpZnkgc3RydWN0IHBjaV9kZXYgd2hlcmUgcG9z
c2libGUNCj4+Pj4gLS0tDQo+Pj4+ICAgIHhlbi9kcml2ZXJzL3ZwY2kvdnBjaS5jIHwgNyArKysr
KystDQo+Pj4+ICAgIHhlbi9pbmNsdWRlL3hlbi92cGNpLmggIHwgMiArKw0KPj4+PiAgICAyIGZp
bGVzIGNoYW5nZWQsIDggaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQ0KPj4+Pg0KPj4+PiBk
aWZmIC0tZ2l0IGEveGVuL2RyaXZlcnMvdnBjaS92cGNpLmMgYi94ZW4vZHJpdmVycy92cGNpL3Zw
Y2kuYw0KPj4+PiBpbmRleCBjYmQxYmFjN2ZjMzMuLjE2NjY0MDJkNTViOCAxMDA2NDQNCj4+Pj4g
LS0tIGEveGVuL2RyaXZlcnMvdnBjaS92cGNpLmMNCj4+Pj4gKysrIGIveGVuL2RyaXZlcnMvdnBj
aS92cGNpLmMNCj4+Pj4gQEAgLTM1LDcgKzM1LDcgQEAgZXh0ZXJuIHZwY2lfcmVnaXN0ZXJfaW5p
dF90ICpjb25zdCBfX3N0YXJ0X3ZwY2lfYXJyYXlbXTsNCj4+Pj4gICAgZXh0ZXJuIHZwY2lfcmVn
aXN0ZXJfaW5pdF90ICpjb25zdCBfX2VuZF92cGNpX2FycmF5W107DQo+Pj4+ICAgICNkZWZpbmUg
TlVNX1ZQQ0lfSU5JVCAoX19lbmRfdnBjaV9hcnJheSAtIF9fc3RhcnRfdnBjaV9hcnJheSkNCj4+
Pj4gICAgDQo+Pj4+IC12b2lkIHZwY2lfcmVtb3ZlX2RldmljZShzdHJ1Y3QgcGNpX2RldiAqcGRl
dikNCj4+Pj4gK3ZvaWQgdnBjaV9yZW1vdmVfZGV2aWNlX3JlZ2lzdGVycyhjb25zdCBzdHJ1Y3Qg
cGNpX2RldiAqcGRldikNCj4+PiBNYWtpbmcgdGhpcyBjb25zdCBpcyBraW5kIG9mIG1pc2xlYWRp
bmcsIGFzIHlvdSBlbmQgdXAgbW9kaWZ5aW5nDQo+Pj4gY29udGVudHMgb2YgdGhlIHBkZXYsIGlz
IGp1c3QgdGhhdCB2cGNpIGRhdGEgaXMgc3RvcmVkIGFzIGEgcG9pbnRlcg0KPj4+IGluc2lkZSB0
aGUgc3RydWN0IHNvIHlvdSBhdm9pZCB0aGUgZWZmZWN0cyBvZiB0aGUgY29uc3RpZmljYXRpb24u
DQo+PiBPaywgSSB3aWxsIHJlbW92ZSBjb25zdA0KPiBKYW4gcHJlZmVycyB0aGUgY29uc3QsIHNv
IHBsZWFzZSBsZWF2ZSBpdC4NCk9vb29rICkNCj4NCj4gVGhhbmtzLCBSb2dlci4NCj4NCg==


From xen-devel-bounces@lists.xenproject.org Wed Oct 27 09:46:19 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Oct 2021 09:46:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.216801.376537 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mffVc-0008WL-S5; Wed, 27 Oct 2021 09:46:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 216801.376537; Wed, 27 Oct 2021 09:46:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mffVc-0008WE-P0; Wed, 27 Oct 2021 09:46:12 +0000
Received: by outflank-mailman (input) for mailman id 216801;
 Wed, 27 Oct 2021 09:46:12 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=8lYk=PP=epam.com=prvs=0934bd4bd6=oleksandr_andrushchenko@srs-us1.protection.inumbo.net>)
 id 1mffVb-0008W8-Vs
 for xen-devel@lists.xenproject.org; Wed, 27 Oct 2021 09:46:12 +0000
Received: from mx0a-0039f301.pphosted.com (unknown [148.163.133.242])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id b6cb3706-a78a-42dc-8098-e8b79ca7aa71;
 Wed, 27 Oct 2021 09:46:11 +0000 (UTC)
Received: from pps.filterd (m0174676.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 19R9SilI027539; 
 Wed, 27 Oct 2021 09:46:09 GMT
Received: from eur05-vi1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2172.outbound.protection.outlook.com [104.47.17.172])
 by mx0a-0039f301.pphosted.com with ESMTP id 3by2x9rfbf-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Wed, 27 Oct 2021 09:46:09 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by AM0PR03MB4308.eurprd03.prod.outlook.com (2603:10a6:208:ce::25)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.14; Wed, 27 Oct
 2021 09:46:06 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::c038:e032:595a:651]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::c038:e032:595a:651%9]) with mapi id 15.20.4649.014; Wed, 27 Oct 2021
 09:46:06 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b6cb3706-a78a-42dc-8098-e8b79ca7aa71
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=hW76mk+6I5xpfyvC+8t8ICHgWvUuctkINpzoUM9dAJvQTban+KU2fl8vjQcyxb9aF1bxDLlE0eDVHRbAd8N8qSMwJY/2yZn39//4hYRGIJJ0dot4KimhNz5rHSX/sJa1YtoENzDzRomNqolwa33fFL/D3O9peQO8p+kdOU1xzpO8DB8UrjWvPxyKoXjF8IwNitk+EUmDuVP/eAe+N+sXbSwifADHVLC0kveQ5gJe8j/9vqo0VnN8MdqhvihiomZlu8pmzPeJ82HfAfRYziuL7Ysfqqx40yeHrPCuUMPbXK+sKbqZc9dn9OcaLOaOZ11DvMwMpN9PBUkmz7lrH7iZmw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=rWcTn89i7Mn/dAYxkBX410tb9WadxnadmchSVN5TjUY=;
 b=KNdY9wkWxPHLUeY3VUfDbW7cX6OAYsOFtnvO3NgxbzsA7r5S3Fp0RTEyipwx3Uu2+JiKwr68GbiSOEiUiPj7TqipUUdHBNkGXRvHetBS3xuoFdSsBH/0fL0pAnK+eYd2nz/b6WfgdNdjuVeloht+SVBbDS4zzX7XhASnJjkW7yxZBHyD03vafNCdOhyoq9A0THF+aVijDEKukrivigS4AAZSg0Rxv2lp4CaknzWTYgryYBahQcgYi0LmMACthqZcxKZVz0dICrF01eux8HAPsDOFUAxBedoYqGBL9QujVpSyIJU5NNoO6cHToS1AJ2aOMT7daYJPByQcKfBHjKpBDw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=rWcTn89i7Mn/dAYxkBX410tb9WadxnadmchSVN5TjUY=;
 b=PQn0h63sJfTRmkc2Ov2zWLm/m7mHOjm3oa8Psg/pkaJnkjEJLidmOHRAHTMvkPPfWHP0ydDo9GmMS7OoX5d4DUdnbOuX+5Vj6x+Z/wB1PnIo+OJmt4FPbeaaT3d7a0EX0Hoq4gdF/X2tgkF7S/UGKNeaWrszfkN8W5FmS7c3JJZTSMBe7odieQzGPB5G3lh7/iQ3O+u463vDVsBocs7lu5RE7nUoKC6zQdhkEe/ykpk5CamhXJjGE3mBzd+8XJAG0UnGJapEqqNFZe/tsjbgyTrt3wenHubxmF7MxKSmQjzmAA/YfhxWW2fhh4oKZJwz/LzhnpRMZMU6NKfMto4f+A==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org"
	<sstabellini@kernel.org>,
        "iwj@xenproject.org" <iwj@xenproject.org>,
        Bertrand
 Marquis <bertrand.marquis@arm.com>,
        Rahul Singh <rahul.singh@arm.com>,
        Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH] xen/arm: fix SBDF calculation for vPCI MMIO handlers
Thread-Topic: [PATCH] xen/arm: fix SBDF calculation for vPCI MMIO handlers
Thread-Index: AQHXyww6rKHs3LJru0q52eLUia+oNavmi9YAgAABaACAAAVYAIAABjyA
Date: Wed, 27 Oct 2021 09:46:06 +0000
Message-ID: <19e92d29-d3dd-06dc-5a1c-15ee33a106de@epam.com>
References: <20211027082533.1406015-1-andr2000@gmail.com>
 <YXkU+DKYmvwo+kak@Air-de-Roger>
 <0bbe4d1d-421d-e816-42aa-f43581902a02@epam.com>
 <YXkaov2E5CdWRjlr@Air-de-Roger>
In-Reply-To: <YXkaov2E5CdWRjlr@Air-de-Roger>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 88d3dc0d-9e73-4db5-049f-08d9992e98ee
x-ms-traffictypediagnostic: AM0PR03MB4308:
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <AM0PR03MB4308110CAFD67BC16C284B73E7859@AM0PR03MB4308.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 mCJfdVkXRWtzLssbHtdd+2UXkta/sgEguJ0u8+PDsWS012ymoQ0qoyu3almkoDYn3yz+skQcx8CKNqrhgICs9ivd30Xqo/49qGIYroZQmPwgkWDpJminK+vbW3Ds1iSdvG8XB9+CZBZvcYs/nHmp/q7j6UOPCcj4aJRPLoGzUQ5HfllSoiCpu0IqDlky+6kh6K+xQ6RoAkXJCzZQFmsAGKhNEcjODsP9Gjq/w2m8sTtUPq3QLXgwYG+U8K9VxjsaxXH2CpVKYdRjTffAXTb2+ts9zaT1aUl7pR8krtyr4ooIYVDIh6QdAWXfVZk+TcxNdARqtHeKcceXkvnrEqp8X6aPeSQOQJfaA7e+u4WdGFyGFGRYS0JUFS4qT6bh2GqIMozkr89gbD50k8kDHR3kluDMKTCxIeLTntFjZsCFgNJty24gsA77+8gzB4Msknpk+Rz1eigqRE9872NJTXSuVfo5Y4HEx+06iHVfDrxq2MdQ57zXojpA6ASnwwappzgQcH8rac0MewNuei0L0B7fb9GbNuRmr9FK0HGTbaw8ksbU4axinFBcU6Qo3i243eYt7vsVDcoYgUvx+UqBIhWFqwNhv7MbmYww+QGhxCFz4piOBxUo/jlNFZl/xzSJjuyKu/TbFyGcFpFXcUQ1othsEsI6PHPMQjlcbaFyNmlg5UZriugGWMNqore79vrhCEyQR3ls8ZMqtteZm4PijsPP+7j2ouw62QtCYoYTOAMHEFgmV/7ajOuYf0Jv2mqKH2t/
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(8936002)(6506007)(53546011)(38070700005)(2616005)(6916009)(31696002)(31686004)(76116006)(91956017)(86362001)(26005)(6486002)(71200400001)(66946007)(64756008)(38100700002)(66446008)(186003)(4326008)(8676002)(83380400001)(2906002)(5660300002)(54906003)(107886003)(508600001)(6512007)(122000001)(66476007)(66556008)(316002)(36756003)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?eEdlQWtIcTgxWGpZczhySTJKN2lUVFhOZ3FDYWJBVlpZeEVSOXpkSzh3dW1Y?=
 =?utf-8?B?N2V4V3phYWNTdUVkU0hMSjB1dGFnOHlUUm1GdHFLN3dWVzlRbVdCbGVKbzFw?=
 =?utf-8?B?cG52UjZ0bElmbDhwSHNabEFEZkhabnl6ZWY2ZGFNUGZ1QlQrSCtjcVJHYmdr?=
 =?utf-8?B?dEs3UVN0SXUwV2l4OEhPMzcvaWdXT3hTR1pzcVdGYjVhYzNnR3dnQkovR2Vl?=
 =?utf-8?B?M2l3MTZqcXFWQUgwZkloSEo1NFMvSUhRNWtsMEpOSlptdHVBcFVBZDRJdzR4?=
 =?utf-8?B?WXkwT2lSd0xieXRyYWZUdUZtdjVvRzhwSlFNVDJWMVpSNzh4T3JUZGdGejBn?=
 =?utf-8?B?T2ZNUlJ0YThRZVJNMTNhaGhzaTd1NGQ1L05qRCtvZnJRS0Mra3gzVHVXWkxM?=
 =?utf-8?B?S2pncmZCd2REK2JSeEhXd1dpQVFabVdjOW94UjAxVWh6SkxlNVFma1A3REM5?=
 =?utf-8?B?VFJKOHJEMVZnZkJlVXU4cGlDMXY3cklsZjVZSGlwOUlQMEJCS2JqSUtlZUhr?=
 =?utf-8?B?Rkwxcmp3bnVXVlBtMWk2c1ZLY3NwTnFoSFBjTGVZQ0ZzZVB4anpQcUpON1Bs?=
 =?utf-8?B?NG9yeUVkbnlUNVRYTEcwZzB3K2VMcHNwalJYSGZTVko2TWQ2cm9SL3BoMXdi?=
 =?utf-8?B?Zk00TGc0cHNZSENHYjV1WVhnNFhHWi9rMVFrRGgreUFWRW1wL0dZK241SkVl?=
 =?utf-8?B?SEI0akxweDZMdmFWanphMitiZmVYbkl2a2p1MzBxL09TMVNvR01jb0lSQk9s?=
 =?utf-8?B?cS82NGZOMjIybzJHQ2grZ3hnOU5sc0pIeTd0cU03M2I2aENhbFJEYVF4aW9Q?=
 =?utf-8?B?SVhiWFFiWmFtS2YxN2tnS3g3bmJyNXlVbDE4M3dzSFpZdTdEYjFOaVJOZVhh?=
 =?utf-8?B?NzdqT0lGelV1ak1LZjJzbDFzeVlCQUVDVitzL09QZ0diRm1IOU83QlJ4RGUz?=
 =?utf-8?B?U3pudENCMDJPRUtzNGFKbThBN2FHd2h2SDdCRStUYmJGbTloMjBpa2pWTmtQ?=
 =?utf-8?B?UEV5YTZ0R1M1OWlWY0F1ZFVSeFkvQjltVmEzRFdsTkxUYWpNYy9HU0ZiQjdw?=
 =?utf-8?B?SUNLVTltbjdPdnYwWWNuVWU5Y2FvUjZHOUh2SnJqV3JINmhheXA3a05Vb3gr?=
 =?utf-8?B?czFHb29wMmdnbjRtNGVEODhWZUZORzR0dFM4c0FTd015NlhtME1wNjk2TUtI?=
 =?utf-8?B?SUs4cEZid2JvMVJFeGI2NlNCNVJ1RDE3NVRLc01qRHZvN293cHRqTk1PNWJi?=
 =?utf-8?B?YzRXajVucW0zelliT240YUdHUi84SDlINU9icTBLMmJwcHJvREZhSHRlWWc4?=
 =?utf-8?B?bUE3OTdrS1lqMmpuSVk2U25vbHlESXczYklPMEhSLzA2M3ZKeHh0RjZacWpX?=
 =?utf-8?B?Y2dLVjJVNVByMUkxeE5ubWJtYjlhVEI4ZTQySjZraDNrQlNKVm1zM1lpYUxs?=
 =?utf-8?B?NDhrbDlKckU0czU1NEpHTStmUmJmNGFUL3FQbWZaNGpDMWNBbmR3eVlXYmxB?=
 =?utf-8?B?U0lXeEZWZFJEaUNncjdaa09OdmgzMmV3bWdmYVhiVE5LWVZYYjVGbjVqYnlY?=
 =?utf-8?B?d0taVUx0elpJTDhkdWswNEp0eUVzVm1xUmd2VzRPbTdOQ2U1eCtvT25nSG1l?=
 =?utf-8?B?ZzIxNEYxa0UzRUdOT0d2NUZiWmtiL3lZeXlNUmdZSzRBelhjSUpCQ2dVNHlu?=
 =?utf-8?B?K05QU3ZMK2xTOXlKSnNqK2RSVW5DUVdVMjhJczQ1dC8zajRtVUNzT1p5L0RP?=
 =?utf-8?B?eUMybTU4bE5GWnYyTXU4RFBIVi9HcHJ0eFNldGpFcjlkSXcvWVFFa3E4aXpL?=
 =?utf-8?B?Z2J6Mng0czV0YThpK2hMT0V4ZjdyNHhKNktZak9ibTFpNU5ocklOMWNIQnZJ?=
 =?utf-8?B?NTlhS1BSREFlWGFkWjA1RGFpRjRmWG8zbWhPZklrQkxxQUI3Qzk0V3ZOVXFs?=
 =?utf-8?B?UnFjRVRHUHY2dUxGNng0K2hXdW5nSm45U2JlNXpLeXliWmxqRFF3ek0rNG56?=
 =?utf-8?B?UjZZMkxVL09MbWdzN1FjYXc1V0piUS9JNk81Q3pjTTY5ZEVuZUJCdWRWYnlw?=
 =?utf-8?B?cU5PT2R5ODliR090RVFZcnZUbnNLZkhXa2xXK0FwN1g5NWE4V24yL2loMlZp?=
 =?utf-8?B?Q1hnNkFWck1ha2dsL2NpSDdsbUh1OE80akp3bzlPcGk4dWs0V2tzR0NTR08r?=
 =?utf-8?B?M0VSc0d5YkhHTWFMdFFNMUhCRVEzTldSSGZneUZmQTI2MTVpT2owYUVCeW1P?=
 =?utf-8?B?M0JKa3pDR0FEWit0WHRENzRBdDVnUFNLeEZKSnlYbGI1eVZpS2txR2hGNXJm?=
 =?utf-8?B?NERBOHgvUWtucDczUWROanBsRm43a2RRemJlQklsdnZKTUVQRld5Zz09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <E9E8834A3ED9F94A87B25A35D2478D0F@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 88d3dc0d-9e73-4db5-049f-08d9992e98ee
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Oct 2021 09:46:06.1483
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: LwTXRxE66/bBGPg8SNx883CrSqiRqfKuNYY1GPvFdKSQZjWaptl4SjKAsoD72ias8o1qYSy/J9tHl3XRrZzT3M+yuOYNkUdYqzsInXcx+4qBPHYDrM592MUq4wzmqAj3
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR03MB4308
X-Proofpoint-ORIG-GUID: Cl-4K7mzVEJKkwRQ_JSeP01N6xBuRtaK
X-Proofpoint-GUID: Cl-4K7mzVEJKkwRQ_JSeP01N6xBuRtaK
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475
 definitions=2021-10-27_03,2021-10-26_01,2020-04-07_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 clxscore=1015
 lowpriorityscore=0 phishscore=0 malwarescore=0 priorityscore=1501
 bulkscore=0 mlxscore=0 mlxlogscore=999 impostorscore=0 spamscore=0
 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2110270059

DQoNCk9uIDI3LjEwLjIxIDEyOjIzLCBSb2dlciBQYXUgTW9ubsOpIHdyb3RlOg0KPiBPbiBXZWQs
IE9jdCAyNywgMjAyMSBhdCAwOTowNDozOUFNICswMDAwLCBPbGVrc2FuZHIgQW5kcnVzaGNoZW5r
byB3cm90ZToNCj4+IEhpLCBSb2dlciENCj4+DQo+PiBPbiAyNy4xMC4yMSAxMTo1OSwgUm9nZXIg
UGF1IE1vbm7DqSB3cm90ZToNCj4+PiBPbiBXZWQsIE9jdCAyNywgMjAyMSBhdCAxMToyNTozM0FN
ICswMzAwLCBPbGVrc2FuZHIgQW5kcnVzaGNoZW5rbyB3cm90ZToNCj4+Pj4gRnJvbTogT2xla3Nh
bmRyIEFuZHJ1c2hjaGVua28gPG9sZWtzYW5kcl9hbmRydXNoY2hlbmtvQGVwYW0uY29tPg0KPj4+
Pg0KPj4+PiBXaGlsZSBpbiB2UENJIE1NSU8gdHJhcCBoYW5kbGVycyBmb3IgdGhlIGd1ZXN0IFBD
SSBob3N0IGJyaWRnZSBpdCBpcyBub3QNCj4+Pj4gZW5vdWdoIGZvciBTQkRGIHRyYW5zbGF0aW9u
IHRvIHNpbXBseSBjYWxsIFZQQ0lfRUNBTV9CREYoaW5mby0+Z3BhKSBhcw0KPj4+PiB0aGUgYmFz
ZSBhZGRyZXNzIG1heSBub3QgYmUgYWxpZ25lZCBpbiB0aGUgd2F5IHRoYXQgdGhlIHRyYW5zbGF0
aW9uDQo+Pj4+IGFsd2F5cyB3b3JrLg0KPj4+IEkgdGhpbmsgSSd2ZSBhbHJlYWR5IHJhaXNlZCB0
aGlzIGR1cmluZyByZXZpZXcgWzBdLiBCdXQgdGhpcyBpcyBvbmx5IGENCj4+PiBwcm9ibGVtIGlm
IHlvdSBjaGFuZ2UgdGhlIGN1cnJlbnQgdmFsdWUgb2YgR1VFU1RfVlBDSV9FQ0FNX0JBU0UNCj4+
PiBBRkFJQ1QsIGFzIHRoZSBjdXJyZW50IHZhbHVlIGhhcyBiaXRzIFswLDI3XSBjbGVhci4NCj4+
IEV4YWN0bHksIHNvIHdlIHdlcmUganVzdCBsdWNreSBub3QgdG8gaGl0IHRoaXMgYmVmb3JlDQo+
Pj4gSSBhc3N1bWUgdGhpcyBpcyBhIHByb2JsZW0gZm9yIHRoZSBoYXJkd2FyZSBkb21haW4gdGhh
dCBuZWVkcyB0byB0cmFwDQo+Pj4gcmFuZG9tIGJhc2UgYWRkcmVzc2VzIGFzIHByZXNlbnQgb24g
aGFyZHdhcmUsIGJ1dCB0aGF0IGNvZGUgaGFzbid0DQo+Pj4gYmVlbiBjb21taXR0ZWQgeWV0Lg0K
Pj4gWWVzLCBJIGFtIGZhY2luZyB0aGlzIG9uIHRoZSByZWFsIEhXIHdoZW4gRG9tMCdzIGFjY2Vz
cyBpcyB0cmFwcGVkDQo+PiBhbmQgdGhlIGJhc2UgaXMgbm90IHRha2VuIGludG8gYWNjb3VudC4g
U28sIEkgaGF2ZSBhIHBhdGNoIGZvciB0aGUNCj4+IGZ1dHVyZSB1cHN0cmVhbSB3aGljaCBzdWJ0
cmFjdHMgdGhlIHJlbGV2YW50IGJhc2UgZnJvbSB0aGUgZ3BhLA0KPj4gZS5nLiBlaXRoZXIgR1VF
U1RfVlBDSV9FQ0FNX0JBU0Ugb3IgYnJpZGdlLT5jZmctPnBoeXNfYWRkcg0KPj4+IElmIHRoYXQn
cyBpbmRlZWQgdGhlIGNhc2UsIHBsZWFzZSBleHBhbmQgdGhlIGNvbW1pdCBtZXNzYWdlIHRvIGNv
bnRhaW4NCj4+PiB0aGlzIGluZm9ybWF0aW9uLg0KPj4gSSBjYW4gb25seSBtZW50aW9uIGFib3V0
ICJ0aGUgY3VycmVudCB2YWx1ZSBvZiBHVUVTVF9WUENJX0VDQU1fQkFTRQ0KPj4gQUZBSUNULCBh
cyB0aGUgY3VycmVudCB2YWx1ZSBoYXMgYml0cyBbMCwyN10gY2xlYXIiIGFzIG9mIG5vdyBiZWNh
dXNlDQo+PiBEb20wIHRyYXBzIGFyZSBub3QgeWV0IHRoZXJlLg0KPiBJbmRlZWQsIEkgd291bGQg
cmF0aGVyIG1lbnRpb24gYm90aCBjYXNlcywgaWU6DQo+DQo+ICJUaGlzIGNoYW5nZSBpcyBub3Qg
c3RyaWN0bHkgcmVxdWlyZWQgZ2l2ZW4gdGhlIGN1cnJlbnQgdmFsdWUgb2YNCj4gR1VFU1RfVlBD
SV9FQ0FNX0JBU0Ugd2hpY2ggaGFzIGJpdHMgMCB0byAyNyBjbGVhciwgYnV0IGNvdWxkIGNhdXNl
DQo+IGlzc3VlcyBpZiBzdWNoIHZhbHVlIGlzIGNoYW5nZWQsIG9yIHdoZW4gaGFuZGxlcnMgZm9y
IGRvbTAgRUNBTQ0KPiByZWdpb25zIGFyZSBhZGRlZCBhcyB0aG9zZSB3aWxsIGJlIG1hcHBlZCBv
dmVyIGV4aXN0aW5nIGhhcmR3YXJlDQo+IHJlZ2lvbnMgdGhhdCBjb3VsZCB1c2Ugbm9uLWFsaWdu
ZWQgYmFzZSBhZGRyZXNzZXMuIg0KU291bmRzIGdvb2QsIHdpbGwgYWRkDQo+DQo+IFJlZ2FyZHMs
IFJvZ2VyLg0KVGhhbmsgeW91LA0KT2xla3NhbmRy


From xen-devel-bounces@lists.xenproject.org Wed Oct 27 09:49:53 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Oct 2021 09:49:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.216811.376548 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mffZ3-0000p7-F2; Wed, 27 Oct 2021 09:49:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 216811.376548; Wed, 27 Oct 2021 09:49:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mffZ3-0000p0-C8; Wed, 27 Oct 2021 09:49:45 +0000
Received: by outflank-mailman (input) for mailman id 216811;
 Wed, 27 Oct 2021 09:49:44 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mffZ2-0000ou-7c
 for xen-devel@lists.xenproject.org; Wed, 27 Oct 2021 09:49:44 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mffZ2-0000Iz-2z
 for xen-devel@lists.xenproject.org; Wed, 27 Oct 2021 09:49:44 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mffZ2-0007Zj-0Z
 for xen-devel@lists.xenproject.org; Wed, 27 Oct 2021 09:49:44 +0000
Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89)
 (envelope-from <iwj@xenproject.org>)
 id 1mffYy-000740-5u; Wed, 27 Oct 2021 10:49:40 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date
	:Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From;
	bh=lKNn9nVcf2yNauEfyMR2FCQ4Wfr9soC5sSBQNxOgQj8=; b=q7B/H4zVrZMILwzMiXvJ1xxevM
	4wv0mfN5JNzn4IMIhCDszJkcziXgHAb0D1GFNHXriecPenUEaao6LV1Vu7yO9b5Ypxbx2Z6FIr+p/
	bPDZ+gCBfssln/nWkN0q6dNU/jTTGNc1ZI4JlqpAqDV+9Hdce8y9iSOl4jYLYZgoi7g4=;
From: Ian Jackson <iwj@xenproject.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
Message-ID: <24953.8371.554610.857382@mariner.uk.xensource.com>
Date: Wed, 27 Oct 2021 10:49:39 +0100
To: Roger Pau Monne <roger.pau@citrix.com>
Cc: <xen-devel@lists.xenproject.org>,
    Jan Beulich <jbeulich@suse.com>,
    Andrew Cooper <andrew.cooper3@citrix.com>,
    Wei Liu <wl@xen.org>
Subject: Re: [PATCH] x86/hpet: setup HPET even when disabled due to stopping in deep C states
Newsgroups: chiark.mail.xen.devel
In-Reply-To: <20211026151233.57246-1-roger.pau@citrix.com>
References: <68352fc1-9ba0-1081-be50-065b212f96a3@citrix.com>
	<20211026151233.57246-1-roger.pau@citrix.com>
X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu)

Roger Pau Monne writes ("[PATCH] x86/hpet: setup HPET even when disabled due to stopping in deep C states"):
> Always allow the HPET to be setup, but don't report a frequency back
> to the platform time source probe in order to avoid it from being
> selected as a valid timer if it's not usable.
> 
> Doing the setup even when not intended to be used as a platform timer
> is required so that is can be used in legacy replacement mode in order
> to assert the IO-APIC is capable of receiving interrupts.
> 
> Fixes: c12731493a ('x86/hpet: Use another crystalball to evaluate HPET usability')
> Reported-by: Andrew Cooper <andrew.cooper3@citrix.com>
> Signed-off-by: Roger Pau Monn� <roger.pau@citrix.com>

Release-Acked-by: Ian Jackson <iwj@xenproject.org>


From xen-devel-bounces@lists.xenproject.org Wed Oct 27 09:49:56 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Oct 2021 09:49:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.216812.376559 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mffZD-00019b-NX; Wed, 27 Oct 2021 09:49:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 216812.376559; Wed, 27 Oct 2021 09:49:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mffZD-00019S-K3; Wed, 27 Oct 2021 09:49:55 +0000
Received: by outflank-mailman (input) for mailman id 216812;
 Wed, 27 Oct 2021 09:49:54 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mffZC-00018i-J2
 for xen-devel@lists.xenproject.org; Wed, 27 Oct 2021 09:49:54 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mffZC-0000JN-IH
 for xen-devel@lists.xenproject.org; Wed, 27 Oct 2021 09:49:54 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mffZC-0007bR-HX
 for xen-devel@lists.xenproject.org; Wed, 27 Oct 2021 09:49:54 +0000
Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89)
 (envelope-from <iwj@xenproject.org>)
 id 1mffZ7-00074M-Em; Wed, 27 Oct 2021 10:49:49 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date
	:Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From;
	bh=JxyqyvZQahu+SmFfOBf6TLjKBOYVW8BxtkDd7aW8iDQ=; b=PEz+322SgrqGTvF3Ea1ECw22di
	kAfug9VB4SAgJHZ36BIUYzVq3KdAxZhhXNnjJPpiGwv8c9cJyAtATVP1LSLgHnsvIRRGUid4xU2W8
	jA4hFc2xpVJOf2AV2RXfC+aIguvwe0f3V2zIAVMTHZ8CnG1cXe9him7k6jZYlL+AwQqk=;
From: Ian Jackson <iwj@xenproject.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
Message-ID: <24953.8381.24925.802466@mariner.uk.xensource.com>
Date: Wed, 27 Oct 2021 10:49:49 +0100
To: Roger Pau =?iso-8859-1?Q?Monn=E9?= <roger.pau@citrix.com>
Cc: Jan Beulich <jbeulich@suse.com>,
    "xen-devel\@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
    Andrew  Cooper <andrew.cooper3@citrix.com>,
    Wei Liu <wl@xen.org>
Subject: Re: [PATCH 2/2] x86: de-duplicate MONITOR/MWAIT CPUID-related
 definitions
Newsgroups: chiark.mail.xen.devel
In-Reply-To: <YW6tx43rw1SEo4fY@MacBook-Air-de-Roger.local>
References: <9963c7a2-f880-66fc-8f12-b1ddd0619c91@suse.com>
	<b809979b-5d43-482b-921b-65a4e203db2f@suse.com>
	<YW6tx43rw1SEo4fY@MacBook-Air-de-Roger.local>
X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu)

Roger Pau Monn� writes ("Re: [PATCH 2/2] x86: de-duplicate MONITOR/MWAIT CPUID-related definitions"):
> On Tue, Oct 19, 2021 at 09:08:22AM +0200, Jan Beulich wrote:
> > As of 724b55f48a6c ("x86: introduce MWAIT-based, ACPI-less CPU idle
> > driver") they (also) live in asm/mwait.h; no idea how I missed the
> > duplicates back at the time.
> > 
> > Signed-off-by: Jan Beulich <jbeulich@suse.com>
> 
> Acked-by: Roger Pau Monn� <roger.pau@citrix.com>

Release-Acked-by: Ian Jackson <iwj@xenproject.org>


From xen-devel-bounces@lists.xenproject.org Wed Oct 27 09:50:21 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Oct 2021 09:50:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.216820.376570 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mffZc-0002fJ-Vl; Wed, 27 Oct 2021 09:50:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 216820.376570; Wed, 27 Oct 2021 09:50:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mffZc-0002fC-Sl; Wed, 27 Oct 2021 09:50:20 +0000
Received: by outflank-mailman (input) for mailman id 216820;
 Wed, 27 Oct 2021 09:50:19 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5kU4=PP=linutronix.de=tglx@srs-us1.protection.inumbo.net>)
 id 1mffZb-0002et-5T
 for xen-devel@lists.xenproject.org; Wed, 27 Oct 2021 09:50:19 +0000
Received: from galois.linutronix.de (unknown [193.142.43.55])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 3a54ceac-a241-4598-8ce9-37dfa8ea536c;
 Wed, 27 Oct 2021 09:50:17 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3a54ceac-a241-4598-8ce9-37dfa8ea536c
From: Thomas Gleixner <tglx@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1635328216;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=R6HIFHpD6EcdYz7reZvQoCoHmuw7azptYwwiCQ/462A=;
	b=s5FI1XoOJnu3DWuAjQT9oMfvwzWnRyRjqgbREBvPHSIdBxd0Tt+btuL3eWpbAHJEozHQsk
	5oCeOrUnC+GxJoz1NRwzZH+i1MZY6KRc2nQGeBTLsU3EM8o8CZuzcTOXMbfT52+uNpWHGU
	Zgn6VpT6KcNwYUvI7fevXm3Vx6GN7MlDitE+tAgok6ewuZFw1p+pHFWiBL0KHIbKVZg+wf
	XD1CHUPGEdgjwjEWii5/dUOLU/J/iPlQu671Oa5R2pnRfyKQFlsn0+qMyx0z6ta+zOxUyv
	ou54HCFpyd0hHUYIQPStT6lolTkFfUHIROMiikYNn2hRe9+kx+oRWTUN5BCTFA==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1635328216;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=R6HIFHpD6EcdYz7reZvQoCoHmuw7azptYwwiCQ/462A=;
	b=GjeNq8UVPat0Fum4HvNLZzqlAOxC37IV1okHyikLt5oTECPz45x+VmPxYQRujP+BrJq/eZ
	Zxp766A3FFhkeSCQ==
To: Jason Andryuk <jandryuk@gmail.com>, josef@oderland.se
Cc: boris.ostrovsky@oracle.com, helgaas@kernel.org, jandryuk@gmail.com,
 jgross@suse.com, linux-pci@vger.kernel.org, maz@kernel.org,
 xen-devel@lists.xenproject.org, David Woodhouse <dwmw2@infradead.org>
Subject: [PATCH] PCI/MSI: Move non-mask check back into low level accessors
In-Reply-To: <87fssmg8k4.ffs@tglx>
References: <90277228-cf14-0cfa-c95e-d42e7d533353@oderland.se>
 <20211025012503.33172-1-jandryuk@gmail.com> <87fssmg8k4.ffs@tglx>
Date: Wed, 27 Oct 2021 11:50:15 +0200
Message-ID: <87cznqg5k8.ffs@tglx>
MIME-Version: 1.0
Content-Type: text/plain

The recent rework of PCI/MSI[X] masking moved the non-mask checks from the
low level accessors into the higher level mask/unmask functions.

This missed the fact that these accessors can be invoked from other places
as well. The missing checks break XEN-PV which sets pci_msi_ignore_mask and
also violates the virtual MSIX and the msi_attrib.maskbit protections.

Instead of sprinkling checks all over the place, lift them back into the
low level accessor functions. To avoid checking three different conditions
combine them into one property of msi_desc::msi_attrib.

Reported-by: Josef Johansson <josef@oderland.se>
Fixes: fcacdfbef5a1 ("PCI/MSI: Provide a new set of mask and unmask functions")
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Jason Andryuk <jandryuk@gmail.com>
Cc: Marc Zyngier <maz@kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>
Cc: linux-pci@vger.kernel.org
Cc: xen-devel <xen-devel@lists.xenproject.org>
Cc: Juergen Gross <jgross@suse.com>
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: David Woodhouse <dwmw2@infradead.org>
---
 drivers/pci/msi.c   |   26 ++++++++++++++------------
 include/linux/msi.h |    2 +-
 2 files changed, 15 insertions(+), 13 deletions(-)

--- a/drivers/pci/msi.c
+++ b/drivers/pci/msi.c
@@ -148,6 +148,9 @@ static noinline void pci_msi_update_mask
 	raw_spinlock_t *lock = &desc->dev->msi_lock;
 	unsigned long flags;
 
+	if (!desc->msi_attrib.can_mask)
+		return;
+
 	raw_spin_lock_irqsave(lock, flags);
 	desc->msi_mask &= ~clear;
 	desc->msi_mask |= set;
@@ -181,7 +184,8 @@ static void pci_msix_write_vector_ctrl(s
 {
 	void __iomem *desc_addr = pci_msix_desc_addr(desc);
 
-	writel(ctrl, desc_addr + PCI_MSIX_ENTRY_VECTOR_CTRL);
+	if (desc->msi_attrib.can_mask)
+		writel(ctrl, desc_addr + PCI_MSIX_ENTRY_VECTOR_CTRL);
 }
 
 static inline void pci_msix_mask(struct msi_desc *desc)
@@ -200,23 +204,17 @@ static inline void pci_msix_unmask(struc
 
 static void __pci_msi_mask_desc(struct msi_desc *desc, u32 mask)
 {
-	if (pci_msi_ignore_mask || desc->msi_attrib.is_virtual)
-		return;
-
 	if (desc->msi_attrib.is_msix)
 		pci_msix_mask(desc);
-	else if (desc->msi_attrib.maskbit)
+	else
 		pci_msi_mask(desc, mask);
 }
 
 static void __pci_msi_unmask_desc(struct msi_desc *desc, u32 mask)
 {
-	if (pci_msi_ignore_mask || desc->msi_attrib.is_virtual)
-		return;
-
 	if (desc->msi_attrib.is_msix)
 		pci_msix_unmask(desc);
-	else if (desc->msi_attrib.maskbit)
+	else
 		pci_msi_unmask(desc, mask);
 }
 
@@ -484,7 +482,8 @@ msi_setup_entry(struct pci_dev *dev, int
 	entry->msi_attrib.is_64		= !!(control & PCI_MSI_FLAGS_64BIT);
 	entry->msi_attrib.is_virtual    = 0;
 	entry->msi_attrib.entry_nr	= 0;
-	entry->msi_attrib.maskbit	= !!(control & PCI_MSI_FLAGS_MASKBIT);
+	entry->msi_attrib.can_mask	= !pci_msi_ignore_mask &&
+					  !!(control & PCI_MSI_FLAGS_MASKBIT);
 	entry->msi_attrib.default_irq	= dev->irq;	/* Save IOAPIC IRQ */
 	entry->msi_attrib.multi_cap	= (control & PCI_MSI_FLAGS_QMASK) >> 1;
 	entry->msi_attrib.multiple	= ilog2(__roundup_pow_of_two(nvec));
@@ -495,7 +494,7 @@ msi_setup_entry(struct pci_dev *dev, int
 		entry->mask_pos = dev->msi_cap + PCI_MSI_MASK_32;
 
 	/* Save the initial mask status */
-	if (entry->msi_attrib.maskbit)
+	if (entry->msi_attrib.can_mask)
 		pci_read_config_dword(dev, entry->mask_pos, &entry->msi_mask);
 
 out:
@@ -638,10 +637,13 @@ static int msix_setup_entries(struct pci
 		entry->msi_attrib.is_virtual =
 			entry->msi_attrib.entry_nr >= vec_count;
 
+		entry->msi_attrib.can_mask	= !pci_msi_ignore_mask &&
+						  !entry->msi_attrib.is_virtual;
+
 		entry->msi_attrib.default_irq	= dev->irq;
 		entry->mask_base		= base;
 
-		if (!entry->msi_attrib.is_virtual) {
+		if (!entry->msi_attrib.can_mask) {
 			addr = pci_msix_desc_addr(entry);
 			entry->msix_ctrl = readl(addr + PCI_MSIX_ENTRY_VECTOR_CTRL);
 		}
--- a/include/linux/msi.h
+++ b/include/linux/msi.h
@@ -148,7 +148,7 @@ struct msi_desc {
 				u8	is_msix		: 1;
 				u8	multiple	: 3;
 				u8	multi_cap	: 3;
-				u8	maskbit		: 1;
+				u8	can_mask	: 1;
 				u8	is_64		: 1;
 				u8	is_virtual	: 1;
 				u16	entry_nr;


From xen-devel-bounces@lists.xenproject.org Wed Oct 27 09:50:47 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Oct 2021 09:50:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.216825.376582 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mffa3-0003Ei-Bl; Wed, 27 Oct 2021 09:50:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 216825.376582; Wed, 27 Oct 2021 09:50:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mffa3-0003Eb-6G; Wed, 27 Oct 2021 09:50:47 +0000
Received: by outflank-mailman (input) for mailman id 216825;
 Wed, 27 Oct 2021 09:50:46 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mffa2-0003EK-3L; Wed, 27 Oct 2021 09:50:46 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mffa1-0000KE-UI; Wed, 27 Oct 2021 09:50:45 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mffa1-0000Mj-KE; Wed, 27 Oct 2021 09:50:45 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mffa1-0007Ij-Jj; Wed, 27 Oct 2021 09:50:45 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=OeWdZX4mj1t84mUnTT3m1pfo4Y2M63EwRInHW5U700Q=; b=rraUUdVA25DJQWHKY5NKkNRdbH
	7bY2WR4TfhTPf30MvyR2jP/PSuYB9/r5koPw6ouLNp8cdlOjeNkce00ilG8ysEprsvHMXsY2AAIvR
	4E5nV8rmtKkOQcvTXuT7n6XKSKNAhNV31BAiKHdJtfztFp3vXHrsuOpnJzjSPWXteTSk=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165895-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-coverity test] 165895: all pass - PUSHED
X-Osstest-Versions-This:
    xen=b0fce57a6a491c120f2554ad7cc9a0c43ee5defa
X-Osstest-Versions-That:
    xen=23ec1ebc8acbfd2bf06f6085a776f0db923f9fa9
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 27 Oct 2021 09:50:45 +0000

flight 165895 xen-unstable-coverity real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165895/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 xen                  b0fce57a6a491c120f2554ad7cc9a0c43ee5defa
baseline version:
 xen                  23ec1ebc8acbfd2bf06f6085a776f0db923f9fa9

Last test of basis   165836  2021-10-24 09:18:30 Z    3 days
Testing same since   165895  2021-10-27 09:18:35 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Anthony PERARD <anthony.perard@citrix.com>

jobs:
 coverity-amd64                                               pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   23ec1ebc8a..b0fce57a6a  b0fce57a6a491c120f2554ad7cc9a0c43ee5defa -> coverity-tested/smoke


From xen-devel-bounces@lists.xenproject.org Wed Oct 27 09:53:35 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Oct 2021 09:53:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.216838.376595 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mffce-0003zH-N6; Wed, 27 Oct 2021 09:53:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 216838.376595; Wed, 27 Oct 2021 09:53:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mffce-0003zA-K3; Wed, 27 Oct 2021 09:53:28 +0000
Received: by outflank-mailman (input) for mailman id 216838;
 Wed, 27 Oct 2021 09:53:27 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=8lYk=PP=epam.com=prvs=0934bd4bd6=oleksandr_andrushchenko@srs-us1.protection.inumbo.net>)
 id 1mffcd-0003z4-Ao
 for xen-devel@lists.xenproject.org; Wed, 27 Oct 2021 09:53:27 +0000
Received: from mx0a-0039f301.pphosted.com (unknown [148.163.133.242])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id ba9848f2-370b-11ec-8458-12813bfff9fa;
 Wed, 27 Oct 2021 09:53:26 +0000 (UTC)
Received: from pps.filterd (m0174678.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 19R9VRVA031287; 
 Wed, 27 Oct 2021 09:53:23 GMT
Received: from eur05-am6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2107.outbound.protection.outlook.com [104.47.18.107])
 by mx0a-0039f301.pphosted.com with ESMTP id 3by475r3cd-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Wed, 27 Oct 2021 09:53:23 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by AM0PR03MB4755.eurprd03.prod.outlook.com (2603:10a6:208:c2::29)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.18; Wed, 27 Oct
 2021 09:53:20 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::c038:e032:595a:651]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::c038:e032:595a:651%9]) with mapi id 15.20.4649.014; Wed, 27 Oct 2021
 09:53:20 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ba9848f2-370b-11ec-8458-12813bfff9fa
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Q07DCNdX3mfsSyTCl/aGmCMIDcYejLWRx9+scROQdrGJoOk4Yk0uhoG9qBa+RwxejLTAX1nSDZT6HzsCuYMAYOuhuER2z+MvrmqnKUj6rnU4gojI8RhG4l+VQD1y5UfO5jMP00LXNmLGo4U5Qa0QwHKeUL5FFXN+upYWockG87RL5qtnPVpgL4Am58kL4CAeXTMp02GKQ3EoykHxHS7cWL/JGEuOylqqmFLl2NrdjLwpTcq3hqZBDoOkyCCPu4JGVtuucIXM383+TFEiRgNhR/tpoVU2Q8d/vqlQUtqiNAAsebXa8DzF/Cm6zvuCV9cg5kgh/8MrLep1+ZOSp9NkOA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=m4X/aaawMMI5dNoBKLU0OAoBCSiBjLiGRQVr/A8v00Y=;
 b=UTUCUohJOl1/+M7xn03hZqYI5rXh+eKmkQc1rEueZlxAXAMXPlDU6uIdMq8pA8OLy07Tg0r3L3XpSl6AweznxB1gdNDzG0Ia/5HNriV30itVGyccGDhvJGq7mT2clBn7c5yhuKutKK1JYnuF5z+ZcFbxTLrUvxutWUSkStuwsKqn6XkJBAGMQBc1bd0OWqbXWsheaiuO3aUQrB8g3V8GNvOYkfFyCNKl+DZSiZ+rhPFUEokIIhJogUBIolg28RuqLiamAQpwGdMC1RCAjBmOVCEoAB99ocWt/i50KIVC4vWNpFcuICY1Lbx1PLjjsXy4y7/qCTcdu9HiJin+lLt1hA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=m4X/aaawMMI5dNoBKLU0OAoBCSiBjLiGRQVr/A8v00Y=;
 b=J6BxeM4V/GXqBsA7iRt46VQaXXRtVqDIlFa2K43Kgh8NOG5ezT2SBxFfIuU9DzADniSXbGZ5n1G0vNy7rDWpaWaaBA5YQwQQ3ApNdmG45po2TJz4uKcP6IDt3KLF07rJffJuggUPp86VX3qt5pjMXOrffqGIyBXtS/X8oUWKnerybULXuBqYVGn1wW0KsrKF39ru1ppU3GV7hBALUXjUrzFakdkN/hCUfQz+r2AbOTsQNpsvsrK4QKb2V7H8INPTZqnUahW3PPMP0loJyIO6dWQbzZ9jK6/g8Sava8LjWH7G+V9JX6XZ3WEHz7uHiMqZwWyd4aT9sZsYY8gG8+qrZw==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org"
	<sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "jbeulich@suse.com" <jbeulich@suse.com>,
        Bertrand Marquis
	<bertrand.marquis@arm.com>,
        Rahul Singh <rahul.singh@arm.com>,
        Oleksandr
 Andrushchenko <Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH v3 02/11] vpci: Add hooks for PCI device assign/de-assign
Thread-Topic: [PATCH v3 02/11] vpci: Add hooks for PCI device assign/de-assign
Thread-Index: AQHXtdAg2qzxZ1hIP02wGTFUbQtoPavQ36qAgBXlpoA=
Date: Wed, 27 Oct 2021 09:53:20 +0000
Message-ID: <58191b00-8246-8106-bf45-a1dc5e6265f7@epam.com>
References: <20210930075223.860329-1-andr2000@gmail.com>
 <20210930075223.860329-3-andr2000@gmail.com>
 <YWbDMwC+6ehmGurS@MacBook-Air-de-Roger.local>
In-Reply-To: <YWbDMwC+6ehmGurS@MacBook-Air-de-Roger.local>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 986147d0-81a3-49b6-4ff7-08d9992f9bc6
x-ms-traffictypediagnostic: AM0PR03MB4755:
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <AM0PR03MB4755C39E77FE65C9B2E8BD91E7859@AM0PR03MB4755.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:9508;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 iSxz/l/oA0X1Xl0DiX78SkRMoF61XmdRGX73c78DZuXnT5c7huEYEsEJkEOpSOdLHaXprUmIhBzKivOHkGi64yQ4OiPWOs3GojpX4tm5vVtTfYO33iXSS3ZX6eIX1U5BMxG8wFvJFYM7qWjn+Uk8JeiWfoCf9D839SHfcs7T0iDBk1VuBR8rkc1SMlrdi1F0wqYHsJA/op/wMyO2zwwaYivwLLnFZ3JqF3JVBrsSf73nreVE81oahMCxgfEtrZ7RzK6nVMUuNYkj5Lcn2zYNl9OZd1VSL86+2MdS0fcgtB6MmehgY1RMSpgNaHKSccdIF6witcqg4HjlGGw/orbwCFqu6vPaHlmAYZ05v8X9yXKjwBT0C2vO9qEeJL71qsTHjGbmhaIe6F+DXTpc1T0IbGzICs/Ki8YYXnPpSsUHZ8KxXaGd+g/f7MpruLGAU304vg7RwApk16PDXC4qxfyjlVU0c1X6UYJRAmB8e9sTVk39BY+itDLnMtCGMHs2Oqaf26pf9LVzzBjXwX1UNbY3SnAEb6YZt+qv2AN+G/qfwalPaNbEk3mKYHSyy0zlmWKd4V2vXNNGSPyoVCAOjym6pHNgB9THm9/bOfo4qceDyAiml7IAvgH2MH6gd2bPXeDLWnHxK7wl8GFgOms9Q7sIA079uNVXXgybE2F4hNMV7VWYwIfzl0f9BFBgcuq8FFsEO9dfbFWmjp/3ivStNV1Y7RrmS+5NVJjejLJqZM4QmfVvyA5bunNIOikE1NGbqIit
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(26005)(6512007)(508600001)(6486002)(122000001)(53546011)(8676002)(107886003)(66446008)(38100700002)(6916009)(64756008)(36756003)(91956017)(31686004)(5660300002)(54906003)(316002)(2616005)(38070700005)(2906002)(6506007)(76116006)(31696002)(186003)(71200400001)(4326008)(8936002)(66476007)(66946007)(66556008)(86362001)(83380400001)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?UVFJN0N1ckd1bjVhT0NheWdVb2hwQUVaRDBSU3JLNWxkbU1rZEM3WExNd3E1?=
 =?utf-8?B?WkdDWVpqc0wwaW04SWgyNFBOUkFnK3JCMHUyWElvd24yclR0eDZsclJuNTJH?=
 =?utf-8?B?enhadTg4ZWE3K2V2em5wWlF0OG5acGh4ZTgvSzdCQTE0ZXZQWEhuc3dkRG8v?=
 =?utf-8?B?UjlBcWc3NTNmbWFDL3U3MjhaMllMTWxNTEV1RE1NS2VocExkclY3VTJoUlhK?=
 =?utf-8?B?aHplRHBCUHA5Y3VWTUhqZHhOWXExQiswL3Z1Nlc5elFuSTk1TVRTeGgxRVFx?=
 =?utf-8?B?YWh4U3ppUnJIdDdBZXBLa1hKS0czKzdLMjlRMmpDcExkS2IzQk1BenBwQWl3?=
 =?utf-8?B?dm1XWE1qMmhydGFSWC9reTlMWU5LLzg3YzVYZUs1UHRYbWd6ZlF1SmFxUHdY?=
 =?utf-8?B?QTF2cysvNC9xSUM0cDVwUktSSHFYaGxSZVFmeVdBREwwTjhVTmZvSmt6UDZu?=
 =?utf-8?B?VW13enBJdEFFL0RxMDAwanE5MUxkUkZ5OThhaitMSE5VR2J4dm9hQlVxQUlx?=
 =?utf-8?B?SElRTUViRmo1Tk9qSEtJWVUxS2l3dE96SXBzMzVzb1ZpNkhsTGxwNWlvaGNR?=
 =?utf-8?B?NmVRd0hTYzd3WjBmVlBnRkEwY1M0SmZQd1E5c1ljcFVJc2VMUTE2QmhEdFdL?=
 =?utf-8?B?Nzcrd2FWd2ZlbklrYWxHRGlKcFlYUDA0VVA4Q1hxVjJObmFsOUpGNXgyM2Qr?=
 =?utf-8?B?MFFwY1dGZ0dhbXZDYUt5V1I1V1dzdlg4R1kyV3NrSmNEWFZlSVc0VHBQWWRu?=
 =?utf-8?B?WUF1MWlVdGtJVXJhb3VzcjNXaC9UMFd2T1ZEQVdyZ0FNSWJHM1RrVDM3ekQv?=
 =?utf-8?B?R3ZrUldUbExoS3B1RW9VZXdvdHE1eG4wTDAxWWlMVjk3aXk3OGVxYi9vdmo5?=
 =?utf-8?B?VnFVMHZVREJSVlJvRFhqV2xHUzNWdTJXS0M1Z3AxcnNpR05LWjJycWFpYjJ4?=
 =?utf-8?B?K3JvQXZQcVZoeW95V283cjdOdElyeG4xbkpGNS9NQmJvZEh6Q3poNHN1YWhP?=
 =?utf-8?B?bjNaTm1QTDFqWDhRL3lEZGxwOHZ2bG1kQnorMXFvL2pBY3dEQk5CL0pZR042?=
 =?utf-8?B?NERZWjQvNmZHN1pwUU4rUS9OUmZGRDdOK0tlSUszRmVyeDRIc0RPdVBSTjM3?=
 =?utf-8?B?akhjVnJQVU1ta1FpQ1Zsc0NIQkFRODRURWZRT21GZS91WlpaTWlIYW1NSDdw?=
 =?utf-8?B?WVdlQXZCS2pha1ZweUhmNnE0YXRRRnc0dkhyaEVIS2pSSzBjdSt3ODdHYzJ2?=
 =?utf-8?B?d05xNHJReSsvT2VsbmhMVFNXVUc2Y09Kc29uWGQ4ZE5MMUVURXh6QjBWZFhl?=
 =?utf-8?B?QzI3ZDR1SEZEUWdsZlM5ZTJReXdmVHFuOTVDaUpGOE84WEdzKzB4UVBJUHBu?=
 =?utf-8?B?TXlQeUxDbHhLVk9COGdLRWpucFhoTEFUUEV5Q0dpd2dFUUEwM1A0K0dRQklq?=
 =?utf-8?B?Q0IybG14cWxtUUdmUEYxdDh2aTJqOHVhSDdQUTlpVExhRTB5SDR5M0ErUlpR?=
 =?utf-8?B?cXUzWEZoUVhzYnl5amlST01FZjFPMXEycHg5SkhwQU45U0hEZENFa3pzUUFN?=
 =?utf-8?B?UWJrVFFhQm1lSUI0TnV0UlBnYjU5SzVTL1lKd0c0NXhqVm1SMjU2M2poYjFn?=
 =?utf-8?B?cERkSVpJR3ZheGxIMWM0WUpRbWxKMWs0QUMrbVJkMVN3bGtsanpsRkdqU1lM?=
 =?utf-8?B?VkdpVVNpZHREeTIyNXNpVWtrV1k5L0w3ZzZCNTMxaklFUFVNWEM3UHRPR2lJ?=
 =?utf-8?B?WGEyQXRtOUNLNkdBdVZMVWZCTlpTWmNtMXhSa1RuelptelUrUFFNcnc5NzBn?=
 =?utf-8?B?UVg3eE9FVW1Vc3dHaXFSNlN0KzhkQTllZzh0UXhaQWs0MGZRS2pHUDEzaXR3?=
 =?utf-8?B?aHppWTNEWS81aVRkb3pkVWRFVjlzemFFUlZyQW5jMGFMQ3ZrWHZjblZBbG1E?=
 =?utf-8?B?dVIwR0xPTnd6MU83YkxqQmZNQVNwaUViZnJaTTBGSE1YVXRRL1lFcFZVeHNv?=
 =?utf-8?B?U2l4ZklKYmI4LzVQd2N0TW56Sit5eGoxQ2tvV0hKbjluOFZjZ1FJRzAxbnk1?=
 =?utf-8?B?SnYvc1ZsS0FobDg5RUFUV1BvcG0rRlJlNE9vUTJySXNBSk9HcWhScjRkMjlW?=
 =?utf-8?B?Rm1leFhReUJaZ2NDalZ6NjRxd1VzTkhJclRCMGVmOVIwOXhJTU1wMDl5ODBK?=
 =?utf-8?B?NUN6eFNKam5YcFRtMUxVQmVRcllDOXR4K2lRMVV6ajd4VmZ5N2RuaGVjSU9h?=
 =?utf-8?B?OXFXcndnOXBYVnFWRGlGNUVFaUlXV2FybGxnUW9JQjhZd084QUZOSU12aldj?=
 =?utf-8?B?TFVjTmhIenoyT0JoSFA0M2dKVkxhRHB6YUpFc3JMLzFmMlNOSlJadz09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <35DC485804E4B14F872C20888E54FAFF@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 986147d0-81a3-49b6-4ff7-08d9992f9bc6
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Oct 2021 09:53:20.3801
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: wW158Fm1PI1WbdYelF1Z7qZjcybxTUi9nfOCjkIxEwsEKzTsYlRucm+V5dTLt3fYaPSuh0xkBONxOlhitdhWm5EmMaRcLWs3xeWvFbN5HqF9pvZafqFYiTrfr9ylJzax
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR03MB4755
X-Proofpoint-GUID: x_zFrt2w_LFkVAtH1bFjviCDxYVcvJne
X-Proofpoint-ORIG-GUID: x_zFrt2w_LFkVAtH1bFjviCDxYVcvJne
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475
 definitions=2021-10-27_03,2021-10-26_01,2020-04-07_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 bulkscore=0
 phishscore=0 adultscore=0 malwarescore=0 clxscore=1015 priorityscore=1501
 impostorscore=0 mlxscore=0 spamscore=0 mlxlogscore=999 lowpriorityscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2110270060

SGksIFJvZ2VyIQ0KDQpPbiAxMy4xMC4yMSAxNDoyOSwgUm9nZXIgUGF1IE1vbm7DqSB3cm90ZToN
Cj4gT24gVGh1LCBTZXAgMzAsIDIwMjEgYXQgMTA6NTI6MTRBTSArMDMwMCwgT2xla3NhbmRyIEFu
ZHJ1c2hjaGVua28gd3JvdGU6DQo+PiBGcm9tOiBPbGVrc2FuZHIgQW5kcnVzaGNoZW5rbyA8b2xl
a3NhbmRyX2FuZHJ1c2hjaGVua29AZXBhbS5jb20+DQo+Pg0KPj4gV2hlbiBhIFBDSSBkZXZpY2Ug
Z2V0cyBhc3NpZ25lZC9kZS1hc3NpZ25lZCBzb21lIHdvcmsgb24gdlBDSSBzaWRlIG5lZWRzDQo+
PiB0byBiZSBkb25lIGZvciB0aGF0IGRldmljZS4gSW50cm9kdWNlIGEgcGFpciBvZiBob29rcyBz
byB2UENJIGNhbiBoYW5kbGUNCj4+IHRoYXQuDQo+Pg0KPj4gUGxlYXNlIG5vdGUsIHRoYXQgaW4g
dGhlIGN1cnJlbnQgZGVzaWduIHRoZSBlcnJvciBwYXRoIGlzIGhhbmRsZWQgYnkNCj4+IHRoZSB0
b29sc3RhY2sgdmlhIFhFTl9ET01DVExfYXNzaWduX2RldmljZS9YRU5fRE9NQ1RMX2RlYXNzaWdu
X2RldmljZSwNCj4+IHNvIHRoaXMgaXMgd2h5IGl0IGlzIGFjY2VwdGFibGUgbm90IHRvIGRlLWFz
c2lnbiBkZXZpY2VzIGlmIHZQQ0kncw0KPj4gYXNzaWduIGZhaWxzLCBlLmcuIHRoZSByb2xsIGJh
Y2sgd2lsbCBiZSBoYW5kbGVkIG9uIGRlYXNzaWduX2RldmljZSB3aGVuDQo+PiBpdCBpcyBjYWxs
ZWQgYnkgdGhlIHRvb2xzdGFjay4NCj4gSXQncyBraW5kIG9mIGhhcmQgdG8gc2VlIHdoYXQgd291
bGQgbmVlZCB0byBiZSByb2xsZWQgYmFjaywgYXMgdGhlDQo+IGZ1bmN0aW9ucyBhcmUganVzdCBk
dW1taWVzIHJpZ2h0IG5vdyB0aGF0IGRvbid0IHBlcmZvcm0gYW55IGFjdGlvbnMuDQo+DQo+IEkg
ZG9uJ3QgdGhpbmsgdGhlIHRvb2xzdGFjayBzaG91bGQgYmUgdGhlIG9uZSB0byBkZWFsIHdpdGgg
dGhlDQo+IGZhbGxvdXQsIGFzIGl0IGNvdWxkIGxlYXZlIFhlbiBpbiBhIGJyb2tlbiBzdGF0ZS4g
VGhlIGN1cnJlbnQgY29tbWl0DQo+IG1lc3NhZ2UgZG9lc24ndCBwcm92aWRlIGFueSBpbmZvcm1h
dGlvbiBhYm91dCB3aHkgaXQgaGFzIGJlZW4gZGVzaWduZWQNCj4gdGhpcyB3YXkuDQpZZXMsIHdl
IGRpc2N1c3NlZCBpbiBvdGhlciBwYXRjaGVzIHRoYXQgd2UgbmVlZCBub3QgcmVseSBvbiB0aGUN
CnRvb2xzdGFjayBhbmQgcGVyZm9ybSBjbGVhbnVwIG91cnNlbHZlcywgc28gdGhpcyB0aGUgY29k
ZSBmcm9tIHRoZQ0KZnV0dXJlIHRvIGlsbHVzdHJhdGUgdGhlIHJvbGwtYmFjazoNCg0KaW50IHZw
Y2lfYXNzaWduX2RldmljZShzdHJ1Y3QgZG9tYWluICpkLCBjb25zdCBzdHJ1Y3QgcGNpX2RldiAq
cGRldikNCnsNCiDCoMKgwqAgaW50IHJjOw0KDQogwqDCoMKgIC8qIEl0IG9ubHkgbWFrZXMgc2Vu
c2UgdG8gYXNzaWduIGZvciBod2RvbSBvciBndWVzdCBkb21haW4uICovDQogwqDCoMKgIGlmICgg
aXNfc3lzdGVtX2RvbWFpbihkKSB8fCAhaGFzX3ZwY2koZCkgKQ0KIMKgwqDCoMKgwqDCoMKgIHJl
dHVybiAwOw0KDQogwqDCoMKgIHJjID0gdnBjaV9iYXJfYWRkX2hhbmRsZXJzKGQsIHBkZXYpOw0K
IMKgwqDCoCBpZiAoIHJjICkNCiDCoMKgwqDCoMKgwqDCoCBnb3RvIGZhaWw7DQoNCiDCoMKgwqAg
cmMgPSB2cGNpX2FkZF92aXJ0dWFsX2RldmljZShkLCBwZGV2KTsNCiDCoMKgwqAgaWYgKCByYyAp
DQogwqDCoMKgIHsNCiDCoMKgwqDCoMKgwqDCoCBnZHByaW50ayhYRU5MT0dfRVJSLA0KIMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgICIlcHA6IGZhaWxlZCB0byBhZGQgdmlydHVhbCBk
ZXZpY2UgZm9yICVwZDogJWRcbiIsDQogwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAg
JnBkZXYtPnNiZGYsIGQsIHJjKTsNCiDCoMKgwqDCoMKgwqDCoCBnb3RvIGZhaWw7DQogwqDCoMKg
IH0NCg0KIMKgwqDCoCByZXR1cm4gMDsNCg0KZmFpbDoNCiDCoMKgwqAgLyoNCiDCoMKgwqDCoCAq
IFdlIGFyZSB0cnlpbmcgdG8gY2xlYW4gdXAgYXMgbXVjaCBhcyB3ZSBjYW4sIHNvIGlnbm9yZSB0
aGUgcmV0dXJuDQogwqDCoMKgwqAgKiB2YWx1ZSBvZiB2cGNpX2RlYXNzaWduX2RldmljZSBiZWxv
dywgc28gd2UgY2FuIHJldHVybiB0aGUNCiDCoMKgwqDCoCAqIGVycm9yIHdoaWNoIGNhdXNlZCB0
aGUgZmFpbHVyZS4NCiDCoMKgwqDCoCAqLw0KIMKgwqDCoCB2cGNpX2RlYXNzaWduX2RldmljZShk
LCBwZGV2KTsNCiDCoMKgwqAgcmV0dXJuIHJjOw0KfQ0KDQpTbywgSSB3aWxsIGRyb3AgdGhlIHBh
cnQgYWJvdXQgdGhlIHRvb2xzdGFjayBhbmQgY2xlYW51cCBmcm9tIHRoZSBjb21taXQgbWVzc2Fn
ZQ0KPg0KPj4gU2lnbmVkLW9mZi1ieTogT2xla3NhbmRyIEFuZHJ1c2hjaGVua28gPG9sZWtzYW5k
cl9hbmRydXNoY2hlbmtvQGVwYW0uY29tPg0KPj4gLS0tDQo+PiBTaW5jZSB2MjoNCj4+IC0gZGVm
aW5lIENPTkZJR19IQVNfVlBDSV9HVUVTVF9TVVBQT1JUIHNvIGRlYWQgY29kZSBpcyBub3QgY29t
cGlsZWQNCj4+ICAgIGZvciB4ODYNCj4+IFNpbmNlIHYxOg0KPj4gICAtIGNvbnN0aWZ5IHN0cnVj
dCBwY2lfZGV2IHdoZXJlIHBvc3NpYmxlDQo+PiAgIC0gZG8gbm90IG9wZW4gY29kZSBpc19zeXN0
ZW1fZG9tYWluKCkNCj4+ICAgLSBleHRlbmRlZCB0aGUgY29tbWl0IG1lc3NhZ2UNCj4+IC0tLQ0K
Pj4gICB4ZW4vZHJpdmVycy9LY29uZmlnICAgICAgICAgICB8ICA0ICsrKysNCj4+ICAgeGVuL2Ry
aXZlcnMvcGFzc3Rocm91Z2gvcGNpLmMgfCAgOSArKysrKysrKysNCj4+ICAgeGVuL2RyaXZlcnMv
dnBjaS92cGNpLmMgICAgICAgfCAyMyArKysrKysrKysrKysrKysrKysrKysrKw0KPj4gICB4ZW4v
aW5jbHVkZS94ZW4vdnBjaS5oICAgICAgICB8IDIwICsrKysrKysrKysrKysrKysrKysrDQo+PiAg
IDQgZmlsZXMgY2hhbmdlZCwgNTYgaW5zZXJ0aW9ucygrKQ0KPj4NCj4+IGRpZmYgLS1naXQgYS94
ZW4vZHJpdmVycy9LY29uZmlnIGIveGVuL2RyaXZlcnMvS2NvbmZpZw0KPj4gaW5kZXggZGI5NDM5
M2Y0N2E2Li43ODA0OTBjZjhlMzkgMTAwNjQ0DQo+PiAtLS0gYS94ZW4vZHJpdmVycy9LY29uZmln
DQo+PiArKysgYi94ZW4vZHJpdmVycy9LY29uZmlnDQo+PiBAQCAtMTUsNCArMTUsOCBAQCBzb3Vy
Y2UgImRyaXZlcnMvdmlkZW8vS2NvbmZpZyINCj4+ICAgY29uZmlnIEhBU19WUENJDQo+PiAgIAli
b29sDQo+PiAgIA0KPj4gK2NvbmZpZyBIQVNfVlBDSV9HVUVTVF9TVVBQT1JUDQo+PiArCWJvb2wN
Cj4+ICsJZGVwZW5kcyBvbiBIQVNfVlBDSQ0KPiBJIHdvdWxkIGFzc3VtZSB0aGlzIGlzIHRvIGdv
IGF3YXkgb25jZSB0aGUgd29yayBpcyBmaW5pc2hlZD8gSSBkb24ndA0KPiB0aGluayBpdCBtYWtl
cyBzZW5zZSB0byBzcGxpdCB2UENJIGNvZGUgYmV0d2VlbiBkb21VL2RvbTAgb24gYSBidWlsZA0K
PiB0aW1lIGJhc2lzLg0KPg0KPj4gKw0KPj4gICBlbmRtZW51DQo+PiBkaWZmIC0tZ2l0IGEveGVu
L2RyaXZlcnMvcGFzc3Rocm91Z2gvcGNpLmMgYi94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC9wY2ku
Yw0KPj4gaW5kZXggOWY4MDRhNTBlNzgwLi44MDVhYjg2ZWQ1NTUgMTAwNjQ0DQo+PiAtLS0gYS94
ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC9wY2kuYw0KPj4gKysrIGIveGVuL2RyaXZlcnMvcGFzc3Ro
cm91Z2gvcGNpLmMNCj4+IEBAIC04NzAsNiArODcwLDEwIEBAIHN0YXRpYyBpbnQgZGVhc3NpZ25f
ZGV2aWNlKHN0cnVjdCBkb21haW4gKmQsIHVpbnQxNl90IHNlZywgdWludDhfdCBidXMsDQo+PiAg
ICAgICBpZiAoIHJldCApDQo+PiAgICAgICAgICAgZ290byBvdXQ7DQo+PiAgIA0KPj4gKyAgICBy
ZXQgPSB2cGNpX2RlYXNzaWduX2RldmljZShkLCBwZGV2KTsNCj4+ICsgICAgaWYgKCByZXQgKQ0K
Pj4gKyAgICAgICAgZ290byBvdXQ7DQo+PiArDQo+PiAgICAgICBpZiAoIHBkZXYtPmRvbWFpbiA9
PSBoYXJkd2FyZV9kb21haW4gICkNCj4+ICAgICAgICAgICBwZGV2LT5xdWFyYW50aW5lID0gZmFs
c2U7DQo+PiAgIA0KPj4gQEAgLTE0MjksNiArMTQzMywxMSBAQCBzdGF0aWMgaW50IGFzc2lnbl9k
ZXZpY2Uoc3RydWN0IGRvbWFpbiAqZCwgdTE2IHNlZywgdTggYnVzLCB1OCBkZXZmbiwgdTMyIGZs
YWcpDQo+PiAgICAgICAgICAgcmMgPSBoZC0+cGxhdGZvcm1fb3BzLT5hc3NpZ25fZGV2aWNlKGQs
IGRldmZuLCBwY2lfdG9fZGV2KHBkZXYpLCBmbGFnKTsNCj4+ICAgICAgIH0NCj4+ICAgDQo+PiAr
ICAgIGlmICggcmMgKQ0KPj4gKyAgICAgICAgZ290byBkb25lOw0KPj4gKw0KPj4gKyAgICByYyA9
IHZwY2lfYXNzaWduX2RldmljZShkLCBwZGV2KTsNCj4+ICsNCj4+ICAgIGRvbmU6DQo+PiAgICAg
ICBpZiAoIHJjICkNCj4+ICAgICAgICAgICBwcmludGsoWEVOTE9HX0dfV0FSTklORyAiJXBkOiBh
c3NpZ24gKCVwcCkgZmFpbGVkICglZClcbiIsDQo+PiBkaWZmIC0tZ2l0IGEveGVuL2RyaXZlcnMv
dnBjaS92cGNpLmMgYi94ZW4vZHJpdmVycy92cGNpL3ZwY2kuYw0KPj4gaW5kZXggMTY2NjQwMmQ1
NWI4Li4wZmU4NmNiMzBkMjMgMTAwNjQ0DQo+PiAtLS0gYS94ZW4vZHJpdmVycy92cGNpL3ZwY2ku
Yw0KPj4gKysrIGIveGVuL2RyaXZlcnMvdnBjaS92cGNpLmMNCj4+IEBAIC04Niw2ICs4NiwyOSBA
QCBpbnQgX19od2RvbV9pbml0IHZwY2lfYWRkX2hhbmRsZXJzKHN0cnVjdCBwY2lfZGV2ICpwZGV2
KQ0KPj4gICANCj4+ICAgICAgIHJldHVybiByYzsNCj4+ICAgfQ0KPj4gKw0KPj4gKyNpZmRlZiBD
T05GSUdfSEFTX1ZQQ0lfR1VFU1RfU1VQUE9SVA0KPj4gKy8qIE5vdGlmeSB2UENJIHRoYXQgZGV2
aWNlIGlzIGFzc2lnbmVkIHRvIGd1ZXN0LiAqLw0KPj4gK2ludCB2cGNpX2Fzc2lnbl9kZXZpY2Uo
c3RydWN0IGRvbWFpbiAqZCwgY29uc3Qgc3RydWN0IHBjaV9kZXYgKmRldikNCj4+ICt7DQo+PiAr
ICAgIC8qIEl0IG9ubHkgbWFrZXMgc2Vuc2UgdG8gYXNzaWduIGZvciBod2RvbSBvciBndWVzdCBk
b21haW4uICovDQo+PiArICAgIGlmICggaXNfc3lzdGVtX2RvbWFpbihkKSB8fCAhaGFzX3ZwY2ko
ZCkgKQ0KPj4gKyAgICAgICAgcmV0dXJuIDA7DQo+PiArDQo+PiArICAgIHJldHVybiAwOw0KPj4g
K30NCj4+ICsNCj4+ICsvKiBOb3RpZnkgdlBDSSB0aGF0IGRldmljZSBpcyBkZS1hc3NpZ25lZCBm
cm9tIGd1ZXN0LiAqLw0KPj4gK2ludCB2cGNpX2RlYXNzaWduX2RldmljZShzdHJ1Y3QgZG9tYWlu
ICpkLCBjb25zdCBzdHJ1Y3QgcGNpX2RldiAqZGV2KQ0KPj4gK3sNCj4+ICsgICAgLyogSXQgb25s
eSBtYWtlcyBzZW5zZSB0byBkZS1hc3NpZ24gZnJvbSBod2RvbSBvciBndWVzdCBkb21haW4uICov
DQo+PiArICAgIGlmICggaXNfc3lzdGVtX2RvbWFpbihkKSB8fCAhaGFzX3ZwY2koZCkgKQ0KPj4g
KyAgICAgICAgcmV0dXJuIDA7DQo+PiArDQo+PiArICAgIHJldHVybiAwOw0KPj4gK30NCj4+ICsj
ZW5kaWYgLyogQ09ORklHX0hBU19WUENJX0dVRVNUX1NVUFBPUlQgKi8NCj4+ICsNCj4+ICAgI2Vu
ZGlmIC8qIF9fWEVOX18gKi8NCj4+ICAgDQo+PiAgIHN0YXRpYyBpbnQgdnBjaV9yZWdpc3Rlcl9j
bXAoY29uc3Qgc3RydWN0IHZwY2lfcmVnaXN0ZXIgKnIxLA0KPj4gZGlmZiAtLWdpdCBhL3hlbi9p
bmNsdWRlL3hlbi92cGNpLmggYi94ZW4vaW5jbHVkZS94ZW4vdnBjaS5oDQo+PiBpbmRleCAyZTkx
MGQwYjFmOTAuLmVjYzA4ZjJjMGY2NSAxMDA2NDQNCj4+IC0tLSBhL3hlbi9pbmNsdWRlL3hlbi92
cGNpLmgNCj4+ICsrKyBiL3hlbi9pbmNsdWRlL3hlbi92cGNpLmgNCj4+IEBAIC0yNDIsNiArMjQy
LDI2IEBAIHN0YXRpYyBpbmxpbmUgYm9vbCB2cGNpX3Byb2Nlc3NfcGVuZGluZyhzdHJ1Y3QgdmNw
dSAqdikNCj4+ICAgfQ0KPj4gICAjZW5kaWYNCj4+ICAgDQo+PiArI2lmIGRlZmluZWQoQ09ORklH
X0hBU19WUENJKSAmJiBkZWZpbmVkKENPTkZJR19IQVNfVlBDSV9HVUVTVF9TVVBQT1JUKQ0KPiBZ
b3UgZG9uJ3QgbmVlZCB0byBjaGVjayBmb3IgQ09ORklHX0hBU19WUENJLCBhcw0KPiBDT05GSUdf
SEFTX1ZQQ0lfR1VFU1RfU1VQUE9SVCBhbHJlYWR5IGRlcGVuZHMgb24gQ09ORklHX0hBU19WUENJ
IGJlaW5nDQo+IHNldC4NCj4NCldpbGwgZml4DQo+PiArLyogTm90aWZ5IHZQQ0kgdGhhdCBkZXZp
Y2UgaXMgYXNzaWduZWQvZGUtYXNzaWduZWQgdG8vZnJvbSBndWVzdC4gKi8NCj4+ICtpbnQgX19t
dXN0X2NoZWNrIHZwY2lfYXNzaWduX2RldmljZShzdHJ1Y3QgZG9tYWluICpkLA0KPj4gKyAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNvbnN0IHN0cnVjdCBwY2lfZGV2ICpkZXYp
Ow0KPj4gK2ludCBfX211c3RfY2hlY2sgdnBjaV9kZWFzc2lnbl9kZXZpY2Uoc3RydWN0IGRvbWFp
biAqZCwNCj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNvbnN0IHN0
cnVjdCBwY2lfZGV2ICpkZXYpOw0KPj4gKyNlbHNlDQo+PiArc3RhdGljIGlubGluZSBpbnQgdnBj
aV9hc3NpZ25fZGV2aWNlKHN0cnVjdCBkb21haW4gKmQsDQo+PiArICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgIGNvbnN0IHN0cnVjdCBwY2lfZGV2ICpkZXYpDQo+PiArew0KPj4g
KyAgICByZXR1cm4gMDsNCj4+ICt9Ow0KPj4gKw0KPj4gK3N0YXRpYyBpbmxpbmUgaW50IHZwY2lf
ZGVhc3NpZ25fZGV2aWNlKHN0cnVjdCBkb21haW4gKmQsDQo+PiArICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgY29uc3Qgc3RydWN0IHBjaV9kZXYgKmRldikNCj4+ICt7DQo+
PiArICAgIHJldHVybiAwOw0KPj4gK307DQo+IFlvdSBuZWVkIHRoZSBfX211c3RfY2hlY2sgYXR0
cmlidXRlcyBoZXJlIGFsc28gdG8gbWF0Y2ggdGhlIHByb3RvdHlwZXMNCj4gYWJvdmUuDQpZZXMs
IGl0IHdhcyBhbHJlYWR5IGRpc2N1c3NlZCBhbmQgSSB3aWxsIHJlbW92ZSBfX211c3RfY2hlY2su
DQo+IFRoYW5rcywgUm9nZXIuDQpUaGFuayB5b3UsDQpPbGVrc2FuZHI=


From xen-devel-bounces@lists.xenproject.org Wed Oct 27 09:54:28 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Oct 2021 09:54:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.216846.376606 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mffdc-0004cn-5T; Wed, 27 Oct 2021 09:54:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 216846.376606; Wed, 27 Oct 2021 09:54:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mffdc-0004cg-1F; Wed, 27 Oct 2021 09:54:28 +0000
Received: by outflank-mailman (input) for mailman id 216846;
 Wed, 27 Oct 2021 09:54:26 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=EkRf=PP=oderland.se=josef@srs-us1.protection.inumbo.net>)
 id 1mffda-0004cW-9m
 for xen-devel@lists.xenproject.org; Wed, 27 Oct 2021 09:54:26 +0000
Received: from office.oderland.com (unknown [91.201.60.5])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 55d0c856-024d-4e26-90fa-4b03ec1e4164;
 Wed, 27 Oct 2021 09:54:24 +0000 (UTC)
Received: from [193.180.18.161] (port=57000 helo=[10.137.0.14])
 by office.oderland.com with esmtpsa (TLS1.2) tls
 TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2)
 (envelope-from <josef@oderland.se>)
 id 1mffdX-00APdA-AN; Wed, 27 Oct 2021 11:54:23 +0200
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 55d0c856-024d-4e26-90fa-4b03ec1e4164
Message-ID: <d1cc20aa-5c5c-6c7b-2e5d-bc31362ad891@oderland.se>
Date: Wed, 27 Oct 2021 11:54:19 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:93.0) Gecko/20100101
 Thunderbird/93.0
Subject: Re: [PATCH] PCI/MSI: Move non-mask check back into low level
 accessors
Content-Language: en-US
To: Thomas Gleixner <tglx@linutronix.de>
Cc: boris.ostrovsky@oracle.com, helgaas@kernel.org, jgross@suse.com,
 linux-pci@vger.kernel.org, maz@kernel.org, xen-devel@lists.xenproject.org,
 David Woodhouse <dwmw2@infradead.org>, Jason Andryuk <jandryuk@gmail.com>
References: <90277228-cf14-0cfa-c95e-d42e7d533353@oderland.se>
 <20211025012503.33172-1-jandryuk@gmail.com> <87fssmg8k4.ffs@tglx>
 <87cznqg5k8.ffs@tglx>
From: Josef Johansson <josef@oderland.se>
In-Reply-To: <87cznqg5k8.ffs@tglx>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-AntiAbuse: This header was added to track abuse, please include it with any abuse report
X-AntiAbuse: Primary Hostname - office.oderland.com
X-AntiAbuse: Original Domain - lists.xenproject.org
X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12]
X-AntiAbuse: Sender Address Domain - oderland.se
X-Get-Message-Sender-Via: office.oderland.com: authenticated_id: josjoh@oderland.se
X-Authenticated-Sender: office.oderland.com: josjoh@oderland.se

On 10/27/21 11:50, Thomas Gleixner wrote:
> The recent rework of PCI/MSI[X] masking moved the non-mask checks from the
> low level accessors into the higher level mask/unmask functions.
>
> This missed the fact that these accessors can be invoked from other places
> as well. The missing checks break XEN-PV which sets pci_msi_ignore_mask and
> also violates the virtual MSIX and the msi_attrib.maskbit protections.
>
> Instead of sprinkling checks all over the place, lift them back into the
> low level accessor functions. To avoid checking three different conditions
> combine them into one property of msi_desc::msi_attrib.
>
> Reported-by: Josef Johansson <josef@oderland.se>
> Fixes: fcacdfbef5a1 ("PCI/MSI: Provide a new set of mask and unmask functions")
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Cc: Jason Andryuk <jandryuk@gmail.com>
> Cc: Marc Zyngier <maz@kernel.org>
> Cc: Bjorn Helgaas <helgaas@kernel.org>
> Cc: linux-pci@vger.kernel.org
> Cc: xen-devel <xen-devel@lists.xenproject.org>
> Cc: Juergen Gross <jgross@suse.com>
> Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> Cc: David Woodhouse <dwmw2@infradead.org>
> ---
>  drivers/pci/msi.c   |   26 ++++++++++++++------------
>  include/linux/msi.h |    2 +-
>  2 files changed, 15 insertions(+), 13 deletions(-)
>
> --- a/drivers/pci/msi.c
> +++ b/drivers/pci/msi.c
> @@ -148,6 +148,9 @@ static noinline void pci_msi_update_mask
>  	raw_spinlock_t *lock = &desc->dev->msi_lock;
>  	unsigned long flags;
>  
> +	if (!desc->msi_attrib.can_mask)
> +		return;
> +
>  	raw_spin_lock_irqsave(lock, flags);
>  	desc->msi_mask &= ~clear;
>  	desc->msi_mask |= set;
> @@ -181,7 +184,8 @@ static void pci_msix_write_vector_ctrl(s
>  {
>  	void __iomem *desc_addr = pci_msix_desc_addr(desc);
>  
> -	writel(ctrl, desc_addr + PCI_MSIX_ENTRY_VECTOR_CTRL);
> +	if (desc->msi_attrib.can_mask)
> +		writel(ctrl, desc_addr + PCI_MSIX_ENTRY_VECTOR_CTRL);
>  }
>  
>  static inline void pci_msix_mask(struct msi_desc *desc)
> @@ -200,23 +204,17 @@ static inline void pci_msix_unmask(struc
>  
>  static void __pci_msi_mask_desc(struct msi_desc *desc, u32 mask)
>  {
> -	if (pci_msi_ignore_mask || desc->msi_attrib.is_virtual)
> -		return;
> -
>  	if (desc->msi_attrib.is_msix)
>  		pci_msix_mask(desc);
> -	else if (desc->msi_attrib.maskbit)
> +	else
>  		pci_msi_mask(desc, mask);
>  }
>  
>  static void __pci_msi_unmask_desc(struct msi_desc *desc, u32 mask)
>  {
> -	if (pci_msi_ignore_mask || desc->msi_attrib.is_virtual)
> -		return;
> -
>  	if (desc->msi_attrib.is_msix)
>  		pci_msix_unmask(desc);
> -	else if (desc->msi_attrib.maskbit)
> +	else
>  		pci_msi_unmask(desc, mask);
>  }
>  
> @@ -484,7 +482,8 @@ msi_setup_entry(struct pci_dev *dev, int
>  	entry->msi_attrib.is_64		= !!(control & PCI_MSI_FLAGS_64BIT);
>  	entry->msi_attrib.is_virtual    = 0;
>  	entry->msi_attrib.entry_nr	= 0;
> -	entry->msi_attrib.maskbit	= !!(control & PCI_MSI_FLAGS_MASKBIT);
> +	entry->msi_attrib.can_mask	= !pci_msi_ignore_mask &&
> +					  !!(control & PCI_MSI_FLAGS_MASKBIT);
>  	entry->msi_attrib.default_irq	= dev->irq;	/* Save IOAPIC IRQ */
>  	entry->msi_attrib.multi_cap	= (control & PCI_MSI_FLAGS_QMASK) >> 1;
>  	entry->msi_attrib.multiple	= ilog2(__roundup_pow_of_two(nvec));
> @@ -495,7 +494,7 @@ msi_setup_entry(struct pci_dev *dev, int
>  		entry->mask_pos = dev->msi_cap + PCI_MSI_MASK_32;
>  
>  	/* Save the initial mask status */
> -	if (entry->msi_attrib.maskbit)
> +	if (entry->msi_attrib.can_mask)
>  		pci_read_config_dword(dev, entry->mask_pos, &entry->msi_mask);
>  
>  out:
> @@ -638,10 +637,13 @@ static int msix_setup_entries(struct pci
>  		entry->msi_attrib.is_virtual =
>  			entry->msi_attrib.entry_nr >= vec_count;
>  
> +		entry->msi_attrib.can_mask	= !pci_msi_ignore_mask &&
> +						  !entry->msi_attrib.is_virtual;
> +
>  		entry->msi_attrib.default_irq	= dev->irq;
>  		entry->mask_base		= base;
>  
> -		if (!entry->msi_attrib.is_virtual) {
> +		if (!entry->msi_attrib.can_mask) {
>  			addr = pci_msix_desc_addr(entry);
>  			entry->msix_ctrl = readl(addr + PCI_MSIX_ENTRY_VECTOR_CTRL);
>  		}
> --- a/include/linux/msi.h
> +++ b/include/linux/msi.h
> @@ -148,7 +148,7 @@ struct msi_desc {
>  				u8	is_msix		: 1;
>  				u8	multiple	: 3;
>  				u8	multi_cap	: 3;
> -				u8	maskbit		: 1;
> +				u8	can_mask	: 1;
>  				u8	is_64		: 1;
>  				u8	is_virtual	: 1;
>  				u16	entry_nr;
Thanks,
I'll test this out ASAP.


From xen-devel-bounces@lists.xenproject.org Wed Oct 27 09:59:35 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Oct 2021 09:59:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.216854.376616 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mffiK-0005Mb-NN; Wed, 27 Oct 2021 09:59:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 216854.376616; Wed, 27 Oct 2021 09:59:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mffiK-0005MU-KF; Wed, 27 Oct 2021 09:59:20 +0000
Received: by outflank-mailman (input) for mailman id 216854;
 Wed, 27 Oct 2021 09:59:19 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=IAIZ=PP=casper.srs.infradead.org=BATV+733d164bc6d8c7ae176c+6639+infradead.org+dwmw2@srs-us1.protection.inumbo.net>)
 id 1mffiI-0005MO-Fc
 for xen-devel@lists.xenproject.org; Wed, 27 Oct 2021 09:59:19 +0000
Received: from casper.infradead.org (unknown [2001:8b0:10b:1236::1])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 093f47d1-09a4-433a-a7b4-2b2c755d0fae;
 Wed, 27 Oct 2021 09:59:15 +0000 (UTC)
Received: from [2a01:4c8:1042:994a:f240:791a:356:222b] (helo=[IPv6:::1])
 by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1mffgA-00HYMy-VW; Wed, 27 Oct 2021 09:57:21 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 093f47d1-09a4-433a-a7b4-2b2c755d0fae
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:Content-Type:
	MIME-Version:Message-ID:References:In-Reply-To:Subject:CC:To:From:Date:Sender
	:Reply-To:Content-ID:Content-Description;
	bh=IB3vKlP4on8GCe7l1kqRxw29zumVr5j1/nr3g3ShAqE=; b=TFIclONAtSjKcxHyXMw0hxIXQg
	i4qFpmRUnP0XhR8jx0r1ZLqVzGWnv9mIVHcPsi9zG9WQ2J/E0svgPJHZ/LvBhs7TAq7J9zJ43i77v
	LxpF4ceCthZEDDUxkwZeU0LU9nwkCIg7c7VZx7VXJosiC5OXg/yfwCSg/ZRN+kI9OQYOD0QpZo1Li
	/uafDQmCFr5fdEYZ455y1c71uWucC4UVAeOkl2BanY32VDjOW6CfbndZeTchTqLA3A/QlZV+Ti+j5
	P2KEFwiccphpVCEFqctNvOIpWJMxcn4NyiHbNyakPWd6p10E2q7SCSUWB1TZs0ea7MUef/E18ySzd
	JGx5THPg==;
Date: Wed, 27 Oct 2021 10:57:04 +0100
From: David Woodhouse <dwmw2@infradead.org>
To: Thomas Gleixner <tglx@linutronix.de>, Jason Andryuk <jandryuk@gmail.com>,
 josef@oderland.se
CC: boris.ostrovsky@oracle.com, helgaas@kernel.org, jandryuk@gmail.com,
 jgross@suse.com, linux-pci@vger.kernel.org, maz@kernel.org,
 xen-devel@lists.xenproject.org
Subject: =?US-ASCII?Q?Re=3A_=5BPATCH=5D_PCI/MSI=3A_Move_non-mask_?= =?US-ASCII?Q?check_back_into_low_level_accessors?=
User-Agent: K-9 Mail for Android
In-Reply-To: <87cznqg5k8.ffs@tglx>
References: <90277228-cf14-0cfa-c95e-d42e7d533353@oderland.se> <20211025012503.33172-1-jandryuk@gmail.com> <87fssmg8k4.ffs@tglx> <87cznqg5k8.ffs@tglx>
Message-ID: <0A9FDABA-9067-4811-9B3D-DAFE5589D1A4@infradead.org>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-SRS-Rewrite: SMTP reverse-path rewritten from <dwmw2@infradead.org> by casper.infradead.org. See http://www.infradead.org/rpr.html



On 27 October 2021 10:50:15 BST, Thomas Gleixner <tglx@linutronix=2Ede> wr=
ote:
>The recent rework of PCI/MSI[X] masking moved the non-mask checks from th=
e
>low level accessors into the higher level mask/unmask functions=2E
>
>This missed the fact that these accessors can be invoked from other place=
s
>as well=2E The missing checks break XEN-PV which sets pci_msi_ignore_mask=
 and
>also violates the virtual MSIX and the msi_attrib=2Emaskbit protections=
=2E

Not just PV=2E It's Xen HVM guests too=2E

I'll also give it a spin on both Xen and not-Xen=2E Thanks=2E

--=20
Sent from my Android device with K-9 Mail=2E Please excuse my brevity=2E


From xen-devel-bounces@lists.xenproject.org Wed Oct 27 10:17:32 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Oct 2021 10:17:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.216862.376628 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mffzf-0007ma-6c; Wed, 27 Oct 2021 10:17:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 216862.376628; Wed, 27 Oct 2021 10:17:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mffzf-0007mT-3U; Wed, 27 Oct 2021 10:17:15 +0000
Received: by outflank-mailman (input) for mailman id 216862;
 Wed, 27 Oct 2021 10:17:13 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=8lYk=PP=epam.com=prvs=0934bd4bd6=oleksandr_andrushchenko@srs-us1.protection.inumbo.net>)
 id 1mffzd-0007mN-Jy
 for xen-devel@lists.xenproject.org; Wed, 27 Oct 2021 10:17:13 +0000
Received: from mx0b-0039f301.pphosted.com (unknown [148.163.137.242])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 661050cb-5fbf-4b10-b194-81ee377379e1;
 Wed, 27 Oct 2021 10:17:11 +0000 (UTC)
Received: from pps.filterd (m0174683.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.0.43) with SMTP id 19R9N0PJ015567;
 Wed, 27 Oct 2021 10:17:09 GMT
Received: from eur01-ve1-obe.outbound.protection.outlook.com
 (mail-ve1eur01lp2053.outbound.protection.outlook.com [104.47.1.53])
 by mx0b-0039f301.pphosted.com with ESMTP id 3by0vn0y4f-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Wed, 27 Oct 2021 10:17:08 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by AM9PR03MB6769.eurprd03.prod.outlook.com (2603:10a6:20b:284::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.18; Wed, 27 Oct
 2021 10:17:02 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::c038:e032:595a:651]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::c038:e032:595a:651%9]) with mapi id 15.20.4649.014; Wed, 27 Oct 2021
 10:17:02 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 661050cb-5fbf-4b10-b194-81ee377379e1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=nJ/AfkCy52lvOvbu4Gc1tw/8ZRW3HHo1tGwHgx96lFRRzYNflpPO+KOgTOvb4i11TflLqKCDkYVNL6/PAq54K2Byr9koCY31+9cEQv5j7dmTjKZIYZUYYPQkUQJ76454ZchiYwbBpbn9DaxPVW2g9/gdDH53aE2t+Hso2MmM82cLjuVdI24S5rq5V7wuclhNONe0NyM0sQY4pk1V45uU50dnTvVZwW7cc0D8HBt+3g92bUSUqER5KC9EUMoZWg2tK/jGwsrQ//6wQJ1xV5547ClFdSIonuwemMWmI3yH4kJYG+wb4K/emyYPdTA1hZe7kvDzRrV1RlUXWUyFKz0e8A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=OQK98qWp/1lENa6X6N98dzHtyEK5xhe6l9LbTzVHU7g=;
 b=CWU1EEMl8jMYfal115hxCFBKNB7ue9uiBKw5OdejKNZAkUk1TFxprXVXGUAS1rFTlHxDKYZAOxkH1ew/1ywWTTnZfACQ3R8/i8LZAcP/Fk6585bJGzq/jQWO3CYPeiMJf9wxei5hquSeGgRp14zFT4PHXyqBOymYrZjCfsjQfxgTrmPgBhyK5T/1bjRJP8HPdt+BDt7Y74c6CPD2VNU1PcvSlWxXYUj/HhxF3yE6OVnIAioybEgqr2JH0cYoyqH+7HWXL0PavLKOwKLn6CAdfaqV06N9QzBiqHWq5mXuy6pLu3A2+vFkwvtKdWSbhvRVEX4i7EC7otdZmm7nnX5xVA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=OQK98qWp/1lENa6X6N98dzHtyEK5xhe6l9LbTzVHU7g=;
 b=lA7bCNs2CfJQCS5rQ0ScxnAogCc4tSlwZBHKA6mvsatbwmpLx9bf3mOUVDk9BT6stQ/vek7L/0rUI9+IKGzqBnbkqbbPvG4OpI3gAiR/gumrk9F33tCjsuU3xZANj6eu7IxfnQdPnTjhyl4kRQvcdXArOQfdTFAiBuEaJMoMH6Tc64p4/+1oMxCBxK2lIlKFc4ZeJDz+882x9cDaPeO+WKlTXQh+I5DnlAdDIlZsGfjmSxeD+QxpsCkcTsPbHvy5Vz0G/4WJUf8SvL9GfiidpXJAEnai6lYJ1r0dq3XAmWDsv0WH8sWOB8p5qetCZ9SF0/LMjLf/gFMYm8+r4FPLow==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org"
	<sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "jbeulich@suse.com" <jbeulich@suse.com>,
        Bertrand Marquis
	<bertrand.marquis@arm.com>,
        Rahul Singh <rahul.singh@arm.com>,
        Oleksandr
 Andrushchenko <Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH v3 03/11] vpci/header: Move register assignments from
 init_bars
Thread-Topic: [PATCH v3 03/11] vpci/header: Move register assignments from
 init_bars
Thread-Index: AQHXtdAhPfrDnvz+/U+T4IKIC1fCcavRBz+AgBXEsIA=
Date: Wed, 27 Oct 2021 10:17:02 +0000
Message-ID: <89e1f09e-c840-860e-e596-38fb141aa707@epam.com>
References: <20210930075223.860329-1-andr2000@gmail.com>
 <20210930075223.860329-4-andr2000@gmail.com>
 <YWbkZ216FbV8lBns@MacBook-Air-de-Roger.local>
In-Reply-To: <YWbkZ216FbV8lBns@MacBook-Air-de-Roger.local>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 4195fb99-d868-46e2-3921-08d99932eb67
x-ms-traffictypediagnostic: AM9PR03MB6769:
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <AM9PR03MB6769B9CC4B3F1BE8DAAF970EE7859@AM9PR03MB6769.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:7219;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 IARElCVdqexSeIEgEnpRJJYAelhiIZemtoZJRrS0E1mNC9G/y8BZih7ZWQhWsQSLVxyqlOQwmqdMFyvQQH+S7ohcJ2YzrFAtdt0TWef3o8ZD9kAn5EV+YtFB8b0EJ21hxw++03YM6iL6MLRIalhQu6CUcFHmVEm8hanQIN7fAPqzV9KaziOojwU5lJuEn6h0xMHas4usvFPxuoPoIDA9WyuTk8uaHexjKd1KqW2PeBecvRQJOLOWIDQaQz4QZmZSe4JdJCHTzB/OPR/xrFeil+rlCRt01bjVTmRtT/JCopgSIK6eXU5wbPf60JIOLX2DFM5r5HiKCyJgaKnMUBVim1VprYhxWNU10ei5WHt1LCH9yTbe9XBb9QuTCB3/x8b/7nTu/0MHqXs6rWmmdZ90/SewPcKjCe7gTGxy5X81wkXMCiuIjG5EiWQAFZmmvs1AAcMVY3E3zPR1UbO71cYf0WS1KH9KlpBVCtrYlZ+cCVtXZobNldGvD7pQKZe3BMyTVGoqsSOhTa48mDhOwQCO9O7BhN7qw2P4zWIsmv5JvKZOJPwuKlup5KfPGns79YfjZq2nB7oaralKPvocXDAUWW/jN7xTPN+rHmcDZu0D8NP5w57X48SuoCv1JfgS4FjU69Baoz8j94XNP+4iwk+cBNYN11d0kKI2YolKHNQgd+ZiKk2A+L42l29onK9VmWsOd0s9NetJBVTutuL1Mg9KUyiZN6g3edl4tezxKCpVL11fnYorCqf7hdEyBclnTLMb
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(122000001)(66446008)(66556008)(5660300002)(66476007)(64756008)(66946007)(38100700002)(107886003)(186003)(2616005)(4326008)(31686004)(31696002)(86362001)(71200400001)(36756003)(6916009)(6512007)(6506007)(2906002)(54906003)(316002)(53546011)(8936002)(6486002)(76116006)(91956017)(38070700005)(26005)(508600001)(8676002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?bk12Vnk0bXFqWHk3dXloa2NyT2ltSlZBWi8vSENmTzNDSHV5ZFV2QkIzd0JT?=
 =?utf-8?B?RHBPZWRYdXRqTldFSUZ5bm15REpGK0xEMXRORnFhV1BUWFJxTXNyblBIYkEz?=
 =?utf-8?B?UmtGMTZSVk55TU9WVCsvVGh5RGpNeldwcnl2OWVCL2pmSWpTR0NqNVZnc0x0?=
 =?utf-8?B?TGxRbEFHak9wTW4rNXJhZUJMZHNyVDdoOFZIYTN2MGE5bHNseEV1RW5BQnFy?=
 =?utf-8?B?OEpCOHFaSlZLQ3YweC9pVXpqMjgwYldwd2VucGlhK29BaW1weUd3azVsNUJn?=
 =?utf-8?B?RzZwK1FWSlVuOUhLVTI3emtOOEhxTm5CMXovcjhMOVM3WU1ncEZwZHNCVmcz?=
 =?utf-8?B?SXdsL2kzSitIeEMxd2FQb081eXZsUDBrZ0w0cTl0K3NGRE5DcG5FYVZPZ1c5?=
 =?utf-8?B?cWxmMWZ6LytpZ2hsQWFSZnA2ZEZ1cnp4SXdqbGpBYjFyNG52Nnd1d2VUZy9h?=
 =?utf-8?B?Q0YrVjdPd2lNZ0NoRlo0WVA1WVhCYzgxc1ZFV2JCZGxCbDU4Q05ZQ0dEQ3pW?=
 =?utf-8?B?Yzl0TUZCWmRjVDJnTDM1VWRkM2k5YUQ3M3FhSFBmY2dsdHZaWFBBZVgvMFpC?=
 =?utf-8?B?d2xGQ2V4REVLQWRMVE5nZzArcjZEWnhDMHNFSnZMTW8vVkJQTGFQYlZWelJP?=
 =?utf-8?B?dHFZN0FFdHh1R3lxVUlYK0V1akMrVkpIV29iN3o0TDlCNTFDSnUzdkdsaDUy?=
 =?utf-8?B?TUduWTFwK2JQOUczRmRIY0VnakdjZGloWFRXeUxrMkxYSDNCODRUNW5qUmZD?=
 =?utf-8?B?dG90S0VCRnVtU29Jc2ZKUnFsUXhLeURXUGlIMmpCY2p3L2ZSSFhBVUhIUG40?=
 =?utf-8?B?MWZGY2hMc2VVaVdsc1JGa0kxVU03NkVXQzJ2MU1leVBubHQ0OGlsRTRGTWVx?=
 =?utf-8?B?Y1VRMTg4elNERWNaYTJFS3g0eFRwYVIzdG00TThSWitKRnU0Y0ZyT05qcDlN?=
 =?utf-8?B?N2lmU1R4VkhlVjgxQkpKWXNPczRoQ2loVE5oeU9JS1lnbGlOd2FyMlA2VE9V?=
 =?utf-8?B?ZlQyYVlCZnI3VnY1d0RZSTFFaEhrT21CSUNWRHdGTDY1VFlxOStSY0gvVDdv?=
 =?utf-8?B?MHNJOW54RXFwbjJCWUJiWGhoa01tUG5scjQ2SHpGM0ljRzF6T1U2SHh0dTFW?=
 =?utf-8?B?ODU4dC9zRUhCT2dZWkR3S0ZRUVdpMUZXWHJDelNWeHdZR1BlNVFISmw3K0RY?=
 =?utf-8?B?SzBhdTFiclRCazRDSzM3d2NwN0dsdnQ1czBOd0p2S1duRUFqZ0NtenNpOTc2?=
 =?utf-8?B?OE1NTFBLVWFRQU1wWEdUS3hhNlN5SG1DdUYyL1p0bUpvTGRyUTNSa0JXZU5S?=
 =?utf-8?B?d2pWKzNtZVoraXhnbVBNa3lzMFUzTU9IZGM4NnZKNnY4NVQvc0t4NjNaZXp2?=
 =?utf-8?B?R0QxV0pLUWdXVms3YjB4czJVbGlRTGZza3FlTGRVb3JZMFBhcnlsTklHVjFP?=
 =?utf-8?B?OHQvbzRHeGt3MHFoYlFPWmhaSlFsb01ZdW45Tys5M3FUcTVXUExJYTVLeCt1?=
 =?utf-8?B?d0srRkdiVXJzcjRNVWhXc050SzRGbm1TNFE2SDRWUjBHZ2dnZkZVUWo3UFRl?=
 =?utf-8?B?UnJnM3NkQXQ2Q3ZTVjFKTENDWG1uZmFxb2g0cXhKazVwa1NsTDN4d05MTDcw?=
 =?utf-8?B?NzF5UE5qdERnc2o4TFQvWWkrMmxnWXprT0o3bWdrVVVPdTEwREJ4a2Z6cUlD?=
 =?utf-8?B?QnQvc3puUFY5ZU95T0tTWlN2SXJxZnN0Y3BsREJWMDJnaHFSREJVZFU0MGxF?=
 =?utf-8?B?MDQxd0RmMENrb21CVk5LcFpjUE85U2tiOFpvS1Z6SWZVZ05hMkFKb2VXQytw?=
 =?utf-8?B?VFdtZkZIUHhueG96a1FLbkhRcDZFNktUS1MrQjRxQmVRY0ltaEdTYWhjc05n?=
 =?utf-8?B?RWx1cWFWWUZ2ZWE3eitJTnl0ZW1pSXYxSlRNNGhoWUNWSjl3RlJqMFljdmc3?=
 =?utf-8?B?SzB6eUcxZm1lVU12dTdPYk9BalgycHNhQWVUZm5XblBSUmhqMVhHalR4ZDhy?=
 =?utf-8?B?a0UrdzFRYjA1M21GUzhyWnBNWm8rbVo3dC9pL0dXUXNwNkVvTjhudHNDRzVF?=
 =?utf-8?B?OFByN1N4THJrS0VBSzF0VlRpWEkyVTIxNVRDc0J4ejFURFNhRUwzdmtyTkRz?=
 =?utf-8?B?bWJ5SGozZ0huU2NEU2lBSHkvaWdyVHRrbnhGZFBQK1R2M2dObFhOL3BMN2s1?=
 =?utf-8?B?eUZ6aXVySmhHRzdXdU5EOUx0aFFralkyQ1paMjdzZDFsUDl5bklQWkM1WlAy?=
 =?utf-8?B?Uy9kZXQzeHhTckN6eERnc0V5aXVncno0c3FZUjRqaWdsYXNOd2JvL01POUhX?=
 =?utf-8?B?QzVEUTdBRkRwSUdHWVcrVmlzNUc1ZEkxUGVmVUtRSFlRTHA2WWdsUT09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <54F4998B51A8AA44B688E3E83E82411B@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4195fb99-d868-46e2-3921-08d99932eb67
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Oct 2021 10:17:02.4848
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: pXHCWwNWVRn4lnypKapzTqq8JNcJM8nSec8in/TwvZFCtTLyjIS4wG1ru2HdOy7eF3aQOkDWLk57dPhNPTmYzoVrfapElhdvFmkOIQVt/ncwsJtkwUnk/cewq4OCWI3f
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR03MB6769
X-Proofpoint-ORIG-GUID: pbdVdSAx3MuomTobX_2Gw_Pqq_Z0lcjZ
X-Proofpoint-GUID: pbdVdSAx3MuomTobX_2Gw_Pqq_Z0lcjZ
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475
 definitions=2021-10-27_03,2021-10-26_01,2020-04-07_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 mlxscore=0
 bulkscore=0 impostorscore=0 phishscore=0 clxscore=1015 spamscore=0
 malwarescore=0 lowpriorityscore=0 mlxlogscore=999 adultscore=0
 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2110270063

SGksIFJvZ2VyIQ0KDQpPbiAxMy4xMC4yMSAxNjo1MSwgUm9nZXIgUGF1IE1vbm7DqSB3cm90ZToN
Cj4gT24gVGh1LCBTZXAgMzAsIDIwMjEgYXQgMTA6NTI6MTVBTSArMDMwMCwgT2xla3NhbmRyIEFu
ZHJ1c2hjaGVua28gd3JvdGU6DQo+PiBGcm9tOiBPbGVrc2FuZHIgQW5kcnVzaGNoZW5rbyA8b2xl
a3NhbmRyX2FuZHJ1c2hjaGVua29AZXBhbS5jb20+DQo+Pg0KPj4gVGhpcyBpcyBpbiBwcmVwYXJh
dGlvbiBmb3IgZHluYW1pYyBhc3NpZ25tZW50IG9mIHRoZSB2UENJIHJlZ2lzdGVyDQo+PiBoYW5k
bGVycyBkZXBlbmRpbmcgb24gdGhlIGRvbWFpbjogaHdkb20gb3IgZ3Vlc3QuDQo+PiBUaGUgbmVl
ZCBmb3IgdGhpcyBzdGVwIGlzIHRoYXQgaXQgaXMgZWFzaWVyIHRvIGhhdmUgYWxsIHJlbGF0ZWQg
ZnVuY3Rpb25hbGl0eQ0KPj4gcHV0IGF0IG9uZSBwbGFjZS4gV2hlbiB0aGUgc3Vic2VxdWVudCBw
YXRjaGVzIGFkZCBkZWNpc2lvbnMgb24gd2hpY2gNCj4+IGhhbmRsZXJzIHRvIGluc3RhbGwsIGUu
Zy4gaHdkb20gb3IgZ3Vlc3QgaGFuZGxlcnMsIHRoZW4gdGhpcyBpcyBlYXNpbHkNCj4+IGFjaGll
dmFibGUuDQo+IFdvbid0IGl0IGJlIHBvc3NpYmxlIHRvIHNlbGVjdCB0aGUgaGFuZGxlcnMgdG8g
aW5zdGFsbCBpbiBpbml0X2JhcnMNCj4gaXRzZWxmPw0KSXQgaXMgcG9zc2libGUNCj4NCj4gU3Bs
aXR0aW5nIGl0IGxpa2UgdGhhdCBtZWFucyB5b3UgbmVlZCB0byBpdGVyYXRlIG92ZXIgdGhlIG51
bWJlcnMgb2YNCj4gQkFScyB0d2ljZSAob25lIGluIGFkZF9iYXJfaGFuZGxlcnMgYW5kIG9uZSBp
biBpbml0X2JhcnMpLCB3aGljaCBtYWtlcw0KPiBpdCBtb3JlIGxpa2VseSB0byBpbnRyb2R1Y2Ug
ZXJyb3JzIG9yIGRpdmVyZ2VuY2VzLg0KPg0KPiBEZWNvdXBsaW5nIHRoZSBmaWxsaW5nIG9mIHZw
Y2lfYmFyIGRhdGEgd2l0aCBzZXR0aW5nIHRoZSBoYW5kbGVycw0KPiBzZWVtcyBzbGlnaHRseSBj
b25mdXNpbmcuDQpPaywgSSB3b24ndCBpbnRyb2R1Y2UgYWRkX2Jhcl9oYW5kbGVycywgdGh1cyBy
ZW5kZXJpbmcgdGhpcyBwYXRjaCB1c2VsZXNzLg0KSSdsbCBkcm9wIGl0IGFuZCByZS13b3JrIHRo
ZSB1cGNvbWluZyBwYXRjaGVzIHdpdGggdGhpcyByZXNwZWN0DQoNClRoYW5rIHlvdSwNCk9sZWtz
YW5kcg==


From xen-devel-bounces@lists.xenproject.org Wed Oct 27 10:42:07 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Oct 2021 10:42:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.216872.376638 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfgNQ-0002Zg-6u; Wed, 27 Oct 2021 10:41:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 216872.376638; Wed, 27 Oct 2021 10:41:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfgNQ-0002ZZ-3t; Wed, 27 Oct 2021 10:41:48 +0000
Received: by outflank-mailman (input) for mailman id 216872;
 Wed, 27 Oct 2021 10:41:47 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=gtXy=PP=arm.com=michal.orzel@srs-us1.protection.inumbo.net>)
 id 1mfgNP-0002ZT-3q
 for xen-devel@lists.xenproject.org; Wed, 27 Oct 2021 10:41:47 +0000
Received: from foss.arm.com (unknown [217.140.110.172])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTP
 id 7f93e34e-ad61-4b4e-9ef8-7e4fd39633f7;
 Wed, 27 Oct 2021 10:41:44 +0000 (UTC)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 10CE81FB;
 Wed, 27 Oct 2021 03:41:44 -0700 (PDT)
Received: from [10.57.26.24] (unknown [10.57.26.24])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id AF5573F70D;
 Wed, 27 Oct 2021 03:41:42 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7f93e34e-ad61-4b4e-9ef8-7e4fd39633f7
Subject: Re: [patch-4.16] arm/smmuv1,v2: Protect smmu master list with a lock
To: Julien Grall <julien@xen.org>, xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, bertrand.marquis@arm.com,
 Ian Jackson <iwj@xenproject.org>
References: <20211026122903.15042-1-michal.orzel@arm.com>
 <e5632a4e-db98-41b4-1045-2b3532c098fa@xen.org>
 <70c30a6c-b779-805e-079a-41bb484894b9@xen.org>
From: Michal Orzel <michal.orzel@arm.com>
Message-ID: <cb452c0c-ccde-7798-c403-f972b48a2c46@arm.com>
Date: Wed, 27 Oct 2021 12:41:31 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <70c30a6c-b779-805e-079a-41bb484894b9@xen.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit

Hi Julien,

On 26.10.2021 18:56, Julien Grall wrote:
> Hi,
> 
> On 26/10/2021 17:28, Julien Grall wrote:
>> On 26/10/2021 13:29, Michal Orzel wrote:
>>> If a device is added to SMMUv1/v2 from DT and PCI
>>> at the same time, there is a concurrent access
>>> to a smmu master list. This could lead to a
>>> scenario where one is looking into a list that
>>> is being modified at the same time. Add a lock
>>> to prevent this issue.
>>
>> Did you intend to say "Hold" rather than "Add"?
>>
Yes, this is what I meant. I will change it.

>>>
>>> Reuse the existing spinlock arm_smmu_devices_lock
>>> as it is already protecting find_smmu_master.
>>>
>>> ipmmu-smmu and smmuv3 are not impacted by this
>>> issue as there is no access or modification of
>>> a global resource during add_device.
>>>
>>> Signed-off-by: Michal Orzel <michal.orzel@arm.com>
>>> ---
>>> This patch aims for 4.16 release.
>>> Benefits:
>>> Remove a bug that could lead to a corruption of the
>>> smmu master list, which would be very hard to debug.
>>
>>  From my understanding, this corruption would only happen with CONFIG_HAS_PCI. At the moment, this is a experimental feature as it is not fully complete.
> 
> Actually, digging through the code, I noticed that iommu_add_device() assume that it can only be called with platform/DT. Thankfully, AFAICT, the function would return -ENXIO because the fwspec would not be allocated for PCI device.
> 
> So was this patch tested with additional patch on top?
> 
The purpose of this patch is to fix the issue that is present and which you thankfully noticed.
There is still a lot of patches to be added that aim to support PCI passthrough.
The complete PCI series is tested with SMMU and it works.
But there is no chance to test this patch standalone as iommu_add_device is not in the correct form for PCI as of now.

>>
>>> Risks:
>>> Overall the risk is low as we are touching init code
>>> rather than a runtime one. In case of any issue, the
>>> problem would be catched during system boot or guest
>>> start.
>>
>> With the PCI feature enabled, this can be called at runtime as this plumbed through a PHYSDEVOP. That said, it doesn't matter here as for supported code (platform/DT device), this will only happen during boot.
>>
>> The patch looks straighforward, so I would not mind to have it in Xen 4.16. Ian, what do you think?
>>
>>> ---
>>>   xen/drivers/passthrough/arm/smmu.c | 25 +++++++++++++++++++------
>>>   1 file changed, 19 insertions(+), 6 deletions(-)
>>>
>>> diff --git a/xen/drivers/passthrough/arm/smmu.c b/xen/drivers/passthrough/arm/smmu.c
>>> index c9dfc4caa0..be62a66a28 100644
>>> --- a/xen/drivers/passthrough/arm/smmu.c
>>> +++ b/xen/drivers/passthrough/arm/smmu.c
>>> @@ -820,21 +820,25 @@ static int arm_smmu_dt_add_device_legacy(struct arm_smmu_device *smmu,
>>>                        struct device *dev,
>>>                        struct iommu_fwspec *fwspec)
>>>   {
>>> -    int i;
>>> +    int i, ret;
>>>       struct arm_smmu_master *master;
>>>       struct device_node *dev_node = dev_get_dev_node(dev);
>>> +    spin_lock(&arm_smmu_devices_lock);
>>>       master = find_smmu_master(smmu, dev_node);
>>>       if (master) {
>>>           dev_err(dev,
>>>               "rejecting multiple registrations for master device %s\n",
>>>               dev_node->name);
>>> -        return -EBUSY;
>>> +        ret = -EBUSY;
>>> +        goto out_unlock;
>>>       }
>>>       master = devm_kzalloc(dev, sizeof(*master), GFP_KERNEL);
>>> -    if (!master)
>>> -        return -ENOMEM;
>>> +    if (!master) {
>>> +        ret = -ENOMEM;
>>> +        goto out_unlock;
>>> +    }
>>>       master->of_node = dev_node;
>>>       /* Xen: Let Xen know that the device is protected by an SMMU */
>>> @@ -846,11 +850,17 @@ static int arm_smmu_dt_add_device_legacy(struct arm_smmu_device *smmu,
>>>               dev_err(dev,
>>>                   "stream ID for master device %s greater than maximum allowed (%d)\n",
>>>                   dev_node->name, smmu->num_mapping_groups);
>>> -            return -ERANGE;
>>> +            ret = -ERANGE;
>>> +            goto out_unlock;
>>>           }
>>>           master->cfg.smendx[i] = INVALID_SMENDX;
>>>       }
>>> -    return insert_smmu_master(smmu, master);
>>> +
>>> +    ret = insert_smmu_master(smmu, master);
>>> +
>>> +out_unlock:
>>> +    spin_unlock(&arm_smmu_devices_lock);
>>
>> Please add a newline here.
>>
Ok.

>>> +    return ret;
>>>   }
>>>   static int register_smmu_master(struct arm_smmu_device *smmu,
>>> @@ -2056,7 +2066,10 @@ static int arm_smmu_add_device(struct device *dev)
>>>       } else {
>>>           struct arm_smmu_master *master;
>>> +        spin_lock(&arm_smmu_devices_lock);
>>>           master = find_smmu_master(smmu, dev->of_node);
>>> +        spin_unlock(&arm_smmu_devices_lock);
>>
>> At the moment, unlocking here is fine because we don't remove the device. However, there are a series to supporting removing a device (see [1]). So I think it would be preferable to unlock after the last use of 'cfg'.
>>
Ok. I will move unlocking to the end of this else {} block. I was not aware of the patch you are referring to.

>> Looking at the code, I also noticed that the error path is not correct for at least the PCI device and we would leak memory. We also assume that Stream ID == Requester ID. Are both of them in your radar for PCI passthrough?
>>
I agree with you. I also noticed it. However this is going to be fixed with the next patch series when Rahul gets back.

>> Cheers,
>>
>> [1] https://lore.kernel.org/xen-devel/1630562763-390068-9-git-send-email-fnu.vikram@xilinx.com/
>>
> 
> Cheers,
>
Cheers,
Michal


From xen-devel-bounces@lists.xenproject.org Wed Oct 27 11:34:55 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Oct 2021 11:34:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.216885.376656 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfhCZ-0007lS-94; Wed, 27 Oct 2021 11:34:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 216885.376656; Wed, 27 Oct 2021 11:34:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfhCZ-0007lL-68; Wed, 27 Oct 2021 11:34:39 +0000
Received: by outflank-mailman (input) for mailman id 216885;
 Wed, 27 Oct 2021 11:34:38 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mfhCY-0007lB-7B; Wed, 27 Oct 2021 11:34:38 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mfhCX-0002Ae-Vb; Wed, 27 Oct 2021 11:34:38 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mfhCX-0004yv-Mm; Wed, 27 Oct 2021 11:34:37 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mfhCX-00087W-ML; Wed, 27 Oct 2021 11:34:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=ryIAPIycL962Qdo9SRtvPAUFp5FQ2oCjSI3lnx73tW8=; b=1m2DDl7UFnsl+MXaq/rJpIdVP0
	TyLqMiNgHEWSIed+7ZHluSPjlzDmgZ6gJTahCxF6f73GkY34Ak6q/Aj5bVNia8qHtOlgHlkrJPrW2
	rtupw1k4AbuFNuU0dKaXDYNcPpb32+s3h0D8DMWeWuTbWstOjpSbiJjMZIMhfjWniWXA=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165890-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 165890: regressions - FAIL
X-Osstest-Failures:
    libvirt:build-armhf-libvirt:libvirt-build:fail:regression
    libvirt:build-amd64-libvirt:libvirt-build:fail:regression
    libvirt:build-i386-libvirt:libvirt-build:fail:regression
    libvirt:build-arm64-libvirt:libvirt-build:fail:regression
    libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    libvirt=775de86975bd36134e31eea68bf4bac8677ccc88
X-Osstest-Versions-That:
    libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 27 Oct 2021 11:34:37 +0000

flight 165890 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165890/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-armhf-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-amd64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-i386-libvirt            6 libvirt-build            fail REGR. vs. 151777
 build-arm64-libvirt           6 libvirt-build            fail REGR. vs. 151777

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-libvirt-vhd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a

version targeted for testing:
 libvirt              775de86975bd36134e31eea68bf4bac8677ccc88
baseline version:
 libvirt              2c846fa6bcc11929c9fb857a22430fb9945654ad

Last test of basis   151777  2020-07-10 04:19:19 Z  474 days
Failing since        151818  2020-07-11 04:18:52 Z  473 days  459 attempts
Testing same since   165890  2021-10-27 04:19:21 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
    Adolfo Jayme Barrientos <fitoschido@gmail.com>
  Aleksandr Alekseev <alexander.alekseev@virtuozzo.com>
  Aleksei Zakharov <zaharov@selectel.ru>
  Andika Triwidada <andika@gmail.com>
  Andrea Bolognani <abologna@redhat.com>
  Ani Sinha <ani@anisinha.ca>
  Balázs Meskó <meskobalazs@mailbox.org>
  Barrett Schonefeld <bschoney@utexas.edu>
  Bastian Germann <bastiangermann@fishpost.de>
  Bastien Orivel <bastien.orivel@diateam.net>
  BiaoXiang Ye <yebiaoxiang@huawei.com>
  Bihong Yu <yubihong@huawei.com>
  Binfeng Wu <wubinfeng@huawei.com>
  Bjoern Walk <bwalk@linux.ibm.com>
  Boris Fiuczynski <fiuczy@linux.ibm.com>
  Brian Turek <brian.turek@gmail.com>
  Bruno Haible <bruno@clisp.org>
  Chris Mayo <aklhfex@gmail.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Ehrhardt <christian.ehrhardt@canonical.com>
  Christian Kirbach <christian.kirbach@gmail.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Cole Robinson <crobinso@redhat.com>
  Collin Walling <walling@linux.ibm.com>
  Cornelia Huck <cohuck@redhat.com>
  Cédric Bosdonnat <cbosdonnat@suse.com>
  Côme Borsoi <fedora@borsoi.fr>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniel Letai <dani@letai.org.il>
  Daniel P. Berrange <berrange@redhat.com>
  Daniel P. Berrangé <berrange@redhat.com>
  Didik Supriadi <didiksupriadi41@gmail.com>
  dinglimin <dinglimin@cmss.chinamobile.com>
  Dmitrii Shcherbakov <dmitrii.shcherbakov@canonical.com>
  Dmytro Linkin <dlinkin@nvidia.com>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Eric Farman <farman@linux.ibm.com>
  Erik Skultety <eskultet@redhat.com>
  Fabian Affolter <mail@fabian-affolter.ch>
  Fabian Freyer <fabian.freyer@physik.tu-berlin.de>
  Fabiano Fidêncio <fabiano@fidencio.org>
  Fangge Jin <fjin@redhat.com>
  Farhan Ali <alifm@linux.ibm.com>
  Fedora Weblate Translation <i18n@lists.fedoraproject.org>
  Franck Ridel <fridel@protonmail.com>
  Gavi Teitz <gavi@nvidia.com>
  gongwei <gongwei@smartx.com>
  Guoyi Tu<tu.guoyi@h3c.com>
  Göran Uddeborg <goeran@uddeborg.se>
  Halil Pasic <pasic@linux.ibm.com>
  Han Han <hhan@redhat.com>
  Hao Wang <wanghao232@huawei.com>
  Hela Basa <r45xveza@pm.me>
  Helmut Grohne <helmut@subdivi.de>
  Hiroki Narukawa <hnarukaw@yahoo-corp.jp>
  Ian Wienand <iwienand@redhat.com>
  Jakob Meng <jakobmeng@web.de>
  Jamie Strandboge <jamie@canonical.com>
  Jamie Strandboge <jamie@ubuntu.com>
  Jan Kuparinen <copper_fin@hotmail.com>
  jason lee <ppark5237@gmail.com>
  Jean-Baptiste Holcroft <jean-baptiste@holcroft.fr>
  Jia Zhou <zhou.jia2@zte.com.cn>
  Jianan Gao <jgao@redhat.com>
  Jim Fehlig <jfehlig@suse.com>
  Jin Yan <jinyan12@huawei.com>
  Jinsheng Zhang <zhangjl02@inspur.com>
  Jiri Denemark <jdenemar@redhat.com>
  John Ferlan <jferlan@redhat.com>
  Jonathan Watt <jwatt@jwatt.org>
  Jonathon Jongsma <jjongsma@redhat.com>
  Julio Faracco <jcfaracco@gmail.com>
  Justin Gatzen <justin.gatzen@gmail.com>
  Ján Tomko <jtomko@redhat.com>
  Kashyap Chamarthy <kchamart@redhat.com>
  Kevin Locke <kevin@kevinlocke.name>
  Kristina Hanicova <khanicov@redhat.com>
  Laine Stump <laine@redhat.com>
  Laszlo Ersek <lersek@redhat.com>
  Lee Yarwood <lyarwood@redhat.com>
  Lei Yang <yanglei209@huawei.com>
  Liao Pingfang <liao.pingfang@zte.com.cn>
  Lin Ma <lma@suse.com>
  Lin Ma <lma@suse.de>
  Lin Ma <morecache@gmail.com>
  Liu Yiding <liuyd.fnst@fujitsu.com>
  Luke Yue <lukedyue@gmail.com>
  Luyao Zhong <luyao.zhong@intel.com>
  Marc Hartmayer <mhartmay@linux.ibm.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Markus Schade <markus.schade@hetzner.com>
  Martin Kletzander <mkletzan@redhat.com>
  Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
  Matej Cepl <mcepl@cepl.eu>
  Matt Coleman <matt@datto.com>
  Matt Coleman <mcoleman@datto.com>
  Mauro Matteo Cascella <mcascell@redhat.com>
  Meina Li <meili@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Michał Smyk <fedora@smyk.it>
  Milo Casagrande <milo@milo.name>
  Moshe Levi <moshele@nvidia.com>
  Muha Aliss <muhaaliss@gmail.com>
  Nathan <nathan95@live.it>
  Neal Gompa <ngompa13@gmail.com>
  Nick Chevsky <nchevsky@gmail.com>
  Nick Shyrokovskiy <nshyrokovskiy@gmail.com>
  Nickys Music Group <nickys.music.group@gmail.com>
  Nico Pache <npache@redhat.com>
  Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
  Olaf Hering <olaf@aepfle.de>
  Olesya Gerasimenko <gammaray@basealt.ru>
  Or Ozeri <oro@il.ibm.com>
  Orion Poplawski <orion@nwra.com>
  Pany <geekpany@gmail.com>
  Patrick Magauran <patmagauran.j@gmail.com>
  Paulo de Rezende Pinatti <ppinatti@linux.ibm.com>
  Pavel Hrdina <phrdina@redhat.com>
  Peng Liang <liangpeng10@huawei.com>
  Peter Krempa <pkrempa@redhat.com>
  Pino Toscano <ptoscano@redhat.com>
  Pino Toscano <toscano.pino@tiscali.it>
  Piotr Drąg <piotrdrag@gmail.com>
  Prathamesh Chavan <pc44800@gmail.com>
  Praveen K Paladugu <prapal@linux.microsoft.com>
  Richard W.M. Jones <rjones@redhat.com>
  Ricky Tigg <ricky.tigg@gmail.com>
  Robin Lee <cheeselee@fedoraproject.org>
  Roman Bogorodskiy <bogorodskiy@gmail.com>
  Roman Bolshakov <r.bolshakov@yadro.com>
  Ryan Gahagan <rgahagan@cs.utexas.edu>
  Ryan Schmidt <git@ryandesign.com>
  Sam Hartman <hartmans@debian.org>
  Scott Shambarger <scott-libvirt@shambarger.net>
  Sebastian Mitterle <smitterl@redhat.com>
  SeongHyun Jo <caelus9536@gmail.com>
  Shalini Chellathurai Saroja <shalini@linux.ibm.com>
  Shaojun Yang <yangshaojun@phytium.com.cn>
  Shi Lei <shi_lei@massclouds.com>
  simmon <simmon@nplob.com>
  Simon Chopin <chopin.simon@gmail.com>
  Simon Gaiser <simon@invisiblethingslab.com>
  Simon Rowe <simon.rowe@nutanix.com>
  Stefan Bader <stefan.bader@canonical.com>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Berger <stefanb@linux.vnet.ibm.com>
  Stefan Hajnoczi <stefanha@gmail.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Szymon Scholz <szymonscholz@gmail.com>
  Thomas Huth <thuth@redhat.com>
  Tim Wiederhake <twiederh@redhat.com>
  Tomáš Golembiovský <tgolembi@redhat.com>
  Tomáš Janoušek <tomi@nomi.cz>
  Tuguoyi <tu.guoyi@h3c.com>
  Victor Toso <victortoso@redhat.com>
  Ville Skyttä <ville.skytta@iki.fi>
  Vinayak Kale <vkale@nvidia.com>
  Wang Xin <wangxinxin.wang@huawei.com>
  WangJian <wangjian161@huawei.com>
  Weblate <noreply@weblate.org>
  Wei Liu <liuwe@microsoft.com>
  Wei Liu <wei.liu@kernel.org>
  Wei-Chen Chen <weicche@microsoft.com>
  William Douglas <william.douglas@intel.com>
  Yalei Li <274268859@qq.com>
  Yalei Li <liyl43@chinatelecom.cn>
  Yang Fei <yangfei85@huawei.com>
  Yang Hang <yanghang44@huawei.com>
  Yanqiu Zhang <yanqzhan@redhat.com>
  Yaroslav Kargin <ykargin@virtuozzo.com>
  Yi Li <yili@winhong.com>
  Yi Wang <wang.yi59@zte.com.cn>
  Yuri Chornoivan <yurchor@ukr.net>
  Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
  zhangjl02 <zhangjl02@inspur.com>
  Zheng Chuan <zhengchuan@huawei.com>
  zhenwei pi <pizhenwei@bytedance.com>
  Zhenyu Ye <yezhenyu2@huawei.com>
  Zhenyu Zheng <zheng.zhenyu@outlook.com>
  Zhenzhong Duan <zhenzhong.duan@intel.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          fail    
 build-arm64-libvirt                                          fail    
 build-armhf-libvirt                                          fail    
 build-i386-libvirt                                           fail    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           blocked 
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-libvirt-xsm                                 blocked 
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-libvirt                                     blocked 
 test-arm64-arm64-libvirt                                     blocked 
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-libvirt-pair                                blocked 
 test-amd64-i386-libvirt-pair                                 blocked 
 test-arm64-arm64-libvirt-qcow2                               blocked 
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-libvirt-vhd                                 blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 81133 lines long.)


From xen-devel-bounces@lists.xenproject.org Wed Oct 27 12:00:10 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Oct 2021 12:00:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.216893.376670 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfhb1-0001qY-Bz; Wed, 27 Oct 2021 11:59:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 216893.376670; Wed, 27 Oct 2021 11:59:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfhb1-0001qR-8S; Wed, 27 Oct 2021 11:59:55 +0000
Received: by outflank-mailman (input) for mailman id 216893;
 Wed, 27 Oct 2021 11:59:54 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=8lYk=PP=epam.com=prvs=0934bd4bd6=oleksandr_andrushchenko@srs-us1.protection.inumbo.net>)
 id 1mfhb0-0001qL-EK
 for xen-devel@lists.xenproject.org; Wed, 27 Oct 2021 11:59:54 +0000
Received: from mx0a-0039f301.pphosted.com (unknown [148.163.133.242])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 6457da7c-371d-11ec-845d-12813bfff9fa;
 Wed, 27 Oct 2021 11:59:52 +0000 (UTC)
Received: from pps.filterd (m0174678.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 19RBScMp005785; 
 Wed, 27 Oct 2021 11:59:50 GMT
Received: from eur02-am5-obe.outbound.protection.outlook.com
 (mail-am5eur02lp2058.outbound.protection.outlook.com [104.47.4.58])
 by mx0a-0039f301.pphosted.com with ESMTP id 3by4rqgu1x-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Wed, 27 Oct 2021 11:59:50 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by AM9PR03MB7345.eurprd03.prod.outlook.com (2603:10a6:20b:273::7)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.14; Wed, 27 Oct
 2021 11:59:47 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::c038:e032:595a:651]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::c038:e032:595a:651%9]) with mapi id 15.20.4649.014; Wed, 27 Oct 2021
 11:59:47 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6457da7c-371d-11ec-845d-12813bfff9fa
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ZtFs1gb8NzeI54Ehulow8bilsGvy5apcZzfqatu8sBRs15PLSWpomx17M5VO/0ctPHHmGbpqYTkL1Jo2XlUc4QQlHh9YUC4HVO4a3oYZsEzvpih7C4/lmjYUyoKLs3of9UIRaAHUs4f5OlCkssTKPUe1W1FlIxVsa4uu0gPxRShEqSEu7nMLnlZWVSkRKsYtEzzUpjDHDDd3waOjrG58BpfXPySg1kkTodSUe09uJPxFlp6AoDUIyqMdM2XINRNM7wccTuPbj/lJ4sN0arm/VWRGeXXPVRgQLvCc+JaYsKjIM5NSx8PrI/tVNhDtr4FkoBOrmH7H2f4ijb5UzRkvbw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=TwtKAD/U7xJJJxkyj6ijJDX5fvDJUHshCauM3+qbnU0=;
 b=NoIK7LFam+4JwH5nMs5co3HXWySffmiE96hWg5NYKhSglZQRIJxlw22QkQVUN/TZrCp8fS+gPhM+VvorxK9l4PHRrmWgrOHdL3kCrQV6kGS/BqzHaneEj5BpvpcR+jyOv4pxC+Hi1hDZy+e1ORJe8tnUxGmnixcxDNErE/kbBqZ81cb5dyAgMB7cDSUM+e38coYozhL9nT/C9d/5WxJyqvmqGqiNzpCTonN9VaaS90hcsRId6Be6cDswIIq1UkU4G9g+tBgLY3sCHJH6MWkpcM4ZvP1oWJyySUWRnk5fDj4unfReZhNGc//ud8UcHEkeiKHn20fzjY+8EUli6JeUrg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=TwtKAD/U7xJJJxkyj6ijJDX5fvDJUHshCauM3+qbnU0=;
 b=OqmoZFwD3ZlOctbh6R4YkiUYsBAve6Io7U5mfy979f8L+qnCSb1+qA1NpqBwLTAaPYFq05b35fmbdk30+A67+ZS4suVLHhxHUpnwd88oFcvtANg2Ula6HUKBvpiA+GW8Ru82SkHyRojndgFD+id+b3SqH9hnZsBc0gwNQY8VhHd6sFDGZ9g7kWGtAMhtqUXeQoRQiqWkmTmQNTFYYIisoCjF0nS3y6aC5aikBEICPo121UmT2zCXMf7kW4/LqFIt0VvyEXKHnL08vygNt4OeekbYfzlK0wfl6SGLiZ1EiX+bMX2CS9AcFUftEIR6yUoHmAilA6ZUD0gzJdUrFwl1bg==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org"
	<sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "jbeulich@suse.com" <jbeulich@suse.com>,
        Bertrand Marquis
	<bertrand.marquis@arm.com>,
        Rahul Singh <rahul.singh@arm.com>,
        Oleksandr
 Andrushchenko <Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH v3 03/11] vpci/header: Move register assignments from
 init_bars
Thread-Topic: [PATCH v3 03/11] vpci/header: Move register assignments from
 init_bars
Thread-Index: AQHXtdAhPfrDnvz+/U+T4IKIC1fCcavRBz+AgBXEsICAABy1AA==
Date: Wed, 27 Oct 2021 11:59:47 +0000
Message-ID: <344cf880-8f76-1a71-d27c-e7ba10459d5b@epam.com>
References: <20210930075223.860329-1-andr2000@gmail.com>
 <20210930075223.860329-4-andr2000@gmail.com>
 <YWbkZ216FbV8lBns@MacBook-Air-de-Roger.local>
 <89e1f09e-c840-860e-e596-38fb141aa707@epam.com>
In-Reply-To: <89e1f09e-c840-860e-e596-38fb141aa707@epam.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: af438979-ccae-405e-e765-08d9994145f4
x-ms-traffictypediagnostic: AM9PR03MB7345:
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <AM9PR03MB7345D37373DF1AE667D16C4AE7859@AM9PR03MB7345.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:8273;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 ihE73+xfZDCiRMr79UUu/N8Zhwz8/3esnVke6qP70gphBNSNgPh7HdC0Aecv4buRI4WXWCi2ySn5OaVkN3OSrQGIEOoIhO4XKnNID3vtdjDmdnTJPTktwjI4aEBDlzRi+qYlrWvubAAUWSc4ekL9Co0+msLsKV1zpv2GFj880bAvEIGu6eRUz4QEug6Dr3IQ6mNmCGSjvZIAAnGHEXoC3n0IzL1u4YOHYji1WIxQc3vBkxg1smWfidcfg2vnLAes7An5vqX2KnGsS8HCKofnD+PLxyQkvIm+XvvSdYbCukTNxyCy5j/5M6PLIeMFlmtZ9H31dMkM/hMr8x0EpXLtZexEJbPBxntPjPK/m9Uhm/LGZCg0wNRdUflT2n4VnRwjgUaen++LLfqxXTYPQ9yLM1MBIuTtD4w/i3H7L2i04ahjDPkpyg77XEK3RLd1xLVM3hQmZ1RgS/3GKpN+Ixo9R+i3LMOircVzG6dLeekfCV3iRQE7GyZbARwS8TSk26I9X43H2CyLiLjpffUexwPtoZGJA3VHHoJzx0ewt998WH2sx0L1j3mHlWBgruSbkifAfg0WLxm8Vl6r30bTHqBUmukWh9fXVrS4ubSy4ASls8o2pvCXdbujJL8GQsYRkPpSf7aQiuXPsuK5P69kBFAMSSrPAJnDQ6fmt0v2tyH72ZIRgGJhENTaTmEe0TgyZDoCjIkS4GQvEMnQyQ6yqWG+GWCTkpdggUG5/7xbK2LCo5hclQcMKoTCzCir6yiSohOa
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(316002)(38100700002)(8936002)(54906003)(6512007)(8676002)(83380400001)(26005)(2906002)(31696002)(6916009)(6486002)(107886003)(36756003)(508600001)(2616005)(5660300002)(66946007)(66446008)(66476007)(64756008)(4326008)(122000001)(66556008)(86362001)(186003)(31686004)(38070700005)(71200400001)(53546011)(91956017)(6506007)(76116006)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?L3ZOelBLTjBiR01jN2VRQlV5Y2RwNnN6SjNlMEh5Y1hmU0toMTlmaVZnemcv?=
 =?utf-8?B?OUV2UktxT3YzaDlnVVQyOE9jQ3JPMUdMWGJhTzBsNmpFSU5WQUtlN2t1YzN1?=
 =?utf-8?B?SGt0TkNTSkpiWkxvWGxuVWlYT1lXVUtrTjhGUjVaQTFBS2lOYU51T21yY2Ur?=
 =?utf-8?B?WjgvUW42VmtTRUhFcDc4WXJHYklURjAxVmVvQzZHczFTVThPTFhJU2RSNHpF?=
 =?utf-8?B?cVhJUzJuVTV0RVI1cVFOMDNZQjJrR0sydnVwNEJKckdjWU8zV09oN1dyWmtk?=
 =?utf-8?B?SEtaZExNMFJrdkQwaHkxVWcwR1h2bDRuSXFHVUNmUE9HYVd2VjVnV3Uya0N5?=
 =?utf-8?B?eWZMWW9GcmtxM3l4ZXZpUVk4TDl3V0F1Y3BHUzhxeWN2V0FyQmN0SEhJMWgx?=
 =?utf-8?B?QUZtbVYzZ3NlcXZpdDFEMjhQOXR2cW5md0R3d3FaNnpVQTlVSHNTWGh4SHVw?=
 =?utf-8?B?cE93V1A1dDkxUzZQTnNtbHg0Mmp1eVVoY2lvVm9zT0VyRFFrbWZnMCtWU2pP?=
 =?utf-8?B?ZWlDem5qby9GV0h2V2VkOTBHN1JLU0FlTXVjb3R5b1ArR3ZPNnltOXRFakkz?=
 =?utf-8?B?UmMwbHdyK3B3Qm55LzFhWDJDSWNYMGZ3RFBlczcxTlZJLzlkUnVxNXlpcVM5?=
 =?utf-8?B?QU1sU3F2NTV5MkdEY3pvTG5DY2NHcDc3UklCWnovZm9IWFhmUmN2QVptU29n?=
 =?utf-8?B?cmxrcUFFTFJSSDFJRVRwdjFtWlhEek9jVUt6MzRESXY1UzVTU1ZLVjhiYm9q?=
 =?utf-8?B?c3pGTm5yQUJBNlVxa0RsYW9NTXpjbXIrclhlZUxqUnlRemVFd1Z1OE9qdi91?=
 =?utf-8?B?elRSdFRmSDNNazUwcmVVQUtsOUY4a1NoRE4rY0hORzN6MG5HMThwSWJvV3Qy?=
 =?utf-8?B?Vy9BUFl5K01yMUloT0I2ajVVUi9KS3NXMUdEZDQ3a3MrbUhRcjZpTmZsR2Rz?=
 =?utf-8?B?RE9NdWFKWnhZMEhydVlEWmd3SFBRNGlpWStSUGhoRkpOcnk1QStKM0g5alVH?=
 =?utf-8?B?ZUxNN2M3K01iL05Lakd2d0ZQR2RnT0x4WjFDenlqVWQ2UVFSaDEwUTNld0Fh?=
 =?utf-8?B?akpZelJKS3YwSExiajBPOVV1Mk1lNVZXUkZqV1dQb29pR3JTRlRRWnlaTDhI?=
 =?utf-8?B?a1dQdEpYbVNkbUhaNm4wQmZuN3JxYW1kaVdHQWswTUpLaHFhdkh0SCtqZ2p3?=
 =?utf-8?B?ZjF6ckxMT2VmSHdTNUtRNTBGb0JpcUYrbmRxUWVXUTRUQ1RuTGxHOW1tVUFr?=
 =?utf-8?B?NUsxZ09mRHJGVVVqL1lzdW9GdDZvYWZNUFFubmxoSVNjOU1oM0R3K3Q0ZEVT?=
 =?utf-8?B?bG9QcC9xdnZDK1dYWWRzVUlmMk55SlI3cWFMS1VNU3A1TkFwUDhiVmxZUTFU?=
 =?utf-8?B?RTYxTDF5ck9hMzhPSisrZVBpSldXbElvTmtJMzJTaHhzVDlFM0hmZVBmS3Zp?=
 =?utf-8?B?VzdVZWJYT3NRSzdWTmVoakJsMDRhWm8vYjBMVkZhUDlWdGhFUHQxTVVwSkVR?=
 =?utf-8?B?UUZxbUl6aUdjb3luMVFxZHd1RWh5UlF3cnpVNlJDUjNHZ2xMbEFFd3E2Nkg5?=
 =?utf-8?B?ODVhd3d3N0xWVGRMLzdyMk11ajNhN0IzSStleC9MWmx1YVdxSlIxMEdlUGpq?=
 =?utf-8?B?aktEN2piS1d2ZUg4cDFGQ21pc00vRytJODlrM1R4cGIwY1lBN011eUZoNElG?=
 =?utf-8?B?U2x6TWpUYXh4YWZYNW1mZXd0b3k5aW1FamVrczU2L2RVSnJ5c1pyNUxYVkRY?=
 =?utf-8?B?Z1J2U2hBM2JEd3JPMlhRZExVMDk1ZjZqb1Mzait0L1NQeGZmNW9WdkY4dk5j?=
 =?utf-8?B?R3NRZjY1dFk1SnpHYXpjUDlCOXhROEp1NHFpUjFFSnYvWHY4bXplYXVLUGh2?=
 =?utf-8?B?MDBpWWJXOTVjOEp2b3VXRzFBcytLVmo0QTVlQWtoQnN0MEpvNjNOaFZxYUNz?=
 =?utf-8?B?bGZFU2FKYXltNk05TTdGYWw4VS9yWms2bU5oNjFpeENnZitXVUlMcWlkcTJw?=
 =?utf-8?B?Q1hLYU91bUpoeEUzVDJhTkRtd0tYZmZ5ZDFqWXExQUdDZENyelQ1ejdnMXlI?=
 =?utf-8?B?SktYcHIyeTNjQm5kNW1oSnJCTWNsb2dKRkYyQ3J6NS9XeEY3R2Z4UHd6Mm9T?=
 =?utf-8?B?ZkFuWnhGSmhnVzZSYk10TUlIK3dRdGdOc0hVM3R6QjhLWUJrU1lrZEdDRkRU?=
 =?utf-8?B?TFdGVWZkczgzNGNid0Y1bUZEVXo0OFMyRzJZT0liM2hwMzhqY0NOR3lOampF?=
 =?utf-8?B?VW54VmtQNFpqM3FUL1NBUmRBN2ZqYjNjdkVoVzkxckNMRndXNXJrN0YzREVJ?=
 =?utf-8?B?VkYrbXAwcHQ1ZHJla09uQlc1MkltTHF3RHpHWFJhT2QwM1M0OTdxdz09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <1BA4C1A5AB1AEE4AB95764898ED62B59@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: af438979-ccae-405e-e765-08d9994145f4
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Oct 2021 11:59:47.3893
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: YItOJdbO8XIUgvyWDQOSQxX53/t9mZIGhFRJ6YE9mvf8dduhIgLXDmQLlLoSVZFZS8MYsvYERNXne4Cg63iH86PnjJm4ngKFKdcl66veDxy9UPO7YeGn1DVDsHmXvkbr
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR03MB7345
X-Proofpoint-GUID: uPDv8_TRYiK89CzYIVtRkxK6REe1Fe0M
X-Proofpoint-ORIG-GUID: uPDv8_TRYiK89CzYIVtRkxK6REe1Fe0M
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475
 definitions=2021-10-27_03,2021-10-26_01,2020-04-07_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 mlxscore=0
 spamscore=0 suspectscore=0 bulkscore=0 clxscore=1015 phishscore=0
 malwarescore=0 priorityscore=1501 adultscore=0 mlxlogscore=999
 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2110270074

SGksIFJvZ2VyIQ0KDQpPbiAyNy4xMC4yMSAxMzoxNywgT2xla3NhbmRyIEFuZHJ1c2hjaGVua28g
d3JvdGU6DQo+IEhpLCBSb2dlciENCj4NCj4gT24gMTMuMTAuMjEgMTY6NTEsIFJvZ2VyIFBhdSBN
b25uw6kgd3JvdGU6DQo+PiBPbiBUaHUsIFNlcCAzMCwgMjAyMSBhdCAxMDo1MjoxNUFNICswMzAw
LCBPbGVrc2FuZHIgQW5kcnVzaGNoZW5rbyB3cm90ZToNCj4+PiBGcm9tOiBPbGVrc2FuZHIgQW5k
cnVzaGNoZW5rbyA8b2xla3NhbmRyX2FuZHJ1c2hjaGVua29AZXBhbS5jb20+DQo+Pj4NCj4+PiBU
aGlzIGlzIGluIHByZXBhcmF0aW9uIGZvciBkeW5hbWljIGFzc2lnbm1lbnQgb2YgdGhlIHZQQ0kg
cmVnaXN0ZXINCj4+PiBoYW5kbGVycyBkZXBlbmRpbmcgb24gdGhlIGRvbWFpbjogaHdkb20gb3Ig
Z3Vlc3QuDQo+Pj4gVGhlIG5lZWQgZm9yIHRoaXMgc3RlcCBpcyB0aGF0IGl0IGlzIGVhc2llciB0
byBoYXZlIGFsbCByZWxhdGVkIGZ1bmN0aW9uYWxpdHkNCj4+PiBwdXQgYXQgb25lIHBsYWNlLiBX
aGVuIHRoZSBzdWJzZXF1ZW50IHBhdGNoZXMgYWRkIGRlY2lzaW9ucyBvbiB3aGljaA0KPj4+IGhh
bmRsZXJzIHRvIGluc3RhbGwsIGUuZy4gaHdkb20gb3IgZ3Vlc3QgaGFuZGxlcnMsIHRoZW4gdGhp
cyBpcyBlYXNpbHkNCj4+PiBhY2hpZXZhYmxlLg0KPj4gV29uJ3QgaXQgYmUgcG9zc2libGUgdG8g
c2VsZWN0IHRoZSBoYW5kbGVycyB0byBpbnN0YWxsIGluIGluaXRfYmFycw0KPj4gaXRzZWxmPw0K
PiBJdCBpcyBwb3NzaWJsZQ0KPj4gU3BsaXR0aW5nIGl0IGxpa2UgdGhhdCBtZWFucyB5b3UgbmVl
ZCB0byBpdGVyYXRlIG92ZXIgdGhlIG51bWJlcnMgb2YNCj4+IEJBUnMgdHdpY2UgKG9uZSBpbiBh
ZGRfYmFyX2hhbmRsZXJzIGFuZCBvbmUgaW4gaW5pdF9iYXJzKSwgd2hpY2ggbWFrZXMNCj4+IGl0
IG1vcmUgbGlrZWx5IHRvIGludHJvZHVjZSBlcnJvcnMgb3IgZGl2ZXJnZW5jZXMuDQo+Pg0KPj4g
RGVjb3VwbGluZyB0aGUgZmlsbGluZyBvZiB2cGNpX2JhciBkYXRhIHdpdGggc2V0dGluZyB0aGUg
aGFuZGxlcnMNCj4+IHNlZW1zIHNsaWdodGx5IGNvbmZ1c2luZy4NCj4gT2ssIEkgd29uJ3QgaW50
cm9kdWNlIGFkZF9iYXJfaGFuZGxlcnMsIHRodXMgcmVuZGVyaW5nIHRoaXMgcGF0Y2ggdXNlbGVz
cy4NCj4gSSdsbCBkcm9wIGl0IGFuZCByZS13b3JrIHRoZSB1cGNvbWluZyBwYXRjaGVzIHdpdGgg
dGhpcyByZXNwZWN0DQpPbiB0aGUgb3RoZXIgaGFuZCBhZnRlciB0aGlua2luZyBhIGJpdCBtb3Jl
Lg0KV2hhdCBhY3R1YWxseSBpbml0X2JhcnMgZG8/DQoxLiBSdW5zIG9uY2UgcGVyIGVhY2ggcGRl
diAoX19pbml0PykNCjIuIFNpemVzIHRoZSBCQVJzIGFuZCBkZXRlY3RzIHRoZWlyIHR5cGUsIHNl
dHMgdXAgcGRldi0+dnBjaS0+aGVhZGVyIEJBUiB2YWx1ZXMNCjMuIEFkZHMgcmVnaXN0ZXIgaGFu
ZGxlcnMuDQoNCkZvciBEb21VIHdlIG9ubHkgbmVlZCAzKSwgc28gd2UgY2FuIHNldHVwIGd1ZXN0
IGhhbmRsZXJzLg0KU28sIGZyb20gdGhpcyBQT1YgZWl0aGVyIHdlIG5lZWQgdG8gaGF2ZSBhIHll
dCBhbm90aGVyIGFkZF9iYXJfaGFuZGxlcnMNCm9yIHNpbWlsYXIgZm9yIGF0IGxlYXN0IHRoZSBn
dWVzdHMgYW5kIHRoZSBjYXNlIHdoZW4gcGRldiBpcyBhc3NpZ25lZCBiYWNrIHRvIGh3ZG9tLg0K
DQpTbyB0aGlzIGNhbiBiZSBhIHJlYXNvbiB0byBkZWZlbmQgdGhlIGN1cnJlbnQgYXBwcm9hY2gg
d2l0aCBhZGRfYmFyX2hhbmRsZXJzLg0KDQpPcj8gRG8geW91IGhhdmUgYW4gaWRlYSBob3cgdG8g
ZG8gdGhhdCBzb21lIG90aGVyIHdheT8NCj4NCj4gVGhhbmsgeW91LA0KPiBPbGVrc2FuZHINCg==


From xen-devel-bounces@lists.xenproject.org Wed Oct 27 12:01:37 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Oct 2021 12:01:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.216902.376681 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfhca-0003JX-4G; Wed, 27 Oct 2021 12:01:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 216902.376681; Wed, 27 Oct 2021 12:01:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfhca-0003JO-0R; Wed, 27 Oct 2021 12:01:32 +0000
Received: by outflank-mailman (input) for mailman id 216902;
 Wed, 27 Oct 2021 12:01:30 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=EkRf=PP=oderland.se=josef@srs-us1.protection.inumbo.net>)
 id 1mfhcY-0003J5-Hp
 for xen-devel@lists.xenproject.org; Wed, 27 Oct 2021 12:01:30 +0000
Received: from office.oderland.com (unknown [91.201.60.5])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 993a5837-de9b-4c34-bf53-82085f17bb45;
 Wed, 27 Oct 2021 12:01:28 +0000 (UTC)
Received: from [193.180.18.161] (port=57004 helo=[10.137.0.14])
 by office.oderland.com with esmtpsa (TLS1.2) tls
 TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2)
 (envelope-from <josef@oderland.se>)
 id 1mfhcV-00DPNq-Bn; Wed, 27 Oct 2021 14:01:27 +0200
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 993a5837-de9b-4c34-bf53-82085f17bb45
Message-ID: <89d6c2f4-4d00-972f-e434-cb1839e78598@oderland.se>
Date: Wed, 27 Oct 2021 14:01:23 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:93.0) Gecko/20100101
 Thunderbird/93.0
Subject: Re: [PATCH] PCI/MSI: Move non-mask check back into low level
 accessors
Content-Language: en-US
From: Josef Johansson <josef@oderland.se>
To: Thomas Gleixner <tglx@linutronix.de>,
 David Woodhouse <dwmw2@infradead.org>
Cc: boris.ostrovsky@oracle.com, helgaas@kernel.org, jgross@suse.com,
 linux-pci@vger.kernel.org, maz@kernel.org, xen-devel@lists.xenproject.org,
 Jason Andryuk <jandryuk@gmail.com>
References: <90277228-cf14-0cfa-c95e-d42e7d533353@oderland.se>
 <20211025012503.33172-1-jandryuk@gmail.com> <87fssmg8k4.ffs@tglx>
 <87cznqg5k8.ffs@tglx> <d1cc20aa-5c5c-6c7b-2e5d-bc31362ad891@oderland.se>
In-Reply-To: <d1cc20aa-5c5c-6c7b-2e5d-bc31362ad891@oderland.se>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-AntiAbuse: This header was added to track abuse, please include it with any abuse report
X-AntiAbuse: Primary Hostname - office.oderland.com
X-AntiAbuse: Original Domain - lists.xenproject.org
X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12]
X-AntiAbuse: Sender Address Domain - oderland.se
X-Get-Message-Sender-Via: office.oderland.com: authenticated_id: josjoh@oderland.se
X-Authenticated-Sender: office.oderland.com: josjoh@oderland.se

On 10/27/21 11:54, Josef Johansson wrote:
> On 10/27/21 11:50, Thomas Gleixner wrote:
>> The recent rework of PCI/MSI[X] masking moved the non-mask checks from the
>> low level accessors into the higher level mask/unmask functions.
>>
>> This missed the fact that these accessors can be invoked from other places
>> as well. The missing checks break XEN-PV which sets pci_msi_ignore_mask and
>> also violates the virtual MSIX and the msi_attrib.maskbit protections.
>>
>> Instead of sprinkling checks all over the place, lift them back into the
>> low level accessor functions. To avoid checking three different conditions
>> combine them into one property of msi_desc::msi_attrib.
>>
>> Reported-by: Josef Johansson <josef@oderland.se>
>> Fixes: fcacdfbef5a1 ("PCI/MSI: Provide a new set of mask and unmask functions")
>> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
>> Cc: Jason Andryuk <jandryuk@gmail.com>
>> Cc: Marc Zyngier <maz@kernel.org>
>> Cc: Bjorn Helgaas <helgaas@kernel.org>
>> Cc: linux-pci@vger.kernel.org
>> Cc: xen-devel <xen-devel@lists.xenproject.org>
>> Cc: Juergen Gross <jgross@suse.com>
>> Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
>> Cc: David Woodhouse <dwmw2@infradead.org>
>> ---
>>  drivers/pci/msi.c   |   26 ++++++++++++++------------
>>  include/linux/msi.h |    2 +-
>>  2 files changed, 15 insertions(+), 13 deletions(-)
>>
>> --- a/drivers/pci/msi.c
>> +++ b/drivers/pci/msi.c
>> @@ -148,6 +148,9 @@ static noinline void pci_msi_update_mask
>>  	raw_spinlock_t *lock = &desc->dev->msi_lock;
>>  	unsigned long flags;
>>  
>> +	if (!desc->msi_attrib.can_mask)
>> +		return;
>> +
>>  	raw_spin_lock_irqsave(lock, flags);
>>  	desc->msi_mask &= ~clear;
>>  	desc->msi_mask |= set;
>> @@ -181,7 +184,8 @@ static void pci_msix_write_vector_ctrl(s
>>  {
>>  	void __iomem *desc_addr = pci_msix_desc_addr(desc);
>>  
>> -	writel(ctrl, desc_addr + PCI_MSIX_ENTRY_VECTOR_CTRL);
>> +	if (desc->msi_attrib.can_mask)
>> +		writel(ctrl, desc_addr + PCI_MSIX_ENTRY_VECTOR_CTRL);
>>  }
>>  
>>  static inline void pci_msix_mask(struct msi_desc *desc)
>> @@ -200,23 +204,17 @@ static inline void pci_msix_unmask(struc
>>  
>>  static void __pci_msi_mask_desc(struct msi_desc *desc, u32 mask)
>>  {
>> -	if (pci_msi_ignore_mask || desc->msi_attrib.is_virtual)
>> -		return;
>> -
>>  	if (desc->msi_attrib.is_msix)
>>  		pci_msix_mask(desc);
>> -	else if (desc->msi_attrib.maskbit)
>> +	else
>>  		pci_msi_mask(desc, mask);
>>  }
>>  
>>  static void __pci_msi_unmask_desc(struct msi_desc *desc, u32 mask)
>>  {
>> -	if (pci_msi_ignore_mask || desc->msi_attrib.is_virtual)
>> -		return;
>> -
>>  	if (desc->msi_attrib.is_msix)
>>  		pci_msix_unmask(desc);
>> -	else if (desc->msi_attrib.maskbit)
>> +	else
>>  		pci_msi_unmask(desc, mask);
>>  }
>>  
>> @@ -484,7 +482,8 @@ msi_setup_entry(struct pci_dev *dev, int
>>  	entry->msi_attrib.is_64		= !!(control & PCI_MSI_FLAGS_64BIT);
>>  	entry->msi_attrib.is_virtual    = 0;
>>  	entry->msi_attrib.entry_nr	= 0;
>> -	entry->msi_attrib.maskbit	= !!(control & PCI_MSI_FLAGS_MASKBIT);
>> +	entry->msi_attrib.can_mask	= !pci_msi_ignore_mask &&
>> +					  !!(control & PCI_MSI_FLAGS_MASKBIT);
>>  	entry->msi_attrib.default_irq	= dev->irq;	/* Save IOAPIC IRQ */
>>  	entry->msi_attrib.multi_cap	= (control & PCI_MSI_FLAGS_QMASK) >> 1;
>>  	entry->msi_attrib.multiple	= ilog2(__roundup_pow_of_two(nvec));
>> @@ -495,7 +494,7 @@ msi_setup_entry(struct pci_dev *dev, int
>>  		entry->mask_pos = dev->msi_cap + PCI_MSI_MASK_32;
>>  
>>  	/* Save the initial mask status */
>> -	if (entry->msi_attrib.maskbit)
>> +	if (entry->msi_attrib.can_mask)
>>  		pci_read_config_dword(dev, entry->mask_pos, &entry->msi_mask);
>>  
>>  out:
>> @@ -638,10 +637,13 @@ static int msix_setup_entries(struct pci
>>  		entry->msi_attrib.is_virtual =
>>  			entry->msi_attrib.entry_nr >= vec_count;
>>  
>> +		entry->msi_attrib.can_mask	= !pci_msi_ignore_mask &&
>> +						  !entry->msi_attrib.is_virtual;
>> +
>>  		entry->msi_attrib.default_irq	= dev->irq;
>>  		entry->mask_base		= base;
>>  
>> -		if (!entry->msi_attrib.is_virtual) {
>> +		if (!entry->msi_attrib.can_mask) {
>>  			addr = pci_msix_desc_addr(entry);
>>  			entry->msix_ctrl = readl(addr + PCI_MSIX_ENTRY_VECTOR_CTRL);
>>  		}
>> --- a/include/linux/msi.h
>> +++ b/include/linux/msi.h
>> @@ -148,7 +148,7 @@ struct msi_desc {
>>  				u8	is_msix		: 1;
>>  				u8	multiple	: 3;
>>  				u8	multi_cap	: 3;
>> -				u8	maskbit		: 1;
>> +				u8	can_mask	: 1;
>>  				u8	is_64		: 1;
>>  				u8	is_virtual	: 1;
>>  				u16	entry_nr;
> Thanks,
> I'll test this out ASAP.
I'm adding

diff --git a/kernel/irq/msi.c b/kernel/irq/msi.c
index 6a5ecee6e567..28d509452958 100644
--- a/kernel/irq/msi.c
+++ b/kernel/irq/msi.c
@@ -529,10 +529,10 @@ static bool msi_check_reservation_mode(struct irq_domain *domain,
 
 	/*
 	 * Checking the first MSI descriptor is sufficient. MSIX supports
-	 * masking and MSI does so when the maskbit is set.
+	 * masking and MSI does so when the can_mask is set.
 	 */
 	desc = first_msi_entry(dev);
-	return desc->msi_attrib.is_msix || desc->msi_attrib.maskbit;
+	return desc->msi_attrib.is_msix || desc->msi_attrib.can_mask;
 }
 
 int __msi_domain_alloc_irqs(struct irq_domain *domain, struct device *dev,



From xen-devel-bounces@lists.xenproject.org Wed Oct 27 13:00:53 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Oct 2021 13:00:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.216917.376698 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfiXQ-00011R-Gv; Wed, 27 Oct 2021 13:00:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 216917.376698; Wed, 27 Oct 2021 13:00:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfiXQ-00011K-Bj; Wed, 27 Oct 2021 13:00:16 +0000
Received: by outflank-mailman (input) for mailman id 216917;
 Wed, 27 Oct 2021 13:00:14 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=7jCJ=PP=oracle.com=boris.ostrovsky@srs-us1.protection.inumbo.net>)
 id 1mfiXO-00011E-7m
 for xen-devel@lists.xenproject.org; Wed, 27 Oct 2021 13:00:14 +0000
Received: from mx0a-00069f02.pphosted.com (unknown [205.220.165.32])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id d25d17e6-3725-11ec-845e-12813bfff9fa;
 Wed, 27 Oct 2021 13:00:12 +0000 (UTC)
Received: from pps.filterd (m0246629.ppops.net [127.0.0.1])
 by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 19RCThjx023019; 
 Wed, 27 Oct 2021 13:00:08 GMT
Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71])
 by mx0b-00069f02.pphosted.com with ESMTP id 3bx4g19r0r-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Wed, 27 Oct 2021 13:00:06 +0000
Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1])
 by aserp3030.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 19RCtG7p051618;
 Wed, 27 Oct 2021 12:59:51 GMT
Received: from nam10-dm6-obe.outbound.protection.outlook.com
 (mail-dm6nam10lp2101.outbound.protection.outlook.com [104.47.58.101])
 by aserp3030.oracle.com with ESMTP id 3bx4g9vmqk-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Wed, 27 Oct 2021 12:59:51 +0000
Received: from BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10)
 by MN2PR10MB3757.namprd10.prod.outlook.com (2603:10b6:208:182::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.15; Wed, 27 Oct
 2021 12:59:49 +0000
Received: from BLAPR10MB5009.namprd10.prod.outlook.com
 ([fe80::3c49:46aa:83e1:a329]) by BLAPR10MB5009.namprd10.prod.outlook.com
 ([fe80::3c49:46aa:83e1:a329%6]) with mapi id 15.20.4649.014; Wed, 27 Oct 2021
 12:59:49 +0000
Received: from [10.74.107.92] (138.3.200.28) by
 SN7PR04CA0047.namprd04.prod.outlook.com (2603:10b6:806:120::22) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.14 via Frontend
 Transport; Wed, 27 Oct 2021 12:59:46 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d25d17e6-3725-11ec-845e-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date :
 subject : to : cc : references : from : in-reply-to : content-type :
 content-transfer-encoding : mime-version; s=corp-2021-07-09;
 bh=X3TQ78hrD55J4dSEd5tXdmdstbmPGtogtES+IsQjVWg=;
 b=DPw+HS3VetPZdkGoQkZcLc1aDblZylDTW9nHAa9RdEbo1OjQosc5kVwOlzyEFSTJctCz
 j4VNm9EZE/Ot/CbvHsLQviXChS3V2jDdtB1n9XOW3U3o8DV6hhFdKpEpHTwxes9CMw1u
 Gjbifqu+fDs9IWKbfr/VE5Jgw3ifcGr6MmIm/mbkwTFNup7Of80c4Y6DD60ukSbjfEd+
 sCDar+RyB1Glrivd+NaP1MnBqAQGdo/U2rGoULhN5CulszjKFfy+hmUKxe2vWhJHXHOM
 /rilrPV9nCyfue8Qf9euGZMDuU86mY2HlOGwUfxaTaDaywWlTZ+FmdK0VbPGcIPLc8UO 1Q== 
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=AAMlYLCM0S18kpXAvMhJE5+JzLXqXwub4DhC8mtea9rNRnfxHh09WUMn0v82+J7m2Kkr5O/5q2Bd+k9QW75jz5ZyrbwTj9K0uL36B1YwbgEHicB2LO1sbKwlrPXcDsG1XrUYfNuRtoNObpZpw4I+REjG5UZEZZLhKIGoX4aDJV/v1lpbRF2Y0oHm7S3Idc7eyBvk5dxygg0cpW04OI9h6CggEvs9c5jQHonvhc3sXTwPN1B1JOGRAInUYAihgiHd582U0u8XbRRWhRJ38lBq5SBkZ9ImesMT5EkbD4ZGO6Pv/IpR2m5I4sthfja4NvZqp16mT1TmjFjzZFl+YVoREw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=X3TQ78hrD55J4dSEd5tXdmdstbmPGtogtES+IsQjVWg=;
 b=awHgM634+LdGfkBhL4EgIT0lyOZjW+Bv3Puee6dJmHEIAr3IdzWOnFi8T6iMz4d+gDORnLu1xguGyyevOXfBlG2z6hUwDZjLfsu2Va4K4zrrEGxEJVzPMPQGceV33X8wmECRWJSKLq2VIKv/0bPTf/Bw1cKsErUdn3JMwdJsOMhI3GCe+XuDmSpH30m4AguIAnVF0m9vdKq8dMrl0DRt9/PdMf+yiWe14OIjVjNzuqeuEUaIJENi15QSNklY4sovzA93ygVshZn1297mL7nAvjDP9o1709D5ZA6p0Kln/wJRF1tmtW8sRLITHNcd6Z+RT2rw+pucXBwm5NcTnrrfIA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com;
 dkim=pass header.d=oracle.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=X3TQ78hrD55J4dSEd5tXdmdstbmPGtogtES+IsQjVWg=;
 b=Q++DSuQ8x5nYCY3lUw16DduvgNky1+o2resN0P9w7bBxQEqyxaJT2mhLjvmz+S0c3OkyqmuNX5jfFmbU8H+4OMCuSxyEXlOMrDr14cYTzFysrpAHCagwvCpf7OvHUQKZ44gK1vbj3Ivz5oR4oPBAdC6qqPiw7FmPWFmPSfvGZZ4=
Authentication-Results: gmail.com; dkim=none (message not signed)
 header.d=none;gmail.com; dmarc=none action=none header.from=oracle.com;
Message-ID: <71ce7c97-1d08-9fdf-b217-53eb914a29a6@oracle.com>
Date: Wed, 27 Oct 2021 08:59:43 -0400
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.2.1
Subject: Re: [PATCH v5] xen-pciback: allow compiling on other archs than x86
Content-Language: en-US
To: Oleksandr Andrushchenko <andr2000@gmail.com>,
        xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org
Cc: jgross@suse.com, julien@xen.org, sstabellini@kernel.org, jbeulich@suse.com,
        Oleksandr Andrushchenko
 <oleksandr_andrushchenko@epam.com>,
        Anastasiia Lukianenko <anastasiia_lukianenko@epam.com>
References: <20210928073501.433559-1-andr2000@gmail.com>
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
In-Reply-To: <20210928073501.433559-1-andr2000@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: SN7PR04CA0047.namprd04.prod.outlook.com
 (2603:10b6:806:120::22) To BLAPR10MB5009.namprd10.prod.outlook.com
 (2603:10b6:208:321::10)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: b47a38ff-065f-45c7-a5ac-08d99949a8aa
X-MS-TrafficTypeDiagnostic: MN2PR10MB3757:
X-Microsoft-Antispam-PRVS: 
	<MN2PR10MB37576298A904C4C08FA6DE898A859@MN2PR10MB3757.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6790;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 
	UIOkF6QwnqDI9q/OUC/xW67/EJI9i7EPPFJ23qTrCDBODcF4GkHbQJkR8FLatk+9k4mwDFlHdmt8gfGz1w/HJ+UpRKXNYgWeQThtp/mSS4dcNaQCmBL70Tl0YeTVw/owsDVxR/kkTaZaTdUXmbyxec86gV+X/3FzXBfMreHnQia9oLoTtjUxrT2aTZUlbCuXfrKb0ytEPSYha4Rnmii8J5ZrH3fhuUkdR6oYCMKOu+vKiqjLnXd8qCyC0xOk9C0bX2j5F+AICachRUz+gwUP45gmOBXTkWOHQxjafvR00CwSvne29Tae2YrjpHSrbCwpbjWc5JkthDZrOGk6cUUCHPCEY1kfWajOQOvQwAQUVZRLkToexxBgtAqOp4Of5DA7SsY1gw5d8wCiHrkx6/dvh9/sJ3SAL9uCwU4AVz/ecqQCAGbYCOjvXiDs05oDp2h4/gMh4c7P+koRXo3O0LdZoyJHYrHzVwBYyYIHpmf9YJF7BpANPSkAuD/ibjP5rJifu4weWFd4JcwWO20K4bxM9GAoqKBrGntgkZfEiuF9CkpZ8qI6rUN36gnF/feWMURVV+ftfJ5TqeXZOXtKwM2PjeJ3giBb4wfQ8i/24BnprVL+3XTQrjtinmPkY6xOPlrcLYZCo6WSf5/dzkOnF0J61Ly+nki1JVgSDIPxDA+6ZvGlUeNbPFlpWaRziVD3EWO/xu81rZqAC8mM4aPJE0q93A8TNVroCudra3H3c4E0AUQ=
X-Forefront-Antispam-Report: 
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB5009.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(31686004)(66946007)(66556008)(66476007)(38100700002)(83380400001)(8676002)(86362001)(31696002)(956004)(2616005)(36756003)(44832011)(8936002)(5660300002)(186003)(26005)(6666004)(508600001)(53546011)(4326008)(16576012)(54906003)(316002)(6486002)(2906002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?Zi9HMm1ROG1aRSt6ZTJCaDhpdnFIK0F1RXlvRUx2OVZ3UmllOTZ0RlRPNURY?=
 =?utf-8?B?RWpWdTVaZnZucVg0Ujl5cTNyaDIxdlVQTGZkRkM4UmFOZlR3YTRackRYanFX?=
 =?utf-8?B?NFNxN1d0ay9HeEo5TXFqOTBQZXBQVEVQTjhOeTdmVGcxZnB4Mk03OGFzdm9N?=
 =?utf-8?B?Vk9Jd3NMdGg5WDlGNzRaYXJtY2tzdyt3UjlpVTNDNG15QjRxRW95NFMrZjZ1?=
 =?utf-8?B?NTl5TWg5NGJJdHhJOXUxZ0RNZFlTL2RFNWZ0dkx6Znc0VWo1bXNkSHluUGU3?=
 =?utf-8?B?TC83N0dGSnFyKzJlaEcxKzlMVGJWU2VtZy9sVFkvZHhjN0tOR2dRNWFKUEFl?=
 =?utf-8?B?Ym1Ra0g1MnZDaW85UlBMVUFpOFBFdit6TnlCUFJmcHZ6blZmQ09nSDcrSmRT?=
 =?utf-8?B?cm5TU2x2Q0ZOdlloK2JRcEh3SEZyai82SXNUR0tGWUpxME1WTTBaTEg1eWpC?=
 =?utf-8?B?L3J5SGROVmNGQndDazZrdG5GT09USzZGTy84TFk4eVFxOXR1aGZpVDRtaWY1?=
 =?utf-8?B?Wk94NGtlUU40dlVHVE5Ka3hXWklFUG16ZnMySXgxZFBNSFZpcTE0NHdhTFFJ?=
 =?utf-8?B?S05jd0VkelpaSE4zTkd3K2o0cGJQVXZoSzNxeFJidFE0VWdVR1ZBWFcyNnY4?=
 =?utf-8?B?aGZnY0kxUFdQWTJ5U0VMWk9XR1plRUFYRjVTV2JzWldjMk5hYXJ0WjFzekIy?=
 =?utf-8?B?TEk5NUZVZUZJSk54U2krbGhFMUMwRVBHT25CTmJxdEhlSUNTNjlpUzJCRThz?=
 =?utf-8?B?cEcwblFHbWxjZWtwOHloaDBldGFmVWJmUGtQZ0h6S2RrUW9zLzgyeU93czh1?=
 =?utf-8?B?OVk2TXBBZVZjVWF2V2hmaGxFVzhrOUx6dU5CNTF6VW1OSC92M1dlL29TRWFZ?=
 =?utf-8?B?ckJ6aWdBSU43MjdQOEZ4b1JyZ0dKZmV3OXhQWUFPWkZUM09RRGdCb2NZbjYv?=
 =?utf-8?B?NFE2WjVqb0pFc0ZPQ1FQbVZkU2hRUjdBbUhiU1ExVVRuN0Fna0x5QXUra05G?=
 =?utf-8?B?TCtob0ZHSmdXaDRkYXhlelBKREkrUWppV3BLT1BKY2UvWEc5eitmWXY4YkZH?=
 =?utf-8?B?aFYvNndna2k3eW1QTHdnandPRW01WEpENnd1ZXlnVDBEZ3dOZzNLK1NwQjd3?=
 =?utf-8?B?UWZic2NHWkVhMTdyNXExRkRNNzNoZnJmRmhSeGZDMWw2cjNWbHV1bXJhM0hq?=
 =?utf-8?B?Vk5jend4Z0lZRjRQc2lyVXlic0E4V3ppdVV1azhFV2VjWkp4VTk4ZVUwNndO?=
 =?utf-8?B?eXZZd09OWW5NdHliajM2TkxnVlllRktVaGlDenMrVXJSMmliU2l3bTR3MG52?=
 =?utf-8?B?TElsTUh3WEx0WU5SRmFhdndQSVpSYXo1QUtuZFdxNFRyck9iYVlDbTRnSmRJ?=
 =?utf-8?B?dllnMUduUUFQSmhRUzVCM0ZvNytMQUJiekFWeVpQTk5HYzlaQitUMVd4YWNn?=
 =?utf-8?B?ZjF5TlVjUlBic0QvRExGazI2RnlWOUJ0NEI0b2M1ZFRZc1ZmYlp1YXlydURx?=
 =?utf-8?B?VE4renVuYmQ1N2JvMjJSS1krWGsvbUUxbmJ1bnNSV1Q4ZCsxc2h4eGhBdGVH?=
 =?utf-8?B?MEZ2RGwrSi9Cd29LOEFuSE5BTGZtL1VMS2ZLd3dQS1d2dkQ2M3E3YXozV3c3?=
 =?utf-8?B?Wm1XbFM2elhxQmZVVDdlQzZNRkVTWWFTL1l4TDFRL252eEtkVjZSVVdreUtl?=
 =?utf-8?B?L1VDWkdjMG9xbEE5SHNRbDZDWEx6bVY5Y1ViUndkZk14WjlDZVc0ekVhakgz?=
 =?utf-8?B?QW42UEtzUFBIcWdoeFBuRndHcllLQVQxTHMzL2trQVBZVHRJdlFESGEyTkFr?=
 =?utf-8?B?cVgzTFlqcEJCTDR6VjRxZGFEMjc3NVY2ckRHbWlrTkVYNHh4d0tobjhLZVdm?=
 =?utf-8?B?ck5wYnVIWG8ySnR2KzRaV2hKYzdzN2YwUCsrOURiYnY0c2w3eWpKTFlIN3hr?=
 =?utf-8?B?SWtrMytVQkhJZ3hEc1Y0Ky9tUXNnRXJEaURQYWlQSldzMjRVOURlZmhBUUhq?=
 =?utf-8?B?c1c5bUJjZHZnc0NqalViRWxDYURDOWdTTHl4YUVXY3djMm9NbCtnc25BOWRP?=
 =?utf-8?B?TnBucktubWlMNEZ6Q016Z2dGdndJMUR5a3JIdENnWkEwWStQRGNvRlR5cVVY?=
 =?utf-8?B?TE1xUEVnMjNEakpuU3hQMURkdTNLZ0tSeERsd0lSRTY2VFR0czhTak1aN2xV?=
 =?utf-8?B?Sld1S1EvQkl0L2pVem9YYXdQTE5tbS9meFozRnVSZ2dRcTlENWVLOWtYamtN?=
 =?utf-8?B?SlpUU24xaEhBUnF4V3h3OFdrT3R3PT0=?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b47a38ff-065f-45c7-a5ac-08d99949a8aa
X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Oct 2021 12:59:49.5394
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: CAWkgY1loPKCi7SzMG6bDlAnHCPj3BMSO4GJo6xrm/egnbQeRzCsGd3t8hle/TFdNBoM86t9Wf6+fAo8EgVyrrh/FReq+Fm2q/kZH4dDLHw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR10MB3757
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10149 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxscore=0 phishscore=0
 suspectscore=0 mlxlogscore=999 adultscore=0 bulkscore=0 spamscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2110270079
X-Proofpoint-ORIG-GUID: 7lkM7CfiKkEAy04K_2Em4FMfmi7OZfDI
X-Proofpoint-GUID: 7lkM7CfiKkEAy04K_2Em4FMfmi7OZfDI


On 9/28/21 3:35 AM, Oleksandr Andrushchenko wrote:
> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
>
> Xen-pciback driver was designed to be built for x86 only. But it
> can also be used by other architectures, e.g. Arm.
>
> Currently PCI backend implements multiple functionalities at a time,
> such as:
> 1. It is used as a database for assignable PCI devices, e.g. xl
>     pci-assignable-{add|remove|list} manipulates that list. So, whenever
>     the toolstack needs to know which PCI devices can be passed through
>     it reads that from the relevant sysfs entries of the pciback.
> 2. It is used to hold the unbound PCI devices list, e.g. when passing
>     through a PCI device it needs to be unbound from the relevant device
>     driver and bound to pciback (strictly speaking it is not required
>     that the device is bound to pciback, but pciback is again used as a
>     database of the passed through PCI devices, so we can re-bind the
>     devices back to their original drivers when guest domain shuts down)
> 3. Device reset for the devices being passed through
> 4. Para-virtualised use-cases support
>
> The para-virtualised part of the driver is not always needed as some
> architectures, e.g. Arm or x86 PVH Dom0, are not using backend-frontend
> model for PCI device passthrough.
>
> For such use-cases make the very first step in splitting the
> xen-pciback driver into two parts: Xen PCI stub and PCI PV backend
> drivers.
>
> For that add new configuration options CONFIG_XEN_PCI_STUB and
> CONFIG_XEN_PCIDEV_STUB, so the driver can be limited in its
> functionality, e.g. no support for para-virtualised scenario.
> x86 platform will continue using CONFIG_XEN_PCIDEV_BACKEND for the
> fully featured backend driver.
>
> Please note, that CONFIG_XEN_PCIDEV_BACKEND and CONFIG_XEN_PCIDEV_STUB
> are mutually exclusive.
>
> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> Signed-off-by: Anastasiia Lukianenko <anastasiia_lukianenko@epam.com>
> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>


Oleksandr,



Can you please rebase this on top of 5.15-rc7? There is a bunch of conflicts due to cae7d81a3730dfe08623f8c1083230c8d0987639.


Thanks.

-boris



From xen-devel-bounces@lists.xenproject.org Wed Oct 27 13:17:44 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Oct 2021 13:17:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.216924.376709 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfio4-0002au-V6; Wed, 27 Oct 2021 13:17:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 216924.376709; Wed, 27 Oct 2021 13:17:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfio4-0002an-Rw; Wed, 27 Oct 2021 13:17:28 +0000
Received: by outflank-mailman (input) for mailman id 216924;
 Wed, 27 Oct 2021 13:17:28 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=7jCJ=PP=oracle.com=boris.ostrovsky@srs-us1.protection.inumbo.net>)
 id 1mfio4-0002ah-EB
 for xen-devel@lists.xenproject.org; Wed, 27 Oct 2021 13:17:28 +0000
Received: from mx0a-00069f02.pphosted.com (unknown [205.220.165.32])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 12bd4d21-7a46-40c9-a544-f45233a15492;
 Wed, 27 Oct 2021 13:17:26 +0000 (UTC)
Received: from pps.filterd (m0246617.ppops.net [127.0.0.1])
 by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 19RCTXdT023707; 
 Wed, 27 Oct 2021 13:17:25 GMT
Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79])
 by mx0b-00069f02.pphosted.com with ESMTP id 3bx4fj3gye-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Wed, 27 Oct 2021 13:17:24 +0000
Received: from pps.filterd (userp3020.oracle.com [127.0.0.1])
 by userp3020.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 19RDBwhE027370;
 Wed, 27 Oct 2021 13:17:20 GMT
Received: from nam10-mw2-obe.outbound.protection.outlook.com
 (mail-mw2nam10lp2101.outbound.protection.outlook.com [104.47.55.101])
 by userp3020.oracle.com with ESMTP id 3bx4gr28bv-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Wed, 27 Oct 2021 13:17:19 +0000
Received: from BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10)
 by MN2PR10MB4029.namprd10.prod.outlook.com (2603:10b6:208:186::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.18; Wed, 27 Oct
 2021 13:17:17 +0000
Received: from BLAPR10MB5009.namprd10.prod.outlook.com
 ([fe80::3c49:46aa:83e1:a329]) by BLAPR10MB5009.namprd10.prod.outlook.com
 ([fe80::3c49:46aa:83e1:a329%6]) with mapi id 15.20.4649.014; Wed, 27 Oct 2021
 13:17:17 +0000
Received: from [10.74.107.92] (138.3.200.28) by
 SA9PR13CA0105.namprd13.prod.outlook.com (2603:10b6:806:24::20) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4649.13 via Frontend Transport; Wed, 27 Oct 2021 13:17:16 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 12bd4d21-7a46-40c9-a544-f45233a15492
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date :
 subject : to : cc : references : from : in-reply-to : content-type :
 content-transfer-encoding : mime-version; s=corp-2021-07-09;
 bh=eKryvM9DrpnRHaNG5FgK2wqEwMeD6lIALav02VvtXik=;
 b=P6zMv1KjmxFSsCseTL2+W3H/fYwsMlxq3H7Cc2hjn3Tb8mVd5VfirykrhKxb4WxqNfj8
 pveIamyZCOdl1bmnRIr0EK89a1J3Mv0cOWNPEMSnmUWvx7GP+KxOdPLsgN8l/opltVG9
 acjojYUDcD1a0Ge/JJ/398feJPtlj8ARPvwzDj4ZSePNkyX8nagekcALfAlnleChPx9U
 yvh6aMs5hye5RRQmuzWQIiNcFZ6SR8svC7K/f5nfKbUAJldYhE0ulwFwW7CCVZ8Z2kJ3
 Pqs6llxTnql3iXg5xA60OhOIQt0dUG9BTBpP7PcXPetVhadEJthgEREEhd9jpRdrJQcu 7g== 
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ml8PDl91brzso0vTLH3bWUhEN8PpFT41O/ITYGxzHel7zoz7At/CjerKe932Jhbm+tECfCvqbuzHW1z4oHvm3OahcjRA7nO0xqAVRQdVCgniX4hT1+fZfzO7ME7D52G5bdubs0ma1clqG0I1pdpgXd8A2vQOU5msFG7WrsJ9000OgwZlup12rbFg+CXYN+Q01L6CzR+xDRAExKGUW40RwjwJJezE7ALcC1i2hDkL2DNpFOmYldnRwg4ndlJX4rHEKT8DuL7TgLwmshOle9uNhpdi9ruXISzn+AFHuqJ+0+pUtLZZT3DGuaRTTACN10ffbbL2IukWjKv+QWr9OMNSLQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=eKryvM9DrpnRHaNG5FgK2wqEwMeD6lIALav02VvtXik=;
 b=joSB9/S0r4ZzIo1wlEpDkJ76Jsct2+xjFldQ8T+VygyZlmxJ7DxQ4mY3wV3PG1ZEQsYe1LxlKcCLH/45W3bY9//vCREzTMq3nTPHcqSv9Z2RL3kLwtzFpGL1DGPtzf8NC45DKRhmAZrx+tafhUfAA0pbVF/KDDXeXTIT/JhoK4NWbbGQcntHX1ZD0eolGY1B7KrKCLLoPfBO4MNpW7qGD3fbQTbbKXJk8gOyikWxV5g+W7pwYp3NBIM5sF4Dr+dOahYUo8ZEL+FLtWm/hVGNDtLcD9jKoIWOgTlL35g8dTA9SipED5xuwVZiw6mFTO5HbUnuEHnHxcmot8W6JNR/YQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com;
 dkim=pass header.d=oracle.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=eKryvM9DrpnRHaNG5FgK2wqEwMeD6lIALav02VvtXik=;
 b=TiLuORGEVzEJbxeQ/gyUu7jOwXAIkoR/Zu5VJkadi2pU8pOXI96xP8UBtQSC/8cq0B7CkHGGykh6/s3HhghgghXj3Q/gaxxn/9CHJuO7JpK5IpuuVsF9/bFtVfLNFh8OQuuDwd07jfnDuqjkgEkmYKzTg2xhGz3rkCZWZwXC2Lk=
Authentication-Results: suse.com; dkim=none (message not signed)
 header.d=none;suse.com; dmarc=none action=none header.from=oracle.com;
Message-ID: <0fca8243-0106-8091-9635-53251c97149a@oracle.com>
Date: Wed, 27 Oct 2021 09:17:12 -0400
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.2.1
Subject: Re: [PATCH 0/6] xen/x86: PV boot speedup
Content-Language: en-US
To: Jan Beulich <jbeulich@suse.com>, Juergen Gross <jgross@suse.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
        lkml <linux-kernel@vger.kernel.org>,
        "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <022b1a5e-4121-6bae-f07c-4ad5eac12481@suse.com>
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
In-Reply-To: <022b1a5e-4121-6bae-f07c-4ad5eac12481@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: SA9PR13CA0105.namprd13.prod.outlook.com
 (2603:10b6:806:24::20) To BLAPR10MB5009.namprd10.prod.outlook.com
 (2603:10b6:208:321::10)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 14717415-b223-4b82-e8ec-08d9994c1980
X-MS-TrafficTypeDiagnostic: MN2PR10MB4029:
X-Microsoft-Antispam-PRVS: 
	<MN2PR10MB4029531CE21C710B6A59A35F8A859@MN2PR10MB4029.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7219;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 
	OQAJhsEdVuFrk5m1rg2kYBNsX6vsV5AzZo2RpjZq5rcBwYoYgXm2ATgub80RmpHnkAIP2e09CDpn9BZ8djhmnw6WGzBgVhefWYSeo2pjmxzkE40FNYQXXmQffM+ydl0PvYZ2BlLUjmbMRFSOTgpfYpgNsT2QRKEQUaIfM1mQ7m2HH/PhN7POFIzALV0ipu/98mZemSGpvidT97Z4mGHrQbiNMjdOo1VGft0sf9aq6N9cr9ZmLf9p5W75ITe9jqy1Ml49rxlOA/72HoxU3GNUT9hqLJuKqlOKEjb37jf1iKEq0HHd9+e8rWxaZ2uHAE5CeAlCHbQaBrkECHwy1HsPqcrIKedYS1Fv0+qtwxe0YcHPJM4Cy9l7VmxS/ai8ZfyrW3bNCgT52AoEcNA4M1FsRdvofogrToBlQodYuNiqL6+VXVY2vSsnVaL7/ayWNFbbcGL3/ppfHAQNfQxwew8TxPH0o875O+MXv6OoxVDS9OcwRs6qt488QQibINiJLYlib6FsYv/zs4I2rQQjyxVP1u7vgg147g0VZbtTbbI70lOA3vv79ZrCJ/D3fQjrJmeJYZ+9rWfQ/vWT4xp0KtkTihic8tyZvTCohsLW2IKJ2k9tkirktX/84ua78TlIoPu2H79Z9dOCl1t4oFFLR9IOhDAXT8z1xb0bzNgNXkWqM1CUSsvOgn4y9KmDkCht0RaYjwibbfl8EgUFpx6/hts0KvkWH2qd9CzObucMgxTKo9U=
X-Forefront-Antispam-Report: 
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB5009.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(31686004)(36756003)(6666004)(4744005)(16576012)(6486002)(66556008)(66946007)(66476007)(956004)(53546011)(186003)(5660300002)(26005)(38100700002)(83380400001)(44832011)(508600001)(86362001)(4326008)(31696002)(8936002)(2616005)(8676002)(54906003)(2906002)(316002)(110136005)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?QUR3RjFYUE5wMlJuVnQrQW4xK1BKYzJQUEFNN3F0eVVkWWxkZ0lLYUorTEFx?=
 =?utf-8?B?ZXBRR0I1OUE2M0prY2Z0Nis4dGR2MG8zSTh1dnRBeE13bnYrWkNYNUVNeWJQ?=
 =?utf-8?B?WWZxYmhDdFY4MXViZm1UTkUyclhxK01QLzU5d1BRd3JhRzRCa21KaTFhNnk4?=
 =?utf-8?B?Z3cvVFJmNEZKZUhlL2kwZGo0NGYzS3dNL1cxTjJWNjIxVzRTaGVFM215akp6?=
 =?utf-8?B?MzU0ZllNaUorenVCN3pzeUx2a3VRMjlNSnlXM0ttSy94NHlmT0t0bUs1anlF?=
 =?utf-8?B?Y0VKNng3VHJMbDFScHB2UFFoY1RrZDZkNWNKRzVJTU9WSFFSLys3bHhmUmo1?=
 =?utf-8?B?UFk1anc5VExPUEN1L0paY1pvb2xNQ3V4TmZ2ZnNwa01JTnVpM2Q3bmU2V3Vu?=
 =?utf-8?B?WVZud3dnMndPbzVRWFZBM0padXE3b2xBU3FtTjdaQVN3dzNFWkhNU1c4MHRV?=
 =?utf-8?B?V2ZqZWNaWEI3VkRTbkZNLzg2SnQyYmpiUnc1WWhJTTRobHY5SjE3Q2xxVzNX?=
 =?utf-8?B?Z2FQU2VHU2tGOHpKNWRQUDdlb1ptcEpSS1YwcS9DTHhRR3hhNmFSUGRaZjYr?=
 =?utf-8?B?cFY1NmdXUzExang4OENhQWY0K0M0Tk9UL0MvaFNuTmY3Z2tieFc1a1BmMnZI?=
 =?utf-8?B?NnNuNkMzMmZrL3VHdXpIMjFqTmhYQzIwRTNQeEJQdW5WaFFqdWFYN0Z0R2Fr?=
 =?utf-8?B?SmR6RkxrZEtiOUZIN05oVVRDSUdZelJUMmJtNmFRMXlMTkdVQ3JvWThURDly?=
 =?utf-8?B?amRabmRhd3p4YXpxYXFaUmxlVDQ4OWdDNllWdm0rN1J2c09UbUt2Ny9OdjVU?=
 =?utf-8?B?S3BpcDR4MGRobjNiNXV5SUhTSkdLWVlpY2NERmw1WngvVE5uSVJEc3JOd1Zj?=
 =?utf-8?B?UXpCWU43bHcwNHFhRUpBSC94bUhLNXdjRC9mYWhyQWJyMVRjdEJmbG9aNjk5?=
 =?utf-8?B?bWwyNHB6OFFURS9lVHRINTVqZEJnZHMwZHFOOHhHc1FLME56Z3QwenhqTWFz?=
 =?utf-8?B?akZrLzh1aUQ5aG9JNm42Tm1ZUFhHREhDdWxlMmNtSjZSWElCZXVVWWlvYXBI?=
 =?utf-8?B?NW05c0RIdFZvZGE1NmVmRDBXUHlvVGFmTTVQclVwT2ROM1hiMjJEU2d1aXha?=
 =?utf-8?B?ZjBPQUphdGI2a2ZFZjJvVEYzZTNJQjJCZWluT1F5eVVudE1DRVoyVzByYmlU?=
 =?utf-8?B?RUlNcFVwQTV0QjZ2VnZ2WUtRc05MRnhMbEhDb2hMMTRlaGJYU0JJZEozZGdD?=
 =?utf-8?B?b3ZkcGxaRnptU2hJclkyOEYrRk0xQndLOFFZUlRpNFlIeG04a2J1MFdFYzdV?=
 =?utf-8?B?UTF6MnZ0UXBQV0hEcHZXSVA4dlZpa3JwdlZBQjB1OUIyRklMc2FFY0RNQU54?=
 =?utf-8?B?OFhxNWlvQTEvZjVmcCtOVG02SkhuLzgzK3ZMRzg0TFArYmNqWVJ5SFR2N0p6?=
 =?utf-8?B?OS9CUHJiMnlzdEJ3WThIRG13ekZjOUFGamlmUjRtV1pLNTJmbW1IUDE2ZlJi?=
 =?utf-8?B?akg2RUFWUTlhWm54UU0xWFlNdGx6TnN1WndGWTJoNnRMT2htdWRLMFFWT09s?=
 =?utf-8?B?b1hXeGluZmNWL1AxSk01QjZKUFdKSnlvR0F0M2x3U290dFhrZ3NmSGdKcDlT?=
 =?utf-8?B?bC9mQWRNRXA0MGMvM3ozSUVvSjRaRDB6Ukl0U2xSVnBNaksvbkowZ2lNUWdy?=
 =?utf-8?B?UGtTK3lUK2NqeUprak1CNzhFbitzbW03Wk9RUEVnWFB3b3lSNytPTW1QWnEw?=
 =?utf-8?B?ZzJyR3Erd2ZJVE5jcmlVSDdKTmxtRWlFTUVNemFQWXZueXZhM2M0VGFLYU9x?=
 =?utf-8?B?d01uY0kwU0xuYWZ2czQ2Z21EQlBXNWlPY2pBQjVZY2JzTHlGSFowZm5peHJS?=
 =?utf-8?B?ekpPRjgvVDJ4MkNUQ2Q5NXVSR2pwdEJsdUxkWG0rWEpPUmN0ZWdtY2ZCa3BJ?=
 =?utf-8?B?c2lWTWpkaWVrRDBrNHZUUFNSM1h2MGhURnRvZDNvQXJpOWthZWhTRVllTnkr?=
 =?utf-8?B?TmRVS0I2TXo1MG1IeVUyZ2t0VHBtS3JJcjk3aUhoVit3YmZCSDM4Nm9FckZ6?=
 =?utf-8?B?cTBZdjJZK083WDVabUpkdFZVbDRVRnA5OFBQeUcxYk04ZmcvN0c5U2RtL2c1?=
 =?utf-8?B?TVN2QTBSR0pOK1c2OHJqZ0k3TENxaFpUWTJIcE5VeFcrbTczQ05TN3c5NjBV?=
 =?utf-8?B?MVd6NFlGRlM4R3pTUVMwSFd2NjhEU1B1WnliVDFhMmp2UGZ3R1pnSUhDUEs4?=
 =?utf-8?B?UWtrNU45cUpDUWFkdFJ4Z2FVQ3pnPT0=?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 14717415-b223-4b82-e8ec-08d9994c1980
X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Oct 2021 13:17:17.6448
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: z0AiZT1boac9VOL6ePHA2yblIgl5mnOb2RGYuvajIYvMnAC/6FFRPw2fc72VzW8aQB5x9urApDq4AANJJaDTv0WDvhzKNrIKkDNtJNLRcH8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR10MB4029
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10149 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 malwarescore=0
 adultscore=0 suspectscore=0 bulkscore=0 mlxscore=0 spamscore=0
 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2110270081
X-Proofpoint-ORIG-GUID: SthDEoaTXnYSC6InyF03KM7WKXPFgABg
X-Proofpoint-GUID: SthDEoaTXnYSC6InyF03KM7WKXPFgABg


On 9/30/21 8:33 AM, Jan Beulich wrote:
> The observed (by the human eye) performance difference of early boot
> between native and PV-on-Xen was just too large to not look into. As
> it turns out, gaining performance back wasn't all that difficult.
>
> While the series (re)introduces a small number of PTWR emulations on
> the boot path (from phys_pte_init()), there has been a much larger
> number of them post-boot. Hence I think if this was of concern, the
> post-boot instances would want eliminating first.
>
> Some of the later changes aren'r directly related to the main goal of
> the series; these address aspects noticed while doing the investigation.
>
> 1: streamline set_pte_mfn()
> 2: restore (fix) xen_set_pte_init() behavior
> 3: adjust xen_set_fixmap()
> 4: adjust handling of the L3 user vsyscall special page table
> 5: there's no highmem anymore in PV mode
> 6: restrict PV Dom0 identity mapping



Applied to for-linus-5.16


-boris



From xen-devel-bounces@lists.xenproject.org Wed Oct 27 13:18:42 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Oct 2021 13:18:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.216930.376720 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfip6-0003HU-Cj; Wed, 27 Oct 2021 13:18:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 216930.376720; Wed, 27 Oct 2021 13:18:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfip6-0003HN-9P; Wed, 27 Oct 2021 13:18:32 +0000
Received: by outflank-mailman (input) for mailman id 216930;
 Wed, 27 Oct 2021 13:18:31 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=7jCJ=PP=oracle.com=boris.ostrovsky@srs-us1.protection.inumbo.net>)
 id 1mfip5-0003HD-4F
 for xen-devel@lists.xenproject.org; Wed, 27 Oct 2021 13:18:31 +0000
Received: from mx0a-00069f02.pphosted.com (unknown [205.220.165.32])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 6017e992-3728-11ec-845e-12813bfff9fa;
 Wed, 27 Oct 2021 13:18:29 +0000 (UTC)
Received: from pps.filterd (m0246617.ppops.net [127.0.0.1])
 by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 19RCTXeA023707; 
 Wed, 27 Oct 2021 13:18:22 GMT
Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80])
 by mx0b-00069f02.pphosted.com with ESMTP id 3bx4fj3h46-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Wed, 27 Oct 2021 13:18:21 +0000
Received: from pps.filterd (userp3030.oracle.com [127.0.0.1])
 by userp3030.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 19RDC0Qd051761;
 Wed, 27 Oct 2021 13:18:20 GMT
Received: from nam11-bn8-obe.outbound.protection.outlook.com
 (mail-bn8nam11lp2175.outbound.protection.outlook.com [104.47.58.175])
 by userp3030.oracle.com with ESMTP id 3bx4h2c032-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Wed, 27 Oct 2021 13:18:20 +0000
Received: from BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10)
 by BLAPR10MB5251.namprd10.prod.outlook.com (2603:10b6:208:332::5)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.14; Wed, 27 Oct
 2021 13:18:18 +0000
Received: from BLAPR10MB5009.namprd10.prod.outlook.com
 ([fe80::3c49:46aa:83e1:a329]) by BLAPR10MB5009.namprd10.prod.outlook.com
 ([fe80::3c49:46aa:83e1:a329%6]) with mapi id 15.20.4649.014; Wed, 27 Oct 2021
 13:18:18 +0000
Received: from [10.74.107.92] (138.3.200.28) by
 SA9PR13CA0094.namprd13.prod.outlook.com (2603:10b6:806:24::9) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4669.4 via Frontend Transport; Wed, 27 Oct 2021 13:18:16 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6017e992-3728-11ec-845e-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date :
 subject : to : cc : references : from : in-reply-to : content-type :
 content-transfer-encoding : mime-version; s=corp-2021-07-09;
 bh=W87fTEnY3iPNmG6BeDf1aco/7GScB8QEqVfl/m52wVs=;
 b=QZN4iz25AXSmS1xq+uKoSYZvbYAwl0kDa0K+m8sZf1/vw3YRQy1qDWVPBHco7EHoQfgK
 tYiocARJKGd0XzUABlye7WOh4wv6YFwj8xFAFQFbrzCZfa6buH/7/VdJMzum4jzjvy0Y
 kbsS/tXV54yakHGs4bpl1zzgdIa8mjWxjN+VYA/p/gi/Eyz1kKBlutrj6Qd7hgRZmdyD
 r5ttSi7KZLv3yOm/dzSjRxkSVDvXr2a0GnOxXnSCcGL9++5iVOAsA11zyJ0rqFYm0Zem
 BECv8THJa9uR+semMBSdY279GAG188Pgl1eT+ItipXKAYgJy9N+NvgS0dpiH5kpA8J/8 RQ== 
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=YBcmK97aZALqRgwJxY/qFXsHrmDew1oW+Wc/GklnnLKa7td06i4oF9nQ8Jg6T9te1vu6c/E3HUiuJdxpTHEiFJk3r9FUC1FX0e741wDdCtiAlv/DI21z97Ruh2+t3WAa40htNAAKHgIKdD3nUiMFWdTfvolA3fFvspsSUecxnbGZ+rOHSwlOKjpKwWXG+dCPAQ5vYfZOOFBar5EGIKkXjvIDeD6Af2ekDdtJmz7CO0K5g3t0i7df3iPhwI8yHj9fh8gqOlBiDqph7L+xC4BXzYgAvU2XcO/ykd9HRonO04UnbdnfcQpS3FdHp3XSgh0dFig9q8ooNfPHkW/kTQ7tFQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=W87fTEnY3iPNmG6BeDf1aco/7GScB8QEqVfl/m52wVs=;
 b=aYMGoiZ0vi78gbBAKYY0TX9jfGkfHx3cTiEdVK0IORkbxD+Ygh2k07h5E3Jy5IjZZpKwO4vgx4ftFe0ya75MldNsLRW+xAy+oOcdFqJxZoeuPgas8vSdVJfR0qxTDLWqeG+6w+hTYcz8RKndpviF7/kWnLFTVeMDX8jdQufvwmJK2PqS/1AamrCiaRe8VhIj3ZGrakqrAGNYLMlsgwaARps7lVBjUkbC+OM9Et67YTcI47ccZj9xQwF4/LfprUWD2h8j/axHagVl5VxX3aHOliRlWnrObL6FmupLyWgO5z+DJLP4Vb1dKLBe14+GbctEpGKrsOHGmZl8+dxoTL3TcA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com;
 dkim=pass header.d=oracle.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=W87fTEnY3iPNmG6BeDf1aco/7GScB8QEqVfl/m52wVs=;
 b=LK3JknIfU7vUSeOLMUpNHM/rqhcCwRIximOCs5zYdp20ZaTUUfopZF37ABYjcb6ldazZPDa8xGiwT+oXLSlFkNMPZ7fxzYvCJOliU6Qn3AA1wGTX4kjBmEQ8C5+f3zNenyvtDsmGr54n8MI1I/fEyndTaGUYWXdWZMj5IUxShIs=
Authentication-Results: suse.com; dkim=none (message not signed)
 header.d=none;suse.com; dmarc=none action=none header.from=oracle.com;
Message-ID: <f9db2b8f-c4b7-95b3-856c-ebf5231d6bf8@oracle.com>
Date: Wed, 27 Oct 2021 09:18:13 -0400
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.2.1
Subject: Re: [PATCH -next] xen-pciback: Fix return in pm_ctrl_init()
Content-Language: en-US
To: Juergen Gross <jgross@suse.com>, YueHaibing <yuehaibing@huawei.com>,
        sstabellini@kernel.org
Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org
References: <20211008074417.8260-1-yuehaibing@huawei.com>
 <6644d095-92da-261e-87aa-284dcfcde19a@suse.com>
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
In-Reply-To: <6644d095-92da-261e-87aa-284dcfcde19a@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: SA9PR13CA0094.namprd13.prod.outlook.com
 (2603:10b6:806:24::9) To BLAPR10MB5009.namprd10.prod.outlook.com
 (2603:10b6:208:321::10)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 26eecf02-b001-491a-1dfb-08d9994c3dcd
X-MS-TrafficTypeDiagnostic: BLAPR10MB5251:
X-Microsoft-Antispam-PRVS: 
	<BLAPR10MB525158F6DE5B734DAFA96AED8A859@BLAPR10MB5251.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:935;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 
	mS8DLiWZuWCC4dYSiSn7DlJpMFkyVNR/G8Gbd64ZsIShCQTccBG/wIKvSNv2DdIHXfTNSfEs3QmYShtzWuQhNZDMWMCBF2hsUpcDsDUtJyHC2CXhKcIMQ3kavSvIPDMjI8nhBkTI2bAJ5MaF5l97UwQu1/HzInn383rlvWDx6GcR0wUiPnVFjThipAJrecLEKPpxFhsIMGgQQR0MONNSHKyskitcWpuulXlOMlzC8BJA4qZcpkcaMj6lmQSDzOLp+SR9wk2HOQMe/n3b12sCsxzhKg2wQc3DN6h0N7jZY2AKLGpZrPOqQGSeI6qgO5kElcEcPHMbRXxdPRspjA0FeaBt5Bl8gYna1dApS1/RNDctugVN6b3OF3XWb3QnG4V2V5t75ihLls5rpV0Vh8wM0YX8cahhsxYnGPG4CJzi8gKEHO5IUz0MiRGlZwlQJYj8oTejmsPBrPgTEBxLv00LEsIbQa7zcYV3WZcc3srvcEuKFu+jMbrRwMMPifdlz2+TZSVvPNPywtQ/XGWukf5On36V1IMml9m45QcAOuYLD7xqNEWQUKiAhD/DrmHgw4kBp6BaaatILVdItOFjCT8pAmcFkkZkzIpLIrIv8wLUBsUNV9fIW5U6Ke8jAmTOy8UM8YreQj4yFLkDsjoZIx8YlQX9ip9axivSoZ9rqz8ATrc5QzLy9kpBQyyzsgqTqvTcaFOBX3yMG0L95a70CJOxsVNyWG3Lm9ZKre1k8WqzR8psZf0/cwUIDeEENm/vg2nz
X-Forefront-Antispam-Report: 
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB5009.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(6666004)(110136005)(508600001)(36756003)(956004)(53546011)(8936002)(31686004)(2616005)(2906002)(4326008)(86362001)(6486002)(8676002)(26005)(186003)(66946007)(66476007)(66556008)(44832011)(38100700002)(5660300002)(83380400001)(16576012)(31696002)(4744005)(316002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?cnQ1NGdIQ09uOGlMMzVDeGF2a2tMd3F6ZWlERmtNdEVGZTJ6Z2lvY2lxaERP?=
 =?utf-8?B?MktVaXJDRks5WWYzRGtjNUF1Z3d6djY5eHMzcnZ6cVZ4VVp6b21qbmpwYW94?=
 =?utf-8?B?eUFMRE0wbkVQYnY5dThreWlybEZtVktQQm0ra3FnWFVGdCtXd3RYejBETGJ2?=
 =?utf-8?B?N0FGODJGQ2QyMmlDb3FuSXoyR3EydW0zeC84MFAwbnVYYjlReHAyYTBXVnBy?=
 =?utf-8?B?U2lqNTdjTVlXRm80bmMydDBOeWZUZkVjQ3ZZV2ZnNFNpMW5uRFNZY1R1TzNH?=
 =?utf-8?B?aGVGWDBPa3piNW1ZNUxxRzNjZXhsYktCZDByVTd2ZGh0ZUR0TUE1VkZtZUgz?=
 =?utf-8?B?cWVBdTVLbHkrVURob2k2MEtvamNkcUEvcXhsZVgxRHF5SGdOSGI5NVZGeXdP?=
 =?utf-8?B?YWZoTE9HUjVqdGdhcTc5TExiUFRHcG5nVXFYTVErWXp2UG1oK04zeGYyTVE0?=
 =?utf-8?B?T1pMcU9vcEhJYzdSYksyTE1FYlE4elFXQzRrWUkwUDA3a0hFUHhXTDdMV3Vv?=
 =?utf-8?B?WUdoRThkdFZRcXczemYxMkpZYlpOSXJyTmtwMDRqbE5WczF5eFBZUFAyd1VW?=
 =?utf-8?B?MHdjdnZuakhjc2FNcGtPNGpyQkVtNGs5dG0vZVZoV0JJWHhUUk5IejFKN25K?=
 =?utf-8?B?ZEFxVi9YSzgxYi9iMnZxUmhMWDNFbEJBRFlnMzkxNzNId29WcmZIQlMzS0V0?=
 =?utf-8?B?Rk1lYjlxYTlpOUt3MDgzY0IvR3o3Q1FDcUNhN0hTaFpaZTFEZmlzUndxNkI4?=
 =?utf-8?B?L051RUk0dWVyTEgyWUt6WXNlMk0rNm5lWk50UHpseFJuLzBQUlpHK1JhOXo1?=
 =?utf-8?B?RGpYdDgra1g1akFvU0s2WUUvYVpEY3M5NG9RdXdWRDZFR2FwREZLaG1DVmtn?=
 =?utf-8?B?S0tNMUNGYkRBeVlsZlQvTXpQYjhJRGE1M1FVMUozN2p5Ly80QmppRy8xb1BO?=
 =?utf-8?B?UmJxY2R5cTFHUlFGbm5NRERPd1lqTlhzS2JHKzRZOHZRKzBacWFCRWFJSUpW?=
 =?utf-8?B?QVdBVDZkbGI4cjBpSmFxbEZhaUlLeHc3Rm5uamoxL3RLSWkydXVQUFRSSncv?=
 =?utf-8?B?d2E0ZjNUVTlZZkJWMFpEeDROcXk5RVZHV1N6SWtUSUIyQjlNamRFR21lZUcx?=
 =?utf-8?B?WlMwSTZoSFJhN2tPOSsxWFpycWpOOWJGZU5MV0ppVnM3a2JtZnZ3UmhqQlZZ?=
 =?utf-8?B?NGZvcCs5aGROc2VwMENhZUxFZFUzTEhyNFlqd3dlMGRMdllISkMxTWcyOXdi?=
 =?utf-8?B?K2M4T0s2VDNQa21KV2RRM2owUGlFTyt2ZUVXRGdJSEM1cWVsTUljZ0hZTzdX?=
 =?utf-8?B?WHV6Zy9mL3NGdExZR2xKeW02RndZa1RaMTJpeStpU1NaVTNpWHlIRWsxQXhL?=
 =?utf-8?B?R24wUGgybys1MTNLVHRNckZGNW5MN3puWFMyMFhZWk81c0JMaEMrM3VaNUZ0?=
 =?utf-8?B?NFBGdmY5SWIweWNlRDZIOVZhYW5tZ3lGb1lFQ2kycVpEQms2MFBiK0Y0U2Jt?=
 =?utf-8?B?REdEUHlhSzVnenU3Z2xHeXQ3V0h1d1NzWk5IZW05RXlOMFdpWkdNdDJCUlRk?=
 =?utf-8?B?S05uenlWb3d6aURySzlBYjJ1UnZIb2t2L3dBY1gyK3RiMi9ucXFFYUVZSVM3?=
 =?utf-8?B?MzNNRjF2Sk04NU1MVjcvMDdNWlhtanFEV2phZXFLRHFibWdLc2dCaUFFVEh2?=
 =?utf-8?B?WHYrS24xaUYrYlE3VGo0VXRkSG04eEZXZ0tTUmVrZXErSDJPR29XSzJrYitH?=
 =?utf-8?B?ODV4U3RDeTZVUEhsQzh6Zy9KTmNhWlFrVFFYekYxaFpGdDlzR3FjaHQzQmdC?=
 =?utf-8?B?d0RWend0VGRTblBoMVMyQThwQ2sxekppdTkxN29qcUI5YU1TMnQxOWhSaFZa?=
 =?utf-8?B?ZkZlcTBsdlhMVkt6UUdiR040K2tuUHJRdTY0SmlCNEpWOU9xNjJ5MkFRQVVq?=
 =?utf-8?B?Rm43TUJpYm9EYkV1bjlIcHo1dk9JTjBKMGwvK2Q2b0QwNEY2azJ1cFBJdWxj?=
 =?utf-8?B?ajlxcVdUVU41WkY3WjJ3ZExuakhYcTlOc2JKbmdnQWZHU0RjMHYwQjEzVXpt?=
 =?utf-8?B?eFFZVko1dllSVmN3Mm45QzUvbHM4WFdMWWFQZnQ5YUZVNjVnTGU4bmtoaEdJ?=
 =?utf-8?B?UkMrTERucW5EcmdRY3NhYndGTmk5OUlMNHpvUzdselI5MjZIaTE3eEYwbjJl?=
 =?utf-8?B?d2ZFNHd0QnlhanplWEdYZ3ovNlluWHRmeEM1elB5enR4cG85NVY2NEJmNmFW?=
 =?utf-8?Q?NUTx52dO7ykUJFbG8AkDzHTYH+MyW7Twd3q7unW0iM=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 26eecf02-b001-491a-1dfb-08d9994c3dcd
X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Oct 2021 13:18:18.5243
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: mkPP8sTdc5T5cZP6MRdBnqn/oda+wV8GfmBW0aI6aLjSLPK1akCauD8MYp++DkdOsG6wCRi6gdAFlLZzCwKXDeR58beZtcL+ZsE1Uo/s2F8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB5251
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10149 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 bulkscore=0 suspectscore=0
 mlxscore=0 adultscore=0 malwarescore=0 phishscore=0 mlxlogscore=999
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2110270081
X-Proofpoint-ORIG-GUID: PHVel80CkDtcDBJSeEFu0PT_UpwjL2ir
X-Proofpoint-GUID: PHVel80CkDtcDBJSeEFu0PT_UpwjL2ir


On 10/8/21 11:01 AM, Juergen Gross wrote:
> On 08.10.21 09:44, YueHaibing wrote:
>> Return NULL instead of passing to ERR_PTR while err is zero,
>> this fix smatch warnings:
>> drivers/xen/xen-pciback/conf_space_capability.c:163
>>   pm_ctrl_init() warn: passing zero to 'ERR_PTR'
>>
>> Fixes: a92336a1176b ("xen/pciback: Drop two backends, squash and cleanup some code.")
>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>
> Reviewed-by: Juergen Gross <jgross@suse.com>
>


Applied to for-linux-5.16.


-boris



From xen-devel-bounces@lists.xenproject.org Wed Oct 27 13:19:46 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Oct 2021 13:19:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.216938.376731 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfiqH-0003tE-Nt; Wed, 27 Oct 2021 13:19:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 216938.376731; Wed, 27 Oct 2021 13:19:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfiqH-0003t7-Kp; Wed, 27 Oct 2021 13:19:45 +0000
Received: by outflank-mailman (input) for mailman id 216938;
 Wed, 27 Oct 2021 13:19:44 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=7jCJ=PP=oracle.com=boris.ostrovsky@srs-us1.protection.inumbo.net>)
 id 1mfiqG-0003sy-3X
 for xen-devel@lists.xenproject.org; Wed, 27 Oct 2021 13:19:44 +0000
Received: from mx0a-00069f02.pphosted.com (unknown [205.220.165.32])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 1bb01231-c11b-4fc1-b95f-c741fe7ebdbe;
 Wed, 27 Oct 2021 13:19:42 +0000 (UTC)
Received: from pps.filterd (m0246627.ppops.net [127.0.0.1])
 by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 19RCThJi016751; 
 Wed, 27 Oct 2021 13:19:31 GMT
Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70])
 by mx0b-00069f02.pphosted.com with ESMTP id 3bx4fyjr2g-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Wed, 27 Oct 2021 13:19:31 +0000
Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1])
 by aserp3020.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 19RDBZvB152600;
 Wed, 27 Oct 2021 13:19:30 GMT
Received: from nam12-mw2-obe.outbound.protection.outlook.com
 (mail-mw2nam12lp2042.outbound.protection.outlook.com [104.47.66.42])
 by aserp3020.oracle.com with ESMTP id 3bx4gcpfa5-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Wed, 27 Oct 2021 13:19:30 +0000
Received: from BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10)
 by MN2PR10MB4271.namprd10.prod.outlook.com (2603:10b6:208:199::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.14; Wed, 27 Oct
 2021 13:19:28 +0000
Received: from BLAPR10MB5009.namprd10.prod.outlook.com
 ([fe80::3c49:46aa:83e1:a329]) by BLAPR10MB5009.namprd10.prod.outlook.com
 ([fe80::3c49:46aa:83e1:a329%6]) with mapi id 15.20.4649.014; Wed, 27 Oct 2021
 13:19:28 +0000
Received: from [10.74.107.92] (138.3.200.28) by
 SN7P222CA0019.NAMP222.PROD.OUTLOOK.COM (2603:10b6:806:124::13) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4649.15 via Frontend Transport; Wed, 27 Oct 2021 13:19:26 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1bb01231-c11b-4fc1-b95f-c741fe7ebdbe
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date :
 subject : to : cc : references : from : in-reply-to : content-type :
 content-transfer-encoding : mime-version; s=corp-2021-07-09;
 bh=jCTLYwXV72ZLYxKASLK1rgVCwYnEc5zUYfHCCwskxkc=;
 b=NiecBS1TAnCZpFkBy5NP9ySagRcqARBYvsAipK+DBR3PeHozh1CTABbs+zhbbCQekciw
 DywrGd8e9HJXK6KgCnHHSqLucYW/6rn2B7znkBAeKn0gZeZlWDRJ0arHuafDNok5vz1P
 T+CqophffiXZzQV4BzZUjBAJ2KRk961zrivSVOtOILEO2WqeGCSCKxpSBsX0wjrIjmY7
 2zSD7OkuykUmBeBnAoVzj+vuITahgfPVO8M48Hy4z2t1+BomhbNiKa1e8sVz4dTdzTzS
 Hk3GUO7keKmFTP+ODq1+Gs5Fzhaf62Z1w7SeFZ4z6HjSUP/Zs9u7XQu9YuuCntr0n4RD HQ== 
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=LOJZ1Rexiu/qd2InrL50yxkQUG1dwEZa2Gzha6cZcDCGudhVqDP7IxsWJNziXzKGbSiDhJjFhBq0oMkwaXDSYGOkEAeyjLJbv/3wKPcJhYf6tFj8bF0Kux8t1PFEdlGTWwHOTqbEaH8iAphj5hhJ079oGLm/2L2fYHngQgE4t8HjTb18XVR5xSsnes2wuolkjarErIHpdPihKzdmTHJVTY+tT/tKqRWd90hE2ArZRaCyEmFJzkyi4Elo6oZuYMHpBy/+NCCmM/tjFDnYuF1//0DmdmPb9zHg9o/h3xRe9v5i3NVFZrt9WTkPZcju/zz3fsxiPf1ne8cgLU7AmK2a6g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=jCTLYwXV72ZLYxKASLK1rgVCwYnEc5zUYfHCCwskxkc=;
 b=YZsnI0xBMwvh6TsKlou5QGF4pb0qGRViZ0UKDce1g5SFww6+gzqzA3HBNxEGHfV6ucCLroWr0mSf1ID/nnPuIb2D7kOr01ot7syo3+cbSGn6zn9Ut/FouGGAtQX1Aa2BnfSfP17qWCJNjPB/t2Rz9q0jLvVvFmL4kALIAqS5Bupe3ECelcGGeTG1CQgJvzCbyfkQBW/lEru/zj78gyWMCsk2xnbB0FVVN6mIHYtsv/hOCRnJVYXg8JsG+6XUOw0bMVm3yfYu8kRLDYKYnVCiDWnv9N/ujrVUOr3ItUyZusFF4nz+bXtSmbyCvqiTRvOeGpG8/BLLKX7elrTXXt0fBQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com;
 dkim=pass header.d=oracle.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=jCTLYwXV72ZLYxKASLK1rgVCwYnEc5zUYfHCCwskxkc=;
 b=PATfkNBC+KJkJPcUukrGvLWOUqNKQtv035pYT30CFy3PUx+WjT1miThfKXLSK0QHoizvkuyROhSjX6idjPHtZlyagWs4CSqeFLbd8tIqS/qp3ulsv2GOdKuImMSqKyJDV4Cn4dsFyydDBFkKNvkEO5LzGZHyM09jOi4P3n6jmqI=
Authentication-Results: suse.com; dkim=none (message not signed)
 header.d=none;suse.com; dmarc=none action=none header.from=oracle.com;
Message-ID: <9ad3538d-e4c8-2b74-e7b7-c409af0c3eeb@oracle.com>
Date: Wed, 27 Oct 2021 09:19:23 -0400
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.2.1
Subject: Re: [PATCH] x86/xen: Remove redundant irq_enter/exit() invocations
Content-Language: en-US
To: Juergen Gross <jgross@suse.com>, Thomas Gleixner <tglx@linutronix.de>,
        LKML <linux-kernel@vger.kernel.org>
Cc: x86@kernel.org, Stefano Stabellini <sstabellini@kernel.org>,
        xen-devel@lists.xenproject.org
References: <877deicqqy.ffs@tglx>
 <bc88bc9c-d5bb-d9a2-0d48-c8703a613c59@suse.com>
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
In-Reply-To: <bc88bc9c-d5bb-d9a2-0d48-c8703a613c59@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: SN7P222CA0019.NAMP222.PROD.OUTLOOK.COM
 (2603:10b6:806:124::13) To BLAPR10MB5009.namprd10.prod.outlook.com
 (2603:10b6:208:321::10)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 383faa27-8829-458d-2eca-08d9994c674f
X-MS-TrafficTypeDiagnostic: MN2PR10MB4271:
X-Microsoft-Antispam-PRVS: 
	<MN2PR10MB427119097C230D131FE2A36A8A859@MN2PR10MB4271.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:854;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 
	zqGmL6Ux2LWA4SG4SNdjK+zE3BtGLsqCCTsinjhxR4cGhv1rP3nAEKuO0A6PAvXDyYB9MhMUKYXD4KbEgzLH0VTxineD1RWrZufeYuNvKOU4IP+yx4hOVzIueA6Hj7AC9b4M7sjqkn+8SYQJfLUPiT07aIZ4W4+6gIRLG5afiE61nvg2zvT7iv5JZ5fP+PF89O1/0ZbKvO6xkvrA7auW+9qkzKSRsNPiYkiJ9r3KBz0JDOXzQxQZ27bsaVED0lclIgrrEvYDFFsGPHEQDoswfF7MljFpePG3Bam5+4SJZUA+erpjATwJVmH7a3B7B56RBNFAUvDWlDPYQhqNUUrM8G5cRkWVUFBmOchq+BTQSut6WznoJ4XOoL2ZHKFmgy4ZeH5V//zQgSjsIFoHYEt2n+V4LfX/p7r5qRWpMUfQW9gO/PFHPas9hR7Laoaxo8NHAk0sgsxpP+7fwBGR1exwREQ/ay/pfFNBlj1bAx1WZQXt2q6DiW6oSOi4dL/NTVCm0mr/wLYV0k3JnJe87BOTQtKGgvQnNjkOTfvwe64/EqROjrVlb7wf0+WKqz5zoYzz0iHY+wFm8i++HBmgjgxHJVycpkeCGFUeemVbasqqcS5YO5hG7hf4AyVnECy/hfD1FMDSvqehFkyUQh0jHPLYp7ZzkEVtlKhAONkJQTtD90kYcJtgw0HthbaGgIu9hMg3NFrWctX4zpERlVn3rZEuYoDDF5en8tFvugjqxdzWvuUG7FYTbqBRREa6SSTKrQ8h
X-Forefront-Antispam-Report: 
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB5009.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(4744005)(44832011)(26005)(66946007)(6486002)(66476007)(38100700002)(6666004)(66556008)(8676002)(508600001)(2616005)(956004)(186003)(31686004)(16576012)(31696002)(53546011)(36756003)(8936002)(110136005)(2906002)(316002)(5660300002)(4326008)(86362001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?OVo5MEM3Mzh4SmdlYTV1ZDZlNy95N3JBTURxcFBlcko3UzdYWFhRQVpJK05v?=
 =?utf-8?B?WEJ0V24zRjJqM0grQkQ2VjJlWkdsMGdya3dqTGtUSE5EL3oxTEJsR0Jtazd0?=
 =?utf-8?B?aW5tQ3UyQThoUGJiMXEwcVh0NG1PVm4xSDVSbUZtTTdiRU03R2dWK3QrcXJj?=
 =?utf-8?B?VXdxV3ZiR2NHdEl1eWRHSmRvRm1IUFR3ZXMwU1doYVdhYW1OY096LzhoRm0v?=
 =?utf-8?B?QWhCMExjRmVQQ3JpZW02TzVvRUlKYTE1MWU2b1E2aHBnK3pMeGtYL2lGMWZs?=
 =?utf-8?B?b0ZnTE0zWGpUUEd2TXpUUTRRYUt1TTVTWkgrOE1CQ2ZTYUVHUHFSZjN0NVVC?=
 =?utf-8?B?YmRPOGF5WDNyOXhMVnRnSWJ3UE5iR3prdlBremUzY0FUMjZaWlBCMjVSN3pq?=
 =?utf-8?B?QUpsY1dab1VVeUdXNlZhMW5sS3YvTEc5ZkxDUk4yQW11RzJuS2dBdFFlblEz?=
 =?utf-8?B?bUhvMldnVytZa3NpYTJvUlUreUhYVUZ2VzJINGRzU2dObzQxOTVGc2JSeWxO?=
 =?utf-8?B?TWxhOUNhekw4clkzSlVPZTZtY0NSM1FGWDhvSGZhUTNQMmkzb1A3NFkxVEFn?=
 =?utf-8?B?UVBnbHBlMGtqaVdNa3ZSbndJT05pa2dIcHBBeDdheHFjN2lQaHpVeG5aTGM1?=
 =?utf-8?B?NUtGVmpDUkdPclVYeXd3YzY2VHNqMDJ1Q3paOUJGalUzWE9mcCt0STZqMnlB?=
 =?utf-8?B?aU5aS2QrTE1hYmhjOXMrbXZPNDhUREhhaUpqYVpXYW1UM0pMbUw0eWxKQU9r?=
 =?utf-8?B?UHA5c043TkRNTXowSG5pdmxLdmxCTUY2VDdjVGZGNk5Kem4waUxnUDM3eHJi?=
 =?utf-8?B?dTlZbHMra1JlNElVQXR4UWpNRWZ2VldUUFNtY3Joa2xoMmtsQ0kyMjR3bU1l?=
 =?utf-8?B?S2t5Q2YvdlREYmFYaEJwbjF0SWhpejRhenNKZVZvNTA0QTVrblJSa0hOU0gr?=
 =?utf-8?B?MEZScVk3ZW1aaXlrd3B0b1dZTVZZL3g5Q29KMG0xNnIvWGNFU1RnOENYTnE4?=
 =?utf-8?B?ZE9ORHhvdXJTejlMMnhuQW5SYk5Gek9FeUkwUkNOWHAzZmVGanUycjE3Zjg0?=
 =?utf-8?B?ZVdjRmF2S3pjSG1YRE5Icmdta2hkaENza25SWk9VZkM5b3VRelppU0htY0ph?=
 =?utf-8?B?MlF6ZXF3OGZjbVBtdjJFK3BRRmhBZjdlLzJjUkk0Ui9WUjZMVVhVRDZoNFE4?=
 =?utf-8?B?amE2N3h0THhnTytkSFNaTW5jL2QwN1I3RHd3VkZxSDByYjQ5YU5Sd3FDYVRv?=
 =?utf-8?B?MVRaVDQ0Sm0xclpvc0VTNEpCczIvOTNMWEFUT1I3dWxqdytVRCthOVRndXJY?=
 =?utf-8?B?TllHampWbmRSQlU3WTdpUUV3cW5EclBYQkRlZlRrOThQNE5ScGZtaVc3ZjY5?=
 =?utf-8?B?MVJvM29QTGJXaHJsZWgrQ1dkeU5iRXFJdGNySVRESlIyVFp5bU94cEJrd09Q?=
 =?utf-8?B?UUJFd0tFb0pBKy9rUVpCSk5vdlM5QjlMU2loQm90dzhwK3A1SjJwemIvUHdn?=
 =?utf-8?B?SnVIdjBvVnZPVU14bnBWODdaRENaVHRnZEp4RnZ0OTFkZzBmcEwyL0lTRGk1?=
 =?utf-8?B?bUNQUGhGditiYlZEdExmZTNjT2dxZWJLQVNwckJmcHU0MEk3dFkxWFpHUm5u?=
 =?utf-8?B?M2EyRWwxNThSL2EwNmNCeWttNHBPdzJuUkxERzFjenptL21YblJUWlZVa3BJ?=
 =?utf-8?B?d0ZCSXRDN1FZV0taVDlIODJEUXltWjkyM2NiT0FjRTJIOERVOG16Z1Y0emFn?=
 =?utf-8?B?SkRqN3U5ODRTdEF1Q0VqWHZEVDhVN0ZESUU3MGdHdTlJNkdDZUY2K0RIS0Vv?=
 =?utf-8?B?cUlSaENnTldQWkJDSmo2L0w2NVA0aFJOQ25VQ05sZW9UUUdvZ3ptYzkrTEh0?=
 =?utf-8?B?bFkzOTY0ZDc2b0loSE1lTHBJeUhkeEdSeDlYaE1GbXEvbmlXYVdRWnFQTGIz?=
 =?utf-8?B?R2hKUHAvYUJlU2JoOXQ4d2tyMnNWUW1qZjUrQmgxVEIzcjFmY2FQendMblM1?=
 =?utf-8?B?K05LUSszaThLSGV4L00vcDE2c2tTajk2dkdqUmVDOEM5ZzEwVTgvZnBJNDN0?=
 =?utf-8?B?Vk5rZC9NbWxkMFB2S0dNNUNSZ0VvTDBQTlFGcUJaT2Y0TUhjUDBDMWc3Uk9l?=
 =?utf-8?B?ckZGZ2tLYkNleW9HSjYzSVFmVTQ3WVVBYTNJTDRpd1l4anQzRTFIMktXVVUz?=
 =?utf-8?B?UXF5UkpJUlpwd0hVaE01QTV2SUlmd0hhZDdjMjMrd05Md0V1Q3BSdk9Dc0hM?=
 =?utf-8?Q?uNkamnSNUA3Ezjtjtv/1VO68PDxCgsdHn1bkOdlINk=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 383faa27-8829-458d-2eca-08d9994c674f
X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Oct 2021 13:19:28.1503
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: byoIO6OthIxkQFa6CDPb2C+Wm+TC1PS8YvLLtF+Qa5rY+3X9W236VDp3uE7X/Q5PmEWOApcsX3odN5LpPNx50WcBpH21d8Bepb6MjNGJnTc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR10MB4271
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10149 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 mlxlogscore=999
 bulkscore=0 phishscore=0 mlxscore=0 spamscore=0 adultscore=0
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2110270081
X-Proofpoint-GUID: eOQJ2Szt3I6r5wuYEzc0uKbYGl9H-sVJ
X-Proofpoint-ORIG-GUID: eOQJ2Szt3I6r5wuYEzc0uKbYGl9H-sVJ


On 10/12/21 10:25 AM, Juergen Gross wrote:
> On 12.10.21 15:33, Thomas Gleixner wrote:
>> All these handlers are regular device interrupt handlers, so they already
>> went through the proper entry code which handles this correctly.
>>
>> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
>> Cc: Juergen Gross <jgross@suse.com>
>> Cc: Stefano Stabellini <sstabellini@kernel.org>
>> Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
>> Cc: x86@kernel.org
>> Cc: xen-devel@lists.xenproject.org
>
> Reviewed-by: Juergen Gross <jgross@suse.com>
>


Applied to for-linus-5.16


-boris



From xen-devel-bounces@lists.xenproject.org Wed Oct 27 13:20:37 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Oct 2021 13:20:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.216944.376742 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfir7-0005EZ-1z; Wed, 27 Oct 2021 13:20:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 216944.376742; Wed, 27 Oct 2021 13:20:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfir6-0005ES-UV; Wed, 27 Oct 2021 13:20:36 +0000
Received: by outflank-mailman (input) for mailman id 216944;
 Wed, 27 Oct 2021 13:20:35 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=7jCJ=PP=oracle.com=boris.ostrovsky@srs-us1.protection.inumbo.net>)
 id 1mfir5-0005EG-Fo
 for xen-devel@lists.xenproject.org; Wed, 27 Oct 2021 13:20:35 +0000
Received: from mx0a-00069f02.pphosted.com (unknown [205.220.165.32])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id aaa66c2c-3728-11ec-8460-12813bfff9fa;
 Wed, 27 Oct 2021 13:20:34 +0000 (UTC)
Received: from pps.filterd (m0246617.ppops.net [127.0.0.1])
 by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 19RCTXgI023707; 
 Wed, 27 Oct 2021 13:20:33 GMT
Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80])
 by mx0b-00069f02.pphosted.com with ESMTP id 3bx4fj3hjw-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Wed, 27 Oct 2021 13:20:33 +0000
Received: from pps.filterd (userp3030.oracle.com [127.0.0.1])
 by userp3030.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 19RDK0YE078610;
 Wed, 27 Oct 2021 13:20:28 GMT
Received: from nam11-bn8-obe.outbound.protection.outlook.com
 (mail-bn8nam11lp2173.outbound.protection.outlook.com [104.47.58.173])
 by userp3030.oracle.com with ESMTP id 3bx4h2c3q8-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Wed, 27 Oct 2021 13:20:28 +0000
Received: from BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10)
 by BLAPR10MB5251.namprd10.prod.outlook.com (2603:10b6:208:332::5)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.14; Wed, 27 Oct
 2021 13:20:25 +0000
Received: from BLAPR10MB5009.namprd10.prod.outlook.com
 ([fe80::3c49:46aa:83e1:a329]) by BLAPR10MB5009.namprd10.prod.outlook.com
 ([fe80::3c49:46aa:83e1:a329%6]) with mapi id 15.20.4649.014; Wed, 27 Oct 2021
 13:20:25 +0000
Received: from [10.74.107.92] (138.3.200.28) by
 SN7P220CA0002.NAMP220.PROD.OUTLOOK.COM (2603:10b6:806:123::7) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4649.13 via Frontend Transport; Wed, 27 Oct 2021 13:20:24 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: aaa66c2c-3728-11ec-8460-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date :
 subject : to : cc : references : from : in-reply-to : content-type :
 content-transfer-encoding : mime-version; s=corp-2021-07-09;
 bh=L9W4r73MtAXDYeLPSmVSL8I7yuybLpV30uuTJpDGZkU=;
 b=GXOwsif/zXyYPmjJHLQ0bHv4oWuuB8BCYizHOdZX7PqwdPIVtf6ucFq4+FTE8qJoJlA3
 N9TVhWvmk3GpKJWf8MdOZNbDyW7WMFAt+Jq1ZAfA2uoNggROJXF3S5lbFEzdNVZ+Sy77
 haQrx9Zm9GG0IgfdJvjjMPK+BJ5A4/DC7qoDEfBJV146ACvqsP3GFR7V9JDM41X8VSmC
 J/9xWBRql0dfF9z1uNPSA8FhuMUVhtK/MyrmyAs8VLbdQ5248YIRaJN6spiLfi6pTWTa
 QiaazvebUxh9aH/p4XXqMIt+Jp8QONUclFziBY2YG8p+55D5v5Ot9PQA1WeXwdpa9/ms KQ== 
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=O5eOWHKoU0xcQpWjilVDUyRgCDsE9yc1Mp9HImX+29N8KeQ0WJPI1fWkZHGSqmBzZg3V6AtA7z7kXW9CGpBn7FBSc3n2N/M5I+UBMxREcLZCUoUMrHZQjVYlaNndE83qKgD2LaqgBueARhwI47kJQuWASojSKfdd9l65tcG8YrvFAhSBoSOt6w6HIbCzNbCHiwfFtJbwRpmXx3+uuoYWr/ZDozTsXNxS6k50yvcSKmv4l6DOUe6gaKduPsB/F61QR29urUJETlB0lP5CPG5TC2W4eHlqCVttE17YT94DZzBFIXHHGKTQeC4rYjsxQt5VCsXpkmCBhpwJSBciMKlQPA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=L9W4r73MtAXDYeLPSmVSL8I7yuybLpV30uuTJpDGZkU=;
 b=NPPjcAi3rsM4TW+UO+Z5ifWOHSV21EYlKU709N4V0hb3nhJ/DsylweBa3enZb87ZL9uyr4V62Vx881XchfZEHksA2j1gYMVCWoO4iw8R/j3157gjcT0AEPcmUN0dEoZVSWRKgqz+LGM9vc2I+O6z/qEHjqqSZzPNFpPO/kQ46A1S1V1v/x8V3ijvyTZQja505BP9d0P/sJGO0uWxD6+yanyldZtIdxwNO3rXgUFYrJoruTuwUlN3OD1OXTg+HjBU8Q4+Lb2X602jWzXspE7vvziO9jzqqmvIhFDFj6/qtz6hy4uazGvz8cIX5zhVMB7O5CdJ/xVn90sJO2qOzRPJiA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com;
 dkim=pass header.d=oracle.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=L9W4r73MtAXDYeLPSmVSL8I7yuybLpV30uuTJpDGZkU=;
 b=tG03PjNEiBAb6CMRdB/Fp7opGnxS4nrPgVvG4n7s5izBmx3jomm5TenF6RZWANPxcNHY9kC5eAePZlXZ3XEA565DUyR2MHrjez7lA37DBmBdNeLO0ZpSz/ihlZuejbVfTkCoiUoLXlUW2OqzmToAFVt7JlOeOWq+QVDd55juf2w=
Authentication-Results: kernel.org; dkim=none (message not signed)
 header.d=none;kernel.org; dmarc=none action=none header.from=oracle.com;
Message-ID: <34c7914f-c647-c110-c269-1c1fe51d6f39@oracle.com>
Date: Wed, 27 Oct 2021 09:20:21 -0400
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.2.1
Subject: Re: [PATCH] xen/pvcalls-back: Remove redundant 'flush_workqueue()'
 calls
Content-Language: en-US
To: Stefano Stabellini <sstabellini@kernel.org>,
        Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: jgross@suse.com, xen-devel@lists.xenproject.org,
        linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
References: <2d6c2e031e4aa2acf2ac4e0bbbc17cfdcc8dbee2.1634236560.git.christophe.jaillet@wanadoo.fr>
 <alpine.DEB.2.21.2110141242320.9408@sstabellini-ThinkPad-T480s>
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
In-Reply-To: <alpine.DEB.2.21.2110141242320.9408@sstabellini-ThinkPad-T480s>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: SN7P220CA0002.NAMP220.PROD.OUTLOOK.COM
 (2603:10b6:806:123::7) To BLAPR10MB5009.namprd10.prod.outlook.com
 (2603:10b6:208:321::10)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 463e9f9e-6a95-46a2-7e88-08d9994c89ad
X-MS-TrafficTypeDiagnostic: BLAPR10MB5251:
X-Microsoft-Antispam-PRVS: 
	<BLAPR10MB52510CB7E7B799FC61A385878A859@BLAPR10MB5251.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:2449;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 
	noGnT8sumRBW/FshnbUF9/CA+PbVvujSMc0cazwQ2muoH9cucCu8roDrOUmjhwCPE8zZOQlR9lsJZI5RpDvcFTmbPxC/4bntBO/Daa1bJP5WNpRqz4xY4j1FGV0EvlEtxmIb75s1Z3EyCFsbY0mQLkva51//BBhumi0KmsDcrfCPNG1y3bv6sqNAtdBbWQAhOngu+zcdtY2Ihlthkked/w2CwORUjjgcuRHicVPdLF5+0iOROmNaLq3qucj0vAbOdIzeFy7ehB3E/0LYTi8W7lS0jg1YuCDg1URIHWPVSiJStv4LrcyiobbMFqXEvxvdFcnKavmudniO8MI7UF4EJWz0RQMMfS740EvixmtOR9lCmz+agRvh99aBlyOefokne0UnGz0SyjNDhrDYDjVKI9z7eNNSHxRJC4RwBvlrizLCM0hgoWFyDGVS2J55UFo79zujYO/jLbyiIvMztmX+x/V1wyP2/LOGl4M1YHVEMkl6cb7Q5FeHrP056v/wWeAYR7zyepAK6TyWckEGxHkEwA6v+PV5y2OXKW0/7pnnYM/nfRJgagtBmRd+TdYDCdk0/GRws/AswW8JFBEHpzmBs5Q+tA8jIT6MyQByQgerjBA0+HS38F3gZFhedibzob9MGsADjQPBgRsws/7wAItLiR//TPmGg0K55N16DHiX6yyETMOFNce+u0BLJ2XMgLNa0wn0jBZV2Y1qKsITLZKEPJ23xPcFlfpBNK+fg5a6rxE=
X-Forefront-Antispam-Report: 
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB5009.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(6666004)(110136005)(508600001)(36756003)(956004)(53546011)(8936002)(31686004)(2616005)(2906002)(4326008)(86362001)(6486002)(8676002)(26005)(186003)(66946007)(66476007)(66556008)(44832011)(38100700002)(5660300002)(16576012)(31696002)(4744005)(316002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?M1N2ck1rQk5HK3EyQTRIUldPa1NPVGwvUVJ2eVI5S1Q5TGJaWlVYcjZZQkdT?=
 =?utf-8?B?RG9KWSswL2ZNd1lOS0ZtQ05zVE9zUWJFTVZCT2NvUm9wWTBpM3dQY09oS21s?=
 =?utf-8?B?WEVYQTM4SGJqSVFGaThYSGEvMGc2MThkVjRZaXJsbzRGUXd3VzFFSFJFVFo0?=
 =?utf-8?B?Y0E5WEtlQ25UdTBUUnJCMlFqSmVFWGZEMFQ2TS9uekErR2hmczFZQ3EvemVu?=
 =?utf-8?B?Vm9scVFIT0VNemh4Y25pYUhvTEJDTUl4OWZLam1GRjJibWplc3VpSHdiSjZ4?=
 =?utf-8?B?bjYzNVB2MUhtWEtYeThoM0hzY0lJZGpzem01SnMveEdmdXdaWGJ5S3hVM08w?=
 =?utf-8?B?aUhRT0NkWnViMXk3VllJKzByNC9qaExTMXVvNmZzQlpQVHh6bmg2Q29SSkE0?=
 =?utf-8?B?dlJvMmk3bUM1UFM0T2RORGhVTUtzSXFxVitBRHE5MVIya2p1QVV5N0Q2Ynpt?=
 =?utf-8?B?UFgyV3lEazBONHg1Sk9VQmQwdzBIQVY1NXVidUpoWHhHVFl0eVR1aEY5QXBy?=
 =?utf-8?B?Y05Vb2NsU0Jlb3FUUmU5QVJZbytFMVUxNS9wKzR5UHg1OWttRmYzVnFQMXhG?=
 =?utf-8?B?VGc2UEZxcThIUi9lbHB1L3ZNUnh6WlBMQ3Bibm93UUUyN1NUOEFjUDJmTWx1?=
 =?utf-8?B?em1nTGh6OXFDNlpudVdQanBNS0RMcUtwaXlKOTNQMStUeUN2dEpRb1Y0Nlds?=
 =?utf-8?B?Vzk3MjNRN3JJYmhYL0k5cmMwOUU2Rm5jQ080Tm1vdyswbEN6L2FtUmJMeXJq?=
 =?utf-8?B?K3VLR0NCWHQzeWEvZlM2MUk3WldXbWRqcVZIZ1llaG80RThaRDFuZitmVmlO?=
 =?utf-8?B?ZGJmSDVyT1BKRkdnMm5hNDlDSGhPVm1LS1BHVWpJUzV2MkZ1aHMvMXpLRi80?=
 =?utf-8?B?WXpBQndQVEtoc3Rady9Zc3BKazZrN1F1cTFMVUlNS01jVkdwRmFPalZhbVZ4?=
 =?utf-8?B?M2pqWmdvS1pRLzRwaldwNFMrZUdvUXZFR25rLzgyNFF6cnBURFJhdkpSaXho?=
 =?utf-8?B?TmhhRWQ3aFoxQlo1LzVFbjVKNG5LRXp6UUl3NzdQUzlDU09oejBVc3FjWVN1?=
 =?utf-8?B?R1YrWnlUTmlaTnh6NFV6blp4RGpuUkFHTFZsWUNNTEFUc2NqMjNtb3Vib1RK?=
 =?utf-8?B?dHdFVGsrTkNuajhXd2ZKUXdwV0xONWJUMFBraE9pRWtSQ3JPMGVWQ1lFSzB3?=
 =?utf-8?B?YUVMQStNcHVsWmFHS1pjOVowK2JPaG9WOVpScnMxRGtiTmJiK283K1l0d2Uz?=
 =?utf-8?B?Wnh0WHlYQ095dWtjOEtsTEx6MGk2Wno2R0UwTEwwMFhvenR4MC9nRXFMVHRp?=
 =?utf-8?B?c1BaYlJtR09mU3ZFd1o5SE5RNk5mZ1NuS0ZvQXp6UjB5YUFkekM1bXpTR0xQ?=
 =?utf-8?B?TTcwVnBaZ0FkUjVVNkZIdVJaMGlIUy82VjFDaHJvVFQ4N0l1OVVSc0x5bGJo?=
 =?utf-8?B?MG5KS3drbFEzRDN3ZUFVOWxkdkU2L3Q5cTJkOExqc0VZWGI1alUxTDUzeEFR?=
 =?utf-8?B?dGU0Y0MwZWlSeUJGbVFzTnFhRVdoYXhqMTZXeXZnREhOajk4WnhQSnBxbmcy?=
 =?utf-8?B?TStReWthQ09CR0tLUHQrMUVka25Fbm9SaTVsME1WR3BzT0VMVUNYQkwxK2xa?=
 =?utf-8?B?R2dpY1loNDNXRTZuanJsSVhqREhoNXRSd21BSEJmZGt3REp2Nm5tbmpYVzhI?=
 =?utf-8?B?Uk5VbG1NamNmUW9xS2R3Z3pRZUZweCtvWHRzY2tRb21naTB4b1Mwd0ZESkNx?=
 =?utf-8?B?RlBqT3VxanZPdFJvYlhteVRXMzVoblFzOGl2bjFqT3J5cmMzakF4SFpJTDhm?=
 =?utf-8?B?aUY3am4wRUVVRTlpUDFkR2lsT2d6LzhmSlhyN3NhVTU2bi9ZZ3ovaFl2a0c1?=
 =?utf-8?B?VlZrcFhnbFZKQlY4N0ZjMS90YzU3V1I3MGlDU2h6RW5yZ05kWEM2dS9NR3lK?=
 =?utf-8?B?SFlkbVI0UmV0UExweTdJQ1VreGRTV2k2ckhYQVNIalAySjVZYzN1NXlPaEFU?=
 =?utf-8?B?T2kyYW9XVVJscTZxWGZFaXpyTnozTjhSVWt2dm5ucFhUd2lOSUVCbVNZSnlu?=
 =?utf-8?B?d0JCOWtmSy9MYVlBVm0zbFFxWWZhT2JkNHZrRGl3alZvaEtQRUpUbE5obW5k?=
 =?utf-8?B?M0E0YS81MUxFcjUvVnBtelIxSEs2V0VOTmExUHlWWE16b1Q3bFJkd3N2MVFJ?=
 =?utf-8?B?djNDUHFpNTJENENiempNMDNDUnh3UEF1NzhhWFd5TUZsZFppd0FaamxIcFZH?=
 =?utf-8?B?N05uRVViSVFkQ3llWktUU05TU3JRPT0=?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 463e9f9e-6a95-46a2-7e88-08d9994c89ad
X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Oct 2021 13:20:25.8129
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: FRtforF920aRPKwzBhUlGajh7h+pG0/pv+08mzcKtHecM8tasqR4Ss+dOqIShyvR9ya8kWGIuKwGnB1nJ9I/FddSZrKpgVajNaLCuMgiMp8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB5251
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10149 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 bulkscore=0 suspectscore=0
 mlxscore=0 adultscore=0 malwarescore=0 phishscore=0 mlxlogscore=999
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2110270082
X-Proofpoint-ORIG-GUID: udi5c0VZCP_WOdHgimML04apw505sWvu
X-Proofpoint-GUID: udi5c0VZCP_WOdHgimML04apw505sWvu


On 10/14/21 3:42 PM, Stefano Stabellini wrote:
> On Thu, 14 Oct 2021, Christophe JAILLET wrote:
>> 'destroy_workqueue()' already drains the queue before destroying it, so
>> there is no need to flush it explicitly.
>>
>> Remove the redundant 'flush_workqueue()' calls.
>>
>> This was generated with coccinelle:
>>
>> @@
>> expression E;
>> @@
>> - 	flush_workqueue(E);
>> 	destroy_workqueue(E);
>>
>> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> Acked-by: Stefano Stabellini <sstabellini@kernel.org>
>

Applied to for-linus-5.16


-boris



From xen-devel-bounces@lists.xenproject.org Wed Oct 27 13:21:30 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Oct 2021 13:21:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.216953.376753 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfirs-0005sA-Eo; Wed, 27 Oct 2021 13:21:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 216953.376753; Wed, 27 Oct 2021 13:21:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfirs-0005rz-BY; Wed, 27 Oct 2021 13:21:24 +0000
Received: by outflank-mailman (input) for mailman id 216953;
 Wed, 27 Oct 2021 13:21:24 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=7jCJ=PP=oracle.com=boris.ostrovsky@srs-us1.protection.inumbo.net>)
 id 1mfirr-0005rt-Tw
 for xen-devel@lists.xenproject.org; Wed, 27 Oct 2021 13:21:23 +0000
Received: from mx0b-00069f02.pphosted.com (unknown [205.220.177.32])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id ef23d07e-da83-487e-8ca0-2511f0171745;
 Wed, 27 Oct 2021 13:21:22 +0000 (UTC)
Received: from pps.filterd (m0246630.ppops.net [127.0.0.1])
 by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 19RCTjTU017577; 
 Wed, 27 Oct 2021 13:21:20 GMT
Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79])
 by mx0b-00069f02.pphosted.com with ESMTP id 3bx4fg29tg-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Wed, 27 Oct 2021 13:21:19 +0000
Received: from pps.filterd (userp3020.oracle.com [127.0.0.1])
 by userp3020.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 19RDJvYC055161;
 Wed, 27 Oct 2021 13:21:18 GMT
Received: from nam10-dm6-obe.outbound.protection.outlook.com
 (mail-dm6nam10lp2103.outbound.protection.outlook.com [104.47.58.103])
 by userp3020.oracle.com with ESMTP id 3bx4gr2dea-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Wed, 27 Oct 2021 13:21:18 +0000
Received: from BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10)
 by BL0PR10MB2883.namprd10.prod.outlook.com (2603:10b6:208:73::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.15; Wed, 27 Oct
 2021 13:21:14 +0000
Received: from BLAPR10MB5009.namprd10.prod.outlook.com
 ([fe80::3c49:46aa:83e1:a329]) by BLAPR10MB5009.namprd10.prod.outlook.com
 ([fe80::3c49:46aa:83e1:a329%6]) with mapi id 15.20.4649.014; Wed, 27 Oct 2021
 13:21:14 +0000
Received: from [10.74.107.92] (138.3.200.28) by
 SN7P220CA0005.NAMP220.PROD.OUTLOOK.COM (2603:10b6:806:123::10) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4649.14 via Frontend Transport; Wed, 27 Oct 2021 13:21:12 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ef23d07e-da83-487e-8ca0-2511f0171745
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date :
 subject : to : cc : references : from : in-reply-to : content-type :
 content-transfer-encoding : mime-version; s=corp-2021-07-09;
 bh=XeUytp3hIPU0AtblceHI1LRrE4kwQgGDTm2effsGT+s=;
 b=Iu7hrbT7DsjyLG4l6tQL9+wMYk3BtKITUpYMcWAZAtETT4EFJK+xgQrNSCoYthLYAhkX
 /xXEG8+cOMJp19vWtxsxFz+y/i6xf4CIely652KhZczafjyvjF4LUql1hGZyMUaAJWKQ
 6Y3aPWB8yaarAE48wg5CR8J2jysDvPFuHXmtvzMfYHD6TbImpqk0O+Pxnr03RexWRfCt
 GaB71qvSUdkQDlsNnXbbVlLpUvmrichoFoB9rveqPhUgnyn5TMt83gqSPpDDoAS1aplB
 Pos437EvANWFWYDzjt4cS/TntgpZNHRqKh6aPRDXk7Jq6Dt6aXIGGQL64I9+E8U/wPNa PA== 
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=WpkrwFBE+kVkrKsgp2333kG7IbMPIPg1dFkuaH+F/paye5JO/mf9f8IM5xPBahb3kukgQWjNv8QkF1+MzNJf/ntw+/pKNdkShZ6I9gXnc1T9G1gHE4j1FRA/8OnQh/6yTEQkPfLfCme8a2Jlc5ao6YEsJ5/rEi5qft52H/YEW2UJlF1w6Iw4kArnwrafjQQK+ne31e/o//FqVfYilf5IH/OMibq8fknpzTM8Rb0JSw0H6OZldMlKmxMJOCSFtpUSKgHB/bTMokpTr8u4fBUBp04fPyr1OBWA40g8BUvYjQ5dpPWQwV8NzsMOfGwu6PMKV75ebFbMhL9x++ttal7XyQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=XeUytp3hIPU0AtblceHI1LRrE4kwQgGDTm2effsGT+s=;
 b=N03VFWWpWDG+u9ch+IM8jK7Hj4WsmlYd9xbmMfcLXGKbdPBHituIFPaZXwFq13zoWV90QosdSqWZhZCuwknUh+uKJOT6ondwF6dU17DAf9avKxA+fS8WfoNbmbZygnJoXjJt87vlT3UMvCe4zXteNfYtyt2ksmoykQR3226EzD29rQECl8K7UKFKafFmn5x8sCR0Lfx0Z8SXdY87L8hYV2n4HYMGO/JeSAc2R9uxY2zQgGYilRufRoVFz/z2vPmwdklNMjVFEt+H91J5z8sCX+5CQm77D+2irUWSkOTt5PQ3dsV2j/FWEVtyx47aTCGfYVoxNiPCEs64cHavrqwmkQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com;
 dkim=pass header.d=oracle.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=XeUytp3hIPU0AtblceHI1LRrE4kwQgGDTm2effsGT+s=;
 b=pnn+EJdVJQ8ISyl6dpIhYAY0/n5BLFG2grSo6QMSucQBNVK3/BV/zIAO+RIJpoC33W0QfnGI9h9ll3GRqaF9fb3HI4kZZpgJFEtTkeuw1sL08edvTOj8823KNDi2hWAsBPxNJW1ZncIooB6ggdsXfebLUUamRt+ndvYzZbfKYhw=
Authentication-Results: suse.com; dkim=none (message not signed)
 header.d=none;suse.com; dmarc=none action=none header.from=oracle.com;
Message-ID: <f08cdb58-dbcc-406a-d3ff-cd4ca507efb9@oracle.com>
Date: Wed, 27 Oct 2021 09:21:08 -0400
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.2.1
Subject: Re: [PATCH] xen: fix wrong SPDX headers of Xen related headers
Content-Language: en-US
To: Juergen Gross <jgross@suse.com>, xen-devel@lists.xenproject.org,
        linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org
Cc: gregkh@linuxfoundation.org, Stefano Stabellini <sstabellini@kernel.org>
References: <20211015143312.29900-1-jgross@suse.com>
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
In-Reply-To: <20211015143312.29900-1-jgross@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: SN7P220CA0005.NAMP220.PROD.OUTLOOK.COM
 (2603:10b6:806:123::10) To BLAPR10MB5009.namprd10.prod.outlook.com
 (2603:10b6:208:321::10)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: ea34547b-6dde-4d0f-b0f0-08d9994ca676
X-MS-TrafficTypeDiagnostic: BL0PR10MB2883:
X-Microsoft-Antispam-PRVS: 
	<BL0PR10MB28830C063A9C5F1184E406218A859@BL0PR10MB2883.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6108;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 
	lYCEK6eUt5bF8P7R1aVwawdmxr3BQ3rp5IIow1mo2KsA8MflYTT+KBB3MGAYM2Xmstezpe2Y5pH6gRfsjnHpFOB3zY04aLd32PNs7DoWRyZLahWCkHJ72Jqa3HH8crUpgpyO4M753B/38EqYfJSd056QbNJnkD+eJ9P6IF4TJ6lnLgNKfrRqECFcC9xX0tuRa2PQfhUYB9mTngQ27RuTKqvZyaIKkShCkmH/7rPJkgRnoZ8HO2+qpI0657AcBVB0zdgt3dEeRTJ54iyiHW7UXSq4bJrC+BRGCK9mWwUrA5U0tFYBouHsO2E27AUvbt1riMKjj0EtkxdTvrfBlVX7U6Gwz/XqEKJVvFcDaI4e1RQfusTnEHTy5PRdEbl61aiaVjwzfl+dBf3Jv0QsqMp7IO9stxYw0qIPW38paNaESjSxBtASVD4uGPp8589LCxj/qtMe4cZPLOYGTNcqXE41IYIhpJC4JnYJfnvqPl6AeCBhKiXFPblS7f6kruKZ3MToZ0c2gt3hoLnfmnCd0Fk26nrtiDbMc1W9UMTBf1D+ZUBz1ab7CzvCymmdUp6ohQiw5FzubtZYmdtO+YgRQ2g3JXio3+GcgHcpbTcWehZ1W78B+86y1lrAXa800T+OFepSrSNeL2rHUsZTZOqjDSSECE7KN1sPI7Tf7LGKe0UetgtVXX1wYoUoJ4zfYhZU5j7EYlYc1LN1mlvSe6chlhHvf1lUS3ELOt9wP9yuEsggWAo=
X-Forefront-Antispam-Report: 
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB5009.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(4744005)(31686004)(66556008)(66476007)(66946007)(38100700002)(8676002)(86362001)(31696002)(956004)(2616005)(36756003)(44832011)(8936002)(5660300002)(53546011)(6666004)(26005)(508600001)(186003)(4326008)(16576012)(6486002)(316002)(2906002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?NFdRQ3JhbXkzdmtYWEQ2TU90U3B4UG5VVTVlSUVUOGdRUWVBd2dhSlY3UjNS?=
 =?utf-8?B?UHJaNmlSRzZkbGxiN0szZko4N0pxR3lxNDNkL0t1SmdOQ2lvb0xSM09tWnNH?=
 =?utf-8?B?RmRnSUZiR2dJVloxSEJPdTMxVzFaZEFsMmpKYXZycllaS0kzeDN0ZVRVYzBF?=
 =?utf-8?B?REhqUk04L0lUbUdHa1o4MUh6c0RpZzJmVk5tWjAxeis5dG5JeU1vL1VIa0F2?=
 =?utf-8?B?WEFxTDFvMkMyS2JVSnNvTm8xazBPN3ZRRUxmZmdCdmp0NFczM2lyVHN3eWJz?=
 =?utf-8?B?WXpJaXRCYzhQUFM4eHlhMkdOaW93THBLUEhCUEYxTjhxczBoY09oY2JabXpm?=
 =?utf-8?B?emVrUExGRS84NjdvejUxdU5MMFFiRjVhK3JnOGMxeXhYekNLdk1RRXk5cm9V?=
 =?utf-8?B?cS9LMTIraWtzUC8vWCtTWW1EdlZHUXBHbXJIamVWZlNwTnM1YnBRbERvUWZa?=
 =?utf-8?B?YkFsWWJZSFNxb2tvdXZDV3RIaFpqUmJ3VGxJYUxqYUt4WXpCUktFOHdtcVZy?=
 =?utf-8?B?ZVdIN1lQd2JIWjBOSGtEOUMxNWdZMnNZUk9INm5OTUVKckNUaG81L3BxbHZL?=
 =?utf-8?B?SGhYMjNXTldFSDc0Tjl1WUxyRDNBd2VkT0RtanVGdDh2ZkUyemN5bmF3a2JX?=
 =?utf-8?B?cTQzaVhWNVhwOEZKcEp0ZFlSemlTcmlEVzhXL1JkSDRQbHJkYzRiYXFoMEk3?=
 =?utf-8?B?NExSS3owQjBFQk1ac2srVVJzc2JrVjFGTmpvbWZyajErTklKV1RGSHpwdFVG?=
 =?utf-8?B?QlhlQWtOM3RHZ3Q3RVE1S3RadW9iUDhMRHNCY3VVMFJGcVIvRHl6SXJjQlNY?=
 =?utf-8?B?Q29iMDRBTm12aGkwbWtqNWpVR21rODdDeUFaMUJjeTlvVk5qWGVLMURKZ3hV?=
 =?utf-8?B?NStPZ2F5T21lbUFnSlArN21ONVVnbS9XaExrN2E2aHV3SEpIR1Z0enRLSStL?=
 =?utf-8?B?MWdhTFlRWnJIeVZzYy9aeG1JZUp6RVpSbGpIVkZraGkySG1xRzN0UjZ2ZjZ3?=
 =?utf-8?B?RWtnQ3pKeUQybzIrbGlSVDZtSnRuRFQydVJNNitGOXNnK01SRkU1b25PWG1F?=
 =?utf-8?B?eXlLb0QrajFMSEdla3FmVzMrYWtWdERLdEdsOVdmSlp5c2NUNmd0UGJLUURu?=
 =?utf-8?B?SHFDcTZVcTVCaVFPWnZCUUJ6WmpxRXpnUkNjQXVTZDNkMGpwbEhvSE1oTzdj?=
 =?utf-8?B?cnNSaENodXBCVURjRmFPYjdUdUhxVnQ4YXY4V1d0bUtVZG1iMjVBcWZHaktK?=
 =?utf-8?B?cEJDRTNySmhPOTNUSTJ6WTZuc0FYNXYvRjdBeDVHeERnaWdHQ2FHMUJ6eERm?=
 =?utf-8?B?ZzRteXJSaFhNRTVEaE9YUFVkVjJHNE4rbGNUREtIeEE0VWlVVGRvYSt2VUd0?=
 =?utf-8?B?QVdNQ1FmTkprUE5paDhJNGRXQ0JyU1VzUFNIaXRyRHNKbHJFNitUZGZtNVB1?=
 =?utf-8?B?ZDh4VSsrak14UUNVbEorV1UvVVg3SGt0SVZXQmh4VEo1S21TN2M3YlVncUpJ?=
 =?utf-8?B?OVdoMGxqK0xRbE5RblR5YjU3Si9jdXVaYlYxa0RzTVR3MDlaNzM3TmxENzZZ?=
 =?utf-8?B?ei9vcjArYllBWkJKZ0FhT2JxMVVJYjFtMnhxdmNvOTIwcjlXazFUN3lvbGZO?=
 =?utf-8?B?d0ptODVrVU5GbGdpYSsyenMzRTh4RXU4M2VNTHhMMTBqcGZGTGlwcVkrNUVi?=
 =?utf-8?B?WUczYWRsUFRMTUVEeFR1cEg3dDR5L2plcEp3S25xNHpiWmpWcFh1YjNGQXg1?=
 =?utf-8?B?N1ZpQTNXS1pKTTZDTVo5eU5GNnVwU2tUREpEc0xRM3pQcjJPaU9DY0FXNkNY?=
 =?utf-8?B?Z0hmRytRL2RJbDFhYzdnc2h2N0hDbW54MnNST1NqajNoT0luN21rOTNtZWNw?=
 =?utf-8?B?MVZZRzdNbk1yTWIwNTdNZEtsQW9KMXk3WDdVdE56NS9DK01uT0p5ZzBWbHJV?=
 =?utf-8?B?ekxkMXp5dENhSWhCS0ZCVW1xTGU1MjNpL3RSMmN5dCtBRStrOExkRXFHSDd6?=
 =?utf-8?B?THNLT1Brc2JHZ1BoUEhqa0k1TFA4V2x6aEhXN2lGWUh3dDI4S3ZLV0ZldWk0?=
 =?utf-8?B?ZDJzRzg4ZDBjbHF3UjZoUnJHQVNwY2tkUGh6djZGdk1hcW9RZUNoWHR1bzZs?=
 =?utf-8?B?d0pyb1ozK1JQNkY0WkhNbnpOT0NKV1VlZkNibVgzb3lVNDZNUE1IVlBZMnRJ?=
 =?utf-8?B?WUx2ZXVqNmVPZE8vNDdMbUQxdmo5NjdoUDkwWmhJTm9NZ3FZL1FUTjk3VHJ6?=
 =?utf-8?B?T1kzZi90L0RhYjg2Y2lWRVh3bzN3PT0=?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ea34547b-6dde-4d0f-b0f0-08d9994ca676
X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Oct 2021 13:21:14.1774
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: B9quMx5P2gw/dBWae72opcDJhiIBFZqZ7cUnvUQePZ3cfpCiamvwhCMdH4IiJmzjEfUYZftxG2VNMIIgdISovkKlhJxzMSvwRTY08dgLkq4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR10MB2883
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10149 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 malwarescore=0
 adultscore=0 suspectscore=0 bulkscore=0 mlxscore=0 spamscore=0
 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2110270082
X-Proofpoint-ORIG-GUID: O23f2bqCU6iHhSNnYTERd-M2G1K2CNrc
X-Proofpoint-GUID: O23f2bqCU6iHhSNnYTERd-M2G1K2CNrc


On 10/15/21 10:33 AM, Juergen Gross wrote:
> Commit b24413180f5600 ("License cleanup: add SPDX GPL-2.0 license
> identifier to files with no license") was meant to do a tree-wide
> cleanup for files without any license information by adding a SPDX
> GPL-2.0 line to them.
>
> Unfortunately this was applied even to several Xen-related headers
> which have been originally under the MIT license, but obviously have
> been copied to the Linux tree from the Xen project without keeping the
> license boiler plate as required.
>
> Correct that by changing the license of those files back to "MIT".
>
> Some files still contain the MIT license text. Replace that by the
> related SPDX line.
>
> Signed-off-by: Juergen Gross <jgross@suse.com>


Applied to for-linus-5.16


-boris



From xen-devel-bounces@lists.xenproject.org Wed Oct 27 13:22:47 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Oct 2021 13:22:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.216960.376763 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfit4-0006Vq-Q9; Wed, 27 Oct 2021 13:22:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 216960.376763; Wed, 27 Oct 2021 13:22:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfit4-0006Vj-NH; Wed, 27 Oct 2021 13:22:38 +0000
Received: by outflank-mailman (input) for mailman id 216960;
 Wed, 27 Oct 2021 13:22:37 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=7jCJ=PP=oracle.com=boris.ostrovsky@srs-us1.protection.inumbo.net>)
 id 1mfit3-0006V5-J9
 for xen-devel@lists.xenproject.org; Wed, 27 Oct 2021 13:22:37 +0000
Received: from mx0a-00069f02.pphosted.com (unknown [205.220.165.32])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 9642b59d-ee01-460b-90c0-08173d1a9a57;
 Wed, 27 Oct 2021 13:22:33 +0000 (UTC)
Received: from pps.filterd (m0246627.ppops.net [127.0.0.1])
 by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 19RCThLl016751; 
 Wed, 27 Oct 2021 13:22:07 GMT
Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70])
 by mx0b-00069f02.pphosted.com with ESMTP id 3bx4fyjrj1-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Wed, 27 Oct 2021 13:22:05 +0000
Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1])
 by aserp3020.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 19RDLXCD187936;
 Wed, 27 Oct 2021 13:22:04 GMT
Received: from nam12-mw2-obe.outbound.protection.outlook.com
 (mail-mw2nam12lp2044.outbound.protection.outlook.com [104.47.66.44])
 by aserp3020.oracle.com with ESMTP id 3bx4gcpjjr-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Wed, 27 Oct 2021 13:22:04 +0000
Received: from BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10)
 by BL0PR10MB2979.namprd10.prod.outlook.com (2603:10b6:208:7f::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.20; Wed, 27 Oct
 2021 13:22:00 +0000
Received: from BLAPR10MB5009.namprd10.prod.outlook.com
 ([fe80::3c49:46aa:83e1:a329]) by BLAPR10MB5009.namprd10.prod.outlook.com
 ([fe80::3c49:46aa:83e1:a329%6]) with mapi id 15.20.4649.014; Wed, 27 Oct 2021
 13:22:00 +0000
Received: from [10.74.107.92] (138.3.200.28) by
 SN4PR0501CA0129.namprd05.prod.outlook.com (2603:10b6:803:42::46) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.12 via Frontend
 Transport; Wed, 27 Oct 2021 13:21:58 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9642b59d-ee01-460b-90c0-08173d1a9a57
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date :
 subject : to : cc : references : from : in-reply-to : content-type :
 content-transfer-encoding : mime-version; s=corp-2021-07-09;
 bh=gEiO1xZ7xTyZWBanmfxng6/b7T/MSvtCaGAWP6qE6Ow=;
 b=HYZE37+4Uy9qdC3P4YoMWH6RhV5kgiARU3psiLfqJ6jgdHHdfZcGmM4H62+2jz5oedmI
 wV6HNu1FusfjVD/gkpRTTdIdRMtpEG1aICaJUMJT/dbPxVdyzB4VQx4Q2Dzkh6Vzp+VK
 45PHKqQOwyrFtWQLDVnUzVe4JY0CZoLArHtpQ98K8ZrOVb4djwz1Mh8j9Pgyb+M832OX
 d3jEe5MZn4a4nVAWmFI0x6dfCzO+zRRtnj+WE5f4KjICE0GW8hbNjk6z3zjADnt7WSia
 nhMlgaLac+qUt0YRFUzBUoD99ciDKF5hZriOKWBQX9+/sgBgPcPzHjPffnLXzLgLRCOO rw== 
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=TrPdJ0PEZzxInUP96LPjRuJr44d7VigoQXYMnQzAOxejVXfHFjiu3IjVCU9GWPcFrPyDLDBeKyZBENaDfUcdB/MTCm3OZ61fKPodxxGl+1MVBy2BcmvS2QhMlYAmpxPPvEpnFEt0xnTq2FuPzoFVTzfaQusd45S31Ald9EBeYoFLkx+R0yeIOvUHyctaFx9qSln9aTB1MVi4Dix6X8LRejfsPr+2eiq/rg5NTfKq6UYTOcdl/CkQKg8joizYxVkL/VhcbKxfdutQoeQmnic6BsYJIylQDKRixuH5hSMKl2ezKyT7dAm6TnL7X1zSWUVnCN6qUwI35AkpKKXcEo3MYw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=gEiO1xZ7xTyZWBanmfxng6/b7T/MSvtCaGAWP6qE6Ow=;
 b=Go0jVe78DZuBwguk5EZwjz281vApnxMlGvVOMqWu32Z5IrsIbXWLRSyONL6Hj0u4NGxtkyCmHuaEe+gOPjEV//u6HDJPAaYgzXsgaYxPeCor2MsuMBJuxHfVB/bdBBq2ipuKdAoBBuu+YKbfoeq15lQhgvNet4BJu+yVcOn70RaOAubZmlzCsOpG2dGmNbsGJIyEuoc/fhu5PBdkujmGON+QRzyeGs/Sojlxyv24Xl2hkT1eWNT2XRKS5pCaf8datFdS+tmCtJQ5Yq3etwpQO5cbK4l1/0ZJ8dwfqx5d0/kCvITCqRx5mnoM+CSqlC/lPfwYFlWOgogifAzCrtVIvA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com;
 dkim=pass header.d=oracle.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=gEiO1xZ7xTyZWBanmfxng6/b7T/MSvtCaGAWP6qE6Ow=;
 b=KB6XeR1vvrDYLrjoaAbmVwL+blLIHmBU08HO5uQBKx8ul2VHALEO+nosyYjQ1TXFcF50fWdMU3dSu6xa2A5M8cIN+vSa3S+Qaiji6LAlyyNkGQs9RB2rlOCKXJOk7MTQkr9MweSufxc50zUJrdyz/MmMNJKvdvK00Y1do/jxe8s=
Authentication-Results: arm.com; dkim=none (message not signed)
 header.d=none;arm.com; dmarc=none action=none header.from=oracle.com;
Message-ID: <7f6dd8b6-8b6b-54a7-35d6-da78b18ec59b@oracle.com>
Date: Wed, 27 Oct 2021 09:21:55 -0400
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.2.1
Subject: Re: [PATCH v2] xen: Fix implicit type conversion
Content-Language: en-US
To: Jiamei Xie <Jiamei.Xie@arm.com>, Juergen Gross <jgross@suse.com>,
        Jiasheng Jiang <jiasheng@iscas.ac.cn>,
        "sstabellini@kernel.org" <sstabellini@kernel.org>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
References: <1635233531-2437704-1-git-send-email-jiasheng@iscas.ac.cn>
 <01fd083e-e9a6-c019-0a74-bf28b2982412@suse.com>
 <VI1PR08MB30564CABD02DBB0F17BBDCDD92849@VI1PR08MB3056.eurprd08.prod.outlook.com>
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
In-Reply-To: <VI1PR08MB30564CABD02DBB0F17BBDCDD92849@VI1PR08MB3056.eurprd08.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: SN4PR0501CA0129.namprd05.prod.outlook.com
 (2603:10b6:803:42::46) To BLAPR10MB5009.namprd10.prod.outlook.com
 (2603:10b6:208:321::10)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 9c119ab2-2e95-4b64-09e3-08d9994cc22f
X-MS-TrafficTypeDiagnostic: BL0PR10MB2979:
X-Microsoft-Antispam-PRVS: 
	<BL0PR10MB2979C8E9F8348182922DACB48A859@BL0PR10MB2979.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:2958;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 
	vOTgBT7lBDEIH9Qg3oV0gPWbODaIa62AN7Y+N/tEI8aePO0H8dVFjdspn2WBxipRwQhIJpN7LzsCmQUlUxxgFZSkzQYOQ37NHpnRYR0L09jFc7BygSGohCl16TUZSb0yw03V8eQf0lHnJHOV7Rw0mgjR+BQmBzbo/IW5fJL2537xwie3D1s5rwFfB0ivLEAH1+sn4B4+fGWjHHwgeGHR7aSVlKNSV77EHaIcL5rpw1dNrkgxTgFBmsS/1426z0m6RisxVBeEl7B6AiM12pg16F7yKW++Pw3t3kp57rOcxPQAkixEsi3+UkxfL0wZzaDeRWCEUjS0ksLyQ+gWq9azTlttpHx7zwEbiKgx577sEKqd5wTiVQA0hBOFKl5vlY64HtP6AvY+CCTGEz0vMnBp2b2octYCrhsGaLk1dVsffY/0ElgeG1BebuPAcLEY3fQSWiD9AK2dJsVtafLbkyo1DC7Pl3DGwrKRYOdf1LpDCS5IzwCD1ZUoDWBpuX/g1FdX428vuk5gfloAVB/D4pGnkRuXDofK6bvt4rMDlZtQ/5+XVW7MMk0n/AI9cAjoUDJGcmBwZSdWllT4Q0Z0QHK4L48wUfku8I9/vRPGCCyV9BvnUiuB0l92rfnkwecGe17LT3EUMoYv19iASBpiTpeeayl3aT9bCyNU62gzVGPIt43R2vPNOr4zZKwz0jQxSmXe47F6UM1J2hf/BbbG7yrj7M9z0VccuFS54Ijn564K0Do=
X-Forefront-Antispam-Report: 
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB5009.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(508600001)(66946007)(83380400001)(316002)(956004)(66556008)(26005)(31696002)(186003)(66476007)(16576012)(5660300002)(54906003)(36756003)(53546011)(6486002)(8676002)(38100700002)(4326008)(2616005)(44832011)(110136005)(6666004)(2906002)(8936002)(86362001)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?UUMycVhyb3cwNXRSS0VmRmdkNkhSem5hdlNTalV0Mk13VXRjMHJiei84UkJY?=
 =?utf-8?B?Yk5jWVRsczA0WkpmNThJUTJ3MGd5M0l3UDlzSnVZOHk5WVJ1eHdjanhEcXE1?=
 =?utf-8?B?WG44VCtLVUhIeWxnNUlvajViV2MzSmhpWjBWMFdGNnZ3OUlrOXlZeEkwVHRC?=
 =?utf-8?B?V21nYTJNVzBOY3F3cXJHaHlyTXYwbkhldit5TUlyZTdPNTgxcHB1MGVYeGc5?=
 =?utf-8?B?TERDbTE5SFhvZ1FzdFE4eFlWbnJwMnQ0V1pDNzBRM2hxS0lKZHgvbDZVQ3kr?=
 =?utf-8?B?Z3lzU3NtdmpGTWhkZW40bXRhcDFFaTBmby9LMEw3eHpSZFk2U29lRWZtMUZn?=
 =?utf-8?B?UUhkSHh4cXV0SWhOS1pVbkNGcHVUSDJoWVllVUk5R1FuY0NtVGVuM3RBTVpM?=
 =?utf-8?B?eUhvdXpNQVZBWFQ5OFJnRzhQSjNQODNldC9TOFF0MDI1RWxFdG94TWR2azNM?=
 =?utf-8?B?SGdrb0hQMHhhVU14UmNseXIwREp3YUFySTRENjBZeFlNS3B3c0NBWTYzMVk1?=
 =?utf-8?B?bGNlYUdEN083SmFISnVmUjc5TXlBaHFCQzlPYi9jcmx6OTNHSGJ5cEtkUE13?=
 =?utf-8?B?TnZQSU9nWGVBSmRTWUhJUXJnaUc0TGZSRXVkdGpzd3dveTVxYVNoMFE2UlJ3?=
 =?utf-8?B?cDU3S3NDQUwvVjZ1bmMvK0ptMlE3VWl6dUN5ZElqeTl0a2J5NkpDLzNqSFdM?=
 =?utf-8?B?Y1Y2bXkvUzVBdWxneWZNaC9sSzJjek5pVXVtWThWdXF4SjF4Vy9iWmZIRVZS?=
 =?utf-8?B?SXR4ZndycXhpUDdoUVVVSHNMSnpYd0Z1Smx2YVVCTkx1T3o0Q0U3ZXNjaDdJ?=
 =?utf-8?B?UUxzNXFXbk9xYXk1S2M4UWxMOTNvb3h1dlZPOFhOUEJnY3dyUVp2bVBMVTYx?=
 =?utf-8?B?WU1wM1d0Ylp3VVp2ZXFBK1JtT0p1R3U0dmhDQytYZUVyWFlHVXdtUnRYSE9N?=
 =?utf-8?B?bGl2QmVSSDNSRXNEMXhRaFhGS0hQL09VTk1FNTY0TklVL2NERjgzTk5mbUFp?=
 =?utf-8?B?dHVOaUd5STdZcUcyZVZJUlQybTQ2OHRTbmFXd0orWjVRcDhaemk1eWxtZzVH?=
 =?utf-8?B?ZVN0Y3duaDhUV2ozelJXWHRqakM1NTRXZ0V4UTAxMGdlMWtZY3NVcStiMGZa?=
 =?utf-8?B?NnplVTdyMlEzV1NzR1A0MWxjYVFYcUVtc1AvMk1MaFdQTVVDRzFSSTB3VUkx?=
 =?utf-8?B?OFBzb0RQSWNzUVUxazBhdWFHVHk4REFvRW54Q1lPRTl0YnBXTXpZNnd6QVFx?=
 =?utf-8?B?ZXhEQkF3TXMvaVlrZEJ5cHZqNEh4SkUwa2hIVG1wcy9ZQzFod0g5Q09CSmc3?=
 =?utf-8?B?TmpRNm1qNHcyQXJ0WE1DQUxzc1NzdTQ5OGU1T1lPOVVUOGh0SFpoN1JzNW04?=
 =?utf-8?B?blFqOFBGV1phN0NOVHhJUlRqVEdYOU1EVkpGT2VhR28xNzlZdnB4YjB5UnFZ?=
 =?utf-8?B?UjZ1S0pUUkxMNDJUWm9vTHZpaHgyNWRIL0RYR2hlOTNvSG1IOXlXQmdPcnhs?=
 =?utf-8?B?NFBXQkRickNOTEdLL2ExZ2pDTnMyTGNMNWpkYUszeVBEQTRaK1Eya21Ib2o0?=
 =?utf-8?B?TkprZVZaTHdCWXNQL0VRTEU5ckNBeEJSd3BqaTJzSmFzaFozZGJkY2ZsZUtr?=
 =?utf-8?B?NzdQZEhBeGVzYTdyVTQrUFhURThaVnpqU2x4V1RJd3A0VDFqTHgxUDYrUVBz?=
 =?utf-8?B?OXVJMHpsMENQaXIwN3hXRlBYa003SU0yOXBmTTVFekhKYXM3eDk2U3NCcmxp?=
 =?utf-8?B?V1o4REVXQWtCbHloa0JzSU5MK1hUS3BTMlZFZklyeTd0SVNxUUFDZnpWSGw4?=
 =?utf-8?B?OXVsSnIxMmJwR0pzclVXa2lZUXExbGdlWTVua1NwUmdUTHo2bFNYdmlTWkUz?=
 =?utf-8?B?SlZ3bWxUcmJUa1l3VWhTUXJNUk1NdUR0dnRDYUkrbXc3QXY4cjZTRzdmS3VS?=
 =?utf-8?B?WEk3djVwOFJueEhhVElTb2NMMWd1NkVOZTR5QVFIZEpVbFp5c2xqOEk1VFkx?=
 =?utf-8?B?T3lOUnhoRGRMTnYvMUhJcytSNUg2UzdyQmF5TmkxSmZ4WUMxYzNyUEJ1TWpT?=
 =?utf-8?B?dDBaSkg4K3AyVjRVWWp2NktFMVpGemdsZUxHdUc1YnlyekRpM3NSUVJiSWM5?=
 =?utf-8?B?cWxVR0c4ejFDZG10YnRORS9kSVJyMmZnTTFsbG1NZ1pWRHRSSnVZNS9lOVY4?=
 =?utf-8?B?YTVUNWNoSEV3Tm92cWQ1OWdVelhMVFlFdDN2ZTcyRUpiR0E1NE5sRjlNM1VX?=
 =?utf-8?B?MnNVTThaN0p5WVJzYjFWL0QyMXlRPT0=?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9c119ab2-2e95-4b64-09e3-08d9994cc22f
X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Oct 2021 13:22:00.7129
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: E6E/U6TfPsNHQbL0DfTJ7ngyZbez1QtpL9n2LtAt1thRq+m2R47RligHm8/BAOsjTYSOsRhq+LWEYGxWo1IvfJ45h9tdKebGL4YfAn+JPzg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR10MB2979
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10149 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 mlxlogscore=945
 bulkscore=0 phishscore=0 mlxscore=0 spamscore=0 adultscore=0
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2110270082
X-Proofpoint-GUID: Ud_BLW9H_LV1RsX4s-gURqnzf7Mm35-T
X-Proofpoint-ORIG-GUID: Ud_BLW9H_LV1RsX4s-gURqnzf7Mm35-T


On 10/26/21 5:59 AM, Jiamei Xie wrote:
>
>> -----Original Message-----
>> From: Xen-devel <xen-devel-bounces@lists.xenproject.org> On Behalf Of
>> Juergen Gross
>> Sent: 2021年10月26日 15:36
>> To: Jiasheng Jiang <jiasheng@iscas.ac.cn>; boris.ostrovsky@oracle.com;
>> sstabellini@kernel.org
>> Cc: xen-devel@lists.xenproject.org; linux-kernel@vger.kernel.org
>> Subject: Re: [PATCH v2] xen: Fix implicit type conversion
>>
>> On 26.10.21 09:32, Jiasheng Jiang wrote:
>>> The variable 'i' is defined as UINT.
>>> However in the for_each_possible_cpu, its value is assigned to -1.
>>> That doesn't make sense and in the cpumask_next() it is implicitly
>>> type conversed to INT.
>>> It is universally accepted that the implicit type conversion is
>>> terrible.
>>> Also, having the good programming custom will set an example for
>>> others.
>>> Thus, it might be better to change the definition of 'i' from UINT
>>> to INT.
>>>
>>> Fixes: 3fac101 ("xen: Re-upload processor PM data to hypervisor after S3
>> resume (v2)")
>>> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
>> Reviewed-by: Juergen Gross <jgross@suse.com>
>>
>>
>> Juergen
> [Jiamei Xie]
> Reviewed-by: Jiamei Xie <jiamei.xie@arm.com>



Applied to for-linus-5.16


-boris



From xen-devel-bounces@lists.xenproject.org Wed Oct 27 13:24:16 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Oct 2021 13:24:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.216967.376775 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfiuY-000783-6h; Wed, 27 Oct 2021 13:24:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 216967.376775; Wed, 27 Oct 2021 13:24:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfiuY-00077w-3j; Wed, 27 Oct 2021 13:24:10 +0000
Received: by outflank-mailman (input) for mailman id 216967;
 Wed, 27 Oct 2021 13:24:08 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Ie0f=PP=citrix.com=roger.pau@srs-us1.protection.inumbo.net>)
 id 1mfiuW-00077f-I7
 for xen-devel@lists.xenproject.org; Wed, 27 Oct 2021 13:24:08 +0000
Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 293f06a2-3729-11ec-8460-12813bfff9fa;
 Wed, 27 Oct 2021 13:24:07 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 293f06a2-3729-11ec-8460-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1635341047;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=Zb6gF6I6P83yeH5HqUgwwsMR5qHmEktyMPeulOHwFBM=;
  b=D0wF6zox/E4+XJxEHGb0vKGHSoiUzBvH6VDUeLEMzIofqj7d8ZmkMdzW
   XRWVA7RjpfTKBd7e5xaX2jXuG8x4bN/AO9qTXxIvP/YS4EAhOejxjpvQi
   xpdhPBMA1cibxlvSMj3ZFahBoccgvljrHmAY9WcocvAzfA5OA5xOa2QjW
   g=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: cFF7Sw0Y+xlXo8KFiY59jOI52ASDPfYXUmhB+92C0sA9Rof9E6QF6ACalXsC7B/EXoFS09Zmzp
 /5m+x3aMVEQjlSbmI3M6J+1X78acoMm0UGHyMa/V1RDH+QWKKhlvQSgHRL+CeK08mQ6MxI0ETl
 nvhnIWfvJqEaqNTQmZIIvyQYUvlrhDNP4/GK/AAENZuxR17ZB6UDk3HJUfKjFa9SRrU/VYX0fW
 H35iP6eaBWPvmf3hH+yDwNPDjYK34bFretcOXS1VAfDA1ax9KzBCN2f12VQ2lx81yt0k6ul9SA
 qar3zus8nYrzXumcM7fRCsLW
X-SBRS: 5.1
X-MesageID: 56354113
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:ZNMCUKKotycgjmLzFE+Ry5MlxSXFcZb7ZxGr2PjKsXjdYENS1TQBx
 2BNWz2FaPiOY2umLt10b4zk/RgFvZLQm4NlQQJlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s
 q3yv/GZdJhcokcxIn5BC5C5xZVG/fjgqoHUVaiUZUideSc+EH140Eo5xLZg6mJVqYPR7z2l6
 IuaT/L3YDdJ6xYsWo7Dw/vewP/HlK2aVAIw5jTSV9gS1LPtvyB94KYkDbOwNxPFrrx8RYZWc
 QphIIaRpQs19z91Yj+sfy2SnkciGtY+NiDW4pZatjTLbrGvaUXe345iXMfwZ3u7hB2Thvoh5
 NpDkaetagsQZ7HOnsVBXklXRnQW0a1uoNcrIFC6uM2XiUbHb2Ht07NlC0Re0Y8wo7gtRzsUr
 LpBdW5LPkvra+GemdpXTsF2gcsuNo/zNZ43sXB81zDJS/0hRPgvRo2Xu4QFgG5p3aiiG96FO
 5EHdyA3Ry7sRBxvNHg8OatlzP6n0yyXnzpw9wvO+PtfD3Lo5CVrzLXoB//EddWLSNt9k16Ro
 yTN+GGRKi8dMNuT2D+U6EWGj+XEnT74cI8KHbj+/flv6HWRzGEODBwdVXOgvOK0zEW5Xrp3M
 UUU5y5otqk0+0yDR8P4GRa/pRastBMGR8BZFeF87QiX07fV+C6QHG1CRTlEAPQ2uclzSTE02
 1uhm9LyGScpoLCTUWia9LqfsXW1Iyd9BUgGaCwfRA0J+e7Kpo0pkwnPRdZuFq2yptDtEDS2y
 DePxAA8mrESgMgjx6i9u1fdjFqEgZzETRU84AnNaV609QNyZIOjZIuA5EDS6LBLK4PxZkKao
 HEOlsya7eYPJZKAjiqARKMKBr7B2hqeGGSC2xg1RcBnrmnzvS74FWxN3N1gDF1wGJYodjHNW
 1LwtToI+J1VHSenPaAiNupdFP8W5aTnEN3kUNXdYdxPfoV9eWe7wc1+WaKD9zuyyBZ0wMnTL
 b/eKJz2VS9LVsyL2RLvH79FuYLH0BzS0o86qXrT9B+gzaaFLECcTbMIITNihchosfva/m05H
 ztZXvZmKimzssWiPUE7EqZJdDjmyETX47is86S7kcbYe2Jb9JkJUaO5/F/YU9UNc15pvunJ5
 GqhfURT1UDyg3bKQS3TNCs+Muy0Dcwn9CpmVcDJAbpO8yJ7CWpIxPxGH6bbgJF9rLAzpRKKZ
 6BdEyl/Phi/YmueoGlMBXUMhIdjaA6qlWqz09mNO1ACk2pbb1WRoLfMJ1K3nAFXV3bfnZZu8
 tWIi1KAKbJeFlsKMSojQK/2p79HlSNGw7wasoqhCoQ7RXgAB6AwdHOo3q5tephdQfgBrxPDv
 zur7d4jjbCli6c+8cXThLDCqIGsEuBkGVFdEXWd5rGzXRQ2NEL5qWOZeOrXLz3bSk3u/6CuO
 bdcw/3maaVVl1dWqYtsVb1syPtmtdfoorZbyCViHWnKMAv3Wu8xfCHe0JkdrLBJy59YpRCyB
 hCF9O5FNOjbI8jiClMQelYoN7zRyfEOlzDOxv0pO0GmtjRv9b+KXBwKbRmBgSBQNpVvN4Yhz
 btzscIa8VXn2BErLsyHnmZf8GHVdi4MVKAut5c7Bo73i1V0lgEeMMKEUiKvucOBcdRBNEUuM
 wS4vquaiuQO3FfGfloyCWPJgbhXi6MRtU0Y11QFPVmIxIbI36dlwB1L/D0rZQ1J1REbgflrM
 21mOkApd6WD+zBk2JpKU2y2QlwTARSY/gr6ykcTlX2fRE6tDzSfIGo4MOeL3UYY72MDIWQLo
 ODGkD7oAWTwYcX8/iouQko0+fXsQOt4+hDGhM36Td+OGIM3YGa9j6KjDYbSR8AL3S/laJX7m
 NRX
IronPort-HdrOrdr: A9a23:DdPkoak37+x2fxnKLPdkQXMHM8DpDfO2imdD5ihNYBxZY6Wkfp
 +V88jzhCWZtN9OYhwdcLC7WZVpQRvnhPlICK0qTM2ftW7dyRaVxeBZnPDfKljbdREWmdQtt5
 uIH5IObeEYSGIK8foSgzPIYurIouP3iZxA7N22pxwGLXAIGtFdBkVCe36m+yVNNXd77PECZf
 yhD6R81l6dkSN9VLXFOpBJZZmIm/T70LbdJTIWDR8u7weDyRuu9b7BChCdmjMTSSlGz7sO+X
 XM11WR3NTuj9iLjjvnk0PD5ZVfn9XsjvNFGcy3k8AQbhHhkByhaohNU6CL+Bo1vOaswlA3l8
 SkmWZsA+1Dr1fqOk2lqxrk3AftlB4o9n/Z0FedxUDupMToLQhKQvZptMZ8SF/0+kAgtNZz3O
 ZgxGSCradaChvGgWDU+8XIfwsCrDv0nVMS1cooy1BPW4oXb7Fc6aYF+llOLZsGFCXmrKg6De
 hVCt3G7vo+SyLVU5nghBgt/DWQZAVwIv/fKXJy//B9kgIm00yR9nFohPD2xRw7hdYAo5ot3Z
 WzDk0nrsAIciYsV9MOOA42e7rBNoX8e2O+DIusGyWTKEgmAQOEl3el2sR/2AmVEKZ4uKfa3q
 6xFm9liQ==
X-IronPort-AV: E=Sophos;i="5.87,186,1631592000"; 
   d="scan'208";a="56354113"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=mcN3noz0xxnCv1Hrh7HDDEwAucWOXw8Ysg6BbRkC+LUQsDsKGGPWii8enJOKx8IqX2ZGqt+7g0cUopeeUnRDIRw5yM2KcqoZQ8LSwkoU9TqGCJEaToZrSr/t5ecZA0c6II/P1aKvpEa1VAYZlVqqDOqSqBmtNEcCOmX4yKmVFnuJ59tOz7fBEiup5w1harB9aDVfhbPp8g0wtvtmYfB39PPvByaTsEZ8THRtvbHRlnRJcy7smwIRIeOP6yfjdn02eBgtoBMFW5wuDff4KzK9Q93RnkW/q5bgl4NhKPLdfOJq1/FG5/VR0TKPt3Q/G6NRs3apqcivvdfZRun2pAFeTQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=JE5xfLqvEgTX7DCAiYY1bVSPmz+g5/It3HNMaqoeK28=;
 b=dQkSJXZeCUf/WarlFvJztbwO7K/m2ExTTOOTiolG07dOyTYUXYPVKKtoF8hXCp8ExqIsbTYSCfn6U9XYMM4BK7I1qeRv+J5QYdD5LPfDpImlwIezo5XNuRVKUrauEOEQM+lqd/eHuSIfPGG2VvhKiPK8XEwTSR5ldffKmDLZTyTVmj5Om1l/pHRi9BL6+Tc8/PSvrUBeokYPw4YgLc0ssDRtSq8jcwTsVczApzotFSZ8884kHqbi3neXbEW1E5RG/lZmharLUcLii+UKjxKxZEFKjX6Grre/R+NPilHY4p9OAD/XDGa9bAQbnedppIP9NGnwARo5bZseypqYW3Hvkw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=JE5xfLqvEgTX7DCAiYY1bVSPmz+g5/It3HNMaqoeK28=;
 b=TdMQboZ/I74CAcyOyS1SVzAzwzV04XFLUH+l+Kp4b1BzAvPtuoYCqqM0VSELCwzRLlwrtaSHWKBtOXAACpIGNkY+LccS39uX/kO58ENX2BVqUn2mu4SAZed+NP9uOa2EWH3VwMdOGoULuk5Ubd6viAvwP1OnpXkai+YP+MRGTek=
Date: Wed, 27 Oct 2021 15:23:55 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	"julien@xen.org" <julien@xen.org>, "sstabellini@kernel.org"
	<sstabellini@kernel.org>, Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Artem Mygaiev <Artem_Mygaiev@epam.com>,
	"jbeulich@suse.com" <jbeulich@suse.com>, Bertrand Marquis
	<bertrand.marquis@arm.com>, Rahul Singh <rahul.singh@arm.com>
Subject: Re: [PATCH v3 03/11] vpci/header: Move register assignments from
 init_bars
Message-ID: <YXlS68Ghrphi5dHB@Air-de-Roger>
References: <20210930075223.860329-1-andr2000@gmail.com>
 <20210930075223.860329-4-andr2000@gmail.com>
 <YWbkZ216FbV8lBns@MacBook-Air-de-Roger.local>
 <89e1f09e-c840-860e-e596-38fb141aa707@epam.com>
 <344cf880-8f76-1a71-d27c-e7ba10459d5b@epam.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <344cf880-8f76-1a71-d27c-e7ba10459d5b@epam.com>
X-ClientProxiedBy: MR2P264CA0018.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:500:1::30) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: e7509a0c-e10f-462e-328c-08d9994d0a9c
X-MS-TrafficTypeDiagnostic: DM6PR03MB3945:
X-Microsoft-Antispam-PRVS: <DM6PR03MB3945DF5D8680941CC6E27DB18F859@DM6PR03MB3945.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: Wpdq+j8d6/OBoNKaJs7f2dJ2g3OopKanH4yJOzR7XcKcPivTSKhwwVV2i2WVPh/csREixIlBHvpqXGUK32ERIZ9zLoTxE3Q1oCaAGMHImGtaaXAW70AG4NsunzYsYNOdmGqUr85mOTkkUvMFBTFjHH9RvNE+0hHYy8U74QxieELIisQTKKPbDN6LpC+vChCqaIEfe+bp6mX5GuOXoCyb/RaA3FmpyjY1byh5awKaSgr+HJD9HES2fwGCK8MWHktWKrFcTHEXnJX/esMxXqgoJ1EsQT2OfNkPb/CwtdK2h4htBIZurzEeqwlK/9W/+JfszUsd+l4IFBkd7dGQ7a4MuBw/XyWJEKBnVoCmnwvpvVX0KLfX93RbmN5Ft5rppQRFfymaHl4mcpwSLzAnWkJbW6g5/5Q6hwVFHwqSj0oZC2qAThTsIiT0ZHH9o609fAkKt585hqcBNarx5H4ZSHlGFA6G3cTKOaJCDoXFf7VOfbNf6X6+zLo7C22yWbJLmhYYdmm7oqgimBCCAwdrFolVeK1Oum2HeulhzsEcirDyQHmTgqHTp4qsawRz03go4nh6cFzxs3bf/1Sk/mZ1gtqtt77IgVO9d59ty72P81AjG3MiXIx/P6cefj3QHl1wpdPSBw+x/IuuTNDfby0QI00ALA==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(7916004)(4636009)(366004)(26005)(956004)(66556008)(5660300002)(82960400001)(2906002)(508600001)(33716001)(316002)(66946007)(83380400001)(54906003)(4326008)(53546011)(6666004)(66476007)(38100700002)(9686003)(186003)(6486002)(7416002)(86362001)(8936002)(8676002)(6496006)(6916009)(85182001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZGNOUnlyZEhkeFQwVlk2UmtxTmJnM3JGTWJUSjZaMVFrbkF0d2hUdCs2UzVv?=
 =?utf-8?B?RzRzKzZDM0JHZFI0OUR6V2FkRWtodllPWjM5MEVyVGJCSEhSSWU3NTRkeFQ5?=
 =?utf-8?B?Z215RFZCc3VvMC9wMWlIS01ZcmJLV2hmZjNpNUkvV1FYMTVGWUdiZEVpV0t2?=
 =?utf-8?B?emtQR2xhMSt3WE11L1B5eU5KM0ZneFVVSFFXcHVVZEV3aktTakJ1aFlhanYy?=
 =?utf-8?B?SUlNV2VyTXVqZ0J0NTRtOUgrL0xmSEVsTU9xOUhvMW1zL2E3OWc5aEcySExy?=
 =?utf-8?B?YnUxeXhmUmRsb2dMSHd2RElHaURMTEhYeVdYYWgwdXVtenB4QWdVaGVKNkM2?=
 =?utf-8?B?ZjJlbHlsOHRJb2V3b2E4TkhQQjRIMlNQa0M5STVYb1lEOWoxSkFvNVIraTl6?=
 =?utf-8?B?azhWdHc1MzdHd3U3OTJpWU90NEpBQUR6Q1lnTnFENVEyeEovQ2JlaUZDVE1L?=
 =?utf-8?B?YTJzRG02Rlg4MUlDU2ZKdzJYcFZVekJ2U3pQS1VoYjFxZ3BXRG5IYWNkUFB2?=
 =?utf-8?B?SExtOXY0b1VvQTJwcUhaVjZOZzl6ZE91VnZFRTlaWllSZ2kzai9VM0UxK0ha?=
 =?utf-8?B?SlZFNHdqOHZVakRWUkozRk1waVE4K1Y4dVY3Q2Z3YjFVWnpNQ3dyOTQyVXJp?=
 =?utf-8?B?b1ZKL3ZnUjRjYllJZ3Y0a0c0M2syT1N1eUNuOFlmV0paSzhhQ1lxZ0dkZ1V4?=
 =?utf-8?B?aXR0cUZPb0E3TU4xNDJoV1Fsc0RNd1JRa3RmSEw0TnYvTGVrWlBIZzRZb3NB?=
 =?utf-8?B?dlFiYXZERmFCRnlVajJJOUNtSWtROGFydDdsa3krT0p6bTNJNTdBN0VhSjY1?=
 =?utf-8?B?czFMZmRpSmlLSGkrRS83OHN0S0ZDZHF5a1BCNDJDTXVWTWwyRG9hWDZMNElo?=
 =?utf-8?B?V0tqZ2dBMGRmYnpvejJ3eGtMTmZTVVZqZmUvZEdRS05RaG5ZOUVFZmJ2Rmkw?=
 =?utf-8?B?VFZCRW96Y3V5OTFaRVhjUFRNL2FrNVdPY1VSeUpFbFgzVEpRRlAzZHQwc2pj?=
 =?utf-8?B?WHp1MWNlSktxUlpSRlVTT0R3N0RBamxWS1kzQVhIT1FjLzczUWhLSVhXRkFz?=
 =?utf-8?B?ZHovWkY4emd4SVhXSExyb2xsb1NtWjJDRVFvanFsT0krVDRjTE0vdVYxL3Jl?=
 =?utf-8?B?b3NsUFRveUE2TWNzeDI0ektYM0ZabzFnTmQxWDJHZHRhMW1nUXRsMVpqd2Mz?=
 =?utf-8?B?Qm5RVHN3d3h2ejB0dU5TYVp5Nlgzamp3dmtGeFlrSFZ1QWMwbkJobGtvQTRy?=
 =?utf-8?B?M0trRFdiQndMNWlBZGZvY05DYm9HZ2haYVFMV0prdUJsUFd1L2Y1MWZrclpS?=
 =?utf-8?B?VDQxa3hTY3RLTmN4N1BPMzZkeUJoejJrWm5oTm9EbGR5bENXMXh0bDhMb3Fn?=
 =?utf-8?B?OUhEUHdZcHJ3TEpWN1h3cWhWeHR3MDVLTGcvS1RLZzJLQXNOUnRQQlJJQmNI?=
 =?utf-8?B?K3BjQjJZMUVmVndwVDIyV1JUMW1yRUlacnlaaHZLR1Y0c1NSVHNTenRLYmI1?=
 =?utf-8?B?Vk1yeVBRVVk2anNFNjNHa2VEcnVMWDlvZmdnUDJhSDBtVlArUUFRVW5sdkhY?=
 =?utf-8?B?Q1pDbVc2ZmhrK2RtRjRyNDBXa2hSWWpKMGJ0QlJUNEtoVGVMbG9HeWVEbnBt?=
 =?utf-8?B?WXBxSFJ2QUZZWUNoejREa2N6WkhQTy9mbThVUGxKK25OaHROSFZTUmE4NUFs?=
 =?utf-8?B?aXZwMGNqcmxoSkdTemMyQ2hTa3Irc0dSUzcrMy9iU08vYnNybVJtSFR5TGFh?=
 =?utf-8?B?cGRpYWUrZlFwZjhFVCtPbTBFMS9wVUVwbDNOY2hiSG95VVg4VUt4TWtITC9o?=
 =?utf-8?B?bzVRcVFIWTV0VkxwYnpobVVaK1I2dDVTa0ZVaHd3Y2N4QTdNd0xJMUQxeDFr?=
 =?utf-8?B?ZWRCUHRzVVN6RjJqdnowODVzRi8rckplS3BjT21WRk05ZVhaUGY5anBUUkJQ?=
 =?utf-8?B?UEFXUGE2dWM1NmxGQ29mTkxocFFJQi96ZVk4TVR5Vlp1eTBLMWNoSFdyMUto?=
 =?utf-8?B?OXR1a0lJVnYvSS9oeXZjYWlkbzhDb3pSOUI1ZGxGa0V2bnhZR0MvemU4SUtO?=
 =?utf-8?B?WEZWbU5lYjVqSU53cm1xbXM2a2xDU3ErQVlpazNNWW5GYjFJRmt2SUlQbUZk?=
 =?utf-8?B?S240MFRWR21nRXZ4b1krNkNId2d5cFFHMU9JNm9mT2xJTUZCOGVlN3ZxWkFz?=
 =?utf-8?Q?iKukowtXMgZ7m1Q+rOsFN4k=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: e7509a0c-e10f-462e-328c-08d9994d0a9c
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Oct 2021 13:24:02.2620
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0WB5eHisXo9Gp5AtZqS9PDwXdX9aMHL4Q3iJcSGk+YCHW9rge/BJDzBPPJotdnUn89qEH4UaSgJ5kjEucSni8Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB3945
X-OriginatorOrg: citrix.com

On Wed, Oct 27, 2021 at 11:59:47AM +0000, Oleksandr Andrushchenko wrote:
> Hi, Roger!
> 
> On 27.10.21 13:17, Oleksandr Andrushchenko wrote:
> > Hi, Roger!
> >
> > On 13.10.21 16:51, Roger Pau Monné wrote:
> >> On Thu, Sep 30, 2021 at 10:52:15AM +0300, Oleksandr Andrushchenko wrote:
> >>> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> >>>
> >>> This is in preparation for dynamic assignment of the vPCI register
> >>> handlers depending on the domain: hwdom or guest.
> >>> The need for this step is that it is easier to have all related functionality
> >>> put at one place. When the subsequent patches add decisions on which
> >>> handlers to install, e.g. hwdom or guest handlers, then this is easily
> >>> achievable.
> >> Won't it be possible to select the handlers to install in init_bars
> >> itself?
> > It is possible
> >> Splitting it like that means you need to iterate over the numbers of
> >> BARs twice (one in add_bar_handlers and one in init_bars), which makes
> >> it more likely to introduce errors or divergences.
> >>
> >> Decoupling the filling of vpci_bar data with setting the handlers
> >> seems slightly confusing.
> > Ok, I won't introduce add_bar_handlers, thus rendering this patch useless.
> > I'll drop it and re-work the upcoming patches with this respect
> On the other hand after thinking a bit more.
> What actually init_bars do?
> 1. Runs once per each pdev (__init?)
> 2. Sizes the BARs and detects their type, sets up pdev->vpci->header BAR values
> 3. Adds register handlers.
> 
> For DomU we only need 3), so we can setup guest handlers.

I think you assume that there will always be a hardware domain with
vPCI enabled that will get the device assigned and thus init_bars will
be executed prior to assigning to a domU.

But what about dom0less, or when using a classic PV dom0? In that case
the device won't get assigned to a hardware domain with vPCI support,
so the vpci structure won't be allocated or filled, and hence
init_bars would have to be executed when assigning to a domU.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Wed Oct 27 13:27:18 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Oct 2021 13:27:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.216976.376785 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfixU-0007qc-R4; Wed, 27 Oct 2021 13:27:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 216976.376785; Wed, 27 Oct 2021 13:27:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfixU-0007qV-OA; Wed, 27 Oct 2021 13:27:12 +0000
Received: by outflank-mailman (input) for mailman id 216976;
 Wed, 27 Oct 2021 13:27:11 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mfixT-0007qL-N0; Wed, 27 Oct 2021 13:27:11 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mfixT-00048a-Ga; Wed, 27 Oct 2021 13:27:11 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mfixT-0001UC-64; Wed, 27 Oct 2021 13:27:11 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mfixT-0002pO-5Y; Wed, 27 Oct 2021 13:27:11 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=5ElPefmGsT2YpwVr6/Rsm9OQwxXwLk+Skk6+ITA38ZY=; b=lhxRdreKlej0lPa9j5QgP/rdur
	G7AVBHJdwntJAin38k/w/UTO77i7jwailwW4RhIwsMFrd0KH52r3bQsLg7gM9203K6P7jLmnOOIf9
	OpRU2qzgsLEMR+JSHx+LGiijDTslVbfMsJlfqvgYkKcDBf4ZFTYYd44d4XmSkx2PWBcU=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165887-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 165887: tolerable FAIL
X-Osstest-Failures:
    xen-unstable:test-amd64-amd64-xl:guest-localmigrate/x10:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=b0fce57a6a491c120f2554ad7cc9a0c43ee5defa
X-Osstest-Versions-That:
    xen=b0fce57a6a491c120f2554ad7cc9a0c43ee5defa
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 27 Oct 2021 13:27:11 +0000

flight 165887 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165887/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-xl          20 guest-localmigrate/x10     fail pass in 165875

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 165875
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 165875
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165875
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165875
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 165875
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 165875
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 165875
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 165875
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 165875
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 165875
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 165875
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165875
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 xen                  b0fce57a6a491c120f2554ad7cc9a0c43ee5defa
baseline version:
 xen                  b0fce57a6a491c120f2554ad7cc9a0c43ee5defa

Last test of basis   165887  2021-10-27 01:52:47 Z    0 days
Testing same since                          (not found)         0 attempts

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          fail    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Published tested tree is already up to date.



From xen-devel-bounces@lists.xenproject.org Wed Oct 27 14:00:00 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Oct 2021 14:00:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.216986.376800 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfjSx-0002q6-EM; Wed, 27 Oct 2021 13:59:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 216986.376800; Wed, 27 Oct 2021 13:59:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfjSx-0002pz-BQ; Wed, 27 Oct 2021 13:59:43 +0000
Received: by outflank-mailman (input) for mailman id 216986;
 Wed, 27 Oct 2021 13:59:42 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+yfZ=PP=citrix.com=anthony.perard@srs-us1.protection.inumbo.net>)
 id 1mfjSw-0002pt-Cz
 for xen-devel@lists.xenproject.org; Wed, 27 Oct 2021 13:59:42 +0000
Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 2147d1eb-372e-11ec-8460-12813bfff9fa;
 Wed, 27 Oct 2021 13:59:41 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2147d1eb-372e-11ec-8460-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1635343181;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=QO3evD+5ru6SBtboebElv0wLrxWv04BBbpZkkqlAlPQ=;
  b=IhAhQHTt2+RUEODiqc/Y636IqPhOZMbpNXQRZS2h/Y1KctRLVmbfk2Lx
   X1SpOsd1Jfkw4NX1LMyo+k1zTgWqOCXtU7OSItwoIT8AqN41kFKm6oOJL
   GIVioy5uqA+asMQrE+QPlaP6HOzxLjJdwrS/Gk5RNfdzvsHEnILBRNG85
   U=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: 2tUkm5hz3JYdCPGIFSIijTldf9nl0hyIjRtlnGloDs3Ccg7iAbOpWXORJLbKlb7ZV3QJ2aDipV
 U+iME93b8WPCnGFArq4vYqg9wIz3aWKcA5DOXcNgAfCsdu30aCuLIPO4mUZr9ABMcROe3bei62
 +U+fJwNopW+YR46K+jgACeLDLRJH+tMK0cwYKusM0Xe411/ESrdsItmJ9qodyXAkfpwvgS6yY9
 shtLsaS0LNOzc4CsLFYUtGmxyCB4PGQP2ks8GbkRYB+3sZFboIS3P6OVlhxor4fJMTz5voBmS3
 Pzem3vCiilzH7LzOyMk5NaZA
X-SBRS: 5.1
X-MesageID: 58289320
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:1y4VFaDTeu1wdxVW/7Xkw5YqxClBgxIJ4kV8jS/XYbTApDx30GNRy
 GAcUD/SPvqDYDekf9oiao3i9EMPvJWGzII3QQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA
 xA2M4GYRCwMo/u1Si6FatANl1ElvU2zbue6WLGs1hxZH1c+EX550007wobVv6Yz6TSHK1LV0
 T/Ni5W31G+Ng1aY5UpNtspvADs21BjDkGtwUm4WPJinj3eH/5UhN7oNJLnZEpfNatI88thW5
 Qr05OrREmvxp3/BAz4++1rxWhVirrX6ZWBihpfKMkQLb9crSiEai84G2PQghUh/tCe7kfBsw
 sV06N+6dEAxNZyUxtwfekwNe81+FfUuFL7vJHG+tYqYzlHccmuqyPJrZK00FdRGoKAtWzgIr
 KFGbmBWBvyAr7veLLaTQ+9whsMlPY/zMZkWoH1IxjDFF/c2B5vERs0m4PcFjG1g15sURZ4yY
 eJBbiRfSiWdbydCYHkbIdVgg8OmqVXwJmgwRFW9+vNsvjm7IBZK+LPkKtbSd/SBTN9ZmUver
 WXDl0zmBjkKOdrZziCKmlq3muLBlCX8HpkOHbe18vprhly71m0XCRsGE1C8pJGRkVWiUthSL
 0gV/CsGrqUo8kGvCN7nUHWQsHOC+xIRRddUO+k78x2WjLrZ5R6DAWoJRSIHb8Yp3Oc3Wj4Cx
 lKPh8nuBzFkrPuSU331y1uPhWrsY25PdzZEPHJaC1teizX+nG0tpi3dfNhDDaSlt4C2Ewy32
 zu79HYGhZxG2KbnyJ6H1VzAhjutoL3AQQg0+hjbUwqZ0+9pWGK2T9f3sQaDvJ6sOK7cFwPb5
 CFVxKBy+chXVcnV/BFhVtnhC11ACxytCzbbnUJ0V6co8zCg6hZPlqgBvWkgei+F3isCEAIFg
 XM/WysNu/e/31PwNMebhr5d7exwlcAM8vy+D5jpgiJmOMQZSeN+1HgGibSs927silMwtqo0J
 I2Wd82hZV5DV/86lmXtF71FiOd2rszb+Y81bcqjp/hA+eHHDEN5tJ9faAfeBgzHxPrcyOkqz
 zqvH5TTkEgOOAEPSiLW7ZQSPTg3wYsTXvjLRzhsXrfbeGJOQTh5Y9eImO9JU9E1zsx9y7aTl
 lngCxAw9bYKrSCeQel8Qis4M+2HsFcWhS9TABHAyn7yhCd6Mdf1tf5OH3b1FJF+nNFeITdPZ
 6FtU6297j5nE2uvF+01YcavoYp8Wg6sgA7SbSOpbCJmJ8xrRhDT+8+idQzqrXFcAi2yvMo4g
 ruhygKEHsZTG1U8VJ7bOKC10le8nXkBg+YuDUHGFcZeJRf3+49wJi2v0vJue5MQKQ/Ozyex3
 hqNBUtKvvHEpoI4qYGbha2No4qzPfF5G05WQzvS4bqsbHGI9Wu/245QFu2PeGmFBm/z/ayjY
 8RTzu39b6JbzAob7dIkHu8yn6wk5tbpq7tL9SheHS3GPwaxF7dtAniaxs0T5KdD8aBU5FmtU
 UWV99gEZbjQYJH5EEQcLRYOZ/iY0a1GgSHb6Pk4LRmo5CJz+7bbA0xeMwPV1X5YJbpxdogk3
 f0gqIgd7Anm0kgmNdOPjyZ18WWQLyNfD/V7589CWIK72BA2zlxiYIDHDn6k6Z6CXNxAL002L
 2LGn6HFnbldmhLPfndb+aIhBgaBaUDiYCx38WI=
IronPort-HdrOrdr: A9a23:+5L9t6rDppiilzssayX6aWYaV5oreYIsimQD101hICG8cqSj+f
 xGuM5rsSMc6QxhPU3I9ursBEDtex/hHNtOkO4s1NSZLWvbUQmTTL2KhLGKq1aLJ8S9zJ8/6U
 4JSdkZNDSaNzlHZKjBjzWFLw==
X-IronPort-AV: E=Sophos;i="5.87,186,1631592000"; 
   d="scan'208";a="58289320"
Date: Wed, 27 Oct 2021 14:59:22 +0100
From: Anthony PERARD <anthony.perard@citrix.com>
To: Stefano Stabellini <sstabellini@kernel.org>
CC: <xen-devel@lists.xenproject.org>, <iwj@xenproject.org>,
	<cardoe@cardoe.com>, <wl@xen.org>, <andrew.cooper3@citrix.com>, "Stefano
 Stabellini" <stefano.stabellini@xilinx.com>
Subject: Re: [PATCH 3/3] automation: add a QEMU based x86_64 Dom0/DomU test
Message-ID: <YXlbOjiphjN/XqMz@perard>
References: <alpine.DEB.2.21.2110210831470.2311@sstabellini-ThinkPad-T480s>
 <20211021230839.10794-3-sstabellini@kernel.org>
 <YXK2lTWZHiTXIBtJ@perard>
 <alpine.DEB.2.21.2110221219520.2311@sstabellini-ThinkPad-T480s>
 <YXbXwjxHPNjSAKrG@perard>
 <alpine.DEB.2.21.2110251754210.4586@sstabellini-ThinkPad-T480s>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <alpine.DEB.2.21.2110251754210.4586@sstabellini-ThinkPad-T480s>

On Mon, Oct 25, 2021 at 06:33:53PM -0700, Stefano Stabellini wrote:
> On Mon, 25 Oct 2021, Anthony PERARD wrote:
> > There is something I'm missing, how is it a problem to have a container
> > that is a bit bigger? What sort of problem could we have to deal with?
> 
> It takes time to clone the container in the gitlab-ci, the bigger the
> container the more time it takes. It is fetched over the network. Now we
> are fetching qemu (as part of the container) 10 times during the build
> although it is not needed.

I guess the issue would be more like we don't do enough caching with our
gitlab runners. So package installation is just a workaround.

> But we do have a severe problem at the moment with external sources: our
> "git clones" keep failing during the build on x86. That is definitely
> something worth improving (see my other email thread on the subject) and
> it is the main problem affecting gitlab-ci at the moment, I keep having
> to restart jobs almost daily to get the overall pipeline to "pass".
> 
> If you have any ideas on how to stop fetching things using "git" from
> external repositories in gitlab-ci that would be fantastic :-)
> The only thing I could think of to "fix it" is moving all external repos
> to gitlab repositories mirrors.

I don't think that would work, I've seen the initial clone/fetch of a
job fail as well, so from gitlab. If we could have a cache of those
external resources closer to the runners, that would be better.

> > > I am not entirely sure what is the best solution overall, but for this
> > > series at this stage I would prefer to keep the same strategy used for
> > > the ARM tests (i.e. reuse the debian unstable build container and
> > > apt-get the few missing packages.) If we do change the way we do it, I
> > > would rather change both x86 and ARM at the same time.
> > 
> > I'm pretty sure the best strategy would be to do as little as possible
> > during a job, download as little as possible and possibly cache as much
> > as possible and do as much as possible ahead of time. Feel free to
> > change the Arm test, but I don't think it is necessary to change the Arm
> > test at the same time as introducing an x86 test.
> 
> I agree.
> 
> At the same time it would be nice to follow the same strategy between
> x86 and ARM going forward: if one optimization is made for one, it is
> also made for the other.

Probably better, yes.

Thanks,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Wed Oct 27 14:01:32 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Oct 2021 14:01:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.216991.376811 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfjUO-0004FX-QN; Wed, 27 Oct 2021 14:01:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 216991.376811; Wed, 27 Oct 2021 14:01:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfjUO-0004FQ-MS; Wed, 27 Oct 2021 14:01:12 +0000
Received: by outflank-mailman (input) for mailman id 216991;
 Wed, 27 Oct 2021 14:01:11 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Ie0f=PP=citrix.com=roger.pau@srs-us1.protection.inumbo.net>)
 id 1mfjUN-0004FA-BC
 for xen-devel@lists.xenproject.org; Wed, 27 Oct 2021 14:01:11 +0000
Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 5638c9b8-372e-11ec-8461-12813bfff9fa;
 Wed, 27 Oct 2021 14:01:10 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5638c9b8-372e-11ec-8461-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1635343270;
  h=from:to:cc:subject:date:message-id:
   content-transfer-encoding:mime-version;
  bh=2i9GfYNWeX3Ze5Ogj0jctuP2WAEbgnGUkdmNAC0myZU=;
  b=ejH8KkZwiIKeOlQCurNVZYtHl1yxFouIRYyro2U/b4itmJMIUnn7ibju
   jnGRNfC/ZjfiRWnhHcLki1mvoype/XTo4tLzUazlHStChRXgVrwu5X6ur
   XXTFEJv+OFY8071aVknbjvhgyhHp6fSKStjPjwSooNnDUZoJo4nbdAST8
   w=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: hx2+bg6HnU+EHOPVlrlIQK3cloXHRV9h5NtVW97K9ufx8fmKwaAWDdCoYlwtgxWt0QmKLRJUdB
 iJ10SZ4vZvCplg1RMX3qvkR+k/rlVVb5HegIUbsdb2He1Ksx+P9Ue4w82BlYSVpyVooKh3CDIa
 dhNAmN7Zu4LS5wHDjPmiOkoPXQEctl16nIZi7At8OIt8VTyP8vVN530fttyoe5gdOL8ogPVEzH
 mnjEUzGs7TFpH3lfivzAdlEkUViaDhar01SGQGPEkLfB6M4nMTo9teWajr6emk9ZRJheqqM2BA
 zCtRCl1mh6scp/3Bv8KAt4Xw
X-SBRS: 5.1
X-MesageID: 56350266
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:8lh3VKC8yTj05RVW/9/kw5YqxClBgxIJ4kV8jS/XYbTApGwjgTFUz
 DMcXDzQOPrfZTGge4gjbtm+90wHvpeAz9VmQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA
 xA2M4GYRCwMo/u1Si6FatANl1ElvU2zbue6WLGs1hxZH1c+EX550007wobVv6Yz6TSHK1LV0
 T/Ni5W31G+Ng1aY5UpNtspvADs21BjDkGtwUm4WPJinj3eH/5UhN7oNJLnZEpfNatI88thW5
 Qr05OrREmvxp3/BAz4++1rxWhVirrX6ZWBihpfKMkQLb9crSiEai84G2PQghUh/hRKzw9t/1
 P509oWURQdwM73hkfwDXEwNe81+FfUuFL7vJHG+tYqYzlHccmuqyPJrZK00FdRGoKAtWzgIr
 KFGbmBWBvyAr7veLLaTUO5ji95lNMD2FIgepmth3XfSCvNOrZXrHvuRuIcCgmlYasZmMtOOd
 tQ+dhhWakr8U01GYl01IZEGtbL97pX4W2IB8w/EzUYt2EDMyCRh3b6rN8DaEvSLWsd9jkuev
 njB/WnyHlcdLtP34SqI9Degi/HCmQv/WZkOD/uo+/hymlqRy2cPThoMWjOTo/O0l0q/UNJ3M
 FEP92wlqq1ayaCwZoCjBVvi+ifC50NCHYoLewEn1O2T4qTz2VqSCHQvd31YTNAm7cImaDUyy
 FDcyrsFGgdTmLGSTHuc8JKdojWzJTUZIAc+WMMUcecWy4K8+N9r33ojWv4mSfTv1oSkRlkc1
 hjT9HBm74j/m/LnwElSEbrvuDmruoTSBjA84gHaTwpJBSsoOdb7OeREBbXdhMuszbp1rHHd4
 xDoeODEtYji6K1hcgTXGI3h+5nyvp643MX02wIHInXY323FF4SfVY5R+ipiA0xiL9wJfzTkC
 GeK51gMvsAIbCHyNPcqC25UNyjM5fK4fTgCfquNBuein7ArLFPXlM2QTRfIt4wSrKTcuf5mY
 srKGSpdJX0bFb5m3FKLqxQ1itcWKtQF7TqLH/jTlk3/uZLHPSL9YepVYTOmM7FihIvZ8Vq9z
 jqqH5bTo/mpeLalOXe/HE96BQ1iEEXX8ris9JMOJr/Ze1M3cIzjYteIqY4cl0Vet/09vs/D/
 22nW18ez1z6hHbdLh6NZGwlY7TqNauTZ1pnVcD1FVr3iXUlf6i166ITK8k+cbU9rbQxxv9oV
 fgVPc6HB60XGDjA/j0ca7j7rZBjK0v31V7fYXL9bWhtZYNkSizI5sTgIlnl+h4RA3flrsA5u
 bChiF/WGMJRWwR4Ac/KQ/uz1Fft72MFked/UhKQcNlecUnh6qZwLCn1gqNlKs0AM0yblDCby
 xyXEVETouyU+90599zAhKalqYa1ErQhQhoGTjeDtbvvbHvU5Guux4NEQd2kRzGFWTOm4rima
 MVU0+r4bK8NkmFVvtcuCL1s168/uYfi/ucI0gR+EXzXRF23Ebc8cGKe1MxCu6ARlL9UvQy6B
 hCG9tVAYOjbPcrkFBgaJRY/b/TF3vYRw2GA4fMwKUT8xSl24LvYDhkCY0jS0HRQfOlvLYco4
 eY9o8pHuQWwhy0jPsuCki0JpX+HKWYNUvl/u5wXaGMxZtHHFr2WjUTgNxLL
IronPort-HdrOrdr: A9a23:2kzo3KPMMihaMsBcTyH155DYdb4zR+YMi2TDiHoedfUFSKOlfp
 6V8MjztSWVtN4QMEtQ/uxoX5PwPE80lKQFm7X5WI3CYOCIghrQEGgP1/qG/9SCIVyBygc+79
 YZT0EWMrSZZjIW/KWKgnjILz9J+qj5zEnCv5a5854Cd3APV0k2hD0JdjpzX3cGDzVuNN4cLt
 6x98BHrz2vdTA+adm6PGAMW6zmq8fQnJzrTBYaD1p/gTP+wA+A2frfKVy1zx0eWzRAzfML9n
 XEqRXw4uGGv+ugwhHR+mfP59B9mcfnyPFEGMuQ4/JlYAnEu0KNXsBMSreCtDc6rKWG70srqs
 DFp1MaM8F6+xrqDxeIiCqo/zOl/Ccl6nfkx1Pdq2Dku9bFSDUzDNcErZ5FczPCgnBQ8u1U4e
 Zu5Sa0ppBXBRTPkGDW/N7TTSxnkUKyvD4LjfMTtXpCSoETAYUh4rD3xHklUKvoIRiKq7zOSI
 JVfYPhDbdtAB+nhknizyhSKIfGZAV3Iv+EKnJyzfB9nQIm2EyR9HFot/D3qE1wgK7Ve6M0l9
 gsDZ4Y5o2mNvVmFp6VJN1xCPdfWVa9CS4lDgqpUCHa/ec8SjXwl6I=
X-IronPort-AV: E=Sophos;i="5.87,186,1631592000"; 
   d="scan'208";a="56350266"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=dle5zqP0YH9M+hp1QoDPPlBFkY8h2yLseu8tuhzwEh4Gm8uYAFd0VMCPBnvv+YYvCXJRjc30a7uX7UG5sUJvDREuqTTjnKeH6Hhm+tuD86KRqV8ciJnmpHljEjwWBuHdwgKmySNI3Foj5b+XrZdRgrpbrDA66KRQ4933o5oeWfE/YYxVep5iMq7UT/8D4ZYsYWh4+o1g93mlemQRAGZFg6i3Gkiv1dVaM+bVE/UB1xEnn/N5CkmxV4RMcabV4eyfjAwxh+aXksjLOntWuIICxziZmt49FPbkdkat0NRLUhq4tkfatxIk3QoB3yVgLOuojTW7W6bpy1SJW125o+7NfA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=vEFq9Noxa0+tac7zwTnn1lh6K/4Fwca86hbVXGfBKb4=;
 b=Ey1X7M1R1ihLtF0+J9tvvVdd+Eg0eR0fsCodK77nO0ANb2W+vFov57uGrtX/uTJMUqALUP4JbV7BTCt0E3NyxKUCtpyxEN/5QkLTJOt8J8NM3ERqirqDxaPymAC6J3ZIuWH33qCAKSgXD13/MzbTmuNEg3iLJWijOCyLR+B0POOdq3oHVW+p7p4psxiDMizk8d18umKnGVK7oCraUtHfcVtUyvSEKdxlLoHV9YGv0aStOFpS+mF5aqxXplSkoqR03DidXPKa4BPidiL4m/w2DU8s0TiLOiEIytzKT1J05Cw7o1yFTNaP26husYXGq+kjUvzb8dqFt22ZR3tsefbKig==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=vEFq9Noxa0+tac7zwTnn1lh6K/4Fwca86hbVXGfBKb4=;
 b=Fh4BklOde+PEmf4tP5mnr+PxulUGo2UEXHLFvkbsg0ve3d73NCUor3mH/AV02wPFv6yrN8YnCOm0PrMlRV/olIucayr84RG4Ln620BRChwIS6Bpo8b+8ggQLf7rf6JUd19++M1H/SOWihHOTnohp6OUXytVnB8RFz4DAaQ9uDYY=
From: Roger Pau Monne <roger.pau@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Roger Pau Monne <roger.pau@citrix.com>, Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>, Ian Jackson
	<iwj@xenproject.org>
Subject: [PATCH] x86/cpuid: prevent decreasing of hypervisor max leaf on migration
Date: Wed, 27 Oct 2021 16:00:50 +0200
Message-ID: <20211027140050.67509-1-roger.pau@citrix.com>
X-Mailer: git-send-email 2.33.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: MR2P264CA0149.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:501:1::12) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: f964a496-0953-45d3-b7c1-08d9995237ce
X-MS-TrafficTypeDiagnostic: DM6PR03MB3673:
X-Microsoft-Antispam-PRVS: <DM6PR03MB36737C3553CDAA3A2186B64E8F859@DM6PR03MB3673.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:2887;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: NK0LFjzmqUfDR+9TyQt0RFJK/bJllGAzrD0fcwHBDutqdQy49QEi5y7Hr8EAoqmVIrZyFAAuZ1h01i4RE8GHumdANMRVDtQ6u5f4NftKmz28gqhRm2SrMx7+9gymnngBx/QkQn5B2fZiyCXn4V32uwpdxoWrsYDnruiAla9T7anGNiPnzjt2cSou2FnHP34WBVURR/L5bL17mTw7liu9ew3rruUaOwj6Z19nHZq2o3XA/wAzHM6XrJwOxyhEzRspcwlhksiwqrqaTr11OBpKJ1GGzb7KZMO6WEvdGAmMYoey7foyJNa5dcQIIHeLO7+2XdKtj1hNZsr83ymJ/zFh9x0DVYrrO6wTMrow1p9ds1DnRepBF29k0x7orc/VQuWb5lbjWs/veRNRj+JXLbN+9C0aIZ4O2SFmboXiRrRxjxwGYag1T/VhuKtNiBmvoNlSYbKivf2djjFaSe4i6A824vMfC9YnWbeFtlYg9LFHFi9HB/YsRDjalAyzj2TG0ohO293yswWWyh5/i1BgMemv9zI8BqI++Ts3HrZ9BBk66TBJLv/BtM/Jqu02UtSHfxz5jQdBhpqUkQdlZhuOirDa5jIKubV7rAJ9lht9x8i1RAHG0WJCyZ8GvKCSvlypx5iut4QFFvi/+aS6WxDD8qg3iw==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(316002)(4326008)(1076003)(6916009)(186003)(83380400001)(38100700002)(508600001)(6666004)(26005)(8936002)(8676002)(36756003)(5660300002)(86362001)(956004)(2906002)(6496006)(66556008)(66476007)(2616005)(54906003)(82960400001)(66946007)(6486002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RXVacjFLTFBUZFRnVnQrQjZZVm5uaTRYcXorQXd0anRXSmtZY1MxOHZUdDUz?=
 =?utf-8?B?R1cxdW8xMDhkUjVoY09zaWlCL0E5L3gyZENUOFBLbmh0QlRPQmY4enJHejFG?=
 =?utf-8?B?SjlHZm55N2xEcGdSaGZYTEtzTm9ZaGlWUWZYeStiQ2wyVEpjazR3VFM4V1ZI?=
 =?utf-8?B?YTlWSEtrcnFaTjlFZ2oxODQvanVycEVYQUdlQ3pQeFV3bU5oZk9McFlyclJ5?=
 =?utf-8?B?Q1J4SzJ0YXRPMTkxRnVJU3djbkQxMnBHQkVzN1BUa096QUFpUGUrYmVuOEhH?=
 =?utf-8?B?QTFnTU5CSFhrMkJiS1hpWENGREc3WnYxUjBGU3U1eWhTMy9QOTRqZE5SK2NN?=
 =?utf-8?B?aTR3LzViWUM3NnRnREZHSTlNQWlxR3dqVmhWYktkc2xoK0FwTytYTkdLTmdm?=
 =?utf-8?B?bXRnTWtBb01tT0NaeTlrRXpGWDZqMGRRNG84WmxxMndpYWNMaWN4eVE5QWxK?=
 =?utf-8?B?NGhJK05CaUhsZkViYUwwNmdWdVRFUlpLR2xNZzZxTGg2U1IvUFVydDMrOFUx?=
 =?utf-8?B?eUF3OWR6d09ub1Mxbk9zdWVyRy9yUFlQcnVBZTE1S2lmSjF5TnlGVGVtSnhO?=
 =?utf-8?B?TnlEKzdsVFRHdHUrRXByTzkyblIzNE5jTkFTT0QwNExnU3pVUWM4cmVZOXlW?=
 =?utf-8?B?TDZoZVljUGEyR053L0VVSGJGdkVHcGJrTXh6QmRhMjRIeDhlWEZXWWx5V3M4?=
 =?utf-8?B?MFYvWE9HS2YvemFVaGprRHA5MXNXR2ZZSjg2ZEVlNDAxTFNpTWtsWEpjb3RK?=
 =?utf-8?B?WjBFa3FxbHdIcVRkSGVzQmxvY05idXloWVpyUEZwQ000TEE0MUNSSlR6OVdY?=
 =?utf-8?B?UFRpdzFHU2FqcXNlYi9EN3pmUklEK2k4VUNjU3dBditEM0RreU1qdEx4Z3VL?=
 =?utf-8?B?ckdnUVFKY0Q1WDhNdjVnRVBJV1k4dm85R25FUE5hL1JZbU1Fcit5QXAyeHBs?=
 =?utf-8?B?cno0VzlFZExxTVJwUEwwdG9WV0J6T2tuWWp0VnFDUTVybHFKdUdIMGlUT2tI?=
 =?utf-8?B?YzZZcG5ESEZLMG9QcjBQYXdsOVBNQmJERlNnQ0ZKeFQvNENkbGR4Z2czRlZY?=
 =?utf-8?B?YWFEZjg0NUtOcGN5d0ZXOUliUHZORjg2THhGUllMcGNvcmIrK3QxMUduaWFx?=
 =?utf-8?B?M1laZXNKcWYxdEdiYVBkc0s4VmZjZTJEWXgvbEdoWDRXdjN4OFFjYnBycmpk?=
 =?utf-8?B?dHVYY1M3S0FHaHA4V1JIUTN5bFBwd1hhNSthaWhiSlFqS3ZDTkNUVy8vT0VV?=
 =?utf-8?B?dnhUcmxqNGRTVFNYdk1uaEozM0huVUpWUVl4UlN3cHcxR0RZeEQ0NzFrbExY?=
 =?utf-8?B?ektKMkFJUjVSMjdFYkdRVGZJU05qekR2bEJ1cURsTUJoUU9MSTd1NjRpQnAy?=
 =?utf-8?B?U21LM212V2xiUTYrd3VDWGt1Y0pZdk1FVkhZSkdCSmcrTWNNNVpwRTkzSkNa?=
 =?utf-8?B?WVh4VkM2UWdhKzRRZjhLa2hwUXpTUEpMUWN1U016TnBadDBTemdrMDEzcUJk?=
 =?utf-8?B?U2tZMlZSM2Z0SkRFTFNtRi9yZ1VBWmdyZGNKZE1ld3VrQU1VVHpmQmVjTnU1?=
 =?utf-8?B?M2NFZTJacjlnSm4yNGh2bk5HZXhUVjhiK01wL080c3k1NDQzcWFYNkNLYnM4?=
 =?utf-8?B?T1FVN1RsUmpGMXNWQWtHSWRrN256ZzVHTnYzZEsxSmIyem4wSXJvMUdIdEtR?=
 =?utf-8?B?RVdGL21uWnUvZHhId29WdlkzbHlFSXZkVjRBYTVqRlpoN3F4bWttblFxR3lT?=
 =?utf-8?B?cWlXbTdzUFlhdHFzZW5uUGlzcnQwd0g2TzZjTVBhdXRKWGdRREhSSEtsa3BY?=
 =?utf-8?B?bTRNMHhIbTdIVlJhRDlKYlpDdU9ZV3lER0FZcnRXMU1CMm1rTXdobGxoM2lk?=
 =?utf-8?B?Mkc5K0VmZ2IrcGRCU3ppbzBmTldhclJlQVJpa0R4anh1SlZaU3pkYUlHa09C?=
 =?utf-8?B?NjA3d2RyTk5nR0QxaURIaVpXbTlZQTJQTEJKbmlBdlc2dS9WL0xNUTJkekRE?=
 =?utf-8?B?WmIrU0V6OVVNNS9aKzc2Qk9jSHhnNG9ybjhYVm1ieGdrMWtuUkQvZUh4d2Nw?=
 =?utf-8?B?cDZ5TEFQNXp3ZitEOGtVenR6c1M0eUxnS3RYUjhyb0EwZ24zUWRHQ3ltaWRm?=
 =?utf-8?B?Q1lzVllCV0hzc0VsQ2JobjAxYnUwTGhSeUZlNkF2UmhJNzU1Y2pBN2gyM2dG?=
 =?utf-8?Q?QRA0bW2ma6mfIhiqXveMbUs=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: f964a496-0953-45d3-b7c1-08d9995237ce
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Oct 2021 14:01:05.4060
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: rWoTwW0IeOzISE9SFJnp6GmVCOu4r/SBWj4qVtqpRVs5Asa0UrB2gs5tBQ0+vlnoFRl19T/F0gf1m1sKOgCSBw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB3673
X-OriginatorOrg: citrix.com

In order to be compatible with previous Xen versions, and not change
max hypervisor leaf as a result of a migration, keep the clamping of
the maximum leaf value provided to XEN_CPUID_MAX_NUM_LEAVES, instead
of doing it based on the domain type. Also set the default maximum
leaf without taking the domain type into account. The maximum
hypervisor leaf is not migrated, so we need the default to not regress
beyond what might already be reported to a guest by existing Xen
versions.

This is a partial revert of 540d911c28 and restores the previous
behaviour and assures that HVM guests won't see it's maximum
hypervisor leaf reduced from 5 to 4 as a result of a migration.

Fixes: 540d911c28 ('x86/CPUID: shrink max_{,sub}leaf fields according to actual leaf contents')
Reported-by: Andrew Cooper <andrew.cooper3@citrix.com>
Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
Cc: Ian Jackson <iwj@xenproject.org>
---
Regarding release risks:

This is a partial revert of a commit.  The main issues could be that a
partial revert could break the build or leave the remaining code in a
non-working condition.

Breaking the build will be easily discovered by our automated testing,
while leaving the remaining code in a broken state is unlikely, as the
chunks reverted are isolated from the rest of the change in
540d911c28.
---
 xen/arch/x86/traps.c                | 6 ++----
 xen/include/public/arch-x86/cpuid.h | 6 +-----
 2 files changed, 3 insertions(+), 9 deletions(-)

diff --git a/xen/arch/x86/traps.c b/xen/arch/x86/traps.c
index a1c2adb7ad..79fd276a41 100644
--- a/xen/arch/x86/traps.c
+++ b/xen/arch/x86/traps.c
@@ -1086,15 +1086,13 @@ void cpuid_hypervisor_leaves(const struct vcpu *v, uint32_t leaf,
     uint32_t base = is_viridian_domain(d) ? 0x40000100 : 0x40000000;
     uint32_t idx  = leaf - base;
     unsigned int limit = is_viridian_domain(d) ? p->hv2_limit : p->hv_limit;
-    unsigned int dflt = is_pv_domain(d) ? XEN_CPUID_MAX_PV_NUM_LEAVES
-                                        : XEN_CPUID_MAX_HVM_NUM_LEAVES;
 
     if ( limit == 0 )
         /* Default number of leaves */
-        limit = dflt;
+        limit = XEN_CPUID_MAX_NUM_LEAVES;
     else
         /* Clamp toolstack value between 2 and MAX_NUM_LEAVES. */
-        limit = min(max(limit, 2u), dflt);
+        limit = min(max(limit, 2u), XEN_CPUID_MAX_NUM_LEAVES + 0u);
 
     if ( idx > limit )
         return;
diff --git a/xen/include/public/arch-x86/cpuid.h b/xen/include/public/arch-x86/cpuid.h
index 00926b1fef..ce46305bee 100644
--- a/xen/include/public/arch-x86/cpuid.h
+++ b/xen/include/public/arch-x86/cpuid.h
@@ -113,10 +113,6 @@
 /* Max. address width in bits taking memory hotplug into account. */
 #define XEN_CPUID_MACHINE_ADDRESS_WIDTH_MASK (0xffu << 0)
 
-#define XEN_CPUID_MAX_PV_NUM_LEAVES 5
-#define XEN_CPUID_MAX_HVM_NUM_LEAVES 4
-#define XEN_CPUID_MAX_NUM_LEAVES \
-    (XEN_CPUID_MAX_PV_NUM_LEAVES > XEN_CPUID_MAX_HVM_NUM_LEAVES ? \
-     XEN_CPUID_MAX_PV_NUM_LEAVES : XEN_CPUID_MAX_HVM_NUM_LEAVES)
+#define XEN_CPUID_MAX_NUM_LEAVES 5
 
 #endif /* __XEN_PUBLIC_ARCH_X86_CPUID_H__ */
-- 
2.33.0



From xen-devel-bounces@lists.xenproject.org Wed Oct 27 14:06:56 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Oct 2021 14:06:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217001.376822 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfjZp-0004zy-IZ; Wed, 27 Oct 2021 14:06:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217001.376822; Wed, 27 Oct 2021 14:06:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfjZp-0004zr-EI; Wed, 27 Oct 2021 14:06:49 +0000
Received: by outflank-mailman (input) for mailman id 217001;
 Wed, 27 Oct 2021 14:06:48 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=8lYk=PP=epam.com=prvs=0934bd4bd6=oleksandr_andrushchenko@srs-us1.protection.inumbo.net>)
 id 1mfjZn-0004zl-U0
 for xen-devel@lists.xenproject.org; Wed, 27 Oct 2021 14:06:48 +0000
Received: from mx0a-0039f301.pphosted.com (unknown [148.163.133.242])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id e6ee6fce-ca17-47ef-9f01-74032ae8a223;
 Wed, 27 Oct 2021 14:06:46 +0000 (UTC)
Received: from pps.filterd (m0174676.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 19RBScdw022557; 
 Wed, 27 Oct 2021 14:06:44 GMT
Received: from eur01-ve1-obe.outbound.protection.outlook.com
 (mail-ve1eur01lp2058.outbound.protection.outlook.com [104.47.1.58])
 by mx0a-0039f301.pphosted.com with ESMTP id 3by2x9swv2-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Wed, 27 Oct 2021 14:06:44 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by AM0PR03MB4020.eurprd03.prod.outlook.com (2603:10a6:208:76::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.16; Wed, 27 Oct
 2021 14:06:40 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::c038:e032:595a:651]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::c038:e032:595a:651%9]) with mapi id 15.20.4649.014; Wed, 27 Oct 2021
 14:06:40 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e6ee6fce-ca17-47ef-9f01-74032ae8a223
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=V284zms6pkYFrlk9bq5tO1xaMTfkajPASJxk7LD4QKQ9iRKxu+ZOVAGZ4SqqVONsYSo3QZw1l0RFFFR2seMJmAaUHwhgd07h3+alV7BJjDTqAKZ6o7e9EaS4X60A1NrzXmpORh9JNHfW94On/GPKI6FeVun7tXTUHiQQdyZTMSvlkBs9A1LuPyJO5zG9gad6K89ca87HnsV3+P2NT7IcGHH4EPV+U2+unR/90EM9U5WhfFs7/w3210+RKYYmHmIbtZQcgwzEqNog/AEYy4KdSGkdhHSVrBd7AsHvXlgySNKILOz9cKqm+CX9XqYeSJYv6rP/L1OAzO78lgbYKsxbTQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=DI778T0dFEeWmm1k3GfkJmWyAYvd0gsLkVcNoLsTGS4=;
 b=ZNO6xt0sw4faeOsRl2x2Txctj/zbMJ+r8sMs0lXs91JDZCm6RLt8cHASlRstPw79y9TbwzTchErIu4ciEp1erepr3rnTdXJVXPLwyApnreZQ4QK3RtFFKvbQiVCPpQMqybwmhiVWqFk8xUbN8/MKAcjZ40G1TeWpah+itlrsSVmttWjCcbBkPhIOckAV8OxPxrfleELlIj6jhm2xn1bQLa1/61fkbhvYxwXVHASOS2ybZIGQmsGhI+8qWnaI4h+eGbN7QAnI3UKqlmbUdpOLF+6Tg5pkg1W6pM1fe+1BKvIKE9T2AvxZBwUNI7TmbhS5461HWq2n3ZiFBrMR/Iya/A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=DI778T0dFEeWmm1k3GfkJmWyAYvd0gsLkVcNoLsTGS4=;
 b=rgxhzbzEvyTNFNEDMZm5DYIAgEVjSuyny0PLlx+k80yrYsAoVeoO45/2Kfzy+ixAVEQo9piIbYVA0VaamdWDAwbYbeo/BfpMR1zUHVNHYahFS0e5Qp2ap2h74phRR0vDLpH0XqDz5zvxWgFQ8XHKr/D2/APg1CBKXV88lbfbgNc1sanmmgAPxmUnOjXBNhNYSI4cYGuBFE+WJ46NqNc/Oh7qSAl7kWchG4GE/OrPLIm6HXE+gdCU/WVFH7uIqMRA9FZLHP+mhBTfRbemLqbM2z0kVZX0FF/tRPO7fQYB84pB0ApX0nm2SZ52OFI9FuUq9axkW5s1hiUwY7CKHC1UqQ==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org"
	<sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "jbeulich@suse.com" <jbeulich@suse.com>,
        Bertrand Marquis
	<bertrand.marquis@arm.com>,
        Oleksandr Andrushchenko
	<Oleksandr_Andrushchenko@epam.com>,
        Rahul Singh <rahul.singh@arm.com>
Subject: Re: [PATCH v3 03/11] vpci/header: Move register assignments from
 init_bars
Thread-Topic: [PATCH v3 03/11] vpci/header: Move register assignments from
 init_bars
Thread-Index: AQHXtdAhPfrDnvz+/U+T4IKIC1fCcavRBz+AgBXEsICAABy1AIAAF4OAgAAL8YA=
Date: Wed, 27 Oct 2021 14:06:40 +0000
Message-ID: <368bf4b5-f9fd-76a6-294e-dbb93a18e73f@epam.com>
References: <20210930075223.860329-1-andr2000@gmail.com>
 <20210930075223.860329-4-andr2000@gmail.com>
 <YWbkZ216FbV8lBns@MacBook-Air-de-Roger.local>
 <89e1f09e-c840-860e-e596-38fb141aa707@epam.com>
 <344cf880-8f76-1a71-d27c-e7ba10459d5b@epam.com>
 <YXlS68Ghrphi5dHB@Air-de-Roger>
In-Reply-To: <YXlS68Ghrphi5dHB@Air-de-Roger>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 14e0102e-6fa6-40ff-9a06-08d99952ff8d
x-ms-traffictypediagnostic: AM0PR03MB4020:
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <AM0PR03MB4020C0010626509DF53BAE34E7859@AM0PR03MB4020.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:9508;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 tPxr4yJYNKlP0Hsm+Bl2TQMyRRCCKa88tsmvw0zV0VmyR5dRrADKFQO/vWmJ+ooa/9DwcPxBBU9bWKqnSiv5K2DjWdz2EXHbvxFTGdibyaqzHdYqpYQQN+mgwB1cLDR9rtPbV+9C3RyBpfRm7xory8lOXP7tRqd0XAQ1Gy5rFB0COGXcNSfESc0Tdqt+VO8EA4rIGVPz8S7ebJCl+z+3C3ORmRy8lVDAHPY7yeeakIDbfl/X88gYIeECNmjkINAasXvJkKpAx9R3LXyRWE6D++FN5Ef5iW1kuLtmC/0WrnE90eNBDGW0odkbHD9prS7wBz0e8oM1t7IiU0j7henJ8a2c70JpV6LbBxVNCx4ulX9Xhpnx2iNqJ7irvBGxH6grJb6alDLv5rN7Ukdj9H1OmPjH/Op2o/Oj6Skt1oz0CPrzQLiMsVIlG9af8yms+yxLStHTT7AZiarNIITGSK5pXU2CK53UGFpMQ1RqnkYjjZcZClXSk06BcwyDwpwSIA1ZXYio4/4eyzDdA/Xpp5g6ktp/TAnKCcz68seIQMrF8LtWZIaR7kvtmFHAPIVi0/uYOcSpWPr0lRjvLSlpF/lKRgw8MJa91d1Mnbmdy5UVFmt5R/SSj8gozpuX1jWNpGOOk5TnALpahmvJmvM2+8b51zVoSZbmnrifi24qQh3rr9H4VBtfoRJyo62Q6mIOtmejBeFmxwauxbxvgi4iK84DXWvq11PdHwXyk6EpWUx39lBr/6Fw6hwrp/vwbfzDLibbuB2bf1IG02CsAu2LiuHkhz618JpJqLXTMA2bYgjLW2g+FOuknchgxjMavZVr8bus8cjlU2dPp4Kb5SKOBXEedQ==
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(6916009)(26005)(508600001)(71200400001)(66946007)(36756003)(76116006)(6486002)(64756008)(54906003)(38100700002)(966005)(91956017)(66556008)(6512007)(5660300002)(66446008)(66476007)(2906002)(53546011)(122000001)(4326008)(186003)(316002)(38070700005)(31696002)(2616005)(31686004)(8936002)(8676002)(6506007)(83380400001)(86362001)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?NXJzS1VnQVVMbHFJOFliWi85OUcrUzdINTVjbWJlOFc4MzZSNk9qWnN5WnRT?=
 =?utf-8?B?ZXBDcnRuUmpuUHpnK1FrMG1DUFZIbUZIQ01vNWdZUHZYbGNoU3NKZ09aMGVR?=
 =?utf-8?B?MDQzUFlOZHBYL1FQeFhGaE5RRXNmeHdQano5ZUt6RU9kMEJHMUpLOWNDNkpR?=
 =?utf-8?B?UFpMQyt3eS9EUnBPdTZiMnZ4TnNTd29mK2hRV3NUQzBSM3pONXZ4dkF2Q243?=
 =?utf-8?B?R2FrQ2dOZzE4SHhHaG13a0RxQWZyUU1DdUtTbm96MjUxUi9IR3dlMGRTTitF?=
 =?utf-8?B?RHg1bHFGd1FrNjBTY1BSMjdjNTluSkxpUFo5R1UvR2pkU3pqWER3U1YzUHEy?=
 =?utf-8?B?TlhxbTJzaGRZOEd5MnV0R2Y3QnpMUWtPQStoT3ZFVTlUMzZEd0dpSHVVcWlQ?=
 =?utf-8?B?TFYrSnJWdFhGRXRmODh3djBsTW5tUWFNbncrZ1kwV3hYL2pCeTMvb2NBdG5R?=
 =?utf-8?B?TVZiUHFETWgrdit0bE90SUZ5Y3dUektJRlhINlFwbXR0V2M5N0hXZUFNWm1Q?=
 =?utf-8?B?bjM3dEpja3kxbXJtZGswbEJ5RHVPd3JNQzhISjViRXRiRWdHQWx5NXdPbHRC?=
 =?utf-8?B?THQzekQ1T2xnQUNwYUEzQzFvd0hPK2trZkRLWEtpQ0dzS1p6R0RSbkZ5UDh6?=
 =?utf-8?B?ditzL29jelZPQ0QwbmIxUERoa3NoN0JsaWxCNWwrV3Y2dC9PQytSY0RTYnpQ?=
 =?utf-8?B?ZkhXaVVRdWpHdGxJN0JodFBDOEk0UktPUU5rVytVdVFVVko3Q3o2VnJGYU1i?=
 =?utf-8?B?VkVpZTNvM21YK2NpN00zK0JMd2JacFJQNzBqMWZCWjJoT3hpbk5KWllsK3VW?=
 =?utf-8?B?Y042M3R4WGdWbThzbk9YWXFzNmdydG0xSmQvMFRSMzBHYUwyRktBam9GV1gx?=
 =?utf-8?B?bnpJbG10TjVOYzBIaUdIdDhTRWU0Vm9zeGM5aHh5MFhUUG9ZVzBzSmQxVGtD?=
 =?utf-8?B?REVwTXZOektoZGxmU3VIMUhIK3BadnpCKzNpbUpqYSsrTkdzUER3RzV3TCtL?=
 =?utf-8?B?T0lVMVhTeU9IVzFjR2wwUHlqbDdYNjk5TEcxQm42VFBmVmF5U0FGcVN6Z3JF?=
 =?utf-8?B?Z3RiWGNoNUpHMjZ6UEdoMi9VWngvWkFwWGRaL0c1WGZKRkRnRnI0YUZuZWM3?=
 =?utf-8?B?d0E5K0FxUFR6Tnc4R3ZITkpCMnEwV0VZcU10aGhDY1k5RUtaRXY1TktGYmhr?=
 =?utf-8?B?eW14cXpLVlBKVitWeUg0b3M1S0ZrSlhkQXpDR1R0WFFmdzhleVhiMFFLeStU?=
 =?utf-8?B?b0huUlRVcmtQeHBxUTN6S1JLTEtORU11WDVZVDQ2OXBiYXV5M1lOUjdzVUwv?=
 =?utf-8?B?Z0F4eEtBL1V1aWJLZDdIcS9vRGVjZExwK3Jubm13TTdWOXJ1VHlCRjRDUHNY?=
 =?utf-8?B?ZDE5UWRzcEpjZjBhWjJPRVFJeS9SYTZZM2R3QVlsM3poQ3ZxSVRmWm9zak9R?=
 =?utf-8?B?a3FWK2hHcTBFdHR2Zjk1c1JOZ1NwdURHbFcyUmtCeEtkVlFwcHh3MmZBLzc2?=
 =?utf-8?B?cTZTa0tFaDJFTjMwMDFaWk84Sit1WldGV0haVDhyWFZPSDExR3pnMm1SVVVR?=
 =?utf-8?B?Rm5wTXo3MS84MTErUXlFWFBYdmEyWEhhOUNzSi9NTENZUXdTbEFpRDhpeUpi?=
 =?utf-8?B?L1ZlM0h3Z3BVbkpXSnlxMXNzUjZsbmQvZHpVcTF1TkFNVkdBUDVBdk9IektR?=
 =?utf-8?B?REpKeWp3N1Q2REhHVzV6SHV1UUhSQ1pEUDIxTTk2enArZHFWaUhTQisxaStM?=
 =?utf-8?B?YnZReUpBNFZBODZuL0FiWkU3b08rR1drR3Q3L1hLMHlPZVZ1T1pETjBmVHBX?=
 =?utf-8?B?U1NlUDBNc2ZYRjJHcHpnaXd0UkNnRFNtNlpwZ1RtWUpLbVVwL2lwUWYveHdE?=
 =?utf-8?B?RWhqcC9iWlRNNzh2OS9JMTMwRmhta05JQy95aHZSMzd0cjZDNHNvRFJRNXhp?=
 =?utf-8?B?alF3TTI1NUJlL0VMUWkrZURBcFJhNkhTVHFSNFM0ekhlSndkRVJiUlBGVFBE?=
 =?utf-8?B?WVhpRmM2enVDMU1Dd1owb2xSL2drZmRSQVJadndKenZHWnAzdUR4b1VaVlBy?=
 =?utf-8?B?Mm9BYStWZytJM25hRXZOczNUSk9UNFh2Qlhjcmk4cnN1d0ozOTlVNWNnOWQx?=
 =?utf-8?B?THUzNTRHcTVkOVNpeGQ1WGY2TGxnZUhyWFRIWGdVSE5yTzVXd2JudFViTTJR?=
 =?utf-8?B?L3lWU0dxTVJBWHNnWEVRL1k5RVpzd0twSWtGMXM1RHpVTzNnV0tHSS9JMFNG?=
 =?utf-8?B?NzVmQTlLVDJLL3N3bmIzUElvVGxZbGJGbXNlMDdmZkFyZG56WFhBTVBmMlNF?=
 =?utf-8?B?KzU5MW9JTVdQOVVKcTZ0RUdUVUpNTEx1REdqZ2ZnT0ZDMHNPc2dkdz09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <FC9DB9DDE48C2C49888C74CD1F2001CA@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 14e0102e-6fa6-40ff-9a06-08d99952ff8d
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Oct 2021 14:06:40.2010
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: MmlF8KA8PpTJ1H9t5TSpVxoTiZP2YYQ6zrNvEInyDYg9/7eUV8AxW1ha4sVWcqzyi6plJrZjjwGlqChvOAxLfS7gVkxhqZi5feUmMjmdaoyg8KkpanWpdoF0vN2FLmRz
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR03MB4020
X-Proofpoint-ORIG-GUID: SVbeTDCmLfqbJ7l_6e9iOfZtMxuxRhWX
X-Proofpoint-GUID: SVbeTDCmLfqbJ7l_6e9iOfZtMxuxRhWX
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475
 definitions=2021-10-27_04,2021-10-26_01,2020-04-07_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 clxscore=1015
 lowpriorityscore=0 phishscore=0 malwarescore=0 priorityscore=1501
 bulkscore=0 mlxscore=0 mlxlogscore=999 impostorscore=0 spamscore=0
 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2110270086

DQoNCk9uIDI3LjEwLjIxIDE2OjIzLCBSb2dlciBQYXUgTW9ubsOpIHdyb3RlOg0KPiBPbiBXZWQs
IE9jdCAyNywgMjAyMSBhdCAxMTo1OTo0N0FNICswMDAwLCBPbGVrc2FuZHIgQW5kcnVzaGNoZW5r
byB3cm90ZToNCj4+IEhpLCBSb2dlciENCj4+DQo+PiBPbiAyNy4xMC4yMSAxMzoxNywgT2xla3Nh
bmRyIEFuZHJ1c2hjaGVua28gd3JvdGU6DQo+Pj4gSGksIFJvZ2VyIQ0KPj4+DQo+Pj4gT24gMTMu
MTAuMjEgMTY6NTEsIFJvZ2VyIFBhdSBNb25uw6kgd3JvdGU6DQo+Pj4+IE9uIFRodSwgU2VwIDMw
LCAyMDIxIGF0IDEwOjUyOjE1QU0gKzAzMDAsIE9sZWtzYW5kciBBbmRydXNoY2hlbmtvIHdyb3Rl
Og0KPj4+Pj4gRnJvbTogT2xla3NhbmRyIEFuZHJ1c2hjaGVua28gPG9sZWtzYW5kcl9hbmRydXNo
Y2hlbmtvQGVwYW0uY29tPg0KPj4+Pj4NCj4+Pj4+IFRoaXMgaXMgaW4gcHJlcGFyYXRpb24gZm9y
IGR5bmFtaWMgYXNzaWdubWVudCBvZiB0aGUgdlBDSSByZWdpc3Rlcg0KPj4+Pj4gaGFuZGxlcnMg
ZGVwZW5kaW5nIG9uIHRoZSBkb21haW46IGh3ZG9tIG9yIGd1ZXN0Lg0KPj4+Pj4gVGhlIG5lZWQg
Zm9yIHRoaXMgc3RlcCBpcyB0aGF0IGl0IGlzIGVhc2llciB0byBoYXZlIGFsbCByZWxhdGVkIGZ1
bmN0aW9uYWxpdHkNCj4+Pj4+IHB1dCBhdCBvbmUgcGxhY2UuIFdoZW4gdGhlIHN1YnNlcXVlbnQg
cGF0Y2hlcyBhZGQgZGVjaXNpb25zIG9uIHdoaWNoDQo+Pj4+PiBoYW5kbGVycyB0byBpbnN0YWxs
LCBlLmcuIGh3ZG9tIG9yIGd1ZXN0IGhhbmRsZXJzLCB0aGVuIHRoaXMgaXMgZWFzaWx5DQo+Pj4+
PiBhY2hpZXZhYmxlLg0KPj4+PiBXb24ndCBpdCBiZSBwb3NzaWJsZSB0byBzZWxlY3QgdGhlIGhh
bmRsZXJzIHRvIGluc3RhbGwgaW4gaW5pdF9iYXJzDQo+Pj4+IGl0c2VsZj8NCj4+PiBJdCBpcyBw
b3NzaWJsZQ0KPj4+PiBTcGxpdHRpbmcgaXQgbGlrZSB0aGF0IG1lYW5zIHlvdSBuZWVkIHRvIGl0
ZXJhdGUgb3ZlciB0aGUgbnVtYmVycyBvZg0KPj4+PiBCQVJzIHR3aWNlIChvbmUgaW4gYWRkX2Jh
cl9oYW5kbGVycyBhbmQgb25lIGluIGluaXRfYmFycyksIHdoaWNoIG1ha2VzDQo+Pj4+IGl0IG1v
cmUgbGlrZWx5IHRvIGludHJvZHVjZSBlcnJvcnMgb3IgZGl2ZXJnZW5jZXMuDQo+Pj4+DQo+Pj4+
IERlY291cGxpbmcgdGhlIGZpbGxpbmcgb2YgdnBjaV9iYXIgZGF0YSB3aXRoIHNldHRpbmcgdGhl
IGhhbmRsZXJzDQo+Pj4+IHNlZW1zIHNsaWdodGx5IGNvbmZ1c2luZy4NCj4+PiBPaywgSSB3b24n
dCBpbnRyb2R1Y2UgYWRkX2Jhcl9oYW5kbGVycywgdGh1cyByZW5kZXJpbmcgdGhpcyBwYXRjaCB1
c2VsZXNzLg0KPj4+IEknbGwgZHJvcCBpdCBhbmQgcmUtd29yayB0aGUgdXBjb21pbmcgcGF0Y2hl
cyB3aXRoIHRoaXMgcmVzcGVjdA0KPj4gT24gdGhlIG90aGVyIGhhbmQgYWZ0ZXIgdGhpbmtpbmcg
YSBiaXQgbW9yZS4NCj4+IFdoYXQgYWN0dWFsbHkgaW5pdF9iYXJzIGRvPw0KPj4gMS4gUnVucyBv
bmNlIHBlciBlYWNoIHBkZXYgKF9faW5pdD8pDQo+PiAyLiBTaXplcyB0aGUgQkFScyBhbmQgZGV0
ZWN0cyB0aGVpciB0eXBlLCBzZXRzIHVwIHBkZXYtPnZwY2ktPmhlYWRlciBCQVIgdmFsdWVzDQo+
PiAzLiBBZGRzIHJlZ2lzdGVyIGhhbmRsZXJzLg0KPj4NCj4+IEZvciBEb21VIHdlIG9ubHkgbmVl
ZCAzKSwgc28gd2UgY2FuIHNldHVwIGd1ZXN0IGhhbmRsZXJzLg0KPiBJIHRoaW5rIHlvdSBhc3N1
bWUgdGhhdCB0aGVyZSB3aWxsIGFsd2F5cyBiZSBhIGhhcmR3YXJlIGRvbWFpbiB3aXRoDQo+IHZQ
Q0kgZW5hYmxlZCB0aGF0IHdpbGwgZ2V0IHRoZSBkZXZpY2UgYXNzaWduZWQgYW5kIHRodXMgaW5p
dF9iYXJzIHdpbGwNCj4gYmUgZXhlY3V0ZWQgcHJpb3IgdG8gYXNzaWduaW5nIHRvIGEgZG9tVS4N
ClllcywgdGhpcyBpcyB0aGUgY3VycmVudCBhc3N1bXB0aW9uLi4uDQo+DQo+IEJ1dCB3aGF0IGFi
b3V0IGRvbTBsZXNzLA0KaXQgd2FzIGRlY2lkZWQgdG8gcHV0IGRvbTBsZXNzIG91dCBvZiBzY29w
ZSBmb3Igbm93DQo+ICAgb3Igd2hlbiB1c2luZyBhIGNsYXNzaWMgUFYgZG9tMD8NCkkgdGhvdWdo
dCB0aGF0IHZQQ0kgaXMgb25seSB1c2VkIGZvciBQVkggRG9tMCBhbmQgaXQgaXMgZW5vdWdoIGZv
ciBub3cNCih5ZXMsIHRoaXMgaXMgYSB3ZWFrIGFyZ3VtZW50LCBidXQgd2UgZG8gbm90IHdhbnQg
UENJIHBhc3N0aHJvdWdoIG9uIEFybQ0KdG8gYmVjb21lIGEgbmV2ZXIgZW5kaW5nIGdhbWUuLi4g
c2luY2UgMjAxNS4uLikNCj4gICBJbiB0aGF0IGNhc2UNCj4gdGhlIGRldmljZSB3b24ndCBnZXQg
YXNzaWduZWQgdG8gYSBoYXJkd2FyZSBkb21haW4gd2l0aCB2UENJIHN1cHBvcnQsDQo+IHNvIHRo
ZSB2cGNpIHN0cnVjdHVyZSB3b24ndCBiZSBhbGxvY2F0ZWQgb3IgZmlsbGVkLA0KWWVzLCB0aGlz
IGlzIHRydWUuIEJ1dCBiZWNhdXNlIG9mIHRoZSAzIGZ1bmN0aW9uZmxpdGllcyBvZiB0aGUgaW5p
dF9iYXJzIGlzDQpkb2luZyBpdCBtaWdodCBzdGlsbCBuZWVkIHNvbWUgZGlzLWFnZ3JlZ2F0aW9u
LCBlLmcuIEJBUiBzaXppbmcNCmlzIG5vdCBuZWVkZWQgYW5kIG1pZ2h0IG5vdCBiZSBwb3NzaWJs
ZSB3aGlsZSBhc3NpZ25pbmcgdG8gYSBEb21VLg0KU28sIEkgdGhpbmsgdGhhdCBpbml0X2JhcnMg
d2lsbCBuZWVkIHRvIGJlIHNwbGl0IGluIGFueSBjYXNlLg0KPiAgIGFuZCBoZW5jZQ0KPiBpbml0
X2JhcnMgd291bGQgaGF2ZSB0byBiZSBleGVjdXRlZCB3aGVuIGFzc2lnbmluZyB0byBhIGRvbVUu
DQpQbGVhc2Ugc2VlIGFib3ZlOiBub3Qgc3VyZSBpbml0X2JhcnMgY2FuIGV4aXN0IGluIGl0cyBm
b3JtIHRvIGFjaGlldmUgdGhhdC4NCk9uZSBvZiB0aGUgc3RlcHMgdGhpcyBwYXRjaCBpcyBkb2lu
ZyBpcyB3ZSBzcGxpdCBpbml0X2JhcnMgaW50bw0KYSkgcmVnaXN0ZXIgYXNzaWdubWVudA0KYikg
YWxsIHRoZSByZXNldDogaW5pdGlhbCBwZGV2J3MgaGVhZGVyIGluaXRpYWxpemF0aW9uLCBzaXpp
bmcgZXRjLg0KDQpUaGUgc2FtZSBpcyB0cnVlIGZvciBNU0kvTVNJLVguIFdoZW4gd2UgYWRkIHN1
cHBvcnQgZm9yIE1TSS9NU0ktWCBvbiBBcm0NCnlvdSB3aWxsIHNlZSB0aGUgc2FtZTogd2UgbmVl
ZCB0byBzcGxpdCBbMV0gKHRoaXMgaXMgV0lQKS4NCg0KU28sIEkgYW0gc3RpbGwgY29udmluY2Vk
IHRoYXQgd2UgbmVlZCBhZGRfYmFyX2hhbmRsZXJzIGluIHNvbWUgZm9ybS4NCj4gVGhhbmtzLCBS
b2dlci4NCj4NClsxXSBodHRwczovL2dpdGxhYi5jb20vcmFoc2luZ2gveGVuLWludGVncmF0aW9u
Ly0vY29tbWl0LzdiODk4NjAxMjYxZmMzYWQ4MzRhYzNkMDZjYzRjNzg0ZjMzYzk1YmI=


From xen-devel-bounces@lists.xenproject.org Wed Oct 27 14:08:30 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Oct 2021 14:08:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217007.376833 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfjbM-0005dR-SE; Wed, 27 Oct 2021 14:08:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217007.376833; Wed, 27 Oct 2021 14:08:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfjbM-0005dK-PF; Wed, 27 Oct 2021 14:08:24 +0000
Received: by outflank-mailman (input) for mailman id 217007;
 Wed, 27 Oct 2021 14:08:23 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=8lYk=PP=epam.com=prvs=0934bd4bd6=oleksandr_andrushchenko@srs-us1.protection.inumbo.net>)
 id 1mfjbL-0005d5-TM
 for xen-devel@lists.xenproject.org; Wed, 27 Oct 2021 14:08:23 +0000
Received: from mx0b-0039f301.pphosted.com (unknown [148.163.137.242])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 584e2738-372f-11ec-8461-12813bfff9fa;
 Wed, 27 Oct 2021 14:08:22 +0000 (UTC)
Received: from pps.filterd (m0174681.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 19RD4HSf006746; 
 Wed, 27 Oct 2021 14:08:20 GMT
Received: from eur04-db3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2056.outbound.protection.outlook.com [104.47.12.56])
 by mx0b-0039f301.pphosted.com with ESMTP id 3by7awra5w-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Wed, 27 Oct 2021 14:08:17 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by AM0PR03MB4881.eurprd03.prod.outlook.com (2603:10a6:208:100::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.14; Wed, 27 Oct
 2021 14:08:14 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::c038:e032:595a:651]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::c038:e032:595a:651%9]) with mapi id 15.20.4649.014; Wed, 27 Oct 2021
 14:08:13 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 584e2738-372f-11ec-8461-12813bfff9fa
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Sd/utTyXvWs1bztXD0rO3lRI9iceTJTgjIL9V9VPw2xM+h6//o4wx3NCSd/tb6t4kVA9tJkXT6/Sb78fpcdj2psdzvQF1/4snMMIcFVyNFcVDg8WTau7E14CsxjumpDfRbV5+B46Ih7SGVJcGfRU2dk8c28rKBGaMoXHLLX73xogxz/Y8fmjJ6ppgmEC/7/BMn8iawoY13x5j1ZR6MEbobh3bq0P9tv0owsn4OKR2w1g7yskkVXnLVs1qq7RA6sEPfwJQNT73LuKkl5kY93ohSuFcBj9exikPZNixFShHsVhv4oM5vrlJFn9bu4ichgcelmf6qKD2RnaR0l30IsHNg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Rn3I5RN5vIvThW5WWjLNL3MsWJiUA8D8v+CAnC/faGI=;
 b=Bqscu/bBNOzT/Hhfz2SmyyCiC2meGxNdmQ2ZmQvweCXAXHagR/gFokX5tjPuUnBYHmib6afvcmPq2EjFWWJA1tpZ33bQGDK0p4RDopJBo0QdaiBIcr8EmuZbZsTM97XGmVqqIIGiy0nvLO2MNyQAmgbPhEsH/wYNblqgt5R5I/BuvqSco2+VnTR9VWAgC7XDiwptiI/0Nfe5JcagUqQE9nuYjlIC4FKjFqIEaz2d0uxmk+a1Bf51eEeu7DYI9A+7m755SybRwB6FiyI5pVEtcTLX+VVmmP2fJddYVtNUZZiTAQtbyUNwpluj2Dh0ELx22Kxe3xVoXME5Bl6KThZYxg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Rn3I5RN5vIvThW5WWjLNL3MsWJiUA8D8v+CAnC/faGI=;
 b=eGmSP/umu01mvC9s6YF6YUhYAEZnm6/NDweKP83EJ1vWqQn+LfHRGvAo2F9QkQFhCorawBVrQtei698TM/b7LpWkcwiH8tZTW2oFuVkjFtCnPrX1bdK0pD1l0aiV1h6p6LqmbIeyvGd3ZsFMXWzZz0sRWj5OlVSP5LJTqZOe32HS/ZsmwBITATpIqw2zo8aunI35Tuisi0xqzN6lXP9kC3yilyNq89v7iju+wZS0UeJBvPJJWMTOtjQpHZ08ssaG3/3uy3HZuWHdWR8RAtNtuEec39VA9qTFEM8x2dR5kqpo//adBAeb1zcM8ta+WnP+gujwDJ3DrxdX/eLaVwCt2g==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
        "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
CC: "jgross@suse.com" <jgross@suse.com>, "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org" <sstabellini@kernel.org>,
        "jbeulich@suse.com"
	<jbeulich@suse.com>,
        Anastasiia Lukianenko <Anastasiia_Lukianenko@epam.com>,
        Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH v5] xen-pciback: allow compiling on other archs than x86
Thread-Topic: [PATCH v5] xen-pciback: allow compiling on other archs than x86
Thread-Index: AQHXtDtdCEW9atNFMk2qqaldf5A98Kvm/I6AgAATI4A=
Date: Wed, 27 Oct 2021 14:08:13 +0000
Message-ID: <a54ab50a-f35c-26b9-3907-20c014a1120a@epam.com>
References: <20210928073501.433559-1-andr2000@gmail.com>
 <71ce7c97-1d08-9fdf-b217-53eb914a29a6@oracle.com>
In-Reply-To: <71ce7c97-1d08-9fdf-b217-53eb914a29a6@oracle.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 1ecf37fa-9219-4632-6d55-08d99953375a
x-ms-traffictypediagnostic: AM0PR03MB4881:
x-microsoft-antispam-prvs: 
 <AM0PR03MB4881045FCF2A12E99B49E8A4E7859@AM0PR03MB4881.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:8273;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 kKDTZuZ1a+MTcICOGfBfs8L/pfO28kZAzLf8wysiYz/N5eMC804N6RRBFaM4a1beTBUdX839bob7Uxro9J/7+gxAeR8IcVSjgK0RJBJCkL2MDwv/v3FPHWtT77qrwXFS655/lymAUGZFLnj6Smdn9Wi0AMgXQJpxBg38bfwLYSA9gjzwM+T5d3eu+9S4iCMaSm1nyrHQoyHRIuhBIweteiHL8t7FxRBnPuckKOMoq0G3TgdtPo9L7JEzif7LevJw7KHfsIHFcfqBAGVTYUbk/0ykKmp5srjuRXgvD4ITCq0zMVXlDEWWkul0zvnCIb3ketzZpZYlCGaJAH6KWpqSVFjy593y7eE9YqqVhbtNC3qnxDAyXn44YEasubGY3ULz95xMti0equUNYjKaoyVyI2bUXhplE4DIm+MILgkFdkmgRcdpnt7WL2LWbLwIag52NOIuZ42b8ZtfOL3cpyZYSsu+F2RVPLrgA0OXWLHvU2xg132tcRhw52ECkk06BtwoJcjdfTNQOxxHqHQv3lhPqMDr/zLXRMeKUPh6syFbFRBCWxq4O3pZkVVl3RKlwnp4L2Tnb+SPtKV8sUx6Ep0g2xThG1FRZxvVjgryENTW0k3xtdgmhZLqCuVf7iBE1FlZTQQ36ao/Nf89tzVwyAFn5ildFYZ3+MiwvVrHaaUX7j56CB7Vp1mlOweS4jLq5GniCwis7uT2zYdct+E7RIqY6XV1oWmp0HPjyOp1vOe4HGi1RCqRCD1uq6zAAZ9wK7RD
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(8676002)(2616005)(122000001)(36756003)(107886003)(54906003)(38100700002)(31686004)(31696002)(38070700005)(316002)(6512007)(110136005)(5660300002)(86362001)(6486002)(508600001)(2906002)(4326008)(71200400001)(66946007)(66446008)(66476007)(64756008)(91956017)(76116006)(66556008)(6506007)(53546011)(186003)(83380400001)(26005)(8936002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?U0lJS0Q2MWdNQk93Ryt4R1RkN2tFNkNjR1hLTU15S2N6cXQ5OHVqYVpZZ1cx?=
 =?utf-8?B?cVlHOThKV3VHT0RXRnVDbzFVZG1DWWdSM3J1STNXVjBmYUtpMGFXa3VlRW9B?=
 =?utf-8?B?c2hDMC83Vm9tWXdDRWVJbzllYXBRMnZJMEdKZkhpclRpRWJLdklsbDIwRG9D?=
 =?utf-8?B?MHpsTUo3SEc2bFE2eWZQZXF3S1VYS2JLZ2F4ZmFIMWxOL3lTam5HU2FRSVU5?=
 =?utf-8?B?czlGQXJIQkxxakRaOTFpalRMR3NId2hqMmxQNUVSaVBaV1hoUnd0SmhXNEEw?=
 =?utf-8?B?bFVJalBROXhpN2tKV2krQk5WOTJZY0crTVNsaEt6QUloTGREUDVOZGdySktT?=
 =?utf-8?B?QzB4VzY1VkdQekw5ejZTKzkzRm41aTRGT1hiY1B4UitTZ0wxZktpQWYrcUlr?=
 =?utf-8?B?OXVRQjErb3JIcHEzeHYzOVFkQmNKbmROVVJCZXU2TExkQnhUcTZZR1hNN3Vs?=
 =?utf-8?B?dzVNQ1JwSG9tenFBZVBMb0M4NXZvZExUbEJPMlo3VFl3MWZMU1lRTk4rTnZk?=
 =?utf-8?B?QTRpM0FwZ1RZLzVDeUxEZnB1UG03aUtwOUFwMFBlQjFvVm80amF6d25HdlNU?=
 =?utf-8?B?cXZMZUhNR1R4d0JCanE4ZFhocDRhTERKYk5KRTRRWjQ1TDVPRmdENHdBbytm?=
 =?utf-8?B?M3hEUk5jWnBqR1M5U2JITndpVUY5aDRzVUZOaGgwUU1BLzQvNlZ0Ujhyemly?=
 =?utf-8?B?WFhlWTdZZ0hoNWwwV0lQY2Z0QmUzcFlXcFYzeXZ4Wkw5LzFXRjl2bWp0VWZM?=
 =?utf-8?B?MkExQmpJdVlNbnN4L0Nrb2tzQU9YQ1l4TWhWblFYWGpDYlhCOFdZb0t5RmVs?=
 =?utf-8?B?Q3V3Zi9Ob09janZJZ1BtZEdrOEtjU2o1M29ncVhxTitRTjdXRGt1UzdyZzVr?=
 =?utf-8?B?VnhCYzlpVWhXL0R0Mll3dGFYdThjcEduWjF4T2YrVkRRV2I5cUk3bVJoaDdJ?=
 =?utf-8?B?bHVsTmRyeis4VFV1ZFRIUm8wNTFEWjRlSGNKUGRXRG5lc0tWdEsvLzFsZHhy?=
 =?utf-8?B?Zkt2eThWdUJRbHU3VHFabVJiTlFYZ2p5Y0hPL2tTNHZreVBUUEZhZW16VGhF?=
 =?utf-8?B?VnJiMTdrcU5oVU8wYkVPa0Z6YkowcUxzTVdiU0dvUURWeEZURWpERzZkYllR?=
 =?utf-8?B?dEJ2bVJnck1yOTM0dENjZzBZSzRCU2xsZW5wM2RNT1pUeUpDZlErbm1zRHBn?=
 =?utf-8?B?UDlRc29tUDlmY2MzN0dtOUNFSU13NGdveVVwS09MZ2puRGx1M0J6MVJsWDRZ?=
 =?utf-8?B?SFZOVkhhSlRQcW1qODh2alBjbHpwcWk2NE42Z0d1YWx0c1U4RjAyT2R2TUY0?=
 =?utf-8?B?ei9ob0gzM012eU4rYlYvbTQyTlJDVVIwaHdrcDhDSWtzMldyZnFHbCtmOWw5?=
 =?utf-8?B?VVE0RUxCdmFZZlZyQUprSmhBcm55QXd4VGZGMU1PL09pclQzVWh1ZUdDdXRR?=
 =?utf-8?B?SmpEdlJFWXgyRmpGQ0g4L3Z0OGhKQ2haK2l3aFZuM09ad1ZnZDEraTE4dmFZ?=
 =?utf-8?B?eDh2a1psNzZtdEhha25ieXNQV1JVaU1XQzdZemRmTU9oUlRBQXBnUHFOL0ow?=
 =?utf-8?B?YkxFMFJnc0RqMnc3d3JGN1ZYbFoyNjJTcE1ERWdHYkpLeWJOK3RnVjBsWW5M?=
 =?utf-8?B?ajI3UFZDcFFJSUFGOUs1VWFrb3N5SmJZTElqMi9oRGwwRC92aDhPTUwwSHVF?=
 =?utf-8?B?bDYyZzREVVN3Tm9pNkhjbWNQdlo3ZE5MYy84MVBkNWw1Q25KblYrVU5MYzBB?=
 =?utf-8?B?TjFRM2N4T3EzRm5ETjNKampKQy9GMDZHaTNXNFhibFBNellQdEZwbE5WcU0w?=
 =?utf-8?B?YnpQNXE3UEVqL1h5NlJiSS9sQXVjc2VLYmFyakNwcGVZazZQVldYZ2tYTVNx?=
 =?utf-8?B?VjVXZ05xeW5pQTVmQ0ZGd1JKS3NqMHFnZE1QMmhqQnlHSFJYZHBNUEhxZ2NC?=
 =?utf-8?B?UlVxZU9BVzJDaGlpdlg5dDhlaWFVMUlMeGVCQmJTNnEzbmk1bmRMR3FHZVIz?=
 =?utf-8?B?bU8yaW84ek9zNE1mNkVVT0ZVUjcvOGJLL0YvcXZwZjFhcTZIUWdxVVdUVFlx?=
 =?utf-8?B?Z0JDeENJN0k5VGZjcjliMkRDQ0FrbEh2WVROVXFST3pNd1R0NVlaVHMxeWlu?=
 =?utf-8?B?elpkMUF4bUp2M1lRSk53TTVUNk1ocVltelh2TjZWUnE0MEd5WkxlTWhVZk9V?=
 =?utf-8?B?WkpxNTJzV1EreU9vVWJTeFVDeHlVMEFtbVQ2R1IvcnBpYlk4bmJVWVlhOFh0?=
 =?utf-8?B?RmlYQ3N6MUFNV2ZuWTJYVS96dmNBa2VLWTNOUjJ0Y29pNm9weGluN1dQK2ow?=
 =?utf-8?B?QXZuOVRhUnZJRldEMWdRd1NXeVJaNGhsTEd5UVE2a1djTUd6NFluQT09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <63AC4E6A6599E646A8110B071D4793C1@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1ecf37fa-9219-4632-6d55-08d99953375a
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Oct 2021 14:08:13.8529
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 4LBRjLfEQZBabVc7SHcdH05vEDqlNy9lljYGqYdGKPwPalIvGs+weq4iJ1gCjrphTTkzC7e17h8etUxt/PD2/PtA3kz/SgOq0eBSdP1LToB60KC5jbTX8MJMiiEVE5Iv
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR03MB4881
X-Proofpoint-GUID: -GGOC06-1D2eJXhRrbBJgsySY5UCtfVZ
X-Proofpoint-ORIG-GUID: -GGOC06-1D2eJXhRrbBJgsySY5UCtfVZ
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475
 definitions=2021-10-27_04,2021-10-26_01,2020-04-07_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 phishscore=0
 spamscore=0 clxscore=1015 mlxscore=0 mlxlogscore=999 malwarescore=0
 priorityscore=1501 bulkscore=0 suspectscore=0 lowpriorityscore=0
 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2110270086

SGksIEJvcmlzIQ0KDQpPbiAyNy4xMC4yMSAxNTo1OSwgQm9yaXMgT3N0cm92c2t5IHdyb3RlOg0K
Pg0KPiBPbiA5LzI4LzIxIDM6MzUgQU0sIE9sZWtzYW5kciBBbmRydXNoY2hlbmtvIHdyb3RlOg0K
Pj4gRnJvbTogT2xla3NhbmRyIEFuZHJ1c2hjaGVua28gPG9sZWtzYW5kcl9hbmRydXNoY2hlbmtv
QGVwYW0uY29tPg0KPj4NCj4+IFhlbi1wY2liYWNrIGRyaXZlciB3YXMgZGVzaWduZWQgdG8gYmUg
YnVpbHQgZm9yIHg4NiBvbmx5LiBCdXQgaXQNCj4+IGNhbiBhbHNvIGJlIHVzZWQgYnkgb3RoZXIg
YXJjaGl0ZWN0dXJlcywgZS5nLiBBcm0uDQo+Pg0KPj4gQ3VycmVudGx5IFBDSSBiYWNrZW5kIGlt
cGxlbWVudHMgbXVsdGlwbGUgZnVuY3Rpb25hbGl0aWVzIGF0IGEgdGltZSwNCj4+IHN1Y2ggYXM6
DQo+PiAxLiBJdCBpcyB1c2VkIGFzIGEgZGF0YWJhc2UgZm9yIGFzc2lnbmFibGUgUENJIGRldmlj
ZXMsIGUuZy4geGwNCj4+IMKgwqDCoCBwY2ktYXNzaWduYWJsZS17YWRkfHJlbW92ZXxsaXN0fSBt
YW5pcHVsYXRlcyB0aGF0IGxpc3QuIFNvLCB3aGVuZXZlcg0KPj4gwqDCoMKgIHRoZSB0b29sc3Rh
Y2sgbmVlZHMgdG8ga25vdyB3aGljaCBQQ0kgZGV2aWNlcyBjYW4gYmUgcGFzc2VkIHRocm91Z2gN
Cj4+IMKgwqDCoCBpdCByZWFkcyB0aGF0IGZyb20gdGhlIHJlbGV2YW50IHN5c2ZzIGVudHJpZXMg
b2YgdGhlIHBjaWJhY2suDQo+PiAyLiBJdCBpcyB1c2VkIHRvIGhvbGQgdGhlIHVuYm91bmQgUENJ
IGRldmljZXMgbGlzdCwgZS5nLiB3aGVuIHBhc3NpbmcNCj4+IMKgwqDCoCB0aHJvdWdoIGEgUENJ
IGRldmljZSBpdCBuZWVkcyB0byBiZSB1bmJvdW5kIGZyb20gdGhlIHJlbGV2YW50IGRldmljZQ0K
Pj4gwqDCoMKgIGRyaXZlciBhbmQgYm91bmQgdG8gcGNpYmFjayAoc3RyaWN0bHkgc3BlYWtpbmcg
aXQgaXMgbm90IHJlcXVpcmVkDQo+PiDCoMKgwqAgdGhhdCB0aGUgZGV2aWNlIGlzIGJvdW5kIHRv
IHBjaWJhY2ssIGJ1dCBwY2liYWNrIGlzIGFnYWluIHVzZWQgYXMgYQ0KPj4gwqDCoMKgIGRhdGFi
YXNlIG9mIHRoZSBwYXNzZWQgdGhyb3VnaCBQQ0kgZGV2aWNlcywgc28gd2UgY2FuIHJlLWJpbmQg
dGhlDQo+PiDCoMKgwqAgZGV2aWNlcyBiYWNrIHRvIHRoZWlyIG9yaWdpbmFsIGRyaXZlcnMgd2hl
biBndWVzdCBkb21haW4gc2h1dHMgZG93bikNCj4+IDMuIERldmljZSByZXNldCBmb3IgdGhlIGRl
dmljZXMgYmVpbmcgcGFzc2VkIHRocm91Z2gNCj4+IDQuIFBhcmEtdmlydHVhbGlzZWQgdXNlLWNh
c2VzIHN1cHBvcnQNCj4+DQo+PiBUaGUgcGFyYS12aXJ0dWFsaXNlZCBwYXJ0IG9mIHRoZSBkcml2
ZXIgaXMgbm90IGFsd2F5cyBuZWVkZWQgYXMgc29tZQ0KPj4gYXJjaGl0ZWN0dXJlcywgZS5nLiBB
cm0gb3IgeDg2IFBWSCBEb20wLCBhcmUgbm90IHVzaW5nIGJhY2tlbmQtZnJvbnRlbmQNCj4+IG1v
ZGVsIGZvciBQQ0kgZGV2aWNlIHBhc3N0aHJvdWdoLg0KPj4NCj4+IEZvciBzdWNoIHVzZS1jYXNl
cyBtYWtlIHRoZSB2ZXJ5IGZpcnN0IHN0ZXAgaW4gc3BsaXR0aW5nIHRoZQ0KPj4geGVuLXBjaWJh
Y2sgZHJpdmVyIGludG8gdHdvIHBhcnRzOiBYZW4gUENJIHN0dWIgYW5kIFBDSSBQViBiYWNrZW5k
DQo+PiBkcml2ZXJzLg0KPj4NCj4+IEZvciB0aGF0IGFkZCBuZXcgY29uZmlndXJhdGlvbiBvcHRp
b25zIENPTkZJR19YRU5fUENJX1NUVUIgYW5kDQo+PiBDT05GSUdfWEVOX1BDSURFVl9TVFVCLCBz
byB0aGUgZHJpdmVyIGNhbiBiZSBsaW1pdGVkIGluIGl0cw0KPj4gZnVuY3Rpb25hbGl0eSwgZS5n
LiBubyBzdXBwb3J0IGZvciBwYXJhLXZpcnR1YWxpc2VkIHNjZW5hcmlvLg0KPj4geDg2IHBsYXRm
b3JtIHdpbGwgY29udGludWUgdXNpbmcgQ09ORklHX1hFTl9QQ0lERVZfQkFDS0VORCBmb3IgdGhl
DQo+PiBmdWxseSBmZWF0dXJlZCBiYWNrZW5kIGRyaXZlci4NCj4+DQo+PiBQbGVhc2Ugbm90ZSwg
dGhhdCBDT05GSUdfWEVOX1BDSURFVl9CQUNLRU5EIGFuZCBDT05GSUdfWEVOX1BDSURFVl9TVFVC
DQo+PiBhcmUgbXV0dWFsbHkgZXhjbHVzaXZlLg0KPj4NCj4+IFNpZ25lZC1vZmYtYnk6IE9sZWtz
YW5kciBBbmRydXNoY2hlbmtvIDxvbGVrc2FuZHJfYW5kcnVzaGNoZW5rb0BlcGFtLmNvbT4NCj4+
IFNpZ25lZC1vZmYtYnk6IEFuYXN0YXNpaWEgTHVraWFuZW5rbyA8YW5hc3Rhc2lpYV9sdWtpYW5l
bmtvQGVwYW0uY29tPg0KPj4gUmV2aWV3ZWQtYnk6IFN0ZWZhbm8gU3RhYmVsbGluaSA8c3N0YWJl
bGxpbmlAa2VybmVsLm9yZz4NCj4NCj4NCj4gT2xla3NhbmRyLA0KPg0KPg0KPg0KPiBDYW4geW91
IHBsZWFzZSByZWJhc2UgdGhpcyBvbiB0b3Agb2YgNS4xNS1yYzc/IFRoZXJlIGlzIGEgYnVuY2gg
b2YgY29uZmxpY3RzIGR1ZSB0byBjYWU3ZDgxYTM3MzBkZmUwODYyM2Y4YzEwODMyMzBjOGQwOTg3
NjM5Lg0KPg0KSSdsbCB0cnkgdG8gZG8gdGhhdCBBU0FQICh3aGF0IGlzIHRoZSBkZWFkbGluZSBm
b3IgdGhhdD8pDQo+DQo+IFRoYW5rcy4NCj4NCj4gLWJvcmlzDQo+DQpUaGFuayB5b3UsDQpPbGVr
c2FuZHI=


From xen-devel-bounces@lists.xenproject.org Wed Oct 27 14:13:54 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Oct 2021 14:13:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217018.376844 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfjgX-00077q-KD; Wed, 27 Oct 2021 14:13:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217018.376844; Wed, 27 Oct 2021 14:13:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfjgX-00077j-HF; Wed, 27 Oct 2021 14:13:45 +0000
Received: by outflank-mailman (input) for mailman id 217018;
 Wed, 27 Oct 2021 14:13:44 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+yfZ=PP=citrix.com=anthony.perard@srs-us1.protection.inumbo.net>)
 id 1mfjgW-00077a-L0
 for xen-devel@lists.xenproject.org; Wed, 27 Oct 2021 14:13:44 +0000
Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 171ace6e-3730-11ec-8461-12813bfff9fa;
 Wed, 27 Oct 2021 14:13:43 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 171ace6e-3730-11ec-8461-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1635344023;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=9O6EJPV7a2A5/ZVPN2tD/rjdbuiLIuY9TnBRQOAhMjI=;
  b=K+p7mWzzA7NXY5fMy54uuBG7MeKPFYfB4R9UKI+R1JEiXvpLN7aHnZ9p
   0qQC3uZJIST4iHnMNDfJ8l4Zfrp6qEyubzsINZKZ7DTXf24vX+omVkyWr
   iuxvJMq+xyVBT10xMpqxBZHBdXkOALH1cMRoNFXCnboGuMaS9pMD2OP64
   I=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: uLQo/QPh8uHBjN1Zgc4Ue5bRU4fyVX26Eb+H0TUIve9U7uBUObOAWH1coRGRW/vvRpX+RuSaCT
 f8xf2ENsq4bXSsrSJ40v+ieisnTc2zlS0Cm4g+RiYKIGmNacnKsWs3DUayTi6MGM8GEhu+a55i
 N5N4kvaQ0CJ8Qg/DnwOftL5bRtgTweFaGQ7aupxRqjflnm2MJet0AZ61ObEB+T+hIF81MFtRTf
 q+dN1f9uDZAKt5KT6/BYJ0i5hH7QdjVIakes0PMX6joTTB2BT9ULD1sZkD+G1WWcrvLRy8fUs0
 fP+D6QoLeHFuWmeymiKjFhV+
X-SBRS: 5.1
X-MesageID: 56361623
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:C8FtxqlDbcZsUBmz10v4oeno5gwcIURdPkR7XQ2eYbSJt1+Wr1Gzt
 xJMUTjSM66OMDGmett3bdnkpBgEvMPQnYBiQAVo+yA1EyMWpZLJC+rCIxarNUt+DCFioGGLT
 Sk6QoOdRCzhZiaE/n9BClVlxJVF/fngqoDUUYYoAQgsA187IMsdoUg7wbdg2tQ32YHR7z6l4
 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc
 s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4
 PRDhJ2ySzgpApPnpbpefThUFDNCGIQTrdcrIVDn2SCS50jPcn+qyPRyFkAme4Yf/46bA0kXq
 6ZecmpUKEne2aTmm9pXScE17ignBMDtIIMYvGAm1TzDBOwqaZvCX7/L9ZlT2zJYasVmQKiFO
 ZNHM2EHgBLoUQxtHXNGMcMHmOavjTraLTBTunuxnP9ii4TU5FMoi+W8WDbPQfSBTN9ZmUuwr
 Wvc82P0RBodMbS31j6t4n+qwOjVkkvTQ54fGrS+8bhxnFSZy2gXCRsXfUu6pfi/mgi1XNc3A
 1cP5iMkoKw29UqqZtrwRRu1pDiDpBF0c8pdFag25R+AzoLQ4h2FHS4UQzhZctskucQqAzsw2
 TehnszrLSxitqWPTnCQ/avSqim9URX5NkdbO3VCF1FcpYC+/sdj1XojU+qPDoaUgOz0GzPPw
 wy0hxVgxJsygckZ64CSqAWvby2XmrDFSQs85wPyV22j7x9kaIPNW7FE+WQ3/t4bc97HFgjpU
 Gws3pHEtrhXXM7leDmlGb1VRNmUC+C53CowaLKFN6Iq8Cix4DaddIRU7SAWyKxBY5tcJ2GBj
 KM+v2psCH5v0JmCMfAfj2GZUZ1CIU3c+TLNDKi8gj1mOcEZSeN/1HsyDXN8Jki0+KTWrYkxO
 I2AbeGnBmsABKJswVKeHrlGjOV0nXBknTqLGPgXKihLN5LEPBZ5rp9eaTOzgh0RtvvY8G05D
 f4Gb6NmNCmzoMWhO3KKoOb/3HgBLGQhBICeliCkXrXrH+aSI0l4U6W56ep4I+RNxv0J/s+Vr
 iDVchIJkzLX2CyYQThmn1g+MdsDq74k9illVcHtVH71s0UejXGHtvhALstmJ+B+pYSOD5dcF
 pE4RilJOdwXIhyvxtjXRcKVQFVKeEv5iASQETCiZTRjLZdsSxaQoo3vfxf19TlIBS2y7JNsr
 7ql3wLdYJwCWwU9U5qGNKPxlwu87SoHheZ/f0rUOd0PKk/ix5dndn7qhfgtLsBSdRianmmG1
 xybCAszrPXWp9Nn68HAgK2J9t/7E+Z3EkdAMXPc6LK6aXvT8ma5mNcSW+eUZzHNEmjz/fz6N
 +lSyvj9NtwBnUpL7NUgQ+o6k/pm6oK29bFAzwliEHHaVHiRC+ttciucwM1ClqxR3bsF6wG4b
 V2Cp4tBMrKTNcK7TFNIfFg5bv6O3O0/kyXJ6ahnO13z4SJ68ebVUUhWOBXQ2iVRIKEsbdEgy
 OYl/sUX9xa+mlwhNdPf1nJY8GGFL3ohVaQ7t85FXN+321RzklwSM4bBDiLW4Y2Ub4QeO0YnF
 TaYma7eiukO3UHFaXcySSDA0Oc1aU7iY/yWIIvu/2i0p+c=
IronPort-HdrOrdr: A9a23:FKoADalhg3FFxFLpsp7Wbw7tPyzpDfIs3DAbv31ZSRFFG/Fxl6
 iV8sjz8SWE7Ar5OUtQ/OxoV5PsfZqxz/JICMwqTNCftWrdyQmVxeNZjbcKqgeIc0aVygce79
 YCT0EXMqyXMbEQt6fHCWeDfOod/A==
X-IronPort-AV: E=Sophos;i="5.87,186,1631592000"; 
   d="scan'208";a="56361623"
Date: Wed, 27 Oct 2021 15:13:37 +0100
From: Anthony PERARD <anthony.perard@citrix.com>
To: Stefano Stabellini <sstabellini@kernel.org>
CC: <xen-devel@lists.xenproject.org>, <iwj@xenproject.org>,
	<cardoe@cardoe.com>, <wl@xen.org>, <andrew.cooper3@citrix.com>, "Stefano
 Stabellini" <stefano.stabellini@xilinx.com>
Subject: Re: [PATCH v2 3/3] automation: add a QEMU based x86_64 Dom0/DomU test
Message-ID: <YXleke8ciibv/1qt@perard>
References: <alpine.DEB.2.21.2110251836020.4586@sstabellini-ThinkPad-T480s>
 <20211026014200.32102-3-sstabellini@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20211026014200.32102-3-sstabellini@kernel.org>

On Mon, Oct 25, 2021 at 06:42:00PM -0700, Stefano Stabellini wrote:
> From: Stefano Stabellini <stefano.stabellini@xilinx.com>
> 
> Introduce a test based on QEMU to run Xen, Dom0 and start a DomU.
> This is similar to the existing qemu-alpine-arm64.sh script and test.
> The only differences are:
> - use Debian's qemu-system-x86_64 (on ARM we build our own)
> - use ipxe instead of u-boot and ImageBuilder
> 
> Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>
> ---
>  automation/gitlab-ci/test.yaml           | 24 ++++++
>  automation/scripts/qemu-alpine-x86_64.sh | 95 ++++++++++++++++++++++++
>  2 files changed, 119 insertions(+)
>  create mode 100755 automation/scripts/qemu-alpine-x86_64.sh
> 
> diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.yaml
> index 91a10febbf..43d248a604 100644
> --- a/automation/gitlab-ci/test.yaml
> +++ b/automation/gitlab-ci/test.yaml
> @@ -47,6 +47,30 @@ qemu-alpine-arm64-gcc:
>      - /^coverity-tested\/.*/
>      - /^stable-.*/
>  
> +qemu-alpine-x86_64-gcc:
> +  stage: test
> +  image: registry.gitlab.com/xen-project/xen/${CONTAINER}
> +  variables:
> +    CONTAINER: debian:stretch
> +  script:
> +    - ./automation/scripts/qemu-alpine-x86_64.sh 2>&1 | tee qemu-smoke-arm64.log

Maybe the log file should be called "qemu-smoke-x86_64.log" ? Or just
"qemu-smoke.log"?


I'm still not happy about the `apt install` in the middle of the test,
but I guess that will do for now:

Reviewed-by: Anthony PERARD <anthony.perard@citrix.com>

Thanks,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Wed Oct 27 14:47:18 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Oct 2021 14:47:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217027.376855 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfkCk-00024k-7c; Wed, 27 Oct 2021 14:47:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217027.376855; Wed, 27 Oct 2021 14:47:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfkCk-00024d-4T; Wed, 27 Oct 2021 14:47:02 +0000
Received: by outflank-mailman (input) for mailman id 217027;
 Wed, 27 Oct 2021 14:47:00 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=7jCJ=PP=oracle.com=boris.ostrovsky@srs-us1.protection.inumbo.net>)
 id 1mfkCi-00024X-8G
 for xen-devel@lists.xenproject.org; Wed, 27 Oct 2021 14:47:00 +0000
Received: from mx0b-00069f02.pphosted.com (unknown [205.220.177.32])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id bcdfd66a-3734-11ec-8473-12813bfff9fa;
 Wed, 27 Oct 2021 14:46:59 +0000 (UTC)
Received: from pps.filterd (m0246632.ppops.net [127.0.0.1])
 by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 19RDpOZF004972; 
 Wed, 27 Oct 2021 14:46:56 GMT
Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70])
 by mx0b-00069f02.pphosted.com with ESMTP id 3bx4fj3k6d-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Wed, 27 Oct 2021 14:46:55 +0000
Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1])
 by aserp3020.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 19REPdtZ085047;
 Wed, 27 Oct 2021 14:46:54 GMT
Received: from nam11-co1-obe.outbound.protection.outlook.com
 (mail-co1nam11lp2169.outbound.protection.outlook.com [104.47.56.169])
 by aserp3020.oracle.com with ESMTP id 3bx4gctbx0-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Wed, 27 Oct 2021 14:46:54 +0000
Received: from BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10)
 by MN2PR10MB4030.namprd10.prod.outlook.com (2603:10b6:208:1bd::27)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.18; Wed, 27 Oct
 2021 14:46:52 +0000
Received: from BLAPR10MB5009.namprd10.prod.outlook.com
 ([fe80::3c49:46aa:83e1:a329]) by BLAPR10MB5009.namprd10.prod.outlook.com
 ([fe80::3c49:46aa:83e1:a329%6]) with mapi id 15.20.4649.014; Wed, 27 Oct 2021
 14:46:52 +0000
Received: from [10.74.107.92] (138.3.200.28) by
 SN4PR0201CA0029.namprd02.prod.outlook.com (2603:10b6:803:2e::15) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.14 via Frontend
 Transport; Wed, 27 Oct 2021 14:46:50 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: bcdfd66a-3734-11ec-8473-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date :
 subject : to : cc : references : from : in-reply-to : content-type :
 content-transfer-encoding : mime-version; s=corp-2021-07-09;
 bh=ez8CdOqAU4YBceY+JgLTkEaT24Hss77HCx0Dmj9E0Yw=;
 b=IMx52jKUpud9sJBFWWmdNECcOoesUg9hLpTmTBRNt1Fs9Suvsdrv4yKVBWIgUJPMnydC
 i/FjipoYq5p7mlrjZQr/e2pHCXFfPjg+7eTGztbhfkTr0MDiiyel62jQIDhx/8PsToEB
 gt1wzbjtk1rUsGRgnWSyvXlZzY0vNZLEi899ZuWqIZ0j+uRqcla659UtLJiUOTPGzaBY
 ldmPxHezWm5OFkOCmC5nVNBNNSwW6rbjCnjkarYVMUbInr1lxGPBg0bDmDT7rJNveSDB
 NNz54u+d5SuJX6IpomMDfaGbLr6BJrifM7ZKOoOCQCQnioe70CFGDELIJ0MEN9WJ9Pbx 8A== 
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=YMI9VEJ5L2dA0zOtBnpjN1OAYXACLk6qPVN+w/etCUFzt9Mkk14MlxVqFI/n61EvJ/z8fI2angR8betv2Scw7jJdzSolw6WBUhyRX4DlJJ01UxNXmTgo+Ql1L06AtNoJzK3nBagmf9jsu5wwVPRLVUXV26N8qUd6Av3t1boLSJvpT+RKQWZDByiCbpZBzoRDRWSqrTx22Ac4ZqYQPbzJbYVC4FvNf9Rs6b515XyArHb/sELV9Ijc+2IPSJHeF+sp0pvGxqeB0fZASUwmIaKZ8+0X+6Xp9rLDJuDzLccENdC7za7rRKl8wWPFWnGPtExyD2Cn1m0fYW3ys8NoheJWvA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ez8CdOqAU4YBceY+JgLTkEaT24Hss77HCx0Dmj9E0Yw=;
 b=JpPL9gu5kbDXy9IpGEY6ZWquT3CGMMbtfH5nQzZ5xHidEcVzYi+owQ1BAI689udJr3ZKTjxkgRMbErEqkeV3mfV1bnXZOAjZCeXkdp9N8PKLkISpje1JqIyPeA1ZwziRsd8dRdjx0zZSLBwto7lo45bLZ0Jpw94jcKpcVsC+slIVnkkLH5xZOdJmJam8NzU98kQUR+YhgNyt8preNUIBJVPsV2JCPcA4r7haSf5Ux29YkVGY+WFgGQdOOaLh7/evGamPl+fv3QCoP0cb0G0QvgRfxsOmtF54RgYAgQSYvgzx90NHOAO9MM1uP0mSoqlPPOAqjpWgju4NeKQ8WV9F0Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com;
 dkim=pass header.d=oracle.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ez8CdOqAU4YBceY+JgLTkEaT24Hss77HCx0Dmj9E0Yw=;
 b=BBk5Dqm6TpuDpIJMl82Ugi0pIZwshHpMjYeJvyStsm5V4aqbOoXcKUu/ZaLRlGfqfG4ZDJIgmKhLhfkvIQhD2muBFImOxT6I7ifYx3dQEZNRn/kxCiYrsjR1tVCPxx/KvQkDztu8DTJlAbqKdKO06+uh6hWOwpWY1Kt7a7cLvJM=
Authentication-Results: epam.com; dkim=none (message not signed)
 header.d=none;epam.com; dmarc=none action=none header.from=oracle.com;
Message-ID: <af42493e-ec31-8673-5532-1f0c8275b2c6@oracle.com>
Date: Wed, 27 Oct 2021 10:46:46 -0400
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.2.1
Subject: Re: [PATCH v5] xen-pciback: allow compiling on other archs than x86
Content-Language: en-US
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>,
        "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: "jgross@suse.com" <jgross@suse.com>, "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org" <sstabellini@kernel.org>,
        "jbeulich@suse.com" <jbeulich@suse.com>,
        Anastasiia Lukianenko <Anastasiia_Lukianenko@epam.com>
References: <20210928073501.433559-1-andr2000@gmail.com>
 <71ce7c97-1d08-9fdf-b217-53eb914a29a6@oracle.com>
 <a54ab50a-f35c-26b9-3907-20c014a1120a@epam.com>
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
In-Reply-To: <a54ab50a-f35c-26b9-3907-20c014a1120a@epam.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: SN4PR0201CA0029.namprd02.prod.outlook.com
 (2603:10b6:803:2e::15) To BLAPR10MB5009.namprd10.prod.outlook.com
 (2603:10b6:208:321::10)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: b0c66ac8-f91b-488e-475d-08d999589d22
X-MS-TrafficTypeDiagnostic: MN2PR10MB4030:
X-Microsoft-Antispam-PRVS: 
	<MN2PR10MB4030DD5A20F81A78B799C3AF8A859@MN2PR10MB4030.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:2043;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 
	7xcGj9Ok/zO7dLjD+ZoTO+FWRsQUZSD7GYOaJGSzaDM5YF7FZ4pQWIvXrg8scNPQRJomnjeFvOqrpLDl2dlZGWYftQVVTWRWMkrhwGj+o1i8R4WaR/Sfh/Grw/Lh2RvI8u7lgI5GN1CirKR1kdl9sCtqyV8kPUzoyRrCqTaFdtPJXe+55dnsUExX2H37Pdex6rO3PjLejDEmNKKU329/75urKgqh177fyQMgELv/15Kmj2RP9oViWZ7xIKz5+FrkpLua3vl3g3fVuzJhRTCgkEfZLlGiUPBzUqsfaUAUY6eXXFsj5ZdRbyazlTlaCXqRusgRpwCMXWGfGXYUBKXk6PkL48RJis1bRqjTj9MMhKjA9IoFNMftlVwRFta05epUhck7mWNak0wh/aAhK3/nuCXRHwGoChOuekU3x1XqDhRoZvMcEcA69cdUG2HXOHD9qG28oIGcSuZHHGpRASOc5l6bGQNVjwWUeH+55vhSlnDNTq8QxLg4T5OP9EXW76MGL5PEybrUds68sAfcF2GboaQzn6uS8T6FBMjPuRqInrIQHqS5UOqiW1WZqyKjImCl5FotOF9ako9duKGS9kKmXuABfym26QGz0lm70Y0Oz+/LyxAfj7kMIdVNbVXEKW/uIDfERu8Iw+PavIN/aJZeT9J6sSRcNykPjaW+FPdXt6mUaEYO2eVJOo/3peUCQH5+JeLvG2PuJosO00PqR563uO+ggJl/SOjX+3oY7tPzOnU=
X-Forefront-Antispam-Report: 
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB5009.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(38100700002)(508600001)(36756003)(31696002)(26005)(66556008)(4744005)(5660300002)(110136005)(31686004)(16576012)(8676002)(2616005)(316002)(6666004)(186003)(2906002)(66476007)(8936002)(4326008)(956004)(66946007)(54906003)(53546011)(6486002)(86362001)(44832011)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?QTdBYXBNd3hiV292cHMxdzFyNWk4OWRhQ3VKUnQwOU5XQmVpVVBTaHJkOER3?=
 =?utf-8?B?SFhyZG0wSWJOd1piVDV0ZUpyMWNiZTEwb3grSUlZUXNsVTNLOTlUMFY2V0RJ?=
 =?utf-8?B?cjVxZzd0QjRCQWRvRlVsRTBickpVUXA1dTFuSGYzUG9CRTF2b0JyemdLV2Er?=
 =?utf-8?B?Zm90NDl0R0ZLL0Rvak5McGl3RHN2TThaWWFBVlVNN29lOG9sZjJnK0ZocWJs?=
 =?utf-8?B?WVRCcGJpY2FnNXlnY3NVUzFmTjVnVGdaOWRkWXdaYVRDM0I0TnpqcnNPN1I0?=
 =?utf-8?B?Sk14c2Ywb0MxYll0VzNZZ1ozMmZNU0NLT09malRUbDRzQmhIUG1yTUczT1pX?=
 =?utf-8?B?MG56SW5lUTJ5elIxdFoxeFQzeDFvQjh0V3pFdzRWajdTUm9VMlRNWVFpZEJG?=
 =?utf-8?B?Y1JnWHNrb3NCd0l1b2sva3ZndjR4c1pveUxOTnJtYmpkMm9wWmh4NE1sQlZa?=
 =?utf-8?B?VEFlT0Vyc3pWdERUM2FUTXRCYUFsdWU5dmROYlVxUmdmTytwTm1CckFYQ3RH?=
 =?utf-8?B?QU1WNFJWbVV4OFAwUGNOcndDb29ocWlRM05EOFVrQkNpS2FlZnlyRURBelNM?=
 =?utf-8?B?dExpTDIrRzJpZWd4OGptZGo1YXZHV1Z5SHFTSHgrdHc2MjZtbFRtYlZtUXI2?=
 =?utf-8?B?ek1iQkNzYmxOVUdrQmdwNjRodm1hbVJQRS9CU2lrZmx5MnAvaDhJQk1UdjNu?=
 =?utf-8?B?R3BNM0NOWms3ei9vNXl0b1dkRlU5N2VQT1FFR0RlWXB0UkdPYkxwRTFCa3VL?=
 =?utf-8?B?M2FkZmJUQ1VnSWFRbGozaFNqTHRoVE4ybmxPV1lDODBTdDBiTHhMYUNoRGpP?=
 =?utf-8?B?cWk3YXFBZXU3ZS9aZjBHeFZONzlsaWVZVmp0Mm9FKzBzVVIwcVN5YldPdFlq?=
 =?utf-8?B?ZFVONkNsdmRsbElwV1pkVXFOM1A4dXBWamJGOGlzQkVqa3hnOUNaUUd3Nkpp?=
 =?utf-8?B?aHFOaDZKQXN3VmxnVDk3QzFTbXpBb2NqSHBocng2cEJnd0xZYU9KWnd4ZVBw?=
 =?utf-8?B?bDMvc2cySWZmSDNVUjY3aUVVci9mVytsVUVKN2w3d3NucVZYRVppMDYvSjlE?=
 =?utf-8?B?S3kzYjlQMEJmT3pDcytaK0xWZzkyaE92R2pTOStzdUVubnZ5NXVwVWl3TWVW?=
 =?utf-8?B?RTErRFMzQk5BZ3pyckRpSWpRbVFIZWRVMHprVTQ4Z3d5aFJkT1ZEVkN5YW9Z?=
 =?utf-8?B?RFdGU0pQMHZKbGJ2cWZKMzR3SDdUREE1aGtEQmlCU0p3ZS9aZFFhVFQ1VFc3?=
 =?utf-8?B?TU9iRTN2K2o0TExFQUF1QUpGTVJ0aUMwZWs2cnVSOXVGbndTd0E5YzkzYURI?=
 =?utf-8?B?QmpOQmxaUjJIWjg3MGZnK1VWdUZRZjhlWk9EdnV1WXFjdnBJRGw0T1lSNzE3?=
 =?utf-8?B?R09zWkRxNWF5ZlF4cnJkTDFXeHNhOC8zVFExNnpkVjJmQVkxY1N6NWZETS9X?=
 =?utf-8?B?aTB0Sjl5MUphdHhUSkRTamlBci9MRzV0MWJsYkxjaVc5ejJESkdpcEQ4Tkti?=
 =?utf-8?B?a0QvUU1NMzZHVFp5NXl3eiszdTAzRmh3TDYybGkxT1RBbm81OU53Ky9aQjlh?=
 =?utf-8?B?eFphMm9IK3QvRnNjVlFTMGFKeCs5MmFRV1hjOVM3MkxheTBKakJscXlLZjgx?=
 =?utf-8?B?aDVsZzN6TXFWQnpTU1ZKSnliNkxIemNYcW9aNFZrMTdXZFVlS0hibjJwZUU5?=
 =?utf-8?B?ajZXTVZoRDY4NUJTd3NCK0ZGVXVqTVROL0x6byttTG5JcjkyY0h1SmdEa2ZX?=
 =?utf-8?B?eDdVbGNwVTFxTCtLbFBaUEx2ZWxZZEJweXhZM2NSTjlrOUQrZ0c5OEtiWUhN?=
 =?utf-8?B?MS9xejNWRU1FWWtrL1dyRkZFR3RhbzJnM01TT05lazBER3pNKytJbExTZS9Q?=
 =?utf-8?B?aWFkeEN2dE5oNzVUdnkrT3JjYm1sbGtERENubTVqZUg2Q2NXRXBxaUJFZTBW?=
 =?utf-8?B?ME5lZnArMkpYUHYyVHRLRkxLZnpKdkQwT3VkekdwMlJYbVJDS3JSK2hKOGVZ?=
 =?utf-8?B?cVMrdjFUbzlObjJYZ0o0YUNzd1JCbldHV1c2bHR0QXlrblFDS2ZkMURFZklk?=
 =?utf-8?B?Q2tVNHlzL3JXUHlBSm1jbEVDakJFRmJMU3J0Vlp5R1hGbEJWdCs0WFNNU05L?=
 =?utf-8?B?S2NvbitHNFpMNEdReDVxUjFnMENycmNTSW1ldVI2ZE9sQkJQZmhsWVl5TEwx?=
 =?utf-8?B?ZUE0ano5cXNtN3FzRnh6ZlFFQ1QrM0paN3BDYzdOMndjekJtVDB5ekpUN1V1?=
 =?utf-8?Q?vjZ1LjDnKn+HxZDGoV1+58r6nj/0uaDXdGeq6Ddb58=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b0c66ac8-f91b-488e-475d-08d999589d22
X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Oct 2021 14:46:52.3869
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: tzBQsHnCb+cHUKC9u15eeaajJiEnHeBSA/1mwkXVVesJpssQFNP7aFXCUrdetdxMMUbndSCdDWulhQdgxagOFS5NqVg0XwzkxTyN6v9kvhU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR10MB4030
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10150 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 mlxlogscore=947
 bulkscore=0 phishscore=0 mlxscore=0 spamscore=0 adultscore=0
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2110270089
X-Proofpoint-GUID: vkJzeyI5kwAh-EJt2O9nsDqJnLy-YX1V
X-Proofpoint-ORIG-GUID: vkJzeyI5kwAh-EJt2O9nsDqJnLy-YX1V


On 10/27/21 10:08 AM, Oleksandr Andrushchenko wrote:
> Hi, Boris!
>
> On 27.10.21 15:59, Boris Ostrovsky wrote:
>>
>> Can you please rebase this on top of 5.15-rc7? There is a bunch of conflicts due to cae7d81a3730dfe08623f8c1083230c8d0987639.
>>
> I'll try to do that ASAP (what is the deadline for that?)


If you could do in the next few days it would be great. I expect next merge window will open on Sunday.


-boris



From xen-devel-bounces@lists.xenproject.org Wed Oct 27 14:50:03 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Oct 2021 14:50:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217034.376866 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfkFe-0002ts-OR; Wed, 27 Oct 2021 14:50:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217034.376866; Wed, 27 Oct 2021 14:50:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfkFe-0002tY-Js; Wed, 27 Oct 2021 14:50:02 +0000
Received: by outflank-mailman (input) for mailman id 217034;
 Wed, 27 Oct 2021 14:50:01 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=8lYk=PP=epam.com=prvs=0934bd4bd6=oleksandr_andrushchenko@srs-us1.protection.inumbo.net>)
 id 1mfkFd-0002kh-5l
 for xen-devel@lists.xenproject.org; Wed, 27 Oct 2021 14:50:01 +0000
Received: from mx0a-0039f301.pphosted.com (unknown [148.163.133.242])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 42a4ddc0-1870-4506-b56e-5f41931ddfda;
 Wed, 27 Oct 2021 14:49:59 +0000 (UTC)
Received: from pps.filterd (m0174679.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 19RBSMmt021844; 
 Wed, 27 Oct 2021 14:49:58 GMT
Received: from eur02-he1-obe.outbound.protection.outlook.com
 (mail-he1eur02lp2059.outbound.protection.outlook.com [104.47.5.59])
 by mx0a-0039f301.pphosted.com with ESMTP id 3by4ht9euy-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Wed, 27 Oct 2021 14:49:58 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by AM0PR03MB4019.eurprd03.prod.outlook.com (2603:10a6:208:7b::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.16; Wed, 27 Oct
 2021 14:49:55 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::c038:e032:595a:651]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::c038:e032:595a:651%9]) with mapi id 15.20.4649.014; Wed, 27 Oct 2021
 14:49:55 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 42a4ddc0-1870-4506-b56e-5f41931ddfda
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=TBMVlx6Csa81gUspTKxX2wW14bPQQ6XgADWZTLocGI2iwYQAVMSJ4ClvzDEEJVq3ghH/AL65NWT7zBjkDl0G3iiIPwaWvIM0pTaFtLWrbS8Xf0jooN9sSc1Gjg/VFJovsrEFUfqI2RNDz4QXw9HUSwi6SJp5cIGHY+4F2mVVEjiH7p98HSvRP8zSehUTiGi1qzXBJlhOUA3RY0QN5A+IjuFyv2lcUJs4ogDTTxHk+5YZLkfp3qZAqsInr3BvPzazUanG/xdCa9K/hmlx0DaEphHTw3MRz0Vu9Wjs3Fit19Dz2DJ0kAoiCBJnVNQmhnqtEeUWs/XzCfs0ees3tihGAQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=uKCRZI733TaWp+3vG42oP142BKKgodaJONsPpUSr6vU=;
 b=aXO1kz0FYTkQGAOCijJ69D2N+zhB/Ft0vo52v5a3Y7W5lDUfjbt6XOrBqHRBbCKZOwVugnrfdR7rpRN8HOR+1zscH1CHRSXHbHBLLDVxSvXbIHc0luY/8SNe2sDenwmxvB8VegfCcFQIs2XqL8DTqbyEqr18IkZaDIMaCt5TYdZTBohpu7GAmv2DqSB6CX6NGhXtpPt4EfSowzAYCnmfNy75bNx3wWWTE/0EZdVupZSKTD4w5pNFH7CXphmW81Q+7+jkkTkBAt379sdweGIL3UHHdDvJLpSZttt1j/gktTD5WWE87g0skmuI//DSXHDnwFbHDvVTKOC5792Au6tE1w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=uKCRZI733TaWp+3vG42oP142BKKgodaJONsPpUSr6vU=;
 b=d7QD0qwamPXQNvyDEDReTk/10RvN7rFkOI/+JiyTUY7dS0SrkE8dN7fas22VwzyzVqfZZidUqSl9890SsFtku/ssL2yPMt2hvVogpdDM2lvq1XHE93ADOCOBeYST+qDcxMDmiYRncDa5gD4oyZcl+RCvmZxXjohc9SXHdAb9EYgUHkPurBTSxrn4FayCL4goHxjasucOuLFq/N2hBDTyhCtjC8JP2iXBxQbt9lv/ix4Wx4N+2Ppo8WJYF31WGSEu03ZAJF5Ae97Lu8FPDUxScKgAW+NM1WHw+Oywq2nl9Am8SgyT+SOoKJmAbDPNBf+PKppNj9hnIryNlezbeijX4A==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
        "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
CC: "jgross@suse.com" <jgross@suse.com>, "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org" <sstabellini@kernel.org>,
        "jbeulich@suse.com"
	<jbeulich@suse.com>,
        Anastasiia Lukianenko <Anastasiia_Lukianenko@epam.com>
Subject: Re: [PATCH v5] xen-pciback: allow compiling on other archs than x86
Thread-Topic: [PATCH v5] xen-pciback: allow compiling on other archs than x86
Thread-Index: AQHXtDtdCEW9atNFMk2qqaldf5A98Kvm/I6AgAATI4CAAArGAIAAAOAA
Date: Wed, 27 Oct 2021 14:49:54 +0000
Message-ID: <c4efe0b5-89de-aac1-6ec5-5f137fa3b9d4@epam.com>
References: <20210928073501.433559-1-andr2000@gmail.com>
 <71ce7c97-1d08-9fdf-b217-53eb914a29a6@oracle.com>
 <a54ab50a-f35c-26b9-3907-20c014a1120a@epam.com>
 <af42493e-ec31-8673-5532-1f0c8275b2c6@oracle.com>
In-Reply-To: <af42493e-ec31-8673-5532-1f0c8275b2c6@oracle.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 37051162-eebb-40c2-3ef3-08d999590a1d
x-ms-traffictypediagnostic: AM0PR03MB4019:
x-microsoft-antispam-prvs: 
 <AM0PR03MB4019F78BCBB0111488C7D780E7859@AM0PR03MB4019.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:2331;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 OuN55pPMC67MLDM2D8E9MXT3RniJMOJHgrQsmPsAYVuI5cPq1HWnzVXeGjBhCZT1NtMKuldNo0NDpVOtCBp2Ab3KQUhyrcL3FALpObIxlAGvPaqsxCqdrLTQg7+Fdirb8m0xSK1XEyoL0R4wkg8c6TciH4NSmT4lDlinO0VgTAKqpzhFqHXUdzpjhbvP3esXcC1W7Qj+3VNEBY5Kneii7mujLVpbH7FDtu4BpbXZjw5swmOdP6hnXzZVldd9Cw3d9P1W/iItp2ZiFD8iqwHxH+vWpL805+P17mNhmntA8a4cFIaRblzp8hkilMS6j7deqv+ftESehkVV8hEGjuGpEdk//UM+dfFOBMGQal5euReiCc/UizKvL1Od+y2qwwEwqqsNUSO+vw7sc7wmnthbOOLa5CtrQbxWKQBxa3qYZnMr89ItBUdo8Pa0jXS2z0EYCynyNz2WjSrFmIQviJ6+I08g9qLxa5t0/Wxnm7/xQy89/5wEY6hqxHzm21+JcMaiO9oBv7RLxbVR7SqR+i4TGgQzmlW3xOSCb1tl7XneZa2jg1aZepHS6rAVQtGTQoIqxKAdRlW6ZuIe6xkMfL6kozLf00wnXzyqKGsKvx0uNas8E+U/p14Dwl8Hw2Ru9MvG/gAnBI7yz6iPvPFLNsl4WVmGi4cmlH1TzjHHvq0ukccZHpJiWJCPP3otn01W3QTrx5BWy6ii/Ct9aSSoI1x+rdyaCA64aSkLA98Ml4oDawjau+wLcaim15l47axzpQsR
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(4744005)(53546011)(64756008)(86362001)(6506007)(5660300002)(122000001)(66476007)(36756003)(38100700002)(66556008)(4326008)(71200400001)(66946007)(54906003)(26005)(110136005)(66446008)(76116006)(107886003)(31686004)(91956017)(31696002)(508600001)(2906002)(2616005)(186003)(8676002)(6486002)(316002)(38070700005)(6512007)(8936002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?NG9PNVdtUmRxOGNOR1VuNVBwQ1FtNmQ2ZHNiMzJGNGEvNUFvRVR0cnpxNDdL?=
 =?utf-8?B?NWpNWjJ4bU5uWnNNazhRY1pSemY2Y0t2dVNBYk84T0RJcWhVVndHeEZRUFpS?=
 =?utf-8?B?aEIxYkRRZkpYMlE2VjY3bzM5VEF0Z3BORm9LZkUrWlV0UlcxNG0rMW1mT3VP?=
 =?utf-8?B?ZVA4VTFkenZpSG5IU3UvcHloMzQwRDJield3cUhybzJZZ1JiSWJLSy9EZ1hr?=
 =?utf-8?B?eWF2bWM4Q2tiTUROcE95WkQvTy85ZFlSaStJVHlicnZmLzVNSkRGQkFTVDVE?=
 =?utf-8?B?WFQ4VStHRWltd0NyeCsxZURtY3hKNnRYTC9lN25YS05mY0R1ZWxwWWhGVFV5?=
 =?utf-8?B?Vmh6dHcvaUdvV1NNdWdQa0xRL09zZFAwMnRadGVKUFk1N3BPeW96cGZsSnlI?=
 =?utf-8?B?VEorMDlVc1J0ZWVzb0MxakgxSExWVVVmTXhlRnRmWEhBenVDUWtmR0dVSkVz?=
 =?utf-8?B?bnpOenBuZncrWW5FU3VMWVBtRTVncngzRStLREpnV1VHRmdYV3UyeEpEeDhZ?=
 =?utf-8?B?U0prMk5NTkhtajZhWGZmZHRrazh5ZWdSTGt1bGk1enhvTWN3M0gySzJGK2hr?=
 =?utf-8?B?bUxkdjYzbGFJaFpLRzlOaC9HQ2U3U1puK0QwckgrU21HcnYvaXdHTmVhdFZP?=
 =?utf-8?B?REtJSTgrdkIrbHRmYlJpOVFOTEJkZC9xNTMyTEtzK2ZYd3dLVUZKWThJUFZD?=
 =?utf-8?B?S25Nc1BoZWJYOW5HYklqdlIvMzN4YXl1SUxGd21NeUxlRFdTdGlhTG9JdTZI?=
 =?utf-8?B?UUFrYTgyQ0czeDJYbk0ySWdldlI0MzY4d1BvODBFTWFqQ3RTbmR5WlFYOW5j?=
 =?utf-8?B?VmNxL0t6b25Jc2FqQzJtVSt0YzF1c3ZVUFhHRWRKTFFVNGx2VGlvWVRmQjhu?=
 =?utf-8?B?NFdUUDhGN2hLVkprN25XeHBRaWZOYm8vaUVIdG9lV2tkam1nOXk1bGliM0xl?=
 =?utf-8?B?eENYMVZ2SzZ2Y3UzTHAveVJwQXNWeFRPUFZXMzJFclN1V1RXV3FqUUhIMi9n?=
 =?utf-8?B?bzZjQ1FKVnltYURLQVNKMGFzZW94d1VJQ3drWktBL3JMckx1cTRZTTlCOE5q?=
 =?utf-8?B?M3JycGF6NGlmUFNXSmZYUkZnZmIvdmlGSytDOVVmMzBNOXJ5U0d5TWZOSDdM?=
 =?utf-8?B?dWhJdUtWTGtCeGNlRW0yamZYR3QwL3V0MHJyNGdmWWIvZHZ4QWszaUZDMjNY?=
 =?utf-8?B?bkZ2akZpMUE4Y1FCVnBwa1BUZEZlWWpPdjAzZ3pENVJmTWszc2N6emF5cVZV?=
 =?utf-8?B?Y3ovUStTZWw5ckZVdjN4b2grMUJQVEVETnBwS25ldnpWM0UzYTlXQlJvdSs2?=
 =?utf-8?B?d3dXWEI0UjhSa0RtYmpUR0ZKRHpWaG1ibkE5K3NHbUwyakdIdEYwaktLNE9M?=
 =?utf-8?B?TGk4Vmd6NThXK2MrSW1wUUF4NnlRNndRNWg4WHBYVmUxWDVmV2VadzV0QVBZ?=
 =?utf-8?B?Z3p0dkJ5NHYzN1lIQ3VTZG1uNmFsL0Y0UHZ2VEpKWXFOTi9SSkVHcVBqMVhp?=
 =?utf-8?B?c1d6SVVFMEtLZTV6eDVTTlFPNUVYeDN3aXVMOU51dmZvcGtqUjJHRUNxVHAz?=
 =?utf-8?B?RzRIQjlnaG94Z0FyRGRPdUZUeDhMRm10b3JoaE5GblZvdHYremI3N0c0NFlI?=
 =?utf-8?B?UTVnZVdHY0xmdFRLTXVmUzBsS1I0U2dqZVp2VGlpczg5U0dIZS93dyt4bXEr?=
 =?utf-8?B?YjVLc1phSEZDbnp4WnV4Vk5ZNk5UWXV3akppR1hlbndqc3dPYjVlbjRWMXBS?=
 =?utf-8?B?ZEpLTEE5cGVJQTdqVzZiV3AzZ2h4dWYzbm9Qb01USVFzVjUwS0JVWnhJNXBG?=
 =?utf-8?B?L3BvWGc3SXhQNy85b2tIeHZPaEdjalBUMFBuSXEzWGQyMXBOTSt5clp1YmJF?=
 =?utf-8?B?WElHZG1rZFdweU82RXJHcDM3WjIyQ3VOOVJDTWRUU3ZEU29BakVNalVnOVp6?=
 =?utf-8?B?NStXbHVBVFE5MkZWR0pzZlFGZ2dOSGovNzFidU1xVGpoUjZ0bkY0Z1N2akVF?=
 =?utf-8?B?a1hxNFdlcFhEc3ZyUHpwMERycGxPSUZVT1prTDBJb0gyQWdoaU8xM2YrRjZh?=
 =?utf-8?B?SXMxNlpzWEdSdi9lZ0g4bWxpMEM1ZUdLRDk5OWROQ2lzWENRWFd2SnZMdm5h?=
 =?utf-8?B?TGJYdUxkL0FxaERwZnJQL2xiUUVLbW5PeHJqVjd6ZXNTdU53cVordGdTaS8w?=
 =?utf-8?B?bVFIVG1ycE5BMWU2QkszaUx1QW5vWHRoQmE0UEdXaFo0SzAweUlIYXhWV2w0?=
 =?utf-8?B?YVo4M0p3dm5VanBxdTZ5UGJMaFR2aEtqVnp4Q09HcTBudUpBRCtkYnc5eUhq?=
 =?utf-8?B?NzRSQVcvMzRZL1VjR0o1aVViRm1WKy9zZjZQOUpwcDNlZzFhNk0yUT09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <BD1825029B228A4DBD83AA8A8D2AABFE@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 37051162-eebb-40c2-3ef3-08d999590a1d
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Oct 2021 14:49:54.9617
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: CQ4NEgit0tTWutaYSsfoqMwWVSJsFMJPYaWPQ/ve9L9N5R3YYymVNnIJbLTruStksy9rluPWNryDNMh1tSghwEfSY2Yu7POdHdxMcUlM2ms0C6giRNmn5nMrcPnZHb28
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR03MB4019
X-Proofpoint-ORIG-GUID: UDjy5fVWp9j5P5bKqyOJ4dorSncNx4ke
X-Proofpoint-GUID: UDjy5fVWp9j5P5bKqyOJ4dorSncNx4ke
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475
 definitions=2021-10-27_04,2021-10-26_01,2020-04-07_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 malwarescore=0
 mlxscore=0 mlxlogscore=851 priorityscore=1501 phishscore=0 suspectscore=0
 adultscore=0 impostorscore=0 spamscore=0 lowpriorityscore=0 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2110270089

DQoNCk9uIDI3LjEwLjIxIDE3OjQ2LCBCb3JpcyBPc3Ryb3Zza3kgd3JvdGU6DQo+DQo+IE9uIDEw
LzI3LzIxIDEwOjA4IEFNLCBPbGVrc2FuZHIgQW5kcnVzaGNoZW5rbyB3cm90ZToNCj4+IEhpLCBC
b3JpcyENCj4+DQo+PiBPbiAyNy4xMC4yMSAxNTo1OSwgQm9yaXMgT3N0cm92c2t5IHdyb3RlOg0K
Pj4+DQo+Pj4gQ2FuIHlvdSBwbGVhc2UgcmViYXNlIHRoaXMgb24gdG9wIG9mIDUuMTUtcmM3PyBU
aGVyZSBpcyBhIGJ1bmNoIG9mIGNvbmZsaWN0cyBkdWUgdG8gY2FlN2Q4MWEzNzMwZGZlMDg2MjNm
OGMxMDgzMjMwYzhkMDk4NzYzOS4NCj4+Pg0KPj4gSSdsbCB0cnkgdG8gZG8gdGhhdCBBU0FQICh3
aGF0IGlzIHRoZSBkZWFkbGluZSBmb3IgdGhhdD8pDQo+DQo+DQo+IElmIHlvdSBjb3VsZCBkbyBp
biB0aGUgbmV4dCBmZXcgZGF5cyBpdCB3b3VsZCBiZSBncmVhdC4gSSBleHBlY3QgbmV4dCBtZXJn
ZSB3aW5kb3cgd2lsbCBvcGVuIG9uIFN1bmRheS4NClN1cmUsIEknbGwgdHJ5IHRvIHNlbmQgaXQg
dG9tb3Jyb3cuDQpJIGFzc3VtZSBJIGNhbiBrZWVwIFItYidzIGFmdGVyIHRoZSByZWJhc2UgKHRo
aXMgaXMgZ29pbmcgdG8gYmUgdjYgb2YgdGhlIHBhdGNoKT8NCj4NCj4NCj4gLWJvcmlzDQo+DQo=


From xen-devel-bounces@lists.xenproject.org Wed Oct 27 15:11:56 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Oct 2021 15:11:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217049.376876 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfkaH-00061y-Jm; Wed, 27 Oct 2021 15:11:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217049.376876; Wed, 27 Oct 2021 15:11:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfkaH-00061r-Gu; Wed, 27 Oct 2021 15:11:21 +0000
Received: by outflank-mailman (input) for mailman id 217049;
 Wed, 27 Oct 2021 15:11:20 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=uMsA=PP=citrix.com=Andrew.Cooper3@srs-us1.protection.inumbo.net>)
 id 1mfkaG-00061l-6v
 for xen-devel@lists.xenproject.org; Wed, 27 Oct 2021 15:11:20 +0000
Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 22885f0c-3738-11ec-8474-12813bfff9fa;
 Wed, 27 Oct 2021 15:11:18 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 22885f0c-3738-11ec-8474-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1635347478;
  h=subject:to:cc:references:from:message-id:date:
   in-reply-to:content-transfer-encoding:mime-version;
  bh=d+zYVzVzpCvYkJ9HsTezrHeiK+Jj4ut/Tkule/dGkvQ=;
  b=GGsxbsVQyrKTd6HTgxhqkDk8Dx+mF/ZPhmJsHnwKzV8SqDxdfLOZCtY2
   cU/+tMQlFY19F4oDVU3LN/4mJ4CQ4ulGm7UDUeKV9NsJdyAGTfW0qKMwM
   ZIaId0ag+xDSW24oZnP7eDETpcwqfMWxDoRtTBarw5GEJUxneFzst4m5d
   E=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: vIBzT9eAxsPzK4Sb0DGFee0i9i7uKaISFbcLtD0mQD1cKOp5CBNFWLIo6WsLJEIyD8GTjwVqC6
 L+n7PaItzjbq90gkOqq7zhQbgHXso8Mik+NiDxnIwJ9GJI9rJnMwrht3uilgoQ7WJwXfqcUtKT
 UFkc2rSuhvf9Dmugz1h6RmWzpVRkvVuD+FYaHW+R75V9MB+v8C9/64dL94m9RV7z6fJG5qmtuB
 UVnSs19bID2nYgjav7BZ5RhLEthQYpsgcFOV5g0U6GUkEGuP5rm2PHY7pGA9r/vx/zDRcLJXVP
 yH02xRE7/AJocOBk1lhK3SCS
X-SBRS: 5.1
X-MesageID: 56398759
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:kCFxaKo6P53idgIJ0l7K2U8CWnVeBmLlYhIvgKrLsJaIsI4StFCzt
 garIBnUO6vfN2Ghe9sla4XipEtUvpSAyt8ySgM+rSlnFH8Q95uZCYyVIHmrMnLJJKUvbq7GA
 +byyDXkBJppJpMJjk71atANlZT4vE2xbuKU5NTsY0idfic5Dnd+4f5fs7Rh2Ncx2YLmW1nlV
 e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL
 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9
 DlCncagVx1qI/bJo+QUciVHPgFVPLwb8bCSdBBTseTLp6HHW37lwvEoB0AqJ4wIvO1wBAmi9
 9RBdmpLNErawbvrnvTrEYGAhex6RCXvFKoZtmtt0nfyCvE+TIqYa67L+cVZzHE7gcUm8fP2O
 pRCOGowMUWojxtnCwwdJIozzM6UuyP7VBBm60CKmKU97D2GpOB2+Oe0a4eEEjCQfu1XlEuFo
 mPN/0ziHwoXcteYzFKt4n+qw+PCgy7/cIYTD6GjsO5nhkWJwW4eAwFQUkG0ydG4lUyWS99ZM
 1YT+Cclse417kPDZsb5dw21pjiDpBF0ZjZLO7RkskfXkPOSulvHQDhfJtJcVDA4nJUmWyZpy
 wSMpNPgJABwnZ2+SGPA/7jB+FteJhMpBWMFYCYFSy4M7N/ivJw/g3rzczpzLEKmpoaqQW+ok
 lhmuAB73u9J1ZdaiM1X6Hie22r0zqUlWDLZ8ek+soiN1Qh+eJK+L7Kh7VzW/J6sx67IEwHf4
 hDodyWYhd3i7K1hdgTRH43h/5nzvp5p1QEwZ3Y1R/HNEBz2ohaekXh4um0WGauQGp9slcXVS
 EHSoxhNw5RYIWGna6R6C6roVZ93l/e7RY69D6iJBjarXnSXXFXflM2JTRXJt10BbWB2yf1vU
 XtlWZ/0ZZrlNUiX5GXvHLpMuVPa7is/2XnSVfjGI+ePitKjiIquYe5dajOmN7lhhIvd+Vm92
 4sPZqOilkQEOMWjM3a/zGLmBQ1TRZTNLcut8JI/my/qClcOJVzN/NeLnux4K90/xv0E/goKl
 1nkMnJlJJPErSSvAS2Ba2x5aaOpWpB6rHkhOjcrM0ru0H8mCbtDJo9CH3fuVbV4puFl09BuS
 PwJJ5eJDvhVE2yV8DUBd5jt6odlcU3z1w6JOiOkZhk5foJhGFOVqoO1IFO3+XlcFDezuOs/v
 6akilHRT60cSlkwF83Rcv+ukQ+85CBPhOJoUkLUCdBPY0GwopNyIin8g6ZvccEBIBnO3BWA0
 AOSDUtKrOXBudZtotLImbqFv8GiFO4nRhhWGGzS7LCXMyjG/zX8nd8cAbjQJT2EDTH64qSvY
 +lR3srQCvxfkQYYqZd4HpZq0bk6u4nlqYhFw1k2B37MdVmqVO9teyHUwclVu6RR7bZFog/qC
 FmX89xXNLjVasPoFFkdeFgsYuiZjKxGnzDT6bI+IVng5T8x972CCB0AMx6JgS1bDb10LIJ6n
 rtx5J9Is1Sy2kgwL9KLriFI7GDdfHUPXpIuuoweHIK22BEgzUtPYMCEByL7iH1Vhw6g7qX+z
 ueouZf/
IronPort-HdrOrdr: A9a23:fjX11K4thez/8JrAkQPXwViBI+orL9Y04lQ7vn2ZFiY7TiXIra
 yTdaoguCMc6AxxZJkh8erwXJVoMkmsiqKdhrNhQYtKPTOWxVdASbsN0WKM+UyZJ8STzJ866U
 4kSdkFNDSSNykLsS+Z2njALz9I+rDum8rJ9ISuvEuFDzsaDJ2Ihz0JezpzeXcGJjWua6BJca
 Z0qvA33AZJLh8sH7qG7zQ+LqX+juyOsKijTQ8NBhYh5gXLpTS06ITiGxzd+hsFSTtAzZor7G
 CAymXCl+qemsD+7iWZ+37Y7pxQltek4txfBPaUgsxQDjn3kA6naKloRrXHljEop+OE7kosjb
 D30lsdFvU2z0mUUnC+oBPr1QWl+DEy60X6wVvdunfnqdyRfkNzN+NxwaZiNjfJ4Uspu99xlI
 hR2XiCipZRBRTc2Azg+tnhTXhR5wqJiEtntdRWo21UUIMYZrMUh5cY5llpHJAJGz+/wJw7Ed
 NpENrX6J9tABKnhkjizytSKeGXLzEO9k/seDlHhiXV6UkZoJlB9Tpa+CRF9U1ws67USPF/lq
 352+pT5fdzp/QtHNdA7dE6ML2K41z2MGDx2V2pUCDa/YE8SjnwQs3Mkf8IDN/DQu1+8HJ1ou
 WZbG9l
X-IronPort-AV: E=Sophos;i="5.87,187,1631592000"; 
   d="scan'208";a="56398759"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=V1imqS5mt4yI9d7ZUzmYBElUvAofxUQDErwE5k8NdNmeeCLlmZo+tF0NIOWqQB9RJCzmSc+/MJfYGKVOcpuHZvaJMFCOLf2voNh1OUpKmHN68gKrHo7g4s8+quAzypw84z5Mz/goxQAOAr5nUPoRrK4dl1Y+3c0ntr18Cmgs90F5h1V9QuEfsAXOGatsz9rOq08wMUVf2L058gJWSjI+uSirUIgcDGN1YEpCtGP/ZvT8XKdy/JjGik8o4lth9BeRkv3cotesMxISgfNBFiP8b1vw5LOZ9Vgt3OS45Qq/aT06m9mQ0vk1qw1u79gbsVCv20udZO6bEp83JWD8dVt7Yg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ia2GqD4k/yLn9puVehXGjmi3W3/nGkAK14/JGRToq4g=;
 b=egv/Et2je9KDXBZLrItOr/Q8sH9B19Ma40QbkSuJqUhLhOEB+GhEUriVRytxdcP7rD3K88B0q9qv/an9/JKBfjFTv3xzIEXu4mN+RsrP6JPpZaP/pw3eMVVVZRfsMQWziNaafuXa7MtP/jUm68Hybt8YowxVWqdDMhuUeZYxK2C6vbjVgSSqxAZcK3W/PE6fTODVOtaYMAXEsiMVipIfMpHUPwyouqXX6Uu7bWl57zbVfEwcZzzubg1XAaDGY+TCeP/tKsar8XktidCM7NtlMh3pOkFxAL8dzyg1flb/Vjfhxh/94AT9yd+txIkdqhHrp2ZAqhyF8HM+WrZXhys8IQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ia2GqD4k/yLn9puVehXGjmi3W3/nGkAK14/JGRToq4g=;
 b=rQoN6iRSusuD005f1YMmTUMGvl/UXJXW5samftI9sYaHXW28pVOu1CyYctyu0q0eop4LPyvoqntxQTW7lUqVWDXb3rL+uFolNezT3Wg9y5SvytP1IU/1AzwSaf7Tis9TOzHgHxVM37pis2nnISmqJrtSuUdZ2MHM3hZbWpoPpfM=
Subject: Re: [PATCH] x86/cpuid: prevent decreasing of hypervisor max leaf on
 migration
To: Roger Pau Monne <roger.pau@citrix.com>, <xen-devel@lists.xenproject.org>
CC: Jan Beulich <jbeulich@suse.com>, Wei Liu <wl@xen.org>, Ian Jackson
	<iwj@xenproject.org>
References: <20211027140050.67509-1-roger.pau@citrix.com>
From: Andrew Cooper <andrew.cooper3@citrix.com>
Message-ID: <43570e20-d8c7-9bb3-1a98-594ca7b528d1@citrix.com>
Date: Wed, 27 Oct 2021 16:11:04 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <20211027140050.67509-1-roger.pau@citrix.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Content-Language: en-GB
X-ClientProxiedBy: LO4P123CA0119.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:192::16) To BYAPR03MB3623.namprd03.prod.outlook.com
 (2603:10b6:a02:aa::12)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: ca3ab3cd-1711-42b5-30c4-08d9995c01ea
X-MS-TrafficTypeDiagnostic: BY5PR03MB5345:
X-Microsoft-Antispam-PRVS: <BY5PR03MB5345A91551CC681A449E01F3BA859@BY5PR03MB5345.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:3631;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: I4noxWwz4ppv5MhmVxKHjxibsY71p54OaafnelLm3QsqwcwjMiIEDf/BI+UFMudxSVkDfWuvcauxm8AJSUsgzFjMi8jV1peLxgtOLnHPQBAvkX7NJdr18e5QbH3Uk/pey7fib5UBgngY3tTyK0gDKxE0wmQpPijit9O7NdnDgyG0PIbS5X2Fy1qeGRCo0H9S77WpCeT8/2LZhXB7c32pjwAfm3LfT2o5k9i+qmpUw/qNajdXlBMxy8uo24CQ/xAvu+NTCLmHYPsrMBu0ouiP7Ybw8wilYdDs8GSwX5MhQIzEBVIo1lPeDWVR+bIkcc7qg1u/AkptWqmIqhWyogvh5G5SxLOuVXIGHyrnLRJ+Pt/4n3LTmrly7vOWyw5Pe+DYB0/PbT1NBbXLxaShKsqbXxfFa7uynzwJ4RGBQvDAUs40hbFwVBxdfMPI6nQq/vpBwvzAm7lS3hFmJ9Cf2CXpHiuvEKE277QvRmMWJype2U+1/rt5c91YO2nnv3ppvbsSHMXOQ1ecpZ2VanQi6uYt/XbKSDjyfAR1WGkKpkJE9y27TNW36Ie3y0sO53Iv+JmmyW8UMQ24hWlFJu1aEKD18ttR5XyGecwpzH4LQcDp4sQ4lLDtGaPSgQsaPB1v1FZY9s/mf0LGDqqxlLRRgbxDaWrj0viKjMqZH21SAS+eX1N9BT58g6V7vhHHiIiiGwLZpE9UPBQoacUDMnuZhJ6c1V9xCROLLGSVTUB0sah6Zih2HVrwgTjT7Q7Gl+PKtqoX
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(53546011)(316002)(26005)(31686004)(66946007)(66556008)(36756003)(66476007)(508600001)(6486002)(86362001)(5660300002)(16576012)(8676002)(8936002)(54906003)(4326008)(956004)(83380400001)(186003)(31696002)(2906002)(2616005)(82960400001)(38100700002)(6666004)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dW9xTS84YkI0Nk5mSG8yVXFSNitHalp4Snh6YmJ2NVlwc2p2dWk3K1lYQlA2?=
 =?utf-8?B?aE8xTEVHeGxPaWh1ZThwejhGcDY3UnBON2I2bDBlUnlSajM3cVhjRlVaOG9m?=
 =?utf-8?B?SDdLWEdyN2RpakVua2dZdGZvWWJvVlFadGNPb2o2dWdVamJxKzF3Wko1QzBU?=
 =?utf-8?B?c015cmJqUjYrdDlocWtkZUtUSE56anFnZzQzOUNqNXZ4TDlyeVh6OVJ6ZDVT?=
 =?utf-8?B?OWhNVWlkdnRyMG94U3doWFFOME5TWTVZcjRhbFVJTlJJZ3o3Yi9xb0hDWG5P?=
 =?utf-8?B?OTcrOG5SVHRzVmZCZ0E4TXpNWFlGaDVVODVIWGpkMHdBRWNtWGxPRk1xTGp3?=
 =?utf-8?B?SFViQUw5ZG40M1pGMDJkakQzekhZd1JEMnlVVmJja2ZXUU10R0F4UGRVZWJq?=
 =?utf-8?B?Qk5OWFhWVkptRDNBa0NFNjhJb0VRNStwWVNRZzI2YVFQUHNDbEdHazdHOTZt?=
 =?utf-8?B?Rk93UWNwNDhLczFHTENGVktLOFJkSWVwb2R1QjBMc0NBTmpTaGt1STM5R3Fq?=
 =?utf-8?B?L2ZXc1lDR0Jnd3RmbjRIRTAyWm80T0xJNjA4blVPVTNCUGVwVlovM2d3eGpx?=
 =?utf-8?B?R0VRTXNhYThxUTdseUxyeTlRUk1mNWx0SVBpeFU0cFk5Wjh6R0JxU0FBU1pE?=
 =?utf-8?B?cnJMWkRMY1dFYnkxOG1vdFptWE9aaEJmMGc5ZnBXSnZEZWsxL2xwcXYzaGxY?=
 =?utf-8?B?RXJ4S2N3Ti9qaklzQTRrcG5LS3ozdnk0WVRYdjRwMk84a3RXZTZ6Qm02LzdT?=
 =?utf-8?B?YjJlVlRrTWp1Ly80VWIxdk1yVUx2UHRpbnFodW54TGszVjVUZUNnbG1kTWtC?=
 =?utf-8?B?SGQ5MCtSSUlzdjNUZEZGLzJyZzI3S3djY08wVkpRV2NPcUQvbm1MQXRmREFM?=
 =?utf-8?B?OUJzOUp2SUxwdVN5MWhDUW9VQzNNMWtuNlh2bmtHbk4xWUFmMHlEelJjSlJL?=
 =?utf-8?B?OS96NkxOQW5HWUZRaHg1YU9PTmRwN25leFhjQTAwVFdkY3BTN05wNUtCQWlC?=
 =?utf-8?B?QjF3R2tmT1crb3FBcnNJT3FuaTNCT3UwTERCZDhzSTVoVHl4LzVPMlFaekt3?=
 =?utf-8?B?TXhreVAyMGhUZitmSXRaQUdSdS90YVpOTm9wVmNZU1M2eFk4M2NzeWRZcExm?=
 =?utf-8?B?cnkzK0RXZHZKVmIySUpQVGI2ZEt2OTcwSGZwR3p2TGtkOEttQVh0WnhxRllW?=
 =?utf-8?B?QjBwaUFzWmtqaDFOZXcwanZ0TDVFWVFHbHkzNkx0YmdkWmkyUmxBcUdwQmsy?=
 =?utf-8?B?Snh1VHRPT3RQa3dnbmc5L0RXa3VXR0NCMURiYi9JZGhiUC9ZclJGNGVpcU5J?=
 =?utf-8?B?K2xNblJ0MGVTMjRPWDFYdllvMndpM3FqMTluK3dQWmwyV2twNTlJRVllNy9i?=
 =?utf-8?B?TFlnam8rSW94dDdDTGFUTkNtYUJQMUhXQ3hzVGtLa0FlZnpuM1ZEOTZiUUhr?=
 =?utf-8?B?VnJqWEpkT2tabEJSdnlxa05qUkg2NE50SGIvbm00MHIxOE5rK0FCbnRDYlBS?=
 =?utf-8?B?bWNjc1dWZ0ZzbWQraEZmaSt3TVpJVDVPREtZS3RiZityM2plUldiVWFoMm53?=
 =?utf-8?B?ck55MU01MG9NU3VyNWxjdGEvQ2xQS1hlc2JKZzlLUGNzOVBkNjd3TGFxNm04?=
 =?utf-8?B?WXhBQng5NjU2ZTByNjlkU0xDS3AyRGhjT1lrbnRNVGNDTzVzQWNVWTRkWUxP?=
 =?utf-8?B?TG8waDFQQXlQcnFDS0JZcWp4a3R1SExaNDBlOThUMFJWZzQ0M3NJVlpUbUlN?=
 =?utf-8?B?THNtODVWamF3d3JuS0dxTHRVZWdHbGhhUXhNNUpheXlHUXU1RWNiOU5hUFdF?=
 =?utf-8?B?QzRrYXo1VThxeGVwZ1dqbEkveEdRSmhaME1la3lhMnYrdmNUM21WWnkvbHNo?=
 =?utf-8?B?bDQ0REV2VVdtS3NOczd0aC80ckdCcW1jVGV2b3lrbDI3Z1JnWWJvRmZLSDBO?=
 =?utf-8?B?dTZKK3JsMUJEb2s4aktuZEdZanRVdTh4VGJ4MC9ucU0yRXk1TWhuUklnakEw?=
 =?utf-8?B?NW8wMFdycy9sNUdoTlJQM0JmZTV6WWpZQTkrMDUyNmg4cEtnOHFaMjg4c1hS?=
 =?utf-8?B?VklzQmc2YXo5ZlNUZlUvWG9ZVGF3bmVBZTZxak8xeVEwVTArT0ZSQzEzQmR5?=
 =?utf-8?B?VXBRWXN6THF3VGk0aTBDdTdpUFZhY3Zua081ZUo2ZmFLc2wzZE9FcE43Q2Fw?=
 =?utf-8?B?U3J5bmpVZithVUdoaGppUDFrZGlzc3hTaTEyUnlYdm9PKzlvSWpEa0xtTWxa?=
 =?utf-8?B?Szc5dWQ4bDExMDg3Nk1jUjBFeXlRPT0=?=
X-MS-Exchange-CrossTenant-Network-Message-Id: ca3ab3cd-1711-42b5-30c4-08d9995c01ea
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Oct 2021 15:11:10.1169
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2V0t8h6oF1bykGS+B+fLfMz623713o6AEj0+zODzzseeQIGUCJa2mlUyY2nPCn9dKoKaeoHCgAktStWDgivdMQDMXXljT1QtO6XlNYV4zPM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR03MB5345
X-OriginatorOrg: citrix.com

On 27/10/2021 15:00, Roger Pau Monne wrote:
> In order to be compatible with previous Xen versions, and not change
> max hypervisor leaf as a result of a migration, keep the clamping of
> the maximum leaf value provided to XEN_CPUID_MAX_NUM_LEAVES, instead
> of doing it based on the domain type. Also set the default maximum
> leaf without taking the domain type into account. The maximum
> hypervisor leaf is not migrated, so we need the default to not regress
> beyond what might already be reported to a guest by existing Xen
> versions.
>
> This is a partial revert of 540d911c28 and restores the previous
> behaviour and assures that HVM guests won't see it's maximum
> hypervisor leaf reduced from 5 to 4 as a result of a migration.
>
> Fixes: 540d911c28 ('x86/CPUID: shrink max_{,sub}leaf fields according to actual leaf contents')
> Reported-by: Andrew Cooper <andrew.cooper3@citrix.com>
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>

Thanks.

Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>

> ---
> Cc: Ian Jackson <iwj@xenproject.org>
> ---
> Regarding release risks:
>
> This is a partial revert of a commit.  The main issues could be that a
> partial revert could break the build or leave the remaining code in a
> non-working condition.
>
> Breaking the build will be easily discovered by our automated testing,
> while leaving the remaining code in a broken state is unlikely, as the
> chunks reverted are isolated from the rest of the change in
> 540d911c28.

This fixes a regression vs 4.15.  Furthermore, the changes to the
hypervisor leaves don't even interact with the rest of the patch.

Failure to compile is about the only risk, and this is easy to prove one
way or another.

~Andrew



From xen-devel-bounces@lists.xenproject.org Wed Oct 27 15:19:45 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Oct 2021 15:19:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217056.376887 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfkiG-0006lp-CR; Wed, 27 Oct 2021 15:19:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217056.376887; Wed, 27 Oct 2021 15:19:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfkiG-0006li-9M; Wed, 27 Oct 2021 15:19:36 +0000
Received: by outflank-mailman (input) for mailman id 217056;
 Wed, 27 Oct 2021 15:19:35 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mfkiF-0006lV-0Y; Wed, 27 Oct 2021 15:19:35 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mfkiE-0006Fb-RU; Wed, 27 Oct 2021 15:19:34 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mfkiE-0007Ef-IP; Wed, 27 Oct 2021 15:19:34 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mfkiE-0005ly-Hu; Wed, 27 Oct 2021 15:19:34 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=w0TRgnjxQ9wZodE23FuDDloezv8i4iiJNfpJqsq6pCM=; b=hzg6KESzreBZu8nA9fgoNpk1db
	mdOWd1SZ+UBs8uQ9By0mCaQ9UsxQZtaP7JXlS2Jopxh+rErG5FBK393+nKi8gfVxoS+bY5hNzJe2x
	OXdSCxT0OVhNGxZL90d2mehBNUBPjFIJnJhRxrf4B4BPWBVCQ+Tbz2gkC4RCSYF9w6j8=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165889-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 165889: regressions - FAIL
X-Osstest-Failures:
    qemu-mainline:build-i386:xen-build:fail:regression
    qemu-mainline:build-i386-xsm:xen-build:fail:regression
    qemu-mainline:build-armhf:xen-build:fail:regression
    qemu-mainline:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-amd:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-pair:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-freebsd10-i386:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-freebsd10-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-coresched-i386-xl:build-check(1):blocked:nonblocking
    qemu-mainline:build-armhf-libvirt:build-check(1):blocked:nonblocking
    qemu-mainline:build-i386-libvirt:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-intel:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-shadow:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-vhd:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=931ce30859176f0f7daac6bac255dae5eb21284e
X-Osstest-Versions-That:
    qemuu=50352cce138ef3b30c1cda28a4df68fff5da3202
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 27 Oct 2021 15:19:34 +0000

flight 165889 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165889/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-i386                    6 xen-build                fail REGR. vs. 165682
 build-i386-xsm                6 xen-build                fail REGR. vs. 165682
 build-armhf                   6 xen-build                fail REGR. vs. 165682

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl           1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-credit2   1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-cubietruck  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-multivcpu  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-rtds      1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-vhd       1 build-check(1)               blocked  n/a
 test-amd64-i386-qemuu-rhel6hvm-amd  1 build-check(1)               blocked n/a
 test-amd64-i386-pair          1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-freebsd10-i386  1 build-check(1)               blocked  n/a
 test-amd64-i386-freebsd10-amd64  1 build-check(1)               blocked  n/a
 test-amd64-coresched-i386-xl  1 build-check(1)               blocked  n/a
 build-armhf-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-arndale   1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-credit1   1 build-check(1)               blocked  n/a
 test-amd64-i386-qemuu-rhel6hvm-intel  1 build-check(1)             blocked n/a
 test-amd64-i386-xl            1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-pvshim     1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-qemuu-debianhvm-amd64  1 build-check(1)         blocked n/a
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow  1 build-check(1)  blocked n/a
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm  1 build-check(1)      blocked n/a
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 1 build-check(1) blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a
 test-amd64-i386-xl-qemuu-win7-amd64  1 build-check(1)              blocked n/a
 test-amd64-i386-xl-qemuu-ws16-amd64  1 build-check(1)              blocked n/a
 test-amd64-i386-xl-shadow     1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-vhd        1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-xsm        1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165682
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165682
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165682
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 qemuu                931ce30859176f0f7daac6bac255dae5eb21284e
baseline version:
 qemuu                50352cce138ef3b30c1cda28a4df68fff5da3202

Last test of basis   165682  2021-10-19 21:09:14 Z    7 days
Failing since        165694  2021-10-20 18:09:12 Z    6 days   16 attempts
Testing same since   165883  2021-10-26 21:38:10 Z    0 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
  Alistair Francis <alistair.francis@wdc.com>
  Andrew Jones <drjones@redhat.com>
  Ani Sinha <ani@anisinha.ca>
  BALATON Zoltan <balaton@eik.bme.hu>
  Bin Meng <bmeng.cn@gmail.com>
  Cédric Le Goater <clg@kaod.org>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  David Gibson <david@gibson.dropbear.id.au>
  David Hildenbrand <david@redhat.com>
  Dr. David Alan Gilbert <dgilbert@redhat.com>
  Eric Auger <eric.auger@redhat.com>
  Eugenio Pérez <eperezma@redhat.com>
  Frank Chang <frank.chang@sifive.com>
  Gavin Shan <gshan@redhat.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Greg Kurz <groug@kaod.org>
  Gustavo Romero <gromero@linux.ibm.com>
  Igor Mammedov <imammedo@redhat.com>
  Jason Wang <jasowang@redhat.com>
  John Wang <wangzhiqiang02@inspur.com>
  John Wang <wangzq.jn@gmail.com>
  Laurent Vivier <laurent@vivier.eu>
  Laurent Vivier <lvivier@redhat.com>
  Luc Michel <lmichel@kalray.eu>
  Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
  Matheus Ferst <matheus.ferst@eldorado.org.br>
  Mathieu Poirier <mathieu.poirier@linaro.org>
  Michael S. Tsirkin <mst@redhat.com>
  Mingwang Li <limingwang@huawei.com>
  Oğuz Ersen <oguzersen@protonmail.com>
  Philipp Tomsich <philipp.tomsich@vrull.eu>
  Philippe Mathieu-Daudé <f4bug@amsat.org>
  Philippe Mathieu-Daudé <philmd@redhat.com>
  Richard Henderson <richard.henderson@linaro.org>
  Shuuichirou Ishii <ishii.shuuichir@fujitsu.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Thomas Huth <thuth@redhat.com>
  Tong Ho <tong.ho@xilinx.com>
  Travis Geiselbrecht <travisg@gmail.com>
  Vincent Palatin <vpalatin@rivosinc.com>
  Vivek Goyal <vgoyal@redhat.com>
  Xueming Li <xuemingl@nvidia.com>
  Yanan Wang <wangyanan55@huawei.com>
  Yifei Jiang <jiangyifei@huawei.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               fail    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          blocked 
 test-amd64-i386-xl                                           blocked 
 test-amd64-coresched-i386-xl                                 blocked 
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  blocked 
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       blocked 
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           blocked 
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     blocked 
 test-amd64-i386-freebsd10-amd64                              blocked 
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          blocked 
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          blocked 
 test-armhf-armhf-xl-arndale                                  blocked 
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  blocked 
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  blocked 
 test-armhf-armhf-xl-cubietruck                               blocked 
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         blocked 
 test-amd64-i386-freebsd10-i386                               blocked 
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         blocked 
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                blocked 
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         blocked 
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 blocked 
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    blocked 
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     blocked 
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              blocked 
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    blocked 
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      blocked 
 test-amd64-i386-xl-vhd                                       blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 3749 lines long.)


From xen-devel-bounces@lists.xenproject.org Wed Oct 27 15:29:46 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Oct 2021 15:29:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217066.376902 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfkrs-0008LD-Ha; Wed, 27 Oct 2021 15:29:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217066.376902; Wed, 27 Oct 2021 15:29:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfkrs-0008L6-DV; Wed, 27 Oct 2021 15:29:32 +0000
Received: by outflank-mailman (input) for mailman id 217066;
 Wed, 27 Oct 2021 15:29:30 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=EkRf=PP=oderland.se=josef@srs-us1.protection.inumbo.net>)
 id 1mfkrq-0008Kx-Ml
 for xen-devel@lists.xenproject.org; Wed, 27 Oct 2021 15:29:30 +0000
Received: from office.oderland.com (unknown [91.201.60.5])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id a95564fa-b781-4028-b31f-8464dbacc59b;
 Wed, 27 Oct 2021 15:29:27 +0000 (UTC)
Received: from [193.180.18.161] (port=35520 helo=[10.137.0.14])
 by office.oderland.com with esmtpsa (TLS1.2) tls
 TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2)
 (envelope-from <josef@oderland.se>)
 id 1mfkrl-000gBN-MF; Wed, 27 Oct 2021 17:29:25 +0200
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a95564fa-b781-4028-b31f-8464dbacc59b
Message-ID: <5b3d4653-0cdf-e098-0a4a-3c5c3ae3977b@oderland.se>
Date: Wed, 27 Oct 2021 17:29:22 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:93.0) Gecko/20100101
 Thunderbird/93.0
Content-Language: en-US
From: Josef Johansson <josef@oderland.se>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: boris.ostrovsky@oracle.com, helgaas@kernel.org, jgross@suse.com,
 linux-pci@vger.kernel.org, maz@kernel.org, xen-devel@lists.xenproject.org,
 Jason Andryuk <jandryuk@gmail.com>, David Woodhouse <dwmw2@infradead.org>
References: <90277228-cf14-0cfa-c95e-d42e7d533353@oderland.se>
 <20211025012503.33172-1-jandryuk@gmail.com> <87fssmg8k4.ffs@tglx>
 <87cznqg5k8.ffs@tglx> <d1cc20aa-5c5c-6c7b-2e5d-bc31362ad891@oderland.se>
 <89d6c2f4-4d00-972f-e434-cb1839e78598@oderland.se>
Subject: Re: [PATCH] PCI/MSI: Move non-mask check back into low level
 accessors
In-Reply-To: <89d6c2f4-4d00-972f-e434-cb1839e78598@oderland.se>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-AntiAbuse: This header was added to track abuse, please include it with any abuse report
X-AntiAbuse: Primary Hostname - office.oderland.com
X-AntiAbuse: Original Domain - lists.xenproject.org
X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12]
X-AntiAbuse: Sender Address Domain - oderland.se
X-Get-Message-Sender-Via: office.oderland.com: authenticated_id: josjoh@oderland.se
X-Authenticated-Sender: office.oderland.com: josjoh@oderland.se

On 10/27/21 14:01, Josef Johansson wrote:
> On 10/27/21 11:54, Josef Johansson wrote:
>> On 10/27/21 11:50, Thomas Gleixner wrote:
>>> The recent rework of PCI/MSI[X] masking moved the non-mask checks from the
>>> low level accessors into the higher level mask/unmask functions.
>>>
>>> This missed the fact that these accessors can be invoked from other places
>>> as well. The missing checks break XEN-PV which sets pci_msi_ignore_mask and
>>> also violates the virtual MSIX and the msi_attrib.maskbit protections.
>>>
>>> Instead of sprinkling checks all over the place, lift them back into the
>>> low level accessor functions. To avoid checking three different conditions
>>> combine them into one property of msi_desc::msi_attrib.
>>>
>>> Reported-by: Josef Johansson <josef@oderland.se>
>>> Fixes: fcacdfbef5a1 ("PCI/MSI: Provide a new set of mask and unmask functions")
>>> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
>>> Cc: Jason Andryuk <jandryuk@gmail.com>
>>> Cc: Marc Zyngier <maz@kernel.org>
>>> Cc: Bjorn Helgaas <helgaas@kernel.org>
>>> Cc: linux-pci@vger.kernel.org
>>> Cc: xen-devel <xen-devel@lists.xenproject.org>
>>> Cc: Juergen Gross <jgross@suse.com>
>>> Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
>>> Cc: David Woodhouse <dwmw2@infradead.org>
>>> ---
>>>  drivers/pci/msi.c   |   26 ++++++++++++++------------
>>>  include/linux/msi.h |    2 +-
>>>  2 files changed, 15 insertions(+), 13 deletions(-)
>>>
>>> --- a/drivers/pci/msi.c
>>> +++ b/drivers/pci/msi.c
>>> @@ -148,6 +148,9 @@ static noinline void pci_msi_update_mask
>>>  	raw_spinlock_t *lock = &desc->dev->msi_lock;
>>>  	unsigned long flags;
>>>  
>>> +	if (!desc->msi_attrib.can_mask)
>>> +		return;
>>> +
>>>  	raw_spin_lock_irqsave(lock, flags);
>>>  	desc->msi_mask &= ~clear;
>>>  	desc->msi_mask |= set;
>>> @@ -181,7 +184,8 @@ static void pci_msix_write_vector_ctrl(s
>>>  {
>>>  	void __iomem *desc_addr = pci_msix_desc_addr(desc);
>>>  
>>> -	writel(ctrl, desc_addr + PCI_MSIX_ENTRY_VECTOR_CTRL);
>>> +	if (desc->msi_attrib.can_mask)
>>> +		writel(ctrl, desc_addr + PCI_MSIX_ENTRY_VECTOR_CTRL);
>>>  }
>>>  
>>>  static inline void pci_msix_mask(struct msi_desc *desc)
>>> @@ -200,23 +204,17 @@ static inline void pci_msix_unmask(struc
>>>  
>>>  static void __pci_msi_mask_desc(struct msi_desc *desc, u32 mask)
>>>  {
>>> -	if (pci_msi_ignore_mask || desc->msi_attrib.is_virtual)
>>> -		return;
>>> -
>>>  	if (desc->msi_attrib.is_msix)
>>>  		pci_msix_mask(desc);
>>> -	else if (desc->msi_attrib.maskbit)
>>> +	else
>>>  		pci_msi_mask(desc, mask);
>>>  }
>>>  
>>>  static void __pci_msi_unmask_desc(struct msi_desc *desc, u32 mask)
>>>  {
>>> -	if (pci_msi_ignore_mask || desc->msi_attrib.is_virtual)
>>> -		return;
>>> -
>>>  	if (desc->msi_attrib.is_msix)
>>>  		pci_msix_unmask(desc);
>>> -	else if (desc->msi_attrib.maskbit)
>>> +	else
>>>  		pci_msi_unmask(desc, mask);
>>>  }
>>>  
>>> @@ -484,7 +482,8 @@ msi_setup_entry(struct pci_dev *dev, int
>>>  	entry->msi_attrib.is_64		= !!(control & PCI_MSI_FLAGS_64BIT);
>>>  	entry->msi_attrib.is_virtual    = 0;
>>>  	entry->msi_attrib.entry_nr	= 0;
>>> -	entry->msi_attrib.maskbit	= !!(control & PCI_MSI_FLAGS_MASKBIT);
>>> +	entry->msi_attrib.can_mask	= !pci_msi_ignore_mask &&
>>> +					  !!(control & PCI_MSI_FLAGS_MASKBIT);
>>>  	entry->msi_attrib.default_irq	= dev->irq;	/* Save IOAPIC IRQ */
>>>  	entry->msi_attrib.multi_cap	= (control & PCI_MSI_FLAGS_QMASK) >> 1;
>>>  	entry->msi_attrib.multiple	= ilog2(__roundup_pow_of_two(nvec));
>>> @@ -495,7 +494,7 @@ msi_setup_entry(struct pci_dev *dev, int
>>>  		entry->mask_pos = dev->msi_cap + PCI_MSI_MASK_32;
>>>  
>>>  	/* Save the initial mask status */
>>> -	if (entry->msi_attrib.maskbit)
>>> +	if (entry->msi_attrib.can_mask)
>>>  		pci_read_config_dword(dev, entry->mask_pos, &entry->msi_mask);
>>>  
>>>  out:
>>> @@ -638,10 +637,13 @@ static int msix_setup_entries(struct pci
>>>  		entry->msi_attrib.is_virtual =
>>>  			entry->msi_attrib.entry_nr >= vec_count;
>>>  
>>> +		entry->msi_attrib.can_mask	= !pci_msi_ignore_mask &&
>>> +						  !entry->msi_attrib.is_virtual;
>>> +
>>>  		entry->msi_attrib.default_irq	= dev->irq;
>>>  		entry->mask_base		= base;
>>>  
>>> -		if (!entry->msi_attrib.is_virtual) {
>>> +		if (!entry->msi_attrib.can_mask) {
>>>  			addr = pci_msix_desc_addr(entry);
>>>  			entry->msix_ctrl = readl(addr + PCI_MSIX_ENTRY_VECTOR_CTRL);
>>>  		}
>>> --- a/include/linux/msi.h
>>> +++ b/include/linux/msi.h
>>> @@ -148,7 +148,7 @@ struct msi_desc {
>>>  				u8	is_msix		: 1;
>>>  				u8	multiple	: 3;
>>>  				u8	multi_cap	: 3;
>>> -				u8	maskbit		: 1;
>>> +				u8	can_mask	: 1;
>>>  				u8	is_64		: 1;
>>>  				u8	is_virtual	: 1;
>>>  				u16	entry_nr;
>> Thanks,
>> I'll test this out ASAP.
> I'm adding
>
> diff --git a/kernel/irq/msi.c b/kernel/irq/msi.c
> index 6a5ecee6e567..28d509452958 100644
> --- a/kernel/irq/msi.c
> +++ b/kernel/irq/msi.c
> @@ -529,10 +529,10 @@ static bool msi_check_reservation_mode(struct irq_domain *domain,
>  
>  	/*
>  	 * Checking the first MSI descriptor is sufficient. MSIX supports
> -	 * masking and MSI does so when the maskbit is set.
> +	 * masking and MSI does so when the can_mask is set.
>  	 */
>  	desc = first_msi_entry(dev);
> -	return desc->msi_attrib.is_msix || desc->msi_attrib.maskbit;
> +	return desc->msi_attrib.is_msix || desc->msi_attrib.can_mask;
>  }
>  
>  int __msi_domain_alloc_irqs(struct irq_domain *domain, struct device *dev,
>
Hi Thomas,

With the above added the kernel boots fine and I can even suspend it twice.
Which is with my laptop, a good sign.

You can add Tested-By: josef@oderland.se.

Thanks again!

When I suspend I get errors from Xen, including stacktraces below
if anyone has any clue, if this might be related. I get one each time I
suspend
and the third time amdgpu gives up.

rtc_cmos 00:01: registered as rtc0
rtc_cmos 00:01: setting system clock to 2021-10-27T15:04:35 UTC (1635347075)
rtc_cmos 00:01: no alarms, y3k, 114 bytes nvram
device-mapper: core: CONFIG_IMA_DISABLE_HTABLE is disabled. Duplicate IMA measurements will not be recorded in the IMA log.
device-mapper: uevent: version 1.0.3
device-mapper: ioctl: 4.45.0-ioctl (2021-03-22) initialised: dm-devel@redhat.com
efifb: probing for efifb
efifb: cannot reserve video memory at 0x60000000
------------[ cut here ]------------
ioremap on RAM at 0x0000000060000000 - 0x00000000607e8fff
WARNING: CPU: 7 PID: 1 at arch/x86/mm/ioremap.c:210 __ioremap_caller+0x332/0x350
Modules linked in:
CPU: 7 PID: 1 Comm: swapper/0 Not tainted 5.15.0-0.rc7.0.fc32.qubes.x86_64 #1
Hardware name: LENOVO 20Y1S02400/20Y1S02400, BIOS R1BET65W(1.34 ) 06/17/2021
RIP: e030:__ioremap_caller+0x332/0x350
Code: e8 c3 ca ff ff 49 09 c6 e9 32 fe ff ff 48 8d 54 24 28 48 8d 74 24 18 48 c7 c7 35 f2 5d 82 c6 05 e8 7b a9 01 01 e8 48 39 be 00 <0f> 0b 45 31 e4 e9 ac fe ff ff e8 ff f5 c3 00 66 66 2e 0f 1f 84 00
RSP: e02b:ffffc9004007bb00 EFLAGS: 00010286
RAX: 0000000000000000 RBX: 00000000007e9000 RCX: ffffffff82915ca8
RDX: c0000000ffffdfff RSI: 0000000000000000 RDI: ffffffff82865ca0
RBP: 0000000060000000 R08: 0000000000000000 R09: ffffc9004007b948
R10: ffffc9004007b940 R11: ffffffff82945ce8 R12: 0000000000000001
R13: 00000000007e9000 R14: 00000000007e9000 R15: ffffffff81c8f772
FS:  0000000000000000(0000) GS:ffff8881407c0000(0000) knlGS:0000000000000000
CS:  e030 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 0000000000000000 CR3: 0000000002810000 CR4: 0000000000050660
Call Trace:
 efifb_probe.cold+0x2e6/0x688
 platform_probe+0x3f/0x90
 call_driver_probe+0x24/0xc0
 really_probe+0x1e7/0x310
 __driver_probe_device+0xfe/0x180
 driver_probe_device+0x1e/0x90
 __device_attach_driver+0x72/0xe0
 ? driver_allows_async_probing+0x50/0x50
 ? driver_allows_async_probing+0x50/0x50
 bus_for_each_drv+0x8f/0xd0
 __device_attach+0xe9/0x1f0
 bus_probe_device+0x8e/0xa0
 device_add+0x3fb/0x630
 platform_device_add+0x102/0x230
 sysfb_init+0xea/0x141
 ? firmware_map_add_early+0xb8/0xb8
 do_one_initcall+0x57/0x200
 do_initcalls+0x109/0x166
 kernel_init_freeable+0x23c/0x2bd
 ? rest_init+0xc0/0xc0
 kernel_init+0x16/0x120
 ret_from_fork+0x22/0x30
---[ end trace b068d3cd1b7f5f49 ]---
efifb: abort, cannot remap video memory 0x7e9000 @ 0x60000000
efi-framebuffer: probe of efi-framebuffer.0 failed with error -5
--
printk: Suspending console(s) (use no_console_suspend to debug)
[drm] free PSP TMR buffer
PM: suspend devices took 0.428 seconds
ACPI: EC: interrupt blocked
ACPI: PM: Preparing to enter system sleep state S3
ACPI: EC: event blocked
ACPI: EC: EC stopped
ACPI: PM: Saving platform NVS memory
Disabling non-boot CPUs ...
------------[ cut here ]------------
WARNING: CPU: 1 PID: 0 at arch/x86/mm/tlb.c:522 switch_mm_irqs_off+0x3c5/0x400
Modules linked in: snd_seq_dummy snd_hrtimer snd_seq snd_seq_device snd_timer nf_tables nfnetlink vfat fat intel_rapl_msr think_lmi firmware_attributes_class wmi_bmof intel_rapl_common pcspkr uvcvideo videobuf2_vmalloc videobuf2_memops joydev videobuf2_v4l2 sp5100_tco k10temp videobuf2_common i2c_piix4 iwlwifi videodev mc cfg80211 thinkpad_acpi ipmi_devintf ucsi_acpi platform_profile typec_ucsi ledtrig_audio ipmi_msghandler r8169 rfkill typec snd wmi soundcore video i2c_scmi fuse xenfs ip_tables dm_thin_pool dm_persistent_data dm_bio_prison dm_crypt trusted asn1_encoder hid_multitouch amdgpu crct10dif_pclmul crc32_pclmul crc32c_intel gpu_sched i2c_algo_bit drm_ttm_helper ghash_clmulni_intel ttm serio_raw drm_kms_helper cec sdhci_pci cqhci sdhci xhci_pci drm xhci_pci_renesas nvme xhci_hcd ehci_pci mmc_core ehci_hcd nvme_core xen_acpi_processor xen_privcmd xen_pciback xen_blkback xen_gntalloc xen_gntdev xen_evtchn uinput
CPU: 1 PID: 0 Comm: swapper/1 Tainted: G        W        --------- ---  5.15.0-0.rc7.0.fc32.qubes.x86_64 #1
Hardware name: LENOVO 20Y1S02400/20Y1S02400, BIOS R1BET65W(1.34 ) 06/17/2021
RIP: e030:switch_mm_irqs_off+0x3c5/0x400
Code: f0 41 80 65 01 fb ba 01 00 00 00 49 8d b5 60 23 00 00 4c 89 ef 49 c7 85 68 23 00 00 60 1d 08 81 e8 a0 f3 08 00 e9 15 fd ff ff <0f> 0b e8 34 fa ff ff e9 ad fc ff ff 0f 0b e9 31 fe ff ff 0f 0b e9
RSP: e02b:ffffc900400f3eb0 EFLAGS: 00010006
RAX: 00000001336c6000 RBX: ffff888140660000 RCX: 0000000000000040
RDX: ffff8881003027c0 RSI: 0000000000000000 RDI: ffff8881b36c6000
RBP: ffffffff829d91c0 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000008 R11: 0000000000000000 R12: ffff888104e88440
R13: ffff8881003027c0 R14: 0000000000000000 R15: 0000000000000001
FS:  0000000000000000(0000) GS:ffff888140640000(0000) knlGS:0000000000000000
CS:  10000e030 DS: 002b ES: 002b CR0: 0000000080050033
CR2: 000060b7d78bf198 CR3: 0000000002810000 CR4: 0000000000050660
Call Trace:
 switch_mm+0x1c/0x30
 idle_task_exit+0x55/0x60
 play_dead_common+0xa/0x20
 xen_pv_play_dead+0xa/0x60
 do_idle+0xd1/0xe0
 cpu_startup_entry+0x19/0x20
 asm_cpu_bringup_and_idle+0x5/0x1000
---[ end trace b068d3cd1b7f5f4b ]---
smpboot: CPU 1 is now offline
smpboot: CPU 2 is now offline
smpboot: CPU 3 is now offline
smpboot: CPU 4 is now offline
smpboot: CPU 5 is now offline
smpboot: CPU 6 is now offline
smpboot: CPU 7 is now offline
ACPI: PM: Low-level resume complete
ACPI: EC: EC started
ACPI: PM: Restoring platform NVS memory
xen_acpi_processor: Uploading Xen processor PM info
xen_acpi_processor: (_PXX): Hypervisor error (-19) for ACPI CPU1
xen_acpi_processor: (_PXX): Hypervisor error (-19) for ACPI CPU3
xen_acpi_processor: (_PXX): Hypervisor error (-19) for ACPI CPU5
xen_acpi_processor: (_PXX): Hypervisor error (-19) for ACPI CPU7
xen_acpi_processor: (_PXX): Hypervisor error (-19) for ACPI CPU9
xen_acpi_processor: (_PXX): Hypervisor error (-19) for ACPI CPU11
--
CPU2 is up
installing Xen timer for CPU 3
cpu 3 spinlock event irq 79
[Firmware Bug]: ACPI MWAIT C-state 0x0 not supported by HW (0x0)
ACPI: \_SB_.PLTF.C003: Found 3 idle states
ACPI: FW issue: working around C-state latencies out of order
CPU3 is up
------------[ cut here ]------------
cfs_rq->avg.load_avg || cfs_rq->avg.util_avg || cfs_rq->avg.runnable_avg
installing Xen timer for CPU 4
WARNING: CPU: 3 PID: 455 at kernel/sched/fair.c:3339 __update_blocked_fair+0x49b/0x4b0
Modules linked in: snd_seq_dummy snd_hrtimer snd_seq snd_seq_device snd_timer nf_tables nfnetlink vfat fat intel_rapl_msr think_lmi firmware_attributes_class wmi_bmof intel_rapl_common pcspkr uvcvideo videobuf2_vmalloc videobuf2_memops joydev videobuf2_v4l2 sp5100_tco k10temp videobuf2_common i2c_piix4 iwlwifi videodev mc cfg80211 thinkpad_acpi ipmi_devintf ucsi_acpi platform_profile typec_ucsi ledtrig_audio ipmi_msghandler r8169 rfkill typec snd wmi soundcore video i2c_scmi fuse xenfs ip_tables dm_thin_pool dm_persistent_data dm_bio_prison dm_crypt trusted asn1_encoder hid_multitouch amdgpu crct10dif_pclmul crc32_pclmul crc32c_intel gpu_sched i2c_algo_bit drm_ttm_helper ghash_clmulni_intel ttm serio_raw drm_kms_helper cec sdhci_pci cqhci sdhci xhci_pci drm xhci_pci_renesas nvme xhci_hcd ehci_pci mmc_core ehci_hcd nvme_core xen_acpi_processor xen_privcmd xen_pciback xen_blkback xen_gntalloc xen_gntdev xen_evtchn uinput
CPU: 3 PID: 455 Comm: kworker/3:2 Tainted: G        W        --------- ---  5.15.0-0.rc7.0.fc32.qubes.x86_64 #1
Hardware name: LENOVO 20Y1S02400/20Y1S02400, BIOS R1BET65W(1.34 ) 06/17/2021
Workqueue:  0x0 (events)
RIP: e030:__update_blocked_fair+0x49b/0x4b0
Code: 6b fd ff ff 49 8b 96 48 01 00 00 48 89 90 50 09 00 00 e9 ff fc ff ff 48 c7 c7 10 7a 5e 82 c6 05 f3 35 9e 01 01 e8 1f f3 b2 00 <0f> 0b 41 8b 86 38 01 00 00 e9 c6 fc ff ff 0f 1f 80 00 00 00 00 0f
RSP: e02b:ffffc900410d7ce0 EFLAGS: 00010082
RAX: 0000000000000000 RBX: 0000000000000018 RCX: ffff8881406d8a08
RDX: 00000000ffffffd8 RSI: 0000000000000027 RDI: ffff8881406d8a00
RBP: ffff8881406e9800 R08: 0000000000000048 R09: ffffc900410d7c78
R10: 0000000000000049 R11: 000000002d2d2d2d R12: ffff8881406e9f80
R13: ffff8881406e9e40 R14: ffff8881406e96c0 R15: 0000000000000000
FS:  0000000000000000(0000) GS:ffff8881406c0000(0000) knlGS:0000000000000000
CS:  10000e030 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 0000782e51820000 CR3: 0000000002810000 CR4: 0000000000050660
Call Trace:
 update_blocked_averages+0xa8/0x180
 newidle_balance+0x175/0x380
 pick_next_task_fair+0x39/0x3e0
 pick_next_task+0x4c/0xbd0
 ? dequeue_task_fair+0xba/0x390
 __schedule+0x13a/0x570
 schedule+0x44/0xa0
 worker_thread+0xc0/0x320
 ? process_one_work+0x390/0x390
 kthread+0x10f/0x130
 ? set_kthread_struct+0x40/0x40
 ret_from_fork+0x22/0x30
---[ end trace b068d3cd1b7f5f4c ]---
cpu 4 spinlock event irq 85
[Firmware Bug]: ACPI MWAIT C-state 0x0 not supported by HW (0x0)
ACPI: \_SB_.PLTF.C004: Found 3 idle states
ACPI: FW issue: working around C-state latencies out of order
CPU4 is up
installing Xen timer for CPU 5
cpu 5 spinlock event irq 91
[Firmware Bug]: ACPI MWAIT C-state 0x0 not supported by HW (0x0)
ACPI: \_SB_.PLTF.C005: Found 3 idle states
ACPI: FW issue: working around C-state latencies out of order
CPU5 is up



From xen-devel-bounces@lists.xenproject.org Wed Oct 27 15:35:11 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Oct 2021 15:35:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217073.376913 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfkxE-0001J3-5L; Wed, 27 Oct 2021 15:35:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217073.376913; Wed, 27 Oct 2021 15:35:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfkxE-0001Iw-1X; Wed, 27 Oct 2021 15:35:04 +0000
Received: by outflank-mailman (input) for mailman id 217073;
 Wed, 27 Oct 2021 15:35:03 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Ie0f=PP=citrix.com=roger.pau@srs-us1.protection.inumbo.net>)
 id 1mfkxD-0001Iq-Hj
 for xen-devel@lists.xenproject.org; Wed, 27 Oct 2021 15:35:03 +0000
Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 72a38e14-373b-11ec-8475-12813bfff9fa;
 Wed, 27 Oct 2021 15:35:01 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 72a38e14-373b-11ec-8475-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1635348901;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=omqzar+LVci20djhtPeKhrDhQttQh6vnd5U9NP+pDLU=;
  b=Sm8Wa+gNfqcPbg9ktaIVLMf75jsy7Z2lwuEgH/ekwV1n6D0ntGnUmeg7
   9Ds93GzVdmkPp8QLDmsHy+FBjxNdw+Xs20S8AyM9lONBBvi+RMc07QxPX
   51cSL5xiQTHnYjPE7JgU8l4PF3sbixe6R8gNMTtw6D4a0DSS1bNQgK7VG
   o=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: DgHiUFgs+7zIGXMUdNZH+0wbZFoPWPvmH382QJiAwIbIdHtsjA18CCcPw3aSPdjeu6l4mr/2to
 D5NiutJwanj9Bo7+uut/bI2z76Aw+kxAnCZyZaFG15qOv+gG3qxtkhAmewrZ+qzSi0EBIK+irC
 SWTRRvGcfxqHwiF3WTVTw8uI6C9Wt2pMsObIlCfKhILwKS+DFMM1wFltvAuM8VJcXhelwqhPVL
 2Nr2hugwu10qhYFbxUSs/0xViYvq0fld4KG388cpDB9L0Qmk1ISQeABNtz41CLXP5MtTUMfrOF
 APBke8II/diKMGzT3xCM7vi2
X-SBRS: 5.1
X-MesageID: 56414692
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:j3ovtqpFYUx3T4IJyLbleJkDUzJeBmICYxIvgKrLsJaIsI4StFCzt
 garIBnSb/aCMDemf4h2aN+3o0MHu5PSx4VqTgM++CA8FCxA85uZCYyVIHmrMnLJJKUvbq7GA
 +byyDXkBJppJpMJjk71atANlZT4vE2xbuKU5NTsY0idfic5Dnd+4f5fs7Rh2Ncx2YLmW1nlV
 e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL
 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9
 DlCnZyyGSg0Prftov4UVAVYMiN/Eqd/0YaSdBBTseTLp6HHW37lwvEoB0AqJ4wIvO1wBAmi9
 9RBdmpLNErawbvrnvTrEYGAhex6RCXvFJkYtXx6iynQEN4tQIzZQrWM7thdtNs1rp0QQa+CO
 ZtDAdZpRAXyZDgfGFEQNJg/gtyyq1z8fg1/gnvA8MLb5ECMlVcsgdABKuH9U8aWSMBiu1eXr
 2PL4Uz0GhgfcteYzFKtzHWogePemDLhb6gbHra46/1CjUWawyoYDxh+fVmxrOS9i0W+c8lCM
 EFS8S0rxYAo/Uy2Sp/mXhu3oFaNpBtaUN1Ve8Uw5RuR0KPS70CcD3IdUz9aQNU8sYk9QjlC/
 k+EmZblCCJitJWRSGmB7fGEoDWqIy8XIGQeIygeQmMtxN3uo5o6iB7Vef9lHLSold3+GTz2w
 DeioTA3gvMYistj/6em+VHKhRq8q56PSRQ6ji3wWm+m9Qp/aJSSW52z6VPb4PBDK66UVlCE+
 nMDnqC29/sSBJuAkCiMRuQlH7yz4fuBdjrGjjZS84IJrmr3vST5JMYJvW84dBwB3ts4lSHBY
 E2Dlh5R/r5pJnKtca9WYYOeAf0D9P21fTj6bcz8Yt1La5l3UQaI+iByeEKdt1zQfFgQfbIXY
 sjDL579ZZoOIeE+lmDuHrZCuVM+7nlmnTu7eHzt8/iwPVNyjlauQrAZLEDGUOk96K6VyOk+2
 4cCb5XUo/mzveuXX8U2zWLxBQxVRZTYLcqvwyCySgJlClA+cI3GI6SIqY7Ng6Q/w8xoeh7gp
 xlRoHNwxlvlnmHgIg6XcH1lY76Hdc8h9i9hYnd8Zw7xgyVLjWOTAEE3LcNfkV4Pr7UL8BKJZ
 6NdJ5Xo7gpnE2yvF8shgWnV89U5KUXDafOmNCu5ejkvF6OMtCSSkuIIijDHrXFUZgLu7JNWi
 +T5imvzHMpSLyw/XZ2+QK/+kDuMUY01xbsas73geYIIJi0BMeFCdkTMsxPAC5tTdkyTl2HDj
 lf+7NVxjbClnrLZOeLh3Mish4yoD/F/DgxdGWza5qyxLi7U4iyoxooobQpCVW21uLrc9Prwa
 ONL4ev7NfFbzl9Gv5AlS+RgzL4k5suprLhfl1w2EHLOZlWtK7VhPnjZgpUf6vwTnudU6VmsR
 0aC2thGIrHVasnrJ0EceVg+ZeOZ2PBKxjSLtaYpIF/37TNc9aacVRkAJAGFjSFQdeMnMI4sz
 eo7ltQR7giz1kgjPtqc13gG/GWQNH0QFa4gs8hCUoPsjwMqzHBEYIDdVXCqsM3eNY0UPxBzc
 DGOhafEi7BN/Wb4ciI+RSrXwO5QpZUSoxQWnlUMEEuEx4jejfgt0RwPrTluFlZJzg9K2v5YM
 3RwMxEnPr2H+jpliZQRX22oHA0dVhSV9laolgkMnWzdCUKpSnbMPCs2PuPUpBIV9GdVfz56+
 rCEyTm6DWa2LZ+phiZiC1R4r/HDTMBq8lyQkc+qKM2JAp0mbGe3maSpf2cJ90PqDM5ZaJcrf
 gW2EDKcsZHGCBM=
IronPort-HdrOrdr: A9a23:TASrlaijH/1iBnMCCywPWDfb0HBQX0Z13DAbv31ZSRFFG/FwyP
 rBoB1L73DJYWgqNE3I+erhBEGBKUmsk6KdxbNhQItKOzOWxFdATbsSl7cKpgeAJ8SQzJ856U
 4NSdkbNDS0NykEsS+Y2njJLz9D+qj+zEnAv463pB0BPGIaCdAS0+46MHfhLqQffng2OXNTLu
 vk2iMonUvGRZxBBf7LeEXtEtKz6uHjpdbDW1orFhQn4A6BgXeB76P7KQGR2lM7XylUybkv3G
 DZm0ihj5/T/M2T+1v57Sv+/p5WkNzuxp9qA9GNsNEcLnHJhhyzbIpsdrWetHQeof2p6nwtjN
 7Qyi1Qc/hb2jf0RCWYsBHt0w7v3HIH7GLj80aRhT/ZrcnwVFsBeoJ8rLMcViGcx1srvdl63q
 4O9XmerYBrARTJmzm4z8TUVjlx/3DE4UYKoKo2tThyQIEeYLheocg050VOCqoNGyr89cQODP
 RuNsfB//xbGGnqLkwxhlMfguBEY05DWytvGiM5y4ioOnlt7T5EJnIjtY8idixqzuN7d3FGj9
 60e5iA2os+CPP+VpgNcdvpd/HHfFAlcSi8Ql56Hm6XYJ3vG0i94KIfs49Frt1DRvQzvewPcd
 L6IQpliVI=
X-IronPort-AV: E=Sophos;i="5.87,187,1631592000"; 
   d="scan'208";a="56414692"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Zzof1VCqOUXSUPe8bqPiN/FXUHWHVVhyVu0BJOf6I8jGAGbbILqg19WIPBmVrY+rO21K0UpoLFi6qe4j569LJYx7NLW9xkxgjfMWAYTXIpOvXRXQHLs0+DLY8IvPpYWJYQVtvtKk93aJleu//w1qEE6AhsTOuiWZQm5c68icu9X5txa3ymXyoz5dQ5QWIliws2lrNZfkqhDu79XNtaCSInAvY3kW4qrWIOlCsocVcGvehcE+AALUAt7VvENl1KUsd/ThSFqOtyerd5nvg+yoHVN2IQlNk7r+IvOaMlgTU+5C5/6ftUXpUw55JCwJ+RLDNhWGpJjV9t3GJu1ls6tI8g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=E7Fv1Im5mtr/Kbm5XYnuYLi1vcvEW6YgAsGomI1zCzs=;
 b=Rlh4JaMVAiXFT3w3DIZej3uprGNX/9mk2kbN+9ATk3isWgKUmzq0ZyCiCMLVltGxp5xeEfIzRteNT46X31+2NVWoc1yvg2xxGAiU5xuChmdXDWl7aXs4wufrvkqDtCblwj3i4jrlISxYzn8F0ELB5tdphiz5L07cz93uPZY9qAzknpihpRy29wc1038pSNyLTwASBRE3c+4wg6DErPTxCzcOCkGJPF7sIV7yI9wO4J1i8tq1u7UlMXIlZawewv4EyXUBnFiP20eI0Mp7fE6T4CjINoKXj6sGgd40T2PxvzGj3I1836RQ/9ehSmXgTYyRK3o6TkXDmUzXkRQzq7PA9g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=E7Fv1Im5mtr/Kbm5XYnuYLi1vcvEW6YgAsGomI1zCzs=;
 b=gch4TUWWilt444k/1CWoknRnucGr3h93rFHJUOHVxUBwOuqlHAa3iiv5fgIhqXQkyf4VfIhmMBpN8yYACkIGLBrLX3J4tKv/13/GsVFcgAAp7Q4SH1fVAmaQAzHZahP1AKn1SekFP+L0/ISxRMWqJUvCGfZnnQJB2VpM/a5QFYI=
Date: Wed, 27 Oct 2021 17:34:49 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	"julien@xen.org" <julien@xen.org>, "sstabellini@kernel.org"
	<sstabellini@kernel.org>, Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Artem Mygaiev <Artem_Mygaiev@epam.com>,
	"jbeulich@suse.com" <jbeulich@suse.com>, Bertrand Marquis
	<bertrand.marquis@arm.com>, Rahul Singh <rahul.singh@arm.com>
Subject: Re: [PATCH v3 03/11] vpci/header: Move register assignments from
 init_bars
Message-ID: <YXlxmdYdwptakDDK@Air-de-Roger>
References: <20210930075223.860329-1-andr2000@gmail.com>
 <20210930075223.860329-4-andr2000@gmail.com>
 <YWbkZ216FbV8lBns@MacBook-Air-de-Roger.local>
 <89e1f09e-c840-860e-e596-38fb141aa707@epam.com>
 <344cf880-8f76-1a71-d27c-e7ba10459d5b@epam.com>
 <YXlS68Ghrphi5dHB@Air-de-Roger>
 <368bf4b5-f9fd-76a6-294e-dbb93a18e73f@epam.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <368bf4b5-f9fd-76a6-294e-dbb93a18e73f@epam.com>
X-ClientProxiedBy: MR2P264CA0144.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:500:30::36) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 9574d431-39a5-4bb0-5584-08d9995f533d
X-MS-TrafficTypeDiagnostic: DM6PR03MB4299:
X-Microsoft-Antispam-PRVS: <DM6PR03MB4299DC31C442BAA8C75B6DD68F859@DM6PR03MB4299.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: JmtGjcnb0nPPxBepb86jcaJulj9p2SVae4KRUVGOpoOKsKs+NdCFPcXWEZr0zqL8Ywkk26t3i7jdGIPgOo4NNuZ7ECUMdsj5Fc3LxncsKvzqedOLcdkcizloXD9ZVOBfBWguXs9nZ2J0uLVF+sW3gYZeNgJOFkIfzXfpj6YUIKIyYqtfTkuj1BTiI5PtNr1MhQqkXWm1gWqvrSePLNHSNYmRvgjSaB+IWqH+zKb0Zxa5PiF7ZGKl00SE8gQK2P2lUH1XyQ0TtlnoXTA58k5SgMO4Mf1jdl4jHCdiDY651u0xuKb/1zAZD/FWooTG9EHDxMO3G4jrkYyGt3T69XIs/zgm3COkyF5TyV8pz7FA/2hQY71VSzY3dvLL+b8197ZCzRP3THF+ItE7GlBxZh9y5gQPxHo0ox3Vl3A+/m6igkcl1Sn24HMGFwKDZ/da04qAhtfNovYDCRMwEeMrLp9E1qNS0M8AdmMemz6pt8lz1016hDJ5K03cENf8mfstqwuORdUmSl7g+Xv711dIFYAMSOZWH1a9IoaYDAVK5l4880A1krJhqM8fBBgzbqUCvP6EFNeWqmkZLMXa0Dt4SmwSwfFJWszW1J2NbATISl2F1NdJtxk8jY7DmaFfNioF4rr+YMEJglyBPrDZj0dTJ1Ibyg==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(7916004)(366004)(6666004)(26005)(53546011)(186003)(508600001)(5660300002)(33716001)(6916009)(2906002)(54906003)(4326008)(9686003)(6486002)(316002)(66946007)(956004)(7416002)(6496006)(85182001)(82960400001)(66556008)(66476007)(8936002)(8676002)(38100700002)(83380400001)(86362001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?V0ROamkvdzlQNXV5Y0NLSDRWVmRhTVYxTmw1TDVSRTZ3by9Xb0t4MnROZVRV?=
 =?utf-8?B?VW1uTnFIWUhCT0tjMDFUdjlnRStUbStBcVZGM1NHajVtbnZJcnFwMDh0YWRN?=
 =?utf-8?B?RVVHTUVpNjVWSDdRRTBlVktsVjdnQmxEY1E1T0dmRmlYWUpUTkRUMzhTWk5W?=
 =?utf-8?B?K3dHcnlvRjR4S3FGL3hCdFE2c1drOWFWZ2FQTW43VGxhMkNyb1dNWVljNldJ?=
 =?utf-8?B?cHJPQ0ovMVlua1BiVG9XekxoNmF2VVh0c1lzeS9zUmozSzZtc1ZVYkpMZDRF?=
 =?utf-8?B?NDBXWmNVMkEyN2NORyt1eUh6azdwb1JkRlJUbm9SZE5ZMWVocFRTS2NrM2to?=
 =?utf-8?B?OFIybVVyM0RXSlE4eUtQcjEwM0hiZ2lsMkVHWTZGdlpWVFlGYWluTjRFWGYw?=
 =?utf-8?B?ZGl6YnAwS2VtMk5JTGU4VHVxMXRwUHBrQ0VuRjNRWnNoOFdaaVNmdXZKYWVw?=
 =?utf-8?B?U2xaaVljdzBZVW41djZtWXVrelpDUWtwZEpMUmRUSDI1SEV5cDZ3MkZMSzVM?=
 =?utf-8?B?Y0NaNm5QUHBqZ0JQZFJwZEtKY205djFydlZYSjBuWllVcDlhcHh1UlNYYWwv?=
 =?utf-8?B?UWl4QUY5Mk5WU2pXczVuL3E0NE5mR2htL2ZOQmNVeVV0Y0J3V3Jla2VKOGEx?=
 =?utf-8?B?MHhWdHlRMUdUeTJlQzJCKytGYWt6SDRIVnZaemhldjJYbXQ3WGVlOGRLa3gz?=
 =?utf-8?B?dmhZM1BvTmVQYjY1YTREL1ZCQ2RuQnMrZHM1WU10eWhvNFFxbGhIaCtEelI0?=
 =?utf-8?B?RWxmRzNyOXl0UnhZdzlURWl2MGZodElzdFpZUE5BMkJwejNESWR2Y3Jkd0dm?=
 =?utf-8?B?UEh5dzI2aFZOMm1iRVRmN3hTSzZsWm91UnU0ODFIN1Q3ekpmT3ZEdUtSSUlO?=
 =?utf-8?B?TmtUZnE4cTJXQWRoc1dHYW5JcEVuVXFjK0NpSE1xOHZmcWtqNC9MNzhuaDB0?=
 =?utf-8?B?anRsY2FlOUt0NlVyUFozTG9vTm5MSUd3d3ZtRzFKdnhCc1RhWkQxdGpWcVh1?=
 =?utf-8?B?RjJmdnhKbVJOYm14eTFNMmxoYTZXQjNmRS9pWk1WNXp5NzFNZTRRbDkwK3dr?=
 =?utf-8?B?VHZMTGFEenhSMko1R29FWjNQR3FjMk5XVm9ySjl6OFhNZDZmZDl4bGJ1bzNW?=
 =?utf-8?B?UWd0UFNuOUd5MSsveEhOZThETkk5WnNobFZVQWRaTWJyblFqUWw5T08vUzh2?=
 =?utf-8?B?QitjZjgvK0RIWGMwOTZ4eEZ5S0hpWFlCZVFOc3orRjlZVHBoZktkWG1FM0V1?=
 =?utf-8?B?RVNEYlVLSzdxZUp5bnM0anIyVkFNV0t0ZE9CQ0NMREJ0RVpkeFZVS2R1MXFn?=
 =?utf-8?B?Qzl5SGU5OVNRQTVveXVSUGFvTnQ5T253dTEzZDhrcXh1aGdjTWFKNm9OdUE0?=
 =?utf-8?B?NXRrSytTMWhlTC9xV1NJTkpiNEFtc0hYTis5Y2t2SG83dmdVMWpuRmdWb295?=
 =?utf-8?B?UmVRcWxOdXlENGlDL1FRTm1ObzRCbnBjMVllY3V4T25nSkZlOXpZYkVqekJp?=
 =?utf-8?B?T2RnWEo3S2NQL3VFYUM1U1MwZVgyVnRySWtaeGlyT1B3Y3c4TkE2NTU3VFRQ?=
 =?utf-8?B?ZUNHZTZuTUpGNjFWWjFEK1Qyek9mamJJM1pXQWRSZGJtbzJqYXBrdzFjVGlr?=
 =?utf-8?B?cHNMZ2t5VGhITjVXZFdUMFVqQ2RQSkFNOTVyZURsN0c0cWVoTEt5ZzFFMUJ1?=
 =?utf-8?B?REgxYWsxekI2ZTcvaHR1dWs2ZFBBYU5Ddm9jTnRlTWNiaTlWRUh4WjZMd2xC?=
 =?utf-8?B?Y3d6ZzNpUC8vRGpoeHVJUmhlSFl0RTJlRGVaODFpaUZoR1B2RHpnUSt3cTVR?=
 =?utf-8?B?NUtyRnhISExNZUl3bkFpbjduOGVlTDJkQ2JaVXhHRE5OZ3dKWjNGbERaVzg2?=
 =?utf-8?B?eVJSTmFXWlZBVWw3K1VxVS9ERS9EUkkwMERKSlFIeHNlVTZraVdBaW1ENGgr?=
 =?utf-8?B?eU1qVjlnUVNlN1hJZzJ1d1liQ3ZLbWcxdzQ1ck1nRzhxd2tvRnVDaXRlZkVJ?=
 =?utf-8?B?K01wWWxMUmxDaWExY1cxYW9JU1ViQW50Z0dyNjVObEYxVTV5SHlEVzdpcGdK?=
 =?utf-8?B?SkxNaGRPWXRVUXhja1dKUzJmdlppam9SellCNzU1WmdvbXB3WnBzWUNrd21l?=
 =?utf-8?B?dnpRQ3gydkVhc1hqUW95aXdNU25QRi9Ec0lmTXF3RngzMXVsWndPdkJuWGhN?=
 =?utf-8?Q?B/5OVE2nw7vHl4kBdzydl0M=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 9574d431-39a5-4bb0-5584-08d9995f533d
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Oct 2021 15:34:54.8799
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: eJrhyvBFhkM8mdz5yapYlw1sItk9gOOOzPwA+4va2ZSw17z1CMT4BhdJ2xJXSbhnKd61jRWCI8kPxaE5pUZ6fw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4299
X-OriginatorOrg: citrix.com

On Wed, Oct 27, 2021 at 02:06:40PM +0000, Oleksandr Andrushchenko wrote:
> 
> 
> On 27.10.21 16:23, Roger Pau Monné wrote:
> > On Wed, Oct 27, 2021 at 11:59:47AM +0000, Oleksandr Andrushchenko wrote:
> >> Hi, Roger!
> >>
> >> On 27.10.21 13:17, Oleksandr Andrushchenko wrote:
> >>> Hi, Roger!
> >>>
> >>> On 13.10.21 16:51, Roger Pau Monné wrote:
> >>>> On Thu, Sep 30, 2021 at 10:52:15AM +0300, Oleksandr Andrushchenko wrote:
> >>>>> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> >>>>>
> >>>>> This is in preparation for dynamic assignment of the vPCI register
> >>>>> handlers depending on the domain: hwdom or guest.
> >>>>> The need for this step is that it is easier to have all related functionality
> >>>>> put at one place. When the subsequent patches add decisions on which
> >>>>> handlers to install, e.g. hwdom or guest handlers, then this is easily
> >>>>> achievable.
> >>>> Won't it be possible to select the handlers to install in init_bars
> >>>> itself?
> >>> It is possible
> >>>> Splitting it like that means you need to iterate over the numbers of
> >>>> BARs twice (one in add_bar_handlers and one in init_bars), which makes
> >>>> it more likely to introduce errors or divergences.
> >>>>
> >>>> Decoupling the filling of vpci_bar data with setting the handlers
> >>>> seems slightly confusing.
> >>> Ok, I won't introduce add_bar_handlers, thus rendering this patch useless.
> >>> I'll drop it and re-work the upcoming patches with this respect
> >> On the other hand after thinking a bit more.
> >> What actually init_bars do?
> >> 1. Runs once per each pdev (__init?)
> >> 2. Sizes the BARs and detects their type, sets up pdev->vpci->header BAR values
> >> 3. Adds register handlers.
> >>
> >> For DomU we only need 3), so we can setup guest handlers.
> > I think you assume that there will always be a hardware domain with
> > vPCI enabled that will get the device assigned and thus init_bars will
> > be executed prior to assigning to a domU.
> Yes, this is the current assumption...
> >
> > But what about dom0less,
> it was decided to put dom0less out of scope for now
> >   or when using a classic PV dom0?
> I thought that vPCI is only used for PVH Dom0 and it is enough for now
> (yes, this is a weak argument, but we do not want PCI passthrough on Arm
> to become a never ending game... since 2015...)

I understand that not everything will be supported, that's perfectly
fine, but we should aim to not make supporting those use cases
harder in the future.

> >   In that case
> > the device won't get assigned to a hardware domain with vPCI support,
> > so the vpci structure won't be allocated or filled,
> Yes, this is true. But because of the 3 functionflities of the init_bars is
> doing it might still need some dis-aggregation, e.g. BAR sizing
> is not needed and might not be possible while assigning to a DomU.
> So, I think that init_bars will need to be split in any case.

I understand that BAR sizing will not be needed if the structure is
pre-initialized, but I also cannot see why it would be impossible, at
least on x86.

> >   and hence
> > init_bars would have to be executed when assigning to a domU.
> Please see above: not sure init_bars can exist in its form to achieve that.
> One of the steps this patch is doing is we split init_bars into
> a) register assignment
> b) all the reset: initial pdev's header initialization, sizing etc.
> 
> The same is true for MSI/MSI-X. When we add support for MSI/MSI-X on Arm
> you will see the same: we need to split [1] (this is WIP).
> 
> So, I am still convinced that we need add_bar_handlers in some form.

I'm fine to split it if there's a hard requirement, but I'm afraid so
far I'm not convinced it's required. Maybe if you could elaborate on
why BAR sizing might not be possible when assigning to domU I could be
convinced.

Another option might be to just modify init_bars to have slightly
different paths for dom0 vs domU.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Wed Oct 27 15:40:18 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Oct 2021 15:40:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217082.376924 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfl29-0002qC-TZ; Wed, 27 Oct 2021 15:40:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217082.376924; Wed, 27 Oct 2021 15:40:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfl29-0002q5-OE; Wed, 27 Oct 2021 15:40:09 +0000
Received: by outflank-mailman (input) for mailman id 217082;
 Wed, 27 Oct 2021 15:40:08 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mfl28-0002pE-OC
 for xen-devel@lists.xenproject.org; Wed, 27 Oct 2021 15:40:08 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mfl28-0006bC-LK
 for xen-devel@lists.xenproject.org; Wed, 27 Oct 2021 15:40:08 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mfl28-0007lx-KN
 for xen-devel@lists.xenproject.org; Wed, 27 Oct 2021 15:40:08 +0000
Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89)
 (envelope-from <iwj@xenproject.org>)
 id 1mfl1v-0007ml-8b; Wed, 27 Oct 2021 16:39:55 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date
	:Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From;
	bh=vz66shXEZb+9ivv9wFPjwWjuGbdx0hkL6b04z5V0o/4=; b=tBKOaeGZkcOtLncMrjFRORXwjm
	rUUR3475BhWIv87y6LoaVqt1EmDe0iGpufRwyz//AWkZBpnM6IiNXUlRkkrKQ4u8WyODEBDKPVfl/
	e9sdmXEekEnIyd8zjH9JkQzh3DWTbjIjKdKAPzQnbc6Tp5lteOeU8DEomaY2jsRY1+mE=;
From: Ian Jackson <iwj@xenproject.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
Message-ID: <24953.29377.25284.598334@mariner.uk.xensource.com>
Date: Wed, 27 Oct 2021 16:39:45 +0100
To: Roger Pau Monne <roger.pau@citrix.com>
Cc: <xen-devel@lists.xenproject.org>,
    Jan Beulich <jbeulich@suse.com>,
    Andrew Cooper <andrew.cooper3@citrix.com>,
    Wei Liu <wl@xen.org>,
    Ian Jackson <iwj@xenproject.org>
Subject: Re: [PATCH] x86/cpuid: prevent decreasing of hypervisor max leaf on migration
In-Reply-To: <20211027140050.67509-1-roger.pau@citrix.com>
References: <20211027140050.67509-1-roger.pau@citrix.com>
X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu)

Roger Pau Monne writes ("[PATCH] x86/cpuid: prevent decreasing of hypervisor max leaf on migration"):
> In order to be compatible with previous Xen versions, and not change
> max hypervisor leaf as a result of a migration, keep the clamping of
> the maximum leaf value provided to XEN_CPUID_MAX_NUM_LEAVES, instead
> of doing it based on the domain type. Also set the default maximum
> leaf without taking the domain type into account. The maximum
> hypervisor leaf is not migrated, so we need the default to not regress
> beyond what might already be reported to a guest by existing Xen
> versions.
> 
> This is a partial revert of 540d911c28 and restores the previous
> behaviour and assures that HVM guests won't see it's maximum
> hypervisor leaf reduced from 5 to 4 as a result of a migration.
> 
> Fixes: 540d911c28 ('x86/CPUID: shrink max_{,sub}leaf fields according to actual leaf contents')
> Reported-by: Andrew Cooper <andrew.cooper3@citrix.com>
> Signed-off-by: Roger Pau Monn� <roger.pau@citrix.com>
> ---
> Cc: Ian Jackson <iwj@xenproject.org>
> ---
> Regarding release risks:
> 
> This is a partial revert of a commit.  The main issues could be that a
> partial revert could break the build or leave the remaining code in a
> non-working condition.
> 
> Breaking the build will be easily discovered by our automated testing,
> while leaving the remaining code in a broken state is unlikely, as the
> chunks reverted are isolated from the rest of the change in
> 540d911c28.

Release-Acked-by: Ian Jackson <iwj@xenproject.org>

Thanks


From xen-devel-bounces@lists.xenproject.org Wed Oct 27 17:03:13 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Oct 2021 17:03:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217114.376963 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfmJy-00041T-J5; Wed, 27 Oct 2021 17:02:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217114.376963; Wed, 27 Oct 2021 17:02:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfmJy-00041M-Fz; Wed, 27 Oct 2021 17:02:38 +0000
Received: by outflank-mailman (input) for mailman id 217114;
 Wed, 27 Oct 2021 17:02:37 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mfmJx-00041G-5t
 for xen-devel@lists.xenproject.org; Wed, 27 Oct 2021 17:02:37 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mfmJw-00006h-Mq; Wed, 27 Oct 2021 17:02:36 +0000
Received: from [54.239.6.185] (helo=[192.168.29.96])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mfmJw-00006e-Fw; Wed, 27 Oct 2021 17:02:36 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=YGBeAL8WAtYqlWd8ljR5UkBz0tY2psM2CALKMoUIoDI=; b=PuZGRqmKLhLKF0f7EfoeQ7pdj/
	mRS2XQfPg4u1MVQcPLBNEUowH3DOLYnYqIW1mpTeEmT3b7EHNoHoBOSDi2yPFlVg6V9ZUdUwxroPY
	Y+F8U5aMmmZOmqjdIe/bTW9TCdO7PbZZbKgTGJqGbHZPLMAsnDM2P5Mv+ZLZvcxkPflw=;
Message-ID: <01545115-e82e-2a9d-a8e4-da9676080c0f@xen.org>
Date: Wed, 27 Oct 2021 18:02:34 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.2.1
Subject: Re: [patch-4.16] arm/smmuv1,v2: Protect smmu master list with a lock
To: Michal Orzel <michal.orzel@arm.com>, xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, bertrand.marquis@arm.com,
 Ian Jackson <iwj@xenproject.org>
References: <20211026122903.15042-1-michal.orzel@arm.com>
 <e5632a4e-db98-41b4-1045-2b3532c098fa@xen.org>
 <70c30a6c-b779-805e-079a-41bb484894b9@xen.org>
 <cb452c0c-ccde-7798-c403-f972b48a2c46@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <cb452c0c-ccde-7798-c403-f972b48a2c46@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit



On 27/10/2021 11:41, Michal Orzel wrote:
> Hi Julien,

Hi Michal,

> On 26.10.2021 18:56, Julien Grall wrote:
>> Hi,
>>
>> On 26/10/2021 17:28, Julien Grall wrote:
>>> On 26/10/2021 13:29, Michal Orzel wrote:
>>>> If a device is added to SMMUv1/v2 from DT and PCI
>>>> at the same time, there is a concurrent access
>>>> to a smmu master list. This could lead to a
>>>> scenario where one is looking into a list that
>>>> is being modified at the same time. Add a lock
>>>> to prevent this issue.
>>>
>>> Did you intend to say "Hold" rather than "Add"?
>>>
> Yes, this is what I meant. I will change it.
> 
>>>>
>>>> Reuse the existing spinlock arm_smmu_devices_lock
>>>> as it is already protecting find_smmu_master.
>>>>
>>>> ipmmu-smmu and smmuv3 are not impacted by this
>>>> issue as there is no access or modification of
>>>> a global resource during add_device.
>>>>
>>>> Signed-off-by: Michal Orzel <michal.orzel@arm.com>
>>>> ---
>>>> This patch aims for 4.16 release.
>>>> Benefits:
>>>> Remove a bug that could lead to a corruption of the
>>>> smmu master list, which would be very hard to debug.
>>>
>>>   From my understanding, this corruption would only happen with CONFIG_HAS_PCI. At the moment, this is a experimental feature as it is not fully complete.
>>
>> Actually, digging through the code, I noticed that iommu_add_device() assume that it can only be called with platform/DT. Thankfully, AFAICT, the function would return -ENXIO because the fwspec would not be allocated for PCI device.
>>
>> So was this patch tested with additional patch on top?
>>
> The purpose of this patch is to fix the issue that is present and which you thankfully noticed.
> There is still a lot of patches to be added that aim to support PCI passthrough.
> The complete PCI series is tested with SMMU and it works.
> But there is no chance to test this patch standalone as iommu_add_device is not in the correct form for PCI as of now.

Ok. I would suggest to say this is a latent bug so it make clear that 
the patch is more for hardening at the moment.

>>>>    xen/drivers/passthrough/arm/smmu.c | 25 +++++++++++++++++++------
>>>>    1 file changed, 19 insertions(+), 6 deletions(-)
>>>>
>>>> diff --git a/xen/drivers/passthrough/arm/smmu.c b/xen/drivers/passthrough/arm/smmu.c
>>>> index c9dfc4caa0..be62a66a28 100644
>>>> --- a/xen/drivers/passthrough/arm/smmu.c
>>>> +++ b/xen/drivers/passthrough/arm/smmu.c
>>>> @@ -820,21 +820,25 @@ static int arm_smmu_dt_add_device_legacy(struct arm_smmu_device *smmu,
>>>>                         struct device *dev,
>>>>                         struct iommu_fwspec *fwspec)
>>>>    {
>>>> -    int i;
>>>> +    int i, ret;
>>>>        struct arm_smmu_master *master;
>>>>        struct device_node *dev_node = dev_get_dev_node(dev);
>>>> +    spin_lock(&arm_smmu_devices_lock);
>>>>        master = find_smmu_master(smmu, dev_node);
>>>>        if (master) {
>>>>            dev_err(dev,
>>>>                "rejecting multiple registrations for master device %s\n",
>>>>                dev_node->name);
>>>> -        return -EBUSY;
>>>> +        ret = -EBUSY;
>>>> +        goto out_unlock;
>>>>        }
>>>>        master = devm_kzalloc(dev, sizeof(*master), GFP_KERNEL);
>>>> -    if (!master)
>>>> -        return -ENOMEM;
>>>> +    if (!master) {
>>>> +        ret = -ENOMEM;
>>>> +        goto out_unlock;
>>>> +    }
>>>>        master->of_node = dev_node;
>>>>        /* Xen: Let Xen know that the device is protected by an SMMU */
>>>> @@ -846,11 +850,17 @@ static int arm_smmu_dt_add_device_legacy(struct arm_smmu_device *smmu,
>>>>                dev_err(dev,
>>>>                    "stream ID for master device %s greater than maximum allowed (%d)\n",
>>>>                    dev_node->name, smmu->num_mapping_groups);
>>>> -            return -ERANGE;
>>>> +            ret = -ERANGE;
>>>> +            goto out_unlock;
>>>>            }
>>>>            master->cfg.smendx[i] = INVALID_SMENDX;
>>>>        }
>>>> -    return insert_smmu_master(smmu, master);
>>>> +
>>>> +    ret = insert_smmu_master(smmu, master);
>>>> +
>>>> +out_unlock:
>>>> +    spin_unlock(&arm_smmu_devices_lock);
>>>
>>> Please add a newline here.
>>>
> Ok.
> 
>>>> +    return ret;
>>>>    }
>>>>    static int register_smmu_master(struct arm_smmu_device *smmu,
>>>> @@ -2056,7 +2066,10 @@ static int arm_smmu_add_device(struct device *dev)
>>>>        } else {
>>>>            struct arm_smmu_master *master;
>>>> +        spin_lock(&arm_smmu_devices_lock);
>>>>            master = find_smmu_master(smmu, dev->of_node);
>>>> +        spin_unlock(&arm_smmu_devices_lock);
>>>
>>> At the moment, unlocking here is fine because we don't remove the device. However, there are a series to supporting removing a device (see [1]). So I think it would be preferable to unlock after the last use of 'cfg'.
>>>
> Ok. I will move unlocking to the end of this else {} block. I was not aware of the patch you are referring to.

I think the end of the else is still too early. This needs to at least 
be past iommu_group_set_iommudata() because we store cfg.

Potentially, the lock wants to also englobe 
arm_smmu_master_alloc_smes(). So I am wondering whether it would be 
simpler to hold the lock for the whole duration of arm_smmu_add_device() 
(I can see value when we will want to interlock with the remove code).

> 
>>> Looking at the code, I also noticed that the error path is not correct for at least the PCI device and we would leak memory. We also assume that Stream ID == Requester ID. Are both of them in your radar for PCI passthrough?
>>>
> I agree with you. I also noticed it. However this is going to be fixed with the next patch series when Rahul gets back.

Good. Do you have a todo list for PCI passthrough that can be shared?

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Oct 27 17:03:39 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Oct 2021 17:03:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217117.376974 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfmKc-0004Ve-TN; Wed, 27 Oct 2021 17:03:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217117.376974; Wed, 27 Oct 2021 17:03:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfmKc-0004VX-PQ; Wed, 27 Oct 2021 17:03:18 +0000
Received: by outflank-mailman (input) for mailman id 217117;
 Wed, 27 Oct 2021 17:03:17 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <ijackson@chiark.greenend.org.uk>) id 1mfmKb-0004Tq-DS
 for xen-devel@lists.xenproject.org; Wed, 27 Oct 2021 17:03:17 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <ijackson@chiark.greenend.org.uk>) id 1mfmKb-00007H-Ca
 for xen-devel@lists.xenproject.org; Wed, 27 Oct 2021 17:03:17 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <ijackson@chiark.greenend.org.uk>) id 1mfmKb-00008b-B5
 for xen-devel@lists.xenproject.org; Wed, 27 Oct 2021 17:03:17 +0000
Received: from [172.18.45.5] (helo=zealot.relativity.greenend.org.uk)
 by mariner.uk.xensource.com with esmtp (Exim 4.89)
 (envelope-from <ijackson@chiark.greenend.org.uk>)
 id 1mfmKP-0007y4-91; Wed, 27 Oct 2021 18:03:05 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:
	Message-Id:Date:Subject:Cc:To:From;
	bh=xjcD9iqokQD26kS+IVg9w8opmcg5O1wcnBjmb/ZBRFM=; b=Pb/AXsoCZLS37kL9o7+DhUsbGk
	FhY163JzEUpeZ829rXe74UdrYbeORDfg03j0kZhrN3zOpueZn9/gWLpJDHRPqOBv8Co3j/yXdrJbO
	O40Y6eQVmWCWNKAq5kHOToGh4bpRcRJGWANEnTOgcVkfi+cLN4z0H6MH/EIKPlN+TNhs=;
From: Ian Jackson <iwj@xenproject.org>
To: xen-devel@lists.xenproject.org
Cc: Ian Jackson <iwj@xenproject.org>,
	Juergen Gross <jgross@suse.com>
Subject: [OSSTEST PATCH 0/2] ts-xen-build: explicitly enable/disable configure features
Date: Wed, 27 Oct 2021 18:02:54 +0100
Message-Id: <20211027170256.18223-1-iwj@xenproject.org>
X-Mailer: git-send-email 2.20.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

The existing code depends on precisely whether the non-default option
appearing in the configure script is indeed the opposite of the option
we want to pass.

Right now it seems to be working but this seems fragile.  Do it
differently.

I have verified that with current Xen, on arm64:

   + egrep -q -- '--disable-xend|--enable-xend' tools/configure
   + egrep -q -- '--disable-ovmf|--enable-ovmf' tools/configure
   + enable_opts=' --enable-ovmf'
   + egrep -q -- '--disable-qemu-traditional|--enable-qemu-traditional' tools/configure
   + enable_opts=' --enable-ovmf --disable-qemu-traditional'
   + ./configure --sysconfdir=/etc --enable-ovmf --disable-qemu-traditional

and on amd64:

   + egrep -q -- '--disable-xend|--enable-xend' tools/configure
   + egrep -q -- '--disable-ovmf|--enable-ovmf' tools/configure
   + enable_opts=' --enable-ovmf'
   + egrep -q -- '--disable-qemu-traditional|--enable-qemu-traditional' tools/configure
   + enable_opts=' --enable-ovmf --enable-qemu-traditional'
   + ./configure --sysconfdir=/etc --enable-ovmf --enable-qemu-traditional

Juergen, I would appreciate a review from you.  I think I would like
this in osstest production before changing the qemu trad build default
in Xen.

Ian Jackson (2):
  ts-xen-build: Refactor enable/disable configure options
  ts-xen-build: Pass --enable if --disable found in usage, and v.v.

 ts-xen-build | 38 +++++++++++++++++++++++++-------------
 1 file changed, 25 insertions(+), 13 deletions(-)

-- 
2.20.1



From xen-devel-bounces@lists.xenproject.org Wed Oct 27 17:03:39 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Oct 2021 17:03:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217118.376980 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfmKd-0004YO-8S; Wed, 27 Oct 2021 17:03:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217118.376980; Wed, 27 Oct 2021 17:03:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfmKd-0004XK-1B; Wed, 27 Oct 2021 17:03:19 +0000
Received: by outflank-mailman (input) for mailman id 217118;
 Wed, 27 Oct 2021 17:03:17 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <ijackson@chiark.greenend.org.uk>) id 1mfmKb-0004Tv-Fd
 for xen-devel@lists.xenproject.org; Wed, 27 Oct 2021 17:03:17 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <ijackson@chiark.greenend.org.uk>) id 1mfmKb-00007K-Eq
 for xen-devel@lists.xenproject.org; Wed, 27 Oct 2021 17:03:17 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <ijackson@chiark.greenend.org.uk>) id 1mfmKb-00008d-DO
 for xen-devel@lists.xenproject.org; Wed, 27 Oct 2021 17:03:17 +0000
Received: from [172.18.45.5] (helo=zealot.relativity.greenend.org.uk)
 by mariner.uk.xensource.com with esmtp (Exim 4.89)
 (envelope-from <ijackson@chiark.greenend.org.uk>)
 id 1mfmKP-0007y4-MO; Wed, 27 Oct 2021 18:03:05 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:
	References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From;
	bh=aV0xoRJrzvDBM4vBQY4k8X980Lt0ARIHFyS24ypIT/o=; b=gbtSh3DWra8q9KhmBva49ms8mw
	UcCVBcn717j3sVsIheBdSAaUDC00u9qtBU1RIOyGtPq4EzJZI92XOvBITlaZAekvkCZ/5IC57gx09
	eRDP7R3Dtyd8JZzcHymytuAaBHWPWwcSpKpmb/1j/2mGFtMzJW7UWFHWaJtZLNugGljc=;
From: Ian Jackson <iwj@xenproject.org>
To: xen-devel@lists.xenproject.org
Cc: Ian Jackson <iwj@xenproject.org>,
	Juergen Gross <jgross@suse.com>
Subject: [OSSTEST PATCH 1/2] ts-xen-build: Refactor enable/disable configure options
Date: Wed, 27 Oct 2021 18:02:55 +0100
Message-Id: <20211027170256.18223-2-iwj@xenproject.org>
X-Mailer: git-send-email 2.20.1
In-Reply-To: <20211027170256.18223-1-iwj@xenproject.org>
References: <20211027170256.18223-1-iwj@xenproject.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Replace the repeated pattern with a function to generate that code.
No significant functional change.

Signed-off-by: Ian Jackson <iwj@xenproject.org>
CC: Juergen Gross <jgross@suse.com>
---
 ts-xen-build | 30 +++++++++++++++++-------------
 1 file changed, 17 insertions(+), 13 deletions(-)

diff --git a/ts-xen-build b/ts-xen-build
index ccb2aba23..d6f6bfacb 100755
--- a/ts-xen-build
+++ b/ts-xen-build
@@ -142,9 +142,21 @@ END
 }
 
 sub build () {
-    my $xend_opt= $r{enable_xend} =~ m/true/ ? "--enable-xend" : "--disable-xend";
-    my $ovmf_opt= $r{enable_ovmf} =~ m/true/ ? "--enable-ovmf" : "--disable-ovmf";
-    my $qemutrad_opt = $r{arch} =~ m/amd64|i386/ ? "--enable-qemu-traditional" : "--disable-qemu-traditional";
+    my $enable_opts = ''; # shell script to set "enable_opts" shell var
+    my $enable_disable = sub {
+	my ($subdir, $feat, $enable) = @_;
+	my $opt = "--".($enable ? 'enable' : 'disable')."-$feat";
+	$enable_opts .= <<END;
+                if grep -q -- $opt \\
+                               ${subdir}configure ; then
+		    enable_opts="\$enable_opts $opt"
+                fi
+END
+    };
+    
+    $enable_disable->("tools/", "xend", $r{enable_xend} =~ m/true/);
+    $enable_disable->("tools/", "ovmf", $r{enable_ovmf} =~ m/true/);
+    $enable_disable->("tools/", "qemu-traditional", $r{arch} =~ m/amd64|i386/);
 
     my $configure_prefix = $r{cmdprefix_configure} // '';
     my $configure_suffix = $r{cmdsuffix_configure} // '';
@@ -152,17 +164,9 @@ sub build () {
 
     buildcmd_stamped_logged(600, 'xen', 'configure', <<END,<<END,<<END);
             if test -f configure; then
-                if grep -q -- $xend_opt tools/configure ; then
-		    xend=$xend_opt
-                fi
-                if grep -q -- $ovmf_opt tools/configure ; then
-                    ovmf=$ovmf_opt
-                fi
-                if grep -q -- $qemutrad_opt tools/configure ; then
-                    qemutrad=$qemutrad_opt
-                fi
+$enable_opts
 END
-               $configure_prefix ./configure --sysconfdir=/etc \$xend \$ovmf \$qemutrad $configure_suffix @configure_args
+               $configure_prefix ./configure --sysconfdir=/etc \$enable_opts $configure_suffix @configure_args
 END
             fi
 END
-- 
2.20.1



From xen-devel-bounces@lists.xenproject.org Wed Oct 27 17:03:39 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Oct 2021 17:03:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217120.376984 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfmKd-0004e8-Hn; Wed, 27 Oct 2021 17:03:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217120.376984; Wed, 27 Oct 2021 17:03:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfmKd-0004cK-Al; Wed, 27 Oct 2021 17:03:19 +0000
Received: by outflank-mailman (input) for mailman id 217120;
 Wed, 27 Oct 2021 17:03:17 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <ijackson@chiark.greenend.org.uk>) id 1mfmKb-0004U9-Pz
 for xen-devel@lists.xenproject.org; Wed, 27 Oct 2021 17:03:17 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <ijackson@chiark.greenend.org.uk>) id 1mfmKb-00007P-P9
 for xen-devel@lists.xenproject.org; Wed, 27 Oct 2021 17:03:17 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <ijackson@chiark.greenend.org.uk>) id 1mfmKb-00008z-OU
 for xen-devel@lists.xenproject.org; Wed, 27 Oct 2021 17:03:17 +0000
Received: from [172.18.45.5] (helo=zealot.relativity.greenend.org.uk)
 by mariner.uk.xensource.com with esmtp (Exim 4.89)
 (envelope-from <ijackson@chiark.greenend.org.uk>)
 id 1mfmKQ-0007y4-1y; Wed, 27 Oct 2021 18:03:06 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:
	References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From;
	bh=CmW5peRN50Em71b3k175/7jXqoQ/j3qYsI/MZ7encfA=; b=Hw7bbjgBaL5JaLH2jWoVtU43fJ
	zzkGW9yChBzMMC8S3zNosyOqb47qLK5srXP73qL9bhQ0ExLdhTwdp87iE7/BBn7VB9HACZhEIU0/W
	UJ+bezMvuxmegwm2IIPkqkNNUsL5f+IHIra8SUE9MinGjeboGeyF7jQWIKaR7yfYxchY=;
From: Ian Jackson <iwj@xenproject.org>
To: xen-devel@lists.xenproject.org
Cc: Ian Jackson <iwj@xenproject.org>,
	Juergen Gross <jgross@suse.com>
Subject: [OSSTEST PATCH 2/2] ts-xen-build: Pass --enable if --disable found in usage, and v.v.
Date: Wed, 27 Oct 2021 18:02:56 +0100
Message-Id: <20211027170256.18223-3-iwj@xenproject.org>
X-Mailer: git-send-email 2.20.1
In-Reply-To: <20211027170256.18223-1-iwj@xenproject.org>
References: <20211027170256.18223-1-iwj@xenproject.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

The existing code works in practice if the usage message always lists
the non-default, since the unlisted-in-usage options that would be
supported, but are elided, are in any case the default.

But configure might *compute* its defaults.  In which case it will
list only one of them in the usage message.  If the computed default
is not the same as the usual default (the one implied by listing the
opposite in the usage message) we would wrongly not pass the option.

So grep for both enable and disable.

Signed-off-by: Ian Jackson <iwj@xenproject.org>
CC: Juergen Gross <jgross@suse.com>
---
 ts-xen-build | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/ts-xen-build b/ts-xen-build
index d6f6bfacb..c294a51ea 100755
--- a/ts-xen-build
+++ b/ts-xen-build
@@ -142,12 +142,20 @@ END
 }
 
 sub build () {
+    # We want to explicitly enable and disable some things.  But not
+    # all versions of Xen support all configuration options.  We
+    # detect presence of an option by grepping configure.  That finds
+    # them in the usage message.  The usage message has only one of
+    # the two, depending on the usual default.  (Presence of --enable
+    # in the usage output means --disable is supported, and vice
+    # versa.)  So we search for both enable and disable, and if either
+    # is found, we use the one we want.
     my $enable_opts = ''; # shell script to set "enable_opts" shell var
     my $enable_disable = sub {
 	my ($subdir, $feat, $enable) = @_;
 	my $opt = "--".($enable ? 'enable' : 'disable')."-$feat";
 	$enable_opts .= <<END;
-                if grep -q -- $opt \\
+                if egrep -q -- '--disable-$feat|--enable-$feat' \\
                                ${subdir}configure ; then
 		    enable_opts="\$enable_opts $opt"
                 fi
-- 
2.20.1



From xen-devel-bounces@lists.xenproject.org Wed Oct 27 17:07:53 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Oct 2021 17:07:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217142.377006 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfmP0-0006TU-0V; Wed, 27 Oct 2021 17:07:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217142.377006; Wed, 27 Oct 2021 17:07:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfmOz-0006TN-Tl; Wed, 27 Oct 2021 17:07:49 +0000
Received: by outflank-mailman (input) for mailman id 217142;
 Wed, 27 Oct 2021 17:07:48 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mfmOy-0006ST-K2
 for xen-devel@lists.xenproject.org; Wed, 27 Oct 2021 17:07:48 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mfmOy-0000E5-J5
 for xen-devel@lists.xenproject.org; Wed, 27 Oct 2021 17:07:48 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mfmOy-0000Uc-IG
 for xen-devel@lists.xenproject.org; Wed, 27 Oct 2021 17:07:48 +0000
Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89)
 (envelope-from <iwj@xenproject.org>)
 id 1mfmOj-0007zu-Rh; Wed, 27 Oct 2021 18:07:33 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date
	:Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From;
	bh=PAlChERQT9Splk172v3rgtHgay6giGcKCHV4DS1ABJ8=; b=36cZ3uepc1sjCeWx+WaTmUsJf3
	FSdfT3rmnCNJ8Si5K+LaFF03iIznMv3zAmHlYybzxHI0450QAV3xIAx0CaNRH5aDzSOCYTRxMqAZA
	fcRFaMWa8wZf63fjlCKHBmuKbJiFHbTqXwMHh3MAb2tL2xPTFGbbkeOnUSgwKc/qST0w=;
From: Ian Jackson <iwj@xenproject.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <24953.34635.645112.279110@mariner.uk.xensource.com>
Date: Wed, 27 Oct 2021 18:07:23 +0100
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
Cc: Roger Pau =?iso-8859-1?Q?Monn=E9?= <roger.pau@citrix.com>,
    "xen-devel\@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
    "julien\@xen.org" <julien@xen.org>,
    "sstabellini\@kernel.org" <sstabellini@kernel.org>,
    Bertrand  Marquis <bertrand.marquis@arm.com>,
    Rahul Singh <rahul.singh@arm.com>
Subject: Re: [PATCH] xen/arm: fix SBDF calculation for vPCI MMIO handlers
In-Reply-To: <0bbe4d1d-421d-e816-42aa-f43581902a02@epam.com>
References: <20211027082533.1406015-1-andr2000@gmail.com>
	<YXkU+DKYmvwo+kak@Air-de-Roger>
	<0bbe4d1d-421d-e816-42aa-f43581902a02@epam.com>
X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu)

Oleksandr Andrushchenko writes ("Re: [PATCH] xen/arm: fix SBDF calculation for vPCI MMIO handlers"):
> P.S. Sorry I failed to mark this patch as a fix for 4.16 and explain why it is
> a good candidate for 4.16 inclusion

Hello :-).

Um, can you explain what the practical impact is of not taking this
patch for 4.16 ?  As I understand it vpci for ARM is non-functional in
4.16 and this is not expected to change ?  So there would be no
benefit to users, and taking the patch would add small but nonzero
risk ?

I think according to the freeze policy I set this can go in if the
maintainers feel it is a "straightforward bugfix", but provided it
goes in by the end of this coming Friday.

After that it will need a release-ack and right now, unless I am
mistaken (which may well be the case) it can just as well wait ?

Thanks,
Ian.


From xen-devel-bounces@lists.xenproject.org Wed Oct 27 17:36:07 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Oct 2021 17:36:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217149.377018 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfmqB-0001PQ-BU; Wed, 27 Oct 2021 17:35:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217149.377018; Wed, 27 Oct 2021 17:35:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfmqB-0001PJ-7X; Wed, 27 Oct 2021 17:35:55 +0000
Received: by outflank-mailman (input) for mailman id 217149;
 Wed, 27 Oct 2021 17:35:54 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mfmq9-0001PD-VR
 for xen-devel@lists.xenproject.org; Wed, 27 Oct 2021 17:35:53 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mfmq8-0000gG-MY; Wed, 27 Oct 2021 17:35:52 +0000
Received: from [54.239.6.185] (helo=[192.168.29.96])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mfmq8-0002HX-Ei; Wed, 27 Oct 2021 17:35:52 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=Vd+DQmk1rQNBtODXMucWIaaELYAfQaTQwGvyh1TUmws=; b=HJlaAOw0sp6GHztbbVWwtI/wQw
	WW52867gTr2t0SCv2aTJY7m0otaxPoIbGThBUtl0UDTB94CZTNpR1Ow4xn7B6+V8RWUWQCBnc1acf
	IvTS9kOd7YafXkJxMY/CXqUSGFKg9HJ/QdG2+1c0R+XfI08AgJjQNXyFeSs/eWF8zioY=;
Message-ID: <cb7e9ef7-476e-93c3-d3c9-9a9ebc61003d@xen.org>
Date: Wed, 27 Oct 2021 18:35:50 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.2.1
Subject: Re: [PATCH] xen/arm: fix SBDF calculation for vPCI MMIO handlers
To: Oleksandr Andrushchenko <andr2000@gmail.com>,
 xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org, iwj@xenproject.org, bertrand.marquis@arm.com,
 rahul.singh@arm.com,
 Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
References: <20211027082533.1406015-1-andr2000@gmail.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20211027082533.1406015-1-andr2000@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Oleksandr,

On 27/10/2021 09:25, Oleksandr Andrushchenko wrote:
> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> 
> While in vPCI MMIO trap handlers for the guest PCI host bridge it is not
> enough for SBDF translation to simply call VPCI_ECAM_BDF(info->gpa) as
> the base address may not be aligned in the way that the translation
> always work. If not adjusted with respect to the base address it may not be
> able to properly convert SBDF and crashes:
> 
> (XEN) vpci_mmio_read 0000:65:1a.0 reg 8bc gpa e65d08bc

I can't find a printk() that may output this message. Where does this 
comes from?

Anyway, IIUC the guest physical address is 0xe65d08bc which, if I am not 
mistaken, doesn't belong to the range advertised for GUEST_VPCI_ECAM.

IMHO, the stack trace should come from usptream Xen or need some 
information to explain how this was reproduced.

> (XEN) Data Abort Trap. Syndrome=0x6
> (XEN) Walking Hypervisor VA 0x467a28bc on CPU0 via TTBR 0x00000000481d5000
I can understnad that if we don't substract GUEST_VPCI_ECAM, we would 
(in theory) not get the correct BDF. But... I don't understand how this 
would result to a data abort in the hypervisor.

In fact, I think the vPCI code should be resilient enough to not crash 
if we pass the wrong BDF.

When there is a data abort in Xen, you should get a stack trace from 
where this comes from. Can you paste it here?

> 
> Fix this by adjusting the gpa with respect to the host bridge base address
> in a way as it is done for x86.
> 
> Fixes: d59168dc05a5 ("xen/arm: Enable the existing x86 virtual PCI support for ARM")
> 
> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> ---
>   xen/arch/arm/vpci.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/xen/arch/arm/vpci.c b/xen/arch/arm/vpci.c
> index 8f40a0dec6d2..23f45386f4b3 100644
> --- a/xen/arch/arm/vpci.c
> +++ b/xen/arch/arm/vpci.c
> @@ -24,7 +24,7 @@ static int vpci_mmio_read(struct vcpu *v, mmio_info_t *info,
>       unsigned long data;
>   
>       /* We ignore segment part and always handle segment 0 */
> -    sbdf.sbdf = VPCI_ECAM_BDF(info->gpa);
> +    sbdf.sbdf = VPCI_ECAM_BDF(info->gpa - GUEST_VPCI_ECAM_BASE);

Looking at the rest of the rest, it seems that
  1) the issue is latent as the bits 0-27 are clear
  2) this will need to be modified to take into account dom0.

So I would prefer if the base address is passed differently (maybe in 
priv?) from the start. This will avoid extra modification that you 
already plan to have in a follow-up series.

>   
>       if ( vpci_ecam_read(sbdf, ECAM_REG_OFFSET(info->gpa),
>                           1U << info->dabt.size, &data) )
> @@ -44,7 +44,7 @@ static int vpci_mmio_write(struct vcpu *v, mmio_info_t *info,
>       pci_sbdf_t sbdf;
>   
>       /* We ignore segment part and always handle segment 0 */
> -    sbdf.sbdf = VPCI_ECAM_BDF(info->gpa);
> +    sbdf.sbdf = VPCI_ECAM_BDF(info->gpa - GUEST_VPCI_ECAM_BASE);
>   
>       return vpci_ecam_write(sbdf, ECAM_REG_OFFSET(info->gpa),
>                              1U << info->dabt.size, r);
> 

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Oct 27 17:57:09 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Oct 2021 17:57:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217158.377029 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfnAW-0003uT-1a; Wed, 27 Oct 2021 17:56:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217158.377029; Wed, 27 Oct 2021 17:56:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfnAV-0003uM-Uq; Wed, 27 Oct 2021 17:56:55 +0000
Received: by outflank-mailman (input) for mailman id 217158;
 Wed, 27 Oct 2021 17:56:54 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mfnAU-0003uC-Ku; Wed, 27 Oct 2021 17:56:54 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mfnAU-00012R-Gw; Wed, 27 Oct 2021 17:56:54 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mfnAU-0004cK-9n; Wed, 27 Oct 2021 17:56:54 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mfnAU-0006bn-71; Wed, 27 Oct 2021 17:56:54 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=w274TJilkZqbkjOMyvrxwVUGXyxsmeDbhenjI0SbGsM=; b=S+G8e8argXgwpZGQK/jRKdwPqJ
	MKf0g20LWZhVK4iP2Yh7iV1yZ/2EYTo6s9A6z0cuahK7OBx1X08jB2Y12YZIKkMjVuIn9pnsIbY6u
	O8QiZaTcM/Y52hqKhTN1NIUWqY2fE8lNX4SSw2KKCssMG5E4g6fS/0+eV6h9NCUkL9ss=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165899-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 165899: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=9a95d11023ac2f2ee49a2958cf80658270442c42
X-Osstest-Versions-That:
    ovmf=2f6f3329add328103cb0654b71d7b814dc0c9759
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 27 Oct 2021 17:56:54 +0000

flight 165899 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165899/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 9a95d11023ac2f2ee49a2958cf80658270442c42
baseline version:
 ovmf                 2f6f3329add328103cb0654b71d7b814dc0c9759

Last test of basis   165873  2021-10-26 05:40:10 Z    1 days
Testing same since   165899  2021-10-27 12:10:06 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Chasel Chiu <chasel.chiu@intel.com>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   2f6f3329ad..9a95d11023  9a95d11023ac2f2ee49a2958cf80658270442c42 -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Wed Oct 27 18:07:20 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Oct 2021 18:07:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217166.377043 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfnKN-0005WG-Tw; Wed, 27 Oct 2021 18:07:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217166.377043; Wed, 27 Oct 2021 18:07:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfnKN-0005W9-Pm; Wed, 27 Oct 2021 18:07:07 +0000
Received: by outflank-mailman (input) for mailman id 217166;
 Wed, 27 Oct 2021 18:07:06 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mfnKM-0005Vn-ND
 for xen-devel@lists.xenproject.org; Wed, 27 Oct 2021 18:07:06 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mfnKL-0001Iq-FZ; Wed, 27 Oct 2021 18:07:05 +0000
Received: from [54.239.6.185] (helo=[192.168.29.96])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mfnKL-0004Ni-8M; Wed, 27 Oct 2021 18:07:05 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=cSAsLeSYfMVI+YiyzBjCtswDKla10wlmd6gbsDtBuvA=; b=nuBEaXaEIPs2lUHFquNs8ztckm
	OAHbdgJAXv2WGrRrKUQt9kn7WSLP228sN17tnJvPUTg/gbKA+qbjZSyiFYC73VA3Y2VV4xvZvzzdl
	3bHt0jc5vKFJm9I+rXbIGkzNDTNUFvqs3RS0A97ynM7Z2XhoNw18Ome4s/cjEulJ4EYQ=;
Message-ID: <7a97bbef-68a9-8f52-0c93-88d4e84a07fc@xen.org>
Date: Wed, 27 Oct 2021 19:07:03 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.2.1
Subject: Re: [PATCH] xen/arm: do not try to add pci-domain for disabled
 devices
To: Oleksandr Andrushchenko <andr2000@gmail.com>,
 xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org, iwj@xenproject.org, bertrand.marquis@arm.com,
 rahul.singh@arm.com,
 Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
References: <20211027083730.1406947-1-andr2000@gmail.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20211027083730.1406947-1-andr2000@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Oleksandr,

On 27/10/2021 09:37, Oleksandr Andrushchenko wrote:
> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> 
> If a PCI host bridge device is present in the device tree, but is
> disabled, then its PCI host bridge driver was not instantiated.
> This results in the following panic during Xen start:
> 
> (XEN) Device tree generation failed (-22).

It would good to clarify in the commit message where the error is coming 
from. I think this is from pci_get_host_bridge_segment().

> (XEN)
> (XEN) ****************************************
> (XEN) Panic on CPU 0:
> (XEN) Could not set up DOM0 guest OS
> (XEN) ****************************************
> 
> Fix this by not adding linux,pci-domain property for hwdom if it is
> neither available nor device enabled.
 From my reading of the binding [1], the property should be present in 
all the hostbridges if one specify it. IOW, I think the property should 
also be added for hostbridges that are not available.

AFAICT, Linux will ignore hostbridge that are not available. But it 
feels to me we are twisting the rule. So, could we consider to allocate 
an unused number?

> 
> Fixes: 4cfab4425d39 ("xen/arm: Add linux,pci-domain property for hwdom if not available.")
> 
> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> ---
>   xen/arch/arm/domain_build.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
> index 124ade09123a..beeecf84a209 100644
> --- a/xen/arch/arm/domain_build.c
> +++ b/xen/arch/arm/domain_build.c
> @@ -747,7 +747,8 @@ static int __init write_properties(struct domain *d, struct kernel_info *kinfo,
>               return res;
>       }
>   
> -    if ( is_pci_passthrough_enabled() && dt_device_type_is_equal(node, "pci") )
> +    if ( is_pci_passthrough_enabled() && dt_device_type_is_equal(node, "pci") &&
 From my understanding, PCI device described in the DT would also have 
'type="pci"'. So we would also return an error because we don't have a 
corresponding hostbridge.

I think this check should be replaced with device_get_class(node) == 
DEVICE_PCI (confusingly DEVICE_PCI indicates that this is an 
hostbridge...). Although, I would consider to pass the device class as a 
parameter of write_properties() to avoid calling device_class() multiple 
time (it is already used twice in handle_node()).

I am aware this is not a bug introduced by your patch, but I think this 
should be dealt in this patch as well.

> +         dt_device_is_available(node) )

Shouldn't you also check that the hostbridge wasn't passthrough-ed?

>       {
>           if ( !dt_find_property(node, "linux,pci-domain", NULL) )
>           {
> 

Cheers,

[1] Documentation/devicetree/bindings/pci/pci.txt

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Oct 27 18:07:36 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Oct 2021 18:07:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217169.377054 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfnKq-0005ze-4z; Wed, 27 Oct 2021 18:07:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217169.377054; Wed, 27 Oct 2021 18:07:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfnKq-0005zX-1s; Wed, 27 Oct 2021 18:07:36 +0000
Received: by outflank-mailman (input) for mailman id 217169;
 Wed, 27 Oct 2021 18:07:34 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=7jCJ=PP=oracle.com=boris.ostrovsky@srs-us1.protection.inumbo.net>)
 id 1mfnKo-0005z1-9V
 for xen-devel@lists.xenproject.org; Wed, 27 Oct 2021 18:07:34 +0000
Received: from mx0a-00069f02.pphosted.com (unknown [205.220.165.32])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id c171dd4c-3750-11ec-847f-12813bfff9fa;
 Wed, 27 Oct 2021 18:07:33 +0000 (UTC)
Received: from pps.filterd (m0246617.ppops.net [127.0.0.1])
 by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 19RH6xKB023704; 
 Wed, 27 Oct 2021 18:07:29 GMT
Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70])
 by mx0b-00069f02.pphosted.com with ESMTP id 3bx4fj5e5w-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Wed, 27 Oct 2021 18:07:29 +0000
Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1])
 by aserp3020.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 19RI5ZHu085940;
 Wed, 27 Oct 2021 18:06:57 GMT
Received: from nam04-mw2-obe.outbound.protection.outlook.com
 (mail-mw2nam08lp2177.outbound.protection.outlook.com [104.47.73.177])
 by aserp3020.oracle.com with ESMTP id 3bx4gd47jy-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Wed, 27 Oct 2021 18:06:57 +0000
Received: from BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10)
 by MN2PR10MB4111.namprd10.prod.outlook.com (2603:10b6:208:111::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.20; Wed, 27 Oct
 2021 18:06:54 +0000
Received: from BLAPR10MB5009.namprd10.prod.outlook.com
 ([fe80::3c49:46aa:83e1:a329]) by BLAPR10MB5009.namprd10.prod.outlook.com
 ([fe80::3c49:46aa:83e1:a329%6]) with mapi id 15.20.4649.014; Wed, 27 Oct 2021
 18:06:54 +0000
Received: from [10.74.107.92] (138.3.200.28) by
 SA0PR11CA0075.namprd11.prod.outlook.com (2603:10b6:806:d2::20) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4649.14 via Frontend Transport; Wed, 27 Oct 2021 18:06:52 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c171dd4c-3750-11ec-847f-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date :
 subject : to : cc : references : from : in-reply-to : content-type :
 content-transfer-encoding : mime-version; s=corp-2021-07-09;
 bh=qX/EEefklTZfUtSEWanRcHquz74G+d2OJ84qEV0aM0A=;
 b=S2+vXqpCIDGRmWBTLTIxJ+J6dq1E6UcvL2p2uS8FNuc2hjNK7JZe43LJ720+riV9F18T
 wR9K4F3Dsyq+nCaiKoFkVfyi88DIIPGjcQqX7/Nor4E3RWbpfSokEfhggWj2Bb+N7bmK
 dhZQREEcdo/DEz91RQHq57o2z6pvQsON/TCMSGZwNum3r0tRI3xWmrCHgEQqufUvNPyK
 qoMA2n2/AAWekUr6WAoRSwWGiuh+pXG5bYyBQ3O/q12jOSERq4oPrIhiLSyzNl6Dghv/
 bpOBSTIONA2TnXjRTPfuzxgCjNzd5G7NNLL27UHau599xvxnVV5PFF9YogrpllSJhlzs vQ== 
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=F7GMxrxITp3JLZszB98tSPPkOpgaLuVWA1RJFU92s6IPaiwMunRxGpphBEpKS0Qsz84WAtbNeIM1z4BySIkp9ZOsd6Ow6A3FtUeBPq+8MPDpV3Nv0FpwGgOLy5H27GglFt5bTlMe8cuPk2l7b7tqWMwpC+WVEjGGmoQeu1i2JDd+G1SD4+shKt0kW8/AoLff7vbc33sZHXTPgpfldebbrt0I5vpY6PIm4V9bBLyVmq9W8594kphg16RRiHtEcBVRg7UXn8YzCMxKyErnr5H1EPWaqyAJy6c8JIkbiAsE0wS5U0qkeHn+L2EmVPgtki0KOKDt54LdKkUiSAuE7cypkQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=qX/EEefklTZfUtSEWanRcHquz74G+d2OJ84qEV0aM0A=;
 b=Cdt2oNfpcWI2ZSKLq1zwiRpzYV81B00m48mBJj/1hGaojCmmrTOaowH5Dgh9cGgZCe/4pjdSowdwQsPO9Qyo0J29WmuSB3Ktz+4ft2iP5P+GkhZRI3Mh8Qxk8UkkL1iCBm6lzdGQCVvOUNt/XIFIWMiPEjaLyetkaLaOlUMTfksri702tUOZCAvkAqUYwek1qscxo9f8rJxOEd7VZ4J5Mq3uPMMYAoPGtelGA18IQDiI9bXEEV4QtI1khXu13LkNVn1qgFoD6wMwdx+U1SLVs+Vcz3f0y/FAghVqpKvgZBciJiTZ/7PReJCpOOWgaZ2La0aVCgSsDny+61T60JG/Ug==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com;
 dkim=pass header.d=oracle.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=qX/EEefklTZfUtSEWanRcHquz74G+d2OJ84qEV0aM0A=;
 b=zUCl6DtAOF1kiM0i2VCuqpSZa4plF3j+OJ0tNolfNTj4lkncC5jQwRZAcwXbkYY132/yJwKRM3GOSXFGgJIZ3QZTZtHcBbiuK1+OMNqtdZ1Yope2l02r7igopsBKT4j/47UROIVhpNIB4+4FyY40Ezqw2wa/vEEBIXTHcktAV0E=
Authentication-Results: epam.com; dkim=none (message not signed)
 header.d=none;epam.com; dmarc=none action=none header.from=oracle.com;
Message-ID: <3725217f-1195-7972-e669-d4484c1deaae@oracle.com>
Date: Wed, 27 Oct 2021 14:06:49 -0400
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.2.1
Subject: Re: [PATCH v5] xen-pciback: allow compiling on other archs than x86
Content-Language: en-US
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>,
        "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: "jgross@suse.com" <jgross@suse.com>, "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org" <sstabellini@kernel.org>,
        "jbeulich@suse.com" <jbeulich@suse.com>,
        Anastasiia Lukianenko <Anastasiia_Lukianenko@epam.com>
References: <20210928073501.433559-1-andr2000@gmail.com>
 <71ce7c97-1d08-9fdf-b217-53eb914a29a6@oracle.com>
 <a54ab50a-f35c-26b9-3907-20c014a1120a@epam.com>
 <af42493e-ec31-8673-5532-1f0c8275b2c6@oracle.com>
 <c4efe0b5-89de-aac1-6ec5-5f137fa3b9d4@epam.com>
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
In-Reply-To: <c4efe0b5-89de-aac1-6ec5-5f137fa3b9d4@epam.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: SA0PR11CA0075.namprd11.prod.outlook.com
 (2603:10b6:806:d2::20) To BLAPR10MB5009.namprd10.prod.outlook.com
 (2603:10b6:208:321::10)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: a7fb903e-fbd0-4ca5-8c99-08d999748f1a
X-MS-TrafficTypeDiagnostic: MN2PR10MB4111:
X-Microsoft-Antispam-PRVS: 
	<MN2PR10MB4111D0F9B4DB5C0E8572562E8A859@MN2PR10MB4111.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:2733;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 
	6gsV8qBEY5XJY+y8i9zZE0/uPx8Z0r+A2p8AfuwYr8/Z1ozz8p2X1Wd+kjgePrnPswd6GlYt3YMAqkX7bkmjqiKOMOcH9LsHYYAb0UB7QnvXeCeN3iOFQ5/Tnmk/JJqghZRM5o8tkylNYgLRJTQ0zoxPIttOC2UnpxOO3EqtX1RKcyv6uaNsREr3SZsdNz5zGWajTQX55rAKI++fdaGnNJkzYLQWxycpokelXN61XIbJR9KNnta2mr/JklC6aJkUlzFo90Bf6kEYRPBzyLa28/Bx0GliRrPgB8ADr/NAitntWUSS5RlWhiAIiKmR1uK0MaymJ+qIYonMlN7vqr4uvOril8M/g4T0aD5NFFCWb5mbb6Xq91scaCILXRVAsa4Ff55EZOU2EjXzTc+VIRf1tMSjCOAoX0OSCm0nfTsSZAMbbMu10dW7mS6F0gwYhV83TSu5C6bUZNu6t1NkmZlQS6roeRDNLfhV0suna9QmF/YdlIDAIEEwxLyG4oUMYtwVqR6WUKoUs2jjbYAVyTEAS4U+JP8aym9CuuTqm4QhDd8mDMNXOUPVv2JPMCUbKTaHeDUmjVLR0n3aMzIXD2e92T/hWfpqJj1vi3JyiWGIGiZX+sWZhiU9kwGBVUQ/dzYIQSz+J+CUIn4tSuFlQHgE0KAu9eYqsTFBVpWNWdprP9QpBVpF1dbeBjnx22rG6ie+zfjX4i+T+TbGrVLiIOoBq3dlYT3Lmrx5QeiabKoAwjsZqca2ZAzB7RNrX0GFeHH0
X-Forefront-Antispam-Report: 
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB5009.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(4744005)(38100700002)(2906002)(6486002)(26005)(5660300002)(2616005)(66476007)(186003)(956004)(44832011)(8936002)(4326008)(66946007)(54906003)(316002)(66556008)(508600001)(16576012)(8676002)(31686004)(53546011)(110136005)(86362001)(6666004)(31696002)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?K1p1ZXlhbHdsdktUNjByOE56UEVwTS9DRjBiY2NTRkphRmVhRHVVbStxSVVE?=
 =?utf-8?B?Z0JRYXc3bFVuT1FWU0E0VFBoRzNUUTdwc3c0R205WExkQXZxbmlqbUwvWUg4?=
 =?utf-8?B?aDlLc2c4VHRycldQdEk2Z0NIM3E2eXExT2FXY3VPVS9LRFhxZEZyRGJjZThV?=
 =?utf-8?B?andZK0JML0hTTExTOHhIdVBwYTd4dklTSjZxZVhsNGltT0t0ZE9lbkVDSisw?=
 =?utf-8?B?UlY0bTJOVkE0c3phYWIvRWNvZDE4OFVpUVhIK2pCTW41Zmk1ME1XSlk2ejBP?=
 =?utf-8?B?SnlKVzJJKzNQd2YvMjVDYUc5dHo5blEwdDFlWXU2LzhKeEVoakgreTB4Yjk1?=
 =?utf-8?B?ckZpQXgvS2EvcjNtN2tMb2RJeFAxL0Q3WjQ5TTRwMDFsazEyNVVOSjdtK2Fx?=
 =?utf-8?B?d0VnR3NMQUNjNFhzWTdFNGxnRVJkNHhYK2VxMmhwYTBzQW5LSkpwT2xtZk9l?=
 =?utf-8?B?UWx0ckhTNVhua1A1Uzl3dmN5U3loaTFiMGtZU0lPK25XMGkzNjM0QjkrbGVR?=
 =?utf-8?B?a0RSRXRiejR2NElXT3FCckZ0TXJwNGdQczJYaGZ4VWdRUDRVcW5SR1kwTEFC?=
 =?utf-8?B?ZS9KbXlKemFvdWkvbFNEWFZ4VGx0cnVaMGN5S0dHdUdQYkJUVjFFckQ5eUdm?=
 =?utf-8?B?MjhUVnhPYmMvRC9KaE5KZnRBT05LazJUWDQvc3dSWDBiUlVCeXdJbjJQMUZ2?=
 =?utf-8?B?Ukh5YWR0UFY3K0lvUkRaMWdPSDQ5M2k5N0dVN0ZNSVhzNUtkSk1senI1SGxu?=
 =?utf-8?B?bU42cUY2cTNuekhSMkJ1TTBzbXkraExkUFQ2VHRwd1pWRzREcFNLbXB6R3dx?=
 =?utf-8?B?NHdEVmZwQlB2SWxpUVN5RFRyeld4ajRtZVl5U2p6R0Vkcjltd0lKaVBiV0xM?=
 =?utf-8?B?dUdwZHMwelZ5bXpBWjZMeUlBaXRMRjA4TmxTTEs2Q3g3aVpBS3NTMUtEOVpm?=
 =?utf-8?B?a2o2TWFzNnBZUGFjWnNzTElnOVFYbGJMUXEwcnJ2TEFlVExOWTBvb1AwVnBJ?=
 =?utf-8?B?OFJjMTFzbUlsOGpWRWxremVZMUp0Z1c5WFZTVUFKMm9iTWFqZm5CREQ1Vklx?=
 =?utf-8?B?OWtaRUozTTVZeUlnSUpFYmM5ZFRQVHdXekhQR0ViYnNGejRQbFZ4Rk83OGEv?=
 =?utf-8?B?d1ZLb09XcXZ1NmQyNzJQVUo3bjFoZlRyc2xLb1Q2MXU5MzhwdG5NRUhsanY3?=
 =?utf-8?B?NThZU0o0ZG9yUHBJVS9heUp2QmRqQ29sb3JURUI1ZVFRQTk0c1N4TlRTS245?=
 =?utf-8?B?cHZSU0M2MllzUU5pWTI4djBPdjZEZmZTOW5wbFZyZ0o4YW14cmkvRnBSYkh5?=
 =?utf-8?B?cng5cmNuZ3EwelYwaGppZVMvYURwcVBXOWoyUjBQcE1rTlBXTGpEWmRKWWpj?=
 =?utf-8?B?SWZ2cktjMVFEdlhJc2E1TEpldjJaRlpKNWNJbHNpTEZaMlFUU2dubm1ROHhQ?=
 =?utf-8?B?RVFOMThoZFl3SFN6TmNtZmpoZmlIWjZsNWhZZ21zRjBjV2JQRUNXTCs3bU5n?=
 =?utf-8?B?TnpXWTdrSjJQV3UxSGxyRE1OdWtzM3UzS0hjSk4rQWlnanRxc2JjYWZUYXNn?=
 =?utf-8?B?djhOM2dXVUt4K1crU2M1UlJka2ZpcmJROVc1ZVFESWpzNTNlZnZNNnN1MlJY?=
 =?utf-8?B?ZUw5RlhvQ2tqU1grVFJHVjZYQ3p6TnhXaUYwS0w2MzZ6VmIralMyanNIMmk0?=
 =?utf-8?B?bUxWa0UzQWlGWDB6MzZaajZBU3M4aElIZG8zenYxZlBkR3ltTjE1cDRvOHBX?=
 =?utf-8?B?bDgzNmJKTjRqQTRZMTYzODRBZCt2cm4vcDFVV0dSeHA4bFNhTTh4b05Hbnkr?=
 =?utf-8?B?Skx2YkxHNGw2RkJiMkgrVWxNbnFDUkordG8yVEhGVE5kU01hZkIzY3hlRHh4?=
 =?utf-8?B?em13dmNZcW9UYWMyVnVLTXM4dVZXVCt3SzZtWm1IVXFXMFNPT3pGb0VLaDEr?=
 =?utf-8?B?bmsxTDhrZDlKSmY4Y0Z0bytnNEdma3JEa25iY04rVlZ2RVNvOWJ5TjNTeDBO?=
 =?utf-8?B?eElCeUFCMnE3ejN1WnhCYld3TjhVaWRHamVvMmdDUnhTZkpKNHdONHlwMjdO?=
 =?utf-8?B?QjhBazdveU5WM0lmYUpBRzU1dEJVRllwWDRTYUJMV3NtdThlWjhjMURzWEpp?=
 =?utf-8?B?Wk42cUtKRjZ2TEE5dCtuWFcwVlF2NUFzdGxsSWRMVUV4a2lGeDVGYUdGYlU0?=
 =?utf-8?B?Y3BZdzMvcTRYaXBlZ0RTbGRXdUptbmRvTUFLMkIyOFJqaklkR3pMV3dzTVJ0?=
 =?utf-8?Q?+NZ3OCgawQar67D8ymYQb4W1sR/UvurQh0A2uXFkTg=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a7fb903e-fbd0-4ca5-8c99-08d999748f1a
X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Oct 2021 18:06:54.7844
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: NdrmVOBz27clLvf1H3gX68QBr6tA177KrWOqQOzSE3Z8FTtFsf5galyCh9LtrEGsvQke5cW6KIaPpJyLJYcxlNQPisWm7tvDzOwZNiezosk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR10MB4111
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10150 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 mlxlogscore=951
 bulkscore=0 phishscore=0 mlxscore=0 spamscore=0 adultscore=0
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2110270102
X-Proofpoint-ORIG-GUID: GPTz2k5lFmcBk5_0zVGQZm7i8KBwG5xy
X-Proofpoint-GUID: GPTz2k5lFmcBk5_0zVGQZm7i8KBwG5xy


On 10/27/21 10:49 AM, Oleksandr Andrushchenko wrote:
>
> On 27.10.21 17:46, Boris Ostrovsky wrote:
>> On 10/27/21 10:08 AM, Oleksandr Andrushchenko wrote:
>>> Hi, Boris!
>>>
>>> On 27.10.21 15:59, Boris Ostrovsky wrote:
>>>> Can you please rebase this on top of 5.15-rc7? There is a bunch of conflicts due to cae7d81a3730dfe08623f8c1083230c8d0987639.
>>>>
>>> I'll try to do that ASAP (what is the deadline for that?)
>>
>> If you could do in the next few days it would be great. I expect next merge window will open on Sunday.
> Sure, I'll try to send it tomorrow.
> I assume I can keep R-b's after the rebase (this is going to be v6 of the patch)?


I don't see why not.


-boris



From xen-devel-bounces@lists.xenproject.org Wed Oct 27 18:14:02 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Oct 2021 18:14:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217179.377064 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfnQv-0007a1-Ru; Wed, 27 Oct 2021 18:13:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217179.377064; Wed, 27 Oct 2021 18:13:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfnQv-0007Zu-P4; Wed, 27 Oct 2021 18:13:53 +0000
Received: by outflank-mailman (input) for mailman id 217179;
 Wed, 27 Oct 2021 18:13:53 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=7RMc=PP=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1mfnQv-0007Zo-8t
 for xen-devel@lists.xenproject.org; Wed, 27 Oct 2021 18:13:53 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id f81640f5-4f05-4764-a282-53a70df5cc69;
 Wed, 27 Oct 2021 18:13:52 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id 2585F6109F;
 Wed, 27 Oct 2021 18:13:51 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f81640f5-4f05-4764-a282-53a70df5cc69
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1635358431;
	bh=sqvOweKnJ6e1tg/Hui1lqFbtUDaNPrM9lRPPHRa077A=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=TSMJz9UFUC9yYsoGskP0/mJq1qWpVVLGxYK6vxdIHtOQk8ORnJ02/OrCNeP0e7Zw7
	 5g9fcBoX1QYQUbCfqR1rsA/YPkvDNGugAqn1TPYT4oS3FfPmk57P/LyZluj6R29i2g
	 mNLr+VFu+Ovw+dVfUyrz6e6PsHphdUB+2nR08aL9AK3rFGxVhL/GPOu/gcpa5bnfd+
	 I+bx7qxO6YBmtjqIkvFKl6BO1yOuSr3rsGLXvXVGfHFagEvy4yPbqKaWejP9dRW3sG
	 lznLGd7R9TLW7oaEa4YcmUoDsCsZyD/QnOE8NMnEt8hXtg+T44hxp1GcTwqdJ8eRBq
	 mI1iswY2ciFrw==
Date: Wed, 27 Oct 2021 11:13:49 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Bertrand Marquis <Bertrand.Marquis@arm.com>
cc: Stefano Stabellini <sstabellini@kernel.org>, 
    George Dunlap <George.Dunlap@citrix.com>, 
    "dunlapg@umich.edu" <dunlapg@umich.edu>, 
    "roger.pau@citrix.com" <roger.pau@citrix.com>, 
    "jbeulich@suse.com" <jbeulich@suse.com>, 
    "committers@xenproject.org" <committers@xenproject.org>, 
    "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v2] governance: communication channels
In-Reply-To: <F3071594-3327-40B4-A0C2-D3EAD591DF74@arm.com>
Message-ID: <alpine.DEB.2.21.2110271111150.11563@sstabellini-ThinkPad-T480s>
References: <alpine.DEB.2.21.2110251845500.4586@sstabellini-ThinkPad-T480s> <F3071594-3327-40B4-A0C2-D3EAD591DF74@arm.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Tue, 26 Oct 2021, Bertrand Marquis wrote:
> > On 26 Oct 2021, at 02:46, Stefano Stabellini <sstabellini@kernel.org> wrote:
> > 
> > Clarify that xen-devel is the only official communication channel.
> > 
> > Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>
> Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>

Thanks Bertrand


> Just for my knowledge, where is this file stored (as it is not in xen.git) ?

The governance is here:

https://xenbits.xenproject.org/governance/
https://xenbits.xen.org/gitweb/?p=governance.git;a=tree


From xen-devel-bounces@lists.xenproject.org Wed Oct 27 18:17:35 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Oct 2021 18:17:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217185.377076 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfnUO-0008Dq-Dc; Wed, 27 Oct 2021 18:17:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217185.377076; Wed, 27 Oct 2021 18:17:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfnUO-0008Dj-8s; Wed, 27 Oct 2021 18:17:28 +0000
Received: by outflank-mailman (input) for mailman id 217185;
 Wed, 27 Oct 2021 18:17:27 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mfnUN-0008DZ-ID; Wed, 27 Oct 2021 18:17:27 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mfnUN-0001Um-AS; Wed, 27 Oct 2021 18:17:27 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mfnUN-0005YI-2Z; Wed, 27 Oct 2021 18:17:27 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mfnUN-0005YU-27; Wed, 27 Oct 2021 18:17:27 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Message-Id:Subject:To;
	bh=5glbjRsyfWyGz8pLj3ECLGnoUzFFuYHmOEd/dqY5bNU=; b=mA8l+13Eh8ey/8/y/Sfo2nPRO1
	zv6zTEVp800S1cIxE5PBMfJBCA0gmeRDN5KtttYp4qCdyHw6DW1OXBALUiIG8rhLZvsxmdjg0E6iE
	STfc3tzyxqm1Bynv0yF2FrzQYu6K5xxlIdbprT9g5wMQ5Uib6x/VluA5lPGqDPUKRBiw=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Subject: [qemu-mainline bisection] complete build-armhf
Message-Id: <E1mfnUN-0005YU-27@osstest.test-lab.xenproject.org>
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 27 Oct 2021 18:17:27 +0000

branch xen-unstable
xenbranch xen-unstable
job build-armhf
testid xen-build

Tree: ovmf git://xenbits.xen.org/osstest/ovmf.git
Tree: qemuu git://git.qemu.org/qemu.git
Tree: seabios git://xenbits.xen.org/osstest/seabios.git
Tree: xen git://xenbits.xen.org/xen.git

*** Found and reproduced problem changeset ***

  Bug is in tree:  qemuu git://git.qemu.org/qemu.git
  Bug introduced:  e741aff0f43343d6d91242fee1072fee376d5cce
  Bug not present: 685db13a38f7599fabd353382ff65d3c244ea641
  Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/165902/


  commit e741aff0f43343d6d91242fee1072fee376d5cce
  Author: Igor Mammedov <imammedo@redhat.com>
  Date:   Thu Sep 2 07:35:38 2021 -0400
  
      tests: qtest: add qtest_has_accel() to check if tested binary supports accelerator
      
      Currently it is not possible to create tests that have KVM as a hard
      requirement on a host that doesn't support KVM for tested target
      binary (modulo going through the trouble of compiling out
      the offending test case).
      
      Following scenario makes test fail when it's run on non x86 host:
        qemu-system-x86_64 -enable-kvm -M q35,kernel-irqchip=on -smp 1,maxcpus=288
      
      This patch introduces qtest_has_accel() to let users check if accel is
      available in advance and avoid executing non run-able test-cases.
      
      It implements detection of TCG and KVM only, the rest could be
      added later on, when we actually start testing them in qtest.
      
      Signed-off-by: Igor Mammedov <imammedo@redhat.com>
      Message-Id: <20210902113551.461632-3-imammedo@redhat.com>
      Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
      Signed-off-by: Michael S. Tsirkin <mst@redhat.com>


For bisection revision-tuple graph see:
   http://logs.test-lab.xenproject.org/osstest/results/bisect/qemu-mainline/build-armhf.xen-build.html
Revision IDs in each graph node refer, respectively, to the Trees above.

----------------------------------------
Running cs-bisection-step --graph-out=/home/logs/results/bisect/qemu-mainline/build-armhf.xen-build --summary-out=tmp/165902.bisection-summary --basis-template=165682 --blessings=real,real-bisect,real-retry qemu-mainline build-armhf xen-build
Searching for failure / basis pass:
 165889 fail [host=cubietruck-braque] / 165682 ok.
Failure / basis pass flights: 165889 / 165682
Tree: ovmf git://xenbits.xen.org/osstest/ovmf.git
Tree: qemuu git://git.qemu.org/qemu.git
Tree: seabios git://xenbits.xen.org/osstest/seabios.git
Tree: xen git://xenbits.xen.org/xen.git
Latest 2f6f3329add328103cb0654b71d7b814dc0c9759 931ce30859176f0f7daac6bac255dae5eb21284e 64f37cc530f144e53c190c9e8209a51b58fd5c43 b0fce57a6a491c120f2554ad7cc9a0c43ee5defa
Basis pass 90246a6d9f6fda3536d042d02867123caabe3aaa 50352cce138ef3b30c1cda28a4df68fff5da3202 64f37cc530f144e53c190c9e8209a51b58fd5c43 c11b8d25fbe9c0155e91409594ea6701008409ed
Generating revisions with ./adhoc-revtuple-generator  git://xenbits.xen.org/osstest/ovmf.git#90246a6d9f6fda3536d042d02867123caabe3aaa-2f6f3329add328103cb0654b71d7b814dc0c9759 git://git.qemu.org/qemu.git#50352cce138ef3b30c1cda28a4df68fff5da3202-931ce30859176f0f7daac6bac255dae5eb21284e git://xenbits.xen.org/osstest/seabios.git#64f37cc530f144e53c190c9e8209a51b58fd5c43-64f37cc530f144e53c190c9e8209a51b58fd5c43 git://xenbits.xen.org/xen.git#c11b8d25fbe9c0155e91409594ea6701008409ed-b0fce57a6a491c120f25\
 54ad7cc9a0c43ee5defa
>From git://cache:9419/git://xenbits.xen.org/osstest/ovmf
   2f6f3329ad..9a95d11023  xen-tested-master -> origin/xen-tested-master
>From git://cache:9419/git://git.qemu.org/qemu
 + 66b095c4fe...5c49c6c241 staging    -> origin/staging  (forced update)
Loaded 34953 nodes in revision graph
Searching for test results:
 165682 pass 90246a6d9f6fda3536d042d02867123caabe3aaa 50352cce138ef3b30c1cda28a4df68fff5da3202 64f37cc530f144e53c190c9e8209a51b58fd5c43 c11b8d25fbe9c0155e91409594ea6701008409ed
 165694 [host=cubietruck-gleizes]
 165703 [host=cubietruck-picasso]
 165721 fail irrelevant
 165726 fail irrelevant
 165753 fail irrelevant
 165790 [host=cubietruck-gleizes]
 165799 fail bd5ec03d87cacc5be2de4284b092aafd4ac4eb31 660efed8b37aedec9b5fcc555da1f88f7d12c98a 64f37cc530f144e53c190c9e8209a51b58fd5c43 23ec1ebc8acbfd2bf06f6085a776f0db923f9fa9
 165817 [host=cubietruck-gleizes]
 165823 [host=cubietruck-gleizes]
 165834 [host=cubietruck-gleizes]
 165844 [host=cubietruck-gleizes]
 165846 [host=cubietruck-gleizes]
 165847 [host=cubietruck-gleizes]
 165849 [host=cubietruck-gleizes]
 165851 [host=cubietruck-gleizes]
 165845 [host=cubietruck-gleizes]
 165854 [host=cubietruck-gleizes]
 165856 [host=cubietruck-gleizes]
 165859 [host=cubietruck-gleizes]
 165860 [host=cubietruck-gleizes]
 165855 fail 8b76f235340922a6d293bff05978ba57d3b498e1 c5b2f559814104f4145f8bc310f4d33c7ead8f49 64f37cc530f144e53c190c9e8209a51b58fd5c43 23ec1ebc8acbfd2bf06f6085a776f0db923f9fa9
 165865 [host=cubietruck-gleizes]
 165867 pass 90246a6d9f6fda3536d042d02867123caabe3aaa 50352cce138ef3b30c1cda28a4df68fff5da3202 64f37cc530f144e53c190c9e8209a51b58fd5c43 c11b8d25fbe9c0155e91409594ea6701008409ed
 165869 fail 8b76f235340922a6d293bff05978ba57d3b498e1 c5b2f559814104f4145f8bc310f4d33c7ead8f49 64f37cc530f144e53c190c9e8209a51b58fd5c43 23ec1ebc8acbfd2bf06f6085a776f0db923f9fa9
 165870 fail bd5ec03d87cacc5be2de4284b092aafd4ac4eb31 1dafe7656a9c2770065e91208edd4c073f5f98a9 64f37cc530f144e53c190c9e8209a51b58fd5c43 23ec1ebc8acbfd2bf06f6085a776f0db923f9fa9
 165872 fail 2f286930a8280f4d817460020110009938f695b6 6f9e8515c106650fbba7222c8f66234c8546c025 64f37cc530f144e53c190c9e8209a51b58fd5c43 98f60e5de00baf650c574c9352bb19aedb082dea
 165874 fail 4fdf843c75d297fe892f989009b3d3e397ccfd55 402378407dbdce79ce745a13f5c84815f929cfdd 64f37cc530f144e53c190c9e8209a51b58fd5c43 6809998c5f8f1d2e26ac9e867af8ac71e7a66cf2
 165866 fail 8b76f235340922a6d293bff05978ba57d3b498e1 c5b2f559814104f4145f8bc310f4d33c7ead8f49 64f37cc530f144e53c190c9e8209a51b58fd5c43 23ec1ebc8acbfd2bf06f6085a776f0db923f9fa9
 165876 fail 37a33f02aa1ab89f392da7d06ec3578fda1b6182 220ffd949bf2c157665905f7744bdbf201333e1f 64f37cc530f144e53c190c9e8209a51b58fd5c43 6809998c5f8f1d2e26ac9e867af8ac71e7a66cf2
 165878 fail 37a33f02aa1ab89f392da7d06ec3578fda1b6182 e741aff0f43343d6d91242fee1072fee376d5cce 64f37cc530f144e53c190c9e8209a51b58fd5c43 6809998c5f8f1d2e26ac9e867af8ac71e7a66cf2
 165879 pass 90246a6d9f6fda3536d042d02867123caabe3aaa 50352cce138ef3b30c1cda28a4df68fff5da3202 64f37cc530f144e53c190c9e8209a51b58fd5c43 5e97b97bc254b0ee23f701a4d5a317853136d288
 165881 pass 90246a6d9f6fda3536d042d02867123caabe3aaa 50352cce138ef3b30c1cda28a4df68fff5da3202 64f37cc530f144e53c190c9e8209a51b58fd5c43 b7635526acffbe4ad8ad16fd92812c57742e54c2
 165877 fail b80c17b62d989ec00e528c6307c726ce6800bcc4 c5b2f559814104f4145f8bc310f4d33c7ead8f49 64f37cc530f144e53c190c9e8209a51b58fd5c43 b0fce57a6a491c120f2554ad7cc9a0c43ee5defa
 165882 pass 37a33f02aa1ab89f392da7d06ec3578fda1b6182 50352cce138ef3b30c1cda28a4df68fff5da3202 64f37cc530f144e53c190c9e8209a51b58fd5c43 6809998c5f8f1d2e26ac9e867af8ac71e7a66cf2
 165884 pass 37a33f02aa1ab89f392da7d06ec3578fda1b6182 685db13a38f7599fabd353382ff65d3c244ea641 64f37cc530f144e53c190c9e8209a51b58fd5c43 6809998c5f8f1d2e26ac9e867af8ac71e7a66cf2
 165886 fail 37a33f02aa1ab89f392da7d06ec3578fda1b6182 e741aff0f43343d6d91242fee1072fee376d5cce 64f37cc530f144e53c190c9e8209a51b58fd5c43 6809998c5f8f1d2e26ac9e867af8ac71e7a66cf2
 165883 fail 2f6f3329add328103cb0654b71d7b814dc0c9759 931ce30859176f0f7daac6bac255dae5eb21284e 64f37cc530f144e53c190c9e8209a51b58fd5c43 b0fce57a6a491c120f2554ad7cc9a0c43ee5defa
 165888 pass 37a33f02aa1ab89f392da7d06ec3578fda1b6182 685db13a38f7599fabd353382ff65d3c244ea641 64f37cc530f144e53c190c9e8209a51b58fd5c43 6809998c5f8f1d2e26ac9e867af8ac71e7a66cf2
 165892 pass 90246a6d9f6fda3536d042d02867123caabe3aaa 50352cce138ef3b30c1cda28a4df68fff5da3202 64f37cc530f144e53c190c9e8209a51b58fd5c43 c11b8d25fbe9c0155e91409594ea6701008409ed
 165894 fail 2f6f3329add328103cb0654b71d7b814dc0c9759 931ce30859176f0f7daac6bac255dae5eb21284e 64f37cc530f144e53c190c9e8209a51b58fd5c43 b0fce57a6a491c120f2554ad7cc9a0c43ee5defa
 165898 fail 37a33f02aa1ab89f392da7d06ec3578fda1b6182 e741aff0f43343d6d91242fee1072fee376d5cce 64f37cc530f144e53c190c9e8209a51b58fd5c43 6809998c5f8f1d2e26ac9e867af8ac71e7a66cf2
 165889 fail 2f6f3329add328103cb0654b71d7b814dc0c9759 931ce30859176f0f7daac6bac255dae5eb21284e 64f37cc530f144e53c190c9e8209a51b58fd5c43 b0fce57a6a491c120f2554ad7cc9a0c43ee5defa
 165900 pass 37a33f02aa1ab89f392da7d06ec3578fda1b6182 685db13a38f7599fabd353382ff65d3c244ea641 64f37cc530f144e53c190c9e8209a51b58fd5c43 6809998c5f8f1d2e26ac9e867af8ac71e7a66cf2
 165902 fail 37a33f02aa1ab89f392da7d06ec3578fda1b6182 e741aff0f43343d6d91242fee1072fee376d5cce 64f37cc530f144e53c190c9e8209a51b58fd5c43 6809998c5f8f1d2e26ac9e867af8ac71e7a66cf2
Searching for interesting versions
 Result found: flight 165682 (pass), for basis pass
 Result found: flight 165883 (fail), for basis failure
 Repro found: flight 165892 (pass), for basis pass
 Repro found: flight 165894 (fail), for basis failure
 0 revisions at 37a33f02aa1ab89f392da7d06ec3578fda1b6182 685db13a38f7599fabd353382ff65d3c244ea641 64f37cc530f144e53c190c9e8209a51b58fd5c43 6809998c5f8f1d2e26ac9e867af8ac71e7a66cf2
No revisions left to test, checking graph state.
 Result found: flight 165884 (pass), for last pass
 Result found: flight 165886 (fail), for first failure
 Repro found: flight 165888 (pass), for last pass
 Repro found: flight 165898 (fail), for first failure
 Repro found: flight 165900 (pass), for last pass
 Repro found: flight 165902 (fail), for first failure

*** Found and reproduced problem changeset ***

  Bug is in tree:  qemuu git://git.qemu.org/qemu.git
  Bug introduced:  e741aff0f43343d6d91242fee1072fee376d5cce
  Bug not present: 685db13a38f7599fabd353382ff65d3c244ea641
  Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/165902/


  commit e741aff0f43343d6d91242fee1072fee376d5cce
  Author: Igor Mammedov <imammedo@redhat.com>
  Date:   Thu Sep 2 07:35:38 2021 -0400
  
      tests: qtest: add qtest_has_accel() to check if tested binary supports accelerator
      
      Currently it is not possible to create tests that have KVM as a hard
      requirement on a host that doesn't support KVM for tested target
      binary (modulo going through the trouble of compiling out
      the offending test case).
      
      Following scenario makes test fail when it's run on non x86 host:
        qemu-system-x86_64 -enable-kvm -M q35,kernel-irqchip=on -smp 1,maxcpus=288
      
      This patch introduces qtest_has_accel() to let users check if accel is
      available in advance and avoid executing non run-able test-cases.
      
      It implements detection of TCG and KVM only, the rest could be
      added later on, when we actually start testing them in qtest.
      
      Signed-off-by: Igor Mammedov <imammedo@redhat.com>
      Message-Id: <20210902113551.461632-3-imammedo@redhat.com>
      Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
      Signed-off-by: Michael S. Tsirkin <mst@redhat.com>

Revision graph left in /home/logs/results/bisect/qemu-mainline/build-armhf.xen-build.{dot,ps,png,html,svg}.
----------------------------------------
165902: tolerable ALL FAIL

flight 165902 qemu-mainline real-bisect [real]
http://logs.test-lab.xenproject.org/osstest/logs/165902/

Failures :-/ but no regressions.

Tests which did not succeed,
including tests which could not be run:
 build-armhf                   6 xen-build               fail baseline untested


jobs:
 build-armhf                                                  fail    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary



From xen-devel-bounces@lists.xenproject.org Wed Oct 27 20:08:02 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Oct 2021 20:08:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217198.377090 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfpCp-0001xy-EY; Wed, 27 Oct 2021 20:07:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217198.377090; Wed, 27 Oct 2021 20:07:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfpCp-0001xr-B1; Wed, 27 Oct 2021 20:07:27 +0000
Received: by outflank-mailman (input) for mailman id 217198;
 Wed, 27 Oct 2021 20:07:25 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=uMsA=PP=citrix.com=Andrew.Cooper3@srs-us1.protection.inumbo.net>)
 id 1mfpCn-0001xl-N5
 for xen-devel@lists.xenproject.org; Wed, 27 Oct 2021 20:07:25 +0000
Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 7fd9d3ba-3761-11ec-8484-12813bfff9fa;
 Wed, 27 Oct 2021 20:07:24 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7fd9d3ba-3761-11ec-8484-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1635365244;
  h=from:to:cc:subject:date:message-id:mime-version:
   content-transfer-encoding;
  bh=V33m3v63LC16O+vDvWblrhoA4NK0Cb2mmG8ztXFT6fo=;
  b=T2hUGOEmjyod3q4D91ozKKseDFumI7WNr+K8lFrjL6Ra9+w5RuE3up/Z
   YETTGZmbC/2o1LXppltrK+ba1OLRbcDp8ncKYuFe/tqE4U6qKJcB61mXm
   8NcMAFmZP+AMW26aPcSrnHAMl3X2DKyyvG30lWEZ/sNM2Unid+wq9mQ7K
   8=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: BbQZr1aRdwIkuFaquRS7cSViqFtnf+JMrqL/1ynUsz42973fNPxg/r+H4Pwjs8itO3LMt2kCPF
 /nHD07j70Ue0yXmnvdK6cipIA7y8c2q0dpzCAv1qu+1/l0rMqEdezpT5B4V50oIx7A8G54p6hm
 TxyCtMUMUMEpLxy3t7fHas7oHFy5lAxylikD1yFDRnUKFw2fl+fAotJfSF1uRBtNCoxvk4Qxcg
 s5mVzYsXRNHg7xO7yWLBOwalOIVdyh2ZgYEjuyOy65L+h/7csxLbOjRS9aGaSWFxLNYIUIMBqG
 pKAjOvt7dZ1wtCs+EOShxPko
X-SBRS: 5.1
X-MesageID: 56878025
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:1nTlQ68AZdzE8JI8GSZ+DrUDZHmTJUtcMsCJ2f8bNWPcYEJGY0x3n
 2seWTvUOPqJM2Gjet1wOY3go0wGscCDyNdlQAtl+S48E34SpcT7XtnIdU2Y0wF+jyHgoOCLy
 +1EN7Es+ehtFie0Si9AttENlFEkvU2ybuOU5NXsZ2YhGmeIdA970Ug6wrZj3dYy6TSEK1jlV
 e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH
 I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPgp7
 dpvs7/gWT1yI7Hnkb8/aUhcMAhhaPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us
 6ZCcXZUM07F17neLLGTE4GAguwKKsXxMZxZkXZn1TzDVt4tQIzZQrWM7thdtNs1rp0QTamOP
 5BEAdZpRBXqTRRtYkwcMZlgk+H4v3XOXRhRo13A8MLb5ECMlVcsgdABKuH9ZdiiVchT2EGCq
 Qru/nv7KgEXMsSFzjiI+W7qgfXA9QvrVYRXGLCm+/pChFyI2ndVGBAQTUG8o/Sylgi5Qd03A
 24+9zcqrKMy3Fe2VdS7VBq9yENopTZFBYAWSbdjrljQlOyEuG51G1ToUBYZTdMEsuxmVQZxy
 0OilojLP21rk5SKHCf1GqivkRu+Pi0cLGknbCACTBcY79SLnLzfni4jXf44T/br1oyd9SXYh
 mnQ9nBn1up7Ydsjjv3jpTj6bySQSo8lp+Lfzj7cWX659UtHbYqhap3ABbPzvKsYctjxorVsu
 hE5dymiAAImUc7leM+lGrxl8FSVCxCtamW0bblHRMBJythV0yT/Fb28GRknTKuTDu4KeCXyf
 GjYsh5L6ZlYMROCNPEsPtjuUJRwlfG4SLwJs8w4iPIUOvCdkyfcpUlTibO4hTixwCDAb4lmY
 f93jvpA/V5FUP86nVJats8W0KMxxzBW+I8gbcuT8vhT6pLHPCT9Ye5caDOmN7llhIvZ8FS92
 4sObKOilkQAONASlwGKqOb/23hRdiNlbX03wuQKHtO+zv1OQzB8VaWJm+p9K+SIXc19z4/1w
 510YWcAoHKXuJENAV/ihqlLZOy9UJBhg2g8OCBwb1+k12J6OdSk7bsFdotxdr4irbQxwflxR
 vgDWsOBHvUQFWiXp2VDNcHw/N54aRCmpQOSJC75MjIxSIFtGl7S8dj+cwqxqCRXVnirtdEzq
 qGL3x/ARcZRXBxrCcvbMar9z164sXUHtvh1Wk/EfotadEn2qdA4IC3tlP4nZcoLLEyblDed0
 g+XBzYepPXM/NBpoIWY2/jcot7wQeVkH0dcE23K1pqMNHHXrji53ItNcOeUZjSBBmn6z7qvO
 LdOxPbmPfxZwFsT69hgE6xmxL4V7sf0o+MI1RxtGXjGYgj5Cr5kJXXaj8BDurcUm+1csAqyH
 EmO5sNbKfOCP8a8SAwdIw8sb+Ki0/AIm2aNsaRpcRuivCInrqCaVUhyPgWXjH0PJbR4B4op3
 OM9tZNE8Ae4kBcrbo6Lgy08G75g9ZDcv3HLbq0nPbI=
IronPort-HdrOrdr: A9a23:DmuOPa/9YiIiu6FsAShuk+DWI+orL9Y04lQ7vn2YSXRuE/Bw8P
 re+sjztCWE7wr5N0tQ+uxoVJPufZq+z+8Q3WByB8bBYOCOggLBR+sOgbcKqweQYhEWndQ86U
 4PScZD4aXLfD1Hsfo=
X-IronPort-AV: E=Sophos;i="5.87,187,1631592000"; 
   d="scan'208";a="56878025"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Jan Beulich
	<JBeulich@suse.com>, =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?=
	<roger.pau@citrix.com>, Wei Liu <wl@xen.org>, Ian Jackson
	<iwj@xenproject.org>
Subject: [PATCH] x86/passthrough:  Fix hvm_gsi_eoi() build with GCC 12
Date: Wed, 27 Oct 2021 21:07:13 +0100
Message-ID: <20211027200713.22625-1-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

GCC master (nearly version 12) complains:

  hvm.c: In function 'hvm_gsi_eoi':
  hvm.c:905:10: error: the comparison will always evaluate as 'true' for the
  address of 'dpci' will never be NULL [-Werror=address]
    905 |     if ( !pirq_dpci(pirq) )
        |          ^
  In file included from /local/xen.git/xen/include/xen/irq.h:73,
                   from /local/xen.git/xen/include/xen/pci.h:13,
                   from /local/xen.git/xen/include/asm/hvm/io.h:22,
                   from /local/xen.git/xen/include/asm/hvm/domain.h:27,
                   from /local/xen.git/xen/include/asm/domain.h:7,
                   from /local/xen.git/xen/include/xen/domain.h:8,
                   from /local/xen.git/xen/include/xen/sched.h:11,
                   from /local/xen.git/xen/include/xen/event.h:12,
                   from hvm.c:20:
  /local/xen.git/xen/include/asm/irq.h:140:34: note: 'dpci' declared here
    140 |             struct hvm_pirq_dpci dpci;
        |                                  ^~~~

The location marker is unhelpfully positioned and upstream may get around to
fixing it.  The complaint is intended to be:

  if ( !((pirq) ? &(pirq)->arch.hvm.dpci : NULL) )
                  ^~~~~~~~~~~~~~~~~~~~~~

which is a hint that the code is should be simplified to just:

  if ( !pirq )

Do so.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Roger Pau Monné <roger.pau@citrix.com>
CC: Wei Liu <wl@xen.org>
CC: Ian Jackson <iwj@xenproject.org>

Request for 4.16, as being very low risk.

This is a build problem with a soon-to-be-released compiler, but the issue it
highlights is real and the fix is a clear improvement in code quality.  There
is no difference in the compiled binary as a result of this change.

  $ diff -u dis-before dis-after
  --- dis-before       2021-10-27 21:00:07.512530321 +0100
  +++ dis-after        2021-10-27 21:00:25.996752544 +0100
  @@ -1,5 +1,5 @@

  -xen-syms-before:     file format elf64-x86-64
  +xen-syms-after:     file format elf64-x86-64

   Disassembly of section .text:

If this does not get taken at this point, it will need backporting after the
release, when GCC 12 is released.
---
 xen/drivers/passthrough/x86/hvm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/drivers/passthrough/x86/hvm.c b/xen/drivers/passthrough/x86/hvm.c
index 351daafdc9bf..22bf84639f22 100644
--- a/xen/drivers/passthrough/x86/hvm.c
+++ b/xen/drivers/passthrough/x86/hvm.c
@@ -902,7 +902,7 @@ static void hvm_gsi_eoi(struct domain *d, unsigned int gsi)
     struct pirq *pirq = pirq_info(d, gsi);
 
     /* Check if GSI is actually mapped. */
-    if ( !pirq_dpci(pirq) )
+    if ( !pirq )
         return;
 
     hvm_gsi_deassert(d, gsi);
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Wed Oct 27 21:00:28 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Oct 2021 21:00:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217205.377101 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfq1x-0007kj-Ec; Wed, 27 Oct 2021 21:00:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217205.377101; Wed, 27 Oct 2021 21:00:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfq1x-0007kc-BW; Wed, 27 Oct 2021 21:00:17 +0000
Received: by outflank-mailman (input) for mailman id 217205;
 Wed, 27 Oct 2021 21:00:15 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mfq1v-0007kS-J4; Wed, 27 Oct 2021 21:00:15 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mfq1v-0004Gf-Bw; Wed, 27 Oct 2021 21:00:15 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mfq1v-00056l-07; Wed, 27 Oct 2021 21:00:15 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mfq1u-0004W4-Vt; Wed, 27 Oct 2021 21:00:14 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=OBtssAdqQiZTI86D1VImkjXSDqNeXVwu6qZEbkJZkgU=; b=y2iAufjyLe1ymOSl6mtFpdsqQ2
	2ltphMdsXcsziZ6WxXEy1covBLsv0jere+wU9anTBDBrbsXUS5ebAntFliZ74b1EGhU/vH/L0dZaA
	N1fxwbZr/1yBFU2KNsd1hGPCbullVyvJi17e51M9GqKhy1mStUREvRLWY2UQ1B8EIM7s=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165915-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 165915: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=c91c967f329f866b1826b04e73e32aea936930cd
X-Osstest-Versions-That:
    xen=b0fce57a6a491c120f2554ad7cc9a0c43ee5defa
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 27 Oct 2021 21:00:14 +0000

flight 165915 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165915/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  c91c967f329f866b1826b04e73e32aea936930cd
baseline version:
 xen                  b0fce57a6a491c120f2554ad7cc9a0c43ee5defa

Last test of basis   165861  2021-10-25 16:01:42 Z    2 days
Testing same since   165915  2021-10-27 17:01:29 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Roger Pau Monne <roger.pau@citrix.com>
  Roger Pau Monné <roger.pau@citrix.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   b0fce57a6a..c91c967f32  c91c967f329f866b1826b04e73e32aea936930cd -> smoke


From xen-devel-bounces@lists.xenproject.org Wed Oct 27 21:18:10 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Oct 2021 21:18:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217215.377137 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfqJC-0001Ti-L1; Wed, 27 Oct 2021 21:18:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217215.377137; Wed, 27 Oct 2021 21:18:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfqJC-0001TX-Gg; Wed, 27 Oct 2021 21:18:06 +0000
Received: by outflank-mailman (input) for mailman id 217215;
 Wed, 27 Oct 2021 21:18:05 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=nMly=PP=gmail.com=digetx@srs-us1.protection.inumbo.net>)
 id 1mfqJB-0000sJ-8S
 for xen-devel@lists.xenproject.org; Wed, 27 Oct 2021 21:18:05 +0000
Received: from mail-lf1-x132.google.com (unknown [2a00:1450:4864:20::132])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 69deffbd-45dd-4bf9-95f2-79beb43a3f9b;
 Wed, 27 Oct 2021 21:17:57 +0000 (UTC)
Received: by mail-lf1-x132.google.com with SMTP id u11so9038212lfs.1
 for <xen-devel@lists.xenproject.org>; Wed, 27 Oct 2021 14:17:57 -0700 (PDT)
Received: from localhost.localdomain (46-138-41-28.dynamic.spd-mgts.ru.
 [46.138.41.28])
 by smtp.gmail.com with ESMTPSA id d7sm104336ljl.18.2021.10.27.14.17.54
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Wed, 27 Oct 2021 14:17:56 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 69deffbd-45dd-4bf9-95f2-79beb43a3f9b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=4OzDm5Q6AH2k+PTLkkEFou1ZT7VKkxRv+kE3WUpAOf8=;
        b=UQ/1aCiL3zbAzp7+64ENWMFEP+bdpmbq+KH3NTi7hX2kN+fFVrO8S32QtOPwQfMxxS
         B4dmeXUf/BzuJhhzqG8VnHaUgY25bdcGnTrwxpDILzBPa9fYkIseD/FA90YqGQJP6GXZ
         PaIGof4Fo+LwMmngjVzKDktvBb6N6F/Oq7yFljDHwAcSrBHnke6Ooi6gGMrQtQGLY6gt
         DkEqtfwDzQkavBqxwLa+DWQ8L/Pn42h6a2KO1Y5kAXNNdt6/bA2gpVm767XfMu2cU+ZD
         8088MqymRILm5tETDMubwXrrDQl/PbR2eeFdMLFjmwWobAMprcx5uRuWc88/LBbNkX13
         zK7A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=4OzDm5Q6AH2k+PTLkkEFou1ZT7VKkxRv+kE3WUpAOf8=;
        b=7j3IyY68TzNv5tdjXXE7+W/Y4efqcM8OnXKuAUH0Z8HvLDEFMXzNPu6dQHlZM2Bq4k
         2XMmCYgN/gKzXFUHPrldfDTGKZfnHbhr9hkuOvMqN6WIf3IGmqiT+weFsFjAhHr/EKvs
         aOuAfgf/EAYRMfyK87S/XfsSkK+h5vEafjKRWEkI16n5T+j5UiJKjopd0y12IxjN1bFc
         LNFFymRqB48awzR9T/MqGxj019M0ARI67Y+vGa970a8Y8np89rjBXcDs/o8h6tX1eCAE
         vb28fJJPMuPUFj7NwgvIUhcP9w+C/CrzveBO8k0Gm2p1IaOmQNekmjhxRvAbuLRMrG8T
         ptBg==
X-Gm-Message-State: AOAM532EQOPWywgYQYpDqQupjgGQhMZrohxfLb9FnyAqGCRXduFX+OPy
	jaESA1jIXeeXUVrpjp2ZHH0=
X-Google-Smtp-Source: ABdhPJyeN/kGQE6WfHsDgri2jvM3EdB0FfWjlbwbrCss0fAIUEYOe9Prwt7QavBIliqBuOmpkw05Og==
X-Received: by 2002:a05:6512:3f04:: with SMTP id y4mr128266lfa.180.1635369476308;
        Wed, 27 Oct 2021 14:17:56 -0700 (PDT)
From: Dmitry Osipenko <digetx@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Lee Jones <lee.jones@linaro.org>,
	"Rafael J . Wysocki" <rafael@kernel.org>,
	Mark Brown <broonie@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Russell King <linux@armlinux.org.uk>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Ulf Hansson <ulf.hansson@linaro.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Guo Ren <guoren@kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Greg Ungerer <gerg@linux-m68k.org>,
	Joshua Thompson <funaho@jurai.org>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Nick Hu <nickhu@andestech.com>,
	Greentime Hu <green.hu@gmail.com>,
	Vincent Chen <deanbo422@gmail.com>,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	Helge Deller <deller@gmx.de>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Rich Felker <dalias@libc.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Len Brown <lenb@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Chen-Yu Tsai <wens@csie.org>,
	=?UTF-8?q?Jonathan=20Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>,
	Tony Lindgren <tony@atomide.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Vladimir Zapolskiy <vz@mleia.com>,
	Avi Fishman <avifishman70@gmail.com>,
	Tomer Maimon <tmaimon77@gmail.com>,
	Tali Perry <tali.perry1@gmail.com>,
	Patrick Venture <venture@google.com>,
	Nancy Yuen <yuenn@google.com>,
	Benjamin Fair <benjaminfair@google.com>,
	Pavel Machek <pavel@ucw.cz>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	linux-csky@vger.kernel.org,
	linux-ia64@vger.kernel.org,
	linux-m68k@lists.linux-m68k.org,
	linux-mips@vger.kernel.org,
	linux-parisc@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-riscv@lists.infradead.org,
	linux-sh@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	linux-acpi@vger.kernel.org,
	linux-omap@vger.kernel.org,
	openbmc@lists.ozlabs.org,
	linux-tegra@vger.kernel.org,
	linux-pm@vger.kernel.org
Subject: [PATCH v2 02/45] notifier: Add blocking_notifier_call_chain_empty()
Date: Thu, 28 Oct 2021 00:16:32 +0300
Message-Id: <20211027211715.12671-3-digetx@gmail.com>
X-Mailer: git-send-email 2.33.1
In-Reply-To: <20211027211715.12671-1-digetx@gmail.com>
References: <20211027211715.12671-1-digetx@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Add blocking_notifier_call_chain_empty() that returns true if call chain
is empty.

Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
 include/linux/notifier.h |  2 ++
 kernel/notifier.c        | 14 ++++++++++++++
 2 files changed, 16 insertions(+)

diff --git a/include/linux/notifier.h b/include/linux/notifier.h
index 4b80a815b666..054271e9cb20 100644
--- a/include/linux/notifier.h
+++ b/include/linux/notifier.h
@@ -173,6 +173,8 @@ int blocking_notifier_call_chain_robust(struct blocking_notifier_head *nh,
 int raw_notifier_call_chain_robust(struct raw_notifier_head *nh,
 		unsigned long val_up, unsigned long val_down, void *v);
 
+bool blocking_notifier_call_chain_empty(struct blocking_notifier_head *nh);
+
 #define NOTIFY_DONE		0x0000		/* Don't care */
 #define NOTIFY_OK		0x0001		/* Suits me */
 #define NOTIFY_STOP_MASK	0x8000		/* Don't call further */
diff --git a/kernel/notifier.c b/kernel/notifier.c
index b8251dc0bc0f..1f7ba8988b90 100644
--- a/kernel/notifier.c
+++ b/kernel/notifier.c
@@ -322,6 +322,20 @@ int blocking_notifier_call_chain(struct blocking_notifier_head *nh,
 }
 EXPORT_SYMBOL_GPL(blocking_notifier_call_chain);
 
+/**
+ *	blocking_notifier_call_chain_empty - Check whether notifier chain is empty
+ *	@nh: Pointer to head of the blocking notifier chain
+ *
+ *	Checks whether notifier chain is empty.
+ *
+ *	Returns true is notifier chain is empty, false otherwise.
+ */
+bool blocking_notifier_call_chain_empty(struct blocking_notifier_head *nh)
+{
+	return !rcu_access_pointer(nh->head);
+}
+EXPORT_SYMBOL_GPL(blocking_notifier_call_chain_empty);
+
 /*
  *	Raw notifier chain routines.  There is no protection;
  *	the caller must provide it.  Use at your own risk!
-- 
2.33.1



From xen-devel-bounces@lists.xenproject.org Wed Oct 27 21:18:10 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Oct 2021 21:18:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217213.377115 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfqJ3-0000sW-0t; Wed, 27 Oct 2021 21:17:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217213.377115; Wed, 27 Oct 2021 21:17:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfqJ2-0000sP-TO; Wed, 27 Oct 2021 21:17:56 +0000
Received: by outflank-mailman (input) for mailman id 217213;
 Wed, 27 Oct 2021 21:17:55 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=nMly=PP=gmail.com=digetx@srs-us1.protection.inumbo.net>)
 id 1mfqJ1-0000sJ-HP
 for xen-devel@lists.xenproject.org; Wed, 27 Oct 2021 21:17:55 +0000
Received: from mail-lf1-x12e.google.com (unknown [2a00:1450:4864:20::12e])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id d25f7dee-b839-40a1-9397-c24b450b7115;
 Wed, 27 Oct 2021 21:17:53 +0000 (UTC)
Received: by mail-lf1-x12e.google.com with SMTP id bi35so8955450lfb.9
 for <xen-devel@lists.xenproject.org>; Wed, 27 Oct 2021 14:17:53 -0700 (PDT)
Received: from localhost.localdomain (46-138-41-28.dynamic.spd-mgts.ru.
 [46.138.41.28])
 by smtp.gmail.com with ESMTPSA id d7sm104336ljl.18.2021.10.27.14.17.50
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Wed, 27 Oct 2021 14:17:52 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d25f7dee-b839-40a1-9397-c24b450b7115
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:mime-version
         :content-transfer-encoding;
        bh=HanWLUgUF9ofZz0QDrpGI0FWc48M0ufWpqHp0nt1b2E=;
        b=a1C0lJ0gvckIcvrduJKizBVznyKnv2//TCPoPAKkXD5DGkkQrqb/ViKHcln36NfZVY
         ISxWYKFK39QVsDuVPSlu1LT5SZ/nBBGFDz/uufiZqdO/sZQ/qKfQbI2KUPqf8Q5RxkHA
         MqrWECpWx+g/FtcgYyau3zztbhU+vtw2w2aCc+udZXZ6rXXp+WIwUtGzuFURsYXqbmre
         UplyFnSR1G34j0+8EfYoJdUe8oXvIadmEQEw4Cs4f6QOILfUENf3Exk7blXkIQnIkrzz
         fkcmzAmhEcuM9KSNxc0P3MxX2C8tZcNnFx2+J321vEf5QsS8Rq276nN8ZpOlB8JNgrdd
         UeOg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version
         :content-transfer-encoding;
        bh=HanWLUgUF9ofZz0QDrpGI0FWc48M0ufWpqHp0nt1b2E=;
        b=pQw9ofOQhtO2Lr2Q4hsGVfjMgUndfqeJe2bLQu1wehsAkO0CR5XC3+5lBM2d+zNdsO
         uMdtWzqObbGHR1Zhd5x+sPuQzRJWDiq2nIewIiiMWPtOb3KxQU7AYRkOJYPUENy3FrWQ
         XE6SP9X7xNjTTxKEyWCnNqKo/ssxyZSmw9Ms+BpCkPuC+XWh4i6F326bISCJp07M7Gv8
         Lk1C27aBo84Pe1tiUWS0VXcswphyhisdN1buTMn8lTJjwoAM9iF0IjKR5A+cQiKn762j
         rmhXc04b7CceUOVEqXCmjqN6rI30j2hujqcBMc7Fjh/5Tkx01SJs7icHmJtEJbbS0IPc
         vuCA==
X-Gm-Message-State: AOAM5321NPEjWPN1TgihxzL3e6susLs62RqM94/emCTftR00iDi6yP+Q
	LcW572VAt4X2fTv/mVOH2cE=
X-Google-Smtp-Source: ABdhPJwziuHQfMqUpY6gmZyMY580K8cBL+Vix4M/+v/UKEXvEr1gkREZREaCQS2oC15RMdaQR1Q4+A==
X-Received: by 2002:a05:6512:31a:: with SMTP id t26mr121977lfp.280.1635369472536;
        Wed, 27 Oct 2021 14:17:52 -0700 (PDT)
From: Dmitry Osipenko <digetx@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Lee Jones <lee.jones@linaro.org>,
	"Rafael J . Wysocki" <rafael@kernel.org>,
	Mark Brown <broonie@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Russell King <linux@armlinux.org.uk>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Ulf Hansson <ulf.hansson@linaro.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Guo Ren <guoren@kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Greg Ungerer <gerg@linux-m68k.org>,
	Joshua Thompson <funaho@jurai.org>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Nick Hu <nickhu@andestech.com>,
	Greentime Hu <green.hu@gmail.com>,
	Vincent Chen <deanbo422@gmail.com>,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	Helge Deller <deller@gmx.de>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Rich Felker <dalias@libc.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Len Brown <lenb@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Chen-Yu Tsai <wens@csie.org>,
	=?UTF-8?q?Jonathan=20Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>,
	Tony Lindgren <tony@atomide.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Vladimir Zapolskiy <vz@mleia.com>,
	Avi Fishman <avifishman70@gmail.com>,
	Tomer Maimon <tmaimon77@gmail.com>,
	Tali Perry <tali.perry1@gmail.com>,
	Patrick Venture <venture@google.com>,
	Nancy Yuen <yuenn@google.com>,
	Benjamin Fair <benjaminfair@google.com>,
	Pavel Machek <pavel@ucw.cz>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	linux-csky@vger.kernel.org,
	linux-ia64@vger.kernel.org,
	linux-m68k@lists.linux-m68k.org,
	linux-mips@vger.kernel.org,
	linux-parisc@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-riscv@lists.infradead.org,
	linux-sh@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	linux-acpi@vger.kernel.org,
	linux-omap@vger.kernel.org,
	openbmc@lists.ozlabs.org,
	linux-tegra@vger.kernel.org,
	linux-pm@vger.kernel.org
Subject: [PATCH v2 00/45] Introduce power-off+restart call chain API
Date: Thu, 28 Oct 2021 00:16:30 +0300
Message-Id: <20211027211715.12671-1-digetx@gmail.com>
X-Mailer: git-send-email 2.33.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Problem
-------

SoC devices require power-off call chaining functionality from kernel.
We have a widely used restart chaining provided by restart notifier API,
but nothing for power-off.

Solution
--------

Introduce new API that provides both restart and power-off call chains.

Why combine restart with power-off? Because drivers often do both.
More practical to have API that provides both under the same roof.

The new API is designed with simplicity and extensibility in mind.
It's built upon the existing restart and reboot APIs. The simplicity
is in new helper functions that are convenient for drivers. The
extensibility is in the design that doesn't hardcode callback
arguments, making easy to add new parameters and remove old.

This is a third attempt to introduce the new API. First was made by
Guenter Roeck back in 2014, second was made by Thierry Reding in 2017.
In fact the work didn't stop and recently arm_pm_restart() was removed
from v5.14 kernel, which was a part of preparatory work started by
Guenter Roeck. I took into account experience and ideas from the
previous attempts, extended and polished them.

Adoption plan
-------------

This patchset introduces the new API. It also converts multiple drivers
and arch code to the new API to demonstrate how it all looks in practice.

The plan is:

1. Merge new API (patches 1-8). This API will co-exist with the old APIs.

2. Convert arch code to do_kernel_power_off() (patches 9-21).

3. Convert drivers and platform code to the new API.

4. Remove obsolete pm_power_off and pm_power_off_prepare variables.

5. Make restart-notifier API private to kernel/reboot.c once no users left.

Results
-------

1. Devices can be powered off properly.

2. Global variables are removed from drivers.

3. Global pm_power_off and pm_power_off_prepare callback variables are
removed once all users are converted to the new API. The latter callback
is removed by patch #25 of this series.

4. Ambiguous call chain ordering is prohibited. See patch #5 which adds
verification of restart handlers priorities, ensuring that they are unique.

Changelog:

v2: - Replaced standalone power-off call chain demo-API with the combined
      power-off+restart API because this is what drivers want. It's a more
      comprehensive solution.

    - Converted multiple drivers and arch code to the new API. Suggested by
      Andy Shevchenko. I skimmed through the rest of drivers, verifying that
      new API suits them. The rest of the drivers will be converted once we
      will settle on the new API, otherwise will be too many patches here.

    - v2 API doesn't expose notifier to users and require handlers to
      have unique priority. Suggested by Guenter Roeck.

    - v2 API has power-off chaining disabled by default and require
      drivers to explicitly opt-in to the chaining. This preserves old
      behaviour for existing drivers once they are converted to the new
      API.

Dmitry Osipenko (45):
  notifier: Remove extern annotation from function prototypes
  notifier: Add blocking_notifier_call_chain_empty()
  notifier: Add atomic/blocking_notifier_has_unique_priority()
  reboot: Correct typo in a comment
  reboot: Warn if restart handler has duplicated priority
  reboot: Warn if unregister_restart_handler() fails
  reboot: Remove extern annotation from function prototypes
  kernel: Add combined power-off+restart handler call chain API
  xen/x86: Use do_kernel_power_off()
  ARM: Use do_kernel_power_off()
  arm64: Use do_kernel_power_off()
  csky: Use do_kernel_power_off()
  ia64: Use do_kernel_power_off()
  mips: Use do_kernel_power_off()
  nds32: Use do_kernel_power_off()
  parisc: Use do_kernel_power_off()
  powerpc: Use do_kernel_power_off()
  riscv: Use do_kernel_power_off()
  sh: Use do_kernel_power_off()
  x86: Use do_kernel_power_off()
  m68k: Switch to new power-handler API
  memory: emif: Use kernel_can_power_off()
  ACPI: power: Switch to power-handler API
  regulator: pfuze100: Use devm_register_power_handler()
  reboot: Remove pm_power_off_prepare()
  soc/tegra: pmc: Utilize power-handler API to power off Nexus 7
    properly
  mfd: ntxec: Use devm_register_power_handler()
  mfd: rn5t618: Use devm_register_power_handler()
  mfd: acer-a500: Use devm_register_power_handler()
  mfd: ene-kb3930: Use devm_register_power_handler()
  mfd: axp20x: Use register_simple_power_off_handler()
  mfd: retu: Use devm_register_simple_power_off_handler()
  mfd: rk808: Use devm_register_simple_power_off_handler()
  mfd: palmas: Use devm_register_simple_power_off_handler()
  mfd: max8907: Use devm_register_simple_power_off_handler()
  mfd: tps6586x: Use devm_register_simple_power_off_handler()
  mfd: tps65910: Use devm_register_simple_power_off_handler()
  mfd: max77620: Use devm_register_simple_power_off_handler()
  mfd: dm355evm_msp: Use devm_register_trivial_power_off_handler()
  mfd: twl4030: Use devm_register_trivial_power_off_handler()
  mfd: ab8500: Use devm_register_trivial_power_off_handler()
  reset: ath79: Use devm_register_simple_restart_handler()
  reset: intel-gw: Use devm_register_simple_restart_handler()
  reset: lpc18xx: Use devm_register_prioritized_restart_handler()
  reset: npcm: Use devm_register_prioritized_restart_handler()

 arch/arm/kernel/reboot.c               |   4 +-
 arch/arm64/kernel/process.c            |   3 +-
 arch/csky/kernel/power.c               |   6 +-
 arch/ia64/kernel/process.c             |   4 +-
 arch/m68k/emu/natfeat.c                |   3 +-
 arch/m68k/include/asm/machdep.h        |   1 -
 arch/m68k/kernel/process.c             |   5 +-
 arch/m68k/kernel/setup_mm.c            |   1 -
 arch/m68k/kernel/setup_no.c            |   1 -
 arch/m68k/mac/config.c                 |   4 +-
 arch/mips/kernel/reset.c               |   3 +-
 arch/nds32/kernel/process.c            |   3 +-
 arch/parisc/kernel/process.c           |   4 +-
 arch/powerpc/kernel/setup-common.c     |   4 +-
 arch/powerpc/xmon/xmon.c               |   3 +-
 arch/riscv/kernel/reset.c              |  12 +-
 arch/sh/kernel/reboot.c                |   3 +-
 arch/x86/kernel/reboot.c               |   4 +-
 arch/x86/xen/enlighten_pv.c            |   4 +-
 drivers/acpi/sleep.c                   |  25 +-
 drivers/memory/emif.c                  |   2 +-
 drivers/mfd/ab8500-sysctrl.c           |  17 +-
 drivers/mfd/acer-ec-a500.c             |  52 +--
 drivers/mfd/axp20x.c                   |  22 +-
 drivers/mfd/dm355evm_msp.c             |  20 +-
 drivers/mfd/ene-kb3930.c               |  45 +-
 drivers/mfd/max77620.c                 |  21 +-
 drivers/mfd/max8907.c                  |  22 +-
 drivers/mfd/ntxec.c                    |  50 +-
 drivers/mfd/palmas.c                   |  24 +-
 drivers/mfd/retu-mfd.c                 |  31 +-
 drivers/mfd/rk808.c                    |  23 +-
 drivers/mfd/rn5t618.c                  |  56 +--
 drivers/mfd/tps6586x.c                 |  21 +-
 drivers/mfd/tps65910.c                 |  17 +-
 drivers/mfd/twl4030-power.c            |  10 +-
 drivers/regulator/pfuze100-regulator.c |  39 +-
 drivers/reset/reset-ath79.c            |  15 +-
 drivers/reset/reset-intel-gw.c         |  13 +-
 drivers/reset/reset-lpc18xx.c          |  14 +-
 drivers/reset/reset-npcm.c             |  14 +-
 drivers/soc/tegra/pmc.c                |  54 ++-
 include/linux/mfd/axp20x.h             |   1 +
 include/linux/notifier.h               |  37 +-
 include/linux/pm.h                     |   1 -
 include/linux/reboot.h                 | 216 ++++++++-
 kernel/notifier.c                      |  88 ++++
 kernel/power/hibernate.c               |   2 +-
 kernel/reboot.c                        | 615 ++++++++++++++++++++++++-
 49 files changed, 1209 insertions(+), 430 deletions(-)

-- 
2.33.1



From xen-devel-bounces@lists.xenproject.org Wed Oct 27 21:18:11 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Oct 2021 21:18:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217216.377148 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfqJH-0001q1-0i; Wed, 27 Oct 2021 21:18:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217216.377148; Wed, 27 Oct 2021 21:18:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfqJG-0001po-Sz; Wed, 27 Oct 2021 21:18:10 +0000
Received: by outflank-mailman (input) for mailman id 217216;
 Wed, 27 Oct 2021 21:18:10 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=nMly=PP=gmail.com=digetx@srs-us1.protection.inumbo.net>)
 id 1mfqJG-0000sJ-8f
 for xen-devel@lists.xenproject.org; Wed, 27 Oct 2021 21:18:10 +0000
Received: from mail-lf1-x12d.google.com (unknown [2a00:1450:4864:20::12d])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 92f7f69c-ba4d-45e9-915e-e2b0259386cd;
 Wed, 27 Oct 2021 21:17:59 +0000 (UTC)
Received: by mail-lf1-x12d.google.com with SMTP id bq11so8953119lfb.10
 for <xen-devel@lists.xenproject.org>; Wed, 27 Oct 2021 14:17:59 -0700 (PDT)
Received: from localhost.localdomain (46-138-41-28.dynamic.spd-mgts.ru.
 [46.138.41.28])
 by smtp.gmail.com with ESMTPSA id d7sm104336ljl.18.2021.10.27.14.17.56
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Wed, 27 Oct 2021 14:17:57 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 92f7f69c-ba4d-45e9-915e-e2b0259386cd
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=gfPQe0zgS4I4UWFZNFBbY1KeZFawP+pEpuBLVF6wdKM=;
        b=IF53pE4MG8dtqJfDztqJu8/A7a/y14/j36v2nKdiMw6iu4DWmrRW8MOeE8LURQLXaK
         Ga0+xYwPRFyxojC/znNrOvpLGs+k6KHlhVWadULFKWtX+mXFusF6mHh4CLs+vcnkJVbI
         sCT8nKeVlZGK2TnNZ10Uo/TFQPsaFWopDEGJma2V9OokstL1aGUJunbAvrHKFFxOtEwg
         lD8/h9mw7UJrhz8Lza29Xoci0CHBwnwZJdD56IRSRRGiIs4vKcta6w27872hpSmyCu02
         ZBL1gjD87s9mbzpJUGm1Sbte3r8qhTN12pgeySe/LAcZyKJ0wXtrJhOtFLQB3UvQJ2Q1
         ctBg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=gfPQe0zgS4I4UWFZNFBbY1KeZFawP+pEpuBLVF6wdKM=;
        b=64LdfLFdyNs9FIPPEP7qdkbVqEL93mZAkB9Tc8XfpIuWXw+Lydsq4mT3ttKfHdDIAY
         66A3gSoTk3+P98ft+5eBhowddOwiahM8qwr0wjdftq6FuH6fLEBy+o2f+jFI4RyY7g5H
         Jucn37Aj6V5gTLwWHr6XASacoboBrnxJ5iNQlUf1pLqEdhGHLvaJ7Z1bydOGpCx53D/m
         E96VXOb2jM7emsXlvF+T/fsjexp6Hn1/7TcfpmqihZE6Vg5JmF13rbIpCkzkycKi05kw
         kYoMYxO8s+bimz5v0gs+WsuWiJO2bQI6lJ9CbMMN7saWgR/pHM72MiogG5k2d7pLVGJ3
         zMTQ==
X-Gm-Message-State: AOAM531v933gp1gYyJVSW4wA4r336AucWFC+dISX9Z3ldhyRuHtaH12k
	akfYXo7Z0oWrtaMVrTVna5o=
X-Google-Smtp-Source: ABdhPJxkIyEtMiQViKWR5fwy6fiT3tpzf12+F4/RJZJ4BQVHBt5yXcPBTwu2lq74yYNLjaS3GsmWQQ==
X-Received: by 2002:a05:6512:1095:: with SMTP id j21mr130850lfg.274.1635369478293;
        Wed, 27 Oct 2021 14:17:58 -0700 (PDT)
From: Dmitry Osipenko <digetx@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Lee Jones <lee.jones@linaro.org>,
	"Rafael J . Wysocki" <rafael@kernel.org>,
	Mark Brown <broonie@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Russell King <linux@armlinux.org.uk>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Ulf Hansson <ulf.hansson@linaro.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Guo Ren <guoren@kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Greg Ungerer <gerg@linux-m68k.org>,
	Joshua Thompson <funaho@jurai.org>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Nick Hu <nickhu@andestech.com>,
	Greentime Hu <green.hu@gmail.com>,
	Vincent Chen <deanbo422@gmail.com>,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	Helge Deller <deller@gmx.de>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Rich Felker <dalias@libc.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Len Brown <lenb@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Chen-Yu Tsai <wens@csie.org>,
	=?UTF-8?q?Jonathan=20Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>,
	Tony Lindgren <tony@atomide.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Vladimir Zapolskiy <vz@mleia.com>,
	Avi Fishman <avifishman70@gmail.com>,
	Tomer Maimon <tmaimon77@gmail.com>,
	Tali Perry <tali.perry1@gmail.com>,
	Patrick Venture <venture@google.com>,
	Nancy Yuen <yuenn@google.com>,
	Benjamin Fair <benjaminfair@google.com>,
	Pavel Machek <pavel@ucw.cz>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	linux-csky@vger.kernel.org,
	linux-ia64@vger.kernel.org,
	linux-m68k@lists.linux-m68k.org,
	linux-mips@vger.kernel.org,
	linux-parisc@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-riscv@lists.infradead.org,
	linux-sh@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	linux-acpi@vger.kernel.org,
	linux-omap@vger.kernel.org,
	openbmc@lists.ozlabs.org,
	linux-tegra@vger.kernel.org,
	linux-pm@vger.kernel.org
Subject: [PATCH v2 03/45] notifier: Add atomic/blocking_notifier_has_unique_priority()
Date: Thu, 28 Oct 2021 00:16:33 +0300
Message-Id: <20211027211715.12671-4-digetx@gmail.com>
X-Mailer: git-send-email 2.33.1
In-Reply-To: <20211027211715.12671-1-digetx@gmail.com>
References: <20211027211715.12671-1-digetx@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Add atomic/blocking_notifier_has_unique_priority() helpers which return
true if given handler has unique priority.

Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
 include/linux/notifier.h |  5 +++
 kernel/notifier.c        | 74 ++++++++++++++++++++++++++++++++++++++++
 2 files changed, 79 insertions(+)

diff --git a/include/linux/notifier.h b/include/linux/notifier.h
index 054271e9cb20..b782ce100022 100644
--- a/include/linux/notifier.h
+++ b/include/linux/notifier.h
@@ -175,6 +175,11 @@ int raw_notifier_call_chain_robust(struct raw_notifier_head *nh,
 
 bool blocking_notifier_call_chain_empty(struct blocking_notifier_head *nh);
 
+bool atomic_notifier_has_unique_priority(struct atomic_notifier_head *nh,
+		struct notifier_block *nb);
+bool blocking_notifier_has_unique_priority(struct blocking_notifier_head *nh,
+		struct notifier_block *nb);
+
 #define NOTIFY_DONE		0x0000		/* Don't care */
 #define NOTIFY_OK		0x0001		/* Suits me */
 #define NOTIFY_STOP_MASK	0x8000		/* Don't call further */
diff --git a/kernel/notifier.c b/kernel/notifier.c
index 1f7ba8988b90..cf0e1c4bd364 100644
--- a/kernel/notifier.c
+++ b/kernel/notifier.c
@@ -203,6 +203,40 @@ int atomic_notifier_call_chain(struct atomic_notifier_head *nh,
 EXPORT_SYMBOL_GPL(atomic_notifier_call_chain);
 NOKPROBE_SYMBOL(atomic_notifier_call_chain);
 
+/**
+ *	atomic_notifier_has_unique_priority - Checks whether notifier's priority is unique
+ *	@nh: Pointer to head of the atomic notifier chain
+ *	@n: Entry in notifier chain to check
+ *
+ *	Checks whether there is another notifier in the chain with the same priority.
+ *	Must be called in process context.
+ *
+ *	Returns true if priority is unique, false otherwise.
+ */
+bool atomic_notifier_has_unique_priority(struct atomic_notifier_head *nh,
+		struct notifier_block *n)
+{
+	struct notifier_block **nl = &nh->head;
+	unsigned long flags;
+	bool ret = true;
+
+	spin_lock_irqsave(&nh->lock, flags);
+
+	while ((*nl) != NULL && (*nl)->priority >= n->priority) {
+		if ((*nl)->priority == n->priority && (*nl) != n) {
+			ret = false;
+			break;
+		}
+
+		nl = &((*nl)->next);
+	}
+
+	spin_unlock_irqrestore(&nh->lock, flags);
+
+	return ret;
+}
+EXPORT_SYMBOL_GPL(atomic_notifier_has_unique_priority);
+
 /*
  *	Blocking notifier chain routines.  All access to the chain is
  *	synchronized by an rwsem.
@@ -336,6 +370,46 @@ bool blocking_notifier_call_chain_empty(struct blocking_notifier_head *nh)
 }
 EXPORT_SYMBOL_GPL(blocking_notifier_call_chain_empty);
 
+/**
+ *	blocking_notifier_has_unique_priority - Checks whether notifier's priority is unique
+ *	@nh: Pointer to head of the blocking notifier chain
+ *	@n: Entry in notifier chain to check
+ *
+ *	Checks whether there is another notifier in the chain with the same priority.
+ *	Must be called in process context.
+ *
+ *	Returns true if priority is unique, false otherwise.
+ */
+bool blocking_notifier_has_unique_priority(struct blocking_notifier_head *nh,
+		struct notifier_block *n)
+{
+	struct notifier_block **nl = &nh->head;
+	bool ret = true;
+
+	/*
+	 * This code gets used during boot-up, when task switching is
+	 * not yet working and interrupts must remain disabled.  At
+	 * such times we must not call down_write().
+	 */
+	if (system_state != SYSTEM_BOOTING)
+		down_write(&nh->rwsem);
+
+	while ((*nl) != NULL && (*nl)->priority >= n->priority) {
+		if ((*nl)->priority == n->priority && (*nl) != n) {
+			ret = false;
+			break;
+		}
+
+		nl = &((*nl)->next);
+	}
+
+	if (system_state != SYSTEM_BOOTING)
+		up_write(&nh->rwsem);
+
+	return ret;
+}
+EXPORT_SYMBOL_GPL(blocking_notifier_has_unique_priority);
+
 /*
  *	Raw notifier chain routines.  There is no protection;
  *	the caller must provide it.  Use at your own risk!
-- 
2.33.1



From xen-devel-bounces@lists.xenproject.org Wed Oct 27 21:18:11 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Oct 2021 21:18:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217214.377126 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfqJ7-00018a-9b; Wed, 27 Oct 2021 21:18:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217214.377126; Wed, 27 Oct 2021 21:18:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfqJ7-00018T-4T; Wed, 27 Oct 2021 21:18:01 +0000
Received: by outflank-mailman (input) for mailman id 217214;
 Wed, 27 Oct 2021 21:18:00 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=nMly=PP=gmail.com=digetx@srs-us1.protection.inumbo.net>)
 id 1mfqJ6-0000sJ-8E
 for xen-devel@lists.xenproject.org; Wed, 27 Oct 2021 21:18:00 +0000
Received: from mail-lf1-x135.google.com (unknown [2a00:1450:4864:20::135])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id bce1809a-144c-4b61-baea-055b3065fd00;
 Wed, 27 Oct 2021 21:17:55 +0000 (UTC)
Received: by mail-lf1-x135.google.com with SMTP id l13so8987907lfg.6
 for <xen-devel@lists.xenproject.org>; Wed, 27 Oct 2021 14:17:55 -0700 (PDT)
Received: from localhost.localdomain (46-138-41-28.dynamic.spd-mgts.ru.
 [46.138.41.28])
 by smtp.gmail.com with ESMTPSA id d7sm104336ljl.18.2021.10.27.14.17.52
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Wed, 27 Oct 2021 14:17:54 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: bce1809a-144c-4b61-baea-055b3065fd00
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=wTvK5kO0FUcGnxCyVmK+GKrZNfPhZFNt57h0QWat/qo=;
        b=ZqOcoukrajwjG0ttfhDDamRtFbZgEiaFrpLAXOR7yQBANjFcnFFXOdYomTLQXBItFZ
         6fsN0Gio8AJkokF0BnxXjlaJgq1CP0FdapZULDkVLC880wSvbduG3ij7wOgm65yyZHfb
         /MEYtYvu3WnHHl8p/60KRwD6dDnaqpWEGWZELHlL42ECg0BG3xSUbLaFXBGJ8l5anvCb
         nmVZ+GAgVHAauuOzz3lnhLFItX2Cbpx7VOJRMQdOkh5vDNRTVY6CLlgAa8SfZ45DmHqN
         vHhGZ7nhCEzJCcCT39f5nwGqOjoorbJierMaHF5OrWAM3eykGjghB0x8WQgbnqhmKJ6c
         aKlw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=wTvK5kO0FUcGnxCyVmK+GKrZNfPhZFNt57h0QWat/qo=;
        b=MIyTjnIccPfpARTs5S90w7eSfTcVG97Wl1FCYn1foRqK1bM3rJxz8MNBBFJt5qIOFz
         JvNNj8UN3W57LU5sLm6RaT7n2+khgZ7SoylSHQWk/5TkEqKxPR+hZbFn+7OIuUkcaRmE
         uB0BL9uBmZzMY+aAbUljOB46JF0TaDhdfb7eT/VqlYCnVuq5IG3l20zr7maxOVSqQU/+
         ymr5GstanfdYpB3AD3SJnD57nZipAL/lQLeHdkVNH9sQIcG3Izeg8CcO63srO4t2OiGb
         /ECsspTdje2lLOidOQCRglJ313Zk4UYMhpGkWOSPWEh3ELzEpBqD7cugUh7b2q9Fettd
         nf6w==
X-Gm-Message-State: AOAM530/VMHBivxVEjajZTXAgviYAAmdkRbZon9ycXjEytv44oN+bTaR
	OHoJeYkbl9dDgLPyqEyHN48=
X-Google-Smtp-Source: ABdhPJwuKOrqeex0uVzCe5G2iTS4vzkdpHKtiR+d5t3erf2uXeC/mCcisVEMxQQhKVgKCWNS6EmCsw==
X-Received: by 2002:a05:6512:38d0:: with SMTP id p16mr80629lft.483.1635369474451;
        Wed, 27 Oct 2021 14:17:54 -0700 (PDT)
From: Dmitry Osipenko <digetx@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Lee Jones <lee.jones@linaro.org>,
	"Rafael J . Wysocki" <rafael@kernel.org>,
	Mark Brown <broonie@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Russell King <linux@armlinux.org.uk>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Ulf Hansson <ulf.hansson@linaro.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Guo Ren <guoren@kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Greg Ungerer <gerg@linux-m68k.org>,
	Joshua Thompson <funaho@jurai.org>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Nick Hu <nickhu@andestech.com>,
	Greentime Hu <green.hu@gmail.com>,
	Vincent Chen <deanbo422@gmail.com>,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	Helge Deller <deller@gmx.de>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Rich Felker <dalias@libc.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Len Brown <lenb@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Chen-Yu Tsai <wens@csie.org>,
	=?UTF-8?q?Jonathan=20Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>,
	Tony Lindgren <tony@atomide.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Vladimir Zapolskiy <vz@mleia.com>,
	Avi Fishman <avifishman70@gmail.com>,
	Tomer Maimon <tmaimon77@gmail.com>,
	Tali Perry <tali.perry1@gmail.com>,
	Patrick Venture <venture@google.com>,
	Nancy Yuen <yuenn@google.com>,
	Benjamin Fair <benjaminfair@google.com>,
	Pavel Machek <pavel@ucw.cz>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	linux-csky@vger.kernel.org,
	linux-ia64@vger.kernel.org,
	linux-m68k@lists.linux-m68k.org,
	linux-mips@vger.kernel.org,
	linux-parisc@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-riscv@lists.infradead.org,
	linux-sh@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	linux-acpi@vger.kernel.org,
	linux-omap@vger.kernel.org,
	openbmc@lists.ozlabs.org,
	linux-tegra@vger.kernel.org,
	linux-pm@vger.kernel.org
Subject: [PATCH v2 01/45] notifier: Remove extern annotation from function prototypes
Date: Thu, 28 Oct 2021 00:16:31 +0300
Message-Id: <20211027211715.12671-2-digetx@gmail.com>
X-Mailer: git-send-email 2.33.1
In-Reply-To: <20211027211715.12671-1-digetx@gmail.com>
References: <20211027211715.12671-1-digetx@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

There is no need to annotate function prototypes with 'extern', it makes
code less readable. Remove unnecessary annotations from <notifier.h>.

Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
 include/linux/notifier.h | 30 +++++++++++++++---------------
 1 file changed, 15 insertions(+), 15 deletions(-)

diff --git a/include/linux/notifier.h b/include/linux/notifier.h
index 87069b8459af..4b80a815b666 100644
--- a/include/linux/notifier.h
+++ b/include/linux/notifier.h
@@ -90,7 +90,7 @@ struct srcu_notifier_head {
 	} while (0)
 
 /* srcu_notifier_heads must be cleaned up dynamically */
-extern void srcu_init_notifier_head(struct srcu_notifier_head *nh);
+void srcu_init_notifier_head(struct srcu_notifier_head *nh);
 #define srcu_cleanup_notifier_head(name)	\
 		cleanup_srcu_struct(&(name)->srcu);
 
@@ -141,36 +141,36 @@ extern void srcu_init_notifier_head(struct srcu_notifier_head *nh);
 
 #ifdef __KERNEL__
 
-extern int atomic_notifier_chain_register(struct atomic_notifier_head *nh,
+int atomic_notifier_chain_register(struct atomic_notifier_head *nh,
 		struct notifier_block *nb);
-extern int blocking_notifier_chain_register(struct blocking_notifier_head *nh,
+int blocking_notifier_chain_register(struct blocking_notifier_head *nh,
 		struct notifier_block *nb);
-extern int raw_notifier_chain_register(struct raw_notifier_head *nh,
+int raw_notifier_chain_register(struct raw_notifier_head *nh,
 		struct notifier_block *nb);
-extern int srcu_notifier_chain_register(struct srcu_notifier_head *nh,
+int srcu_notifier_chain_register(struct srcu_notifier_head *nh,
 		struct notifier_block *nb);
 
-extern int atomic_notifier_chain_unregister(struct atomic_notifier_head *nh,
+int atomic_notifier_chain_unregister(struct atomic_notifier_head *nh,
 		struct notifier_block *nb);
-extern int blocking_notifier_chain_unregister(struct blocking_notifier_head *nh,
+int blocking_notifier_chain_unregister(struct blocking_notifier_head *nh,
 		struct notifier_block *nb);
-extern int raw_notifier_chain_unregister(struct raw_notifier_head *nh,
+int raw_notifier_chain_unregister(struct raw_notifier_head *nh,
 		struct notifier_block *nb);
-extern int srcu_notifier_chain_unregister(struct srcu_notifier_head *nh,
+int srcu_notifier_chain_unregister(struct srcu_notifier_head *nh,
 		struct notifier_block *nb);
 
-extern int atomic_notifier_call_chain(struct atomic_notifier_head *nh,
+int atomic_notifier_call_chain(struct atomic_notifier_head *nh,
 		unsigned long val, void *v);
-extern int blocking_notifier_call_chain(struct blocking_notifier_head *nh,
+int blocking_notifier_call_chain(struct blocking_notifier_head *nh,
 		unsigned long val, void *v);
-extern int raw_notifier_call_chain(struct raw_notifier_head *nh,
+int raw_notifier_call_chain(struct raw_notifier_head *nh,
 		unsigned long val, void *v);
-extern int srcu_notifier_call_chain(struct srcu_notifier_head *nh,
+int srcu_notifier_call_chain(struct srcu_notifier_head *nh,
 		unsigned long val, void *v);
 
-extern int blocking_notifier_call_chain_robust(struct blocking_notifier_head *nh,
+int blocking_notifier_call_chain_robust(struct blocking_notifier_head *nh,
 		unsigned long val_up, unsigned long val_down, void *v);
-extern int raw_notifier_call_chain_robust(struct raw_notifier_head *nh,
+int raw_notifier_call_chain_robust(struct raw_notifier_head *nh,
 		unsigned long val_up, unsigned long val_down, void *v);
 
 #define NOTIFY_DONE		0x0000		/* Don't care */
-- 
2.33.1



From xen-devel-bounces@lists.xenproject.org Wed Oct 27 21:18:16 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Oct 2021 21:18:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217217.377159 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfqJM-0002Jq-Av; Wed, 27 Oct 2021 21:18:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217217.377159; Wed, 27 Oct 2021 21:18:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfqJM-0002Iz-6D; Wed, 27 Oct 2021 21:18:16 +0000
Received: by outflank-mailman (input) for mailman id 217217;
 Wed, 27 Oct 2021 21:18:15 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=nMly=PP=gmail.com=digetx@srs-us1.protection.inumbo.net>)
 id 1mfqJL-0000sJ-8f
 for xen-devel@lists.xenproject.org; Wed, 27 Oct 2021 21:18:15 +0000
Received: from mail-lj1-x22e.google.com (unknown [2a00:1450:4864:20::22e])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 7ba8bc2f-320b-42ee-a31a-b7b5adb59c29;
 Wed, 27 Oct 2021 21:18:01 +0000 (UTC)
Received: by mail-lj1-x22e.google.com with SMTP id 17so3837676ljq.0
 for <xen-devel@lists.xenproject.org>; Wed, 27 Oct 2021 14:18:01 -0700 (PDT)
Received: from localhost.localdomain (46-138-41-28.dynamic.spd-mgts.ru.
 [46.138.41.28])
 by smtp.gmail.com with ESMTPSA id d7sm104336ljl.18.2021.10.27.14.17.58
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Wed, 27 Oct 2021 14:17:59 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7ba8bc2f-320b-42ee-a31a-b7b5adb59c29
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=TugVlbRXpFiQ9yttEJ2CYhwYKdBA8PSz6pBjqNjtqe8=;
        b=LxdZEWQx3suPqkadhSlrIg8Y/wBbCgZ19oaPbtBfHJRBGXgu8OvRhmKtGBeiAtGOi+
         liDoShgJoGfChatXJvVHlGfhJqZTZfaSa614IMYrTFjYDb/peXO5oxQ8SJntz+ROu8lH
         ob1M7/DUPmtXRrZcD8cMolSz0IhB48FDFGrv8rmurlnFUtz5GHTwT3bfswp5rSRPgw7Q
         Bzriun3on2U4+nPpGH/7v8uRLlN52ALrwjKmwn0fNW7IfodPJ5+z4OBz44Q0tz7qr3AI
         hQkqoobZyhuG5/zdS6+8c5M7BaM8ouPopuZJKxbxjokH3QVc4vnRaK15kTyz9igV7eYm
         7uUg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=TugVlbRXpFiQ9yttEJ2CYhwYKdBA8PSz6pBjqNjtqe8=;
        b=IXqTipDTIzwpDTqhy+sJ2IQ63aPFevIucceFggjYkAVfMl3MI6aNEqDCQfnsfxrg2s
         6VnoCLe5tfoxmzSy7XljZfqR/ilFIOpVD0D1LfIa2zHN6T9LSq79Mx8g/yvcsD2ua433
         Fvk1iG3ZgfmxkpWG4Jc0M23rechwMW+3zslGdsEhvJd9Y6GtTQQ4nlEsNgIrReITu6+f
         AiiMFoud53eEVERoPpF0MunLXXFE/ckYHwklRyCrvUpcFM2qe0brRfhX8psi/4YxpI5M
         v0bjbuGv0rszvopx/HTYHD9r0jRXGNb/yora4p2RkcD3s9gijk469dyy/TaZuYp26WYI
         B9Zg==
X-Gm-Message-State: AOAM530g3PbQi30kHQQWbJVfy4MbDUuh6VD4iKoe3XmfJJoPCb6vBRmo
	3uhPgOnOkAvij/g1YEC/UD8=
X-Google-Smtp-Source: ABdhPJzuqmviV3vutEjHAVvh6ry+9Hwrmd//Nm2QPeCY1TzVEUwjdrrEOpdr1ds5exnt/bZhRUUrMg==
X-Received: by 2002:a2e:a5c8:: with SMTP id n8mr301030ljp.307.1635369480150;
        Wed, 27 Oct 2021 14:18:00 -0700 (PDT)
From: Dmitry Osipenko <digetx@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Lee Jones <lee.jones@linaro.org>,
	"Rafael J . Wysocki" <rafael@kernel.org>,
	Mark Brown <broonie@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Russell King <linux@armlinux.org.uk>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Ulf Hansson <ulf.hansson@linaro.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Guo Ren <guoren@kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Greg Ungerer <gerg@linux-m68k.org>,
	Joshua Thompson <funaho@jurai.org>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Nick Hu <nickhu@andestech.com>,
	Greentime Hu <green.hu@gmail.com>,
	Vincent Chen <deanbo422@gmail.com>,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	Helge Deller <deller@gmx.de>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Rich Felker <dalias@libc.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Len Brown <lenb@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Chen-Yu Tsai <wens@csie.org>,
	=?UTF-8?q?Jonathan=20Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>,
	Tony Lindgren <tony@atomide.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Vladimir Zapolskiy <vz@mleia.com>,
	Avi Fishman <avifishman70@gmail.com>,
	Tomer Maimon <tmaimon77@gmail.com>,
	Tali Perry <tali.perry1@gmail.com>,
	Patrick Venture <venture@google.com>,
	Nancy Yuen <yuenn@google.com>,
	Benjamin Fair <benjaminfair@google.com>,
	Pavel Machek <pavel@ucw.cz>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	linux-csky@vger.kernel.org,
	linux-ia64@vger.kernel.org,
	linux-m68k@lists.linux-m68k.org,
	linux-mips@vger.kernel.org,
	linux-parisc@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-riscv@lists.infradead.org,
	linux-sh@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	linux-acpi@vger.kernel.org,
	linux-omap@vger.kernel.org,
	openbmc@lists.ozlabs.org,
	linux-tegra@vger.kernel.org,
	linux-pm@vger.kernel.org
Subject: [PATCH v2 04/45] reboot: Correct typo in a comment
Date: Thu, 28 Oct 2021 00:16:34 +0300
Message-Id: <20211027211715.12671-5-digetx@gmail.com>
X-Mailer: git-send-email 2.33.1
In-Reply-To: <20211027211715.12671-1-digetx@gmail.com>
References: <20211027211715.12671-1-digetx@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Correct s/implemenations/implementations/ in <reboot.h>.

Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
 include/linux/reboot.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/reboot.h b/include/linux/reboot.h
index af907a3d68d1..7c288013a3ca 100644
--- a/include/linux/reboot.h
+++ b/include/linux/reboot.h
@@ -63,7 +63,7 @@ struct pt_regs;
 extern void machine_crash_shutdown(struct pt_regs *);
 
 /*
- * Architecture independent implemenations of sys_reboot commands.
+ * Architecture independent implementations of sys_reboot commands.
  */
 
 extern void kernel_restart_prepare(char *cmd);
-- 
2.33.1



From xen-devel-bounces@lists.xenproject.org Wed Oct 27 21:18:21 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Oct 2021 21:18:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217218.377170 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfqJR-0002th-Kx; Wed, 27 Oct 2021 21:18:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217218.377170; Wed, 27 Oct 2021 21:18:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfqJR-0002tQ-Gh; Wed, 27 Oct 2021 21:18:21 +0000
Received: by outflank-mailman (input) for mailman id 217218;
 Wed, 27 Oct 2021 21:18:20 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=nMly=PP=gmail.com=digetx@srs-us1.protection.inumbo.net>)
 id 1mfqJQ-0000sJ-8j
 for xen-devel@lists.xenproject.org; Wed, 27 Oct 2021 21:18:20 +0000
Received: from mail-lf1-x133.google.com (unknown [2a00:1450:4864:20::133])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 2e7b98de-8165-4f45-971f-8de142cf3589;
 Wed, 27 Oct 2021 21:18:03 +0000 (UTC)
Received: by mail-lf1-x133.google.com with SMTP id bp15so9011871lfb.4
 for <xen-devel@lists.xenproject.org>; Wed, 27 Oct 2021 14:18:03 -0700 (PDT)
Received: from localhost.localdomain (46-138-41-28.dynamic.spd-mgts.ru.
 [46.138.41.28])
 by smtp.gmail.com with ESMTPSA id d7sm104336ljl.18.2021.10.27.14.18.00
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Wed, 27 Oct 2021 14:18:01 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2e7b98de-8165-4f45-971f-8de142cf3589
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=O+IvQoJf2OjzCPAk90L+IlIvsTQGqRsS8A3mVG9thss=;
        b=BbS8+/zxVJ00rr3ixtYTd3bTdxqjkUjnBr55DaOxzJArvyNX4521PAqPigYX/BjB1N
         aGylVDFiYrs5wRaWuZx6L52it/PPywema7yDnahBHenwiuFnc4S3m//ivsOGtXuUlPNB
         ubXOhenNVEu1KXB2mXMptIWVwaeJRf3hxW3c8R68HPPg3pjoH3MM7xhUxuphpty83aFx
         DGHamMHIXY7/zgP3wsKkRhZ7yEHgmahY/byikn8BiZjEw2DWUQkjcB5nYo+Xgh+eH8p4
         oVpJycq4ZWi1GYj36y1/HBYlXfcjUxN5WpbpwFTT0cF/PRko7dGul5P66XpFeKCAINSY
         8XVA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=O+IvQoJf2OjzCPAk90L+IlIvsTQGqRsS8A3mVG9thss=;
        b=UrfxMbjD6aQoXDBgVtOUbnWc7vAvnH2w3/rUs7LcfMphW1ZXGXJyq9lh1MVz6uVbqk
         SGlM5lcxzse7UHKOMm1smaDj1Mmy0ii9G+lGn3AcanYrIEwnI+Dx4DL3ec3JfKiuGThH
         dFdt+0Syw8B2psNEoijmQwaXBomClChOXwE/vbU8k2Zz/ZMOLo4uQ71HM0DwbTwTlkls
         nd1hH9CoAST9DZT0M+0DLvJmmPNlPndJWSwj9L+rWm/zBJ+mddO9vjXWbmV4rXx8DLXH
         7c1EmoE/gRR9iaZ8M7Nu6sCUIE99+CVu7luE27o6kuFUtRCUsUdu950raQWn/TMZWWGK
         2hLQ==
X-Gm-Message-State: AOAM531ZoPascVNJv1Xnz4IO88Octe6frNZVLO+3PmAk/2JUHFPWsjyw
	3nGTLCCQPJFVES/oEGPZAOo=
X-Google-Smtp-Source: ABdhPJxyJaCNELbykyJ8mI+u0lU4wtjMFWua0Lm4EEmjlSiKb32hiTjDEQ+OHhGC/feOlGuy6qCfSA==
X-Received: by 2002:ac2:4285:: with SMTP id m5mr140041lfh.86.1635369481970;
        Wed, 27 Oct 2021 14:18:01 -0700 (PDT)
From: Dmitry Osipenko <digetx@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Lee Jones <lee.jones@linaro.org>,
	"Rafael J . Wysocki" <rafael@kernel.org>,
	Mark Brown <broonie@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Russell King <linux@armlinux.org.uk>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Ulf Hansson <ulf.hansson@linaro.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Guo Ren <guoren@kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Greg Ungerer <gerg@linux-m68k.org>,
	Joshua Thompson <funaho@jurai.org>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Nick Hu <nickhu@andestech.com>,
	Greentime Hu <green.hu@gmail.com>,
	Vincent Chen <deanbo422@gmail.com>,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	Helge Deller <deller@gmx.de>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Rich Felker <dalias@libc.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Len Brown <lenb@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Chen-Yu Tsai <wens@csie.org>,
	=?UTF-8?q?Jonathan=20Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>,
	Tony Lindgren <tony@atomide.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Vladimir Zapolskiy <vz@mleia.com>,
	Avi Fishman <avifishman70@gmail.com>,
	Tomer Maimon <tmaimon77@gmail.com>,
	Tali Perry <tali.perry1@gmail.com>,
	Patrick Venture <venture@google.com>,
	Nancy Yuen <yuenn@google.com>,
	Benjamin Fair <benjaminfair@google.com>,
	Pavel Machek <pavel@ucw.cz>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	linux-csky@vger.kernel.org,
	linux-ia64@vger.kernel.org,
	linux-m68k@lists.linux-m68k.org,
	linux-mips@vger.kernel.org,
	linux-parisc@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-riscv@lists.infradead.org,
	linux-sh@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	linux-acpi@vger.kernel.org,
	linux-omap@vger.kernel.org,
	openbmc@lists.ozlabs.org,
	linux-tegra@vger.kernel.org,
	linux-pm@vger.kernel.org
Subject: [PATCH v2 05/45] reboot: Warn if restart handler has duplicated priority
Date: Thu, 28 Oct 2021 00:16:35 +0300
Message-Id: <20211027211715.12671-6-digetx@gmail.com>
X-Mailer: git-send-email 2.33.1
In-Reply-To: <20211027211715.12671-1-digetx@gmail.com>
References: <20211027211715.12671-1-digetx@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Add sanity check which ensures that there are no two restart handlers
registered with the same priority. Normally it's a direct sign of a
problem if two handlers use the same priority.

Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
 kernel/reboot.c | 15 ++++++++++++++-
 1 file changed, 14 insertions(+), 1 deletion(-)

diff --git a/kernel/reboot.c b/kernel/reboot.c
index efb40d095d1e..d39e599c3c99 100644
--- a/kernel/reboot.c
+++ b/kernel/reboot.c
@@ -182,7 +182,20 @@ static ATOMIC_NOTIFIER_HEAD(restart_handler_list);
  */
 int register_restart_handler(struct notifier_block *nb)
 {
-	return atomic_notifier_chain_register(&restart_handler_list, nb);
+	int ret;
+
+	ret = atomic_notifier_chain_register(&restart_handler_list, nb);
+	if (ret)
+		return ret;
+
+	/*
+	 * Handler must have unique priority. Otherwise invocation order is
+	 * determined by the registration order, which is presumed to be
+	 * unreliable.
+	 */
+	WARN_ON(!atomic_notifier_has_unique_priority(&restart_handler_list, nb));
+
+	return 0;
 }
 EXPORT_SYMBOL(register_restart_handler);
 
-- 
2.33.1



From xen-devel-bounces@lists.xenproject.org Wed Oct 27 21:18:27 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Oct 2021 21:18:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217223.377180 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfqJX-0003Sk-5a; Wed, 27 Oct 2021 21:18:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217223.377180; Wed, 27 Oct 2021 21:18:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfqJX-0003Sa-0W; Wed, 27 Oct 2021 21:18:27 +0000
Received: by outflank-mailman (input) for mailman id 217223;
 Wed, 27 Oct 2021 21:18:25 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=nMly=PP=gmail.com=digetx@srs-us1.protection.inumbo.net>)
 id 1mfqJV-0000sJ-8v
 for xen-devel@lists.xenproject.org; Wed, 27 Oct 2021 21:18:25 +0000
Received: from mail-lf1-x12b.google.com (unknown [2a00:1450:4864:20::12b])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id ed0e3168-9c8e-4547-b3ab-80654ef25559;
 Wed, 27 Oct 2021 21:18:04 +0000 (UTC)
Received: by mail-lf1-x12b.google.com with SMTP id f3so803673lfu.12
 for <xen-devel@lists.xenproject.org>; Wed, 27 Oct 2021 14:18:04 -0700 (PDT)
Received: from localhost.localdomain (46-138-41-28.dynamic.spd-mgts.ru.
 [46.138.41.28])
 by smtp.gmail.com with ESMTPSA id d7sm104336ljl.18.2021.10.27.14.18.02
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Wed, 27 Oct 2021 14:18:03 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ed0e3168-9c8e-4547-b3ab-80654ef25559
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=iOJthmuPEC7IB5L8OM1uajmE3s/Ei+DiZXNIsEtdoSk=;
        b=M6DsUnX+Dqnnl5/0WkKsChXFOe/dRyATOHCL/N/d/DYRaMuFNhNXN2y8l/5KKDdvO8
         HePUBv3ijZ6wA1hQMS8r/8Dy8p8fDstfsgPNvYzogEnoiN08aVSWSCzuevGifeB4Cbsl
         JU+F7xYiyB1f3JwKGti4sTNyf7tgTKcPyJdN2KeBPBno+Y11B21cmAzeN1UTCPeELLZl
         qo9vl+NLInil/J95xFZK38OdgQBYthlLceqQb/6Zg0gcqPneeFesfA544/Mc5a4V8TTa
         vBfOArxwV6NLDS9FtxVb4oHCbiHa9QgKi34nHbfFFiWQfKG+GQY4kpTfJykuXmLPssEZ
         NnyA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=iOJthmuPEC7IB5L8OM1uajmE3s/Ei+DiZXNIsEtdoSk=;
        b=v2Wu1pBzcuimhXiQpobWtfPQk1jmkCVHOFitT/T+vNyNgxEblaa05wvJxqwIEACx/c
         kWCPNkiUfpofFZ8AzXxfF1h9GgiZwIlHx7woH8y3b5mwakOLaOGgNgeifd1j4xjcqjyU
         hFi3faP/fl4NGm7Rb/HtWWZDIwHQ9ZGX60IUclnmsKfivqGZuRP42PdUaNZp3Um51oK4
         tqYBUM+C7Rwy+y2w4KBtvNyxLLfHCYi3r4SnU5FFrmtPSdnl1SQ0OvA8fYqrvCl0hd7g
         5Oy24C6s7ppuP/UNcg6a6zQdAhuPicPDZMfegF3KA14DpFoietjAM59eHz4+AQgTysZh
         WuGg==
X-Gm-Message-State: AOAM532sWDDIKQt36CQ3TnAQ6ct21G3ht4iBnLlolyOyxUdF36n54XjA
	TwnCkHeHtO//ZgXQlW5pYas=
X-Google-Smtp-Source: ABdhPJySbOm+27yOjORJjCzB1RrKvb62o79gukvdjDZzwYphfPzvlvqWgT3cY5UK3KGllNbg7CmL+w==
X-Received: by 2002:a05:6512:344a:: with SMTP id j10mr74981lfr.653.1635369483872;
        Wed, 27 Oct 2021 14:18:03 -0700 (PDT)
From: Dmitry Osipenko <digetx@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Lee Jones <lee.jones@linaro.org>,
	"Rafael J . Wysocki" <rafael@kernel.org>,
	Mark Brown <broonie@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Russell King <linux@armlinux.org.uk>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Ulf Hansson <ulf.hansson@linaro.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Guo Ren <guoren@kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Greg Ungerer <gerg@linux-m68k.org>,
	Joshua Thompson <funaho@jurai.org>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Nick Hu <nickhu@andestech.com>,
	Greentime Hu <green.hu@gmail.com>,
	Vincent Chen <deanbo422@gmail.com>,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	Helge Deller <deller@gmx.de>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Rich Felker <dalias@libc.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Len Brown <lenb@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Chen-Yu Tsai <wens@csie.org>,
	=?UTF-8?q?Jonathan=20Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>,
	Tony Lindgren <tony@atomide.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Vladimir Zapolskiy <vz@mleia.com>,
	Avi Fishman <avifishman70@gmail.com>,
	Tomer Maimon <tmaimon77@gmail.com>,
	Tali Perry <tali.perry1@gmail.com>,
	Patrick Venture <venture@google.com>,
	Nancy Yuen <yuenn@google.com>,
	Benjamin Fair <benjaminfair@google.com>,
	Pavel Machek <pavel@ucw.cz>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	linux-csky@vger.kernel.org,
	linux-ia64@vger.kernel.org,
	linux-m68k@lists.linux-m68k.org,
	linux-mips@vger.kernel.org,
	linux-parisc@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-riscv@lists.infradead.org,
	linux-sh@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	linux-acpi@vger.kernel.org,
	linux-omap@vger.kernel.org,
	openbmc@lists.ozlabs.org,
	linux-tegra@vger.kernel.org,
	linux-pm@vger.kernel.org
Subject: [PATCH v2 06/45] reboot: Warn if unregister_restart_handler() fails
Date: Thu, 28 Oct 2021 00:16:36 +0300
Message-Id: <20211027211715.12671-7-digetx@gmail.com>
X-Mailer: git-send-email 2.33.1
In-Reply-To: <20211027211715.12671-1-digetx@gmail.com>
References: <20211027211715.12671-1-digetx@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Emit warning if unregister_restart_handler() fails since it never should
fail. This will ease further API development by catching mistakes early.

Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
 kernel/reboot.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/reboot.c b/kernel/reboot.c
index d39e599c3c99..291d44082f42 100644
--- a/kernel/reboot.c
+++ b/kernel/reboot.c
@@ -210,7 +210,7 @@ EXPORT_SYMBOL(register_restart_handler);
  */
 int unregister_restart_handler(struct notifier_block *nb)
 {
-	return atomic_notifier_chain_unregister(&restart_handler_list, nb);
+	return WARN_ON(atomic_notifier_chain_unregister(&restart_handler_list, nb));
 }
 EXPORT_SYMBOL(unregister_restart_handler);
 
-- 
2.33.1



From xen-devel-bounces@lists.xenproject.org Wed Oct 27 21:18:31 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Oct 2021 21:18:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217228.377192 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfqJb-00041M-DB; Wed, 27 Oct 2021 21:18:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217228.377192; Wed, 27 Oct 2021 21:18:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfqJb-00041E-9P; Wed, 27 Oct 2021 21:18:31 +0000
Received: by outflank-mailman (input) for mailman id 217228;
 Wed, 27 Oct 2021 21:18:30 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=nMly=PP=gmail.com=digetx@srs-us1.protection.inumbo.net>)
 id 1mfqJa-0000sJ-92
 for xen-devel@lists.xenproject.org; Wed, 27 Oct 2021 21:18:30 +0000
Received: from mail-lj1-x22f.google.com (unknown [2a00:1450:4864:20::22f])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 9f7f8704-d885-405c-9c50-3b01bfd973f5;
 Wed, 27 Oct 2021 21:18:06 +0000 (UTC)
Received: by mail-lj1-x22f.google.com with SMTP id n7so6988482ljp.5
 for <xen-devel@lists.xenproject.org>; Wed, 27 Oct 2021 14:18:06 -0700 (PDT)
Received: from localhost.localdomain (46-138-41-28.dynamic.spd-mgts.ru.
 [46.138.41.28])
 by smtp.gmail.com with ESMTPSA id d7sm104336ljl.18.2021.10.27.14.18.03
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Wed, 27 Oct 2021 14:18:05 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9f7f8704-d885-405c-9c50-3b01bfd973f5
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=YMqE3plwxFsGF2jAAFpub/HIgtQoag7R/7s0kLQElmo=;
        b=FUIf1ArHmNaCMJZ4bSQxWbL5JCSm2CJKzXGlBqJrWaAR8tSPTufWS8xOyLSwSu1PM5
         2liVJ/5r60CrtJJr5DfBlw1KykabxABPWMHDsuYjgXtr14EcQg2JUBTjbQBqUDOiqreb
         QGWgVclCqks9knb00wTu5MnkQu4fzkoUJI9+ACesDxpbb8YGJKMHlYbydkINuBcjzEjx
         IFIHDVdQgtIeC1A4mREDvIovPg1tG0nOTZB7ncUf8fLjV8foPKyZUn+53/McMAaFU2Ip
         XymrGCj037mcVReap7wcm8US/GqkUtNAHHKTZ6VwLbtZ8u26dh3C526wfrT0Bgbs2S/w
         m+/Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=YMqE3plwxFsGF2jAAFpub/HIgtQoag7R/7s0kLQElmo=;
        b=agydHyY3LtTwXzA4hAoSA7OCZXDaF4mqDR8dRXHztPFIo8PCdiPJhpL9vXlzY4HQMK
         hRdKi+cdnWzAnpr6obM3m5OSv0/Bfdu6bK+1F77eFZGKsFnrx/zKV+PoViPGNMMNa9Yw
         6TgbES9p4XDwrYMF53H1R9e6f69wtBMyIYNmLqaJfwHP5UW0Nz0MP9FpPwjQX1Pe7Lrg
         4UEcDjKPCzF+gom6GE2jaSliMvQkk4EuZBPfUobzRxvRsDhVCfNgZrPdKqxnUrKXZVn3
         7uuhKJdEAantDviyVOdnM/nlquzDIKFoQbGw+xP80YYTAOh6ZbtzOt7eGpihjDtosA2f
         0qzA==
X-Gm-Message-State: AOAM531mZGPuHLVrhRYoZ3Cr2K/ovUhQx0vnGMFbZMmeNliaFe9QGePW
	AiqQArBoqyrgoGdg/iaevvM=
X-Google-Smtp-Source: ABdhPJwf9klS71294z2BVTXZCugJ9JFGgS+3s6bIBq/C8DIXy9Ezc+U1oWDuHg++RtezU/Ib7TxqLQ==
X-Received: by 2002:a2e:2f19:: with SMTP id v25mr310304ljv.281.1635369485711;
        Wed, 27 Oct 2021 14:18:05 -0700 (PDT)
From: Dmitry Osipenko <digetx@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Lee Jones <lee.jones@linaro.org>,
	"Rafael J . Wysocki" <rafael@kernel.org>,
	Mark Brown <broonie@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Russell King <linux@armlinux.org.uk>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Ulf Hansson <ulf.hansson@linaro.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Guo Ren <guoren@kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Greg Ungerer <gerg@linux-m68k.org>,
	Joshua Thompson <funaho@jurai.org>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Nick Hu <nickhu@andestech.com>,
	Greentime Hu <green.hu@gmail.com>,
	Vincent Chen <deanbo422@gmail.com>,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	Helge Deller <deller@gmx.de>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Rich Felker <dalias@libc.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Len Brown <lenb@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Chen-Yu Tsai <wens@csie.org>,
	=?UTF-8?q?Jonathan=20Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>,
	Tony Lindgren <tony@atomide.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Vladimir Zapolskiy <vz@mleia.com>,
	Avi Fishman <avifishman70@gmail.com>,
	Tomer Maimon <tmaimon77@gmail.com>,
	Tali Perry <tali.perry1@gmail.com>,
	Patrick Venture <venture@google.com>,
	Nancy Yuen <yuenn@google.com>,
	Benjamin Fair <benjaminfair@google.com>,
	Pavel Machek <pavel@ucw.cz>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	linux-csky@vger.kernel.org,
	linux-ia64@vger.kernel.org,
	linux-m68k@lists.linux-m68k.org,
	linux-mips@vger.kernel.org,
	linux-parisc@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-riscv@lists.infradead.org,
	linux-sh@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	linux-acpi@vger.kernel.org,
	linux-omap@vger.kernel.org,
	openbmc@lists.ozlabs.org,
	linux-tegra@vger.kernel.org,
	linux-pm@vger.kernel.org
Subject: [PATCH v2 07/45] reboot: Remove extern annotation from function prototypes
Date: Thu, 28 Oct 2021 00:16:37 +0300
Message-Id: <20211027211715.12671-8-digetx@gmail.com>
X-Mailer: git-send-email 2.33.1
In-Reply-To: <20211027211715.12671-1-digetx@gmail.com>
References: <20211027211715.12671-1-digetx@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

There is no need to annotate function prototypes with 'extern', it makes
code less readable. Remove unnecessary annotations from <reboot.h>.

Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
 include/linux/reboot.h | 38 +++++++++++++++++++-------------------
 1 file changed, 19 insertions(+), 19 deletions(-)

diff --git a/include/linux/reboot.h b/include/linux/reboot.h
index 7c288013a3ca..b7fa25726323 100644
--- a/include/linux/reboot.h
+++ b/include/linux/reboot.h
@@ -40,36 +40,36 @@ extern int reboot_cpu;
 extern int reboot_force;
 
 
-extern int register_reboot_notifier(struct notifier_block *);
-extern int unregister_reboot_notifier(struct notifier_block *);
+int register_reboot_notifier(struct notifier_block *);
+int unregister_reboot_notifier(struct notifier_block *);
 
-extern int devm_register_reboot_notifier(struct device *, struct notifier_block *);
+int devm_register_reboot_notifier(struct device *, struct notifier_block *);
 
-extern int register_restart_handler(struct notifier_block *);
-extern int unregister_restart_handler(struct notifier_block *);
-extern void do_kernel_restart(char *cmd);
+int register_restart_handler(struct notifier_block *);
+int unregister_restart_handler(struct notifier_block *);
+void do_kernel_restart(char *cmd);
 
 /*
  * Architecture-specific implementations of sys_reboot commands.
  */
 
-extern void migrate_to_reboot_cpu(void);
-extern void machine_restart(char *cmd);
-extern void machine_halt(void);
-extern void machine_power_off(void);
+void migrate_to_reboot_cpu(void);
+void machine_restart(char *cmd);
+void machine_halt(void);
+void machine_power_off(void);
 
-extern void machine_shutdown(void);
+void machine_shutdown(void);
 struct pt_regs;
-extern void machine_crash_shutdown(struct pt_regs *);
+void machine_crash_shutdown(struct pt_regs *);
 
 /*
  * Architecture independent implementations of sys_reboot commands.
  */
 
-extern void kernel_restart_prepare(char *cmd);
-extern void kernel_restart(char *cmd);
-extern void kernel_halt(void);
-extern void kernel_power_off(void);
+void kernel_restart_prepare(char *cmd);
+void kernel_restart(char *cmd);
+void kernel_halt(void);
+void kernel_power_off(void);
 
 extern int C_A_D; /* for sysctl */
 void ctrl_alt_del(void);
@@ -77,15 +77,15 @@ void ctrl_alt_del(void);
 #define POWEROFF_CMD_PATH_LEN	256
 extern char poweroff_cmd[POWEROFF_CMD_PATH_LEN];
 
-extern void orderly_poweroff(bool force);
-extern void orderly_reboot(void);
+void orderly_poweroff(bool force);
+void orderly_reboot(void);
 void hw_protection_shutdown(const char *reason, int ms_until_forced);
 
 /*
  * Emergency restart, callable from an interrupt handler.
  */
 
-extern void emergency_restart(void);
+void emergency_restart(void);
 #include <asm/emergency-restart.h>
 
 #endif /* _LINUX_REBOOT_H */
-- 
2.33.1



From xen-devel-bounces@lists.xenproject.org Wed Oct 27 21:18:36 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Oct 2021 21:18:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217231.377203 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfqJg-0004a8-NA; Wed, 27 Oct 2021 21:18:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217231.377203; Wed, 27 Oct 2021 21:18:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfqJg-0004Zz-JE; Wed, 27 Oct 2021 21:18:36 +0000
Received: by outflank-mailman (input) for mailman id 217231;
 Wed, 27 Oct 2021 21:18:35 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=nMly=PP=gmail.com=digetx@srs-us1.protection.inumbo.net>)
 id 1mfqJf-0000sJ-9B
 for xen-devel@lists.xenproject.org; Wed, 27 Oct 2021 21:18:35 +0000
Received: from mail-lf1-x12d.google.com (unknown [2a00:1450:4864:20::12d])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 1b76926b-f49a-49cc-98f7-b7d95f05d555;
 Wed, 27 Oct 2021 21:18:10 +0000 (UTC)
Received: by mail-lf1-x12d.google.com with SMTP id p16so9034533lfa.2
 for <xen-devel@lists.xenproject.org>; Wed, 27 Oct 2021 14:18:10 -0700 (PDT)
Received: from localhost.localdomain (46-138-41-28.dynamic.spd-mgts.ru.
 [46.138.41.28])
 by smtp.gmail.com with ESMTPSA id d7sm104336ljl.18.2021.10.27.14.18.07
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Wed, 27 Oct 2021 14:18:09 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1b76926b-f49a-49cc-98f7-b7d95f05d555
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=BPtMBppPEnkW8FAu+XIJVa0vPCxV8oSZETkwJ9fGFM4=;
        b=evvP7MsJwkqVHf9WWHeVtMPJGHU+mvo2PJqLCvURQO+gDiXejWyY7GbQhAh5S2Yuq3
         zE+MXp6bpyTV9PKDTbTfo9WWXpFtGfj5n4Qz8ioZr0QyDkpV7sVDFNZi5aSeGd0r1ssm
         FaiC2SGtT+UwMk3wtZhRptmS5Jh1EvMlK22P6yAvTfzVBpKlWKTd0CWvNC0iHDJeCUVq
         3jvnGl27YfW1MAZwLzhuSz3oPcJmkrZj59ainuK5d21Jqe/MApWPiIhI2vk+XeD9jyY+
         vEN96KR+en3glKlYAHFchamcvD6xrJYfM61Zs7aonaQIhrzZ8Vd1+JewhOn6GxzMgcou
         E++w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=BPtMBppPEnkW8FAu+XIJVa0vPCxV8oSZETkwJ9fGFM4=;
        b=5fFOu7DkrF+vSSDHjfbO0LPf9+sl2ZbJF843RTdbIZjDQErnn0URrS3PVpBr6JmuIl
         IRQakIOIy71lcYlF5MliBe23A/QR6Sv1u7okFU/a8xUqv4wDYNTY0SCw4KwbH95NE2uE
         erSvBFqpl+nJhnakJq1CH7/qPwmUj+7QzwBQp9KSYClbOvinCdxU9GBqWWbDj5NFGe/T
         PqjIpvkXLBK3Q7rIyJ3dnktobJSLY5rFND+aZ9L+03EO5lDKHvHowXR+QBNhgiUwUj1G
         EhZ4cI4r5wSjIff7cFKPElY0QnYBQskX2FDa6kdh/5IqL3jfQiN++dquDKgswZVKw0I7
         gBDw==
X-Gm-Message-State: AOAM530ablZrBRX8cUOxilCjAkXMrEqugPHAm1G0CgUSJAJ0xUuZbJxf
	KDfzNYe6iMlD7yIRjP6sda8=
X-Google-Smtp-Source: ABdhPJwclkCD48sSOOyIVpWJhTUvxO0ayPfEAseJaJV46PV2ffR0qGAwcKjO8WTuzPJQEhkUDZtmqQ==
X-Received: by 2002:a05:6512:aca:: with SMTP id n10mr147591lfu.66.1635369489587;
        Wed, 27 Oct 2021 14:18:09 -0700 (PDT)
From: Dmitry Osipenko <digetx@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Lee Jones <lee.jones@linaro.org>,
	"Rafael J . Wysocki" <rafael@kernel.org>,
	Mark Brown <broonie@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Russell King <linux@armlinux.org.uk>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Ulf Hansson <ulf.hansson@linaro.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Guo Ren <guoren@kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Greg Ungerer <gerg@linux-m68k.org>,
	Joshua Thompson <funaho@jurai.org>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Nick Hu <nickhu@andestech.com>,
	Greentime Hu <green.hu@gmail.com>,
	Vincent Chen <deanbo422@gmail.com>,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	Helge Deller <deller@gmx.de>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Rich Felker <dalias@libc.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Len Brown <lenb@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Chen-Yu Tsai <wens@csie.org>,
	=?UTF-8?q?Jonathan=20Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>,
	Tony Lindgren <tony@atomide.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Vladimir Zapolskiy <vz@mleia.com>,
	Avi Fishman <avifishman70@gmail.com>,
	Tomer Maimon <tmaimon77@gmail.com>,
	Tali Perry <tali.perry1@gmail.com>,
	Patrick Venture <venture@google.com>,
	Nancy Yuen <yuenn@google.com>,
	Benjamin Fair <benjaminfair@google.com>,
	Pavel Machek <pavel@ucw.cz>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	linux-csky@vger.kernel.org,
	linux-ia64@vger.kernel.org,
	linux-m68k@lists.linux-m68k.org,
	linux-mips@vger.kernel.org,
	linux-parisc@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-riscv@lists.infradead.org,
	linux-sh@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	linux-acpi@vger.kernel.org,
	linux-omap@vger.kernel.org,
	openbmc@lists.ozlabs.org,
	linux-tegra@vger.kernel.org,
	linux-pm@vger.kernel.org
Subject: [PATCH v2 09/45] xen/x86: Use do_kernel_power_off()
Date: Thu, 28 Oct 2021 00:16:39 +0300
Message-Id: <20211027211715.12671-10-digetx@gmail.com>
X-Mailer: git-send-email 2.33.1
In-Reply-To: <20211027211715.12671-1-digetx@gmail.com>
References: <20211027211715.12671-1-digetx@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Kernel now supports chained power-off handlers. Use do_kernel_power_off()
that invokes chained power-off handlers. It also invokes legacy
pm_power_off() for now, which will be removed once all drivers will
be converted to the new power-off API.

Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
 arch/x86/xen/enlighten_pv.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/xen/enlighten_pv.c b/arch/x86/xen/enlighten_pv.c
index 4f63117f09bb..4a0b9b7baf02 100644
--- a/arch/x86/xen/enlighten_pv.c
+++ b/arch/x86/xen/enlighten_pv.c
@@ -32,6 +32,7 @@
 #include <linux/gfp.h>
 #include <linux/edd.h>
 #include <linux/objtool.h>
+#include <linux/reboot.h>
 
 #include <xen/xen.h>
 #include <xen/events.h>
@@ -1087,8 +1088,7 @@ static void xen_machine_halt(void)
 
 static void xen_machine_power_off(void)
 {
-	if (pm_power_off)
-		pm_power_off();
+	do_kernel_power_off();
 	xen_reboot(SHUTDOWN_poweroff);
 }
 
-- 
2.33.1



From xen-devel-bounces@lists.xenproject.org Wed Oct 27 21:18:42 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Oct 2021 21:18:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217233.377214 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfqJm-00059H-11; Wed, 27 Oct 2021 21:18:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217233.377214; Wed, 27 Oct 2021 21:18:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfqJl-000598-Tq; Wed, 27 Oct 2021 21:18:41 +0000
Received: by outflank-mailman (input) for mailman id 217233;
 Wed, 27 Oct 2021 21:18:40 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=nMly=PP=gmail.com=digetx@srs-us1.protection.inumbo.net>)
 id 1mfqJk-0000sJ-9F
 for xen-devel@lists.xenproject.org; Wed, 27 Oct 2021 21:18:40 +0000
Received: from mail-lj1-x229.google.com (unknown [2a00:1450:4864:20::229])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 3344fc9b-88c1-4226-bfe0-1e061a865c5c;
 Wed, 27 Oct 2021 21:18:08 +0000 (UTC)
Received: by mail-lj1-x229.google.com with SMTP id e2so6926591ljg.13
 for <xen-devel@lists.xenproject.org>; Wed, 27 Oct 2021 14:18:08 -0700 (PDT)
Received: from localhost.localdomain (46-138-41-28.dynamic.spd-mgts.ru.
 [46.138.41.28])
 by smtp.gmail.com with ESMTPSA id d7sm104336ljl.18.2021.10.27.14.18.05
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Wed, 27 Oct 2021 14:18:07 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3344fc9b-88c1-4226-bfe0-1e061a865c5c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=fMubR/4yBWUsww90rEyWY4dQ/XIE0qHuvtbXYbD4Pcs=;
        b=PqCG395LcNV60Qtp9Eu+DTDleDk9S+RpTfMF0TfPgeQNI7so50v1YaWYDZEm91iiCp
         stqqT31Aw/f237mfaJZBez2KJOlBBu7yQ98GuPbn0Fd6OHOrOUOIxbGKQzyeoEhI5d7U
         MaBsKPUXg/EUUv+aX6yG0KDR/rz5MnoalTZ2EQX7cxTfGCEi5fn/e2tAfWVQjz7cx+Cl
         FA6SmHKqY94Xx88iXkSj3vwZ5v8NluykZ6pHT7wJbq5dzQ3vU6x4mnoyEhNfbPxeYtlB
         xjgt4J5kOapwcnmeYf3Jiro9Ajf5AzXtfbVfgy9Vs0NcvOiCK5vS43vmXx4Ff0yYTgVu
         NUXA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=fMubR/4yBWUsww90rEyWY4dQ/XIE0qHuvtbXYbD4Pcs=;
        b=izQ5CZGekrlIHPN/N2Ihz05dL9/rP3NQhcwdOEgOEEWCAmtmxc1sr4lNuf/Q/8qswa
         wcsbXaJZ0JSTcV1+g53ixywPuWGeuGpeA06Y8i5Bm7wXnvYAnCbmfRPGzkhxGB0X7Xzc
         YJ53lQlZJxuHiTFwQM0IDAOCSQCbv5/YNHnoklisw4Im10YkXmzgwWCk4yuVCiH8G7tT
         L/HcUe81dPW5DMb3AixJIx5+SElsCNQzHRP1V3EeQEo0CypvW8M0zo5ScmDe4dAj8NIm
         X/tDw2vwHcQTp/bKvGtCapyNHTMr/D6BXVuBayE3VOHG1bea1nMp9YgBjtgWf2Zrf6b5
         Ysdw==
X-Gm-Message-State: AOAM532+uKeB77BK9qDnwu67UFKmo8RYNXBxBsWk2pyprisoX0y0niNq
	VWKIKx8wr801qYTdZu2TIgaQ5XTPYLU=
X-Google-Smtp-Source: ABdhPJx+Js0me0cUAXGk9csOUj0IQmbpvMK95ONWvTRhfCm5GVYebrAN8Mns/32HOctyWJz6JrEWGw==
X-Received: by 2002:a2e:b701:: with SMTP id j1mr325708ljo.133.1635369487617;
        Wed, 27 Oct 2021 14:18:07 -0700 (PDT)
From: Dmitry Osipenko <digetx@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Lee Jones <lee.jones@linaro.org>,
	"Rafael J . Wysocki" <rafael@kernel.org>,
	Mark Brown <broonie@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Russell King <linux@armlinux.org.uk>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Ulf Hansson <ulf.hansson@linaro.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Guo Ren <guoren@kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Greg Ungerer <gerg@linux-m68k.org>,
	Joshua Thompson <funaho@jurai.org>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Nick Hu <nickhu@andestech.com>,
	Greentime Hu <green.hu@gmail.com>,
	Vincent Chen <deanbo422@gmail.com>,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	Helge Deller <deller@gmx.de>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Rich Felker <dalias@libc.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Len Brown <lenb@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Chen-Yu Tsai <wens@csie.org>,
	=?UTF-8?q?Jonathan=20Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>,
	Tony Lindgren <tony@atomide.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Vladimir Zapolskiy <vz@mleia.com>,
	Avi Fishman <avifishman70@gmail.com>,
	Tomer Maimon <tmaimon77@gmail.com>,
	Tali Perry <tali.perry1@gmail.com>,
	Patrick Venture <venture@google.com>,
	Nancy Yuen <yuenn@google.com>,
	Benjamin Fair <benjaminfair@google.com>,
	Pavel Machek <pavel@ucw.cz>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	linux-csky@vger.kernel.org,
	linux-ia64@vger.kernel.org,
	linux-m68k@lists.linux-m68k.org,
	linux-mips@vger.kernel.org,
	linux-parisc@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-riscv@lists.infradead.org,
	linux-sh@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	linux-acpi@vger.kernel.org,
	linux-omap@vger.kernel.org,
	openbmc@lists.ozlabs.org,
	linux-tegra@vger.kernel.org,
	linux-pm@vger.kernel.org
Subject: [PATCH v2 08/45] kernel: Add combined power-off+restart handler call chain API
Date: Thu, 28 Oct 2021 00:16:38 +0300
Message-Id: <20211027211715.12671-9-digetx@gmail.com>
X-Mailer: git-send-email 2.33.1
In-Reply-To: <20211027211715.12671-1-digetx@gmail.com>
References: <20211027211715.12671-1-digetx@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

SoC platforms often have multiple options of how to perform system's
power-off and restart operations. Meanwhile today's kernel is limited to
a single option. Add combined power-off+restart handler call chain API,
which is inspired by the restart API. The new API provides both power-off
and restart functionality.

The old pm_power_off method will be kept around till all users are
converted to the new API.

Current restart API will be replaced by the new unified API since
new API is its superset. The restart functionality of the power-handler
API is built upon the existing restart-notifier APIs.

In order to ease conversion to the new API, convenient helpers are added
for the common use-cases. They will reduce amount of boilerplate code and
remove global variables. These helpers preserve old behaviour for cases
where only one power-off handler is executed, this is what existing
drivers want, and thus, they could be easily converted to the new API.
Users of the new API should explicitly enable power-off chaining by
setting corresponding flag of the power_handler structure.

Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
 include/linux/reboot.h   | 176 +++++++++++-
 kernel/power/hibernate.c |   2 +-
 kernel/reboot.c          | 601 ++++++++++++++++++++++++++++++++++++++-
 3 files changed, 768 insertions(+), 11 deletions(-)

diff --git a/include/linux/reboot.h b/include/linux/reboot.h
index b7fa25726323..0ec835338c27 100644
--- a/include/linux/reboot.h
+++ b/include/linux/reboot.h
@@ -8,10 +8,16 @@
 
 struct device;
 
-#define SYS_DOWN	0x0001	/* Notify of system down */
-#define SYS_RESTART	SYS_DOWN
-#define SYS_HALT	0x0002	/* Notify of system halt */
-#define SYS_POWER_OFF	0x0003	/* Notify of system power off */
+enum reboot_prepare_mode {
+	SYS_DOWN = 1,		/* Notify of system down */
+	SYS_RESTART = SYS_DOWN,
+	SYS_HALT,		/* Notify of system halt */
+	SYS_POWER_OFF,		/* Notify of system power off */
+};
+
+#define RESTART_PRIO_RESERVED		0
+#define RESTART_PRIO_DEFAULT		128
+#define RESTART_PRIO_HIGH		192
 
 enum reboot_mode {
 	REBOOT_UNDEFINED = -1,
@@ -49,6 +55,167 @@ int register_restart_handler(struct notifier_block *);
 int unregister_restart_handler(struct notifier_block *);
 void do_kernel_restart(char *cmd);
 
+/*
+ * Unified poweroff + restart API.
+ */
+
+#define POWEROFF_PRIO_RESERVED		0
+#define POWEROFF_PRIO_PLATFORM		1
+#define POWEROFF_PRIO_DEFAULT		128
+#define POWEROFF_PRIO_HIGH		192
+#define POWEROFF_PRIO_FIRMWARE		224
+
+enum poweroff_mode {
+	POWEROFF_NORMAL = 0,
+	POWEROFF_PREPARE,
+};
+
+struct power_off_data {
+	void *cb_data;
+};
+
+struct power_off_prep_data {
+	void *cb_data;
+};
+
+struct restart_data {
+	void *cb_data;
+	const char *cmd;
+	enum reboot_mode mode;
+};
+
+struct reboot_prep_data {
+	void *cb_data;
+	const char *cmd;
+	enum reboot_prepare_mode mode;
+};
+
+struct power_handler_private_data {
+	struct notifier_block reboot_prep_nb;
+	struct notifier_block power_off_nb;
+	struct notifier_block restart_nb;
+	void (*trivial_power_off_cb)(void);
+	void (*simple_power_off_cb)(void *data);
+	void *simple_power_off_cb_data;
+	bool registered;
+};
+
+/**
+ * struct power_handler - Machine power-off + restart handler
+ *
+ * Describes power-off and restart handlers which are invoked by kernel
+ * to power off or restart this machine.  Supports prioritized chaining for
+ * both restart and power-off handlers.  Callback's priority must be unique.
+ * Intended to be used by device drivers that are responsible for restarting
+ * and powering off hardware which kernel is running on.
+ *
+ * Struct power_handler can be static.  Members of this structure must not be
+ * altered while handler is registered.
+ *
+ * Fill the structure members and pass it to register_power_handler().
+ */
+struct power_handler {
+	/**
+	 * @cb_data:
+	 *
+	 * User data included in callback's argument.
+	 */
+	void *cb_data;
+
+	/**
+	 * @power_off_cb:
+	 *
+	 * Callback that should turn off machine.  Inactive if NULL.
+	 */
+	void (*power_off_cb)(struct power_off_data *data);
+
+	/**
+	 * @power_off_prepare_cb:
+	 *
+	 * Power-off preparation callback.  All power-off preparation callbacks
+	 * are invoked before @restart_cb.  Inactive if NULL.
+	 */
+	void (*power_off_prepare_cb)(struct power_off_prep_data *data);
+
+	/**
+	 * @power_off_priority:
+	 *
+	 * Power-off callback priority, must be unique.  Zero value is
+	 * reassigned to default priority.  Inactive if @power_off_cb is NULL.
+	 */
+	int power_off_priority;
+
+	/**
+	 * @power_off_chaining_allowed:
+	 *
+	 * False if callbacks execution should stop when @power_off_cb fails
+	 * to power off machine.  True if further lower priority power-off
+	 * callback should be executed.
+	 */
+	bool power_off_chaining_allowed;
+
+	/**
+	 * @restart_cb:
+	 *
+	 * Callback that should reboot machine.  Inactive if NULL.
+	 */
+	void (*restart_cb)(struct restart_data *data);
+
+	/**
+	 * @restart_priority:
+	 *
+	 * Restart callback priority, must be unique.  Zero value is reassigned
+	 * to default priority.  Inactive if @restart_cb is NULL.
+	 */
+	int restart_priority;
+
+	/**
+	 * @reboot_prepare_cb:
+	 *
+	 * Reboot preparation callback.  All reboot preparation callbacks are
+	 * invoked before @restart_cb.  Inactive if NULL.
+	 */
+	void (*reboot_prepare_cb)(struct reboot_prep_data *data);
+
+	/**
+	 * @priv:
+	 *
+	 * Internal data.  Shouldn't be touched.
+	 */
+	const struct power_handler_private_data priv;
+};
+
+int register_power_handler(struct power_handler *handler);
+void unregister_power_handler(struct power_handler *handler);
+
+struct power_handler *
+register_simple_power_off_handler(void (*callback)(void *data), void *data);
+
+void unregister_simple_power_off_handler(struct power_handler *handler);
+
+int devm_register_power_handler(struct device *dev,
+				struct power_handler *handler);
+
+int devm_register_simple_power_off_handler(struct device *dev,
+					   void (*callback)(void *data),
+					   void *data);
+
+int devm_register_trivial_power_off_handler(struct device *dev,
+					    void (*callback)(void));
+
+int devm_register_simple_restart_handler(struct device *dev,
+					 void (*callback)(struct restart_data *data),
+					 void *data);
+
+int devm_register_prioritized_restart_handler(struct device *dev,
+					      int priority,
+					      void (*callback)(struct restart_data *data),
+					      void *data);
+
+int register_platform_power_off(void (*power_off)(void));
+
+void do_kernel_power_off(void);
+
 /*
  * Architecture-specific implementations of sys_reboot commands.
  */
@@ -70,6 +237,7 @@ void kernel_restart_prepare(char *cmd);
 void kernel_restart(char *cmd);
 void kernel_halt(void);
 void kernel_power_off(void);
+bool kernel_can_power_off(void);
 
 extern int C_A_D; /* for sysctl */
 void ctrl_alt_del(void);
diff --git a/kernel/power/hibernate.c b/kernel/power/hibernate.c
index 559acef3fddb..13ad98352fde 100644
--- a/kernel/power/hibernate.c
+++ b/kernel/power/hibernate.c
@@ -664,7 +664,7 @@ static void power_down(void)
 		hibernation_platform_enter();
 		fallthrough;
 	case HIBERNATION_SHUTDOWN:
-		if (pm_power_off)
+		if (kernel_can_power_off())
 			kernel_power_off();
 		break;
 	}
diff --git a/kernel/reboot.c b/kernel/reboot.c
index 291d44082f42..779429726616 100644
--- a/kernel/reboot.c
+++ b/kernel/reboot.c
@@ -189,9 +189,8 @@ int register_restart_handler(struct notifier_block *nb)
 		return ret;
 
 	/*
-	 * Handler must have unique priority. Otherwise invocation order is
-	 * determined by the registration order, which is presumed to be
-	 * unreliable.
+	 * Handler must have unique priority. Otherwise call order is
+	 * determined by registration order, which is unreliable.
 	 */
 	WARN_ON(!atomic_notifier_has_unique_priority(&restart_handler_list, nb));
 
@@ -294,6 +293,587 @@ void kernel_halt(void)
 }
 EXPORT_SYMBOL_GPL(kernel_halt);
 
+/*
+ *	Notifier list for kernel code which wants to be called
+ *	to power off the system.
+ */
+static BLOCKING_NOTIFIER_HEAD(power_off_handler_list);
+
+static void dummy_pm_power_off(void)
+{
+	/* temporary stub until pm_power_off() is gone, see more below */
+}
+
+static struct notifier_block *pm_power_off_nb;
+
+/**
+ *	register_power_off_handler - Register function to be called to power off
+ *				     the system
+ *	@nb: Info about handler function to be called
+ *	@nb->priority:	Handler priority. Handlers should follow the
+ *			following guidelines for setting priorities.
+ *			0:	Power-off handler of last resort,
+ *				with limited power-off capabilities
+ *			128:	Default power-off handler; use if no other
+ *				power-off handler is expected to be available,
+ *				and/or if power-off functionality is
+ *				sufficient to power-off the entire system
+ *			255:	Highest priority power-off handler, will
+ *				preempt all other power-off handlers
+ *
+ *	Registers a function with code to be called to power off the
+ *	system.
+ *
+ *	Registered functions will be called as last step of the power-off
+ *	sequence.
+ *
+ *	Registered functions are expected to power off the system immediately.
+ *	If more than one function is registered, the power-off handler priority
+ *	selects which function will be called first.
+ *
+ *	Power-off handlers are expected to be registered from non-architecture
+ *	code, typically from drivers. A typical use case would be a system
+ *	where power-off functionality is provided through a PMIC. Multiple
+ *	power-off handlers may exist; for example, one power-off handler might
+ *	turn off the entire system, while another only turns off part of
+ *	system. In such cases, the power-off handler which only disables part
+ *	of the hardware is expected to register with low priority to ensure
+ *	that it only runs if no other means to power off the system is
+ *	available.
+ *
+ *	Currently always returns zero, as blocking_notifier_chain_register()
+ *	always returns zero.
+ */
+static int register_power_off_handler(struct notifier_block *nb)
+{
+	int ret;
+
+	ret = blocking_notifier_chain_register(&power_off_handler_list, nb);
+	if (ret)
+		return ret;
+
+	/*
+	 * Handler must have unique priority. Otherwise invocation order is
+	 * determined by the registration order, which is presumed to be
+	 * unreliable.
+	 */
+	WARN_ON(!blocking_notifier_has_unique_priority(&power_off_handler_list, nb));
+
+	/*
+	 * Some drivers check whether pm_power_off was already installed.
+	 * Install dummy callback using new API to preserve old behaviour
+	 * for those drivers during period of transition to the new API.
+	 */
+	if (!pm_power_off) {
+		pm_power_off = dummy_pm_power_off;
+		pm_power_off_nb = nb;
+	}
+
+	return 0;
+}
+
+static void unregister_power_off_handler(struct notifier_block *nb)
+{
+	if (nb == pm_power_off_nb) {
+		/*
+		 * Check whether somebody replaced pm_power_off behind
+		 * out back.
+		 */
+		if (!WARN_ON(pm_power_off != dummy_pm_power_off))
+			pm_power_off = NULL;
+
+		pm_power_off_nb = NULL;
+	}
+
+	WARN_ON(blocking_notifier_chain_unregister(&power_off_handler_list, nb));
+}
+
+static void devm_unregister_power_off_handler(void *data)
+{
+	struct notifier_block *nb = data;
+
+	unregister_power_off_handler(nb);
+}
+
+static int devm_register_power_off_handler(struct device *dev,
+					   struct notifier_block *nb)
+{
+	int err;
+
+	err = register_power_off_handler(nb);
+	if (err)
+		return err;
+
+	return devm_add_action_or_reset(dev, devm_unregister_power_off_handler,
+					nb);
+}
+
+static int power_handler_power_off(struct notifier_block *nb,
+				   unsigned long mode, void *unused)
+{
+	struct power_off_prep_data prep_data = {};
+	struct power_handler_private_data *priv;
+	struct power_off_data data = {};
+	struct power_handler *h;
+	int ret = NOTIFY_DONE;
+
+	priv = container_of(nb, struct power_handler_private_data, power_off_nb);
+	h = container_of(priv, struct power_handler, priv);
+	prep_data.cb_data = h->cb_data;
+	data.cb_data = h->cb_data;
+
+	switch (mode) {
+	case POWEROFF_NORMAL:
+		if (h->power_off_cb)
+			h->power_off_cb(&data);
+
+		if (priv->simple_power_off_cb)
+			priv->simple_power_off_cb(priv->simple_power_off_cb_data);
+
+		if (priv->trivial_power_off_cb)
+			priv->trivial_power_off_cb();
+
+		if (!h->power_off_chaining_allowed)
+			ret = NOTIFY_STOP;
+
+		break;
+
+	case POWEROFF_PREPARE:
+		if (h->power_off_prepare_cb)
+			h->power_off_prepare_cb(&prep_data);
+
+		break;
+
+	default:
+		unreachable();
+	}
+
+	return ret;
+}
+
+static int power_handler_restart(struct notifier_block *nb,
+				 unsigned long mode, void *cmd)
+{
+	struct power_handler_private_data *priv;
+	struct restart_data data = {};
+	struct power_handler *h;
+
+	priv = container_of(nb, struct power_handler_private_data, restart_nb);
+	h = container_of(priv, struct power_handler, priv);
+
+	data.cb_data = h->cb_data;
+	data.mode = mode;
+	data.cmd = cmd;
+
+	h->restart_cb(&data);
+
+	return NOTIFY_DONE;
+}
+
+static int power_handler_restart_prep(struct notifier_block *nb,
+				      unsigned long mode, void *cmd)
+{
+	struct power_handler_private_data *priv;
+	struct reboot_prep_data data = {};
+	struct power_handler *h;
+
+	priv = container_of(nb, struct power_handler_private_data, reboot_prep_nb);
+	h = container_of(priv, struct power_handler, priv);
+
+	data.cb_data = h->cb_data;
+	data.mode = mode;
+	data.cmd = cmd;
+
+	h->reboot_prepare_cb(&data);
+
+	return NOTIFY_DONE;
+}
+
+static struct power_handler_private_data *
+power_handler_private_data(struct power_handler *handler)
+{
+	return (struct power_handler_private_data *)&handler->priv;
+}
+
+/**
+ *	devm_register_power_handler - Register power handler
+ *	@dev: Device that registers handler
+ *	@handler: Power handler descriptor
+ *
+ *	Registers power handler that will be called as last step of the
+ *	power-off and restart sequences.
+ *
+ *	Returns zero on success, or error code on failure.
+ */
+int register_power_handler(struct power_handler *handler)
+{
+	struct power_handler_private_data *priv = power_handler_private_data(handler);
+	int err, priority;
+
+	/* sanity-check whether handler is registered twice */
+	if (WARN_ON(priv->registered))
+		return -EBUSY;
+
+	if (handler->power_off_cb || handler->power_off_prepare_cb) {
+		if (handler->power_off_priority == POWEROFF_PRIO_RESERVED)
+			priority = POWEROFF_PRIO_DEFAULT;
+		else
+			priority = handler->power_off_priority;
+
+		priv->power_off_nb.notifier_call = power_handler_power_off;
+		priv->power_off_nb.priority = priority;
+
+		err = register_power_off_handler(&priv->power_off_nb);
+		if (err)
+			goto reset_power_handler;
+	}
+
+	if (handler->restart_cb) {
+		if (handler->restart_priority == RESTART_PRIO_RESERVED)
+			priority = RESTART_PRIO_DEFAULT;
+		else
+			priority = handler->restart_priority;
+
+		priv->restart_nb.notifier_call = power_handler_restart;
+		priv->restart_nb.priority = priority;
+
+		err = register_restart_handler(&priv->restart_nb);
+		if (err)
+			goto unreg_power_off_handler;
+	}
+
+	if (handler->reboot_prepare_cb) {
+		priv->reboot_prep_nb.notifier_call = power_handler_restart_prep;
+		priv->reboot_prep_nb.priority = 0;
+
+		err = register_reboot_notifier(&priv->reboot_prep_nb);
+		if (err)
+			goto unreg_restart_handler;
+	}
+
+	priv->registered = true;
+
+	return 0;
+
+unreg_restart_handler:
+	if (handler->restart_cb)
+		unregister_restart_handler(&priv->restart_nb);
+
+unreg_power_off_handler:
+	if (handler->power_off_cb)
+		unregister_power_off_handler(&priv->power_off_nb);
+
+reset_power_handler:
+	memset(priv, 0, sizeof(*priv));
+
+	return err;
+}
+EXPORT_SYMBOL(register_power_handler);
+
+/**
+ *	unregister_power_handler - Unregister power handler
+ *	@handler: Power handler descriptor
+ *
+ *	Unregisters a previously registered power handler. Does nothing if
+ *	handler is NULL.
+ */
+void unregister_power_handler(struct power_handler *handler)
+{
+	struct power_handler_private_data *priv;
+
+	if (!handler)
+		return;
+
+	priv = power_handler_private_data(handler);
+
+	/* sanity-check whether handler is unregistered twice */
+	if (WARN_ON(!priv->registered))
+		return;
+
+	if (handler->reboot_prepare_cb)
+		unregister_reboot_notifier(&priv->reboot_prep_nb);
+
+	if (handler->restart_cb)
+		unregister_restart_handler(&priv->restart_nb);
+
+	if (handler->power_off_cb)
+		unregister_power_off_handler(&priv->power_off_nb);
+
+	memset(priv, 0, sizeof(*priv));
+}
+EXPORT_SYMBOL(unregister_power_handler);
+
+static void devm_unregister_power_handler(void *data)
+{
+	struct power_handler *handler = data;
+
+	unregister_power_handler(handler);
+}
+
+/**
+ *	devm_register_power_handler - Register power handler
+ *	@dev: Device that registers handler
+ *	@handler: Power handler descriptor
+ *
+ *	Resource-managed variant of register_power_handler();
+ *
+ *	Returns zero on success, or error code on failure.
+ */
+int devm_register_power_handler(struct device *dev,
+				struct power_handler *handler)
+{
+	int err;
+
+	err = register_power_handler(handler);
+	if (err)
+		return err;
+
+	return devm_add_action_or_reset(dev, devm_unregister_power_handler,
+					handler);
+}
+EXPORT_SYMBOL(devm_register_power_handler);
+
+/**
+ *	register_simple_power_off_handler - Register simple power-off callback
+ *	@dev: Device that registers callback
+ *	@callback: Callback function
+ *	@data: Callback's argument
+ *
+ *	Registers power-off callback with default priority, it will be called
+ *	as last step of the power-off sequence.
+ *
+ *	Returns power_handler pointer on success, or ERR_PTR on failure.
+ */
+struct power_handler *
+register_simple_power_off_handler(void (*callback)(void *data), void *data)
+{
+	struct power_handler_private_data *priv;
+	struct power_handler *handler;
+	int err;
+
+	handler = kzalloc(sizeof(*handler), GFP_KERNEL);
+	if (!handler)
+		return ERR_PTR(-ENOMEM);
+
+	priv = power_handler_private_data(handler);
+
+	priv->power_off_nb.notifier_call = power_handler_power_off;
+	priv->power_off_nb.priority = POWEROFF_PRIO_DEFAULT;
+	priv->simple_power_off_cb_data = data;
+	priv->simple_power_off_cb = callback;
+
+	err = register_power_off_handler(&priv->power_off_nb);
+	if (err) {
+		kfree(handler);
+		return ERR_PTR(err);
+	}
+
+	return handler;
+}
+EXPORT_SYMBOL(register_simple_power_off_handler);
+
+/**
+ *	unregister_power_handler - Unregister simple power-off handler
+ *	@handler: Power handler descriptor
+ *
+ *	Unregisters power handler that was registered by
+ *	register_simple_power_off_handler(). Does nothing if handler is
+ *	error or NULL.
+ */
+void unregister_simple_power_off_handler(struct power_handler *handler)
+{
+	struct power_handler_private_data *priv;
+
+	if (!IS_ERR_OR_NULL(handler)) {
+		priv = power_handler_private_data(handler);
+		unregister_power_off_handler(&priv->power_off_nb);
+		kfree(handler);
+	}
+}
+EXPORT_SYMBOL(unregister_simple_power_off_handler);
+
+/**
+ *	devm_register_simple_power_off_handler - Register simple power-off callback
+ *	@dev: Device that registers callback
+ *	@callback: Callback function
+ *	@data: Callback's argument
+ *
+ *	Registers resource-managed power-off callback with default priority,
+ *	it will be called as last step of the power-off sequence. Further
+ *	lower priority callbacks won't be executed if this @callback fails.
+ *
+ *	Returns zero on success, or error code on failure.
+ */
+int devm_register_simple_power_off_handler(struct device *dev,
+					   void (*callback)(void *data),
+					   void *data)
+{
+	struct power_handler_private_data *priv;
+	struct power_handler *handler;
+
+	handler = devm_kzalloc(dev, sizeof(*handler), GFP_KERNEL);
+	if (!handler)
+		return -ENOMEM;
+
+	priv = power_handler_private_data(handler);
+
+	priv->power_off_nb.notifier_call = power_handler_power_off;
+	priv->power_off_nb.priority = POWEROFF_PRIO_DEFAULT;
+	priv->simple_power_off_cb_data = data;
+	priv->simple_power_off_cb = callback;
+
+	return devm_register_power_off_handler(dev, &priv->power_off_nb);
+}
+EXPORT_SYMBOL(devm_register_simple_power_off_handler);
+
+/**
+ *	devm_register_trivial_power_off_handler - Register trivial power-off callback
+ *	@dev: Device that registers callback
+ *	@desc: Callback descriptor
+ *
+ *	Same as devm_register_simple_power_off_handler(), but callback
+ *	doesn't take argument. Further lower priority callbacks won't be
+ *	executed if this @callback fails.
+ *
+ *	Returns zero on success, or error code on failure.
+ */
+int devm_register_trivial_power_off_handler(struct device *dev,
+					    void (*callback)(void))
+{
+	struct power_handler_private_data *priv;
+	struct power_handler *handler;
+
+	handler = devm_kzalloc(dev, sizeof(*handler), GFP_KERNEL);
+	if (!handler)
+		return -ENOMEM;
+
+	priv = power_handler_private_data(handler);
+
+	priv->power_off_nb.notifier_call = power_handler_power_off;
+	priv->power_off_nb.priority = POWEROFF_PRIO_DEFAULT;
+	priv->trivial_power_off_cb = callback;
+
+	return devm_register_power_off_handler(dev, &priv->power_off_nb);
+}
+EXPORT_SYMBOL(devm_register_trivial_power_off_handler);
+
+/**
+ *	devm_register_simple_restart_handler - Register simple restart callback
+ *	@dev: Device that registers callback
+ *	@callback: Callback function
+ *	@data: Callback's argument
+ *
+ *	Registers resource-managed restart callback with default priority,
+ *	it will be called as last step of the restart sequence.
+ *
+ *	Returns zero on success, or error code on failure.
+ */
+int devm_register_simple_restart_handler(struct device *dev,
+					 void (*callback)(struct restart_data *data),
+					 void *data)
+{
+	return devm_register_prioritized_restart_handler(dev,
+							 RESTART_PRIO_DEFAULT,
+							 callback, data);
+}
+EXPORT_SYMBOL(devm_register_simple_restart_handler);
+
+/**
+ *	devm_register_prioritized_restart_handler - Register prioritized restart callback
+ *	@dev: Device that registers callback
+ *	@priority: Callback's priority
+ *	@callback: Callback function
+ *	@data: Callback's argument
+ *
+ *	Registers resource-managed restart callback with a given priority,
+ *	it will be called as last step of the restart sequence.
+ *
+ *	Returns zero on success, or error code on failure.
+ */
+int devm_register_prioritized_restart_handler(struct device *dev,
+					      int priority,
+					      void (*callback)(struct restart_data *data),
+					      void *data)
+{
+	struct power_handler *handler;
+
+	handler = devm_kzalloc(dev, sizeof(*handler), GFP_KERNEL);
+	if (!handler)
+		return -ENOMEM;
+
+	handler->restart_priority = priority;
+	handler->restart_cb = callback;
+	handler->cb_data = data;
+
+	return devm_register_power_handler(dev, handler);
+}
+EXPORT_SYMBOL(devm_register_prioritized_restart_handler);
+
+static struct power_handler platform_power_off_handler = {
+	.priv = {
+		.power_off_nb = {
+			.notifier_call = power_handler_power_off,
+			.priority = POWEROFF_PRIO_PLATFORM,
+		},
+	},
+};
+
+/**
+ *	register_platform_power_off - Register platform-level power-off callback
+ *	@power_off: Power-off callback
+ *
+ *	Registers power-off callback that will be called as last step
+ *	of the power-off sequence. This callback is expected to be invoked
+ *	for the last resort. Further lower priority callbacks won't be
+ *	executed if @power_off fails. Only one platform power-off callback
+ *	is allowed to be registered.
+ *
+ *	Returns zero on success, or error code on failure.
+ */
+int register_platform_power_off(void (*power_off)(void))
+{
+	struct power_handler_private_data *priv;
+
+	/* this function is allowed to be called only once */
+	if (WARN_ON(platform_power_off_handler.priv.trivial_power_off_cb))
+		return -EBUSY;
+
+	priv = power_handler_private_data(&platform_power_off_handler);
+	priv->trivial_power_off_cb = power_off;
+
+	return register_power_off_handler(&priv->power_off_nb);
+}
+
+/**
+ *	do_kernel_power_off - Execute kernel power-off handler call chain
+ *
+ *	Calls functions registered with register_power_off_handler.
+ *
+ *	Expected to be called as last step of the power-off sequence.
+ *
+ *	Powers off the system immediately if a power-off handler function has
+ *	been registered. Otherwise does nothing.
+ */
+void do_kernel_power_off(void)
+{
+	/* legacy pm_power_off() is unchained and it has highest priority */
+	if (pm_power_off && pm_power_off != dummy_pm_power_off)
+		return pm_power_off();
+
+	blocking_notifier_call_chain(&power_off_handler_list, POWEROFF_NORMAL,
+				     NULL);
+}
+
+static void do_kernel_power_off_prepare(void)
+{
+	/* legacy pm_power_off_prepare() is unchained and it has highest priority */
+	if (pm_power_off_prepare)
+		return pm_power_off_prepare();
+
+	blocking_notifier_call_chain(&power_off_handler_list, POWEROFF_PREPARE,
+				     NULL);
+}
+
 /**
  *	kernel_power_off - power_off the system
  *
@@ -302,8 +882,7 @@ EXPORT_SYMBOL_GPL(kernel_halt);
 void kernel_power_off(void)
 {
 	kernel_shutdown_prepare(SYSTEM_POWER_OFF);
-	if (pm_power_off_prepare)
-		pm_power_off_prepare();
+	do_kernel_power_off_prepare();
 	migrate_to_reboot_cpu();
 	syscore_shutdown();
 	pr_emerg("Power down\n");
@@ -312,6 +891,16 @@ void kernel_power_off(void)
 }
 EXPORT_SYMBOL_GPL(kernel_power_off);
 
+bool kernel_can_power_off(void)
+{
+	if (!pm_power_off &&
+	    blocking_notifier_call_chain_empty(&power_off_handler_list))
+		return false;
+
+	return true;
+}
+EXPORT_SYMBOL_GPL(kernel_can_power_off);
+
 DEFINE_MUTEX(system_transition_mutex);
 
 /*
@@ -353,7 +942,7 @@ SYSCALL_DEFINE4(reboot, int, magic1, int, magic2, unsigned int, cmd,
 	/* Instead of trying to make the power_off code look like
 	 * halt when pm_power_off is not set do it the easy way.
 	 */
-	if ((cmd == LINUX_REBOOT_CMD_POWER_OFF) && !pm_power_off)
+	if (cmd == LINUX_REBOOT_CMD_POWER_OFF && !kernel_can_power_off())
 		cmd = LINUX_REBOOT_CMD_HALT;
 
 	mutex_lock(&system_transition_mutex);
-- 
2.33.1



From xen-devel-bounces@lists.xenproject.org Wed Oct 27 21:19:31 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Oct 2021 21:19:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217250.377225 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfqKU-0006kd-H9; Wed, 27 Oct 2021 21:19:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217250.377225; Wed, 27 Oct 2021 21:19:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfqKU-0006kW-De; Wed, 27 Oct 2021 21:19:26 +0000
Received: by outflank-mailman (input) for mailman id 217250;
 Wed, 27 Oct 2021 21:19:25 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mfqKT-0006k6-6t; Wed, 27 Oct 2021 21:19:25 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mfqKS-0004aa-SY; Wed, 27 Oct 2021 21:19:24 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mfqKS-0005j3-HR; Wed, 27 Oct 2021 21:19:24 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mfqKS-0004fv-Gy; Wed, 27 Oct 2021 21:19:24 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=4AXboFFIBpGS8MeQYyny0pSAazGKu5vCqbuQYfm+8/o=; b=w4l9c4rUnr6yeIfYuibgcwcBtw
	SUIumOta6XIx64+DtdJBDZcBjX2mdAplfTozwJEPBHrg/PGdW+V8yH8VeJbESiZfvdhSA12xKTJ7S
	ozUzJr97dumx9MVd0uwvdpsrkLktiahpoYYZ+ZJk3ccYhUKXndtjTpeMMdwkmmPHusTM=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165901-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 165901: regressions - FAIL
X-Osstest-Failures:
    qemu-mainline:build-i386:xen-build:fail:regression
    qemu-mainline:build-i386-xsm:xen-build:fail:regression
    qemu-mainline:build-armhf:xen-build:fail:regression
    qemu-mainline:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-amd:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-pair:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-freebsd10-i386:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-freebsd10-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-coresched-i386-xl:build-check(1):blocked:nonblocking
    qemu-mainline:build-armhf-libvirt:build-check(1):blocked:nonblocking
    qemu-mainline:build-i386-libvirt:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-intel:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-shadow:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-vhd:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=931ce30859176f0f7daac6bac255dae5eb21284e
X-Osstest-Versions-That:
    qemuu=50352cce138ef3b30c1cda28a4df68fff5da3202
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 27 Oct 2021 21:19:24 +0000

flight 165901 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165901/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-i386                    6 xen-build                fail REGR. vs. 165682
 build-i386-xsm                6 xen-build                fail REGR. vs. 165682
 build-armhf                   6 xen-build                fail REGR. vs. 165682

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl           1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-credit2   1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-cubietruck  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-multivcpu  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-rtds      1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-vhd       1 build-check(1)               blocked  n/a
 test-amd64-i386-qemuu-rhel6hvm-amd  1 build-check(1)               blocked n/a
 test-amd64-i386-pair          1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-freebsd10-i386  1 build-check(1)               blocked  n/a
 test-amd64-i386-freebsd10-amd64  1 build-check(1)               blocked  n/a
 test-amd64-coresched-i386-xl  1 build-check(1)               blocked  n/a
 build-armhf-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-arndale   1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-credit1   1 build-check(1)               blocked  n/a
 test-amd64-i386-qemuu-rhel6hvm-intel  1 build-check(1)             blocked n/a
 test-amd64-i386-xl            1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-pvshim     1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-qemuu-debianhvm-amd64  1 build-check(1)         blocked n/a
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow  1 build-check(1)  blocked n/a
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm  1 build-check(1)      blocked n/a
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 1 build-check(1) blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a
 test-amd64-i386-xl-qemuu-win7-amd64  1 build-check(1)              blocked n/a
 test-amd64-i386-xl-qemuu-ws16-amd64  1 build-check(1)              blocked n/a
 test-amd64-i386-xl-shadow     1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-vhd        1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-xsm        1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165682
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165682
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165682
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 qemuu                931ce30859176f0f7daac6bac255dae5eb21284e
baseline version:
 qemuu                50352cce138ef3b30c1cda28a4df68fff5da3202

Last test of basis   165682  2021-10-19 21:09:14 Z    8 days
Failing since        165694  2021-10-20 18:09:12 Z    7 days   17 attempts
Testing same since   165883  2021-10-26 21:38:10 Z    0 days    3 attempts

------------------------------------------------------------
People who touched revisions under test:
  Alistair Francis <alistair.francis@wdc.com>
  Andrew Jones <drjones@redhat.com>
  Ani Sinha <ani@anisinha.ca>
  BALATON Zoltan <balaton@eik.bme.hu>
  Bin Meng <bmeng.cn@gmail.com>
  Cédric Le Goater <clg@kaod.org>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  David Gibson <david@gibson.dropbear.id.au>
  David Hildenbrand <david@redhat.com>
  Dr. David Alan Gilbert <dgilbert@redhat.com>
  Eric Auger <eric.auger@redhat.com>
  Eugenio Pérez <eperezma@redhat.com>
  Frank Chang <frank.chang@sifive.com>
  Gavin Shan <gshan@redhat.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Greg Kurz <groug@kaod.org>
  Gustavo Romero <gromero@linux.ibm.com>
  Igor Mammedov <imammedo@redhat.com>
  Jason Wang <jasowang@redhat.com>
  John Wang <wangzhiqiang02@inspur.com>
  John Wang <wangzq.jn@gmail.com>
  Laurent Vivier <laurent@vivier.eu>
  Laurent Vivier <lvivier@redhat.com>
  Luc Michel <lmichel@kalray.eu>
  Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
  Matheus Ferst <matheus.ferst@eldorado.org.br>
  Mathieu Poirier <mathieu.poirier@linaro.org>
  Michael S. Tsirkin <mst@redhat.com>
  Mingwang Li <limingwang@huawei.com>
  Oğuz Ersen <oguzersen@protonmail.com>
  Philipp Tomsich <philipp.tomsich@vrull.eu>
  Philippe Mathieu-Daudé <f4bug@amsat.org>
  Philippe Mathieu-Daudé <philmd@redhat.com>
  Richard Henderson <richard.henderson@linaro.org>
  Shuuichirou Ishii <ishii.shuuichir@fujitsu.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Thomas Huth <thuth@redhat.com>
  Tong Ho <tong.ho@xilinx.com>
  Travis Geiselbrecht <travisg@gmail.com>
  Vincent Palatin <vpalatin@rivosinc.com>
  Vivek Goyal <vgoyal@redhat.com>
  Xueming Li <xuemingl@nvidia.com>
  Yanan Wang <wangyanan55@huawei.com>
  Yifei Jiang <jiangyifei@huawei.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               fail    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          blocked 
 test-amd64-i386-xl                                           blocked 
 test-amd64-coresched-i386-xl                                 blocked 
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  blocked 
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       blocked 
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           blocked 
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     blocked 
 test-amd64-i386-freebsd10-amd64                              blocked 
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          blocked 
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          blocked 
 test-armhf-armhf-xl-arndale                                  blocked 
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  blocked 
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  blocked 
 test-armhf-armhf-xl-cubietruck                               blocked 
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         blocked 
 test-amd64-i386-freebsd10-i386                               blocked 
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         blocked 
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                blocked 
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         blocked 
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 blocked 
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    blocked 
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     blocked 
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              blocked 
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    blocked 
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      blocked 
 test-amd64-i386-xl-vhd                                       blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 3749 lines long.)


From xen-devel-bounces@lists.xenproject.org Wed Oct 27 21:28:02 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Oct 2021 21:28:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217271.377244 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfqSb-0008W1-Nc; Wed, 27 Oct 2021 21:27:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217271.377244; Wed, 27 Oct 2021 21:27:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfqSb-0008Uy-Hl; Wed, 27 Oct 2021 21:27:49 +0000
Received: by outflank-mailman (input) for mailman id 217271;
 Wed, 27 Oct 2021 21:27:48 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=nMly=PP=gmail.com=digetx@srs-us1.protection.inumbo.net>)
 id 1mfqLq-0000sJ-D1
 for xen-devel@lists.xenproject.org; Wed, 27 Oct 2021 21:20:50 +0000
Received: from mail-lf1-x12b.google.com (unknown [2a00:1450:4864:20::12b])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 6b24b17d-f326-4da9-87af-f64c80f064d3;
 Wed, 27 Oct 2021 21:18:49 +0000 (UTC)
Received: by mail-lf1-x12b.google.com with SMTP id f3so806989lfu.12
 for <xen-devel@lists.xenproject.org>; Wed, 27 Oct 2021 14:18:49 -0700 (PDT)
Received: from localhost.localdomain (46-138-41-28.dynamic.spd-mgts.ru.
 [46.138.41.28])
 by smtp.gmail.com with ESMTPSA id d7sm104336ljl.18.2021.10.27.14.18.46
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Wed, 27 Oct 2021 14:18:48 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6b24b17d-f326-4da9-87af-f64c80f064d3
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=umNH2+YT7M6ZKcjQGvjjohnKVEe/3rK29YQH+BDj6i4=;
        b=nj5zb43OqtwdizDOJ4YZ+fYZadM1gdDKmRqYZUCoy6YYJ9FK+h8NFV8Fm4J2Ku+dUO
         VD1iu0fINLYL61cuY7tNDYLtDDcpQWTMBS3LiXmrEVigOlROqEfbjJpsrnK8lw9w6k0A
         Q5RVvk+HURAmLxg4yngnt6lHHBxEc4oSlIcG3ZpIBx+R3YAOuuSSdjMf/vRVMuvqCw1Z
         E8uGSsJkZ6VWq/NOLfLD+OAnXKEDLZsNGIWjcaZrIrkicK6f30puV4871fbRXrX4aoDM
         yS04DJACEKWBr3KF/AjOj2De3JGJ2p+GHt74NSrUBKQDPvr858UletsNh5sICSkmVEWD
         3KsQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=umNH2+YT7M6ZKcjQGvjjohnKVEe/3rK29YQH+BDj6i4=;
        b=wRRl6TaF/lWmwyCCvr9GZAD93OnfkRb//X5tW9b5zEnU0uM2wAWxS4zjUIpclUVpBD
         VM40jfJIKs9MgJ+0HlH7YUr54szABsr+RAjAGiLcTQu5qxOYA/Hgpq5WkAXgdBv5JjhD
         OVjB8H/yAA3W6SVDmOHXEIigvB4m3W0pL6Gkcd6qssCrxoTGHD54VDWiy6rTTflhxlij
         1zu/k6X1FJFyzpT7JSsB2BXJIW7lQxQrTIQA4evCaMeFTxxLPbU/RZk5w/r1heTDQaT5
         MVNIrDb8Yfpq6i9L6yMIMnYwsubjUZNXuq+LDx4ex6rQNglXGBpNu7Il9e+uUMTqTLaN
         B+eQ==
X-Gm-Message-State: AOAM531Xz80I7RwlXZ6T1lICkZCULmqZ2QUBAViKksvq4b1zn7TJjX7M
	ZeCBqlwuN83zg5DfVy1BRqg=
X-Google-Smtp-Source: ABdhPJyzuSZuOYHEQbprBgwtJMyx5L9tc7ERtjIIXrEKG72XHaUi8WMWlLHXLzXgCVfDIwEbrdMbVw==
X-Received: by 2002:a05:6512:38d0:: with SMTP id p16mr83922lft.483.1635369528748;
        Wed, 27 Oct 2021 14:18:48 -0700 (PDT)
From: Dmitry Osipenko <digetx@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Lee Jones <lee.jones@linaro.org>,
	"Rafael J . Wysocki" <rafael@kernel.org>,
	Mark Brown <broonie@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Russell King <linux@armlinux.org.uk>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Ulf Hansson <ulf.hansson@linaro.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Guo Ren <guoren@kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Greg Ungerer <gerg@linux-m68k.org>,
	Joshua Thompson <funaho@jurai.org>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Nick Hu <nickhu@andestech.com>,
	Greentime Hu <green.hu@gmail.com>,
	Vincent Chen <deanbo422@gmail.com>,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	Helge Deller <deller@gmx.de>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Rich Felker <dalias@libc.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Len Brown <lenb@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Chen-Yu Tsai <wens@csie.org>,
	=?UTF-8?q?Jonathan=20Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>,
	Tony Lindgren <tony@atomide.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Vladimir Zapolskiy <vz@mleia.com>,
	Avi Fishman <avifishman70@gmail.com>,
	Tomer Maimon <tmaimon77@gmail.com>,
	Tali Perry <tali.perry1@gmail.com>,
	Patrick Venture <venture@google.com>,
	Nancy Yuen <yuenn@google.com>,
	Benjamin Fair <benjaminfair@google.com>,
	Pavel Machek <pavel@ucw.cz>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	linux-csky@vger.kernel.org,
	linux-ia64@vger.kernel.org,
	linux-m68k@lists.linux-m68k.org,
	linux-mips@vger.kernel.org,
	linux-parisc@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-riscv@lists.infradead.org,
	linux-sh@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	linux-acpi@vger.kernel.org,
	linux-omap@vger.kernel.org,
	openbmc@lists.ozlabs.org,
	linux-tegra@vger.kernel.org,
	linux-pm@vger.kernel.org
Subject: [PATCH v2 30/45] mfd: ene-kb3930: Use devm_register_power_handler()
Date: Thu, 28 Oct 2021 00:17:00 +0300
Message-Id: <20211027211715.12671-31-digetx@gmail.com>
X-Mailer: git-send-email 2.33.1
In-Reply-To: <20211027211715.12671-1-digetx@gmail.com>
References: <20211027211715.12671-1-digetx@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Use devm_register_power_handler() that replaces global pm_power_off
variable and allows to register multiple power-off handlers. It also
provides restart-handler support, i.e. all in one API.

Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
 drivers/mfd/ene-kb3930.c | 45 ++++++++++++++--------------------------
 1 file changed, 15 insertions(+), 30 deletions(-)

diff --git a/drivers/mfd/ene-kb3930.c b/drivers/mfd/ene-kb3930.c
index 1b73318d1f1f..6a3c5f48e5e1 100644
--- a/drivers/mfd/ene-kb3930.c
+++ b/drivers/mfd/ene-kb3930.c
@@ -31,10 +31,9 @@ struct kb3930 {
 	struct i2c_client *client;
 	struct regmap *ram_regmap;
 	struct gpio_descs *off_gpios;
+	struct power_handler power_handler;
 };
 
-static struct kb3930 *kb3930_power_off;
-
 #define EC_GPIO_WAVE		0
 #define EC_GPIO_OFF_MODE	1
 
@@ -60,21 +59,19 @@ static void kb3930_off(struct kb3930 *ddata, int off_mode)
 	}
 }
 
-static int kb3930_restart(struct notifier_block *this,
-			  unsigned long mode, void *cmd)
+static void kb3930_restart(struct restart_data *data)
 {
-	kb3930_off(kb3930_power_off, EC_OFF_MODE_REBOOT);
-	return NOTIFY_DONE;
+	struct kb3930 *ddata = data->cb_data;
+
+	kb3930_off(ddata, EC_OFF_MODE_REBOOT);
 }
 
-static void kb3930_pm_power_off(void)
+static void kb3930_power_off(struct power_off_data *data)
 {
-	kb3930_off(kb3930_power_off, EC_OFF_MODE_POWER);
-}
+	struct kb3930 *ddata = data->cb_data;
 
-static struct notifier_block kb3930_restart_nb = {
-	.notifier_call = kb3930_restart,
-};
+	kb3930_off(ddata, EC_OFF_MODE_POWER);
+}
 
 static const struct mfd_cell ariel_ec_cells[] = {
 	{ .name = "dell-wyse-ariel-led", },
@@ -131,7 +128,6 @@ static int kb3930_probe(struct i2c_client *client)
 	if (!ddata)
 		return -ENOMEM;
 
-	kb3930_power_off = ddata;
 	ddata->client = client;
 	i2c_set_clientdata(client, ddata);
 
@@ -169,24 +165,14 @@ static int kb3930_probe(struct i2c_client *client)
 	}
 
 	if (ddata->off_gpios) {
-		register_restart_handler(&kb3930_restart_nb);
-		if (!pm_power_off)
-			pm_power_off = kb3930_pm_power_off;
-	}
+		ddata->power_handler.cb_data = ddata;
+		ddata->power_handler.restart_cb = kb3930_restart;
+		ddata->power_handler.power_off_cb = kb3930_power_off;
 
-	return 0;
-}
-
-static int kb3930_remove(struct i2c_client *client)
-{
-	struct kb3930 *ddata = i2c_get_clientdata(client);
-
-	if (ddata->off_gpios) {
-		if (pm_power_off == kb3930_pm_power_off)
-			pm_power_off = NULL;
-		unregister_restart_handler(&kb3930_restart_nb);
+		ret = devm_register_power_handler(dev, &ddata->power_handler);
+		if (ret)
+			return ret;
 	}
-	kb3930_power_off = NULL;
 
 	return 0;
 }
@@ -199,7 +185,6 @@ MODULE_DEVICE_TABLE(of, kb3930_dt_ids);
 
 static struct i2c_driver kb3930_driver = {
 	.probe_new = kb3930_probe,
-	.remove = kb3930_remove,
 	.driver = {
 		.name = "ene-kb3930",
 		.of_match_table = kb3930_dt_ids,
-- 
2.33.1



From xen-devel-bounces@lists.xenproject.org Wed Oct 27 21:28:02 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Oct 2021 21:28:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217277.377265 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfqSd-0000dU-Jc; Wed, 27 Oct 2021 21:27:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217277.377265; Wed, 27 Oct 2021 21:27:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfqSd-0000cJ-EU; Wed, 27 Oct 2021 21:27:51 +0000
Received: by outflank-mailman (input) for mailman id 217277;
 Wed, 27 Oct 2021 21:27:49 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=nMly=PP=gmail.com=digetx@srs-us1.protection.inumbo.net>)
 id 1mfqL7-0000sJ-Bg
 for xen-devel@lists.xenproject.org; Wed, 27 Oct 2021 21:20:05 +0000
Received: from mail-lf1-x130.google.com (unknown [2a00:1450:4864:20::130])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 8e7ff3db-fb04-477a-9d59-8253b9171804;
 Wed, 27 Oct 2021 21:18:36 +0000 (UTC)
Received: by mail-lf1-x130.google.com with SMTP id x27so9004728lfu.5
 for <xen-devel@lists.xenproject.org>; Wed, 27 Oct 2021 14:18:36 -0700 (PDT)
Received: from localhost.localdomain (46-138-41-28.dynamic.spd-mgts.ru.
 [46.138.41.28])
 by smtp.gmail.com with ESMTPSA id d7sm104336ljl.18.2021.10.27.14.18.33
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Wed, 27 Oct 2021 14:18:35 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8e7ff3db-fb04-477a-9d59-8253b9171804
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=rTg0c6UJkUtA3xox9iyqZdpwaCfteR79knUJVekTw18=;
        b=IOOovw4HthrHOXjOs46Y3yITm9+R54zah3HqdDtgfe0CoTVx3Ny/qQfSWJECq3va5v
         POFxHfUV4nFfAVF/2xQmQF0GAuAxqBjz1BtRvOKx4MR0EfN6IoGEZZUqz+WUpBWyPywt
         GrOnqTwA95eu+J8qffyJd/WsYZnQLcqOy0MiUotidUtoWBtzitEMBsbvSCmIUhOFOmfU
         TN0N1IIFJs2PwhqjyrirBl5OZM0AJ4ETZ7OvQijCQBnaCq4fjrrAiLoAARG8gCOMWpFL
         isJ90k/kflRmNXJGxu4rOU7Ttcg3V2boCXpvP5Lo62Urd2fuc4VonqYdYqPHg73Ap8Wn
         SfNw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=rTg0c6UJkUtA3xox9iyqZdpwaCfteR79knUJVekTw18=;
        b=2Ryq/cOZEhk7RoiARC42+tDS60H2d+EuMIyg06Q1PpOG0Yq/s7z6Ap68lw8o9xwuJC
         qqbj+4IRq/+LcU6dpevIT+wTLbm731cyOdcK0FJAkJDWFkpRZI9OpB9spds1NB0AA7Me
         kqT5K0zvrC/ter1x+4gx3iA6IKc6DhisEBNIROm4dBfHLROH42Umyzdr9S+uadT5k9O0
         U3tKYYhAzFqQcT44405loytao+6b7LpxiZuC2WuJz1qmRytNdt400E5pipIuj2fG7HzS
         FRXP/5T5ELECNh5TfthLVOwh0KbOWpct7SnEcdnekY3cRr39LUAnPIzt88/yPDAPvTGG
         LtEA==
X-Gm-Message-State: AOAM531sfyCzsovH055k4VMx/4FneZeIxwzXNmsEXBMqBXUpHGZN1ILT
	Q6FVsobAu+oYhePupn//BR4=
X-Google-Smtp-Source: ABdhPJxFzFVD2w1ioavz6oJ1REfrGLdo1ULxWozIc4isKil/5p3npr9c6ZJggbEvwegyiOXfsqbr2g==
X-Received: by 2002:a05:6512:3699:: with SMTP id d25mr132127lfs.380.1635369515664;
        Wed, 27 Oct 2021 14:18:35 -0700 (PDT)
From: Dmitry Osipenko <digetx@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Lee Jones <lee.jones@linaro.org>,
	"Rafael J . Wysocki" <rafael@kernel.org>,
	Mark Brown <broonie@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Russell King <linux@armlinux.org.uk>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Ulf Hansson <ulf.hansson@linaro.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Guo Ren <guoren@kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Greg Ungerer <gerg@linux-m68k.org>,
	Joshua Thompson <funaho@jurai.org>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Nick Hu <nickhu@andestech.com>,
	Greentime Hu <green.hu@gmail.com>,
	Vincent Chen <deanbo422@gmail.com>,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	Helge Deller <deller@gmx.de>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Rich Felker <dalias@libc.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Len Brown <lenb@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Chen-Yu Tsai <wens@csie.org>,
	=?UTF-8?q?Jonathan=20Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>,
	Tony Lindgren <tony@atomide.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Vladimir Zapolskiy <vz@mleia.com>,
	Avi Fishman <avifishman70@gmail.com>,
	Tomer Maimon <tmaimon77@gmail.com>,
	Tali Perry <tali.perry1@gmail.com>,
	Patrick Venture <venture@google.com>,
	Nancy Yuen <yuenn@google.com>,
	Benjamin Fair <benjaminfair@google.com>,
	Pavel Machek <pavel@ucw.cz>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	linux-csky@vger.kernel.org,
	linux-ia64@vger.kernel.org,
	linux-m68k@lists.linux-m68k.org,
	linux-mips@vger.kernel.org,
	linux-parisc@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-riscv@lists.infradead.org,
	linux-sh@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	linux-acpi@vger.kernel.org,
	linux-omap@vger.kernel.org,
	openbmc@lists.ozlabs.org,
	linux-tegra@vger.kernel.org,
	linux-pm@vger.kernel.org
Subject: [PATCH v2 23/45] ACPI: power: Switch to power-handler API
Date: Thu, 28 Oct 2021 00:16:53 +0300
Message-Id: <20211027211715.12671-24-digetx@gmail.com>
X-Mailer: git-send-email 2.33.1
In-Reply-To: <20211027211715.12671-1-digetx@gmail.com>
References: <20211027211715.12671-1-digetx@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Switch to power-handler API that replaces legacy pm_power_off callbacks.

Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
 drivers/acpi/sleep.c | 25 +++++++++++--------------
 1 file changed, 11 insertions(+), 14 deletions(-)

diff --git a/drivers/acpi/sleep.c b/drivers/acpi/sleep.c
index 3023224515ab..41b3ea867f8f 100644
--- a/drivers/acpi/sleep.c
+++ b/drivers/acpi/sleep.c
@@ -47,19 +47,11 @@ static void acpi_sleep_tts_switch(u32 acpi_state)
 	}
 }
 
-static int tts_notify_reboot(struct notifier_block *this,
-			unsigned long code, void *x)
+static void tts_reboot_prepare(struct reboot_prep_data *data)
 {
 	acpi_sleep_tts_switch(ACPI_STATE_S5);
-	return NOTIFY_DONE;
 }
 
-static struct notifier_block tts_notifier = {
-	.notifier_call	= tts_notify_reboot,
-	.next		= NULL,
-	.priority	= 0,
-};
-
 static int acpi_sleep_prepare(u32 acpi_state)
 {
 #ifdef CONFIG_ACPI_SLEEP
@@ -1016,7 +1008,7 @@ static void acpi_sleep_hibernate_setup(void)
 static inline void acpi_sleep_hibernate_setup(void) {}
 #endif /* !CONFIG_HIBERNATION */
 
-static void acpi_power_off_prepare(void)
+static void acpi_power_off_prepare(struct power_off_prep_data *data)
 {
 	/* Prepare to power off the system */
 	acpi_sleep_prepare(ACPI_STATE_S5);
@@ -1024,7 +1016,7 @@ static void acpi_power_off_prepare(void)
 	acpi_os_wait_events_complete();
 }
 
-static void acpi_power_off(void)
+static void acpi_power_off(struct power_off_data *data)
 {
 	/* acpi_sleep_prepare(ACPI_STATE_S5) should have already been called */
 	pr_debug("%s called\n", __func__);
@@ -1032,6 +1024,11 @@ static void acpi_power_off(void)
 	acpi_enter_sleep_state(ACPI_STATE_S5);
 }
 
+static struct power_handler acpi_power_handler = {
+	.power_off_priority = POWEROFF_PRIO_FIRMWARE,
+	.reboot_prepare_cb = tts_reboot_prepare,
+};
+
 int __init acpi_sleep_init(void)
 {
 	char supported[ACPI_S_STATE_COUNT * 3 + 1];
@@ -1048,8 +1045,8 @@ int __init acpi_sleep_init(void)
 
 	if (acpi_sleep_state_supported(ACPI_STATE_S5)) {
 		sleep_states[ACPI_STATE_S5] = 1;
-		pm_power_off_prepare = acpi_power_off_prepare;
-		pm_power_off = acpi_power_off;
+		acpi_power_handler.power_off_cb = acpi_power_off;
+		acpi_power_handler.power_off_prepare_cb = acpi_power_off_prepare;
 	} else {
 		acpi_no_s5 = true;
 	}
@@ -1065,6 +1062,6 @@ int __init acpi_sleep_init(void)
 	 * Register the tts_notifier to reboot notifier list so that the _TTS
 	 * object can also be evaluated when the system enters S5.
 	 */
-	register_reboot_notifier(&tts_notifier);
+	register_power_handler(&acpi_power_handler);
 	return 0;
 }
-- 
2.33.1



From xen-devel-bounces@lists.xenproject.org Wed Oct 27 21:28:02 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Oct 2021 21:28:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217276.377262 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfqSd-0000YS-9R; Wed, 27 Oct 2021 21:27:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217276.377262; Wed, 27 Oct 2021 21:27:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfqSd-0000Xy-2E; Wed, 27 Oct 2021 21:27:51 +0000
Received: by outflank-mailman (input) for mailman id 217276;
 Wed, 27 Oct 2021 21:27:48 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=nMly=PP=gmail.com=digetx@srs-us1.protection.inumbo.net>)
 id 1mfqK4-0000sJ-9s
 for xen-devel@lists.xenproject.org; Wed, 27 Oct 2021 21:19:00 +0000
Received: from mail-lf1-x135.google.com (unknown [2a00:1450:4864:20::135])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 53a3346b-be90-451c-9701-5a2efea95047;
 Wed, 27 Oct 2021 21:18:18 +0000 (UTC)
Received: by mail-lf1-x135.google.com with SMTP id j9so8977658lfu.7
 for <xen-devel@lists.xenproject.org>; Wed, 27 Oct 2021 14:18:17 -0700 (PDT)
Received: from localhost.localdomain (46-138-41-28.dynamic.spd-mgts.ru.
 [46.138.41.28])
 by smtp.gmail.com with ESMTPSA id d7sm104336ljl.18.2021.10.27.14.18.15
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Wed, 27 Oct 2021 14:18:16 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 53a3346b-be90-451c-9701-5a2efea95047
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=jIixMSKlDuHM/ROsyXYWDI0GhGtBfDPAGuo/NFEP3H8=;
        b=VuUlnz7weOhSfAIMvRGdAiCqe8Shtv78aoHm3EO65feC0nT0nvvBnSk8QPIhVywkUj
         RNOysBHRGg3KyTpFUTlL4md1P0VicBRamsV0pMYoslyc5mszXHbTC0wuGj5LLTuLIDD2
         VnVcbr+sDBlhSPvrsCXrkM2C7rhvtU8y8OQkbc+espeBKofEXAYEbW1oSchhu8gpHnH6
         5hh0T8v4+pCxxupjUbq3tFFMpwd3gXAylv/eoy7+WuK9q+47ahw0aKqYniKpkL9kizMT
         KLoyc7ML3E1XRsxFnCpxt+IjBVgNhbN/TY6BaYE18l22YJ+9HYMvndESw4+sKVIU4K+r
         XT2Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=jIixMSKlDuHM/ROsyXYWDI0GhGtBfDPAGuo/NFEP3H8=;
        b=m32cSMLIJsIH0DOHYa91t7YgFBaA5HiMMsmYTv8uP8K3GbLEVtT5zgPgkE8GwiPHaH
         p68lWC6qRAZAhh+q9teoz4UIXQY+LI5rAX/bxs6yfOgqs7+dU57DueaRXEvt8FgWrVom
         /bqsyvRvid8/qOm6iTwVJS3tPDqOd1YALp27GzDVR+Lb4ZzJe5nyfTE4zKsw9GtQZg94
         uwWGzuvJQ4BuASPOrqPAhjUSxVg/a6dmoM1z+KQbFxzlJq3D5FkVKFvVuARlYFnScw26
         4IuH79nPJ4l0MfJhgIxzTYyvJfQe0THnTJs/kJz4xIpwlf8Oxgh5oDA7h0As/PxYTNOO
         yOiQ==
X-Gm-Message-State: AOAM530PSjzCtKlj9PQUfIa2DToNa2yzpBPTIY41adC8Msoha7dCmqai
	jha6ZzQCbMj1ccLoJofeHgs=
X-Google-Smtp-Source: ABdhPJzTnlhiIBlvhjatRngwhlUNPcdRxQkZ5VPhYXoHnLeJsw7ZI6sTw6Ma1GzH+vutcEMuVDSyeQ==
X-Received: by 2002:a05:6512:228e:: with SMTP id f14mr113005lfu.610.1635369497072;
        Wed, 27 Oct 2021 14:18:17 -0700 (PDT)
From: Dmitry Osipenko <digetx@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Lee Jones <lee.jones@linaro.org>,
	"Rafael J . Wysocki" <rafael@kernel.org>,
	Mark Brown <broonie@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Russell King <linux@armlinux.org.uk>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Ulf Hansson <ulf.hansson@linaro.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Guo Ren <guoren@kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Greg Ungerer <gerg@linux-m68k.org>,
	Joshua Thompson <funaho@jurai.org>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Nick Hu <nickhu@andestech.com>,
	Greentime Hu <green.hu@gmail.com>,
	Vincent Chen <deanbo422@gmail.com>,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	Helge Deller <deller@gmx.de>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Rich Felker <dalias@libc.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Len Brown <lenb@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Chen-Yu Tsai <wens@csie.org>,
	=?UTF-8?q?Jonathan=20Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>,
	Tony Lindgren <tony@atomide.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Vladimir Zapolskiy <vz@mleia.com>,
	Avi Fishman <avifishman70@gmail.com>,
	Tomer Maimon <tmaimon77@gmail.com>,
	Tali Perry <tali.perry1@gmail.com>,
	Patrick Venture <venture@google.com>,
	Nancy Yuen <yuenn@google.com>,
	Benjamin Fair <benjaminfair@google.com>,
	Pavel Machek <pavel@ucw.cz>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	linux-csky@vger.kernel.org,
	linux-ia64@vger.kernel.org,
	linux-m68k@lists.linux-m68k.org,
	linux-mips@vger.kernel.org,
	linux-parisc@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-riscv@lists.infradead.org,
	linux-sh@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	linux-acpi@vger.kernel.org,
	linux-omap@vger.kernel.org,
	openbmc@lists.ozlabs.org,
	linux-tegra@vger.kernel.org,
	linux-pm@vger.kernel.org
Subject: [PATCH v2 13/45] ia64: Use do_kernel_power_off()
Date: Thu, 28 Oct 2021 00:16:43 +0300
Message-Id: <20211027211715.12671-14-digetx@gmail.com>
X-Mailer: git-send-email 2.33.1
In-Reply-To: <20211027211715.12671-1-digetx@gmail.com>
References: <20211027211715.12671-1-digetx@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Kernel now supports chained power-off handlers. Use do_kernel_power_off()
that invokes chained power-off handlers. It also invokes legacy
pm_power_off() for now, which will be removed once all drivers will
be converted to the new power-off API.

Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
 arch/ia64/kernel/process.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/ia64/kernel/process.c b/arch/ia64/kernel/process.c
index 834df24a88f1..cee4d7db2143 100644
--- a/arch/ia64/kernel/process.c
+++ b/arch/ia64/kernel/process.c
@@ -19,6 +19,7 @@
 #include <linux/module.h>
 #include <linux/notifier.h>
 #include <linux/personality.h>
+#include <linux/reboot.h>
 #include <linux/sched.h>
 #include <linux/sched/debug.h>
 #include <linux/sched/hotplug.h>
@@ -599,8 +600,7 @@ machine_halt (void)
 void
 machine_power_off (void)
 {
-	if (pm_power_off)
-		pm_power_off();
+	do_kernel_power_off();
 	machine_halt();
 }
 
-- 
2.33.1



From xen-devel-bounces@lists.xenproject.org Wed Oct 27 21:28:02 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Oct 2021 21:28:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217278.377273 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfqSe-0000l5-4m; Wed, 27 Oct 2021 21:27:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217278.377273; Wed, 27 Oct 2021 21:27:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfqSd-0000jW-QJ; Wed, 27 Oct 2021 21:27:51 +0000
Received: by outflank-mailman (input) for mailman id 217278;
 Wed, 27 Oct 2021 21:27:49 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=nMly=PP=gmail.com=digetx@srs-us1.protection.inumbo.net>)
 id 1mfqNS-0000sJ-FF
 for xen-devel@lists.xenproject.org; Wed, 27 Oct 2021 21:22:30 +0000
Received: from mail-lj1-x22c.google.com (unknown [2a00:1450:4864:20::22c])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 75304b2b-e4b2-4f61-96e2-041fe02a1904;
 Wed, 27 Oct 2021 21:19:08 +0000 (UTC)
Received: by mail-lj1-x22c.google.com with SMTP id i26so5091804ljg.7
 for <xen-devel@lists.xenproject.org>; Wed, 27 Oct 2021 14:19:08 -0700 (PDT)
Received: from localhost.localdomain (46-138-41-28.dynamic.spd-mgts.ru.
 [46.138.41.28])
 by smtp.gmail.com with ESMTPSA id d7sm104336ljl.18.2021.10.27.14.19.05
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Wed, 27 Oct 2021 14:19:06 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 75304b2b-e4b2-4f61-96e2-041fe02a1904
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=IyeKRcg+jY+d7mV074g++I9amtFxwmtCwLh3hlXwjuE=;
        b=QnkHqeqzRHJ5AsPp67EWmABUOzsGTZSEBDGiay4nrsnQYbRzqAwsk2Smx/z5LQ/pzF
         rdPrmuGWIQsGZY0bghrDq1od6/1Zl94Y7Qb1GFsmOOrt3AmEW7aEpgHOlwWIuWg9pF6h
         Oq2ibAnCelRGtOXc03WYR55PI40ZligMz8SFKQbuKJzels1J9jjvQqZYNvv/xzelX9Df
         3ooSIaYPCZ69IQLFRxzA4xs/vR6PqnP/beBugw1fOkkPovapvfxOsncNdJLVW4zeoK8b
         skyzHaRP9ZlGt9pP4tePYITTWnPX31LYoVXuqb9igbxjWGO6dkZHNW0xRIrqWzuV8p7l
         c4kw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=IyeKRcg+jY+d7mV074g++I9amtFxwmtCwLh3hlXwjuE=;
        b=yskBtUYTkO7vMc3nH96aWtDfWa/j2vhawnvPdCDsnad9aYEb2lFjMe4J3ITK2IC90U
         1Ygw3EfOcJFkfPOCXgbV5JHjXhEzY3rPQV6tRDaoGiqqZrTfTS3TKlHVttkgfwWUeA8H
         nFO9t21dbUy/S5ih6+SPhyk0FCv9JhNA24fnivHd+cmjDQ2IdYlOYQKs/o+ASPWVSNvA
         fjgXZZT8PRCoVnrZn7H9+VmyVBt7v14+t38l+KK4rUjtDuSCdAj5oyD5aP7AzHDBlq8e
         44DBwxJqFqxquWt06I0QT9vdtL3ajfBPO2bz1FdwjDLZDJ5hVceeUWhi95z8sbBWCRyv
         Hm2A==
X-Gm-Message-State: AOAM533CLgVHPhUSs2arwTkSYcJ5jFPVw/1L6BhxPYZZlcXbMERj6nOb
	ExUo7bkPlSpOtCdvtHbR3so=
X-Google-Smtp-Source: ABdhPJy4ahVYxTGf2Y3bPKsNGZG7BdaFjyQVV1JaKCPUvFr94r9L7duD8TnIWNPTqCXGHbJewLuL1g==
X-Received: by 2002:a05:651c:1256:: with SMTP id h22mr358353ljh.348.1635369547137;
        Wed, 27 Oct 2021 14:19:07 -0700 (PDT)
From: Dmitry Osipenko <digetx@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Lee Jones <lee.jones@linaro.org>,
	"Rafael J . Wysocki" <rafael@kernel.org>,
	Mark Brown <broonie@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Russell King <linux@armlinux.org.uk>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Ulf Hansson <ulf.hansson@linaro.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Guo Ren <guoren@kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Greg Ungerer <gerg@linux-m68k.org>,
	Joshua Thompson <funaho@jurai.org>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Nick Hu <nickhu@andestech.com>,
	Greentime Hu <green.hu@gmail.com>,
	Vincent Chen <deanbo422@gmail.com>,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	Helge Deller <deller@gmx.de>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Rich Felker <dalias@libc.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Len Brown <lenb@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Chen-Yu Tsai <wens@csie.org>,
	=?UTF-8?q?Jonathan=20Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>,
	Tony Lindgren <tony@atomide.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Vladimir Zapolskiy <vz@mleia.com>,
	Avi Fishman <avifishman70@gmail.com>,
	Tomer Maimon <tmaimon77@gmail.com>,
	Tali Perry <tali.perry1@gmail.com>,
	Patrick Venture <venture@google.com>,
	Nancy Yuen <yuenn@google.com>,
	Benjamin Fair <benjaminfair@google.com>,
	Pavel Machek <pavel@ucw.cz>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	linux-csky@vger.kernel.org,
	linux-ia64@vger.kernel.org,
	linux-m68k@lists.linux-m68k.org,
	linux-mips@vger.kernel.org,
	linux-parisc@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-riscv@lists.infradead.org,
	linux-sh@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	linux-acpi@vger.kernel.org,
	linux-omap@vger.kernel.org,
	openbmc@lists.ozlabs.org,
	linux-tegra@vger.kernel.org,
	linux-pm@vger.kernel.org
Subject: [PATCH v2 40/45] mfd: twl4030: Use devm_register_trivial_power_off_handler()
Date: Thu, 28 Oct 2021 00:17:10 +0300
Message-Id: <20211027211715.12671-41-digetx@gmail.com>
X-Mailer: git-send-email 2.33.1
In-Reply-To: <20211027211715.12671-1-digetx@gmail.com>
References: <20211027211715.12671-1-digetx@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Use devm_register_trivial_power_off_handler() that replaces global
pm_power_off variable and allows to register multiple power-off handlers.

Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
 drivers/mfd/twl4030-power.c | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/drivers/mfd/twl4030-power.c b/drivers/mfd/twl4030-power.c
index 6b36932263ba..72df4735d628 100644
--- a/drivers/mfd/twl4030-power.c
+++ b/drivers/mfd/twl4030-power.c
@@ -29,6 +29,7 @@
 #include <linux/platform_device.h>
 #include <linux/of.h>
 #include <linux/of_device.h>
+#include <linux/reboot.h>
 
 #include <asm/mach-types.h>
 
@@ -923,7 +924,7 @@ static int twl4030_power_probe(struct platform_device *pdev)
 	}
 
 	/* Board has to be wired properly to use this feature */
-	if (twl4030_power_use_poweroff(pdata, node) && !pm_power_off) {
+	if (twl4030_power_use_poweroff(pdata, node)) {
 		/* Default for SEQ_OFFSYNC is set, lets ensure this */
 		err = twl_i2c_read_u8(TWL_MODULE_PM_MASTER, &val,
 				      TWL4030_PM_MASTER_CFG_P123_TRANSITION);
@@ -939,7 +940,12 @@ static int twl4030_power_probe(struct platform_device *pdev)
 			}
 		}
 
-		pm_power_off = twl4030_power_off;
+		err = devm_register_trivial_power_off_handler(&pdev->dev,
+							      twl4030_power_off);
+		if (err) {
+			dev_err(&pdev->dev, "Failed to register power-off handler\n");
+			goto relock;
+		}
 	}
 
 relock:
-- 
2.33.1



From xen-devel-bounces@lists.xenproject.org Wed Oct 27 21:28:02 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Oct 2021 21:28:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217270.377239 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfqSb-0008TD-EW; Wed, 27 Oct 2021 21:27:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217270.377239; Wed, 27 Oct 2021 21:27:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfqSb-0008T6-9H; Wed, 27 Oct 2021 21:27:49 +0000
Received: by outflank-mailman (input) for mailman id 217270;
 Wed, 27 Oct 2021 21:27:48 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=nMly=PP=gmail.com=digetx@srs-us1.protection.inumbo.net>)
 id 1mfqKi-0000sJ-Ar
 for xen-devel@lists.xenproject.org; Wed, 27 Oct 2021 21:19:40 +0000
Received: from mail-lf1-x131.google.com (unknown [2a00:1450:4864:20::131])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 6b544073-9049-4d9c-951a-73ca878768f3;
 Wed, 27 Oct 2021 21:18:31 +0000 (UTC)
Received: by mail-lf1-x131.google.com with SMTP id j9so8978698lfu.7
 for <xen-devel@lists.xenproject.org>; Wed, 27 Oct 2021 14:18:31 -0700 (PDT)
Received: from localhost.localdomain (46-138-41-28.dynamic.spd-mgts.ru.
 [46.138.41.28])
 by smtp.gmail.com with ESMTPSA id d7sm104336ljl.18.2021.10.27.14.18.28
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Wed, 27 Oct 2021 14:18:29 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6b544073-9049-4d9c-951a-73ca878768f3
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=0HObz0L7jYC33/Dxy7x3kt14KoppaRcQ+sU+HcRStgU=;
        b=juuYY7khswyJq9WLrD2Xv0L7DT3egfGiA3J+op4ykA5lhTUc4DxfT1yB0Oh88agPiv
         UhoKqT4ns2hfuw9gr/v0jAGL8GkGSlrTsMjRAQAm62Utk3Ft2TKiyIKDHiM1MbMECMuo
         YhNAqYcsFGhVw4jQXQFg7Xiu9P0ShsfWNYxHZwYj/2saBc/VAXVzxB4ozqBsrO+obQNg
         sFt44IAUuRDv+vAvbmBDNGqc/rVW0RxicCJ9k+jGGnO7zutAFJ4cO/39uMNR4REocLb+
         fT+JvIjl7o4XFJOJc5uobpc1ra4sZ3Uq0sG0p07pr/mfIHANj05r1FY541LLyuiyYuuI
         01TQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=0HObz0L7jYC33/Dxy7x3kt14KoppaRcQ+sU+HcRStgU=;
        b=acfnmuqIlNnfB4OFtbYvx1D968GPMkRdfh2lNKsjbWRFq19PSfqf4hRhTNo1Q3h/FD
         DHUCu4fJNkCTuFvyuYIneEN5b7xqBjtJU+y3GPLonIqPQU68tpZ9l1Q2Th0blRR5s1rb
         A0HEciiNi+XbXqOmx5motbnuhX2joRtgHymw+5aaglI8sTd8uZ6jYjValMkq29nVJYPf
         jVHcHFpsC9IJZPPUrAB7FHfxsTj+DBiVPJkgONvPg/GJr8Y2qDaMibQYAnjX0E7+1JHd
         8aOkXgpK3cWm7FhizFrvbg3nEjpYXvTLl8sRxKdiW4rCoxtPCBC8RKYokBmAZVRkjsXG
         hx/w==
X-Gm-Message-State: AOAM5333kPG0SLpK+KdwFOWehCItqYKd+5eB1DdyMFZScbUuPCo1jkBO
	Qld38IZYdTI49x+m7o7WCdI=
X-Google-Smtp-Source: ABdhPJwvis6SZ3kogk4xA1IHskuhNiRlAlBXPnsBTS3IAzxRcr2G+o3cy4E7zzZ6V+F8EKCBP2j+FA==
X-Received: by 2002:ac2:4ec4:: with SMTP id p4mr108449lfr.127.1635369510228;
        Wed, 27 Oct 2021 14:18:30 -0700 (PDT)
From: Dmitry Osipenko <digetx@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Lee Jones <lee.jones@linaro.org>,
	"Rafael J . Wysocki" <rafael@kernel.org>,
	Mark Brown <broonie@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Russell King <linux@armlinux.org.uk>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Ulf Hansson <ulf.hansson@linaro.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Guo Ren <guoren@kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Greg Ungerer <gerg@linux-m68k.org>,
	Joshua Thompson <funaho@jurai.org>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Nick Hu <nickhu@andestech.com>,
	Greentime Hu <green.hu@gmail.com>,
	Vincent Chen <deanbo422@gmail.com>,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	Helge Deller <deller@gmx.de>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Rich Felker <dalias@libc.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Len Brown <lenb@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Chen-Yu Tsai <wens@csie.org>,
	=?UTF-8?q?Jonathan=20Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>,
	Tony Lindgren <tony@atomide.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Vladimir Zapolskiy <vz@mleia.com>,
	Avi Fishman <avifishman70@gmail.com>,
	Tomer Maimon <tmaimon77@gmail.com>,
	Tali Perry <tali.perry1@gmail.com>,
	Patrick Venture <venture@google.com>,
	Nancy Yuen <yuenn@google.com>,
	Benjamin Fair <benjaminfair@google.com>,
	Pavel Machek <pavel@ucw.cz>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	linux-csky@vger.kernel.org,
	linux-ia64@vger.kernel.org,
	linux-m68k@lists.linux-m68k.org,
	linux-mips@vger.kernel.org,
	linux-parisc@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-riscv@lists.infradead.org,
	linux-sh@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	linux-acpi@vger.kernel.org,
	linux-omap@vger.kernel.org,
	openbmc@lists.ozlabs.org,
	linux-tegra@vger.kernel.org,
	linux-pm@vger.kernel.org
Subject: [PATCH v2 20/45] x86: Use do_kernel_power_off()
Date: Thu, 28 Oct 2021 00:16:50 +0300
Message-Id: <20211027211715.12671-21-digetx@gmail.com>
X-Mailer: git-send-email 2.33.1
In-Reply-To: <20211027211715.12671-1-digetx@gmail.com>
References: <20211027211715.12671-1-digetx@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Kernel now supports chained power-off handlers. Use do_kernel_power_off()
that invokes chained power-off handlers. It also invokes legacy
pm_power_off() for now, which will be removed once all drivers will
be converted to the new power-off API.

Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
 arch/x86/kernel/reboot.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/kernel/reboot.c b/arch/x86/kernel/reboot.c
index 0a40df66a40d..cd7d9416d81a 100644
--- a/arch/x86/kernel/reboot.c
+++ b/arch/x86/kernel/reboot.c
@@ -747,10 +747,10 @@ static void native_machine_halt(void)
 
 static void native_machine_power_off(void)
 {
-	if (pm_power_off) {
+	if (kernel_can_power_off()) {
 		if (!reboot_force)
 			machine_shutdown();
-		pm_power_off();
+		do_kernel_power_off();
 	}
 	/* A fallback in case there is no PM info available */
 	tboot_shutdown(TB_SHUTDOWN_HALT);
-- 
2.33.1



From xen-devel-bounces@lists.xenproject.org Wed Oct 27 21:28:02 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Oct 2021 21:28:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217281.377279 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfqSe-0000tG-KR; Wed, 27 Oct 2021 21:27:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217281.377279; Wed, 27 Oct 2021 21:27:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfqSe-0000qC-7d; Wed, 27 Oct 2021 21:27:52 +0000
Received: by outflank-mailman (input) for mailman id 217281;
 Wed, 27 Oct 2021 21:27:50 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=nMly=PP=gmail.com=digetx@srs-us1.protection.inumbo.net>)
 id 1mfqND-0000sJ-Ey
 for xen-devel@lists.xenproject.org; Wed, 27 Oct 2021 21:22:15 +0000
Received: from mail-lj1-x231.google.com (unknown [2a00:1450:4864:20::231])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id ff658b29-29e8-4a31-ab27-c640fd96d1ac;
 Wed, 27 Oct 2021 21:19:04 +0000 (UTC)
Received: by mail-lj1-x231.google.com with SMTP id 17so3841722ljq.0
 for <xen-devel@lists.xenproject.org>; Wed, 27 Oct 2021 14:19:04 -0700 (PDT)
Received: from localhost.localdomain (46-138-41-28.dynamic.spd-mgts.ru.
 [46.138.41.28])
 by smtp.gmail.com with ESMTPSA id d7sm104336ljl.18.2021.10.27.14.19.01
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Wed, 27 Oct 2021 14:19:03 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ff658b29-29e8-4a31-ab27-c640fd96d1ac
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=Mu7tO95vXROZ9xbCJkoDzGl64HT6xR31EdIoyaMnKtk=;
        b=kPE91xXN+stBc0ha+PSjaOkkNGKlDTid0pZMJS4/z0xuWbbpv+/mX7oe8gzrFGsnxt
         knUKantyHU6PWIePiCnlFQ4UN8ZQdQP1oXKoJzSLIKv1lTDAhiLZjpDPc+aijhkrEZAj
         Xd8HN8BgZu0o5hpIxMQVtpuABAaRE4DHHXJZzo4Dy3xXk62gjG4MyDoYUHzKrSYuupRB
         lCz2OE27nWCjWUb+PHoI0yIS0mi3esed5R8cO+FhwY/2Rv4/jyVsNkj3xtgaoN5/YStc
         dCcP9WUacf6ElBGM42XMwNMMkAZqDoGVD/aHJJj9Cz/Tk9wj2JFlAJdIXkKMwT6cvxA3
         e31g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=Mu7tO95vXROZ9xbCJkoDzGl64HT6xR31EdIoyaMnKtk=;
        b=OWKFoUhWj90xmynbKzk3p4ZGwVeB7PunJvv2FX2kQToVbg/8bfGMZK9JnheeQBZg85
         c7vsd2obubGPEN2cyAvIF9hDywbjd6cT8yjA2v2wawF3fxX0pJuVeaF4dIyc+OrgO1aC
         6CPUP33yFZTtE3kJm54CeGcxBab0GvDONSDgVvUlf2w8RUrc7ZrTa7P1M+qPqZ0qzNXN
         krh4M/eTfT47nwFKNLcmVmJsxeqXZnfGB0ppLhqQPqy4hNyL7TyNir/zcBd6zgdQpoOh
         G8xXbaZBCruzK3g0MZ/oPopKwqn07rV6O41zwULXSDV7DZU0Z/7gWnVMxXBUxbHSk76k
         mS/w==
X-Gm-Message-State: AOAM530vDxhtg/vif7zKvrUjSQiDMITFpfdcYCQAmHVOh9UuTNVUqgb0
	O4vFUDMXMX4EVQMhNIrECQ8=
X-Google-Smtp-Source: ABdhPJx+pRFjcRYPR1om8nKBpIgAHoRaPbEg7vS4nL7YKN3yH6zq2Ajomu3cvpnY+yAbJLhjtqI1TQ==
X-Received: by 2002:a2e:bb98:: with SMTP id y24mr344716lje.168.1635369543476;
        Wed, 27 Oct 2021 14:19:03 -0700 (PDT)
From: Dmitry Osipenko <digetx@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Lee Jones <lee.jones@linaro.org>,
	"Rafael J . Wysocki" <rafael@kernel.org>,
	Mark Brown <broonie@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Russell King <linux@armlinux.org.uk>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Ulf Hansson <ulf.hansson@linaro.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Guo Ren <guoren@kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Greg Ungerer <gerg@linux-m68k.org>,
	Joshua Thompson <funaho@jurai.org>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Nick Hu <nickhu@andestech.com>,
	Greentime Hu <green.hu@gmail.com>,
	Vincent Chen <deanbo422@gmail.com>,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	Helge Deller <deller@gmx.de>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Rich Felker <dalias@libc.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Len Brown <lenb@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Chen-Yu Tsai <wens@csie.org>,
	=?UTF-8?q?Jonathan=20Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>,
	Tony Lindgren <tony@atomide.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Vladimir Zapolskiy <vz@mleia.com>,
	Avi Fishman <avifishman70@gmail.com>,
	Tomer Maimon <tmaimon77@gmail.com>,
	Tali Perry <tali.perry1@gmail.com>,
	Patrick Venture <venture@google.com>,
	Nancy Yuen <yuenn@google.com>,
	Benjamin Fair <benjaminfair@google.com>,
	Pavel Machek <pavel@ucw.cz>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	linux-csky@vger.kernel.org,
	linux-ia64@vger.kernel.org,
	linux-m68k@lists.linux-m68k.org,
	linux-mips@vger.kernel.org,
	linux-parisc@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-riscv@lists.infradead.org,
	linux-sh@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	linux-acpi@vger.kernel.org,
	linux-omap@vger.kernel.org,
	openbmc@lists.ozlabs.org,
	linux-tegra@vger.kernel.org,
	linux-pm@vger.kernel.org
Subject: [PATCH v2 38/45] mfd: max77620: Use devm_register_simple_power_off_handler()
Date: Thu, 28 Oct 2021 00:17:08 +0300
Message-Id: <20211027211715.12671-39-digetx@gmail.com>
X-Mailer: git-send-email 2.33.1
In-Reply-To: <20211027211715.12671-1-digetx@gmail.com>
References: <20211027211715.12671-1-digetx@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Use devm_register_simple_power_off_handler() that replaces global
pm_power_off variable and allows to register multiple power-off handlers.

Nexus 7 Android tablet can be powered off using MAX77663 PMIC and using
a special bootloader command. At first the bootloader option should be
tried, it will have a higher priority than of PMIC that uses default
priority.

Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
 drivers/mfd/max77620.c | 21 ++++++++++++---------
 1 file changed, 12 insertions(+), 9 deletions(-)

diff --git a/drivers/mfd/max77620.c b/drivers/mfd/max77620.c
index fec2096474ad..29487ccc191a 100644
--- a/drivers/mfd/max77620.c
+++ b/drivers/mfd/max77620.c
@@ -31,11 +31,10 @@
 #include <linux/init.h>
 #include <linux/of.h>
 #include <linux/of_device.h>
+#include <linux/reboot.h>
 #include <linux/regmap.h>
 #include <linux/slab.h>
 
-static struct max77620_chip *max77620_scratch;
-
 static const struct resource gpio_resources[] = {
 	DEFINE_RES_IRQ(MAX77620_IRQ_TOP_GPIO),
 };
@@ -483,13 +482,13 @@ static int max77620_read_es_version(struct max77620_chip *chip)
 	return ret;
 }
 
-static void max77620_pm_power_off(void)
+static void max77620_pm_power_off(void *data)
 {
-	struct max77620_chip *chip = max77620_scratch;
+	struct max77620_chip *chip = data;
 
 	regmap_update_bits(chip->rmap, MAX77620_REG_ONOFFCNFG1,
-			   MAX77620_ONOFFCNFG1_SFT_RST,
-			   MAX77620_ONOFFCNFG1_SFT_RST);
+				   MAX77620_ONOFFCNFG1_SFT_RST,
+				   MAX77620_ONOFFCNFG1_SFT_RST);
 }
 
 static int max77620_probe(struct i2c_client *client,
@@ -566,9 +565,13 @@ static int max77620_probe(struct i2c_client *client,
 	}
 
 	pm_off = of_device_is_system_power_controller(client->dev.of_node);
-	if (pm_off && !pm_power_off) {
-		max77620_scratch = chip;
-		pm_power_off = max77620_pm_power_off;
+	if (pm_off) {
+		ret = devm_register_simple_power_off_handler(chip->dev,
+							     max77620_pm_power_off,
+							     chip);
+		if (ret < 0)
+			dev_err(chip->dev,
+				"Failed to register power-off handler: %d\n", ret);
 	}
 
 	return 0;
-- 
2.33.1



From xen-devel-bounces@lists.xenproject.org Wed Oct 27 21:28:03 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Oct 2021 21:28:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217282.377288 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfqSf-00015B-Bc; Wed, 27 Oct 2021 21:27:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217282.377288; Wed, 27 Oct 2021 21:27:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfqSf-00012Q-0E; Wed, 27 Oct 2021 21:27:53 +0000
Received: by outflank-mailman (input) for mailman id 217282;
 Wed, 27 Oct 2021 21:27:50 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=nMly=PP=gmail.com=digetx@srs-us1.protection.inumbo.net>)
 id 1mfqJz-0000sJ-9b
 for xen-devel@lists.xenproject.org; Wed, 27 Oct 2021 21:18:55 +0000
Received: from mail-lf1-x12f.google.com (unknown [2a00:1450:4864:20::12f])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 0222bae1-7769-490d-af5a-95eedee2bd43;
 Wed, 27 Oct 2021 21:18:16 +0000 (UTC)
Received: by mail-lf1-x12f.google.com with SMTP id u21so8955846lff.8
 for <xen-devel@lists.xenproject.org>; Wed, 27 Oct 2021 14:18:16 -0700 (PDT)
Received: from localhost.localdomain (46-138-41-28.dynamic.spd-mgts.ru.
 [46.138.41.28])
 by smtp.gmail.com with ESMTPSA id d7sm104336ljl.18.2021.10.27.14.18.13
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Wed, 27 Oct 2021 14:18:14 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0222bae1-7769-490d-af5a-95eedee2bd43
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=Vv5v7NJqa2pgRBcibgPiURAuuSzsOgTRkcWT+pa422M=;
        b=VGbgvR+u/npCM8vNPn38NuZ+MIrzGhV81ZfjU+MvKS7AiNy8hSxCjA7ujiUYCw1avb
         GAS28yQKe3RY82NkG0EyIE3kAScJ6kyKTE9XbDbIDpQ4/fNIy31zksAcsMcf8bk9+oZI
         1wHpYlYvsjYNqCu/GmNzEr8yZmApiaFT6QsgmW5CvvcXj9w3x5S6f7cRGSestmqNVLhh
         o9VGqc+8lw97d2ugsZVtaD4DU57/XiuAmduAg/0PPfMVALR+BIUtVf/vGT/0dSW22xNm
         0l5U0Yw6vCM5eFCBC2LE4tjs/ctA+ukPU11+6ITwiBuENW3D9cS5YJDtN5S1cIiSXp7j
         wB1A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=Vv5v7NJqa2pgRBcibgPiURAuuSzsOgTRkcWT+pa422M=;
        b=0F+OIJvsYsGhRiZNJ72olscU3yMuCPfgyQTS+uu7olyHpLJDpnKujzpOoH5QIYWjRl
         f0QxYEMFk18jonOGw5y/nS5NHMTMIZ1vjCjk/UU9KKz5MP6tDpnJmBpbDMIX2ZtkvVeB
         UqlgpoTLivzGTAW8rtvmQAI6utRG6Ksb9GdRS8dIo0/X1MCt/PrvSMDVQNT0JvXTrh5K
         OGYv4zjRSNu09OwfZ0je/Fbz7ZKxFWRmxzrbSM4gObu3KIePnVEYsGj6wCiBs8U99LKM
         21hnGX3tUihmsZn14Az8TgzHu9DQ8F/3gHptJXf+1dobEnXoLKkHYPSuk1Ot+RTnpnQn
         CPDQ==
X-Gm-Message-State: AOAM530DKGns7N7S9ogSVOYjDGJew81eHlmrAqBbu+oSuayO43iAldjW
	1C+aab59xWUTNTLC581sM0g=
X-Google-Smtp-Source: ABdhPJycpSIBttPaIIeVkgKRen/cPXePW42pRZoMffRx62Sit7qS0BR3pB37ZmB7g4nrP0IYjPFMsA==
X-Received: by 2002:ac2:5c43:: with SMTP id s3mr133719lfp.248.1635369495190;
        Wed, 27 Oct 2021 14:18:15 -0700 (PDT)
From: Dmitry Osipenko <digetx@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Lee Jones <lee.jones@linaro.org>,
	"Rafael J . Wysocki" <rafael@kernel.org>,
	Mark Brown <broonie@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Russell King <linux@armlinux.org.uk>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Ulf Hansson <ulf.hansson@linaro.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Guo Ren <guoren@kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Greg Ungerer <gerg@linux-m68k.org>,
	Joshua Thompson <funaho@jurai.org>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Nick Hu <nickhu@andestech.com>,
	Greentime Hu <green.hu@gmail.com>,
	Vincent Chen <deanbo422@gmail.com>,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	Helge Deller <deller@gmx.de>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Rich Felker <dalias@libc.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Len Brown <lenb@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Chen-Yu Tsai <wens@csie.org>,
	=?UTF-8?q?Jonathan=20Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>,
	Tony Lindgren <tony@atomide.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Vladimir Zapolskiy <vz@mleia.com>,
	Avi Fishman <avifishman70@gmail.com>,
	Tomer Maimon <tmaimon77@gmail.com>,
	Tali Perry <tali.perry1@gmail.com>,
	Patrick Venture <venture@google.com>,
	Nancy Yuen <yuenn@google.com>,
	Benjamin Fair <benjaminfair@google.com>,
	Pavel Machek <pavel@ucw.cz>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	linux-csky@vger.kernel.org,
	linux-ia64@vger.kernel.org,
	linux-m68k@lists.linux-m68k.org,
	linux-mips@vger.kernel.org,
	linux-parisc@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-riscv@lists.infradead.org,
	linux-sh@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	linux-acpi@vger.kernel.org,
	linux-omap@vger.kernel.org,
	openbmc@lists.ozlabs.org,
	linux-tegra@vger.kernel.org,
	linux-pm@vger.kernel.org
Subject: [PATCH v2 12/45] csky: Use do_kernel_power_off()
Date: Thu, 28 Oct 2021 00:16:42 +0300
Message-Id: <20211027211715.12671-13-digetx@gmail.com>
X-Mailer: git-send-email 2.33.1
In-Reply-To: <20211027211715.12671-1-digetx@gmail.com>
References: <20211027211715.12671-1-digetx@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Kernel now supports chained power-off handlers. Use do_kernel_power_off()
that invokes chained power-off handlers. It also invokes legacy
pm_power_off() for now, which will be removed once all drivers will
be converted to the new power-off API.

Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
 arch/csky/kernel/power.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/arch/csky/kernel/power.c b/arch/csky/kernel/power.c
index 923ee4e381b8..86ee202906f8 100644
--- a/arch/csky/kernel/power.c
+++ b/arch/csky/kernel/power.c
@@ -9,16 +9,14 @@ EXPORT_SYMBOL(pm_power_off);
 void machine_power_off(void)
 {
 	local_irq_disable();
-	if (pm_power_off)
-		pm_power_off();
+	do_kernel_power_off();
 	asm volatile ("bkpt");
 }
 
 void machine_halt(void)
 {
 	local_irq_disable();
-	if (pm_power_off)
-		pm_power_off();
+	do_kernel_power_off();
 	asm volatile ("bkpt");
 }
 
-- 
2.33.1



From xen-devel-bounces@lists.xenproject.org Wed Oct 27 21:28:04 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Oct 2021 21:28:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217283.377297 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfqSg-0001L2-4V; Wed, 27 Oct 2021 21:27:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217283.377297; Wed, 27 Oct 2021 21:27:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfqSf-0001G3-Os; Wed, 27 Oct 2021 21:27:53 +0000
Received: by outflank-mailman (input) for mailman id 217283;
 Wed, 27 Oct 2021 21:27:50 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=nMly=PP=gmail.com=digetx@srs-us1.protection.inumbo.net>)
 id 1mfqLC-0000sJ-Bf
 for xen-devel@lists.xenproject.org; Wed, 27 Oct 2021 21:20:10 +0000
Received: from mail-lj1-x229.google.com (unknown [2a00:1450:4864:20::229])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id e3b334e6-cd33-456a-ab3a-269c6b97cb7a;
 Wed, 27 Oct 2021 21:18:38 +0000 (UTC)
Received: by mail-lj1-x229.google.com with SMTP id d23so5638600ljj.10
 for <xen-devel@lists.xenproject.org>; Wed, 27 Oct 2021 14:18:38 -0700 (PDT)
Received: from localhost.localdomain (46-138-41-28.dynamic.spd-mgts.ru.
 [46.138.41.28])
 by smtp.gmail.com with ESMTPSA id d7sm104336ljl.18.2021.10.27.14.18.35
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Wed, 27 Oct 2021 14:18:37 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e3b334e6-cd33-456a-ab3a-269c6b97cb7a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=RsN03A/v4Sm7hW8tBAQNfAIwim2Ix+phU87uldQTcUU=;
        b=aSBcb4MObsGcKwVtxhkQi6r6MrllJ5Wvhx4AXr7+3ZZIOmNeNayjB4H7wS3yJIQaI0
         vfLkw8dEY0bAB5FpyHupYLxHHW8temP9OImGFFR4LDmE7/mvPRk5uTYf1q52vThLv1Ot
         CBrv1hpmeU5p/gGow8523dqz9J8N1faFeN/IXFxxWyp7mhT8fq2Z7acBEZ06y9nx6CF2
         oI6Bf+jKcKCu1O6+i0B6l4EesA9cDqHIJQrezIg8dnd+TlutJ/VurnoBCjdUW8FVuBfF
         rgIrNrWNCUTYVjuoeGUx+HMg9DODFrvmZsdKkZzK15Dx1U5yq0D3h61n1EAZrJfufwr8
         qWRQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=RsN03A/v4Sm7hW8tBAQNfAIwim2Ix+phU87uldQTcUU=;
        b=OHfHyq85RsRt/yzp0dtbFhmdlQQbtE9RDQFutPsx65jgZ3GCcOnJLc9G/gfVhNzWGD
         OoKDcdqKybndotrveSIVAMk6C+dJqNKtIPiTX5s3YOvHsyaYuLFIkic6c4re2CeNWPE1
         kekf3suRqBASTL+apcpeV32KNtPDi87fHSr2Dmb7ohS0gAe/+SznOjfuXDU/eBIZmCPC
         sJZvIzTLPFU42/BPqAhHOQ9Lz0IeHz0kZVVgdCHTETalKIaFs5+ZZoRu0PBFZCU2Gtj+
         Q3Fori8AmaIAcY2PtRWt9p0cFzsc1KDKDWiP+piIz5imLoK9Tbywr3SHIZ2+4w3DLuXS
         u7Bw==
X-Gm-Message-State: AOAM533haRxmYCqMCQCg0OtJokdBKv2hU4J3jVErmuPcxivSt/74OUQl
	gPwtdGX50V65VjQocRonLs4=
X-Google-Smtp-Source: ABdhPJwvRw65HVRl6UYG4kSDngjOw+VDWoznyGC0SQFAdeVNXxGihIuJGUkpMtbqNUFYMuUZsUPclw==
X-Received: by 2002:a2e:3e08:: with SMTP id l8mr351596lja.194.1635369517590;
        Wed, 27 Oct 2021 14:18:37 -0700 (PDT)
From: Dmitry Osipenko <digetx@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Lee Jones <lee.jones@linaro.org>,
	"Rafael J . Wysocki" <rafael@kernel.org>,
	Mark Brown <broonie@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Russell King <linux@armlinux.org.uk>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Ulf Hansson <ulf.hansson@linaro.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Guo Ren <guoren@kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Greg Ungerer <gerg@linux-m68k.org>,
	Joshua Thompson <funaho@jurai.org>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Nick Hu <nickhu@andestech.com>,
	Greentime Hu <green.hu@gmail.com>,
	Vincent Chen <deanbo422@gmail.com>,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	Helge Deller <deller@gmx.de>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Rich Felker <dalias@libc.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Len Brown <lenb@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Chen-Yu Tsai <wens@csie.org>,
	=?UTF-8?q?Jonathan=20Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>,
	Tony Lindgren <tony@atomide.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Vladimir Zapolskiy <vz@mleia.com>,
	Avi Fishman <avifishman70@gmail.com>,
	Tomer Maimon <tmaimon77@gmail.com>,
	Tali Perry <tali.perry1@gmail.com>,
	Patrick Venture <venture@google.com>,
	Nancy Yuen <yuenn@google.com>,
	Benjamin Fair <benjaminfair@google.com>,
	Pavel Machek <pavel@ucw.cz>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	linux-csky@vger.kernel.org,
	linux-ia64@vger.kernel.org,
	linux-m68k@lists.linux-m68k.org,
	linux-mips@vger.kernel.org,
	linux-parisc@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-riscv@lists.infradead.org,
	linux-sh@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	linux-acpi@vger.kernel.org,
	linux-omap@vger.kernel.org,
	openbmc@lists.ozlabs.org,
	linux-tegra@vger.kernel.org,
	linux-pm@vger.kernel.org
Subject: [PATCH v2 24/45] regulator: pfuze100: Use devm_register_power_handler()
Date: Thu, 28 Oct 2021 00:16:54 +0300
Message-Id: <20211027211715.12671-25-digetx@gmail.com>
X-Mailer: git-send-email 2.33.1
In-Reply-To: <20211027211715.12671-1-digetx@gmail.com>
References: <20211027211715.12671-1-digetx@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Use devm_register_power_handler() that replaces global pm_power_off_prepare
variable and allows to register multiple power-off handlers.

Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
 drivers/regulator/pfuze100-regulator.c | 39 ++++++++++----------------
 1 file changed, 15 insertions(+), 24 deletions(-)

diff --git a/drivers/regulator/pfuze100-regulator.c b/drivers/regulator/pfuze100-regulator.c
index d60d7d1b7fa2..73d5baf9d3ea 100644
--- a/drivers/regulator/pfuze100-regulator.c
+++ b/drivers/regulator/pfuze100-regulator.c
@@ -10,6 +10,7 @@
 #include <linux/of_device.h>
 #include <linux/regulator/of_regulator.h>
 #include <linux/platform_device.h>
+#include <linux/reboot.h>
 #include <linux/regulator/driver.h>
 #include <linux/regulator/machine.h>
 #include <linux/regulator/pfuze100.h>
@@ -76,6 +77,7 @@ struct pfuze_chip {
 	struct pfuze_regulator regulator_descs[PFUZE100_MAX_REGULATOR];
 	struct regulator_dev *regulators[PFUZE100_MAX_REGULATOR];
 	struct pfuze_regulator *pfuze_regulators;
+	struct power_handler power_handler;
 };
 
 static const int pfuze100_swbst[] = {
@@ -569,10 +571,10 @@ static inline struct device_node *match_of_node(int index)
 	return pfuze_matches[index].of_node;
 }
 
-static struct pfuze_chip *syspm_pfuze_chip;
-
-static void pfuze_power_off_prepare(void)
+static void pfuze_power_off_prepare(struct power_off_prep_data *data)
 {
+	struct pfuze_chip *syspm_pfuze_chip = data->cb_data;
+
 	dev_info(syspm_pfuze_chip->dev, "Configure standby mode for power off");
 
 	/* Switch from default mode: APS/APS to APS/Off */
@@ -611,24 +613,24 @@ static void pfuze_power_off_prepare(void)
 
 static int pfuze_power_off_prepare_init(struct pfuze_chip *pfuze_chip)
 {
+	int err;
+
 	if (pfuze_chip->chip_id != PFUZE100) {
 		dev_warn(pfuze_chip->dev, "Requested pm_power_off_prepare handler for not supported chip\n");
 		return -ENODEV;
 	}
 
-	if (pm_power_off_prepare) {
-		dev_warn(pfuze_chip->dev, "pm_power_off_prepare is already registered.\n");
-		return -EBUSY;
-	}
+	pfuze_chip->power_handler.power_off_prepare_cb = pfuze_power_off_prepare;
+	pfuze_chip->power_handler.cb_data = pfuze_chip;
 
-	if (syspm_pfuze_chip) {
-		dev_warn(pfuze_chip->dev, "syspm_pfuze_chip is already set.\n");
-		return -EBUSY;
+	err = devm_register_power_handler(pfuze_chip->dev,
+					  &pfuze_chip->power_handler);
+	if (err) {
+		dev_err(pfuze_chip->dev,
+			"failed to register power handler: %d\n", err);
+		return err;
 	}
 
-	syspm_pfuze_chip = pfuze_chip;
-	pm_power_off_prepare = pfuze_power_off_prepare;
-
 	return 0;
 }
 
@@ -837,23 +839,12 @@ static int pfuze100_regulator_probe(struct i2c_client *client,
 	return 0;
 }
 
-static int pfuze100_regulator_remove(struct i2c_client *client)
-{
-	if (syspm_pfuze_chip) {
-		syspm_pfuze_chip = NULL;
-		pm_power_off_prepare = NULL;
-	}
-
-	return 0;
-}
-
 static struct i2c_driver pfuze_driver = {
 	.driver = {
 		.name = "pfuze100-regulator",
 		.of_match_table = pfuze_dt_ids,
 	},
 	.probe = pfuze100_regulator_probe,
-	.remove = pfuze100_regulator_remove,
 };
 module_i2c_driver(pfuze_driver);
 
-- 
2.33.1



From xen-devel-bounces@lists.xenproject.org Wed Oct 27 21:28:08 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Oct 2021 21:28:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217287.377327 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfqSj-0002ND-Mc; Wed, 27 Oct 2021 21:27:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217287.377327; Wed, 27 Oct 2021 21:27:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfqSj-0002L7-D2; Wed, 27 Oct 2021 21:27:57 +0000
Received: by outflank-mailman (input) for mailman id 217287;
 Wed, 27 Oct 2021 21:27:55 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=nMly=PP=gmail.com=digetx@srs-us1.protection.inumbo.net>)
 id 1mfqLM-0000sJ-C4
 for xen-devel@lists.xenproject.org; Wed, 27 Oct 2021 21:20:20 +0000
Received: from mail-lf1-x131.google.com (unknown [2a00:1450:4864:20::131])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 785f57b0-ec27-457a-9ea3-6dcf331783c7;
 Wed, 27 Oct 2021 21:18:42 +0000 (UTC)
Received: by mail-lf1-x131.google.com with SMTP id l13so8991223lfg.6
 for <xen-devel@lists.xenproject.org>; Wed, 27 Oct 2021 14:18:42 -0700 (PDT)
Received: from localhost.localdomain (46-138-41-28.dynamic.spd-mgts.ru.
 [46.138.41.28])
 by smtp.gmail.com with ESMTPSA id d7sm104336ljl.18.2021.10.27.14.18.39
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Wed, 27 Oct 2021 14:18:41 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 785f57b0-ec27-457a-9ea3-6dcf331783c7
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=mcl172dtfGlkf1TcslUPgwMlkZWwlYhkCJ06Bxg/bBU=;
        b=cr3OoRz90WYilQxW+1X5mebi5NSQ3xkQzRtxCrXFmhmNlKVd4Mk6BghlahMCy7Iyto
         a4UuDalJ4f78KLT3HAaBh5614BnSWOH/t9zbr0YPxrmg6/JuWnf5dAnKZsc2b4GAIVeJ
         9uKqX2hlny1afoYheoedvOJbugyMQlznsmVrZlOSaKsdu2draZ6B8WFqE5e4JBYGYqhC
         KXF/Z/WyDDccTQoDfFgyc6FoM2LFPomJZ3hRr6/JbV3znQY16GvUC7Q6Zprq2NGBD3P+
         O43c0LmvrM3DBmK/z7V4e9Zq9h2WiaNFgKFrXs2jyu8jI7tMHdmmNyPNNNQGazHFhhOk
         f27Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=mcl172dtfGlkf1TcslUPgwMlkZWwlYhkCJ06Bxg/bBU=;
        b=hA2Ppv3OGcoDsMCW9909dv08NGy3GCE+pkv9bk9nM6DhYTLZiahgnMC9D2ENxX8olW
         8cb7hVb8hLk7m7gLTOlT9fGui+ZAgXpkWw4LRh6sLsHr7V812uTmG4VGOKAtEBxGZQnB
         iq1PMuhBEnTCBmagp7boRy1f+7Ohd9hp7R2eQdbDHysyfxpFZ8XF2KUuePnWQEJPvtTe
         cQwUbZRReOe6/CyjbCHKYgeFu5QHFd/SPAYVVG0P/rIc2ZE9sNJOcQJFFkffmBSBmdoN
         E/EqzcByhqcVY8vS80GnP1XZcPw0O7y+Wkb8pzVGAcU6BkHJ1PgxK/tDpRdnpAd2K0FW
         x8tQ==
X-Gm-Message-State: AOAM533W/UKW+SUnHNTJX44GjJSVvH4lAhhlyMU5/IGBuW3TNF/HpI81
	+2XDVbqk0MfB6EleZkSr7bk=
X-Google-Smtp-Source: ABdhPJwc0gXcQNbXi4wauxJdUJOzB/R/HFQ4KaA94+CkBW5unEGwAKJM6qsNc2djNTohX6NYEK5drA==
X-Received: by 2002:a05:6512:3ca3:: with SMTP id h35mr145327lfv.128.1635369521305;
        Wed, 27 Oct 2021 14:18:41 -0700 (PDT)
From: Dmitry Osipenko <digetx@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Lee Jones <lee.jones@linaro.org>,
	"Rafael J . Wysocki" <rafael@kernel.org>,
	Mark Brown <broonie@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Russell King <linux@armlinux.org.uk>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Ulf Hansson <ulf.hansson@linaro.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Guo Ren <guoren@kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Greg Ungerer <gerg@linux-m68k.org>,
	Joshua Thompson <funaho@jurai.org>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Nick Hu <nickhu@andestech.com>,
	Greentime Hu <green.hu@gmail.com>,
	Vincent Chen <deanbo422@gmail.com>,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	Helge Deller <deller@gmx.de>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Rich Felker <dalias@libc.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Len Brown <lenb@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Chen-Yu Tsai <wens@csie.org>,
	=?UTF-8?q?Jonathan=20Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>,
	Tony Lindgren <tony@atomide.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Vladimir Zapolskiy <vz@mleia.com>,
	Avi Fishman <avifishman70@gmail.com>,
	Tomer Maimon <tmaimon77@gmail.com>,
	Tali Perry <tali.perry1@gmail.com>,
	Patrick Venture <venture@google.com>,
	Nancy Yuen <yuenn@google.com>,
	Benjamin Fair <benjaminfair@google.com>,
	Pavel Machek <pavel@ucw.cz>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	linux-csky@vger.kernel.org,
	linux-ia64@vger.kernel.org,
	linux-m68k@lists.linux-m68k.org,
	linux-mips@vger.kernel.org,
	linux-parisc@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-riscv@lists.infradead.org,
	linux-sh@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	linux-acpi@vger.kernel.org,
	linux-omap@vger.kernel.org,
	openbmc@lists.ozlabs.org,
	linux-tegra@vger.kernel.org,
	linux-pm@vger.kernel.org
Subject: [PATCH v2 26/45] soc/tegra: pmc: Utilize power-handler API to power off Nexus 7 properly
Date: Thu, 28 Oct 2021 00:16:56 +0300
Message-Id: <20211027211715.12671-27-digetx@gmail.com>
X-Mailer: git-send-email 2.33.1
In-Reply-To: <20211027211715.12671-1-digetx@gmail.com>
References: <20211027211715.12671-1-digetx@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Nexus 7 Android tablet can be turned off using a special bootloader
command which is conveyed to bootloader by putting magic value into
specific scratch register and then rebooting normally. This power-off
method should be invoked if USB cable is connected. Bootloader then will
display battery status and power off the device. This behaviour is
borrowed from downstream kernel and matches user expectations, otherwise
it looks like device got hung during power-off and it may wake up on
USB disconnect.

Switch PMC driver to power-handler API, which provides drivers with
combined power-off+restart call chains functionality, replacing the
restart-only call chain API.

Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
 drivers/soc/tegra/pmc.c | 54 +++++++++++++++++++++++++++--------------
 1 file changed, 36 insertions(+), 18 deletions(-)

diff --git a/drivers/soc/tegra/pmc.c b/drivers/soc/tegra/pmc.c
index 575d6d5b4294..a01330099e1a 100644
--- a/drivers/soc/tegra/pmc.c
+++ b/drivers/soc/tegra/pmc.c
@@ -39,6 +39,7 @@
 #include <linux/platform_device.h>
 #include <linux/pm_domain.h>
 #include <linux/pm_opp.h>
+#include <linux/power_supply.h>
 #include <linux/reboot.h>
 #include <linux/regmap.h>
 #include <linux/reset.h>
@@ -107,6 +108,7 @@
 #define PMC_USB_DEBOUNCE_DEL		0xec
 #define PMC_USB_AO			0xf0
 
+#define PMC_SCRATCH37			0x130
 #define PMC_SCRATCH41			0x140
 
 #define PMC_WAKE2_MASK			0x160
@@ -1064,10 +1066,8 @@ int tegra_pmc_cpu_remove_clamping(unsigned int cpuid)
 	return tegra_powergate_remove_clamping(id);
 }
 
-static int tegra_pmc_restart_notify(struct notifier_block *this,
-				    unsigned long action, void *data)
+static void tegra_pmc_restart(const char *cmd)
 {
-	const char *cmd = data;
 	u32 value;
 
 	value = tegra_pmc_scratch_readl(pmc, pmc->soc->regs->scratch0);
@@ -1090,13 +1090,33 @@ static int tegra_pmc_restart_notify(struct notifier_block *this,
 	value = tegra_pmc_readl(pmc, PMC_CNTRL);
 	value |= PMC_CNTRL_MAIN_RST;
 	tegra_pmc_writel(pmc, value, PMC_CNTRL);
+}
 
-	return NOTIFY_DONE;
+static void tegra_pmc_restart_handler(struct restart_data *data)
+{
+	tegra_pmc_restart(data->cmd);
 }
 
-static struct notifier_block tegra_pmc_restart_handler = {
-	.notifier_call = tegra_pmc_restart_notify,
-	.priority = 128,
+static void tegra_pmc_power_off_handler(struct power_off_data *data)
+{
+	/*
+	 * Reboot Nexus 7 into special bootloader mode if USB cable is
+	 * connected in order to display battery status and power off.
+	 */
+	if (of_machine_is_compatible("asus,grouper") &&
+	    power_supply_is_system_supplied()) {
+		const u32 go_to_charger_mode = 0xa5a55a5a;
+
+		tegra_pmc_writel(pmc, go_to_charger_mode, PMC_SCRATCH37);
+		tegra_pmc_restart(NULL);
+	}
+}
+
+static struct power_handler tegra_pmc_power_handler = {
+	.restart_cb = tegra_pmc_restart_handler,
+	.power_off_cb = tegra_pmc_power_off_handler,
+	.power_off_priority = POWEROFF_PRIO_FIRMWARE,
+	.power_off_chaining_allowed = true,
 };
 
 static int powergate_show(struct seq_file *s, void *data)
@@ -2859,6 +2879,13 @@ static int tegra_pmc_probe(struct platform_device *pdev)
 		pmc->clk = NULL;
 	}
 
+	err = devm_register_power_handler(&pdev->dev, &tegra_pmc_power_handler);
+	if (err) {
+		dev_err(&pdev->dev, "unable to register power handler, %d\n",
+			err);
+		return err;
+	}
+
 	/*
 	 * PCLK clock rate can't be retrieved using CLK API because it
 	 * causes lockup if CPU enters LP2 idle state from some other
@@ -2890,20 +2917,13 @@ static int tegra_pmc_probe(struct platform_device *pdev)
 			goto cleanup_sysfs;
 	}
 
-	err = register_restart_handler(&tegra_pmc_restart_handler);
-	if (err) {
-		dev_err(&pdev->dev, "unable to register restart handler, %d\n",
-			err);
-		goto cleanup_debugfs;
-	}
-
 	err = tegra_pmc_pinctrl_init(pmc);
 	if (err)
-		goto cleanup_restart_handler;
+		goto cleanup_debugfs;
 
 	err = tegra_pmc_regmap_init(pmc);
 	if (err < 0)
-		goto cleanup_restart_handler;
+		goto cleanup_debugfs;
 
 	err = tegra_powergate_init(pmc, pdev->dev.of_node);
 	if (err < 0)
@@ -2926,8 +2946,6 @@ static int tegra_pmc_probe(struct platform_device *pdev)
 
 cleanup_powergates:
 	tegra_powergate_remove_all(pdev->dev.of_node);
-cleanup_restart_handler:
-	unregister_restart_handler(&tegra_pmc_restart_handler);
 cleanup_debugfs:
 	debugfs_remove(pmc->debugfs);
 cleanup_sysfs:
-- 
2.33.1



From xen-devel-bounces@lists.xenproject.org Wed Oct 27 21:28:08 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Oct 2021 21:28:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217288.377332 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfqSk-0002UJ-FD; Wed, 27 Oct 2021 21:27:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217288.377332; Wed, 27 Oct 2021 21:27:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfqSk-0002SB-3b; Wed, 27 Oct 2021 21:27:58 +0000
Received: by outflank-mailman (input) for mailman id 217288;
 Wed, 27 Oct 2021 21:27:56 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=nMly=PP=gmail.com=digetx@srs-us1.protection.inumbo.net>)
 id 1mfqK9-0000sJ-9k
 for xen-devel@lists.xenproject.org; Wed, 27 Oct 2021 21:19:05 +0000
Received: from mail-lf1-x129.google.com (unknown [2a00:1450:4864:20::129])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id c91dc08f-1be2-4c3f-99b3-2504c75db291;
 Wed, 27 Oct 2021 21:18:19 +0000 (UTC)
Received: by mail-lf1-x129.google.com with SMTP id p16so9035184lfa.2
 for <xen-devel@lists.xenproject.org>; Wed, 27 Oct 2021 14:18:19 -0700 (PDT)
Received: from localhost.localdomain (46-138-41-28.dynamic.spd-mgts.ru.
 [46.138.41.28])
 by smtp.gmail.com with ESMTPSA id d7sm104336ljl.18.2021.10.27.14.18.17
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Wed, 27 Oct 2021 14:18:18 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c91dc08f-1be2-4c3f-99b3-2504c75db291
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=Cc0IUGWHitJ0Cooyguk/vAdy9iAEtCRPuqNtfJHYmrA=;
        b=hGiOk7puznFSxpZSFm/Eya2Cl9N4a04S/N7AMKzyQzEzjBU4DjBRSyeAPC6r2d+wM7
         xUQ7Ac9D1vF+xVotAvlC6ZCck4cXMzjLk9AuV7aPkEcOFRxo/Y6dcKGr+AskSfh12zZH
         j4t9S3xSdGJpshUHlnXLi2wz4oVxcxE35PVQckWFsoWLYAS6gGsox7O/ylTaKD83bUPI
         lt0JfBMnsOVk10t4KXi669c5Oy5pFEzyyvF+GC9JzvCvwEtP2Bq8P5zo32YZHs5FWOMt
         Vb6ZGXWglhHchKGKPrIHgEEJ9wGUMKsnUwpN3Lz0Uy/fasmq0C+gajXgFsv262T+m1RI
         GwKg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=Cc0IUGWHitJ0Cooyguk/vAdy9iAEtCRPuqNtfJHYmrA=;
        b=6/zYNa7H2H+Tpaf4MJDAU+tL/EjCzLf1K4unL8znIpbxRO6a3/6jqVGLnVA2tzry9S
         q1nA5wnh81VkUU5AcjIcxsQwf3qdqNL3WOXlmJBVwDAOVzDHxaUTLVuTmR/AoQSVQrcS
         KI2gfdrIRkTEtT5aZsSWdDRM13oRsF5lijbzMdqZ3IhEExqNCP9JE72pLpprqhVKitxN
         4kFSVlz9ekb40Zqz+f2ITnZOIc8iZTfe1NX1DuMKejBUZ+rvJMxVvwpO2MdX0Nt4RQUs
         VZLQri3Nl7rYxce20oZk9JkNUP7w6wot5tx64MCLv9CeNC2NbEI4Oc8hLImLEII374MP
         IR1w==
X-Gm-Message-State: AOAM533//XLFn/TKjefQlJLcyLzf33Wi8sDJVPQvSSUEIrgbLyJGZsh5
	c6UGcjpzJH4kN/Tu2GRV+Ks=
X-Google-Smtp-Source: ABdhPJygpdJSNoXRh8ba3OotHfDcr8CSl9bSWUL0hunV++q/wiTfcZPk6onGhghey5UXGxJAqpQkjw==
X-Received: by 2002:a05:6512:228a:: with SMTP id f10mr83288lfu.489.1635369498913;
        Wed, 27 Oct 2021 14:18:18 -0700 (PDT)
From: Dmitry Osipenko <digetx@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Lee Jones <lee.jones@linaro.org>,
	"Rafael J . Wysocki" <rafael@kernel.org>,
	Mark Brown <broonie@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Russell King <linux@armlinux.org.uk>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Ulf Hansson <ulf.hansson@linaro.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Guo Ren <guoren@kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Greg Ungerer <gerg@linux-m68k.org>,
	Joshua Thompson <funaho@jurai.org>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Nick Hu <nickhu@andestech.com>,
	Greentime Hu <green.hu@gmail.com>,
	Vincent Chen <deanbo422@gmail.com>,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	Helge Deller <deller@gmx.de>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Rich Felker <dalias@libc.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Len Brown <lenb@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Chen-Yu Tsai <wens@csie.org>,
	=?UTF-8?q?Jonathan=20Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>,
	Tony Lindgren <tony@atomide.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Vladimir Zapolskiy <vz@mleia.com>,
	Avi Fishman <avifishman70@gmail.com>,
	Tomer Maimon <tmaimon77@gmail.com>,
	Tali Perry <tali.perry1@gmail.com>,
	Patrick Venture <venture@google.com>,
	Nancy Yuen <yuenn@google.com>,
	Benjamin Fair <benjaminfair@google.com>,
	Pavel Machek <pavel@ucw.cz>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	linux-csky@vger.kernel.org,
	linux-ia64@vger.kernel.org,
	linux-m68k@lists.linux-m68k.org,
	linux-mips@vger.kernel.org,
	linux-parisc@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-riscv@lists.infradead.org,
	linux-sh@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	linux-acpi@vger.kernel.org,
	linux-omap@vger.kernel.org,
	openbmc@lists.ozlabs.org,
	linux-tegra@vger.kernel.org,
	linux-pm@vger.kernel.org
Subject: [PATCH v2 14/45] mips: Use do_kernel_power_off()
Date: Thu, 28 Oct 2021 00:16:44 +0300
Message-Id: <20211027211715.12671-15-digetx@gmail.com>
X-Mailer: git-send-email 2.33.1
In-Reply-To: <20211027211715.12671-1-digetx@gmail.com>
References: <20211027211715.12671-1-digetx@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Kernel now supports chained power-off handlers. Use do_kernel_power_off()
that invokes chained power-off handlers. It also invokes legacy
pm_power_off() for now, which will be removed once all drivers will
be converted to the new power-off API.

Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
 arch/mips/kernel/reset.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/mips/kernel/reset.c b/arch/mips/kernel/reset.c
index 6288780b779e..e7ce07b3e79b 100644
--- a/arch/mips/kernel/reset.c
+++ b/arch/mips/kernel/reset.c
@@ -114,8 +114,7 @@ void machine_halt(void)
 
 void machine_power_off(void)
 {
-	if (pm_power_off)
-		pm_power_off();
+	do_kernel_power_off();
 
 #ifdef CONFIG_SMP
 	preempt_disable();
-- 
2.33.1



From xen-devel-bounces@lists.xenproject.org Wed Oct 27 21:28:14 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Oct 2021 21:28:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217291.377349 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfqSp-0003Pb-6T; Wed, 27 Oct 2021 21:28:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217291.377349; Wed, 27 Oct 2021 21:28:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfqSp-0003PH-2K; Wed, 27 Oct 2021 21:28:03 +0000
Received: by outflank-mailman (input) for mailman id 217291;
 Wed, 27 Oct 2021 21:28:02 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=nMly=PP=gmail.com=digetx@srs-us1.protection.inumbo.net>)
 id 1mfqLg-0000sJ-Cm
 for xen-devel@lists.xenproject.org; Wed, 27 Oct 2021 21:20:40 +0000
Received: from mail-lj1-x22c.google.com (unknown [2a00:1450:4864:20::22c])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 2a30c3a8-3914-4552-9591-340833ae07dc;
 Wed, 27 Oct 2021 21:18:45 +0000 (UTC)
Received: by mail-lj1-x22c.google.com with SMTP id k13so6922068ljj.12
 for <xen-devel@lists.xenproject.org>; Wed, 27 Oct 2021 14:18:45 -0700 (PDT)
Received: from localhost.localdomain (46-138-41-28.dynamic.spd-mgts.ru.
 [46.138.41.28])
 by smtp.gmail.com with ESMTPSA id d7sm104336ljl.18.2021.10.27.14.18.43
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Wed, 27 Oct 2021 14:18:44 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2a30c3a8-3914-4552-9591-340833ae07dc
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=XVkgO3q8+3iXvnI8C7YHW1hpsebxqvqNvVwPho8vSws=;
        b=JvBjth71MhsyIm0JdpPylPRsS4KUFW6BneSIAqxDXDzbFjW9Bt93MWfm5UnDUVT+LY
         PN2DoVOg4LkGHqR46okUaH0xtknlZuN7sz1m2rXWFP+8ycrv0mDE2+lXOLhNQyopT3Vb
         C9HJqmEvn5NNTeFE+Yqt8PhYhqF5nNL7X6uD9nn3NzyyFpNh4ofur6IOki9Q5zCOptdK
         PNXfyjJD/8x2BE3QO9lZ5RaDpWCetJjHnzeJvzuWrsMKLwqp5dFqdwNw5X1p5tIb9H77
         X9gwILOKempj602Hj9wd8g1ui3+PA2eteBB91Roi8uzQIKwV7mQ4s5O8fFD8fUrtUyG6
         Kjfw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=XVkgO3q8+3iXvnI8C7YHW1hpsebxqvqNvVwPho8vSws=;
        b=Cv6uTIRUoRiNxUDYded0HSpKvlZPwGeb2gPoFy0B36ap8b767QFpNMBV3eQwfBlSQu
         YbuJgQ5blV6EV/LFQB4WxtL4goTzHhJN5L3zeKyCh/gZOnbWW3/03T24r4b2O3YuAl3d
         lu4C+bCFb0/+merDn1ZnM0tMC0lZO20loeqvgHd22ZLe86HlyaEkBVLx01yZvjIScBwG
         smxWdTRQjkalmg7AGdlb6w1SYvEwlVUlZJCIHpwf0urSSQ5K+IjgJSSnEjJhPKY3xh1A
         1fXA7GDMzn2lCQ6SOpgzt5P5L7h0un+MUx0J6TZTgNzBt9PLu86Ubxi/NKQUeyk5htiC
         OLzw==
X-Gm-Message-State: AOAM533V+wAfoJO5TwDZNOi1ZykbfglfosZqd2HY5ujTzdI+krnVL4+8
	0OuMOVx4vbuZT7+WtpfjWVo=
X-Google-Smtp-Source: ABdhPJyyXdjb3N9Ed9Jr705ZzPzIsFRHZUJ+KOYE2dHtjD39JQsr/OWSSeXdN0P7Zob21uOYhbWDdA==
X-Received: by 2002:a2e:9b55:: with SMTP id o21mr306486ljj.141.1635369524980;
        Wed, 27 Oct 2021 14:18:44 -0700 (PDT)
From: Dmitry Osipenko <digetx@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Lee Jones <lee.jones@linaro.org>,
	"Rafael J . Wysocki" <rafael@kernel.org>,
	Mark Brown <broonie@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Russell King <linux@armlinux.org.uk>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Ulf Hansson <ulf.hansson@linaro.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Guo Ren <guoren@kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Greg Ungerer <gerg@linux-m68k.org>,
	Joshua Thompson <funaho@jurai.org>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Nick Hu <nickhu@andestech.com>,
	Greentime Hu <green.hu@gmail.com>,
	Vincent Chen <deanbo422@gmail.com>,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	Helge Deller <deller@gmx.de>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Rich Felker <dalias@libc.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Len Brown <lenb@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Chen-Yu Tsai <wens@csie.org>,
	=?UTF-8?q?Jonathan=20Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>,
	Tony Lindgren <tony@atomide.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Vladimir Zapolskiy <vz@mleia.com>,
	Avi Fishman <avifishman70@gmail.com>,
	Tomer Maimon <tmaimon77@gmail.com>,
	Tali Perry <tali.perry1@gmail.com>,
	Patrick Venture <venture@google.com>,
	Nancy Yuen <yuenn@google.com>,
	Benjamin Fair <benjaminfair@google.com>,
	Pavel Machek <pavel@ucw.cz>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	linux-csky@vger.kernel.org,
	linux-ia64@vger.kernel.org,
	linux-m68k@lists.linux-m68k.org,
	linux-mips@vger.kernel.org,
	linux-parisc@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-riscv@lists.infradead.org,
	linux-sh@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	linux-acpi@vger.kernel.org,
	linux-omap@vger.kernel.org,
	openbmc@lists.ozlabs.org,
	linux-tegra@vger.kernel.org,
	linux-pm@vger.kernel.org
Subject: [PATCH v2 28/45] mfd: rn5t618: Use devm_register_power_handler()
Date: Thu, 28 Oct 2021 00:16:58 +0300
Message-Id: <20211027211715.12671-29-digetx@gmail.com>
X-Mailer: git-send-email 2.33.1
In-Reply-To: <20211027211715.12671-1-digetx@gmail.com>
References: <20211027211715.12671-1-digetx@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Use devm_register_power_handler() that replaces global pm_power_off
variable and allows to register multiple power-off handlers. It also
provides restart-handler support, i.e. all in one API.

Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
 drivers/mfd/rn5t618.c | 56 ++++++++++++++++---------------------------
 1 file changed, 21 insertions(+), 35 deletions(-)

diff --git a/drivers/mfd/rn5t618.c b/drivers/mfd/rn5t618.c
index 384acb459427..12d7b2339bbe 100644
--- a/drivers/mfd/rn5t618.c
+++ b/drivers/mfd/rn5t618.c
@@ -84,9 +84,6 @@ static const struct regmap_irq_chip rc5t619_irq_chip = {
 	.mask_invert = true,
 };
 
-static struct i2c_client *rn5t618_pm_power_off;
-static struct notifier_block rn5t618_restart_handler;
-
 static int rn5t618_irq_init(struct rn5t618 *rn5t618)
 {
 	const struct regmap_irq_chip *irq_chip = NULL;
@@ -115,7 +112,9 @@ static int rn5t618_irq_init(struct rn5t618 *rn5t618)
 	return ret;
 }
 
-static void rn5t618_trigger_poweroff_sequence(bool repower)
+static void
+rn5t618_trigger_poweroff_sequence(struct i2c_client *rn5t618_pm_power_off,
+				  bool repower)
 {
 	int ret;
 
@@ -151,25 +150,31 @@ static void rn5t618_trigger_poweroff_sequence(bool repower)
 	dev_alert(&rn5t618_pm_power_off->dev, "Failed to shutdown (err = %d)\n", ret);
 }
 
-static void rn5t618_power_off(void)
+static void rn5t618_power_off(struct power_off_data *data)
 {
-	rn5t618_trigger_poweroff_sequence(false);
+	struct i2c_client *client = data->cb_data;
+
+	rn5t618_trigger_poweroff_sequence(client, false);
 }
 
-static int rn5t618_restart(struct notifier_block *this,
-			    unsigned long mode, void *cmd)
+static void rn5t618_restart(struct restart_data *data)
 {
-	rn5t618_trigger_poweroff_sequence(true);
+	struct i2c_client *client = data->cb_data;
+
+	rn5t618_trigger_poweroff_sequence(client, true);
 
 	/*
 	 * Re-power factor detection on PMIC side is not instant. 1ms
 	 * proved to be enough time until reset takes effect.
 	 */
 	mdelay(1);
-
-	return NOTIFY_DONE;
 }
 
+static struct power_handler rn5t618_power_handler = {
+	.restart_cb = rn5t618_restart,
+	.restart_priority = RESTART_PRIO_HIGH,
+};
+
 static const struct of_device_id rn5t618_of_match[] = {
 	{ .compatible = "ricoh,rn5t567", .data = (void *)RN5T567 },
 	{ .compatible = "ricoh,rn5t618", .data = (void *)RN5T618 },
@@ -221,38 +226,20 @@ static int rn5t618_i2c_probe(struct i2c_client *i2c)
 		return ret;
 	}
 
-	rn5t618_pm_power_off = i2c;
-	if (of_device_is_system_power_controller(i2c->dev.of_node)) {
-		if (!pm_power_off)
-			pm_power_off = rn5t618_power_off;
-		else
-			dev_warn(&i2c->dev, "Poweroff callback already assigned\n");
-	}
+	if (of_device_is_system_power_controller(i2c->dev.of_node))
+		rn5t618_power_handler.power_off_cb = rn5t618_power_off;
 
-	rn5t618_restart_handler.notifier_call = rn5t618_restart;
-	rn5t618_restart_handler.priority = 192;
+	rn5t618_power_handler.cb_data = i2c;
 
-	ret = register_restart_handler(&rn5t618_restart_handler);
+	ret = devm_register_power_handler(&i2c->dev, &rn5t618_power_handler);
 	if (ret) {
-		dev_err(&i2c->dev, "cannot register restart handler, %d\n", ret);
+		dev_err(&i2c->dev, "failed to register power handler: %d\n", ret);
 		return ret;
 	}
 
 	return rn5t618_irq_init(priv);
 }
 
-static int rn5t618_i2c_remove(struct i2c_client *i2c)
-{
-	if (i2c == rn5t618_pm_power_off) {
-		rn5t618_pm_power_off = NULL;
-		pm_power_off = NULL;
-	}
-
-	unregister_restart_handler(&rn5t618_restart_handler);
-
-	return 0;
-}
-
 static int __maybe_unused rn5t618_i2c_suspend(struct device *dev)
 {
 	struct rn5t618 *priv = dev_get_drvdata(dev);
@@ -284,7 +271,6 @@ static struct i2c_driver rn5t618_i2c_driver = {
 		.pm = &rn5t618_i2c_dev_pm_ops,
 	},
 	.probe_new = rn5t618_i2c_probe,
-	.remove = rn5t618_i2c_remove,
 };
 
 module_i2c_driver(rn5t618_i2c_driver);
-- 
2.33.1



From xen-devel-bounces@lists.xenproject.org Wed Oct 27 21:28:15 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Oct 2021 21:28:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217293.377357 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfqSr-0003m0-Dn; Wed, 27 Oct 2021 21:28:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217293.377357; Wed, 27 Oct 2021 21:28:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfqSq-0003kR-Sv; Wed, 27 Oct 2021 21:28:04 +0000
Received: by outflank-mailman (input) for mailman id 217293;
 Wed, 27 Oct 2021 21:28:02 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=nMly=PP=gmail.com=digetx@srs-us1.protection.inumbo.net>)
 id 1mfqJp-0000sJ-9M
 for xen-devel@lists.xenproject.org; Wed, 27 Oct 2021 21:18:45 +0000
Received: from mail-lj1-x22c.google.com (unknown [2a00:1450:4864:20::22c])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id fa87cbdc-a519-4dc2-8f4a-cb53f367af93;
 Wed, 27 Oct 2021 21:18:12 +0000 (UTC)
Received: by mail-lj1-x22c.google.com with SMTP id d23so5636747ljj.10
 for <xen-devel@lists.xenproject.org>; Wed, 27 Oct 2021 14:18:12 -0700 (PDT)
Received: from localhost.localdomain (46-138-41-28.dynamic.spd-mgts.ru.
 [46.138.41.28])
 by smtp.gmail.com with ESMTPSA id d7sm104336ljl.18.2021.10.27.14.18.09
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Wed, 27 Oct 2021 14:18:11 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fa87cbdc-a519-4dc2-8f4a-cb53f367af93
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=SC0z1BXiHBYdSnCagR43oAXvnFYzAsSZgTyQ9BiR6xA=;
        b=OqqZ454WmFhFtJRhrw1iVetFaZ5cTmy1bK8cAKF7x4FJ4EjwPLEB4smQoL+kFj8hga
         BjmXNHow4qrZGAK5gLKqSouT5oIb6yppthDueiLerRGv55Pbl/JgRUYLNcFzmXzu9NWO
         EfhhNkXWXYZNWJhLg94zD8UyrvrtUOP73QnC8NTzMu/ENt6HanrdBXR7OCg2dyRE+fYN
         1aO4sBj2Cdgy8VygaDgIGG5bFgsrX38xxJAfHh6M83eOLzNNbly5jBUwBwT1c3/ScSfl
         6ZeIfaA93j63rbj1hC4fiWUjcO1LV9zENBfV1gxkADNuk/sNHvjjMOa2SIgObFEQihCd
         GDlw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=SC0z1BXiHBYdSnCagR43oAXvnFYzAsSZgTyQ9BiR6xA=;
        b=z8Q9DWuAXsgqcQ+MIzqcXJHobJKYZWvEqvg0H235r9zMqA89hhRgneH+IPwWrFSesw
         YE5in9E7gjCHF7cGxDJREE0CQbTHL2h8GLZ+fKuaSct/PAUnfYp8mczqZGeokYaOUG/9
         PxeRY6Sv8pAXo/PuEEVut4DY+kQ2zodZwndePD9DRHHEQvDV70VtLUmV4PNpMzmRTWk0
         jH2tcF83UN+o8oY/kWUhyko+goqAoXhWXGZMADZ9XAzXEe5a8yvV2xj7w8/m0q4ZDHeC
         +SzFW01yhwVakB4vykrdlxIhjitx5oU1BG4d8mnBE4kuM230TAUeAEezxSVuDRbiAiGi
         enEA==
X-Gm-Message-State: AOAM532Fuwwy6f9Zx6XVafLo+C420Yq6VBnzuNeHuDBEy8Ex9/3LzPj9
	nexmhH7BY/jxwLmtC4HomVM=
X-Google-Smtp-Source: ABdhPJyn+zaTZhCmg6enYSN9xCI0Iv7Hmc/0KiXYEr7/tCUpX3ufLRXDN1zs5d0zePAVBcBxKNrxsQ==
X-Received: by 2002:a05:651c:291:: with SMTP id b17mr380232ljo.90.1635369491425;
        Wed, 27 Oct 2021 14:18:11 -0700 (PDT)
From: Dmitry Osipenko <digetx@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Lee Jones <lee.jones@linaro.org>,
	"Rafael J . Wysocki" <rafael@kernel.org>,
	Mark Brown <broonie@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Russell King <linux@armlinux.org.uk>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Ulf Hansson <ulf.hansson@linaro.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Guo Ren <guoren@kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Greg Ungerer <gerg@linux-m68k.org>,
	Joshua Thompson <funaho@jurai.org>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Nick Hu <nickhu@andestech.com>,
	Greentime Hu <green.hu@gmail.com>,
	Vincent Chen <deanbo422@gmail.com>,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	Helge Deller <deller@gmx.de>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Rich Felker <dalias@libc.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Len Brown <lenb@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Chen-Yu Tsai <wens@csie.org>,
	=?UTF-8?q?Jonathan=20Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>,
	Tony Lindgren <tony@atomide.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Vladimir Zapolskiy <vz@mleia.com>,
	Avi Fishman <avifishman70@gmail.com>,
	Tomer Maimon <tmaimon77@gmail.com>,
	Tali Perry <tali.perry1@gmail.com>,
	Patrick Venture <venture@google.com>,
	Nancy Yuen <yuenn@google.com>,
	Benjamin Fair <benjaminfair@google.com>,
	Pavel Machek <pavel@ucw.cz>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	linux-csky@vger.kernel.org,
	linux-ia64@vger.kernel.org,
	linux-m68k@lists.linux-m68k.org,
	linux-mips@vger.kernel.org,
	linux-parisc@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-riscv@lists.infradead.org,
	linux-sh@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	linux-acpi@vger.kernel.org,
	linux-omap@vger.kernel.org,
	openbmc@lists.ozlabs.org,
	linux-tegra@vger.kernel.org,
	linux-pm@vger.kernel.org
Subject: [PATCH v2 10/45] ARM: Use do_kernel_power_off()
Date: Thu, 28 Oct 2021 00:16:40 +0300
Message-Id: <20211027211715.12671-11-digetx@gmail.com>
X-Mailer: git-send-email 2.33.1
In-Reply-To: <20211027211715.12671-1-digetx@gmail.com>
References: <20211027211715.12671-1-digetx@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Kernel now supports chained power-off handlers. Use do_kernel_power_off()
that invokes chained power-off handlers. It also invokes legacy
pm_power_off() for now, which will be removed once all drivers will
be converted to the new power-off API.

Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
 arch/arm/kernel/reboot.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/arch/arm/kernel/reboot.c b/arch/arm/kernel/reboot.c
index 3044fcb8d073..2cb943422554 100644
--- a/arch/arm/kernel/reboot.c
+++ b/arch/arm/kernel/reboot.c
@@ -116,9 +116,7 @@ void machine_power_off(void)
 {
 	local_irq_disable();
 	smp_send_stop();
-
-	if (pm_power_off)
-		pm_power_off();
+	do_kernel_power_off();
 }
 
 /*
-- 
2.33.1



From xen-devel-bounces@lists.xenproject.org Wed Oct 27 21:28:17 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Oct 2021 21:28:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217294.377364 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfqSs-00040e-Ta; Wed, 27 Oct 2021 21:28:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217294.377364; Wed, 27 Oct 2021 21:28:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfqSs-0003sc-0v; Wed, 27 Oct 2021 21:28:06 +0000
Received: by outflank-mailman (input) for mailman id 217294;
 Wed, 27 Oct 2021 21:28:03 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=nMly=PP=gmail.com=digetx@srs-us1.protection.inumbo.net>)
 id 1mfqLW-0000sJ-CQ
 for xen-devel@lists.xenproject.org; Wed, 27 Oct 2021 21:20:30 +0000
Received: from mail-lf1-x129.google.com (unknown [2a00:1450:4864:20::129])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 86a69c89-a557-4740-824b-69dfcad5c2ab;
 Wed, 27 Oct 2021 21:18:44 +0000 (UTC)
Received: by mail-lf1-x129.google.com with SMTP id l13so8991340lfg.6
 for <xen-devel@lists.xenproject.org>; Wed, 27 Oct 2021 14:18:44 -0700 (PDT)
Received: from localhost.localdomain (46-138-41-28.dynamic.spd-mgts.ru.
 [46.138.41.28])
 by smtp.gmail.com with ESMTPSA id d7sm104336ljl.18.2021.10.27.14.18.41
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Wed, 27 Oct 2021 14:18:42 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 86a69c89-a557-4740-824b-69dfcad5c2ab
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=C0CUDQ/mpKr8nQVI8ALn1ZNGlMYg+VmEWd/lyCBC2+I=;
        b=Z3brf9Hxnc2b6ua3/QaRBg13ceKk9pypP3vq3e3axfEBPvBW41vI/qfBl8+BwawzwO
         NlHu2lL93XTrvXoS8prTqJO+oc3t3LVioKZpz1/2twqHxmO2Rep4n956JPepAb55tnvu
         Yq8u1nymmyHqcHNTOwToESfBr2ALI5JLRcu8Vew43TUipSvAyYGlhtxcdEE10JjxQ8L7
         CgvM26J/cz900816o54jCXMSmEWOFUvtpqIxxDad09smC+hGdBM0SBN82Upy8AJEypnh
         RA0SpOKKidR5e2HsVPYqqyxDECtb4bl9tRIXX4QIA46Li7tlvPD9rk0WAJDNE7RcwF/Y
         YL9g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=C0CUDQ/mpKr8nQVI8ALn1ZNGlMYg+VmEWd/lyCBC2+I=;
        b=QYZHkayd1rU4KUiFbHPPi7aR8O2qeW/LVfrCQJUYnt5HStEqeB4cg1UyF+ntyiDSbR
         jaIhcVRzEnHzAmiXgs7z8+SdkQZtI+tggiZaPAByC+woMHrPOMvpxICkR07c0xdj39jO
         a2YuBoUt7OStOf4xYlYP4478ZMpXsBWhjhQTlgQ52lWhTmQqLqmFOmQiGWa9aVgXVC3w
         ZuSpHDgU/bh+Vm/rX3duBTih7fO2AFJ8IUAbmo0ybvN0cyZph/NyQe00ob6A85X+nqDr
         arbtgiLmI7wMMjQsrNAFV254AWJnBSwmuBY7VkPl064RVEkRy3ipEfuRpiTLvCi0w5Je
         vN+Q==
X-Gm-Message-State: AOAM5315Xdz3q2hAqaORyn7zn0EdN/AegwxiVJYasd95BRO0OuLhlDun
	HoBA0WoC3QUdfPNktT2YM1g=
X-Google-Smtp-Source: ABdhPJw9ag+XL4jMbHM8NK1hhlQp61Q60DmRHFpovh5w79ZSq7lT/XD7C7FFPkBUSvk0m7mbQoA/BQ==
X-Received: by 2002:a05:6512:31a:: with SMTP id t26mr125024lfp.280.1635369523122;
        Wed, 27 Oct 2021 14:18:43 -0700 (PDT)
From: Dmitry Osipenko <digetx@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Lee Jones <lee.jones@linaro.org>,
	"Rafael J . Wysocki" <rafael@kernel.org>,
	Mark Brown <broonie@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Russell King <linux@armlinux.org.uk>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Ulf Hansson <ulf.hansson@linaro.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Guo Ren <guoren@kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Greg Ungerer <gerg@linux-m68k.org>,
	Joshua Thompson <funaho@jurai.org>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Nick Hu <nickhu@andestech.com>,
	Greentime Hu <green.hu@gmail.com>,
	Vincent Chen <deanbo422@gmail.com>,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	Helge Deller <deller@gmx.de>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Rich Felker <dalias@libc.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Len Brown <lenb@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Chen-Yu Tsai <wens@csie.org>,
	=?UTF-8?q?Jonathan=20Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>,
	Tony Lindgren <tony@atomide.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Vladimir Zapolskiy <vz@mleia.com>,
	Avi Fishman <avifishman70@gmail.com>,
	Tomer Maimon <tmaimon77@gmail.com>,
	Tali Perry <tali.perry1@gmail.com>,
	Patrick Venture <venture@google.com>,
	Nancy Yuen <yuenn@google.com>,
	Benjamin Fair <benjaminfair@google.com>,
	Pavel Machek <pavel@ucw.cz>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	linux-csky@vger.kernel.org,
	linux-ia64@vger.kernel.org,
	linux-m68k@lists.linux-m68k.org,
	linux-mips@vger.kernel.org,
	linux-parisc@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-riscv@lists.infradead.org,
	linux-sh@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	linux-acpi@vger.kernel.org,
	linux-omap@vger.kernel.org,
	openbmc@lists.ozlabs.org,
	linux-tegra@vger.kernel.org,
	linux-pm@vger.kernel.org
Subject: [PATCH v2 27/45] mfd: ntxec: Use devm_register_power_handler()
Date: Thu, 28 Oct 2021 00:16:57 +0300
Message-Id: <20211027211715.12671-28-digetx@gmail.com>
X-Mailer: git-send-email 2.33.1
In-Reply-To: <20211027211715.12671-1-digetx@gmail.com>
References: <20211027211715.12671-1-digetx@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Use devm_register_power_handler() that replaces global pm_power_off
variable and allows to register multiple power-off handlers. It also
provides restart-handler support, i.e. all in one API.

Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
 drivers/mfd/ntxec.c | 50 ++++++++++-----------------------------------
 1 file changed, 11 insertions(+), 39 deletions(-)

diff --git a/drivers/mfd/ntxec.c b/drivers/mfd/ntxec.c
index b711e73eedcb..fd6410cbe153 100644
--- a/drivers/mfd/ntxec.c
+++ b/drivers/mfd/ntxec.c
@@ -32,12 +32,11 @@
 #define NTXEC_POWERKEEP_VALUE	0x0800
 #define NTXEC_RESET_VALUE	0xff00
 
-static struct i2c_client *poweroff_restart_client;
-
-static void ntxec_poweroff(void)
+static void ntxec_poweroff(struct power_off_data *data)
 {
 	int res;
 	u8 buf[3] = { NTXEC_REG_POWEROFF };
+	struct i2c_client *poweroff_restart_client = data->cb_data;
 	struct i2c_msg msgs[] = {
 		{
 			.addr = poweroff_restart_client->addr,
@@ -62,8 +61,7 @@ static void ntxec_poweroff(void)
 	msleep(5000);
 }
 
-static int ntxec_restart(struct notifier_block *nb,
-			 unsigned long action, void *data)
+static void ntxec_restart(struct restart_data *data)
 {
 	int res;
 	u8 buf[3] = { NTXEC_REG_RESET };
@@ -72,6 +70,7 @@ static int ntxec_restart(struct notifier_block *nb,
 	 * it causes an I2C error. (The reset handler in the downstream driver
 	 * does send the full two-byte value, but doesn't check the result).
 	 */
+	struct i2c_client *poweroff_restart_client = data->cb_data;
 	struct i2c_msg msgs[] = {
 		{
 			.addr = poweroff_restart_client->addr,
@@ -87,13 +86,11 @@ static int ntxec_restart(struct notifier_block *nb,
 	if (res < 0)
 		dev_warn(&poweroff_restart_client->dev,
 			 "Failed to restart (err = %d)\n", res);
-
-	return NOTIFY_DONE;
 }
 
-static struct notifier_block ntxec_restart_handler = {
-	.notifier_call = ntxec_restart,
-	.priority = 128,
+static struct power_handler ntxec_power_handler = {
+	.restart_cb = ntxec_restart,
+	.power_off_cb = ntxec_poweroff,
 };
 
 static int regmap_ignore_write(void *context,
@@ -208,25 +205,12 @@ static int ntxec_probe(struct i2c_client *client)
 		if (res < 0)
 			return res;
 
-		if (poweroff_restart_client)
-			/*
-			 * Another instance of the driver already took
-			 * poweroff/restart duties.
-			 */
-			dev_err(ec->dev, "poweroff_restart_client already assigned\n");
-		else
-			poweroff_restart_client = client;
-
-		if (pm_power_off)
-			/* Another driver already registered a poweroff handler. */
-			dev_err(ec->dev, "pm_power_off already assigned\n");
-		else
-			pm_power_off = ntxec_poweroff;
-
-		res = register_restart_handler(&ntxec_restart_handler);
+		ntxec_power_handler.cb_data = client;
+
+		res = devm_register_power_handler(ec->dev, &ntxec_power_handler);
 		if (res)
 			dev_err(ec->dev,
-				"Failed to register restart handler: %d\n", res);
+				"Failed to register power handler: %d\n", res);
 	}
 
 	i2c_set_clientdata(client, ec);
@@ -239,17 +223,6 @@ static int ntxec_probe(struct i2c_client *client)
 	return res;
 }
 
-static int ntxec_remove(struct i2c_client *client)
-{
-	if (client == poweroff_restart_client) {
-		poweroff_restart_client = NULL;
-		pm_power_off = NULL;
-		unregister_restart_handler(&ntxec_restart_handler);
-	}
-
-	return 0;
-}
-
 static const struct of_device_id of_ntxec_match_table[] = {
 	{ .compatible = "netronix,ntxec", },
 	{}
@@ -262,7 +235,6 @@ static struct i2c_driver ntxec_driver = {
 		.of_match_table = of_ntxec_match_table,
 	},
 	.probe_new = ntxec_probe,
-	.remove = ntxec_remove,
 };
 module_i2c_driver(ntxec_driver);
 
-- 
2.33.1



From xen-devel-bounces@lists.xenproject.org Wed Oct 27 21:28:18 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Oct 2021 21:28:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217295.377369 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfqSt-0004GG-U7; Wed, 27 Oct 2021 21:28:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217295.377369; Wed, 27 Oct 2021 21:28:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfqSt-0004B9-4f; Wed, 27 Oct 2021 21:28:07 +0000
Received: by outflank-mailman (input) for mailman id 217295;
 Wed, 27 Oct 2021 21:28:03 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=nMly=PP=gmail.com=digetx@srs-us1.protection.inumbo.net>)
 id 1mfqKT-0000sJ-AJ
 for xen-devel@lists.xenproject.org; Wed, 27 Oct 2021 21:19:25 +0000
Received: from mail-lj1-x22f.google.com (unknown [2a00:1450:4864:20::22f])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id b85a0f4c-68ce-41fd-81db-436811659b39;
 Wed, 27 Oct 2021 21:18:27 +0000 (UTC)
Received: by mail-lj1-x22f.google.com with SMTP id s19so6943375ljj.11
 for <xen-devel@lists.xenproject.org>; Wed, 27 Oct 2021 14:18:27 -0700 (PDT)
Received: from localhost.localdomain (46-138-41-28.dynamic.spd-mgts.ru.
 [46.138.41.28])
 by smtp.gmail.com with ESMTPSA id d7sm104336ljl.18.2021.10.27.14.18.24
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Wed, 27 Oct 2021 14:18:26 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b85a0f4c-68ce-41fd-81db-436811659b39
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=+aSuiMovnmRlKPN5Rl3JuNmFHUt6skQo3O4wD7dX5JQ=;
        b=ehfhpJuO10tH0JJc+NToykiYU0vR9QNQWRGBFoJEmaOxGSK6IxZtCBEULR0W0LLrnh
         rWgUh4Kku73ZADq2I2DXfxnNngsudNBU15HzSYHJ5ZGaDy4yKkQqtcH85+TmIu3x8kh9
         Xstkp84P8gb9NHhImh/kkEu/eLRzihVMriWTiS1lyvVYlI0S9doH7srHH4uUDtgtagHH
         NnlFwVxtytB+YFKInQI4zlx/qw9ggp+d792cFqZ86NXSDRvmn2HsZCjK5JnAlXZtcFzO
         y6wwCc1x7j8EpGXUAyH+X2YWcF6tl/6iZWVr+mUSLKEmJFL/9H+FbFwe9fJf0ZNH5qP/
         q9Cw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=+aSuiMovnmRlKPN5Rl3JuNmFHUt6skQo3O4wD7dX5JQ=;
        b=yDZar7Z4ETp0eiJMYqbWz+Pv9sP/D9+OjaQQiTCH2cy9PFh/9b4EbdLdECZdz3eByQ
         nlubfo90lbmCH0UpQMGoQQ7lvbdKVWrLWKbg3Yb2r/zq2+DjPUr3BJSMcjuJtydQy41+
         ElyYpdnDUe7+iBGJmtDTa3O31K4BamF5WZMkxPcbDm5RdF4GL7A2fwP8hKxMlB0ZmrAq
         VheMi+jJHltaVvY/+jKi1Hxx77i+GaikoB+YZYG8yQvzN57Yp88AaQa4iZM0EHFa18cS
         2Q/sTFEOqJcsKTbBoImdSVdDw26F1btxxVaIpRYNqja84Zqvse//2thnzWE8bi5NI40C
         BoQQ==
X-Gm-Message-State: AOAM5339T7wC4DSHhL6SxFZqYKsBVBIOHvPIAkfRqWs3Q2YeIRIlsmiZ
	J2L56yJBv6FO3Sk3YwVOMto=
X-Google-Smtp-Source: ABdhPJySCnLdJnyefyOJzA6HMZEBF+hyXH0EM8QKUFyfoUHamOZK7R7lRqwGKBcRpuomVJFL6q66/Q==
X-Received: by 2002:a2e:891a:: with SMTP id d26mr331100lji.368.1635369506344;
        Wed, 27 Oct 2021 14:18:26 -0700 (PDT)
From: Dmitry Osipenko <digetx@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Lee Jones <lee.jones@linaro.org>,
	"Rafael J . Wysocki" <rafael@kernel.org>,
	Mark Brown <broonie@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Russell King <linux@armlinux.org.uk>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Ulf Hansson <ulf.hansson@linaro.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Guo Ren <guoren@kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Greg Ungerer <gerg@linux-m68k.org>,
	Joshua Thompson <funaho@jurai.org>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Nick Hu <nickhu@andestech.com>,
	Greentime Hu <green.hu@gmail.com>,
	Vincent Chen <deanbo422@gmail.com>,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	Helge Deller <deller@gmx.de>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Rich Felker <dalias@libc.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Len Brown <lenb@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Chen-Yu Tsai <wens@csie.org>,
	=?UTF-8?q?Jonathan=20Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>,
	Tony Lindgren <tony@atomide.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Vladimir Zapolskiy <vz@mleia.com>,
	Avi Fishman <avifishman70@gmail.com>,
	Tomer Maimon <tmaimon77@gmail.com>,
	Tali Perry <tali.perry1@gmail.com>,
	Patrick Venture <venture@google.com>,
	Nancy Yuen <yuenn@google.com>,
	Benjamin Fair <benjaminfair@google.com>,
	Pavel Machek <pavel@ucw.cz>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	linux-csky@vger.kernel.org,
	linux-ia64@vger.kernel.org,
	linux-m68k@lists.linux-m68k.org,
	linux-mips@vger.kernel.org,
	linux-parisc@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-riscv@lists.infradead.org,
	linux-sh@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	linux-acpi@vger.kernel.org,
	linux-omap@vger.kernel.org,
	openbmc@lists.ozlabs.org,
	linux-tegra@vger.kernel.org,
	linux-pm@vger.kernel.org
Subject: [PATCH v2 18/45] riscv: Use do_kernel_power_off()
Date: Thu, 28 Oct 2021 00:16:48 +0300
Message-Id: <20211027211715.12671-19-digetx@gmail.com>
X-Mailer: git-send-email 2.33.1
In-Reply-To: <20211027211715.12671-1-digetx@gmail.com>
References: <20211027211715.12671-1-digetx@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Kernel now supports chained power-off handlers. Use do_kernel_power_off()
that invokes chained power-off handlers. It also invokes legacy
pm_power_off() for now, which will be removed once all drivers will
be converted to the new power-off API.

Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
 arch/riscv/kernel/reset.c | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)

diff --git a/arch/riscv/kernel/reset.c b/arch/riscv/kernel/reset.c
index 9c842c41684a..912288572226 100644
--- a/arch/riscv/kernel/reset.c
+++ b/arch/riscv/kernel/reset.c
@@ -23,16 +23,12 @@ void machine_restart(char *cmd)
 
 void machine_halt(void)
 {
-	if (pm_power_off != NULL)
-		pm_power_off();
-	else
-		default_power_off();
+	do_kernel_power_off();
+	default_power_off();
 }
 
 void machine_power_off(void)
 {
-	if (pm_power_off != NULL)
-		pm_power_off();
-	else
-		default_power_off();
+	do_kernel_power_off();
+	default_power_off();
 }
-- 
2.33.1



From xen-devel-bounces@lists.xenproject.org Wed Oct 27 21:28:23 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Oct 2021 21:28:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217301.377383 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfqSz-0005Ma-Br; Wed, 27 Oct 2021 21:28:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217301.377383; Wed, 27 Oct 2021 21:28:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfqSy-0005If-9k; Wed, 27 Oct 2021 21:28:12 +0000
Received: by outflank-mailman (input) for mailman id 217301;
 Wed, 27 Oct 2021 21:28:09 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=nMly=PP=gmail.com=digetx@srs-us1.protection.inumbo.net>)
 id 1mfqMP-0000sJ-Dd
 for xen-devel@lists.xenproject.org; Wed, 27 Oct 2021 21:21:25 +0000
Received: from mail-lf1-x135.google.com (unknown [2a00:1450:4864:20::135])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id ed9f40e7-2116-4b6d-ad37-3eab09f39abc;
 Wed, 27 Oct 2021 21:18:58 +0000 (UTC)
Received: by mail-lf1-x135.google.com with SMTP id bp15so9015747lfb.4
 for <xen-devel@lists.xenproject.org>; Wed, 27 Oct 2021 14:18:58 -0700 (PDT)
Received: from localhost.localdomain (46-138-41-28.dynamic.spd-mgts.ru.
 [46.138.41.28])
 by smtp.gmail.com with ESMTPSA id d7sm104336ljl.18.2021.10.27.14.18.56
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Wed, 27 Oct 2021 14:18:57 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ed9f40e7-2116-4b6d-ad37-3eab09f39abc
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=/Hqy/1scbv2xgSJ+Pfjnwd9vR5EU0n/d3WfB2tugTgE=;
        b=fdXEajT5ReWU0k76RL+UMQexWX6+dI9dqZX5MdJXsVZcuokskYVO71+oKjzDY4A2wc
         hJ1YtaH4eNeZaWabxSPD6IdHvppV9tDUjSfbiCZ9pzJbnyd1ILGvgPlaBo02Y2jjZnzD
         JbO/7oiPSFxLAQwFLHGGO2Gfwy8dZZlQdidry7vBInQu2wS67Np/bBN1rUC/SIaULQAp
         mZSgP8kJbrDoclvDh2sRCaJ+wiPArCAPZMKwm6/7+fwfn1T4SmuQIaJDkhw4NUU2izwl
         4ikxIWp8MhgEKidppyJcozjOV5jYdL31Pn9EYMxWJrcs7VGZ0QCvDnuFIw51Kr2focF2
         kW1g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=/Hqy/1scbv2xgSJ+Pfjnwd9vR5EU0n/d3WfB2tugTgE=;
        b=I5kACTmRG3JXiYMQEH1UugQcBwvTXlF1XclwGQBRTjvuJaE0IxJJwOWY/DxLZCTp9L
         +JFN6Y64/SnZohMczrBKTUbhipu/mO8zH13VmfBpVU9M9yEvMYEnKHKE5BMSeLC+Bc9P
         d5aQPCM93zwqCgRAR9rfKSRn/YWKAolcBCOtz4XZ6P0HQinSGybdt3mW1qIoaTjabBv8
         oHREsBzclOFRJGvczhT1yK6Fd/8YpHK+BEuH1dNIRAvKVOLkK/uQXEGoU5eyyZCiQRGe
         J72MoujsJVmYKq45CRzfJo2LukPQYj3Ki8AN72lDhFRTVlSIJ6SquICz9I/K+tZzqERA
         gnFw==
X-Gm-Message-State: AOAM5330ZC1+DL/qhfcxPA91rYSj0jeo7o3+ZhzlY0Cjlf2JudUXDye2
	laUjQDMBgyLf4MFUgGJrcMQ=
X-Google-Smtp-Source: ABdhPJxErOfbgWaHoJDyROU+wtxCyzAJwEEk/21TSkl3Wl7+6OTCwc5MbFi2KTtZM0ExVMRMX2XJDw==
X-Received: by 2002:a05:6512:344a:: with SMTP id j10mr78084lfr.653.1635369538003;
        Wed, 27 Oct 2021 14:18:58 -0700 (PDT)
From: Dmitry Osipenko <digetx@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Lee Jones <lee.jones@linaro.org>,
	"Rafael J . Wysocki" <rafael@kernel.org>,
	Mark Brown <broonie@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Russell King <linux@armlinux.org.uk>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Ulf Hansson <ulf.hansson@linaro.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Guo Ren <guoren@kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Greg Ungerer <gerg@linux-m68k.org>,
	Joshua Thompson <funaho@jurai.org>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Nick Hu <nickhu@andestech.com>,
	Greentime Hu <green.hu@gmail.com>,
	Vincent Chen <deanbo422@gmail.com>,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	Helge Deller <deller@gmx.de>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Rich Felker <dalias@libc.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Len Brown <lenb@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Chen-Yu Tsai <wens@csie.org>,
	=?UTF-8?q?Jonathan=20Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>,
	Tony Lindgren <tony@atomide.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Vladimir Zapolskiy <vz@mleia.com>,
	Avi Fishman <avifishman70@gmail.com>,
	Tomer Maimon <tmaimon77@gmail.com>,
	Tali Perry <tali.perry1@gmail.com>,
	Patrick Venture <venture@google.com>,
	Nancy Yuen <yuenn@google.com>,
	Benjamin Fair <benjaminfair@google.com>,
	Pavel Machek <pavel@ucw.cz>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	linux-csky@vger.kernel.org,
	linux-ia64@vger.kernel.org,
	linux-m68k@lists.linux-m68k.org,
	linux-mips@vger.kernel.org,
	linux-parisc@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-riscv@lists.infradead.org,
	linux-sh@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	linux-acpi@vger.kernel.org,
	linux-omap@vger.kernel.org,
	openbmc@lists.ozlabs.org,
	linux-tegra@vger.kernel.org,
	linux-pm@vger.kernel.org
Subject: [PATCH v2 35/45] mfd: max8907: Use devm_register_simple_power_off_handler()
Date: Thu, 28 Oct 2021 00:17:05 +0300
Message-Id: <20211027211715.12671-36-digetx@gmail.com>
X-Mailer: git-send-email 2.33.1
In-Reply-To: <20211027211715.12671-1-digetx@gmail.com>
References: <20211027211715.12671-1-digetx@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Use devm_register_simple_power_off_handler() that replaces global
pm_power_off variable and allows to register multiple power-off handlers.

Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
 drivers/mfd/max8907.c | 22 +++++++++++++++-------
 1 file changed, 15 insertions(+), 7 deletions(-)

diff --git a/drivers/mfd/max8907.c b/drivers/mfd/max8907.c
index 41f566e6a096..58699510311b 100644
--- a/drivers/mfd/max8907.c
+++ b/drivers/mfd/max8907.c
@@ -16,6 +16,7 @@
 #include <linux/module.h>
 #include <linux/of.h>
 #include <linux/of_device.h>
+#include <linux/reboot.h>
 #include <linux/regmap.h>
 #include <linux/slab.h>
 
@@ -174,9 +175,10 @@ static const struct regmap_irq_chip max8907_rtc_irq_chip = {
 	.num_irqs = ARRAY_SIZE(max8907_rtc_irqs),
 };
 
-static struct max8907 *max8907_pm_off;
-static void max8907_power_off(void)
+static void max8907_power_off(void *data)
 {
+	struct max8907 *max8907_pm_off = data;
+
 	regmap_update_bits(max8907_pm_off->regmap_gen, MAX8907_REG_RESET_CNFG,
 			MAX8907_MASK_POWER_OFF, MAX8907_MASK_POWER_OFF);
 }
@@ -214,6 +216,17 @@ static int max8907_i2c_probe(struct i2c_client *i2c,
 		goto err_regmap_gen;
 	}
 
+	if (pm_off) {
+		ret = devm_register_simple_power_off_handler(&i2c->dev,
+							     max8907_power_off,
+							     max8907);
+		if (ret) {
+			dev_err(&i2c->dev,
+				"failed to register power-off handler: %d\n", ret);
+			return ret;
+		}
+	}
+
 	max8907->i2c_rtc = i2c_new_dummy_device(i2c->adapter, MAX8907_RTC_I2C_ADDR);
 	if (IS_ERR(max8907->i2c_rtc)) {
 		ret = PTR_ERR(max8907->i2c_rtc);
@@ -260,11 +273,6 @@ static int max8907_i2c_probe(struct i2c_client *i2c,
 		goto err_add_devices;
 	}
 
-	if (pm_off && !pm_power_off) {
-		max8907_pm_off = max8907;
-		pm_power_off = max8907_power_off;
-	}
-
 	return 0;
 
 err_add_devices:
-- 
2.33.1



From xen-devel-bounces@lists.xenproject.org Wed Oct 27 21:28:26 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Oct 2021 21:28:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217311.377395 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfqT2-00066Y-5v; Wed, 27 Oct 2021 21:28:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217311.377395; Wed, 27 Oct 2021 21:28:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfqT1-00062N-Cu; Wed, 27 Oct 2021 21:28:15 +0000
Received: by outflank-mailman (input) for mailman id 217311;
 Wed, 27 Oct 2021 21:28:13 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=nMly=PP=gmail.com=digetx@srs-us1.protection.inumbo.net>)
 id 1mfqM0-0000sJ-D6
 for xen-devel@lists.xenproject.org; Wed, 27 Oct 2021 21:21:00 +0000
Received: from mail-lf1-x12e.google.com (unknown [2a00:1450:4864:20::12e])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 9672a8f3-3b40-45f5-bd54-2ef11c63971a;
 Wed, 27 Oct 2021 21:18:53 +0000 (UTC)
Received: by mail-lf1-x12e.google.com with SMTP id bq11so8957029lfb.10
 for <xen-devel@lists.xenproject.org>; Wed, 27 Oct 2021 14:18:53 -0700 (PDT)
Received: from localhost.localdomain (46-138-41-28.dynamic.spd-mgts.ru.
 [46.138.41.28])
 by smtp.gmail.com with ESMTPSA id d7sm104336ljl.18.2021.10.27.14.18.50
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Wed, 27 Oct 2021 14:18:52 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9672a8f3-3b40-45f5-bd54-2ef11c63971a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=3tizDJEeWC2iLbZdJm6My4oRtC+CKaYmiKRSIM6veO0=;
        b=P2SMTBdUazDV2Wnt33aO9FM2Ioz84SezmWonZoC9di4gBNxmpSDTZT6tEbAs+vJh3H
         Fl3mZiziafsNnSwbT1iMyr0r9bKbxSiHP3xJiOBIo4ewxSS3FiLigSFoEgJOcOsMECFU
         Ealy6ndYpUfciCkbDSvwvbDJBaKQyOcr0jiZpeL2e0iKkV4AQLDVCHRPOCPCDpkazzgq
         BERHUZw176GWVNNNOqpmpYaLAn7f4joDeIeKRo11vDGHWht2ujkzv0CrGvSNdzJe9tR3
         GFiFAzCfeg61A5JBu27BdMdrz99RW2oVhEudj/a2XZux9KH22qJjawF87cCiFM6fKipn
         F+kg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=3tizDJEeWC2iLbZdJm6My4oRtC+CKaYmiKRSIM6veO0=;
        b=WKuF3f5jMtIPIfAp9WX/XWuZm0OkzVRuQ8n1SSOmvmAYeqHB8/JVNlgutqTd7ao/I/
         4sLUvoS8w+lUoXpHkxG4Km/HbvH2AYth1+56pNotULysNpLyFJMblvJjt9o148NCRFY3
         jh2rh7iLolIwrxXjQEgDgTUgZKu/0XzQ3h0f5bD2Nm1hOJMu8GDzbx+T5qx2s0cJ71I+
         jDRTZQ2bEqrbchtaSwBuGxqFymxnuuEFz3egntDoXUyAco0BAk4VIvt6z4PzIugTJSde
         LmmV62eUjqGp27fMVlGPjJ0o/+Kow+WlYMx/f3zSmjAXfBuO7q+22MM2FAT84BaorbK2
         JFoA==
X-Gm-Message-State: AOAM532rBXGmjDWEC0Jx6V9lAx3yhBc7WLLK2Nl1UFLIVJ0YrQD9X+ak
	zAQFJA6Ii4n6j21/IFoiNIo=
X-Google-Smtp-Source: ABdhPJw7dGE4iKe+cyeyTSJFUn+l5q/Abxrr3B6KYrOVBl1p66aP04j6vH2fcBbUhHRs8nFJgDlWqw==
X-Received: by 2002:a05:6512:1095:: with SMTP id j21mr134174lfg.274.1635369532441;
        Wed, 27 Oct 2021 14:18:52 -0700 (PDT)
From: Dmitry Osipenko <digetx@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Lee Jones <lee.jones@linaro.org>,
	"Rafael J . Wysocki" <rafael@kernel.org>,
	Mark Brown <broonie@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Russell King <linux@armlinux.org.uk>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Ulf Hansson <ulf.hansson@linaro.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Guo Ren <guoren@kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Greg Ungerer <gerg@linux-m68k.org>,
	Joshua Thompson <funaho@jurai.org>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Nick Hu <nickhu@andestech.com>,
	Greentime Hu <green.hu@gmail.com>,
	Vincent Chen <deanbo422@gmail.com>,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	Helge Deller <deller@gmx.de>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Rich Felker <dalias@libc.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Len Brown <lenb@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Chen-Yu Tsai <wens@csie.org>,
	=?UTF-8?q?Jonathan=20Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>,
	Tony Lindgren <tony@atomide.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Vladimir Zapolskiy <vz@mleia.com>,
	Avi Fishman <avifishman70@gmail.com>,
	Tomer Maimon <tmaimon77@gmail.com>,
	Tali Perry <tali.perry1@gmail.com>,
	Patrick Venture <venture@google.com>,
	Nancy Yuen <yuenn@google.com>,
	Benjamin Fair <benjaminfair@google.com>,
	Pavel Machek <pavel@ucw.cz>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	linux-csky@vger.kernel.org,
	linux-ia64@vger.kernel.org,
	linux-m68k@lists.linux-m68k.org,
	linux-mips@vger.kernel.org,
	linux-parisc@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-riscv@lists.infradead.org,
	linux-sh@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	linux-acpi@vger.kernel.org,
	linux-omap@vger.kernel.org,
	openbmc@lists.ozlabs.org,
	linux-tegra@vger.kernel.org,
	linux-pm@vger.kernel.org
Subject: [PATCH v2 32/45] mfd: retu: Use devm_register_simple_power_off_handler()
Date: Thu, 28 Oct 2021 00:17:02 +0300
Message-Id: <20211027211715.12671-33-digetx@gmail.com>
X-Mailer: git-send-email 2.33.1
In-Reply-To: <20211027211715.12671-1-digetx@gmail.com>
References: <20211027211715.12671-1-digetx@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Use devm_register_simple_power_off_handler() that replaces global
pm_power_off variable and allows to register multiple power-off handlers.

Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
 drivers/mfd/retu-mfd.c | 31 ++++++++++++++++---------------
 1 file changed, 16 insertions(+), 15 deletions(-)

diff --git a/drivers/mfd/retu-mfd.c b/drivers/mfd/retu-mfd.c
index c748fd29a220..d18f05c1f095 100644
--- a/drivers/mfd/retu-mfd.c
+++ b/drivers/mfd/retu-mfd.c
@@ -22,6 +22,7 @@
 #include <linux/slab.h>
 #include <linux/mutex.h>
 #include <linux/module.h>
+#include <linux/reboot.h>
 #include <linux/regmap.h>
 #include <linux/mfd/core.h>
 #include <linux/mfd/retu.h>
@@ -81,9 +82,6 @@ static struct regmap_irq_chip retu_irq_chip = {
 	.ack_base	= RETU_REG_IDR,
 };
 
-/* Retu device registered for the power off. */
-static struct retu_dev *retu_pm_power_off;
-
 static const struct resource tahvo_usb_res[] = {
 	{
 		.name	= "tahvo-usb",
@@ -165,12 +163,12 @@ int retu_write(struct retu_dev *rdev, u8 reg, u16 data)
 }
 EXPORT_SYMBOL_GPL(retu_write);
 
-static void retu_power_off(void)
+static void retu_power_off(void *data)
 {
-	struct retu_dev *rdev = retu_pm_power_off;
+	struct retu_dev *rdev = data;
 	int reg;
 
-	mutex_lock(&retu_pm_power_off->mutex);
+	mutex_lock(&rdev->mutex);
 
 	/* Ignore power button state */
 	regmap_read(rdev->regmap, RETU_REG_CC1, &reg);
@@ -183,7 +181,7 @@ static void retu_power_off(void)
 	for (;;)
 		cpu_relax();
 
-	mutex_unlock(&retu_pm_power_off->mutex);
+	mutex_unlock(&rdev->mutex);
 }
 
 static int retu_regmap_read(void *context, const void *reg, size_t reg_size,
@@ -261,6 +259,17 @@ static int retu_probe(struct i2c_client *i2c, const struct i2c_device_id *id)
 		 (ret & RETU_REG_ASICR_VILMA) ? rdat->companion_name : "",
 		 (ret >> 4) & 0x7, ret & 0xf);
 
+	if (i2c->addr == 1) {
+		ret = devm_register_simple_power_off_handler(&i2c->dev,
+							     retu_power_off,
+							     rdev);
+		if (ret) {
+			dev_err(rdev->dev,
+				"could not register power-off handler: %d\n", ret);
+			return ret;
+		}
+	}
+
 	/* Mask all interrupts. */
 	ret = retu_write(rdev, rdat->irq_chip->mask_base, 0xffff);
 	if (ret < 0)
@@ -279,10 +288,6 @@ static int retu_probe(struct i2c_client *i2c, const struct i2c_device_id *id)
 		return ret;
 	}
 
-	if (i2c->addr == 1 && !pm_power_off) {
-		retu_pm_power_off = rdev;
-		pm_power_off	  = retu_power_off;
-	}
 
 	return 0;
 }
@@ -291,10 +296,6 @@ static int retu_remove(struct i2c_client *i2c)
 {
 	struct retu_dev *rdev = i2c_get_clientdata(i2c);
 
-	if (retu_pm_power_off == rdev) {
-		pm_power_off	  = NULL;
-		retu_pm_power_off = NULL;
-	}
 	mfd_remove_devices(rdev->dev);
 	regmap_del_irq_chip(i2c->irq, rdev->irq_data);
 
-- 
2.33.1



From xen-devel-bounces@lists.xenproject.org Wed Oct 27 21:28:37 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Oct 2021 21:28:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217337.377414 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfqTD-0007zc-Gq; Wed, 27 Oct 2021 21:28:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217337.377414; Wed, 27 Oct 2021 21:28:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfqTD-0007zK-Bm; Wed, 27 Oct 2021 21:28:27 +0000
Received: by outflank-mailman (input) for mailman id 217337;
 Wed, 27 Oct 2021 21:28:26 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=nMly=PP=gmail.com=digetx@srs-us1.protection.inumbo.net>)
 id 1mfqNI-0000sJ-F3
 for xen-devel@lists.xenproject.org; Wed, 27 Oct 2021 21:22:20 +0000
Received: from mail-lj1-x232.google.com (unknown [2a00:1450:4864:20::232])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 3fd14165-1c51-4e97-b6e8-86c09a0d6493;
 Wed, 27 Oct 2021 21:19:06 +0000 (UTC)
Received: by mail-lj1-x232.google.com with SMTP id q16so7020585ljg.3
 for <xen-devel@lists.xenproject.org>; Wed, 27 Oct 2021 14:19:06 -0700 (PDT)
Received: from localhost.localdomain (46-138-41-28.dynamic.spd-mgts.ru.
 [46.138.41.28])
 by smtp.gmail.com with ESMTPSA id d7sm104336ljl.18.2021.10.27.14.19.03
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Wed, 27 Oct 2021 14:19:05 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3fd14165-1c51-4e97-b6e8-86c09a0d6493
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=3OlHSqJ+90NzTUoF0ScIJd6Gu2h2samNuNJcsiL1Jk8=;
        b=TlGsLZtcrVzUb7sAOhif3p7pVw8LafC2xLy1EDPy1NIwJl5MQQvmHy2JQZYszcOE8Z
         bpdCDmyEM5D03Couzbs3VVZUIdamWSCPF0yzl5vvizBqtDssLI1790jRM+TPIcawNrlD
         8STEeq0OEOHvy2rX7OXiOWUq9V+Wbq3xZg3vhjF/dealnvdRkEuGDx5b0mmtoBXsa4Tg
         7gFUHQvvLRw3QjAUV5dCuqij4emeiEy4r7tFICkEZrQaaXXABdfN2M8h/mxrxQbImqYG
         GaGzMOCXHjG+QuAc4Dq0gK0PotuHucIYhVqvi35iVuJc+hGZhg1h00rdw0kra8k/EpLO
         luJw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=3OlHSqJ+90NzTUoF0ScIJd6Gu2h2samNuNJcsiL1Jk8=;
        b=BN39/gDvZoVTgRGs+6aS1GMtwC3mp+mHjKiuRx0k01hIFramQi8QPCaokCyA+gk8D3
         8p0O873nUDe6e60YTN4GO08B3izGzxbSbivg5p7TqUU5MCG1E0FNVJxY2E0PZd0O2CND
         bCILcLm4o72t8GnE+BsAjr1Oewzm/msueKLh2A4oQX4KnCSslYwyduGHJsqvBx6WZdAi
         dD/u7EWuSJDZNlnpwkns+YGcuNT3CasS2um8Z42A45RjQXXryR1NnPKaw5zWCUdI5AMW
         Wwv0BVwh4o7s0HLnDI+ZjGZDobN0SikzfOUaVIlX/GMGILB2koBfnkcT605E5bmHu4bK
         w88g==
X-Gm-Message-State: AOAM531NpLun6zaWfxagMpY5KG9iXCQr7gfeenakzmKV6mK20aFmRJat
	yP4mNPwMpMCZlPb4bdRnM2M=
X-Google-Smtp-Source: ABdhPJzDbMhKltt/cJ4cLHVC7lvSJKFFWBp4i2pL/KBXA4D8sI4Ihh3wNKVdm9xKvnEcHeY8d+ELCw==
X-Received: by 2002:a2e:b0e2:: with SMTP id h2mr336408ljl.522.1635369545290;
        Wed, 27 Oct 2021 14:19:05 -0700 (PDT)
From: Dmitry Osipenko <digetx@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Lee Jones <lee.jones@linaro.org>,
	"Rafael J . Wysocki" <rafael@kernel.org>,
	Mark Brown <broonie@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Russell King <linux@armlinux.org.uk>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Ulf Hansson <ulf.hansson@linaro.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Guo Ren <guoren@kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Greg Ungerer <gerg@linux-m68k.org>,
	Joshua Thompson <funaho@jurai.org>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Nick Hu <nickhu@andestech.com>,
	Greentime Hu <green.hu@gmail.com>,
	Vincent Chen <deanbo422@gmail.com>,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	Helge Deller <deller@gmx.de>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Rich Felker <dalias@libc.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Len Brown <lenb@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Chen-Yu Tsai <wens@csie.org>,
	=?UTF-8?q?Jonathan=20Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>,
	Tony Lindgren <tony@atomide.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Vladimir Zapolskiy <vz@mleia.com>,
	Avi Fishman <avifishman70@gmail.com>,
	Tomer Maimon <tmaimon77@gmail.com>,
	Tali Perry <tali.perry1@gmail.com>,
	Patrick Venture <venture@google.com>,
	Nancy Yuen <yuenn@google.com>,
	Benjamin Fair <benjaminfair@google.com>,
	Pavel Machek <pavel@ucw.cz>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	linux-csky@vger.kernel.org,
	linux-ia64@vger.kernel.org,
	linux-m68k@lists.linux-m68k.org,
	linux-mips@vger.kernel.org,
	linux-parisc@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-riscv@lists.infradead.org,
	linux-sh@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	linux-acpi@vger.kernel.org,
	linux-omap@vger.kernel.org,
	openbmc@lists.ozlabs.org,
	linux-tegra@vger.kernel.org,
	linux-pm@vger.kernel.org
Subject: [PATCH v2 39/45] mfd: dm355evm_msp: Use devm_register_trivial_power_off_handler()
Date: Thu, 28 Oct 2021 00:17:09 +0300
Message-Id: <20211027211715.12671-40-digetx@gmail.com>
X-Mailer: git-send-email 2.33.1
In-Reply-To: <20211027211715.12671-1-digetx@gmail.com>
References: <20211027211715.12671-1-digetx@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Use devm_register_trivial_power_off_handler() that replaces global
pm_power_off variable and allows to register multiple power-off handlers.

Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
 drivers/mfd/dm355evm_msp.c | 20 +++++++++++++-------
 1 file changed, 13 insertions(+), 7 deletions(-)

diff --git a/drivers/mfd/dm355evm_msp.c b/drivers/mfd/dm355evm_msp.c
index 54fb6cbd2aa0..5ee830f65589 100644
--- a/drivers/mfd/dm355evm_msp.c
+++ b/drivers/mfd/dm355evm_msp.c
@@ -8,6 +8,7 @@
 #include <linux/init.h>
 #include <linux/mutex.h>
 #include <linux/platform_device.h>
+#include <linux/reboot.h>
 #include <linux/clk.h>
 #include <linux/module.h>
 #include <linux/err.h>
@@ -375,11 +376,10 @@ static void dm355evm_power_off(void)
 	dm355evm_command(MSP_COMMAND_POWEROFF);
 }
 
-static int dm355evm_msp_remove(struct i2c_client *client)
+static void dm355evm_msp_remove(void *data)
 {
-	pm_power_off = NULL;
+	/* FIXME remove children ... */
 	msp430 = NULL;
-	return 0;
 }
 
 static int
@@ -392,6 +392,11 @@ dm355evm_msp_probe(struct i2c_client *client, const struct i2c_device_id *id)
 		return -EBUSY;
 	msp430 = client;
 
+	status = devm_add_action_or_reset(&client->dev, dm355evm_msp_remove,
+					  NULL);
+	if (status < 0)
+		goto fail;
+
 	/* display revision status; doubles as sanity check */
 	status = dm355evm_msp_read(DM355EVM_MSP_FIRMREV);
 	if (status < 0)
@@ -416,13 +421,15 @@ dm355evm_msp_probe(struct i2c_client *client, const struct i2c_device_id *id)
 		goto fail;
 
 	/* PM hookup */
-	pm_power_off = dm355evm_power_off;
+	status = devm_register_trivial_power_off_handler(&client->dev,
+							 dm355evm_power_off);
+	if (status)
+		dev_err(&client->dev, "failed to register power-off handler: %d",
+			status);
 
 	return 0;
 
 fail:
-	/* FIXME remove children ... */
-	dm355evm_msp_remove(client);
 	return status;
 }
 
@@ -436,7 +443,6 @@ static struct i2c_driver dm355evm_msp_driver = {
 	.driver.name	= "dm355evm_msp",
 	.id_table	= dm355evm_msp_ids,
 	.probe		= dm355evm_msp_probe,
-	.remove		= dm355evm_msp_remove,
 };
 
 static int __init dm355evm_msp_init(void)
-- 
2.33.1



From xen-devel-bounces@lists.xenproject.org Wed Oct 27 21:28:41 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Oct 2021 21:28:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217340.377425 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfqTG-0000BF-WA; Wed, 27 Oct 2021 21:28:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217340.377425; Wed, 27 Oct 2021 21:28:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfqTG-00008j-RD; Wed, 27 Oct 2021 21:28:30 +0000
Received: by outflank-mailman (input) for mailman id 217340;
 Wed, 27 Oct 2021 21:28:29 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=nMly=PP=gmail.com=digetx@srs-us1.protection.inumbo.net>)
 id 1mfqLl-0000sJ-Ct
 for xen-devel@lists.xenproject.org; Wed, 27 Oct 2021 21:20:45 +0000
Received: from mail-lf1-x12e.google.com (unknown [2a00:1450:4864:20::12e])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 649940cd-d36d-4ca6-8e33-520c1685eb77;
 Wed, 27 Oct 2021 21:18:47 +0000 (UTC)
Received: by mail-lf1-x12e.google.com with SMTP id j9so8979909lfu.7
 for <xen-devel@lists.xenproject.org>; Wed, 27 Oct 2021 14:18:47 -0700 (PDT)
Received: from localhost.localdomain (46-138-41-28.dynamic.spd-mgts.ru.
 [46.138.41.28])
 by smtp.gmail.com with ESMTPSA id d7sm104336ljl.18.2021.10.27.14.18.45
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Wed, 27 Oct 2021 14:18:46 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 649940cd-d36d-4ca6-8e33-520c1685eb77
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=VpMTaQaJ0cjNLgvNqh3di7liIGTew7KcJqDZRitT+Gs=;
        b=IWwdEP2zbLaLlU4mCU5s8PpqrkaIWlck+oA3xnCuAzsOirLY91m5COquObIzRO/SOa
         ZZIFcDLGTP22p0/7Hcw3xr55ftJZWhQ4nU6sBNGCfWjV2gTeJrHUPc9jLo/fr5xO0l0l
         0SNS1n6R63fMlbNJFT3gbKkQCc0Ia7/EAvKfYLtASP95KzfXrWNNTSb1yRqxn8x5d6xD
         hciHreIyBYgx6dcdUlzTSBb07ys9RFpq3Y5/l5Vd2vvkqxnAXOO/WD9ek4xsO4aDTsfM
         H41ne9Olkj2NqvJkNPysdfnoteByPeCFY3T52VBJFYJ9FKDG6+cEspYVw2UY7y4ppIDD
         pOHg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=VpMTaQaJ0cjNLgvNqh3di7liIGTew7KcJqDZRitT+Gs=;
        b=RqdCZsuPuXVDshcCV9ZuWRS9ycon7W4A1fnVSfv83Ql2mcWskO7RRnPBBEJ/1ty5l7
         bbFZKSxerXH6O0qcjyAcsFHQbHMdQ2XlhnyrEz0LYrpmYjg1q487EQsdId+xzbwC6adM
         jmhZz2SU9sNREpawQUSvRq8qt02oO3WjFnXMkRWoyOj1MAUOk8hmJ6EkoeFswypVotXk
         EUuVX9fcrYy8W/I24BXkCRIxztlHizUnrr1kgD6Jq5B3aa1RjYr6lhhjl4b81ox5erUF
         JZHI9fp6OxrGjOI/fztNxoWq9mSHQJUIXblQGMaYtvdS1QhKGECXNlXCwPPhvGmJgBpj
         4X/Q==
X-Gm-Message-State: AOAM532JcXTqEu0wFc0NjYli1BbzC1Tj47kksX2nTQg5T/uvklp8ra86
	oP3te+1I09knbtGaJPEFOPY=
X-Google-Smtp-Source: ABdhPJys0u/+wFsWDr/9j4b/C5x8WEos0EuABuOI0MYqETh3mbRQO/mjL91g1gnGx/4TO6/Fje2n8g==
X-Received: by 2002:ac2:4c9a:: with SMTP id d26mr128014lfl.344.1635369526848;
        Wed, 27 Oct 2021 14:18:46 -0700 (PDT)
From: Dmitry Osipenko <digetx@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Lee Jones <lee.jones@linaro.org>,
	"Rafael J . Wysocki" <rafael@kernel.org>,
	Mark Brown <broonie@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Russell King <linux@armlinux.org.uk>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Ulf Hansson <ulf.hansson@linaro.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Guo Ren <guoren@kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Greg Ungerer <gerg@linux-m68k.org>,
	Joshua Thompson <funaho@jurai.org>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Nick Hu <nickhu@andestech.com>,
	Greentime Hu <green.hu@gmail.com>,
	Vincent Chen <deanbo422@gmail.com>,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	Helge Deller <deller@gmx.de>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Rich Felker <dalias@libc.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Len Brown <lenb@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Chen-Yu Tsai <wens@csie.org>,
	=?UTF-8?q?Jonathan=20Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>,
	Tony Lindgren <tony@atomide.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Vladimir Zapolskiy <vz@mleia.com>,
	Avi Fishman <avifishman70@gmail.com>,
	Tomer Maimon <tmaimon77@gmail.com>,
	Tali Perry <tali.perry1@gmail.com>,
	Patrick Venture <venture@google.com>,
	Nancy Yuen <yuenn@google.com>,
	Benjamin Fair <benjaminfair@google.com>,
	Pavel Machek <pavel@ucw.cz>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	linux-csky@vger.kernel.org,
	linux-ia64@vger.kernel.org,
	linux-m68k@lists.linux-m68k.org,
	linux-mips@vger.kernel.org,
	linux-parisc@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-riscv@lists.infradead.org,
	linux-sh@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	linux-acpi@vger.kernel.org,
	linux-omap@vger.kernel.org,
	openbmc@lists.ozlabs.org,
	linux-tegra@vger.kernel.org,
	linux-pm@vger.kernel.org
Subject: [PATCH v2 29/45] mfd: acer-a500: Use devm_register_power_handler()
Date: Thu, 28 Oct 2021 00:16:59 +0300
Message-Id: <20211027211715.12671-30-digetx@gmail.com>
X-Mailer: git-send-email 2.33.1
In-Reply-To: <20211027211715.12671-1-digetx@gmail.com>
References: <20211027211715.12671-1-digetx@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Use devm_register_power_handler() that replaces global pm_power_off
variable and allows to register multiple power-off handlers. It also
provides restart-handler support, i.e. all in one API.

Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
 drivers/mfd/acer-ec-a500.c | 52 ++++++++++++++------------------------
 1 file changed, 19 insertions(+), 33 deletions(-)

diff --git a/drivers/mfd/acer-ec-a500.c b/drivers/mfd/acer-ec-a500.c
index 80c2fdd14fc4..fc864abc0049 100644
--- a/drivers/mfd/acer-ec-a500.c
+++ b/drivers/mfd/acer-ec-a500.c
@@ -31,8 +31,6 @@ enum {
 	REG_COLD_REBOOT = 0x55,
 };
 
-static struct i2c_client *a500_ec_client_pm_off;
-
 static int a500_ec_read(void *context, const void *reg_buf, size_t reg_size,
 			void *val_buf, size_t val_sizel)
 {
@@ -104,32 +102,35 @@ static const struct regmap_bus a500_ec_regmap_bus = {
 	.max_raw_read = 2,
 };
 
-static void a500_ec_poweroff(void)
+static void a500_ec_power_off_handler(struct power_off_data *data)
 {
-	i2c_smbus_write_word_data(a500_ec_client_pm_off,
-				  REG_SHUTDOWN, CMD_SHUTDOWN);
+	struct i2c_client *client = data->cb_data;
+
+	i2c_smbus_write_word_data(client, REG_SHUTDOWN, CMD_SHUTDOWN);
 
 	mdelay(A500_EC_POWER_CMD_TIMEOUT);
 }
 
-static int a500_ec_restart_notify(struct notifier_block *this,
-				  unsigned long reboot_mode, void *data)
+static void a500_ec_restart_handler(struct restart_data *data)
 {
-	if (reboot_mode == REBOOT_WARM)
-		i2c_smbus_write_word_data(a500_ec_client_pm_off,
+	struct i2c_client *client = data->cb_data;
+
+	if (data->mode == REBOOT_WARM)
+		i2c_smbus_write_word_data(client,
 					  REG_WARM_REBOOT, CMD_WARM_REBOOT);
 	else
-		i2c_smbus_write_word_data(a500_ec_client_pm_off,
+		i2c_smbus_write_word_data(client,
 					  REG_COLD_REBOOT, CMD_COLD_REBOOT);
 
 	mdelay(A500_EC_POWER_CMD_TIMEOUT);
-
-	return NOTIFY_DONE;
 }
 
-static struct notifier_block a500_ec_restart_handler = {
-	.notifier_call = a500_ec_restart_notify,
-	.priority = 200,
+static struct power_handler a500_ec_power_handler = {
+	.restart_cb = a500_ec_restart_handler,
+	.restart_priority = RESTART_PRIO_HIGH,
+
+	.power_off_cb = a500_ec_power_off_handler,
+	.power_off_priority = POWEROFF_PRIO_HIGH,
 };
 
 static const struct mfd_cell a500_ec_cells[] = {
@@ -156,26 +157,12 @@ static int a500_ec_probe(struct i2c_client *client)
 	}
 
 	if (of_device_is_system_power_controller(client->dev.of_node)) {
-		a500_ec_client_pm_off = client;
+		a500_ec_power_handler.cb_data = client;
 
-		err = register_restart_handler(&a500_ec_restart_handler);
+		err = devm_register_power_handler(&client->dev,
+						  &a500_ec_power_handler);
 		if (err)
 			return err;
-
-		if (!pm_power_off)
-			pm_power_off = a500_ec_poweroff;
-	}
-
-	return 0;
-}
-
-static int a500_ec_remove(struct i2c_client *client)
-{
-	if (of_device_is_system_power_controller(client->dev.of_node)) {
-		if (pm_power_off == a500_ec_poweroff)
-			pm_power_off = NULL;
-
-		unregister_restart_handler(&a500_ec_restart_handler);
 	}
 
 	return 0;
@@ -193,7 +180,6 @@ static struct i2c_driver a500_ec_driver = {
 		.of_match_table = a500_ec_match,
 	},
 	.probe_new = a500_ec_probe,
-	.remove = a500_ec_remove,
 };
 module_i2c_driver(a500_ec_driver);
 
-- 
2.33.1



From xen-devel-bounces@lists.xenproject.org Wed Oct 27 21:28:41 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Oct 2021 21:28:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217342.377429 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfqTH-0000Fg-FL; Wed, 27 Oct 2021 21:28:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217342.377429; Wed, 27 Oct 2021 21:28:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfqTH-0000Em-8C; Wed, 27 Oct 2021 21:28:31 +0000
Received: by outflank-mailman (input) for mailman id 217342;
 Wed, 27 Oct 2021 21:28:29 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=nMly=PP=gmail.com=digetx@srs-us1.protection.inumbo.net>)
 id 1mfqKY-0000sJ-AS
 for xen-devel@lists.xenproject.org; Wed, 27 Oct 2021 21:19:30 +0000
Received: from mail-lf1-x12b.google.com (unknown [2a00:1450:4864:20::12b])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 9f389b0c-6a35-4f94-9ef8-4b8e581c515e;
 Wed, 27 Oct 2021 21:18:29 +0000 (UTC)
Received: by mail-lf1-x12b.google.com with SMTP id u21so8956897lff.8
 for <xen-devel@lists.xenproject.org>; Wed, 27 Oct 2021 14:18:29 -0700 (PDT)
Received: from localhost.localdomain (46-138-41-28.dynamic.spd-mgts.ru.
 [46.138.41.28])
 by smtp.gmail.com with ESMTPSA id d7sm104336ljl.18.2021.10.27.14.18.26
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Wed, 27 Oct 2021 14:18:28 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9f389b0c-6a35-4f94-9ef8-4b8e581c515e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=032w538UVpeATjNmIAIpxMVbSRQ+KkFSikcjH52Go7E=;
        b=i8kSi+aWSekhMHl+RIohvB2J9+GhXDqC8y87gHZKIo3HgrCgrxAFgJBJNd643IAUw8
         g9MSIRkc2bpIwozO+KBB9OaCJ9xgY87SwdOaEqBvwzFZ8T3iGC1OLWPTCXnsFCHj5/5U
         sps32PSa8KExjTmWa9ZRL9t+O9qr0b8kzTl0fgjkERRFIi+xDfIxjTflHCHCDk5rZ0mt
         zfhXGA8+rDpphj6+WcqiIpDWahpS8la7wRdBB0/XTYtTbOXFjjBe+uIATNvGTQr/gKbD
         b/xTsJZdL1e/rQ412ul4+9vATu7deYBtZoT3x3kO5sbA1sdcdzRIoZ4KvX2dngppNAWQ
         v1fA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=032w538UVpeATjNmIAIpxMVbSRQ+KkFSikcjH52Go7E=;
        b=bw3fD/MMX27aKYnvSDOUOSLRmXplsrMnpZlahUi3WGGS0jwoa55B0M1BapMn+pcDyM
         f4FJ23U90tsl7C+uEIzLp5B8bmeVU30sXo/FKon/Ycd6C2WHO57HNbmD4p3axFuKRUsI
         bjyR0Eh4aoyrULyIreR7Uz0nFwnvltN5R8k0A7aqODcm1Qou/v3MuIkgLHjR1ZJvs0hh
         j4WIjJ2dp1QGko0fH3Kng/gbbnrxY6eY+7bAae/Us4QW8dVn+6uFLi6IGY0TgZT69g1e
         AOYyDK+m0KFwhCnxxnCFxPjn5hopliaSSXwnsUfMdmFZrJA1GAPHdP6yJVxdYFAi2dCH
         Mb5A==
X-Gm-Message-State: AOAM533CiNkFN3jGqSiTv1+o2H95SBi17uQwPDb8KmVwvjXVFdPDs083
	yce+SSwUSTA6mH/BPbiH7lE=
X-Google-Smtp-Source: ABdhPJxRtK/tJ0GqKzVRuD4r9yGdXpMq7YD+HTcHjRYwt7Ifx6KwMehlmhPixjH5hNZN4Zb5ESKkAg==
X-Received: by 2002:a05:6512:1316:: with SMTP id x22mr96787lfu.291.1635369508415;
        Wed, 27 Oct 2021 14:18:28 -0700 (PDT)
From: Dmitry Osipenko <digetx@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Lee Jones <lee.jones@linaro.org>,
	"Rafael J . Wysocki" <rafael@kernel.org>,
	Mark Brown <broonie@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Russell King <linux@armlinux.org.uk>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Ulf Hansson <ulf.hansson@linaro.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Guo Ren <guoren@kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Greg Ungerer <gerg@linux-m68k.org>,
	Joshua Thompson <funaho@jurai.org>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Nick Hu <nickhu@andestech.com>,
	Greentime Hu <green.hu@gmail.com>,
	Vincent Chen <deanbo422@gmail.com>,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	Helge Deller <deller@gmx.de>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Rich Felker <dalias@libc.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Len Brown <lenb@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Chen-Yu Tsai <wens@csie.org>,
	=?UTF-8?q?Jonathan=20Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>,
	Tony Lindgren <tony@atomide.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Vladimir Zapolskiy <vz@mleia.com>,
	Avi Fishman <avifishman70@gmail.com>,
	Tomer Maimon <tmaimon77@gmail.com>,
	Tali Perry <tali.perry1@gmail.com>,
	Patrick Venture <venture@google.com>,
	Nancy Yuen <yuenn@google.com>,
	Benjamin Fair <benjaminfair@google.com>,
	Pavel Machek <pavel@ucw.cz>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	linux-csky@vger.kernel.org,
	linux-ia64@vger.kernel.org,
	linux-m68k@lists.linux-m68k.org,
	linux-mips@vger.kernel.org,
	linux-parisc@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-riscv@lists.infradead.org,
	linux-sh@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	linux-acpi@vger.kernel.org,
	linux-omap@vger.kernel.org,
	openbmc@lists.ozlabs.org,
	linux-tegra@vger.kernel.org,
	linux-pm@vger.kernel.org
Subject: [PATCH v2 19/45] sh: Use do_kernel_power_off()
Date: Thu, 28 Oct 2021 00:16:49 +0300
Message-Id: <20211027211715.12671-20-digetx@gmail.com>
X-Mailer: git-send-email 2.33.1
In-Reply-To: <20211027211715.12671-1-digetx@gmail.com>
References: <20211027211715.12671-1-digetx@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Kernel now supports chained power-off handlers. Use do_kernel_power_off()
that invokes chained power-off handlers. It also invokes legacy
pm_power_off() for now, which will be removed once all drivers will
be converted to the new power-off API.

Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
 arch/sh/kernel/reboot.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/sh/kernel/reboot.c b/arch/sh/kernel/reboot.c
index 5c33f036418b..e8eeedc9b182 100644
--- a/arch/sh/kernel/reboot.c
+++ b/arch/sh/kernel/reboot.c
@@ -46,8 +46,7 @@ static void native_machine_shutdown(void)
 
 static void native_machine_power_off(void)
 {
-	if (pm_power_off)
-		pm_power_off();
+	do_kernel_power_off();
 }
 
 static void native_machine_halt(void)
-- 
2.33.1



From xen-devel-bounces@lists.xenproject.org Wed Oct 27 21:28:44 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Oct 2021 21:28:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217347.377449 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfqTK-00010h-D1; Wed, 27 Oct 2021 21:28:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217347.377449; Wed, 27 Oct 2021 21:28:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfqTK-0000zd-04; Wed, 27 Oct 2021 21:28:34 +0000
Received: by outflank-mailman (input) for mailman id 217347;
 Wed, 27 Oct 2021 21:28:31 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=nMly=PP=gmail.com=digetx@srs-us1.protection.inumbo.net>)
 id 1mfqJu-0000sJ-9U
 for xen-devel@lists.xenproject.org; Wed, 27 Oct 2021 21:18:50 +0000
Received: from mail-lf1-x129.google.com (unknown [2a00:1450:4864:20::129])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 1cbb708e-fa5f-44cb-a7bf-37c8ad45fecb;
 Wed, 27 Oct 2021 21:18:14 +0000 (UTC)
Received: by mail-lf1-x129.google.com with SMTP id j9so8977387lfu.7
 for <xen-devel@lists.xenproject.org>; Wed, 27 Oct 2021 14:18:14 -0700 (PDT)
Received: from localhost.localdomain (46-138-41-28.dynamic.spd-mgts.ru.
 [46.138.41.28])
 by smtp.gmail.com with ESMTPSA id d7sm104336ljl.18.2021.10.27.14.18.11
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Wed, 27 Oct 2021 14:18:13 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1cbb708e-fa5f-44cb-a7bf-37c8ad45fecb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=mkT4WvxT7RtftPa0rTvgt/WDicZUVRxbWN0FWKN7Smg=;
        b=Yo8WLAj00ehYxZyZdDVWixoWYFZCxGC5pnXCEDD+Lpmu7VCTkoyMEfgBUZ5rd74829
         10cwYzMjgPMmfgRZlSo7KTAiAM4JViXknvJSGF9v6lX6GD7KJFaPvImanRJ6VVtdquR5
         UWHkY3wgAzq9P8o4pg5QZxxWrvHm8PSEPWuEh07SLsPZUVJPf1GZYbO3PdmhFgXJ+BA3
         yKffg+/c59X1/gl1a+krdkF8Zrm1ykankDPCOetkz+NKynMz9QOH9WwpSKXop30n94Hj
         u5jmdqBNWkVvyuWeZCuboMhJEA6otxFAt6GyTyoGvAX05kLjRNIXysRA8hScLTqoqleX
         /lfA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=mkT4WvxT7RtftPa0rTvgt/WDicZUVRxbWN0FWKN7Smg=;
        b=0Jw+nd7IidZADIwIV+ErH9Rnd1i4QILDUDuz7LNKXf6z8kxBU4HYKJrlD4h1HONk/m
         idUBXpaXrJaoJtPNFjgxaAF7KK87j5JukYbhnbACIao/su+b6Jiuc+OLpyViv03PxfoW
         q9x+cvbM7Z5Td20QRhsGzs9cVcFLuv+zkgKmiYeESRX4OFfNm+O1cxM8IBeyzauI0P8D
         EFieZj0GdQNhaj7rGyUfAnX1ReZt9v8OXBXkX2JdlHVu1k5kYUjjpg5rn+YkKKP+IcYJ
         MOMXxLh9qEvuAolseM6XPcjeqrXCPim3CXf/RoyeWQ3fZnQvmSy0wXyPYac734ISYh5v
         Pmuw==
X-Gm-Message-State: AOAM532VivzYfoMuhYXkirHsMRl3kZICJFv6YX25uQUj5fvrKc7HFJyF
	v6CswwxALD7qDlJRHZvpnrs=
X-Google-Smtp-Source: ABdhPJwGPYNJdHipR88AgCsSNedxVrXKRLPSbCNZ0Vw/PQMqS4/ZZmjcey45JQAWlpQD9BTSBOkxoA==
X-Received: by 2002:ac2:5fea:: with SMTP id s10mr112420lfg.652.1635369493279;
        Wed, 27 Oct 2021 14:18:13 -0700 (PDT)
From: Dmitry Osipenko <digetx@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Lee Jones <lee.jones@linaro.org>,
	"Rafael J . Wysocki" <rafael@kernel.org>,
	Mark Brown <broonie@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Russell King <linux@armlinux.org.uk>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Ulf Hansson <ulf.hansson@linaro.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Guo Ren <guoren@kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Greg Ungerer <gerg@linux-m68k.org>,
	Joshua Thompson <funaho@jurai.org>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Nick Hu <nickhu@andestech.com>,
	Greentime Hu <green.hu@gmail.com>,
	Vincent Chen <deanbo422@gmail.com>,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	Helge Deller <deller@gmx.de>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Rich Felker <dalias@libc.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Len Brown <lenb@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Chen-Yu Tsai <wens@csie.org>,
	=?UTF-8?q?Jonathan=20Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>,
	Tony Lindgren <tony@atomide.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Vladimir Zapolskiy <vz@mleia.com>,
	Avi Fishman <avifishman70@gmail.com>,
	Tomer Maimon <tmaimon77@gmail.com>,
	Tali Perry <tali.perry1@gmail.com>,
	Patrick Venture <venture@google.com>,
	Nancy Yuen <yuenn@google.com>,
	Benjamin Fair <benjaminfair@google.com>,
	Pavel Machek <pavel@ucw.cz>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	linux-csky@vger.kernel.org,
	linux-ia64@vger.kernel.org,
	linux-m68k@lists.linux-m68k.org,
	linux-mips@vger.kernel.org,
	linux-parisc@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-riscv@lists.infradead.org,
	linux-sh@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	linux-acpi@vger.kernel.org,
	linux-omap@vger.kernel.org,
	openbmc@lists.ozlabs.org,
	linux-tegra@vger.kernel.org,
	linux-pm@vger.kernel.org
Subject: [PATCH v2 11/45] arm64: Use do_kernel_power_off()
Date: Thu, 28 Oct 2021 00:16:41 +0300
Message-Id: <20211027211715.12671-12-digetx@gmail.com>
X-Mailer: git-send-email 2.33.1
In-Reply-To: <20211027211715.12671-1-digetx@gmail.com>
References: <20211027211715.12671-1-digetx@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Kernel now supports chained power-off handlers. Use do_kernel_power_off()
that invokes chained power-off handlers. It also invokes legacy
pm_power_off() for now, which will be removed once all drivers will
be converted to the new power-off API.

Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
 arch/arm64/kernel/process.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/arm64/kernel/process.c b/arch/arm64/kernel/process.c
index aacf2f5559a8..f8db031afa7d 100644
--- a/arch/arm64/kernel/process.c
+++ b/arch/arm64/kernel/process.c
@@ -110,8 +110,7 @@ void machine_power_off(void)
 {
 	local_irq_disable();
 	smp_send_stop();
-	if (pm_power_off)
-		pm_power_off();
+	do_kernel_power_off();
 }
 
 /*
-- 
2.33.1



From xen-devel-bounces@lists.xenproject.org Wed Oct 27 21:28:45 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Oct 2021 21:28:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217349.377453 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfqTK-00017W-V4; Wed, 27 Oct 2021 21:28:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217349.377453; Wed, 27 Oct 2021 21:28:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfqTK-00015O-KK; Wed, 27 Oct 2021 21:28:34 +0000
Received: by outflank-mailman (input) for mailman id 217349;
 Wed, 27 Oct 2021 21:28:32 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=nMly=PP=gmail.com=digetx@srs-us1.protection.inumbo.net>)
 id 1mfqKs-0000sJ-B1
 for xen-devel@lists.xenproject.org; Wed, 27 Oct 2021 21:19:50 +0000
Received: from mail-lf1-x129.google.com (unknown [2a00:1450:4864:20::129])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id dd7093c0-ce60-4352-a841-5e64a19135f8;
 Wed, 27 Oct 2021 21:18:34 +0000 (UTC)
Received: by mail-lf1-x129.google.com with SMTP id bq11so8955702lfb.10
 for <xen-devel@lists.xenproject.org>; Wed, 27 Oct 2021 14:18:34 -0700 (PDT)
Received: from localhost.localdomain (46-138-41-28.dynamic.spd-mgts.ru.
 [46.138.41.28])
 by smtp.gmail.com with ESMTPSA id d7sm104336ljl.18.2021.10.27.14.18.32
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Wed, 27 Oct 2021 14:18:33 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: dd7093c0-ce60-4352-a841-5e64a19135f8
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=4OWbCpLiTrW70NMTPpPUNVkhVF3RKPzG5GTofMVph+0=;
        b=nyjF7CMTiXZTknDCkjxSlwBlmez3wFeA+zehsvTRn8HWRCKWBbu+VeqUVL44ms69wV
         nnBlf5yP21RTavxXaqxcjkZ3KCf591eZC6XUlLgNrDZoqwAeG0e8waWDmBuDqGJPa/ia
         TWGnRhqwCJRO6ZHGrxxDEuuBCRuC8gitnwXoBy6yPn2yaI52p7BdBoMEudji1fyrvZ7s
         jQQkx67Vh3JRx01BzNxvLauTbUeZkFSOIEd8jQMxIMky+FUXABFowKrpCYCop+RjKrYK
         44VAj9OlGjdC9id5DEzvny9pb4y7eTDKQL+s4i3zBATQTR5zvjDC+NzhG9GB4CVWfx2z
         vHjQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=4OWbCpLiTrW70NMTPpPUNVkhVF3RKPzG5GTofMVph+0=;
        b=yAUNVwKW7EnBX8Z9BTD4hyfSHPCeqfPmkkQmdhKYGYzDVYOSqkVvXiKL4AIwEyk/rV
         PvNzbVrVETplO1Hboup8cptVlK4GPnVn+F47GwzObpPyTM/304RrK0b7XbB3J33za9N+
         hsJ0lpsNw9exaFzRC75n5qlQVjtwhX+2e9NhNeJw1JahiKaS29mVWB+TS2aI0sufSd2b
         r5N2BlQxuKTXAMMDts/jsH9+l/mevP9ICm8y/r8X3wcQD+SIE5yw7Uebml7/IYE49EDa
         jkIg0Dcf7PpZdW5jn+KWgpt38tRTJtLR0AscuWy4YG0bzepbJxEdGC9de1sYQ1qatKZ8
         NuLA==
X-Gm-Message-State: AOAM531AsjhwQq/wiXqKwW+G5Bc/I8EqN0EE3xVSnddS2tHDTQXooLFd
	hhEXFD3LNx8DQ4NfXpzBuJ4=
X-Google-Smtp-Source: ABdhPJy61JBdPHWehe+0JZDFDtaEYRkwyYUuH0JZUFf3l53X5Ds5OQvvxR8PRHj15LQUp0FSRiIF9w==
X-Received: by 2002:ac2:53a5:: with SMTP id j5mr141454lfh.130.1635369513848;
        Wed, 27 Oct 2021 14:18:33 -0700 (PDT)
From: Dmitry Osipenko <digetx@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Lee Jones <lee.jones@linaro.org>,
	"Rafael J . Wysocki" <rafael@kernel.org>,
	Mark Brown <broonie@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Russell King <linux@armlinux.org.uk>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Ulf Hansson <ulf.hansson@linaro.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Guo Ren <guoren@kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Greg Ungerer <gerg@linux-m68k.org>,
	Joshua Thompson <funaho@jurai.org>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Nick Hu <nickhu@andestech.com>,
	Greentime Hu <green.hu@gmail.com>,
	Vincent Chen <deanbo422@gmail.com>,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	Helge Deller <deller@gmx.de>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Rich Felker <dalias@libc.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Len Brown <lenb@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Chen-Yu Tsai <wens@csie.org>,
	=?UTF-8?q?Jonathan=20Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>,
	Tony Lindgren <tony@atomide.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Vladimir Zapolskiy <vz@mleia.com>,
	Avi Fishman <avifishman70@gmail.com>,
	Tomer Maimon <tmaimon77@gmail.com>,
	Tali Perry <tali.perry1@gmail.com>,
	Patrick Venture <venture@google.com>,
	Nancy Yuen <yuenn@google.com>,
	Benjamin Fair <benjaminfair@google.com>,
	Pavel Machek <pavel@ucw.cz>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	linux-csky@vger.kernel.org,
	linux-ia64@vger.kernel.org,
	linux-m68k@lists.linux-m68k.org,
	linux-mips@vger.kernel.org,
	linux-parisc@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-riscv@lists.infradead.org,
	linux-sh@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	linux-acpi@vger.kernel.org,
	linux-omap@vger.kernel.org,
	openbmc@lists.ozlabs.org,
	linux-tegra@vger.kernel.org,
	linux-pm@vger.kernel.org
Subject: [PATCH v2 22/45] memory: emif: Use kernel_can_power_off()
Date: Thu, 28 Oct 2021 00:16:52 +0300
Message-Id: <20211027211715.12671-23-digetx@gmail.com>
X-Mailer: git-send-email 2.33.1
In-Reply-To: <20211027211715.12671-1-digetx@gmail.com>
References: <20211027211715.12671-1-digetx@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Replace legacy pm_power_off with kernel_can_power_off() helper that
is aware about chained power-off handlers.

Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
 drivers/memory/emif.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/memory/emif.c b/drivers/memory/emif.c
index 762d0c0f0716..cab10d5274a0 100644
--- a/drivers/memory/emif.c
+++ b/drivers/memory/emif.c
@@ -630,7 +630,7 @@ static irqreturn_t emif_threaded_isr(int irq, void *dev_id)
 		dev_emerg(emif->dev, "SDRAM temperature exceeds operating limit.. Needs shut down!!!\n");
 
 		/* If we have Power OFF ability, use it, else try restarting */
-		if (pm_power_off) {
+		if (kernel_can_power_off()) {
 			kernel_power_off();
 		} else {
 			WARN(1, "FIXME: NO pm_power_off!!! trying restart\n");
-- 
2.33.1



From xen-devel-bounces@lists.xenproject.org Wed Oct 27 21:28:46 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Oct 2021 21:28:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217350.377460 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfqTM-0001PZ-92; Wed, 27 Oct 2021 21:28:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217350.377460; Wed, 27 Oct 2021 21:28:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfqTL-0001M3-Gf; Wed, 27 Oct 2021 21:28:35 +0000
Received: by outflank-mailman (input) for mailman id 217350;
 Wed, 27 Oct 2021 21:28:32 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=nMly=PP=gmail.com=digetx@srs-us1.protection.inumbo.net>)
 id 1mfqLv-0000sJ-D2
 for xen-devel@lists.xenproject.org; Wed, 27 Oct 2021 21:20:55 +0000
Received: from mail-lf1-x132.google.com (unknown [2a00:1450:4864:20::132])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 765197f5-6d84-42ba-939a-91f43f9d5d2b;
 Wed, 27 Oct 2021 21:18:51 +0000 (UTC)
Received: by mail-lf1-x132.google.com with SMTP id bi35so8959697lfb.9
 for <xen-devel@lists.xenproject.org>; Wed, 27 Oct 2021 14:18:51 -0700 (PDT)
Received: from localhost.localdomain (46-138-41-28.dynamic.spd-mgts.ru.
 [46.138.41.28])
 by smtp.gmail.com with ESMTPSA id d7sm104336ljl.18.2021.10.27.14.18.48
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Wed, 27 Oct 2021 14:18:50 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 765197f5-6d84-42ba-939a-91f43f9d5d2b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=MQWhTF0wBI+IugzPE3ghLHT129hypIGKpejDwrM3hyE=;
        b=RZvyurGZNweTiQS39Ean2OjgLccYrK032pC/dpD5TIetEdWActoZDZ0pbxUwZ65EB3
         f6HHqHOjaIJRkLRbNXFH+a9dD2g5xu+MxS8srOD+UoT89FXGbOpnIpBzsogwI4SrHnvI
         Xp4OXB4rFx2UJNCOe+1ontZRmKhqDl18fc0h55fLU7qhbVovqyZfQtN1oE2ZBblN4A6p
         LG+FlNBhlZ+ejJ/tR/o9Ca2I3+iU/ni7hPa9YCzdcCgi2bkMHewfSz0zfMDsoGnOZiG5
         WYH0N8y7+ABYK8jopd3eQsXttqeRRQN+xpWJ5QIjK2cUfd8tbZPE8negDAsL0a+gaJ2V
         fJ3A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=MQWhTF0wBI+IugzPE3ghLHT129hypIGKpejDwrM3hyE=;
        b=TrWHUXfnUy4TAP/21iJjmHLf5D1rssfNba3HCQtdgoa5UnY5Gi69Peuh2LaeSC+HEg
         GplshlLQwjhwi+JFPFZxZbD10p0ScPYIeMDnqQRZAK25R+CLzpOZl5y/xSZ+frcY/I9s
         PbMxWxRFTQiNpT/87xIN5ChognVwVms5Q2P8G/xhi7xQ/n072b//jy7Dfvmk4Wj1IsL8
         0hyhAhYaiiXjbDJo4p2V0b5t36wk3xBay4WEPAAR4Em4Vjo+wL3PeOr2Ypjop/r6DCB6
         hjGzu96SPJs7tUvc9OZ4qPQze0lNQ/58+FbKNRuGJai3ux1t8cbIIW8d2gFs652OrqTk
         uR5Q==
X-Gm-Message-State: AOAM533Zd8U4h9uqqxFDJ/+xq9vNGZY9tzp3qtR+BJ8GRFZAm6rKXpzL
	Rj+mKIBS1lrrF0u1roulv7M=
X-Google-Smtp-Source: ABdhPJyooWx5IN/z+hq1uWs5thGA811Cpi77JA6dUlt/XGnE5KIxJDhql9o1FzopBJlB1UrwswiMLg==
X-Received: by 2002:a05:6512:3f04:: with SMTP id y4mr131405lfa.180.1635369530580;
        Wed, 27 Oct 2021 14:18:50 -0700 (PDT)
From: Dmitry Osipenko <digetx@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Lee Jones <lee.jones@linaro.org>,
	"Rafael J . Wysocki" <rafael@kernel.org>,
	Mark Brown <broonie@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Russell King <linux@armlinux.org.uk>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Ulf Hansson <ulf.hansson@linaro.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Guo Ren <guoren@kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Greg Ungerer <gerg@linux-m68k.org>,
	Joshua Thompson <funaho@jurai.org>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Nick Hu <nickhu@andestech.com>,
	Greentime Hu <green.hu@gmail.com>,
	Vincent Chen <deanbo422@gmail.com>,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	Helge Deller <deller@gmx.de>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Rich Felker <dalias@libc.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Len Brown <lenb@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Chen-Yu Tsai <wens@csie.org>,
	=?UTF-8?q?Jonathan=20Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>,
	Tony Lindgren <tony@atomide.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Vladimir Zapolskiy <vz@mleia.com>,
	Avi Fishman <avifishman70@gmail.com>,
	Tomer Maimon <tmaimon77@gmail.com>,
	Tali Perry <tali.perry1@gmail.com>,
	Patrick Venture <venture@google.com>,
	Nancy Yuen <yuenn@google.com>,
	Benjamin Fair <benjaminfair@google.com>,
	Pavel Machek <pavel@ucw.cz>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	linux-csky@vger.kernel.org,
	linux-ia64@vger.kernel.org,
	linux-m68k@lists.linux-m68k.org,
	linux-mips@vger.kernel.org,
	linux-parisc@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-riscv@lists.infradead.org,
	linux-sh@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	linux-acpi@vger.kernel.org,
	linux-omap@vger.kernel.org,
	openbmc@lists.ozlabs.org,
	linux-tegra@vger.kernel.org,
	linux-pm@vger.kernel.org
Subject: [PATCH v2 31/45] mfd: axp20x: Use register_simple_power_off_handler()
Date: Thu, 28 Oct 2021 00:17:01 +0300
Message-Id: <20211027211715.12671-32-digetx@gmail.com>
X-Mailer: git-send-email 2.33.1
In-Reply-To: <20211027211715.12671-1-digetx@gmail.com>
References: <20211027211715.12671-1-digetx@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Use register_simple_power_off_handler() that replaces global pm_power_off
variable and allows to register multiple power-off handlers.

Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
 drivers/mfd/axp20x.c       | 22 +++++++++++-----------
 include/linux/mfd/axp20x.h |  1 +
 2 files changed, 12 insertions(+), 11 deletions(-)

diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c
index 8161a5dc68e8..db31fdb169e4 100644
--- a/drivers/mfd/axp20x.c
+++ b/drivers/mfd/axp20x.c
@@ -24,6 +24,7 @@
 #include <linux/module.h>
 #include <linux/of_device.h>
 #include <linux/pm_runtime.h>
+#include <linux/reboot.h>
 #include <linux/regmap.h>
 #include <linux/regulator/consumer.h>
 
@@ -823,9 +824,10 @@ static const struct mfd_cell axp813_cells[] = {
 	},
 };
 
-static struct axp20x_dev *axp20x_pm_power_off;
-static void axp20x_power_off(void)
+static void axp20x_power_off(void *data)
 {
+	struct axp20x_dev *axp20x_pm_power_off = data;
+
 	if (axp20x_pm_power_off->variant == AXP288_ID)
 		return;
 
@@ -1000,10 +1002,12 @@ int axp20x_device_probe(struct axp20x_dev *axp20x)
 		return ret;
 	}
 
-	if (!pm_power_off) {
-		axp20x_pm_power_off = axp20x;
-		pm_power_off = axp20x_power_off;
-	}
+	axp20x->power_handler =
+		register_simple_power_off_handler(axp20x_power_off, axp20x);
+
+	if (IS_ERR(axp20x->power_handler))
+		dev_err(axp20x->dev, "failed to register power-off handler: %pe",
+			axp20x->power_handler);
 
 	dev_info(axp20x->dev, "AXP20X driver loaded\n");
 
@@ -1013,11 +1017,7 @@ EXPORT_SYMBOL(axp20x_device_probe);
 
 void axp20x_device_remove(struct axp20x_dev *axp20x)
 {
-	if (axp20x == axp20x_pm_power_off) {
-		axp20x_pm_power_off = NULL;
-		pm_power_off = NULL;
-	}
-
+	unregister_simple_power_off_handler(axp20x->power_handler);
 	mfd_remove_devices(axp20x->dev);
 	regmap_del_irq_chip(axp20x->irq, axp20x->regmap_irqc);
 }
diff --git a/include/linux/mfd/axp20x.h b/include/linux/mfd/axp20x.h
index 9ab0e2fca7ea..49319a0ac369 100644
--- a/include/linux/mfd/axp20x.h
+++ b/include/linux/mfd/axp20x.h
@@ -643,6 +643,7 @@ struct axp20x_dev {
 	const struct mfd_cell           *cells;
 	const struct regmap_config	*regmap_cfg;
 	const struct regmap_irq_chip	*regmap_irq_chip;
+	struct power_handler		*power_handler;
 };
 
 /* generic helper function for reading 9-16 bit wide regs */
-- 
2.33.1



From xen-devel-bounces@lists.xenproject.org Wed Oct 27 21:28:47 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Oct 2021 21:28:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217352.377465 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfqTM-0001Xa-Tj; Wed, 27 Oct 2021 21:28:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217352.377465; Wed, 27 Oct 2021 21:28:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfqTM-0001VV-9s; Wed, 27 Oct 2021 21:28:36 +0000
Received: by outflank-mailman (input) for mailman id 217352;
 Wed, 27 Oct 2021 21:28:33 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=nMly=PP=gmail.com=digetx@srs-us1.protection.inumbo.net>)
 id 1mfqN3-0000sJ-Eh
 for xen-devel@lists.xenproject.org; Wed, 27 Oct 2021 21:22:05 +0000
Received: from mail-lf1-x12e.google.com (unknown [2a00:1450:4864:20::12e])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 65faa95e-9d9e-4589-b672-ba4175121473;
 Wed, 27 Oct 2021 21:19:02 +0000 (UTC)
Received: by mail-lf1-x12e.google.com with SMTP id x27so9006560lfu.5
 for <xen-devel@lists.xenproject.org>; Wed, 27 Oct 2021 14:19:02 -0700 (PDT)
Received: from localhost.localdomain (46-138-41-28.dynamic.spd-mgts.ru.
 [46.138.41.28])
 by smtp.gmail.com with ESMTPSA id d7sm104336ljl.18.2021.10.27.14.18.59
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Wed, 27 Oct 2021 14:19:01 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 65faa95e-9d9e-4589-b672-ba4175121473
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=IkN5RxNvfWU6udxIv0HqPwHPsreqVVHZYAiW4uOSdQE=;
        b=EBSN3i6pBzJ/QX6b7hWJ61FbfkEkrcOrflTwto+4KX4or46ACVz9Tr/1pugxTtiHmi
         G7CMVOoidyYK0g+Vg4pJnm/bKfolm8lIe6sk0vITgUl/0On7GAe1avC+nPdsUhal8n/2
         2LfBGzyZF4kisF1H8Fy3oqJJlA7mP+5FCx9jGZBePen+YJxCg52jU7glSS7bDwelermJ
         QOk39GQqnkcumTBHd2mHERoDOJXwlx4KsuyCu/MObr6DT96WNWvs0v/iyAkBnjjhRCxD
         gw7GTseQp5qiH+atTqu6Rg9n+NmY0IzLKdyAE4sSGNY6W234A5z05GeGyvCsr57AR1H6
         zVgw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=IkN5RxNvfWU6udxIv0HqPwHPsreqVVHZYAiW4uOSdQE=;
        b=QQRK7uNfkfXqzh/2+qQB2MBTUpYfY33zA5szHcVFIkXZkR0RvDa8Tuz3JK8x6ySli9
         eVRGuLNRWtkyZYfGkhVaPgixrOkMdiN9DO4/Vg0p7aO/4jRO7dBUmg7vTAhGleHCS0W/
         DtfzuiJxJnpm/NliR9eU3OuIvXPBNwbxbm+NnOEZFdYo8epCKQKr31KWpU76Jl9i/vq1
         6llItVoOnjKUOESZEEve4RRWAYdTNEghGVqW9AdNAbXSCpZcOi3e5fWDvDJPrDuEEXPO
         Jy1sxBH6dZ0fM6/TZyr/A84UyjIht9NoK9JuzPZwJ+RfFdartxC6cXMxTrzyivSSgXeK
         6vqw==
X-Gm-Message-State: AOAM533yRwLzsgkPHU9agHgQM72/9qu/2LVgrf9CagaeHQ/CWo4fsrwD
	ytPEBubdFEq5l68D2yfMXJM=
X-Google-Smtp-Source: ABdhPJxsr/pRUcPc/yvXJw9vQsQsBRCfPMRUucvUkltufw5utcaA8e0PD5R7U1W5XHhl0HmaGsY5xg==
X-Received: by 2002:a05:6512:aca:: with SMTP id n10mr150724lfu.66.1635369541621;
        Wed, 27 Oct 2021 14:19:01 -0700 (PDT)
From: Dmitry Osipenko <digetx@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Lee Jones <lee.jones@linaro.org>,
	"Rafael J . Wysocki" <rafael@kernel.org>,
	Mark Brown <broonie@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Russell King <linux@armlinux.org.uk>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Ulf Hansson <ulf.hansson@linaro.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Guo Ren <guoren@kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Greg Ungerer <gerg@linux-m68k.org>,
	Joshua Thompson <funaho@jurai.org>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Nick Hu <nickhu@andestech.com>,
	Greentime Hu <green.hu@gmail.com>,
	Vincent Chen <deanbo422@gmail.com>,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	Helge Deller <deller@gmx.de>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Rich Felker <dalias@libc.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Len Brown <lenb@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Chen-Yu Tsai <wens@csie.org>,
	=?UTF-8?q?Jonathan=20Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>,
	Tony Lindgren <tony@atomide.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Vladimir Zapolskiy <vz@mleia.com>,
	Avi Fishman <avifishman70@gmail.com>,
	Tomer Maimon <tmaimon77@gmail.com>,
	Tali Perry <tali.perry1@gmail.com>,
	Patrick Venture <venture@google.com>,
	Nancy Yuen <yuenn@google.com>,
	Benjamin Fair <benjaminfair@google.com>,
	Pavel Machek <pavel@ucw.cz>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	linux-csky@vger.kernel.org,
	linux-ia64@vger.kernel.org,
	linux-m68k@lists.linux-m68k.org,
	linux-mips@vger.kernel.org,
	linux-parisc@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-riscv@lists.infradead.org,
	linux-sh@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	linux-acpi@vger.kernel.org,
	linux-omap@vger.kernel.org,
	openbmc@lists.ozlabs.org,
	linux-tegra@vger.kernel.org,
	linux-pm@vger.kernel.org
Subject: [PATCH v2 37/45] mfd: tps65910: Use devm_register_simple_power_off_handler()
Date: Thu, 28 Oct 2021 00:17:07 +0300
Message-Id: <20211027211715.12671-38-digetx@gmail.com>
X-Mailer: git-send-email 2.33.1
In-Reply-To: <20211027211715.12671-1-digetx@gmail.com>
References: <20211027211715.12671-1-digetx@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Use devm_register_simple_power_off_handler() that replaces global
pm_power_off variable and allows to register multiple power-off handlers.

Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
 drivers/mfd/tps65910.c | 17 ++++++++++++-----
 1 file changed, 12 insertions(+), 5 deletions(-)

diff --git a/drivers/mfd/tps65910.c b/drivers/mfd/tps65910.c
index 6e105cca27d4..8fab30dc84e5 100644
--- a/drivers/mfd/tps65910.c
+++ b/drivers/mfd/tps65910.c
@@ -16,6 +16,7 @@
 #include <linux/irq.h>
 #include <linux/irqdomain.h>
 #include <linux/mfd/core.h>
+#include <linux/reboot.h>
 #include <linux/regmap.h>
 #include <linux/mfd/tps65910.h>
 #include <linux/of.h>
@@ -429,9 +430,9 @@ struct tps65910_board *tps65910_parse_dt(struct i2c_client *client,
 }
 #endif
 
-static struct i2c_client *tps65910_i2c_client;
-static void tps65910_power_off(void)
+static void tps65910_power_off(void *data)
 {
+	struct i2c_client *tps65910_i2c_client = data;
 	struct tps65910 *tps65910;
 
 	tps65910 = dev_get_drvdata(&tps65910_i2c_client->dev);
@@ -503,9 +504,15 @@ static int tps65910_i2c_probe(struct i2c_client *i2c,
 	tps65910_ck32k_init(tps65910, pmic_plat_data);
 	tps65910_sleepinit(tps65910, pmic_plat_data);
 
-	if (pmic_plat_data->pm_off && !pm_power_off) {
-		tps65910_i2c_client = i2c;
-		pm_power_off = tps65910_power_off;
+	if (pmic_plat_data->pm_off) {
+		ret = devm_register_simple_power_off_handler(&i2c->dev,
+							     tps65910_power_off,
+							     i2c);
+		if (ret) {
+			dev_err(&i2c->dev,
+				"failed to register power-off handler: %d\n", ret);
+			return ret;
+		}
 	}
 
 	ret = devm_mfd_add_devices(tps65910->dev, -1,
-- 
2.33.1



From xen-devel-bounces@lists.xenproject.org Wed Oct 27 21:28:49 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Oct 2021 21:28:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217357.377481 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfqTP-0002AJ-9U; Wed, 27 Oct 2021 21:28:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217357.377481; Wed, 27 Oct 2021 21:28:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfqTO-00025c-SL; Wed, 27 Oct 2021 21:28:38 +0000
Received: by outflank-mailman (input) for mailman id 217357;
 Wed, 27 Oct 2021 21:28:36 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=nMly=PP=gmail.com=digetx@srs-us1.protection.inumbo.net>)
 id 1mfqKJ-0000sJ-AC
 for xen-devel@lists.xenproject.org; Wed, 27 Oct 2021 21:19:15 +0000
Received: from mail-lj1-x22e.google.com (unknown [2a00:1450:4864:20::22e])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 8325c7f7-cc0c-4dff-b219-56797cb660da;
 Wed, 27 Oct 2021 21:18:23 +0000 (UTC)
Received: by mail-lj1-x22e.google.com with SMTP id n7so6989547ljp.5
 for <xen-devel@lists.xenproject.org>; Wed, 27 Oct 2021 14:18:23 -0700 (PDT)
Received: from localhost.localdomain (46-138-41-28.dynamic.spd-mgts.ru.
 [46.138.41.28])
 by smtp.gmail.com with ESMTPSA id d7sm104336ljl.18.2021.10.27.14.18.20
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Wed, 27 Oct 2021 14:18:22 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8325c7f7-cc0c-4dff-b219-56797cb660da
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=ZQw7CI0X8q8oTyepUGNJOSZqk2PM67xqdSRvFtKKmiw=;
        b=h1ou+u32rU4cYIn0OrunTZVHH8PVsk/s4rO9s8rIgCD+KKjcifq4iXhOSD/tIm7Qin
         P6ARY8cS2LdXxM+CoAbgm367SWuzYvU7Z79bJYgTCDi7YlT7Y5yuy0qGD8YIp/7ys02d
         pQwjIRkz9TYZYOpAy67AqOhS7slV4KAtJVEBcoUUJ83/AZzv5dclkL7bTj62SJ6cw7H4
         UW+yIUAnRXLn6nWbS4xhDtCDZfNdRtv+xAYYROwA+IIcIffcm5Q9yfNkOiBLfH2Y/wmk
         oOdsC/qn1zU/au/+LxlGh/gFJDeofp5A7xGvQ93uStcIj752OCcUSwSsN/9T0qMY5YTe
         dvtw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=ZQw7CI0X8q8oTyepUGNJOSZqk2PM67xqdSRvFtKKmiw=;
        b=qSeavAipE4/55i1CIBdyrfgRSMnWrGYua7QqembtjS9VS5zGf9DGFghBZ9FA5grlYo
         +Gu1XVyy4utsUewS6AIO40Bwj7Vxm/U+MeFAyUFEpvT9vxiZgA02ZHSQ4OE4F9FYfzB+
         6HaLDqfjJdAPUqTgLTmI4uY2207RYoz/l+XbySPKdeGKoEkMZ3KmuvG/CVc+tw0B6isB
         quuONDLs2T9vMWNfGUQKNoNIEVFwALxGIUwF3g5MwUmwMsUdtx+Woopw5YO86ygoKi8a
         ru7xXV+i79EB8iZxDXZoIvIVvY3Kss6WtHpYLI3w8cs4uhn1xq71ZG2HyjmdfI9L5GMX
         VvRg==
X-Gm-Message-State: AOAM533/WVh8D2oVwDK1WobA/8Ufx1ZALSEESOsk1VgBEnJIug8P1E8g
	VbBG9oA9j3i9echvY5FkzaQ=
X-Google-Smtp-Source: ABdhPJztZrtJsxWmkjJ9e0hDv7W0ZJONlmNUbIC8cbkqFySfq5YC9V4Azd52J8+C4kw5eLOToEAzlw==
X-Received: by 2002:a2e:bf1c:: with SMTP id c28mr359960ljr.150.1635369502589;
        Wed, 27 Oct 2021 14:18:22 -0700 (PDT)
From: Dmitry Osipenko <digetx@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Lee Jones <lee.jones@linaro.org>,
	"Rafael J . Wysocki" <rafael@kernel.org>,
	Mark Brown <broonie@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Russell King <linux@armlinux.org.uk>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Ulf Hansson <ulf.hansson@linaro.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Guo Ren <guoren@kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Greg Ungerer <gerg@linux-m68k.org>,
	Joshua Thompson <funaho@jurai.org>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Nick Hu <nickhu@andestech.com>,
	Greentime Hu <green.hu@gmail.com>,
	Vincent Chen <deanbo422@gmail.com>,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	Helge Deller <deller@gmx.de>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Rich Felker <dalias@libc.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Len Brown <lenb@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Chen-Yu Tsai <wens@csie.org>,
	=?UTF-8?q?Jonathan=20Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>,
	Tony Lindgren <tony@atomide.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Vladimir Zapolskiy <vz@mleia.com>,
	Avi Fishman <avifishman70@gmail.com>,
	Tomer Maimon <tmaimon77@gmail.com>,
	Tali Perry <tali.perry1@gmail.com>,
	Patrick Venture <venture@google.com>,
	Nancy Yuen <yuenn@google.com>,
	Benjamin Fair <benjaminfair@google.com>,
	Pavel Machek <pavel@ucw.cz>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	linux-csky@vger.kernel.org,
	linux-ia64@vger.kernel.org,
	linux-m68k@lists.linux-m68k.org,
	linux-mips@vger.kernel.org,
	linux-parisc@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-riscv@lists.infradead.org,
	linux-sh@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	linux-acpi@vger.kernel.org,
	linux-omap@vger.kernel.org,
	openbmc@lists.ozlabs.org,
	linux-tegra@vger.kernel.org,
	linux-pm@vger.kernel.org
Subject: [PATCH v2 16/45] parisc: Use do_kernel_power_off()
Date: Thu, 28 Oct 2021 00:16:46 +0300
Message-Id: <20211027211715.12671-17-digetx@gmail.com>
X-Mailer: git-send-email 2.33.1
In-Reply-To: <20211027211715.12671-1-digetx@gmail.com>
References: <20211027211715.12671-1-digetx@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Kernel now supports chained power-off handlers. Use do_kernel_power_off()
that invokes chained power-off handlers. It also invokes legacy
pm_power_off() for now, which will be removed once all drivers will
be converted to the new power-off API.

Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
 arch/parisc/kernel/process.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/parisc/kernel/process.c b/arch/parisc/kernel/process.c
index ea3d83b6fb62..928201b1f58f 100644
--- a/arch/parisc/kernel/process.c
+++ b/arch/parisc/kernel/process.c
@@ -26,6 +26,7 @@
 #include <linux/module.h>
 #include <linux/personality.h>
 #include <linux/ptrace.h>
+#include <linux/reboot.h>
 #include <linux/sched.h>
 #include <linux/sched/debug.h>
 #include <linux/sched/task.h>
@@ -114,8 +115,7 @@ void machine_power_off(void)
 	pdc_chassis_send_status(PDC_CHASSIS_DIRECT_SHUTDOWN);
 
 	/* ipmi_poweroff may have been installed. */
-	if (pm_power_off)
-		pm_power_off();
+	do_kernel_power_off();
 		
 	/* It seems we have no way to power the system off via
 	 * software. The user has to press the button himself. */
-- 
2.33.1



From xen-devel-bounces@lists.xenproject.org Wed Oct 27 21:28:53 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Oct 2021 21:28:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217360.377496 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfqTT-0002qE-5h; Wed, 27 Oct 2021 21:28:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217360.377496; Wed, 27 Oct 2021 21:28:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfqTS-0002mD-2y; Wed, 27 Oct 2021 21:28:42 +0000
Received: by outflank-mailman (input) for mailman id 217360;
 Wed, 27 Oct 2021 21:28:40 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=nMly=PP=gmail.com=digetx@srs-us1.protection.inumbo.net>)
 id 1mfqKO-0000sJ-AH
 for xen-devel@lists.xenproject.org; Wed, 27 Oct 2021 21:19:20 +0000
Received: from mail-lj1-x229.google.com (unknown [2a00:1450:4864:20::229])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 01087dc5-ad54-4608-8e65-24125bedb2ea;
 Wed, 27 Oct 2021 21:18:25 +0000 (UTC)
Received: by mail-lj1-x229.google.com with SMTP id q16so7018224ljg.3
 for <xen-devel@lists.xenproject.org>; Wed, 27 Oct 2021 14:18:25 -0700 (PDT)
Received: from localhost.localdomain (46-138-41-28.dynamic.spd-mgts.ru.
 [46.138.41.28])
 by smtp.gmail.com with ESMTPSA id d7sm104336ljl.18.2021.10.27.14.18.22
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Wed, 27 Oct 2021 14:18:24 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 01087dc5-ad54-4608-8e65-24125bedb2ea
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=rn6kChPkfoFMf9bWYHf70bnGYIj3LFIVKDTZ1qePG0M=;
        b=UpWsh/FpGieodrD9s3cNqzK6jy31h5ljZFEwQ+D2q0RTlqvYeysLYZeRQo1KpYyV2E
         FrJFQ3pk1ZjLGkSmkQuMqpQGm3pLQYdGN7MewaJIFH4jHkVWFJbftv36SpE7wHzAfM6f
         KfYBgHNJAt7rLgdyfNzETIqs5AkGlF85N8K8c3T6GaZ5ArdlodepiLYddRqHEhO/3Klg
         D8JJS7iUiqx+skaUr3SoIxZKpGEOkheRNugtxOQ9N5fX3CP32io6EjkCrnAIhbDZrUUD
         zN+4zZTl26WGoleIrx97PYAjrTar40Pf+ijrpXYWtFKLlTkmoUa0DEaDGbd2O74e82mz
         NNrw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=rn6kChPkfoFMf9bWYHf70bnGYIj3LFIVKDTZ1qePG0M=;
        b=qRh9j7hbT/NKISwO62UTVlxZgn42/1NU4tzS4UVF8vNNARgoD3KmoViiZzCjclwGRy
         uG2hs9rri+ztNo1Hk7yMsf+dLTxS7Iw+sAexSES89/2DEc3HlLxo84S8vNYFtfMgHbG4
         hZMIF73DmyldBEycSVCOf74eBCwwDU4cOMI+2KH97bXebZB0V51CBVs2xr4Pk2Vq+49P
         id0J17DybQkunC5GyZkTA+VKV+ExCvDqwnowIhmhQR5NzZ4zR8HEE6c9TNNBwyOF9jIs
         kEnZu94qMd3IyaYyvB+xblR7in5kuPvErlbc9k89e9ukHdKHBuZdRY7q6FPO9Zu93OfL
         3O6Q==
X-Gm-Message-State: AOAM532u//tee7kJ4nR5X0INZjR6SO+yYlL4qV8ubpARwWLx8ASaUl/w
	tbYlISZpWFFK1d3930DlzgA=
X-Google-Smtp-Source: ABdhPJzozXX9CLT+V56pSkYTIT6ENXsjFNJw478xo/aJxRV2fH58rMxN8jZgU4s16hZZ4d9qEx0Lfg==
X-Received: by 2002:a05:651c:114b:: with SMTP id h11mr321181ljo.35.1635369504516;
        Wed, 27 Oct 2021 14:18:24 -0700 (PDT)
From: Dmitry Osipenko <digetx@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Lee Jones <lee.jones@linaro.org>,
	"Rafael J . Wysocki" <rafael@kernel.org>,
	Mark Brown <broonie@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Russell King <linux@armlinux.org.uk>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Ulf Hansson <ulf.hansson@linaro.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Guo Ren <guoren@kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Greg Ungerer <gerg@linux-m68k.org>,
	Joshua Thompson <funaho@jurai.org>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Nick Hu <nickhu@andestech.com>,
	Greentime Hu <green.hu@gmail.com>,
	Vincent Chen <deanbo422@gmail.com>,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	Helge Deller <deller@gmx.de>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Rich Felker <dalias@libc.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Len Brown <lenb@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Chen-Yu Tsai <wens@csie.org>,
	=?UTF-8?q?Jonathan=20Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>,
	Tony Lindgren <tony@atomide.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Vladimir Zapolskiy <vz@mleia.com>,
	Avi Fishman <avifishman70@gmail.com>,
	Tomer Maimon <tmaimon77@gmail.com>,
	Tali Perry <tali.perry1@gmail.com>,
	Patrick Venture <venture@google.com>,
	Nancy Yuen <yuenn@google.com>,
	Benjamin Fair <benjaminfair@google.com>,
	Pavel Machek <pavel@ucw.cz>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	linux-csky@vger.kernel.org,
	linux-ia64@vger.kernel.org,
	linux-m68k@lists.linux-m68k.org,
	linux-mips@vger.kernel.org,
	linux-parisc@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-riscv@lists.infradead.org,
	linux-sh@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	linux-acpi@vger.kernel.org,
	linux-omap@vger.kernel.org,
	openbmc@lists.ozlabs.org,
	linux-tegra@vger.kernel.org,
	linux-pm@vger.kernel.org
Subject: [PATCH v2 17/45] powerpc: Use do_kernel_power_off()
Date: Thu, 28 Oct 2021 00:16:47 +0300
Message-Id: <20211027211715.12671-18-digetx@gmail.com>
X-Mailer: git-send-email 2.33.1
In-Reply-To: <20211027211715.12671-1-digetx@gmail.com>
References: <20211027211715.12671-1-digetx@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Kernel now supports chained power-off handlers. Use do_kernel_power_off()
that invokes chained power-off handlers. It also invokes legacy
pm_power_off() for now, which will be removed once all drivers will
be converted to the new power-off API.

Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
 arch/powerpc/kernel/setup-common.c | 4 +---
 arch/powerpc/xmon/xmon.c           | 3 +--
 2 files changed, 2 insertions(+), 5 deletions(-)

diff --git a/arch/powerpc/kernel/setup-common.c b/arch/powerpc/kernel/setup-common.c
index 4f1322b65760..71c4ccd9bbb1 100644
--- a/arch/powerpc/kernel/setup-common.c
+++ b/arch/powerpc/kernel/setup-common.c
@@ -161,9 +161,7 @@ void machine_restart(char *cmd)
 void machine_power_off(void)
 {
 	machine_shutdown();
-	if (pm_power_off)
-		pm_power_off();
-
+	do_kernel_power_off();
 	smp_send_stop();
 	machine_hang();
 }
diff --git a/arch/powerpc/xmon/xmon.c b/arch/powerpc/xmon/xmon.c
index dd8241c009e5..9d835807d645 100644
--- a/arch/powerpc/xmon/xmon.c
+++ b/arch/powerpc/xmon/xmon.c
@@ -1243,8 +1243,7 @@ static void bootcmds(void)
 	} else if (cmd == 'h') {
 		ppc_md.halt();
 	} else if (cmd == 'p') {
-		if (pm_power_off)
-			pm_power_off();
+		do_kernel_power_off();
 	}
 }
 
-- 
2.33.1



From xen-devel-bounces@lists.xenproject.org Wed Oct 27 21:28:54 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Oct 2021 21:28:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217363.377502 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfqTU-0003AY-FY; Wed, 27 Oct 2021 21:28:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217363.377502; Wed, 27 Oct 2021 21:28:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfqTT-00033w-NJ; Wed, 27 Oct 2021 21:28:43 +0000
Received: by outflank-mailman (input) for mailman id 217363;
 Wed, 27 Oct 2021 21:28:41 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=nMly=PP=gmail.com=digetx@srs-us1.protection.inumbo.net>)
 id 1mfqKn-0000sJ-B1
 for xen-devel@lists.xenproject.org; Wed, 27 Oct 2021 21:19:45 +0000
Received: from mail-lf1-x134.google.com (unknown [2a00:1450:4864:20::134])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id fed3223e-1a96-44bf-b846-2ec276fe5515;
 Wed, 27 Oct 2021 21:18:33 +0000 (UTC)
Received: by mail-lf1-x134.google.com with SMTP id b32so5809968lfv.0
 for <xen-devel@lists.xenproject.org>; Wed, 27 Oct 2021 14:18:33 -0700 (PDT)
Received: from localhost.localdomain (46-138-41-28.dynamic.spd-mgts.ru.
 [46.138.41.28])
 by smtp.gmail.com with ESMTPSA id d7sm104336ljl.18.2021.10.27.14.18.30
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Wed, 27 Oct 2021 14:18:31 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fed3223e-1a96-44bf-b846-2ec276fe5515
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=guWA5fFZeGPtiBZOYoQcCwu2VFdVsVhLW9/JhrymZ0g=;
        b=Y3ajD9hSFiO6I4QqBgfg35JQ5CG9aR8SawQdCZ/PvBPpTrKpea4VQPEYGG2e2LlPNw
         INBF/7ltt3G3417Dh9CdQfPTHSkRg6FMpjv8P1ntJFwpZqSV1uSTE4GmrYnNoXeajbha
         R/xICM0awt4oVDfnXFmFRQIZuNOfUQCww36nBDR3iRSiJcFpUgR7ytoBp8ilJAXX1BoV
         q3WrRdzyqUShxUhnVnyU+VPDZDBm93MNtu5SNFBPibM7EM2q+6x7IVUVp7KS5HkYIUo5
         6/azutWfWLEZTqcTTzvxBwc0sMsrgJicmN8uMy0n0bR+IWtSXzppNigQSpvDusN76BYk
         OmuA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=guWA5fFZeGPtiBZOYoQcCwu2VFdVsVhLW9/JhrymZ0g=;
        b=6mZxwjxX8n/6jWjp9NQ3L1SsmMkt0ikUFuq8nEr97Dt4c1g8L0wGs//PXlADKfrMuT
         ok6M9jXJXs12wMbndXbWFbCyZB9mwwA81HbbkdpoY2wJKe66CXqCtdnqLcVnlj24UTxI
         loLEZyBgJKtPI5Df4EuuJq/UKzS5gesLo49P41Me7y0xUlI2+ezVGy6NILKb1aNYLD24
         VCJ1iMODYtgu1yg16yey3GRWDzUzDqitTX5cuTBBh7vR3SI19zI9kWJeVLqLxvdhXQ6l
         mdV7i8x3AB+NQ8cGFadhyHYnhaU/bQjAplGHvsL1C8DJ83fn/YE5fXmvjQ+MzQcrg7bw
         aHsg==
X-Gm-Message-State: AOAM530ij2vVunU9aLOySLUnJLN1IvTUVKCdi4sK2GX45DZCP2Ncodt5
	td4MYNCpqUo9wgCpLbLuvPw=
X-Google-Smtp-Source: ABdhPJw9hBA3rUBC1cmHCV5isZVZ9pveXdrJpcvckt2xCHU4v9xkBuaEqDJVomXcVNELr8shz4+44g==
X-Received: by 2002:a05:6512:324d:: with SMTP id c13mr91026lfr.349.1635369512043;
        Wed, 27 Oct 2021 14:18:32 -0700 (PDT)
From: Dmitry Osipenko <digetx@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Lee Jones <lee.jones@linaro.org>,
	"Rafael J . Wysocki" <rafael@kernel.org>,
	Mark Brown <broonie@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Russell King <linux@armlinux.org.uk>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Ulf Hansson <ulf.hansson@linaro.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Guo Ren <guoren@kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Greg Ungerer <gerg@linux-m68k.org>,
	Joshua Thompson <funaho@jurai.org>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Nick Hu <nickhu@andestech.com>,
	Greentime Hu <green.hu@gmail.com>,
	Vincent Chen <deanbo422@gmail.com>,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	Helge Deller <deller@gmx.de>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Rich Felker <dalias@libc.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Len Brown <lenb@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Chen-Yu Tsai <wens@csie.org>,
	=?UTF-8?q?Jonathan=20Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>,
	Tony Lindgren <tony@atomide.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Vladimir Zapolskiy <vz@mleia.com>,
	Avi Fishman <avifishman70@gmail.com>,
	Tomer Maimon <tmaimon77@gmail.com>,
	Tali Perry <tali.perry1@gmail.com>,
	Patrick Venture <venture@google.com>,
	Nancy Yuen <yuenn@google.com>,
	Benjamin Fair <benjaminfair@google.com>,
	Pavel Machek <pavel@ucw.cz>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	linux-csky@vger.kernel.org,
	linux-ia64@vger.kernel.org,
	linux-m68k@lists.linux-m68k.org,
	linux-mips@vger.kernel.org,
	linux-parisc@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-riscv@lists.infradead.org,
	linux-sh@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	linux-acpi@vger.kernel.org,
	linux-omap@vger.kernel.org,
	openbmc@lists.ozlabs.org,
	linux-tegra@vger.kernel.org,
	linux-pm@vger.kernel.org
Subject: [PATCH v2 21/45] m68k: Switch to new power-handler API
Date: Thu, 28 Oct 2021 00:16:51 +0300
Message-Id: <20211027211715.12671-22-digetx@gmail.com>
X-Mailer: git-send-email 2.33.1
In-Reply-To: <20211027211715.12671-1-digetx@gmail.com>
References: <20211027211715.12671-1-digetx@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Kernel now supports chained power-off handlers. Use
register_power_off_handler() that registers power-off handlers and
do_kernel_power_off() that invokes chained power-off handlers. Legacy
pm_power_off() will be removed once all drivers will be converted to
the new power-off API.

Normally arch code should adopt only the do_kernel_power_off() at first,
but m68k is a special case because it uses pm_power_off() "inside out",
i.e. pm_power_off() invokes machine_power_off() [in fact it does nothing],
while it's machine_power_off() that should invoke the pm_power_off(), and
thus, we can't convert platforms to the new API separately. There are only
two platforms changed here, so it's not a big deal.

Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
 arch/m68k/emu/natfeat.c         | 3 ++-
 arch/m68k/include/asm/machdep.h | 1 -
 arch/m68k/kernel/process.c      | 5 ++---
 arch/m68k/kernel/setup_mm.c     | 1 -
 arch/m68k/kernel/setup_no.c     | 1 -
 arch/m68k/mac/config.c          | 4 +++-
 6 files changed, 7 insertions(+), 8 deletions(-)

diff --git a/arch/m68k/emu/natfeat.c b/arch/m68k/emu/natfeat.c
index 71b78ecee75c..b19dc00026d9 100644
--- a/arch/m68k/emu/natfeat.c
+++ b/arch/m68k/emu/natfeat.c
@@ -15,6 +15,7 @@
 #include <linux/string.h>
 #include <linux/kernel.h>
 #include <linux/module.h>
+#include <linux/reboot.h>
 #include <linux/io.h>
 #include <asm/machdep.h>
 #include <asm/natfeat.h>
@@ -90,5 +91,5 @@ void __init nf_init(void)
 	pr_info("NatFeats found (%s, %lu.%lu)\n", buf, version >> 16,
 		version & 0xffff);
 
-	mach_power_off = nf_poweroff;
+	register_platform_power_off(nf_poweroff);
 }
diff --git a/arch/m68k/include/asm/machdep.h b/arch/m68k/include/asm/machdep.h
index 8fd80ef1b77e..8d8c3ee2069f 100644
--- a/arch/m68k/include/asm/machdep.h
+++ b/arch/m68k/include/asm/machdep.h
@@ -24,7 +24,6 @@ extern int (*mach_get_rtc_pll)(struct rtc_pll_info *);
 extern int (*mach_set_rtc_pll)(struct rtc_pll_info *);
 extern void (*mach_reset)( void );
 extern void (*mach_halt)( void );
-extern void (*mach_power_off)( void );
 extern unsigned long (*mach_hd_init) (unsigned long, unsigned long);
 extern void (*mach_hd_setup)(char *, int *);
 extern void (*mach_heartbeat) (int);
diff --git a/arch/m68k/kernel/process.c b/arch/m68k/kernel/process.c
index a6030dbaa089..e160a7c57bd3 100644
--- a/arch/m68k/kernel/process.c
+++ b/arch/m68k/kernel/process.c
@@ -67,12 +67,11 @@ void machine_halt(void)
 
 void machine_power_off(void)
 {
-	if (mach_power_off)
-		mach_power_off();
+	do_kernel_power_off();
 	for (;;);
 }
 
-void (*pm_power_off)(void) = machine_power_off;
+void (*pm_power_off)(void);
 EXPORT_SYMBOL(pm_power_off);
 
 void show_regs(struct pt_regs * regs)
diff --git a/arch/m68k/kernel/setup_mm.c b/arch/m68k/kernel/setup_mm.c
index 4b51bfd38e5f..50f4f120a4ff 100644
--- a/arch/m68k/kernel/setup_mm.c
+++ b/arch/m68k/kernel/setup_mm.c
@@ -98,7 +98,6 @@ EXPORT_SYMBOL(mach_get_rtc_pll);
 EXPORT_SYMBOL(mach_set_rtc_pll);
 void (*mach_reset)( void );
 void (*mach_halt)( void );
-void (*mach_power_off)( void );
 #ifdef CONFIG_HEARTBEAT
 void (*mach_heartbeat) (int);
 EXPORT_SYMBOL(mach_heartbeat);
diff --git a/arch/m68k/kernel/setup_no.c b/arch/m68k/kernel/setup_no.c
index 5e4104f07a44..00bf82258233 100644
--- a/arch/m68k/kernel/setup_no.c
+++ b/arch/m68k/kernel/setup_no.c
@@ -55,7 +55,6 @@ int (*mach_hwclk) (int, struct rtc_time*);
 /* machine dependent reboot functions */
 void (*mach_reset)(void);
 void (*mach_halt)(void);
-void (*mach_power_off)(void);
 
 #ifdef CONFIG_M68000
 #if defined(CONFIG_M68328)
diff --git a/arch/m68k/mac/config.c b/arch/m68k/mac/config.c
index 5d16f9b47aa9..727320dedf08 100644
--- a/arch/m68k/mac/config.c
+++ b/arch/m68k/mac/config.c
@@ -12,6 +12,7 @@
 
 #include <linux/errno.h>
 #include <linux/module.h>
+#include <linux/reboot.h>
 #include <linux/types.h>
 #include <linux/mm.h>
 #include <linux/tty.h>
@@ -139,7 +140,6 @@ void __init config_mac(void)
 	mach_hwclk = mac_hwclk;
 	mach_reset = mac_reset;
 	mach_halt = mac_poweroff;
-	mach_power_off = mac_poweroff;
 #if IS_ENABLED(CONFIG_INPUT_M68K_BEEP)
 	mach_beep = mac_mksound;
 #endif
@@ -159,6 +159,8 @@ void __init config_mac(void)
 
 	if (macintosh_config->ident == MAC_MODEL_IICI)
 		mach_l2_flush = via_l2_flush;
+
+	register_platform_power_off(mac_poweroff);
 }
 
 
-- 
2.33.1



From xen-devel-bounces@lists.xenproject.org Wed Oct 27 21:28:57 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Oct 2021 21:28:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217365.377511 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfqTW-0003Xo-OX; Wed, 27 Oct 2021 21:28:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217365.377511; Wed, 27 Oct 2021 21:28:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfqTV-0003S7-Hy; Wed, 27 Oct 2021 21:28:45 +0000
Received: by outflank-mailman (input) for mailman id 217365;
 Wed, 27 Oct 2021 21:28:42 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=nMly=PP=gmail.com=digetx@srs-us1.protection.inumbo.net>)
 id 1mfqMA-0000sJ-DL
 for xen-devel@lists.xenproject.org; Wed, 27 Oct 2021 21:21:10 +0000
Received: from mail-lj1-x233.google.com (unknown [2a00:1450:4864:20::233])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 5b88031b-e522-4827-becf-81d9a5b22854;
 Wed, 27 Oct 2021 21:18:55 +0000 (UTC)
Received: by mail-lj1-x233.google.com with SMTP id s19so6945173ljj.11
 for <xen-devel@lists.xenproject.org>; Wed, 27 Oct 2021 14:18:55 -0700 (PDT)
Received: from localhost.localdomain (46-138-41-28.dynamic.spd-mgts.ru.
 [46.138.41.28])
 by smtp.gmail.com with ESMTPSA id d7sm104336ljl.18.2021.10.27.14.18.52
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Wed, 27 Oct 2021 14:18:53 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5b88031b-e522-4827-becf-81d9a5b22854
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=Vtt3o4MswiJ8Uwk5SbVoJldxGf1+YbPRO7EtWlQaYpw=;
        b=h9Sc10ekNHuFL9pzFR5ivr4ubnoV3ErBKpxwq8qtLnmmEwmpDGD4jSeaWauc76yLUe
         mSt4r4zCNyFKj4h5OR8HLlxF7zfIwR2mYZXQxAs/YUFPraXy5oJXAYRRb5XFp5DFvHId
         dp4uwopusQmPxwo8pBprt9hjoN+nwfiSLFgat9Xg5VUZGhfoEbJhN2yWrZJiei/Mb3oo
         mtgvsX4Y0EPIUr2yLJuO6jAqsOYLbfr0p9vS8kzfJK4fcF7aAzjiqNMDP4LlFTOflII0
         /Ozi7fljMZ5bdh0k27GOMuAQZgJbYkevh7WpkJcoo8VpN/Xp7c/9529BJm6xL6ZNrYi/
         VmuQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=Vtt3o4MswiJ8Uwk5SbVoJldxGf1+YbPRO7EtWlQaYpw=;
        b=zW87Cb28Ra2mF2jh4VUx07tpYuwVyYlSNfj0U7XmyzkZpQuNfeUdQ4/n10xQoMjNC8
         FUK1KqBAkBhCPeXGGhAZFPqEVm3kAWH/RndMpAihmVB5wkb4LdCdagmUHiD676OmCok2
         wQDbtaWAo7/KIJpquQEKL4m805JcAdIf0Kbu/j7McZDEoJVo318DFpqyJKkb4Swqbjry
         3/a4tTNn8jIzEgOg9lzxyr+jzNNBsz3VQLNE7ywcNk+h+En4uDJlEEUOmsOOEV1UvTgR
         yEKTjc/T0mBFfj64LwjKcuReEBFROImb1tDEcL4fz3Ilb/MQ5eEudvL4NQWscE1bT8j+
         E2+A==
X-Gm-Message-State: AOAM532MK1UbnfPtD7V6pnkmI72J6+YTu0sPPclaJG8qmKGsZQsFyCFY
	B2rATSksO3C722yk0MYwezw=
X-Google-Smtp-Source: ABdhPJyyBz+GAYvcNwhzUHtMKnc91wku7za2iucydPD6HlUd9fBk/92YnwCUeQIBB5tQ4kJ4zljd+g==
X-Received: by 2002:a2e:b804:: with SMTP id u4mr293626ljo.425.1635369534279;
        Wed, 27 Oct 2021 14:18:54 -0700 (PDT)
From: Dmitry Osipenko <digetx@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Lee Jones <lee.jones@linaro.org>,
	"Rafael J . Wysocki" <rafael@kernel.org>,
	Mark Brown <broonie@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Russell King <linux@armlinux.org.uk>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Ulf Hansson <ulf.hansson@linaro.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Guo Ren <guoren@kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Greg Ungerer <gerg@linux-m68k.org>,
	Joshua Thompson <funaho@jurai.org>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Nick Hu <nickhu@andestech.com>,
	Greentime Hu <green.hu@gmail.com>,
	Vincent Chen <deanbo422@gmail.com>,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	Helge Deller <deller@gmx.de>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Rich Felker <dalias@libc.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Len Brown <lenb@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Chen-Yu Tsai <wens@csie.org>,
	=?UTF-8?q?Jonathan=20Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>,
	Tony Lindgren <tony@atomide.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Vladimir Zapolskiy <vz@mleia.com>,
	Avi Fishman <avifishman70@gmail.com>,
	Tomer Maimon <tmaimon77@gmail.com>,
	Tali Perry <tali.perry1@gmail.com>,
	Patrick Venture <venture@google.com>,
	Nancy Yuen <yuenn@google.com>,
	Benjamin Fair <benjaminfair@google.com>,
	Pavel Machek <pavel@ucw.cz>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	linux-csky@vger.kernel.org,
	linux-ia64@vger.kernel.org,
	linux-m68k@lists.linux-m68k.org,
	linux-mips@vger.kernel.org,
	linux-parisc@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-riscv@lists.infradead.org,
	linux-sh@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	linux-acpi@vger.kernel.org,
	linux-omap@vger.kernel.org,
	openbmc@lists.ozlabs.org,
	linux-tegra@vger.kernel.org,
	linux-pm@vger.kernel.org
Subject: [PATCH v2 33/45] mfd: rk808: Use devm_register_simple_power_off_handler()
Date: Thu, 28 Oct 2021 00:17:03 +0300
Message-Id: <20211027211715.12671-34-digetx@gmail.com>
X-Mailer: git-send-email 2.33.1
In-Reply-To: <20211027211715.12671-1-digetx@gmail.com>
References: <20211027211715.12671-1-digetx@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Use devm_register_simple_power_off_handler() that replaces global
pm_power_off variable and allows to register multiple power-off handlers.

Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
 drivers/mfd/rk808.c | 23 +++++++++++------------
 1 file changed, 11 insertions(+), 12 deletions(-)

diff --git a/drivers/mfd/rk808.c b/drivers/mfd/rk808.c
index b181fe401330..3bf369469053 100644
--- a/drivers/mfd/rk808.c
+++ b/drivers/mfd/rk808.c
@@ -18,6 +18,7 @@
 #include <linux/mfd/core.h>
 #include <linux/module.h>
 #include <linux/of_device.h>
+#include <linux/reboot.h>
 #include <linux/regmap.h>
 
 struct rk808_reg_data {
@@ -526,12 +527,11 @@ static const struct regmap_irq_chip rk818_irq_chip = {
 	.init_ack_masked = true,
 };
 
-static struct i2c_client *rk808_i2c_client;
-
-static void rk808_pm_power_off(void)
+static void rk808_pm_power_off(void *data)
 {
 	int ret;
 	unsigned int reg, bit;
+	struct i2c_client *rk808_i2c_client = data;
 	struct rk808 *rk808 = i2c_get_clientdata(rk808_i2c_client);
 
 	switch (rk808->variant) {
@@ -725,8 +725,14 @@ static int rk808_probe(struct i2c_client *client,
 	}
 
 	if (of_property_read_bool(np, "rockchip,system-power-controller")) {
-		rk808_i2c_client = client;
-		pm_power_off = rk808_pm_power_off;
+		ret = devm_register_simple_power_off_handler(&client->dev,
+							     rk808_pm_power_off,
+							     client);
+		if (ret) {
+			dev_err(&client->dev,
+				"failed to register power-off handler %d\n", ret);
+			goto err_irq;
+		}
 	}
 
 	return 0;
@@ -742,13 +748,6 @@ static int rk808_remove(struct i2c_client *client)
 
 	regmap_del_irq_chip(client->irq, rk808->irq_data);
 
-	/**
-	 * pm_power_off may points to a function from another module.
-	 * Check if the pointer is set by us and only then overwrite it.
-	 */
-	if (pm_power_off == rk808_pm_power_off)
-		pm_power_off = NULL;
-
 	return 0;
 }
 
-- 
2.33.1



From xen-devel-bounces@lists.xenproject.org Wed Oct 27 21:29:00 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Oct 2021 21:29:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217366.377518 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfqTZ-0004DJ-7Y; Wed, 27 Oct 2021 21:28:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217366.377518; Wed, 27 Oct 2021 21:28:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfqTY-00044A-F1; Wed, 27 Oct 2021 21:28:48 +0000
Received: by outflank-mailman (input) for mailman id 217366;
 Wed, 27 Oct 2021 21:28:43 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=nMly=PP=gmail.com=digetx@srs-us1.protection.inumbo.net>)
 id 1mfqMU-0000sJ-Dm
 for xen-devel@lists.xenproject.org; Wed, 27 Oct 2021 21:21:30 +0000
Received: from mail-lf1-x12f.google.com (unknown [2a00:1450:4864:20::12f])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id f281c280-7e2c-4b52-8649-7ff7b12073ce;
 Wed, 27 Oct 2021 21:19:00 +0000 (UTC)
Received: by mail-lf1-x12f.google.com with SMTP id bi35so8960334lfb.9
 for <xen-devel@lists.xenproject.org>; Wed, 27 Oct 2021 14:19:00 -0700 (PDT)
Received: from localhost.localdomain (46-138-41-28.dynamic.spd-mgts.ru.
 [46.138.41.28])
 by smtp.gmail.com with ESMTPSA id d7sm104336ljl.18.2021.10.27.14.18.58
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Wed, 27 Oct 2021 14:18:59 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f281c280-7e2c-4b52-8649-7ff7b12073ce
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=/EvvYGeTVCQImKsIJ5eG/5fF3PWyG/w2giRYqfawyD8=;
        b=WISWhItqSg2B7RF+VMq4lOAEaPJboj2meAQ+IB5/V1NHbNJFBmj5XS0xlb4zCXSKCT
         6NsXWHZYq9LRGS+jBn6SfWgsJR2EyLsQBWeeDJtEZfPXB1ZJ5N3cxcINwqw5WxZcKDSN
         DIvIUkbk9mQPYxMXhFN2I7TObVzLJ8eVxU8hzEXgYSzj8Cm7i8BXlPfHwlq3yNPgneQb
         CHkJFZxdfY5RLlI3BGfXo88fraOgWdNEzamQkJbIJD18e+/pItOdQTQl7YVu3LpCjfDV
         vOVdkFjMAfH4ytXgGRWsun/uVtAnjn/uKIwgKMmU3X2UQuuCd1+gugzIIN8JE0FZ4XsA
         8FgQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=/EvvYGeTVCQImKsIJ5eG/5fF3PWyG/w2giRYqfawyD8=;
        b=U+exVGjIuZrTZvaorfdlm/oyMq/hAou4g7Vw/VviOIsVhOIHQaH7ZsgzcBUs7BDYjA
         xraSSIeYu8vLir9B69E23edFmqksnkzkDjlj0XX9iP/YQjAQsOqBvPE2H0o4GgtlRZWU
         hNb8Vt0pzE/X4FnG6j1bTSaVkkiaPKZy4XStEshgOR5EVDgbiCYau9+cgT96W8kxvvjh
         Jes/wNAAN6xcwNzNW7NF/R1UoYY+g3+1Tetx6QyDld+fZiZBt8XbGVa6aKBwJ2veesUB
         ejKBdjDxK1tTRYWB6HttVhUmGEiggrsbBMFOpESh0/WytCeQjzfCZBdMqOkMt4a2eBrR
         KceQ==
X-Gm-Message-State: AOAM533mQDpK4i0E42aqLHLCnefrjicLGCp8rNX3Nr7Sip/m3X9UaPTm
	hees8pr1YHC7aEumg+rfsP4=
X-Google-Smtp-Source: ABdhPJxRCjxAoGlWdRIW6Oj8xz2ri71YJVQnEgFasE3kMNBOfZWQ65DiEYFCvQ3qjpKPcAaJZhmXrA==
X-Received: by 2002:ac2:4c08:: with SMTP id t8mr95028lfq.281.1635369539813;
        Wed, 27 Oct 2021 14:18:59 -0700 (PDT)
From: Dmitry Osipenko <digetx@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Lee Jones <lee.jones@linaro.org>,
	"Rafael J . Wysocki" <rafael@kernel.org>,
	Mark Brown <broonie@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Russell King <linux@armlinux.org.uk>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Ulf Hansson <ulf.hansson@linaro.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Guo Ren <guoren@kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Greg Ungerer <gerg@linux-m68k.org>,
	Joshua Thompson <funaho@jurai.org>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Nick Hu <nickhu@andestech.com>,
	Greentime Hu <green.hu@gmail.com>,
	Vincent Chen <deanbo422@gmail.com>,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	Helge Deller <deller@gmx.de>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Rich Felker <dalias@libc.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Len Brown <lenb@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Chen-Yu Tsai <wens@csie.org>,
	=?UTF-8?q?Jonathan=20Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>,
	Tony Lindgren <tony@atomide.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Vladimir Zapolskiy <vz@mleia.com>,
	Avi Fishman <avifishman70@gmail.com>,
	Tomer Maimon <tmaimon77@gmail.com>,
	Tali Perry <tali.perry1@gmail.com>,
	Patrick Venture <venture@google.com>,
	Nancy Yuen <yuenn@google.com>,
	Benjamin Fair <benjaminfair@google.com>,
	Pavel Machek <pavel@ucw.cz>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	linux-csky@vger.kernel.org,
	linux-ia64@vger.kernel.org,
	linux-m68k@lists.linux-m68k.org,
	linux-mips@vger.kernel.org,
	linux-parisc@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-riscv@lists.infradead.org,
	linux-sh@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	linux-acpi@vger.kernel.org,
	linux-omap@vger.kernel.org,
	openbmc@lists.ozlabs.org,
	linux-tegra@vger.kernel.org,
	linux-pm@vger.kernel.org
Subject: [PATCH v2 36/45] mfd: tps6586x: Use devm_register_simple_power_off_handler()
Date: Thu, 28 Oct 2021 00:17:06 +0300
Message-Id: <20211027211715.12671-37-digetx@gmail.com>
X-Mailer: git-send-email 2.33.1
In-Reply-To: <20211027211715.12671-1-digetx@gmail.com>
References: <20211027211715.12671-1-digetx@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Use devm_register_simple_power_off_handler() that replaces global
pm_power_off variable and allows to register multiple power-off handlers.

Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
 drivers/mfd/tps6586x.c | 21 ++++++++++++++-------
 1 file changed, 14 insertions(+), 7 deletions(-)

diff --git a/drivers/mfd/tps6586x.c b/drivers/mfd/tps6586x.c
index c9303d3d6602..9033ed936d1e 100644
--- a/drivers/mfd/tps6586x.c
+++ b/drivers/mfd/tps6586x.c
@@ -22,6 +22,7 @@
 #include <linux/err.h>
 #include <linux/i2c.h>
 #include <linux/platform_device.h>
+#include <linux/reboot.h>
 #include <linux/regmap.h>
 #include <linux/of.h>
 
@@ -461,9 +462,10 @@ static const struct regmap_config tps6586x_regmap_config = {
 	.cache_type = REGCACHE_RBTREE,
 };
 
-static struct device *tps6586x_dev;
-static void tps6586x_power_off(void)
+static void tps6586x_power_off(void *data)
 {
+	struct device *tps6586x_dev = data;
+
 	if (tps6586x_clr_bits(tps6586x_dev, TPS6586X_SUPPLYENE, EXITSLREQ_BIT))
 		return;
 
@@ -540,6 +542,16 @@ static int tps6586x_i2c_probe(struct i2c_client *client,
 		return ret;
 	}
 
+	if (pdata->pm_off) {
+		ret = devm_register_simple_power_off_handler(&client->dev,
+							     tps6586x_power_off,
+							     &client->dev);
+		if (ret) {
+			dev_err(&client->dev,
+				"failed to register power-off handler: %d\n", ret);
+			return ret;
+		}
+	}
 
 	if (client->irq) {
 		ret = tps6586x_irq_init(tps6586x, client->irq,
@@ -564,11 +576,6 @@ static int tps6586x_i2c_probe(struct i2c_client *client,
 		goto err_add_devs;
 	}
 
-	if (pdata->pm_off && !pm_power_off) {
-		tps6586x_dev = &client->dev;
-		pm_power_off = tps6586x_power_off;
-	}
-
 	return 0;
 
 err_add_devs:
-- 
2.33.1



From xen-devel-bounces@lists.xenproject.org Wed Oct 27 21:29:03 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Oct 2021 21:29:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217372.377537 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfqTd-0005DX-4f; Wed, 27 Oct 2021 21:28:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217372.377537; Wed, 27 Oct 2021 21:28:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfqTc-00059t-He; Wed, 27 Oct 2021 21:28:52 +0000
Received: by outflank-mailman (input) for mailman id 217372;
 Wed, 27 Oct 2021 21:28:49 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=nMly=PP=gmail.com=digetx@srs-us1.protection.inumbo.net>)
 id 1mfqKE-0000sJ-9s
 for xen-devel@lists.xenproject.org; Wed, 27 Oct 2021 21:19:10 +0000
Received: from mail-lf1-x12a.google.com (unknown [2a00:1450:4864:20::12a])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 0b8a1e4b-85eb-4c9e-ba9c-2f8a196adde9;
 Wed, 27 Oct 2021 21:18:21 +0000 (UTC)
Received: by mail-lf1-x12a.google.com with SMTP id u11so9039924lfs.1
 for <xen-devel@lists.xenproject.org>; Wed, 27 Oct 2021 14:18:21 -0700 (PDT)
Received: from localhost.localdomain (46-138-41-28.dynamic.spd-mgts.ru.
 [46.138.41.28])
 by smtp.gmail.com with ESMTPSA id d7sm104336ljl.18.2021.10.27.14.18.19
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Wed, 27 Oct 2021 14:18:20 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0b8a1e4b-85eb-4c9e-ba9c-2f8a196adde9
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=IgdEY3brdUGAcbkVUTuopyRaDKQjmT9IOiG4donLZPs=;
        b=A3JO6VvJimX2FDA0dLxQreYnwNBhx07tWQqQ/SXHhnBPoY3sXPbkG7/+E3nQpmOX0A
         xlWT2EkBKpC8k8ZWfgyhIneFn7gx6l3JU5mZMCJ9Gg2YcXAy3/1zaAAc5fiz8vpe6tlD
         ZvghxSem0XLQoHwdT6xVe9kcSCqZDVrl06JyyBvtaA4P5y8CnmEwrM6jHVXlGrSBhDO0
         o8SePrtzTGOU2c+h0yCzi7vHVuNfd1Z0T1OIQTsX0utpaovYy+QkExsu3rsU1LEkDfsA
         b8P9cl2mQ3B7fspke5UfEwNdCDRC5NS7RaIYXDvPpdxxluddWoVhn2i0iC+LZc0Zjzjl
         nizw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=IgdEY3brdUGAcbkVUTuopyRaDKQjmT9IOiG4donLZPs=;
        b=08iVB7RQGYBcC9LIiw7uhNy98+HvujL5P93s1q88YJbqKGpQ7Awv+XRJGbaPbjJzP5
         SGb5ZnDVnyWtHXpuoDlM/w6WCRBBcC5Cmb8A1c25J7b7xYjxz1kWd+b2736qgGqwV9iR
         Eclw1PBap1h7x91P7IDsXIyugynMEoziMGwJlmj1rKaUYRmBb1z1bgFvQEv1XreHC0kj
         aAnEbhl/X5txrjcdyqgo8wPPE6rpZc9x5H8k7TVT8XjmkpVGYPn9BXzHw8gbnnm/D4Lu
         pJBu9NhtBB8w2PNtWG14FRerdel7ChzjY8oqtQjIBYAIYlSTlljjSTi7ctzjdSLcZ5Wu
         ZEeg==
X-Gm-Message-State: AOAM530PUgffhrAveixWGtV+j+wG2cIWtUsWLnD7H/a0qXczQVPNzy5u
	im4u2GVvHBrXULXefBPNM0o=
X-Google-Smtp-Source: ABdhPJwtMjA7PlvcFRu5kz6vTDm0WOPOzzhi40W0Cp5+CpUA24meJt6Drh8JDJU/Rr1wsTlEzin4/g==
X-Received: by 2002:a05:6512:401f:: with SMTP id br31mr96058lfb.169.1635369500752;
        Wed, 27 Oct 2021 14:18:20 -0700 (PDT)
From: Dmitry Osipenko <digetx@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Lee Jones <lee.jones@linaro.org>,
	"Rafael J . Wysocki" <rafael@kernel.org>,
	Mark Brown <broonie@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Russell King <linux@armlinux.org.uk>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Ulf Hansson <ulf.hansson@linaro.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Guo Ren <guoren@kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Greg Ungerer <gerg@linux-m68k.org>,
	Joshua Thompson <funaho@jurai.org>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Nick Hu <nickhu@andestech.com>,
	Greentime Hu <green.hu@gmail.com>,
	Vincent Chen <deanbo422@gmail.com>,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	Helge Deller <deller@gmx.de>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Rich Felker <dalias@libc.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Len Brown <lenb@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Chen-Yu Tsai <wens@csie.org>,
	=?UTF-8?q?Jonathan=20Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>,
	Tony Lindgren <tony@atomide.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Vladimir Zapolskiy <vz@mleia.com>,
	Avi Fishman <avifishman70@gmail.com>,
	Tomer Maimon <tmaimon77@gmail.com>,
	Tali Perry <tali.perry1@gmail.com>,
	Patrick Venture <venture@google.com>,
	Nancy Yuen <yuenn@google.com>,
	Benjamin Fair <benjaminfair@google.com>,
	Pavel Machek <pavel@ucw.cz>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	linux-csky@vger.kernel.org,
	linux-ia64@vger.kernel.org,
	linux-m68k@lists.linux-m68k.org,
	linux-mips@vger.kernel.org,
	linux-parisc@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-riscv@lists.infradead.org,
	linux-sh@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	linux-acpi@vger.kernel.org,
	linux-omap@vger.kernel.org,
	openbmc@lists.ozlabs.org,
	linux-tegra@vger.kernel.org,
	linux-pm@vger.kernel.org
Subject: [PATCH v2 15/45] nds32: Use do_kernel_power_off()
Date: Thu, 28 Oct 2021 00:16:45 +0300
Message-Id: <20211027211715.12671-16-digetx@gmail.com>
X-Mailer: git-send-email 2.33.1
In-Reply-To: <20211027211715.12671-1-digetx@gmail.com>
References: <20211027211715.12671-1-digetx@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Kernel now supports chained power-off handlers. Use do_kernel_power_off()
that invokes chained power-off handlers. It also invokes legacy
pm_power_off() for now, which will be removed once all drivers will
be converted to the new power-off API.

Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
 arch/nds32/kernel/process.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/nds32/kernel/process.c b/arch/nds32/kernel/process.c
index 49fab9e39cbf..0936dcd7db1b 100644
--- a/arch/nds32/kernel/process.c
+++ b/arch/nds32/kernel/process.c
@@ -54,8 +54,7 @@ EXPORT_SYMBOL(machine_halt);
 
 void machine_power_off(void)
 {
-	if (pm_power_off)
-		pm_power_off();
+	do_kernel_power_off();
 }
 
 EXPORT_SYMBOL(machine_power_off);
-- 
2.33.1



From xen-devel-bounces@lists.xenproject.org Wed Oct 27 21:29:08 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Oct 2021 21:29:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217381.377555 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfqTh-0006Jn-W2; Wed, 27 Oct 2021 21:28:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217381.377555; Wed, 27 Oct 2021 21:28:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfqTh-0006H9-E9; Wed, 27 Oct 2021 21:28:57 +0000
Received: by outflank-mailman (input) for mailman id 217381;
 Wed, 27 Oct 2021 21:28:54 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=nMly=PP=gmail.com=digetx@srs-us1.protection.inumbo.net>)
 id 1mfqMK-0000sJ-DQ
 for xen-devel@lists.xenproject.org; Wed, 27 Oct 2021 21:21:20 +0000
Received: from mail-lj1-x232.google.com (unknown [2a00:1450:4864:20::232])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 7da57f3f-7eb8-46f0-ab3f-75a2e3b9b760;
 Wed, 27 Oct 2021 21:18:57 +0000 (UTC)
Received: by mail-lj1-x232.google.com with SMTP id u5so6967447ljo.8
 for <xen-devel@lists.xenproject.org>; Wed, 27 Oct 2021 14:18:57 -0700 (PDT)
Received: from localhost.localdomain (46-138-41-28.dynamic.spd-mgts.ru.
 [46.138.41.28])
 by smtp.gmail.com with ESMTPSA id d7sm104336ljl.18.2021.10.27.14.18.54
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Wed, 27 Oct 2021 14:18:55 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7da57f3f-7eb8-46f0-ab3f-75a2e3b9b760
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=J0jiL1GV/+pRa/Pi8omBJ059E/kI2yC/kBEGzY3TRbg=;
        b=FJbtoAu7rbq7E5RaKvepyk9plUf7jLnT+ML08UZjLgFiOZ5VaykzHp5Ff2lObAbFB8
         5GZGzZ57ZApIGsXSOF6gLQA97YsI0ZAQ/ZGu34m5aZxcCPPjtIEcQp67CojYOup39/Xv
         xsYx/9Bl6pD+/d5Egre5OsJvj19u3KKVwrkexlOW8n23RNvDolWdvTv8CSXdsnambAlA
         jmNsfq7r35M1wkX74Jgv3A3xCPTBUP4sDGuQeSw9FU1X/TxBftWhWMRe81zJ6SuXHAM8
         TvqOPVU0PykNu+1EXPWfVa52MP/IYJ4S57Q0SiUIct4v8BdbY1Ush4O+dDWBQRJUzf+C
         FQ7A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=J0jiL1GV/+pRa/Pi8omBJ059E/kI2yC/kBEGzY3TRbg=;
        b=dHcADv7uU+wNiNSiWnlJL7NX6jn65nJijzmlWEvvgGnBUh+NUbR4Vdy26OE6JOw+64
         J7Z3xIydOzcWbjHCn6ZJa4NOqOIyiobMyPlvAfT4997NFcrma2Peo+dG9uKnhGVvNdEP
         Akmx4Qay1ptUH4FakaQM3X0n0xxscirrXeMs+kTOrzc6diA5Bz+bA43bTP8+Gxr8619f
         Eulg9j6dn4YOg3qgtAabiMvTN6sJbya2Cas02nf/3nnQfYdWM2Ks0HPC8xsrZkUJrH2L
         WjqBZm5ZY0m6HlMBw6yvS4StIgVe9HybzSeAlb1tvCFMfDnuFgqNSauYsCAUia/GqVi5
         9Rhg==
X-Gm-Message-State: AOAM533gbJOWrxW48lXYAoodtvfh9O8C/IZ+t1V8hzh8f8UAEJyORn14
	q8la2lWLKEnCZjW4fd4lltI=
X-Google-Smtp-Source: ABdhPJwO9DbKrxmMzwfiSQzUITuZHuDXfhRgNgPDDhUghYThRMLe5cQOKy/B7VPBX8OP8l5Jmu7iAw==
X-Received: by 2002:a2e:8097:: with SMTP id i23mr314285ljg.287.1635369536096;
        Wed, 27 Oct 2021 14:18:56 -0700 (PDT)
From: Dmitry Osipenko <digetx@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Lee Jones <lee.jones@linaro.org>,
	"Rafael J . Wysocki" <rafael@kernel.org>,
	Mark Brown <broonie@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Russell King <linux@armlinux.org.uk>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Ulf Hansson <ulf.hansson@linaro.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Guo Ren <guoren@kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Greg Ungerer <gerg@linux-m68k.org>,
	Joshua Thompson <funaho@jurai.org>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Nick Hu <nickhu@andestech.com>,
	Greentime Hu <green.hu@gmail.com>,
	Vincent Chen <deanbo422@gmail.com>,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	Helge Deller <deller@gmx.de>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Rich Felker <dalias@libc.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Len Brown <lenb@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Chen-Yu Tsai <wens@csie.org>,
	=?UTF-8?q?Jonathan=20Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>,
	Tony Lindgren <tony@atomide.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Vladimir Zapolskiy <vz@mleia.com>,
	Avi Fishman <avifishman70@gmail.com>,
	Tomer Maimon <tmaimon77@gmail.com>,
	Tali Perry <tali.perry1@gmail.com>,
	Patrick Venture <venture@google.com>,
	Nancy Yuen <yuenn@google.com>,
	Benjamin Fair <benjaminfair@google.com>,
	Pavel Machek <pavel@ucw.cz>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	linux-csky@vger.kernel.org,
	linux-ia64@vger.kernel.org,
	linux-m68k@lists.linux-m68k.org,
	linux-mips@vger.kernel.org,
	linux-parisc@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-riscv@lists.infradead.org,
	linux-sh@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	linux-acpi@vger.kernel.org,
	linux-omap@vger.kernel.org,
	openbmc@lists.ozlabs.org,
	linux-tegra@vger.kernel.org,
	linux-pm@vger.kernel.org
Subject: [PATCH v2 34/45] mfd: palmas: Use devm_register_simple_power_off_handler()
Date: Thu, 28 Oct 2021 00:17:04 +0300
Message-Id: <20211027211715.12671-35-digetx@gmail.com>
X-Mailer: git-send-email 2.33.1
In-Reply-To: <20211027211715.12671-1-digetx@gmail.com>
References: <20211027211715.12671-1-digetx@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Use devm_register_simple_power_off_handler() that replaces global
pm_power_off variable and allows to register multiple power-off handlers.

Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
 drivers/mfd/palmas.c | 24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/drivers/mfd/palmas.c b/drivers/mfd/palmas.c
index f5b3fa973b13..c7d4d48d2fda 100644
--- a/drivers/mfd/palmas.c
+++ b/drivers/mfd/palmas.c
@@ -14,6 +14,7 @@
 #include <linux/i2c.h>
 #include <linux/interrupt.h>
 #include <linux/irq.h>
+#include <linux/reboot.h>
 #include <linux/regmap.h>
 #include <linux/err.h>
 #include <linux/mfd/core.h>
@@ -420,12 +421,12 @@ static void palmas_dt_to_pdata(struct i2c_client *i2c,
 			"ti,system-power-controller");
 }
 
-static struct palmas *palmas_dev;
-static void palmas_power_off(void)
+static void palmas_power_off(void *data)
 {
 	unsigned int addr;
 	int ret, slave;
 	u8 powerhold_mask;
+	struct palmas *palmas_dev = data;
 	struct device_node *np = palmas_dev->dev->of_node;
 
 	if (of_property_read_bool(np, "ti,palmas-override-powerhold")) {
@@ -680,12 +681,16 @@ static int palmas_i2c_probe(struct i2c_client *i2c,
 	 */
 	if (node) {
 		ret = devm_of_platform_populate(&i2c->dev);
-		if (ret < 0) {
+		if (ret < 0)
+			goto err_irq;
+	}
+
+	if (pdata->pm_off) {
+		ret = devm_register_simple_power_off_handler(&i2c->dev,
+							     palmas_power_off,
+							     palmas);
+		if (ret)
 			goto err_irq;
-		} else if (pdata->pm_off && !pm_power_off) {
-			palmas_dev = palmas;
-			pm_power_off = palmas_power_off;
-		}
 	}
 
 	return ret;
@@ -712,11 +717,6 @@ static int palmas_i2c_remove(struct i2c_client *i2c)
 			i2c_unregister_device(palmas->i2c_clients[i]);
 	}
 
-	if (palmas == palmas_dev) {
-		pm_power_off = NULL;
-		palmas_dev = NULL;
-	}
-
 	return 0;
 }
 
-- 
2.33.1



From xen-devel-bounces@lists.xenproject.org Wed Oct 27 21:44:11 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Oct 2021 21:44:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217483.377569 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfqiC-0003UF-AL; Wed, 27 Oct 2021 21:43:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217483.377569; Wed, 27 Oct 2021 21:43:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfqiC-0003U8-60; Wed, 27 Oct 2021 21:43:56 +0000
Received: by outflank-mailman (input) for mailman id 217483;
 Wed, 27 Oct 2021 21:43:55 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=7RMc=PP=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1mfqiB-0003U2-0F
 for xen-devel@lists.xenproject.org; Wed, 27 Oct 2021 21:43:55 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id b79db595-d8c6-4e4e-87ce-fc959242d51d;
 Wed, 27 Oct 2021 21:43:54 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id 5C2F5610A6;
 Wed, 27 Oct 2021 21:43:53 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b79db595-d8c6-4e4e-87ce-fc959242d51d
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1635371033;
	bh=k/JbqUolIYAJmrAovML5eVa3Ao+2nM5I/2RllYpocSk=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=AWqkKuVtA9PoDvkMf+Qmg289G0N8xQ49/0bQL2D06kFYDsaCZ+4Ch8yLzQwYYjxrA
	 mcSObttUK/MUjvf8wp5t/5RH5IIgPcc0ioywXiAiAZX0FBujUMefkjgs7OfCqeM7U6
	 1EfLDhVITQwlREAmRg2w7u6smv8uFI+VGMTxNQ7mtOUp2aOQhfgwNFt5fgwdF8fIoy
	 RalgCSsMVFIe4MwidZk0iG72P2qZ89Puf4IshWYAP86bB76YIGo1Bx5KGVdz7jIi07
	 o+u6i8ENhCieL7ohfKEsuKyXdIyUk9IaGPprhJc4eRsXTaTEpOSNX3UaEfLNggRK2N
	 s+rJzYkD7cWig==
Date: Wed, 27 Oct 2021 14:43:46 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Anthony PERARD <anthony.perard@citrix.com>, cardoe@cardoe.com
cc: Stefano Stabellini <sstabellini@kernel.org>, 
    xen-devel@lists.xenproject.org, iwj@xenproject.org, wl@xen.org, 
    andrew.cooper3@citrix.com, 
    Stefano Stabellini <stefano.stabellini@xilinx.com>
Subject: Solving the gitlab-ci git fetch issue, was: [PATCH 3/3] automation:
 add a QEMU based x86_64 Dom0/DomU test
In-Reply-To: <YXlbOjiphjN/XqMz@perard>
Message-ID: <alpine.DEB.2.21.2110271437120.20134@sstabellini-ThinkPad-T480s>
References: <alpine.DEB.2.21.2110210831470.2311@sstabellini-ThinkPad-T480s> <20211021230839.10794-3-sstabellini@kernel.org> <YXK2lTWZHiTXIBtJ@perard> <alpine.DEB.2.21.2110221219520.2311@sstabellini-ThinkPad-T480s> <YXbXwjxHPNjSAKrG@perard>
 <alpine.DEB.2.21.2110251754210.4586@sstabellini-ThinkPad-T480s> <YXlbOjiphjN/XqMz@perard>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Wed, 27 Oct 2021, Anthony PERARD wrote:
> > But we do have a severe problem at the moment with external sources: our
> > "git clones" keep failing during the build on x86. That is definitely
> > something worth improving (see my other email thread on the subject) and
> > it is the main problem affecting gitlab-ci at the moment, I keep having
> > to restart jobs almost daily to get the overall pipeline to "pass".
> > 
> > If you have any ideas on how to stop fetching things using "git" from
> > external repositories in gitlab-ci that would be fantastic :-)
> > The only thing I could think of to "fix it" is moving all external repos
> > to gitlab repositories mirrors.
> 
> I don't think that would work, I've seen the initial clone/fetch of a
> job fail as well, so from gitlab. If we could have a cache of those
> external resources closer to the runners, that would be better.

You mean like a git repository mirror inside the Rackspace network (the
provider of the x86 runner), right? Then we would force the git client
to go to the Rackspace mirror instead of directly to the target using
"insteadOf".

Is that what you meant? Doug, do you think it would work?


From xen-devel-bounces@lists.xenproject.org Wed Oct 27 22:09:34 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Oct 2021 22:09:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217497.377580 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfr6l-00065M-89; Wed, 27 Oct 2021 22:09:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217497.377580; Wed, 27 Oct 2021 22:09:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfr6l-00065F-5F; Wed, 27 Oct 2021 22:09:19 +0000
Received: by outflank-mailman (input) for mailman id 217497;
 Wed, 27 Oct 2021 22:09:18 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=EkRf=PP=oderland.se=josef@srs-us1.protection.inumbo.net>)
 id 1mfr6k-000658-9u
 for xen-devel@lists.xenproject.org; Wed, 27 Oct 2021 22:09:18 +0000
Received: from office.oderland.com (unknown [91.201.60.5])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id bd4105ae-b34a-4ea5-8d56-5b94d6000d0a;
 Wed, 27 Oct 2021 22:09:16 +0000 (UTC)
Received: from [193.180.18.161] (port=35522 helo=[10.137.0.14])
 by office.oderland.com with esmtpsa (TLS1.2) tls
 TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2)
 (envelope-from <josef@oderland.se>) id 1mfr6h-00A1Pm-Db
 for xen-devel@lists.xenproject.org; Thu, 28 Oct 2021 00:09:15 +0200
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: bd4105ae-b34a-4ea5-8d56-5b94d6000d0a
Message-ID: <085f23da-3eed-d446-3b9b-ec655db1d3df@oderland.se>
Date: Thu, 28 Oct 2021 00:09:14 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:93.0) Gecko/20100101
 Thunderbird/93.0
Content-Language: en-US
To: xen-devel <xen-devel@lists.xenproject.org>
From: Josef Johansson <josef@oderland.se>
Subject: BUG: arch/x86/mm/tlb.c:522 CR3 is not what we think
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-AntiAbuse: This header was added to track abuse, please include it with any abuse report
X-AntiAbuse: Primary Hostname - office.oderland.com
X-AntiAbuse: Original Domain - lists.xenproject.org
X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12]
X-AntiAbuse: Sender Address Domain - oderland.se
X-Get-Message-Sender-Via: office.oderland.com: authenticated_id: josjoh@oderland.se
X-Authenticated-Sender: office.oderland.com: josjoh@oderland.se

Hi,

During suspend my kernel (v5.15-rc7) tries to disable non-boot CPUs, as it
should. The first time the CPUs are offlined I get a BUG (it's WARN but it
should be BUG if it could). The second time I suspend I get a WARN.

I tried my very best to track what is happening during the first suspend
and my
diagnosis is that:

 * xen is hooking in xen_pv_cpu_disable, when it runs it
load_cr3(swapper_pg_dir)
 * when do_idle is called xen runs play_dead on it, which in turn runs
switch_mm(current->active_mm, &init_mm)
    with the assumption that  active_mm == init_mm.
 * since xen_pv_cpu_disable did not run leave_mm / switch_mm_irqs_off
before
load_cr3
    cr3 is now the disabled CPUs mm and not init_mm.

But obviously there needs to be something specific to my setup here
that's causing these issues. I'm running Ryzen 7 with 8 cores and smt=off.

I've tried to look around for a existing bug about this to no avail.

This bug is for PV (dom0).

My fear is this BUG later lead to problems inside amdgpu
which then effectively kills the screen output during third suspend.

A thought is that the first BUG leads to the next WARN.

Please advise on how I can debug this further
since I'm at my wits end here.

Regards
- Josef

# First suspend
printk: Suspending console(s) (use no_console_suspend to debug)
[drm] free PSP TMR buffer
PM: suspend devices took 0.428 seconds
ACPI: EC: interrupt blocked
ACPI: PM: Preparing to enter system sleep state S3
ACPI: EC: event blocked
ACPI: EC: EC stopped
ACPI: PM: Saving platform NVS memory
Disabling non-boot CPUs ...
------------[ cut here ]------------
WARNING: CPU: 1 PID: 0 at arch/x86/mm/tlb.c:522 switch_mm_irqs_off+0x3c5/0x400
Modules linked in: snd_seq_dummy snd_hrtimer snd_seq snd_seq_device snd_timer nf_tables nfnetlink vfat fat intel_rapl_msr think_lmi firmware_attributes_class wmi_bmof intel_rapl_common pcspkr uvcvideo videobuf2_vmalloc videobuf2_memops joydev videobuf2_v4l2 sp5100_tco k10temp videobuf2_common i2c_piix4 iwlwifi videodev mc cfg80211 thinkpad_acpi ipmi_devintf ucsi_acpi platform_profile typec_ucsi ledtrig_audio ipmi_msghandler r8169 rfkill typec snd wmi soundcore video i2c_scmi fuse xenfs ip_tables dm_thin_pool dm_persistent_data dm_bio_prison dm_crypt trusted asn1_encoder hid_multitouch amdgpu crct10dif_pclmul crc32_pclmul crc32c_intel gpu_sched i2c_algo_bit drm_ttm_helper ghash_clmulni_intel ttm serio_raw drm_kms_helper cec sdhci_pci cqhci sdhci xhci_pci drm xhci_pci_renesas nvme xhci_hcd ehci_pci mmc_core ehci_hcd nvme_core xen_acpi_processor xen_privcmd xen_pciback xen_blkback xen_gntalloc xen_gntdev xen_evtchn uinput
CPU: 1 PID: 0 Comm: swapper/1 Tainted: G        W        --------- ---  5.15.0-0.rc7.0.fc32.qubes.x86_64 #1
Hardware name: LENOVO 20Y1S02400/20Y1S02400, BIOS R1BET65W(1.34 ) 06/17/2021
RIP: e030:switch_mm_irqs_off+0x3c5/0x400
Code: f0 41 80 65 01 fb ba 01 00 00 00 49 8d b5 60 23 00 00 4c 89 ef 49 c7 85 68 23 00 00 60 1d 08 81 e8 a0 f3 08 00 e9 15 fd ff ff <0f> 0b e8 34 fa ff ff e9 ad fc ff ff 0f 0b e9 31 fe ff ff 0f 0b e9
RSP: e02b:ffffc900400f3eb0 EFLAGS: 00010006
RAX: 00000001336c6000 RBX: ffff888140660000 RCX: 0000000000000040
RDX: ffff8881003027c0 RSI: 0000000000000000 RDI: ffff8881b36c6000
RBP: ffffffff829d91c0 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000008 R11: 0000000000000000 R12: ffff888104e88440
R13: ffff8881003027c0 R14: 0000000000000000 R15: 0000000000000001
FS:  0000000000000000(0000) GS:ffff888140640000(0000) knlGS:0000000000000000
CS:  10000e030 DS: 002b ES: 002b CR0: 0000000080050033
CR2: 000060b7d78bf198 CR3: 0000000002810000 CR4: 0000000000050660
Call Trace:
 switch_mm+0x1c/0x30
 idle_task_exit+0x55/0x60
 play_dead_common+0xa/0x20
 xen_pv_play_dead+0xa/0x60
 do_idle+0xd1/0xe0
 cpu_startup_entry+0x19/0x20
 asm_cpu_bringup_and_idle+0x5/0x1000
---[ end trace b068d3cd1b7f5f4b ]---
smpboot: CPU 1 is now offline
smpboot: CPU 2 is now offline
smpboot: CPU 3 is now offline
smpboot: CPU 4 is now offline
smpboot: CPU 5 is now offline
smpboot: CPU 6 is now offline
smpboot: CPU 7 is now offline
ACPI: PM: Low-level resume complete
ACPI: EC: EC started
ACPI: PM: Restoring platform NVS memory
xen_acpi_processor: Uploading Xen processor PM info
xen_acpi_processor: (_PXX): Hypervisor error (-19) for ACPI CPU1
xen_acpi_processor: (_PXX): Hypervisor error (-19) for ACPI CPU3
xen_acpi_processor: (_PXX): Hypervisor error (-19) for ACPI CPU5
xen_acpi_processor: (_PXX): Hypervisor error (-19) for ACPI CPU7
xen_acpi_processor: (_PXX): Hypervisor error (-19) for ACPI CPU9
xen_acpi_processor: (_PXX): Hypervisor error (-19) for ACPI CPU11


# Second suspend
CPU2 is up
installing Xen timer for CPU 3
cpu 3 spinlock event irq 79
[Firmware Bug]: ACPI MWAIT C-state 0x0 not supported by HW (0x0)
ACPI: \_SB_.PLTF.C003: Found 3 idle states
ACPI: FW issue: working around C-state latencies out of order
CPU3 is up
------------[ cut here ]------------
cfs_rq->avg.load_avg || cfs_rq->avg.util_avg || cfs_rq->avg.runnable_avg
installing Xen timer for CPU 4
WARNING: CPU: 3 PID: 455 at kernel/sched/fair.c:3339 __update_blocked_fair+0x49b/0x4b0
Modules linked in: snd_seq_dummy snd_hrtimer snd_seq snd_seq_device snd_timer nf_tables nfnetlink vfat fat intel_rapl_msr think_lmi firmware_attributes_class wmi_bmof intel_rapl_common pcspkr uvcvideo videobuf2_vmalloc videobuf2_memops joydev videobuf2_v4l2 sp5100_tco k10temp videobuf2_common i2c_piix4 iwlwifi videodev mc cfg80211 thinkpad_acpi ipmi_devintf ucsi_acpi platform_profile typec_ucsi ledtrig_audio ipmi_msghandler r8169 rfkill typec snd wmi soundcore video i2c_scmi fuse xenfs ip_tables dm_thin_pool dm_persistent_data dm_bio_prison dm_crypt trusted asn1_encoder hid_multitouch amdgpu crct10dif_pclmul crc32_pclmul crc32c_intel gpu_sched i2c_algo_bit drm_ttm_helper ghash_clmulni_intel ttm serio_raw drm_kms_helper cec sdhci_pci cqhci sdhci xhci_pci drm xhci_pci_renesas nvme xhci_hcd ehci_pci mmc_core ehci_hcd nvme_core xen_acpi_processor xen_privcmd xen_pciback xen_blkback xen_gntalloc xen_gntdev xen_evtchn uinput
CPU: 3 PID: 455 Comm: kworker/3:2 Tainted: G        W        --------- ---  5.15.0-0.rc7.0.fc32.qubes.x86_64 #1
Hardware name: LENOVO 20Y1S02400/20Y1S02400, BIOS R1BET65W(1.34 ) 06/17/2021
Workqueue:  0x0 (events)
RIP: e030:__update_blocked_fair+0x49b/0x4b0
Code: 6b fd ff ff 49 8b 96 48 01 00 00 48 89 90 50 09 00 00 e9 ff fc ff ff 48 c7 c7 10 7a 5e 82 c6 05 f3 35 9e 01 01 e8 1f f3 b2 00 <0f> 0b 41 8b 86 38 01 00 00 e9 c6 fc ff ff 0f 1f 80 00 00 00 00 0f
RSP: e02b:ffffc900410d7ce0 EFLAGS: 00010082
RAX: 0000000000000000 RBX: 0000000000000018 RCX: ffff8881406d8a08
RDX: 00000000ffffffd8 RSI: 0000000000000027 RDI: ffff8881406d8a00
RBP: ffff8881406e9800 R08: 0000000000000048 R09: ffffc900410d7c78
R10: 0000000000000049 R11: 000000002d2d2d2d R12: ffff8881406e9f80
R13: ffff8881406e9e40 R14: ffff8881406e96c0 R15: 0000000000000000
FS:  0000000000000000(0000) GS:ffff8881406c0000(0000) knlGS:0000000000000000
CS:  10000e030 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 0000782e51820000 CR3: 0000000002810000 CR4: 0000000000050660
Call Trace:
 update_blocked_averages+0xa8/0x180
 newidle_balance+0x175/0x380
 pick_next_task_fair+0x39/0x3e0
 pick_next_task+0x4c/0xbd0
 ? dequeue_task_fair+0xba/0x390
 __schedule+0x13a/0x570
 schedule+0x44/0xa0
 worker_thread+0xc0/0x320
 ? process_one_work+0x390/0x390
 kthread+0x10f/0x130
 ? set_kthread_struct+0x40/0x40
 ret_from_fork+0x22/0x30
---[ end trace b068d3cd1b7f5f4c ]---
cpu 4 spinlock event irq 85
[Firmware Bug]: ACPI MWAIT C-state 0x0 not supported by HW (0x0)
ACPI: \_SB_.PLTF.C004: Found 3 idle states
ACPI: FW issue: working around C-state latencies out of order
CPU4 is up
installing Xen timer for CPU 5
cpu 5 spinlock event irq 91
[Firmware Bug]: ACPI MWAIT C-state 0x0 not supported by HW (0x0)
ACPI: \_SB_.PLTF.C005: Found 3 idle states
ACPI: FW issue: working around C-state latencies out of order
CPU5 is up



From xen-devel-bounces@lists.xenproject.org Wed Oct 27 22:45:16 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Oct 2021 22:45:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217508.377590 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfrex-0001oK-3Z; Wed, 27 Oct 2021 22:44:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217508.377590; Wed, 27 Oct 2021 22:44:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfrex-0001oD-0f; Wed, 27 Oct 2021 22:44:39 +0000
Received: by outflank-mailman (input) for mailman id 217508;
 Wed, 27 Oct 2021 22:44:37 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=7RMc=PP=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1mfrev-0001o7-Om
 for xen-devel@lists.xenproject.org; Wed, 27 Oct 2021 22:44:37 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id fdcd4a46-f96e-49f3-bed3-53bceeb31ec9;
 Wed, 27 Oct 2021 22:44:36 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id B2744600D3;
 Wed, 27 Oct 2021 22:44:35 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fdcd4a46-f96e-49f3-bed3-53bceeb31ec9
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1635374676;
	bh=lBCpNJsMYfrZdJ5KdC8o4vtet7JfCHWffWxijhofpDg=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=bLemXR+aNahY+IUON0o+irgAoSOIesri3u5rHYWrK1zTZDX2wipL6dPtugY1iWyMb
	 U/zGbC509YmXxAzaJ/nodti5lve3pcN0yEb2vjmbl/SF8ytecfHQw+r4w9CdtCcTbv
	 woHt5XDcUYU1Q4xttTlDB7OE07lxBItHumO1qODnOlPLRGVuiK2z0UQzQJv3zK2fwc
	 u8UknqfZlwfRyOYE79ENFnz3x03+ikIrfFY0F3iAmGiMvx8Tk+B2zyonYjSOuC+/AZ
	 FG4clKFvY/8Z76ZvjzCiu4jSutm2ZyprYptuB0suzKwq8PvZ3Fj2Uoe9cgokFp4dj0
	 2YvJy4Rz/NUFg==
Date: Wed, 27 Oct 2021 15:44:34 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Juergen Gross <jgross@suse.com>
cc: Stefano Stabellini <sstabellini@kernel.org>, 
    Andrew Cooper <andrew.cooper3@citrix.com>, xen-devel@lists.xenproject.org, 
    iwj@xenproject.org, cardoe@cardoe.com, wl@xen.org, 
    anthony.perard@citrix.com, 
    Stefano Stabellini <stefano.stabellini@xilinx.com>
Subject: Re: [PATCH 2/3] automation: Linux 5.10.74 test-artifact
In-Reply-To: <8c0a2a97-04ab-4836-fc35-026dd7c122a4@suse.com>
Message-ID: <alpine.DEB.2.21.2110271543150.20134@sstabellini-ThinkPad-T480s>
References: <alpine.DEB.2.21.2110210831470.2311@sstabellini-ThinkPad-T480s> <20211021230839.10794-2-sstabellini@kernel.org> <19aa9196-eb5f-22a1-206c-c9c87ee79fa9@citrix.com> <alpine.DEB.2.21.2110221219300.2311@sstabellini-ThinkPad-T480s>
 <d559b765-9e38-00bd-039b-9c33845b8e54@suse.com> <alpine.DEB.2.21.2110251753200.4586@sstabellini-ThinkPad-T480s> <8c0a2a97-04ab-4836-fc35-026dd7c122a4@suse.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="8323329-1561552572-1635374676=:20134"

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-1561552572-1635374676=:20134
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT

On Wed, 27 Oct 2021, Juergen Gross wrote:
> On 26.10.21 02:54, Stefano Stabellini wrote:
> > On Mon, 25 Oct 2021, Juergen Gross wrote:
> > > On 22.10.21 21:41, Stefano Stabellini wrote:
> > > > +Juergen
> > > > 
> > > > On Fri, 22 Oct 2021, Andrew Cooper wrote:
> > > > > On 22/10/2021 00:08, Stefano Stabellini wrote:
> > > > > > +# build depends
> > > > > > +RUN apt-get update && \
> > > > > > +    apt-get --quiet --yes install \
> > > > > > +        build-essential \
> > > > > > +        libssl-dev \
> > > > > > +        bc \
> > > > > > +        curl \
> > > > > > +        flex \
> > > > > > +        bison \
> > > > > > +        libelf-dev \
> > > > > > +        && \
> > > > > > +    \
> > > > > > +    # Build the kernel
> > > > > > +    curl -fsSLO
> > > > > > https://cdn.kernel.org/pub/linux/kernel/v5.x/linux-"$LINUX_VERSION".tar.xz
> > > > > > && \
> > > > > > +    tar xvJf linux-"$LINUX_VERSION".tar.xz && \
> > > > > > +    cd linux-"$LINUX_VERSION" && \
> > > > > > +    make defconfig && \
> > > > > > +    make xen.config && \
> > > > > > +    cp .config .config.orig && \
> > > > > > +    cat .config.orig | grep XEN | grep =m |sed 's/=m/=y/g' >>
> > > > > > .config
> > > > > > && \
> > > > > > +    make -j$(nproc) bzImage && \
> > > > > 
> > > > > defconfig is huuuuge.  Can we use tinyconfig instead?
> > > > > 
> > > > > Also, you want to turn off CONFIG_MODULES seeing as you only copy
> > > > > bzImage to the test.
> > > > > 
> > > > > This also fixes the fact that `grep XEN` also matches
> > > > > CONFIG_NETXEN_NIC
> > > > > which has nothing to do with Xen.
> > > > 
> > > > Tinyconfig would be a good idea but it crashes on QEMU with the appended
> > > > boot log. I did:
> > > > 
> > > > # make tinyconfig
> > > > # make xen.config
> > > > # make bzImage
> > > > 
> > > > Of course we could have our own tailored special kernel config for this
> > > > kernel but I like the simplicify of "make tinyconfig" or "make
> > > > defconfig" followed by "make xen.config".
> > > > 
> > > > Unless you know one kconfig option or two that we need to add to
> > > > tinyconfig to make it work my preference is to go with defconfig for
> > > > now.
> > > 
> > > You will need to add the dom0 and SMP related config options at least.
> > > 
> > > I'll have a look at config.xen, which is a little bit weird: it
> > > configures the backends, but not dom0.
> > 
> > Thanks, it would be good if make tinyconfig && make xen.config would
> > just work on QEMU. In the meantime I'll keep defconfig for this test, we
> > can always improve later.
> 
> Can you please test the attached patch?

Yes, that works, thanks!

We don't currently have any patches under automation/ but I guess I
could add this patch under automation/tests-artifacts/kernel/

Cheers,

Stefano
--8323329-1561552572-1635374676=:20134--


From xen-devel-bounces@lists.xenproject.org Wed Oct 27 23:14:42 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Oct 2021 23:14:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217517.377602 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfs7r-00059B-K3; Wed, 27 Oct 2021 23:14:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217517.377602; Wed, 27 Oct 2021 23:14:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfs7r-000594-FL; Wed, 27 Oct 2021 23:14:31 +0000
Received: by outflank-mailman (input) for mailman id 217517;
 Wed, 27 Oct 2021 23:14:30 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=7RMc=PP=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1mfs7q-00058v-6v
 for xen-devel@lists.xenproject.org; Wed, 27 Oct 2021 23:14:30 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id a27092dc-377b-11ec-848a-12813bfff9fa;
 Wed, 27 Oct 2021 23:14:29 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id 33D9661073;
 Wed, 27 Oct 2021 23:14:28 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a27092dc-377b-11ec-848a-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1635376468;
	bh=ZxsRB9KDMD7vo3PWeIPjNbL9zMu2Gc6zvpMQSYEYrCE=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=bqBWZrzOrE7EKghJyMpRBdqiGSvnZCVC9F8eIzC32x+bEqmUjXF/IbKFFKtgjoZpS
	 3UpvRDI1g7Ev/txKY+fWL2/qlOkMZuEMExepdOoNeBSypieBVIoQrRD5ELn5LtT89U
	 CVpDVoomWSm+LHyP+0cioGtfaeP+gq9GwhRjLUOgqo3XRr+AWR+oF9c0z5Ans6fbSb
	 pPqeynqgT+mqxP8ADjE6F5cju4NjQI733czmC6RxdNgH4vx1W/ntbma14t8lD9w1al
	 gm62Vniwj9VcTBJ/ou3GwfwIMw0gz3UGM1EyrKDEFmnX60PsZHi+055RTvpVYkMM8A
	 IawtkiYNY5o5g==
Date: Wed, 27 Oct 2021 16:14:26 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Julien Grall <julien@xen.org>
cc: Michal Orzel <michal.orzel@arm.com>, xen-devel@lists.xenproject.org, 
    Stefano Stabellini <sstabellini@kernel.org>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, bertrand.marquis@arm.com, 
    Ian Jackson <iwj@xenproject.org>
Subject: Re: [patch-4.16] arm/smmuv1,v2: Protect smmu master list with a
 lock
In-Reply-To: <01545115-e82e-2a9d-a8e4-da9676080c0f@xen.org>
Message-ID: <alpine.DEB.2.21.2110271557570.20134@sstabellini-ThinkPad-T480s>
References: <20211026122903.15042-1-michal.orzel@arm.com> <e5632a4e-db98-41b4-1045-2b3532c098fa@xen.org> <70c30a6c-b779-805e-079a-41bb484894b9@xen.org> <cb452c0c-ccde-7798-c403-f972b48a2c46@arm.com> <01545115-e82e-2a9d-a8e4-da9676080c0f@xen.org>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="8323329-507483422-1635376468=:20134"

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-507483422-1635376468=:20134
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT

On Wed, 27 Oct 2021, Julien Grall wrote:
> > > > > +    return ret;
> > > > >    }
> > > > >    static int register_smmu_master(struct arm_smmu_device *smmu,
> > > > > @@ -2056,7 +2066,10 @@ static int arm_smmu_add_device(struct device
> > > > > *dev)
> > > > >        } else {
> > > > >            struct arm_smmu_master *master;
> > > > > +        spin_lock(&arm_smmu_devices_lock);
> > > > >            master = find_smmu_master(smmu, dev->of_node);
> > > > > +        spin_unlock(&arm_smmu_devices_lock);
> > > > 
> > > > At the moment, unlocking here is fine because we don't remove the
> > > > device. However, there are a series to supporting removing a device (see
> > > > [1]). So I think it would be preferable to unlock after the last use of
> > > > 'cfg'.
> > > > 
> > Ok. I will move unlocking to the end of this else {} block. I was not aware
> > of the patch you are referring to.
> 
> I think the end of the else is still too early. This needs to at least be past
> iommu_group_set_iommudata() because we store cfg.
> 
> Potentially, the lock wants to also englobe arm_smmu_master_alloc_smes(). So I
> am wondering whether it would be simpler to hold the lock for the whole
> duration of arm_smmu_add_device() (I can see value when we will want to
> interlock with the remove code).

The patch was to protect the smmu master list. From that point of view
the unlock right after find_smmu_master would be sufficient, right?

We only need to protect cfg if we are worried that the same device is
added in two different ways at the same time. Did I get it right? If so,
I would say that that case should not be possible? Am I missing another
potential conflict?


I am pointing this out for two reasons:

Protecting the list is different from protecting each element from
concurrent modification of the element itself. If the latter is a
potential problem, I wonder if arm_smmu_add_device is the only function
affected?

The second reason is that extending the lock past
arm_smmu_master_alloc_smes is a bit worrying because it causes
&arm_smmu_devices_lock and smmu->stream_map_lock to nest, which wasn't
the case before.

I am not saying that it is a bad idea to extend the lock past
arm_smmu_master_alloc_smes -- it might be the right thing to do. But I
am merely saying that it might be best to think twice about it and/or do
that after 4.16.
--8323329-507483422-1635376468=:20134--


From xen-devel-bounces@lists.xenproject.org Wed Oct 27 23:25:04 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Oct 2021 23:25:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217526.377613 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfsHq-0006em-IZ; Wed, 27 Oct 2021 23:24:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217526.377613; Wed, 27 Oct 2021 23:24:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfsHq-0006ef-Ep; Wed, 27 Oct 2021 23:24:50 +0000
Received: by outflank-mailman (input) for mailman id 217526;
 Wed, 27 Oct 2021 23:24:49 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=7RMc=PP=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1mfsHp-0006eZ-Fq
 for xen-devel@lists.xenproject.org; Wed, 27 Oct 2021 23:24:49 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 126a9885-377d-11ec-848c-12813bfff9fa;
 Wed, 27 Oct 2021 23:24:48 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id 4BF9D603E8;
 Wed, 27 Oct 2021 23:24:47 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 126a9885-377d-11ec-848c-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1635377087;
	bh=HqmB7XSKiNR8LhBrGOSnCWkHbJVha25DbfIuQCSttv0=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=HnIn6fW7qeVOaXndJ4oFNqapU1vnAmstq6F7ssEJPN1tM6Zn0GcIfYPNkSDXB8V8v
	 bkAWqtcTWyS856ltsT4zqvZFsDyqE+9fiqlgiyK38lHHCZTOASReAGjWtoBE5ydqs3
	 DpxXM6iVfspkYkisgW1vaRJZ6mUMvHWJM8EcLOaa8Tl4Y6iHaLY8EoY/RjSdsc+k/0
	 hA7nMjLK/Ty3KE5mD7DNfa7v1iwTDfh76y9WLOfMxOAoN2/+82ozbByPZJm1rJsF/h
	 TlzmhYcxZ0TdCCuOveAPEtoHu4Tj/DGfZQtdr2fApptXdl/Zg1kIAilrq+TfnAbN36
	 aLAoh2JSCIHCQ==
Date: Wed, 27 Oct 2021 16:24:46 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Stefano Stabellini <sstabellini@kernel.org>
cc: Juergen Gross <jgross@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>, 
    xen-devel@lists.xenproject.org, iwj@xenproject.org, cardoe@cardoe.com, 
    wl@xen.org, anthony.perard@citrix.com, 
    Stefano Stabellini <stefano.stabellini@xilinx.com>
Subject: Re: [PATCH 2/3] automation: Linux 5.10.74 test-artifact
In-Reply-To: <alpine.DEB.2.21.2110271543150.20134@sstabellini-ThinkPad-T480s>
Message-ID: <alpine.DEB.2.21.2110271619240.20134@sstabellini-ThinkPad-T480s>
References: <alpine.DEB.2.21.2110210831470.2311@sstabellini-ThinkPad-T480s> <20211021230839.10794-2-sstabellini@kernel.org> <19aa9196-eb5f-22a1-206c-c9c87ee79fa9@citrix.com> <alpine.DEB.2.21.2110221219300.2311@sstabellini-ThinkPad-T480s>
 <d559b765-9e38-00bd-039b-9c33845b8e54@suse.com> <alpine.DEB.2.21.2110251753200.4586@sstabellini-ThinkPad-T480s> <8c0a2a97-04ab-4836-fc35-026dd7c122a4@suse.com> <alpine.DEB.2.21.2110271543150.20134@sstabellini-ThinkPad-T480s>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="8323329-1515627719-1635377087=:20134"

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-1515627719-1635377087=:20134
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT

On Wed, 27 Oct 2021, Stefano Stabellini wrote:
> On Wed, 27 Oct 2021, Juergen Gross wrote:
> > On 26.10.21 02:54, Stefano Stabellini wrote:
> > > On Mon, 25 Oct 2021, Juergen Gross wrote:
> > > > On 22.10.21 21:41, Stefano Stabellini wrote:
> > > > > +Juergen
> > > > > 
> > > > > On Fri, 22 Oct 2021, Andrew Cooper wrote:
> > > > > > On 22/10/2021 00:08, Stefano Stabellini wrote:
> > > > > > > +# build depends
> > > > > > > +RUN apt-get update && \
> > > > > > > +    apt-get --quiet --yes install \
> > > > > > > +        build-essential \
> > > > > > > +        libssl-dev \
> > > > > > > +        bc \
> > > > > > > +        curl \
> > > > > > > +        flex \
> > > > > > > +        bison \
> > > > > > > +        libelf-dev \
> > > > > > > +        && \
> > > > > > > +    \
> > > > > > > +    # Build the kernel
> > > > > > > +    curl -fsSLO
> > > > > > > https://cdn.kernel.org/pub/linux/kernel/v5.x/linux-"$LINUX_VERSION".tar.xz
> > > > > > > && \
> > > > > > > +    tar xvJf linux-"$LINUX_VERSION".tar.xz && \
> > > > > > > +    cd linux-"$LINUX_VERSION" && \
> > > > > > > +    make defconfig && \
> > > > > > > +    make xen.config && \
> > > > > > > +    cp .config .config.orig && \
> > > > > > > +    cat .config.orig | grep XEN | grep =m |sed 's/=m/=y/g' >>
> > > > > > > .config
> > > > > > > && \
> > > > > > > +    make -j$(nproc) bzImage && \
> > > > > > 
> > > > > > defconfig is huuuuge.  Can we use tinyconfig instead?
> > > > > > 
> > > > > > Also, you want to turn off CONFIG_MODULES seeing as you only copy
> > > > > > bzImage to the test.
> > > > > > 
> > > > > > This also fixes the fact that `grep XEN` also matches
> > > > > > CONFIG_NETXEN_NIC
> > > > > > which has nothing to do with Xen.
> > > > > 
> > > > > Tinyconfig would be a good idea but it crashes on QEMU with the appended
> > > > > boot log. I did:
> > > > > 
> > > > > # make tinyconfig
> > > > > # make xen.config
> > > > > # make bzImage
> > > > > 
> > > > > Of course we could have our own tailored special kernel config for this
> > > > > kernel but I like the simplicify of "make tinyconfig" or "make
> > > > > defconfig" followed by "make xen.config".
> > > > > 
> > > > > Unless you know one kconfig option or two that we need to add to
> > > > > tinyconfig to make it work my preference is to go with defconfig for
> > > > > now.
> > > > 
> > > > You will need to add the dom0 and SMP related config options at least.
> > > > 
> > > > I'll have a look at config.xen, which is a little bit weird: it
> > > > configures the backends, but not dom0.
> > > 
> > > Thanks, it would be good if make tinyconfig && make xen.config would
> > > just work on QEMU. In the meantime I'll keep defconfig for this test, we
> > > can always improve later.
> > 
> > Can you please test the attached patch?
> 
> Yes, that works, thanks!

Sorry, I spoke too soon: same error as before:

https://gitlab.com/xen-project/people/sstabellini/xen/-/jobs/1722909607/raw

(XEN) Hardware Dom0 crashed: rebooting machine in 5 seconds.

No output from the kernel.

By the way you can repro this at your end by doing the following:

# docker run -v /tmp:/tmp registry.gitlab.com/xen-project/xen/debian:stretch

Then inside the container follow pretty much what this script does:

xen.git/automation/scripts/qemu-alpine-x86_64.sh

For instance, you can do:

---
cat >> binaries/pxelinux.0 << EOF
#!ipxe

kernel /tmp/xen console=com1
module /tmp/bzImage console=hvc0
module /tmp/xen-rootfs.cpio.gz
boot
EOF

qemu-system-x86_64 \
    -cpu qemu64,+svm \
    -m 2G -smp 2 \
    -monitor none -serial stdio \
    -nographic \
    -device virtio-net-pci,netdev=n0 \
    -netdev user,id=n0,tftp=binaries,bootfile=/pxelinux.0
---

Just place your xen, bzImage and xen-rootfs.cpio.gz (the rootfs is not
required) binaries under /tmp and you are good to go.

Cheers,

Stefano
--8323329-1515627719-1635377087=:20134--


From xen-devel-bounces@lists.xenproject.org Wed Oct 27 23:26:52 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Oct 2021 23:26:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217533.377624 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfsJd-0007HG-Tc; Wed, 27 Oct 2021 23:26:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217533.377624; Wed, 27 Oct 2021 23:26:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfsJd-0007H9-QR; Wed, 27 Oct 2021 23:26:41 +0000
Received: by outflank-mailman (input) for mailman id 217533;
 Wed, 27 Oct 2021 23:26:40 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=7RMc=PP=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1mfsJc-0007H1-Fx
 for xen-devel@lists.xenproject.org; Wed, 27 Oct 2021 23:26:40 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 5ef3e9c5-40a3-4d8d-9565-cce436c1c195;
 Wed, 27 Oct 2021 23:26:39 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id 88C25603E8;
 Wed, 27 Oct 2021 23:26:38 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5ef3e9c5-40a3-4d8d-9565-cce436c1c195
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1635377199;
	bh=UwG3nGU7iQVLhkp+Nj2/VLD26FJbiYfUpKXWLSkCa0c=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=o7o0TPin+LcwXywwXuZZqTSWBJRcdtpYq/uQEQBnjoV+B5aZVDmFMjzL/c8lkj1AY
	 Q/NxL2ZjaIVp5LD5AFNOxql9z8Od/EOq9ModO5HuXqIJMhY/b4kTH9SvxwsS7NrH+m
	 GtkcNPe0y/e8T3v9bGeBknSGGHaAtBn2K6zZ4AC54vftVJW3CbmCpccgMomE8NWbsl
	 yFVv2G8JitBxONh0ax9/aOyiffUVd0eHKjG0MeHrCuwJUTWsA/Jr0Cjocq88BfAsFc
	 eDbUbjXUzgi9CcJ7WHHFaVW8S9/9aWY3BnxK/czTxpH4IYdfR0yKTyNk3awHpCl9y1
	 kCj/9Fjmw10cw==
Date: Wed, 27 Oct 2021 16:26:37 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Anthony PERARD <anthony.perard@citrix.com>
cc: Stefano Stabellini <sstabellini@kernel.org>, 
    xen-devel@lists.xenproject.org, iwj@xenproject.org, cardoe@cardoe.com, 
    wl@xen.org, andrew.cooper3@citrix.com, 
    Stefano Stabellini <stefano.stabellini@xilinx.com>
Subject: Re: [PATCH v2 3/3] automation: add a QEMU based x86_64 Dom0/DomU
 test
In-Reply-To: <YXleke8ciibv/1qt@perard>
Message-ID: <alpine.DEB.2.21.2110271429370.20134@sstabellini-ThinkPad-T480s>
References: <alpine.DEB.2.21.2110251836020.4586@sstabellini-ThinkPad-T480s> <20211026014200.32102-3-sstabellini@kernel.org> <YXleke8ciibv/1qt@perard>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Wed, 27 Oct 2021, Anthony PERARD wrote:
> On Mon, Oct 25, 2021 at 06:42:00PM -0700, Stefano Stabellini wrote:
> > From: Stefano Stabellini <stefano.stabellini@xilinx.com>
> > 
> > Introduce a test based on QEMU to run Xen, Dom0 and start a DomU.
> > This is similar to the existing qemu-alpine-arm64.sh script and test.
> > The only differences are:
> > - use Debian's qemu-system-x86_64 (on ARM we build our own)
> > - use ipxe instead of u-boot and ImageBuilder
> > 
> > Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>
> > ---
> >  automation/gitlab-ci/test.yaml           | 24 ++++++
> >  automation/scripts/qemu-alpine-x86_64.sh | 95 ++++++++++++++++++++++++
> >  2 files changed, 119 insertions(+)
> >  create mode 100755 automation/scripts/qemu-alpine-x86_64.sh
> > 
> > diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.yaml
> > index 91a10febbf..43d248a604 100644
> > --- a/automation/gitlab-ci/test.yaml
> > +++ b/automation/gitlab-ci/test.yaml
> > @@ -47,6 +47,30 @@ qemu-alpine-arm64-gcc:
> >      - /^coverity-tested\/.*/
> >      - /^stable-.*/
> >  
> > +qemu-alpine-x86_64-gcc:
> > +  stage: test
> > +  image: registry.gitlab.com/xen-project/xen/${CONTAINER}
> > +  variables:
> > +    CONTAINER: debian:stretch
> > +  script:
> > +    - ./automation/scripts/qemu-alpine-x86_64.sh 2>&1 | tee qemu-smoke-arm64.log
> 
> Maybe the log file should be called "qemu-smoke-x86_64.log" ? Or just
> "qemu-smoke.log"?

Good catch! This could be fixed on commit.

 
> I'm still not happy about the `apt install` in the middle of the test,
> but I guess that will do for now:
> 
> Reviewed-by: Anthony PERARD <anthony.perard@citrix.com>

Thanks!

Now the series is fully acked and Ian gave his reviewed-by. If people
are OK with that I could commit it in a couple of days (and by the end
of this week).


From xen-devel-bounces@lists.xenproject.org Wed Oct 27 23:44:03 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Oct 2021 23:44:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217540.377635 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfsa0-0001Ag-BD; Wed, 27 Oct 2021 23:43:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217540.377635; Wed, 27 Oct 2021 23:43:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfsa0-0001AZ-7T; Wed, 27 Oct 2021 23:43:36 +0000
Received: by outflank-mailman (input) for mailman id 217540;
 Wed, 27 Oct 2021 23:43:34 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=M2QJ=PP=gmail.com=julien.grall.oss@srs-us1.protection.inumbo.net>)
 id 1mfsZy-0001AT-Ir
 for xen-devel@lists.xenproject.org; Wed, 27 Oct 2021 23:43:34 +0000
Received: from mail-ed1-x52a.google.com (unknown [2a00:1450:4864:20::52a])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id c9b44d32-10d9-49d4-9fda-ce52ad41b8d5;
 Wed, 27 Oct 2021 23:43:33 +0000 (UTC)
Received: by mail-ed1-x52a.google.com with SMTP id h7so17521846ede.8
 for <xen-devel@lists.xenproject.org>; Wed, 27 Oct 2021 16:43:32 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c9b44d32-10d9-49d4-9fda-ce52ad41b8d5
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=pr1lHcILu5PgQxs5HmyhZz21UrEMCu2I7pDsA/XCmJY=;
        b=cHxwYVvjPra1gE8sr+DGWWdcllNj4zjInOxCE0FL1cj6/hts1YnezgwkOyjT5X6hMm
         irysgpModoGqw2ieDPWIBJlmJLJMyOKAFoLs/Lqf/GKfQjS127/pzD2lcx1t1QkqRZpr
         AmsYLx9Y72AP6PptZjh0fUCATVLubx4jAAMjoY4nCEy6oyhOf151RG9bElVwRtd3lUvQ
         BKc7X3j1RNwjNfydn/QldSzElQCmRdlGPdNM7I4OHWpD7GctCqECApW35OjV+hIJF7vZ
         N1SJX7+MscEug+0FKlqWvvm0XR8WVHO9YQX+ai6SvBB1hKoh7GUaiIgzmy2lqWkYskco
         i3ZQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=pr1lHcILu5PgQxs5HmyhZz21UrEMCu2I7pDsA/XCmJY=;
        b=MyvaKUTEa1PfaHArWsyeY1DyHE6lSFa+F2YpKhUf14kpbhKvqOdxPHkPiGsv0+qTWa
         3Yl5htpWB76re0oODLAK3IN4KuZXPs5VbUbmYISI13Yaov1LQTsJAAOQKrXeXPrQDVOQ
         x/HgxMQG1Xl+BuzNdUavAxrBxI11HLnq+UPHxnFame9ETAfd4SuF1lSXKk2BaKGrUnP5
         QHiZDw1VLUR74txuCQwnGwMlVvhJIfnck+6NNyuo/5DWnGeQNGWj90d8MaraCFY6DMFD
         nkTOWAQB9uYk3L4Lt0zstdK6ayQZBRcdyPeIln362J6pFiHNWen0oEU/gelE64xywJXz
         RhGQ==
X-Gm-Message-State: AOAM533cnpa3xIow80Gufz0+qgGP48+fcT/h/jSURB46nl86DfJmV5m6
	HAmFtfs48JxZdXjY/wRobxzl/LHOiAKFG4euLxw=
X-Google-Smtp-Source: ABdhPJwNEyvChWLU0N+xe6DkvT/POTswZ6UvWq26GVKs7+o0wErybuNkuIM7d3QyE1e0R+L5r6n0GrY3wWIiLpgcOD4=
X-Received: by 2002:aa7:de8f:: with SMTP id j15mr1227294edv.347.1635378212143;
 Wed, 27 Oct 2021 16:43:32 -0700 (PDT)
MIME-Version: 1.0
References: <20211026122903.15042-1-michal.orzel@arm.com> <e5632a4e-db98-41b4-1045-2b3532c098fa@xen.org>
 <70c30a6c-b779-805e-079a-41bb484894b9@xen.org> <cb452c0c-ccde-7798-c403-f972b48a2c46@arm.com>
 <01545115-e82e-2a9d-a8e4-da9676080c0f@xen.org> <alpine.DEB.2.21.2110271557570.20134@sstabellini-ThinkPad-T480s>
In-Reply-To: <alpine.DEB.2.21.2110271557570.20134@sstabellini-ThinkPad-T480s>
From: Julien Grall <julien.grall.oss@gmail.com>
Date: Thu, 28 Oct 2021 00:43:21 +0100
Message-ID: <CAJ=z9a2SSgG7a87_xTGT5LeNLgubOLQf1+dbnrsTsP8_p5ErJg@mail.gmail.com>
Subject: Re: [patch-4.16] arm/smmuv1,v2: Protect smmu master list with a lock
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: Michal Orzel <michal.orzel@arm.com>, xen-devel <xen-devel@lists.xenproject.org>, 
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, Bertrand Marquis <bertrand.marquis@arm.com>, 
	Ian Jackson <iwj@xenproject.org>
Content-Type: multipart/alternative; boundary="00000000000068854805cf5e29f9"

--00000000000068854805cf5e29f9
Content-Type: text/plain; charset="UTF-8"

On Thu, 28 Oct 2021, 00:14 Stefano Stabellini, <sstabellini@kernel.org>
wrote:

> On Wed, 27 Oct 2021, Julien Grall wrote:
> > > > > > +    return ret;
> > > > > >    }
> > > > > >    static int register_smmu_master(struct arm_smmu_device *smmu,
> > > > > > @@ -2056,7 +2066,10 @@ static int arm_smmu_add_device(struct
> device
> > > > > > *dev)
> > > > > >        } else {
> > > > > >            struct arm_smmu_master *master;
> > > > > > +        spin_lock(&arm_smmu_devices_lock);
> > > > > >            master = find_smmu_master(smmu, dev->of_node);
> > > > > > +        spin_unlock(&arm_smmu_devices_lock);
> > > > >
> > > > > At the moment, unlocking here is fine because we don't remove the
> > > > > device. However, there are a series to supporting removing a
> device (see
> > > > > [1]). So I think it would be preferable to unlock after the last
> use of
> > > > > 'cfg'.
> > > > >
> > > Ok. I will move unlocking to the end of this else {} block. I was not
> aware
> > > of the patch you are referring to.
> >
> > I think the end of the else is still too early. This needs to at least
> be past
> > iommu_group_set_iommudata() because we store cfg.
> >
> > Potentially, the lock wants to also englobe
> arm_smmu_master_alloc_smes(). So I
> > am wondering whether it would be simpler to hold the lock for the whole
> > duration of arm_smmu_add_device() (I can see value when we will want to
> > interlock with the remove code).
>
> The patch was to protect the smmu master list. From that point of view
> the unlock right after find_smmu_master would be sufficient, right?
>

Yes. However this is not fixing all the problems (see below).


> We only need to protect cfg if we are worried that the same device is
> added in two different ways at the same time. Did I get it right? If so,
> I would say that that case should not be possible? Am I missing another
> potential conflict?
>

It should not be possible to add the same device twice. The problem is more
when we are going to remove the device. In this case, "master" may
disappear at any point.

The support for removing device is not yet implemented in the tree. But
there is already a patch on the ML. So I think it would be shortsighted to
only move the lock to just solve concurrent access to the list.


>
> I am pointing this out for two reasons:
>
> Protecting the list is different from protecting each element from
> concurrent modification of the element itself. If the latter is a
> potential problem, I wonder if arm_smmu_add_device is the only function
> affected?
>

I had a brief looked at the code and couldn't find any other places where
this may be an issue.


> The second reason is that extending the lock past
> arm_smmu_master_alloc_smes is a bit worrying because it causes
> &arm_smmu_devices_lock and smmu->stream_map_lock to nest, which wasn't
> the case before.
>

Nested locks are common. I don't believe there would be a problem here with
this one.


> I am not saying that it is a bad idea to extend the lock past
> arm_smmu_master_alloc_smes -- it might be the right thing to do.


I don't usually suggest locking changes blindly ;).

But I

am merely saying that it might be best to think twice about it.

and/or do
> that after 4.16.


To be honest, this patch is not useful the callback to register a device in
the IOMMU subsystem. So if you are concerned with the my suggested locking
then, I am afraid the current patch is a no-go on my side for 4.16.

That said we can work towards a new locking approach for 4.17. However, I
would want to have a proposal from your side or at least some details on
why the suggested locking is not suitable.

Cheers,

--00000000000068854805cf5e29f9
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"auto"><div><br><br><div class=3D"gmail_quote"><div dir=3D"ltr" =
class=3D"gmail_attr">On Thu, 28 Oct 2021, 00:14 Stefano Stabellini, &lt;<a =
href=3D"mailto:sstabellini@kernel.org">sstabellini@kernel.org</a>&gt; wrote=
:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;bor=
der-left:1px #ccc solid;padding-left:1ex">On Wed, 27 Oct 2021, Julien Grall=
 wrote:<br>
&gt; &gt; &gt; &gt; &gt; +=C2=A0=C2=A0=C2=A0 return ret;<br>
&gt; &gt; &gt; &gt; &gt;=C2=A0 =C2=A0 }<br>
&gt; &gt; &gt; &gt; &gt;=C2=A0 =C2=A0 static int register_smmu_master(struc=
t arm_smmu_device *smmu,<br>
&gt; &gt; &gt; &gt; &gt; @@ -2056,7 +2066,10 @@ static int arm_smmu_add_dev=
ice(struct device<br>
&gt; &gt; &gt; &gt; &gt; *dev)<br>
&gt; &gt; &gt; &gt; &gt;=C2=A0 =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 } else {<br>
&gt; &gt; &gt; &gt; &gt;=C2=A0 =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0 struct arm_smmu_master *master;<br>
&gt; &gt; &gt; &gt; &gt; +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 spin_l=
ock(&amp;arm_smmu_devices_lock);<br>
&gt; &gt; &gt; &gt; &gt;=C2=A0 =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0 master =3D find_smmu_master(smmu, dev-&gt;of_node);<br>
&gt; &gt; &gt; &gt; &gt; +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 spin_u=
nlock(&amp;arm_smmu_devices_lock);<br>
&gt; &gt; &gt; &gt; <br>
&gt; &gt; &gt; &gt; At the moment, unlocking here is fine because we don&#3=
9;t remove the<br>
&gt; &gt; &gt; &gt; device. However, there are a series to supporting remov=
ing a device (see<br>
&gt; &gt; &gt; &gt; [1]). So I think it would be preferable to unlock after=
 the last use of<br>
&gt; &gt; &gt; &gt; &#39;cfg&#39;.<br>
&gt; &gt; &gt; &gt; <br>
&gt; &gt; Ok. I will move unlocking to the end of this else {} block. I was=
 not aware<br>
&gt; &gt; of the patch you are referring to.<br>
&gt; <br>
&gt; I think the end of the else is still too early. This needs to at least=
 be past<br>
&gt; iommu_group_set_iommudata() because we store cfg.<br>
&gt; <br>
&gt; Potentially, the lock wants to also englobe arm_smmu_master_alloc_smes=
(). So I<br>
&gt; am wondering whether it would be simpler to hold the lock for the whol=
e<br>
&gt; duration of arm_smmu_add_device() (I can see value when we will want t=
o<br>
&gt; interlock with the remove code).<br>
<br>
The patch was to protect the smmu master list. From that point of view<br>
the unlock right after find_smmu_master would be sufficient, right?<br></bl=
ockquote></div></div><div dir=3D"auto"><br></div><div dir=3D"auto">Yes. How=
ever this is not fixing all the problems (see below).</div><div dir=3D"auto=
"><br></div><div dir=3D"auto"><div class=3D"gmail_quote"><blockquote class=
=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padd=
ing-left:1ex">
<br>
We only need to protect cfg if we are worried that the same device is<br>
added in two different ways at the same time. Did I get it right? If so,<br=
>
I would say that that case should not be possible? Am I missing another<br>
potential conflict?<br></blockquote></div></div><div dir=3D"auto"><br></div=
><div dir=3D"auto">It should not be possible to add the same device twice. =
The problem is more when we are going to remove the device. In this case, &=
quot;master&quot; may disappear at any point.</div><div dir=3D"auto"><br></=
div><div dir=3D"auto">The support for removing device is not yet implemente=
d in the tree. But there is already a patch on the ML. So I think it would =
be shortsighted to only move the lock to just solve concurrent access to th=
e list.</div><div dir=3D"auto"><br></div><div dir=3D"auto"><div class=3D"gm=
ail_quote"><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;bor=
der-left:1px #ccc solid;padding-left:1ex">
<br>
<br>
I am pointing this out for two reasons:<br>
<br>
Protecting the list is different from protecting each element from<br>
concurrent modification of the element itself. If the latter is a<br>
potential problem, I wonder if arm_smmu_add_device is the only function<br>
affected?<br></blockquote></div></div><div dir=3D"auto"><br></div><div dir=
=3D"auto">I had a brief looked at the code and couldn&#39;t find any other =
places where this may be an issue.</div><div dir=3D"auto"><br></div><div di=
r=3D"auto"><div class=3D"gmail_quote"><blockquote class=3D"gmail_quote" sty=
le=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
The second reason is that extending the lock past<br>
arm_smmu_master_alloc_smes is a bit worrying because it causes<br>
&amp;arm_smmu_devices_lock and smmu-&gt;stream_map_lock to nest, which wasn=
&#39;t<br>
the case before.<br></blockquote></div></div><div dir=3D"auto"><br></div><d=
iv dir=3D"auto">Nested locks are common. I don&#39;t believe there would be=
 a problem here with this one.</div><div dir=3D"auto"><br></div><div dir=3D=
"auto"><div class=3D"gmail_quote"><blockquote class=3D"gmail_quote" style=
=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
I am not saying that it is a bad idea to extend the lock past<br>
arm_smmu_master_alloc_smes -- it might be the right thing to do. </blockquo=
te></div></div><div dir=3D"auto"><br><span style=3D"font-family:sans-serif"=
>I don&#39;t usually suggest locking changes blindly ;).</span><br></div><d=
iv dir=3D"auto"><br></div><div dir=3D"auto"><div class=3D"gmail_quote"><blo=
ckquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #c=
cc solid;padding-left:1ex">But I</blockquote></div></div><div dir=3D"auto">=
<div class=3D"gmail_quote"><blockquote class=3D"gmail_quote" style=3D"margi=
n:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
am merely saying that it might be best to think twice about it.</blockquote=
></div></div><div dir=3D"auto"><div class=3D"gmail_quote"><blockquote class=
=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padd=
ing-left:1ex">and/or do<br>
that after 4.16.</blockquote></div></div><div dir=3D"auto"><br></div><div d=
ir=3D"auto">To be honest, this patch is not useful the callback to register=
 a device in the IOMMU subsystem. So if you are concerned with the my sugge=
sted locking then, I am afraid the current patch is a no-go on my side for =
4.16.</div><div dir=3D"auto"><br></div><div dir=3D"auto">That said we can w=
ork towards a new locking approach for 4.17. However, I would want to have =
a proposal from your side or at least some details on why the suggested loc=
king is not suitable.</div><div dir=3D"auto"><br></div><div dir=3D"auto">Ch=
eers,</div><div dir=3D"auto"></div></div>

--00000000000068854805cf5e29f9--


From xen-devel-bounces@lists.xenproject.org Wed Oct 27 23:45:45 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Oct 2021 23:45:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217548.377645 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfsbm-0001sG-Rs; Wed, 27 Oct 2021 23:45:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217548.377645; Wed, 27 Oct 2021 23:45:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfsbm-0001s9-Or; Wed, 27 Oct 2021 23:45:26 +0000
Received: by outflank-mailman (input) for mailman id 217548;
 Wed, 27 Oct 2021 23:45:26 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=M2QJ=PP=gmail.com=julien.grall.oss@srs-us1.protection.inumbo.net>)
 id 1mfsbl-0001rw-UX
 for xen-devel@lists.xenproject.org; Wed, 27 Oct 2021 23:45:25 +0000
Received: from mail-ed1-x535.google.com (unknown [2a00:1450:4864:20::535])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 646ec479-80ae-4518-9736-8ecb0d978c9b;
 Wed, 27 Oct 2021 23:45:24 +0000 (UTC)
Received: by mail-ed1-x535.google.com with SMTP id g8so17473389edb.2
 for <xen-devel@lists.xenproject.org>; Wed, 27 Oct 2021 16:45:24 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 646ec479-80ae-4518-9736-8ecb0d978c9b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=2iSCHqJVLf6tYgbKKAiQCHDbyiwZZSfoEu8uZI9MyTo=;
        b=QSWAseTBZkRK/COzIKl34J63FPh5JGJAmBMdkig8dolFIG++RULZ7qwYji8kdi5BiT
         FvuHIPV6GTzRHuoUjmolxBgy72fn8hQXeXHfrjQEEipTQP2vb68wUIW4gZLxmN04bFIp
         5IE45h5DyMPLU/gKCfNGpj312dUfQDjpAw0SgNEJr4lPxXyUU1DP7ubTVpcaqkw6BaNn
         8Y06CSf1JYWmRHhFOpuoUCkFaT3wdGYEDt2WAlvlrJpHJ0Mt0+qaIEtJt3+V4eC71FLg
         icK4PjTmrOI7RHwh+SwqQmmTU+76pVe8rGUvBKbFRH+6ooSpjKpVaR1coAUQ7lFV0K5H
         zc5A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=2iSCHqJVLf6tYgbKKAiQCHDbyiwZZSfoEu8uZI9MyTo=;
        b=izYCaGUj37c1e3Kq1DYIiLrEwCCUzvHIEccg2vXqbWtvvACdhdnoHiwc88g2Q68YtO
         lMDIi/tpXVrGgfVhtPcaNGS+E53LroMrVeeBp/vMvtxwS3EX2kg9SpR4Z2RBaQxuMF+I
         p1+VSYBNL7I/U8+7BYM0HwZ9gAcjir6TqEgDaHk4VX51l+JDHiIOs8wemW6n/yWrzh8s
         nR/YdcSJxf8vjvlf2mQyJtPltVwOkncAB/mFqYiJ1mu88sHkqCvlnZbmIuGPZR12fJ2G
         vdDST5FJJRWq4Uc1BW3VrBBZ6KMC3RmN6CzDYA4umKsIAINSiELZOvTcL9odzqGJ1B59
         Lyug==
X-Gm-Message-State: AOAM531WP4rQ8gNvy/UTgNmj7Wz7I4Ho4onNGN+tERO6Sh9djO8Q0lno
	zIlpDRHrEUmItVbbP9Sms+k0Gv53MpBlYk01uZ0=
X-Google-Smtp-Source: ABdhPJy0vIP8thTX0QKPSUeeatVhdrnFo9GbgqbPs1ewdORdeMgS9p3gVoPfN8/3UOKc2vEXHX27BVdfkO4Ga/wyo+A=
X-Received: by 2002:a50:9e64:: with SMTP id z91mr1265317ede.219.1635378323885;
 Wed, 27 Oct 2021 16:45:23 -0700 (PDT)
MIME-Version: 1.0
References: <20211026122903.15042-1-michal.orzel@arm.com> <e5632a4e-db98-41b4-1045-2b3532c098fa@xen.org>
 <70c30a6c-b779-805e-079a-41bb484894b9@xen.org> <cb452c0c-ccde-7798-c403-f972b48a2c46@arm.com>
 <01545115-e82e-2a9d-a8e4-da9676080c0f@xen.org> <alpine.DEB.2.21.2110271557570.20134@sstabellini-ThinkPad-T480s>
 <CAJ=z9a2SSgG7a87_xTGT5LeNLgubOLQf1+dbnrsTsP8_p5ErJg@mail.gmail.com>
In-Reply-To: <CAJ=z9a2SSgG7a87_xTGT5LeNLgubOLQf1+dbnrsTsP8_p5ErJg@mail.gmail.com>
From: Julien Grall <julien.grall.oss@gmail.com>
Date: Thu, 28 Oct 2021 00:45:12 +0100
Message-ID: <CAJ=z9a0nTsLph_Q7T29Wz-bzAMj2YFTMQ4ow4-r9-_Spc2_BVA@mail.gmail.com>
Subject: Re: [patch-4.16] arm/smmuv1,v2: Protect smmu master list with a lock
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: Michal Orzel <michal.orzel@arm.com>, xen-devel <xen-devel@lists.xenproject.org>, 
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, Bertrand Marquis <bertrand.marquis@arm.com>, 
	Ian Jackson <iwj@xenproject.org>
Content-Type: multipart/alternative; boundary="0000000000001193ec05cf5e3001"

--0000000000001193ec05cf5e3001
Content-Type: text/plain; charset="UTF-8"

On Thu, 28 Oct 2021, 00:43 Julien Grall, <julien.grall.oss@gmail.com> wrote:

>
>
> On Thu, 28 Oct 2021, 00:14 Stefano Stabellini, <sstabellini@kernel.org>
> wrote:
>
>> On Wed, 27 Oct 2021, Julien Grall wrote:
>> > > > > > +    return ret;
>> > > > > >    }
>> > > > > >    static int register_smmu_master(struct arm_smmu_device *smmu,
>> > > > > > @@ -2056,7 +2066,10 @@ static int arm_smmu_add_device(struct
>> device
>> > > > > > *dev)
>> > > > > >        } else {
>> > > > > >            struct arm_smmu_master *master;
>> > > > > > +        spin_lock(&arm_smmu_devices_lock);
>> > > > > >            master = find_smmu_master(smmu, dev->of_node);
>> > > > > > +        spin_unlock(&arm_smmu_devices_lock);
>> > > > >
>> > > > > At the moment, unlocking here is fine because we don't remove the
>> > > > > device. However, there are a series to supporting removing a
>> device (see
>> > > > > [1]). So I think it would be preferable to unlock after the last
>> use of
>> > > > > 'cfg'.
>> > > > >
>> > > Ok. I will move unlocking to the end of this else {} block. I was not
>> aware
>> > > of the patch you are referring to.
>> >
>> > I think the end of the else is still too early. This needs to at least
>> be past
>> > iommu_group_set_iommudata() because we store cfg.
>> >
>> > Potentially, the lock wants to also englobe
>> arm_smmu_master_alloc_smes(). So I
>> > am wondering whether it would be simpler to hold the lock for the whole
>> > duration of arm_smmu_add_device() (I can see value when we will want to
>> > interlock with the remove code).
>>
>> The patch was to protect the smmu master list. From that point of view
>> the unlock right after find_smmu_master would be sufficient, right?
>>
>
> Yes. However this is not fixing all the problems (see below).
>
>
>> We only need to protect cfg if we are worried that the same device is
>> added in two different ways at the same time. Did I get it right? If so,
>> I would say that that case should not be possible? Am I missing another
>> potential conflict?
>>
>
> It should not be possible to add the same device twice. The problem is
> more when we are going to remove the device. In this case, "master" may
> disappear at any point.
>
> The support for removing device is not yet implemented in the tree. But
> there is already a patch on the ML. So I think it would be shortsighted to
> only move the lock to just solve concurrent access to the list.
>
>
>>
>> I am pointing this out for two reasons:
>>
>> Protecting the list is different from protecting each element from
>> concurrent modification of the element itself. If the latter is a
>> potential problem, I wonder if arm_smmu_add_device is the only function
>> affected?
>>
>
> I had a brief looked at the code and couldn't find any other places where
> this may be an issue.
>
>
>> The second reason is that extending the lock past
>> arm_smmu_master_alloc_smes is a bit worrying because it causes
>> &arm_smmu_devices_lock and smmu->stream_map_lock to nest, which wasn't
>> the case before.
>>
>
> Nested locks are common. I don't believe there would be a problem here
> with this one.
>
>
>> I am not saying that it is a bad idea to extend the lock past
>> arm_smmu_master_alloc_smes -- it might be the right thing to do.
>
>
> I don't usually suggest locking changes blindly ;).
>
> But I
>
> am merely saying that it might be best to think twice about it.
>
> and/or do
>> that after 4.16.
>
>
> To be honest, this patch is not useful the callback to register a device
> in the IOMMU subsystem. So if you are concerned with
>

The sentence makes no sense sorry. I meant the add callback doesn't support
PCI devices. So the locking is a latent issue at the moment.

 the my suggested locking then, I am afraid the current patch is a no-go on
> my side for 4.16.
>
> That said we can work towards a new locking approach for 4.17. However, I
> would want to have a proposal from your side or at least some details on
> why the suggested locking is not suitable.
>
> Cheers,
>

--0000000000001193ec05cf5e3001
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"auto"><div><br><br><div class=3D"gmail_quote"><div dir=3D"ltr" =
class=3D"gmail_attr">On Thu, 28 Oct 2021, 00:43 Julien Grall, &lt;<a href=
=3D"mailto:julien.grall.oss@gmail.com">julien.grall.oss@gmail.com</a>&gt; w=
rote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex=
;border-left:1px #ccc solid;padding-left:1ex"><div dir=3D"auto"><div><br><b=
r><div class=3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail_attr">On Thu, =
28 Oct 2021, 00:14 Stefano Stabellini, &lt;<a href=3D"mailto:sstabellini@ke=
rnel.org" target=3D"_blank" rel=3D"noreferrer">sstabellini@kernel.org</a>&g=
t; wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 =
.8ex;border-left:1px #ccc solid;padding-left:1ex">On Wed, 27 Oct 2021, Juli=
en Grall wrote:<br>
&gt; &gt; &gt; &gt; &gt; +=C2=A0=C2=A0=C2=A0 return ret;<br>
&gt; &gt; &gt; &gt; &gt;=C2=A0 =C2=A0 }<br>
&gt; &gt; &gt; &gt; &gt;=C2=A0 =C2=A0 static int register_smmu_master(struc=
t arm_smmu_device *smmu,<br>
&gt; &gt; &gt; &gt; &gt; @@ -2056,7 +2066,10 @@ static int arm_smmu_add_dev=
ice(struct device<br>
&gt; &gt; &gt; &gt; &gt; *dev)<br>
&gt; &gt; &gt; &gt; &gt;=C2=A0 =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 } else {<br>
&gt; &gt; &gt; &gt; &gt;=C2=A0 =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0 struct arm_smmu_master *master;<br>
&gt; &gt; &gt; &gt; &gt; +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 spin_l=
ock(&amp;arm_smmu_devices_lock);<br>
&gt; &gt; &gt; &gt; &gt;=C2=A0 =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0 master =3D find_smmu_master(smmu, dev-&gt;of_node);<br>
&gt; &gt; &gt; &gt; &gt; +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 spin_u=
nlock(&amp;arm_smmu_devices_lock);<br>
&gt; &gt; &gt; &gt; <br>
&gt; &gt; &gt; &gt; At the moment, unlocking here is fine because we don&#3=
9;t remove the<br>
&gt; &gt; &gt; &gt; device. However, there are a series to supporting remov=
ing a device (see<br>
&gt; &gt; &gt; &gt; [1]). So I think it would be preferable to unlock after=
 the last use of<br>
&gt; &gt; &gt; &gt; &#39;cfg&#39;.<br>
&gt; &gt; &gt; &gt; <br>
&gt; &gt; Ok. I will move unlocking to the end of this else {} block. I was=
 not aware<br>
&gt; &gt; of the patch you are referring to.<br>
&gt; <br>
&gt; I think the end of the else is still too early. This needs to at least=
 be past<br>
&gt; iommu_group_set_iommudata() because we store cfg.<br>
&gt; <br>
&gt; Potentially, the lock wants to also englobe arm_smmu_master_alloc_smes=
(). So I<br>
&gt; am wondering whether it would be simpler to hold the lock for the whol=
e<br>
&gt; duration of arm_smmu_add_device() (I can see value when we will want t=
o<br>
&gt; interlock with the remove code).<br>
<br>
The patch was to protect the smmu master list. From that point of view<br>
the unlock right after find_smmu_master would be sufficient, right?<br></bl=
ockquote></div></div><div dir=3D"auto"><br></div><div dir=3D"auto">Yes. How=
ever this is not fixing all the problems (see below).</div><div dir=3D"auto=
"><br></div><div dir=3D"auto"><div class=3D"gmail_quote"><blockquote class=
=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padd=
ing-left:1ex">
<br>
We only need to protect cfg if we are worried that the same device is<br>
added in two different ways at the same time. Did I get it right? If so,<br=
>
I would say that that case should not be possible? Am I missing another<br>
potential conflict?<br></blockquote></div></div><div dir=3D"auto"><br></div=
><div dir=3D"auto">It should not be possible to add the same device twice. =
The problem is more when we are going to remove the device. In this case, &=
quot;master&quot; may disappear at any point.</div><div dir=3D"auto"><br></=
div><div dir=3D"auto">The support for removing device is not yet implemente=
d in the tree. But there is already a patch on the ML. So I think it would =
be shortsighted to only move the lock to just solve concurrent access to th=
e list.</div><div dir=3D"auto"><br></div><div dir=3D"auto"><div class=3D"gm=
ail_quote"><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;bor=
der-left:1px #ccc solid;padding-left:1ex">
<br>
<br>
I am pointing this out for two reasons:<br>
<br>
Protecting the list is different from protecting each element from<br>
concurrent modification of the element itself. If the latter is a<br>
potential problem, I wonder if arm_smmu_add_device is the only function<br>
affected?<br></blockquote></div></div><div dir=3D"auto"><br></div><div dir=
=3D"auto">I had a brief looked at the code and couldn&#39;t find any other =
places where this may be an issue.</div><div dir=3D"auto"><br></div><div di=
r=3D"auto"><div class=3D"gmail_quote"><blockquote class=3D"gmail_quote" sty=
le=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
The second reason is that extending the lock past<br>
arm_smmu_master_alloc_smes is a bit worrying because it causes<br>
&amp;arm_smmu_devices_lock and smmu-&gt;stream_map_lock to nest, which wasn=
&#39;t<br>
the case before.<br></blockquote></div></div><div dir=3D"auto"><br></div><d=
iv dir=3D"auto">Nested locks are common. I don&#39;t believe there would be=
 a problem here with this one.</div><div dir=3D"auto"><br></div><div dir=3D=
"auto"><div class=3D"gmail_quote"><blockquote class=3D"gmail_quote" style=
=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
I am not saying that it is a bad idea to extend the lock past<br>
arm_smmu_master_alloc_smes -- it might be the right thing to do. </blockquo=
te></div></div><div dir=3D"auto"><br><span style=3D"font-family:sans-serif"=
>I don&#39;t usually suggest locking changes blindly ;).</span><br></div><d=
iv dir=3D"auto"><br></div><div dir=3D"auto"><div class=3D"gmail_quote"><blo=
ckquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #c=
cc solid;padding-left:1ex">But I</blockquote></div></div><div dir=3D"auto">=
<div class=3D"gmail_quote"><blockquote class=3D"gmail_quote" style=3D"margi=
n:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
am merely saying that it might be best to think twice about it.</blockquote=
></div></div><div dir=3D"auto"><div class=3D"gmail_quote"><blockquote class=
=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padd=
ing-left:1ex">and/or do<br>
that after 4.16.</blockquote></div></div><div dir=3D"auto"><br></div><div d=
ir=3D"auto">To be honest, this patch is not useful the callback to register=
 a device in the IOMMU subsystem. So if you are concerned with</div><div di=
r=3D"auto"></div></div></blockquote></div></div><div dir=3D"auto"><br></div=
><div dir=3D"auto">The sentence makes no sense sorry. I meant the add callb=
ack doesn&#39;t support PCI devices. So the locking is a latent issue at th=
e moment.</div><div dir=3D"auto"><br></div><div dir=3D"auto"><div class=3D"=
gmail_quote"><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;b=
order-left:1px #ccc solid;padding-left:1ex"><div dir=3D"auto"><div dir=3D"a=
uto">=C2=A0the my suggested locking then, I am afraid the current patch is =
a no-go on my side for 4.16.</div><div dir=3D"auto"><br></div><div dir=3D"a=
uto">That said we can work towards a new locking approach for 4.17. However=
, I would want to have a proposal from your side or at least some details o=
n why the suggested locking is not suitable.</div><div dir=3D"auto"><br></d=
iv><div dir=3D"auto">Cheers,</div><div dir=3D"auto"></div></div>
</blockquote></div></div></div>

--0000000000001193ec05cf5e3001--


From xen-devel-bounces@lists.xenproject.org Wed Oct 27 23:57:15 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 27 Oct 2021 23:57:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217556.377657 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfsn3-0003Ni-VF; Wed, 27 Oct 2021 23:57:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217556.377657; Wed, 27 Oct 2021 23:57:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfsn3-0003Nb-RM; Wed, 27 Oct 2021 23:57:05 +0000
Received: by outflank-mailman (input) for mailman id 217556;
 Wed, 27 Oct 2021 23:57:05 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=7RMc=PP=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1mfsn2-0003NV-Ux
 for xen-devel@lists.xenproject.org; Wed, 27 Oct 2021 23:57:04 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 9542014e-3781-11ec-848c-12813bfff9fa;
 Wed, 27 Oct 2021 23:57:04 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id 11D6660F9C;
 Wed, 27 Oct 2021 23:57:03 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9542014e-3781-11ec-848c-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1635379023;
	bh=Z4vtCU4oJ7ft2D9z1b+lz+jTWGnf4/E/tC5BtXysHaE=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=gIwRoyiqq65J1Zu6M/fuXqRFPJ51iZ+mePbIU2Dy+JiVfIElLyVTvurfYQ1loXW6W
	 3wCl5vLiEsvRNBJ9Pnb4gwfChZIaBaVOGhRjNHzBzixKSdOSoYLXv/RgGYVrmePVj/
	 JBAA3W6OtExsJvOPqHi+O2uy7Ots65TcB/1mJ0ptSuwac7QJE5y9uC33BBZb9BaMOy
	 omEWVOKDrLRtx6tmCpzs5peVbDZ8q0oKwZlx3iOni3Ef/3OdTSNd3XYLRe2mBivq8g
	 GB0kzZpnA6/jJkSg4UdAUCtwqg7j9647PUOjENnNlx2YOtB1q3vKWFYHMIGcdHTTNI
	 EJrQ0GGBzK3zw==
Date: Wed, 27 Oct 2021 16:57:02 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Julien Grall <julien@xen.org>
cc: Oleksandr Andrushchenko <andr2000@gmail.com>, 
    xen-devel@lists.xenproject.org, sstabellini@kernel.org, iwj@xenproject.org, 
    bertrand.marquis@arm.com, rahul.singh@arm.com, 
    Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Subject: Re: [PATCH] xen/arm: do not try to add pci-domain for disabled
 devices
In-Reply-To: <7a97bbef-68a9-8f52-0c93-88d4e84a07fc@xen.org>
Message-ID: <alpine.DEB.2.21.2110271649240.20134@sstabellini-ThinkPad-T480s>
References: <20211027083730.1406947-1-andr2000@gmail.com> <7a97bbef-68a9-8f52-0c93-88d4e84a07fc@xen.org>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Wed, 27 Oct 2021, Julien Grall wrote:
> Hi Oleksandr,
> 
> On 27/10/2021 09:37, Oleksandr Andrushchenko wrote:
> > From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> > 
> > If a PCI host bridge device is present in the device tree, but is
> > disabled, then its PCI host bridge driver was not instantiated.
> > This results in the following panic during Xen start:
> > 
> > (XEN) Device tree generation failed (-22).
> 
> It would good to clarify in the commit message where the error is coming from.
> I think this is from pci_get_host_bridge_segment().
> 
> > (XEN)
> > (XEN) ****************************************
> > (XEN) Panic on CPU 0:
> > (XEN) Could not set up DOM0 guest OS
> > (XEN) ****************************************
> > 
> > Fix this by not adding linux,pci-domain property for hwdom if it is
> > neither available nor device enabled.
> From my reading of the binding [1], the property should be present in all the
> hostbridges if one specify it. IOW, I think the property should also be added
> for hostbridges that are not available.

Just wanted to say that I think you are right:

"""
It is required to either not set this property at all or set it for all
host bridges in the system, otherwise potentially conflicting domain numbers
may be assigned to root buses behind different host bridges.  The domain
number for each host bridge in the system must be unique.
"""

and I am ready to believe device trees with disabled bridges might have
(incorrectly) ignored the rule.


> AFAICT, Linux will ignore hostbridge that are not available. But it feels to
> me we are twisting the rule. So, could we consider to allocate an unused
> number?

I think that would be fine but it doesn't look easy from the current Xen
code point of view because the allocation depends on the Xen driver,
which we don't have. But I'll let others comment on it. Otherwise
skipping the disabled host bridge node for Dom0 sounds OK.


From xen-devel-bounces@lists.xenproject.org Thu Oct 28 00:20:58 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Oct 2021 00:20:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217566.377668 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mft9v-0007B1-I6; Thu, 28 Oct 2021 00:20:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217566.377668; Thu, 28 Oct 2021 00:20:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mft9v-0007Au-En; Thu, 28 Oct 2021 00:20:43 +0000
Received: by outflank-mailman (input) for mailman id 217566;
 Thu, 28 Oct 2021 00:20:42 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=TkaK=PQ=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1mft9u-0007Am-0i
 for xen-devel@lists.xenproject.org; Thu, 28 Oct 2021 00:20:42 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id e1d82062-3784-11ec-848d-12813bfff9fa;
 Thu, 28 Oct 2021 00:20:41 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id 0F9EF610C7;
 Thu, 28 Oct 2021 00:20:40 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e1d82062-3784-11ec-848d-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1635380440;
	bh=HoAuIDTuAGBplcEGnWmXrI1OHfBOdkx/zacsX2UldhU=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=HvSIKd1uzNYiJ1BzFYwvCrYmvte38aMEdBW+2hoH78aZiZsqVNiulZEJzapVTakTs
	 lDdQVO69CMAlHB+RL+Lt5I1EmSbG3J1SQ9kwIyexJr5yZybj1DpSmTOJkUzYdABr+9
	 Ck0BFaolUhyAB1ZPhyGBgYub/8t6OpXy6zYTulhK0Ev//g4JoOmtsX7OqRIJVDplL/
	 1nNEjNa1tY2XJhWpXsBRk8Ys5s8FUDNczFFzBOYifMGMuc+tULUBtZ3DWbQTdfxuq1
	 hMhJENH7pqODEQwieFJOrViSL8pHB1W+0MgokZUZI4WdgZLD496LauMm0pHBMhNLAV
	 svqD8wi4IuFjA==
Date: Wed, 27 Oct 2021 17:20:39 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Julien Grall <julien.grall.oss@gmail.com>
cc: Stefano Stabellini <sstabellini@kernel.org>, 
    Michal Orzel <michal.orzel@arm.com>, 
    xen-devel <xen-devel@lists.xenproject.org>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, 
    Bertrand Marquis <bertrand.marquis@arm.com>, 
    Ian Jackson <iwj@xenproject.org>
Subject: Re: [patch-4.16] arm/smmuv1,v2: Protect smmu master list with a
 lock
In-Reply-To: <CAJ=z9a2SSgG7a87_xTGT5LeNLgubOLQf1+dbnrsTsP8_p5ErJg@mail.gmail.com>
Message-ID: <alpine.DEB.2.21.2110271658330.20134@sstabellini-ThinkPad-T480s>
References: <20211026122903.15042-1-michal.orzel@arm.com> <e5632a4e-db98-41b4-1045-2b3532c098fa@xen.org> <70c30a6c-b779-805e-079a-41bb484894b9@xen.org> <cb452c0c-ccde-7798-c403-f972b48a2c46@arm.com> <01545115-e82e-2a9d-a8e4-da9676080c0f@xen.org>
 <alpine.DEB.2.21.2110271557570.20134@sstabellini-ThinkPad-T480s> <CAJ=z9a2SSgG7a87_xTGT5LeNLgubOLQf1+dbnrsTsP8_p5ErJg@mail.gmail.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: multipart/mixed; BOUNDARY="8323329-1722989215-1635379202=:20134"
Content-ID: <alpine.DEB.2.21.2110271700150.20134@sstabellini-ThinkPad-T480s>

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-1722989215-1635379202=:20134
Content-Type: text/plain; CHARSET=UTF-8
Content-Transfer-Encoding: 8BIT
Content-ID: <alpine.DEB.2.21.2110271700151.20134@sstabellini-ThinkPad-T480s>

On Thu, 28 Oct 2021, Julien Grall wrote:
> On Thu, 28 Oct 2021, 00:14 Stefano Stabellini, <sstabellini@kernel.org> wrote:
>       On Wed, 27 Oct 2021, Julien Grall wrote:
>       > > > > > +    return ret;
>       > > > > >    }
>       > > > > >    static int register_smmu_master(struct arm_smmu_device *smmu,
>       > > > > > @@ -2056,7 +2066,10 @@ static int arm_smmu_add_device(struct device
>       > > > > > *dev)
>       > > > > >        } else {
>       > > > > >            struct arm_smmu_master *master;
>       > > > > > +        spin_lock(&arm_smmu_devices_lock);
>       > > > > >            master = find_smmu_master(smmu, dev->of_node);
>       > > > > > +        spin_unlock(&arm_smmu_devices_lock);
>       > > > >
>       > > > > At the moment, unlocking here is fine because we don't remove the
>       > > > > device. However, there are a series to supporting removing a device (see
>       > > > > [1]). So I think it would be preferable to unlock after the last use of
>       > > > > 'cfg'.
>       > > > >
>       > > Ok. I will move unlocking to the end of this else {} block. I was not aware
>       > > of the patch you are referring to.
>       >
>       > I think the end of the else is still too early. This needs to at least be past
>       > iommu_group_set_iommudata() because we store cfg.
>       >
>       > Potentially, the lock wants to also englobe arm_smmu_master_alloc_smes(). So I
>       > am wondering whether it would be simpler to hold the lock for the whole
>       > duration of arm_smmu_add_device() (I can see value when we will want to
>       > interlock with the remove code).
> 
>       The patch was to protect the smmu master list. From that point of view
>       the unlock right after find_smmu_master would be sufficient, right?
> 
> 
> Yes. However this is not fixing all the problems (see below).
> 
> 
>       We only need to protect cfg if we are worried that the same device is
>       added in two different ways at the same time. Did I get it right? If so,
>       I would say that that case should not be possible? Am I missing another
>       potential conflict?
> 
> 
> It should not be possible to add the same device twice. The problem is more when we are going to remove the device. In this case, "master"
> may disappear at any point.
> 
> The support for removing device is not yet implemented in the tree. But there is already a patch on the ML. So I think it would be
> shortsighted to only move the lock to just solve concurrent access to the list.
 
That makes sense now: the other source of conflict is concurrent add and
remove of the same device. Sorry it wasn't clear to me before.
 
 
>       I am pointing this out for two reasons:
> 
>       Protecting the list is different from protecting each element from
>       concurrent modification of the element itself. If the latter is a
>       potential problem, I wonder if arm_smmu_add_device is the only function
>       affected?
> 
> 
> I had a brief looked at the code and couldn't find any other places where this may be an issue.
> 
> 
>       The second reason is that extending the lock past
>       arm_smmu_master_alloc_smes is a bit worrying because it causes
>       &arm_smmu_devices_lock and smmu->stream_map_lock to nest, which wasn't
>       the case before.
> 
> 
> Nested locks are common. I don't believe there would be a problem here with this one.
> 
> 
>       I am not saying that it is a bad idea to extend the lock past
>       arm_smmu_master_alloc_smes -- it might be the right thing to do.
> 
> 
> I don't usually suggest locking changes blindly ;).
> 
>       But I
> 
>       am merely saying that it might be best to think twice about it.
> 
>       and/or do
>       that after 4.16.
> 
> 
> To be honest, this patch is not useful the callback to register a
> device in the IOMMU subsystem. The sentence makes no sense sorry. I
> meant the add callback doesn't support PCI devices. So the locking is
> a latent issue at the moment.
>
> So if you are concerned with the my suggested locking then, I am
> afraid the current patch is a no-go on my side for 4.16.

I was totally fine with it aside from the last suggestion of extending
the spin_unlock until the end of the function because until then the
changes were obviously correct to me.

I didn't understand the reason why we needed extending spin_unlock, now
I understand it. Also lock nesting is one of those thing that it is
relatively common but I think should always take a second check to make
sure it is correct.  Specifically we need to check that no fuctions with
smmu->stream_map_lock taken call a function that take
&arm_smmu_devices_lock. It is not very difficult but I haven't done
this check myself.

The other thing that is not clear to me is whether we would need also to
protect places where we use (not allocate) masters and/or cfg, e.g.
arm_smmu_attach_dev, arm_smmu_domain_add_master.


> That said we can work towards a new locking approach for 4.17.
> However, I would want to have a proposal from your side or at least
> some details on why the suggested locking is not suitable.
 
The suggested locking approach up until the last suggestion looks
totally fine to me. The last suggestion is a bit harder to tell because
the PCI removal hook is not there yet, so I am having troubles seeing
exactly what needs to be protected.
--8323329-1722989215-1635379202=:20134--


From xen-devel-bounces@lists.xenproject.org Thu Oct 28 01:28:19 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Oct 2021 01:28:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217582.377679 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfuCq-0006lO-ME; Thu, 28 Oct 2021 01:27:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217582.377679; Thu, 28 Oct 2021 01:27:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfuCq-0006lH-IE; Thu, 28 Oct 2021 01:27:48 +0000
Received: by outflank-mailman (input) for mailman id 217582;
 Thu, 28 Oct 2021 01:27:47 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=XuVQ=PQ=oracle.com=dongli.zhang@srs-us1.protection.inumbo.net>)
 id 1mfuCp-0006l6-9a
 for xen-devel@lists.xenproject.org; Thu, 28 Oct 2021 01:27:47 +0000
Received: from mx0b-00069f02.pphosted.com (unknown [205.220.177.32])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id f31fe5f2-0269-485d-b85d-84d770fe77ed;
 Thu, 28 Oct 2021 01:27:44 +0000 (UTC)
Received: from pps.filterd (m0246632.ppops.net [127.0.0.1])
 by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 19RMoQ0b004983; 
 Thu, 28 Oct 2021 01:26:23 GMT
Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80])
 by mx0b-00069f02.pphosted.com with ESMTP id 3bx4fj6ctg-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Thu, 28 Oct 2021 01:26:22 +0000
Received: from pps.filterd (userp3030.oracle.com [127.0.0.1])
 by userp3030.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 19S1G2P3136150;
 Thu, 28 Oct 2021 01:26:22 GMT
Received: from nam12-dm6-obe.outbound.protection.outlook.com
 (mail-dm6nam12lp2173.outbound.protection.outlook.com [104.47.59.173])
 by userp3030.oracle.com with ESMTP id 3bx4h39y0s-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Thu, 28 Oct 2021 01:26:21 +0000
Received: from BYAPR10MB2663.namprd10.prod.outlook.com (2603:10b6:a02:a9::20)
 by BY5PR10MB3761.namprd10.prod.outlook.com (2603:10b6:a03:1ff::33)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.13; Thu, 28 Oct
 2021 01:26:18 +0000
Received: from BYAPR10MB2663.namprd10.prod.outlook.com
 ([fe80::2848:63dc:b87:8021]) by BYAPR10MB2663.namprd10.prod.outlook.com
 ([fe80::2848:63dc:b87:8021%7]) with mapi id 15.20.4649.014; Thu, 28 Oct 2021
 01:26:18 +0000
Received: from localhost.localdomain (138.3.200.16) by
 SN4PR0701CA0044.namprd07.prod.outlook.com (2603:10b6:803:2d::17) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.15 via Frontend
 Transport; Thu, 28 Oct 2021 01:26:16 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f31fe5f2-0269-485d-b85d-84d770fe77ed
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc :
 subject : date : message-id : content-type : mime-version;
 s=corp-2021-07-09; bh=00hIRxLONqx+89sOGBZdZ0BNvFPX/tr/Ga097oZol8E=;
 b=RXWQ1nVHFH22oxLuSTWSm+MUpBaedacM3oodIlY/4ca9cEpy7DOnC+cIDWMUhejse9B1
 cFA/ornvfk0wHiUVR9wOgnxm7pcDEiWlylc8u2CjVdyDtUzModADyfgdHuqFeRrlYY2X
 XUbF0jszYU2J0DjjY2nSHClyJJulhpcL9aKC/4uyqint3gdCN8+/xSwXcUlFbhw6L3wg
 SXXLQarXL9aDcrelbY8F8r5andnKiDBTocW072q1KKJyMMVqsB3pGTcdrZAEdQ9Mjkjz
 hfWxnnnEhW55fbR5utvO0L6Oh1CfcpcAbzjq+yLkudrwAO0L/Q4K1gDY6MHhP92sEbAo sQ== 
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=CeZeAwLfVj0nL+YJy8sIk+zk0h8ZhbGk9RQ3Fr33b7Og9AI6Gsvdr5WINIgIbaqVilte4UfdhvGYFqGL2g8gkzoWJ2tot6l6QWdoSfz55yVIS9B7etAOabvdA97EqZxXmU+vQ+MPxMg4c4FIBF6VbkjQlORHGehpt3c13JHkcGf1KcX52wloET3xBA3ZrxaO6OmDEua+YErGht/ZzCu7wdd8Vbjli5XEOAOi7L0Qkei3dcmgg6uRwJ+tn+8h2tja1Ss121wrek3sKxBjaiLKSgk5zfplt1YpVlWh7f+G7Xacdm28mIS4qTX5uK2+Gy90tdFbcynHDxsw9KXb2Yj6Fg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=00hIRxLONqx+89sOGBZdZ0BNvFPX/tr/Ga097oZol8E=;
 b=cVrc9ERBkhGcKMDYheuIGoyRTCWc7fWTsnoL/7wceO6+vCQ65TA3+855kETErWXC1zaqREXvgylBEGTcP54hKhc8EujwPWpsGJJXSM2IZvIzWVhsUGN6H6+cMj2UB4D0LNY1CW4YSoFserlzSMgxDs+4nROmREAL1dUq6L2tzO93I6Em0JsuUcEHvYbDRPZ+RBaN2qiWe3lcW9MeW6HVGNDLRzx5/dUp3ATW7ymH7MipbZXiWsVNuZqW2E2xtLqfSHWVk3/ySVvU/ZlvXwP0e5a9XJN+C3TDiGABBDeWHRjhfoQ/D2toVlaH9qteXYBs3aJVLquZTnKnn/SYvSYOcg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com;
 dkim=pass header.d=oracle.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=00hIRxLONqx+89sOGBZdZ0BNvFPX/tr/Ga097oZol8E=;
 b=R9J2bIbpyyoAIDSOJtkw0O1NQnUw4d4954SxzNxdQgnEI/rRtpzb9m4IPVnBYsniflBdTG++KL84WX1qAQH6XHD1Kheqmwtl/K3LeTmqmgTzUOABfKP2v1FMrNCJtikfbmk3OstC3YfFYcqzAEdfq6zgcq7l1T//O1xI+1NHS+g=
Authentication-Results: lists.xenproject.org; dkim=none (message not signed)
 header.d=none;lists.xenproject.org; dmarc=none action=none
 header.from=oracle.com;
From: Dongli Zhang <dongli.zhang@oracle.com>
To: xen-devel@lists.xenproject.org, x86@kernel.org
Cc: boris.ostrovsky@oracle.com, jgross@suse.com, sstabellini@kernel.org,
        tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
        dave.hansen@linux.intel.com, hpa@zytor.com, joe.jin@oracle.com,
        linux-kernel@vger.kernel.org
Subject: [PATCH v2 1/1] xen: delay xen_hvm_init_time_ops() if kdump is boot on vcpu>=32
Date: Wed, 27 Oct 2021 18:25:43 -0700
Message-Id: <20211028012543.8776-1-dongli.zhang@oracle.com>
X-Mailer: git-send-email 2.17.1
Content-Type: text/plain
X-ClientProxiedBy: SN4PR0701CA0044.namprd07.prod.outlook.com
 (2603:10b6:803:2d::17) To BYAPR10MB2663.namprd10.prod.outlook.com
 (2603:10b6:a02:a9::20)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: ee9e348d-fa09-4a9f-f005-08d999b1f0e0
X-MS-TrafficTypeDiagnostic: BY5PR10MB3761:
X-Microsoft-Antispam-PRVS: 
	<BY5PR10MB3761F0B338E4D170F1F9D35FF0869@BY5PR10MB3761.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 
	GZ0PE8fRiQtK/1s94b3zXHZ978dGcJr5t2hJngZ1Nb853CSC2Yg4NTSdVZHrui0WyNyEuD2Mw4peahW/L2CZPZNcdOhZd0m4oBkPjivgOonoh+hoT0AbG38qmJJEOXtwKSfj8I6JEvmUy/u3qBaRVq7n5tvaUy40WCLM78MDkdZCM6ene7lwrK8+oEHhq4l6oaKdxKjO+Cdgi8okwM8YVb/yeADTmvomRkyGSX0WeIJY8p/Ab4ZgHURR5BQ+Jqg4PzeE8Us5D9Q/nenuQbYiThNTDnThhVHAFOYh0J3at/o7mYWAcFzCoEQMG/6wCJwTHzer0GqJlMAqhWx7zLCA94GtXEYWSP/7/LUa+Mbco9M3J4riAYUcZaQfOfQDhZMqFVtrpRPo++PVC2PDG5dcjK6fWUTnhMWlr2aJpzU4Y5N6zc/cD+N454BFzC4uK2AMLSYV9r6R7TybRuP+piDN3cBgInhhHWE8Q5PCOxPxxvBoHfKug/83sp5+/tQ2An9d9XApoZthkxlFa10YajJKHlBA3rc4XGxJJ9MevyhWePpl0kJZp+dzLNPU2+s9QHHittyv7It8c9lb8+WgecSu721YlhfJSFgPWDqnbfwX8u6Wiyiyl553oGPyVJtDKqfXB6AFEUL5n++5hvFydIsaxkQDGFy99JXmwHtsGeIepSYbEbhg+hXxc3EfS8Ndfnvk2k4XvmV4W+Ks3v+rNB0Abp37OuwzND4wIT8+XKOjFmaL3YRhLRYBNU01GFQRc8Guq3/JGDlL0dLX/221+hDjeyuOi4twWrbyPSJuonbqEgE=
X-Forefront-Antispam-Report: 
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB2663.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(36756003)(2616005)(5660300002)(38350700002)(2906002)(66556008)(86362001)(956004)(66476007)(316002)(6666004)(6506007)(38100700002)(83380400001)(186003)(6486002)(66946007)(8936002)(6512007)(508600001)(44832011)(26005)(52116002)(7416002)(4326008)(966005)(1076003)(8676002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?90jjWBT5DMTT5TE7WJ7uCYuMl3UkX10N8b6g7zr8ZQSpf2xNqKPKxKvFmsCl?=
 =?us-ascii?Q?xUHYB9TJyyOAWgD8peO0JLJBMgsaKC1Ryjqo6AEcbU55xZF/DA3L/c3yQmnk?=
 =?us-ascii?Q?dAr76I1pb3TGQGIxggg7PVYWStyZErJw3v3QXqgwi7ncbfuaSpJetsvCYFQp?=
 =?us-ascii?Q?bntFohuSaPU12yHfptFAdtwJn16mZIyifPEWUjwepe69A4nwZicC5H03Yu7N?=
 =?us-ascii?Q?mV08XCfjiqlFJm1X4MPWM7FhNjUWZV4NjS82sP8UJlztSnArPjHEiUW1pGli?=
 =?us-ascii?Q?Ahr2RMCOUcjIQeDZ/ZzOVHPeJTpzoNzirQDqK5p95AaNt0olQ07CZhZyYiWx?=
 =?us-ascii?Q?+TP2ODfCpm0JVM2pXByNU2Xus28q5Z3Y61+G39tgianMAlvHbcbEE0hI+8us?=
 =?us-ascii?Q?wo3539OIgjsSJNAdqzYJTWI/+bG0z0pcDXPaFIsOpCFbYx81Ea2bREbXIM3A?=
 =?us-ascii?Q?1BPNAkDSRyvSI3x0XcYZ6GRir7APZ6R8E4yn2sfL7wujuEPIOzuVEUSGRPaO?=
 =?us-ascii?Q?iHUJFQhNLqtOYSw5FZtdEHNVj5y5Sxt7WYHGkCfL8/ifZRSNCCpWTves6VLb?=
 =?us-ascii?Q?78PV+X+cI54COPvn4bgbTNDsQxNmwzMFyfZgP4jVGof63/roUFzp28THAUk+?=
 =?us-ascii?Q?tXmud+uQZu00LjFrj4Otd1SSEm/cXHRzwy5zeqcnkL9aSNjF+iZKYSrtYhpC?=
 =?us-ascii?Q?kLGjSfHxJHiSSWyk2s9pICsL977TMh6V6VJb/tkKlyzkLnCANuFG1T3z1PQM?=
 =?us-ascii?Q?98AObkglseytl9zuHE+oY6g7a3XGjfBQE7Nc7arAGUsecwL7D6xdSZtKcyOp?=
 =?us-ascii?Q?GdXLLwoVHuQXmgRO8b8MolF3mgOQOxDG9ABiyq2w7CjOFPDn9E/EUx9Pm0+W?=
 =?us-ascii?Q?NYo9BI53cCD6bIeVfgYczP56fi/4+S727c/q6aiuHkBuj2LH9ViUOEWC5wJY?=
 =?us-ascii?Q?c1h3dpYTKBF5ZDp4vxdVNAEqy7AW4bMaMjFYGVc55SgIQ5qzOlsFU62a40wz?=
 =?us-ascii?Q?eoDGz6Xj2EgY/8OUKOz/UHG+ZvYItwGf9YieJKuHoeAMvaYBXoIAL2cns2Y4?=
 =?us-ascii?Q?5J97rxZ5r95rjq2yXJqUsGezX/s6ZHD6LasMGNKnHtkyAEdZ3k0yWjLUpLFj?=
 =?us-ascii?Q?+NrjjC6PbEwiTLXl1HtExYiqL3nP4JSJ2YBVxafKAwFAz0Trlq5zj2FTa2Qw?=
 =?us-ascii?Q?UNZTRmpoKvsCPGmcxyJBuCUGwQOhstSuixCNePjviHUTic+TeXhLzflsTxHt?=
 =?us-ascii?Q?Dwn5SEEuk8B6KHsORQ8Gq7OnOJ5ZnmEO0birBxVVm620eBFvtjTxWSs3QzLs?=
 =?us-ascii?Q?ncRgjeqp0dP1JQSv/ZZLcoSahU96gCINlHolJmhhJ74ilRwWmgvWVX7bxtuA?=
 =?us-ascii?Q?e3IJ5BcpNguE3b/gjFVYiJcITiAlOwlQKJsG929+IhCShaLHqvifIJAmT/NR?=
 =?us-ascii?Q?7UClibjGpV4yTEnRioKcK6gW5PjhAIeetmzPHaVaQWrusQEmYjVannfxtPOX?=
 =?us-ascii?Q?OcQQVSMAIPtzRf+NPsk5hegEVhwbLFjY9OLmBWArkBk+BP9odJUiYYnJoX0v?=
 =?us-ascii?Q?fYtt9Mf/zsEGfQDWIfMG1cFBhlqVUBnsR8OJPc0K+mTuQ30ckvDE0quA2yIV?=
 =?us-ascii?Q?0fCCTiWyvhSKP3OPqcbXO18=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ee9e348d-fa09-4a9f-f005-08d999b1f0e0
X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB2663.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Oct 2021 01:26:18.1638
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Jki7SmEMuVURk2MiuuiD6+QLaRR6Q9Gcq0RGgOTkxdbW/AWGjUu80ZY9PqJgoY0dzunokPZLGHrfkqL+T8OWPA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR10MB3761
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10150 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 bulkscore=0 suspectscore=0
 mlxscore=0 adultscore=0 malwarescore=0 phishscore=0 mlxlogscore=999
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2110280006
X-Proofpoint-GUID: HVIeaRs42jHKtvGrgD95e0-5YT6Jr_vo
X-Proofpoint-ORIG-GUID: HVIeaRs42jHKtvGrgD95e0-5YT6Jr_vo

The sched_clock() can be used very early since
commit 857baa87b642 ("sched/clock: Enable sched clock early"). In addition,
with commit 38669ba205d1 ("x86/xen/time: Output xen sched_clock time from
0"), kdump kernel in Xen HVM guest may panic at very early stage when
accessing &__this_cpu_read(xen_vcpu)->time as in below:

setup_arch()
 -> init_hypervisor_platform()
     -> x86_init.hyper.init_platform = xen_hvm_guest_init()
         -> xen_hvm_init_time_ops()
             -> xen_clocksource_read()
                 -> src = &__this_cpu_read(xen_vcpu)->time;

This is because Xen HVM supports at most MAX_VIRT_CPUS=32 'vcpu_info'
embedded inside 'shared_info' during early stage until xen_vcpu_setup() is
used to allocate/relocate 'vcpu_info' for boot cpu at arbitrary address.

However, when Xen HVM guest panic on vcpu >= 32, since
xen_vcpu_info_reset(0) would set per_cpu(xen_vcpu, cpu) = NULL when
vcpu >= 32, xen_clocksource_read() on vcpu >= 32 would panic.

This patch delays xen_hvm_init_time_ops() to later in
xen_hvm_smp_prepare_boot_cpu() after the 'vcpu_info' for boot vcpu is
registered when the boot vcpu is >= 32.

Another option is to always delay xen_hvm_init_time_ops() for any vcpus
(including vcpu=0). Since to delay xen_hvm_init_time_ops() may lead to
clock backward issue, it is preferred to avoid that for regular boot (The
pv_sched_clock=native_sched_clock() is used at the very beginning until
xen_sched_clock() is registered). That requires to adjust
xen_sched_clock_offset. That's why we only delay xen_hvm_init_time_ops()
for vcpu>=32.

This issue can be reproduced on purpose via below command at the guest
side when kdump/kexec is enabled:

"taskset -c 33 echo c > /proc/sysrq-trigger"

Reference:
https://lists.xenproject.org/archives/html/xen-devel/2021-10/msg00571.html
Cc: Joe Jin <joe.jin@oracle.com>
Signed-off-by: Dongli Zhang <dongli.zhang@oracle.com>
---
Changed since v1:
  - Add commit message to explain why xen_hvm_init_time_ops() is delayed
    for any vcpus. (Suggested by Boris Ostrovsky)
  - Add a comment in xen_hvm_smp_prepare_boot_cpu() referencing the related
    code in xen_hvm_guest_init(). (suggested by Juergen Gross)

 arch/x86/xen/enlighten_hvm.c | 20 +++++++++++++++++++-
 arch/x86/xen/smp_hvm.c       |  8 ++++++++
 2 files changed, 27 insertions(+), 1 deletion(-)

diff --git a/arch/x86/xen/enlighten_hvm.c b/arch/x86/xen/enlighten_hvm.c
index e68ea5f4ad1c..7734dec52794 100644
--- a/arch/x86/xen/enlighten_hvm.c
+++ b/arch/x86/xen/enlighten_hvm.c
@@ -216,7 +216,25 @@ static void __init xen_hvm_guest_init(void)
 	WARN_ON(xen_cpuhp_setup(xen_cpu_up_prepare_hvm, xen_cpu_dead_hvm));
 	xen_unplug_emulated_devices();
 	x86_init.irqs.intr_init = xen_init_IRQ;
-	xen_hvm_init_time_ops();
+
+	/*
+	 * Only MAX_VIRT_CPUS 'vcpu_info' are embedded inside 'shared_info'
+	 * and the VM would use them until xen_vcpu_setup() is used to
+	 * allocate/relocate them at arbitrary address.
+	 *
+	 * However, when Xen HVM guest panic on vcpu >= MAX_VIRT_CPUS,
+	 * per_cpu(xen_vcpu, cpu) is still NULL at this stage. To access
+	 * per_cpu(xen_vcpu, cpu) via xen_clocksource_read() would panic.
+	 *
+	 * Therefore we delay xen_hvm_init_time_ops() to
+	 * xen_hvm_smp_prepare_boot_cpu() when boot vcpu is >= MAX_VIRT_CPUS.
+	 */
+	if (xen_vcpu_nr(0) >= MAX_VIRT_CPUS)
+		pr_info("Delay xen_hvm_init_time_ops() as kernel is running on vcpu=%d\n",
+			xen_vcpu_nr(0));
+	else
+		xen_hvm_init_time_ops();
+
 	xen_hvm_init_mmu_ops();
 
 #ifdef CONFIG_KEXEC_CORE
diff --git a/arch/x86/xen/smp_hvm.c b/arch/x86/xen/smp_hvm.c
index 6ff3c887e0b9..f99043df8bb5 100644
--- a/arch/x86/xen/smp_hvm.c
+++ b/arch/x86/xen/smp_hvm.c
@@ -19,6 +19,14 @@ static void __init xen_hvm_smp_prepare_boot_cpu(void)
 	 */
 	xen_vcpu_setup(0);
 
+	/*
+	 * The xen_hvm_init_time_ops() is delayed from
+	 * xen_hvm_guest_init() to here to avoid panic when the kernel
+	 * boots from vcpu>=MAX_VIRT_CPUS (32).
+	 */
+	if (xen_vcpu_nr(0) >= MAX_VIRT_CPUS)
+		xen_hvm_init_time_ops();
+
 	/*
 	 * The alternative logic (which patches the unlock/lock) runs before
 	 * the smp bootup up code is activated. Hence we need to set this up
-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Thu Oct 28 01:28:25 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Oct 2021 01:28:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217585.377690 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfuDG-0007FG-2b; Thu, 28 Oct 2021 01:28:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217585.377690; Thu, 28 Oct 2021 01:28:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfuDF-0007F9-Ug; Thu, 28 Oct 2021 01:28:13 +0000
Received: by outflank-mailman (input) for mailman id 217585;
 Thu, 28 Oct 2021 01:28:12 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=TkaK=PQ=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1mfuDE-0007DF-Fq
 for xen-devel@lists.xenproject.org; Thu, 28 Oct 2021 01:28:12 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 500f2842-378e-11ec-8493-12813bfff9fa;
 Thu, 28 Oct 2021 01:28:11 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id 63C0E60F56;
 Thu, 28 Oct 2021 01:28:10 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 500f2842-378e-11ec-8493-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1635384490;
	bh=/SSWR3C7/EFbNOMT4a7VbNksXhwttXyDyCOgW8/+9o4=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=uTLG0uLy2rMhIXZATdlVQ02SNddE8n59TcHIess2YsKlSp957d4y/uv0vqufOTM4k
	 rErWJE2paJcCoPn9jTtHjgxsEkwHDzRnFxQ1PvR9JDZX2Z4aKLX0V5Bzf97n6ydWTr
	 32y08ShXCj/uVPtH1ffJ4lTZo5mW/IzYl6NqVsuWa2ntNDtOh7pC+lpizsDlXAlfnZ
	 GMc4z+7ffJV7xXy+QSDnabq90mk50KVk8qLDP2jPan47OBKqyhZECc2dZ4+qE+GorY
	 77njjyVKAC920D1pemGJPKzlLIrJ/h2G5VSyWeuXB3fkyKpM9SBN6y0YRvWr9qCu/G
	 hIGYfbA9ger8Q==
Date: Wed, 27 Oct 2021 18:28:08 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Oleksandr Tyshchenko <olekstysh@gmail.com>
cc: xen-devel@lists.xenproject.org, linux-arm-kernel@lists.infradead.org, 
    linux-kernel@vger.kernel.org, 
    Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, 
    Stefano Stabellini <sstabellini@kernel.org>, 
    Russell King <linux@armlinux.org.uk>, Julien Grall <julien@xen.org>
Subject: Re: [PATCH V2 2/4] arm/xen: Switch to use gnttab_setup_auto_xlat_frames()
 for DT
In-Reply-To: <1635264312-3796-3-git-send-email-olekstysh@gmail.com>
Message-ID: <alpine.DEB.2.21.2110271754400.20134@sstabellini-ThinkPad-T480s>
References: <1635264312-3796-1-git-send-email-olekstysh@gmail.com> <1635264312-3796-3-git-send-email-olekstysh@gmail.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Tue, 26 Oct 2021, Oleksandr Tyshchenko wrote:
> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> 
> Read the start address of the grant table space from DT
> (region 0).
> 
> This patch mostly restores behaviour before commit 3cf4095d7446
> ("arm/xen: Use xen_xlate_map_ballooned_pages to setup grant table")
> but trying not to break the ACPI support added after that commit.
> So the patch touches DT part only and leaves the ACPI part with
> xen_xlate_map_ballooned_pages().
> 
> This is a preparation for using Xen extended region feature
> where unused regions of guest physical address space (provided
> by the hypervisor) will be used to create grant/foreign/whatever
> mappings instead of wasting real RAM pages from the domain memory
> for establishing these mappings.
> 
> The immediate benefit of this change:
> - Avoid superpage shattering in Xen P2M when establishing
>   stage-2 mapping (GFN <-> MFN) for the grant table space
> - Avoid wasting real RAM pages (reducing the amount of memory
>   usuable) for mapping grant table space
> - The grant table space is always mapped at the exact
>   same place (region 0 is reserved for the grant table)
> 
> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> ---
> Changes RFC -> V2:
>    - new patch
> ---
>  arch/arm/xen/enlighten.c | 32 +++++++++++++++++++++++++-------
>  1 file changed, 25 insertions(+), 7 deletions(-)
> 
> diff --git a/arch/arm/xen/enlighten.c b/arch/arm/xen/enlighten.c
> index 7f1c106b..dea46ec 100644
> --- a/arch/arm/xen/enlighten.c
> +++ b/arch/arm/xen/enlighten.c
> @@ -59,6 +59,9 @@ unsigned long xen_released_pages;
>  struct xen_memory_region xen_extra_mem[XEN_EXTRA_MEM_MAX_REGIONS] __initdata;
>  
>  static __read_mostly unsigned int xen_events_irq;
> +static phys_addr_t xen_grant_frames;

__read_mostly


> +#define GRANT_TABLE_INDEX   0
>  
>  uint32_t xen_start_flags;
>  EXPORT_SYMBOL(xen_start_flags);
> @@ -303,6 +306,7 @@ static void __init xen_acpi_guest_init(void)
>  static void __init xen_dt_guest_init(void)
>  {
>  	struct device_node *xen_node;
> +	struct resource res;
>  
>  	xen_node = of_find_compatible_node(NULL, NULL, "xen,xen");
>  	if (!xen_node) {
> @@ -310,6 +314,12 @@ static void __init xen_dt_guest_init(void)
>  		return;
>  	}
>  
> +	if (of_address_to_resource(xen_node, GRANT_TABLE_INDEX, &res)) {
> +		pr_err("Xen grant table region is not found\n");
> +		return;
> +	}
> +	xen_grant_frames = res.start;
> +
>  	xen_events_irq = irq_of_parse_and_map(xen_node, 0);
>  }
>  
> @@ -317,16 +327,20 @@ static int __init xen_guest_init(void)
>  {
>  	struct xen_add_to_physmap xatp;
>  	struct shared_info *shared_info_page = NULL;
> -	int cpu;
> +	int rc, cpu;
>  
>  	if (!xen_domain())
>  		return 0;
>  
>  	if (!acpi_disabled)
>  		xen_acpi_guest_init();
> -	else
> +	else {
>  		xen_dt_guest_init();
>  
> +		if (!xen_grant_frames)
> +			return -ENODEV;

maybe we can avoid this, see below


> +	}
> +
>  	if (!xen_events_irq) {
>  		pr_err("Xen event channel interrupt not found\n");
>  		return -ENODEV;
> @@ -370,12 +384,16 @@ static int __init xen_guest_init(void)
>  	for_each_possible_cpu(cpu)
>  		per_cpu(xen_vcpu_id, cpu) = cpu;
>  
> -	xen_auto_xlat_grant_frames.count = gnttab_max_grant_frames();
> -	if (xen_xlate_map_ballooned_pages(&xen_auto_xlat_grant_frames.pfn,
> -					  &xen_auto_xlat_grant_frames.vaddr,
> -					  xen_auto_xlat_grant_frames.count)) {
> +	if (!acpi_disabled) {

To make the code more resilient couldn't we do:

if (!acpi_disabled || !xen_grant_frames) {


> +		xen_auto_xlat_grant_frames.count = gnttab_max_grant_frames();
> +		rc = xen_xlate_map_ballooned_pages(&xen_auto_xlat_grant_frames.pfn,
> +										   &xen_auto_xlat_grant_frames.vaddr,
> +										   xen_auto_xlat_grant_frames.count);
> +	} else
> +		rc = gnttab_setup_auto_xlat_frames(xen_grant_frames);
> +	if (rc) {
>  		free_percpu(xen_vcpu_info);
> -		return -ENOMEM;
> +		return rc;
>  	}
>  	gnttab_init();



From xen-devel-bounces@lists.xenproject.org Thu Oct 28 01:40:23 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Oct 2021 01:40:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217597.377701 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfuOs-0001HY-7G; Thu, 28 Oct 2021 01:40:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217597.377701; Thu, 28 Oct 2021 01:40:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfuOs-0001HQ-0i; Thu, 28 Oct 2021 01:40:14 +0000
Received: by outflank-mailman (input) for mailman id 217597;
 Thu, 28 Oct 2021 01:40:12 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=TkaK=PQ=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1mfuOq-0001H1-K4
 for xen-devel@lists.xenproject.org; Thu, 28 Oct 2021 01:40:12 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id fd3dfeac-378f-11ec-8493-12813bfff9fa;
 Thu, 28 Oct 2021 01:40:11 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id 6090461100;
 Thu, 28 Oct 2021 01:40:10 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fd3dfeac-378f-11ec-8493-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1635385210;
	bh=X288Vb/CllN4w89yrsjxckKoO24AoOFwTC+Y1bZLW54=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=dLx+k5vKHRPbn9SEh146uGicFOvuXY5hlgq84dMgd0XlKDUkNwmGh745Eyvj4Tlkx
	 pHv0CQlLN2Fidfqzl0WpeQDhbO/RBotviUoP2VDpTIdNCIX7X8A4m4X08HkZJALyWI
	 7ivVD1MqmiC1bJTRItBaeEKM+7Nk8Ko5TgySx/QtN4O1PvNkY/keYwy69+VKQ1sATC
	 arysC86WNTzxHzO7S/sZSF6w+99XpzZQPSoGRAf1TTPnCRy06usB4DGmBn7YSNCElT
	 k1qmQvsrlO6vu7CUGNmLhuL+jRnU1WkrW0f8w540sMVT99qapAMoKKqkrpxrjQjV1B
	 cAKl+pORy1r9A==
Date: Wed, 27 Oct 2021 18:40:09 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Oleksandr Tyshchenko <olekstysh@gmail.com>
cc: xen-devel@lists.xenproject.org, linux-arm-kernel@lists.infradead.org, 
    linux-kernel@vger.kernel.org, 
    Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, 
    Stefano Stabellini <sstabellini@kernel.org>, 
    Russell King <linux@armlinux.org.uk>, 
    Boris Ostrovsky <boris.ostrovsky@oracle.com>, 
    Juergen Gross <jgross@suse.com>, Julien Grall <julien@xen.org>
Subject: Re: [PATCH V2 4/4] arm/xen: Read extended regions from DT and init
 Xen resource
In-Reply-To: <1635264312-3796-5-git-send-email-olekstysh@gmail.com>
Message-ID: <alpine.DEB.2.21.2110271803060.20134@sstabellini-ThinkPad-T480s>
References: <1635264312-3796-1-git-send-email-olekstysh@gmail.com> <1635264312-3796-5-git-send-email-olekstysh@gmail.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: multipart/mixed; BOUNDARY="8323329-800219594-1635384450=:20134"
Content-ID: <alpine.DEB.2.21.2110271827430.20134@sstabellini-ThinkPad-T480s>

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-800219594-1635384450=:20134
Content-Type: text/plain; CHARSET=UTF-8
Content-Transfer-Encoding: 8BIT
Content-ID: <alpine.DEB.2.21.2110271827431.20134@sstabellini-ThinkPad-T480s>

On Tue, 26 Oct 2021, Oleksandr Tyshchenko wrote:
> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> 
> This patch implements arch_xen_unpopulated_init() on Arm where
> the extended regions (if any) are gathered from DT and inserted
> into passed Xen resource to be used as unused address space
> for Xen scratch pages by unpopulated-alloc code.
> 
> The extended region (safe range) is a region of guest physical
> address space which is unused and could be safely used to create
> grant/foreign mappings instead of wasting real RAM pages from
> the domain memory for establishing these mappings.
> 
> The extended regions are chosen by the hypervisor at the domain
> creation time and advertised to it via "reg" property under
> hypervisor node in the guest device-tree. As region 0 is reserved
> for grant table space (always present), the indexes for extended
> regions are 1...N.
> 
> If arch_xen_unpopulated_init() fails for some reason the default
> behaviour will be restored (allocate xenballooned pages).
> 
> This patch also removes XEN_UNPOPULATED_ALLOC dependency on x86.
> 
> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> ---
> Changes RFC -> V2:
>    - new patch, instead of
>     "[RFC PATCH 2/2] xen/unpopulated-alloc: Query hypervisor to provide unallocated space"
> ---
>  arch/arm/xen/enlighten.c | 112 +++++++++++++++++++++++++++++++++++++++++++++++
>  drivers/xen/Kconfig      |   2 +-
>  2 files changed, 113 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/xen/enlighten.c b/arch/arm/xen/enlighten.c
> index dea46ec..1a1e0d3 100644
> --- a/arch/arm/xen/enlighten.c
> +++ b/arch/arm/xen/enlighten.c
> @@ -62,6 +62,7 @@ static __read_mostly unsigned int xen_events_irq;
>  static phys_addr_t xen_grant_frames;
>  
>  #define GRANT_TABLE_INDEX   0
> +#define EXT_REGION_INDEX    1
>  
>  uint32_t xen_start_flags;
>  EXPORT_SYMBOL(xen_start_flags);
> @@ -303,6 +304,117 @@ static void __init xen_acpi_guest_init(void)
>  #endif
>  }
>  
> +#ifdef CONFIG_XEN_UNPOPULATED_ALLOC
> +int arch_xen_unpopulated_init(struct resource *res)
> +{
> +	struct device_node *np;
> +	struct resource *regs, *tmp_res;
> +	uint64_t min_gpaddr = -1, max_gpaddr = 0;
> +	unsigned int i, nr_reg = 0;
> +	struct range mhp_range;
> +	int rc;
> +
> +	if (!xen_domain())
> +		return -ENODEV;
> +
> +	np = of_find_compatible_node(NULL, NULL, "xen,xen");
> +	if (WARN_ON(!np))
> +		return -ENODEV;
> +
> +	/* Skip region 0 which is reserved for grant table space */
> +	while (of_get_address(np, nr_reg + EXT_REGION_INDEX, NULL, NULL))
> +		nr_reg++;
> +	if (!nr_reg) {
> +		pr_err("No extended regions are found\n");
> +		return -EINVAL;
> +	}
> +
> +	regs = kcalloc(nr_reg, sizeof(*regs), GFP_KERNEL);
> +	if (!regs)
> +		return -ENOMEM;
> +
> +	/*
> +	 * Create resource from extended regions provided by the hypervisor to be
> +	 * used as unused address space for Xen scratch pages.
> +	 */
> +	for (i = 0; i < nr_reg; i++) {
> +		rc = of_address_to_resource(np, i + EXT_REGION_INDEX, &regs[i]);
> +		if (rc)
> +			goto err;
> +
> +		if (max_gpaddr < regs[i].end)
> +			max_gpaddr = regs[i].end;
> +		if (min_gpaddr > regs[i].start)
> +			min_gpaddr = regs[i].start;
> +	}
> +
> +	/* Check whether the resource range is within the hotpluggable range */
> +	mhp_range = mhp_get_pluggable_range(true);
> +	if (min_gpaddr < mhp_range.start)
> +		min_gpaddr = mhp_range.start;
> +	if (max_gpaddr > mhp_range.end)
> +		max_gpaddr = mhp_range.end;
> +
> +	res->start = min_gpaddr;
> +	res->end = max_gpaddr;
> +
> +	/*
> +	 * Mark holes between extended regions as unavailable. The rest of that
> +	 * address space will be available for the allocation.
> +	 */
> +	for (i = 1; i < nr_reg; i++) {
> +		resource_size_t start, end;
> +
> +		start = regs[i - 1].end + 1;
> +		end = regs[i].start - 1;
> +
> +		if (start > (end + 1)) {

Should this be:

if (start >= end)

?


> +			rc = -EINVAL;
> +			goto err;
> +		}
> +
> +		/* There is no hole between regions */
> +		if (start == (end + 1))

Also here, shouldn't it be:

if (start == end)

?

I think I am missing again something in termination accounting :-)


> +			continue;
> +
> +		/* Check whether the hole range is within the resource range */
> +		if (start < res->start || end > res->end) {

By definition I don't think this check is necessary as either condition
is impossible?


> +			if (start < res->start)
> +				start = res->start;
> +			if (end > res->end)
> +				end = res->end;
> +
> +			if (start >= (end + 1))
> +				continue;
> +		}
> +
> +		tmp_res = kzalloc(sizeof(*tmp_res), GFP_KERNEL);
> +		if (!tmp_res) {
> +			rc = -ENOMEM;
> +			goto err;
> +		}
> +
> +		tmp_res->name = "Unavailable space";
> +		tmp_res->start = start;
> +		tmp_res->end = end;

Do we need to set any flags so that the system can reuse the memory in
the hole, e.g. IORESOURCE_MEM? Or is it not necessary?


> +		rc = insert_resource(res, tmp_res);
> +		if (rc) {
> +			pr_err("Cannot insert resource [%llx - %llx] %d\n",
> +					tmp_res->start, tmp_res->end, rc);

Although it is impossible to enable XEN_UNPOPULATED_ALLOC on arm32 due
to unmet dependencies, I would like to keep the implementation of
arch_xen_unpopulated_init 32bit clean.

I am getting build errors like (by forcing arch_xen_unpopulated_init to
compile on arm32):

./include/linux/kern_levels.h:5:18: warning: format ‘%llx’ expects argument of type ‘long long unsigned int’, but argument 3 has type ‘resource_size_t {aka unsigned int}’ [-Wformat=]


> +			kfree(tmp_res);
> +			goto err;
> +		}
> +	}
> +
> +err:
> +	kfree(regs);
> +
> +	return rc;
> +}
> +#endif
> +
>  static void __init xen_dt_guest_init(void)
>  {
>  	struct device_node *xen_node;
> diff --git a/drivers/xen/Kconfig b/drivers/xen/Kconfig
> index 1b2c3ac..e6031fc 100644
> --- a/drivers/xen/Kconfig
> +++ b/drivers/xen/Kconfig
> @@ -297,7 +297,7 @@ config XEN_FRONT_PGDIR_SHBUF
>  
>  config XEN_UNPOPULATED_ALLOC
>  	bool "Use unpopulated memory ranges for guest mappings"
> -	depends on X86 && ZONE_DEVICE
> +	depends on ZONE_DEVICE
>  	default XEN_BACKEND || XEN_GNTDEV || XEN_DOM0
>  	help
>  	  Use unpopulated memory ranges in order to create mappings for guest
--8323329-800219594-1635384450=:20134--


From xen-devel-bounces@lists.xenproject.org Thu Oct 28 03:07:33 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Oct 2021 03:07:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217614.377711 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfvl0-000105-IQ; Thu, 28 Oct 2021 03:07:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217614.377711; Thu, 28 Oct 2021 03:07:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfvl0-0000zy-FK; Thu, 28 Oct 2021 03:07:10 +0000
Received: by outflank-mailman (input) for mailman id 217614;
 Thu, 28 Oct 2021 03:07:09 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mfvkz-0000zo-Tz; Thu, 28 Oct 2021 03:07:09 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mfvkz-0004de-M0; Thu, 28 Oct 2021 03:07:09 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mfvkz-00066E-DK; Thu, 28 Oct 2021 03:07:09 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mfvkz-0007c2-BK; Thu, 28 Oct 2021 03:07:09 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=zIrPb+sa83AcD+AfQrD6XdhENwZcU9iCVvdfhXhG8CY=; b=0AVSI8EkzxwVc16LD/cf3lwwrO
	/j02p0Uv4qYsXc2kSX0RMm0ZbFC1MqslD7qAAA0qWIJ+tj1WFgR+My3TS0J8dtou/1k4NixWGdg2d
	I15Hswgq+htWo7b42ymLJEGF//+uOGkt1AIsYo3uEmVyZ3EiFr0Iovrh08VS7adVJD5k=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165893-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-5.4 test] 165893: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-5.4:test-armhf-armhf-libvirt-raw:debian-di-install:fail:heisenbug
    linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=89b6869b942b8730467f2a0760ea466044aa52d2
X-Osstest-Versions-That:
    linux=4f508aa9dd3bde7a1c5e4e6de72abb8a03fd504a
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 28 Oct 2021 03:07:09 +0000

flight 165893 linux-5.4 real [real]
flight 165918 linux-5.4 real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/165893/
http://logs.test-lab.xenproject.org/osstest/logs/165918/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-armhf-armhf-libvirt-raw 12 debian-di-install   fail pass in 165918-retest

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail in 165918 like 165696
 test-armhf-armhf-libvirt-raw 14 migrate-support-check fail in 165918 never pass
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165696
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 165696
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 165696
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 165696
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165696
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165696
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 165696
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 165696
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 165696
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 165696
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 165696
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 linux                89b6869b942b8730467f2a0760ea466044aa52d2
baseline version:
 linux                4f508aa9dd3bde7a1c5e4e6de72abb8a03fd504a

Last test of basis   165696  2021-10-21 00:12:55 Z    7 days
Testing same since   165893  2021-10-27 08:12:24 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Aleksander Jan Bajkowski <olek2@wp.pl>
  Andrew Morton <akpm@linux-foundation.org>
  Antoine Tenart <atenart@kernel.org>
  Arnd Bergmann <arnd@arndb.de>
  Ayumi Nakamichi <ayumi.nakamichi.kf@renesas.com>
  Benjamin Coddington <bcodding@redhat.com>
  Biju Das <biju.das.jz@bp.renesas.com>
  Brendan Grieve <brendan@grieve.com.au>
  Brendan Higgins <brendanhiggins@google.com>
  Charles Keepax <ckeepax@opensource.cirrus.com>
  Christian Brauner <christian.brauner@ubuntu.com>
  Christoph Hellwig <hch@lst.de>
  Christopher M. Riedl <cmr@codefail.de>
  Chuck Lever <chuck.lever@oracle.com>
  David S. Miller <davem@davemloft.net>
  David Sterba <dsterba@suse.com>
  Dexuan Cui <decui@microsoft.com>
  Dinh Nguyen <dinguyen@kernel.org>
  Dmitry Torokhov <dmitry.torokhov@gmail.com>
  Eugen Hristev <eugen.hristev@microchip.com>
  Fabien Dessenne <fabien.dessenne@foss.st.com>
  Filipe Manana <fdmanana@suse.com>
  Florian Fainelli <f.fainelli@gmail.com>
  Florian Westphal <fw@strlen.de>
  Gang He <ghe@suse.com>
  Gaosheng Cui <cuigaosheng1@huawei.com>
  Gerald Schaefer <gerald.schaefer@linux.ibm.com>
  Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  Guangbin Huang <huangguangbin2@huawei.com>
  Guenter Roeck <linux@roeck-us.net>
  Hans de Goede <hdegoede@redhat.com>
  Hauke Mehrtens <hauke@hauke-m.de>
  Helge Deller <deller@gmx.de>
  Herve Codina <herve.codina@bootlin.com>
  Ido Schimmel <idosch@mellanox.com>
  Ilya Dryomov <idryomov@gmail.com>
  Jakub Kicinski <kuba@kernel.org>
  Jan Kara <jack@suse.cz>
  Jeff Layton <jlayton@kernel.org>
  Jens Wiklander <jens.wiklander@linaro.org>
  Joseph Qi <joseph.qi@linux.alibaba.com>
  Julian Anastasov <ja@ssi.bg>
  Kai Vehmanen <kai.vehmanen@linux.intel.com>
  Kees Cook <keescook@chromium.org>
  Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
  Kurt Kanzenbach <kurt@linutronix.de>
  Lin Ma <linma@zju.edu.cn>
  Linus Torvalds <torvalds@linux-foundation.org>
  Linus Walleij <linus.walleij@linaro.org>
  Linux Kernel Functional Testing <lkft@linaro.org>
  Lukas Bulwahn <lukas.bulwahn@gmail.com>
  Marc Kleine-Budde <mkl@pengutronix.de>
  Mark Brown <broonie@kernel.org>
  Martin K. Petersen <martin.petersen@oracle.com>
  Matthew Wilcox (Oracle) <willy@infradead.org>
  Max Filippov <jcmvbkbc@gmail.com>
  Miaohe Lin <linmiaohe@huawei.com>
  Michael Ellerman <mpe@ellerman.id.au>
  Nathan Chancellor <nathan@kernel.org>
  Nick Desaulniers <ndesaulniers@google.com>
  Nicolas Ferre <nicolas.ferre@microchip.com>
  Oleksij Rempel <o.rempel@pengutronix.de>
  Pablo Neira Ayuso <pablo@netfilter.org>
  Paul Moore <paul@paul-moore.com>
  Peng Li <lipeng321@huawei.com>
  Prashant Malani <pmalani@chromium.org>
  Randy Dunlap <rdunlap@infradead.org>
  Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
  Russell King <rmk+kernel@armlinux.org.uk>
  Sasha Levin <sashal@kernel.org>
  Shengjiu Wang <shengjiu.wang@nxp.com>
  Shuah Khan <skhan@linuxfoundation.org>
  Stephane Grosjean <s.grosjean@peak-system.com>
  Steven Clarkson <sc@lambdal.com>
  Steven Rostedt (VMware) <rostedt@goodmis.org>
  Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
  Sumit Garg <sumit.garg@linaro.org>
  Takashi Iwai <tiwai@suse.de>
  Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
  Valentin Vidic <vvidic@valentin-vidic.from.hr>
  Vegard Nossum <vegard.nossum@gmail.com>
  Vegard Nossum <vegard.nossum@oracle.com>
  Vladimir Oltean <vladimir.oltean@nxp.com>
  Xiaolong Huang <butterflyhuangxx@gmail.com>
  Yanfei Xu <yanfei.xu@windriver.com>
  Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
  Zhang Changzhong <zhangchangzhong@huawei.com>
  Zheyu Ma <zheyuma97@gmail.com>
  Ziyang Xuan <william.xuanziyang@huawei.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 fail    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   4f508aa9dd3b..89b6869b942b  89b6869b942b8730467f2a0760ea466044aa52d2 -> tested/linux-5.4


From xen-devel-bounces@lists.xenproject.org Thu Oct 28 04:23:00 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Oct 2021 04:23:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217515.377726 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfwvz-0000MJ-Qe; Thu, 28 Oct 2021 04:22:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217515.377726; Thu, 28 Oct 2021 04:22:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfwvz-0000MC-MO; Thu, 28 Oct 2021 04:22:35 +0000
Received: by outflank-mailman (input) for mailman id 217515;
 Wed, 27 Oct 2021 23:09:10 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=EXXu=PP=dabbelt.com=palmer@srs-us1.protection.inumbo.net>)
 id 1mfs2f-0004Hw-Q0
 for xen-devel@lists.xenproject.org; Wed, 27 Oct 2021 23:09:09 +0000
Received: from mail-pj1-x102d.google.com (unknown [2607:f8b0:4864:20::102d])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 9f7c6ad4-4552-412e-98d4-8eab26454eb9;
 Wed, 27 Oct 2021 23:09:08 +0000 (UTC)
Received: by mail-pj1-x102d.google.com with SMTP id
 v1-20020a17090a088100b001a21156830bso6416842pjc.1
 for <xen-devel@lists.xenproject.org>; Wed, 27 Oct 2021 16:09:08 -0700 (PDT)
Received: from localhost ([2620:0:1000:5e10:60fc:a50:6d27:9fd3])
 by smtp.gmail.com with ESMTPSA id bg15sm739067pjb.15.2021.10.27.16.09.07
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Wed, 27 Oct 2021 16:09:07 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9f7c6ad4-4552-412e-98d4-8eab26454eb9
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=dabbelt-com.20210112.gappssmtp.com; s=20210112;
        h=date:subject:in-reply-to:cc:from:to:message-id:mime-version
         :content-transfer-encoding;
        bh=XJfFTW9EjYJeHoclf1SeEwj25PLenE7ts5EFTr8vzec=;
        b=vYjyS+8EH3CfIBezSrdmSEFFSJc1bpK8IsDLNwp4SIdgzIr0qhB73jSdQ+tZtt+gKe
         gLRCAnofL8DMkcE7vLBKcZfntvEYsCybXJMFIekVgyaoqoB4d2yoy2/fxl6NKOgXIYmd
         GMEiLNFKg0iVmrnBvlpV4pv/PV+nqVeQwlB1PLBrwM8b8vjtjZjGvc3MJRrAfuUoDBNo
         ViaF9lo0gQuECLSnf0dUVzQmZPRvjI+cvfCWgH2cYeMbb2VhrXJlj9sEs5Y4vYC263de
         h2wbGwEHNdbZkGS/4AP/MxQ7HKYBbqiVTjD7lo6//33sqHBHnP35ISg1TmvMKaMznq9A
         cKAw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:date:subject:in-reply-to:cc:from:to:message-id
         :mime-version:content-transfer-encoding;
        bh=XJfFTW9EjYJeHoclf1SeEwj25PLenE7ts5EFTr8vzec=;
        b=7GwE/ug7EqExXnf4YaKKfqFiIF79hXKnK0oP6JIek87r52/R4LTQnSIEs9SbIs6iJl
         rFtH1O/90GpluSzmDlETlxKUriuKhf8hmHvDx3jF6QNOInF0zNFqutx4/rJbEU6QJNDw
         YTDOO9qQtO4MlHN2ym2bJRwkCf5jucxhn7meFIOQ9Ab7XxWM+31i42m87erukPa0DsnA
         v9cr57m4L/NzPR+4CckTorwdNvK8zdoVaxowgYYE0JjDak5wv5FJRrApIz0p1MQe9TCD
         3guUzXjhj4fXbitGHzYbhuLyi4ODs/BR0X+I1Po+HW/zTePdaLOQhQvN14bo+O3OSQSK
         vp3Q==
X-Gm-Message-State: AOAM531OcxR/6dgSu33Q8ea79mgFWu3sN2A3KKvqhQCvRpr2yPQE2NtW
	+FKGLZ4HlcOIRMWGSy5iyom22A==
X-Google-Smtp-Source: ABdhPJxUJYglQ4uyqyrvUHQJ2HBzLbAnkI4OfP0sJtC8YPLND6BbQ0gKrpcxmED13rpzsyQoceaG3g==
X-Received: by 2002:a17:903:246:b0:13f:2ff9:8b93 with SMTP id j6-20020a170903024600b0013f2ff98b93mr652035plh.54.1635376148047;
        Wed, 27 Oct 2021 16:09:08 -0700 (PDT)
Date: Wed, 27 Oct 2021 16:09:07 -0700 (PDT)
X-Google-Original-Date: Wed, 27 Oct 2021 16:09:01 PDT (-0700)
Subject:     Re: [PATCH v2 18/45] riscv: Use do_kernel_power_off()
In-Reply-To: <20211027211715.12671-19-digetx@gmail.com>
CC: thierry.reding@gmail.com, jonathanh@nvidia.com, lee.jones@linaro.org,
  rafael@kernel.org, broonie@kernel.org, akpm@linux-foundation.org, linux@roeck-us.net,
  linux@armlinux.org.uk, daniel.lezcano@linaro.org, andriy.shevchenko@linux.intel.com,
  ulf.hansson@linaro.org, catalin.marinas@arm.com, will@kernel.org, guoren@kernel.org,
  geert@linux-m68k.org, gerg@linux-m68k.org, funaho@jurai.org, tsbogend@alpha.franken.de,
  nickhu@andestech.com, green.hu@gmail.com, deanbo422@gmail.com, James.Bottomley@HansenPartnership.com,
  deller@gmx.de, mpe@ellerman.id.au, benh@kernel.crashing.org, paulus@samba.org,
  Paul Walmsley <paul.walmsley@sifive.com>, aou@eecs.berkeley.edu, ysato@users.sourceforge.jp, dalias@libc.org,
  tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org,
  hpa@zytor.com, boris.ostrovsky@oracle.com, jgross@suse.com, sstabellini@kernel.org,
  lenb@kernel.org, ssantosh@kernel.org, krzysztof.kozlowski@canonical.com,
  linus.walleij@linaro.org, wens@csie.org, j.neuschaefer@gmx.net, tony@atomide.com, lgirdwood@gmail.com,
  p.zabel@pengutronix.de, vz@mleia.com, avifishman70@gmail.com, tmaimon77@gmail.com,
  tali.perry1@gmail.com, venture@google.com, yuenn@google.com, benjaminfair@google.com, pavel@ucw.cz,
  linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-csky@vger.kernel.org,
  linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org,
  linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org,
  linux-sh@vger.kernel.org, xen-devel@lists.xenproject.org, linux-acpi@vger.kernel.org,
  linux-omap@vger.kernel.org, openbmc@lists.ozlabs.org, linux-tegra@vger.kernel.org,
  linux-pm@vger.kernel.org
From: Palmer Dabbelt <palmer@dabbelt.com>
To: digetx@gmail.com
Message-ID: <mhng-fd8f451c-4860-4b0c-a155-6f65891cd276@palmerdabbelt-glaptop>
Mime-Version: 1.0 (MHng)
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit

On Wed, 27 Oct 2021 14:16:48 PDT (-0700), digetx@gmail.com wrote:
> Kernel now supports chained power-off handlers. Use do_kernel_power_off()
> that invokes chained power-off handlers. It also invokes legacy
> pm_power_off() for now, which will be removed once all drivers will
> be converted to the new power-off API.
>
> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
> ---
>  arch/riscv/kernel/reset.c | 12 ++++--------
>  1 file changed, 4 insertions(+), 8 deletions(-)
>
> diff --git a/arch/riscv/kernel/reset.c b/arch/riscv/kernel/reset.c
> index 9c842c41684a..912288572226 100644
> --- a/arch/riscv/kernel/reset.c
> +++ b/arch/riscv/kernel/reset.c
> @@ -23,16 +23,12 @@ void machine_restart(char *cmd)
>
>  void machine_halt(void)
>  {
> -	if (pm_power_off != NULL)
> -		pm_power_off();
> -	else
> -		default_power_off();
> +	do_kernel_power_off();
> +	default_power_off();
>  }
>
>  void machine_power_off(void)
>  {
> -	if (pm_power_off != NULL)
> -		pm_power_off();
> -	else
> -		default_power_off();
> +	do_kernel_power_off();
> +	default_power_off();
>  }

Acked-by: Palmer Dabbelt <palmer@dabbelt.com>


From xen-devel-bounces@lists.xenproject.org Thu Oct 28 05:43:10 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Oct 2021 05:43:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217636.377736 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfyBY-00005c-Ly; Thu, 28 Oct 2021 05:42:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217636.377736; Thu, 28 Oct 2021 05:42:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfyBY-00005V-Iv; Thu, 28 Oct 2021 05:42:44 +0000
Received: by outflank-mailman (input) for mailman id 217636;
 Thu, 28 Oct 2021 05:42:43 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mfyBX-00005J-JD; Thu, 28 Oct 2021 05:42:43 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mfyBX-0007pA-DQ; Thu, 28 Oct 2021 05:42:43 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mfyBX-0003ru-0A; Thu, 28 Oct 2021 05:42:43 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mfyBW-0008U9-Vx; Thu, 28 Oct 2021 05:42:42 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=cdwjCrbDw5peYfQyjGd+o54N0hjwPBe7BOsmjO2KGnE=; b=YnF8dxtMXQovLyKLSmC8CMsHBV
	GIFoHJwwQ7HA8L+HVNXtertV9KWMkD1vGM/DFQdxNEmVFKOzVzZz5b7GQJnqg2iQjBl9W4nMvoQDj
	BIDCH2blKTYAkf5dojjKE4xr7lxGLEGkMtVrBWGeHZrmibvERKoqYaH64XQyH3sZVDlU=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165916-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 165916: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=1fc596a56b334f4d593a2b49e5ff55af6aaa0816
X-Osstest-Versions-That:
    linux=d25f27432f80a800a3592db128254c8140bd71bf
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 28 Oct 2021 05:42:42 +0000

flight 165916 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165916/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 165885
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 165885
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165885
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 165885
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165885
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 165885
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 165885
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165885
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 linux                1fc596a56b334f4d593a2b49e5ff55af6aaa0816
baseline version:
 linux                d25f27432f80a800a3592db128254c8140bd71bf

Last test of basis   165885  2021-10-26 22:40:41 Z    1 days
Testing same since   165916  2021-10-27 18:10:33 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Aharon Landau <aharonl@nvidia.com>
  Alok Prasad <palok@marvell.com>
  Ariel Elior <aelior@marvell.com>
  Dan Carpenter <dan.carpenter@oracle.com>
  Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>
  Dinh Nguyen <dinguyen@kernel.org>
  Guenter Roeck <linux@roeck-us.net>
  Jason Gunthorpe <jgg@nvidia.com>
  Leon Romanovsky <leonro@nvidia.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Mark Zhang <markzhang@nvidia.com>
  Michal Kalderon <michal.kalderon@marvell.com>
  Mike Marciniszyn <mike.marciniszyn@cornelisnetworks.com>
  Mustafa Ismail <mustafa.ismail@intel.com>
  Patrisious Haddad <phaddad@nvidia.com>
  Prabhakar Kushwaha <pkushwaha@marvell.com>
  Shai Malin <smalin@marvell.com>
  Shiraz Saleem <shiraz.saleem@intel.com>
  Steven Rostedt (VMware) <rostedt@goodmis.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   d25f27432f80..1fc596a56b33  1fc596a56b334f4d593a2b49e5ff55af6aaa0816 -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Thu Oct 28 06:14:00 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Oct 2021 06:14:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217643.377751 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfyfc-0003RM-61; Thu, 28 Oct 2021 06:13:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217643.377751; Thu, 28 Oct 2021 06:13:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfyfc-0003RF-2u; Thu, 28 Oct 2021 06:13:48 +0000
Received: by outflank-mailman (input) for mailman id 217643;
 Thu, 28 Oct 2021 06:13:47 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=sO6D=PQ=gmail.com=andr2000@srs-us1.protection.inumbo.net>)
 id 1mfyfb-0003R9-7k
 for xen-devel@lists.xenproject.org; Thu, 28 Oct 2021 06:13:47 +0000
Received: from mail-wm1-x32c.google.com (unknown [2a00:1450:4864:20::32c])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id ab4564aa-0b11-4baf-b5b6-8503340c5668;
 Thu, 28 Oct 2021 06:13:45 +0000 (UTC)
Received: by mail-wm1-x32c.google.com with SMTP id v127so4657718wme.5
 for <xen-devel@lists.xenproject.org>; Wed, 27 Oct 2021 23:13:45 -0700 (PDT)
Received: from localhost.localdomain ([185.199.97.5])
 by smtp.gmail.com with ESMTPSA id b19sm5649656wmj.9.2021.10.27.23.13.43
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Wed, 27 Oct 2021 23:13:43 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ab4564aa-0b11-4baf-b5b6-8503340c5668
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:mime-version
         :content-transfer-encoding;
        bh=q3qnOo6SNi6rqddx/0yloZQA3I3JxT1zp2CKgKB09us=;
        b=TwFkBaSJCwHCEWFfzyxsaSXf3iO2XIjEXbpSRkKKMjscqrvSwvJeojBTOFVcrJuRGg
         CpsTsATuS6MO+XpmPb1QYG/TFUfdDCNIVZlHQW77//nQPho20ETXVA9kzX0U8gqexjsC
         EUSLx16pywRPCoRSQ88+AKtsxf2H5WNVFKR1BNuNRm8ktVB6uglFBSoCNFbsZRxslcqx
         YBWFk5OC0T7Q6O6HqQSC1LADIiiP4fqHeh+CQfJd7YVFLUME2GRucn6G+BqHuRl1kFVL
         0b415YswL7w7t7lPOqq0L3m5Jpj5MoPwqqYUxcM2hOkrP1ajRgH+Uy2LE4y/b90Rfw2e
         iBYg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version
         :content-transfer-encoding;
        bh=q3qnOo6SNi6rqddx/0yloZQA3I3JxT1zp2CKgKB09us=;
        b=pjhPkizK/9hT4EFNyzD4snygaRcCpnGA/+iEOnNYjXdLsU5Kzg8y5sxDGo6XXYjzi2
         T1Gji+fWMRsg1BgmTN5nPSZnsObW9+bW2T30nj2xr3zpQOeP07YZGDi3pMulg9OWuqy/
         KQwgpdMmepQiHYuLFcA2mgwOSa+UnzprOVvf04Wm3jWW3gkWsLtzkAtBxjJi566NjKHj
         oNXmHA3PweVLJYP75+i1+HdHszYPrgrI7OHYrfZXSbxOp7YtnrEWfhp87PUwMaMJeQlO
         86+oII1LR23wJUjsQ7XqXSOGy5OMdQOk83R+JSsOXCagAdoll1Vd6VUGYbZpSiBuuOlK
         NH7Q==
X-Gm-Message-State: AOAM5320r4Pdv7ehaMGXDgJ2PXx8xmfq7mfpHL6dWxi8/T/3e6BS8CT9
	VYHk8fEKPwIuVA3j5t6GuJTCFdOKA4Fq5w==
X-Google-Smtp-Source: ABdhPJz//HRSfzmYX4KISrdn+yhGgPuaOyN74hoip0nXElEu6yi9BSQby+eCwmf9oEZo0mHlayWHCw==
X-Received: by 2002:a05:600c:4f96:: with SMTP id n22mr2371815wmq.168.1635401624195;
        Wed, 27 Oct 2021 23:13:44 -0700 (PDT)
From: Oleksandr Andrushchenko <andr2000@gmail.com>
To: xen-devel@lists.xenproject.org,
	linux-kernel@vger.kernel.org
Cc: boris.ostrovsky@oracle.com,
	jgross@suse.com,
	julien@xen.org,
	sstabellini@kernel.org,
	jbeulich@suse.com,
	Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>,
	Anastasiia Lukianenko <anastasiia_lukianenko@epam.com>
Subject: [PATCH] xen-pciback: allow compiling on other archs than x86
Date: Thu, 28 Oct 2021 09:13:41 +0300
Message-Id: <20211028061341.1479333-1-andr2000@gmail.com>
X-Mailer: git-send-email 2.25.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>

Xen-pciback driver was designed to be built for x86 only. But it
can also be used by other architectures, e.g. Arm.

Currently PCI backend implements multiple functionalities at a time,
such as:
1. It is used as a database for assignable PCI devices, e.g. xl
   pci-assignable-{add|remove|list} manipulates that list. So, whenever
   the toolstack needs to know which PCI devices can be passed through
   it reads that from the relevant sysfs entries of the pciback.
2. It is used to hold the unbound PCI devices list, e.g. when passing
   through a PCI device it needs to be unbound from the relevant device
   driver and bound to pciback (strictly speaking it is not required
   that the device is bound to pciback, but pciback is again used as a
   database of the passed through PCI devices, so we can re-bind the
   devices back to their original drivers when guest domain shuts down)
3. Device reset for the devices being passed through
4. Para-virtualised use-cases support

The para-virtualised part of the driver is not always needed as some
architectures, e.g. Arm or x86 PVH Dom0, are not using backend-frontend
model for PCI device passthrough.

For such use-cases make the very first step in splitting the
xen-pciback driver into two parts: Xen PCI stub and PCI PV backend
drivers.

For that add new configuration options CONFIG_XEN_PCI_STUB and
CONFIG_XEN_PCIDEV_STUB, so the driver can be limited in its
functionality, e.g. no support for para-virtualised scenario.
x86 platform will continue using CONFIG_XEN_PCIDEV_BACKEND for the
fully featured backend driver.

Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Signed-off-by: Anastasiia Lukianenko <anastasiia_lukianenko@epam.com>
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
Reviewed-by: Juergen Gross <jgross@suse.com>
---
Changes since v5:
- rebased
Changes since v4:
- squashed two patches
- simplified Makefile
Changes since v3:
 - Fix >>32 shift for 32-bit architectures
Changes since v2:
 - swap the patch order
Since v1:
 - Do not move pci_xen_initial_domain as it is x86 specific
---
 arch/x86/include/asm/xen/pci.h              | 19 ------
 arch/x86/pci/xen.c                          | 76 +--------------------
 drivers/xen/Kconfig                         | 24 +++++++
 drivers/xen/Makefile                        |  2 +-
 drivers/xen/pci.c                           | 75 ++++++++++++++++++++
 drivers/xen/xen-pciback/Makefile            |  7 ++
 drivers/xen/xen-pciback/conf_space_header.c |  8 ++-
 drivers/xen/xen-pciback/pci_stub.c          |  3 +-
 drivers/xen/xen-pciback/pciback.h           |  5 ++
 drivers/xen/xen-pciback/xenbus.c            |  8 ++-
 include/xen/pci.h                           | 28 ++++++++
 11 files changed, 155 insertions(+), 100 deletions(-)
 create mode 100644 include/xen/pci.h

diff --git a/arch/x86/include/asm/xen/pci.h b/arch/x86/include/asm/xen/pci.h
index 4557f7cb0fa6..9015b888edd6 100644
--- a/arch/x86/include/asm/xen/pci.h
+++ b/arch/x86/include/asm/xen/pci.h
@@ -22,25 +22,6 @@ static inline int __init pci_xen_initial_domain(void)
 	return -1;
 }
 #endif
-#ifdef CONFIG_XEN_DOM0
-int xen_find_device_domain_owner(struct pci_dev *dev);
-int xen_register_device_domain_owner(struct pci_dev *dev, uint16_t domain);
-int xen_unregister_device_domain_owner(struct pci_dev *dev);
-#else
-static inline int xen_find_device_domain_owner(struct pci_dev *dev)
-{
-	return -1;
-}
-static inline int xen_register_device_domain_owner(struct pci_dev *dev,
-						   uint16_t domain)
-{
-	return -1;
-}
-static inline int xen_unregister_device_domain_owner(struct pci_dev *dev)
-{
-	return -1;
-}
-#endif
 
 #if defined(CONFIG_PCI_MSI)
 #if defined(CONFIG_PCI_XEN)
diff --git a/arch/x86/pci/xen.c b/arch/x86/pci/xen.c
index 5debe4ac6f81..12da00558631 100644
--- a/arch/x86/pci/xen.c
+++ b/arch/x86/pci/xen.c
@@ -23,6 +23,7 @@
 
 #include <xen/features.h>
 #include <xen/events.h>
+#include <xen/pci.h>
 #include <asm/xen/pci.h>
 #include <asm/xen/cpuid.h>
 #include <asm/apic.h>
@@ -585,78 +586,3 @@ int __init pci_xen_initial_domain(void)
 }
 #endif
 
-#ifdef CONFIG_XEN_DOM0
-
-struct xen_device_domain_owner {
-	domid_t domain;
-	struct pci_dev *dev;
-	struct list_head list;
-};
-
-static DEFINE_SPINLOCK(dev_domain_list_spinlock);
-static struct list_head dev_domain_list = LIST_HEAD_INIT(dev_domain_list);
-
-static struct xen_device_domain_owner *find_device(struct pci_dev *dev)
-{
-	struct xen_device_domain_owner *owner;
-
-	list_for_each_entry(owner, &dev_domain_list, list) {
-		if (owner->dev == dev)
-			return owner;
-	}
-	return NULL;
-}
-
-int xen_find_device_domain_owner(struct pci_dev *dev)
-{
-	struct xen_device_domain_owner *owner;
-	int domain = -ENODEV;
-
-	spin_lock(&dev_domain_list_spinlock);
-	owner = find_device(dev);
-	if (owner)
-		domain = owner->domain;
-	spin_unlock(&dev_domain_list_spinlock);
-	return domain;
-}
-EXPORT_SYMBOL_GPL(xen_find_device_domain_owner);
-
-int xen_register_device_domain_owner(struct pci_dev *dev, uint16_t domain)
-{
-	struct xen_device_domain_owner *owner;
-
-	owner = kzalloc(sizeof(struct xen_device_domain_owner), GFP_KERNEL);
-	if (!owner)
-		return -ENODEV;
-
-	spin_lock(&dev_domain_list_spinlock);
-	if (find_device(dev)) {
-		spin_unlock(&dev_domain_list_spinlock);
-		kfree(owner);
-		return -EEXIST;
-	}
-	owner->domain = domain;
-	owner->dev = dev;
-	list_add_tail(&owner->list, &dev_domain_list);
-	spin_unlock(&dev_domain_list_spinlock);
-	return 0;
-}
-EXPORT_SYMBOL_GPL(xen_register_device_domain_owner);
-
-int xen_unregister_device_domain_owner(struct pci_dev *dev)
-{
-	struct xen_device_domain_owner *owner;
-
-	spin_lock(&dev_domain_list_spinlock);
-	owner = find_device(dev);
-	if (!owner) {
-		spin_unlock(&dev_domain_list_spinlock);
-		return -ENODEV;
-	}
-	list_del(&owner->list);
-	spin_unlock(&dev_domain_list_spinlock);
-	kfree(owner);
-	return 0;
-}
-EXPORT_SYMBOL_GPL(xen_unregister_device_domain_owner);
-#endif /* CONFIG_XEN_DOM0 */
diff --git a/drivers/xen/Kconfig b/drivers/xen/Kconfig
index 1b2c3aca6887..a1b11c62da9e 100644
--- a/drivers/xen/Kconfig
+++ b/drivers/xen/Kconfig
@@ -181,10 +181,34 @@ config SWIOTLB_XEN
 	select DMA_OPS
 	select SWIOTLB
 
+config XEN_PCI_STUB
+	bool
+
+config XEN_PCIDEV_STUB
+	tristate "Xen PCI-device stub driver"
+	depends on PCI && !X86 && XEN
+	depends on XEN_BACKEND
+	select XEN_PCI_STUB
+	default m
+	help
+	  The PCI device stub driver provides limited version of the PCI
+	  device backend driver without para-virtualized support for guests.
+	  If you select this to be a module, you will need to make sure no
+	  other driver has bound to the device(s) you want to make visible to
+	  other guests.
+
+	  The "hide" parameter (only applicable if backend driver is compiled
+	  into the kernel) allows you to bind the PCI devices to this module
+	  from the default device drivers. The argument is the list of PCI BDFs:
+	  xen-pciback.hide=(03:00.0)(04:00.0)
+
+	  If in doubt, say m.
+
 config XEN_PCIDEV_BACKEND
 	tristate "Xen PCI-device backend driver"
 	depends on PCI && X86 && XEN
 	depends on XEN_BACKEND
+	select XEN_PCI_STUB
 	default m
 	help
 	  The PCI device backend driver allows the kernel to export arbitrary
diff --git a/drivers/xen/Makefile b/drivers/xen/Makefile
index 3434593455b2..5aae66e638a7 100644
--- a/drivers/xen/Makefile
+++ b/drivers/xen/Makefile
@@ -24,7 +24,7 @@ obj-$(CONFIG_XEN_SYS_HYPERVISOR)	+= sys-hypervisor.o
 obj-$(CONFIG_XEN_PVHVM_GUEST)		+= platform-pci.o
 obj-$(CONFIG_SWIOTLB_XEN)		+= swiotlb-xen.o
 obj-$(CONFIG_XEN_MCE_LOG)		+= mcelog.o
-obj-$(CONFIG_XEN_PCIDEV_BACKEND)	+= xen-pciback/
+obj-$(CONFIG_XEN_PCI_STUB)	        += xen-pciback/
 obj-$(CONFIG_XEN_PRIVCMD)		+= xen-privcmd.o
 obj-$(CONFIG_XEN_ACPI_PROCESSOR)	+= xen-acpi-processor.o
 obj-$(CONFIG_XEN_EFI)			+= efi.o
diff --git a/drivers/xen/pci.c b/drivers/xen/pci.c
index 224df03ce42e..fc8c1249d49f 100644
--- a/drivers/xen/pci.c
+++ b/drivers/xen/pci.c
@@ -254,3 +254,78 @@ static int xen_mcfg_late(void)
 	return 0;
 }
 #endif
+
+#ifdef CONFIG_XEN_DOM0
+struct xen_device_domain_owner {
+	domid_t domain;
+	struct pci_dev *dev;
+	struct list_head list;
+};
+
+static DEFINE_SPINLOCK(dev_domain_list_spinlock);
+static struct list_head dev_domain_list = LIST_HEAD_INIT(dev_domain_list);
+
+static struct xen_device_domain_owner *find_device(struct pci_dev *dev)
+{
+	struct xen_device_domain_owner *owner;
+
+	list_for_each_entry(owner, &dev_domain_list, list) {
+		if (owner->dev == dev)
+			return owner;
+	}
+	return NULL;
+}
+
+int xen_find_device_domain_owner(struct pci_dev *dev)
+{
+	struct xen_device_domain_owner *owner;
+	int domain = -ENODEV;
+
+	spin_lock(&dev_domain_list_spinlock);
+	owner = find_device(dev);
+	if (owner)
+		domain = owner->domain;
+	spin_unlock(&dev_domain_list_spinlock);
+	return domain;
+}
+EXPORT_SYMBOL_GPL(xen_find_device_domain_owner);
+
+int xen_register_device_domain_owner(struct pci_dev *dev, uint16_t domain)
+{
+	struct xen_device_domain_owner *owner;
+
+	owner = kzalloc(sizeof(struct xen_device_domain_owner), GFP_KERNEL);
+	if (!owner)
+		return -ENODEV;
+
+	spin_lock(&dev_domain_list_spinlock);
+	if (find_device(dev)) {
+		spin_unlock(&dev_domain_list_spinlock);
+		kfree(owner);
+		return -EEXIST;
+	}
+	owner->domain = domain;
+	owner->dev = dev;
+	list_add_tail(&owner->list, &dev_domain_list);
+	spin_unlock(&dev_domain_list_spinlock);
+	return 0;
+}
+EXPORT_SYMBOL_GPL(xen_register_device_domain_owner);
+
+int xen_unregister_device_domain_owner(struct pci_dev *dev)
+{
+	struct xen_device_domain_owner *owner;
+
+	spin_lock(&dev_domain_list_spinlock);
+	owner = find_device(dev);
+	if (!owner) {
+		spin_unlock(&dev_domain_list_spinlock);
+		return -ENODEV;
+	}
+	list_del(&owner->list);
+	spin_unlock(&dev_domain_list_spinlock);
+	kfree(owner);
+	return 0;
+}
+EXPORT_SYMBOL_GPL(xen_unregister_device_domain_owner);
+#endif
diff --git a/drivers/xen/xen-pciback/Makefile b/drivers/xen/xen-pciback/Makefile
index e8d981d43235..d63df09de81c 100644
--- a/drivers/xen/xen-pciback/Makefile
+++ b/drivers/xen/xen-pciback/Makefile
@@ -1,5 +1,12 @@
 # SPDX-License-Identifier: GPL-2.0
+
+# N.B. The below cannot be expressed with a single line using
+# CONFIG_XEN_PCI_STUB as it always remains in "y" state,
+# thus preventing the driver to be built as a module.
+# Please note, that CONFIG_XEN_PCIDEV_BACKEND and
+# CONFIG_XEN_PCIDEV_STUB are mutually exclusive.
 obj-$(CONFIG_XEN_PCIDEV_BACKEND) += xen-pciback.o
+obj-$(CONFIG_XEN_PCIDEV_STUB) += xen-pciback.o
 
 xen-pciback-y := pci_stub.o pciback_ops.o xenbus.o
 xen-pciback-y += conf_space.o conf_space_header.o \
diff --git a/drivers/xen/xen-pciback/conf_space_header.c b/drivers/xen/xen-pciback/conf_space_header.c
index ac45cdc38e85..981435103af1 100644
--- a/drivers/xen/xen-pciback/conf_space_header.c
+++ b/drivers/xen/xen-pciback/conf_space_header.c
@@ -236,8 +236,12 @@ static void *bar_init(struct pci_dev *dev, int offset)
 	else {
 		pos = (offset - PCI_BASE_ADDRESS_0) / 4;
 		if (pos && (res[pos - 1].flags & IORESOURCE_MEM_64)) {
-			bar->val = res[pos - 1].start >> 32;
-			bar->len_val = -resource_size(&res[pos - 1]) >> 32;
+			/*
+			 * Use ">> 16 >> 16" instead of direct ">> 32" shift
+			 * to avoid warnings on 32-bit architectures.
+			 */
+			bar->val = res[pos - 1].start >> 16 >> 16;
+			bar->len_val = -resource_size(&res[pos - 1]) >> 16 >> 16;
 			return bar;
 		}
 	}
diff --git a/drivers/xen/xen-pciback/pci_stub.c b/drivers/xen/xen-pciback/pci_stub.c
index f8e4faa96ad6..bba527620507 100644
--- a/drivers/xen/xen-pciback/pci_stub.c
+++ b/drivers/xen/xen-pciback/pci_stub.c
@@ -19,7 +19,8 @@
 #include <linux/sched.h>
 #include <linux/atomic.h>
 #include <xen/events.h>
-#include <asm/xen/pci.h>
+#include <xen/pci.h>
+#include <xen/xen.h>
 #include <asm/xen/hypervisor.h>
 #include <xen/interface/physdev.h>
 #include "pciback.h"
diff --git a/drivers/xen/xen-pciback/pciback.h b/drivers/xen/xen-pciback/pciback.h
index 95e28ee48d52..9a64196e831d 100644
--- a/drivers/xen/xen-pciback/pciback.h
+++ b/drivers/xen/xen-pciback/pciback.h
@@ -71,6 +71,11 @@ struct pci_dev *pcistub_get_pci_dev(struct xen_pcibk_device *pdev,
 				    struct pci_dev *dev);
 void pcistub_put_pci_dev(struct pci_dev *dev);
 
+static inline bool xen_pcibk_pv_support(void)
+{
+	return IS_ENABLED(CONFIG_XEN_PCIDEV_BACKEND);
+}
+
 /* Ensure a device is turned off or reset */
 void xen_pcibk_reset_device(struct pci_dev *pdev);
 
diff --git a/drivers/xen/xen-pciback/xenbus.c b/drivers/xen/xen-pciback/xenbus.c
index c09c7ebd6968..bde63ef677b8 100644
--- a/drivers/xen/xen-pciback/xenbus.c
+++ b/drivers/xen/xen-pciback/xenbus.c
@@ -14,7 +14,7 @@
 #include <linux/workqueue.h>
 #include <xen/xenbus.h>
 #include <xen/events.h>
-#include <asm/xen/pci.h>
+#include <xen/pci.h>
 #include "pciback.h"
 
 #define INVALID_EVTCHN_IRQ  (-1)
@@ -743,6 +743,9 @@ const struct xen_pcibk_backend *__read_mostly xen_pcibk_backend;
 
 int __init xen_pcibk_xenbus_register(void)
 {
+	if (!xen_pcibk_pv_support())
+		return 0;
+
 	xen_pcibk_backend = &xen_pcibk_vpci_backend;
 	if (passthrough)
 		xen_pcibk_backend = &xen_pcibk_passthrough_backend;
@@ -752,5 +755,6 @@ int __init xen_pcibk_xenbus_register(void)
 
 void __exit xen_pcibk_xenbus_unregister(void)
 {
-	xenbus_unregister_driver(&xen_pcibk_driver);
+	if (xen_pcibk_pv_support())
+		xenbus_unregister_driver(&xen_pcibk_driver);
 }
diff --git a/include/xen/pci.h b/include/xen/pci.h
new file mode 100644
index 000000000000..b8337cf85fd1
--- /dev/null
+++ b/include/xen/pci.h
@@ -0,0 +1,28 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+
+#ifndef __XEN_PCI_H__
+#define __XEN_PCI_H__
+
+#if defined(CONFIG_XEN_DOM0)
+int xen_find_device_domain_owner(struct pci_dev *dev);
+int xen_register_device_domain_owner(struct pci_dev *dev, uint16_t domain);
+int xen_unregister_device_domain_owner(struct pci_dev *dev);
+#else
+static inline int xen_find_device_domain_owner(struct pci_dev *dev)
+{
+	return -1;
+}
+
+static inline int xen_register_device_domain_owner(struct pci_dev *dev,
+						   uint16_t domain)
+{
+	return -1;
+}
+
+static inline int xen_unregister_device_domain_owner(struct pci_dev *dev)
+{
+	return -1;
+}
+#endif
+
+#endif
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Thu Oct 28 06:16:52 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Oct 2021 06:16:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217652.377761 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfyiU-000499-Ns; Thu, 28 Oct 2021 06:16:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217652.377761; Thu, 28 Oct 2021 06:16:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfyiU-000492-Kz; Thu, 28 Oct 2021 06:16:46 +0000
Received: by outflank-mailman (input) for mailman id 217652;
 Thu, 28 Oct 2021 06:16:45 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=N7Vm=PQ=canb.auug.org.au=sfr@srs-us1.protection.inumbo.net>)
 id 1mfyiS-00048u-6S
 for xen-devel@lists.xenproject.org; Thu, 28 Oct 2021 06:16:45 +0000
Received: from gandalf.ozlabs.org (unknown [150.107.74.76])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id c18ac763-5c92-43e6-90d4-0612c6b33863;
 Thu, 28 Oct 2021 06:16:40 +0000 (UTC)
Received: from authenticated.ozlabs.org (localhost [127.0.0.1])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest
 SHA256) (No client certificate requested)
 by mail.ozlabs.org (Postfix) with ESMTPSA id 4HfwLV6NF6z4xcB;
 Thu, 28 Oct 2021 17:16:34 +1100 (AEDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c18ac763-5c92-43e6-90d4-0612c6b33863
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canb.auug.org.au;
	s=201702; t=1635401796;
	bh=RZCVeOXwcdZa/nUqU9rKDWY5H15gYWvRWpcvq5i8Ge0=;
	h=Date:From:To:Cc:Subject:From;
	b=KxxaLlCJKUB3tk2ICp52vJiupSdOjd0U/C1dxifNIKXuuczTJpshFtBKr4OTAMVbL
	 2WWLRt0t0dZu+5jgCscb4xEiiZ+Gt+QLSIG7VlRp0zlDxCzhSjNlCzHHkN8KjspCC4
	 +XBmqBPucM69dELcL+TqMLawq6UW3ZCgeTDJeqAbpdG4eVkWqMCVF3z6s8rKFq+rWU
	 WJOFX/qBCn7j0dFLGOQPk0K6Z733SPL39JLULFUdRoYCXaxASve41nXeYyr9KCL/mh
	 Awd/Vs7rvOPUg0ivwkc4vrd4Mod5oXDgPG8B22ItA4AIoU/w6IMVVV2urFbznDE8Sr
	 xMSb5bvMvjFDw==
Date: Thu, 28 Oct 2021 17:16:33 +1100
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Juergen Gross <jgross@suse.com>, Konrad Rzeszutek Wilk
 <konrad.wilk@oracle.com>, Stefano Stabellini <sstabellini@kernel.org>,
 Boris Ostrovsky <boris.ostrovsky@oracle.com>, Xen Devel
 <xen-devel@lists.xenproject.org>, Thomas Gleixner <tglx@linutronix.de>,
 Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>, Peter
 Zijlstra <peterz@infradead.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Linux Next
 Mailing List <linux-next@vger.kernel.org>
Subject: linux-next: manual merge of the xen-tip tree with the tip tree
Message-ID: <20211028171633.603441ef@canb.auug.org.au>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="Sig_/gjdfCg28mrFUIRBmrXBDBmL";
 protocol="application/pgp-signature"; micalg=pgp-sha256

--Sig_/gjdfCg28mrFUIRBmrXBDBmL
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable

Hi all,

Today's linux-next merge of the xen-tip tree got a conflict in:

  arch/x86/xen/irq.c

between commits:

  20125c872a3f ("x86/xen: Make save_fl() noinstr")
  d7bfc7d57cbe ("x86/xen: Make irq_enable() noinstr")
  09c413071e2d ("x86/xen: Make irq_disable() noinstr")
  1462eb381b4c ("x86/xen: Rework the xen_{cpu,irq,mmu}_opsarrays")

from the tip tree and commit:

  97c79d816979 ("x86/xen: switch initial pvops IRQ functions to dummy ones")

from the xen-tip tree.

I fixed it up (see below) and can carry the fix as necessary. This
is now fixed as far as linux-next is concerned, but any non trivial
conflicts should be mentioned to your upstream maintainer when your tree
is submitted for merging.  You may also want to consider cooperating
with the maintainer of the conflicting tree to minimise any particularly
complex conflicts.

There may be more required, though.
--=20
Cheers,
Stephen Rothwell

diff --cc arch/x86/xen/irq.c
index 4fe387e520af,ae8537583102..000000000000
--- a/arch/x86/xen/irq.c
+++ b/arch/x86/xen/irq.c
@@@ -94,16 -40,14 +40,16 @@@ static void xen_halt(void
  		xen_safe_halt();
  }
 =20
 -static const struct pv_irq_ops xen_irq_ops __initconst =3D {
 -	/* Initial interrupt flag handling only called while interrupts off. */
 -	.save_fl =3D __PV_IS_CALLEE_SAVE(paravirt_ret0),
 -	.irq_disable =3D __PV_IS_CALLEE_SAVE(paravirt_nop),
 -	.irq_enable =3D __PV_IS_CALLEE_SAVE(paravirt_BUG),
 +static const typeof(pv_ops) xen_irq_ops __initconst =3D {
 +	.irq =3D {
-=20
- 		.save_fl =3D PV_CALLEE_SAVE(xen_save_fl),
- 		.irq_disable =3D PV_CALLEE_SAVE(xen_irq_disable),
- 		.irq_enable =3D PV_CALLEE_SAVE(xen_irq_enable),
++		/* Initial interrupt flag handling only called while interrupts off. */
++		.save_fl =3D __PV_IS_CALLEE_SAVE(paravirt_ret0),
++		.irq_disable =3D __PV_IS_CALLEE_SAVE(paravirt_nop),
++		.irq_enable =3D __PV_IS_CALLEE_SAVE(paravirt_BUG),
 =20
 -	.safe_halt =3D xen_safe_halt,
 -	.halt =3D xen_halt,
 +		.safe_halt =3D xen_safe_halt,
 +		.halt =3D xen_halt,
 +	},
  };
 =20
  void __init xen_init_irq_ops(void)

--Sig_/gjdfCg28mrFUIRBmrXBDBmL
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEENIC96giZ81tWdLgKAVBC80lX0GwFAmF6QEEACgkQAVBC80lX
0Gxqagf/Td093dl4efT9lndu1gmog0FXF5HLVk8gif87xRq/cT3j5DPqKW8hK5fi
UQ+M974Op+nIw/Eoplf/l1Yn4nND+YJ5krN/5UUbHSBzQs3FL0jJ2dw3B+MOgTwd
SdJn5rW+MXt7HLhcPxkrA+bDZ2Z/CTjUrIpwtmEGzeYUQKjBbMgBMIxnulAd5EqA
3T5aXCG2xjb09NgKN6VJhXSNh7nM5q+9Zdx6v7anYWdahZ9Y4hG720qbf0Wgtu0P
o7nR0InCFnIA3UkG4fFlxGZAvjzlRIb/HPTE4wC2HmcO/PVU+grqT/Mt6eSI+r1g
ciDl8OICcWy0nJTmU+/ZpiNH/UqtRQ==
=T10R
-----END PGP SIGNATURE-----

--Sig_/gjdfCg28mrFUIRBmrXBDBmL--


From xen-devel-bounces@lists.xenproject.org Thu Oct 28 06:33:45 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Oct 2021 06:33:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217659.377773 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfyyd-0006To-6h; Thu, 28 Oct 2021 06:33:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217659.377773; Thu, 28 Oct 2021 06:33:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfyyd-0006Th-3R; Thu, 28 Oct 2021 06:33:27 +0000
Received: by outflank-mailman (input) for mailman id 217659;
 Thu, 28 Oct 2021 06:33:25 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=N7Vm=PQ=canb.auug.org.au=sfr@srs-us1.protection.inumbo.net>)
 id 1mfyyZ-0006Tb-HL
 for xen-devel@lists.xenproject.org; Thu, 28 Oct 2021 06:33:25 +0000
Received: from gandalf.ozlabs.org (unknown [2404:9400:2:0:216:3eff:fee2:21ea])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 8f0293af-01bf-4ea0-8ac7-358bbb1fc79d;
 Thu, 28 Oct 2021 06:33:20 +0000 (UTC)
Received: from authenticated.ozlabs.org (localhost [127.0.0.1])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest
 SHA256) (No client certificate requested)
 by mail.ozlabs.org (Postfix) with ESMTPSA id 4Hfwjn0W6hz4xcC;
 Thu, 28 Oct 2021 17:33:16 +1100 (AEDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8f0293af-01bf-4ea0-8ac7-358bbb1fc79d
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canb.auug.org.au;
	s=201702; t=1635402797;
	bh=/R7loCnMrMbPjsUshOHJxqGM+7aLjRr8ecYMPWeUsTU=;
	h=Date:From:To:Cc:Subject:From;
	b=g64YH78CMh3JlAlFRYGBkNNGd4y5pNAcgx5ZxVoMv9669gK8hhRZMeZ0HaS+keMbD
	 I7eue/L5R22Q5T/JgBZ9sPSEv7GQyYu1PoIm0XF3UFC/uppsItGb6+XKMOnl0y+TEp
	 lJk0yAUVtpLTv1wHn8KrXXU3a8cDmWIvac5TwoEIYYy+ArxmcOACaewgiKs7JFEzWm
	 P2UOmmmmq1f8ohxWoDrCKaRICLqCjqSHuhc104TqrB1Pow2a/oCC22QjLkLkXs/6gy
	 P0RtS8q+siRTjlxaIBjNuSqKwP3F/kb6j0h+VRUe+QMFsVEqNXZYTteqt7AFDRKf7F
	 xKet4Q0PvuHmg==
Date: Thu, 28 Oct 2021 17:33:15 +1100
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Juergen Gross <jgross@suse.com>, Konrad Rzeszutek Wilk
 <konrad.wilk@oracle.com>, Stefano Stabellini <sstabellini@kernel.org>,
 Boris Ostrovsky <boris.ostrovsky@oracle.com>, Xen Devel
 <xen-devel@lists.xenproject.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Linux Next
 Mailing List <linux-next@vger.kernel.org>
Subject: linux-next: build warnings after merge of the xen-tip tree
Message-ID: <20211028173315.55b1a121@canb.auug.org.au>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="Sig_/r0i/0s/oy4PgZOhjNEZmIby";
 protocol="application/pgp-signature"; micalg=pgp-sha256

--Sig_/r0i/0s/oy4PgZOhjNEZmIby
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable

Hi all,

After merging the xen-tip tree, today's linux-next build (x86_64
allmodconfig) produced these warnings:

vmlinux.o: warning: objtool: pv_ops[32]: paravirt_BUG
vmlinux.o: warning: objtool: lock_is_held_type()+0x145: call to pv_ops[32](=
) leaves .noinstr.text section

Presuambly introduced by commit

  97c79d816979 ("x86/xen: switch initial pvops IRQ functions to dummy ones")

--=20
Cheers,
Stephen Rothwell

--Sig_/r0i/0s/oy4PgZOhjNEZmIby
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEENIC96giZ81tWdLgKAVBC80lX0GwFAmF6RCsACgkQAVBC80lX
0Gysogf8DPnYiV4jaScnM+66C/vwmmlpos27JM+22fOKgj/3J1syzTHopLIS2jZ8
v358bhJ1jj8EnGJI/m2ebkZwATeNbGhsTj/Grs2AWaz4XzjVNX7fX6PX6fg4p4wM
aLCRmuedIMDcNkzSNtsO9AZQsQLtpdsmxRthvfwdLkA/L6895mszPTP+hA4AZNzD
SuoLYGP622hkjcASTSGxhaohbo1hJtsfwAkQQzviQ/QhfWdVKmx7gOuLA7AG9mJU
UPVVXAFwoYX58z2q3AqoN2xsAFknKRAafS2L8zKk99JKhrK7azlwoqXZj9unkErI
rivpI4IsQO6yjZs3k9OZ0aIZSI/PkQ==
=yI5b
-----END PGP SIGNATURE-----

--Sig_/r0i/0s/oy4PgZOhjNEZmIby--


From xen-devel-bounces@lists.xenproject.org Thu Oct 28 06:39:55 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Oct 2021 06:39:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217666.377783 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfz4l-0007Ca-SE; Thu, 28 Oct 2021 06:39:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217666.377783; Thu, 28 Oct 2021 06:39:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfz4l-0007CT-PC; Thu, 28 Oct 2021 06:39:47 +0000
Received: by outflank-mailman (input) for mailman id 217666;
 Thu, 28 Oct 2021 06:39:46 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=fllP=PQ=gmx.de=deller@srs-us1.protection.inumbo.net>)
 id 1mfz4k-0007Ba-RG
 for xen-devel@lists.xenproject.org; Thu, 28 Oct 2021 06:39:46 +0000
Received: from mout.gmx.net (unknown [212.227.15.15])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id d6807702-37b9-11ec-8497-12813bfff9fa;
 Thu, 28 Oct 2021 06:39:45 +0000 (UTC)
Received: from [192.168.20.60] ([92.116.152.46]) by mail.gmx.net (mrgmx005
 [212.227.17.190]) with ESMTPSA (Nemesis) id 1M3UZ6-1mfR6019Wc-000dpr; Thu, 28
 Oct 2021 08:38:50 +0200
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d6807702-37b9-11ec-8497-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net;
	s=badeba3b8450; t=1635403130;
	bh=9epiwmWdzTgZY2j4GBWRs9N0QEWknADgKRkQPvp+Ggo=;
	h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From:In-Reply-To;
	b=FXhe5yXxylYP540/EC+4AzkmLOP3fNSEmO39fyo/3NOlbWcEm0ryYTd7J3Iv20szB
	 cWKWEC4dZ521NZJ4gyIpkKod8spMS5RmsFlBvqxTT96Vwc/S6HyYHyyyo0FoSjpetw
	 nwPjJnU+hcraQ+NzVcLrxZf8To+aYZc5aH/99quU=
X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c
Message-ID: <6470d500-a832-9e1f-e3b9-4d3972b3996e@gmx.de>
Date: Thu, 28 Oct 2021 08:38:35 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.2.0
Subject: Re: [PATCH v2 16/45] parisc: Use do_kernel_power_off()
Content-Language: en-US
To: Dmitry Osipenko <digetx@gmail.com>,
 Thierry Reding <thierry.reding@gmail.com>,
 Jonathan Hunter <jonathanh@nvidia.com>, Lee Jones <lee.jones@linaro.org>,
 "Rafael J . Wysocki" <rafael@kernel.org>, Mark Brown <broonie@kernel.org>,
 Andrew Morton <akpm@linux-foundation.org>, Guenter Roeck
 <linux@roeck-us.net>, Russell King <linux@armlinux.org.uk>,
 Daniel Lezcano <daniel.lezcano@linaro.org>,
 Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
 Ulf Hansson <ulf.hansson@linaro.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will@kernel.org>,
 Guo Ren <guoren@kernel.org>, Geert Uytterhoeven <geert@linux-m68k.org>,
 Greg Ungerer <gerg@linux-m68k.org>, Joshua Thompson <funaho@jurai.org>,
 Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
 Nick Hu <nickhu@andestech.com>, Greentime Hu <green.hu@gmail.com>,
 Vincent Chen <deanbo422@gmail.com>,
 "James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
 Michael Ellerman <mpe@ellerman.id.au>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 Paul Mackerras <paulus@samba.org>, Paul Walmsley <paul.walmsley@sifive.com>,
 Palmer Dabbelt <palmer@dabbelt.com>, Albert Ou <aou@eecs.berkeley.edu>,
 Yoshinori Sato <ysato@users.sourceforge.jp>, Rich Felker <dalias@libc.org>,
 Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
 Borislav Petkov <bp@alien8.de>, Dave Hansen <dave.hansen@linux.intel.com>,
 x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
 Boris Ostrovsky <boris.ostrovsky@oracle.com>, Juergen Gross
 <jgross@suse.com>, Stefano Stabellini <sstabellini@kernel.org>,
 Len Brown <lenb@kernel.org>, Santosh Shilimkar <ssantosh@kernel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
 Linus Walleij <linus.walleij@linaro.org>, Chen-Yu Tsai <wens@csie.org>,
 =?UTF-8?Q?Jonathan_Neusch=c3=a4fer?= <j.neuschaefer@gmx.net>,
 Tony Lindgren <tony@atomide.com>, Liam Girdwood <lgirdwood@gmail.com>,
 Philipp Zabel <p.zabel@pengutronix.de>, Vladimir Zapolskiy <vz@mleia.com>,
 Avi Fishman <avifishman70@gmail.com>, Tomer Maimon <tmaimon77@gmail.com>,
 Tali Perry <tali.perry1@gmail.com>, Patrick Venture <venture@google.com>,
 Nancy Yuen <yuenn@google.com>, Benjamin Fair <benjaminfair@google.com>,
 Pavel Machek <pavel@ucw.cz>, linux-arm-kernel@lists.infradead.org,
 linux-kernel@vger.kernel.org, linux-csky@vger.kernel.org,
 linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org,
 linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org,
 linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org,
 linux-sh@vger.kernel.org, xen-devel@lists.xenproject.org,
 linux-acpi@vger.kernel.org, linux-omap@vger.kernel.org,
 openbmc@lists.ozlabs.org, linux-tegra@vger.kernel.org,
 linux-pm@vger.kernel.org
References: <20211027211715.12671-1-digetx@gmail.com>
 <20211027211715.12671-17-digetx@gmail.com>
From: Helge Deller <deller@gmx.de>
In-Reply-To: <20211027211715.12671-17-digetx@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-Provags-ID: V03:K1:FyRzIrUgBb05q0bHWFRS/zQ/jjhGXy+pktz0g9vMu8rSAyG2PhH
 igLh0yuSJkfQClwGAYYVp96vDjlam7EqP3CW0lWkZ155s/JTRG7aXysFtzh8fsHm3d7JOnd
 U2wPiCoWHArr/c1zeopIGDkaYwvec8wHmOgMEvIr7aPgxK9GcFiXcIhkSKruN1bnrxyn2QX
 umWMtuIv0Xa3Bg/ofbf6Q==
X-Spam-Flag: NO
X-UI-Out-Filterresults: notjunk:1;V03:K0:Nt03nam4XH8=:N7PuLhTcs13ezPdb4QL3P5
 EAsOC32SEC/CwoA2+8DjNnTsILfn+sFrb9LZytvE/YP2J2Aj7Qx7fkEO40fY8T8rIBLGw9GX+
 NIsaN0+sjNJKdkOQlJE/AFyfJG+vQ7ahzCRk2HMLrf3z5M6K/b0L71tddrkVIJCMb7IuCUzph
 ykgDP6aZxfqVXIMaikKg097ePHHG0x47b/94G1+2NvXBe71nBfFTfm04TrvRNne2czLnMB+Lg
 v+wFHtJZ2jQ9cLfCu2fzZQuGkclVf14XlYnoDKMRVnVFWWYf0adoOjwfKSRtptB20/q31drw2
 HePgYF8sylMcfQbim3Wp4ygBdzf5/6i3x4H4dnB1q/EhvkJY/KiaZgrjHxrJkHNauXcVxsg6y
 3vvk7psmlYjcJLo6ddOdIBc9OIQs133Ce1iU2wSod2qhYwBPSJppgIk8kJCYKzZxAzsnModUK
 BgEImgsOUGiDlYZe9Muppxy4TrQaqVmfjaM9kmqq8Gvz9GaOjVqBYmFsm570hW8BuF9BI+r+S
 0GJuN3cdiVBY0G0MhcxnoHe4O22baIwcBDk2FnckJriXO5mZE3hJQVTcEKeAb2ybK5KNuVVY6
 nww/BdElXnSWt1HhtpoHRHlgigO4KvVdiDhtBi8tFoyeYg8pvvK9qgrlLqCEJsbs8TBaWRdRr
 7fvMB1yoKM8dWEL+Z/gHindYZd433ys7huBzX1XyE7cCnO+L/FE5ZfETDY8DSBwlBCCD940Ri
 wkqaYntrDtmIkWD9BWTD4j7K3fgZUU7IPEaJZjdl5xWo8e268I+GMSTVMrUSVDmQzI7cEG+Lb
 i0qZzTuZiztLiwLZgXQVnYgopvNIgyfo6LMbZ9e4NuBR0ff+vu+fsAwWJH4T3BJlzoZYXX193
 PLDnh+2eGZNNZJ83DOYN1ApcqeJpwMwKyPuCFuf/SxuBIQ7A6oWrcCikiPFJaPxKlXhX5RTg8
 v7QQ4c9ImeWqMCb0i29R5vmks8Ui9IG2X5j/SIZwSpXutCAWE2F/LMHO+pOK/jVtTRVpgu0WW
 MapTUMEB41Z0LdVwL6aYL1P3sWB52Pfffr4C3r7aA/3cWiJWf1QCoiwOmHCTExfYhCTFuQCe5
 +ZRYgxUKbSq514=

On 10/27/21 23:16, Dmitry Osipenko wrote:
> Kernel now supports chained power-off handlers. Use do_kernel_power_off(=
)
> that invokes chained power-off handlers. It also invokes legacy
> pm_power_off() for now, which will be removed once all drivers will
> be converted to the new power-off API.
>
> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>

Acked-by: Helge Deller <deller@gmx.de> # parisc



> ---
>  arch/parisc/kernel/process.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/parisc/kernel/process.c b/arch/parisc/kernel/process.c
> index ea3d83b6fb62..928201b1f58f 100644
> --- a/arch/parisc/kernel/process.c
> +++ b/arch/parisc/kernel/process.c
> @@ -26,6 +26,7 @@
>  #include <linux/module.h>
>  #include <linux/personality.h>
>  #include <linux/ptrace.h>
> +#include <linux/reboot.h>
>  #include <linux/sched.h>
>  #include <linux/sched/debug.h>
>  #include <linux/sched/task.h>
> @@ -114,8 +115,7 @@ void machine_power_off(void)
>  	pdc_chassis_send_status(PDC_CHASSIS_DIRECT_SHUTDOWN);
>
>  	/* ipmi_poweroff may have been installed. */
> -	if (pm_power_off)
> -		pm_power_off();
> +	do_kernel_power_off();
>
>  	/* It seems we have no way to power the system off via
>  	 * software. The user has to press the button himself. */
>



From xen-devel-bounces@lists.xenproject.org Thu Oct 28 07:00:47 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Oct 2021 07:00:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217673.377795 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfzOb-0001ub-JN; Thu, 28 Oct 2021 07:00:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217673.377795; Thu, 28 Oct 2021 07:00:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfzOb-0001uU-FZ; Thu, 28 Oct 2021 07:00:17 +0000
Received: by outflank-mailman (input) for mailman id 217673;
 Thu, 28 Oct 2021 07:00:15 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=vfrR=PQ=suse.com=jgross@srs-us1.protection.inumbo.net>)
 id 1mfzOZ-0001u5-Nu
 for xen-devel@lists.xenproject.org; Thu, 28 Oct 2021 07:00:15 +0000
Received: from smtp-out2.suse.de (unknown [195.135.220.29])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id a59fe0c8-4ab9-4b3c-9d3b-f8eaf4778075;
 Thu, 28 Oct 2021 07:00:14 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 3F31E1FD4B;
 Thu, 28 Oct 2021 07:00:13 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 0C0AA13EC9;
 Thu, 28 Oct 2021 07:00:13 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id 6mfJAX1KemHjDwAAMHmgww
 (envelope-from <jgross@suse.com>); Thu, 28 Oct 2021 07:00:13 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a59fe0c8-4ab9-4b3c-9d3b-f8eaf4778075
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1635404413; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=/hR5TGXRQVQkw6zIe3acsy/m0ARZTYmLwVeDdkmr0o8=;
	b=lZtQH9UdJczVGiwq03JhFSRRql36X1yvCa5IvgG6miCjSi8bU5ryad7X4Z4fSeZUNPoIWw
	RrmpLUCAWZ+6rok5+bY1b3ZBh6wNVPpC8kXsbM7YaitryweAu1v2w2t4Kj1ICE6oEe4SYd
	CaML0Yhd63mU4lwbKznP8PZiFoQUy5c=
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 xen-devel@lists.xenproject.org, iwj@xenproject.org, cardoe@cardoe.com,
 wl@xen.org, anthony.perard@citrix.com,
 Stefano Stabellini <stefano.stabellini@xilinx.com>
References: <alpine.DEB.2.21.2110210831470.2311@sstabellini-ThinkPad-T480s>
 <20211021230839.10794-2-sstabellini@kernel.org>
 <19aa9196-eb5f-22a1-206c-c9c87ee79fa9@citrix.com>
 <alpine.DEB.2.21.2110221219300.2311@sstabellini-ThinkPad-T480s>
 <d559b765-9e38-00bd-039b-9c33845b8e54@suse.com>
 <alpine.DEB.2.21.2110251753200.4586@sstabellini-ThinkPad-T480s>
 <8c0a2a97-04ab-4836-fc35-026dd7c122a4@suse.com>
 <alpine.DEB.2.21.2110271543150.20134@sstabellini-ThinkPad-T480s>
 <alpine.DEB.2.21.2110271619240.20134@sstabellini-ThinkPad-T480s>
From: Juergen Gross <jgross@suse.com>
Subject: Re: [PATCH 2/3] automation: Linux 5.10.74 test-artifact
Message-ID: <4f82901a-2e74-f4ee-311e-b8187d856745@suse.com>
Date: Thu, 28 Oct 2021 09:00:12 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.21.2110271619240.20134@sstabellini-ThinkPad-T480s>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="8tTS3EAeEY8aqWI31agR6YRyIzlHM6igP"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--8tTS3EAeEY8aqWI31agR6YRyIzlHM6igP
Content-Type: multipart/mixed; boundary="4xVbZeMI34GdqL0pKQ94tjWax7zfzoINd";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 xen-devel@lists.xenproject.org, iwj@xenproject.org, cardoe@cardoe.com,
 wl@xen.org, anthony.perard@citrix.com,
 Stefano Stabellini <stefano.stabellini@xilinx.com>
Message-ID: <4f82901a-2e74-f4ee-311e-b8187d856745@suse.com>
Subject: Re: [PATCH 2/3] automation: Linux 5.10.74 test-artifact
References: <alpine.DEB.2.21.2110210831470.2311@sstabellini-ThinkPad-T480s>
 <20211021230839.10794-2-sstabellini@kernel.org>
 <19aa9196-eb5f-22a1-206c-c9c87ee79fa9@citrix.com>
 <alpine.DEB.2.21.2110221219300.2311@sstabellini-ThinkPad-T480s>
 <d559b765-9e38-00bd-039b-9c33845b8e54@suse.com>
 <alpine.DEB.2.21.2110251753200.4586@sstabellini-ThinkPad-T480s>
 <8c0a2a97-04ab-4836-fc35-026dd7c122a4@suse.com>
 <alpine.DEB.2.21.2110271543150.20134@sstabellini-ThinkPad-T480s>
 <alpine.DEB.2.21.2110271619240.20134@sstabellini-ThinkPad-T480s>
In-Reply-To: <alpine.DEB.2.21.2110271619240.20134@sstabellini-ThinkPad-T480s>

--4xVbZeMI34GdqL0pKQ94tjWax7zfzoINd
Content-Type: multipart/mixed;
 boundary="------------FB101BD822545065E5676DF2"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------FB101BD822545065E5676DF2
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 28.10.21 01:24, Stefano Stabellini wrote:
> On Wed, 27 Oct 2021, Stefano Stabellini wrote:
>> On Wed, 27 Oct 2021, Juergen Gross wrote:
>>> On 26.10.21 02:54, Stefano Stabellini wrote:
>>>> On Mon, 25 Oct 2021, Juergen Gross wrote:
>>>>> On 22.10.21 21:41, Stefano Stabellini wrote:
>>>>>> +Juergen
>>>>>>
>>>>>> On Fri, 22 Oct 2021, Andrew Cooper wrote:
>>>>>>> On 22/10/2021 00:08, Stefano Stabellini wrote:
>>>>>>>> +# build depends
>>>>>>>> +RUN apt-get update && \
>>>>>>>> +    apt-get --quiet --yes install \
>>>>>>>> +        build-essential \
>>>>>>>> +        libssl-dev \
>>>>>>>> +        bc \
>>>>>>>> +        curl \
>>>>>>>> +        flex \
>>>>>>>> +        bison \
>>>>>>>> +        libelf-dev \
>>>>>>>> +        && \
>>>>>>>> +    \
>>>>>>>> +    # Build the kernel
>>>>>>>> +    curl -fsSLO
>>>>>>>> https://cdn.kernel.org/pub/linux/kernel/v5.x/linux-"$LINUX_VERSI=
ON".tar.xz
>>>>>>>> && \
>>>>>>>> +    tar xvJf linux-"$LINUX_VERSION".tar.xz && \
>>>>>>>> +    cd linux-"$LINUX_VERSION" && \
>>>>>>>> +    make defconfig && \
>>>>>>>> +    make xen.config && \
>>>>>>>> +    cp .config .config.orig && \
>>>>>>>> +    cat .config.orig | grep XEN | grep =3Dm |sed 's/=3Dm/=3Dy/g=
' >>
>>>>>>>> .config
>>>>>>>> && \
>>>>>>>> +    make -j$(nproc) bzImage && \
>>>>>>>
>>>>>>> defconfig is huuuuge.=C2=A0 Can we use tinyconfig instead?
>>>>>>>
>>>>>>> Also, you want to turn off CONFIG_MODULES seeing as you only copy=

>>>>>>> bzImage to the test.
>>>>>>>
>>>>>>> This also fixes the fact that `grep XEN` also matches
>>>>>>> CONFIG_NETXEN_NIC
>>>>>>> which has nothing to do with Xen.
>>>>>>
>>>>>> Tinyconfig would be a good idea but it crashes on QEMU with the ap=
pended
>>>>>> boot log. I did:
>>>>>>
>>>>>> # make tinyconfig
>>>>>> # make xen.config
>>>>>> # make bzImage
>>>>>>
>>>>>> Of course we could have our own tailored special kernel config for=
 this
>>>>>> kernel but I like the simplicify of "make tinyconfig" or "make
>>>>>> defconfig" followed by "make xen.config".
>>>>>>
>>>>>> Unless you know one kconfig option or two that we need to add to
>>>>>> tinyconfig to make it work my preference is to go with defconfig f=
or
>>>>>> now.
>>>>>
>>>>> You will need to add the dom0 and SMP related config options at lea=
st.
>>>>>
>>>>> I'll have a look at config.xen, which is a little bit weird: it
>>>>> configures the backends, but not dom0.
>>>>
>>>> Thanks, it would be good if make tinyconfig && make xen.config would=

>>>> just work on QEMU. In the meantime I'll keep defconfig for this test=
, we
>>>> can always improve later.
>>>
>>> Can you please test the attached patch?
>>
>> Yes, that works, thanks!
>=20
> Sorry, I spoke too soon: same error as before:
>=20
> https://gitlab.com/xen-project/people/sstabellini/xen/-/jobs/1722909607=
/raw
>=20
> (XEN) Hardware Dom0 crashed: rebooting machine in 5 seconds.
>=20
> No output from the kernel.

This is not very surprising, as tinyconfig doesn't have CONFIG_PRINTK.
BTW, it doesn't have initrd support either (BLK_DEV_RAM and
BLK_DEV_INITRD), so I added those to xen.config as well.

With the (updated) attached patch the kernel boots fine as dom0 until
rootfs is tried to be mounted on a physical machine.

I've added CONFIG_BUG, too, in order to have more debugging output if
needed.


Juergen

--------------FB101BD822545065E5676DF2
Content-Type: text/x-patch; charset=UTF-8;
 name="0001-x86-xen-update-xen.config.patch"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: attachment;
 filename="0001-x86-xen-update-xen.config.patch"

=46rom cb08391f332c850ba569b9232c8225ebe0e0758c Mon Sep 17 00:00:00 2001
From: Juergen Gross <jgross@suse.com>
Date: Wed, 27 Oct 2021 09:05:28 +0200
Subject: [PATCH] x86/xen: update xen.config

Update some entries in xen.config:

- add ACPI as being required for running as dom0
- add SMP for convenience
- add PRINTK and BUG for diagnosis support
- add BLK_DEV_INITRD and BLK_DEV_RAM for initrd support
- remove HIGHMEM64G as this option no longer exists
- remove XEN_MAX_DOMAIN_MEMORY as this option no longer exists

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 arch/x86/configs/xen.config | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/arch/x86/configs/xen.config b/arch/x86/configs/xen.config
index d9fc7139fd46..8db14cadf5b0 100644
--- a/arch/x86/configs/xen.config
+++ b/arch/x86/configs/xen.config
@@ -1,6 +1,4 @@
 # global x86 required specific stuff
-# On 32-bit HIGHMEM4G is not allowed
-CONFIG_HIGHMEM64G=3Dy
 CONFIG_64BIT=3Dy
=20
 # These enable us to allow some of the
@@ -9,12 +7,17 @@ CONFIG_HYPERVISOR_GUEST=3Dy
 CONFIG_PCI=3Dy
 CONFIG_PCI_MSI=3Dy
 CONFIG_X86_MCE=3Dy
+CONFIG_ACPI=3Dy
 CONFIG_ACPI_PROCESSOR=3Dy
 CONFIG_CPU_FREQ=3Dy
+CONFIG_SMP=3Dy
+CONFIG_PRINTK=3Dy
+CONFIG_BUG=3Dy
+CONFIG_BLK_DEV_RAM=3Dy
+CONFIG_BLK_DEV_INITRD=3Dy
=20
 # x86 xen specific config options
 CONFIG_XEN_PVH=3Dy
-CONFIG_XEN_MAX_DOMAIN_MEMORY=3D500
 CONFIG_XEN_SAVE_RESTORE=3Dy
 # CONFIG_XEN_DEBUG_FS is not set
 CONFIG_XEN_MCE_LOG=3Dy
--=20
2.26.2


--------------FB101BD822545065E5676DF2
Content-Type: application/pgp-keys;
 name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Transfer-Encoding: quoted-printable
Content-Description: OpenPGP public key
Content-Disposition: attachment;
 filename="OpenPGP_0xB0DE9DD628BF132F.asc"

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy=
cWx
w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O=
f8Z
d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y=
9bf
IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq=
G7/
377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR=
3Jv
c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA=
QIe
AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT=
hpw
dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0=
MbD
1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv=
oPH
Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v=
5QL
+qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ=
2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC=
QoL
BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr=
Wf0
teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC=
/nu
AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh=
ITT
d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm=
XBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz=
80h
SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC=
AcD
AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn=
FOX
gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1=
jnD
kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0=
N51
N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l=
otu
fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1=
tqS
EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA=
hsD
BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3=
g3O
ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5=
dM7
wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5=
D+j
LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm=
V2x
AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N=
Eaw
QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW=
nHI
s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR=
wgn
BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV=
bVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk=
pEd
IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA=
QAB
wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw=
Tbe
8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1=
vJz
Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8=
VGi
wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW=
svi
uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX=
zXs
ZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------FB101BD822545065E5676DF2--

--4xVbZeMI34GdqL0pKQ94tjWax7zfzoINd--

--8tTS3EAeEY8aqWI31agR6YRyIzlHM6igP
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmF6SnwFAwAAAAAACgkQsN6d1ii/Ey9l
fAf/dYu4D2wYqOE1Ou/zYyLj8KWnoJjXMYyOavVniqSMSjBgNJJGaoV/lzBfL5oH409YbGO1Qjgx
+2nB6WRv1jMWOdW41GDgu3zxs+O9+fAULdKi4k7k4XZyw9Ilcutj+65rkerijgiHnDL3E9udhcKF
Y7XQ8aJ/Dme3JRYrkKwh1lpvts2t1BALxCVlPkgvquJOVP4Rw/aFRKCKPyyR1ENU6fw4iRmGWNjO
Tn5Ir6dNU46BHDnuBT4SzC4Q9j6lhkGU3kPisU0KBDPmPhR+kWThTaU4ftlGUbOJ35zowfHsNUPh
67fpuJkFk9sZ6wUTbXz/fVm3MWLIYwuDNic/xC5IMA==
=mjKT
-----END PGP SIGNATURE-----

--8tTS3EAeEY8aqWI31agR6YRyIzlHM6igP--


From xen-devel-bounces@lists.xenproject.org Thu Oct 28 07:28:24 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Oct 2021 07:28:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217684.377828 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfzpT-00051z-EJ; Thu, 28 Oct 2021 07:28:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217684.377828; Thu, 28 Oct 2021 07:28:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfzpT-00051s-B6; Thu, 28 Oct 2021 07:28:03 +0000
Received: by outflank-mailman (input) for mailman id 217684;
 Thu, 28 Oct 2021 07:28:02 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=vfrR=PQ=suse.com=jgross@srs-us1.protection.inumbo.net>)
 id 1mfzpS-0004Ty-K0
 for xen-devel@lists.xenproject.org; Thu, 28 Oct 2021 07:28:02 +0000
Received: from smtp-out1.suse.de (unknown [195.135.220.28])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id f56227c9-2e4c-43c5-be9e-7872ee2bb4ea;
 Thu, 28 Oct 2021 07:27:57 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 68ADB21967;
 Thu, 28 Oct 2021 07:27:56 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 0D40313ABD;
 Thu, 28 Oct 2021 07:27:56 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id UAr+AfxQemEmGwAAMHmgww
 (envelope-from <jgross@suse.com>); Thu, 28 Oct 2021 07:27:56 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f56227c9-2e4c-43c5-be9e-7872ee2bb4ea
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1635406076; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=ggMgRCzUrgVk3/nbGHlSVTwAJfT38iDHULHtl55v/o8=;
	b=L+hv7qAjrtmHYTJ8VoWW7a/cmADpjn9JUa+yjIIp8HlLmnZVXHLcZHpgdATMNLaxfScin7
	eTxF6U3n9v2kka9NS4TuR31Zc2y4baK1ldiDDkiidpC1V7KxUJ3PibOnOsjl7eYQNoMpUP
	6PXws49K+zxxzYg50k1WwNhWqNMKcY0=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org,
	x86@kernel.org,
	virtualization@lists.linux-foundation.org,
	linux-kernel@vger.kernel.org
Cc: Juergen Gross <jgross@suse.com>,
	Deep Shah <sdeep@vmware.com>,
	"VMware, Inc." <pv-drivers@vmware.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>
Subject: [PATCH v3 2/2] x86/xen: switch initial pvops IRQ functions to dummy ones
Date: Thu, 28 Oct 2021 09:27:48 +0200
Message-Id: <20211028072748.29862-3-jgross@suse.com>
X-Mailer: git-send-email 2.26.2
In-Reply-To: <20211028072748.29862-1-jgross@suse.com>
References: <20211028072748.29862-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

The initial pvops functions handling irq flags will only ever be called
before interrupts are being enabled.

So switch them to be dummy functions:
- xen_save_fl() can always return 0
- xen_irq_disable() is a nop
- xen_irq_enable() can BUG()

Add some generic paravirt functions for that purpose.

Signed-off-by: Juergen Gross <jgross@suse.com>
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
---
V3:
- make paravirt_BUG() noinstr
---
 arch/x86/include/asm/paravirt_types.h |  2 +
 arch/x86/kernel/paravirt.c            | 13 +++++-
 arch/x86/xen/enlighten.c              | 19 +--------
 arch/x86/xen/irq.c                    | 61 ++-------------------------
 4 files changed, 20 insertions(+), 75 deletions(-)

diff --git a/arch/x86/include/asm/paravirt_types.h b/arch/x86/include/asm/paravirt_types.h
index d9d6b0203ec4..fc1151e77569 100644
--- a/arch/x86/include/asm/paravirt_types.h
+++ b/arch/x86/include/asm/paravirt_types.h
@@ -577,7 +577,9 @@ void paravirt_leave_lazy_mmu(void);
 void paravirt_flush_lazy_mmu(void);
 
 void _paravirt_nop(void);
+void paravirt_BUG(void);
 u64 _paravirt_ident_64(u64);
+unsigned long paravirt_ret0(void);
 
 #define paravirt_nop	((void *)_paravirt_nop)
 
diff --git a/arch/x86/kernel/paravirt.c b/arch/x86/kernel/paravirt.c
index 04cafc057bed..b44814dfe83f 100644
--- a/arch/x86/kernel/paravirt.c
+++ b/arch/x86/kernel/paravirt.c
@@ -46,6 +46,17 @@ asm (".pushsection .entry.text, \"ax\"\n"
      ".type _paravirt_nop, @function\n\t"
      ".popsection");
 
+/* stub always returning 0. */
+asm (".pushsection .entry.text, \"ax\"\n"
+     ".global paravirt_ret0\n"
+     "paravirt_ret0:\n\t"
+     "xor %" _ASM_AX ", %" _ASM_AX ";\n\t"
+     "ret\n\t"
+     ".size paravirt_ret0, . - paravirt_ret0\n\t"
+     ".type paravirt_ret0, @function\n\t"
+     ".popsection");
+
+
 void __init default_banner(void)
 {
 	printk(KERN_INFO "Booting paravirtualized kernel on %s\n",
@@ -53,7 +64,7 @@ void __init default_banner(void)
 }
 
 /* Undefined instruction for dealing with missing ops pointers. */
-static void paravirt_BUG(void)
+noinstr void paravirt_BUG(void)
 {
 	BUG();
 }
diff --git a/arch/x86/xen/enlighten.c b/arch/x86/xen/enlighten.c
index 006b4a814fac..30c6e986a6cd 100644
--- a/arch/x86/xen/enlighten.c
+++ b/arch/x86/xen/enlighten.c
@@ -31,25 +31,10 @@ EXPORT_SYMBOL_GPL(hypercall_page);
  * Pointer to the xen_vcpu_info structure or
  * &HYPERVISOR_shared_info->vcpu_info[cpu]. See xen_hvm_init_shared_info
  * and xen_vcpu_setup for details. By default it points to share_info->vcpu_info
- * but if the hypervisor supports VCPUOP_register_vcpu_info then it can point
- * to xen_vcpu_info. The pointer is used in __xen_evtchn_do_upcall to
- * acknowledge pending events.
- * Also more subtly it is used by the patched version of irq enable/disable
- * e.g. xen_irq_enable_direct and xen_iret in PV mode.
- *
- * The desire to be able to do those mask/unmask operations as a single
- * instruction by using the per-cpu offset held in %gs is the real reason
- * vcpu info is in a per-cpu pointer and the original reason for this
- * hypercall.
- *
+ * but during boot it is switched to point to xen_vcpu_info.
+ * The pointer is used in __xen_evtchn_do_upcall to acknowledge pending events.
  */
 DEFINE_PER_CPU(struct vcpu_info *, xen_vcpu);
-
-/*
- * Per CPU pages used if hypervisor supports VCPUOP_register_vcpu_info
- * hypercall. This can be used both in PV and PVHVM mode. The structure
- * overrides the default per_cpu(xen_vcpu, cpu) value.
- */
 DEFINE_PER_CPU(struct vcpu_info, xen_vcpu_info);
 
 /* Linux <-> Xen vCPU id mapping */
diff --git a/arch/x86/xen/irq.c b/arch/x86/xen/irq.c
index dfa091d79c2e..ae8537583102 100644
--- a/arch/x86/xen/irq.c
+++ b/arch/x86/xen/irq.c
@@ -24,60 +24,6 @@ void xen_force_evtchn_callback(void)
 	(void)HYPERVISOR_xen_version(0, NULL);
 }
 
-asmlinkage __visible unsigned long xen_save_fl(void)
-{
-	struct vcpu_info *vcpu;
-	unsigned long flags;
-
-	vcpu = this_cpu_read(xen_vcpu);
-
-	/* flag has opposite sense of mask */
-	flags = !vcpu->evtchn_upcall_mask;
-
-	/* convert to IF type flag
-	   -0 -> 0x00000000
-	   -1 -> 0xffffffff
-	*/
-	return (-flags) & X86_EFLAGS_IF;
-}
-PV_CALLEE_SAVE_REGS_THUNK(xen_save_fl);
-
-asmlinkage __visible void xen_irq_disable(void)
-{
-	/* There's a one instruction preempt window here.  We need to
-	   make sure we're don't switch CPUs between getting the vcpu
-	   pointer and updating the mask. */
-	preempt_disable();
-	this_cpu_read(xen_vcpu)->evtchn_upcall_mask = 1;
-	preempt_enable_no_resched();
-}
-PV_CALLEE_SAVE_REGS_THUNK(xen_irq_disable);
-
-asmlinkage __visible void xen_irq_enable(void)
-{
-	struct vcpu_info *vcpu;
-
-	/*
-	 * We may be preempted as soon as vcpu->evtchn_upcall_mask is
-	 * cleared, so disable preemption to ensure we check for
-	 * events on the VCPU we are still running on.
-	 */
-	preempt_disable();
-
-	vcpu = this_cpu_read(xen_vcpu);
-	vcpu->evtchn_upcall_mask = 0;
-
-	/* Doesn't matter if we get preempted here, because any
-	   pending event will get dealt with anyway. */
-
-	barrier(); /* unmask then check (avoid races) */
-	if (unlikely(vcpu->evtchn_upcall_pending))
-		xen_force_evtchn_callback();
-
-	preempt_enable();
-}
-PV_CALLEE_SAVE_REGS_THUNK(xen_irq_enable);
-
 static void xen_safe_halt(void)
 {
 	/* Blocking includes an implicit local_irq_enable(). */
@@ -95,9 +41,10 @@ static void xen_halt(void)
 }
 
 static const struct pv_irq_ops xen_irq_ops __initconst = {
-	.save_fl = PV_CALLEE_SAVE(xen_save_fl),
-	.irq_disable = PV_CALLEE_SAVE(xen_irq_disable),
-	.irq_enable = PV_CALLEE_SAVE(xen_irq_enable),
+	/* Initial interrupt flag handling only called while interrupts off. */
+	.save_fl = __PV_IS_CALLEE_SAVE(paravirt_ret0),
+	.irq_disable = __PV_IS_CALLEE_SAVE(paravirt_nop),
+	.irq_enable = __PV_IS_CALLEE_SAVE(paravirt_BUG),
 
 	.safe_halt = xen_safe_halt,
 	.halt = xen_halt,
-- 
2.26.2



From xen-devel-bounces@lists.xenproject.org Thu Oct 28 07:28:24 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Oct 2021 07:28:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217683.377811 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfzpQ-0004Xk-9R; Thu, 28 Oct 2021 07:28:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217683.377811; Thu, 28 Oct 2021 07:28:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfzpQ-0004Wm-2F; Thu, 28 Oct 2021 07:28:00 +0000
Received: by outflank-mailman (input) for mailman id 217683;
 Thu, 28 Oct 2021 07:27:59 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=vfrR=PQ=suse.com=jgross@srs-us1.protection.inumbo.net>)
 id 1mfzpO-0004U4-Tx
 for xen-devel@lists.xenproject.org; Thu, 28 Oct 2021 07:27:58 +0000
Received: from smtp-out1.suse.de (unknown [195.135.220.28])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 913742bf-37c0-11ec-8499-12813bfff9fa;
 Thu, 28 Oct 2021 07:27:57 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 04A4B21966;
 Thu, 28 Oct 2021 07:27:56 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id ADEA513ABD;
 Thu, 28 Oct 2021 07:27:55 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id 0KRSKftQemEmGwAAMHmgww
 (envelope-from <jgross@suse.com>); Thu, 28 Oct 2021 07:27:55 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 913742bf-37c0-11ec-8499-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1635406076; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=PUfw6t8nwpxm2zhH5abaL+rPMYpBE9jrK9+wuQK9hvA=;
	b=gi6tqNuahpz4PiXSsejbjDh7zaV2+FLmXWLxMRdjprAWF5wE8v3Vjmp8qgy0D1hMn6S5vM
	wDB8UN/b58JMPqALcU8BEyk1mlq3oTqvRGoyECXLSjWaLEgOmzvBO8Ef8JKReLmj00h2Jz
	lTjxccr136CnGdVrXXgPiOH8c9oYrqU=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org,
	x86@kernel.org,
	linux-kernel@vger.kernel.org
Cc: Juergen Gross <jgross@suse.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Peter Zijlstra <peterz@infradead.org>
Subject: [PATCH v3 1/2] x86/xen: remove xen_have_vcpu_info_placement flag
Date: Thu, 28 Oct 2021 09:27:47 +0200
Message-Id: <20211028072748.29862-2-jgross@suse.com>
X-Mailer: git-send-email 2.26.2
In-Reply-To: <20211028072748.29862-1-jgross@suse.com>
References: <20211028072748.29862-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

The flag xen_have_vcpu_info_placement was needed to support Xen
hypervisors older than version 3.4, which didn't support the
VCPUOP_register_vcpu_info hypercall. Today the Linux kernel requires
at least Xen 4.0 to be able to run, so xen_have_vcpu_info_placement
can be dropped (in theory the flag was used to ensure a working kernel
even in case of the VCPUOP_register_vcpu_info hypercall failing for
other reasons than the hypercall not being supported, but the only
cases covered by the flag would be parameter errors, which ought not
to be made anyway).

This allows to let some functions return void now, as they can never
fail.

Signed-off-by: Juergen Gross <jgross@suse.com>
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
---
 arch/x86/xen/enlighten.c     | 97 +++++++++---------------------------
 arch/x86/xen/enlighten_hvm.c |  6 +--
 arch/x86/xen/enlighten_pv.c  | 28 ++---------
 arch/x86/xen/smp.c           | 24 ---------
 arch/x86/xen/xen-ops.h       |  4 +-
 5 files changed, 33 insertions(+), 126 deletions(-)

diff --git a/arch/x86/xen/enlighten.c b/arch/x86/xen/enlighten.c
index 95d970359e17..006b4a814fac 100644
--- a/arch/x86/xen/enlighten.c
+++ b/arch/x86/xen/enlighten.c
@@ -84,21 +84,6 @@ EXPORT_SYMBOL(xen_start_flags);
  */
 struct shared_info *HYPERVISOR_shared_info = &xen_dummy_shared_info;
 
-/*
- * Flag to determine whether vcpu info placement is available on all
- * VCPUs.  We assume it is to start with, and then set it to zero on
- * the first failure.  This is because it can succeed on some VCPUs
- * and not others, since it can involve hypervisor memory allocation,
- * or because the guest failed to guarantee all the appropriate
- * constraints on all VCPUs (ie buffer can't cross a page boundary).
- *
- * Note that any particular CPU may be using a placed vcpu structure,
- * but we can only optimise if the all are.
- *
- * 0: not available, 1: available
- */
-int xen_have_vcpu_info_placement = 1;
-
 static int xen_cpu_up_online(unsigned int cpu)
 {
 	xen_init_lock_cpu(cpu);
@@ -124,10 +109,8 @@ int xen_cpuhp_setup(int (*cpu_up_prepare_cb)(unsigned int),
 	return rc >= 0 ? 0 : rc;
 }
 
-static int xen_vcpu_setup_restore(int cpu)
+static void xen_vcpu_setup_restore(int cpu)
 {
-	int rc = 0;
-
 	/* Any per_cpu(xen_vcpu) is stale, so reset it */
 	xen_vcpu_info_reset(cpu);
 
@@ -136,11 +119,8 @@ static int xen_vcpu_setup_restore(int cpu)
 	 * be handled by hotplug.
 	 */
 	if (xen_pv_domain() ||
-	    (xen_hvm_domain() && cpu_online(cpu))) {
-		rc = xen_vcpu_setup(cpu);
-	}
-
-	return rc;
+	    (xen_hvm_domain() && cpu_online(cpu)))
+		xen_vcpu_setup(cpu);
 }
 
 /*
@@ -150,7 +130,7 @@ static int xen_vcpu_setup_restore(int cpu)
  */
 void xen_vcpu_restore(void)
 {
-	int cpu, rc;
+	int cpu;
 
 	for_each_possible_cpu(cpu) {
 		bool other_cpu = (cpu != smp_processor_id());
@@ -170,20 +150,9 @@ void xen_vcpu_restore(void)
 		if (xen_pv_domain() || xen_feature(XENFEAT_hvm_safe_pvclock))
 			xen_setup_runstate_info(cpu);
 
-		rc = xen_vcpu_setup_restore(cpu);
-		if (rc)
-			pr_emerg_once("vcpu restore failed for cpu=%d err=%d. "
-					"System will hang.\n", cpu, rc);
-		/*
-		 * In case xen_vcpu_setup_restore() fails, do not bring up the
-		 * VCPU. This helps us avoid the resulting OOPS when the VCPU
-		 * accesses pvclock_vcpu_time via xen_vcpu (which is NULL.)
-		 * Note that this does not improve the situation much -- now the
-		 * VM hangs instead of OOPSing -- with the VCPUs that did not
-		 * fail, spinning in stop_machine(), waiting for the failed
-		 * VCPUs to come up.
-		 */
-		if (other_cpu && is_up && (rc == 0) &&
+		xen_vcpu_setup_restore(cpu);
+
+		if (other_cpu && is_up &&
 		    HYPERVISOR_vcpu_op(VCPUOP_up, xen_vcpu_nr(cpu), NULL))
 			BUG();
 	}
@@ -200,7 +169,7 @@ void xen_vcpu_info_reset(int cpu)
 	}
 }
 
-int xen_vcpu_setup(int cpu)
+void xen_vcpu_setup(int cpu)
 {
 	struct vcpu_register_vcpu_info info;
 	int err;
@@ -221,44 +190,26 @@ int xen_vcpu_setup(int cpu)
 	 */
 	if (xen_hvm_domain()) {
 		if (per_cpu(xen_vcpu, cpu) == &per_cpu(xen_vcpu_info, cpu))
-			return 0;
+			return;
 	}
 
-	if (xen_have_vcpu_info_placement) {
-		vcpup = &per_cpu(xen_vcpu_info, cpu);
-		info.mfn = arbitrary_virt_to_mfn(vcpup);
-		info.offset = offset_in_page(vcpup);
+	vcpup = &per_cpu(xen_vcpu_info, cpu);
+	info.mfn = arbitrary_virt_to_mfn(vcpup);
+	info.offset = offset_in_page(vcpup);
 
-		/*
-		 * Check to see if the hypervisor will put the vcpu_info
-		 * structure where we want it, which allows direct access via
-		 * a percpu-variable.
-		 * N.B. This hypercall can _only_ be called once per CPU.
-		 * Subsequent calls will error out with -EINVAL. This is due to
-		 * the fact that hypervisor has no unregister variant and this
-		 * hypercall does not allow to over-write info.mfn and
-		 * info.offset.
-		 */
-		err = HYPERVISOR_vcpu_op(VCPUOP_register_vcpu_info,
-					 xen_vcpu_nr(cpu), &info);
-
-		if (err) {
-			pr_warn_once("register_vcpu_info failed: cpu=%d err=%d\n",
-				     cpu, err);
-			xen_have_vcpu_info_placement = 0;
-		} else {
-			/*
-			 * This cpu is using the registered vcpu info, even if
-			 * later ones fail to.
-			 */
-			per_cpu(xen_vcpu, cpu) = vcpup;
-		}
-	}
-
-	if (!xen_have_vcpu_info_placement)
-		xen_vcpu_info_reset(cpu);
+	/*
+	 * N.B. This hypercall can _only_ be called once per CPU.
+	 * Subsequent calls will error out with -EINVAL. This is due to
+	 * the fact that hypervisor has no unregister variant and this
+	 * hypercall does not allow to over-write info.mfn and
+	 * info.offset.
+	 */
+	err = HYPERVISOR_vcpu_op(VCPUOP_register_vcpu_info, xen_vcpu_nr(cpu),
+				 &info);
+	if (err)
+		panic("register_vcpu_info failed: cpu=%d err=%d\n", cpu, err);
 
-	return ((per_cpu(xen_vcpu, cpu) == NULL) ? -ENODEV : 0);
+	per_cpu(xen_vcpu, cpu) = vcpup;
 }
 
 void __init xen_banner(void)
diff --git a/arch/x86/xen/enlighten_hvm.c b/arch/x86/xen/enlighten_hvm.c
index e68ea5f4ad1c..42300941ec29 100644
--- a/arch/x86/xen/enlighten_hvm.c
+++ b/arch/x86/xen/enlighten_hvm.c
@@ -163,9 +163,9 @@ static int xen_cpu_up_prepare_hvm(unsigned int cpu)
 		per_cpu(xen_vcpu_id, cpu) = cpu_acpi_id(cpu);
 	else
 		per_cpu(xen_vcpu_id, cpu) = cpu;
-	rc = xen_vcpu_setup(cpu);
-	if (rc || !xen_have_vector_callback)
-		return rc;
+	xen_vcpu_setup(cpu);
+	if (!xen_have_vector_callback)
+		return 0;
 
 	if (xen_feature(XENFEAT_hvm_safe_pvclock))
 		xen_setup_timer(cpu);
diff --git a/arch/x86/xen/enlighten_pv.c b/arch/x86/xen/enlighten_pv.c
index a7b7d674f500..2635a00be42d 100644
--- a/arch/x86/xen/enlighten_pv.c
+++ b/arch/x86/xen/enlighten_pv.c
@@ -993,31 +993,13 @@ void __init xen_setup_vcpu_info_placement(void)
 	for_each_possible_cpu(cpu) {
 		/* Set up direct vCPU id mapping for PV guests. */
 		per_cpu(xen_vcpu_id, cpu) = cpu;
-
-		/*
-		 * xen_vcpu_setup(cpu) can fail  -- in which case it
-		 * falls back to the shared_info version for cpus
-		 * where xen_vcpu_nr(cpu) < MAX_VIRT_CPUS.
-		 *
-		 * xen_cpu_up_prepare_pv() handles the rest by failing
-		 * them in hotplug.
-		 */
-		(void) xen_vcpu_setup(cpu);
+		xen_vcpu_setup(cpu);
 	}
 
-	/*
-	 * xen_vcpu_setup managed to place the vcpu_info within the
-	 * percpu area for all cpus, so make use of it.
-	 */
-	if (xen_have_vcpu_info_placement) {
-		pv_ops.irq.save_fl = __PV_IS_CALLEE_SAVE(xen_save_fl_direct);
-		pv_ops.irq.irq_disable =
-			__PV_IS_CALLEE_SAVE(xen_irq_disable_direct);
-		pv_ops.irq.irq_enable =
-			__PV_IS_CALLEE_SAVE(xen_irq_enable_direct);
-		pv_ops.mmu.read_cr2 =
-			__PV_IS_CALLEE_SAVE(xen_read_cr2_direct);
-	}
+	pv_ops.irq.save_fl = __PV_IS_CALLEE_SAVE(xen_save_fl_direct);
+	pv_ops.irq.irq_disable = __PV_IS_CALLEE_SAVE(xen_irq_disable_direct);
+	pv_ops.irq.irq_enable = __PV_IS_CALLEE_SAVE(xen_irq_enable_direct);
+	pv_ops.mmu.read_cr2 = __PV_IS_CALLEE_SAVE(xen_read_cr2_direct);
 }
 
 static const struct pv_info xen_info __initconst = {
diff --git a/arch/x86/xen/smp.c b/arch/x86/xen/smp.c
index c1b2f764b29a..bafa61b1482f 100644
--- a/arch/x86/xen/smp.c
+++ b/arch/x86/xen/smp.c
@@ -121,34 +121,10 @@ int xen_smp_intr_init(unsigned int cpu)
 
 void __init xen_smp_cpus_done(unsigned int max_cpus)
 {
-	int cpu, rc, count = 0;
-
 	if (xen_hvm_domain())
 		native_smp_cpus_done(max_cpus);
 	else
 		calculate_max_logical_packages();
-
-	if (xen_have_vcpu_info_placement)
-		return;
-
-	for_each_online_cpu(cpu) {
-		if (xen_vcpu_nr(cpu) < MAX_VIRT_CPUS)
-			continue;
-
-		rc = remove_cpu(cpu);
-
-		if (rc == 0) {
-			/*
-			 * Reset vcpu_info so this cpu cannot be onlined again.
-			 */
-			xen_vcpu_info_reset(cpu);
-			count++;
-		} else {
-			pr_warn("%s: failed to bring CPU %d down, error %d\n",
-				__func__, cpu, rc);
-		}
-	}
-	WARN(count, "%s: brought %d CPUs offline\n", __func__, count);
 }
 
 void xen_smp_send_reschedule(int cpu)
diff --git a/arch/x86/xen/xen-ops.h b/arch/x86/xen/xen-ops.h
index 8bc8b72a205d..fd0fec6e92f4 100644
--- a/arch/x86/xen/xen-ops.h
+++ b/arch/x86/xen/xen-ops.h
@@ -76,9 +76,7 @@ irqreturn_t xen_debug_interrupt(int irq, void *dev_id);
 
 bool xen_vcpu_stolen(int vcpu);
 
-extern int xen_have_vcpu_info_placement;
-
-int xen_vcpu_setup(int cpu);
+void xen_vcpu_setup(int cpu);
 void xen_vcpu_info_reset(int cpu);
 void xen_setup_vcpu_info_placement(void);
 
-- 
2.26.2



From xen-devel-bounces@lists.xenproject.org Thu Oct 28 07:28:24 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Oct 2021 07:28:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217682.377806 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfzpP-0004UI-Uq; Thu, 28 Oct 2021 07:27:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217682.377806; Thu, 28 Oct 2021 07:27:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfzpP-0004UB-RT; Thu, 28 Oct 2021 07:27:59 +0000
Received: by outflank-mailman (input) for mailman id 217682;
 Thu, 28 Oct 2021 07:27:57 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=vfrR=PQ=suse.com=jgross@srs-us1.protection.inumbo.net>)
 id 1mfzpN-0004Ty-RQ
 for xen-devel@lists.xenproject.org; Thu, 28 Oct 2021 07:27:57 +0000
Received: from smtp-out2.suse.de (unknown [195.135.220.29])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 3086f298-831e-47fa-a994-02350b070050;
 Thu, 28 Oct 2021 07:27:56 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id A67AA1FD4B;
 Thu, 28 Oct 2021 07:27:55 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 503A013ABD;
 Thu, 28 Oct 2021 07:27:55 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id FZtpEvtQemEmGwAAMHmgww
 (envelope-from <jgross@suse.com>); Thu, 28 Oct 2021 07:27:55 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3086f298-831e-47fa-a994-02350b070050
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1635406075; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:  content-transfer-encoding:content-transfer-encoding;
	bh=s1H6Hgf+92X5PDjWMvrW0ZAWQ57zgmauDgvkDjzNQEw=;
	b=W6sS9Lg3HJmDdeEnNjwpHBIHJr/K64x8BNLpRXk/C/7c9+zWtPK6+QSuBu3FbHknmNGgQ0
	wUFQFbZw0q/2YD74L4zQkU3/V5NQJ4bXt2Dkn84gWMIONgCBnwcyZ8DlE+MNbAYEruXC4A
	xLF/3abL2rn8eOCFSEFfKQHiiBjrzec=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org,
	x86@kernel.org,
	linux-kernel@vger.kernel.org,
	virtualization@lists.linux-foundation.org
Cc: Juergen Gross <jgross@suse.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Deep Shah <sdeep@vmware.com>,
	"VMware, Inc." <pv-drivers@vmware.com>
Subject: [PATCH v3 0/2] x86/xen: simplify irq pvops
Date: Thu, 28 Oct 2021 09:27:46 +0200
Message-Id: <20211028072748.29862-1-jgross@suse.com>
X-Mailer: git-send-email 2.26.2
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

The pvops function for Xen PV guests handling the interrupt flag are
much more complex than needed.

With the supported Xen hypervisor versions they can be simplified a
lot, especially by removing the need for disabling preemption.

Juergen Gross (2):
  x86/xen: remove xen_have_vcpu_info_placement flag
  x86/xen: switch initial pvops IRQ functions to dummy ones

 arch/x86/include/asm/paravirt_types.h |   2 +
 arch/x86/kernel/paravirt.c            |  13 ++-
 arch/x86/xen/enlighten.c              | 116 ++++++--------------------
 arch/x86/xen/enlighten_hvm.c          |   6 +-
 arch/x86/xen/enlighten_pv.c           |  28 ++-----
 arch/x86/xen/irq.c                    |  61 +-------------
 arch/x86/xen/smp.c                    |  24 ------
 arch/x86/xen/xen-ops.h                |   4 +-
 8 files changed, 53 insertions(+), 201 deletions(-)

-- 
2.26.2



From xen-devel-bounces@lists.xenproject.org Thu Oct 28 07:31:43 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Oct 2021 07:31:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217703.377839 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfzsw-00076M-0q; Thu, 28 Oct 2021 07:31:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217703.377839; Thu, 28 Oct 2021 07:31:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfzsv-00076F-T4; Thu, 28 Oct 2021 07:31:37 +0000
Received: by outflank-mailman (input) for mailman id 217703;
 Thu, 28 Oct 2021 07:31:36 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=8Bw3=PQ=citrix.com=roger.pau@srs-us1.protection.inumbo.net>)
 id 1mfzsu-000769-Lz
 for xen-devel@lists.xenproject.org; Thu, 28 Oct 2021 07:31:36 +0000
Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 8b015873-6436-4dca-9a47-3b0071903eda;
 Thu, 28 Oct 2021 07:31:35 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8b015873-6436-4dca-9a47-3b0071903eda
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1635406295;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=Igg5TvV0Krxv12+lr9LmMK5oWENoLKkAF6Ex2oIH7fo=;
  b=QZ3M3V5qY+h4jVB7X2AI+rFvmA4rGSme4CqRv1pdalSQH09iOl9aUdas
   lqlz4Mn1wh04SR1dcmiM1432P2YIw/aCdk3C/D+spdZJOTVqbfOzxChtn
   L8iyIduS/p07nkjRpxxjGxZiIxkVZ6Erq4WrM8WT//XedhJmAGsLcvU7D
   4=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: XRCSgrGeoXAi6NUaueYdd3aoBgTk5pTSYcD3kSHP0WUtKilbCfbz3mviN3eaQthCAI7vGbyzQo
 KbeZmHc8v7u2J3z2iodTyQQ2XMJHqvbOc/nOiomXpDb72XNadW2FjMTayk+3x0rulrVmk4mULd
 2GcfOjV4Sqiy89a2uiboAVMGR5eRDI3JIK8x0UkQRuEE8Cjmt0lxJjraIgk45YGVWGd1Qc2JRh
 SAG9ryWsLyBWzRdRYNdsu2GMHHD+3HYWdzxFC04IZy5M511MNsyDez+W2BNujBS4FaBNozAdpJ
 FwNgUup4WeK402FB9S4qXv6V
X-SBRS: 5.1
X-MesageID: 56918969
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:uHQ4IaIlvqatxLKBFE+RJ5IlxSXFcZb7ZxGr2PjKsXjdYENS3mdRm
 zBLX27Sb67eambxc4glbIuzpk5T75CDytc3TVBlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s
 q3yv/GZdJhcokcxIn5BC5C5xZVG/fjgqoHUVaiUZUideSc+EH140Eo5y7Zg6mJVqYPR7z2l6
 IuaT/L3YDdJ6xYsWo7Dw/vewP/HlK2aVAIw5jTSV9gS1LPtvyB94KYkDbOwNxPFrrx8RYZWc
 QphIIaRpQs19z91Yj+sfy2SnkciGtY+NiDW4pZatjTLbrGvaUXe345iXMfwZ3u7hB3Ypf581
 tRHm6euWEQOGYHxgaMCXzJxRnQW0a1uoNcrIFC6uM2XiUbHb2Ht07NlC0Re0Y8wo7gtRzsUr
 LpBdW5LPkvra+GemdpXTsF2gcsuNo/zNZ43sXB81zDJS/0hRPgvRo2Xu44BjGZu16iiG97RN
 o0VMz1FNC77YhtOYHYlLZUkjMa30yyXnzpw9wvO+PtfD3Lo5BN1+KjgNpzSYNPibcRKnG6Iq
 2Te5WP7DxoGctuFxlKt4n+qw+PCgy7/cIYTD6GjsO5nhkWJwW4eAwFQUkG0ydGboEOjX9NUK
 2QP5zEj66M18SSWosLVBkPi5iTe51hFBoQWQ7ZSBByxJrT8sjy3C3YFRBB6ds1lk+gaeCVty
 VOitoa8bdBwi4G9RXWY/7aSiDq9PykJMGMPDRM5oRs5D8rL+95r0EqeJjp3OOvs1IetQGCvq
 9yfhHFm3+17sCId60msEbkraRqXrZ/VUhV92AzTWm+0hu+STN/4P9L2gbQ3APApEWp4crVjl
 CRb8yR9xLpXZX1oqMBraL5UdF1Oz63cWAAweXY1Q/EcG82FohZPh7x47jBkP1tOOc0ZYzLva
 0K7kVoPv8IIYiPwNvEmM97Z5yEWIU7ITo2Nuhf8NYMmX3SMXFXfoHEGibC4hjiFfLcQfVEXZ
 s7ALJfE4YcyAqV71jumL9rxIpdwrh3SMVj7HMihpzz+iOL2TCfMFd8tbQvfBshkvfjsiFiEr
 L5i2z6ilkw3vBvWOXKMr+b+7DkicBAGOHwBg5cGK7DZelA/RDFJ5j246epJRrGJVp99z4/g1
 nq8RlVZ2Bz4g3jGIh+NcXdtdPXkWpMXkJ7xFXVE0Y+A1ydxbICxwr0YcpdrL7Ar+PY6lax/T
 uUfetXGCfNKE2yV9zMYZJj7jYpjaBX02l7eY3v7OGAyL8x6WgjE2t74ZQ+zpiMAOTW66Jklq
 Lq62wKFHZdaH1Z+DNzbYe6Exk+quSRPg/p7WkbFe4EBeEjl/IVwBTb2i/s7f5MFJRnZn2PI3
 AeKGxYI4+LKptZtotXOgKmFqaavEvd/QRUGTzWKs+7uOHCDrGS5wIJGXOKZRhznVTv5qPe4e
 OFY7/DgK/lbzlxEhJVxTuRwxqUk6tqx+7IDllZ4HG/GZkiAA697JiXUxtFGs6BAy+MLuQayX
 U7TqNBWNa/QZZHgGV8VYgEkcv6CxbcfnTyLtaY5J0Dz5SlW+rubUBoNY0nQ2XIFdLYlYpk4x
 eoBudIN713tgxUnBd+KkyRI+jneNXcHSagm6skXDYKDZtDHEb2ejUgw0hPL3aw=
IronPort-HdrOrdr: A9a23:zO0kvKAop3X1BiPlHehKsceALOsnbusQ8zAXPh9KJyC9I/b2qy
 nxppgmPH/P6Ar4WBkb6La90Y27MA7hHP9OkPMs1NKZPTUO11HYSb2KgbGSpwEIXheOitK1tp
 0QApSWaueAdWSS5PySiGLTfqdCsbv3gJxAx92utEuFJTsaFZ2IhD0JczpzfHcGIzWvUvECZe
 WhD4d81nCdUEVSSv7+KmgOXuDFqdGOvJX6YSQeDxpizAWVlzun5JPzDhDdh34lIn9y6IZn1V
 KAvx3y562lvf3+4hjA11XL55ATvNf60NNMCOGFl8BQADTxjQSDYphnRtS5zX0IidDqzGxvvM
 jHoh8mMcg2w3TNflutqR+o4AXk2CZG0Q6q9XaoxV/Y5eDpTjMzDMRMwahDdAHC1kYmtNZglI
 pWwmOwrfNsfFL9tRW4w+KNewBhl0Kyr3Znu/UUlWZjXYwXb6IUhZAD/XlSDIwLEEvBmc4a+d
 FVfYLhDcttABGnhyizhBgr/DXsZAV9Iv6+eDlDhiTPuAIm2EyQzCMjtboidzk7hdUAoqJ/lp
 b525JT5cZzp/8tHNFA7dg6ML6K40z2MFrx2TGpUB/a/J9uAQO4l3ew2sRy2N2X
X-IronPort-AV: E=Sophos;i="5.87,189,1631592000"; 
   d="scan'208";a="56918969"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=UPc35hQhDhXv+hTms8Xz/VfCGKe4qJgrYzRJBt+9UpZpgGqCE6iSPdJNouSVARx+RRRRyQJvsIGbL0YyL9UEgQ3H1+6x2lNnxGv8Agoiyv9le3xQxsQ6YrfwW6It7Gd0e4wgx7fFnzNDfFJYhPETrUv82ALl7BjZ81iU1tCriMIVDgTEXFHl9nTmepl//MmS6Bh6ZqawgeZ280MvEzfgf/mrw03T9xePxRFGmE7b+cYBkiYeMRPsUAEpwz8mZ0XGx4bViJnVVfeBWC/KZBTbQuRaoX/T9k8mU1x9ah/NtB8Tp5eVhOO+xniwAV/XZM0VyufwK3j5KaQQgo3RKUrhhw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=OXHP1hrv9uTrfHr1OoxQoKeUCSVR/pziD6tkAO1sNQw=;
 b=PWdAX4aytmqtt6t8rDrIDfrVBDQ2b/+jGnf8n7rtZYIF0zgH4DriuAPgeRwkBl0kQTqEVaeN598YN8EB4sc3qEMDO48pvyA0wWpAiuTQ+r1HZC+PhJfzofb6ESNa05bw2OE2fz2iYRFNZggSJsN0EMcKcdAbq3P/2T2Q0mpCiZNaaGPl+STLg/A6fB7VAd1B73WEpicBv7Tm5MuSZjSGfecB57Zjw7b2PHdmJkO71Qnk7XUDmVvlfPfVAkiMCrRZwxzSbr6PEU/A6ORL2MSvhY2nOJL0qqMrJPfBkqegyY5xwY//lUix+a/PNjK/AxUImixIfNNFtYKM3u+TU88Lkg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=OXHP1hrv9uTrfHr1OoxQoKeUCSVR/pziD6tkAO1sNQw=;
 b=PJ9kilD22I10NS0kYBOHbKGfzXlM7qSwzzBfSQd0sqsJIQQaXBu9qb5G+Y13yzwhsSp0fvCrNC9dBkB+8P258wrpI//nFUW68e1ZMXXdILcOEOzdI31YiAr9MjhJsIP22A59YKrvuBcV00CM+HskuRPctC29thJrNdsP/t5pAkg=
Date: Thu, 28 Oct 2021 09:31:24 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>, Jan Beulich
	<JBeulich@suse.com>, Wei Liu <wl@xen.org>, Ian Jackson <iwj@xenproject.org>
Subject: Re: [PATCH] x86/passthrough:  Fix hvm_gsi_eoi() build with GCC 12
Message-ID: <YXpRzHEawUZEU87h@Air-de-Roger>
References: <20211027200713.22625-1-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20211027200713.22625-1-andrew.cooper3@citrix.com>
X-ClientProxiedBy: MR1P264CA0042.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:501:3e::23) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 01916b7c-87c4-48d0-a6b7-08d999e4f5e6
X-MS-TrafficTypeDiagnostic: DM6PR03MB3833:
X-Microsoft-Antispam-PRVS: <DM6PR03MB3833C2D8C7466FE5624D9B528F869@DM6PR03MB3833.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 6DQYqtkvrGDmb2qERQr9qhZhq/UAhsVFlMMRdzRzQBCTK0ByeyflE1hQ7uEtuXmsDfOggd4q4S8qrYX0Puk1LcyRX4MT8bWXrVQubeZQeOw6gCauMZN3EXt81P1xAN7Z1tP8tlaCOORwPeTElcSeHyxb6fx2GghBb/4RxdXxndkHjd0IrJxAdjaX+l+KFjPIsumWfCRpFVYl4fO+M+jDt1Zo2dsu+HpSnX75tbSI2lDuhuwtHPCXdxxV+8ZcRsQSxgqpYPyt5M68m6SA82ZdzYQdtVNnqWhS0eTKP+gBYmyNAABCp7cSHLdIcP+haeMfwM19ZwPAZfHWkov+IdpBNuM9K2i+ybfHCgzPXrQdm+uxPgXVmmo3GRrMk41AFXpv2JdzosULLTqh4Vzftv4Qii5Q7y4QRyEOhoT71s7nO9yed2VnmcW55AAHRJtwv+TMpbpeFk3lwbNW6rkWX2nr4fpA26zM7yGM7pYH0rhRkypIpEuPE4DxdaeBkeg4AbthfuvKqmQ8/AK1+4TELlCgnU82Z+SZTE4C71hOtA/7a0YBdICg+KAbUuFVI3dwbrkq7MjEsVCJPyVnKwhpbRFEeHmVLW6agxSuYK6+RVL2Ef+3FsmlfHcPjewBkAiT71qebGjtH2HeUwpBj9iw3b9zAA==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(7916004)(366004)(6666004)(8936002)(33716001)(54906003)(6862004)(956004)(38100700002)(2906002)(82960400001)(6636002)(66556008)(26005)(85182001)(508600001)(186003)(5660300002)(8676002)(6486002)(6496006)(9686003)(4326008)(316002)(66946007)(86362001)(66476007);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?di90czdnQUlaUCs1a3EwMWtJZ21SOE95dlQ0SlpvbWJVMnQvQlJoSlNxRGxu?=
 =?utf-8?B?UWl5US92N21KQVI3MGhOR0k2Wk1hS0VSNTFoUHdXQndEcFE4amZuTVpWbndQ?=
 =?utf-8?B?UTljZmxiWDNxcXZwSG9KSm9vN0FqRnNvM29rVzJOb21XS3l6M3QwaFdxWHB1?=
 =?utf-8?B?a3VmK3RRZ25uVzAyVlh2MC9KVll6OTI2RGxwTGlZWURFSy9WbTFQV1gxN2lK?=
 =?utf-8?B?b1QrbWhHU0RPRzVHbG9MTU5Bdk5VeWlyWTRKUU9KRmtMT2IzMTdFWVQwbTNt?=
 =?utf-8?B?VTJiNllML3ZJY1pURlJFVG82anBWZWkzUk9KODFCbmlMelFZUTFIa3U5d3du?=
 =?utf-8?B?QjlYd2VlMW9rc0pPcEZhdFJNMjRPVldBVXhRYVA5TDFoNWtXa2FQaVp3eDhs?=
 =?utf-8?B?bFdJbk9ZUXdJdGpJajVObU1UbFB5cnZydmZhWmRGdENqc1prRE02ajJmRnJj?=
 =?utf-8?B?R1NBWmN5R21uQk1NeUJoS3grUlQ4TCttaFNYY0FGZnJRTXRSTDgwRVo3bzY5?=
 =?utf-8?B?TzdUWWUwWlM1U1cySzczWHRENkRLK1I2ZEkrVDRDMWVuWXBucW96TW5TK3Vr?=
 =?utf-8?B?R2VOYkJ5d0VlSmZ0WlRwdEpHVk1XdGNLa1cyeEw0QWluRCtkc2dRdkh4WTdt?=
 =?utf-8?B?dmhlT1pyRWw5SlBhR2hqbDdKUkpuUklRaFRodTE3blFzTVloVDZZZ0xqeXNs?=
 =?utf-8?B?WXBibGtGWUVBV1c3ZE1zamkwL2hTa09QRUJEeGczU1poUFp0QmRxTk1MY2dS?=
 =?utf-8?B?Z05rU3ZXY3kxd09YQ3JJdHBhTmdRcWJDemJFK01hbkxaSE05RVkxV1QvdTAw?=
 =?utf-8?B?K1ZnWGNMZlJvenB5Vng0YnBzMWJWd3FvLzYvTTJNQW1HSkM2eUR6L0hjRmtk?=
 =?utf-8?B?aGJVam5mR2dZMHVKdnpnMDlHT0tOMTBsc1hyUGVuNW5sMjRNNnZqQlVzK0lO?=
 =?utf-8?B?Z25TRGFySGNoQ1M4dEl3aEM0L1dwdFpGMWZrbVFieGt5bzkrSnFVaG9vWXcz?=
 =?utf-8?B?Sk5zVHJaVEZ5UGVyQlg1SFkwNmFpZk1jL0wyNTNQYml0WGRab2IvYndQV3Nw?=
 =?utf-8?B?VUNwZWRaaFR1aVVMa1djREdLV052cGhXcHgrdVh5T09nN0hWa05MY2pCMmdq?=
 =?utf-8?B?RVJOVjFoSURxcnlWbXpLclVoK0xRMFl1bnNmZTlNd3JvNkpiUUJSeWdyZ0dl?=
 =?utf-8?B?Y1RnVWxycng3V0tpZUxFbkxmLy9iekd0V0cwOVM4eHNKNHlydDdJcmRtL2k3?=
 =?utf-8?B?NEswVFVoVVV2V1FBekFiWFpSNnpZd2VGdkhhWTVVTTlkeUwxeFNaR01CSWRU?=
 =?utf-8?B?UkVOMzhPRmRaa1k2bFVtd09veC9paVFSRk9WaUhRKzZ0NDlnOVRheFRJSDlp?=
 =?utf-8?B?ZlVWZ3VnMURka2ZaTlVLWnp6NDBTK0hGUXY3L2dmcXpRWUxBTGExdjRTd1lu?=
 =?utf-8?B?ZjRLRmVPdWZieERnTlZicm56Z1JOU0poMTBybjAvN2hjNVZWdVdOMWVvR0pQ?=
 =?utf-8?B?UU8xem1YS0NKY20yTU9sWExmNlduT3BCbUlKZ2pBZlhvMFU2QnhGUVdYUHcz?=
 =?utf-8?B?U0xDaE5mY0JPUll6eHZJTmNrdXdvOXA0Y0ZRaWJDUGxQSzNZSjRMNXdqMmNI?=
 =?utf-8?B?LyttcEZ3Ni9lNFJvdXJSeS9UcjhGY0JYYmUycFpHZ1dNMkV1NSt6VDBXZ0dp?=
 =?utf-8?B?dDNwNDhwWjREL2h4SThpOXBlalpCOUNuUi9GbFR2U1laNDNtZzNsYWEyNWtZ?=
 =?utf-8?B?bUxMelVFcGRxNFdtY2pnT3VmU1dBU3hxMjkzMjlEWlZvb0d0WVBjR3JrczQ5?=
 =?utf-8?B?RWF1MFl6YVRtSXJRN3dKcUQ5eG5vdWdmdU5hbFZSc0cvUG1sTHg3OXdUdE9l?=
 =?utf-8?B?Si9XT2JnMTA4aGFnNWl2YzltbkszUVlPM1RGNlFRdHpkRERiQ1JCTVh4K2N2?=
 =?utf-8?B?eXdkNmZEMHA3cUpLQlRtRmxGZDI5bWREVEVSNEZJR0d3MGU3SHpNMkExaUxP?=
 =?utf-8?B?cys4QUg4OGNXN05rcGVLRjZPZ0JBWHFnd3ZEL1NBbVA0d2FQY2Fxa2x6cHhj?=
 =?utf-8?B?aGJ4VnhEcGpSZVpCUjZ2WnpCb1VvclptaEtsV3VvRGZ3VVYvV0JTN1E4cUJy?=
 =?utf-8?B?LzYzL3JMb0lsWWM4SlBJSUhqVUxhZ1gxTFFES3EzK2VnWnFYNlkrbGNLSHgz?=
 =?utf-8?Q?AQWKlnV2TARyi5v2TSoahag=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 01916b7c-87c4-48d0-a6b7-08d999e4f5e6
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Oct 2021 07:31:30.9003
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6q4uLdd6/b11hQZmZ5L/ccBg/CUvZDQhRqC6t+qCaqLQxnLupFXfrTCUEt3tIoOQkQp0kV4LYt4X8tNwugvHqA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB3833
X-OriginatorOrg: citrix.com

On Wed, Oct 27, 2021 at 09:07:13PM +0100, Andrew Cooper wrote:
> GCC master (nearly version 12) complains:
> 
>   hvm.c: In function 'hvm_gsi_eoi':
>   hvm.c:905:10: error: the comparison will always evaluate as 'true' for the
>   address of 'dpci' will never be NULL [-Werror=address]
>     905 |     if ( !pirq_dpci(pirq) )
>         |          ^
>   In file included from /local/xen.git/xen/include/xen/irq.h:73,
>                    from /local/xen.git/xen/include/xen/pci.h:13,
>                    from /local/xen.git/xen/include/asm/hvm/io.h:22,
>                    from /local/xen.git/xen/include/asm/hvm/domain.h:27,
>                    from /local/xen.git/xen/include/asm/domain.h:7,
>                    from /local/xen.git/xen/include/xen/domain.h:8,
>                    from /local/xen.git/xen/include/xen/sched.h:11,
>                    from /local/xen.git/xen/include/xen/event.h:12,
>                    from hvm.c:20:
>   /local/xen.git/xen/include/asm/irq.h:140:34: note: 'dpci' declared here
>     140 |             struct hvm_pirq_dpci dpci;
>         |                                  ^~~~
> 
> The location marker is unhelpfully positioned and upstream may get around to
> fixing it.  The complaint is intended to be:
> 
>   if ( !((pirq) ? &(pirq)->arch.hvm.dpci : NULL) )
>                   ^~~~~~~~~~~~~~~~~~~~~~
> 
> which is a hint that the code is should be simplified to just:
> 
>   if ( !pirq )

I likely need more coffee, but doesn't this exploit how the macro
(pirq_dpci) is currently coded?

IOW we could change how pirq_dpci is implemented and then that
relation might no longer be true. What we care in hvm_gsi_eoi is not
only having a valid pirq, but also having a valid dpci struct which
will only be the case if the PIRQ is bound to an HVM domain, and that
is what the check tries to represent.

I know this is not how pirq_dpci is currently implemented, but I don't
see why it couldn't change in the future.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Thu Oct 28 07:35:58 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Oct 2021 07:35:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217711.377849 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfzwz-0007oU-LZ; Thu, 28 Oct 2021 07:35:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217711.377849; Thu, 28 Oct 2021 07:35:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mfzwz-0007oN-Ih; Thu, 28 Oct 2021 07:35:49 +0000
Received: by outflank-mailman (input) for mailman id 217711;
 Thu, 28 Oct 2021 07:35:48 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=vfrR=PQ=suse.com=jgross@srs-us1.protection.inumbo.net>)
 id 1mfzwy-0007oH-26
 for xen-devel@lists.xenproject.org; Thu, 28 Oct 2021 07:35:48 +0000
Received: from smtp-out1.suse.de (unknown [195.135.220.28])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id cd27cd09-f6bf-4883-a04d-ec1aeff56f78;
 Thu, 28 Oct 2021 07:35:47 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 399DF2177B;
 Thu, 28 Oct 2021 07:35:46 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 7F48A13ABD;
 Thu, 28 Oct 2021 07:35:43 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id 1yyyHc9SemEoHwAAMHmgww
 (envelope-from <jgross@suse.com>); Thu, 28 Oct 2021 07:35:43 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: cd27cd09-f6bf-4883-a04d-ec1aeff56f78
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1635406546; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=6B5pmyQNFFGuA4GPECyRE5zg2HYL2//T1yApmd7nsM0=;
	b=r6yeWDlMsEfA0y5YFT2WvCIkR54aJfsk2BjD1k73An8Lpr9mBWZehdxnBWG0AsAvfvNmwI
	MnonR7NMALwwPFGOhAwXYUyYDhujPU8bNxWRam4ZnSksywP0T/oIpzAMXVbgdvII+AA6d1
	h1svOAaQoBSAgC2+n2bt/LD5oO+njA0=
Subject: Re: [PATCH v2 09/45] xen/x86: Use do_kernel_power_off()
To: Dmitry Osipenko <digetx@gmail.com>,
 Thierry Reding <thierry.reding@gmail.com>,
 Jonathan Hunter <jonathanh@nvidia.com>, Lee Jones <lee.jones@linaro.org>,
 "Rafael J . Wysocki" <rafael@kernel.org>, Mark Brown <broonie@kernel.org>,
 Andrew Morton <akpm@linux-foundation.org>, Guenter Roeck
 <linux@roeck-us.net>, Russell King <linux@armlinux.org.uk>,
 Daniel Lezcano <daniel.lezcano@linaro.org>,
 Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
 Ulf Hansson <ulf.hansson@linaro.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will@kernel.org>,
 Guo Ren <guoren@kernel.org>, Geert Uytterhoeven <geert@linux-m68k.org>,
 Greg Ungerer <gerg@linux-m68k.org>, Joshua Thompson <funaho@jurai.org>,
 Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
 Nick Hu <nickhu@andestech.com>, Greentime Hu <green.hu@gmail.com>,
 Vincent Chen <deanbo422@gmail.com>,
 "James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
 Helge Deller <deller@gmx.de>, Michael Ellerman <mpe@ellerman.id.au>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 Paul Mackerras <paulus@samba.org>, Paul Walmsley <paul.walmsley@sifive.com>,
 Palmer Dabbelt <palmer@dabbelt.com>, Albert Ou <aou@eecs.berkeley.edu>,
 Yoshinori Sato <ysato@users.sourceforge.jp>, Rich Felker <dalias@libc.org>,
 Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
 Borislav Petkov <bp@alien8.de>, Dave Hansen <dave.hansen@linux.intel.com>,
 x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
 Boris Ostrovsky <boris.ostrovsky@oracle.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Len Brown <lenb@kernel.org>,
 Santosh Shilimkar <ssantosh@kernel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
 Linus Walleij <linus.walleij@linaro.org>, Chen-Yu Tsai <wens@csie.org>,
 =?UTF-8?Q?Jonathan_Neusch=c3=a4fer?= <j.neuschaefer@gmx.net>,
 Tony Lindgren <tony@atomide.com>, Liam Girdwood <lgirdwood@gmail.com>,
 Philipp Zabel <p.zabel@pengutronix.de>, Vladimir Zapolskiy <vz@mleia.com>,
 Avi Fishman <avifishman70@gmail.com>, Tomer Maimon <tmaimon77@gmail.com>,
 Tali Perry <tali.perry1@gmail.com>, Patrick Venture <venture@google.com>,
 Nancy Yuen <yuenn@google.com>, Benjamin Fair <benjaminfair@google.com>,
 Pavel Machek <pavel@ucw.cz>, linux-arm-kernel@lists.infradead.org,
 linux-kernel@vger.kernel.org, linux-csky@vger.kernel.org,
 linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org,
 linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org,
 linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org,
 linux-sh@vger.kernel.org, xen-devel@lists.xenproject.org,
 linux-acpi@vger.kernel.org, linux-omap@vger.kernel.org,
 openbmc@lists.ozlabs.org, linux-tegra@vger.kernel.org,
 linux-pm@vger.kernel.org
References: <20211027211715.12671-1-digetx@gmail.com>
 <20211027211715.12671-10-digetx@gmail.com>
From: Juergen Gross <jgross@suse.com>
Message-ID: <0a9e42a1-c179-0d0c-99e3-f355b5db5aa1@suse.com>
Date: Thu, 28 Oct 2021 09:35:42 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <20211027211715.12671-10-digetx@gmail.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="gFqi6FeylFrTW5XaUARAuOXV5Sz4QEf7K"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--gFqi6FeylFrTW5XaUARAuOXV5Sz4QEf7K
Content-Type: multipart/mixed; boundary="s6NO7De5nnKdkPBqWk386oADRqxtp9b1f";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Dmitry Osipenko <digetx@gmail.com>,
 Thierry Reding <thierry.reding@gmail.com>,
 Jonathan Hunter <jonathanh@nvidia.com>, Lee Jones <lee.jones@linaro.org>,
 "Rafael J . Wysocki" <rafael@kernel.org>, Mark Brown <broonie@kernel.org>,
 Andrew Morton <akpm@linux-foundation.org>, Guenter Roeck
 <linux@roeck-us.net>, Russell King <linux@armlinux.org.uk>,
 Daniel Lezcano <daniel.lezcano@linaro.org>,
 Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
 Ulf Hansson <ulf.hansson@linaro.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will@kernel.org>,
 Guo Ren <guoren@kernel.org>, Geert Uytterhoeven <geert@linux-m68k.org>,
 Greg Ungerer <gerg@linux-m68k.org>, Joshua Thompson <funaho@jurai.org>,
 Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
 Nick Hu <nickhu@andestech.com>, Greentime Hu <green.hu@gmail.com>,
 Vincent Chen <deanbo422@gmail.com>,
 "James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
 Helge Deller <deller@gmx.de>, Michael Ellerman <mpe@ellerman.id.au>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 Paul Mackerras <paulus@samba.org>, Paul Walmsley <paul.walmsley@sifive.com>,
 Palmer Dabbelt <palmer@dabbelt.com>, Albert Ou <aou@eecs.berkeley.edu>,
 Yoshinori Sato <ysato@users.sourceforge.jp>, Rich Felker <dalias@libc.org>,
 Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
 Borislav Petkov <bp@alien8.de>, Dave Hansen <dave.hansen@linux.intel.com>,
 x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
 Boris Ostrovsky <boris.ostrovsky@oracle.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Len Brown <lenb@kernel.org>,
 Santosh Shilimkar <ssantosh@kernel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
 Linus Walleij <linus.walleij@linaro.org>, Chen-Yu Tsai <wens@csie.org>,
 =?UTF-8?Q?Jonathan_Neusch=c3=a4fer?= <j.neuschaefer@gmx.net>,
 Tony Lindgren <tony@atomide.com>, Liam Girdwood <lgirdwood@gmail.com>,
 Philipp Zabel <p.zabel@pengutronix.de>, Vladimir Zapolskiy <vz@mleia.com>,
 Avi Fishman <avifishman70@gmail.com>, Tomer Maimon <tmaimon77@gmail.com>,
 Tali Perry <tali.perry1@gmail.com>, Patrick Venture <venture@google.com>,
 Nancy Yuen <yuenn@google.com>, Benjamin Fair <benjaminfair@google.com>,
 Pavel Machek <pavel@ucw.cz>, linux-arm-kernel@lists.infradead.org,
 linux-kernel@vger.kernel.org, linux-csky@vger.kernel.org,
 linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org,
 linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org,
 linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org,
 linux-sh@vger.kernel.org, xen-devel@lists.xenproject.org,
 linux-acpi@vger.kernel.org, linux-omap@vger.kernel.org,
 openbmc@lists.ozlabs.org, linux-tegra@vger.kernel.org,
 linux-pm@vger.kernel.org
Message-ID: <0a9e42a1-c179-0d0c-99e3-f355b5db5aa1@suse.com>
Subject: Re: [PATCH v2 09/45] xen/x86: Use do_kernel_power_off()
References: <20211027211715.12671-1-digetx@gmail.com>
 <20211027211715.12671-10-digetx@gmail.com>
In-Reply-To: <20211027211715.12671-10-digetx@gmail.com>

--s6NO7De5nnKdkPBqWk386oADRqxtp9b1f
Content-Type: multipart/mixed;
 boundary="------------58F2BFF62DC0576B4BD13AA9"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------58F2BFF62DC0576B4BD13AA9
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 27.10.21 23:16, Dmitry Osipenko wrote:
> Kernel now supports chained power-off handlers. Use do_kernel_power_off=
()
> that invokes chained power-off handlers. It also invokes legacy
> pm_power_off() for now, which will be removed once all drivers will
> be converted to the new power-off API.
>=20
> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>

Acked-by: Juergen Gross <jgross@suse.com>


Juergen


--------------58F2BFF62DC0576B4BD13AA9
Content-Type: application/pgp-keys;
 name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Transfer-Encoding: quoted-printable
Content-Description: OpenPGP public key
Content-Disposition: attachment;
 filename="OpenPGP_0xB0DE9DD628BF132F.asc"

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy=
cWx
w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O=
f8Z
d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y=
9bf
IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq=
G7/
377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR=
3Jv
c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA=
QIe
AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT=
hpw
dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0=
MbD
1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv=
oPH
Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v=
5QL
+qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ=
2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC=
QoL
BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr=
Wf0
teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC=
/nu
AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh=
ITT
d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm=
XBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz=
80h
SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC=
AcD
AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn=
FOX
gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1=
jnD
kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0=
N51
N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l=
otu
fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1=
tqS
EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA=
hsD
BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3=
g3O
ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5=
dM7
wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5=
D+j
LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm=
V2x
AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N=
Eaw
QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW=
nHI
s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR=
wgn
BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV=
bVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk=
pEd
IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA=
QAB
wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw=
Tbe
8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1=
vJz
Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8=
VGi
wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW=
svi
uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX=
zXs
ZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------58F2BFF62DC0576B4BD13AA9--

--s6NO7De5nnKdkPBqWk386oADRqxtp9b1f--

--gFqi6FeylFrTW5XaUARAuOXV5Sz4QEf7K
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmF6Us4FAwAAAAAACgkQsN6d1ii/Ey81
RQf+O3ya1tE8Z6tv0yRGBRxJKsYIhum0plUzBYr4KjAMitS51HL7pjN2SqE+kRW8tC6fvz4MBV4Z
Bz+M8arbbC/asIjQfOQZb7/Bq5fDArNCDorqYSn/pVKT1f6Q41/74k05FMlTVVrl+SGj3w59z4uY
Lf6z5wnewjYkuZOCAGfe2tfxDRlwSaSa2FVHQWI6NNjxysvYLSr3UBBBsh09j8+adx17Q0C5vRvK
EX1Ik8bZJIw/xEyUzVkwRgpBlMmvnTyQEpLqBoXCH3VyiSymWybl0lJR43bhuZXd44FWcs7GGxnX
mwHRqP+ks0TmdWNmGx98oQFP3LVC0zx8uBRZBZBycA==
=NnyJ
-----END PGP SIGNATURE-----

--gFqi6FeylFrTW5XaUARAuOXV5Sz4QEf7K--


From xen-devel-bounces@lists.xenproject.org Thu Oct 28 08:12:56 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Oct 2021 08:12:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217723.377883 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg0WW-0004ZC-4K; Thu, 28 Oct 2021 08:12:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217723.377883; Thu, 28 Oct 2021 08:12:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg0WW-0004Z1-0c; Thu, 28 Oct 2021 08:12:32 +0000
Received: by outflank-mailman (input) for mailman id 217723;
 Thu, 28 Oct 2021 08:12:31 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=vfrR=PQ=suse.com=jgross@srs-us1.protection.inumbo.net>)
 id 1mg0WU-00041u-TR
 for xen-devel@lists.xenproject.org; Thu, 28 Oct 2021 08:12:30 +0000
Received: from smtp-out2.suse.de (unknown [195.135.220.29])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 5daee37d-a544-4438-9282-357a0ff238fd;
 Thu, 28 Oct 2021 08:12:25 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 07CF41FD4F;
 Thu, 28 Oct 2021 08:12:25 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id B678814083;
 Thu, 28 Oct 2021 08:12:24 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id CK1RK2hbemE/MQAAMHmgww
 (envelope-from <jgross@suse.com>); Thu, 28 Oct 2021 08:12:24 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5daee37d-a544-4438-9282-357a0ff238fd
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1635408745; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=dqnayNM2vGd2Nrg8Q8qI72d6PyZbBY3HiH0gFXYcd+Y=;
	b=BXb9x2kWX32ZD+ibkO+u1SI6k7/MiU42TziCvwCnK6bY2CW2BUuJTmX90k2dYpTMlzNZz/
	7i6vxJGKz8/7y1Hwj4C5OncMAvmb+xf06mYWq6vciW1LQPlr0Eic5whbcU6Kl6gEERsQQ4
	YOp9GpFxlPrjYfE4Z+5OPdo6fsWubzg=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org,
	x86@kernel.org,
	linux-kernel@vger.kernel.org
Cc: Juergen Gross <jgross@suse.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	"H. Peter Anvin" <hpa@zytor.com>
Subject: [PATCH 3/4] xen: remove highmem remnants
Date: Thu, 28 Oct 2021 10:12:20 +0200
Message-Id: <20211028081221.2475-4-jgross@suse.com>
X-Mailer: git-send-email 2.26.2
In-Reply-To: <20211028081221.2475-1-jgross@suse.com>
References: <20211028081221.2475-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

There are some references to highmem left in Xen pv specific code which
can be removed.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 arch/x86/xen/enlighten_pv.c | 7 -------
 arch/x86/xen/mmu_pv.c       | 1 -
 2 files changed, 8 deletions(-)

diff --git a/arch/x86/xen/enlighten_pv.c b/arch/x86/xen/enlighten_pv.c
index a7b7d674f500..fe19a398bc00 100644
--- a/arch/x86/xen/enlighten_pv.c
+++ b/arch/x86/xen/enlighten_pv.c
@@ -27,7 +27,6 @@
 #include <linux/export.h>
 #include <linux/mm.h>
 #include <linux/page-flags.h>
-#include <linux/highmem.h>
 #include <linux/pci.h>
 #include <linux/gfp.h>
 #include <linux/edd.h>
@@ -1245,12 +1244,6 @@ asmlinkage __visible void __init xen_start_kernel(void)
 	__supported_pte_mask &= ~_PAGE_GLOBAL;
 	__default_kernel_pte_mask &= ~_PAGE_GLOBAL;
 
-	/*
-	 * Prevent page tables from being allocated in highmem, even
-	 * if CONFIG_HIGHPTE is enabled.
-	 */
-	__userpte_alloc_gfp &= ~__GFP_HIGHMEM;
-
 	/* Get mfn list */
 	xen_build_dynamic_phys_to_machine();
 
diff --git a/arch/x86/xen/mmu_pv.c b/arch/x86/xen/mmu_pv.c
index 3359c23573c5..793870fb942a 100644
--- a/arch/x86/xen/mmu_pv.c
+++ b/arch/x86/xen/mmu_pv.c
@@ -41,7 +41,6 @@
  * Jeremy Fitzhardinge <jeremy@xensource.com>, XenSource Inc, 2007
  */
 #include <linux/sched/mm.h>
-#include <linux/highmem.h>
 #include <linux/debugfs.h>
 #include <linux/bug.h>
 #include <linux/vmalloc.h>
-- 
2.26.2



From xen-devel-bounces@lists.xenproject.org Thu Oct 28 08:12:56 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Oct 2021 08:12:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217722.377865 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg0WR-00044R-R1; Thu, 28 Oct 2021 08:12:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217722.377865; Thu, 28 Oct 2021 08:12:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg0WR-00043u-Nf; Thu, 28 Oct 2021 08:12:27 +0000
Received: by outflank-mailman (input) for mailman id 217722;
 Thu, 28 Oct 2021 08:12:26 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=vfrR=PQ=suse.com=jgross@srs-us1.protection.inumbo.net>)
 id 1mg0WQ-000420-Hl
 for xen-devel@lists.xenproject.org; Thu, 28 Oct 2021 08:12:26 +0000
Received: from smtp-out2.suse.de (unknown [195.135.220.29])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id c82b039b-37c6-11ec-849a-12813bfff9fa;
 Thu, 28 Oct 2021 08:12:25 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 523121FD4C;
 Thu, 28 Oct 2021 08:12:24 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 0BF4814083;
 Thu, 28 Oct 2021 08:12:24 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id 0BTdAWhbemE/MQAAMHmgww
 (envelope-from <jgross@suse.com>); Thu, 28 Oct 2021 08:12:24 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c82b039b-37c6-11ec-849a-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1635408744; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=cWdDMKt9ZR6fJrJlomm3JcZ8sxGTe4D9W9jT8YxWMnw=;
	b=EuCcEXH/JLcU3tuPtMKIUeyYxSTGsXxYljjToHY98i+p3XwMuqaFiCREzyeFYCGweS9rqI
	+YHRCmT9ZqgJJnWVT/jjIYMdsOS57chc9ALp35rBB4lx0XZbVGQ5dfdwDea1ng60jsFqzV
	h2/kbtg7V1Eb8DRcHhV82XPX1/s9cSc=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org,
	x86@kernel.org,
	linux-kernel@vger.kernel.org
Cc: Juergen Gross <jgross@suse.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	"H. Peter Anvin" <hpa@zytor.com>
Subject: [PATCH 1/4] x86/xen: remove 32-bit pv leftovers
Date: Thu, 28 Oct 2021 10:12:18 +0200
Message-Id: <20211028081221.2475-2-jgross@suse.com>
X-Mailer: git-send-email 2.26.2
In-Reply-To: <20211028081221.2475-1-jgross@suse.com>
References: <20211028081221.2475-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

There are some remaining 32-bit pv-guest support leftovers in the Xen
hypercall interface. Remove them.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 arch/x86/include/asm/xen/hypercall.h | 40 +++++++---------------------
 drivers/xen/mem-reservation.c        | 27 +++++++------------
 2 files changed, 19 insertions(+), 48 deletions(-)

diff --git a/arch/x86/include/asm/xen/hypercall.h b/arch/x86/include/asm/xen/hypercall.h
index 454b20815f35..02156b76aa92 100644
--- a/arch/x86/include/asm/xen/hypercall.h
+++ b/arch/x86/include/asm/xen/hypercall.h
@@ -323,9 +323,7 @@ HYPERVISOR_get_debugreg(int reg)
 static inline int
 HYPERVISOR_update_descriptor(u64 ma, u64 desc)
 {
-	if (sizeof(u64) == sizeof(long))
-		return _hypercall2(int, update_descriptor, ma, desc);
-	return _hypercall4(int, update_descriptor, ma, ma>>32, desc, desc>>32);
+	return _hypercall2(int, update_descriptor, ma, desc);
 }
 
 static inline long
@@ -344,12 +342,7 @@ static inline int
 HYPERVISOR_update_va_mapping(unsigned long va, pte_t new_val,
 			     unsigned long flags)
 {
-	if (sizeof(new_val) == sizeof(long))
-		return _hypercall3(int, update_va_mapping, va,
-				   new_val.pte, flags);
-	else
-		return _hypercall4(int, update_va_mapping, va,
-				   new_val.pte, new_val.pte >> 32, flags);
+	return _hypercall3(int, update_va_mapping, va, new_val.pte, flags);
 }
 
 static inline int
@@ -461,16 +454,10 @@ MULTI_update_va_mapping(struct multicall_entry *mcl, unsigned long va,
 {
 	mcl->op = __HYPERVISOR_update_va_mapping;
 	mcl->args[0] = va;
-	if (sizeof(new_val) == sizeof(long)) {
-		mcl->args[1] = new_val.pte;
-		mcl->args[2] = flags;
-	} else {
-		mcl->args[1] = new_val.pte;
-		mcl->args[2] = new_val.pte >> 32;
-		mcl->args[3] = flags;
-	}
+	mcl->args[1] = new_val.pte;
+	mcl->args[2] = flags;
 
-	trace_xen_mc_entry(mcl, sizeof(new_val) == sizeof(long) ? 3 : 4);
+	trace_xen_mc_entry(mcl, 3);
 }
 
 static inline void
@@ -478,19 +465,10 @@ MULTI_update_descriptor(struct multicall_entry *mcl, u64 maddr,
 			struct desc_struct desc)
 {
 	mcl->op = __HYPERVISOR_update_descriptor;
-	if (sizeof(maddr) == sizeof(long)) {
-		mcl->args[0] = maddr;
-		mcl->args[1] = *(unsigned long *)&desc;
-	} else {
-		u32 *p = (u32 *)&desc;
-
-		mcl->args[0] = maddr;
-		mcl->args[1] = maddr >> 32;
-		mcl->args[2] = *p++;
-		mcl->args[3] = *p;
-	}
-
-	trace_xen_mc_entry(mcl, sizeof(maddr) == sizeof(long) ? 2 : 4);
+	mcl->args[0] = maddr;
+	mcl->args[1] = *(unsigned long *)&desc;
+
+	trace_xen_mc_entry(mcl, 2);
 }
 
 static inline void
diff --git a/drivers/xen/mem-reservation.c b/drivers/xen/mem-reservation.c
index 3782cf070338..24648836e0d4 100644
--- a/drivers/xen/mem-reservation.c
+++ b/drivers/xen/mem-reservation.c
@@ -35,6 +35,7 @@ void __xenmem_reservation_va_mapping_update(unsigned long count,
 	for (i = 0; i < count; i++) {
 		struct page *page = pages[i];
 		unsigned long pfn = page_to_pfn(page);
+		int ret;
 
 		BUG_ON(!page);
 
@@ -46,16 +47,10 @@ void __xenmem_reservation_va_mapping_update(unsigned long count,
 
 		set_phys_to_machine(pfn, frames[i]);
 
-		/* Link back into the page tables if not highmem. */
-		if (!PageHighMem(page)) {
-			int ret;
-
-			ret = HYPERVISOR_update_va_mapping(
-					(unsigned long)__va(pfn << PAGE_SHIFT),
-					mfn_pte(frames[i], PAGE_KERNEL),
-					0);
-			BUG_ON(ret);
-		}
+		ret = HYPERVISOR_update_va_mapping(
+				(unsigned long)__va(pfn << PAGE_SHIFT),
+				mfn_pte(frames[i], PAGE_KERNEL), 0);
+		BUG_ON(ret);
 	}
 }
 EXPORT_SYMBOL_GPL(__xenmem_reservation_va_mapping_update);
@@ -68,6 +63,7 @@ void __xenmem_reservation_va_mapping_reset(unsigned long count,
 	for (i = 0; i < count; i++) {
 		struct page *page = pages[i];
 		unsigned long pfn = page_to_pfn(page);
+		int ret;
 
 		/*
 		 * We don't support PV MMU when Linux and Xen are using
@@ -75,14 +71,11 @@ void __xenmem_reservation_va_mapping_reset(unsigned long count,
 		 */
 		BUILD_BUG_ON(XEN_PAGE_SIZE != PAGE_SIZE);
 
-		if (!PageHighMem(page)) {
-			int ret;
+		ret = HYPERVISOR_update_va_mapping(
+				(unsigned long)__va(pfn << PAGE_SHIFT),
+				__pte_ma(0), 0);
+		BUG_ON(ret);
 
-			ret = HYPERVISOR_update_va_mapping(
-					(unsigned long)__va(pfn << PAGE_SHIFT),
-					__pte_ma(0), 0);
-			BUG_ON(ret);
-		}
 		__set_phys_to_machine(pfn, INVALID_P2M_ENTRY);
 	}
 }
-- 
2.26.2



From xen-devel-bounces@lists.xenproject.org Thu Oct 28 08:12:57 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Oct 2021 08:12:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217724.377894 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg0WY-0004sp-Hs; Thu, 28 Oct 2021 08:12:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217724.377894; Thu, 28 Oct 2021 08:12:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg0WY-0004sb-Dm; Thu, 28 Oct 2021 08:12:34 +0000
Received: by outflank-mailman (input) for mailman id 217724;
 Thu, 28 Oct 2021 08:12:31 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=vfrR=PQ=suse.com=jgross@srs-us1.protection.inumbo.net>)
 id 1mg0WV-000420-E4
 for xen-devel@lists.xenproject.org; Thu, 28 Oct 2021 08:12:31 +0000
Received: from smtp-out2.suse.de (unknown [195.135.220.29])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id c8ed97ca-37c6-11ec-849a-12813bfff9fa;
 Thu, 28 Oct 2021 08:12:26 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 533B81FD50;
 Thu, 28 Oct 2021 08:12:25 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 0D7CE13B7D;
 Thu, 28 Oct 2021 08:12:25 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id 6B8ZAmlbemE/MQAAMHmgww
 (envelope-from <jgross@suse.com>); Thu, 28 Oct 2021 08:12:25 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c8ed97ca-37c6-11ec-849a-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1635408745; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=Xwab1206kf6LPwimd9DqBNkl2HPMyacCxBPHJc6oauA=;
	b=lXctq1nTr/IrpFNo9dzqTLg+Mk1DHZaLUAO1sv3bfQ2soI/KtJHeCVSpvwoaVFIthWU0W7
	JK3fBD95T9sTH3Cj0cGhOQFvUtMTlplsFlS4HSWyMKrCHMfX6hpvgOsajs2KiFqgr1ce3n
	S/YBqk6nsSp6iJ9uuY1NpttjHYqYmSc=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org,
	x86@kernel.org,
	linux-kernel@vger.kernel.org
Cc: Juergen Gross <jgross@suse.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	"H. Peter Anvin" <hpa@zytor.com>
Subject: [PATCH 4/4] x86/xen: remove 32-bit awareness from startup_xen
Date: Thu, 28 Oct 2021 10:12:21 +0200
Message-Id: <20211028081221.2475-5-jgross@suse.com>
X-Mailer: git-send-email 2.26.2
In-Reply-To: <20211028081221.2475-1-jgross@suse.com>
References: <20211028081221.2475-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

startup_xen is still 32-bit aware, even if no longer needed.

Replace the register macros by the 64-bit register names for making
it more readable.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 arch/x86/xen/xen-head.S | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/arch/x86/xen/xen-head.S b/arch/x86/xen/xen-head.S
index cb6538ae2fe0..38b0a3226c95 100644
--- a/arch/x86/xen/xen-head.S
+++ b/arch/x86/xen/xen-head.S
@@ -28,13 +28,13 @@ SYM_CODE_START(startup_xen)
 
 	/* Clear .bss */
 	xor %eax,%eax
-	mov $__bss_start, %_ASM_DI
-	mov $__bss_stop, %_ASM_CX
-	sub %_ASM_DI, %_ASM_CX
-	shr $__ASM_SEL(2, 3), %_ASM_CX
-	rep __ASM_SIZE(stos)
+	mov $__bss_start, %rdi
+	mov $__bss_stop, %rcx
+	sub %rdi, %rcx
+	shr $3, %rcx
+	rep stosq
 
-	mov %_ASM_SI, xen_start_info
+	mov %rsi, xen_start_info
 	mov initial_stack(%rip), %rsp
 
 	/* Set up %gs.
-- 
2.26.2



From xen-devel-bounces@lists.xenproject.org Thu Oct 28 08:12:57 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Oct 2021 08:12:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217721.377861 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg0WR-00042D-JF; Thu, 28 Oct 2021 08:12:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217721.377861; Thu, 28 Oct 2021 08:12:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg0WR-000426-Fy; Thu, 28 Oct 2021 08:12:27 +0000
Received: by outflank-mailman (input) for mailman id 217721;
 Thu, 28 Oct 2021 08:12:26 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=vfrR=PQ=suse.com=jgross@srs-us1.protection.inumbo.net>)
 id 1mg0WQ-00041u-4A
 for xen-devel@lists.xenproject.org; Thu, 28 Oct 2021 08:12:26 +0000
Received: from smtp-out1.suse.de (unknown [195.135.220.28])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id fa1a8677-4a17-4393-b02a-b061a7bfd820;
 Thu, 28 Oct 2021 08:12:25 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 0749421969;
 Thu, 28 Oct 2021 08:12:24 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 94FC613B7D;
 Thu, 28 Oct 2021 08:12:23 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id cAz8ImdbemE/MQAAMHmgww
 (envelope-from <jgross@suse.com>); Thu, 28 Oct 2021 08:12:23 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fa1a8677-4a17-4393-b02a-b061a7bfd820
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1635408744; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:  content-transfer-encoding:content-transfer-encoding;
	bh=MAdAn9lpXksqynEY71tU+xB36Uh2pHZMgZIOmXx5QU4=;
	b=oHPcT2FRTlfOw5yijkWBtet9X2gojCMg6OeMHOToEdrwFfsTjLhzRvqSpw0D2tQG0a8pa0
	xcIGS5u++8uvD2Qxr75dbGuvqfKHVXNd/W2R1qKUMFHthtVP3ocDnuubBMr3ywbae33Rwr
	d1iPp8Gg8fKtI8iVlvKc+O1Bw939tn4=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org,
	x86@kernel.org,
	linux-kernel@vger.kernel.org
Cc: Juergen Gross <jgross@suse.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Russell King <linux@armlinux.org.uk>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/4] xen: do some cleanup
Date: Thu, 28 Oct 2021 10:12:17 +0200
Message-Id: <20211028081221.2475-1-jgross@suse.com>
X-Mailer: git-send-email 2.26.2
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Some cleanups, mostly related to no longer supporting 32-bit PV mode.

Juergen Gross (4):
  x86/xen: remove 32-bit pv leftovers
  xen: allow pv-only hypercalls only with CONFIG_XEN_PV
  xen: remove highmem remnants
  x86/xen: remove 32-bit awareness from startup_xen

 arch/arm/xen/enlighten.c             |   1 -
 arch/arm/xen/hypercall.S             |   1 -
 arch/arm64/xen/hypercall.S           |   1 -
 arch/x86/include/asm/xen/hypercall.h | 233 ++++++++++++---------------
 arch/x86/xen/enlighten_pv.c          |   7 -
 arch/x86/xen/mmu_pv.c                |   1 -
 arch/x86/xen/xen-head.S              |  12 +-
 drivers/xen/mem-reservation.c        |  27 ++--
 include/xen/arm/hypercall.h          |  15 --
 9 files changed, 118 insertions(+), 180 deletions(-)

-- 
2.26.2



From xen-devel-bounces@lists.xenproject.org Thu Oct 28 08:12:57 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Oct 2021 08:12:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217725.377905 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg0Wb-0005E8-QQ; Thu, 28 Oct 2021 08:12:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217725.377905; Thu, 28 Oct 2021 08:12:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg0Wb-0005Dt-Mx; Thu, 28 Oct 2021 08:12:37 +0000
Received: by outflank-mailman (input) for mailman id 217725;
 Thu, 28 Oct 2021 08:12:35 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=vfrR=PQ=suse.com=jgross@srs-us1.protection.inumbo.net>)
 id 1mg0WZ-00041u-Ti
 for xen-devel@lists.xenproject.org; Thu, 28 Oct 2021 08:12:35 +0000
Received: from smtp-out2.suse.de (unknown [195.135.220.29])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id eb631bc3-ad74-4c17-a4d9-b2eeb376b7cf;
 Thu, 28 Oct 2021 08:12:25 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id B15881FD4E;
 Thu, 28 Oct 2021 08:12:24 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 58B2813B7D;
 Thu, 28 Oct 2021 08:12:24 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id WOSfFGhbemE/MQAAMHmgww
 (envelope-from <jgross@suse.com>); Thu, 28 Oct 2021 08:12:24 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: eb631bc3-ad74-4c17-a4d9-b2eeb376b7cf
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1635408744; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=QksQebk1Y8FPDBoAglLu73ax8R7o9eRK4x+nsqV+elk=;
	b=lRnnR5fTPLeK40Bxibys9A9K4vacdHa60hfErHP2QMDlMAYS5tZ2OFxKFgIyzjDvyyneJq
	PtWY0wY+RlPdkWOtQlg1hLP644z5QrjQ14SBUP0M0No27CpxKyVolR4eycuZUHWyPswFvo
	pib9cppXK/qTrRCRqpBLV6HJOibwId4=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org,
	x86@kernel.org,
	linux-kernel@vger.kernel.org
Cc: Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Russell King <linux@armlinux.org.uk>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	"H. Peter Anvin" <hpa@zytor.com>,
	linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/4] xen: allow pv-only hypercalls only with CONFIG_XEN_PV
Date: Thu, 28 Oct 2021 10:12:19 +0200
Message-Id: <20211028081221.2475-3-jgross@suse.com>
X-Mailer: git-send-email 2.26.2
In-Reply-To: <20211028081221.2475-1-jgross@suse.com>
References: <20211028081221.2475-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Put the definitions of the hypercalls usable only by pv guests inside
CONFIG_XEN_PV sections.

On Arm two dummy functions related to pv hypercalls can be removed.

While at it remove the no longer supported tmem hypercall definition.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 arch/arm/xen/enlighten.c             |   1 -
 arch/arm/xen/hypercall.S             |   1 -
 arch/arm64/xen/hypercall.S           |   1 -
 arch/x86/include/asm/xen/hypercall.h | 211 +++++++++++++--------------
 include/xen/arm/hypercall.h          |  15 --
 5 files changed, 102 insertions(+), 127 deletions(-)

diff --git a/arch/arm/xen/enlighten.c b/arch/arm/xen/enlighten.c
index 7f1c106b746f..7619fbffcea2 100644
--- a/arch/arm/xen/enlighten.c
+++ b/arch/arm/xen/enlighten.c
@@ -442,7 +442,6 @@ EXPORT_SYMBOL_GPL(HYPERVISOR_hvm_op);
 EXPORT_SYMBOL_GPL(HYPERVISOR_memory_op);
 EXPORT_SYMBOL_GPL(HYPERVISOR_physdev_op);
 EXPORT_SYMBOL_GPL(HYPERVISOR_vcpu_op);
-EXPORT_SYMBOL_GPL(HYPERVISOR_tmem_op);
 EXPORT_SYMBOL_GPL(HYPERVISOR_platform_op_raw);
 EXPORT_SYMBOL_GPL(HYPERVISOR_multicall);
 EXPORT_SYMBOL_GPL(HYPERVISOR_vm_assist);
diff --git a/arch/arm/xen/hypercall.S b/arch/arm/xen/hypercall.S
index b11bba542fac..f794dac9859a 100644
--- a/arch/arm/xen/hypercall.S
+++ b/arch/arm/xen/hypercall.S
@@ -88,7 +88,6 @@ HYPERCALL2(hvm_op);
 HYPERCALL2(memory_op);
 HYPERCALL2(physdev_op);
 HYPERCALL3(vcpu_op);
-HYPERCALL1(tmem_op);
 HYPERCALL1(platform_op_raw);
 HYPERCALL2(multicall);
 HYPERCALL2(vm_assist);
diff --git a/arch/arm64/xen/hypercall.S b/arch/arm64/xen/hypercall.S
index 5b09aca55108..9d01361696a1 100644
--- a/arch/arm64/xen/hypercall.S
+++ b/arch/arm64/xen/hypercall.S
@@ -80,7 +80,6 @@ HYPERCALL2(hvm_op);
 HYPERCALL2(memory_op);
 HYPERCALL2(physdev_op);
 HYPERCALL3(vcpu_op);
-HYPERCALL1(tmem_op);
 HYPERCALL1(platform_op_raw);
 HYPERCALL2(multicall);
 HYPERCALL2(vm_assist);
diff --git a/arch/x86/include/asm/xen/hypercall.h b/arch/x86/include/asm/xen/hypercall.h
index 02156b76aa92..b4832ec1a047 100644
--- a/arch/x86/include/asm/xen/hypercall.h
+++ b/arch/x86/include/asm/xen/hypercall.h
@@ -248,6 +248,7 @@ privcmd_call(unsigned int call,
 	return res;
 }
 
+#ifdef CONFIG_XEN_PV
 static inline int
 HYPERVISOR_set_trap_table(struct trap_info *table)
 {
@@ -280,6 +281,107 @@ HYPERVISOR_callback_op(int cmd, void *arg)
 	return _hypercall2(int, callback_op, cmd, arg);
 }
 
+static inline int
+HYPERVISOR_set_debugreg(int reg, unsigned long value)
+{
+	return _hypercall2(int, set_debugreg, reg, value);
+}
+
+static inline unsigned long
+HYPERVISOR_get_debugreg(int reg)
+{
+	return _hypercall1(unsigned long, get_debugreg, reg);
+}
+
+static inline int
+HYPERVISOR_update_descriptor(u64 ma, u64 desc)
+{
+	return _hypercall2(int, update_descriptor, ma, desc);
+}
+
+static inline int
+HYPERVISOR_update_va_mapping(unsigned long va, pte_t new_val,
+			     unsigned long flags)
+{
+	return _hypercall3(int, update_va_mapping, va, new_val.pte, flags);
+}
+
+static inline int
+HYPERVISOR_set_segment_base(int reg, unsigned long value)
+{
+	return _hypercall2(int, set_segment_base, reg, value);
+}
+
+static inline void
+MULTI_fpu_taskswitch(struct multicall_entry *mcl, int set)
+{
+	mcl->op = __HYPERVISOR_fpu_taskswitch;
+	mcl->args[0] = set;
+
+	trace_xen_mc_entry(mcl, 1);
+}
+
+static inline void
+MULTI_update_va_mapping(struct multicall_entry *mcl, unsigned long va,
+			pte_t new_val, unsigned long flags)
+{
+	mcl->op = __HYPERVISOR_update_va_mapping;
+	mcl->args[0] = va;
+	mcl->args[1] = new_val.pte;
+	mcl->args[2] = flags;
+
+	trace_xen_mc_entry(mcl, 3);
+}
+
+static inline void
+MULTI_update_descriptor(struct multicall_entry *mcl, u64 maddr,
+			struct desc_struct desc)
+{
+	mcl->op = __HYPERVISOR_update_descriptor;
+	mcl->args[0] = maddr;
+	mcl->args[1] = *(unsigned long *)&desc;
+
+	trace_xen_mc_entry(mcl, 2);
+}
+
+static inline void
+MULTI_mmu_update(struct multicall_entry *mcl, struct mmu_update *req,
+		 int count, int *success_count, domid_t domid)
+{
+	mcl->op = __HYPERVISOR_mmu_update;
+	mcl->args[0] = (unsigned long)req;
+	mcl->args[1] = count;
+	mcl->args[2] = (unsigned long)success_count;
+	mcl->args[3] = domid;
+
+	trace_xen_mc_entry(mcl, 4);
+}
+
+static inline void
+MULTI_mmuext_op(struct multicall_entry *mcl, struct mmuext_op *op, int count,
+		int *success_count, domid_t domid)
+{
+	mcl->op = __HYPERVISOR_mmuext_op;
+	mcl->args[0] = (unsigned long)op;
+	mcl->args[1] = count;
+	mcl->args[2] = (unsigned long)success_count;
+	mcl->args[3] = domid;
+
+	trace_xen_mc_entry(mcl, 4);
+}
+
+static inline void
+MULTI_stack_switch(struct multicall_entry *mcl,
+		   unsigned long ss, unsigned long esp)
+{
+	mcl->op = __HYPERVISOR_stack_switch;
+	mcl->args[0] = ss;
+	mcl->args[1] = esp;
+
+	trace_xen_mc_entry(mcl, 2);
+}
+#endif
+
 static inline int
 HYPERVISOR_sched_op(int cmd, void *arg)
 {
@@ -308,24 +410,6 @@ HYPERVISOR_platform_op(struct xen_platform_op *op)
 	return _hypercall1(int, platform_op, op);
 }
 
-static inline int
-HYPERVISOR_set_debugreg(int reg, unsigned long value)
-{
-	return _hypercall2(int, set_debugreg, reg, value);
-}
-
-static inline unsigned long
-HYPERVISOR_get_debugreg(int reg)
-{
-	return _hypercall1(unsigned long, get_debugreg, reg);
-}
-
-static inline int
-HYPERVISOR_update_descriptor(u64 ma, u64 desc)
-{
-	return _hypercall2(int, update_descriptor, ma, desc);
-}
-
 static inline long
 HYPERVISOR_memory_op(unsigned int cmd, void *arg)
 {
@@ -338,13 +422,6 @@ HYPERVISOR_multicall(void *call_list, uint32_t nr_calls)
 	return _hypercall2(int, multicall, call_list, nr_calls);
 }
 
-static inline int
-HYPERVISOR_update_va_mapping(unsigned long va, pte_t new_val,
-			     unsigned long flags)
-{
-	return _hypercall3(int, update_va_mapping, va, new_val.pte, flags);
-}
-
 static inline int
 HYPERVISOR_event_channel_op(int cmd, void *arg)
 {
@@ -387,14 +464,6 @@ HYPERVISOR_vcpu_op(int cmd, int vcpuid, void *extra_args)
 	return _hypercall3(int, vcpu_op, cmd, vcpuid, extra_args);
 }
 
-#ifdef CONFIG_X86_64
-static inline int
-HYPERVISOR_set_segment_base(int reg, unsigned long value)
-{
-	return _hypercall2(int, set_segment_base, reg, value);
-}
-#endif
-
 static inline int
 HYPERVISOR_suspend(unsigned long start_info_mfn)
 {
@@ -415,13 +484,6 @@ HYPERVISOR_hvm_op(int op, void *arg)
        return _hypercall2(unsigned long, hvm_op, op, arg);
 }
 
-static inline int
-HYPERVISOR_tmem_op(
-	struct tmem_op *op)
-{
-	return _hypercall1(int, tmem_op, op);
-}
-
 static inline int
 HYPERVISOR_xenpmu_op(unsigned int op, void *arg)
 {
@@ -439,73 +501,4 @@ HYPERVISOR_dm_op(
 	return ret;
 }
 
-static inline void
-MULTI_fpu_taskswitch(struct multicall_entry *mcl, int set)
-{
-	mcl->op = __HYPERVISOR_fpu_taskswitch;
-	mcl->args[0] = set;
-
-	trace_xen_mc_entry(mcl, 1);
-}
-
-static inline void
-MULTI_update_va_mapping(struct multicall_entry *mcl, unsigned long va,
-			pte_t new_val, unsigned long flags)
-{
-	mcl->op = __HYPERVISOR_update_va_mapping;
-	mcl->args[0] = va;
-	mcl->args[1] = new_val.pte;
-	mcl->args[2] = flags;
-
-	trace_xen_mc_entry(mcl, 3);
-}
-
-static inline void
-MULTI_update_descriptor(struct multicall_entry *mcl, u64 maddr,
-			struct desc_struct desc)
-{
-	mcl->op = __HYPERVISOR_update_descriptor;
-	mcl->args[0] = maddr;
-	mcl->args[1] = *(unsigned long *)&desc;
-
-	trace_xen_mc_entry(mcl, 2);
-}
-
-static inline void
-MULTI_mmu_update(struct multicall_entry *mcl, struct mmu_update *req,
-		 int count, int *success_count, domid_t domid)
-{
-	mcl->op = __HYPERVISOR_mmu_update;
-	mcl->args[0] = (unsigned long)req;
-	mcl->args[1] = count;
-	mcl->args[2] = (unsigned long)success_count;
-	mcl->args[3] = domid;
-
-	trace_xen_mc_entry(mcl, 4);
-}
-
-static inline void
-MULTI_mmuext_op(struct multicall_entry *mcl, struct mmuext_op *op, int count,
-		int *success_count, domid_t domid)
-{
-	mcl->op = __HYPERVISOR_mmuext_op;
-	mcl->args[0] = (unsigned long)op;
-	mcl->args[1] = count;
-	mcl->args[2] = (unsigned long)success_count;
-	mcl->args[3] = domid;
-
-	trace_xen_mc_entry(mcl, 4);
-}
-
-static inline void
-MULTI_stack_switch(struct multicall_entry *mcl,
-		   unsigned long ss, unsigned long esp)
-{
-	mcl->op = __HYPERVISOR_stack_switch;
-	mcl->args[0] = ss;
-	mcl->args[1] = esp;
-
-	trace_xen_mc_entry(mcl, 2);
-}
-
 #endif /* _ASM_X86_XEN_HYPERCALL_H */
diff --git a/include/xen/arm/hypercall.h b/include/xen/arm/hypercall.h
index b40485e54d80..9d7dd1c65a21 100644
--- a/include/xen/arm/hypercall.h
+++ b/include/xen/arm/hypercall.h
@@ -53,7 +53,6 @@ unsigned long HYPERVISOR_hvm_op(int op, void *arg);
 int HYPERVISOR_memory_op(unsigned int cmd, void *arg);
 int HYPERVISOR_physdev_op(int cmd, void *arg);
 int HYPERVISOR_vcpu_op(int cmd, int vcpuid, void *extra_args);
-int HYPERVISOR_tmem_op(void *arg);
 int HYPERVISOR_vm_assist(unsigned int cmd, unsigned int type);
 int HYPERVISOR_dm_op(domid_t domid, unsigned int nr_bufs,
 		     struct xen_dm_op_buf *bufs);
@@ -74,18 +73,4 @@ HYPERVISOR_suspend(unsigned long start_info_mfn)
 	return HYPERVISOR_sched_op(SCHEDOP_shutdown, &r);
 }
 
-static inline void
-MULTI_update_va_mapping(struct multicall_entry *mcl, unsigned long va,
-			unsigned int new_val, unsigned long flags)
-{
-	BUG();
-}
-
-static inline void
-MULTI_mmu_update(struct multicall_entry *mcl, struct mmu_update *req,
-		 int count, int *success_count, domid_t domid)
-{
-	BUG();
-}
-
 #endif /* _ASM_ARM_XEN_HYPERCALL_H */
-- 
2.26.2



From xen-devel-bounces@lists.xenproject.org Thu Oct 28 09:48:52 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Oct 2021 09:48:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217758.377916 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg21M-0006oK-SF; Thu, 28 Oct 2021 09:48:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217758.377916; Thu, 28 Oct 2021 09:48:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg21M-0006oD-Oh; Thu, 28 Oct 2021 09:48:28 +0000
Received: by outflank-mailman (input) for mailman id 217758;
 Thu, 28 Oct 2021 09:48:26 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=WzT0=PQ=citrix.com=anthony.perard@srs-us1.protection.inumbo.net>)
 id 1mg21K-0006o3-Q6
 for xen-devel@lists.xenproject.org; Thu, 28 Oct 2021 09:48:26 +0000
Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 6be20bab-61d9-48c7-9ebc-9b29a977d1ae;
 Thu, 28 Oct 2021 09:48:24 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6be20bab-61d9-48c7-9ebc-9b29a977d1ae
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1635414504;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=CnFZ75dQ6xsXYjMS/S7fCNUFlHqMD2os8BP2OWgW/8E=;
  b=Q846xqrWk8XD9DQs1Wxa27ahnUIxkc0I7xqlMGbqVb7ZTZWksnYgf3NE
   mguLupj9S58C3HDhTySKvyrlnhrGny3GknNvpQUflANUBjQ0IEUI129Ha
   34XW2c3WvazbwMwxkRpZQsBR9IHF5tGk1sBQd95KxIUQ46Zj9uJVKwraa
   8=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: 8tFzC1kL3YfRIxKhIZoaS0VkzHMCMocbjjwMPSJSSBBv06NwH/OOQN+qPu03dTqlAiulAvvr/w
 z60GILbu56ZpNqLaM46b3+2Xw3LcNB8BjIfsNQEJ9kTImvki9RhQo0YYauqYbf7QdCHqNEr4yR
 yJ/Qu7UpzLTCCq4oa05Fh8+s5Fp5t3OJSjkLsPfPyc/Cbmxwq3SlaQuKk721fevrH4+iN8uOwC
 TN+aG5U4gNh7hE7QmmD247kCscoThL7LWhGB7R0O/YVLlCgvDQM0OebwFkS7m3UjGzVZrqAPYV
 WunIZRSaJ2eDjG79PEdaPtk4
X-SBRS: 5.1
X-MesageID: 58467448
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:fT3Ffqybw3MvIIp6Y0h6t+eqwSrEfRIJ4+MujC+fZmUNrF6WrkUPn
 WUeUDrTMvqIajfzKtwibd609h8FvZLWy9NhQAVvqyAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx
 59DAjUVBJlsFhcwnvopW1TYhSEUOZugH9IQM8aZfHAuLeNYYH1500s6w7Rp2tcAbeWRWGthh
 /uj+6UzB3f9s9JEGjp8B3Wr8U4HUFza4Vv0j3RmDRx5lAa2e0o9VfrzEZqZPXrgKrS4K8bhL
 wr1IBNVyUuCl/slIovNfr8W6STmSJaKVeSFoiI+t6RPHnGuD8H9u0o2HKN0VKtZt9mGt8JBm
 OUKpYXhcEQSJ6nTlb4NcxJkDBgraMWq+JefSZS+mcmazkmAeHrw2fR+SkoxOOX0+M4uXzsIr
 6ZBbmlQMFbT3Ipaw5riIgVors0lMMnsOpJZonx6xCvVJf0nXYrCU+PB4towMDIY25ASQ6mCO
 5pxhTxHcgbpQi9qPgouUMgXo8ChqCDtfj1apwfAzUYwyzeKl1EguFT3C/LUZd6iVchThlyfp
 G/N4yL+GB5yHMOb4SqI9DSrnOCntTjnVYwbErr+7eJjilCXwm0VCTUGVF+6p+n/gUm7M/pEM
 FAd8Ccqqak09WSoQ8P7Uhn+p2SL1jYXUsBcFOAS4wiXxq3ZpQ2eAwAsXjNHLdArqsIybTgrz
 UOS2cPkAyR1t7+YQm7b8a2bxQ5eIgBMczVEP3VdC1JYvZ+z++nfky4jUP5xIP6Fyc3sSAiz+
 CmOsyVkl5UYsdEygvDTEU/8vxqgoZ3ATwgQ7wrRX3644g4RWLNJd7BE+nCAsq4edNfxok2p+
 SFewZDHvb9m4YSlzXTVGI0w8KeVC+Fp2dE2qWVkGIU97HyT8nqncJE4DNpWdRoxbJhsldMEZ
 ibuVeJtCH17YCTCgUxfOdvZ5yEWIU7ITo2Nuhf8NYMmX3SJXFXblByCnGbJt4wXrGAikLskJ
 bCQetu2AHARBMxPlWTtGrxDieVwmHFumQs/oKwXKTz8iNJyg1bOEN843KamNLhlvMtoXi2Mq
 76zyPdmOz0ACbajM0E7AKYYLEwQLGhTOHwFg5c/SwJ3GSI/QDtJI6aImdsJItU594wIxrag1
 izsASdwlQug7UAr3C3XMxiPnpu0Bs0hxZ/6VARxVWuVN48LOtfysv1HLcJrLdHKNoVLlJZJc
 hXMQO3Yatwnd9gN0211gUDVoNMweRK1qxiJOib5MjEzc4Q5H17C+8P+fxup/y4LV3Llucw7q
 rym9wXaXZtcGFgyUJeIMKqinwGroHwQuONuRE+UcNNdT1rhrdpxICvrg/5pf8xVcUffxiGX3
 hq9CAsDobWfuJc89dTE3PjWr4qgH+ZkMFBdGm3XseS/OSXApzLxyo5cSueYOzvaUTqsqqmlY
 OxUydD6MeEGwwkW49YtTe4zwPtntdX1prJcwgB1J1nxbgymWuF6P32L/chTrakRlLVXjhS7B
 xCU8d5ANLTXZM68SAwNJBAoZ/io3O0PnmWA9uw8JUj36XMl/LeDVkkObRCAhDYEcelwOYIhh
 +wgpNQX+0q0jR9zaoSKiSVd9mKtKH0cUvp46sFGUdGz0gd7mEtfZZH8CzPt5MDdYtpBBUAmP
 zuIifeQnL9b3EfDLyI+GHWlMTCxXnjSVMSmFGM/Gmk=
IronPort-HdrOrdr: A9a23:+Yl2zKGA62x5gytGpLqE6MeALOsnbusQ8zAXP0AYc3Jom+ij5q
 STdZUgpHrJYVkqNU3I9ertBEDEewK6yXcX2/hyAV7BZmnbUQKTRekIh7cKgQeQeBEWntQts5
 uIGJIeNDSfNzdHsfo=
X-IronPort-AV: E=Sophos;i="5.87,189,1631592000"; 
   d="scan'208";a="58467448"
Date: Thu, 28 Oct 2021 10:48:20 +0100
From: Anthony PERARD <anthony.perard@citrix.com>
To: Stefano Stabellini <sstabellini@kernel.org>
CC: <cardoe@cardoe.com>, <xen-devel@lists.xenproject.org>,
	<iwj@xenproject.org>, <wl@xen.org>, <andrew.cooper3@citrix.com>, "Stefano
 Stabellini" <stefano.stabellini@xilinx.com>
Subject: Re: Solving the gitlab-ci git fetch issue, was: [PATCH 3/3]
 automation: add a QEMU based x86_64 Dom0/DomU test
Message-ID: <YXpx5PJwZoJQ6YIy@perard>
References: <alpine.DEB.2.21.2110210831470.2311@sstabellini-ThinkPad-T480s>
 <20211021230839.10794-3-sstabellini@kernel.org>
 <YXK2lTWZHiTXIBtJ@perard>
 <alpine.DEB.2.21.2110221219520.2311@sstabellini-ThinkPad-T480s>
 <YXbXwjxHPNjSAKrG@perard>
 <alpine.DEB.2.21.2110251754210.4586@sstabellini-ThinkPad-T480s>
 <YXlbOjiphjN/XqMz@perard>
 <alpine.DEB.2.21.2110271437120.20134@sstabellini-ThinkPad-T480s>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <alpine.DEB.2.21.2110271437120.20134@sstabellini-ThinkPad-T480s>

On Wed, Oct 27, 2021 at 02:43:46PM -0700, Stefano Stabellini wrote:
> On Wed, 27 Oct 2021, Anthony PERARD wrote:
> > > But we do have a severe problem at the moment with external sources: our
> > > "git clones" keep failing during the build on x86. That is definitely
> > > something worth improving (see my other email thread on the subject) and
> > > it is the main problem affecting gitlab-ci at the moment, I keep having
> > > to restart jobs almost daily to get the overall pipeline to "pass".
> > > 
> > > If you have any ideas on how to stop fetching things using "git" from
> > > external repositories in gitlab-ci that would be fantastic :-)
> > > The only thing I could think of to "fix it" is moving all external repos
> > > to gitlab repositories mirrors.
> > 
> > I don't think that would work, I've seen the initial clone/fetch of a
> > job fail as well, so from gitlab. If we could have a cache of those
> > external resources closer to the runners, that would be better.
> 
> You mean like a git repository mirror inside the Rackspace network (the
> provider of the x86 runner), right? Then we would force the git client
> to go to the Rackspace mirror instead of directly to the target using
> "insteadOf".

That would seems the best to me. If we could install Ian's
git-cache-proxy that is used in osstest, that would be good I think.
Having a mirror instead might work too but that would mean figure out
which repo we would need a mirror of.

I did try a different alternative a while back, I tried to use gitlab's
caching capability:
    automation: Cache sub-project git tree in build jobs
    https://lore.kernel.org/xen-devel/20191219144217.305851-3-anthony.perard@citrix.com/
It mostly works but I'm not sure how useful it is as it seems there is
10 computers that would maintain 10 different caches, and most of them
for a short while.

> Is that what you meant? Doug, do you think it would work?

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Thu Oct 28 09:53:42 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Oct 2021 09:53:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217765.377927 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg26K-0008EU-He; Thu, 28 Oct 2021 09:53:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217765.377927; Thu, 28 Oct 2021 09:53:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg26K-0008EN-CU; Thu, 28 Oct 2021 09:53:36 +0000
Received: by outflank-mailman (input) for mailman id 217765;
 Thu, 28 Oct 2021 09:53:34 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=3vD9=PQ=gmail.com=rjwysocki@srs-us1.protection.inumbo.net>)
 id 1mg26I-0008EG-8r
 for xen-devel@lists.xenproject.org; Thu, 28 Oct 2021 09:53:34 +0000
Received: from mail-ot1-f52.google.com (unknown [209.85.210.52])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id e9552aec-37d4-11ec-849b-12813bfff9fa;
 Thu, 28 Oct 2021 09:53:33 +0000 (UTC)
Received: by mail-ot1-f52.google.com with SMTP id
 l16-20020a9d6a90000000b0054e7ab56f27so7746554otq.12
 for <xen-devel@lists.xenproject.org>; Thu, 28 Oct 2021 02:53:33 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e9552aec-37d4-11ec-849b-12813bfff9fa
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=uz31be5RzrXoa4uAxe1xyKZoIQd0wtsVVy1gZjyOGeo=;
        b=X+5dvuAmn9czEBhw6oatav5UeJL0vhrLj4q9FFVTO6GKkY+w6ZdTGQelk9hohVgmIY
         Yd/PMAb9qN2fX6rpO+Fpzm+gR/kyQtBYy1xKP0BVFyiF6JMgcVJ/jonAcOKEc5RMYN84
         bVyCtxx6L18Oix7FtsZay+26Tgxusro5DRWzimEhh0BkHauB34MF0IJQ0cJdxI8ndFpk
         tT4Q+r4ixZ5Ah5FISSTxYHxCacenL8jcQmXEuNicUbvPowtwmco9S3DHl+sUlxlFu2M/
         C/l6w+xpTjC03APqBD9r6g78sDJCOGZzbBq8lQX028BB5WtVKYbius/6Y/dmsd7As+UZ
         GHEw==
X-Gm-Message-State: AOAM533cQ7hhthlSJGrjUOE6zfetNM13gK+S35NHNSw5caDZ5bIiPyb6
	6VPoubcouKlXxtTAD28NN1Ei8sZ+IjxqaC1JJZo=
X-Google-Smtp-Source: ABdhPJzOhFRTFEQQ+n5tEP/bBwTFb0889hJMVw20FWNyFAcerxAE3whFQ+5AhX1ip3T9ogNIhdu7wA8+/uN9VNCEoX8=
X-Received: by 2002:a9d:65c1:: with SMTP id z1mr2411564oth.198.1635414812552;
 Thu, 28 Oct 2021 02:53:32 -0700 (PDT)
MIME-Version: 1.0
References: <20211027211715.12671-1-digetx@gmail.com> <20211027211715.12671-9-digetx@gmail.com>
In-Reply-To: <20211027211715.12671-9-digetx@gmail.com>
From: "Rafael J. Wysocki" <rafael@kernel.org>
Date: Thu, 28 Oct 2021 11:53:20 +0200
Message-ID: <CAJZ5v0jMdSjmkswzu18LSxcNk+k92Oz5XFFXmu-h=W8aPP4Oig@mail.gmail.com>
Subject: Re: [PATCH v2 08/45] kernel: Add combined power-off+restart handler
 call chain API
To: Dmitry Osipenko <digetx@gmail.com>
Cc: Thierry Reding <thierry.reding@gmail.com>, Jonathan Hunter <jonathanh@nvidia.com>, 
	Lee Jones <lee.jones@linaro.org>, "Rafael J . Wysocki" <rafael@kernel.org>, 
	Mark Brown <broonie@kernel.org>, Andrew Morton <akpm@linux-foundation.org>, 
	Guenter Roeck <linux@roeck-us.net>, Russell King <linux@armlinux.org.uk>, 
	Daniel Lezcano <daniel.lezcano@linaro.org>, 
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>, Ulf Hansson <ulf.hansson@linaro.org>, 
	Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will@kernel.org>, Guo Ren <guoren@kernel.org>, 
	Geert Uytterhoeven <geert@linux-m68k.org>, Greg Ungerer <gerg@linux-m68k.org>, 
	Joshua Thompson <funaho@jurai.org>, Thomas Bogendoerfer <tsbogend@alpha.franken.de>, 
	Nick Hu <nickhu@andestech.com>, Greentime Hu <green.hu@gmail.com>, 
	Vincent Chen <deanbo422@gmail.com>, 
	"James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>, Helge Deller <deller@gmx.de>, 
	Michael Ellerman <mpe@ellerman.id.au>, Benjamin Herrenschmidt <benh@kernel.crashing.org>, 
	Paul Mackerras <paulus@samba.org>, Paul Walmsley <paul.walmsley@sifive.com>, 
	Palmer Dabbelt <palmer@dabbelt.com>, Albert Ou <aou@eecs.berkeley.edu>, 
	Yoshinori Sato <ysato@users.sourceforge.jp>, Rich Felker <dalias@libc.org>, 
	Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>, 
	Dave Hansen <dave.hansen@linux.intel.com>, "the arch/x86 maintainers" <x86@kernel.org>, 
	"H. Peter Anvin" <hpa@zytor.com>, Boris Ostrovsky <boris.ostrovsky@oracle.com>, 
	Juergen Gross <jgross@suse.com>, Stefano Stabellini <sstabellini@kernel.org>, Len Brown <lenb@kernel.org>, 
	Santosh Shilimkar <ssantosh@kernel.org>, 
	Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>, 
	Linus Walleij <linus.walleij@linaro.org>, Chen-Yu Tsai <wens@csie.org>, 
	=?UTF-8?Q?Jonathan_Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>, 
	Tony Lindgren <tony@atomide.com>, Liam Girdwood <lgirdwood@gmail.com>, 
	Philipp Zabel <p.zabel@pengutronix.de>, Vladimir Zapolskiy <vz@mleia.com>, 
	Avi Fishman <avifishman70@gmail.com>, Tomer Maimon <tmaimon77@gmail.com>, 
	Tali Perry <tali.perry1@gmail.com>, Patrick Venture <venture@google.com>, 
	Nancy Yuen <yuenn@google.com>, Benjamin Fair <benjaminfair@google.com>, Pavel Machek <pavel@ucw.cz>, 
	Linux ARM <linux-arm-kernel@lists.infradead.org>, 
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, linux-csky@vger.kernel.org, 
	linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, 
	linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, 
	linuxppc-dev <linuxppc-dev@lists.ozlabs.org>, linux-riscv@lists.infradead.org, 
	Linux-sh list <linux-sh@vger.kernel.org>, xen-devel@lists.xenproject.org, 
	ACPI Devel Maling List <linux-acpi@vger.kernel.org>, 
	Linux OMAP Mailing List <linux-omap@vger.kernel.org>, openbmc@lists.ozlabs.org, 
	linux-tegra <linux-tegra@vger.kernel.org>, Linux PM <linux-pm@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"

On Wed, Oct 27, 2021 at 11:18 PM Dmitry Osipenko <digetx@gmail.com> wrote:
>
> SoC platforms often have multiple options of how to perform system's
> power-off and restart operations. Meanwhile today's kernel is limited to
> a single option. Add combined power-off+restart handler call chain API,
> which is inspired by the restart API. The new API provides both power-off
> and restart functionality.
>
> The old pm_power_off method will be kept around till all users are
> converted to the new API.
>
> Current restart API will be replaced by the new unified API since
> new API is its superset. The restart functionality of the power-handler
> API is built upon the existing restart-notifier APIs.
>
> In order to ease conversion to the new API, convenient helpers are added
> for the common use-cases. They will reduce amount of boilerplate code and
> remove global variables. These helpers preserve old behaviour for cases
> where only one power-off handler is executed, this is what existing
> drivers want, and thus, they could be easily converted to the new API.
> Users of the new API should explicitly enable power-off chaining by
> setting corresponding flag of the power_handler structure.
>
> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
> ---
>  include/linux/reboot.h   | 176 +++++++++++-
>  kernel/power/hibernate.c |   2 +-
>  kernel/reboot.c          | 601 ++++++++++++++++++++++++++++++++++++++-
>  3 files changed, 768 insertions(+), 11 deletions(-)
>
> diff --git a/include/linux/reboot.h b/include/linux/reboot.h
> index b7fa25726323..0ec835338c27 100644
> --- a/include/linux/reboot.h
> +++ b/include/linux/reboot.h
> @@ -8,10 +8,16 @@
>
>  struct device;
>
> -#define SYS_DOWN       0x0001  /* Notify of system down */
> -#define SYS_RESTART    SYS_DOWN
> -#define SYS_HALT       0x0002  /* Notify of system halt */
> -#define SYS_POWER_OFF  0x0003  /* Notify of system power off */
> +enum reboot_prepare_mode {
> +       SYS_DOWN = 1,           /* Notify of system down */
> +       SYS_RESTART = SYS_DOWN,
> +       SYS_HALT,               /* Notify of system halt */
> +       SYS_POWER_OFF,          /* Notify of system power off */
> +};
> +
> +#define RESTART_PRIO_RESERVED          0
> +#define RESTART_PRIO_DEFAULT           128
> +#define RESTART_PRIO_HIGH              192
>
>  enum reboot_mode {
>         REBOOT_UNDEFINED = -1,
> @@ -49,6 +55,167 @@ int register_restart_handler(struct notifier_block *);
>  int unregister_restart_handler(struct notifier_block *);
>  void do_kernel_restart(char *cmd);
>
> +/*
> + * Unified poweroff + restart API.
> + */
> +
> +#define POWEROFF_PRIO_RESERVED         0
> +#define POWEROFF_PRIO_PLATFORM         1
> +#define POWEROFF_PRIO_DEFAULT          128
> +#define POWEROFF_PRIO_HIGH             192
> +#define POWEROFF_PRIO_FIRMWARE         224
> +
> +enum poweroff_mode {
> +       POWEROFF_NORMAL = 0,
> +       POWEROFF_PREPARE,
> +};
> +
> +struct power_off_data {
> +       void *cb_data;
> +};
> +
> +struct power_off_prep_data {
> +       void *cb_data;
> +};
> +
> +struct restart_data {
> +       void *cb_data;
> +       const char *cmd;
> +       enum reboot_mode mode;
> +};
> +
> +struct reboot_prep_data {
> +       void *cb_data;
> +       const char *cmd;
> +       enum reboot_prepare_mode mode;
> +};
> +
> +struct power_handler_private_data {
> +       struct notifier_block reboot_prep_nb;
> +       struct notifier_block power_off_nb;
> +       struct notifier_block restart_nb;
> +       void (*trivial_power_off_cb)(void);
> +       void (*simple_power_off_cb)(void *data);
> +       void *simple_power_off_cb_data;
> +       bool registered;
> +};
> +
> +/**
> + * struct power_handler - Machine power-off + restart handler
> + *
> + * Describes power-off and restart handlers which are invoked by kernel
> + * to power off or restart this machine.  Supports prioritized chaining for
> + * both restart and power-off handlers.  Callback's priority must be unique.
> + * Intended to be used by device drivers that are responsible for restarting
> + * and powering off hardware which kernel is running on.
> + *
> + * Struct power_handler can be static.  Members of this structure must not be
> + * altered while handler is registered.
> + *
> + * Fill the structure members and pass it to register_power_handler().
> + */
> +struct power_handler {

The name of this structure is too generic IMV.  There are many things
that it might apply to in principle.

What about calling power_off_handler or sys_off_handler as it need not
be about power at all?


From xen-devel-bounces@lists.xenproject.org Thu Oct 28 09:59:42 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Oct 2021 09:59:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217774.377938 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg2C5-0000aW-AA; Thu, 28 Oct 2021 09:59:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217774.377938; Thu, 28 Oct 2021 09:59:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg2C5-0000aP-6C; Thu, 28 Oct 2021 09:59:33 +0000
Received: by outflank-mailman (input) for mailman id 217774;
 Thu, 28 Oct 2021 09:59:32 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=3vD9=PQ=gmail.com=rjwysocki@srs-us1.protection.inumbo.net>)
 id 1mg2C4-0000aJ-Ey
 for xen-devel@lists.xenproject.org; Thu, 28 Oct 2021 09:59:32 +0000
Received: from mail-ot1-f47.google.com (unknown [209.85.210.47])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id bee3b0c0-37d5-11ec-849b-12813bfff9fa;
 Thu, 28 Oct 2021 09:59:31 +0000 (UTC)
Received: by mail-ot1-f47.google.com with SMTP id
 v2-20020a05683018c200b0054e3acddd91so7801421ote.8
 for <xen-devel@lists.xenproject.org>; Thu, 28 Oct 2021 02:59:31 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: bee3b0c0-37d5-11ec-849b-12813bfff9fa
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=YApfc+rtORQHprN7aKpnZNhl8TPl/VtOJQI8beQJmCY=;
        b=LAm2gKCwm1SkWg5dM9bC0xZ2RyIBWOvX2+7d2iOMfn0lEopdx5kywBvUFB4l74IJli
         RtCo+7BEltzjHoQkbrzpcBh7RbgN68HWD9nz/lH3lKRJzCzoPwzy2TBhFYd/LIYwsu/X
         ywP7HPrMmixKhiKj9q8EONTc+Fwn0EuMevfrM0p0E7QdUzl6sIYJlJjBPZb4IL5SLOqp
         +n9m/AQChd6KO2Hca1nIo1XegNjIn15KwwhweDUd0QmqQIvMVEy0GYRrufpwW+m8KYN4
         JqshFGuHcR2EwgvA/H/IC4IYW7L0wx97RGoY3WWfXduevCIDLmH/PqLgP3zOUQJPBvBO
         M/nA==
X-Gm-Message-State: AOAM533c8ZqXnNGn6Nwgb9IcF6Deh4dGkjN98kmkgZpCMaUpJy4TmBLV
	nQ4I4jUEbAvKD6zv8tIn9IB41EVMlV75SAjVPJU=
X-Google-Smtp-Source: ABdhPJzD4cm7tn60vkyopY5CUMxUc9huwAUhS0IgxTyGcJq7Km0Bm+8fuUNsdZomFIBYzzQsRecVralPmU+TS+34zNY=
X-Received: by 2002:a9d:65c1:: with SMTP id z1mr2427957oth.198.1635415170827;
 Thu, 28 Oct 2021 02:59:30 -0700 (PDT)
MIME-Version: 1.0
References: <20211027211715.12671-1-digetx@gmail.com> <20211027211715.12671-9-digetx@gmail.com>
In-Reply-To: <20211027211715.12671-9-digetx@gmail.com>
From: "Rafael J. Wysocki" <rafael@kernel.org>
Date: Thu, 28 Oct 2021 11:59:18 +0200
Message-ID: <CAJZ5v0gpu2ezMhWr=grg6M8aWAx58DQozbXHoZaiPqUaZxJi4Q@mail.gmail.com>
Subject: Re: [PATCH v2 08/45] kernel: Add combined power-off+restart handler
 call chain API
To: Dmitry Osipenko <digetx@gmail.com>
Cc: Thierry Reding <thierry.reding@gmail.com>, Jonathan Hunter <jonathanh@nvidia.com>, 
	Lee Jones <lee.jones@linaro.org>, "Rafael J . Wysocki" <rafael@kernel.org>, 
	Mark Brown <broonie@kernel.org>, Andrew Morton <akpm@linux-foundation.org>, 
	Guenter Roeck <linux@roeck-us.net>, Russell King <linux@armlinux.org.uk>, 
	Daniel Lezcano <daniel.lezcano@linaro.org>, 
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>, Ulf Hansson <ulf.hansson@linaro.org>, 
	Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will@kernel.org>, Guo Ren <guoren@kernel.org>, 
	Geert Uytterhoeven <geert@linux-m68k.org>, Greg Ungerer <gerg@linux-m68k.org>, 
	Joshua Thompson <funaho@jurai.org>, Thomas Bogendoerfer <tsbogend@alpha.franken.de>, 
	Greentime Hu <green.hu@gmail.com>, Vincent Chen <deanbo422@gmail.com>, 
	"James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>, Helge Deller <deller@gmx.de>, 
	Michael Ellerman <mpe@ellerman.id.au>, Benjamin Herrenschmidt <benh@kernel.crashing.org>, 
	Paul Mackerras <paulus@samba.org>, Paul Walmsley <paul.walmsley@sifive.com>, 
	Palmer Dabbelt <palmer@dabbelt.com>, Albert Ou <aou@eecs.berkeley.edu>, 
	Yoshinori Sato <ysato@users.sourceforge.jp>, Rich Felker <dalias@libc.org>, 
	Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>, 
	Dave Hansen <dave.hansen@linux.intel.com>, "the arch/x86 maintainers" <x86@kernel.org>, 
	"H. Peter Anvin" <hpa@zytor.com>, Boris Ostrovsky <boris.ostrovsky@oracle.com>, 
	Juergen Gross <jgross@suse.com>, Stefano Stabellini <sstabellini@kernel.org>, Len Brown <lenb@kernel.org>, 
	Santosh Shilimkar <ssantosh@kernel.org>, 
	Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>, 
	Linus Walleij <linus.walleij@linaro.org>, Chen-Yu Tsai <wens@csie.org>, 
	=?UTF-8?Q?Jonathan_Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>, 
	Tony Lindgren <tony@atomide.com>, Liam Girdwood <lgirdwood@gmail.com>, 
	Philipp Zabel <p.zabel@pengutronix.de>, Vladimir Zapolskiy <vz@mleia.com>, 
	Avi Fishman <avifishman70@gmail.com>, Tomer Maimon <tmaimon77@gmail.com>, 
	Tali Perry <tali.perry1@gmail.com>, Patrick Venture <venture@google.com>, 
	Nancy Yuen <yuenn@google.com>, Benjamin Fair <benjaminfair@google.com>, Pavel Machek <pavel@ucw.cz>, 
	Linux ARM <linux-arm-kernel@lists.infradead.org>, 
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, linux-csky@vger.kernel.org, 
	linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, 
	linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, 
	linuxppc-dev <linuxppc-dev@lists.ozlabs.org>, linux-riscv@lists.infradead.org, 
	Linux-sh list <linux-sh@vger.kernel.org>, xen-devel@lists.xenproject.org, 
	ACPI Devel Maling List <linux-acpi@vger.kernel.org>, 
	Linux OMAP Mailing List <linux-omap@vger.kernel.org>, openbmc@lists.ozlabs.org, 
	linux-tegra <linux-tegra@vger.kernel.org>, Linux PM <linux-pm@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"

On Wed, Oct 27, 2021 at 11:18 PM Dmitry Osipenko <digetx@gmail.com> wrote:
>
> SoC platforms often have multiple options of how to perform system's
> power-off and restart operations. Meanwhile today's kernel is limited to
> a single option. Add combined power-off+restart handler call chain API,
> which is inspired by the restart API. The new API provides both power-off
> and restart functionality.
>
> The old pm_power_off method will be kept around till all users are
> converted to the new API.
>
> Current restart API will be replaced by the new unified API since
> new API is its superset. The restart functionality of the power-handler
> API is built upon the existing restart-notifier APIs.
>
> In order to ease conversion to the new API, convenient helpers are added
> for the common use-cases. They will reduce amount of boilerplate code and
> remove global variables. These helpers preserve old behaviour for cases
> where only one power-off handler is executed, this is what existing
> drivers want, and thus, they could be easily converted to the new API.
> Users of the new API should explicitly enable power-off chaining by
> setting corresponding flag of the power_handler structure.
>
> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
> ---
>  include/linux/reboot.h   | 176 +++++++++++-
>  kernel/power/hibernate.c |   2 +-
>  kernel/reboot.c          | 601 ++++++++++++++++++++++++++++++++++++++-
>  3 files changed, 768 insertions(+), 11 deletions(-)
>
> diff --git a/include/linux/reboot.h b/include/linux/reboot.h
> index b7fa25726323..0ec835338c27 100644
> --- a/include/linux/reboot.h
> +++ b/include/linux/reboot.h
> @@ -8,10 +8,16 @@
>
>  struct device;
>
> -#define SYS_DOWN       0x0001  /* Notify of system down */
> -#define SYS_RESTART    SYS_DOWN
> -#define SYS_HALT       0x0002  /* Notify of system halt */
> -#define SYS_POWER_OFF  0x0003  /* Notify of system power off */
> +enum reboot_prepare_mode {
> +       SYS_DOWN = 1,           /* Notify of system down */
> +       SYS_RESTART = SYS_DOWN,
> +       SYS_HALT,               /* Notify of system halt */
> +       SYS_POWER_OFF,          /* Notify of system power off */
> +};
> +
> +#define RESTART_PRIO_RESERVED          0
> +#define RESTART_PRIO_DEFAULT           128
> +#define RESTART_PRIO_HIGH              192
>
>  enum reboot_mode {
>         REBOOT_UNDEFINED = -1,
> @@ -49,6 +55,167 @@ int register_restart_handler(struct notifier_block *);
>  int unregister_restart_handler(struct notifier_block *);
>  void do_kernel_restart(char *cmd);
>
> +/*
> + * Unified poweroff + restart API.
> + */
> +
> +#define POWEROFF_PRIO_RESERVED         0
> +#define POWEROFF_PRIO_PLATFORM         1
> +#define POWEROFF_PRIO_DEFAULT          128
> +#define POWEROFF_PRIO_HIGH             192
> +#define POWEROFF_PRIO_FIRMWARE         224

Also I'm wondering why these particular numbers were chosen, here and above?

> +
> +enum poweroff_mode {
> +       POWEROFF_NORMAL = 0,
> +       POWEROFF_PREPARE,
> +};
> +
> +struct power_off_data {
> +       void *cb_data;
> +};
> +
> +struct power_off_prep_data {
> +       void *cb_data;
> +};
> +
> +struct restart_data {
> +       void *cb_data;
> +       const char *cmd;
> +       enum reboot_mode mode;
> +};
> +
> +struct reboot_prep_data {
> +       void *cb_data;
> +       const char *cmd;
> +       enum reboot_prepare_mode mode;
> +};
> +
> +struct power_handler_private_data {
> +       struct notifier_block reboot_prep_nb;
> +       struct notifier_block power_off_nb;
> +       struct notifier_block restart_nb;
> +       void (*trivial_power_off_cb)(void);
> +       void (*simple_power_off_cb)(void *data);
> +       void *simple_power_off_cb_data;
> +       bool registered;
> +};
> +
> +/**
> + * struct power_handler - Machine power-off + restart handler
> + *
> + * Describes power-off and restart handlers which are invoked by kernel
> + * to power off or restart this machine.  Supports prioritized chaining for
> + * both restart and power-off handlers.  Callback's priority must be unique.
> + * Intended to be used by device drivers that are responsible for restarting
> + * and powering off hardware which kernel is running on.
> + *
> + * Struct power_handler can be static.  Members of this structure must not be
> + * altered while handler is registered.
> + *
> + * Fill the structure members and pass it to register_power_handler().
> + */
> +struct power_handler {
> +       /**
> +        * @cb_data:
> +        *
> +        * User data included in callback's argument.
> +        */

And here I would document the structure fields in the main kerneldoc
comment above.

As is, it is a bit hard to grasp the whole definition.

> +       void *cb_data;
> +
> +       /**
> +        * @power_off_cb:
> +        *
> +        * Callback that should turn off machine.  Inactive if NULL.
> +        */
> +       void (*power_off_cb)(struct power_off_data *data);
> +
> +       /**
> +        * @power_off_prepare_cb:
> +        *
> +        * Power-off preparation callback.  All power-off preparation callbacks
> +        * are invoked before @restart_cb.  Inactive if NULL.
> +        */
> +       void (*power_off_prepare_cb)(struct power_off_prep_data *data);
> +
> +       /**
> +        * @power_off_priority:
> +        *
> +        * Power-off callback priority, must be unique.  Zero value is
> +        * reassigned to default priority.  Inactive if @power_off_cb is NULL.
> +        */
> +       int power_off_priority;
> +
> +       /**
> +        * @power_off_chaining_allowed:
> +        *
> +        * False if callbacks execution should stop when @power_off_cb fails
> +        * to power off machine.  True if further lower priority power-off
> +        * callback should be executed.
> +        */
> +       bool power_off_chaining_allowed;
> +
> +       /**
> +        * @restart_cb:
> +        *
> +        * Callback that should reboot machine.  Inactive if NULL.
> +        */
> +       void (*restart_cb)(struct restart_data *data);
> +
> +       /**
> +        * @restart_priority:
> +        *
> +        * Restart callback priority, must be unique.  Zero value is reassigned
> +        * to default priority.  Inactive if @restart_cb is NULL.
> +        */
> +       int restart_priority;
> +
> +       /**
> +        * @reboot_prepare_cb:
> +        *
> +        * Reboot preparation callback.  All reboot preparation callbacks are
> +        * invoked before @restart_cb.  Inactive if NULL.
> +        */
> +       void (*reboot_prepare_cb)(struct reboot_prep_data *data);
> +
> +       /**
> +        * @priv:
> +        *
> +        * Internal data.  Shouldn't be touched.
> +        */
> +       const struct power_handler_private_data priv;
> +};


From xen-devel-bounces@lists.xenproject.org Thu Oct 28 09:59:43 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Oct 2021 09:59:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217775.377949 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg2CF-0000uN-HA; Thu, 28 Oct 2021 09:59:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217775.377949; Thu, 28 Oct 2021 09:59:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg2CF-0000uG-Dd; Thu, 28 Oct 2021 09:59:43 +0000
Received: by outflank-mailman (input) for mailman id 217775;
 Thu, 28 Oct 2021 09:59:42 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=8Bw3=PQ=citrix.com=roger.pau@srs-us1.protection.inumbo.net>)
 id 1mg2CE-0000tf-DU
 for xen-devel@lists.xenproject.org; Thu, 28 Oct 2021 09:59:42 +0000
Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id c417c0ae-37d5-11ec-849b-12813bfff9fa;
 Thu, 28 Oct 2021 09:59:40 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c417c0ae-37d5-11ec-849b-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1635415180;
  h=from:to:cc:subject:date:message-id:
   content-transfer-encoding:mime-version;
  bh=Oakwnb+RPivWdNAOZIgYSBn91hjpiphbOOddHwVVxoo=;
  b=envJ9MZH3njPIjZn9wA/WlMDzpNU6SJyRt4S+Fusw83nLnp+KyikrKXM
   3LML3FBYU3CdQ+OE+CMrL7/iG3s3r4j6iwFqVoN/wmPX0i6W59arDykR9
   BRYXbqf4bNzjbjpg6P9GT/qyNWrykI52yNV2cNFWiLG0FCgUzi6jOx+D7
   U=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: 2hZx6HcgrQQ2VYb/0jIODLzmNxKZ/n9FlrEmbLzrJ7oNbUvO0j42H+DaYZajC50OF2dln9fgcS
 tiYgTREcg06IQmeVlfmoxamtVPo1eWWeQvK1kl+9D2sTlq6wfbLnq8Aj/IXIWXLJel4pAVRNH/
 Dums//5TgfaSaFGSCoax8zHLuDO1sk7FEOMNdwjV5W+ND0Gk5Y/Byrm3AGwmHFgl6hVIj8n8/Y
 YyA6HAxH6lrzYnxJNVD27w3YPe89AxHLaZ1sri+ItqAISSs91Obs8sao6MGB33zOpDZFKtjtiL
 /EkKsmHbXfxW/F+0pw72CHQs
X-SBRS: 5.1
X-MesageID: 56533758
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:H45Jr6p9LN54EIrVWcVh7LbtrGVeBmJEYxIvgKrLsJaIsI4StFCzt
 garIBmPP/ncMGanftF0PIu3px8DuZSGm4UxHlQ4qS48FyIS+JuZCYyVIHmrMnLJJKUvbq7GA
 +byyDXkBJppJpMJjk71atANlZT4vE2xbuKU5NTsY0idfic5Dnd+4f5fs7Rh2Ncx2YLpW1rlV
 e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL
 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9
 DlCnZqPdS4IILHOo/QifhBKEwxfO/152KCSdBBTseTLp6HHW37lwvEoB0AqJ4wIvO1wBAmi9
 9RBdmpLNErawbvrnvTrEYGAhex6RCXvFJkYtXx6iynQEN4tQIzZQrWM7thdtNs1rp0QQK2FO
 JdJAdZpRCzeb0VOA3A0NLw3t9z3oynvVzRVi3vA8MLb5ECMlVcsgdABKuH9dtWUSO1Pk02fp
 2aA+H72ajkYO8aY0iGt6W+3i6nEmiaTcIMNFpWo+/hymlqRy2cPThoMWjOTn/69jUKvXsNFH
 GYd8CEusKsa+VSiS5/2WBjQiGWfohcWVt5UEus7wAKA0KzZ50CeHGdsZiFFQMwrsokxXzNC/
 k+EmZblCCJitJWRSGmB7fGEoDWqIy8XIGQeIygeQmMt4cTnoYw1pgLCSJBkCqHdpt//FCz0w
 juKhDMjnLhVhskOv5hX5nie3Wjq/MKQCFdouEOHBQpJ8z+VeqajWLCByEbH781QE6uQXFmsn
 X5UpOiBubVm4Y62qASBR+AEHbeM7vmDMSHBjVMHI6TN5whB6Fb4ItgOuGAWyFNBd59eI2ewM
 RC7VRZ5vccLZBOXgblLj5Vd4ijA5ZPrEsj5TbjqZ95Kb4kZmOSvrXw2OxD4M4wAliERfUAD1
 XWzLZnE4ZUyU/0PIN+KqwE1iuZDKscWnjq7eHwD5077uYdynVbMIVv/DHOAb/oi8ISPqxjP/
 tBUOqOikksEDbagOnOMr99DcTjmyETX47it8qS7kcbYe2Jb9JwJUaeNkdvNhaQ8x8y5adskD
 lniAxQFmTITdFXMKBmQa2ALVV8cdc0XkJ7PBgR1ZQzA8yF6Oe6Htf5DH7NqLehP3LEylpZcE
 qhaE/hs99wSE1wrDRxGNsKjxGGjHTz27T+z092NO2liIcQ4HVWVqrcJvGLHrUEzM8Z+juNny
 5WI3QLHW5sTAQNkCcfdcvW0yF2t+3ManYpPs4Hge7G/oW3gr9pnLTLflPgyL51eIBnP3GLCh
 Q2XHQ0Zta/GpIpsqIvFgqWNroGIFepiHxUFQzmHvOjubSSKrHC+xYJgUfqTeWyPXm3D56j/N
 /5eyOvxMaNbkQ8S4ZZ8Cbti0Yk3+8Dr++1B1g1hEXiSNwarB7psL2Oox85KsqERlLZVtRHvA
 hCE+8VAOKXPM8TgSQZDKA0gZ+WF9PcVhjiNsqhlfBSkvHd6pePVX19TMh+AjD1mAIF0aI51k
 /08vMM26hCkjkZ4ONixkS0JpX+HKWYNUvt7u8hCUpPrkAci1npLfYfYVn3t+JiKZthBbhsqL
 zuTiPaQjrhQ3BOfIX86FHyL1utBn5Ue/htNyQZadViOn9PEgN4x3QFQrmtrHlgEkE0f3rIhI
 HVvOm10Ob6KrmVhi8V0VmyxHx1MWU+C8UvrxlpVzGDUQiFEjIAWwLHR7QpVwH0kzg==
IronPort-HdrOrdr: A9a23:xkVtcKCyzU78SrblHehCsceALOsnbusQ8zAXPh9KJiC9I/b1qy
 nxppkmPH/P6Qr4WBkb6LS90c67MAnhHP9OkPIs1NKZMjUO11HYSr2KgbGSoQEIeBeOidK1t5
 0QCpSWYeeYZTMR7beYkXeF+r4bsaW6GcuT9IDjJhlWPGRXg/YK1XYFNu/XKDw/eCB2Qb4CUL
 aM7MtOoDStPVwRc8SAH3EAG8zOvcfCmp7KaQMPQ0dP0njFsRqYrJrBVzSI1BYXVD1ChZ8k7G
 j+igT8ooGuqeuyxBPw33Laq75WhNzi4N1eA9HksLlfFhzcziKTIKhxUbyLuz445Mmp9VYRid
 HJ5ywtOsxigkmhCV2dkF/I4U3NwTwu43jtxRuzmn34u/H0Qzo8Fo5omZ9ZWgGx0TtugPhMlI
 Zwm06JvZteCh3N2A7n4cLTah1snk2o5VI/jO8oiWBFW4d2Us4ckWUmxjIVLH48JlO71Gh+e9
 MeT/00pcwmPG9yVkqp8FWGm7eXLzYO9hTveDl3hiXa6UkSoJlD9Tpp+CUopAZ0yHsMceg02w
 36CNUaqFg3dL5vUUtcPpZ2fSLlMB2FffrzWFjiU2gPUpt3f07wlw==
X-IronPort-AV: E=Sophos;i="5.87,189,1631592000"; 
   d="scan'208";a="56533758"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Nz2ypRxzM9/7Q8pWQ8LPzDXDRpRLR936OQxNeG4ENOUwt421u9g2Xxbz2SG1t6MpYeF7qWr1PYgKxLK/tLXkW3bT5Zihx9aijioCm3lwVVfMWXNzoyUY2JanThnW/WNHqND4g8mzoWd8P8pVyrNvYGgZzZK5C242Uw7OUOO/EzqNhJ1LYmp0w97onhLTqg9W5kRfEB+Hntli+GhPkVenXHAzN8myPNUUhFP1+XI2d0wlqh8U2JDlH96ssZh7YJqcnCf8C0PFM06xCDYQUKvLPz6K6uGP1gUiya0op6Hhn+Mjxr+7/vdcsAnPKQVJYGMrc4+gybGHQP5wHH6pm6oe3A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=3/YcNgYIYDZGbkmto+fXyzD3LJW/4JR+QhvZmPSgIso=;
 b=dUKoxFdZYD1R+dfdayIJbakKv7q1OuNZ2QXAIb4fzbybKV/RPswKks8yE+2AWGZ3P45hMAWjQkD90PJr3uO0Bj9qefSgczM2ZKDQX2ed0w+HSvZIXhqJ6xGTQEo8cbEhBQvl/sLDAherkK93nFwInvvnSNmQK/AtF3eFxv0AA+ID5Zcy6Bv8a1pAF8EJgKBkHW0bqIbfXhZ2D13lMx0qBXyoCvoMJaeUX6ipJ3T22tM4EG0Z9IjUISaN59Q97XztyjHD7QORA58Vbyp87VDu+j5jAK9uOER1Cuu2ITZFnQlwQdp9adornzBZkQVp0CwFsFb5N15yT3M6Zcl+24fcVQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=3/YcNgYIYDZGbkmto+fXyzD3LJW/4JR+QhvZmPSgIso=;
 b=GvqivnPn7cUCI6M+0FHkfGIZRHAemCyfaWyePYsrCwzurD2DQNCjiwdOfCP3QmQueSonmIHrI8T0Wk48X36aLNzJhxbV3ATH2egocU/4aIqMzt9j8lBqYNakPuBj537MIPpL/fAtbEhlH82itC32g5adiNK48pY7nAmYyVWneBI=
From: Roger Pau Monne <roger.pau@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Roger Pau Monne <roger.pau@citrix.com>, Wei Liu <wl@xen.org>, Andrew
 Cooper <andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>, Stefano
 Stabellini <sstabellini@kernel.org>, Anthony PERARD
	<anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>, Christian
 Lindig <christian.lindig@citrix.com>, David Scott <dave@recoil.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, Ian Jackson
	<iwj@xenproject.org>
Subject: [PATCH for-4.16 v3] gnttab: allow setting max version per-domain
Date: Thu, 28 Oct 2021 11:59:23 +0200
Message-ID: <20211028095923.83982-1-roger.pau@citrix.com>
X-Mailer: git-send-email 2.33.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: MR1P264CA0087.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:501:3f::25) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: edbfdef5-9da1-41d8-aaf2-08d999f9a302
X-MS-TrafficTypeDiagnostic: DM5PR03MB3289:
X-Microsoft-Antispam-PRVS: <DM5PR03MB3289806746CB7F07FAFD12AB8F869@DM5PR03MB3289.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6430;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: EK6ZOYrCts/r2w83TI+eyt5hDvrm4zJxsrJgkK+diZKIgM700tdn1GQhqKFZizjSPWjmpDgf8wNvFRywuViN0H6hqDntfKE8Aq2+GlA8IKzIt+k2Suu88kciYtmoVxM33uvNvFHjAhoycFZ2iCTxlbB5x1JoiVZqHlmVTytBM9SL7MCh4RdCMX3v3/M+zulKcQ9+K9gZkO5FRazcb88UZyNPsaP0mzjpWs+Ym+uJBmdTIvm1vFMe7Fxhqb4al2eQ8c0Xu6vFScyuh11VJ9UTDQYUcB1g2vZY1MOtJ+bEORHPciSqd0ukzYTLMQSzEy6caR5lEnbBHRXgBpStcaSPgqPHoyXC47Z3Y8UJf4XVNunImL7TnMbICRGHe2VFc6wEruOHK39DSnsgIW7amfbeKAk4WMB+g0QA+RnZ3oBuHrdQz7Vv6tKDZA8qn0u3BSFEJskX1hE2THmyoqwWRdj4XoMgaEoMpPDVQ4HWi1I//G6ajC31tDoGMYBXAzY1BZuXvlsFPeZjAzwD9DiCsVKIqzVFsMwOpZXguQE44QZRbhFaCzgX5S2JOLW8vqfj8zW8/R0GkCPS+xarZY7kdeWJJOfQe2sDrAzGdCISCmSfwFGrPtc+DlrVOtAentbkzizBqrVOuvdGRdwdmdXCbbgeHw==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(8676002)(6496006)(86362001)(4326008)(6486002)(956004)(8936002)(26005)(186003)(508600001)(36756003)(6666004)(83380400001)(5660300002)(66476007)(316002)(6916009)(66556008)(30864003)(38100700002)(2906002)(2616005)(54906003)(1076003)(66946007)(82960400001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VnJ4bzY1cE1uK0Y4eVRuM0xjd3JuNm1uZy94Mk1Yb255TE15cDRwUWUxbjZZ?=
 =?utf-8?B?QS9IckhCdFFXQnVrQWFqYUM3Y3RuSUNuSE1Id3g0bG0rS1Fsd3NROWpIWFU4?=
 =?utf-8?B?RkhNWElmSXBXcno2dFlCZjhSY25HdmpRWEUxZDJEdmQ2R2dVQ3VQTnJvNkVs?=
 =?utf-8?B?SHFxMnZtcHp1MmQ0S1NiaDUxKzNnNlVCakxjbU5KaU00NEhia1RPMmttQ0t1?=
 =?utf-8?B?cllvMnJ3M2R3Y1RrekN1SUg0MWJZTWl5cnRMUG5OSWxxOFZuSmUyWTVQeFdN?=
 =?utf-8?B?aFJZZ0tiL21JSUtxSWhtcU84em9DRnJIeWZrUUE4Ny9YNUF4bHNqT0dhS01I?=
 =?utf-8?B?VmtCajRtVERHekNmVXNNTm92c0JRV3l0YUE3cTd4VjdmZVBrcG9HUlRuS2Z4?=
 =?utf-8?B?WjdNbnQrV3F3cUxiYXB0Nis3NGdJZmdlamlnRXA3NlRCTHF4MnUveFhwL0tW?=
 =?utf-8?B?VDYzRlUzVGZZd2tkdFdPejJIZkVwckNtbDFSM0E5RzZGWVYweUlYMGFxTjNs?=
 =?utf-8?B?RmNtSmRhc2pnRXRVMUtkSVlta3ZTbER0Yk54bFI1amVnejVvazhjZWFYVGxv?=
 =?utf-8?B?citrK2kwRmU5dXB5RlYvTmhPdStFK0tQVjZPWDQ2REZSdnNuWk5sc2ovYWJl?=
 =?utf-8?B?MnI3RHVnK1J0NEl1emhZakpWMFEwVW90aDNreWhoTE1jaGtzZElEeWtkL3Rt?=
 =?utf-8?B?Y0cyY1QzbGs2TUlKRXFnSlNyS2NIaVlxU3lUSFBIakxxeFVlNmZjOW1xeUVz?=
 =?utf-8?B?UlVSaHBsZDVqcHh4Qi8rV29qTFF6Ymg5TEhCWjU3Q3I2K2xQWmlTekZuUlJI?=
 =?utf-8?B?aHg0YnlpV3JWVE9Uc0hXbnJ6VnlBTFZQYXVYd1F5R1Z6RXh6cWdvYUQ3WlJh?=
 =?utf-8?B?NFBSZGwyNnBOZ3FMa0N4SXFJTXI5dUlDVzhHVkVYVTdka0MvbVdTWU1ER2V2?=
 =?utf-8?B?T3lkSGJyU2FuWmxpMjRyU3VWYWFhSFF6c2JxdjJPRThnS09QVXEreXk4VGdL?=
 =?utf-8?B?dE5WRy9sdUdNRFBobEFNdmtvNU5UWE0xR3B3WXJpN2M0YWNCNFZFZUZwN1R0?=
 =?utf-8?B?aDhNdzl2bkdIVDhvT2NNeU44MWovTlRtUHNkNDlwS1VzSnQvZ0R4RzlHeklt?=
 =?utf-8?B?bTNjZmJHZ3Vqc1pWejVucnNDMm9rNW9WZnFEdnVkM2dtcXh5TVc4Q1o1Rmd3?=
 =?utf-8?B?S2F6RWFNSjhpZEZTT0xqc1lOOW04TkQ4cWJsZTBZUHExZ1U2UDBBRVY2c3cv?=
 =?utf-8?B?bnRlRm9JWklBNGhrYzcvUmdjZk54TTVFU0xZRFZsc1FFR2FQZU51eUZBQjlw?=
 =?utf-8?B?YVZDWU9yckFDR0UxY0F3cG1tcmlWY0EwV2dDMk5wNkFYMzFwcFJyT2FuNHh4?=
 =?utf-8?B?VjhNcCtaVlJoeEV2QXRYRG1ENkthR29IUUlWUjBpamx2cVdKTG96VHJ1N3NN?=
 =?utf-8?B?aGg4QUliYVNqL1Q2VWhja29tNVQwVGkwRi9FQVpmcVNRQU4wYzBBdmVvRWlV?=
 =?utf-8?B?aTlTSHgzc2FhTEZUWHQ1Q1NZdm5XNlVTdHB2WGZHQzVQQXNrU0ZTU3hIelB5?=
 =?utf-8?B?ZjJ2b1RWN2RBUFE3R0dZeWtCTkV0SWJGUEVIcTlNTmhTTUNOTGhQNjBRY1Zr?=
 =?utf-8?B?QTlRbFhYK2JWODFQMVREV3RJb3dVMkFibVFWbmtwUUZBNlRBdHBraXkyZFJN?=
 =?utf-8?B?cFNYTnF4Qytxd2hoeGdBVXlrVVY3N3RFOS84bnZPQXV2SEpvOVI0QWpPdm13?=
 =?utf-8?B?Q0tteWM3RXRMZDVucnRiMGRnOWRKZTYyNTBxNnFkaFkxR3hzc0ozRHFvVXcv?=
 =?utf-8?B?ZmVzTVZZeklXUEsyWk01eC9sdUdRQmljL1h5YW91cC9CYkd0aENWeElwUDEx?=
 =?utf-8?B?VWJGTEtOc1lYSGNGeFpIU2RqeTVQa0Y5NVdONm9SM2Rnc2JoeTB2OFNBaFU4?=
 =?utf-8?B?T3NmVytmOU9VMjBHd2k2a3BTK2NzM1RFWkUxT0t5RHBLZy8xRVpIYW01WTdt?=
 =?utf-8?B?ZUwwTWY3UHpBQk1mYm1NRlRsNGZMQlNMS0UzbC9qS0JDOXE3cmcwYzAyMWNJ?=
 =?utf-8?B?TTJLdEo3cVRXNkdiVTF5d0lUQUNrR2ZUamRCY1kzYXZmdUI0Z2FlUXk3bm1y?=
 =?utf-8?B?cjYveURzWk1Ya0ZMU2lwWnE1d3Jjc2hFWG1zMTA3OHFQWGNCWjI0bno1cWlZ?=
 =?utf-8?Q?AydwpQLPhtq0SHxMJ2lVo1E=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: edbfdef5-9da1-41d8-aaf2-08d999f9a302
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Oct 2021 09:59:31.2314
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ikUiJFxGufZjPBC3rJ9A/+l/Rv8L3U0yZzZowLbladrp20h8Yb4TcmwDgB+AV5YyZ2Vjt+RDJUf91SCy1IbD5A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB3289
X-OriginatorOrg: citrix.com

Introduce a new domain create field so that toolstack can specify the
maximum grant table version usable by the domain. This is plumbed into
xl and settable by the user as max_grant_version.

Previously this was only settable on a per host basis using the
gnttab command line option.

Note the version is specified using 4 bits, which leaves room to
specify up to grant table version 14 (15 is used to signal default max
version). Given that we only have 2 grant table versions right now,
and a new version is unlikely in the near future using 4 bits seems
more than enough.

Note that when using the default grant version the specific max
version in use by the domain is not migrated. Any guests should be
able to cope with the max grant version changing across migrations,
and if a specific guest relies on a maximum grant version being
unconditionally available it should be specified on the configuration
file.

Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
Acked-by: Christian Lindig <christian.lindig@citrix.com>
---
NB: the stubdom max grant version is cloned from the domain one. Not
sure whether long term we might want to use different options for the
stubdom and the domain. In any case the attack surface will always be
max(stubdom, domain), so maybe it's just pointless to allow more fine
grained settings.
---
Changes since v2:
 - Drop XEN_DOMCTLGRANT_MAX - it's unused.
 - Rename max_grant_version field to max_version in the grant table
   struct.
 - Print domain on log messages.
 - Print a message if host has more than 16Tb of RAM and grant v2 is
   disabled.
 - Add a TB macro.

Changes since v1:
 - Introduce a grant_opts field and use the low 4 bits to specify the
   version. Remaining bits will be used for other purposes.
---
Cc: Ian Jackson <iwj@xenproject.org>
---
Posting this patch alone as I think allowing to control transient
grants on a per-domain basis will require a bit more of work.

Release rationale:

We have had a bunch of security issues involving grant table v2 (382,
379, 268, 255) which could have been avoided by limiting the grant
table version available to guests. This can be currently done using a
global host parameter, but it's certainly more helpful to be able to
do it on a per domain basis from the toolstack.

Changes to the hypervisor by this patch are fairly minimal, as there
are already checks for the max grant table version allowed, so the
main change there is moving the max grant table version limit inside
the domain struct and plumbing it through the toolstrack.

I think the risk here is quite low for libxl/xl, because it's
extensively tested by osstest, so the main risk would be breaking the
Ocaml stubs, which could go unnoticed as those are not actually tested
by osstest.
---
 docs/man/xl.cfg.5.pod.in             |  6 ++++++
 docs/man/xl.conf.5.pod.in            |  7 +++++++
 tools/helpers/init-xenstore-domain.c |  1 +
 tools/include/libxl.h                |  7 +++++++
 tools/libs/light/libxl_create.c      |  3 +++
 tools/libs/light/libxl_dm.c          |  1 +
 tools/libs/light/libxl_types.idl     |  1 +
 tools/ocaml/libs/xc/xenctrl.ml       |  1 +
 tools/ocaml/libs/xc/xenctrl.mli      |  1 +
 tools/ocaml/libs/xc/xenctrl_stubs.c  |  7 ++++++-
 tools/xl/xl.c                        |  8 ++++++++
 tools/xl/xl.h                        |  1 +
 tools/xl/xl_parse.c                  |  9 +++++++++
 xen/arch/arm/domain_build.c          |  2 ++
 xen/arch/x86/setup.c                 |  1 +
 xen/common/domain.c                  |  3 ++-
 xen/common/grant_table.c             | 28 ++++++++++++++++++++++++++--
 xen/include/public/domctl.h          | 10 ++++++++--
 xen/include/xen/config.h             |  1 +
 xen/include/xen/grant_table.h        |  5 +++--
 20 files changed, 95 insertions(+), 8 deletions(-)

diff --git a/docs/man/xl.cfg.5.pod.in b/docs/man/xl.cfg.5.pod.in
index 55c4881205..21a39adb70 100644
--- a/docs/man/xl.cfg.5.pod.in
+++ b/docs/man/xl.cfg.5.pod.in
@@ -580,6 +580,12 @@ to have. This value controls how many pages of foreign domains can be accessed
 via the grant mechanism by this domain. The default value is settable via
 L<xl.conf(5)>.
 
+=item B<max_grant_version=NUMBER>
+
+Specify the maximum grant table version the domain is allowed to use. Current
+supported versions are 1 and 2. The default value is settable via
+L<xl.conf(5)>.
+
 =item B<nomigrate=BOOLEAN>
 
 Disable migration of this domain.  This enables certain other features
diff --git a/docs/man/xl.conf.5.pod.in b/docs/man/xl.conf.5.pod.in
index b48e99131a..0a70698a7c 100644
--- a/docs/man/xl.conf.5.pod.in
+++ b/docs/man/xl.conf.5.pod.in
@@ -101,6 +101,13 @@ Sets the default value for the C<max_maptrack_frames> domain config value.
 Default: value of Xen command line B<gnttab_max_maptrack_frames>
 parameter (or its default value if unspecified).
 
+=item B<max_grant_version=NUMBER>
+
+Sets the default value for the C<max_grant_version> domain config value.
+
+Default: value of Xen command line B<gnttab> parameter (or its default value if
+unspecified).
+
 =item B<vif.default.script="PATH">
 
 Configures the default hotplug script used by virtual network devices.
diff --git a/tools/helpers/init-xenstore-domain.c b/tools/helpers/init-xenstore-domain.c
index 6836002f0b..7cd1aa8f7c 100644
--- a/tools/helpers/init-xenstore-domain.c
+++ b/tools/helpers/init-xenstore-domain.c
@@ -88,6 +88,7 @@ static int build(xc_interface *xch)
          */
         .max_grant_frames = 4,
         .max_maptrack_frames = 128,
+        .grant_opts = 1,
     };
 
     xs_fd = open("/dev/xen/xenbus_backend", O_RDWR);
diff --git a/tools/include/libxl.h b/tools/include/libxl.h
index 2e8679dbcb..8621161845 100644
--- a/tools/include/libxl.h
+++ b/tools/include/libxl.h
@@ -514,6 +514,13 @@
  */
 #define LIBXL_HAVE_VPMU 1
 
+/*
+ * LIBXL_HAVE_MAX_GRANT_VERSION indicates libxl_domain_build_info has a
+ * max_grant_version field for setting the max grant table version per
+ * domain.
+ */
+#define LIBXL_HAVE_MAX_GRANT_VERSION 1
+
 /*
  * libxl ABI compatibility
  *
diff --git a/tools/libs/light/libxl_create.c b/tools/libs/light/libxl_create.c
index 5a61d01722..431c569dd2 100644
--- a/tools/libs/light/libxl_create.c
+++ b/tools/libs/light/libxl_create.c
@@ -607,6 +607,9 @@ int libxl__domain_make(libxl__gc *gc, libxl_domain_config *d_config,
             .max_evtchn_port = b_info->event_channels,
             .max_grant_frames = b_info->max_grant_frames,
             .max_maptrack_frames = b_info->max_maptrack_frames,
+            .grant_opts = b_info->max_grant_version == -1
+                          ? XEN_DOMCTL_GRANT_version_default
+                          : b_info->max_grant_version,
             .vmtrace_size = ROUNDUP(b_info->vmtrace_buf_kb << 10, XC_PAGE_SHIFT),
         };
 
diff --git a/tools/libs/light/libxl_dm.c b/tools/libs/light/libxl_dm.c
index 9d93056b5c..9a8ddbe188 100644
--- a/tools/libs/light/libxl_dm.c
+++ b/tools/libs/light/libxl_dm.c
@@ -2320,6 +2320,7 @@ void libxl__spawn_stub_dm(libxl__egc *egc, libxl__stub_dm_spawn_state *sdss)
 
     dm_config->b_info.max_grant_frames = guest_config->b_info.max_grant_frames;
     dm_config->b_info.max_maptrack_frames = guest_config->b_info.max_maptrack_frames;
+    dm_config->b_info.max_grant_version = guest_config->b_info.max_grant_version;
 
     dm_config->b_info.u.pv.features = "";
 
diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_types.idl
index 608d55a456..ce856febe5 100644
--- a/tools/libs/light/libxl_types.idl
+++ b/tools/libs/light/libxl_types.idl
@@ -519,6 +519,7 @@ libxl_domain_build_info = Struct("domain_build_info",[
 
     ("max_grant_frames",    uint32, {'init_val': 'LIBXL_MAX_GRANT_DEFAULT'}),
     ("max_maptrack_frames", uint32, {'init_val': 'LIBXL_MAX_GRANT_DEFAULT'}),
+    ("max_grant_version",   integer, {'init_val': '-1'}),
     
     ("device_model_version", libxl_device_model_version),
     ("device_model_stubdomain", libxl_defbool),
diff --git a/tools/ocaml/libs/xc/xenctrl.ml b/tools/ocaml/libs/xc/xenctrl.ml
index addcf4cc59..d3eacfba6e 100644
--- a/tools/ocaml/libs/xc/xenctrl.ml
+++ b/tools/ocaml/libs/xc/xenctrl.ml
@@ -84,6 +84,7 @@ type domctl_create_config =
 	max_evtchn_port: int;
 	max_grant_frames: int;
 	max_maptrack_frames: int;
+	max_grant_version: int;
 	arch: arch_domainconfig;
 }
 
diff --git a/tools/ocaml/libs/xc/xenctrl.mli b/tools/ocaml/libs/xc/xenctrl.mli
index 0a5ce529e9..96e5d14643 100644
--- a/tools/ocaml/libs/xc/xenctrl.mli
+++ b/tools/ocaml/libs/xc/xenctrl.mli
@@ -76,6 +76,7 @@ type domctl_create_config = {
   max_evtchn_port: int;
   max_grant_frames: int;
   max_maptrack_frames: int;
+  max_grant_version: int;
   arch: arch_domainconfig;
 }
 
diff --git a/tools/ocaml/libs/xc/xenctrl_stubs.c b/tools/ocaml/libs/xc/xenctrl_stubs.c
index ad953d36bd..1e60925069 100644
--- a/tools/ocaml/libs/xc/xenctrl_stubs.c
+++ b/tools/ocaml/libs/xc/xenctrl_stubs.c
@@ -188,7 +188,8 @@ CAMLprim value stub_xc_domain_create(value xch, value wanted_domid, value config
 #define VAL_MAX_EVTCHN_PORT     Field(config, 5)
 #define VAL_MAX_GRANT_FRAMES    Field(config, 6)
 #define VAL_MAX_MAPTRACK_FRAMES Field(config, 7)
-#define VAL_ARCH                Field(config, 8)
+#define VAL_MAX_GRANT_VERSION   Field(config, 8)
+#define VAL_ARCH                Field(config, 9)
 
 	uint32_t domid = Int_val(wanted_domid);
 	int result;
@@ -198,6 +199,9 @@ CAMLprim value stub_xc_domain_create(value xch, value wanted_domid, value config
 		.max_evtchn_port = Int_val(VAL_MAX_EVTCHN_PORT),
 		.max_grant_frames = Int_val(VAL_MAX_GRANT_FRAMES),
 		.max_maptrack_frames = Int_val(VAL_MAX_MAPTRACK_FRAMES),
+		.grant_opts = Int_val(VAL_MAX_GRANT_VERSION) == -1
+			      ? XEN_DOMCTL_GRANT_version_default
+			      : Int_val(VAL_MAX_GRANT_VERSION),
 	};
 
 	domain_handle_of_uuid_string(cfg.handle, String_val(VAL_HANDLE));
@@ -251,6 +255,7 @@ CAMLprim value stub_xc_domain_create(value xch, value wanted_domid, value config
 	}
 
 #undef VAL_ARCH
+#undef VAL_MAX_GRANT_VERSION
 #undef VAL_MAX_MAPTRACK_FRAMES
 #undef VAL_MAX_GRANT_FRAMES
 #undef VAL_MAX_EVTCHN_PORT
diff --git a/tools/xl/xl.c b/tools/xl/xl.c
index f422f9fed5..7564ff323b 100644
--- a/tools/xl/xl.c
+++ b/tools/xl/xl.c
@@ -55,6 +55,7 @@ bool progress_use_cr = 0;
 bool timestamps = 0;
 int max_grant_frames = -1;
 int max_maptrack_frames = -1;
+int max_grant_version = -1;
 libxl_domid domid_policy = INVALID_DOMID;
 
 xentoollog_level minmsglevel = minmsglevel_default;
@@ -219,6 +220,13 @@ static void parse_global_config(const char *configfile,
     else if (e != ESRCH)
         exit(1);
 
+    e = xlu_cfg_get_bounded_long (config, "max_grant_version", 0,
+                                  INT_MAX, &l, 1);
+    if (!e)
+        max_grant_version = l;
+    else if (e != ESRCH)
+        exit(1);
+
     libxl_cpu_bitmap_alloc(ctx, &global_vm_affinity_mask, 0);
     libxl_cpu_bitmap_alloc(ctx, &global_hvm_affinity_mask, 0);
     libxl_cpu_bitmap_alloc(ctx, &global_pv_affinity_mask, 0);
diff --git a/tools/xl/xl.h b/tools/xl/xl.h
index 7e23f30192..cf12c79a9b 100644
--- a/tools/xl/xl.h
+++ b/tools/xl/xl.h
@@ -282,6 +282,7 @@ extern char *default_colo_proxy_script;
 extern char *blkdev_start;
 extern int max_grant_frames;
 extern int max_maptrack_frames;
+extern int max_grant_version;
 extern libxl_bitmap global_vm_affinity_mask;
 extern libxl_bitmap global_hvm_affinity_mask;
 extern libxl_bitmap global_pv_affinity_mask;
diff --git a/tools/xl/xl_parse.c b/tools/xl/xl_parse.c
index c503b9be00..117fcdcb2b 100644
--- a/tools/xl/xl_parse.c
+++ b/tools/xl/xl_parse.c
@@ -1431,6 +1431,15 @@ void parse_config_data(const char *config_source,
     else
         exit(1);
 
+    e = xlu_cfg_get_bounded_long (config, "max_grant_version", 0,
+                                  INT_MAX, &l, 1);
+    if (e == ESRCH) /* not specified */
+        b_info->max_grant_version = max_grant_version;
+    else if (!e)
+        b_info->max_grant_version = l;
+    else
+        exit(1);
+
     libxl_defbool_set(&b_info->claim_mode, claim_mode);
 
     if (xlu_cfg_get_string (config, "on_poweroff", &buf, 0))
diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
index 0167731ab0..faeb3eba76 100644
--- a/xen/arch/arm/domain_build.c
+++ b/xen/arch/arm/domain_build.c
@@ -2967,6 +2967,7 @@ void __init create_domUs(void)
             .max_evtchn_port = -1,
             .max_grant_frames = -1,
             .max_maptrack_frames = -1,
+            .grant_opts = XEN_DOMCTL_GRANT_version_default,
         };
 
         if ( !dt_device_is_compatible(node, "xen,domain") )
@@ -3074,6 +3075,7 @@ void __init create_dom0(void)
         .max_evtchn_port = -1,
         .max_grant_frames = gnttab_dom0_frames(),
         .max_maptrack_frames = -1,
+        .grant_opts = XEN_DOMCTL_GRANT_version_default,
     };
 
     /* The vGIC for DOM0 is exactly emulating the hardware GIC */
diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c
index b101565f14..b5b6c75447 100644
--- a/xen/arch/x86/setup.c
+++ b/xen/arch/x86/setup.c
@@ -750,6 +750,7 @@ static struct domain *__init create_dom0(const module_t *image,
         .max_evtchn_port = -1,
         .max_grant_frames = -1,
         .max_maptrack_frames = -1,
+        .grant_opts = XEN_DOMCTL_GRANT_version_default,
         .max_vcpus = dom0_max_vcpus(),
         .arch = {
             .misc_flags = opt_dom0_msr_relaxed ? XEN_X86_MSR_RELAXED : 0,
diff --git a/xen/common/domain.c b/xen/common/domain.c
index 8b53c49d1e..0c7052c770 100644
--- a/xen/common/domain.c
+++ b/xen/common/domain.c
@@ -678,7 +678,8 @@ struct domain *domain_create(domid_t domid,
         init_status |= INIT_evtchn;
 
         if ( (err = grant_table_init(d, config->max_grant_frames,
-                                     config->max_maptrack_frames)) != 0 )
+                                     config->max_maptrack_frames,
+                                     config->grant_opts)) != 0 )
             goto fail;
         init_status |= INIT_gnttab;
 
diff --git a/xen/common/grant_table.c b/xen/common/grant_table.c
index e510395d08..f94f0f272c 100644
--- a/xen/common/grant_table.c
+++ b/xen/common/grant_table.c
@@ -53,6 +53,7 @@ struct grant_table {
     percpu_rwlock_t       lock;
     /* Lock protecting the maptrack limit */
     spinlock_t            maptrack_lock;
+    unsigned int          max_version;
     /*
      * Defaults to v1.  May be changed with GNTTABOP_set_version.  All other
      * values are invalid.
@@ -1917,11 +1918,33 @@ active_alloc_failed:
 }
 
 int grant_table_init(struct domain *d, int max_grant_frames,
-                     int max_maptrack_frames)
+                     int max_maptrack_frames, unsigned int options)
 {
     struct grant_table *gt;
+    unsigned int max_grant_version = options & XEN_DOMCTL_GRANT_version_mask;
     int ret = -ENOMEM;
 
+    if ( max_grant_version == XEN_DOMCTL_GRANT_version_default )
+        max_grant_version = opt_gnttab_max_version;
+    if ( !max_grant_version )
+    {
+        dprintk(XENLOG_INFO, "%pd: invalid grant table version 0 requested\n",
+                d);
+        return -EINVAL;
+    }
+    if ( max_grant_version > opt_gnttab_max_version )
+    {
+        dprintk(XENLOG_INFO,
+                "%pd: requested grant version (%u) greater than supported (%u)\n",
+                d, max_grant_version, opt_gnttab_max_version);
+        return -EINVAL;
+    }
+    if ( unlikely(max_page >= PFN_DOWN(TB(16))) && is_pv_domain(d) &&
+         max_grant_version < 2 )
+        dprintk(XENLOG_INFO,
+                "%pd: host memory above 16Tb and grant table v2 disabled\n",
+                d);
+
     /* Default to maximum value if no value was specified */
     if ( max_grant_frames < 0 )
         max_grant_frames = opt_max_grant_frames;
@@ -1947,6 +1970,7 @@ int grant_table_init(struct domain *d, int max_grant_frames,
     gt->gt_version = 1;
     gt->max_grant_frames = max_grant_frames;
     gt->max_maptrack_frames = max_maptrack_frames;
+    gt->max_version = max_grant_version;
 
     /* Install the structure early to simplify the error path. */
     gt->domain = d;
@@ -3076,7 +3100,7 @@ gnttab_set_version(XEN_GUEST_HANDLE_PARAM(gnttab_set_version_t) uop)
         goto out;
 
     res = -ENOSYS;
-    if ( op.version == 2 && opt_gnttab_max_version == 1 )
+    if ( op.version == 2 && gt->max_version == 1 )
         goto out; /* Behave as before set_version was introduced. */
 
     res = 0;
diff --git a/xen/include/public/domctl.h b/xen/include/public/domctl.h
index 51017b47bc..0ec57614bd 100644
--- a/xen/include/public/domctl.h
+++ b/xen/include/public/domctl.h
@@ -89,14 +89,20 @@ struct xen_domctl_createdomain {
     /*
      * Various domain limits, which impact the quantity of resources
      * (global mapping space, xenheap, etc) a guest may consume.  For
-     * max_grant_frames and max_maptrack_frames, < 0 means "use the
-     * default maximum value in the hypervisor".
+     * max_grant_frames, max_maptrack_frames and max_gnttab_version < 0
+     * means "use the default maximum value in the hypervisor".
      */
     uint32_t max_vcpus;
     uint32_t max_evtchn_port;
     int32_t max_grant_frames;
     int32_t max_maptrack_frames;
 
+/* Grant version, use low 4 bits. */
+#define XEN_DOMCTL_GRANT_version_mask    0xf
+#define XEN_DOMCTL_GRANT_version_default 0xf
+
+    uint32_t grant_opts;
+
     /* Per-vCPU buffer size in bytes.  0 to disable. */
     uint32_t vmtrace_size;
 
diff --git a/xen/include/xen/config.h b/xen/include/xen/config.h
index b76222ecf6..37b42c756a 100644
--- a/xen/include/xen/config.h
+++ b/xen/include/xen/config.h
@@ -81,6 +81,7 @@
 #define KB(_kb)     (_AC(_kb, ULL) << 10)
 #define MB(_mb)     (_AC(_mb, ULL) << 20)
 #define GB(_gb)     (_AC(_gb, ULL) << 30)
+#define TB(_tb)     (_AC(_tb, ULL) << 40)
 
 #define IS_ALIGNED(val, align) (((val) & ((align) - 1)) == 0)
 
diff --git a/xen/include/xen/grant_table.h b/xen/include/xen/grant_table.h
index 41713e2726..fe6225346f 100644
--- a/xen/include/xen/grant_table.h
+++ b/xen/include/xen/grant_table.h
@@ -36,7 +36,7 @@ extern unsigned int opt_max_grant_frames;
 
 /* Create/destroy per-domain grant table context. */
 int grant_table_init(struct domain *d, int max_grant_frames,
-                     int max_maptrack_frames);
+                     int max_maptrack_frames, unsigned int options);
 void grant_table_destroy(
     struct domain *d);
 void grant_table_init_vcpu(struct vcpu *v);
@@ -67,7 +67,8 @@ int gnttab_acquire_resource(
 
 static inline int grant_table_init(struct domain *d,
                                    int max_grant_frames,
-                                   int max_maptrack_frames)
+                                   int max_maptrack_frames,
+                                   unsigned int options)
 {
     return 0;
 }
-- 
2.33.0



From xen-devel-bounces@lists.xenproject.org Thu Oct 28 10:04:41 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Oct 2021 10:04:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217789.377960 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg2Gr-0002hJ-8H; Thu, 28 Oct 2021 10:04:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217789.377960; Thu, 28 Oct 2021 10:04:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg2Gr-0002hC-52; Thu, 28 Oct 2021 10:04:29 +0000
Received: by outflank-mailman (input) for mailman id 217789;
 Thu, 28 Oct 2021 10:04:27 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ikAZ=PQ=epam.com=prvs=19352d112c=oleksandr_andrushchenko@srs-us1.protection.inumbo.net>)
 id 1mg2Go-0002h6-Ut
 for xen-devel@lists.xenproject.org; Thu, 28 Oct 2021 10:04:27 +0000
Received: from mx0a-0039f301.pphosted.com (unknown [148.163.133.242])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id a5945aba-dce4-42a1-a7fb-c1b6c5201251;
 Thu, 28 Oct 2021 10:04:25 +0000 (UTC)
Received: from pps.filterd (m0174676.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 19S9SbIl001597; 
 Thu, 28 Oct 2021 10:04:24 GMT
Received: from eur04-vi1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2052.outbound.protection.outlook.com [104.47.14.52])
 by mx0a-0039f301.pphosted.com with ESMTP id 3byduj1y3d-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Thu, 28 Oct 2021 10:04:24 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.13; Thu, 28 Oct
 2021 10:04:21 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::c038:e032:595a:651]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::c038:e032:595a:651%9]) with mapi id 15.20.4649.015; Thu, 28 Oct 2021
 10:04:21 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a5945aba-dce4-42a1-a7fb-c1b6c5201251
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=IKkVgvmREF6JbpN1hgnC3mCnicD4j6E2SIM0v80WSkXV7jGkAWBpfnORcWYNAMUjJ18CgZHlROhJV4zd7raPsR1s6NldBlOT93eZYquCj308vlFhI1DKIEe+8bQEF/lJyPgxEMfvKNCqKQO8Kpb24hXpB1UIxu7bihJ/lRx2vhgdfCzBi4t9TrcZSvAkXmW6tVuj/0dKY+pKFRJfDYEzi0Z8aNbBzCSquLS5qs8o8e8pXabe9M5Sb4xJ4WHxvDuJZWoM8w+8of5uUAnMdQihy/2N9u1XuH7wWNBawYZ/op73IB0tOnzu6IEZmiQ+5uNBJluqPprTCsJudnmFr7Zq4Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=sjYkhuSv5aGZ6QJd7Al7PtnntmiqCTKVkPcOMq5b7QU=;
 b=ZGPn7cKp9q5Z+t7Mi80jKPWUiaw4FaCOTIfmBjnozQf30wnvfTg8XSat0hrFBweFkiUg5dhc6+rYT3Tv7s7CZ5mBPxg/ZoLkgwOcob+0nABox8/1BCbGcJ2Zd4ZOGOySOt4d4zVL1fevLW+2IcLMww5ZYs12Orf9qpwhPEORNJfWGqUQ5G9jlR3hkquOpZWjzN4bi/C40809MYgab6PmN3GxzrENZ0pzZNnFiLRql0sRVuM9BuriPKvo9d0pGGezhTUrHzAhFrs381mNbCDZ+0dshKwybQ/FIyrUBAijw98JO8qJ0PIJiR1bkFLSz6t4PzCz/xRCq0km1FR4FuEbiA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=sjYkhuSv5aGZ6QJd7Al7PtnntmiqCTKVkPcOMq5b7QU=;
 b=KTvduSaMbkckdt54Ry2TBn+iC737bEyXV5ylXNr3t9pSxF0DGj/1Fg7x0mDU42gcv6msN1qUFokaWk8cbIQKv31X5MyRQE1kIPaZjWIkoOaLasoLfmbppprC4UbSs4O+3hdy/sNnpIzEqkuEZSbqb1dmI7Ft9IZr75ieFOo61Oi7N19ZXhsijCH/Xq/Ap+hqowLdUxmeVc9g6Js/+6TeqzMUm7vRpXjXul4IdSKgn1Di+Nggc/XHAZSAxdUnxg0M0VVZXQlTUlGyxjdUexHP7eIdIS4K5wuEt63uHqJPjYhsHGWmEBHhI1GkAyHCTDgTwpkao6T815gmLnqgEYT+Cg==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        Roger
 Pau Monne <roger.pau@citrix.com>
Subject: vpci: Need for vpci_cancel_pending
Thread-Topic: vpci: Need for vpci_cancel_pending
Thread-Index: AQHXy+MtilSp1e2bsUu2TEgvHf6jsQ==
Date: Thu, 28 Oct 2021 10:04:20 +0000
Message-ID: <fd1328da-5ad3-62cc-28d6-0ec60e9ea582@epam.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 68bdbf69-7b21-481c-1a85-08d999fa4fd8
x-ms-traffictypediagnostic: AM0PR03MB6324:
x-microsoft-antispam-prvs: 
 <AM0PR03MB6324155E0D6C44ECE483655EE7869@AM0PR03MB6324.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:8882;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 ///6P9RP77EJTDN3wTema0fOoSTm5SO+KkWOORz2phH7XiuEbSglMY4zivMo8AHMWCVYq4jJTtEQ6W45/PgxrkiIavcPa0QU4FQwwSlwqPuTcVmJmxP8ZXZPqDzkMlgB73wc8AAnUlRYooftR3vd5ggsY9YzvcXEI9nAUXDTMFYbTFRZ3bJ7C8AQC1l3V3ZZA4JxxeUFKLu3Kv2HMhfLUx+FcaOU8U3g9B1sQvl0MccgIvOl6HjqQ0gg2djw6wPIWawLOePPykA+lUxz/WtOWRbN0o7Se8LUuGpAj7YLljpIiTncybZt3tIq0yGkHXaadGnlxaSvh3IOgAIFwnUD+YRuQQwB/gdpSDsZsVInIcE0IjZhXdO6HWa3YYY6QRxdJUNs2PdLpqzCCTgMLY0LS+I9H/pllxvvKjYgd1lRduK+cbjEnAiSFQLtogcXXjUPuKI7q00i9uAraH9WsJMIZoeBDCIVfgWxBs7oKHx8sK1jo7b5Uchnnhho1JZWdLVpPWi+UmZTmfN6eEVkHFFwkpARhbXptq+TX4Sn7JgV6myMVt7Jj+JUVP4g1HJWY+aK/eHpjpJ3Ugul02HJBlRmvP3dVYJK9btjfRPXB+oEDezKspd5yN7oCOXW+yHgAMqaaVf1Q66pNIP7ax6OUIT+UxnySjcCd5QcfF0QMgrTW7JRxMPyzX2/2MEkOwc3kBKXTa8f26RuCZxcUKrz7MSyIrc6bx6MzpUgrn9ez1B8AJAQV7ThZQx0b0d1U4+RyaNG
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(110136005)(8936002)(31686004)(316002)(31696002)(71200400001)(38070700005)(2906002)(508600001)(66556008)(6506007)(86362001)(55236004)(76116006)(66946007)(36756003)(66476007)(91956017)(66446008)(26005)(64756008)(6512007)(38100700002)(8676002)(5660300002)(6486002)(186003)(2616005)(83380400001)(122000001)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?djRkcllyNythVldhSndqdzd5SVRhV1hocXBzT1QzaEZGUi9Nckx6a0ZOUDFG?=
 =?utf-8?B?NDFsaHNmWjJHYThoa0I5RnliUVlCc1JjZ2Fzc0srZW5BcWQ0RUIvUlVZWUtZ?=
 =?utf-8?B?NzVldnVaUEVqMHVtM3JRMHNoaW1BVWJZemZha2RlSVdzaEZ5dStKU1I5VXJ0?=
 =?utf-8?B?OFVpMWZOODRXbEVUdW43UzdOdTRQOG1wLzg3eFhjL3FKRUJFUjRxNUdjYm9l?=
 =?utf-8?B?SVREdHRvVGNndnhFdExSc3NxSWxkQ1hydWpxK0NTcGlpbSs3UW5JcEp4bHpl?=
 =?utf-8?B?TjlvQ0s3ZWFuZ2JtbnRSZ3ZJZnppL1pqenM5NURtRW1xeXhSYVJlYTdjblNv?=
 =?utf-8?B?aXdSRVRnWUZ6ZXk4SkJGNzk2dDVnei9YMzRETzZDb3B0b1ZUbGowZVR3MlQv?=
 =?utf-8?B?N2xWUGlaQmU5aXRwVHlVY3NpZjBTTFZjeDdJVkoraDNKT2ZlVzBMaEp2dGVS?=
 =?utf-8?B?c0t2NE9hQ21mNFlCS1hPL0w5MXhoUElsb2xYeU9WTVgvRnRQYzY0aTVGREZQ?=
 =?utf-8?B?M09QdnBFOW43OGpPblF6eE4zblJuSDJYOXJVN2ZUemw5VEJRZnJrYlNjTVl4?=
 =?utf-8?B?TVFsRDgrL01iY0M4d1NsMzFxL2pFREFqMXc4QlNDVENXdm9kNUNONStDcTR0?=
 =?utf-8?B?NDZDbGUrTWpOUjVQbVpXSGFCU282akNNRjE3N0Q5QmJZb1d2UFRjZ0UxTm5L?=
 =?utf-8?B?TFJtZDl1bjhnVlM5UDdwZUFjSWwyanNJTnM1b29KRkwyZFgrb1lDemR5UThB?=
 =?utf-8?B?TVc5Qll3R3dxQ0plV215MnA3SGFUWWdleXpCcmpFYVpUcEM1WWxRblZzUkFm?=
 =?utf-8?B?Wi9QbXpncytCa1h0YzE0VllHWXVyY3QxMmhiQS9mTnNtTnl6UmY5a0lwcURs?=
 =?utf-8?B?RVkzNDlFcmhzdGpvNStueWpLbEdUUEJDcGlVL1RzbDlyUjZSTlgzTnF5Slhm?=
 =?utf-8?B?TGwyWVlMK0doVUtBVmNsQlZCZFNGTjA5UjViR2JBb3l3NEhyT21EUGp3SEIz?=
 =?utf-8?B?UUN6QlpweUtTZ0czZFh1QzkwRFp2TXNIS1hXSlBsN2krSmhlakNwTnJ3SEI0?=
 =?utf-8?B?ZmRocjRJbkZSV01oU1lqVVJtR1BYcjNSSTFJaXZZS1Y3bVdFN2pMWk8xL0No?=
 =?utf-8?B?MG1LZUp2UDdPWUFNQzFrdWV5cVlKVVRXai9leDllS2VZU2VLcFNLSW1tREkr?=
 =?utf-8?B?U000MDVyU2pFUHhiU2FRLzNuY0U5QkcxdTc0VkpHdkpVZkdZK3ZnZ2lCVFJC?=
 =?utf-8?B?eW5kN0xKc0o1WUlndXRCajhzMjM1UHdDeEhnWitjL2x4cDVBOHd5MFh3NWFK?=
 =?utf-8?B?eDB1ck5JSDl3QngzV1kzcHRJTTJjaTBON2o3Y1pCMXE0YmNFQU1yWnFVR0lt?=
 =?utf-8?B?OEpQZGo4MWNURGIxRmpOSmNRTTcySSt4SzhqTXhiRUJpZU40NCszNStTZjA2?=
 =?utf-8?B?NWsxdkxMUFp4L1FlWElYeTBGR3FIY3JIY0ZsS01uTTF1d2dtRUxaQzlOb28r?=
 =?utf-8?B?cW41NUM1QkFtZUhmd0g2bC9pTGN4ZWNwUURSaGl4eU9HY3hMVC9RN01Za0dQ?=
 =?utf-8?B?M0NkdVVuRzc3YzFqQjllSzQ2aXU5WmlYc2dJSGJwK2dxUDQ4MVBWTHRQSmo0?=
 =?utf-8?B?ZGQ2Q2NUckQ3UjRMQ1FzOHpZVStabFByZGk3OU9ITkpwT083UXl2R3BYcytF?=
 =?utf-8?B?ZVNmdmtxanFXeU80SlFJU2x6S1VVQU8zWCtRTWx4ZUYyK1ZiK1lhbGFJdVBz?=
 =?utf-8?B?eXdRWjR0cGdvM0hqN0xuZjM0M0RJZnV4QnJxbkRIZHFkYk5pYU1La09xOUFa?=
 =?utf-8?B?TmNrZkhFdS9vanRXbm9zOWdDN1NoYkh0TFE1Qnh0QlZqcUE1dGZEYnpsTTQz?=
 =?utf-8?B?eW1UMVN4YXV5OVF4SUdiN0wzSGdqOTJwZUhCQ3F3bmR4L1RpSWVFRnpQU04r?=
 =?utf-8?B?YUllbnBLUVZUOG1Hc0tUd1RCRjNkczByRnRVSTU0RE1nVitXZXhERllkMXcy?=
 =?utf-8?B?cmxYL1p1YnlncTR6K3ZPb2xaWDNMZlV5TDZTYVJzbVZjRkVYTm43ekQ4TU02?=
 =?utf-8?B?RGxSUDJ4Q2RscUFYNERHamJCL0c0NGZEaGsrQkJDdk9qdTlsZ2xjWllnU1d2?=
 =?utf-8?B?bkRRczhhR04vdndXYmlGZEoyZGVzbFhIM1l2bTVyTGYweUlIRWw5cnc0OE04?=
 =?utf-8?B?V1hGcHZDWG1PcXlzRlVFNEhIMUZaZU4wdUJ5RVQ2NU84MkQ3azl1elMvcWpW?=
 =?utf-8?B?Rk1qSGRDMmhrTFphUTlMRTRCL2tuNHl0VFd2WXBSM2hkTkhQYW9EZStyKys0?=
 =?utf-8?B?dW1KQkNubjVEWmY4Q1lEK0s3OXhRcmRvVGxpUlc3eFJQQkdtQnNVUT09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <52D3E33F9313A34A87CB98520DAF7CC8@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 68bdbf69-7b21-481c-1a85-08d999fa4fd8
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Oct 2021 10:04:20.9295
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: kR6s0d1VUf9vhBh6/Aeic74RNF2Ah4abHe5u78tybb1cNbNn3skC2HqcPVxr7xJgxSSViUlHRxTru/PcnJC2d4Foe05hOjzOrw6O/+TcXLk0nRoeFW2o0nN/wo/7HPUX
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR03MB6324
X-Proofpoint-GUID: fzR4vii7jUQx7x1lQpeDL3fD7-caD9yN
X-Proofpoint-ORIG-GUID: fzR4vii7jUQx7x1lQpeDL3fD7-caD9yN
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475
 definitions=2021-10-28_01,2021-10-26_01,2020-04-07_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 clxscore=1015
 bulkscore=0 spamscore=0 impostorscore=0 lowpriorityscore=0 mlxlogscore=528
 suspectscore=0 priorityscore=1501 mlxscore=0 adultscore=0 phishscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2110280055

SGksIGFsbCENCg0KV2hpbGUgd29ya2luZyBvbiBQQ0kgcGFzc3Rocm91Z2ggb24gQXJtIEkgc3Rl
cHBlZCBvbnRvIGEgY3Jhc2gNCndpdGggdGhlIGZvbGxvd2luZyBjYWxsIGNoYWluOg0KDQpwY2lf
cGh5c2Rldl9vcA0KIMKgIHBjaV9hZGRfZGV2aWNlDQogwqAgwqDCoCDCoGluaXRfYmFycyAtPiBt
b2RpZnlfYmFycyAtPiBkZWZlcl9tYXAgLT4gcmFpc2Vfc29mdGlycShTQ0hFRFVMRV9TT0ZUSVJR
KQ0KIMKgIGlvbW11X2FkZF9kZXZpY2UgPC0gRkFJTFMNCiDCoCB2cGNpX3JlbW92ZV9kZXZpY2Ug
LT4geGZyZWUocGRldi0+dnBjaSkNCg0KVGhlbjoNCmxlYXZlX2h5cGVydmlzb3JfdG9fZ3Vlc3QN
CiDCoCB2cGNpX3Byb2Nlc3NfcGVuZGluZzogdi0+dnBjaS5tZW0gIT0gTlVMTDsgdi0+dnBjaS5w
ZGV2LT52cGNpID09IE5VTEwNCg0KV2hpY2ggcmVzdWx0cyBpbiB0aGUgY3Jhc2ggYmVsb3c6DQoN
CihYRU4pIERhdGEgQWJvcnQgVHJhcC4gU3luZHJvbWU9MHg2DQooWEVOKSBXYWxraW5nIEh5cGVy
dmlzb3IgVkEgMHgxMCBvbiBDUFUwIHZpYSBUVEJSIDB4MDAwMDAwMDA0ODFkZDAwMA0KKFhFTikg
MFRIWzB4MF0gPSAweDAwMDAwMDAwNDgxZGNmN2YNCihYRU4pIDFTVFsweDBdID0gMHgwMDAwMDAw
MDQ4MWQ5ZjdmDQooWEVOKSAyTkRbMHgwXSA9IDB4MDAwMDAwMDAwMDAwMDAwMA0KKFhFTikgQ1BV
MDogVW5leHBlY3RlZCBUcmFwOiBEYXRhIEFib3J0DQouLi4NCihYRU4pIFhlbiBjYWxsIHRyYWNl
Og0KKFhFTinCoMKgwqAgWzwwMDAwMDAwMDAwMjI0NmQ4Pl0gX3NwaW5fbG9jaysweDQwLzB4YTQg
KFBDKQ0KKFhFTinCoMKgwqAgWzwwMDAwMDAwMDAwMjI0NmMwPl0gX3NwaW5fbG9jaysweDI4LzB4
YTQgKExSKQ0KKFhFTinCoMKgwqAgWzwwMDAwMDAwMDAwMjRmNmQwPl0gdnBjaV9wcm9jZXNzX3Bl
bmRpbmcrMHg3OC8weDEyOA0KKFhFTinCoMKgwqAgWzwwMDAwMDAwMDAwMjdmN2U4Pl0gbGVhdmVf
aHlwZXJ2aXNvcl90b19ndWVzdCsweDUwLzB4Y2MNCihYRU4pwqDCoMKgIFs8MDAwMDAwMDAwMDI2
OWM1Yz5dIGVudHJ5Lm8jZ3Vlc3Rfc3luY19zbG93cGF0aCsweGE4LzB4ZDQNCg0KU28sIGl0IHNl
ZW1zIHRoYXQgaWYgcGNpX2FkZF9kZXZpY2UgZmFpbHMgYW5kIGNhbGxzIHZwY2lfcmVtb3ZlX2Rl
dmljZQ0KdGhlIGxhdGVyIG5lZWRzIHRvIGNhbmNlbCBhbnkgcGVuZGluZyB3b3JrLg0KDQpJZiB0
aGlzIGlzIGEgbWFwIG9wZXJhdGlvbiBpdCBzZWVtcyB0byBiZSBzdHJhaWdodGZvcndhcmQ6IGRl
c3Ryb3kNCnRoZSByYW5nZSBzZXQgYW5kIGRvIG5vdCBtYXAgYW55dGhpbmcuDQoNCklmIHZwY2lf
cmVtb3ZlX2RldmljZSBpcyBjYWxsZWQgYW5kIHVubWFwIG9wZXJhdGlvbiB3YXMgc2NoZWR1bGVk
DQp0aGVuIGl0IGNhbiBiZSB0aGF0Og0KLSBndWVzdCBpcyBiZWluZyBkZXN0cm95ZWQgZm9yIGFu
eSByZWFzb24gYW5kIHNraXBwaW5nIHVubWFwIGlzIG9rDQogwqAgYXMgYWxsIHRoZSBtYXBwaW5n
cyBmb3IgdGhlIHdob2xlIGRvbWFpbiB3aWxsIGJlIGRlc3Ryb3llZCBhbnl3YXlzDQotIGd1ZXN0
IGlzIHN0aWxsIGdvaW5nIHRvIHN0YXkgYWxpdmUgYW5kIHRoZW4gdW5tYXBwaW5nIG11c3QgYmUg
ZG9uZQ0KDQpJIHdvdWxkIGxpa2UgdG8gaGVhciB5b3VyIHRob3VnaHQgd2hhdCB3b3VsZCBiZSB0
aGUgcmlnaHQgYXBwcm9hY2gNCnRvIHRha2UgaW4gb3JkZXIgdG8gc29sdmUgdGhlIGlzc3VlLg0K
DQpUaGFuayB5b3UgaW4gYWR2YW5jZSwNCk9sZWtzYW5kcg==


From xen-devel-bounces@lists.xenproject.org Thu Oct 28 10:05:37 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Oct 2021 10:05:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217794.377971 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg2Hk-0003Ha-Hf; Thu, 28 Oct 2021 10:05:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217794.377971; Thu, 28 Oct 2021 10:05:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg2Hk-0003HT-Ej; Thu, 28 Oct 2021 10:05:24 +0000
Received: by outflank-mailman (input) for mailman id 217794;
 Thu, 28 Oct 2021 10:05:24 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mg2Hk-0003HL-17
 for xen-devel@lists.xenproject.org; Thu, 28 Oct 2021 10:05:24 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mg2Hi-0004gq-OO; Thu, 28 Oct 2021 10:05:22 +0000
Received: from 54-240-197-225.amazon.com ([54.240.197.225] helo=[10.7.236.13])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mg2Hi-00059E-GT; Thu, 28 Oct 2021 10:05:22 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=MZ0gQCL7RG80aB7yqtqCAkOV78hJhMJsG3xFRq+YgWs=; b=gI6K4GXZ4wqKIQSTECaZ4wUjDt
	Psubp5pztQgQgHb1uEGKerfykjEv3FOgJhkpDis1pTZAcW502I3z2Qf+oMlrb8VUSfK7BSLaJC/6g
	BiaLGF79zlDWx2/7j9Q3U9PsN5ldUx9XKXeNdnvWskrqlpbmwlanA/YN0wCm2fDpUxes=;
Message-ID: <4554621d-63da-ea3e-e56a-4e01d0cef347@xen.org>
Date: Thu, 28 Oct 2021 11:05:19 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.2.1
Subject: Re: [patch-4.16] arm/smmuv1,v2: Protect smmu master list with a lock
To: Stefano Stabellini <sstabellini@kernel.org>,
 Julien Grall <julien.grall.oss@gmail.com>
Cc: Michal Orzel <michal.orzel@arm.com>,
 xen-devel <xen-devel@lists.xenproject.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>, Ian Jackson <iwj@xenproject.org>
References: <20211026122903.15042-1-michal.orzel@arm.com>
 <e5632a4e-db98-41b4-1045-2b3532c098fa@xen.org>
 <70c30a6c-b779-805e-079a-41bb484894b9@xen.org>
 <cb452c0c-ccde-7798-c403-f972b48a2c46@arm.com>
 <01545115-e82e-2a9d-a8e4-da9676080c0f@xen.org>
 <alpine.DEB.2.21.2110271557570.20134@sstabellini-ThinkPad-T480s>
 <CAJ=z9a2SSgG7a87_xTGT5LeNLgubOLQf1+dbnrsTsP8_p5ErJg@mail.gmail.com>
 <alpine.DEB.2.21.2110271658330.20134@sstabellini-ThinkPad-T480s>
From: Julien Grall <julien@xen.org>
In-Reply-To: <alpine.DEB.2.21.2110271658330.20134@sstabellini-ThinkPad-T480s>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi Stefano,

First apologies for sending the previous e-mails in HTML (thanks for 
pointing that out!).

On 28/10/2021 01:20, Stefano Stabellini wrote:
> On Thu, 28 Oct 2021, Julien Grall wrote:
>> On Thu, 28 Oct 2021, 00:14 Stefano Stabellini, <sstabellini@kernel.org> wrote:
>>        On Wed, 27 Oct 2021, Julien Grall wrote:
>>        > > > > > +    return ret;
>>        > > > > >    }
>>        > > > > >    static int register_smmu_master(struct arm_smmu_device *smmu,
>>        > > > > > @@ -2056,7 +2066,10 @@ static int arm_smmu_add_device(struct device
>>        > > > > > *dev)
>>        > > > > >        } else {
>>        > > > > >            struct arm_smmu_master *master;
>>        > > > > > +        spin_lock(&arm_smmu_devices_lock);
>>        > > > > >            master = find_smmu_master(smmu, dev->of_node);
>>        > > > > > +        spin_unlock(&arm_smmu_devices_lock);
>>        > > > >
>>        > > > > At the moment, unlocking here is fine because we don't remove the
>>        > > > > device. However, there are a series to supporting removing a device (see
>>        > > > > [1]). So I think it would be preferable to unlock after the last use of
>>        > > > > 'cfg'.
>>        > > > >
>>        > > Ok. I will move unlocking to the end of this else {} block. I was not aware
>>        > > of the patch you are referring to.
>>        >
>>        > I think the end of the else is still too early. This needs to at least be past
>>        > iommu_group_set_iommudata() because we store cfg.
>>        >
>>        > Potentially, the lock wants to also englobe arm_smmu_master_alloc_smes(). So I
>>        > am wondering whether it would be simpler to hold the lock for the whole
>>        > duration of arm_smmu_add_device() (I can see value when we will want to
>>        > interlock with the remove code).
>>
>>        The patch was to protect the smmu master list. From that point of view
>>        the unlock right after find_smmu_master would be sufficient, right?
>>
>>
>> Yes. However this is not fixing all the problems (see below).
>>
>>
>>        We only need to protect cfg if we are worried that the same device is
>>        added in two different ways at the same time. Did I get it right? If so,
>>        I would say that that case should not be possible? Am I missing another
>>        potential conflict?
>>
>>
>> It should not be possible to add the same device twice. The problem is more when we are going to remove the device. In this case, "master"
>> may disappear at any point.
>>
>> The support for removing device is not yet implemented in the tree. But there is already a patch on the ML. So I think it would be
>> shortsighted to only move the lock to just solve concurrent access to the list.
>   
> That makes sense now: the other source of conflict is concurrent add and
> remove of the same device. Sorry it wasn't clear to me before.
At the moment, we are relying on the upper layer (e.g. PCI or DT 
subsystem) to prevent concurrent add/remove/assignment. The trouble is 
we don't have a common lock between PCI and DT.

One possibility would be to add a common in the uper layer, but it feels 
to me this is a bit fragile and may also require longer locking section 
than necessary.

That said, add/remove/assignment operations are meant to be rare. So 
this is could be an option. This would also have the advantage to cover 
all the IOMMUs.

>   
>   
>>        I am pointing this out for two reasons:
>>
>>        Protecting the list is different from protecting each element from
>>        concurrent modification of the element itself. If the latter is a
>>        potential problem, I wonder if arm_smmu_add_device is the only function
>>        affected?
>>
>>
>> I had a brief looked at the code and couldn't find any other places where this may be an issue.
>>
>>
>>        The second reason is that extending the lock past
>>        arm_smmu_master_alloc_smes is a bit worrying because it causes
>>        &arm_smmu_devices_lock and smmu->stream_map_lock to nest, which wasn't
>>        the case before.
>>
>>
>> Nested locks are common. I don't believe there would be a problem here with this one.
>>
>>
>>        I am not saying that it is a bad idea to extend the lock past
>>        arm_smmu_master_alloc_smes -- it might be the right thing to do.
>>
>>
>> I don't usually suggest locking changes blindly ;).
>>
>>        But I
>>
>>        am merely saying that it might be best to think twice about it.
>>
>>        and/or do
>>        that after 4.16.
>>
>>

[...]

> The other thing that is not clear to me is whether we would need also to
> protect places where we use (not allocate) masters and/or cfg, e.g.
> arm_smmu_attach_dev, arm_smmu_domain_add_master.

I think both should be with the lock. Now the question is will other 
IOMMUs driver requires the same locking?

If yes, then maybe that locking should be in the common code.

>> That said we can work towards a new locking approach for 4.17.
>> However, I would want to have a proposal from your side or at least
>> some details on why the suggested locking is not suitable.
>   
> The suggested locking approach up until the last suggestion looks
> totally fine to me. The last suggestion is a bit harder to tell because
> the PCI removal hook is not there yet, so I am having troubles seeing
> exactly what needs to be protected.

The PCI removal hook is the same as the platform device one. There are 
already a patch on the ML (see [1]) for that.

We have two interlocking problem to resolve:
   1) Concurrent request between PCI and platform/DT subsystem
   2) Removal vs add vs (re)assign

The two approaches I can think of are:

Approach A:
   - The driver is responsible to protect against 1)
   - Each subsystem (DT and PCI) are responsible for 2)

Approach B:
   The driver is responsible to protect for 1) 2).

 From my understanding, the proposed patch for Michal is following 
approach A whilst my proposal is going towards approach B.

I am open to use approach A, however I think this needs to be documented 
as the lock to use will depend on whether the device is a PCI device or not.

Cheers,

[1] <1630562763-390068-9-git-send-email-fnu.vikram@xilinx.com>

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Thu Oct 28 10:17:29 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Oct 2021 10:17:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217803.377982 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg2TG-0004rY-Lf; Thu, 28 Oct 2021 10:17:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217803.377982; Thu, 28 Oct 2021 10:17:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg2TG-0004rE-Hd; Thu, 28 Oct 2021 10:17:18 +0000
Received: by outflank-mailman (input) for mailman id 217803;
 Thu, 28 Oct 2021 10:17:17 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=8Bw3=PQ=citrix.com=roger.pau@srs-us1.protection.inumbo.net>)
 id 1mg2TF-0004r8-Gx
 for xen-devel@lists.xenproject.org; Thu, 28 Oct 2021 10:17:17 +0000
Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 392c3aee-37d8-11ec-849d-12813bfff9fa;
 Thu, 28 Oct 2021 10:17:16 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 392c3aee-37d8-11ec-849d-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1635416236;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=J7CX4NDYbpG+cUyO3uFKAvNC07glfsw82SVZwEnYpEw=;
  b=TY6xkrnxSUl+xlOs4nb9Wu8Sm1J8yN5A5Vn00L0wfmgY1o3TXPSHfSrP
   ORtLLMlpEE4Z+3edXKjt1cYOcMrr1wQwfiORTuk+P9OFEzu7VOv++Q5Vf
   2Poczda6LR4yaplaydptp1iunRDOD5G3DHkuAkmCWq1I8Dz6Lx/YOJXRA
   I=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: UmGIX/SdaBhY25QhGWEtlOpFIf8F0DyDVt+Jf7VoKUj9l331FN5v9JAxnq34KfmSSQJ6CVUXmf
 Qh2WfuNnY0zzUhLWkVxQOFqJlXApK/AaXJJkpWh9zujZQhqIQpP4d6Fje2JeKttzdM0AfdDTxm
 Fq+4cSVHOqqNVNW7QMNB/dpQGPzBtYu+Suw2SHuYPYTDfAtpTWUtlbxJEcl/nccKvVFyFKxtTc
 SaxlTb6sbVbUNiUc6AR9m4LoKbjAgYCIaNLywIp4N3/dZZSLuLQe1EfGPyBiU/5rlFlo/MKNjs
 uy1Um9uZqhlAjSnWZEoXfnWF
X-SBRS: 5.1
X-MesageID: 56534845
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:HUl+EavliSf+u0kwhjGii4hIc+fnVLFZMUV32f8akzHdYApBsoF/q
 tZmKWrUb6uPZjH8c9pxOY23oExQ78PdnIVqSwRkrCk2HikQ+JbJXdiXEBz9bniYRiHhoOOLz
 Cm8hv3odp1coqr0/0/1WlTZQP0VOZigHtIQMsadUsxKbVIiGHhJZS5LwbZj29cw24jhWmthh
 PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe
 gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ
 Npls8G2dSE2ebfwmeU5FAtGFhx+Oupp9+qSSZS/mZT7I0zudnLtx7NlDV0sPJ1e8eFyaY1M3
 aVGcnZXNEnF3r/ohuLgIgVvrp1LwM3DJoQQt2sm1TjEJf0nXYrCU+PB4towMDIY254TRqqOO
 5dxhTxHQjLDIBRMPE8rJbERweCS10PDS35IgQfAzUYwyzeKl1EguFT3C/LFd9rPSchLk0Kwo
 mPd43+/EhwcLMaYyzeO7jSrnOCntQT/VYEJHbu07MlDhlGJ23cTAx0bU1i8ifShg0v4UNVaQ
 3H44QJ38/J0rhbyCICgAVvo+xZooyLwRfJWTusGzh7K0JbV4iLeFHYBcz5GL/Mp4ZpeqSMR6
 neFmNbgBDpKubKTSG6A+rr8kQ5eKRT5PkdZOndaFVptD83L5dhp1EqWH4kL/Lud14WtQVnNL
 ya2QD/Sbln5pfUA0Lmn5hj5ijaoq4mhouUdt1iPADzNAu+UYueYi22UBbrzsakowGWxFADpU
 J04dy62t7lm4Xalz3XlfQn1NOv1j8tpyRWF6bKVI7Ev9i6251modp1K7Td1KS9Ba5hfJGS3O
 BWI51IBuPe/2UdGi4csOupd7OxxlMDd+SnNDKiIPrKinLAoLGdrAx2ClWbPhjuwwSDAYIk0O
 IuBcNbEMJrpIf8P8dZCfM9EieVD7nlnnQv7HMmnpzz6gev2TCPEEt8tbQrRBt3VGYvZ+W05B
 f4EbJDUo/ieOcWjChTqHXk7dgFXcyJjX8mq+6S6tIere2JbJY3oMNeIqZsJcI15haVF0ODO+
 3C2QEhDz1Tjw3bALG23hrpLMtsDhL5z8iA2OzICJ1Gt1yRxaIqj9v5HJZA2YaMm5KpoyvstF
 6sJfMCJA/JuTDXb+mtCMcmh/dI6LBn71xiTOyeFYSQke8IyTQL+5dK5LBDk8zMDD3TruJJm8
 aGgzA7SXbEKWx9mUJTNcPuqwl7o5Sodlet+UlHmON5WfEmwooFmJzao1q08It0WKAWFzTyfj
 l7EDRAdrOjLgok07NiW2vzU89b3S7NzRxMIEXPa4LC6MTjh0lCimYIQAvyVeT39VX/v/Pnwb
 +ti0PyhYuYMm0xHstQgHu8zn74+/dbmu5RT0h9gQCfQd12uB75tfiuG0M1IuvEfz7NVo1LrC
 EeG+90cMrSVIsL1VlUWIVN9POiE0PgVnBjU7Og0fxqmtHMmouLfXBUAJQSIhQxcMKBxYdEsz
 uoWscIL7xCy10gxOdGcgyEIr2mBIxTsiUn8Wk321GMztjcW9w==
IronPort-HdrOrdr: A9a23:p21tFqHxgRjzhmd0pLqE1MeALOsnbusQ8zAXPidKOHhom62j5q
 WTdZsgpHzJYVoqOU3I+urvBEDjewK6yXcd2+B4V9qftWHdyQ2VxepZnOnfKlPbexEW39QtrJ
 uJLMNFY+EYd2IUsS9R2njBLz9a+rW6zJw=
X-IronPort-AV: E=Sophos;i="5.87,189,1631592000"; 
   d="scan'208";a="56534845"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=C2D6vA0nNcGLC3MC8yiv68NBDrw0QKUxjix+2PO9H6kyjIyx9MMXFlIN3MA0B3NCXMeuk4pRTB2K3JX/nZlcPutibj4Kbya8vYKzJ6bPdbUjp3qkWxqyCfenSOz51YdCZwF9+q5BkIcGXfCD2/Qd4oVUrOjRzHvFsBSGLaGicHXWtWiwFekF7V4Bt4hyIC2bWo63q0T/94X5qYgm69YtWdlRipUlCNoqozQNt8EchrO8zjshx365c1f4sm5qZgLL7U/vUkDN+Xn7Mm/lj1Qkks3PHKdfgrS5cJfMLAiYcSceDTuDaPeY9bLNKCwN+Ys2QMAN7TC28dV1y90wrZsGzg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=0esejLYCgZOnikz06LoxTp7WD4zGjIBFKxEULQIsOSM=;
 b=OZDQhAmZDnyYOheDkeKhVT5YzvuMH6EeK2y+9GyiX7W391GSRB3XJsTP10oYR001ZlGAXNYEmMA74alGYzc4rDRL0DCRzF05UyJHn00O7NtnyVanrJlRgrz/L2o68OiHgvnsP3U9R8B377Nmq1J2rCr8mhA84EbmA4FFVirnmy3hofWaW4VQ0bIBms7xAeACskBKBZcB4RTb6fqEwj7xEZ2daNgDRW76rrKGQVwvwjabfDL8Qb/fuDwFyOU876om7xIAJG91/bY7b3bIkPOhIDYdbz7tnsm5nV1dq8zOR9S1Aei669UNrh+TIXVGbdhayKpzgSsF3OTPm9tya4oSuw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=0esejLYCgZOnikz06LoxTp7WD4zGjIBFKxEULQIsOSM=;
 b=ty5KU9nR9y4gBTCT1Ie2S233lGQWjvE1xUpJ9z3q3GYlbbGneVHps2SoXeYX7kW3YEFTvgX2OiayCKkEF1LD9NGXJddnj8u3Ub6gtE7KkyMAbvgVXW+m+xjQfjUtc/ggfu9y2aHk8lM9b93+9ctsiydbuWPwx+QbCSMQ42I/m3I=
Date: Thu, 28 Oct 2021 12:17:06 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: vpci: Need for vpci_cancel_pending
Message-ID: <YXp4ovmIsHKTGiw0@Air-de-Roger>
References: <fd1328da-5ad3-62cc-28d6-0ec60e9ea582@epam.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <fd1328da-5ad3-62cc-28d6-0ec60e9ea582@epam.com>
X-ClientProxiedBy: MR1P264CA0040.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:501:3e::11) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: b327ac00-95a1-4f30-45fb-08d999fc1b2f
X-MS-TrafficTypeDiagnostic: DM4PR03MB5999:
X-Microsoft-Antispam-PRVS: <DM4PR03MB5999ED66CB7D4D9A058273EF8F869@DM4PR03MB5999.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: VnTErMV+0qBrAT7EE7IqVFPALvZR7fmk1G9Y4BLb58pLZNWCMhyGXMmVBh0x/MpyxU/uEbFgTVF2loctvjY65R4B/StpOWXppl/lKPDjFwz9kbAj7gPlprpJ0t19GC9YrWVC18xI1xftGwePXEEv2/sUjFUNuLwTcptA+LDr4kcVtc24Pnw7A82rHZLXXLAm0XccNCZLhQj9DxbyjD5hHqf5hINXutt96EnU5UzxVE5PypWymmaKYZPTqIfbBkv+nT04t79xBWNAsI2L2l/E/lywIHb3mLHR2BatCUPvtI+rCVyLJLePeN6LZLMH1iEr44Ll+P1JwAyHEmGCbMUtfidDVXNhP00TOGWuyjhttJ97Hn+tyo2q3FyiVv9rmhIeSQ+ImwCGYcwUD+wdktkbN3dXwLI/3czvdfbxJ0u46iCOUrpIgj5+EF+gR6swLlWgDXFmCSyB35JSRO168A4KohPQBLmI1DViDASXqW4WLd6YTulPA4ALBzt4gvFmG8DFd1+ZjnXnruSRDjlDBjZGPsraUt3qQbDMgz7IYciiEQn4MZJbOAvjEMRK5knAP+/Kgz5hQUdFgFpWuMZ44HTyURGxmSO+99JkD4VfRe0CqQ4PJcqhCKjxjxxVLHT/jeOtyXRdsmbthKTup1c2Zx9cnQ==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(7916004)(366004)(66946007)(66476007)(6496006)(6916009)(316002)(66556008)(83380400001)(5660300002)(82960400001)(33716001)(2906002)(6486002)(85182001)(8936002)(26005)(86362001)(9686003)(38100700002)(956004)(508600001)(4326008)(186003)(6666004)(8676002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VTJSWjFKeGVnYzRqa081S2IwemZ2VzYxT1RtU0F4NTllY05XREJqbHlRc3U3?=
 =?utf-8?B?ZnlRT1VFTE96R1ppNlNKbGJxcEhRblA1Q3FHWmlQbUZEUXFzVkR0TERVL2NN?=
 =?utf-8?B?UHRxTUVrOGxESlZKOXhWQzRxS1BSTFFISlVCektiR0FSNVhqVjgzbzU3cG5F?=
 =?utf-8?B?RENsVUR6QkFLbDNVUHIxdlhDWWxlcG1PWlIvQ1hBK1hjN1Y1WkJsMGl4cGdm?=
 =?utf-8?B?WFI2eFJSend0QktMMlVmUnpCV3VBU2xDVUFjaldxdUtWbDVMTnR3VGZ3MmpC?=
 =?utf-8?B?ZGJZMnN4ZlZCQmZvQWRqNjRjUzk3VHkwVDdzbjI1eUZBK2c3czlsbHBXM0Rm?=
 =?utf-8?B?Qnl5VmJMOEtROEdZRUtlYno5aytXTmwyUmlvZGtWMmZBV0lWZTNvYkFLN3FX?=
 =?utf-8?B?Z09CSFV1YVpYeUd4YXhDUlVhU1lQamdlNW01SU5Id3M0Q2IrbnJrbjB3MFo0?=
 =?utf-8?B?U01FYVFuZ3RUUS9rSkdyVFVoa210ZFZuYjlCVVo1TnVaY3d0eG1Mb0Yxai9J?=
 =?utf-8?B?QkEyQXQ5TjRvQXNQUHUxMUN5MnBUeThNc1ZtRXBGcElCTE0rcTFGWXNHSkFZ?=
 =?utf-8?B?Vm5IeWhjUHBZOVBZczBGSTczYklHQXc2SDEvdHNVRlJIS3k2SHZYb3J6UGk3?=
 =?utf-8?B?ZHNFSTJwbHRabGNNSGZ1Wk1QdzlsNlNGeTByZHhhZnAxanpXcUM1VHpvQk8x?=
 =?utf-8?B?WW1IeFkzNDNIKzVKTUM2MU1xWWhVeHREODBwaTBoTUlTeTE3S0NJLzcyVmJW?=
 =?utf-8?B?QnpRRHQyUDZuSGw4bFhjTHRCVk1GRnJHciswMXcrTGxURXIwYWNtMUFaVk0v?=
 =?utf-8?B?ZGpRS0Y4K2RiQVEwcjNDb1pKV21kZG12NjV5Mk1TYk1ZOHc4cTFiRzMzem5I?=
 =?utf-8?B?QVdDL3U2NnhhcGtzTDJ5WUlCc3dBTFFsbGk1anZMVXhJQ2p4ZU9INDJCWTdV?=
 =?utf-8?B?YUE3VHFJUWlsK0huZHJadzd3eGVxTFBib0IyeGFpcDlKK3VhZnJoQ21ySHh2?=
 =?utf-8?B?Z0dtL043a2s1Q3FycGRBdE4vOThzem5kaFdjQk1VRVNYaDF6UVpFY1crSU5Q?=
 =?utf-8?B?RXZaM2hEZEpoN1g5OGVzc3Y2WXp4SFQwL1piY0VjZFBUYWJyMFcva1VyKzlw?=
 =?utf-8?B?aHlBL20zdmgxczF0TXlGSXM0V00xa0dWVXFTMFpTWk9WWTFCbkZCV0NNNVo3?=
 =?utf-8?B?ZDdmcXRKY0IxL25PNjVleExQR293UldSeXFBVHZkRitlT25FYVU1WXRWaHN5?=
 =?utf-8?B?Z3pQcG01eHFUMURoS2tXRWFpd1RhSEZ6R1AvMDg0NlU1YWVlOW5oZHJyN3o3?=
 =?utf-8?B?R2tFZkJMT3h5aFJVM0x3VXZiNVRQTlg5azNVL2hJZXg5aEUycVBwcHJUNzR2?=
 =?utf-8?B?T3ZnM0U4aFJsQ2d3Zk9STGF0b0JvMjF6bTdpalA1aDkra1VlbzJSamtDdEdR?=
 =?utf-8?B?SStvRjYwMWMyNld3Z2tiVytOQzJJbnFyYmZ4ZXVpVlR6amZ4eGRvN1BUb1Jv?=
 =?utf-8?B?UXlDV09WQ1djS210a1RSQ1RuR0VKbFYxQUZmUDFpRHNoLzZ1aFBBTjZWVkQx?=
 =?utf-8?B?SlVZdkh5cmJuaFRWV091YU11ckVVMjZzcHRwaFlDVVBWR2gzQ1dpcDhvTlcw?=
 =?utf-8?B?d1g1NCtUZ0dXWVJvc0pjM3BUbWtkeVpsN3B5MkJyYlJSWjJuK3d0cUdNcXE4?=
 =?utf-8?B?SFVhSllLeG84bnZSWDMvMzY3U0JBZmd2U1o0OXhyQnQ2MDBIWUxUenF4T3Vu?=
 =?utf-8?B?UEJpT21iQWNtOW9MOWRheS81Z2ZOcVV4RzdKUlQwWUhIaUduZGcwQUJvMEdD?=
 =?utf-8?B?aGxpM2xabWlodVFrakNidWMyWlB2UE5TYXV3SDVOSkFETWUxeEFpV05XVDJv?=
 =?utf-8?B?ekpzVXZnS1M5SXhnWGh0a2h5MDZ1SlFnaDV5Z1FWRmV4MEFIOFoxTGRtVE5n?=
 =?utf-8?B?dE1SbTUxOCtmeE1TY0swbG0xLy8vL000T040b0FiazZ0Z2dFQVp6bGdnMzNE?=
 =?utf-8?B?RjJZdjFYTmtDS0xBUlVRVWpFT0VFdkxsdTlJVmFGSnJ0U0RUZGpxNS9CVjla?=
 =?utf-8?B?MHpCbDFkTUxLbGduQlc2ZTNkamo1YU94dkNFeGtkVWN2b3JjQ1Uwb2NFNVR0?=
 =?utf-8?B?V0VjQk9qS21uOTg5SHlPc3l0VFJGRGx1UGlWbE9SQkNySHIzd2p1NUM5Kzkw?=
 =?utf-8?Q?PkEOpEKDceVYPRIU4M/BLRE=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: b327ac00-95a1-4f30-45fb-08d999fc1b2f
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Oct 2021 10:17:11.7771
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2ocC7IjyxDnKcTQBwKZQAQ45CmEAXzpeR01b7f4W7g5rw4xLyFscvVjwUQBhoiK8qAkCLSr/GXp3EfTV4hfYrQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR03MB5999
X-OriginatorOrg: citrix.com

On Thu, Oct 28, 2021 at 10:04:20AM +0000, Oleksandr Andrushchenko wrote:
> Hi, all!
> 
> While working on PCI passthrough on Arm I stepped onto a crash
> with the following call chain:
> 
> pci_physdev_op
>    pci_add_device
>        init_bars -> modify_bars -> defer_map -> raise_softirq(SCHEDULE_SOFTIRQ)
>    iommu_add_device <- FAILS
>    vpci_remove_device -> xfree(pdev->vpci)
> 
> Then:
> leave_hypervisor_to_guest
>    vpci_process_pending: v->vpci.mem != NULL; v->vpci.pdev->vpci == NULL
> 
> Which results in the crash below:
> 
> (XEN) Data Abort Trap. Syndrome=0x6
> (XEN) Walking Hypervisor VA 0x10 on CPU0 via TTBR 0x00000000481dd000
> (XEN) 0TH[0x0] = 0x00000000481dcf7f
> (XEN) 1ST[0x0] = 0x00000000481d9f7f
> (XEN) 2ND[0x0] = 0x0000000000000000
> (XEN) CPU0: Unexpected Trap: Data Abort
> ...
> (XEN) Xen call trace:
> (XEN)    [<00000000002246d8>] _spin_lock+0x40/0xa4 (PC)
> (XEN)    [<00000000002246c0>] _spin_lock+0x28/0xa4 (LR)
> (XEN)    [<000000000024f6d0>] vpci_process_pending+0x78/0x128
> (XEN)    [<000000000027f7e8>] leave_hypervisor_to_guest+0x50/0xcc
> (XEN)    [<0000000000269c5c>] entry.o#guest_sync_slowpath+0xa8/0xd4
> 
> So, it seems that if pci_add_device fails and calls vpci_remove_device
> the later needs to cancel any pending work.

Indeed, you will need to check that v->vpci.pdev == pdev before
canceling the pending work though, or else you could be canceling
pending work from a different device.

> If this is a map operation it seems to be straightforward: destroy
> the range set and do not map anything.
> 
> If vpci_remove_device is called and unmap operation was scheduled
> then it can be that:
> - guest is being destroyed for any reason and skipping unmap is ok
>    as all the mappings for the whole domain will be destroyed anyways
> - guest is still going to stay alive and then unmapping must be done
> 
> I would like to hear your thought what would be the right approach
> to take in order to solve the issue.

For the hardware domain it's likely better to do nothing, and just try
to continue execution. The worse that could happen is that MMIO mappings
are left in place when the device has been deassigned.

For unprivileged domains that get a failure in the middle of a vPCI
{un}map operation we need to destroy them, as we don't know in which
state the p2m is. This can only happen in vpci_process_pending for
domUs I think, as they won't be allowed to call pci_add_device. Please
see the FIXME in vpci_process_pending related to this topic.

Regards, Roger.


From xen-devel-bounces@lists.xenproject.org Thu Oct 28 10:25:49 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Oct 2021 10:25:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217812.377992 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg2bH-0006QM-J2; Thu, 28 Oct 2021 10:25:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217812.377992; Thu, 28 Oct 2021 10:25:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg2bH-0006QF-Fx; Thu, 28 Oct 2021 10:25:35 +0000
Received: by outflank-mailman (input) for mailman id 217812;
 Thu, 28 Oct 2021 10:25:34 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ikAZ=PQ=epam.com=prvs=19352d112c=oleksandr_andrushchenko@srs-us1.protection.inumbo.net>)
 id 1mg2bG-0006Q9-JT
 for xen-devel@lists.xenproject.org; Thu, 28 Oct 2021 10:25:34 +0000
Received: from mx0b-0039f301.pphosted.com (unknown [148.163.137.242])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 61a69c0c-37d9-11ec-849d-12813bfff9fa;
 Thu, 28 Oct 2021 10:25:32 +0000 (UTC)
Received: from pps.filterd (m0174682.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 19S9SRa6013270; 
 Thu, 28 Oct 2021 10:25:31 GMT
Received: from eur02-ve1-obe.outbound.protection.outlook.com
 (mail-ve1eur02lp2050.outbound.protection.outlook.com [104.47.6.50])
 by mx0b-0039f301.pphosted.com with ESMTP id 3bydxahtth-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Thu, 28 Oct 2021 10:25:31 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by VI1PR0302MB2831.eurprd03.prod.outlook.com (2603:10a6:800:e4::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.18; Thu, 28 Oct
 2021 10:25:28 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::c038:e032:595a:651]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::c038:e032:595a:651%9]) with mapi id 15.20.4649.015; Thu, 28 Oct 2021
 10:25:28 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 61a69c0c-37d9-11ec-849d-12813bfff9fa
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=CRvibzKcaVYrZDD9nhv1r9lfHWpm/gO3q71IYn53l/slajJkfx4OwdaSZ3n74OP90vxikzxJ/lYPQ3uqk6pJVWMXMHO+aqnBDwuO2giUi8ppRYfEeSN+UtDMjT5/hZMSoPRvSFJoGAhNKzAdFjt26u1Rufr1tDXI8tVbIlJG3ZTKOwr9ga6CUopuAkOfo/XKknFNEWc85rilgss/Anu0BJgZ8iN1i7djs+tWv8uPyiXtP71Kreq1WAHc0LgWOdHarCCWQjPXd1c+tF7kYvH1+qzXskM4OrnHxk0Eb+2Y2mGI6gm0AqXIhCOK8/gTX83YMk+vqm48CbWJtmYSmsrVUA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=6opf6qcZt0dnnlbGzapi+zs3MS7pr9vRfRnGsTuvFVk=;
 b=e46f6VZHTBJWp1iXcgoIkWQiRSg01/lDRyXT6EDgffUlH/lQVfR699SE26G05lPo+1MSOb4XEOlWfcuX5KJbEA/PJJhUEI6EEn2R4GLyaLKYc3Tcyki30rY+NvJr2FJ24VTgqomCEZ8y7vOkeAEn6FGMnNQsNQAx902Jkvt8sdw9gjUGmlItyJoh4qmpqII1//+L9vjKauydm9uCeZ0s8f+F4SlXWGtEFGuT0JSpVCfLx4/wZn9uRzDG9+QCXvKa2f1RxQaSDTkQHiLxNj9CyWthaiNaaqxOaA2OuZCQC+6hZ5VzJsM5cFXEM8vosZjeGrxUWbqA+8aN+1ziSILj9g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=6opf6qcZt0dnnlbGzapi+zs3MS7pr9vRfRnGsTuvFVk=;
 b=046bH1glEISu5/PwBJ4cQkfJMiBG3Sf6TBhwjw6WQIEDZ6ANg6Sa67YfAf6z8mKLw8bWuzbe8VXhbij5P0nvXUlx3AhI+lZ36EPuCgRrlyre5NqJkKKsDa0YTnmf5skSB8HCiA591Juqi1/07b+AT0jemDJ8ZHoFIIMiV7ZOe/YlLc8tFsZp3KaLGRZlAkjd8k45QgWl15R/QIuEKQNbYmg3JRZ+VdVe+i75HE5VUAgZa/dJf5gG8AuPH2scZQ7acUfcWV3dA32VXhB43+9jTkCavZYqn+usSR3uHo4cGaJfPxyWDz/n2sQ6Wb+MYN/V2/oX1pJEyhxdWYs7/qwH1Q==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
Subject: Re: vpci: Need for vpci_cancel_pending
Thread-Topic: vpci: Need for vpci_cancel_pending
Thread-Index: AQHXy+MtilSp1e2bsUu2TEgvHf6jsavoMiQAgAACRgA=
Date: Thu, 28 Oct 2021 10:25:28 +0000
Message-ID: <9eca8f0d-ca4c-696c-5ce8-4073033f59cc@epam.com>
References: <fd1328da-5ad3-62cc-28d6-0ec60e9ea582@epam.com>
 <YXp4ovmIsHKTGiw0@Air-de-Roger>
In-Reply-To: <YXp4ovmIsHKTGiw0@Air-de-Roger>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 3b9a55d2-1b96-4772-cd3f-08d999fd436c
x-ms-traffictypediagnostic: VI1PR0302MB2831:
x-microsoft-antispam-prvs: 
 <VI1PR0302MB283187E275EF357355D60348E7869@VI1PR0302MB2831.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 x3G9mY07rxg38y9sHTwGpzPau9R3D+GTS8nBFVS5zAGC3Pz2xdEi5VmrrcymRVDl0bDj9MH8OvG5bmErtNsL7FxSOUYCYZ+V1DWukEyvvDd1wFz+wl6yhFwTITjZbXMMydV0MrMKr+49kpd9KG6r1awiyOVRkmYwCtwe5vnm+TJYnym4jM4zYf+vyZ++vhs8eTqvoxL8ONY0QCLDxCILVa7vC3DPgjEWka4g7DCaR9SPzh7jgRKhV9tH7LpT8Udj8gQcj4JeIThnqOD7cRBW/aND6mciGtbAL7VdSP94ynhoJ8csMbdlg/uTSWu2Te38FXpr77iTXbcfukWJRQnpdLFj+XM+uRt0JvCKeX7N0RbKj+WOLGHnLNr8JKlofQo9F/E6EJNCeJtT0GrEcwqraA53A5ddheEd1ODHCNwzAFKc3Xbj+3LrvXnTjkMh0U1KfI8g30ZTXeE8OaHoh2v/lqzbB1FesBQ8K0ajbdS5mpT4lNjjBFWkr5NEqHSLpyTaHr+rNESBrhBvCbrTcFiMJuQGO8xjvS4BQu+qNmbQB4JMSmOdodrQG9h0j0tiGBKMNVnIVr454xcjPPUpQQdVAPzx37LGP7hBgpDyCjWEj38F//kqwzr50soAZkSZivNX46RbNtroiKTYUGbTxPTHGLPbbaWYp3CPR2wLza6CjbMqsPCI4ZS/GtSQrd6b25K06RwKiXJretmgKguwr593sCrqdeMESUTsriIlAGhDctwgfBSTVW9xkB7J1aKFV/J/
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(66946007)(38100700002)(8676002)(76116006)(5660300002)(64756008)(53546011)(6916009)(66446008)(6506007)(66556008)(36756003)(2906002)(55236004)(31696002)(4326008)(107886003)(66476007)(122000001)(316002)(508600001)(6486002)(26005)(8936002)(31686004)(54906003)(38070700005)(2616005)(83380400001)(86362001)(71200400001)(186003)(6512007)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?ZGdYeVkrSSsveGhJV1lUSnliMWpFckhRZGdtSFZSU0d4UWJFS2RCRGhSdVY5?=
 =?utf-8?B?Nk51cnhHTGZBdW9BREFGRlRDbDljb2VZamZ5MlRoREg1UitYNWNKU1MxVnRp?=
 =?utf-8?B?N3g2UGJCMEI5VXZoNnJod1BJQ21ZTkYxdFF0bTRqOGlzbGZGdEJQSER3dGFL?=
 =?utf-8?B?M0ZvajVpL3lFV2F1ZVVhb1dTcDNUemJPVGZyeXc3elVoRjMwTWNoT0l0Z1o0?=
 =?utf-8?B?QjM2SEJMWjZhWWlTTVlSa1FmVmE2ZjY3a0tWYzU5MDBGTklRdGJNN3orc0hP?=
 =?utf-8?B?TkZid3VKRHFOQlowQW9GcFR1N1g3QVYvQzRGR1B3SUFUZVd5bTAvNjQvMFVZ?=
 =?utf-8?B?VDJYZzl3REZUU1lwckkrMG45U2FTOE82Z0IyWGtDZHZqTGR1eWorWGlmNG9r?=
 =?utf-8?B?MUpqUWZRcWRPR3AwcXU1aTdOSEFiZGl4TlVweGppV3NHNWpIY3hTcnBxckl4?=
 =?utf-8?B?ZzBaa1pCUVVoOCsxUDVDM1o5RU1kMlZpc1RPU091L09jUmdlZE5IM2JicXFx?=
 =?utf-8?B?bVFza0h2UVlIOHgxL2k0bWlMVGhUbVBUdnM4WWZLNndkRWxyVWlxSWROWktR?=
 =?utf-8?B?M3l4Yk1Jd1pCb3hJc1F6SzZ4REsvYU4yLzc1RjRvSmQ2Tkt1ZWhlNEMvdG9M?=
 =?utf-8?B?TG1lVDZYVS9lVHA2Q1d3aXRFMTE5TEhKWDVMZW5ZbjlxbzJGcUFkaGlEQ3Ny?=
 =?utf-8?B?WjdrVTVBRHozRFpiZjN2MEV0ZHBmQ3l0T2RrV3ozMElWaC82VldMV081ZHNR?=
 =?utf-8?B?TFBBZC9sdmtLTHRpY2o4NFdsRkVyK255Zng2MERWSzVEeG5yOVJtcHFiTkUx?=
 =?utf-8?B?TmJsSXZNaC9nTU1zMEhubGQzaVhxL2JWWUxZWUdqYjdlZk9QenBYY2lWY1lw?=
 =?utf-8?B?ZUFueDVXdUFRRktmKy9ZcFZUdFNKOXZXcXRRanBTbDloSncrRVUxK0xOMVIw?=
 =?utf-8?B?MVBoUDR6MldwaDBNT2IxSzBjVWZ2S0R4TjltcUpWQlZkZ0ExWmNnV0ZqNXJT?=
 =?utf-8?B?TVNScVBYL05pMVp4WHRieHhrRWN1OXo5SzBYZUEzVzV6eG5scHRSVXZUTits?=
 =?utf-8?B?Yk5IMmNsSkNzTzFqaWR1U0RKbXhJQkhrL3lpeDdwcnBtSXdXeTArQ0dBM3ZV?=
 =?utf-8?B?VEJzTU5aYnNuWTdUbEozWnRIVVp6OEsrdHFaTjdMbDRiV2RZK3ZoeUg1aHJz?=
 =?utf-8?B?NklzMTBtVkV0YlJ4cjRCY3lKQUhZM2VKR3NreUJpWlZGb05YY0VUdWhIQmNL?=
 =?utf-8?B?NFZyZE95M2Iyc2duSkp0MU1KK2s0MThUVXBSWkhDakR1WEJNOURqenFrOFFN?=
 =?utf-8?B?amc2T3R5MmZaei9aUDJINTYrSXptMWhaMldETTRuSnd6V2k5dXN2eGhXMkd1?=
 =?utf-8?B?L1pQMmZCTDdZSFdTTXJFdHdXWWRGd1BmMjBDbk1kak5rY2RpMDVtQ0RtcUY5?=
 =?utf-8?B?QU8wSVZaT2xoV25UK0lhRWEzV01qWEs3ZEk1MFlrL0dBRk1BSHNHL202OUNi?=
 =?utf-8?B?bC94K213Uk5uQjJVU0g1ODBoaTMwYzU3cys5TWtsUkR0Zkpab0JxSDd2TGhL?=
 =?utf-8?B?dHVwN3RpNFNZMjBtNVpmOVozdUZXZDQ3aDB0L0I4dEFveEsxNkp5Ynl6S0JZ?=
 =?utf-8?B?MnNCRjlxM2ZHZlhKTlVxR2lUdUFSUjc1SWozeWdRNUJXUll0elRJTTVaZmp1?=
 =?utf-8?B?NXVkNXpvZWpxbmV3RDJJK0xRclBnNitCSXlpZ2JXRVVYWm5HQXBPa2h3R1Yy?=
 =?utf-8?B?VGk5eStDbDNOK0dtUENQN3VqMXNCVDA2WlF4aWorU2ZKOGl4Zytxd3FwYkcz?=
 =?utf-8?B?R2VuNHNVblQvVFNkbVFhWTc3ZXJlOURnaTJTYTVaUzlPalBkS09hL055TitV?=
 =?utf-8?B?SkE2MHoxaDc0Ly9IV3EwTWFLUkhPWmE0N3Bkd2NxV28wZy8vakxzdmlrT21o?=
 =?utf-8?B?VUx0cFJ5QU0zYlNCK3VackhZWFVuMTY5Zi9oaXlnZERMeDZOYitHL0FtcnE4?=
 =?utf-8?B?R05RUnB2NVBac2dJZjNWWkpnWFNnU0oxQmlHTVU5azEwd1ZidUdiSW1abHhr?=
 =?utf-8?B?TG0rS0EvOUYzUWc3cDNNVG1SYk1wLzAvaUV4SzJaMUlJL295WERaUURGRXhS?=
 =?utf-8?B?Ym9NR28yV1IrVXgwREk2THl4eGZXTi9kSjN0NGdMcDR3cFFBb3NjOW5MUXRn?=
 =?utf-8?B?QjdXMTNiU3JIZDQ2SHNiL29UM3YyWXNHRnh6dTVTZmlSSklvdDJkQnRTSVcz?=
 =?utf-8?B?dDNQQjZFdFByektxbTdhTXlaMTZxV2dHcjU5akpWWmkxWHdPbkkyZDE0YTdO?=
 =?utf-8?B?Z09CcjJoSnRLZ2Jib2N1OVhPZWNkZmhFZDZncWhFTmZDOWVLRmdQdz09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <41FC9834D2E2344686D53FE5DC960945@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3b9a55d2-1b96-4772-cd3f-08d999fd436c
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Oct 2021 10:25:28.6008
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: vIruqOAnEvBSlk71vkheavGuu5vxJwn4JknKkATUjn+2s1brKuELWE4QKDsOcpmLtINiVdNR0OnwqdV2HAaLp2cfjCAJdb9yTddy2Kk/evh190AFFwhscvpR7l+4f/1B
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0302MB2831
X-Proofpoint-GUID: H3bossY9MqdK-5cRBt6jG8Nq4drz-MJa
X-Proofpoint-ORIG-GUID: H3bossY9MqdK-5cRBt6jG8Nq4drz-MJa
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475
 definitions=2021-10-28_01,2021-10-26_01,2020-04-07_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=826
 impostorscore=0 phishscore=0 mlxscore=0 malwarescore=0 spamscore=0
 suspectscore=0 bulkscore=0 priorityscore=1501 lowpriorityscore=0
 clxscore=1015 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2110280057

DQoNCk9uIDI4LjEwLjIxIDEzOjE3LCBSb2dlciBQYXUgTW9ubsOpIHdyb3RlOg0KPiBPbiBUaHUs
IE9jdCAyOCwgMjAyMSBhdCAxMDowNDoyMEFNICswMDAwLCBPbGVrc2FuZHIgQW5kcnVzaGNoZW5r
byB3cm90ZToNCj4+IEhpLCBhbGwhDQo+Pg0KPj4gV2hpbGUgd29ya2luZyBvbiBQQ0kgcGFzc3Ro
cm91Z2ggb24gQXJtIEkgc3RlcHBlZCBvbnRvIGEgY3Jhc2gNCj4+IHdpdGggdGhlIGZvbGxvd2lu
ZyBjYWxsIGNoYWluOg0KPj4NCj4+IHBjaV9waHlzZGV2X29wDQo+PiAgIMKgIHBjaV9hZGRfZGV2
aWNlDQo+PiAgIMKgIMKgwqAgwqBpbml0X2JhcnMgLT4gbW9kaWZ5X2JhcnMgLT4gZGVmZXJfbWFw
IC0+IHJhaXNlX3NvZnRpcnEoU0NIRURVTEVfU09GVElSUSkNCj4+ICAgwqAgaW9tbXVfYWRkX2Rl
dmljZSA8LSBGQUlMUw0KPj4gICDCoCB2cGNpX3JlbW92ZV9kZXZpY2UgLT4geGZyZWUocGRldi0+
dnBjaSkNCj4+DQo+PiBUaGVuOg0KPj4gbGVhdmVfaHlwZXJ2aXNvcl90b19ndWVzdA0KPj4gICDC
oCB2cGNpX3Byb2Nlc3NfcGVuZGluZzogdi0+dnBjaS5tZW0gIT0gTlVMTDsgdi0+dnBjaS5wZGV2
LT52cGNpID09IE5VTEwNCj4+DQo+PiBXaGljaCByZXN1bHRzIGluIHRoZSBjcmFzaCBiZWxvdzoN
Cj4+DQo+PiAoWEVOKSBEYXRhIEFib3J0IFRyYXAuIFN5bmRyb21lPTB4Ng0KPj4gKFhFTikgV2Fs
a2luZyBIeXBlcnZpc29yIFZBIDB4MTAgb24gQ1BVMCB2aWEgVFRCUiAweDAwMDAwMDAwNDgxZGQw
MDANCj4+IChYRU4pIDBUSFsweDBdID0gMHgwMDAwMDAwMDQ4MWRjZjdmDQo+PiAoWEVOKSAxU1Rb
MHgwXSA9IDB4MDAwMDAwMDA0ODFkOWY3Zg0KPj4gKFhFTikgMk5EWzB4MF0gPSAweDAwMDAwMDAw
MDAwMDAwMDANCj4+IChYRU4pIENQVTA6IFVuZXhwZWN0ZWQgVHJhcDogRGF0YSBBYm9ydA0KPj4g
Li4uDQo+PiAoWEVOKSBYZW4gY2FsbCB0cmFjZToNCj4+IChYRU4pwqDCoMKgIFs8MDAwMDAwMDAw
MDIyNDZkOD5dIF9zcGluX2xvY2srMHg0MC8weGE0IChQQykNCj4+IChYRU4pwqDCoMKgIFs8MDAw
MDAwMDAwMDIyNDZjMD5dIF9zcGluX2xvY2srMHgyOC8weGE0IChMUikNCj4+IChYRU4pwqDCoMKg
IFs8MDAwMDAwMDAwMDI0ZjZkMD5dIHZwY2lfcHJvY2Vzc19wZW5kaW5nKzB4NzgvMHgxMjgNCj4+
IChYRU4pwqDCoMKgIFs8MDAwMDAwMDAwMDI3ZjdlOD5dIGxlYXZlX2h5cGVydmlzb3JfdG9fZ3Vl
c3QrMHg1MC8weGNjDQo+PiAoWEVOKcKgwqDCoCBbPDAwMDAwMDAwMDAyNjljNWM+XSBlbnRyeS5v
I2d1ZXN0X3N5bmNfc2xvd3BhdGgrMHhhOC8weGQ0DQo+Pg0KPj4gU28sIGl0IHNlZW1zIHRoYXQg
aWYgcGNpX2FkZF9kZXZpY2UgZmFpbHMgYW5kIGNhbGxzIHZwY2lfcmVtb3ZlX2RldmljZQ0KPj4g
dGhlIGxhdGVyIG5lZWRzIHRvIGNhbmNlbCBhbnkgcGVuZGluZyB3b3JrLg0KPiBJbmRlZWQsIHlv
dSB3aWxsIG5lZWQgdG8gY2hlY2sgdGhhdCB2LT52cGNpLnBkZXYgPT0gcGRldiBiZWZvcmUNCj4g
Y2FuY2VsaW5nIHRoZSBwZW5kaW5nIHdvcmsgdGhvdWdoLCBvciBlbHNlIHlvdSBjb3VsZCBiZSBj
YW5jZWxpbmcNCj4gcGVuZGluZyB3b3JrIGZyb20gYSBkaWZmZXJlbnQgZGV2aWNlLg0KSG93IGFi
b3V0Og0KDQp2b2lkIHZwY2lfY2FuY2VsX3BlbmRpbmcoc3RydWN0IHBjaV9kZXYgKnBkZXYpDQp7
DQogwqDCoMKgIHN0cnVjdCB2Y3B1ICp2ID0gY3VycmVudDsNCg0KIMKgwqDCoCBpZiAoIHYtPnZw
Y2kubWVtICYmIHYtPnZwY2kucGRldiA9PSBwZGV2KQ0KIMKgwqDCoCB7DQogwqDCoMKgwqDCoMKg
wqAgcmFuZ2VzZXRfZGVzdHJveSh2LT52cGNpLm1lbSk7DQogwqDCoMKgwqDCoMKgwqAgdi0+dnBj
aS5tZW0gPSBOVUxMOw0KIMKgwqDCoCB9DQp9DQoNClRoaXMgd2lsbCBlZmZlY3RpdmVseSBwcmV2
ZW50IHRoZSBwZW5kaW5nIHdvcmsgZnJvbSBydW5uaW5nDQo+DQo+PiBJZiB0aGlzIGlzIGEgbWFw
IG9wZXJhdGlvbiBpdCBzZWVtcyB0byBiZSBzdHJhaWdodGZvcndhcmQ6IGRlc3Ryb3kNCj4+IHRo
ZSByYW5nZSBzZXQgYW5kIGRvIG5vdCBtYXAgYW55dGhpbmcuDQo+Pg0KPj4gSWYgdnBjaV9yZW1v
dmVfZGV2aWNlIGlzIGNhbGxlZCBhbmQgdW5tYXAgb3BlcmF0aW9uIHdhcyBzY2hlZHVsZWQNCj4+
IHRoZW4gaXQgY2FuIGJlIHRoYXQ6DQo+PiAtIGd1ZXN0IGlzIGJlaW5nIGRlc3Ryb3llZCBmb3Ig
YW55IHJlYXNvbiBhbmQgc2tpcHBpbmcgdW5tYXAgaXMgb2sNCj4+ICAgwqAgYXMgYWxsIHRoZSBt
YXBwaW5ncyBmb3IgdGhlIHdob2xlIGRvbWFpbiB3aWxsIGJlIGRlc3Ryb3llZCBhbnl3YXlzDQo+
PiAtIGd1ZXN0IGlzIHN0aWxsIGdvaW5nIHRvIHN0YXkgYWxpdmUgYW5kIHRoZW4gdW5tYXBwaW5n
IG11c3QgYmUgZG9uZQ0KPj4NCj4+IEkgd291bGQgbGlrZSB0byBoZWFyIHlvdXIgdGhvdWdodCB3
aGF0IHdvdWxkIGJlIHRoZSByaWdodCBhcHByb2FjaA0KPj4gdG8gdGFrZSBpbiBvcmRlciB0byBz
b2x2ZSB0aGUgaXNzdWUuDQo+IEZvciB0aGUgaGFyZHdhcmUgZG9tYWluIGl0J3MgbGlrZWx5IGJl
dHRlciB0byBkbyBub3RoaW5nLCBhbmQganVzdCB0cnkNCj4gdG8gY29udGludWUgZXhlY3V0aW9u
LiBUaGUgd29yc2UgdGhhdCBjb3VsZCBoYXBwZW4gaXMgdGhhdCBNTUlPIG1hcHBpbmdzDQo+IGFy
ZSBsZWZ0IGluIHBsYWNlIHdoZW4gdGhlIGRldmljZSBoYXMgYmVlbiBkZWFzc2lnbmVkLg0KPg0K
PiBGb3IgdW5wcml2aWxlZ2VkIGRvbWFpbnMgdGhhdCBnZXQgYSBmYWlsdXJlIGluIHRoZSBtaWRk
bGUgb2YgYSB2UENJDQo+IHt1bn1tYXAgb3BlcmF0aW9uIHdlIG5lZWQgdG8gZGVzdHJveSB0aGVt
LCBhcyB3ZSBkb24ndCBrbm93IGluIHdoaWNoDQo+IHN0YXRlIHRoZSBwMm0gaXMuIFRoaXMgY2Fu
IG9ubHkgaGFwcGVuIGluIHZwY2lfcHJvY2Vzc19wZW5kaW5nIGZvcg0KPiBkb21VcyBJIHRoaW5r
LCBhcyB0aGV5IHdvbid0IGJlIGFsbG93ZWQgdG8gY2FsbCBwY2lfYWRkX2RldmljZS4gUGxlYXNl
DQo+IHNlZSB0aGUgRklYTUUgaW4gdnBjaV9wcm9jZXNzX3BlbmRpbmcgcmVsYXRlZCB0byB0aGlz
IHRvcGljLg0KQWdyZWUNCj4NCj4gUmVnYXJkcywgUm9nZXIuDQo+DQpUaGFuayB5b3UsDQpPbGVr
c2FuZHI=


From xen-devel-bounces@lists.xenproject.org Thu Oct 28 10:28:42 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Oct 2021 10:28:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217820.378005 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg2eH-000769-4K; Thu, 28 Oct 2021 10:28:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217820.378005; Thu, 28 Oct 2021 10:28:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg2eG-000762-Ul; Thu, 28 Oct 2021 10:28:40 +0000
Received: by outflank-mailman (input) for mailman id 217820;
 Thu, 28 Oct 2021 10:28:39 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mg2eE-00075q-Us; Thu, 28 Oct 2021 10:28:38 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mg2eE-00055g-Nc; Thu, 28 Oct 2021 10:28:38 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mg2eE-00027P-DB; Thu, 28 Oct 2021 10:28:38 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mg2eE-0000mf-Ch; Thu, 28 Oct 2021 10:28:38 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=gD8CaqCBpQAtPItBvvYc31jxObUtBgM9m/da6Omnogg=; b=DaS++6fx3Anr3i9uxXrWo+4vcL
	UeMQ0xAlbAX/SGxdH4oCUr/NV9f1DLY7Ky17oAfKnUH80NgJd+1lXE+oTQnS1zkXkQrLIDri6HSrS
	uwCVcH4GPOU2pJisRuQh+sqU6BmYqQ3VBMPhHqZ97OSTLjVfbUOpOYkLOKZDFiIIOo4w=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165922-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 165922: regressions - FAIL
X-Osstest-Failures:
    libvirt:build-armhf-libvirt:libvirt-build:fail:regression
    libvirt:build-amd64-libvirt:libvirt-build:fail:regression
    libvirt:build-i386-libvirt:libvirt-build:fail:regression
    libvirt:build-arm64-libvirt:libvirt-build:fail:regression
    libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    libvirt=ed87c62c2bdbfa35e08195c0573dc8f46e866167
X-Osstest-Versions-That:
    libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 28 Oct 2021 10:28:38 +0000

flight 165922 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165922/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-armhf-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-amd64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-i386-libvirt            6 libvirt-build            fail REGR. vs. 151777
 build-arm64-libvirt           6 libvirt-build            fail REGR. vs. 151777

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-libvirt-vhd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a

version targeted for testing:
 libvirt              ed87c62c2bdbfa35e08195c0573dc8f46e866167
baseline version:
 libvirt              2c846fa6bcc11929c9fb857a22430fb9945654ad

Last test of basis   151777  2020-07-10 04:19:19 Z  475 days
Failing since        151818  2020-07-11 04:18:52 Z  474 days  460 attempts
Testing same since   165922  2021-10-28 04:20:15 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
    Adolfo Jayme Barrientos <fitoschido@gmail.com>
  Aleksandr Alekseev <alexander.alekseev@virtuozzo.com>
  Aleksei Zakharov <zaharov@selectel.ru>
  Andika Triwidada <andika@gmail.com>
  Andrea Bolognani <abologna@redhat.com>
  Ani Sinha <ani@anisinha.ca>
  Balázs Meskó <meskobalazs@mailbox.org>
  Barrett Schonefeld <bschoney@utexas.edu>
  Bastian Germann <bastiangermann@fishpost.de>
  Bastien Orivel <bastien.orivel@diateam.net>
  BiaoXiang Ye <yebiaoxiang@huawei.com>
  Bihong Yu <yubihong@huawei.com>
  Binfeng Wu <wubinfeng@huawei.com>
  Bjoern Walk <bwalk@linux.ibm.com>
  Boris Fiuczynski <fiuczy@linux.ibm.com>
  Brian Turek <brian.turek@gmail.com>
  Bruno Haible <bruno@clisp.org>
  Chris Mayo <aklhfex@gmail.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Ehrhardt <christian.ehrhardt@canonical.com>
  Christian Kirbach <christian.kirbach@gmail.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Cole Robinson <crobinso@redhat.com>
  Collin Walling <walling@linux.ibm.com>
  Cornelia Huck <cohuck@redhat.com>
  Cédric Bosdonnat <cbosdonnat@suse.com>
  Côme Borsoi <fedora@borsoi.fr>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniel Letai <dani@letai.org.il>
  Daniel P. Berrange <berrange@redhat.com>
  Daniel P. Berrangé <berrange@redhat.com>
  Didik Supriadi <didiksupriadi41@gmail.com>
  dinglimin <dinglimin@cmss.chinamobile.com>
  Dmitrii Shcherbakov <dmitrii.shcherbakov@canonical.com>
  Dmytro Linkin <dlinkin@nvidia.com>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Eric Farman <farman@linux.ibm.com>
  Erik Skultety <eskultet@redhat.com>
  Fabian Affolter <mail@fabian-affolter.ch>
  Fabian Freyer <fabian.freyer@physik.tu-berlin.de>
  Fabiano Fidêncio <fabiano@fidencio.org>
  Fangge Jin <fjin@redhat.com>
  Farhan Ali <alifm@linux.ibm.com>
  Fedora Weblate Translation <i18n@lists.fedoraproject.org>
  Franck Ridel <fridel@protonmail.com>
  Gavi Teitz <gavi@nvidia.com>
  gongwei <gongwei@smartx.com>
  Guoyi Tu<tu.guoyi@h3c.com>
  Göran Uddeborg <goeran@uddeborg.se>
  Halil Pasic <pasic@linux.ibm.com>
  Han Han <hhan@redhat.com>
  Hao Wang <wanghao232@huawei.com>
  Hela Basa <r45xveza@pm.me>
  Helmut Grohne <helmut@subdivi.de>
  Hiroki Narukawa <hnarukaw@yahoo-corp.jp>
  Ian Wienand <iwienand@redhat.com>
  Jakob Meng <jakobmeng@web.de>
  Jamie Strandboge <jamie@canonical.com>
  Jamie Strandboge <jamie@ubuntu.com>
  Jan Kuparinen <copper_fin@hotmail.com>
  jason lee <ppark5237@gmail.com>
  Jean-Baptiste Holcroft <jean-baptiste@holcroft.fr>
  Jia Zhou <zhou.jia2@zte.com.cn>
  Jianan Gao <jgao@redhat.com>
  Jim Fehlig <jfehlig@suse.com>
  Jin Yan <jinyan12@huawei.com>
  Jinsheng Zhang <zhangjl02@inspur.com>
  Jiri Denemark <jdenemar@redhat.com>
  John Ferlan <jferlan@redhat.com>
  Jonathan Watt <jwatt@jwatt.org>
  Jonathon Jongsma <jjongsma@redhat.com>
  Julio Faracco <jcfaracco@gmail.com>
  Justin Gatzen <justin.gatzen@gmail.com>
  Ján Tomko <jtomko@redhat.com>
  Kashyap Chamarthy <kchamart@redhat.com>
  Kevin Locke <kevin@kevinlocke.name>
  Kristina Hanicova <khanicov@redhat.com>
  Laine Stump <laine@redhat.com>
  Laszlo Ersek <lersek@redhat.com>
  Lee Yarwood <lyarwood@redhat.com>
  Lei Yang <yanglei209@huawei.com>
  Liao Pingfang <liao.pingfang@zte.com.cn>
  Lin Ma <lma@suse.com>
  Lin Ma <lma@suse.de>
  Lin Ma <morecache@gmail.com>
  Liu Yiding <liuyd.fnst@fujitsu.com>
  Luke Yue <lukedyue@gmail.com>
  Luyao Zhong <luyao.zhong@intel.com>
  Marc Hartmayer <mhartmay@linux.ibm.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Markus Schade <markus.schade@hetzner.com>
  Martin Kletzander <mkletzan@redhat.com>
  Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
  Matej Cepl <mcepl@cepl.eu>
  Matt Coleman <matt@datto.com>
  Matt Coleman <mcoleman@datto.com>
  Mauro Matteo Cascella <mcascell@redhat.com>
  Meina Li <meili@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Michał Smyk <fedora@smyk.it>
  Milo Casagrande <milo@milo.name>
  Moshe Levi <moshele@nvidia.com>
  Muha Aliss <muhaaliss@gmail.com>
  Nathan <nathan95@live.it>
  Neal Gompa <ngompa13@gmail.com>
  Nick Chevsky <nchevsky@gmail.com>
  Nick Shyrokovskiy <nshyrokovskiy@gmail.com>
  Nickys Music Group <nickys.music.group@gmail.com>
  Nico Pache <npache@redhat.com>
  Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
  Olaf Hering <olaf@aepfle.de>
  Olesya Gerasimenko <gammaray@basealt.ru>
  Or Ozeri <oro@il.ibm.com>
  Orion Poplawski <orion@nwra.com>
  Pany <geekpany@gmail.com>
  Patrick Magauran <patmagauran.j@gmail.com>
  Paulo de Rezende Pinatti <ppinatti@linux.ibm.com>
  Pavel Hrdina <phrdina@redhat.com>
  Peng Liang <liangpeng10@huawei.com>
  Peter Krempa <pkrempa@redhat.com>
  Pino Toscano <ptoscano@redhat.com>
  Pino Toscano <toscano.pino@tiscali.it>
  Piotr Drąg <piotrdrag@gmail.com>
  Prathamesh Chavan <pc44800@gmail.com>
  Praveen K Paladugu <prapal@linux.microsoft.com>
  Richard W.M. Jones <rjones@redhat.com>
  Ricky Tigg <ricky.tigg@gmail.com>
  Robin Lee <cheeselee@fedoraproject.org>
  Roman Bogorodskiy <bogorodskiy@gmail.com>
  Roman Bolshakov <r.bolshakov@yadro.com>
  Ryan Gahagan <rgahagan@cs.utexas.edu>
  Ryan Schmidt <git@ryandesign.com>
  Sam Hartman <hartmans@debian.org>
  Scott Shambarger <scott-libvirt@shambarger.net>
  Sebastian Mitterle <smitterl@redhat.com>
  SeongHyun Jo <caelus9536@gmail.com>
  Shalini Chellathurai Saroja <shalini@linux.ibm.com>
  Shaojun Yang <yangshaojun@phytium.com.cn>
  Shi Lei <shi_lei@massclouds.com>
  simmon <simmon@nplob.com>
  Simon Chopin <chopin.simon@gmail.com>
  Simon Gaiser <simon@invisiblethingslab.com>
  Simon Rowe <simon.rowe@nutanix.com>
  Stefan Bader <stefan.bader@canonical.com>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Berger <stefanb@linux.vnet.ibm.com>
  Stefan Hajnoczi <stefanha@gmail.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Szymon Scholz <szymonscholz@gmail.com>
  Thomas Huth <thuth@redhat.com>
  Tim Wiederhake <twiederh@redhat.com>
  Tomáš Golembiovský <tgolembi@redhat.com>
  Tomáš Janoušek <tomi@nomi.cz>
  Tuguoyi <tu.guoyi@h3c.com>
  Victor Toso <victortoso@redhat.com>
  Ville Skyttä <ville.skytta@iki.fi>
  Vinayak Kale <vkale@nvidia.com>
  Wang Xin <wangxinxin.wang@huawei.com>
  WangJian <wangjian161@huawei.com>
  Weblate <noreply@weblate.org>
  Wei Liu <liuwe@microsoft.com>
  Wei Liu <wei.liu@kernel.org>
  Wei-Chen Chen <weicche@microsoft.com>
  William Douglas <william.douglas@intel.com>
  Yalei Li <274268859@qq.com>
  Yalei Li <liyl43@chinatelecom.cn>
  Yang Fei <yangfei85@huawei.com>
  Yang Hang <yanghang44@huawei.com>
  Yanqiu Zhang <yanqzhan@redhat.com>
  Yaroslav Kargin <ykargin@virtuozzo.com>
  Yi Li <yili@winhong.com>
  Yi Wang <wang.yi59@zte.com.cn>
  Yuri Chornoivan <yurchor@ukr.net>
  Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
  zhangjl02 <zhangjl02@inspur.com>
  Zheng Chuan <zhengchuan@huawei.com>
  zhenwei pi <pizhenwei@bytedance.com>
  Zhenyu Ye <yezhenyu2@huawei.com>
  Zhenyu Zheng <zheng.zhenyu@outlook.com>
  Zhenzhong Duan <zhenzhong.duan@intel.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          fail    
 build-arm64-libvirt                                          fail    
 build-armhf-libvirt                                          fail    
 build-i386-libvirt                                           fail    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           blocked 
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-libvirt-xsm                                 blocked 
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-libvirt                                     blocked 
 test-arm64-arm64-libvirt                                     blocked 
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-libvirt-pair                                blocked 
 test-amd64-i386-libvirt-pair                                 blocked 
 test-arm64-arm64-libvirt-qcow2                               blocked 
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-libvirt-vhd                                 blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 81184 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Oct 28 10:30:52 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Oct 2021 10:30:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217830.378018 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg2gG-00004r-N7; Thu, 28 Oct 2021 10:30:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217830.378018; Thu, 28 Oct 2021 10:30:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg2gG-0008WQ-Ip; Thu, 28 Oct 2021 10:30:44 +0000
Received: by outflank-mailman (input) for mailman id 217830;
 Thu, 28 Oct 2021 10:30:43 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=8Bw3=PQ=citrix.com=roger.pau@srs-us1.protection.inumbo.net>)
 id 1mg2gF-0008W7-6e
 for xen-devel@lists.xenproject.org; Thu, 28 Oct 2021 10:30:43 +0000
Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 16dabda6-37da-11ec-849d-12813bfff9fa;
 Thu, 28 Oct 2021 10:30:37 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 16dabda6-37da-11ec-849d-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1635417037;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=aMhRtlhvkTrgMvP8toDW8jUe7lnsT+xFPG0QoHOVOaw=;
  b=aQhj6tEqqM4UkuUNd6nwRNYA0UvpoIq7QNSSuPx/Gn1A5RMV8HhX9v1U
   LInwNWVCK4EnMmQUd6PUt01RWzYLdO/Ecd6gOEN49QRWXSUI11dXDiDeS
   3ES7PM0Urh9h+QsnrkADA5Gm1RC3wbwtVwaviyAnLOPkrdxMQuKAuPlcn
   8=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: F11yVwODpKW/9692EmFKjf4ho1p+xQ6+i9F9z9lIN/hZ7qLXL8knQbpp4ZrWAa6g3IVplBCQGJ
 FSaRgdVFKWsm7jVWmPa7Dv9DXZBjTTbqC+P39rUHED6iPoARJj/4k3HKi5JQjEmosnEQkAO7zN
 5/Z6S9XksSJIueDMw3WPPxaTXY12F6Qwf0SMp15v9jIWwtwT4nC/FoKu9t2VFHscdGLwv7KwNb
 j2WRZnknY9UutsQaD3rwqgthyQUBt+Jg+dkEZV8yXoSe4N2wu877KR/mmYmFW7KtZCGQjhyYAr
 9yiMpwjN1HdjZVuag2NhkHSS
X-SBRS: 5.1
X-MesageID: 56090061
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:xaJvQqvPFIP6Jq88jP4SErtT8efnVLBZMUV32f8akzHdYApBsoF/q
 tZmKTiPOPiMamDyf9x/OYmzpEgCusfVydQwGgdlpCozFXgX+JbJXdiXEBz9bniYRiHhoOOLz
 Cm8hv3odp1coqr0/0/1WlTZQP0VOZigHtIQMsadUsxKbVIiGHhJZS5LwbZj29cw24jhWmthh
 PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe
 gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ
 NplmqaOZxotPLf3hrpNA0RlOBFDL7NF9+qSSZS/mZT7I0zudnLtx7NlDV0sPJ1e8eFyaY1M3
 aVGcnZXNEnF3r/ohuLgIgVvrp1LwM3DJoQQt2sm1TjEJf0nXYrCU+PB4towMDIY254WTK6GO
 ZNxhTxHNhbZP0JsIHUrLakFvsP0t3jDQmwCpwfAzUYwyzeKl1EguFT3C/LFd9rPSchLk0Kwo
 mPd43+/EhwcLMaYyzeO7jSrnOCntQT/VYEJHbu07MlDhlGJ23cTAx0bU1i8ifShg0v4UNVaQ
 3H44QJ38/J0rhbyCICgAVvo+xZooyLwRfJ/KdMU9QWP0JHKvVbJW1UvfgNTdt8p4ZpeqSMR6
 neFmNbgBDpKubKTSG6A+rr8kQ5eKRT5PkdZOndaFVptD83L5dhp1EqWH4kL/Lud14WtQVnNL
 ya2QD/Sbln5pfUA0Lmn5hj5ijaoq4mhouUdt1iPADzNAu+UYueYi22UBbrzsakowGWxFADpU
 J04dy62t7lm4Xalz3XlfQn1NOv1j8tpyRWF6bKVI7Ev9i6251modp1K7Td1KS9Ba5hfJGS3O
 BWI51IBuPe/2UdGi4csOupd7OxxlMDd+SnNDKiIPrKinLAoLGdrAx2ClWbPhjuwwSDAYIk0O
 IuBcNbEMJrpIf8P8dZCfM9EieVD7nlnnQv7HMmnpzz6gev2TCPEEt8tbQrRBt3VGYvZ+W05B
 f4EbJDUo/ieOcWjChTqHXk7dgFXcyJjX8mq+6S6tIere2JbJY3oMNeIqZsJcI15haVF0ODO+
 3C2QEhDz1Tjw3bALG23hrpLMuOHsU9XoS1pMCoyE0yv3nR/M4+j4L1GL8k8fKU99fwlxvlxF
 qFXd8KFC/VJazLG5zVCMsWt8N08LEym1VCUIi6oQDkjZJo8FQbHzcDpI1n0/y4UAyvp6cZn+
 ++81hnWSIYoThh5CJqEc+qmyl685CBPmO97U0bSDMNUfUHgrNpjJyDr16dlKMAQMxTTgDCd0
 l/OUxsfoODMpa4z8cXI2v/Y/9v4TbMmExMDTWfB7LuwOS3LxUaZwNdNALSSYDTQdGLo46H+N
 +9b+O7xba8cl1FQvosiT7sylfAi58HirqNxxxh/GCmZdEyiD75tLyXU3cRLsaERlLZVtRHvB
 xCK89hef76IJNnkABgaIw98NraP0vQdmz/z6/UpIRqluH8rreTfCUgCbQORjCF9LaduNNJ3y
 Ogsj8ca9gijh0d4Kd2BlC1VqzyBI3Fov3/LbX3G7FsHUjYW92w=
IronPort-HdrOrdr: A9a23:IM94/66QbPek/UgohQPXwVKBI+orL9Y04lQ7vn2ZFiY7TiXIra
 yTdaoguCMc6AxxZJkh8erwX5VoZUmsj6KdhrNhQItKPTOWw1dASbsN0WKM+UyDJ8STzJ856U
 4kSdkDNDSSNykKsS+Z2njALz9I+rDum8rJ9ISuv0uFDzsaE52Ihz0JdDpzeXcGIjWua6BJcK
 Z1saF81kWdkDksH46GL0hAe9KGi8zAlZrgbxJDLxk76DOWhTftzLLhCRCX0joXTjsKmN4ZgC
 T4uj28wp/mn+Cwyxfa2WOWx5NKmOH5wt8GIMCXkMAaJhjllw7tToV8XL+puiwzvYiUmRsXue
 iJhy1lE9V46nvXcG3wiRzx2zP42DJr0HPmwU/wuwqrneXJABYBT+ZRj4NQdRXUr2A6ustn7a
 5N12WF87JKEBLphk3Glpn1fiAvsnDxjWspkOYVgXAae5AZcqVtoYsW+14QOIscHRj99JssHI
 BVfY/hDc5tABCnhk3izytSKITGZAV3Iv7GeDlMhiWt6UkXoJgjpHFogPD2nR87heQAotd/lq
 P5259T5cNzp/ktHNVA7dc6MLiK41P2MGfx2UKpUBza/fI8SjnwQ6Ce2sRA2AjtQu1P8KcP
X-IronPort-AV: E=Sophos;i="5.87,189,1631592000"; 
   d="scan'208";a="56090061"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=gfuvGISKDoj74pcblbNB01BCgZXDuid2yHlErL6pMH8lk3v0tLA8/rpp05jPVbnXPoMwRZOzA6HmoHex7uRzgw73aUZwNSlXPlUgMR7Nwo8ql1wmS1o6GHZ5Nj2z6ymuztt5RldLAvng7PRoGT3d5FXlnZnK9kCsUReE+oMlq3I/066Juk3T4CcuJ8MAKvbk8WI+n1WHwnt6PrPwqPMpv9LNAj4QUU/hxVWMoJ4JXv7geRzBmGLi9UQ7t97cRafl0JXLHVujEacibbTiQTwk7LWQa9V//iAuyVWaB3b96tGVH79b71+ep/bdVdKTUWoapjO4xaPng7Uz1gsjUHaqKA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=tUCZ0gn6lGYZuz7TP2vGZsgRF18FCCsnQd/3UBtBTP0=;
 b=KzHsB6oUh9XKH8oC/avAzmkPFY4b+7huVNVlD3ZrQy1s/eo99m/xa/y6zIH7tMNfe5YOqFPZiC0MPB8fAtWuLoocaDbrOuBi39gB+BXZT2py/hLYJVi2fQ89an6Hi+JFeONXgEyvHOkEyt9TUXIbeNeliYgaotgROLol9Th0aq2nZXUI5u93EM7DO849jL5WUKJDLEgNE4sXdAVBtntCqQNdQikpO6TkciykD4OEbMTmroukjpNYPTg81RC76PZuff+id0WE/Rg4SOqPBp6HRSrW8u9Hh/9oaN4cyv3nmmBxCZt65kH3VDTy/O3DZ3iov+rtN18gK2WEwOGfPMnCVQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=tUCZ0gn6lGYZuz7TP2vGZsgRF18FCCsnQd/3UBtBTP0=;
 b=oYaNKuET5lhKeyU3vMI1zGIvq7FmHAefWelpcvszxmj0z37xKrn6XwUL9Md0Ph7qz2VDwHBLZyxtSX6je1laT6EdbXTqmukNyEp+opAJhfXPuINMQjdZ5wBPFb2RfDMmk3da74HZwdJS6/n/kxWoijnxzrn6l5KKzJt420XZIXU=
Date: Thu, 28 Oct 2021 12:30:16 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: vpci: Need for vpci_cancel_pending
Message-ID: <YXp7uHdubtmsG/HM@Air-de-Roger>
References: <fd1328da-5ad3-62cc-28d6-0ec60e9ea582@epam.com>
 <YXp4ovmIsHKTGiw0@Air-de-Roger>
 <9eca8f0d-ca4c-696c-5ce8-4073033f59cc@epam.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <9eca8f0d-ca4c-696c-5ce8-4073033f59cc@epam.com>
X-ClientProxiedBy: MR1P264CA0074.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:501:3f::29) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 0b3e49a9-f876-47e5-b956-08d999fdf182
X-MS-TrafficTypeDiagnostic: DM6PR03MB4540:
X-Microsoft-Antispam-PRVS: <DM6PR03MB4540D2720C8A6EA9E4EF34588F869@DM6PR03MB4540.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: OYvbRuZUONw46d3yPhgMMA2+77j6Jf/vnFPvJCA17M+srBEQHNQSKJB3xlniHTE7V6mjLDCbDwV2MU36y3Ea78du3ilqIyL/tbw6Z+n2YsUpR9FOWqiVcD4/2mJ7ySZmGCuERgxyhziAGu7s/ARBN77tCT/7hmO6Bu2lyGIlNlrxJJ9pSaJMhUiFs9VU4H9DePqePmTjTBgL7kSrs/Qn2qGwJENQ1EA4fVQAm4e/bdXb0odrKP4DDNrWrzmu9bXbn8vlRq8d9/lLlWpSP/GzMjnkA7ZtryLk5WO1wLhQ6GpFe0HHWKrpIqfXjoTnSsf8ZeKcbMbeSdDT082adoLeRDrBP3hq17iPYVUWIyJgJqpVm2uV3CeRhAPo95aCAueZPri9kuTRjYexzYD0qnVx0m7G0nD/3JwU/vhCjOxcd6IzxvHEitYib2UFhrRRFrEd55mJbY+pUNiwbjeFBmDHBtDJrlBlDznQYFz/l0u19VOsANvKHtTr8CZsHQkesYtLMeoBi/CHTUuXujE4+ImKjoFKBwX/HPJnOEHs/XnLKg8BgMpI+f/dAXMs7AP31X0YdW1DrO0RPPbI1NTCJU0kzaegAhpyTB0uC10OVAQ7mN/OE7L5Bd7hI2bnjiVk8fhcgt03KEpapZbWz77Ht1VPaA==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(7916004)(366004)(85182001)(82960400001)(66556008)(66476007)(6496006)(956004)(38100700002)(83380400001)(8676002)(86362001)(8936002)(66946007)(6486002)(186003)(26005)(6666004)(53546011)(508600001)(4326008)(9686003)(5660300002)(33716001)(2906002)(316002)(6916009);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VHpJSVY3Ym9MV2wyU1pIR0lneHFNMGdZcytKbVhRaFJFMzJKY3VWZEhFWjYv?=
 =?utf-8?B?L0owU3JnOXFwT04weXB4Q0tKZ2dxVGM2R2VtS3hLUGVLUUtOQkhYTDNQbFVY?=
 =?utf-8?B?U2hYWFRqOTdLeHRWa3hCZ1JNM3NmTUlVczhGUzgzSk1iZm1vUUdLakphelNK?=
 =?utf-8?B?M2xZeDZMTmdIVWNkTWtUdUttSmJwTnRqcDFCVmpxSUpNdkprTFBkbUdWWWYw?=
 =?utf-8?B?VENMYkYybFY5cmlIM2YvNDVaQ0VTWmg2NXFJVFRLa1hWek1sT2d4TkVGWnN3?=
 =?utf-8?B?bVZocDdFWE1Lanlyd25VWlpBcFg3QU8xK09CeGdBek16ZUxrOTRtczc1eHp6?=
 =?utf-8?B?N0RyK09GbTRuUDRtQlUzSGI0YjZtSFM4QkI2cVB2SlNkd0xTVmpaYkIyR0Rt?=
 =?utf-8?B?Tll3aGdsUjNqTTBsV0hieFYydEg4RWc2aHlPams2alo2ZHg2b24wL0dVb3dH?=
 =?utf-8?B?b3lQUHlKZXZ2eTl2bHJxZGJqUWEyUWU0MjJZWE1EMmFPaExmNVBENlIrYWti?=
 =?utf-8?B?c2hUMFhlYnIwTjJHTmYyUVVnMlVpWElYT0tvTlk3NWVKaTJTN2paMTNFZWRY?=
 =?utf-8?B?MktZY3JaZWQwZVo1WXVlUDVIdFA5WE5MQXlJQThFekc0SHhDWjhVaGY0SlM3?=
 =?utf-8?B?ZFRmOHpFdjlJUTgwcnZITUZacks3eXFBdnFIbmpKTmpGSGdBdm9GelBQLytp?=
 =?utf-8?B?UmRJQndVd3hGb09yQWpBTmRHY2lsd2JrZUh2c0lGTU1kRTYzRktDWDQ3Y2Fv?=
 =?utf-8?B?TVJSQm54ZitXUjNPelRRQk5TMHBOUk1YbzR3eEpieFAyOTBuT3dPRW5ObnZP?=
 =?utf-8?B?UXkwdTdKZlZxTHQ5YXFoN0tLYk45VzNrZjlKTDQ3OXJHZ1RXdjZmazV2MUFV?=
 =?utf-8?B?ZHJndTk4d3h0bko4dXlSbjkyUVVDNk52SUkzcHVkcndRakdFVXFYUGF1WVpT?=
 =?utf-8?B?ekdFZEIvNG1FcVQrTXZ6YmtzaWdQZjhucFhCK05VcCs1NFlKVEtzV3UwVzMw?=
 =?utf-8?B?SlVRMWlYbzVUY3hNTUV2empXNy9neXJVZEtkOWhWSEhPb0k5V2pLRElaTU45?=
 =?utf-8?B?Nlp6Ukp3K1VNT3BsNlVYWmYwNTRaM0Z3TnhYdERBZm4vZThkSGI4dG9qeWgx?=
 =?utf-8?B?MUpyYVl1UExBOHVTd2NMYTQ0OFhpRWF2MmR5VytkNjF4MHdZblVHZURZYzJq?=
 =?utf-8?B?SzFNbHFFWHpmVm44Nkc4ZUI2V2VnZXM4SXpaMDRsakx3ekRyR1A4NDRxWnd0?=
 =?utf-8?B?bmJKOStGSUtaNUpFaWVWbHQ0eUpJbWNNUVAzQTNpYTgyVVRTNktBaWFWNGNT?=
 =?utf-8?B?TnpFQ1RvK2hXSXBtR253VTZJbU9VZmFrK3NXUU16V1BxQ3BUNDVLaGJaakQr?=
 =?utf-8?B?VFRqbWptc2oxUklBdkJaK0d6bVhKeVpmb3A4VnVQekduUEdhalRCNmxacGkx?=
 =?utf-8?B?em1yK3hqMVNiaHd4QzUxVVVIdmsxTW9nMHk1ZmRSMTNHWk5PanNuNFNvcmZu?=
 =?utf-8?B?M1VPMHAwWjFBbVlQZEZDanlrNnNkNWgydURSTFNPYmRmZGhOTitoM21TTldj?=
 =?utf-8?B?ZWdZOHhHd1R3MTg3dlpmWmZwVFJQa1AvL0N0QjR2YzJaT1NrZzhTMWNHMEpk?=
 =?utf-8?B?NmF2ODQvUGlvTmJ0RnlvK0pJYTVhQmMxVVpQZHNtKzYrZG51WnpOckNuc1Vz?=
 =?utf-8?B?Z0VWcS9kZEdDNnorT2R3Y2VlaTZ4d0xJeXhReXNPblZGbjNpVmRHa2dGRHph?=
 =?utf-8?B?dS91K1VZbktUS3VWOTg5SkcrQUJHWEdLeWNGUCs4Lzd6eE1oNjV3NEZ0S3lK?=
 =?utf-8?B?U25COUcwV0xtRTRFZktjQ0l0OElWOVp0Z3VRMXFEa2RTSkxWQ2RyRnEweGl5?=
 =?utf-8?B?MUZWMUkzazE2ZWVHSk9GOCsyYTBiend1cytDUncvalo5VEtOTk93V2pjRjha?=
 =?utf-8?B?ZUE0SW5YczlGSDV3SUl2amorNWdHZDQwQkplQ3phRm9jbm5sQUNqaU1hMDd0?=
 =?utf-8?B?NFBCTWZXUlc3TE81MHdmTmE0R3JqVXFWcDNLc2RVU0pBbFdVM0sxaHQ0b0Y5?=
 =?utf-8?B?SktQUGxZZXNqVlBJVktPc0hBS1BsZW8zbEZsVklUTFlsM0Y3ZHlHVEFSYTBH?=
 =?utf-8?B?VHJYSUZqSzR1U3BkYUlidFVEV1B0V3VZMjVkT05XLzZINXRpT3NWNzRtZU9X?=
 =?utf-8?Q?HlwuZfWW3VoncZh92AHmZ74=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 0b3e49a9-f876-47e5-b956-08d999fdf182
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Oct 2021 10:30:20.9537
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: oWRmUNoIDk/N7FY6GPtcsw/wKY2uSpCljbgCaV+APbej9dZ0k4INLC9T9Hw0vS45DDySuFb1KhQw2AJIwtafIg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4540
X-OriginatorOrg: citrix.com

On Thu, Oct 28, 2021 at 10:25:28AM +0000, Oleksandr Andrushchenko wrote:
> 
> 
> On 28.10.21 13:17, Roger Pau Monné wrote:
> > On Thu, Oct 28, 2021 at 10:04:20AM +0000, Oleksandr Andrushchenko wrote:
> >> Hi, all!
> >>
> >> While working on PCI passthrough on Arm I stepped onto a crash
> >> with the following call chain:
> >>
> >> pci_physdev_op
> >>     pci_add_device
> >>         init_bars -> modify_bars -> defer_map -> raise_softirq(SCHEDULE_SOFTIRQ)
> >>     iommu_add_device <- FAILS
> >>     vpci_remove_device -> xfree(pdev->vpci)
> >>
> >> Then:
> >> leave_hypervisor_to_guest
> >>     vpci_process_pending: v->vpci.mem != NULL; v->vpci.pdev->vpci == NULL
> >>
> >> Which results in the crash below:
> >>
> >> (XEN) Data Abort Trap. Syndrome=0x6
> >> (XEN) Walking Hypervisor VA 0x10 on CPU0 via TTBR 0x00000000481dd000
> >> (XEN) 0TH[0x0] = 0x00000000481dcf7f
> >> (XEN) 1ST[0x0] = 0x00000000481d9f7f
> >> (XEN) 2ND[0x0] = 0x0000000000000000
> >> (XEN) CPU0: Unexpected Trap: Data Abort
> >> ...
> >> (XEN) Xen call trace:
> >> (XEN)    [<00000000002246d8>] _spin_lock+0x40/0xa4 (PC)
> >> (XEN)    [<00000000002246c0>] _spin_lock+0x28/0xa4 (LR)
> >> (XEN)    [<000000000024f6d0>] vpci_process_pending+0x78/0x128
> >> (XEN)    [<000000000027f7e8>] leave_hypervisor_to_guest+0x50/0xcc
> >> (XEN)    [<0000000000269c5c>] entry.o#guest_sync_slowpath+0xa8/0xd4
> >>
> >> So, it seems that if pci_add_device fails and calls vpci_remove_device
> >> the later needs to cancel any pending work.
> > Indeed, you will need to check that v->vpci.pdev == pdev before
> > canceling the pending work though, or else you could be canceling
> > pending work from a different device.
> How about:
> 
> void vpci_cancel_pending(struct pci_dev *pdev)
> {
>      struct vcpu *v = current;
> 
>      if ( v->vpci.mem && v->vpci.pdev == pdev)
>      {
>          rangeset_destroy(v->vpci.mem);
>          v->vpci.mem = NULL;
>      }
> }
> 
> This will effectively prevent the pending work from running

Can't you just place this in vpci_remove_device?

Or is there a need to cancel pending work without removing the device?

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Thu Oct 28 10:32:30 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Oct 2021 10:32:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217836.378028 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg2ht-0000ha-1h; Thu, 28 Oct 2021 10:32:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217836.378028; Thu, 28 Oct 2021 10:32:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg2hs-0000hT-Uz; Thu, 28 Oct 2021 10:32:24 +0000
Received: by outflank-mailman (input) for mailman id 217836;
 Thu, 28 Oct 2021 10:32:23 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ikAZ=PQ=epam.com=prvs=19352d112c=oleksandr_andrushchenko@srs-us1.protection.inumbo.net>)
 id 1mg2hr-0000hL-BR
 for xen-devel@lists.xenproject.org; Thu, 28 Oct 2021 10:32:23 +0000
Received: from mx0a-0039f301.pphosted.com (unknown [148.163.133.242])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 6647d1dd-e493-4036-b301-22f72f2d84c1;
 Thu, 28 Oct 2021 10:32:21 +0000 (UTC)
Received: from pps.filterd (m0174676.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 19S9SZ2a001567; 
 Thu, 28 Oct 2021 10:32:20 GMT
Received: from eur03-db5-obe.outbound.protection.outlook.com
 (mail-db5eur03lp2052.outbound.protection.outlook.com [104.47.10.52])
 by mx0a-0039f301.pphosted.com with ESMTP id 3byduj23sj-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Thu, 28 Oct 2021 10:32:20 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by AM0PR03MB3715.eurprd03.prod.outlook.com (2603:10a6:208:43::31)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.15; Thu, 28 Oct
 2021 10:32:17 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::c038:e032:595a:651]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::c038:e032:595a:651%9]) with mapi id 15.20.4649.015; Thu, 28 Oct 2021
 10:32:17 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6647d1dd-e493-4036-b301-22f72f2d84c1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=OR1wLKc8IXuIjkO2Gh8DhmkSGH05YktTVrv4Y7DPgG69o7ZcjphcVnXG0JphTjJ4HGT3gKYdiyNZVGnMk9UZ3h1GzNFKQ/yV9fkPeUiM0IxSIBNAP5mMT75sdb79y+sY/F7WzePDu/irpaHqtnP5l3qcTeuggOZbvBsGHsSueHB+HGZfskwVOSvt8fpxV62YWxJnEW3BJtHfz59sEZ0HK8gUw43wWtffej5QJIK8pIkjCs0Q+QWv0h78UvjE3ptVIPB61n+5Qk9RCh2n8p6krUX0QEOlBHaRKvRAkS9ZD18J1SX4iEFfM9XttFuw9qLp5m2Y10QpQ+QAPYo1/E6DDA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=nl6HudNpHslqI/UiWj1QV4BZrWsOMpJYIAhOf971FEE=;
 b=hpuIjmxpf01DfWqEB49YtJWOQjkolx4hcq9tzb51ucTWmcNpx7sDYeGMc7PIXPXjNyutBEaM5RrPGIzVcnAE70IUDYk8VimzEnhwjdrEIpMlog179yoXvtKqiGwX99Xf+HRBTcLoVwQ2LSzJKkMEkjuvWvq/ZINUcpTo0//GmtMUP9zQyKWcmbbalI3RjYphuPe6Tzb/gkcMDDGc8RUeHfHa9NSFFT8E2R1YTmmxdOWPrVPo3eqVDY9rirgdiTi76rjzjalhan1+OL2ya5P1sDc8MbHWFWcHcm4aNVVFYZq48VbwtW1Q7pBbtbkCCw1cUbPGqajM1qdHbK+fY+6nmA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=nl6HudNpHslqI/UiWj1QV4BZrWsOMpJYIAhOf971FEE=;
 b=zQlffk2WDnovT9Q67ZtJ71stfGjjRyerIZjH0zZtxDWU6rPMnBVY2eGMqrQ6LEnWFM2M6I2MxJVQXhxQy7zWXgVDQEqDpP7eItcwwpiAACl6lkpM/Tovdo/gcp7tdj+ZKTllMx5oT4IiVvG+ZhNY9FgovxoAxXwUEGpL6pmPkSGVOm1V8TnNCvR/GyYdDUBSLgoK48DslmaRiXfSLhUJ0nzGKi8QEtkPWQWQR8LOyLSaAYkZk6Vrm2GktEFziuI0hp3LTJFuCkcppmfS1dSUvxgeXEir1aFXsx7SeRsBqZdkGZJvrBW2QgZy9EN/Z5c/DyDXI/wmePCn62zgT8QGdQ==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: vpci: Need for vpci_cancel_pending
Thread-Topic: vpci: Need for vpci_cancel_pending
Thread-Index: AQHXy+MtilSp1e2bsUu2TEgvHf6jsavoMiQAgAACRgCAAAFoAIAAAJCA
Date: Thu, 28 Oct 2021 10:32:17 +0000
Message-ID: <85fb7d38-3dfa-1120-21bc-638efbe2849c@epam.com>
References: <fd1328da-5ad3-62cc-28d6-0ec60e9ea582@epam.com>
 <YXp4ovmIsHKTGiw0@Air-de-Roger>
 <9eca8f0d-ca4c-696c-5ce8-4073033f59cc@epam.com>
 <YXp7uHdubtmsG/HM@Air-de-Roger>
In-Reply-To: <YXp7uHdubtmsG/HM@Air-de-Roger>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 253d7f1c-075a-44bb-5a57-08d999fe373b
x-ms-traffictypediagnostic: AM0PR03MB3715:
x-microsoft-antispam-prvs: 
 <AM0PR03MB3715C4F8AB444409B49D1041E7869@AM0PR03MB3715.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 iY4UfPW6rYMJxtZ4B35dGkdArp5Uv905tnTsUXrLoGK7gvs3qUNVGYLxVtyFuezdvmHD5zOUlPXZ8KjJzQ7Q2ThXbp/IVEpkpabWqI4+W1WZkxLV7/kMVnyurQFRgGJ2XblXfQbVaThVoy8fRk6KiHpWX4YSIBTdaxWdOAX5ILsK0uQdRju3BaCSkeYqdsi1fRqnEmGlkF/8a642TkXkrqt+9mCfxqq37gPlkRf39ifQfLCw/EXiWneXDKLAYLbZ7IA0msTtQf72nssn4PN4UZb0WSVn52bGPqCpHTOoZ/eTbcSpvoc5WGesDtsGGny+2qjQNzCl8YSmVIQWw/2LNqhmbRnZyCk0nb3u/0pIdYDDOsFYhtwFZWKjA0wOMJQB5VzEvojynid9fkZsif8MxxSy962+ZzqiwpAj0ilUOqg4Arj4BmZeG/FwBrLJGlCNHGjSxWbDLdzA73p7yjXTSbG4p+K7axk1r07dO9IUVR00+VidZI48X2QQqEpMD+wtLzS4NlNJKS5WSp5LZzHhbB6q1e6VBcwr6ZuNuemU5BHwALWt3mFUA7oKFfS2gpvJ2ZbkxepKAKkAwA06s6JJjMxbtKZgv5DrwiowwNvdXwPGgWi+tTNUkAyHzYOsLxpeAnx1ptpg0l9m4K1CqF97ILEnAgiBhyp3Ox6xpJ5qnT3YZJ+KLPs5FJ0RooYLywC3vkuVrVqiqOMyB8/wyOpw8IEdGB1GfH8SmUojLQ5TE4OHohcZP6ZImW5XcQ3QKvK6
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(66946007)(76116006)(71200400001)(91956017)(8676002)(6512007)(6916009)(122000001)(86362001)(55236004)(5660300002)(316002)(38070700005)(4326008)(6506007)(66476007)(66446008)(66556008)(64756008)(38100700002)(2906002)(53546011)(2616005)(508600001)(31686004)(8936002)(186003)(83380400001)(6486002)(36756003)(26005)(31696002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?R1BWRjhCdlU0RlZKS1diVWwwVUNBQ2FEcGtEaU9hakQxVzBiTElUckxFRjlO?=
 =?utf-8?B?dUI5U2RBaE5NdUxRa1BTN0tzU2MrNVc3RkorQ3pFNU5RREMwbm9VMGc5a1lk?=
 =?utf-8?B?YXBQUERiTnFKM1h2S0ExeXdNMHJoUllHUTJiRFZkTnJkd0h3K0RGMXJNeG0w?=
 =?utf-8?B?TUFNdVR4eTQzby9IakJmYWhDQlFKLzlmSXRESmZFUGhaL2tQOTJrSC9Yb3JR?=
 =?utf-8?B?dW10SDlvL2h6SVlMbmRMa0xZOEl6RXpyWVU1TFBFeGR6dzBkdUVhQ2Y0SW55?=
 =?utf-8?B?RFpLVkFmYUs2V0oyL0JPWlprenpKUFdFRjlOWGVjbHBOTUZPa1dUY1JPcVNx?=
 =?utf-8?B?ZHcvMmxsam5nUUZRN2dSWXd6UHdLQ1ZqV2drckFWbkJkd3M2YXgrQmFjeDlR?=
 =?utf-8?B?NnlKZ2R5OWRrd1p5SmNLYnZjVlJEcjlJOTRJZW9PNGEramUyclgzV1hlOGVO?=
 =?utf-8?B?amFQMXBXa0sxRGhPcnhzVW9QSTAvT1k4dmdDT0thRGRVOHRkdkp0SDcyTVV2?=
 =?utf-8?B?NlB3UG5TS2FqUDBHRjk0blVsZkJhVFJ1MjQ4akJWdGx1bTNsME8wa0JYMTY1?=
 =?utf-8?B?MThyZEVmU0pRTkJKLzFiU2I5Y2pUMVNBV21yZUloOWlrZ0dueElHd2piYTRv?=
 =?utf-8?B?N2RMaWJ4Z0E2OUlMS3BGd1VRWU1WTWo2L0ZlNytTeWo1Q2Y1WGI5akZUWUc3?=
 =?utf-8?B?dWpmKzNjbXFucHg5Nys4NDAraWdqMC8zSVNVUi8rZHZNVGpoZWVSdjJlRnUv?=
 =?utf-8?B?czlIUDh5c282ci9TMzVoekxyYlBkSUgybE1SOEJrOXVYMHRXVmVGVlltUC96?=
 =?utf-8?B?NzR1TDBTcm9VdmR5b2JpbXRxQVNDLzR0Q2NRbXptMnBwbUVvQ256SFZndU9M?=
 =?utf-8?B?ZzJmcitndUNKTld0QXlxUjNXdTBUNG4wMkY1aHJBQXE0c1dyNVpxdWhmMWJC?=
 =?utf-8?B?UGRMYlhkMTVSblNsQlR0RlZ1QUlGL0h4L0Y0bStydnpuYWF6OUR1UEFlZFlP?=
 =?utf-8?B?bWdiUmw0bXJVb2o3VExlMkU1RmVrK0U2Y2YvWTVvZW5GN2tpNHNJZTNYVkJ5?=
 =?utf-8?B?OWY0dlgzeGg0WTVDeGY4UmVOeWxPWXJucU5CTDgvTHNVNTdwUlFQcTRva3pZ?=
 =?utf-8?B?ZmgxNFh4SG9ONFNmRDZZMFpLZFRzVXNWbnoyelJwZzV3ZHl6OHh6OHNZK2xl?=
 =?utf-8?B?Z1BHMDBJWUVZU09kdndEUEFoVFl3MXpjd0ttN1dBaW9jYzZ5TWNmRVJ1eno4?=
 =?utf-8?B?Wm9vN09VNnpUTWQ3a25ZVDh6MzNGK3hFdHBzVmVQb2VBbDdZR1MwclpCTVBq?=
 =?utf-8?B?U2JEYS9kN2l0dEcvU2gwVmJMQ1FNL05QTHF0elMzNHZRRkgyZDhlOW1NRHZp?=
 =?utf-8?B?YUQ1dm1CNHVPT2ZwRXMxUEdSYTUyWmZ2UThtaDVyT2psVHNhK1h6YXp4TG9Q?=
 =?utf-8?B?bkNGc3ZiREVKMTliWEl3OXpJUmt1bGxneVhjQTRSWWRqZzd0MGt2VU5iekV2?=
 =?utf-8?B?eVVYSlZ3OTZPTjFIOFBDdzc2Z2w0NXdHVmNHbW9oVDBDdWFBYUozZHF2VWF4?=
 =?utf-8?B?a0doUy9CVzlERlBoa2Z3R3F5UWoxTnMrWnA4Z0VYRUsvYnM5SUVSbkg5S3Vl?=
 =?utf-8?B?VXZOQ2JQQVdGQmNCeTJ1N3Boa3ludXZpUUdFUzkvRFBtZkVhSFhhak9Ma0FF?=
 =?utf-8?B?UTQySlFoMFVQZkpzMmt3OG9IUENNRmNmcHAzb1JPS0p4MVZRYVNpNTJnSnhq?=
 =?utf-8?B?YWtFNkxYMzVBcFpWd3MzL2hKZEhpblU3aTRJVU4zZ3RlVzJxbXFtWm9jM0li?=
 =?utf-8?B?aTN4YXVySEVPNmowUVdEOTlmVjZ1VU9uTzIxcWg5bnEyRFlIaHpMUkFtaU0r?=
 =?utf-8?B?clN0QnVJVm1EYzJnVitldGltV3oyM2twUFhSVlN2NGI3ZE5BMXFscVlrbXJY?=
 =?utf-8?B?TFN5NWNpaUdMRkVXL2ppZmZrQmJqVUlVNHk2SHJoMFU2eWhzZm9iTEw2eWpR?=
 =?utf-8?B?SHFCV3JneHVoeTI1QWQ3V1FqL0ZpRVdiNXBEZXVHV2RWWmJMWGNGdUdDazNC?=
 =?utf-8?B?ck85eWI5Q1pLVDFtZXBaWi9SWEZaNi9SdlBDT1cxK2NDZFRGcysrNzg5azFD?=
 =?utf-8?B?Q1dxTENvSEJnUUx0YjZvbUx2Z1NyeWpLM0tQNE1QUUE3U3JYVjlqQWtKQUpx?=
 =?utf-8?B?UEhDakprTjIxRzlVcUdZRCsvWm51S3RQS3BaVGs2dFJCMzJROC96NU1DZjBG?=
 =?utf-8?B?S3llL0drcFpsems1SmxwNUVqbSt5T0EwclgyemZ6Z0NLMm1rUThZRGUwQllW?=
 =?utf-8?B?aDUzNExYREFwVmQ5enFqNVFwdUNGMEJYamJlbUtocFY3aXNhQzdTQT09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <67EC452D085F8346B5D576D9DFF9ACF3@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 253d7f1c-075a-44bb-5a57-08d999fe373b
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Oct 2021 10:32:17.6218
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ygFDrU8r8j3ib5RCPZmlXUySS353a8yGPfdOid7xK3NA533v8dnjL10fvql0KL6fgM5E01UnSlEF8eP6Pcp2M80BcT/z1PnBjxPufPdpt68wiUzQSgLQrnDFSh1O1hdL
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR03MB3715
X-Proofpoint-GUID: KC2oVsjB2Jlha_g5RdpS26_cPwAWmg8a
X-Proofpoint-ORIG-GUID: KC2oVsjB2Jlha_g5RdpS26_cPwAWmg8a
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475
 definitions=2021-10-28_01,2021-10-26_01,2020-04-07_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 clxscore=1015
 bulkscore=0 spamscore=0 impostorscore=0 lowpriorityscore=0 mlxlogscore=766
 suspectscore=0 priorityscore=1501 mlxscore=0 adultscore=0 phishscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2110280057

DQoNCk9uIDI4LjEwLjIxIDEzOjMwLCBSb2dlciBQYXUgTW9ubsOpIHdyb3RlOg0KPiBPbiBUaHUs
IE9jdCAyOCwgMjAyMSBhdCAxMDoyNToyOEFNICswMDAwLCBPbGVrc2FuZHIgQW5kcnVzaGNoZW5r
byB3cm90ZToNCj4+DQo+PiBPbiAyOC4xMC4yMSAxMzoxNywgUm9nZXIgUGF1IE1vbm7DqSB3cm90
ZToNCj4+PiBPbiBUaHUsIE9jdCAyOCwgMjAyMSBhdCAxMDowNDoyMEFNICswMDAwLCBPbGVrc2Fu
ZHIgQW5kcnVzaGNoZW5rbyB3cm90ZToNCj4+Pj4gSGksIGFsbCENCj4+Pj4NCj4+Pj4gV2hpbGUg
d29ya2luZyBvbiBQQ0kgcGFzc3Rocm91Z2ggb24gQXJtIEkgc3RlcHBlZCBvbnRvIGEgY3Jhc2gN
Cj4+Pj4gd2l0aCB0aGUgZm9sbG93aW5nIGNhbGwgY2hhaW46DQo+Pj4+DQo+Pj4+IHBjaV9waHlz
ZGV2X29wDQo+Pj4+ICAgIMKgIHBjaV9hZGRfZGV2aWNlDQo+Pj4+ICAgIMKgIMKgwqAgwqBpbml0
X2JhcnMgLT4gbW9kaWZ5X2JhcnMgLT4gZGVmZXJfbWFwIC0+IHJhaXNlX3NvZnRpcnEoU0NIRURV
TEVfU09GVElSUSkNCj4+Pj4gICAgwqAgaW9tbXVfYWRkX2RldmljZSA8LSBGQUlMUw0KPj4+PiAg
ICDCoCB2cGNpX3JlbW92ZV9kZXZpY2UgLT4geGZyZWUocGRldi0+dnBjaSkNCj4+Pj4NCj4+Pj4g
VGhlbjoNCj4+Pj4gbGVhdmVfaHlwZXJ2aXNvcl90b19ndWVzdA0KPj4+PiAgICDCoCB2cGNpX3By
b2Nlc3NfcGVuZGluZzogdi0+dnBjaS5tZW0gIT0gTlVMTDsgdi0+dnBjaS5wZGV2LT52cGNpID09
IE5VTEwNCj4+Pj4NCj4+Pj4gV2hpY2ggcmVzdWx0cyBpbiB0aGUgY3Jhc2ggYmVsb3c6DQo+Pj4+
DQo+Pj4+IChYRU4pIERhdGEgQWJvcnQgVHJhcC4gU3luZHJvbWU9MHg2DQo+Pj4+IChYRU4pIFdh
bGtpbmcgSHlwZXJ2aXNvciBWQSAweDEwIG9uIENQVTAgdmlhIFRUQlIgMHgwMDAwMDAwMDQ4MWRk
MDAwDQo+Pj4+IChYRU4pIDBUSFsweDBdID0gMHgwMDAwMDAwMDQ4MWRjZjdmDQo+Pj4+IChYRU4p
IDFTVFsweDBdID0gMHgwMDAwMDAwMDQ4MWQ5ZjdmDQo+Pj4+IChYRU4pIDJORFsweDBdID0gMHgw
MDAwMDAwMDAwMDAwMDAwDQo+Pj4+IChYRU4pIENQVTA6IFVuZXhwZWN0ZWQgVHJhcDogRGF0YSBB
Ym9ydA0KPj4+PiAuLi4NCj4+Pj4gKFhFTikgWGVuIGNhbGwgdHJhY2U6DQo+Pj4+IChYRU4pwqDC
oMKgIFs8MDAwMDAwMDAwMDIyNDZkOD5dIF9zcGluX2xvY2srMHg0MC8weGE0IChQQykNCj4+Pj4g
KFhFTinCoMKgwqAgWzwwMDAwMDAwMDAwMjI0NmMwPl0gX3NwaW5fbG9jaysweDI4LzB4YTQgKExS
KQ0KPj4+PiAoWEVOKcKgwqDCoCBbPDAwMDAwMDAwMDAyNGY2ZDA+XSB2cGNpX3Byb2Nlc3NfcGVu
ZGluZysweDc4LzB4MTI4DQo+Pj4+IChYRU4pwqDCoMKgIFs8MDAwMDAwMDAwMDI3ZjdlOD5dIGxl
YXZlX2h5cGVydmlzb3JfdG9fZ3Vlc3QrMHg1MC8weGNjDQo+Pj4+IChYRU4pwqDCoMKgIFs8MDAw
MDAwMDAwMDI2OWM1Yz5dIGVudHJ5Lm8jZ3Vlc3Rfc3luY19zbG93cGF0aCsweGE4LzB4ZDQNCj4+
Pj4NCj4+Pj4gU28sIGl0IHNlZW1zIHRoYXQgaWYgcGNpX2FkZF9kZXZpY2UgZmFpbHMgYW5kIGNh
bGxzIHZwY2lfcmVtb3ZlX2RldmljZQ0KPj4+PiB0aGUgbGF0ZXIgbmVlZHMgdG8gY2FuY2VsIGFu
eSBwZW5kaW5nIHdvcmsuDQo+Pj4gSW5kZWVkLCB5b3Ugd2lsbCBuZWVkIHRvIGNoZWNrIHRoYXQg
di0+dnBjaS5wZGV2ID09IHBkZXYgYmVmb3JlDQo+Pj4gY2FuY2VsaW5nIHRoZSBwZW5kaW5nIHdv
cmsgdGhvdWdoLCBvciBlbHNlIHlvdSBjb3VsZCBiZSBjYW5jZWxpbmcNCj4+PiBwZW5kaW5nIHdv
cmsgZnJvbSBhIGRpZmZlcmVudCBkZXZpY2UuDQo+PiBIb3cgYWJvdXQ6DQo+Pg0KPj4gdm9pZCB2
cGNpX2NhbmNlbF9wZW5kaW5nKHN0cnVjdCBwY2lfZGV2ICpwZGV2KQ0KPj4gew0KPj4gICDCoMKg
wqAgc3RydWN0IHZjcHUgKnYgPSBjdXJyZW50Ow0KPj4NCj4+ICAgwqDCoMKgIGlmICggdi0+dnBj
aS5tZW0gJiYgdi0+dnBjaS5wZGV2ID09IHBkZXYpDQo+PiAgIMKgwqDCoCB7DQo+PiAgIMKgwqDC
oMKgwqDCoMKgIHJhbmdlc2V0X2Rlc3Ryb3kodi0+dnBjaS5tZW0pOw0KPj4gICDCoMKgwqDCoMKg
wqDCoCB2LT52cGNpLm1lbSA9IE5VTEw7DQo+PiAgIMKgwqDCoCB9DQo+PiB9DQo+Pg0KPj4gVGhp
cyB3aWxsIGVmZmVjdGl2ZWx5IHByZXZlbnQgdGhlIHBlbmRpbmcgd29yayBmcm9tIHJ1bm5pbmcN
Cj4gQ2FuJ3QgeW91IGp1c3QgcGxhY2UgdGhpcyBpbiB2cGNpX3JlbW92ZV9kZXZpY2U/DQo+DQo+
IE9yIGlzIHRoZXJlIGEgbmVlZCB0byBjYW5jZWwgcGVuZGluZyB3b3JrIHdpdGhvdXQgcmVtb3Zp
bmcgdGhlIGRldmljZT8NCkBAIC0xNDksOCArMTQ5LDcgQEAgYm9vbCB2cGNpX3Byb2Nlc3NfcGVu
ZGluZyhzdHJ1Y3QgdmNwdSAqdikNCiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqAgIXJjICYmIHYtPnZwY2kucm9tX29ubHkpOw0KIMKgwqDCoMKgwqDCoMKg
wqAgc3Bpbl91bmxvY2soJnYtPnZwY2kucGRldi0+dnBjaS0+bG9jayk7DQoNCi3CoMKgwqDCoMKg
wqDCoCByYW5nZXNldF9kZXN0cm95KHYtPnZwY2kubWVtKTsNCi3CoMKgwqDCoMKgwqDCoCB2LT52
cGNpLm1lbSA9IE5VTEw7DQorwqDCoMKgwqDCoMKgwqAgdnBjaV9jYW5jZWxfcGVuZGluZyh2LT52
cGNpLnBkZXYpOw0KDQpTbywgd2UgY2FuIHJlLXVzZSBpdCBhbmQgZG8gbm90IGNvcHkgcGFzdGUg
dGhlIHNhbWUNCj4NCj4gVGhhbmtzLCBSb2dlci4NCg==


From xen-devel-bounces@lists.xenproject.org Thu Oct 28 10:48:41 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Oct 2021 10:48:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217844.378040 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg2xM-0002H9-Br; Thu, 28 Oct 2021 10:48:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217844.378040; Thu, 28 Oct 2021 10:48:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg2xM-0002H2-8W; Thu, 28 Oct 2021 10:48:24 +0000
Received: by outflank-mailman (input) for mailman id 217844;
 Thu, 28 Oct 2021 10:48:22 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mg2xK-0002Gw-Rb
 for xen-devel@lists.xenproject.org; Thu, 28 Oct 2021 10:48:22 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mg2xJ-0005Pp-E0; Thu, 28 Oct 2021 10:48:21 +0000
Received: from 54-240-197-225.amazon.com ([54.240.197.225] helo=[10.7.236.13])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mg2xJ-0000FV-7M; Thu, 28 Oct 2021 10:48:21 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=eYZYMJPfUDtKec0PE+3l3jBDCoirZbSHATOkABGhIBE=; b=TuwOsuB19lNkWCSAGWuiPfTdnL
	6y4yeCWVXb/gCvXegjXiaYw7nxrzsXq+VME+yPonJKbGVrCYHYa6ptZFzJEcn1vYr41fWy0IXY7pz
	P3+aj2yDP2SsZR7UCPgnPuDJxyibWt2KiXqb8jA+LEUvHEiqlTU6UfZXsokG9jj9lExY=;
Message-ID: <c3602294-0ab4-10df-77cc-2a9e13ddc73f@xen.org>
Date: Thu, 28 Oct 2021 11:48:19 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.2.1
Subject: Re: [PATCH] xen/arm: do not try to add pci-domain for disabled
 devices
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: Oleksandr Andrushchenko <andr2000@gmail.com>,
 xen-devel@lists.xenproject.org, iwj@xenproject.org,
 bertrand.marquis@arm.com, rahul.singh@arm.com,
 Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
References: <20211027083730.1406947-1-andr2000@gmail.com>
 <7a97bbef-68a9-8f52-0c93-88d4e84a07fc@xen.org>
 <alpine.DEB.2.21.2110271649240.20134@sstabellini-ThinkPad-T480s>
From: Julien Grall <julien@xen.org>
In-Reply-To: <alpine.DEB.2.21.2110271649240.20134@sstabellini-ThinkPad-T480s>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Stefano,

On 28/10/2021 00:57, Stefano Stabellini wrote:
> On Wed, 27 Oct 2021, Julien Grall wrote:
>> Hi Oleksandr,
>>
>> On 27/10/2021 09:37, Oleksandr Andrushchenko wrote:
>>> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
>>>
>>> If a PCI host bridge device is present in the device tree, but is
>>> disabled, then its PCI host bridge driver was not instantiated.
>>> This results in the following panic during Xen start:
>>>
>>> (XEN) Device tree generation failed (-22).
>>
>> It would good to clarify in the commit message where the error is coming from.
>> I think this is from pci_get_host_bridge_segment().
>>
>>> (XEN)
>>> (XEN) ****************************************
>>> (XEN) Panic on CPU 0:
>>> (XEN) Could not set up DOM0 guest OS
>>> (XEN) ****************************************
>>>
>>> Fix this by not adding linux,pci-domain property for hwdom if it is
>>> neither available nor device enabled.
>>  From my reading of the binding [1], the property should be present in all the
>> hostbridges if one specify it. IOW, I think the property should also be added
>> for hostbridges that are not available.
> 
> Just wanted to say that I think you are right:
> 
> """
> It is required to either not set this property at all or set it for all
> host bridges in the system, otherwise potentially conflicting domain numbers
> may be assigned to root buses behind different host bridges.  The domain
> number for each host bridge in the system must be unique.
> """
> 
> and I am ready to believe device trees with disabled bridges might have
> (incorrectly) ignored the rule.

Looking at linux/arch/arm64/boot/dts/, there are a few Device-Tree that 
contain the property "linux,pci-domain". All of them seems to also add 
it for disabled hostbridges.

However, I am under the impression that it is more common to have a 
Devide-Tree without any property "linux,pci-domain". When PCI support is 
enabled, Xen will generate the domain ID for the hostbridge and write it 
to the DT.

This doesn't work for disabled hostbridge and I think this is 
Oleksandr's problem. @Oleksandr can you confirm it?

> 
> 
>> AFAICT, Linux will ignore hostbridge that are not available. But it feels to
>> me we are twisting the rule. So, could we consider to allocate an unused
>> number?
> 
> I think that would be fine but it doesn't look easy from the current Xen
> code point of view because the allocation depends on the Xen driver,
> which we don't have. But I'll let others comment on it.
So what matters is Xen doesn't make things worse. We have two cases to care:
   1) Xen only has drivers for a part of the hostbriges
   2) Some hostbriges are disabled

Case 1) will definitely generate a DT that will make Linux unhappy if we 
have don't add the property consistently.

I believe that in case 2), current Linux will not check for the 
consistency. But that something, we probably should avoid to rely on.

I think in the two cases we can generate the domain ID by calling 
pci_get_new_domain_nr().

Now if we have to support inconsistent device-tree. Then we could 
collect the "linux,pci-domain" and find the maximum one. We would 
allocate a number above for any hostbridges with no property.

> Otherwise
> skipping the disabled host bridge node for Dom0 sounds OK.

At the moment, I haven't found any example of Device-Tree where 
"linux,pci-domain" will be only on part of the hostbridges (see above).

So I think we should avoid breaking the rule here at least until we have 
a "real" DT that break it.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Thu Oct 28 11:00:16 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Oct 2021 11:00:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217852.378051 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg38a-0003tf-GG; Thu, 28 Oct 2021 11:00:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217852.378051; Thu, 28 Oct 2021 11:00:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg38a-0003tY-DB; Thu, 28 Oct 2021 11:00:00 +0000
Received: by outflank-mailman (input) for mailman id 217852;
 Thu, 28 Oct 2021 10:59:58 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=vfrR=PQ=suse.com=jgross@srs-us1.protection.inumbo.net>)
 id 1mg38Y-0003tS-Kn
 for xen-devel@lists.xenproject.org; Thu, 28 Oct 2021 10:59:58 +0000
Received: from smtp-out2.suse.de (unknown [195.135.220.29])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 2fd3e766-37de-11ec-849d-12813bfff9fa;
 Thu, 28 Oct 2021 10:59:57 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 454D91FD4B;
 Thu, 28 Oct 2021 10:59:56 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 07D4713C5C;
 Thu, 28 Oct 2021 10:59:56 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id opa6AKyCemGQNgAAMHmgww
 (envelope-from <jgross@suse.com>); Thu, 28 Oct 2021 10:59:56 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2fd3e766-37de-11ec-849d-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1635418796; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding;
	bh=zbNYXie6Hzu/qw+CQlU1pNMVLlxvFSRFIIQVne0mm/A=;
	b=bNz1I6ZABAMt8Dl4G3Tn26G74FtY89yFKIs9oSYIAdBladlFdguRX8/jVEu3rN725BrO4C
	aqnV6fskaxOVK3L71kMUr+uMwiA7gKJQBRpXB4MDDNsPpBtRipv/LEPd1uw9yowq6PUP08
	2lKgmbDSHONB5ZySGN9l0z4USVQIkKg=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org,
	linux-kernel@vger.kernel.org
Cc: Juergen Gross <jgross@suse.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	stable@vger.kernel.org,
	=?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
Subject: [PATCH] xen/balloon: add late_initcall_sync() for initial ballooning done
Date: Thu, 28 Oct 2021 12:59:52 +0200
Message-Id: <20211028105952.10011-1-jgross@suse.com>
X-Mailer: git-send-email 2.26.2
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

When running as PVH or HVM guest with actual memory < max memory the
hypervisor is using "populate on demand" in order to allow the guest
to balloon down from its maximum memory size. For this to work
correctly the guest must not touch more memory pages than its target
memory size as otherwise the PoD cache will be exhausted and the guest
is crashed as a result of that.

In extreme cases ballooning down might not be finished today before
the init process is started, which can consume lots of memory.

In order to avoid random boot crashes in such cases, add a late init
call to wait for ballooning down having finished for PVH/HVM guests.

Cc: <stable@vger.kernel.org>
Reported-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
Signed-off-by: Juergen Gross <jgross@suse.com>
---
 drivers/xen/balloon.c | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/drivers/xen/balloon.c b/drivers/xen/balloon.c
index 3a50f097ed3e..d19b851c3d3b 100644
--- a/drivers/xen/balloon.c
+++ b/drivers/xen/balloon.c
@@ -765,3 +765,23 @@ static int __init balloon_init(void)
 	return 0;
 }
 subsys_initcall(balloon_init);
+
+static int __init balloon_wait_finish(void)
+{
+	if (!xen_domain())
+		return -ENODEV;
+
+	/* PV guests don't need to wait. */
+	if (xen_pv_domain() || !current_credit())
+		return 0;
+
+	pr_info("Waiting for initial ballooning down having finished.\n");
+
+	while (current_credit())
+		schedule_timeout_interruptible(HZ / 10);
+
+	pr_info("Initial ballooning down finished.\n");
+
+	return 0;
+}
+late_initcall_sync(balloon_wait_finish);
-- 
2.26.2



From xen-devel-bounces@lists.xenproject.org Thu Oct 28 11:01:21 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Oct 2021 11:01:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217857.378062 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg39n-0005FT-SF; Thu, 28 Oct 2021 11:01:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217857.378062; Thu, 28 Oct 2021 11:01:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg39n-0005FM-Nd; Thu, 28 Oct 2021 11:01:15 +0000
Received: by outflank-mailman (input) for mailman id 217857;
 Thu, 28 Oct 2021 11:01:14 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Cvms=PQ=linux.intel.com=andriy.shevchenko@srs-us1.protection.inumbo.net>)
 id 1mg39m-0005F6-JP
 for xen-devel@lists.xenproject.org; Thu, 28 Oct 2021 11:01:14 +0000
Received: from mga07.intel.com (unknown [134.134.136.100])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 5cc50fd4-37de-11ec-849d-12813bfff9fa;
 Thu, 28 Oct 2021 11:01:13 +0000 (UTC)
Received: from orsmga006.jf.intel.com ([10.7.209.51])
 by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 28 Oct 2021 04:01:11 -0700
Received: from smile.fi.intel.com ([10.237.72.184])
 by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 28 Oct 2021 04:00:54 -0700
Received: from andy by smile.fi.intel.com with local (Exim 4.95)
 (envelope-from <andriy.shevchenko@linux.intel.com>)
 id 1mg395-001jY2-If; Thu, 28 Oct 2021 14:00:31 +0300
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5cc50fd4-37de-11ec-849d-12813bfff9fa
X-IronPort-AV: E=McAfee;i="6200,9189,10150"; a="293839153"
X-IronPort-AV: E=Sophos;i="5.87,189,1631602800"; 
   d="scan'208";a="293839153"
X-IronPort-AV: E=Sophos;i="5.87,189,1631602800"; 
   d="scan'208";a="447649034"
Date: Thu, 28 Oct 2021 14:00:31 +0300
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Dmitry Osipenko <digetx@gmail.com>
Cc: Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Lee Jones <lee.jones@linaro.org>,
	"Rafael J . Wysocki" <rafael@kernel.org>,
	Mark Brown <broonie@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Russell King <linux@armlinux.org.uk>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>, Guo Ren <guoren@kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Greg Ungerer <gerg@linux-m68k.org>,
	Joshua Thompson <funaho@jurai.org>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Nick Hu <nickhu@andestech.com>, Greentime Hu <green.hu@gmail.com>,
	Vincent Chen <deanbo422@gmail.com>,
	"James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
	Helge Deller <deller@gmx.de>, Michael Ellerman <mpe@ellerman.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Rich Felker <dalias@libc.org>, Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>, x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Len Brown <lenb@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Chen-Yu Tsai <wens@csie.org>,
	Jonathan =?iso-8859-1?Q?Neusch=E4fer?= <j.neuschaefer@gmx.net>,
	Tony Lindgren <tony@atomide.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Vladimir Zapolskiy <vz@mleia.com>,
	Avi Fishman <avifishman70@gmail.com>,
	Tomer Maimon <tmaimon77@gmail.com>,
	Tali Perry <tali.perry1@gmail.com>,
	Patrick Venture <venture@google.com>, Nancy Yuen <yuenn@google.com>,
	Benjamin Fair <benjaminfair@google.com>,
	Pavel Machek <pavel@ucw.cz>, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-csky@vger.kernel.org,
	linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org,
	linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org,
	linux-sh@vger.kernel.org, xen-devel@lists.xenproject.org,
	linux-acpi@vger.kernel.org, linux-omap@vger.kernel.org,
	openbmc@lists.ozlabs.org, linux-tegra@vger.kernel.org,
	linux-pm@vger.kernel.org
Subject: Re: [PATCH v2 03/45] notifier: Add
 atomic/blocking_notifier_has_unique_priority()
Message-ID: <YXqCz/utp2DFJJ45@smile.fi.intel.com>
References: <20211027211715.12671-1-digetx@gmail.com>
 <20211027211715.12671-4-digetx@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211027211715.12671-4-digetx@gmail.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo

On Thu, Oct 28, 2021 at 12:16:33AM +0300, Dmitry Osipenko wrote:
> Add atomic/blocking_notifier_has_unique_priority() helpers which return
> true if given handler has unique priority.

...

> +/**
> + *	atomic_notifier_has_unique_priority - Checks whether notifier's priority is unique
> + *	@nh: Pointer to head of the atomic notifier chain
> + *	@n: Entry in notifier chain to check
> + *
> + *	Checks whether there is another notifier in the chain with the same priority.
> + *	Must be called in process context.
> + *
> + *	Returns true if priority is unique, false otherwise.

Why this indentation?

> + */
> +bool atomic_notifier_has_unique_priority(struct atomic_notifier_head *nh,
> +		struct notifier_block *n)
> +{
> +	struct notifier_block **nl = &nh->head;
> +	unsigned long flags;
> +	bool ret = true;
> +
> +	spin_lock_irqsave(&nh->lock, flags);
> +
> +	while ((*nl) != NULL && (*nl)->priority >= n->priority) {

' != NULL' is redundant.

> +		if ((*nl)->priority == n->priority && (*nl) != n) {
> +			ret = false;
> +			break;
> +		}
> +
> +		nl = &((*nl)->next);
> +	}
> +
> +	spin_unlock_irqrestore(&nh->lock, flags);
> +
> +	return ret;
> +}

...

> +	/*
> +	 * This code gets used during boot-up, when task switching is
> +	 * not yet working and interrupts must remain disabled.  At

One space is enough.

> +	 * such times we must not call down_write().
> +	 */

> +	while ((*nl) != NULL && (*nl)->priority >= n->priority) {

' != NULL' is not needed.

> +		if ((*nl)->priority == n->priority && (*nl) != n) {
> +			ret = false;
> +			break;
> +		}
> +
> +		nl = &((*nl)->next);
> +	}

-- 
With Best Regards,
Andy Shevchenko




From xen-devel-bounces@lists.xenproject.org Thu Oct 28 11:02:42 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Oct 2021 11:02:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217866.378072 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg3B7-0005sH-6D; Thu, 28 Oct 2021 11:02:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217866.378072; Thu, 28 Oct 2021 11:02:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg3B7-0005sA-2x; Thu, 28 Oct 2021 11:02:37 +0000
Received: by outflank-mailman (input) for mailman id 217866;
 Thu, 28 Oct 2021 11:02:36 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ikAZ=PQ=epam.com=prvs=19352d112c=oleksandr_andrushchenko@srs-us1.protection.inumbo.net>)
 id 1mg3B6-0005s2-GJ
 for xen-devel@lists.xenproject.org; Thu, 28 Oct 2021 11:02:36 +0000
Received: from mx0b-0039f301.pphosted.com (unknown [148.163.137.242])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 8e36c030-37de-11ec-849d-12813bfff9fa;
 Thu, 28 Oct 2021 11:02:35 +0000 (UTC)
Received: from pps.filterd (m0174680.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 19S9dPcc017739; 
 Thu, 28 Oct 2021 11:02:33 GMT
Received: from eur02-he1-obe.outbound.protection.outlook.com
 (mail-he1eur02lp2056.outbound.protection.outlook.com [104.47.5.56])
 by mx0b-0039f301.pphosted.com with ESMTP id 3byr860p2m-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Thu, 28 Oct 2021 11:02:19 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by VI1PR0302MB2832.eurprd03.prod.outlook.com (2603:10a6:800:e2::15)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.20; Thu, 28 Oct
 2021 11:01:59 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::c038:e032:595a:651]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::c038:e032:595a:651%9]) with mapi id 15.20.4649.015; Thu, 28 Oct 2021
 11:01:59 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8e36c030-37de-11ec-849d-12813bfff9fa
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=LJdC6HbESxAW1rX2Usv6+w1J/nE02+/QBDfl69pKyTnfof9XKNtIfc48Kjs/0pswXhE3VrQ7TjWvSiiz49hwcB7N0b3417rg24MCllDdjDhxpCGByR30Wxj/GyN7RsJVDSymoBTMiWld6e1I03srlmifqndy5aUQXXebBQiC+f2bc62zF8Upgqfeefk8v92G+MwhwiRUx3R+cwpM8VRnaiaojST6vxvoUiIq7mBnB9h2mA8hLG6BScYox6NUzf/0+bI/svW9M39uvFp7mIb27upY1IlJQKlw82z3uBO6z1PCYY1trx6ecZd9Uu3Yzo2cnakuz8B67UDqX3chhPtwKQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Cna+XBVUvbxaMDXQFakSFpPkvrHlNy9J4yfLgCRUvKM=;
 b=JG2wbq84pw9/ZoSGXQ6Ts1EbRVaCcVUF3aPApcbN3juapWrVnuhTbR1ZjM/dJxMOvHM1HxwiLyiLpTpy0X85OfdacxW+dPxhk1Okx6tJ/007T5/JbYEn9G7OEp+PB7FqaxhP+E7bJzZ9eTDRr+ymOKOvjQNvggkT+cdd6F9K7AhoazjwQnC7ceGgr6TgmQp6K5cFfEccevDqb+7VoJjgsrRif+nbSftfamrQemUEnWq7acRfJlcyNd4n5zA4Je87R0AyFnJ485DpUx68pvn8DtYO6OwBVLqAKR8Islp0bx0eCjw6kFZLRhtkScbbnc5aXet3R6gWhw2v8vGgET5lRQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Cna+XBVUvbxaMDXQFakSFpPkvrHlNy9J4yfLgCRUvKM=;
 b=TG56jZ0XL22SYC7f6MuCk7Kck54rp+ZBq2YEKTOdyqTYMI/ABU01WSHG767V40vM3jQOJODsUe55PWk67EoJ7choe+rL8n5sKg0IybNNvD84b0XvYxVtaq68n0YETVczmvLPzcZsBOUSY6ZCNn5uckrth0KpuuoxucDzlrzi7qsnyvLeixn27WxyENc7zYqgSbI61uK0B5TXCqXP3xQb35gUYPE7PL42gCLzzqD5V9+kGKJ8m5AdgAOp11QFsUNTTQLPlvKECLsK579f+ZqyGuKVz59uf9AD5GJntzmE2YqKR1EOX0cUNHSUObLMRMZw1uHhBP4y4lWKTTJZHTIhTA==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        "iwj@xenproject.org" <iwj@xenproject.org>,
        Bertrand Marquis
	<bertrand.marquis@arm.com>,
        Rahul Singh <rahul.singh@arm.com>
Subject: Re: [PATCH] xen/arm: do not try to add pci-domain for disabled
 devices
Thread-Topic: [PATCH] xen/arm: do not try to add pci-domain for disabled
 devices
Thread-Index: AQHXyw3lMiQK+jRYtUWdkzZ53OfPJavnJMeAgABhyQCAALX3gIAAA8+A
Date: Thu, 28 Oct 2021 11:01:59 +0000
Message-ID: <1bb4f2d7-958f-4408-c04e-88d9b580d2a2@epam.com>
References: <20211027083730.1406947-1-andr2000@gmail.com>
 <7a97bbef-68a9-8f52-0c93-88d4e84a07fc@xen.org>
 <alpine.DEB.2.21.2110271649240.20134@sstabellini-ThinkPad-T480s>
 <c3602294-0ab4-10df-77cc-2a9e13ddc73f@xen.org>
In-Reply-To: <c3602294-0ab4-10df-77cc-2a9e13ddc73f@xen.org>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 22de76ff-9649-4f62-1381-08d99a025d28
x-ms-traffictypediagnostic: VI1PR0302MB2832:
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <VI1PR0302MB28321972BA284005A43CA5E9E7869@VI1PR0302MB2832.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:8273;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 jnBwJ+m505kFdw2xNR0pUdJDQnU4O8U3v5QIi2X+WGFZ/h9t+rY3nCXFFjO+ODTn0TNy4ZOa2bZ5eq5q+5S3ToxVZUWMc8lwFBejR2TYke1F/H8qFWzGHzuTdCUqvxLlkrPxUBJgjXaMmd5wqVdy59uZbiZi46und1+Hwojc6kW3p4YJVZC9L4aiFXh7agC5s4iRGogPDbf4+QPnvDTGNPfFMYqL7UkTxwsULx+Ky9SREE8jGa8NZSH0VRHK/jMNXdJahIj9gm0KfUQrxxFURQyHhA9DuNRufBCUUmc1D7x/dMassFQzqGv5URK+O0f+MQQvhk8f/ExO6vYqTum3lkA7OLGQTf5k/93r9So3IIHREy2FEeRVLG4qvRzKZNK5F+RHQy5apGC0Wqfhg8As/dYkoclK28xQ0jvAjlxkQN2dnt45D/f3OAsNgd3i9vb1ijJZmylVsy07tvULtn+mg8twlLeWMbV0uvN9/Bdd6wg7mqIFNyODxJ9zjg4xFBFjfqB/vZx5lrBd9Y+RkMCCQdQ8kKdS4V6xOUj0ZzKxjV62xZA3eHNIdg3cQYdL/TjELZewV6xahS+qhFNeRqHHUrei7heSb3jXTY7UZFmVE6nsGDjVbC3ZPHb8Nh6+2O6zNVv0kBWPHU2J3r/6LiZNXKzYWwINuZ6ZO4kt3ntg7yK+wEjOMF+m89tDMYMKjNwoBIfBkRAmtxwfP22+qfXQDrv7S2eS7Inum+4vPpWOW20gIKtuoAbtD27IMkkpjMHE
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(53546011)(26005)(122000001)(66446008)(8936002)(186003)(91956017)(83380400001)(508600001)(5660300002)(31696002)(8676002)(66946007)(4326008)(54906003)(2616005)(36756003)(6486002)(71200400001)(31686004)(38070700005)(86362001)(66556008)(4744005)(55236004)(6512007)(2906002)(316002)(64756008)(110136005)(38100700002)(66476007)(6506007)(76116006)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?Y1pJUjdQd21oTG1QMGdhVDNGR3FZTVNlZ3Q2dHRJQTRwa1JQOXRLejBwSkpP?=
 =?utf-8?B?Q0RBd1I2YnB5NkdDcVdOVmJjb0dnb1VDa3JtQ3Q2a215RmZMdmxzSXhkb2pH?=
 =?utf-8?B?dEM2ck03Ukg5eFUxMWtYS2Y1VHhMM1RrR0laM2d4aGhyUXpMYTVWYmkwMHpi?=
 =?utf-8?B?Zk5jRUc2Wm9qM0hYR2wzZWlXVXltRlMrQXUyL3J0d2VBMzh2a2ZLRmlQRUZ0?=
 =?utf-8?B?OCttMyt4a3lGaU14MVBacnlEcXB3dUY5dlloR3gxbnpZb2ZsTWYxT0dTOEV4?=
 =?utf-8?B?K1pUQmVnVk51R2lsaXNwZGdWbDd2VDNJMVBPSGJkU3pRS0xRYjJBcEkrOHBp?=
 =?utf-8?B?S0pxa1R6VGd5QTdqMXhBYytzYjZYQTFHZmlhbm93aVZsenpDamNJYlNwdVBk?=
 =?utf-8?B?VUl2S0FqeUNIMk9QWmZtcFZhdzBTaitSdTMzYUtPQXBiY2Vmb1YxbmZxN1hm?=
 =?utf-8?B?TDFwUTRNOVBRbEpPVzZIY3JkSVE0S0gzSUs5cUVydmVzWS9SSkJsV2lEZHZL?=
 =?utf-8?B?WkJIa05IMUU3R1hyTXM4V3RWV2NUT0ZoQWh2YjlObldnbi80Q2ZnVDBVTFJ2?=
 =?utf-8?B?dkhPVnRnSlYyMHN6MzhadXZ4V21tU21lWjVJOFNES3J3TWtXOWFWTlE2UEtK?=
 =?utf-8?B?SW41bHZCbUROeGNmMWVMRzFQVHBZNEdYMS9vdUVxNThEQWlvajM1SCt4ME9q?=
 =?utf-8?B?NllpT1JxNVpZMDd6VUVwYTJiN0I2TnBFK29wVmw0ejh0YWZtb1JnenVVVnlr?=
 =?utf-8?B?MnpkQUYyZXBHbUxDdDVuNTdGVE9UTXRhNU5aTWZiamVZcDAyeDB5NGVsWURs?=
 =?utf-8?B?djF4SFJzckZ5Y1k5SFFWTFBQVGVKRnhVT1RTd2ZtaHNlSFVlM3lUbitTY3ht?=
 =?utf-8?B?WmFFdnJBU0xjR2dGNm80eVM4VlZtQVhlM1ZsZVBidWFMcFlpWG1ORTZhSDF2?=
 =?utf-8?B?S1J4QzVBR0VUYjNqUWhvTUZXdlgzdkQ4Nk1sMllpWG5HbXN1K2lVU2N2eFMr?=
 =?utf-8?B?VXY0VDVBa0cyMld0VzA1Ly9MWEhVQ2FwNVFQa0hITmpFM21nVEZjRGZSc1gr?=
 =?utf-8?B?RjdGMksvaEpTa3o3UXNPZHNCM2lXTzQ0MEE0dktTQ3NqSXRnT24zZWJRcmRM?=
 =?utf-8?B?YlBETTJPajA2VTlVMkVxazFDZXY0alVvRys0RWhzeVR6NzJRNklnYWtwVEYv?=
 =?utf-8?B?ME9VQkIzR2gzQ29vaVVwZ2k4VWFjU01hQ3BQR0FkUkFsdzZrT081aWJvblBV?=
 =?utf-8?B?YTNtSzdySStLNFBjR0toM0RUTzVoS1lvWkxMeUx5cmErZ0syV0xXOWVWcUlZ?=
 =?utf-8?B?dnJKdDhUVTNnVWNVSVFmSXhzbUFROFdFVTExcGZwNE1paWJ0TUErbFBGQnI0?=
 =?utf-8?B?a0szckhYUjloVzB6d1U2cHFYOTJ3R2x1eFdOMHdRT3IzcHl3ME44VmdxcXkw?=
 =?utf-8?B?S2ZVUGs2YWNTTGNJYTBqVzk4Tm5FcnpLK1hjTGQ4NGlDN2VLSkZwL081QjVp?=
 =?utf-8?B?eWZjSnV3L0hxS0hXNlo2SUtFSzJoeGZaWFU3dnY4NFQ2SmRyWHpoQVg5ZGxo?=
 =?utf-8?B?YWV5amczMkN3bVkrdHRGelFoaUNtOGU2MjhaSFBYVVdmL0tDaG8rL2VZVFJQ?=
 =?utf-8?B?ZnE1dFIvMmNtOUVMNEU0OEIyS0pTQW9BOUFZaWJuMnp5NFUyV1ZJV0orZG42?=
 =?utf-8?B?MUdDRTlzdlROMnJ1NnVHNzBOZk5Ma0RxcVgvSGoyVUNicElCc09jY0xCTzFS?=
 =?utf-8?B?RDNyVFRRelg3aEVGaXl1S2M2VnRxai9FUXVxVUg1MGhqaVA5NzQ3M0hEczhL?=
 =?utf-8?B?RE9Md3g1dDcyZGEvbzZsYU0zSVRCUVk0SlZxTjgwck16b2lyWXNrNXBtRW9M?=
 =?utf-8?B?RFdpVkN1aTJ0ZmNtNm5VMlNIV3pYQjNlKzJxMDRtMmhkWEhRdmVUY2N1NDc0?=
 =?utf-8?B?RWhOZEU5V3laTFRJUVhub2pROXNjbXpnQW90Z0tNeS9GOGtVWVRadG9FbnhU?=
 =?utf-8?B?aS8yTW8rT28rZUo0TkFjM0I0NU5IblhJK2lucEs5MWFOUW9hSk1mWUZPb252?=
 =?utf-8?B?SlRFcjZzWWo3a3JjV2xlTzd6R21LdUVlVDc0OSt4bFlaMzhXZE8zeUxzMHBX?=
 =?utf-8?B?MHhyQzdXZTBQNU05cE9BclVvRmNQT2xxd1hITS8zTU0xbFo3eXFzNjNLd3By?=
 =?utf-8?B?Z2RYQkM4OUxXNkNERFozdVZPUHgvdDBnekw1V0xIdmVpYXNqalZUbURaZENW?=
 =?utf-8?B?ak1pUXFoV3pWWUZzdlFCUmRzMjgwN0tUcGlpbldHaHFoalpJVXRIb0RZeTlT?=
 =?utf-8?B?aXhDamVoL0JGMDQyaHBBV2RncUFTc3YrcG5HMDJDZG1FSy9EY1JBZz09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <84E88C74473D644293955029C14D4A42@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 22de76ff-9649-4f62-1381-08d99a025d28
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Oct 2021 11:01:59.1761
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: rNHUEtzSb4/rwiUsik+PYbDqXyyXqJaWWA5MzORKjesugFakxueSlR6qsgmrEEjBfVNFp25bajsKTU5ih9bMgMi8rJVc79E8RNJef2HT6ihcWXZxvhS/ILKMCx93RWrc
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0302MB2832
X-Proofpoint-GUID: aXNDcDNCBjxtsIlcf7SV4ZdvcyQlSTq7
X-Proofpoint-ORIG-GUID: aXNDcDNCBjxtsIlcf7SV4ZdvcyQlSTq7
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475
 definitions=2021-10-28_01,2021-10-26_01,2020-04-07_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=640 clxscore=1015
 malwarescore=0 spamscore=0 impostorscore=0 suspectscore=0 phishscore=0
 mlxscore=0 lowpriorityscore=0 priorityscore=1501 adultscore=0 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2110280061

SGksIEp1bGllbiENCg0KW3NuaXBdDQpPbiAyOC4xMC4yMSAxMzo0OCwgSnVsaWVuIEdyYWxsIHdy
b3RlOg0KPiBIaSBTdGVmYW5vLA0KPg0KPiBMb29raW5nIGF0IGxpbnV4L2FyY2gvYXJtNjQvYm9v
dC9kdHMvLCB0aGVyZSBhcmUgYSBmZXcgRGV2aWNlLVRyZWUgdGhhdCBjb250YWluIHRoZSBwcm9w
ZXJ0eSAibGludXgscGNpLWRvbWFpbiIuIEFsbCBvZiB0aGVtIHNlZW1zIHRvIGFsc28gYWRkIGl0
IGZvciBkaXNhYmxlZCBob3N0YnJpZGdlcy4NCj4NCj4gSG93ZXZlciwgSSBhbSB1bmRlciB0aGUg
aW1wcmVzc2lvbiB0aGF0IGl0IGlzIG1vcmUgY29tbW9uIHRvIGhhdmUgYSBEZXZpZGUtVHJlZSB3
aXRob3V0IGFueSBwcm9wZXJ0eSAibGludXgscGNpLWRvbWFpbiIuIFdoZW4gUENJIHN1cHBvcnQg
aXMgZW5hYmxlZCwgWGVuIHdpbGwgZ2VuZXJhdGUgdGhlIGRvbWFpbiBJRCBmb3IgdGhlIGhvc3Ri
cmlkZ2UgYW5kIHdyaXRlIGl0IHRvIHRoZSBEVC4NCj4NCj4gVGhpcyBkb2Vzbid0IHdvcmsgZm9y
IGRpc2FibGVkIGhvc3RicmlkZ2UgYW5kIEkgdGhpbmsgdGhpcyBpcyBPbGVrc2FuZHIncyBwcm9i
bGVtLiBAT2xla3NhbmRyIGNhbiB5b3UgY29uZmlybSBpdD8NClllcywgd2hhdCBJIGhhdmUgaXMg
YSBkaXNhYmxlZCBub2RlIHdpdGhvdXQgImxpbnV4LHBjaS1kb21haW4i


From xen-devel-bounces@lists.xenproject.org Thu Oct 28 11:04:04 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Oct 2021 11:04:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217873.378083 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg3CL-0006Uh-Gk; Thu, 28 Oct 2021 11:03:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217873.378083; Thu, 28 Oct 2021 11:03:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg3CL-0006Ua-Dm; Thu, 28 Oct 2021 11:03:53 +0000
Received: by outflank-mailman (input) for mailman id 217873;
 Thu, 28 Oct 2021 11:03:52 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mg3CK-0006UQ-66
 for xen-devel@lists.xenproject.org; Thu, 28 Oct 2021 11:03:52 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mg3CI-0005ht-0O; Thu, 28 Oct 2021 11:03:50 +0000
Received: from 54-240-197-225.amazon.com ([54.240.197.225] helo=[10.7.236.13])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mg3CH-0001Lh-Qq; Thu, 28 Oct 2021 11:03:49 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=R910lvvlJXVIuwagQjRDlCiMvr2RrUoISl2d6FGyCVs=; b=g8abL9ULP0DjYb09EEsUUfX0tt
	FG4hR8FBDgOeEyupjIbT1JfRJ+DgS9JbH4VyoxLWbZVl36BnXAzasgX84VXXS7dL3O/N59zgu7ACA
	xwprrvkK/EL0u36ojSUx1Kx3PsvcvoD5b2o1WEx3gVjd733hrdafqdqEodiG3aa5dsG0=;
Message-ID: <3c6efc32-3e3f-6a26-952c-6347501b8a78@xen.org>
Date: Thu, 28 Oct 2021 12:03:47 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.2.1
Subject: Re: [PATCH] xen/arm: do not try to add pci-domain for disabled
 devices
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>,
 Stefano Stabellini <sstabellini@kernel.org>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 "iwj@xenproject.org" <iwj@xenproject.org>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Rahul Singh <rahul.singh@arm.com>
References: <20211027083730.1406947-1-andr2000@gmail.com>
 <7a97bbef-68a9-8f52-0c93-88d4e84a07fc@xen.org>
 <alpine.DEB.2.21.2110271649240.20134@sstabellini-ThinkPad-T480s>
 <c3602294-0ab4-10df-77cc-2a9e13ddc73f@xen.org>
 <1bb4f2d7-958f-4408-c04e-88d9b580d2a2@epam.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <1bb4f2d7-958f-4408-c04e-88d9b580d2a2@epam.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit



On 28/10/2021 12:01, Oleksandr Andrushchenko wrote:
> Hi, Julien!
> 
> [snip]
> On 28.10.21 13:48, Julien Grall wrote:
>> Hi Stefano,
>>
>> Looking at linux/arch/arm64/boot/dts/, there are a few Device-Tree that contain the property "linux,pci-domain". All of them seems to also add it for disabled hostbridges.
>>
>> However, I am under the impression that it is more common to have a Devide-Tree without any property "linux,pci-domain". When PCI support is enabled, Xen will generate the domain ID for the hostbridge and write it to the DT.
>>
>> This doesn't work for disabled hostbridge and I think this is Oleksandr's problem. @Oleksandr can you confirm it?
> Yes, what I have is a disabled node without "linux,pci-domain"

Just to confirm, is it the same for enabled hostbridges?

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Thu Oct 28 11:11:45 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Oct 2021 11:11:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217880.378095 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg3Jo-000827-Bm; Thu, 28 Oct 2021 11:11:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217880.378095; Thu, 28 Oct 2021 11:11:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg3Jo-000820-8P; Thu, 28 Oct 2021 11:11:36 +0000
Received: by outflank-mailman (input) for mailman id 217880;
 Thu, 28 Oct 2021 11:11:34 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ikAZ=PQ=epam.com=prvs=19352d112c=oleksandr_andrushchenko@srs-us1.protection.inumbo.net>)
 id 1mg3Jm-00081u-4P
 for xen-devel@lists.xenproject.org; Thu, 28 Oct 2021 11:11:34 +0000
Received: from mx0b-0039f301.pphosted.com (unknown [148.163.137.242])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id c897fe9f-6d2f-415e-8c99-2ce44c5ac7b5;
 Thu, 28 Oct 2021 11:11:31 +0000 (UTC)
Received: from pps.filterd (m0174683.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.0.43) with SMTP id 19SB8Edp019805;
 Thu, 28 Oct 2021 11:11:30 GMT
Received: from eur01-ve1-obe.outbound.protection.outlook.com
 (mail-ve1eur01lp2054.outbound.protection.outlook.com [104.47.1.54])
 by mx0b-0039f301.pphosted.com with ESMTP id 3bytqh80ej-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Thu, 28 Oct 2021 11:11:30 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by AM9PR03MB6770.eurprd03.prod.outlook.com (2603:10a6:20b:283::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.15; Thu, 28 Oct
 2021 11:11:23 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::c038:e032:595a:651]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::c038:e032:595a:651%9]) with mapi id 15.20.4649.015; Thu, 28 Oct 2021
 11:11:23 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c897fe9f-6d2f-415e-8c99-2ce44c5ac7b5
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=lUKor2PbqwFUAxx/qSeU2GU4e2b9wjBVOx0GkS+yLAMsoOTdfl79R6CopafoKVarqjDU2KDTN3lILG7vjxzWee1jSiLQ2LyJXr0AY+qXxL7G63SXJgbW/x6Bvyp9+Fm/10CqxsN5jbdh5x348N9NE9lyd7vus6JR+WDxWDvhVGdkKdnD6gZUqA0jpFTUG5z5Jmt8iVuoTnr5nWAQtnJOd15sUbsc+d2BMELdZ0k9Egvfu9OClxbJ0Uf6lYRK7LLTJkyKiyhabpTfJ9PB4cCfDCHOGyZJhU+GWc8yrZTx1ASUF1S8QbvuEDCn1IwnU1xn90v0mEsM9AM8sx6esfsd2A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=7XE1DNF78RLY3YWtWlW6oEyxJ3XO2LTZWjFEO7rBssQ=;
 b=ahs4uOpnD8trXqZFFKtVhCk7DRKgewpx4DZXVIkaD+F6y335DR2uU+ILBYF+mIp4ItF4AR3sBhXrcZp38qti9HCl1yrHu0QB3L2z3xRTxLn1PP2NxmTg44IF7FyeuyR/WBZATbDSCBCme3i4j9isACndWZD2gv6sdWGnq4rqcPvXedNVZyHvYxc1q4hOVrIk75KSYzERfv2H/QX2BFE6mPscRInmB/bZ4BmkA81hXopSX+K4LDQrqZM7CjuYFfXBXNetJY1RkuVX92Mbgqad89fduqxrubdrK0PwphF68QdqQInGeS0CDzZoa+ejFvNnSQOzer/vSfyVGpMdLUJGSQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=7XE1DNF78RLY3YWtWlW6oEyxJ3XO2LTZWjFEO7rBssQ=;
 b=fYW7GwTPXyZIc3hx3ndg3FtOsMkFIwX5R+gQ5qLMpzCqI5kvNWTG5Gs4NjMvd3hCOOz1Wxu53jYIrvHWATbRXCHDMo+7MD+saqz9Rul/V+NgIizglRpZARaSacDHAYewKV3UJK+f1negmLLiut1ofvpsbqk9fsExKIlqTirTfufKKqdB8oDYzwrPihfZtGbkw5aP3712OczQV+0tmU7N8Q5rgKDA5B3uOAAO2hJp03115AWA0ZNygwY88cnn6Rkwowy7XurAiS3cD1DTAPLW3Y5Qa7eSJo0AlyxypDCRVLCwCfg4SsXGYX1bk7evoaPQckfQj0Y9rL4I9EM9gAdWVg==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        "iwj@xenproject.org" <iwj@xenproject.org>,
        Bertrand Marquis
	<bertrand.marquis@arm.com>,
        Rahul Singh <rahul.singh@arm.com>
Subject: Re: [PATCH] xen/arm: do not try to add pci-domain for disabled
 devices
Thread-Topic: [PATCH] xen/arm: do not try to add pci-domain for disabled
 devices
Thread-Index: 
 AQHXyw3lMiQK+jRYtUWdkzZ53OfPJavnJMeAgABhyQCAALX3gIAAA8+AgAAAg4CAAAIfAA==
Date: Thu, 28 Oct 2021 11:11:23 +0000
Message-ID: <dc8c8794-b896-dbc3-1fe5-f4b8c84b4f96@epam.com>
References: <20211027083730.1406947-1-andr2000@gmail.com>
 <7a97bbef-68a9-8f52-0c93-88d4e84a07fc@xen.org>
 <alpine.DEB.2.21.2110271649240.20134@sstabellini-ThinkPad-T480s>
 <c3602294-0ab4-10df-77cc-2a9e13ddc73f@xen.org>
 <1bb4f2d7-958f-4408-c04e-88d9b580d2a2@epam.com>
 <3c6efc32-3e3f-6a26-952c-6347501b8a78@xen.org>
In-Reply-To: <3c6efc32-3e3f-6a26-952c-6347501b8a78@xen.org>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: b2aa34b9-a030-4dee-8d14-08d99a03ad58
x-ms-traffictypediagnostic: AM9PR03MB6770:
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <AM9PR03MB6770A14F425F9744671849A7E7869@AM9PR03MB6770.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:8273;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 u6qzlkgpQCOcZho2wePUWkKBx+r4PiqfogFTYNSLFXw04IwM4sPAlLN0ZWmqM6vaIvmgZNNQPvbZIDSNV+pC24nPaF/6PIsl9ek2dDw/JSQktHkJ+QWLXOhyFkj7pGu98LV/L0dcMGTjcpOREYtqRxe5HTrcHOrgwjMtSR34pn3ver1TfdgYWBhU0lweMk/9GJ5FFV7/7Q2SsM4hnRsdLmyarL27C8mqeJQK6ro5+O99w7jgW+xPDEsfi6ZC66Il/YKbfUjTcOneM2ZBlm31p/4XR/DUoEnZlQNzY3/AIq/qSo0EqQnael+nxOjeNi+n8JG8jGQng3sYrKIJbAEKudWwFplz63LiJUuFgwhviERb4Ic+FvaScIyebMG2qJKGRzizHVMG2Dadc7MuKvnCjrJgdmQu/7+y/iG4JQZyOfh87QcsO4SnBfQyJOpPPZgIhlfUHMKG46WXwTmbH65qW8huOXYa0lXfDbWF3GIxPTjfy/s93TI9HNxQ7Swl7uz6v7f20rG7Ughg/087Errxo/0ZKObW6GpnUysW+OxjiUrGynv6AES3CU4hI82VuFzVxl4/H+sbdmjgR2JRnB02Yddnlm9UT+sf4Bv2Q448ExEBSCIHTQHkW4bMWGZ+cTZPLHb9VMgpoNMIxn82OGTOyuhu/zuOmHemfsSNe8L0mJWBE2k0zMj9z2Ge8VDbaffQfwcujTFjSwxuONMHQlHvuGpRyemGy/cUBSe0NJJQdliLJK/GqhtDkZTUt69KuLIQ
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(4744005)(6506007)(53546011)(316002)(54906003)(508600001)(64756008)(5660300002)(6512007)(66446008)(71200400001)(83380400001)(8936002)(8676002)(186003)(26005)(76116006)(55236004)(91956017)(4326008)(110136005)(38070700005)(122000001)(38100700002)(2616005)(66476007)(6486002)(2906002)(66946007)(31686004)(31696002)(66556008)(86362001)(36756003)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?RGNsZXlEdkFsZ1NEMWhSOEhTMUJuUENOUVNMTkl1OXlXbExGazFsaUlEa0Z2?=
 =?utf-8?B?NUpHV2xVbFJkNkk5aDhVQklQRkhVRThEd1BMZXM1V2lWQmYrS0FsVWwzenVE?=
 =?utf-8?B?TkhsOUdTWEUwNGN5MVdMNkUxVGhIM1VMbUh0VE5HVWFGWWxGS0hpRkFEZVQy?=
 =?utf-8?B?VXhkazBXMGpEUm5jNmJIc0NoVzdKZDZOMmV6K05OOG9wUHpUUENEVkJ2TmIx?=
 =?utf-8?B?UlJYMk02QllBbjNQTUIwTExxVmJoTnM4V1V4M2ZRTU0xVGJoMTF1ZGlwZ3dS?=
 =?utf-8?B?WTUxT1llVG9uaFVPRURKUHM2blpMQUxUSm4xa1hvbVVzaU5TQXpldThLOTRN?=
 =?utf-8?B?a2VVeGFzTmNXc1FMTzJPWkJZVm80NXhkcUF1S0pJV0FVZGsrLy94c3BIbEMw?=
 =?utf-8?B?dnRRZmhlUHRadFZmWVZoWktvQVRWS1R3QXRhS1A2cWdsTTJMaklqcDZyVE4v?=
 =?utf-8?B?VlBOUWNnRHo1VjN1bUtPVnp3b1ZacC9HYStCWkMrZERYNkFwcXZna2J6T3dh?=
 =?utf-8?B?OCtzaWR5Rmh4WmE1LzlVR1FLTUtCOEZDVTBLVDlvWDRDcTU5NU1oajNKeFgv?=
 =?utf-8?B?cExFcGVEUmRKWW1zUDdnMGNkZG9adlFiRmNkQ2NZekxnVlUxTFYxM2FCem5a?=
 =?utf-8?B?b1BDQWJPR3ZGSmtYMG50Vm03bE93R1N2QjF0WXpmT0VobTdUcStVTjZPdzJ2?=
 =?utf-8?B?Z2VrZTZPdmZ1c3YvemNRZXpQcDQ1Z05iTEx5MWxKZEN5aDlmV1N5QTlFQVRP?=
 =?utf-8?B?S3hUNk1jZ1JmZzJaMXFxMWZhWDlqMjYxUDFHajJWM0h3eUUwOWlvYUxpbWI4?=
 =?utf-8?B?dXNZaE9hWHVVTkFNVUFpb0RHVzVQdUtXSnFDWVJwRWpRa3NUMEFGa3BEcDlw?=
 =?utf-8?B?OVRvbzZtRkUyWnNIdUlsd1RsakJQNzNOOXZiUXl3SGcxSUZualVYT3NzbklF?=
 =?utf-8?B?aXdWeWVkOExPZy9JVmh5WXR6M2Y5ZUV5UHZKbDB4VlVKa3o3dlFkcVV6dDJL?=
 =?utf-8?B?ZlRZbEVRLy9MdmVERndwRVRkWUtObE9wb2w0U3owdlFsSzcvWkdUNkFLQTAx?=
 =?utf-8?B?T3luU0dhRXRYNjNUcUdZRVRFbnE3anJqSU9iWXZoUngxQTRuVDFUa3p1MVUw?=
 =?utf-8?B?dzVKSUdTc24yS1RhcXFnUkRudDhsRFlvby9wSUQvNW9QVHNMaGtLTnZPNkVm?=
 =?utf-8?B?bjBtd2ZaNlFlSDRIbW1HK1lVeTFLL3pnWmZGcGlBek9BTTFrOHB0UElMTjB4?=
 =?utf-8?B?N1cra3JtRXBiMFZwTHZEREExSVZrOTBVbHlPZWVBQzliSUJwdndlNWxpTzEz?=
 =?utf-8?B?bUNZTm5mVmFsbWw3NUd3cGJNZWcrRXpvNDJLTlVDMzRDOEtQTjlXT0JZSmVv?=
 =?utf-8?B?bHVCS0VvOTZqdTA5ZEszYW5EUGY1Y1ZPTnVpdUN5MXhVcHNjeEJJaDYvbnBM?=
 =?utf-8?B?bE5ZTzZ3QTlXNmhTVnl4K0RTcTFrbTFRQnFtNlN6eVIraGFCditrYk82K2dV?=
 =?utf-8?B?anVQNENSVElnMSsweE1FVXpPQTVBd2tFK09rRHJ0RndCMmNUNVdqWHVUNzQr?=
 =?utf-8?B?R3N2b0RVZGZ2MEZ4Ri9FckZ6ZmFFNjZUaGoxN2VlNVF3UUxoUFBrVGxDblA5?=
 =?utf-8?B?SGdvSlpocUVyUzFKSHB2MXkrSXhhbDZGTUxVUHpVRnJ3STdSRHZ0RVd3TGov?=
 =?utf-8?B?VDR2aUdCV1p5Y0x6ZFZDS1FQMDl4MDhDdGdnejMyamlsMnZEeFJPQnhFNE04?=
 =?utf-8?B?Z0s5bWJnbnpYV2pQRG8zVkE4TlhoazlxbXlPWFNGem1zU1IyV0FPaTFhZTJh?=
 =?utf-8?B?cDVRajN1Rjk3aDArYmtQWkZYMkdONi9uUTJMSExyeUwvSW04eXNIaElqK2dB?=
 =?utf-8?B?Vml6SjJGNXUvZi90MzBpNzZIQWdubHJNaWQ0Y2JQRC94bk1HbEIyZVRGczlS?=
 =?utf-8?B?QTFGU1FzYXdwbEVFK1pLN3Y4Z0o0WTBzREFMS242VW9sVUFQSm9NTnpxdXRm?=
 =?utf-8?B?SlJ6NkU1YjNDTTZJV0VTbkJSZ0dSUytlTXJSazZFdEVHUThVR0M3Uy9sdFpz?=
 =?utf-8?B?c211bFJydTVvS3VORUxMQjEwL3BkMGJOczZ1WWtoWmNlZjBaQjFhcWx5LzI4?=
 =?utf-8?B?S3RSWmtMaW5kQUMzVVd2c1RZbERwNXd4RjlBZFBlaklRVC91OExSVkpLTjRF?=
 =?utf-8?B?SkRaK3dLbFprdk5tVU9oVkcwYXdKelR6SW1DS2R2cGdLcGNmZUVPY3BSbnFQ?=
 =?utf-8?B?TVcyKzNITE5uT3hFc0IwajJHNEV0KzhsVDdBSG1uc3JBTnVZczNYcWxqTVhh?=
 =?utf-8?B?TzhVWEI0VTlCUzE2bWlPQXdNTDNCMW5VWjNSWm03UWNuS0xCT2VvQT09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <362DFFD03B6A644E83CC02FD9C3DD261@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b2aa34b9-a030-4dee-8d14-08d99a03ad58
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Oct 2021 11:11:23.1933
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Qzob6TeBZGUhmSZAnoV5arp/nl5i5ZbZAR2DN2NGbqIdKJIjYD0JxsYxVo98WT4mqwpX93Vs1N1WlQAVgVlcERlNetG0ged1gOgCIGJpNjwPHz+nR/Gcz/mfjgVLQf2J
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR03MB6770
X-Proofpoint-GUID: ygs0qeRy_AhW2ATu_9PTQmN3mtqpF9lD
X-Proofpoint-ORIG-GUID: ygs0qeRy_AhW2ATu_9PTQmN3mtqpF9lD
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475
 definitions=2021-10-28_01,2021-10-26_01,2020-04-07_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501
 mlxlogscore=461 spamscore=0 phishscore=0 malwarescore=0 clxscore=1015
 suspectscore=0 adultscore=0 bulkscore=0 impostorscore=0 mlxscore=0
 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2110280062

DQoNCk9uIDI4LjEwLjIxIDE0OjAzLCBKdWxpZW4gR3JhbGwgd3JvdGU6DQo+DQo+DQo+IE9uIDI4
LzEwLzIwMjEgMTI6MDEsIE9sZWtzYW5kciBBbmRydXNoY2hlbmtvIHdyb3RlOg0KPj4gSGksIEp1
bGllbiENCj4+DQo+PiBbc25pcF0NCj4+IE9uIDI4LjEwLjIxIDEzOjQ4LCBKdWxpZW4gR3JhbGwg
d3JvdGU6DQo+Pj4gSGkgU3RlZmFubywNCj4+Pg0KPj4+IExvb2tpbmcgYXQgbGludXgvYXJjaC9h
cm02NC9ib290L2R0cy8sIHRoZXJlIGFyZSBhIGZldyBEZXZpY2UtVHJlZSB0aGF0IGNvbnRhaW4g
dGhlIHByb3BlcnR5ICJsaW51eCxwY2ktZG9tYWluIi4gQWxsIG9mIHRoZW0gc2VlbXMgdG8gYWxz
byBhZGQgaXQgZm9yIGRpc2FibGVkIGhvc3RicmlkZ2VzLg0KPj4+DQo+Pj4gSG93ZXZlciwgSSBh
bSB1bmRlciB0aGUgaW1wcmVzc2lvbiB0aGF0IGl0IGlzIG1vcmUgY29tbW9uIHRvIGhhdmUgYSBE
ZXZpZGUtVHJlZSB3aXRob3V0IGFueSBwcm9wZXJ0eSAibGludXgscGNpLWRvbWFpbiIuIFdoZW4g
UENJIHN1cHBvcnQgaXMgZW5hYmxlZCwgWGVuIHdpbGwgZ2VuZXJhdGUgdGhlIGRvbWFpbiBJRCBm
b3IgdGhlIGhvc3RicmlkZ2UgYW5kIHdyaXRlIGl0IHRvIHRoZSBEVC4NCj4+Pg0KPj4+IFRoaXMg
ZG9lc24ndCB3b3JrIGZvciBkaXNhYmxlZCBob3N0YnJpZGdlIGFuZCBJIHRoaW5rIHRoaXMgaXMg
T2xla3NhbmRyJ3MgcHJvYmxlbS4gQE9sZWtzYW5kciBjYW4geW91IGNvbmZpcm0gaXQ/DQo+PiBZ
ZXMsIHdoYXQgSSBoYXZlIGlzIGEgZGlzYWJsZWQgbm9kZSB3aXRob3V0ICJsaW51eCxwY2ktZG9t
YWluIg0KPg0KPiBKdXN0IHRvIGNvbmZpcm0sIGlzIGl0IHRoZSBzYW1lIGZvciBlbmFibGVkIGhv
c3RicmlkZ2VzPw0KTm9uZSBvZiB0aGUgYnJpZGdlcyBoYXZlICJsaW51eCxwY2ktZG9tYWluIiBp
biBteSBkZXZpY2UgdHJlZXMNCj4NCj4gQ2hlZXJzLA0KPg0K


From xen-devel-bounces@lists.xenproject.org Thu Oct 28 11:14:09 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Oct 2021 11:14:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217890.378106 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg3MB-0000Gx-TW; Thu, 28 Oct 2021 11:14:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217890.378106; Thu, 28 Oct 2021 11:14:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg3MB-0000Gq-Q5; Thu, 28 Oct 2021 11:14:03 +0000
Received: by outflank-mailman (input) for mailman id 217890;
 Thu, 28 Oct 2021 11:14:03 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mg3MB-0000Gk-Cz
 for xen-devel@lists.xenproject.org; Thu, 28 Oct 2021 11:14:03 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mg3MB-0005tN-0K; Thu, 28 Oct 2021 11:14:03 +0000
Received: from 54-240-197-225.amazon.com ([54.240.197.225] helo=[10.7.236.13])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mg3MA-00027e-QT; Thu, 28 Oct 2021 11:14:02 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=Hw4hI0gE4QgJ8ZpOe253Zwh1AWcsryjSDOXILm7Ye7M=; b=u8R0SF20gfLKfRWNBr5KOdAsgc
	SfMTTYs5ENNWj8ttH7trDn/IE2laOZyG65Nczab210lDHe+gHUOAbZS03j8UM0vLT6usbCUv+9sLS
	uuxKMJh4g1vJXxPpeU7c4ns8HXZccBJGn3PwydbOD/RlOwV99+UhhyMAgBLlgwnn5e6Y=;
Message-ID: <4e862e54-9cbb-ae91-6284-cfcb684dcf09@xen.org>
Date: Thu, 28 Oct 2021 12:13:59 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.2.1
Subject: Re: [PATCH v5 09/10] xen/arm: Do not map PCI ECAM and MMIO space to
 Domain-0's p2m
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: "sstabellini@kernel.org" <sstabellini@kernel.org>,
 Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Artem Mygaiev <Artem_Mygaiev@epam.com>,
 "roger.pau@citrix.com" <roger.pau@citrix.com>,
 "jbeulich@suse.com" <jbeulich@suse.com>,
 "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
 "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
 "paul@xen.org" <paul@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>,
 Rahul Singh <rahul.singh@arm.com>
References: <20211008055535.337436-1-andr2000@gmail.com>
 <20211008055535.337436-10-andr2000@gmail.com>
 <f5767857-a80a-fcc2-e70e-ce59ce19c8c9@xen.org>
 <121f1c81-4385-ae12-fefc-dfa638bf1f81@epam.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <121f1c81-4385-ae12-fefc-dfa638bf1f81@epam.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit



On 25/10/2021 12:37, Oleksandr Andrushchenko wrote:
> Hi, Julien!

Hi Oleksandr,

> On 13.10.21 19:17, Julien Grall wrote:
>> On 08/10/2021 06:55, Oleksandr Andrushchenko wrote:
>>> +    };
>>>          naddr = dt_number_of_address(dev);
>>>    @@ -1884,7 +1889,6 @@ static int __init handle_device(struct domain *d, struct dt_device_node *dev,
>>>        /* Give permission and map MMIOs */
>>>        for ( i = 0; i < naddr; i++ )
>>>        {
>>> -        struct map_range_data mr_data = { .d = d, .p2mt = p2mt };
>>>            res = dt_device_get_address(dev, i, &addr, &size);
>>>            if ( res )
>>>            {
>>> @@ -1898,7 +1902,7 @@ static int __init handle_device(struct domain *d, struct dt_device_node *dev,
>>>                return res;
>>>        }
>>>    -    res = map_device_children(d, dev, p2mt);
>>> +    res = map_device_children(dev, &mr_data);
>>>        if ( res )
>>>            return res;
>>>    @@ -3056,7 +3060,14 @@ static int __init construct_dom0(struct domain *d)
>>>            return rc;
>>>          if ( acpi_disabled )
>>> +    {
>>>            rc = prepare_dtb_hwdom(d, &kinfo);
>>> +        if ( rc < 0 )
>>> +            return rc;
>>> +#ifdef CONFIG_HAS_PCI
>>> +        rc = pci_host_bridge_mappings(d, p2m_mmio_direct_c);
>>
>> It is not clear to me why you are passing p2m_mmio_direct_c and not p2mt here?
> There is no p2mt in the caller function, e.g. construct_dom0
>> If you really want to force a type, then I think it should be p2m_mmio_direct.
> I just followed the defaults found in:
> static int __init prepare_dtb_hwdom(struct domain *d, struct kernel_info *kinfo)
> {
>       const p2m_type_t default_p2mt = p2m_mmio_direct_c;
> which is also called from construct_dom0

We use "p2m_mmio_direct_c" (cacheable mapping) by default because we 
don't know what how the region will be accessed  (e.g. this may be an 
SRAM). With this type, there is no restriction and dom0 is responsible 
to set to proper attribute in the stage-1 page-tables.

In this hostbridge cases, I see limited reasons at the moment for 
someone to map the non-BAR regions with cacheable attributes. So I think 
it is better to chose the most restricting attribute in the stage-2 
page-table.

>>
>> But then why is it a parameter of pci_host_bridge_mappings? Do you expect someone else to modify it?
> No, I don't expect to modify that, I just don't want PCI code to make decisions on that.
> So, I feel more comfortable if that decision is taken in construct_dom0.
Only the hostbridge driver is really aware of how the region will be 
accessed. So I think it is better to let...

> 
> So, what do we want here? Pass as parameter (then p2m_mmio_direct I guess, not p2m_mmio_direct_c)?
> Or let PCI code use p2m_mmio_direct inside pci_host_bridge_mappings?

... pci_host_bridge_mappings() decide the attribute. This can 
potentially allow us to have a per-hostbridge type if needed in the future.

[...]

>>
>> This is also exported but not used. I would prefer if we only exposed when the first external user will be introduced.
> ZynqMP is the first user yet in this patch. More to come probably later on when we add other host bridges.

Ah, sorry I didn't spot the use.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Thu Oct 28 11:20:36 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Oct 2021 11:20:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217896.378116 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg3SH-0001n7-Jm; Thu, 28 Oct 2021 11:20:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217896.378116; Thu, 28 Oct 2021 11:20:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg3SH-0001n0-Gh; Thu, 28 Oct 2021 11:20:21 +0000
Received: by outflank-mailman (input) for mailman id 217896;
 Thu, 28 Oct 2021 11:20:20 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ikAZ=PQ=epam.com=prvs=19352d112c=oleksandr_andrushchenko@srs-us1.protection.inumbo.net>)
 id 1mg3SG-0001mu-Jt
 for xen-devel@lists.xenproject.org; Thu, 28 Oct 2021 11:20:20 +0000
Received: from mx0a-0039f301.pphosted.com (unknown [148.163.133.242])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id a8d8d4f4-763f-4152-b2a2-ca5adf082d76;
 Thu, 28 Oct 2021 11:20:19 +0000 (UTC)
Received: from pps.filterd (m0174678.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 19SAYXGa002914; 
 Thu, 28 Oct 2021 11:20:17 GMT
Received: from eur04-db3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2055.outbound.protection.outlook.com [104.47.12.55])
 by mx0a-0039f301.pphosted.com with ESMTP id 3byt7sr727-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Thu, 28 Oct 2021 11:20:17 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by VI1PR0302MB2832.eurprd03.prod.outlook.com (2603:10a6:800:e2::15)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.20; Thu, 28 Oct
 2021 11:20:12 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::c038:e032:595a:651]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::c038:e032:595a:651%9]) with mapi id 15.20.4649.015; Thu, 28 Oct 2021
 11:20:12 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a8d8d4f4-763f-4152-b2a2-ca5adf082d76
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=eQuHIGaQNpjy00wXfhNN6xs1gyzy843nqCDIXJ316CfMWhpSETD8LLyg62OqyoilWq7nWpYl+T3WgXXJfqeM8vFHUfWrTFQIabx+LNIsUNm/LpKaQvycupQHEdR4UhXy6FjwD73wd9K44yCZUY7Y5KrTccqnj7Ta3l34ExMGVCbxiYQTE5CXEzbPQQvQg/QwJGGQ/6fcgkVrd/QBTtxvYPF0maRlPkWAr0aYaRGmDA+dgumjakR5bPSoR+Zji/azK2BvXer1MRp5io5RAOOj2BKPLUdCdCg1AFnVrPNjsuFDtM3KPIycdKPTFkZ8S3LifJoAbVi4i6JIlHrzhuSwLQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=WvaVs5i9m5HWWKBsK0G/8yaxV4x2SjMqbjVognfvLWg=;
 b=dIc05so42s4AH3qu06VEmZH/WL3KLt185u3uLS/Pt9aRt5m9MzhHQQPbC14bCVMjjJuB3wRD/P95tEKNrUaozl1x9RkZSJYcK8emqUeid46uJTmo4sH45xXhOC6i7ZRNgLHzv3DIgkKs9CeJfc1sw8m1l5hj68MmG2o8ep6PFbZjvNcOir9d6mXYs4fctNnsxlSE1mvxy7Ej8t1rwyED5jUn8xZdxgvv/Ly7jM3Vq7aKCIYtZT063xtPjtQC9MyABBhIlPtOj6mnZ7gbVnwzx6kwD812ADnp9PzZQ+jKzpyNgsYMHdLM1nk092+qB76aBNO6aytcOVbgipnl5fw00A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=WvaVs5i9m5HWWKBsK0G/8yaxV4x2SjMqbjVognfvLWg=;
 b=SvM9WXjSuT23JHjO4eWO87wu6bGxWYrKXDjW1JOj4rzh27v2qZkN3wzYZfBfO9WvATlyMo54W50q64luLypKEHqr/o6Kr2rbn9k1YWQ/ahxKkAmumZskn5wEDJed4JIZ/CCy34KSVlJJMg0ChmAQN+Bdv6W5wqAf6WQ0W/f5QUYz7SfCiv/KO4CMj5xfAqUmiHy4mT/++lcfR4j0Rs+mqs1fKpf7rIYqHaPF3gWAd4J0CCWkvg4e7ajnItqSRzH7H+3QdJzs0IuFtr3HYbW+/E7G+NAB6kESnx19vJjUSCE09DtapJNuaKB5tHv9Me17QL4je+FFLhEslvTgtNTm7g==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Julien Grall <julien@xen.org>,
        "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: "sstabellini@kernel.org" <sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "roger.pau@citrix.com" <roger.pau@citrix.com>,
        "jbeulich@suse.com"
	<jbeulich@suse.com>,
        "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
        "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
        "paul@xen.org"
	<paul@xen.org>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Rahul Singh
	<rahul.singh@arm.com>
Subject: Re: [PATCH v5 09/10] xen/arm: Do not map PCI ECAM and MMIO space to
 Domain-0's p2m
Thread-Topic: [PATCH v5 09/10] xen/arm: Do not map PCI ECAM and MMIO space to
 Domain-0's p2m
Thread-Index: AQHXvAkp3d9SZd4Ne0C6z52O+cvuD6vRI24AgBKN8ACABLBegIAAAbyA
Date: Thu, 28 Oct 2021 11:20:12 +0000
Message-ID: <7d4f4496-1b8f-75aa-1f9f-004de31ef454@epam.com>
References: <20211008055535.337436-1-andr2000@gmail.com>
 <20211008055535.337436-10-andr2000@gmail.com>
 <f5767857-a80a-fcc2-e70e-ce59ce19c8c9@xen.org>
 <121f1c81-4385-ae12-fefc-dfa638bf1f81@epam.com>
 <4e862e54-9cbb-ae91-6284-cfcb684dcf09@xen.org>
In-Reply-To: <4e862e54-9cbb-ae91-6284-cfcb684dcf09@xen.org>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 9a14b01c-5b50-40e4-d748-08d99a04e894
x-ms-traffictypediagnostic: VI1PR0302MB2832:
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <VI1PR0302MB2832A21FB355C8C838987374E7869@VI1PR0302MB2832.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 +CYZtIZVgXxhNVnX3jGPrhx7QwXU5FF88xjOZsyEWSkL9FdmkcZ4synxX92LSsZTwTkzAmqiJscnIzstL1C/kV54i4H08aKKsTl3MDDzjNu9EjDVuXZyHfP4OZHyY5stTnsPy7TlCDZ94dA4oKEMuabBKotUzWybo/bSzwVQtWMlrcGxtvybVCMWoSUB+CgqUjjC42r5NC6McwAlsURPpnsgYkPIxPupanfK/ORCv4mlSfJqw2I4xVG+QdB/mh922krHXjCocv57JpAz9wFeFWUXun8yFFM+jpPT7uxrOTkcZhVFcGY+bPclgcrYsDJoQhXHUXZtYLTWel6VKDaaa8NpASZNizWzSGr1HTklm7dbxxyfsFlZ/Stz9OFaw6CyXV/QiaEpNJoDQswFUKirSxiXt0BfNjRmAG4FNRxNKJ/U3yR7KP5fqk0MFCU55gQaef2B3N2gQVUukvdFMPKQzVlVNOQNCX9YD2fKTK7dCXdcWugMddBr3SXO+TMXuS1qqfB8i8xdikdUCypfVkEKynPr/c0D99FSi0W2XwAH0FntpgS6YGhmav/Ua27lAr1Ma7Uco64hHuwyKSA4FGJd3P9/ItfC1ma5B+KGfFHxwnwsp6l9owcBQFVUF3j7zamgEvSfF1bpreqaH5Fx7izKUZUZXf6mbMEZuqk4kQ7G61LfEOYmSKW0VtxeKyzZkDs5sl4xGBxglixEiWRgUCeeknukWLpWWgFaIjnt8vLCIUxhAFo5k1cV10t9YNJVMslP
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(86362001)(6486002)(31686004)(38070700005)(71200400001)(55236004)(66556008)(2616005)(36756003)(66476007)(110136005)(38100700002)(6506007)(76116006)(2906002)(316002)(6512007)(64756008)(54906003)(122000001)(186003)(91956017)(66446008)(8936002)(26005)(53546011)(8676002)(66946007)(4326008)(5660300002)(31696002)(508600001)(83380400001)(7416002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?Mlh2OTlhYjQrYnZteE9kWFY4eFlKOW9MUnZudUttb3AyYm9GVmtSQUN5a2RT?=
 =?utf-8?B?NDdtc1JpTTNVQ2MxaXcrSzF4dmoxRVpsREZNQXRpZG5NdW5reDdVSkY4clR5?=
 =?utf-8?B?ZXR5ZWxPUFpOYkxJbmhqcjhMYWs2dUNRL3M4UkxFMnE1cDZQUVdRSzBiS2JQ?=
 =?utf-8?B?cllGM29STHZmVGxVQlZnUWNZQlhrTXVRRHB5V2VXNTZwb1ZiMHg5R2xhRjVx?=
 =?utf-8?B?VEVYTnZodkNwSUNMNTJvek5kb09sWlpzRm92aHhvSTZNTHVPdzdIcm5VZXRO?=
 =?utf-8?B?UDY0Z3I4Z0MwcDRieWVkcjBxanJWTjFLT0VRMUJ5VEdvUE5xV3RTVDdwMndG?=
 =?utf-8?B?dkRiOWl0MG03UUNKNi9rK2VPdUhQR2VLQzJpM1R0NzdCeFFYOWxndmN1TTVP?=
 =?utf-8?B?VjhxcnZnNVhYYjRPRVZ1OVk3ZmV6aXBzRkplTEtsYTFPdytUUWh3NzIveGRN?=
 =?utf-8?B?ZmpENUFsQmxwajNLaWVSSEVkUkJsZ1lNNjRyNUtUWk01dmJpUjlVcTRRaitD?=
 =?utf-8?B?ZnJiaWFtajJkZ09nTUxOQWUyaUNOT0VuM2FRbVhMMmFWL2tya0xiaWxpa2VP?=
 =?utf-8?B?R0FDbHJZVVFtNEJxeTg1b1ZVb1ovaHEwUDh1VU9uVm1yLzIrK2QwWFBKSnpn?=
 =?utf-8?B?dGMvZzk2TXQ3aHFKQU9VdW9KZ1hQRUpFSDNHUEQ3dGV4ekFEeU9CN1l2dmdl?=
 =?utf-8?B?OFViby9hTC9zeENLVVBLaXgraFo4NEZqR253TzN6aTdjNWw2VkVqeWU1cTdu?=
 =?utf-8?B?V2lWZ3k2VFJseFY2dnc1QVVTSi9KOVBqeFZuNW9PRnJYSWpGWW5PajBpUERl?=
 =?utf-8?B?bzhuTXUyNXpsKzg3OGVOcysrN3VJNkdwMHFLaTRkdTIvUWY2U3RKZFovTlZ2?=
 =?utf-8?B?aURZTTNDUGdCeFJEOXdXajdSRnBPQUZENWdjamFQc3hUMlh0VysrUGlSM0NL?=
 =?utf-8?B?cVpZNDlnVENibGhNamxhVDlCWWgvUTIvSDk4U0xjdjRScGdWdHBqN2kzM1VX?=
 =?utf-8?B?VGxIOVpTRmlVSDNtTy9DU3JMMVZYSmlJNm5aUjMvZjVLMm11cTdOMy83a2Mw?=
 =?utf-8?B?NmRSSVpRZTczOEhHeVpTaS9pOHBMc1g3MUlYS0lobjdTTndHeVRvTVpXU2FJ?=
 =?utf-8?B?L1VTZ3VGaERTdUlTVXNTNERhYWMzN29OemloTmFRVlFRWVRWcEhIZ29qR00y?=
 =?utf-8?B?OGZYbUtXV25BK3Z4b0l4VGFoUFg2SVQ2Snl1S3NtbUJsaFc3TUYveGl0K09H?=
 =?utf-8?B?dEJCYTlldDZVTFJNK0JzQ2FjQUlTNEdPbkFiTGZ0S0hmcnVGR1JLc0pNZmh2?=
 =?utf-8?B?WkdsYWlRdmJwL3locDNaZTU0QzZBRlJ3RzNGTytSWkZSdnN1KzhWUEFXZmMv?=
 =?utf-8?B?MlNiK1V3b3kxZWF0WkpFZG5uYjJhOE5hOUZhWHpxVEsrT3NxZkxkaW9Fa1FS?=
 =?utf-8?B?QU5vYzN1RG9nWlM5UFo2aGV6ZytwZit4bW5mWmwvajRwSnZHZ3ZuZC9VVVcr?=
 =?utf-8?B?UW55MlV3bzdNcXZYL2JuRlhmbmFSYk1NamxpdEVSYW1ZNlU2Wi9zYmFQTjl6?=
 =?utf-8?B?UENWbVVUYnZkWlVVUnZQdm5OTlM4ZGJvQk94RitPQm9tU05QKzd2eVF0a24x?=
 =?utf-8?B?bXlDS21ET0FqTHhQbktQRGZpVTJqVktXUjRSTlJhcjFHYmVkb2lEajFuUFJG?=
 =?utf-8?B?eURVMVFWK1ZFaUdUWHY0NDZPa0lkSHRDZmxpbW5GaDFYUk8zUkxacm1hNEhK?=
 =?utf-8?B?cHJTZU1GNnRhQzRZMUhtNkJUK0MxUGcyQThYbllHRUZYUktRZDZzbmt6Umdw?=
 =?utf-8?B?OUdaUjJKWU5MUDR6anhhZ0xaVXRSd0Nkb3hsSHV5YkVZNTlJUzRncmR2SVQ1?=
 =?utf-8?B?TGx4dFJ6SkpmRDdtS3plSGk0cUlZUGNIaWZXWE5EVklUSUlEUkJVSWNHek14?=
 =?utf-8?B?V3VBTFhzeHcyUEwrL1k3eDZ5QkgzMS82d29JeEdmTDhkZGtwRzlDc3VRNzlJ?=
 =?utf-8?B?SlhlUDd3Y21mejNZaEtiRDNIV2htcVAvVFd1Si9kcm9iZGtTb1lJVFkyT2Qy?=
 =?utf-8?B?aDU0YmlRZDJybklITm1SeWMrVkNCWE1vcHR0MlJZdlNUUEI4cU5Vb29HRFBS?=
 =?utf-8?B?bUJsU2hNSndrSmdFc3F4VzJpQ0JtemJuNzdlb2RRVjFWRWVJWjJRcG02NnRi?=
 =?utf-8?B?aFM0NGcwOFYwNnhsQ3pZL3lUZHFyNldTQ1k2V0JoNTkyM1czUnpMN0p1Z2or?=
 =?utf-8?B?bXRpdjV3S01Ec2VtR3o1RWJidENEVk9nYitEZHU4SWRUTTdqeGVIUWR0OUJh?=
 =?utf-8?B?THVuQ2VIWFhBNGZOQjl5OThFZDJOQXR3VXRGZ1htUlROTlhta0ZUUT09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <FE88065D10BA5D4AA76D94359E541E6E@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9a14b01c-5b50-40e4-d748-08d99a04e894
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Oct 2021 11:20:12.0737
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: xDvysfeS0xrt+jtcBqKluwHLNN9LpME8oz/NAxGHOPogOKUrWwu2KqnfgM5dkxO5jgV6lnjeTti390Nk2Ynwv+5a8S9R9+Kgnc+ggnXBR6ZQZXLCTIVE+Kb+2joWssGa
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0302MB2832
X-Proofpoint-GUID: nvw2yOzyhpDvxfu15v4fqzJSJZyC8sup
X-Proofpoint-ORIG-GUID: nvw2yOzyhpDvxfu15v4fqzJSJZyC8sup
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475
 definitions=2021-10-28_01,2021-10-26_01,2020-04-07_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 spamscore=0
 clxscore=1015 impostorscore=0 suspectscore=0 priorityscore=1501
 bulkscore=0 lowpriorityscore=0 mlxscore=0 malwarescore=0 adultscore=0
 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2110280062

SGksIEp1bGllbiENCg0KT24gMjguMTAuMjEgMTQ6MTMsIEp1bGllbiBHcmFsbCB3cm90ZToNCj4N
Cj4NCj4gT24gMjUvMTAvMjAyMSAxMjozNywgT2xla3NhbmRyIEFuZHJ1c2hjaGVua28gd3JvdGU6
DQo+PiBIaSwgSnVsaWVuIQ0KPg0KPiBIaSBPbGVrc2FuZHIsDQo+DQo+PiBPbiAxMy4xMC4yMSAx
OToxNywgSnVsaWVuIEdyYWxsIHdyb3RlOg0KPj4+IE9uIDA4LzEwLzIwMjEgMDY6NTUsIE9sZWtz
YW5kciBBbmRydXNoY2hlbmtvIHdyb3RlOg0KPj4+PiArwqDCoMKgIH07DQo+Pj4+IMKgwqAgwqDC
oMKgwqDCoCBuYWRkciA9IGR0X251bWJlcl9vZl9hZGRyZXNzKGRldik7DQo+Pj4+IMKgwqAgQEAg
LTE4ODQsNyArMTg4OSw2IEBAIHN0YXRpYyBpbnQgX19pbml0IGhhbmRsZV9kZXZpY2Uoc3RydWN0
IGRvbWFpbiAqZCwgc3RydWN0IGR0X2RldmljZV9ub2RlICpkZXYsDQo+Pj4+IMKgwqDCoMKgwqDC
oCAvKiBHaXZlIHBlcm1pc3Npb24gYW5kIG1hcCBNTUlPcyAqLw0KPj4+PiDCoMKgwqDCoMKgwqAg
Zm9yICggaSA9IDA7IGkgPCBuYWRkcjsgaSsrICkNCj4+Pj4gwqDCoMKgwqDCoMKgIHsNCj4+Pj4g
LcKgwqDCoMKgwqDCoMKgIHN0cnVjdCBtYXBfcmFuZ2VfZGF0YSBtcl9kYXRhID0geyAuZCA9IGQs
IC5wMm10ID0gcDJtdCB9Ow0KPj4+PiDCoMKgwqDCoMKgwqDCoMKgwqDCoCByZXMgPSBkdF9kZXZp
Y2VfZ2V0X2FkZHJlc3MoZGV2LCBpLCAmYWRkciwgJnNpemUpOw0KPj4+PiDCoMKgwqDCoMKgwqDC
oMKgwqDCoCBpZiAoIHJlcyApDQo+Pj4+IMKgwqDCoMKgwqDCoMKgwqDCoMKgIHsNCj4+Pj4gQEAg
LTE4OTgsNyArMTkwMiw3IEBAIHN0YXRpYyBpbnQgX19pbml0IGhhbmRsZV9kZXZpY2Uoc3RydWN0
IGRvbWFpbiAqZCwgc3RydWN0IGR0X2RldmljZV9ub2RlICpkZXYsDQo+Pj4+IMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqAgcmV0dXJuIHJlczsNCj4+Pj4gwqDCoMKgwqDCoMKgIH0NCj4+Pj4g
wqDCoCAtwqDCoMKgIHJlcyA9IG1hcF9kZXZpY2VfY2hpbGRyZW4oZCwgZGV2LCBwMm10KTsNCj4+
Pj4gK8KgwqDCoCByZXMgPSBtYXBfZGV2aWNlX2NoaWxkcmVuKGRldiwgJm1yX2RhdGEpOw0KPj4+
PiDCoMKgwqDCoMKgwqAgaWYgKCByZXMgKQ0KPj4+PiDCoMKgwqDCoMKgwqDCoMKgwqDCoCByZXR1
cm4gcmVzOw0KPj4+PiDCoMKgIEBAIC0zMDU2LDcgKzMwNjAsMTQgQEAgc3RhdGljIGludCBfX2lu
aXQgY29uc3RydWN0X2RvbTAoc3RydWN0IGRvbWFpbiAqZCkNCj4+Pj4gwqDCoMKgwqDCoMKgwqDC
oMKgwqAgcmV0dXJuIHJjOw0KPj4+PiDCoMKgIMKgwqDCoMKgwqAgaWYgKCBhY3BpX2Rpc2FibGVk
ICkNCj4+Pj4gK8KgwqDCoCB7DQo+Pj4+IMKgwqDCoMKgwqDCoMKgwqDCoMKgIHJjID0gcHJlcGFy
ZV9kdGJfaHdkb20oZCwgJmtpbmZvKTsNCj4+Pj4gK8KgwqDCoMKgwqDCoMKgIGlmICggcmMgPCAw
ICkNCj4+Pj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqAgcmV0dXJuIHJjOw0KPj4+PiArI2lmZGVm
IENPTkZJR19IQVNfUENJDQo+Pj4+ICvCoMKgwqDCoMKgwqDCoCByYyA9IHBjaV9ob3N0X2JyaWRn
ZV9tYXBwaW5ncyhkLCBwMm1fbW1pb19kaXJlY3RfYyk7DQo+Pj4NCj4+PiBJdCBpcyBub3QgY2xl
YXIgdG8gbWUgd2h5IHlvdSBhcmUgcGFzc2luZyBwMm1fbW1pb19kaXJlY3RfYyBhbmQgbm90IHAy
bXQgaGVyZT8NCj4+IFRoZXJlIGlzIG5vIHAybXQgaW4gdGhlIGNhbGxlciBmdW5jdGlvbiwgZS5n
LiBjb25zdHJ1Y3RfZG9tMA0KPj4+IElmIHlvdSByZWFsbHkgd2FudCB0byBmb3JjZSBhIHR5cGUs
IHRoZW4gSSB0aGluayBpdCBzaG91bGQgYmUgcDJtX21taW9fZGlyZWN0Lg0KPj4gSSBqdXN0IGZv
bGxvd2VkIHRoZSBkZWZhdWx0cyBmb3VuZCBpbjoNCj4+IHN0YXRpYyBpbnQgX19pbml0IHByZXBh
cmVfZHRiX2h3ZG9tKHN0cnVjdCBkb21haW4gKmQsIHN0cnVjdCBrZXJuZWxfaW5mbyAqa2luZm8p
DQo+PiB7DQo+PiDCoCDCoMKgwqAgY29uc3QgcDJtX3R5cGVfdCBkZWZhdWx0X3AybXQgPSBwMm1f
bW1pb19kaXJlY3RfYzsNCj4+IHdoaWNoIGlzIGFsc28gY2FsbGVkIGZyb20gY29uc3RydWN0X2Rv
bTANCj4NCj4gV2UgdXNlICJwMm1fbW1pb19kaXJlY3RfYyIgKGNhY2hlYWJsZSBtYXBwaW5nKSBi
eSBkZWZhdWx0IGJlY2F1c2Ugd2UgZG9uJ3Qga25vdyB3aGF0IGhvdyB0aGUgcmVnaW9uIHdpbGwg
YmUgYWNjZXNzZWTCoCAoZS5nLiB0aGlzIG1heSBiZSBhbiBTUkFNKS4gV2l0aCB0aGlzIHR5cGUs
IHRoZXJlIGlzIG5vIHJlc3RyaWN0aW9uIGFuZCBkb20wIGlzIHJlc3BvbnNpYmxlIHRvIHNldCB0
byBwcm9wZXIgYXR0cmlidXRlIGluIHRoZSBzdGFnZS0xIHBhZ2UtdGFibGVzLg0KPg0KPiBJbiB0
aGlzIGhvc3RicmlkZ2UgY2FzZXMsIEkgc2VlIGxpbWl0ZWQgcmVhc29ucyBhdCB0aGUgbW9tZW50
IGZvciBzb21lb25lIHRvIG1hcCB0aGUgbm9uLUJBUiByZWdpb25zIHdpdGggY2FjaGVhYmxlIGF0
dHJpYnV0ZXMuIFNvIEkgdGhpbmsgaXQgaXMgYmV0dGVyIHRvIGNob3NlIHRoZSBtb3N0IHJlc3Ry
aWN0aW5nIGF0dHJpYnV0ZSBpbiB0aGUgc3RhZ2UtMiBwYWdlLXRhYmxlLg0KPg0KPj4+DQo+Pj4g
QnV0IHRoZW4gd2h5IGlzIGl0IGEgcGFyYW1ldGVyIG9mIHBjaV9ob3N0X2JyaWRnZV9tYXBwaW5n
cz8gRG8geW91IGV4cGVjdCBzb21lb25lIGVsc2UgdG8gbW9kaWZ5IGl0Pw0KPj4gTm8sIEkgZG9u
J3QgZXhwZWN0IHRvIG1vZGlmeSB0aGF0LCBJIGp1c3QgZG9uJ3Qgd2FudCBQQ0kgY29kZSB0byBt
YWtlIGRlY2lzaW9ucyBvbiB0aGF0Lg0KPj4gU28sIEkgZmVlbCBtb3JlIGNvbWZvcnRhYmxlIGlm
IHRoYXQgZGVjaXNpb24gaXMgdGFrZW4gaW4gY29uc3RydWN0X2RvbTAuDQo+IE9ubHkgdGhlIGhv
c3RicmlkZ2UgZHJpdmVyIGlzIHJlYWxseSBhd2FyZSBvZiBob3cgdGhlIHJlZ2lvbiB3aWxsIGJl
IGFjY2Vzc2VkLiBTbyBJIHRoaW5rIGl0IGlzIGJldHRlciB0byBsZXQuLi4NCj4NCj4+DQo+PiBT
bywgd2hhdCBkbyB3ZSB3YW50IGhlcmU/IFBhc3MgYXMgcGFyYW1ldGVyICh0aGVuIHAybV9tbWlv
X2RpcmVjdCBJIGd1ZXNzLCBub3QgcDJtX21taW9fZGlyZWN0X2MpPw0KPj4gT3IgbGV0IFBDSSBj
b2RlIHVzZSBwMm1fbW1pb19kaXJlY3QgaW5zaWRlIHBjaV9ob3N0X2JyaWRnZV9tYXBwaW5ncz8N
Cj4NCj4gLi4uIHBjaV9ob3N0X2JyaWRnZV9tYXBwaW5ncygpIGRlY2lkZSB0aGUgYXR0cmlidXRl
LiBUaGlzIGNhbiBwb3RlbnRpYWxseSBhbGxvdyB1cyB0byBoYXZlIGEgcGVyLWhvc3RicmlkZ2Ug
dHlwZSBpZiBuZWVkZWQgaW4gdGhlIGZ1dHVyZS4NCkl0IGlzIGFsbCBjbGVhciBub3csIHRoYW5r
IHlvdSENCj4NCj4gWy4uLl0NCj4NCj4+Pg0KPj4+IFRoaXMgaXMgYWxzbyBleHBvcnRlZCBidXQg
bm90IHVzZWQuIEkgd291bGQgcHJlZmVyIGlmIHdlIG9ubHkgZXhwb3NlZCB3aGVuIHRoZSBmaXJz
dCBleHRlcm5hbCB1c2VyIHdpbGwgYmUgaW50cm9kdWNlZC4NCj4+IFp5bnFNUCBpcyB0aGUgZmly
c3QgdXNlciB5ZXQgaW4gdGhpcyBwYXRjaC4gTW9yZSB0byBjb21lIHByb2JhYmx5IGxhdGVyIG9u
IHdoZW4gd2UgYWRkIG90aGVyIGhvc3QgYnJpZGdlcy4NCj4NCj4gQWgsIHNvcnJ5IEkgZGlkbid0
IHNwb3QgdGhlIHVzZS4NCj4NCj4gQ2hlZXJzLA0KPg0KVGhhbmsgeW91LA0KT2xla3NhbmRy


From xen-devel-bounces@lists.xenproject.org Thu Oct 28 11:31:17 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Oct 2021 11:31:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217905.378128 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg3ci-0003L3-KW; Thu, 28 Oct 2021 11:31:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217905.378128; Thu, 28 Oct 2021 11:31:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg3ci-0003Kw-HQ; Thu, 28 Oct 2021 11:31:08 +0000
Received: by outflank-mailman (input) for mailman id 217905;
 Thu, 28 Oct 2021 11:31:07 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mg3ch-0003Km-Ku; Thu, 28 Oct 2021 11:31:07 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mg3ch-0006BD-Fl; Thu, 28 Oct 2021 11:31:07 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mg3ch-0003x7-4k; Thu, 28 Oct 2021 11:31:07 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mg3ch-0000j1-4G; Thu, 28 Oct 2021 11:31:07 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=R9MJEY1V0mI1GImehJZjeSGXKbwTYW7BnpyZWuR4ivk=; b=kA8EcRKaCxiVYb8AqVn1aho8zA
	vPphNGHq4G5t+F17t7Raj3kTsCKJ0menph0lf3RXG4VGPmxwZ2zEbEXfoOkhOOOkJ4GB27lI57dLn
	M3uHkcmebWf5LhR96/1ko2aDWnJEYwM6vg60NxhNA5CEO1KqAROmJFYygUabV3DCB1WM=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165921-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 165921: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=bb146ce32dd8edc463e792554351e50b9e5b769f
X-Osstest-Versions-That:
    ovmf=9a95d11023ac2f2ee49a2958cf80658270442c42
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 28 Oct 2021 11:31:07 +0000

flight 165921 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165921/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 bb146ce32dd8edc463e792554351e50b9e5b769f
baseline version:
 ovmf                 9a95d11023ac2f2ee49a2958cf80658270442c42

Last test of basis   165899  2021-10-27 12:10:06 Z    0 days
Testing same since   165921  2021-10-28 02:41:24 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Star Zeng <star.zeng@intel.com>
  Zeng, Star <star.zeng@intel.com>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   9a95d11023..bb146ce32d  bb146ce32dd8edc463e792554351e50b9e5b769f -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Thu Oct 28 11:52:25 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Oct 2021 11:52:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217917.378142 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg3x8-0005uF-BN; Thu, 28 Oct 2021 11:52:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217917.378142; Thu, 28 Oct 2021 11:52:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg3x8-0005u8-8T; Thu, 28 Oct 2021 11:52:14 +0000
Received: by outflank-mailman (input) for mailman id 217917;
 Thu, 28 Oct 2021 11:52:12 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=vfrR=PQ=suse.com=jgross@srs-us1.protection.inumbo.net>)
 id 1mg3x6-0005u0-Df
 for xen-devel@lists.xenproject.org; Thu, 28 Oct 2021 11:52:12 +0000
Received: from smtp-out2.suse.de (unknown [195.135.220.29])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 1fb6d30d-d3a0-4259-b83d-d27d1718b171;
 Thu, 28 Oct 2021 11:52:11 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id AA8771FD4E;
 Thu, 28 Oct 2021 11:52:10 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 949EA13B88;
 Thu, 28 Oct 2021 11:52:10 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id 3H7cIuqOemHRUQAAMHmgww
 (envelope-from <jgross@suse.com>); Thu, 28 Oct 2021 11:52:10 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1fb6d30d-d3a0-4259-b83d-d27d1718b171
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1635421930; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=G9ibeAb1zURj9w7ETNGyyWy46klDJinkBbIz3MSBDOo=;
	b=kvEAhuwwKnV9WnxAT0st1S3bNv2DYi5gPalKIc1wiXbB7MQ3V/rQNPaMqnHEpcSIeB3Q2p
	Rf4jGheNHWFGwFgpfgVjPmltBImZKpXuTL5MLmUTlEpCm0kcMOWi6eTo/1InMv4RZ3xkQO
	dwU8u9SqFWshFEFqEPliMiyp72MLD7M=
To: Ian Jackson <iwj@xenproject.org>, xen-devel@lists.xenproject.org
References: <20211027170256.18223-1-iwj@xenproject.org>
From: Juergen Gross <jgross@suse.com>
Subject: Re: [OSSTEST PATCH 0/2] ts-xen-build: explicitly enable/disable
 configure features
Message-ID: <822a9317-2ed0-8510-dc31-90ccff5c6c38@suse.com>
Date: Thu, 28 Oct 2021 13:52:10 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <20211027170256.18223-1-iwj@xenproject.org>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="T5XHMySs1FYVmOpkmtcVV48WV70KGve7l"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--T5XHMySs1FYVmOpkmtcVV48WV70KGve7l
Content-Type: multipart/mixed; boundary="Tulo1RHSq5IuDsE1akCxIHA93zCl7U47T";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Ian Jackson <iwj@xenproject.org>, xen-devel@lists.xenproject.org
Message-ID: <822a9317-2ed0-8510-dc31-90ccff5c6c38@suse.com>
Subject: Re: [OSSTEST PATCH 0/2] ts-xen-build: explicitly enable/disable
 configure features
References: <20211027170256.18223-1-iwj@xenproject.org>
In-Reply-To: <20211027170256.18223-1-iwj@xenproject.org>

--Tulo1RHSq5IuDsE1akCxIHA93zCl7U47T
Content-Type: multipart/mixed;
 boundary="------------A589B12D2B8A6F7362708CCD"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------A589B12D2B8A6F7362708CCD
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 27.10.21 19:02, Ian Jackson wrote:
> The existing code depends on precisely whether the non-default option
> appearing in the configure script is indeed the opposite of the option
> we want to pass.
>=20
> Right now it seems to be working but this seems fragile.  Do it
> differently.
>=20
> I have verified that with current Xen, on arm64:
>=20
>     + egrep -q -- '--disable-xend|--enable-xend' tools/configure
>     + egrep -q -- '--disable-ovmf|--enable-ovmf' tools/configure
>     + enable_opts=3D' --enable-ovmf'
>     + egrep -q -- '--disable-qemu-traditional|--enable-qemu-traditional=
' tools/configure
>     + enable_opts=3D' --enable-ovmf --disable-qemu-traditional'
>     + ./configure --sysconfdir=3D/etc --enable-ovmf --disable-qemu-trad=
itional
>=20
> and on amd64:
>=20
>     + egrep -q -- '--disable-xend|--enable-xend' tools/configure
>     + egrep -q -- '--disable-ovmf|--enable-ovmf' tools/configure
>     + enable_opts=3D' --enable-ovmf'
>     + egrep -q -- '--disable-qemu-traditional|--enable-qemu-traditional=
' tools/configure
>     + enable_opts=3D' --enable-ovmf --enable-qemu-traditional'
>     + ./configure --sysconfdir=3D/etc --enable-ovmf --enable-qemu-tradi=
tional
>=20
> Juergen, I would appreciate a review from you.  I think I would like
> this in osstest production before changing the qemu trad build default
> in Xen.

Far from being a Perl expert I agree this is a sensible approach and it
should do the right thing.

It will still depend on no unsupported option being mentioned in any
comment, e.g. "# option --enable-foo is no longer supported" will result
in a wrong positive when testing for feature "foo". In the end this will
break the build, so it should be easy to detect in case this happens
some time in the future.

As there is no way to print out all supported options, this could only
be solved by adding "--disable-option-checking", which has other
disadvantages.

You can add my:

Reviewed-by: Juergen Gross <jgross@suse.com>


Juergen

--------------A589B12D2B8A6F7362708CCD
Content-Type: application/pgp-keys;
 name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Transfer-Encoding: quoted-printable
Content-Description: OpenPGP public key
Content-Disposition: attachment;
 filename="OpenPGP_0xB0DE9DD628BF132F.asc"

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy=
cWx
w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O=
f8Z
d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y=
9bf
IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq=
G7/
377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR=
3Jv
c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA=
QIe
AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT=
hpw
dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0=
MbD
1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv=
oPH
Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v=
5QL
+qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ=
2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC=
QoL
BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr=
Wf0
teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC=
/nu
AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh=
ITT
d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm=
XBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz=
80h
SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC=
AcD
AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn=
FOX
gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1=
jnD
kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0=
N51
N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l=
otu
fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1=
tqS
EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA=
hsD
BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3=
g3O
ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5=
dM7
wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5=
D+j
LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm=
V2x
AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N=
Eaw
QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW=
nHI
s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR=
wgn
BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV=
bVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk=
pEd
IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA=
QAB
wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw=
Tbe
8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1=
vJz
Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8=
VGi
wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW=
svi
uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX=
zXs
ZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------A589B12D2B8A6F7362708CCD--

--Tulo1RHSq5IuDsE1akCxIHA93zCl7U47T--

--T5XHMySs1FYVmOpkmtcVV48WV70KGve7l
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmF6juoFAwAAAAAACgkQsN6d1ii/Ey8l
Zgf+JNSpTlo/+rnUTmiD+LtZkCuQ8WUitxjCGT59VehNH8E6dT6kAC0uT1FPca6uAq3RDcngsHf9
8eXZoB204eFp/5ex8SEkPvb5s6JQZ96FH2Xg1oVaRLktg5/vRJDprMJsr9X8xtUFtP9E6FceI/Do
9mcQwg6wVLncpaqS6Arna9pX1SNnNjx0b/B3f8BuHE63/aKdZSkVk2OEJDSQxEYz3Zc2Azm1uBh9
f7psr72HED6wGJ57U1aA7E/l4PvTKyaVQ8kkAE110qiWiBNlN7XU5O2pjrrhWd3E0znPJnqrxn/4
TVBW87M4KeE3Awivx8r1KZW3ZOWr/g+h2M3WPP1UjA==
=UDZU
-----END PGP SIGNATURE-----

--T5XHMySs1FYVmOpkmtcVV48WV70KGve7l--


From xen-devel-bounces@lists.xenproject.org Thu Oct 28 11:59:42 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Oct 2021 11:59:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217925.378153 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg449-0006jQ-6I; Thu, 28 Oct 2021 11:59:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217925.378153; Thu, 28 Oct 2021 11:59:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg449-0006jJ-2P; Thu, 28 Oct 2021 11:59:29 +0000
Received: by outflank-mailman (input) for mailman id 217925;
 Thu, 28 Oct 2021 11:59:27 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=kHpK=PQ=kernel.org=broonie@srs-us1.protection.inumbo.net>)
 id 1mg446-0006jD-Tv
 for xen-devel@lists.xenproject.org; Thu, 28 Oct 2021 11:59:26 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 7f0149a2-37e6-11ec-849d-12813bfff9fa;
 Thu, 28 Oct 2021 11:59:25 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id 17810610FC;
 Thu, 28 Oct 2021 11:59:11 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7f0149a2-37e6-11ec-849d-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1635422364;
	bh=6SRnBqGEu6kfrjY8F8AIxFOXpP3mk9uNLODc5pl6vYo=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=PF+p5k3fPcX4g7U/HaBJuzIJ4k5E0pNaC5AYSReMWdptL5C6nDTIJaIE7qlYNYlG6
	 n1n/PwUdpeEdECCRPixbjSlqTeevDW0OntTvozcAaeZnGpyg9v14UXE0Uy+uDhiwA4
	 opUKp2Rh8z49oq5/De4kzH0wt2Tq2fvNA7/+mgp+6zfuqvEwWijrNqLYLBlBZuMPRL
	 88N447RwKebi4Ez1WZLL28f9yHI1UOy8Ip53Ye3TTKmeO3nK2Kc7hLybqU9+9eT+Gw
	 dD6HWh7fPMZRMI/QpI/9KZ3rirsCMx4Hs00YhSbDpBEZNMfr2ZfvOMHA6ZLmKCwWDw
	 xkF14RX5nWTCw==
Date: Thu, 28 Oct 2021 12:59:08 +0100
From: Mark Brown <broonie@kernel.org>
To: Dmitry Osipenko <digetx@gmail.com>
Cc: Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Lee Jones <lee.jones@linaro.org>,
	"Rafael J . Wysocki" <rafael@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Russell King <linux@armlinux.org.uk>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>, Guo Ren <guoren@kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Greg Ungerer <gerg@linux-m68k.org>,
	Joshua Thompson <funaho@jurai.org>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Nick Hu <nickhu@andestech.com>, Greentime Hu <green.hu@gmail.com>,
	Vincent Chen <deanbo422@gmail.com>,
	"James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
	Helge Deller <deller@gmx.de>, Michael Ellerman <mpe@ellerman.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Rich Felker <dalias@libc.org>, Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>, x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Len Brown <lenb@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Chen-Yu Tsai <wens@csie.org>,
	Jonathan =?iso-8859-1?Q?Neusch=E4fer?= <j.neuschaefer@gmx.net>,
	Tony Lindgren <tony@atomide.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Vladimir Zapolskiy <vz@mleia.com>,
	Avi Fishman <avifishman70@gmail.com>,
	Tomer Maimon <tmaimon77@gmail.com>,
	Tali Perry <tali.perry1@gmail.com>,
	Patrick Venture <venture@google.com>, Nancy Yuen <yuenn@google.com>,
	Benjamin Fair <benjaminfair@google.com>,
	Pavel Machek <pavel@ucw.cz>, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-csky@vger.kernel.org,
	linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org,
	linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org,
	linux-sh@vger.kernel.org, xen-devel@lists.xenproject.org,
	linux-acpi@vger.kernel.org, linux-omap@vger.kernel.org,
	openbmc@lists.ozlabs.org, linux-tegra@vger.kernel.org,
	linux-pm@vger.kernel.org
Subject: Re: [PATCH v2 24/45] regulator: pfuze100: Use
 devm_register_power_handler()
Message-ID: <YXqQjG+5Eshm9fl5@sirena.org.uk>
References: <20211027211715.12671-1-digetx@gmail.com>
 <20211027211715.12671-25-digetx@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="Wle3PKA2/qG6+6Vj"
Content-Disposition: inline
In-Reply-To: <20211027211715.12671-25-digetx@gmail.com>
X-Cookie: try again


--Wle3PKA2/qG6+6Vj
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Oct 28, 2021 at 12:16:54AM +0300, Dmitry Osipenko wrote:

> Use devm_register_power_handler() that replaces global pm_power_off_prepare
> variable and allows to register multiple power-off handlers.

Acked-by: Mark Brown <broonie@kernel.org>

--Wle3PKA2/qG6+6Vj
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmF6kIwACgkQJNaLcl1U
h9AyhAf+Nziuu181EjKis21sdValh/0I2qd5n6cZmpuLUeA7g6K6TyFH79y+tEkd
Itu0nx35rsztyjl7+A8ECF9S9uJGD1N0o3cruhqU01R5Kloz9mrUDRii5R3Uh+fm
wjXlm+iYDXdXIzRmM07WyWi8rUTpLrhHx7ogAb291MVxgxc1LqxOBAwk6hcvnDCB
aLDZSKk0LT7/yHSU+s5sBmll+K1S09x+XUfo/7VEuf9WqctxN8t6DgnigNeg1sU1
S3cmBREB1bkkqHuPWJhOyUeW6YyuYI8inCcpXRNtdydg4jwo5l2h16fE8e0db953
VsD3Y2dmLQu1qKxLNZUqHCelyjTPow==
=sNsl
-----END PGP SIGNATURE-----

--Wle3PKA2/qG6+6Vj--


From xen-devel-bounces@lists.xenproject.org Thu Oct 28 12:06:59 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Oct 2021 12:06:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217938.378164 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg4BC-0008Sr-7T; Thu, 28 Oct 2021 12:06:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217938.378164; Thu, 28 Oct 2021 12:06:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg4BC-0008Sk-4T; Thu, 28 Oct 2021 12:06:46 +0000
Received: by outflank-mailman (input) for mailman id 217938;
 Thu, 28 Oct 2021 12:06:44 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=PZP8=PQ=armlinux.org.uk=linux+xen-devel=lists.xenproject.org@srs-us1.protection.inumbo.net>)
 id 1mg4BA-0008Sa-9y
 for xen-devel@lists.xenproject.org; Thu, 28 Oct 2021 12:06:44 +0000
Received: from pandora.armlinux.org.uk (unknown
 [2001:4d48:ad52:32c8:5054:ff:fe00:142])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 92ec2a09-0148-4841-bb16-56e0f6e08e17;
 Thu, 28 Oct 2021 12:06:42 +0000 (UTC)
Received: from shell.armlinux.org.uk
 ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:55352)
 by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2)
 (envelope-from <linux@armlinux.org.uk>)
 id 1mg49X-0007U2-7Y; Thu, 28 Oct 2021 13:05:03 +0100
Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2)
 (envelope-from <linux@shell.armlinux.org.uk>)
 id 1mg49J-0000E4-10; Thu, 28 Oct 2021 13:04:49 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
X-Inumbo-ID: 92ec2a09-0148-4841-bb16-56e0f6e08e17
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type:
	MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To:
	Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:
	Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:
	List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive;
	bh=GpuSFsY8v1fsacTBMl7cW/OISWXGLDeNRbuCtC30aBk=; b=W1PY6v3a0gl28+75siyBir0JE7
	Fp7YVXk4eumpI7oh5l3VshDq6gvXTJzeDqwLIA7HtdW9RkL6pMp4IcYWBdC8YBeLJ884GA1gyp1tO
	Y7fSb5TmfSsPkAYf5+Uv0jB+TwExUCboy8NE3ZdeLiqweYYbYNBNKy/YN8LtjXB1cJCNfECPWpzHJ
	IjYFN8VRej9HsaWGHqoXgj+EX24TVLvhRR55/YJ4ERKX12tGykSGVvtNxtRka41e0YKfTDTz73ApZ
	VsLBAxiQuI6I69R2lbhaxUKuFHbz65ETTSdY10Txs8zIAFlVFf6QU2JAAeKgvzmhciKkq1xCECSXs
	jbUZCbwg==;
Date: Thu, 28 Oct 2021 13:04:49 +0100
From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Dmitry Osipenko <digetx@gmail.com>
Cc: Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Lee Jones <lee.jones@linaro.org>,
	"Rafael J . Wysocki" <rafael@kernel.org>,
	Mark Brown <broonie@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>, Guo Ren <guoren@kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Greg Ungerer <gerg@linux-m68k.org>,
	Joshua Thompson <funaho@jurai.org>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Nick Hu <nickhu@andestech.com>, Greentime Hu <green.hu@gmail.com>,
	Vincent Chen <deanbo422@gmail.com>,
	"James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
	Helge Deller <deller@gmx.de>, Michael Ellerman <mpe@ellerman.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Rich Felker <dalias@libc.org>, Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>, x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Len Brown <lenb@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Chen-Yu Tsai <wens@csie.org>,
	Jonathan =?iso-8859-1?Q?Neusch=E4fer?= <j.neuschaefer@gmx.net>,
	Tony Lindgren <tony@atomide.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Vladimir Zapolskiy <vz@mleia.com>,
	Avi Fishman <avifishman70@gmail.com>,
	Tomer Maimon <tmaimon77@gmail.com>,
	Tali Perry <tali.perry1@gmail.com>,
	Patrick Venture <venture@google.com>, Nancy Yuen <yuenn@google.com>,
	Benjamin Fair <benjaminfair@google.com>,
	Pavel Machek <pavel@ucw.cz>, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-csky@vger.kernel.org,
	linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org,
	linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org,
	linux-sh@vger.kernel.org, xen-devel@lists.xenproject.org,
	linux-acpi@vger.kernel.org, linux-omap@vger.kernel.org,
	openbmc@lists.ozlabs.org, linux-tegra@vger.kernel.org,
	linux-pm@vger.kernel.org
Subject: Re: [PATCH v2 10/45] ARM: Use do_kernel_power_off()
Message-ID: <YXqR4T31FOguMnm9@shell.armlinux.org.uk>
References: <20211027211715.12671-1-digetx@gmail.com>
 <20211027211715.12671-11-digetx@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211027211715.12671-11-digetx@gmail.com>
Sender: Russell King (Oracle) <linux@armlinux.org.uk>

On Thu, Oct 28, 2021 at 12:16:40AM +0300, Dmitry Osipenko wrote:
> Kernel now supports chained power-off handlers. Use do_kernel_power_off()
> that invokes chained power-off handlers. It also invokes legacy
> pm_power_off() for now, which will be removed once all drivers will
> be converted to the new power-off API.
> 
> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>

Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>

Thanks!

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!


From xen-devel-bounces@lists.xenproject.org Thu Oct 28 12:09:38 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Oct 2021 12:09:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217945.378175 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg4Dr-0000eY-Lj; Thu, 28 Oct 2021 12:09:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217945.378175; Thu, 28 Oct 2021 12:09:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg4Dr-0000eR-IT; Thu, 28 Oct 2021 12:09:31 +0000
Received: by outflank-mailman (input) for mailman id 217945;
 Thu, 28 Oct 2021 12:09:29 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ikAZ=PQ=epam.com=prvs=19352d112c=oleksandr_andrushchenko@srs-us1.protection.inumbo.net>)
 id 1mg4Dp-0000eE-Kd
 for xen-devel@lists.xenproject.org; Thu, 28 Oct 2021 12:09:29 +0000
Received: from mx0a-0039f301.pphosted.com (unknown [148.163.133.242])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id e59db32b-37e7-11ec-849e-12813bfff9fa;
 Thu, 28 Oct 2021 12:09:28 +0000 (UTC)
Received: from pps.filterd (m0174678.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 19SBuGZ5029362; 
 Thu, 28 Oct 2021 12:09:27 GMT
Received: from eur05-am6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2106.outbound.protection.outlook.com [104.47.18.106])
 by mx0a-0039f301.pphosted.com with ESMTP id 3byt7srd2m-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Thu, 28 Oct 2021 12:09:26 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by AM0PR03MB4434.eurprd03.prod.outlook.com (2603:10a6:208:c7::25)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.18; Thu, 28 Oct
 2021 12:09:23 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::c038:e032:595a:651]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::c038:e032:595a:651%9]) with mapi id 15.20.4649.015; Thu, 28 Oct 2021
 12:09:23 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e59db32b-37e7-11ec-849e-12813bfff9fa
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=P4xbdy/AvyNNODjFNREfmc+L8B7K7s5VEsC149QztK4OwJhCy+7W0iQo7sA0l+FhLgIfiifnEckZ0gZFQ5tMz9DyhprEoB1+Sg/F6f9kjg/BtXUJvLmjrYQQJSEPjkAfUtemtWtFCd0BRbXRUlqa+NevtRxItM66ColSrsDvxbA+c0r9zVaJvbdgyXrugIYJfhjPhD7FmXlu1wHrzEnF5AmbUuUWDImMFL73mpsHHZ7TNpic3FxOMTBBT89u5QIKthINC+UPR1hWRej7eS0tKI7fVMJ6NwAQV428LQz6NEPJrfak9lo4+Iy4u5JoaTMVscbhq+FIsqYQCYgb6xBIOg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=KXjVVaYRIzu3YZAJHyXoYeMii60wVndp7uSUSjaKSlM=;
 b=EPKkpda56LsQbEvawaoBQiow34vLl3+JVqKVzj/q856zNV6iUuZgVoOHG1uJuKV0Vt9biiSQZ0fnQqYYJEzcENC/0pDpsmg3xZve1RhfmhnXawDOubEHyp1yehME0JxL3b5lMJk5dGP+n6qBhgLdaakGs27H7TbHa/nEKHU4e6CdgOYhzXz1gKW19v6aUT9mQlaG6Bq11xIIorO4gYOx0RPdZveh5Bi2tUv9UBEpzgU4H7C9PqOdRb722BQPvIHh5U9mQZA7k78MVA5LupddfaYexsj/kSJuiyfmBIoRyI/7TOGhtZg+HwiORG7Ea2Wk19kzVSUP4DllJpwJcLDrzg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=KXjVVaYRIzu3YZAJHyXoYeMii60wVndp7uSUSjaKSlM=;
 b=boW8FciuFcNCdlB0uK7vXtX6z/jkps4kjer+cT9zx4SlaRsQHsu1LpASLZSh4ibm36P3DmiqSYf4o7d7NkqT/ePV7pz0XAUh4P/2FvoL1/qyF88H5GTY9Hh8CCzRoyZ8yro92d0L7S5NqwukfRa7GE+pyH2KtdSD9g651Fvg7qfrhXAOIobVBuCXuPPhit0mnlFREetDRq3hqJvK7T/0ru0Emftban5wpAV4injwczkmhSwiFcvsED9mC+qZq0+w8adfQ9XCdGcyZ4ggMVbtBMIZsRX8V1+ub6T6BCE7/cf6Npd6g6YhEyaLl3O8B2blCTYXCPjtU/l98CqLNJDtNw==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Julien Grall <julien@xen.org>,
        "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: "sstabellini@kernel.org" <sstabellini@kernel.org>,
        "iwj@xenproject.org"
	<iwj@xenproject.org>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Rahul
 Singh <rahul.singh@arm.com>,
        Oleksandr Andrushchenko
	<Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH] xen/arm: fix SBDF calculation for vPCI MMIO handlers
Thread-Topic: [PATCH] xen/arm: fix SBDF calculation for vPCI MMIO handlers
Thread-Index: AQHXyww6rKHs3LJru0q52eLUia+oNavnHBIAgAE3H4A=
Date: Thu, 28 Oct 2021 12:09:23 +0000
Message-ID: <d63c6e0b-8aa3-9ba3-893c-5e464638a8db@epam.com>
References: <20211027082533.1406015-1-andr2000@gmail.com>
 <cb7e9ef7-476e-93c3-d3c9-9a9ebc61003d@xen.org>
In-Reply-To: <cb7e9ef7-476e-93c3-d3c9-9a9ebc61003d@xen.org>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: e4e01999-7b10-42dc-a910-08d99a0bc7c5
x-ms-traffictypediagnostic: AM0PR03MB4434:
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <AM0PR03MB44340AC15CB72811E66275B9E7869@AM0PR03MB4434.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 nJoZ+iUXipOTgqbbhV0PTGYoD1OEnsv1VwbqqWtH8jFjV4WvUHlJBH1w+bZdhsTXHH1jDWr8EF8pnIkV1wfUbDtj/+Ut9Et9D92JUWIx8Dj9H3IvIewuI/++2BmoHQElb/JQYlRM2SzOogFWunfKH1RY5RJ/jEMHbRAx+iv2U1dRvpzDVVfjnQPu65cjTy6dCcHpcrsXKnDfeIh0rwrK/E4TWL46Z7cDSepltHKM70K8Kc5g7CtYERtM/U2IA3IupSn5t34ni3zsbWW574AeIoF+ey5+epA2M5RiPPSF3Rk+Gr++0QmpL8vuKSghabpo9iZ1x00AdP94mLU92eMBI9rE7WSnpYPxaqkENNhKjLrCKfqLsX++pr4gvgyoZAzgHqwax7zMKLP+XJmx3lo70dWzfHfHiBHYF5gKiU957rPv7gjyAWlwfSfDFsICqD1z8FN0ZZj+nIUKd7JRj+CeKqP+EaCn4/EZ7IdAwBsiopxiprWKWE7KKU1R6N1r4h1krkz0Z1KIQ8NQTHH9CKIRzJK6YbKzkThWnizO0xDswxG8ZQE63NtLguOAv8IWV28aiBAOdKQgJX7nJXptVtjpAX5bTsj6v9w0VP2tr6sjJfxc6hL1sfduxD8WAQ0M3sx/PrNLTdk29JTRpu1msHqVha7EzflHGPCOkzUqOAlBdoWnY1/gqIh6rnDVRf0isYgEJdsuIttmCqmQEfaY3SyBOorxtnjc8rg4M4AsFtGZ0LWJW/trK4RIJ5SoeAASVbrF
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(76116006)(66556008)(66476007)(66446008)(83380400001)(8676002)(26005)(64756008)(91956017)(53546011)(4326008)(36756003)(186003)(107886003)(31686004)(66946007)(508600001)(6486002)(2616005)(54906003)(110136005)(6506007)(6512007)(2906002)(316002)(38100700002)(5660300002)(8936002)(71200400001)(31696002)(38070700005)(86362001)(122000001)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?UXFteGtxQ0swTk9TUmU0UlowYWZCQ2RGWmNKSDAvclhoemI4ME1MdXlkVk4y?=
 =?utf-8?B?NVZzbExqWEhBcWVEYlRoeXgyOFVuRHNRbHViNHpaZVI0c0lkRHRCRG1zdkxq?=
 =?utf-8?B?SnMvaUdsaHdKWXYrMCtzTXZ2VGJLVWF5N0NGN1plUlI0WEpvZHN2aUorRTZJ?=
 =?utf-8?B?Mm5xOTFXVEszTTE1cVFia2hkT1FSeVFZNXFGcUpIY1Q5VVQ1QUhwdG5GdVBG?=
 =?utf-8?B?aUNJYU43SmxEOW1VK1d5NXRKQ3psbmh2ZFRDTnBRY2hoN1R1WlBiRGcxYlBi?=
 =?utf-8?B?dDc2SStBaldnTlhMUlpwcjNSdlFZUlpkdVFUS1FCVXNaM1FuTVlWVXdTdDdj?=
 =?utf-8?B?NUxNYVlmbDlhamhLMnJMNWE3RWhWNU15dGM3UnFhYXN1WkJMMWVVRGtteFVS?=
 =?utf-8?B?VWkwOWV3WFpGMjRkUXdCOG5sOEtRU2JWNlYxa1Btczg1eXlPeWZVT2cwaUZV?=
 =?utf-8?B?amhVWmx5Uk9QMVlkTVU1MTBnaHF4aEJISWk1OW1OTXhNNThkbjBEY2g1Ukh1?=
 =?utf-8?B?QU93NnJjb1ROeDFXMkdzNnRnd245RTgzODdubWF0MGwzdkt3c2Q1aEQvRjdk?=
 =?utf-8?B?MFpjOXNTY0VMeURZelBDMGM2Zlo0VEtGUlBVRUgrOHNwTmsrcmlnTGRKMVQ2?=
 =?utf-8?B?M084MTdmSndSUzFwTGEyMk9haE9JaG5kN3hPLzBCTk5HUkVzeFRBWnQwTlBv?=
 =?utf-8?B?aDdFYlhESTNQMldkUGtSWFR5dDN4WGxiaVUrRmkzdWlQOHluQ0w5aEkxc21l?=
 =?utf-8?B?dXZBWTAvSHlwMnVGbEFibEFQRDFuUkVlZ3VFQW1JL2U5SkozaGo5ai8vZkU0?=
 =?utf-8?B?NXhoNGxqR0RhOE1WN0xtL0R3Z3VDZmROektINk9nL2dKT3hLSjMrellVS0kz?=
 =?utf-8?B?OWhJT0laNTB2MDMxcnpDRW9MMFIwUkV5bnZrby9QM1JZb0pnQ3dWaTZydzlW?=
 =?utf-8?B?amxXTzJFY1RTN0hGcFNUVFJ6bVhmSngxMEY5a0hrM29ncERxelpweWptUkpj?=
 =?utf-8?B?MmVLUGszSExqM21mdElLM21hczhYelVWYlgzNTZvVWFXQkpMNVJkcjl5aW1X?=
 =?utf-8?B?OFNFdUdVd2I4QTJ3eUsxVHdPYmdUc2ZEQitrdWFiZkZ5TmlFZGtNUkJQM013?=
 =?utf-8?B?YVA5cVZSakYvVVZGNHNuc0N6Uk5ZWVRJMzJ1cmhhMGwxVDdkallON2trNmUx?=
 =?utf-8?B?Y2ZVTFpvR1IrcHd3Wk9sSVJCVTZpcXZkNm9yaGg5QWZsMmEzemF4aGMwTmN3?=
 =?utf-8?B?V3ptUTRxTVd0dnc3Ry9jRDNLeTFFMWVtRC9xd2hQZjMwVzVmMCs2ZmNPcGl3?=
 =?utf-8?B?RDNUTEpNSFhhOW5CODREWm1MSU5sYm1xUlR3TTZ2MFE3SzMxZHMrSS9aeHZz?=
 =?utf-8?B?ZlRhZTVHK3NPb29NWjZmRlBtbWlxUmRvaW40NXJZdVZHclg3WU5pdTZhVlZ2?=
 =?utf-8?B?UThQOVRDZnpTNEo1ZWQrMzdvQjZ6aW1jVlJOTFNuVGpxb2xsc2ovWDVQVDc0?=
 =?utf-8?B?YjVpTGJaL3lZN1NTMk8yRWhCOGZraHlYeFQwUEVkT2srVXZPcjZOdEZibFQz?=
 =?utf-8?B?YlN0VnFUcWhhOStIenpJSjhqUnFPdVdPckpvWEtNOFNmeENNdlJRK0JNTWJR?=
 =?utf-8?B?eHMvcmxETDBscnRWN1A1RWt4aUJ6c1pmcGQwTXRzbW15SHIwYW82VFAxb3lU?=
 =?utf-8?B?Rnk3bVg3OWVTTWVIZ29pT0hwMkNSWnVXaytzb1RsYlhNQ3oxaHF0WmpidmVn?=
 =?utf-8?B?WkdDa0FlMEN3VVBlcXhJaTQySnUrSkVqdDJmb2pveFdTdWpEdkcxbXN3TTZH?=
 =?utf-8?B?aVBLV3pYbnZvQ04wdnRJdEdDYTVZc3dzRkYwNzBJMlJqV0ZBeUZJaHl5cDBh?=
 =?utf-8?B?RW5OdmJ2MGVPSTdEditTbWZVbTVZekpFcGI3ZmxhTjJOakRiclRhQS9zbmpV?=
 =?utf-8?B?clF6NVhZdnV1Ui9HM0FwaUFsUzBaU1luekdFTXpXSW9FNXBZKzl3dG5pUEhC?=
 =?utf-8?B?NEs2c2xPZmZBdHJFUW9laEcyYjhJWTNuR3NEWklzQzZaeUtjemxpVzk4bFFo?=
 =?utf-8?B?eVQxQ3RjRmsxeWxaamF5RnN2UFBRZHV4dDdXeEd5NGs2dm5kZ1cyby8yZmJt?=
 =?utf-8?B?ekZ1RzRVQXQvdW44dDRSK3dMYWU3OGdGQmRORWZDVDBCcktjek1pbTlsRGJO?=
 =?utf-8?B?a0o1Z0h2MWFuYnQ4dnhwazg5dlo2S3V1ZERRTmtFazBOWFNqd1NNcDRSRjVI?=
 =?utf-8?B?NkxiU1B1K2lsRFZqanUvMUg1RUw1TUM1cElJSFIyZjNwZVZ5Y3Y4VFlBbnUv?=
 =?utf-8?B?TzVnTG1nWmxQbk8wWUlvdFJQT0lpZG9HOGZlM0Z3U211c0x4bjc1QT09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <E4A4052A0D6E604FBDCA5F2581DD2407@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e4e01999-7b10-42dc-a910-08d99a0bc7c5
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Oct 2021 12:09:23.5438
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: yY1GJSG0Ew8w8qP7JArV2NVXh4Yan3VEXdswp+gKx0AvZxIObLufBIqf8kUhjqT9v5Lfq3NPGQ4GZmYXcaF7gs8pfu5c38LoCV4hPU1QAlr9sP3HvR5aCtbxrZVGwbZb
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR03MB4434
X-Proofpoint-GUID: v0x8s0WpRO10k3QVVp93vu4-rABen6tS
X-Proofpoint-ORIG-GUID: v0x8s0WpRO10k3QVVp93vu4-rABen6tS
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475
 definitions=2021-10-28_01,2021-10-26_01,2020-04-07_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 spamscore=0
 clxscore=1015 impostorscore=0 suspectscore=0 priorityscore=1501
 bulkscore=0 lowpriorityscore=0 mlxscore=0 malwarescore=0 adultscore=0
 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2110280066

SGksIEp1bGllbiENCg0KT24gMjcuMTAuMjEgMjA6MzUsIEp1bGllbiBHcmFsbCB3cm90ZToNCj4g
SGkgT2xla3NhbmRyLA0KPg0KPiBPbiAyNy8xMC8yMDIxIDA5OjI1LCBPbGVrc2FuZHIgQW5kcnVz
aGNoZW5rbyB3cm90ZToNCj4+IEZyb206IE9sZWtzYW5kciBBbmRydXNoY2hlbmtvIDxvbGVrc2Fu
ZHJfYW5kcnVzaGNoZW5rb0BlcGFtLmNvbT4NCj4+DQo+PiBXaGlsZSBpbiB2UENJIE1NSU8gdHJh
cCBoYW5kbGVycyBmb3IgdGhlIGd1ZXN0IFBDSSBob3N0IGJyaWRnZSBpdCBpcyBub3QNCj4+IGVu
b3VnaCBmb3IgU0JERiB0cmFuc2xhdGlvbiB0byBzaW1wbHkgY2FsbCBWUENJX0VDQU1fQkRGKGlu
Zm8tPmdwYSkgYXMNCj4+IHRoZSBiYXNlIGFkZHJlc3MgbWF5IG5vdCBiZSBhbGlnbmVkIGluIHRo
ZSB3YXkgdGhhdCB0aGUgdHJhbnNsYXRpb24NCj4+IGFsd2F5cyB3b3JrLiBJZiBub3QgYWRqdXN0
ZWQgd2l0aCByZXNwZWN0IHRvIHRoZSBiYXNlIGFkZHJlc3MgaXQgbWF5IG5vdCBiZQ0KPj4gYWJs
ZSB0byBwcm9wZXJseSBjb252ZXJ0IFNCREYgYW5kIGNyYXNoZXM6DQo+Pg0KPj4gKFhFTikgdnBj
aV9tbWlvX3JlYWQgMDAwMDo2NToxYS4wIHJlZyA4YmMgZ3BhIGU2NWQwOGJjDQo+DQo+IEkgY2Fu
J3QgZmluZCBhIHByaW50aygpIHRoYXQgbWF5IG91dHB1dCB0aGlzIG1lc3NhZ2UuIFdoZXJlIGRv
ZXMgdGhpcyBjb21lcyBmcm9tPw0KVGhhdCB3YXMgYSBkZWJ1ZyBwcmludC4gSSBzaG91bGRuJ3Qg
aGF2ZSB1c2VkIHRoYXQgaW4gdGhlIHBhdGNoIGRlc2NyaXB0aW9uLCBidXQNCnByb2JhYmx5IGFm
dGVyICItLS0iIHRvIGJldHRlciBleHBsYWluIHdoYXQncyBoYXBwZW5pbmcNCj4NCj4gQW55d2F5
LCBJSVVDIHRoZSBndWVzdCBwaHlzaWNhbCBhZGRyZXNzIGlzIDB4ZTY1ZDA4YmMgd2hpY2gsIGlm
IEkgYW0gbm90IG1pc3Rha2VuLCBkb2Vzbid0IGJlbG9uZyB0byB0aGUgcmFuZ2UgYWR2ZXJ0aXNl
ZCBmb3IgR1VFU1RfVlBDSV9FQ0FNLg0KVGhpcyBpcyBmcm9tIGRvbTAgSSBhbSB3b3JraW5nIG9u
IG5vdy4NCj4NCj4gSU1ITywgdGhlIHN0YWNrIHRyYWNlIHNob3VsZCBjb21lIGZyb20gdXNwdHJl
YW0gWGVuIG9yIG5lZWQgc29tZSBpbmZvcm1hdGlvbiB0byBleHBsYWluIGhvdyB0aGlzIHdhcyBy
ZXByb2R1Y2VkLg0KPg0KPj4gKFhFTikgRGF0YSBBYm9ydCBUcmFwLiBTeW5kcm9tZT0weDYNCj4+
IChYRU4pIFdhbGtpbmcgSHlwZXJ2aXNvciBWQSAweDQ2N2EyOGJjIG9uIENQVTAgdmlhIFRUQlIg
MHgwMDAwMDAwMDQ4MWQ1MDAwDQo+IEkgY2FuIHVuZGVyc3RuYWQgdGhhdCBpZiB3ZSBkb24ndCBz
dWJzdHJhY3QgR1VFU1RfVlBDSV9FQ0FNLCB3ZSB3b3VsZCAoaW4gdGhlb3J5KSBub3QgZ2V0IHRo
ZSBjb3JyZWN0IEJERi4gQnV0Li4uIEkgZG9uJ3QgdW5kZXJzdGFuZCBob3cgdGhpcyB3b3VsZCBy
ZXN1bHQgdG8gYSBkYXRhIGFib3J0IGluIHRoZSBoeXBlcnZpc29yLg0KPg0KPiBJbiBmYWN0LCBJ
IHRoaW5rIHRoZSB2UENJIGNvZGUgc2hvdWxkIGJlIHJlc2lsaWVudCBlbm91Z2ggdG8gbm90IGNy
YXNoIGlmIHdlIHBhc3MgdGhlIHdyb25nIEJERi4NCldlbGwsIHRoZXJlIGlzIG5vICg/KSBlYXN5
IHdheSB0byB2YWxpZGF0ZSBTQkRGLiBBbmQgdGhpcyBjb3VsZCBiZSBhIHByb2JsZW0gaWYgd2Ug
aGF2ZSBhIG1pc2JlaGF2aW5nDQpndWVzdCB3aGljaCBtYXkgZm9yY2UgWGVuIHRvIGFjY2VzcyB0
aGUgbWVtb3J5IGJleW9uZCB0aGF0IG9mIFBDSSBob3N0IGJyaWRnZQ0KPg0KPiBXaGVuIHRoZXJl
IGlzIGEgZGF0YSBhYm9ydCBpbiBYZW4sIHlvdSBzaG91bGQgZ2V0IGEgc3RhY2sgdHJhY2UgZnJv
bSB3aGVyZSB0aGlzIGNvbWVzIGZyb20uIENhbiB5b3UgcGFzdGUgaXQgaGVyZT8NCihYRU4pIERh
dGEgQWJvcnQgVHJhcC4gU3luZHJvbWU9MHg2DQooWEVOKSBXYWxraW5nIEh5cGVydmlzb3IgVkEg
MHg0NjdhMjhiYyBvbiBDUFUwIHZpYSBUVEJSIDB4MDAwMDAwMDA0ODFkNTAwMA0KKFhFTikgMFRI
WzB4MF0gPSAweDAwMDAwMDAwNDgxZDRmN2YNCihYRU4pIDFTVFsweDFdID0gMHgwMDAwMDAwMDQ4
MWQyZjdmDQooWEVOKSAyTkRbMHgzM10gPSAweDAwMDAwMDAwMDAwMDAwMDANCihYRU4pIENQVTA6
IFVuZXhwZWN0ZWQgVHJhcDogRGF0YSBBYm9ydA0KKFhFTikgLS0tLVsgWGVuLTQuMTYtdW5zdGFi
bGXCoCBhcm02NMKgIGRlYnVnPXnCoCBOb3QgdGFpbnRlZCBdLS0tLQ0KKFhFTikgQ1BVOsKgwqDC
oCAwDQooWEVOKSBQQzrCoMKgwqDCoCAwMDAwMDAwMDAwMjZkM2Q0IHBjaV9nZW5lcmljX2NvbmZp
Z19yZWFkKzB4ODgvMHg5Yw0KKFhFTikgTFI6wqDCoMKgwqAgMDAwMDAwMDAwMDI2ZDM2Yw0KKFhF
TikgU1A6wqDCoMKgwqAgMDAwMDgwMDA3ZmY5N2MwMA0KKFhFTikgQ1BTUjrCoMKgIDAwMDAwMDAw
NjA0MDAyNDkgTU9ERTo2NC1iaXQgRUwyaCAoSHlwZXJ2aXNvciwgaGFuZGxlcikNCihYRU4pwqDC
oMKgwqDCoCBYMDogMDAwMDAwMDA0NjdhMjhiY8KgIFgxOiAwMDAwMDAwMDA2NWQwOGJjwqAgWDI6
IDAwMDAwMDAwMDAwMDA4YmMNCihYRU4pwqDCoMKgwqDCoCBYMzogMDAwMDAwMDAwMDAwMDAwY8Kg
IFg0OiAwMDAwODAwMDdmZmM2ZmQwwqAgWDU6IDAwMDAwMDAwMDAwMDAwMDANCihYRU4pwqDCoMKg
wqDCoCBYNjogMDAwMDAwMDAwMDAwMDAxNMKgIFg3OiBmZmZmODAwMDExYTU4MDAwwqAgWDg6IGZm
ZmYwMDAwMjI1YTAzODANCihYRU4pwqDCoMKgwqDCoCBYOTogMDAwMDAwMDAwMDAwMDAwMCBYMTA6
IDAxMDEwMTAxMDEwMTAxMDEgWDExOiAwMDAwMDAwMDAwMDAwMDI4DQooWEVOKcKgwqDCoMKgIFgx
MjogMDEwMTAxMDEwMTAxMDEwMSBYMTM6IDAwMDAwMDAwMDAwMDAwMjAgWDE0OiBmZmZmZmZmZmZm
ZmZmZmZmDQooWEVOKcKgwqDCoMKgIFgxNTogMDAwMDAwMDAwMDAwMDAwMSBYMTY6IGZmZmY4MDAw
MTBkYTY3MDggWDE3OiAwMDAwMDAwMDAwMDAwMDIwDQooWEVOKcKgwqDCoMKgIFgxODogMDAwMDAw
MDAwMDAwMDAwMiBYMTk6IDAwMDAwMDAwMDAwMDAwMDQgWDIwOiAwMDAwODAwMDdmZjk3YzVjDQoo
WEVOKcKgwqDCoMKgIFgyMTogMDAwMDAwMDAwMDAwMDhiYyBYMjI6IDAwMDAwMDAwMDAwMDA4YmMg
WDIzOiAwMDAwMDAwMDAwMDAwMDA0DQooWEVOKcKgwqDCoMKgIFgyNDogMDAwMDAwMDAwMDAwMDAw
MCBYMjU6IDAwMDAwMDAwMDAwMDA4YmMgWDI2OiAwMDAwMDAwMDAwMDA2NWQwDQooWEVOKcKgwqDC
oMKgIFgyNzogMDAwMDgwMDA3ZmZiOTAxMCBYMjg6IDAwMDAwMDAwMDAwMDAwMDDCoCBGUDogMDAw
MDgwMDA3ZmY5N2MwMA0KKFhFTikNCihYRU4pwqDCoCBWVENSX0VMMjogMDAwMDAwMDA4MDBhMzU1
OA0KKFhFTinCoCBWVFRCUl9FTDI6IDAwMDEwMDAwYmZmYmEwMDANCihYRU4pDQooWEVOKcKgIFND
VExSX0VMMjogMDAwMDAwMDAzMGNkMTgzZA0KKFhFTinCoMKgwqAgSENSX0VMMjogMDAwMDAwMDA4
MDdjNjYzZg0KKFhFTinCoCBUVEJSMF9FTDI6IDAwMDAwMDAwNDgxZDUwMDANCihYRU4pDQooWEVO
KcKgwqDCoCBFU1JfRUwyOiAwMDAwMDAwMDk2MDAwMDA2DQooWEVOKcKgIEhQRkFSX0VMMjogMDAw
MDAwMDAwMGU2NWQwMA0KKFhFTinCoMKgwqAgRkFSX0VMMjogMDAwMDAwMDA0NjdhMjhiYw0KKFhF
TikNCltzbmlwXQ0KKFhFTikgWGVuIGNhbGwgdHJhY2U6DQooWEVOKcKgwqDCoCBbPDAwMDAwMDAw
MDAyNmQzZDQ+XSBwY2lfZ2VuZXJpY19jb25maWdfcmVhZCsweDg4LzB4OWMgKFBDKQ0KKFhFTinC
oMKgwqAgWzwwMDAwMDAwMDAwMjZkMzZjPl0gcGNpX2dlbmVyaWNfY29uZmlnX3JlYWQrMHgyMC8w
eDljIChMUikNCihYRU4pwqDCoMKgIFs8MDAwMDAwMDAwMDI2ZDJjOD5dIHBjaS1hY2Nlc3MuYyNw
Y2lfY29uZmlnX3JlYWQrMHg2MC8weDg0DQooWEVOKcKgwqDCoCBbPDAwMDAwMDAwMDAyNmQ0YTg+
XSBwY2lfY29uZl9yZWFkMzIrMHgxMC8weDE4DQooWEVOKcKgwqDCoCBbPDAwMDAwMDAwMDAyNGRj
Zjg+XSB2cGNpLmMjdnBjaV9yZWFkX2h3KzB4NDgvMHhiOA0KKFhFTinCoMKgwqAgWzwwMDAwMDAw
MDAwMjRlM2U0Pl0gdnBjaV9yZWFkKzB4YWMvMHgyNGMNCihYRU4pwqDCoMKgIFs8MDAwMDAwMDAw
MDI0ZTkzND5dIHZwY2lfZWNhbV9yZWFkKzB4NzgvMHhhOA0KKFhFTinCoMKgwqAgWzwwMDAwMDAw
MDAwMjZlMzY4Pl0gdnBjaS5jI3ZwY2lfbW1pb19yZWFkKzB4NDQvMHg3Yw0KKFhFTinCoMKgwqAg
WzwwMDAwMDAwMDAwMjc1MDU0Pl0gdHJ5X2hhbmRsZV9tbWlvKzB4MWVjLzB4MjY0DQooWEVOKcKg
wqDCoCBbPDAwMDAwMDAwMDAyN2VhNTA+XSB0cmFwcy5jI2RvX3RyYXBfc3RhZ2UyX2Fib3J0X2d1
ZXN0KzB4MThjLzB4MmQ4DQooWEVOKcKgwqDCoCBbPDAwMDAwMDAwMDAyN2YwODg+XSBkb190cmFw
X2d1ZXN0X3N5bmMrMHhmMC8weDYxOA0KKFhFTinCoMKgwqAgWzwwMDAwMDAwMDAwMjY5YzU4Pl0g
ZW50cnkubyNndWVzdF9zeW5jX3Nsb3dwYXRoKzB4YTQvMHhkNA0KKFhFTikNCihYRU4pDQooWEVO
KSAqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqDQooWEVOKSBQYW5pYyBv
biBDUFUgMDoNCihYRU4pIENQVTA6IFVuZXhwZWN0ZWQgVHJhcDogRGF0YSBBYm9ydA0KKFhFTikg
KioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKg0KDQo+DQo+Pg0KPj4gRml4
IHRoaXMgYnkgYWRqdXN0aW5nIHRoZSBncGEgd2l0aCByZXNwZWN0IHRvIHRoZSBob3N0IGJyaWRn
ZSBiYXNlIGFkZHJlc3MNCj4+IGluIGEgd2F5IGFzIGl0IGlzIGRvbmUgZm9yIHg4Ni4NCj4+DQo+
PiBGaXhlczogZDU5MTY4ZGMwNWE1ICgieGVuL2FybTogRW5hYmxlIHRoZSBleGlzdGluZyB4ODYg
dmlydHVhbCBQQ0kgc3VwcG9ydCBmb3IgQVJNIikNCj4+DQo+PiBTaWduZWQtb2ZmLWJ5OiBPbGVr
c2FuZHIgQW5kcnVzaGNoZW5rbyA8b2xla3NhbmRyX2FuZHJ1c2hjaGVua29AZXBhbS5jb20+DQo+
PiAtLS0NCj4+IMKgIHhlbi9hcmNoL2FybS92cGNpLmMgfCA0ICsrLS0NCj4+IMKgIDEgZmlsZSBj
aGFuZ2VkLCAyIGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pDQo+Pg0KPj4gZGlmZiAtLWdp
dCBhL3hlbi9hcmNoL2FybS92cGNpLmMgYi94ZW4vYXJjaC9hcm0vdnBjaS5jDQo+PiBpbmRleCA4
ZjQwYTBkZWM2ZDIuLjIzZjQ1Mzg2ZjRiMyAxMDA2NDQNCj4+IC0tLSBhL3hlbi9hcmNoL2FybS92
cGNpLmMNCj4+ICsrKyBiL3hlbi9hcmNoL2FybS92cGNpLmMNCj4+IEBAIC0yNCw3ICsyNCw3IEBA
IHN0YXRpYyBpbnQgdnBjaV9tbWlvX3JlYWQoc3RydWN0IHZjcHUgKnYsIG1taW9faW5mb190ICpp
bmZvLA0KPj4gwqDCoMKgwqDCoCB1bnNpZ25lZCBsb25nIGRhdGE7DQo+PiDCoCDCoMKgwqDCoMKg
IC8qIFdlIGlnbm9yZSBzZWdtZW50IHBhcnQgYW5kIGFsd2F5cyBoYW5kbGUgc2VnbWVudCAwICov
DQo+PiAtwqDCoMKgIHNiZGYuc2JkZiA9IFZQQ0lfRUNBTV9CREYoaW5mby0+Z3BhKTsNCj4+ICvC
oMKgwqAgc2JkZi5zYmRmID0gVlBDSV9FQ0FNX0JERihpbmZvLT5ncGEgLSBHVUVTVF9WUENJX0VD
QU1fQkFTRSk7DQo+DQo+IExvb2tpbmcgYXQgdGhlIHJlc3Qgb2YgdGhlIHJlc3QsIGl0IHNlZW1z
IHRoYXQNCj4gwqAxKSB0aGUgaXNzdWUgaXMgbGF0ZW50IGFzIHRoZSBiaXRzIDAtMjcgYXJlIGNs
ZWFyDQo+IMKgMikgdGhpcyB3aWxsIG5lZWQgdG8gYmUgbW9kaWZpZWQgdG8gdGFrZSBpbnRvIGFj
Y291bnQgZG9tMC4NCj4NCj4gU28gSSB3b3VsZCBwcmVmZXIgaWYgdGhlIGJhc2UgYWRkcmVzcyBp
cyBwYXNzZWQgZGlmZmVyZW50bHkgKG1heWJlIGluIHByaXY/KSBmcm9tIHRoZSBzdGFydC4gVGhp
cyB3aWxsIGF2b2lkIGV4dHJhIG1vZGlmaWNhdGlvbiB0aGF0IHlvdSBhbHJlYWR5IHBsYW4gdG8g
aGF2ZSBpbiBhIGZvbGxvdy11cCBzZXJpZXMuDQpJIHdhcyB0aGlua2luZyBhYm91dCB0aGUgc2Ft
ZSwgYnV0IHRoZSBmdXR1cmUgY29kZSB3aWxsIHVzZSBwcml2IGZvciBvdGhlciBwdXJwb3NlOg0K
DQpzdGF0aWMgaW50IHZwY2lfbW1pb19yZWFkKHN0cnVjdCB2Y3B1ICp2LCBtbWlvX2luZm9fdCAq
aW5mbywNCiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oCByZWdpc3Rlcl90ICpyLCB2b2lkICpwKQ0Kew0KIMKgwqDCoCBzdHJ1Y3QgcGNpX2hvc3RfYnJp
ZGdlICpicmlkZ2UgPSBwOw0KIMKgwqDCoCBwY2lfc2JkZl90IHNiZGY7DQogwqDCoMKgIC8qIGRh
dGEgaXMgbmVlZGVkIHRvIHByZXZlbnQgYSBwb2ludGVyIGNhc3Qgb24gMzJiaXQgKi8NCiDCoMKg
wqAgdW5zaWduZWQgbG9uZyBkYXRhOw0KDQogwqDCoMKgIGlmICggYnJpZGdlICkNCiDCoMKgwqAg
ew0KIMKgwqDCoMKgwqDCoMKgIHNiZGYuc2JkZiA9IFZQQ0lfRUNBTV9CREYoaW5mby0+Z3BhIC0g
YnJpZGdlLT5jZmctPnBoeXNfYWRkcik7DQogwqDCoMKgwqDCoMKgwqAgc2JkZi5zZWcgPSBicmlk
Z2UtPnNlZ21lbnQ7DQogwqDCoMKgIH0NCiDCoMKgwqAgZWxzZQ0KIMKgwqDCoMKgwqDCoMKgIHNi
ZGYuc2JkZiA9IFZQQ0lfRUNBTV9CREYoaW5mby0+Z3BhIC0gR1VFU1RfVlBDSV9FQ0FNX0JBU0Up
Ow0KDQo+DQo+PiDCoCDCoMKgwqDCoMKgIGlmICggdnBjaV9lY2FtX3JlYWQoc2JkZiwgRUNBTV9S
RUdfT0ZGU0VUKGluZm8tPmdwYSksDQo+PiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoCAxVSA8PCBpbmZvLT5kYWJ0LnNpemUsICZkYXRhKSApDQo+PiBA
QCAtNDQsNyArNDQsNyBAQCBzdGF0aWMgaW50IHZwY2lfbW1pb193cml0ZShzdHJ1Y3QgdmNwdSAq
diwgbW1pb19pbmZvX3QgKmluZm8sDQo+PiDCoMKgwqDCoMKgIHBjaV9zYmRmX3Qgc2JkZjsNCj4+
IMKgIMKgwqDCoMKgwqAgLyogV2UgaWdub3JlIHNlZ21lbnQgcGFydCBhbmQgYWx3YXlzIGhhbmRs
ZSBzZWdtZW50IDAgKi8NCj4+IC3CoMKgwqAgc2JkZi5zYmRmID0gVlBDSV9FQ0FNX0JERihpbmZv
LT5ncGEpOw0KPj4gK8KgwqDCoCBzYmRmLnNiZGYgPSBWUENJX0VDQU1fQkRGKGluZm8tPmdwYSAt
IEdVRVNUX1ZQQ0lfRUNBTV9CQVNFKTsNCj4+IMKgIMKgwqDCoMKgwqAgcmV0dXJuIHZwY2lfZWNh
bV93cml0ZShzYmRmLCBFQ0FNX1JFR19PRkZTRVQoaW5mby0+Z3BhKSwNCj4+IMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIDFVIDw8IGluZm8t
PmRhYnQuc2l6ZSwgcik7DQo+Pg0KPg0KPiBDaGVlcnMsDQo+DQpUaGFuayB5b3UsDQpPbGVrc2Fu
ZHI=


From xen-devel-bounces@lists.xenproject.org Thu Oct 28 12:10:48 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Oct 2021 12:10:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217951.378186 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg4F1-00022e-10; Thu, 28 Oct 2021 12:10:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217951.378186; Thu, 28 Oct 2021 12:10:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg4F0-00022X-Ss; Thu, 28 Oct 2021 12:10:42 +0000
Received: by outflank-mailman (input) for mailman id 217951;
 Thu, 28 Oct 2021 12:10:41 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Oo2o=PQ=arm.com=michal.orzel@srs-us1.protection.inumbo.net>)
 id 1mg4Ez-00022L-MY
 for xen-devel@lists.xenproject.org; Thu, 28 Oct 2021 12:10:41 +0000
Received: from foss.arm.com (unknown [217.140.110.172])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTP
 id 109b19dc-37e8-11ec-849e-12813bfff9fa;
 Thu, 28 Oct 2021 12:10:39 +0000 (UTC)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 01BB61063;
 Thu, 28 Oct 2021 05:10:39 -0700 (PDT)
Received: from [10.57.24.217] (unknown [10.57.24.217])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B26863F5A1;
 Thu, 28 Oct 2021 05:10:37 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 109b19dc-37e8-11ec-849e-12813bfff9fa
Subject: Re: [patch-4.16] arm/smmuv1,v2: Protect smmu master list with a lock
To: Julien Grall <julien@xen.org>, xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, bertrand.marquis@arm.com,
 Ian Jackson <iwj@xenproject.org>
References: <20211026122903.15042-1-michal.orzel@arm.com>
 <e5632a4e-db98-41b4-1045-2b3532c098fa@xen.org>
 <70c30a6c-b779-805e-079a-41bb484894b9@xen.org>
 <cb452c0c-ccde-7798-c403-f972b48a2c46@arm.com>
 <01545115-e82e-2a9d-a8e4-da9676080c0f@xen.org>
From: Michal Orzel <michal.orzel@arm.com>
Message-ID: <cd1d7a11-6d08-ff3b-d1ca-b495a1d013f4@arm.com>
Date: Thu, 28 Oct 2021 14:10:15 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <01545115-e82e-2a9d-a8e4-da9676080c0f@xen.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit

Hi Julien,

On 27.10.2021 19:02, Julien Grall wrote:
> 
> 
> On 27/10/2021 11:41, Michal Orzel wrote:
>> Hi Julien,
> 
> Hi Michal,
> 
>> On 26.10.2021 18:56, Julien Grall wrote:
>>> Hi,
>>>
>>> On 26/10/2021 17:28, Julien Grall wrote:
>>>> On 26/10/2021 13:29, Michal Orzel wrote:
>>>>> If a device is added to SMMUv1/v2 from DT and PCI
>>>>> at the same time, there is a concurrent access
>>>>> to a smmu master list. This could lead to a
>>>>> scenario where one is looking into a list that
>>>>> is being modified at the same time. Add a lock
>>>>> to prevent this issue.
>>>>
>>>> Did you intend to say "Hold" rather than "Add"?
>>>>
>> Yes, this is what I meant. I will change it.
>>
>>>>>
>>>>> Reuse the existing spinlock arm_smmu_devices_lock
>>>>> as it is already protecting find_smmu_master.
>>>>>
>>>>> ipmmu-smmu and smmuv3 are not impacted by this
>>>>> issue as there is no access or modification of
>>>>> a global resource during add_device.
>>>>>
>>>>> Signed-off-by: Michal Orzel <michal.orzel@arm.com>
>>>>> ---
>>>>> This patch aims for 4.16 release.
>>>>> Benefits:
>>>>> Remove a bug that could lead to a corruption of the
>>>>> smmu master list, which would be very hard to debug.
>>>>
>>>>   From my understanding, this corruption would only happen with CONFIG_HAS_PCI. At the moment, this is a experimental feature as it is not fully complete.
>>>
>>> Actually, digging through the code, I noticed that iommu_add_device() assume that it can only be called with platform/DT. Thankfully, AFAICT, the function would return -ENXIO because the fwspec would not be allocated for PCI device.
>>>
>>> So was this patch tested with additional patch on top?
>>>
>> The purpose of this patch is to fix the issue that is present and which you thankfully noticed.
>> There is still a lot of patches to be added that aim to support PCI passthrough.
>> The complete PCI series is tested with SMMU and it works.
>> But there is no chance to test this patch standalone as iommu_add_device is not in the correct form for PCI as of now.
> 
> Ok. I would suggest to say this is a latent bug so it make clear that the patch is more for hardening at the moment.
> 
Ok I will mention it in the commit msg.

>>>>>    xen/drivers/passthrough/arm/smmu.c | 25 +++++++++++++++++++------
>>>>>    1 file changed, 19 insertions(+), 6 deletions(-)
>>>>>
>>>>> diff --git a/xen/drivers/passthrough/arm/smmu.c b/xen/drivers/passthrough/arm/smmu.c
>>>>> index c9dfc4caa0..be62a66a28 100644
>>>>> --- a/xen/drivers/passthrough/arm/smmu.c
>>>>> +++ b/xen/drivers/passthrough/arm/smmu.c
>>>>> @@ -820,21 +820,25 @@ static int arm_smmu_dt_add_device_legacy(struct arm_smmu_device *smmu,
>>>>>                         struct device *dev,
>>>>>                         struct iommu_fwspec *fwspec)
>>>>>    {
>>>>> -    int i;
>>>>> +    int i, ret;
>>>>>        struct arm_smmu_master *master;
>>>>>        struct device_node *dev_node = dev_get_dev_node(dev);
>>>>> +    spin_lock(&arm_smmu_devices_lock);
>>>>>        master = find_smmu_master(smmu, dev_node);
>>>>>        if (master) {
>>>>>            dev_err(dev,
>>>>>                "rejecting multiple registrations for master device %s\n",
>>>>>                dev_node->name);
>>>>> -        return -EBUSY;
>>>>> +        ret = -EBUSY;
>>>>> +        goto out_unlock;
>>>>>        }
>>>>>        master = devm_kzalloc(dev, sizeof(*master), GFP_KERNEL);
>>>>> -    if (!master)
>>>>> -        return -ENOMEM;
>>>>> +    if (!master) {
>>>>> +        ret = -ENOMEM;
>>>>> +        goto out_unlock;
>>>>> +    }
>>>>>        master->of_node = dev_node;
>>>>>        /* Xen: Let Xen know that the device is protected by an SMMU */
>>>>> @@ -846,11 +850,17 @@ static int arm_smmu_dt_add_device_legacy(struct arm_smmu_device *smmu,
>>>>>                dev_err(dev,
>>>>>                    "stream ID for master device %s greater than maximum allowed (%d)\n",
>>>>>                    dev_node->name, smmu->num_mapping_groups);
>>>>> -            return -ERANGE;
>>>>> +            ret = -ERANGE;
>>>>> +            goto out_unlock;
>>>>>            }
>>>>>            master->cfg.smendx[i] = INVALID_SMENDX;
>>>>>        }
>>>>> -    return insert_smmu_master(smmu, master);
>>>>> +
>>>>> +    ret = insert_smmu_master(smmu, master);
>>>>> +
>>>>> +out_unlock:
>>>>> +    spin_unlock(&arm_smmu_devices_lock);
>>>>
>>>> Please add a newline here.
>>>>
>> Ok.
>>
>>>>> +    return ret;
>>>>>    }
>>>>>    static int register_smmu_master(struct arm_smmu_device *smmu,
>>>>> @@ -2056,7 +2066,10 @@ static int arm_smmu_add_device(struct device *dev)
>>>>>        } else {
>>>>>            struct arm_smmu_master *master;
>>>>> +        spin_lock(&arm_smmu_devices_lock);
>>>>>            master = find_smmu_master(smmu, dev->of_node);
>>>>> +        spin_unlock(&arm_smmu_devices_lock);
>>>>
>>>> At the moment, unlocking here is fine because we don't remove the device. However, there are a series to supporting removing a device (see [1]). So I think it would be preferable to unlock after the last use of 'cfg'.
>>>>
>> Ok. I will move unlocking to the end of this else {} block. I was not aware of the patch you are referring to.
> 
> I think the end of the else is still too early. This needs to at least be past iommu_group_set_iommudata() because we store cfg.
> 
> Potentially, the lock wants to also englobe arm_smmu_master_alloc_smes(). So I am wondering whether it would be simpler to hold the lock for the whole duration of arm_smmu_add_device() (I can see value when we will want to interlock with the remove code).
> 
>>
>>>> Looking at the code, I also noticed that the error path is not correct for at least the PCI device and we would leak memory. We also assume that Stream ID == Requester ID. Are both of them in your radar for PCI passthrough?
>>>>
>> I agree with you. I also noticed it. However this is going to be fixed with the next patch series when Rahul gets back.
> 
> Good. Do you have a todo list for PCI passthrough that can be shared?
> 
As I am not working on the PCI stuff, I do not have such a list but I can point you to the branch on which both ARM and EPAM are working:
https://gitlab.com/xen-project/fusa/xen-integration/-/tree/integration/pci-passthrough

> Cheers,
> 

Cheers,
Michal


From xen-devel-bounces@lists.xenproject.org Thu Oct 28 12:12:18 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Oct 2021 12:12:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217960.378201 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg4GP-0002m7-GB; Thu, 28 Oct 2021 12:12:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217960.378201; Thu, 28 Oct 2021 12:12:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg4GP-0002m0-Cz; Thu, 28 Oct 2021 12:12:09 +0000
Received: by outflank-mailman (input) for mailman id 217960;
 Thu, 28 Oct 2021 12:12:08 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=dsiD=PQ=oracle.com=boris.ostrovsky@srs-us1.protection.inumbo.net>)
 id 1mg4GO-0002ls-Jl
 for xen-devel@lists.xenproject.org; Thu, 28 Oct 2021 12:12:08 +0000
Received: from mx0a-00069f02.pphosted.com (unknown [205.220.165.32])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id e4b335d9-6488-40e5-9ac1-c14e431a9521;
 Thu, 28 Oct 2021 12:12:06 +0000 (UTC)
Received: from pps.filterd (m0246627.ppops.net [127.0.0.1])
 by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 19SC1lDT027005; 
 Thu, 28 Oct 2021 12:11:59 GMT
Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79])
 by mx0b-00069f02.pphosted.com with ESMTP id 3byedajse1-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Thu, 28 Oct 2021 12:11:56 +0000
Received: from pps.filterd (userp3020.oracle.com [127.0.0.1])
 by userp3020.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 19SC04fV073886;
 Thu, 28 Oct 2021 12:11:55 GMT
Received: from nam10-dm6-obe.outbound.protection.outlook.com
 (mail-dm6nam10lp2101.outbound.protection.outlook.com [104.47.58.101])
 by userp3020.oracle.com with ESMTP id 3bx4gsng66-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Thu, 28 Oct 2021 12:11:54 +0000
Received: from BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10)
 by MN2PR10MB4255.namprd10.prod.outlook.com (2603:10b6:208:1d2::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.18; Thu, 28 Oct
 2021 12:11:52 +0000
Received: from BLAPR10MB5009.namprd10.prod.outlook.com
 ([fe80::3c49:46aa:83e1:a329]) by BLAPR10MB5009.namprd10.prod.outlook.com
 ([fe80::3c49:46aa:83e1:a329%6]) with mapi id 15.20.4649.015; Thu, 28 Oct 2021
 12:11:51 +0000
Received: from [10.74.110.188] (138.3.200.60) by
 SJ0PR03CA0204.namprd03.prod.outlook.com (2603:10b6:a03:2ef::29) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.14 via Frontend
 Transport; Thu, 28 Oct 2021 12:11:48 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e4b335d9-6488-40e5-9ac1-c14e431a9521
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date :
 subject : from : to : cc : references : in-reply-to : content-type :
 content-transfer-encoding : mime-version; s=corp-2021-07-09;
 bh=wP+ghV8psSDE7JiAbtNWhkDPkpAJ51NPcm+xjXzme74=;
 b=g3wikDzDlANve7TOzcdyZ5dFtUc/sUeHA0vG2ds5QfJL3bj7lQPSxOiq3ui8dyW7Fl5/
 SLwa7BAAD6w+tvpfRCYb9TBuCyGNCc4q13IpLCDmMcqwQ6gNmbpVYEjrdgMU4F4Zp3Bg
 LFWrmm/XBvpMlhekQ+n2vdFlgX8GPXRcdBOgNxB2uDOhil9KOVg9cDNconFtZV6uOlZZ
 gyXnUaM3rr9AzbARTraLmd9OnSHsJwMzMis4e8YbxxcHw36sqlT3atl35zElhd1xwE5Y
 6OTubdxb6uBDUsWqSQueg22X8DAtel1vcsIe/tHcDjIlEtJ9+L9dwnQMreV73FlsaLu2 qA== 
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=iRp7qr62M7tlDbfsPDUv+s61PnVZtcTuO3p9a+jcvQfGAOI3CI7T1y21cWDujp91Dil2tT80K5Lg1K5swAWHmXiDwUpzY8yaMTnaNH+hBhlAPSJqtvRQMiuvS2Ff05L+mrEbKShUJuENZUqSvYLiesTrRC22Mitu7g+Dgo+S8+F2erGyL0eQW2Rx4jcuvQr/IkgWIku4RUKJQPJZjHdiikYmKYv5MH46e//4791btl/6kTIWhRlSt6o6v8fxQ5LX1tBUssDztwqX/CpZkAYPBIspr1ye8ftQqH0LnYA95O6UBQi8hhqdaR73JMe/wbwe//+W5NnrDyL3mQTG7kmh8g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=wP+ghV8psSDE7JiAbtNWhkDPkpAJ51NPcm+xjXzme74=;
 b=Lzhy4Uxj+f80E8DxJmscTO31uKosLKeHLgisqc+GdqyJmE5tRmWp0UyoCwtjI1zbzSYuRwNlpCOCQj0vU8TWk6Gy5A/lIWtgX1i6SVfekYYX1WMhwR0BE8jmxu5mjKo8LZ53sYliEUJeB55JZMN8uv1nrO6XV0NP84IObyE853up4abiSsjvjzjMVRlmTqhnPwCjIBfRRyVl5pxnfnF7oC79XP4uvPdeUYTvBOpHHQ4a9XmN2xqAEme9fT74oDDslJkGy5PYdsgyimZ9QDMUJhgicQwqMmyPiogXVRyRTnYwWV9WpuVge5nsr7j4EjhHyHbKo15Oy2yJp/SOcE2gFQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com;
 dkim=pass header.d=oracle.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=wP+ghV8psSDE7JiAbtNWhkDPkpAJ51NPcm+xjXzme74=;
 b=g389OYwqRhdHWtkOfuoAILdni1i+dR4+a2mzc2KbQuDRkySnIkw/pVHrIc3qOZMpfD/TA51vv2J4RnelbTDgHJypx0w3T/cxLpmBw6hGBXqZa5mC65H3gpTUrPOIsHDAz3vmtsCe3SheI8o+0Zs0hKCWAZqLTwLTqR4Fat5tFIU=
Authentication-Results: suse.com; dkim=none (message not signed)
 header.d=none;suse.com; dmarc=none action=none header.from=oracle.com;
Message-ID: <8b60b1ce-b65c-6136-fffe-5c8a043b0ffe@oracle.com>
Date: Thu, 28 Oct 2021 08:11:45 -0400
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.2.1
Subject: Re: [PATCH] x86/pvh: add prototype for xen_pvh_init()
Content-Language: en-US
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: Juergen Gross <jgross@suse.com>, xen-devel@lists.xenproject.org,
        x86@kernel.org, linux-kernel@vger.kernel.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
        Borislav Petkov <bp@alien8.de>, "H. Peter Anvin" <hpa@zytor.com>,
        kernel test robot <lkp@intel.com>
References: <20211006061950.9227-1-jgross@suse.com>
 <5164486e-b6d5-035d-5eb6-ec03a04284d0@oracle.com>
In-Reply-To: <5164486e-b6d5-035d-5eb6-ec03a04284d0@oracle.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: SJ0PR03CA0204.namprd03.prod.outlook.com
 (2603:10b6:a03:2ef::29) To BLAPR10MB5009.namprd10.prod.outlook.com
 (2603:10b6:208:321::10)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: b516f82c-818c-4f85-10fc-08d99a0c1f76
X-MS-TrafficTypeDiagnostic: MN2PR10MB4255:
X-Microsoft-Antispam-PRVS: 
	<MN2PR10MB4255D32BC0236EA9CA3CA2028A869@MN2PR10MB4255.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:792;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 
	/4ZnXPhc1y0BsbCEMVUM8fR0r4kJvcAIp6UFw1na6KM69g7HLpMGVYbsP8lrTDXscqiPczCKqXKqhCyjKQs7RkNU3+umIq5He5GZxSPBbgQIzedgWqxOUjgrzjFteITxrG7BHvWaEAkAzhNoCrMXhUCb/OINeS62MnUDgeLOda9xG1YvgDc2G5MFqdHBnMTVhUFFrd6phR/3UUdk9Wl8wN8Gct5y4DHOI3X709z6MQncJrLJg/TUiyyun07QpvE9mcH4V6SNVIXJyI8s3BhpdMwcp1jS7C84hU8cEa4e1IlAX251z7B/K3h8/Ikitk53N6lXCrBa2adkTtHQHndeJCfgRIkkhmu70GSxcZFu2Kn3mtBZ3r7GWFIbEMlD9k5S+VnJlnIXM6GFVbdEyFxanYt79pYK84hsEhMsA4eHJdX9ALWCavj3URRymLKZNSv2d3SUwSX1fn8qC0QIH+m57OFt2Uh8n64jjwZq4T/EMWzFAYbSMqwWOdsds6pw5yGjz4I35GVTX+n6UDY7nZsIB0s2+LAmRrXPxHqg4B2HtPX58ycgzIZsvuQqINzGJxKkcyiPdRtmB0Vru8nQF77KgBO0FS8MmUE2Vxtj1DGQ09WhqRb7cXovlKfTzJug6Pp22S2jyvatDArUFCjKqIYBqWvg+utMw80PgYTU3zum+WYvymmdPFeJedhZDGQ3pWFJIFFPhbLO5wEy31cP2NErgJwWlvlyDPmxREkedMGo9bo=
X-Forefront-Antispam-Report: 
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB5009.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(316002)(31696002)(4744005)(16576012)(5660300002)(53546011)(2906002)(6666004)(36756003)(8936002)(7416002)(8676002)(86362001)(6486002)(54906003)(66946007)(66476007)(508600001)(44832011)(66556008)(2616005)(956004)(31686004)(4326008)(186003)(38100700002)(26005)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?cjVhV0QxQjBCUUdlZ1dWV0RYVWR4U2ppakxBUzlwWnlLaHJVZUp1amtKa2o5?=
 =?utf-8?B?enJKMDF0ajlMbVEwaGlKR0Q1WGhwc3FWZ09SV0JUNnd1Y1JxQmMzMjJOUDZl?=
 =?utf-8?B?SHMxUHROajA1NXdEdU12d2F0cWJreTRJVEU0VllhMTBpNThIeTNTNldmV2pF?=
 =?utf-8?B?eUJrZkUyTTlOaUt2R3BZcmxmSDh6bUVjUXFueWZxRHkxR1c0K29kMUxlRUJu?=
 =?utf-8?B?bC9WOU5jQmFjZkFHdlZ6UXRuWGdEU2JrUlVIMThBczc5ZmNSOUhMNnFMNHZn?=
 =?utf-8?B?R1NlOXJnakgzTS9xNXV1THQvNlJnU2dtVmhRdDlTUDVpRngyb204L0lKOTVn?=
 =?utf-8?B?d1BzNTVCeUtheXkvQjFsNGMvR1BqTVowV1FjUWJsbXlnRzhBY2lEZnU5bUFI?=
 =?utf-8?B?dlBIWXJiRnpZOHRWa3hybTdJa1FzZDNmRTVBVmFYWGJDYzdZWWt4WnZDM25U?=
 =?utf-8?B?M0xTMUhVRktwRUplQys1ZmZySkgwd0NvNDRJR2N0cTg2b3gxRnVCLzdGdVo0?=
 =?utf-8?B?bjdmSjIyM3d0YTFJb0tDeTYyVmZmeFZDQk9VWXZnRjVPRFFucFRCUnQxbUxR?=
 =?utf-8?B?YjJ3dWxoSXpxU0pWTGk4SkN2b3VMelZHNnhXZVYzWWJ1UkhreDdsWDNsbjd6?=
 =?utf-8?B?bnVuWEF3eXlhZ2dKdEJKQU9keE1wRnpIK25WRjRGNG1VMis4Y2tnRllKRFJN?=
 =?utf-8?B?WThVa2tZVzZseENNOFEyV2Rqb0dIWENYQ2ZVN2haQzhNM0pBV1REZTA1bzZ2?=
 =?utf-8?B?aTRZa1Y4QkFxNkxwL094eDlDNVBFM2RLaG1vemVmYjBsbE14MXRlTkFqRTVQ?=
 =?utf-8?B?cVl1YnAzd1RxMmJ5R0NlK0h5bnhKY1F1YStjMHV6K3kzM0lFUW10QWVUSCtG?=
 =?utf-8?B?MjJCMm5XRSs2U0d5dkwvT1FPKzg4Nnh3YXZYOU52Q0d0ZHp0ektzazZ6RlVY?=
 =?utf-8?B?VjdteHp5OHYranRyd1FWMUo4cHZOUTlsM05CTWI3dEU1VmFpTzRwT2x1cHRa?=
 =?utf-8?B?L0llVzdaL3RXYU93NWk2SXFOU2pNN0pvK0ZvdElxVlFqNmsvTU1tZThweVM4?=
 =?utf-8?B?ZHlYcnFjUDY4MjJqK29qVU5zVlppU2NJcTRGYTBoTStKeVdRQm5OUFlHSXZ5?=
 =?utf-8?B?TlZIV095N1VjUHVZM1BkaGJBSExzdmxMVUdFRUx6TDR4d3U4c1M3MUowaFIw?=
 =?utf-8?B?eGVObWl2T1FXb0xFdE8vNEtNYnZCZCsvWDkyblJKMG1nTDdOMFRnT3dHSEh4?=
 =?utf-8?B?TjBZaXVlVnB5K2RMOFd6Mk1mSXRPcUdFdDVMODZGeUJGTzJocDljNkhpR1V2?=
 =?utf-8?B?R1VCR2JHbjNtT0g4UW9DZmdWekpET0tPbnh5a3V3VkQ5cXF6d2pyLzNpYWhW?=
 =?utf-8?B?TkpNZXlRRTluZHA2K2dTV2p5b2pCTmdCM2cyNFlnYWJZMDB4V1I3UkNFRTky?=
 =?utf-8?B?MGRNWWw5NGI5dmxzcktTa1o2QzQzejcxVE9QY1czckk0NUZuYVMwMENESnpW?=
 =?utf-8?B?SFN0MURxYlZ0aXVsSkZPMS9HR1dWYWZQSThyRW1jNW1KSUZaajZOYmY5S3gz?=
 =?utf-8?B?UlRCRHdnQlhpSGpGdExuMDg3ZTdYS2NLaHBDMW9OMVdaRmhKR0dSMGFYOWJ5?=
 =?utf-8?B?eHA1UHkybFZoc3NhelB4aHZFaVhaekJZMnh6azhzdE9BQjE1VU8vWFNhYWNo?=
 =?utf-8?B?dlZKUVBORkY2VUwwVlRhWmpxa0szYTNjVHdYeGt0S0NFRG1PZjJVcm9USEpI?=
 =?utf-8?B?dlp0dHFreEp3U3NOMm1tWUhaTUJuMGd6Z1czbjJSVy8rcitvSjM1WGxiTTh3?=
 =?utf-8?B?ZkxSSHFUeHJ6ekRQWTNwMEViMTBJQW1Iais3WG9WM212TnZFMGJuK3NPSjgr?=
 =?utf-8?B?T2VEZVlxU1NWbFlZbjVTMXIrNzhHREZHY05ldFpydGc3bDA1WkRjSWYrS3ND?=
 =?utf-8?B?ekxWYXhkOVkyanlYcFN4bTBrR1NJdGNjK1Y3Y1NiTFI3TDNGU0FRUnNveUZB?=
 =?utf-8?B?bmJoNDNBN3FVU0VYWkhVWi9ScDZ4UHdvaTFuc3dTc2lTakZvUXpyRS81L3pE?=
 =?utf-8?B?OWpveUxhY3VUTHpCL0ZaTkJtVW5ORDFiWlF6akQvK2RYdzd4aThpOUYxVHhY?=
 =?utf-8?B?V3pKUGJSejNMeGJSWmE1TFVEL1hYcTZSWlQ4a2RHRUNBZFYyekllTlFOeTcx?=
 =?utf-8?B?ZFE0OVdGWm01VGJZQzJjbFpwY3FreDJ4MTRDa1ZRekh2WGRBMWEyMWZYMUlM?=
 =?utf-8?B?RHVxVnFpWk84elRsSDhveWpuT3R3PT0=?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b516f82c-818c-4f85-10fc-08d99a0c1f76
X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Oct 2021 12:11:51.0888
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: VgCJ4LTI2z5Fi/B5mdWri0GTqPmfydntsAggvjck5xmvEQBBL1yc8A7M6DOr5g02nq6BLjblT0xbOirnY97991ItbZA9pq9Z/17P65Si7B4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR10MB4255
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10150 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 malwarescore=0
 adultscore=0 suspectscore=0 bulkscore=0 mlxscore=0 spamscore=0
 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2110280066
X-Proofpoint-ORIG-GUID: Abo1nBc04FO2WEdmdM8RJg9wW9NfTYSs
X-Proofpoint-GUID: Abo1nBc04FO2WEdmdM8RJg9wW9NfTYSs


On 10/6/21 8:43 AM, Boris Ostrovsky wrote:
> On 10/6/21 2:19 AM, Juergen Gross wrote:
>> xen_pvh_init() is lacking a prototype in a header, add it.
>>
>> Reported-by: kernel test robot <lkp@intel.com>
>> Signed-off-by: Juergen Gross <jgross@suse.com>
>
>
> Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>


Applied to for-linus-5.16


-boris



From xen-devel-bounces@lists.xenproject.org Thu Oct 28 12:12:37 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Oct 2021 12:12:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217965.378212 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg4Gq-0003Ii-QD; Thu, 28 Oct 2021 12:12:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217965.378212; Thu, 28 Oct 2021 12:12:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg4Gq-0003Ia-Mp; Thu, 28 Oct 2021 12:12:36 +0000
Received: by outflank-mailman (input) for mailman id 217965;
 Thu, 28 Oct 2021 12:12:35 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mg4Gp-0003IL-Gb
 for xen-devel@lists.xenproject.org; Thu, 28 Oct 2021 12:12:35 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mg4Gp-0006uE-Fr
 for xen-devel@lists.xenproject.org; Thu, 28 Oct 2021 12:12:35 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mg4Gp-0006DE-Ew
 for xen-devel@lists.xenproject.org; Thu, 28 Oct 2021 12:12:35 +0000
Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89)
 (envelope-from <iwj@xenproject.org>)
 id 1mg4Gl-0001yM-N2; Thu, 28 Oct 2021 13:12:31 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date
	:Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From;
	bh=Rb+KJoJ7amVA/cjLy/03Mj3uIwAST5xsyioaPfq6ANM=; b=XDSL+F9h577av9x9Z4mx1MpQb3
	Xp0723e6Y1ZQdzGN80ZxbQzLzEJs7/5o3xSVMQlhoL3v70StW2KukeSnHw8Q4s+A4yB9HSGmzmZgI
	toWLY8JiBAC2Kzj5HpETwp0kD0NujBxb6LCvFd3DbLkqIu3D7CNl4prp8qV7CCvZMFY8=;
From: Ian Jackson <iwj@xenproject.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <24954.37807.277003.373593@mariner.uk.xensource.com>
Date: Thu, 28 Oct 2021 13:12:31 +0100
To: Roger Pau Monne <roger.pau@citrix.com>
Cc: <xen-devel@lists.xenproject.org>,
    Wei Liu <wl@xen.org>,
    Andrew  Cooper <andrew.cooper3@citrix.com>,
    George Dunlap <george.dunlap@citrix.com>,
    Jan Beulich <jbeulich@suse.com>,
    Julien Grall <julien@xen.org>,
    Stefano  Stabellini <sstabellini@kernel.org>,
    Anthony PERARD <anthony.perard@citrix.com>,
    Juergen Gross <jgross@suse.com>,
    Christian  Lindig <christian.lindig@citrix.com>,
    David Scott <dave@recoil.org>,
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH for-4.16 v3] gnttab: allow setting max version per-domain
In-Reply-To: <20211028095923.83982-1-roger.pau@citrix.com>
References: <20211028095923.83982-1-roger.pau@citrix.com>
X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu)

Roger Pau Monne writes ("[PATCH for-4.16 v3] gnttab: allow setting max version per-domain"):
> diff --git a/docs/man/xl.cfg.5.pod.in b/docs/man/xl.cfg.5.pod.in
> index 55c4881205..21a39adb70 100644
> --- a/docs/man/xl.cfg.5.pod.in
> +++ b/docs/man/xl.cfg.5.pod.in
> @@ -580,6 +580,12 @@ to have. This value controls how many pages of foreign domains can be accessed
>  via the grant mechanism by this domain. The default value is settable via
>  L<xl.conf(5)>.
>  
> +=item B<max_grant_version=NUMBER>
> +
> +Specify the maximum grant table version the domain is allowed to use. Current
> +supported versions are 1 and 2. The default value is settable via
> +L<xl.conf(5)>.


Firstly, review from my maintainer hat:

In the lower levels of this stack, I'm not sure why you chose -1 for
"default", when 0 is not (and never will be) used ?

> diff --git a/tools/helpers/init-xenstore-domain.c b/tools/helpers/init-xenstore-domain.c
> index 6836002f0b..7cd1aa8f7c 100644
> --- a/tools/helpers/init-xenstore-domain.c
> +++ b/tools/helpers/init-xenstore-domain.c
> @@ -88,6 +88,7 @@ static int build(xc_interface *xch)
>           */
>          .max_grant_frames = 4,
>          .max_maptrack_frames = 128,
> +        .grant_opts = 1,
>      };

I think this sets the max gnttab version for xenstore stub domains to
1 ?  That's not mentioned in your commit message or your release
discussion.


Secondly, the release question:

> Release rationale:
> 
> We have had a bunch of security issues involving grant table v2 (382,
> 379, 268, 255) which could have been avoided by limiting the grant
> table version available to guests. This can be currently done using a
> global host parameter, but it's certainly more helpful to be able to
> do it on a per domain basis from the toolstack.

Let me think this through.

Upside:

So the advantage is to have a mitigation for possible (but, perhaps,
likely) future security bugs.  We don't change the default here, so
the default configuration is still vulnerable.

We have this mitigation already but only on a per-host command line
basis, so you (1) have to reboot (2) can't use it if you have any
guests that need v2.  (2) is less of a problem than it sounds because
even with the selective mitigation you will remain vulnerable to those
guests.  So the main advantage is having to reboot the guests but not
the hosts.

Downside:

> Changes to the hypervisor by this patch are fairly minimal, as there
> are already checks for the max grant table version allowed, so the
> main change there is moving the max grant table version limit inside
> the domain struct and plumbing it through the toolstrack.

Right.

> I think the risk here is quite low for libxl/xl, because it's
> extensively tested by osstest, so the main risk would be breaking the
> Ocaml stubs, which could go unnoticed as those are not actually tested
> by osstest.

I will want a review by ocaml folks.  Christian ?

In particular, I would like an opinion from the ocaml tooling
maintainers about whether there is a risk of this feature breaking
things *if it's not used*.


I am not sure about the implications for migration.  Might using this
cause migration to fail for some guests ?

   Note that when using the default grant version the specific max
   version in use by the domain is not migrated. Any guests should be
   able to cope with the max grant version changing across migrations,
   and if a specific guest relies on a maximum grant version being
   unconditionally available it should be specified on the configuration
   file.

Only if the feature is *not* used, I guess.  Ie, this is the status
quo.   So I don't think there is any release risk there.


If this change does cause problems, it is deep throughout the stack,
but not entangled with anything else, so I think we could revert it ?


If we can get good answers to all of this, ideally I would like to see
this committed by the end of tomorrow.  I plan to cut RC1 on Monday.

I don't currently want to rule out allowing this to go in early next
week but that is getting considerably less desirable.


Thanks,
Ian.


From xen-devel-bounces@lists.xenproject.org Thu Oct 28 12:13:51 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Oct 2021 12:13:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217971.378223 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg4Ht-0003xF-4f; Thu, 28 Oct 2021 12:13:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217971.378223; Thu, 28 Oct 2021 12:13:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg4Ht-0003x8-1W; Thu, 28 Oct 2021 12:13:41 +0000
Received: by outflank-mailman (input) for mailman id 217971;
 Thu, 28 Oct 2021 12:13:39 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mg4Hr-0003wn-L9; Thu, 28 Oct 2021 12:13:39 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mg4Hr-0006vo-GQ; Thu, 28 Oct 2021 12:13:39 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mg4Hr-000580-49; Thu, 28 Oct 2021 12:13:39 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mg4Hr-0001a1-3f; Thu, 28 Oct 2021 12:13:39 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=zoQ+XSBEOCKNPzZeRBJGTiXF3pu6aB+45RBphuQFo4A=; b=vDhimAD03mW8YrTpq7dY1+gtsI
	cblL2DFVlZpw1ZkH86Uoj9CL5c22V+eHa3/+Py0RBD6VcmW8Jfbvg4B4Vc0NDAsHv6gvPEHTThBsy
	XZ9EdXCY/XvbYNKRiwwqKmleN6NE01PYxDShMPHM+0+CkeOZiXwf6kxZlTmEERRi2XvE=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165919-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 165919: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-unstable:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=c91c967f329f866b1826b04e73e32aea936930cd
X-Osstest-Versions-That:
    xen=b0fce57a6a491c120f2554ad7cc9a0c43ee5defa
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 28 Oct 2021 12:13:39 +0000

flight 165919 xen-unstable real [real]
flight 165923 xen-unstable real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/165919/
http://logs.test-lab.xenproject.org/osstest/logs/165923/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 165923-retest

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 165887
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 165887
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165887
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165887
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 165887
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 165887
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 165887
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 165887
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 165887
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 165887
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 165887
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165887
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 xen                  c91c967f329f866b1826b04e73e32aea936930cd
baseline version:
 xen                  b0fce57a6a491c120f2554ad7cc9a0c43ee5defa

Last test of basis   165887  2021-10-27 01:52:47 Z    1 days
Testing same since   165919  2021-10-27 21:07:55 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Roger Pau Monne <roger.pau@citrix.com>
  Roger Pau Monné <roger.pau@citrix.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 fail    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   b0fce57a6a..c91c967f32  c91c967f329f866b1826b04e73e32aea936930cd -> master


From xen-devel-bounces@lists.xenproject.org Thu Oct 28 12:15:36 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Oct 2021 12:15:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217981.378237 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg4JZ-0004i8-O3; Thu, 28 Oct 2021 12:15:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217981.378237; Thu, 28 Oct 2021 12:15:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg4JZ-0004i1-Jf; Thu, 28 Oct 2021 12:15:25 +0000
Received: by outflank-mailman (input) for mailman id 217981;
 Thu, 28 Oct 2021 12:15:24 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=w4/Z=PQ=citrix.com=Andrew.Cooper3@srs-us1.protection.inumbo.net>)
 id 1mg4JY-0004h1-A1
 for xen-devel@lists.xenproject.org; Thu, 28 Oct 2021 12:15:24 +0000
Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id b907f645-37e8-11ec-849e-12813bfff9fa;
 Thu, 28 Oct 2021 12:15:22 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b907f645-37e8-11ec-849e-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1635423322;
  h=to:cc:references:from:subject:message-id:date:
   in-reply-to:content-transfer-encoding:mime-version;
  bh=wo3lZqbfES5TyRviIoqJ3nRNqzln6OQQuxUlfM6B6OE=;
  b=AtgzeQVWZNaQAVomFBrHQ0G8AK6RpdPmHggO+5HMbCvNS/0okzj86tv/
   rvCJYkbkruCPWTu+F5sqD9UuFez773Ld003W1c6mKiamf+CK3DtG5paCz
   QxUhk/le3j9jGDXL1evri+XImUpDk+Hq82hnbAYGZD9q3FtADRXpMFxIM
   8=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: 4Fuqpa7iZ9W9k1Q1kd/LsSTcO9O22zglR7w0PNQcxbG5VJSCeULjEer2u4HXwEeKmuUwwHuoBs
 rExq21cQOdI8rc3GU/egxMlgk0/KxVgUZ+4PMIDQ1xj3D+pgCrWdnqILbyz605oR16qHKmaSeu
 pOONfDPIk6iejv3kM5cLWKse3yWj1dT5jc6pBwCps+s2QTHyv4JKMHMRz1i5CSv32fgTJGEe3h
 oOqk/fB7ZNeHBits6bicK0FCYCnRM1/WTPbfmQCaIaCCnPRUkSs76N/ZZo+H4tZerbIMTfrhJ/
 Of3/0UYmnDAhMRR0wyMmx258
X-SBRS: 5.1
X-MesageID: 56532491
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:LmO7Fa/wcnLLZzK2ix5gDrUDfXmTJUtcMsCJ2f8bNWPcYEJGY0x3n
 WQdWzqHM6nfajagf49xaNi+/EMBu8KAxtU3SQNppS48E34SpcT7XtnIdU2Y0wF+jyHgoOCLy
 +1EN7Es+ehtFie0Si9AttENlFEkvU2ybuOU5NXsZ2YhGmeIdA970Ug6wrZj0tYx6TSEK1jlV
 e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH
 I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPhoy
 ecUpbicSD0AJ5/ptvYTcyNcDjFXaPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us
 6ZCcXZUM07F17neLLGTE4GAguwKKsXxMZxZkXZn1TzDVt4tQIzZQrWM7thdtNs1rp0QQK2EO
 5tAAdZpRBqZODFtJWpOMskVhtzvwXPvVgVS9E3A8MLb5ECMlVcsgdABKuH9WPaHWMFUlUawv
 X/d8iLyBRRyHMySz3+J/2yhgsfLnDjnQ8QCGbug7PlojVaPgGsJB3U+VES5iem0jFakXNBSI
 FBS/TAhxYAt8GS7Q9+7WAe3yENopTZFBYAWSbdjrljQlOyEuG51G1ToUBZYae5/pOsaRAYDz
 22sscHnJQZrra28HCf1GqivkRu+Pi0cLGknbCACTBcY79SLnLzfni4jXf44T/br1oyd9SXYh
 mnQ9nBn1up7Ydsjjv3jpTj6bySQSo8lp+Lfzj7cWX659UtHbYqhap3ABbPzvKsYctjxorVsu
 hE5dymiAAImUc7leM+lGrxl8FSVCxCta2S0bblHRMBJythV0yT/Fb28GRknTKuTDu4KeCXyf
 GjYsh5L6ZlYMROCNPEsPtnvU55xk/mwSbwJs8w4iPIVO/CdkyfcpUlTibO4hTixwCDAb4lmY
 f93jvpA/V5FUP86nVJats8W0KMxxzBW+I8gbcuT8vhT6pLHPCT9Ye5caDOmN7llhIvZ8FS92
 4sObKOilkQAONASlwGKqOb/23hRdiNlbX03wuQKHtO+zv1OQzB8VaWJm+p9K+SIXc19z4/1w
 510YWcBoHLXjnzbMwSaLHdlbbLkR5FkqnwneycrOD6VN7ILO+5DNY8TKMk6e6cJ7utmwaImR
 vUJYZzYUP9OVi7G63IWapyk9N5ucxGihASvOSu5YWdgI848FlKRotK0LBHy8CQuDzassZdsq
 bOXyQ6GE4EIQB5vDZiKZav3nU+xp3UUhMl7Q1DMfotIYEzp/YUzc37xg/Y7LtsiMxLGwjfGh
 Q+aDQ1B/bvGopMv8cmPjqeB9t/7H+x7F0tcPm/a8bfpanWKojv9mddNCb/acyrcWWX4/LSZS
 d9Ul/ysYucamFtqspZnF+o5x6wJ+Nay9aRRyR5pHSuXYg3zWK9gOHSPweJGqrZJmu1CoQKzV
 0+CpotaNLGONJ+3GVIdPlN4POGK1PVSkTjO9/UlZk794XYvrraAVExTOTiKiTBcc+QpYN90n
 795tZ5E8RG7hzorLs2C33Jd+Gm7J3AdV7kq68MBC4jxhwt3klxPbPQw0MMtDE1jvzmUDnQXH
 w==
IronPort-HdrOrdr: A9a23:YABEYakJiUJJF9jZ2bSt3JhYSXXpDfO8imdD5ihNYBxZY6Wkfp
 +V88jzhCWZtN9OYhwdcLC7WZVpQRvnhPtICPoqTMiftW7dyReVxeBZnPbfKljbdREWmdQtrZ
 uIH5IOb+EYSGIK9/oSgzPIY+rIouP3iZxA7N22pxwGLXAIGtJdBkVCe2Km+yVNNXh77PECZf
 yhD6R81lidkDgsH7+G7i5vZZm8mzSHruOqXTc2QzocrCWehzKh77D3VzCewxclSjtKhZMv63
 LMnQDV7riq96jT8G6S60bjq7Bt3PfxwNpKA8KBzuATNzXXkw6tIKBsQaeLsjwZqPymrHwqjN
 7PiRE9ONkb0QKcQkiF5T/WnyXw2jcn7HHvjXeenHvYuMT8AAk3DsJQ7LgpOifx2g4FhpVRwa
 hL12WWu958FhXbhhnw4NDOSlVDile0iWBKq59Ss1VvFa8lLJNBp40W+01YVL0aGjjh1YwhGO
 5ySOnB+fdtd0+AZXyxhBgv/DWVZAVwIv66eDlGhiTMuAIm2EyRjnFoivD3p01wt67UEPJ/lq
 P52qcBrsAGciZZV9M6OA47e7rDNoX6e2O7DIujGyWUKEg5AQO4l3fW2sR/2Aj4Qu1D8HMN8K
 6xJ2+w81RCIn7TNQ==
X-IronPort-AV: E=Sophos;i="5.87,189,1631592000"; 
   d="scan'208";a="56532491"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=H/fJ45rur22KrHXaUIVbmesWJBOKha/wpD9rkuGVdmKT8JgEnb3OqvdiunZMmD/hUiptd+SKlg8/fb18hGwiudorKj/sNi4r0+ggGIxqoTmVAkzhhyE8ye0/AwBLB0CMvmNaz1SY6BXNQeJJ1yospViicNLeKvBvvDT/pCfvVu8Isw2p4iwDmmwM6iX6Dcq5Sp/5Jzq4QHhNeqsdBcT2QWGZjJ1WXxUkUXKAfoYu97dkYSRFEiQx2TS7yOeCA+ZKbYMLTADcLZxUY3pHk7LefOJR3VAvpjByF7H+xv+SwSivQAPmceKuIRsQPgKP/QxEvQUwvD+nMgW5H8wDIG2vyw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=4v16CIS+WGRPeYy/jCskGG6tDbOi3oFXX1GfOs71dYM=;
 b=Qk9NWUudZrLL5h7FT9pRvnJEa4AcTImicP+U0i7xDZ8e9M8OoBcoYRfl9gTqhL7LCUsW8GfkpGpl1RwRvhXbXuNB87h+pT6il4u582ZvvTJWuLntezp5wqsEJJtyd7WgBypVyYeCmDnZcAKX4pulw4393JRv5X1UhgFQhqNRK6LKO+hS2GsRe78OiUNnCHX6V1aHEPVphNmeMqNXIdGsWTsr9KtzN+Z013MbnIGiiDsCl68Nv7uDX3AGvhZozAV/nViqzGR93fgXHd8nxczpCQMGfdVHGVWmV1olY3gCmiJHIuZOzYJdbXyfJ1gA74HpcXzkB/F79Fs2awHTDTSUGQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=4v16CIS+WGRPeYy/jCskGG6tDbOi3oFXX1GfOs71dYM=;
 b=qwNyHypgvu8Fvzw+X+//0nzg4b3oAKGtfj3RoYYF6iM8vbqDtHzC3jCissj1Md4WIeCKBPCBZp01AYMySgWXj/CZxt5t0WK0FbKY0YpuhNGIjzCr2JRG6sB+6SbLFlNqFZgvIxBV0bES8SeocgZQsRovCeE4nIRBlbqKvvTIL1c=
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>, Jan Beulich
	<JBeulich@suse.com>, Wei Liu <wl@xen.org>, Ian Jackson <iwj@xenproject.org>
References: <20211027200713.22625-1-andrew.cooper3@citrix.com>
 <YXpRzHEawUZEU87h@Air-de-Roger>
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH] x86/passthrough: Fix hvm_gsi_eoi() build with GCC 12
Message-ID: <64788530-a18c-332f-c287-84478a200816@citrix.com>
Date: Thu, 28 Oct 2021 13:15:13 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <YXpRzHEawUZEU87h@Air-de-Roger>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Content-Language: en-GB
X-ClientProxiedBy: LO2P265CA0149.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:9::17) To BYAPR03MB3623.namprd03.prod.outlook.com
 (2603:10b6:a02:aa::12)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 32eaa458-0f5a-4b5d-1f80-08d99a0c9bce
X-MS-TrafficTypeDiagnostic: BYAPR03MB4615:
X-Microsoft-Antispam-PRVS: <BYAPR03MB4615B808B6560A0540B32CFBBA869@BYAPR03MB4615.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: chi8N01ZnJLFGXWVQT1LE/Z+rcx4YwCa1gVpohx75vHmGiRkOhbJFw6n9qeIhG4Q6vwMoyLZRPKx9pJULhz2E/OWvZC6VOyTqs1t6Ia3vBY1u5G5BCr2V3JBIShdL8Cb3PgjEskPgbBRxlCsuD/8PONKURSF1PX/b/K2LDBcKUwLSXSOheMeswmqBQ0KPofSyCUOhy2OU1IClM8f9BEjsaJNCIIl6iCg2ADhyVW2+YxqYSoNwVK3A5q6VjRfGV9SZlN08nkNWXy65zFc8lR5u/CYD/i1UUfdikg/SOp10r3tPbWCnZTrQUs6PkunPgngKH96EFJl9/VQgn6WX4Oxi4hvGxCwLYVDfjhav3mupoXdUgdu8v2jOm4wAAtQA13tMSljVSfxgflE9DMFmoPHCp/yjH+SA8mHDVD/3FBAHMhhqA8r/bjn9cOSlpM24YivGUMFozsDqFCMaCYtOM/HH9Q8Pd0ShOyiCpoJtolmviTbD50NGyCzNlVRDv8F6wiXNIP8brNs94hb/5ROFHj7MwYVp6k1zShOUyEqXVbh/hlBDeqisAY2ZjVYyzlylrLblR8IoZPR4V2iv8fHIdzcN45adag9zzBdN7y/4HRJ/vc7xJTtxyXtnW4tfz79nm6hMyBiEze4b1K2Ml9OYTHOraDX4jZ+vKIQYHueo08LRpZWqUU0pM3bUBv81YZ7naQj2rg2F+h5QjGGGqT8XrrivVn5gxR7oI04BiRYz98zTIfZ9ToE76dTzyUB3k4VveQs
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(8936002)(508600001)(186003)(66476007)(16576012)(37006003)(316002)(8676002)(82960400001)(36756003)(54906003)(26005)(956004)(6636002)(66946007)(86362001)(6666004)(2616005)(66556008)(4326008)(38100700002)(2906002)(31686004)(6486002)(5660300002)(31696002)(6862004)(53546011)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OVdnWjVYNmpDVVJaeE1UYVVpTWpVWmtQTW9maEx0OEprRStVRDFhTDB2dDlI?=
 =?utf-8?B?a3QzQTRiazJ6eE5lNDZ1ZlcrTFdBSHlHbFFEamh4UE5XSVR5dlNlNk95QnFV?=
 =?utf-8?B?aXJ1blVLUUlnaWgvcHR4emVVdEM5K1N0SHoydng0WDhISzFpOFEwZ1lUankz?=
 =?utf-8?B?c2pmdkF6ekM0WDBQc1ZDSkZpanBodHlPQjBKS2lvVEtQZGFqS21RYnZiUkZo?=
 =?utf-8?B?R2F5VDFGTml0dklxVWt2QTh6Sjd1REplNFNNQVF4Y0UrM2VVMmt0amN5bXJF?=
 =?utf-8?B?TzhyTVVlRlJCYnR2Vm90MnJCM3gyWGRTdjhoUmViY1ROWWVjcGJTUi9WYnFH?=
 =?utf-8?B?a2RIYnpXU2NMU3FLcytBK1lkM0NVdUJRWEtZNXVMZktoTHR0S0hPanQ2ZXln?=
 =?utf-8?B?YVluNXdOZm9BWmpNdUFUemh3a29mZGFOcTVuQjJVamVrcXBtQjQ0ZXJPKysy?=
 =?utf-8?B?a0MrV2tFT2IwcTRTRmZ1bDFzUG82UjliK0czbXNNTEw4S2hrWURoTzJZVTVo?=
 =?utf-8?B?ZFhDREIwKy9FdzA3Q09LeGxFU0FjaGRjNGJOY2R5SWsvU3ZRSFVGNTBhb2FV?=
 =?utf-8?B?ZjVERHFLTmRLWlE0amJSS1htbVc2ck1jVjZPajNFTktxOXlaUjFlZnp2Z3l0?=
 =?utf-8?B?S2JpZGJRTzFuQUJlZmIwdTg2bm4yMlJUeDVzWVUzTG9QZUhjdFRQdnphY3Q0?=
 =?utf-8?B?ZlNOL2FBOHFlZy8vRC8wNkFTMkZYMnA2UGp1UTRHMHlrekJpSDZRczJmS1la?=
 =?utf-8?B?anA5Vzc3bUxJN3dnQlhIOFZlRW13VzVaOUpHNDRIak5vQnJvTXVjcmY2em1F?=
 =?utf-8?B?WTd1dHY1Wkt1Um1BT1J4M0FpbzhJaVQ4Z1ZRR3hBZXp0dllEK1dHSW5rdFRG?=
 =?utf-8?B?bGh2MEFxODFnbUplYWJsdHNLYnd2OHBibTE5T3d5OXYrd0lGdkVMWWlWRDZp?=
 =?utf-8?B?ekZ3dTlLZmVqQk9UNmRvZzY1UGVOZzE4d1U0MFJzTUw0dWYxRHE1eVBkd29O?=
 =?utf-8?B?MnJ4dmpCSUd6WGtMNVVQZm1BNjNJRTROYTJyRU9TNks0eFc1RDhzYjFIZTAy?=
 =?utf-8?B?RUdmenVET0JjWklIRlpNdXRSWksrbmVENjRsYlFzcDYyZEdVL0wzeWFJWmdJ?=
 =?utf-8?B?RllZL1RXNkFzVUN5WW1MSEZoM3NJRXJjb1NtWDFlMWQ1MHBld1p2bWxsNGc0?=
 =?utf-8?B?WTNLNWcwUEM1aVY5K1pIMkl0Y1NMRGpjanAraDJlWmRieXFqZUgyNElrVTcz?=
 =?utf-8?B?U0ZoaFBhZmo2MGlDc0xHN2hJVXMxT2ZDZmxadUxFVGV1dEtkMkZBSWhWU3Vw?=
 =?utf-8?B?dVdPYlhjN0s1bFB6UEU3TDBRcllRNlFDTFZrZ1JsNENBcU43UlN5ZEVJVVpp?=
 =?utf-8?B?Nm5Ba3Z6NUc1bjJhOTNTSU14eDV2bzE3T0VxbTdmV1NQdnp4WHlCMFhTOHpl?=
 =?utf-8?B?T1NJWkdyTGZqY0NVZXBJcGFZZi8zY2MzTldPM0tERllMZTJzU2ZWOGlqQzVp?=
 =?utf-8?B?N0xsclpKd0Vla0hDY0QramsxN1cxaHlkVzVFaTBNSThpendLL0xSNUVtbzBt?=
 =?utf-8?B?WHNJTVhrSjlhaEFSMllGWmJjakVIcnJiWXVsbkVIOGlqTHBZc09SRFBFN0F0?=
 =?utf-8?B?OXpHT1ArUHVZK0xiaC96bCtCNFJFbWphUXZaQXJCTmpYS2NPOFR3YnZTK1du?=
 =?utf-8?B?SUNva1B6Zmx0K3Y1d0gvRXpHOEtrZWhFL2xFNmFBSmRkbUxqUE05T2xsc2Ry?=
 =?utf-8?B?UFZOUEhab1dHR0swM3J0TnBvQXFwODNhRzNaOFdEcmF6V0VzbHhRVUVjQW1v?=
 =?utf-8?B?VkQ4T2lGT21YNDR5SlgveXFjVGFOT2lvcVJxM2RGMjY4SkJMelNpbFoyWFd2?=
 =?utf-8?B?WlZMY2p6M3Vjb3VUUURCNXNyN0N1Nk1ib3Y4RHUrUmZidTdEZmVCUFBxSHRR?=
 =?utf-8?B?TFhFSlloU3psWDhtNTBCV0ZrdDdyVHk3K1BZeGxLa1RnR1o1MStVVmNaMmtl?=
 =?utf-8?B?OGptandSbmp0a2w0TmZBaHdRck1ENEZ3V0NwTGdlTkswaTdxVDJUalNudGpy?=
 =?utf-8?B?ZUc4Ylg0MFVSWVBiU1p2NDhPNDdxMU03TzF6Q0tvQVNiazEzbyswZWxvTzVh?=
 =?utf-8?B?OENyanJLVkdsazhJNFJPcmFjYy82N25jNVBzT0hnUEk1ZHZ6bFA4My8wNHFS?=
 =?utf-8?B?bUFQT0ExUUFJZ0c1ZSs0aFZBSzNzbkdzS095RDhDR2djS29jVWdoYVZYUWEx?=
 =?utf-8?B?U3hXN2ZUMU1Dc1FESmpzaGxqTllnPT0=?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 32eaa458-0f5a-4b5d-1f80-08d99a0c9bce
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Oct 2021 12:15:19.6186
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6VH/beKBmPMU8e6a1MFlXt3rN1pZPDDyDlANROfJnXEVJOMf6KGXZBSUfc1Ujfa4viBcEqOzjpUsX4fu44ueb8Ht8OeDqSU5WRboUnSf2pg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB4615
X-OriginatorOrg: citrix.com

On 28/10/2021 08:31, Roger Pau Monn=C3=A9 wrote:
> On Wed, Oct 27, 2021 at 09:07:13PM +0100, Andrew Cooper wrote:
>> GCC master (nearly version 12) complains:
>>
>>   hvm.c: In function 'hvm_gsi_eoi':
>>   hvm.c:905:10: error: the comparison will always evaluate as 'true' for=
 the
>>   address of 'dpci' will never be NULL [-Werror=3Daddress]
>>     905 |     if ( !pirq_dpci(pirq) )
>>         |          ^
>>   In file included from /local/xen.git/xen/include/xen/irq.h:73,
>>                    from /local/xen.git/xen/include/xen/pci.h:13,
>>                    from /local/xen.git/xen/include/asm/hvm/io.h:22,
>>                    from /local/xen.git/xen/include/asm/hvm/domain.h:27,
>>                    from /local/xen.git/xen/include/asm/domain.h:7,
>>                    from /local/xen.git/xen/include/xen/domain.h:8,
>>                    from /local/xen.git/xen/include/xen/sched.h:11,
>>                    from /local/xen.git/xen/include/xen/event.h:12,
>>                    from hvm.c:20:
>>   /local/xen.git/xen/include/asm/irq.h:140:34: note: 'dpci' declared her=
e
>>     140 |             struct hvm_pirq_dpci dpci;
>>         |                                  ^~~~
>>
>> The location marker is unhelpfully positioned and upstream may get aroun=
d to
>> fixing it.  The complaint is intended to be:
>>
>>   if ( !((pirq) ? &(pirq)->arch.hvm.dpci : NULL) )
>>                   ^~~~~~~~~~~~~~~~~~~~~~
>>
>> which is a hint that the code is should be simplified to just:
>>
>>   if ( !pirq )
> I likely need more coffee, but doesn't this exploit how the macro
> (pirq_dpci) is currently coded?

The way pirq_dpci() is currently coded, this is nonsense, which GCC is
now highlighting.

It would be a very different thing if the logic said:

struct pirq *pirq =3D pirq_info(d, gsi);
struct hvm_pirq_dpci *dpci =3D pirq_dpci(pirq);

/* Check if GSI is actually mapped. */
if ( !dpci )
=C2=A0=C2=A0=C2=A0 return;

but it doesn't. Getting a non-null pirq pointer from pirq_info(d, gsi)
does identify that the GSI is mapped, and the dpci nested structure is
not used in this function.=C2=A0 I would expect this property to remain tru=
e
even if we alter the data layout.

~Andrew



From xen-devel-bounces@lists.xenproject.org Thu Oct 28 12:16:01 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Oct 2021 12:16:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217986.378247 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg4K9-0005F8-0n; Thu, 28 Oct 2021 12:16:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217986.378247; Thu, 28 Oct 2021 12:16:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg4K8-0005F1-U1; Thu, 28 Oct 2021 12:16:00 +0000
Received: by outflank-mailman (input) for mailman id 217986;
 Thu, 28 Oct 2021 12:15:59 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Oo2o=PQ=arm.com=michal.orzel@srs-us1.protection.inumbo.net>)
 id 1mg4K7-0005Ei-RE
 for xen-devel@lists.xenproject.org; Thu, 28 Oct 2021 12:15:59 +0000
Received: from foss.arm.com (unknown [217.140.110.172])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTP
 id cd8e71a4-d6b5-48b6-8293-1be42eaab109;
 Thu, 28 Oct 2021 12:15:58 +0000 (UTC)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C7D981063;
 Thu, 28 Oct 2021 05:15:57 -0700 (PDT)
Received: from [10.57.24.217] (unknown [10.57.24.217])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 8D0363F5A1;
 Thu, 28 Oct 2021 05:15:56 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: cd8e71a4-d6b5-48b6-8293-1be42eaab109
Subject: Re: [patch-4.16] arm/smmuv1,v2: Protect smmu master list with a lock
To: Julien Grall <julien@xen.org>, Stefano Stabellini
 <sstabellini@kernel.org>, Julien Grall <julien.grall.oss@gmail.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>, Ian Jackson <iwj@xenproject.org>
References: <20211026122903.15042-1-michal.orzel@arm.com>
 <e5632a4e-db98-41b4-1045-2b3532c098fa@xen.org>
 <70c30a6c-b779-805e-079a-41bb484894b9@xen.org>
 <cb452c0c-ccde-7798-c403-f972b48a2c46@arm.com>
 <01545115-e82e-2a9d-a8e4-da9676080c0f@xen.org>
 <alpine.DEB.2.21.2110271557570.20134@sstabellini-ThinkPad-T480s>
 <CAJ=z9a2SSgG7a87_xTGT5LeNLgubOLQf1+dbnrsTsP8_p5ErJg@mail.gmail.com>
 <alpine.DEB.2.21.2110271658330.20134@sstabellini-ThinkPad-T480s>
 <4554621d-63da-ea3e-e56a-4e01d0cef347@xen.org>
From: Michal Orzel <michal.orzel@arm.com>
Message-ID: <560e75eb-fa0d-a13a-219c-3c1db0b28fa1@arm.com>
Date: Thu, 28 Oct 2021 14:15:44 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <4554621d-63da-ea3e-e56a-4e01d0cef347@xen.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit

Hi Julien,

On 28.10.2021 12:05, Julien Grall wrote:
> Hi Stefano,
> 
> First apologies for sending the previous e-mails in HTML (thanks for pointing that out!).
> 
> On 28/10/2021 01:20, Stefano Stabellini wrote:
>> On Thu, 28 Oct 2021, Julien Grall wrote:
>>> On Thu, 28 Oct 2021, 00:14 Stefano Stabellini, <sstabellini@kernel.org> wrote:
>>>        On Wed, 27 Oct 2021, Julien Grall wrote:
>>>        > > > > > +    return ret;
>>>        > > > > >    }
>>>        > > > > >    static int register_smmu_master(struct arm_smmu_device *smmu,
>>>        > > > > > @@ -2056,7 +2066,10 @@ static int arm_smmu_add_device(struct device
>>>        > > > > > *dev)
>>>        > > > > >        } else {
>>>        > > > > >            struct arm_smmu_master *master;
>>>        > > > > > +        spin_lock(&arm_smmu_devices_lock);
>>>        > > > > >            master = find_smmu_master(smmu, dev->of_node);
>>>        > > > > > +        spin_unlock(&arm_smmu_devices_lock);
>>>        > > > >
>>>        > > > > At the moment, unlocking here is fine because we don't remove the
>>>        > > > > device. However, there are a series to supporting removing a device (see
>>>        > > > > [1]). So I think it would be preferable to unlock after the last use of
>>>        > > > > 'cfg'.
>>>        > > > >
>>>        > > Ok. I will move unlocking to the end of this else {} block. I was not aware
>>>        > > of the patch you are referring to.
>>>        >
>>>        > I think the end of the else is still too early. This needs to at least be past
>>>        > iommu_group_set_iommudata() because we store cfg.
>>>        >
>>>        > Potentially, the lock wants to also englobe arm_smmu_master_alloc_smes(). So I
>>>        > am wondering whether it would be simpler to hold the lock for the whole
>>>        > duration of arm_smmu_add_device() (I can see value when we will want to
>>>        > interlock with the remove code).
>>>
>>>        The patch was to protect the smmu master list. From that point of view
>>>        the unlock right after find_smmu_master would be sufficient, right?
>>>
>>>
>>> Yes. However this is not fixing all the problems (see below).
>>>
>>>
>>>        We only need to protect cfg if we are worried that the same device is
>>>        added in two different ways at the same time. Did I get it right? If so,
>>>        I would say that that case should not be possible? Am I missing another
>>>        potential conflict?
>>>
>>>
>>> It should not be possible to add the same device twice. The problem is more when we are going to remove the device. In this case, "master"
>>> may disappear at any point.
>>>
>>> The support for removing device is not yet implemented in the tree. But there is already a patch on the ML. So I think it would be
>>> shortsighted to only move the lock to just solve concurrent access to the list.
>>   That makes sense now: the other source of conflict is concurrent add and
>> remove of the same device. Sorry it wasn't clear to me before.
> At the moment, we are relying on the upper layer (e.g. PCI or DT subsystem) to prevent concurrent add/remove/assignment. The trouble is we don't have a common lock between PCI and DT.
> 
> One possibility would be to add a common in the uper layer, but it feels to me this is a bit fragile and may also require longer locking section than necessary.
> 
> That said, add/remove/assignment operations are meant to be rare. So this is could be an option. This would also have the advantage to cover all the IOMMUs.
> 
>>    
>>>        I am pointing this out for two reasons:
>>>
>>>        Protecting the list is different from protecting each element from
>>>        concurrent modification of the element itself. If the latter is a
>>>        potential problem, I wonder if arm_smmu_add_device is the only function
>>>        affected?
>>>
>>>
>>> I had a brief looked at the code and couldn't find any other places where this may be an issue.
>>>
>>>
>>>        The second reason is that extending the lock past
>>>        arm_smmu_master_alloc_smes is a bit worrying because it causes
>>>        &arm_smmu_devices_lock and smmu->stream_map_lock to nest, which wasn't
>>>        the case before.
>>>
>>>
>>> Nested locks are common. I don't believe there would be a problem here with this one.
>>>
>>>
>>>        I am not saying that it is a bad idea to extend the lock past
>>>        arm_smmu_master_alloc_smes -- it might be the right thing to do.
>>>
>>>
>>> I don't usually suggest locking changes blindly ;).
>>>
>>>        But I
>>>
>>>        am merely saying that it might be best to think twice about it.
>>>
>>>        and/or do
>>>        that after 4.16.
>>>
>>>
> 
> [...]
> 
>> The other thing that is not clear to me is whether we would need also to
>> protect places where we use (not allocate) masters and/or cfg, e.g.
>> arm_smmu_attach_dev, arm_smmu_domain_add_master.
> 
> I think both should be with the lock. Now the question is will other IOMMUs driver requires the same locking?
> 
> If yes, then maybe that locking should be in the common code.
> 
>>> That said we can work towards a new locking approach for 4.17.
>>> However, I would want to have a proposal from your side or at least
>>> some details on why the suggested locking is not suitable.
>>   The suggested locking approach up until the last suggestion looks
>> totally fine to me. The last suggestion is a bit harder to tell because
>> the PCI removal hook is not there yet, so I am having troubles seeing
>> exactly what needs to be protected.
> 
> The PCI removal hook is the same as the platform device one. There are already a patch on the ML (see [1]) for that.
> 
> We have two interlocking problem to resolve:
>   1) Concurrent request between PCI and platform/DT subsystem
>   2) Removal vs add vs (re)assign
> 
> The two approaches I can think of are:
> 
> Approach A:
>   - The driver is responsible to protect against 1)
>   - Each subsystem (DT and PCI) are responsible for 2)
> 
> Approach B:
>   The driver is responsible to protect for 1) 2).
> 
> From my understanding, the proposed patch for Michal is following approach A whilst my proposal is going towards approach B.
> 
> I am open to use approach A, however I think this needs to be documented as the lock to use will depend on whether the device is a PCI device or not.
> 

The purpose of this patch is to fix the issue that is present in 4.16.
The patch adding support for removal you are reffering to:
-is in RFC state
-is not meant for 4.16
-will need to be modified anyway because of the future PCI passthrough patches that are going to modify lots of stuff

That being said, the bug we want to fix touches only point 1). And in fact my patch is solving this issue.
So I think we should focus on 4.16 and fixing bugs for it without thinking of future patches/modifications.
I agree that the locking behaviour will change as soon as the patch you are reffering to will be merged.
However, the PCI passthrough patches are going to modify this code anyway, so all in all the future modifications will be needed.

> Cheers,
> 
> [1] <1630562763-390068-9-git-send-email-fnu.vikram@xilinx.com>
> 

Cheers,
Michal


From xen-devel-bounces@lists.xenproject.org Thu Oct 28 12:23:55 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Oct 2021 12:23:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.217995.378259 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg4Rc-0006rq-SX; Thu, 28 Oct 2021 12:23:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 217995.378259; Thu, 28 Oct 2021 12:23:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg4Rc-0006rj-Oj; Thu, 28 Oct 2021 12:23:44 +0000
Received: by outflank-mailman (input) for mailman id 217995;
 Thu, 28 Oct 2021 12:22:01 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=QhoO=PQ=gmail.com=green.hu@srs-us1.protection.inumbo.net>)
 id 1mg4Pw-0006oU-Vf
 for xen-devel@lists.xenproject.org; Thu, 28 Oct 2021 12:22:01 +0000
Received: from mail-pj1-x1034.google.com (unknown [2607:f8b0:4864:20::1034])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 620ad1b5-302e-48e5-bad1-24cde6d35744;
 Thu, 28 Oct 2021 12:22:00 +0000 (UTC)
Received: by mail-pj1-x1034.google.com with SMTP id
 k2-20020a17090ac50200b001a218b956aaso4545502pjt.2
 for <xen-devel@lists.xenproject.org>; Thu, 28 Oct 2021 05:22:00 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 620ad1b5-302e-48e5-bad1-24cde6d35744
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc:content-transfer-encoding;
        bh=sEQTGe1SdVzMEvdAS+JHzGs+s//rKDLb3zrHBeoZhQ4=;
        b=iTF+KxXEUPxEL0X/A/h2gzR6rfhKbueZtpV43T9ecbwhzi0t+l3q/o5Ua3AWvU+Enc
         ByGkTqENMRntgh3iznFMDxu2CMYcinTkd+zVseDqmIBVqNiOOl7jtDTN28tXnXeh/eHS
         f+SIvvi2YC7tI22dM3EDibcHeQLa3iIqsv5H8CiejoyVxtmYKOA3VOetskmtU4Lx+Pqb
         LjWvbMeTK5pVAec3h6exgixTZBuA0b6b4pLrHZnH5EOvWXMCcJgTfSDot7PpiFpwOrmA
         UDe0Zf8yyrgR8VQIYltC0W9ualVYljq6alX4ZkNWzu2NeGmBPW3wY5ZPA2p2XVSWoIe3
         jylQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc:content-transfer-encoding;
        bh=sEQTGe1SdVzMEvdAS+JHzGs+s//rKDLb3zrHBeoZhQ4=;
        b=EKIuycGZTZAGfIXLPPhyxNzb4IpONDf+HWiQU1zbMP8HlvVDFjK+weUbYkR3XTO4wD
         YjeHs5UyroUXGVC4VR28ipJ5/0pw9PFgSnrYSnw1Cw6r5BYIa8O5LEPKJXy+Fa7c0BuM
         rKKn1NFSE+snfT1XhRMqKLG4RL7IUqSkt3Y/BeZRW60tKod9cmuT/PfhM5C19GR90GZN
         wYbRXWcp9i1XWTh2BtThyZbxDlcRU2J5pMslrDUqlvABZ72JlvsVF8ySboQ4k3OZ3efm
         fGoOgp1OmwIvk5QBU/0XhVSl6qvXv4UQOSHZxB81fwnkvKLHMRrldaGcpULF99iAGct9
         BP9w==
X-Gm-Message-State: AOAM530xsLbs/W84qjz8B7boiouC4Tong3vlDu59FCZkELvKozywnLFO
	PsdSjoozIFtvsKul9TLXtlQwGIoJfQTNvWVlAkw=
X-Google-Smtp-Source: ABdhPJwgRG6Z5IlQAMmxkEb7xwk/3DRskWOoc9lq5s+Jze0PB67uqVa13ZU9GrnI44E+cb/61DiEpYjC8sFDBN8RSYA=
X-Received: by 2002:a17:902:b716:b0:13f:b2d1:f316 with SMTP id
 d22-20020a170902b71600b0013fb2d1f316mr3644234pls.24.1635423719258; Thu, 28
 Oct 2021 05:21:59 -0700 (PDT)
MIME-Version: 1.0
References: <20211027211715.12671-1-digetx@gmail.com> <20211027211715.12671-16-digetx@gmail.com>
In-Reply-To: <20211027211715.12671-16-digetx@gmail.com>
From: Greentime Hu <green.hu@gmail.com>
Date: Thu, 28 Oct 2021 20:20:00 +0800
Message-ID: <CAEbi=3eTruN6rYvEHCtyhTEZ=Ep8n6g75UMpHffc=0UrVTGbdQ@mail.gmail.com>
Subject: Re: [PATCH v2 15/45] nds32: Use do_kernel_power_off()
To: Dmitry Osipenko <digetx@gmail.com>
Cc: Thierry Reding <thierry.reding@gmail.com>, Jonathan Hunter <jonathanh@nvidia.com>, 
	Lee Jones <lee.jones@linaro.org>, "Rafael J . Wysocki" <rafael@kernel.org>, 
	Mark Brown <broonie@kernel.org>, Andrew Morton <akpm@linux-foundation.org>, 
	Guenter Roeck <linux@roeck-us.net>, Russell King <linux@armlinux.org.uk>, 
	Daniel Lezcano <daniel.lezcano@linaro.org>, 
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>, Ulf Hansson <ulf.hansson@linaro.org>, 
	Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will@kernel.org>, Guo Ren <guoren@kernel.org>, 
	Geert Uytterhoeven <geert@linux-m68k.org>, Greg Ungerer <gerg@linux-m68k.org>, 
	Joshua Thompson <funaho@jurai.org>, Thomas Bogendoerfer <tsbogend@alpha.franken.de>, 
	Nick Hu <nickhu@andestech.com>, Vincent Chen <deanbo422@gmail.com>, 
	"James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>, Helge Deller <deller@gmx.de>, 
	Michael Ellerman <mpe@ellerman.id.au>, Benjamin Herrenschmidt <benh@kernel.crashing.org>, 
	Paul Mackerras <paulus@samba.org>, Paul Walmsley <paul.walmsley@sifive.com>, 
	Palmer Dabbelt <palmer@dabbelt.com>, Albert Ou <aou@eecs.berkeley.edu>, 
	Yoshinori Sato <ysato@users.sourceforge.jp>, Rich Felker <dalias@libc.org>, 
	Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>, 
	Dave Hansen <dave.hansen@linux.intel.com>, x86@kernel.org, 
	"H. Peter Anvin" <hpa@zytor.com>, Boris Ostrovsky <boris.ostrovsky@oracle.com>, 
	Juergen Gross <jgross@suse.com>, Stefano Stabellini <sstabellini@kernel.org>, Len Brown <lenb@kernel.org>, 
	Santosh Shilimkar <ssantosh@kernel.org>, 
	Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>, 
	Linus Walleij <linus.walleij@linaro.org>, Chen-Yu Tsai <wens@csie.org>, 
	=?UTF-8?Q?Jonathan_Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>, 
	Tony Lindgren <tony@atomide.com>, Liam Girdwood <lgirdwood@gmail.com>, 
	Philipp Zabel <p.zabel@pengutronix.de>, Vladimir Zapolskiy <vz@mleia.com>, 
	Avi Fishman <avifishman70@gmail.com>, Tomer Maimon <tmaimon77@gmail.com>, 
	Tali Perry <tali.perry1@gmail.com>, Patrick Venture <venture@google.com>, 
	Nancy Yuen <yuenn@google.com>, Benjamin Fair <benjaminfair@google.com>, Pavel Machek <pavel@ucw.cz>, 
	linux-arm-kernel@lists.infradead.org, 
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, linux-csky@vger.kernel.org, 
	linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, 
	linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, 
	linuxppc-dev <linuxppc-dev@lists.ozlabs.org>, linux-riscv@lists.infradead.org, 
	linux-sh@vger.kernel.org, xen-devel@lists.xenproject.org, 
	linux-acpi@vger.kernel.org, linux-omap@vger.kernel.org, 
	openbmc@lists.ozlabs.org, linux-tegra@vger.kernel.org, 
	linux-pm@vger.kernel.org, Alan Kao <alankao@andestech.com>, 
	=?UTF-8?B?Sy5DLiBLdWVuLUNoZXJuIExpbijmnpflnaTmiJAp?= <kclin@andestech.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Dmitry Osipenko <digetx@gmail.com> =E6=96=BC 2021=E5=B9=B410=E6=9C=8828=E6=
=97=A5 =E9=80=B1=E5=9B=9B =E4=B8=8A=E5=8D=885:18=E5=AF=AB=E9=81=93=EF=BC=9A
>
> Kernel now supports chained power-off handlers. Use do_kernel_power_off()
> that invokes chained power-off handlers. It also invokes legacy
> pm_power_off() for now, which will be removed once all drivers will
> be converted to the new power-off API.
>
> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
> ---
>  arch/nds32/kernel/process.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/nds32/kernel/process.c b/arch/nds32/kernel/process.c
> index 49fab9e39cbf..0936dcd7db1b 100644
> --- a/arch/nds32/kernel/process.c
> +++ b/arch/nds32/kernel/process.c
> @@ -54,8 +54,7 @@ EXPORT_SYMBOL(machine_halt);
>
>  void machine_power_off(void)
>  {
> -       if (pm_power_off)
> -               pm_power_off();
> +       do_kernel_power_off();
>  }
>
>  EXPORT_SYMBOL(machine_power_off);
> --
> 2.33.1
>

Loop in Alan and KC


From xen-devel-bounces@lists.xenproject.org Thu Oct 28 12:29:29 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Oct 2021 12:29:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.218006.378270 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg4Ww-0007g1-KN; Thu, 28 Oct 2021 12:29:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 218006.378270; Thu, 28 Oct 2021 12:29:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg4Ww-0007fu-Ga; Thu, 28 Oct 2021 12:29:14 +0000
Received: by outflank-mailman (input) for mailman id 218006;
 Thu, 28 Oct 2021 12:29:12 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mg4Wu-0007fm-GE
 for xen-devel@lists.xenproject.org; Thu, 28 Oct 2021 12:29:12 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mg4Wu-0007Cu-AE
 for xen-devel@lists.xenproject.org; Thu, 28 Oct 2021 12:29:12 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mg4Wu-00071j-9L
 for xen-devel@lists.xenproject.org; Thu, 28 Oct 2021 12:29:12 +0000
Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89)
 (envelope-from <iwj@xenproject.org>)
 id 1mg4Wq-00024G-FP; Thu, 28 Oct 2021 13:29:08 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date
	:Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From;
	bh=xTyjn4c3e2yajfXpWQk72ujAhJ/ZYp1EyU1023ShDGE=; b=kOIjz1CvkjWdFb9TqpJfe1Qq/V
	+t9f0jlU/uBEzIfvwtG5ratFQtrWyL4CD/fJkVkkwb9JdbSE0uMPLEH+LrvlsjGkwoKm+5Hr3GYeF
	0gWwhGP+6r436PzlpZZLb6ftWdTxlI8vk93Ei9FoD2c1ubYdBwSDfg0EbxyHkfRdOu/U=;
From: Ian Jackson <iwj@xenproject.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <24954.38803.851753.366549@mariner.uk.xensource.com>
Date: Thu, 28 Oct 2021 13:29:07 +0100
To: Juergen Gross <jgross@suse.com>
Cc: xen-devel@lists.xenproject.org
Subject: Re: [OSSTEST PATCH 0/2] ts-xen-build: explicitly enable/disable
 configure features
In-Reply-To: <822a9317-2ed0-8510-dc31-90ccff5c6c38@suse.com>
References: <20211027170256.18223-1-iwj@xenproject.org>
	<822a9317-2ed0-8510-dc31-90ccff5c6c38@suse.com>
X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu)

Juergen Gross writes ("Re: [OSSTEST PATCH 0/2] ts-xen-build: explicitly enable/disable configure features"):
> Far from being a Perl expert I agree this is a sensible approach and it
> should do the right thing.
> 
> It will still depend on no unsupported option being mentioned in any
> comment, e.g. "# option --enable-foo is no longer supported" will result
> in a wrong positive when testing for feature "foo". In the end this will
> break the build, so it should be easy to detect in case this happens
> some time in the future.
> 
> As there is no way to print out all supported options, this could only
> be solved by adding "--disable-option-checking", which has other
> disadvantages.
> 
> You can add my:
> 
> Reviewed-by: Juergen Gross <jgross@suse.com>

Thank you for your detailed review and analysis.

I have pushed this to osstest pretest.

Ian.


From xen-devel-bounces@lists.xenproject.org Thu Oct 28 13:03:42 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Oct 2021 13:03:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.218016.378281 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg545-0003Uc-8x; Thu, 28 Oct 2021 13:03:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 218016.378281; Thu, 28 Oct 2021 13:03:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg545-0003UV-4z; Thu, 28 Oct 2021 13:03:29 +0000
Received: by outflank-mailman (input) for mailman id 218016;
 Thu, 28 Oct 2021 13:03:28 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=8Bw3=PQ=citrix.com=roger.pau@srs-us1.protection.inumbo.net>)
 id 1mg544-0003UP-6k
 for xen-devel@lists.xenproject.org; Thu, 28 Oct 2021 13:03:28 +0000
Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 13c13876-5818-4a16-b822-92e87fd61794;
 Thu, 28 Oct 2021 13:03:26 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 13c13876-5818-4a16-b822-92e87fd61794
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1635426206;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=AhceljzKYRz2odnWhyS8tRE+GxdKJQirIFvwjs4RfdI=;
  b=atblYchJ03iXKWhaKYqZmof8FiDIdMQ+2wjUrfoDMpQm4b/ieLArACvd
   CmFFChel5tnd38v1nKK05Z8XL0ttRZY980RPuaZ6AJAPRRRkmusJVdIqS
   E3TRuFTLdB53sWHbcHtKfqSJUkgBsoUWrn7y2+Ad6OnZl8pxRgNMWJYpP
   Y=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: Vqm9IcfZ7tUlYJjiWScSa81XyRJBkdzJQbW4OtfH3OJQR/jr5IuZ2SaubNtbm3W5uKcgosIvZP
 WlAaCoykwqLI9RVZ5G4XzxPbq6jvvoSCWvj9zhy1oWMaoMF0rcbXf6+8/WOTcDvCAaOwttt8n3
 WWur3N/1/T0gNIlvtZdLU1LEXzU5+i1RsUmwZB2iZNdZ2MAAaUsEfcI2t2qe5YnguWu3ISBpnp
 2a/fNy/0eoOgf4Yynn8rlqOudZXpVMW2rmdVRDxnnhTI5FotpU1lH8Swn9wy2sBtQiy2BmFBwr
 Ua4Yu03nkAD46BHrnnJzcvQW
X-SBRS: 5.1
X-MesageID: 56941798
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:z1j846LdQbQaVM+EFE+RjZMlxSXFcZb7ZxGr2PjKsXjdYENSgzYGy
 jBOUW3QbqzcNjanKI9zYdji9xsPvZ7Vm9NnQVNlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s
 q3yv/GZdJhcokcxIn5BC5C5xZVG/fjgqoHUVaiUZUideSc+EH140Eo5y7Zg6mJVqYPR7z2l6
 IuaT/L3YDdJ6xYsWo7Dw/vewP/HlK2aVAIw5jTSV9gS1LPtvyB94KYkDbOwNxPFrrx8RYZWc
 QphIIaRpQs19z91Yj+sfy2SnkciGtY+NiDW4pZatjTLbrGvaUXe345iXMfwZ3u7hB20jf9q4
 c4TmqC2YisoMJ3mn+4bDgVxRnQW0a1uoNcrIFC6uM2XiUbHb2Ht07NlC0Re0Y8wo7gtRzsUr
 LpBdW5LPkvra+GemdpXTsF2gcsuNo/zNZ43sXB81zDJS/0hRPgvRo2Xu44EhWhh1qiiG97ca
 JYCWx1BRy/pXA8eZnMwWY8ng/yR0yyXnzpw9wvO+PtfD3Lo5A5+yr/2K/LOZ8eHA85Smy6wv
 Xna9m70BhUbMt23yjef9H+owOjVkkvTZoUWE7Gp8+9wt3eazGcTFR4+WEOypL+yjUvWc95WN
 UE84Cclqqk2skuxQbHVXQC8oXOClg4RXZxXCeJSwBGAzO/Y7hiUAkAATyVdc5o2uckuXzso2
 1SV2dTzClRHsaKXYWKQ8K+OqjG/MjRTKnUNDQcGRwYY59jooKkokwnCCN1kFcadkdndCTz2h
 TeQo0ADa6471JBRkf/hpBae3mzq9sOhohMJChv/Y3CK9SpiOqGZYaeE6Fbrx/FKKtuFZwzU1
 JQboPS24OcLBJCLsSWCRuQRAb2kj8q43C3gbU1HRMZ5qWz8k5K3VcUJumsmfRY2WioRUWaxO
 Be7hO9H2HNE0JJGh4dMaIWtF99i86HkEdn0Phw/RosTOsYvHONrEScHWKJx44wPuBRz+U3cE
 c3CGSpJMZr8If8+pNZRb7xEuYLHPghkmQvuqWnTlnxLK4a2an+PUqsiO1CTdO0/567siFyLq
 IsEaZPQkEsOALGWjszrHWg7dgliwZ8TXsmeliCqXrTbfloO9J8JUqe5LUwdl3xNwP0Oy7agE
 oCVUU5E0lvv7UAr2i3RAk2PnIjHBM4lxVpiZHREFQ/xhxALPNb+hI9CJsBfVeR2q4ReIQtcE
 qBtlzOoWa8UFFwqOl01MPHAkWCVXE/62FzUZ3D8PGhXklwJb1Whx+IItzDHrUEmJiG2qdE/s
 /un0AbaSoAEXANsEIDdb/fH8r97lSN1dDtaUxSaL99NVl/r9YQ2eSX9guVue5MHKAnZxyvc3
 AGTWE9Kqe7Iqo4z0d/ImaHb8Nv5T7ogRhJXTzvB8LK7FSjG5W7/k4VOZ/mFIGLGX2Tu9aT8O
 egMl6PgMOcKlUphupZnF+o51ro34tbi/ucIzgltEHjRQU6sD7dsfiuP0cVV7/Ufzb5FowqmH
 EmI/4ACa7mOPcrkFn8XJRYkMbvfha1FxGGK4K1sckvg5SJx8L6WamloPkGB2H5HMb94EII52
 uN96sQY3BOy10gxOdGcgyEKq2nVdi4cU78qv40xCZPwjlZ50UlLZJHRB3Ok4JyLbNkQYEAmL
 iXN2fjHjrVYgEHDb2AyBT7G2u8E3cYCvxVDzVkjIVWVm4Wa2q9rjUMJqTlnHB5Iyhhn0v5oP
 jk5PkJ4EqyC4jN0iZURRGurAQxAWEWU90GZJ4HlT4EFo51EjlDwEVA=
IronPort-HdrOrdr: A9a23:A877kq4CR+UwD7/eRAPXwMzXdLJyesId70hD6qkXc20zTiX4rb
 HLoB1/73TJYVkqNE3I9eruBEDiexPhHPxOj7X5VI3KNGOKhILCFuBfxLqn7zr8GzDvss5xvJ
 0QFpSW0eeAbmSSW/yKgjWFLw==
X-IronPort-AV: E=Sophos;i="5.87,189,1631592000"; 
   d="scan'208";a="56941798"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=j+9UhwpDcEBrmCkSTi7xBhPUVv7HdvG8FWUK6hpWWEY2W/qw3rHjft0EmV61CyowgoRE+TW6mWiKBPQ27iEOn6nI7GcO916ZinY26gqFMr7vf/jLOvJtEMikQLct9MJvjPovlfBnHN8/rQNbdhjWFigIuUNYiYG2ycoBS2teEPvSRdxsQIvESTTZeTuMfvV7XxkA5P2sqoWCJJEqe8QuRXGadiVrUD+XvQ2UWoDIbAnjdvbWa1qG4KPaN30f8ZvQ/zne3Db/w2dLenFgrxEkcqw5/KnA02A03HBd+PK9a+/tzrVttVog9J6cxaW06QsZLDNU2Dd7ocWgGnGy4/yMDw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=TMjAYuXt5rsltQUWFAndqjAVZQiKlI8lpg4tgKFHseE=;
 b=cKppplmRiet98NaboJmmiSzwDtUOgFV+moarau+HQB57CW4JM+/KXZvJu/3KjoGLukvuRQn06ILpLcy9mpjhF2em0jEx9FYj+zkAuLhI6E/eXSCjVzG0eK3evbRyU4888Kmsl8WhxwgTB3rDD1NCEwOj6E8Ak43XPAUBxWnzCCMbzTP+m0sVBe9lA9KbnqxNTtlH2+bGaUsIHMpPgEmxvB4kqz26FFaHVDn3d606fJzuFNHBEZJ/HUMEFg5D1UcGw1DFsZ2b549MQC/vUR04abBoXEf9ceeTQku5bopcSbf/rb/haOtpGxfixBZN8Rz4CdDvpxEDPHbobOCTU2K1WA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=TMjAYuXt5rsltQUWFAndqjAVZQiKlI8lpg4tgKFHseE=;
 b=NUp+B9bAZlmU3ESw8z0C3taUlC4/8Ph1xtiTidjh3G5CeE34cR0DlEcaSGT4AzSOKH1tbkTk9WfM9+vEhl59ac4J/mpQ+oumQgfpARtrMMWEG8VW4o97+A+uLTFb2OxmTGMv+koW+mhDiC9cagJqQF3jGtoNUqF3RF+OIZ4plxw=
Date: Thu, 28 Oct 2021 15:03:15 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Ian Jackson <iwj@xenproject.org>
CC: <xen-devel@lists.xenproject.org>, Wei Liu <wl@xen.org>, Andrew Cooper
	<andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>, Jan
 Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>, Stefano
 Stabellini <sstabellini@kernel.org>, Anthony PERARD
	<anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>, Christian
 Lindig <christian.lindig@citrix.com>, David Scott <dave@recoil.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH for-4.16 v3] gnttab: allow setting max version per-domain
Message-ID: <YXqfk4tj30EmbSEt@Air-de-Roger>
References: <20211028095923.83982-1-roger.pau@citrix.com>
 <24954.37807.277003.373593@mariner.uk.xensource.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <24954.37807.277003.373593@mariner.uk.xensource.com>
X-ClientProxiedBy: MR2P264CA0109.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:500:33::25) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 6054c68d-0f55-4f55-d240-08d99a135182
X-MS-TrafficTypeDiagnostic: DM6PR03MB5068:
X-Microsoft-Antispam-PRVS: <DM6PR03MB50685173F398D63202434F848F869@DM6PR03MB5068.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: fChqEKLMg01Mser8Hu0HAv+JpaObxGUKkdTpePxL9FUtqZO2RZsKriyPYIQekPtM55yM7+jE2wrnGmozAcHMFFEGxLEAV6nQKtkGNIK7qlfyh1Zh6MmzXq9QGrAIPO/SB2XpTkiIRfAI71NVDON8y2Tw19i+lwajiNvJgBZs4wRngEG1XWkx0jKdN6HmD2+EEr5WZDmTrC5j1+A2fNZN5dmubB4rUM2pi7JalFNbZvc99SHgpkGXRt2h2Bu8J0hXyvMmoW0WMyws3LTolR9COX9tbxG0wrKqxqIc0lwRT2vt2X2rZ/2akm8rfwF06BKpjVp6zJQq18HEHoI6U+w9YwE59AH6gddyHx5rDBclEcqYK9BFc1Sk9sLJ3UyInfMqXmO4600VPDddL0EoLv0nTqz73JNeWaUbPMkNiPaDG0c4w7unvjCpJOOxgTxqz+UIXqq4sXxVRsxJVyXhq+kOTUwZGLgQdhWVs5YWaSPQdzxl7h7d2jtkQadU8YXbYo6KmioB8Gx2Ge0fnUoJXsooDA2Il7wp5HbCwAtpvDR36+tLx2MbxV/BryFYPED6TXze5HwkBy+p7nK7tzCZjur3KkWczN4nESoOjTlZjzOu+ZCxWmseTlrPVGhxtzw9QH7V35GFAbeYDsHihvQZJpX75F3lxtoqvZ4Mvu/WnO0b8yNME+EDbCyT60JFqYMa64423p8PVoBKqHkzwCqjUZpnyRvthOBfmS+ABaHhMt3zZaCOAs4Ig0GzgwzrCPX9SEzwJqdxNQ5ss73zg+fVEMQZEQ==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(7916004)(4636009)(366004)(956004)(38100700002)(66556008)(66476007)(5660300002)(66946007)(2906002)(8936002)(83380400001)(508600001)(26005)(6666004)(8676002)(9686003)(6916009)(33716001)(4326008)(82960400001)(6486002)(966005)(54906003)(316002)(6496006)(85182001)(86362001)(186003);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eFB3Wld1MGVwOEZlYjE5MWxoU082UHU1dVhYRzZsNnNRalZmWW1IMERhVmhU?=
 =?utf-8?B?Rnk0cW92cGNYeHd1U01hS2ZZYXJHNTFNMFdjOGVTenpwZWQzK2FYZUF2QWRJ?=
 =?utf-8?B?Rm9BNHhhdmFRU3ZFTklHMGFKT1pGcUpLc2s3NHhpZ29UblBDQi8zVzkwOGVQ?=
 =?utf-8?B?MlJaTlVad21sRHFMMVh5UzllWG1xWjZNNHNCZDg1Wll6akZGdGZHWFlZalV0?=
 =?utf-8?B?WjhtWHBzRWppdU8wSE1GZnVEaTRwdUxTOTZjWDRwRXBPWmo2WHJnS3NHWm9h?=
 =?utf-8?B?aGRKcG9KUHNUblIvZmZhSXdwN1lEbFltVW9KdzBnYlJRMHVhNWRGdWxXUzJa?=
 =?utf-8?B?NFpxY1l5MjhmRjZoc1BOTzRFQ3FCKzQwaHlpUitrNDJiV0NxcXJ6TWtiWTd6?=
 =?utf-8?B?eEZsZWtkU0Erbkx5QzNQN1E3VjZTVTA5MHExcUpYNVM3OHVIcStvbjJXdE82?=
 =?utf-8?B?MDJ1alloNEM2KzZFVkNsR1BSNWVsMFNIbXlycTROUEVIMDZ6S2FJdHdjNkpy?=
 =?utf-8?B?V25rQnIxaEtrL1BURUJjK1FoU0ZoSEJvYUtuSkpSYUE4QmMvRm5BOFlYczFF?=
 =?utf-8?B?NkZzNFczWFBhSkFwVDRUQ3R1a1daMml2Y1NxVHZ4VncwNE5kcUlJM0UvbWFs?=
 =?utf-8?B?UENML2RsT0xFbTczZDVycnNST0JvTW1XMlBuUnVlZ0d1MjVaMXVsQnhMd2Nj?=
 =?utf-8?B?NTBHbSsvcEk3TzZPcnBLUDAwd2pldEJ0cVg4aHF1emNRUXUxQWlaNGtKcVdT?=
 =?utf-8?B?bHZ4Z0l5MXIyWEU0clVaT1ZFakJSNTJJSlpjQlluMFc2aXZwVC82d283aFZI?=
 =?utf-8?B?N2RidVYzaVhiNHBLSlM3eTFoMUF2TjJmZ0EzS2VFQzk5REF6OXFER2N5Ty8z?=
 =?utf-8?B?UTRWRlo1R2k5UERlSHB1OEVZSldzSU00OG4vY3lyRlB2ZUpPbkMvNEZEMUZZ?=
 =?utf-8?B?NGxsYTZ3Qy9ZMWhmbTNUbGVzcUJwaFBVL0NlVXpMSDVKM2xDU3BUd1VzYmtC?=
 =?utf-8?B?Wlg1bzlHc3l3UEQ1RjRtSnRYNHRWUlNFUVkwd1paeVB0NjlhelRsa09xdGdr?=
 =?utf-8?B?TmtuSmZKZjk4c2tRYU41Q3NuaFc4cHY0OUtRbmZzQ2hHSlc5Nm9jWjVRNVQ0?=
 =?utf-8?B?aVN6eS9GZ2U3citGaFNQdWV4emNpcXZMbEJSUTlRQVZPV3RFSmRHV2g5TzFK?=
 =?utf-8?B?OUQ1TnZHaExkL0pSNXZIZTZOb2hDTFgwYWIrcmg1VC9IMTl0dU00VmMrVEtU?=
 =?utf-8?B?SDFIb3IwOUJMR0lVV1FJeTgvVjlEYVJVdjlDUm1QV09PS3NyQmFJSUxvRHM2?=
 =?utf-8?B?ck5adm5vY3AvNEJFTHNuR1l6Y2d6UFAzSTRCR0UvN1hORytoWGZSMklZZng0?=
 =?utf-8?B?UDNNeXREamNxcnUvcW4xcUI5T1EyUTFMTXE0TlhJTnE5NU1YdzdKbDBYamFh?=
 =?utf-8?B?OFNYdnFubVE1by9Vc3c1blR2enFLdzhzcU04Um54QkRTMnRpOWZ4ZXlhV3Vr?=
 =?utf-8?B?U2ZrZUR2TWxVU0xOV1Bzc2RCaWdLQStpV2ZFeXUvckpWUi9aaEpuYlpqUFp5?=
 =?utf-8?B?cStFdEdRTkc4SXpySWRrUXEzZEhOWDZNRHZtSEMwYkViY3dtbll0NnFvZ3dW?=
 =?utf-8?B?RXh1ZEpOL2NRUmFBL09yN3FJWXJtb25ZTmRycnl3MGxOYVM5TFdhUUYzZ2g0?=
 =?utf-8?B?S2JQUC9PYkZ1TUZRY09mVG1yaXdjUUJ2cHdjSXpxSFVPME0xNjFIbnBJdzN6?=
 =?utf-8?B?UngzdGhnTENBQWFmMUxmUVptQUl5VlBCVDVJVjlGSUVvWTMrNTNHc2FEV2Ja?=
 =?utf-8?B?elR6SktrRHBLdkhGcDNyQ0xtTVJoVDJtL0tFUDlBQUF2Z2NsNzFQempvYVFF?=
 =?utf-8?B?bTZiNzl4VlUrSkVUUWw5YTdMcVZnc0h3S0xoMnA5RlJ5dlV5bHJHaDNWeFk3?=
 =?utf-8?B?c1JGU2tpK0RjcTNHdS9abVJEUWxDWkl5VWZmcHRIZTkwR2ROMlZldGRzd01n?=
 =?utf-8?B?RldCRnBaQWZ2RFRUUk16YlA2Z1NKRjUrWVE0ZTI1eUdpdVovakppcW82UmFt?=
 =?utf-8?B?S25BbU42U1A1Q0xENXMxVnN2ZU1wbzBsTzZ4N2ZBTkg2V3FvZ05qL2R6Y1dX?=
 =?utf-8?B?aXhzZTc2UzVQQkNocUt2UUx2S2hKcDg1Ujk0NTZ4UzVUay9lRVU1K0Fic0FZ?=
 =?utf-8?Q?QaSDCFwu5TYKx2iDeEKCq0A=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 6054c68d-0f55-4f55-d240-08d99a135182
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Oct 2021 13:03:21.4012
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zOn3i/FrQhzVCtIwB0cRhrAY2tF3LJ94PFyv3n1aUFS+usX8htwLaC4pD26sDOkYRIY1M/M4StF/B+5w4J4dNQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB5068
X-OriginatorOrg: citrix.com

On Thu, Oct 28, 2021 at 01:12:31PM +0100, Ian Jackson wrote:
> Roger Pau Monne writes ("[PATCH for-4.16 v3] gnttab: allow setting max version per-domain"):
> > diff --git a/docs/man/xl.cfg.5.pod.in b/docs/man/xl.cfg.5.pod.in
> > index 55c4881205..21a39adb70 100644
> > --- a/docs/man/xl.cfg.5.pod.in
> > +++ b/docs/man/xl.cfg.5.pod.in
> > @@ -580,6 +580,12 @@ to have. This value controls how many pages of foreign domains can be accessed
> >  via the grant mechanism by this domain. The default value is settable via
> >  L<xl.conf(5)>.
> >  
> > +=item B<max_grant_version=NUMBER>
> > +
> > +Specify the maximum grant table version the domain is allowed to use. Current
> > +supported versions are 1 and 2. The default value is settable via
> > +L<xl.conf(5)>.
> 
> 
> Firstly, review from my maintainer hat:
> 
> In the lower levels of this stack, I'm not sure why you chose -1 for
> "default", when 0 is not (and never will be) used ?

No, I actually had plans to use 0 to signal no grant table support for
the guest, see:

https://lore.kernel.org/xen-devel/20210922082123.54374-7-roger.pau@citrix.com/

> > diff --git a/tools/helpers/init-xenstore-domain.c b/tools/helpers/init-xenstore-domain.c
> > index 6836002f0b..7cd1aa8f7c 100644
> > --- a/tools/helpers/init-xenstore-domain.c
> > +++ b/tools/helpers/init-xenstore-domain.c
> > @@ -88,6 +88,7 @@ static int build(xc_interface *xch)
> >           */
> >          .max_grant_frames = 4,
> >          .max_maptrack_frames = 128,
> > +        .grant_opts = 1,
> >      };
> 
> I think this sets the max gnttab version for xenstore stub domains to
> 1 ?  That's not mentioned in your commit message or your release
> discussion.

Indeed. AFAICT MiniOS only supports grant table v1, and the grant
related parameters max_maptrack_frames and max_grant_frames are
already set based on DEFAULT_MAX_GRANTS and NR_GRANT_FRAMES
respectively as defined in MiniOS code.

Would you like me to this to the commit message:

"xenstored stubdomains are limited to grant table v1 because the
current MiniOS code used to build them only has support for grants v1.
There are existing limits set for xenstored stubdomains at creation
time that already match the defaults in MiniOS."

> 
> Secondly, the release question:
> 
> > Release rationale:
> > 
> > We have had a bunch of security issues involving grant table v2 (382,
> > 379, 268, 255) which could have been avoided by limiting the grant
> > table version available to guests. This can be currently done using a
> > global host parameter, but it's certainly more helpful to be able to
> > do it on a per domain basis from the toolstack.
> 
> Let me think this through.
> 
> Upside:
> 
> So the advantage is to have a mitigation for possible (but, perhaps,
> likely) future security bugs.  We don't change the default here, so
> the default configuration is still vulnerable.
> 
> We have this mitigation already but only on a per-host command line
> basis, so you (1) have to reboot (2) can't use it if you have any
> guests that need v2.  (2) is less of a problem than it sounds because
> even with the selective mitigation you will remain vulnerable to those
> guests.  So the main advantage is having to reboot the guests but not
> the hosts.
> 
> Downside:
> 
> > Changes to the hypervisor by this patch are fairly minimal, as there
> > are already checks for the max grant table version allowed, so the
> > main change there is moving the max grant table version limit inside
> > the domain struct and plumbing it through the toolstrack.
> 
> Right.
> 
> > I think the risk here is quite low for libxl/xl, because it's
> > extensively tested by osstest, so the main risk would be breaking the
> > Ocaml stubs, which could go unnoticed as those are not actually tested
> > by osstest.
> 
> I will want a review by ocaml folks.  Christian ?
> 
> In particular, I would like an opinion from the ocaml tooling
> maintainers about whether there is a risk of this feature breaking
> things *if it's not used*.
> 
> 
> I am not sure about the implications for migration.  Might using this
> cause migration to fail for some guests ?
> 
>    Note that when using the default grant version the specific max
>    version in use by the domain is not migrated. Any guests should be
>    able to cope with the max grant version changing across migrations,
>    and if a specific guest relies on a maximum grant version being
>    unconditionally available it should be specified on the configuration
>    file.
> 
> Only if the feature is *not* used, I guess.  Ie, this is the status
> quo.   So I don't think there is any release risk there.

This was raised by Jan in a previous version, the discussion can be
found here:

https://lore.kernel.org/xen-devel/0b58667f-b6bc-d5b5-2dd1-0c8996367319@suse.com/

The issue could arise if a guest that strictly needs grant v2 is
migrated from a host that has v2 as the default max version to another
box that has v1 as the max version. If the guest config file doesn't
explicitly specify that the guest requires grant v2 migration will
succeed, but the guest will likely fail to resume properly.

This is already the current behavior if a guest is migrated from a
host not having gnttab=max-ver set to one having gnttab=max-ver:1.

> 
> If this change does cause problems, it is deep throughout the stack,
> but not entangled with anything else, so I think we could revert it ?

I think so, unless we start piling a lot of other toolstack changes on
top it's unlikely to be a problem to revert.

> If we can get good answers to all of this, ideally I would like to see
> this committed by the end of tomorrow.  I plan to cut RC1 on Monday.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Thu Oct 28 13:10:31 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Oct 2021 13:10:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.218023.378292 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg5Am-000516-0T; Thu, 28 Oct 2021 13:10:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 218023.378292; Thu, 28 Oct 2021 13:10:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg5Al-00050z-TN; Thu, 28 Oct 2021 13:10:23 +0000
Received: by outflank-mailman (input) for mailman id 218023;
 Thu, 28 Oct 2021 13:10:23 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mg5Al-00050p-3p; Thu, 28 Oct 2021 13:10:23 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mg5Ak-0007ti-Th; Thu, 28 Oct 2021 13:10:22 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mg5Ak-0006SE-J6; Thu, 28 Oct 2021 13:10:22 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mg5Ak-0004va-IZ; Thu, 28 Oct 2021 13:10:22 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=rwbASYhj21zxQ8ncuU+fY+gdkT8nCJFwEScloahQEo0=; b=TJ3B0xhZm/32t8mS0qBfas2wsa
	cWrhyghfLf77rEGZ36O0M02ZgTuDPkbdIvp62UypKSPji834Vlm8WzK5earvPU4AiS1l2klBUKO1F
	6XQ2cSO8DUHPYr0klFY/Uqjj/xGfbrDS1gjU1cwM6lvBlmRyTxBJcSLmHvDVjNMk2tW8=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165920-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 165920: regressions - FAIL
X-Osstest-Failures:
    qemu-mainline:build-i386:xen-build:fail:regression
    qemu-mainline:build-i386-xsm:xen-build:fail:regression
    qemu-mainline:build-armhf:xen-build:fail:regression
    qemu-mainline:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-amd:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-pair:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-freebsd10-i386:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-freebsd10-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-coresched-i386-xl:build-check(1):blocked:nonblocking
    qemu-mainline:build-armhf-libvirt:build-check(1):blocked:nonblocking
    qemu-mainline:build-i386-libvirt:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-intel:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-shadow:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-vhd:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=c52d69e7dbaaed0ffdef8125e79218672c30161d
X-Osstest-Versions-That:
    qemuu=50352cce138ef3b30c1cda28a4df68fff5da3202
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 28 Oct 2021 13:10:22 +0000

flight 165920 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165920/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-i386                    6 xen-build                fail REGR. vs. 165682
 build-i386-xsm                6 xen-build                fail REGR. vs. 165682
 build-armhf                   6 xen-build                fail REGR. vs. 165682

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl           1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-credit2   1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-cubietruck  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-multivcpu  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-rtds      1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-vhd       1 build-check(1)               blocked  n/a
 test-amd64-i386-qemuu-rhel6hvm-amd  1 build-check(1)               blocked n/a
 test-amd64-i386-pair          1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-freebsd10-i386  1 build-check(1)               blocked  n/a
 test-amd64-i386-freebsd10-amd64  1 build-check(1)               blocked  n/a
 test-amd64-coresched-i386-xl  1 build-check(1)               blocked  n/a
 build-armhf-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-credit1   1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-arndale   1 build-check(1)               blocked  n/a
 test-amd64-i386-qemuu-rhel6hvm-intel  1 build-check(1)             blocked n/a
 test-amd64-i386-xl            1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-pvshim     1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-qemuu-debianhvm-amd64  1 build-check(1)         blocked n/a
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow  1 build-check(1)  blocked n/a
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm  1 build-check(1)      blocked n/a
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 1 build-check(1) blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a
 test-amd64-i386-xl-qemuu-win7-amd64  1 build-check(1)              blocked n/a
 test-amd64-i386-xl-qemuu-ws16-amd64  1 build-check(1)              blocked n/a
 test-amd64-i386-xl-shadow     1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-vhd        1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-xsm        1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165682
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165682
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165682
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 qemuu                c52d69e7dbaaed0ffdef8125e79218672c30161d
baseline version:
 qemuu                50352cce138ef3b30c1cda28a4df68fff5da3202

Last test of basis   165682  2021-10-19 21:09:14 Z    8 days
Failing since        165694  2021-10-20 18:09:12 Z    7 days   18 attempts
Testing same since   165920  2021-10-27 21:39:18 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Alistair Francis <alistair.francis@wdc.com>
  Andrew Jones <drjones@redhat.com>
  Ani Sinha <ani@anisinha.ca>
  BALATON Zoltan <balaton@eik.bme.hu>
  Bin Meng <bmeng.cn@gmail.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Cédric Le Goater <clg@kaod.org>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  David Gibson <david@gibson.dropbear.id.au>
  David Hildenbrand <david@redhat.com>
  Dr. David Alan Gilbert <dgilbert@redhat.com>
  Eric Auger <eric.auger@redhat.com>
  Eugenio Pérez <eperezma@redhat.com>
  Frank Chang <frank.chang@sifive.com>
  Gavin Shan <gshan@redhat.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Greg Kurz <groug@kaod.org>
  Gustavo Romero <gromero@linux.ibm.com>
  Igor Mammedov <imammedo@redhat.com>
  Jason Wang <jasowang@redhat.com>
  John Wang <wangzhiqiang02@inspur.com>
  John Wang <wangzq.jn@gmail.com>
  Laurent Vivier <laurent@vivier.eu>
  Laurent Vivier <lvivier@redhat.com>
  Luc Michel <lmichel@kalray.eu>
  Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
  Markus Armbruster <armbru@redhat.com>
  Matheus Ferst <matheus.ferst@eldorado.org.br>
  Mathieu Poirier <mathieu.poirier@linaro.org>
  Michael S. Tsirkin <mst@redhat.com>
  Mingwang Li <limingwang@huawei.com>
  Oğuz Ersen <oguzersen@protonmail.com>
  Peter Krempa <pkrempa@redhat.com>
  Philipp Tomsich <philipp.tomsich@vrull.eu>
  Philippe Mathieu-Daudé <f4bug@amsat.org>
  Philippe Mathieu-Daudé <philmd@redhat.com>
  Richard Henderson <richard.henderson@linaro.org>
  Shuuichirou Ishii <ishii.shuuichir@fujitsu.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Thomas Huth <thuth@redhat.com>
  Tong Ho <tong.ho@xilinx.com>
  Travis Geiselbrecht <travisg@gmail.com>
  Vincent Palatin <vpalatin@rivosinc.com>
  Vivek Goyal <vgoyal@redhat.com>
  Xueming Li <xuemingl@nvidia.com>
  Yanan Wang <wangyanan55@huawei.com>
  Yifei Jiang <jiangyifei@huawei.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               fail    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          blocked 
 test-amd64-i386-xl                                           blocked 
 test-amd64-coresched-i386-xl                                 blocked 
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  blocked 
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       blocked 
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           blocked 
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     blocked 
 test-amd64-i386-freebsd10-amd64                              blocked 
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          blocked 
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          blocked 
 test-armhf-armhf-xl-arndale                                  blocked 
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  blocked 
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  blocked 
 test-armhf-armhf-xl-cubietruck                               blocked 
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         blocked 
 test-amd64-i386-freebsd10-i386                               blocked 
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         blocked 
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                blocked 
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         blocked 
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 blocked 
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    blocked 
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     blocked 
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              blocked 
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    blocked 
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      blocked 
 test-amd64-i386-xl-vhd                                       blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 4111 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Oct 28 13:23:23 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Oct 2021 13:23:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.218032.378306 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg5N3-0006gy-FB; Thu, 28 Oct 2021 13:23:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 218032.378306; Thu, 28 Oct 2021 13:23:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg5N3-0006gr-Af; Thu, 28 Oct 2021 13:23:05 +0000
Received: by outflank-mailman (input) for mailman id 218032;
 Thu, 28 Oct 2021 13:23:03 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mg5N1-0006gl-CY
 for xen-devel@lists.xenproject.org; Thu, 28 Oct 2021 13:23:03 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mg5Mz-000878-N6; Thu, 28 Oct 2021 13:23:01 +0000
Received: from 54-240-197-225.amazon.com ([54.240.197.225] helo=[10.7.236.13])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mg5Mz-00023C-H4; Thu, 28 Oct 2021 13:23:01 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=U9+CneLqA59jMvTf40V/pcb3YWfkkZv+ivMYePhNc/0=; b=QVICLKelAk8FXmNf8cSCuqCgku
	G/us69MO5lkDpSQmKyV29hYaR+1eSUkN7MVkALTdI2HTPdjthHvDYV3H88JmYWgtRl2qXowq7Yx9L
	05kSj1rhKc9oAz62kyqmp2dmwLB+Q0WXIsFg3ETZdA/Z0fmQTbiM5J9giqNOc4SGkbiQ=;
Message-ID: <65886734-7333-4469-fcc1-6916db708f13@xen.org>
Date: Thu, 28 Oct 2021 14:22:59 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.2.1
Subject: Re: [PATCH] xen/arm: fix SBDF calculation for vPCI MMIO handlers
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: "sstabellini@kernel.org" <sstabellini@kernel.org>,
 "iwj@xenproject.org" <iwj@xenproject.org>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Rahul Singh <rahul.singh@arm.com>
References: <20211027082533.1406015-1-andr2000@gmail.com>
 <cb7e9ef7-476e-93c3-d3c9-9a9ebc61003d@xen.org>
 <d63c6e0b-8aa3-9ba3-893c-5e464638a8db@epam.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <d63c6e0b-8aa3-9ba3-893c-5e464638a8db@epam.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

On 28/10/2021 13:09, Oleksandr Andrushchenko wrote:
> Hi, Julien!

Hello,

> On 27.10.21 20:35, Julien Grall wrote:
>> Hi Oleksandr,
>>
>> On 27/10/2021 09:25, Oleksandr Andrushchenko wrote:
>>> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
>>>
>>> While in vPCI MMIO trap handlers for the guest PCI host bridge it is not
>>> enough for SBDF translation to simply call VPCI_ECAM_BDF(info->gpa) as
>>> the base address may not be aligned in the way that the translation
>>> always work. If not adjusted with respect to the base address it may not be
>>> able to properly convert SBDF and crashes:
>>>
>>> (XEN) vpci_mmio_read 0000:65:1a.0 reg 8bc gpa e65d08bc
>>
>> I can't find a printk() that may output this message. Where does this comes from?
> That was a debug print. I shouldn't have used that in the patch description, but
> probably after "---" to better explain what's happening
>>
>> Anyway, IIUC the guest physical address is 0xe65d08bc which, if I am not mistaken, doesn't belong to the range advertised for GUEST_VPCI_ECAM.
> This is from dom0 I am working on now.
>>
>> IMHO, the stack trace should come from usptream Xen or need some information to explain how this was reproduced.
>>
>>> (XEN) Data Abort Trap. Syndrome=0x6
>>> (XEN) Walking Hypervisor VA 0x467a28bc on CPU0 via TTBR 0x00000000481d5000
>> I can understnad that if we don't substract GUEST_VPCI_ECAM, we would (in theory) not get the correct BDF. But... I don't understand how this would result to a data abort in the hypervisor.
>>
>> In fact, I think the vPCI code should be resilient enough to not crash if we pass the wrong BDF.
> Well, there is no (?) easy way to validate SBDF.

AFAICT pci_ecam_map_bus() is already doing some validation for the bus 
number. So...

  And this could be a problem if we have a misbehaving
> guest which may force Xen to access the memory beyond that of PCI host bridge
>>
>> When there is a data abort in Xen, you should get a stack trace from where this comes from. Can you paste it here?
> (XEN) Data Abort Trap. Syndrome=0x6
> (XEN) Walking Hypervisor VA 0x467a28bc on CPU0 via TTBR 0x00000000481d5000
> (XEN) 0TH[0x0] = 0x00000000481d4f7f
> (XEN) 1ST[0x1] = 0x00000000481d2f7f
> (XEN) 2ND[0x33] = 0x0000000000000000
> (XEN) CPU0: Unexpected Trap: Data Abort

... I am getting quite confused why this is crashing. Are we validation 
correctly the access?


> (XEN) ----[ Xen-4.16-unstable  arm64  debug=y  Not tainted ]----
> (XEN) CPU:    0
> (XEN) PC:     000000000026d3d4 pci_generic_config_read+0x88/0x9c
> (XEN) LR:     000000000026d36c
> (XEN) SP:     000080007ff97c00
> (XEN) CPSR:   0000000060400249 MODE:64-bit EL2h (Hypervisor, handler)
> (XEN)      X0: 00000000467a28bc  X1: 00000000065d08bc  X2: 00000000000008bc
> (XEN)      X3: 000000000000000c  X4: 000080007ffc6fd0  X5: 0000000000000000
> (XEN)      X6: 0000000000000014  X7: ffff800011a58000  X8: ffff0000225a0380
> (XEN)      X9: 0000000000000000 X10: 0101010101010101 X11: 0000000000000028
> (XEN)     X12: 0101010101010101 X13: 0000000000000020 X14: ffffffffffffffff
> (XEN)     X15: 0000000000000001 X16: ffff800010da6708 X17: 0000000000000020
> (XEN)     X18: 0000000000000002 X19: 0000000000000004 X20: 000080007ff97c5c
> (XEN)     X21: 00000000000008bc X22: 00000000000008bc X23: 0000000000000004
> (XEN)     X24: 0000000000000000 X25: 00000000000008bc X26: 00000000000065d0
> (XEN)     X27: 000080007ffb9010 X28: 0000000000000000  FP: 000080007ff97c00
> (XEN)
> (XEN)   VTCR_EL2: 00000000800a3558
> (XEN)  VTTBR_EL2: 00010000bffba000
> (XEN)
> (XEN)  SCTLR_EL2: 0000000030cd183d
> (XEN)    HCR_EL2: 00000000807c663f
> (XEN)  TTBR0_EL2: 00000000481d5000
> (XEN)
> (XEN)    ESR_EL2: 0000000096000006
> (XEN)  HPFAR_EL2: 0000000000e65d00
> (XEN)    FAR_EL2: 00000000467a28bc
> (XEN)
> [snip]
> (XEN) Xen call trace:
> (XEN)    [<000000000026d3d4>] pci_generic_config_read+0x88/0x9c (PC)
> (XEN)    [<000000000026d36c>] pci_generic_config_read+0x20/0x9c (LR)
> (XEN)    [<000000000026d2c8>] pci-access.c#pci_config_read+0x60/0x84
> (XEN)    [<000000000026d4a8>] pci_conf_read32+0x10/0x18
> (XEN)    [<000000000024dcf8>] vpci.c#vpci_read_hw+0x48/0xb8
> (XEN)    [<000000000024e3e4>] vpci_read+0xac/0x24c
> (XEN)    [<000000000024e934>] vpci_ecam_read+0x78/0xa8
> (XEN)    [<000000000026e368>] vpci.c#vpci_mmio_read+0x44/0x7c
> (XEN)    [<0000000000275054>] try_handle_mmio+0x1ec/0x264
> (XEN)    [<000000000027ea50>] traps.c#do_trap_stage2_abort_guest+0x18c/0x2d8
> (XEN)    [<000000000027f088>] do_trap_guest_sync+0xf0/0x618
> (XEN)    [<0000000000269c58>] entry.o#guest_sync_slowpath+0xa4/0xd4
> (XEN)
> (XEN)
> (XEN) ****************************************
> (XEN) Panic on CPU 0:
> (XEN) CPU0: Unexpected Trap: Data Abort
> (XEN) ****************************************
> 
>>
>>>
>>> Fix this by adjusting the gpa with respect to the host bridge base address
>>> in a way as it is done for x86.
>>>
>>> Fixes: d59168dc05a5 ("xen/arm: Enable the existing x86 virtual PCI support for ARM")
>>>
>>> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
>>> ---
>>>    xen/arch/arm/vpci.c | 4 ++--
>>>    1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/xen/arch/arm/vpci.c b/xen/arch/arm/vpci.c
>>> index 8f40a0dec6d2..23f45386f4b3 100644
>>> --- a/xen/arch/arm/vpci.c
>>> +++ b/xen/arch/arm/vpci.c
>>> @@ -24,7 +24,7 @@ static int vpci_mmio_read(struct vcpu *v, mmio_info_t *info,
>>>        unsigned long data;
>>>          /* We ignore segment part and always handle segment 0 */
>>> -    sbdf.sbdf = VPCI_ECAM_BDF(info->gpa);
>>> +    sbdf.sbdf = VPCI_ECAM_BDF(info->gpa - GUEST_VPCI_ECAM_BASE);
>>
>> Looking at the rest of the rest, it seems that
>>   1) the issue is latent as the bits 0-27 are clear
>>   2) this will need to be modified to take into account dom0.
>>
>> So I would prefer if the base address is passed differently (maybe in priv?) from the start. This will avoid extra modification that you already plan to have in a follow-up series.
> I was thinking about the same, but the future code will use priv for other purpose:
> 
> static int vpci_mmio_read(struct vcpu *v, mmio_info_t *info,
>                             register_t *r, void *p)
> {
>       struct pci_host_bridge *bridge = p;
>       pci_sbdf_t sbdf;
>       /* data is needed to prevent a pointer cast on 32bit */
>       unsigned long data;
> 
>       if ( bridge )
>       {
>           sbdf.sbdf = VPCI_ECAM_BDF(info->gpa - bridge->cfg->phys_addr);
>           sbdf.seg = bridge->segment;
>       }
>       else
>           sbdf.sbdf = VPCI_ECAM_BDF(info->gpa - GUEST_VPCI_ECAM_BASE);

Is it the only place you are doing to use bridge? If so, then I think we 
can simply have a structure that would contain phys_addr and segment.

This would be include in the bridge for dom0 and for guest this could be 
a static global variable for now.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Thu Oct 28 13:26:58 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Oct 2021 13:26:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.218039.378317 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg5Qi-0007M8-RJ; Thu, 28 Oct 2021 13:26:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 218039.378317; Thu, 28 Oct 2021 13:26:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg5Qi-0007M1-OB; Thu, 28 Oct 2021 13:26:52 +0000
Received: by outflank-mailman (input) for mailman id 218039;
 Thu, 28 Oct 2021 13:26:51 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=8Bw3=PQ=citrix.com=roger.pau@srs-us1.protection.inumbo.net>)
 id 1mg5Qg-0007Lv-Tq
 for xen-devel@lists.xenproject.org; Thu, 28 Oct 2021 13:26:51 +0000
Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id b47bb778-37f2-11ec-84a0-12813bfff9fa;
 Thu, 28 Oct 2021 13:26:49 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b47bb778-37f2-11ec-84a0-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1635427609;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=A3H/kgwksHOHrFEsqR/o88gHwbTl30STVFrpzKzM2hQ=;
  b=aT+LZrXFONbR3t7ZcExn7GMhX7MQjG+rM8C9ac5xTcI94hyMjf3a/vJg
   yp11IVIQ59ZvgB4iJaid088j1VmoZQ2gnESjp/D3m6nrXjvjw8Ovl4X0F
   LlXl+01/GPe/QR7BWRD2RM8Wj+j1wPy2+DR0/5nt8rp57y/IMvXaPVXnX
   M=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: KqBACIgmDRhH9xszq+YtsbBZKhzFHjIusonzHXOGuChy/DjARYHFwQQpfAQZxsOgApMS0DhiVi
 wp/P/Ro3lY9uaS+njPKCmAOGq15t95XfcvAA73ykYX6TaFbp9wZsqH6zQij/KlcfPeI3wXaWuk
 ViHAVMZcEh2t397sSBLSfbIOy6g1cenmiCMc24/d8PAWl4CbqZhDk4IJG8ErtoD9HRfT2ul8r4
 dbKyt326qjNFdHhdUCi8uBzAtqWGr+GrRgzi8LCl9kCIm24+woIzasl7wJF/EJ3dIhN1TPh7pB
 Jk2BLyOIjeE8JOdqgqmg644s
X-SBRS: 5.1
X-MesageID: 56549343
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:ujx4Sq04+yR8IJt33fbD5SV2kn2cJEfYwER7XKvMYLTBsI5bpz0Dm
 zROC22Caf3ZZTT1fdskOY/gpxkGv8LXzodhTwBkpC1hF35El5HIVI+TRqvS04J+DSFhoGZPt
 Zh2hgzodZhsJpPkS5PE3oHJ9RGQ74nRLlbHILOCan8ZqTNMEn970Es7wb5h2+aEvPDia++zk
 YKqyyHgEAfNNw5cagr4PIra9XuDFNyr0N8plgRWicJj5TcypFFMZH4rHomjLmOQf2VhNrXSq
 9Avbl2O1jixEx8FUrtJm1tgG6EAaua60QOm0hK6V0U+6/TrS+NbPqsTbZIhhUlrZzqhjtVql
 ogSlqGKQ0QAAvTMwtQ+eQNmOnQrVUFG0OevzXmXtMWSywvNcmf2wuUoB0YzVWEa0r8pWycUr
 6VecW1TKEDY7w616OvTpu1EnMMsIdOtJIoCknph0SvYHbAtRpWrr6DiuIEFgGZr2psm8fD2P
 u8jSmIzXj/5XD5gZVgyJrU6l7ehiSyqG9FfgA3M/vdmi4TJ9yRu1JD9PdyTfcaFLe1UgUSwt
 m/A537+ABwRKJqY0zXt2mKhgKrDkD32XKoWFaak7bh6jVuL3GsRBRYKE1yhrpGRqGSzRtZeI
 Ew84Tc1oO4580nDczXmd0Tm+jje5EdaAocOVb1hgO2Q9kbKyxecHTZZER18UtZlnfNvRWYa9
 XWTofq8UFSDr4apYX6a876Vqxa7Ni4UMXIOaEc4cOcV3zXwiNps1kyXH76PBIbw14evQWihn
 FhmuQBn3+1L5fPnwZlX6rwub9iEnZPOUhIurjveWmao/2uVj6b0OtT2tzA3ARtGRbt1r2VtX
 lBYxKByD8hUVPlhcRBhps1WRdlFAN7eaVXhbaZHRcVJythU0yfLkXpsyD9/Plx1Fc0PZCXkZ
 kTe0SsIusQOZyXyN/QpMtLtYyjP8UQGPY+8PhwzRoEXCqWdiSfdpH0+DaJu9zm1+KTTrU3PE
 cjCKpv9ZZrrIa9m0CC3V48gPUwDnUgDKZfobcmjlXyPiOPGDFbMEOttGAbeP4gRsfLfyC2Io
 ok3Cid/40gGOAEISnKMqtB7wJFjBSVTOK0aXOQMJ7PdeFI8QT1xYxITqJt4E7FYc21uvr6g1
 lm2W1NCyUq5gnvCKA6QbWtkZq+pVpF6xU/X9wR3Vbpx83R8M4up8okFcJ47Iesu+OB5lKYmR
 PgZYcSQRP9IT22fqTgaaJD8qq1kdQiq2l3Sb3b0PmBncs4yXRHN9//lYhDrqHsEAB2ouJZsu
 LanzA7aH8YOHlwwEMbMZfuz5FqtpnxByvlqVk7FL4ALKkXh+YRnMQLrifozL51eIBnP3GLCh
 Q2XHQ0Zta/GpIpsqIvFgqWNroGIFepiHxUFQzmHvOjubSSDpzit245NVuqMbAvxbmKs9fXwf
 /hRwtH9LOYDwARAvb1jHus51qk5/dbu+eNXl1w2AHXRYl23Ibp8OX3aj9JXv6hAy7IF6wu7X
 kWDpotTNbmTYZ63FVcQIEwub/iZ1OFSkT7XtKxnLEL/7S5x3byGTUQNYEXc1H0DdON4YNE/3
 OMsmM8K8Aju2BMlP+GPgj1Q62nRfGcLVL8qt81CDYLm4ubxJoquvXAI5vfK3ayy
IronPort-HdrOrdr: A9a23:HzRHEqpiT42nwMvMUSLTpvQaV5uxL9V00zEX/kB9WHVpm5Oj+P
 xGzc526farslsssREb+OxpOMG7MBThHLpOkPMs1NCZLXTbUQqTXfpfBO7ZrQEIdBeOlNK1uZ
 0QFpSWTeeAcWSS7vyKkTVQcexQueVvmZrA7Yy1rwYPPHFXguNbnn9E426gYzNLrWJ9dPwE/f
 Snl656T23KQwVpUi33PAhOY8Hz4/nw0L72ax8PABAqrCGIkDOT8bb/VzyVxA0XXT9jyaortT
 GtqX202oyT99WAjjPM3W7a6Jpb3PPn19t4HcSJzuwYMC/lhAqEbJloH5eCoDc2iuey70tCqq
 iAnz4Qe+BIr1/BdGC8phXgnyHmzTYV8nfnjWSVhHPyyPaJDQ4SOo5kv8Z0YxHZ400vsJVXy6
 RQxV+UsJJREFfpgDn9z8KgbWAqqmOE5V4Z1cIDhX1WVoUTLJVLq5YEwU9TGJAcWArn9YEcFv
 V0Bs203ocZTbqjVQGbgoBT+q3vYpxqdS32B3Tq+/blnAS+pUoJj3fxn6ck7zM9HJFUcegz2w
 2LCNUuqFh0dL5lUUtKPpZ3fSKGMB2/ffvyChPmHb3GLtBOB5ufke+93F0KjNvaDKDgiqFC3q
 j8bA==
X-IronPort-AV: E=Sophos;i="5.87,189,1631592000"; 
   d="scan'208";a="56549343"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=JjRuQMBujP9/VOMFQqKmEZkHxLMiQ/xU5WhTLnScaQIQzg8apCA8b5eUENBDnZVaq0rlVOTRHrKN6/gxzFnKfXny4xFpaEGYiMxx6u+t3oz/0Sn/kYBbnfbqGGSLGTOp8C/1DEpazVA2eZE1WtkEIeKsaP97VnvPFn7J+V74TP38LyYc7TLEaxOCFoWr0fzSANfUmUL/oAAnTirNfI0LGVBrzSe7KsSvaxMbHIdN410NtnfxtAqDerOXrnhVBSs6VpOHSmIUUV/b7xgX0Ch+eohSTp+Zfl/PbCCY1jouuingHnfiYaO1nTysYKu8PUlE2kCIrCUkcoPyy/uomT3/9A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=euJgYPFU8bUrNLRObsngksn9vuyg3OJUWI2FfPHJMwQ=;
 b=NTuSHkMCTqAVg+sKpEpynsZ1xvSDWrfuaiEuUMJXaKlL0lqAoyDzb8qJNBv5PbfJOQMN7ZT3XRjSTaTumHVwy7AeEuzL7aWN0rBn1zIpCY/STKQGxN7SMIkbXMEdrVNfGdtjIAv5AN1RVzrQOPT9FyVEbD/s98Jwl+p5CmD6Ml2MGCM0/iNejOqM3TD0e/E7tst/unWsa5vuaC06lG5ncEQxmZhcnGJkU8VQ/Nd7pbUPEGlfieCHsyDuOMajniv5EMR+qPK8EP+T2vatzZYZHo1PwbvCpB1ux8djW/fFmApuNRNhZKbzjhbkn/imaldh7Lv2srvF5cES2wePKUTbYw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=euJgYPFU8bUrNLRObsngksn9vuyg3OJUWI2FfPHJMwQ=;
 b=p5GxkUFt3Yn3rAyPBgh36aJU9CBGCkd+HaB98A2mmnEtY+e+NVw0tRrS7VlspOJNSGy66MkR02T74MNXIHPpmU6Wd11GP3xi3rfrx5BZ0i7bGFKbLqgjd+raNQ298shcUXK5NRDqqa6KpqqSFAr5BUtR5OxAHX1CzZ03/ad4L0k=
Date: Thu, 28 Oct 2021 15:26:41 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>, Jan Beulich
	<JBeulich@suse.com>, Wei Liu <wl@xen.org>, Ian Jackson <iwj@xenproject.org>
Subject: Re: [PATCH] x86/passthrough: Fix hvm_gsi_eoi() build with GCC 12
Message-ID: <YXqlEQWk1HGNLKq3@Air-de-Roger>
References: <20211027200713.22625-1-andrew.cooper3@citrix.com>
 <YXpRzHEawUZEU87h@Air-de-Roger>
 <64788530-a18c-332f-c287-84478a200816@citrix.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <64788530-a18c-332f-c287-84478a200816@citrix.com>
X-ClientProxiedBy: MR1P264CA0009.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:501:2e::14) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 2c5275a6-549c-4a8a-fa23-08d99a1696f1
X-MS-TrafficTypeDiagnostic: DS7PR03MB5591:
X-Microsoft-Antispam-PRVS: <DS7PR03MB55910F47C371063CA35E92C98F869@DS7PR03MB5591.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: kzuQ+LQAEiSnokffErpMSkdhfX+XXKl8XQn0BI1UBtyHVuX/zGrFd0kv27Ys28uG5v9Ph/kefP7G41bJxj8/tTNXo/azrPxoNz7G0wJzzjOA6oKu34iBFEjglO0fl3Eo3+eOZtxl1cPh55L0dFhWkwin7lRyYYqrql16fWKFHGvGs/088aeBgz/LA28GQfWpaZ6SLV0X3eyqaQyAUYCuVSBwYho8s5hjmomrE4DiZPvFnNSO5zPSGCbcQWZRE1vxX+lXU3iKr7EQzyM4q985r9qwddWJQ9a2k6Z/T771YTbzNoYdw1dGEegJHo5L4X+jk3Y/mngLXcCzCtDDhXjuEkdlgvVo1/JdqYf4KdusWK0yeMV1N8vIjYlct/fxbHGsnAyM2KdQUZaUBCWoHPlDwSCIyhNgRNr8v7HasmRZCcNO5Gv8dgpaBzVVPT3BEhIOsdTW2NW+7OG9WmimhovRlHB132gmSJS4oSjluOGqc+G8WzytJYN/vOuUNYnPWMsBo3T/qxOwsCbqILzqA4xhd2FnTsQFlW9lDsHpt8zIcabeIELENgwQYzKm6VqXtZAQh0GnjdT5wyUb26TOPNXoTqILZ51qoauS6J6p1cWEtrPsX52C6WM4DZEcNFrFAqrscoRE90BATs+BYVmgJBVj0g==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(7916004)(366004)(508600001)(86362001)(2906002)(4326008)(6636002)(6666004)(956004)(186003)(9686003)(6862004)(85182001)(6486002)(316002)(8676002)(33716001)(38100700002)(66946007)(54906003)(66476007)(66556008)(53546011)(26005)(6496006)(8936002)(5660300002)(82960400001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YkpJY3Q4L1k2YnFuSkszRzJkYUowK3ZqcGFEaDNZc3ZtaWNCZDYvZCtMaG1s?=
 =?utf-8?B?MkprUmx3eWd1NDJlblZKNWQra2NFMERXSzdkU2xjT3MyeHJKMzk4RllJUS9j?=
 =?utf-8?B?Qlo0aDg0eENzMUFLZUxVNmR3VVhkUWlqOVVDQU02Zy9xbUVzbCtQOUo1b3BC?=
 =?utf-8?B?eWhwOUo4ei8rUHh2VEhqUVEzVTNMUHFEbE1pOTM4M1RLWER6QjBsVTFob0dU?=
 =?utf-8?B?aURDU2R2ZUNlaEdRWC85YVNrdi9OTUJVWHRFbUtXNnpRYTZvYXNpeDBYWUlV?=
 =?utf-8?B?S0Erdk9nVi9oZ2ZadytWUnlMOC9DMlhvZENWK1YweDFVTEQwZ3JzZC8wSTJw?=
 =?utf-8?B?ZVlSYkQyRFViTVZMYmtWdVErZm1SaUVhSTBYWjRMQXhsR2ZQaGxuSitwSTh3?=
 =?utf-8?B?VGFtZUR4NWZVaEw3YitxL0hEeG9lM3AwZ3A0b1VXSzRpMmwzSjZaRW0yMFpD?=
 =?utf-8?B?VDJCZFkrai9HSHhzOFJLaG1zakNGQWhtUVBZTzN5UFAwWk8xVUR0Z2VLc1N5?=
 =?utf-8?B?eTZWQjN4c0ZPVXcreFJ4cUVzd3VYVklFYkszMldKZE1nSkwyTHN4TjEwVk5D?=
 =?utf-8?B?YnowNGx6VlNnTGNhYTExVVlGMnpkS0IwUnRvWnN6V2RpWVdCQ3ZYdUJPY0JH?=
 =?utf-8?B?NzNka2UybEJBMllhTmU0SWZRWk9mRFg3WThGMjVGbWhBRVd0SWxNYk9scnVn?=
 =?utf-8?B?d3IvZHh2cXY3R091YzJlaElDYUNJcGo2RDBRLzB3NXlmTU9sZ3hEQjZ5NFVk?=
 =?utf-8?B?NDd1Q3J3VFBncWtLVU5kL0FiVVAvS2R5ZlFlSWczaHcxcVBhajliNXFicmtI?=
 =?utf-8?B?ZkJicG55eXlIaEs2UXlNeGpyelZuRXFqLzNNSVJsaHIrKy9CamJVU0ZHMjhZ?=
 =?utf-8?B?d25iZmRqNjQ3RDhaWVZrSXA4U2J6OGR6a1VvQzJQdmRmQ2lRMlNRME1sM0Jz?=
 =?utf-8?B?Z01QRUxVYjhJcnR4UkFWVW1LYk4xdUVqSGFIQVNEVVZuakVCOFlMZmx5anY4?=
 =?utf-8?B?KyswZTVWVFFxVk9TVE9ndFFsV2s1OC91aVdkWGdCOFZqdEU4VXN0NEtzSGFB?=
 =?utf-8?B?YnAxcmRpb3lZSFE2L1ZabGtET2dXSzdnSFdoL0NjWXJDUnNhRTlQYjVtZkFD?=
 =?utf-8?B?MkdSbVBPbjNtQXVJVkxVSE5GdGUrY2ljK3RCNDVRekRzVk9pVFEwR3pkbEJ4?=
 =?utf-8?B?UXlPMHp3MmRmWm5oZkFBZjJvRDRIVWc0WUt0YWp4MFhSSTFCYy9Qb0VvRWlz?=
 =?utf-8?B?TEZKUjZVVFE2ZE9GTVBNdU5NVlFqMWFKY3hEN1NiL2FrdUpnMnhuMGkvaDFw?=
 =?utf-8?B?dnoxYjVGR1JXYkxXNGszRXpvWThJS1pTUWY4MnppZVR1NmlleWFJb3R2UmRU?=
 =?utf-8?B?T2VFUUFqNW9rMEVlK3FEU0hwUnMyQktham10dXVnOHh6MlRTRFJEZDRsREg0?=
 =?utf-8?B?bVpCckZVdElnMFFoQ0VjbEN5OTdnZU9RUE1aQ3I1OGlacmRFWFVBYVdsRmtO?=
 =?utf-8?B?eUVtaXlIQlRYdFl2bWhRdmxCUEVrNk5WZStiT1F3bU9rY2RaREtVcEpnK2sw?=
 =?utf-8?B?RnFub2lTUVlkaW1Cajd0aDVJS2xrTG16cmd3ZG5UVmlnZmhwSnpmdEx2Z01Y?=
 =?utf-8?B?UHhwYm9SZVZodmpUQXFHT1pFUXRKYXR2emZ0Z0NYTEhXMVdsWU5hcForNmNl?=
 =?utf-8?B?UHNLYlVTaHNmbE1IeHhWQ0UyVlViTjBsMHlqcElrNGpRNHhWRGh4bkxQUElZ?=
 =?utf-8?B?anBFMHJWb2psOThFaW1aU1JwNThIaGl0c2Q5Y2Q4MS9HRkhRTG5SZjhlNE5L?=
 =?utf-8?B?NjFJMkR5OHF3cEJVRzBOM1BCM3J5UVUzYVlaRkROM0kwcXRZbnI5UE5uek80?=
 =?utf-8?B?Wm1NbmZwcWZ6ZTY0Qk5QcXdwenVjbS9td3gxZGFTTnZsSjk1dzVlaUp5RWln?=
 =?utf-8?B?RVcrNUZxcDVQaCtvKy8yeGRQVFhGOEJienBmbEJLYWNRdS9wYWNST0I0Kzhh?=
 =?utf-8?B?Vlk3dzIrUVBzZnBrSnJtekFNZDVYVCtpV0NFSk82RTdxYUhsRk5CN240WjBM?=
 =?utf-8?B?WityaTlaYzFSaWdKTWJGdmtmSTFCMTBJZEJiQ3dKNlNrWlVOK0liT3Y1Sm1B?=
 =?utf-8?B?RThsVnZYMTNNRDJuTGRCenpzZEhOVEg5YVY4UGtPQnNmVGt6cWo0TU1qTUNr?=
 =?utf-8?Q?2kYglDmPkUeL8iU+ccJXqnw=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 2c5275a6-549c-4a8a-fa23-08d99a1696f1
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Oct 2021 13:26:46.3169
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: x9fX9W62TWgORnuyPbF/Aa6LuSlwNZTHC1MSSstEKWDJ7sOeodN+nT7Vu/NSM2x6At45JbpnuB8c5c+f6ZHKew==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR03MB5591
X-OriginatorOrg: citrix.com

On Thu, Oct 28, 2021 at 01:15:13PM +0100, Andrew Cooper wrote:
> On 28/10/2021 08:31, Roger Pau Monné wrote:
> > On Wed, Oct 27, 2021 at 09:07:13PM +0100, Andrew Cooper wrote:
> >> GCC master (nearly version 12) complains:
> >>
> >>   hvm.c: In function 'hvm_gsi_eoi':
> >>   hvm.c:905:10: error: the comparison will always evaluate as 'true' for the
> >>   address of 'dpci' will never be NULL [-Werror=address]
> >>     905 |     if ( !pirq_dpci(pirq) )
> >>         |          ^
> >>   In file included from /local/xen.git/xen/include/xen/irq.h:73,
> >>                    from /local/xen.git/xen/include/xen/pci.h:13,
> >>                    from /local/xen.git/xen/include/asm/hvm/io.h:22,
> >>                    from /local/xen.git/xen/include/asm/hvm/domain.h:27,
> >>                    from /local/xen.git/xen/include/asm/domain.h:7,
> >>                    from /local/xen.git/xen/include/xen/domain.h:8,
> >>                    from /local/xen.git/xen/include/xen/sched.h:11,
> >>                    from /local/xen.git/xen/include/xen/event.h:12,
> >>                    from hvm.c:20:
> >>   /local/xen.git/xen/include/asm/irq.h:140:34: note: 'dpci' declared here
> >>     140 |             struct hvm_pirq_dpci dpci;
> >>         |                                  ^~~~
> >>
> >> The location marker is unhelpfully positioned and upstream may get around to
> >> fixing it.  The complaint is intended to be:
> >>
> >>   if ( !((pirq) ? &(pirq)->arch.hvm.dpci : NULL) )
> >>                   ^~~~~~~~~~~~~~~~~~~~~~
> >>
> >> which is a hint that the code is should be simplified to just:
> >>
> >>   if ( !pirq )
> > I likely need more coffee, but doesn't this exploit how the macro
> > (pirq_dpci) is currently coded?
> 
> The way pirq_dpci() is currently coded, this is nonsense, which GCC is
> now highlighting.
> 
> It would be a very different thing if the logic said:
> 
> struct pirq *pirq = pirq_info(d, gsi);
> struct hvm_pirq_dpci *dpci = pirq_dpci(pirq);
> 
> /* Check if GSI is actually mapped. */
> if ( !dpci )
>     return;
> 
> but it doesn't. Getting a non-null pirq pointer from pirq_info(d, gsi)
> does identify that the GSI is mapped, and the dpci nested structure is
> not used in this function.  I would expect this property to remain true
> even if we alter the data layout.

I think we have further assertions that this will be true:

 1. d can only be an HVM domain given the callers of the function.
 2. The pirq struct is obtained from the list of pirqs owned by d.

In which case it's assured that the pirq will always have a dpci. I
think it might be better if the check was replaced with:

if ( !is_hvm_domain(d) || !pirq )
{
    ASSERT(is_hvm_domain(d));
    return;
}

Here Xen cares that pirq is not NULL and that d is an HVM domain
because hvm_gsi_deassert will assume so.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Thu Oct 28 13:36:32 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Oct 2021 13:36:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.218047.378328 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg5Zv-0000Sk-Oz; Thu, 28 Oct 2021 13:36:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 218047.378328; Thu, 28 Oct 2021 13:36:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg5Zv-0000Sd-LY; Thu, 28 Oct 2021 13:36:23 +0000
Received: by outflank-mailman (input) for mailman id 218047;
 Thu, 28 Oct 2021 13:36:22 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=8Bw3=PQ=citrix.com=roger.pau@srs-us1.protection.inumbo.net>)
 id 1mg5Zu-0000SX-Fx
 for xen-devel@lists.xenproject.org; Thu, 28 Oct 2021 13:36:22 +0000
Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 091c2ac8-37f4-11ec-84a0-12813bfff9fa;
 Thu, 28 Oct 2021 13:36:21 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 091c2ac8-37f4-11ec-84a0-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1635428181;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=LA9IN5hvsHuDuR1ya0QUiI4hCXC1Cqm7/E7WVr1dteM=;
  b=BRYutO1CRuhjAcyLMrm75oUfEMgWZwk2EWvaeowI4gBJE0q4KPk7BrHH
   on0CkKTPmoFDc72bogb2LwndzjstR+1enZPjUKyCfo3pr8ldepobhRr5F
   LdFicrFHZqkh8J2Ml7cl3q9vKy5oXn6QxP8xNARt3RlkPROfT+VNGXqSK
   s=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: lfJkCEYuR5n4DC+DZ3uthob4ZYM1fuR5pgNcx0P8FOeqx711yntbwXsUOhfdGdY117q/g2h96K
 Nn9ygs8bLPJX/vKCpC5Gw3AJ0gyrlrIlGuRLtck8ZLbdK6GuJr6j5ucABVGO0ekSLnzNDLAREU
 WBBkppDI3zzo7tWl/Jh56s0j6MGOXbmWyt06crbv3ZV7YGER8x4Ou+oYWh6SaO321AKp//DIFu
 zVAgS7wUZeg7EMORZmp/SqQd8a7sMeFh4LC4owWu8W03+A3oAwokAnvvNOzQfkF9dbDTmok5LD
 08Ee0LWYDuoHKsiAyaeIBbl2
X-SBRS: 5.1
X-MesageID: 56550448
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:7/OlXKgxw906avZmueuFqoo+X161KBYKZh0ujC45NGQN5FlHY01je
 htvD26Ab/reZ2H0eYp2aI638hgEu5HdytAxHVRsrCgzFHwb9cadCdqndUqhZCn6wu8v7a5EA
 2fyTvGacajYm1eF/k/F3oAMKRCQ7InQLlbGILes1htZGEk0F0/NtTo5w7Rg29Yy0YDja++wk
 YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq
 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx
 /1Uh5m3eCYTLpeRgd4wTSZhCSZuN5ZZreqvzXiX6aR/zmXDenrohf5vEFs3LcsT/eMf7WNmr
 KJCbmpXN1ba2rzwkOnTpupE36zPKOHxO4wSoDd4xCzxBvc6W5HTBa7N4Le02R9t2J0TRaqCN
 6L1bxJufDHRMiFFOWwNJ68Xkb/0qCPFYQxx/Qf9Sa0fvDGIkV0ZPKLWGNvKePSaSMNNhEGaq
 2nauWPjDXkyPtGF1SCM9H7qg+bVhD76Q6obDrj+/flv6HWJz2wODFsNVF20odGwkEv4UNVaQ
 2QP4TYnp6U28E2tT/H+Uge+rXrCuQQTM/J3F+A58wiLxrDjygCVHHUfTjVBZdols+c7XTUvk
 FSOmrvBByFrsbCTYWKQ8PGTtzzaETgYKyoOaDEJSSMB4sL/u8cjgxTXVNFhHaWpyNrvFlnNL
 yui9XZkwe9J1IhSivv9rQuvby+QSobhVzww4TT2ZHKfsxpDSZCaXpav+VLg8qMVRGqGdWWps
 H8BksmYyekBC5CRiSCAKNkw8KGVC+Wta2KE3wY+d3U133H0oST7JNEPiN1rDB4xap5sRNP/X
 KPEVeq9DrdoN3y2cbQ/XYu1D8k7pUQLPYW4Dq6KBjaij54YSeNmwM2MTRLPt4wOuBJ1+U3aB
 Xt9WZ31ZZr9If8+pAdav89HjdcWKtkWnAs/v6zTwRW9yqa5b3WIU7oDO1bmRrlnt/7f/l2Pq
 IgOZ5fiJ/BjvAvWOXC/HWk7dgliEJTGLcqu95w/mhCre1IO9J4d5w/5nup6Jt0Nc1V9nebU5
 HCtMnK0O3Kk7UAr3T6iMyg5AJu2BM4XhStiYUQEYAb5s1B+MN3HxPpOKPMKkUwPqbULIQhcF
 KJeJa1tw51nF1z6xtjqRcKs8dI4LE7y2VLm0ujMSGFXQqOMjjfho7fMVgDu6DMPHmyws84/q
 KenzQTVXdwIQAEKMSocQKnHI4qZsSdPleRscVHPJ9UPKkzg/JIzc376j+MtItFKIhLGn2PI2
 wGTCBYehO/Mv45qr4WZ2fHa99+kQ7lkA05XP2jH9rLqZyPUyXWunN1bW+GScDGDCG6toPe+Z
 f9Yxu3XOeEcmAoYqJJ1FrtmlPps59bmq7JA4B5jGXHHMwaiBr96eyHU1shTrKxdgLRevFLuC
 E6I/9BbP5SPOd/kTwFNdFZ0MLzb2KhNyDfI7PkzLEHr3wNN/eKKARdIIh2BqC1BN78pYokr9
 vgs5ZwN4Aulhxt0btvf1nJI936BJ2ArWrk8ss1IG5fijwcmxw0QYZHYDSOqspiDZ88VbxsvK
 z6QwqHDm65d1gzJdH9qTSrB2u9UhJIvvhFWzQBdewTVy4Sd3vJnjgdM9TkXTxhOykQV2u1+D
 WFnKklpKPjc5DxvnsVCAzihFgwp6Md1IaAtJ4/lTFHkcnQ=
IronPort-HdrOrdr: A9a23:qODiP6G+WE5yS/cSpLqFcpHXdLJyesId70hD6qkvc3Nom52j+/
 xGws536faVslcssHFJo6HmBEClewKnyXcT2/htAV7CZnichILMFu9fBOTZsl/d8kHFh4tgPO
 JbAtRD4b7LfClHZKTBkXCF+r8bqbHtmsDY5pav854ud3ATV0gJ1XYGNu/xKDwReOApP+tcKH
 LKjfA32AZINE5nJPiTNz0gZazuttfLnJXpbVovAAMm0hCHiXeN5KThGxaV8x8CW3cXqI1SvV
 Ttokjc3OGOovu7whjT2yv66IlXosLozp9mCNaXgsYYBz3wgkKDZZhnWZeFoDcpydvfpWoCoZ
 3pmVMNLs5z43TeciWcpgbs4RDp1HIU53rr2Taj8DLeiP28YAh/J9tKhIpffBecwVEnpstA3K
 VC2H/cn4ZLDDvb9R6NpuTgZlVPrA6ZsHAimekcgzh0So0FcoJcqoQZ4Qd8DIoAJiTn84oqed
 MeQv003MwmMm9yUkqp/FWGmLeXLzEO91a9Mwc/U/WuonhrdCsT9Tpd+CQd9k1wgq7VBaM0oN
 gsCZ4Y5o2mePVmGp6VNN1xMvdfNVa9NC4kEFjiaWgPR5t3cE4klfbMkcEIDaeRCdo18Kc=
X-IronPort-AV: E=Sophos;i="5.87,190,1631592000"; 
   d="scan'208";a="56550448"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=OuPT3RMMQkpvlMwVAzIDTcESTopgxbEJIU+0FAME4M6fcxY80rJRMiBrjJANyI96PNY2SYslXpoYlgR4TvQotipBF1HwSyuFESBrIp2OlLUu1N/xyO7RbRukqMpDHklOEKgBW2pHw1WkxRGUAUjNDym0aodxsm0E2Xg/3HugfsyI82bJMPdpiHm3AaXaIj9kX5mMIrom3uCZog4fVFrUbHaQmtmNuqeq7VXjn4GsEQuUhXQXA0+G6e5WWQ7vPey6KpOYATr9umxtcEOg2Ag9GCBftgTTuObZoVnCsjeciH2/HJuKl/D6jZBgn0sfsICjqw1knPSc4v53Ij/QOg9NqA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=R3S4DJB+Ifu4PAobrPqPQmYAw2JoqJ0/kKP21fu4zIg=;
 b=V+Lcxn+uI2dwe5Oeb6CQ+TsLPW3OjUXlk5hgf+m+79jWwCApBaHfFnMH262SsruxWHIPY5gS1IVeAnF7Wis81J8zOTsk0B1Ao3PfpCR8B/77CMgOjHjcUhjE5amhCIjaSYV6FGELDux9IEjZTqHZQgdg/tHOUOqxlpSYZkd/R+/oxQln7Ah0mXOTBM8YCdHWpBngoFE/hXbk+9zRHgeQ7/2dpGFy4q65jDzLcuv48uJPjc0xL20VmkBxUXome0mK+TGKZYeaSQL4QSmZVw1+O5DN34uL8q325Uvrzw/AO7ms9MHUeuERcjlYeFCNCCYLCyCNdHY+YpUFIBsILh3n2w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=R3S4DJB+Ifu4PAobrPqPQmYAw2JoqJ0/kKP21fu4zIg=;
 b=NChzVfgaQ1ecBwXgU2kKIcpSOut7coxVXKjGpAQxik12a3vOa5j31bLJ+UDyEsI3Wsn1OfMQJCQ0oSjIvym66+4HLYeXNDqlS8/tmVtsvf2jOepzbGWmlt17QXyXv74Dfxmw9KI3uFpIXR0qyYhDCu1L2eP3tn7JgUO6JlVHKlk=
Date: Thu, 28 Oct 2021 15:36:11 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
CC: Julien Grall <julien@xen.org>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, "sstabellini@kernel.org"
	<sstabellini@kernel.org>, "iwj@xenproject.org" <iwj@xenproject.org>, Bertrand
 Marquis <bertrand.marquis@arm.com>, Rahul Singh <rahul.singh@arm.com>
Subject: Re: [PATCH] xen/arm: fix SBDF calculation for vPCI MMIO handlers
Message-ID: <YXqnS7iZUvokJby6@Air-de-Roger>
References: <20211027082533.1406015-1-andr2000@gmail.com>
 <cb7e9ef7-476e-93c3-d3c9-9a9ebc61003d@xen.org>
 <d63c6e0b-8aa3-9ba3-893c-5e464638a8db@epam.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <d63c6e0b-8aa3-9ba3-893c-5e464638a8db@epam.com>
X-ClientProxiedBy: MR2P264CA0167.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:501:1::30) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: ef7f72f3-361e-49fe-3655-08d99a17eafc
X-MS-TrafficTypeDiagnostic: DM6PR03MB3834:
X-Microsoft-Antispam-PRVS: <DM6PR03MB3834B8F2ED89A9E9C8A5CE7A8F869@DM6PR03MB3834.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 2zCVaG/s5W7BTOOpq+XTSMkQcZu9tQJH1jrcif8ftGk7BND9QC4Z29lZjaSHcElK2WvVQasuVX3LvwS+rdvF0qV5+7GIcigZFGvTsmln7W4764doxq4KhT3KwidF0oK5J0kkiosbXY7hbsNAJrUx07MDUlXk2ohv1pHVU5KspA1Vn/i8vM9oI9oEzQhmf0Y6+aN3S6omLvzi6wImCNV1EVIaMAwfETCOvjXslRvJgBaqSaxUmEiT9+OBxgbwoeVqpxEvku4k7kZL6WkZtbuzZu1GjpC7kE7C+WRRZ8YQPQNRt1rY88yII+13+QPTXh9fvzgMQJAvKgUy8rsdKC17Sv9gVfBR/6iT7GWAA0goO+ajCet9TUe++68D3feJ1+vcr/jPPKUAxbbc6EJhPCIvLaLoFMom0jomJSgHB9Rd6aEGwdRtpLkcL8INxIHqq+AfHHEqAc9081w4vstTmupot3Gy9FR8FVp/DhGHFRTRB7bnMxVWYiszT/V35YlQWq9sScjIo/plXBAYXWAEabvstpStFxzPqELl+HH9GDSKDP22XFXxlJE4ltesquQh9XWbwJ3/9O5REcHNS/poDWLqnPlR/MYUBN17nQJkLB8K3DqzXKslxPNDddGIW6V80ywBcuth0clMODV2v6w8gbpUfw==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(7916004)(4636009)(366004)(6916009)(82960400001)(66556008)(66476007)(2906002)(9686003)(508600001)(316002)(4326008)(38100700002)(33716001)(6666004)(83380400001)(53546011)(6496006)(186003)(26005)(6486002)(8676002)(66946007)(86362001)(8936002)(85182001)(956004)(54906003)(5660300002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RTk4WE5yZ3QxVy9nZkJ5Ni9LSG5LQzJ0a05iWVM1N1hVdkNvM3F6cE1tQ2Zt?=
 =?utf-8?B?VUNwWjBJRG12MmRoSG52M3NQMmxnK2VrVjB1TFV1U2J2cXhrMHBwbE82STZX?=
 =?utf-8?B?Ymp4QW5iNjhWVlp6VXRqUlZWWFpHYWdlVWYzdVRKZWViaHgxcXNEQWN0elhY?=
 =?utf-8?B?NkFtb2llNnV5WmU0ay9SZjZWQ082cDFGQTduOFVmV0dmR29kSVNrUnZJczZw?=
 =?utf-8?B?czR2M2ErVkZTbXJoRFB2OXdTOEJVR3hDSWQ2SStsaHI1UG9lUEhCQWxMeVZF?=
 =?utf-8?B?c3JBOXp0eWJpQ2pvYmVGVjN0Y2YvaUlTSXFMR1hBNnEwYWQ4ckxlQ0RqR3p2?=
 =?utf-8?B?UFpLK3N5d2tkVDFOTjUxYmsyWkliNzRkSUJ4Rmt2L2NlRXg1VzliRCthZUhD?=
 =?utf-8?B?WEp1anAzbXJRZFk3VU5Pcy9HamtPNkc2R1QycnNqam8zcm9Wa0NQVVdxcUdD?=
 =?utf-8?B?S0xBb3hVbjhJaEFtQi9JMk9TRDFDdzBpOElTSUZpRUlvM2U0WmdJbDJySjVH?=
 =?utf-8?B?dlp2UUZDVWpiWnI2Y0dOR0xRZ2NmZVUzTUwvc0tubVVCRzNnMm5kQS9wSWhF?=
 =?utf-8?B?eTcxek1TY3Y1SEwyWE9CY2ZPM1Z0SGRKeUtNRGlyVGc5U0VJWUJQWTVXOXhw?=
 =?utf-8?B?UzUzUFh5YXF0dUQ2RjdMa2tJWEZzRHRMYTdyZ1NPaGViOC9HalN6STlXQW1x?=
 =?utf-8?B?cXdIME1vVnljT0ZnUm5GODFVT3pXQnhFZ25tZHlwdm02OFJzcWhXR0JydTYv?=
 =?utf-8?B?V3B1ZEV0Uk90T2RHOSswdlJHeWZvODlsTFU3ZWpZVUV1ejdhUzFEbS9mVkp2?=
 =?utf-8?B?U3I0TmpBMEQ1dTY3bkVidDFnanFCdlpSZHlzZ3JmaDROTjI2ODJVeDdxNEw0?=
 =?utf-8?B?OWRrU2hQRENGY2JjME5lcm1ybnZNdWl5T3VBamQrTmgrZTlsYUZpQUFQUmpl?=
 =?utf-8?B?aHRHMzBYZVJ1Ny8vSEZaQTcxTWl6NE9YSVF0SGlJOCs4OVBmeXE1VkdjQ01z?=
 =?utf-8?B?OGhJKzlyRkFwQ0cxdWFTamsrMk9vQnJpUFNtOHNrOWZpaVhaY0lhREFlV05w?=
 =?utf-8?B?ZWs4WjJaSEtGQzl3ZmpIQm9jWFZkTkdZQlhvams2WnhCMUhNeTl4SitvMkwx?=
 =?utf-8?B?bk1wM0VpWVZrQjhGUVZTeFpYbzZGalhtQ2ljUGFwUjlGd1Z2K0c0V0tvR3hr?=
 =?utf-8?B?THhTUHM5bGFWQlRWQUhZcmZqOTRUZnlad0dXZTlJVXhqejhsMi9xeW5aaGhL?=
 =?utf-8?B?OExiKzFzVVV4Si9NRm1FNWVkeXlqdlJkQ0JTRmZNUE4yUXYzQjJwak1FL1U2?=
 =?utf-8?B?M0oxbnJVWHBJZVZvVzFtZjFjVEgzRWVYMFlEc1lFNDBJRWZaZ2dXZHdibkRY?=
 =?utf-8?B?djRicU1rRlFVcjZGcS9TK3lkMGVLNmpzdlRNdHVyUEc4TUF5bXlkODJwUHV2?=
 =?utf-8?B?cDlBZGpLdmJGd3htSE5wai9pQ016YUVjbjNPTVprOVkzUUFpWS9aeHkzVlVm?=
 =?utf-8?B?Y3U3K0taVnpRcFU1NUNSa0F3SXBsNU9nQVltd3RnSmtCMGNDLzNOT2hwcUsv?=
 =?utf-8?B?ZVFZQ2dadGZPSjRKMmFNaGxqamlPL0Vlck90YVROUkxHck9INFU1Mmx1NkVS?=
 =?utf-8?B?Wm1LQm04OUhyNC80SDkzTUtUSUJjRDNSNE1EbDlIL2VaMFhRNys2SWRNdm1h?=
 =?utf-8?B?ZU5mT2g5MCsxdmh0L2hNWmkvb29ET1hPRSs1UE8wVXBMRzI4dHpObVhvTVU3?=
 =?utf-8?B?UG9aK0wzRTBTNkZXak1aK01GWjNIVFlxdEVRN2lZV29JSks5QS85OWVSTTdC?=
 =?utf-8?B?d2hha2g2eDBwR1hMcnd1eFRxZ005VWZEa0NKVzVpN0xNVEFoaTZ6cjlUMVdo?=
 =?utf-8?B?U1pldDU2M3FKeUJUQ2Zxd2QwTkdSOElCRHJvMG10V3RhWjJka3Q5aUE4azFC?=
 =?utf-8?B?RE9tYWZVMlUybkVmSmpMOVhjRDErem8rTHdQektTc05GSVhLS2FNbEt4aHZO?=
 =?utf-8?B?eDZVN1krTUVGZlFnVEh1YlhMekVtaG44S0xPaldoQ2cwV2d2eGQ3aGo4MFRP?=
 =?utf-8?B?aHdVUWhUOU93eGk3b0lKTEFxZlhDZHcrdDg5bHZ6dVMzYXVBQ0ZNRzJWYjRi?=
 =?utf-8?B?c0pITGZnUmdFNzJRRjg0SlNQbWtuNERPVjJXdTlNcE1GLzNmRDV1QzRGUTdR?=
 =?utf-8?Q?8bKb09uq5VC+bSkK+0ISCu8=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: ef7f72f3-361e-49fe-3655-08d99a17eafc
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Oct 2021 13:36:16.8800
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: o2TRnE9enPTRmxhV03THNMbFnzlAIW1H7d2Z1loA7sj6wk8ejSFKNup0CMV1nusBZNGHAld/AupaYRvig4YkkA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB3834
X-OriginatorOrg: citrix.com

On Thu, Oct 28, 2021 at 12:09:23PM +0000, Oleksandr Andrushchenko wrote:
> Hi, Julien!
> 
> On 27.10.21 20:35, Julien Grall wrote:
> > Hi Oleksandr,
> >
> > On 27/10/2021 09:25, Oleksandr Andrushchenko wrote:
> >> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> >>
> >> While in vPCI MMIO trap handlers for the guest PCI host bridge it is not
> >> enough for SBDF translation to simply call VPCI_ECAM_BDF(info->gpa) as
> >> the base address may not be aligned in the way that the translation
> >> always work. If not adjusted with respect to the base address it may not be
> >> able to properly convert SBDF and crashes:
> >>
> >> (XEN) vpci_mmio_read 0000:65:1a.0 reg 8bc gpa e65d08bc
> >
> > I can't find a printk() that may output this message. Where does this comes from?
> That was a debug print. I shouldn't have used that in the patch description, but
> probably after "---" to better explain what's happening
> >
> > Anyway, IIUC the guest physical address is 0xe65d08bc which, if I am not mistaken, doesn't belong to the range advertised for GUEST_VPCI_ECAM.
> This is from dom0 I am working on now.
> >
> > IMHO, the stack trace should come from usptream Xen or need some information to explain how this was reproduced.
> >
> >> (XEN) Data Abort Trap. Syndrome=0x6
> >> (XEN) Walking Hypervisor VA 0x467a28bc on CPU0 via TTBR 0x00000000481d5000
> > I can understnad that if we don't substract GUEST_VPCI_ECAM, we would (in theory) not get the correct BDF. But... I don't understand how this would result to a data abort in the hypervisor.
> >
> > In fact, I think the vPCI code should be resilient enough to not crash if we pass the wrong BDF.
> Well, there is no (?) easy way to validate SBDF. And this could be a problem if we have a misbehaving
> guest which may force Xen to access the memory beyond that of PCI host bridge

How could that be? The ECAM region exposed to the guest you should be
the same as the physical one for dom0?

And for domUs you really need to fix vpci_{read,write} to not
passthrough accesses not explicitly handled.

> > When there is a data abort in Xen, you should get a stack trace from where this comes from. Can you paste it here?
> (XEN) Data Abort Trap. Syndrome=0x6
> (XEN) Walking Hypervisor VA 0x467a28bc on CPU0 via TTBR 0x00000000481d5000
> (XEN) 0TH[0x0] = 0x00000000481d4f7f
> (XEN) 1ST[0x1] = 0x00000000481d2f7f
> (XEN) 2ND[0x33] = 0x0000000000000000
> (XEN) CPU0: Unexpected Trap: Data Abort
> (XEN) ----[ Xen-4.16-unstable  arm64  debug=y  Not tainted ]----
> (XEN) CPU:    0
> (XEN) PC:     000000000026d3d4 pci_generic_config_read+0x88/0x9c
> (XEN) LR:     000000000026d36c
> (XEN) SP:     000080007ff97c00
> (XEN) CPSR:   0000000060400249 MODE:64-bit EL2h (Hypervisor, handler)
> (XEN)      X0: 00000000467a28bc  X1: 00000000065d08bc  X2: 00000000000008bc
> (XEN)      X3: 000000000000000c  X4: 000080007ffc6fd0  X5: 0000000000000000
> (XEN)      X6: 0000000000000014  X7: ffff800011a58000  X8: ffff0000225a0380
> (XEN)      X9: 0000000000000000 X10: 0101010101010101 X11: 0000000000000028
> (XEN)     X12: 0101010101010101 X13: 0000000000000020 X14: ffffffffffffffff
> (XEN)     X15: 0000000000000001 X16: ffff800010da6708 X17: 0000000000000020
> (XEN)     X18: 0000000000000002 X19: 0000000000000004 X20: 000080007ff97c5c
> (XEN)     X21: 00000000000008bc X22: 00000000000008bc X23: 0000000000000004
> (XEN)     X24: 0000000000000000 X25: 00000000000008bc X26: 00000000000065d0
> (XEN)     X27: 000080007ffb9010 X28: 0000000000000000  FP: 000080007ff97c00
> (XEN)
> (XEN)   VTCR_EL2: 00000000800a3558
> (XEN)  VTTBR_EL2: 00010000bffba000
> (XEN)
> (XEN)  SCTLR_EL2: 0000000030cd183d
> (XEN)    HCR_EL2: 00000000807c663f
> (XEN)  TTBR0_EL2: 00000000481d5000
> (XEN)
> (XEN)    ESR_EL2: 0000000096000006
> (XEN)  HPFAR_EL2: 0000000000e65d00
> (XEN)    FAR_EL2: 00000000467a28bc
> (XEN)
> [snip]
> (XEN) Xen call trace:
> (XEN)    [<000000000026d3d4>] pci_generic_config_read+0x88/0x9c (PC)
> (XEN)    [<000000000026d36c>] pci_generic_config_read+0x20/0x9c (LR)
> (XEN)    [<000000000026d2c8>] pci-access.c#pci_config_read+0x60/0x84
> (XEN)    [<000000000026d4a8>] pci_conf_read32+0x10/0x18
> (XEN)    [<000000000024dcf8>] vpci.c#vpci_read_hw+0x48/0xb8
> (XEN)    [<000000000024e3e4>] vpci_read+0xac/0x24c
> (XEN)    [<000000000024e934>] vpci_ecam_read+0x78/0xa8
> (XEN)    [<000000000026e368>] vpci.c#vpci_mmio_read+0x44/0x7c
> (XEN)    [<0000000000275054>] try_handle_mmio+0x1ec/0x264
> (XEN)    [<000000000027ea50>] traps.c#do_trap_stage2_abort_guest+0x18c/0x2d8
> (XEN)    [<000000000027f088>] do_trap_guest_sync+0xf0/0x618
> (XEN)    [<0000000000269c58>] entry.o#guest_sync_slowpath+0xa4/0xd4
> (XEN)
> (XEN)
> (XEN) ****************************************
> (XEN) Panic on CPU 0:
> (XEN) CPU0: Unexpected Trap: Data Abort
> (XEN) ****************************************

Are you exposing an ECAM region to the guest bigger than the
underlying one, and that's why you get crashes? (because you get out of
the hardware range)

I would assume physical accesses to the ECAM area reported by the
hardware don't trigger traps?

Roger.


From xen-devel-bounces@lists.xenproject.org Thu Oct 28 13:55:09 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Oct 2021 13:55:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.218057.378339 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg5rp-0002xx-E6; Thu, 28 Oct 2021 13:54:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 218057.378339; Thu, 28 Oct 2021 13:54:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg5rp-0002xq-BG; Thu, 28 Oct 2021 13:54:53 +0000
Received: by outflank-mailman (input) for mailman id 218057;
 Thu, 28 Oct 2021 13:54:52 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mg5ro-0002xk-0o
 for xen-devel@lists.xenproject.org; Thu, 28 Oct 2021 13:54:52 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mg5rm-0000BM-2F; Thu, 28 Oct 2021 13:54:50 +0000
Received: from 54-240-197-225.amazon.com ([54.240.197.225] helo=[10.7.236.13])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mg5rl-0003pg-RP; Thu, 28 Oct 2021 13:54:49 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=ZSGZqzfT5vAhsS+EOmQ9PiDOya2zVesOw3BdOVIRcmU=; b=q7waaba8jwwYOpQFwUfXNL91u0
	Uy0CrhVJj2Ce3dR6flM7AnG9EwwGZSLvGkKa3oy27dkfV9yrcL1GPWRCQkYsFpKsH3BT8ozxoTtG8
	CtzQLZSik7jC7gj/2/XUJNDk9XpEN83k8sabRWkJ4Lw0XuLojqMYFy9fsKWByAc/Jg/g=;
Message-ID: <5bd3b7e3-5193-4d16-5d3a-950d973e664d@xen.org>
Date: Thu, 28 Oct 2021 14:54:47 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.2.1
Subject: Re: [patch-4.16] arm/smmuv1,v2: Protect smmu master list with a lock
To: Michal Orzel <michal.orzel@arm.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Julien Grall <julien.grall.oss@gmail.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>, Ian Jackson <iwj@xenproject.org>
References: <20211026122903.15042-1-michal.orzel@arm.com>
 <e5632a4e-db98-41b4-1045-2b3532c098fa@xen.org>
 <70c30a6c-b779-805e-079a-41bb484894b9@xen.org>
 <cb452c0c-ccde-7798-c403-f972b48a2c46@arm.com>
 <01545115-e82e-2a9d-a8e4-da9676080c0f@xen.org>
 <alpine.DEB.2.21.2110271557570.20134@sstabellini-ThinkPad-T480s>
 <CAJ=z9a2SSgG7a87_xTGT5LeNLgubOLQf1+dbnrsTsP8_p5ErJg@mail.gmail.com>
 <alpine.DEB.2.21.2110271658330.20134@sstabellini-ThinkPad-T480s>
 <4554621d-63da-ea3e-e56a-4e01d0cef347@xen.org>
 <560e75eb-fa0d-a13a-219c-3c1db0b28fa1@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <560e75eb-fa0d-a13a-219c-3c1db0b28fa1@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit



On 28/10/2021 13:15, Michal Orzel wrote:
> Hi Julien,

Hi Michal,

> On 28.10.2021 12:05, Julien Grall wrote:
> The purpose of this patch is to fix the issue that is present in 4.16.

I think this is a latent bug (see more below).

> The patch adding support for removal you are reffering to:
> -is in RFC state
> -is not meant for 4.16
> -will need to be modified anyway because of the future PCI passthrough patches that are going to modify lots of stuff
> 
> That being said, the bug we want to fix touches only point 1). And in fact my patch is solving this issue.
> So I think we should focus on 4.16 and fixing bugs for it without thinking of future patches/modifications.

I would have agreed with your reasoning if this bug could be triggered 
with Xen 4.16 out-of-box. AFAIK, this is not the case because PCI 
devices cannot be registered with the SMMU driver.

> I agree that the locking behaviour will change as soon as the patch you are reffering to will be merged.
> However, the PCI passthrough patches are going to modify this code anyway, so all in all the future modifications will be needed.

Right. PCI passthrough is not going to work in 4.16 whether this patch 
is merged or not. We are past the code freeze and as you said the code 
(and potentially the locking) is going to be reworked for PCI passthrough.

So, I think this is a bad idea to rush this patch in 4.16. Instead, we 
should focus on getting a consistent locking for 4.17 that would cover 
the removal part and all PCI and DT concurrent call.

To be clear, I am not expecting you to implement the both part. I am 
fine if you focus only on the latter. But first, we need to agree on the 
approach (see my 2 proposals sent earlier).

Regarding the patch itself, I will be happy to queue the patch when it 
is fully ready and merge it after the tree is re-opened for 4.17.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Thu Oct 28 14:08:13 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Oct 2021 14:08:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.218065.378349 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg64Z-0004er-Ir; Thu, 28 Oct 2021 14:08:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 218065.378349; Thu, 28 Oct 2021 14:08:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg64Z-0004ek-Ft; Thu, 28 Oct 2021 14:08:03 +0000
Received: by outflank-mailman (input) for mailman id 218065;
 Thu, 28 Oct 2021 14:08:02 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mg64Y-0004ec-II
 for xen-devel@lists.xenproject.org; Thu, 28 Oct 2021 14:08:02 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mg64Y-0000W3-GX
 for xen-devel@lists.xenproject.org; Thu, 28 Oct 2021 14:08:02 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mg64Y-0004wW-FV
 for xen-devel@lists.xenproject.org; Thu, 28 Oct 2021 14:08:02 +0000
Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89)
 (envelope-from <iwj@xenproject.org>)
 id 1mg64Q-0002Iu-6U; Thu, 28 Oct 2021 15:07:54 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date
	:Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From;
	bh=rGbI1nrbEtRmTuOQzyt+xuWb0qGYgmHYv+GOx5TdSAM=; b=uvYds+3CwPADEzYOQcLJtIlsMS
	XK9z/LbIS68NWpAwKRy90bvaV3TUtxFjwAilaelZn1xNIwIbVh2YadVMyOJc+k2cndHyE9lKBRThm
	XRzxNmlIDiuKakBRHN1BfY+OBBzL3hoJN9Ws2DWShoCmnnCCctFsaeSHKuqjlraPw46M=;
From: Ian Jackson <iwj@xenproject.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <24954.44729.11634.91132@mariner.uk.xensource.com>
Date: Thu, 28 Oct 2021 15:07:53 +0100
To: Julien Grall <julien@xen.org>
Cc: Michal Orzel <michal.orzel@arm.com>,
    Stefano Stabellini <sstabellini@kernel.org>,
    Julien Grall <julien.grall.oss@gmail.com>,
    xen-devel <xen-devel@lists.xenproject.org>,
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
    Bertrand Marquis <bertrand.marquis@arm.com>
Subject: Re: [patch-4.16] arm/smmuv1,v2: Protect smmu master list with a lock
In-Reply-To: <5bd3b7e3-5193-4d16-5d3a-950d973e664d@xen.org>
References: <20211026122903.15042-1-michal.orzel@arm.com>
	<e5632a4e-db98-41b4-1045-2b3532c098fa@xen.org>
	<70c30a6c-b779-805e-079a-41bb484894b9@xen.org>
	<cb452c0c-ccde-7798-c403-f972b48a2c46@arm.com>
	<01545115-e82e-2a9d-a8e4-da9676080c0f@xen.org>
	<alpine.DEB.2.21.2110271557570.20134@sstabellini-ThinkPad-T480s>
	<CAJ=z9a2SSgG7a87_xTGT5LeNLgubOLQf1+dbnrsTsP8_p5ErJg@mail.gmail.com>
	<alpine.DEB.2.21.2110271658330.20134@sstabellini-ThinkPad-T480s>
	<4554621d-63da-ea3e-e56a-4e01d0cef347@xen.org>
	<560e75eb-fa0d-a13a-219c-3c1db0b28fa1@arm.com>
	<5bd3b7e3-5193-4d16-5d3a-950d973e664d@xen.org>
X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu)

Julien Grall writes ("Re: [patch-4.16] arm/smmuv1,v2: Protect smmu master list with a lock"):
> Right. PCI passthrough is not going to work in 4.16 whether this patch 
> is merged or not. We are past the code freeze and as you said the code 
> (and potentially the locking) is going to be reworked for PCI passthrough.
> 
> So, I think this is a bad idea to rush this patch in 4.16. Instead, we 
> should focus on getting a consistent locking for 4.17 that would cover 
> the removal part and all PCI and DT concurrent call.

Thanks for this clear communication.  As the release manager I very
much appreciate it.  Michal, do you disagree with Julien's analysis ?

If not, I would like to take this patch off my list of stuff I have on
my radar for 4.16.

Thanks,
Ian.


From xen-devel-bounces@lists.xenproject.org Thu Oct 28 14:11:36 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Oct 2021 14:11:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.218071.378360 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg67a-00066e-13; Thu, 28 Oct 2021 14:11:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 218071.378360; Thu, 28 Oct 2021 14:11:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg67Z-00066X-UM; Thu, 28 Oct 2021 14:11:09 +0000
Received: by outflank-mailman (input) for mailman id 218071;
 Thu, 28 Oct 2021 14:11:08 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mg67Y-00066R-Gj
 for xen-devel@lists.xenproject.org; Thu, 28 Oct 2021 14:11:08 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mg67Y-0000aQ-FI
 for xen-devel@lists.xenproject.org; Thu, 28 Oct 2021 14:11:08 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mg67Y-0005Il-Ea
 for xen-devel@lists.xenproject.org; Thu, 28 Oct 2021 14:11:08 +0000
Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89)
 (envelope-from <iwj@xenproject.org>)
 id 1mg67U-0002Ju-PF; Thu, 28 Oct 2021 15:11:04 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date
	:Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From;
	bh=686+/GwBsuXxkPZS/sCU+xH1FdRwq4PT+JCTmnLo+sU=; b=qYmo0APZXPGiPX4B86oZndbx4/
	oszeBcCFcpSTUSK5aGIp0YMUiqSq3HiE1BVOg5AKdmcMWXOU8M2ZbmhjwY2G2VYjTrZltyIdi/nQe
	wr/NeyN2Nhb9fHdmJhGEfx5pLrX25Ozq85RrvkHWAOtZ0DksBUjmyPjHmC7gNX6x5e+s=;
From: Ian Jackson <iwj@xenproject.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
Message-ID: <24954.44919.8320.63375@mariner.uk.xensource.com>
Date: Thu, 28 Oct 2021 15:11:03 +0100
To: Roger Pau =?iso-8859-1?Q?Monn=E9?= <roger.pau@citrix.com>
Cc: <xen-devel@lists.xenproject.org>,
    Wei Liu <wl@xen.org>,
    Andrew Cooper <andrew.cooper3@citrix.com>,
    George Dunlap <george.dunlap@citrix.com>,
    Jan  Beulich <jbeulich@suse.com>,
    Julien Grall <julien@xen.org>,
    Stefano  Stabellini <sstabellini@kernel.org>,
    Anthony PERARD <anthony.perard@citrix.com>,
    Juergen Gross <jgross@suse.com>,
    Christian  Lindig <christian.lindig@citrix.com>,
    David Scott <dave@recoil.org>,
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH for-4.16 v3] gnttab: allow setting max version per-domain
In-Reply-To: <YXqfk4tj30EmbSEt@Air-de-Roger>
References: <20211028095923.83982-1-roger.pau@citrix.com>
	<24954.37807.277003.373593@mariner.uk.xensource.com>
	<YXqfk4tj30EmbSEt@Air-de-Roger>
X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu)

Roger Pau Monn� writes ("Re: [PATCH for-4.16 v3] gnttab: allow setting max version per-domain"):
> Would you like me to this to the commit message:
> 
> "xenstored stubdomains are limited to grant table v1 because the
> current MiniOS code used to build them only has support for grants v1.
> There are existing limits set for xenstored stubdomains at creation
> time that already match the defaults in MiniOS."

Yes, please.

> > I am not sure about the implications for migration.  Might using this
> > cause migration to fail for some guests ?
> > 
> >    Note that when using the default grant version the specific max
> >    version in use by the domain is not migrated. Any guests should be
> >    able to cope with the max grant version changing across migrations,
> >    and if a specific guest relies on a maximum grant version being
> >    unconditionally available it should be specified on the configuration
> >    file.
> > 
> > Only if the feature is *not* used, I guess.  Ie, this is the status
> > quo.   So I don't think there is any release risk there.
> 
> This was raised by Jan in a previous version, the discussion can be
> found here:
> 
> https://lore.kernel.org/xen-devel/0b58667f-b6bc-d5b5-2dd1-0c8996367319@suse.com/
> 
> The issue could arise if a guest that strictly needs grant v2 is
> migrated from a host that has v2 as the default max version to another
> box that has v1 as the max version. If the guest config file doesn't
> explicitly specify that the guest requires grant v2 migration will
> succeed, but the guest will likely fail to resume properly.
> 
> This is already the current behavior if a guest is migrated from a
> host not having gnttab=max-ver set to one having gnttab=max-ver:1.

Right.  I don't think this is the correct behaviour but the patch is
moving in the right direction.

> > If we can get good answers to all of this, ideally I would like to see
> > this committed by the end of tomorrow.  I plan to cut RC1 on Monday.

Thanks.


Tools ack: with the commit message change discussed above,

Reviewed-by: Ian Jackson <iwj@xenproject.org>


I have no further release concerns but a formal release-ack will have
to wait for review of the ocaml parts.

Ian.


From xen-devel-bounces@lists.xenproject.org Thu Oct 28 14:16:20 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Oct 2021 14:16:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.218078.378372 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg6CR-0006mL-LA; Thu, 28 Oct 2021 14:16:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 218078.378372; Thu, 28 Oct 2021 14:16:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg6CR-0006mE-I2; Thu, 28 Oct 2021 14:16:11 +0000
Received: by outflank-mailman (input) for mailman id 218078;
 Thu, 28 Oct 2021 14:16:10 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ikAZ=PQ=epam.com=prvs=19352d112c=oleksandr_andrushchenko@srs-us1.protection.inumbo.net>)
 id 1mg6CQ-0006m8-2E
 for xen-devel@lists.xenproject.org; Thu, 28 Oct 2021 14:16:10 +0000
Received: from mx0a-0039f301.pphosted.com (unknown [148.163.133.242])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 75d29d13-2a0c-49d9-bd25-1e1cd124e8d0;
 Thu, 28 Oct 2021 14:16:07 +0000 (UTC)
Received: from pps.filterd (m0174677.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 19SE963T030246; 
 Thu, 28 Oct 2021 14:16:05 GMT
Received: from eur03-db5-obe.outbound.protection.outlook.com
 (mail-db5eur03lp2058.outbound.protection.outlook.com [104.47.10.58])
 by mx0a-0039f301.pphosted.com with ESMTP id 3bywcd01be-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Thu, 28 Oct 2021 14:16:05 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by AM9PR03MB6963.eurprd03.prod.outlook.com (2603:10a6:20b:2d5::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.14; Thu, 28 Oct
 2021 14:16:02 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::c038:e032:595a:651]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::c038:e032:595a:651%9]) with mapi id 15.20.4649.015; Thu, 28 Oct 2021
 14:16:02 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 75d29d13-2a0c-49d9-bd25-1e1cd124e8d0
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=enrqpxI6T5iA7pLnTAQSd1Exy+gS+XfPmos1uUV3SNpflYkYj7n5gIYUvvqobK4+Q7J8Mn25lw97YXZAenY9GYaRO3cBzFIHmXidxo8fFwMCfsDg2uffu9ijsn3PMQ5BeWD+7/HEy7Nz9ZN0vUQW028KqEkzjBA/PdT5X1SSQ+OBT53wWsltvQvA7YYobY3DQvYN++3NxrzRb0E5MI5y8VsNsr5jjIoKrq/kct34k3kWyZmbjvrfXzxWCweUS4E5rZDzj6Y8M7FtSGy/TD21RrzIFNO0ZtHWNdBsx7WHR0pP7eu8IyT1P2ZEuXMdzJm1qTxS2UgWp6oOb7CNSK+1dA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=YeVa6WyfW6WLKqGpv0QIgGb1PoLtq1h7iG9lzPDI5+g=;
 b=eLGnXWaU9VkFdzg0c5+bkFlJHW814ZtzS8NmBkPjsgG3Tk6yT3yAR2pCNunL5o4u5aqQ9qkmNcMU5BHg1NVJZ0AN9Md0oc/S2nsltnc404Auc5SdjVpOxv7eqp/xhSAmbXtqKhT+xaFZbinvuWQqn6BVrHUAq/Y2zxkuQK5wrbuJQDI0QstMiO/kKs/Ddghp+lI5ACIV1Z73yolT+fRRpURWAowupWmPXBRxjdLv38UqcPg7ZSYMBGYXgSO87VZq862yRcbzSDA73Jwp5I6Ujs2xvfENtvreCHfl/aZfb7QEe4IC6Z0oEZpSy8HzUmfyuppCHjZPY/kADekUQ6sNnw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=YeVa6WyfW6WLKqGpv0QIgGb1PoLtq1h7iG9lzPDI5+g=;
 b=oD6lagdz/TWY8vfZgXgDUR7o9UA+tf4vbhQq8+JwaXfhLLrvoBp6ATEePdF9ZsJsqofRZluDwFa5ihXHSfG+E/nfNQNgrpbG+OLGvsREQOcQSSFemB8NRwIUr78rjVgQmgJUfNMExUTfAmdi0N/Ms9ozlr7XfmEAvAtphtxtVMVwNdrhVj+tusi4/uIVBYvxPiNokEeThRDQjf8Ireus4wpx3507CYaULSxMWFsXyGNG1e/zdruV7SuDBwoPFJNaA1Fr0wUbAMEr9nWPicBZb/vcq19F+JuDPNVwVCXw7NPd6jwM0esiEVKcZJzI8vgiekL7rFrAGUyNJog+99JSiw==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Julien Grall <julien@xen.org>,
        "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: "sstabellini@kernel.org" <sstabellini@kernel.org>,
        "iwj@xenproject.org"
	<iwj@xenproject.org>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Rahul
 Singh <rahul.singh@arm.com>
Subject: Re: [PATCH] xen/arm: fix SBDF calculation for vPCI MMIO handlers
Thread-Topic: [PATCH] xen/arm: fix SBDF calculation for vPCI MMIO handlers
Thread-Index: AQHXyww6rKHs3LJru0q52eLUia+oNavnHBIAgAE3H4CAABSQgIAADtGA
Date: Thu, 28 Oct 2021 14:16:02 +0000
Message-ID: <b6bb02b6-6358-b5e0-1b80-7819aadabe10@epam.com>
References: <20211027082533.1406015-1-andr2000@gmail.com>
 <cb7e9ef7-476e-93c3-d3c9-9a9ebc61003d@xen.org>
 <d63c6e0b-8aa3-9ba3-893c-5e464638a8db@epam.com>
 <65886734-7333-4469-fcc1-6916db708f13@xen.org>
In-Reply-To: <65886734-7333-4469-fcc1-6916db708f13@xen.org>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 7b3ec9ad-a753-4d0f-b67c-08d99a1d7918
x-ms-traffictypediagnostic: AM9PR03MB6963:
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <AM9PR03MB6963E21A348EAE0946E8D5E3E7869@AM9PR03MB6963.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 n5eHIZVtWKBK611FMH7DM9713+eFbVKSGTTEa/ymeYw2Y//aOBY23h2rQA58QC2haW1XscFOez8HXnHxUxWvS25hfATq1qhdkcTmV/HpjKdANtyI98g544RjlBCwGyBMGA8vjM5V81oKre93P29YyQvS7UN+JeDYqxKjGEqmkjPU5x88Gbbi+TYrCNYEAo8ygyncZGNry3rcX+ruFkR4OgbuoK5S4WW1nXAFJ7ihZFKxXp+DgiNPdHqad5AJB178tp6yVj55tHR0EqpaC6DxroV9Nx/9ta5awzwYz1r25NrsPa50odo/GY+3vvywS4E6M3pujg2qdpJyjQbfybXLMCy+YvJjGuOrXZsQvRPvydSxADk41vSEvhgUTwUjE2rUURCaT7Yiu38QXUhcRn5JPfiU8SkeL0qEi8eM4Km+XiBtDGfCi8mHl2+LE5Q/8qvf9Py+HJbKnn8dEP1yCgtfv4jid0LD4Ss3+VFHiPtwtNc1V76nEwyGDDsJViUEWJMPpjk8IMWDHDQg9daw7XgrINKM2Knl9pCIkdD7WusmlkIP/jyckeNBt3G0IhkE4evBnAyvHT7ADjANRufb90dmehfsfarM6W96xFvPAn0lstvfZ/Pyqs7vI4FlKc6jLpg7gyo6KVOJOlnbqFFtNdjK3fr8k2BZjT2WfZlp5k3DCZICtC5RP7IykoGC6DBIhaZleLOJQkRfxUaIheP+ML3ICZxS0UUJ/zhl+JMIybwdhkWfkIKy3LS0CaQd9b5vB9ur
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(6486002)(316002)(54906003)(26005)(186003)(110136005)(36756003)(31696002)(86362001)(2906002)(5660300002)(38070700005)(6512007)(53546011)(64756008)(66946007)(31686004)(71200400001)(91956017)(76116006)(4326008)(8936002)(508600001)(2616005)(122000001)(83380400001)(6506007)(66476007)(8676002)(38100700002)(66556008)(66446008)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?M2tIZ2crOHMvQ2xUekdRU0RBV0NCQ09FQ1BCWVV0VExjeDNQakgrcnRWdUpw?=
 =?utf-8?B?T1Y2TWNhNzZ1UEZmeHJRbm9WeGhyaTJzWkp0L0d0T0RTUDNqc2R2bElwb3pO?=
 =?utf-8?B?SUluMmhKb0oycHFUZmloVnFWbG14VTM1S1VSK2gzL3ZVcmVWY3d5L2ZoRXUx?=
 =?utf-8?B?V1l3Q1pOZHNtdFJnemUrcE9lU0dxaEtzZ1ZyeW9LdkRQRHladmlXTi93Mjcw?=
 =?utf-8?B?NmtHVDllbWN0UW1IRC9sbis3dlFCRWJiV1R5L0Nqd0Z1MG43UHh2MkxNOEJY?=
 =?utf-8?B?N2xMUklOakZyTTViQWJoVDEyUUwrYXdMYVZPL3F3eFl1STluTE9hVlVqWDdh?=
 =?utf-8?B?dU9UWUNudjVLRFVxU1NCNmhSSEZpT0JPcGtjY041RjlWd3RXSUY2VHB1UXl5?=
 =?utf-8?B?SkxQSnR3RlprUSt1T2I2RkJsZUw4NEdnZUprRmpTREJaczUvU3p3cDdlQWNx?=
 =?utf-8?B?UzZTazZxU2FVam5VTXh6NE9kT05laXJXTGkrcXF0c0EyRUFWcUJzYVV0dGhm?=
 =?utf-8?B?bUJGUTNLNUF3TWdPZnR4d3Uwc04zVVNVY3lYd1g4ekN4eXdjdHdkamdKWWNu?=
 =?utf-8?B?RExsbHFWeThiWlJ5YlNLNHRLMUpHcnBKUENoc29tZDFjSkRMVzNLZ0NXSi9H?=
 =?utf-8?B?czRSV0xzWGdVeklGRlVjL0wzSmFzZW1DMXhLV1VEdVZ0OHdza09pbHlHaXcr?=
 =?utf-8?B?dkxlVVRJYjBhODNmM2FTOFIxRjhWanNPYkpZTTd5MXFaeGlhSDZWT1dkM2FS?=
 =?utf-8?B?bjRjVytiRFRaZmMzU3B3QjgzMkozYS9Nci9sTk56dVFMeTIwT25temF5NWdu?=
 =?utf-8?B?WFFNdGJKclZpbWI2Uys5SWluK1B5TEZ3NlRvRElaRUJvN0lvTTVvMk9JZVNF?=
 =?utf-8?B?dzM1UUxQcjNOalV0TlpHTm1UcDhmNFovRDFVR2ZlVWViRkdwZFVoTHFrUVJY?=
 =?utf-8?B?ZER6U1BDbjhVS2lLVzVYRndEZnQ3aWVvcDNZWEhaWGl1dytteFFRMHlabFRZ?=
 =?utf-8?B?dDJPa2svWUFHd2FBTmFBT0JSK0QxdWNPR0dFN0VkMFJ0SUpGNmdRWjBwbXVk?=
 =?utf-8?B?YjZ4UGF3NHVhd0dRMTByWStXNE9OcUkxTW85VjVHQ3hNMmF2N3NlNFViWVZi?=
 =?utf-8?B?NjJZdnZHSG9mU1ZxVzByeHJuRXBYMjhBNjJIaWtRVFBhOVhSSFFzdGtId3VK?=
 =?utf-8?B?Z1lIK1ZhWGhZMU8xc2tkZVdmMjlZaStrN0h4elpvZ2NSRURvRXpjV1c4M0tH?=
 =?utf-8?B?VHpMU3F5U1A4eWo5cytKaTdaNUJEMTZUN0RZdHhqaVd6eDh3YTlJYUlBekxo?=
 =?utf-8?B?Z1gyem1ObmFFR2dKemtiWkFEUUFxSmZwV2U3VCtrZWplaG5hdnkzM2N6TVIz?=
 =?utf-8?B?R1gxYkh1L1dTeG1kQkRSZ3RZb29nSzFZa1NIK0dWYU4rRnk1L25PUndDOXdE?=
 =?utf-8?B?WWlaL0kzNEg1UUhXK3Nwelo1VTRIaklrVkozOHZmdXFxd2JSTENXME1OMkxF?=
 =?utf-8?B?YzU2TDFlbk5iQWFVN1M4anZJNi9VQW1RT2tNZXRhN0FCSzliRUtIUlpMV0kv?=
 =?utf-8?B?THIvbGR3eGZCN3ZlR2thaElSZXNQdDBsWjJOZkVsUjNqamswdWduTkxLcXdn?=
 =?utf-8?B?a3VxZmdHZ21XK2lTOVNDcTdwN2hpYUQ0QVRBUGMxWkI3VlM1eDN5aXh2Q1FC?=
 =?utf-8?B?T09HK1Z0R2Y4RDlSYmcySjNXRE15Y2thRCtPY0tuSFJEWkNzR2JRcXRETExI?=
 =?utf-8?B?Q3p0eW5kT28ycjlsc0VURGFVbHMyTHhJcWhuaUxCQnVJTDdRVy9Sb3UrTEow?=
 =?utf-8?B?MFQ4STN0aStKZDhqV05BUWcxSWhwZDlUZ0pFZUpIbUIzSm81VzYrczBTNXFr?=
 =?utf-8?B?Y3FicXp1bmRNamhNUU5qTitWVE9sS3ZHL0pReEh4bVhTTVNRU3RrOXZJdjJp?=
 =?utf-8?B?TThMbTYwcFVuTlY3bW1OSEtSQ2Y1UkhDQ0owSjhYVjZiWFJPbGRuQ2wrSUJQ?=
 =?utf-8?B?M2U0VnloU05oQnZFRHI1VXdVb21rTUF0cW9GYjlJM096UjE5ZW9RWE9RVWpT?=
 =?utf-8?B?Q0w4Q0EwUm93bm5PQ1pQajZpUksvL05hM1hSWkQ5WUxZM3UzeXBQQkRHZXly?=
 =?utf-8?B?RlkzUzRBZVpobWk5YTVMN2RSZ2xnaEZHNUtRTXdERUlqRUVocDVoeVBMRGlI?=
 =?utf-8?B?bnRPL1IvdFNhdmVldXM2NEZna1dXd01GRlA0VGxFdnE3T2FXZkRpWlNvRGQ0?=
 =?utf-8?B?VjJJQnZPWE83QlBvOWlkOUZmNGsrd2FyRU5pU09vN2doeWw0VmZUeHJ6a1ox?=
 =?utf-8?B?aVhialhLd3ZqeWZNemNIbzVKWWpST2R5ejQ4TWZ2SXp3MDRtK3NJZz09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <44BE859F689E504ABFAC04855B8984B9@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7b3ec9ad-a753-4d0f-b67c-08d99a1d7918
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Oct 2021 14:16:02.4673
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: toT28DVwC9NKLG37dN5fyC9bPoGFJrKOmN14ogyiFHhqsXLTf+DlYsEya4frWRVIhtR5kexSKb6pViNk2seae+3iKtDI9WzqOpKH1QqCuC1rkBc2Q9MGlTR1qa1QQMda
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR03MB6963
X-Proofpoint-GUID: dCW4Wx4p6R-YvKjDsMK-JZR4GiUUvdm7
X-Proofpoint-ORIG-GUID: dCW4Wx4p6R-YvKjDsMK-JZR4GiUUvdm7
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475
 definitions=2021-10-28_01,2021-10-26_01,2020-04-07_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501
 phishscore=0 mlxlogscore=999 suspectscore=0 bulkscore=0 lowpriorityscore=0
 spamscore=0 impostorscore=0 malwarescore=0 clxscore=1015 adultscore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2110280080

DQoNCk9uIDI4LjEwLjIxIDE2OjIyLCBKdWxpZW4gR3JhbGwgd3JvdGU6DQo+IE9uIDI4LzEwLzIw
MjEgMTM6MDksIE9sZWtzYW5kciBBbmRydXNoY2hlbmtvIHdyb3RlOg0KPj4gSGksIEp1bGllbiEN
Cj4NCj4gSGVsbG8sDQo+DQo+PiBPbiAyNy4xMC4yMSAyMDozNSwgSnVsaWVuIEdyYWxsIHdyb3Rl
Og0KPj4+IEhpIE9sZWtzYW5kciwNCj4+Pg0KPj4+IE9uIDI3LzEwLzIwMjEgMDk6MjUsIE9sZWtz
YW5kciBBbmRydXNoY2hlbmtvIHdyb3RlOg0KPj4+PiBGcm9tOiBPbGVrc2FuZHIgQW5kcnVzaGNo
ZW5rbyA8b2xla3NhbmRyX2FuZHJ1c2hjaGVua29AZXBhbS5jb20+DQo+Pj4+DQo+Pj4+IFdoaWxl
IGluIHZQQ0kgTU1JTyB0cmFwIGhhbmRsZXJzIGZvciB0aGUgZ3Vlc3QgUENJIGhvc3QgYnJpZGdl
IGl0IGlzIG5vdA0KPj4+PiBlbm91Z2ggZm9yIFNCREYgdHJhbnNsYXRpb24gdG8gc2ltcGx5IGNh
bGwgVlBDSV9FQ0FNX0JERihpbmZvLT5ncGEpIGFzDQo+Pj4+IHRoZSBiYXNlIGFkZHJlc3MgbWF5
IG5vdCBiZSBhbGlnbmVkIGluIHRoZSB3YXkgdGhhdCB0aGUgdHJhbnNsYXRpb24NCj4+Pj4gYWx3
YXlzIHdvcmsuIElmIG5vdCBhZGp1c3RlZCB3aXRoIHJlc3BlY3QgdG8gdGhlIGJhc2UgYWRkcmVz
cyBpdCBtYXkgbm90IGJlDQo+Pj4+IGFibGUgdG8gcHJvcGVybHkgY29udmVydCBTQkRGIGFuZCBj
cmFzaGVzOg0KPj4+Pg0KPj4+PiAoWEVOKSB2cGNpX21taW9fcmVhZCAwMDAwOjY1OjFhLjAgcmVn
IDhiYyBncGEgZTY1ZDA4YmMNCj4+Pg0KPj4+IEkgY2FuJ3QgZmluZCBhIHByaW50aygpIHRoYXQg
bWF5IG91dHB1dCB0aGlzIG1lc3NhZ2UuIFdoZXJlIGRvZXMgdGhpcyBjb21lcyBmcm9tPw0KPj4g
VGhhdCB3YXMgYSBkZWJ1ZyBwcmludC4gSSBzaG91bGRuJ3QgaGF2ZSB1c2VkIHRoYXQgaW4gdGhl
IHBhdGNoIGRlc2NyaXB0aW9uLCBidXQNCj4+IHByb2JhYmx5IGFmdGVyICItLS0iIHRvIGJldHRl
ciBleHBsYWluIHdoYXQncyBoYXBwZW5pbmcNCj4+Pg0KPj4+IEFueXdheSwgSUlVQyB0aGUgZ3Vl
c3QgcGh5c2ljYWwgYWRkcmVzcyBpcyAweGU2NWQwOGJjIHdoaWNoLCBpZiBJIGFtIG5vdCBtaXN0
YWtlbiwgZG9lc24ndCBiZWxvbmcgdG8gdGhlIHJhbmdlIGFkdmVydGlzZWQgZm9yIEdVRVNUX1ZQ
Q0lfRUNBTS4NCj4+IFRoaXMgaXMgZnJvbSBkb20wIEkgYW0gd29ya2luZyBvbiBub3cuDQo+Pj4N
Cj4+PiBJTUhPLCB0aGUgc3RhY2sgdHJhY2Ugc2hvdWxkIGNvbWUgZnJvbSB1c3B0cmVhbSBYZW4g
b3IgbmVlZCBzb21lIGluZm9ybWF0aW9uIHRvIGV4cGxhaW4gaG93IHRoaXMgd2FzIHJlcHJvZHVj
ZWQuDQo+Pj4NCj4+Pj4gKFhFTikgRGF0YSBBYm9ydCBUcmFwLiBTeW5kcm9tZT0weDYNCj4+Pj4g
KFhFTikgV2Fsa2luZyBIeXBlcnZpc29yIFZBIDB4NDY3YTI4YmMgb24gQ1BVMCB2aWEgVFRCUiAw
eDAwMDAwMDAwNDgxZDUwMDANCj4+PiBJIGNhbiB1bmRlcnN0bmFkIHRoYXQgaWYgd2UgZG9uJ3Qg
c3Vic3RyYWN0IEdVRVNUX1ZQQ0lfRUNBTSwgd2Ugd291bGQgKGluIHRoZW9yeSkgbm90IGdldCB0
aGUgY29ycmVjdCBCREYuIEJ1dC4uLiBJIGRvbid0IHVuZGVyc3RhbmQgaG93IHRoaXMgd291bGQg
cmVzdWx0IHRvIGEgZGF0YSBhYm9ydCBpbiB0aGUgaHlwZXJ2aXNvci4NCj4+Pg0KPj4+IEluIGZh
Y3QsIEkgdGhpbmsgdGhlIHZQQ0kgY29kZSBzaG91bGQgYmUgcmVzaWxpZW50IGVub3VnaCB0byBu
b3QgY3Jhc2ggaWYgd2UgcGFzcyB0aGUgd3JvbmcgQkRGLg0KPj4gV2VsbCwgdGhlcmUgaXMgbm8g
KD8pIGVhc3kgd2F5IHRvIHZhbGlkYXRlIFNCREYuDQo+DQo+IEFGQUlDVCBwY2lfZWNhbV9tYXBf
YnVzKCkgaXMgYWxyZWFkeSBkb2luZyBzb21lIHZhbGlkYXRpb24gZm9yIHRoZSBidXMgbnVtYmVy
LiBTby4uLg0Kd2hhdCBpdCBkb2VzIGlzIG5vdCBlbm91Z2ggYXMuLi4NCiDCoMKgwqAgaWYgKCBi
dXNuIDwgY2ZnLT5idXNuX3N0YXJ0IHx8IGJ1c24gPiBjZmctPmJ1c25fZW5kICkNCiDCoMKgwqDC
oMKgwqDCoCByZXR1cm4gTlVMTDsNCg0KIMKgwqDCoCBidXNuIC09IGNmZy0+YnVzbl9zdGFydDsN
CiDCoMKgwqAgYmFzZSA9IGNmZy0+d2luICsgKGJ1c24gPDwgb3BzLT5idXNfc2hpZnQpOw0KDQog
wqDCoMKgIHJldHVybiBiYXNlICsgKFBDSV9ERVZGTjIoc2JkZi5iZGYpIDw8IGRldmZuX3NoaWZ0
KSArIHdoZXJlOw0KdGhpcyBjYW4gc3RpbGwgb3ZlcnJ1bg0KPg0KPiDCoEFuZCB0aGlzIGNvdWxk
IGJlIGEgcHJvYmxlbSBpZiB3ZSBoYXZlIGEgbWlzYmVoYXZpbmcNCj4+IGd1ZXN0IHdoaWNoIG1h
eSBmb3JjZSBYZW4gdG8gYWNjZXNzIHRoZSBtZW1vcnkgYmV5b25kIHRoYXQgb2YgUENJIGhvc3Qg
YnJpZGdlDQo+Pj4NCj4+PiBXaGVuIHRoZXJlIGlzIGEgZGF0YSBhYm9ydCBpbiBYZW4sIHlvdSBz
aG91bGQgZ2V0IGEgc3RhY2sgdHJhY2UgZnJvbSB3aGVyZSB0aGlzIGNvbWVzIGZyb20uIENhbiB5
b3UgcGFzdGUgaXQgaGVyZT8NCj4+IChYRU4pIERhdGEgQWJvcnQgVHJhcC4gU3luZHJvbWU9MHg2
DQo+PiAoWEVOKSBXYWxraW5nIEh5cGVydmlzb3IgVkEgMHg0NjdhMjhiYyBvbiBDUFUwIHZpYSBU
VEJSIDB4MDAwMDAwMDA0ODFkNTAwMA0KPj4gKFhFTikgMFRIWzB4MF0gPSAweDAwMDAwMDAwNDgx
ZDRmN2YNCj4+IChYRU4pIDFTVFsweDFdID0gMHgwMDAwMDAwMDQ4MWQyZjdmDQo+PiAoWEVOKSAy
TkRbMHgzM10gPSAweDAwMDAwMDAwMDAwMDAwMDANCj4+IChYRU4pIENQVTA6IFVuZXhwZWN0ZWQg
VHJhcDogRGF0YSBBYm9ydA0KPg0KPiAuLi4gSSBhbSBnZXR0aW5nIHF1aXRlIGNvbmZ1c2VkIHdo
eSB0aGlzIGlzIGNyYXNoaW5nLiBBcmUgd2UgdmFsaWRhdGlvbiBjb3JyZWN0bHkgdGhlIGFjY2Vz
cz8NClNlZSBhYm92ZS4gSWYgcHJvdmlkZWQgd2l0aCBiaWcgZW5vdWdoIFNCREYgd2UgY2FuIGVu
ZCB1cCBnZXR0aW5nIG91dCBvZiB0aGUgd2luZG93Lg0KPg0KPg0KPj4gKFhFTikgLS0tLVsgWGVu
LTQuMTYtdW5zdGFibGXCoCBhcm02NCBkZWJ1Zz15wqAgTm90IHRhaW50ZWQgXS0tLS0NCj4+IChY
RU4pIENQVTrCoMKgwqAgMA0KPj4gKFhFTikgUEM6wqDCoMKgwqAgMDAwMDAwMDAwMDI2ZDNkNCBw
Y2lfZ2VuZXJpY19jb25maWdfcmVhZCsweDg4LzB4OWMNCj4+IChYRU4pIExSOsKgwqDCoMKgIDAw
MDAwMDAwMDAyNmQzNmMNCj4+IChYRU4pIFNQOsKgwqDCoMKgIDAwMDA4MDAwN2ZmOTdjMDANCj4+
IChYRU4pIENQU1I6wqDCoCAwMDAwMDAwMDYwNDAwMjQ5IE1PREU6NjQtYml0IEVMMmggKEh5cGVy
dmlzb3IsIGhhbmRsZXIpDQo+PiAoWEVOKcKgwqDCoMKgwqAgWDA6IDAwMDAwMDAwNDY3YTI4YmPC
oCBYMTogMDAwMDAwMDAwNjVkMDhiY8KgIFgyOiAwMDAwMDAwMDAwMDAwOGJjDQo+PiAoWEVOKcKg
wqDCoMKgwqAgWDM6IDAwMDAwMDAwMDAwMDAwMGPCoCBYNDogMDAwMDgwMDA3ZmZjNmZkMMKgIFg1
OiAwMDAwMDAwMDAwMDAwMDAwDQo+PiAoWEVOKcKgwqDCoMKgwqAgWDY6IDAwMDAwMDAwMDAwMDAw
MTTCoCBYNzogZmZmZjgwMDAxMWE1ODAwMMKgIFg4OiBmZmZmMDAwMDIyNWEwMzgwDQo+PiAoWEVO
KcKgwqDCoMKgwqAgWDk6IDAwMDAwMDAwMDAwMDAwMDAgWDEwOiAwMTAxMDEwMTAxMDEwMTAxIFgx
MTogMDAwMDAwMDAwMDAwMDAyOA0KPj4gKFhFTinCoMKgwqDCoCBYMTI6IDAxMDEwMTAxMDEwMTAx
MDEgWDEzOiAwMDAwMDAwMDAwMDAwMDIwIFgxNDogZmZmZmZmZmZmZmZmZmZmZg0KPj4gKFhFTinC
oMKgwqDCoCBYMTU6IDAwMDAwMDAwMDAwMDAwMDEgWDE2OiBmZmZmODAwMDEwZGE2NzA4IFgxNzog
MDAwMDAwMDAwMDAwMDAyMA0KPj4gKFhFTinCoMKgwqDCoCBYMTg6IDAwMDAwMDAwMDAwMDAwMDIg
WDE5OiAwMDAwMDAwMDAwMDAwMDA0IFgyMDogMDAwMDgwMDA3ZmY5N2M1Yw0KPj4gKFhFTinCoMKg
wqDCoCBYMjE6IDAwMDAwMDAwMDAwMDA4YmMgWDIyOiAwMDAwMDAwMDAwMDAwOGJjIFgyMzogMDAw
MDAwMDAwMDAwMDAwNA0KPj4gKFhFTinCoMKgwqDCoCBYMjQ6IDAwMDAwMDAwMDAwMDAwMDAgWDI1
OiAwMDAwMDAwMDAwMDAwOGJjIFgyNjogMDAwMDAwMDAwMDAwNjVkMA0KPj4gKFhFTinCoMKgwqDC
oCBYMjc6IDAwMDA4MDAwN2ZmYjkwMTAgWDI4OiAwMDAwMDAwMDAwMDAwMDAwwqAgRlA6IDAwMDA4
MDAwN2ZmOTdjMDANCj4+IChYRU4pDQo+PiAoWEVOKcKgwqAgVlRDUl9FTDI6IDAwMDAwMDAwODAw
YTM1NTgNCj4+IChYRU4pwqAgVlRUQlJfRUwyOiAwMDAxMDAwMGJmZmJhMDAwDQo+PiAoWEVOKQ0K
Pj4gKFhFTinCoCBTQ1RMUl9FTDI6IDAwMDAwMDAwMzBjZDE4M2QNCj4+IChYRU4pwqDCoMKgIEhD
Ul9FTDI6IDAwMDAwMDAwODA3YzY2M2YNCj4+IChYRU4pwqAgVFRCUjBfRUwyOiAwMDAwMDAwMDQ4
MWQ1MDAwDQo+PiAoWEVOKQ0KPj4gKFhFTinCoMKgwqAgRVNSX0VMMjogMDAwMDAwMDA5NjAwMDAw
Ng0KPj4gKFhFTinCoCBIUEZBUl9FTDI6IDAwMDAwMDAwMDBlNjVkMDANCj4+IChYRU4pwqDCoMKg
IEZBUl9FTDI6IDAwMDAwMDAwNDY3YTI4YmMNCj4+IChYRU4pDQo+PiBbc25pcF0NCj4+IChYRU4p
IFhlbiBjYWxsIHRyYWNlOg0KPj4gKFhFTinCoMKgwqAgWzwwMDAwMDAwMDAwMjZkM2Q0Pl0gcGNp
X2dlbmVyaWNfY29uZmlnX3JlYWQrMHg4OC8weDljIChQQykNCj4+IChYRU4pwqDCoMKgIFs8MDAw
MDAwMDAwMDI2ZDM2Yz5dIHBjaV9nZW5lcmljX2NvbmZpZ19yZWFkKzB4MjAvMHg5YyAoTFIpDQo+
PiAoWEVOKcKgwqDCoCBbPDAwMDAwMDAwMDAyNmQyYzg+XSBwY2ktYWNjZXNzLmMjcGNpX2NvbmZp
Z19yZWFkKzB4NjAvMHg4NA0KPj4gKFhFTinCoMKgwqAgWzwwMDAwMDAwMDAwMjZkNGE4Pl0gcGNp
X2NvbmZfcmVhZDMyKzB4MTAvMHgxOA0KPj4gKFhFTinCoMKgwqAgWzwwMDAwMDAwMDAwMjRkY2Y4
Pl0gdnBjaS5jI3ZwY2lfcmVhZF9odysweDQ4LzB4YjgNCj4+IChYRU4pwqDCoMKgIFs8MDAwMDAw
MDAwMDI0ZTNlND5dIHZwY2lfcmVhZCsweGFjLzB4MjRjDQo+PiAoWEVOKcKgwqDCoCBbPDAwMDAw
MDAwMDAyNGU5MzQ+XSB2cGNpX2VjYW1fcmVhZCsweDc4LzB4YTgNCj4+IChYRU4pwqDCoMKgIFs8
MDAwMDAwMDAwMDI2ZTM2OD5dIHZwY2kuYyN2cGNpX21taW9fcmVhZCsweDQ0LzB4N2MNCj4+IChY
RU4pwqDCoMKgIFs8MDAwMDAwMDAwMDI3NTA1ND5dIHRyeV9oYW5kbGVfbW1pbysweDFlYy8weDI2
NA0KPj4gKFhFTinCoMKgwqAgWzwwMDAwMDAwMDAwMjdlYTUwPl0gdHJhcHMuYyNkb190cmFwX3N0
YWdlMl9hYm9ydF9ndWVzdCsweDE4Yy8weDJkOA0KPj4gKFhFTinCoMKgwqAgWzwwMDAwMDAwMDAw
MjdmMDg4Pl0gZG9fdHJhcF9ndWVzdF9zeW5jKzB4ZjAvMHg2MTgNCj4+IChYRU4pwqDCoMKgIFs8
MDAwMDAwMDAwMDI2OWM1OD5dIGVudHJ5Lm8jZ3Vlc3Rfc3luY19zbG93cGF0aCsweGE0LzB4ZDQN
Cj4+IChYRU4pDQo+PiAoWEVOKQ0KPj4gKFhFTikgKioqKioqKioqKioqKioqKioqKioqKioqKioq
KioqKioqKioqKioqKg0KPj4gKFhFTikgUGFuaWMgb24gQ1BVIDA6DQo+PiAoWEVOKSBDUFUwOiBV
bmV4cGVjdGVkIFRyYXA6IERhdGEgQWJvcnQNCj4+IChYRU4pICoqKioqKioqKioqKioqKioqKioq
KioqKioqKioqKioqKioqKioqKioNCj4+DQo+Pj4NCj4+Pj4NCj4+Pj4gRml4IHRoaXMgYnkgYWRq
dXN0aW5nIHRoZSBncGEgd2l0aCByZXNwZWN0IHRvIHRoZSBob3N0IGJyaWRnZSBiYXNlIGFkZHJl
c3MNCj4+Pj4gaW4gYSB3YXkgYXMgaXQgaXMgZG9uZSBmb3IgeDg2Lg0KPj4+Pg0KPj4+PiBGaXhl
czogZDU5MTY4ZGMwNWE1ICgieGVuL2FybTogRW5hYmxlIHRoZSBleGlzdGluZyB4ODYgdmlydHVh
bCBQQ0kgc3VwcG9ydCBmb3IgQVJNIikNCj4+Pj4NCj4+Pj4gU2lnbmVkLW9mZi1ieTogT2xla3Nh
bmRyIEFuZHJ1c2hjaGVua28gPG9sZWtzYW5kcl9hbmRydXNoY2hlbmtvQGVwYW0uY29tPg0KPj4+
PiAtLS0NCj4+Pj4gwqDCoCB4ZW4vYXJjaC9hcm0vdnBjaS5jIHwgNCArKy0tDQo+Pj4+IMKgwqAg
MSBmaWxlIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkNCj4+Pj4NCj4+
Pj4gZGlmZiAtLWdpdCBhL3hlbi9hcmNoL2FybS92cGNpLmMgYi94ZW4vYXJjaC9hcm0vdnBjaS5j
DQo+Pj4+IGluZGV4IDhmNDBhMGRlYzZkMi4uMjNmNDUzODZmNGIzIDEwMDY0NA0KPj4+PiAtLS0g
YS94ZW4vYXJjaC9hcm0vdnBjaS5jDQo+Pj4+ICsrKyBiL3hlbi9hcmNoL2FybS92cGNpLmMNCj4+
Pj4gQEAgLTI0LDcgKzI0LDcgQEAgc3RhdGljIGludCB2cGNpX21taW9fcmVhZChzdHJ1Y3QgdmNw
dSAqdiwgbW1pb19pbmZvX3QgKmluZm8sDQo+Pj4+IMKgwqDCoMKgwqDCoCB1bnNpZ25lZCBsb25n
IGRhdGE7DQo+Pj4+IMKgwqAgwqDCoMKgwqDCoCAvKiBXZSBpZ25vcmUgc2VnbWVudCBwYXJ0IGFu
ZCBhbHdheXMgaGFuZGxlIHNlZ21lbnQgMCAqLw0KPj4+PiAtwqDCoMKgIHNiZGYuc2JkZiA9IFZQ
Q0lfRUNBTV9CREYoaW5mby0+Z3BhKTsNCj4+Pj4gK8KgwqDCoCBzYmRmLnNiZGYgPSBWUENJX0VD
QU1fQkRGKGluZm8tPmdwYSAtIEdVRVNUX1ZQQ0lfRUNBTV9CQVNFKTsNCj4+Pg0KPj4+IExvb2tp
bmcgYXQgdGhlIHJlc3Qgb2YgdGhlIHJlc3QsIGl0IHNlZW1zIHRoYXQNCj4+PiDCoMKgMSkgdGhl
IGlzc3VlIGlzIGxhdGVudCBhcyB0aGUgYml0cyAwLTI3IGFyZSBjbGVhcg0KPj4+IMKgwqAyKSB0
aGlzIHdpbGwgbmVlZCB0byBiZSBtb2RpZmllZCB0byB0YWtlIGludG8gYWNjb3VudCBkb20wLg0K
Pj4+DQo+Pj4gU28gSSB3b3VsZCBwcmVmZXIgaWYgdGhlIGJhc2UgYWRkcmVzcyBpcyBwYXNzZWQg
ZGlmZmVyZW50bHkgKG1heWJlIGluIHByaXY/KSBmcm9tIHRoZSBzdGFydC4gVGhpcyB3aWxsIGF2
b2lkIGV4dHJhIG1vZGlmaWNhdGlvbiB0aGF0IHlvdSBhbHJlYWR5IHBsYW4gdG8gaGF2ZSBpbiBh
IGZvbGxvdy11cCBzZXJpZXMuDQo+PiBJIHdhcyB0aGlua2luZyBhYm91dCB0aGUgc2FtZSwgYnV0
IHRoZSBmdXR1cmUgY29kZSB3aWxsIHVzZSBwcml2IGZvciBvdGhlciBwdXJwb3NlOg0KPj4NCj4+
IHN0YXRpYyBpbnQgdnBjaV9tbWlvX3JlYWQoc3RydWN0IHZjcHUgKnYsIG1taW9faW5mb190ICpp
bmZvLA0KPj4gwqAgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqAgcmVnaXN0ZXJfdCAqciwgdm9pZCAqcCkNCj4+IHsNCj4+IMKgIMKgwqDCoCBzdHJ1Y3Qg
cGNpX2hvc3RfYnJpZGdlICpicmlkZ2UgPSBwOw0KPj4gwqAgwqDCoMKgIHBjaV9zYmRmX3Qgc2Jk
ZjsNCj4+IMKgIMKgwqDCoCAvKiBkYXRhIGlzIG5lZWRlZCB0byBwcmV2ZW50IGEgcG9pbnRlciBj
YXN0IG9uIDMyYml0ICovDQo+PiDCoCDCoMKgwqAgdW5zaWduZWQgbG9uZyBkYXRhOw0KPj4NCj4+
IMKgIMKgwqDCoCBpZiAoIGJyaWRnZSApDQo+PiDCoCDCoMKgwqAgew0KPj4gwqAgwqDCoMKgwqDC
oMKgwqAgc2JkZi5zYmRmID0gVlBDSV9FQ0FNX0JERihpbmZvLT5ncGEgLSBicmlkZ2UtPmNmZy0+
cGh5c19hZGRyKTsNCj4+IMKgIMKgwqDCoMKgwqDCoMKgIHNiZGYuc2VnID0gYnJpZGdlLT5zZWdt
ZW50Ow0KPj4gwqAgwqDCoMKgIH0NCj4+IMKgIMKgwqDCoCBlbHNlDQo+PiDCoCDCoMKgwqDCoMKg
wqDCoCBzYmRmLnNiZGYgPSBWUENJX0VDQU1fQkRGKGluZm8tPmdwYSAtIEdVRVNUX1ZQQ0lfRUNB
TV9CQVNFKTsNCj4NCj4gSXMgaXQgdGhlIG9ubHkgcGxhY2UgeW91IGFyZSBkb2luZyB0byB1c2Ug
YnJpZGdlPyBJZiBzbywgdGhlbiBJIHRoaW5rIHdlIGNhbiBzaW1wbHkgaGF2ZSBhIHN0cnVjdHVy
ZSB0aGF0IHdvdWxkIGNvbnRhaW4gcGh5c19hZGRyIGFuZCBzZWdtZW50Lg0KPg0KPiBUaGlzIHdv
dWxkIGJlIGluY2x1ZGUgaW4gdGhlIGJyaWRnZSBmb3IgZG9tMCBhbmQgZm9yIGd1ZXN0IHRoaXMg
Y291bGQgYmUgYSBzdGF0aWMgZ2xvYmFsIHZhcmlhYmxlIGZvciBub3cuDQpIbS4gSSBkb24ndCB0
aGluayBhIGdsb2JhbCBpcyBhbnkgYmV0dGVyIHRoYW4gdXNpbmcgaW5mby0+Z3BhIC0gR1VFU1Rf
VlBDSV9FQ0FNX0JBU0UuDQpCdXQgSSBhbSBmaW5lIHdpdGggdGhlIHN0cnVjdHVyZTogcGxlYXNl
IGxldCBtZSBrbm93IHlvdXIgcHJlZmVyZW5jZSwNCnNvIEkgY2FuIGhhdmUgYW4gYWNjZXB0YWJs
ZSBmaXgNCj4NCj4gQ2hlZXJzLA0KPg0KVGhhbmsgeW91LA0KT2xla3NhbmRy


From xen-devel-bounces@lists.xenproject.org Thu Oct 28 14:19:26 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Oct 2021 14:19:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.218087.378383 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg6FS-0007XH-7t; Thu, 28 Oct 2021 14:19:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 218087.378383; Thu, 28 Oct 2021 14:19:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg6FS-0007XA-4K; Thu, 28 Oct 2021 14:19:18 +0000
Received: by outflank-mailman (input) for mailman id 218087;
 Thu, 28 Oct 2021 14:19:17 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=TkaK=PQ=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1mg6FR-0007X4-Es
 for xen-devel@lists.xenproject.org; Thu, 28 Oct 2021 14:19:17 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 07db4ff8-37fa-11ec-84a3-12813bfff9fa;
 Thu, 28 Oct 2021 14:19:15 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id B054361139;
 Thu, 28 Oct 2021 14:19:14 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 07db4ff8-37fa-11ec-84a3-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1635430755;
	bh=AAsvdLWrWc0Yclmu1IC+KTPmrmf7tikUCuuxsQqi/qg=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=UvX4swdRoNucoaD8MbU+wbr2QDss26QuhM1EfqhkXTN6ZyQ/AOqV/7kiMwiU27Orh
	 FSAXrEpW8ZSopwDZFGLmiIEtdiAyC4n5+NMLJ/7KGidARN3LRxuBaFXV2kobZ2HbAG
	 N0VUVRJhx6VQlSLuJxTaWrdctIRa4MFbEVnsP0u6gVEV9Ulk7/ZwXPaA72ggTnQVWw
	 iXs9Qx3+PUHlimCGrfLZH5iRjOFt6IKVZKnlrNF1eUif9C0dgPduH2hDWwNDpPe7F1
	 j4z5S1nGrwQnswdZnsYg1n0OjTj9at8hCbPzwHsbNImrQMjs2S9mO0kgGzecVsrSd1
	 6BzIpEUe4m7ZA==
Date: Thu, 28 Oct 2021 07:19:13 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Anthony PERARD <anthony.perard@citrix.com>
cc: Stefano Stabellini <sstabellini@kernel.org>, cardoe@cardoe.com, 
    xen-devel@lists.xenproject.org, iwj@xenproject.org, wl@xen.org, 
    andrew.cooper3@citrix.com, 
    Stefano Stabellini <stefano.stabellini@xilinx.com>
Subject: Re: Solving the gitlab-ci git fetch issue, was: [PATCH 3/3] automation:
 add a QEMU based x86_64 Dom0/DomU test
In-Reply-To: <YXpx5PJwZoJQ6YIy@perard>
Message-ID: <alpine.DEB.2.21.2110280715310.20134@sstabellini-ThinkPad-T480s>
References: <alpine.DEB.2.21.2110210831470.2311@sstabellini-ThinkPad-T480s> <20211021230839.10794-3-sstabellini@kernel.org> <YXK2lTWZHiTXIBtJ@perard> <alpine.DEB.2.21.2110221219520.2311@sstabellini-ThinkPad-T480s> <YXbXwjxHPNjSAKrG@perard>
 <alpine.DEB.2.21.2110251754210.4586@sstabellini-ThinkPad-T480s> <YXlbOjiphjN/XqMz@perard> <alpine.DEB.2.21.2110271437120.20134@sstabellini-ThinkPad-T480s> <YXpx5PJwZoJQ6YIy@perard>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Thu, 28 Oct 2021, Anthony PERARD wrote:
> On Wed, Oct 27, 2021 at 02:43:46PM -0700, Stefano Stabellini wrote:
> > On Wed, 27 Oct 2021, Anthony PERARD wrote:
> > > > But we do have a severe problem at the moment with external sources: our
> > > > "git clones" keep failing during the build on x86. That is definitely
> > > > something worth improving (see my other email thread on the subject) and
> > > > it is the main problem affecting gitlab-ci at the moment, I keep having
> > > > to restart jobs almost daily to get the overall pipeline to "pass".
> > > > 
> > > > If you have any ideas on how to stop fetching things using "git" from
> > > > external repositories in gitlab-ci that would be fantastic :-)
> > > > The only thing I could think of to "fix it" is moving all external repos
> > > > to gitlab repositories mirrors.
> > > 
> > > I don't think that would work, I've seen the initial clone/fetch of a
> > > job fail as well, so from gitlab. If we could have a cache of those
> > > external resources closer to the runners, that would be better.
> > 
> > You mean like a git repository mirror inside the Rackspace network (the
> > provider of the x86 runner), right? Then we would force the git client
> > to go to the Rackspace mirror instead of directly to the target using
> > "insteadOf".
> 
> That would seems the best to me. If we could install Ian's
> git-cache-proxy that is used in osstest, that would be good I think.
> Having a mirror instead might work too but that would mean figure out
> which repo we would need a mirror of.
> 
> I did try a different alternative a while back, I tried to use gitlab's
> caching capability:
>     automation: Cache sub-project git tree in build jobs
>     https://lore.kernel.org/xen-devel/20191219144217.305851-3-anthony.perard@citrix.com/
> It mostly works but I'm not sure how useful it is as it seems there is
> 10 computers that would maintain 10 different caches, and most of them
> for a short while.

Interesting!

With the current runners being short-lived, it makes sense only to have
git-cache-proxy on a different always-on host. But even after the
runners are changed to be always running, instead of spawned on demand,
it might be better to have git-cache-proxy on a separate host so that
all runners can use it.  It should be more efficient?


From xen-devel-bounces@lists.xenproject.org Thu Oct 28 14:23:52 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Oct 2021 14:23:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.218094.378394 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg6Jj-0000Uj-PS; Thu, 28 Oct 2021 14:23:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 218094.378394; Thu, 28 Oct 2021 14:23:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg6Jj-0000Uc-M1; Thu, 28 Oct 2021 14:23:43 +0000
Received: by outflank-mailman (input) for mailman id 218094;
 Thu, 28 Oct 2021 14:23:42 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ikAZ=PQ=epam.com=prvs=19352d112c=oleksandr_andrushchenko@srs-us1.protection.inumbo.net>)
 id 1mg6Ji-0000UW-Bf
 for xen-devel@lists.xenproject.org; Thu, 28 Oct 2021 14:23:42 +0000
Received: from mx0b-0039f301.pphosted.com (unknown [148.163.137.242])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id a5d64c3a-37fa-11ec-84a3-12813bfff9fa;
 Thu, 28 Oct 2021 14:23:41 +0000 (UTC)
Received: from pps.filterd (m0174683.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.0.43) with SMTP id 19SEHGq7002155;
 Thu, 28 Oct 2021 14:23:38 GMT
Received: from eur01-ve1-obe.outbound.protection.outlook.com
 (mail-ve1eur01lp2050.outbound.protection.outlook.com [104.47.1.50])
 by mx0b-0039f301.pphosted.com with ESMTP id 3bywg5814q-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Thu, 28 Oct 2021 14:23:37 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by VI1PR0302MB3373.eurprd03.prod.outlook.com (2603:10a6:803:1b::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.20; Thu, 28 Oct
 2021 14:23:34 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::c038:e032:595a:651]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::c038:e032:595a:651%9]) with mapi id 15.20.4649.015; Thu, 28 Oct 2021
 14:23:34 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a5d64c3a-37fa-11ec-84a3-12813bfff9fa
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=TEir9NWfKblRGXYVjYlpc0OhReNpN2UHuyokMe7QHWMi1pzPQTV8CDES2lkr2s5sQwHKKSUUbE3KnzFBdTUa1lCIy/wtSrljofFFE1OZgA7G7dpauOafoqJ7MIpB7Hqk9JrIJKTpU17e9Fe9NBR8Xj37H8FhfSUzMyI3TOrjB1T5sgQilV6emC6YRpwjjlWkQTfQ6q/vqPYiLQP7nxSd/T1S2pFMfurPmzai3HLyYDH3GDN/NaqZOmx78cleiqtuoubj4A8j18QG14Dx7x3fCLBfGnapBQbAF027/Nc2rYnsKh2OOST1ZvvtZdB+ntk4jJ7ldw/Fqfj7+Pu9rcd/nw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=4kYDrEAGhyYGrBHM0aibwdt4pNQYhXuWYdvWT8+9790=;
 b=Xz6yKz0uakoc48H0DVXVDQNa/9vKSd8fwZZt+7C84NZpfzy8shNOqy7VWcCs01cK5dY3s/EZ0GTTR+CPpUFoHxWyJ+lt/K3oK6UNYNnyGhzJurRS0IPUoIONu7fIgkkthgu/OUv1+kDd2yvXfXcHh01kHdDlWqwEY9VlDYLr9hlqwvIY1ZubjuUY4/9aITPK27010OdVYnKoguznd540aZA+Wwfoxd4rmaJgU7ccissWrIw/RawLO3fqa2qxVzxTpr1cZk7PV81PS8tZrhgtp0TxkY+ALlKLo6jZEt4sMb5FnTRgn8tz3NRzBRG4Za5ExI4teCazgJ0JqLCoHhwVeg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=4kYDrEAGhyYGrBHM0aibwdt4pNQYhXuWYdvWT8+9790=;
 b=ZQnGE9NzmdDHuKpqkKO+7LkGD5wFQo81s5q3j1veYk3trWfb5SCHri3ToDYjHbOCD2yxppaCCSpczlFd53rkNz1RTm9zJEkT1eiOfyB3kwF9v2BtwBdhzFSdANFl1O35p6K2d5KeFgGufp5/8ZmvrrY9yBehAG+UAjdKibleZB/A0kDGLhKz5tevwKPmPXRDkjQSFAQscU8eZC7xFNHMKJDl8WLqehWvGZR6KYmV2MMk5z3jVveso+xzdfqANHJW1zvw0o8ZgC2j2CXUHGHWMJKlirL2X00WMT2MYZJiWHuIdkStkA1whc0cyklrSyh5kHNg00+unYxhBlMkJvQ/wQ==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>
CC: Julien Grall <julien@xen.org>,
        "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>,
        "sstabellini@kernel.org"
	<sstabellini@kernel.org>,
        "iwj@xenproject.org" <iwj@xenproject.org>,
        Bertrand
 Marquis <bertrand.marquis@arm.com>,
        Rahul Singh <rahul.singh@arm.com>
Subject: Re: [PATCH] xen/arm: fix SBDF calculation for vPCI MMIO handlers
Thread-Topic: [PATCH] xen/arm: fix SBDF calculation for vPCI MMIO handlers
Thread-Index: AQHXyww6rKHs3LJru0q52eLUia+oNavnHBIAgAE3H4CAABhAgIAADTsA
Date: Thu, 28 Oct 2021 14:23:34 +0000
Message-ID: <3206478e-f230-cd91-5de9-85ef6c251405@epam.com>
References: <20211027082533.1406015-1-andr2000@gmail.com>
 <cb7e9ef7-476e-93c3-d3c9-9a9ebc61003d@xen.org>
 <d63c6e0b-8aa3-9ba3-893c-5e464638a8db@epam.com>
 <YXqnS7iZUvokJby6@Air-de-Roger>
In-Reply-To: <YXqnS7iZUvokJby6@Air-de-Roger>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: e7800bbb-ad77-4965-3d01-08d99a1e8647
x-ms-traffictypediagnostic: VI1PR0302MB3373:
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <VI1PR0302MB33739C3D566AF30FB4447818E7869@VI1PR0302MB3373.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 5enHst3tv3bs64w+ywvsuZu2aTDUR4PElTXDCst6m0h4jjiWDSdcQiTzu9BHSduphe9toUzxfafE7KettBFmN+4qdWmPwhbxd55BhwrxDf2TTvZt7w/0dOes4omGmGnrqBBoWrhVJOlWDn/2hezhvvlgnNhdkEac3kfjGSSNzp9zUNbGZSlTR5RDGgZiX/42geLu2AapybkTKuug/qiYdcNrfXZ6+LZErFKfc6Fj6xVDj6z/yjczBazUUJiKFyi84pd0zKSPKuh+JzUSEoihtLHpON38XeJuOhMAO9qLJuZ1GJeJUdoSB/fxatatqb1VuDzHccInfypjQwU38+hESryFdD4tygXed2BIbxy7pIm1nVVKctF8yZ+8tf21KYEtM+URQqKP5rU211HK+y/Ts0GmVU+1yOO/uj/4/3GYf8dSP43A1f/IvWCG4GZPOgz3JIceeL10R0Jaw630/BhZrBGuNsvbwt/E6/1l/sLyQgZk6odnPYlXQMGaLH0vbA5jCX89VmZoxP28XYZntWLB17niWm066IswHBR1JY4aE8NSz1LtQIUTBC/z6hRiHLX01YK0Vm161wbS0iXIeZcBDN2X8fVEfxp7kM9LSPlT30GNq1GY0HKp3DopOnl4vfer6hTPip/Sx9SoK34aDtXRlDpBHKf1ziHtEdwmRukkSKoh3vSRZ9DQ82xyuXllezSezjpfcR0+sZ6MJ6+uoQPPIWfv6A0lbk0aOz6vg2Dt+XAlDAQDkhSqoXA8fMhZYpIe
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(26005)(36756003)(186003)(2906002)(53546011)(5660300002)(66446008)(6506007)(64756008)(4326008)(2616005)(31686004)(316002)(71200400001)(91956017)(66946007)(6512007)(38100700002)(54906003)(38070700005)(6486002)(6916009)(86362001)(83380400001)(31696002)(8676002)(66556008)(508600001)(76116006)(66476007)(8936002)(122000001)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?bUxTd002WmhWTTZGbmRBb0hMY08rUFFSZGp1S090N0hBaWF2NEZGYm1pRitr?=
 =?utf-8?B?NTNJbGZ5VjRWUlhwM0YzMWtueVppU0hJT3B0dWdWbi9HUzNBZWdvbFlhcnR3?=
 =?utf-8?B?d0dVZWZTTUdnUzUyY3BuV0tLcUxOV3ZRQVdyUkNqR21VQVBoZlc2QUlQQVFK?=
 =?utf-8?B?OCt5QksvWlFKSFh5WVZlN1F0Qk51VE5WdXQ0UnFoblFPQndRRWRVeEd2bUxz?=
 =?utf-8?B?THlqbWtVWFRrRVJ6aW9KQzNvTnhjVUgrN0ZmQ1dQOXhURHYweFYrMnZkbGNr?=
 =?utf-8?B?RGc1ekl4OFRGUlBwb2luaGI4NE9odFlnMDNYVFBuWTVYQWFYS0tIS1lCNzZR?=
 =?utf-8?B?Q2VxKzZIU0lxQ1J1RTVlbzNGR1ZWTFJYcjM1cHB3SURPTzl6TWhIZUxaSzl5?=
 =?utf-8?B?S3NGTzBhMEl6N2F3RXN5SklGS1BJbXNsN0FBRjY5cFZHeTdwbWJFVGRQN3F6?=
 =?utf-8?B?VEJWQWVWM3BlcmRrRkd0eU1FSEpRY2RjcnUwUWNkSmI3QjVJWHA1ckE3bkRT?=
 =?utf-8?B?eXhtVW9hMWNTOGZaZHQ0RzRDUnVHQjU0aGRKMkZBOEtqcHJITkVQZHJkdktD?=
 =?utf-8?B?Rm01aUR2aGpJWURlVko1UDNzZXZNci9DUy9KTDM3QzRPTEQ5ZHh5K3NXdUpu?=
 =?utf-8?B?aUhPYkFUS2RRY1BJNklKcnI0WGZEVEtmWGdCNVZtUEVqNjNvWXArSGlnVXlD?=
 =?utf-8?B?NEdJM3Z6Mzl5MSthcXdNOVZKVnpiR3p3SXRyWThkOWlCUXREUkhxRm95SHVr?=
 =?utf-8?B?ejdTT0dYQ0VYZjdUQ0lhZnU1SE5TdEkyd1BoNEFGWFRQcWkwMzV5aGdoWHdi?=
 =?utf-8?B?aDBtZEdBNm5oU253bG5lSGJDN0VleW1HRXdzbUlzSmhvaVJHQ2s4U2MvM3ZV?=
 =?utf-8?B?MkhoOGdvZkF5NUt6T2lIcVhkTXJ4d1lCbjlvaXhvaDZoeTZPbjZwd1pqWEVo?=
 =?utf-8?B?aklaYjd6cERtL2pMQjJCUjB1bWxiYW9oa1R2YW5UaGRiOUQyN2VEckYxS3d5?=
 =?utf-8?B?MDlrQW5XMWNjWldjVEsrcTRpSjEzUUJyMklMOUFUQXRJNndmQTRaRDRzR3NE?=
 =?utf-8?B?ME9pUkZaU0NPTHdiQlVpR1RmemVCVmJHL1Y1b0RFMno5ZmFMSExYSjlaeWF6?=
 =?utf-8?B?YVRMd2Y1VGxjM21sUmF6b0ZVWFdpNlZrL1lWWi9Menh3cThwT3ZpTHZkYVcy?=
 =?utf-8?B?OFYvNzRIU2ZBMmc0OGcvazd0ZWd5NFh6eWF0QmYyVk1Bd05UVTB3TGZaOGFn?=
 =?utf-8?B?VXNONnFsaVRjV0tnTmVLd0JqY1YvNEdaMHlJdXg1UTFKMSsyVTVXMDJ1blgv?=
 =?utf-8?B?ZjRrQVpxd2IyREVBbGFxcWJKL0xmMzRNRTNyZVNpUUdtV0JaRFRsUWlRT3hm?=
 =?utf-8?B?TTdCZG9Wc0lPbHM4QWhROGFkSUc0S0ZXNWt1UnJWb05ibFMwejI3TURKaG1Y?=
 =?utf-8?B?Z0ZRQ2sxbXliOXYwb21kYzlod3ZVSGR3NDdHLy9aSGp0UVFUaUdRblgvZ1ZK?=
 =?utf-8?B?WTlBNW9WMjNNMkRwZnRicXpNR3BpcTFUaW9CZWNoSWlNeCszc2pmRHhDVENx?=
 =?utf-8?B?NWt6NWFKOGFjdFVGZDZkRUFYSTk4SEM5OXhjSXFmdnkzOHd2TmNzUGdERE9U?=
 =?utf-8?B?MDVPbUc1emdwK1pMVDBjamo3M3F4T0QwUGxNbWs1RmtkTE9sN2R5Z2pCdE1p?=
 =?utf-8?B?Y0dQUkJHZXVLL2JEbWg5ZkhnZjdaa3A5MWNJcEwzYzY2VnBDYjdXUUwrcWRE?=
 =?utf-8?B?TFlyd1pzRjg3ckIzeDVYY3ZjWlQ5NWhKZXFCSUthZTVSazR1Rkg4dnF1RnJ3?=
 =?utf-8?B?akM0L0FSTkNCSE1TY2tOdWR6ek9PanFIZ0daTWFTU2VBUE4wUU5tdEJmcU9v?=
 =?utf-8?B?MnR4dEJLYmdyTlNqQ0VBUmNnVmlZRDVkZnF4WTdpcGc0ejBFWVpuUjJmWU5y?=
 =?utf-8?B?eWVmeE9PazV1TGxsaWFoQndoMmRsT1l5bWxUTUcxd0JlRXJhZGp6dHRlYyt0?=
 =?utf-8?B?ZVA0TStPRHM0TUFhSEJXN1hNL0p5UjVTZjhEc0lMQ0UwRStycTRtdlppSXJo?=
 =?utf-8?B?bzRXbWgrNjRQNE1SOE9nM01xTloweXQrUjJCN0Q4SzB0UXBtcUFLTjBrTzA0?=
 =?utf-8?B?aUNxdE9RYk9oZDZSSnE0VzlpM1Y0Znd3VXZ6dDUzaDRmZTFMV3drYzQzSzgz?=
 =?utf-8?B?cEcrbVB2RkZ4R1p1QkU3UVFzUFFNM0JtQWV3VmZodHltU3U2cGVEVXdIWkpJ?=
 =?utf-8?B?Yi93R3AxVWNoVWR3YnpSemtKZkVBZlM3bnVnNDQ2RE42Njc3ejlCMisvMlNj?=
 =?utf-8?B?R2h2WTMyMFRNWnlHdTlYZEFwMUwzcUNzM05KWmJSbk9idWlsWjNYdz09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <87D6C0FF8800884EAB3C1A7623A6CCE1@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e7800bbb-ad77-4965-3d01-08d99a1e8647
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Oct 2021 14:23:34.1052
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: vVnVNwfgJbXUZHLjZ/9YfaFgL3T4z737Zvweczkc020A3hb73qc03kUq/Q2MIIUgggTey4ozs7TG/8huICHNGW4NU4Qcz/2JlFUp48PRPtnjEtNJO8CBjQkeSItU7lbJ
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0302MB3373
X-Proofpoint-GUID: UB78aQyipW525TRl38J8fSytqGzhiQQi
X-Proofpoint-ORIG-GUID: UB78aQyipW525TRl38J8fSytqGzhiQQi
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475
 definitions=2021-10-28_01,2021-10-26_01,2020-04-07_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501
 lowpriorityscore=0 mlxlogscore=999 impostorscore=0 mlxscore=0
 malwarescore=0 spamscore=0 adultscore=0 phishscore=0 bulkscore=0
 suspectscore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx
 scancount=1 engine=8.12.0-2110150000 definitions=main-2110280080

DQoNCk9uIDI4LjEwLjIxIDE2OjM2LCBSb2dlciBQYXUgTW9ubsOpIHdyb3RlOg0KPiBPbiBUaHUs
IE9jdCAyOCwgMjAyMSBhdCAxMjowOToyM1BNICswMDAwLCBPbGVrc2FuZHIgQW5kcnVzaGNoZW5r
byB3cm90ZToNCj4+IEhpLCBKdWxpZW4hDQo+Pg0KPj4gT24gMjcuMTAuMjEgMjA6MzUsIEp1bGll
biBHcmFsbCB3cm90ZToNCj4+PiBIaSBPbGVrc2FuZHIsDQo+Pj4NCj4+PiBPbiAyNy8xMC8yMDIx
IDA5OjI1LCBPbGVrc2FuZHIgQW5kcnVzaGNoZW5rbyB3cm90ZToNCj4+Pj4gRnJvbTogT2xla3Nh
bmRyIEFuZHJ1c2hjaGVua28gPG9sZWtzYW5kcl9hbmRydXNoY2hlbmtvQGVwYW0uY29tPg0KPj4+
Pg0KPj4+PiBXaGlsZSBpbiB2UENJIE1NSU8gdHJhcCBoYW5kbGVycyBmb3IgdGhlIGd1ZXN0IFBD
SSBob3N0IGJyaWRnZSBpdCBpcyBub3QNCj4+Pj4gZW5vdWdoIGZvciBTQkRGIHRyYW5zbGF0aW9u
IHRvIHNpbXBseSBjYWxsIFZQQ0lfRUNBTV9CREYoaW5mby0+Z3BhKSBhcw0KPj4+PiB0aGUgYmFz
ZSBhZGRyZXNzIG1heSBub3QgYmUgYWxpZ25lZCBpbiB0aGUgd2F5IHRoYXQgdGhlIHRyYW5zbGF0
aW9uDQo+Pj4+IGFsd2F5cyB3b3JrLiBJZiBub3QgYWRqdXN0ZWQgd2l0aCByZXNwZWN0IHRvIHRo
ZSBiYXNlIGFkZHJlc3MgaXQgbWF5IG5vdCBiZQ0KPj4+PiBhYmxlIHRvIHByb3Blcmx5IGNvbnZl
cnQgU0JERiBhbmQgY3Jhc2hlczoNCj4+Pj4NCj4+Pj4gKFhFTikgdnBjaV9tbWlvX3JlYWQgMDAw
MDo2NToxYS4wIHJlZyA4YmMgZ3BhIGU2NWQwOGJjDQo+Pj4gSSBjYW4ndCBmaW5kIGEgcHJpbnRr
KCkgdGhhdCBtYXkgb3V0cHV0IHRoaXMgbWVzc2FnZS4gV2hlcmUgZG9lcyB0aGlzIGNvbWVzIGZy
b20/DQo+PiBUaGF0IHdhcyBhIGRlYnVnIHByaW50LiBJIHNob3VsZG4ndCBoYXZlIHVzZWQgdGhh
dCBpbiB0aGUgcGF0Y2ggZGVzY3JpcHRpb24sIGJ1dA0KPj4gcHJvYmFibHkgYWZ0ZXIgIi0tLSIg
dG8gYmV0dGVyIGV4cGxhaW4gd2hhdCdzIGhhcHBlbmluZw0KPj4+IEFueXdheSwgSUlVQyB0aGUg
Z3Vlc3QgcGh5c2ljYWwgYWRkcmVzcyBpcyAweGU2NWQwOGJjIHdoaWNoLCBpZiBJIGFtIG5vdCBt
aXN0YWtlbiwgZG9lc24ndCBiZWxvbmcgdG8gdGhlIHJhbmdlIGFkdmVydGlzZWQgZm9yIEdVRVNU
X1ZQQ0lfRUNBTS4NCj4+IFRoaXMgaXMgZnJvbSBkb20wIEkgYW0gd29ya2luZyBvbiBub3cuDQo+
Pj4gSU1ITywgdGhlIHN0YWNrIHRyYWNlIHNob3VsZCBjb21lIGZyb20gdXNwdHJlYW0gWGVuIG9y
IG5lZWQgc29tZSBpbmZvcm1hdGlvbiB0byBleHBsYWluIGhvdyB0aGlzIHdhcyByZXByb2R1Y2Vk
Lg0KPj4+DQo+Pj4+IChYRU4pIERhdGEgQWJvcnQgVHJhcC4gU3luZHJvbWU9MHg2DQo+Pj4+IChY
RU4pIFdhbGtpbmcgSHlwZXJ2aXNvciBWQSAweDQ2N2EyOGJjIG9uIENQVTAgdmlhIFRUQlIgMHgw
MDAwMDAwMDQ4MWQ1MDAwDQo+Pj4gSSBjYW4gdW5kZXJzdG5hZCB0aGF0IGlmIHdlIGRvbid0IHN1
YnN0cmFjdCBHVUVTVF9WUENJX0VDQU0sIHdlIHdvdWxkIChpbiB0aGVvcnkpIG5vdCBnZXQgdGhl
IGNvcnJlY3QgQkRGLiBCdXQuLi4gSSBkb24ndCB1bmRlcnN0YW5kIGhvdyB0aGlzIHdvdWxkIHJl
c3VsdCB0byBhIGRhdGEgYWJvcnQgaW4gdGhlIGh5cGVydmlzb3IuDQo+Pj4NCj4+PiBJbiBmYWN0
LCBJIHRoaW5rIHRoZSB2UENJIGNvZGUgc2hvdWxkIGJlIHJlc2lsaWVudCBlbm91Z2ggdG8gbm90
IGNyYXNoIGlmIHdlIHBhc3MgdGhlIHdyb25nIEJERi4NCj4+IFdlbGwsIHRoZXJlIGlzIG5vICg/
KSBlYXN5IHdheSB0byB2YWxpZGF0ZSBTQkRGLiBBbmQgdGhpcyBjb3VsZCBiZSBhIHByb2JsZW0g
aWYgd2UgaGF2ZSBhIG1pc2JlaGF2aW5nDQo+PiBndWVzdCB3aGljaCBtYXkgZm9yY2UgWGVuIHRv
IGFjY2VzcyB0aGUgbWVtb3J5IGJleW9uZCB0aGF0IG9mIFBDSSBob3N0IGJyaWRnZQ0KPiBIb3cg
Y291bGQgdGhhdCBiZT8gVGhlIEVDQU0gcmVnaW9uIGV4cG9zZWQgdG8gdGhlIGd1ZXN0IHlvdSBz
aG91bGQgYmUNCj4gdGhlIHNhbWUgYXMgdGhlIHBoeXNpY2FsIG9uZSBmb3IgZG9tMD8NCk9rLCBJ
IGhhdmUgYSBEZXNpZ253YXJlIFBDSSBoaXN0IHdoaWNoIGhhcyAyIEVDQU0gcmVnaW9ucyAoSSBh
bSBzdGFydGluZyB0bw0KaW1wbGVtZW50IHRoZSBkcml2ZXIgZm9yIGl0LCBzbyBJIGNhbiBiZSB3
cm9uZyBoZXJlKToNCi0gUm9vdCBDb21wbGV4IEVDQU0gYXJlYSAoImRiaSIpLCBpdCBpcyBzb21l
dGhpbmcgbGlrZSAweDMwMDAgYnl0ZXMgbG9uZw0KLSAiQ2xpZW50IiBFQ0FNIGFyZWEgKCJjb25m
aWciKQ0KU28gZnJvbSBEb20wIFBPViB3ZSBoYXZlIDIgRUNBTSByZWdpb25zIGFuZCBmb3IgdGhl
IGd1ZXN0DQp3ZSBhbHdheXMgZW11bGF0ZSBhIHNpbmdsZSBiaWcgcmVnaW9uOg0KLyoNCiDCoCog
MjU2IE1CIGlzIHJlc2VydmVkIGZvciBWUENJIGNvbmZpZ3VyYXRpb24gc3BhY2UgYmFzZWQgb24g
Y2FsY3VsYXRpb24NCiDCoCogMjU2IGJ1c2VzIHggMzIgZGV2aWNlcyB4IDggZnVuY3Rpb25zIHgg
NCBLQiA9IDI1NiBNQg0KIMKgKi8NCiNkZWZpbmUgR1VFU1RfVlBDSV9FQ0FNX0JBU0XCoMKgwqAg
eGVuX21rX3VsbG9uZygweDEwMDAwMDAwKQ0KI2RlZmluZSBHVUVTVF9WUENJX0VDQU1fU0laRcKg
wqDCoCB4ZW5fbWtfdWxsb25nKDB4MTAwMDAwMDApDQoNClNvLCB3ZSBoYXZlIHRoZSBiYXNlIGFk
ZHJlc3MgYW5kIHNpemUgb2YgdGhlIGVtdWxhdGVkIEVDQU0gc3BhY2UNCm5vdCBjb25uZWN0ZWQg
dG8gdGhlIHJlYWwgaG9zdCBicmlkZ2UNCj4NCj4gQW5kIGZvciBkb21VcyB5b3UgcmVhbGx5IG5l
ZWQgdG8gZml4IHZwY2lfe3JlYWQsd3JpdGV9IHRvIG5vdA0KPiBwYXNzdGhyb3VnaCBhY2Nlc3Nl
cyBub3QgZXhwbGljaXRseSBoYW5kbGVkLg0KRG8geW91IG1lYW4gdGhhdCB3ZSBuZWVkIHRvIHZh
bGlkYXRlIFNCREZzIHRoZXJlPw0KVGhpcyBjYW4gYmUgdHJpY2t5IGlmIHdlIGhhdmUgYSB1c2Ut
Y2FzZSB3aGVuIGEgUENJIGRldmljZSBiZWluZw0KcGFzc2VkIHRocm91Z2ggaWYgbm90IHB1dCBh
dCAwMDAwOjAwOjAuMCwgYnV0IHJlcXVlc3RlZCB0byBiZSwgZm9yDQpleGFtcGxlLCAwMDAwOjBk
OjAuMC4gU28sIHdlIG5lZWQgdG8gZ28gb3ZlciB0aGUgbGlzdCBvZiB2aXJ0dWFsDQpkZXZpY2Vz
IGFuZCBzZWUgaWYgU0JERiB0aGUgZ3Vlc3QgaXMgdHJ5aW5nIHRvIGFjY2VzcyBpcyBhIHZhbGlk
IFNCREYuDQpJcyB0aGlzIHdoYXQgeW91IG1lYW4/DQo+DQo+Pj4gV2hlbiB0aGVyZSBpcyBhIGRh
dGEgYWJvcnQgaW4gWGVuLCB5b3Ugc2hvdWxkIGdldCBhIHN0YWNrIHRyYWNlIGZyb20gd2hlcmUg
dGhpcyBjb21lcyBmcm9tLiBDYW4geW91IHBhc3RlIGl0IGhlcmU/DQo+PiAoWEVOKSBEYXRhIEFi
b3J0IFRyYXAuIFN5bmRyb21lPTB4Ng0KPj4gKFhFTikgV2Fsa2luZyBIeXBlcnZpc29yIFZBIDB4
NDY3YTI4YmMgb24gQ1BVMCB2aWEgVFRCUiAweDAwMDAwMDAwNDgxZDUwMDANCj4+IChYRU4pIDBU
SFsweDBdID0gMHgwMDAwMDAwMDQ4MWQ0ZjdmDQo+PiAoWEVOKSAxU1RbMHgxXSA9IDB4MDAwMDAw
MDA0ODFkMmY3Zg0KPj4gKFhFTikgMk5EWzB4MzNdID0gMHgwMDAwMDAwMDAwMDAwMDAwDQo+PiAo
WEVOKSBDUFUwOiBVbmV4cGVjdGVkIFRyYXA6IERhdGEgQWJvcnQNCj4+IChYRU4pIC0tLS1bIFhl
bi00LjE2LXVuc3RhYmxlwqAgYXJtNjTCoCBkZWJ1Zz15wqAgTm90IHRhaW50ZWQgXS0tLS0NCj4+
IChYRU4pIENQVTrCoMKgwqAgMA0KPj4gKFhFTikgUEM6wqDCoMKgwqAgMDAwMDAwMDAwMDI2ZDNk
NCBwY2lfZ2VuZXJpY19jb25maWdfcmVhZCsweDg4LzB4OWMNCj4+IChYRU4pIExSOsKgwqDCoMKg
IDAwMDAwMDAwMDAyNmQzNmMNCj4+IChYRU4pIFNQOsKgwqDCoMKgIDAwMDA4MDAwN2ZmOTdjMDAN
Cj4+IChYRU4pIENQU1I6wqDCoCAwMDAwMDAwMDYwNDAwMjQ5IE1PREU6NjQtYml0IEVMMmggKEh5
cGVydmlzb3IsIGhhbmRsZXIpDQo+PiAoWEVOKcKgwqDCoMKgwqAgWDA6IDAwMDAwMDAwNDY3YTI4
YmPCoCBYMTogMDAwMDAwMDAwNjVkMDhiY8KgIFgyOiAwMDAwMDAwMDAwMDAwOGJjDQo+PiAoWEVO
KcKgwqDCoMKgwqAgWDM6IDAwMDAwMDAwMDAwMDAwMGPCoCBYNDogMDAwMDgwMDA3ZmZjNmZkMMKg
IFg1OiAwMDAwMDAwMDAwMDAwMDAwDQo+PiAoWEVOKcKgwqDCoMKgwqAgWDY6IDAwMDAwMDAwMDAw
MDAwMTTCoCBYNzogZmZmZjgwMDAxMWE1ODAwMMKgIFg4OiBmZmZmMDAwMDIyNWEwMzgwDQo+PiAo
WEVOKcKgwqDCoMKgwqAgWDk6IDAwMDAwMDAwMDAwMDAwMDAgWDEwOiAwMTAxMDEwMTAxMDEwMTAx
IFgxMTogMDAwMDAwMDAwMDAwMDAyOA0KPj4gKFhFTinCoMKgwqDCoCBYMTI6IDAxMDEwMTAxMDEw
MTAxMDEgWDEzOiAwMDAwMDAwMDAwMDAwMDIwIFgxNDogZmZmZmZmZmZmZmZmZmZmZg0KPj4gKFhF
TinCoMKgwqDCoCBYMTU6IDAwMDAwMDAwMDAwMDAwMDEgWDE2OiBmZmZmODAwMDEwZGE2NzA4IFgx
NzogMDAwMDAwMDAwMDAwMDAyMA0KPj4gKFhFTinCoMKgwqDCoCBYMTg6IDAwMDAwMDAwMDAwMDAw
MDIgWDE5OiAwMDAwMDAwMDAwMDAwMDA0IFgyMDogMDAwMDgwMDA3ZmY5N2M1Yw0KPj4gKFhFTinC
oMKgwqDCoCBYMjE6IDAwMDAwMDAwMDAwMDA4YmMgWDIyOiAwMDAwMDAwMDAwMDAwOGJjIFgyMzog
MDAwMDAwMDAwMDAwMDAwNA0KPj4gKFhFTinCoMKgwqDCoCBYMjQ6IDAwMDAwMDAwMDAwMDAwMDAg
WDI1OiAwMDAwMDAwMDAwMDAwOGJjIFgyNjogMDAwMDAwMDAwMDAwNjVkMA0KPj4gKFhFTinCoMKg
wqDCoCBYMjc6IDAwMDA4MDAwN2ZmYjkwMTAgWDI4OiAwMDAwMDAwMDAwMDAwMDAwwqAgRlA6IDAw
MDA4MDAwN2ZmOTdjMDANCj4+IChYRU4pDQo+PiAoWEVOKcKgwqAgVlRDUl9FTDI6IDAwMDAwMDAw
ODAwYTM1NTgNCj4+IChYRU4pwqAgVlRUQlJfRUwyOiAwMDAxMDAwMGJmZmJhMDAwDQo+PiAoWEVO
KQ0KPj4gKFhFTinCoCBTQ1RMUl9FTDI6IDAwMDAwMDAwMzBjZDE4M2QNCj4+IChYRU4pwqDCoMKg
IEhDUl9FTDI6IDAwMDAwMDAwODA3YzY2M2YNCj4+IChYRU4pwqAgVFRCUjBfRUwyOiAwMDAwMDAw
MDQ4MWQ1MDAwDQo+PiAoWEVOKQ0KPj4gKFhFTinCoMKgwqAgRVNSX0VMMjogMDAwMDAwMDA5NjAw
MDAwNg0KPj4gKFhFTinCoCBIUEZBUl9FTDI6IDAwMDAwMDAwMDBlNjVkMDANCj4+IChYRU4pwqDC
oMKgIEZBUl9FTDI6IDAwMDAwMDAwNDY3YTI4YmMNCj4+IChYRU4pDQo+PiBbc25pcF0NCj4+IChY
RU4pIFhlbiBjYWxsIHRyYWNlOg0KPj4gKFhFTinCoMKgwqAgWzwwMDAwMDAwMDAwMjZkM2Q0Pl0g
cGNpX2dlbmVyaWNfY29uZmlnX3JlYWQrMHg4OC8weDljIChQQykNCj4+IChYRU4pwqDCoMKgIFs8
MDAwMDAwMDAwMDI2ZDM2Yz5dIHBjaV9nZW5lcmljX2NvbmZpZ19yZWFkKzB4MjAvMHg5YyAoTFIp
DQo+PiAoWEVOKcKgwqDCoCBbPDAwMDAwMDAwMDAyNmQyYzg+XSBwY2ktYWNjZXNzLmMjcGNpX2Nv
bmZpZ19yZWFkKzB4NjAvMHg4NA0KPj4gKFhFTinCoMKgwqAgWzwwMDAwMDAwMDAwMjZkNGE4Pl0g
cGNpX2NvbmZfcmVhZDMyKzB4MTAvMHgxOA0KPj4gKFhFTinCoMKgwqAgWzwwMDAwMDAwMDAwMjRk
Y2Y4Pl0gdnBjaS5jI3ZwY2lfcmVhZF9odysweDQ4LzB4YjgNCj4+IChYRU4pwqDCoMKgIFs8MDAw
MDAwMDAwMDI0ZTNlND5dIHZwY2lfcmVhZCsweGFjLzB4MjRjDQo+PiAoWEVOKcKgwqDCoCBbPDAw
MDAwMDAwMDAyNGU5MzQ+XSB2cGNpX2VjYW1fcmVhZCsweDc4LzB4YTgNCj4+IChYRU4pwqDCoMKg
IFs8MDAwMDAwMDAwMDI2ZTM2OD5dIHZwY2kuYyN2cGNpX21taW9fcmVhZCsweDQ0LzB4N2MNCj4+
IChYRU4pwqDCoMKgIFs8MDAwMDAwMDAwMDI3NTA1ND5dIHRyeV9oYW5kbGVfbW1pbysweDFlYy8w
eDI2NA0KPj4gKFhFTinCoMKgwqAgWzwwMDAwMDAwMDAwMjdlYTUwPl0gdHJhcHMuYyNkb190cmFw
X3N0YWdlMl9hYm9ydF9ndWVzdCsweDE4Yy8weDJkOA0KPj4gKFhFTinCoMKgwqAgWzwwMDAwMDAw
MDAwMjdmMDg4Pl0gZG9fdHJhcF9ndWVzdF9zeW5jKzB4ZjAvMHg2MTgNCj4+IChYRU4pwqDCoMKg
IFs8MDAwMDAwMDAwMDI2OWM1OD5dIGVudHJ5Lm8jZ3Vlc3Rfc3luY19zbG93cGF0aCsweGE0LzB4
ZDQNCj4+IChYRU4pDQo+PiAoWEVOKQ0KPj4gKFhFTikgKioqKioqKioqKioqKioqKioqKioqKioq
KioqKioqKioqKioqKioqKg0KPj4gKFhFTikgUGFuaWMgb24gQ1BVIDA6DQo+PiAoWEVOKSBDUFUw
OiBVbmV4cGVjdGVkIFRyYXA6IERhdGEgQWJvcnQNCj4+IChYRU4pICoqKioqKioqKioqKioqKioq
KioqKioqKioqKioqKioqKioqKioqKioNCj4gQXJlIHlvdSBleHBvc2luZyBhbiBFQ0FNIHJlZ2lv
biB0byB0aGUgZ3Vlc3QgYmlnZ2VyIHRoYW4gdGhlDQo+IHVuZGVybHlpbmcgb25lLCBhbmQgdGhh
dCdzIHdoeSB5b3UgZ2V0IGNyYXNoZXM/IChiZWNhdXNlIHlvdSBnZXQgb3V0IG9mDQo+IHRoZSBo
YXJkd2FyZSByYW5nZSkNClBsZWFzZSBzZWUgYWJvdmUNCj4gSSB3b3VsZCBhc3N1bWUgcGh5c2lj
YWwgYWNjZXNzZXMgdG8gdGhlIEVDQU0gYXJlYSByZXBvcnRlZCBieSB0aGUNCj4gaGFyZHdhcmUg
ZG9uJ3QgdHJpZ2dlciB0cmFwcz8NCk5vDQo+DQo+IFJvZ2VyLg0KVGhhbmsgeW91LA0KT2xla3Nh
bmRy


From xen-devel-bounces@lists.xenproject.org Thu Oct 28 14:29:07 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Oct 2021 14:29:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.218103.378405 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg6Oj-0001BD-C6; Thu, 28 Oct 2021 14:28:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 218103.378405; Thu, 28 Oct 2021 14:28:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg6Oj-0001B6-8y; Thu, 28 Oct 2021 14:28:53 +0000
Received: by outflank-mailman (input) for mailman id 218103;
 Thu, 28 Oct 2021 14:28:52 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mg6Oi-0001B0-7J
 for xen-devel@lists.xenproject.org; Thu, 28 Oct 2021 14:28:52 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mg6Og-0000tG-OA; Thu, 28 Oct 2021 14:28:50 +0000
Received: from 54-240-197-225.amazon.com ([54.240.197.225] helo=[10.7.236.13])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mg6Og-0006Jq-IK; Thu, 28 Oct 2021 14:28:50 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=Tk7jIP+7OQbDQ53Ur4kinmK9QtkuxGl9hAnU+Z+HoUY=; b=WhsxOXdfS1YXn2FSAzJzQ9M1qr
	KcBQP/fnO3Mv7rHnCYdGZ8wS92PoFIKSj148HAlC3Y6M+xuOPWGsUjmwBqOGcgIHOm2ncIfdF+f1r
	McB4AkHzYdutCDwJoJt/azmH/jHzN7rq6YijOg5hcE8VmSY4D48YSFDYokEU/3K180iI=;
Message-ID: <6d8f1061-7aec-2c1a-aaf4-c30440c2797a@xen.org>
Date: Thu, 28 Oct 2021 15:28:48 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.2.1
Subject: Re: [PATCH] xen/arm: fix SBDF calculation for vPCI MMIO handlers
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: "sstabellini@kernel.org" <sstabellini@kernel.org>,
 "iwj@xenproject.org" <iwj@xenproject.org>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Rahul Singh <rahul.singh@arm.com>
References: <20211027082533.1406015-1-andr2000@gmail.com>
 <cb7e9ef7-476e-93c3-d3c9-9a9ebc61003d@xen.org>
 <d63c6e0b-8aa3-9ba3-893c-5e464638a8db@epam.com>
 <65886734-7333-4469-fcc1-6916db708f13@xen.org>
 <b6bb02b6-6358-b5e0-1b80-7819aadabe10@epam.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <b6bb02b6-6358-b5e0-1b80-7819aadabe10@epam.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi,

On 28/10/2021 15:16, Oleksandr Andrushchenko wrote:
> On 28.10.21 16:22, Julien Grall wrote:
>> On 28/10/2021 13:09, Oleksandr Andrushchenko wrote:
>>> Hi, Julien!
>>
>> Hello,
>>
>>> On 27.10.21 20:35, Julien Grall wrote:
>>>> Hi Oleksandr,
>>>>
>>>> On 27/10/2021 09:25, Oleksandr Andrushchenko wrote:
>>>>> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
>>>>>
>>>>> While in vPCI MMIO trap handlers for the guest PCI host bridge it is not
>>>>> enough for SBDF translation to simply call VPCI_ECAM_BDF(info->gpa) as
>>>>> the base address may not be aligned in the way that the translation
>>>>> always work. If not adjusted with respect to the base address it may not be
>>>>> able to properly convert SBDF and crashes:
>>>>>
>>>>> (XEN) vpci_mmio_read 0000:65:1a.0 reg 8bc gpa e65d08bc
>>>>
>>>> I can't find a printk() that may output this message. Where does this comes from?
>>> That was a debug print. I shouldn't have used that in the patch description, but
>>> probably after "---" to better explain what's happening
>>>>
>>>> Anyway, IIUC the guest physical address is 0xe65d08bc which, if I am not mistaken, doesn't belong to the range advertised for GUEST_VPCI_ECAM.
>>> This is from dom0 I am working on now.
>>>>
>>>> IMHO, the stack trace should come from usptream Xen or need some information to explain how this was reproduced.
>>>>
>>>>> (XEN) Data Abort Trap. Syndrome=0x6
>>>>> (XEN) Walking Hypervisor VA 0x467a28bc on CPU0 via TTBR 0x00000000481d5000
>>>> I can understnad that if we don't substract GUEST_VPCI_ECAM, we would (in theory) not get the correct BDF. But... I don't understand how this would result to a data abort in the hypervisor.
>>>>
>>>> In fact, I think the vPCI code should be resilient enough to not crash if we pass the wrong BDF.
>>> Well, there is no (?) easy way to validate SBDF.
>>
>> AFAICT pci_ecam_map_bus() is already doing some validation for the bus number. So...
> what it does is not enough as...
>       if ( busn < cfg->busn_start || busn > cfg->busn_end )
>           return NULL;
> 
>       busn -= cfg->busn_start;
>       base = cfg->win + (busn << ops->bus_shift);
> 
>       return base + (PCI_DEVFN2(sbdf.bdf) << devfn_shift) + where;
> this can still overrun

Thanks, I guessed this was not enough... What I am trying to understand 
is *why* this is not enough *and* whether we need to add more validation.

>>
>>   And this could be a problem if we have a misbehaving
>>> guest which may force Xen to access the memory beyond that of PCI host bridge
>>>>
>>>> When there is a data abort in Xen, you should get a stack trace from where this comes from. Can you paste it here?
>>> (XEN) Data Abort Trap. Syndrome=0x6
>>> (XEN) Walking Hypervisor VA 0x467a28bc on CPU0 via TTBR 0x00000000481d5000
>>> (XEN) 0TH[0x0] = 0x00000000481d4f7f
>>> (XEN) 1ST[0x1] = 0x00000000481d2f7f
>>> (XEN) 2ND[0x33] = 0x0000000000000000
>>> (XEN) CPU0: Unexpected Trap: Data Abort
>>
>> ... I am getting quite confused why this is crashing. Are we validation correctly the access?
> See above. If provided with big enough SBDF we can end up getting out of the window.

Shouldn't we validate that we are still in the window?

>>
>>
>>> (XEN) ----[ Xen-4.16-unstable  arm64 debug=y  Not tainted ]----
>>> (XEN) CPU:    0
>>> (XEN) PC:     000000000026d3d4 pci_generic_config_read+0x88/0x9c
>>> (XEN) LR:     000000000026d36c
>>> (XEN) SP:     000080007ff97c00
>>> (XEN) CPSR:   0000000060400249 MODE:64-bit EL2h (Hypervisor, handler)
>>> (XEN)      X0: 00000000467a28bc  X1: 00000000065d08bc  X2: 00000000000008bc
>>> (XEN)      X3: 000000000000000c  X4: 000080007ffc6fd0  X5: 0000000000000000
>>> (XEN)      X6: 0000000000000014  X7: ffff800011a58000  X8: ffff0000225a0380
>>> (XEN)      X9: 0000000000000000 X10: 0101010101010101 X11: 0000000000000028
>>> (XEN)     X12: 0101010101010101 X13: 0000000000000020 X14: ffffffffffffffff
>>> (XEN)     X15: 0000000000000001 X16: ffff800010da6708 X17: 0000000000000020
>>> (XEN)     X18: 0000000000000002 X19: 0000000000000004 X20: 000080007ff97c5c
>>> (XEN)     X21: 00000000000008bc X22: 00000000000008bc X23: 0000000000000004
>>> (XEN)     X24: 0000000000000000 X25: 00000000000008bc X26: 00000000000065d0
>>> (XEN)     X27: 000080007ffb9010 X28: 0000000000000000  FP: 000080007ff97c00
>>> (XEN)
>>> (XEN)   VTCR_EL2: 00000000800a3558
>>> (XEN)  VTTBR_EL2: 00010000bffba000
>>> (XEN)
>>> (XEN)  SCTLR_EL2: 0000000030cd183d
>>> (XEN)    HCR_EL2: 00000000807c663f
>>> (XEN)  TTBR0_EL2: 00000000481d5000
>>> (XEN)
>>> (XEN)    ESR_EL2: 0000000096000006
>>> (XEN)  HPFAR_EL2: 0000000000e65d00
>>> (XEN)    FAR_EL2: 00000000467a28bc
>>> (XEN)
>>> [snip]
>>> (XEN) Xen call trace:
>>> (XEN)    [<000000000026d3d4>] pci_generic_config_read+0x88/0x9c (PC)
>>> (XEN)    [<000000000026d36c>] pci_generic_config_read+0x20/0x9c (LR)
>>> (XEN)    [<000000000026d2c8>] pci-access.c#pci_config_read+0x60/0x84
>>> (XEN)    [<000000000026d4a8>] pci_conf_read32+0x10/0x18
>>> (XEN)    [<000000000024dcf8>] vpci.c#vpci_read_hw+0x48/0xb8
>>> (XEN)    [<000000000024e3e4>] vpci_read+0xac/0x24c
>>> (XEN)    [<000000000024e934>] vpci_ecam_read+0x78/0xa8
>>> (XEN)    [<000000000026e368>] vpci.c#vpci_mmio_read+0x44/0x7c
>>> (XEN)    [<0000000000275054>] try_handle_mmio+0x1ec/0x264
>>> (XEN)    [<000000000027ea50>] traps.c#do_trap_stage2_abort_guest+0x18c/0x2d8
>>> (XEN)    [<000000000027f088>] do_trap_guest_sync+0xf0/0x618
>>> (XEN)    [<0000000000269c58>] entry.o#guest_sync_slowpath+0xa4/0xd4
>>> (XEN)
>>> (XEN)
>>> (XEN) ****************************************
>>> (XEN) Panic on CPU 0:
>>> (XEN) CPU0: Unexpected Trap: Data Abort
>>> (XEN) ****************************************
>>>
>>>>
>>>>>
>>>>> Fix this by adjusting the gpa with respect to the host bridge base address
>>>>> in a way as it is done for x86.
>>>>>
>>>>> Fixes: d59168dc05a5 ("xen/arm: Enable the existing x86 virtual PCI support for ARM")
>>>>>
>>>>> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
>>>>> ---
>>>>>     xen/arch/arm/vpci.c | 4 ++--
>>>>>     1 file changed, 2 insertions(+), 2 deletions(-)
>>>>>
>>>>> diff --git a/xen/arch/arm/vpci.c b/xen/arch/arm/vpci.c
>>>>> index 8f40a0dec6d2..23f45386f4b3 100644
>>>>> --- a/xen/arch/arm/vpci.c
>>>>> +++ b/xen/arch/arm/vpci.c
>>>>> @@ -24,7 +24,7 @@ static int vpci_mmio_read(struct vcpu *v, mmio_info_t *info,
>>>>>         unsigned long data;
>>>>>           /* We ignore segment part and always handle segment 0 */
>>>>> -    sbdf.sbdf = VPCI_ECAM_BDF(info->gpa);
>>>>> +    sbdf.sbdf = VPCI_ECAM_BDF(info->gpa - GUEST_VPCI_ECAM_BASE);
>>>>
>>>> Looking at the rest of the rest, it seems that
>>>>    1) the issue is latent as the bits 0-27 are clear
>>>>    2) this will need to be modified to take into account dom0.
>>>>
>>>> So I would prefer if the base address is passed differently (maybe in priv?) from the start. This will avoid extra modification that you already plan to have in a follow-up series.
>>> I was thinking about the same, but the future code will use priv for other purpose:
>>>
>>> static int vpci_mmio_read(struct vcpu *v, mmio_info_t *info,
>>>                              register_t *r, void *p)
>>> {
>>>        struct pci_host_bridge *bridge = p;
>>>        pci_sbdf_t sbdf;
>>>        /* data is needed to prevent a pointer cast on 32bit */
>>>        unsigned long data;
>>>
>>>        if ( bridge )
>>>        {
>>>            sbdf.sbdf = VPCI_ECAM_BDF(info->gpa - bridge->cfg->phys_addr);
>>>            sbdf.seg = bridge->segment;
>>>        }
>>>        else
>>>            sbdf.sbdf = VPCI_ECAM_BDF(info->gpa - GUEST_VPCI_ECAM_BASE);
>>
>> Is it the only place you are doing to use bridge? If so, then I think we can simply have a structure that would contain phys_addr and segment.
>>
>> This would be include in the bridge for dom0 and for guest this could be a static global variable for now.
> Hm. I don't think a global is any better than using info->gpa - GUEST_VPCI_ECAM_BASE.
> But I am fine with the structure: please let me know your preference,
> so I can have an acceptable fix

The difference is you don't duplicate the same check in two places
Alternatively, I would be happy consider an helper that is used in both 
places.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Thu Oct 28 14:32:58 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Oct 2021 14:32:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.218110.378416 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg6SZ-0002gZ-WD; Thu, 28 Oct 2021 14:32:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 218110.378416; Thu, 28 Oct 2021 14:32:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg6SZ-0002gS-TD; Thu, 28 Oct 2021 14:32:51 +0000
Received: by outflank-mailman (input) for mailman id 218110;
 Thu, 28 Oct 2021 14:32:50 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=vfrR=PQ=suse.com=jgross@srs-us1.protection.inumbo.net>)
 id 1mg6SY-0002gM-OP
 for xen-devel@lists.xenproject.org; Thu, 28 Oct 2021 14:32:50 +0000
Received: from smtp-out1.suse.de (unknown [195.135.220.28])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 8fe34b82-edda-4c31-82b5-e264a555ac21;
 Thu, 28 Oct 2021 14:32:49 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 80F70218A9;
 Thu, 28 Oct 2021 14:32:48 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 5859713E9D;
 Thu, 28 Oct 2021 14:32:48 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id OCddFJC0emFAHwAAMHmgww
 (envelope-from <jgross@suse.com>); Thu, 28 Oct 2021 14:32:48 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8fe34b82-edda-4c31-82b5-e264a555ac21
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1635431568; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=hV0aji8Xm0Y3NQ8V/Q2GT040OXgKsgKtfYIluob1gto=;
	b=C9TBG1FR5q5LUh/IhECIcWh0Yon6Hhp1B6JkQKRG4bSj27Yz1UI9JmPhjlqmqbGLgT6rCf
	d7DineDy9aVIT7+3eiykMFvw7meVR8nPE/yOguQbSxYJBv/4EfPKbLWfnkjrJQEHuCGB+1
	bNiCFGdRKgtf3+hXO3RYKltRDSMbBZY=
To: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>, Wei Liu
 <wl@xen.org>, xen-devel@lists.xenproject.org
References: <20211015125152.25198-1-jgross@suse.com>
 <20211015125152.25198-11-jgross@suse.com>
 <88c3d815-912c-a92c-2e96-7eff6a454a75@suse.com>
From: Juergen Gross <jgross@suse.com>
Subject: Re: [PATCH 10/12] xen/x86: call hypercall handlers via switch
 statement
Message-ID: <1ab4b64f-720c-4f9a-043b-eefc5f6c387e@suse.com>
Date: Thu, 28 Oct 2021 16:32:47 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <88c3d815-912c-a92c-2e96-7eff6a454a75@suse.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="7cG2FgSE4RgsDyogCrwlNbbcVVSFi5EqW"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--7cG2FgSE4RgsDyogCrwlNbbcVVSFi5EqW
Content-Type: multipart/mixed; boundary="MqJMvy4m2NmcYWeGVGFjuyoD71HE6JLXC";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>, Wei Liu
 <wl@xen.org>, xen-devel@lists.xenproject.org
Message-ID: <1ab4b64f-720c-4f9a-043b-eefc5f6c387e@suse.com>
Subject: Re: [PATCH 10/12] xen/x86: call hypercall handlers via switch
 statement
References: <20211015125152.25198-1-jgross@suse.com>
 <20211015125152.25198-11-jgross@suse.com>
 <88c3d815-912c-a92c-2e96-7eff6a454a75@suse.com>
In-Reply-To: <88c3d815-912c-a92c-2e96-7eff6a454a75@suse.com>

--MqJMvy4m2NmcYWeGVGFjuyoD71HE6JLXC
Content-Type: multipart/mixed;
 boundary="------------DC02056F439CAFA9B34248DA"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------DC02056F439CAFA9B34248DA
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 21.10.21 16:41, Jan Beulich wrote:
> On 15.10.2021 14:51, Juergen Gross wrote:
>> Instead of using a function table use the generated switch statement
>> macros for calling the appropriate hypercall handlers.
>>
>> This is beneficial to performance and avoids speculation issues.
>>
>> With calling the handlers using the correct number of parameters now
>> it is possible to do the parameter register clobbering in the NDEBUG
>> case after returning from the handler. This in turn removes the only
>> users of hypercall_args_table[] which can be removed now.
>=20
> "removed" reads misleading to me: You really replace it by new tables,
> using script-generated initializers. Also it looks like you're doubling=

> the data, as the same sets were previously used by pv64/hvm64 and
> pv32/hvm32 respectively.

Yes, I'll change that paragraph.

Regarding having 4 tables on x86 now: merging the pv/hvm tables would be
possible, but this would add some complexity to the script generating
the tables (it should test whether the number of parameters of pv and
hvm match). As the tables are present in debug build only I don't think
this is a real issue.

>=20
>> --- a/xen/arch/x86/hvm/hypercall.c
>> +++ b/xen/arch/x86/hvm/hypercall.c
>> @@ -108,56 +108,10 @@ long hvm_physdev_op(int cmd, XEN_GUEST_HANDLE_PA=
RAM(void) arg)
>>           return compat_physdev_op(cmd, arg);
>>   }
>>  =20
>> -#define HYPERCALL(x)                                         \
>> -    [ __HYPERVISOR_ ## x ] =3D { (hypercall_fn_t *) do_ ## x,  \
>> -                               (hypercall_fn_t *) do_ ## x }
>> -
>> -#define HVM_CALL(x)                                          \
>> -    [ __HYPERVISOR_ ## x ] =3D { (hypercall_fn_t *) hvm_ ## x, \
>> -                               (hypercall_fn_t *) hvm_ ## x }
>> -
>> -#define COMPAT_CALL(x)                                       \
>> -    [ __HYPERVISOR_ ## x ] =3D { (hypercall_fn_t *) do_ ## x,  \
>> -                               (hypercall_fn_t *) compat_ ## x }
>> -
>> -static const struct {
>> -    hypercall_fn_t *native, *compat;
>> -} hvm_hypercall_table[] =3D {
>> -    HVM_CALL(memory_op),
>> -    COMPAT_CALL(multicall),
>> -#ifdef CONFIG_GRANT_TABLE
>> -    HVM_CALL(grant_table_op),
>> -#endif
>> -    HYPERCALL(vm_assist),
>> -    COMPAT_CALL(vcpu_op),
>> -    HVM_CALL(physdev_op),
>> -    COMPAT_CALL(xen_version),
>> -    HYPERCALL(console_io),
>> -    HYPERCALL(event_channel_op),
>> -    COMPAT_CALL(sched_op),
>> -    COMPAT_CALL(set_timer_op),
>> -    COMPAT_CALL(xsm_op),
>> -    HYPERCALL(hvm_op),
>> -    HYPERCALL(sysctl),
>> -    HYPERCALL(domctl),
>> -#ifdef CONFIG_ARGO
>> -    COMPAT_CALL(argo_op),
>> -#endif
>> -    COMPAT_CALL(platform_op),
>> -#ifdef CONFIG_PV
>> -    COMPAT_CALL(mmuext_op),
>> -#endif
>> -    HYPERCALL(xenpmu_op),
>> -    COMPAT_CALL(dm_op),
>> -#ifdef CONFIG_HYPFS
>> -    HYPERCALL(hypfs_op),
>> +#ifndef NDEBUG
>> +static unsigned char hypercall_args_64[] =3D hypercall_args_hvm64;
>> +static unsigned char hypercall_args_32[] =3D hypercall_args_hvm32;
>=20
> Irrespective of this being debugging-only: Const?

Yes.

>=20
>> @@ -239,33 +176,11 @@ int hvm_hypercall(struct cpu_user_regs *regs)
>>           HVM_DBG_LOG(DBG_LEVEL_HCALL, "hcall%lu(%lx, %lx, %lx, %lx, %=
lx)",
>>                       eax, rdi, rsi, rdx, r10, r8);
>>  =20
>> -#ifndef NDEBUG
>> -        /* Deliberately corrupt parameter regs not used by this hyper=
call. */
>> -        switch ( hypercall_args_table[eax].native )
>> -        {
>> -        case 0: rdi =3D 0xdeadbeefdeadf00dUL; fallthrough;
>> -        case 1: rsi =3D 0xdeadbeefdeadf00dUL; fallthrough;
>> -        case 2: rdx =3D 0xdeadbeefdeadf00dUL; fallthrough;
>> -        case 3: r10 =3D 0xdeadbeefdeadf00dUL; fallthrough;
>> -        case 4: r8 =3D 0xdeadbeefdeadf00dUL;
>> -        }
>> -#endif
>> -
>> -        regs->rax =3D hvm_hypercall_table[eax].native(rdi, rsi, rdx, =
r10, r8);
>> +        call_handlers_hvm64(eax, regs->rax, rdi, rsi, rdx, r10, r8);
>>  =20
>>   #ifndef NDEBUG
>> -        if ( !curr->hcall_preempted )
>> -        {
>> -            /* Deliberately corrupt parameter regs used by this hyper=
call. */
>> -            switch ( hypercall_args_table[eax].native )
>> -            {
>> -            case 5: regs->r8  =3D 0xdeadbeefdeadf00dUL; fallthrough;
>> -            case 4: regs->r10 =3D 0xdeadbeefdeadf00dUL; fallthrough;
>> -            case 3: regs->rdx =3D 0xdeadbeefdeadf00dUL; fallthrough;
>> -            case 2: regs->rsi =3D 0xdeadbeefdeadf00dUL; fallthrough;
>> -            case 1: regs->rdi =3D 0xdeadbeefdeadf00dUL;
>> -            }
>> -        }
>> +        if ( !curr->hcall_preempted && regs->rax !=3D -ENOSYS )
>> +            clobber_regs(regs, hypercall_args_64[eax]);
>=20
> I'm not fundamentally opposed, but sadly -ENOSYS comes back also in und=
ue
> situations, e.g. various hypercalls still produce this for "unknown
> sub-function". Hence the weakened clobbering wants at least mentioning,=

> perhaps also justifying, in the description.

Okay.

>=20
>> @@ -55,4 +42,34 @@ compat_common_vcpu_op(
>>  =20
>>   #endif /* CONFIG_COMPAT */
>>  =20
>> +#ifndef NDEBUG
>=20
> Hmm, I was actuall hoping for the conditional to actually live ...
>=20
>> +static inline void clobber_regs(struct cpu_user_regs *regs,
>> +                                unsigned int nargs)
>> +{
>=20
> ... here and ...
>=20
>> +    /* Deliberately corrupt used parameter regs. */
>> +    switch ( nargs )
>> +    {
>> +    case 5: regs->r8  =3D 0xdeadbeefdeadf00dUL; fallthrough;
>> +    case 4: regs->r10 =3D 0xdeadbeefdeadf00dUL; fallthrough;
>> +    case 3: regs->rdx =3D 0xdeadbeefdeadf00dUL; fallthrough;
>> +    case 2: regs->rsi =3D 0xdeadbeefdeadf00dUL; fallthrough;
>> +    case 1: regs->rdi =3D 0xdeadbeefdeadf00dUL;
>> +    }
>> +}
>> +
>> +static inline void clobber_regs32(struct cpu_user_regs *regs,
>> +                                  unsigned int nargs)
>> +{
>=20
> ... here, such that the conditionals in the .c files could go away
> altogether.

I didn't do that in order to be able to have the tables with the
number of parameters inside #ifndef NDEBUG sections.

I think I can change that by using a macro for reading the table
values.

>=20
>> +    /* Deliberately corrupt used parameter regs. */
>> +    switch ( nargs )
>> +    {
>> +    case 5: regs->edi =3D 0xdeadf00dUL; fallthrough;
>> +    case 4: regs->esi =3D 0xdeadf00dUL; fallthrough;
>> +    case 3: regs->edx =3D 0xdeadf00dUL; fallthrough;
>> +    case 2: regs->ecx =3D 0xdeadf00dUL; fallthrough;
>> +    case 1: regs->ebx =3D 0xdeadf00dUL;
>=20
> No need for the UL suffixes here afaics; U ones may want to be there.

Okay.

> Overall, besides these mainly cosmetic aspects the main thing missing
> is an approach to prioritize the handful most frequently used functions=
,
> for them to be pulled out of the switch() so we don't depend on the
> compiler's choice for the order of comparisons done.

I have already prepared that step by generating the complete call
sequence, so any change for prioritizing some hypercalls can be local to
the generator script and the used input data.

The main question is how to do that. I've collected some hypercall
statistics data for PV and PVH guests running some simple tests (once a
build of the Xen hypervisor, and once a scp of a large file). The data
is split between guest and dom0 (PV) counts. There is no clear "winner"
which hypercall should be fastest, but several hypercalls are clearly
not important.

Here is the data:

PV-hypercall    PV-guest build   PV-guest scp    dom0 build     dom0 scp
mmu_update           186175729           2865         20936        33725
stack_switch           1273311          62381        108589       270764
multicall              2182803             50           302          524
update_va_mapping       571868             10            60           80
xen_version              73061            850           859         5432
grant_table_op               0              0         35557       139110
iret                  75673006         484132        268157       757958
vcpu_op                 453037          71199        138224       334988
set_segment_base       1650249          62387        108645       270823
mmuext_op             11225681            188          7239         3426
sched_op                280153         134645         70729       137943
event_channel_op        192327          66204         71409       214191
physdev_op                   0              0          7721         4315
(the dom0 values are for the guest running the build or scp test, so
dom0 acting as backend)

HVM-hypercall   PVH-guest build    PVH-guest scp
vcpu_op                  277684             2324
event_channel_op         350233            57383
(the related dom0 counter values are in the same range as with the test
running in the PV guest)

It should be noted that during boot of the guests the numbers for the PV
guest are more like the ones for the build test with the exception of
iret and sched_op being higher, while for PVH sched_op is by far the
most often used hypercall.

I'm not sure how to translate those numbers into a good algorithm for
generating the call sequence.

I could add priorities to each hypercall in hypercall-defs.c and have a
cascade of if (likely(foo)) call_foo; else if (likely(bla)) ... else
switch(rest).

Or I could have groups of hypercalls with a priority for each group and:

mask =3D 1ULL << num;
if (likely(mask & prio_1_mask)) switch(num) ...
else if (likely(mask & prio_2_mask)) switch (num) ...
=2E..
else switch (num) ...

Or I could combine those approaches using the mask variant for cases of
multiple entries having the same priority and the direct call variant
for the cases of only a single entry having a specific priority.

And then there is the problem to set the priorities (fairly simple for
HVM, PV is more diffcult).


Juergen

--------------DC02056F439CAFA9B34248DA
Content-Type: application/pgp-keys;
 name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Transfer-Encoding: quoted-printable
Content-Description: OpenPGP public key
Content-Disposition: attachment;
 filename="OpenPGP_0xB0DE9DD628BF132F.asc"

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy=
cWx
w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O=
f8Z
d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y=
9bf
IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq=
G7/
377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR=
3Jv
c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA=
QIe
AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT=
hpw
dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0=
MbD
1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv=
oPH
Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v=
5QL
+qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ=
2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC=
QoL
BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr=
Wf0
teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC=
/nu
AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh=
ITT
d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm=
XBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz=
80h
SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC=
AcD
AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn=
FOX
gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1=
jnD
kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0=
N51
N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l=
otu
fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1=
tqS
EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA=
hsD
BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3=
g3O
ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5=
dM7
wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5=
D+j
LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm=
V2x
AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N=
Eaw
QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW=
nHI
s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR=
wgn
BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV=
bVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk=
pEd
IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA=
QAB
wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw=
Tbe
8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1=
vJz
Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8=
VGi
wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW=
svi
uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX=
zXs
ZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------DC02056F439CAFA9B34248DA--

--MqJMvy4m2NmcYWeGVGFjuyoD71HE6JLXC--

--7cG2FgSE4RgsDyogCrwlNbbcVVSFi5EqW
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmF6tI8FAwAAAAAACgkQsN6d1ii/Ey/B
0Qf+Me8eWhB5u72RWK3P0oSkzd2Zdt6ZCrKCWBagKvPXOsmAgTTeiW1q1UnxDxZEOm6ZmxhhVY5U
CXe+kleiHbwQd5aEL1Nz+ef7SCEgOShI+H6SznTkh+exe8hvg7299HhAlkKlyrZDuXv2eFvW5iZm
fatlCCr5WRrSDS/hPZD5zdoXnQM4LtEmxAHTr1gzM5GIeCVvpXElBbENEL/kUAp3rVygmMb0erfy
TDHv2SilQ1xnljDpfhOghiHPjqZ73uXl6WzhiBf83aDy1pbmce7BKv2ctoWoa8uverZh/+OJ9y7M
wkA/Qn6VDL/kG+YEYOi18d7xWw99UmUt4UUQN9ZrGg==
=b9KM
-----END PGP SIGNATURE-----

--7cG2FgSE4RgsDyogCrwlNbbcVVSFi5EqW--


From xen-devel-bounces@lists.xenproject.org Thu Oct 28 14:35:24 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Oct 2021 14:35:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.218117.378426 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg6Uu-0003KL-Cz; Thu, 28 Oct 2021 14:35:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 218117.378426; Thu, 28 Oct 2021 14:35:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg6Uu-0003KE-9u; Thu, 28 Oct 2021 14:35:16 +0000
Received: by outflank-mailman (input) for mailman id 218117;
 Thu, 28 Oct 2021 14:35:15 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=vfrR=PQ=suse.com=jgross@srs-us1.protection.inumbo.net>)
 id 1mg6Ut-0003K6-FI
 for xen-devel@lists.xenproject.org; Thu, 28 Oct 2021 14:35:15 +0000
Received: from smtp-out1.suse.de (unknown [195.135.220.28])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 42e9df40-37fc-11ec-84a5-12813bfff9fa;
 Thu, 28 Oct 2021 14:35:14 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 484FE21971;
 Thu, 28 Oct 2021 14:35:13 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 2391213E9D;
 Thu, 28 Oct 2021 14:35:13 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id Hb57ByG1emF0IAAAMHmgww
 (envelope-from <jgross@suse.com>); Thu, 28 Oct 2021 14:35:13 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 42e9df40-37fc-11ec-84a5-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1635431713; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=gXW6zl0c3Hc/TgIXbImSMoNAWWb2v5ChOXsCMwT6ZuU=;
	b=ufycYvLdsVrS3wrHeOK5rYG8nk/sHQvI3TGq7b8VtomXb6dDFaOYSg6I1e5fy5+8IuWWl8
	dyr/wQoChFqkulUjrvZ5yuqL8KkaH+yGivU2E94MMosQsSKQq8D10M4jQSeghnLS+P9wO7
	amSJdWyfvLTNYYmpird1vCnEW1bbqsc=
Subject: Re: [PATCH 12/12] xen/x86: add hypercall performance counters for
 hvm, correct pv
To: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>, Wei Liu
 <wl@xen.org>, xen-devel@lists.xenproject.org
References: <20211015125152.25198-1-jgross@suse.com>
 <20211015125152.25198-13-jgross@suse.com>
 <6570b0b9-0cde-a262-937c-b4e2e3f8e1e4@suse.com>
From: Juergen Gross <jgross@suse.com>
Message-ID: <ef18a8ad-460f-b4fd-2d8e-7cdc8b1fe980@suse.com>
Date: Thu, 28 Oct 2021 16:35:12 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <6570b0b9-0cde-a262-937c-b4e2e3f8e1e4@suse.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="lUvt0gcmM4E3dpvRm2tfk1m0BLe5mnDAx"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--lUvt0gcmM4E3dpvRm2tfk1m0BLe5mnDAx
Content-Type: multipart/mixed; boundary="LVwgB13r4EzE68ZrTEvUQa77dyAWAtcED";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>, Wei Liu
 <wl@xen.org>, xen-devel@lists.xenproject.org
Message-ID: <ef18a8ad-460f-b4fd-2d8e-7cdc8b1fe980@suse.com>
Subject: Re: [PATCH 12/12] xen/x86: add hypercall performance counters for
 hvm, correct pv
References: <20211015125152.25198-1-jgross@suse.com>
 <20211015125152.25198-13-jgross@suse.com>
 <6570b0b9-0cde-a262-937c-b4e2e3f8e1e4@suse.com>
In-Reply-To: <6570b0b9-0cde-a262-937c-b4e2e3f8e1e4@suse.com>

--LVwgB13r4EzE68ZrTEvUQa77dyAWAtcED
Content-Type: multipart/mixed;
 boundary="------------1C287D2BB2F17978B3ECE6C9"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------1C287D2BB2F17978B3ECE6C9
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 21.10.21 17:19, Jan Beulich wrote:
> On 15.10.2021 14:51, Juergen Gross wrote:
>> The HVM hypercall handler is missing incrementing the per hypercall
>> counters. Add that.
>>
>> The counters for PV are handled wrong, as they are not using
>> perf_incra() with the number of the hypercall as index, but are
>> incrementing the total number of hypercalls only. Fix that.
>=20
> Why do you say "total number"? Isn't it that all accounting goes into
> set_trap_table's slot, effectively making that slot a "total number"
> despite not being labeled that way?

Oh, right. Will correct.

> Also this fix renders largely redundant the calls_to_multicall counter.=

> Could I talk you into deleting that at the same time? (As to the "not
> fully redundant": I consider it suspicious that this counter gets
> incremented at the bottom of the function, not at the top.)

I think I'll just another patch doing that.

> Finally I take it that with the Kconfig setting being under DEBUG, we
> don't consider security supported builds with PERF_COUNTERS enabled.
> Otherwise as a prereq I would think perfc_incra() would need teaching
> of array_index_nospec().

I agree.

> In any event, preferably with at least the description slightly
> adjusted,
> Reviewed-by: Jan Beulich <jbeulich@suse.com>

Thanks.


Juergen


--------------1C287D2BB2F17978B3ECE6C9
Content-Type: application/pgp-keys;
 name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Transfer-Encoding: quoted-printable
Content-Description: OpenPGP public key
Content-Disposition: attachment;
 filename="OpenPGP_0xB0DE9DD628BF132F.asc"

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy=
cWx
w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O=
f8Z
d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y=
9bf
IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq=
G7/
377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR=
3Jv
c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA=
QIe
AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT=
hpw
dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0=
MbD
1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv=
oPH
Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v=
5QL
+qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ=
2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC=
QoL
BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr=
Wf0
teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC=
/nu
AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh=
ITT
d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm=
XBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz=
80h
SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC=
AcD
AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn=
FOX
gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1=
jnD
kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0=
N51
N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l=
otu
fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1=
tqS
EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA=
hsD
BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3=
g3O
ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5=
dM7
wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5=
D+j
LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm=
V2x
AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N=
Eaw
QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW=
nHI
s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR=
wgn
BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV=
bVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk=
pEd
IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA=
QAB
wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw=
Tbe
8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1=
vJz
Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8=
VGi
wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW=
svi
uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX=
zXs
ZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------1C287D2BB2F17978B3ECE6C9--

--LVwgB13r4EzE68ZrTEvUQa77dyAWAtcED--

--lUvt0gcmM4E3dpvRm2tfk1m0BLe5mnDAx
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmF6tSAFAwAAAAAACgkQsN6d1ii/Ey9H
tAf/WijgbrR9C89hehAwaFMXvZjMdj0KA3xASiqb/ZDUsIq8RWnntJ4cSOAH/1xVoKho3J2mte1V
ikGlo74ITXHYSPtYtpoz7QX7PpAEQ9m9rIddy4IZ50hg+dl+/LCpGJGqZdoq6CbdcqiUotzVhL04
mR0/fDYO3qG1mCg2ERkJ/2HEyPqKnvbXdm/Vkv2uEru5j1pWRELLKC6wkyAIgzeDfTbg0L0OzZNi
bwGOUMuRNuvl1Tf3iWsuMXlyXsKDIUt9tQdLFln9XnEiEqGn1VYmmEoOoA4LPQGawYj/EKebPKTU
bc8/hM0d0QF6tSWu95dLQkIvLDgWG/IILopXLB92kA==
=ydGK
-----END PGP SIGNATURE-----

--lUvt0gcmM4E3dpvRm2tfk1m0BLe5mnDAx--


From xen-devel-bounces@lists.xenproject.org Thu Oct 28 14:36:39 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Oct 2021 14:36:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.218121.378438 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg6W9-0003v3-Oc; Thu, 28 Oct 2021 14:36:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 218121.378438; Thu, 28 Oct 2021 14:36:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg6W9-0003uv-L9; Thu, 28 Oct 2021 14:36:33 +0000
Received: by outflank-mailman (input) for mailman id 218121;
 Thu, 28 Oct 2021 14:36:32 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=sO6D=PQ=gmail.com=andr2000@srs-us1.protection.inumbo.net>)
 id 1mg6W8-0003up-P6
 for xen-devel@lists.xenproject.org; Thu, 28 Oct 2021 14:36:32 +0000
Received: from mail-wr1-x434.google.com (unknown [2a00:1450:4864:20::434])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 3fc72607-c5c8-408d-b8e5-87ea81cef5ad;
 Thu, 28 Oct 2021 14:36:31 +0000 (UTC)
Received: by mail-wr1-x434.google.com with SMTP id v17so10572567wrv.9
 for <xen-devel@lists.xenproject.org>; Thu, 28 Oct 2021 07:36:31 -0700 (PDT)
Received: from localhost.localdomain ([185.199.97.5])
 by smtp.gmail.com with ESMTPSA id u2sm3031883wrr.35.2021.10.28.07.36.22
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Thu, 28 Oct 2021 07:36:25 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3fc72607-c5c8-408d-b8e5-87ea81cef5ad
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:mime-version
         :content-transfer-encoding;
        bh=NuKSKhq+LJNFGWFZ54Znk00tU2bQ3a59y26xZbZTkY0=;
        b=W2vlhm9tTlOftcdPxk+krlNZe5bJyaEc9INyl9aZOmX0JqlW0LB83IqsqkRAdLZpEt
         9qHoUCPaIvYTle2ZYNS9mImwSPWMdq6K0CrQnwzAuyXAByCIZHc1bZUhsyI6u9ncqv/S
         YUUz27FPxpnK715X/s53yStC1zZuyM0gIgIIkzqz61xc5FmGj+FdNi76AIfhlWFKi9Ab
         bxjRWFe/h2+XO7uKVFLAWmf2PO/eP9N1IXadKdFwWjPy9MneuTQAnWMw+7IRnK3g/RQ7
         kh/ed6q7qHu52er9YUezkfj9vgSqOlSzdSur4hZH+foK2esnFF5hZALIc4onrbEBKKqt
         HyYA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version
         :content-transfer-encoding;
        bh=NuKSKhq+LJNFGWFZ54Znk00tU2bQ3a59y26xZbZTkY0=;
        b=7NHDC5idM8b3voFCUj00sedsL8rQhWPAfAq/cY+QXMrgFFL7WQxFlkIXRA8mKrW1bW
         pYfN9LNgdScxIFZ79e9tlnEiyXEpDGgTrsdi15zpmTCDhURySRBPM7HjYhF+00/sM/yA
         /muxfNAjCGNqqb7h8lMMki/jJCfL1YwufPFjRakBgNnPTRWxwyyIGIRCXXxbVPyhZUK2
         K5hRqRh/q/QNvt8cX7ZJ59N6HwRMavmaFvuGyTM8b+B7mYnFfGBYYKB2g/RYSIAXGa+D
         vmIcrFByMrPvPhh5vRrYY2Ht7jQh68L1PtJGzZYrPdpDRmTDk2Xs+wFfMBxkYwYyTAHm
         KXCQ==
X-Gm-Message-State: AOAM532s3qxlOwHWcPjlo1jUdwCk5Ql6IYBbPgAA29qPPwo3wnws32ar
	31nmgzG0X+9TteZiAk+lo5FqiTmtA2aw7g==
X-Google-Smtp-Source: ABdhPJzFJfOBFsIqpLg+wXJlDeWk4mdZzne8R5XqGAVKRMVYViBs3aYpt3BfeizpR7Kkv6BJLAoU3A==
X-Received: by 2002:a5d:4b8e:: with SMTP id b14mr6045996wrt.259.1635431789876;
        Thu, 28 Oct 2021 07:36:29 -0700 (PDT)
From: Oleksandr Andrushchenko <andr2000@gmail.com>
To: xen-devel@lists.xenproject.org,
	linux-kernel@vger.kernel.org
Cc: boris.ostrovsky@oracle.com,
	jgross@suse.com,
	julien@xen.org,
	sstabellini@kernel.org,
	jbeulich@suse.com,
	Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>,
	Anastasiia Lukianenko <anastasiia_lukianenko@epam.com>
Subject: [RESEND PATCH v6] xen-pciback: allow compiling on other archs than x86
Date: Thu, 28 Oct 2021 17:36:20 +0300
Message-Id: <20211028143620.144936-1-andr2000@gmail.com>
X-Mailer: git-send-email 2.25.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>

Xen-pciback driver was designed to be built for x86 only. But it
can also be used by other architectures, e.g. Arm.

Currently PCI backend implements multiple functionalities at a time,
such as:
1. It is used as a database for assignable PCI devices, e.g. xl
   pci-assignable-{add|remove|list} manipulates that list. So, whenever
   the toolstack needs to know which PCI devices can be passed through
   it reads that from the relevant sysfs entries of the pciback.
2. It is used to hold the unbound PCI devices list, e.g. when passing
   through a PCI device it needs to be unbound from the relevant device
   driver and bound to pciback (strictly speaking it is not required
   that the device is bound to pciback, but pciback is again used as a
   database of the passed through PCI devices, so we can re-bind the
   devices back to their original drivers when guest domain shuts down)
3. Device reset for the devices being passed through
4. Para-virtualised use-cases support

The para-virtualised part of the driver is not always needed as some
architectures, e.g. Arm or x86 PVH Dom0, are not using backend-frontend
model for PCI device passthrough.

For such use-cases make the very first step in splitting the
xen-pciback driver into two parts: Xen PCI stub and PCI PV backend
drivers.

For that add new configuration options CONFIG_XEN_PCI_STUB and
CONFIG_XEN_PCIDEV_STUB, so the driver can be limited in its
functionality, e.g. no support for para-virtualised scenario.
x86 platform will continue using CONFIG_XEN_PCIDEV_BACKEND for the
fully featured backend driver.

Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Signed-off-by: Anastasiia Lukianenko <anastasiia_lukianenko@epam.com>
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
Reviewed-by: Juergen Gross <jgross@suse.com>
---
Changes since v5:
- rebased
- fixed a warning found by:
  Reported-by: kernel test robot <lkp@intel.com>
  All warnings (new ones prefixed by >>):
  >> drivers/xen/pci.c:279:5: warning: no previous prototype for 'xen_find_device_domain_owner' [-Wmissing-prototypes]
Changes since v4:
- squashed two patches
- simplified Makefile
Changes since v3:
 - Fix >>32 shift for 32-bit architectures
Changes since v2:
 - swap the patch order
Since v1:
 - Do not move pci_xen_initial_domain as it is x86 specific
---
 arch/x86/include/asm/xen/pci.h              | 19 ------
 arch/x86/pci/xen.c                          | 76 +--------------------
 drivers/xen/Kconfig                         | 24 +++++++
 drivers/xen/Makefile                        |  2 +-
 drivers/xen/pci.c                           | 76 +++++++++++++++++++++
 drivers/xen/xen-pciback/Makefile            |  7 ++
 drivers/xen/xen-pciback/conf_space_header.c |  8 ++-
 drivers/xen/xen-pciback/pci_stub.c          |  3 +-
 drivers/xen/xen-pciback/pciback.h           |  5 ++
 drivers/xen/xen-pciback/xenbus.c            |  8 ++-
 include/xen/pci.h                           | 28 ++++++++
 11 files changed, 156 insertions(+), 100 deletions(-)
 create mode 100644 include/xen/pci.h

diff --git a/arch/x86/include/asm/xen/pci.h b/arch/x86/include/asm/xen/pci.h
index 4557f7cb0fa6..9015b888edd6 100644
--- a/arch/x86/include/asm/xen/pci.h
+++ b/arch/x86/include/asm/xen/pci.h
@@ -22,25 +22,6 @@ static inline int __init pci_xen_initial_domain(void)
 	return -1;
 }
 #endif
-#ifdef CONFIG_XEN_DOM0
-int xen_find_device_domain_owner(struct pci_dev *dev);
-int xen_register_device_domain_owner(struct pci_dev *dev, uint16_t domain);
-int xen_unregister_device_domain_owner(struct pci_dev *dev);
-#else
-static inline int xen_find_device_domain_owner(struct pci_dev *dev)
-{
-	return -1;
-}
-static inline int xen_register_device_domain_owner(struct pci_dev *dev,
-						   uint16_t domain)
-{
-	return -1;
-}
-static inline int xen_unregister_device_domain_owner(struct pci_dev *dev)
-{
-	return -1;
-}
-#endif
 
 #if defined(CONFIG_PCI_MSI)
 #if defined(CONFIG_PCI_XEN)
diff --git a/arch/x86/pci/xen.c b/arch/x86/pci/xen.c
index 5debe4ac6f81..12da00558631 100644
--- a/arch/x86/pci/xen.c
+++ b/arch/x86/pci/xen.c
@@ -23,6 +23,7 @@
 
 #include <xen/features.h>
 #include <xen/events.h>
+#include <xen/pci.h>
 #include <asm/xen/pci.h>
 #include <asm/xen/cpuid.h>
 #include <asm/apic.h>
@@ -585,78 +586,3 @@ int __init pci_xen_initial_domain(void)
 }
 #endif
 
-#ifdef CONFIG_XEN_DOM0
-
-struct xen_device_domain_owner {
-	domid_t domain;
-	struct pci_dev *dev;
-	struct list_head list;
-};
-
-static DEFINE_SPINLOCK(dev_domain_list_spinlock);
-static struct list_head dev_domain_list = LIST_HEAD_INIT(dev_domain_list);
-
-static struct xen_device_domain_owner *find_device(struct pci_dev *dev)
-{
-	struct xen_device_domain_owner *owner;
-
-	list_for_each_entry(owner, &dev_domain_list, list) {
-		if (owner->dev == dev)
-			return owner;
-	}
-	return NULL;
-}
-
-int xen_find_device_domain_owner(struct pci_dev *dev)
-{
-	struct xen_device_domain_owner *owner;
-	int domain = -ENODEV;
-
-	spin_lock(&dev_domain_list_spinlock);
-	owner = find_device(dev);
-	if (owner)
-		domain = owner->domain;
-	spin_unlock(&dev_domain_list_spinlock);
-	return domain;
-}
-EXPORT_SYMBOL_GPL(xen_find_device_domain_owner);
-
-int xen_register_device_domain_owner(struct pci_dev *dev, uint16_t domain)
-{
-	struct xen_device_domain_owner *owner;
-
-	owner = kzalloc(sizeof(struct xen_device_domain_owner), GFP_KERNEL);
-	if (!owner)
-		return -ENODEV;
-
-	spin_lock(&dev_domain_list_spinlock);
-	if (find_device(dev)) {
-		spin_unlock(&dev_domain_list_spinlock);
-		kfree(owner);
-		return -EEXIST;
-	}
-	owner->domain = domain;
-	owner->dev = dev;
-	list_add_tail(&owner->list, &dev_domain_list);
-	spin_unlock(&dev_domain_list_spinlock);
-	return 0;
-}
-EXPORT_SYMBOL_GPL(xen_register_device_domain_owner);
-
-int xen_unregister_device_domain_owner(struct pci_dev *dev)
-{
-	struct xen_device_domain_owner *owner;
-
-	spin_lock(&dev_domain_list_spinlock);
-	owner = find_device(dev);
-	if (!owner) {
-		spin_unlock(&dev_domain_list_spinlock);
-		return -ENODEV;
-	}
-	list_del(&owner->list);
-	spin_unlock(&dev_domain_list_spinlock);
-	kfree(owner);
-	return 0;
-}
-EXPORT_SYMBOL_GPL(xen_unregister_device_domain_owner);
-#endif /* CONFIG_XEN_DOM0 */
diff --git a/drivers/xen/Kconfig b/drivers/xen/Kconfig
index 1b2c3aca6887..a1b11c62da9e 100644
--- a/drivers/xen/Kconfig
+++ b/drivers/xen/Kconfig
@@ -181,10 +181,34 @@ config SWIOTLB_XEN
 	select DMA_OPS
 	select SWIOTLB
 
+config XEN_PCI_STUB
+	bool
+
+config XEN_PCIDEV_STUB
+	tristate "Xen PCI-device stub driver"
+	depends on PCI && !X86 && XEN
+	depends on XEN_BACKEND
+	select XEN_PCI_STUB
+	default m
+	help
+	  The PCI device stub driver provides limited version of the PCI
+	  device backend driver without para-virtualized support for guests.
+	  If you select this to be a module, you will need to make sure no
+	  other driver has bound to the device(s) you want to make visible to
+	  other guests.
+
+	  The "hide" parameter (only applicable if backend driver is compiled
+	  into the kernel) allows you to bind the PCI devices to this module
+	  from the default device drivers. The argument is the list of PCI BDFs:
+	  xen-pciback.hide=(03:00.0)(04:00.0)
+
+	  If in doubt, say m.
+
 config XEN_PCIDEV_BACKEND
 	tristate "Xen PCI-device backend driver"
 	depends on PCI && X86 && XEN
 	depends on XEN_BACKEND
+	select XEN_PCI_STUB
 	default m
 	help
 	  The PCI device backend driver allows the kernel to export arbitrary
diff --git a/drivers/xen/Makefile b/drivers/xen/Makefile
index 3434593455b2..5aae66e638a7 100644
--- a/drivers/xen/Makefile
+++ b/drivers/xen/Makefile
@@ -24,7 +24,7 @@ obj-$(CONFIG_XEN_SYS_HYPERVISOR)	+= sys-hypervisor.o
 obj-$(CONFIG_XEN_PVHVM_GUEST)		+= platform-pci.o
 obj-$(CONFIG_SWIOTLB_XEN)		+= swiotlb-xen.o
 obj-$(CONFIG_XEN_MCE_LOG)		+= mcelog.o
-obj-$(CONFIG_XEN_PCIDEV_BACKEND)	+= xen-pciback/
+obj-$(CONFIG_XEN_PCI_STUB)	        += xen-pciback/
 obj-$(CONFIG_XEN_PRIVCMD)		+= xen-privcmd.o
 obj-$(CONFIG_XEN_ACPI_PROCESSOR)	+= xen-acpi-processor.o
 obj-$(CONFIG_XEN_EFI)			+= efi.o
diff --git a/drivers/xen/pci.c b/drivers/xen/pci.c
index 224df03ce42e..2c890f4f2cbc 100644
--- a/drivers/xen/pci.c
+++ b/drivers/xen/pci.c
@@ -8,6 +8,7 @@
 #include <linux/pci.h>
 #include <linux/acpi.h>
 #include <linux/pci-acpi.h>
+#include <xen/pci.h>
 #include <xen/xen.h>
 #include <xen/interface/physdev.h>
 #include <xen/interface/xen.h>
@@ -254,3 +255,78 @@ static int xen_mcfg_late(void)
 	return 0;
 }
 #endif
+
+#ifdef CONFIG_XEN_DOM0
+struct xen_device_domain_owner {
+	domid_t domain;
+	struct pci_dev *dev;
+	struct list_head list;
+};
+
+static DEFINE_SPINLOCK(dev_domain_list_spinlock);
+static struct list_head dev_domain_list = LIST_HEAD_INIT(dev_domain_list);
+
+static struct xen_device_domain_owner *find_device(struct pci_dev *dev)
+{
+	struct xen_device_domain_owner *owner;
+
+	list_for_each_entry(owner, &dev_domain_list, list) {
+		if (owner->dev == dev)
+			return owner;
+	}
+	return NULL;
+}
+
+int xen_find_device_domain_owner(struct pci_dev *dev)
+{
+	struct xen_device_domain_owner *owner;
+	int domain = -ENODEV;
+
+	spin_lock(&dev_domain_list_spinlock);
+	owner = find_device(dev);
+	if (owner)
+		domain = owner->domain;
+	spin_unlock(&dev_domain_list_spinlock);
+	return domain;
+}
+EXPORT_SYMBOL_GPL(xen_find_device_domain_owner);
+
+int xen_register_device_domain_owner(struct pci_dev *dev, uint16_t domain)
+{
+	struct xen_device_domain_owner *owner;
+
+	owner = kzalloc(sizeof(struct xen_device_domain_owner), GFP_KERNEL);
+	if (!owner)
+		return -ENODEV;
+
+	spin_lock(&dev_domain_list_spinlock);
+	if (find_device(dev)) {
+		spin_unlock(&dev_domain_list_spinlock);
+		kfree(owner);
+		return -EEXIST;
+	}
+	owner->domain = domain;
+	owner->dev = dev;
+	list_add_tail(&owner->list, &dev_domain_list);
+	spin_unlock(&dev_domain_list_spinlock);
+	return 0;
+}
+EXPORT_SYMBOL_GPL(xen_register_device_domain_owner);
+
+int xen_unregister_device_domain_owner(struct pci_dev *dev)
+{
+	struct xen_device_domain_owner *owner;
+
+	spin_lock(&dev_domain_list_spinlock);
+	owner = find_device(dev);
+	if (!owner) {
+		spin_unlock(&dev_domain_list_spinlock);
+		return -ENODEV;
+	}
+	list_del(&owner->list);
+	spin_unlock(&dev_domain_list_spinlock);
+	kfree(owner);
+	return 0;
+}
+EXPORT_SYMBOL_GPL(xen_unregister_device_domain_owner);
+#endif
diff --git a/drivers/xen/xen-pciback/Makefile b/drivers/xen/xen-pciback/Makefile
index e8d981d43235..d63df09de81c 100644
--- a/drivers/xen/xen-pciback/Makefile
+++ b/drivers/xen/xen-pciback/Makefile
@@ -1,5 +1,12 @@
 # SPDX-License-Identifier: GPL-2.0
+
+# N.B. The below cannot be expressed with a single line using
+# CONFIG_XEN_PCI_STUB as it always remains in "y" state,
+# thus preventing the driver to be built as a module.
+# Please note, that CONFIG_XEN_PCIDEV_BACKEND and
+# CONFIG_XEN_PCIDEV_STUB are mutually exclusive.
 obj-$(CONFIG_XEN_PCIDEV_BACKEND) += xen-pciback.o
+obj-$(CONFIG_XEN_PCIDEV_STUB) += xen-pciback.o
 
 xen-pciback-y := pci_stub.o pciback_ops.o xenbus.o
 xen-pciback-y += conf_space.o conf_space_header.o \
diff --git a/drivers/xen/xen-pciback/conf_space_header.c b/drivers/xen/xen-pciback/conf_space_header.c
index ac45cdc38e85..981435103af1 100644
--- a/drivers/xen/xen-pciback/conf_space_header.c
+++ b/drivers/xen/xen-pciback/conf_space_header.c
@@ -236,8 +236,12 @@ static void *bar_init(struct pci_dev *dev, int offset)
 	else {
 		pos = (offset - PCI_BASE_ADDRESS_0) / 4;
 		if (pos && (res[pos - 1].flags & IORESOURCE_MEM_64)) {
-			bar->val = res[pos - 1].start >> 32;
-			bar->len_val = -resource_size(&res[pos - 1]) >> 32;
+			/*
+			 * Use ">> 16 >> 16" instead of direct ">> 32" shift
+			 * to avoid warnings on 32-bit architectures.
+			 */
+			bar->val = res[pos - 1].start >> 16 >> 16;
+			bar->len_val = -resource_size(&res[pos - 1]) >> 16 >> 16;
 			return bar;
 		}
 	}
diff --git a/drivers/xen/xen-pciback/pci_stub.c b/drivers/xen/xen-pciback/pci_stub.c
index f8e4faa96ad6..bba527620507 100644
--- a/drivers/xen/xen-pciback/pci_stub.c
+++ b/drivers/xen/xen-pciback/pci_stub.c
@@ -19,7 +19,8 @@
 #include <linux/sched.h>
 #include <linux/atomic.h>
 #include <xen/events.h>
-#include <asm/xen/pci.h>
+#include <xen/pci.h>
+#include <xen/xen.h>
 #include <asm/xen/hypervisor.h>
 #include <xen/interface/physdev.h>
 #include "pciback.h"
diff --git a/drivers/xen/xen-pciback/pciback.h b/drivers/xen/xen-pciback/pciback.h
index 95e28ee48d52..9a64196e831d 100644
--- a/drivers/xen/xen-pciback/pciback.h
+++ b/drivers/xen/xen-pciback/pciback.h
@@ -71,6 +71,11 @@ struct pci_dev *pcistub_get_pci_dev(struct xen_pcibk_device *pdev,
 				    struct pci_dev *dev);
 void pcistub_put_pci_dev(struct pci_dev *dev);
 
+static inline bool xen_pcibk_pv_support(void)
+{
+	return IS_ENABLED(CONFIG_XEN_PCIDEV_BACKEND);
+}
+
 /* Ensure a device is turned off or reset */
 void xen_pcibk_reset_device(struct pci_dev *pdev);
 
diff --git a/drivers/xen/xen-pciback/xenbus.c b/drivers/xen/xen-pciback/xenbus.c
index c09c7ebd6968..bde63ef677b8 100644
--- a/drivers/xen/xen-pciback/xenbus.c
+++ b/drivers/xen/xen-pciback/xenbus.c
@@ -14,7 +14,7 @@
 #include <linux/workqueue.h>
 #include <xen/xenbus.h>
 #include <xen/events.h>
-#include <asm/xen/pci.h>
+#include <xen/pci.h>
 #include "pciback.h"
 
 #define INVALID_EVTCHN_IRQ  (-1)
@@ -743,6 +743,9 @@ const struct xen_pcibk_backend *__read_mostly xen_pcibk_backend;
 
 int __init xen_pcibk_xenbus_register(void)
 {
+	if (!xen_pcibk_pv_support())
+		return 0;
+
 	xen_pcibk_backend = &xen_pcibk_vpci_backend;
 	if (passthrough)
 		xen_pcibk_backend = &xen_pcibk_passthrough_backend;
@@ -752,5 +755,6 @@ int __init xen_pcibk_xenbus_register(void)
 
 void __exit xen_pcibk_xenbus_unregister(void)
 {
-	xenbus_unregister_driver(&xen_pcibk_driver);
+	if (xen_pcibk_pv_support())
+		xenbus_unregister_driver(&xen_pcibk_driver);
 }
diff --git a/include/xen/pci.h b/include/xen/pci.h
new file mode 100644
index 000000000000..b8337cf85fd1
--- /dev/null
+++ b/include/xen/pci.h
@@ -0,0 +1,28 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+
+#ifndef __XEN_PCI_H__
+#define __XEN_PCI_H__
+
+#if defined(CONFIG_XEN_DOM0)
+int xen_find_device_domain_owner(struct pci_dev *dev);
+int xen_register_device_domain_owner(struct pci_dev *dev, uint16_t domain);
+int xen_unregister_device_domain_owner(struct pci_dev *dev);
+#else
+static inline int xen_find_device_domain_owner(struct pci_dev *dev)
+{
+	return -1;
+}
+
+static inline int xen_register_device_domain_owner(struct pci_dev *dev,
+						   uint16_t domain)
+{
+	return -1;
+}
+
+static inline int xen_unregister_device_domain_owner(struct pci_dev *dev)
+{
+	return -1;
+}
+#endif
+
+#endif
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Thu Oct 28 14:39:54 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Oct 2021 14:39:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.218132.378449 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg6ZG-0004gC-CR; Thu, 28 Oct 2021 14:39:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 218132.378449; Thu, 28 Oct 2021 14:39:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg6ZG-0004g5-8f; Thu, 28 Oct 2021 14:39:46 +0000
Received: by outflank-mailman (input) for mailman id 218132;
 Thu, 28 Oct 2021 14:39:44 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ikAZ=PQ=epam.com=prvs=19352d112c=oleksandr_andrushchenko@srs-us1.protection.inumbo.net>)
 id 1mg6ZE-0004fz-SX
 for xen-devel@lists.xenproject.org; Thu, 28 Oct 2021 14:39:44 +0000
Received: from mx0a-0039f301.pphosted.com (unknown [148.163.133.242])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id e2fe0a92-37fc-11ec-84a5-12813bfff9fa;
 Thu, 28 Oct 2021 14:39:42 +0000 (UTC)
Received: from pps.filterd (m0174679.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 19SEdWaT000675; 
 Thu, 28 Oct 2021 14:39:41 GMT
Received: from eur05-vi1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2174.outbound.protection.outlook.com [104.47.17.174])
 by mx0a-0039f301.pphosted.com with ESMTP id 3bywtf801g-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Thu, 28 Oct 2021 14:39:40 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by AM0PR03MB4147.eurprd03.prod.outlook.com (2603:10a6:208:cf::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.15; Thu, 28 Oct
 2021 14:39:35 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::c038:e032:595a:651]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::c038:e032:595a:651%9]) with mapi id 15.20.4649.015; Thu, 28 Oct 2021
 14:39:35 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e2fe0a92-37fc-11ec-84a5-12813bfff9fa
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=UPtCD30RpRYB1+ZC0BzonCGcf1xNRuL+e4a1yTTe+niHYZQTQk3Va+uxlYEQJ9g2TBE2JHoqvDucHoOv2OFwlFp7FnpxtU4/g5bkHt7ag7CGcWFfYVVrsIYWd8vAePtUNMmo7WS0TUKnO+lCkNT0wkZtzMT2q1ohn+7t7UWGgbFvoIOKIUJdNBjhDUZSlv5JcfBV6CkT/TzzfWTrC48yvdlpsr52DnZlr/Cec4C76bcL+b7/Pne+xNQa2clkmgm8M9AeW18iAVTp5a/gxxGtwqWMlJRh1QeE0RioQodg/TZZFP6eDwezB9qDrhU8CkAKHxdDl0w8V2mWG3pzuwZ6zg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=4UR/c+DHQivn/j8a6aYUCPsv74J+U9DQKuBogtvLLug=;
 b=YS8OO95VO5X+IZ6uPOPNWVtedXmheVZbpyAFojbfPYMvVoyHERdRPoBPWtkpB5VjP5pWwBRaImZAkMNxzYsg4E634QJwkTpFBo95OPoR5s8tRqCZqhHdo41elK2XufiYwg6btjEcyGOOSYic1l4V5DY0OZ+bOjZ6ltDECLKZszi0eJbZfncy9GjBM1f4DbD7a6G/hpdf4ycLlfNLFZnG4gNh8xN5CaRczn7rihTePKAh4PxEfUl15nN5GP3m/0Ny3PmXsLvn0hoGwaDYCQoY635pBs7m+t4UtGivZ/15uQOIK1eQRqT3Sl8PDBat5a9BKKrucfybe/B6yzod5cDKpg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=4UR/c+DHQivn/j8a6aYUCPsv74J+U9DQKuBogtvLLug=;
 b=3iz/DC2J5JCEoecXTKPA0xzMp3ZTgLKV+mcp3cE6yND54rB76mafVFy/oyLrQMXSpY1Vl0/rRKEg5lwdhg6xt/D5i0F5tqHtI5xNX5czp+S+BW7FFRvChC+ds+ntm2TMkL3f/jnSGAKuFlai9LTRYOxVAbdiv9+0kXqv7OQyf68IG9SMTnkIdLc7wQaMK5Wd2xvvSmo6UrLmVqtNp2q2A37pucYiD/J6nyQgewKyvyba+SDtdurbBxNoWfqyFQfsdaPJoeIkqVo0ywspgV2ndp+y0w4MQWtFluUeIucJHUvPPX7AfhdBXVJ5fQ3D/sNYo8JZIfnqj+kzDT4O3Tz2iQ==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "boris.ostrovsky@oracle.com" <boris.ostrovsky@oracle.com>
CC: "jgross@suse.com" <jgross@suse.com>, "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org" <sstabellini@kernel.org>,
        "jbeulich@suse.com"
	<jbeulich@suse.com>,
        Oleksandr Andrushchenko
	<Oleksandr_Andrushchenko@epam.com>,
        Anastasiia Lukianenko
	<Anastasiia_Lukianenko@epam.com>
Subject: Re: [PATCH] xen-pciback: allow compiling on other archs than x86
Thread-Topic: [PATCH] xen-pciback: allow compiling on other archs than x86
Thread-Index: AQHXy8L4matlcvklF0O8ro+XGa1E1qvoe7kA
Date: Thu, 28 Oct 2021 14:39:35 +0000
Message-ID: <57a26095-e62d-ed15-a9b5-d95a51ae32d4@epam.com>
References: <20211028061341.1479333-1-andr2000@gmail.com>
In-Reply-To: <20211028061341.1479333-1-andr2000@gmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 2f2973a4-35a3-42f2-9629-08d99a20c36d
x-ms-traffictypediagnostic: AM0PR03MB4147:
x-microsoft-antispam-prvs: 
 <AM0PR03MB4147626504933A8597DD9794E7869@AM0PR03MB4147.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:8882;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 1PFFAswphDcURfhDB5uVRiUy6VkylzkQZAexEg8ldD2Vq5MhB6mJr+9x+uSWxvPJ36HEHBJJUeEq8sUjgIJ89jwYTbDjrYGTHAYOsbM+P5uio6u5LchutbMqGNtqifVH2DZVn3n9bQRTUOp4yzQrGzkx5QEHSthCUIzkKYXtOp+GKwvykKCEJ98krW3lHK4h93in9IF8ugLJAwOPDATXo298KGOj0CK+DPAjFi+EAn+TuOHJz3D3CNdQgsvyvr0ByH7OHpSHowxk5N+1Amm/MsdQ0Ksy+S8NfmGg4Zbjn8/PVCSIDawtXmMBdWoSLlmpy22vWFM0tat8ncIC2GJzOPthQU5GCeu4fdV+B96koItmeqV/udxuZ1Rbm8RQtea6UyDc182G3bShGlp01ONsVESs5CCdIv5MD46Xsueglz+Pqcc0dXhmZi+I+8fRT9lOsM7uEjDnxPt07Dnxk81E0jGBrRZSSsVDeKxB+mvDYIjYt1+nGi7YnU0HYwSxo1f+idBSy/mwRHMcn/HT9z0R06IeeW22w4nfPhuN6ehIVRGKwZK9XTuS8LeYCGHrJ55o6dJ1nvBcAIW2WPUVc5kK1EkdUfvoWNc0F/MRIWSO8efQdGrMlPXyo2MxbdDosDBrjq9FiXxL1xzgswaTDyNMDgIcJwYwg7wtyoGlsQ3Wvp33xO4eyQTQukMKanSr0+1FU3hwyP269cCPrTxfvwBwSoiHseOFmvN9REsbf7R3sbW8/m8N4pMGYnO6jVuUBD1v9W/a8j7XJPh9qTMTCr0W0o/NzwpfGUiyr7/USqEMWJ1iZPUrMTmYueYxLnuv5Ke8lMlDYv3hu4gtbRoh1AKE10mBkpUyBqfpKpbHCEL5KEs=
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(107886003)(36756003)(83380400001)(30864003)(2616005)(966005)(91956017)(38100700002)(122000001)(316002)(38070700005)(508600001)(5660300002)(8676002)(66946007)(31686004)(6512007)(66556008)(66476007)(64756008)(2906002)(66446008)(76116006)(71200400001)(4326008)(54906003)(110136005)(86362001)(8936002)(53546011)(6486002)(31696002)(6506007)(26005)(186003)(45980500001)(579004);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?RDNRaEJPVldtbFV3M1dwQ2RnTGVHMDB0eDlwKys5U0QyNlZKenUrbHQxWEhJ?=
 =?utf-8?B?Rk9xMUtPTFJSemJzL0Rpb1pIMEw1OVZHaVB1czAvM3VpOFdxT3pDRmFtVTYr?=
 =?utf-8?B?bnh0ZlQ5ZWlCQTVRK1MwNXhFZkhPVWpMb1B0VzBHY1duZVBhTUp3VU1oSXRP?=
 =?utf-8?B?T20yejVOcU0vUW80My9hanl2bmxXRTJsVFBQSkxjREJOREl2K0hVSEU4OTZ6?=
 =?utf-8?B?Q0hrZFArUGtqQzJVZTNVTVJ3dkVic01tdXlIK1R0SW1hd2FMeDhHdSszMWVv?=
 =?utf-8?B?ZFJZUVlpMEx0b0FVaE9xZWE2M1BkL3Z3SDFtUjQ5b3pKWmpDWnhEaG1KMjBE?=
 =?utf-8?B?YUZqbk9NM3hDRG1pZjVyay8wNWhmSnZrNUh2WGh3TGx2dFdYcFg0cjducXNt?=
 =?utf-8?B?SnB2REx4Mm1ZWmVkRUtZcExSVEFFYWNQbksrQ1piLzBZMzk3U0wzMitqWlZ3?=
 =?utf-8?B?L0llYzkyNjVCVmFpRmRwSWV5Y0YvbjZ3QThNMjl5MWFTb3pOb0dlODQ5VjF1?=
 =?utf-8?B?WExxM3FNeHlRdWgraS9ZNGFXZmxaNmtVVUxkaklKdUhua2hmWk5Xa3RUYU5V?=
 =?utf-8?B?ci9BcmJvS3ptRnZKd2Ixb2p4d1RydGIwMDQ5T3lMSmdZaSt4aFpUUGlDdEpX?=
 =?utf-8?B?K3pkUEs2Tm1HbWREeWhaUFpXbkJBSndFeTVxK2swZFVOYVRHMjMwa081czhu?=
 =?utf-8?B?THNyaGptREI2bGFaZGdCVkJKcFhRQ1E5NDZUM01sNFlyUXBhTWRTdUJxYi81?=
 =?utf-8?B?YVJJTCtlR3NSZTVwc29XajBzUzkwcTUrQkFTTWpPOHpIZ2dzOGZLNTVnY2c4?=
 =?utf-8?B?TEVPQ1Q4STExR0JjYjIwUlA5cUZQZVJRMWhMM1lpbGZob014Q0FOV3dyb3Na?=
 =?utf-8?B?WkNMdnpEcFVocERCVDdXQXBoUm9pQ1hMbDcyYjBWZXhiY1g5WkxIUGVmdGZY?=
 =?utf-8?B?Z2pySkxnQnRaN3J0a3VWbVozZENuZVlabGNKMGtMYXZ3SE5la3JzV0NhRDgx?=
 =?utf-8?B?cFIrQW5hVFdHekNKUlhCcU1LKzRFU2l1MVZZdTJDVk5rOEZzdmtubG0vMUFQ?=
 =?utf-8?B?T29NYUZBV1hjYTk2K2NnS1R6S0VVQnNDbDAybWdrK1doTFZocUdvc3dKZ0Fn?=
 =?utf-8?B?V05JYWYweHo0Z0xiVUNReHRtOGhVcjhzSnJadFVuQ1pVQkhTQmxVbmdCUXJ5?=
 =?utf-8?B?V2VtUFFYOGRCVHF5djF3VlN6Q0p5SzZVTlNjVTViZStNVFlPZVdjZktXMXlj?=
 =?utf-8?B?V2NMSkU2c2RmaWQ2dVFjSE56blJCV1o2OEI1dFhqQ1V0WWlMT0pSV3A0OTc5?=
 =?utf-8?B?bk1VVTZvcVBVZ09HZis0OElUQ1k5NGRoL2htRThlK0ZQa01iek5oaTFWSlpG?=
 =?utf-8?B?YWpwRXQ4Y1FsditPb2xLRDlOU0FFYUw4WHdleXNnS01tSFN6V3Y5bHpXRWdM?=
 =?utf-8?B?QzE4OHZSVjVWVDdzTE5WWFdrMStza0xhYjF2KzlnVmpXWVRBenNXbWNaeFI1?=
 =?utf-8?B?eUE5Mis4RkEyM0gxZjdPY1pwSHFSVE9JREg1THVyOXBEZHR0TkJlcEtpeGVC?=
 =?utf-8?B?Q2xCMDdUOE5KdjdUNm04dGlEZGhDREVCMXVhQks5SmQvQ0hiaTJyM00rU0Zo?=
 =?utf-8?B?QUZ0bUZTK245dElyUmlZR1lIQ3ZQcUdNM1RNWEpBZGJZdHh0U09za2RtLzRT?=
 =?utf-8?B?emNlUzlBQTFrbThMSTFaR1ZVK2tQNEVmUEh2b1VHR3hET1dmbDdEMkFNMkxs?=
 =?utf-8?B?d1hNMTBiaGQ2VmdIZzMzdklWdDcrcldjYjNYS3cyYWgzcEZ0ZU1uNU9rUXdM?=
 =?utf-8?B?WHlpNVlYUFN0cEg3TEZSd1lrSWloRk1vUmwvdXpHSVZFTTJreUM3VERZZldJ?=
 =?utf-8?B?WVovb1dNUWpLSnIzbEpGVkhuMnNCRVFYdEVqbk93OGMwRU1YaEpjSEl0OTE3?=
 =?utf-8?B?ZVZYT0tHL29sY3k5V0sybHZuTjFORWZHQlZPWkVJQnI4MUdwSlJnUXhYZGZO?=
 =?utf-8?B?dkhNWWF0UnlrNmlkQlpQS2l1WVd5R1Q5RS8wTHZ6eE0wUzlDLzJITVEwd3ZW?=
 =?utf-8?B?ZU8rbHdmNWpxNnhJRk8rM2gwRHY0eWpCcjdIMHZuWEpzTUNwUlhDUHd4ZGxl?=
 =?utf-8?B?YkpKb21EdkZIUTR3MWhDcDVnTUI0NFU1aEZGMmgzVGFsd2w5d3RHVVZTeHZL?=
 =?utf-8?B?WlVwcCsrM1ZGWFYvczc3OW9HcThsZVBhRlgxVlZZbzloUjg0c1o4Z1J5eHBn?=
 =?utf-8?B?ZVlWWjVtVzVDZ2tNYWFubS92czBOS08vWG4zUWRndjVBb280UDA4NlNnV0l2?=
 =?utf-8?B?RSswSVF5N1RBc0RZYmNmV29jZDZwdWhQTVRTbEVrdGQ4N1lBOWw3UT09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <4FABE0271AAD574DB274A9AF1242C79D@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2f2973a4-35a3-42f2-9629-08d99a20c36d
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Oct 2021 14:39:35.6960
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: V/lQSchkCriMGa02BSVn+bBA6l1y7fZsviSjdY02ttJbwVz3b+ETKp1tmfTMcjMs9ITUZjozCN+XuSz2vArSOQVq5yZKwfNldGOyli53+1L7kxZ8EEg6nrJTNuDhzRgp
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR03MB4147
X-Proofpoint-GUID: x2zSfIGSXsAM5rdQElezQVtwbqOjZr9Z
X-Proofpoint-ORIG-GUID: x2zSfIGSXsAM5rdQElezQVtwbqOjZr9Z
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475
 definitions=2021-10-28_01,2021-10-26_01,2020-04-07_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0
 malwarescore=0 phishscore=0 spamscore=0 clxscore=1015 suspectscore=0
 mlxscore=0 bulkscore=0 priorityscore=1501 adultscore=0 mlxlogscore=999
 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2110280082

UGxlYXNlIGlnbm9yZSB0aGlzIHBhdGNoIGluIGZhdm9yIG9mICJSRVNFTkQgUEFUQ0ggdjYiIGR1
ZSB0bw0KYSB3YXJuaW5nIHJlcG9ydGVkIGJ5IGtlcm5lbCB0ZXN0IHJvYm90IDxsa3BAaW50ZWwu
Y29tPjoNCg0KSSBsb3ZlIHlvdXIgcGF0Y2ghIFBlcmhhcHMgc29tZXRoaW5nIHRvIGltcHJvdmU6
DQoNClthdXRvIGJ1aWxkIHRlc3QgV0FSTklORyBvbiB4ZW4tdGlwL2xpbnV4LW5leHRdDQpbYWxz
byBidWlsZCB0ZXN0IFdBUk5JTkcgb24gbGludXgvbWFzdGVyIGxpbnVzL21hc3RlciB2NS4xNS1y
YzcgbmV4dC0yMDIxMTAyOF0NCltjYW5ub3QgYXBwbHkgdG8gaGVsZ2Fhcy1wY2kvbmV4dF0NCltJ
ZiB5b3VyIHBhdGNoIGlzIGFwcGxpZWQgdG8gdGhlIHdyb25nIGdpdCB0cmVlLCBraW5kbHkgZHJv
cCB1cyBhIG5vdGUuDQpBbmQgd2hlbiBzdWJtaXR0aW5nIHBhdGNoLCB3ZSBzdWdnZXN0IHRvIHVz
ZSAnLS1iYXNlJyBhcyBkb2N1bWVudGVkIGluDQpodHRwczovL2dpdC1zY20uY29tL2RvY3MvZ2l0
LWZvcm1hdC1wYXRjaF0NCg0KdXJsOmh0dHBzOi8vZ2l0aHViLmNvbS8wZGF5LWNpL2xpbnV4L2Nv
bW1pdHMvT2xla3NhbmRyLUFuZHJ1c2hjaGVua28veGVuLXBjaWJhY2stYWxsb3ctY29tcGlsaW5n
LW9uLW90aGVyLWFyY2hzLXRoYW4teDg2LzIwMjExMDI4LTE0MTUyMw0KYmFzZTpodHRwczovL2dp
dC5rZXJuZWwub3JnL3B1Yi9zY20vbGludXgva2VybmVsL2dpdC94ZW4vdGlwLmdpdCAgbGludXgt
bmV4dA0KY29uZmlnOiBhcm02NC1kZWZjb25maWcgKGF0dGFjaGVkIGFzIC5jb25maWcpDQpjb21w
aWxlcjogYWFyY2g2NC1saW51eC1nY2MgKEdDQykgMTEuMi4wDQpyZXByb2R1Y2UgKHRoaXMgaXMg
YSBXPTEgYnVpbGQpOg0KICAgICAgICAgd2dldGh0dHBzOi8vcmF3LmdpdGh1YnVzZXJjb250ZW50
LmNvbS9pbnRlbC9sa3AtdGVzdHMvbWFzdGVyL3NiaW4vbWFrZS5jcm9zcyAgLU8gfi9iaW4vbWFr
ZS5jcm9zcw0KICAgICAgICAgY2htb2QgK3ggfi9iaW4vbWFrZS5jcm9zcw0KICAgICAgICAgI2h0
dHBzOi8vZ2l0aHViLmNvbS8wZGF5LWNpL2xpbnV4L2NvbW1pdC8wODVhNzI3OWQwZDg1NDk3Njg4
YmM1YmU5YTFmMDBhYjJjY2UwMmFlDQogICAgICAgICBnaXQgcmVtb3RlIGFkZCBsaW51eC1yZXZp
ZXdodHRwczovL2dpdGh1Yi5jb20vMGRheS1jaS9saW51eA0KICAgICAgICAgZ2l0IGZldGNoIC0t
bm8tdGFncyBsaW51eC1yZXZpZXcgT2xla3NhbmRyLUFuZHJ1c2hjaGVua28veGVuLXBjaWJhY2st
YWxsb3ctY29tcGlsaW5nLW9uLW90aGVyLWFyY2hzLXRoYW4teDg2LzIwMjExMDI4LTE0MTUyMw0K
ICAgICAgICAgZ2l0IGNoZWNrb3V0IDA4NWE3Mjc5ZDBkODU0OTc2ODhiYzViZTlhMWYwMGFiMmNj
ZTAyYWUNCiAgICAgICAgICMgc2F2ZSB0aGUgYXR0YWNoZWQgLmNvbmZpZyB0byBsaW51eCBidWls
ZCB0cmVlDQogICAgICAgICBDT01QSUxFUl9JTlNUQUxMX1BBVEg9JEhPTUUvMGRheSBDT01QSUxF
Uj1nY2MtMTEuMi4wIG1ha2UuY3Jvc3MgQVJDSD1hcm02NA0KDQpJZiB5b3UgZml4IHRoZSBpc3N1
ZSwga2luZGx5IGFkZCBmb2xsb3dpbmcgdGFnIGFzIGFwcHJvcHJpYXRlDQpSZXBvcnRlZC1ieTog
a2VybmVsIHRlc3Qgcm9ib3Q8bGtwQGludGVsLmNvbT4NCg0KQWxsIHdhcm5pbmdzIChuZXcgb25l
cyBwcmVmaXhlZCBieSA+Pik6DQoNCj4+IGRyaXZlcnMveGVuL3BjaS5jOjI3OTo1OiB3YXJuaW5n
OiBubyBwcmV2aW91cyBwcm90b3R5cGUgZm9yICd4ZW5fZmluZF9kZXZpY2VfZG9tYWluX293bmVy
JyBbLVdtaXNzaW5nLXByb3RvdHlwZXNdDQoNCiAgICAgIDI3OSB8IGludCB4ZW5fZmluZF9kZXZp
Y2VfZG9tYWluX293bmVyKHN0cnVjdCBwY2lfZGV2ICpkZXYpDQogICAgICAgICAgfCAgICAgXn5+
fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fg0KDQo+PiBkcml2ZXJzL3hlbi9wY2kuYzoyOTM6NTog
d2FybmluZzogbm8gcHJldmlvdXMgcHJvdG90eXBlIGZvciAneGVuX3JlZ2lzdGVyX2RldmljZV9k
b21haW5fb3duZXInIFstV21pc3NpbmctcHJvdG90eXBlc10NCg0KICAgICAgMjkzIHwgaW50IHhl
bl9yZWdpc3Rlcl9kZXZpY2VfZG9tYWluX293bmVyKHN0cnVjdCBwY2lfZGV2ICpkZXYsIHVpbnQx
Nl90IGRvbWFpbikNCiAgICAgICAgICB8ICAgICBefn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+
fn5+fg0KDQo+PiBkcml2ZXJzL3hlbi9wY2kuYzozMTU6NTogd2FybmluZzogbm8gcHJldmlvdXMg
cHJvdG90eXBlIGZvciAneGVuX3VucmVnaXN0ZXJfZGV2aWNlX2RvbWFpbl9vd25lcicgWy1XbWlz
c2luZy1wcm90b3R5cGVzXQ0KDQogICAgICAzMTUgfCBpbnQgeGVuX3VucmVnaXN0ZXJfZGV2aWNl
X2RvbWFpbl9vd25lcihzdHJ1Y3QgcGNpX2RldiAqZGV2KQ0KICAgICAgICAgIHwgICAgIF5+fn5+
fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn4NCg0KDQp2aW0gKy94ZW5fZmluZF9kZXZpY2Vf
ZG9tYWluX293bmVyICsyNzkgZHJpdmVycy94ZW4vcGNpLmMNCg0KICAgIDI3OAkNCiAgPiAyNzkJ
aW50IHhlbl9maW5kX2RldmljZV9kb21haW5fb3duZXIoc3RydWN0IHBjaV9kZXYgKmRldikNCiAg
ICAyODAJew0KICAgIDI4MQkJc3RydWN0IHhlbl9kZXZpY2VfZG9tYWluX293bmVyICpvd25lcjsN
CiAgICAyODIJCWludCBkb21haW4gPSAtRU5PREVWOw0KICAgIDI4MwkNCiAgICAyODQJCXNwaW5f
bG9jaygmZGV2X2RvbWFpbl9saXN0X3NwaW5sb2NrKTsNCiAgICAyODUJCW93bmVyID0gZmluZF9k
ZXZpY2UoZGV2KTsNCiAgICAyODYJCWlmIChvd25lcikNCiAgICAyODcJCQlkb21haW4gPSBvd25l
ci0+ZG9tYWluOw0KICAgIDI4OAkJc3Bpbl91bmxvY2soJmRldl9kb21haW5fbGlzdF9zcGlubG9j
ayk7DQogICAgMjg5CQlyZXR1cm4gZG9tYWluOw0KICAgIDI5MAl9DQogICAgMjkxCUVYUE9SVF9T
WU1CT0xfR1BMKHhlbl9maW5kX2RldmljZV9kb21haW5fb3duZXIpOw0KICAgIDI5MgkNCiAgPiAy
OTMJaW50IHhlbl9yZWdpc3Rlcl9kZXZpY2VfZG9tYWluX293bmVyKHN0cnVjdCBwY2lfZGV2ICpk
ZXYsIHVpbnQxNl90IGRvbWFpbikNCiAgICAyOTQJew0KICAgIDI5NQkJc3RydWN0IHhlbl9kZXZp
Y2VfZG9tYWluX293bmVyICpvd25lcjsNCiAgICAyOTYJDQogICAgMjk3CQlvd25lciA9IGt6YWxs
b2Moc2l6ZW9mKHN0cnVjdCB4ZW5fZGV2aWNlX2RvbWFpbl9vd25lciksIEdGUF9LRVJORUwpOw0K
ICAgIDI5OAkJaWYgKCFvd25lcikNCiAgICAyOTkJCQlyZXR1cm4gLUVOT0RFVjsNCiAgICAzMDAJ
DQogICAgMzAxCQlzcGluX2xvY2soJmRldl9kb21haW5fbGlzdF9zcGlubG9jayk7DQogICAgMzAy
CQlpZiAoZmluZF9kZXZpY2UoZGV2KSkgew0KICAgIDMwMwkJCXNwaW5fdW5sb2NrKCZkZXZfZG9t
YWluX2xpc3Rfc3BpbmxvY2spOw0KICAgIDMwNAkJCWtmcmVlKG93bmVyKTsNCiAgICAzMDUJCQly
ZXR1cm4gLUVFWElTVDsNCiAgICAzMDYJCX0NCiAgICAzMDcJCW93bmVyLT5kb21haW4gPSBkb21h
aW47DQogICAgMzA4CQlvd25lci0+ZGV2ID0gZGV2Ow0KICAgIDMwOQkJbGlzdF9hZGRfdGFpbCgm
b3duZXItPmxpc3QsICZkZXZfZG9tYWluX2xpc3QpOw0KICAgIDMxMAkJc3Bpbl91bmxvY2soJmRl
dl9kb21haW5fbGlzdF9zcGlubG9jayk7DQogICAgMzExCQlyZXR1cm4gMDsNCiAgICAzMTIJfQ0K
ICAgIDMxMwlFWFBPUlRfU1lNQk9MX0dQTCh4ZW5fcmVnaXN0ZXJfZGV2aWNlX2RvbWFpbl9vd25l
cik7DQogICAgMzE0CQ0KICA+IDMxNQlpbnQgeGVuX3VucmVnaXN0ZXJfZGV2aWNlX2RvbWFpbl9v
d25lcihzdHJ1Y3QgcGNpX2RldiAqZGV2KQ0KDQpPbiAyOC4xMC4yMSAwOToxMywgT2xla3NhbmRy
IEFuZHJ1c2hjaGVua28gd3JvdGU6DQo+IEZyb206IE9sZWtzYW5kciBBbmRydXNoY2hlbmtvIDxv
bGVrc2FuZHJfYW5kcnVzaGNoZW5rb0BlcGFtLmNvbT4NCj4NCj4gWGVuLXBjaWJhY2sgZHJpdmVy
IHdhcyBkZXNpZ25lZCB0byBiZSBidWlsdCBmb3IgeDg2IG9ubHkuIEJ1dCBpdA0KPiBjYW4gYWxz
byBiZSB1c2VkIGJ5IG90aGVyIGFyY2hpdGVjdHVyZXMsIGUuZy4gQXJtLg0KPg0KPiBDdXJyZW50
bHkgUENJIGJhY2tlbmQgaW1wbGVtZW50cyBtdWx0aXBsZSBmdW5jdGlvbmFsaXRpZXMgYXQgYSB0
aW1lLA0KPiBzdWNoIGFzOg0KPiAxLiBJdCBpcyB1c2VkIGFzIGEgZGF0YWJhc2UgZm9yIGFzc2ln
bmFibGUgUENJIGRldmljZXMsIGUuZy4geGwNCj4gICAgIHBjaS1hc3NpZ25hYmxlLXthZGR8cmVt
b3ZlfGxpc3R9IG1hbmlwdWxhdGVzIHRoYXQgbGlzdC4gU28sIHdoZW5ldmVyDQo+ICAgICB0aGUg
dG9vbHN0YWNrIG5lZWRzIHRvIGtub3cgd2hpY2ggUENJIGRldmljZXMgY2FuIGJlIHBhc3NlZCB0
aHJvdWdoDQo+ICAgICBpdCByZWFkcyB0aGF0IGZyb20gdGhlIHJlbGV2YW50IHN5c2ZzIGVudHJp
ZXMgb2YgdGhlIHBjaWJhY2suDQo+IDIuIEl0IGlzIHVzZWQgdG8gaG9sZCB0aGUgdW5ib3VuZCBQ
Q0kgZGV2aWNlcyBsaXN0LCBlLmcuIHdoZW4gcGFzc2luZw0KPiAgICAgdGhyb3VnaCBhIFBDSSBk
ZXZpY2UgaXQgbmVlZHMgdG8gYmUgdW5ib3VuZCBmcm9tIHRoZSByZWxldmFudCBkZXZpY2UNCj4g
ICAgIGRyaXZlciBhbmQgYm91bmQgdG8gcGNpYmFjayAoc3RyaWN0bHkgc3BlYWtpbmcgaXQgaXMg
bm90IHJlcXVpcmVkDQo+ICAgICB0aGF0IHRoZSBkZXZpY2UgaXMgYm91bmQgdG8gcGNpYmFjaywg
YnV0IHBjaWJhY2sgaXMgYWdhaW4gdXNlZCBhcyBhDQo+ICAgICBkYXRhYmFzZSBvZiB0aGUgcGFz
c2VkIHRocm91Z2ggUENJIGRldmljZXMsIHNvIHdlIGNhbiByZS1iaW5kIHRoZQ0KPiAgICAgZGV2
aWNlcyBiYWNrIHRvIHRoZWlyIG9yaWdpbmFsIGRyaXZlcnMgd2hlbiBndWVzdCBkb21haW4gc2h1
dHMgZG93bikNCj4gMy4gRGV2aWNlIHJlc2V0IGZvciB0aGUgZGV2aWNlcyBiZWluZyBwYXNzZWQg
dGhyb3VnaA0KPiA0LiBQYXJhLXZpcnR1YWxpc2VkIHVzZS1jYXNlcyBzdXBwb3J0DQo+DQo+IFRo
ZSBwYXJhLXZpcnR1YWxpc2VkIHBhcnQgb2YgdGhlIGRyaXZlciBpcyBub3QgYWx3YXlzIG5lZWRl
ZCBhcyBzb21lDQo+IGFyY2hpdGVjdHVyZXMsIGUuZy4gQXJtIG9yIHg4NiBQVkggRG9tMCwgYXJl
IG5vdCB1c2luZyBiYWNrZW5kLWZyb250ZW5kDQo+IG1vZGVsIGZvciBQQ0kgZGV2aWNlIHBhc3N0
aHJvdWdoLg0KPg0KPiBGb3Igc3VjaCB1c2UtY2FzZXMgbWFrZSB0aGUgdmVyeSBmaXJzdCBzdGVw
IGluIHNwbGl0dGluZyB0aGUNCj4geGVuLXBjaWJhY2sgZHJpdmVyIGludG8gdHdvIHBhcnRzOiBY
ZW4gUENJIHN0dWIgYW5kIFBDSSBQViBiYWNrZW5kDQo+IGRyaXZlcnMuDQo+DQo+IEZvciB0aGF0
IGFkZCBuZXcgY29uZmlndXJhdGlvbiBvcHRpb25zIENPTkZJR19YRU5fUENJX1NUVUIgYW5kDQo+
IENPTkZJR19YRU5fUENJREVWX1NUVUIsIHNvIHRoZSBkcml2ZXIgY2FuIGJlIGxpbWl0ZWQgaW4g
aXRzDQo+IGZ1bmN0aW9uYWxpdHksIGUuZy4gbm8gc3VwcG9ydCBmb3IgcGFyYS12aXJ0dWFsaXNl
ZCBzY2VuYXJpby4NCj4geDg2IHBsYXRmb3JtIHdpbGwgY29udGludWUgdXNpbmcgQ09ORklHX1hF
Tl9QQ0lERVZfQkFDS0VORCBmb3IgdGhlDQo+IGZ1bGx5IGZlYXR1cmVkIGJhY2tlbmQgZHJpdmVy
Lg0KPg0KPiBTaWduZWQtb2ZmLWJ5OiBPbGVrc2FuZHIgQW5kcnVzaGNoZW5rbyA8b2xla3NhbmRy
X2FuZHJ1c2hjaGVua29AZXBhbS5jb20+DQo+IFNpZ25lZC1vZmYtYnk6IEFuYXN0YXNpaWEgTHVr
aWFuZW5rbyA8YW5hc3Rhc2lpYV9sdWtpYW5lbmtvQGVwYW0uY29tPg0KPiBSZXZpZXdlZC1ieTog
U3RlZmFubyBTdGFiZWxsaW5pIDxzc3RhYmVsbGluaUBrZXJuZWwub3JnPg0KPiBSZXZpZXdlZC1i
eTogSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuY29tPg0KPiAtLS0NCj4gQ2hhbmdlcyBzaW5j
ZSB2NToNCj4gLSByZWJhc2VkDQo+IENoYW5nZXMgc2luY2UgdjQ6DQo+IC0gc3F1YXNoZWQgdHdv
IHBhdGNoZXMNCj4gLSBzaW1wbGlmaWVkIE1ha2VmaWxlDQo+IENoYW5nZXMgc2luY2UgdjM6DQo+
ICAgLSBGaXggPj4zMiBzaGlmdCBmb3IgMzItYml0IGFyY2hpdGVjdHVyZXMNCj4gQ2hhbmdlcyBz
aW5jZSB2MjoNCj4gICAtIHN3YXAgdGhlIHBhdGNoIG9yZGVyDQo+IFNpbmNlIHYxOg0KPiAgIC0g
RG8gbm90IG1vdmUgcGNpX3hlbl9pbml0aWFsX2RvbWFpbiBhcyBpdCBpcyB4ODYgc3BlY2lmaWMN
Cj4gLS0tDQo+ICAgYXJjaC94ODYvaW5jbHVkZS9hc20veGVuL3BjaS5oICAgICAgICAgICAgICB8
IDE5IC0tLS0tLQ0KPiAgIGFyY2gveDg2L3BjaS94ZW4uYyAgICAgICAgICAgICAgICAgICAgICAg
ICAgfCA3NiArLS0tLS0tLS0tLS0tLS0tLS0tLS0NCj4gICBkcml2ZXJzL3hlbi9LY29uZmlnICAg
ICAgICAgICAgICAgICAgICAgICAgIHwgMjQgKysrKysrKw0KPiAgIGRyaXZlcnMveGVuL01ha2Vm
aWxlICAgICAgICAgICAgICAgICAgICAgICAgfCAgMiArLQ0KPiAgIGRyaXZlcnMveGVuL3BjaS5j
ICAgICAgICAgICAgICAgICAgICAgICAgICAgfCA3NSArKysrKysrKysrKysrKysrKysrKw0KPiAg
IGRyaXZlcnMveGVuL3hlbi1wY2liYWNrL01ha2VmaWxlICAgICAgICAgICAgfCAgNyArKw0KPiAg
IGRyaXZlcnMveGVuL3hlbi1wY2liYWNrL2NvbmZfc3BhY2VfaGVhZGVyLmMgfCAgOCArKy0NCj4g
ICBkcml2ZXJzL3hlbi94ZW4tcGNpYmFjay9wY2lfc3R1Yi5jICAgICAgICAgIHwgIDMgKy0NCj4g
ICBkcml2ZXJzL3hlbi94ZW4tcGNpYmFjay9wY2liYWNrLmggICAgICAgICAgIHwgIDUgKysNCj4g
ICBkcml2ZXJzL3hlbi94ZW4tcGNpYmFjay94ZW5idXMuYyAgICAgICAgICAgIHwgIDggKystDQo+
ICAgaW5jbHVkZS94ZW4vcGNpLmggICAgICAgICAgICAgICAgICAgICAgICAgICB8IDI4ICsrKysr
KysrDQo+ICAgMTEgZmlsZXMgY2hhbmdlZCwgMTU1IGluc2VydGlvbnMoKyksIDEwMCBkZWxldGlv
bnMoLSkNCj4gICBjcmVhdGUgbW9kZSAxMDA2NDQgaW5jbHVkZS94ZW4vcGNpLmgNCj4NCj4gZGlm
ZiAtLWdpdCBhL2FyY2gveDg2L2luY2x1ZGUvYXNtL3hlbi9wY2kuaCBiL2FyY2gveDg2L2luY2x1
ZGUvYXNtL3hlbi9wY2kuaA0KPiBpbmRleCA0NTU3ZjdjYjBmYTYuLjkwMTViODg4ZWRkNiAxMDA2
NDQNCj4gLS0tIGEvYXJjaC94ODYvaW5jbHVkZS9hc20veGVuL3BjaS5oDQo+ICsrKyBiL2FyY2gv
eDg2L2luY2x1ZGUvYXNtL3hlbi9wY2kuaA0KPiBAQCAtMjIsMjUgKzIyLDYgQEAgc3RhdGljIGlu
bGluZSBpbnQgX19pbml0IHBjaV94ZW5faW5pdGlhbF9kb21haW4odm9pZCkNCj4gICAJcmV0dXJu
IC0xOw0KPiAgIH0NCj4gICAjZW5kaWYNCj4gLSNpZmRlZiBDT05GSUdfWEVOX0RPTTANCj4gLWlu
dCB4ZW5fZmluZF9kZXZpY2VfZG9tYWluX293bmVyKHN0cnVjdCBwY2lfZGV2ICpkZXYpOw0KPiAt
aW50IHhlbl9yZWdpc3Rlcl9kZXZpY2VfZG9tYWluX293bmVyKHN0cnVjdCBwY2lfZGV2ICpkZXYs
IHVpbnQxNl90IGRvbWFpbik7DQo+IC1pbnQgeGVuX3VucmVnaXN0ZXJfZGV2aWNlX2RvbWFpbl9v
d25lcihzdHJ1Y3QgcGNpX2RldiAqZGV2KTsNCj4gLSNlbHNlDQo+IC1zdGF0aWMgaW5saW5lIGlu
dCB4ZW5fZmluZF9kZXZpY2VfZG9tYWluX293bmVyKHN0cnVjdCBwY2lfZGV2ICpkZXYpDQo+IC17
DQo+IC0JcmV0dXJuIC0xOw0KPiAtfQ0KPiAtc3RhdGljIGlubGluZSBpbnQgeGVuX3JlZ2lzdGVy
X2RldmljZV9kb21haW5fb3duZXIoc3RydWN0IHBjaV9kZXYgKmRldiwNCj4gLQkJCQkJCSAgIHVp
bnQxNl90IGRvbWFpbikNCj4gLXsNCj4gLQlyZXR1cm4gLTE7DQo+IC19DQo+IC1zdGF0aWMgaW5s
aW5lIGludCB4ZW5fdW5yZWdpc3Rlcl9kZXZpY2VfZG9tYWluX293bmVyKHN0cnVjdCBwY2lfZGV2
ICpkZXYpDQo+IC17DQo+IC0JcmV0dXJuIC0xOw0KPiAtfQ0KPiAtI2VuZGlmDQo+ICAgDQo+ICAg
I2lmIGRlZmluZWQoQ09ORklHX1BDSV9NU0kpDQo+ICAgI2lmIGRlZmluZWQoQ09ORklHX1BDSV9Y
RU4pDQo+IGRpZmYgLS1naXQgYS9hcmNoL3g4Ni9wY2kveGVuLmMgYi9hcmNoL3g4Ni9wY2kveGVu
LmMNCj4gaW5kZXggNWRlYmU0YWM2ZjgxLi4xMmRhMDA1NTg2MzEgMTAwNjQ0DQo+IC0tLSBhL2Fy
Y2gveDg2L3BjaS94ZW4uYw0KPiArKysgYi9hcmNoL3g4Ni9wY2kveGVuLmMNCj4gQEAgLTIzLDYg
KzIzLDcgQEANCj4gICANCj4gICAjaW5jbHVkZSA8eGVuL2ZlYXR1cmVzLmg+DQo+ICAgI2luY2x1
ZGUgPHhlbi9ldmVudHMuaD4NCj4gKyNpbmNsdWRlIDx4ZW4vcGNpLmg+DQo+ICAgI2luY2x1ZGUg
PGFzbS94ZW4vcGNpLmg+DQo+ICAgI2luY2x1ZGUgPGFzbS94ZW4vY3B1aWQuaD4NCj4gICAjaW5j
bHVkZSA8YXNtL2FwaWMuaD4NCj4gQEAgLTU4NSw3OCArNTg2LDMgQEAgaW50IF9faW5pdCBwY2lf
eGVuX2luaXRpYWxfZG9tYWluKHZvaWQpDQo+ICAgfQ0KPiAgICNlbmRpZg0KPiAgIA0KPiAtI2lm
ZGVmIENPTkZJR19YRU5fRE9NMA0KPiAtDQo+IC1zdHJ1Y3QgeGVuX2RldmljZV9kb21haW5fb3du
ZXIgew0KPiAtCWRvbWlkX3QgZG9tYWluOw0KPiAtCXN0cnVjdCBwY2lfZGV2ICpkZXY7DQo+IC0J
c3RydWN0IGxpc3RfaGVhZCBsaXN0Ow0KPiAtfTsNCj4gLQ0KPiAtc3RhdGljIERFRklORV9TUElO
TE9DSyhkZXZfZG9tYWluX2xpc3Rfc3BpbmxvY2spOw0KPiAtc3RhdGljIHN0cnVjdCBsaXN0X2hl
YWQgZGV2X2RvbWFpbl9saXN0ID0gTElTVF9IRUFEX0lOSVQoZGV2X2RvbWFpbl9saXN0KTsNCj4g
LQ0KPiAtc3RhdGljIHN0cnVjdCB4ZW5fZGV2aWNlX2RvbWFpbl9vd25lciAqZmluZF9kZXZpY2Uo
c3RydWN0IHBjaV9kZXYgKmRldikNCj4gLXsNCj4gLQlzdHJ1Y3QgeGVuX2RldmljZV9kb21haW5f
b3duZXIgKm93bmVyOw0KPiAtDQo+IC0JbGlzdF9mb3JfZWFjaF9lbnRyeShvd25lciwgJmRldl9k
b21haW5fbGlzdCwgbGlzdCkgew0KPiAtCQlpZiAob3duZXItPmRldiA9PSBkZXYpDQo+IC0JCQly
ZXR1cm4gb3duZXI7DQo+IC0JfQ0KPiAtCXJldHVybiBOVUxMOw0KPiAtfQ0KPiAtDQo+IC1pbnQg
eGVuX2ZpbmRfZGV2aWNlX2RvbWFpbl9vd25lcihzdHJ1Y3QgcGNpX2RldiAqZGV2KQ0KPiAtew0K
PiAtCXN0cnVjdCB4ZW5fZGV2aWNlX2RvbWFpbl9vd25lciAqb3duZXI7DQo+IC0JaW50IGRvbWFp
biA9IC1FTk9ERVY7DQo+IC0NCj4gLQlzcGluX2xvY2soJmRldl9kb21haW5fbGlzdF9zcGlubG9j
ayk7DQo+IC0Jb3duZXIgPSBmaW5kX2RldmljZShkZXYpOw0KPiAtCWlmIChvd25lcikNCj4gLQkJ
ZG9tYWluID0gb3duZXItPmRvbWFpbjsNCj4gLQlzcGluX3VubG9jaygmZGV2X2RvbWFpbl9saXN0
X3NwaW5sb2NrKTsNCj4gLQlyZXR1cm4gZG9tYWluOw0KPiAtfQ0KPiAtRVhQT1JUX1NZTUJPTF9H
UEwoeGVuX2ZpbmRfZGV2aWNlX2RvbWFpbl9vd25lcik7DQo+IC0NCj4gLWludCB4ZW5fcmVnaXN0
ZXJfZGV2aWNlX2RvbWFpbl9vd25lcihzdHJ1Y3QgcGNpX2RldiAqZGV2LCB1aW50MTZfdCBkb21h
aW4pDQo+IC17DQo+IC0Jc3RydWN0IHhlbl9kZXZpY2VfZG9tYWluX293bmVyICpvd25lcjsNCj4g
LQ0KPiAtCW93bmVyID0ga3phbGxvYyhzaXplb2Yoc3RydWN0IHhlbl9kZXZpY2VfZG9tYWluX293
bmVyKSwgR0ZQX0tFUk5FTCk7DQo+IC0JaWYgKCFvd25lcikNCj4gLQkJcmV0dXJuIC1FTk9ERVY7
DQo+IC0NCj4gLQlzcGluX2xvY2soJmRldl9kb21haW5fbGlzdF9zcGlubG9jayk7DQo+IC0JaWYg
KGZpbmRfZGV2aWNlKGRldikpIHsNCj4gLQkJc3Bpbl91bmxvY2soJmRldl9kb21haW5fbGlzdF9z
cGlubG9jayk7DQo+IC0JCWtmcmVlKG93bmVyKTsNCj4gLQkJcmV0dXJuIC1FRVhJU1Q7DQo+IC0J
fQ0KPiAtCW93bmVyLT5kb21haW4gPSBkb21haW47DQo+IC0Jb3duZXItPmRldiA9IGRldjsNCj4g
LQlsaXN0X2FkZF90YWlsKCZvd25lci0+bGlzdCwgJmRldl9kb21haW5fbGlzdCk7DQo+IC0Jc3Bp
bl91bmxvY2soJmRldl9kb21haW5fbGlzdF9zcGlubG9jayk7DQo+IC0JcmV0dXJuIDA7DQo+IC19
DQo+IC1FWFBPUlRfU1lNQk9MX0dQTCh4ZW5fcmVnaXN0ZXJfZGV2aWNlX2RvbWFpbl9vd25lcik7
DQo+IC0NCj4gLWludCB4ZW5fdW5yZWdpc3Rlcl9kZXZpY2VfZG9tYWluX293bmVyKHN0cnVjdCBw
Y2lfZGV2ICpkZXYpDQo+IC17DQo+IC0Jc3RydWN0IHhlbl9kZXZpY2VfZG9tYWluX293bmVyICpv
d25lcjsNCj4gLQ0KPiAtCXNwaW5fbG9jaygmZGV2X2RvbWFpbl9saXN0X3NwaW5sb2NrKTsNCj4g
LQlvd25lciA9IGZpbmRfZGV2aWNlKGRldik7DQo+IC0JaWYgKCFvd25lcikgew0KPiAtCQlzcGlu
X3VubG9jaygmZGV2X2RvbWFpbl9saXN0X3NwaW5sb2NrKTsNCj4gLQkJcmV0dXJuIC1FTk9ERVY7
DQo+IC0JfQ0KPiAtCWxpc3RfZGVsKCZvd25lci0+bGlzdCk7DQo+IC0Jc3Bpbl91bmxvY2soJmRl
dl9kb21haW5fbGlzdF9zcGlubG9jayk7DQo+IC0Ja2ZyZWUob3duZXIpOw0KPiAtCXJldHVybiAw
Ow0KPiAtfQ0KPiAtRVhQT1JUX1NZTUJPTF9HUEwoeGVuX3VucmVnaXN0ZXJfZGV2aWNlX2RvbWFp
bl9vd25lcik7DQo+IC0jZW5kaWYgLyogQ09ORklHX1hFTl9ET00wICovDQo+IGRpZmYgLS1naXQg
YS9kcml2ZXJzL3hlbi9LY29uZmlnIGIvZHJpdmVycy94ZW4vS2NvbmZpZw0KPiBpbmRleCAxYjJj
M2FjYTY4ODcuLmExYjExYzYyZGE5ZSAxMDA2NDQNCj4gLS0tIGEvZHJpdmVycy94ZW4vS2NvbmZp
Zw0KPiArKysgYi9kcml2ZXJzL3hlbi9LY29uZmlnDQo+IEBAIC0xODEsMTAgKzE4MSwzNCBAQCBj
b25maWcgU1dJT1RMQl9YRU4NCj4gICAJc2VsZWN0IERNQV9PUFMNCj4gICAJc2VsZWN0IFNXSU9U
TEINCj4gICANCj4gK2NvbmZpZyBYRU5fUENJX1NUVUINCj4gKwlib29sDQo+ICsNCj4gK2NvbmZp
ZyBYRU5fUENJREVWX1NUVUINCj4gKwl0cmlzdGF0ZSAiWGVuIFBDSS1kZXZpY2Ugc3R1YiBkcml2
ZXIiDQo+ICsJZGVwZW5kcyBvbiBQQ0kgJiYgIVg4NiAmJiBYRU4NCj4gKwlkZXBlbmRzIG9uIFhF
Tl9CQUNLRU5EDQo+ICsJc2VsZWN0IFhFTl9QQ0lfU1RVQg0KPiArCWRlZmF1bHQgbQ0KPiArCWhl
bHANCj4gKwkgIFRoZSBQQ0kgZGV2aWNlIHN0dWIgZHJpdmVyIHByb3ZpZGVzIGxpbWl0ZWQgdmVy
c2lvbiBvZiB0aGUgUENJDQo+ICsJICBkZXZpY2UgYmFja2VuZCBkcml2ZXIgd2l0aG91dCBwYXJh
LXZpcnR1YWxpemVkIHN1cHBvcnQgZm9yIGd1ZXN0cy4NCj4gKwkgIElmIHlvdSBzZWxlY3QgdGhp
cyB0byBiZSBhIG1vZHVsZSwgeW91IHdpbGwgbmVlZCB0byBtYWtlIHN1cmUgbm8NCj4gKwkgIG90
aGVyIGRyaXZlciBoYXMgYm91bmQgdG8gdGhlIGRldmljZShzKSB5b3Ugd2FudCB0byBtYWtlIHZp
c2libGUgdG8NCj4gKwkgIG90aGVyIGd1ZXN0cy4NCj4gKw0KPiArCSAgVGhlICJoaWRlIiBwYXJh
bWV0ZXIgKG9ubHkgYXBwbGljYWJsZSBpZiBiYWNrZW5kIGRyaXZlciBpcyBjb21waWxlZA0KPiAr
CSAgaW50byB0aGUga2VybmVsKSBhbGxvd3MgeW91IHRvIGJpbmQgdGhlIFBDSSBkZXZpY2VzIHRv
IHRoaXMgbW9kdWxlDQo+ICsJICBmcm9tIHRoZSBkZWZhdWx0IGRldmljZSBkcml2ZXJzLiBUaGUg
YXJndW1lbnQgaXMgdGhlIGxpc3Qgb2YgUENJIEJERnM6DQo+ICsJICB4ZW4tcGNpYmFjay5oaWRl
PSgwMzowMC4wKSgwNDowMC4wKQ0KPiArDQo+ICsJICBJZiBpbiBkb3VidCwgc2F5IG0uDQo+ICsN
Cj4gICBjb25maWcgWEVOX1BDSURFVl9CQUNLRU5EDQo+ICAgCXRyaXN0YXRlICJYZW4gUENJLWRl
dmljZSBiYWNrZW5kIGRyaXZlciINCj4gICAJZGVwZW5kcyBvbiBQQ0kgJiYgWDg2ICYmIFhFTg0K
PiAgIAlkZXBlbmRzIG9uIFhFTl9CQUNLRU5EDQo+ICsJc2VsZWN0IFhFTl9QQ0lfU1RVQg0KPiAg
IAlkZWZhdWx0IG0NCj4gICAJaGVscA0KPiAgIAkgIFRoZSBQQ0kgZGV2aWNlIGJhY2tlbmQgZHJp
dmVyIGFsbG93cyB0aGUga2VybmVsIHRvIGV4cG9ydCBhcmJpdHJhcnkNCj4gZGlmZiAtLWdpdCBh
L2RyaXZlcnMveGVuL01ha2VmaWxlIGIvZHJpdmVycy94ZW4vTWFrZWZpbGUNCj4gaW5kZXggMzQz
NDU5MzQ1NWIyLi41YWFlNjZlNjM4YTcgMTAwNjQ0DQo+IC0tLSBhL2RyaXZlcnMveGVuL01ha2Vm
aWxlDQo+ICsrKyBiL2RyaXZlcnMveGVuL01ha2VmaWxlDQo+IEBAIC0yNCw3ICsyNCw3IEBAIG9i
ai0kKENPTkZJR19YRU5fU1lTX0hZUEVSVklTT1IpCSs9IHN5cy1oeXBlcnZpc29yLm8NCj4gICBv
YmotJChDT05GSUdfWEVOX1BWSFZNX0dVRVNUKQkJKz0gcGxhdGZvcm0tcGNpLm8NCj4gICBvYmot
JChDT05GSUdfU1dJT1RMQl9YRU4pCQkrPSBzd2lvdGxiLXhlbi5vDQo+ICAgb2JqLSQoQ09ORklH
X1hFTl9NQ0VfTE9HKQkJKz0gbWNlbG9nLm8NCj4gLW9iai0kKENPTkZJR19YRU5fUENJREVWX0JB
Q0tFTkQpCSs9IHhlbi1wY2liYWNrLw0KPiArb2JqLSQoQ09ORklHX1hFTl9QQ0lfU1RVQikJICAg
ICAgICArPSB4ZW4tcGNpYmFjay8NCj4gICBvYmotJChDT05GSUdfWEVOX1BSSVZDTUQpCQkrPSB4
ZW4tcHJpdmNtZC5vDQo+ICAgb2JqLSQoQ09ORklHX1hFTl9BQ1BJX1BST0NFU1NPUikJKz0geGVu
LWFjcGktcHJvY2Vzc29yLm8NCj4gICBvYmotJChDT05GSUdfWEVOX0VGSSkJCQkrPSBlZmkubw0K
PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy94ZW4vcGNpLmMgYi9kcml2ZXJzL3hlbi9wY2kuYw0KPiBp
bmRleCAyMjRkZjAzY2U0MmUuLmZjOGMxMjQ5ZDQ5ZiAxMDA2NDQNCj4gLS0tIGEvZHJpdmVycy94
ZW4vcGNpLmMNCj4gKysrIGIvZHJpdmVycy94ZW4vcGNpLmMNCj4gQEAgLTI1NCwzICsyNTQsNzgg
QEAgc3RhdGljIGludCB4ZW5fbWNmZ19sYXRlKHZvaWQpDQo+ICAgCXJldHVybiAwOw0KPiAgIH0N
Cj4gICAjZW5kaWYNCj4gKw0KPiArI2lmZGVmIENPTkZJR19YRU5fRE9NMA0KPiArc3RydWN0IHhl
bl9kZXZpY2VfZG9tYWluX293bmVyIHsNCj4gKwlkb21pZF90IGRvbWFpbjsNCj4gKwlzdHJ1Y3Qg
cGNpX2RldiAqZGV2Ow0KPiArCXN0cnVjdCBsaXN0X2hlYWQgbGlzdDsNCj4gK307DQo+ICsNCj4g
K3N0YXRpYyBERUZJTkVfU1BJTkxPQ0soZGV2X2RvbWFpbl9saXN0X3NwaW5sb2NrKTsNCj4gK3N0
YXRpYyBzdHJ1Y3QgbGlzdF9oZWFkIGRldl9kb21haW5fbGlzdCA9IExJU1RfSEVBRF9JTklUKGRl
dl9kb21haW5fbGlzdCk7DQo+ICsNCj4gK3N0YXRpYyBzdHJ1Y3QgeGVuX2RldmljZV9kb21haW5f
b3duZXIgKmZpbmRfZGV2aWNlKHN0cnVjdCBwY2lfZGV2ICpkZXYpDQo+ICt7DQo+ICsJc3RydWN0
IHhlbl9kZXZpY2VfZG9tYWluX293bmVyICpvd25lcjsNCj4gKw0KPiArCWxpc3RfZm9yX2VhY2hf
ZW50cnkob3duZXIsICZkZXZfZG9tYWluX2xpc3QsIGxpc3QpIHsNCj4gKwkJaWYgKG93bmVyLT5k
ZXYgPT0gZGV2KQ0KPiArCQkJcmV0dXJuIG93bmVyOw0KPiArCX0NCj4gKwlyZXR1cm4gTlVMTDsN
Cj4gK30NCj4gKw0KPiAraW50IHhlbl9maW5kX2RldmljZV9kb21haW5fb3duZXIoc3RydWN0IHBj
aV9kZXYgKmRldikNCj4gK3sNCj4gKwlzdHJ1Y3QgeGVuX2RldmljZV9kb21haW5fb3duZXIgKm93
bmVyOw0KPiArCWludCBkb21haW4gPSAtRU5PREVWOw0KPiArDQo+ICsJc3Bpbl9sb2NrKCZkZXZf
ZG9tYWluX2xpc3Rfc3BpbmxvY2spOw0KPiArCW93bmVyID0gZmluZF9kZXZpY2UoZGV2KTsNCj4g
KwlpZiAob3duZXIpDQo+ICsJCWRvbWFpbiA9IG93bmVyLT5kb21haW47DQo+ICsJc3Bpbl91bmxv
Y2soJmRldl9kb21haW5fbGlzdF9zcGlubG9jayk7DQo+ICsJcmV0dXJuIGRvbWFpbjsNCj4gK30N
Cj4gK0VYUE9SVF9TWU1CT0xfR1BMKHhlbl9maW5kX2RldmljZV9kb21haW5fb3duZXIpOw0KPiAr
DQo+ICtpbnQgeGVuX3JlZ2lzdGVyX2RldmljZV9kb21haW5fb3duZXIoc3RydWN0IHBjaV9kZXYg
KmRldiwgdWludDE2X3QgZG9tYWluKQ0KPiArew0KPiArCXN0cnVjdCB4ZW5fZGV2aWNlX2RvbWFp
bl9vd25lciAqb3duZXI7DQo+ICsNCj4gKwlvd25lciA9IGt6YWxsb2Moc2l6ZW9mKHN0cnVjdCB4
ZW5fZGV2aWNlX2RvbWFpbl9vd25lciksIEdGUF9LRVJORUwpOw0KPiArCWlmICghb3duZXIpDQo+
ICsJCXJldHVybiAtRU5PREVWOw0KPiArDQo+ICsJc3Bpbl9sb2NrKCZkZXZfZG9tYWluX2xpc3Rf
c3BpbmxvY2spOw0KPiArCWlmIChmaW5kX2RldmljZShkZXYpKSB7DQo+ICsJCXNwaW5fdW5sb2Nr
KCZkZXZfZG9tYWluX2xpc3Rfc3BpbmxvY2spOw0KPiArCQlrZnJlZShvd25lcik7DQo+ICsJCXJl
dHVybiAtRUVYSVNUOw0KPiArCX0NCj4gKwlvd25lci0+ZG9tYWluID0gZG9tYWluOw0KPiArCW93
bmVyLT5kZXYgPSBkZXY7DQo+ICsJbGlzdF9hZGRfdGFpbCgmb3duZXItPmxpc3QsICZkZXZfZG9t
YWluX2xpc3QpOw0KPiArCXNwaW5fdW5sb2NrKCZkZXZfZG9tYWluX2xpc3Rfc3BpbmxvY2spOw0K
PiArCXJldHVybiAwOw0KPiArfQ0KPiArRVhQT1JUX1NZTUJPTF9HUEwoeGVuX3JlZ2lzdGVyX2Rl
dmljZV9kb21haW5fb3duZXIpOw0KPiArDQo+ICtpbnQgeGVuX3VucmVnaXN0ZXJfZGV2aWNlX2Rv
bWFpbl9vd25lcihzdHJ1Y3QgcGNpX2RldiAqZGV2KQ0KPiArew0KPiArCXN0cnVjdCB4ZW5fZGV2
aWNlX2RvbWFpbl9vd25lciAqb3duZXI7DQo+ICsNCj4gKwlzcGluX2xvY2soJmRldl9kb21haW5f
bGlzdF9zcGlubG9jayk7DQo+ICsJb3duZXIgPSBmaW5kX2RldmljZShkZXYpOw0KPiArCWlmICgh
b3duZXIpIHsNCj4gKwkJc3Bpbl91bmxvY2soJmRldl9kb21haW5fbGlzdF9zcGlubG9jayk7DQo+
ICsJCXJldHVybiAtRU5PREVWOw0KPiArCX0NCj4gKwlsaXN0X2RlbCgmb3duZXItPmxpc3QpOw0K
PiArCXNwaW5fdW5sb2NrKCZkZXZfZG9tYWluX2xpc3Rfc3BpbmxvY2spOw0KPiArCWtmcmVlKG93
bmVyKTsNCj4gKwlyZXR1cm4gMDsNCj4gK30NCj4gK0VYUE9SVF9TWU1CT0xfR1BMKHhlbl91bnJl
Z2lzdGVyX2RldmljZV9kb21haW5fb3duZXIpOw0KPiArI2VuZGlmDQo+IGRpZmYgLS1naXQgYS9k
cml2ZXJzL3hlbi94ZW4tcGNpYmFjay9NYWtlZmlsZSBiL2RyaXZlcnMveGVuL3hlbi1wY2liYWNr
L01ha2VmaWxlDQo+IGluZGV4IGU4ZDk4MWQ0MzIzNS4uZDYzZGYwOWRlODFjIDEwMDY0NA0KPiAt
LS0gYS9kcml2ZXJzL3hlbi94ZW4tcGNpYmFjay9NYWtlZmlsZQ0KPiArKysgYi9kcml2ZXJzL3hl
bi94ZW4tcGNpYmFjay9NYWtlZmlsZQ0KPiBAQCAtMSw1ICsxLDEyIEBADQo+ICAgIyBTUERYLUxp
Y2Vuc2UtSWRlbnRpZmllcjogR1BMLTIuMA0KPiArDQo+ICsjIE4uQi4gVGhlIGJlbG93IGNhbm5v
dCBiZSBleHByZXNzZWQgd2l0aCBhIHNpbmdsZSBsaW5lIHVzaW5nDQo+ICsjIENPTkZJR19YRU5f
UENJX1NUVUIgYXMgaXQgYWx3YXlzIHJlbWFpbnMgaW4gInkiIHN0YXRlLA0KPiArIyB0aHVzIHBy
ZXZlbnRpbmcgdGhlIGRyaXZlciB0byBiZSBidWlsdCBhcyBhIG1vZHVsZS4NCj4gKyMgUGxlYXNl
IG5vdGUsIHRoYXQgQ09ORklHX1hFTl9QQ0lERVZfQkFDS0VORCBhbmQNCj4gKyMgQ09ORklHX1hF
Tl9QQ0lERVZfU1RVQiBhcmUgbXV0dWFsbHkgZXhjbHVzaXZlLg0KPiAgIG9iai0kKENPTkZJR19Y
RU5fUENJREVWX0JBQ0tFTkQpICs9IHhlbi1wY2liYWNrLm8NCj4gK29iai0kKENPTkZJR19YRU5f
UENJREVWX1NUVUIpICs9IHhlbi1wY2liYWNrLm8NCj4gICANCj4gICB4ZW4tcGNpYmFjay15IDo9
IHBjaV9zdHViLm8gcGNpYmFja19vcHMubyB4ZW5idXMubw0KPiAgIHhlbi1wY2liYWNrLXkgKz0g
Y29uZl9zcGFjZS5vIGNvbmZfc3BhY2VfaGVhZGVyLm8gXA0KPiBkaWZmIC0tZ2l0IGEvZHJpdmVy
cy94ZW4veGVuLXBjaWJhY2svY29uZl9zcGFjZV9oZWFkZXIuYyBiL2RyaXZlcnMveGVuL3hlbi1w
Y2liYWNrL2NvbmZfc3BhY2VfaGVhZGVyLmMNCj4gaW5kZXggYWM0NWNkYzM4ZTg1Li45ODE0MzUx
MDNhZjEgMTAwNjQ0DQo+IC0tLSBhL2RyaXZlcnMveGVuL3hlbi1wY2liYWNrL2NvbmZfc3BhY2Vf
aGVhZGVyLmMNCj4gKysrIGIvZHJpdmVycy94ZW4veGVuLXBjaWJhY2svY29uZl9zcGFjZV9oZWFk
ZXIuYw0KPiBAQCAtMjM2LDggKzIzNiwxMiBAQCBzdGF0aWMgdm9pZCAqYmFyX2luaXQoc3RydWN0
IHBjaV9kZXYgKmRldiwgaW50IG9mZnNldCkNCj4gICAJZWxzZSB7DQo+ICAgCQlwb3MgPSAob2Zm
c2V0IC0gUENJX0JBU0VfQUREUkVTU18wKSAvIDQ7DQo+ICAgCQlpZiAocG9zICYmIChyZXNbcG9z
IC0gMV0uZmxhZ3MgJiBJT1JFU09VUkNFX01FTV82NCkpIHsNCj4gLQkJCWJhci0+dmFsID0gcmVz
W3BvcyAtIDFdLnN0YXJ0ID4+IDMyOw0KPiAtCQkJYmFyLT5sZW5fdmFsID0gLXJlc291cmNlX3Np
emUoJnJlc1twb3MgLSAxXSkgPj4gMzI7DQo+ICsJCQkvKg0KPiArCQkJICogVXNlICI+PiAxNiA+
PiAxNiIgaW5zdGVhZCBvZiBkaXJlY3QgIj4+IDMyIiBzaGlmdA0KPiArCQkJICogdG8gYXZvaWQg
d2FybmluZ3Mgb24gMzItYml0IGFyY2hpdGVjdHVyZXMuDQo+ICsJCQkgKi8NCj4gKwkJCWJhci0+
dmFsID0gcmVzW3BvcyAtIDFdLnN0YXJ0ID4+IDE2ID4+IDE2Ow0KPiArCQkJYmFyLT5sZW5fdmFs
ID0gLXJlc291cmNlX3NpemUoJnJlc1twb3MgLSAxXSkgPj4gMTYgPj4gMTY7DQo+ICAgCQkJcmV0
dXJuIGJhcjsNCj4gICAJCX0NCj4gICAJfQ0KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy94ZW4veGVu
LXBjaWJhY2svcGNpX3N0dWIuYyBiL2RyaXZlcnMveGVuL3hlbi1wY2liYWNrL3BjaV9zdHViLmMN
Cj4gaW5kZXggZjhlNGZhYTk2YWQ2Li5iYmE1Mjc2MjA1MDcgMTAwNjQ0DQo+IC0tLSBhL2RyaXZl
cnMveGVuL3hlbi1wY2liYWNrL3BjaV9zdHViLmMNCj4gKysrIGIvZHJpdmVycy94ZW4veGVuLXBj
aWJhY2svcGNpX3N0dWIuYw0KPiBAQCAtMTksNyArMTksOCBAQA0KPiAgICNpbmNsdWRlIDxsaW51
eC9zY2hlZC5oPg0KPiAgICNpbmNsdWRlIDxsaW51eC9hdG9taWMuaD4NCj4gICAjaW5jbHVkZSA8
eGVuL2V2ZW50cy5oPg0KPiAtI2luY2x1ZGUgPGFzbS94ZW4vcGNpLmg+DQo+ICsjaW5jbHVkZSA8
eGVuL3BjaS5oPg0KPiArI2luY2x1ZGUgPHhlbi94ZW4uaD4NCj4gICAjaW5jbHVkZSA8YXNtL3hl
bi9oeXBlcnZpc29yLmg+DQo+ICAgI2luY2x1ZGUgPHhlbi9pbnRlcmZhY2UvcGh5c2Rldi5oPg0K
PiAgICNpbmNsdWRlICJwY2liYWNrLmgiDQo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3hlbi94ZW4t
cGNpYmFjay9wY2liYWNrLmggYi9kcml2ZXJzL3hlbi94ZW4tcGNpYmFjay9wY2liYWNrLmgNCj4g
aW5kZXggOTVlMjhlZTQ4ZDUyLi45YTY0MTk2ZTgzMWQgMTAwNjQ0DQo+IC0tLSBhL2RyaXZlcnMv
eGVuL3hlbi1wY2liYWNrL3BjaWJhY2suaA0KPiArKysgYi9kcml2ZXJzL3hlbi94ZW4tcGNpYmFj
ay9wY2liYWNrLmgNCj4gQEAgLTcxLDYgKzcxLDExIEBAIHN0cnVjdCBwY2lfZGV2ICpwY2lzdHVi
X2dldF9wY2lfZGV2KHN0cnVjdCB4ZW5fcGNpYmtfZGV2aWNlICpwZGV2LA0KPiAgIAkJCQkgICAg
c3RydWN0IHBjaV9kZXYgKmRldik7DQo+ICAgdm9pZCBwY2lzdHViX3B1dF9wY2lfZGV2KHN0cnVj
dCBwY2lfZGV2ICpkZXYpOw0KPiAgIA0KPiArc3RhdGljIGlubGluZSBib29sIHhlbl9wY2lia19w
dl9zdXBwb3J0KHZvaWQpDQo+ICt7DQo+ICsJcmV0dXJuIElTX0VOQUJMRUQoQ09ORklHX1hFTl9Q
Q0lERVZfQkFDS0VORCk7DQo+ICt9DQo+ICsNCj4gICAvKiBFbnN1cmUgYSBkZXZpY2UgaXMgdHVy
bmVkIG9mZiBvciByZXNldCAqLw0KPiAgIHZvaWQgeGVuX3BjaWJrX3Jlc2V0X2RldmljZShzdHJ1
Y3QgcGNpX2RldiAqcGRldik7DQo+ICAgDQo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3hlbi94ZW4t
cGNpYmFjay94ZW5idXMuYyBiL2RyaXZlcnMveGVuL3hlbi1wY2liYWNrL3hlbmJ1cy5jDQo+IGlu
ZGV4IGMwOWM3ZWJkNjk2OC4uYmRlNjNlZjY3N2I4IDEwMDY0NA0KPiAtLS0gYS9kcml2ZXJzL3hl
bi94ZW4tcGNpYmFjay94ZW5idXMuYw0KPiArKysgYi9kcml2ZXJzL3hlbi94ZW4tcGNpYmFjay94
ZW5idXMuYw0KPiBAQCAtMTQsNyArMTQsNyBAQA0KPiAgICNpbmNsdWRlIDxsaW51eC93b3JrcXVl
dWUuaD4NCj4gICAjaW5jbHVkZSA8eGVuL3hlbmJ1cy5oPg0KPiAgICNpbmNsdWRlIDx4ZW4vZXZl
bnRzLmg+DQo+IC0jaW5jbHVkZSA8YXNtL3hlbi9wY2kuaD4NCj4gKyNpbmNsdWRlIDx4ZW4vcGNp
Lmg+DQo+ICAgI2luY2x1ZGUgInBjaWJhY2suaCINCj4gICANCj4gICAjZGVmaW5lIElOVkFMSURf
RVZUQ0hOX0lSUSAgKC0xKQ0KPiBAQCAtNzQzLDYgKzc0Myw5IEBAIGNvbnN0IHN0cnVjdCB4ZW5f
cGNpYmtfYmFja2VuZCAqX19yZWFkX21vc3RseSB4ZW5fcGNpYmtfYmFja2VuZDsNCj4gICANCj4g
ICBpbnQgX19pbml0IHhlbl9wY2lia194ZW5idXNfcmVnaXN0ZXIodm9pZCkNCj4gICB7DQo+ICsJ
aWYgKCF4ZW5fcGNpYmtfcHZfc3VwcG9ydCgpKQ0KPiArCQlyZXR1cm4gMDsNCj4gKw0KPiAgIAl4
ZW5fcGNpYmtfYmFja2VuZCA9ICZ4ZW5fcGNpYmtfdnBjaV9iYWNrZW5kOw0KPiAgIAlpZiAocGFz
c3Rocm91Z2gpDQo+ICAgCQl4ZW5fcGNpYmtfYmFja2VuZCA9ICZ4ZW5fcGNpYmtfcGFzc3Rocm91
Z2hfYmFja2VuZDsNCj4gQEAgLTc1Miw1ICs3NTUsNiBAQCBpbnQgX19pbml0IHhlbl9wY2lia194
ZW5idXNfcmVnaXN0ZXIodm9pZCkNCj4gICANCj4gICB2b2lkIF9fZXhpdCB4ZW5fcGNpYmtfeGVu
YnVzX3VucmVnaXN0ZXIodm9pZCkNCj4gICB7DQo+IC0JeGVuYnVzX3VucmVnaXN0ZXJfZHJpdmVy
KCZ4ZW5fcGNpYmtfZHJpdmVyKTsNCj4gKwlpZiAoeGVuX3BjaWJrX3B2X3N1cHBvcnQoKSkNCj4g
KwkJeGVuYnVzX3VucmVnaXN0ZXJfZHJpdmVyKCZ4ZW5fcGNpYmtfZHJpdmVyKTsNCj4gICB9DQo+
IGRpZmYgLS1naXQgYS9pbmNsdWRlL3hlbi9wY2kuaCBiL2luY2x1ZGUveGVuL3BjaS5oDQo+IG5l
dyBmaWxlIG1vZGUgMTAwNjQ0DQo+IGluZGV4IDAwMDAwMDAwMDAwMC4uYjgzMzdjZjg1ZmQxDQo+
IC0tLSAvZGV2L251bGwNCj4gKysrIGIvaW5jbHVkZS94ZW4vcGNpLmgNCj4gQEAgLTAsMCArMSwy
OCBAQA0KPiArLyogU1BEWC1MaWNlbnNlLUlkZW50aWZpZXI6IEdQTC0yLjAgKi8NCj4gKw0KPiAr
I2lmbmRlZiBfX1hFTl9QQ0lfSF9fDQo+ICsjZGVmaW5lIF9fWEVOX1BDSV9IX18NCj4gKw0KPiAr
I2lmIGRlZmluZWQoQ09ORklHX1hFTl9ET00wKQ0KPiAraW50IHhlbl9maW5kX2RldmljZV9kb21h
aW5fb3duZXIoc3RydWN0IHBjaV9kZXYgKmRldik7DQo+ICtpbnQgeGVuX3JlZ2lzdGVyX2Rldmlj
ZV9kb21haW5fb3duZXIoc3RydWN0IHBjaV9kZXYgKmRldiwgdWludDE2X3QgZG9tYWluKTsNCj4g
K2ludCB4ZW5fdW5yZWdpc3Rlcl9kZXZpY2VfZG9tYWluX293bmVyKHN0cnVjdCBwY2lfZGV2ICpk
ZXYpOw0KPiArI2Vsc2UNCj4gK3N0YXRpYyBpbmxpbmUgaW50IHhlbl9maW5kX2RldmljZV9kb21h
aW5fb3duZXIoc3RydWN0IHBjaV9kZXYgKmRldikNCj4gK3sNCj4gKwlyZXR1cm4gLTE7DQo+ICt9
DQo+ICsNCj4gK3N0YXRpYyBpbmxpbmUgaW50IHhlbl9yZWdpc3Rlcl9kZXZpY2VfZG9tYWluX293
bmVyKHN0cnVjdCBwY2lfZGV2ICpkZXYsDQo+ICsJCQkJCQkgICB1aW50MTZfdCBkb21haW4pDQo+
ICt7DQo+ICsJcmV0dXJuIC0xOw0KPiArfQ0KPiArDQo+ICtzdGF0aWMgaW5saW5lIGludCB4ZW5f
dW5yZWdpc3Rlcl9kZXZpY2VfZG9tYWluX293bmVyKHN0cnVjdCBwY2lfZGV2ICpkZXYpDQo+ICt7
DQo+ICsJcmV0dXJuIC0xOw0KPiArfQ0KPiArI2VuZGlmDQo+ICsNCj4gKyNlbmRpZg0K


From xen-devel-bounces@lists.xenproject.org Thu Oct 28 15:28:28 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Oct 2021 15:28:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.218145.378460 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg7Jx-0001hy-Vq; Thu, 28 Oct 2021 15:28:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 218145.378460; Thu, 28 Oct 2021 15:28:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg7Jx-0001hr-Sg; Thu, 28 Oct 2021 15:28:01 +0000
Received: by outflank-mailman (input) for mailman id 218145;
 Thu, 28 Oct 2021 15:28:01 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ikAZ=PQ=epam.com=prvs=19352d112c=oleksandr_andrushchenko@srs-us1.protection.inumbo.net>)
 id 1mg7Jx-0001hj-7K
 for xen-devel@lists.xenproject.org; Thu, 28 Oct 2021 15:28:01 +0000
Received: from mx0a-0039f301.pphosted.com (unknown [148.163.133.242])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 5417fa08-1dd2-410e-91b8-00200485692b;
 Thu, 28 Oct 2021 15:27:58 +0000 (UTC)
Received: from pps.filterd (m0174678.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 19SEdRsi020934; 
 Thu, 28 Oct 2021 15:27:56 GMT
Received: from eur05-am6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2109.outbound.protection.outlook.com [104.47.18.109])
 by mx0a-0039f301.pphosted.com with ESMTP id 3bywtjr98n-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Thu, 28 Oct 2021 15:27:56 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by AM0PR03MB4884.eurprd03.prod.outlook.com (2603:10a6:208:fe::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.13; Thu, 28 Oct
 2021 15:27:48 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::c038:e032:595a:651]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::c038:e032:595a:651%9]) with mapi id 15.20.4649.015; Thu, 28 Oct 2021
 15:27:48 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5417fa08-1dd2-410e-91b8-00200485692b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=RFQ/93y19bRQC86/c4n59fh3FZUYpEaTyMp95F+KDbMXC7TFf1it++eepWrI27Q4aVntqqNZRv13fUfH5IwHhTwzBKfE1YLDfHYOBDECCds1BncuBFQFFQf7cMbUkt1H02cca681Bb8qC02BoiF4szsuGmId9IfHWy7s+EVBSQXy6z1KwJTXmece17mx9nu21Gbcz0kDbhy78JeAsjOO8hwOwCd+eRciFoX5yVf1z/uJ3hb9S63Jsqb/WTYw3HfJQ3VvIJvJl5Euzmck4ogq5dfBAHM8KVtxWqAo1RDSy+zebYhli/IwtVjGV4XLMlBb3nG5SD5LnWuv3DooW+DKPA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=UfsEAqFKfLRs1FaI0IiohxRLNl8Kxyzz5v9NUaq/fdk=;
 b=k+zAyXuOWUtx6m0qKfOwQwJRMZBXXu+PyLxyleD9sF9HgZ1DpY1d5qxzm96YWYDVwP7AFSlciD7ZWPcq1F+Pr2FRD7kqvlCBGI85JdeXRJ68kkN13VWTMGxysmIXAc/9+HgElFmXJ/m/MXgrL0VwPpV8F2LS2Z4VzgWBfc1PEME/AdA6vgE/KDrrnujbGetRLGhLSodyMqzxGiQXA26kar7oN5SqsJCUL2PRleWbwhjRXCJvxFLMulv3PwaGLrah389/E0u0QZLltNnERtL+hI1MCl4hQDMQmss5cGh0S1yyQ9VBROSRNMeyuMwTZKajlLdzqObPT3VMo4kUCYp0Mw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=UfsEAqFKfLRs1FaI0IiohxRLNl8Kxyzz5v9NUaq/fdk=;
 b=RkravY377uAkWzsCBJjYoYjeze1kVdFLEYf4dniZj4bd7BnzqkkhFquPTrOmOekUj568Oj6JP5inn83wjgbPTJejWI33pwbYsEfgkTkB4Vncykf20CSe4KPNVULFPjqCCXnwNduRm/YGbQ2H3Ushxadcc3Jo29hD/3MJkyAq3XlhpPrRd42g8F3vbCCson9en/oVuyG6E+U0Pvma/rcms6bjWImFkhvfJnscdQIEwD2TsCX7JmH2FgbWaBxtiiR2EAUo2opwILsq0PnyIb6cB5Kn8NTMLeDQfGLW2n7VobHyO/4ypl/8ihL3JA/6HoRcdn5kkckRMY+GdfqmG1UV+w==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Julien Grall <julien@xen.org>,
        "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: "sstabellini@kernel.org" <sstabellini@kernel.org>,
        "iwj@xenproject.org"
	<iwj@xenproject.org>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Rahul
 Singh <rahul.singh@arm.com>
Subject: Re: [PATCH] xen/arm: fix SBDF calculation for vPCI MMIO handlers
Thread-Topic: [PATCH] xen/arm: fix SBDF calculation for vPCI MMIO handlers
Thread-Index: 
 AQHXyww6rKHs3LJru0q52eLUia+oNavnHBIAgAE3H4CAABSQgIAADtGAgAADkwCAABB5AA==
Date: Thu, 28 Oct 2021 15:27:48 +0000
Message-ID: <38da2edd-06a2-63d0-51ad-1284272c8da5@epam.com>
References: <20211027082533.1406015-1-andr2000@gmail.com>
 <cb7e9ef7-476e-93c3-d3c9-9a9ebc61003d@xen.org>
 <d63c6e0b-8aa3-9ba3-893c-5e464638a8db@epam.com>
 <65886734-7333-4469-fcc1-6916db708f13@xen.org>
 <b6bb02b6-6358-b5e0-1b80-7819aadabe10@epam.com>
 <6d8f1061-7aec-2c1a-aaf4-c30440c2797a@xen.org>
In-Reply-To: <6d8f1061-7aec-2c1a-aaf4-c30440c2797a@xen.org>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 56899d40-50c7-42cb-dc08-08d99a277fc6
x-ms-traffictypediagnostic: AM0PR03MB4884:
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <AM0PR03MB488416863D71389D66CD7871E7869@AM0PR03MB4884.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 pTlBySfF7ZqxbsyFWhxXswnWnPzdYT+cC/ecp/csfUIMGata7ZdBYmapOuXl0xzgGVbI6SZ/3U6LXvAGr0rvYGgHzgflUVlQXGdWX1wazLo5ntEBwi57cbNs3ONzFSUyqN7B7J8vPyNGtGWOBfF9ykSgf14QLlPmKS42kMFTgQaXvmrhzn37fp9wx9xx0dFJBOHvOkCMvY2XazK7khDydasjx3irZtnX1WcCrh+4aeP0G8GarvIPz6fQzAHKuoMh8q2NWwLdIoUmTMgofA6KJ59EbGabaT6LGg824hm62unetqItq0zd6Xxv2sUhHNxtshnIAOVaDELw5KyAN/teMKVDmBd0OHtRhrv5cfyMw26/rY9Bj0jnrKwwiz30XgmN3lyeu2eueiw5nkXm094HzVwZdeMk7lrfPIal31U4NnXo04mLuSLtM23/jdSvHvV+1z8v+rWyqCSW7VKBSsF3SBkBdAl/EIu9SpdpG18Dl/SMjikP1xuKF/M1dsYM9g9cUFRYtqK+NLGtHmnoPSfWMVt+6XvS4PhVroFumgY6Vd8OW7te1Wzdpw5iyO3OUn0TjumHXjT/mKxDPJElbLpiZdaKn9gsm+KO5J8fPZPLbWKtYbIV8sBJ/s9BgivOji2zlBAjD5XuCT5l7f1TiI1/B1NJ4iZWWPSR3Am3yfGYLjpdkrFIsSbg0rhOuH5Vp/TCmlkawiQpiPWRZBbXZD5TlW52DMduvdfyp7ONVn/W6OBbONbQVv/UWqie8i2ZJ6Dj
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(71200400001)(66946007)(76116006)(316002)(31686004)(38100700002)(66476007)(122000001)(91956017)(2616005)(66556008)(110136005)(54906003)(4326008)(8676002)(64756008)(186003)(6512007)(8936002)(36756003)(2906002)(53546011)(86362001)(26005)(508600001)(6486002)(6506007)(38070700005)(66446008)(5660300002)(83380400001)(31696002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?dnlZblJEd3pxYXljRGRRMEN0dzZzVDNtZ0xIY2thQUUwelp0WHlKTjhGZml6?=
 =?utf-8?B?MitmK1kvYzJCNGkrZVhzUWVjd0phNDRZelAvWTFkdldRNEErY3VGeXRnZlZh?=
 =?utf-8?B?NFR4ODlVOHdUY1hvWmpPZ2s2bEVLbzg0YWpEVGhvV1BKVitFYWVZYWE5YjVz?=
 =?utf-8?B?OXMvbHU1a0RyVTdBK1E0VkpEN1pqTTNQTjA0dnY0bzRTeGlwLy9YQm1VcXVm?=
 =?utf-8?B?SzBYTjRndStXVG9ZbVkwOFMxd2FsS2VtazZNNUVrRW9aRDdmYjlncCsyTDNP?=
 =?utf-8?B?THFTTEo2TkxyQTRUcjdYYU9YbnB1RWRSd0pzVlkwVFBvZnpJeG1MZjc3U2w1?=
 =?utf-8?B?ZjE0dEt2VkU2VDgyNVhvalNEbGNieGVPL3kvZ1VLdlRDUjAvL3lBeUNoQkhV?=
 =?utf-8?B?SFBHTVZMMVV1NDlIL3NuVThnNTFNZnZmcFVKZFRDcy9yY1VicG1zZUxGeEN0?=
 =?utf-8?B?cUFhOUwxbUZBdTR4QXd1aFZXWm1uTlBJWFBDcWkzMEFKR0hySEJVTGdQUFM1?=
 =?utf-8?B?SnEvMjVrYzZTSGYxOVJEWm1KK253L1MzSHdxcko2YnNZUG94Um4rRlkyVTF4?=
 =?utf-8?B?WVBGMU1yZHo5NjVabUxpMUZ0R0pwMlVVcFowOGk0RjIwRmpENWxDTm02QmNm?=
 =?utf-8?B?WFRUdUcyei9mRDh4b2xZT2UrbzR2Y2Z3bVlpaWhPTm4vb0JLZWF5a2NFUXRn?=
 =?utf-8?B?TlBrRVJ4VVNUL3lJSC9rdVpyU0VlQU0rTFI2cHRjbWRKQTZCbklFeW51RkR0?=
 =?utf-8?B?UC9XdVUva0V2Z3BId1pIb1A2YlFmUnFzNzhIbWcyQllOUW9JSlBWNkV3L0Ji?=
 =?utf-8?B?dTVtZC9KL282RXcxTnRvdlVlSlFKK0E5VVljNURTVFFHVG02c0pJSEhXa3RC?=
 =?utf-8?B?UzJuU0EwS2NzbWR1RmswVGJpSWs4a0p2d3kraERRVGZ2NUxRcndNYlR4TkNB?=
 =?utf-8?B?OTdEN3AwYThFTWJScEtobm83UVhBZzdHT1g4ZUpTb01VQzI1eXJoVmZ3b1JM?=
 =?utf-8?B?VDgzMGs5UU40UmZOZzZzbGJQR0E0QTFxVTNsR056NStXalRWV2xpKzVsYysw?=
 =?utf-8?B?TDFoMS9SbzYvVUljVGNTUkxaTDM3MWpxNk5BWHhFRlppUURiUzF5NlFWSlc5?=
 =?utf-8?B?UFJvMi8zUFY4R3dORDFtcXNhM0JNcEZxUGxqRzFnSDhxTVZHdG9EdlNwcVY5?=
 =?utf-8?B?ZGxuckZ5bnRZU3NWN2RHWnA4WnArR1MyMUR1cFMwTUovbHZWcnZrQlpOTmJk?=
 =?utf-8?B?UGRCZTdRMTF1NTVZdisrTmVOeWJEeC9nelIvSkxJV29ja3BVOWdmRDB4S3l6?=
 =?utf-8?B?UmdYQ0s5M2ZFbzFIS2dlWnFGbXFxcUsrMXY1SlcrQjNXWkNLMzhuQ2RibFFW?=
 =?utf-8?B?OUdBMVNEYlJndldxOWU5aUlXN0RWOVBVTFE0WmZzQ1QzcnMzemRyV3haaDhU?=
 =?utf-8?B?VWR6ZHhGdENJSEhDcWlZZ0NLOVcvVFdxRDU2K2hWbGNndXpsNzFOVmc5VmZG?=
 =?utf-8?B?V3dEZldnWHpVTHUrNFFlQ0ZLZWg2SjVkVkl6aVAzWU4wdGZ1ZVpha0ZCVWRO?=
 =?utf-8?B?QWthUGd0TldHanVBZGZxTk9YejUyNjkraWMxRDd2OGMydWNNUzhMNTFaZ2gx?=
 =?utf-8?B?c3Z4WVJ3MXBYTk9acEpBZjFndGo4Rm8rWEhJVU9GamJLR25NL3p6RTFZOWhV?=
 =?utf-8?B?cVFDSzBDeUFxeVdwUEhJUGJSamZpWXVvdzlhaVVuN3NVNGgwVExlc0tuTXJU?=
 =?utf-8?B?QmR4LzJpUUp6dXpSVy9ubGJaYzJkWjdqZStNVnduZlRlbkdFUXEwYUxWRTl6?=
 =?utf-8?B?a3hESXBUQ2oyTitsb2pmWERNb3dXbjNvZGgzQWpaeHMxa1VPQjdkNW00Lzkr?=
 =?utf-8?B?UlJxMThpVTBCMjNYUFJab29SVWV0MUlFQUg1Y1dualJlbFNXTkw2dGtBeUVo?=
 =?utf-8?B?RDUvVXQxNkltalhuMW81U2xLU0ZvT0hLdEhtcGlrUmtNaG1JZldtQ1Zoa01i?=
 =?utf-8?B?Q1BVTnRDd2hiRW9sRmZVTVVQTEdOZnFjUjdnZXh5VnBsaXdYa21CK25JOElI?=
 =?utf-8?B?Z1FZM2tGRzZHa2lZRHdleC9qVysrQUk5RjRuNU9kYlV0REU2enhVb0FCNUFw?=
 =?utf-8?B?cmVZeGY4SnlWMjVmdm9HSWdZcmpZRFdiUlVZLzRSU3FEU0psL3oydGQydWM5?=
 =?utf-8?B?cDV0U3V5RnZLS2xqV3JiTE1kY3RiZlplU3FXQytGc0NicXBVYU9xVEY4cC9O?=
 =?utf-8?B?K1VoQTFSQW4vYWw0NWljZFRwNHBQM1M2WXEwdk5TVlIzNHJwcmVPanQ1aEFR?=
 =?utf-8?B?Z1RKT2szSnJiMlRaQ0QwUUFQaWhwZEdiTHVTSE85bDdVU2dIVXJHQT09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <E9FDC10B02A727489C3F0E7852B25E5A@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 56899d40-50c7-42cb-dc08-08d99a277fc6
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Oct 2021 15:27:48.6362
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: EfaNFLPkwF+t57EJ6OaeeGYSZddOSZIYrahWZ7LQ3akWqVVUmdfTavFtxsaE5lbR+ja19NyIDvs/+bVgNKHjoDM3/lNdSf/Vg7MfJJHFgVla90oaz1dKQj2C0P8NSzw5
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR03MB4884
X-Proofpoint-GUID: PpcWGSxlOikViCuvid4O0b-HMce0f84B
X-Proofpoint-ORIG-GUID: PpcWGSxlOikViCuvid4O0b-HMce0f84B
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475
 definitions=2021-10-28_01,2021-10-26_01,2020-04-07_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501
 lowpriorityscore=0 clxscore=1015 mlxlogscore=999 suspectscore=0 mlxscore=0
 adultscore=0 phishscore=0 impostorscore=0 bulkscore=0 spamscore=0
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2110280086

DQoNCk9uIDI4LjEwLjIxIDE3OjI4LCBKdWxpZW4gR3JhbGwgd3JvdGU6DQo+IEhpLA0KPg0KPiBP
biAyOC8xMC8yMDIxIDE1OjE2LCBPbGVrc2FuZHIgQW5kcnVzaGNoZW5rbyB3cm90ZToNCj4+IE9u
IDI4LjEwLjIxIDE2OjIyLCBKdWxpZW4gR3JhbGwgd3JvdGU6DQo+Pj4gT24gMjgvMTAvMjAyMSAx
MzowOSwgT2xla3NhbmRyIEFuZHJ1c2hjaGVua28gd3JvdGU6DQo+Pj4+IEhpLCBKdWxpZW4hDQo+
Pj4NCj4+PiBIZWxsbywNCj4+Pg0KPj4+PiBPbiAyNy4xMC4yMSAyMDozNSwgSnVsaWVuIEdyYWxs
IHdyb3RlOg0KPj4+Pj4gSGkgT2xla3NhbmRyLA0KPj4+Pj4NCj4+Pj4+IE9uIDI3LzEwLzIwMjEg
MDk6MjUsIE9sZWtzYW5kciBBbmRydXNoY2hlbmtvIHdyb3RlOg0KPj4+Pj4+IEZyb206IE9sZWtz
YW5kciBBbmRydXNoY2hlbmtvIDxvbGVrc2FuZHJfYW5kcnVzaGNoZW5rb0BlcGFtLmNvbT4NCj4+
Pj4+Pg0KPj4+Pj4+IFdoaWxlIGluIHZQQ0kgTU1JTyB0cmFwIGhhbmRsZXJzIGZvciB0aGUgZ3Vl
c3QgUENJIGhvc3QgYnJpZGdlIGl0IGlzIG5vdA0KPj4+Pj4+IGVub3VnaCBmb3IgU0JERiB0cmFu
c2xhdGlvbiB0byBzaW1wbHkgY2FsbCBWUENJX0VDQU1fQkRGKGluZm8tPmdwYSkgYXMNCj4+Pj4+
PiB0aGUgYmFzZSBhZGRyZXNzIG1heSBub3QgYmUgYWxpZ25lZCBpbiB0aGUgd2F5IHRoYXQgdGhl
IHRyYW5zbGF0aW9uDQo+Pj4+Pj4gYWx3YXlzIHdvcmsuIElmIG5vdCBhZGp1c3RlZCB3aXRoIHJl
c3BlY3QgdG8gdGhlIGJhc2UgYWRkcmVzcyBpdCBtYXkgbm90IGJlDQo+Pj4+Pj4gYWJsZSB0byBw
cm9wZXJseSBjb252ZXJ0IFNCREYgYW5kIGNyYXNoZXM6DQo+Pj4+Pj4NCj4+Pj4+PiAoWEVOKSB2
cGNpX21taW9fcmVhZCAwMDAwOjY1OjFhLjAgcmVnIDhiYyBncGEgZTY1ZDA4YmMNCj4+Pj4+DQo+
Pj4+PiBJIGNhbid0IGZpbmQgYSBwcmludGsoKSB0aGF0IG1heSBvdXRwdXQgdGhpcyBtZXNzYWdl
LiBXaGVyZSBkb2VzIHRoaXMgY29tZXMgZnJvbT8NCj4+Pj4gVGhhdCB3YXMgYSBkZWJ1ZyBwcmlu
dC4gSSBzaG91bGRuJ3QgaGF2ZSB1c2VkIHRoYXQgaW4gdGhlIHBhdGNoIGRlc2NyaXB0aW9uLCBi
dXQNCj4+Pj4gcHJvYmFibHkgYWZ0ZXIgIi0tLSIgdG8gYmV0dGVyIGV4cGxhaW4gd2hhdCdzIGhh
cHBlbmluZw0KPj4+Pj4NCj4+Pj4+IEFueXdheSwgSUlVQyB0aGUgZ3Vlc3QgcGh5c2ljYWwgYWRk
cmVzcyBpcyAweGU2NWQwOGJjIHdoaWNoLCBpZiBJIGFtIG5vdCBtaXN0YWtlbiwgZG9lc24ndCBi
ZWxvbmcgdG8gdGhlIHJhbmdlIGFkdmVydGlzZWQgZm9yIEdVRVNUX1ZQQ0lfRUNBTS4NCj4+Pj4g
VGhpcyBpcyBmcm9tIGRvbTAgSSBhbSB3b3JraW5nIG9uIG5vdy4NCj4+Pj4+DQo+Pj4+PiBJTUhP
LCB0aGUgc3RhY2sgdHJhY2Ugc2hvdWxkIGNvbWUgZnJvbSB1c3B0cmVhbSBYZW4gb3IgbmVlZCBz
b21lIGluZm9ybWF0aW9uIHRvIGV4cGxhaW4gaG93IHRoaXMgd2FzIHJlcHJvZHVjZWQuDQo+Pj4+
Pg0KPj4+Pj4+IChYRU4pIERhdGEgQWJvcnQgVHJhcC4gU3luZHJvbWU9MHg2DQo+Pj4+Pj4gKFhF
TikgV2Fsa2luZyBIeXBlcnZpc29yIFZBIDB4NDY3YTI4YmMgb24gQ1BVMCB2aWEgVFRCUiAweDAw
MDAwMDAwNDgxZDUwMDANCj4+Pj4+IEkgY2FuIHVuZGVyc3RuYWQgdGhhdCBpZiB3ZSBkb24ndCBz
dWJzdHJhY3QgR1VFU1RfVlBDSV9FQ0FNLCB3ZSB3b3VsZCAoaW4gdGhlb3J5KSBub3QgZ2V0IHRo
ZSBjb3JyZWN0IEJERi4gQnV0Li4uIEkgZG9uJ3QgdW5kZXJzdGFuZCBob3cgdGhpcyB3b3VsZCBy
ZXN1bHQgdG8gYSBkYXRhIGFib3J0IGluIHRoZSBoeXBlcnZpc29yLg0KPj4+Pj4NCj4+Pj4+IElu
IGZhY3QsIEkgdGhpbmsgdGhlIHZQQ0kgY29kZSBzaG91bGQgYmUgcmVzaWxpZW50IGVub3VnaCB0
byBub3QgY3Jhc2ggaWYgd2UgcGFzcyB0aGUgd3JvbmcgQkRGLg0KPj4+PiBXZWxsLCB0aGVyZSBp
cyBubyAoPykgZWFzeSB3YXkgdG8gdmFsaWRhdGUgU0JERi4NCj4+Pg0KPj4+IEFGQUlDVCBwY2lf
ZWNhbV9tYXBfYnVzKCkgaXMgYWxyZWFkeSBkb2luZyBzb21lIHZhbGlkYXRpb24gZm9yIHRoZSBi
dXMgbnVtYmVyLiBTby4uLg0KPj4gd2hhdCBpdCBkb2VzIGlzIG5vdCBlbm91Z2ggYXMuLi4NCj4+
IMKgIMKgwqDCoCBpZiAoIGJ1c24gPCBjZmctPmJ1c25fc3RhcnQgfHwgYnVzbiA+IGNmZy0+YnVz
bl9lbmQgKQ0KPj4gwqAgwqDCoMKgwqDCoMKgwqAgcmV0dXJuIE5VTEw7DQo+Pg0KPj4gwqAgwqDC
oMKgIGJ1c24gLT0gY2ZnLT5idXNuX3N0YXJ0Ow0KPj4gwqAgwqDCoMKgIGJhc2UgPSBjZmctPndp
biArIChidXNuIDw8IG9wcy0+YnVzX3NoaWZ0KTsNCj4+DQo+PiDCoCDCoMKgwqAgcmV0dXJuIGJh
c2UgKyAoUENJX0RFVkZOMihzYmRmLmJkZikgPDwgZGV2Zm5fc2hpZnQpICsgd2hlcmU7DQo+PiB0
aGlzIGNhbiBzdGlsbCBvdmVycnVuDQo+DQo+IFRoYW5rcywgSSBndWVzc2VkIHRoaXMgd2FzIG5v
dCBlbm91Z2guLi4gV2hhdCBJIGFtIHRyeWluZyB0byB1bmRlcnN0YW5kIGlzICp3aHkqIHRoaXMg
aXMgbm90IGVub3VnaCAqYW5kKiB3aGV0aGVyIHdlIG5lZWQgdG8gYWRkIG1vcmUgdmFsaWRhdGlv
bi4NCj4NCj4+Pg0KPj4+IMKgwqBBbmQgdGhpcyBjb3VsZCBiZSBhIHByb2JsZW0gaWYgd2UgaGF2
ZSBhIG1pc2JlaGF2aW5nDQo+Pj4+IGd1ZXN0IHdoaWNoIG1heSBmb3JjZSBYZW4gdG8gYWNjZXNz
IHRoZSBtZW1vcnkgYmV5b25kIHRoYXQgb2YgUENJIGhvc3QgYnJpZGdlDQo+Pj4+Pg0KPj4+Pj4g
V2hlbiB0aGVyZSBpcyBhIGRhdGEgYWJvcnQgaW4gWGVuLCB5b3Ugc2hvdWxkIGdldCBhIHN0YWNr
IHRyYWNlIGZyb20gd2hlcmUgdGhpcyBjb21lcyBmcm9tLiBDYW4geW91IHBhc3RlIGl0IGhlcmU/
DQo+Pj4+IChYRU4pIERhdGEgQWJvcnQgVHJhcC4gU3luZHJvbWU9MHg2DQo+Pj4+IChYRU4pIFdh
bGtpbmcgSHlwZXJ2aXNvciBWQSAweDQ2N2EyOGJjIG9uIENQVTAgdmlhIFRUQlIgMHgwMDAwMDAw
MDQ4MWQ1MDAwDQo+Pj4+IChYRU4pIDBUSFsweDBdID0gMHgwMDAwMDAwMDQ4MWQ0ZjdmDQo+Pj4+
IChYRU4pIDFTVFsweDFdID0gMHgwMDAwMDAwMDQ4MWQyZjdmDQo+Pj4+IChYRU4pIDJORFsweDMz
XSA9IDB4MDAwMDAwMDAwMDAwMDAwMA0KPj4+PiAoWEVOKSBDUFUwOiBVbmV4cGVjdGVkIFRyYXA6
IERhdGEgQWJvcnQNCj4+Pg0KPj4+IC4uLiBJIGFtIGdldHRpbmcgcXVpdGUgY29uZnVzZWQgd2h5
IHRoaXMgaXMgY3Jhc2hpbmcuIEFyZSB3ZSB2YWxpZGF0aW9uIGNvcnJlY3RseSB0aGUgYWNjZXNz
Pw0KPj4gU2VlIGFib3ZlLiBJZiBwcm92aWRlZCB3aXRoIGJpZyBlbm91Z2ggU0JERiB3ZSBjYW4g
ZW5kIHVwIGdldHRpbmcgb3V0IG9mIHRoZSB3aW5kb3cuDQo+DQo+IFNob3VsZG4ndCB3ZSB2YWxp
ZGF0ZSB0aGF0IHdlIGFyZSBzdGlsbCBpbiB0aGUgd2luZG93Pw0KWWVzLCB0aGlzIHdpbGwgd29y
ayBpZiBjaGVjayBpcyBpbXBsZW1lbnRlZCB0byByZXNwZWN0IGJyaWRnZSdzIGNvbmZpZyB3aW5k
b3cuDQo+DQo+Pj4NCj4+Pg0KPj4+PiAoWEVOKSAtLS0tWyBYZW4tNC4xNi11bnN0YWJsZcKgIGFy
bTY0IGRlYnVnPXnCoCBOb3QgdGFpbnRlZCBdLS0tLQ0KPj4+PiAoWEVOKSBDUFU6wqDCoMKgIDAN
Cj4+Pj4gKFhFTikgUEM6wqDCoMKgwqAgMDAwMDAwMDAwMDI2ZDNkNCBwY2lfZ2VuZXJpY19jb25m
aWdfcmVhZCsweDg4LzB4OWMNCj4+Pj4gKFhFTikgTFI6wqDCoMKgwqAgMDAwMDAwMDAwMDI2ZDM2
Yw0KPj4+PiAoWEVOKSBTUDrCoMKgwqDCoCAwMDAwODAwMDdmZjk3YzAwDQo+Pj4+IChYRU4pIENQ
U1I6wqDCoCAwMDAwMDAwMDYwNDAwMjQ5IE1PREU6NjQtYml0IEVMMmggKEh5cGVydmlzb3IsIGhh
bmRsZXIpDQo+Pj4+IChYRU4pwqDCoMKgwqDCoCBYMDogMDAwMDAwMDA0NjdhMjhiY8KgIFgxOiAw
MDAwMDAwMDA2NWQwOGJjwqAgWDI6IDAwMDAwMDAwMDAwMDA4YmMNCj4+Pj4gKFhFTinCoMKgwqDC
oMKgIFgzOiAwMDAwMDAwMDAwMDAwMDBjwqAgWDQ6IDAwMDA4MDAwN2ZmYzZmZDDCoCBYNTogMDAw
MDAwMDAwMDAwMDAwMA0KPj4+PiAoWEVOKcKgwqDCoMKgwqAgWDY6IDAwMDAwMDAwMDAwMDAwMTTC
oCBYNzogZmZmZjgwMDAxMWE1ODAwMMKgIFg4OiBmZmZmMDAwMDIyNWEwMzgwDQo+Pj4+IChYRU4p
wqDCoMKgwqDCoCBYOTogMDAwMDAwMDAwMDAwMDAwMCBYMTA6IDAxMDEwMTAxMDEwMTAxMDEgWDEx
OiAwMDAwMDAwMDAwMDAwMDI4DQo+Pj4+IChYRU4pwqDCoMKgwqAgWDEyOiAwMTAxMDEwMTAxMDEw
MTAxIFgxMzogMDAwMDAwMDAwMDAwMDAyMCBYMTQ6IGZmZmZmZmZmZmZmZmZmZmYNCj4+Pj4gKFhF
TinCoMKgwqDCoCBYMTU6IDAwMDAwMDAwMDAwMDAwMDEgWDE2OiBmZmZmODAwMDEwZGE2NzA4IFgx
NzogMDAwMDAwMDAwMDAwMDAyMA0KPj4+PiAoWEVOKcKgwqDCoMKgIFgxODogMDAwMDAwMDAwMDAw
MDAwMiBYMTk6IDAwMDAwMDAwMDAwMDAwMDQgWDIwOiAwMDAwODAwMDdmZjk3YzVjDQo+Pj4+IChY
RU4pwqDCoMKgwqAgWDIxOiAwMDAwMDAwMDAwMDAwOGJjIFgyMjogMDAwMDAwMDAwMDAwMDhiYyBY
MjM6IDAwMDAwMDAwMDAwMDAwMDQNCj4+Pj4gKFhFTinCoMKgwqDCoCBYMjQ6IDAwMDAwMDAwMDAw
MDAwMDAgWDI1OiAwMDAwMDAwMDAwMDAwOGJjIFgyNjogMDAwMDAwMDAwMDAwNjVkMA0KPj4+PiAo
WEVOKcKgwqDCoMKgIFgyNzogMDAwMDgwMDA3ZmZiOTAxMCBYMjg6IDAwMDAwMDAwMDAwMDAwMDDC
oCBGUDogMDAwMDgwMDA3ZmY5N2MwMA0KPj4+PiAoWEVOKQ0KPj4+PiAoWEVOKcKgwqAgVlRDUl9F
TDI6IDAwMDAwMDAwODAwYTM1NTgNCj4+Pj4gKFhFTinCoCBWVFRCUl9FTDI6IDAwMDEwMDAwYmZm
YmEwMDANCj4+Pj4gKFhFTikNCj4+Pj4gKFhFTinCoCBTQ1RMUl9FTDI6IDAwMDAwMDAwMzBjZDE4
M2QNCj4+Pj4gKFhFTinCoMKgwqAgSENSX0VMMjogMDAwMDAwMDA4MDdjNjYzZg0KPj4+PiAoWEVO
KcKgIFRUQlIwX0VMMjogMDAwMDAwMDA0ODFkNTAwMA0KPj4+PiAoWEVOKQ0KPj4+PiAoWEVOKcKg
wqDCoCBFU1JfRUwyOiAwMDAwMDAwMDk2MDAwMDA2DQo+Pj4+IChYRU4pwqAgSFBGQVJfRUwyOiAw
MDAwMDAwMDAwZTY1ZDAwDQo+Pj4+IChYRU4pwqDCoMKgIEZBUl9FTDI6IDAwMDAwMDAwNDY3YTI4
YmMNCj4+Pj4gKFhFTikNCj4+Pj4gW3NuaXBdDQo+Pj4+IChYRU4pIFhlbiBjYWxsIHRyYWNlOg0K
Pj4+PiAoWEVOKcKgwqDCoCBbPDAwMDAwMDAwMDAyNmQzZDQ+XSBwY2lfZ2VuZXJpY19jb25maWdf
cmVhZCsweDg4LzB4OWMgKFBDKQ0KPj4+PiAoWEVOKcKgwqDCoCBbPDAwMDAwMDAwMDAyNmQzNmM+
XSBwY2lfZ2VuZXJpY19jb25maWdfcmVhZCsweDIwLzB4OWMgKExSKQ0KPj4+PiAoWEVOKcKgwqDC
oCBbPDAwMDAwMDAwMDAyNmQyYzg+XSBwY2ktYWNjZXNzLmMjcGNpX2NvbmZpZ19yZWFkKzB4NjAv
MHg4NA0KPj4+PiAoWEVOKcKgwqDCoCBbPDAwMDAwMDAwMDAyNmQ0YTg+XSBwY2lfY29uZl9yZWFk
MzIrMHgxMC8weDE4DQo+Pj4+IChYRU4pwqDCoMKgIFs8MDAwMDAwMDAwMDI0ZGNmOD5dIHZwY2ku
YyN2cGNpX3JlYWRfaHcrMHg0OC8weGI4DQo+Pj4+IChYRU4pwqDCoMKgIFs8MDAwMDAwMDAwMDI0
ZTNlND5dIHZwY2lfcmVhZCsweGFjLzB4MjRjDQo+Pj4+IChYRU4pwqDCoMKgIFs8MDAwMDAwMDAw
MDI0ZTkzND5dIHZwY2lfZWNhbV9yZWFkKzB4NzgvMHhhOA0KPj4+PiAoWEVOKcKgwqDCoCBbPDAw
MDAwMDAwMDAyNmUzNjg+XSB2cGNpLmMjdnBjaV9tbWlvX3JlYWQrMHg0NC8weDdjDQo+Pj4+IChY
RU4pwqDCoMKgIFs8MDAwMDAwMDAwMDI3NTA1ND5dIHRyeV9oYW5kbGVfbW1pbysweDFlYy8weDI2
NA0KPj4+PiAoWEVOKcKgwqDCoCBbPDAwMDAwMDAwMDAyN2VhNTA+XSB0cmFwcy5jI2RvX3RyYXBf
c3RhZ2UyX2Fib3J0X2d1ZXN0KzB4MThjLzB4MmQ4DQo+Pj4+IChYRU4pwqDCoMKgIFs8MDAwMDAw
MDAwMDI3ZjA4OD5dIGRvX3RyYXBfZ3Vlc3Rfc3luYysweGYwLzB4NjE4DQo+Pj4+IChYRU4pwqDC
oMKgIFs8MDAwMDAwMDAwMDI2OWM1OD5dIGVudHJ5Lm8jZ3Vlc3Rfc3luY19zbG93cGF0aCsweGE0
LzB4ZDQNCj4+Pj4gKFhFTikNCj4+Pj4gKFhFTikNCj4+Pj4gKFhFTikgKioqKioqKioqKioqKioq
KioqKioqKioqKioqKioqKioqKioqKioqKg0KPj4+PiAoWEVOKSBQYW5pYyBvbiBDUFUgMDoNCj4+
Pj4gKFhFTikgQ1BVMDogVW5leHBlY3RlZCBUcmFwOiBEYXRhIEFib3J0DQo+Pj4+IChYRU4pICoq
KioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioNCj4+Pj4NCj4+Pj4+DQo+Pj4+
Pj4NCj4+Pj4+PiBGaXggdGhpcyBieSBhZGp1c3RpbmcgdGhlIGdwYSB3aXRoIHJlc3BlY3QgdG8g
dGhlIGhvc3QgYnJpZGdlIGJhc2UgYWRkcmVzcw0KPj4+Pj4+IGluIGEgd2F5IGFzIGl0IGlzIGRv
bmUgZm9yIHg4Ni4NCj4+Pj4+Pg0KPj4+Pj4+IEZpeGVzOiBkNTkxNjhkYzA1YTUgKCJ4ZW4vYXJt
OiBFbmFibGUgdGhlIGV4aXN0aW5nIHg4NiB2aXJ0dWFsIFBDSSBzdXBwb3J0IGZvciBBUk0iKQ0K
Pj4+Pj4+DQo+Pj4+Pj4gU2lnbmVkLW9mZi1ieTogT2xla3NhbmRyIEFuZHJ1c2hjaGVua28gPG9s
ZWtzYW5kcl9hbmRydXNoY2hlbmtvQGVwYW0uY29tPg0KPj4+Pj4+IC0tLQ0KPj4+Pj4+IMKgwqDC
oCB4ZW4vYXJjaC9hcm0vdnBjaS5jIHwgNCArKy0tDQo+Pj4+Pj4gwqDCoMKgIDEgZmlsZSBjaGFu
Z2VkLCAyIGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pDQo+Pj4+Pj4NCj4+Pj4+PiBkaWZm
IC0tZ2l0IGEveGVuL2FyY2gvYXJtL3ZwY2kuYyBiL3hlbi9hcmNoL2FybS92cGNpLmMNCj4+Pj4+
PiBpbmRleCA4ZjQwYTBkZWM2ZDIuLjIzZjQ1Mzg2ZjRiMyAxMDA2NDQNCj4+Pj4+PiAtLS0gYS94
ZW4vYXJjaC9hcm0vdnBjaS5jDQo+Pj4+Pj4gKysrIGIveGVuL2FyY2gvYXJtL3ZwY2kuYw0KPj4+
Pj4+IEBAIC0yNCw3ICsyNCw3IEBAIHN0YXRpYyBpbnQgdnBjaV9tbWlvX3JlYWQoc3RydWN0IHZj
cHUgKnYsIG1taW9faW5mb190ICppbmZvLA0KPj4+Pj4+IMKgwqDCoMKgwqDCoMKgIHVuc2lnbmVk
IGxvbmcgZGF0YTsNCj4+Pj4+PiDCoMKgwqAgwqDCoMKgwqDCoCAvKiBXZSBpZ25vcmUgc2VnbWVu
dCBwYXJ0IGFuZCBhbHdheXMgaGFuZGxlIHNlZ21lbnQgMCAqLw0KPj4+Pj4+IC3CoMKgwqAgc2Jk
Zi5zYmRmID0gVlBDSV9FQ0FNX0JERihpbmZvLT5ncGEpOw0KPj4+Pj4+ICvCoMKgwqAgc2JkZi5z
YmRmID0gVlBDSV9FQ0FNX0JERihpbmZvLT5ncGEgLSBHVUVTVF9WUENJX0VDQU1fQkFTRSk7DQo+
Pj4+Pg0KPj4+Pj4gTG9va2luZyBhdCB0aGUgcmVzdCBvZiB0aGUgcmVzdCwgaXQgc2VlbXMgdGhh
dA0KPj4+Pj4gwqDCoMKgMSkgdGhlIGlzc3VlIGlzIGxhdGVudCBhcyB0aGUgYml0cyAwLTI3IGFy
ZSBjbGVhcg0KPj4+Pj4gwqDCoMKgMikgdGhpcyB3aWxsIG5lZWQgdG8gYmUgbW9kaWZpZWQgdG8g
dGFrZSBpbnRvIGFjY291bnQgZG9tMC4NCj4+Pj4+DQo+Pj4+PiBTbyBJIHdvdWxkIHByZWZlciBp
ZiB0aGUgYmFzZSBhZGRyZXNzIGlzIHBhc3NlZCBkaWZmZXJlbnRseSAobWF5YmUgaW4gcHJpdj8p
IGZyb20gdGhlIHN0YXJ0LiBUaGlzIHdpbGwgYXZvaWQgZXh0cmEgbW9kaWZpY2F0aW9uIHRoYXQg
eW91IGFscmVhZHkgcGxhbiB0byBoYXZlIGluIGEgZm9sbG93LXVwIHNlcmllcy4NCj4+Pj4gSSB3
YXMgdGhpbmtpbmcgYWJvdXQgdGhlIHNhbWUsIGJ1dCB0aGUgZnV0dXJlIGNvZGUgd2lsbCB1c2Ug
cHJpdiBmb3Igb3RoZXIgcHVycG9zZToNCj4+Pj4NCj4+Pj4gc3RhdGljIGludCB2cGNpX21taW9f
cmVhZChzdHJ1Y3QgdmNwdSAqdiwgbW1pb19pbmZvX3QgKmluZm8sDQo+Pj4+IMKgwqAgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgcmVnaXN0ZXJfdCAq
ciwgdm9pZCAqcCkNCj4+Pj4gew0KPj4+PiDCoMKgIMKgwqDCoCBzdHJ1Y3QgcGNpX2hvc3RfYnJp
ZGdlICpicmlkZ2UgPSBwOw0KPj4+PiDCoMKgIMKgwqDCoCBwY2lfc2JkZl90IHNiZGY7DQo+Pj4+
IMKgwqAgwqDCoMKgIC8qIGRhdGEgaXMgbmVlZGVkIHRvIHByZXZlbnQgYSBwb2ludGVyIGNhc3Qg
b24gMzJiaXQgKi8NCj4+Pj4gwqDCoCDCoMKgwqAgdW5zaWduZWQgbG9uZyBkYXRhOw0KPj4+Pg0K
Pj4+PiDCoMKgIMKgwqDCoCBpZiAoIGJyaWRnZSApDQo+Pj4+IMKgwqAgwqDCoMKgIHsNCj4+Pj4g
wqDCoCDCoMKgwqDCoMKgwqDCoCBzYmRmLnNiZGYgPSBWUENJX0VDQU1fQkRGKGluZm8tPmdwYSAt
IGJyaWRnZS0+Y2ZnLT5waHlzX2FkZHIpOw0KPj4+PiDCoMKgIMKgwqDCoMKgwqDCoMKgIHNiZGYu
c2VnID0gYnJpZGdlLT5zZWdtZW50Ow0KPj4+PiDCoMKgIMKgwqDCoCB9DQo+Pj4+IMKgwqAgwqDC
oMKgIGVsc2UNCj4+Pj4gwqDCoCDCoMKgwqDCoMKgwqDCoCBzYmRmLnNiZGYgPSBWUENJX0VDQU1f
QkRGKGluZm8tPmdwYSAtIEdVRVNUX1ZQQ0lfRUNBTV9CQVNFKTsNCj4+Pg0KPj4+IElzIGl0IHRo
ZSBvbmx5IHBsYWNlIHlvdSBhcmUgZG9pbmcgdG8gdXNlIGJyaWRnZT8gSWYgc28sIHRoZW4gSSB0
aGluayB3ZSBjYW4gc2ltcGx5IGhhdmUgYSBzdHJ1Y3R1cmUgdGhhdCB3b3VsZCBjb250YWluIHBo
eXNfYWRkciBhbmQgc2VnbWVudC4NCj4+Pg0KPj4+IFRoaXMgd291bGQgYmUgaW5jbHVkZSBpbiB0
aGUgYnJpZGdlIGZvciBkb20wIGFuZCBmb3IgZ3Vlc3QgdGhpcyBjb3VsZCBiZSBhIHN0YXRpYyBn
bG9iYWwgdmFyaWFibGUgZm9yIG5vdy4NCj4+IEhtLiBJIGRvbid0IHRoaW5rIGEgZ2xvYmFsIGlz
IGFueSBiZXR0ZXIgdGhhbiB1c2luZyBpbmZvLT5ncGEgLSBHVUVTVF9WUENJX0VDQU1fQkFTRS4N
Cj4+IEJ1dCBJIGFtIGZpbmUgd2l0aCB0aGUgc3RydWN0dXJlOiBwbGVhc2UgbGV0IG1lIGtub3cg
eW91ciBwcmVmZXJlbmNlLA0KPj4gc28gSSBjYW4gaGF2ZSBhbiBhY2NlcHRhYmxlIGZpeA0KPg0K
PiBUaGUgZGlmZmVyZW5jZSBpcyB5b3UgZG9uJ3QgZHVwbGljYXRlIHRoZSBzYW1lIGNoZWNrIGlu
IHR3byBwbGFjZXMNCj4gQWx0ZXJuYXRpdmVseSwgSSB3b3VsZCBiZSBoYXBweSBjb25zaWRlciBh
biBoZWxwZXIgdGhhdCBpcyB1c2VkIGluIGJvdGggcGxhY2VzLg0KQnV0IHRoZW4gd2UgZHVwbGlj
YXRlIGRhdGEgaW5zaWRlICJzdHJ1Y3QgcGNpX2hvc3RfYnJpZGdlICpicmlkZ2UiIGJlY2F1c2Ug
d2UgbmVlZA0KdG8gYWxsb2NhdGUgKGhhdmUgaXQgZW1iZWRkZWQpIHN1Y2ggYSBzdHJ1Y3R1cmUg
cGVyIGJyaWRnZSwgZS5nLiB3ZSBoYXZlDQoNCmJyaWRnZS0+c2VnbWVudA0KYnJpZGdlLT5jZmct
PnBoeXNfYWRkcg0KDQphbmQgdGhlbiB3ZSBhZGQgYSBzdHJ1Y3R1cmUgd2hpY2ggY29udGFpbnMg
dGhlIHNhbWU6DQoNCmJyaWRnZS0+bmV3X3N0cnVjdC5zZWdtZW50ID09IGJyaWRnZS0+c2VnbWVu
dA0KYnJpZGdlLT5uZXdfc3RydWN0LnBoeXNfYWRkciA9PSBicmlkZ2UtPmNmZy0+cGh5c19hZGRy
DQoNClRoaXMgaXMgc28gdGhhdCBicmlkZ2UtPm5ld19zdHJ1Y3QgY2FuIGJlIHBhc3NlZCBhcyBh
IHByaXZhdGUgdG8gcmVnaXN0ZXJfbW1pb19oYW5kbGVyDQoNCkFuZCB0aGUgYWJvdmUgc2VlbXMg
dG8gYmUgbm8gc28gYnJpZ2h0IGNvbXBhcmluZyB0byBqdXN0IHBhc3NpbmcNCmJyaWRnZSBhcyBw
cml2YXRlIGFuZCB1c2luZyBpbmZvLT5ncGEgLSBHVUVTVF9WUENJX0VDQU1fQkFTRS4uLg0KU28s
IEkgd291bGQgc3RheSB3aXRoIHNpbXBsZXINCg0KIMKgwqDCoCBpZiAoIGJyaWRnZSApDQogwqDC
oCDCoMKgwqAgew0KIMKgwqAgwqDCoMKgwqDCoMKgwqAgc2JkZi5zYmRmID0gVlBDSV9FQ0FNX0JE
RihpbmZvLT5ncGEgLSBicmlkZ2UtPmNmZy0+cGh5c19hZGRyKTsNCiDCoMKgIMKgwqDCoMKgwqDC
oMKgIHNiZGYuc2VnID0gYnJpZGdlLT5zZWdtZW50Ow0KIMKgwqAgwqDCoMKgIH0NCiDCoMKgIMKg
wqDCoCBlbHNlDQogwqDCoCDCoMKgwqDCoMKgwqDCoCBzYmRmLnNiZGYgPSBWUENJX0VDQU1fQkRG
KGluZm8tPmdwYSAtIEdVRVNUX1ZQQ0lfRUNBTV9CQVNFKTsNCj4NCj4gQ2hlZXJzLA0KPg0KVGhh
bmsgeW91LA0KT2xla3NhbmRy


From xen-devel-bounces@lists.xenproject.org Thu Oct 28 15:35:42 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Oct 2021 15:35:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.218155.378471 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg7RB-0003ER-Q6; Thu, 28 Oct 2021 15:35:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 218155.378471; Thu, 28 Oct 2021 15:35:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg7RB-0003EK-Lq; Thu, 28 Oct 2021 15:35:29 +0000
Received: by outflank-mailman (input) for mailman id 218155;
 Thu, 28 Oct 2021 15:35:28 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mg7RA-0003EE-NM
 for xen-devel@lists.xenproject.org; Thu, 28 Oct 2021 15:35:28 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mg7R8-000219-PW; Thu, 28 Oct 2021 15:35:26 +0000
Received: from 54-240-197-225.amazon.com ([54.240.197.225] helo=[10.7.236.13])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mg7R8-0002aP-JS; Thu, 28 Oct 2021 15:35:26 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=tm1fQqAazImqGUvQVkJgceZ7un+Txhyo0qJJW8MmxZ8=; b=glG4PC4tXyuA8Q3NSyF5K4HLrB
	ILNQNtzCed8T5pbJBdy8chnRjNv46Nw/OIWzublXA/31uXHZrTR9AqFA4JC7nQuGz/glqEnhsrBDc
	5tr13IYMoI6beUvYiMUNnMt9GyOkwztO0Uk/1Y7M+2cutidrJOt0M7/rLNORyC+JcR9U=;
Message-ID: <a74b52fb-6514-4187-17fe-b63236efa0ce@xen.org>
Date: Thu, 28 Oct 2021 16:35:24 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.2.1
Subject: Re: [PATCH] xen/arm: fix SBDF calculation for vPCI MMIO handlers
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: "sstabellini@kernel.org" <sstabellini@kernel.org>,
 "iwj@xenproject.org" <iwj@xenproject.org>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Rahul Singh <rahul.singh@arm.com>
References: <20211027082533.1406015-1-andr2000@gmail.com>
 <cb7e9ef7-476e-93c3-d3c9-9a9ebc61003d@xen.org>
 <d63c6e0b-8aa3-9ba3-893c-5e464638a8db@epam.com>
 <65886734-7333-4469-fcc1-6916db708f13@xen.org>
 <b6bb02b6-6358-b5e0-1b80-7819aadabe10@epam.com>
 <6d8f1061-7aec-2c1a-aaf4-c30440c2797a@xen.org>
 <38da2edd-06a2-63d0-51ad-1284272c8da5@epam.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <38da2edd-06a2-63d0-51ad-1284272c8da5@epam.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi,

On 28/10/2021 16:27, Oleksandr Andrushchenko wrote:
> bridge as private and using info->gpa - GUEST_VPCI_ECAM_BASE...
> So, I would stay with simpler
> 
>       if ( bridge )
>          {
>              sbdf.sbdf = VPCI_ECAM_BDF(info->gpa - bridge->cfg->phys_addr);
>              sbdf.seg = bridge->segment;
>          }
>          else
>              sbdf.sbdf = VPCI_ECAM_BDF(info->gpa - GUEST_VPCI_ECAM_BASE);

I am fine with that so long this is part of an helper (maybe 
vpci_sbdf_from_addr()) rather than duplicated.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Thu Oct 28 15:55:19 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Oct 2021 15:55:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.218164.378482 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg7k9-0005iQ-EN; Thu, 28 Oct 2021 15:55:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 218164.378482; Thu, 28 Oct 2021 15:55:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg7k9-0005iJ-BA; Thu, 28 Oct 2021 15:55:05 +0000
Received: by outflank-mailman (input) for mailman id 218164;
 Thu, 28 Oct 2021 15:55:04 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mg7k7-0005iD-VJ
 for xen-devel@lists.xenproject.org; Thu, 28 Oct 2021 15:55:03 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mg7k7-0002MB-Sx
 for xen-devel@lists.xenproject.org; Thu, 28 Oct 2021 15:55:03 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1mg7k7-0003lf-S6
 for xen-devel@lists.xenproject.org; Thu, 28 Oct 2021 15:55:03 +0000
Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89)
 (envelope-from <iwj@xenproject.org>)
 id 1mg7k2-0002Zf-AA; Thu, 28 Oct 2021 16:54:58 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date
	:Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From;
	bh=XKsSmWH6fEEInPTeowmJjPBExAxFn3B2Cx2v8gh8Gkc=; b=WCdg6XN8g1xt9YEd1SV+H7e3fM
	f4IU2LpRnVcaMxjk11V/hr/H2kkGz5uJnxWlCmkN5GXudtKXFdhMFn5LqdY65SaBdkIY/dDSN/nW7
	wxwSsyt3AOloIfwDQdKOnC3vgj+SBgxdSHdazDtz+SGrbXXqW129oXVIYoUaKA88cb2o=;
From: Ian Jackson <iwj@xenproject.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
Message-ID: <24954.51153.588540.850154@mariner.uk.xensource.com>
Date: Thu, 28 Oct 2021 16:54:57 +0100
To: Julien Grall <julien@xen.org>
Cc: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>,
    "xen-devel\@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
    "sstabellini\@kernel.org" <sstabellini@kernel.org>,
    "iwj\@xenproject.org" <iwj@xenproject.org>,
    Bertrand Marquis <bertrand.marquis@arm.com>,
    Rahul Singh <rahul.singh@arm.com>
Subject: Re: [PATCH] xen/arm: fix SBDF calculation for vPCI MMIO handlers
In-Reply-To: <a74b52fb-6514-4187-17fe-b63236efa0ce@xen.org>
References: <20211027082533.1406015-1-andr2000@gmail.com>
	<cb7e9ef7-476e-93c3-d3c9-9a9ebc61003d@xen.org>
	<d63c6e0b-8aa3-9ba3-893c-5e464638a8db@epam.com>
	<65886734-7333-4469-fcc1-6916db708f13@xen.org>
	<b6bb02b6-6358-b5e0-1b80-7819aadabe10@epam.com>
	<6d8f1061-7aec-2c1a-aaf4-c30440c2797a@xen.org>
	<38da2edd-06a2-63d0-51ad-1284272c8da5@epam.com>
	<a74b52fb-6514-4187-17fe-b63236efa0ce@xen.org>
X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu)

Julien Grall writes ("Re: [PATCH] xen/arm: fix SBDF calculation for vPCI MMIO handlers"):
> On 28/10/2021 16:27, Oleksandr Andrushchenko wrote:
> > bridge as private and using info->gpa - GUEST_VPCI_ECAM_BASE...
> > So, I would stay with simpler
> > 
> >   ��� if ( bridge )
> >   �� ��� {
> >   �� ������� sbdf.sbdf = VPCI_ECAM_BDF(info->gpa - bridge->cfg->phys_addr);
> >   �� ������� sbdf.seg = bridge->segment;
> >   �� ��� }
> >   �� ��� else
> >   �� ������� sbdf.sbdf = VPCI_ECAM_BDF(info->gpa - GUEST_VPCI_ECAM_BASE);
> 
> I am fine with that so long this is part of an helper (maybe 
> vpci_sbdf_from_addr()) rather than duplicated.

There are a number of patches that I'm getting CC'd on related to ARM
and vpci (according to the Subject).  Are these targeted for 4.16 ?
Most of them don't have 4.16 Subject tags.

Am I getting these in my capacity as a REST maintainer ?

I am finding it difficult to see the wood for the trees.
It would be really helpful if these vpci fixes were collected
together into a series.

Thanks,
Ian.
(writing as Xen 4.16 Release Manager)


From xen-devel-bounces@lists.xenproject.org Thu Oct 28 16:03:47 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Oct 2021 16:03:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.218173.378493 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg7sQ-0007pv-A5; Thu, 28 Oct 2021 16:03:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 218173.378493; Thu, 28 Oct 2021 16:03:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg7sQ-0007po-6o; Thu, 28 Oct 2021 16:03:38 +0000
Received: by outflank-mailman (input) for mailman id 218173;
 Thu, 28 Oct 2021 16:03:36 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=8Bw3=PQ=citrix.com=roger.pau@srs-us1.protection.inumbo.net>)
 id 1mg7sO-0007pi-LJ
 for xen-devel@lists.xenproject.org; Thu, 28 Oct 2021 16:03:36 +0000
Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 9a459020-3808-11ec-84ad-12813bfff9fa;
 Thu, 28 Oct 2021 16:03:35 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9a459020-3808-11ec-84ad-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1635437015;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=9u2H7nk240qRYpc+lqJG6AT9egmxsNEET0ohJROM+CY=;
  b=aF2wJJHXf8ahhbaxt+qmwIXaH4NAadUEqs6Vow8wc3U5R7qjvxOCWm5K
   V3t0wcTBtuQhv1S4Tf8xRu58HV6OgN/tuwczht9BWD0DRRU6LATowOAY5
   leY2gyeW0wNawfk2KR5y9jl94CwYOv0YrbwYaePDYYgXPNCTtJe1CXJjh
   w=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: bgvn3qQYvAt+QNLMLRsBLPnkJc/SoQAL5VGe5uZHPt3qCalmF90qKeWvJu3MAgu984UB35S/Mj
 ZreV3XibYCrxA5JzYNJAWD9GmiJNcd10lr7od2wkLs6+5znTGmJgOSRLrOnO/2oVBzGbTGI4Ae
 H6bhxHzPzlBdheEUHyg3nFNXXNox0xs2pTzL65wpBoutUqVinloQCNrDbFdEofZZ3xXcfUGqKT
 81v7/9GDMlCeb5n++CPUma9zJY9Gptss6mMBA05HjyxMnr75FrghIH7ukpxdp7zMTJM9LHmNRp
 GgLh51rKeyRqIAtFAY+pK3Rq
X-SBRS: 5.1
X-MesageID: 56570357
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:sOTDLKqBJgYH91h7UGzKYZ8EC4VeBmJTYxIvgKrLsJaIsI4StFCzt
 garIBnQbqrcYWHxe9lwbIm09hkCvZ7XztYxHFBu/C1jHy4SoJuZCYyVIHmrMnLJJKUvbq7GA
 +byyDXkBJppJpMJjk71atANlZT4vE2xbuKU5NTsY0idfic5Dnd+4f5fs7Rh2Ncx2YLpW1nlV
 e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL
 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9
 DlCnYOPEC4rHoPhpNReTkl9EGIkBrB34bCSdBBTseTLp6HHW37lwvEoB0AqJ4wIvO1wBAmi9
 9RBdmpLNErawbvrnvTrEYGAhex6RCXvFJkYtXx6iynQEN4tQIzZQrWM7thdtNs1rp0QQKmGP
 JdGAdZpRCTuSUR3PUs9M6J9g6D4212vU2QB9WvA8MLb5ECMlVcsgdABKuH9e8OIbdVYmF6Co
 WDL9Hi/BQsVXPSVxCCZ6HuqiqnKlDniRYMJPLSi87hhh1j77nYaCAASE0C6p/a5okekXpRUL
 El80jE1saE4+UivT9/8dx61uniJulgbQdU4O8o+5QKWw6zY+TGwAGQeUyVBY9wrsswxbTEy3
 1rPlNTsbRRtrbmURHS15rqS6zSoNkA9PWIEICMJUwYBy93iu50oyALCSM55F6y4hcGzHiv/q
 w1mtwBn2e9V15RSkfzmoxaX2FpAu6QlUCYq2Vz+XEKLwz9JJ5P1Qo/rs2PG3O9PedPxoka6g
 FAInM2X7eYrBJ6LlTCQTOhlIIxF98ppIxWH3gYxR8hJGyCFvif5J9gJsW4WyFJBa55cIVfUj
 FnvVRS9DXO5FECharNreMqPAsAuwLmI+T/NB62MMIQmjnSccma6EMBSiay4gz+FfKsEy/hX1
 XKnnSCEVi9y5UNPl2Peegvl+eV3rh3SPEuKLXwB8zyp0KCFeFmeQqofPV2FY4gRtf3f/V6Lq
 4wEaZral32ztdEShAGMqOb/ynhRdBAG6W3e8ZQLJoZv3CI/QAnN9MM9MZt+Itc4zsy5Z8/D/
 22nW18w9bYMrSavFOl+UVg6MOmHdc8m9RoTZHVwVX71iylLSdv+t883KspoFYTLAcQ+lJaYu
 dFeIJ7eahmOIxyakwkggW7V990/Kk7z31vSb0JIolEXJvZdeuAAwfe9FiPH/ygSFCun88w4p
 ryrzATARpQfAQ9lCa7rhDiHkgjZUaE1lL0gUk3WDMNUfUmwooFmJzao1q08It0WKAWFzTyfj
 l7EDRAdrOjLgok07NiW2vzU89b3S7NzThhAAm3WzbeqLi2GrGCt9pBNDbSTdjfHWWKqpKj7P
 bdJz+vxOeEslUpRt9YuCK5iyK8zvoO9p7JTwgl+Mm/MalCnVuFpLnWchJEdvaxR3L5J/wCxX
 xvXqNVdPLyIPuLjEUIQe1V5PrjSi6lMl2CLv/ovIUj86Ctmx5a9UB1fb0uWlShQDLppK4d5k
 +0vj9Ebtl6kgR0wP9fY0i0NrzaQLmYNWrkMv40BBNO5kRIiz1xPbMCOCiLy553TOdxAPlNzf
 22RjavGwb9d2lDDYzw4En2UhbhRgpEHuRZryl4eJgvWxoqZ16FvhBABoy4qSgl1zwlc17MhM
 2dmAER5OKGS8mo6n8NERW2tR1lMCRDxFpYdELfVeLk1l3WVa1E=
IronPort-HdrOrdr: A9a23:ul2GT61hBhQ1t1ZwArHqHwqjBShyeYIsimQD101hICG9Lfb2qy
 n+ppgmPEHP5Qr5OEtApTiBUJPwJk800aQFm7X5Wo3SITUO2VHYV72KiLGN/9SOIVydygcw79
 YET0E6MqyNMbEYt7eK3ODbKadY/DDvysnB7o2/vhQdPT2CKZsQlzuRYjzrbHGeLzM2Y6bReq
 Dsgvau8FGbCAsqh4mAdzM4dtmGg+eOuIPtYBYACRJiwA6SjQmw4Lq/NxSDxB8RXx5G3L9nqA
 H+4kDEz5Tml8v+5g7X1mfV4ZgTsNz9yuFbDMjJrsQOMD3jhiuheYwkcbyfuzIepv2p9T8R4Z
 TxiiZlG/42x2Laf2mzrxeo8w780Aw243un8lOciWuLm72xeBsKT+56wa5JeBrQ7EQt+Ptm1r
 hQ4m6fv51LSTvdgSXU/bHzJlBXv3vxhUBnvf8YjnRZX4dbQqRWt5Yj8ERcF4pFND7m6bogDP
 JlAKjnlbhrmGuhHjPkV1RUsZ6RtixZJGbCfqFCgL3b79FupgE486NCr/Zv2kvp9/oGOu95Dq
 r/Q+NVfYp1P70rhJRGdZA8qPuMex/wqC33QRevyHTcZek60iH22tXKCItc3pDfRHVP9up1pK
 j8
X-IronPort-AV: E=Sophos;i="5.87,190,1631592000"; 
   d="scan'208";a="56570357"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=YpXOSbhBZcb9qrdMhJiRrMQU/rrq1cpgki5ZmgTJwUl2FCJSnJF0XkGGBCbIQHuPXOphEWH/C+43OGc5Iq2wavcUgmRDnW/Q72ZleVF0QsA1y9SY8TPhiYUWuwi7nqdv5TSwea1wm5b/c5aO8dDge5SHIXXgTIY9vP6Nd7c//7tsGavoDySkSCQhqBgIeNHlxuugxGe5iUoxUqXkoahgldHRRaRhTgvdKuj2QBI0eqMLs/jGZdnWJe6lAqE90LsS8VSUl3cQp4sA/2LDJ03MDr553SFfpcVHyGwXNKeDKX0fGRYlImPs6qidmr6MiCS7/SaiMOo5xcVSFxktQV7pMg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=pp1YNTGO7VSpDzDXzb4cjwnAwSTAIA/DAPMZwjgNhkM=;
 b=J+Yc34nmP/ZTsTUAzmaQG4ogD2+cNNOtaaMCblEBQBZapQ2Uw7MCmK7YXEG8nrvjovVA2JxrCkHO4C4fNjY2xazG+EgThL7PP2I93tkaN8TsM3BzJeNf0RNgvkANgMrh0HqVArKEZOGIiNe0JDSqNAZnn/AKoF3eo0L6EOIFCcdHVpdDIhzQyAw3DG/UbU7BH8bDfj3oPz1roi97gdcuojHKbprdALSyAZSAIBGkquedIbXXoVU3K4p+PuqydCUaNK7CxR4zosd7OYOzsHqBfho/uyvLbO1B/n0oOJZ4PcT9tMpT+Wen1ZtrQcjQeVBdY5DYej33CAHIvO7WHujJKA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=pp1YNTGO7VSpDzDXzb4cjwnAwSTAIA/DAPMZwjgNhkM=;
 b=T8C9Pec30r453mP1dcIgHbxDGrVNQkXhzbvVfzMMDSZzUPIgUz075zkGTrlHgHl7m94iMtwwANBP3WUD5DfQ2gjJTsdncUaWV54jREwgpGxOOASthxi2WDPryYwaT+pCwuEr39i44UndaG/TiWywHuHX5XmfdFUXGxqJzOAQ3pY=
Date: Thu, 28 Oct 2021 18:03:20 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
CC: Julien Grall <julien@xen.org>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, "sstabellini@kernel.org"
	<sstabellini@kernel.org>, "iwj@xenproject.org" <iwj@xenproject.org>, Bertrand
 Marquis <bertrand.marquis@arm.com>, Rahul Singh <rahul.singh@arm.com>
Subject: Re: [PATCH] xen/arm: fix SBDF calculation for vPCI MMIO handlers
Message-ID: <YXrJyLMiMxaNmFAs@Air-de-Roger>
References: <20211027082533.1406015-1-andr2000@gmail.com>
 <cb7e9ef7-476e-93c3-d3c9-9a9ebc61003d@xen.org>
 <d63c6e0b-8aa3-9ba3-893c-5e464638a8db@epam.com>
 <YXqnS7iZUvokJby6@Air-de-Roger>
 <3206478e-f230-cd91-5de9-85ef6c251405@epam.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <3206478e-f230-cd91-5de9-85ef6c251405@epam.com>
X-ClientProxiedBy: MR2P264CA0070.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:500:31::34) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: d458d62d-9b41-4f81-0705-08d99a2c7a02
X-MS-TrafficTypeDiagnostic: DS7PR03MB5445:
X-Microsoft-Antispam-PRVS: <DS7PR03MB54458B675B6612C0C1B034F28F869@DS7PR03MB5445.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: tqSQ+4POXHgw5e0M1WSczkDas+YjIHoSaf55wwIVHQHhfHOY+bQArgmcjPhoH63Gaar3s46jW2Sfri3ibUZ2Lk+jCccd0qKaU1oc63dTeyHRFK4I9dJwTGToH+mQm+M7gPdEswsC0rLWlB2waKCKNKUyvr9teT76zmpgp1TNphjMjM5huWq86uNW9K6yTasNyAq2NFfo8awuIqKhNaG3lOtiwraZbTefctBgjsI068lS8q6XVyasOGTAdIRdGVYXd+ZpNJV8HYE5oeQQkJEDleIs2bWx5CcPllqnC1zIUKnYL6kEyKJsFgt922fPCygL4WgwTCkehSqybgkUhW0P84tmrmQfZGfnTwT+SwvxEdZqAz/vUndY7C78+Cnt+F5v7NrK9dn2MjE1e94y8JYCK4gpsSnzYog3o6qkc3eNIxNfF/Vv2YLjeK/w1lkuCAIbHg4CIxDxy8QwRrqZs9clQA46l5dRrrDKZ9NgXtMCqeopoPlvaPOVuA6tH7ka05o/m3TAmBCttUcxOEUocMeVLFQCpUbsI+nco6kWGaq+4V2JVlZ9SO1xMB6knZAvxOZacZE4TnLFtsQQfLOnPD0ELKwLXZtkJWmYKpwVz5rxVgffkTRte40nhM0t8sHRoblkmvURdL+b6/j4/fFfehzAfQ==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(7916004)(4636009)(366004)(6666004)(53546011)(33716001)(2906002)(38100700002)(9686003)(316002)(5660300002)(83380400001)(6916009)(4326008)(186003)(6486002)(66476007)(85182001)(26005)(508600001)(6496006)(54906003)(66946007)(8676002)(956004)(8936002)(82960400001)(86362001)(66556008);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?S2swTEd1bGwwM1FpQVRsaW4vdGVQaUx5TXA3VlJnVHFFN25Wc1k3VVpwOVJ1?=
 =?utf-8?B?VEplZ0R0aDNiRWZWQUpvQVJrZGJDQVkxM0tzc3czVWRxeU1UOVFUVWVMbnFz?=
 =?utf-8?B?WWpJUVZ4WXIxbHVKL0RRVnZLZEJFUHJQaStIK05HY3BWSVpXbVJnQWZjbERh?=
 =?utf-8?B?akRLWVJjVGo0bnEwVFQ3SGdKSFRkYy9HK0FDZTlBM1hOV1p4QVRlcnR0bHFt?=
 =?utf-8?B?dFRIdnNkSHpXTTQ2WjJOeXZkVmhWbDNlVXJFd2NuTVVzeDZnbGxMWkRmNEsv?=
 =?utf-8?B?Q2J2UEdOa2xEaWwrc1RwZ1h0dStPU2ljMTNEK0hKNmwyaUtYWjI4STg0ckRK?=
 =?utf-8?B?eDVkbnk0NWIrb3Z6UTlaMHN3Tkh5VWhzOVhZK0QvdVNKTmsrRHMyenQxWDJw?=
 =?utf-8?B?RlVCM1M2Yk1jWGhBK0dmWWQycDhKVmQ0YjVraVBBZlVxWU54aEcweEN0bzJp?=
 =?utf-8?B?V1oxSU9aTC9zejdYMzJhQ2ZGQWVaSC93VXlERThjdkpYb0RNUGgyb0N0RlNj?=
 =?utf-8?B?eUJjckNLc0ZPaGRrUmNFaVRhWE55VEN1bTVDSHNzYVZDQTI2MG1NQXYvaDk3?=
 =?utf-8?B?SStuWmxKM1BzVUJGMHZlUlArUzFpaTJLV2V0dThzZnhNRWpJZjJmSVQ4N0Rw?=
 =?utf-8?B?UVBSTE5RWlU3RTRoS2x4Y3NDL21NS0dqTnpMRXh1L0tKVURWc1VIeGFoMTFt?=
 =?utf-8?B?eGVBUVZ1UXVIQ1RrQXBiRDFjTW56dEM2MU8ra3JxTm8zM1FyWUNySmVFVEwr?=
 =?utf-8?B?TnEvMXhJSG1ZNWswT2xNdW5Pc1pDSU55akFKOGhhMkpjTTN3TEhPcE1RNGtm?=
 =?utf-8?B?LzZhZzhyM08zNHp0N2ZVYU5SajIyci9saGhhVThiQ25CNVFGaTMrZnAvcmpM?=
 =?utf-8?B?SUQvNU5MaHJ0elBibjdrU3AxbHBtckxkbWlwS01LSmI4bDRZUWxYTnFIRXBL?=
 =?utf-8?B?bEttM2I1cXVHdkFzdTlIUnJ4SXN3Z2FzWjVSbWhxUlR4ODl1c1pjelJDTzVV?=
 =?utf-8?B?M3FoNnFEMXlQSEpKWHZBU2xOTTU5Y0FESFZxM2NZZVlZOVBBY2YrVE1uQW5z?=
 =?utf-8?B?Q2htcHdIL2tQN2VhQW1mU3ZmdXRwYTBKVHRGZVkxQ0Z6RFhYR0FPcDlIT2E5?=
 =?utf-8?B?dm5hN3JOV1EyNlg4WVdSWDFRZEdOSXJDOVZwQUw1bzBkeUJEL3RyQ21CMnRz?=
 =?utf-8?B?TG1Wa3U4Nmc5eGMxclJueUxVSjFqcjVpTFhnaDAyaERjL1c4RnRVS056ODM5?=
 =?utf-8?B?dEFOR0srVjdMQ0ZtYlpNR1FMaWZnRGY1TzAwcm9TWGF0ZmlrV2EyZ0Rwc1BJ?=
 =?utf-8?B?a0tROHlNVXRqaFVlbUYyVzNrQUJSTGE1T3B1VnFlL29uSlFPdCtLR0VWYnZQ?=
 =?utf-8?B?T2E5NGlRd1QzMnBDdzIyYS92YmRKbTBQMTRQR0lPL2J6L2tURC9IQzJKV3RR?=
 =?utf-8?B?YkdWOGswamlSNUxGRHRPUjMzRFVuMWZPYXRzKzFxdDNGY3Bnd2tsa3BUbGVU?=
 =?utf-8?B?RFArQzFuSzFWTThHZENMTGJQcHBOVGMyWWR3V3BjdGhJYnRTd0I0RzZmVCtW?=
 =?utf-8?B?UUtCRVBsV2QwMTdnVmVIR0hYb0JhTi95amdBdTNPOWQ5VHFyMjh6cWptLzBG?=
 =?utf-8?B?aitQTENQcXU0TmR4QmhDZFF1V1hUeWQ4RFVZYkxNU05EdVFiQzdOWTloOFFD?=
 =?utf-8?B?VFV5aTcrOGU4S3ZTQXNEandFUWE2M3hZa0dLNzhPQWl1VEdTMEMzZEZqL3Jh?=
 =?utf-8?B?MjhRNUg0QzQwSVo5VGJ4ajI0UnoxYXNkd0NaaFB1NWVKaDZFWSthWUdLckRH?=
 =?utf-8?B?TFdzMU94TDFkQTVEZjRad2kvQytFU1lUYk1IWVY2TlVxNG5JUEsyNjhZRjV5?=
 =?utf-8?B?R2VnTmw1UVV4ODRiMFRvbmtXVER5aDZtd0xnMmk4SzZPQnMxdUt3TWo3aDdy?=
 =?utf-8?B?YVFiMmdCSWxDQWExWXU3c1BlMm4rTEdHVWZQRmR4ZmJJb2FVZEF5RWFPV2Qw?=
 =?utf-8?B?b3JxQit4MUpEMGthTUhiUlllVFk3REV6RWcxTVBYOXhnRHIyZDdqeXpOZ28y?=
 =?utf-8?B?T1JRc2JsVnNyL2RGL2JUOExMSnJZSzRhUTVuVHBzTjRaZEIxSmkwT3h4bVZM?=
 =?utf-8?B?UUlTK3dnVnRvWitnU2lwNEppb0dYcTNnNWdZbHQyNzVJWEdqMWFtL3h5bHgx?=
 =?utf-8?Q?3fbJT44DJQ3H+ERvUCX+EzE=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: d458d62d-9b41-4f81-0705-08d99a2c7a02
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Oct 2021 16:03:26.7191
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: SDD9VAaUN71vEdirhy3Az7vNJzdqGHAdQpUTqt3NHoTjUgEVnUlfPj/GxbWeyNiVvLSLP9023yX7OnBw1OdjYw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR03MB5445
X-OriginatorOrg: citrix.com

On Thu, Oct 28, 2021 at 02:23:34PM +0000, Oleksandr Andrushchenko wrote:
> 
> 
> On 28.10.21 16:36, Roger Pau Monné wrote:
> > On Thu, Oct 28, 2021 at 12:09:23PM +0000, Oleksandr Andrushchenko wrote:
> >> Hi, Julien!
> >>
> >> On 27.10.21 20:35, Julien Grall wrote:
> >>> Hi Oleksandr,
> >>>
> >>> On 27/10/2021 09:25, Oleksandr Andrushchenko wrote:
> >>>> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> >>>>
> >>>> While in vPCI MMIO trap handlers for the guest PCI host bridge it is not
> >>>> enough for SBDF translation to simply call VPCI_ECAM_BDF(info->gpa) as
> >>>> the base address may not be aligned in the way that the translation
> >>>> always work. If not adjusted with respect to the base address it may not be
> >>>> able to properly convert SBDF and crashes:
> >>>>
> >>>> (XEN) vpci_mmio_read 0000:65:1a.0 reg 8bc gpa e65d08bc
> >>> I can't find a printk() that may output this message. Where does this comes from?
> >> That was a debug print. I shouldn't have used that in the patch description, but
> >> probably after "---" to better explain what's happening
> >>> Anyway, IIUC the guest physical address is 0xe65d08bc which, if I am not mistaken, doesn't belong to the range advertised for GUEST_VPCI_ECAM.
> >> This is from dom0 I am working on now.
> >>> IMHO, the stack trace should come from usptream Xen or need some information to explain how this was reproduced.
> >>>
> >>>> (XEN) Data Abort Trap. Syndrome=0x6
> >>>> (XEN) Walking Hypervisor VA 0x467a28bc on CPU0 via TTBR 0x00000000481d5000
> >>> I can understnad that if we don't substract GUEST_VPCI_ECAM, we would (in theory) not get the correct BDF. But... I don't understand how this would result to a data abort in the hypervisor.
> >>>
> >>> In fact, I think the vPCI code should be resilient enough to not crash if we pass the wrong BDF.
> >> Well, there is no (?) easy way to validate SBDF. And this could be a problem if we have a misbehaving
> >> guest which may force Xen to access the memory beyond that of PCI host bridge
> > How could that be? The ECAM region exposed to the guest you should be
> > the same as the physical one for dom0?
> Ok, I have a Designware PCI hist which has 2 ECAM regions (I am starting to
> implement the driver for it, so I can be wrong here):
> - Root Complex ECAM area ("dbi"), it is something like 0x3000 bytes long
> - "Client" ECAM area ("config")
> So from Dom0 POV we have 2 ECAM regions and for the guest
> we always emulate a single big region:

You need support for multiple ECAM regions. That's how we do it on x86
PVH dom0. See register_vpci_mmcfg_handler and related machinery.

> /*
>   * 256 MB is reserved for VPCI configuration space based on calculation
>   * 256 buses x 32 devices x 8 functions x 4 KB = 256 MB
>   */
> #define GUEST_VPCI_ECAM_BASE    xen_mk_ullong(0x10000000)
> #define GUEST_VPCI_ECAM_SIZE    xen_mk_ullong(0x10000000)
> 
> So, we have the base address and size of the emulated ECAM space
> not connected to the real host bridge
> >
> > And for domUs you really need to fix vpci_{read,write} to not
> > passthrough accesses not explicitly handled.
> Do you mean that we need to validate SBDFs there?
> This can be tricky if we have a use-case when a PCI device being
> passed through if not put at 0000:00:0.0, but requested to be, for
> example, 0000:0d:0.0. So, we need to go over the list of virtual
> devices and see if SBDF the guest is trying to access is a valid SBDF.
> Is this what you mean?

No, you need to prevent accesses to registers not explicitly handled
by vpci. Ie: do not forward unhandled accesses to
vpci_{read,wrie}_hw).

Regards, Roger.


From xen-devel-bounces@lists.xenproject.org Thu Oct 28 16:38:27 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Oct 2021 16:38:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.218180.378504 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg8Pb-0002yN-T4; Thu, 28 Oct 2021 16:37:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 218180.378504; Thu, 28 Oct 2021 16:37:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg8Pb-0002yG-Pz; Thu, 28 Oct 2021 16:37:55 +0000
Received: by outflank-mailman (input) for mailman id 218180;
 Thu, 28 Oct 2021 16:37:54 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=TkaK=PQ=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1mg8Pa-0002yA-61
 for xen-devel@lists.xenproject.org; Thu, 28 Oct 2021 16:37:54 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id b1eb2b4f-33f2-47de-b446-c78ea2ff80a1;
 Thu, 28 Oct 2021 16:37:52 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id 58AE461056;
 Thu, 28 Oct 2021 16:37:51 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b1eb2b4f-33f2-47de-b446-c78ea2ff80a1
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1635439071;
	bh=1mfaE+t0DGF3qhqf6/10hRKufFVGSY27UZia8A0NKyU=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=JOnfjlMZ2/OkxYmpeCyrIi9FSsE9220WL8zRKqYlBFG7GT8SR8ONlZft/D+NnfhOC
	 Swe0b7txGApP/RKxMJk6UG0Lkv+qSkNsEjRVhHLBkJXiaLHcK5YubTMXPAkEIcYCuO
	 Okf8YM9MUOtEiuAimzWRh5l6ew4fINhV21veLZAWp7fRgnJGZf3cxIMO4wvMn3TL/X
	 3eqGlLJKbEPxDR5CaNqArbp5TSHm0KThso4u5ZL20tkvx5pWNJ6wk3mVftbUlxnSf2
	 WB+tZX7IzcCAKCB8g5i+HmqbHI7nlCqgve7e8xbM1F6jGRK3fpXmlCHDKvTWJuAe0w
	 hH7JDwZS723Kw==
Date: Thu, 28 Oct 2021 09:37:50 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Oleksandr Tyshchenko <olekstysh@gmail.com>
cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, 
    Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, 
    Boris Ostrovsky <boris.ostrovsky@oracle.com>, 
    Juergen Gross <jgross@suse.com>, 
    Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>
Subject: Re: [PATCH V2 3/4] xen/unpopulated-alloc: Add mechanism to use Xen
 resource
In-Reply-To: <1635264312-3796-4-git-send-email-olekstysh@gmail.com>
Message-ID: <alpine.DEB.2.21.2110280920110.20134@sstabellini-ThinkPad-T480s>
References: <1635264312-3796-1-git-send-email-olekstysh@gmail.com> <1635264312-3796-4-git-send-email-olekstysh@gmail.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Tue, 26 Oct 2021, Oleksandr Tyshchenko wrote:
> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> 
> The main reason of this change is that unpopulated-alloc
> code cannot be used in its current form on Arm, but there
> is a desire to reuse it to avoid wasting real RAM pages
> for the grant/foreign mappings.
> 
> The problem is that system "iomem_resource" is used for
> the address space allocation, but the really unallocated
> space can't be figured out precisely by the domain on Arm
> without hypervisor involvement. For example, not all device
> I/O regions are known by the time domain starts creating
> grant/foreign mappings. And following the advise from
> "iomem_resource" we might end up reusing these regions by
> a mistake. So, the hypervisor which maintains the P2M for
> the domain is in the best position to provide unused regions
> of guest physical address space which could be safely used
> to create grant/foreign mappings.
> 
> Introduce new helper arch_xen_unpopulated_init() which purpose
> is to create specific Xen resource based on the memory regions
> provided by the hypervisor to be used as unused space for Xen
> scratch pages.
> 
> If arch doesn't implement arch_xen_unpopulated_init() to
> initialize Xen resource the default "iomem_resource" will be used.
> So the behavior on x86 won't be changed.
> 
> Also fall back to allocate xenballooned pages (steal real RAM
> pages) if we do not have any suitable resource to work with and
> as the result we won't be able to provide unpopulated pages.
> 
> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> ---
> Changes RFC -> V2:
>    - new patch, instead of
>     "[RFC PATCH 2/2] xen/unpopulated-alloc: Query hypervisor to provide unallocated space"
> ---
>  drivers/xen/unpopulated-alloc.c | 89 +++++++++++++++++++++++++++++++++++++++--
>  include/xen/xen.h               |  2 +
>  2 files changed, 88 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/xen/unpopulated-alloc.c b/drivers/xen/unpopulated-alloc.c
> index a03dc5b..1f1d8d8 100644
> --- a/drivers/xen/unpopulated-alloc.c
> +++ b/drivers/xen/unpopulated-alloc.c
> @@ -8,6 +8,7 @@
>  
>  #include <asm/page.h>
>  
> +#include <xen/balloon.h>
>  #include <xen/page.h>
>  #include <xen/xen.h>
>  
> @@ -15,13 +16,29 @@ static DEFINE_MUTEX(list_lock);
>  static struct page *page_list;
>  static unsigned int list_count;
>  
> +static struct resource *target_resource;
> +static struct resource xen_resource = {
> +	.name = "Xen unused space",
> +};
> +
> +/*
> + * If arch is not happy with system "iomem_resource" being used for
> + * the region allocation it can provide it's own view by initializing
> + * "xen_resource" with unused regions of guest physical address space
> + * provided by the hypervisor.
> + */
> +int __weak arch_xen_unpopulated_init(struct resource *res)
> +{
> +	return -ENOSYS;
> +}
> +
>  static int fill_list(unsigned int nr_pages)
>  {
>  	struct dev_pagemap *pgmap;
> -	struct resource *res;
> +	struct resource *res, *tmp_res = NULL;
>  	void *vaddr;
>  	unsigned int i, alloc_pages = round_up(nr_pages, PAGES_PER_SECTION);
> -	int ret = -ENOMEM;
> +	int ret;
>  
>  	res = kzalloc(sizeof(*res), GFP_KERNEL);
>  	if (!res)
> @@ -30,7 +47,7 @@ static int fill_list(unsigned int nr_pages)
>  	res->name = "Xen scratch";
>  	res->flags = IORESOURCE_MEM | IORESOURCE_BUSY;
>  
> -	ret = allocate_resource(&iomem_resource, res,
> +	ret = allocate_resource(target_resource, res,
>  				alloc_pages * PAGE_SIZE, 0, -1,
>  				PAGES_PER_SECTION * PAGE_SIZE, NULL, NULL);
>  	if (ret < 0) {
> @@ -38,6 +55,31 @@ static int fill_list(unsigned int nr_pages)
>  		goto err_resource;
>  	}
>  
> +	/*
> +	 * Reserve the region previously allocated from Xen resource to avoid
> +	 * re-using it by someone else.
> +	 */
> +	if (target_resource != &iomem_resource) {
> +		tmp_res = kzalloc(sizeof(*tmp_res), GFP_KERNEL);
> +		if (!res) {
> +			ret = -ENOMEM;
> +			goto err_insert;
> +		}
> +
> +		tmp_res->name = res->name;
> +		tmp_res->start = res->start;
> +		tmp_res->end = res->end;
> +		tmp_res->flags = res->flags;
> +
> +		ret = insert_resource(&iomem_resource, tmp_res);
> +		if (ret < 0) {
> +			pr_err("Cannot insert IOMEM resource [%llx - %llx]\n",
> +			       tmp_res->start, tmp_res->end);
> +			kfree(tmp_res);
> +			goto err_insert;
> +		}
> +	}

I am a bit confused.. why do we need to do this? Who could be
erroneously re-using the region? Are you saying that the next time
allocate_resource is called it could find the same region again? It
doesn't seem possible?


>  	pgmap = kzalloc(sizeof(*pgmap), GFP_KERNEL);
>  	if (!pgmap) {
>  		ret = -ENOMEM;
> @@ -95,12 +137,40 @@ static int fill_list(unsigned int nr_pages)
>  err_memremap:
>  	kfree(pgmap);
>  err_pgmap:
> +	if (tmp_res) {
> +		release_resource(tmp_res);
> +		kfree(tmp_res);
> +	}
> +err_insert:
>  	release_resource(res);
>  err_resource:
>  	kfree(res);
>  	return ret;
>  }
>  
> +static void unpopulated_init(void)
> +{
> +	static bool inited = false;

initialized = false


> +	int ret;
> +
> +	if (inited)
> +		return;
> +
> +	/*
> +	 * Try to initialize Xen resource the first and fall back to default
> +	 * resource if arch doesn't offer one.
> +	 */
> +	ret = arch_xen_unpopulated_init(&xen_resource);
> +	if (!ret)
> +		target_resource = &xen_resource;
> +	else if (ret == -ENOSYS)
> +		target_resource = &iomem_resource;
> +	else
> +		pr_err("Cannot initialize Xen resource\n");
> +
> +	inited = true;
> +}

Would it make sense to call unpopulated_init from an init function,
rather than every time xen_alloc_unpopulated_pages is called?


>  /**
>   * xen_alloc_unpopulated_pages - alloc unpopulated pages
>   * @nr_pages: Number of pages
> @@ -112,6 +182,16 @@ int xen_alloc_unpopulated_pages(unsigned int nr_pages, struct page **pages)
>  	unsigned int i;
>  	int ret = 0;
>  
> +	unpopulated_init();
> +
> +	/*
> +	 * Fall back to default behavior if we do not have any suitable resource
> +	 * to allocate required region from and as the result we won't be able to
> +	 * construct pages.
> +	 */
> +	if (!target_resource)
> +		return alloc_xenballooned_pages(nr_pages, pages);

The commit message says that the behavior on x86 doesn't change but this
seems to be a change that could impact x86?


>  	mutex_lock(&list_lock);
>  	if (list_count < nr_pages) {
>  		ret = fill_list(nr_pages - list_count);
> @@ -159,6 +239,9 @@ void xen_free_unpopulated_pages(unsigned int nr_pages, struct page **pages)
>  {
>  	unsigned int i;
>  
> +	if (!target_resource)
> +		return free_xenballooned_pages(nr_pages, pages);
> +
>  	mutex_lock(&list_lock);
>  	for (i = 0; i < nr_pages; i++) {
>  		pages[i]->zone_device_data = page_list;
> diff --git a/include/xen/xen.h b/include/xen/xen.h
> index 43efba0..55d2ef8 100644
> --- a/include/xen/xen.h
> +++ b/include/xen/xen.h
> @@ -55,6 +55,8 @@ extern u64 xen_saved_max_mem_size;
>  #ifdef CONFIG_XEN_UNPOPULATED_ALLOC
>  int xen_alloc_unpopulated_pages(unsigned int nr_pages, struct page **pages);
>  void xen_free_unpopulated_pages(unsigned int nr_pages, struct page **pages);
> +struct resource;

This is to avoid having to #include linux/ioport.h, right? Is it a
problem or is it just to minimize the headers dependencies?

It looks like adding #include <linux/ioport.h> below #include
<linux/types.h> in include/xen/xen.h would work too. I am not sure what
is the best way though, I'll let Juergen comment.


> +int arch_xen_unpopulated_init(struct resource *res);
>  #else
>  #define xen_alloc_unpopulated_pages alloc_xenballooned_pages
>  #define xen_free_unpopulated_pages free_xenballooned_pages
> -- 
> 2.7.4
> 


From xen-devel-bounces@lists.xenproject.org Thu Oct 28 16:42:06 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Oct 2021 16:42:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.218187.378515 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg8TY-0004MS-DR; Thu, 28 Oct 2021 16:42:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 218187.378515; Thu, 28 Oct 2021 16:42:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg8TY-0004ML-AH; Thu, 28 Oct 2021 16:42:00 +0000
Received: by outflank-mailman (input) for mailman id 218187;
 Thu, 28 Oct 2021 16:41:59 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=TkaK=PQ=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1mg8TX-0004MF-EL
 for xen-devel@lists.xenproject.org; Thu, 28 Oct 2021 16:41:59 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id f78ae38e-380d-11ec-84ae-12813bfff9fa;
 Thu, 28 Oct 2021 16:41:58 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id 705AC610E7;
 Thu, 28 Oct 2021 16:41:57 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f78ae38e-380d-11ec-84ae-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1635439317;
	bh=MJB72v3YwZfiRZmTqXyqX0Zm+910bntZbuiMzEic1CM=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=AhmYwRypHDuhufEX3JS0tto+W8BQ3mtHy7IMMH8Pu9pHm9VatFp4FP//iXAhN2OgK
	 JXduuaM5R9Jk7t9bM3WPs8mEbuKBEh+r+X3QeQpU8Bh+sq2PTsqF+0VKkaCsZEH+F/
	 7uBEvZR88DZfaMZamiawEdKkZZBnlcorvYZgiiO+Syi1864lPvqxdr7oP9PyYotZsz
	 3DAPxV9noF8yxIgiLAHyrNPs16MlqSM9waPt6ZPRKAh4GXPtV4OLYMPX3rKJplLFSg
	 Ebid8Bz0qxYMS0zY7Mywgw8H9bwJZpbAzhkYCICFuN7ciTa6wM++PLiPDGrqocTi+J
	 QaTottGwOpUWg==
Date: Thu, 28 Oct 2021 09:41:56 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Juergen Gross <jgross@suse.com>
cc: Stefano Stabellini <sstabellini@kernel.org>, 
    Andrew Cooper <andrew.cooper3@citrix.com>, xen-devel@lists.xenproject.org, 
    iwj@xenproject.org, cardoe@cardoe.com, wl@xen.org, 
    anthony.perard@citrix.com, 
    Stefano Stabellini <stefano.stabellini@xilinx.com>
Subject: Re: [PATCH 2/3] automation: Linux 5.10.74 test-artifact
In-Reply-To: <4f82901a-2e74-f4ee-311e-b8187d856745@suse.com>
Message-ID: <alpine.DEB.2.21.2110280939130.20134@sstabellini-ThinkPad-T480s>
References: <alpine.DEB.2.21.2110210831470.2311@sstabellini-ThinkPad-T480s> <20211021230839.10794-2-sstabellini@kernel.org> <19aa9196-eb5f-22a1-206c-c9c87ee79fa9@citrix.com> <alpine.DEB.2.21.2110221219300.2311@sstabellini-ThinkPad-T480s>
 <d559b765-9e38-00bd-039b-9c33845b8e54@suse.com> <alpine.DEB.2.21.2110251753200.4586@sstabellini-ThinkPad-T480s> <8c0a2a97-04ab-4836-fc35-026dd7c122a4@suse.com> <alpine.DEB.2.21.2110271543150.20134@sstabellini-ThinkPad-T480s>
 <alpine.DEB.2.21.2110271619240.20134@sstabellini-ThinkPad-T480s> <4f82901a-2e74-f4ee-311e-b8187d856745@suse.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="8323329-983100371-1635439317=:20134"

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-983100371-1635439317=:20134
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT

On Thu, 28 Oct 2021, Juergen Gross wrote:
> On 28.10.21 01:24, Stefano Stabellini wrote:
> > On Wed, 27 Oct 2021, Stefano Stabellini wrote:
> > > On Wed, 27 Oct 2021, Juergen Gross wrote:
> > > > On 26.10.21 02:54, Stefano Stabellini wrote:
> > > > > On Mon, 25 Oct 2021, Juergen Gross wrote:
> > > > > > On 22.10.21 21:41, Stefano Stabellini wrote:
> > > > > > > +Juergen
> > > > > > > 
> > > > > > > On Fri, 22 Oct 2021, Andrew Cooper wrote:
> > > > > > > > On 22/10/2021 00:08, Stefano Stabellini wrote:
> > > > > > > > > +# build depends
> > > > > > > > > +RUN apt-get update && \
> > > > > > > > > +    apt-get --quiet --yes install \
> > > > > > > > > +        build-essential \
> > > > > > > > > +        libssl-dev \
> > > > > > > > > +        bc \
> > > > > > > > > +        curl \
> > > > > > > > > +        flex \
> > > > > > > > > +        bison \
> > > > > > > > > +        libelf-dev \
> > > > > > > > > +        && \
> > > > > > > > > +    \
> > > > > > > > > +    # Build the kernel
> > > > > > > > > +    curl -fsSLO
> > > > > > > > > https://cdn.kernel.org/pub/linux/kernel/v5.x/linux-"$LINUX_VERSION".tar.xz
> > > > > > > > > && \
> > > > > > > > > +    tar xvJf linux-"$LINUX_VERSION".tar.xz && \
> > > > > > > > > +    cd linux-"$LINUX_VERSION" && \
> > > > > > > > > +    make defconfig && \
> > > > > > > > > +    make xen.config && \
> > > > > > > > > +    cp .config .config.orig && \
> > > > > > > > > +    cat .config.orig | grep XEN | grep =m |sed 's/=m/=y/g' >>
> > > > > > > > > .config
> > > > > > > > > && \
> > > > > > > > > +    make -j$(nproc) bzImage && \
> > > > > > > > 
> > > > > > > > defconfig is huuuuge.  Can we use tinyconfig instead?
> > > > > > > > 
> > > > > > > > Also, you want to turn off CONFIG_MODULES seeing as you only
> > > > > > > > copy
> > > > > > > > bzImage to the test.
> > > > > > > > 
> > > > > > > > This also fixes the fact that `grep XEN` also matches
> > > > > > > > CONFIG_NETXEN_NIC
> > > > > > > > which has nothing to do with Xen.
> > > > > > > 
> > > > > > > Tinyconfig would be a good idea but it crashes on QEMU with the
> > > > > > > appended
> > > > > > > boot log. I did:
> > > > > > > 
> > > > > > > # make tinyconfig
> > > > > > > # make xen.config
> > > > > > > # make bzImage
> > > > > > > 
> > > > > > > Of course we could have our own tailored special kernel config for
> > > > > > > this
> > > > > > > kernel but I like the simplicify of "make tinyconfig" or "make
> > > > > > > defconfig" followed by "make xen.config".
> > > > > > > 
> > > > > > > Unless you know one kconfig option or two that we need to add to
> > > > > > > tinyconfig to make it work my preference is to go with defconfig
> > > > > > > for
> > > > > > > now.
> > > > > > 
> > > > > > You will need to add the dom0 and SMP related config options at
> > > > > > least.
> > > > > > 
> > > > > > I'll have a look at config.xen, which is a little bit weird: it
> > > > > > configures the backends, but not dom0.
> > > > > 
> > > > > Thanks, it would be good if make tinyconfig && make xen.config would
> > > > > just work on QEMU. In the meantime I'll keep defconfig for this test,
> > > > > we
> > > > > can always improve later.
> > > > 
> > > > Can you please test the attached patch?
> > > 
> > > Yes, that works, thanks!
> > 
> > Sorry, I spoke too soon: same error as before:
> > 
> > https://gitlab.com/xen-project/people/sstabellini/xen/-/jobs/1722909607/raw
> > 
> > (XEN) Hardware Dom0 crashed: rebooting machine in 5 seconds.
> > 
> > No output from the kernel.
> 
> This is not very surprising, as tinyconfig doesn't have CONFIG_PRINTK.
> BTW, it doesn't have initrd support either (BLK_DEV_RAM and
> BLK_DEV_INITRD), so I added those to xen.config as well.
> 
> With the (updated) attached patch the kernel boots fine as dom0 until
> rootfs is tried to be mounted on a physical machine.
> 
> I've added CONFIG_BUG, too, in order to have more debugging output if
> needed.

Much better, now there is output:
https://gitlab.com/xen-project/people/sstabellini/xen/-/jobs/1726396600/raw

This kernel is used as dom0 and from the logs it looks like for dom0 we
need a couple more things:
- flocks
- the kconfig to recognize #!/bin/sh
--8323329-983100371-1635439317=:20134--


From xen-devel-bounces@lists.xenproject.org Thu Oct 28 16:50:33 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Oct 2021 16:50:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.218196.378526 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg8bk-0005yt-ER; Thu, 28 Oct 2021 16:50:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 218196.378526; Thu, 28 Oct 2021 16:50:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg8bk-0005ym-Af; Thu, 28 Oct 2021 16:50:28 +0000
Received: by outflank-mailman (input) for mailman id 218196;
 Thu, 28 Oct 2021 16:50:26 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=TkaK=PQ=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1mg8bi-0005yg-TA
 for xen-devel@lists.xenproject.org; Thu, 28 Oct 2021 16:50:26 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 25df5a0c-380f-11ec-84ae-12813bfff9fa;
 Thu, 28 Oct 2021 16:50:25 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id B2ADE61073;
 Thu, 28 Oct 2021 16:50:24 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 25df5a0c-380f-11ec-84ae-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1635439825;
	bh=zatCatZprUl/+qGSal03LHrneW7AeXcu4SleAI2SVPI=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=EhgoNUaa8j+TNJc99dc+K5pg+l/+ynk8bl88Hnwv87BULKgiVlazyZwMMhCBC7sDh
	 4MFsphySenmGvWN/Fyb3bMVAzbJ2hHZD3tgCIwcrVGGdDXtcFkqDqbqgNNtUiC27m7
	 hD4J3MTAlsEK5zE78vAmz/f/9DEHt86ZymUVXPYv5ewgcrFNfqGNfhEf9+bqnqrODC
	 7wq5gCj5BQ3VjwOxkiTrD0VtWblXr03nme+HODWUGHBceoKeTamlD5M2sGSKHJyeEc
	 W7OK3neKaHJl8FIDh6DQF2NuIae0uNs1kUvrDI1vBJwukRsuEzMEMjK0h12lFsmDXr
	 jSZFdFMR0oXEQ==
Date: Thu, 28 Oct 2021 09:50:24 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Julien Grall <julien@xen.org>
cc: Stefano Stabellini <sstabellini@kernel.org>, 
    Oleksandr Andrushchenko <andr2000@gmail.com>, 
    xen-devel@lists.xenproject.org, iwj@xenproject.org, 
    bertrand.marquis@arm.com, rahul.singh@arm.com, 
    Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Subject: Re: [PATCH] xen/arm: do not try to add pci-domain for disabled
 devices
In-Reply-To: <c3602294-0ab4-10df-77cc-2a9e13ddc73f@xen.org>
Message-ID: <alpine.DEB.2.21.2110280948190.20134@sstabellini-ThinkPad-T480s>
References: <20211027083730.1406947-1-andr2000@gmail.com> <7a97bbef-68a9-8f52-0c93-88d4e84a07fc@xen.org> <alpine.DEB.2.21.2110271649240.20134@sstabellini-ThinkPad-T480s> <c3602294-0ab4-10df-77cc-2a9e13ddc73f@xen.org>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Thu, 28 Oct 2021, Julien Grall wrote:
> Hi Stefano,
> 
> On 28/10/2021 00:57, Stefano Stabellini wrote:
> > On Wed, 27 Oct 2021, Julien Grall wrote:
> > > Hi Oleksandr,
> > > 
> > > On 27/10/2021 09:37, Oleksandr Andrushchenko wrote:
> > > > From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> > > > 
> > > > If a PCI host bridge device is present in the device tree, but is
> > > > disabled, then its PCI host bridge driver was not instantiated.
> > > > This results in the following panic during Xen start:
> > > > 
> > > > (XEN) Device tree generation failed (-22).
> > > 
> > > It would good to clarify in the commit message where the error is coming
> > > from.
> > > I think this is from pci_get_host_bridge_segment().
> > > 
> > > > (XEN)
> > > > (XEN) ****************************************
> > > > (XEN) Panic on CPU 0:
> > > > (XEN) Could not set up DOM0 guest OS
> > > > (XEN) ****************************************
> > > > 
> > > > Fix this by not adding linux,pci-domain property for hwdom if it is
> > > > neither available nor device enabled.
> > >  From my reading of the binding [1], the property should be present in all
> > > the
> > > hostbridges if one specify it. IOW, I think the property should also be
> > > added
> > > for hostbridges that are not available.
> > 
> > Just wanted to say that I think you are right:
> > 
> > """
> > It is required to either not set this property at all or set it for all
> > host bridges in the system, otherwise potentially conflicting domain numbers
> > may be assigned to root buses behind different host bridges.  The domain
> > number for each host bridge in the system must be unique.
> > """
> > 
> > and I am ready to believe device trees with disabled bridges might have
> > (incorrectly) ignored the rule.
> 
> Looking at linux/arch/arm64/boot/dts/, there are a few Device-Tree that
> contain the property "linux,pci-domain". All of them seems to also add it for
> disabled hostbridges.
> 
> However, I am under the impression that it is more common to have a
> Devide-Tree without any property "linux,pci-domain". When PCI support is
> enabled, Xen will generate the domain ID for the hostbridge and write it to
> the DT.
> 
> This doesn't work for disabled hostbridge and I think this is Oleksandr's
> problem. @Oleksandr can you confirm it?
> 
> > 
> > 
> > > AFAICT, Linux will ignore hostbridge that are not available. But it feels
> > > to
> > > me we are twisting the rule. So, could we consider to allocate an unused
> > > number?
> > 
> > I think that would be fine but it doesn't look easy from the current Xen
> > code point of view because the allocation depends on the Xen driver,
> > which we don't have. But I'll let others comment on it.
> So what matters is Xen doesn't make things worse. We have two cases to care:
>   1) Xen only has drivers for a part of the hostbriges
>   2) Some hostbriges are disabled
> 
> Case 1) will definitely generate a DT that will make Linux unhappy if we have
> don't add the property consistently.

Good point!


From xen-devel-bounces@lists.xenproject.org Thu Oct 28 17:56:16 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Oct 2021 17:56:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.218204.378537 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg9cn-0003wJ-AI; Thu, 28 Oct 2021 17:55:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 218204.378537; Thu, 28 Oct 2021 17:55:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg9cn-0003wC-6l; Thu, 28 Oct 2021 17:55:37 +0000
Received: by outflank-mailman (input) for mailman id 218204;
 Thu, 28 Oct 2021 17:55:35 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ikAZ=PQ=epam.com=prvs=19352d112c=oleksandr_andrushchenko@srs-us1.protection.inumbo.net>)
 id 1mg9cl-0003w4-GZ
 for xen-devel@lists.xenproject.org; Thu, 28 Oct 2021 17:55:35 +0000
Received: from mx0a-0039f301.pphosted.com (unknown [148.163.133.242])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 3e9d917c-3818-11ec-84b0-12813bfff9fa;
 Thu, 28 Oct 2021 17:55:32 +0000 (UTC)
Received: from pps.filterd (m0174678.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 19SHdHOR009750; 
 Thu, 28 Oct 2021 17:55:30 GMT
Received: from eur04-he1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2056.outbound.protection.outlook.com [104.47.13.56])
 by mx0a-0039f301.pphosted.com with ESMTP id 3c00es81mt-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Thu, 28 Oct 2021 17:55:30 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by AM0PR03MB3715.eurprd03.prod.outlook.com (2603:10a6:208:43::31)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.15; Thu, 28 Oct
 2021 17:55:26 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::c038:e032:595a:651]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::c038:e032:595a:651%9]) with mapi id 15.20.4649.015; Thu, 28 Oct 2021
 17:55:25 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3e9d917c-3818-11ec-84b0-12813bfff9fa
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=l24mchNO/rCxlxISTX4S8LrCUxuDqvJ8PLpDxgDQNgprGlshMFzwrOEfvW1fpnlBtVQAoJzwe/LBXDYkM9jLHfjAyGfrEOgesmiJN8/JJbvOVWbMKikXnVfnl97M1XG/EqgppBmsLoikvIrO2h+LKAwDP4dHfJL+OEGI3O63b4qKUI+/soTAz2zctOgaIX7GtyjXHx+6vs2cMEXMLvSq5r7de6owZm0MrpHa5tuaqciMFii0Wm6ub2O8FoOUhTW8ExgquLLrSwsVAnSQ82d2QJXUlnWrFTdRsMPnvzLsORrgcXZQPXYYkGyLhYhZvvpST/odGFHcZ38/jUU+Umo6+A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=J0ujsxokvVj+8ncAPfxdMDr1N5LTYotS9baQqxpxCvE=;
 b=Nu00GvkhPhjKEUvFgE1+DvuTvtaxjo8aj9NV8YHr8ntENWI4MASUgJC9pOOxRcg0gBx/TOwat0zQIE9GhiuYd1qMenoqsMH75KHktiIC6Z2gDg2g7dAvq0ahljbd3wtH/DrEGp6tRafnAZa4iwGi46lkv5wvvosPAHm/Doglx9lLe+d13y1DVPz9hetJADO8OzpdHw8McbgyD3KpsLpmtqiMVTyulhOVnZ8dy0slqBSx/51LOX6zjjPnZ7fTXhKlx4REEwewtKeQviv/8xQV5o4t8cd9roxR0d68ePAAcE2/lsZFByeWuOut+P+q5jzg94DJr1JRXtD3xMhPyfEBOA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=J0ujsxokvVj+8ncAPfxdMDr1N5LTYotS9baQqxpxCvE=;
 b=LFK1yOnxb1MV6CPVKc46oLw0murPHBhmLa0D9s+cSS4ubY3sFMujE0j+Atrk0UoFeN6ws1JOUDRR91rzC/4pAciPn8FRRYaoLftkqOwOPlYTKczG03sJFzwK2Ji/bwUkzfOM8QsrCnPRIKOm1NgLgwUG8ddfkfsSsumzG1Sz0inqJWIIemdLraV7GAORgDzrLcu7FmUn8tPsuSIE+Z/6raTZGIBFTNG5pyIXj2mlVL367HVoyWP6I2xO9YSpe76iE3+YJakvFZ8z9CsWf5HibVt+1s+h6EXIU2ZAiC6KFcSIRc/hCMIZr2sW4382tzlvIZjqDkly84AoZ8zT9X5cYw==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>,
        Julien Grall
	<julien@xen.org>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        "sstabellini@kernel.org" <sstabellini@kernel.org>,
        Rahul Singh
	<rahul.singh@arm.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH] xen/arm: fix SBDF calculation for vPCI MMIO handlers
Thread-Topic: [PATCH] xen/arm: fix SBDF calculation for vPCI MMIO handlers
Thread-Index: 
 AQHXyww6rKHs3LJru0q52eLUia+oNavnHBIAgAE3H4CAABhAgIAADTsAgAAb4gCAAB9PgA==
Date: Thu, 28 Oct 2021 17:55:25 +0000
Message-ID: <5de6c2f1-ef5c-9d8c-4287-9b0e3ff08b34@epam.com>
References: <20211027082533.1406015-1-andr2000@gmail.com>
 <cb7e9ef7-476e-93c3-d3c9-9a9ebc61003d@xen.org>
 <d63c6e0b-8aa3-9ba3-893c-5e464638a8db@epam.com>
 <YXqnS7iZUvokJby6@Air-de-Roger>
 <3206478e-f230-cd91-5de9-85ef6c251405@epam.com>
 <YXrJyLMiMxaNmFAs@Air-de-Roger>
In-Reply-To: <YXrJyLMiMxaNmFAs@Air-de-Roger>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 52151adb-9256-420a-e8f2-08d99a3c1f15
x-ms-traffictypediagnostic: AM0PR03MB3715:
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <AM0PR03MB371546967EED5FCFCF09EB86E7869@AM0PR03MB3715.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 XfjHP71i8jxeOZQA5lQ7l5CDj1T+DZ8QG7s5NSC3cyfdvIM/52UDoquc1ztcVo0wkjX0qaFFRISLvuOxR/v4wCSXJfKGmyh96kgry4hGznDL9OfCaBLdQGIAKMY1MTSFGPYVlCTUDuTufcCP9R/U/44I2PmSvmPnw3t4Q4ttr3b6Q3LNo1fKPNdfOpMnRfLToAurKlwby6Nv6PUwwL4tHWrqUFU2HROacDQRvvdI2oIKh6khl0tK+IgphtWRis9wR8SsedyPeI687sAzKRZEAiYH3GOaqv+8xI1cSlORP6aNh0m4FIFreeOPtMli0yybZ9hzSkrjSNHJg8LBSLBC4SOK6a8qsXdc7wyJKRN5o9MpMHRmvxbiBmMyeAYfGxdAtcHO+c2uR5PvlO/Q8SmXF7vo6jZAaOkRfCvBQsKDwMOuDJ+73357O/bXAzmH4O66rbcBVpGzLwCV+9gsG2h2zPApSJmJiGWcCdc2/ehVaVgXySih2Ucf/f+f1y48ssEsEQShcxjNWmMXj4cMXrphqLoLHBy3bl0gvxXUrIzo6zo9NV61Etw8d8FQArGfpH7ACUZWvjs+mDhpC0RkTopCSmvfi1mE37H8stAy0JWp8CCXCNyEICD+9mOHReG3YhN96FzN05/qQfGvxg+I0688Azl14ItKzS5gQjMb2EWKosSq89Pwb85JsaU3dGZWdpxfPONd2KsokG0PjudiPjizdpb/jJqABcMsXw/DCpE1rtT7YBKykIi3uoRiuUcxezHLK8k33dNcb9G+BxfIWtpXZSvVFGKRafym4gnyEkf2PxJ7spsVs2t2BDgPwJiUw/O/lsbBjMpl8myot2aPaAqTBw==
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(8936002)(31686004)(186003)(2616005)(508600001)(110136005)(36756003)(26005)(31696002)(83380400001)(6486002)(53546011)(6512007)(316002)(8676002)(86362001)(91956017)(71200400001)(76116006)(66946007)(66476007)(66446008)(38100700002)(6506007)(64756008)(122000001)(966005)(2906002)(5660300002)(66556008)(4326008)(38070700005)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?WkRuNk5XWURySkhod0lEazdhbG9rQlJ2NmxPM2Q2anQ0OWF2REhuMDBUbXI5?=
 =?utf-8?B?SjJMbG02L2RmdnRiT2pkVm5NTGw4emRrKy9aazN3YlFZR1ZsRjRLY1N2Z1Bu?=
 =?utf-8?B?T1ZSa2xBS2tUbjFWSzdNaVNhUVJlWjVGU2hHYXJvOWFHV3hVT0o3czZjOFVu?=
 =?utf-8?B?QnYyUjl1a3hoZHY0T3dnNVNCNVV6SGJMVklCcjdubS83SGs0NU5lVjgzV3N5?=
 =?utf-8?B?dm5uci9tM2g2aFdhRXdiSzEvZ3Ztak1LZmk3dDF1b25YK05UVVRvMTBGOCsr?=
 =?utf-8?B?L3NKb1FydllsQkJ5a0k2ejNyWVNSWUhzYzcrNkRnb1MyNUJBV1NnQUdnanJ2?=
 =?utf-8?B?cEYwcEZFWTB1QW0ycGRRWTA1T2ZVVEhBUnBaYzJLY1ZsdGN3QWtHVmV2MmUz?=
 =?utf-8?B?d2YrbWpKVUo5RFp6Q0htVWJ4N3MyQWRucXlleWZIZGhQNnpwTSs5OGgveVB6?=
 =?utf-8?B?T2lGdVM1WGFRY3gzcjlvVTFVaDZpcEQ5RkJYcXZPOUFTK00wYXUwd2hwMHRM?=
 =?utf-8?B?Y2g4UnNHQjdsaGZrYUlIWmFmcVFGU2VFWXAzeVN0eVVickhuNWoxYkVBWnVI?=
 =?utf-8?B?VXc1dmpJK2ZkZm9ySSswcnEyQUV4Y2tlRTY3UmkyT2E3WTJIL0VTRnRkYjBS?=
 =?utf-8?B?RDM5SWpYeXl5UzliYUE2SGNiTnA3QTNKelVScFRTYXRtQ2xQSENBTEdlR0lU?=
 =?utf-8?B?OFZmNk5RK2FVVU1zSytFODNmL3FFSlJyUTIvSUY3U3Z3ZGxVQ3VKdjNPMjVZ?=
 =?utf-8?B?Z01TMmtlVzZuclljNWFxUUN0aVg0aFdtazlqZURrbU1HcDNlTWZhL3U1WHpw?=
 =?utf-8?B?cjR3aU1Sc0pBei9VdlU3VHFTcE1VWkVmNVU1TE9YbXROSFdkS1dLK2xZSDU5?=
 =?utf-8?B?dzlTSis5V0ZWbWE3ZytvV3poWWRML0ZaakZxeXpNZVFZc25VTlgyOEpDOWVu?=
 =?utf-8?B?Y1lzeDliL0lXTjNyOUI0dDhyc3h1MWE0YnI1akg4MnRCeG1tbGVicjlLdUhE?=
 =?utf-8?B?aGNDZjY0K0U4TC9YV3RoOHdXbTExNGNtOUlLM2c2VEgrQzc5MXUxcjA4dW9z?=
 =?utf-8?B?bVJKczk1VHFjTHJXQWNEQjl2UlRYMW9DWWs0MnRSSTNwcXdKZ3ZCYlQrNWxt?=
 =?utf-8?B?QjZUNWhWSVEzWU1yekZvNHVzeldWUDRQQnVuVWdJVmhOdFhMUkFqOHovVUxz?=
 =?utf-8?B?UWJ0UlJ4MWQ5bXZrZlA1Sm9NbDdOM0k2M3hVWW43dnlVa0RST1FVdVlEZERO?=
 =?utf-8?B?b0tPM1ZtNVZTTENJaDJ1QmE0R05lblpDdjFUWHREU1FHdHo0K0I2dnJDcmIw?=
 =?utf-8?B?UDByMng0dE8vTjdYRHVkQTF1TkoyeEFzVTR4WFpPUGs4NWxMY2VCSUIySGN1?=
 =?utf-8?B?c1pRd2ZKQlBhYllOR1M5SThSY3NpU1RtWWtvaXhpci9VY3hMT1JJY3hlYmlV?=
 =?utf-8?B?YzZRMmdFSHVQWWg5eUR3Z2dIVHpyWlU1U09QYzJ6dzgyazB2T2dxVUpVOHJl?=
 =?utf-8?B?SkZKNm5jakdzeVR6Nk5JUXdBd0kvREtCK2ZWYXp6NWhOQ1ZnTmZwck5sTVpV?=
 =?utf-8?B?UmlRNHdSRS9VcExxVG1vWUNRWXg1WU81Qlh1UElrazlyNEZPNTBwKzdKOENr?=
 =?utf-8?B?WjRZVVBoN2FxV3l2OGdNdnp4YnlZSGN3SVovY3MvbUlsbUUzdEoyRC9uWlVK?=
 =?utf-8?B?WlI4U25LQXNaMUM4ZXN6VzdPazRmWmp3R0w1MXNPRzNwU1pYR21zSFF1N0Zt?=
 =?utf-8?B?TXNXekRHR3JUQkRqNHRMYTU4dzBFZlFUUzdlZm00WXIydUFpRkd4T2ZHdnJF?=
 =?utf-8?B?QXQ0RXBZT25MOWh0OEtRWFArYWg5MWFsOVZBSW0vMWhPc3ZIQ0VmeVA2TXMw?=
 =?utf-8?B?MUtlbkJ4WGp3SERZckJMOWVOWURtTENYTGhuWTlMVUdIRmdLU1E5RmF3S2x3?=
 =?utf-8?B?c0NEZmh6RmV2TjdGdnM5Rk5INWJyMmN1NldVa0k5RUVoaDdSUU9GVG5pb0J5?=
 =?utf-8?B?eCt6V2k3ZWtCRHNlR0pEYWN5NU90ZHQyVmJGWnVGbTc1bFZDaVFzWVRJVE1n?=
 =?utf-8?B?UzR0cnlxd0d3V1lFdTBLZkEybUtHbnV1VkxnZmE2RjZTNVRvaE05TUFieXlT?=
 =?utf-8?B?V1NFV3R0S1hlT3ZRL1VjdUtQM3JZSGhBVlBDT242V0w4TldBWTl2Q080eFFo?=
 =?utf-8?B?TktMZE1qdjFTeVoxMThHdHRkTW5tRVJBYXBYWEY0V1hHRFVBeG4yZXlYV3BT?=
 =?utf-8?B?czlSeE5OMWlPZ1JvVVo5QkJLYTllekp0MkN0YkdjTjM5Q2VwcTZrVDNVL2cy?=
 =?utf-8?B?OXN4bERGdXZ6LzkrcUFSemRia3ZLb0NQSHdNVEpnYVJiZXRneElDZz09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <A76019E8A61E0A4384FCDA567DE0E176@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 52151adb-9256-420a-e8f2-08d99a3c1f15
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Oct 2021 17:55:25.8476
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: YUgS7il3JbMhzje7h4QmehKU4OYNKLHZ2PZalAoQEAntB6Be8lIKMxtKZz6HcTKwa9A66gE7cvlCm8mMP5zFzhIVtCNaZ7uY5wvKjRa9DZ0AWbbm3ONqJqvygDOUyE9m
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR03MB3715
X-Proofpoint-ORIG-GUID: RC8oijkBaOp2wgYnEkabsknMOqUg7kaC
X-Proofpoint-GUID: RC8oijkBaOp2wgYnEkabsknMOqUg7kaC
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475
 definitions=2021-10-28_04,2021-10-26_01,2020-04-07_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 bulkscore=0
 spamscore=0 suspectscore=0 impostorscore=0 clxscore=1015 mlxscore=0
 phishscore=0 priorityscore=1501 lowpriorityscore=0 mlxlogscore=999
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2110280095

DQoNCk9uIDI4LjEwLjIxIDE5OjAzLCBSb2dlciBQYXUgTW9ubsOpIHdyb3RlOg0KPiBPbiBUaHUs
IE9jdCAyOCwgMjAyMSBhdCAwMjoyMzozNFBNICswMDAwLCBPbGVrc2FuZHIgQW5kcnVzaGNoZW5r
byB3cm90ZToNCj4+DQo+PiBPbiAyOC4xMC4yMSAxNjozNiwgUm9nZXIgUGF1IE1vbm7DqSB3cm90
ZToNCj4+PiBPbiBUaHUsIE9jdCAyOCwgMjAyMSBhdCAxMjowOToyM1BNICswMDAwLCBPbGVrc2Fu
ZHIgQW5kcnVzaGNoZW5rbyB3cm90ZToNCj4+Pj4gSGksIEp1bGllbiENCj4+Pj4NCj4+Pj4gT24g
MjcuMTAuMjEgMjA6MzUsIEp1bGllbiBHcmFsbCB3cm90ZToNCj4+Pj4+IEhpIE9sZWtzYW5kciwN
Cj4+Pj4+DQo+Pj4+PiBPbiAyNy8xMC8yMDIxIDA5OjI1LCBPbGVrc2FuZHIgQW5kcnVzaGNoZW5r
byB3cm90ZToNCj4+Pj4+PiBGcm9tOiBPbGVrc2FuZHIgQW5kcnVzaGNoZW5rbyA8b2xla3NhbmRy
X2FuZHJ1c2hjaGVua29AZXBhbS5jb20+DQo+Pj4+Pj4NCj4+Pj4+PiBXaGlsZSBpbiB2UENJIE1N
SU8gdHJhcCBoYW5kbGVycyBmb3IgdGhlIGd1ZXN0IFBDSSBob3N0IGJyaWRnZSBpdCBpcyBub3QN
Cj4+Pj4+PiBlbm91Z2ggZm9yIFNCREYgdHJhbnNsYXRpb24gdG8gc2ltcGx5IGNhbGwgVlBDSV9F
Q0FNX0JERihpbmZvLT5ncGEpIGFzDQo+Pj4+Pj4gdGhlIGJhc2UgYWRkcmVzcyBtYXkgbm90IGJl
IGFsaWduZWQgaW4gdGhlIHdheSB0aGF0IHRoZSB0cmFuc2xhdGlvbg0KPj4+Pj4+IGFsd2F5cyB3
b3JrLiBJZiBub3QgYWRqdXN0ZWQgd2l0aCByZXNwZWN0IHRvIHRoZSBiYXNlIGFkZHJlc3MgaXQg
bWF5IG5vdCBiZQ0KPj4+Pj4+IGFibGUgdG8gcHJvcGVybHkgY29udmVydCBTQkRGIGFuZCBjcmFz
aGVzOg0KPj4+Pj4+DQo+Pj4+Pj4gKFhFTikgdnBjaV9tbWlvX3JlYWQgMDAwMDo2NToxYS4wIHJl
ZyA4YmMgZ3BhIGU2NWQwOGJjDQo+Pj4+PiBJIGNhbid0IGZpbmQgYSBwcmludGsoKSB0aGF0IG1h
eSBvdXRwdXQgdGhpcyBtZXNzYWdlLiBXaGVyZSBkb2VzIHRoaXMgY29tZXMgZnJvbT8NCj4+Pj4g
VGhhdCB3YXMgYSBkZWJ1ZyBwcmludC4gSSBzaG91bGRuJ3QgaGF2ZSB1c2VkIHRoYXQgaW4gdGhl
IHBhdGNoIGRlc2NyaXB0aW9uLCBidXQNCj4+Pj4gcHJvYmFibHkgYWZ0ZXIgIi0tLSIgdG8gYmV0
dGVyIGV4cGxhaW4gd2hhdCdzIGhhcHBlbmluZw0KPj4+Pj4gQW55d2F5LCBJSVVDIHRoZSBndWVz
dCBwaHlzaWNhbCBhZGRyZXNzIGlzIDB4ZTY1ZDA4YmMgd2hpY2gsIGlmIEkgYW0gbm90IG1pc3Rh
a2VuLCBkb2Vzbid0IGJlbG9uZyB0byB0aGUgcmFuZ2UgYWR2ZXJ0aXNlZCBmb3IgR1VFU1RfVlBD
SV9FQ0FNLg0KPj4+PiBUaGlzIGlzIGZyb20gZG9tMCBJIGFtIHdvcmtpbmcgb24gbm93Lg0KPj4+
Pj4gSU1ITywgdGhlIHN0YWNrIHRyYWNlIHNob3VsZCBjb21lIGZyb20gdXNwdHJlYW0gWGVuIG9y
IG5lZWQgc29tZSBpbmZvcm1hdGlvbiB0byBleHBsYWluIGhvdyB0aGlzIHdhcyByZXByb2R1Y2Vk
Lg0KPj4+Pj4NCj4+Pj4+PiAoWEVOKSBEYXRhIEFib3J0IFRyYXAuIFN5bmRyb21lPTB4Ng0KPj4+
Pj4+IChYRU4pIFdhbGtpbmcgSHlwZXJ2aXNvciBWQSAweDQ2N2EyOGJjIG9uIENQVTAgdmlhIFRU
QlIgMHgwMDAwMDAwMDQ4MWQ1MDAwDQo+Pj4+PiBJIGNhbiB1bmRlcnN0bmFkIHRoYXQgaWYgd2Ug
ZG9uJ3Qgc3Vic3RyYWN0IEdVRVNUX1ZQQ0lfRUNBTSwgd2Ugd291bGQgKGluIHRoZW9yeSkgbm90
IGdldCB0aGUgY29ycmVjdCBCREYuIEJ1dC4uLiBJIGRvbid0IHVuZGVyc3RhbmQgaG93IHRoaXMg
d291bGQgcmVzdWx0IHRvIGEgZGF0YSBhYm9ydCBpbiB0aGUgaHlwZXJ2aXNvci4NCj4+Pj4+DQo+
Pj4+PiBJbiBmYWN0LCBJIHRoaW5rIHRoZSB2UENJIGNvZGUgc2hvdWxkIGJlIHJlc2lsaWVudCBl
bm91Z2ggdG8gbm90IGNyYXNoIGlmIHdlIHBhc3MgdGhlIHdyb25nIEJERi4NCj4+Pj4gV2VsbCwg
dGhlcmUgaXMgbm8gKD8pIGVhc3kgd2F5IHRvIHZhbGlkYXRlIFNCREYuIEFuZCB0aGlzIGNvdWxk
IGJlIGEgcHJvYmxlbSBpZiB3ZSBoYXZlIGEgbWlzYmVoYXZpbmcNCj4+Pj4gZ3Vlc3Qgd2hpY2gg
bWF5IGZvcmNlIFhlbiB0byBhY2Nlc3MgdGhlIG1lbW9yeSBiZXlvbmQgdGhhdCBvZiBQQ0kgaG9z
dCBicmlkZ2UNCj4+PiBIb3cgY291bGQgdGhhdCBiZT8gVGhlIEVDQU0gcmVnaW9uIGV4cG9zZWQg
dG8gdGhlIGd1ZXN0IHlvdSBzaG91bGQgYmUNCj4+PiB0aGUgc2FtZSBhcyB0aGUgcGh5c2ljYWwg
b25lIGZvciBkb20wPw0KPj4gT2ssIEkgaGF2ZSBhIERlc2lnbndhcmUgUENJIGhpc3Qgd2hpY2gg
aGFzIDIgRUNBTSByZWdpb25zIChJIGFtIHN0YXJ0aW5nIHRvDQo+PiBpbXBsZW1lbnQgdGhlIGRy
aXZlciBmb3IgaXQsIHNvIEkgY2FuIGJlIHdyb25nIGhlcmUpOg0KPj4gLSBSb290IENvbXBsZXgg
RUNBTSBhcmVhICgiZGJpIiksIGl0IGlzIHNvbWV0aGluZyBsaWtlIDB4MzAwMCBieXRlcyBsb25n
DQo+PiAtICJDbGllbnQiIEVDQU0gYXJlYSAoImNvbmZpZyIpDQo+PiBTbyBmcm9tIERvbTAgUE9W
IHdlIGhhdmUgMiBFQ0FNIHJlZ2lvbnMgYW5kIGZvciB0aGUgZ3Vlc3QNCj4+IHdlIGFsd2F5cyBl
bXVsYXRlIGEgc2luZ2xlIGJpZyByZWdpb246DQo+IFlvdSBuZWVkIHN1cHBvcnQgZm9yIG11bHRp
cGxlIEVDQU0gcmVnaW9ucy4gVGhhdCdzIGhvdyB3ZSBkbyBpdCBvbiB4ODYNCj4gUFZIIGRvbTAu
IFNlZSByZWdpc3Rlcl92cGNpX21tY2ZnX2hhbmRsZXIgYW5kIHJlbGF0ZWQgbWFjaGluZXJ5Lg0K
SXMgaXQgY29tbW9uIGZvciBhIFBDSSBob3N0IGJyaWRnZSB0byBoYXZlIG11bHRpcGxlIEVDQU0g
cmVnaW9ucz8NCkN1cnJlbnRseSBvbiBBcm0gd2Ugd2VyZSBhYm91dCB0byBzdXBwb3J0ICJwY2kt
aG9zdC1lY2FtLWdlbmVyaWMiIFsxXSwNCmUuZy4gZ2VuZXJpYyBFQ0FNIGhvc3QgYnJpZGdlIHdo
aWNoIG5vcm1hbGx5ICg/KSBoYXMgYSBzaW5nbGUgRUNBTQ0KcmVnaW9uIFsyXS4gQnV0IHRoZSBo
b3N0IGJyaWRnZSBJIHdhbnQgdG8gc3VwcG9ydCBoYXMgbXVsdGlwbGUsIHNvDQpzdHJpY3RseSBz
cGVha2luZyBpdCBpcyBub3QgdGhlIG9uZSB0aGF0IHdlIGltcGxlbWVudC4NCg0KQXJtIGZvbGtz
LCBkbyB3ZSB3YW50IHRoaXMgZ2VuZXJhbGl6YXRpb24gYXQgdGhpcyBtb21lbnQgdG8gYWxpZ24g
d2l0aCB4ODYNCndpdGggdGhpcyByZXNwZWN0Pw0KDQpXZSBjYW4gbGl2ZSB3aXRoIHRoZSBjdXJy
ZW50IGFwcHJvYWNoIGFuZCB3aGVuIEkgaGF2ZSBteSBkcml2ZXIgaW1wbGVtZW50ZWQNCkkgY2Fu
IHNlbmQgcGF0Y2hlcyB0byBtYWtlIHRoYXQgZ2VuZXJhbGl6YXRpb24uDQo+DQo+PiAvKg0KPj4g
ICDCoCogMjU2IE1CIGlzIHJlc2VydmVkIGZvciBWUENJIGNvbmZpZ3VyYXRpb24gc3BhY2UgYmFz
ZWQgb24gY2FsY3VsYXRpb24NCj4+ICAgwqAqIDI1NiBidXNlcyB4IDMyIGRldmljZXMgeCA4IGZ1
bmN0aW9ucyB4IDQgS0IgPSAyNTYgTUINCj4+ICAgwqAqLw0KPj4gI2RlZmluZSBHVUVTVF9WUENJ
X0VDQU1fQkFTRcKgwqDCoCB4ZW5fbWtfdWxsb25nKDB4MTAwMDAwMDApDQo+PiAjZGVmaW5lIEdV
RVNUX1ZQQ0lfRUNBTV9TSVpFwqDCoMKgIHhlbl9ta191bGxvbmcoMHgxMDAwMDAwMCkNCj4+DQo+
PiBTbywgd2UgaGF2ZSB0aGUgYmFzZSBhZGRyZXNzIGFuZCBzaXplIG9mIHRoZSBlbXVsYXRlZCBF
Q0FNIHNwYWNlDQo+PiBub3QgY29ubmVjdGVkIHRvIHRoZSByZWFsIGhvc3QgYnJpZGdlDQo+Pj4g
QW5kIGZvciBkb21VcyB5b3UgcmVhbGx5IG5lZWQgdG8gZml4IHZwY2lfe3JlYWQsd3JpdGV9IHRv
IG5vdA0KPj4+IHBhc3N0aHJvdWdoIGFjY2Vzc2VzIG5vdCBleHBsaWNpdGx5IGhhbmRsZWQuDQo+
PiBEbyB5b3UgbWVhbiB0aGF0IHdlIG5lZWQgdG8gdmFsaWRhdGUgU0JERnMgdGhlcmU/DQo+PiBU
aGlzIGNhbiBiZSB0cmlja3kgaWYgd2UgaGF2ZSBhIHVzZS1jYXNlIHdoZW4gYSBQQ0kgZGV2aWNl
IGJlaW5nDQo+PiBwYXNzZWQgdGhyb3VnaCBpZiBub3QgcHV0IGF0IDAwMDA6MDA6MC4wLCBidXQg
cmVxdWVzdGVkIHRvIGJlLCBmb3INCj4+IGV4YW1wbGUsIDAwMDA6MGQ6MC4wLiBTbywgd2UgbmVl
ZCB0byBnbyBvdmVyIHRoZSBsaXN0IG9mIHZpcnR1YWwNCj4+IGRldmljZXMgYW5kIHNlZSBpZiBT
QkRGIHRoZSBndWVzdCBpcyB0cnlpbmcgdG8gYWNjZXNzIGlzIGEgdmFsaWQgU0JERi4NCj4+IElz
IHRoaXMgd2hhdCB5b3UgbWVhbj8NCj4gTm8sIHlvdSBuZWVkIHRvIHByZXZlbnQgYWNjZXNzZXMg
dG8gcmVnaXN0ZXJzIG5vdCBleHBsaWNpdGx5IGhhbmRsZWQNCj4gYnkgdnBjaS4gSWU6IGRvIG5v
dCBmb3J3YXJkIHVuaGFuZGxlZCBhY2Nlc3NlcyB0bw0KPiB2cGNpX3tyZWFkLHdyaWV9X2h3KS4N
Ckkgc2VlLCBzbyB0aG9zZSB3aGljaCBoYXZlIG5vIGhhbmRsZXJzIGFyZSBub3QgcGFzc2VkIHRv
IHRoZSBoYXJkd2FyZS4NCkkgbmVlZCB0byBzZWUgaG93IHRvIGRvIHRoYXQNCj4NCj4gUmVnYXJk
cywgUm9nZXIuDQpUaGFuayB5b3UsDQpPbGVrc2FuZHINCg0KWzFdIGh0dHBzOi8vZWxpeGlyLmJv
b3RsaW4uY29tL2xpbnV4L3Y1LjE1LXJjNy9zb3VyY2UvZHJpdmVycy9wY2kvY29udHJvbGxlci9w
Y2ktaG9zdC1nZW5lcmljLmMNClsyXSBodHRwczovL2VsaXhpci5ib290bGluLmNvbS9saW51eC92
NS4xNS1yYzcvc291cmNlL2RyaXZlcnMvcGNpL2NvbnRyb2xsZXIvcGNpLWhvc3QtY29tbW9uLmMj
TDIz


From xen-devel-bounces@lists.xenproject.org Thu Oct 28 18:00:36 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Oct 2021 18:00:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.218211.378548 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg9hW-0005VN-TK; Thu, 28 Oct 2021 18:00:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 218211.378548; Thu, 28 Oct 2021 18:00:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg9hW-0005VG-Pf; Thu, 28 Oct 2021 18:00:30 +0000
Received: by outflank-mailman (input) for mailman id 218211;
 Thu, 28 Oct 2021 18:00:29 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ikAZ=PQ=epam.com=prvs=19352d112c=oleksandr_andrushchenko@srs-us1.protection.inumbo.net>)
 id 1mg9hV-0005VA-HQ
 for xen-devel@lists.xenproject.org; Thu, 28 Oct 2021 18:00:29 +0000
Received: from mx0b-0039f301.pphosted.com (unknown [148.163.137.242])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 9759b898-ad4e-45fd-9941-b5b9141bb3bd;
 Thu, 28 Oct 2021 18:00:27 +0000 (UTC)
Received: from pps.filterd (m0174680.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 19SHwkQP032018; 
 Thu, 28 Oct 2021 18:00:25 GMT
Received: from eur05-am6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2104.outbound.protection.outlook.com [104.47.18.104])
 by mx0b-0039f301.pphosted.com with ESMTP id 3c00qxr09p-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Thu, 28 Oct 2021 18:00:25 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by AM0PR03MB6066.eurprd03.prod.outlook.com (2603:10a6:208:165::32)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.14; Thu, 28 Oct
 2021 18:00:22 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::c038:e032:595a:651]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::c038:e032:595a:651%9]) with mapi id 15.20.4649.015; Thu, 28 Oct 2021
 18:00:22 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9759b898-ad4e-45fd-9941-b5b9141bb3bd
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=X1Y8EgoeCu24OTmpEfOPHEl1nPjrvA0v8M+ujpiXwC+4PlXETXq19Vj6Q3bk+AhRql/7PplPVvTuGRu5PDAPX2/E7Qw5xj/GyVrfErs7ypI9bBpXE0DwX5UIbi0QqpHbs7AeKH4inH8CqkUHuUenyUfwxLnwvAtOf3n4kol8SkRkndxV4kwPXcIlSdYUQMkBxAwq/KwvOA3dZyL5I5KXtjF0C4NMzyO9z1V3KGDcr6OZZ9VcJJVXjQH+GF2ZBbc9lYuRnALf0nP3EKD1gKURxNphnhiYoYyvdNGf89d34tuV32X32Wi/SbiyQS7Bf0f66no72Br68zoYowoWRHT7vQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=cpKiKheWiTfjBLTy5YHdUPBNxXxGmMNB11suL+eBGNc=;
 b=GhCS3WoeGNSiyHNH4Q8S+aaI6+WZue8MDfKi4ip+M8nvKFvZZyFf2vgsC1S8NYV5PUdDLf4iyINiDBTA2mUZCGQF2tWTlDYV5X4HljN/703qbUfeq+tjbxnAWbkPOHccBEJ8sO89GAyUISmHRfFMsDftI5Qt6+AYt+IZmRm6vG6S0xTf0jm4Nozcowhu39p0hGND4IsgjiSxTNBvbPVy6HP+vQjmmE53+Uo3WqGpqNGRjtJe0ROHgARqXhvSM2Jt4kU2OLsR52GHSFi+VGdBXAYmOqXEsI6jOL140u3y74U/7kBfGWte0ZvrMsgP4Q0cPgDkVcfYMQul8eKc3wiT7A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=cpKiKheWiTfjBLTy5YHdUPBNxXxGmMNB11suL+eBGNc=;
 b=nBUL/AaHEnLOJ7qMSf9whciMBhKj2EUE5X4vftl1RdLgjQIOXfJksOQB3+VAXubOefQFRPDldXGyBo+N3bYGaYNTgq1SvP+eA0LrbzpihUiVCxdZgnv7/5L6rm/GyrJSLvTi8P2AO6Hl7MXCRSkPDJkKephs199GT2tu/XoYw1zd+OgHL69pgtOKemBfaEskBVWT8AHEgJz0dwU8Qw/11BYuNejbIJmstC5hW4bgboD3fovq6qxDCVBiAXjbJgADAz3Kfb8DxG9OAK0ykzD05d2cRIYrbnypbPCBjK4s5PnVxvFCns2EepsINydiZ/iM/1EaJA4PS7fsuIB978IF9Q==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Julien Grall <julien@xen.org>,
        "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: "sstabellini@kernel.org" <sstabellini@kernel.org>,
        Bertrand Marquis
	<bertrand.marquis@arm.com>,
        Rahul Singh <rahul.singh@arm.com>,
        Oleksandr
 Andrushchenko <Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH] xen/arm: fix SBDF calculation for vPCI MMIO handlers
Thread-Topic: [PATCH] xen/arm: fix SBDF calculation for vPCI MMIO handlers
Thread-Index: 
 AQHXyww6rKHs3LJru0q52eLUia+oNavnHBIAgAE3H4CAABSQgIAADtGAgAADkwCAABB5AIAAAiIAgAAofwA=
Date: Thu, 28 Oct 2021 18:00:22 +0000
Message-ID: <6aa95015-c2c1-e55a-5303-c82842c94438@epam.com>
References: <20211027082533.1406015-1-andr2000@gmail.com>
 <cb7e9ef7-476e-93c3-d3c9-9a9ebc61003d@xen.org>
 <d63c6e0b-8aa3-9ba3-893c-5e464638a8db@epam.com>
 <65886734-7333-4469-fcc1-6916db708f13@xen.org>
 <b6bb02b6-6358-b5e0-1b80-7819aadabe10@epam.com>
 <6d8f1061-7aec-2c1a-aaf4-c30440c2797a@xen.org>
 <38da2edd-06a2-63d0-51ad-1284272c8da5@epam.com>
 <a74b52fb-6514-4187-17fe-b63236efa0ce@xen.org>
In-Reply-To: <a74b52fb-6514-4187-17fe-b63236efa0ce@xen.org>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: d01cca99-1878-49d3-74aa-08d99a3ccfcb
x-ms-traffictypediagnostic: AM0PR03MB6066:
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <AM0PR03MB6066F3D0C662E65779424015E7869@AM0PR03MB6066.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:6108;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 u6b4ZltQIKcneB6nIWZ5gk29lw8QoeRh4IFzKBcELMyHjSyJpWEIeE7ScWvu2+tFdjRXzY+O7uImTVv69tqNeKt5VlN3u61oJ14OjxavXQ+/OFfmMVGEwuayEQrwUqrYQLIdXVZxWiyKvGFod5qt6KgUAcidwlv/X7rWcSaCsvBeIf8Ghv8ErypXAx7yzDZCtNtyrjQQB2xuoCquM79PuVrSgsXsCEZZ7qx0Wo+ZnpV0ovWX/C/mCfuI6qjr+lWRtdp+nQU5kDTOwcSd41zckKh7zdlSXCbA2900jLoJSC5PaGhI2qdt35FMvPf910Bp2j0EA2EkCenmbGjE5a6zHiBmH9FjdYD7+oJSUgvSy3n65Y9LV1qV6qcvSVqZKfcSkJayGNE93OvAreh4HfhzBMcYuyKjdbD8ASbLG5ErDufYtM8pV1HXAsKU+2YxL3Z1og6gNiDoOTOEtVNUX/pUhqViake2Q2RiK3gFbNOPsXQD8r3xwtA5gWDKyTZKsbxpWlcGddO2jUhMzQ0W6ljLdzI0L8hT5/rfZMZbZLFUI7qRVJr4MKLEJwnb8b5qtWSZr70Qs5O/mvaTOPr/Cicx7j5N0JPpsKPfCWRJGbG+HY0ErGsOy5K80uID2BdUxSRnFIqonRFDtueIROV5AFnFTcLuYIoV4I5EAsDiyFtCLh3XFatec2XwRmuuyHcp6LmMBLiq8mO8RTZ2kPxu6fh7kXPTXqv8KVPOLF7w9uAs1i0=
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(5660300002)(8936002)(8676002)(53546011)(6506007)(4744005)(6486002)(508600001)(6512007)(316002)(31696002)(2616005)(36756003)(2906002)(76116006)(38100700002)(110136005)(107886003)(64756008)(66476007)(66946007)(66556008)(31686004)(91956017)(4326008)(71200400001)(66446008)(86362001)(122000001)(26005)(38070700005)(186003)(54906003)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?RU1Da0JuRmtkdU9Dc0hQZVJwNENENndQc0xvVUpkTlN4NVNPRTJVSDhxYVpj?=
 =?utf-8?B?UGI0eHBQQmsweGsvdXJlalJSQTdMaTVKWExiN3U0SE0ySzdIdzV6VmpLcDh4?=
 =?utf-8?B?U2hMejEyYlJvRVlvWCtsd2dKN1FDekNCZEMxMisvRlFxbjlpdEgrV2UyNXdr?=
 =?utf-8?B?L2c1bjZ5WXhLRDg2QlZ3RS82MmdhTTVRVWtLTWdPWUxxZDNJTjBsT1JBbDVk?=
 =?utf-8?B?NENiZ3dmTVUydDUyRVAvRDVkcWxIdHA3elFhbm5lSTVockZSMkRSODIvYnhs?=
 =?utf-8?B?Q0lUZUl2YjRBU2ZwTUxNa1phY3VaSEExTnR1akg1SXorN3FjV3dnN29HUVMy?=
 =?utf-8?B?dXN0WmRPcG9GNGNTZGRBbmpjMllzeFdGUUQ4bUFkS3djY0lDVFJ1UVJBUTlW?=
 =?utf-8?B?R2tBT1JtSWorNkIrMndXbzEvQS9LaUV5amNzOENmZ0t1MjA3b29EaHkvd2lU?=
 =?utf-8?B?OUtPVTZWOGZwT2grMlV4Y2lnUlo1S2VMWXNjWDZPbTZMcUpZcm5XZU9MWjRS?=
 =?utf-8?B?blB3YmE5RGRzeExLdzUvYXg4N1hZL29oSnFHK3dCenA3NVpmRng0bmF0QmpQ?=
 =?utf-8?B?VCthM1BjaVg0MWhabytCamt0Q0xhdGtJOGpxYm9Wb0FYNTAzQk9OSm90QTY5?=
 =?utf-8?B?a0pTM0FPZFBiL2NFR1pSbFB2SWJlL2lDRitYQ3h3S3UwRTcyT2sxZVdxQnpO?=
 =?utf-8?B?K2VoMTBvRnpEU0pDTHNicmZFK2kxdUN6U3ZBcS8wYzFwT1pScy9qT2RObERq?=
 =?utf-8?B?enV2R3VVZXhsSmhQblpPaDRXTnlVeWNzZE9xQTRscnFHdmRsTmN6OFFmRWVl?=
 =?utf-8?B?ZUxDTXRUaGl3Q3dBbnE2OVlVeG9IbkpnOXhROThweVpwb2JwZXFsNU9iUzYv?=
 =?utf-8?B?Wm9xTGZnUjZvWVdmWS9SZzlBNndFTjBycTd2Z0tERnoxWGt6YjBVNEw2b1I4?=
 =?utf-8?B?MzZabXVrZ2pyaXZsYjk2bFBjZ2xsNjh3MUV1MVM1NWEwTXdaSmJRL0FXMmVZ?=
 =?utf-8?B?dGVnSVpWRkdZZ0tMcVJFeHQ1MUovWFd1RmlXQUthaTNYbGc1M2FEWUo2MWdm?=
 =?utf-8?B?L3Q0TjQwdkd6VWY4bFpuVGwxNHo5U2w2WGZSS1NJcGpBOURQSCs2VDM2NElx?=
 =?utf-8?B?ZWJnR3FxbmQvWVRld3RsY3hHV2JmamRJeHgxTXJxYkgxaDhtZDZub1gzajZl?=
 =?utf-8?B?dmNrbU5PSXRZcW1aSDBsTndudTQvUDMyRnpGcS92eXNtQ2wvNlYyOFgvRCts?=
 =?utf-8?B?WUp6Y29CcVk1NE9RbHJXOWF2dUdaYWZFNjhJYnROZFFzbUFrLzNONC8vOEZD?=
 =?utf-8?B?RnBOcEQxekc5NEhsYXRVWWkwaEVIQmR3NUo2aHIyNmZuSFQ4NFdtNGRFSlZS?=
 =?utf-8?B?NHZwSCtwVDZHc0dSMDlmSmNWU3VOYktEdEdlWUJncVFwMVREdnJCUDlvbjhP?=
 =?utf-8?B?ZmJ3TVZhN0ljUEJRa0NHYVFTWHFQRDQ3bk12dUtxVENyT3pSNjNydlNyMWh2?=
 =?utf-8?B?S1NPZmZKc0hoRThqcEtleUVsMjhRZjVpYkoyeU02UGEzNHBuaWtxcWFsZDJv?=
 =?utf-8?B?Q0lGOWdFOE5oSlczcVQzWVBES0NrWmtLL0dxaUQzY2ZOQUI0L3ZNRXBvc0ZG?=
 =?utf-8?B?Q2hiaXNpNGg2Nm9PaEsxbjRNTUpLd3ZnM0ovdnBUQ01FNUZsSEgwVVZJMjI5?=
 =?utf-8?B?c2NscVl6cEZUc2x1UndWSmVIaHRUbmpIZGJyeVlqZTIyVytCZDBPSVR3czQy?=
 =?utf-8?B?cVFkMk4vdEFiK0RuUG16Mmhnb0Jmd3hwZFpDOWh4ek5NWWJxL0hMd3kzS29p?=
 =?utf-8?B?TlFTK1duUjJPcktWbWxOeWVMdXNtbnFRMkg3MTA0SlFXM0plQ0tOdG56OU9s?=
 =?utf-8?B?dlptMzJiSG5ZcEFnNm8zQ3hUMzJGY0pickJBdklQN1dpdjU0OXBRcmN4UldS?=
 =?utf-8?B?MU9SbUhKUVAraTU1ZnVrRkRUakp2a2pmTGhRaW1jMWphQlBZcGlWd2swUDlI?=
 =?utf-8?B?Q2ZSMjJJUGZQYWZFMjVVY3llUEFuMEZsazhUcXdxb21DS0w2cVRtck9CL1FW?=
 =?utf-8?B?d1pBY1Y2TjZZZzhkL3pBaFV4azRWQjRTcEVpUm1KZmFObmxuclZPeWFsU0V3?=
 =?utf-8?B?U3IrdGx1YjFnejU3blVzMjVDbENscjgwZzNKUEdvZkJuK2g2U3pCcWptWmFp?=
 =?utf-8?B?TnJJOFpGcU5RaUNwVFNHZDJTVkhHQ082ZHBwU3BZMmxBWEhnUHphbnhJUEhO?=
 =?utf-8?B?TEVvWjltNWV6dG9jY0ttNk5QUUFINVVtSGdLaEtVU0hkMzNPc2JTQU0xZmQz?=
 =?utf-8?B?RzVrSUpZMldHR1BuZzZIb2FFNDBIdmZGVENoc3NEcDVUaS91RUpRdz09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <B6769B93C08F9D448D498DFF9A5D6242@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d01cca99-1878-49d3-74aa-08d99a3ccfcb
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Oct 2021 18:00:22.3154
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: kMk3O/4UmYFaWpLNDeP6PXsx15CWYH9WBsdhPXSW/74w0/pOJlqDng0huUjdpmZnkxD4B3BIbutbs9u2x9HFcluDbpwGOASZk1m9ljgjqfQpHf9vaWU48jUE+lYze4EC
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR03MB6066
X-Proofpoint-ORIG-GUID: t5YNPLCNz7Z_fhFoiR5CgsKNtzihkq15
X-Proofpoint-GUID: t5YNPLCNz7Z_fhFoiR5CgsKNtzihkq15
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475
 definitions=2021-10-28_04,2021-10-26_01,2020-04-07_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501
 lowpriorityscore=0 spamscore=0 phishscore=0 adultscore=0 mlxlogscore=999
 bulkscore=0 impostorscore=0 suspectscore=0 malwarescore=0 clxscore=1015
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2110280095

DQoNCk9uIDI4LjEwLjIxIDE4OjM1LCBKdWxpZW4gR3JhbGwgd3JvdGU6DQo+IEhpLA0KPg0KPiBP
biAyOC8xMC8yMDIxIDE2OjI3LCBPbGVrc2FuZHIgQW5kcnVzaGNoZW5rbyB3cm90ZToNCj4+IGJy
aWRnZSBhcyBwcml2YXRlIGFuZCB1c2luZyBpbmZvLT5ncGEgLSBHVUVTVF9WUENJX0VDQU1fQkFT
RS4uLg0KPj4gU28sIEkgd291bGQgc3RheSB3aXRoIHNpbXBsZXINCj4+DQo+PiDCoCDCoMKgwqAg
aWYgKCBicmlkZ2UgKQ0KPj4gwqAgwqDCoCDCoMKgwqAgew0KPj4gwqAgwqDCoCDCoMKgwqDCoMKg
wqDCoCBzYmRmLnNiZGYgPSBWUENJX0VDQU1fQkRGKGluZm8tPmdwYSAtIGJyaWRnZS0+Y2ZnLT5w
aHlzX2FkZHIpOw0KPj4gwqAgwqDCoCDCoMKgwqDCoMKgwqDCoCBzYmRmLnNlZyA9IGJyaWRnZS0+
c2VnbWVudDsNCj4+IMKgIMKgwqAgwqDCoMKgIH0NCj4+IMKgIMKgwqAgwqDCoMKgIGVsc2UNCj4+
IMKgIMKgwqAgwqDCoMKgwqDCoMKgwqAgc2JkZi5zYmRmID0gVlBDSV9FQ0FNX0JERihpbmZvLT5n
cGEgLSBHVUVTVF9WUENJX0VDQU1fQkFTRSk7DQo+DQo+IEkgYW0gZmluZSB3aXRoIHRoYXQgc28g
bG9uZyB0aGlzIGlzIHBhcnQgb2YgYW4gaGVscGVyIChtYXliZSB2cGNpX3NiZGZfZnJvbV9hZGRy
KCkpIHJhdGhlciB0aGFuIGR1cGxpY2F0ZWQuDQo+DQpPaywgSSB3aWxsIGltcGxlbWVudCBhIGhl
bHBlciB0aGVuOg0KcGNpX3NiZGZfdCB2cGNpX3NiZGZfZnJvbV9ncGEoY29uc3Qgc3RydWN0IHBj
aV9ob3N0X2JyaWRnZSAqYnJpZGdlLCBwYWRkcl90IGdwYSk7DQo+IENoZWVycywNCj4NClRoYW5r
IHlvdSwNCk9sZWtzYW5kcg==


From xen-devel-bounces@lists.xenproject.org Thu Oct 28 18:09:34 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Oct 2021 18:09:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.218222.378559 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg9q8-0006IP-UA; Thu, 28 Oct 2021 18:09:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 218222.378559; Thu, 28 Oct 2021 18:09:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg9q8-0006II-QW; Thu, 28 Oct 2021 18:09:24 +0000
Received: by outflank-mailman (input) for mailman id 218222;
 Thu, 28 Oct 2021 18:09:24 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ikAZ=PQ=epam.com=prvs=19352d112c=oleksandr_andrushchenko@srs-us1.protection.inumbo.net>)
 id 1mg9q8-0006IC-2e
 for xen-devel@lists.xenproject.org; Thu, 28 Oct 2021 18:09:24 +0000
Received: from mx0b-0039f301.pphosted.com (unknown [148.163.137.242])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 2dc422c4-381a-11ec-84b0-12813bfff9fa;
 Thu, 28 Oct 2021 18:09:23 +0000 (UTC)
Received: from pps.filterd (m0174680.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 19SHwsE6032090; 
 Thu, 28 Oct 2021 18:09:21 GMT
Received: from eur05-vi1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2174.outbound.protection.outlook.com [104.47.17.174])
 by mx0b-0039f301.pphosted.com with ESMTP id 3c00qxr1gu-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Thu, 28 Oct 2021 18:09:21 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by AM0PR03MB3587.eurprd03.prod.outlook.com (2603:10a6:208:44::33)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.18; Thu, 28 Oct
 2021 18:09:19 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::c038:e032:595a:651]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::c038:e032:595a:651%9]) with mapi id 15.20.4649.015; Thu, 28 Oct 2021
 18:09:19 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2dc422c4-381a-11ec-84b0-12813bfff9fa
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Y0n9luGLj/ZXa/p3bMPZq0KBxwMRBG5/UzS8yfi0NuTeaLMDEyJ7B01o1bKXQb2kXLish/s/GioLWN2fIov15fTv+KcI8k7GFiGv+GFCxrR+AgqZB+KkOi9Q3iwUiBvO3s7LveNjALHjs8App3dluTEK4i04Ux2z97pTNRNtY3Gmhe+fMHe0B+HHWgDlAQQIZBwkk6+t4N5qafCmjjwEnthy7VYQmhKSPqsZ1+wcjGYEqi1mY9Ot50Z++RXnEjK7z75JLBL2Gyua5mHUFKerOP2Q3QsWNDqO8+mmCmttcu6MGykHB70AucgHbFmjuONqHKqffyhZtIervfTWinKgaA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=tCVOlmoi5k3p/KxFgnd0uAiN1JjQp/1/AWb1Vk1P7/Y=;
 b=Hy/KeAQCZO6gQa+x7d8UbpN91Kw4UKlIfmvmsWyoPBWRDSTxkWdtr3Q+MbmCi3VOFrq7K48P5mONe3Br/M66BKQLeONrxvWhmiMPCZjc2mY+lCA6/lJ/WYOALxfwOf2zRsPssK9IH8qyuZDsWqRurMCQLLefZXm6MvnVKeQ2o2ZGMzZA+5B0MEmhHv8/wQo6iy1C5X/FeM0xJm0U644Q6vjH+alep3GD6tndS99L7OekoHye1DqdCa4tRpd2H01lcg8/L6EFNRtvHwUa/7W4/NeShJM2dI0AgNkQ+xED45uxasAskr/xsKjDtRukm7xUokk/ZUF04SrO7NOfc+hmJA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=tCVOlmoi5k3p/KxFgnd0uAiN1JjQp/1/AWb1Vk1P7/Y=;
 b=PQHjLGfteEdjmbUOolLnia1FxC2WFG7RM9u2rQVz6bvLHRSvaeYg13ap3l0nTzK1VFinA4QL16UaxPsZG8bPLiPjYGnXjfg+uXxK1EwxCU/hu8HaDmmWQb5UVSOkvkhYINIAlEjKnQVJbFLXMXLntqYYQ1FRsNWwmyJ2KFP1afwCJuLtOoUmH9fq91XzHf0XN2GLtvHECLYDMkaGos6Y0Am32yb9o05rXdFu7pc7xC0JdBzYgJGhwSS66vR45xzG7fwaqtDJ/I0mHCy2RvV1FzPEGhHYR1n13RybZdg6ObFjo7ABw7vrPo1bVNWMZreBdrpd2jbvql4UrL4MM0UZWA==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        "iwj@xenproject.org" <iwj@xenproject.org>,
        Bertrand Marquis
	<bertrand.marquis@arm.com>,
        Rahul Singh <rahul.singh@arm.com>,
        Oleksandr
 Andrushchenko <Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH] xen/arm: do not try to add pci-domain for disabled
 devices
Thread-Topic: [PATCH] xen/arm: do not try to add pci-domain for disabled
 devices
Thread-Index: AQHXyw3lMiQK+jRYtUWdkzZ53OfPJavnJMeAgABhyQCAALX3gIAAZSoAgAAWCQA=
Date: Thu, 28 Oct 2021 18:09:19 +0000
Message-ID: <c90be094-ea45-1388-436c-ccb27801ac5a@epam.com>
References: <20211027083730.1406947-1-andr2000@gmail.com>
 <7a97bbef-68a9-8f52-0c93-88d4e84a07fc@xen.org>
 <alpine.DEB.2.21.2110271649240.20134@sstabellini-ThinkPad-T480s>
 <c3602294-0ab4-10df-77cc-2a9e13ddc73f@xen.org>
 <alpine.DEB.2.21.2110280948190.20134@sstabellini-ThinkPad-T480s>
In-Reply-To: <alpine.DEB.2.21.2110280948190.20134@sstabellini-ThinkPad-T480s>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 43fe67e2-0cda-4e79-d3e3-08d99a3e0fd0
x-ms-traffictypediagnostic: AM0PR03MB3587:
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <AM0PR03MB3587E16C0FCF99413CA53005E7869@AM0PR03MB3587.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 53wO+AA9XOotcQm/pkoEGA1Xv6Lx6M75qL+XfcXuYfHEySOpTLYNr5y3AKd2g99PvebM8TG0Up1h9aSeQbG+JQCOBrzbRYIs5oFa6vKD5US1ZFccukkS6XWpn+2Tz0RHv4eRFr45UpREyeKpdunDRsGleT5xMwVQBzQHIJyL6iZUJ6XMgrNxiflM0ej7a1sWP5i2JC+HBWEcXCTgnOxRWprEgjag28sh8V22/o5QS3li9Ge8SESmpDcqwSQs0HtBLi4UpkXaqEqkeX8ddnHeLmQjQ4NXVbSp9dqq3tZVZT8ETM+6pin/tHM9OOM68BDk/EodBNjrq2Sg5Cbr2VXzk/1AC62rFM1ZbCyyYAELtP7gbHncVvC5gGO6wz8BHDYkWLaWUh28FUUtoOKbuyzbzROUKcW1nFI7Gzu8AysnPjCd+Bz+XoOGRV6GpUdYOWm+tnWXKx4q2rObZegc1JjjZ8wPbM1rlWWD63XAtMDaDN739RhN4VBv6tOs4kIJ+UaCvTtmJ2PAJxIpDLrHJwEMoVkx/GG7zLnPKAgnmD8mbAtscy3YJfQomw1S+rWPNP7K7KCEqlXYLT2Ff4b7XP/3Noe+wrZ/9k9Zz6nN39gd3kwX+UWkOuhovf3jHxYLYk6SNs6Dl81KpLmEhnch71wCJ3vO39XYyINQjk4/CdW2WjUb0dT8U9a76EVLpS4Vig8iqA1d8cHHSRmfJ0nrH14RASzTTlAqp9mJ6BFu+0HMASE5wxbSX5CS1sBIMx8URS71
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(8936002)(8676002)(86362001)(31686004)(122000001)(38070700005)(36756003)(38100700002)(316002)(54906003)(110136005)(2616005)(6486002)(5660300002)(71200400001)(76116006)(26005)(66946007)(91956017)(64756008)(107886003)(4326008)(186003)(53546011)(83380400001)(6506007)(66446008)(508600001)(31696002)(6512007)(2906002)(66476007)(66556008)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?a3RabkdGYy85ZzFNZ29PaVNMNFB0d0JZNW02NjJOeGxZRjU3RjFXeTArVXk2?=
 =?utf-8?B?RVRXeXVKTkwzTmhjM05udk9lc0kzNm9hQnB0bThIbncwVE5pSVBtYnpJa1pn?=
 =?utf-8?B?K0VIejlPYncrL1NkeUt6MFdZbTRocDREYVljWXd6akNOUzBWQis0Rk03RWxr?=
 =?utf-8?B?b0NGRDIyUWNvbTlFdmkrK2R4ODhBR3V3aHhzakhnaWtZOXUzWDA2QzdRZHVr?=
 =?utf-8?B?UXlONFF6VGQ2ZzBmNzFDSVR6bkhsMndPdmliR0JNUDNCdW9Bdjlnckt2dlcz?=
 =?utf-8?B?M1FYYkhMTzVHTncvMGQ5RGNwV3BXNkgyK3dSRm5mT3RMRkxqMHVKVElXWHNi?=
 =?utf-8?B?Qzh1UWVtdWJ5ZEJ2R1Q0bVhPYUU3N2lGQXlIMGhKRERRZE9jZ1F1dVprWC9B?=
 =?utf-8?B?SDZwRnAxRDAzcEIwUlRmcTQzZDF5RzZacm9CTU5KS3llMU1qMnU1bzlpQ2N2?=
 =?utf-8?B?TDN3MnZPakNXNk1LVy9YYklBUlpPY2ROSkEwMERpc0FFV0pWU25RYS84alpx?=
 =?utf-8?B?aWRiMmhxL0IxUEFZZ2p3LzJmVEZud2xwTG9nWDZncGkxVnJwOVU3ZmovSU9y?=
 =?utf-8?B?VWEyY3M0ZWkzUDk0SWxhZDR2K0drb2FtcTJ3VE1tZ3ZTaFhZcmh2R1JVcm1G?=
 =?utf-8?B?WnFncDVSSFZscEF0bHl3b0JxYWxoWE13YUVnUjVUYWUxUUNsbG5NTFpZcEhh?=
 =?utf-8?B?NVhYV21kZk9URnZrZ1d1Q0tjSlh6aHlINXgyeEVXZEJHZ0xha3I5LzdIbFAz?=
 =?utf-8?B?ckNQMXFYNyt4VElzUjRFcWJ1M3M4cGJ5RXFwbzZSd0t6QXZYZXdtQjJWRHNM?=
 =?utf-8?B?dmRtRktMRUx6K2ZqUXpYSEQ1WTdXQzhROHFBbzNTdjRNOGVJd29lVGtBWUZy?=
 =?utf-8?B?Vk1LdG13Wkx4dlBvS1pIcEpmNXRreE9VejVobno3dUJSdncwTDZPQjNrUGIz?=
 =?utf-8?B?QkIwaVZWbGo2cllmbHh0TDVOTE5IV2xjVytEYmxNeTJGRGlLVGVoOWpQNkxM?=
 =?utf-8?B?c1FkenJOY1U2cVlPTHRkeXlnUjBsU0t6YkFQT0RDeXVRU013SDl0czlTZG5W?=
 =?utf-8?B?RkQvYzdnNkdSSG9YRUVRL0hML0hHekZuNjR0bWxMaVp5UllPSG5pbU5WSEk5?=
 =?utf-8?B?TFFaeVdQWWJqMDd4SE9rMytPRVJJRDA2aWhubEhvUjFMckpzNmVEMjl1VWlj?=
 =?utf-8?B?Zm1VMUxDZUtYVGExbVBZQU9HTUs3eUdNWk83RFpYRnMrS1hIRjIxVloyYS8z?=
 =?utf-8?B?OTlJdTZCcURDaVI5eGRnSUJuVXMxYUN4THJHZW42bHluc2l2cmU5cHhVVXZE?=
 =?utf-8?B?ZGkvMTF2UFIwSHd4ekE2WmhaVHZrYzlSb3NvUHpucmxuMEwvZlNXdE80YlJO?=
 =?utf-8?B?YkxaaVhsd2lnaEhCcVZSMHdraDREOXErbVk0T3IrZHZ3L1VNUUdTckk2STFn?=
 =?utf-8?B?Y3hjQVg5cHJkRlgvR2dtakFKV2g0NU83dHo0RHMrN0JiOUJWOVdyNnl5VkFY?=
 =?utf-8?B?VW1LZlBjVU93UFl4ZHZhdG5rRzM2b3FwMFJ3d3EzUEN4d2NidGJMQ1hVc0lH?=
 =?utf-8?B?RFJrejdzNzR0bUtxRWl3MWNBemppT1VrUVBudW41ZkxoRmwwMDNDRHN2WGlG?=
 =?utf-8?B?T2FxUjJMQUM4T2FsMThCQ2FhWkpEbXhaZ0xWS0VGTmUrMmlWTjV5S2kya2hU?=
 =?utf-8?B?WkcvZEl3OGovVWczZnFkNkRmbmJsT3FVSTFQcVRkc1k2am9sY2M3MzBQWUFu?=
 =?utf-8?B?ZlZuWDVMS2xXb1ZLSnh5ek5IWmQwZU8zTkFIeFJCZEpVS1d2a0ZDVjZ6V1px?=
 =?utf-8?B?VHUyYlJHZUV6blA2d0lzMHNySzlPaXRTWTRTMFNwNGlNYVM0OGR1U1A4Vysz?=
 =?utf-8?B?L3g1SHQxWS9yNVBURFhDMjZqQWV4R3ErenZIb21CZ2Q3dGhPUUhVenQ0dkZN?=
 =?utf-8?B?NE8vNlJROFY4U1N6ZzZOVHFNdUhjSWs1cUZEQURkdXRqK2tJUWVSdGNiTHRU?=
 =?utf-8?B?cWpjSFdrbGJwTXJLbTJOOFpFTFJ1RlFQOXpIL3loaTZhL2lRMXd0LzJBNXhu?=
 =?utf-8?B?azVHWWVaTis3US9xbENESG1adXAzL3F3Q0RGQjQyQzFNbXRqemlkYkRhV1Iz?=
 =?utf-8?B?Q0VTeVZDTXdWTWlXenhBT1FHb2ZRTHlacUJJSEhtZzUrR2FQVSsvcXluSWxR?=
 =?utf-8?B?ZGkwZXhHYVJ6Z0JYY2JaUkl4cS9GNngwTDNsU284Zy9XU1RmZ1ZzdTVESE1R?=
 =?utf-8?B?V0RvUXlER3p6bkI4eWNWRFJOQW5XUmJjZW0zci9jSUZNMDh3K0dhNFFxUG9L?=
 =?utf-8?B?RUdnU25YV3Uzb1J5WTlzVVd6b3NmeXdyZ2pzVHd6amY3Wm82VHpiQT09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <1A8AD10D5685F34BA373F7E5722D0434@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 43fe67e2-0cda-4e79-d3e3-08d99a3e0fd0
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Oct 2021 18:09:19.2305
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: zE382gzVFESq1nny6O4G7/yfprHUkbsSLdaJPxoyo2lktZgkrtkKsVZRomvrp4e3yzHUdSs+fffsC/4Va1vH1TksJr/SRe2pe5in935Kf15iialMLEdSijW1vwcJsA2Q
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR03MB3587
X-Proofpoint-ORIG-GUID: 5h-X1ZxJtJjPCpQF3JEQv3qEnAaZrJxv
X-Proofpoint-GUID: 5h-X1ZxJtJjPCpQF3JEQv3qEnAaZrJxv
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475
 definitions=2021-10-28_04,2021-10-26_01,2020-04-07_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501
 lowpriorityscore=0 spamscore=0 phishscore=0 adultscore=0 mlxlogscore=999
 bulkscore=0 impostorscore=0 suspectscore=0 malwarescore=0 clxscore=1015
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2110280096

DQoNCk9uIDI4LjEwLjIxIDE5OjUwLCBTdGVmYW5vIFN0YWJlbGxpbmkgd3JvdGU6DQo+IE9uIFRo
dSwgMjggT2N0IDIwMjEsIEp1bGllbiBHcmFsbCB3cm90ZToNCj4+IEhpIFN0ZWZhbm8sDQo+Pg0K
Pj4gT24gMjgvMTAvMjAyMSAwMDo1NywgU3RlZmFubyBTdGFiZWxsaW5pIHdyb3RlOg0KPj4+IE9u
IFdlZCwgMjcgT2N0IDIwMjEsIEp1bGllbiBHcmFsbCB3cm90ZToNCj4+Pj4gSGkgT2xla3NhbmRy
LA0KPj4+Pg0KPj4+PiBPbiAyNy8xMC8yMDIxIDA5OjM3LCBPbGVrc2FuZHIgQW5kcnVzaGNoZW5r
byB3cm90ZToNCj4+Pj4+IEZyb206IE9sZWtzYW5kciBBbmRydXNoY2hlbmtvIDxvbGVrc2FuZHJf
YW5kcnVzaGNoZW5rb0BlcGFtLmNvbT4NCj4+Pj4+DQo+Pj4+PiBJZiBhIFBDSSBob3N0IGJyaWRn
ZSBkZXZpY2UgaXMgcHJlc2VudCBpbiB0aGUgZGV2aWNlIHRyZWUsIGJ1dCBpcw0KPj4+Pj4gZGlz
YWJsZWQsIHRoZW4gaXRzIFBDSSBob3N0IGJyaWRnZSBkcml2ZXIgd2FzIG5vdCBpbnN0YW50aWF0
ZWQuDQo+Pj4+PiBUaGlzIHJlc3VsdHMgaW4gdGhlIGZvbGxvd2luZyBwYW5pYyBkdXJpbmcgWGVu
IHN0YXJ0Og0KPj4+Pj4NCj4+Pj4+IChYRU4pIERldmljZSB0cmVlIGdlbmVyYXRpb24gZmFpbGVk
ICgtMjIpLg0KPj4+PiBJdCB3b3VsZCBnb29kIHRvIGNsYXJpZnkgaW4gdGhlIGNvbW1pdCBtZXNz
YWdlIHdoZXJlIHRoZSBlcnJvciBpcyBjb21pbmcNCj4+Pj4gZnJvbS4NCj4+Pj4gSSB0aGluayB0
aGlzIGlzIGZyb20gcGNpX2dldF9ob3N0X2JyaWRnZV9zZWdtZW50KCkuDQo+Pj4+DQo+Pj4+PiAo
WEVOKQ0KPj4+Pj4gKFhFTikgKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioq
Kg0KPj4+Pj4gKFhFTikgUGFuaWMgb24gQ1BVIDA6DQo+Pj4+PiAoWEVOKSBDb3VsZCBub3Qgc2V0
IHVwIERPTTAgZ3Vlc3QgT1MNCj4+Pj4+IChYRU4pICoqKioqKioqKioqKioqKioqKioqKioqKioq
KioqKioqKioqKioqKioNCj4+Pj4+DQo+Pj4+PiBGaXggdGhpcyBieSBub3QgYWRkaW5nIGxpbnV4
LHBjaS1kb21haW4gcHJvcGVydHkgZm9yIGh3ZG9tIGlmIGl0IGlzDQo+Pj4+PiBuZWl0aGVyIGF2
YWlsYWJsZSBub3IgZGV2aWNlIGVuYWJsZWQuDQo+Pj4+ICAgRnJvbSBteSByZWFkaW5nIG9mIHRo
ZSBiaW5kaW5nIFsxXSwgdGhlIHByb3BlcnR5IHNob3VsZCBiZSBwcmVzZW50IGluIGFsbA0KPj4+
PiB0aGUNCj4+Pj4gaG9zdGJyaWRnZXMgaWYgb25lIHNwZWNpZnkgaXQuIElPVywgSSB0aGluayB0
aGUgcHJvcGVydHkgc2hvdWxkIGFsc28gYmUNCj4+Pj4gYWRkZWQNCj4+Pj4gZm9yIGhvc3Ricmlk
Z2VzIHRoYXQgYXJlIG5vdCBhdmFpbGFibGUuDQo+Pj4gSnVzdCB3YW50ZWQgdG8gc2F5IHRoYXQg
SSB0aGluayB5b3UgYXJlIHJpZ2h0Og0KPj4+DQo+Pj4gIiIiDQo+Pj4gSXQgaXMgcmVxdWlyZWQg
dG8gZWl0aGVyIG5vdCBzZXQgdGhpcyBwcm9wZXJ0eSBhdCBhbGwgb3Igc2V0IGl0IGZvciBhbGwN
Cj4+PiBob3N0IGJyaWRnZXMgaW4gdGhlIHN5c3RlbSwgb3RoZXJ3aXNlIHBvdGVudGlhbGx5IGNv
bmZsaWN0aW5nIGRvbWFpbiBudW1iZXJzDQo+Pj4gbWF5IGJlIGFzc2lnbmVkIHRvIHJvb3QgYnVz
ZXMgYmVoaW5kIGRpZmZlcmVudCBob3N0IGJyaWRnZXMuICBUaGUgZG9tYWluDQo+Pj4gbnVtYmVy
IGZvciBlYWNoIGhvc3QgYnJpZGdlIGluIHRoZSBzeXN0ZW0gbXVzdCBiZSB1bmlxdWUuDQo+Pj4g
IiIiDQo+Pj4NCj4+PiBhbmQgSSBhbSByZWFkeSB0byBiZWxpZXZlIGRldmljZSB0cmVlcyB3aXRo
IGRpc2FibGVkIGJyaWRnZXMgbWlnaHQgaGF2ZQ0KPj4+IChpbmNvcnJlY3RseSkgaWdub3JlZCB0
aGUgcnVsZS4NCj4+IExvb2tpbmcgYXQgbGludXgvYXJjaC9hcm02NC9ib290L2R0cy8sIHRoZXJl
IGFyZSBhIGZldyBEZXZpY2UtVHJlZSB0aGF0DQo+PiBjb250YWluIHRoZSBwcm9wZXJ0eSAibGlu
dXgscGNpLWRvbWFpbiIuIEFsbCBvZiB0aGVtIHNlZW1zIHRvIGFsc28gYWRkIGl0IGZvcg0KPj4g
ZGlzYWJsZWQgaG9zdGJyaWRnZXMuDQo+Pg0KPj4gSG93ZXZlciwgSSBhbSB1bmRlciB0aGUgaW1w
cmVzc2lvbiB0aGF0IGl0IGlzIG1vcmUgY29tbW9uIHRvIGhhdmUgYQ0KPj4gRGV2aWRlLVRyZWUg
d2l0aG91dCBhbnkgcHJvcGVydHkgImxpbnV4LHBjaS1kb21haW4iLiBXaGVuIFBDSSBzdXBwb3J0
IGlzDQo+PiBlbmFibGVkLCBYZW4gd2lsbCBnZW5lcmF0ZSB0aGUgZG9tYWluIElEIGZvciB0aGUg
aG9zdGJyaWRnZSBhbmQgd3JpdGUgaXQgdG8NCj4+IHRoZSBEVC4NCj4+DQo+PiBUaGlzIGRvZXNu
J3Qgd29yayBmb3IgZGlzYWJsZWQgaG9zdGJyaWRnZSBhbmQgSSB0aGluayB0aGlzIGlzIE9sZWtz
YW5kcidzDQo+PiBwcm9ibGVtLiBAT2xla3NhbmRyIGNhbiB5b3UgY29uZmlybSBpdD8NCj4+DQo+
Pj4NCj4+Pj4gQUZBSUNULCBMaW51eCB3aWxsIGlnbm9yZSBob3N0YnJpZGdlIHRoYXQgYXJlIG5v
dCBhdmFpbGFibGUuIEJ1dCBpdCBmZWVscw0KPj4+PiB0bw0KPj4+PiBtZSB3ZSBhcmUgdHdpc3Rp
bmcgdGhlIHJ1bGUuIFNvLCBjb3VsZCB3ZSBjb25zaWRlciB0byBhbGxvY2F0ZSBhbiB1bnVzZWQN
Cj4+Pj4gbnVtYmVyPw0KPj4+IEkgdGhpbmsgdGhhdCB3b3VsZCBiZSBmaW5lIGJ1dCBpdCBkb2Vz
bid0IGxvb2sgZWFzeSBmcm9tIHRoZSBjdXJyZW50IFhlbg0KPj4+IGNvZGUgcG9pbnQgb2Ygdmll
dyBiZWNhdXNlIHRoZSBhbGxvY2F0aW9uIGRlcGVuZHMgb24gdGhlIFhlbiBkcml2ZXIsDQo+Pj4g
d2hpY2ggd2UgZG9uJ3QgaGF2ZS4gQnV0IEknbGwgbGV0IG90aGVycyBjb21tZW50IG9uIGl0Lg0K
Pj4gU28gd2hhdCBtYXR0ZXJzIGlzIFhlbiBkb2Vzbid0IG1ha2UgdGhpbmdzIHdvcnNlLiBXZSBo
YXZlIHR3byBjYXNlcyB0byBjYXJlOg0KPj4gICAgMSkgWGVuIG9ubHkgaGFzIGRyaXZlcnMgZm9y
IGEgcGFydCBvZiB0aGUgaG9zdGJyaWdlcw0KPj4gICAgMikgU29tZSBob3N0YnJpZ2VzIGFyZSBk
aXNhYmxlZA0KPj4NCj4+IENhc2UgMSkgd2lsbCBkZWZpbml0ZWx5IGdlbmVyYXRlIGEgRFQgdGhh
dCB3aWxsIG1ha2UgTGludXggdW5oYXBweSBpZiB3ZSBoYXZlDQo+PiBkb24ndCBhZGQgdGhlIHBy
b3BlcnR5IGNvbnNpc3RlbnRseS4NCj4gR29vZCBwb2ludCENClNvLCB0aGUgYm90dG9tIGxpbmU6
IHdlIGFkZCB0aGUgcHJvcGVydHkgcmVnYXJkbGVzcyBvZiB0aGUgc3RhdHVzPw0KQW5kIHRoZSBz
ZWdtZW50IHdlIGFzc2lnbiBmb3IgdGhlIGRpc2FibGVkIG9uZXMgaXMgcGNpX2dldF9uZXdfZG9t
YWluX25yKCk/DQpJIGd1ZXNzIG5vdGhpbmcgYmFkIGhhcHBlbnMgaWYgd2UgaGF2ZSBzYXkgMyBi
cmlkZ2VzOg0Kb2theSAtID4gc2VnIDANCmRpc2FibGVkIC0gPiBzZWcgMQ0Kb2theSAtID4gc2Vn
IDINCg==


From xen-devel-bounces@lists.xenproject.org Thu Oct 28 18:13:39 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Oct 2021 18:13:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.218231.378570 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg9u4-0007kJ-Ev; Thu, 28 Oct 2021 18:13:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 218231.378570; Thu, 28 Oct 2021 18:13:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg9u4-0007kC-Bv; Thu, 28 Oct 2021 18:13:28 +0000
Received: by outflank-mailman (input) for mailman id 218231;
 Thu, 28 Oct 2021 18:13:27 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=dsiD=PQ=oracle.com=boris.ostrovsky@srs-us1.protection.inumbo.net>)
 id 1mg9u2-0007k6-Vx
 for xen-devel@lists.xenproject.org; Thu, 28 Oct 2021 18:13:27 +0000
Received: from mx0b-00069f02.pphosted.com (unknown [205.220.177.32])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 2867625a-2041-40bd-be89-53da8f6f9b61;
 Thu, 28 Oct 2021 18:13:24 +0000 (UTC)
Received: from pps.filterd (m0246630.ppops.net [127.0.0.1])
 by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 19SHJJOi030823; 
 Thu, 28 Oct 2021 18:13:20 GMT
Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79])
 by mx0b-00069f02.pphosted.com with ESMTP id 3byhy9kytp-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Thu, 28 Oct 2021 18:13:20 +0000
Received: from pps.filterd (userp3020.oracle.com [127.0.0.1])
 by userp3020.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 19SHu2Fi037748;
 Thu, 28 Oct 2021 18:13:19 GMT
Received: from nam10-dm6-obe.outbound.protection.outlook.com
 (mail-dm6nam10lp2105.outbound.protection.outlook.com [104.47.58.105])
 by userp3020.oracle.com with ESMTP id 3bx4gt6ww0-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Thu, 28 Oct 2021 18:13:18 +0000
Received: from BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10)
 by MN2PR10MB4111.namprd10.prod.outlook.com (2603:10b6:208:111::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.20; Thu, 28 Oct
 2021 18:13:16 +0000
Received: from BLAPR10MB5009.namprd10.prod.outlook.com
 ([fe80::3c49:46aa:83e1:a329]) by BLAPR10MB5009.namprd10.prod.outlook.com
 ([fe80::3c49:46aa:83e1:a329%6]) with mapi id 15.20.4649.015; Thu, 28 Oct 2021
 18:13:16 +0000
Received: from [10.74.110.188] (138.3.200.60) by
 SN7PR04CA0229.namprd04.prod.outlook.com (2603:10b6:806:127::24) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.15 via Frontend
 Transport; Thu, 28 Oct 2021 18:13:14 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2867625a-2041-40bd-be89-53da8f6f9b61
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date :
 subject : to : cc : references : from : in-reply-to : content-type :
 content-transfer-encoding : mime-version; s=corp-2021-07-09;
 bh=n2MbTc19cbFW3BYU2IBRk5XhrVaUi1awGIXDuwFqQrY=;
 b=sXuCi0sZ03hebw4GpgFqkCcTPpXTYV3VQdffMRxeoFc9KaHfGqpu5RM1WMZe1oSGBuyY
 e1OSUbzU1Z/bUEIvfPxeWBMkU7N0vrStgKx1BMYwQubyJbX6kxmvfD0DgmqEHeQfcHVx
 bUeRzMsti8iO7t0vWw+N6IHk//oV1dbneyol9FaqGsEUgOkPSZOdWiwqvGjs/w9ZI+XI
 LJ0NKJGXO+WN1ebNbRGpJKP2f2NX2ntXBji2ynR62i+BwzO2vuaK3fdO3b1uqth+uDxa
 OdTreVv2+scJKpa5Na7/PO3Znh6ZCY/vynfC6yoUZqw0SvFJA+/PWZIxMATF71FDwhdr TQ== 
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=K0HIg9xbmauhc9QhR1aiBDyvSSYX7r79eF/uHGi2Kbrdn8/tN858OvQX4+QCqZszellM9wD2HL4PT8oh3srw56YnNosjt7xhe16C2yFwYK1xRVY3k0FsXE3F9rvztUrcq7AouXtO9uavJPkJvrNGtgszkOwWbKUXSeh5bv8mEhL7fkSprykzEEC1uwWLyMHLpJO6BdZWkpkAR7Epnck72JdzIC046IRb6E01EwlrKRd/iYULwhPeANRHeEP/ZeQk4kKU0KwH6Nlzkk2AYfqEVVbwvws2oZMcFMzSf1amqqfYFjVWj5c7Fg4BVKozM+cbXry4X6Nzobhfa4QXYiX4FA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=n2MbTc19cbFW3BYU2IBRk5XhrVaUi1awGIXDuwFqQrY=;
 b=ZCGkGvffI4p40hAmdUEddTPGdZFN45b8rdnJwjM4sOb0wUysMIPt/IqpZ2t/WukjRTtzkSeEYAarldhl/2/YfuRmCud+REeYxPRIq3qG/p2KBHQX9Hm6P3ajSVlQNLiSmqmRmIGTQUpHngayvsu++re+nPDPFU3QlXBgNXhfVKLmp7e9kiqF6bFVwWIXY/1OUVmjmg1NxwBRFH4yMl3okWMgupVgLzn09nTTNFWpeMpdb6ZepEIFXQAVUhe9UkPoYbJ8xpIIxSLxbSuf0nqtbq3z1Xx5jzESXQlYNkRj1GbWuZZTZGFMj/2eba6pSKzQEVBf3IFGNsNStlC47OrqXA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com;
 dkim=pass header.d=oracle.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=n2MbTc19cbFW3BYU2IBRk5XhrVaUi1awGIXDuwFqQrY=;
 b=I46Rp9bgRv+yNdR0KltVLDau7NsOZ1G0AvMYyGd4TsU6oatiaUI/XIlj3eCdIN9XIwkRfQeG6oQQcYUK/ghS6K0EkwfsygBxkCwE2oL3ciCylhPoE8Hmw/LmMebdgeuaeLjbZcmSljpq1O10+ub/AR8Wn5puGH2sboYN2VAome4=
Authentication-Results: suse.com; dkim=none (message not signed)
 header.d=none;suse.com; dmarc=none action=none header.from=oracle.com;
Message-ID: <86df4640-b1b0-d3ee-119a-b6bf608f6d97@oracle.com>
Date: Thu, 28 Oct 2021 14:13:11 -0400
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.2.1
Subject: Re: [PATCH] xen/balloon: add late_initcall_sync() for initial
 ballooning done
Content-Language: en-US
To: Juergen Gross <jgross@suse.com>, xen-devel@lists.xenproject.org,
        linux-kernel@vger.kernel.org
Cc: Stefano Stabellini <sstabellini@kernel.org>, stable@vger.kernel.org,
        =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= <marmarek@invisiblethingslab.com>
References: <20211028105952.10011-1-jgross@suse.com>
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
In-Reply-To: <20211028105952.10011-1-jgross@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: SN7PR04CA0229.namprd04.prod.outlook.com
 (2603:10b6:806:127::24) To BLAPR10MB5009.namprd10.prod.outlook.com
 (2603:10b6:208:321::10)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 5822cb4c-d5bb-43d5-9ceb-08d99a3e9d03
X-MS-TrafficTypeDiagnostic: MN2PR10MB4111:
X-Microsoft-Antispam-PRVS: 
	<MN2PR10MB4111A5C6C189060AC2C7D3768A869@MN2PR10MB4111.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:1850;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 
	nAzxwAHJLNMbjCtEbIQyyP/AyjtLPOhOrcXjyFUtESPeEXedAioS8A+HrGRA0BzxgoHLznsO5UxuA5CeKr6WXAgPwRVzcYIEkqCx4wC0S91qjItWUO6EB7CHsE2+rBWe4xLlU8DpmchBPj1ZIZMr3Bx5wbzcWkb8Nd6erm/86tLV+1IJm17XmpOBNyT7y8IK9/T4isEmwkG6OdL2mPZTgei5ArP8pbcQBoaccWH/lq3KFmL7RWPzDdy8ZXJQ5LTdHgg+g5c/5QNEhj4pASTEIr6Y4dzN7aX1GgZ1KCrcSWcT7xjYqcJi7uA1rns6G47Pv+JEjyGB4aO5ngabJJgtCgEXUmXVmo6B6zambWjMnOf6Yom8/XmlYUAC9sTIn/SqgXlaatjIsIVvK7NxE7A/pc0hM1b3LDlJ8gPyj3BlZCrrRges5wjhphCKeX6Izk0OZ80WmGS7sjfGa3ToeE8xRpDGIYGDXydHLHUpXnDlQaYsef7NFNBuHkFCQl1KcQXuztDAP70JUMjsSTlL/F7ZA1cDMAIb+CEKN8RIywHjNL4EbgMUc7wtPT3Hhx4KRwZ1XgUcAqAf/S1yOtd62XZw8SxL3BrpnNCAY7TLPiJwynkiq3aLnLV1cSJsSn6dud4L7nuFeNZGbM8RXKkTqZolU9CzTNLV9HJeRtGE2I6O7q/ZaKoL9XYu1Y9u/XJZKHB+aq+MuotJrw82jhZEEKo7fieBaw/l1CTKSt7lYaepggA=
X-Forefront-Antispam-Report: 
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB5009.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(16576012)(508600001)(53546011)(66946007)(31686004)(66556008)(8676002)(316002)(31696002)(54906003)(36756003)(86362001)(558084003)(6666004)(6486002)(2616005)(5660300002)(2906002)(44832011)(8936002)(956004)(38100700002)(4326008)(26005)(66476007)(186003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?dGZlMkxobkI2d3p1ZnpCQTdhUnpaV2s1My9UMm1zQzlSOVV3dUhBd29odUly?=
 =?utf-8?B?WVFScmIzeW52V3pwcFBoY0M3QlVtQTVGa2hCbmJzQ1dwaXBtNkt0ZVlpcEZL?=
 =?utf-8?B?ejNZU0tySnNOSmZudjZUKzY3MkhWRkM3TUpaTUVFdDVqYytlQ2dwMVhWZnpj?=
 =?utf-8?B?S25hcnZRZmpaL2REVlIyU3NLWlZQVDZ0cU4rQzhmQ2pQVUw4YjgwanlqTW5v?=
 =?utf-8?B?ZHdDV0FtbEV0WXhzaHNKc2RwMkx6a3FDeUN1UFRyK1A2SHpmcGJaRjYrMCsv?=
 =?utf-8?B?QXhkdTRQK3duVEpxeStWOFJoRXE0ZG9IOGYvQ2phMGtaSHl6aHdjT1hnVDQ0?=
 =?utf-8?B?ZlNmNUd6NlFZUjc1ZVJZbERYeEEzWldURWwwS2JQNzR5YmFXeVRVNW8vMldP?=
 =?utf-8?B?UnhnVXVKOThMcGJnR25Gc0tpSUN2VVFrVmNFR2FjdnpQZ3hQMktqQVV2a2hN?=
 =?utf-8?B?WDZYcFhDQU5ia3dNTmFmbmlubUFLRGVQZllHN1hxdG1iQ01LOTM2bXB4QURx?=
 =?utf-8?B?ZzFRZTJSeTlIZnUvSlgxTkU5OHR0blJmVVhaWDQ0Z1MwWHl2b01RNUpPQmFC?=
 =?utf-8?B?cE9hbUx5OEFvdVYwbnY3cmxIZDE3Q3pWeHhXYTVjUTMvdWdCcVZzNkFkSDBt?=
 =?utf-8?B?UFhWSnhQRTBkZHZubmdqOWFhRHBUalJpa2J2SkFuRFkxZnYxU3BhamlkTTBJ?=
 =?utf-8?B?aDlzdk9ZN0NtdC92ZlNoU1Z6S2ZNUDRybktMaHRoTEsxQmczRkNkazE4VzJv?=
 =?utf-8?B?cG1lZ1VMaUp0dklQdlVBNk4xN3AxcExJa1ZvK2hsdTlWRTV2SldRb0FhWitP?=
 =?utf-8?B?dVl5R1o5THMxdEVGNS9iMFVpVHQvSHZQanE1d3RsYmd2d3prT0l0TURPRTVw?=
 =?utf-8?B?bHpreGxEUlYxdjI0b1VuWTV6T0k3R2FkZldOVVVScUpaY0t2NFd5aWpTTmJ0?=
 =?utf-8?B?ZjFzNGhuWnFNQ1ROVXlBbXdVM0F3QjBBNjBLdE5oSUc1MmxvY2ZjbStzNHpa?=
 =?utf-8?B?U2lQTkxQTGp3VGhvY2VRSk92M04wNzZmV3JPbVg3bzhxREZjOGtkSjc2ZWhB?=
 =?utf-8?B?a2liZW1ZWkNPbTV4azM3dzJxR1orUExhUU94aFc0VjROMUtQcldxOWJkaTZO?=
 =?utf-8?B?MVFXa0lUVmRsWVQ2ZkFBUlowb3prODI3aytxRDdXbDc2d1pVaFpFQXhxZzg2?=
 =?utf-8?B?ZVZMNWVmdkJJTmE5NkZ4YXpqVG5CSDltSE1IZVZ2VTI4T1RwTjdwZnNTUjY0?=
 =?utf-8?B?L0JSVXBlKyt4UXBvc3FvSlVucDBmb21maWl5ZXhJeThqcmFNOWJXME5YczdE?=
 =?utf-8?B?QW1GbyttbVB5d2JtMW4yeW1NdUw5emNac1hKNnVZL1V2QVh2Y25NN2JBK1hn?=
 =?utf-8?B?WjdsZGhmaGRvdVFDK2ZFL2VFakdrNU54Qm1EOXhLSldZTjJkUUt0QWorZ09V?=
 =?utf-8?B?QXQxZnUzMS8xNkwwSlVaanpkZDRvc2RERVZGS3gwL3hkWitOa05VVE9KQkI3?=
 =?utf-8?B?MVpyc1FEbnRtT24zS040d2RTK29oQ294bFpxSWozK3FyOUgweExKdEZ1TzJD?=
 =?utf-8?B?NXlFdDZmS1BZdXBVaG5ySDE3TWczeTNnVVBudGdlcy81ZmQwallQb1FkYi9Q?=
 =?utf-8?B?dVgrTlh4Mjk3Q1pJazFCalZkY2JUZDBVK0l3djI3S0xyMzU5dUtYVEhieFBs?=
 =?utf-8?B?VllHK1M0TjlRYnplUnhvM3BFWjV0VE9EaDA0bVpIaXhQUDdBcXR1NGd5V0tB?=
 =?utf-8?B?ZENyV0pBZ3ZNSXNlbVMwYnF6Z1hGRi9nV1ZtRWI3YmRPdVBUSjVYTjlJeHE5?=
 =?utf-8?B?Zngvb1JqMUoyd3lhSnl2ajBVamhQcEVOTGVhdDNtYWpYbHN6QnlocmhDQ1R2?=
 =?utf-8?B?K1lKZkhBWStRYzYwRmx3R1E3akZ0dVRNVjVpa2NsdWdjUmk4SHJ3NUtqT3NC?=
 =?utf-8?B?dE5xT2IyaE4yYmNuVE9EK0ZwdUJocW5JNVgyNUZmQmhoUlkyRkdEdG5jTEM2?=
 =?utf-8?B?QUFzUTZVR1RJaWxDK3RzL1EwT0tPYTJDV1pRSWVVZG9JYUlmUTJpcEdFRnJ2?=
 =?utf-8?B?ZFh5SEhkQnpCL1JtY3UzaTlOZlF2TmdHdTRIT2tYOGh1T29KVlVOU3BCZG9I?=
 =?utf-8?B?cGxJT3ZScHZFbXh3MkZqaUdBUnJTa2k0TUdHUnBVYy9XVmJCWWp6b0pjTm42?=
 =?utf-8?B?a1VXZzRDdlhoRHY5WTMxMkMreWNvbGdPYkNhNldVRWRHR0FjNHFIS1VxSnhO?=
 =?utf-8?B?RUVTVXpoZmtIYkpNNGRvVlMyTzZBPT0=?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5822cb4c-d5bb-43d5-9ceb-08d99a3e9d03
X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Oct 2021 18:13:16.4476
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +wRpRGeER8v3nTpdxhdOB7EQ4STXuHgttjkT5Ofvgjb9bUUYB2NK8JhcWIg9z1t8C3GASsnvsvUHKviUnaEu7kvzbFjIDmS3vvy+Q/CL6tU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR10MB4111
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10151 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 malwarescore=0
 adultscore=0 suspectscore=0 bulkscore=0 mlxscore=0 spamscore=0
 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2110280095
X-Proofpoint-ORIG-GUID: MBXg1uUgs8IUfF3jm2otdfABloUDyh7a
X-Proofpoint-GUID: MBXg1uUgs8IUfF3jm2otdfABloUDyh7a


On 10/28/21 6:59 AM, Juergen Gross wrote:
> +
> +	while (current_credit())
> +		schedule_timeout_interruptible(HZ / 10);


Should we be concerned that we may get stuck here forever if for some reason we can't balloon down everything?


-boris




From xen-devel-bounces@lists.xenproject.org Thu Oct 28 18:19:04 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Oct 2021 18:19:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.218240.378581 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg9zL-0008Uk-2x; Thu, 28 Oct 2021 18:18:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 218240.378581; Thu, 28 Oct 2021 18:18:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mg9zK-0008Ud-W6; Thu, 28 Oct 2021 18:18:54 +0000
Received: by outflank-mailman (input) for mailman id 218240;
 Thu, 28 Oct 2021 18:18:53 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=TkaK=PQ=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1mg9zJ-0008UW-Iw
 for xen-devel@lists.xenproject.org; Thu, 28 Oct 2021 18:18:53 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 144f8349-388a-42f8-9fd5-e602c4cebce7;
 Thu, 28 Oct 2021 18:18:52 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id AFDF6610E7;
 Thu, 28 Oct 2021 18:18:51 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 144f8349-388a-42f8-9fd5-e602c4cebce7
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1635445131;
	bh=1RvhQoSr/2Cfzr5asneQjz6FZQyQ0S2NuU1ldOk68nI=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=Woieo0gGzKzv/48/y2UnyGyjcE73zavcYPU+rV8wMDEDnbrPoGb8ZF9Y79+vIRhUR
	 o8/62NoZBejt4dRArJP23/q3c5XoTiGMcnoDPM4dYfkfpBiKsC/JTR9zDYvXWmPpjX
	 b7bVZEyowVn58c8iQRsCiggnSYVg7nUySArw5lfZH7bLKATGakq9c9o9he/MaZ1ckw
	 NZ5ktno8WD+mDPy9VNmQAKt20DwFiHGGH4PiPrurE1nlYa9cL1EozNKErxtgpf+OFt
	 /Zop6lhpYOaAS4zTlrhcRPu6KlpMtT3rUvuJCfZ968jc6FHyClT8LfYX5Q8mbkeUxS
	 sEmqWlmuBApIQ==
Date: Thu, 28 Oct 2021 11:18:51 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
cc: Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>, 
    "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, 
    "iwj@xenproject.org" <iwj@xenproject.org>, 
    Bertrand Marquis <bertrand.marquis@arm.com>, 
    Rahul Singh <rahul.singh@arm.com>
Subject: Re: [PATCH] xen/arm: do not try to add pci-domain for disabled
 devices
In-Reply-To: <c90be094-ea45-1388-436c-ccb27801ac5a@epam.com>
Message-ID: <alpine.DEB.2.21.2110281118070.20134@sstabellini-ThinkPad-T480s>
References: <20211027083730.1406947-1-andr2000@gmail.com> <7a97bbef-68a9-8f52-0c93-88d4e84a07fc@xen.org> <alpine.DEB.2.21.2110271649240.20134@sstabellini-ThinkPad-T480s> <c3602294-0ab4-10df-77cc-2a9e13ddc73f@xen.org> <alpine.DEB.2.21.2110280948190.20134@sstabellini-ThinkPad-T480s>
 <c90be094-ea45-1388-436c-ccb27801ac5a@epam.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Thu, 28 Oct 2021, Oleksandr Andrushchenko wrote:
> On 28.10.21 19:50, Stefano Stabellini wrote:
> > On Thu, 28 Oct 2021, Julien Grall wrote:
> >> Hi Stefano,
> >>
> >> On 28/10/2021 00:57, Stefano Stabellini wrote:
> >>> On Wed, 27 Oct 2021, Julien Grall wrote:
> >>>> Hi Oleksandr,
> >>>>
> >>>> On 27/10/2021 09:37, Oleksandr Andrushchenko wrote:
> >>>>> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> >>>>>
> >>>>> If a PCI host bridge device is present in the device tree, but is
> >>>>> disabled, then its PCI host bridge driver was not instantiated.
> >>>>> This results in the following panic during Xen start:
> >>>>>
> >>>>> (XEN) Device tree generation failed (-22).
> >>>> It would good to clarify in the commit message where the error is coming
> >>>> from.
> >>>> I think this is from pci_get_host_bridge_segment().
> >>>>
> >>>>> (XEN)
> >>>>> (XEN) ****************************************
> >>>>> (XEN) Panic on CPU 0:
> >>>>> (XEN) Could not set up DOM0 guest OS
> >>>>> (XEN) ****************************************
> >>>>>
> >>>>> Fix this by not adding linux,pci-domain property for hwdom if it is
> >>>>> neither available nor device enabled.
> >>>>   From my reading of the binding [1], the property should be present in all
> >>>> the
> >>>> hostbridges if one specify it. IOW, I think the property should also be
> >>>> added
> >>>> for hostbridges that are not available.
> >>> Just wanted to say that I think you are right:
> >>>
> >>> """
> >>> It is required to either not set this property at all or set it for all
> >>> host bridges in the system, otherwise potentially conflicting domain numbers
> >>> may be assigned to root buses behind different host bridges.  The domain
> >>> number for each host bridge in the system must be unique.
> >>> """
> >>>
> >>> and I am ready to believe device trees with disabled bridges might have
> >>> (incorrectly) ignored the rule.
> >> Looking at linux/arch/arm64/boot/dts/, there are a few Device-Tree that
> >> contain the property "linux,pci-domain". All of them seems to also add it for
> >> disabled hostbridges.
> >>
> >> However, I am under the impression that it is more common to have a
> >> Devide-Tree without any property "linux,pci-domain". When PCI support is
> >> enabled, Xen will generate the domain ID for the hostbridge and write it to
> >> the DT.
> >>
> >> This doesn't work for disabled hostbridge and I think this is Oleksandr's
> >> problem. @Oleksandr can you confirm it?
> >>
> >>>
> >>>> AFAICT, Linux will ignore hostbridge that are not available. But it feels
> >>>> to
> >>>> me we are twisting the rule. So, could we consider to allocate an unused
> >>>> number?
> >>> I think that would be fine but it doesn't look easy from the current Xen
> >>> code point of view because the allocation depends on the Xen driver,
> >>> which we don't have. But I'll let others comment on it.
> >> So what matters is Xen doesn't make things worse. We have two cases to care:
> >>    1) Xen only has drivers for a part of the hostbriges
> >>    2) Some hostbriges are disabled
> >>
> >> Case 1) will definitely generate a DT that will make Linux unhappy if we have
> >> don't add the property consistently.
> > Good point!
> So, the bottom line: we add the property regardless of the status?
> And the segment we assign for the disabled ones is pci_get_new_domain_nr()?

Yeah I think so


> I guess nothing bad happens if we have say 3 bridges:
> okay - > seg 0
> disabled - > seg 1
> okay - > seg 2

It should be fine I think


From xen-devel-bounces@lists.xenproject.org Thu Oct 28 18:58:33 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Oct 2021 18:58:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.218249.378592 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgAbT-0004VS-35; Thu, 28 Oct 2021 18:58:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 218249.378592; Thu, 28 Oct 2021 18:58:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgAbS-0004VL-Vi; Thu, 28 Oct 2021 18:58:18 +0000
Received: by outflank-mailman (input) for mailman id 218249;
 Thu, 28 Oct 2021 18:58:17 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=dsiD=PQ=oracle.com=boris.ostrovsky@srs-us1.protection.inumbo.net>)
 id 1mgAbR-0004VD-Ff
 for xen-devel@lists.xenproject.org; Thu, 28 Oct 2021 18:58:17 +0000
Received: from mx0b-00069f02.pphosted.com (unknown [205.220.177.32])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 01ed7f36-3821-11ec-84b3-12813bfff9fa;
 Thu, 28 Oct 2021 18:58:16 +0000 (UTC)
Received: from pps.filterd (m0246632.ppops.net [127.0.0.1])
 by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 19SIk69s021602; 
 Thu, 28 Oct 2021 18:58:12 GMT
Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79])
 by mx0b-00069f02.pphosted.com with ESMTP id 3byja2caqc-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Thu, 28 Oct 2021 18:58:11 +0000
Received: from pps.filterd (userp3020.oracle.com [127.0.0.1])
 by userp3020.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 19SIu2oi087288;
 Thu, 28 Oct 2021 18:58:10 GMT
Received: from nam12-bn8-obe.outbound.protection.outlook.com
 (mail-bn8nam12lp2171.outbound.protection.outlook.com [104.47.55.171])
 by userp3020.oracle.com with ESMTP id 3bx4gt8q1c-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Thu, 28 Oct 2021 18:58:10 +0000
Received: from BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10)
 by BLAPR10MB4978.namprd10.prod.outlook.com (2603:10b6:208:30e::23)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.14; Thu, 28 Oct
 2021 18:58:08 +0000
Received: from BLAPR10MB5009.namprd10.prod.outlook.com
 ([fe80::3c49:46aa:83e1:a329]) by BLAPR10MB5009.namprd10.prod.outlook.com
 ([fe80::3c49:46aa:83e1:a329%6]) with mapi id 15.20.4649.015; Thu, 28 Oct 2021
 18:58:08 +0000
Received: from [10.74.110.188] (138.3.200.60) by
 SN7PR04CA0023.namprd04.prod.outlook.com (2603:10b6:806:f2::28) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4649.14 via Frontend Transport; Thu, 28 Oct 2021 18:58:06 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 01ed7f36-3821-11ec-84b3-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date :
 subject : to : cc : references : from : in-reply-to : content-type :
 content-transfer-encoding : mime-version; s=corp-2021-07-09;
 bh=OZS+twtcft5wr6hjuRRp9E/3gTstdgRG1JceZBp4DHw=;
 b=H+ppbqhANTXZDUJy/DfKSPap1MUN0I84H5Gq7Po7n+/wM44n+o1HTcD7NA3bZOzBgp9S
 RkW4De1qcg6L0YvVMEIjPnt4QXScC8BthlzPcR9EPIhehLqkuYDYyLS2Aj+mhsLmChO2
 ufXzRZ96P2QIGWo5SCuhfi9Us5Js6u7qU1LzlD/0pRTrG7V407m2I7SbS6gMBBediMJu
 dGy+GaNDrr8FDsoVNvoD1k/n6N/IHq56yZWzOrpdPXavG1Xqu+mMTMKt05KLMGSlkiJK
 XFJfOaqNoheI9adgtK8jH0dPWyfn23BI+r2LbzLuAn/jSfr3+2d1/TgZgzCXqWuXWls7 GQ== 
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=m4QnsVBf0YeUO1m/YOf3lbLnRoySOgHThQyXIf6QdubUC+dwRYtkrRObU6RfdfnSJp9PuZyCInZ6BECa3E4Iyjn5CeYtPV/QYZfUl9jlsALe6XQjmslk1JPC5At/F8HPY25wbB89lmo5mt4iqCHpp5DdELJtZqMrUbBhrkhGE5tkNj5ElbYvaitbNf5vNi/9r14ALZAiBU4MaNE0d+60paCwkm1CrYCmKjG1izwRDfAPBCuZgZdmPLJAhDATQKTh2kFnL9QLhgqf2okl277+jebqbSOFLBiyoFzmi0n01ICduLB3zX/oO8R/QLaP+R/ug5RVnJw32TjPaYfyyB0IQg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=OZS+twtcft5wr6hjuRRp9E/3gTstdgRG1JceZBp4DHw=;
 b=hs5F83905MqL0X71fSRAwA17so/+3boG/cBE0ps65gNiNLtzjvANEeqB3QqBaeqvcNw0rwrYgapNlwtssU8hsrwNJaXge7UlP5d99yHmMQFefBs2G9o9GDOYPyaMlJ0vXrK4vWrPrHnqXu9foRlnIWIpfOYwFeopOMNXa3O+8Bo/pe1tiGzyHqHAU82F1ESldU42t8/EAYRPJG1dSzBivahvec0c+uASTHlxz/3QCRrcXrQINJgPMB+h71abffLCVqIL8B8c1y5NzfUxsdVaYMQ8LZebggtEWrhwJcvlSIAz+51tHCE7FzljbWSbPIFrF5LTmBl1yr75bGO/k6MqDA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com;
 dkim=pass header.d=oracle.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=OZS+twtcft5wr6hjuRRp9E/3gTstdgRG1JceZBp4DHw=;
 b=v+oAF68POPxaaJNd3tbUwIEcVCqgfSSjeoFB3wzHFtPsaB77EtUCfos03uWNPH97cOXPwmmwdXASY5l3o6AI9rfTRoKFrXiVdHi/UBJbPP+5Go5xII4Gu65uZoH6JqMaaCxuI+NHu4Sp4vX8/HenFoDK5GJTdBSbJEl8LxSQr3k=
Authentication-Results: gmail.com; dkim=none (message not signed)
 header.d=none;gmail.com; dmarc=none action=none header.from=oracle.com;
Message-ID: <18766b45-5de5-5978-70b8-8582c30230db@oracle.com>
Date: Thu, 28 Oct 2021 14:57:58 -0400
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.2.1
Subject: Re: [PATCH V2 1/4] xen/unpopulated-alloc: Drop check for
 virt_addr_valid() in fill_list()
Content-Language: en-US
To: Oleksandr Tyshchenko <olekstysh@gmail.com>, xen-devel@lists.xenproject.org,
        linux-kernel@vger.kernel.org
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
        Juergen Gross <jgross@suse.com>,
        Stefano Stabellini
 <sstabellini@kernel.org>,
        Julien Grall <julien@xen.org>
References: <1635264312-3796-1-git-send-email-olekstysh@gmail.com>
 <1635264312-3796-2-git-send-email-olekstysh@gmail.com>
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
In-Reply-To: <1635264312-3796-2-git-send-email-olekstysh@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: SN7PR04CA0023.namprd04.prod.outlook.com
 (2603:10b6:806:f2::28) To BLAPR10MB5009.namprd10.prod.outlook.com
 (2603:10b6:208:321::10)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: b3bca456-7b53-4f24-a07d-08d99a44e152
X-MS-TrafficTypeDiagnostic: BLAPR10MB4978:
X-Microsoft-Antispam-PRVS: 
	<BLAPR10MB4978FA82C04EC0CA138A23F88A869@BLAPR10MB4978.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:3968;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 
	D+PM9H3ZhT/yQxZSXB0E4GguuqEexd0mRtTC8vdRoiz34z/ONada7WPDhViiLxHoYc9TpWXcEQOZDe+PBtK6Vh9jFGPy8V23v3JS6W4+vrCcW4m+39kbvh36qBf0474s1oEaanQTOt+zEjd7w5KfGiW11ewWHf+q082DFXY9jUHKXfwhMrUx0eKgI9jdhDuhA+oR07+l6Tg13jn+la328DjjxLYamO7Lzidp9B73QFy9odT8B5ei0gJBfl43FzhIk5ZNULqgROqvS91Uso7b3O6FawNfSi6zEUVHLAIXnEcM4NU5D9skreZXfFEKAgAIvS/4O2WYfz6KTkrUDYwtJRMNaR/JOPMu4Tr8avlVzhTCbmgO9s9ZUfon3PGPLLMKJ05Wnamz7DONHTERNHpET2cqSotdvaEmM+LyJEJzEiEdK/WRGHkqztABe5iTAQOaQj55yrE7P9MyuUs93z+w8Xaz4FFRgUgGmhkZ1VMSEtT3L/1+OeGeyBUZrZRTjj7uoycMoOHwQ7kJ1p1Caai47WLHvvBa4bJtfdBzucr94EBewNCHJdtf1W5aM8xuhKAXz5mTtiNjWz/puhI8UTfJCbJ/Eee0x0kNyXpca++yMUBlfADZZRJ7pBh7PAVIQ29/3fHEGhK/IHdUIqgSTaiNYn8XzpPyXRyBi2D7rkJYgThMlcLZwAkBvzwUQbM6GzdZm5hJVW8D8iUH1ukoD86zrwPgLixZDKhFocAr9nZ0/ek8dNoTqRw98mkDz2v8WxIo
X-Forefront-Antispam-Report: 
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB5009.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(86362001)(2906002)(31686004)(44832011)(8936002)(8676002)(38100700002)(5660300002)(316002)(4744005)(66476007)(66556008)(186003)(16576012)(2616005)(31696002)(6486002)(956004)(26005)(36756003)(66946007)(53546011)(54906003)(4326008)(508600001)(6666004)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?Nmg4TGZyc084Q0swbHQ5M2xBSkxvRDhTYldLNzRFMTFuWGpZU245Z2lJZTFX?=
 =?utf-8?B?MmI0UHRTcmFPVURSUTJ4bXcvdnF3TEcrclN4azlSRnc4OGV6SG9nRmFuTnRm?=
 =?utf-8?B?b1hubUNQL2RoNUFncXhzNGR6RzZURDBPQTdkOTQrd04zMVcrMlBnS21ZSHBN?=
 =?utf-8?B?SUdvYXJaWFgweVJxNGlWcnRsNkJtODhTaERlSGoyODljRnBvMC9BN2RpN1ZU?=
 =?utf-8?B?MUJaSzVXdngzU2MwK0RjWWcrYUtOdTR4a29SQzY3UWhDdTduMWk2MnJ0bTZi?=
 =?utf-8?B?eFVzdmVvTnFuZHFPLzRPLzhlTzcvVkU5WUZBWEovcXNiSVhyWGZOSFdhZ1BY?=
 =?utf-8?B?TGNoWVhrMHREU1gvTG4vWXZXT0UyaGZMQW54TlRMckpJS1BOSHZlRG1xZHJW?=
 =?utf-8?B?TlBhdmFvZG8zMG5YYytjeEgzUUtJa2NRS0JNTzU0YXFOSWo2YU1sN3VsZGpP?=
 =?utf-8?B?azFObG1UN28rajlaS3lOdk5zckY3N2IycmpMZHBnLy9WVmtReHVsRFRhZ3hJ?=
 =?utf-8?B?UDU4TWRoNDZwbHNoY0ZNTFc4Y2pjTlhmVXI5N3M5bjhvUzNXMGhjRTZiWVJs?=
 =?utf-8?B?SFczcFJIdysxTG5TTGRvRWUvQmplaDhidmtrczBxYmpSOW00N3dOVVRvN2NX?=
 =?utf-8?B?SEVFUXgrV3Y4Vm5CSHZXeFJydFJMejFjVi96bFA2aDcwaDE3VDFFYXVadWZQ?=
 =?utf-8?B?TTRpbkltRDkrakpFMjcwSmFXZkd3NUlIZEtIaHNNSEQrK1Ryc2ttUjZzWlRN?=
 =?utf-8?B?Z3MrQlZTL2JBbzJKMkFUbG1CZCtOUlZ0Z2hOTVdCbUhaQ2ZGcmJoeVZ6bnQz?=
 =?utf-8?B?Ui9DL21IQXhnYkVocHh1YVdYWFhWWFQrNVFnUGJDdjRCWG5KRjR2QmxET1JB?=
 =?utf-8?B?WTQvWk8yNUxiNTc3dTlEREJ1ck1hbjN5NklhWWRMT0VFWWR0N21ybmdDR05m?=
 =?utf-8?B?TlpXRy9jbUkrUmJDSHhIQ0QrekY0WGRqT0RCMElnclBmZ25BeHRjSVBQMGhP?=
 =?utf-8?B?U01YT2E3VWIwTmQyenlYZzVDM3JGRHlsVmlBRitjdGZuZ2w3N055R2RRK2pG?=
 =?utf-8?B?NG1HUEc2cGpRK29WU1FEQ083OStDUHFubUpBbGhwSm9rdGVWak16R3hVSjBK?=
 =?utf-8?B?VTJvNEVuNERzaS9zc1Mrcm5IMFlrSTF1clNoZW11cU1Nbi9DVDY0MVIzQk1z?=
 =?utf-8?B?VDBUclZFS0YzUHZGZzZ1MnpieTd3aS9aUzBaOUU1cVFoR0FaS3ZNSmRXR2hm?=
 =?utf-8?B?ajZnVndwaEc0bVlLNWhvZWcvbERXU2JsYjNneWxEVkFCV0pGemF4R2h2U281?=
 =?utf-8?B?NDQ0eUVYM1dONFdzeWY5Ui9rUHd2aEp6MUtMMEgxS21paUhVWHN4MHlaOWZk?=
 =?utf-8?B?TnBacktQZ2dtalBGdXV4V3ovOFZhcDh3bFVWYllnbnFmVWxsekt6dkZrRE54?=
 =?utf-8?B?MWVKT3pWUldOU3owUGViWkdqN0JaaXpya3pkOUl0ZG9FeDdIZjhDOFlhcllJ?=
 =?utf-8?B?WXpZSFFBU1k1cG9BMXlNamVrZkw1RFg3THRHdU5xNEkraGV0QWlyNEF2dmNG?=
 =?utf-8?B?OU9uUythbDgxcmZ0QVhxQzhsL29QVHk4dmFKRllmRUZmaGVEQWFxdUdia3Y2?=
 =?utf-8?B?dW9nYjVlcE9pRitvd0RRMGRWYWltU0RrYjZDYTFIMkppV1FqOUJkQ21LbU5W?=
 =?utf-8?B?V1ZlUnFwaEdUWUR3S29lYUk1b3liZU9BcjZ5SVExRndkVE9ucVlic05mL3dz?=
 =?utf-8?B?U2x4VytxSGxwRHgzZmc5YVk0bnRsd0dpNFFZVU9Wc2xRcmNQTW4wWFAzQzN0?=
 =?utf-8?B?cnM0TS8yMk42Q29uaHRWUjRXK29BV2FYVi82d1NGMW1FcEZLSlhLNDdWRHNL?=
 =?utf-8?B?eVRjUFp0a2I2T0t1UlBySnBGNCtna1dzbitkOGZ1NXNTbkUzWlAybnl2OEdp?=
 =?utf-8?B?Tit6RnVqWFFGaWFTakszZGxxU0U4OXMzQzVPL2dBaVhpaUJmRy9oeks1UU44?=
 =?utf-8?B?ZWtCN0NsaXpGdkhaYUFTUSttWE5VZlJkZk1qMEZpZ2t1dXlFOTd2T3JUK3I5?=
 =?utf-8?B?dEdYYVdxSjhjem1BZDU0VzNGSzI1N2RHaFlQTW10cUc3bFJBbDhrM04vb20w?=
 =?utf-8?B?aHNMZ0VOZDB5USsvUENDL3VaVW1UQ3huVnI0R2VvWkVBWG9NdlZnODVuSXdH?=
 =?utf-8?B?YUVLdnBUTUtFb1VHMlVwZlZoa1ZGSER4dVdSckxLLzl3U3hyMTV5M2NzNVgv?=
 =?utf-8?B?TjMxTzd1SzZZVDVVR3YyT2IrS3V3PT0=?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b3bca456-7b53-4f24-a07d-08d99a44e152
X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Oct 2021 18:58:08.0817
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 7a84z7jFUQ+s4H0D8f07alk+7cSCs/2BPCuFlCuqXFOnSXo1iKnR2eY7TuvfLmqdaJ9NOaUhXmzL8O8IdEp2XzDT6yjxyGrtzmuIdGgUPl4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB4978
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10151 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 malwarescore=0
 adultscore=0 suspectscore=0 bulkscore=0 mlxscore=0 spamscore=0
 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2110280099
X-Proofpoint-GUID: _ipTbYQJafJNb5rTTedGLiT93fdy_k7-
X-Proofpoint-ORIG-GUID: _ipTbYQJafJNb5rTTedGLiT93fdy_k7-


On 10/26/21 12:05 PM, Oleksandr Tyshchenko wrote:
> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>
> If memremap_pages() succeeds the range is guaranteed to have proper page
> table, there is no need for an additional virt_addr_valid() check.
>
> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>


Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>




From xen-devel-bounces@lists.xenproject.org Thu Oct 28 19:09:23 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Oct 2021 19:09:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.218256.378602 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgAlx-000636-34; Thu, 28 Oct 2021 19:09:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 218256.378602; Thu, 28 Oct 2021 19:09:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgAlw-00062z-W6; Thu, 28 Oct 2021 19:09:08 +0000
Received: by outflank-mailman (input) for mailman id 218256;
 Thu, 28 Oct 2021 19:09:07 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=dsiD=PQ=oracle.com=boris.ostrovsky@srs-us1.protection.inumbo.net>)
 id 1mgAlv-00062q-R8
 for xen-devel@lists.xenproject.org; Thu, 28 Oct 2021 19:09:07 +0000
Received: from mx0b-00069f02.pphosted.com (unknown [205.220.177.32])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 4fd5fe2f-1a45-4395-a34c-2eb3a89499a5;
 Thu, 28 Oct 2021 19:09:05 +0000 (UTC)
Received: from pps.filterd (m0246632.ppops.net [127.0.0.1])
 by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 19SIjZp1021616; 
 Thu, 28 Oct 2021 19:09:01 GMT
Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79])
 by mx0b-00069f02.pphosted.com with ESMTP id 3byja2ccdh-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Thu, 28 Oct 2021 19:08:59 +0000
Received: from pps.filterd (userp3020.oracle.com [127.0.0.1])
 by userp3020.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 19SIu2RH087373;
 Thu, 28 Oct 2021 19:08:58 GMT
Received: from nam10-dm6-obe.outbound.protection.outlook.com
 (mail-dm6nam10lp2104.outbound.protection.outlook.com [104.47.58.104])
 by userp3020.oracle.com with ESMTP id 3bx4gt97ct-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Thu, 28 Oct 2021 19:08:58 +0000
Received: from BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10)
 by BL0PR10MB2980.namprd10.prod.outlook.com (2603:10b6:208:7d::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.14; Thu, 28 Oct
 2021 19:08:56 +0000
Received: from BLAPR10MB5009.namprd10.prod.outlook.com
 ([fe80::3c49:46aa:83e1:a329]) by BLAPR10MB5009.namprd10.prod.outlook.com
 ([fe80::3c49:46aa:83e1:a329%6]) with mapi id 15.20.4649.015; Thu, 28 Oct 2021
 19:08:56 +0000
Received: from [10.74.110.188] (138.3.200.60) by
 BYAPR01CA0041.prod.exchangelabs.com (2603:10b6:a03:94::18) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4649.14 via Frontend Transport; Thu, 28 Oct 2021 19:08:54 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4fd5fe2f-1a45-4395-a34c-2eb3a89499a5
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date :
 subject : to : cc : references : from : in-reply-to : content-type :
 content-transfer-encoding : mime-version; s=corp-2021-07-09;
 bh=MF0710uZFyMs26KIjmJUd9EACMS7DQrZSFE1vH8ah9Y=;
 b=ve9DyOXfj7iinpnWGgA6SDZrMSICmDdStG3tcgXEEDmU0bfWbFnYZUBIdPwqd+YltJrB
 wC5xVBqL0jf+rkWmoJBNFgqb6phpeYQqI8Zl01rO8Bxanna3zk5KqwJu3TF1KrXd2Tm+
 /JVsp7jGeNBKUMm9o/dJLcb+ugJUcaGE72k38FTBIa8EGTBP5YZ3f+dcQtJ33Uf6YAho
 rHzFWMGgfz3spDJL0BLT7D118CJkzj7rW/cKUT03ARbBS292ryLbqklOFhqpLKcDGdyx
 8z+pE9caQgSRrl4jkY0VSfK2UMIxqHRUvA57RINvUcI1i9l+MrIV9NRwO/5WGJ0Kr/Vi 9A== 
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=cWO8yqg6Kd2e1r0umMOS2vohgtXioIbSbXdOh9YkBecBfsxjtqWRZn80/QTzDwTKDRSnbplw/7i/Ssap42OFwIKx7eyPJX+qdQkEfkdP3FGIKSsZt2xwFCmW5D2j8o82kOYhJ96YCK2fbHEuSxl6AoN+OeV22cG1LiXAWFJHq6vwwyRcRT2SXdSnOJEZ8eELqak0uTMVoqHJQT0wn7y84GVkVUhkWHK2ib6IiM+5Qc3Mw7UyoeQx3EDIEwOv/tVJJXZxzMuVXCFTPsUe9B7i2PnFxNbRA+uxnFnXJCCzUkln0c6i9/kRqSykjezl8jndoamuONgQmIK6lUdWB6dPDA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=MF0710uZFyMs26KIjmJUd9EACMS7DQrZSFE1vH8ah9Y=;
 b=AKKBSCT9pEDbN/2ivhVXYuYM58ZlXIF+MEAaFR2bFKBqJLxVFKg3n8yLMyvpnyPahcqRUZF+yi3PMno/D/mONQxZsPf4FP2/OPxAethj13qi6Zr7hVxfKe0/PRpTgwSwzqAesfWdwct7j0Pj/BwEvgG3qCv0eagqq1SPpmwCKxPdJicDk3ZWyc98jxQpsX2AMIe/bIThNPng4RHpXEJ+NdYT1nVRO79hfBL+wo3SAdqDEWbZzAUBfqAF741JZdWdrvYJSDoapuBGlyy0jqqkXcObVTzNr+6eA58+oVbY/kjQt+yJ4ejQKVlQlPRpPEia3QyOHsT5KTWTirlmKmxjiA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com;
 dkim=pass header.d=oracle.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=MF0710uZFyMs26KIjmJUd9EACMS7DQrZSFE1vH8ah9Y=;
 b=LWnRZHtmcmryH1ypUHZwekXQOXOte64U069lRGPu9G6C21foEGH+w1PHFpa8c0rCGIHAMauAnRQkfKRI3TDEy2tbSz7JMG3GWh0vB3sHJSa1NZKXQ98RHxem8K0Nk2Rg4RP3M9Za+nO2EYaAT6/eYN64LwXFCm2WG+J1ntOx1Ns=
Authentication-Results: gmail.com; dkim=none (message not signed)
 header.d=none;gmail.com; dmarc=none action=none header.from=oracle.com;
Message-ID: <0b1837f9-57ef-8deb-df78-cb7841d93d68@oracle.com>
Date: Thu, 28 Oct 2021 15:08:51 -0400
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.2.1
Subject: Re: [PATCH V2 3/4] xen/unpopulated-alloc: Add mechanism to use Xen
 resource
Content-Language: en-US
To: Oleksandr Tyshchenko <olekstysh@gmail.com>, xen-devel@lists.xenproject.org,
        linux-kernel@vger.kernel.org
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
        Juergen Gross <jgross@suse.com>,
        Stefano Stabellini
 <sstabellini@kernel.org>,
        Julien Grall <julien@xen.org>
References: <1635264312-3796-1-git-send-email-olekstysh@gmail.com>
 <1635264312-3796-4-git-send-email-olekstysh@gmail.com>
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
In-Reply-To: <1635264312-3796-4-git-send-email-olekstysh@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: BYAPR01CA0041.prod.exchangelabs.com (2603:10b6:a03:94::18)
 To BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 88bb9532-1987-45ec-6265-08d99a466389
X-MS-TrafficTypeDiagnostic: BL0PR10MB2980:
X-Microsoft-Antispam-PRVS: 
	<BL0PR10MB29805DDA338C841F5F3C8A8C8A869@BL0PR10MB2980.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8273;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 
	0OeJwAGjgf2L1aEr/iFW9CImlCIDEzFnR4N4zYGDr5XDDxTHxsCUuZuE/zoRci1ef7z9LewTOhx4bMslOmWgLJH2fct3f2nAeOuNjXDKjTKkd1K5WMpkDUrPgIRaOw4oPoLwGpSG33fUZ/d15SI7a3fd0E9RcyCrfDwfp6vLMqMsRXZKs/Qx6Ppabx8n9UgfX02dUGIN2u1t/obPsy+Y+NM2uRoZX1j9qK1AM+SGgTc+nbDlSLBFnaHVXnyeEjFWvU9Wh990oXhlJjEe+dee9ECVIwc7md+luFC5kBXQHdH4r+W2kl1zIcwoHl17QgRGHHDozpEO8KHQ0qABvqgQ8K8DlcisyQEzgIuZozvH6Z6QhfwjxSeVbLolgcnSLsaZ5BsPQNGkOzT6YztDh0LWSnvN0+R4OoHzYCW0C94xXdx7fO+sFoAs6VZvBPCQNrRQChVMy5dgOnrQ3tggeYvyhy9KaYRnC7Nnr7DBSfqFWgRkgC9MLEy7drfe3LXBYhG4+DAMVSp6BJD6WE79Ad73l3dM2OOYOe63/3ZlA4eykLMoEIaaBGQPTKbCphIpJS9AG5SdNtIltlOWhEq9uY8ieS46fXPA49XR6TIoZ/o39MzLhiqbVHQbq3M+4hZ6acxF2U30X4k/lwQvkiozOlebqVjRwZ0hekMXAnw51zYJM6bjko7oJIJWrprDk0Qvoame3HYhk49BqZkyE7+SG/Q8wQ==
X-Forefront-Antispam-Report: 
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB5009.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(508600001)(86362001)(44832011)(4744005)(8676002)(2906002)(31686004)(4326008)(316002)(6486002)(31696002)(6666004)(5660300002)(54906003)(36756003)(66476007)(186003)(66946007)(16576012)(38100700002)(66556008)(8936002)(2616005)(956004)(53546011)(26005)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?NU5jZG5KSktGNzBuZXdOaWlsK095VDVYOFppb0Uzck1HelZtY2t2a0p6bk80?=
 =?utf-8?B?b0p1aUJwSXY2cG5zc3BaanViMENjVVJtSVpCMHVHZzZFZUxNL3J2anNsMDZL?=
 =?utf-8?B?eEV4cHE0TU9HMWIxamxBbktHaU45a2lhMEdhU1BhNjhLY0NJUk9TaW9keExO?=
 =?utf-8?B?NkFYTnE0NzNsdjd3U2VpeEFjYy9sMWd0VWZtK2x1VmVQKzdORGxubXVQR0tI?=
 =?utf-8?B?bmJaZUNWNFBnVURtWUJocXhnWE5xQUZJdnowU0Y1c2pFWFFvV3V4Z3czczVo?=
 =?utf-8?B?U3FJcWI2bFUwOVNtcjc5cEtRV3JhQkxaZzhDN0JuOVo4OTErb1haL0FhYkVX?=
 =?utf-8?B?clNVUzhuaHphcmhYTFFMazUweVpLVU12UUpyaVVGaEgrOUZ3U3pwdW0zeG43?=
 =?utf-8?B?bUp5MkJ2OXRzdzFkeXBnVWZubFRUa0czeG5UTmFvRnFDdXlkRWlhalRtN0JU?=
 =?utf-8?B?YXcxTlA3QnJ2aVk5ZW5MMHhTbU5WOXo5V25aMEs2Z09nL1FQajU4ZlVDVDJS?=
 =?utf-8?B?YmRQc3gzS2hQdVNoL2hOUWtBdWhCRWV2M2lIbXZiR00xL3FhbTMrWmFSZjND?=
 =?utf-8?B?MTczTTg4MExlNzRBNDduVnBud2ljTTl1OGtFZ0lzM0VvME5TWnhxL0UwZEYv?=
 =?utf-8?B?aVFJYVpuUDZZY000MWNDS0pLcjZCRTNhTlF2dXp2MXlESDVZKzdEaTF5WE4z?=
 =?utf-8?B?cUxjOWlWa2xjQzh5d3NnOGVlTzNPYUxQZXpMYUQ3M2pyMG9WQnk0UytoSnpV?=
 =?utf-8?B?MWNlUUpMVExjMTA4YkJWVkU4RzJnQjVzZHdFSzM5Q1Y0N2xSa0VNQlJzeHU3?=
 =?utf-8?B?SnVuNUl6VHRUcXI2VzZ3bU1jQ0RNc0pTa2p0U2dPQkNwbEtZUkJ6TWsrblA0?=
 =?utf-8?B?RGhWTnZCaEs1eVlUc0NocU1kYWpmMzJkUWdSNmdPTGxoanBjdkZ6bHNuTVhm?=
 =?utf-8?B?cktlcU40ZmVLRlQyZkt4YVBtU08zMGVKbWVJUGNpejZzZ3AzOUJDMGZseUZ3?=
 =?utf-8?B?YlVobnBYLzNING52MDdOckRZeWp0Ny9aTW5CT1NJazlvVXBsYjFtL3hQMlN5?=
 =?utf-8?B?U0YzUGg3YjNiaVpMNmgyYzhTUGYwNlF6ejVOUUU0dGVPODlqZXk4ZEdYNGJI?=
 =?utf-8?B?ckFCVFdRYmZ2TEVKVzl1d0U2ZlQza0V3ZHJDdXpsbUdydUpKcURrbURqNTNx?=
 =?utf-8?B?Vzk2NHc4QlBMK3EvRk8zV21NWmNSdCtBK0o3bXRpcEpRZERldjh3SndQN1hp?=
 =?utf-8?B?SjZ2WkxJRGJRMll3RFVQZ284dmFrMFlkMkJoRjBOYXhpRlhWbGRDUFZkTjhw?=
 =?utf-8?B?MThkL2k4ME9IU3libTUranhuakdwNUhjSHdlNDZmTC9tTFRLNDZ1Z3RmTEpa?=
 =?utf-8?B?aXlpSnBodEVpMzFSZW9zaVlHM2daSE51UlNwaG53ajhSa1UvUEF2VEdRT25V?=
 =?utf-8?B?c2VvUy9TaDMvOWpTRzZLVVdrRExucUowanVQYUt2eHR6UWtZL01MM0VqUG9Q?=
 =?utf-8?B?V1RlZGcxQ0RBeEc4T2ROek9STUVhYzBwQzhxV2Q0ZGhtK3lJM1RmQm1xTXFR?=
 =?utf-8?B?U2s5dTFkT3NTVU9IdGdpdmFMZHNsbXdUMGNrcHc4dlk0SmVsMi9tSWUxbmdO?=
 =?utf-8?B?aGpucU9zVkFNQ05ZZVhHOWttMnZxdi9QRHBidzIxN0pVQ3VxdTlyU0dIZ0Nv?=
 =?utf-8?B?VENwZk9nc0ovYmg5Rk5CNWFqbWpSVE9EdFNhcnVLd3ZrQ0tYODErS21BODE1?=
 =?utf-8?B?QWxSdElDZDd5OE8yK296YzFiV3NNa1lKR1ZmQitHa3FYbmJHTER2a3AweS95?=
 =?utf-8?B?Wll6M21aN3VGTUNtTnY3Z2tSWE5oRmgwUUI5Y1g1dW1meUc3enZ1UGgyaUZ5?=
 =?utf-8?B?MUJUZi9vdTBWSmM2aTZyNkVTVWNhYjVzWlBhbUR6aTQ1cjZzWGRvdGZ4aUlF?=
 =?utf-8?B?N1NHcGV4Y0M1VW9QSXl3NytLVUxGWmEzWDdUaVRZbks5Yy9WdmQrVU0zakM2?=
 =?utf-8?B?NU9LOU0rVkt5d3lIVnVpbHNJelk4Wmp5YklrUXV1YVdaWm9UaXkveEM0enU5?=
 =?utf-8?B?Vlk3WU92SkpYaTFTSnVFeXdOUUR4dzYrbmpkcWtLd1RoRjFNVm9EWTIxZmk2?=
 =?utf-8?B?L1pxMGw3a3krWXNNNTh6UWx0cnF2RlQ3MjlycXlEdzJDczNRQmNRZVBnYnZq?=
 =?utf-8?B?RURocUZNR1liQmk1VktKaUZqUHJhdk9iY0R6eE5QVWFLQWJKamhuSjNZS3dC?=
 =?utf-8?Q?6phB7HTmS99wQBboBnLDhg0xceDPaKyJqz9EoC/vG8=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 88bb9532-1987-45ec-6265-08d99a466389
X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Oct 2021 19:08:55.9624
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8nnkcjxKWK0q00HGxr4/be0nFfL3PS1gE1U+k7NuJWAh5LpvdIAsXQQmgCSFUdmXvTA4IvgN1HlrtpQv1Bl3J0V1ZftqDgxRXU30hXP6B7U=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR10MB2980
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10151 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 malwarescore=0
 adultscore=0 suspectscore=0 bulkscore=0 mlxscore=0 spamscore=0
 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2110280099
X-Proofpoint-GUID: HKPxr1Rf9kkDtqz470HThbNiVPGDYUBf
X-Proofpoint-ORIG-GUID: HKPxr1Rf9kkDtqz470HThbNiVPGDYUBf


On 10/26/21 12:05 PM, Oleksandr Tyshchenko wrote:
>   
> +static void unpopulated_init(void)
> +{
> +	static bool inited = false;
> +	int ret;
> +
> +	if (inited)
> +		return;
> +
> +	/*
> +	 * Try to initialize Xen resource the first and fall back to default
> +	 * resource if arch doesn't offer one.
> +	 */
> +	ret = arch_xen_unpopulated_init(&xen_resource);
> +	if (!ret)
> +		target_resource = &xen_resource;
> +	else if (ret == -ENOSYS)
> +		target_resource = &iomem_resource;
> +	else
> +		pr_err("Cannot initialize Xen resource\n");


I'd pass target_resource as a parameter to arch_xen_unpopulated_init() instead. Default routine will assign it iomem_resource and you won't have to deal with -ENOSYS.


Also, what happens in case of error? Is it fatal? I don't think your changes in fill_list() will work.


> +
> +	inited = true;


I agree with Stefano in that it would be better to call this from an init function, and you won't have t worry about multiple calls here.


-boris


From xen-devel-bounces@lists.xenproject.org Thu Oct 28 20:02:04 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Oct 2021 20:02:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.218267.378614 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgBav-0003yK-4h; Thu, 28 Oct 2021 20:01:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 218267.378614; Thu, 28 Oct 2021 20:01:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgBav-0003yD-0F; Thu, 28 Oct 2021 20:01:49 +0000
Received: by outflank-mailman (input) for mailman id 218267;
 Thu, 28 Oct 2021 20:01:47 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mgBat-0003y3-Iu; Thu, 28 Oct 2021 20:01:47 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mgBat-0007Ab-CV; Thu, 28 Oct 2021 20:01:47 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mgBat-0003mr-0O; Thu, 28 Oct 2021 20:01:47 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mgBas-0006aI-Uh; Thu, 28 Oct 2021 20:01:46 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=3NHtPZUsqNYYBJm4zESGEXE66LPfTPIP6Ks/fDKf7as=; b=EHKA0Rc12Hxgub0lpjIDVNXpCE
	/d9Uu/49Zy9Vz5MjBIxiQIQWzkHQUywT5aFrg3iPFAfXgdtRlOjg46Wj7LC2CAxiz/SvZFFpyuGiI
	9/gtsBwv6cXQaYzETs66mxhryLZA8Uy/7qx+4EUmI6w0bsJBZx0aGnzRDuAvtAaAGAo0=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165924-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 165924: tolerable FAIL
X-Osstest-Failures:
    xen-unstable:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    xen-unstable:test-amd64-amd64-examine:memdisk-try-append:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=c91c967f329f866b1826b04e73e32aea936930cd
X-Osstest-Versions-That:
    xen=c91c967f329f866b1826b04e73e32aea936930cd
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 28 Oct 2021 20:01:46 +0000

flight 165924 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165924/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail in 165919 pass in 165924
 test-amd64-amd64-examine      4 memdisk-try-append         fail pass in 165919

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 165919
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 165919
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165919
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165919
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 165919
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 165919
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 165919
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 165919
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 165919
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 165919
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 165919
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165919
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 xen                  c91c967f329f866b1826b04e73e32aea936930cd
baseline version:
 xen                  c91c967f329f866b1826b04e73e32aea936930cd

Last test of basis   165924  2021-10-28 12:15:42 Z    0 days
Testing same since                          (not found)         0 attempts

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Published tested tree is already up to date.



From xen-devel-bounces@lists.xenproject.org Thu Oct 28 20:17:19 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Oct 2021 20:17:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.218277.378628 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgBpk-0005ix-Jh; Thu, 28 Oct 2021 20:17:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 218277.378628; Thu, 28 Oct 2021 20:17:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgBpk-0005iq-F7; Thu, 28 Oct 2021 20:17:08 +0000
Received: by outflank-mailman (input) for mailman id 218277;
 Thu, 28 Oct 2021 20:17:07 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=9gJ2=PQ=invisiblethingslab.com=marmarek@srs-us1.protection.inumbo.net>)
 id 1mgBpj-0005ik-3E
 for xen-devel@lists.xenproject.org; Thu, 28 Oct 2021 20:17:07 +0000
Received: from out3-smtp.messagingengine.com (unknown [66.111.4.27])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 051323d6-382c-11ec-84b7-12813bfff9fa;
 Thu, 28 Oct 2021 20:17:05 +0000 (UTC)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id 707855C00D4;
 Thu, 28 Oct 2021 16:17:05 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute1.internal (MEProxy); Thu, 28 Oct 2021 16:17:05 -0400
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu,
 28 Oct 2021 16:17:03 -0400 (EDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 051323d6-382c-11ec-84b7-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:content-type:date:from:in-reply-to
	:message-id:mime-version:references:subject:to:x-me-proxy
	:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=5lHMBp
	j8jcGhebPQpTOYiDXSyqlgx4IThAJ8eNFDX74=; b=EdZx+kAdnMwb+jYdhFSU3e
	bjAyzKrEqfJWbH8NMq+8P3rgLpwXXxothhyPrsrrB7FijmdAiE3kTdiSaL6ELrkT
	6usso22/FeGG99cGO+Ph93+EJpvTpQEcnJWoyivkRRkiZJjj6bA2Urq20u3f9cQw
	+IvnaGABJKbPCBezGm7NpTY8bqaMWPNpXN/HHIFM98l8qNxwoZQ6l3u7F9rwv6Py
	GPv0hTLLcRhCHj9+tPx3DpKtsBAqWRuVhYW1Wq7M11DTUCSjWnFDxMGzlF66hdW4
	w9438SdXzq3mTqfgWTnu9KpP07Ew1QKyAlYDPTmcGg1cVmBANbfP2ugyf6TB7VxQ
	==
X-ME-Sender: <xms:QAV7YaVQwb3n3EJGIi7y8xDS1Rk2gH8TrVPUPUbbaye6nO6xKmU2Eg>
    <xme:QAV7YWmw1S9CbPYM1-onq01RVYnW7vZSfKrLuRH60K-8MrKJLtvK2PkfFH2aVtqTp
    17Q_xzmNLOWSw>
X-ME-Received: <xmr:QAV7YebKpgB9bhmmBy4NhwiDaQWekCU4YL0Ph_3uPTZGxAtrB0bP6JkMkdldR8PPR712_MZzK0Uy411HqXthWPqY8QAiQSu9>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrvdegvddgheelucetufdoteggodetrfdotf
    fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
    uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
    cujfgurhepfffhvffukfhfgggtuggjsehgtderredttdejnecuhfhrohhmpeforghrvghk
    ucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesihhnvh
    hishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpeetveff
    iefghfekhffggeeffffhgeevieektedthfehveeiheeiiedtudegfeetffenucevlhhush
    htvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrghrmhgrrhgvkhes
    ihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm
X-ME-Proxy: <xmx:QAV7YRV0Oua-q3Zjs057wE7yKHqDWdUI3tbpTUwc6BMpV1i2JE1-UQ>
    <xmx:QAV7YUkPzgCHsZyTaE0evbjrq6ZnLHs93XsSdDZTAeT37FFyJlByow>
    <xmx:QAV7YWe0ql_7UYnHIDd4q7YBe4rnnYKXqVi5d6ik6-AR2LhprXlU1w>
    <xmx:QQV7YeifmEzqBzluQBehlZzliUIALZsSO2Ifp7GSY2Wd20N9sbQ5DQ>
Date: Thu, 28 Oct 2021 22:16:59 +0200
From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
To: Juergen Gross <jgross@suse.com>
Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>, stable@vger.kernel.org
Subject: Re: [PATCH] xen/balloon: add late_initcall_sync() for initial
 ballooning done
Message-ID: <YXsFO2TMRiJTQM2q@mail-itl>
References: <20211028105952.10011-1-jgross@suse.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="E2YpY0crIIXSHyLi"
Content-Disposition: inline
In-Reply-To: <20211028105952.10011-1-jgross@suse.com>


--E2YpY0crIIXSHyLi
Content-Type: text/plain; protected-headers=v1; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Date: Thu, 28 Oct 2021 22:16:59 +0200
From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
To: Juergen Gross <jgross@suse.com>
Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>, stable@vger.kernel.org
Subject: Re: [PATCH] xen/balloon: add late_initcall_sync() for initial
 ballooning done

On Thu, Oct 28, 2021 at 12:59:52PM +0200, Juergen Gross wrote:
> When running as PVH or HVM guest with actual memory < max memory the
> hypervisor is using "populate on demand" in order to allow the guest
> to balloon down from its maximum memory size. For this to work
> correctly the guest must not touch more memory pages than its target
> memory size as otherwise the PoD cache will be exhausted and the guest
> is crashed as a result of that.
>=20
> In extreme cases ballooning down might not be finished today before
> the init process is started, which can consume lots of memory.
>=20
> In order to avoid random boot crashes in such cases, add a late init
> call to wait for ballooning down having finished for PVH/HVM guests.
>=20
> Cc: <stable@vger.kernel.org>
> Reported-by: Marek Marczykowski-G=C3=B3recki <marmarek@invisiblethingslab=
=2Ecom>
> Signed-off-by: Juergen Gross <jgross@suse.com>

It may happen that initial balloon down fails (state=3D=3DBP_ECANCELED). In
that case, it waits indefinitely. I think it should rather report a
failure (and panic? it's similar to OOM before PID 1 starts, so rather
hard to recover), instead of hanging.

Anyway, it does fix the boot crashes.

> ---
>  drivers/xen/balloon.c | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
>=20
> diff --git a/drivers/xen/balloon.c b/drivers/xen/balloon.c
> index 3a50f097ed3e..d19b851c3d3b 100644
> --- a/drivers/xen/balloon.c
> +++ b/drivers/xen/balloon.c
> @@ -765,3 +765,23 @@ static int __init balloon_init(void)
>  	return 0;
>  }
>  subsys_initcall(balloon_init);
> +
> +static int __init balloon_wait_finish(void)
> +{
> +	if (!xen_domain())
> +		return -ENODEV;
> +
> +	/* PV guests don't need to wait. */
> +	if (xen_pv_domain() || !current_credit())
> +		return 0;
> +
> +	pr_info("Waiting for initial ballooning down having finished.\n");
> +
> +	while (current_credit())
> +		schedule_timeout_interruptible(HZ / 10);
> +
> +	pr_info("Initial ballooning down finished.\n");
> +
> +	return 0;
> +}
> +late_initcall_sync(balloon_wait_finish);
> --=20
> 2.26.2
>=20

--=20
Best Regards,
Marek Marczykowski-G=C3=B3recki
Invisible Things Lab

--E2YpY0crIIXSHyLi
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmF7BTsACgkQ24/THMrX
1yyExQf8C+Zlijc1idL0I+sDb62ywXLbZxjsytrZOhBRNZO84RpHwSdxw1Q3Nbpq
KWfXMw4PJX6IWvACg4Oy7VVfpXR/6/pZLJStFl4j8iPha+gF5kph2uFwQhHbNjSO
kk3E9UIQpwLHNixP4CPG5Aa74Ta8Seth7Fl63JpYc4H0eR4rwwEL2ifOz73ElBEK
VpMxsPf/20XEHITTeluwxv/otMuZtBok9ZEC5irOmOfkghwVJ855dcBYk+FSFlX3
+1ZKbB+CU0SOkqnEjSBjlctJl9awkdpKD8voE1IjMDSDdGcDHE50MSjQdfZqtWF6
Ehku7nMKd8rRz8Xz1pwE3+3Ny2SlDw==
=4WvB
-----END PGP SIGNATURE-----

--E2YpY0crIIXSHyLi--


From xen-devel-bounces@lists.xenproject.org Thu Oct 28 20:31:38 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Oct 2021 20:31:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.218284.378639 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgC3X-00087l-MP; Thu, 28 Oct 2021 20:31:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 218284.378639; Thu, 28 Oct 2021 20:31:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgC3X-00087e-J1; Thu, 28 Oct 2021 20:31:23 +0000
Received: by outflank-mailman (input) for mailman id 218284;
 Thu, 28 Oct 2021 20:31:22 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=TkaK=PQ=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1mgC3W-00087Y-A8
 for xen-devel@lists.xenproject.org; Thu, 28 Oct 2021 20:31:22 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 0291f0a4-382e-11ec-84b7-12813bfff9fa;
 Thu, 28 Oct 2021 20:31:20 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id CEFE261056;
 Thu, 28 Oct 2021 20:31:19 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0291f0a4-382e-11ec-84b7-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1635453080;
	bh=XamYXyG57QYjFkoR5cUPTY/8giiUqlew45mR4jt4c3w=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=UrnIspJWeeB+yd1bf/ws0+/rvyrlTk7JX4cN0wEx8TWGz1jaIImJEapKJYhBX7si5
	 c6wZzznEkgOSCDqU/PHyCw9lI12VFlZi0vpIqFIqzQJeMRQb+wXmOLgGWnbwWNj4du
	 REC507rzAiN3Dih1Iw9wr/rbvmyoJfRYBbp6y5PAYMvYgxpx0GMMAaRdoc1ZI763cq
	 gvAgCQwjoDlFSWyKb8HQOCgkDdsBO5MbFOVNXIvewcDEMMGaemdU1Iq6BEuQ4Atp9C
	 zqzIbnB8PS1O4N6PaSZqdMH4xZYdOCoSf2r21xvQb2H3JBRVT3pDNKzHiZ5CduTYiL
	 YxUGpv0vHgNcw==
Date: Thu, 28 Oct 2021 13:31:18 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Julien Grall <julien@xen.org>
cc: Stefano Stabellini <sstabellini@kernel.org>, 
    Julien Grall <julien.grall.oss@gmail.com>, 
    Michal Orzel <michal.orzel@arm.com>, 
    xen-devel <xen-devel@lists.xenproject.org>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, 
    Bertrand Marquis <bertrand.marquis@arm.com>, 
    Ian Jackson <iwj@xenproject.org>
Subject: Re: [patch-4.16] arm/smmuv1,v2: Protect smmu master list with a
 lock
In-Reply-To: <4554621d-63da-ea3e-e56a-4e01d0cef347@xen.org>
Message-ID: <alpine.DEB.2.21.2110281311030.20134@sstabellini-ThinkPad-T480s>
References: <20211026122903.15042-1-michal.orzel@arm.com> <e5632a4e-db98-41b4-1045-2b3532c098fa@xen.org> <70c30a6c-b779-805e-079a-41bb484894b9@xen.org> <cb452c0c-ccde-7798-c403-f972b48a2c46@arm.com> <01545115-e82e-2a9d-a8e4-da9676080c0f@xen.org>
 <alpine.DEB.2.21.2110271557570.20134@sstabellini-ThinkPad-T480s> <CAJ=z9a2SSgG7a87_xTGT5LeNLgubOLQf1+dbnrsTsP8_p5ErJg@mail.gmail.com> <alpine.DEB.2.21.2110271658330.20134@sstabellini-ThinkPad-T480s> <4554621d-63da-ea3e-e56a-4e01d0cef347@xen.org>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: multipart/mixed; BOUNDARY="8323329-345338608-1635451899=:20134"
Content-ID: <alpine.DEB.2.21.2110281311590.20134@sstabellini-ThinkPad-T480s>

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-345338608-1635451899=:20134
Content-Type: text/plain; CHARSET=UTF-8
Content-Transfer-Encoding: 8BIT
Content-ID: <alpine.DEB.2.21.2110281311591.20134@sstabellini-ThinkPad-T480s>

On Thu, 28 Oct 2021, Julien Grall wrote:
> Hi Stefano,
> 
> First apologies for sending the previous e-mails in HTML (thanks for pointing
> that out!).
> 
> On 28/10/2021 01:20, Stefano Stabellini wrote:
> > On Thu, 28 Oct 2021, Julien Grall wrote:
> > > On Thu, 28 Oct 2021, 00:14 Stefano Stabellini, <sstabellini@kernel.org>
> > > wrote:
> > >        On Wed, 27 Oct 2021, Julien Grall wrote:
> > >        > > > > > +    return ret;
> > >        > > > > >    }
> > >        > > > > >    static int register_smmu_master(struct arm_smmu_device
> > > *smmu,
> > >        > > > > > @@ -2056,7 +2066,10 @@ static int
> > > arm_smmu_add_device(struct device
> > >        > > > > > *dev)
> > >        > > > > >        } else {
> > >        > > > > >            struct arm_smmu_master *master;
> > >        > > > > > +        spin_lock(&arm_smmu_devices_lock);
> > >        > > > > >            master = find_smmu_master(smmu, dev->of_node);
> > >        > > > > > +        spin_unlock(&arm_smmu_devices_lock);
> > >        > > > >
> > >        > > > > At the moment, unlocking here is fine because we don't
> > > remove the
> > >        > > > > device. However, there are a series to supporting removing
> > > a device (see
> > >        > > > > [1]). So I think it would be preferable to unlock after the
> > > last use of
> > >        > > > > 'cfg'.
> > >        > > > >
> > >        > > Ok. I will move unlocking to the end of this else {} block. I
> > > was not aware
> > >        > > of the patch you are referring to.
> > >        >
> > >        > I think the end of the else is still too early. This needs to at
> > > least be past
> > >        > iommu_group_set_iommudata() because we store cfg.
> > >        >
> > >        > Potentially, the lock wants to also englobe
> > > arm_smmu_master_alloc_smes(). So I
> > >        > am wondering whether it would be simpler to hold the lock for the
> > > whole
> > >        > duration of arm_smmu_add_device() (I can see value when we will
> > > want to
> > >        > interlock with the remove code).
> > > 
> > >        The patch was to protect the smmu master list. From that point of
> > > view
> > >        the unlock right after find_smmu_master would be sufficient, right?
> > > 
> > > 
> > > Yes. However this is not fixing all the problems (see below).
> > > 
> > > 
> > >        We only need to protect cfg if we are worried that the same device
> > > is
> > >        added in two different ways at the same time. Did I get it right?
> > > If so,
> > >        I would say that that case should not be possible? Am I missing
> > > another
> > >        potential conflict?
> > > 
> > > 
> > > It should not be possible to add the same device twice. The problem is
> > > more when we are going to remove the device. In this case, "master"
> > > may disappear at any point.
> > > 
> > > The support for removing device is not yet implemented in the tree. But
> > > there is already a patch on the ML. So I think it would be
> > > shortsighted to only move the lock to just solve concurrent access to the
> > > list.
> >   That makes sense now: the other source of conflict is concurrent add and
> > remove of the same device. Sorry it wasn't clear to me before.
> At the moment, we are relying on the upper layer (e.g. PCI or DT subsystem) to
> prevent concurrent add/remove/assignment. The trouble is we don't have a
> common lock between PCI and DT.
> 
> One possibility would be to add a common in the uper layer, but it feels to me
> this is a bit fragile and may also require longer locking section than
> necessary.
> 
> That said, add/remove/assignment operations are meant to be rare. So this is
> could be an option. This would also have the advantage to cover all the
> IOMMUs.
> 
> >     
> > >        I am pointing this out for two reasons:
> > > 
> > >        Protecting the list is different from protecting each element from
> > >        concurrent modification of the element itself. If the latter is a
> > >        potential problem, I wonder if arm_smmu_add_device is the only
> > > function
> > >        affected?
> > > 
> > > 
> > > I had a brief looked at the code and couldn't find any other places where
> > > this may be an issue.
> > > 
> > > 
> > >        The second reason is that extending the lock past
> > >        arm_smmu_master_alloc_smes is a bit worrying because it causes
> > >        &arm_smmu_devices_lock and smmu->stream_map_lock to nest, which
> > > wasn't
> > >        the case before.
> > > 
> > > 
> > > Nested locks are common. I don't believe there would be a problem here
> > > with this one.
> > > 
> > > 
> > >        I am not saying that it is a bad idea to extend the lock past
> > >        arm_smmu_master_alloc_smes -- it might be the right thing to do.
> > > 
> > > 
> > > I don't usually suggest locking changes blindly ;).
> > > 
> > >        But I
> > > 
> > >        am merely saying that it might be best to think twice about it.
> > > 
> > >        and/or do
> > >        that after 4.16.
> > > 
> > > 
> 
> [...]
> 
> > The other thing that is not clear to me is whether we would need also to
> > protect places where we use (not allocate) masters and/or cfg, e.g.
> > arm_smmu_attach_dev, arm_smmu_domain_add_master.
> 
> I think both should be with the lock. Now the question is will other IOMMUs
> driver requires the same locking?
> 
> If yes, then maybe that locking should be in the common code.
> 
> > > That said we can work towards a new locking approach for 4.17.
> > > However, I would want to have a proposal from your side or at least
> > > some details on why the suggested locking is not suitable.
> >   The suggested locking approach up until the last suggestion looks
> > totally fine to me. The last suggestion is a bit harder to tell because
> > the PCI removal hook is not there yet, so I am having troubles seeing
> > exactly what needs to be protected.
> 
> The PCI removal hook is the same as the platform device one. There are already
> a patch on the ML (see [1]) for that.
> 
> We have two interlocking problem to resolve:
>   1) Concurrent request between PCI and platform/DT subsystem
>   2) Removal vs add vs (re)assign
> 
> The two approaches I can think of are:
> 
> Approach A:
>   - The driver is responsible to protect against 1)
>   - Each subsystem (DT and PCI) are responsible for 2)
> 
> Approach B:
>   The driver is responsible to protect for 1) 2).
> 
> From my understanding, the proposed patch for Michal is following approach A
> whilst my proposal is going towards approach B.
> 
> I am open to use approach A, however I think this needs to be documented as
> the lock to use will depend on whether the device is a PCI device or not.

Thanks for the explanation, now everything is a lot clearer. I don't
have feedback on approach A vs. B -- it looks like both could work well.

In regards to this specific patch and also the conversation about 4.16
or 4.17: I think it would be fine to take this patch in 4.16 in its
current form. Although it is not required because PCI passthrough is
not going to be complete in 4.16 anyway, I like that this patch makes
the code consistent in terms of protection of rbtree accesses.  With
this patch the arm_smmu_master rbtree is consistently protected from
concurrent accesses. Without this patch, it is sometimes protected and
sometimes not, which is not great.

So I think that is something that could be good to have in 4.16. But
like you said, the patch is not strictly required so it is fine either
way.

Other changes on top of it, e.g. a complete implementation of Approach A
or Approach B, I think it would be best to target 4.17 so that we can
evaluate them together with the other outstanding PCI patches. I think
it would make the review a lot easier (at least for me.)
--8323329-345338608-1635451899=:20134--


From xen-devel-bounces@lists.xenproject.org Thu Oct 28 21:08:23 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Oct 2021 21:08:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.218291.378649 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgCcm-0003Fo-E3; Thu, 28 Oct 2021 21:07:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 218291.378649; Thu, 28 Oct 2021 21:07:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgCcm-0003Fh-B9; Thu, 28 Oct 2021 21:07:48 +0000
Received: by outflank-mailman (input) for mailman id 218291;
 Thu, 28 Oct 2021 21:07:46 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=TkaK=PQ=kernel.org=sstabellini@srs-us1.protection.inumbo.net>)
 id 1mgCck-0003FY-SI
 for xen-devel@lists.xenproject.org; Thu, 28 Oct 2021 21:07:46 +0000
Received: from mail.kernel.org (unknown [198.145.29.99])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 18caf938-3833-11ec-84b9-12813bfff9fa;
 Thu, 28 Oct 2021 21:07:45 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id 8631D60F02;
 Thu, 28 Oct 2021 21:07:44 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 18caf938-3833-11ec-84b9-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1635455264;
	bh=ETP106AJ5Wm/QlV2E9AF5Sl7aujUTPXDcEd7droTXpA=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=ENOatHPSvUGJdwE1pLHko9V38A3aptvBP/gTFTGEMx9AO1JjGzNEF3w7lKBjiXZta
	 Zwu0cwc7kCJVHz0sAII2dV7wWl5SUvu+NdhoUlHFf3835CCwUETZ9ypkFyOVv7he+q
	 pAn2QBzZcfyez3aCp9dyy3vlOQ+EydEF1y2Wb302byI0PObE4uEVirkio3yRTR5CTI
	 7QSBmX45J9MKbfRsS2dPhlQUd+Se0UqQ21LC5PSTQUGNbBxzz27bOjs99dkvrW4Sxn
	 2P0NpFqpSLMMx5Jd0uEhUxYilq+EaL+CNqt6CbSo93LPsdTBD5eeH9OdhNNZR6EGWh
	 dv5SNnUlTgBNA==
Date: Thu, 28 Oct 2021 14:07:43 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s
To: Dongli Zhang <dongli.zhang@oracle.com>
cc: xen-devel@lists.xenproject.org, sstabellini@kernel.org, julien@xen.org, 
    Volodymyr_Babchuk@epam.com, andrew.cooper3@citrix.com, 
    george.dunlap@citrix.com, iwj@xenproject.org, jbeulich@suse.com, 
    wl@xen.org, joe.jin@oracle.com
Subject: Re: [PATCH v2 1/1] xen: update system time immediately when
 VCPUOP_register_vcpu_info
In-Reply-To: <20211025173523.3647-1-dongli.zhang@oracle.com>
Message-ID: <alpine.DEB.2.21.2110281406550.20134@sstabellini-ThinkPad-T480s>
References: <20211025173523.3647-1-dongli.zhang@oracle.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Mon, 25 Oct 2021, Dongli Zhang wrote:
> The guest may access the pv vcpu_time_info immediately after
> VCPUOP_register_vcpu_info. This is to borrow the idea of
> VCPUOP_register_vcpu_time_memory_area, where the
> force_update_vcpu_system_time() is called immediately when the new memory
> area is registered.
> 
> Otherwise, we may observe clock drift at the VM side if the VM accesses
> the clocksource immediately after VCPUOP_register_vcpu_info().
> 
> Reference:
> https://lists.xenproject.org/archives/html/xen-devel/2021-10/msg00571.html
> Cc: Joe Jin <joe.jin@oracle.com>
> Signed-off-by: Dongli Zhang <dongli.zhang@oracle.com>
> ---
> Changed since v1:
>   - Implement force_update_vcpu_system_time() for ARM
>     (suggested by Jan Beulich)
>     While I have tested ARM compilation with aarch64-linux-gnu-gcc, I did
>     not test on ARM platform.

This is fine. Of course it is not going to do anything on ARM given that
update_vcpu_system_time in unimplemented but it is certainly harmless.

For the ARM part:
Acked-by: Stefano Stabellini <sstabellini@kernel.org>


>  xen/arch/arm/time.c        | 5 +++++
>  xen/common/domain.c        | 2 ++
>  xen/include/asm-arm/time.h | 2 ++
>  3 files changed, 9 insertions(+)
> 
> diff --git a/xen/arch/arm/time.c b/xen/arch/arm/time.c
> index 7dbd363537..dec53b5f7d 100644
> --- a/xen/arch/arm/time.c
> +++ b/xen/arch/arm/time.c
> @@ -351,6 +351,11 @@ void update_vcpu_system_time(struct vcpu *v)
>      /* XXX update shared_info->wc_* */
>  }
>  
> +void force_update_vcpu_system_time(struct vcpu *v)
> +{
> +    update_vcpu_system_time(v);
> +}
> +
>  void domain_set_time_offset(struct domain *d, int64_t time_offset_seconds)
>  {
>      d->time_offset.seconds = time_offset_seconds;
> diff --git a/xen/common/domain.c b/xen/common/domain.c
> index 8b53c49d1e..d71fcab88c 100644
> --- a/xen/common/domain.c
> +++ b/xen/common/domain.c
> @@ -1704,6 +1704,8 @@ long do_vcpu_op(int cmd, unsigned int vcpuid, XEN_GUEST_HANDLE_PARAM(void) arg)
>          rc = map_vcpu_info(v, info.mfn, info.offset);
>          domain_unlock(d);
>  
> +        force_update_vcpu_system_time(v);
> +
>          break;
>      }
>  
> diff --git a/xen/include/asm-arm/time.h b/xen/include/asm-arm/time.h
> index 6b8fd839dd..4b401c1110 100644
> --- a/xen/include/asm-arm/time.h
> +++ b/xen/include/asm-arm/time.h
> @@ -105,6 +105,8 @@ extern uint64_t ns_to_ticks(s_time_t ns);
>  
>  void preinit_xen_time(void);
>  
> +void force_update_vcpu_system_time(struct vcpu *v);
> +
>  #endif /* __ARM_TIME_H__ */
>  /*
>   * Local variables:
> -- 
> 2.17.1
> 


From xen-devel-bounces@lists.xenproject.org Thu Oct 28 21:32:50 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Oct 2021 21:32:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.218298.378661 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgD0t-0006dF-8p; Thu, 28 Oct 2021 21:32:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 218298.378661; Thu, 28 Oct 2021 21:32:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgD0t-0006d8-4y; Thu, 28 Oct 2021 21:32:43 +0000
Received: by outflank-mailman (input) for mailman id 218298;
 Thu, 28 Oct 2021 21:32:42 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=CzqG=PQ=gmail.com=digetx@srs-us1.protection.inumbo.net>)
 id 1mgD0s-0006d2-LE
 for xen-devel@lists.xenproject.org; Thu, 28 Oct 2021 21:32:42 +0000
Received: from mail-lj1-x234.google.com (unknown [2a00:1450:4864:20::234])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id ae7fa489-5528-4c65-a2fb-02d53d40de71;
 Thu, 28 Oct 2021 21:32:41 +0000 (UTC)
Received: by mail-lj1-x234.google.com with SMTP id 1so7141681ljv.2
 for <xen-devel@lists.xenproject.org>; Thu, 28 Oct 2021 14:32:41 -0700 (PDT)
Received: from [192.168.2.145] (46-138-44-18.dynamic.spd-mgts.ru.
 [46.138.44.18])
 by smtp.googlemail.com with ESMTPSA id bi14sm474384lfb.290.2021.10.28.14.32.38
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Thu, 28 Oct 2021 14:32:39 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ae7fa489-5528-4c65-a2fb-02d53d40de71
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-language:content-transfer-encoding;
        bh=FNhb8m0Up8WrlODFU5XusWNjgw7FYM5tGcizMhHIPzY=;
        b=USVIOuLFNftY9TSlAv8GQB7acWI1sWWXinRBTyt58drm2RaLh5La11nG4ixMTMewfR
         mX32BgQ2N30EhppM8q0HGzyhqJFMUCJMnblCfs4t5KonQ44KE0wlYv2W8rFYqs4V2koj
         XX371v1ONZUx01vnBeB6kBqd5XtkGxjVTj1e6iP0L3n7qnRFNsZrpRBj/O9TAqf3J13f
         DVFT1FMABW5ltJOUpFKPkQHX+APbXjkM1X+NMw4LCmok7h64fUY8hoIatZpEbYmauo9R
         3tzIe6iUnZRzMnNPnMBZ+KjZo2BGgmZ8KUvvaXZMV9Llm3C259zfQ4YRn+8CQPkkCOFN
         RJzA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-language
         :content-transfer-encoding;
        bh=FNhb8m0Up8WrlODFU5XusWNjgw7FYM5tGcizMhHIPzY=;
        b=Oldo3Bdz2L/QQAAYffRTtq+Tv/lZqB0WTDaH+2xGR1XUVXOyMflqX37wPx11jLKGjW
         o+olBh/5Yl86GqcM02JAmN9TaOaDBQwVIgUxcXeCxEStBM6+s77jAAFU826oL0Mon17+
         FBnehB1Ui9zX5/qi0qVx/iD/dNuYWE6K5qv7KBifejac2MMX+UTW/3M6xXreEWvXYcxN
         EfmL9ijiUvSZSRK4gxvZebcBd38pr0laPLAyCxK/sSmqgF3SAhNr1VlsHkSlK4gwLQSy
         tlEv4SATBi5TUF4UcbkC18XMcups/0S8SuZfJXqawXZo2r3SmMgI6XfMkjKoqQVaEbHU
         7FJw==
X-Gm-Message-State: AOAM531HVdjQ3MfBgL/HEPAV8PWG4MGBojhkqcmLeyTuqGbKxoD9SZDZ
	/e4bfPEGuAUDlMbZZkGKP5w=
X-Google-Smtp-Source: ABdhPJwcWGds1J/UVngHunSwfN7ztb9W9OVxlAX827dktWLGe1JrS01AY9nWnDg96vqg3wWMmL+l6Q==
X-Received: by 2002:a2e:9b0e:: with SMTP id u14mr7220400lji.247.1635456760396;
        Thu, 28 Oct 2021 14:32:40 -0700 (PDT)
Subject: Re: [PATCH v2 03/45] notifier: Add
 atomic/blocking_notifier_has_unique_priority()
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Thierry Reding <thierry.reding@gmail.com>,
 Jonathan Hunter <jonathanh@nvidia.com>, Lee Jones <lee.jones@linaro.org>,
 "Rafael J . Wysocki" <rafael@kernel.org>, Mark Brown <broonie@kernel.org>,
 Andrew Morton <akpm@linux-foundation.org>, Guenter Roeck
 <linux@roeck-us.net>, Russell King <linux@armlinux.org.uk>,
 Daniel Lezcano <daniel.lezcano@linaro.org>,
 Ulf Hansson <ulf.hansson@linaro.org>,
 Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will@kernel.org>,
 Guo Ren <guoren@kernel.org>, Geert Uytterhoeven <geert@linux-m68k.org>,
 Greg Ungerer <gerg@linux-m68k.org>, Joshua Thompson <funaho@jurai.org>,
 Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
 Nick Hu <nickhu@andestech.com>, Greentime Hu <green.hu@gmail.com>,
 Vincent Chen <deanbo422@gmail.com>,
 "James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
 Helge Deller <deller@gmx.de>, Michael Ellerman <mpe@ellerman.id.au>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 Paul Mackerras <paulus@samba.org>, Paul Walmsley <paul.walmsley@sifive.com>,
 Palmer Dabbelt <palmer@dabbelt.com>, Albert Ou <aou@eecs.berkeley.edu>,
 Yoshinori Sato <ysato@users.sourceforge.jp>, Rich Felker <dalias@libc.org>,
 Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
 Borislav Petkov <bp@alien8.de>, Dave Hansen <dave.hansen@linux.intel.com>,
 x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
 Boris Ostrovsky <boris.ostrovsky@oracle.com>, Juergen Gross
 <jgross@suse.com>, Stefano Stabellini <sstabellini@kernel.org>,
 Len Brown <lenb@kernel.org>, Santosh Shilimkar <ssantosh@kernel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
 Linus Walleij <linus.walleij@linaro.org>, Chen-Yu Tsai <wens@csie.org>,
 =?UTF-8?Q?Jonathan_Neusch=c3=a4fer?= <j.neuschaefer@gmx.net>,
 Tony Lindgren <tony@atomide.com>, Liam Girdwood <lgirdwood@gmail.com>,
 Philipp Zabel <p.zabel@pengutronix.de>, Vladimir Zapolskiy <vz@mleia.com>,
 Avi Fishman <avifishman70@gmail.com>, Tomer Maimon <tmaimon77@gmail.com>,
 Tali Perry <tali.perry1@gmail.com>, Patrick Venture <venture@google.com>,
 Nancy Yuen <yuenn@google.com>, Benjamin Fair <benjaminfair@google.com>,
 Pavel Machek <pavel@ucw.cz>, linux-arm-kernel@lists.infradead.org,
 linux-kernel@vger.kernel.org, linux-csky@vger.kernel.org,
 linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org,
 linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org,
 linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org,
 linux-sh@vger.kernel.org, xen-devel@lists.xenproject.org,
 linux-acpi@vger.kernel.org, linux-omap@vger.kernel.org,
 openbmc@lists.ozlabs.org, linux-tegra@vger.kernel.org,
 linux-pm@vger.kernel.org
References: <20211027211715.12671-1-digetx@gmail.com>
 <20211027211715.12671-4-digetx@gmail.com>
 <YXqCz/utp2DFJJ45@smile.fi.intel.com>
From: Dmitry Osipenko <digetx@gmail.com>
Message-ID: <c5fb7590-03a7-0eea-4040-07472a5c9710@gmail.com>
Date: Fri, 29 Oct 2021 00:32:37 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <YXqCz/utp2DFJJ45@smile.fi.intel.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit

28.10.2021 14:00, Andy Shevchenko пишет:
> On Thu, Oct 28, 2021 at 12:16:33AM +0300, Dmitry Osipenko wrote:
>> Add atomic/blocking_notifier_has_unique_priority() helpers which return
>> true if given handler has unique priority.
> 
> ...
> 
>> +/**
>> + *	atomic_notifier_has_unique_priority - Checks whether notifier's priority is unique
>> + *	@nh: Pointer to head of the atomic notifier chain
>> + *	@n: Entry in notifier chain to check
>> + *
>> + *	Checks whether there is another notifier in the chain with the same priority.
>> + *	Must be called in process context.
>> + *
>> + *	Returns true if priority is unique, false otherwise.
> 
> Why this indentation?

This is the same doc-comment style used by this file in general. I
haven't tried to invent anything new.


> ...
> 
>> +	/*
>> +	 * This code gets used during boot-up, when task switching is
>> +	 * not yet working and interrupts must remain disabled.  At
> 
> One space is enough.

This comment is replicated multiple times over this source file. You can
find it before each down_write(). I borrowed the text as-is, for
consistency.


From xen-devel-bounces@lists.xenproject.org Thu Oct 28 21:36:34 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Oct 2021 21:36:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.218307.378672 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgD4W-0007MT-TR; Thu, 28 Oct 2021 21:36:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 218307.378672; Thu, 28 Oct 2021 21:36:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgD4W-0007MM-QY; Thu, 28 Oct 2021 21:36:28 +0000
Received: by outflank-mailman (input) for mailman id 218307;
 Thu, 28 Oct 2021 21:36:27 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=CzqG=PQ=gmail.com=digetx@srs-us1.protection.inumbo.net>)
 id 1mgD4V-0007MG-S7
 for xen-devel@lists.xenproject.org; Thu, 28 Oct 2021 21:36:27 +0000
Received: from mail-lf1-x132.google.com (unknown [2a00:1450:4864:20::132])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id eb1ba2e5-8254-4573-bf34-f378b2a5f3f6;
 Thu, 28 Oct 2021 21:36:27 +0000 (UTC)
Received: by mail-lf1-x132.google.com with SMTP id bq11so16450914lfb.10
 for <xen-devel@lists.xenproject.org>; Thu, 28 Oct 2021 14:36:27 -0700 (PDT)
Received: from [192.168.2.145] (46-138-44-18.dynamic.spd-mgts.ru.
 [46.138.44.18])
 by smtp.googlemail.com with ESMTPSA id s9sm396521ljg.76.2021.10.28.14.36.23
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Thu, 28 Oct 2021 14:36:25 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: eb1ba2e5-8254-4573-bf34-f378b2a5f3f6
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-language:content-transfer-encoding;
        bh=thttoNtx85IqBzMI/c95u4NQI+WEGNQqD09v61bWPkE=;
        b=Y9ted3wnUvFPZbztZa+QHRbohuO2ujzfF68/pFicW5dA7D1yuFrKCL4aTWk/1AChzB
         fKwgUocsDwuNOGM2+iseiHe/bj2d1v3+dSRNtXKqEmTsyBkz7IWQs8pVvc2a2gvGjfup
         yLqAO4u/w7mjCphm/lBZwptgCTPupkSC+307KKr7OHU7po5AtPQB8ZhrguBiu6yERIjH
         bK0WN85VLNpdVAhT7soiJpVcCZ4Sp0KIHJV14Uu8RloVE9YJBCz/nPhBHDPyGgkjYHQ0
         imoJdP8GopH3zoQfTkWNgL4xsg20XHFvSLev9dZQthSUfjSrDblQ5bVzKxHiquLI0ZeF
         3ufg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-language
         :content-transfer-encoding;
        bh=thttoNtx85IqBzMI/c95u4NQI+WEGNQqD09v61bWPkE=;
        b=FDBsBHWd5QW9ajChVI8APwX+1c9lUOToD7AmkDXk1n0oS1whi09PoBCOWs0jzWF2Uc
         a1MH6zqO7IAfgwP4MY+7o+YQbkYGotXyOl3U3ITgQV4kBQy66SDvF3s9MFuGP9AtQgfP
         Y8SdxrUkYqGXZh9HaYCkeE2XnVrBpgn0qeaZtUbIzmp8OhSePR/QnpJJCsioKYHHbszS
         VGUiM7czj8luIaXKjmPPExGkgUUvYw4cuBlwHG6KJAZZVp3nJnh4AvsXMZMx5R83nfhT
         WsbIY/I5XN17doK9+L0PuZGWefxutB+k22CKn2SUBhhmoTZLwVEnqMau9numy7KKPXTl
         +HIQ==
X-Gm-Message-State: AOAM531bgRsRIJka7XiSoFFuv8JywWaE6EiKpccjDiZbBhb/NwC93Hk1
	1ZPVvu+A0wRxfmGXFelWDNY=
X-Google-Smtp-Source: ABdhPJzbYSC0nWI15MXaoXJe2SikVhRJRnLxoLeSiSPsVfPjrcP1DbWpe0jTqiEw6MLnleJHOc1O3g==
X-Received: by 2002:a05:6512:2292:: with SMTP id f18mr6437448lfu.619.1635456985989;
        Thu, 28 Oct 2021 14:36:25 -0700 (PDT)
Subject: Re: [PATCH v2 08/45] kernel: Add combined power-off+restart handler
 call chain API
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Thierry Reding <thierry.reding@gmail.com>,
 Jonathan Hunter <jonathanh@nvidia.com>, Lee Jones <lee.jones@linaro.org>,
 Mark Brown <broonie@kernel.org>, Andrew Morton <akpm@linux-foundation.org>,
 Guenter Roeck <linux@roeck-us.net>, Russell King <linux@armlinux.org.uk>,
 Daniel Lezcano <daniel.lezcano@linaro.org>,
 Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
 Ulf Hansson <ulf.hansson@linaro.org>,
 Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will@kernel.org>,
 Guo Ren <guoren@kernel.org>, Geert Uytterhoeven <geert@linux-m68k.org>,
 Greg Ungerer <gerg@linux-m68k.org>, Joshua Thompson <funaho@jurai.org>,
 Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
 Nick Hu <nickhu@andestech.com>, Greentime Hu <green.hu@gmail.com>,
 Vincent Chen <deanbo422@gmail.com>,
 "James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
 Helge Deller <deller@gmx.de>, Michael Ellerman <mpe@ellerman.id.au>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 Paul Mackerras <paulus@samba.org>, Paul Walmsley <paul.walmsley@sifive.com>,
 Palmer Dabbelt <palmer@dabbelt.com>, Albert Ou <aou@eecs.berkeley.edu>,
 Yoshinori Sato <ysato@users.sourceforge.jp>, Rich Felker <dalias@libc.org>,
 Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
 Borislav Petkov <bp@alien8.de>, Dave Hansen <dave.hansen@linux.intel.com>,
 the arch/x86 maintainers <x86@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>,
 Boris Ostrovsky <boris.ostrovsky@oracle.com>, Juergen Gross
 <jgross@suse.com>, Stefano Stabellini <sstabellini@kernel.org>,
 Len Brown <lenb@kernel.org>, Santosh Shilimkar <ssantosh@kernel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
 Linus Walleij <linus.walleij@linaro.org>, Chen-Yu Tsai <wens@csie.org>,
 =?UTF-8?Q?Jonathan_Neusch=c3=a4fer?= <j.neuschaefer@gmx.net>,
 Tony Lindgren <tony@atomide.com>, Liam Girdwood <lgirdwood@gmail.com>,
 Philipp Zabel <p.zabel@pengutronix.de>, Vladimir Zapolskiy <vz@mleia.com>,
 Avi Fishman <avifishman70@gmail.com>, Tomer Maimon <tmaimon77@gmail.com>,
 Tali Perry <tali.perry1@gmail.com>, Patrick Venture <venture@google.com>,
 Nancy Yuen <yuenn@google.com>, Benjamin Fair <benjaminfair@google.com>,
 Pavel Machek <pavel@ucw.cz>, Linux ARM
 <linux-arm-kernel@lists.infradead.org>,
 Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
 linux-csky@vger.kernel.org, linux-ia64@vger.kernel.org,
 linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org,
 linux-parisc@vger.kernel.org, linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
 linux-riscv@lists.infradead.org, Linux-sh list <linux-sh@vger.kernel.org>,
 xen-devel@lists.xenproject.org,
 ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
 Linux OMAP Mailing List <linux-omap@vger.kernel.org>,
 openbmc@lists.ozlabs.org, linux-tegra <linux-tegra@vger.kernel.org>,
 Linux PM <linux-pm@vger.kernel.org>
References: <20211027211715.12671-1-digetx@gmail.com>
 <20211027211715.12671-9-digetx@gmail.com>
 <CAJZ5v0jMdSjmkswzu18LSxcNk+k92Oz5XFFXmu-h=W8aPP4Oig@mail.gmail.com>
From: Dmitry Osipenko <digetx@gmail.com>
Message-ID: <d1837954-bd70-460d-3548-0d5ec5b75704@gmail.com>
Date: Fri, 29 Oct 2021 00:36:23 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <CAJZ5v0jMdSjmkswzu18LSxcNk+k92Oz5XFFXmu-h=W8aPP4Oig@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit

28.10.2021 12:53, Rafael J. Wysocki пишет:
>> +/**
>> + * struct power_handler - Machine power-off + restart handler
>> + *
>> + * Describes power-off and restart handlers which are invoked by kernel
>> + * to power off or restart this machine.  Supports prioritized chaining for
>> + * both restart and power-off handlers.  Callback's priority must be unique.
>> + * Intended to be used by device drivers that are responsible for restarting
>> + * and powering off hardware which kernel is running on.
>> + *
>> + * Struct power_handler can be static.  Members of this structure must not be
>> + * altered while handler is registered.
>> + *
>> + * Fill the structure members and pass it to register_power_handler().
>> + */
>> +struct power_handler {
> The name of this structure is too generic IMV.  There are many things
> that it might apply to in principle.
> 
> What about calling power_off_handler or sys_off_handler as it need not
> be about power at all?

I didn't like much the 'power' either, but couldn't come up with a
better variant. Will change it in v3, thank you.


From xen-devel-bounces@lists.xenproject.org Thu Oct 28 21:58:55 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Oct 2021 21:58:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.218314.378683 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgDPy-0001VZ-OH; Thu, 28 Oct 2021 21:58:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 218314.378683; Thu, 28 Oct 2021 21:58:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgDPy-0001VS-LH; Thu, 28 Oct 2021 21:58:38 +0000
Received: by outflank-mailman (input) for mailman id 218314;
 Thu, 28 Oct 2021 21:58:37 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=CzqG=PQ=gmail.com=digetx@srs-us1.protection.inumbo.net>)
 id 1mgDPx-0001VM-43
 for xen-devel@lists.xenproject.org; Thu, 28 Oct 2021 21:58:37 +0000
Received: from mail-lj1-x234.google.com (unknown [2a00:1450:4864:20::234])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 0997cad3-c347-4fe7-8756-bde0ef1cf61f;
 Thu, 28 Oct 2021 21:58:36 +0000 (UTC)
Received: by mail-lj1-x234.google.com with SMTP id n7so13170227ljp.5
 for <xen-devel@lists.xenproject.org>; Thu, 28 Oct 2021 14:58:35 -0700 (PDT)
Received: from [192.168.2.145] (46-138-44-18.dynamic.spd-mgts.ru.
 [46.138.44.18])
 by smtp.googlemail.com with ESMTPSA id t17sm248350ljc.136.2021.10.28.14.58.32
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Thu, 28 Oct 2021 14:58:34 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0997cad3-c347-4fe7-8756-bde0ef1cf61f
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-language:content-transfer-encoding;
        bh=c23uil5g78FyKWMRLgZ6hSpJ/5dZjfgZdNOr6DwhpW8=;
        b=fN/sghTD1TZsVWGg7UdNVpmnpsJmxwTIReywOn3iS879FfwyrwTro/6JMf4MaGrEqh
         0NHbUx8tMPVCykH7rLffN6x80gPATjYeRH0X7Rke1JX3QXf40ikAhOl25K5S1BWImyNK
         Ws74ZKNhvY45yMsuq3FCKQn2UeHbmrvMca8cD6CCJ0R2lYcZYJkrBjgifHSN/5oWm7n1
         lFtQ6NQQUb7L/5VMhM9mJogVid13IyjOv29tIrHnCgMGRUpYmk/I5bl/5lJ21eD61OSt
         uVSSMkzEczkDy+3W/RlWkglTIAMMvdWcaEVw6izXBz+EOktxUqL8EL8FpyIQN0i0+0ax
         cKtg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-language
         :content-transfer-encoding;
        bh=c23uil5g78FyKWMRLgZ6hSpJ/5dZjfgZdNOr6DwhpW8=;
        b=hpCQNYdFvIeIMCR+kM2/oZjAkzXhjgplLWRBpSVlgZ5XFf7Eh5fgSIboGW5mzG436J
         c0nbWXSDvQ/8ZnJ1NMQKj1Zpooyeatoir0eyL0PRsbOh1VTNz3espHA1XZy3GeVLQqV+
         srAmKsdKTtSD0zFguFcnBTnWu0m+wl6k3mjUnaG9EYlkNQdQJs5uOwIR7v365e+NZcv5
         aANGXALF/hQh3ojl6gkYKb81u2SlxnREJC0yChHlqCtnWeCebx8ObfTNyt/sXRrlKdqq
         m+S3u4TBaq0ST2y/dWULM0p3r7VmRGHkm0+X7viTG46xplH+lDSLFZNCSP4qCejwevpZ
         ziPQ==
X-Gm-Message-State: AOAM532mw3PwgpKwzko7WEKW9RB5Aonddp4ykKBCQSnN965KFHJ6o8yR
	aj6pf2uQy8VpKDdWecKs6co=
X-Google-Smtp-Source: ABdhPJwU+yd9K4RKqPYJGKdWrmOtthi6PCwOlEc1MXGCnrTPBunu0coGknm3bBb5A7s1sx8AG2GBkw==
X-Received: by 2002:a2e:b88f:: with SMTP id r15mr7402126ljp.157.1635458314886;
        Thu, 28 Oct 2021 14:58:34 -0700 (PDT)
Subject: Re: [PATCH v2 08/45] kernel: Add combined power-off+restart handler
 call chain API
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Thierry Reding <thierry.reding@gmail.com>,
 Jonathan Hunter <jonathanh@nvidia.com>, Lee Jones <lee.jones@linaro.org>,
 Mark Brown <broonie@kernel.org>, Andrew Morton <akpm@linux-foundation.org>,
 Guenter Roeck <linux@roeck-us.net>, Russell King <linux@armlinux.org.uk>,
 Daniel Lezcano <daniel.lezcano@linaro.org>,
 Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
 Ulf Hansson <ulf.hansson@linaro.org>,
 Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will@kernel.org>,
 Guo Ren <guoren@kernel.org>, Geert Uytterhoeven <geert@linux-m68k.org>,
 Greg Ungerer <gerg@linux-m68k.org>, Joshua Thompson <funaho@jurai.org>,
 Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
 Greentime Hu <green.hu@gmail.com>, Vincent Chen <deanbo422@gmail.com>,
 "James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
 Helge Deller <deller@gmx.de>, Michael Ellerman <mpe@ellerman.id.au>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 Paul Mackerras <paulus@samba.org>, Paul Walmsley <paul.walmsley@sifive.com>,
 Palmer Dabbelt <palmer@dabbelt.com>, Albert Ou <aou@eecs.berkeley.edu>,
 Yoshinori Sato <ysato@users.sourceforge.jp>, Rich Felker <dalias@libc.org>,
 Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
 Borislav Petkov <bp@alien8.de>, Dave Hansen <dave.hansen@linux.intel.com>,
 the arch/x86 maintainers <x86@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>,
 Boris Ostrovsky <boris.ostrovsky@oracle.com>, Juergen Gross
 <jgross@suse.com>, Stefano Stabellini <sstabellini@kernel.org>,
 Len Brown <lenb@kernel.org>, Santosh Shilimkar <ssantosh@kernel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
 Linus Walleij <linus.walleij@linaro.org>, Chen-Yu Tsai <wens@csie.org>,
 =?UTF-8?Q?Jonathan_Neusch=c3=a4fer?= <j.neuschaefer@gmx.net>,
 Tony Lindgren <tony@atomide.com>, Liam Girdwood <lgirdwood@gmail.com>,
 Philipp Zabel <p.zabel@pengutronix.de>, Vladimir Zapolskiy <vz@mleia.com>,
 Avi Fishman <avifishman70@gmail.com>, Tomer Maimon <tmaimon77@gmail.com>,
 Tali Perry <tali.perry1@gmail.com>, Patrick Venture <venture@google.com>,
 Nancy Yuen <yuenn@google.com>, Benjamin Fair <benjaminfair@google.com>,
 Pavel Machek <pavel@ucw.cz>, Linux ARM
 <linux-arm-kernel@lists.infradead.org>,
 Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
 linux-csky@vger.kernel.org, linux-ia64@vger.kernel.org,
 linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org,
 linux-parisc@vger.kernel.org, linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
 linux-riscv@lists.infradead.org, Linux-sh list <linux-sh@vger.kernel.org>,
 xen-devel@lists.xenproject.org,
 ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
 Linux OMAP Mailing List <linux-omap@vger.kernel.org>,
 openbmc@lists.ozlabs.org, linux-tegra <linux-tegra@vger.kernel.org>,
 Linux PM <linux-pm@vger.kernel.org>
References: <20211027211715.12671-1-digetx@gmail.com>
 <20211027211715.12671-9-digetx@gmail.com>
 <CAJZ5v0gpu2ezMhWr=grg6M8aWAx58DQozbXHoZaiPqUaZxJi4Q@mail.gmail.com>
From: Dmitry Osipenko <digetx@gmail.com>
Message-ID: <28560da7-8ab6-3bd5-b4d6-e34b21a9bbb0@gmail.com>
Date: Fri, 29 Oct 2021 00:58:32 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <CAJZ5v0gpu2ezMhWr=grg6M8aWAx58DQozbXHoZaiPqUaZxJi4Q@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit

28.10.2021 12:59, Rafael J. Wysocki пишет:
>> +#define RESTART_PRIO_RESERVED          0
>> +#define RESTART_PRIO_DEFAULT           128
>> +#define RESTART_PRIO_HIGH              192
>>
>>  enum reboot_mode {
>>         REBOOT_UNDEFINED = -1,
>> @@ -49,6 +55,167 @@ int register_restart_handler(struct notifier_block *);
>>  int unregister_restart_handler(struct notifier_block *);
>>  void do_kernel_restart(char *cmd);
>>
>> +/*
>> + * Unified poweroff + restart API.
>> + */
>> +
>> +#define POWEROFF_PRIO_RESERVED         0
>> +#define POWEROFF_PRIO_PLATFORM         1
>> +#define POWEROFF_PRIO_DEFAULT          128
>> +#define POWEROFF_PRIO_HIGH             192
>> +#define POWEROFF_PRIO_FIRMWARE         224
> Also I'm wondering why these particular numbers were chosen, here and above?

These values are chosen based on priorities that drivers already use. I looked thorough them all and ended with this scheme that fulfills the needs of the current API users.

I'll add these comments in v3:

/*
 * Standard restart priority levels. Intended to be set in the
 * sys_off_handler.restart_priority field.
 *
 * Use `RESTART_PRIO_XXX +- prio` style for additional levels.
 *
 * RESTART_PRIO_RESERVED:	Falls back to RESTART_PRIO_DEFAULT.
 *				Drivers may leave priority initialized
 *				to zero, to auto-set it to the default level.
 *
 * RESTART_PRIO_DEFAULT:	Use this for generic handler.
 *
 * RESTART_PRIO_HIGH:		Use this if you have multiple handlers and
 *				this handler has higher priority than the
 *				default handler.
 */

/*
 * Standard power-off priority levels. Intended to be set in the
 * sys_off_handler.power_off_priority field.
 *
 * Use `POWEROFF_PRIO_XXX +- prio` style for additional levels.
 *
 * POWEROFF_PRIO_RESERVED:	Falls back to POWEROFF_PRIO_DEFAULT.
 *				Drivers may leave priority initialized
 *				to zero, to auto-set it to the default level.
 *
 * POWEROFF_PRIO_PLATFORM:	Intended to be used by platform-level handler.
 *				Has lowest priority since device drivers are
 *				expected to take over platform handler which
 *				doesn't allow further callback chaining.
 *
 * POWEROFF_PRIO_DEFAULT:	Use this for generic handler.
 *
 * POWEROFF_PRIO_HIGH:		Use this if you have multiple handlers and
 *				this handler has higher priority than the
 *				default handler.
 *
 * POWEROFF_PRIO_FIRMWARE:	Use this if handler uses firmware call.
 *				Has highest priority since firmware is expected
 *				to know best how to power-off hardware properly.
 */


From xen-devel-bounces@lists.xenproject.org Thu Oct 28 22:00:03 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Oct 2021 22:00:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.218319.378694 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgDRB-00024u-3f; Thu, 28 Oct 2021 21:59:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 218319.378694; Thu, 28 Oct 2021 21:59:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgDRA-00024l-Vw; Thu, 28 Oct 2021 21:59:52 +0000
Received: by outflank-mailman (input) for mailman id 218319;
 Thu, 28 Oct 2021 21:59:51 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=CzqG=PQ=gmail.com=digetx@srs-us1.protection.inumbo.net>)
 id 1mgDR9-00024d-27
 for xen-devel@lists.xenproject.org; Thu, 28 Oct 2021 21:59:51 +0000
Received: from mail-lj1-x229.google.com (unknown [2a00:1450:4864:20::229])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id af2d5995-b736-4cdb-b187-51773fa2d12b;
 Thu, 28 Oct 2021 21:59:50 +0000 (UTC)
Received: by mail-lj1-x229.google.com with SMTP id i26so11253307ljg.7
 for <xen-devel@lists.xenproject.org>; Thu, 28 Oct 2021 14:59:50 -0700 (PDT)
Received: from [192.168.2.145] (46-138-44-18.dynamic.spd-mgts.ru.
 [46.138.44.18])
 by smtp.googlemail.com with ESMTPSA id e12sm398160ljp.30.2021.10.28.14.59.47
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Thu, 28 Oct 2021 14:59:49 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: af2d5995-b736-4cdb-b187-51773fa2d12b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-language:content-transfer-encoding;
        bh=7iQ4oU5lLihLvwqt++KnGQLKBiUKhW8mB9CMlvRrAlo=;
        b=A2gDnKnXbVmAEWSfC30h5AU4KgqctGREzx+w+qi3liDGTlzRRXf3E1jZyML8gNPqGK
         Li6mIZ0lXuGBdwOE60K0G95Tgukhjr9rRKc5cXQiD0w/VxhtL95meDusnxyabh4+EWGW
         r0TYt6OWs+PjfxzqoZ6eJ3DrcMZlu658BTNljXfs4JxLykUHrLNYB1GLE4vhnXR1mGD/
         zsbBpAOKKFkkKsVx+h1bPiV6KMSfM+yc+Xd2DvoUE9RQ/ZfhiCHVvnICfk2iVe468EjX
         DSGsN20SLeM1V9+yNC6BNE7z4vvudCJzb443pi2WeFnCmYQbcFE9zeHCdAOjGieXrkv9
         /UcA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-language
         :content-transfer-encoding;
        bh=7iQ4oU5lLihLvwqt++KnGQLKBiUKhW8mB9CMlvRrAlo=;
        b=4fevKNJNGSnV67gi+ySLnIGJZLVx2gpao/o93Irb6hstQ3UXMTrcS/XhBSJd2z+D5L
         1LNO6s5qmlIx+UtZiRH9Ingl0TetwvCykVjS6V9p9F5lK++DsI7Hz3KIM9lzDUrxFNum
         UK6u5Yk6Tw4jCoHq+wS/4BAHHB1hblUVzf3WwIH0kXnd9Y95omFwPmdXUuQS0AxixW7s
         krJkR6jU3hX0hmxwCFCKer0jZa6kRcoGEdbN+en5lGiXFmichuj25Iabpu+inavcnXJY
         rykfhBRly44gOy/YGL90DH0AW+ioqHamv/09z2xG4Ro/73tu+xqi/zzlwhVYf1f6Vhdr
         7N0g==
X-Gm-Message-State: AOAM533O8fcfl3NtJDGe4TP56eTKwKC9gWlE4jVcp2ZpTZKf0Y5TB6t4
	8vrRQ/AIJ0iOsH3O9holHjY=
X-Google-Smtp-Source: ABdhPJxS5C9pTHHcX2SeZO1OzU/OwueG01d90Y/t9QArtk4xiAh7ZBD5U7QFitj+IF+gde/bz4TCKA==
X-Received: by 2002:a2e:9d93:: with SMTP id c19mr7265789ljj.363.1635458389307;
        Thu, 28 Oct 2021 14:59:49 -0700 (PDT)
Subject: Re: [PATCH v2 08/45] kernel: Add combined power-off+restart handler
 call chain API
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Thierry Reding <thierry.reding@gmail.com>,
 Jonathan Hunter <jonathanh@nvidia.com>, Lee Jones <lee.jones@linaro.org>,
 Mark Brown <broonie@kernel.org>, Andrew Morton <akpm@linux-foundation.org>,
 Guenter Roeck <linux@roeck-us.net>, Russell King <linux@armlinux.org.uk>,
 Daniel Lezcano <daniel.lezcano@linaro.org>,
 Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
 Ulf Hansson <ulf.hansson@linaro.org>,
 Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will@kernel.org>,
 Guo Ren <guoren@kernel.org>, Geert Uytterhoeven <geert@linux-m68k.org>,
 Greg Ungerer <gerg@linux-m68k.org>, Joshua Thompson <funaho@jurai.org>,
 Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
 Greentime Hu <green.hu@gmail.com>, Vincent Chen <deanbo422@gmail.com>,
 "James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
 Helge Deller <deller@gmx.de>, Michael Ellerman <mpe@ellerman.id.au>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 Paul Mackerras <paulus@samba.org>, Paul Walmsley <paul.walmsley@sifive.com>,
 Palmer Dabbelt <palmer@dabbelt.com>, Albert Ou <aou@eecs.berkeley.edu>,
 Yoshinori Sato <ysato@users.sourceforge.jp>, Rich Felker <dalias@libc.org>,
 Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
 Borislav Petkov <bp@alien8.de>, Dave Hansen <dave.hansen@linux.intel.com>,
 the arch/x86 maintainers <x86@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>,
 Boris Ostrovsky <boris.ostrovsky@oracle.com>, Juergen Gross
 <jgross@suse.com>, Stefano Stabellini <sstabellini@kernel.org>,
 Len Brown <lenb@kernel.org>, Santosh Shilimkar <ssantosh@kernel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
 Linus Walleij <linus.walleij@linaro.org>, Chen-Yu Tsai <wens@csie.org>,
 =?UTF-8?Q?Jonathan_Neusch=c3=a4fer?= <j.neuschaefer@gmx.net>,
 Tony Lindgren <tony@atomide.com>, Liam Girdwood <lgirdwood@gmail.com>,
 Philipp Zabel <p.zabel@pengutronix.de>, Vladimir Zapolskiy <vz@mleia.com>,
 Avi Fishman <avifishman70@gmail.com>, Tomer Maimon <tmaimon77@gmail.com>,
 Tali Perry <tali.perry1@gmail.com>, Patrick Venture <venture@google.com>,
 Nancy Yuen <yuenn@google.com>, Benjamin Fair <benjaminfair@google.com>,
 Pavel Machek <pavel@ucw.cz>, Linux ARM
 <linux-arm-kernel@lists.infradead.org>,
 Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
 linux-csky@vger.kernel.org, linux-ia64@vger.kernel.org,
 linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org,
 linux-parisc@vger.kernel.org, linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
 linux-riscv@lists.infradead.org, Linux-sh list <linux-sh@vger.kernel.org>,
 xen-devel@lists.xenproject.org,
 ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
 Linux OMAP Mailing List <linux-omap@vger.kernel.org>,
 openbmc@lists.ozlabs.org, linux-tegra <linux-tegra@vger.kernel.org>,
 Linux PM <linux-pm@vger.kernel.org>
References: <20211027211715.12671-1-digetx@gmail.com>
 <20211027211715.12671-9-digetx@gmail.com>
 <CAJZ5v0gpu2ezMhWr=grg6M8aWAx58DQozbXHoZaiPqUaZxJi4Q@mail.gmail.com>
From: Dmitry Osipenko <digetx@gmail.com>
Message-ID: <31547403-969e-91a9-0792-6fd657b78503@gmail.com>
Date: Fri, 29 Oct 2021 00:59:46 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <CAJZ5v0gpu2ezMhWr=grg6M8aWAx58DQozbXHoZaiPqUaZxJi4Q@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit

28.10.2021 12:59, Rafael J. Wysocki пишет:
>> +/**
>> + * struct power_handler - Machine power-off + restart handler
>> + *
>> + * Describes power-off and restart handlers which are invoked by kernel
>> + * to power off or restart this machine.  Supports prioritized chaining for
>> + * both restart and power-off handlers.  Callback's priority must be unique.
>> + * Intended to be used by device drivers that are responsible for restarting
>> + * and powering off hardware which kernel is running on.
>> + *
>> + * Struct power_handler can be static.  Members of this structure must not be
>> + * altered while handler is registered.
>> + *
>> + * Fill the structure members and pass it to register_power_handler().
>> + */
>> +struct power_handler {
>> +       /**
>> +        * @cb_data:
>> +        *
>> +        * User data included in callback's argument.
>> +        */
> And here I would document the structure fields in the main kerneldoc
> comment above.
> 
> As is, it is a bit hard to grasp the whole definition.
> 

I'll move the comments in v3, thanks.


From xen-devel-bounces@lists.xenproject.org Thu Oct 28 22:06:07 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Oct 2021 22:06:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.218328.378704 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgDX4-0003a6-PC; Thu, 28 Oct 2021 22:05:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 218328.378704; Thu, 28 Oct 2021 22:05:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgDX4-0003Zz-Lf; Thu, 28 Oct 2021 22:05:58 +0000
Received: by outflank-mailman (input) for mailman id 218328;
 Thu, 28 Oct 2021 22:05:58 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=CzqG=PQ=gmail.com=digetx@srs-us1.protection.inumbo.net>)
 id 1mgDX3-0003Zt-Sw
 for xen-devel@lists.xenproject.org; Thu, 28 Oct 2021 22:05:57 +0000
Received: from mail-lj1-x235.google.com (unknown [2a00:1450:4864:20::235])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id c74c9afd-2bbe-4ca7-96c6-409320eac8ab;
 Thu, 28 Oct 2021 22:05:57 +0000 (UTC)
Received: by mail-lj1-x235.google.com with SMTP id h11so13245528ljk.1
 for <xen-devel@lists.xenproject.org>; Thu, 28 Oct 2021 15:05:57 -0700 (PDT)
Received: from [192.168.2.145] (46-138-44-18.dynamic.spd-mgts.ru.
 [46.138.44.18])
 by smtp.googlemail.com with ESMTPSA id v13sm444651ljk.72.2021.10.28.15.05.54
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Thu, 28 Oct 2021 15:05:55 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c74c9afd-2bbe-4ca7-96c6-409320eac8ab
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:from:to:cc:references:message-id:date:user-agent
         :mime-version:in-reply-to:content-language:content-transfer-encoding;
        bh=QdlXzZMWoVtcTasTaLsmBsOCqsQBbCgeCfcj0o9XtUc=;
        b=OJvAD8QIK23NiAd5gHFgNc2jMlnwbUhscd64oItZCjDzpbaa9HqfW53eGYcjGvS+Hd
         8DJvk+brxf2GEvT4zQ6W/ef2iXaKU3cVUF0C3X+R0CYtCLZK9UxcbzlXYXArEArHwTk8
         vcyalmRFTF2jyokLO2ef7zgVnqs7E2ea+6mOp4eaXLCsLH7zqMUa5b9lGYh++3iI3c5l
         5SNXuX8KUFV580Mc9ixmfzVIv8iajcv/gjbcoXvjaxxhRQdJfHyZ96a4PDZESCiQ0JsQ
         ezipbNgT7rnH4g7QwqVqZwJlBhjMy6NJ72j6JC2Ohga6KFFIy4TxdzbmMsSK+f4qNFMJ
         K+tA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:from:to:cc:references:message-id:date
         :user-agent:mime-version:in-reply-to:content-language
         :content-transfer-encoding;
        bh=QdlXzZMWoVtcTasTaLsmBsOCqsQBbCgeCfcj0o9XtUc=;
        b=6IhPVI5mcw025rUGjPnf+M99ItBtac6gbdTi9bH9jyzldiX5/PyVlPN9WWnKmiZKxT
         y+DZycpaKOb5ViQP5EFlItoVJ1PoH41QL6Rd5HPE4xuGlyOVXEH9IH+njDZmAyBg7Q+7
         DrfCXxUwp9g90IJk71XetIDrCtId6AV8T5E7kBm5RmwGoTQKOfAArFJvx6uQIHevRu26
         CRTVTEkLFydlVImbNwTFUEUgWyHYcMo5GiTGzpnbewMDBv4r8KdHeJj4bHw6J6l8NELW
         6eTAGWBjZBnyoUz1lTyHXdTKakYG/Iao5yzSQ8U4swdLfzLLXLyidOZtksD7h3MlALVX
         rDLA==
X-Gm-Message-State: AOAM533zm2QcfnzhvgiUiTWlRmG/Ao6n+VZJTrG2pWPURNbbw1gfqW7u
	qkBUfwq6ye7wgzb98aeX/pA=
X-Google-Smtp-Source: ABdhPJzozZj+Szoqatj9JJ7zamkbp5Jf8v8z0Y7vkU95q/rca882+TrclSa79lyDyuur0f9DZkdGEw==
X-Received: by 2002:a2e:99da:: with SMTP id l26mr5923422ljj.508.1635458756009;
        Thu, 28 Oct 2021 15:05:56 -0700 (PDT)
Subject: Re: [PATCH v2 00/45] Introduce power-off+restart call chain API
From: Dmitry Osipenko <digetx@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>,
 Jonathan Hunter <jonathanh@nvidia.com>, Lee Jones <lee.jones@linaro.org>,
 "Rafael J . Wysocki" <rafael@kernel.org>, Mark Brown <broonie@kernel.org>,
 Andrew Morton <akpm@linux-foundation.org>, Guenter Roeck
 <linux@roeck-us.net>, Russell King <linux@armlinux.org.uk>,
 Daniel Lezcano <daniel.lezcano@linaro.org>,
 Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
 Ulf Hansson <ulf.hansson@linaro.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will@kernel.org>,
 Guo Ren <guoren@kernel.org>, Geert Uytterhoeven <geert@linux-m68k.org>,
 Greg Ungerer <gerg@linux-m68k.org>, Joshua Thompson <funaho@jurai.org>,
 Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
 Nick Hu <nickhu@andestech.com>, Greentime Hu <green.hu@gmail.com>,
 Vincent Chen <deanbo422@gmail.com>,
 "James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
 Helge Deller <deller@gmx.de>, Michael Ellerman <mpe@ellerman.id.au>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 Paul Mackerras <paulus@samba.org>, Paul Walmsley <paul.walmsley@sifive.com>,
 Palmer Dabbelt <palmer@dabbelt.com>, Albert Ou <aou@eecs.berkeley.edu>,
 Yoshinori Sato <ysato@users.sourceforge.jp>, Rich Felker <dalias@libc.org>,
 Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
 Borislav Petkov <bp@alien8.de>, Dave Hansen <dave.hansen@linux.intel.com>,
 x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
 Boris Ostrovsky <boris.ostrovsky@oracle.com>, Juergen Gross
 <jgross@suse.com>, Stefano Stabellini <sstabellini@kernel.org>,
 Len Brown <lenb@kernel.org>, Santosh Shilimkar <ssantosh@kernel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
 Linus Walleij <linus.walleij@linaro.org>, Chen-Yu Tsai <wens@csie.org>,
 =?UTF-8?Q?Jonathan_Neusch=c3=a4fer?= <j.neuschaefer@gmx.net>,
 Tony Lindgren <tony@atomide.com>, Liam Girdwood <lgirdwood@gmail.com>,
 Philipp Zabel <p.zabel@pengutronix.de>, Vladimir Zapolskiy <vz@mleia.com>,
 Avi Fishman <avifishman70@gmail.com>, Tomer Maimon <tmaimon77@gmail.com>,
 Tali Perry <tali.perry1@gmail.com>, Patrick Venture <venture@google.com>,
 Nancy Yuen <yuenn@google.com>, Benjamin Fair <benjaminfair@google.com>,
 Pavel Machek <pavel@ucw.cz>, linux-arm-kernel@lists.infradead.org,
 linux-kernel@vger.kernel.org, linux-csky@vger.kernel.org,
 linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org,
 linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org,
 linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org,
 linux-sh@vger.kernel.org, xen-devel@lists.xenproject.org,
 linux-acpi@vger.kernel.org, linux-omap@vger.kernel.org,
 openbmc@lists.ozlabs.org, linux-tegra@vger.kernel.org,
 linux-pm@vger.kernel.org
References: <20211027211715.12671-1-digetx@gmail.com>
Message-ID: <92067c5e-a256-ff45-eae2-21033c6a83d2@gmail.com>
Date: Fri, 29 Oct 2021 01:05:53 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <20211027211715.12671-1-digetx@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit

28.10.2021 00:16, Dmitry Osipenko пишет:
>   mfd: ab8500: Use devm_register_trivial_power_off_handler()
>   reset: ath79: Use devm_register_simple_restart_handler()
>   reset: intel-gw: Use devm_register_simple_restart_handler()
>   reset: lpc18xx: Use devm_register_prioritized_restart_handler()
>   reset: npcm: Use devm_register_prioritized_restart_handler()

These patches got lost because Gmail gave me ban after 40's email. I
think it doesn't worth to re-send them now since you should get an idea
about how API usage looks like without the lost patches.


From xen-devel-bounces@lists.xenproject.org Thu Oct 28 22:10:35 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Oct 2021 22:10:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.218337.378715 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgDbM-00057x-EU; Thu, 28 Oct 2021 22:10:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 218337.378715; Thu, 28 Oct 2021 22:10:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgDbM-00057q-Ba; Thu, 28 Oct 2021 22:10:24 +0000
Received: by outflank-mailman (input) for mailman id 218337;
 Thu, 28 Oct 2021 22:10:22 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=CzqG=PQ=gmail.com=digetx@srs-us1.protection.inumbo.net>)
 id 1mgDbK-00057k-JX
 for xen-devel@lists.xenproject.org; Thu, 28 Oct 2021 22:10:22 +0000
Received: from mail-lj1-x22f.google.com (unknown [2a00:1450:4864:20::22f])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 0aa95140-c52b-4e65-8fdd-845e731cab82;
 Thu, 28 Oct 2021 22:10:21 +0000 (UTC)
Received: by mail-lj1-x22f.google.com with SMTP id 1so7292795ljv.2
 for <xen-devel@lists.xenproject.org>; Thu, 28 Oct 2021 15:10:21 -0700 (PDT)
Received: from [192.168.2.145] (46-138-44-18.dynamic.spd-mgts.ru.
 [46.138.44.18])
 by smtp.googlemail.com with ESMTPSA id x26sm406331ljh.24.2021.10.28.15.10.18
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Thu, 28 Oct 2021 15:10:20 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0aa95140-c52b-4e65-8fdd-845e731cab82
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-language:content-transfer-encoding;
        bh=oJ/0ZuzBVjUo38Wh85+gleqyoNxUo2tupcS3OG//HMk=;
        b=oyp+4ZpoBN8sNbj4o8xY6UXK7DWV+2AXCzvhz53IZDVW7yBXuU0WcYtlG9nrr26Gko
         pspAZNzk5nSawwOoCboqqIBx1NtwU9YP7ClGYgBOs5f5QS+oYjdLS6Chq+lHwnAJsaRE
         aw808EWXPhfWuOImaYWLgQPkx/4+EXGI76qDso1CJ2aKNZ2aChJYUzNXxoU4wlUL2Pxg
         oy7RsSyXKkJJvyMzgbQsMkVQ26q7g1vnPJco9ifX2k6oVsTB9g0J3QdHglNbFRrrT6c8
         P9uyPf++7eB6LV3eSwFOc5BxbfYBVDwZrUUANM1FlvuP72N8IokbXokq1o8sSzQ34LI5
         dsGQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-language
         :content-transfer-encoding;
        bh=oJ/0ZuzBVjUo38Wh85+gleqyoNxUo2tupcS3OG//HMk=;
        b=eF6E/13K+/QILADZS2G85WkBLSlXfXzCvrKPzmyPJUcijsrkrvdT5BANPXuFigxQTe
         gQEoLLttxW8AD8xoVzmch+uq26PybzA8HhGHk+UWBqzfxGpuoYEx1yUHZN6pwUwKeFz0
         Gvv8lSABguA9/xALSgY/eVJrx8DKVLr5EfQ1adsiq7XunQbpf7CEzpxOK5DxvZZq3znP
         gIAxR1551BRAWzc0sGcNv0gQrU8YCqCMSPUWiJGSNVMF4IRgv2vXLA4t/uqLQZNIY4LX
         picy8pGk0Vg6iJitKOREi12VJfz8JeGjWKQ1Isqe98YRzh0cDf7YtH8YOZAYzpWlx9KJ
         ka9Q==
X-Gm-Message-State: AOAM533lPjrPsxJhpRUPtJXXVyeRYWqiJY0QyTIGV1RLF5kY6Q53ynK8
	Qq+7h4dyJRw4cYVx8/JLw6Y=
X-Google-Smtp-Source: ABdhPJykwIAUVmO5wKdpzX+/iWk6pBH4AnIAWbvXPbs4nxxBZpydFbV5fsYhpk8QZgUr9D29NxqkEQ==
X-Received: by 2002:a2e:361a:: with SMTP id d26mr7788286lja.104.1635459020939;
        Thu, 28 Oct 2021 15:10:20 -0700 (PDT)
Subject: Re: [PATCH v2 03/45] notifier: Add
 atomic/blocking_notifier_has_unique_priority()
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Thierry Reding <thierry.reding@gmail.com>,
 Jonathan Hunter <jonathanh@nvidia.com>, Lee Jones <lee.jones@linaro.org>,
 "Rafael J . Wysocki" <rafael@kernel.org>, Mark Brown <broonie@kernel.org>,
 Andrew Morton <akpm@linux-foundation.org>, Guenter Roeck
 <linux@roeck-us.net>, Russell King <linux@armlinux.org.uk>,
 Daniel Lezcano <daniel.lezcano@linaro.org>,
 Ulf Hansson <ulf.hansson@linaro.org>,
 Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will@kernel.org>,
 Guo Ren <guoren@kernel.org>, Geert Uytterhoeven <geert@linux-m68k.org>,
 Greg Ungerer <gerg@linux-m68k.org>, Joshua Thompson <funaho@jurai.org>,
 Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
 Nick Hu <nickhu@andestech.com>, Greentime Hu <green.hu@gmail.com>,
 Vincent Chen <deanbo422@gmail.com>,
 "James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
 Helge Deller <deller@gmx.de>, Michael Ellerman <mpe@ellerman.id.au>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 Paul Mackerras <paulus@samba.org>, Paul Walmsley <paul.walmsley@sifive.com>,
 Palmer Dabbelt <palmer@dabbelt.com>, Albert Ou <aou@eecs.berkeley.edu>,
 Yoshinori Sato <ysato@users.sourceforge.jp>, Rich Felker <dalias@libc.org>,
 Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
 Borislav Petkov <bp@alien8.de>, Dave Hansen <dave.hansen@linux.intel.com>,
 x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
 Boris Ostrovsky <boris.ostrovsky@oracle.com>, Juergen Gross
 <jgross@suse.com>, Stefano Stabellini <sstabellini@kernel.org>,
 Len Brown <lenb@kernel.org>, Santosh Shilimkar <ssantosh@kernel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
 Linus Walleij <linus.walleij@linaro.org>, Chen-Yu Tsai <wens@csie.org>,
 =?UTF-8?Q?Jonathan_Neusch=c3=a4fer?= <j.neuschaefer@gmx.net>,
 Tony Lindgren <tony@atomide.com>, Liam Girdwood <lgirdwood@gmail.com>,
 Philipp Zabel <p.zabel@pengutronix.de>, Vladimir Zapolskiy <vz@mleia.com>,
 Avi Fishman <avifishman70@gmail.com>, Tomer Maimon <tmaimon77@gmail.com>,
 Tali Perry <tali.perry1@gmail.com>, Patrick Venture <venture@google.com>,
 Nancy Yuen <yuenn@google.com>, Benjamin Fair <benjaminfair@google.com>,
 Pavel Machek <pavel@ucw.cz>, linux-arm-kernel@lists.infradead.org,
 linux-kernel@vger.kernel.org, linux-csky@vger.kernel.org,
 linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org,
 linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org,
 linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org,
 linux-sh@vger.kernel.org, xen-devel@lists.xenproject.org,
 linux-acpi@vger.kernel.org, linux-omap@vger.kernel.org,
 openbmc@lists.ozlabs.org, linux-tegra@vger.kernel.org,
 linux-pm@vger.kernel.org
References: <20211027211715.12671-1-digetx@gmail.com>
 <20211027211715.12671-4-digetx@gmail.com>
 <YXqCz/utp2DFJJ45@smile.fi.intel.com>
From: Dmitry Osipenko <digetx@gmail.com>
Message-ID: <ba9d1a3f-c3e4-7060-9859-97014aa633b4@gmail.com>
Date: Fri, 29 Oct 2021 01:10:18 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <YXqCz/utp2DFJJ45@smile.fi.intel.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit

28.10.2021 14:00, Andy Shevchenko пишет:
>> +	while ((*nl) != NULL && (*nl)->priority >= n->priority) {
> ' != NULL' is not needed.
> 

I'll change it in v3, thanks.


From xen-devel-bounces@lists.xenproject.org Thu Oct 28 23:27:43 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Oct 2021 23:27:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.218345.378727 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgEnf-00043S-6u; Thu, 28 Oct 2021 23:27:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 218345.378727; Thu, 28 Oct 2021 23:27:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgEnf-00043L-2h; Thu, 28 Oct 2021 23:27:11 +0000
Received: by outflank-mailman (input) for mailman id 218345;
 Thu, 28 Oct 2021 23:27:09 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=w4/Z=PQ=citrix.com=Andrew.Cooper3@srs-us1.protection.inumbo.net>)
 id 1mgEnd-00043F-Ea
 for xen-devel@lists.xenproject.org; Thu, 28 Oct 2021 23:27:09 +0000
Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 6670aa09-9939-4d19-9872-2c97554643db;
 Thu, 28 Oct 2021 23:27:08 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6670aa09-9939-4d19-9872-2c97554643db
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1635463627;
  h=from:to:cc:subject:date:message-id:mime-version:
   content-transfer-encoding;
  bh=QlWcwayW5CxhvXGoPasCNax8f8rHN7qc15u+X7fUJio=;
  b=OwzL+rPdXmay+MqXHWJ3WwIUuqjKpEddJpa+P4SDFypX7VdLEOMmU4+B
   pmM1G7SxOhH0QrFOQfFcue1IVx+N9HdwfCrnoZO/o31HrsTbcIv5xD/pt
   ndWgBLTBt/VhmXpgVnAK7xnP/kH3UFA3MritidXajwXOxV26TRwMIPOwa
   o=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: Finsqbu55MIkTc0MulkVXNihMwDdrxruU2ptGip3ug7VUhWBEm0cJsnxlHoRQK/P/7EGevjUEY
 01n3FB21VX5BsHSx6JjJ+dSpxJIt7yLuh5DWVh7sXo5LgasSxCDDxTUSszXdBLBf39t/lnBT8k
 OOYCLRj2Q9gkiy4vQHm7lmaftuFadOG/MBciGnMeH4spEzHMEVYhpLLHGai1qYZW2HmjuUdc6V
 VGzP7rKtnNVD+kV4GyNAET/cXHOWfm/Z45ygxifac/Cdh2TzH5Mze0Fmvt0zk10j5vsbx9Up6T
 QD4650j2nPhiQae0JeodVE07
X-SBRS: 5.1
X-MesageID: 57000582
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:sMYEC6JozSlDze2iFE+RNZIlxSXFcZb7ZxGr2PjKsXjdYENShWcOm
 jEfWWmAPffYZTT2eNFwYIji9E4EuZaHx9VrGwNlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s
 q3yv/GZdJhcokcxIn5BC5C5xZVG/fjgqoHUVaiUZUideSc+EH140Eo5y7Zi6mJVqYPR7z2l6
 IuaT/L3YDdJ6xYsWo7Dw/vewP/HlK2aVAIw5jTSV9gS1LPtvyB94KYkDbOwNxPFrrx8RYZWc
 QphIIaRpQs19z91Yj+sfy2SnkciGtY+NiDW4pZatjTLbrGvaUXe345iXMfwZ3u7hB3Ug8Fo6
 McXj6WpEwV3FaPppvYabB1HRnQW0a1uoNcrIFC6uM2XiUbHb2Ht07NlC0Re0Y8wo7gtRzsUr
 LpBdW5LPkvra+GemdpXTsFFgMg5IdatF4QYonx6lhnSDOo8QICFSKLPjTNd9Gpv3pgWQKaED
 yYfQSNJPDWHQFpJBlI4MZAQkdm2nXDvdjIN/Tp5ooJoujOOnWSdyoPFL979atGMA8JPkS6wp
 33E13T0BAkAM96SwibD9Wij7sffkCW+VI8MGbmQ8v9xnEbV1mEVEAcRV1awvb++kEHWc/B1J
 lEQ+yEuhbMv70HtRd74NyBUu1bd4ERaAYAJVbRntkfdkcI4/jp1GEBZUi9YSM58jvYvHz50/
 VGsocHuOjhw5ej9pW2myp+Yqja7OC4wJGAEZDMZQQZt3+QPsL3fnTqUEY49SP/dYsndXGiqm
 WjT/XdWa6A71JZTj82GEUb7byVAT3QjZjU+4RnLRSqb5wd9aZ/Ni2eAuAWDs6gowGp0SDC8U
 Jk4dyq2sL9m4XKlznXlrAAx8FeBvavt3Nr02gcHInXZ327xk0NPhKgJiN2EGG9nM9wfZRjia
 1LJtAVa6fd7ZSXxMPMrPd/sW51yl8AM8OgJsNiOM7KihbAqLWe6ENxGPxbMjwgBbmB1ycnTx
 qt3ge7zVC1HWMyLPRK9RvsH0K9D+8zN7Ti7eHwP9Dz+ieD2TCfMEd8taQLSBshkvPLsiFiEq
 L53aprVoyizpcWjO0E7B6ZIdgtURZX6bLirw/FqmhmreVs4ST54Ua+BndvMueVNxsxoqwsBx
 VnlMmcw9bY1rSevxdyiZi8xZbXxc4x4qH5nbyUgMUzxgyooYJq17bdZfJwyJOF1+OtmxP9yb
 v8EZ8TfXagfFmWZo2wQPcvnsYhvVBW3ngbSbSCrVycyIsx7TAvT9966Iga2rHsSDjC6vNcVq
 qG70l+JWoIKQglvVZ6EaP+mw16rk2IaneZ+AxnBLtVJIR2++4l2MS3hyPQwJphUexnEwzKb0
 SeQAAsZ+raR89NkroGRiPnd/YmzEuZ4Ek5LJEXh7O67ZXvA426u4Y5cS+LULzrTY3z5pfe5b
 uJPwvCibPBexARWs5BxGqpAxL4l44e9vKdTywlpESmZb1mvDb88cHCK0dMW6/9Iz75d/wC3R
 liO6p9RPrDQYJHpF1sYJQwEaOWf1K5LxmmOvKpteEiqtjVq+LenUFlJO0jegSNQG7J5LYc5z
 Lpzo8UR8QG+1kInP9vuYvq4LIhQwqjsi5kai6w=
IronPort-HdrOrdr: A9a23:/aOxAK97VcxScLwVWLZuk+DUI+orL9Y04lQ7vn2YSXRuHPBw8P
 re+8jztCWE7Ar5N0tBpTntAsW9qBDnhPtICOsqTNSftWDd0QPCRuxfBOPZslvd8kbFl9K1u5
 0OT0EHMqyTMWRH
X-IronPort-AV: E=Sophos;i="5.87,191,1631592000"; 
   d="scan'208";a="57000582"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Jan Beulich
	<JBeulich@suse.com>, =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?=
	<roger.pau@citrix.com>, Wei Liu <wl@xen.org>, Ian Jackson
	<iwj@xenproject.org>
Subject: [PATCH] x86/kexec: Fix crash on transition to a 32bit kernel on AMD hardware
Date: Fri, 29 Oct 2021 00:26:58 +0100
Message-ID: <20211028232658.20637-1-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

The `ljmp *mem` instruction is (famously?) not binary compatible between Intel
and AMD CPUS.  The AMD-compatible version would require .long to be .quad in
the second hunk.

Switch to using lretq, which is compatible between Intel and AMD, as well as
being less logic overall.

Fixes: 5a82d5cf352d ("kexec: extend hypercall with improved load/unload ops")
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Roger Pau Monné <roger.pau@citrix.com>
CC: Wei Liu <wl@xen.org>
CC: Ian Jackson <iwj@xenproject.org>

For 4.16.  This is a bugfix for rare (so rare it has probably never been
exercised) but plain-broken usecase.

One argument against taking it says that this has been broken for 8 years
already, so what's a few extra weeks.  Another is that this patch is only
compile tested because I don't have a suitable setup to repro, nor the time to
try organising one.

On the other hand, I specifically used the point of binary incompatibility to
persuade Intel to drop Call Gates out of the architecture in the forthcoming
FRED spec.

The lretq pattern used here matches x86_32_switch() in
xen/arch/x86/boot/head.S, and this codepath is executed on every MB2+EFI
xen.gz boot, which from XenServer alone is a very wide set of testing.
---
 xen/arch/x86/x86_64/kexec_reloc.S | 13 ++++---------
 1 file changed, 4 insertions(+), 9 deletions(-)

diff --git a/xen/arch/x86/x86_64/kexec_reloc.S b/xen/arch/x86/x86_64/kexec_reloc.S
index d488d127cfb9..a93f92b19248 100644
--- a/xen/arch/x86/x86_64/kexec_reloc.S
+++ b/xen/arch/x86/x86_64/kexec_reloc.S
@@ -86,12 +86,11 @@ call_32_bit:
         movq    %rax, (compat_mode_gdt_desc + 2)(%rip)
         lgdt    compat_mode_gdt_desc(%rip)
 
-        /* Relocate compatibility mode entry point address. */
-        leal    compatibility_mode(%rip), %eax
-        movl    %eax, compatibility_mode_far(%rip)
-
         /* Enter compatibility mode. */
-        ljmp    *compatibility_mode_far(%rip)
+        lea     compatibility_mode(%rip), %rax
+        push    $0x10
+        push    %rax
+        lretq
 
 relocate_pages:
         /* %rdi - indirection page maddr */
@@ -171,10 +170,6 @@ compatibility_mode:
         ud2
 
         .align 4
-compatibility_mode_far:
-        .long 0x00000000             /* set in call_32_bit above */
-        .word 0x0010
-
 compat_mode_gdt_desc:
         .word .Lcompat_mode_gdt_end - compat_mode_gdt -1
         .quad 0x0000000000000000     /* set in call_32_bit above */
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Thu Oct 28 23:28:38 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 28 Oct 2021 23:28:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.218349.378738 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgEok-0004bV-I9; Thu, 28 Oct 2021 23:28:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 218349.378738; Thu, 28 Oct 2021 23:28:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgEok-0004bO-DF; Thu, 28 Oct 2021 23:28:18 +0000
Received: by outflank-mailman (input) for mailman id 218349;
 Thu, 28 Oct 2021 23:28:17 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=CzqG=PQ=gmail.com=digetx@srs-us1.protection.inumbo.net>)
 id 1mgEoj-0004bI-Lx
 for xen-devel@lists.xenproject.org; Thu, 28 Oct 2021 23:28:17 +0000
Received: from mail-lf1-x131.google.com (unknown [2a00:1450:4864:20::131])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 6df20459-6f77-423a-9aa4-8b3d30c832eb;
 Thu, 28 Oct 2021 23:28:16 +0000 (UTC)
Received: by mail-lf1-x131.google.com with SMTP id u11so17016454lfs.1
 for <xen-devel@lists.xenproject.org>; Thu, 28 Oct 2021 16:28:16 -0700 (PDT)
Received: from [192.168.2.145] (46-138-44-18.dynamic.spd-mgts.ru.
 [46.138.44.18])
 by smtp.googlemail.com with ESMTPSA id bn3sm414682ljb.7.2021.10.28.16.28.13
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Thu, 28 Oct 2021 16:28:15 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6df20459-6f77-423a-9aa4-8b3d30c832eb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:from:to:cc:references:message-id:date:user-agent
         :mime-version:in-reply-to:content-language:content-transfer-encoding;
        bh=g1ASowQL1SYh3xyvjjnrsnFWzhxhuZ1FkP7TdHa31mE=;
        b=or9I8eXmdc6hOUu3ilMz+ymgHlGQQmwFfcjANI787MFy3461r29Qlx4Drko3A82jiZ
         /Dxbh+rXJkVd+vSmZQz7ByF21FNMWE7Msuh2tmQH7FzEaAaJykw/79BGIIrJtKwboRDm
         04V8OvO+c+XCXlI7f4QRPE7cqx6GZulezk5I+0MnmugoyzWrW9wGp3T/sQ+0YL50opsM
         PEj+17btedXyPtu3l7DUltlj+rCIDD63O2gZoZwfDEKUeboD39P9kLuxM5uqsYcKe9n/
         MuNWRD7sUlbhLEou6B/xsQNLsenMP/929SI9uvSZZXHuqFx/YvhRAZPMrz7X4+YxCerI
         /TgQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:from:to:cc:references:message-id:date
         :user-agent:mime-version:in-reply-to:content-language
         :content-transfer-encoding;
        bh=g1ASowQL1SYh3xyvjjnrsnFWzhxhuZ1FkP7TdHa31mE=;
        b=fBRc4oZ2Nio7KHHgxHo3LKrvpCBuMdmAKPtmCIuLWIhnahmVpvihwNkphTUm9TMmYT
         NKqzU5A1jOCnZb5YjlSkvBvCdQRvp7akn5OTD/FwdqYIfTz9p2b94j1sE5kiBxglx5ao
         svEH9a128MZA15T8++IU0CeiOHee+2RzKucLHAlDbCMDYveAPMv0cZSscRGjCW7tWJnj
         1k3gGBTfRTGhvbRk2q3xnMndLUnadBFz6ijeIYUqZi6n1bEWSsVu/Djv2jx8EEKtgqAe
         owYlPmUzHha426z203SzE2fPKAUx7ZQVfRQtPxJ7NRC/r9JpALndbsIjAyc8KFOq6rgi
         NJKA==
X-Gm-Message-State: AOAM530Y0dekWiG1j8sRVMQUZJ13+7DY9Z79kaIhQglv7bdW/HsCVRFX
	8qnyndIX9ZHRxocxL1bS6m0=
X-Google-Smtp-Source: ABdhPJwV2hV4le461ll7P/MiVtzPzva4GF7PaVejAVvhmYPc9uewsxLl7FIVcxk+rSnnrtvlDg/jfg==
X-Received: by 2002:a19:760a:: with SMTP id c10mr6627861lff.302.1635463695803;
        Thu, 28 Oct 2021 16:28:15 -0700 (PDT)
Subject: Re: [PATCH v2 03/45] notifier: Add
 atomic/blocking_notifier_has_unique_priority()
From: Dmitry Osipenko <digetx@gmail.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Thierry Reding <thierry.reding@gmail.com>,
 Jonathan Hunter <jonathanh@nvidia.com>, Lee Jones <lee.jones@linaro.org>,
 "Rafael J . Wysocki" <rafael@kernel.org>, Mark Brown <broonie@kernel.org>,
 Andrew Morton <akpm@linux-foundation.org>, Guenter Roeck
 <linux@roeck-us.net>, Russell King <linux@armlinux.org.uk>,
 Daniel Lezcano <daniel.lezcano@linaro.org>,
 Ulf Hansson <ulf.hansson@linaro.org>,
 Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will@kernel.org>,
 Guo Ren <guoren@kernel.org>, Geert Uytterhoeven <geert@linux-m68k.org>,
 Greg Ungerer <gerg@linux-m68k.org>, Joshua Thompson <funaho@jurai.org>,
 Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
 Nick Hu <nickhu@andestech.com>, Greentime Hu <green.hu@gmail.com>,
 Vincent Chen <deanbo422@gmail.com>,
 "James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
 Helge Deller <deller@gmx.de>, Michael Ellerman <mpe@ellerman.id.au>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 Paul Mackerras <paulus@samba.org>, Paul Walmsley <paul.walmsley@sifive.com>,
 Palmer Dabbelt <palmer@dabbelt.com>, Albert Ou <aou@eecs.berkeley.edu>,
 Yoshinori Sato <ysato@users.sourceforge.jp>, Rich Felker <dalias@libc.org>,
 Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
 Borislav Petkov <bp@alien8.de>, Dave Hansen <dave.hansen@linux.intel.com>,
 x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
 Boris Ostrovsky <boris.ostrovsky@oracle.com>, Juergen Gross
 <jgross@suse.com>, Stefano Stabellini <sstabellini@kernel.org>,
 Len Brown <lenb@kernel.org>, Santosh Shilimkar <ssantosh@kernel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
 Linus Walleij <linus.walleij@linaro.org>, Chen-Yu Tsai <wens@csie.org>,
 =?UTF-8?Q?Jonathan_Neusch=c3=a4fer?= <j.neuschaefer@gmx.net>,
 Tony Lindgren <tony@atomide.com>, Liam Girdwood <lgirdwood@gmail.com>,
 Philipp Zabel <p.zabel@pengutronix.de>, Vladimir Zapolskiy <vz@mleia.com>,
 Avi Fishman <avifishman70@gmail.com>, Tomer Maimon <tmaimon77@gmail.com>,
 Tali Perry <tali.perry1@gmail.com>, Patrick Venture <venture@google.com>,
 Nancy Yuen <yuenn@google.com>, Benjamin Fair <benjaminfair@google.com>,
 Pavel Machek <pavel@ucw.cz>, linux-arm-kernel@lists.infradead.org,
 linux-kernel@vger.kernel.org, linux-csky@vger.kernel.org,
 linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org,
 linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org,
 linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org,
 linux-sh@vger.kernel.org, xen-devel@lists.xenproject.org,
 linux-acpi@vger.kernel.org, linux-omap@vger.kernel.org,
 openbmc@lists.ozlabs.org, linux-tegra@vger.kernel.org,
 linux-pm@vger.kernel.org
References: <20211027211715.12671-1-digetx@gmail.com>
 <20211027211715.12671-4-digetx@gmail.com>
 <YXqCz/utp2DFJJ45@smile.fi.intel.com>
 <c5fb7590-03a7-0eea-4040-07472a5c9710@gmail.com>
Message-ID: <8a9c4a9a-ea0d-4bc9-cf57-9bd99b211d47@gmail.com>
Date: Fri, 29 Oct 2021 02:28:13 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <c5fb7590-03a7-0eea-4040-07472a5c9710@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit

29.10.2021 00:32, Dmitry Osipenko пишет:
>>> +	/*
>>> +	 * This code gets used during boot-up, when task switching is
>>> +	 * not yet working and interrupts must remain disabled.  At
>> One space is enough.
> This comment is replicated multiple times over this source file. You can
> find it before each down_write(). I borrowed the text as-is, for
> consistency.

Actually, it should be down_read() here since there are no writes. I'll
correct it in v3.


From xen-devel-bounces@lists.xenproject.org Fri Oct 29 00:30:23 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Oct 2021 00:30:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.218357.378749 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgFme-0003yg-9P; Fri, 29 Oct 2021 00:30:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 218357.378749; Fri, 29 Oct 2021 00:30:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgFme-0003yZ-5y; Fri, 29 Oct 2021 00:30:12 +0000
Received: by outflank-mailman (input) for mailman id 218357;
 Fri, 29 Oct 2021 00:30:10 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=OkWz=PR=oracle.com=alec.r.brown@srs-us1.protection.inumbo.net>)
 id 1mgFmc-0003yE-Bs
 for xen-devel@lists.xenproject.org; Fri, 29 Oct 2021 00:30:10 +0000
Received: from mx0b-00069f02.pphosted.com (unknown [205.220.177.32])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 5ee2907c-384f-11ec-84be-12813bfff9fa;
 Fri, 29 Oct 2021 00:30:09 +0000 (UTC)
Received: from pps.filterd (m0246631.ppops.net [127.0.0.1])
 by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 19T021G2020641; 
 Fri, 29 Oct 2021 00:29:21 GMT
Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70])
 by mx0b-00069f02.pphosted.com with ESMTP id 3byjkf5r3u-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Fri, 29 Oct 2021 00:29:21 +0000
Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1])
 by aserp3020.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 19T0Fdvg004874;
 Fri, 29 Oct 2021 00:29:20 GMT
Received: from nam02-sn1-obe.outbound.protection.outlook.com
 (mail-sn1anam02lp2047.outbound.protection.outlook.com [104.47.57.47])
 by aserp3020.oracle.com with ESMTP id 3bx4gf6g03-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Fri, 29 Oct 2021 00:29:20 +0000
Received: from DM6PR10MB2986.namprd10.prod.outlook.com (2603:10b6:5:6b::26) by
 DM6PR10MB4171.namprd10.prod.outlook.com (2603:10b6:5:21f::24) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4649.15; Fri, 29 Oct 2021 00:29:18 +0000
Received: from DM6PR10MB2986.namprd10.prod.outlook.com
 ([fe80::4962:3775:18b3:ccc8]) by DM6PR10MB2986.namprd10.prod.outlook.com
 ([fe80::4962:3775:18b3:ccc8%6]) with mapi id 15.20.4628.020; Fri, 29 Oct 2021
 00:29:18 +0000
Received: from alec-orcl (73.61.222.52) by
 BL0PR1501CA0031.namprd15.prod.outlook.com (2603:10b6:207:17::44) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.15 via Frontend
 Transport; Fri, 29 Oct 2021 00:29:15 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5ee2907c-384f-11ec-84be-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc
 : subject : message-id : references : content-type : in-reply-to :
 mime-version; s=corp-2021-07-09;
 bh=9wUGV/buFXwauNHjy4oujs13zhdzLIE363Ppd2jIzmU=;
 b=NkD4bO/cC0B43hQe85eIgleq/weSA/mkroVtewPhRmd65R/XtRyJnYDYeFyzO1Dk42k2
 fHjnIladbSlNYDqWCWz208SypELeKcAKL/NdWZN1NDnPmN0hekTEq2ELWqumGed69MIi
 CKRdiMCeeqzaH8LXTpO2W5v+huc8929mvtI1KUEPvTAT5SlyyKOGPLmsri4BaTsL9eFe
 t7SBF5CqkvJQfbXDhJC1mfimVdFF/UG+u9fFTyJujmQ9wy3UL8gWL/Gxh0BQ7tUxJeNU
 OqO1V3flytl2d5Yf47AsdoCt4Jrc2w8bh8tqv7T202cb7uuNa51UtlJeS+LakFpC7W8A Ow== 
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=neOsaePSKc2m3S0xfO2mE76+tPejnvvMIOMvQjQdHlqCdSpshayZcPhZL4UlInw9UX3qC9kA5f4XwjidOf8TSF4mOtkyXoqtRi8/PoJ+QEqyTdW3MF/qwZGgKotd/1xcJNCD+MzeNr70qCeLrbOThgCWxjXS4Efh2EwM5bIcY3/wVKFcdc4Z8cmn/ZmWrwT5VTDlO549gGEswY0njJVv8sUyjMsdCaMbqLqijxKfPC38SMes6/7wz8/K0mGzVtwgVwiHZ3e0Fit9lt9msyk7rHtnwAnuxJP8qtDVAktGf5DgE7srh0CgHEFzbyhtmud0hwkMDsfxDfWQm59qJyDyYQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=9wUGV/buFXwauNHjy4oujs13zhdzLIE363Ppd2jIzmU=;
 b=F8i7WaaCl173bq70zmVfdXgZ+iX+KtrN9Usg9SP2ZJmWxpeRTyc6hj0iOjDDqJAdB1wIWDi3qZAdBJwgTyypPXB/IBc5Mc9bE0j87af8BNlLV4YuOfdgadKQCvgXo+e7MPhQQb/RBNbQQk594MUeJLeKZYwnbB7joLmjal7d4VemJmL2uoySrs1LiMike/dXGFNovaXPlxy90siE+Z6/7Tus2peBms5m22VBniWg0TvC4CA5mZV+p6sanVGuKqIFkqKkmt3RiJaLX6xWOEwQs0Pfvf9VwaRviGZiAtsq25IEpRh63SPTU8GBXe31y3uGfdbhh81nSGd5vdPKZXav6Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com;
 dkim=pass header.d=oracle.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=9wUGV/buFXwauNHjy4oujs13zhdzLIE363Ppd2jIzmU=;
 b=eY2jh/F5MEWl1VxkNV0+qAwXaoKmPK/EFs+5pe4mH8ks59RxdUpO8niDM1d8qBLt+5H/N/fj78v9pduZa2hjSzawYnrSnkHEAN+clE14LE+JjqYuibgFCmm5vJmK7HOWH3ibVVg19V/NlDibqvBSB/F3fq4q7oCR1kErAGJhYRw=
Authentication-Results: chromium.org; dkim=none (message not signed)
 header.d=none;chromium.org; dmarc=none action=none header.from=oracle.com;
Date: Thu, 28 Oct 2021 20:29:13 -0400
From: Alec Brown <alec.r.brown@oracle.com>
To: Julius Werner <jwerner@chromium.org>
Cc: "coreboot@coreboot.org" <coreboot@coreboot.org>,
        "grub-devel@gnu.org" <grub-devel@gnu.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "systemd-devel@lists.freedesktop.org" <systemd-devel@lists.freedesktop.org>,
        "trenchboot-devel@googlegroups.com" <trenchboot-devel@googlegroups.com>,
        "u-boot@lists.denx.de" <u-boot@lists.denx.de>,
        "x86@kernel.org" <x86@kernel.org>,
        "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        Aleksandr Burmashev <alexander.burmashev@oracle.com>,
        "allen.cryptic@gmail.com" <allen.cryptic@gmail.com>,
        "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
        "andy.shevchenko@gmail.com" <andy.shevchenko@gmail.com>,
        "ardb@kernel.org" <ardb@kernel.org>,
        "btrotter@gmail.com" <btrotter@gmail.com>,
        Daniel Kiper <daniel.kiper@oracle.com>,
        "dpsmith@apertussolutions.com" <dpsmith@apertussolutions.com>,
        Eric DeVolder <eric.devolder@oracle.com>,
        Eric Snowberg <eric.snowberg@oracle.com>,
        "frowand.list@gmail.com" <frowand.list@gmail.com>,
        "hpa@zytor.com" <hpa@zytor.com>,
        "hun@n-dimensional.de" <hun@n-dimensional.de>,
        "james.dutton@gmail.com" <james.dutton@gmail.com>,
        "javierm@redhat.com" <javierm@redhat.com>,
        Joao Martins <joao.m.martins@oracle.com>,
        Kanth Ghatraju <kanth.ghatraju@oracle.com>,
        Konrad Wilk <konrad.wilk@oracle.com>,
        "krystian.hebel@3mdeb.com" <krystian.hebel@3mdeb.com>,
        "leif@nuviainc.com" <leif@nuviainc.com>,
        "lukasz.hawrylko@intel.com" <lukasz.hawrylko@intel.com>,
        "luto@amacapital.net" <luto@amacapital.net>,
        "michal.zygowski@3mdeb.com" <michal.zygowski@3mdeb.com>,
        "mjg59@google.com" <mjg59@google.com>,
        "mtottenh@akamai.com" <mtottenh@akamai.com>,
        "nico.h@gmx.de" <nico.h@gmx.de>,
        "phcoder@gmail.com" <phcoder@gmail.com>,
        "piotr.krol@3mdeb.com" <piotr.krol@3mdeb.com>,
        "pjones@redhat.com" <pjones@redhat.com>,
        "pmenzel@molgen.mpg.de" <pmenzel@molgen.mpg.de>,
        "rasmus.villemoes@prevas.dk" <rasmus.villemoes@prevas.dk>,
        "rdunlap@infradead.org" <rdunlap@infradead.org>,
        "roger.pau@citrix.com" <roger.pau@citrix.com>,
        Ross Philipson <ross.philipson@oracle.com>,
        "sjg@chromium.org" <sjg@chromium.org>,
        "trini@konsulko.com" <trini@konsulko.com>,
        "tyhicks@linux.microsoft.com" <tyhicks@linux.microsoft.com>,
        "ulrich.windl@rz.uni-regensburg.de" <ulrich.windl@rz.uni-regensburg.de>,
        "wvervoorn@eltan.com" <wvervoorn@eltan.com>,
        "xypron.glpk@gmx.de" <xypron.glpk@gmx.de>,
        "rharwood@redhat.com" <rharwood@redhat.com>
Subject: Re: [External] : Re: [SPECIFICATION RFC v3] The firmware and
 bootloader log specification
Message-ID: <YXtAWTHgN6o39Jwj@alec-orcl>
References: <DM6PR10MB2986A960E859A744FDC3875ABCDE9@DM6PR10MB2986.namprd10.prod.outlook.com>
 <CAODwPW-bbHp3Nxbr9VRt0hZMX0xRnwbGb07PS=8uysXEKFs61w@mail.gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAODwPW-bbHp3Nxbr9VRt0hZMX0xRnwbGb07PS=8uysXEKFs61w@mail.gmail.com>
X-ClientProxiedBy: BL0PR1501CA0031.namprd15.prod.outlook.com
 (2603:10b6:207:17::44) To DM6PR10MB2986.namprd10.prod.outlook.com
 (2603:10b6:5:6b::26)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: be0430f2-c87a-48eb-e40f-08d99a7324fc
X-MS-TrafficTypeDiagnostic: DM6PR10MB4171:
X-Microsoft-Antispam-PRVS: 
	<DM6PR10MB41719F5A0A6F15424086305EBC879@DM6PR10MB4171.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 
	nRnDl7rzvUiwShsMEJHN207ZiC0/2wlhIwGYWvF3FEnOGJZbDwt2HXxIHmqeDh4WZGRr4C6ZxyNZx8/WVdY5k9B3Kvur6IMNXRfN7rWtTPMIqGAb6+WuJfJz9eBNr0AuC5Vjw7kytVet+A8HC3uhIa6yu3ztWQMGQ1sEsScBqcW1EdkUB53yHLenEZs8kEKWYVOWiKaHzIzNkn++OMiGNNZnRj+baLhNkF65BbeSXwJOMFVZFEE9uhHviSlS0uMtkQy7Vp1Wy9zCBkfxHlfnpmwmcptecqNbJzMB2E6je/BFPKYaEuLuNXOexsuZ6wZU7bXjTMCpszuSm6kDb84kiMW6zFOxhB39QU2kD/pzVh0G+NpbUL4DS2rMaor15ahNjgnR8cGuPoQUjn/N0WAExvuC2XHP+GPXIQSShtLplxZNLrenHYpr5tbalCeoOqt2EZabRDvKzPBq80i9vvIXnrE+V50Uog4QkyU5bUDRrFowmxZlDGA9oIYQIjL9gVbKlMSt3iulzCFm8prArsL0XKP4slG8cZ17Bl+Y+vl+iTwTdfbPTknAY1ggvF6fri3ixX2Gv08p4LEk8sIBoqK4fdqDarz+43X6T8/efxZoeJyoD6Q3B82i1zkOJewUhyMkxm22WLGUO5koyE//WtW/Pg==
X-Forefront-Antispam-Report: 
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR10MB2986.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(508600001)(26005)(9686003)(55016002)(186003)(38100700002)(83380400001)(66556008)(66946007)(66476007)(956004)(6916009)(8676002)(7416002)(316002)(8936002)(6496006)(86362001)(4326008)(33716001)(54906003)(5660300002)(7406005)(2906002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?3P6oqVrydYTje+cOyHXO3l/3o9KCV0snOBLUPOPu1f5/sVX6jRPJMyNliBSP?=
 =?us-ascii?Q?nPrax4ups8U/VC1fB10Nu3672baVY+HDrI6WKSv0g+sPwUaZes3/1oN2op4C?=
 =?us-ascii?Q?b9O8RDaHnfMAcrO0gk4q3t58YVbdE6rnEAdehL07kWa9USdS+mSDjMi3Wkk6?=
 =?us-ascii?Q?hqsykvLshfZKIKmNGWI9cR3kYmSihcysbwpYdNiTv69eC+ApbsJ6yAgK9wVC?=
 =?us-ascii?Q?F5RYORecuX/wZl6D8iHDrsm7BfHO9k+FRvBb20wWtyn8IZmAOz+4t0YSOZeJ?=
 =?us-ascii?Q?rKdNK1Hsqo82/xZtZjco26aCBCGKZWqWvaS9O2drk3wA2OmaTeV7D3B2LFET?=
 =?us-ascii?Q?NuNRAjspI8CiW1wJVGashDbqRM328RrN9xPRMInMGP2Xr49fBlGCsvBbY9Om?=
 =?us-ascii?Q?TZ4jHBfQL7heVFP31toOEoLxNp3ir59bfhupG0Fd6xIMLpyPsGQL2CQOOgAu?=
 =?us-ascii?Q?dC+/Dl6ehUGHjggpRbHnNaf2h9erN9dce5Y7OfhlypOTBTAVktw9k9BbeIOL?=
 =?us-ascii?Q?FzzMrVqUS6OmjN50mYiwFLTK+rMfEbxw35ygz1pQBbx0+TrmfQIKz9yvYhjW?=
 =?us-ascii?Q?AikTYSxFZxfMAQYc7KXV73OU0+XImORg1qGJdYmhonsaER4OFulv2Bfov7u0?=
 =?us-ascii?Q?9fqtJTRt17dupm/Um13D/o7gOccsXgfsGTnnmZVGxTsfVad/axqNI8GtAX85?=
 =?us-ascii?Q?sJr186xYV/LVVL2qQnewzuNPenEyb9Gi5AI3rIObvH/ApHiFktr5pkpzJL8L?=
 =?us-ascii?Q?IcrNnNw3VmEGrfHwUUfSN5XLpxzybHpkVKEvQ/yDs0cAEEpGrQtisyBc8eP3?=
 =?us-ascii?Q?lje8KVaYwYzpF29d5JdsK0T61JcWIQRw6usyEXIJIwzMMle/dNZuCaZDJW0v?=
 =?us-ascii?Q?51JXJhuQi8q7Eoht/1CGJBWR9yHyy9lYmTWJFfxh5oYfBLwS+t1hPaXZujQA?=
 =?us-ascii?Q?s4RtoROozyl1sVE3L3w+/qLg27fjoL3tQzK4Sl+OwZaPjrX2hBB5IHZAk1HI?=
 =?us-ascii?Q?OuvFQd/sLI5kv3KQst1xDxuyWVax0fYrSecuk4QUMHtLi1aekLFErtMdk3Aw?=
 =?us-ascii?Q?OdQXvPFXM3IFPSp7Nmc7F/FzZjVyPBxM32Rf4RRx0v+d9H2L0/6ec6VoKXoS?=
 =?us-ascii?Q?WSdkZxrCjhuy7V6OphUzhK8c3Krk9J7kpUe6Yny0TX3t26d5leB8n9Y3UlPP?=
 =?us-ascii?Q?iygGditpIgnDJYN9uTTjZtF1DGopB5xaalbs/eIOw3cmYdoEFExdoPfbGY2H?=
 =?us-ascii?Q?YAYTnFBabSJajSWmXyUayQix6HXuzLNfee5SKAVt7710/j/YlSCzc2kL1DSb?=
 =?us-ascii?Q?kgknopJNkuhcvCkoSt4dXxOzoN4H3blPkCD755GJL2F+E7XXv1aHuaKoXVdc?=
 =?us-ascii?Q?R4RMVhwAFdGyFzJPClO7NtefpWoKNxjHoMQ7suRJUpDnJkpTrWP6ahh0TaKL?=
 =?us-ascii?Q?HHtLTIjEtki7ka3Q/l6Y/fChbhykZZXq/Z7ZkSfE04al8t7OJuV/vBdOAw0n?=
 =?us-ascii?Q?RPwqpbJNVdHWvHHZ5Eg+PD4bxMm6boeBocXmDMt22PC8blEjokBqmRiaWcz5?=
 =?us-ascii?Q?BSg4MrvaX7h8YDHQE+HESWyaqWnOlYmO4IFJX0q9AvUEQvztZS5WNe+pD4wE?=
 =?us-ascii?Q?M27wkTPnVdxL0liTZFY89i8=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: be0430f2-c87a-48eb-e40f-08d99a7324fc
X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB2986.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Oct 2021 00:29:18.5473
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: K62zotkXHxCdifU2M+TY5iXEzTqCyLa098SCEH8c1QiVWVgBjaVJDMtlTqryPrdudBoUi6fMfhAixhKeDCorRQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR10MB4171
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10151 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 mlxlogscore=999
 bulkscore=0 phishscore=0 mlxscore=0 spamscore=0 adultscore=0
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2110290000
X-Proofpoint-ORIG-GUID: oZt1Bea1WYvCpkCBK5SynMwh49YipoXc
X-Proofpoint-GUID: oZt1Bea1WYvCpkCBK5SynMwh49YipoXc

On Tue, Sep 21, 2021 at 03:07:25PM -0700, Julius Werner wrote:
> > Since it doesn't seem possible to have each boot component using the same log
> > format, we added a log_format and log_phys_addr fields to give flexibility in
> > how logs are stored. An example of a different log format that can be used is
> > the cbmem_console log format used by coreboot:
> 
> I am not exactly sure how you expect this interoperability you seem to
> be suggesting here to work. Are you saying that your bf_log_header can
> sometimes point to the bf_log_buffer structure you define, and
> sometimes to a coreboot CBMEM console buffer? But that's a completely
> different format that requires a different reader implementation, how
> is that supposed to work? If this proposal is just "we define a
> wrapper structure that points to everyone's custom firmware log
> implementation", then I don't really see the point (the only benefit
> still left then might be discovery of the log buffer, but that's the
> part you leave open in your design while all those other
> implementations already have working discovery mechanisms of their own
> anyway).
>

Depending on the preferred logging format by the boot component, bf_log_header
can point to our bf_log_buffer, a Coreboot CBMEM console buffer, or some other
preferred logging format. We are looking at ways to pass all logs through one
mechanism to make it simpler to discover all logs along the boot chain. From our
understanding, the CBMEM console is passed to the OS via a CBMEM table stored in
lower memory in a forwarding entry and is discovered by a user space tool
looking through /dev/mem. Is this correct? We aren't entirely sure how other
implementations of log buffers accomplish this, but we think that an explicit
mechanism can be beneficial. This is something we'll need to expand upon in the
specification.
 
> For the other structures you have defined, the same feedback that I
> think was already mentioned on the last iteration of this thread still
> applies: it seems incredibly bloated for a simple firmware logging
> mechanism. You have a whooping 24+n bytes of overhead *per line* which
> probably comes out to somewhere between 30-50% of total space wasted
> on overhead for the average log buffer. I guess there are just
> fundamentally different opinions on how featureful a firmware log
> mechanism needs to be so we're probably not gonna find a format that
> makes everyone happy here, but at least for the coreboot project I see
> little reason for us to implement something like this when we already
> have a well-working existing solution with tooling and wideranged
> support.

Since, the logging format we are proposing won't be the best for each boot
component environment, we are giving the option for boot components to use other
logging formats that best suits their environment.


From xen-devel-bounces@lists.xenproject.org Fri Oct 29 01:33:00 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Oct 2021 01:33:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.218368.378763 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgGku-0003yJ-75; Fri, 29 Oct 2021 01:32:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 218368.378763; Fri, 29 Oct 2021 01:32:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgGku-0003yC-1g; Fri, 29 Oct 2021 01:32:28 +0000
Received: by outflank-mailman (input) for mailman id 218368;
 Fri, 29 Oct 2021 01:32:26 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mgGks-0003y2-Mg; Fri, 29 Oct 2021 01:32:26 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mgGks-0006Ok-E1; Fri, 29 Oct 2021 01:32:26 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mgGkr-0003na-T6; Fri, 29 Oct 2021 01:32:26 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mgGkr-00033j-Pw; Fri, 29 Oct 2021 01:32:25 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=PDkUqhfiY0RqzCosK2JKPCkVt/pA0jGiyQinmyt1ezc=; b=iCmIGkYM3jBgkLliiPF9asONGM
	zHKnLKZLXg7cCz2Ix4DTN4JkA0ObPVfSJbpYQZ0vqWF/Sbc+arrN3pTmsd7UT5hmyHsEoR6+wbIW1
	CYh+OuKZIEI+AZfqaRoX6agDneRuTNHq3lvXHwbRK3NjZQI6ZRIhf4k3Ms4Ah9CkmHE8=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165926-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 165926: regressions - FAIL
X-Osstest-Failures:
    qemu-mainline:build-i386:xen-build:fail:regression
    qemu-mainline:build-i386-xsm:xen-build:fail:regression
    qemu-mainline:build-armhf:xen-build:fail:regression
    qemu-mainline:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-amd:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-pair:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-freebsd10-i386:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-freebsd10-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-coresched-i386-xl:build-check(1):blocked:nonblocking
    qemu-mainline:build-armhf-libvirt:build-check(1):blocked:nonblocking
    qemu-mainline:build-i386-libvirt:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-intel:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-shadow:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-vhd:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=c52d69e7dbaaed0ffdef8125e79218672c30161d
X-Osstest-Versions-That:
    qemuu=50352cce138ef3b30c1cda28a4df68fff5da3202
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 29 Oct 2021 01:32:25 +0000

flight 165926 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165926/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-i386                    6 xen-build                fail REGR. vs. 165682
 build-i386-xsm                6 xen-build                fail REGR. vs. 165682
 build-armhf                   6 xen-build                fail REGR. vs. 165682

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl           1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-credit2   1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-cubietruck  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-multivcpu  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-rtds      1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-vhd       1 build-check(1)               blocked  n/a
 test-amd64-i386-qemuu-rhel6hvm-amd  1 build-check(1)               blocked n/a
 test-amd64-i386-pair          1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-freebsd10-i386  1 build-check(1)               blocked  n/a
 test-amd64-i386-freebsd10-amd64  1 build-check(1)               blocked  n/a
 test-amd64-coresched-i386-xl  1 build-check(1)               blocked  n/a
 build-armhf-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-credit1   1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-arndale   1 build-check(1)               blocked  n/a
 test-amd64-i386-qemuu-rhel6hvm-intel  1 build-check(1)             blocked n/a
 test-amd64-i386-xl            1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-pvshim     1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-qemuu-debianhvm-amd64  1 build-check(1)         blocked n/a
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow  1 build-check(1)  blocked n/a
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm  1 build-check(1)      blocked n/a
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 1 build-check(1) blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a
 test-amd64-i386-xl-qemuu-win7-amd64  1 build-check(1)              blocked n/a
 test-amd64-i386-xl-qemuu-ws16-amd64  1 build-check(1)              blocked n/a
 test-amd64-i386-xl-shadow     1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-vhd        1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-xsm        1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165682
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165682
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165682
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 qemuu                c52d69e7dbaaed0ffdef8125e79218672c30161d
baseline version:
 qemuu                50352cce138ef3b30c1cda28a4df68fff5da3202

Last test of basis   165682  2021-10-19 21:09:14 Z    9 days
Failing since        165694  2021-10-20 18:09:12 Z    8 days   19 attempts
Testing same since   165920  2021-10-27 21:39:18 Z    1 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
  Alistair Francis <alistair.francis@wdc.com>
  Andrew Jones <drjones@redhat.com>
  Ani Sinha <ani@anisinha.ca>
  BALATON Zoltan <balaton@eik.bme.hu>
  Bin Meng <bmeng.cn@gmail.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Cédric Le Goater <clg@kaod.org>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  David Gibson <david@gibson.dropbear.id.au>
  David Hildenbrand <david@redhat.com>
  Dr. David Alan Gilbert <dgilbert@redhat.com>
  Eric Auger <eric.auger@redhat.com>
  Eugenio Pérez <eperezma@redhat.com>
  Frank Chang <frank.chang@sifive.com>
  Gavin Shan <gshan@redhat.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Greg Kurz <groug@kaod.org>
  Gustavo Romero <gromero@linux.ibm.com>
  Igor Mammedov <imammedo@redhat.com>
  Jason Wang <jasowang@redhat.com>
  John Wang <wangzhiqiang02@inspur.com>
  John Wang <wangzq.jn@gmail.com>
  Laurent Vivier <laurent@vivier.eu>
  Laurent Vivier <lvivier@redhat.com>
  Luc Michel <lmichel@kalray.eu>
  Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
  Markus Armbruster <armbru@redhat.com>
  Matheus Ferst <matheus.ferst@eldorado.org.br>
  Mathieu Poirier <mathieu.poirier@linaro.org>
  Michael S. Tsirkin <mst@redhat.com>
  Mingwang Li <limingwang@huawei.com>
  Oğuz Ersen <oguzersen@protonmail.com>
  Peter Krempa <pkrempa@redhat.com>
  Philipp Tomsich <philipp.tomsich@vrull.eu>
  Philippe Mathieu-Daudé <f4bug@amsat.org>
  Philippe Mathieu-Daudé <philmd@redhat.com>
  Richard Henderson <richard.henderson@linaro.org>
  Shuuichirou Ishii <ishii.shuuichir@fujitsu.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Thomas Huth <thuth@redhat.com>
  Tong Ho <tong.ho@xilinx.com>
  Travis Geiselbrecht <travisg@gmail.com>
  Vincent Palatin <vpalatin@rivosinc.com>
  Vivek Goyal <vgoyal@redhat.com>
  Xueming Li <xuemingl@nvidia.com>
  Yanan Wang <wangyanan55@huawei.com>
  Yifei Jiang <jiangyifei@huawei.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               fail    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          blocked 
 test-amd64-i386-xl                                           blocked 
 test-amd64-coresched-i386-xl                                 blocked 
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  blocked 
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       blocked 
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           blocked 
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     blocked 
 test-amd64-i386-freebsd10-amd64                              blocked 
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          blocked 
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          blocked 
 test-armhf-armhf-xl-arndale                                  blocked 
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  blocked 
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  blocked 
 test-armhf-armhf-xl-cubietruck                               blocked 
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         blocked 
 test-amd64-i386-freebsd10-i386                               blocked 
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         blocked 
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                blocked 
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         blocked 
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 blocked 
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    blocked 
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     blocked 
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              blocked 
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    blocked 
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      blocked 
 test-amd64-i386-xl-vhd                                       blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 4111 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Oct 29 04:49:09 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Oct 2021 04:49:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.218376.378777 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgJov-0006mi-6z; Fri, 29 Oct 2021 04:48:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 218376.378777; Fri, 29 Oct 2021 04:48:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgJov-0006mb-32; Fri, 29 Oct 2021 04:48:49 +0000
Received: by outflank-mailman (input) for mailman id 218376;
 Fri, 29 Oct 2021 04:48:47 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=3izX=PR=suse.com=jgross@srs-us1.protection.inumbo.net>)
 id 1mgJot-0006mQ-JU
 for xen-devel@lists.xenproject.org; Fri, 29 Oct 2021 04:48:47 +0000
Received: from smtp-out2.suse.de (unknown [195.135.220.29])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id b11e87bd-aff1-4216-8185-e116b29c4ef2;
 Fri, 29 Oct 2021 04:48:46 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 836721FD5B;
 Fri, 29 Oct 2021 04:48:45 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 519EF13AED;
 Fri, 29 Oct 2021 04:48:45 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id lWh1EC19e2GVQQAAMHmgww
 (envelope-from <jgross@suse.com>); Fri, 29 Oct 2021 04:48:45 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b11e87bd-aff1-4216-8185-e116b29c4ef2
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1635482925; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=LekG6juT/qIhlhdh8j12n+rCTq9RNjI+ZAat+L4EHPY=;
	b=GRz/yiiLwJU84YvKLceV15wuMO8revzGFneV19jTsfizwtQkEokuDCPpKTE/12Cx/ueXsJ
	CnJ6KxSZWrbHlNXloCVQJHc+GTaRnYj7d1IwsqrrjcbLkkRHHHohMVCCsxikaMeJ4UjxS5
	+c+qtQLqvBAcBcHw5i8cRY5lapaGSNc=
To: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?=
 <marmarek@invisiblethingslab.com>
Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org,
 Boris Ostrovsky <boris.ostrovsky@oracle.com>,
 Stefano Stabellini <sstabellini@kernel.org>, stable@vger.kernel.org
References: <20211028105952.10011-1-jgross@suse.com>
 <YXsFO2TMRiJTQM2q@mail-itl>
From: Juergen Gross <jgross@suse.com>
Subject: Re: [PATCH] xen/balloon: add late_initcall_sync() for initial
 ballooning done
Message-ID: <27e7619a-a797-5c46-9f9f-015ab488e31c@suse.com>
Date: Fri, 29 Oct 2021 06:48:44 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <YXsFO2TMRiJTQM2q@mail-itl>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="Au2NSnndHpyE9qEPooGU6Mr1TIE7Tl55C"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--Au2NSnndHpyE9qEPooGU6Mr1TIE7Tl55C
Content-Type: multipart/mixed; boundary="8uodpGNBI7OueoVqXOiFPXcY7Col1GLWS";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?=
 <marmarek@invisiblethingslab.com>
Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org,
 Boris Ostrovsky <boris.ostrovsky@oracle.com>,
 Stefano Stabellini <sstabellini@kernel.org>, stable@vger.kernel.org
Message-ID: <27e7619a-a797-5c46-9f9f-015ab488e31c@suse.com>
Subject: Re: [PATCH] xen/balloon: add late_initcall_sync() for initial
 ballooning done
References: <20211028105952.10011-1-jgross@suse.com>
 <YXsFO2TMRiJTQM2q@mail-itl>
In-Reply-To: <YXsFO2TMRiJTQM2q@mail-itl>

--8uodpGNBI7OueoVqXOiFPXcY7Col1GLWS
Content-Type: multipart/mixed;
 boundary="------------4ACA8F1512DDA652B719B57A"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------4ACA8F1512DDA652B719B57A
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 28.10.21 22:16, Marek Marczykowski-G=C3=B3recki wrote:
> On Thu, Oct 28, 2021 at 12:59:52PM +0200, Juergen Gross wrote:
>> When running as PVH or HVM guest with actual memory < max memory the
>> hypervisor is using "populate on demand" in order to allow the guest
>> to balloon down from its maximum memory size. For this to work
>> correctly the guest must not touch more memory pages than its target
>> memory size as otherwise the PoD cache will be exhausted and the guest=

>> is crashed as a result of that.
>>
>> In extreme cases ballooning down might not be finished today before
>> the init process is started, which can consume lots of memory.
>>
>> In order to avoid random boot crashes in such cases, add a late init
>> call to wait for ballooning down having finished for PVH/HVM guests.
>>
>> Cc: <stable@vger.kernel.org>
>> Reported-by: Marek Marczykowski-G=C3=B3recki <marmarek@invisiblethings=
lab.com>
>> Signed-off-by: Juergen Gross <jgross@suse.com>
>=20
> It may happen that initial balloon down fails (state=3D=3DBP_ECANCELED)=
=2E In
> that case, it waits indefinitely. I think it should rather report a
> failure (and panic? it's similar to OOM before PID 1 starts, so rather
> hard to recover), instead of hanging.

Okay, I can add something like that. I'm thinking of issuing a failure
message in case of credit not having changed for 1 minute and panic()
after two more minutes. Is this fine?


Juergen

--------------4ACA8F1512DDA652B719B57A
Content-Type: application/pgp-keys;
 name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Transfer-Encoding: quoted-printable
Content-Description: OpenPGP public key
Content-Disposition: attachment;
 filename="OpenPGP_0xB0DE9DD628BF132F.asc"

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy=
cWx
w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O=
f8Z
d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y=
9bf
IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq=
G7/
377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR=
3Jv
c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA=
QIe
AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT=
hpw
dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0=
MbD
1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv=
oPH
Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v=
5QL
+qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ=
2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC=
QoL
BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr=
Wf0
teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC=
/nu
AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh=
ITT
d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm=
XBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz=
80h
SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC=
AcD
AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn=
FOX
gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1=
jnD
kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0=
N51
N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l=
otu
fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1=
tqS
EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA=
hsD
BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3=
g3O
ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5=
dM7
wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5=
D+j
LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm=
V2x
AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N=
Eaw
QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW=
nHI
s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR=
wgn
BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV=
bVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk=
pEd
IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA=
QAB
wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw=
Tbe
8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1=
vJz
Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8=
VGi
wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW=
svi
uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX=
zXs
ZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------4ACA8F1512DDA652B719B57A--

--8uodpGNBI7OueoVqXOiFPXcY7Col1GLWS--

--Au2NSnndHpyE9qEPooGU6Mr1TIE7Tl55C
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmF7fSwFAwAAAAAACgkQsN6d1ii/Ey/M
ZQf9G3a7RxLRSsreeOp23xshh0hqFaa/1485PcGwIiqomUJzKTdYO0sPlt8iMUSgRkzN25Ty48+2
MZ+cDshVeh0hfrm7ilWevH6osOln9b2GUPByu0v7VsZlPHCkgUbGJArp1zEu948pdUPn9kfAxhYP
iq3IgncDd8U/KnIBu0WbAIbr1a0bkcjk44LNDmLwNp1jxfKAvPuSPcpBmCc7oR2cegAicocvxJ8D
taSA6v6jPfvbsei8uXTtuPX2+R613AagOGU0hSm+5M8IyTFIaEEjAq72K1zKT22Uwhvfoqd9VSBR
QmoDem9JBNZ1Fj7QPdZa8V3stf3DBNkErQSNwc38WQ==
=utb5
-----END PGP SIGNATURE-----

--Au2NSnndHpyE9qEPooGU6Mr1TIE7Tl55C--


From xen-devel-bounces@lists.xenproject.org Fri Oct 29 05:41:41 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Oct 2021 05:41:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.218384.378787 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgKdp-0004vM-5p; Fri, 29 Oct 2021 05:41:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 218384.378787; Fri, 29 Oct 2021 05:41:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgKdp-0004vF-2T; Fri, 29 Oct 2021 05:41:25 +0000
Received: by outflank-mailman (input) for mailman id 218384;
 Fri, 29 Oct 2021 05:41:24 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mgKdn-0004v3-V7; Fri, 29 Oct 2021 05:41:23 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mgKdn-0003NQ-O1; Fri, 29 Oct 2021 05:41:23 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mgKdn-0005YT-Bl; Fri, 29 Oct 2021 05:41:23 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mgKdn-00018S-Ac; Fri, 29 Oct 2021 05:41:23 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=YU4HjoQZCS7adZ/lHgGvoyBzRMtSJ1vZx/5uH9oD54c=; b=OxoSzGGsq0B5MNapshX04UXXjL
	lFkLFleVylP7iR/WhoRaiaEubKdEuOtKqvgV8WexJNpzsoAjyYBwp2sgrykns/79fkRgGFQ6+kPAf
	2r78G2WMIYTURf3rMMw+Nxg5S5txlsrrnVzCrjS4bZhnUxYGE3GNUw9+W0pibnI269Oc=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165927-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 165927: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-examine:memdisk-try-append:fail:heisenbug
    linux-linus:test-amd64-amd64-freebsd11-amd64:guest-start/freebsd.repeat:fail:heisenbug
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=411a44c24a561e449b592ff631b7ae321f1eb559
X-Osstest-Versions-That:
    linux=1fc596a56b334f4d593a2b49e5ff55af6aaa0816
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 29 Oct 2021 05:41:23 +0000

flight 165927 linux-linus real [real]
flight 165930 linux-linus real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/165927/
http://logs.test-lab.xenproject.org/osstest/logs/165930/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-examine      4 memdisk-try-append  fail pass in 165930-retest
 test-amd64-amd64-freebsd11-amd64 21 guest-start/freebsd.repeat fail pass in 165930-retest

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 165916
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 165916
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165916
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 165916
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165916
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 165916
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 165916
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165916
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass

version targeted for testing:
 linux                411a44c24a561e449b592ff631b7ae321f1eb559
baseline version:
 linux                1fc596a56b334f4d593a2b49e5ff55af6aaa0816

Last test of basis   165916  2021-10-27 18:10:33 Z    1 days
Testing same since   165927  2021-10-28 17:40:51 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Alexei Starovoitov <ast@kernel.org>
  Andrew Lunn <andrew@lunn.ch>
  Björn Töpel <bjorn@kernel.org>
  Christian Brauner <christian.brauner@ubuntu.com>
  Cong Wang <cong.wang@bytedance.com>
  Cyril Strejc <cyril.strejc@skoda.cz>
  Daniel Borkmann <daniel@iogearbox.net>
  Daniel Jordan <daniel.m.jordan@oracle.com>
  Dave Ertman <david.m.ertman@intel.com>
  David Ahern <dsahern@kernel.org>
  David S. Miller <davem@davemloft.net>
  Davide Caratti <dcaratti@redhat.com>
  Dongli Zhang <dongli.zhang@oracle.com>
  Florian Westphal <fw@strlen.de>
  Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  Guangbin Huang <huangguangbin2@huawei.com>
  Guenter Roeck <linux@roeck-us.net>
  Gurucharan G <gurucharanx.g@intel.com>
  Ido Schimmel <idosch@nvidia.com>
  Jakub Kicinski <kuba@kernel.org>
  Jamie Iles <quic_jiles@quicinc.com>
  Janghyub Seo <jhyub06@gmail.com>
  Janusz Dziedzic <janusz.dziedzic@gmail.com>
  Jason Wang <jasowang@redhat.com>
  Jie Wang <wangjie125@huawei.com>
  Johan Hovold <johan@kernel.org>
  Johannes Berg <johannes.berg@intel.com>
  John Fastabend <john.fastabend@gmail.com>
  Jon Maloy <jmaloy@redhat.com>
  Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Liu Jian <liujian56@huawei.com>
  Lorenz Bauer <lmb@cloudflare.com>
  Luke Nelson <luke.r.nels@gmail.com>
  Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
  Mark Brown <broonie@kernel.org>
  Martin KaFai Lau <kafai@fb.com>
  Mat Martineau <mathew.j.martineau@linux.intel.com>
  Max VA <maxv@sentinelone.com>
  Michael Chan <michael.chan@broadcom.com>
  Michael S. Tsirkin <mst@redhat.com>
  Nithin Dabilpuram <ndabilpuram@marvell.com>
  Pavel Skripkin <paskripkin@gmail.com>
  Quanyang Wang <quanyang.wang@windriver.com>
  Rakesh Babu <rsaladi2@marvell.com>
  Rakesh Babu Saladi <rsaladi2@marvell.com>
  Randy Dunlap <rdunlap@infradead.org>
  Roman Gushchin <guro@fb.com>
  Russ Weight <russell.h.weight@intel.com>
  Simon Horman <simon.horman@corigine.com>
  Steven Rostedt (VMware) <rostedt@goodmis.org>
  Subbaraya Sundeep <sbhatta@marvell.com>
  Sunil Goutham <sgoutham@marvell.com>
  Sunil Kovvuri Goutham <sgoutham@marvell.com>
  Sunil Kovvuri Goutham <Sunil.Goutham@cavium.com>
  Sven Eckelmann <sven@narfation.org>
  Tejun Heo <tj@kernel.org>
  Thomas Perrot <thomas.perrot@bootlin.com>
  Toke Høiland-Jørgensen <toke@redhat.com>
  Tony Brelinski <tony.brelinski@intel.com>
  Tony Lu <tonylu@linux.alibaba.com>
  Tony Nguyen <anthony.l.nguyen@intel.com>
  Trevor Woerner <twoerner@gmail.com>
  Vadym Kochan <vkochan@marvell.com>
  Vasily Averin <vvs@virtuozzo.com>
  Vincent Whitchurch <vincent.whitchurch@axis.com>
  Vladimir Zapolskiy <vz@mleia.com>
  Walter Stoll <Walter.Stoll@duagon.com>
  Wang Hai <wanghai38@huawei.com>
  Wen Gu <guwen@linux.alibaba.com>
  Wim Van Sebroeck <wim@linux-watchdog.org>
  Xie Yongji <xieyongji@bytedance.com>
  Xin Long <lucien.xin@gmail.com>
  Xu Kuohai <xukuohai@huawei.com>
  Yang Yingliang <yangyingliang@huawei.com>
  Ying Xue <ying.xue@windriver.com>
  Yongxin Liu <yongxin.liu@windriver.com>
  Yu Xiao <yu.xiao@corigine.com>
  Yucong Sun <sunyucong@gmail.com>
  Yufeng Mo <moyufeng@huawei.com>
  Yuiko Oshino <yuiko.oshino@microchip.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             fail    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   1fc596a56b33..411a44c24a56  411a44c24a561e449b592ff631b7ae321f1eb559 -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Fri Oct 29 05:43:37 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Oct 2021 05:43:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.218392.378802 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgKfw-0005X4-N5; Fri, 29 Oct 2021 05:43:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 218392.378802; Fri, 29 Oct 2021 05:43:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgKfw-0005Wx-I0; Fri, 29 Oct 2021 05:43:36 +0000
Received: by outflank-mailman (input) for mailman id 218392;
 Fri, 29 Oct 2021 05:43:35 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=3izX=PR=suse.com=jgross@srs-us1.protection.inumbo.net>)
 id 1mgKfv-0005Wr-EN
 for xen-devel@lists.xenproject.org; Fri, 29 Oct 2021 05:43:35 +0000
Received: from smtp-out2.suse.de (unknown [195.135.220.29])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id a586b931-5579-48ac-ac47-be7ddfb8d9ce;
 Fri, 29 Oct 2021 05:43:34 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 99D0B1FD62;
 Fri, 29 Oct 2021 05:43:33 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 4969813AE9;
 Fri, 29 Oct 2021 05:43:33 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id gEYGEAWKe2HDUQAAMHmgww
 (envelope-from <jgross@suse.com>); Fri, 29 Oct 2021 05:43:33 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a586b931-5579-48ac-ac47-be7ddfb8d9ce
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1635486213; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=w8qnuh6NKeWK8CUZKe2fxzHcUtWJLDFvEgoVy0TQ3H8=;
	b=CuN8zqc7FXWe7JJB3e0RaI7fApYnSfqOk5VScYYESql2ja1+fhTGd7u0itqs0yXD58D/DD
	d3Qctcar1jEYmDdhJNGV48RqeL4VDK7xpam1DmK9FcUqdf0+bslIhi7gFD+uInhTjHuHCL
	7qZ5PjGGtta/+bkBs2Bzf4PlhwQWc08=
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 xen-devel@lists.xenproject.org, iwj@xenproject.org, cardoe@cardoe.com,
 wl@xen.org, anthony.perard@citrix.com,
 Stefano Stabellini <stefano.stabellini@xilinx.com>
References: <alpine.DEB.2.21.2110210831470.2311@sstabellini-ThinkPad-T480s>
 <20211021230839.10794-2-sstabellini@kernel.org>
 <19aa9196-eb5f-22a1-206c-c9c87ee79fa9@citrix.com>
 <alpine.DEB.2.21.2110221219300.2311@sstabellini-ThinkPad-T480s>
 <d559b765-9e38-00bd-039b-9c33845b8e54@suse.com>
 <alpine.DEB.2.21.2110251753200.4586@sstabellini-ThinkPad-T480s>
 <8c0a2a97-04ab-4836-fc35-026dd7c122a4@suse.com>
 <alpine.DEB.2.21.2110271543150.20134@sstabellini-ThinkPad-T480s>
 <alpine.DEB.2.21.2110271619240.20134@sstabellini-ThinkPad-T480s>
 <4f82901a-2e74-f4ee-311e-b8187d856745@suse.com>
 <alpine.DEB.2.21.2110280939130.20134@sstabellini-ThinkPad-T480s>
From: Juergen Gross <jgross@suse.com>
Subject: Re: [PATCH 2/3] automation: Linux 5.10.74 test-artifact
Message-ID: <bf4c4138-2bd3-4fcb-b279-9f21495a20cc@suse.com>
Date: Fri, 29 Oct 2021 07:43:32 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.21.2110280939130.20134@sstabellini-ThinkPad-T480s>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="aaoTVkTsdCnKxrv9qpQYkb4ljIpnyQMjA"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--aaoTVkTsdCnKxrv9qpQYkb4ljIpnyQMjA
Content-Type: multipart/mixed; boundary="qyBtStghmxWAQUApAxQujhDGdFBHIsCd1";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 xen-devel@lists.xenproject.org, iwj@xenproject.org, cardoe@cardoe.com,
 wl@xen.org, anthony.perard@citrix.com,
 Stefano Stabellini <stefano.stabellini@xilinx.com>
Message-ID: <bf4c4138-2bd3-4fcb-b279-9f21495a20cc@suse.com>
Subject: Re: [PATCH 2/3] automation: Linux 5.10.74 test-artifact
References: <alpine.DEB.2.21.2110210831470.2311@sstabellini-ThinkPad-T480s>
 <20211021230839.10794-2-sstabellini@kernel.org>
 <19aa9196-eb5f-22a1-206c-c9c87ee79fa9@citrix.com>
 <alpine.DEB.2.21.2110221219300.2311@sstabellini-ThinkPad-T480s>
 <d559b765-9e38-00bd-039b-9c33845b8e54@suse.com>
 <alpine.DEB.2.21.2110251753200.4586@sstabellini-ThinkPad-T480s>
 <8c0a2a97-04ab-4836-fc35-026dd7c122a4@suse.com>
 <alpine.DEB.2.21.2110271543150.20134@sstabellini-ThinkPad-T480s>
 <alpine.DEB.2.21.2110271619240.20134@sstabellini-ThinkPad-T480s>
 <4f82901a-2e74-f4ee-311e-b8187d856745@suse.com>
 <alpine.DEB.2.21.2110280939130.20134@sstabellini-ThinkPad-T480s>
In-Reply-To: <alpine.DEB.2.21.2110280939130.20134@sstabellini-ThinkPad-T480s>

--qyBtStghmxWAQUApAxQujhDGdFBHIsCd1
Content-Type: multipart/mixed;
 boundary="------------00C444EF7015E3FAD7CEB0EB"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------00C444EF7015E3FAD7CEB0EB
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 28.10.21 18:41, Stefano Stabellini wrote:
> On Thu, 28 Oct 2021, Juergen Gross wrote:
>> On 28.10.21 01:24, Stefano Stabellini wrote:
>>> On Wed, 27 Oct 2021, Stefano Stabellini wrote:
>>>> On Wed, 27 Oct 2021, Juergen Gross wrote:
>>>>> On 26.10.21 02:54, Stefano Stabellini wrote:
>>>>>> On Mon, 25 Oct 2021, Juergen Gross wrote:
>>>>>>> On 22.10.21 21:41, Stefano Stabellini wrote:
>>>>>>>> +Juergen
>>>>>>>>
>>>>>>>> On Fri, 22 Oct 2021, Andrew Cooper wrote:
>>>>>>>>> On 22/10/2021 00:08, Stefano Stabellini wrote:
>>>>>>>>>> +# build depends
>>>>>>>>>> +RUN apt-get update && \
>>>>>>>>>> +    apt-get --quiet --yes install \
>>>>>>>>>> +        build-essential \
>>>>>>>>>> +        libssl-dev \
>>>>>>>>>> +        bc \
>>>>>>>>>> +        curl \
>>>>>>>>>> +        flex \
>>>>>>>>>> +        bison \
>>>>>>>>>> +        libelf-dev \
>>>>>>>>>> +        && \
>>>>>>>>>> +    \
>>>>>>>>>> +    # Build the kernel
>>>>>>>>>> +    curl -fsSLO
>>>>>>>>>> https://cdn.kernel.org/pub/linux/kernel/v5.x/linux-"$LINUX_VER=
SION".tar.xz
>>>>>>>>>> && \
>>>>>>>>>> +    tar xvJf linux-"$LINUX_VERSION".tar.xz && \
>>>>>>>>>> +    cd linux-"$LINUX_VERSION" && \
>>>>>>>>>> +    make defconfig && \
>>>>>>>>>> +    make xen.config && \
>>>>>>>>>> +    cp .config .config.orig && \
>>>>>>>>>> +    cat .config.orig | grep XEN | grep =3Dm |sed 's/=3Dm/=3Dy=
/g' >>
>>>>>>>>>> .config
>>>>>>>>>> && \
>>>>>>>>>> +    make -j$(nproc) bzImage && \
>>>>>>>>>
>>>>>>>>> defconfig is huuuuge.=C2=A0 Can we use tinyconfig instead?
>>>>>>>>>
>>>>>>>>> Also, you want to turn off CONFIG_MODULES seeing as you only
>>>>>>>>> copy
>>>>>>>>> bzImage to the test.
>>>>>>>>>
>>>>>>>>> This also fixes the fact that `grep XEN` also matches
>>>>>>>>> CONFIG_NETXEN_NIC
>>>>>>>>> which has nothing to do with Xen.
>>>>>>>>
>>>>>>>> Tinyconfig would be a good idea but it crashes on QEMU with the
>>>>>>>> appended
>>>>>>>> boot log. I did:
>>>>>>>>
>>>>>>>> # make tinyconfig
>>>>>>>> # make xen.config
>>>>>>>> # make bzImage
>>>>>>>>
>>>>>>>> Of course we could have our own tailored special kernel config f=
or
>>>>>>>> this
>>>>>>>> kernel but I like the simplicify of "make tinyconfig" or "make
>>>>>>>> defconfig" followed by "make xen.config".
>>>>>>>>
>>>>>>>> Unless you know one kconfig option or two that we need to add to=

>>>>>>>> tinyconfig to make it work my preference is to go with defconfig=

>>>>>>>> for
>>>>>>>> now.
>>>>>>>
>>>>>>> You will need to add the dom0 and SMP related config options at
>>>>>>> least.
>>>>>>>
>>>>>>> I'll have a look at config.xen, which is a little bit weird: it
>>>>>>> configures the backends, but not dom0.
>>>>>>
>>>>>> Thanks, it would be good if make tinyconfig && make xen.config wou=
ld
>>>>>> just work on QEMU. In the meantime I'll keep defconfig for this te=
st,
>>>>>> we
>>>>>> can always improve later.
>>>>>
>>>>> Can you please test the attached patch?
>>>>
>>>> Yes, that works, thanks!
>>>
>>> Sorry, I spoke too soon: same error as before:
>>>
>>> https://gitlab.com/xen-project/people/sstabellini/xen/-/jobs/17229096=
07/raw
>>>
>>> (XEN) Hardware Dom0 crashed: rebooting machine in 5 seconds.
>>>
>>> No output from the kernel.
>>
>> This is not very surprising, as tinyconfig doesn't have CONFIG_PRINTK.=

>> BTW, it doesn't have initrd support either (BLK_DEV_RAM and
>> BLK_DEV_INITRD), so I added those to xen.config as well.
>>
>> With the (updated) attached patch the kernel boots fine as dom0 until
>> rootfs is tried to be mounted on a physical machine.
>>
>> I've added CONFIG_BUG, too, in order to have more debugging output if
>> needed.
>=20
> Much better, now there is output:
> https://gitlab.com/xen-project/people/sstabellini/xen/-/jobs/1726396600=
/raw
>=20
> This kernel is used as dom0 and from the logs it looks like for dom0 we=

> need a couple more things:
> - flocks

CONFIG_FILE_LOCKING probably wants to be added.

> - the kconfig to recognize #!/bin/sh

This is probably CONFIG_BINFMT_SCRIPT.

I'm not sure those should be added to the upstream xen.config.


Juergen

--------------00C444EF7015E3FAD7CEB0EB
Content-Type: application/pgp-keys;
 name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Transfer-Encoding: quoted-printable
Content-Description: OpenPGP public key
Content-Disposition: attachment;
 filename="OpenPGP_0xB0DE9DD628BF132F.asc"

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy=
cWx
w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O=
f8Z
d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y=
9bf
IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq=
G7/
377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR=
3Jv
c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA=
QIe
AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT=
hpw
dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0=
MbD
1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv=
oPH
Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v=
5QL
+qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ=
2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC=
QoL
BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr=
Wf0
teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC=
/nu
AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh=
ITT
d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm=
XBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz=
80h
SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC=
AcD
AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn=
FOX
gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1=
jnD
kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0=
N51
N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l=
otu
fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1=
tqS
EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA=
hsD
BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3=
g3O
ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5=
dM7
wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5=
D+j
LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm=
V2x
AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N=
Eaw
QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW=
nHI
s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR=
wgn
BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV=
bVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk=
pEd
IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA=
QAB
wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw=
Tbe
8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1=
vJz
Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8=
VGi
wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW=
svi
uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX=
zXs
ZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------00C444EF7015E3FAD7CEB0EB--

--qyBtStghmxWAQUApAxQujhDGdFBHIsCd1--

--aaoTVkTsdCnKxrv9qpQYkb4ljIpnyQMjA
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmF7igQFAwAAAAAACgkQsN6d1ii/Ey9T
SQf/bzR34G8TGpKCfe6/SPYU4o6+gOavvVocoDI70P5vTWaUFSs5KKWjtI2vlVPM0MxTzAFJ64qZ
1oopQ0aW/6dU6ek3Pv5GiisPTbBrYPe5VI23tvXDCg9Kp0XPoobqzJa/n8qk6tjzh1C13wTagqcF
cG7KAkfhjxUYqI0mLXIONuxmZToMM2pmJmaofpJ5SZMe9JnCuoZziFz2fRjWZn8aDtMTtiwTi/QQ
dCmUanY2sGOjEGJRf3/HWTZfJENXIX9iPysjSO4vtUq1zZcGojeHQiuIeLTynFwW68ZI3sSgxJUR
LE2Xz8/c6HwQGO40QqCuRVXWcu8VB7gUd2p0JyjYHA==
=aocm
-----END PGP SIGNATURE-----

--aaoTVkTsdCnKxrv9qpQYkb4ljIpnyQMjA--


From xen-devel-bounces@lists.xenproject.org Fri Oct 29 06:51:04 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Oct 2021 06:51:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.218400.378812 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgLie-0004Rs-N2; Fri, 29 Oct 2021 06:50:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 218400.378812; Fri, 29 Oct 2021 06:50:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgLie-0004Rl-Jf; Fri, 29 Oct 2021 06:50:28 +0000
Received: by outflank-mailman (input) for mailman id 218400;
 Fri, 29 Oct 2021 06:50:27 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mgLic-0004RY-Ud; Fri, 29 Oct 2021 06:50:26 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mgLic-0004Xx-ON; Fri, 29 Oct 2021 06:50:26 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mgLic-0001Mo-Dt; Fri, 29 Oct 2021 06:50:26 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mgLic-0004YI-D9; Fri, 29 Oct 2021 06:50:26 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=npBBFFBmk53NhOVHKZTlJ3tHeXllHLB6v+U/f8FtiP4=; b=dqJOMQXU6DNlzFRh2uDpbkAza3
	Tn/1z50n+Ry0yuAFDykno6J+uNbx43Jh2u9IN5eOEwrV/MvluwpOzelgeVeoCEhAonsOCZoVkSdfw
	qTXb723YzdRPYYHaOIXZfpJkM/lwp5Wu4KrrJx1y1iFz83Sdc9+8lssnEOZyka4wv7/8=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165928-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 165928: regressions - FAIL
X-Osstest-Failures:
    qemu-mainline:build-i386:xen-build:fail:regression
    qemu-mainline:build-i386-xsm:xen-build:fail:regression
    qemu-mainline:build-armhf:xen-build:fail:regression
    qemu-mainline:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-amd:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-pair:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-freebsd10-i386:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-freebsd10-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-coresched-i386-xl:build-check(1):blocked:nonblocking
    qemu-mainline:build-armhf-libvirt:build-check(1):blocked:nonblocking
    qemu-mainline:build-i386-libvirt:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-intel:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-shadow:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-vhd:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=c52d69e7dbaaed0ffdef8125e79218672c30161d
X-Osstest-Versions-That:
    qemuu=50352cce138ef3b30c1cda28a4df68fff5da3202
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 29 Oct 2021 06:50:26 +0000

flight 165928 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165928/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-i386                    6 xen-build                fail REGR. vs. 165682
 build-i386-xsm                6 xen-build                fail REGR. vs. 165682
 build-armhf                   6 xen-build                fail REGR. vs. 165682

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl           1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-credit2   1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-cubietruck  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-multivcpu  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-rtds      1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-vhd       1 build-check(1)               blocked  n/a
 test-amd64-i386-qemuu-rhel6hvm-amd  1 build-check(1)               blocked n/a
 test-amd64-i386-pair          1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-freebsd10-i386  1 build-check(1)               blocked  n/a
 test-amd64-i386-freebsd10-amd64  1 build-check(1)               blocked  n/a
 test-amd64-coresched-i386-xl  1 build-check(1)               blocked  n/a
 build-armhf-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-arndale   1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-credit1   1 build-check(1)               blocked  n/a
 test-amd64-i386-qemuu-rhel6hvm-intel  1 build-check(1)             blocked n/a
 test-amd64-i386-xl            1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-pvshim     1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-qemuu-debianhvm-amd64  1 build-check(1)         blocked n/a
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow  1 build-check(1)  blocked n/a
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm  1 build-check(1)      blocked n/a
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 1 build-check(1) blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a
 test-amd64-i386-xl-qemuu-win7-amd64  1 build-check(1)              blocked n/a
 test-amd64-i386-xl-qemuu-ws16-amd64  1 build-check(1)              blocked n/a
 test-amd64-i386-xl-shadow     1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-vhd        1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-xsm        1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165682
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165682
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165682
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 qemuu                c52d69e7dbaaed0ffdef8125e79218672c30161d
baseline version:
 qemuu                50352cce138ef3b30c1cda28a4df68fff5da3202

Last test of basis   165682  2021-10-19 21:09:14 Z    9 days
Failing since        165694  2021-10-20 18:09:12 Z    8 days   20 attempts
Testing same since   165920  2021-10-27 21:39:18 Z    1 days    3 attempts

------------------------------------------------------------
People who touched revisions under test:
  Alistair Francis <alistair.francis@wdc.com>
  Andrew Jones <drjones@redhat.com>
  Ani Sinha <ani@anisinha.ca>
  BALATON Zoltan <balaton@eik.bme.hu>
  Bin Meng <bmeng.cn@gmail.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Cédric Le Goater <clg@kaod.org>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  David Gibson <david@gibson.dropbear.id.au>
  David Hildenbrand <david@redhat.com>
  Dr. David Alan Gilbert <dgilbert@redhat.com>
  Eric Auger <eric.auger@redhat.com>
  Eugenio Pérez <eperezma@redhat.com>
  Frank Chang <frank.chang@sifive.com>
  Gavin Shan <gshan@redhat.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Greg Kurz <groug@kaod.org>
  Gustavo Romero <gromero@linux.ibm.com>
  Igor Mammedov <imammedo@redhat.com>
  Jason Wang <jasowang@redhat.com>
  John Wang <wangzhiqiang02@inspur.com>
  John Wang <wangzq.jn@gmail.com>
  Laurent Vivier <laurent@vivier.eu>
  Laurent Vivier <lvivier@redhat.com>
  Luc Michel <lmichel@kalray.eu>
  Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
  Markus Armbruster <armbru@redhat.com>
  Matheus Ferst <matheus.ferst@eldorado.org.br>
  Mathieu Poirier <mathieu.poirier@linaro.org>
  Michael S. Tsirkin <mst@redhat.com>
  Mingwang Li <limingwang@huawei.com>
  Oğuz Ersen <oguzersen@protonmail.com>
  Peter Krempa <pkrempa@redhat.com>
  Philipp Tomsich <philipp.tomsich@vrull.eu>
  Philippe Mathieu-Daudé <f4bug@amsat.org>
  Philippe Mathieu-Daudé <philmd@redhat.com>
  Richard Henderson <richard.henderson@linaro.org>
  Shuuichirou Ishii <ishii.shuuichir@fujitsu.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Thomas Huth <thuth@redhat.com>
  Tong Ho <tong.ho@xilinx.com>
  Travis Geiselbrecht <travisg@gmail.com>
  Vincent Palatin <vpalatin@rivosinc.com>
  Vivek Goyal <vgoyal@redhat.com>
  Xueming Li <xuemingl@nvidia.com>
  Yanan Wang <wangyanan55@huawei.com>
  Yifei Jiang <jiangyifei@huawei.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               fail    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          blocked 
 test-amd64-i386-xl                                           blocked 
 test-amd64-coresched-i386-xl                                 blocked 
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  blocked 
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       blocked 
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           blocked 
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     blocked 
 test-amd64-i386-freebsd10-amd64                              blocked 
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          blocked 
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          blocked 
 test-armhf-armhf-xl-arndale                                  blocked 
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  blocked 
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  blocked 
 test-armhf-armhf-xl-cubietruck                               blocked 
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         blocked 
 test-amd64-i386-freebsd10-i386                               blocked 
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         blocked 
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                blocked 
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         blocked 
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 blocked 
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    blocked 
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     blocked 
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              blocked 
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    blocked 
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      blocked 
 test-amd64-i386-xl-vhd                                       blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 4111 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Oct 29 07:34:28 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Oct 2021 07:34:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.218408.378827 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgMP8-0000ah-W7; Fri, 29 Oct 2021 07:34:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 218408.378827; Fri, 29 Oct 2021 07:34:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgMP8-0000aa-Sv; Fri, 29 Oct 2021 07:34:22 +0000
Received: by outflank-mailman (input) for mailman id 218408;
 Fri, 29 Oct 2021 07:34:21 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=slsI=PR=citrix.com=roger.pau@srs-us1.protection.inumbo.net>)
 id 1mgMP7-0000aU-6C
 for xen-devel@lists.xenproject.org; Fri, 29 Oct 2021 07:34:21 +0000
Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id a07bef66-388a-11ec-850a-12813bfff9fa;
 Fri, 29 Oct 2021 07:34:19 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a07bef66-388a-11ec-850a-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1635492859;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=Htls4ulL51CujrqXzqk25KMUmpC6GMMGah5DA47sNNo=;
  b=BA/iao6iwzpAK0XDO7liHsRDabdIxjNzyfqsTmAKmMh2lYH1hcAlyBlf
   e7d7KNLKkFC+ysb+DNXRBaoHqAnTW/ilktcQoOIH4N4Rh7dXEVZOdGhpk
   Zm+rPsiOdEPiX7WcLBpAEr6q1CgFGszb5FmNEB6pBy8OGZiMcnWLqn74w
   M=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: KXs+zWnLr1v6cyWSLH38C6MP+35KnOoOsIauKe0PhUEbch8JBmj2f1Z9msdXO1gPJCp/xBFKh4
 UsNJcynB0TLwWB8HUePs42h8/3aU3NKsJHxjtksLi7kaBno2gLAfEmucfYQkINUKw+NjYaete5
 I3nF8uim/mLo+2Bk7Pwg9oEca1KHsP3DAtH1f6Iie8wWOs+2/3G7/josXT2B+29J+Rb4HSATyL
 JsB+GfLaKd3BrRP1pcXQcNy3isN3hbcZs3eAlGWmxJgSJZOesUNcz2UTTHZ2EejbMKS7EqjIQ2
 ADbQ5Cg+dplXqbgCIoCINlj6
X-SBRS: 5.1
X-MesageID: 56613373
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:F5Ae4q5WTOE5zaMZhGOYNgxRtIfAchMFZxGqfqrLsTDasY5as4F+v
 mNMDzqGOvuCYTTxfYgnb9jj9U5TscfWmt9qTARq/C1jHi5G8cbLO4+Ufxz6V8+wwmwvb67FA
 +E2MISowBUcFyeEzvuV3zyIQUBUjclkfJKlYAL/En03FVAMpBsJ00o5wrdh2N4w2rBVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Zx
 o9Rtru/Qg0SAJaPgsk5aBN/OR9aMvgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALNs7kMZlZonh95TrYEewnUdbIRKCiCdpwgWlu35sVQq22i
 8wxMTUxNg3+WiJ1amg6F68zn9qVnnjRbGgNwL6SjfVuuDWCpOBr65D2K8bccNGOQcRTn26bq
 3jA8mC/BQsVXPSFwDqY9jS3h+nAnQvyQodUH7q9ntZ6jVvWymENBRk+UVqgveL/mkO4Q8hYK
 UEf5mwpt6da3GuvQ9rmVhu0ukmtuBIGRsFQGO037gKK4qfM6gPfDW8BJhZDddgnuckeVTEsk
 FiTkLvBDzF1rKecT37b876OtC6zIgAcN2pEbigBJTbp+PG6/tt11EiWCI8+Tujl1bUZBA0c3
 RiE9jQ9oLoYh/U17Oah0HT8iRWGmLzGG1tdChrsYkqp6QZwZYiAboOu6ETG4fsoELt1XmVtr
 1BfxJDAtLFm4YWl0XXXGr1UTe7BC+OtaWWE2TZS848dGyNBEpJJVbtb5y1iPw9XO8IAdC6Bj
 KT76F4JusE70JdHa8ZKj2ON5yYCkfeI+TfNDKm8gj9yjn5ZLlLvEMZGPhf44owVuBJw+ZzTw
 L/CGSpWMV4UCL580B29TPoH3Lkgy0gWnD2IGMynkUn6gePGPhZ5rIvp1nPUM4jVC4vf+W3oH
 yt3bZPWm32zrsWnOkE7DrL/3XhVdCNmVPgaWuRcd/KZIxoOJY3SI6S5/F/VQKQ8x/49vr6Rp
 hmVAxYEoHKi1SyvAVjbMRhLNeKwNauTWFpmZETAy37zgCN9CWtuhY9CH6YKkU4Pr709nKEtF
 alVJ61twJ1nE1z6xtjUVrGkxKRKfxW3nwOeeS2jZTk0ZZl7QALVvNTje2PSGOMmV3bfWRIWr
 +Ly2wXFb4AEQgg+Xs/aZOj2lwG6vGQHmfI0VEzNe4EBdELp+YlsCirwkv5ofJ1cdUSdnmOXh
 1SMHBMVhejRuItpotPHsr+J8tWyGOxkE0sEQ2SCteSqNTPX93aIyJNbVLraZijUUW75of3wZ
 ehcw/zmHucAmVJG79h1H7pxlPps7Nrzvb5KiA9jGSyTPVisD7phJFiA3NVO6fIRluMI51PuV
 xvWqNdAOLiPNMf0K3IrJVIoPraZyPUZujjO9vBpck/00zB6oeicWkJIMhjS1CEEdOlpMJkoy
 PsKsdIN71DtkQIjN9uLg3wG92mIKXBcAawruotDXd3ugwsvjFpDfYbdGmn955TWM4dANUwjI
 zm1gqvehusDmhqeIiRrTXWdj/BAgZkuuQxRyA5QLluErdPJm/sr0UAD6j8wVAlUkk1K3u8b1
 rKH7KGpyXFiJwtVufU=
IronPort-HdrOrdr: A9a23:eTZup6rEz7Hapd5UtUJ9dwIaV5uxL9V00zEX/kB9WHVpm5Oj+P
 xGzc526farslsssREb+OxpOMG7MBThHLpOkPMs1NCZLXTbUQqTXfpfBO7ZrQEIdBeOlNK1uZ
 0QFpSWTeeAcWSS7vyKkTVQcexQueVvmZrA7Yy1rwYPPHFXguNbnn9E426gYzNLrWJ9dPwE/f
 Snl656T23KQwVpUi33PAhOY8Hz4/nw0L72ax8PABAqrCGIkDOT8bb/VzyVxA0XXT9jyaortT
 GtqX202oyT99WAjjPM3W7a6Jpb3PPn19t4HcSJzuwYMC/lhAqEbJloH5eCoDc2iuey70tCqq
 iAnz4Qe+BIr1/BdGC8phXgnyHmzTYV8nfnjWSVhHPyyPaJDQ4SOo5kv8Z0YxHZ400vsJVXy6
 RQxV+UsJJREFfpgDn9z8KgbWAqqmOE5V4Z1cIDhX1WVoUTLJVLq5YEwU9TGJAcWArn9YEcFv
 V0Bs203ocZTbqjVQGbgoBT+q3vYpxqdS32B3Tq+/blnAS+pUoJj3fxn6ck7zM9HJFUcegz2w
 2LCNUuqFh0dL5lUUtKPpZ3fSKGMB2/ffvyChPmHb3GLtBOB5ufke+93F0KjNvaDKDgiqFC3q
 j8bA==
X-IronPort-AV: E=Sophos;i="5.87,191,1631592000"; 
   d="scan'208";a="56613373"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=QSbSsJLdx1D0Jx/myq+ZWDurlRrugxnRjf0QOtGppBvDqVw1gEz0zuTtImAH3982HYaRpb8vH6I/04wHKYT4XZKcFb+lcR33m4fXsAP+UTjou8jquK/ZrW9HEoyl1Jsvqz2/QxpzSiw4VG86ZsZrQzHWUS41Y4qI/nvs21RMlB7ff0kRdrIAmYnzDlemYyXB4SdQF0lqolbfL7Q5MSIzZYGUDC09tllOhti3O1IFNbpulNZTQMzsyHfU75GSqrvUhN4e3qXt1tUGU2R1BVgIWFy2Lic5P36WKiFUucbkNICAIuI0exdZDggtHEdjc5RHqySZ9JWyzku78gEBCsXo2A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=7GAx4LKQKNaHQoging8yT8bl0sE3U6jYHaKB6MVRuNM=;
 b=NL5iurLplJDJXlEjuQp1BIUFkfV9bAiN9SI6AfejKEWSefJa9fS3U3J49WcWPIIjAS7kN50FZ9q0aNv8ktKsVGEOCbvkZ6pSBZ2nNh7lO0t6CMsuj+74C2VM1ob4Fej6YgoV9Ns8Bk00mW+99ZfHnp6HjzA5wiDAHJAkeyLp0kscyMLl5XohgXtga3mpa4Z/no/Lm2AEMqlbJ30iM3eNmwjAWYMFE7v434vlYWWNaIbjTqqhprC0IO//Ua581bvALnFzZ8y8MP7eJR1YMIBfAcWt3jPMcblucEzEwJVVYCCRDPJ9/B3wZRIztlPAnanZ0lrLr2ki0J3QBIcgvBk/1Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=7GAx4LKQKNaHQoging8yT8bl0sE3U6jYHaKB6MVRuNM=;
 b=eqxf9bim7mnvK7cFpUXtOjdWyFBqon4vQE5fz+bMDgEGcVrVfZfZG899IQSVhMxfv4E1IpYAwhvgKloOvFF0Gyy5hHPJRPRADQwxa+1Kz7MMuTGJQu0OJL23wlw4TJWSIMe5JOsNECw4+XppP5hL1hpcIzOamUyqSPmhPPqPgKk=
Date: Fri, 29 Oct 2021 09:33:53 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
CC: Julien Grall <julien@xen.org>, Bertrand Marquis
	<bertrand.marquis@arm.com>, "sstabellini@kernel.org"
	<sstabellini@kernel.org>, Rahul Singh <rahul.singh@arm.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH] xen/arm: fix SBDF calculation for vPCI MMIO handlers
Message-ID: <YXuj4frtHIRuSgOO@Air-de-Roger>
References: <20211027082533.1406015-1-andr2000@gmail.com>
 <cb7e9ef7-476e-93c3-d3c9-9a9ebc61003d@xen.org>
 <d63c6e0b-8aa3-9ba3-893c-5e464638a8db@epam.com>
 <YXqnS7iZUvokJby6@Air-de-Roger>
 <3206478e-f230-cd91-5de9-85ef6c251405@epam.com>
 <YXrJyLMiMxaNmFAs@Air-de-Roger>
 <5de6c2f1-ef5c-9d8c-4287-9b0e3ff08b34@epam.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <5de6c2f1-ef5c-9d8c-4287-9b0e3ff08b34@epam.com>
X-ClientProxiedBy: PR1P264CA0006.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:102:19e::11) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 1398bade-6131-4a92-c717-08d99aae7801
X-MS-TrafficTypeDiagnostic: DM5PR03MB3370:
X-Microsoft-Antispam-PRVS: <DM5PR03MB337058CACD804977CC63CF2B8F879@DM5PR03MB3370.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: cz6LqoD2JUHqCQDt2V+1KxpmhFPAJHs5397kgTIjz6MVqZYrbLwt27LU0ySqf0lsZq3gqeyQCxAGqWMXjMwlaiB1+Ao2M0tn8SE7bfFNZsn8KoDUsy23GK5CZUZhrGc0Tx+50pGBsEPnkC9/nCBT+zTKAXlhx649eBUkickqJbPgRTIx28mScCHOe11LHR7Wdeed0ZC8daGVD7l7za5vBKqLPJJGlCGi0lrADu5BooceOMnpYx2EC9+yjLgO6vMTaO0in3PqsH6YvZzPSl2NdFFzWc5QrTlquhsMWedNhFS9KvFzmenVnb6stq8jlDVhhlKxdnQo2ewD6vQnnaP0zYqZU39vcD73f4BZxX6vK6r6FvUcXeKGi48iNHxz+l6DUH/RZoEvaAhHswaw+AXaMKLIGtQ1NSXWq1CSmLREhrr7IzpTuXWdQqMmDDMKXd2gOFCCI9wiDNmThSAs5tS8M/AHfmo6xTc4+/0cvV2qd7do4TzEbjd24CPpFqdRCBqq6YgS033i5OS5PFQ7lu4ZqPdPVPRVrdcVxQiA9cAQKb7bRmmDkaI7wmfACEo3TShQXajP6HukYxlDXJqpH6oZwc9Z1ADX+1c8E5vgBEMimWTisoYS1wjw/cE7eHrdU/cuqJe8MZI6eXZe93JlDxWhgg==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(7916004)(366004)(8936002)(82960400001)(4326008)(38100700002)(8676002)(66556008)(6666004)(83380400001)(26005)(508600001)(6916009)(54906003)(186003)(6486002)(9686003)(66476007)(86362001)(5660300002)(53546011)(2906002)(956004)(85182001)(33716001)(316002)(66946007)(6496006);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NENXQXp1VHNOSkIyZmVLUkd6dysxN3dMRENTVlZuWm5sVVRlc1M1dnYwK3RK?=
 =?utf-8?B?S0w3aTArNHh3blRHR2JTWmdZQlVFQnZnemFrT05uZ1YwUWpTdFc5Sm9aTkZ4?=
 =?utf-8?B?a25NZnluNjIyTFZXYldmVUxVRHFLNkpoWnZrWlNTeHZMaDJOdlB2OFdoeG1Q?=
 =?utf-8?B?VEdnOFhRekZ2dnZKMml1dW1IMFNkWUJpalVKV1JPQ21hL3RRREUrejlsT0Fn?=
 =?utf-8?B?R2ttdXR3Q1JHTW5hU2ppbUt4TjBYeWJQODRJcnZCVXBCaFlOdDVmZlhqajBw?=
 =?utf-8?B?UmxnSTZvdUFTWWVLWVdKdjRQY3FrRDdwWHVjWnRoYzJJb3BsQkZVZTk0RmR1?=
 =?utf-8?B?OW4rT2NvZGl0NnVVWUVhbUdGUjBSQ3FnOHlSLzhwRDZZd0pnVkhXKzR4V0Js?=
 =?utf-8?B?amJrZHYyTlJ1azdybnBYZ3pSVit0M0dlaEdhY0lmKy9oRVd6WmdUVEY4YzVD?=
 =?utf-8?B?OXM2N3c2NERaVlBCQmhhWTVka0ZSZVRJazd3NDNRM2NPVkFXRGIyYS9XRUp4?=
 =?utf-8?B?YVRHalhqVGlLWVNUQWk0Sjd5aDM3UExuY3I4emtUWXI5ZWFRclIyVWJHVWdi?=
 =?utf-8?B?NWlVNXcvZFU3ODVLQ0pSNGxPRG5SSmtSNXJ2UWNlYXpObUloU2ZqSmFmWkMx?=
 =?utf-8?B?SHkwRS9HZHUwQW9ZR3lVNXBXclpheFpNZHl0Vy9hbzlOdXRaNzJFbjMxUEF0?=
 =?utf-8?B?M0FsMzlzMzhBMkVPaGlSZzUwZnhMMkRLTWFUUHNZeXhjbkxzRnpSYXdWTDdq?=
 =?utf-8?B?V1BhSStDVEJaSlRPNGRiMFBDd1ZEMDZ4M3FybldEcllPNmFMU1IrQ09tN3Aw?=
 =?utf-8?B?MDBCUTBMdkRZbEpGMzRDdzl4WjZNVzN2RXNTalhWS0N1bjhoTlJsVkxsTUxa?=
 =?utf-8?B?aEN4ZndRNmVaK0tWNi9EbExncm9uNHZIQkhLdnBXZzlBYzIrc0QzajZISStz?=
 =?utf-8?B?cUFkMEZEZ3Bkb3ZZcCtRTll0cnJ3ZUt3b1BnMW0vTmtzdGgySm5uSFZZcXBs?=
 =?utf-8?B?Z09Rb1BET0Vub2JKSEdxdWlvN3JNQm1sTUlyQUR2REx3MjJRdjYvTUltOXJn?=
 =?utf-8?B?UXJscHB0cW1ZaVRib0oxem4xV2sxNEFkZGNYNkM2Z0JSa1J6NFVGNnRkWWtD?=
 =?utf-8?B?cEFFUlBUWnE1ZjJaRFNNcGJvRmQycDJhdkFGMEI0eVJqbE1kVlRUMXlTQ2Y2?=
 =?utf-8?B?MUFEaDBNVC83OElOWjU3L3hScDJsY096RWNMU3FtSFduU0xqU21KUUlzcVc4?=
 =?utf-8?B?VHEzNDBLQ1ZaclYyS3ZEVldaMnhFSnFkZklyMCt2WmVJU2tjZGZuS0VXNC9i?=
 =?utf-8?B?cko1ZkRxSGRzTUZWQUFtSHFtUUhBeGlNNnl5ZEJpZjZsWU5QaWpvNGNvckZr?=
 =?utf-8?B?ZEx4OHJYc3N6cGYraW9naVBEZk1mOFRNdjZIZU44eXFKdVdYTjYvanV2eFVu?=
 =?utf-8?B?UWJobDluS3BIZXVHUGYxS3VoN05PMlBxMEpDYXRBdzN6TG9uRGU2VUtNU01J?=
 =?utf-8?B?SG5aZTVuVmdHclBBaWJjckRNS3BUT3JZMVZZbWhnOG9WTm1OdkV4d1hHU3VU?=
 =?utf-8?B?VDFxcFlwcWF3T1NqQTV3dHZORHZzRlA3S2FjQ3R5dldlWmNqL0MvZGoyaEVT?=
 =?utf-8?B?ZkhNSGRVSjVqckthMzRvellrQVJya20yVXhpMlY4bUlVOXo2dnZ3YVo1MzAz?=
 =?utf-8?B?WmY4b1NwU2phbno0TDJxbmg1cjllQ09nTTI4bzlhUC8wSE5sNGUvcG1hdlo3?=
 =?utf-8?B?YVBPSE9PSzYxMW1rcVpnNUFRVUNhM3pRUEFKRHhLVHRWQXFmUXNKSHBzelRH?=
 =?utf-8?B?a2doZGpzT3RjOHp4dEt4emphQU5pWWVZTlI1d3RpeVBTZmVQWkF1cFFrek5P?=
 =?utf-8?B?T29sVTNGSGxCZDhvNTlaTTEvamxnMk9rbGJ4YXpDbEs2anhlRTlSK0xOSkdx?=
 =?utf-8?B?elRod0sxUlFZWFdsVUEyOG51dmFWOE81ZndMWnUraUpobVorMEJuR2NvTDAz?=
 =?utf-8?B?SHd5L2hUN0hLcU9pb09NZmU2eittclF0Z2JmQldCQlRsTlhCa0NvTEZiTEJW?=
 =?utf-8?B?bXlld3RqM2ZLY0FPTXdWQk15S2NGblUrM1d2YzFqTXV6TW1ZV014SURtYWFC?=
 =?utf-8?B?MmN4YUdKOUFHeGVERXBFcU1pc2luUTFMK0MyanhhcCtyK1ZmdXN4NFlGZ1d3?=
 =?utf-8?Q?SSdq8DTgeuqNX1lbr+YRfis=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 1398bade-6131-4a92-c717-08d99aae7801
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Oct 2021 07:33:57.9080
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: xlaTpqt1TEi88Sjg2EWqkW25CubT/vUHusm4EhPlE284lbmzXe93j1MiLYGhTrmrq2eDJZIYXGSW/Fr0gbOrFw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB3370
X-OriginatorOrg: citrix.com

On Thu, Oct 28, 2021 at 05:55:25PM +0000, Oleksandr Andrushchenko wrote:
> 
> 
> On 28.10.21 19:03, Roger Pau Monné wrote:
> > On Thu, Oct 28, 2021 at 02:23:34PM +0000, Oleksandr Andrushchenko wrote:
> >>
> >> On 28.10.21 16:36, Roger Pau Monné wrote:
> >>> On Thu, Oct 28, 2021 at 12:09:23PM +0000, Oleksandr Andrushchenko wrote:
> >>>> Hi, Julien!
> >>>>
> >>>> On 27.10.21 20:35, Julien Grall wrote:
> >>>>> Hi Oleksandr,
> >>>>>
> >>>>> On 27/10/2021 09:25, Oleksandr Andrushchenko wrote:
> >>>>>> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> >>>>>>
> >>>>>> While in vPCI MMIO trap handlers for the guest PCI host bridge it is not
> >>>>>> enough for SBDF translation to simply call VPCI_ECAM_BDF(info->gpa) as
> >>>>>> the base address may not be aligned in the way that the translation
> >>>>>> always work. If not adjusted with respect to the base address it may not be
> >>>>>> able to properly convert SBDF and crashes:
> >>>>>>
> >>>>>> (XEN) vpci_mmio_read 0000:65:1a.0 reg 8bc gpa e65d08bc
> >>>>> I can't find a printk() that may output this message. Where does this comes from?
> >>>> That was a debug print. I shouldn't have used that in the patch description, but
> >>>> probably after "---" to better explain what's happening
> >>>>> Anyway, IIUC the guest physical address is 0xe65d08bc which, if I am not mistaken, doesn't belong to the range advertised for GUEST_VPCI_ECAM.
> >>>> This is from dom0 I am working on now.
> >>>>> IMHO, the stack trace should come from usptream Xen or need some information to explain how this was reproduced.
> >>>>>
> >>>>>> (XEN) Data Abort Trap. Syndrome=0x6
> >>>>>> (XEN) Walking Hypervisor VA 0x467a28bc on CPU0 via TTBR 0x00000000481d5000
> >>>>> I can understnad that if we don't substract GUEST_VPCI_ECAM, we would (in theory) not get the correct BDF. But... I don't understand how this would result to a data abort in the hypervisor.
> >>>>>
> >>>>> In fact, I think the vPCI code should be resilient enough to not crash if we pass the wrong BDF.
> >>>> Well, there is no (?) easy way to validate SBDF. And this could be a problem if we have a misbehaving
> >>>> guest which may force Xen to access the memory beyond that of PCI host bridge
> >>> How could that be? The ECAM region exposed to the guest you should be
> >>> the same as the physical one for dom0?
> >> Ok, I have a Designware PCI hist which has 2 ECAM regions (I am starting to
> >> implement the driver for it, so I can be wrong here):
> >> - Root Complex ECAM area ("dbi"), it is something like 0x3000 bytes long
> >> - "Client" ECAM area ("config")
> >> So from Dom0 POV we have 2 ECAM regions and for the guest
> >> we always emulate a single big region:
> > You need support for multiple ECAM regions. That's how we do it on x86
> > PVH dom0. See register_vpci_mmcfg_handler and related machinery.
> Is it common for a PCI host bridge to have multiple ECAM regions?
> Currently on Arm we were about to support "pci-host-ecam-generic" [1],
> e.g. generic ECAM host bridge which normally (?) has a single ECAM
> region [2]. But the host bridge I want to support has multiple, so
> strictly speaking it is not the one that we implement.

It's possible on x86 to have multiple ECAM regions, whether that means
multiple host bridges, or host bridges having multiple ECAM regions is
unknown to me. It's all reported in the MCFG ACPI table (see PCI
Firmware document for the detailed description of MCFG) using the
"Configuration Space Base Address Allocation Structure", and there can
be multiple of those structures.

> Arm folks, do we want this generalization at this moment to align with x86
> with this respect?
> 
> We can live with the current approach and when I have my driver implemented
> I can send patches to make that generalization.
> >
> >> /*
> >>    * 256 MB is reserved for VPCI configuration space based on calculation
> >>    * 256 buses x 32 devices x 8 functions x 4 KB = 256 MB
> >>    */
> >> #define GUEST_VPCI_ECAM_BASE    xen_mk_ullong(0x10000000)
> >> #define GUEST_VPCI_ECAM_SIZE    xen_mk_ullong(0x10000000)
> >>
> >> So, we have the base address and size of the emulated ECAM space
> >> not connected to the real host bridge
> >>> And for domUs you really need to fix vpci_{read,write} to not
> >>> passthrough accesses not explicitly handled.
> >> Do you mean that we need to validate SBDFs there?
> >> This can be tricky if we have a use-case when a PCI device being
> >> passed through if not put at 0000:00:0.0, but requested to be, for
> >> example, 0000:0d:0.0. So, we need to go over the list of virtual
> >> devices and see if SBDF the guest is trying to access is a valid SBDF.
> >> Is this what you mean?
> > No, you need to prevent accesses to registers not explicitly handled
> > by vpci. Ie: do not forward unhandled accesses to
> > vpci_{read,wrie}_hw).
> I see, so those which have no handlers are not passed to the hardware.
> I need to see how to do that

Indeed. Without fixing that passthrough to domUs is completely unsafe,
as you allow domUs full access to registers not explicitly handled by
current vPCI code.

Regards, Roger.


From xen-devel-bounces@lists.xenproject.org Fri Oct 29 07:50:01 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Oct 2021 07:50:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.218417.378838 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgMe1-0002IL-Dz; Fri, 29 Oct 2021 07:49:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 218417.378838; Fri, 29 Oct 2021 07:49:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgMe1-0002IE-Av; Fri, 29 Oct 2021 07:49:45 +0000
Received: by outflank-mailman (input) for mailman id 218417;
 Fri, 29 Oct 2021 07:49:44 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=3izX=PR=suse.com=jgross@srs-us1.protection.inumbo.net>)
 id 1mgMdz-0002I8-U5
 for xen-devel@lists.xenproject.org; Fri, 29 Oct 2021 07:49:43 +0000
Received: from smtp-out1.suse.de (unknown [195.135.220.28])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 4c048f91-eead-4040-80f2-0b5ef99f4a1f;
 Fri, 29 Oct 2021 07:49:43 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 13B7921971;
 Fri, 29 Oct 2021 07:49:42 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id C937C13B27;
 Fri, 29 Oct 2021 07:49:41 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id HHUYL5Wne2GPfwAAMHmgww
 (envelope-from <jgross@suse.com>); Fri, 29 Oct 2021 07:49:41 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4c048f91-eead-4040-80f2-0b5ef99f4a1f
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1635493782; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding;
	bh=cEHSevouYw8lnbcB9mvJJwAH561ddSGhR9uQkll/Ybg=;
	b=ZmMFSg7HmY3N5x7iTSAMm4Y3XP4uycpYHsJ/QcagIeHfvd81YwIObys7En+h15ENPVGFm3
	oWCRhBglR/uMGpRzFe2Q/ZGTb/lHyzzufZBszoMQL5le4q4uYWgxPtsthnpAvypCTgPqgJ
	elxeVELo3y5KwimhI58Sg0m/AxIZTaM=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org,
	linux-kernel@vger.kernel.org
Cc: Juergen Gross <jgross@suse.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	stable@vger.kernel.org,
	=?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
Subject: [PATCH v2] xen/balloon: add late_initcall_sync() for initial ballooning done
Date: Fri, 29 Oct 2021 09:49:31 +0200
Message-Id: <20211029074931.20657-1-jgross@suse.com>
X-Mailer: git-send-email 2.26.2
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

When running as PVH or HVM guest with actual memory < max memory the
hypervisor is using "populate on demand" in order to allow the guest
to balloon down from its maximum memory size. For this to work
correctly the guest must not touch more memory pages than its target
memory size as otherwise the PoD cache will be exhausted and the guest
is crashed as a result of that.

In extreme cases ballooning down might not be finished today before
the init process is started, which can consume lots of memory.

In order to avoid random boot crashes in such cases, add a late init
call to wait for ballooning down having finished for PVH/HVM guests.

Warn on console if ballooning stalls for more than 1 minute, panic()
after stalling for more than 3 minutes.

Cc: <stable@vger.kernel.org>
Reported-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
Signed-off-by: Juergen Gross <jgross@suse.com>
---
V2:
- add warning and panic() when stalling (Marek Marczykowski-Górecki)
- don't wait if credit > 0
---
 drivers/xen/balloon.c | 35 +++++++++++++++++++++++++++++++++++
 1 file changed, 35 insertions(+)

diff --git a/drivers/xen/balloon.c b/drivers/xen/balloon.c
index 3a50f097ed3e..c0c1c754e515 100644
--- a/drivers/xen/balloon.c
+++ b/drivers/xen/balloon.c
@@ -765,3 +765,38 @@ static int __init balloon_init(void)
 	return 0;
 }
 subsys_initcall(balloon_init);
+
+static int __init balloon_wait_finish(void)
+{
+	long credit, last_credit = 0;
+	unsigned long last_changed;
+
+	if (!xen_domain())
+		return -ENODEV;
+
+	/* PV guests don't need to wait. */
+	if (xen_pv_domain() || !current_credit())
+		return 0;
+
+	pr_info("Waiting for initial ballooning down having finished.\n");
+
+	while ((credit = current_credit()) < 0) {
+		if (credit != last_credit) {
+			last_changed = jiffies;
+			last_credit = credit;
+		}
+		if (jiffies - last_changed >= HZ * 60) {
+			pr_warn_once("Initial ballooning stalling for 60s, %ld pages need to be freed.\n",
+				     -credit);
+		}
+		if (jiffies - last_changed >= 3 * HZ * 60)
+			panic("Initial ballooning failed!\n");
+
+		schedule_timeout_interruptible(HZ / 10);
+	}
+
+	pr_info("Initial ballooning down finished.\n");
+
+	return 0;
+}
+late_initcall_sync(balloon_wait_finish);
-- 
2.26.2



From xen-devel-bounces@lists.xenproject.org Fri Oct 29 07:52:04 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Oct 2021 07:52:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.218424.378849 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgMg8-0003eD-RQ; Fri, 29 Oct 2021 07:51:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 218424.378849; Fri, 29 Oct 2021 07:51:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgMg8-0003e6-O7; Fri, 29 Oct 2021 07:51:56 +0000
Received: by outflank-mailman (input) for mailman id 218424;
 Fri, 29 Oct 2021 07:51:55 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ZHrx=PR=arm.com=Bertrand.Marquis@srs-us1.protection.inumbo.net>)
 id 1mgMg6-0003dv-SG
 for xen-devel@lists.xenproject.org; Fri, 29 Oct 2021 07:51:55 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com (unknown
 [40.107.6.87]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id aa106ed8-f393-43de-89d9-2e42496420b3;
 Fri, 29 Oct 2021 07:51:52 +0000 (UTC)
Received: from AM5P194CA0016.EURP194.PROD.OUTLOOK.COM (2603:10a6:203:8f::26)
 by VI1PR0802MB2365.eurprd08.prod.outlook.com (2603:10a6:800:9f::16) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.14; Fri, 29 Oct
 2021 07:51:50 +0000
Received: from AM5EUR03FT050.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:203:8f:cafe::29) by AM5P194CA0016.outlook.office365.com
 (2603:10a6:203:8f::26) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.14 via Frontend
 Transport; Fri, 29 Oct 2021 07:51:50 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM5EUR03FT050.mail.protection.outlook.com (10.152.17.47) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4649.14 via Frontend Transport; Fri, 29 Oct 2021 07:51:49 +0000
Received: ("Tessian outbound 4ce13939bd4a:v108");
 Fri, 29 Oct 2021 07:51:49 +0000
Received: from e03c7cb1c5a0.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 B80FD207-E6BE-44F5-8E9A-F86949033244.1; 
 Fri, 29 Oct 2021 07:51:42 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id e03c7cb1c5a0.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 29 Oct 2021 07:51:42 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25)
 by AM6PR08MB4674.eurprd08.prod.outlook.com (2603:10a6:20b:c7::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.15; Fri, 29 Oct
 2021 07:51:40 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::69d7:e26:6610:ebd8]) by AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::69d7:e26:6610:ebd8%4]) with mapi id 15.20.4649.015; Fri, 29 Oct 2021
 07:51:40 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: aa106ed8-f393-43de-89d9-2e42496420b3
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=lMoLwd/Uw5OFVjuUUsn5qr/Fc3hsQlU/rFYH58TLTTo=;
 b=OLQEhOwQiyWfa+Mf8gg/9HEIfis//nAtQzcnuQgP43drHMPORFUn5CLBKOG0Hh0Ia/ajLhfLeTxIfUqCh+oPHIL0GPO2yjvSESD+KNv/loz3+9DNAMbyY3jxg+88mkynYSKOFVyAKePCiJaGAGI3kIKlX4dVlWOZkvJYlcyfNOs=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 6880f59315649ec3
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=khj19kLCe1rTM18C/4LNvYBWaf95rnpMyohfP5CfKSMkmCQiv8qnTRZslAtyKvYqQgdOrMJvCNVrPSgG3rKfEOpDo5zCCaxjGVQuSq/+eYpgFlHiCx8GsvBnjdqfyGSVMgyGscsVUFxuSYxZ3lT0sBSLBGCvJHPlGeHgYsHA9CiQZ5y/UceKiSDSYVgfy4oaepilUhpM2jdWDt7Qcb7D3q8LqdfJzBUgq1iR6Mp7qx5V+oW9pADFqukAbm47h2LDPJQ0t2i+HeC7+68wblm4qA5mPZiqUwi5mkLbFIuPakXzgCqsqG3WC0/nmA2dt2Ct1jaCYg7pPl3J0/EG9c4ECw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=lMoLwd/Uw5OFVjuUUsn5qr/Fc3hsQlU/rFYH58TLTTo=;
 b=hyird8WxVsWnDiHpIqc/Zle9uEZvi4/PH62dEMZeEK+gT9gJ7Le7sI9wFsHE57LHfSiG3mU2F4KIapdpg7TXMAXjjAl1I6XtpK8XS3czSCP6GV+PU4+knGRgVkem9kUWn9RG41izufirYrXj5HGRv32N9//wEIgQWpMIpdLNWqlGxI5mbrLJ2Vmq1HMqou0Dk4mlzxwn2AJXPoqkM5r4DxJwr5bvmQfyxqyzH3S0Fuusfa8AlQiHDs29epW8KeepUDKjvDiLmz/nnqCN0erTgw5+JjXL5I+7lTNonpzi9IB1GcnS00Y3gL1sm7KMRgxLD4uhdbUVIp4KbFH9cg1BkQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=lMoLwd/Uw5OFVjuUUsn5qr/Fc3hsQlU/rFYH58TLTTo=;
 b=OLQEhOwQiyWfa+Mf8gg/9HEIfis//nAtQzcnuQgP43drHMPORFUn5CLBKOG0Hh0Ia/ajLhfLeTxIfUqCh+oPHIL0GPO2yjvSESD+KNv/loz3+9DNAMbyY3jxg+88mkynYSKOFVyAKePCiJaGAGI3kIKlX4dVlWOZkvJYlcyfNOs=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Stefano Stabellini <sstabellini@kernel.org>
CC: Julien Grall <julien@xen.org>, Julien Grall <julien.grall.oss@gmail.com>,
	Michal Orzel <Michal.Orzel@arm.com>, xen-devel
	<xen-devel@lists.xenproject.org>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Ian Jackson <iwj@xenproject.org>
Subject: Re: [patch-4.16] arm/smmuv1,v2: Protect smmu master list with a lock
Thread-Topic: [patch-4.16] arm/smmuv1,v2: Protect smmu master list with a lock
Thread-Index:
 AQHXymUg+0MR4ITOT0Gs5iPzJutqzKvleE2AgAAH0ICAASmBgIAAanYAgABn5gCAAAgVgIAACmyAgACjWoCAAK7mAIAAvhaA
Date: Fri, 29 Oct 2021 07:51:40 +0000
Message-ID: <992FE375-4754-4268-8D27-C27C32FDD4F4@arm.com>
References: <20211026122903.15042-1-michal.orzel@arm.com>
 <e5632a4e-db98-41b4-1045-2b3532c098fa@xen.org>
 <70c30a6c-b779-805e-079a-41bb484894b9@xen.org>
 <cb452c0c-ccde-7798-c403-f972b48a2c46@arm.com>
 <01545115-e82e-2a9d-a8e4-da9676080c0f@xen.org>
 <alpine.DEB.2.21.2110271557570.20134@sstabellini-ThinkPad-T480s>
 <CAJ=z9a2SSgG7a87_xTGT5LeNLgubOLQf1+dbnrsTsP8_p5ErJg@mail.gmail.com>
 <alpine.DEB.2.21.2110271658330.20134@sstabellini-ThinkPad-T480s>
 <4554621d-63da-ea3e-e56a-4e01d0cef347@xen.org>
 <alpine.DEB.2.21.2110281311030.20134@sstabellini-ThinkPad-T480s>
In-Reply-To: <alpine.DEB.2.21.2110281311030.20134@sstabellini-ThinkPad-T480s>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3654.120.0.1.13)
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: 7e9243c8-b848-4826-efd1-08d99ab0f6e6
x-ms-traffictypediagnostic: AM6PR08MB4674:|VI1PR0802MB2365:
X-Microsoft-Antispam-PRVS:
	<VI1PR0802MB2365D0C187FBF7E5A5FB9CCC9D879@VI1PR0802MB2365.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:10000;OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 5L/GarYcnaJqgu0OgS5RqblHM8Kaf+XWtjRKeIs9SZ0co89YZDR6l7vgsnxBx8CsKdNb7h5kA2vcCRVnrm8nqDnolY7cKrA1W0MWIQUzAHGtIWDhXqjTPhx+3yDnrhQFbgDDNbI1Ob32hWzFvl//VgUzV9kFxiuPBpF2f8HGfOb2b5pwlkxXYEwIYU1L2lqSAl/9h8hS/yN1FsXEVrH6nqA75whgPzcJO6hY4r2JOWYXr+RunZ3T5UUr+7f4PWGE7RjTNawoUpKcqpu8j9LhcN+7DhsWAu/Eykeoq5D+BIkWctp/+gC+f+PltqeTZ+TxdcfCNP32Zf8Og5g1H99xfIz2nFGB96gtb97TTw8+sCBaStZTMrClk7gdteQVieVF+S188LSJwWxZhFkZqSc5DPOfLNwsgXpNEWngMrYHDx1pGF3FzWCHONSxHMevx+Llb/PKntIKx1LHiwRI8QZjPnbofA34/SI4FhnmAUF08sxLAcAIUGwNZma/4iU8g4y5b1zWBL+9sMFV0vh+iloOif59fJ5SKR2ubOzBCDKWyKdBfPHdtJk66/Y22mf+GqrDXSlFTpiMYCZ3MBQhAWk4UrJLTcrMfyN+CmqmwnqjUeTzXTYBTtPCnvqwz3qXaa9oVAArcmlmGaFYADWPq31dzen3An4Wy9KrRky/EqbLTa1BoiF2vqxkVJMSwnPSB2MdVgMnlWrId8v9XGp9f1YFvpyTr8n77A6j8oit1sjw2kXzo60Qn9y4kRxcrV0OtgnJ
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(76116006)(66946007)(64756008)(66476007)(66446008)(66556008)(86362001)(8676002)(91956017)(2906002)(26005)(186003)(38070700005)(8936002)(36756003)(122000001)(83380400001)(38100700002)(71200400001)(6916009)(33656002)(53546011)(5660300002)(6506007)(4326008)(316002)(2616005)(6512007)(54906003)(6486002)(508600001)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="us-ascii"
Content-ID: <8CB87B2915D6A143BF1393DA919DE68C@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB4674
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM5EUR03FT050.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	edaffebd-76bb-4d8a-7645-08d99ab0f172
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	HsuTxIaZ4WSmLQ6fThC4GIMFpXOnhFK9ztCv+Ht9GvZrYR/YeZ19cuFc+1B8mNewQKZOFmo9DoKrxoSYbrRQGMEi8GK5Zaaasbdnj8oUqujgei8D+JGmOiUcI5EhNjM6dFlg+9neCS3a9BmJyxO/d5B8031a1gUQhAhv5iPVfdQ3Tme8aaUGZ3md16NW832XK0cTY3tVI9DuS4MOPJbZDzBjSSmc/MHn2Txi8TRNDWv1Z4q5CxpbUMNRQh05NFbRCwrx84SbOeCm96ebr/cfP+kN2j8b3P+obQQZlXBgyd1/OCRBvOo6nW7mi6JVlzNdgp4uTnWOXLSDl8mNNOGKUSt/5ZAu5IZCpD9/r4He6jFHh86dqPljaVDrFLH7DZGuEdfwxNCfTSQzjVnuIdaYju5scyy88t3IBlDdAmw8gksDY/zybbEEhJ/Rj5wVPVkzuCiyhXnIHywZ6Xpo4RsEJiGPTUBjU1LsC11ZJ7Kb8l2VmK1x3cgMughm4vMqvJ5iv4eiJ9uhL7VI9+A6QoaMdSUmlhcVTEzgC3qUpIXLtDVLXynfl4sDBZ5h/JDLnTg40wmcZPuHmEbha1GtvwtBK94x5MJMWcRY/NLvkWWOEqkJHcmEdvhFx3WQuxURagQtJWvqgF8BlCGb6g2VkNDLR8dDI08U0CQJt7zx51qHW5Cm9BNTenpcBy1dbQyX0N/j5o/o5cXjiAlkt4mdhtkqbw==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(8676002)(70586007)(54906003)(6512007)(336012)(82310400003)(86362001)(2616005)(36756003)(8936002)(81166007)(508600001)(186003)(70206006)(53546011)(5660300002)(83380400001)(2906002)(33656002)(4326008)(316002)(36860700001)(47076005)(6862004)(6506007)(26005)(356005)(6486002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Oct 2021 07:51:49.6177
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 7e9243c8-b848-4826-efd1-08d99ab0f6e6
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM5EUR03FT050.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0802MB2365

Hi,

> On 28 Oct 2021, at 21:31, Stefano Stabellini <sstabellini@kernel.org> wro=
te:
>=20
> On Thu, 28 Oct 2021, Julien Grall wrote:
>> Hi Stefano,
>>=20
>> First apologies for sending the previous e-mails in HTML (thanks for poi=
nting
>> that out!).
>>=20
>> On 28/10/2021 01:20, Stefano Stabellini wrote:
>>> On Thu, 28 Oct 2021, Julien Grall wrote:
>>>> On Thu, 28 Oct 2021, 00:14 Stefano Stabellini, <sstabellini@kernel.org=
>
>>>> wrote:
>>>>       On Wed, 27 Oct 2021, Julien Grall wrote:
>>>>>>>>> +    return ret;
>>>>>>>>>     }
>>>>>>>>>     static int register_smmu_master(struct arm_smmu_device
>>>> *smmu,
>>>>>>>>> @@ -2056,7 +2066,10 @@ static int
>>>> arm_smmu_add_device(struct device
>>>>>>>>> *dev)
>>>>>>>>>         } else {
>>>>>>>>>             struct arm_smmu_master *master;
>>>>>>>>> +        spin_lock(&arm_smmu_devices_lock);
>>>>>>>>>             master =3D find_smmu_master(smmu, dev->of_node);
>>>>>>>>> +        spin_unlock(&arm_smmu_devices_lock);
>>>>>>>>=20
>>>>>>>> At the moment, unlocking here is fine because we don't
>>>> remove the
>>>>>>>> device. However, there are a series to supporting removing
>>>> a device (see
>>>>>>>> [1]). So I think it would be preferable to unlock after the
>>>> last use of
>>>>>>>> 'cfg'.
>>>>>>>>=20
>>>>>> Ok. I will move unlocking to the end of this else {} block. I
>>>> was not aware
>>>>>> of the patch you are referring to.
>>>>>=20
>>>>> I think the end of the else is still too early. This needs to at
>>>> least be past
>>>>> iommu_group_set_iommudata() because we store cfg.
>>>>>=20
>>>>> Potentially, the lock wants to also englobe
>>>> arm_smmu_master_alloc_smes(). So I
>>>>> am wondering whether it would be simpler to hold the lock for the
>>>> whole
>>>>> duration of arm_smmu_add_device() (I can see value when we will
>>>> want to
>>>>> interlock with the remove code).
>>>>=20
>>>>       The patch was to protect the smmu master list. From that point o=
f
>>>> view
>>>>       the unlock right after find_smmu_master would be sufficient, rig=
ht?
>>>>=20
>>>>=20
>>>> Yes. However this is not fixing all the problems (see below).
>>>>=20
>>>>=20
>>>>       We only need to protect cfg if we are worried that the same devi=
ce
>>>> is
>>>>       added in two different ways at the same time. Did I get it right=
?
>>>> If so,
>>>>       I would say that that case should not be possible? Am I missing
>>>> another
>>>>       potential conflict?
>>>>=20
>>>>=20
>>>> It should not be possible to add the same device twice. The problem is
>>>> more when we are going to remove the device. In this case, "master"
>>>> may disappear at any point.
>>>>=20
>>>> The support for removing device is not yet implemented in the tree. Bu=
t
>>>> there is already a patch on the ML. So I think it would be
>>>> shortsighted to only move the lock to just solve concurrent access to =
the
>>>> list.
>>>  That makes sense now: the other source of conflict is concurrent add a=
nd
>>> remove of the same device. Sorry it wasn't clear to me before.
>> At the moment, we are relying on the upper layer (e.g. PCI or DT subsyst=
em) to
>> prevent concurrent add/remove/assignment. The trouble is we don't have a
>> common lock between PCI and DT.
>>=20
>> One possibility would be to add a common in the uper layer, but it feels=
 to me
>> this is a bit fragile and may also require longer locking section than
>> necessary.
>>=20
>> That said, add/remove/assignment operations are meant to be rare. So thi=
s is
>> could be an option. This would also have the advantage to cover all the
>> IOMMUs.
>>=20
>>>=20
>>>>       I am pointing this out for two reasons:
>>>>=20
>>>>       Protecting the list is different from protecting each element fr=
om
>>>>       concurrent modification of the element itself. If the latter is =
a
>>>>       potential problem, I wonder if arm_smmu_add_device is the only
>>>> function
>>>>       affected?
>>>>=20
>>>>=20
>>>> I had a brief looked at the code and couldn't find any other places wh=
ere
>>>> this may be an issue.
>>>>=20
>>>>=20
>>>>       The second reason is that extending the lock past
>>>>       arm_smmu_master_alloc_smes is a bit worrying because it causes
>>>>       &arm_smmu_devices_lock and smmu->stream_map_lock to nest, which
>>>> wasn't
>>>>       the case before.
>>>>=20
>>>>=20
>>>> Nested locks are common. I don't believe there would be a problem here
>>>> with this one.
>>>>=20
>>>>=20
>>>>       I am not saying that it is a bad idea to extend the lock past
>>>>       arm_smmu_master_alloc_smes -- it might be the right thing to do.
>>>>=20
>>>>=20
>>>> I don't usually suggest locking changes blindly ;).
>>>>=20
>>>>       But I
>>>>=20
>>>>       am merely saying that it might be best to think twice about it.
>>>>=20
>>>>       and/or do
>>>>       that after 4.16.
>>>>=20
>>>>=20
>>=20
>> [...]
>>=20
>>> The other thing that is not clear to me is whether we would need also t=
o
>>> protect places where we use (not allocate) masters and/or cfg, e.g.
>>> arm_smmu_attach_dev, arm_smmu_domain_add_master.
>>=20
>> I think both should be with the lock. Now the question is will other IOM=
MUs
>> driver requires the same locking?
>>=20
>> If yes, then maybe that locking should be in the common code.
>>=20
>>>> That said we can work towards a new locking approach for 4.17.
>>>> However, I would want to have a proposal from your side or at least
>>>> some details on why the suggested locking is not suitable.
>>>  The suggested locking approach up until the last suggestion looks
>>> totally fine to me. The last suggestion is a bit harder to tell because
>>> the PCI removal hook is not there yet, so I am having troubles seeing
>>> exactly what needs to be protected.
>>=20
>> The PCI removal hook is the same as the platform device one. There are a=
lready
>> a patch on the ML (see [1]) for that.
>>=20
>> We have two interlocking problem to resolve:
>>  1) Concurrent request between PCI and platform/DT subsystem
>>  2) Removal vs add vs (re)assign
>>=20
>> The two approaches I can think of are:
>>=20
>> Approach A:
>>  - The driver is responsible to protect against 1)
>>  - Each subsystem (DT and PCI) are responsible for 2)
>>=20
>> Approach B:
>>  The driver is responsible to protect for 1) 2).
>>=20
>> From my understanding, the proposed patch for Michal is following approa=
ch A
>> whilst my proposal is going towards approach B.
>>=20
>> I am open to use approach A, however I think this needs to be documented=
 as
>> the lock to use will depend on whether the device is a PCI device or not=
.
>=20
> Thanks for the explanation, now everything is a lot clearer. I don't
> have feedback on approach A vs. B -- it looks like both could work well.
>=20
> In regards to this specific patch and also the conversation about 4.16
> or 4.17: I think it would be fine to take this patch in 4.16 in its
> current form. Although it is not required because PCI passthrough is
> not going to be complete in 4.16 anyway, I like that this patch makes
> the code consistent in terms of protection of rbtree accesses.  With
> this patch the arm_smmu_master rbtree is consistently protected from
> concurrent accesses. Without this patch, it is sometimes protected and
> sometimes not, which is not great.
>=20
> So I think that is something that could be good to have in 4.16. But
> like you said, the patch is not strictly required so it is fine either
> way.

I think that this patch should be added in 4.16 as it addressing an issue (=
even
if it could not be triggered) as it will serve also as a reminder when the =
rest of
the PCI serie will be added.

So I would say: merge with changes in commit message (needs a v2).

>=20
> Other changes on top of it, e.g. a complete implementation of Approach A
> or Approach B, I think it would be best to target 4.17 so that we can
> evaluate them together with the other outstanding PCI patches. I think
> it would make the review a lot easier (at least for me.)

For the rest, having the full picture with the rest of the PCI patches will=
 help as
most of this code will be modified by it anyway.

Cheers
Bertrand



From xen-devel-bounces@lists.xenproject.org Fri Oct 29 08:00:26 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Oct 2021 08:00:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.218434.378860 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgMoB-0005h9-Ts; Fri, 29 Oct 2021 08:00:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 218434.378860; Fri, 29 Oct 2021 08:00:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgMoB-0005h1-OV; Fri, 29 Oct 2021 08:00:15 +0000
Received: by outflank-mailman (input) for mailman id 218434;
 Fri, 29 Oct 2021 08:00:14 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=slsI=PR=citrix.com=roger.pau@srs-us1.protection.inumbo.net>)
 id 1mgMoA-0005gt-1t
 for xen-devel@lists.xenproject.org; Fri, 29 Oct 2021 08:00:14 +0000
Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 812badc1-e1a6-4478-b2c8-fc401658dba5;
 Fri, 29 Oct 2021 08:00:11 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 812badc1-e1a6-4478-b2c8-fc401658dba5
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1635494410;
  h=from:to:cc:subject:date:message-id:
   content-transfer-encoding:mime-version;
  bh=zWWkMnk0VLcuj6u8zNi1/XhSa7Uo8z3a8pLCxVqD5xQ=;
  b=hhJX8RDtXZdOv0zeCjpJ7lDcIvanGSqYku3HSIEd6CRpnFv8QMZ4fO76
   9xUxCYenJlVqFed4ehXpHOl+WuvG9VwQLi/RJpaTShMpo5XlB5B2ctzB/
   6gf/nJa3HxAdAZYZ5icQbVpjwt/T2oznMhSxrSYs8ZTTepcJC+3c/aRUw
   Y=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: T/8uB8y6BHipisv0wYtGeYuKfIHz/Co2nNp1tW8SEMZt++oByQ7OmGZBPtFDP23EaOqqGymL7m
 odcS80RJRHLnhInxT8wNY1D+S4NnH5SQa2kXYxJLFHs66bNtiHN6L9ODMmESmwWoGxl8J+8vjm
 P4kNADzBcpPR30AnH2nP1IDeGmHoToqDkohj/MkN+fXBkX0OejdIe8c24Qk1OgK49f78uwe07M
 JXdKqXc7whOdXdIKb6Cbyklf6SzqMLiZTMT+/s4YUp9NosekdIQUCMOqoTj/nVEPxPAkwl6MdB
 j63S/CVtjgvTBXyVyXEMmydY
X-SBRS: 5.1
X-MesageID: 56652709
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:fqblAq7s4I/tw6nmDa4wGgxRtGTBchMFZxGqfqrLsTDasY5as4F+v
 msXCmqHa/mNMGekL9x0bdyw9RgDucXXz99hGQBlriA8Hi5G8cbLO4+Ufxz6V8+wwmwvb67FA
 +E2MISowBUcFyeEzvuV3zyIQUBUjclkfJKlYAL/En03FVAMpBsJ00o5wrdh2N4w2rBVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Zz
 4Vg5b6UZSwQN4r+ov40chZyN3BvFPgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALNs7kMZlZonh95TrYEewnUdbIRKCiCdpwgWlu25oRRae2i
 8wxNBhmXBfqWDtzNg0oL64Ojfz2gF2mfGgNwL6SjfVuuDWCpOBr65DhOcTYUsaHTsJUmgCfv
 G2u12b2GBYBL/SE1CGItHmrg4fnnDz5cJIfEqWi8fxni0HVwXYcYDUoUl+8rei8m1SJcdtVI
 EwJ+QIjtaE3skesS7HVRAakqXSJuhodXdt4EOAg7gyJjK3O7G6xGWwsXjNHLts8u6ceVTEsk
 1OEgd7tLThuq6GOD2KQ8K+OqjG/MjRTKnUNDQcGUA8E7t/LsIw1yBXVQb5LEqS4k9n0EjHY2
 C2RoW41gLB7sCIQ//zlpxad2Wvq/8WXCF5ujunKYo67xgQpSd6HQ6CD0FH838xaBaeWZH3Qr
 VFRzqBy89syJZ2KkSWMRsAEE7eo++uJPVXgvLJ/I3Uy32/yoyD7LOi89Bk7fR0zap9VJlcFd
 WeK4VsJjKK/KkdGekOej2iZMM8t0bT7XersUvTZf7KiibAgKVfZokmCiaOWtl0BcXTAc4ljZ
 v93ku72VB727JiLKhLsGo/xNpdwn0gDKZv7H8yT8vhe+eP2iISpYbkEKkCSSesy8bmJpg7Ym
 /4GaZDXl0kBDbCuO3GNmWL2EbzsBSJmbXwRg5cOHtNv3yI8QD1xYxMv6ep5E2Cao0ilvriRp
 SzsMqOp4FH+mWfGOW23hoNLM9vSsWJEhStjZ0QEZA/ws1B6ONrHxPpPJvMfIOh8nMQ+nKEcc
 hXwU5jZahi5Ym+coGp1gFiUhNEKSSlHcirVbnT0P2FlL848L+ELk/e9FjbSGOA1JnPfneM1o
 qG61xOdRpwGRg94C93RZu7pxFS01UXxUsooN6cRCtUMKkjq7qZwLCn90q0+L80WcE2RzTqGz
 QeGRxwfoLCV8YMy9dDIg4GCrpuoTLQiThYLQTGD4ObkLzTe80qi3ZREDLSCcwfCWT6m466lf
 +hUka3xaaVVgFZQvoNgOL931qZitcD3rrpXw108TnXGZlimEJ16JXyC0ZUdv6FB3OYB6wC3R
 liO6p9RPrDQYJHpF1sYJQwEaOWf1K5LxmmOvKpteEijvX155ruKV0lWLiKgsi0FIesnKp4hz
 McgpNUSt161hC01P4vUlStT7WmNcCANCv11qpEADYb3oQM30VUeM4fEAyr77ZzTOdVBNk4mf
 m2diKbY3ukOw0PDdzw4FGTX3PobjpML4UgYwFgHLlWPu9zEmv5og0EBrWVpFlxYnkddzuZ+G
 ml3LEkkd6yB8gBhiNVHQ23xSRpKAweU+xCpxlYE/IEDo5JEioAZwLUBBNuw
IronPort-HdrOrdr: A9a23:SKU8hag+lgoDdMeKYBQGw7jZL3BQXiAji2hC6mlwRA09TyX5ra
 2TdTogtSMc6QxhPE3I/OrrBEDuexzhHPJOj7X5Xo3SOTUO2lHYT72KhLGKq1Hd8kXFndK1vp
 0QEZSWZueQMbB75/yKnTVREbwbsaW6GHbDv5ag859vJzsaFZ2J921Ce2Gm+tUdfng8OXI+fq
 DsgPZvln6bVlk8SN+0PXUBV/irnaywqHq3CSR2fiLO8WO1/EuV1II=
X-IronPort-AV: E=Sophos;i="5.87,191,1631592000"; 
   d="scan'208";a="56652709"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=XFjsVNf871TFpU53+r10y+YAK2rM3srXfA9daPk88ZGVxa6WDLq9y+t/KZtAbtf59JPSjyfl48OtTU92KzGSZERjY9sVGprWrUwKYCyTKiD6dc59P9zh3XcFdj9niByGnjUosTS/+Mtup+AB9j1TfThfdtOvv3/swUc08vFshWzGeXKp17se+RHEhsJPqrX7/s8PSczMznqKkiC51a86rtJCtNooxcE4keKgqnPiQcxAubnO1bkBvLmbX+6q6NfDqi41kNoHrPUarWe/NHErABUu9VJm013dOSNfIYbQaZfkxc9oKr46pPxysSiNmIRkB5Xn49IMUTUBq6ncW5AgRg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=tvUEsdRgJYEB/Lr3tu6UBykHzl61yOYeLYa1ksZuKj8=;
 b=TP3h+wkVnnS989wntot9zFKAne9UqfZ9pB5aG1FG1Inb2gQO1mNyMuRJf3o4KBfWw/pYu+CedWCvkxasmySkbwXGoz/XAFIjqMWQ/CXTnpZ3gtajsODx5+K9kvL6nINXvGPCWHHNzCHdKQAQsk1MkFcEBr7MHUUAfyTkhLZzlQF4OQgeKkIDXchCHp2woNnsPaCexFHabLFUz5FCeuHpTCjP5hczBJFOoXEvQnihwK9DSsRNC06rtwiI2o74Wz4CCS44GtpFt6MNQBBqUgEH23tRZo5tSsD2t2v7pQZF/gPGU/A+jiN6J/tx8WSQDKha/5UIDd+BRH2bwzidj3D9DA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=tvUEsdRgJYEB/Lr3tu6UBykHzl61yOYeLYa1ksZuKj8=;
 b=jYpQlr0Ak+n/jBInYuA8jlYbEO3KajaPHpCBvcoUXEPgUhn3BZExNePWkvnlmkckEBcrJymNZKCEIjye28ktyIw69cW/1+SmXisRdfw82iFZIGcMiLIo6klKD6UNp+QViH82CBP8+LwmZuHzaRk/I9vlY56Tv6lX3Go2bKlHiI4=
From: Roger Pau Monne <roger.pau@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Roger Pau Monne <roger.pau@citrix.com>, Wei Liu <wl@xen.org>, Andrew
 Cooper <andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>, Stefano
 Stabellini <sstabellini@kernel.org>, Anthony PERARD
	<anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>, Christian
 Lindig <christian.lindig@citrix.com>, David Scott <dave@recoil.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, Ian Jackson
	<iwj@xenproject.org>
Subject: [PATCH for-4.16 v4] gnttab: allow setting max version per-domain
Date: Fri, 29 Oct 2021 09:59:56 +0200
Message-ID: <20211029075956.1260-1-roger.pau@citrix.com>
X-Mailer: git-send-email 2.33.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: MR2P264CA0167.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:501:1::30) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 82bcf445-28c7-47a4-89d0-08d99ab21f02
X-MS-TrafficTypeDiagnostic: DM5PR03MB2923:
X-Microsoft-Antispam-PRVS: <DM5PR03MB2923F2E12594906B95931C208F879@DM5PR03MB2923.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7219;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: +Tlrf2XrUY+IlVeXVLw/q8fcHr6cp3njN5an9ibF/8cwixpF3dyHJbUTEi0A9paaucH05hUZW51fmR/dks9TJhOOudMkHMfAsmG3dRiyHUmiva8M3dcr40cOrm1lhaDzSQfrHZI7AgzAM2RISApkWEcQnBjr29eNAR03JLvDSKeLb5IaDZqTOnrHrdGG4qiZCRl28ko33qvdW+Vj0tXN4ZoX+b5zB22uxQ5QFuHTtUm7lrKhTbdsxPcJtxkNqf3ueic2oQ2yONBSOIArU0y6Gobrcza0jMqSr5wXF2lh2IMwAFDxWrkfl/Vj6AUKl3f3YprSj/sOn2W6cWNB+X1KzUeADFk6UBl2o1/yRqHP2dT10q6GSUYhH7s0iQQvG3V1dsyhh8LTqFlGp+SVSSTd6ngU9HQPv9kgA0RorwPuTXilsvdzavpjST7yoUfrb6zv2a1Coq72aKqDawM/ybZF/JMuCafolMmJh1zzP8Ih7Jz93HEc2r3athlrxAicu7ZYqkUg/CsUDrd8bYKAwsj07oeQYnDSLH6aFjN5ApEPGVg0PaLxhHjmCZ8euqE1tyKJOMo6H0KRtq91ASHwlEX4lZ0FVpYkNPEBTIdVGJuqBbTFVhaNCkF6vs1gVqOo6fbGpyESNNFSVh0YLXGA7OHoAw==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(8936002)(54906003)(86362001)(186003)(4326008)(1076003)(26005)(6666004)(6486002)(82960400001)(30864003)(38100700002)(508600001)(2616005)(36756003)(956004)(83380400001)(66556008)(6916009)(2906002)(66946007)(66476007)(6496006)(316002)(5660300002)(8676002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bEJsaVZsZXJKR256eDdwTVFSZTM1WktuTmVobmFLa012MkhTN2tsMXFsZDZR?=
 =?utf-8?B?Uk5PZ3VkODVUSG5yQ0k5WGVsNkpZbkE3ako0M1pwYjloYWpBOWFFek85TVM0?=
 =?utf-8?B?cVY2QjlkL01yeXVxNHRzVWVycVF3M25QME5Wd05CNDRobUR0eDIybUFYZjcy?=
 =?utf-8?B?S0E2V3VtQUdPc0I4OVpRRDZJRS9KQXQ5T0dBbFlMT1VwOFdBbEVBdU9UZE8v?=
 =?utf-8?B?UEFhSGsxcjZVU3NYM2dKdWxuOHVDMWI0eWJUa1FFTzJlUEtzUFltaEx3VXY3?=
 =?utf-8?B?VVA4aUtQaVVOY3QrUENucWdMRE04QllUZytkRnlWRWFibFh1TFA0MGllMFRD?=
 =?utf-8?B?N29CWGc2RjllMUd5NWpUV05ia3d2ekZSaXJiZWNkRFBWZmlIMVVWQlVNdWp6?=
 =?utf-8?B?WW1VL05sOVVSM09DcklGc2E0RmxNSVNvODFMYmFDNWsrSFJyYnFMdUt0WHBr?=
 =?utf-8?B?SHNMcENUN0R3ZzBocCtFR1ErRm0xMHhHTE5IUTFhd0plWDhCU3kxTTlwY2VQ?=
 =?utf-8?B?Y21naGpzeG1SZXRWKzhQbWUrOFJYYnRuOEpDQUx6SlhKUFN3UWhvaW9TSnhL?=
 =?utf-8?B?WXd5bWFtbzZoYVowWVBPTnhpM05PaW1ObHpoL0E1VTluamlwbnFNdWsvVzFQ?=
 =?utf-8?B?WkFyV001RS9jQm1Tb0ErRGVnTjNPSDZLVmxGbnpoNVp5SHlqZWZMVmRnY1Fj?=
 =?utf-8?B?THYyVWJia0hMSm9FMEVTSE5EOE5SakFUSzhKZkJHSURJWFZCcUN0b2N1amxZ?=
 =?utf-8?B?UGJ2M1dMbjd5MlphM1ZFTy9saXpTajJoamYzeDRGWkNHWi93WW9UVFpHSWRM?=
 =?utf-8?B?andWQitLYnJMdDRiSW5DeU80QkdibjkvM2xFUm50d0VLWnZ3RmpXVFc4VWQw?=
 =?utf-8?B?M3NkaUVEdWUzT0JBTW5INFIxS3NMbEg4VUFvbW14TDFlTWV4Smh1SVp2aUgv?=
 =?utf-8?B?dUtVL01aTmdEZFk5U1R6dERnSnFTeTRKY3JYWjdnRUZqeEs4dkJmWnNOYlZL?=
 =?utf-8?B?WVpLZXBEQnVHMHE4U3A2Yk9BU1FhSTRqZUpMRTUwMm5zK0lhV0g4cy9FWUNs?=
 =?utf-8?B?R3JJdUZRWGtmM3R4aVp1dnNQMGFFd1pIbFBJSVF0RHFFM3E2ZWtBZ2ZnYTVy?=
 =?utf-8?B?N1FSWFdVWEs1cEp4TFlYV2hHNDkxbjFMbklNL3k0Mk1VN0N1YXFNbHR1QU1S?=
 =?utf-8?B?V0xvSkZyL2RoRmJMSjNVYjlzVFFDVGQ1LzBKRWJrTUhnSWRxZTVoaHhQbWI1?=
 =?utf-8?B?QkxuMitsNFIxYXRiWi8wTUpHaUtnZTBWU3FEUE1GQW1iNDNuZTdoZUY3bjVy?=
 =?utf-8?B?YnVqOC9wb2RuMExzeEVSZ1dOdUh1MWZZWWlvMWxJU20rK0xoQk5LY2gwQmE1?=
 =?utf-8?B?WWxpRzZSZHkySGMzQ3p2VmNzTHlJQTQ3N2I2eExSR000ZDcwWFlpZ3QwVDFJ?=
 =?utf-8?B?dlFUZFhRTUo2VjRLcHBWb1lkSlZqVHZMME95QXBtK000OFFoSjBEcGNOZzFV?=
 =?utf-8?B?YjNKRGZ4UVlsck95UEoxVHJpa0NrMnJsOXFpbnJtb25sMk9NczhqbisxSU4v?=
 =?utf-8?B?Tk9yTmVNbXJDVVNBR3ZqVDM2MDdkdDk3YjFPWHNTMGkwYW91Z09ha1VFSzRn?=
 =?utf-8?B?VG53RnpKSmJMS2N5S3UvNUx6ZDNvNjZGczlwOWlwazVwYVA0SlVESWZSbjJz?=
 =?utf-8?B?dmY5YWJtVmZjVThVUkZZU3pTaXpEbWhtS0xFZDF1Y1lhV05GR0ZpOERkakZn?=
 =?utf-8?B?RlZqOGVJa1FiZ3VkYWo4R3VFeC81Q3l5OWNVbGI1aFVkdHZXSjh0WkxieVFV?=
 =?utf-8?B?ak9xUGdnc0M4TmZ0WXV3dHVUUSt0akF4R2IrZDdJZVJmUWRaV0srUy80VEM4?=
 =?utf-8?B?ME5DYjd4cUkybVN5QjJLc2JNTlhKZ3BrYURVeHhPc01GQ1V0RHI4ODROMm1z?=
 =?utf-8?B?QXRoY3ZWTFdRaUNBZHpQMWd5dWdPR1ByMVFLaUtGb2gvVFZRaXRLbjhWc3JN?=
 =?utf-8?B?cFY4ZG53VWVIUS9qQ2lZRUZxdVBVSXJZZk50WXpjWTIxaDlCVXFmdGdPY3FK?=
 =?utf-8?B?eGxDRXE4Z1FjNUxlU29LMURpUDJZL0ZITWdOS0ZMV2l2OWViT1I3TExDdWk3?=
 =?utf-8?B?b1F3L1VQL0ppSDNtVXgwSTRhTjVtZEthY0VhY0xDRVhvY0xucFJIaWJZMU5D?=
 =?utf-8?Q?TnRdyu81NO6ynVXSZe5yr20=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 82bcf445-28c7-47a4-89d0-08d99ab21f02
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Oct 2021 08:00:06.6235
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4kCu7WB3nNhSVsJfQLPxZQxnjZur3G6SWnbGoL4bx2XwlH50f98PaBtjvG/wYhBjA5Bx63yeoeB1dMQ0STcbew==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB2923
X-OriginatorOrg: citrix.com

Introduce a new domain create field so that toolstack can specify the
maximum grant table version usable by the domain. This is plumbed into
xl and settable by the user as max_grant_version.

Previously this was only settable on a per host basis using the
gnttab command line option.

Note the version is specified using 4 bits, which leaves room to
specify up to grant table version 14 (15 is used to signal default max
version). Given that we only have 2 grant table versions right now,
and a new version is unlikely in the near future using 4 bits seems
more than enough.

xenstored stubdomains are limited to grant table v1 because the
current MiniOS code used to build them only has support for grants v1.
There are existing limits set for xenstored stubdomains at creation
time that already match the defaults in MiniOS.

Note that when using the default grant version the specific max
version in use by the domain is not migrated. Any guests should be
able to cope with the max grant version changing across migrations,
and if a specific guest relies on a maximum grant version being
unconditionally available it should be specified on the configuration
file.

Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
Acked-by: Christian Lindig <christian.lindig@citrix.com>
Reviewed-by: Ian Jackson <iwj@xenproject.org>
---
NB: the stubdom max grant version is cloned from the domain one. Not
sure whether long term we might want to use different options for the
stubdom and the domain. In any case the attack surface will always be
max(stubdom, domain), so maybe it's just pointless to allow more fine
grained settings.
---
Changes since v3:
 - Expand commit message re xenstored stubdomains.

Changes since v2:
 - Drop XEN_DOMCTLGRANT_MAX - it's unused.
 - Rename max_grant_version field to max_version in the grant table
   struct.
 - Print domain on log messages.
 - Print a message if host has more than 16Tb of RAM and grant v2 is
   disabled.
 - Add a TB macro.

Changes since v1:
 - Introduce a grant_opts field and use the low 4 bits to specify the
   version. Remaining bits will be used for other purposes.
---
Cc: Ian Jackson <iwj@xenproject.org>
---
Posting this patch alone as I think allowing to control transient
grants on a per-domain basis will require a bit more of work.

Release rationale:

We have had a bunch of security issues involving grant table v2 (382,
379, 268, 255) which could have been avoided by limiting the grant
table version available to guests. This can be currently done using a
global host parameter, but it's certainly more helpful to be able to
do it on a per domain basis from the toolstack.

Changes to the hypervisor by this patch are fairly minimal, as there
are already checks for the max grant table version allowed, so the
main change there is moving the max grant table version limit inside
the domain struct and plumbing it through the toolstrack.

I think the risk here is quite low for libxl/xl, because it's
extensively tested by osstest, so the main risk would be breaking the
Ocaml stubs, which could go unnoticed as those are not actually tested
by osstest.
---
 docs/man/xl.cfg.5.pod.in             |  6 ++++++
 docs/man/xl.conf.5.pod.in            |  7 +++++++
 tools/helpers/init-xenstore-domain.c |  1 +
 tools/include/libxl.h                |  7 +++++++
 tools/libs/light/libxl_create.c      |  3 +++
 tools/libs/light/libxl_dm.c          |  1 +
 tools/libs/light/libxl_types.idl     |  1 +
 tools/ocaml/libs/xc/xenctrl.ml       |  1 +
 tools/ocaml/libs/xc/xenctrl.mli      |  1 +
 tools/ocaml/libs/xc/xenctrl_stubs.c  |  7 ++++++-
 tools/xl/xl.c                        |  8 ++++++++
 tools/xl/xl.h                        |  1 +
 tools/xl/xl_parse.c                  |  9 +++++++++
 xen/arch/arm/domain_build.c          |  2 ++
 xen/arch/x86/setup.c                 |  1 +
 xen/common/domain.c                  |  3 ++-
 xen/common/grant_table.c             | 28 ++++++++++++++++++++++++++--
 xen/include/public/domctl.h          | 10 ++++++++--
 xen/include/xen/config.h             |  1 +
 xen/include/xen/grant_table.h        |  5 +++--
 20 files changed, 95 insertions(+), 8 deletions(-)

diff --git a/docs/man/xl.cfg.5.pod.in b/docs/man/xl.cfg.5.pod.in
index 55c4881205..21a39adb70 100644
--- a/docs/man/xl.cfg.5.pod.in
+++ b/docs/man/xl.cfg.5.pod.in
@@ -580,6 +580,12 @@ to have. This value controls how many pages of foreign domains can be accessed
 via the grant mechanism by this domain. The default value is settable via
 L<xl.conf(5)>.
 
+=item B<max_grant_version=NUMBER>
+
+Specify the maximum grant table version the domain is allowed to use. Current
+supported versions are 1 and 2. The default value is settable via
+L<xl.conf(5)>.
+
 =item B<nomigrate=BOOLEAN>
 
 Disable migration of this domain.  This enables certain other features
diff --git a/docs/man/xl.conf.5.pod.in b/docs/man/xl.conf.5.pod.in
index b48e99131a..0a70698a7c 100644
--- a/docs/man/xl.conf.5.pod.in
+++ b/docs/man/xl.conf.5.pod.in
@@ -101,6 +101,13 @@ Sets the default value for the C<max_maptrack_frames> domain config value.
 Default: value of Xen command line B<gnttab_max_maptrack_frames>
 parameter (or its default value if unspecified).
 
+=item B<max_grant_version=NUMBER>
+
+Sets the default value for the C<max_grant_version> domain config value.
+
+Default: value of Xen command line B<gnttab> parameter (or its default value if
+unspecified).
+
 =item B<vif.default.script="PATH">
 
 Configures the default hotplug script used by virtual network devices.
diff --git a/tools/helpers/init-xenstore-domain.c b/tools/helpers/init-xenstore-domain.c
index 6836002f0b..7cd1aa8f7c 100644
--- a/tools/helpers/init-xenstore-domain.c
+++ b/tools/helpers/init-xenstore-domain.c
@@ -88,6 +88,7 @@ static int build(xc_interface *xch)
          */
         .max_grant_frames = 4,
         .max_maptrack_frames = 128,
+        .grant_opts = 1,
     };
 
     xs_fd = open("/dev/xen/xenbus_backend", O_RDWR);
diff --git a/tools/include/libxl.h b/tools/include/libxl.h
index 2e8679dbcb..8621161845 100644
--- a/tools/include/libxl.h
+++ b/tools/include/libxl.h
@@ -514,6 +514,13 @@
  */
 #define LIBXL_HAVE_VPMU 1
 
+/*
+ * LIBXL_HAVE_MAX_GRANT_VERSION indicates libxl_domain_build_info has a
+ * max_grant_version field for setting the max grant table version per
+ * domain.
+ */
+#define LIBXL_HAVE_MAX_GRANT_VERSION 1
+
 /*
  * libxl ABI compatibility
  *
diff --git a/tools/libs/light/libxl_create.c b/tools/libs/light/libxl_create.c
index 5a61d01722..431c569dd2 100644
--- a/tools/libs/light/libxl_create.c
+++ b/tools/libs/light/libxl_create.c
@@ -607,6 +607,9 @@ int libxl__domain_make(libxl__gc *gc, libxl_domain_config *d_config,
             .max_evtchn_port = b_info->event_channels,
             .max_grant_frames = b_info->max_grant_frames,
             .max_maptrack_frames = b_info->max_maptrack_frames,
+            .grant_opts = b_info->max_grant_version == -1
+                          ? XEN_DOMCTL_GRANT_version_default
+                          : b_info->max_grant_version,
             .vmtrace_size = ROUNDUP(b_info->vmtrace_buf_kb << 10, XC_PAGE_SHIFT),
         };
 
diff --git a/tools/libs/light/libxl_dm.c b/tools/libs/light/libxl_dm.c
index 9d93056b5c..9a8ddbe188 100644
--- a/tools/libs/light/libxl_dm.c
+++ b/tools/libs/light/libxl_dm.c
@@ -2320,6 +2320,7 @@ void libxl__spawn_stub_dm(libxl__egc *egc, libxl__stub_dm_spawn_state *sdss)
 
     dm_config->b_info.max_grant_frames = guest_config->b_info.max_grant_frames;
     dm_config->b_info.max_maptrack_frames = guest_config->b_info.max_maptrack_frames;
+    dm_config->b_info.max_grant_version = guest_config->b_info.max_grant_version;
 
     dm_config->b_info.u.pv.features = "";
 
diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_types.idl
index 608d55a456..ce856febe5 100644
--- a/tools/libs/light/libxl_types.idl
+++ b/tools/libs/light/libxl_types.idl
@@ -519,6 +519,7 @@ libxl_domain_build_info = Struct("domain_build_info",[
 
     ("max_grant_frames",    uint32, {'init_val': 'LIBXL_MAX_GRANT_DEFAULT'}),
     ("max_maptrack_frames", uint32, {'init_val': 'LIBXL_MAX_GRANT_DEFAULT'}),
+    ("max_grant_version",   integer, {'init_val': '-1'}),
     
     ("device_model_version", libxl_device_model_version),
     ("device_model_stubdomain", libxl_defbool),
diff --git a/tools/ocaml/libs/xc/xenctrl.ml b/tools/ocaml/libs/xc/xenctrl.ml
index addcf4cc59..d3eacfba6e 100644
--- a/tools/ocaml/libs/xc/xenctrl.ml
+++ b/tools/ocaml/libs/xc/xenctrl.ml
@@ -84,6 +84,7 @@ type domctl_create_config =
 	max_evtchn_port: int;
 	max_grant_frames: int;
 	max_maptrack_frames: int;
+	max_grant_version: int;
 	arch: arch_domainconfig;
 }
 
diff --git a/tools/ocaml/libs/xc/xenctrl.mli b/tools/ocaml/libs/xc/xenctrl.mli
index 0a5ce529e9..96e5d14643 100644
--- a/tools/ocaml/libs/xc/xenctrl.mli
+++ b/tools/ocaml/libs/xc/xenctrl.mli
@@ -76,6 +76,7 @@ type domctl_create_config = {
   max_evtchn_port: int;
   max_grant_frames: int;
   max_maptrack_frames: int;
+  max_grant_version: int;
   arch: arch_domainconfig;
 }
 
diff --git a/tools/ocaml/libs/xc/xenctrl_stubs.c b/tools/ocaml/libs/xc/xenctrl_stubs.c
index ad953d36bd..1e60925069 100644
--- a/tools/ocaml/libs/xc/xenctrl_stubs.c
+++ b/tools/ocaml/libs/xc/xenctrl_stubs.c
@@ -188,7 +188,8 @@ CAMLprim value stub_xc_domain_create(value xch, value wanted_domid, value config
 #define VAL_MAX_EVTCHN_PORT     Field(config, 5)
 #define VAL_MAX_GRANT_FRAMES    Field(config, 6)
 #define VAL_MAX_MAPTRACK_FRAMES Field(config, 7)
-#define VAL_ARCH                Field(config, 8)
+#define VAL_MAX_GRANT_VERSION   Field(config, 8)
+#define VAL_ARCH                Field(config, 9)
 
 	uint32_t domid = Int_val(wanted_domid);
 	int result;
@@ -198,6 +199,9 @@ CAMLprim value stub_xc_domain_create(value xch, value wanted_domid, value config
 		.max_evtchn_port = Int_val(VAL_MAX_EVTCHN_PORT),
 		.max_grant_frames = Int_val(VAL_MAX_GRANT_FRAMES),
 		.max_maptrack_frames = Int_val(VAL_MAX_MAPTRACK_FRAMES),
+		.grant_opts = Int_val(VAL_MAX_GRANT_VERSION) == -1
+			      ? XEN_DOMCTL_GRANT_version_default
+			      : Int_val(VAL_MAX_GRANT_VERSION),
 	};
 
 	domain_handle_of_uuid_string(cfg.handle, String_val(VAL_HANDLE));
@@ -251,6 +255,7 @@ CAMLprim value stub_xc_domain_create(value xch, value wanted_domid, value config
 	}
 
 #undef VAL_ARCH
+#undef VAL_MAX_GRANT_VERSION
 #undef VAL_MAX_MAPTRACK_FRAMES
 #undef VAL_MAX_GRANT_FRAMES
 #undef VAL_MAX_EVTCHN_PORT
diff --git a/tools/xl/xl.c b/tools/xl/xl.c
index f422f9fed5..7564ff323b 100644
--- a/tools/xl/xl.c
+++ b/tools/xl/xl.c
@@ -55,6 +55,7 @@ bool progress_use_cr = 0;
 bool timestamps = 0;
 int max_grant_frames = -1;
 int max_maptrack_frames = -1;
+int max_grant_version = -1;
 libxl_domid domid_policy = INVALID_DOMID;
 
 xentoollog_level minmsglevel = minmsglevel_default;
@@ -219,6 +220,13 @@ static void parse_global_config(const char *configfile,
     else if (e != ESRCH)
         exit(1);
 
+    e = xlu_cfg_get_bounded_long (config, "max_grant_version", 0,
+                                  INT_MAX, &l, 1);
+    if (!e)
+        max_grant_version = l;
+    else if (e != ESRCH)
+        exit(1);
+
     libxl_cpu_bitmap_alloc(ctx, &global_vm_affinity_mask, 0);
     libxl_cpu_bitmap_alloc(ctx, &global_hvm_affinity_mask, 0);
     libxl_cpu_bitmap_alloc(ctx, &global_pv_affinity_mask, 0);
diff --git a/tools/xl/xl.h b/tools/xl/xl.h
index 7e23f30192..cf12c79a9b 100644
--- a/tools/xl/xl.h
+++ b/tools/xl/xl.h
@@ -282,6 +282,7 @@ extern char *default_colo_proxy_script;
 extern char *blkdev_start;
 extern int max_grant_frames;
 extern int max_maptrack_frames;
+extern int max_grant_version;
 extern libxl_bitmap global_vm_affinity_mask;
 extern libxl_bitmap global_hvm_affinity_mask;
 extern libxl_bitmap global_pv_affinity_mask;
diff --git a/tools/xl/xl_parse.c b/tools/xl/xl_parse.c
index c503b9be00..117fcdcb2b 100644
--- a/tools/xl/xl_parse.c
+++ b/tools/xl/xl_parse.c
@@ -1431,6 +1431,15 @@ void parse_config_data(const char *config_source,
     else
         exit(1);
 
+    e = xlu_cfg_get_bounded_long (config, "max_grant_version", 0,
+                                  INT_MAX, &l, 1);
+    if (e == ESRCH) /* not specified */
+        b_info->max_grant_version = max_grant_version;
+    else if (!e)
+        b_info->max_grant_version = l;
+    else
+        exit(1);
+
     libxl_defbool_set(&b_info->claim_mode, claim_mode);
 
     if (xlu_cfg_get_string (config, "on_poweroff", &buf, 0))
diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
index 0167731ab0..faeb3eba76 100644
--- a/xen/arch/arm/domain_build.c
+++ b/xen/arch/arm/domain_build.c
@@ -2967,6 +2967,7 @@ void __init create_domUs(void)
             .max_evtchn_port = -1,
             .max_grant_frames = -1,
             .max_maptrack_frames = -1,
+            .grant_opts = XEN_DOMCTL_GRANT_version_default,
         };
 
         if ( !dt_device_is_compatible(node, "xen,domain") )
@@ -3074,6 +3075,7 @@ void __init create_dom0(void)
         .max_evtchn_port = -1,
         .max_grant_frames = gnttab_dom0_frames(),
         .max_maptrack_frames = -1,
+        .grant_opts = XEN_DOMCTL_GRANT_version_default,
     };
 
     /* The vGIC for DOM0 is exactly emulating the hardware GIC */
diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c
index b101565f14..b5b6c75447 100644
--- a/xen/arch/x86/setup.c
+++ b/xen/arch/x86/setup.c
@@ -750,6 +750,7 @@ static struct domain *__init create_dom0(const module_t *image,
         .max_evtchn_port = -1,
         .max_grant_frames = -1,
         .max_maptrack_frames = -1,
+        .grant_opts = XEN_DOMCTL_GRANT_version_default,
         .max_vcpus = dom0_max_vcpus(),
         .arch = {
             .misc_flags = opt_dom0_msr_relaxed ? XEN_X86_MSR_RELAXED : 0,
diff --git a/xen/common/domain.c b/xen/common/domain.c
index 8b53c49d1e..0c7052c770 100644
--- a/xen/common/domain.c
+++ b/xen/common/domain.c
@@ -678,7 +678,8 @@ struct domain *domain_create(domid_t domid,
         init_status |= INIT_evtchn;
 
         if ( (err = grant_table_init(d, config->max_grant_frames,
-                                     config->max_maptrack_frames)) != 0 )
+                                     config->max_maptrack_frames,
+                                     config->grant_opts)) != 0 )
             goto fail;
         init_status |= INIT_gnttab;
 
diff --git a/xen/common/grant_table.c b/xen/common/grant_table.c
index e510395d08..f94f0f272c 100644
--- a/xen/common/grant_table.c
+++ b/xen/common/grant_table.c
@@ -53,6 +53,7 @@ struct grant_table {
     percpu_rwlock_t       lock;
     /* Lock protecting the maptrack limit */
     spinlock_t            maptrack_lock;
+    unsigned int          max_version;
     /*
      * Defaults to v1.  May be changed with GNTTABOP_set_version.  All other
      * values are invalid.
@@ -1917,11 +1918,33 @@ active_alloc_failed:
 }
 
 int grant_table_init(struct domain *d, int max_grant_frames,
-                     int max_maptrack_frames)
+                     int max_maptrack_frames, unsigned int options)
 {
     struct grant_table *gt;
+    unsigned int max_grant_version = options & XEN_DOMCTL_GRANT_version_mask;
     int ret = -ENOMEM;
 
+    if ( max_grant_version == XEN_DOMCTL_GRANT_version_default )
+        max_grant_version = opt_gnttab_max_version;
+    if ( !max_grant_version )
+    {
+        dprintk(XENLOG_INFO, "%pd: invalid grant table version 0 requested\n",
+                d);
+        return -EINVAL;
+    }
+    if ( max_grant_version > opt_gnttab_max_version )
+    {
+        dprintk(XENLOG_INFO,
+                "%pd: requested grant version (%u) greater than supported (%u)\n",
+                d, max_grant_version, opt_gnttab_max_version);
+        return -EINVAL;
+    }
+    if ( unlikely(max_page >= PFN_DOWN(TB(16))) && is_pv_domain(d) &&
+         max_grant_version < 2 )
+        dprintk(XENLOG_INFO,
+                "%pd: host memory above 16Tb and grant table v2 disabled\n",
+                d);
+
     /* Default to maximum value if no value was specified */
     if ( max_grant_frames < 0 )
         max_grant_frames = opt_max_grant_frames;
@@ -1947,6 +1970,7 @@ int grant_table_init(struct domain *d, int max_grant_frames,
     gt->gt_version = 1;
     gt->max_grant_frames = max_grant_frames;
     gt->max_maptrack_frames = max_maptrack_frames;
+    gt->max_version = max_grant_version;
 
     /* Install the structure early to simplify the error path. */
     gt->domain = d;
@@ -3076,7 +3100,7 @@ gnttab_set_version(XEN_GUEST_HANDLE_PARAM(gnttab_set_version_t) uop)
         goto out;
 
     res = -ENOSYS;
-    if ( op.version == 2 && opt_gnttab_max_version == 1 )
+    if ( op.version == 2 && gt->max_version == 1 )
         goto out; /* Behave as before set_version was introduced. */
 
     res = 0;
diff --git a/xen/include/public/domctl.h b/xen/include/public/domctl.h
index 51017b47bc..0ec57614bd 100644
--- a/xen/include/public/domctl.h
+++ b/xen/include/public/domctl.h
@@ -89,14 +89,20 @@ struct xen_domctl_createdomain {
     /*
      * Various domain limits, which impact the quantity of resources
      * (global mapping space, xenheap, etc) a guest may consume.  For
-     * max_grant_frames and max_maptrack_frames, < 0 means "use the
-     * default maximum value in the hypervisor".
+     * max_grant_frames, max_maptrack_frames and max_gnttab_version < 0
+     * means "use the default maximum value in the hypervisor".
      */
     uint32_t max_vcpus;
     uint32_t max_evtchn_port;
     int32_t max_grant_frames;
     int32_t max_maptrack_frames;
 
+/* Grant version, use low 4 bits. */
+#define XEN_DOMCTL_GRANT_version_mask    0xf
+#define XEN_DOMCTL_GRANT_version_default 0xf
+
+    uint32_t grant_opts;
+
     /* Per-vCPU buffer size in bytes.  0 to disable. */
     uint32_t vmtrace_size;
 
diff --git a/xen/include/xen/config.h b/xen/include/xen/config.h
index b76222ecf6..37b42c756a 100644
--- a/xen/include/xen/config.h
+++ b/xen/include/xen/config.h
@@ -81,6 +81,7 @@
 #define KB(_kb)     (_AC(_kb, ULL) << 10)
 #define MB(_mb)     (_AC(_mb, ULL) << 20)
 #define GB(_gb)     (_AC(_gb, ULL) << 30)
+#define TB(_tb)     (_AC(_tb, ULL) << 40)
 
 #define IS_ALIGNED(val, align) (((val) & ((align) - 1)) == 0)
 
diff --git a/xen/include/xen/grant_table.h b/xen/include/xen/grant_table.h
index 41713e2726..fe6225346f 100644
--- a/xen/include/xen/grant_table.h
+++ b/xen/include/xen/grant_table.h
@@ -36,7 +36,7 @@ extern unsigned int opt_max_grant_frames;
 
 /* Create/destroy per-domain grant table context. */
 int grant_table_init(struct domain *d, int max_grant_frames,
-                     int max_maptrack_frames);
+                     int max_maptrack_frames, unsigned int options);
 void grant_table_destroy(
     struct domain *d);
 void grant_table_init_vcpu(struct vcpu *v);
@@ -67,7 +67,8 @@ int gnttab_acquire_resource(
 
 static inline int grant_table_init(struct domain *d,
                                    int max_grant_frames,
-                                   int max_maptrack_frames)
+                                   int max_maptrack_frames,
+                                   unsigned int options)
 {
     return 0;
 }
-- 
2.33.0



From xen-devel-bounces@lists.xenproject.org Fri Oct 29 08:02:26 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Oct 2021 08:02:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.218441.378871 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgMqD-0006UC-EY; Fri, 29 Oct 2021 08:02:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 218441.378871; Fri, 29 Oct 2021 08:02:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgMqD-0006U5-AM; Fri, 29 Oct 2021 08:02:21 +0000
Received: by outflank-mailman (input) for mailman id 218441;
 Fri, 29 Oct 2021 08:02:20 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mgMqC-0006Tt-6v; Fri, 29 Oct 2021 08:02:20 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mgMqB-0006Hu-TH; Fri, 29 Oct 2021 08:02:19 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mgMqB-0005E1-HI; Fri, 29 Oct 2021 08:02:19 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mgMqB-0003e6-Gm; Fri, 29 Oct 2021 08:02:19 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=8V12mdoJ0bhPuITt5pcJBoJMVrq87J9PO234B+pxMPE=; b=tbqaCg2SSxhB3vLaLHYZu/vzg+
	fP2zXAJ6lKalF5r7UqygpVvP9sYIMdzmi13+yoDTQ/fcszlzCP3B9gcKRe7JYZPQGo2L6hYj5F061
	YayovaQCp5Tc9oz+zVCYEI6OYxu23eZNFyu2e3ePORTcObqOanSKv58ybFWDrqee0LII=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165931-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 165931: regressions - FAIL
X-Osstest-Failures:
    libvirt:build-armhf-libvirt:libvirt-build:fail:regression
    libvirt:build-amd64-libvirt:libvirt-build:fail:regression
    libvirt:build-i386-libvirt:libvirt-build:fail:regression
    libvirt:build-arm64-libvirt:libvirt-build:fail:regression
    libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    libvirt=ed87c62c2bdbfa35e08195c0573dc8f46e866167
X-Osstest-Versions-That:
    libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 29 Oct 2021 08:02:19 +0000

flight 165931 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165931/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-armhf-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-amd64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-i386-libvirt            6 libvirt-build            fail REGR. vs. 151777
 build-arm64-libvirt           6 libvirt-build            fail REGR. vs. 151777

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-libvirt-vhd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a

version targeted for testing:
 libvirt              ed87c62c2bdbfa35e08195c0573dc8f46e866167
baseline version:
 libvirt              2c846fa6bcc11929c9fb857a22430fb9945654ad

Last test of basis   151777  2020-07-10 04:19:19 Z  476 days
Failing since        151818  2020-07-11 04:18:52 Z  475 days  461 attempts
Testing same since   165922  2021-10-28 04:20:15 Z    1 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
    Adolfo Jayme Barrientos <fitoschido@gmail.com>
  Aleksandr Alekseev <alexander.alekseev@virtuozzo.com>
  Aleksei Zakharov <zaharov@selectel.ru>
  Andika Triwidada <andika@gmail.com>
  Andrea Bolognani <abologna@redhat.com>
  Ani Sinha <ani@anisinha.ca>
  Balázs Meskó <meskobalazs@mailbox.org>
  Barrett Schonefeld <bschoney@utexas.edu>
  Bastian Germann <bastiangermann@fishpost.de>
  Bastien Orivel <bastien.orivel@diateam.net>
  BiaoXiang Ye <yebiaoxiang@huawei.com>
  Bihong Yu <yubihong@huawei.com>
  Binfeng Wu <wubinfeng@huawei.com>
  Bjoern Walk <bwalk@linux.ibm.com>
  Boris Fiuczynski <fiuczy@linux.ibm.com>
  Brian Turek <brian.turek@gmail.com>
  Bruno Haible <bruno@clisp.org>
  Chris Mayo <aklhfex@gmail.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Ehrhardt <christian.ehrhardt@canonical.com>
  Christian Kirbach <christian.kirbach@gmail.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Cole Robinson <crobinso@redhat.com>
  Collin Walling <walling@linux.ibm.com>
  Cornelia Huck <cohuck@redhat.com>
  Cédric Bosdonnat <cbosdonnat@suse.com>
  Côme Borsoi <fedora@borsoi.fr>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniel Letai <dani@letai.org.il>
  Daniel P. Berrange <berrange@redhat.com>
  Daniel P. Berrangé <berrange@redhat.com>
  Didik Supriadi <didiksupriadi41@gmail.com>
  dinglimin <dinglimin@cmss.chinamobile.com>
  Dmitrii Shcherbakov <dmitrii.shcherbakov@canonical.com>
  Dmytro Linkin <dlinkin@nvidia.com>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Eric Farman <farman@linux.ibm.com>
  Erik Skultety <eskultet@redhat.com>
  Fabian Affolter <mail@fabian-affolter.ch>
  Fabian Freyer <fabian.freyer@physik.tu-berlin.de>
  Fabiano Fidêncio <fabiano@fidencio.org>
  Fangge Jin <fjin@redhat.com>
  Farhan Ali <alifm@linux.ibm.com>
  Fedora Weblate Translation <i18n@lists.fedoraproject.org>
  Franck Ridel <fridel@protonmail.com>
  Gavi Teitz <gavi@nvidia.com>
  gongwei <gongwei@smartx.com>
  Guoyi Tu<tu.guoyi@h3c.com>
  Göran Uddeborg <goeran@uddeborg.se>
  Halil Pasic <pasic@linux.ibm.com>
  Han Han <hhan@redhat.com>
  Hao Wang <wanghao232@huawei.com>
  Hela Basa <r45xveza@pm.me>
  Helmut Grohne <helmut@subdivi.de>
  Hiroki Narukawa <hnarukaw@yahoo-corp.jp>
  Ian Wienand <iwienand@redhat.com>
  Jakob Meng <jakobmeng@web.de>
  Jamie Strandboge <jamie@canonical.com>
  Jamie Strandboge <jamie@ubuntu.com>
  Jan Kuparinen <copper_fin@hotmail.com>
  jason lee <ppark5237@gmail.com>
  Jean-Baptiste Holcroft <jean-baptiste@holcroft.fr>
  Jia Zhou <zhou.jia2@zte.com.cn>
  Jianan Gao <jgao@redhat.com>
  Jim Fehlig <jfehlig@suse.com>
  Jin Yan <jinyan12@huawei.com>
  Jinsheng Zhang <zhangjl02@inspur.com>
  Jiri Denemark <jdenemar@redhat.com>
  John Ferlan <jferlan@redhat.com>
  Jonathan Watt <jwatt@jwatt.org>
  Jonathon Jongsma <jjongsma@redhat.com>
  Julio Faracco <jcfaracco@gmail.com>
  Justin Gatzen <justin.gatzen@gmail.com>
  Ján Tomko <jtomko@redhat.com>
  Kashyap Chamarthy <kchamart@redhat.com>
  Kevin Locke <kevin@kevinlocke.name>
  Kristina Hanicova <khanicov@redhat.com>
  Laine Stump <laine@redhat.com>
  Laszlo Ersek <lersek@redhat.com>
  Lee Yarwood <lyarwood@redhat.com>
  Lei Yang <yanglei209@huawei.com>
  Liao Pingfang <liao.pingfang@zte.com.cn>
  Lin Ma <lma@suse.com>
  Lin Ma <lma@suse.de>
  Lin Ma <morecache@gmail.com>
  Liu Yiding <liuyd.fnst@fujitsu.com>
  Luke Yue <lukedyue@gmail.com>
  Luyao Zhong <luyao.zhong@intel.com>
  Marc Hartmayer <mhartmay@linux.ibm.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Markus Schade <markus.schade@hetzner.com>
  Martin Kletzander <mkletzan@redhat.com>
  Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
  Matej Cepl <mcepl@cepl.eu>
  Matt Coleman <matt@datto.com>
  Matt Coleman <mcoleman@datto.com>
  Mauro Matteo Cascella <mcascell@redhat.com>
  Meina Li <meili@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Michał Smyk <fedora@smyk.it>
  Milo Casagrande <milo@milo.name>
  Moshe Levi <moshele@nvidia.com>
  Muha Aliss <muhaaliss@gmail.com>
  Nathan <nathan95@live.it>
  Neal Gompa <ngompa13@gmail.com>
  Nick Chevsky <nchevsky@gmail.com>
  Nick Shyrokovskiy <nshyrokovskiy@gmail.com>
  Nickys Music Group <nickys.music.group@gmail.com>
  Nico Pache <npache@redhat.com>
  Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
  Olaf Hering <olaf@aepfle.de>
  Olesya Gerasimenko <gammaray@basealt.ru>
  Or Ozeri <oro@il.ibm.com>
  Orion Poplawski <orion@nwra.com>
  Pany <geekpany@gmail.com>
  Patrick Magauran <patmagauran.j@gmail.com>
  Paulo de Rezende Pinatti <ppinatti@linux.ibm.com>
  Pavel Hrdina <phrdina@redhat.com>
  Peng Liang <liangpeng10@huawei.com>
  Peter Krempa <pkrempa@redhat.com>
  Pino Toscano <ptoscano@redhat.com>
  Pino Toscano <toscano.pino@tiscali.it>
  Piotr Drąg <piotrdrag@gmail.com>
  Prathamesh Chavan <pc44800@gmail.com>
  Praveen K Paladugu <prapal@linux.microsoft.com>
  Richard W.M. Jones <rjones@redhat.com>
  Ricky Tigg <ricky.tigg@gmail.com>
  Robin Lee <cheeselee@fedoraproject.org>
  Roman Bogorodskiy <bogorodskiy@gmail.com>
  Roman Bolshakov <r.bolshakov@yadro.com>
  Ryan Gahagan <rgahagan@cs.utexas.edu>
  Ryan Schmidt <git@ryandesign.com>
  Sam Hartman <hartmans@debian.org>
  Scott Shambarger <scott-libvirt@shambarger.net>
  Sebastian Mitterle <smitterl@redhat.com>
  SeongHyun Jo <caelus9536@gmail.com>
  Shalini Chellathurai Saroja <shalini@linux.ibm.com>
  Shaojun Yang <yangshaojun@phytium.com.cn>
  Shi Lei <shi_lei@massclouds.com>
  simmon <simmon@nplob.com>
  Simon Chopin <chopin.simon@gmail.com>
  Simon Gaiser <simon@invisiblethingslab.com>
  Simon Rowe <simon.rowe@nutanix.com>
  Stefan Bader <stefan.bader@canonical.com>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Berger <stefanb@linux.vnet.ibm.com>
  Stefan Hajnoczi <stefanha@gmail.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Szymon Scholz <szymonscholz@gmail.com>
  Thomas Huth <thuth@redhat.com>
  Tim Wiederhake <twiederh@redhat.com>
  Tomáš Golembiovský <tgolembi@redhat.com>
  Tomáš Janoušek <tomi@nomi.cz>
  Tuguoyi <tu.guoyi@h3c.com>
  Victor Toso <victortoso@redhat.com>
  Ville Skyttä <ville.skytta@iki.fi>
  Vinayak Kale <vkale@nvidia.com>
  Wang Xin <wangxinxin.wang@huawei.com>
  WangJian <wangjian161@huawei.com>
  Weblate <noreply@weblate.org>
  Wei Liu <liuwe@microsoft.com>
  Wei Liu <wei.liu@kernel.org>
  Wei-Chen Chen <weicche@microsoft.com>
  William Douglas <william.douglas@intel.com>
  Yalei Li <274268859@qq.com>
  Yalei Li <liyl43@chinatelecom.cn>
  Yang Fei <yangfei85@huawei.com>
  Yang Hang <yanghang44@huawei.com>
  Yanqiu Zhang <yanqzhan@redhat.com>
  Yaroslav Kargin <ykargin@virtuozzo.com>
  Yi Li <yili@winhong.com>
  Yi Wang <wang.yi59@zte.com.cn>
  Yuri Chornoivan <yurchor@ukr.net>
  Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
  zhangjl02 <zhangjl02@inspur.com>
  Zheng Chuan <zhengchuan@huawei.com>
  zhenwei pi <pizhenwei@bytedance.com>
  Zhenyu Ye <yezhenyu2@huawei.com>
  Zhenyu Zheng <zheng.zhenyu@outlook.com>
  Zhenzhong Duan <zhenzhong.duan@intel.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          fail    
 build-arm64-libvirt                                          fail    
 build-armhf-libvirt                                          fail    
 build-i386-libvirt                                           fail    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           blocked 
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-libvirt-xsm                                 blocked 
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-libvirt                                     blocked 
 test-arm64-arm64-libvirt                                     blocked 
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-libvirt-pair                                blocked 
 test-amd64-i386-libvirt-pair                                 blocked 
 test-arm64-arm64-libvirt-qcow2                               blocked 
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-libvirt-vhd                                 blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 81184 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Oct 29 08:45:11 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Oct 2021 08:45:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.218450.378885 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgNVO-0002Y7-Sk; Fri, 29 Oct 2021 08:44:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 218450.378885; Fri, 29 Oct 2021 08:44:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgNVO-0002Y0-Oq; Fri, 29 Oct 2021 08:44:54 +0000
Received: by outflank-mailman (input) for mailman id 218450;
 Fri, 29 Oct 2021 08:44:53 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=H5Tp=PR=intel.com=kevin.tian@srs-us1.protection.inumbo.net>)
 id 1mgNVN-0002Xs-06
 for xen-devel@lists.xenproject.org; Fri, 29 Oct 2021 08:44:53 +0000
Received: from mga09.intel.com (unknown [134.134.136.24])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 0f194239-45ff-4347-8c8a-c17244b63f95;
 Fri, 29 Oct 2021 08:44:47 +0000 (UTC)
Received: from fmsmga008.fm.intel.com ([10.253.24.58])
 by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 29 Oct 2021 01:44:46 -0700
Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86])
 by fmsmga008.fm.intel.com with ESMTP; 29 Oct 2021 01:44:46 -0700
Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by
 fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2242.12; Fri, 29 Oct 2021 01:44:45 -0700
Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by
 fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2242.12 via Frontend Transport; Fri, 29 Oct 2021 01:44:45 -0700
Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.177)
 by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.1.2242.12; Fri, 29 Oct 2021 01:44:40 -0700
Received: from BN9PR11MB5433.namprd11.prod.outlook.com (2603:10b6:408:11e::13)
 by BN7PR11MB2563.namprd11.prod.outlook.com (2603:10b6:406:b0::33)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.14; Fri, 29 Oct
 2021 08:44:38 +0000
Received: from BN9PR11MB5433.namprd11.prod.outlook.com
 ([fe80::ecad:62e1:bab9:ac81]) by BN9PR11MB5433.namprd11.prod.outlook.com
 ([fe80::ecad:62e1:bab9:ac81%7]) with mapi id 15.20.4649.014; Fri, 29 Oct 2021
 08:44:38 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0f194239-45ff-4347-8c8a-c17244b63f95
X-IronPort-AV: E=McAfee;i="6200,9189,10151"; a="230482638"
X-IronPort-AV: E=Sophos;i="5.87,192,1631602800"; 
   d="scan'208";a="230482638"
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.87,192,1631602800"; 
   d="scan'208";a="538663352"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=LvWhFLgEs0h6qYxJQr52jKq4Axbom/nCT1S+i9JxqpAzuA0ul5rDiv5BSNeypl4seQU5oG9lhvIyNVq9sp65ILKm7Wdm16cpzSwTQ0UDY5nVGh5iMMcNnqN/SlMDPQOseD32qstifzfDqnhjb0kNZZrVo5fYeSaZLDH1TSD9WCGk2Y8lKf2CWEnv6MM7nCscLujA0USbBCt6o2Sxm0uVRHK8pAdLYyGlFXxCjf1VsbC4OM/O8gFJANvzDwSXtp94Fxx/MuXeM/KESbDMqAH3g7GU6GWegbktJLlHAN1sQHF87ehTqgGxR0w0N5BT6Vru5Lzf5y2AKiffICL8BUIMmg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=aSYA/iS4g4dvAdWlB/IxW3i1t49wb+LtWl8hPvbpU6o=;
 b=LHaee6BwwDG/ZMeH6Uyy5nOoEZ9jL0bk0ueqL7CSnwbSeCwEu8cgaYYGJkkXRR+7mr7H3BkooWIt1LSR2H8k7iftfpPeSsFp0hJeZTeIxSYXXB1+WNyizXd0JvYjYFUd19NFD9DJJt0/1L/fEXt5zmGDO7iIi8NwTpIVogTPnECUbQ4Ee+wLk6mbzfwX8H4+Wf8J4c3sp6RU1+30e2+xNq0DbBngN3moivhDzD38eFM4cNnT7RAOSqaVqj5Og6TLhjgHLlaNADUfqHd7IDnvRKGYdGOxacKKiOUadg1HNInvvmjmdtdDvY4+V+yVXxQwD+A3S4RpApQwfbJ3lcmdeg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;
 dkim=pass header.d=intel.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com;
 s=selector2-intel-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=aSYA/iS4g4dvAdWlB/IxW3i1t49wb+LtWl8hPvbpU6o=;
 b=hn9U/viY9Qx6EBaHDsdtMJdgPvA0IghLjwMs4rYX5VEiriOHRyDGR379ejuirZtZ+0c0l4zQGZN2Pblmixacs3oJk2HfuSWsAlfd1IaPrpn4K/dvHhQTON10w7B3vq5vgAWHlY4/sv/n/F12JQx6hVyU63nbkLW/6VtqK1iIlkU=
From: "Tian, Kevin" <kevin.tian@intel.com>
To: Jan Beulich <jbeulich@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: "Cooper, Andrew" <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
	=?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>, Paul Durrant
	<paul@xen.org>
Subject: RE: [PATCH v2 1/3] x86/IOMMU: mark IOMMU / intremap not in use when
 ACPI tables are missing
Thread-Topic: [PATCH v2 1/3] x86/IOMMU: mark IOMMU / intremap not in use when
 ACPI tables are missing
Thread-Index: AQHXxmJDj1yUJeGSDkOPNy18ywaldKvehyQAgAsuYGA=
Date: Fri, 29 Oct 2021 08:44:38 +0000
Message-ID: <BN9PR11MB5433E504303B916154265E678C879@BN9PR11MB5433.namprd11.prod.outlook.com>
References: <09137aa2-649f-08fb-ba68-75f8eb16fc63@suse.com>
 <efe34081-c813-0e37-175c-8553b395e6d9@suse.com>
 <ffe7f130-9034-50d0-ab0a-06933dde88d8@suse.com>
In-Reply-To: <ffe7f130-9034-50d0-ab0a-06933dde88d8@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: suse.com; dkim=none (message not signed)
 header.d=none;suse.com; dmarc=none action=none header.from=intel.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 31f03bc0-14ed-414e-e38a-08d99ab857ab
x-ms-traffictypediagnostic: BN7PR11MB2563:
x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr
x-microsoft-antispam-prvs: <BN7PR11MB2563E631B2B2CDB887D65D2D8C879@BN7PR11MB2563.namprd11.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:2803;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: xiLNjCc93H8SyRyT4NQriPa2WBkNtBwEX0NMFKmkzfCQCjrSC4rVgieToTMtKSlFb+8JGjXoTwa+k97brOJs6H/k5mE2AIIxtLMXDK0zKttwRvISzfY79602NWwIjE1lFxCb2lbOe5A/Aj+MS0sN9dIAYnnb/mJqaZ2ZQNo5TPKmLCcRNaAtvfizNuWL8xjvW+ARuauyo7xMOpkU0eqv1YFgLpy0RSWlWHZyqdMbGYHuf3X1hxpsGiAUwsvQxN3InCH5UIuUDpMhSq+7hxRdJ3m+ohHm0wnaLgti2ApS8ho8xzMgJRSua1qB+5lDehiy0XNlw9plXjz6NVyjtvMhnIKuJDBXS3mHZhV3i4/HFpY9gmvSPz0B6EgKoVDTL7N3gEZP8Bnkxtl0V1H6QmGiwEF5HAplfBidjgt7WdLFa2D/XegcCXGSRPYkhXe/WWwvsU9ulljmvumGZN2Qi+2+DGWgiY2tYgYzT2WOxh6keGg3aoc9JWcmkFVhdA5mlVUb05p1l+aqf5Qvb3juW1vIJUc4w5YrZ9m4Os5PlxSCY7TNPdsJiLnPpCLBuDS4vFksYL4tm63m/o4XqI8M0mNnRbisRYzA+PMjpTX296ILEw7Fp1U9uf2Ftl+rACTxRsv0sdCzkfinX1hgKzNLSO2puVRxoGTqzFqhIKiowO9sh94tP6cEJxmdBQNUeA4we7VGQau39UpLK842rxtLgrFxdA==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR11MB5433.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(83380400001)(508600001)(8936002)(52536014)(33656002)(4326008)(8676002)(122000001)(38100700002)(76116006)(66946007)(110136005)(55016002)(54906003)(7696005)(9686003)(86362001)(64756008)(66556008)(53546011)(2906002)(316002)(186003)(26005)(71200400001)(5660300002)(66476007)(66446008)(82960400001)(38070700005)(6506007);DIR:OUT;SFP:1102;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?d0VjYlRxUUpuZmNJOGplNW5GUHJBVmVleC9oOW5zazRjYmJVRGFnY3RsWmQ1?=
 =?utf-8?B?UjYrYUtPSnBoblpQWVI3cDhrTGNoSVpRbEhFdnF0TWF6RkdpekFVcHRnZWNj?=
 =?utf-8?B?Y1IzL01yTXZhaEduZXNkY1VPN0Z1dVZaM1pBclVHTkVPajV5cngzRzBCMDVz?=
 =?utf-8?B?bU1uSmp3eGwvUVZsV0FUbHZYMFdNNnIvV2tRMUhBK1JSWVRnZW1zVmZ6anZs?=
 =?utf-8?B?VjdYNlZWT3lNakJObFFEdFQ0SzZNb2RhNVB3Tk5BUkUzUWszaEg5MlZKOTdq?=
 =?utf-8?B?SW83TUtEdnV5K1ZpczlaZTdtdDB5NmY5OUNLUGczTjJHWFEwbkFWRXZWYm5w?=
 =?utf-8?B?bmpUNUhZUTcySnovQWtNMlhrUjRNNFI0R1QxN3NGS3hDbUpOZThzclBWOHNZ?=
 =?utf-8?B?LzZrem0xQjI0c3NwbUNtR1gxS2RnVUE0NWVWbTMvdVlLbmZtb1VmMFZDNmpv?=
 =?utf-8?B?Y3ZCL1dvQzFkQ2RUdmFnNENUZnUva1V5U3F1NTR0YzM0Uzh1NjlmcW9GOEVS?=
 =?utf-8?B?TDNVSmEwdU1JWURlV0NLbmR6cXdxSmtUMllyYTIyTUFBaGM4UlNhSGlzTm55?=
 =?utf-8?B?VS8rYWh1TjlFWHNMUzJ4WkNNUUtma0ZCV2paWHlKaFMvY1pOTXJFVm1KNUtX?=
 =?utf-8?B?QldaZ3NkNkw0di9KQzVWRGp3Ym16K2ZEL01scjJWR2RoeXJLdlNLemxtb2RI?=
 =?utf-8?B?M2ZvdFVabTg3VHVDbGlmSFVlM1crclVpTDFLdWI5cWUvK0lGeC9pbkMrSkV5?=
 =?utf-8?B?eU1BYXZhMXNVdlFQS3dzNXF3NktwMHREaVpLZVg5QjBLVjRob01mbDJ4T3Av?=
 =?utf-8?B?dXRxcWduanp0NXVvK1ZxVVhCZWFPTThjRGlpb2Z5S1pjTGpGR242eEtQWUtt?=
 =?utf-8?B?dm00Qm85MGRyM2NORXBzbk5YbmRtaVZwL1hzSVU2WFZybE9Ecm5OQm4yT0dl?=
 =?utf-8?B?cDVMNmpPaVdaMldicmVvZUlsWDl1Z01JQW52bmFLbktNMk53R28yVTVVT1Vo?=
 =?utf-8?B?K2pnVjhVcmpRSTd4UFJnT2pkUDhYZ1FHenhjTGRyS1RoTlNXMXc1UU9mMUZ5?=
 =?utf-8?B?U1lkOXN4YWZHemlqbzk0WkRuaGRwY2tST2FGQzgrQWh6bVBldU8zL2ZYWk14?=
 =?utf-8?B?ZXV0S0s1RWxWRVNYSGVEUUhqb3FrKzBDZmpIVzlpbG1SWnpNRjZRZ0hodHVw?=
 =?utf-8?B?U1BvUHV5d1RPSEkzeVpxZjhqUlF6QXROaytvTU5PODdvVXM5WWptaUNJUVMw?=
 =?utf-8?B?OWF1eVBSaWwyN3Z1ZkdHS016VnJaQlZXUWlidXQwYlpGKzFyUjZYOElsTXdk?=
 =?utf-8?B?L053UFF1NnJocGl3TktPbDN5SUFZTHpDSmFHamY0ei9GYVMrQUhFREE4czRU?=
 =?utf-8?B?SHg1dXB1dGtuRm5CeU1EUnVNOWt4SWMxcXpxTXdUVUFxdlhHWTlBcmdEUTJr?=
 =?utf-8?B?NkhFeU02eDA3ME5PNUVpWllhaFk3ZW5hVGtNYkJvWjI4ZjNIVzB6VDhFanJJ?=
 =?utf-8?B?RmZZVUh4MnN2Ly90OWp3U1NORTQwTzJyNWpVMTlveit0S05LSUFLQ0txNzI4?=
 =?utf-8?B?UFQwN1VYRmlwY2EvNWdkc3FJY3JzV0wzd0dNdFlLU2Npa0VmaHU4UHBaZzJS?=
 =?utf-8?B?REdPNGs2cDlDSVcvaFQ0ekNIOG1LaHhvYVVWVTV5dWpYV1UxQlk2VGpVSnFO?=
 =?utf-8?B?akFqR3AvK2pQUU5HMHBZSWJtUmhQcGpUQm5RTll6VXVWaEJXUEpaR25QcXlG?=
 =?utf-8?B?bzVudTliTjlCbHl4QlhSd2VwNnVlTkV6WENPZ2x1VldadmQ4S1lHVDJtYU4x?=
 =?utf-8?B?SmJrODBQUG9oM0UzVzVnMGZwTE8wcExhUTdKWXJKdWJnZ1dlVGZZVHkvWGxD?=
 =?utf-8?B?cGxBamtDVmJzeld5ZGh5Tkt1WHZkc0luTWlYQkdUUW5wQmM5aytFQzJTa3ZP?=
 =?utf-8?B?K1pnbUg2TWd6QkxhTXplRVFRUUVzbzQvOTI2aGQ5YzV6aERrZGRYRlJEUndN?=
 =?utf-8?B?cWNKNVZOOW5lUGdrTHM2VXFvQWs2am9WSXp5a2tLcjQ2RGJqNkZyK1ZNK2t0?=
 =?utf-8?B?Y0FxZ3RtUzJFb2o4MDdEenJ3UDI5MDlnYkphNDF4THlEZHZkV0lvTktCTEFp?=
 =?utf-8?B?dm9QUUE5eDh1WWRkMTJDdzdrd0lQNjcxMko3ekxqenJWdjNSWUxSMTRNbXFC?=
 =?utf-8?B?VGc9PQ==?=
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5433.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 31f03bc0-14ed-414e-e38a-08d99ab857ab
X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Oct 2021 08:44:38.4571
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: AOqwnQQmM1yAs2cf0SRALpDkaBDIKi/wfwNiVfKVKAZFw3xjvbkzw2Z8tJK1Vteq3g27VHXe3d4YitAXgJ+Bwg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR11MB2563
X-OriginatorOrg: intel.com

PiBGcm9tOiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+DQo+IFNlbnQ6IEZyaWRheSwg
T2N0b2JlciAyMiwgMjAyMSAxOjU5IFBNDQo+IA0KPiBPbiAyMS4xMC4yMDIxIDExOjU4LCBKYW4g
QmV1bGljaCB3cm90ZToNCj4gPiB4MmFwaWNfYnNwX3NldHVwKCkgZ2V0cyBjYWxsZWQgYWhlYWQg
b2YgaW9tbXVfc2V0dXAoKSwgYW5kIHNpbmNlIHgyQVBJQw0KPiA+IG1vZGUgKHBoeXNpY2FsIHZz
IGNsdXN0ZXJlZCkgZGVwZW5kcyBvbiBpb21tdV9pbnRyZW1hcCwgdGhhdCB2YXJpYWJsZQ0KPiA+
IG5lZWRzIHRvIGJlIHNldCB0byBvZmYgYXMgc29vbiBhcyB3ZSBrbm93IHdlIGNhbid0IC8gd29u
J3QgZW5hYmxlDQo+ID4gaW50ZXJydXB0IHJlbWFwcGluZywgaS5lLiBpbiBwYXJ0aWN1bGFyIHdo
ZW4gcGFyc2luZyBvZiB0aGUgcmVzcGVjdGl2ZQ0KPiA+IEFDUEkgdGFibGVzIGZhaWxlZC4gTW92
ZSB0aGUgdHVybmluZyBvZmYgb2YgaW9tbXVfaW50cmVtYXAgZnJvbSBBTUQNCj4gPiBzcGVjaWZp
YyBjb2RlIGludG8gYWNwaV9pb21tdV9pbml0KCksIGFjY29tcGFueWluZyBpdCBieSBjbGVhcmlu
ZyBvZg0KPiA+IGlvbW11X2VuYWJsZS4NCj4gPg0KPiA+IFRha2UgdGhlIG9wcG9ydHVuaXR5IGFu
ZCBhbHNvIGZ1bGx5IHNraXAgQUNQSSB0YWJsZSBwYXJzaW5nIGxvZ2ljIG9uDQo+ID4gVlQtZCB3
aGVuIGJvdGggImlvbW11PW9mZiIgYW5kICJpb21tdT1uby1pbnRyZW1hcCIgYXJlIGluIGVmZmVj
dA0KPiBhbnl3YXksDQo+ID4gbGlrZSB3YXMgYWxyZWFkeSB0aGUgY2FzZSBmb3IgQU1ELg0KPiA+
DQo+ID4gVGhlIHRhZyBiZWxvdyBvbmx5IHJlZmVyZW5jZXMgdGhlIGNvbW1pdCB1bmNvdmVyaW5n
IGEgcHJlLWV4aXN0aW5nDQo+ID4gYW5vbWFseS4NCj4gPg0KPiA+IEZpeGVzOiBkOGJkODIzMjdi
MGYgKCJBTUQvSU9NTVU6IG9idGFpbiBJVkhEIHR5cGUgdG8gdXNlIGVhcmxpZXIiKQ0KPiA+IFJl
cG9ydGVkLWJ5OiBBbmRyZXcgQ29vcGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPg0KPiA+
IFNpZ25lZC1vZmYtYnk6IEphbiBCZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4gDQo+IE91
Y2gsIGZvcmdvdCB0byBDYyBLZXZpbjsgbm93IGFkZGVkLg0KDQpSZXZpZXdlZC1ieTogS2V2aW4g
VGlhbiA8a2V2aW4udGlhbkBpbnRlbC5jb20+DQoNCj4gDQo+IEphbg0KPiANCj4gPiAtLS0NCj4g
PiBXaGlsZSB0aGUgY2hhbmdlIGhlcmUgZGVhbHMgd2l0aCBhcGljX3gyYXBpY19wcm9iZSgpIGFz
IGNhbGxlZCBmcm9tDQo+ID4geDJhcGljX2JzcF9zZXR1cCgpLCB0aGUgY2hlY2tfeDJhcGljX3By
ZWVuYWJsZWQoKSBwYXRoIGxvb2tzIHRvIGJlDQo+ID4gc2ltaWxhcmx5IGFmZmVjdGVkLiBUaGF0
IGNhbGwgb2NjdXJzIGJlZm9yZSBhY3BpX2Jvb3RfaW5pdCgpLCB3aGljaCBpcw0KPiA+IHdoYXQg
Y2FsbHMgYWNwaV9pb21tdV9pbml0KCkuIFRoZSBvcmRlcmluZyBpbiBzZXR1cC5jIGlzIGluIHBh
cnQNCj4gPiByZWxhdGl2ZWx5IGZyYWdpbGUsIHdoaWNoIGlzIHdoeSBmb3IgdGhlIG1vbWVudCBJ
J20gc3RpbGwgaGVzaXRhbnQgdG8NCj4gPiBtb3ZlIHRoZSBnZW5lcmljX2FwaWNfcHJvYmUoKSBj
YWxsIGRvd24uIFBsdXMgSSBkb24ndCBoYXZlIGVhc3kgYWNjZXNzDQo+ID4gdG8gYSBzdWl0YWJs
ZSBzeXN0ZW0gdG8gdGVzdCB0aGlzIGNhc2UuIFRob3VnaHRzPw0KPiA+IC0tLQ0KPiA+IHYyOiBU
cmVhdCBpb21tdV9lbmFibGUgYW5kIGlvbW11X2ludHJlbWFwIGFzIHNlcGFyYXRlIG9wdGlvbnMu
DQo+ID4NCj4gPiAtLS0gYS94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC9hbWQvcGNpX2FtZF9pb21t
dS5jDQo+ID4gKysrIGIveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvYW1kL3BjaV9hbWRfaW9tbXUu
Yw0KPiA+IEBAIC0xODMsOSArMTgzLDYgQEAgaW50IF9faW5pdCBhY3BpX2l2cnNfaW5pdCh2b2lk
KQ0KPiA+ICB7DQo+ID4gICAgICBpbnQgcmM7DQo+ID4NCj4gPiAtICAgIGlmICggIWlvbW11X2Vu
YWJsZSAmJiAhaW9tbXVfaW50cmVtYXAgKQ0KPiA+IC0gICAgICAgIHJldHVybiAwOw0KPiA+IC0N
Cj4gPiAgICAgIHJjID0gYW1kX2lvbW11X2dldF9zdXBwb3J0ZWRfaXZoZF90eXBlKCk7DQo+ID4g
ICAgICBpZiAoIHJjIDwgMCApDQo+ID4gICAgICAgICAgcmV0dXJuIHJjOw0KPiA+IEBAIC0xOTMs
MTAgKzE5MCw3IEBAIGludCBfX2luaXQgYWNwaV9pdnJzX2luaXQodm9pZCkNCj4gPiAgICAgIGl2
aGRfdHlwZSA9IHJjOw0KPiA+DQo+ID4gICAgICBpZiAoIChhbWRfaW9tbXVfZGV0ZWN0X2FjcGko
KSAhPTApIHx8IChpb21tdV9mb3VuZCgpID09IDApICkNCj4gPiAtICAgIHsNCj4gPiAtICAgICAg
ICBpb21tdV9pbnRyZW1hcCA9IGlvbW11X2ludHJlbWFwX29mZjsNCj4gPiAgICAgICAgICByZXR1
cm4gLUVOT0RFVjsNCj4gPiAtICAgIH0NCj4gPg0KPiA+ICAgICAgaW9tbXVfaW5pdF9vcHMgPSAm
X2lvbW11X2luaXRfb3BzOw0KPiA+DQo+ID4gLS0tIGEveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gv
dnRkL2RtYXIuYw0KPiA+ICsrKyBiL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL3Z0ZC9kbWFyLmMN
Cj4gPiBAQCAtNzc3LDExICs3NzcsNyBAQCBzdGF0aWMgaW50IF9faW5pdCBhY3BpX3BhcnNlX2Rt
YXIoc3RydWN0DQo+ID4gICAgICBkbWFyID0gKHN0cnVjdCBhY3BpX3RhYmxlX2RtYXIgKil0YWJs
ZTsNCj4gPiAgICAgIGRtYXJfZmxhZ3MgPSBkbWFyLT5mbGFnczsNCj4gPg0KPiA+IC0gICAgaWYg
KCAhaW9tbXVfZW5hYmxlICYmICFpb21tdV9pbnRyZW1hcCApDQo+ID4gLSAgICB7DQo+ID4gLSAg
ICAgICAgcmV0ID0gLUVJTlZBTDsNCj4gPiAtICAgICAgICBnb3RvIG91dDsNCj4gPiAtICAgIH0N
Cj4gPiArICAgIEFTU0VSVChpb21tdV9lbmFibGUgfHwgaW9tbXVfaW50cmVtYXApOw0KPiA+DQo+
ID4gICAgICBpZiAoICFkbWFyLT53aWR0aCApDQo+ID4gICAgICB7DQo+ID4gLS0tIGEveGVuL2Ry
aXZlcnMvcGFzc3Rocm91Z2gveDg2L2lvbW11LmMNCj4gPiArKysgYi94ZW4vZHJpdmVycy9wYXNz
dGhyb3VnaC94ODYvaW9tbXUuYw0KPiA+IEBAIC00MSw2ICs0MSwyNCBAQCBlbnVtIGlvbW11X2lu
dHJlbWFwIF9fcmVhZF9tb3N0bHkgaW9tbXVfDQo+ID4gIGJvb2wgX19yZWFkX21vc3RseSBpb21t
dV9pbnRwb3N0Ow0KPiA+ICAjZW5kaWYNCj4gPg0KPiA+ICt2b2lkIF9faW5pdCBhY3BpX2lvbW11
X2luaXQodm9pZCkNCj4gPiArew0KPiA+ICsgICAgaW50IHJldDsNCj4gPiArDQo+ID4gKyAgICBp
ZiAoICFpb21tdV9lbmFibGUgJiYgIWlvbW11X2ludHJlbWFwICkNCj4gPiArICAgICAgICByZXR1
cm47DQo+ID4gKw0KPiA+ICsgICAgcmV0ID0gYWNwaV9kbWFyX2luaXQoKTsNCj4gPiArICAgIGlm
ICggcmV0ID09IC1FTk9ERVYgKQ0KPiA+ICsgICAgICAgIHJldCA9IGFjcGlfaXZyc19pbml0KCk7
DQo+ID4gKw0KPiA+ICsgICAgaWYgKCByZXQgKQ0KPiA+ICsgICAgew0KPiA+ICsgICAgICAgIGlv
bW11X2VuYWJsZSA9IGZhbHNlOw0KPiA+ICsgICAgICAgIGlvbW11X2ludHJlbWFwID0gaW9tbXVf
aW50cmVtYXBfb2ZmOw0KPiA+ICsgICAgfQ0KPiA+ICt9DQo+ID4gKw0KPiA+ICBpbnQgX19pbml0
IGlvbW11X2hhcmR3YXJlX3NldHVwKHZvaWQpDQo+ID4gIHsNCj4gPiAgICAgIHN0cnVjdCBJT19B
UElDX3JvdXRlX2VudHJ5ICoqaW9hcGljX2VudHJpZXMgPSBOVUxMOw0KPiA+IC0tLSBhL3hlbi9p
bmNsdWRlL2FzbS14ODYvYWNwaS5oDQo+ID4gKysrIGIveGVuL2luY2x1ZGUvYXNtLXg4Ni9hY3Bp
LmgNCj4gPiBAQCAtMTQxLDE2ICsxNDEsMTAgQEAgZXh0ZXJuIHUzMiB4ODZfYWNwaWlkX3RvX2Fw
aWNpZFtdOw0KPiA+ICBleHRlcm4gdTMyIHBtdG1yX2lvcG9ydDsNCj4gPiAgZXh0ZXJuIHVuc2ln
bmVkIGludCBwbXRtcl93aWR0aDsNCj4gPg0KPiA+ICt2b2lkIGFjcGlfaW9tbXVfaW5pdCh2b2lk
KTsNCj4gPiAgaW50IGFjcGlfZG1hcl9pbml0KHZvaWQpOw0KPiA+ICBpbnQgYWNwaV9pdnJzX2lu
aXQodm9pZCk7DQo+ID4NCj4gPiAtc3RhdGljIGlubGluZSBpbnQgYWNwaV9pb21tdV9pbml0KHZv
aWQpDQo+ID4gLXsNCj4gPiAtICAgIGludCByZXQgPSBhY3BpX2RtYXJfaW5pdCgpOw0KPiA+IC0N
Cj4gPiAtICAgIHJldHVybiByZXQgPT0gLUVOT0RFViA/IGFjcGlfaXZyc19pbml0KCkgOiByZXQ7
DQo+ID4gLX0NCj4gPiAtDQo+ID4gIHZvaWQgYWNwaV9tbWNmZ19pbml0KHZvaWQpOw0KPiA+DQo+
ID4gIC8qIEluY3JlbWVudGVkIHdoZW5ldmVyIHdlIHRyYW5zaXRpb24gdGhyb3VnaCBTMy4gVmFs
dWUgaXMgMSBkdXJpbmcgYm9vdC4NCj4gKi8NCj4gPg0KPiA+DQoNCg==


From xen-devel-bounces@lists.xenproject.org Fri Oct 29 08:59:16 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Oct 2021 08:59:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.218458.378896 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgNj4-0004Eq-9X; Fri, 29 Oct 2021 08:59:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 218458.378896; Fri, 29 Oct 2021 08:59:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgNj4-0004Ej-5e; Fri, 29 Oct 2021 08:59:02 +0000
Received: by outflank-mailman (input) for mailman id 218458;
 Fri, 29 Oct 2021 08:59:00 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mgNj2-0004Ed-Go
 for xen-devel@lists.xenproject.org; Fri, 29 Oct 2021 08:59:00 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mgNj0-0007I8-NC; Fri, 29 Oct 2021 08:58:58 +0000
Received: from home.octic.net ([81.187.162.82] helo=[10.0.1.193])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mgNj0-000101-H4; Fri, 29 Oct 2021 08:58:58 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=BHsANGG6SqCdq6wkRZfocCX1dJzi1cPW1dMdaS+Xg2E=; b=X0Xe8C/1NAz091vuuffxoE9epI
	tAH2uGrGs7fmt/UnuVpXXhKuQ2mqEC/2J7+RVAIYEJmbaVpN0ifZIQn0Au4AXrajrl2OILuS6dNT1
	wXBATqIhYhmt23vGgAVdVKjd1uxE7s0edqQkdnNdbEH/10PnAUAOvAq6npu9dZ4T2Cv4=;
Message-ID: <2e198e53-e3fb-4ea6-0c44-f326b5e5f5fc@xen.org>
Date: Fri, 29 Oct 2021 09:58:55 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.2.1
Subject: Re: [PATCH for-4.16 v4] gnttab: allow setting max version per-domain
To: Roger Pau Monne <roger.pau@citrix.com>, xen-devel@lists.xenproject.org
Cc: Wei Liu <wl@xen.org>, Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Anthony PERARD <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>,
 Christian Lindig <christian.lindig@citrix.com>, David Scott
 <dave@recoil.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Ian Jackson <iwj@xenproject.org>
References: <20211029075956.1260-1-roger.pau@citrix.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20211029075956.1260-1-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Roger,

On 29/10/2021 08:59, Roger Pau Monne wrote:
> diff --git a/xen/common/grant_table.c b/xen/common/grant_table.c
> index e510395d08..f94f0f272c 100644
> --- a/xen/common/grant_table.c
> +++ b/xen/common/grant_table.c
> @@ -53,6 +53,7 @@ struct grant_table {
>       percpu_rwlock_t       lock;
>       /* Lock protecting the maptrack limit */
>       spinlock_t            maptrack_lock;
> +    unsigned int          max_version;
>       /*
>        * Defaults to v1.  May be changed with GNTTABOP_set_version.  All other
>        * values are invalid.
> @@ -1917,11 +1918,33 @@ active_alloc_failed:
>   }
>   
>   int grant_table_init(struct domain *d, int max_grant_frames,
> -                     int max_maptrack_frames)
> +                     int max_maptrack_frames, unsigned int options)
>   {
>       struct grant_table *gt;
> +    unsigned int max_grant_version = options & XEN_DOMCTL_GRANT_version_mask;
>       int ret = -ENOMEM;
>   
> +    if ( max_grant_version == XEN_DOMCTL_GRANT_version_default )
> +        max_grant_version = opt_gnttab_max_version;
> +    if ( !max_grant_version )
> +    {
> +        dprintk(XENLOG_INFO, "%pd: invalid grant table version 0 requested\n",
> +                d);
> +        return -EINVAL;
> +    }
> +    if ( max_grant_version > opt_gnttab_max_version )
> +    {
> +        dprintk(XENLOG_INFO,
> +                "%pd: requested grant version (%u) greater than supported (%u)\n",
> +                d, max_grant_version, opt_gnttab_max_version);
> +        return -EINVAL;
> +    }
> +    if ( unlikely(max_page >= PFN_DOWN(TB(16))) && is_pv_domain(d) &&

 From my understanding, the limit for the grant table v1 is based on the 
page granularity used and the size of the fields.

So the limit you add is valid for 4KB but not 16KB/64KB. Therefore, I 
think it would be better to use:

'max_page >= (1U << 32)'

Furthermore, it would add a comment explaining where this limit comes from.

Lastly, did you check the compiler wouldn't throw an error on arm32?

> +         max_grant_version < 2 )
> +        dprintk(XENLOG_INFO,
> +                "%pd: host memory above 16Tb and grant table v2 disabled\n",
> +                d);

I would switch this one to a printk().

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Oct 29 09:16:13 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Oct 2021 09:16:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.218465.378907 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgNzX-0006jG-OB; Fri, 29 Oct 2021 09:16:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 218465.378907; Fri, 29 Oct 2021 09:16:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgNzX-0006j9-Kf; Fri, 29 Oct 2021 09:16:03 +0000
Received: by outflank-mailman (input) for mailman id 218465;
 Fri, 29 Oct 2021 09:16:03 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mgNzX-0006j3-9s
 for xen-devel@lists.xenproject.org; Fri, 29 Oct 2021 09:16:03 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mgNzV-0007aQ-LL; Fri, 29 Oct 2021 09:16:01 +0000
Received: from gw1.octic.net ([81.187.162.82] helo=[10.0.1.193])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mgNzV-00029G-Fp; Fri, 29 Oct 2021 09:16:01 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=TPpm9UiiMgGERDzbm3zLqKVBTKH1kmyaayZgZDaL3Go=; b=5L0Uz0rIBhe15hKKnJYFJu/8pi
	pC1eusv8M8mkjvnOKC2haijZj1NUTSY46WdytuWxlTSiH7/vJ/NuNllQBVVfGfMTHrCa35Qabbsrh
	Y9YG1tlsqIaWBJAKkCvDdVvTh3vHlfUV8+tnBPKmlROCg/6pVliQGcnWMKi3ACWE/ZPg=;
Message-ID: <d7e4ae66-f648-e18e-79c8-fae6eb896f00@xen.org>
Date: Fri, 29 Oct 2021 10:15:59 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.2.1
Subject: Re: [PATCH] xen/arm: fix SBDF calculation for vPCI MMIO handlers
To: Ian Jackson <iwj@xenproject.org>
Cc: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 "sstabellini@kernel.org" <sstabellini@kernel.org>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Rahul Singh <rahul.singh@arm.com>
References: <20211027082533.1406015-1-andr2000@gmail.com>
 <cb7e9ef7-476e-93c3-d3c9-9a9ebc61003d@xen.org>
 <d63c6e0b-8aa3-9ba3-893c-5e464638a8db@epam.com>
 <65886734-7333-4469-fcc1-6916db708f13@xen.org>
 <b6bb02b6-6358-b5e0-1b80-7819aadabe10@epam.com>
 <6d8f1061-7aec-2c1a-aaf4-c30440c2797a@xen.org>
 <38da2edd-06a2-63d0-51ad-1284272c8da5@epam.com>
 <a74b52fb-6514-4187-17fe-b63236efa0ce@xen.org>
 <24954.51153.588540.850154@mariner.uk.xensource.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <24954.51153.588540.850154@mariner.uk.xensource.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi Ian,

On 28/10/2021 16:54, Ian Jackson wrote:
> Julien Grall writes ("Re: [PATCH] xen/arm: fix SBDF calculation for vPCI MMIO handlers"):
>> On 28/10/2021 16:27, Oleksandr Andrushchenko wrote:
>>> bridge as private and using info->gpa - GUEST_VPCI_ECAM_BASE...
>>> So, I would stay with simpler
>>>
>>>        if ( bridge )
>>>           {
>>>               sbdf.sbdf = VPCI_ECAM_BDF(info->gpa - bridge->cfg->phys_addr);
>>>               sbdf.seg = bridge->segment;
>>>           }
>>>           else
>>>               sbdf.sbdf = VPCI_ECAM_BDF(info->gpa - GUEST_VPCI_ECAM_BASE);
>>
>> I am fine with that so long this is part of an helper (maybe
>> vpci_sbdf_from_addr()) rather than duplicated.
> 
> There are a number of patches that I'm getting CC'd on related to ARM
> and vpci (according to the Subject).  Are these targeted for 4.16 ?
> Most of them don't have 4.16 Subject tags.

Oleksandr wants this patch to be included for 4.16 but forgot to tag it 
properly.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Oct 29 09:42:06 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Oct 2021 09:42:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.218472.378918 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgOOT-0001cq-QW; Fri, 29 Oct 2021 09:41:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 218472.378918; Fri, 29 Oct 2021 09:41:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgOOT-0001cj-My; Fri, 29 Oct 2021 09:41:49 +0000
Received: by outflank-mailman (input) for mailman id 218472;
 Fri, 29 Oct 2021 09:41:48 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=slsI=PR=citrix.com=roger.pau@srs-us1.protection.inumbo.net>)
 id 1mgOOS-0001ca-BC
 for xen-devel@lists.xenproject.org; Fri, 29 Oct 2021 09:41:48 +0000
Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 6ecb50f8-389c-11ec-8510-12813bfff9fa;
 Fri, 29 Oct 2021 09:41:47 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6ecb50f8-389c-11ec-8510-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1635500507;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=1QdTVul8JI5HeVBMcOd2XK68E5F5bpRRbHmoudlRHac=;
  b=UaIXAC/O/Jr5V4msXUWrUxrzD08u5oKmKH2r54srywU6ZAZtXYScm5Xo
   Df0PpTxnr7IMTQTEB3f73Khwgctss2IA3KPk+gC0RGLWff13s0G8CsYv1
   IjU3oBED4R9KOe0qKsxg4XMKsedFN2Gxobr0KQdnsSkNYmnFP9wnNB+l8
   Q=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: UOq4mzm7rZGYRiX24Y5CoARygo4UBwPB3S/A6JZH9MD2wSfKszBydANv+pu4DGDKpiRM2An9FD
 XDb3rBLBjBYeVhnFqhbC4RBUQ6JGTz6FV93jWtL27jUsVKe2sJdwZ8Y0PtKkqWtX0RwWh8s+Vg
 jLOaXaPVm4a9+BD12IIKsIso4IPkc3FvqTs/Oin0s8xGm+/R3Mv8Gs5fU/iPnV7aklT6zEM7ho
 fTzLT/EEg4ojDS4yyAQCtv+gXKJtN1oy1b+1M9UykSEwifInUR7D1F/n1CGs6dSk4RcUIw77gL
 PiAcCNSKIU235XCmgWGD0mDo
X-SBRS: 5.1
X-MesageID: 56618865
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:45qp+a10Cq9uRSdvsfbD5Y93kn2cJEfYwER7XKvMYLTBsI5bpzBVz
 jYbWzuAOPmJM2DwetF/b46ypB4C7JGHy4VkSAJkpC1hF35El5HIVI+TRqvS04J+DSFhoGZPt
 Zh2hgzodZhsJpPkS5PE3oHJ9RGQ74nRLlbHILOCan8ZqTNMEn970Es7wb9h2+aEvPDia++zk
 YKqyyHgEAfNNw5cagr4PIra9XuDFNyr0N8plgRWicJj5TcypFFMZH4rHomjLmOQf2VhNrXSq
 9Avbl2O1jixEx8FUrtJm1tgG6EAaua60QOm0hK6V0U+6/TrS+NbPqsTbZIhhUlrZzqhu/Apl
 IQdi4aJTl0wJo7uvu9EWQNnDHQrVUFG0OevzXmXtMWSywvNcmf2wuUoB0YzVWEa0r8pWycUr
 6VecW1TKEDY7w616OvTpu1EnMMsIdOtJIoCknph0SvYHbAtRpWrr6DiuIEGhWdg2J0m8fD2Y
 PUVZBFUMjD8ewBFFFM8J7kMw9ysryyqG9FfgA3M/vdmi4TJ9yR92abgGMDYcduLQYNShEnwj
 mDJ5WPiGTkBKceSjzGC9xqEh/DNtTP2XpoIE7+1/eIsh0ecrkQtDxkRWUq+sOOOoEe0UNJCK
 GQZ4iMr66M18SSDVcLhVhe1pHqFuB80WNdKFeA+rgaXxcL88wufQ2QJUDNFQNgnr9MtAywn0
 EeTmNHkDiApt6eaIVqf67OVoDWaKSUTa2gYakcsTwEI/t3iq4EblQ/UQ5BoF6vdpsLxMSH9x
 XaNtidWulkIpZdVjePhpwmB2m/y4MiSJuIo2unJdkaFtl8oNLC/Xovy8ED4z9BLdYyDcUbU6
 RDohPOixOwJCJiMkgmET+MMAKyl6p65DdHMvbJ8N8J+r2r1qhZPaagVuWskfB44ba7obBewO
 BeL0T698qO/K5dDgUVfWIm2F9gxhZbpEdDoR5g4hfIfP8AvKmdrEMxoDHN8PlwBcmBwzsnT2
 r/BKK5A6Er274w9kVJaoM9GiNcWKtgWnz+7eHwC503PPUCiTHCUU6wZF1CFc/o06qiJyC2Mr
 Y0Ca5fUlkgPCbWkCsUyzWL1BQpXRZTcLcuvw/G7i8bZelY2cI3fI6aJqV/eR2CVt/sMzbqZl
 p1MckRZ1ED+lRX6xfaiMRhehEfUdc8n9xoTZHV0VX7xgiRLSdv/vc83KspsFZF6pbML8BKBZ
 6RcEyl2Kq8UEWqvFvV0RcSVkbGOgzzw1FzfYHP/MGhjF3OiLiSQkuLZksLU3HBmJgK8tNcko
 q3m0QXeQJEZQB9lAtqQY/Wqp25dd1BG8A6rd0eXcNRVZmv2941md374gvMtepleIhTf3DqKk
 Q2RBE5A9+XKpoY09vjPhLyF8Nj1Q7cvQBICEjmJ96uyOAnb4nGnnd1KXtGXcG2PT2jz4qijO
 7lYlqmuLP0dkV9WmINgCLI3n7km7t7iquYCnARpFXnGdXqxDbZkLiXU1MVDrPQVlLRYpRG3S
 gSE/dwDYeeFP8bsEVgwIgs5b7vciaFIy2eKtflseRf0/i56+raDQH5+BRjUhXwPNqZxPaMk3
 fwl5Jwc5Tugh0d4Kd2BlC1VqTiBdyRST6U9u5gGK4b3kQ53mEpaaJnRByKqspGCb9JAbhsjL
 jOO3feQgr1dwgzJcmYpFGiL1u1Y3MxctBdPxV4EBlKIhtua2aNngEwPqWw6HlZP0xFK8+NvI
 Ww6ZUR6KJKH8ypsmMUeDXunHBtMBUHB90H8o7fTeLY1k6V8urTxEVAA
IronPort-HdrOrdr: A9a23:8UH4AqCez7TpO+flHehKsceALOsnbusQ8zAXPh9KJyC9I/b2qy
 nxppgmPH/P6Ar4WBkb6La90Y27MA7hHP9OkPMs1NKZPTUO11HYSb2KgbGSpwEIXheOitK1tp
 0QApSWaueAdWSS5PySiGLTfqdCsbv3gJxAx92utEuFJTsaFZ2IhD0JczpzfHcGIzWvUvECZe
 WhD4d81nCdUEVSSv7+KmgOXuDFqdGOvJX6YSQeDxpizAWVlzun5JPzDhDdh34lIn9y6IZn1V
 KAvx3y562lvf3+4hjA11XL55ATvNf60NNMCOGFl8BQADTxjQSDYphnRtS5zX0IidDqzGxvvM
 jHoh8mMcg2w3TNflutqR+o4AXk2CZG0Q6q9XaoxV/Y5eDpTjMzDMRMwahDdAHC1kYmtNZglI
 pWwmOwrfNsfFL9tRW4w+KNewBhl0Kyr3Znu/UUlWZjXYwXb6IUhZAD/XlSDIwLEEvBmc4a+d
 FVfYLhDcttABGnhyizhBgr/DXsZAV9Iv6+eDlDhiTPuAIm2EyQzCMjtboidzk7hdUAoqJ/lp
 b525JT5cZzp/8tHNFA7dg6ML6K40z2MFrx2TGpUB/a/J9uAQO4l3ew2sRy2N2X
X-IronPort-AV: E=Sophos;i="5.87,192,1631592000"; 
   d="scan'208";a="56618865"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=e9XFupziMqMsGo5093H4IRzBJdsr2XA/IjIYPJdU+lcsqcbX7fpZG/m6Tu20XdocdVKJW4sD5eq4S1SzGP7YuL10+6cAS0Rr8z8zwd8ShEHvPi3c2Ld+DPLf8ldM5W77hjBoHyN25WMmVw6GRND4o/kzMzEwEFCu0ejcOZav3L2P1NcaLQQno/HAZGqJS1XKqac2Y8uTCZn09dEQztFYVcnu6onpIK/1XImuWQrb0orE5KCJuSFqTjeJ0pusHbU69Z3VFUu2LQM4YmUbB4VoyuflXa1Pg/5cio1EE+cgigWcwC23Lr/k4EroJMdqNNMMKHTnAgeD8bdnlcnCvQSwKA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=FFjzSNwd3zDvhkZOMQl7twjqykhZdXQ8hSCSuHYErp8=;
 b=UUoILe1B8gZ1Vshob73zfq5dpmxpBBu6iG+krJCq9JLrGIVJ/mIBDb6k1rXFFhbQnu6EO4jlMjqCrX/y8lbWo5LLXyhECiu/hgp+3vKQE+7uXqrAYtl62rxKdFr3yF+bWkdbyCJNhR8UnK9xo+EAg3fIJbMRYQYRP2dAf8dABJQq82mHQ+TuRFfV1S0YQG7dz6aj7McKi+6koFLCTz4BwTyU7NMPAfcAUBGqYTM7/s5c7SB5BQILGiM6ohZd/aXTgVZ4dCYsNO8ZE/JM+5HnE4I44Y/wNE4Tbyvyra3tHPThM0C3+Kys48WB5MogDMUyeUWBRsz0KyMXAb9pSgyv3Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=FFjzSNwd3zDvhkZOMQl7twjqykhZdXQ8hSCSuHYErp8=;
 b=BgzPduSH/iDywZHRWBiE2uFQLHp552uJGng9Gnf4xhnTBR9GzsvetcEQ4Q/PbKvIsk1dD+Wd9PEoSqoXaC+CLkTCXOawcSvXNE1zYf9xLOxpBz8rSDTrHm7R8kXgILFXhvogeCg+ONVMsxX3rUa8Xc5Qm/hzlL7rofa7/8osuAA=
Date: Fri, 29 Oct 2021 11:41:35 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Julien Grall <julien@xen.org>
CC: <xen-devel@lists.xenproject.org>, Wei Liu <wl@xen.org>, Andrew Cooper
	<andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>, "Jan
 Beulich" <jbeulich@suse.com>, Stefano Stabellini <sstabellini@kernel.org>,
	Anthony PERARD <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>,
	Christian Lindig <christian.lindig@citrix.com>, David Scott
	<dave@recoil.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, "Ian
 Jackson" <iwj@xenproject.org>
Subject: Re: [PATCH for-4.16 v4] gnttab: allow setting max version per-domain
Message-ID: <YXvBz4OdpcmVRAGM@Air-de-Roger>
References: <20211029075956.1260-1-roger.pau@citrix.com>
 <2e198e53-e3fb-4ea6-0c44-f326b5e5f5fc@xen.org>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <2e198e53-e3fb-4ea6-0c44-f326b5e5f5fc@xen.org>
X-ClientProxiedBy: MR2P264CA0019.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:500:1::31) To SA0PR03MB5610.namprd03.prod.outlook.com
 (2603:10b6:806:b2::9)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 457ce1f9-7f34-4e33-f454-08d99ac05037
X-MS-TrafficTypeDiagnostic: SN6PR03MB4493:
X-Microsoft-Antispam-PRVS: <SN6PR03MB44936C298AC58C3C5D9E86368F879@SN6PR03MB4493.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:4714;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: XK1dHCkj0xDHMe8Qsi3PT2/obyg3nFHiZK1gNLIXcFbV/NBxsYgjDoxsjOpN84bFu2vAKqpmu4VKrY/WZ/iVf5KLuFNGlQBgjBUkG1CpcBAE/4C1/pfMghAD9xDhhk1vlvYJ2UXJKNommreFX8aVOPelpwHNfKBu1PVMFm7AWEEkTlcTGYbDR6M/EqcCkJ5k5smYmepebl21TkgopDOiLkhMG3P8Yty/bgkJpg4FthxIusofk27IJ2YoNVAqeaKLK6XrPf3xeZxKOx+ZCWz6kjZ2kiHW9LksCXlfR15k1e9mcQkrH0SiZC/N6Cp/6Zq2+4mNnyqAOLElTCDY08g04q99A2qUFj3k1lzgocOhgfxiKn/O4cxJH5+L7HH1YUSHMLVIDh8QwG2PMCHkqMtjEu6eUbwj3Oo5TCw7OBbBOXPCIlcxM3UHMaAGGLNdtw3MTdvp00uWWe7uFlpEC1qz6mXXJEWs1MQd53UFuyHSNsbnHlILK+2DMozgwEDnIsHCVanZVhxvc8e6im5eu9TPi+UwI+fKg1BjvsFgcIYktN6/dfgwNw/Wei4OHi9pwZfnokoTLFBzDN4jDXzIiO9ODWKRFAhVMnf04V3E1NBULJyi53/FwXHXmxqUF4nKM0+PRrWdLj/pqly6jgRqq5RO0A==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA0PR03MB5610.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(7916004)(4636009)(366004)(8936002)(2906002)(186003)(8676002)(316002)(33716001)(82960400001)(54906003)(508600001)(83380400001)(956004)(26005)(4326008)(86362001)(66476007)(66556008)(5660300002)(6916009)(6496006)(85182001)(6666004)(6486002)(66946007)(38100700002)(9686003)(53546011);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YVFoNHRIakNsTWh5ZTdMSkVPWTZzTHU3V0x1TXkzeGQ3QWI5aXFLSUVSNXBz?=
 =?utf-8?B?eDJrdU5tSjIvMFowRm1oYi8zUFBndlpFNnhBbzRLc2dwRTZxR0k4aUFHQUF5?=
 =?utf-8?B?ZEVMbzNXeWVrbjRzcGZ0MlRqblV2WVNDbzdObktZQ0Nld0FNa1UrWUx6Tm1C?=
 =?utf-8?B?bnUwNUtEQVp3aklEMllFQVRWMkcwSFdVUkhCY2thL0xWMUNyU2hQbTNYYVRh?=
 =?utf-8?B?aVJBbmxBVGw2aDcxVnVtR252MnNFTzBQcGRSa0xmeDFsdEdLMHlKdWxEczcz?=
 =?utf-8?B?UkNRbnRZNk8rQ2FsRE1Lc0wxQkpUVXBzZkdackpxZWZNSFdlN3g0REtPeTN3?=
 =?utf-8?B?dkVqcEpBOGZjYUlsczdjU0tzNVd1REplNk5qeEpjdVc2SGJCT2J6TXdzMkJa?=
 =?utf-8?B?T0RCNTJaWUlDcDA1WlVncVNBaEh6STZkMTMyWHRPVExyejB3a1QzeXZTTGpE?=
 =?utf-8?B?R0lLUWtKVUtLV3hFL0JodUswN01seStIUFRZMmRsZG4wVit0enlLbWpwY0c4?=
 =?utf-8?B?TUEzbDZ5UHA5UnJtMEdYRm0wR0JLV1F2Ynp5ejBWUTd3ajRZYmQrTmZ2d1Q2?=
 =?utf-8?B?Q0xwdENqUTJRdFNiVlIyQXFTQUVTcDF3a081UjFodjRoMVpKWWhwZ3lhVXFG?=
 =?utf-8?B?MVRJbjg4Zm1nTmY0RHBrSkJYWXhFQ2ZoTTkvVFFKMXdkeVA4NW5XMU1meGlm?=
 =?utf-8?B?VnFnWm5acitvZXdyV1JqRTVlRWVtU0REWUtlYWVWRjJGUERLS1JhSWZ0TFp2?=
 =?utf-8?B?b1JyZ01oOTdta3ZreDFCZlVxNHVEWENWTGFRdDA4L08xYk0zTHZIQ0ZvR29q?=
 =?utf-8?B?WjhPRlk4dTdCY3F0UFg1WTM5Ykx4V1JULy9jaDJXTjhTeFhJU3dMZWRnSTZR?=
 =?utf-8?B?dWxBZ05ycGhhYmFReEJsbTBzN2NnUi9nQlBBMWZTYTh4Ny8xSUxTNjJmTHZn?=
 =?utf-8?B?SytyU285cnU0UEZnVTJqZnptNVZ3cnFyalRENEVad0pxSEpqMVBIcTlkUjgy?=
 =?utf-8?B?RVIvK29TMjRkMGpKN3hGZzlxVWw3OEJPL09iT2NnVXJweVpLSmEyYklSdnoz?=
 =?utf-8?B?SkxuanhMZ21qM1hidUM4YXpkYW8zWjFnbFZxR2pMbTM4R3JFdFZ5L05EekVL?=
 =?utf-8?B?OFY4M1gzQUpBR1BEWDU4OWF3NmlCeGo4UFNFMzVmU2cvdWNhNHE4Y1FieVpQ?=
 =?utf-8?B?MFVPN25UVGpXQUhBNXBYT1J4RElNUWxpREMzdWgvTUFyRHlYdXp5UDdwQldv?=
 =?utf-8?B?ZnFsZVdBWXY3S0l1Sk5VVUE3YmpGa3o5OVE5bEZ6RUcwNXNGa0Q5anZsZG4w?=
 =?utf-8?B?dm9mK2dBdXowelZHNnVwclF5bjF2V3M3dDhGdElkdUVPclJVNUtSaTcyY3Yw?=
 =?utf-8?B?aE9Ba3U5RXFtaU1VNGh6R2V4M2REcU00QW41VFF3T0ZadEh0UTJPWWJ4aHZF?=
 =?utf-8?B?bTFVcWRnWjZzdmpnV0kyT0JpandWaWloeXdmMDR6TTNteHFmZ0ozZS9zdndw?=
 =?utf-8?B?bVpoNmxIQnhUMGVpV21UZU13cFNYY2VZbVNjNkFoS0pSS3ZPaHRiNy8rTW5M?=
 =?utf-8?B?aVI2VGF3RVpQcUtFS05maEcvRGwzbDN3bEJTZk1JWGljRDVJbllSZmpNR0VT?=
 =?utf-8?B?TUtFRUZoUFRSdE9IdVNYc0RCcXArRTRUb21nM21FWW9nem1HZFdzbk5KSElw?=
 =?utf-8?B?OHRxRk84NmxMUTR1VXNWaXZmZkVGOWFDSlBGV2M5NkY2K25OK2xtSTdaek1v?=
 =?utf-8?B?VGdFeklXQW5zWElMRWl0OGVjbGs5RzNKRDlWK3JCSnREK3ZCYUlQR2Fqalh4?=
 =?utf-8?B?a2RGMUNISS8zZVdpWHlqT3JYdXpkSTdPY3FGejRwd2RYUGhhQnlMYnVUeldr?=
 =?utf-8?B?RUlMTTZyY1A3WUxwTEJLYVlDS1dhWUZWTWkxNjFpY2xpYnhFQ3hGc0QwZkNy?=
 =?utf-8?B?cDEyeG9wM2dTMzZUTVpuWEJtTmxnWVVxeGQwNWw4Wk5hekpDYVlGRXBhMDlT?=
 =?utf-8?B?cy9SVFFWYnQ2VStFOGx0OWZLRERBREFwRXZYUVdjanFCRjhhV05RdDhCZm5x?=
 =?utf-8?B?RzZIS2s3Qkt5VzFXYStPbFcyM3JtZGo5UCs5cVVlN2llc1VEcmlyNFEwUTdZ?=
 =?utf-8?B?a2Z0Wit1bGl4bWNZM0RLZ2dBazBCamUzWWhJVTkybnZLL2lScTEwSDlmU1BS?=
 =?utf-8?Q?MzX3/n72ya8jkNC9KGbJyqI=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 457ce1f9-7f34-4e33-f454-08d99ac05037
X-MS-Exchange-CrossTenant-AuthSource: SA0PR03MB5610.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Oct 2021 09:41:42.3054
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: hJ3OZViV1Zhl+7otgYwRjk4drs7Ug7iZaC0R2WwtGesCdqfKH+PbFwF/9QhC+C07EgzXGpo50TlWpl6Fg1EZUQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR03MB4493
X-OriginatorOrg: citrix.com

On Fri, Oct 29, 2021 at 09:58:55AM +0100, Julien Grall wrote:
> Hi Roger,
> 
> On 29/10/2021 08:59, Roger Pau Monne wrote:
> > diff --git a/xen/common/grant_table.c b/xen/common/grant_table.c
> > index e510395d08..f94f0f272c 100644
> > --- a/xen/common/grant_table.c
> > +++ b/xen/common/grant_table.c
> > @@ -53,6 +53,7 @@ struct grant_table {
> >       percpu_rwlock_t       lock;
> >       /* Lock protecting the maptrack limit */
> >       spinlock_t            maptrack_lock;
> > +    unsigned int          max_version;
> >       /*
> >        * Defaults to v1.  May be changed with GNTTABOP_set_version.  All other
> >        * values are invalid.
> > @@ -1917,11 +1918,33 @@ active_alloc_failed:
> >   }
> >   int grant_table_init(struct domain *d, int max_grant_frames,
> > -                     int max_maptrack_frames)
> > +                     int max_maptrack_frames, unsigned int options)
> >   {
> >       struct grant_table *gt;
> > +    unsigned int max_grant_version = options & XEN_DOMCTL_GRANT_version_mask;
> >       int ret = -ENOMEM;
> > +    if ( max_grant_version == XEN_DOMCTL_GRANT_version_default )
> > +        max_grant_version = opt_gnttab_max_version;
> > +    if ( !max_grant_version )
> > +    {
> > +        dprintk(XENLOG_INFO, "%pd: invalid grant table version 0 requested\n",
> > +                d);
> > +        return -EINVAL;
> > +    }
> > +    if ( max_grant_version > opt_gnttab_max_version )
> > +    {
> > +        dprintk(XENLOG_INFO,
> > +                "%pd: requested grant version (%u) greater than supported (%u)\n",
> > +                d, max_grant_version, opt_gnttab_max_version);
> > +        return -EINVAL;
> > +    }
> > +    if ( unlikely(max_page >= PFN_DOWN(TB(16))) && is_pv_domain(d) &&
> 
> From my understanding, the limit for the grant table v1 is based on the page
> granularity used and the size of the fields.
> 
> So the limit you add is valid for 4KB but not 16KB/64KB. Therefore, I think
> it would be better to use:
> 
> 'max_page >= (1U << 32)'

I'm slightly confused. Isn't Xen always using a 4KB page granularity,
and that also applies to the grant table entries?

I don't think it's possible to use correctly use a 16KB or 64KB page
as an entry for the grant table, as Xen assumes those to always be 4KB
based.

> Furthermore, it would add a comment explaining where this limit comes from.
> 
> Lastly, did you check the compiler wouldn't throw an error on arm32?

I've tested a previous version (v2), but not this one. I assume it
doesn't build?

I've pushed it to gitlab and will adjust as needed.

> > +         max_grant_version < 2 )
> > +        dprintk(XENLOG_INFO,
> > +                "%pd: host memory above 16Tb and grant table v2 disabled\n",
> > +                d);
> 
> I would switch this one to a printk().

That's fine, will adjust unless someone has objections.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Fri Oct 29 09:57:40 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Oct 2021 09:57:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.218479.378928 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgOdZ-0003Jm-4f; Fri, 29 Oct 2021 09:57:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 218479.378928; Fri, 29 Oct 2021 09:57:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgOdZ-0003Jf-1k; Fri, 29 Oct 2021 09:57:25 +0000
Received: by outflank-mailman (input) for mailman id 218479;
 Fri, 29 Oct 2021 09:57:24 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=qfCy=PR=invisiblethingslab.com=marmarek@srs-us1.protection.inumbo.net>)
 id 1mgOdX-0003JZ-Vw
 for xen-devel@lists.xenproject.org; Fri, 29 Oct 2021 09:57:24 +0000
Received: from out3-smtp.messagingengine.com (unknown [66.111.4.27])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 9c8271aa-389e-11ec-8510-12813bfff9fa;
 Fri, 29 Oct 2021 09:57:22 +0000 (UTC)
Received: from compute4.internal (compute4.nyi.internal [10.202.2.44])
 by mailout.nyi.internal (Postfix) with ESMTP id 3B5E95C0220;
 Fri, 29 Oct 2021 05:57:22 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute4.internal (MEProxy); Fri, 29 Oct 2021 05:57:22 -0400
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri,
 29 Oct 2021 05:57:20 -0400 (EDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9c8271aa-389e-11ec-8510-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:content-type:date:from:in-reply-to
	:message-id:mime-version:references:subject:to:x-me-proxy
	:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=3/Egfh
	4X+ZdPXzTj4EaqMgbhEWAl0zPu3cQnawCwVO4=; b=kCKWYV9uq+QIfP4Qg3wcFm
	fELenkkPgPvNOALaIoR2v1v9PE2h0vWPGYl/PKkJu8sdlHc9LXSFTc3ZR2gV/KIk
	BruKbAMKQ5qO+TXVGFLdA+PnyXT87Xk3/GGeHjbwzJ09Aqc1yThs4ZuQaEwDeBai
	Iod1ItadzdcoI+cpV5gxJCVOJjIM9mog4bzakYfkY8UjQ3FZ67hBKL7hqJhS5meS
	qqmUx1SyowR5LF1LOXwwxPFsr+lP2/KCO8q0A16PIRtWHjhtT1yjE1eBPyaRtT8P
	u12vnRprhMeV8RiMpylj5uF7FrVMFApaYUDtNcGbPmK+N2O+0Gm30J2N73YNaExg
	==
X-ME-Sender: <xms:gsV7YarWpM9MY6o510lBTf4K0-d5szn528oVZFE1MFdPagX9xpjUgA>
    <xme:gsV7YYo-uhoBOjjBdNY6S-WzLoZRjUtxmI4DQ0dLgCekOQAqDYU7EgPxJ7Hmginhh
    016Kv2pA5kMsw>
X-ME-Received: <xmr:gsV7YfP0FACiTRy27rcEo7gqjY0Zu4SRBq-cMnsa6wEAmlJTwUwe9AymhpO6HSxtHatB2SC3DuCLFVH2Ho1STBMWekRQlqho>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrvdeghedgudelucetufdoteggodetrfdotf
    fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
    uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
    cujfgurhepfffhvffukfhfgggtuggjsehgtderredttdejnecuhfhrohhmpeforghrvghk
    ucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesihhnvh
    hishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpeehvedv
    ueevheekhefhvefggffgvedugeetuefgleeivdehgfeuieeugfetteeiffenucffohhmrg
    hinhepkhgvrhhnvghlrdhorhhgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghm
    pehmrghilhhfrhhomhepmhgrrhhmrghrvghksehinhhvihhsihgslhgvthhhihhnghhslh
    grsgdrtghomh
X-ME-Proxy: <xmx:gsV7YZ4J5qvDuhzPuhwl4RnOcRfeeSyS43IBvoGw7Jk4pfB3ZjKLbQ>
    <xmx:gsV7YZ7QgfuWVZN4d_b2jxUZQBEiMvHvf3SaWX9ahoyB17vZ1h-2Aw>
    <xmx:gsV7YZhjQo79qUec-ty7DQuRGDTPoG069hAEfwx80kQWrHEgWTUx7A>
    <xmx:gsV7YTmkCkUjV_Pr-NigJ3MjXbO85CG6RQAHYymRQnJCMp1z_KjnCw>
Date: Fri, 29 Oct 2021 11:57:17 +0200
From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
To: Juergen Gross <jgross@suse.com>
Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>, stable@vger.kernel.org
Subject: Re: [PATCH] xen/balloon: add late_initcall_sync() for initial
 ballooning done
Message-ID: <YXvFfRKuD574hulr@mail-itl>
References: <20211028105952.10011-1-jgross@suse.com>
 <YXsFO2TMRiJTQM2q@mail-itl>
 <27e7619a-a797-5c46-9f9f-015ab488e31c@suse.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="qlvPDcy0Ybnk1Q+S"
Content-Disposition: inline
In-Reply-To: <27e7619a-a797-5c46-9f9f-015ab488e31c@suse.com>


--qlvPDcy0Ybnk1Q+S
Content-Type: text/plain; protected-headers=v1; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Date: Fri, 29 Oct 2021 11:57:17 +0200
From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
To: Juergen Gross <jgross@suse.com>
Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>, stable@vger.kernel.org
Subject: Re: [PATCH] xen/balloon: add late_initcall_sync() for initial
 ballooning done

On Fri, Oct 29, 2021 at 06:48:44AM +0200, Juergen Gross wrote:
> On 28.10.21 22:16, Marek Marczykowski-G=C3=B3recki wrote:
> > On Thu, Oct 28, 2021 at 12:59:52PM +0200, Juergen Gross wrote:
> > > When running as PVH or HVM guest with actual memory < max memory the
> > > hypervisor is using "populate on demand" in order to allow the guest
> > > to balloon down from its maximum memory size. For this to work
> > > correctly the guest must not touch more memory pages than its target
> > > memory size as otherwise the PoD cache will be exhausted and the guest
> > > is crashed as a result of that.
> > >=20
> > > In extreme cases ballooning down might not be finished today before
> > > the init process is started, which can consume lots of memory.
> > >=20
> > > In order to avoid random boot crashes in such cases, add a late init
> > > call to wait for ballooning down having finished for PVH/HVM guests.
> > >=20
> > > Cc: <stable@vger.kernel.org>
> > > Reported-by: Marek Marczykowski-G=C3=B3recki <marmarek@invisiblething=
slab.com>
> > > Signed-off-by: Juergen Gross <jgross@suse.com>
> >=20
> > It may happen that initial balloon down fails (state=3D=3DBP_ECANCELED)=
=2E In
> > that case, it waits indefinitely. I think it should rather report a
> > failure (and panic? it's similar to OOM before PID 1 starts, so rather
> > hard to recover), instead of hanging.
>=20
> Okay, I can add something like that. I'm thinking of issuing a failure
> message in case of credit not having changed for 1 minute and panic()
> after two more minutes. Is this fine?

Isn't it better to get a state from balloon_thread()? If the balloon
fails it won't really try anymore (until 3600s timeout), so waiting in
that state doesn't help. And reporting the failure earlier may be more
user friendly. Or maybe there is something that could wakeup the thread
earlier, that I don't see? Hot plugging more RAM is rather unlikely at
this stage...
See my patch at [1], although rather hacky (and likely - racy).

[1] https://lore.kernel.org/xen-devel/YXFxKC4shCATB913@mail-itl/

--=20
Best Regards,
Marek Marczykowski-G=C3=B3recki
Invisible Things Lab

--qlvPDcy0Ybnk1Q+S
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmF7xX0ACgkQ24/THMrX
1yxoEgf+LmB4JafdHInJTr2vAFi4q6NgWgkLEQ5VU9RFsyxR6E1Y2gFfyQClL8T5
pbWpH16scP/dnR74YMV9WfZKL5Zvza9vFTM2okm/rKjazkuPacho2xrxIJ9EPQNz
xL2XQFqi2Ma6j8RN0CePJtunyCIThttE2FFKl6BGAKCPCJKqAmMPxXnSjajQNc+6
ZKdubeSuvvlm4PKl89eyVyUrNC5QobxUlXCc7IaVRV1PEHFYrxH4pEOtsEAVfjA5
VIFzSmygyP65qWhRvLvCWHFZ8F740EypyzdNoBuhdpEfc3/O/siyFVsd1dlIdmcV
Dy823HP72V5ImM2iXpgSYCOgUjiVrQ==
=tifY
-----END PGP SIGNATURE-----

--qlvPDcy0Ybnk1Q+S--


From xen-devel-bounces@lists.xenproject.org Fri Oct 29 10:01:49 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Oct 2021 10:01:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.218487.378940 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgOhb-0004w0-P4; Fri, 29 Oct 2021 10:01:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 218487.378940; Fri, 29 Oct 2021 10:01:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgOhb-0004vt-M8; Fri, 29 Oct 2021 10:01:35 +0000
Received: by outflank-mailman (input) for mailman id 218487;
 Fri, 29 Oct 2021 10:01:33 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mgOhZ-0004vX-Su
 for xen-devel@lists.xenproject.org; Fri, 29 Oct 2021 10:01:33 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mgOhY-0008U6-JD; Fri, 29 Oct 2021 10:01:32 +0000
Received: from [54.239.6.188] (helo=[192.168.17.171])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mgOhY-0005os-CO; Fri, 29 Oct 2021 10:01:32 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=TjDhzCb7m7bs4AOHf2O6U9BtgJKYEz5RF/iAPK57lB0=; b=b3GmI4GhrDOKzs3rcmpt3yABsr
	p/xXGhtqsK8E90kGyMTQGoSv1KtBcog+C1mOxWr2cKKmFTrQWbue880fJRhCMYwyJUNpj5X8BSHvH
	r6lGURzvH5zzTABLT/BBiiWuqF1EQW4kxrMTDi17wTX+/VpgTqOAqDeVmqe4v0HUaE/U=;
Message-ID: <09995bd2-0924-74bf-508f-5692b3250532@xen.org>
Date: Fri, 29 Oct 2021 11:01:29 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.2.1
Subject: Re: [PATCH for-4.16 v4] gnttab: allow setting max version per-domain
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
Cc: xen-devel@lists.xenproject.org, Wei Liu <wl@xen.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Anthony PERARD <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>,
 Christian Lindig <christian.lindig@citrix.com>, David Scott
 <dave@recoil.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Ian Jackson <iwj@xenproject.org>
References: <20211029075956.1260-1-roger.pau@citrix.com>
 <2e198e53-e3fb-4ea6-0c44-f326b5e5f5fc@xen.org>
 <YXvBz4OdpcmVRAGM@Air-de-Roger>
From: Julien Grall <julien@xen.org>
In-Reply-To: <YXvBz4OdpcmVRAGM@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit



On 29/10/2021 10:41, Roger Pau Monné wrote:
> On Fri, Oct 29, 2021 at 09:58:55AM +0100, Julien Grall wrote:
>> Hi Roger,
Hi Roger,

>> On 29/10/2021 08:59, Roger Pau Monne wrote:
>>> diff --git a/xen/common/grant_table.c b/xen/common/grant_table.c
>>> index e510395d08..f94f0f272c 100644
>>> --- a/xen/common/grant_table.c
>>> +++ b/xen/common/grant_table.c
>>> @@ -53,6 +53,7 @@ struct grant_table {
>>>        percpu_rwlock_t       lock;
>>>        /* Lock protecting the maptrack limit */
>>>        spinlock_t            maptrack_lock;
>>> +    unsigned int          max_version;
>>>        /*
>>>         * Defaults to v1.  May be changed with GNTTABOP_set_version.  All other
>>>         * values are invalid.
>>> @@ -1917,11 +1918,33 @@ active_alloc_failed:
>>>    }
>>>    int grant_table_init(struct domain *d, int max_grant_frames,
>>> -                     int max_maptrack_frames)
>>> +                     int max_maptrack_frames, unsigned int options)
>>>    {
>>>        struct grant_table *gt;
>>> +    unsigned int max_grant_version = options & XEN_DOMCTL_GRANT_version_mask;
>>>        int ret = -ENOMEM;
>>> +    if ( max_grant_version == XEN_DOMCTL_GRANT_version_default )
>>> +        max_grant_version = opt_gnttab_max_version;
>>> +    if ( !max_grant_version )
>>> +    {
>>> +        dprintk(XENLOG_INFO, "%pd: invalid grant table version 0 requested\n",
>>> +                d);
>>> +        return -EINVAL;
>>> +    }
>>> +    if ( max_grant_version > opt_gnttab_max_version )
>>> +    {
>>> +        dprintk(XENLOG_INFO,
>>> +                "%pd: requested grant version (%u) greater than supported (%u)\n",
>>> +                d, max_grant_version, opt_gnttab_max_version);
>>> +        return -EINVAL;
>>> +    }
>>> +    if ( unlikely(max_page >= PFN_DOWN(TB(16))) && is_pv_domain(d) &&
>>
>>  From my understanding, the limit for the grant table v1 is based on the page
>> granularity used and the size of the fields.
>>
>> So the limit you add is valid for 4KB but not 16KB/64KB. Therefore, I think
>> it would be better to use:
>>
>> 'max_page >= (1U << 32)'
> 
> I'm slightly confused. Isn't Xen always using a 4KB page granularity,

Yes. We only support 4KB today. But most of Xen is agnostic to the page 
granularity. I have actually started to look to allow 64KB/16KB page 
granularity for Xen on Arm in my spare time.

> and that also applies to the grant table entries?
The page granularity for the hypercall interface is whatever the page 
granularity Xen is using. So...

> 
> I don't think it's possible to use correctly use a 16KB or 64KB page
> as an entry for the grant table, as Xen assumes those to always be 4KB
> based.

... if you build Xen with 16KB, then the grant table entries will be 
using 16KB.

So I would like to avoid making the assumption that we are always using 
4KB. That said, the worse that can happen is a spurious message. So this 
is more to get an accurate check.

> 
>> Furthermore, it would add a comment explaining where this limit comes from.
>>
>> Lastly, did you check the compiler wouldn't throw an error on arm32?
> 
> I've tested a previous version (v2), but not this one. I assume it
> doesn't build?

I haven't tried. But I remember in the past seen report for always 
true/false check. Maybe that was just on coverity?

> 
> I've pushed it to gitlab and will adjust as needed.

Thanks!

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Oct 29 10:22:41 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Oct 2021 10:22:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.218494.378951 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgP1j-0007RR-Gv; Fri, 29 Oct 2021 10:22:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 218494.378951; Fri, 29 Oct 2021 10:22:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgP1j-0007RK-Df; Fri, 29 Oct 2021 10:22:23 +0000
Received: by outflank-mailman (input) for mailman id 218494;
 Fri, 29 Oct 2021 10:22:22 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=3izX=PR=suse.com=jgross@srs-us1.protection.inumbo.net>)
 id 1mgP1i-0007RE-8Q
 for xen-devel@lists.xenproject.org; Fri, 29 Oct 2021 10:22:22 +0000
Received: from smtp-out2.suse.de (unknown [195.135.220.29])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id bb13493d-6955-4321-a528-39b40296a7f8;
 Fri, 29 Oct 2021 10:22:21 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 32F851FD53;
 Fri, 29 Oct 2021 10:22:20 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 8750F13BBE;
 Fri, 29 Oct 2021 10:22:19 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id mfQIH1vLe2FKRwAAMHmgww
 (envelope-from <jgross@suse.com>); Fri, 29 Oct 2021 10:22:19 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: bb13493d-6955-4321-a528-39b40296a7f8
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1635502940; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=NpBs+BlaJGVaaBIJS28nFtrD0GaRfryOLIVX4pU4cWE=;
	b=nP4l/aojAMAp+vKxcHtgt1X3MJL+nm8KRXhHTN0SYGe2t2Qm7RcEk2PVs5RVcesGeHAtV9
	NlLOwJ+plnTLeNYHn/yme6yyGAAQ5DsnhsZLcF1Hf7MrNMkywJxyYCv29GUGJWY3ur8i8/
	GMO2kcXmL/R7GqLGo5+UurDJZrYcNpg=
To: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?=
 <marmarek@invisiblethingslab.com>
Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org,
 Boris Ostrovsky <boris.ostrovsky@oracle.com>,
 Stefano Stabellini <sstabellini@kernel.org>, stable@vger.kernel.org
References: <20211028105952.10011-1-jgross@suse.com>
 <YXsFO2TMRiJTQM2q@mail-itl> <27e7619a-a797-5c46-9f9f-015ab488e31c@suse.com>
 <YXvFfRKuD574hulr@mail-itl>
From: Juergen Gross <jgross@suse.com>
Subject: Re: [PATCH] xen/balloon: add late_initcall_sync() for initial
 ballooning done
Message-ID: <63a474ea-9e5d-4515-ca99-1d56f52b7673@suse.com>
Date: Fri, 29 Oct 2021 12:22:18 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <YXvFfRKuD574hulr@mail-itl>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="Fdc7FltF5YGeKV3gR9EUKXH5xt7a8jSp8"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--Fdc7FltF5YGeKV3gR9EUKXH5xt7a8jSp8
Content-Type: multipart/mixed; boundary="joHFG26fOySkAysnHotfMlksprVfq3bLQ";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?=
 <marmarek@invisiblethingslab.com>
Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org,
 Boris Ostrovsky <boris.ostrovsky@oracle.com>,
 Stefano Stabellini <sstabellini@kernel.org>, stable@vger.kernel.org
Message-ID: <63a474ea-9e5d-4515-ca99-1d56f52b7673@suse.com>
Subject: Re: [PATCH] xen/balloon: add late_initcall_sync() for initial
 ballooning done
References: <20211028105952.10011-1-jgross@suse.com>
 <YXsFO2TMRiJTQM2q@mail-itl> <27e7619a-a797-5c46-9f9f-015ab488e31c@suse.com>
 <YXvFfRKuD574hulr@mail-itl>
In-Reply-To: <YXvFfRKuD574hulr@mail-itl>

--joHFG26fOySkAysnHotfMlksprVfq3bLQ
Content-Type: multipart/mixed;
 boundary="------------67EF389DDB8B8DBA8228B295"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------67EF389DDB8B8DBA8228B295
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 29.10.21 11:57, Marek Marczykowski-G=C3=B3recki wrote:
> On Fri, Oct 29, 2021 at 06:48:44AM +0200, Juergen Gross wrote:
>> On 28.10.21 22:16, Marek Marczykowski-G=C3=B3recki wrote:
>>> On Thu, Oct 28, 2021 at 12:59:52PM +0200, Juergen Gross wrote:
>>>> When running as PVH or HVM guest with actual memory < max memory the=

>>>> hypervisor is using "populate on demand" in order to allow the guest=

>>>> to balloon down from its maximum memory size. For this to work
>>>> correctly the guest must not touch more memory pages than its target=

>>>> memory size as otherwise the PoD cache will be exhausted and the gue=
st
>>>> is crashed as a result of that.
>>>>
>>>> In extreme cases ballooning down might not be finished today before
>>>> the init process is started, which can consume lots of memory.
>>>>
>>>> In order to avoid random boot crashes in such cases, add a late init=

>>>> call to wait for ballooning down having finished for PVH/HVM guests.=

>>>>
>>>> Cc: <stable@vger.kernel.org>
>>>> Reported-by: Marek Marczykowski-G=C3=B3recki <marmarek@invisiblethin=
gslab.com>
>>>> Signed-off-by: Juergen Gross <jgross@suse.com>
>>>
>>> It may happen that initial balloon down fails (state=3D=3DBP_ECANCELE=
D). In
>>> that case, it waits indefinitely. I think it should rather report a
>>> failure (and panic? it's similar to OOM before PID 1 starts, so rathe=
r
>>> hard to recover), instead of hanging.
>>
>> Okay, I can add something like that. I'm thinking of issuing a failure=

>> message in case of credit not having changed for 1 minute and panic()
>> after two more minutes. Is this fine?
>=20
> Isn't it better to get a state from balloon_thread()? If the balloon
> fails it won't really try anymore (until 3600s timeout), so waiting in
> that state doesn't help. And reporting the failure earlier may be more
> user friendly. Or maybe there is something that could wakeup the thread=

> earlier, that I don't see? Hot plugging more RAM is rather unlikely at
> this stage...

Waking up the thread would be easy, but probably that wouldn't really
help.

The idea was that maybe a Xen admin would see the guest not booting up
further and then adding some more memory to the guest (this should wake
up the balloon thread again).

I agree that stopping to wait for ballooning to finish in case of it
having failed is probably a sensible thing to do. Additionally I could
add a boot parameter to control the timeout after the fail message and
the panic().

What do you think?


Juergen


Juergen

--------------67EF389DDB8B8DBA8228B295
Content-Type: application/pgp-keys;
 name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Transfer-Encoding: quoted-printable
Content-Description: OpenPGP public key
Content-Disposition: attachment;
 filename="OpenPGP_0xB0DE9DD628BF132F.asc"

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy=
cWx
w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O=
f8Z
d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y=
9bf
IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq=
G7/
377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR=
3Jv
c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA=
QIe
AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT=
hpw
dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0=
MbD
1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv=
oPH
Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v=
5QL
+qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ=
2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC=
QoL
BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr=
Wf0
teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC=
/nu
AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh=
ITT
d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm=
XBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz=
80h
SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC=
AcD
AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn=
FOX
gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1=
jnD
kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0=
N51
N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l=
otu
fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1=
tqS
EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA=
hsD
BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3=
g3O
ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5=
dM7
wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5=
D+j
LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm=
V2x
AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N=
Eaw
QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW=
nHI
s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR=
wgn
BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV=
bVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk=
pEd
IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA=
QAB
wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw=
Tbe
8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1=
vJz
Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8=
VGi
wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW=
svi
uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX=
zXs
ZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------67EF389DDB8B8DBA8228B295--

--joHFG26fOySkAysnHotfMlksprVfq3bLQ--

--Fdc7FltF5YGeKV3gR9EUKXH5xt7a8jSp8
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmF7y1sFAwAAAAAACgkQsN6d1ii/Ey+l
ugf/a3IW0loPuVfAGCVx81M8C6h2H4x7prD9NQDY+krOnWqeCgP9nV7xQApbU37EpG8y2ZVoNMLa
PMCd2Sv338o7J5q1Z3NIvJ5F7vB1dHVs1vGOMeuwwFyAP21gNrldaq7y5oVHwzk20sWAfdIZ36qE
BFzFi1fccui0FsJIP2m40XH+SqI6Zl89BZQgzzavYH0FQ9NleLE3vdRoWQmp9GJZsEw4kaBdprZh
IIydb0peoTHZ/1B026/jgNqUOrv7Y7czlFAvN6AAZBJo23Xe1X0bwiXCo/QUJKTprGBC+aFWAzTA
eCWri4KQYwntt25K6Nwd0oFnpT5ygnOg6hWUTjbtqA==
=MezS
-----END PGP SIGNATURE-----

--Fdc7FltF5YGeKV3gR9EUKXH5xt7a8jSp8--


From xen-devel-bounces@lists.xenproject.org Fri Oct 29 10:32:58 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Oct 2021 10:32:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.218501.378962 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgPBo-0000bY-GB; Fri, 29 Oct 2021 10:32:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 218501.378962; Fri, 29 Oct 2021 10:32:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgPBo-0000bR-Cv; Fri, 29 Oct 2021 10:32:48 +0000
Received: by outflank-mailman (input) for mailman id 218501;
 Fri, 29 Oct 2021 10:32:47 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=qfCy=PR=invisiblethingslab.com=marmarek@srs-us1.protection.inumbo.net>)
 id 1mgPBm-0000bL-T0
 for xen-devel@lists.xenproject.org; Fri, 29 Oct 2021 10:32:46 +0000
Received: from out3-smtp.messagingengine.com (unknown [66.111.4.27])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 8e3f4ee2-38a3-11ec-8510-12813bfff9fa;
 Fri, 29 Oct 2021 10:32:45 +0000 (UTC)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id C0CCF5C01B4;
 Fri, 29 Oct 2021 06:32:45 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute1.internal (MEProxy); Fri, 29 Oct 2021 06:32:45 -0400
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri,
 29 Oct 2021 06:32:44 -0400 (EDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8e3f4ee2-38a3-11ec-8510-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:content-type:date:from:in-reply-to
	:message-id:mime-version:references:subject:to:x-me-proxy
	:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=YdG730
	3DTkIoGkZP5x+x4wYzhp24+CwM+Xym9I44YWs=; b=B7QCGeJ92ZtCVMqwCNv34T
	954aDC3ascW+t0S+sUV//zWOoDdJESXwj5FSjsUPLNH0pouoyow8/sUN52I7/NoB
	C173U6lft8cSpGa7RjglbqH+z2kwmwsT1l8VNnyvplzPHdmlFn3RUP+x+vulL1xo
	bWVzROOVZBgThP9KgxPQPh+8Ppsar87MapLTrSY/n2L/47Cj3D9SqHwsZKVZcFW5
	IaVnLvNIVIWdrIa+6Ear9w3H1lcyhMPIB/1/X8okuUVfIDB8yAlJbOiy0rkMiogp
	zuBZE91zK1+Rg8mVFkYhfFk9IRBHBTwcJAxROcQt7jkFM59upaCtywi91M7rK1pQ
	==
X-ME-Sender: <xms:zc17YVMU6GJBaTwkY-gYaNMt0lZeWwvejwWvLT_0jL9FuXivDDudbA>
    <xme:zc17YX9VjZ3Et2xs2oI0o17j5baFaCrq0JbnFMZla26KuB5MYIzQ8ZT47L6YyvQf2
    zImIom05kCQLA>
X-ME-Received: <xmr:zc17YUTZcfqTgVDM3-5QyjMkedXRf0kdkvyehgqQFer4XJ6dxqe9oSsTslR_qZ3IkC6hTDUBQIQMu_8rLe5cHMZZNversEmV>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrvdeghedgvdeiucetufdoteggodetrfdotf
    fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
    uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
    cujfgurhepfffhvffukfhfgggtuggjsehgtdorredttdejnecuhfhrohhmpeforghrvghk
    ucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesihhnvh
    hishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpeeiieeh
    jeegteeggeeigffhkeekieefjeduhedvfffhiefgkefhvdevfeejffdvfeenucevlhhush
    htvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrghrmhgrrhgvkhes
    ihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm
X-ME-Proxy: <xmx:zc17YRsGQHNxnsefUAzFGYPW2P2_6jMf7nGeldygoAZodjI8fGPLwQ>
    <xmx:zc17Ydef5t6pPNBKmz7vD1CkF3mgxTihbuAL0abFZaJ7fBh8J1KoUg>
    <xmx:zc17Yd3U52gwcZLtJab9z2NtqSxTu-6-ds7uCLNeY5W0gWnXpLx3Lg>
    <xmx:zc17YR4ZsW_HRv9xbHbUVL-FMkSReTPsHcEVAhwbu5Q6Zwem84CuAg>
Date: Fri, 29 Oct 2021 12:32:40 +0200
From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
To: Juergen Gross <jgross@suse.com>
Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>, stable@vger.kernel.org
Subject: Re: [PATCH] xen/balloon: add late_initcall_sync() for initial
 ballooning done
Message-ID: <YXvNyDjltJQrDFJr@mail-itl>
References: <20211028105952.10011-1-jgross@suse.com>
 <YXsFO2TMRiJTQM2q@mail-itl>
 <27e7619a-a797-5c46-9f9f-015ab488e31c@suse.com>
 <YXvFfRKuD574hulr@mail-itl>
 <63a474ea-9e5d-4515-ca99-1d56f52b7673@suse.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="MZykTqTxNZ8yEQ39"
Content-Disposition: inline
In-Reply-To: <63a474ea-9e5d-4515-ca99-1d56f52b7673@suse.com>


--MZykTqTxNZ8yEQ39
Content-Type: text/plain; protected-headers=v1; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Date: Fri, 29 Oct 2021 12:32:40 +0200
From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
To: Juergen Gross <jgross@suse.com>
Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>, stable@vger.kernel.org
Subject: Re: [PATCH] xen/balloon: add late_initcall_sync() for initial
 ballooning done

On Fri, Oct 29, 2021 at 12:22:18PM +0200, Juergen Gross wrote:
> On 29.10.21 11:57, Marek Marczykowski-G=C3=B3recki wrote:
> > On Fri, Oct 29, 2021 at 06:48:44AM +0200, Juergen Gross wrote:
> > > On 28.10.21 22:16, Marek Marczykowski-G=C3=B3recki wrote:
> > > > On Thu, Oct 28, 2021 at 12:59:52PM +0200, Juergen Gross wrote:
> > > > > When running as PVH or HVM guest with actual memory < max memory =
the
> > > > > hypervisor is using "populate on demand" in order to allow the gu=
est
> > > > > to balloon down from its maximum memory size. For this to work
> > > > > correctly the guest must not touch more memory pages than its tar=
get
> > > > > memory size as otherwise the PoD cache will be exhausted and the =
guest
> > > > > is crashed as a result of that.
> > > > >=20
> > > > > In extreme cases ballooning down might not be finished today befo=
re
> > > > > the init process is started, which can consume lots of memory.
> > > > >=20
> > > > > In order to avoid random boot crashes in such cases, add a late i=
nit
> > > > > call to wait for ballooning down having finished for PVH/HVM gues=
ts.
> > > > >=20
> > > > > Cc: <stable@vger.kernel.org>
> > > > > Reported-by: Marek Marczykowski-G=C3=B3recki <marmarek@invisiblet=
hingslab.com>
> > > > > Signed-off-by: Juergen Gross <jgross@suse.com>
> > > >=20
> > > > It may happen that initial balloon down fails (state=3D=3DBP_ECANCE=
LED). In
> > > > that case, it waits indefinitely. I think it should rather report a
> > > > failure (and panic? it's similar to OOM before PID 1 starts, so rat=
her
> > > > hard to recover), instead of hanging.
> > >=20
> > > Okay, I can add something like that. I'm thinking of issuing a failure
> > > message in case of credit not having changed for 1 minute and panic()
> > > after two more minutes. Is this fine?
> >=20
> > Isn't it better to get a state from balloon_thread()? If the balloon
> > fails it won't really try anymore (until 3600s timeout), so waiting in
> > that state doesn't help. And reporting the failure earlier may be more
> > user friendly. Or maybe there is something that could wakeup the thread
> > earlier, that I don't see? Hot plugging more RAM is rather unlikely at
> > this stage...
>=20
> Waking up the thread would be easy, but probably that wouldn't really
> help.

Waking it up alone no. I was thinking what could wake it up - if
nothing, then definitely waiting wouldn't help. You explained that just
below:

> The idea was that maybe a Xen admin would see the guest not booting up
> further and then adding some more memory to the guest (this should wake
> up the balloon thread again).
>=20
> I agree that stopping to wait for ballooning to finish in case of it
> having failed is probably a sensible thing to do. Additionally I could
> add a boot parameter to control the timeout after the fail message and
> the panic().

Right, that would make sense: it's basically a time admin has to plug in
more memory to the VM.

> What do you think?

--=20
Best Regards,
Marek Marczykowski-G=C3=B3recki
Invisible Things Lab

--MZykTqTxNZ8yEQ39
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmF7zckACgkQ24/THMrX
1yzVxQf8DUP3H4Z8NAkaoDVpZJ/oOnqtiuVAYq6eLO+LusUGWgfcjgF6QoxCvMCA
yuUmLc5NaZf9LNeqxNm6v+TOeS4g1ZYgAGtU1r2WeujWFD8uXD/3v1pWyWhLTFEs
BGKjjDJDWBGVYSXh64P7UKxG9fZQH+uiEy9Agfv3Gy0PhvtH8WqpD/kTi5lN/z0G
VQ5jDWcoZgluFddglJx35OXfEEjo8qaojvbl86cYBTFuiRfrVTEo411oh8yl4cHh
sWC+L0F5cngKl6M53q+Rpo3Q5Ohabd/INmhZEGOgQ7P8VXlxhlCkVUA5bWjR1rt8
KdylFCdtRVHctkF+FWP82EqQEHjmtw==
=7a/r
-----END PGP SIGNATURE-----

--MZykTqTxNZ8yEQ39--


From xen-devel-bounces@lists.xenproject.org Fri Oct 29 11:05:00 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Oct 2021 11:05:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.218508.378973 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgPgg-00048S-3J; Fri, 29 Oct 2021 11:04:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 218508.378973; Fri, 29 Oct 2021 11:04:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgPgf-00048L-Vb; Fri, 29 Oct 2021 11:04:41 +0000
Received: by outflank-mailman (input) for mailman id 218508;
 Fri, 29 Oct 2021 11:04:40 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=slsI=PR=citrix.com=roger.pau@srs-us1.protection.inumbo.net>)
 id 1mgPge-000485-5H
 for xen-devel@lists.xenproject.org; Fri, 29 Oct 2021 11:04:40 +0000
Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id c20d8c5a-88b6-4101-be31-9d7761d3ca68;
 Fri, 29 Oct 2021 11:04:37 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c20d8c5a-88b6-4101-be31-9d7761d3ca68
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1635505477;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=8GGuKprvlV/fRhiaW5ZpJ7fLCJim6s5Rur380aIpYvU=;
  b=Xf1pcNZyKRs0S+aUv7vo0lWpgAGAtpuaeDvx4dZ5RCAxfksu7alwQ1m1
   YVI3BGb52COfEEv08HNM0fKe3rCKtkdP12rEx5mQM1Fgp3OF9rgtE7AJm
   x1z7rUYS9WeFk2I+fTs5gDTXnzuvGNwM+LZ2TTTq4+S55bmGPcMJgjkNU
   0=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: Ose0NfwTPiRvjnyOJZM0BHFppAlkQfbtbXHRBOwuMOvvgVslMwrA8uC1zrxNzMC3Cp8qWBi4Iy
 wD22FaOuSXfFsxfcvx0ZZxaLdqIQrf+iNA9QnoSztYZAbrlUj5pO41kyFk8rI3vtC+0ZOsgFpi
 CqIMMg4Fca8aMcxZdOvAM6yyRRMfi+PL3Czqt8Oq3q/hU3hXjmNJn/oV7j245/hLmS497RlO0B
 zNMUwfMVk3miyWzsjWdWJJZboFPDj2UyH/No349/n04ivxdGr4Lcxcgbwrpq5r6CHJlcJ6pJW6
 PjXuzS2sUfGKX77piruTeJpL
X-SBRS: 5.1
X-MesageID: 56188328
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:t0DtQKJTA+R1kof9FE+RjZMlxSXFcZb7ZxGr2PjKsXjdYENS0DZUz
 zAcDzzQbvmON2fye48iPNywpx8Cu8fdz4MwTVZlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s
 q3yv/GZdJhcokcxIn5BC5C5xZVG/fjgqoHUVaiUZUideSc+EH140Eo5yrZg6mJVqYPR7z2l6
 IuaT/L3YDdJ6xYsWo7Dw/vewP/HlK2aVAIw5jTSV9gS1LPtvyB94KYkDbOwNxPFrrx8RYZWc
 QphIIaRpQs19z91Yj+sfy2SnkciGtY+NiDW4pZatjTLbrGvaUXe345iXMfwZ3u7hB2ogOJ0+
 olPlqWUUAd2G6DUt+0RahVXRnQW0a1uoNcrIFC6uM2XiUbHb2Ht07NlC0Re0Y8wo7gtRzsUr
 LpBdW5LPkvra+GemdpXTsF2gcsuNo/zNZ43sXB81zDJS/0hRPgvRo2Xu4YIjGxq1qiiG97FX
 9E6YhxkXC/iegJwME4sL8hvsL+R0yyXnzpw9wvO+PtfD3Lo5AB4zrXFKtfefd2OA8JPkS6wp
 G3c+H/iKgoHL9HZwj2Amlqtme3njS79QJgVFrCz6rhtmlL77lIUDBoaRF6qu86Tg0S1W89cA
 0EM8y9opq83nGSwVcX0VRC8pH+CvzYfVsBWHul87xuCooLE7gDcCmUaQzppbN09qNRwVTEsz
 kWOnd7iGXpoqrL9YXCA8raZqxuiNC5TKnUNDQcGRwYY59jooKkokwnCCN1kFcadkdndCTz2h
 TeQo0ADa6471JBRkf/hpBae3mzq9sOhohMJChv/f32X6zElZq2cQ5Wotn3W9dlJIL+VQQzU1
 JQboPS24OcLBJCLsSWCRuQRAb2kj8q43C3gbU1HRMZ5qWz8k5K3VcUJumsmfRY2WioRUWaxO
 Be7hO9H2HNE0JJGh4dMaIWtF99i86HkEdn0Phw/RosTOsYvHONrEScHWKJx44wPuBRz+U3cE
 c3CGSpJMZr8If46pNZRb7xEuYLHPghkmQvuqWnTlnxLK4a2an+PUqsiO1CTdO0/567siFyLq
 IsDa5XXlkUGCLeWjszrHWg7dw1iwZ8TXsmeliCqXrTbfloO9J8JUqe5LUwdl3xNwP0Oy7agE
 oCVUU5E0lvv7UAr2i3RAk2PnIjHBM4lxVpiZHREFQ/xhxALPNb+hI9CJsBfVeR2q4ReIQtcE
 qBtlzOoWa8UFFwqOl01MPHAkWCVXE/621PRZnD1MGRXklwJb1Whx+IItzDHrUEmJiG2qdE/s
 /un0AbaSoAEXANsEIDdb/fH8r97lSF1dDtaUxSaL99NVl/r9YQ2eSX9guVue5MHKAnZxyvc3
 AGTWE9Kqe7Iqo4z0d/ImaHb8Nv5T7ogRhJXTzvB8LK7FSjG5W7/k4VOZ/mFIGLGX2Tu9aT8O
 egMl6PgMOcKlUphupZnF+o51ro34tbi/ucIzgltEHjRQU6sD7dsfiuP0cVV7/Ufzb5FowqmH
 EmI/4ACa7mOPcrkFn8XJRYkMbvfha1FxGGK4K1sckvg5SJx8L6WamloPkGB2H5HMb94EII52
 uN96sQY3BOy10gxOdGcgyEKq2nVdi4cU78qv40xCZPwjlZ50UlLZJHRB3Ok4JyLbNkQYEAmL
 iXN2fjHjrVYgEHDb2AyBT7G2u8E3cYCvxVDzVkjIVWVm4Wa2q9rjUMJqTlnHB5Iyhhn0v5oP
 jk5PkJ4EqyC4jN0iZURRGurAQxAWEWU90GZJ4HlT4EFo51EjlDwEVA=
IronPort-HdrOrdr: A9a23:AyBKCKANHsyHsUzlHeg2sceALOsnbusQ8zAXPh9KJiC9I/b1qy
 nxppkmPH/P6Qr4WBkb6Le90Y27MAnhHPlOkPQs1NaZLXLbUQ6TQr2KgrGSoQEIdxeOk9K1kJ
 0QD5SWa+eAfGSS7/yKmTVQeuxIqLLskNHK9JfjJjVWPHlXgslbnnlE422gYytLrWd9dP4E/M
 323Ls5m9PsQwVcUu2LQl0+G8TTrdzCk5zrJTYAGh4c8QGLyRel8qTzHRS01goXF2on+8ZvzU
 H11yjCoomzufCyzRHRk0fV8pRtgdPkjv9OHtaFhMQ5IijlziyoeINicbufuy1dmpDj1H8a1P
 335zswNcV67H3cOkmzvBvWwgHllA0j7nfzoGXoyEfLkIjcfnYXGsBBjYVWfl/y8Ew7puxx16
 pNwiawq4dXJQmoplW92/H4EzVR0makq3srluAey1ZFV5EFVbNXpYsDuGtIDZY7Gj7g4oxPKp
 ghMCjl3ocUTbqmVQGagoE2q+bcG0jbXy32DXTqg/blkwS/xxtCvg8lLM92pAZ3yHtycegC2w
 3+CNUbqFh5dL5gUUtMPpZzfSKJMB25ffvtChPbHb21LtBNB5ryw6SHlIndotvaPqA18A==
X-IronPort-AV: E=Sophos;i="5.87,192,1631592000"; 
   d="scan'208";a="56188328"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Z3XdZ7sIXQPHZl6hDDL37RO9ZNyLYsR19IhofmM7GMN1U9Zwv8pDBeWm7oJESi/fwfkRIEpAZBWMnd9kj5l7aeFyYDKH5KWQO/0rFp7ZsmS6Nj29Z7NVwP41uSeIv8exAbwZSaDwfXMdvrNBF/acGM9EKblB73sNSUXlOg35vnPs18LJEdk0H5mpPX5CWB1UK5+jO3Etk06/nEUGwJ+zru6rfgka03vzIc3+RcooC2xwVIylp/aWLtf8r/VW7/XVkbs954QH4SAESOzOeurNyrrX/eS5gfChYv4dcnAgttF9mxvtUCK0f8IE5ftcQByU3EUVktk7kpQPQpIYF0P2jA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=xkmFxWAVPJ5VUqgBkfUGg8iQeZPlKe9heBr3gRjkk5I=;
 b=lfWDLr4VuVhFBuXarQqC5qnNEFQP3htlr1k9PYwvoEjYxd/os28QqsMfEshMNUqPb0TYNsv+YwOfz9FFCwEDCLAEgjiSzBXHoMFuswzATfalz+BSAVoPM1XqK9Xyz+c3XRrY5TOW5Gzxr7t5hwHw3vabwqe3MJeX2vlakP9JWGOCwo9mINEIvH4++rhCy4JgTtRyypiUHwxzE6kWUUY74+n+TqY/05IMqAXNIc63+r8ETqavPuc9M6UbhigdwlwXIW1hcJhzRjFTKNO5WJP/ygdSn1vP4Agy7ltX+X3WFb750tGw46tQr/eQ5mjF6qFtAOIyf6bXRnOjGFWx+8avhQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=xkmFxWAVPJ5VUqgBkfUGg8iQeZPlKe9heBr3gRjkk5I=;
 b=u4ekk4ycZtmzwHLdEkMe4J0C67NBKU48DNbeFSx93Ka24X/gbIj8h1txJMW/q5WWageUIWmD2t2eRqXf268JkyGNCYT0t4ONV3eA35NjHrBlObEFf626OE5Lv+juH0M5u6bKCyC1c7xos6M6vJti8ZUgTUxN6x0a4SJhL0QzEWI=
Date: Fri, 29 Oct 2021 13:04:23 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Julien Grall <julien@xen.org>
CC: <xen-devel@lists.xenproject.org>, Wei Liu <wl@xen.org>, Andrew Cooper
	<andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>, Jan
 Beulich <jbeulich@suse.com>, Stefano Stabellini <sstabellini@kernel.org>,
	Anthony PERARD <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>,
	Christian Lindig <christian.lindig@citrix.com>, David Scott
	<dave@recoil.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, Ian
 Jackson <iwj@xenproject.org>
Subject: Re: [PATCH for-4.16 v4] gnttab: allow setting max version per-domain
Message-ID: <YXvVN0cecMMPdgmh@Air-de-Roger>
References: <20211029075956.1260-1-roger.pau@citrix.com>
 <2e198e53-e3fb-4ea6-0c44-f326b5e5f5fc@xen.org>
 <YXvBz4OdpcmVRAGM@Air-de-Roger>
 <09995bd2-0924-74bf-508f-5692b3250532@xen.org>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <09995bd2-0924-74bf-508f-5692b3250532@xen.org>
X-ClientProxiedBy: PAZP264CA0067.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:102:1fd::10) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: d58301a2-118f-4f00-2005-08d99acbe08e
X-MS-TrafficTypeDiagnostic: DM4PR03MB6095:
X-Microsoft-Antispam-PRVS: <DM4PR03MB60957581E58C63FBFAC2794B8F879@DM4PR03MB6095.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7691;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: SCSqA2tW3xiFUS4QH+EJktK8NLxvm/cPtgUp5J6BeEeo18o0CAJR0vSMfdjeCK89lBHrDcSElLv631qTZlMcNeaKHi9IJO/rvzo3H7RFLQdMquFXi68yjSnWVosPd43vJo4ZjdFtvS0pCyeMu2y9hVzQsWjGgOxzkU83veJaUB1lYIo2EjX5o1+ZQ/AxijIIN6IopVRWLSZREe5Toff3TzKh8YhiDD/ySojYhtK3b3uRYuGRpKAIErVYFN/QEyVYrYSGFrZwlfvB8a9gAMP9WpJl49aGhveDMQWGmqPNjSlTU0B6H+UwWZs5mCZegv/cftF/JoBm7h7ppaKNqc1IR/CoR+Qhr3iVcQl97TxqaxhVYanb42Uv/nbN8mN6rK0obhBAuQp3CGuk6pZD5eT/Goodkl5hfKdl19x63skEpgI8RCQBGwPSGrnwakXYdz01pqQEFMhmfBVy3CbMldh8yzmYz+QXy+kA7kFyV+wEtwtMTVTcAJzslCHJ/57tjMid2oB1G8YQYRlB814gnk/BcQjRHY2Fbfewgnok1vBNMWntkVk6mcePkNgLmarSBytl3DzEb8y/Tlf98keA1LlTD4zhKI4jmTuOSGd6gnUIRhpbBOoN4xZnTbr9lr9vuOYfJDc7nJ79lheZEt+Feivfzw==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(7916004)(4636009)(366004)(4326008)(316002)(2906002)(86362001)(6916009)(85182001)(83380400001)(82960400001)(956004)(508600001)(54906003)(6666004)(8936002)(66946007)(6496006)(8676002)(53546011)(26005)(66556008)(66476007)(33716001)(38100700002)(5660300002)(9686003)(6486002)(186003);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bXdyYlpyakNqOGNUTzJueWZuRUw4cjNBalFFYnRoL3FQc09PemxYa3BuNWZo?=
 =?utf-8?B?eW5yZ1U0Z2I5MDNkbE84ZG9YanJPK3kzL1pEMGpGUUphRWliT1M4VEgzeit1?=
 =?utf-8?B?QzMxdjlicHN2alg3OU5GTFlVYUdvNEI1bnpOc2Z2N2JpbHRva2VpY0xERHM3?=
 =?utf-8?B?U2xWemI3cWFkalRpcURVNVdMdllWYUJQTUdFaS9RYWw2TDFySXFMWERNbkR6?=
 =?utf-8?B?Zk1mbmNCQXF1NWkzcTZ4Z1hBRGx6TGlIRjU4cGYrSTZDazM3bWgwemFZbXNS?=
 =?utf-8?B?VjkyOEU0RFF5REVjWUw4QTZmcEQrRzZtcXo0SFdYc0ZiQkVhdHIxM3JqSUJS?=
 =?utf-8?B?QlhaYmJ2WlNONG9oRWNzVEZub2FaVlNqRGdCVTlRSnk5Wm5HRERNQ3pXTitG?=
 =?utf-8?B?L3ZwTHNIS3BHanpDQ0NCcldmUmlzQWZrVFFobGkrVDZlRkRZQTUwWS9ndFJH?=
 =?utf-8?B?cUgycDQ1cHRWdXpIbVNHTDFjRjB2RkhDaUdJZHVkdUJGOFN6aEh5M1Z5VE1W?=
 =?utf-8?B?SVpQWFN6dEViQ1lkTzArQkhFTU5mMEhwcWE4YTJQcGE1ejYzeDhISjFQMDNP?=
 =?utf-8?B?U1ExMHEyd3E1SUlHVHp4VHpjRnVidU5rQWNOYTl0MXE2cUtVQVBObUFQVzNS?=
 =?utf-8?B?elJHRkxpN2dHQk8wMC8xZkdsSUR1NXJtRVFvOElJelgwYzVVTDRyTUxjM2Z0?=
 =?utf-8?B?S3ZHMHllaS9GelFqS0lpNzY2Mll2YjdqeUxPTk11Qzh5MUpJbVcxbkNPQUJJ?=
 =?utf-8?B?dEIwaTVNOWNVNkdPdkIwK1p4RkNiZW1YcktncnNYazUvR1RJd3B2NDdkQkt5?=
 =?utf-8?B?V29QM1JuQ2JPaWNxNVFPVEw4b1IxVUU3Z0NIRnVMckJMWk56TjVHS1ZkbFF1?=
 =?utf-8?B?SnVLKzhFSTBPTlRWRWduVGo1bVFwT2VTVGtRUVQvb095RmN6aTFobEt0bDVR?=
 =?utf-8?B?SGQ2eVBLNm9zbERIeHE4ZHZyM1p4T0F3MGRBVGhGUHZnb0pTamc2YUZwTi9N?=
 =?utf-8?B?NHRXd2RVTkJUcWVkRURnRUtMY04wNTNka1BhUFlpM0MrbUpHMkhnVkpDdzBt?=
 =?utf-8?B?S0taMEpBYTlPbkdnK3lMTy9zblJUY040b0lLSGFsYUZMLy9nOGdwWGV1Lyt2?=
 =?utf-8?B?UXFSMGRuWE4wanN6djZ1TkJubkQ4VTFPb0ZlOGkvek9OWER1eDNMa1Z4eVRr?=
 =?utf-8?B?a3VIa0kxRzh2V3hBWjBUMjRWcnFVVEhDNjE2Z0lPbEdJUDNZaDVwS1FTVEtS?=
 =?utf-8?B?WkwxSWJ0THRRMFQ3UDZJNnpoaVRCU3JZR2FCQWRhbXBYVzNDY2ZOZnpIODhK?=
 =?utf-8?B?Nnh5YkUyNWkzd3JUVzJOMWVNMWR1SVBnZ0F1cXFmR1JMZU1CQU02OUx4bDVL?=
 =?utf-8?B?SXFZamxoSHhqUmJsT3dnZXYydVY5bXZ4ZGxuSEtPSDJSSmN1VkRVb3hXYURv?=
 =?utf-8?B?SDdOaUN0K2ZyVFFVenJnakFkZGkxMlo5MnFyMmd2U1VUTFhodGZzbW9zUUZs?=
 =?utf-8?B?RG5idlovajJDNjdvWmUrS2FrMFVvaC83TzUwSjA2L1pUTk9YalZWM0ZEeXNx?=
 =?utf-8?B?dm00a2ZVR2dLOFRxdFVFUEZXTFR5b3lkbWNKMlQrRlc5bFd5cWFxTXlDMWUv?=
 =?utf-8?B?OE53a0FqclNFL1I5MkZEV1JxUzZ3elFFSmFvK0dwK3V3TllmWU1YVDl5cE1D?=
 =?utf-8?B?bHJXWUxYVWw2MXV2MnNJL1AxMFY4SFpmUDNQQXcvSzJXditQRkxaU25CWGky?=
 =?utf-8?B?OHd0NHBEY0dyRDB5d1lSbExjeEZzaGZTYVQ1M1JLVTBiQ2lhUzBrUHROaC8r?=
 =?utf-8?B?aGVlK2I0OW91TGhJRkprQkl5dmlRL21aTnlKM0hBcjl1d0Z4RzNXZmY4QWcv?=
 =?utf-8?B?MzNxTnJNMXhwaGhPVktTM3RTWUJpUG5SNHRYRkN3VG5sU0pCWU9Xa2xwT01k?=
 =?utf-8?B?ZjlyU1R1ZndSR29OeDIzUmg0Tjg4b01RaW9NS3dDVk5MdTJ0N1gzalpaQTBo?=
 =?utf-8?B?bnUrMVhXVnQ4UU5Yc2ZCbnBjZUdsN1c2UWloeVVzR25nbm13RDNpSVBZTitC?=
 =?utf-8?B?aWhldndhOEszZnQwZHN3b3dvM29yZnFoUktLbURodUxqUXBLTHhyc24wWDhX?=
 =?utf-8?B?UE4zVFd3a0dmTlk0MnFNL1I4VEpZN2w4eHA2dUlxZ2VPbjVNQ0wxR00vM25k?=
 =?utf-8?Q?pFGxOhcbJ7rCQsMtnpikrrY=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: d58301a2-118f-4f00-2005-08d99acbe08e
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Oct 2021 11:04:28.7429
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kT++WdQOwIAERWq5izK09KT1s2coTFMe+abxPrlggjxR/+UPefuhZ71K916EnzhQ/jeY96TAKPaYbT7o6k7zvw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR03MB6095
X-OriginatorOrg: citrix.com

Hello,

On Fri, Oct 29, 2021 at 11:01:29AM +0100, Julien Grall wrote:
> 
> 
> On 29/10/2021 10:41, Roger Pau Monné wrote:
> > On Fri, Oct 29, 2021 at 09:58:55AM +0100, Julien Grall wrote:
> > > Hi Roger,
> Hi Roger,
> 
> > > On 29/10/2021 08:59, Roger Pau Monne wrote:
> > > > diff --git a/xen/common/grant_table.c b/xen/common/grant_table.c
> > > > index e510395d08..f94f0f272c 100644
> > > > --- a/xen/common/grant_table.c
> > > > +++ b/xen/common/grant_table.c
> > > > @@ -53,6 +53,7 @@ struct grant_table {
> > > >        percpu_rwlock_t       lock;
> > > >        /* Lock protecting the maptrack limit */
> > > >        spinlock_t            maptrack_lock;
> > > > +    unsigned int          max_version;
> > > >        /*
> > > >         * Defaults to v1.  May be changed with GNTTABOP_set_version.  All other
> > > >         * values are invalid.
> > > > @@ -1917,11 +1918,33 @@ active_alloc_failed:
> > > >    }
> > > >    int grant_table_init(struct domain *d, int max_grant_frames,
> > > > -                     int max_maptrack_frames)
> > > > +                     int max_maptrack_frames, unsigned int options)
> > > >    {
> > > >        struct grant_table *gt;
> > > > +    unsigned int max_grant_version = options & XEN_DOMCTL_GRANT_version_mask;
> > > >        int ret = -ENOMEM;
> > > > +    if ( max_grant_version == XEN_DOMCTL_GRANT_version_default )
> > > > +        max_grant_version = opt_gnttab_max_version;
> > > > +    if ( !max_grant_version )
> > > > +    {
> > > > +        dprintk(XENLOG_INFO, "%pd: invalid grant table version 0 requested\n",
> > > > +                d);
> > > > +        return -EINVAL;
> > > > +    }
> > > > +    if ( max_grant_version > opt_gnttab_max_version )
> > > > +    {
> > > > +        dprintk(XENLOG_INFO,
> > > > +                "%pd: requested grant version (%u) greater than supported (%u)\n",
> > > > +                d, max_grant_version, opt_gnttab_max_version);
> > > > +        return -EINVAL;
> > > > +    }
> > > > +    if ( unlikely(max_page >= PFN_DOWN(TB(16))) && is_pv_domain(d) &&
> > > 
> > >  From my understanding, the limit for the grant table v1 is based on the page
> > > granularity used and the size of the fields.
> > > 
> > > So the limit you add is valid for 4KB but not 16KB/64KB. Therefore, I think
> > > it would be better to use:
> > > 
> > > 'max_page >= (1U << 32)'
> > 
> > I'm slightly confused. Isn't Xen always using a 4KB page granularity,
> 
> Yes. We only support 4KB today. But most of Xen is agnostic to the page
> granularity. I have actually started to look to allow 64KB/16KB page
> granularity for Xen on Arm in my spare time.
> 
> > and that also applies to the grant table entries?
> The page granularity for the hypercall interface is whatever the page
> granularity Xen is using. So...

I've somehow assumed that the current hypercall ABI was strictly tied
to 4KB pages, as that's for example already hardcoded in Linux
as XEN_PAGE_SIZE.

> > 
> > I don't think it's possible to use correctly use a 16KB or 64KB page
> > as an entry for the grant table, as Xen assumes those to always be 4KB
> > based.
> 
> ... if you build Xen with 16KB, then the grant table entries will be using
> 16KB.
> 
> So I would like to avoid making the assumption that we are always using 4KB.
> That said, the worse that can happen is a spurious message. So this is more
> to get an accurate check.

I don't have strong objections to using max_page >> 32, it might even
be clearer than checking against TB(16).

It's just that the check would be wrong if we allow Xen itself to use
a different page size than the one used by the grant table interface
to the guest.

> > 
> > > Furthermore, it would add a comment explaining where this limit comes from.
> > > 
> > > Lastly, did you check the compiler wouldn't throw an error on arm32?
> > 
> > I've tested a previous version (v2), but not this one. I assume it
> > doesn't build?
> 
> I haven't tried. But I remember in the past seen report for always
> true/false check. Maybe that was just on coverity?

Hm, possibly. It seems like debian-unstable arm32 gcc is building OK,
but I've got no idea if different compiler versions could complain.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Fri Oct 29 12:06:08 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Oct 2021 12:06:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.218516.378984 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgQdc-0002Dk-Nq; Fri, 29 Oct 2021 12:05:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 218516.378984; Fri, 29 Oct 2021 12:05:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgQdc-0002Dd-Kk; Fri, 29 Oct 2021 12:05:36 +0000
Received: by outflank-mailman (input) for mailman id 218516;
 Fri, 29 Oct 2021 12:05:36 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mgQdc-0002DT-43; Fri, 29 Oct 2021 12:05:36 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mgQdb-00026T-VL; Fri, 29 Oct 2021 12:05:36 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mgQdb-0001ZY-KM; Fri, 29 Oct 2021 12:05:35 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mgQdb-0005dC-Ie; Fri, 29 Oct 2021 12:05:35 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=mIz5ozG+3cYAq194bkSoZ/agriHfHK/11K+7JFk4BOs=; b=lpPV89nzXCbsFF+HS/fh6274WU
	KpXXeL4izPo+56lF4d2Ko/sqOQGnnbEUiWtQIcVNF7E2STl+oGRTdyfjFg0bvWsOx5koPViroH4Gq
	3cvMIs83HXv5Zollv8gQmejRptGrdFeS1miSvizCSyQa7TpHeZ7ADjEXOAec5tC27GZM=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165929-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 165929: tolerable FAIL
X-Osstest-Failures:
    xen-unstable:test-amd64-amd64-examine:memdisk-try-append:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-rtds:guest-saverestore.2:fail:heisenbug
    xen-unstable:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=c91c967f329f866b1826b04e73e32aea936930cd
X-Osstest-Versions-That:
    xen=c91c967f329f866b1826b04e73e32aea936930cd
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 29 Oct 2021 12:05:35 +0000

flight 165929 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165929/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-examine    4 memdisk-try-append fail in 165924 pass in 165929
 test-amd64-amd64-xl-rtds     19 guest-saverestore.2        fail pass in 165924
 test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat  fail pass in 165924

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail like 165919
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 165924
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 165924
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165924
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165924
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 165924
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 165924
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 165924
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 165924
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 165924
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 165924
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 165924
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165924
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 xen                  c91c967f329f866b1826b04e73e32aea936930cd
baseline version:
 xen                  c91c967f329f866b1826b04e73e32aea936930cd

Last test of basis   165929  2021-10-29 01:51:41 Z    0 days
Testing same since                          (not found)         0 attempts

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 fail    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     fail    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 fail    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Published tested tree is already up to date.



From xen-devel-bounces@lists.xenproject.org Fri Oct 29 12:22:35 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Oct 2021 12:22:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.218525.378998 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgQtm-0004bL-5O; Fri, 29 Oct 2021 12:22:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 218525.378998; Fri, 29 Oct 2021 12:22:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgQtm-0004bE-2K; Fri, 29 Oct 2021 12:22:18 +0000
Received: by outflank-mailman (input) for mailman id 218525;
 Fri, 29 Oct 2021 12:22:17 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=SwSe=PR=oracle.com=boris.ostrovsky@srs-us1.protection.inumbo.net>)
 id 1mgQtl-0004b8-3Y
 for xen-devel@lists.xenproject.org; Fri, 29 Oct 2021 12:22:17 +0000
Received: from mx0a-00069f02.pphosted.com (unknown [205.220.165.32])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id b7a54580-1b31-45c6-ab37-a3ee0be1bebe;
 Fri, 29 Oct 2021 12:22:14 +0000 (UTC)
Received: from pps.filterd (m0246627.ppops.net [127.0.0.1])
 by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 19TADLSW032302; 
 Fri, 29 Oct 2021 12:21:52 GMT
Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70])
 by mx0b-00069f02.pphosted.com with ESMTP id 3byedarr68-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Fri, 29 Oct 2021 12:21:52 +0000
Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1])
 by aserp3020.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 19TCFgjE119228;
 Fri, 29 Oct 2021 12:21:51 GMT
Received: from nam04-mw2-obe.outbound.protection.outlook.com
 (mail-mw2nam08lp2171.outbound.protection.outlook.com [104.47.73.171])
 by aserp3020.oracle.com with ESMTP id 3bx4gfu8tr-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Fri, 29 Oct 2021 12:21:51 +0000
Received: from BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10)
 by MN2PR10MB4205.namprd10.prod.outlook.com (2603:10b6:208:1d3::9)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.17; Fri, 29 Oct
 2021 12:21:49 +0000
Received: from BLAPR10MB5009.namprd10.prod.outlook.com
 ([fe80::3c49:46aa:83e1:a329]) by BLAPR10MB5009.namprd10.prod.outlook.com
 ([fe80::3c49:46aa:83e1:a329%6]) with mapi id 15.20.4649.015; Fri, 29 Oct 2021
 12:21:49 +0000
Received: from [10.74.111.7] (138.3.200.7) by
 SN7PR04CA0215.namprd04.prod.outlook.com (2603:10b6:806:127::10) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.15 via Frontend
 Transport; Fri, 29 Oct 2021 12:21:45 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b7a54580-1b31-45c6-ab37-a3ee0be1bebe
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date :
 subject : to : cc : references : from : in-reply-to : content-type :
 content-transfer-encoding : mime-version; s=corp-2021-07-09;
 bh=74H8xL+AFXbdcctO+eR2OVdHELwj+SaH8xrr2PwQCVU=;
 b=bZ3UdmX+yfLUQKY/i4a1bcgubcgOey++xVgM2ACQMi+vZvvJKoIQUq9Ce2NYxmmP2aGJ
 AJYaF/KjlhOGz+36FNr3GNoTGv82FqdE41iAKQL7QVFe1dpnotv+fuEoHR+HofPvEyMd
 njDJm8fHBV6rKotx6c3sDEXWdKCTPWNR+AdnAVZLGDHZq7gQCPCu1SkXd22Cbw8BRPqT
 S/JqpJeHnAdLV3PorSJLPz4Y6zcHCqUpt46fKIfQEJlOGyqOq/zfbiVCxNXGrMBrOHeJ
 u/DhR9Bef1QQzi+Ay7OajfeDwMhj6uYUY3iCicHnd5TYjQ1xf9fdWELY96/Noy7jtxiG UA== 
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=P+cvEHky0rfxUAp9FfKOCbQvp7lu5wTFzSYudoIGcPZp0LGYkTbHFjPcD1+IPOLvPNoDAOnQIDcmWlI+pnVltX8sAGphbene7rYwpUdNElZH9/uLMHB76ecnyn3L13CFukmLo0Wqfj4DTLtcmXB3T3u2Tv6kWm9HuWoxcCFIi6xx3ybux4dIWiwpByn7+U7Ly7IZhXRClMOfgw2zzfywTywYNnNplBLzzwHx8mWt7RVSXMr3DWrnXnOYva+ivJKI2Vbk66FYGNZSY6W58ugNfwpf9/b8IbxSE8QHGlFRUx1zbwpcs9TbyI0GS12QcMhNGomZdPPYcfmJgY7HHPjQkQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=74H8xL+AFXbdcctO+eR2OVdHELwj+SaH8xrr2PwQCVU=;
 b=MaAfH87KQuNdHECpVUHKUMNs6euCaefaxmKUc8nFMwPIxPO3YYOZ4qg11SDry0HWoj5HB4j61mrWnh4Z0mZZxOoBM1/LhAfvoqnbXxjPUNdWuDeWAhCSxOTi0nSCQLQb1k1qcrjdR5yi5T3UozR07tb1dTjJMFKpZio4fPTDPlsIhXoVWZBnLmzrpr3gYortWmm/wJgXz5Tha/3fNEN6XVhNlb04utbS+++5ZuOYuS1VQkGPTJv1bpSSqMv+hnQ8ATLX5yyQekl7SXrBQybJ924zmUlcsZ0cZaL0FbGT6ZqaJHiAK3BLC6I2tH4TxfOsrVbc3F+e0XDMJsgiiHjDcQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com;
 dkim=pass header.d=oracle.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=74H8xL+AFXbdcctO+eR2OVdHELwj+SaH8xrr2PwQCVU=;
 b=M6KEYJyRuU/KETE7gCcDQKwkvmu7MyOmKTVLWDWc92VDY3ss4HxMwtjOy1x8HkWmg1bKD/Lu5Rud/+cBgHmd/lT0K3k9npe/9OLMWqxQAVdb4UDv0d0kkCTxrZZm3fYIqGp/dfszkDEr1uk4dfGBY5VBluZTjsEgtvFLNzXSXdk=
Authentication-Results: suse.com; dkim=none (message not signed)
 header.d=none;suse.com; dmarc=none action=none header.from=oracle.com;
Message-ID: <1aefa1dd-9099-9676-8aad-98299dd64b74@oracle.com>
Date: Fri, 29 Oct 2021 08:21:41 -0400
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.2.1
Subject: Re: [PATCH v3 0/2] x86/xen: simplify irq pvops
Content-Language: en-US
To: Juergen Gross <jgross@suse.com>, xen-devel@lists.xenproject.org,
        x86@kernel.org, linux-kernel@vger.kernel.org,
        virtualization@lists.linux-foundation.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
        Borislav Petkov <bp@alien8.de>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        "H. Peter Anvin" <hpa@zytor.com>, Deep Shah <sdeep@vmware.com>,
        "VMware, Inc." <pv-drivers@vmware.com>
References: <20211028072748.29862-1-jgross@suse.com>
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
In-Reply-To: <20211028072748.29862-1-jgross@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: SN7PR04CA0215.namprd04.prod.outlook.com
 (2603:10b6:806:127::10) To BLAPR10MB5009.namprd10.prod.outlook.com
 (2603:10b6:208:321::10)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: f97efe90-b6c1-46fa-807e-08d99ad6ae6a
X-MS-TrafficTypeDiagnostic: MN2PR10MB4205:
X-Microsoft-Antispam-PRVS: 
	<MN2PR10MB4205D7FA2E10517783457C728A879@MN2PR10MB4205.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:4125;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 
	AV3GszoDBnoLW7bokq9FppGYHHzHDmrcx5x6XmHRp3TgJBjghY317leaK0n4FIjVdH0jva5rmTzT0VZzysMcm10c3PLHHIpUNl8zDzLSjYScvFHoEqBW+NkXVSbFYfgrXtqhgZkcBG6w24zFY9HMmvzvK84W2GJlWJ8lZLnyYn2d/LyJDS1C4I/KQwnXB1USieaQbRNtyqfiXm9QYKrGMM4bblUZbX8u7DJEDBjCcQNYDyC7u/xa9ED6lDJ4Ka25GxX3L4rl9LVQYUgWk4Ez2pyJzVWRy/shalf72sBCnXcKE+QRlM/MXYRcnMAx82x7hW7OkuAGq4nOagcrNNY4h8BG2Ei5D+aKT2IZCmy4GU2wZAlqdjDeKqs1OUTOzj/ffqMMKyfoT7ecAvp7w6+NDsjFVWqGrFepM0RFIvMIDaV++qrSMeBhr4FtAVqJsqPGZnTgVCD5ThwQLUI8xADrAsqjeQcgvCfmwW9FvHKg9wnketus+blI47//cDJ8y98brNhtwuQcWq+goDsDVlxZQNsZ3q7mPQxOVT+GrTrRAp1S014x1fSxCzSD8SQSPoVhGqUEnYxXyE/lBFxp45H1aFU+6Ym5cW9k7eig8AhIdLNL7pFpNsnzaQTSAc7CqqKWjR+KH017abuyoUP/6B9Z+p9T0HSEacMkUODXZc8hRoUvcpQ+KAzAP34EZ03Jd/f2dy7MAsrPI4vk1eTFfFt0F9ZaetWtXGEjEUMrqHpUFKM=
X-Forefront-Antispam-Report: 
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB5009.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(508600001)(316002)(44832011)(38100700002)(66476007)(54906003)(66946007)(5660300002)(8936002)(36756003)(66556008)(6666004)(31696002)(6486002)(186003)(4326008)(16576012)(8676002)(86362001)(31686004)(26005)(83380400001)(2616005)(4744005)(2906002)(53546011)(7416002)(956004)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?THk4L05EM0E4L0d5d1RPdFMzalJHVmhRamVTbkt2T1hQN2gxRC9mWjZ3V1hu?=
 =?utf-8?B?YXlUSjMzbVhvQTl1c3Ztd0RyU1ZGSW12a2FIZUxVdExTK21tUlZNamIxaDZ0?=
 =?utf-8?B?bERmWURjeXFDU2liTW5LODdyc3c5MEVZaEdIVFk2bm1jVklVa3EvaVZLYlRy?=
 =?utf-8?B?TVE1ZmdZRWdLb2Y0ZE1WTDZHZDhOS3N2VkhnT3A0MzZMMnRKOUNOUENtM3NX?=
 =?utf-8?B?ZmlUUjBkU00yUXJaNGYrL0VzUzQ4eTVRL1NVWDVjRUlCU1QvY3MwbjlRNkZC?=
 =?utf-8?B?c0FMZnlKQ2JjbWVwZjRPR3puN2JUUkxjWDJNWUpWKy9sUTh2WjNmZGJPd29H?=
 =?utf-8?B?bGVRcGcvRU5CdHFhaVRMQzZicWJKK3RTSE93ZU52dkVhd3lGV04wc3RjaEJ2?=
 =?utf-8?B?Z0hveDNRZWszWWh2ZjhIVFl5UnNwK01DMVNkZUJ2SFpyRkJ3clFja2pPRXRk?=
 =?utf-8?B?OHNqUXpHYUNGcGc3V1JDRTJobUw4V1JvTlVkT3lSRGpaWm4rV1M1NUNvUnNR?=
 =?utf-8?B?TDhIVXZSVXI0bVk1K0tDZ2NrUjBTRDFlT2gyNktrNVFQaFN6czZjREZsZ25M?=
 =?utf-8?B?WmpsR3U5dkd0QUo1UmhueWNZcW1kaTdEQmtjU3dZVi9iZE00YVhYNHIrMklD?=
 =?utf-8?B?VWd6aUsxUDhjYjc0ZGpXMUpLMFdLeVNRRTRBcVEwVzVlN2RKSjN6b0k4RHZx?=
 =?utf-8?B?bEx3K1RIY2V2RW8zeWgxQmovN3dyUUpRalZtUlVwajBSZmwrVWNCMkV5a25a?=
 =?utf-8?B?VDg4Z1AzeU03bEpkTlluV1ppejI1YVUvMGNudHhiQmUrNGRwUDc5SlRqUmFh?=
 =?utf-8?B?a3lYTDlYZmFWQUk3cnVUU2dsaTJBakNRU2xZTmUzWloyYjJTdmZ5eXBpcldy?=
 =?utf-8?B?YlNNdTFSQWNQZVNHUXZmZ1BEcEZjR2JwUTRsenVGak5jNk9zb2JhSWxXTWVU?=
 =?utf-8?B?QjRUV3c5dW1wZXU3RTBLNzhkNURVaHdqU01sc0c4TjdJUDI3cU9FUlpmWWNp?=
 =?utf-8?B?YkRMa25leHpEbEF3TW9xc0lidXVPdHRCendpUC81cnR2cWVvaVY2enc2RTFN?=
 =?utf-8?B?dVR6U0QwWHU2VTUwYi95UWEwclBlb0lyQWV5L29NYUo3Um9ZU1NBWWlnamtV?=
 =?utf-8?B?eUN6RTFiZDMzSUhzdnlYem9ESE13YmpBdU5iNHZrdHJkVDd3ZHlFZDBmSnRo?=
 =?utf-8?B?QyswVDJWYW9CZjhIbEZwN2FPeUNFRWdkZVJGY0FzZGFlTGFldG50dnBuUkxs?=
 =?utf-8?B?VGxKQ3JsSnE1bDNjTEZBZHFvKzJxbGpuTnlhOUYwTmhHV0IzYUw3b2t6TzVS?=
 =?utf-8?B?LzNlS2lEOFJ6VjkvNUFRU215dk5ZUXltZHp6eUg5WnkrSndnb2d4aVNxRk5l?=
 =?utf-8?B?aGpWZ00zZG1XWjhPbHh6ME5PYXRoQmQvNytpZjZhZVVkNXlmYVN2RXAzc0Y3?=
 =?utf-8?B?dFV2N0V1TFdRbWJLUFUvMDNzTmV5TGptemJ5dFdXZisreFhRTWFtdVpyK0d4?=
 =?utf-8?B?RjAyS2NaNWRNdklOU3pOcTlSNUFaQkZHVnQ5c0hIQ0NiejMwM3VJZUhqMEZh?=
 =?utf-8?B?czBxa1JqNkliWHV2RjFEOFRXVDdPbzk4VTV5Y29BLzU2SFk2OFFTMU52OXhx?=
 =?utf-8?B?ZCtZSnRQelpLNnVNMnFHK2ViSFFSNkhPWEQxekxZcDhBOWdLT2g1dmFBdDhn?=
 =?utf-8?B?d0ovUjJGV0N4Y1AwdGVkM2w0RDg5ZVkycjFmcE5VZGNkNCtoYW5tZ05LQlBI?=
 =?utf-8?Q?7QbI3FUDmVmK/kwyfBvdq760tkldgUz5U5k9WO7?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f97efe90-b6c1-46fa-807e-08d99ad6ae6a
X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Oct 2021 12:21:49.1152
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: wdrFf6+/RJBkHI2HOiL+t7Nc24Ra6jfGxQc6AfVj6pRzPMvyDUkSTlNL6DsuZOlmklxzGb6MKfH8ldE5gJx7K5wkOKlsB7VK4PS/aVF2HWw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR10MB4205
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10151 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 mlxlogscore=999
 bulkscore=0 phishscore=0 mlxscore=0 spamscore=0 adultscore=0
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2110290073
X-Proofpoint-ORIG-GUID: onGq9ew2kjs84MKtF47f0GKEXOP4bVfR
X-Proofpoint-GUID: onGq9ew2kjs84MKtF47f0GKEXOP4bVfR


On 10/28/21 3:27 AM, Juergen Gross wrote:
> The pvops function for Xen PV guests handling the interrupt flag are
> much more complex than needed.
>
> With the supported Xen hypervisor versions they can be simplified a
> lot, especially by removing the need for disabling preemption.
>
> Juergen Gross (2):
>    x86/xen: remove xen_have_vcpu_info_placement flag
>    x86/xen: switch initial pvops IRQ functions to dummy ones
>
>   arch/x86/include/asm/paravirt_types.h |   2 +
>   arch/x86/kernel/paravirt.c            |  13 ++-
>   arch/x86/xen/enlighten.c              | 116 ++++++--------------------
>   arch/x86/xen/enlighten_hvm.c          |   6 +-
>   arch/x86/xen/enlighten_pv.c           |  28 ++-----
>   arch/x86/xen/irq.c                    |  61 +-------------
>   arch/x86/xen/smp.c                    |  24 ------
>   arch/x86/xen/xen-ops.h                |   4 +-
>   8 files changed, 53 insertions(+), 201 deletions(-)
>

Applied to for-linus-5.16


-boris



From xen-devel-bounces@lists.xenproject.org Fri Oct 29 12:22:53 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Oct 2021 12:22:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.218528.379009 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgQuB-000521-IS; Fri, 29 Oct 2021 12:22:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 218528.379009; Fri, 29 Oct 2021 12:22:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgQuB-00051u-ED; Fri, 29 Oct 2021 12:22:43 +0000
Received: by outflank-mailman (input) for mailman id 218528;
 Fri, 29 Oct 2021 12:22:42 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=SwSe=PR=oracle.com=boris.ostrovsky@srs-us1.protection.inumbo.net>)
 id 1mgQuA-0004yu-Cf
 for xen-devel@lists.xenproject.org; Fri, 29 Oct 2021 12:22:42 +0000
Received: from mx0b-00069f02.pphosted.com (unknown [205.220.177.32])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id e5f34a3b-38b2-11ec-8511-12813bfff9fa;
 Fri, 29 Oct 2021 12:22:36 +0000 (UTC)
Received: from pps.filterd (m0246631.ppops.net [127.0.0.1])
 by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 19T9vQCR020637; 
 Fri, 29 Oct 2021 12:22:31 GMT
Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71])
 by mx0b-00069f02.pphosted.com with ESMTP id 3byjkf7y42-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Fri, 29 Oct 2021 12:22:31 +0000
Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1])
 by aserp3030.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 19TCFOEC139698;
 Fri, 29 Oct 2021 12:22:30 GMT
Received: from nam11-co1-obe.outbound.protection.outlook.com
 (mail-co1nam11lp2170.outbound.protection.outlook.com [104.47.56.170])
 by aserp3030.oracle.com with ESMTP id 3bx4gd1hn1-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Fri, 29 Oct 2021 12:22:30 +0000
Received: from BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10)
 by MN2PR10MB4189.namprd10.prod.outlook.com (2603:10b6:208:1de::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.15; Fri, 29 Oct
 2021 12:22:28 +0000
Received: from BLAPR10MB5009.namprd10.prod.outlook.com
 ([fe80::3c49:46aa:83e1:a329]) by BLAPR10MB5009.namprd10.prod.outlook.com
 ([fe80::3c49:46aa:83e1:a329%6]) with mapi id 15.20.4649.015; Fri, 29 Oct 2021
 12:22:28 +0000
Received: from [10.74.111.7] (138.3.200.7) by
 SN7PR04CA0233.namprd04.prod.outlook.com (2603:10b6:806:127::28) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.15 via Frontend
 Transport; Fri, 29 Oct 2021 12:22:26 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e5f34a3b-38b2-11ec-8511-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date :
 subject : to : cc : references : from : in-reply-to : content-type :
 content-transfer-encoding : mime-version; s=corp-2021-07-09;
 bh=rTdmQBOgP+ixEXDhCA/I7hkC9GIUeJRNyJC2+9Pu824=;
 b=SPkBrUpX3QwZdXLlyGBhNu9T+BIv7nBMSFZ1tqgPa8piC6q3G3wM8JufoowzDR1PBHYJ
 mSD5x6apaUj1axcx1RD6rj8QWrsHeGhts6U5HagTHFN7wmzwWjrDAMp4XAtZqfY3uwBx
 SmvIYjODWuOD7Y/BZEWtsxoAwW9SZbYoWGyBBoWyAT5b0Kg4L7thq7dLQB9GizonON17
 tRtMhUdnnMoVSAAu1ExByNRWTev+K7B/hg4X4Ii1XIKNetheX8SvL0yFBiYozk/uIQZN
 gNoOGvipsFFOFB4nangi0rEEkwU5gNGRYi5qWsjCmR0D2UGK6UKcOGFMG5Oj2u10mLMO 0A== 
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=MCACU/KQ2bZYUSXNhn/oGlSg10g8fs0w/QbQimtjzvpyrQxLIF5z/bvXCp1Ula3KmE6162iW8qon/iuZj8riGtezY5+zvu3edx1P0K3RLhh9b4p3jEWtc2sWtkd+Gp5BDrug//r6G70lignDPbzuitkLRR9swIGWwAWJ7xUUSVL8zVyN8FHXsTYn2+BhACwkLW9AC17LOHCvtVM757pojKpuZ53tzB3MnKPiAn54uI6RJqPwwhOSAQt7wracZHjY6TaRCEcwbKVanqScFD8OfIm9z114587Df6DpnK+wBd7owO+TlZb9vwP0UZI3islv3xMjfBDaXEoajpmfj+kdlQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=rTdmQBOgP+ixEXDhCA/I7hkC9GIUeJRNyJC2+9Pu824=;
 b=E3drG/qtGQF6lXILloziGFNWrVmpB1Xy/P0Ft/vgT7ygdd13uJwJD8T+MaIHAVe27N21ptdMbS6zP9eusDEC4slNSVsgivnzHzbQrjuREVFnJJY2+3AWVC6YpGIU4VzFhnznKChrZ1aRDSaR4Jz/MkRjjBnpEBJpV8KuoBzPHPhtgSNchsxBTotuF0++J5TpAuHcH43Cq6vZxKyc1Ss6B3I0PXMj6V2XGLPX8/Bbdc7aE9n/ZOVNe2yYoZr1dFGsF4H4RziMbBjVttIU7CBcX9UY4LQZeB4Bt4XRCsryzLgAdCxq5d68x5wMCPX57i8pkzjNWFuaYMHXhQ70kcNTOA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com;
 dkim=pass header.d=oracle.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=rTdmQBOgP+ixEXDhCA/I7hkC9GIUeJRNyJC2+9Pu824=;
 b=jKCAMvCJVZ3GpiXyhkVawHLp6rNMFWDoPq01mBZktqJIqPf1hn3rbEx0xsfJE4FQKHGwPhp6/XcyHqfn736vtVJyfsAtTMgWcezlQOS/Ecr1PqZp/K8erWZ1axkA7zRGA4v96NG/lA8z/GbMPhikaf7aDxl2dJLW8cUHb3Pi30U=
Authentication-Results: gmail.com; dkim=none (message not signed)
 header.d=none;gmail.com; dmarc=none action=none header.from=oracle.com;
Message-ID: <a76b424f-79b4-3132-d487-b48da2f5e28e@oracle.com>
Date: Fri, 29 Oct 2021 08:22:22 -0400
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.2.1
Subject: Re: [RESEND PATCH v6] xen-pciback: allow compiling on other archs
 than x86
Content-Language: en-US
To: Oleksandr Andrushchenko <andr2000@gmail.com>,
        xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org
Cc: jgross@suse.com, julien@xen.org, sstabellini@kernel.org, jbeulich@suse.com,
        Oleksandr Andrushchenko
 <oleksandr_andrushchenko@epam.com>,
        Anastasiia Lukianenko <anastasiia_lukianenko@epam.com>
References: <20211028143620.144936-1-andr2000@gmail.com>
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
In-Reply-To: <20211028143620.144936-1-andr2000@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: SN7PR04CA0233.namprd04.prod.outlook.com
 (2603:10b6:806:127::28) To BLAPR10MB5009.namprd10.prod.outlook.com
 (2603:10b6:208:321::10)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 80ba7d79-51f1-4e21-c00d-08d99ad6c5ce
X-MS-TrafficTypeDiagnostic: MN2PR10MB4189:
X-Microsoft-Antispam-PRVS: 
	<MN2PR10MB418985B696DF0CB355A73D858A879@MN2PR10MB4189.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8273;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 
	DprBO+gqd9iPGgqkXS9XTveNSUOEsoi7FNvL0AKSdmOKSf8nH+dMXCooAYG6JVRzLzUcbCNL9aemW3q+iptoHuOAa764TKfVQFCaD25tghiHGo4hLBH60Prcmy9F6VAY2rNHRozjUCyxuspJL3D+RzT4xnvfyItsFRsSQWuQaXeY7uzVtKY9gUaMnEtbc1szT6f9oYwlnclceq4c1mbhZxuOuxFw2uXW/b0a6C4gFnhpbK/MNvNQ0+wNUmrCHozoDeexksSvOGCEmxBQ63s8ojKawXtee3WpVcE3lIXdGYAhmrhfLBGePmrkHdyQ4+6B3Qo7wSGTX378MDdstJY/4dhDjLLjz0fgZ0Kr4yhzUy5iPor3tpvmzT/570T3gzAvDjBW8ZqLxJofUFMoQXYz7sh4HvJVH4aoFZJa/XXYv+TiEruOh+EJRV8PPnQ0APrapSTsMoJjlHCQFE5gX86gK5QdWx7o16WbT3gb06pmaCZTRQZSXunZYFdy2R0fj36Fh3Criz6WV98J9EKVH7AYyIAeOFvVn8Q6th8C7m7311Ofw8kx1z+RcYo8d+PpJslhmDXPTiaCPkPXVqlfA0tmjBa6jIP3Vo2aA0pILgSF5AexbSMiT86K5d+UoyolJ2SGMCUFyBR02wod+hkv4JuQz2eMQ2LCVV/KKwnAwMXz+LDmJW9PyeQ4Nv7mW1DmXIKILCAjEMrEPEywPL2jSZsbXNdaqDODkNzNU4x7eur1aU4=
X-Forefront-Antispam-Report: 
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB5009.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(66946007)(66556008)(66476007)(2616005)(956004)(83380400001)(26005)(16576012)(31696002)(5660300002)(44832011)(4326008)(36756003)(8676002)(186003)(508600001)(31686004)(6666004)(53546011)(316002)(54906003)(86362001)(8936002)(2906002)(6486002)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?M1RvZlFPd04xMHlabSs2WnBBR3crcVNWTG4wZDl3OEJ2VnNjYllYckNmQVZH?=
 =?utf-8?B?QTIzNTM0dzF5SjlXRjI5Mjl2VVpyaUd4OHpsb2wwSEhGeXprSFd4ZGVYTlEr?=
 =?utf-8?B?R285bGJLQklPTjVWOVdhZ0Zrb1Jaa1dYbnFJODBxUHVxRjN4N1EyUlpBSmZ4?=
 =?utf-8?B?Z0lnVnJ3VkFVQlEyL3E0cnQwd0RWK0hsT3RTN3Jsd0g1NitVd3QvZ2IzcE0r?=
 =?utf-8?B?YmdXSzh2OFBuemtpdXo4MTZKSmdHdjJ2YUVlbUtiRlVWZGVtaDkra0dJYlh6?=
 =?utf-8?B?bUdlLzVOd01jUVhIWXpTcmtSSTVjbWw2UUlWbEN5YklQRDFwcHFVMnFGdWpM?=
 =?utf-8?B?TE1FcEp2eWZmb3pGOWg3c0J1bnU3RE5UOXhVT2dvQklZRmZzb1NDeFlYTVFV?=
 =?utf-8?B?b1Znek5XZmY1RnpBb3QzODI4WjVMZWo5aG5xSGpid1B3YkxSYmc3T3NRQWdV?=
 =?utf-8?B?RGhZOE1Bd0JYUUM4ZFRtVWxNb0ZjL3QzTzRkN0FQRkt2OXJpY0RNWjA5QWN0?=
 =?utf-8?B?cHpaQVBsOTZsdC9rNmtJTE5KMDhVRkRobVlNM2N1UE02L2dkTSt3QXo4aUE2?=
 =?utf-8?B?d1IwM1FEbDdwRTFybDFBcWthK3BuRmdJVk5XVXdvNHJpSGxjK1VDaUxIVWJm?=
 =?utf-8?B?Nmo1ZEtMTzN0Tk1Ob3FZNktnRTRPSGVGMmRLRk9TTGtKcytCR255ZmVsRUIx?=
 =?utf-8?B?MmM3cTY5YjBjZjFJWm9udzVoVzd5QWlmNDJmN2JMNHRkYTBadVFKS1c3Zldl?=
 =?utf-8?B?dUZwUWFCOFFlc1dmNk9PRTZvNXZyM2ovWUs5OVJRSzBuWndtTUlsajQySWFO?=
 =?utf-8?B?TlQ1S3B6eERhWVBQOWZzMlFVWFF4aUVHY2ZCQVp5dGtxVFJCNG91OEZmTjNW?=
 =?utf-8?B?ZlR6WEdicUhaazFkVERqUTN4eHd1U1VEdFVqMkdxVWV4QnlvbExsN2d1Qzlq?=
 =?utf-8?B?Uzd1YUNTeGVaeDVITEF6Lzl0aThJbG5JZ202UlEra1pYd3Y5VGJjZTJjSzRt?=
 =?utf-8?B?K05lQ2pEU1dXWFhIZGN2YUV4U1UwUTI5NTRkYnlZV3lUdzJaNjhza1NBSmRR?=
 =?utf-8?B?NDFicHdSdkpzQUlQMS9Cc25sZU5ZZ0hMNVZFMVJtUWpiWkNITnlveGdhQ3ds?=
 =?utf-8?B?R2EwUCsrMzVGeFFocmxjN0JVczVIK2IzaElTTiswVUFzYTJJRExUNFd4S0wx?=
 =?utf-8?B?Qng2b2c5Vmk1bHAzN0pkRU9KcVdhOXdUK2JwUFNMczJCQ3JhaUJyNnlUTGVJ?=
 =?utf-8?B?eXpOZVpMeEFFMyttNHlUSzFyN1NFNjRZNnJLWHRDbWNnY2t0TUZRNXVmVWxZ?=
 =?utf-8?B?eUlJU1ZrOW1qUDVNcWJQUnhNQjFySm0vSkVZSVU5VXhEeVJjOGY2Tit5NU4z?=
 =?utf-8?B?L1BhSWI4eFJxaVhwRUhNQVc0eDBCV08rVkJObEdiczNIMTZMV0JBMytpYmY4?=
 =?utf-8?B?d1pBT0wvaXcxY0tSV1NCM2E3UmdPdWdJUEFNR0kxKzAyK3dvTHYyVDZIMkda?=
 =?utf-8?B?TkFjVWZ0QXhzTGdNOUN1UFpSaUF5cGRiOVFxUURleWNNYVc3cmRTVkFVc1JT?=
 =?utf-8?B?bFNLemkwb1YxUkV4Y1E5TTlHRUd0MXQ3N1VSUHpmblJsUUVPVEZiTitzcjJ3?=
 =?utf-8?B?NGZiRDZLbHoyRlZLU3hTekFFZW9ydjY0MDJQTU41ZDFPQS9tRlZDUDVMVkx4?=
 =?utf-8?B?U1lEUVRkak1vdUZHTHVvYjdsbnpMTkhPQXdqT1BwZmVkWTJCbUdCQm9ibFNx?=
 =?utf-8?B?a2tITDRQUWs0Q0gzN0JFM040emdaNEVGRVBNTmRFZjkyak9yYzdySEV6aFJ5?=
 =?utf-8?B?UHpHT1ZMMVYwcEx0RjFkQlh4RjBtc05wSkE0dWVJeGw1d3U3U0wvVHhDZWdT?=
 =?utf-8?B?WWFFNGUwNGVJNDNjWVVlSkV0TUdTeGlBUkFoMjB3S1NmbVJmUnpEZktIN1h5?=
 =?utf-8?B?NWxuQTFISk5MUDRuQUorOWtYMzBmckJtcnUrWmIxNVplVlcvMitRaHNhYUJN?=
 =?utf-8?B?QjNOa1p3T3pnSGF4ZVpTcHlHYm16U09DaXpjcW5QUzBWUm1Jb0lSUEtnM1FQ?=
 =?utf-8?B?cDhXNjFJdVRCQy8yb2VhQVdDbnRzdWdnbDUxL0FHcTdhMDhuNmQ3K21SK0hx?=
 =?utf-8?B?RUxaWFdPcXFmaUs2V3BRUkk4aDhVYzljcUMwbVIyZXh5b1ZZeFlrTXAzVk9y?=
 =?utf-8?B?T3dzM0s0dlkxSTdRRFd3V2pGN1dhbUtWZzZ5UE16ZW9qNDBwV3VMY05qNVo2?=
 =?utf-8?B?cHphMUtDWUQ0eWYyVVNQRzRhSmdnPT0=?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 80ba7d79-51f1-4e21-c00d-08d99ad6c5ce
X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Oct 2021 12:22:28.2991
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: CFmT3ept0fsVoA1epB4/Jp+TFyeff10xwWAmIsvpQErO1b94z5m8IE9X8meF9Tbkp338/usbfGHPcaXsFE75wBhDkexxKcqxqLfcJB1j0Uc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR10MB4189
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10151 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxscore=0 phishscore=0
 suspectscore=0 mlxlogscore=999 adultscore=0 bulkscore=0 spamscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2110290073
X-Proofpoint-ORIG-GUID: mO1rUEjYwhGmBzZcU4HINaNjYRAveYCP
X-Proofpoint-GUID: mO1rUEjYwhGmBzZcU4HINaNjYRAveYCP


On 10/28/21 10:36 AM, Oleksandr Andrushchenko wrote:
> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
>
> Xen-pciback driver was designed to be built for x86 only. But it
> can also be used by other architectures, e.g. Arm.
>
> Currently PCI backend implements multiple functionalities at a time,
> such as:
> 1. It is used as a database for assignable PCI devices, e.g. xl
>     pci-assignable-{add|remove|list} manipulates that list. So, whenever
>     the toolstack needs to know which PCI devices can be passed through
>     it reads that from the relevant sysfs entries of the pciback.
> 2. It is used to hold the unbound PCI devices list, e.g. when passing
>     through a PCI device it needs to be unbound from the relevant device
>     driver and bound to pciback (strictly speaking it is not required
>     that the device is bound to pciback, but pciback is again used as a
>     database of the passed through PCI devices, so we can re-bind the
>     devices back to their original drivers when guest domain shuts down)
> 3. Device reset for the devices being passed through
> 4. Para-virtualised use-cases support
>
> The para-virtualised part of the driver is not always needed as some
> architectures, e.g. Arm or x86 PVH Dom0, are not using backend-frontend
> model for PCI device passthrough.
>
> For such use-cases make the very first step in splitting the
> xen-pciback driver into two parts: Xen PCI stub and PCI PV backend
> drivers.
>
> For that add new configuration options CONFIG_XEN_PCI_STUB and
> CONFIG_XEN_PCIDEV_STUB, so the driver can be limited in its
> functionality, e.g. no support for para-virtualised scenario.
> x86 platform will continue using CONFIG_XEN_PCIDEV_BACKEND for the
> fully featured backend driver.
>
> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> Signed-off-by: Anastasiia Lukianenko <anastasiia_lukianenko@epam.com>
> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
> Reviewed-by: Juergen Gross <jgross@suse.com>



Applied to for-linus-5.16


-boris



From xen-devel-bounces@lists.xenproject.org Fri Oct 29 12:40:03 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Oct 2021 12:40:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.218540.379020 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgRAh-0006zb-Vr; Fri, 29 Oct 2021 12:39:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 218540.379020; Fri, 29 Oct 2021 12:39:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgRAh-0006zU-SZ; Fri, 29 Oct 2021 12:39:47 +0000
Received: by outflank-mailman (input) for mailman id 218540;
 Fri, 29 Oct 2021 12:39:46 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mgRAg-0006zK-DI; Fri, 29 Oct 2021 12:39:46 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mgRAg-0002ed-3M; Fri, 29 Oct 2021 12:39:46 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mgRAf-0002mG-Qz; Fri, 29 Oct 2021 12:39:45 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mgRAf-0005oq-QT; Fri, 29 Oct 2021 12:39:45 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=DimGPb+qTv05LBGKqYRMVKZ1Oqwo3p5ldqW+qZ8lzjQ=; b=7Gxb6Ip5u9aigm0tu/QzTxdRt9
	xJ3mWjQ/DUkxtAk/T6IZFsWmT63NgLXJzQU1HM76hFRaLXiHbT5+3TyU67zyI/QOdVxT+hWaODg4+
	9PqCIXh1bNeQqDooD12SzvcKr5EseN60Az5i5gY8b7x1/BlkLkDyDpHC8CooBnCRXnhM=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165934-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 165934: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=1bc232aae32e812341f10c9b938350cd93308eee
X-Osstest-Versions-That:
    ovmf=bb146ce32dd8edc463e792554351e50b9e5b769f
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 29 Oct 2021 12:39:45 +0000

flight 165934 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165934/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 1bc232aae32e812341f10c9b938350cd93308eee
baseline version:
 ovmf                 bb146ce32dd8edc463e792554351e50b9e5b769f

Last test of basis   165921  2021-10-28 02:41:24 Z    1 days
Testing same since   165934  2021-10-29 08:11:27 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Nickle Wang <nickle.wang@hpe.com>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   bb146ce32d..1bc232aae3  1bc232aae32e812341f10c9b938350cd93308eee -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Fri Oct 29 13:25:48 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Oct 2021 13:25:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.218548.379034 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgRsu-0003xf-Fw; Fri, 29 Oct 2021 13:25:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 218548.379034; Fri, 29 Oct 2021 13:25:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgRsu-0003xY-D0; Fri, 29 Oct 2021 13:25:28 +0000
Received: by outflank-mailman (input) for mailman id 218548;
 Fri, 29 Oct 2021 13:25:27 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mgRst-0003xS-PY
 for xen-devel@lists.xenproject.org; Fri, 29 Oct 2021 13:25:27 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mgRsr-0003V6-PL; Fri, 29 Oct 2021 13:25:25 +0000
Received: from [54.239.6.188] (helo=[192.168.17.171])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mgRsr-0002sS-IQ; Fri, 29 Oct 2021 13:25:25 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=rTlCGHc8T5rt0QqFTbh9/k1ciodDLFsbwlS2hgNRauA=; b=fkeAMRxNuo3fao6Fnf7e0JIGNM
	gkpqG1R+hV4e5aynbyejoRlNUOdpIf2LOviRHqaGtOsA2g+4+g0KzHw4CQi9IH5KYN7wAv4cFvcyp
	yL71IY+Z7NwLdL/GufV5v0ZROLi+N3TqwwKU2ZODzQbmfoEgCQb5/7xiIIVbIHkFTI84=;
Message-ID: <4531cc8e-e7d4-2803-b4e4-06d438b98089@xen.org>
Date: Fri, 29 Oct 2021 14:25:22 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.2.1
Subject: Re: [PATCH for-4.16 v4] gnttab: allow setting max version per-domain
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
Cc: xen-devel@lists.xenproject.org, Wei Liu <wl@xen.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Anthony PERARD <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>,
 Christian Lindig <christian.lindig@citrix.com>, David Scott
 <dave@recoil.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Ian Jackson <iwj@xenproject.org>
References: <20211029075956.1260-1-roger.pau@citrix.com>
 <2e198e53-e3fb-4ea6-0c44-f326b5e5f5fc@xen.org>
 <YXvBz4OdpcmVRAGM@Air-de-Roger>
 <09995bd2-0924-74bf-508f-5692b3250532@xen.org>
 <YXvVN0cecMMPdgmh@Air-de-Roger>
From: Julien Grall <julien@xen.org>
In-Reply-To: <YXvVN0cecMMPdgmh@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

On 29/10/2021 12:04, Roger Pau Monné wrote:
> Hello,

Hi Roger,

> On Fri, Oct 29, 2021 at 11:01:29AM +0100, Julien Grall wrote:
>>
>>
>> On 29/10/2021 10:41, Roger Pau Monné wrote:
>>> On Fri, Oct 29, 2021 at 09:58:55AM +0100, Julien Grall wrote:
>>>> On 29/10/2021 08:59, Roger Pau Monne wrote:
>>>>> diff --git a/xen/common/grant_table.c b/xen/common/grant_table.c
>>>>> index e510395d08..f94f0f272c 100644
>>>>> --- a/xen/common/grant_table.c
>>>>> +++ b/xen/common/grant_table.c
>>>>> @@ -53,6 +53,7 @@ struct grant_table {
>>>>>         percpu_rwlock_t       lock;
>>>>>         /* Lock protecting the maptrack limit */
>>>>>         spinlock_t            maptrack_lock;
>>>>> +    unsigned int          max_version;
>>>>>         /*
>>>>>          * Defaults to v1.  May be changed with GNTTABOP_set_version.  All other
>>>>>          * values are invalid.
>>>>> @@ -1917,11 +1918,33 @@ active_alloc_failed:
>>>>>     }
>>>>>     int grant_table_init(struct domain *d, int max_grant_frames,
>>>>> -                     int max_maptrack_frames)
>>>>> +                     int max_maptrack_frames, unsigned int options)
>>>>>     {
>>>>>         struct grant_table *gt;
>>>>> +    unsigned int max_grant_version = options & XEN_DOMCTL_GRANT_version_mask;
>>>>>         int ret = -ENOMEM;
>>>>> +    if ( max_grant_version == XEN_DOMCTL_GRANT_version_default )
>>>>> +        max_grant_version = opt_gnttab_max_version;
>>>>> +    if ( !max_grant_version )
>>>>> +    {
>>>>> +        dprintk(XENLOG_INFO, "%pd: invalid grant table version 0 requested\n",
>>>>> +                d);
>>>>> +        return -EINVAL;
>>>>> +    }
>>>>> +    if ( max_grant_version > opt_gnttab_max_version )
>>>>> +    {
>>>>> +        dprintk(XENLOG_INFO,
>>>>> +                "%pd: requested grant version (%u) greater than supported (%u)\n",
>>>>> +                d, max_grant_version, opt_gnttab_max_version);
>>>>> +        return -EINVAL;
>>>>> +    }
>>>>> +    if ( unlikely(max_page >= PFN_DOWN(TB(16))) && is_pv_domain(d) &&
>>>>
>>>>   From my understanding, the limit for the grant table v1 is based on the page
>>>> granularity used and the size of the fields.
>>>>
>>>> So the limit you add is valid for 4KB but not 16KB/64KB. Therefore, I think
>>>> it would be better to use:
>>>>
>>>> 'max_page >= (1U << 32)'
>>>
>>> I'm slightly confused. Isn't Xen always using a 4KB page granularity,
>>
>> Yes. We only support 4KB today. But most of Xen is agnostic to the page
>> granularity. I have actually started to look to allow 64KB/16KB page
>> granularity for Xen on Arm in my spare time.
>>
>>> and that also applies to the grant table entries?
>> The page granularity for the hypercall interface is whatever the page
>> granularity Xen is using. So...
> 
> I've somehow assumed that the current hypercall ABI was strictly tied
> to 4KB pages, as that's for example already hardcoded in Linux
> as XEN_PAGE_SIZE.

It is a mess. Before, XEN_PAGE_SIZE was introduced, we were assuming 
that Linux and Xen were using the same page granularity.

When I introduced the support to run guest with 16KB and 64KB, then we 
decided to introduce the define. Looking back at the decision, this was 
a mistake and we should have introduced an hypercall to fetch the ABI 
granularity instead.

> 
>>>
>>> I don't think it's possible to use correctly use a 16KB or 64KB page
>>> as an entry for the grant table, as Xen assumes those to always be 4KB
>>> based.
>>
>> ... if you build Xen with 16KB, then the grant table entries will be using
>> 16KB.
>>
>> So I would like to avoid making the assumption that we are always using 4KB.
>> That said, the worse that can happen is a spurious message. So this is more
>> to get an accurate check.
> 
> I don't have strong objections to using max_page >> 32, it might even
> be clearer than checking against TB(16).
> 
> It's just that the check would be wrong if we allow Xen itself to use
> a different page size than the one used by the grant table interface
> to the guest.

With the current interface, I don't see how we can untie the hypervisor 
page granularity from the ABI.

At least on Arm, if we were going to build Xen with 64KB page size, then 
we will not be able to do mapping less than 64KB in the stage-2 
page-tables (aka HAP on x86).

This is going to require some overhaul in the ABI to untie the page 
granularity from the hypervisor one.

For now, if we were going to introduce page granularity 64KB, then we 
will automatically change the ABI to use 64KB page granularity. 
Therefore, I think the check would be suitable with the current code.

[...]

> Hm, possibly. It seems like debian-unstable arm32 gcc is building OK,
> but I've got no idea if different compiler versions could complain.

Thanks for the testing. It should be fine then. This would be a build 
failure, so it can be easily fixed afterwards if needed.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Oct 29 14:17:05 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Oct 2021 14:17:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.218555.379045 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgSga-000152-EJ; Fri, 29 Oct 2021 14:16:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 218555.379045; Fri, 29 Oct 2021 14:16:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgSga-00014v-B4; Fri, 29 Oct 2021 14:16:48 +0000
Received: by outflank-mailman (input) for mailman id 218555;
 Fri, 29 Oct 2021 14:16:47 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=slsI=PR=citrix.com=roger.pau@srs-us1.protection.inumbo.net>)
 id 1mgSgY-00014p-V9
 for xen-devel@lists.xenproject.org; Fri, 29 Oct 2021 14:16:47 +0000
Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id eb9ce681-4b91-4b20-b0aa-18b1735c922c;
 Fri, 29 Oct 2021 14:16:45 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: eb9ce681-4b91-4b20-b0aa-18b1735c922c
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1635517005;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=Q1mJO5IBCQciyQap9uCYFPNreob06LOsmP7+2Hld/Dk=;
  b=UzqdkuGIWkdP1ZjwBo92yTe5xZjYdfvbJYtvEKsRsrtvu9NXIUDw2IiE
   /WBr0anVkjQRxwSXGL5ghUryHW8rhDuKZSyUzi5+4VgpJhJquCmFkOESh
   vuxozcBrDmF6uepSlegavqNrB9dFn8rMZFNaGHMzoCf7Gfpv/0A3hVEin
   c=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: USx3RN4RJu+fv00FxAuom6H3BZxBcnZtbQcXdJnQQqwEmu/a00k4aBIv4aYU0Tr9SB5SR5eaPW
 TJPkb8K66bxfEVATqXjGemzjAf0F/w5EMeTFr7GNnF6eEXBnapl7f7ktt0O0wcRvcR3EOuBIpD
 XY3zBndmBvuyjtXuWvYnP8kpZqQsK5BBSkqTBPIUwmYvXWWV5qWpSU7efKXDRHdKwK4b3FOq6+
 RMHa4i3gVQSY6eMjHUO+xmQTtFZtMppVX2Uc43htgNvsbwy2aun3Mmb4RF+ct7wphAO+SRha1k
 rHsQKRODap4gjAqjlu2lVcX0
X-SBRS: 5.1
X-MesageID: 57042571
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:LhPjTqDhQI2OTRVW/3Xlw5YqxClBgxIJ4kV8jS/XYbTApGgr1DYHy
 2sZW2iDa/6LamChftF0ao238ExXv8DQztJmQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA
 xA2M4GYRCwMo/u1Si6FatANl1ElvU2zbue6WLGs1hxZH1c+EX5500M7wYbVv6Yz6TSHK1LV0
 T/Ni5W31G+Ng1aY5UpNtspvADs21BjDkGtwUm4WPJinj3eH/5UhN7oNJLnZEpfNatI88thW5
 Qr05OrREmvxp3/BAz4++1rxWhVirrX6ZWBihpfKMkQLb9crSiEai84G2PQghUh/0miXrdooy
 cVxrY3zEy4Jbpadkc4ATEwNe81+FfUuFL7vJHG+tYqYzlHccmuqyPJrZK00FdRGoKAtWzgIr
 KFGbmBWBvyAr7veLLaTUO5ji95lNMD2FIgepmth3XfSCvNOrZXrHvqSuYUFg25YasZmAafaZ
 8w6bQVWTS/ZOSBUPlFHGJcZtbL97pX4W2IB8w/EzUYt2EDfxRJ8+KLgO93UfpqNX8o9tkSXv
 GXd5EziHwoXcteYzFKt822urv/CmzvhX4AfH6H+8eRl6HWtwWgUBAwTREGMi/CzgU6jWPpSM
 0URvCEpqMAa71e3R9PwWxm5pn+svRMGXddUVeog52ml2qfSpgqUGGUAZjpAc8A98t87QyQw0
 V2ElM+vAiZg2JWXVHac+7G8vT60fy8PIgcqZyUJUA8E6NnLu5wog1TESdMLOLGxps34H3f32
 T/ikcQlr+xN14hRjfz9pA2ZxWL3znTUcuIrzlyKQFCvtwJpWJa0JNaByQjgvP9qMZnMGzFto
 0M4s8SZ6ekPC7SEmyqMXPgBEdmV2hqVDNHPqQUwR8d5plxB71bmJNoKuGgvey+FJ+5dIWexC
 HI/rz+983O60JGCVqRwf56qQ/ojyaztBLwJvdiFM4IQPPCdmOKBlRyChHJ8PUixzyDAcollY
 P93lPpA615AVMyLKxLtHo8gPUcDnHxW+I8qbcmTI+6b+bSffmWJbrwOLUGDaOs0hIvd/l6Ir
 4oBapbakk0FOAEbXsUx2dRORbztBSNiba0aVuQNLrLTSuaYMDh5YxMu/V/RU9M8xPkE/gs51
 nq8RlVZ2DLCaY7vcm23hoRYQOq3B/5X9CtjVQR1ZArA8yVzMO6HsfZEH7NqLOZPyQCW5aMtJ
 xXzU57bWaonp/Wu02l1UKQRW6Q5JUr62lvUb3r5CNX9FrY5LzH0FhbfVlKH3AEFDzattNt4p
 Lul1wjBRoEESRgkB8HTAM9DBXvo1ZTEsO4tDUbOPPdJf0DgrNpjJyDr16dlKMAQMxTTgDCd0
 l/OUxsfoODMpa4z8cXI2v/Y/9v4TbMmExoIBXTf4Ja3KTLeojipz7hfXbvaZjvaTm71pvmvP
 L0H0/HmPfQbt19WqI4gQa1zxKcz6oK39b9XxwhpBlvRaFGvBu8yK3WKx5AX5KZM2qVYqU29X
 UfWootWPrCAOcXEFl8NJVV6MrTfhK9MwjSLtKY7OkT34iNz7YGra0QKMknekjFZIZt0LJghn
 bUrtvkJ5lHtkREtKNuH0HxZrjzeMnwaXqw7nZgGG4u32BEzw1RPbJGAWC/75JaDN4dFPkUwe
 2LGgaPDg/JXx1bYcmp1Hn/IhLIPiZMLsRFM7VkDO1XWxYaV2q5phEVcoWYtUwBY7hRbyOYia
 GFkOnp8KbiK4zo11tNIWHqhGl0ZCRCUkqArJ4DlSIENo5GUa1Hw
IronPort-HdrOrdr: A9a23:9l4RjKONJgElbMBcT1v155DYdb4zR+YMi2TDiHofdfUFSKClfp
 6V8cjztSWUtN4QMEtQ/uxoHJPwO080kqQFnLX5XI3SJzUO3VHHEGgM1/qB/9SNIVyaygcZ79
 YdT0EcMqyAMbEZt7eC3ODQKb9Jq7PmgcPY9ds2jU0dNT2CA5sQkTuRYTzrdHGeKjM2YabQQ/
 Gnl7V6TnebCD4qR/X+IkNAc/nIptXNmp6jSRkaByQ/4A3LqT+z8rb1HzWRwx9bClp0sPsf2F
 mAtza8yrSosvm9xBOZ/2jP765OkN+k7tdYHsSDhuUcNz2poAe1Y4ZKXaGEoVkO0aySwWdvtO
 OJjwYrPsx15X+UVmapoSH10w2l6zoq42+K8y7QvVLT5ejCAB4qActIgoxUNjHD7VA7gd162K
 VXm0qEqpt+F3r77WXAzumNcysvulu/oHIkn+JWpWdYS5EiZLhYqpFa1F9JEa0HADnx5OkcYa
 dT5fnnlbVrmG6hHjLkVjEF+q3oYp1zJGbIfqE6gL3U79AM90oJi3fxx6Qk7wE9HdwGOt55Dt
 //Q9ZVfYd1P7grhJJGdZQ8qPSMexnwqDL3QSqvyAfcZeo600ykke+C3Fxy3pDtRKA1
X-IronPort-AV: E=Sophos;i="5.87,193,1631592000"; 
   d="scan'208";a="57042571"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=BdTwtUC/ZxdiKt81lzv/CTifD+Q3fYDZkI7IgrWAKYkTW1E9sJUY3EKx2Vaao7TBtsXjQ/YSIpthZXyHx4ds9zBsPgdGoMq9wSRYQmKr6qufvdWtVtyLyvVf4GuVVMAevc5BuUHqPJVOK7ntxoiMFaFdHRdrvsq0TAW/j3JlZdC4JeGvg502KLX2xkTkv71m9I7P+QulvPqhEXFouJIhbz8ImyMBFT7Id0RzpwxmNxA465PyC4+/Tax4zQc/0qR9oQ0THBeR0WFVH6T5Dq7ib/UgNtpELR9ExJBD/qV8UpHmNx80uQXLAC+G7vjzGQg0/22qFmeAv34O2WXrZZJiEw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=2oTJ6W23QdVUOafx/bi+G+TCm9+9zHxj5wEeDKO78bk=;
 b=X/IXvSW30Byva2LT/IXzIDNFHzyRj1v2U2kiTYldSRLXXfpzdWru7Y4SpAClL5KG3fmX9tHv4020mITovc+9pP0bAbQpzUAbxLupQVE2/7f/LH8EKh0MuIwun9WZxnFG3B/49gR4wYVn0YUTs9JjnesVtEl2Oh6DGDzj24vHt8V2LVmPPiqCT39tU1ArkZgoghsOLgKLu6KXIyMlrAZg0KfTpAGyzm7/URHmM7BSZ1wjVrKZPfpP50fHZDSRvTCSo6IekcBijd2bu4b6YLUduT8nb7s9mnSXCDChm5CnjLqBdihQRXZBINFd5X/DE8PWj5KPYWPzK/8ewAB37SLPEg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=2oTJ6W23QdVUOafx/bi+G+TCm9+9zHxj5wEeDKO78bk=;
 b=AK+O8uXL7Kdq4+zJVeDCRBeZ/XB07Cn05a/DjCt/aV0CwSLfXI5K8shA4+tpwk/itfKFVw6izSBJGiF7ArOCpp2F4ru/Dcz+0pyxGMXf2hsiSfvQ1U8Awb0JzWPLYrWUzQPiu8P6xrJpwu/hZFptd8djOXfnJ0f90HDKnkwwXEs=
Date: Fri, 29 Oct 2021 16:16:34 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Julien Grall <julien@xen.org>
CC: <xen-devel@lists.xenproject.org>, Wei Liu <wl@xen.org>, Andrew Cooper
	<andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>, Jan
 Beulich <jbeulich@suse.com>, Stefano Stabellini <sstabellini@kernel.org>,
	Anthony PERARD <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>,
	Christian Lindig <christian.lindig@citrix.com>, David Scott
	<dave@recoil.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, Ian
 Jackson <iwj@xenproject.org>
Subject: Re: [PATCH for-4.16 v4] gnttab: allow setting max version per-domain
Message-ID: <YXwCQl+LpwsKXzlr@Air-de-Roger>
References: <20211029075956.1260-1-roger.pau@citrix.com>
 <2e198e53-e3fb-4ea6-0c44-f326b5e5f5fc@xen.org>
 <YXvBz4OdpcmVRAGM@Air-de-Roger>
 <09995bd2-0924-74bf-508f-5692b3250532@xen.org>
 <YXvVN0cecMMPdgmh@Air-de-Roger>
 <4531cc8e-e7d4-2803-b4e4-06d438b98089@xen.org>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <4531cc8e-e7d4-2803-b4e4-06d438b98089@xen.org>
X-ClientProxiedBy: PR3P193CA0037.EURP193.PROD.OUTLOOK.COM
 (2603:10a6:102:51::12) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 6610f8b9-9749-4f80-235b-08d99ae6b9cd
X-MS-TrafficTypeDiagnostic: DM5PR03MB3211:
X-Microsoft-Antispam-PRVS: <DM5PR03MB3211A301A0FFBFEFA50E36B48F879@DM5PR03MB3211.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6430;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: PswUOcXxHoDPUQeDBhal1u06j5U0UkA84eN7D6zlacIWkNKgmMQB0i8IUWvkjhgaDnel7kV//gSSdWg8+akrsLh0HtUMgT2gsbphHUmUWFlMGgd8UNRIksCu250s3JnZnWJX5aYYoZjChNrc1crwAwStaDp37AHMVz0x9dGwNRVXj4tUlkpUaj1AcUmCQt9FO+X5nzQwVqXzg89YzhygDER83F3Jlm4wYoDFqCqn3e6wPz03bgR9XPPWRQ7lWqcqi7ak6hbtzHT21H3Hc2w0ufieIVDi6ikncyj/9v2tOOaxJtb6WXLl8KHPxaNUCNPSHVR2K0+TBqQWrXNPZNl8HOzZzaAt5tNxZUkphTIVu2NrjGNbHAu+pzk4VNA2HznD+tddUejDyJ0S7fUY1extG27RdacIy/9A2GtZ+01YfWDKYTXJfsAuyXR6d+ewqLqGAKaIPNRbiKpMqSTXP8npzSoWVBe9aOW+fPdweZyOD14vHA5/v+5p3vQ/pyxsjrZEoa0yVBheLkZ0tLEqAEcX4HbEKuQ84lNM5psYSi9MWMl3sMH3ld+xkXEwOzDELdmK/EbWXjlC6VZ2EfoLHr0ghf7cQ3lug+FcuorXrRa+aLnt42E2LGJdwfdI0SD3+d95UT2lPANEhY5DfkaFdb7+Vbo2w0uKEEm3okUVGBznzwFsuNau7oBDEciZDpLV39ScnySxm1j1q4mGmaYfqXN5eg==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(7916004)(4636009)(366004)(2906002)(66476007)(66556008)(5660300002)(6486002)(33716001)(6496006)(9686003)(54906003)(83380400001)(8936002)(4326008)(66946007)(508600001)(26005)(82960400001)(186003)(53546011)(8676002)(38100700002)(316002)(956004)(6916009)(85182001)(6666004)(86362001)(67856001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eEwwWGk0Mk85RTduM3JWVlg1dnJzcUZ3NlZjRU1LU3VqUkY3VldsZWNOUTlr?=
 =?utf-8?B?dmc3V2pYWHJTUzVkSHlySFlaaWo5SEFVTncrbGNNTHFNVjg1c2Q2QW1RY0py?=
 =?utf-8?B?OTZCb2xFdU9oYzF3ekRtWmxHa0lUWUVwWmhRdW9Jd0hMNmFjWGw5c1o3Sncx?=
 =?utf-8?B?bnBhbjJ3M0hDY0I5aDl2eUJkUnBtTFNhUmNkb05MSkI5WCtmemRJaFUvZ0wv?=
 =?utf-8?B?Ti8vMDNJKys4dXlTU05YR1VSenRCRG5naXhxYW5COG5qQzFDN3FFaUtQclBk?=
 =?utf-8?B?UGlEdEZtVi83SzRBMks3NjkzQ2d2N3VZWEh1RXU0emRIZVNzeWRJbEZuZS96?=
 =?utf-8?B?VWtYa0NIVnh6T1QvYktieVpYd2pGM0RWNmYyMjJ5UkZPa29ndk1ab1RaSmFS?=
 =?utf-8?B?YmRPbm4veE9IbjhOWnorUGsyemRxRlphQmp0VjJUck5GR3NXZHlLM0xiQVJo?=
 =?utf-8?B?VXVqbkxGSDk1TGNlV0FOZmZhVXhEb0dXSnpENjViNlh2YmxqUzZCUGE3c2JC?=
 =?utf-8?B?RkhaVmdOZ1dxQ2xFSUt4UUJsVFpzTERZdGdRUkgrOWtUZDFnVnJFcVZGNTMv?=
 =?utf-8?B?T1Z2VlVyeStZaHhtellUT2NOYzVVY0kySzUzUGl3Y0lEK2tvd2JqQzJlT0Nk?=
 =?utf-8?B?OXRDckxzMm84elprNmx4RW1GSXkwdWtwQUdIdnl3ZUgrQVBtaXhpOTF4SUtU?=
 =?utf-8?B?QktBMEd1TUxVTlFNck1kdHg0Z2s2SnN5RFU0cUw1REVLOTVnbWlQWDJldlVP?=
 =?utf-8?B?aUdrM3BUTUZwbDl4ZTJJbkJjS25WK0V2UGV0NU9nVXpTNWE3eWhTKzc2Sm9G?=
 =?utf-8?B?T0l3K3ZZSTJVcm14UlNjekFsQkxnWWIzUWlFL1d0ZXhHVXJRVG9SdFB5a3gz?=
 =?utf-8?B?TTYwZHNHUlhvb1AyWmc3RHd2UG1aTXlCejk3TXB4RWhOWWFXUWpFVXRCSlMy?=
 =?utf-8?B?VG9qVzBXa2JrSW03NXJkaHJmbHBiM2N0MTIvWTcrbkVwNDVjRUVNcnNoZm5q?=
 =?utf-8?B?UU9Rd2pTSzZUS29Bc3NDeHdDZkYrb0RRTlNpazhRdFI0MHRYMVFpbTlweUdZ?=
 =?utf-8?B?L2NoanIxVzlsaHJ3ajdnSXpnemhYM0piSE9Vc0JxbGw5T0g3UisxazFLVTdy?=
 =?utf-8?B?UnRhK016enF5bXp2czNYQStscjRkcTNHZDkwOVlzVFFOeGJEdGNCUUFWb2pq?=
 =?utf-8?B?UThvaFI1NTEwNjNGc1JxMVBIMktObFBZbU1HVG5CQ0FuZHFqbU4raDhyRjNa?=
 =?utf-8?B?WU52VkcxTjUrSTdLQ1VyaWFLQk1zSWdVNGtnT2hiTmlIdmx0REJpeWI2YWlu?=
 =?utf-8?B?YXdHaTMvUzZEKzE4UkcwYUY3clJqbVN3bjhrTWxtL1oyWlBLTVZ5MGk0RVpp?=
 =?utf-8?B?RDBRTHA1NHFHaU83MW9KWmJTT0kwRENEQkdLcjNPZzBzclpCSXp3VHJuUnlu?=
 =?utf-8?B?eG55cEgxemZsQ0tmK1NiRDU1L2E3UEJqbzJGRkR1aVFuckJJTm9wU2NNMVpx?=
 =?utf-8?B?RjZKVU1kUC9KYUdpdVZJbklCRjBPaVVVN1RhNjcrVnpqaThPY1BXY0k1d0pi?=
 =?utf-8?B?R1RJcjdlR09Yemp1a1lwYTJoRzdXZkpDTGN1SXJ4cXp2UUxNcU9wR1NyNHlv?=
 =?utf-8?B?dldDMTk1dm5EQmhRWkgrR3I0WmZ3anZEK21tTFlXeVZoV0kvSEVZc1Nrb3dP?=
 =?utf-8?B?YWZUZTBxalVyRFIzdmpjWUU5NUZlaFNBTVBqdG5TMDZSTVFYQk91Y2g2ek9T?=
 =?utf-8?B?TXBYODZqRGZwaEVZV2ZRUXlJb1NQV1hRenhyd1VYSUhaeSsvUUdkRjZiM1pq?=
 =?utf-8?B?WTlDTVg1L1RHTGV6dFNoMHlDdXdmREVkV1BZRU51QlRkK3gwZVQ0Nmo5NGlQ?=
 =?utf-8?B?SFc1R29vK2xwOWdrYlJ3aXo2NXZ0YjROYTA3NjMyanNJTDRMaEtJWDlJc3po?=
 =?utf-8?B?RFpTeUNpbXVPM1k1a1YxYkNrY2FtcnFkcG1BUjRKTkxXaGZZT0FmUWV0V3VQ?=
 =?utf-8?B?dGg2M2pCOHdqenYydmIzUGlranMxb3luM25abDI3WWYxaVByN3E3TmFOV25C?=
 =?utf-8?B?MmpyT1lrTmcxNXVrNXFwYnR4ZnREbi90OG9DUUN2cTBOdDFDQzhUMlJacUxa?=
 =?utf-8?B?dTNGaytGekVmMVdORTJ3aXF1MmlZQ2Jpdlk0ZVF6R29LWFlnOVhoVXpHaEpr?=
 =?utf-8?Q?oDu37iXZl9ixn/XIM7W9Q/g=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 6610f8b9-9749-4f80-235b-08d99ae6b9cd
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Oct 2021 14:16:40.1702
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: d2G/5XOxAku8L325bfxJCVNs5M/T0KL1WLsUDHKnaPp53nAIMllGlGK25xSdW2zBH79aoiq8/Bffq7dZaBgf4Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB3211
X-OriginatorOrg: citrix.com

On Fri, Oct 29, 2021 at 02:25:22PM +0100, Julien Grall wrote:
> On 29/10/2021 12:04, Roger Pau Monné wrote:
> > Hello,
> 
> Hi Roger,
> 
> > On Fri, Oct 29, 2021 at 11:01:29AM +0100, Julien Grall wrote:
> > > 
> > > 
> > > On 29/10/2021 10:41, Roger Pau Monné wrote:
> > > > On Fri, Oct 29, 2021 at 09:58:55AM +0100, Julien Grall wrote:
> > > > > On 29/10/2021 08:59, Roger Pau Monne wrote:
> > > > > > diff --git a/xen/common/grant_table.c b/xen/common/grant_table.c
> > > > > > index e510395d08..f94f0f272c 100644
> > > > > > --- a/xen/common/grant_table.c
> > > > > > +++ b/xen/common/grant_table.c
> > > > > > @@ -53,6 +53,7 @@ struct grant_table {
> > > > > >         percpu_rwlock_t       lock;
> > > > > >         /* Lock protecting the maptrack limit */
> > > > > >         spinlock_t            maptrack_lock;
> > > > > > +    unsigned int          max_version;
> > > > > >         /*
> > > > > >          * Defaults to v1.  May be changed with GNTTABOP_set_version.  All other
> > > > > >          * values are invalid.
> > > > > > @@ -1917,11 +1918,33 @@ active_alloc_failed:
> > > > > >     }
> > > > > >     int grant_table_init(struct domain *d, int max_grant_frames,
> > > > > > -                     int max_maptrack_frames)
> > > > > > +                     int max_maptrack_frames, unsigned int options)
> > > > > >     {
> > > > > >         struct grant_table *gt;
> > > > > > +    unsigned int max_grant_version = options & XEN_DOMCTL_GRANT_version_mask;
> > > > > >         int ret = -ENOMEM;
> > > > > > +    if ( max_grant_version == XEN_DOMCTL_GRANT_version_default )
> > > > > > +        max_grant_version = opt_gnttab_max_version;
> > > > > > +    if ( !max_grant_version )
> > > > > > +    {
> > > > > > +        dprintk(XENLOG_INFO, "%pd: invalid grant table version 0 requested\n",
> > > > > > +                d);
> > > > > > +        return -EINVAL;
> > > > > > +    }
> > > > > > +    if ( max_grant_version > opt_gnttab_max_version )
> > > > > > +    {
> > > > > > +        dprintk(XENLOG_INFO,
> > > > > > +                "%pd: requested grant version (%u) greater than supported (%u)\n",
> > > > > > +                d, max_grant_version, opt_gnttab_max_version);
> > > > > > +        return -EINVAL;
> > > > > > +    }
> > > > > > +    if ( unlikely(max_page >= PFN_DOWN(TB(16))) && is_pv_domain(d) &&
> > > > > 
> > > > >   From my understanding, the limit for the grant table v1 is based on the page
> > > > > granularity used and the size of the fields.
> > > > > 
> > > > > So the limit you add is valid for 4KB but not 16KB/64KB. Therefore, I think
> > > > > it would be better to use:
> > > > > 
> > > > > 'max_page >= (1U << 32)'
> > > > 
> > > > I'm slightly confused. Isn't Xen always using a 4KB page granularity,
> > > 
> > > Yes. We only support 4KB today. But most of Xen is agnostic to the page
> > > granularity. I have actually started to look to allow 64KB/16KB page
> > > granularity for Xen on Arm in my spare time.
> > > 
> > > > and that also applies to the grant table entries?
> > > The page granularity for the hypercall interface is whatever the page
> > > granularity Xen is using. So...
> > 
> > I've somehow assumed that the current hypercall ABI was strictly tied
> > to 4KB pages, as that's for example already hardcoded in Linux
> > as XEN_PAGE_SIZE.
> 
> It is a mess. Before, XEN_PAGE_SIZE was introduced, we were assuming that
> Linux and Xen were using the same page granularity.
> 
> When I introduced the support to run guest with 16KB and 64KB, then we
> decided to introduce the define. Looking back at the decision, this was a
> mistake and we should have introduced an hypercall to fetch the ABI
> granularity instead.
> 
> > 
> > > > 
> > > > I don't think it's possible to use correctly use a 16KB or 64KB page
> > > > as an entry for the grant table, as Xen assumes those to always be 4KB
> > > > based.
> > > 
> > > ... if you build Xen with 16KB, then the grant table entries will be using
> > > 16KB.
> > > 
> > > So I would like to avoid making the assumption that we are always using 4KB.
> > > That said, the worse that can happen is a spurious message. So this is more
> > > to get an accurate check.
> > 
> > I don't have strong objections to using max_page >> 32, it might even
> > be clearer than checking against TB(16).

FWIW, I've changed the check to use >> 32 and limited it to
CONFIG_64BIT, since on 32bit arches max_page will be a 32bit value.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Fri Oct 29 14:21:01 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Oct 2021 14:21:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.218563.379056 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgSka-0002bT-2u; Fri, 29 Oct 2021 14:20:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 218563.379056; Fri, 29 Oct 2021 14:20:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgSkZ-0002bM-Vo; Fri, 29 Oct 2021 14:20:55 +0000
Received: by outflank-mailman (input) for mailman id 218563;
 Fri, 29 Oct 2021 14:20:54 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=3izX=PR=suse.com=jgross@srs-us1.protection.inumbo.net>)
 id 1mgSkY-0002bC-7x
 for xen-devel@lists.xenproject.org; Fri, 29 Oct 2021 14:20:54 +0000
Received: from smtp-out1.suse.de (unknown [195.135.220.28])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 6bdb8c42-38c3-11ec-8513-12813bfff9fa;
 Fri, 29 Oct 2021 14:20:52 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id AD8A421637;
 Fri, 29 Oct 2021 14:20:51 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 777CD13F6F;
 Fri, 29 Oct 2021 14:20:51 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id QGDIG0MDfGFxMwAAMHmgww
 (envelope-from <jgross@suse.com>); Fri, 29 Oct 2021 14:20:51 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6bdb8c42-38c3-11ec-8513-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1635517251; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding;
	bh=7R9uA+LpPYmFjie5UDdlkOgIald16ENiSYZa7Y+izN4=;
	b=ajMXA7qP6da3jX2Lm8M8CmYif0cqYQtFZQBtUQ002zP1AGAbtipFTgPOVK1RnrkII7LzBb
	tM7maZ3GATqAG8qvot2qHhjqjoN9COaeWLvLkXnOh5kRnuZSUM3HwtrsKR5eTu1LvDm/cz
	byovVaNLPy0slzzddwVYvSWiszt8ozM=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org,
	linux-kernel@vger.kernel.org
Cc: Juergen Gross <jgross@suse.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	stable@vger.kernel.org,
	=?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
Subject: [PATCH v3] xen/balloon: add late_initcall_sync() for initial ballooning done
Date: Fri, 29 Oct 2021 16:20:49 +0200
Message-Id: <20211029142049.25198-1-jgross@suse.com>
X-Mailer: git-send-email 2.26.2
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

When running as PVH or HVM guest with actual memory < max memory the
hypervisor is using "populate on demand" in order to allow the guest
to balloon down from its maximum memory size. For this to work
correctly the guest must not touch more memory pages than its target
memory size as otherwise the PoD cache will be exhausted and the guest
is crashed as a result of that.

In extreme cases ballooning down might not be finished today before
the init process is started, which can consume lots of memory.

In order to avoid random boot crashes in such cases, add a late init
call to wait for ballooning down having finished for PVH/HVM guests.

Warn on console if initial ballooning fails, panic() after stalling
for more than 3 minutes per default. Add a module parameter for
changing this timeout.

Cc: <stable@vger.kernel.org>
Reported-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
Signed-off-by: Juergen Gross <jgross@suse.com>
---
V2:
- add warning and panic() when stalling (Marek Marczykowski-Górecki)
- don't wait if credit > 0
V3:
- issue warning only after ballooning failed (Marek Marczykowski-Górecki)
- make panic() timeout configurable via parameter
---
 .../stable/sysfs-devices-system-xen_memory    | 10 +++
 drivers/xen/balloon.c                         | 63 +++++++++++++++----
 drivers/xen/xen-balloon.c                     |  2 +
 include/xen/balloon.h                         |  1 +
 4 files changed, 63 insertions(+), 13 deletions(-)

diff --git a/Documentation/ABI/stable/sysfs-devices-system-xen_memory b/Documentation/ABI/stable/sysfs-devices-system-xen_memory
index 6d83f95a8a8e..2da062e2c94a 100644
--- a/Documentation/ABI/stable/sysfs-devices-system-xen_memory
+++ b/Documentation/ABI/stable/sysfs-devices-system-xen_memory
@@ -84,3 +84,13 @@ Description:
 		Control scrubbing pages before returning them to Xen for others domains
 		use. Can be set with xen_scrub_pages cmdline
 		parameter. Default value controlled with CONFIG_XEN_SCRUB_PAGES_DEFAULT.
+
+What:		/sys/devices/system/xen_memory/xen_memory0/boot_timeout
+Date:		November 2021
+KernelVersion:	5.16
+Contact:	xen-devel@lists.xenproject.org
+Description:
+		The time (in seconds) to wait before giving up to boot in case
+		initial ballooning fails to free enough memory. Applies only
+		when running as HVM or PVH guest and started with less memory
+		configured than allowed at max.
diff --git a/drivers/xen/balloon.c b/drivers/xen/balloon.c
index 3a50f097ed3e..98fae43d4cec 100644
--- a/drivers/xen/balloon.c
+++ b/drivers/xen/balloon.c
@@ -125,12 +125,12 @@ static struct ctl_table xen_root[] = {
  * BP_ECANCELED: error, balloon operation canceled.
  */
 
-enum bp_state {
+static enum bp_state {
 	BP_DONE,
 	BP_WAIT,
 	BP_EAGAIN,
 	BP_ECANCELED
-};
+} balloon_state = BP_DONE;
 
 /* Main waiting point for xen-balloon thread. */
 static DECLARE_WAIT_QUEUE_HEAD(balloon_thread_wq);
@@ -494,9 +494,9 @@ static enum bp_state decrease_reservation(unsigned long nr_pages, gfp_t gfp)
  * Stop waiting if either state is BP_DONE and ballooning action is
  * needed, or if the credit has changed while state is not BP_DONE.
  */
-static bool balloon_thread_cond(enum bp_state state, long credit)
+static bool balloon_thread_cond(long credit)
 {
-	if (state == BP_DONE)
+	if (balloon_state == BP_DONE)
 		credit = 0;
 
 	return current_credit() != credit || kthread_should_stop();
@@ -510,13 +510,12 @@ static bool balloon_thread_cond(enum bp_state state, long credit)
  */
 static int balloon_thread(void *unused)
 {
-	enum bp_state state = BP_DONE;
 	long credit;
 	unsigned long timeout;
 
 	set_freezable();
 	for (;;) {
-		switch (state) {
+		switch (balloon_state) {
 		case BP_DONE:
 		case BP_ECANCELED:
 			timeout = 3600 * HZ;
@@ -532,7 +531,7 @@ static int balloon_thread(void *unused)
 		credit = current_credit();
 
 		wait_event_freezable_timeout(balloon_thread_wq,
-			balloon_thread_cond(state, credit), timeout);
+			balloon_thread_cond(credit), timeout);
 
 		if (kthread_should_stop())
 			return 0;
@@ -543,22 +542,23 @@ static int balloon_thread(void *unused)
 
 		if (credit > 0) {
 			if (balloon_is_inflated())
-				state = increase_reservation(credit);
+				balloon_state = increase_reservation(credit);
 			else
-				state = reserve_additional_memory();
+				balloon_state = reserve_additional_memory();
 		}
 
 		if (credit < 0) {
 			long n_pages;
 
 			n_pages = min(-credit, si_mem_available());
-			state = decrease_reservation(n_pages, GFP_BALLOON);
-			if (state == BP_DONE && n_pages != -credit &&
+			balloon_state = decrease_reservation(n_pages,
+							     GFP_BALLOON);
+			if (balloon_state == BP_DONE && n_pages != -credit &&
 			    n_pages < totalreserve_pages)
-				state = BP_EAGAIN;
+				balloon_state = BP_EAGAIN;
 		}
 
-		state = update_schedule(state);
+		balloon_state = update_schedule(balloon_state);
 
 		mutex_unlock(&balloon_mutex);
 
@@ -731,6 +731,7 @@ static int __init balloon_init(void)
 	balloon_stats.max_schedule_delay = 32;
 	balloon_stats.retry_count = 1;
 	balloon_stats.max_retry_count = 4;
+	balloon_stats.boot_timeout = 180;
 
 #ifdef CONFIG_XEN_BALLOON_MEMORY_HOTPLUG
 	set_online_page_callback(&xen_online_page);
@@ -765,3 +766,39 @@ static int __init balloon_init(void)
 	return 0;
 }
 subsys_initcall(balloon_init);
+
+static int __init balloon_wait_finish(void)
+{
+	long credit, last_credit = 0;
+	unsigned long last_changed;
+
+	if (!xen_domain())
+		return -ENODEV;
+
+	/* PV guests don't need to wait. */
+	if (xen_pv_domain() || !current_credit())
+		return 0;
+
+	pr_info("Waiting for initial ballooning down having finished.\n");
+
+	while ((credit = current_credit()) < 0) {
+		if (credit != last_credit) {
+			last_changed = jiffies;
+			last_credit = credit;
+		}
+		if (balloon_state == BP_ECANCELED) {
+			pr_warn_once("Initial ballooning failed, %ld pages need to be freed.\n",
+				     -credit);
+			if (jiffies - last_changed >=
+			    HZ * balloon_stats.boot_timeout)
+				panic("Initial ballooning failed!\n");
+		}
+
+		schedule_timeout_interruptible(HZ / 10);
+	}
+
+	pr_info("Initial ballooning down finished.\n");
+
+	return 0;
+}
+late_initcall_sync(balloon_wait_finish);
diff --git a/drivers/xen/xen-balloon.c b/drivers/xen/xen-balloon.c
index 8cd583db20b1..6e5db50ede0f 100644
--- a/drivers/xen/xen-balloon.c
+++ b/drivers/xen/xen-balloon.c
@@ -150,6 +150,7 @@ static DEVICE_ULONG_ATTR(schedule_delay, 0444, balloon_stats.schedule_delay);
 static DEVICE_ULONG_ATTR(max_schedule_delay, 0644, balloon_stats.max_schedule_delay);
 static DEVICE_ULONG_ATTR(retry_count, 0444, balloon_stats.retry_count);
 static DEVICE_ULONG_ATTR(max_retry_count, 0644, balloon_stats.max_retry_count);
+static DEVICE_ULONG_ATTR(boot_timeout, 0644, balloon_stats.boot_timeout);
 static DEVICE_BOOL_ATTR(scrub_pages, 0644, xen_scrub_pages);
 
 static ssize_t target_kb_show(struct device *dev, struct device_attribute *attr,
@@ -211,6 +212,7 @@ static struct attribute *balloon_attrs[] = {
 	&dev_attr_max_schedule_delay.attr.attr,
 	&dev_attr_retry_count.attr.attr,
 	&dev_attr_max_retry_count.attr.attr,
+	&dev_attr_boot_timeout.attr.attr,
 	&dev_attr_scrub_pages.attr.attr,
 	NULL
 };
diff --git a/include/xen/balloon.h b/include/xen/balloon.h
index 6dbdb0b3fd03..95a4187f263b 100644
--- a/include/xen/balloon.h
+++ b/include/xen/balloon.h
@@ -20,6 +20,7 @@ struct balloon_stats {
 	unsigned long max_schedule_delay;
 	unsigned long retry_count;
 	unsigned long max_retry_count;
+	unsigned long boot_timeout;
 };
 
 extern struct balloon_stats balloon_stats;
-- 
2.26.2



From xen-devel-bounces@lists.xenproject.org Fri Oct 29 14:22:34 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Oct 2021 14:22:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.218570.379067 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgSm2-0003C9-Gs; Fri, 29 Oct 2021 14:22:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 218570.379067; Fri, 29 Oct 2021 14:22:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgSm2-0003C2-Bu; Fri, 29 Oct 2021 14:22:26 +0000
Received: by outflank-mailman (input) for mailman id 218570;
 Fri, 29 Oct 2021 14:22:25 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=3izX=PR=suse.com=jgross@srs-us1.protection.inumbo.net>)
 id 1mgSm1-0003Bw-HO
 for xen-devel@lists.xenproject.org; Fri, 29 Oct 2021 14:22:25 +0000
Received: from smtp-out1.suse.de (unknown [195.135.220.28])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 667d7d82-8cd8-41f8-9aaa-3d3b14c5670c;
 Fri, 29 Oct 2021 14:22:24 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 669F221968;
 Fri, 29 Oct 2021 14:22:23 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 3C28F13F6F;
 Fri, 29 Oct 2021 14:22:23 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id S0YmDZ8DfGECNAAAMHmgww
 (envelope-from <jgross@suse.com>); Fri, 29 Oct 2021 14:22:23 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 667d7d82-8cd8-41f8-9aaa-3d3b14c5670c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1635517343; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:  content-transfer-encoding:content-transfer-encoding;
	bh=b3hbVsW/qd4JlhNtySvVHNwOWfFRRa/WfskrRS8x0kU=;
	b=Q/TsdwhKvafsw3XIx0DN0WD1Emzd6dtaD7TcSz5Q+GEs1/TZufUMxi4MHAYThNeTCVkEPX
	LHjHIkWcaSgKoh2hs4j5xohjeUX8Ee1utuCPb6sblhMkolS3iYlk99xfIOR0e6d897yE0x
	yjsq0I3BMcfLcFPgcASRNhzBGS7HjKI=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org,
	linux-kernel@vger.kernel.org
Cc: Juergen Gross <jgross@suse.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>
Subject: [PATCH] xen/balloon: rename alloc/free_xenballooned_pages
Date: Fri, 29 Oct 2021 16:22:19 +0200
Message-Id: <20211029142219.25357-1-jgross@suse.com>
X-Mailer: git-send-email 2.26.2
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

alloc_xenballooned_pages() and free_xenballooned_pages() are used as
direct replacements of xen_alloc_unpopulated_pages() and
xen_free_unpopulated_pages() in case CONFIG_XEN_UNPOPULATED_ALLOC isn't
defined.

Guard both functions with !CONFIG_XEN_UNPOPULATED_ALLOC and rename them
to the xen_*() variants they are replacing. This allows to remove some
ifdeffery from the xen.h header file.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 drivers/xen/balloon.c | 18 ++++++++++--------
 include/xen/balloon.h |  3 ---
 include/xen/xen.h     |  6 ------
 3 files changed, 10 insertions(+), 17 deletions(-)

diff --git a/drivers/xen/balloon.c b/drivers/xen/balloon.c
index 98fae43d4cec..35fac7fb513a 100644
--- a/drivers/xen/balloon.c
+++ b/drivers/xen/balloon.c
@@ -575,6 +575,7 @@ void balloon_set_new_target(unsigned long target)
 }
 EXPORT_SYMBOL_GPL(balloon_set_new_target);
 
+#ifndef CONFIG_XEN_UNPOPULATED_ALLOC
 static int add_ballooned_pages(int nr_pages)
 {
 	enum bp_state st;
@@ -603,12 +604,12 @@ static int add_ballooned_pages(int nr_pages)
 }
 
 /**
- * alloc_xenballooned_pages - get pages that have been ballooned out
+ * xen_alloc_unpopulated_pages - get pages that have been ballooned out
  * @nr_pages: Number of pages to get
  * @pages: pages returned
  * @return 0 on success, error otherwise
  */
-int alloc_xenballooned_pages(int nr_pages, struct page **pages)
+int xen_alloc_unpopulated_pages(int nr_pages, struct page **pages)
 {
 	int pgno = 0;
 	struct page *page;
@@ -645,7 +646,7 @@ int alloc_xenballooned_pages(int nr_pages, struct page **pages)
 	return 0;
  out_undo:
 	mutex_unlock(&balloon_mutex);
-	free_xenballooned_pages(pgno, pages);
+	xen_free_unpopulated_pages(pgno, pages);
 	/*
 	 * NB: free_xenballooned_pages will only subtract pgno pages, but since
 	 * target_unpopulated is incremented with nr_pages at the start we need
@@ -654,14 +655,14 @@ int alloc_xenballooned_pages(int nr_pages, struct page **pages)
 	balloon_stats.target_unpopulated -= nr_pages - pgno;
 	return ret;
 }
-EXPORT_SYMBOL(alloc_xenballooned_pages);
+EXPORT_SYMBOL(xen_alloc_unpopulated_pages);
 
 /**
- * free_xenballooned_pages - return pages retrieved with get_ballooned_pages
+ * xen_free_unpopulated_pages - return pages retrieved with get_ballooned_pages
  * @nr_pages: Number of pages
  * @pages: pages to return
  */
-void free_xenballooned_pages(int nr_pages, struct page **pages)
+void xen_free_unpopulated_pages(int nr_pages, struct page **pages)
 {
 	int i;
 
@@ -680,9 +681,9 @@ void free_xenballooned_pages(int nr_pages, struct page **pages)
 
 	mutex_unlock(&balloon_mutex);
 }
-EXPORT_SYMBOL(free_xenballooned_pages);
+EXPORT_SYMBOL(xen_free_unpopulated_pages);
 
-#if defined(CONFIG_XEN_PV) && !defined(CONFIG_XEN_UNPOPULATED_ALLOC)
+#if defined(CONFIG_XEN_PV)
 static void __init balloon_add_region(unsigned long start_pfn,
 				      unsigned long pages)
 {
@@ -705,6 +706,7 @@ static void __init balloon_add_region(unsigned long start_pfn,
 	balloon_stats.total_pages += extra_pfn_end - start_pfn;
 }
 #endif
+#endif
 
 static int __init balloon_init(void)
 {
diff --git a/include/xen/balloon.h b/include/xen/balloon.h
index 95a4187f263b..d6ee920fafa4 100644
--- a/include/xen/balloon.h
+++ b/include/xen/balloon.h
@@ -27,9 +27,6 @@ extern struct balloon_stats balloon_stats;
 
 void balloon_set_new_target(unsigned long target);
 
-int alloc_xenballooned_pages(int nr_pages, struct page **pages);
-void free_xenballooned_pages(int nr_pages, struct page **pages);
-
 #ifdef CONFIG_XEN_BALLOON
 void xen_balloon_init(void);
 #else
diff --git a/include/xen/xen.h b/include/xen/xen.h
index 43efba045acc..9f031b5faa54 100644
--- a/include/xen/xen.h
+++ b/include/xen/xen.h
@@ -52,13 +52,7 @@ bool xen_biovec_phys_mergeable(const struct bio_vec *vec1,
 extern u64 xen_saved_max_mem_size;
 #endif
 
-#ifdef CONFIG_XEN_UNPOPULATED_ALLOC
 int xen_alloc_unpopulated_pages(unsigned int nr_pages, struct page **pages);
 void xen_free_unpopulated_pages(unsigned int nr_pages, struct page **pages);
-#else
-#define xen_alloc_unpopulated_pages alloc_xenballooned_pages
-#define xen_free_unpopulated_pages free_xenballooned_pages
-#include <xen/balloon.h>
-#endif
 
 #endif	/* _XEN_XEN_H */
-- 
2.26.2



From xen-devel-bounces@lists.xenproject.org Fri Oct 29 14:28:30 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Oct 2021 14:28:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.218577.379078 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgSrg-0003tc-5a; Fri, 29 Oct 2021 14:28:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 218577.379078; Fri, 29 Oct 2021 14:28:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgSrg-0003tV-0s; Fri, 29 Oct 2021 14:28:16 +0000
Received: by outflank-mailman (input) for mailman id 218577;
 Fri, 29 Oct 2021 14:28:15 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mgSrf-0003tL-7b; Fri, 29 Oct 2021 14:28:15 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mgSrf-0004c5-1F; Fri, 29 Oct 2021 14:28:15 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mgSre-0006xz-KY; Fri, 29 Oct 2021 14:28:14 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mgSre-0002pA-K4; Fri, 29 Oct 2021 14:28:14 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=fkJ6hUboHTpuABfOvC7Bj4GsXkmGyyM4rE+XcU6UYns=; b=pC9Vt+0mL8G+sGqicm74gerCB9
	uRZqjlbVma4POjHQ01AfsRmZJ2FngVvJDm1FZw/Yz0//bIsW0xCer/PWSijKM5Tmti0ObwfzjVre4
	aeob3VrJ0TcmMfCB6ZkkDwwVzlAAWbwv3CXAjeeZoax2jQWY1hjBtwLlitK/EHQ+9yyY=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165932-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 165932: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-xl-credit1:guest-start/debian.repeat:fail:heisenbug
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=f25a5481af12c2360710583b84537eb9e652d57d
X-Osstest-Versions-That:
    linux=411a44c24a561e449b592ff631b7ae321f1eb559
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 29 Oct 2021 14:28:14 +0000

flight 165932 linux-linus real [real]
flight 165935 linux-linus real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/165932/
http://logs.test-lab.xenproject.org/osstest/logs/165935/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-xl-credit1 22 guest-start/debian.repeat fail pass in 165935-retest

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 165927
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 165927
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165927
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 165927
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165927
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 165927
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 165927
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165927
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass

version targeted for testing:
 linux                f25a5481af12c2360710583b84537eb9e652d57d
baseline version:
 linux                411a44c24a561e449b592ff631b7ae321f1eb559

Last test of basis   165927  2021-10-28 17:40:51 Z    0 days
Testing same since   165932  2021-10-29 05:44:11 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Aaron Liu <aaron.liu@amd.com>
  Agustin Gutierrez Sanchez <agustin.gutierrez@amd.com>
  Alex Deucher <alexander.deucher@amd.com>
  Bryant Mairs <bryant@mai.rs>
  Christian König <christian.koenig@amd.com>
  Christoph Hellwig <hch@lst.de>
  Dan Williams <dan.j.williams@intel.com>
  Daniel Vetter <daniel.vetter@ffwll.ch>
  Daniel Vetter <daniel.vetter@intel.com>
  Daniel Wheeler <daniel.wheeler@amd.com>
  Dave Airlie <airlied@redhat.com>
  Erhard F. <erhard_f@mailbox.org>
  Eric Yang <Eric.Yang2@amd.com>
  Imre Deak <imre.deak@intel.com>
  Jake Wang <haonan.wang2@amd.com>
  Jani Nikula <jani.nikula@intel.com>
  Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
  José Roberto de Souza <jose.souza@intel.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
  Mario <awxkrnl@gmail.com>
  Mario Risoldi <awxkrnl@gmail.com>
  Maxime Ripard <maxime@cerno.tech>
  Michael Strauss <michael.strauss@amd.com>
  Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
  Nikola Cornij <nikola.cornij@amd.com>
  Patrik Jakobsson <patrik.r.jakobsson@gmail.com>
  Patrik Jakobsson <pjakobsson@suse.de>
  Sam Ravnborg <sam@ravnborg.org>
  Thelford Williams <tdwilliamsiv@gmail.com>
  Thomas Zimmermann <tzimmermann@suse.de>
  Ville Syrjälä <ville.syrjala@linux.intel.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  fail    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   411a44c24a56..f25a5481af12  f25a5481af12c2360710583b84537eb9e652d57d -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Fri Oct 29 15:26:29 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Oct 2021 15:26:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.218586.379092 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgTlj-0001qB-Md; Fri, 29 Oct 2021 15:26:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 218586.379092; Fri, 29 Oct 2021 15:26:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgTlj-0001q4-JA; Fri, 29 Oct 2021 15:26:11 +0000
Received: by outflank-mailman (input) for mailman id 218586;
 Fri, 29 Oct 2021 15:26:09 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mgTlh-0001pu-Tb; Fri, 29 Oct 2021 15:26:09 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mgTlh-0005Yg-Mu; Fri, 29 Oct 2021 15:26:09 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mgTlh-0008Kz-C7; Fri, 29 Oct 2021 15:26:09 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mgTlh-00062w-Bf; Fri, 29 Oct 2021 15:26:09 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=tKK6KsUDldNDR+46ByvKjxE4WFg8N5k1Dyd6mMhQYX8=; b=ASX0S5zXm81KIURVuwl7IE4rPz
	8n8Zb0wHwIujOe+2Ie1FUYss78lnL/BxUGae12TnRf5wdaVr6KG9pWyBMmprJd2qPK3A4tvO+G6oU
	g95CUCUlG72EoJG+Tls9LF5SgCQlgf4TyNIXl6gf0hMxTExfJWHambj7yymNrsptsSQA=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165933-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 165933: regressions - FAIL
X-Osstest-Failures:
    qemu-mainline:build-i386-xsm:xen-build:fail:regression
    qemu-mainline:build-i386:xen-build:fail:regression
    qemu-mainline:build-armhf:xen-build:fail:regression
    qemu-mainline:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:heisenbug
    qemu-mainline:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-amd:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-pair:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-freebsd10-i386:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-freebsd10-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-coresched-i386-xl:build-check(1):blocked:nonblocking
    qemu-mainline:build-armhf-libvirt:build-check(1):blocked:nonblocking
    qemu-mainline:build-i386-libvirt:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-intel:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-shadow:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-vhd:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=c52d69e7dbaaed0ffdef8125e79218672c30161d
X-Osstest-Versions-That:
    qemuu=50352cce138ef3b30c1cda28a4df68fff5da3202
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 29 Oct 2021 15:26:09 +0000

flight 165933 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165933/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-i386-xsm                6 xen-build                fail REGR. vs. 165682
 build-i386                    6 xen-build                fail REGR. vs. 165682
 build-armhf                   6 xen-build                fail REGR. vs. 165682

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-xl-rtds     20 guest-localmigrate/x10     fail pass in 165928

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl           1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-credit2   1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-cubietruck  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-multivcpu  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-rtds      1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-vhd       1 build-check(1)               blocked  n/a
 test-amd64-i386-qemuu-rhel6hvm-amd  1 build-check(1)               blocked n/a
 test-amd64-i386-pair          1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-freebsd10-i386  1 build-check(1)               blocked  n/a
 test-amd64-i386-freebsd10-amd64  1 build-check(1)               blocked  n/a
 test-amd64-coresched-i386-xl  1 build-check(1)               blocked  n/a
 build-armhf-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-arndale   1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-credit1   1 build-check(1)               blocked  n/a
 test-amd64-i386-qemuu-rhel6hvm-intel  1 build-check(1)             blocked n/a
 test-amd64-i386-xl            1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-pvshim     1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-qemuu-debianhvm-amd64  1 build-check(1)         blocked n/a
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow  1 build-check(1)  blocked n/a
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm  1 build-check(1)      blocked n/a
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 1 build-check(1) blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a
 test-amd64-i386-xl-qemuu-win7-amd64  1 build-check(1)              blocked n/a
 test-amd64-i386-xl-qemuu-ws16-amd64  1 build-check(1)              blocked n/a
 test-amd64-i386-xl-shadow     1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-vhd        1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-xsm        1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165682
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165682
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165682
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 qemuu                c52d69e7dbaaed0ffdef8125e79218672c30161d
baseline version:
 qemuu                50352cce138ef3b30c1cda28a4df68fff5da3202

Last test of basis   165682  2021-10-19 21:09:14 Z    9 days
Failing since        165694  2021-10-20 18:09:12 Z    8 days   21 attempts
Testing same since   165920  2021-10-27 21:39:18 Z    1 days    4 attempts

------------------------------------------------------------
People who touched revisions under test:
  Alistair Francis <alistair.francis@wdc.com>
  Andrew Jones <drjones@redhat.com>
  Ani Sinha <ani@anisinha.ca>
  BALATON Zoltan <balaton@eik.bme.hu>
  Bin Meng <bmeng.cn@gmail.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Cédric Le Goater <clg@kaod.org>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  David Gibson <david@gibson.dropbear.id.au>
  David Hildenbrand <david@redhat.com>
  Dr. David Alan Gilbert <dgilbert@redhat.com>
  Eric Auger <eric.auger@redhat.com>
  Eugenio Pérez <eperezma@redhat.com>
  Frank Chang <frank.chang@sifive.com>
  Gavin Shan <gshan@redhat.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Greg Kurz <groug@kaod.org>
  Gustavo Romero <gromero@linux.ibm.com>
  Igor Mammedov <imammedo@redhat.com>
  Jason Wang <jasowang@redhat.com>
  John Wang <wangzhiqiang02@inspur.com>
  John Wang <wangzq.jn@gmail.com>
  Laurent Vivier <laurent@vivier.eu>
  Laurent Vivier <lvivier@redhat.com>
  Luc Michel <lmichel@kalray.eu>
  Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
  Markus Armbruster <armbru@redhat.com>
  Matheus Ferst <matheus.ferst@eldorado.org.br>
  Mathieu Poirier <mathieu.poirier@linaro.org>
  Michael S. Tsirkin <mst@redhat.com>
  Mingwang Li <limingwang@huawei.com>
  Oğuz Ersen <oguzersen@protonmail.com>
  Peter Krempa <pkrempa@redhat.com>
  Philipp Tomsich <philipp.tomsich@vrull.eu>
  Philippe Mathieu-Daudé <f4bug@amsat.org>
  Philippe Mathieu-Daudé <philmd@redhat.com>
  Richard Henderson <richard.henderson@linaro.org>
  Shuuichirou Ishii <ishii.shuuichir@fujitsu.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Thomas Huth <thuth@redhat.com>
  Tong Ho <tong.ho@xilinx.com>
  Travis Geiselbrecht <travisg@gmail.com>
  Vincent Palatin <vpalatin@rivosinc.com>
  Vivek Goyal <vgoyal@redhat.com>
  Xueming Li <xuemingl@nvidia.com>
  Yanan Wang <wangyanan55@huawei.com>
  Yifei Jiang <jiangyifei@huawei.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               fail    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          blocked 
 test-amd64-i386-xl                                           blocked 
 test-amd64-coresched-i386-xl                                 blocked 
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  blocked 
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       blocked 
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           blocked 
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     blocked 
 test-amd64-i386-freebsd10-amd64                              blocked 
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          blocked 
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          blocked 
 test-armhf-armhf-xl-arndale                                  blocked 
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  blocked 
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  blocked 
 test-armhf-armhf-xl-cubietruck                               blocked 
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         blocked 
 test-amd64-i386-freebsd10-i386                               blocked 
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         blocked 
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                blocked 
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         blocked 
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 blocked 
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    blocked 
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-xl-rtds                                     fail    
 test-armhf-armhf-xl-rtds                                     blocked 
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              blocked 
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    blocked 
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      blocked 
 test-amd64-i386-xl-vhd                                       blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 4111 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Oct 29 16:40:36 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Oct 2021 16:40:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.218594.379106 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgUvH-0001fb-66; Fri, 29 Oct 2021 16:40:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 218594.379106; Fri, 29 Oct 2021 16:40:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgUvH-0001fU-3A; Fri, 29 Oct 2021 16:40:07 +0000
Received: by outflank-mailman (input) for mailman id 218594;
 Fri, 29 Oct 2021 16:40:05 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=o3mb=PR=citrix.com=Andrew.Cooper3@srs-us1.protection.inumbo.net>)
 id 1mgUvF-0001Wf-Hl
 for xen-devel@lists.xenproject.org; Fri, 29 Oct 2021 16:40:05 +0000
Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 1ba01d79-056f-4dac-96a1-1bd66e903c6a;
 Fri, 29 Oct 2021 16:40:04 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1ba01d79-056f-4dac-96a1-1bd66e903c6a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1635525604;
  h=to:cc:references:from:subject:message-id:date:
   in-reply-to:content-transfer-encoding:mime-version;
  bh=zxlbXlXgb/Qd7sR7QQpfFPW0ttoH254puqvJCySCSi0=;
  b=O0a/VPvxUOG7EF2hu+P0B/2hYC/Se+0hX/qpD1EBCYYzksk4E03+7y57
   oY1+Oim+gq6uppxmsbBd38DGWfbUqEq5LUWwugu4nj0K3UgLFItMxuo8X
   0Trd+NbJlOupidR231LzJz1fqmNaeqk5fWA9FS1RCi/bU2da/s+sq2xpE
   U=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: 44hmHNUUMxEnEFr/lEFBYX4Iohi0LQXsyunxuP/SB75N8pVPkS3rIH+Q2GF2vHgcDFRRAT/Dv8
 ykFIY+rRN4T04pRz0puhmttdxDj9BFBsYUpGPA8ngqon17jMGaiKXM8HXatr2euG/eqTJTH23N
 v8C8oIesIACa9z65PIByXq195Bmmm2+f/ffiQWCWjxRXQljhfbgdqiisCxkWnT0oxbM06vKxda
 ezNBPoEFxio7UIqrMPDbhZTCqKlBwJFTnwQDZzwS1i7EpWgaws3bmjMTvy33GPcUJn0lVvjVgt
 nRJWGSr7LklirRuwDQtVLgm6
X-SBRS: 5.1
X-MesageID: 56690498
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:IG4hlKKtv4Lah16BFE+RipMlxSXFcZb7ZxGr2PjKsXjdYENS1jRWn
 GYZUDrUPKzeYDf1KdByb9/j8U8Av8DUytFgSQVlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s
 q3yv/GZdJhcokcxIn5BC5C5xZVG/fjgqoHUVaiUZUideSc+EH140Eo5yrZj6mJVqYPR7z2l6
 IuaT/L3YDdJ6xYsWo7Dw/vewP/HlK2aVAIw5jTSV9gS1LPtvyB94KYkDbOwNxPFrrx8RYZWc
 QphIIaRpQs19z91Yj+sfy2SnkciGtY+NiDW4pZatjTLbrGvaUXe345iXMfwZ3u7hB2bs8lAw
 dNni6exWBdqHpDzqdoha0BxRnQW0a1uoNcrIFC6uM2XiUbHb2Ht07NlC0Re0Y8wo7gtRzsUr
 LpBdW5LPkvra+GemdpXTsFFgMg5IdatF4QYonx6lhnSDOo8QICFSKLPjTNd9Gpu2JEWQaeOD
 yYfQSUzPFORUQxfBk0WCM5jtaSmnlP1LzIN/Tp5ooJoujOOnWSdyoPFMtDYZ9iLTsV9hVuDq
 yTN+GGRKhMHMN2SzxKV/3TqgfXA9QvrVYRXGLCm+/pChFyI2ndVGBAQTUG8o/Sylgi5Qd03A
 1MQ0jojq+417kPDZsLmQxSyrXqAvxgdc9ldCes37EeK0KW8yzieAm8IXztQcusMvcU9RSEp/
 lKRltavDjtq2JWUVnC15rqStSm1OyUeMSkFfyBsZQkK+d74u6kokwnCCN1kFcadgtTrFBnqz
 juNrSx4gK8c5fPnzI3iowqB2Wj14MGUEEhlvW07Q15J8CtrSJeUboqC12Pa/OYDDLumf2e9h
 CEtzp32AP81MbmBkymEQeMoFb6v5uqYPDC0vWODD6XN5Bz2pCb9JdE4DCVWYR4zaJ5dKGCBj
 Fr74FsJvPdu0G2Wgbibim5bI/8hyrT8DpzbX/TQY8smjnNZJVLfon8GiaJ92QnQfKkQfUMXZ
 cjznSWEVy9y5UFbINyeHbp1PVgDnXlW+I8rbcqnpylLKJLHDJJvdZ8LMUGVcscy576erQPe/
 r53bpXRlkkDDrCjMnCPq+b/yGzmy1BhWPgaTOQML4a+zvdOQjl9W5c9P5t4I+SJYJi5Zs+Xp
 yrgCye0OXL0hGHdKBXiV5yQQOiHYHqLllpiZXZEFQ/xgxALON/zhI9CJ8pfVeR2r4RLkK8rJ
 8Tpju3dW5yjvBycoG9DBXQ8xaQ/HCmWafWmZHv7MWdmJc4wG2QkOLbMJ2PSycXHNQLu3eMWq
 Ly8zALLB50FQgVpFsHNb/yziVi2uBAgdChaBiMk+/FfJxfh9pZEMSv0gqNlKs0AM0yblDCby
 xyXEVETouyU+90599zAhKalqYa1ErQhQhoGTjeDtbvmZzPH+meDwJNbVLradz7qS26pqr6pY
 v9Yzq+gPaRfzkpKqYd1D51i0bk6u4n0v7Zfwwk9RCfLYl2nB6lOOH6D2cUT5KRByqUA4Vm9W
 16V+8kcMrKMYZu3HFkULQsjT+KCyfBLxWWCsaVreB33vXYl8qCGXENeOwi3pBZcdLYlYpk4x
 eoBudIN71DtgBQdLdvb3Dtf8H6BLyJcXvx/5I0aGoLiliEi1kpGPc7HEibz7ZyCN4dMP00tL
 mPGjabOne0BlE/Lcn51HnnRx+tNw58JvUkSnlMFIl2InPvDh+M2g0INoWhmEFwNw0UVyf93N
 0hqK1ZxdPeH8DpfjcReW3yhRlNaDxqD902tk1YEmQU1laVzurAh+IHlBduwwQ==
IronPort-HdrOrdr: A9a23:E5dfjqvSN9me4YucuBFRKV6r7skC5oMji2hC6mlwRA09TyXGra
 +TdaUguSMc1gx9ZJhBo7G90KnpewK4yXcH2/hvAV7EZnibhILIFvAe0WKG+VPd8kLFh5ZgPM
 tbAs9D4ZjLfCJHZKXBkXmF+rQbsaC6GcmT7I+0pRcdLnAYV0gj1XYcNu/yKDwGeOAsP+teKH
 Pz3Lskm9PtQwVtUiztbUN1IdQr6ue72a7OUFojPVoK+QOOhTSn5PrTFAWZ5A4XV3dqza05+W
 bIvgTl7uH72svLhSP05iv21dB7idHhwtxMCIiljdUUECzljkKNaJ56U7OPkTgpqKWE6Uoskv
 PLvxA8Vv4Dp0/5TyWQm1/AygPg2DEh5zvLzkKZu2LqpYjDSDczG6N69MpkWyqcz3BlkMB30a
 pN0W7cnYFQFwn8kCP04MWNfw12l2KvyEBS0dI7vjh6a88zebVRpYsQ8Ad+C5EbBh/374ghDa
 1HENzc3vBLalmXBkqp/1WH+ObcHEjbIy32B3Tr4qeuonxrdTFCvgUlLfUk7zQ9HMlXcegC2w
 zGWp4Y3Y2mAPVmK56VP91xNPdfPFa9Ny4kAFjiU2gPK5t3T04li6SHq4ndt9vaMqDh8vMJ6e
 P8uRVjxDcPR34=
X-IronPort-AV: E=Sophos;i="5.87,193,1631592000"; 
   d="scan'208";a="56690498"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ISosBwDDbg9W2Ptu7oBucqKfxD3gjOc59OW5ra0WdpG4DCPKO9B60DI78wh5HTG57PmHwd6ukbvsH4YZiCgExBgcnxvacbfHW/yEK0hyXVIqQ5AKzJiYy8gF2HBvp6p1eN2X+RbwgwpQoyS8HCCg1vZYMfVIx/H7wiBwdyLFu0VEriCQYW19AmnNQKneuVzua4Goj+Ige2epvA8x5yEEx/fsYuOmVAZ1ifccg1pZmb/JeVdAwRTBgJyz6gnKRU4uw9XQgmhD/6vPW6ujmFOc6h8yG76bav83zMVIO3xjoK1Triw+BCNVPdNGgQY+81/2/vMeTXQ4DsKogBXarqgQGA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=df0oU8hNu0PcbliEm4rCoT+n11xcH77I9QpMr5SaEJM=;
 b=jjn73YpG93yu5uonumHJtkQJMPGeER/8ERzO0rxrFZseAzufqYIpfF1dKqVaVjP5CHlgUOAol2KsQsA27uQoebHFCZjW2riwv3n9EqIX3X5ufi/q30epwglCo0v3qXW4shE/tZQ9xNcOU8EdE430Rgv7xmN+6JEYGP0BvtrgwMjth/eRjKfNOzgsmfcS7B9BqHDOoI2o/TxXS80cNKAPrHqsbZXmcTNjOkKN6QgnWXkc/TJ4tn7OMfqgaEEizhLPk+f2nuozHmwFeEShq6OzvLRJNxXwnnz44l6AgrKq9/AL9Edz7j2l5AF8LNnc+xTk/dlROrnehsE58OxHm/lmRw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=df0oU8hNu0PcbliEm4rCoT+n11xcH77I9QpMr5SaEJM=;
 b=aNLwYXdPWzG1lDEfaD4VUeurEjcpugnEYw7pAw4KKd9aVhA/71E3Bljh0UEjpmouEmqAuWuvhVTcLOwUD2OPdcvaZEvEJiw8iZfBeYPRPrmWB5uBLKeBdCY9K4Eibiw9fWKD96qL11LGNfKVPoJSr6OJdmCU4mDXC/IPLGZAa8w=
To: Roger Pau Monne <roger.pau@citrix.com>, <xen-devel@lists.xenproject.org>
CC: Wei Liu <wl@xen.org>, George Dunlap <george.dunlap@citrix.com>, Jan
 Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>, Stefano
 Stabellini <sstabellini@kernel.org>, Anthony PERARD
	<anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>, Christian
 Lindig <christian.lindig@citrix.com>, David Scott <dave@recoil.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, Ian Jackson
	<iwj@xenproject.org>
References: <20211029075956.1260-1-roger.pau@citrix.com>
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH for-4.16 v4] gnttab: allow setting max version per-domain
Message-ID: <ffd27f87-9e47-12cf-2cfd-1688a19c445f@citrix.com>
Date: Fri, 29 Oct 2021 17:39:52 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <20211029075956.1260-1-roger.pau@citrix.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Content-Language: en-GB
X-ClientProxiedBy: LO4P123CA0188.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:1a4::13) To BYAPR03MB3623.namprd03.prod.outlook.com
 (2603:10b6:a02:aa::12)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 31043b98-4e02-4c6f-f1a2-08d99afabfb4
X-MS-TrafficTypeDiagnostic: BYAPR03MB3559:
X-Microsoft-Antispam-PRVS: <BYAPR03MB3559A73C8E0EC6CF0D16A119BA879@BYAPR03MB3559.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:5236;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: VQtI3/N5fL2LAJST2VJw5iv+/vkRKlUXyQGajJZktVURDboAT3DTMOCoDtWwiHFfm7E+apHLMY1siMlYBIgL20b1Orll8mnnE1+9IQBRr9RTnroCes+w3X9k+q/ukg1ZqS6acJBSJZmXFTjcRX1HG2gUTtR869HnrOoyFO5Rj2nalA07grdlpulTdiSfGpwjEI3u0s+ErotNBNUIdssi10AYAZE77uMZqcGyfNWQMc+U5YB+glRMqyPQDTqRkmEGfJtzNMNaptiCVvGAzupaGrcP4LHbOcv/J8Ntg9supi+X3WV9oPK1weT9bxPiL+sWimHUrkufCWP6JlYTmQA9qUAQ8F9oJtHW+smm75ktehIEBNFpU65kT8RWFV4D4REU6YpFji2w1Tqu0KprBMXIHKKP9sa+h9Bv2wtKrH+o/9B0TS4+N+cjcHBDdU7a1Xs8gZY/SYDtpQRuUEw6Kj4RYu7gIQVg/BncxFwiwj+boPeWBlQGe2rPY7vz+mkXAohbx9jFqMXch1bE87LKAdbNVb1pzeEbSbF1WjWg3mIHMxYOKIDOQu3r04lsk3G/tL0HLVV2Wm6M869XIYP0TOFcDgGTUZAQKJl1kNiQKAr3KDkDYEwQPs/SF/Crwl4M02EnwN3RwVRaaMEhif09LlNSYmkYDfcbjX2bjIWqPK5Pab9KptC7xqym+dU36vuHeHJFYrjNmZZ6pBwIEbeUm3TaZfQJSd25BffWuJCrr38yY9A=
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(38100700002)(66476007)(26005)(4326008)(66946007)(54906003)(6486002)(53546011)(2906002)(66556008)(508600001)(31696002)(6666004)(83380400001)(82960400001)(186003)(31686004)(956004)(16576012)(5660300002)(86362001)(8936002)(316002)(8676002)(2616005)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cXFBdkpZbWJLTTJiTVJEMlhHaGl1SnhHQ3N5eXQvVzBhV1R1S2JBV0JQYk1p?=
 =?utf-8?B?R1Z6ZDVxRmJ4QUdhZXFNRExMd3Y1aTc0ODdoTm0wU3AyOUFabFp3VGs1d2xi?=
 =?utf-8?B?UkpxUml5bTh6LytyQ3llR3R3WDJtcUV1aEpkNHdRQ2xwVUVuUmtEQ2t6UnZh?=
 =?utf-8?B?dG13SUg1Mzl5c3NKdG9KNDZSakcwUVI5ODcwZ0tHeUQxV3RnLzJPS1d1eWFv?=
 =?utf-8?B?ZUVyZDluSWdqTlAzbWZCV0c3cDFWNjMvQm5FNWtlVU5HUFY3L3dPTjFVaERn?=
 =?utf-8?B?WnYrQzI4UTBuVmVoUkZ4d3h6cXVmT056TVorNVIvUTFrZFE5Unlic01nbnpj?=
 =?utf-8?B?ekZyUDduM3lqaHB5WTg3WVhyRXhoRERRTFF5aW9ZZmV1VHl2V0VuSlA3Mmdu?=
 =?utf-8?B?UVpqeWxxSU0xUnE5ZGpiK2c0eHJIZXh0VkQ3MjBRTmltdVBYS3NNL0xWbU56?=
 =?utf-8?B?SXBFVWp3QU1UeUkyUW5DRmdyQmd4Q2hvUkV1dTY5ZS82YThNeXlNK2tSclNT?=
 =?utf-8?B?Z0Qyb044bGFOOUdTcTFCSmtIbFZnWTM4TUVnM1RjQlBqL3BCYVA4Q08vUEFX?=
 =?utf-8?B?SFVlT2RVc3BCdUl6UUxNOWxRU2VLZnd0RnVLTDRlTmsrcVNmcWdnOVcvK1Zm?=
 =?utf-8?B?bllSVzhSek1GWUd5czR5MmwxSURYNWFaeHRSM3JaNFl3TTBpam1yNTZoYXdG?=
 =?utf-8?B?Q285aW13VkZwZmpBK0kyZmVYSGllaHdpRG1PNnlJeElnS0FDMVl2L1pxYTBM?=
 =?utf-8?B?akkwK2tTakpidkQrdS9NSjY2R1BMZGh4VlpoSEV1dXNoUmY4SU56LytBNndz?=
 =?utf-8?B?a3ZXaTBsYTVpeElBNkpZOTFqNWNZdXpQS05HNGxIUEZRNkhiU3htTWh2dHA0?=
 =?utf-8?B?VWRBeC9WS2pJMlh1dEMwd203YWVOcUd1cHJtT003cGpKa3dnQnpKeU1GMDVK?=
 =?utf-8?B?L1Y2ZFpXRkl1cVVyai83c3dYRU1RTVFDeWhtQVVlK2xDVXd4UUkwTlBjL0Fo?=
 =?utf-8?B?QlE2bXdwbFNtR2dkY2Vsd2Z2UWp4c3A4QjRYYnlGZi90OCsvcGNvUTdZS2Vj?=
 =?utf-8?B?K05qQXA0ZFJNNTJGYVJEN2lCSkU0aW40STNuYjBTS2pEZURqTmQ2cHgrNGRV?=
 =?utf-8?B?NFZYcmVkcDdZcVhFbG5POU5nYVpLNUtyVnEvZGdFcEppc3Btek90clpZbHd4?=
 =?utf-8?B?bm04em9MRUx0YnBqVCtsTThPTXVFOFpBQmtqZjdrMk5vMng1K3JpLzdWOUJ5?=
 =?utf-8?B?V1hkWkdkb3Q5dWdUZ2NLZ3EzNUNmamJCSGY2ZjZzWENiWS9TMnYrNDFFRzY2?=
 =?utf-8?B?UmQ3eDUxTm1yVEFxN3ZMamo1QWJKYnYvK2lhZVphWEJ5SjVqNkdHcWJrVWpM?=
 =?utf-8?B?K1pYaGV4MjRIczhtOHcrSW5SRVFGZm1wWDN2d2JuSDBIRUhvNGN6M0VBS2JS?=
 =?utf-8?B?cmJudFZOV1YrQjVRMU1GZzAxMWdMZy96aXN4SXFaZExqVDkxS3pHV0RDNjR3?=
 =?utf-8?B?c3cvUjNsN3MyVmFGWDBkbnROWUh6d0pTaXA3YzVvQVlsT0xzSDhoYTRVSjZC?=
 =?utf-8?B?ZDB5dEs2TmhieDBSQk9xcHlFem9iWEZBVnNmL0tMeU41NXZaaXJkQUpCRTA4?=
 =?utf-8?B?SkJ3WGF6MzJNbnZiV3ZrOTNjWDhRTXNpNGVpYW9QZE5qR1dXREpUTCtSWnFE?=
 =?utf-8?B?UGRrQTI1VWtrWXBmS0xxZXpYeUErdWgyYTc5aGIzSytMUFFVdXFMVHYwcXYw?=
 =?utf-8?B?WnBqRGFWbkZRQ0tYMUJkVWRJbC84V1ZwRFZBUlJrdXkya0JLdGpld3I1OEhh?=
 =?utf-8?B?bG9WQUtncWNBYzFGRWt4cjhDbE5SdnZDK3VRR3ZVTWMvakErVFBrdXFac0pp?=
 =?utf-8?B?ZkdadWRubVNyMHd5cm5EejR5VXUrNkgrOTZoZFc3MXVaUGlLdEJrMEkza25h?=
 =?utf-8?B?bWw3RUVvT04wcFplbm1LRDIxRkpycmM5bUorT2hiODREbS93dUJRUFhsN090?=
 =?utf-8?B?VEJMWGZ4aDJsSktXeTJ5NGVHdzBMTk94aVh1a2haNHIwSDRHaWx6QU5XSTU1?=
 =?utf-8?B?dWg5TlEzN3BNc2ZkOVZLanVTeWI2MFREUmRGU1JTM2hyWUhWZmI4YytHSW43?=
 =?utf-8?B?ck12dzdaK0I4ZXhJWHI1ZklXUEZtTUVuUnlscGRzRFJJOHdmRUZQWkJaTklX?=
 =?utf-8?B?S0JpeGtwc01TZUkvNTV6SHRQYkE1SFdVRi8wTVNqMG83dyt5SjhVdEh6M1Z6?=
 =?utf-8?B?QW5xeFlmMENzZXd1alY4RXYyVjd3PT0=?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 31043b98-4e02-4c6f-f1a2-08d99afabfb4
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Oct 2021 16:40:00.1082
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: YXwBgI+A0LC4zuEct25SnVzCJeJqWwh8iZ80NwBATSglb4MnUwfOsqE7yPcxTQnLULqhOB4/0NaRY8Hhzue1XVGb0ubCFnsRAmQSyMdsr0o=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB3559
X-OriginatorOrg: citrix.com

On 29/10/2021 08:59, Roger Pau Monne wrote:
> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
> index 0167731ab0..faeb3eba76 100644
> --- a/xen/arch/arm/domain_build.c
> +++ b/xen/arch/arm/domain_build.c
> @@ -2967,6 +2967,7 @@ void __init create_domUs(void)
>              .max_evtchn_port =3D -1,
>              .max_grant_frames =3D -1,
>              .max_maptrack_frames =3D -1,
> +            .grant_opts =3D XEN_DOMCTL_GRANT_version_default,

These three will need to be opt_gnttab_max_version which will need
exporting.

See final comment for why "default" mustn't exist.

> diff --git a/xen/common/grant_table.c b/xen/common/grant_table.c
> index e510395d08..f94f0f272c 100644
> --- a/xen/common/grant_table.c
> +++ b/xen/common/grant_table.c
> @@ -1917,11 +1918,33 @@ active_alloc_failed:
>  }
> =20
>  int grant_table_init(struct domain *d, int max_grant_frames,
> -                     int max_maptrack_frames)
> +                     int max_maptrack_frames, unsigned int options)
>  {
>      struct grant_table *gt;
> +    unsigned int max_grant_version =3D options & XEN_DOMCTL_GRANT_versio=
n_mask;
>      int ret =3D -ENOMEM;
> =20
> +    if ( max_grant_version =3D=3D XEN_DOMCTL_GRANT_version_default )
> +        max_grant_version =3D opt_gnttab_max_version;
> +    if ( !max_grant_version )
> +    {
> +        dprintk(XENLOG_INFO, "%pd: invalid grant table version 0 request=
ed\n",
> +                d);
> +        return -EINVAL;
> +    }
> +    if ( max_grant_version > opt_gnttab_max_version )
> +    {
> +        dprintk(XENLOG_INFO,
> +                "%pd: requested grant version (%u) greater than supporte=
d (%u)\n",
> +                d, max_grant_version, opt_gnttab_max_version);
> +        return -EINVAL;
> +    }

I think this wants to live in sanitise_domain_config() along with all
the other auditing of flags and settings.=C2=A0 Also, it can be simplified:

if ( max_grant_version < 1 ||
=C2=A0=C2=A0=C2=A0 max_grant_version > opt_gnttab_max_version )
{
=C2=A0=C2=A0=C2=A0 dprintk(XENLOG_INFO, "Requested gnttab max version %u ou=
tside of
supported range [%u, %u]\n", ...);
}



> +    if ( unlikely(max_page >=3D PFN_DOWN(TB(16))) && is_pv_domain(d) &&
> +         max_grant_version < 2 )
> +        dprintk(XENLOG_INFO,
> +                "%pd: host memory above 16Tb and grant table v2 disabled=
\n",
> +                d);

This is rather more complicated.

For PV, this going wrong in the first place is conditional on CONFIG_BIGMEM=
.
For HVM, it the guest address size, not the host.
For ARM, I don't even know, because I've lost track of which bits of the
ABI are directmap in an otherwise translated domain.

I think it is probably useful to do something about it, but probably not
in this patch.

Perhaps modify domain_set_alloc_bitsize() to impose an upper limit for
the "host memory size matters" cases?

For the guest address size cases, this possibly wants to feed in to the
max policy calculations in the same way that shadow kinda does.

> diff --git a/xen/include/public/domctl.h b/xen/include/public/domctl.h
> index 51017b47bc..0ec57614bd 100644
> --- a/xen/include/public/domctl.h
> +++ b/xen/include/public/domctl.h
> @@ -89,14 +89,20 @@ struct xen_domctl_createdomain {
>      /*
>       * Various domain limits, which impact the quantity of resources
>       * (global mapping space, xenheap, etc) a guest may consume.  For
> -     * max_grant_frames and max_maptrack_frames, < 0 means "use the
> -     * default maximum value in the hypervisor".
> +     * max_grant_frames, max_maptrack_frames and max_gnttab_version < 0
> +     * means "use the default maximum value in the hypervisor".
>       */
>      uint32_t max_vcpus;
>      uint32_t max_evtchn_port;
>      int32_t max_grant_frames;
>      int32_t max_maptrack_frames;
> =20
> +/* Grant version, use low 4 bits. */
> +#define XEN_DOMCTL_GRANT_version_mask    0xf
> +#define XEN_DOMCTL_GRANT_version_default 0xf

This needs to be a toolstack decision, not something in Xen.=C2=A0 This
doesn't fix the case where VMs can't cope with change underfoot.

It is fine for the user say "use the default", but this must be turned
into an explicit 1 or 2 by the toolstack, so that the version(s) visible
to the guest remains invariant while it is booted.

Given the timescales, I'll put together a prereq patch exposing
gnttab-v1/2 in virt_caps for the toolstack to reason over.

~Andrew



From xen-devel-bounces@lists.xenproject.org Fri Oct 29 17:38:38 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Oct 2021 17:38:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.218607.379116 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgVpe-00079N-OL; Fri, 29 Oct 2021 17:38:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 218607.379116; Fri, 29 Oct 2021 17:38:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgVpe-00079G-LG; Fri, 29 Oct 2021 17:38:22 +0000
Received: by outflank-mailman (input) for mailman id 218607;
 Fri, 29 Oct 2021 17:38:21 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=o3mb=PR=citrix.com=Andrew.Cooper3@srs-us1.protection.inumbo.net>)
 id 1mgVpd-00079A-F6
 for xen-devel@lists.xenproject.org; Fri, 29 Oct 2021 17:38:21 +0000
Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 0165481e-38df-11ec-851a-12813bfff9fa;
 Fri, 29 Oct 2021 17:38:19 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0165481e-38df-11ec-851a-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1635529099;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version;
  bh=Va98mAoUX4RdnTjPuz0JsVT0uMCpT203z8ys8F1q6+Y=;
  b=F+nWdpFOHHPBCFCNsI2AMdV+RAD7xovtJG5yp9PxvWMm7ap9t5b6+Gr4
   qA6lgHj/1eF75cCTPQXf3owljTikKZENtmoG34eXUgoOZntw83zUJmsvu
   mbbpoIslJTUZT8H6p/hLysByKaWPNQlN8jeerE+zmW4gXTGIEUd0y/UjX
   Y=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: Jxj92LCB9X4dt5NWRzmxwOJIJgaYvu57mY33RgUbFi/hrXWfnOgA2Mz6QlFLa1gZIwk0JfkOK3
 9XDXx9viw1tP3ThBNb/h/j8kPIcOO13G6iJrW0ahgQqHyjRbWdGk+OO2QTanljuzLcbl9JZbJ7
 cYGUo1zKFps+FEMFIyHgjb3ytDnebtLAlBYDlfjJeN2YYIR2IJZfEest3enL1JVAOjzrRfVcyf
 xP+M8A8xj/9PmhZj6IbyAlKDnbTAbTFCCxHEnNx9cu8tZID5oBqWcZ6ETpcz7scp+L+cOxKIUE
 Gkwet5QIx5prpsr0wdSbWHJg
X-SBRS: 5.1
X-MesageID: 58604854
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:hM4S1a1jsIJYGfznsvbD5Rt2kn2cJEfYwER7XKvMYLTBsI5bpzMGn
 TFJX2/UbvmLYmSnctAlbNixoU5XsZ/Wn4NgT1M6pC1hF35El5HIVI+TRqvS04J+DSFhoGZPt
 Zh2hgzodZhsJpPkS5PE3oHJ9RGQ74nRLlbHILOCan8ZqTNMEn970Es7wb9h2OaEvPDia++zk
 YKqyyHgEAfNNw5cagr4PIra9XuDFNyr0N8plgRWicJj5TcypFFMZH4rHomjLmOQf2VhNrXSq
 9Avbl2O1jixEx8FUrtJm1tgG6EAaua60QOm0hK6V0U+6/TrS+NbPqsTbZIhhUlrZzqhsfNo7
 O5QuJaKaxYHNPLWtMJET0QGDHQrVUFG0OevzXmXtMWSywvNcmf2wuUoB0YzVWEa0r8pWycUr
 6VecW1TKEDY7w616OvTpu1Er8IvNsT0eqgYvWlt12rxBvc6W5HTBa7N4Le02R9t1p4WQaaDO
 6L1bxJPQzuQTSMMPm0JVqkZo8X0n1akbxBX/Qf9Sa0fvDGIkV0ZPKLWGMXRUsyHQ4NShEnwj
 mPZ/UzpDxcCLtudxDGZtHW2iYfnjS79HY4fCrC83vprm0GIgHweDgUMUlm2quX/jVSxM++zM
 GRNpHBo9/JrshX2EJ+tBHVUvUJooDYyeMN0KPA34juv24TevBy1IDEYE2BePYlOWNANeRQm0
 VqAntXMDDNpsaGIRX/1yop4vQ9eKgBOcjdcPX5soR8tpoC5+tlq302nosNLSfbt1rXI9SfML
 ydmRcTUr44YitIXzO2F9FTDjiPESnPhH1NtuFu/so5I6GpEiG+Zi26AtQezARVodt/xory9U
 J4swZX2AAcmVsjlqcB1aL9RdIxFHt7cWNEmvXZhHoM66xOm8GO5cIZb7VlWfRkyb5pYJ2K0M
 BaL42u9AaO/2lPwMMebhKrqUqwXIVXIT4y5Bpg4kPIXOvCdizNrDAkxPBXNjggBYWAnkL0lO
 IfzTCpfJS1yNEiT9xLvH711+eZynkgWnDqPLbimn0XP+efPPxa9FOZaWGZim8hktctoVi2Oq
 I0BXyZLoj0CONDDjt7/qNVOcAtVcSBjbX00wuQOHtO+zsNdMDlJI5fsLXkJIuSJRoxZybXF+
 G+TQEhdxAatjHHLM1zSOHtidKnuTdB0qndiZX4gOlOh2n4CZ4ez7fhAK8trLOd/rOEzn+RpS
 /QletmbBqgdQDrw5DlAP4L2q5ZvdUr3iFvWbTalejU2Y7VpWxfNpo3/ZgLq+SRXVni3uMIyr
 qeOzATeRZZfFQ1uANyPMKCkzk+rvGhbk+V3BhOaLt5WcUTq0Y5rNy2u0aNnf5BScU3On2LI2
 RyXDBEUofj2j7U0qNSZ17qZq4qJEvdlGhYIFWfs8rvrZzLR+XCuwNEcXb/QLyzdTm795I6re
 f5Rk6PnKPQCkVtH79h8HrJswf5s7tfjveYHnAFtHXGNZFW3ELJwZHKB2JAX5KFKw7ZYvyqwW
 16OpYYGaenYZpu9HQ5DPhchY8SCyeoQy2vb4vkCKUnn4DN6oeicWkJIMhjQ0CFQIdOZ6m/+L
 TvNbCLO1zGCtw==
IronPort-HdrOrdr: A9a23:Hn5Dt6iLm5wbu35rcS6A6vG5UXBQXtQji2hC6mlwRA09TyX4ra
 yTdZEgviMc5wx/ZJhNo7690cu7IU80hKQV3WB5B97LNmTbUQCTXeJfBOXZsljdMhy72ulB1b
 pxN4hSYeeAaWSSVPyKgjWFLw==
X-IronPort-AV: E=Sophos;i="5.87,193,1631592000"; 
   d="scan'208";a="58604854"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Ian Jackson
	<iwj@xenproject.org>, Wei Liu <wl@xen.org>
Subject: [PATCH for-4.16 1/2] tools/golang: Regenerate bindings
Date: Fri, 29 Oct 2021 18:37:53 +0100
Message-ID: <20211029173753.22892-1-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <ffd27f87-9e47-12cf-2cfd-1688a19c445f@citrix.com>
References: <ffd27f87-9e47-12cf-2cfd-1688a19c445f@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain

This was missed previously.

Fixes: 1e6706b0d123 ("xen/arm: Introduce gpaddr_bits field to struct xen_domctl_getdomaininfo")
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Ian Jackson <iwj@xenproject.org>
CC: Wei Liu <wl@xen.org>

For 4.16.  Fixing a build-time error in a change already accepted.
---
 tools/golang/xenlight/helpers.gen.go | 2 ++
 tools/golang/xenlight/types.gen.go   | 1 +
 2 files changed, 3 insertions(+)

diff --git a/tools/golang/xenlight/helpers.gen.go b/tools/golang/xenlight/helpers.gen.go
index 2449580badb6..c010f2d3a47f 100644
--- a/tools/golang/xenlight/helpers.gen.go
+++ b/tools/golang/xenlight/helpers.gen.go
@@ -323,6 +323,7 @@ x.CpuTime = uint64(xc.cpu_time)
 x.VcpuMaxId = uint32(xc.vcpu_max_id)
 x.VcpuOnline = uint32(xc.vcpu_online)
 x.Cpupool = uint32(xc.cpupool)
+x.GpaddrBits = byte(xc.gpaddr_bits)
 x.DomainType = DomainType(xc.domain_type)
 
  return nil}
@@ -355,6 +356,7 @@ xc.cpu_time = C.uint64_t(x.CpuTime)
 xc.vcpu_max_id = C.uint32_t(x.VcpuMaxId)
 xc.vcpu_online = C.uint32_t(x.VcpuOnline)
 xc.cpupool = C.uint32_t(x.Cpupool)
+xc.gpaddr_bits = C.uint8_t(x.GpaddrBits)
 xc.domain_type = C.libxl_domain_type(x.DomainType)
 
  return nil
diff --git a/tools/golang/xenlight/types.gen.go b/tools/golang/xenlight/types.gen.go
index b2e8bd1a855e..8c8c481b86f6 100644
--- a/tools/golang/xenlight/types.gen.go
+++ b/tools/golang/xenlight/types.gen.go
@@ -316,6 +316,7 @@ CpuTime uint64
 VcpuMaxId uint32
 VcpuOnline uint32
 Cpupool uint32
+GpaddrBits byte
 DomainType DomainType
 }
 
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Fri Oct 29 17:38:56 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Oct 2021 17:38:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.218608.379128 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgVq2-0007Yl-12; Fri, 29 Oct 2021 17:38:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 218608.379128; Fri, 29 Oct 2021 17:38:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgVq1-0007Ye-U3; Fri, 29 Oct 2021 17:38:45 +0000
Received: by outflank-mailman (input) for mailman id 218608;
 Fri, 29 Oct 2021 17:38:45 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=o3mb=PR=citrix.com=Andrew.Cooper3@srs-us1.protection.inumbo.net>)
 id 1mgVq1-0007YL-1h
 for xen-devel@lists.xenproject.org; Fri, 29 Oct 2021 17:38:45 +0000
Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 560e8e6d-cbc0-4997-9aa0-5f43e99506a1;
 Fri, 29 Oct 2021 17:38:43 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 560e8e6d-cbc0-4997-9aa0-5f43e99506a1
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1635529123;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=jFlSvSoQXHYlF/J2XH+U0cwgBpmb5I4sZztqFOa4CiA=;
  b=iZ0B98LGaWPbfmhZ+rTLy3jQm6iWX7+IKuGHQnFjLfdkb3E3zYP8zvZJ
   KVyuTUAGIX2r5YxvK/S4Dxs+GqLHxOoTUCdZ4ExDUuJG7Jdx8+bD5DrgI
   IKCxOUA9i2RN3DkI2kVbBAHiW6f7a9U6Vh0NiWCy1cu23Ew0btWHLnkKb
   0=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: xWwwCLD4g4P0l1g4+8F8+NU98v8gunFd/joSk8S0cKcxzyMPbV5N5jyuOqdPx7v/H2U6mXK2JD
 D9xSfgK+2TqZQoa3RCdSiVMeGAsPUoD3hZhy1+eT9788UuPQr4qmZTewAQyZFrSiPRDR21EMbe
 F9ZmSFgC52MFQbl0tz9tObT5vqObBI2+pCuDsgVRCpPpydd3+a+dRy8Tb9ES4B7to33KzdWDcs
 C2+3whd/Hc+jnLubX46+gb83dRvhlVD62Wq38l2qafA44rvwJ9hpyx37V9g3SmCW2fBSXCViPL
 JaV41aC35wXdHIP90nzQsLSV
X-SBRS: 5.1
X-MesageID: 56651988
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:QFcxyq59/IOlZxjHISPLLgxRtLXAchMFZxGqfqrLsTDasY5as4F+v
 mZLDWzQPPiJMDH9L9lzaYy0/BwDupPTxtRlHQdkrCkyHi5G8cbLO4+Ufxz6V8+wwmwvb67FA
 +E2MISowBUcFyeEzvuV3zyIQUBUjclkfJKlYAL/En03FVAMpBsJ00o5wrdh2N8w27BVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Zy
 vhTpcWPeDwVb+79iN4SfhlDK35bBPgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALBc/nJo4A/FpnyinUF60OSpHfWaTao9Rf2V/cg+gTQ6iDP
 ptJOVKDajz7YjlBI0UuUqkXxr6wgELbdC8ArXSa8P9fD2/7k1UqjemF3MDuUseRWcxfk0Kcp
 2TH12f0GBcXMJqY0zXt2m2orv/Cm2X8Qo16PL+l8v9nhnWDy2pVDwcZPXOrrP/8hkOgVtZ3L
 00P5jFovaU07FasTNT2Q1u/unHslh8DWfJAHusi8gaPx6HIpQGDCQAsbBRMddgnv88eXiEx2
 xmCmNaBONB0mOTLEzTHrO7S9G7sf3hORYMfWcMaZQko/cm6n7AIskOMf8ZZH4O1leWqPAill
 lhmsxMCr7kUiMcK0YCy8lbGny+gq/D1c+Il2unEdjn6tl0hNeZJc6TtsAKBta8Rc+51W3HY5
 CBc8/Vy+tziGn1keMale+4KAK2yr8iMNDnRkDaD9LFwqmzzpRZPkW1WiQySxXuF0O5YJlcFg
 2eJ4Gu9AaO/2lPwMMebhKrqUqwXIVDIT4iNaxwtRoMmjmJNXAGG5jpyQkWbwnrglkMh+YlmZ
 8zGLZryUCtKUPw9pNZTewv7+eV2rszZ7TiKLa0XMjz9iebODJJrYe5dWLdxUgzJxPzd+1iEm
 zquH8CL1w9eQIXDjtr/quYuwaQxBSFjX/je8pUPHsbae1YOMDxxWpf5nOJ6E6Q4zvs9qws91
 izkMqOu4AGk3iOvxMTjQi0LVY4Dqr4m9i9mZnNwZQ7ANrpKSd/H0ZrzvqAfJdEPnNGPB9YtJ
 xXcU8nfUPlJVBrd/DERMcv0oIB4LUz5jgOSJSu1JjM4esc4FQDO/9bleCrp9TUPUXXr5Zdv/
 eX421OJW4cHSiRjEN3SNKClwWSusCVPg+l1RUbJfIVeIR2+7IhwJiXtpfYrOMVQew7bzz6X2
 l/OUxcVrOXAuaEv99zNifzWpoulCbImTEFbA3Pa/fC9MiyDpjivxopJUeCpezHBVTyrpPX+N
 LsNl/ylaa8JhldHtYZ4Ao1H96Nm6ou9vaJewyRlAG7PMwahBIR/LyTUxsJIrKBMmONU4FPkR
 kKV99BGEryVI8e5QkUJLQ8oY+nfh/EZnj7esaY8LEngvXIl+bOGVQNZPgWWiTwbJ7xwadt3z
 eAksc8Qygq+lht1bYrW0nEKrzyBfi4aTqEqlpAGG4u62AMkx2ZLbYHYFiKrsoqEbM9BMxVyL
 zKZ7EYYa2+wGqYWn6IPKEXw
IronPort-HdrOrdr: A9a23:fADSG6AlDFmXxhrlHemi55DYdb4zR+YMi2TDtnocdfUxSKelfq
 +V88jzuSWbtN9yYhEdcKG7WZVoKEm0nfQZ3WB7B8bAYOCJghrMEKhSqafk3j38C2nf24dmpM
 NdmnFFeb/NMWQ=
X-IronPort-AV: E=Sophos;i="5.87,193,1631592000"; 
   d="scan'208";a="56651988"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, George Dunlap
	<George.Dunlap@eu.citrix.com>, Ian Jackson <iwj@xenproject.org>, Jan Beulich
	<JBeulich@suse.com>, Stefano Stabellini <sstabellini@kernel.org>, Wei Liu
	<wl@xen.org>, =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	Julien Grall <julien@xen.org>, Christian Lindig
	<christian.lindig@citrix.com>, =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?=
	<edvin.torok@citrix.com>
Subject: [PATCH for-4.16 2/2] xen: Report grant table v1/v2 capabilities to the toolstack
Date: Fri, 29 Oct 2021 18:38:13 +0100
Message-ID: <20211029173813.23002-1-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <ffd27f87-9e47-12cf-2cfd-1688a19c445f@citrix.com>
References: <ffd27f87-9e47-12cf-2cfd-1688a19c445f@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

In order to let the toolstack be able to set the gnttab version on a
per-domain basis, it needs to know which ABIs Xen supports.  Introduce
XEN_SYSCTL_PHYSCAP_gnttab_v{1,2} for the purpose, and plumb in down into
userspace.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: George Dunlap <George.Dunlap@eu.citrix.com>
CC: Ian Jackson <iwj@xenproject.org>
CC: Jan Beulich <JBeulich@suse.com>
CC: Stefano Stabellini <sstabellini@kernel.org>
CC: Wei Liu <wl@xen.org>
CC: Roger Pau Monné <roger.pau@citrix.com>
CC: Julien Grall <julien@xen.org>
CC: Christian Lindig <christian.lindig@citrix.com>
CC: Edwin Török <edvin.torok@citrix.com>

For 4.16.  This is useful information:

  xl info virt_caps | grep -q gnttab-v2

is far more coherent for the admin than having to root around in the Xen build
time configuraiton, or command line settings.

Furthermore, it is information necessary for the toolstack to be able to
choose the gnttab version on a per-domain basis (a feature under consideration
for 4.16).

Risks are largely at build time, but adding new PHYSCAPs is formulaic.  In
this case, just using 2 bits in an already existing hypercall.  golang was
generated automatically, while Ocaml has build time ABI checks issues.
---
 tools/golang/xenlight/helpers.gen.go | 4 ++++
 tools/golang/xenlight/types.gen.go   | 2 ++
 tools/include/libxl.h                | 6 ++++++
 tools/libs/light/libxl.c             | 4 ++++
 tools/libs/light/libxl_types.idl     | 2 ++
 tools/ocaml/libs/xc/xenctrl.ml       | 2 ++
 tools/ocaml/libs/xc/xenctrl.mli      | 2 ++
 tools/xl/xl_info.c                   | 6 ++++--
 xen/common/grant_table.c             | 2 +-
 xen/common/sysctl.c                  | 6 ++++++
 xen/include/public/sysctl.h          | 6 +++++-
 xen/include/xen/grant_table.h        | 2 ++
 12 files changed, 40 insertions(+), 4 deletions(-)

diff --git a/tools/golang/xenlight/helpers.gen.go b/tools/golang/xenlight/helpers.gen.go
index c010f2d3a47f..afa44a857a6c 100644
--- a/tools/golang/xenlight/helpers.gen.go
+++ b/tools/golang/xenlight/helpers.gen.go
@@ -3369,6 +3369,8 @@ x.CapShadow = bool(xc.cap_shadow)
 x.CapIommuHapPtShare = bool(xc.cap_iommu_hap_pt_share)
 x.CapVmtrace = bool(xc.cap_vmtrace)
 x.CapVpmu = bool(xc.cap_vpmu)
+x.CapGnttabV1 = bool(xc.cap_gnttab_v1)
+x.CapGnttabV2 = bool(xc.cap_gnttab_v2)
 
  return nil}
 
@@ -3401,6 +3403,8 @@ xc.cap_shadow = C.bool(x.CapShadow)
 xc.cap_iommu_hap_pt_share = C.bool(x.CapIommuHapPtShare)
 xc.cap_vmtrace = C.bool(x.CapVmtrace)
 xc.cap_vpmu = C.bool(x.CapVpmu)
+xc.cap_gnttab_v1 = C.bool(x.CapGnttabV1)
+xc.cap_gnttab_v2 = C.bool(x.CapGnttabV2)
 
  return nil
  }
diff --git a/tools/golang/xenlight/types.gen.go b/tools/golang/xenlight/types.gen.go
index 8c8c481b86f6..31b5af0777d5 100644
--- a/tools/golang/xenlight/types.gen.go
+++ b/tools/golang/xenlight/types.gen.go
@@ -1011,6 +1011,8 @@ CapShadow bool
 CapIommuHapPtShare bool
 CapVmtrace bool
 CapVpmu bool
+CapGnttabV1 bool
+CapGnttabV2 bool
 }
 
 type Connectorinfo struct {
diff --git a/tools/include/libxl.h b/tools/include/libxl.h
index 2e8679dbcb21..54c10f6efe23 100644
--- a/tools/include/libxl.h
+++ b/tools/include/libxl.h
@@ -515,6 +515,12 @@
 #define LIBXL_HAVE_VPMU 1
 
 /*
+ * LIBXL_HAVE_PHYSINFO_CAP_GNTTAB indicates that libxl_physinfo has a
+ * cap_gnttab_v1/2 fields, which indicates the available grant table ABIs.
+ */
+#define LIBXL_HAVE_PHYSINFO_CAP_GNTTAB 1
+
+/*
  * libxl ABI compatibility
  *
  * The only guarantee which libxl makes regarding ABI compatibility
diff --git a/tools/libs/light/libxl.c b/tools/libs/light/libxl.c
index a032723fdecb..a77aa856fdd6 100644
--- a/tools/libs/light/libxl.c
+++ b/tools/libs/light/libxl.c
@@ -405,6 +405,10 @@ int libxl_get_physinfo(libxl_ctx *ctx, libxl_physinfo *physinfo)
     physinfo->cap_vmtrace =
         !!(xcphysinfo.capabilities & XEN_SYSCTL_PHYSCAP_vmtrace);
     physinfo->cap_vpmu = !!(xcphysinfo.capabilities & XEN_SYSCTL_PHYSCAP_vpmu);
+    physinfo->cap_gnttab_v1 =
+        !!(xcphysinfo.capabilities & XEN_SYSCTL_PHYSCAP_gnttab_v1);
+    physinfo->cap_gnttab_v2 =
+        !!(xcphysinfo.capabilities & XEN_SYSCTL_PHYSCAP_gnttab_v2);
 
     GC_FREE;
     return 0;
diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_types.idl
index 608d55a4568d..573bba68ee3a 100644
--- a/tools/libs/light/libxl_types.idl
+++ b/tools/libs/light/libxl_types.idl
@@ -1065,6 +1065,8 @@ libxl_physinfo = Struct("physinfo", [
     ("cap_iommu_hap_pt_share", bool),
     ("cap_vmtrace", bool),
     ("cap_vpmu", bool),
+    ("cap_gnttab_v1", bool),
+    ("cap_gnttab_v2", bool),
     ], dir=DIR_OUT)
 
 libxl_connectorinfo = Struct("connectorinfo", [
diff --git a/tools/ocaml/libs/xc/xenctrl.ml b/tools/ocaml/libs/xc/xenctrl.ml
index addcf4cc593d..ed2924a2b34a 100644
--- a/tools/ocaml/libs/xc/xenctrl.ml
+++ b/tools/ocaml/libs/xc/xenctrl.ml
@@ -123,6 +123,8 @@ type physinfo_cap_flag =
 	| CAP_IOMMU_HAP_PT_SHARE
 	| CAP_Vmtrace
 	| CAP_Vpmu
+	| CAP_Gnttab_v1
+	| CAP_Gnttab_v2
 
 type physinfo =
 {
diff --git a/tools/ocaml/libs/xc/xenctrl.mli b/tools/ocaml/libs/xc/xenctrl.mli
index 0a5ce529e951..d20dc0108dce 100644
--- a/tools/ocaml/libs/xc/xenctrl.mli
+++ b/tools/ocaml/libs/xc/xenctrl.mli
@@ -108,6 +108,8 @@ type physinfo_cap_flag =
   | CAP_IOMMU_HAP_PT_SHARE
   | CAP_Vmtrace
   | CAP_Vpmu
+  | CAP_Gnttab_v1
+  | CAP_Gnttab_v2
 
 type physinfo = {
   threads_per_core : int;
diff --git a/tools/xl/xl_info.c b/tools/xl/xl_info.c
index 2c86b317b702..712b7638b013 100644
--- a/tools/xl/xl_info.c
+++ b/tools/xl/xl_info.c
@@ -210,7 +210,7 @@ static void output_physinfo(void)
          info.hw_cap[4], info.hw_cap[5], info.hw_cap[6], info.hw_cap[7]
         );
 
-    maybe_printf("virt_caps              :%s%s%s%s%s%s%s%s%s\n",
+    maybe_printf("virt_caps              :%s%s%s%s%s%s%s%s%s%s%s\n",
          info.cap_pv ? " pv" : "",
          info.cap_hvm ? " hvm" : "",
          info.cap_hvm && info.cap_hvm_directio ? " hvm_directio" : "",
@@ -219,7 +219,9 @@ static void output_physinfo(void)
          info.cap_shadow ? " shadow" : "",
          info.cap_iommu_hap_pt_share ? " iommu_hap_pt_share" : "",
          info.cap_vmtrace ? " vmtrace" : "",
-         info.cap_vpmu ? " vpmu" : ""
+         info.cap_vpmu ? " vpmu" : "",
+         info.cap_gnttab_v1 ? " gnttab-v1" : "",
+         info.cap_gnttab_v2 ? " gnttab-v2" : ""
         );
 
     vinfo = libxl_get_version_info(ctx);
diff --git a/xen/common/grant_table.c b/xen/common/grant_table.c
index e510395d088e..a20319b22abc 100644
--- a/xen/common/grant_table.c
+++ b/xen/common/grant_table.c
@@ -178,7 +178,7 @@ static int parse_gnttab_max_maptrack_frames(const char *arg)
 #define GNTTAB_MAX_VERSION 2
 #endif
 
-static unsigned int __read_mostly opt_gnttab_max_version = GNTTAB_MAX_VERSION;
+unsigned int __read_mostly opt_gnttab_max_version = GNTTAB_MAX_VERSION;
 static bool __read_mostly opt_transitive_grants = true;
 
 static int __init parse_gnttab(const char *s)
diff --git a/xen/common/sysctl.c b/xen/common/sysctl.c
index f2dab722b683..1ad3c29351db 100644
--- a/xen/common/sysctl.c
+++ b/xen/common/sysctl.c
@@ -12,6 +12,7 @@
 #include <xen/sched.h>
 #include <xen/domain.h>
 #include <xen/event.h>
+#include <xen/grant_table.h>
 #include <xen/domain_page.h>
 #include <xen/trace.h>
 #include <xen/console.h>
@@ -283,6 +284,11 @@ long do_sysctl(XEN_GUEST_HANDLE_PARAM(xen_sysctl_t) u_sysctl)
         if ( vpmu_is_available )
             pi->capabilities |= XEN_SYSCTL_PHYSCAP_vpmu;
 
+        if ( opt_gnttab_max_version >= 1 )
+            pi->capabilities |= XEN_SYSCTL_PHYSCAP_gnttab_v1;
+        if ( opt_gnttab_max_version >= 2 )
+            pi->capabilities |= XEN_SYSCTL_PHYSCAP_gnttab_v2;
+
         if ( copy_to_guest(u_sysctl, op, 1) )
             ret = -EFAULT;
     }
diff --git a/xen/include/public/sysctl.h b/xen/include/public/sysctl.h
index 3e53681b4368..55252e97f230 100644
--- a/xen/include/public/sysctl.h
+++ b/xen/include/public/sysctl.h
@@ -104,8 +104,12 @@ struct xen_sysctl_tbuf_op {
 /* The platform supports vPMU. */
 #define XEN_SYSCTL_PHYSCAP_vpmu          (1u << 7)
 
+/* Xen supports the Grant v1 and/or v2 ABIs. */
+#define XEN_SYSCTL_PHYSCAP_gnttab_v1     (1u << 8)
+#define XEN_SYSCTL_PHYSCAP_gnttab_v2     (1u << 9)
+
 /* Max XEN_SYSCTL_PHYSCAP_* constant.  Used for ABI checking. */
-#define XEN_SYSCTL_PHYSCAP_MAX XEN_SYSCTL_PHYSCAP_vpmu
+#define XEN_SYSCTL_PHYSCAP_MAX XEN_SYSCTL_PHYSCAP_gnttab_v2
 
 struct xen_sysctl_physinfo {
     uint32_t threads_per_core;
diff --git a/xen/include/xen/grant_table.h b/xen/include/xen/grant_table.h
index 41713e2726e9..9ee830cfd0ab 100644
--- a/xen/include/xen/grant_table.h
+++ b/xen/include/xen/grant_table.h
@@ -32,6 +32,7 @@ struct grant_table;
 
 #ifdef CONFIG_GRANT_TABLE
 
+extern unsigned int opt_gnttab_max_version;
 extern unsigned int opt_max_grant_frames;
 
 /* Create/destroy per-domain grant table context. */
@@ -63,6 +64,7 @@ int gnttab_acquire_resource(
 
 #else
 
+#define opt_gnttab_max_version 0
 #define opt_max_grant_frames 0
 
 static inline int grant_table_init(struct domain *d,
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Fri Oct 29 18:07:14 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Oct 2021 18:07:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.218621.379138 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgWHI-0002eT-BB; Fri, 29 Oct 2021 18:06:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 218621.379138; Fri, 29 Oct 2021 18:06:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgWHI-0002eM-8E; Fri, 29 Oct 2021 18:06:56 +0000
Received: by outflank-mailman (input) for mailman id 218621;
 Fri, 29 Oct 2021 18:06:54 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=o3mb=PR=citrix.com=Andrew.Cooper3@srs-us1.protection.inumbo.net>)
 id 1mgWHF-0002eG-TI
 for xen-devel@lists.xenproject.org; Fri, 29 Oct 2021 18:06:54 +0000
Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id ac633acc-6437-42ed-acfe-3bf7d5722788;
 Fri, 29 Oct 2021 18:06:52 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ac633acc-6437-42ed-acfe-3bf7d5722788
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1635530812;
  h=to:cc:references:from:subject:message-id:date:
   in-reply-to:content-transfer-encoding:mime-version;
  bh=A5WuY3w9P0X75udJidifE1b4JH4cz+UyYg700I+FC5g=;
  b=JoDH9TGYmOBoZEn3aSP5Hdg6eGs7KIMe5TKkGgGOk+zyqroTwPki3YNk
   XE1vKK1AqrurAjCuXAOMbppPjQmAiNyQC2Re9fpMwx5+I5JSZ5NGjgM7g
   o/qyxr81/zJ7k1N/OOvyQSklfnnYkMBQtywBabFgpmeAsQ8kgJHmjiDn2
   g=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: Al0/8wIbmijGEfX3bWy2gkfDkCCCwVEnmVXDy5TkJwJjDeakI0BRkW19esKUNCDa7qWusTWy07
 l2dhI0Gq//UQrU82/z0LA7G/QJ6TlxD00aXgWyjMQqtFalKkZ3RhgB5IHmAwwyGn/IoifgVML8
 +oSMWaktcANi+jT7TIGzceJnVeF/ChocVtTtElYJfSNXI0PzVn2bMiNqtxJmiMAvJUJ6gZOB8p
 k8XsxU4/p7WC6f6h9invz/srHXhWQMo6a/Z2xHRzYC4qDY2QiPeJUnMIlikDSuzCgx4g2vmUZI
 57cOfLrjlRFlcCeQps6/lOtw
X-SBRS: 5.1
X-MesageID: 56695960
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:uXsC0K4m0t8KD2Dq+jFwQgxRtMrAchMFZxGqfqrLsTDasY5as4F+v
 jNLCD+BPPyNNmShetskOdm0/UsO6MCEzocxHlQ/qSBkHi5G8cbLO4+Ufxz6V8+wwmwvb67FA
 +E2MISowBUcFyeEzvuV3zyIQUBUjclkfJKlYAL/En03FVAMpBsJ00o5wrdh2N8w27BVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Z4
 /RujMScbCYSBKjNp7UecxBJORxxMvgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALBc/nJo4A/FpnyinUF60OSpHfWaTao9Rf2V/cg+gTQ6iPO
 ptHMVKDajz+UyZFZw4aJqkGwuCDjELlIgF7pRGK8P9fD2/7k1UqjemF3MDuUv6gSNhRn02Yj
 nnb5Gm/CRYfXPSPxDzA/n+yi+vnmSLgRJlUBLC+7uRtglCY2ioUEhJ+fVqko9Gph0imQdVdJ
 kcIvC00osAa60iDXtT7GRqirxa5UgU0AoQKVbdgsUfUl/SSs13x6nU4oiBpQ/0FjZcaYB0R7
 FqIoILqJTV+moCaRifInluLlg+aNS8QJG4EQCYLSwoZ/tXuyL0OYgLzosVLS/Ht0IWkcd3k6
 3XT9nJm3uRM5SIe//zjpQivvt66mnTeoufZDC3sVWW58hgxWoehY4G5gbQwxacddNjHJrVtU
 X5tpiR/0AzsJc3S/MBuaL9UdF1M2xpjGGeB6bKIN8J4nwlBA1b5IehtDMhWfS+FyPosdz7ze
 1P0sghM/pJVN3bCRfYpON/tV5p3kPi5TY6NuhXogjxmOMUZmOivp3gGWKJt9zq1zBhEfV8XY
 M/znTmQ4YYyVv08kWveqxY12r433CEurV4/trigpylLJYG2PSbPIZ9caQPmRrlgsMus/VWEm
 /4CZpDi40gOD4XDjtz/rNd7waYidiNgW/gbaqV/K4a+H+aRMDh6VqKKnu95I+SIXc19z4/1w
 510YWcBoHLXjnzbMwSaLHdlbbLkR5FkqnwneycrOD6VN7ILOO5DNY8TKMk6e6cJ7utmwaImR
 vUJYZzYUP9OVi7G63IWapyk9N5ucxGihASvOSu5YWdgI848FlKRotK0LBHy8CQuDzassZdsq
 bOXyQ6GE4EIQB5vDZiKZav3nU+xp3UUhMl7Q1DMfotIYEzp/YUzc37xg/Y7LtsiMxLGwjfGh
 Q+aDQ1B/bvGopMv8cmPjqeB9t/7H+x7F0tcPm/a8bfpanWKojv9mddNCb/acyrcWWX4/LSZS
 d9Ul/ysYucamFtqspZnF+o5x6wJ+Nay9aRRyR5pHSuXYg3zWK9gOHSPweJGqrZJmu1CoQKzV
 0+CpotaNLGONJ+3GVIdPlN4POGK1PVSkTjO9/UlZk794XYvrraAVExTOTiKiTBcc+QpYN90n
 795tZ5E8RG7hzorLs2C33Jd+Gm7J3AdV7kq68MBC4jxhwt3klxPbPQw0MMtDE1jvzmUDnQXH
 w==
IronPort-HdrOrdr: A9a23:OUPvE6FY4PRmorvCpLqEEseALOsnbusQ8zAXPiBKJCC9vPb5qy
 nOpoV+6faQslwssR4b9uxoVJPvfZq+z+8R3WByB8bAYOCOggLBQL2KhbGI/9SKIVydygcy78
 Zdm6gVMqyMMbB55/yKnDVRxbwbsaa6GKPDv5ah8590JzsaDJ2Jd21Ce32m+ksdfnghObMJUK
 Cyy+BgvDSadXEefq2AdwM4t7iqnayzqHr+CyR2fyIa1A==
X-IronPort-AV: E=Sophos;i="5.87,193,1631592000"; 
   d="scan'208";a="56695960"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=QUWNq74NuKqu/uGY0Fm2tlQ2sBMoHkmAMjRw6B+S5hm25eZOpfAtw5AWaedYsa0jBGWClhKqk0Udj1myb62UZCspzqtrBIvCN7Zd/8ZmLh+eHGz5a+yLEezZ5Rna9xAoMI8BKIBUr0R88DIge14TTj3gUWCNQlx5qRRwNVkuxmwQecI4lpnNPonHGGO+x+oX9th783E+lr36/+RDlnHKxjqBQFjnc58dCR8l+SNfCzVZP9erGlMASqC6vSPgbRqEOet9uyU73LZGt5M7DJYrkzgaWyRjx0myMcN/h6IUwOJYeFtJCdrzUK6JkgO7o2XIXogQFGpyysTwwmtx4U5EKQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=F8tuQP1wCJKzmiVJdXPyz0Wg+Sw6PLxCydlB4nvomCY=;
 b=HLGgIzkZs3XaTpI6RbIbhQofFmW8tZHkRS4L5zdYimcgxAcUgyGL6GBzJwYpx9RNaxd4+3QzU+GXm8Cnmo+mNn48cFzzZ7ifFocKdNWUvCbU3hUrZGAVqDjV1uLgE/C4/UeTvEwZ+A01aztJwh+JoxFdc2JzZqGsQkeLKtd824mAzcTkPqWGN2hXCsB8PlkC/kR9+DlJaYopEQaNZCqioaO6IB1ede8vUnHODDd7DUEn7w+9NUj+KeAVaoBk7KmZS5X0RmwoXfiFQaY5Y9nlZGK2FhgEkpPsiRaqQfj534At+u3X3KrZlskzY30kMgyORYWG+SJSYClJCJLl+gy1/g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=F8tuQP1wCJKzmiVJdXPyz0Wg+Sw6PLxCydlB4nvomCY=;
 b=ZynPOsTHPk/GgxzOYwqz9s5ilarm+bXJmgN/Kg5eiqLl7HBFqY9E/YCgUPwhfFtY9KiOyYZTdDsOUSxP6Q7zGZIGCIYzL4oUBwD0qHtwctNp/m568aIWsR37Dw1Z5owZSk+76g7ZzjUc6C4bVQER3IfGr4en8c1EbQS5xD9qm0Y=
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>, Jan Beulich
	<JBeulich@suse.com>, Wei Liu <wl@xen.org>, Ian Jackson <iwj@xenproject.org>
References: <20211027200713.22625-1-andrew.cooper3@citrix.com>
 <YXpRzHEawUZEU87h@Air-de-Roger>
 <64788530-a18c-332f-c287-84478a200816@citrix.com>
 <YXqlEQWk1HGNLKq3@Air-de-Roger>
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH] x86/passthrough: Fix hvm_gsi_eoi() build with GCC 12
Message-ID: <99c451d7-4a7f-8dd0-17f6-92b2153d0afe@citrix.com>
Date: Fri, 29 Oct 2021 19:06:43 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <YXqlEQWk1HGNLKq3@Air-de-Roger>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Content-Language: en-GB
X-ClientProxiedBy: LO4P265CA0004.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:2ad::13) To BYAPR03MB3623.namprd03.prod.outlook.com
 (2603:10b6:a02:aa::12)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 5ab75cf0-f659-4073-5bff-08d99b06e025
X-MS-TrafficTypeDiagnostic: SJ0PR03MB5743:
X-Microsoft-Antispam-PRVS: <SJ0PR03MB5743D14667A7B3E892550E27BA879@SJ0PR03MB5743.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: um9CjU1LAvPrzf9JxInCzOminHBZyfjSrQbHcVzXFtF9hkzKlBdCiJ+m24NVpo+YWBj+Bru4RFSuM89NViD+OOb+fxJUuwVBM5a6VxDN9sbfP1OBsxMc0l3eoub0cWYtmWKoMpD8VqL8NuZLfMhCLCuof681Y4/foxhlCVeOYcd2IQpb9hcDBE3jmMoQZfrun+h1HWXu12/WXGFyrcvkfRkNcuFuhBv2cqfyyUbC4DX9aV9Lyo31dONr6w5biQvdTq+h4OlrwGKoT4gPqG06Ho8O+U4XM0XjNBy4UT/B1Ye7JFD0WIaE05O0iuFN3IxD5v4EDeVPCUxcc4VTUfUVQz9u3aNV8tvUR5NNn0Chr2V1kVz8Sk1vDOTZl/dj69w4W2jBedAm5BEaD/q9Ot9H0Rp65fKt6BdzIvAoNFmLoKWF3rAQxIhcotfeq+z1L2PYD9GcH8GgBhQMEzkQnY8c3FsDOyVXG19hUqJGknKAIJEFzJuixlpXlRLDU3jUb2AdED9FfQo/3zDHFXCYm5EYJxgtfdngwfhYVe2SIN63W24K/FSNdv/SzXDTrngdMxQ8vc8HM/Iu6FomAQRdG4jH/TXqz694OUZKE4oYaM2WhGYq/aaMOwNGvqLG0VnIOjyagRWLuwLgabsMgBihfhCVebxZIdW3FAiVSuZgFHJ2HAjbIVF4++jrhJrICzxRk5+WGKDrwgjNqlmAVthTzi+T9T84d1j+CJDjJiQ1cvZBjyOp/QeTOSGdXS5EN0IUjLnZ
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(6486002)(6666004)(86362001)(31696002)(4326008)(2616005)(956004)(38100700002)(82960400001)(26005)(508600001)(66476007)(2906002)(66556008)(66946007)(37006003)(36756003)(53546011)(8936002)(6636002)(186003)(6862004)(16576012)(8676002)(54906003)(5660300002)(316002)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UlhwbVdTQVhIWVRrWGVuWHlJeUhBTlZoN0dPZDFPclg5Z2k5T09VS3dVU2hU?=
 =?utf-8?B?bDF0elNrZ1ovWjJpMkNyYXkyQm1EY1cxTkZmK3NLU3c2N2loaFB3dnV2S0s2?=
 =?utf-8?B?REliNHFVeEVOVTJ2WTFiZERHeGx5MFN1dHYvVE9RVEdCN2dYREppZVE3dnFO?=
 =?utf-8?B?VGtjb3pROVdLTFE5Lzh5K284NWhuMkhyYzhnWUk1QllnTGRLYnc2MEp4c0d3?=
 =?utf-8?B?WkdCeGdvbkhDNTkwM0ExK3BNVnZsWDlLU2VTOU5uYkR3QW1SbE1uWUVXZUEy?=
 =?utf-8?B?TE0xa2F1RG5JcnhTT2RGeFhoV0ErbmNKa0R2WnRkMXdEcWZlNVdIaFBqa2di?=
 =?utf-8?B?S2ZyZkR4bFJObVdnSmxMTzFCZG9wWGRwN2lXam9sYVZlNTVWMnR4K1Awemt2?=
 =?utf-8?B?TkxXWVlOZ1lWTXo5SEIxKzJPSHdvVVhCUDZLbk5UaDFram9PSHYyRlp4SDZm?=
 =?utf-8?B?V29VZXgxNFBVTnR1TlI0VHlQTVY4b0JQQnZOejdVYlVrcHM0N1dseVNlV0pi?=
 =?utf-8?B?bnY1UlVBR2YwSlM1eTFlV0ZLM1Z2WXVyaXc3R2FqSXQrb214UCtXM2JZT3Z4?=
 =?utf-8?B?RzI4Vm9aTk03aEp4Mjd1K1NqdmkrUjZQbEVUU0o1dk51bjRpYTc3OFdNMU1L?=
 =?utf-8?B?WkNIaG54aWN4WEMzeEVGS00rMnF1cUYvbzY0RHBMY0QzZUFlQjltaEtYVW5i?=
 =?utf-8?B?UlNnWC93S0ZRRzFGVUIvRHdUNmxRZXd0R1RZZjJMbzROWHg5TkYwNk1EOHVR?=
 =?utf-8?B?Zmh2Z3hrRUxtU3BraFZvdVRRNVV4dUxoS3FxNnFXbVFoRXdyWDBqa3pyRDRN?=
 =?utf-8?B?cjdVdk83bVE5YWJGd0ZTQ2xtZ0ZzREw0YTM0d211Wk1QL1MvRStyMGVCcUNv?=
 =?utf-8?B?anoxa2ZjcHZXeEpVRlpFcDZHVThEZ1NGNngrMy9vaWNwVnpNVnZKZndhc0hi?=
 =?utf-8?B?TTRVY2orZU5mKzBhaktTRFV1WllnM2hDYXIzcmVvQS8rTkFyaUlqR2xaOFZZ?=
 =?utf-8?B?TTVOTFJMeHN5WEF0TzJyM1UxdVRwTEpaV2pPbHNtMDhCQnk4ekdGdUd6bEJC?=
 =?utf-8?B?S3EwN2dFckZLK2N3MHRsNU8xRnJyUmxNcXRtWFB5NksybEEyaDFvVGl5c0Nt?=
 =?utf-8?B?eFlBMjNtZDdIYk5VWVdHOXBFZzdGQW56QTA2Q2g0czdJVHN1Zk9qdDc4WWlu?=
 =?utf-8?B?U3VMWjNzUGRjckhqYVBSakpRUFdXRXc5cSs1dlIyNVI5R2xCZExIS1ZuNys1?=
 =?utf-8?B?NGE0bUhhY2hJWGkya1BYZitKWE0rMkZHTFdEeGlUU2hXWWZDTm51QVk0TThw?=
 =?utf-8?B?enpaNjd3aUU2K1hnbE44VjBqMnU2QWZNN25BSEVXaGluVFpFbDhFSy92b3Vp?=
 =?utf-8?B?eG00OG9mSHRSeHV4T2ZWMjJIUStuSFdZRzY0K3g1dDBXbkIxbXNNNmlLQXQ2?=
 =?utf-8?B?MXJCRXZpZ1JZTGI0ZEQ0b3BibmV5ZWVwVk5aVGQvd0hCdzFVMERDTjMrVXQw?=
 =?utf-8?B?OGdtZEtnQ25DWHdpRnRVWnZqM0dWd3l5c2x5QkNWS1l5TW43MTd0dDhpWmxE?=
 =?utf-8?B?eTNLV0pwSTlqTkNGU2FFQlAvTjBRZlFkVUltakpLOVNpc05JTXp3NUFrQWYw?=
 =?utf-8?B?Z0tFeTRUSU1JeVJxdjFQRXRuYTlRaXZodFNJbXhhUGMrVmkzM04yTGNRdXg4?=
 =?utf-8?B?U0tHVUFmQWFuRWR3WEszSTd0SkhsZEpSWUd4c0I4aXJHMnpJTzRQZGJuTlZj?=
 =?utf-8?B?SHVFbmhMS0JwK3Q4ZHV5MitPcGFzc2NnSUdGeE0xOG5RTDNCS2JScXo0YU54?=
 =?utf-8?B?VXhpOWZTMEZlZXRqcHZQSHIzanpsQThJZnJiT2dUMmVhUDlBTGw3SndwS0R1?=
 =?utf-8?B?enB4MnZ1VEw4bGJpeUNoUzVOc21BZE9kSDBPRk1DbE9kY2hTS3BCWDNwKzdU?=
 =?utf-8?B?Ykh5QnB5bHluZkZzOWh1aERKbEhhQm1kdXFLM3crM1NpRWcyUUhBWFFmU2pR?=
 =?utf-8?B?VlVjU3Jreis3ekpjNW5qRlNhMGdENGVYZTRwOTI2L2xWZXRSbHpEd21SOElL?=
 =?utf-8?B?cGtxU3R5WS93dHlDTWI2b1MyTC9oOWhOWGZ2dFRnOHF6dmkwT3BRVEhsd2pR?=
 =?utf-8?B?U0NrSDBrWWpGSW1ORnMxN3BLTENyQUx2eCtXMXNIOFNFYnAxWjgxUHZuUGdT?=
 =?utf-8?B?eUphM0oxdjhJZm1LbWxJdGhPN2hpYkFXWGI4QXRhOFRxWVlheXVpWFN5SFlq?=
 =?utf-8?B?ZCszc2t0dDZaRFhJNElQNDI4TTV3PT0=?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 5ab75cf0-f659-4073-5bff-08d99b06e025
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Oct 2021 18:06:48.4398
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: EH69N2NSbbOSTWc9EcmqYYPHH0iB9UXPpagt3k6ty0TMTnGzGgypkIbpR8YA5fQ44j/QB8GWxg5r7pkQhsh+gP79V/LjZcH4Kovrwue6RHI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5743
X-OriginatorOrg: citrix.com

On 28/10/2021 14:26, Roger Pau Monn=C3=A9 wrote:
> On Thu, Oct 28, 2021 at 01:15:13PM +0100, Andrew Cooper wrote:
>> On 28/10/2021 08:31, Roger Pau Monn=C3=A9 wrote:
>>> On Wed, Oct 27, 2021 at 09:07:13PM +0100, Andrew Cooper wrote:
>>>> GCC master (nearly version 12) complains:
>>>>
>>>>   hvm.c: In function 'hvm_gsi_eoi':
>>>>   hvm.c:905:10: error: the comparison will always evaluate as 'true' f=
or the
>>>>   address of 'dpci' will never be NULL [-Werror=3Daddress]
>>>>     905 |     if ( !pirq_dpci(pirq) )
>>>>         |          ^
>>>>   In file included from /local/xen.git/xen/include/xen/irq.h:73,
>>>>                    from /local/xen.git/xen/include/xen/pci.h:13,
>>>>                    from /local/xen.git/xen/include/asm/hvm/io.h:22,
>>>>                    from /local/xen.git/xen/include/asm/hvm/domain.h:27=
,
>>>>                    from /local/xen.git/xen/include/asm/domain.h:7,
>>>>                    from /local/xen.git/xen/include/xen/domain.h:8,
>>>>                    from /local/xen.git/xen/include/xen/sched.h:11,
>>>>                    from /local/xen.git/xen/include/xen/event.h:12,
>>>>                    from hvm.c:20:
>>>>   /local/xen.git/xen/include/asm/irq.h:140:34: note: 'dpci' declared h=
ere
>>>>     140 |             struct hvm_pirq_dpci dpci;
>>>>         |                                  ^~~~
>>>>
>>>> The location marker is unhelpfully positioned and upstream may get aro=
und to
>>>> fixing it.  The complaint is intended to be:
>>>>
>>>>   if ( !((pirq) ? &(pirq)->arch.hvm.dpci : NULL) )
>>>>                   ^~~~~~~~~~~~~~~~~~~~~~
>>>>
>>>> which is a hint that the code is should be simplified to just:
>>>>
>>>>   if ( !pirq )
>>> I likely need more coffee, but doesn't this exploit how the macro
>>> (pirq_dpci) is currently coded?
>> The way pirq_dpci() is currently coded, this is nonsense, which GCC is
>> now highlighting.
>>
>> It would be a very different thing if the logic said:
>>
>> struct pirq *pirq =3D pirq_info(d, gsi);
>> struct hvm_pirq_dpci *dpci =3D pirq_dpci(pirq);
>>
>> /* Check if GSI is actually mapped. */
>> if ( !dpci )
>> =C2=A0=C2=A0=C2=A0 return;
>>
>> but it doesn't. Getting a non-null pirq pointer from pirq_info(d, gsi)
>> does identify that the GSI is mapped, and the dpci nested structure is
>> not used in this function.=C2=A0 I would expect this property to remain =
true
>> even if we alter the data layout.
> I think we have further assertions that this will be true:
>
>  1. d can only be an HVM domain given the callers of the function.
>  2. The pirq struct is obtained from the list of pirqs owned by d.
>
> In which case it's assured that the pirq will always have a dpci. I
> think it might be better if the check was replaced with:
>
> if ( !is_hvm_domain(d) || !pirq )
> {
>     ASSERT(is_hvm_domain(d));
>     return;
> }
>
> Here Xen cares that pirq is not NULL and that d is an HVM domain
> because hvm_gsi_deassert will assume so.

We're several calls deep in an hvm-named codepath, called exclusively
from logic in arch/x86/hvm/

is_hvm_domain() is far from free, and while I'm in favour of having
suitable sanity checks in appropriate places, I don't even think:

{
=C2=A0=C2=A0=C2=A0 struct pirq *pirq =3D pirq_info(d, gsi);

=C2=A0=C2=A0=C2=A0 ASSERT(is_hvm_domain(d));

=C2=A0=C2=A0=C2=A0 if ( !pirq )
=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 return;
...

would be appropriate in this case.

~Andrew



From xen-devel-bounces@lists.xenproject.org Fri Oct 29 20:27:20 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Oct 2021 20:27:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.218641.379149 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgYSd-0007M3-6z; Fri, 29 Oct 2021 20:26:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 218641.379149; Fri, 29 Oct 2021 20:26:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgYSd-0007Lw-44; Fri, 29 Oct 2021 20:26:47 +0000
Received: by outflank-mailman (input) for mailman id 218641;
 Fri, 29 Oct 2021 20:26:46 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mgYSc-0007Lm-IA; Fri, 29 Oct 2021 20:26:46 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mgYSc-0002dy-AD; Fri, 29 Oct 2021 20:26:46 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mgYSb-0002PA-Ti; Fri, 29 Oct 2021 20:26:46 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mgYSb-0000Ik-TD; Fri, 29 Oct 2021 20:26:45 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=oEQy+c0KitFH2Y4u44QQMPv3otxvB1d6TLKN61Idiks=; b=jLnM0YAT1X1bvLq4uzNX9BIY0q
	R+CmdQFRGHdvjCiU4cmKbb9EJsTGL00O6DkkUdkChGx9qSzOX5x+m6L8wvSez9N9GtvgO9guof6Ez
	7Rjzs6vpAlCfnVf1Ypv+j6jftNpicoy2SWNd/OmaY0rv2G/LNAEXLoYeAxOVR56A22p4=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165936-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 165936: regressions - FAIL
X-Osstest-Failures:
    qemu-mainline:build-i386-xsm:xen-build:fail:regression
    qemu-mainline:build-i386:xen-build:fail:regression
    qemu-mainline:build-armhf:xen-build:fail:regression
    qemu-mainline:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:heisenbug
    qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:guest-start/debianhvm.repeat:fail:heisenbug
    qemu-mainline:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-amd:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-pair:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-freebsd10-i386:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-freebsd10-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-coresched-i386-xl:build-check(1):blocked:nonblocking
    qemu-mainline:build-armhf-libvirt:build-check(1):blocked:nonblocking
    qemu-mainline:build-i386-libvirt:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-intel:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-shadow:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-vhd:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=c52d69e7dbaaed0ffdef8125e79218672c30161d
X-Osstest-Versions-That:
    qemuu=50352cce138ef3b30c1cda28a4df68fff5da3202
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 29 Oct 2021 20:26:45 +0000

flight 165936 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165936/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-i386-xsm                6 xen-build                fail REGR. vs. 165682
 build-i386                    6 xen-build                fail REGR. vs. 165682
 build-armhf                   6 xen-build                fail REGR. vs. 165682

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-xl-rtds 20 guest-localmigrate/x10 fail in 165933 pass in 165936
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 20 guest-start/debianhvm.repeat fail pass in 165933

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl           1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-credit2   1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-cubietruck  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-multivcpu  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-rtds      1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-vhd       1 build-check(1)               blocked  n/a
 test-amd64-i386-qemuu-rhel6hvm-amd  1 build-check(1)               blocked n/a
 test-amd64-i386-pair          1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-freebsd10-i386  1 build-check(1)               blocked  n/a
 test-amd64-i386-freebsd10-amd64  1 build-check(1)               blocked  n/a
 test-amd64-coresched-i386-xl  1 build-check(1)               blocked  n/a
 build-armhf-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-credit1   1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-arndale   1 build-check(1)               blocked  n/a
 test-amd64-i386-qemuu-rhel6hvm-intel  1 build-check(1)             blocked n/a
 test-amd64-i386-xl            1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-pvshim     1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-qemuu-debianhvm-amd64  1 build-check(1)         blocked n/a
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow  1 build-check(1)  blocked n/a
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm  1 build-check(1)      blocked n/a
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 1 build-check(1) blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a
 test-amd64-i386-xl-qemuu-win7-amd64  1 build-check(1)              blocked n/a
 test-amd64-i386-xl-qemuu-ws16-amd64  1 build-check(1)              blocked n/a
 test-amd64-i386-xl-shadow     1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-vhd        1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-xsm        1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165682
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165682
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165682
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 qemuu                c52d69e7dbaaed0ffdef8125e79218672c30161d
baseline version:
 qemuu                50352cce138ef3b30c1cda28a4df68fff5da3202

Last test of basis   165682  2021-10-19 21:09:14 Z    9 days
Failing since        165694  2021-10-20 18:09:12 Z    9 days   22 attempts
Testing same since   165920  2021-10-27 21:39:18 Z    1 days    5 attempts

------------------------------------------------------------
People who touched revisions under test:
  Alistair Francis <alistair.francis@wdc.com>
  Andrew Jones <drjones@redhat.com>
  Ani Sinha <ani@anisinha.ca>
  BALATON Zoltan <balaton@eik.bme.hu>
  Bin Meng <bmeng.cn@gmail.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Cédric Le Goater <clg@kaod.org>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  David Gibson <david@gibson.dropbear.id.au>
  David Hildenbrand <david@redhat.com>
  Dr. David Alan Gilbert <dgilbert@redhat.com>
  Eric Auger <eric.auger@redhat.com>
  Eugenio Pérez <eperezma@redhat.com>
  Frank Chang <frank.chang@sifive.com>
  Gavin Shan <gshan@redhat.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Greg Kurz <groug@kaod.org>
  Gustavo Romero <gromero@linux.ibm.com>
  Igor Mammedov <imammedo@redhat.com>
  Jason Wang <jasowang@redhat.com>
  John Wang <wangzhiqiang02@inspur.com>
  John Wang <wangzq.jn@gmail.com>
  Laurent Vivier <laurent@vivier.eu>
  Laurent Vivier <lvivier@redhat.com>
  Luc Michel <lmichel@kalray.eu>
  Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
  Markus Armbruster <armbru@redhat.com>
  Matheus Ferst <matheus.ferst@eldorado.org.br>
  Mathieu Poirier <mathieu.poirier@linaro.org>
  Michael S. Tsirkin <mst@redhat.com>
  Mingwang Li <limingwang@huawei.com>
  Oğuz Ersen <oguzersen@protonmail.com>
  Peter Krempa <pkrempa@redhat.com>
  Philipp Tomsich <philipp.tomsich@vrull.eu>
  Philippe Mathieu-Daudé <f4bug@amsat.org>
  Philippe Mathieu-Daudé <philmd@redhat.com>
  Richard Henderson <richard.henderson@linaro.org>
  Shuuichirou Ishii <ishii.shuuichir@fujitsu.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Thomas Huth <thuth@redhat.com>
  Tong Ho <tong.ho@xilinx.com>
  Travis Geiselbrecht <travisg@gmail.com>
  Vincent Palatin <vpalatin@rivosinc.com>
  Vivek Goyal <vgoyal@redhat.com>
  Xueming Li <xuemingl@nvidia.com>
  Yanan Wang <wangyanan55@huawei.com>
  Yifei Jiang <jiangyifei@huawei.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               fail    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          blocked 
 test-amd64-i386-xl                                           blocked 
 test-amd64-coresched-i386-xl                                 blocked 
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  blocked 
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       blocked 
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           blocked 
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     blocked 
 test-amd64-i386-freebsd10-amd64                              blocked 
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          blocked 
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          blocked 
 test-armhf-armhf-xl-arndale                                  blocked 
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  blocked 
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  blocked 
 test-armhf-armhf-xl-cubietruck                               blocked 
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         blocked 
 test-amd64-i386-freebsd10-i386                               blocked 
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         blocked 
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                blocked 
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         blocked 
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 blocked 
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    blocked 
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     blocked 
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             fail    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              blocked 
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    blocked 
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      blocked 
 test-amd64-i386-xl-vhd                                       blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 4111 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Oct 29 21:47:09 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Oct 2021 21:47:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.218650.379168 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgZhu-0006ey-8g; Fri, 29 Oct 2021 21:46:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 218650.379168; Fri, 29 Oct 2021 21:46:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgZhu-0006er-58; Fri, 29 Oct 2021 21:46:38 +0000
Received: by outflank-mailman (input) for mailman id 218650;
 Fri, 29 Oct 2021 21:46:36 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=SwSe=PR=oracle.com=boris.ostrovsky@srs-us1.protection.inumbo.net>)
 id 1mgZhs-0006el-Bl
 for xen-devel@lists.xenproject.org; Fri, 29 Oct 2021 21:46:36 +0000
Received: from mx0a-00069f02.pphosted.com (unknown [205.220.165.32])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id af83679c-3901-11ec-8520-12813bfff9fa;
 Fri, 29 Oct 2021 21:46:34 +0000 (UTC)
Received: from pps.filterd (m0246629.ppops.net [127.0.0.1])
 by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 19TJjaXG028580; 
 Fri, 29 Oct 2021 21:46:31 GMT
Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80])
 by mx0b-00069f02.pphosted.com with ESMTP id 3byhqrhr12-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Fri, 29 Oct 2021 21:46:30 +0000
Received: from pps.filterd (userp3030.oracle.com [127.0.0.1])
 by userp3030.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 19TLeAsS030561;
 Fri, 29 Oct 2021 21:46:27 GMT
Received: from nam11-bn8-obe.outbound.protection.outlook.com
 (mail-bn8nam11lp2168.outbound.protection.outlook.com [104.47.58.168])
 by userp3030.oracle.com with ESMTP id 3bx4h6fff8-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Fri, 29 Oct 2021 21:46:26 +0000
Received: from BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10)
 by MN2PR10MB4029.namprd10.prod.outlook.com (2603:10b6:208:186::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.15; Fri, 29 Oct
 2021 21:46:25 +0000
Received: from BLAPR10MB5009.namprd10.prod.outlook.com
 ([fe80::3c49:46aa:83e1:a329]) by BLAPR10MB5009.namprd10.prod.outlook.com
 ([fe80::3c49:46aa:83e1:a329%6]) with mapi id 15.20.4649.015; Fri, 29 Oct 2021
 21:46:25 +0000
Received: from [10.74.111.7] (138.3.200.7) by
 SN6PR2101CA0016.namprd21.prod.outlook.com (2603:10b6:805:106::26) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.2 via Frontend
 Transport; Fri, 29 Oct 2021 21:46:22 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: af83679c-3901-11ec-8520-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date :
 subject : to : cc : references : from : in-reply-to : content-type :
 content-transfer-encoding : mime-version; s=corp-2021-07-09;
 bh=xjh3VCLoupmxIzgdO5BP3ClEi4fylUi0ij0RRkludyQ=;
 b=Gp17FPRXp9tPnuppIVk/2SUjCHFJ90mxmzGudoYSfevJ3Dpk1D8Kk6zkjX2Qy+F/T0e7
 pM+5S6pTl4AtOVKkpKOFFHBpWaiWFelpMQxImkga/+kzvB3dVXLNBmEfDBYvVYvP9r3a
 pB6dA/rl4qew2RpLlJkooHsBremeML+B8LonCxAJb0pNd3aJnJASn4DKC9GxBRDldKyF
 C6bw+Nmykh9dpEJxFB2YulOtoF5C4vUXYNjw8QY2yQhitVWsRgEU1SSKQuRSTfGg+8kI
 8aD4b754EMNrZF4LWf8hvwX30CG3A4meTlXmxEVycoESeagS6XfUhOZW6TJuGcuOdXyL og== 
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=bbl6W8qXkjHACMMgc+vQoBdnDOQoOAEQb3ODicDzs2QRn2Q7H8JWBzLRauMLL+rHLcyZT+5K6+lHeR9jdX7Vq3r/ftDJzox4SxtSMrFhljbvNOx7xztFzIANaUtC4ptCo0OnHXQ8VpNk9b8uMzZ5JawfB/46/H2tgjnjTI+LbzEDEkzytXGxlobqy4Ueg2XK7XJ65KQTINDXgaQF87CcEqt90AiwMfAKThtNbpSFcBGHO6xmn+UcRodqOE+DYjqyK1ZPpps1crL7/bm9zDBvbXr7vdqou3ELctPfLTwfu28d+C1tfNgxRwQinwPxsL+Epew3Yie7cXk5OBL1fNRuiA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=xjh3VCLoupmxIzgdO5BP3ClEi4fylUi0ij0RRkludyQ=;
 b=AI3a45GK2ikizd/bdYzKsCDj+i8S6AO/KU/morV6KQ5efzZP3/vV5sK7zlT/TKnmtptHrADJpGV6d7p0MzIszfafJa0SL7YIjpA24rygGk/CLMUfJPw0UkFqeZ8g0C+azqk11OfUZofNcPFO/kq9PZ2TQGaIyaZ0jr172wwut8uhWXT3vTCNvY2kY3nwu8WB+fFLZVz8S0FXq9s8ZNVaVfqHPukyQcZALzT3iqCgY5vz9OWA+RSMlQO9gt/XZ3SfSuzpKd5a+gMRysu5spzwwMlpgiZibgZypDCnp0hFgek7IucCQWIIzWTcbYfx7GpgVnS0IpEuHqf5G8C4/+sqVQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com;
 dkim=pass header.d=oracle.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=xjh3VCLoupmxIzgdO5BP3ClEi4fylUi0ij0RRkludyQ=;
 b=qGmbuGooXZYYV4vZ/+Mhhz78eqxHDya/tWsIQqr4+HkOMtQOhuXrel25QZFf6io/lCTyuRb57x0Xrgf/OKIgKEjiCAK9R28IQUXijZ5qalYBIcwss+zSrHl2RT1Q5bjfX98nk7mvdt65NzQP6q2XO5eCPCZJoY15tCwA3eRs8vA=
Authentication-Results: suse.com; dkim=none (message not signed)
 header.d=none;suse.com; dmarc=none action=none header.from=oracle.com;
Message-ID: <11956c14-f1f7-70f0-40a6-aad31a264af6@oracle.com>
Date: Fri, 29 Oct 2021 17:46:18 -0400
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.2.1
Subject: Re: [PATCH v3] xen/balloon: add late_initcall_sync() for initial
 ballooning done
Content-Language: en-US
To: Juergen Gross <jgross@suse.com>, xen-devel@lists.xenproject.org,
        linux-kernel@vger.kernel.org
Cc: Stefano Stabellini <sstabellini@kernel.org>, stable@vger.kernel.org,
        =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= <marmarek@invisiblethingslab.com>
References: <20211029142049.25198-1-jgross@suse.com>
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
In-Reply-To: <20211029142049.25198-1-jgross@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: SN6PR2101CA0016.namprd21.prod.outlook.com
 (2603:10b6:805:106::26) To BLAPR10MB5009.namprd10.prod.outlook.com
 (2603:10b6:208:321::10)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: fe358997-26eb-43c5-55ed-08d99b258df1
X-MS-TrafficTypeDiagnostic: MN2PR10MB4029:
X-Microsoft-Antispam-PRVS: 
	<MN2PR10MB4029205E5102D3C5B4BCC0218A879@MN2PR10MB4029.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:4714;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 
	+nJA+QETYhBnlRxj5tSRSqTkjAdo0LMIMhmfch55DYbEXpuvGu9/y1UOLZz9MutEtm/Gs8qWXCc59kJJ5RQ2D0kCnHvT3K19WkOFXHZUPhBCnttvi7GaLSX9IeosMy8jTYYoK6U3aHM6r1G4lPWC4YmDHOatOcfEnMXqvPnOJHSMw1DnSt7vLwnEPoJfDCareNHHKYIpsm0Iw5GY/vBIw3dd5VEz9PcJO1BmiRvBhBUx9OD+Lr267noXeFaJJX/nOV3RxXa4RHtpyfMBO2rB4uh70wOB6QVTlyl7hy8Kav68f1YGc4+lcNXGDvrU3YJTY7WlmQ7k4rAXTA73OuGncWjIhNsJzcHzNQ8LMFpuqN3TmXRPH6QEnbPfT+UjETb+aaSrQM4assQIng8JdYXFpKDr4YFeW2p3Tj+wRpkVFrP/XG/ItKVHbTy2dgHxfdyhWbfjvd3q0+nem1HODLTkxvIgKa52BO8XCVvyf2TQTAa/X/q3SJvskFTuhMuoMm8vN+dxy1JVvxjbdpdOxLVaP/UfW3Qu5yZgmiZ1aNBd+Dik1OyNq88y6qVH1zZZomMewy8xhvlpOFtDyNTciX5uGYINBFg3MTQusa69/+lfCS2CbYbJ3+TmjUt4HGbt600VsHewLxdedwQx1G2R6Xr0Bx80wz68RipZbUvXxxCI4DdZRqvD79vuLmaKO6EOivaE5wAn5yKgO3ZyvGCMSGR2nSyA8FkAnlWpbF1MpEVMM4uWG/hqBTcqYl4/x0hi/oe9
X-Forefront-Antispam-Report: 
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB5009.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(6486002)(53546011)(36756003)(26005)(186003)(31686004)(2906002)(4326008)(508600001)(8936002)(2616005)(44832011)(83380400001)(66946007)(66476007)(66556008)(86362001)(956004)(5660300002)(16576012)(38100700002)(54906003)(31696002)(8676002)(6666004)(316002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?MHFCdE1CZDdYRlI4eWhxUWNGZytNWTNMbXgxa0p6Q01vM0VOVDBFOFNmK0x5?=
 =?utf-8?B?eE84TU0xN3B4cklxRVR6YjZpRy9ndGl1M0laWW9WbnRsdVM2SzAvK2pKb3li?=
 =?utf-8?B?S2RqUTE4WmFuajhxQjcwZHZxYVZIcVJUUW1IdFZycmdlWTBlUDZxcWdNWG9n?=
 =?utf-8?B?d0Zhb1pWWkV2SUd6aVFCMHpCMExEcnBBeVFvSitCZDkra2RQeHNCcDk5T08r?=
 =?utf-8?B?dWlheVRiNm02bHE5U25RM2thKzBHTktrVmlmd0w0ZWFMaGNVYXREMGQ2dTlJ?=
 =?utf-8?B?OU5aUVpCUER2cDhsQlhpbmpnTFpHelZTV3FVZDhUMVJFUkYybUJSdWxqWS82?=
 =?utf-8?B?NnBXZERORnRtZnlOMEdCS2hhQTNLVXJReXZmQ25sVmxtRU9DZS9lMjhYRkdO?=
 =?utf-8?B?NlI1UXRJNEs2R0J6L2JVTzdZQmdsRzQ5V0FJOU9pdnBCM2Y5ckZ6RFpJNGgy?=
 =?utf-8?B?NnZYZzRKa21hQlNTZ0dncTdPbS9pRGM5S2IyWUFzRXdld0UvMnIzTHEzRnFB?=
 =?utf-8?B?L2xzdFZudWE4VVZjUC9tZVRLanorL2djd2J6dW96NExBZCs2RS9Pc2NUSjFu?=
 =?utf-8?B?Yk9jbGNBclg3M0lieUhuOE5ZWEJVRzZGak5ZMEE0TExMNGNmRnJiWG9JalR4?=
 =?utf-8?B?eDVuUXVISjFIb1oxNk5Ed1kyVHF2YktseUtIYjFkM245d3owSCtxQVlqcXBn?=
 =?utf-8?B?bEdQOERML3NmVDFpY0t6RGhyZHphUGJJY1pqOGdYWXBYYlJkcWFQZHJIaW1Y?=
 =?utf-8?B?Mm1DQU9MWTZDUEovVEFnZVB1Um8yZ0xrQkZxQjk0MUZiSGdtOFg3YXNPVmhR?=
 =?utf-8?B?aVR0UUc1dkxZMTFtRU0xS1lPQWNnTUFuT0ZyUEVGL29ndGZvZjdESEMxdWZk?=
 =?utf-8?B?NTEzT1JiTlpjMUdJWDNUdTMxYVp0NERadWt4eFZlQTJPNDN1Yk1TdWFyTXRJ?=
 =?utf-8?B?c3BiejdLRFV6NHpQQ21tODV2UEMrMUl3dHROdEZaNm5LMGNpa2JnU1R4MXRJ?=
 =?utf-8?B?MitGSWN5bGYyT2dnRHo0aXFybnhqa3pmTGN3eGQrSHRHaTE5cnkyaGlCRFpx?=
 =?utf-8?B?S0FGL2R3RGpuSXBHKzV0MWRzTldJQXBCVkxyaUErbFdsU2o4T2NncUlwNEla?=
 =?utf-8?B?VEZaeXBRSWhsL3llN2hNb0xOY1Z4ZHo1c2pield4ckZ4VUhONzJPVUp6UWt1?=
 =?utf-8?B?MUVML3lqUkpKL3BEeCtlNWxDem0yZWEwdE5zUERVTjdGdktZUEZ1Z2tLTEJh?=
 =?utf-8?B?QzRwa09YUnhuZmJFTHlHd1llay9xL1BicTJQWUEyZzlsaW9XenUvS2dlUDVl?=
 =?utf-8?B?NEZvWjZIYTNDUjZEUjM3L25FeGpPTWpWaFNybEdCUFh2eDExTllaZlJYZjlM?=
 =?utf-8?B?VTBJZ21KYnZyVGZISHpmRW4ydjVEQnNzZkZXaVZYS09uSG12QlpmT1lEcTNo?=
 =?utf-8?B?VERaSjFVTXI1aUJCZXhhMWJZVlJkSjJYZjVHWEdZbXEwczdTekh5MmtuZ1Q5?=
 =?utf-8?B?NW42eUtMWmRRQVVnSjh3MnF4cVB0NVI0TlhhckYzeGVjY3krRUNyZ0VwRUNo?=
 =?utf-8?B?aldXOE9LVy9EWXplQWthZEN2dStEN0krSUUvQS9nR1M4TmVKaFV3bkc0NlF4?=
 =?utf-8?B?Z29sekZkZnZhTzNvSER5cE5MWHp5Lys3YjRRbU5CeWRNZ2FyajN6cjVodUww?=
 =?utf-8?B?V05kMk9rL2pNeGFDelhhT3AvZkFBNjZKRlRYVUgrOFdiM05VdEpMZnprMWRB?=
 =?utf-8?B?RW9RSHIvQmN5RlFjUUhNU2FqRXdmZHNPV04xZTUrSlQrZUYxYTR3REJ2SHFa?=
 =?utf-8?B?SnlNYzBmWHVVVko4T24xVHN2V1E2eWlKRENXdUxYMlRCa0x1bjFDMG9rVEZk?=
 =?utf-8?B?VzhOOXdiMThNeEdYdzJCNzI4OS8vZ0VOUGRrdVorSmV3aE5WWHdtQTBDNVZ1?=
 =?utf-8?B?bE9qM29XNlVvT2xEOU0rT1YySmNFVWZWZ2dNNEpHVjJ4NWtvalUvYzR3RWph?=
 =?utf-8?B?ZUFqcE1hazNRMXBKQVhwZGM4eTMxSXRzM0FsOGVZK05HOTlMRnJUdnRBaDYv?=
 =?utf-8?B?WjBTNFdyTW0rT0FIY0NDWTN0QmpDODVmMUp5SFhKQ216WUh0Z3hRWlA1dGQ1?=
 =?utf-8?B?c2tnWlFlZGZqcVM4T3BMaGcrTEJXT3lPSiszaGdhQlM5VXI4ZWlacGRoVHpT?=
 =?utf-8?B?NVBscDhuM1RBVU9FOUNvbkdUSTFvQWJRR0dhOURzTXZRckJXWXRCYm9mMm5s?=
 =?utf-8?B?SDB4bHFCOXJQODZrVFFwY2NkRktnPT0=?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fe358997-26eb-43c5-55ed-08d99b258df1
X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Oct 2021 21:46:24.8389
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: VT2TRdoxL967hFSaEZq4CDhXZgCUmSQJBUD59+lMzOvDaJdBdEbVobwct9yPUdc8wEdBpVm7VLvBfvmopjyePVRhFLb655fcrcoxz9kt0kQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR10MB4029
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10152 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 bulkscore=0 suspectscore=0
 mlxscore=0 adultscore=0 malwarescore=0 phishscore=0 mlxlogscore=999
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2110290120
X-Proofpoint-GUID: ih75n44LEzAuxc5fujNyjz6BAbENJBSn
X-Proofpoint-ORIG-GUID: ih75n44LEzAuxc5fujNyjz6BAbENJBSn


On 10/29/21 10:20 AM, Juergen Gross wrote:
> --- a/Documentation/ABI/stable/sysfs-devices-system-xen_memory
> +++ b/Documentation/ABI/stable/sysfs-devices-system-xen_memory
> @@ -84,3 +84,13 @@ Description:
>   		Control scrubbing pages before returning them to Xen for others domains
>   		use. Can be set with xen_scrub_pages cmdline
>   		parameter. Default value controlled with CONFIG_XEN_SCRUB_PAGES_DEFAULT.
> +
> +What:		/sys/devices/system/xen_memory/xen_memory0/boot_timeout
> +Date:		November 2021
> +KernelVersion:	5.16
> +Contact:	xen-devel@lists.xenproject.org
> +Description:
> +		The time (in seconds) to wait before giving up to boot in case
> +		initial ballooning fails to free enough memory. Applies only
> +		when running as HVM or PVH guest and started with less memory
> +		configured than allowed at max.


How is this going to be used? We only need this during boot.


>   
> -		state = update_schedule(state);
> +		balloon_state = update_schedule(balloon_state);


Now that balloon_state has whole file scope it can probably be updated inside update_schedule().


> +	while ((credit = current_credit()) < 0) {
> +		if (credit != last_credit) {
> +			last_changed = jiffies;
> +			last_credit = credit;
> +		}
> +		if (balloon_state == BP_ECANCELED) {


What about other states? We are really waiting for BP_DONE, aren't we?


-boris


> +			pr_warn_once("Initial ballooning failed, %ld pages need to be freed.\n",
> +				     -credit);
> +			if (jiffies - last_changed >=
> +			    HZ * balloon_stats.boot_timeout)
> +				panic("Initial ballooning failed!\n");
> +		}
> +


From xen-devel-bounces@lists.xenproject.org Fri Oct 29 22:19:02 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Oct 2021 22:19:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.218658.379179 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgaD4-0001hF-12; Fri, 29 Oct 2021 22:18:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 218658.379179; Fri, 29 Oct 2021 22:18:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgaD3-0001h8-Sp; Fri, 29 Oct 2021 22:18:49 +0000
Received: by outflank-mailman (input) for mailman id 218658;
 Fri, 29 Oct 2021 22:18:48 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=qfCy=PR=invisiblethingslab.com=marmarek@srs-us1.protection.inumbo.net>)
 id 1mgaD2-0001gu-Iz
 for xen-devel@lists.xenproject.org; Fri, 29 Oct 2021 22:18:48 +0000
Received: from out1-smtp.messagingengine.com (unknown [66.111.4.25])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 2fb0fd4a-3906-11ec-8520-12813bfff9fa;
 Fri, 29 Oct 2021 22:18:47 +0000 (UTC)
Received: from compute4.internal (compute4.nyi.internal [10.202.2.44])
 by mailout.nyi.internal (Postfix) with ESMTP id 2160A5C0174;
 Fri, 29 Oct 2021 18:18:47 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute4.internal (MEProxy); Fri, 29 Oct 2021 18:18:47 -0400
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri,
 29 Oct 2021 18:18:45 -0400 (EDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2fb0fd4a-3906-11ec-8520-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:content-type:date:from:in-reply-to
	:message-id:mime-version:references:subject:to:x-me-proxy
	:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=4qxxtO
	1Z9+doNE2lABc+fvUK72/uISVCrks1lvW+WaQ=; b=U5wIDMy9uUT4rPkdJzu3Ck
	Vne/wo+YL2pw2A6hlvjAPM7U+p5Ao9iWAv/pdxLwvOdBbiMLP/L4i9KNDs5HApJw
	m61aVwctXZzCvllmHjyPl0Av8/RPMf3vC69nsxXw2INHcRgRicicbSnoV/veZsq/
	tmT3qvX9P7k9XasR2xbrgNcMoGq4/95usFoAiZSsYEHSpamdt9gpWFt3+6RokMkC
	P3Kn2YQxP57Mn3Wd2+dMiN8AH5WVmKO1r6oKBj1k4Zxkm8skgUxfzQ4M90/r1kvq
	WQuasfyxF3WH1xQy/CZ5OL6uI9H/qDsxnTQlCUTmL72IRX6Zh2JL0szocIuCY2ag
	==
X-ME-Sender: <xms:RnN8YVspSbaCdxkzQxj_CWkz-4xDZaLS84iF9I49mrRzlbP-dm8QuA>
    <xme:RnN8Yed5KKrfUGd1F2hxhG5Idyf_TbLaXq5Imm1vTwfk9V66yYr-F1x-RkIBsPnGC
    U3xVUNrE8zezg>
X-ME-Received: <xmr:RnN8YYzJFXtCMjSIk2xkdCtu16WZmbBAqnyUubva2doDuCoJTIwGxnhil9V0oyiGwmcrpLWtzbsi8ETf0I05enOmQ5GFfmMq>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrvdegiedgtddvucetufdoteggodetrfdotf
    fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
    uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
    cujfgurhepfffhvffukfhfgggtuggjsehgtderredttdejnecuhfhrohhmpeforghrvghk
    ucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesihhnvh
    hishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpeetveff
    iefghfekhffggeeffffhgeevieektedthfehveeiheeiiedtudegfeetffenucevlhhush
    htvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrghrmhgrrhgvkhes
    ihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm
X-ME-Proxy: <xmx:RnN8YcMETnWD4FGYftpSXHPRXmAmETOloQqWxW5JYZhNIoWuGsryhA>
    <xmx:RnN8YV_9hsQJXna6sbtqbcakQU2Z38U7REQtaFA0rkFVs5K0xSHLig>
    <xmx:RnN8YcXXl2v-ip88bcdV0P8QWkfttpeQ2K35ii3MdcSOWmLLxelD_Q>
    <xmx:R3N8YQaRt51VKEqxyUVd2Kvug-m2qdqQ3SGLmCc0iY_YYFx_yhH89w>
Date: Sat, 30 Oct 2021 00:18:42 +0200
From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: Juergen Gross <jgross@suse.com>, xen-devel@lists.xenproject.org,
	linux-kernel@vger.kernel.org,
	Stefano Stabellini <sstabellini@kernel.org>, stable@vger.kernel.org
Subject: Re: [PATCH v3] xen/balloon: add late_initcall_sync() for initial
 ballooning done
Message-ID: <YXxzQhPvgAOkhGg/@mail-itl>
References: <20211029142049.25198-1-jgross@suse.com>
 <11956c14-f1f7-70f0-40a6-aad31a264af6@oracle.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="xKPG9ePjWpG+ScdL"
Content-Disposition: inline
In-Reply-To: <11956c14-f1f7-70f0-40a6-aad31a264af6@oracle.com>


--xKPG9ePjWpG+ScdL
Content-Type: text/plain; protected-headers=v1; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Date: Sat, 30 Oct 2021 00:18:42 +0200
From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: Juergen Gross <jgross@suse.com>, xen-devel@lists.xenproject.org,
	linux-kernel@vger.kernel.org,
	Stefano Stabellini <sstabellini@kernel.org>, stable@vger.kernel.org
Subject: Re: [PATCH v3] xen/balloon: add late_initcall_sync() for initial
 ballooning done

On Fri, Oct 29, 2021 at 05:46:18PM -0400, Boris Ostrovsky wrote:
>=20
> On 10/29/21 10:20 AM, Juergen Gross wrote:
> > --- a/Documentation/ABI/stable/sysfs-devices-system-xen_memory
> > +++ b/Documentation/ABI/stable/sysfs-devices-system-xen_memory
> > @@ -84,3 +84,13 @@ Description:
> >   		Control scrubbing pages before returning them to Xen for others dom=
ains
> >   		use. Can be set with xen_scrub_pages cmdline
> >   		parameter. Default value controlled with CONFIG_XEN_SCRUB_PAGES_DEF=
AULT.
> > +
> > +What:		/sys/devices/system/xen_memory/xen_memory0/boot_timeout
> > +Date:		November 2021
> > +KernelVersion:	5.16
> > +Contact:	xen-devel@lists.xenproject.org
> > +Description:
> > +		The time (in seconds) to wait before giving up to boot in case
> > +		initial ballooning fails to free enough memory. Applies only
> > +		when running as HVM or PVH guest and started with less memory
> > +		configured than allowed at max.
>=20
>=20
> How is this going to be used? We only need this during boot.
>=20
>=20
> > -		state =3D update_schedule(state);
> > +		balloon_state =3D update_schedule(balloon_state);
>=20
>=20
> Now that balloon_state has whole file scope it can probably be updated in=
side update_schedule().
>=20
>=20
> > +	while ((credit =3D current_credit()) < 0) {
> > +		if (credit !=3D last_credit) {
> > +			last_changed =3D jiffies;
> > +			last_credit =3D credit;
> > +		}
> > +		if (balloon_state =3D=3D BP_ECANCELED) {
>=20
>=20
> What about other states? We are really waiting for BP_DONE, aren't we?

BP_DONE is set also as an intermediate step:

                       balloon_state =3D decrease_reservation(n_pages,
                                                            GFP_BALLOON);
                       if (balloon_state =3D=3D BP_DONE && n_pages !=3D -cr=
edit &&
                            n_pages < totalreserve_pages)
                               balloon_state =3D BP_EAGAIN;

It would be bad to finish waiting in this case.

--=20
Best Regards,
Marek Marczykowski-G=C3=B3recki
Invisible Things Lab

--xKPG9ePjWpG+ScdL
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmF8c0IACgkQ24/THMrX
1yxlhwf+OIifFECv8WTtmwBHvacvFlHzQBwagjrD83H3pw7ACJBLikt5YbfqVNBT
VzYMegSAbgXVjURqPQgJefIylOcwwY+dk26sQS+6S5YtRZdJZX9z9GSNuqBxQzAv
Sa1FNKGAuHyEdAgV23cPo5v4AdgIwbwV2NjPorIeOyVK1oOnvn+59SakN91TtmM9
GGvgNCkzd8KpSG2dswucJqrRvR8Ng8Y/Vskg0QSdS5MKWgth64xWU6raTgyi8vSE
2HjxLH8HYZM/kk+ZSUP2E3snLsJGHNnkwC15qFT1ui2EH/bJeqVSqJHWhBJ2bflH
wbHj/ikVIoFBqMHXf8FJDsRqPzkBSg==
=pMDf
-----END PGP SIGNATURE-----

--xKPG9ePjWpG+ScdL--


From xen-devel-bounces@lists.xenproject.org Fri Oct 29 23:45:20 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 29 Oct 2021 23:45:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.218666.379190 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgbYH-0001o8-CS; Fri, 29 Oct 2021 23:44:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 218666.379190; Fri, 29 Oct 2021 23:44:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgbYH-0001o1-8w; Fri, 29 Oct 2021 23:44:49 +0000
Received: by outflank-mailman (input) for mailman id 218666;
 Fri, 29 Oct 2021 23:44:48 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=SwSe=PR=oracle.com=boris.ostrovsky@srs-us1.protection.inumbo.net>)
 id 1mgbYG-0001nt-By
 for xen-devel@lists.xenproject.org; Fri, 29 Oct 2021 23:44:48 +0000
Received: from mx0a-00069f02.pphosted.com (unknown [205.220.165.32])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id 95298a6c-87c6-49cc-91f8-426465df0fff;
 Fri, 29 Oct 2021 23:44:45 +0000 (UTC)
Received: from pps.filterd (m0246627.ppops.net [127.0.0.1])
 by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 19TKrRNH014448; 
 Fri, 29 Oct 2021 23:44:42 GMT
Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70])
 by mx0b-00069f02.pphosted.com with ESMTP id 3byedauej8-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Fri, 29 Oct 2021 23:44:41 +0000
Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1])
 by aserp3020.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 19TNfgPU182964;
 Fri, 29 Oct 2021 23:44:40 GMT
Received: from nam12-bn8-obe.outbound.protection.outlook.com
 (mail-bn8nam12lp2174.outbound.protection.outlook.com [104.47.55.174])
 by aserp3020.oracle.com with ESMTP id 3bx4ggmfu1-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Fri, 29 Oct 2021 23:44:40 +0000
Received: from BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10)
 by BL0PR10MB2977.namprd10.prod.outlook.com (2603:10b6:208:31::27)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.20; Fri, 29 Oct
 2021 23:44:38 +0000
Received: from BLAPR10MB5009.namprd10.prod.outlook.com
 ([fe80::3c49:46aa:83e1:a329]) by BLAPR10MB5009.namprd10.prod.outlook.com
 ([fe80::3c49:46aa:83e1:a329%6]) with mapi id 15.20.4649.015; Fri, 29 Oct 2021
 23:44:38 +0000
Received: from [10.74.104.68] (138.3.200.4) by
 SN7PR04CA0194.namprd04.prod.outlook.com (2603:10b6:806:126::19) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.15 via Frontend
 Transport; Fri, 29 Oct 2021 23:44:36 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 95298a6c-87c6-49cc-91f8-426465df0fff
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date :
 subject : to : cc : references : from : in-reply-to : content-type :
 content-transfer-encoding : mime-version; s=corp-2021-07-09;
 bh=gfoXfXhQS40ektirZEXsfnYNyX2cBA+sq9UE/J+mvvU=;
 b=fxDrdSSml5meIqUyqsYBc0BbAQeBQcWnH7HVHD3c1/MnKOIQ45Ot45c5nu55gO8EZOKd
 1WKqgZIgCpbkuu/eP/n/tUtWs6fm5PMUsibCMhy2Rdk8i+xnAZ4DxU/BMUylqCKAAp4X
 +W5V9R4eIHJHgPn1IHed14B9Z4DOtLaAwYEl/asPdHYizA36PjeA5IqaRxCYVneQS21t
 GBibAOgvWbPlm/zQQosTqE/+IzCMq9G1qCqPiyXvSj6o75jdyLshdgiUN8WPHkUlU3BV
 E8G5niVaFP1HGkxdIMBX/qviBwSAITSWQXU+NyMhETpW8Zi+2agx0rQVnN9nRO6mvkQs xw== 
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Vo77w0zdKOd+qf/9/b2ecr7mlgNy03KUlUwZmHY/JvoPtPOgBh4B2ZcaBmB8GKmZ/IFGfhpQnTPOcQgIvx4yjde13mGDU4sEzDEJ2Wg8AQLUaNmSOEionDx4AgHcLsS2qpPu7Onl+DGOnFFQkkE63PV2Rrj7/8KIzZoz54FNU00qVij7TvqIWmWmaVmw5o5RXJ5sg1H29zcbuPrTUteQcZUdo6rjqT1VD7Fm0vDnloAwYwvamuncOROkZ3CYX6fPB0SWAnsjAOgjQ4w/Q35QDXqiF1f1jylKzv4MeTEbxdJTexxbRFxDqh3AsdkkhfBDib1lUqxxkILduvgvClJBZA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=gfoXfXhQS40ektirZEXsfnYNyX2cBA+sq9UE/J+mvvU=;
 b=eSgQB0hJtZKCEOGGcskFRhOtmtQwJ54feV1JktURfBsqndsyOetDlrjtTpC8+Nu/yq5ebz4eleS226khvxGBcDoi/gPXHKs5pOd0oIkSEPDz/Sjlf6DV9P3D2k2/lemChYSk2djhV5/Ur3R3ZCjKEbrKtdxhMcTnijqXnjJnWSG/TRnFlSNrH1JW4M36pa7j7Sj3a5UubRE3NQ1zVGIbJeZMVvQAKKoK+6Oox/+71XH0gKSk4ptCrnhJkT2Mv650WEGRTd/lWnoXnhyiHxkiPhWw/Te1QXj12SFSOsxPbcr/huyXNEicpXdMTBeM3tqzQDAJG51UHZjYSWps4LM5TA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com;
 dkim=pass header.d=oracle.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=gfoXfXhQS40ektirZEXsfnYNyX2cBA+sq9UE/J+mvvU=;
 b=LUIy6ndIXIxtU5TSlwRycpVjCKa1yMbL44Y45MnrBretuu/UyuLHn0wTFwjGj0wLNnwnXgd8SVTrQ/yTDuKRVde4rL82sw2uw5knoqCG+SXRFvT0X99WxUwmNAlRJRqzew9p8prp6A5MZslOcbZkMmgLwW1Ry+iH82t9mDMUU/w=
Authentication-Results: invisiblethingslab.com; dkim=none (message not signed)
 header.d=none;invisiblethingslab.com; dmarc=none action=none
 header.from=oracle.com;
Message-ID: <2365e65f-7431-4bf5-4ced-5e146776b9ac@oracle.com>
Date: Fri, 29 Oct 2021 19:44:31 -0400
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.2.1
Subject: Re: [PATCH v3] xen/balloon: add late_initcall_sync() for initial
 ballooning done
Content-Language: en-US
To: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?=
 <marmarek@invisiblethingslab.com>
Cc: Juergen Gross <jgross@suse.com>, xen-devel@lists.xenproject.org,
        linux-kernel@vger.kernel.org,
        Stefano Stabellini <sstabellini@kernel.org>, stable@vger.kernel.org
References: <20211029142049.25198-1-jgross@suse.com>
 <11956c14-f1f7-70f0-40a6-aad31a264af6@oracle.com> <YXxzQhPvgAOkhGg/@mail-itl>
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
In-Reply-To: <YXxzQhPvgAOkhGg/@mail-itl>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: SN7PR04CA0194.namprd04.prod.outlook.com
 (2603:10b6:806:126::19) To BLAPR10MB5009.namprd10.prod.outlook.com
 (2603:10b6:208:321::10)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: b67a4139-008e-493c-c3a7-08d99b36122c
X-MS-TrafficTypeDiagnostic: BL0PR10MB2977:
X-Microsoft-Antispam-PRVS: 
	<BL0PR10MB29773A9EC8AD089AEFB0E6A38A879@BL0PR10MB2977.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 
	CJqU/o8w7ldM1DNzXEXoWODFiPGdJNGkNZIfKdAjEo22/sNjhyMMMJPbA0GHSqlEIrJiXok9ZkAZOSGQ3sRA9FX4n3xSB+WTvr9j2Z2V+yXTawHoSac8lvNFXLaqjPcsMr1k/iJvO1h8UrHFD8ysHQKCw8t8aCy4rPhru5QspF37pT6fuZF9EfyADwK1YnUbDoPQlp9jikdz3pNRyJHxnip4RM81UzMa7APUqek67XXiJcxQffOXofQUwmbo4wi+EjqwVf4+C1lOITm4V5bAfbYSAmOdTW0xueTcTvoOLILZIUJH39lvGhnx6E/pITjNb4r8/0J3yPG1cqERb1+LQpjzBm4lcHOsJi/NOB1QuiVKH4H+MjkYqLWEJRZd//Qcs7Szrz/WBAomvWNRj0U1TGYlaYiQ8woA2bMVRJltmUgmXxUY86fYUzqJTulbkdZK27bugrBD3gTjmzMHviMfLEmXCJfMZsAnzqIbr4HCj/BFPzlUku4yx4eKARO7HG/tM+sY7NDyOquNbkczn+CgfMCVPOf2iJmplUrkg9X9JjVDYKEf4y4EXGOreGtH9Za+1R6NG/6RqY33w8UL+XSpsujVqZ3VaUia7ki7iKLo5gmDMn4b9PWktgvh0AC4MdAjOl7an9i/7m4niDQhUbeBxzqK5Fa/nPg0zdoD089UYl3UUcHm77LHYDPM3tmx8oJdT3SiVagGd9PBV7vUttQZrKwx84QNaWOcOh0mbM9jyrjFcfGovG0knH3+zrTpba2i
X-Forefront-Antispam-Report: 
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB5009.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(66476007)(54906003)(8936002)(31696002)(8676002)(83380400001)(508600001)(186003)(6666004)(6916009)(4326008)(26005)(66574015)(16576012)(44832011)(2616005)(6486002)(86362001)(31686004)(38100700002)(36756003)(2906002)(5660300002)(956004)(316002)(66556008)(53546011)(66946007)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?M29NN3JITjBDZmx5Nmd5MVFCeno5TjBFUytxZE14bGxid1ovT3BHSWhYQmgx?=
 =?utf-8?B?ZFBVZVRFcWFDOCtlV2I2d3E3em1lZXA3N29pVHp6dHhnNGhTUlFIdS80M01H?=
 =?utf-8?B?YkhhTWNTaHRqc3pudGpYZUQyZ0pwVUljWkcwQVR6SlNjMzV6QkdTVnBTamx4?=
 =?utf-8?B?aE1jSzdwMU1HZTBwYjJCWkxMUmFRaTcxQkxmQVEvZHlkUEpORW1oV3lQSWt6?=
 =?utf-8?B?NlhuT2g0VElvL21xUzFEVFF5cHdLSnRMQ3FESFZNc0p4ajQ4T3ZRU3FoZXRZ?=
 =?utf-8?B?c1FPTkQ1RURpUTJjdWxHMmphbEY0RzhSVEVqOW45YnpocHV1M1dJanpoYmNG?=
 =?utf-8?B?Nzkza1daNjRDalpMUlpsdlp4aDY3UklpNUdxbzlaSkN2T0g2enliUFBKZTdm?=
 =?utf-8?B?QjZVZW5rcFBnTkhzSExFeUEwcWhIc1Fac1JROXI1aXBXalJ2clFSc28xOTV4?=
 =?utf-8?B?SUdxbmRCZG1DbkgyMTEyZHF4NHJoVGgwSkJWL0EwQlc0SmxkcWZ4eEdVUlFU?=
 =?utf-8?B?ZEZxdDVhM1ZPNlJPOWxTajd2enpCR1FoeThMRUpYOGExeXphd0pBQTRkbE42?=
 =?utf-8?B?QzFwMEphTEIzdVN4SEt5dTdSMFYzSC8zdytQLzRyVlAvdG4rVFhZdkZ4ckVD?=
 =?utf-8?B?NE4rdjAzMGpDVjZzZ2ZGSmpGU0k5L1FFYnR5dWxpUlp3dXlEVWxORC9Xdm5W?=
 =?utf-8?B?eWxUMUMvNE9xRExnMnFMRTNiUkhKallVTDV0TkY1cThiQTFndW1pTGprditI?=
 =?utf-8?B?dHZCOElyMVdBQm42UzUwMUNWaDVPZVB2UjRHb2RXbUY5RjM4SEtvb2NOVSt3?=
 =?utf-8?B?bG52enRXSVY3ZU1peVRZU1BEREVlOUU1UTQ2clJjTkdJeEhCNW9KdkExTW51?=
 =?utf-8?B?bGRrN05ib0lESzVmNWhGYURadW96eUhKQzlCOSs0YXpOL2pHNzliNEVkVGlR?=
 =?utf-8?B?MDZhaGJPN1ZUbC9aWGljZlhtWkZURzhGUHFzMERUQTlxY3BuaU1jajNHODZp?=
 =?utf-8?B?aG93VVg1SWlqWUxMdnlvTmFRNjhYMWx1MjlUb1JMUkcySEJKZVVBQmYva2Y0?=
 =?utf-8?B?ZDlLdGF1YlhIV213blZlbG5PWVh4enNoNk55ZEJkTW9meHFVR1NiNWdDRnRn?=
 =?utf-8?B?ekdadVUvaGdWdm8xUEE0SlJtZ0FlWTlyR1BwV256ajdyY0lnWk8rSGtwRVZq?=
 =?utf-8?B?WmxZNmlOcysveGxPVHpRaFVjV3R1c2FEKzA3Z1duK25UYnJRWVJBQTd2M1hm?=
 =?utf-8?B?UUZEM1Zjb0lFdHlUVG5Id1o4MGxROFRKekwrT3MxM0lKcFAzVWpVQ05aSUEv?=
 =?utf-8?B?V0E2K0FOUVRkdllDa0Vqd1FlR1V5UDRRbHNkenEwSlhscG43ell2VlNya1F1?=
 =?utf-8?B?TWtEQ0VhSDBXczFnRTF4Rk83ZVF2cGtiSE44bjcxL0I5bDJwc0hHQkIzREVT?=
 =?utf-8?B?cUxLZHJHQlhlWm5ub0hoRmhTejlWcXRocU1pZDJKc0pWWjFwSzlTejZuNWMz?=
 =?utf-8?B?d093L3pZcThraCtrZFZPZndSYnZPQWRmNEFFU3V0cWFsaFBKYzlhckhWZHJL?=
 =?utf-8?B?dCtNc1B1Zm9GN0szQ2dQZVoxcWc5cEFTQ0F6WmJuMlJPdDRRN09td29FdFFW?=
 =?utf-8?B?aGNqNVBkVkVNR0psU0ZubllvRVlnbEJhRHdTUXhjTllJdlRFTkJSUzA5bFB5?=
 =?utf-8?B?cURTRHFiUzhvNW96YlFzWVBRd2hKT3lVQ0FnblgyRUJ1KzdOYXRoWHBEbkJE?=
 =?utf-8?B?MmhsQUdPVnpmMkp6WFNuZzFsZno4OFVxSnVTMkZmUFpjSzBnYlJOSFNPYUp1?=
 =?utf-8?B?LzduV0FXQXNuY3JVcGNtY3JhdFVWeW12TTFxT1ZNdGZyTjVuNHZVcEZrLy9D?=
 =?utf-8?B?MUp0TXZUMlI4ZWFJSWxKbzd1T0kxT3dIYTNLWjFrNlMxeTdqUk80OWk1Um5a?=
 =?utf-8?B?MXBLN01GVHB2SUpNaDlsbjl6anFORS83QUh4VXl1ckZjZVVPZEovU3FQb3lS?=
 =?utf-8?B?N3VVdjhBbjNLN2RQWWUybEd1aTlJRDNjTEw3MndVdk0yMHN3T2NFWnczaURr?=
 =?utf-8?B?WHhFTXhUaGJ2dy94T1hMTnpvWWhIZDJ3VUJRSXFaOWhuS2d1aDliZEVnNkJa?=
 =?utf-8?B?dktZREVQOWpXMjBydHczcUt2OHJVbjEwWGJERnVMNC8zSEF0bWNYNVhUT2tE?=
 =?utf-8?B?MVdQdytHM2ZUUXVveVJ0YnExMnVxbEdDZW9EOVIxT0xSZGM3RlAvQXZ1SGVw?=
 =?utf-8?B?T2dFM3B3QnVJUWFnZzVaaU9KcytnPT0=?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b67a4139-008e-493c-c3a7-08d99b36122c
X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Oct 2021 23:44:38.6641
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: LRe775WjO5CbYv++uDmqhkY5Vzl+rJSrhepyzVDEkIZfqyEMJkonOnDIQFJwR63ckcNJl0CUXkL4zt5cQlrZU8t70xHxwsew6z2HTHIc0/Y=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR10MB2977
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10152 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 mlxlogscore=999
 bulkscore=0 phishscore=0 mlxscore=0 spamscore=0 adultscore=0
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2110290132
X-Proofpoint-ORIG-GUID: ZdwsPRhlKtE41Lc6f9wfC1qV2NmtRETM
X-Proofpoint-GUID: ZdwsPRhlKtE41Lc6f9wfC1qV2NmtRETM


On 10/29/21 6:18 PM, Marek Marczykowski-Górecki wrote:
> On Fri, Oct 29, 2021 at 05:46:18PM -0400, Boris Ostrovsky wrote:
>> On 10/29/21 10:20 AM, Juergen Gross wrote:
>>> --- a/Documentation/ABI/stable/sysfs-devices-system-xen_memory
>>> +++ b/Documentation/ABI/stable/sysfs-devices-system-xen_memory
>>> @@ -84,3 +84,13 @@ Description:
>>>    		Control scrubbing pages before returning them to Xen for others domains
>>>    		use. Can be set with xen_scrub_pages cmdline
>>>    		parameter. Default value controlled with CONFIG_XEN_SCRUB_PAGES_DEFAULT.
>>> +
>>> +What:		/sys/devices/system/xen_memory/xen_memory0/boot_timeout
>>> +Date:		November 2021
>>> +KernelVersion:	5.16
>>> +Contact:	xen-devel@lists.xenproject.org
>>> +Description:
>>> +		The time (in seconds) to wait before giving up to boot in case
>>> +		initial ballooning fails to free enough memory. Applies only
>>> +		when running as HVM or PVH guest and started with less memory
>>> +		configured than allowed at max.
>>
>> How is this going to be used? We only need this during boot.
>>
>>
>>> -		state = update_schedule(state);
>>> +		balloon_state = update_schedule(balloon_state);
>>
>> Now that balloon_state has whole file scope it can probably be updated inside update_schedule().
>>
>>
>>> +	while ((credit = current_credit()) < 0) {
>>> +		if (credit != last_credit) {
>>> +			last_changed = jiffies;
>>> +			last_credit = credit;
>>> +		}
>>> +		if (balloon_state == BP_ECANCELED) {
>>
>> What about other states? We are really waiting for BP_DONE, aren't we?
> BP_DONE is set also as an intermediate step:
>
>                         balloon_state = decrease_reservation(n_pages,
>                                                              GFP_BALLOON);
>                         if (balloon_state == BP_DONE && n_pages != -credit &&
>                              n_pages < totalreserve_pages)
>                                 balloon_state = BP_EAGAIN;
>
> It would be bad to finish waiting in this case.


RIght, but if we were to say 'if (balloon_state != BP_DONE)' the worst that can happen is that we will continue on to the next iteration without warning and/or panicing. Of course, there is a chance thaton the next iteration the same thing will happen but I think chances of hitting this race every time are infinitely low. We can also check for current_credit() again.


The question is whether we do want to continue waiting if we are in BP_AGAIN. I don't think BP_WAIT is possible in this case although this may change in the future and we will forget to update this code.


-boris



From xen-devel-bounces@lists.xenproject.org Sat Oct 30 00:38:56 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 30 Oct 2021 00:38:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.218673.379200 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgcOT-0007NH-Bn; Sat, 30 Oct 2021 00:38:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 218673.379200; Sat, 30 Oct 2021 00:38:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgcOT-0007NA-8p; Sat, 30 Oct 2021 00:38:45 +0000
Received: by outflank-mailman (input) for mailman id 218673;
 Sat, 30 Oct 2021 00:38:44 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mgcOS-0007Me-Ei; Sat, 30 Oct 2021 00:38:44 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mgcOS-0007Pp-1J; Sat, 30 Oct 2021 00:38:44 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mgcOR-0005Jt-PH; Sat, 30 Oct 2021 00:38:43 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mgcOR-0006H8-Om; Sat, 30 Oct 2021 00:38:43 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=q4f5JGQIX7S1jsGYV2hRShMF5yZuMt2KGokZPImfvFk=; b=MUBdbZFMFaLnx9vNTleyBVKZK+
	brcN5Hr75NmiP0WhFntmvV+OB0o5jsm2wiWjGJM625xaXFEOIKFnzYkeLf6528STiELUgUL8uE40U
	gQ966l3zQfVPQKaBErL0NUbFET87zrcePdrCj0wUe0AbRjTLttJAZRhJqkadioOeV2Ks=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165939-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 165939: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=6f1d6682de832d12b728f856331e700a89737a1e
X-Osstest-Versions-That:
    xen=c91c967f329f866b1826b04e73e32aea936930cd
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 30 Oct 2021 00:38:43 +0000

flight 165939 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165939/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  6f1d6682de832d12b728f856331e700a89737a1e
baseline version:
 xen                  c91c967f329f866b1826b04e73e32aea936930cd

Last test of basis   165915  2021-10-27 17:01:29 Z    2 days
Testing same since   165939  2021-10-29 21:00:26 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Roger Pau Monne <roger.pau@citrix.com>
  Roger Pau Monné <roger.pau@citrix.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   c91c967f32..6f1d6682de  6f1d6682de832d12b728f856331e700a89737a1e -> smoke


From xen-devel-bounces@lists.xenproject.org Sat Oct 30 02:23:14 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 30 Oct 2021 02:23:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.218686.379227 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mge1B-00030L-66; Sat, 30 Oct 2021 02:22:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 218686.379227; Sat, 30 Oct 2021 02:22:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mge1A-00030D-VE; Sat, 30 Oct 2021 02:22:48 +0000
Received: by outflank-mailman (input) for mailman id 218686;
 Sat, 30 Oct 2021 02:22:46 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mge18-000301-SO; Sat, 30 Oct 2021 02:22:46 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mge18-0002hM-LV; Sat, 30 Oct 2021 02:22:46 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mge18-0008LL-AV; Sat, 30 Oct 2021 02:22:46 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mge18-0007XN-A1; Sat, 30 Oct 2021 02:22:46 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=1xoNYOuddXtUzjArK3HNbOJwP7gC4GCWfak2qMbHq+U=; b=QU5O0bN88rTtOcIjBmonnf61rr
	KnCtpk/KAa/K5xmpReh4YH1TCiXbtHaX31BoY4GDmNt81KWpWG4O2VdqOnkwPo3IFsl+hG7NFKZ4+
	64ekTEaQetim4KcaZKJKmlPIAt0avQAro5zcbQBP5frrv0vexmCyjZ7dhsltZ4OhYoeU=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165937-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 165937: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=a379fbbcb88bcf43d886977c6fb91fb43f330b84
X-Osstest-Versions-That:
    linux=f25a5481af12c2360710583b84537eb9e652d57d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 30 Oct 2021 02:22:46 +0000

flight 165937 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165937/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 165932
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 165932
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165932
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 165932
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165932
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 165932
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 165932
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165932
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass

version targeted for testing:
 linux                a379fbbcb88bcf43d886977c6fb91fb43f330b84
baseline version:
 linux                f25a5481af12c2360710583b84537eb9e652d57d

Last test of basis   165932  2021-10-29 05:44:11 Z    0 days
Testing same since   165937  2021-10-29 19:09:21 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Adrian Hunter <adrian.hunter@intel.com>
  Amit Engel <amit.engel@dell.com>
  Andrew Morton <akpm@linux-foundation.org>
  Andy Shevchenko <andriy.shevchenko@linux.intel.com>
  Chaotian Jing <chaotian.jing@mediatek.com>
  Chen Wandun <chenwandun@huawei.com>
  Christian Hewitt <christianshewitt@gmail.com>
  Christoph Hellwig <hch@lst.de>
  David Hildenbrand <david@redhat.com>
  David Sterba <dsterba@suse.com>
  David Yang <davidcomponentone@gmail.com>
  Gautham Ananthakrishna <gautham.ananthakrishna@oracle.com>
  Haibo Chen <haibo.chen@nxp.com>
  Herbert Xu <herbert@gondor.apana.org.au>
  Heyuan Shi <heyuan@linux.alibaba.com>
  Hugh Dickins <hughd@google.com>
  Jaehoon Chung <jh80.chung@samsung.com>
  Jens Axboe <axboe@kernel.dk>
  Johan Hovold <johan@kernel.org>
  Johannes Weiner <hannes@cmpxchg.org>
  Kees Cook <keescook@chromium.org>
  Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Marek Szyprowski <m.szyprowski@samsung.com>
  Maurizio Lombardi <mlombard@redhat.com>
  Michal Hocko <mhocko@suse.com>
  Ming Lei <ming.lei@redhat.com>
  Naohiro Aota <naohiro.aota@wdc.com>
  Naoya Horiguchi <naoya.horiguchi@nec.com>
  Qu Wenruo <wqu@suse.com>
  Randy Dunlap <rdunlap@infradead.org>
  Roman Gushchin <guro@fb.com>
  Rongwei Wang <rongwei.wang@linux.alibaba.com>
  Sagi Grimberg <sagi@grimberg.me>
  SeongJae Park <sj@kernel.org>
  Shakeel Butt <shakeelb@google.com>
  Shawn Guo <shawn.guo@linaro.org>
  Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
  Steven Rostedt (VMware) <rostedt@goodmis.org>
  Suren Baghdasaryan <surenb@google.com>
  Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
  Ulf Hansson <ulf.hansson@linaro.org>
  Varun Prakash <varun@chelsio.com>
  Vasily Averin <vvs@virtuozzo.com>
  Wenbin Mei <wenbin.mei@mediatek.com>
  Wolfram Sang <wsa+renesas@sang-engineering.com>
  Xu Yu <xuyu@linux.alibaba.com>
  Yang Shi <shy828301@gmail.com>
  Yi Zhang <yi.zhang@redhat.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   f25a5481af12..a379fbbcb88b  a379fbbcb88bcf43d886977c6fb91fb43f330b84 -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Sat Oct 30 02:46:33 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 30 Oct 2021 02:46:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.218695.379241 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgeO0-0005SK-4t; Sat, 30 Oct 2021 02:46:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 218695.379241; Sat, 30 Oct 2021 02:46:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgeO0-0005SD-1Y; Sat, 30 Oct 2021 02:46:24 +0000
Received: by outflank-mailman (input) for mailman id 218695;
 Sat, 30 Oct 2021 02:46:23 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mgeNz-0005S3-Ca; Sat, 30 Oct 2021 02:46:23 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mgeNz-00035C-3I; Sat, 30 Oct 2021 02:46:23 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mgeNy-0001E1-O2; Sat, 30 Oct 2021 02:46:22 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mgeNy-0003Fl-NW; Sat, 30 Oct 2021 02:46:22 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=EanTIHkyZEpJYZ/NkXx29d4iJZ9W8mcRFDLv6ALmWsI=; b=djg7LV2ajxTt/NX59NCpu+QyDu
	DZ6+za286wzfwIqZBW/gBu59u6z3/QEJAIHHunZtyonXvr92r7LhA+hxR5CereWXAXopxHO/QMNQK
	B+IIzr2hN9HDzaMl0VQ1kyZHdJKzxLtQkk5mCbUQl1K1ePCz3Owj+7wTJhMNRuua1chQ=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165938-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 165938: regressions - FAIL
X-Osstest-Failures:
    qemu-mainline:build-i386-xsm:xen-build:fail:regression
    qemu-mainline:build-i386:xen-build:fail:regression
    qemu-mainline:build-armhf:xen-build:fail:regression
    qemu-mainline:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-amd:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-pair:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-freebsd10-i386:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-freebsd10-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-coresched-i386-xl:build-check(1):blocked:nonblocking
    qemu-mainline:build-armhf-libvirt:build-check(1):blocked:nonblocking
    qemu-mainline:build-i386-libvirt:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-intel:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-shadow:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-vhd:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=a92cecba2791cd408d2bca04ce181dc2abaf9695
X-Osstest-Versions-That:
    qemuu=50352cce138ef3b30c1cda28a4df68fff5da3202
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 30 Oct 2021 02:46:22 +0000

flight 165938 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165938/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-i386-xsm                6 xen-build                fail REGR. vs. 165682
 build-i386                    6 xen-build                fail REGR. vs. 165682
 build-armhf                   6 xen-build                fail REGR. vs. 165682

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl           1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-credit2   1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-cubietruck  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-multivcpu  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-rtds      1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-vhd       1 build-check(1)               blocked  n/a
 test-amd64-i386-qemuu-rhel6hvm-amd  1 build-check(1)               blocked n/a
 test-amd64-i386-pair          1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-freebsd10-i386  1 build-check(1)               blocked  n/a
 test-amd64-i386-freebsd10-amd64  1 build-check(1)               blocked  n/a
 test-amd64-coresched-i386-xl  1 build-check(1)               blocked  n/a
 build-armhf-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-credit1   1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-arndale   1 build-check(1)               blocked  n/a
 test-amd64-i386-qemuu-rhel6hvm-intel  1 build-check(1)             blocked n/a
 test-amd64-i386-xl            1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-pvshim     1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-qemuu-debianhvm-amd64  1 build-check(1)         blocked n/a
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow  1 build-check(1)  blocked n/a
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm  1 build-check(1)      blocked n/a
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 1 build-check(1) blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a
 test-amd64-i386-xl-qemuu-win7-amd64  1 build-check(1)              blocked n/a
 test-amd64-i386-xl-qemuu-ws16-amd64  1 build-check(1)              blocked n/a
 test-amd64-i386-xl-shadow     1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-vhd        1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-xsm        1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165682
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165682
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165682
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 qemuu                a92cecba2791cd408d2bca04ce181dc2abaf9695
baseline version:
 qemuu                50352cce138ef3b30c1cda28a4df68fff5da3202

Last test of basis   165682  2021-10-19 21:09:14 Z   10 days
Failing since        165694  2021-10-20 18:09:12 Z    9 days   23 attempts
Testing same since   165938  2021-10-29 20:38:32 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Alistair Francis <alistair.francis@wdc.com>
  Andrew Jones <drjones@redhat.com>
  Ani Sinha <ani@anisinha.ca>
  BALATON Zoltan <balaton@eik.bme.hu>
  Bin Meng <bmeng.cn@gmail.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Cédric Le Goater <clg@kaod.org>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  David Gibson <david@gibson.dropbear.id.au>
  David Hildenbrand <david@redhat.com>
  Dr. David Alan Gilbert <dgilbert@redhat.com>
  Eric Auger <eric.auger@redhat.com>
  Eugenio Pérez <eperezma@redhat.com>
  Frank Chang <frank.chang@sifive.com>
  Frédéric Pétrot <frederic.petrot@univ-grenoble-alpes.fr>
  Gavin Shan <gshan@redhat.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Greg Kurz <groug@kaod.org>
  Gustavo Romero <gromero@linux.ibm.com>
  Igor Mammedov <imammedo@redhat.com>
  Jason Wang <jasowang@redhat.com>
  John Wang <wangzhiqiang02@inspur.com>
  John Wang <wangzq.jn@gmail.com>
  Laurent Vivier <laurent@vivier.eu>
  Laurent Vivier <lvivier@redhat.com>
  Luc Michel <lmichel@kalray.eu>
  Luis Pires <luis.pires@eldorado.org.br>
  Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
  Markus Armbruster <armbru@redhat.com>
  Matheus Ferst <matheus.ferst@eldorado.org.br>
  Mathieu Poirier <mathieu.poirier@linaro.org>
  Michael S. Tsirkin <mst@redhat.com>
  Mingwang Li <limingwang@huawei.com>
  Oğuz Ersen <oguzersen@protonmail.com>
  Pavel Dovgalyuk <Pavel.Dovgalyuk@ispras.ru>
  Peter Krempa <pkrempa@redhat.com>
  Philipp Tomsich <philipp.tomsich@vrull.eu>
  Philippe Mathieu-Daudé <f4bug@amsat.org>
  Philippe Mathieu-Daudé <philmd@redhat.com>
  Richard Henderson <richard.henderson@linaro.org>
  Shuuichirou Ishii <ishii.shuuichir@fujitsu.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Taylor Simpson <tsimpson@quicinc.com>
  Thomas Huth <thuth@redhat.com>
  Tong Ho <tong.ho@xilinx.com>
  Travis Geiselbrecht <travisg@gmail.com>
  Vincent Palatin <vpalatin@rivosinc.com>
  Vivek Goyal <vgoyal@redhat.com>
  Xueming Li <xuemingl@nvidia.com>
  Yanan Wang <wangyanan55@huawei.com>
  Yifei Jiang <jiangyifei@huawei.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               fail    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          blocked 
 test-amd64-i386-xl                                           blocked 
 test-amd64-coresched-i386-xl                                 blocked 
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  blocked 
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       blocked 
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           blocked 
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     blocked 
 test-amd64-i386-freebsd10-amd64                              blocked 
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          blocked 
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          blocked 
 test-armhf-armhf-xl-arndale                                  blocked 
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  blocked 
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  blocked 
 test-armhf-armhf-xl-cubietruck                               blocked 
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         blocked 
 test-amd64-i386-freebsd10-i386                               blocked 
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         blocked 
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                blocked 
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         blocked 
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 blocked 
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    blocked 
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     blocked 
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              blocked 
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    blocked 
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      blocked 
 test-amd64-i386-xl-vhd                                       blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5028 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Oct 30 04:11:36 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 30 Oct 2021 04:11:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.218703.379254 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgfi4-0005Pw-01; Sat, 30 Oct 2021 04:11:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 218703.379254; Sat, 30 Oct 2021 04:11:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgfi3-0005Pp-TT; Sat, 30 Oct 2021 04:11:11 +0000
Received: by outflank-mailman (input) for mailman id 218703;
 Sat, 30 Oct 2021 04:11:11 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mgfi3-0005Pf-3w; Sat, 30 Oct 2021 04:11:11 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mgfi2-0004XO-VL; Sat, 30 Oct 2021 04:11:10 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mgfi2-0004CS-MI; Sat, 30 Oct 2021 04:11:10 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mgfi2-00025G-Le; Sat, 30 Oct 2021 04:11:10 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=GuTYx/jpDB9UNT71HFXMSinQ27A1d5T1zXVvtjMR15A=; b=fiPgunA0bvbUbWSG5NoZGxsErF
	s1BHt9NGidzQNLefM53ouD84deyJLXgukMQE9lCFQ3W99oHfC+4phmVzDVaE1qlMxGsecQVvbaYz4
	4gPE7M4RCiUiulg/k4xEzFJK4ltQsbniEZvehuBg9cl2DsFXO42LjkitpOj0VvKec0MU=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165940-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 165940: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=3030a73bf849a50411da95e94abf23cb7e8642fc
X-Osstest-Versions-That:
    xen=6f1d6682de832d12b728f856331e700a89737a1e
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 30 Oct 2021 04:11:10 +0000

flight 165940 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165940/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  3030a73bf849a50411da95e94abf23cb7e8642fc
baseline version:
 xen                  6f1d6682de832d12b728f856331e700a89737a1e

Last test of basis   165939  2021-10-29 21:00:26 Z    0 days
Testing same since   165940  2021-10-30 01:01:36 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Stefano Stabellini <stefano.stabellini@xilinx.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   6f1d6682de..3030a73bf8  3030a73bf849a50411da95e94abf23cb7e8642fc -> smoke


From xen-devel-bounces@lists.xenproject.org Sat Oct 30 07:54:11 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 30 Oct 2021 07:54:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.218717.379269 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgjBJ-0000sJ-Uc; Sat, 30 Oct 2021 07:53:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 218717.379269; Sat, 30 Oct 2021 07:53:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgjBJ-0000sC-QN; Sat, 30 Oct 2021 07:53:37 +0000
Received: by outflank-mailman (input) for mailman id 218717;
 Sat, 30 Oct 2021 07:53:36 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=b4cL=PS=citrix.com=roger.pau@srs-us1.protection.inumbo.net>)
 id 1mgjBI-0000s6-5j
 for xen-devel@lists.xenproject.org; Sat, 30 Oct 2021 07:53:36 +0000
Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id 7b3471d4-3956-11ec-8525-12813bfff9fa;
 Sat, 30 Oct 2021 07:53:34 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7b3471d4-3956-11ec-8525-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1635580414;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=+xn9QZhfUiGdzHPSaKyZLJ5GAwI6vtsT6ydfVfA5RoU=;
  b=e9IbTmUvwPaeBXE0zDXRIy8jBY7qQHuBN52+1tzbg3pc17byLnUN5SsI
   NAuT5juW18j1VmIK01yda2KxJlUiRCtPyldE2HzXq9ezXlQGaAiXkoKpf
   Tw81gfnjC9ypQAtaL77mw6wRKNS9NRmb4tRoeS7NSYDAX9ezbaXqddNND
   w=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: HzU8GZT1m77svVQDHoja5CToL11dWaDmNAV9SDJyMRm2ZxMUWSdH32rdwgYtkKWZC3nimkhluA
 dgJfFEHbcvjMuYKzdx0CFC8KjTmPKdu0AkdtPF2iKUhzEhgoAxXMJst/Nmg+c5IHw/Jh8hb2Gf
 a2L5kXpH/lBeJCHOxABYGj9zk8fh7rN+GTeMMzcC/Zs7yjcYxiJXoGfIZQymGnxy0+XrCVFhhz
 FXtHJ2c/Tz7oWcYadkUu/lRqe2Dm11JoEvXIAxvFdtI7Ae3CWnQmKb4VF6/uHGbmAPltvIShbk
 E2oRZugYecRTd0taa1zdq66l
X-SBRS: 5.1
X-MesageID: 56677409
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:8s4hcqChlDCBDBVW/3jlw5YqxClBgxIJ4kV8jS/XYbTApGsqhTZVm
 2UZWWnXbqnbNGKhKtBxb4jioR5X6Mfcx4VhQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA
 xA2M4GYRCwMo/u1Si6FatANl1ElvU2zbue6WLGs1hxZH1c+EX5500M7wIbVv6Yz6TSHK1LV0
 T/Ni5W31G+Ng1aY5UpNtspvADs21BjDkGtwUm4WPJinj3eH/5UhN7oNJLnZEpfNatI88thW5
 Qr05OrREmvxp3/BAz4++1rxWhVirrX6ZWBihpfKMkQLb9crSiEai84G2PQghUh/sSW5lPEsz
 I9xqt+Rax8wIPzFtLgFTEwNe81+FfUuFL7vJHG+tYqYzlHccmuqyPJrZK00FdRGoKAtWzgIr
 KFGbmBWBvyAr7veLLaTUO5ji95lNMD2FIgepmth3XfSCvNOrZXrHvuUuoAEhGZYasZmTa7RS
 NggZzNTNBXFWy9FIH4HMMgytbL97pX4W2IB8w/EzUYt2EDfxRJ8+KLgO93UfpqNX8o9tkSXv
 GXd5EziHwoXcteYzFKt822urv/CmzvhX4AfH6H+8eRl6HWtwWgUBAwTREGMi/CzgU6jWPpSM
 0URvCEpqMAa71e3R9PwWxm5pn+svRMGXddUVeog52ml1a788wufQG8eQVZpeNEg8cM7WzEu/
 luIhM/yQyxitqWPTnCQ/avSqim9UQAXMGsDaCksXQYDpd75r+kbjBjCU9JiG66dlcDuFHf7x
 DXikcQlr+xN14hRjfz9pA2ZxWL3znTUcuIrzj/HbmmEswcjWJHmRq6w8EaK5NocNJnMGzFto
 0M4s8SZ6ekPC7SEmyqMXPgBEdmV2hqVDNHPqQUxRsd8rlxB71bmJNkNu28meC+FJ+5dIWexC
 HI/rz+983O60JGCSaZsK7y8BM0xpUQLPYS0D6uEBjaij3UYSeNmwM2MTRLPt4wOuBJ1+U3aB
 Xt9WZz0ZZr9If8+pAdav89HjdcWKtkWnAs/v6zTwRW9yqa5b3WIU7oDO1bmRrlnt/7Z+1+Er
 I4FbpDiJ/BjvAvWOHG/HWk7dgliEJTGLcqu95w/mhCre1IO9J4d5w/5nup6Jt0Nc1V9nebU5
 HCtMnK0O3Kk7UAr3T6iMyg5AJu2BM4XhStiYUQEYAb5s1B+MN3HxPpOKPMKkUwPqbULIQhcF
 KJeJa1tw51nF1z6xtjqRcCm8dE5K0jz3Wpj/UONOVACQnKpfCSQkvfMdQrz7igeSC2xsMo1u
 bq70Q3HB5EEQmxf4Az+MZpDFnu94ioQnvxcRUzNLoUBcUng6tEyeSfwkuU2M4cHLhCanmmW0
 AOfABE5o+jRotBqrImV1P7c94r5QfFjGkd6HnXA6erkPyft4Wf+k5RLV/yFfG6BWTqsqrmif
 +hc09r1LOYDwARRq4N5HrsylfA+6tLjqqV01ANhGHmXPV2nBqk5eiuN3NVVt70Lzbhc4FPkV
 kWK89hcGLOIJMK6TwJBeFt7NryOjKhGlCPT4PI5JFTByBV2pLfXA19POxSsiTBGKOcnOo0S3
 up86tUd7Bayi0R2P4/e3DxU7WmFMlcJT74j6sMBGIbuhwcmlgNCbJjbBnOk6Z2DcYwRYEwjI
 zvSj6venbVMgEHFdiNrR3TK2ONcg7UIuQxLkwBedwjYxIKdi69lxgBV/BQ2Uh9Rn0dO3O9EM
 2R2M1F4ePeV9DByickfB22hFmmt3vFCFpAdH7fRqFDkcg==
IronPort-HdrOrdr: A9a23:lea7kam6sl/ilplQ5RrJ4F/J6kHpDfIS3DAbv31ZSRFFG/Fw8P
 re/sjztCWE6wr5PUtKpTnuAsi9qB/nmqKdgrN8AV7BZmTbUQKTRelfBOPZsljd8kbFltK1u5
 0PT0DZYueAaWRSvILf2k2ZCNY7hP2K7aiEjfrXpk0GcT1X
X-IronPort-AV: E=Sophos;i="5.87,194,1631592000"; 
   d="scan'208";a="56677409"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=fCyKVZvnlpeVtjNCUNoESM1s4trefVVu/tUPn/6sIi95hGxVHKLBJVGf0s2Ys8oZNVBY/ZnQoDRQ7kfY3CO59JIuaqQztldU6XUjTSZg+RP0+aNAPuIUgAiyDIxxu+0Fx+3HzDsvfeHs+oTqdbRIvJ4H4kVlMTNtIoAr+ijbsrhbT6GICa1RqIBH07o0k4szg1klEGfRj/uK5yazHPzzwbDIQBH1HfjUghDboJ8g9nQ8TON+lzOl4PsEjEIMMsa5w6KrWk53QHN2mK3tSj2pG/CovmFeXf6mj5JBap6ukX7UatX36hso/8NtRUrlwdXoNfUiPJNKDGWmW8o7mnNtkw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=MVJ1k9E/HU64AYnlrTPywAaZ3jOuUc+JxseXIJ8jVeM=;
 b=N3ke0DeNSvH/HvWA2J7/08deNhg/TDOOur/ANgjn3cbpJxvIdltAST5tS7EcQNKC1SOVuvchkyMavziFmy2P+UjSnNIhYSwU5OWLVva0zKbuh/3WmL2CgGHUj+Ae4BXRhZhCnLmkv58K7aTvb15FOVMxJ7mv3i29Ze/2p5IJiOmLd0VkB8ZsJiRNqqiELdReaqqS4Jqzg4yWJqMllnC5MKKuUHPuX/qY5IMj3krwVDB1EichqSjXVckvIMSiBx1eftedPLN574Hogbu2dTAoW/uhqU2Up01yQQr+hG1wre2nm6MCE9gNjNSb9zkmStHSBzJINe1AAwur1vKOL7dDjw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=MVJ1k9E/HU64AYnlrTPywAaZ3jOuUc+JxseXIJ8jVeM=;
 b=hc3HZwfQFOD1BJMUB7x/px+TgMAj3TuvC+moJHhG/fYqPG4V0RLdKoNta2x4bTXK8epveSzULQeQCoeG/gjkgUhmoFOjmNd5M6KXdNkx+ddvSrqLnZrYzrWJHPiiT+V0e5RPE5x3jQDQCVtFmtkuXpkQOJDF2voP/O7lqiveADs=
Date: Sat, 30 Oct 2021 09:53:19 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
CC: <xen-devel@lists.xenproject.org>, Wei Liu <wl@xen.org>, George Dunlap
	<george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>, Julien Grall
	<julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>, Anthony PERARD
	<anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>, Christian
 Lindig <christian.lindig@citrix.com>, David Scott <dave@recoil.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, Ian Jackson
	<iwj@xenproject.org>
Subject: Re: [PATCH for-4.16 v4] gnttab: allow setting max version per-domain
Message-ID: <YXz579WNpHe7aO91@Air-de-Roger>
References: <20211029075956.1260-1-roger.pau@citrix.com>
 <ffd27f87-9e47-12cf-2cfd-1688a19c445f@citrix.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <ffd27f87-9e47-12cf-2cfd-1688a19c445f@citrix.com>
X-ClientProxiedBy: MR1P264CA0130.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:501:51::23) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 226dfa93-30df-40d1-adc9-08d99b7a5a13
X-MS-TrafficTypeDiagnostic: DS7PR03MB5445:
X-Microsoft-Antispam-PRVS: <DS7PR03MB544507840648014BDECDCC968F889@DS7PR03MB5445.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 2C3eamT9JA9CS6o8NGEhbsa0DD843NNamdx3HujpsjUZdThTOzX4zHK/zm30kb8rnjOMfXPMygfJzsLT88HZyXg4sQx5h4Ts8ctKlKl+YByTKSs3d7yqK6gxVKwJkdXtZbVFDuAoR6CUhw/Y8SO3WJw7g+Yy8GYG7bFB9/kVB0Jai3NQ5+H+EdLIWWTbry9CbqIZ5VnqNawocg1ByC/ZBdo9rxfaA5p2pIpOu+1RBjNjKoj21vwFo15WV44YBUcbr9yQD48ZRkgOgdKUHEulqpQaYsORLFZm13F11a+No3wa+o6OPsR+dcfvkIGhQxHwy9ri7k46+0xPnaKVaSmrZ/8uasA397FfpIIucB+yODNFkjNHkYdsc671Ff5wT4VnjQFQPZ9ql7cEUpUhr6aCNncdbfyd1ksqYAftf3VluL50b1+kp5lpoFhWJyNp7Ci10xdx83MYEyDm64Nb2redxPL0CYtDPXxEQqkht/HKSuTNnmOpUCjs2sR0Er80/Mx7CjNMEcIBd4tgA39BiF3B2XmLBD0gpjk348gMBMm4l0IGrSdxsbnjB8Mh27LFQKk6seg5CFeljOO6rP3+N2OPQADhN/P+YnHKTjlijYQpQOEdgq0ZAEb3j8UU8Xhk80E2UUmLaCVIqbSuHKlCbAt0/w==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(7916004)(4636009)(366004)(6486002)(26005)(66476007)(85182001)(508600001)(186003)(6496006)(6636002)(8936002)(82960400001)(86362001)(956004)(8676002)(66946007)(4326008)(54906003)(9686003)(33716001)(38100700002)(66556008)(6666004)(5660300002)(6862004)(53546011)(316002)(2906002)(83380400001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Qm95NGQrYTdkSTVnNUo0WVpNc2ZIM20xRGdDaGZaNU10OTF0Z1lsR2M2em1p?=
 =?utf-8?B?YitGZHdScXYvWWpUNlpsRkhiSG5DYncrQ2pBMnVDMjFqZGhDbndXelNCQ08x?=
 =?utf-8?B?YU81VUhHUFNHeENwRk1XRzllU00vZkE1OGFLclhtV2RtaXJBZzB5bjlEUzFs?=
 =?utf-8?B?dFlkcEpNZGxXa3pYd2g5dTdrdG9vNkxhNEtrakRoTElEc3dEWXV6NStrcCtI?=
 =?utf-8?B?YzQwd1Qvc05BY1RCSEdoQ0ZiSGkyWkJBelcydHAyL0YvS3JHTWI3K2tLWW0r?=
 =?utf-8?B?REhmdFVrL0pXbFYvQ3E5YmpaKyttcVRzSkVYeXhUNStNYWJ3Z1pvWGtNbk1v?=
 =?utf-8?B?TUZIdW92SXNQdSt2UTAyT2V2cXA2ZFAxdk44MlE4YXk5YVBJUU1TcUJnb3Av?=
 =?utf-8?B?a2pzZmFGbnN0SHBrM1ZPYmNLekNqVE1vYTJJM3c4T3ZOajdJNENuT0E1L1Jn?=
 =?utf-8?B?czF0UkZJRzB0ZXRWTEx3aXh1YUw2NTRGVW4yZ0FjYlpBajJMT1dWVllCeWlz?=
 =?utf-8?B?anRrRVN0eG41ZmRFcjcraHhBckZmSEg4WTVhS3VhL0p6bmdVRkdaSCsyVFhs?=
 =?utf-8?B?bG44UmFrM2UwYk5QcmZWd3VGa0l0ZlY2YWV2RGVtUDl4clRTNmJOMUpYV0or?=
 =?utf-8?B?WjFkWlJuS2hOOSt1RlRBZjBVNlVjVVhTREZkQ09xeThSVTllQmdkTVhSWEVa?=
 =?utf-8?B?MnRFbnRjVS9zT2ZtNEJJOUZBNVhtOGt2cnlkZHFqSG9Nazg2UWFodTdrM3JL?=
 =?utf-8?B?aVp0VU5JdHVON0hseVNzSVF3THg4YmVXajZQdkNTNXVOLzZlK2k0ZndvdEY4?=
 =?utf-8?B?MkhBQWNiaWJmTStiM3JLQ3BlL01xYmUxMzB0bm5tdDZTSlJsR0VrS2dMSFRI?=
 =?utf-8?B?REl6SDd3S1RDZFEzRGNyK3BUREJWRzdsU0VKQmhWWm1nNHpYbEVKR1Z5aFQr?=
 =?utf-8?B?MHVPSUxXbHM2c2RsTEpXdUFQeEtWaHdHbmRIOFZTMnZpUjg5eXpodmtFUE82?=
 =?utf-8?B?NHRQTlZYZmF3cVd4OHY1QzF1aU1IN1FRVHMzWGJrVEJsNE0zc2tFWU0rUUNH?=
 =?utf-8?B?cXJsdnJHRVUyNG96ekxPYWFYZ09BWTJKRS9iMElaamJaeWdSZlJ0c0xTYlNK?=
 =?utf-8?B?Z1k3U1p6ckJ2WFRMZFhnMEovZXkxckxrUkNxTFFYTnlLUWZZZWIxTGhBYnJt?=
 =?utf-8?B?K0FzNDZVYWxIaEtwSHErcmx6QmFhVWp2cHdpWmJCcXZ3TUNWSHkxZlRsbXFR?=
 =?utf-8?B?YWpSV0tTZlFJeDk3Zjd5TERKQzUwYmNhU0lvaHJFdDh6bjlCdWIycFBZb0d1?=
 =?utf-8?B?UkxZSnJZM0VWNzRNUkVnSXppR1FPMUx6V21UV3ZOeGt6ZWpyUHNkc0pPcXZQ?=
 =?utf-8?B?ZWo4QXAvbzZuZ3VQWE8wVXRPcnZCK1dpb0NUaTJPUnhuRmJIOHNlek1FVFZn?=
 =?utf-8?B?RkUvVFFSU2FWV0hTWldmNFBaTDQwbHVtbVFwckRFNkYwQ2hraXZSMkNZQ3lH?=
 =?utf-8?B?cWp0RWJteGpuVVJleWZOOU1rSjQvMnlPK2ZBY0tIUFVUMGtWZ3BMSzFXcys3?=
 =?utf-8?B?VVlwSUhxRE1HenI5RnJRQ3EzYTlYWTBYZ202Mzd0UVQ1TUluV0djY1pNbkV0?=
 =?utf-8?B?UDNxZ1VoNFo2b0IwK2U2SEFTUmFLNVdRN1FUbXlqRGk2YjJnM005Mlp0cmhw?=
 =?utf-8?B?WU1UaHpxUkVjcDQ1M0ZBcm1HSFhrZ1IvWmhLSDNBNTlaNzUrQXBTendkSGRS?=
 =?utf-8?B?WU9hSklsL1l5ZzVxTzBLNDRzOGJodFVIeUE5SVZnMVp1QmVrNTZiVWN0cDYv?=
 =?utf-8?B?MWhoc3FCSTVKRFJyZEdITlFtYnl3emlyWVFWQnE1QWpVajRvT2tDZXZvd3Fm?=
 =?utf-8?B?bjJWazBFdFk4OUZDaUh2dWhVQ0dVVTBIV29FOThvdzV6eDNNY0ZidEo2ckJT?=
 =?utf-8?B?c2dYQTgrNHF6SnBRcnd2Z1RxbS9BNDZqVkdCUEMyWUxxQUNuWEdoOXo3QUN2?=
 =?utf-8?B?dkZYWE5FMnNNZzdwR28vRW43YmZMeXF2YWU5blhrc1o3d1lqbGJ5Szh2VjNT?=
 =?utf-8?B?bk1yQVh5b3FETnl1TDRaL1Ntc2dHbG9JTUY4MWF5bWJPUjNyZVdXRTRwa2ll?=
 =?utf-8?B?UTBadlVRN1FNMkpFeDJpRUtObG1kaDRnZlJ6Z0x6aWpqazdkdHNNRnNVQ3FW?=
 =?utf-8?Q?GX6FV6Yyapc+JkToTnwF9dU=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 226dfa93-30df-40d1-adc9-08d99b7a5a13
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Oct 2021 07:53:25.1082
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5JjyzrjxMyH/laEHouSxmkSXzxcl8UKzNP6lT+VbW3/HmQi0f6wBPzPl+QPYfPUTC0v4g6b71TP9cxAO33P+Rg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR03MB5445
X-OriginatorOrg: citrix.com

On Fri, Oct 29, 2021 at 05:39:52PM +0100, Andrew Cooper wrote:
> On 29/10/2021 08:59, Roger Pau Monne wrote:
> > diff --git a/xen/common/grant_table.c b/xen/common/grant_table.c
> > index e510395d08..f94f0f272c 100644
> > --- a/xen/common/grant_table.c
> > +++ b/xen/common/grant_table.c
> > @@ -1917,11 +1918,33 @@ active_alloc_failed:
> >  }
> >  
> >  int grant_table_init(struct domain *d, int max_grant_frames,
> > -                     int max_maptrack_frames)
> > +                     int max_maptrack_frames, unsigned int options)
> >  {
> >      struct grant_table *gt;
> > +    unsigned int max_grant_version = options & XEN_DOMCTL_GRANT_version_mask;
> >      int ret = -ENOMEM;
> >  
> > +    if ( max_grant_version == XEN_DOMCTL_GRANT_version_default )
> > +        max_grant_version = opt_gnttab_max_version;
> > +    if ( !max_grant_version )
> > +    {
> > +        dprintk(XENLOG_INFO, "%pd: invalid grant table version 0 requested\n",
> > +                d);
> > +        return -EINVAL;
> > +    }
> > +    if ( max_grant_version > opt_gnttab_max_version )
> > +    {
> > +        dprintk(XENLOG_INFO,
> > +                "%pd: requested grant version (%u) greater than supported (%u)\n",
> > +                d, max_grant_version, opt_gnttab_max_version);
> > +        return -EINVAL;
> > +    }
> 
> I think this wants to live in sanitise_domain_config() along with all
> the other auditing of flags and settings.

The reason to place those there is that the sanity checks for the
other grant table related parameters (max_grant_frames and
max_maptrack_frames) are performed in this function also. I think it's
better to keep the checks together.

We should consider exporting the relevant values from grant table
code and then moving all the checks to sanitise_domain_config, but
likely a follow up work given the current point in the release.

> Also, it can be simplified:
> 
> if ( max_grant_version < 1 ||
>     max_grant_version > opt_gnttab_max_version )
> {
>     dprintk(XENLOG_INFO, "Requested gnttab max version %u outside of
> supported range [%u, %u]\n", ...);
> }

It was originally done this way so that the first check
(!max_grant_version) could be adjusted when support for
max_grant_version == 0 was introduced [0] in order to signal the
disabling of grant tables altogether.

> 
> 
> > +    if ( unlikely(max_page >= PFN_DOWN(TB(16))) && is_pv_domain(d) &&
> > +         max_grant_version < 2 )
> > +        dprintk(XENLOG_INFO,
> > +                "%pd: host memory above 16Tb and grant table v2 disabled\n",
> > +                d);
> 
> This is rather more complicated.
> 
> For PV, this going wrong in the first place is conditional on CONFIG_BIGMEM.
> For HVM, it the guest address size, not the host.
> For ARM, I don't even know, because I've lost track of which bits of the
> ABI are directmap in an otherwise translated domain.

This was only aiming to cover the PV case, which I think it's the more
likely one. It's possible there's people attempting to create PV
guests on a 16TB machine, but I think it's more unlikely that the
guest itself will have 16TB of RAM.

> I think it is probably useful to do something about it, but probably not
> in this patch.

I'm fine with this, we had no warning at all before, so I don't think
it should be a hard requirement to add one now. It would be nice if
there's consensus, but otherwise let's just skip it.

> Perhaps modify domain_set_alloc_bitsize() to impose an upper limit for
> the "host memory size matters" cases?
> 
> For the guest address size cases, this possibly wants to feed in to the
> max policy calculations in the same way that shadow kinda does.

So grant table version will basically clamp the amount of memory a
guest can use?

What about guests that doesn't use grant tables at all, do we expect
those to set the future max_grant_version to 0 in order to avoid the
clamping without having to expose grant v2?

> > diff --git a/xen/include/public/domctl.h b/xen/include/public/domctl.h
> > index 51017b47bc..0ec57614bd 100644
> > --- a/xen/include/public/domctl.h
> > +++ b/xen/include/public/domctl.h
> > @@ -89,14 +89,20 @@ struct xen_domctl_createdomain {
> >      /*
> >       * Various domain limits, which impact the quantity of resources
> >       * (global mapping space, xenheap, etc) a guest may consume.  For
> > -     * max_grant_frames and max_maptrack_frames, < 0 means "use the
> > -     * default maximum value in the hypervisor".
> > +     * max_grant_frames, max_maptrack_frames and max_gnttab_version < 0
> > +     * means "use the default maximum value in the hypervisor".
> >       */
> >      uint32_t max_vcpus;
> >      uint32_t max_evtchn_port;
> >      int32_t max_grant_frames;
> >      int32_t max_maptrack_frames;
> >  
> > +/* Grant version, use low 4 bits. */
> > +#define XEN_DOMCTL_GRANT_version_mask    0xf
> > +#define XEN_DOMCTL_GRANT_version_default 0xf
> 
> This needs to be a toolstack decision, not something in Xen.  This
> doesn't fix the case where VMs can't cope with change underfoot.
> 
> It is fine for the user say "use the default", but this must be turned
> into an explicit 1 or 2 by the toolstack, so that the version(s) visible
> to the guest remains invariant while it is booted.

Please bear with me, as I'm afraid I don't understand why this is
relevant. Allowed max grant version can only change as a result of a
migration, and A VM being booted cannot (usually) be migrated, as it
requires guest cooperation (and a fully setup xenstore).

Any guest allowing migration during boot (which is AFAICT the only way
for a max grant table version change) should be capable of handling
the max grant table version changing on resume, whereas this resume
happens in the middle of the boot process is a guest decision, and it
should be capable of handling such changes, or else refuse to suspend
during boot. Any resume process will always involve a
re-initialization of the grant table.

If the intent is to make this compatible with transparent live
migration I think there are also other grant table structures that
will need to be migrated in that case, and thus the version would
already be conveyed there.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Sat Oct 30 08:18:28 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 30 Oct 2021 08:18:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.218728.379280 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgjZ6-0003sO-So; Sat, 30 Oct 2021 08:18:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 218728.379280; Sat, 30 Oct 2021 08:18:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgjZ6-0003sH-Pf; Sat, 30 Oct 2021 08:18:12 +0000
Received: by outflank-mailman (input) for mailman id 218728;
 Sat, 30 Oct 2021 08:18:11 +0000
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]
 helo=us1-amaz-eas2.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=b4cL=PS=citrix.com=roger.pau@srs-us1.protection.inumbo.net>)
 id 1mgjZ5-0003sB-5D
 for xen-devel@lists.xenproject.org; Sat, 30 Oct 2021 08:18:11 +0000
Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168])
 by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS
 id eaa25c2c-3959-11ec-8525-12813bfff9fa;
 Sat, 30 Oct 2021 08:18:09 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: eaa25c2c-3959-11ec-8525-12813bfff9fa
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1635581889;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=cbbDuS2FKanmNTOeis47ln1sr9u/6vxwuceh6bT9SYc=;
  b=XvHOE6WgnR54CkN3e7PvYd2jsJOwY0314PtndQfkdAyrusz7E5xvxQ9E
   JVq8KCRsBjZNkGXtAmq4A5uXLMRcmBjQCIwIUhwlUSNvF2ldLFOh4DdZM
   tf0a8MdTq/ZgzULsvqhYJiuMsa94FcWeFfCq5FuPo8ENO7l3eQ7uRAQiS
   Q=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: AVpZ3E+KDDQeK9B22SNoHiNKdUbZVM0/rGiNtca8X4wWBpljgNjZK9I4RhrWhAYj94JXaxJ6jx
 V8+Mt/TuPQhMuQuJIfjRj03NU1Z6MKP3AySuVa/B5vENk52FoKxpeHOD2GvN2y9Pczv9wpHqkU
 hFGewgSsZZd6r5CH7dgK9J+vL08fn35vpAqREpu9N1PPwSsDS+xfCl930c2f+zFdycPHcYvthm
 MZDkB6DJXzgkWaz72cDXh5X0uyMQKe1mmHHyfTWJfctHi44YuTnfvO2X2H/Rk59sUP7C7zHxvn
 t8QE7ORM17FA/PMIj7ZCyquq
X-SBRS: 5.1
X-MesageID: 56243584
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:JOGg8KvrT2hRsOofQhIkyCi7JOfnVL1ZMUV32f8akzHdYApBsoF/q
 tZmKWGBO/vcZGbxKN8lbNjio0pSvcfXmoRgTwFoqy5jHylG+JbJXdiXEBz9bniYRiHhoOOLz
 Cm8hv3odp1coqr0/0/1WlTZQP0VOZigHtIQMsadUsxKbVIiGHhJZS5LwbZj29cw24nhWGthh
 PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe
 gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ
 NpljJ7hbwoYMYf1vu0ZaAZSLitkHax3weqSSZS/mZT7I0zudnLtx7NlDV0sPJ1e8eFyaY1M3
 aVGcnZXNEnF3r/ohuLgIgVvrp1LwM3DJoQQt2sm1TjEJf0nXYrCU+PB4towMDIY254UQa2DN
 5ZxhTxHTj/+YCBTP24uDsgijaCDoyCkfT11gQfAzUYwyzeKl1EguFT3C/LKfvSaSMMTmVyXz
 krH4GbREhwcLMaYyzeO7jSrnOCntTP2XsceGaO18tZugUaP3SoDBRsOT1y5rPKlzEmkVLp3C
 WYZ5y4vpqga71GwQ5/2WBjQnZKflkdCAZwKSbR8sVzTjPqPi+qEOoQaZgdDOforhcAcfBoj0
 mSWle7jHxxugYTAHBpx6YyohT+1PCEUK0oLaikFURYJ7rHfnW0jsv7cZo09SfDo17UZDRm1m
 mnX93Zm293/mOZSj/3jlW0rlQ5AsXQgouQdwgzMFlyo4QpiDGJOT9z5sAOLhRqswWvwc7Vgg
 JTms5TBhAztJcvU/MBofAnrNOvxjxpiGGaF6WOD57F7q1yQF4eLJOi8Gg1WKkZzKdojcjT0e
 kLVsg45zMYNZyb3NvUmPNrrUp9CIU3c+TLNDKi8gj1mOcEZSeN61Hs2OR74M57FyRBEfV4D1
 WezLp/3UCdy5VVPxzuqXeYNuYLHNQhlrV4/savTlkz9uZLHPSb9Ye5cbDOmM7BohIvZ8V692
 4sOaKO3J+B3DbSWjt//qtVIczjn7BETWPjLliCgXrfYf1c9Rz15U5c8A9oJIuRYokicrc+Rl
 lmVUU5E0lvvw3rBLASBcHd4b73zG514qBoG0eYEZD5EAlAvPtSi6rkxbZwyceV1/eBv16csH
 fIEZ9+BErJETTGeo2YRapz0rYpDchW3hF3RY3r5MWZnJ5MwFRbU/tLEfxf08HVcBCSAqsZj8
 aar0RnWQMRfSl06XtrWcv+m03i4oWMZxLBpR0LNL9QKIBfs/YFmJjbflPgyJ81QexzPyiHDj
 1SdAAsCpPmLqIgwqYGbiaeBpoavMu1/AksFQDWLsefobXHXpzPxz5VBXeCEeSHmeFn1oKjyN
 /9Iy/zcMeEcmAoYuYRLDLs2n7k14MHipuEGw108TmnLdVmiFphpPmKCgZtUrqRIy7JU5Vm2V
 0aI9oUIMLmFIpq4QlsYJQ5jZeWfz/AE3DLV6K1tckn94SZ2+puBUFlTYEbQ2HAMcuMtPdN32
 /olte4X9xe720gjPduxhyxJ83iBcy4bWKI9u5BGWILmh2LHEL2ZjUAw3sMu3KyyVg==
IronPort-HdrOrdr: A9a23:IlaWOaCM8AGpCmPlHeg2sceALOsnbusQ8zAXPh9KJiC9I/b1qy
 nxppkmPH/P6Qr4WBkb6Le90Y27MAnhHPlOkPQs1NaZLXLbUQ6TQr2KgrGSoQEIdxeOk9K1kJ
 0QD5SWa+eAfGSS7/yKmTVQeuxIqLLskNHK9JfjJjVWPHlXgslbnnlE422gYytLrWd9dP4E/M
 323Ls5m9PsQwVcUu2LQl0+G8TTrdzCk5zrJTYAGh4c8QGLyRel8qTzHRS01goXF2on+8ZvzU
 H11yjCoomzufCyzRHRk0fV8pRtgdPkjv9OHtaFhMQ5IijlziyoeINicbufuy1dmpDj1H8a1P
 335zswNcV67H3cOkmzvBvWwgHllA0j7nfzoGXoyEfLkIjcfnYXGsBBjYVWfl/y8Ew7puxx16
 pNwiawq4dXJQmoplW92/H4EzVR0makq3srluAey1ZFV5EFVbNXpYsDuGtIDZY7Gj7g4oxPKp
 ghMCjl3ocUTbqmVQGagoE2q+bcG0jbXy32DXTqg/blkwS/xxtCvg8lLM92pAZ3yHtycegC2w
 3+CNUbqFh5dL5gUUtMPpZzfSKJMB25ffvtChPbHb21LtBNB5ryw6SHlIndotvaPqA18A==
X-IronPort-AV: E=Sophos;i="5.87,194,1631592000"; 
   d="scan'208";a="56243584"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=fzX4sEJaHB/AsAsyHXe06Hj0nsDX5E5rvGmz4hsuBgzK6Xm85buO1P5K5sJkO33Yseiv+o8rXixHdju+53+Zeye1B1jB+yMqqioP0Aujy6kAIBkDoyR+nSRaMEFN+JO+Y3osYj5uk81T038XzeCT2dDaHJoQt6m657KCcV6ScwaMNuSnHAaF/t6qh24jB9SrEhu1+UB6VyV6xLL8DnYA8+gsxCxyTN85YbygJ2ZjwOngp84t7IjsmVCL6XfjN/VGtl+Qg/BbXO5OGEpcuUiwr4yeOaZ40H9HjM/7U9s0wwmZwhil3JDZ2G14w4EmFmQPVqXcPqgO334HF+wif60UBQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ThJwByg0/5txHY7BxNW5mZlbW9ULEWYcHuMqtWwzpRc=;
 b=ItOyEQHATH4dnF7xRdFCacSFHRkPuHMBqvzWEHKcuvnZ2uTbuRsBHIa1R9dV34EyGcYS44UtvhO/ZtPlPMD6UATh0P44czYLaAujXJsedfidgsb4VmRystVlfqn0TsQEUfh959jbfjdI32JsOmOf23+3uIlo4tJiK7yCrIv1NaN0UOhWKtRPldnLO4KIbIdxl7NFy8m48GD8Xa+IFw5C63kkmQfssGJHZArsAGowars1XSvq9IRdrOoqeKO2Ph+fdOCJ9M+4n3UfbVAp4dpS+LslAZkvHLsvn/itKy2hgFJ3vZ5g8QR/uaE/d7K0lNirJgKoXD8PRCqLXIlg9F/Pzg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ThJwByg0/5txHY7BxNW5mZlbW9ULEWYcHuMqtWwzpRc=;
 b=czgH3p8tI5emJgEy5egu+LfRq8LkjEREWTQ4P0KKqsXn/vSz+/tK/GLwFqtVGlHP2shgK2o39+JxVpAtZz6AUN4TpqvqlHT8GzT8FF4qdFltG7mwJeTuuQEGEAAtjyv3U/nWN97Ki0fMbY6gWmnPlry2a3BR/mftCc6VbM0VXnU=
Date: Sat, 30 Oct 2021 10:18:01 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>, Jan Beulich
	<JBeulich@suse.com>, Wei Liu <wl@xen.org>, Ian Jackson <iwj@xenproject.org>
Subject: Re: [PATCH] x86/passthrough: Fix hvm_gsi_eoi() build with GCC 12
Message-ID: <YXz/uYqxfV0GaEoH@Air-de-Roger>
References: <20211027200713.22625-1-andrew.cooper3@citrix.com>
 <YXpRzHEawUZEU87h@Air-de-Roger>
 <64788530-a18c-332f-c287-84478a200816@citrix.com>
 <YXqlEQWk1HGNLKq3@Air-de-Roger>
 <99c451d7-4a7f-8dd0-17f6-92b2153d0afe@citrix.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <99c451d7-4a7f-8dd0-17f6-92b2153d0afe@citrix.com>
X-ClientProxiedBy: MR2P264CA0089.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:500:32::29) To SA0PR03MB5610.namprd03.prod.outlook.com
 (2603:10b6:806:b2::9)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 84ba1851-3a92-4ad6-2f5e-08d99b7dcd25
X-MS-TrafficTypeDiagnostic: SA2PR03MB5915:
X-Microsoft-Antispam-PRVS: <SA2PR03MB5915595B5497FD4167CD831A8F889@SA2PR03MB5915.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: QO8dXBhgAH52xHSnNd0ci0xp2ly9zroB/DJ/KRMJ3lxEc18WLhPM2NQl7dXItTrqBGz11Gg+0i0prz8MlY0ZVNqIPBjAr/PbzWJ14N5h/WjKYLCd1/LPiPpwz6avv+bp+fsQQfkiKX/W5OuEm66j9/5euYWNEVKgu12zDDcr9XldPScHLAHtFp4/pnytwH5DS0pPqgZ6fWYi4eEpe/8YZS8srXhE+YcvizX4ThEhn4BISqwHYOlz3eeJQhDaR5iSLW2EVtRmy2XW5SiVVd5zYB0TPlmMpnmjs4rc9PEMg8F0uzUUD+trwP1YGMFpiZuJ6kNz7W6iQmAKLrM94WJloGmDnkGyxcHfhTl9ej+PcHuvudMSQ9+J/wxLVISOR7wymMSYqd17MVR3NAF1iq6nCGN+2YbqeiVkMOh7+V2r7DLp2LTgJjQamLLkN8jzJ9tKnoB4R7wWXy+7QvXtTxO2FrabvR86r9eru+KZM/j+ME/ZLf3BbMso3m0cx/7ncw45oNi+S2JChZLrDkm9CFELTjeU2hLCZl3uxrM7Bk9feUa8LKe6nhC6ufSElqdCEtbowaxnzIMB6vsmc5AFO8z6OjXi13MrwWvB9JtrpUAMVzWF9nDFrDT4O806xcKK9Ou918/b0U1q6RgeGfA7laBqNA==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA0PR03MB5610.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(7916004)(366004)(508600001)(5660300002)(38100700002)(8936002)(83380400001)(6636002)(33716001)(9686003)(6862004)(4326008)(53546011)(82960400001)(2906002)(186003)(54906003)(316002)(956004)(85182001)(6666004)(86362001)(26005)(66556008)(66476007)(66946007)(6486002)(8676002)(6496006);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dlkrRU83YjdFbDA1em5VaG51bXQyaFM4TS8yNkhyQkxGazR0bFpON2U1K3I3?=
 =?utf-8?B?eFZiN2ZNSEpzZThrNTlQeXZvc0hzRmlVaVg1ODhCSFVwd1JIeWVsQlVTZUJo?=
 =?utf-8?B?SXYyMmZQVHU3QUZUb3pLVDBlTlJnbHZYUjRWdjB6SW01c2JmeE5XekwxYjVE?=
 =?utf-8?B?UmY0bVh1dG5ZbERseGxYK0RkelJyeHNkckRoSFordGp2NEJmdjg2aFVzLzZm?=
 =?utf-8?B?UC82Zk5EVTByeEp1RDlYdlJ5cmQ1V3Fja3RFdExqRDMyUzkyT3RPcDZPL3Q4?=
 =?utf-8?B?RnEycHU3SVV1cnFJUkNvbDVjSng1N0NUYmhiOExXTVdkVGNhUlRTTnhHZjVR?=
 =?utf-8?B?M3FzWVJPWjFHNElVT0kzeENhcEhkcEUvUHpEeFgrb3VTT0tKRFFENWpjWXpr?=
 =?utf-8?B?THdXcDRsNFI1YW5BdEUvaHllYXBSRFNvMktEWVRheHdQWFJjMHdjeXc5R0Ez?=
 =?utf-8?B?aGh5bUtJR25DRHdjQ0pEZFc3REZxYnRGMjF3ckh0Ylc0T1FzR0NWQ0FOWHMv?=
 =?utf-8?B?S1UxZDJzamVJYUpGVHhMdWx0SUZ1YWw3OEc3QUNQSlFzVlRxQ3UybVJwR1h3?=
 =?utf-8?B?ZEZ0QVVwNmFzSk9ETXZRVHdxWG5maTc4bitHZXZiUmZTNUllK2xqemp6RFBP?=
 =?utf-8?B?c3FnZ200bmlwQzQ1ZVBCOVR2UC83TmJIWDFmY3BDczB2b1RybWx4a0lqd3dV?=
 =?utf-8?B?RzdKWjZGUmNuZ2FRVnl4bEtSaTBkdGF2VjZlMHZHRDBEaHpMYnBWcTd5K1ht?=
 =?utf-8?B?ZnBmSUcyRC9pZkFLWFNUdXNrRW5vY2xDb2twN3dBdS9FRjhXbHBGSXdEdjls?=
 =?utf-8?B?Q1B1cTBxV25iaWYxZ2twWDR0d2p1ekhDYnZqVk1selRHWEpZTjd1RENsalNz?=
 =?utf-8?B?WFhIZFdIYmd4QWFPY0dxSFBxcERnaFhlem5iVTYzWnN3Rll4UmFPbFI1d3pB?=
 =?utf-8?B?QWRSTGxTeGhlKzZsK3RmN0JFR05TcWl3ZXhYTVA4MUFCQTIvU0ZKUHdNZ28z?=
 =?utf-8?B?cXJDbHR3WHZnMVVjTE9oUjI5M3Y5Z2V2NENGeVRpaVcvNVVrcmVVU3pXQ3ZS?=
 =?utf-8?B?clorU1NyRXcwTDlabWszMDZDUFBZQlR5czNuWEthODBoNkxsd3lwaGltcEsz?=
 =?utf-8?B?VnR4bHlQU2dmUjI4TUFzWUVGUmhIWmJrejRacG1NVVVabXBHMlBqM0hDVkNu?=
 =?utf-8?B?TzcwSTA2SS9rZ3JlZHlUVU9tdEQrcUFBdHovc3pXUzZaVmx2MDAwdnhGVkFM?=
 =?utf-8?B?aUxOdDYwTDRWdmxwMUQ2UnNOcW1GVnVCaWVtTWp6Q1UxSUZlV1YvL1RLUnNZ?=
 =?utf-8?B?eEV0MXd6VW1JbDBxbVMzejFSZkhYUjRhdTV3bEJwVTF6UlZCMG8vaTZqQk1s?=
 =?utf-8?B?T1B2K21sZmNKWGk5VmtuYk4rOTFOUnAzSm5LOHpkOHY0QVB6N1ZWdjhVWjZE?=
 =?utf-8?B?emJ2NG9XMGJIWEY3V1l5dlRFVE9ibk4rczdPdjczT00zMzRmTDZtRUZkNXVX?=
 =?utf-8?B?MFJNN3VrR3JmNE5vZHhxbk9Qa0t2VkZhTitlMUYrbXNwdjVvWDQ0Tk5abDQy?=
 =?utf-8?B?TnVlcnl3RmFKMG54ZXNudWc5MGsrSTJLem9MV3VjYmg0VS80QUpsaERzQUgv?=
 =?utf-8?B?OUE4REdQc3VVMWJaS3RrUU0raDZ3YjF0VVVyUWQxT3kyWWs5MDg1MFhVOVFm?=
 =?utf-8?B?QkE4MUtpYkgxTlE2Y0RwR2lkaFVDYmh0cU1qRm04NWJiYWd0L1BkdS9MWGNr?=
 =?utf-8?B?VXZYSjRpWkI0TjlrRFpOUGpXWWFOeVN6MmpUUkJHTEdpOSs0MXpOaDI0WTRX?=
 =?utf-8?B?SHBYbHBmbDdWVGxFT1NoNkZFTEVteGVFYk1hTUVQcWJvNnIycmdvWVY4OHlS?=
 =?utf-8?B?OFFnRDU4RFVKVUxPYjVMdWErb2paZ3pML3M1WTExN0QxVUhqZG5Cdml6eDdz?=
 =?utf-8?B?RUcyQ3FaNDNjZWxUSERULzhudUFFYXk3dlpBRzROUDJGUTNuK2pNRUg2Z0J6?=
 =?utf-8?B?eVlZRU9wcmJwZDFzSmlvc1VGcnFmQWJnUEdqSEN1b2ltU09XN1pqQ1NVRU5E?=
 =?utf-8?B?cEtxV001STRMM1YwTFl1YTFoc0JROFdqMHpMSk1teEszbFZBL0lUTTVYYVFO?=
 =?utf-8?B?QkdpRnA1ampYWTRxa2hpak1LNmNKNTl1KzhhWURJNjlDTDMvb25WZHRmMWhi?=
 =?utf-8?Q?Iaa6mcy6eBQEy0jugqF+YYA=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 84ba1851-3a92-4ad6-2f5e-08d99b7dcd25
X-MS-Exchange-CrossTenant-AuthSource: SA0PR03MB5610.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Oct 2021 08:18:06.7397
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: w6IH6d7GMnnHpb/dySETjsH+kSyf++AfFmyshkllG6lDQedWyE2EtQpcqfac1cJLgH/d0PRZI6T5r+jAzsw3cg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR03MB5915
X-OriginatorOrg: citrix.com

On Fri, Oct 29, 2021 at 07:06:43PM +0100, Andrew Cooper wrote:
> On 28/10/2021 14:26, Roger Pau Monné wrote:
> > On Thu, Oct 28, 2021 at 01:15:13PM +0100, Andrew Cooper wrote:
> >> On 28/10/2021 08:31, Roger Pau Monné wrote:
> >>> On Wed, Oct 27, 2021 at 09:07:13PM +0100, Andrew Cooper wrote:
> >>>> GCC master (nearly version 12) complains:
> >>>>
> >>>>   hvm.c: In function 'hvm_gsi_eoi':
> >>>>   hvm.c:905:10: error: the comparison will always evaluate as 'true' for the
> >>>>   address of 'dpci' will never be NULL [-Werror=address]
> >>>>     905 |     if ( !pirq_dpci(pirq) )
> >>>>         |          ^
> >>>>   In file included from /local/xen.git/xen/include/xen/irq.h:73,
> >>>>                    from /local/xen.git/xen/include/xen/pci.h:13,
> >>>>                    from /local/xen.git/xen/include/asm/hvm/io.h:22,
> >>>>                    from /local/xen.git/xen/include/asm/hvm/domain.h:27,
> >>>>                    from /local/xen.git/xen/include/asm/domain.h:7,
> >>>>                    from /local/xen.git/xen/include/xen/domain.h:8,
> >>>>                    from /local/xen.git/xen/include/xen/sched.h:11,
> >>>>                    from /local/xen.git/xen/include/xen/event.h:12,
> >>>>                    from hvm.c:20:
> >>>>   /local/xen.git/xen/include/asm/irq.h:140:34: note: 'dpci' declared here
> >>>>     140 |             struct hvm_pirq_dpci dpci;
> >>>>         |                                  ^~~~
> >>>>
> >>>> The location marker is unhelpfully positioned and upstream may get around to
> >>>> fixing it.  The complaint is intended to be:
> >>>>
> >>>>   if ( !((pirq) ? &(pirq)->arch.hvm.dpci : NULL) )
> >>>>                   ^~~~~~~~~~~~~~~~~~~~~~
> >>>>
> >>>> which is a hint that the code is should be simplified to just:
> >>>>
> >>>>   if ( !pirq )
> >>> I likely need more coffee, but doesn't this exploit how the macro
> >>> (pirq_dpci) is currently coded?
> >> The way pirq_dpci() is currently coded, this is nonsense, which GCC is
> >> now highlighting.
> >>
> >> It would be a very different thing if the logic said:
> >>
> >> struct pirq *pirq = pirq_info(d, gsi);
> >> struct hvm_pirq_dpci *dpci = pirq_dpci(pirq);
> >>
> >> /* Check if GSI is actually mapped. */
> >> if ( !dpci )
> >>     return;
> >>
> >> but it doesn't. Getting a non-null pirq pointer from pirq_info(d, gsi)
> >> does identify that the GSI is mapped, and the dpci nested structure is
> >> not used in this function.  I would expect this property to remain true
> >> even if we alter the data layout.
> > I think we have further assertions that this will be true:
> >
> >  1. d can only be an HVM domain given the callers of the function.
> >  2. The pirq struct is obtained from the list of pirqs owned by d.
> >
> > In which case it's assured that the pirq will always have a dpci. I
> > think it might be better if the check was replaced with:
> >
> > if ( !is_hvm_domain(d) || !pirq )
> > {
> >     ASSERT(is_hvm_domain(d));
> >     return;
> > }
> >
> > Here Xen cares that pirq is not NULL and that d is an HVM domain
> > because hvm_gsi_deassert will assume so.
> 
> We're several calls deep in an hvm-named codepath, called exclusively
> from logic in arch/x86/hvm/
> 
> is_hvm_domain() is far from free, and while I'm in favour of having
> suitable sanity checks in appropriate places, I don't even think:
> 
> {
>     struct pirq *pirq = pirq_info(d, gsi);
> 
>     ASSERT(is_hvm_domain(d));
> 
>     if ( !pirq )
>         return;
> ...
> 
> would be appropriate in this case.

Fine:

Acked-by: Roger Pau Monné <roger.pau@citrix.com>

I think I would prefer if you could slightly adjust the commit message
to mention that is already exclusively called from HVM only paths,
and that as such the HVM related dpirq structures will always be
present.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Sat Oct 30 09:13:51 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 30 Oct 2021 09:13:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.218735.379291 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgkQb-00018O-34; Sat, 30 Oct 2021 09:13:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 218735.379291; Sat, 30 Oct 2021 09:13:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgkQa-00018H-W6; Sat, 30 Oct 2021 09:13:28 +0000
Received: by outflank-mailman (input) for mailman id 218735;
 Sat, 30 Oct 2021 09:13:27 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mgkQZ-000187-Mm; Sat, 30 Oct 2021 09:13:27 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mgkQZ-0001y4-IT; Sat, 30 Oct 2021 09:13:27 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mgkQZ-000675-6f; Sat, 30 Oct 2021 09:13:27 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mgkQZ-0006Hu-6A; Sat, 30 Oct 2021 09:13:27 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=kLqT1D0E4mFQB/o9T3Hjc1vkO9PUjec76UhqKkve8Eo=; b=rVWm+p7ctntymu9OlX+9iTCsPO
	yEqA64WT0fPmqtQrG4h5c8Rn0ngS11lBoiUMdyU/zcPWjVib0TA5OnPMC3vuEQJwYn951KKQ1aY3u
	bt5SRyiqCU5ACQZYmsVa66Eanqy52svvlNuyD33i4wgDEkQxd4BaWNMQdp+LhWdV0iss=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165944-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 165944: regressions - FAIL
X-Osstest-Failures:
    libvirt:build-armhf-libvirt:libvirt-build:fail:regression
    libvirt:build-amd64-libvirt:libvirt-build:fail:regression
    libvirt:build-i386-libvirt:libvirt-build:fail:regression
    libvirt:build-arm64-libvirt:libvirt-build:fail:regression
    libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    libvirt=301eb149cef569d4fb3a662bd9ef2460fb7c5e3b
X-Osstest-Versions-That:
    libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 30 Oct 2021 09:13:27 +0000

flight 165944 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165944/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-armhf-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-amd64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-i386-libvirt            6 libvirt-build            fail REGR. vs. 151777
 build-arm64-libvirt           6 libvirt-build            fail REGR. vs. 151777

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-libvirt-vhd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a

version targeted for testing:
 libvirt              301eb149cef569d4fb3a662bd9ef2460fb7c5e3b
baseline version:
 libvirt              2c846fa6bcc11929c9fb857a22430fb9945654ad

Last test of basis   151777  2020-07-10 04:19:19 Z  477 days
Failing since        151818  2020-07-11 04:18:52 Z  476 days  462 attempts
Testing same since   165944  2021-10-30 04:20:11 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
    Adolfo Jayme Barrientos <fitoschido@gmail.com>
  Aleksandr Alekseev <alexander.alekseev@virtuozzo.com>
  Aleksei Zakharov <zaharov@selectel.ru>
  Andika Triwidada <andika@gmail.com>
  Andrea Bolognani <abologna@redhat.com>
  Ani Sinha <ani@anisinha.ca>
  Balázs Meskó <meskobalazs@mailbox.org>
  Barrett Schonefeld <bschoney@utexas.edu>
  Bastian Germann <bastiangermann@fishpost.de>
  Bastien Orivel <bastien.orivel@diateam.net>
  BiaoXiang Ye <yebiaoxiang@huawei.com>
  Bihong Yu <yubihong@huawei.com>
  Binfeng Wu <wubinfeng@huawei.com>
  Bjoern Walk <bwalk@linux.ibm.com>
  Boris Fiuczynski <fiuczy@linux.ibm.com>
  Brian Turek <brian.turek@gmail.com>
  Bruno Haible <bruno@clisp.org>
  Chris Mayo <aklhfex@gmail.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Ehrhardt <christian.ehrhardt@canonical.com>
  Christian Kirbach <christian.kirbach@gmail.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Cole Robinson <crobinso@redhat.com>
  Collin Walling <walling@linux.ibm.com>
  Cornelia Huck <cohuck@redhat.com>
  Cédric Bosdonnat <cbosdonnat@suse.com>
  Côme Borsoi <fedora@borsoi.fr>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniel Letai <dani@letai.org.il>
  Daniel P. Berrange <berrange@redhat.com>
  Daniel P. Berrangé <berrange@redhat.com>
  Didik Supriadi <didiksupriadi41@gmail.com>
  dinglimin <dinglimin@cmss.chinamobile.com>
  Dmitrii Shcherbakov <dmitrii.shcherbakov@canonical.com>
  Dmytro Linkin <dlinkin@nvidia.com>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Eric Farman <farman@linux.ibm.com>
  Erik Skultety <eskultet@redhat.com>
  Fabian Affolter <mail@fabian-affolter.ch>
  Fabian Freyer <fabian.freyer@physik.tu-berlin.de>
  Fabiano Fidêncio <fabiano@fidencio.org>
  Fangge Jin <fjin@redhat.com>
  Farhan Ali <alifm@linux.ibm.com>
  Fedora Weblate Translation <i18n@lists.fedoraproject.org>
  Franck Ridel <fridel@protonmail.com>
  Gavi Teitz <gavi@nvidia.com>
  gongwei <gongwei@smartx.com>
  Guoyi Tu<tu.guoyi@h3c.com>
  Göran Uddeborg <goeran@uddeborg.se>
  Halil Pasic <pasic@linux.ibm.com>
  Han Han <hhan@redhat.com>
  Hao Wang <wanghao232@huawei.com>
  Hela Basa <r45xveza@pm.me>
  Helmut Grohne <helmut@subdivi.de>
  Hiroki Narukawa <hnarukaw@yahoo-corp.jp>
  Ian Wienand <iwienand@redhat.com>
  Jakob Meng <jakobmeng@web.de>
  Jamie Strandboge <jamie@canonical.com>
  Jamie Strandboge <jamie@ubuntu.com>
  Jan Kuparinen <copper_fin@hotmail.com>
  jason lee <ppark5237@gmail.com>
  Jean-Baptiste Holcroft <jean-baptiste@holcroft.fr>
  Jia Zhou <zhou.jia2@zte.com.cn>
  Jianan Gao <jgao@redhat.com>
  Jim Fehlig <jfehlig@suse.com>
  Jin Yan <jinyan12@huawei.com>
  Jinsheng Zhang <zhangjl02@inspur.com>
  Jiri Denemark <jdenemar@redhat.com>
  John Ferlan <jferlan@redhat.com>
  Jonathan Watt <jwatt@jwatt.org>
  Jonathon Jongsma <jjongsma@redhat.com>
  Julio Faracco <jcfaracco@gmail.com>
  Justin Gatzen <justin.gatzen@gmail.com>
  Ján Tomko <jtomko@redhat.com>
  Kashyap Chamarthy <kchamart@redhat.com>
  Kevin Locke <kevin@kevinlocke.name>
  Kristina Hanicova <khanicov@redhat.com>
  Laine Stump <laine@redhat.com>
  Laszlo Ersek <lersek@redhat.com>
  Lee Yarwood <lyarwood@redhat.com>
  Lei Yang <yanglei209@huawei.com>
  Liao Pingfang <liao.pingfang@zte.com.cn>
  Lin Ma <lma@suse.com>
  Lin Ma <lma@suse.de>
  Lin Ma <morecache@gmail.com>
  Liu Yiding <liuyd.fnst@fujitsu.com>
  Luke Yue <lukedyue@gmail.com>
  Luyao Zhong <luyao.zhong@intel.com>
  Marc Hartmayer <mhartmay@linux.ibm.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Markus Schade <markus.schade@hetzner.com>
  Martin Kletzander <mkletzan@redhat.com>
  Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
  Matej Cepl <mcepl@cepl.eu>
  Matt Coleman <matt@datto.com>
  Matt Coleman <mcoleman@datto.com>
  Mauro Matteo Cascella <mcascell@redhat.com>
  Meina Li <meili@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Michał Smyk <fedora@smyk.it>
  Milo Casagrande <milo@milo.name>
  Moshe Levi <moshele@nvidia.com>
  Muha Aliss <muhaaliss@gmail.com>
  Nathan <nathan95@live.it>
  Neal Gompa <ngompa13@gmail.com>
  Nick Chevsky <nchevsky@gmail.com>
  Nick Shyrokovskiy <nshyrokovskiy@gmail.com>
  Nickys Music Group <nickys.music.group@gmail.com>
  Nico Pache <npache@redhat.com>
  Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
  Olaf Hering <olaf@aepfle.de>
  Olesya Gerasimenko <gammaray@basealt.ru>
  Or Ozeri <oro@il.ibm.com>
  Orion Poplawski <orion@nwra.com>
  Pany <geekpany@gmail.com>
  Patrick Magauran <patmagauran.j@gmail.com>
  Paulo de Rezende Pinatti <ppinatti@linux.ibm.com>
  Pavel Hrdina <phrdina@redhat.com>
  Peng Liang <liangpeng10@huawei.com>
  Peter Krempa <pkrempa@redhat.com>
  Pino Toscano <ptoscano@redhat.com>
  Pino Toscano <toscano.pino@tiscali.it>
  Piotr Drąg <piotrdrag@gmail.com>
  Prathamesh Chavan <pc44800@gmail.com>
  Praveen K Paladugu <prapal@linux.microsoft.com>
  Richard W.M. Jones <rjones@redhat.com>
  Ricky Tigg <ricky.tigg@gmail.com>
  Robin Lee <cheeselee@fedoraproject.org>
  Roman Bogorodskiy <bogorodskiy@gmail.com>
  Roman Bolshakov <r.bolshakov@yadro.com>
  Ryan Gahagan <rgahagan@cs.utexas.edu>
  Ryan Schmidt <git@ryandesign.com>
  Sam Hartman <hartmans@debian.org>
  Scott Shambarger <scott-libvirt@shambarger.net>
  Sebastian Mitterle <smitterl@redhat.com>
  SeongHyun Jo <caelus9536@gmail.com>
  Shalini Chellathurai Saroja <shalini@linux.ibm.com>
  Shaojun Yang <yangshaojun@phytium.com.cn>
  Shi Lei <shi_lei@massclouds.com>
  simmon <simmon@nplob.com>
  Simon Chopin <chopin.simon@gmail.com>
  Simon Gaiser <simon@invisiblethingslab.com>
  Simon Rowe <simon.rowe@nutanix.com>
  Stefan Bader <stefan.bader@canonical.com>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Berger <stefanb@linux.vnet.ibm.com>
  Stefan Hajnoczi <stefanha@gmail.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Szymon Scholz <szymonscholz@gmail.com>
  Thomas Huth <thuth@redhat.com>
  Tim Wiederhake <twiederh@redhat.com>
  Tomáš Golembiovský <tgolembi@redhat.com>
  Tomáš Janoušek <tomi@nomi.cz>
  Tuguoyi <tu.guoyi@h3c.com>
  Victor Toso <victortoso@redhat.com>
  Ville Skyttä <ville.skytta@iki.fi>
  Vinayak Kale <vkale@nvidia.com>
  Wang Xin <wangxinxin.wang@huawei.com>
  WangJian <wangjian161@huawei.com>
  Weblate <noreply@weblate.org>
  Wei Liu <liuwe@microsoft.com>
  Wei Liu <wei.liu@kernel.org>
  Wei-Chen Chen <weicche@microsoft.com>
  William Douglas <william.douglas@intel.com>
  Yalei Li <274268859@qq.com>
  Yalei Li <liyl43@chinatelecom.cn>
  Yang Fei <yangfei85@huawei.com>
  Yang Hang <yanghang44@huawei.com>
  Yanqiu Zhang <yanqzhan@redhat.com>
  Yaroslav Kargin <ykargin@virtuozzo.com>
  Yi Li <yili@winhong.com>
  Yi Wang <wang.yi59@zte.com.cn>
  Yuri Chornoivan <yurchor@ukr.net>
  Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
  zhangjl02 <zhangjl02@inspur.com>
  Zheng Chuan <zhengchuan@huawei.com>
  zhenwei pi <pizhenwei@bytedance.com>
  Zhenyu Ye <yezhenyu2@huawei.com>
  Zhenyu Zheng <zheng.zhenyu@outlook.com>
  Zhenzhong Duan <zhenzhong.duan@intel.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          fail    
 build-arm64-libvirt                                          fail    
 build-armhf-libvirt                                          fail    
 build-i386-libvirt                                           fail    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           blocked 
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-libvirt-xsm                                 blocked 
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-libvirt                                     blocked 
 test-arm64-arm64-libvirt                                     blocked 
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-libvirt-pair                                blocked 
 test-amd64-i386-libvirt-pair                                 blocked 
 test-arm64-arm64-libvirt-qcow2                               blocked 
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-libvirt-vhd                                 blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 81290 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Oct 30 10:29:29 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 30 Oct 2021 10:29:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.218744.379305 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mglbZ-0007xh-IN; Sat, 30 Oct 2021 10:28:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 218744.379305; Sat, 30 Oct 2021 10:28:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mglbZ-0007xa-F3; Sat, 30 Oct 2021 10:28:53 +0000
Received: by outflank-mailman (input) for mailman id 218744;
 Sat, 30 Oct 2021 10:28:51 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=COWH=PS=intel.com=lkp@srs-us1.protection.inumbo.net>)
 id 1mglbX-0007xU-SI
 for xen-devel@lists.xenproject.org; Sat, 30 Oct 2021 10:28:51 +0000
Received: from mga14.intel.com (unknown [192.55.52.115])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id f58c253a-20eb-4a7b-b343-233ba23f1f62;
 Sat, 30 Oct 2021 10:28:47 +0000 (UTC)
Received: from orsmga006.jf.intel.com ([10.7.209.51])
 by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 30 Oct 2021 03:28:30 -0700
Received: from lkp-server02.sh.intel.com (HELO c20d8bc80006) ([10.239.97.151])
 by orsmga006.jf.intel.com with ESMTP; 30 Oct 2021 03:28:27 -0700
Received: from kbuild by c20d8bc80006 with local (Exim 4.92)
 (envelope-from <lkp@intel.com>)
 id 1mglb8-0001Gf-OY; Sat, 30 Oct 2021 10:28:26 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f58c253a-20eb-4a7b-b343-233ba23f1f62
X-IronPort-AV: E=McAfee;i="6200,9189,10152"; a="231075949"
X-IronPort-AV: E=Sophos;i="5.87,195,1631602800"; 
   d="gz'50?scan'50,208,50";a="231075949"
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.87,195,1631602800"; 
   d="gz'50?scan'50,208,50";a="448404192"
Date: Sat, 30 Oct 2021 18:27:57 +0800
From: kernel test robot <lkp@intel.com>
To: Juergen Gross <jgross@suse.com>, xen-devel@lists.xenproject.org,
	linux-kernel@vger.kernel.org
Cc: kbuild-all@lists.01.org, Juergen Gross <jgross@suse.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>
Subject: Re: [PATCH] xen/balloon: rename alloc/free_xenballooned_pages
Message-ID: <202110301843.7Wg3e0aV-lkp@intel.com>
References: <20211029142219.25357-1-jgross@suse.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="MGYHOYXEY6WxJCY8"
Content-Disposition: inline
In-Reply-To: <20211029142219.25357-1-jgross@suse.com>
User-Agent: Mutt/1.10.1 (2018-07-13)


--MGYHOYXEY6WxJCY8
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

Hi Juergen,

I love your patch! Yet something to improve:

[auto build test ERROR on xen-tip/linux-next]
[also build test ERROR on linux/master linus/master v5.15-rc7 next-20211029]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Juergen-Gross/xen-balloon-rename-alloc-free_xenballooned_pages/20211029-222901
base:   https://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git linux-next
config: arm64-defconfig (attached as .config)
compiler: aarch64-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/4db6d782d7d5ef16ced6f4e54161bd8f1148d39b
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Juergen-Gross/xen-balloon-rename-alloc-free_xenballooned_pages/20211029-222901
        git checkout 4db6d782d7d5ef16ced6f4e54161bd8f1148d39b
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=arm64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> drivers/xen/balloon.c:612:5: error: conflicting types for 'xen_alloc_unpopulated_pages'; have 'int(int,  struct page **)'
     612 | int xen_alloc_unpopulated_pages(int nr_pages, struct page **pages)
         |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~
   In file included from drivers/xen/balloon.c:68:
   include/xen/xen.h:55:5: note: previous declaration of 'xen_alloc_unpopulated_pages' with type 'int(unsigned int,  struct page **)'
      55 | int xen_alloc_unpopulated_pages(unsigned int nr_pages, struct page **pages);
         |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~
   In file included from include/linux/linkage.h:7,
                    from include/linux/kernel.h:8,
                    from include/linux/list.h:9,
                    from include/linux/rculist.h:10,
                    from include/linux/pid.h:5,
                    from include/linux/sched.h:14,
                    from include/linux/ratelimit.h:6,
                    from include/linux/dev_printk.h:16,
                    from include/linux/device.h:15,
                    from include/linux/node.h:18,
                    from include/linux/cpu.h:17,
                    from drivers/xen/balloon.c:41:
   drivers/xen/balloon.c:658:15: error: conflicting types for 'xen_alloc_unpopulated_pages'; have 'int(int,  struct page **)'
     658 | EXPORT_SYMBOL(xen_alloc_unpopulated_pages);
         |               ^~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/export.h:98:28: note: in definition of macro '___EXPORT_SYMBOL'
      98 |         extern typeof(sym) sym;                                                 \
         |                            ^~~
   include/linux/export.h:160:41: note: in expansion of macro '__EXPORT_SYMBOL'
     160 | #define _EXPORT_SYMBOL(sym, sec)        __EXPORT_SYMBOL(sym, sec, "")
         |                                         ^~~~~~~~~~~~~~~
   include/linux/export.h:163:41: note: in expansion of macro '_EXPORT_SYMBOL'
     163 | #define EXPORT_SYMBOL(sym)              _EXPORT_SYMBOL(sym, "")
         |                                         ^~~~~~~~~~~~~~
   drivers/xen/balloon.c:658:1: note: in expansion of macro 'EXPORT_SYMBOL'
     658 | EXPORT_SYMBOL(xen_alloc_unpopulated_pages);
         | ^~~~~~~~~~~~~
   In file included from drivers/xen/balloon.c:68:
   include/xen/xen.h:55:5: note: previous declaration of 'xen_alloc_unpopulated_pages' with type 'int(unsigned int,  struct page **)'
      55 | int xen_alloc_unpopulated_pages(unsigned int nr_pages, struct page **pages);
         |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/xen/balloon.c:665:6: error: conflicting types for 'xen_free_unpopulated_pages'; have 'void(int,  struct page **)'
     665 | void xen_free_unpopulated_pages(int nr_pages, struct page **pages)
         |      ^~~~~~~~~~~~~~~~~~~~~~~~~~
   In file included from drivers/xen/balloon.c:68:
   include/xen/xen.h:56:6: note: previous declaration of 'xen_free_unpopulated_pages' with type 'void(unsigned int,  struct page **)'
      56 | void xen_free_unpopulated_pages(unsigned int nr_pages, struct page **pages);
         |      ^~~~~~~~~~~~~~~~~~~~~~~~~~
   In file included from include/linux/linkage.h:7,
                    from include/linux/kernel.h:8,
                    from include/linux/list.h:9,
                    from include/linux/rculist.h:10,
                    from include/linux/pid.h:5,
                    from include/linux/sched.h:14,
                    from include/linux/ratelimit.h:6,
                    from include/linux/dev_printk.h:16,
                    from include/linux/device.h:15,
                    from include/linux/node.h:18,
                    from include/linux/cpu.h:17,
                    from drivers/xen/balloon.c:41:
   drivers/xen/balloon.c:684:15: error: conflicting types for 'xen_free_unpopulated_pages'; have 'void(int,  struct page **)'
     684 | EXPORT_SYMBOL(xen_free_unpopulated_pages);
         |               ^~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/export.h:98:28: note: in definition of macro '___EXPORT_SYMBOL'
      98 |         extern typeof(sym) sym;                                                 \
         |                            ^~~
   include/linux/export.h:160:41: note: in expansion of macro '__EXPORT_SYMBOL'
     160 | #define _EXPORT_SYMBOL(sym, sec)        __EXPORT_SYMBOL(sym, sec, "")
         |                                         ^~~~~~~~~~~~~~~
   include/linux/export.h:163:41: note: in expansion of macro '_EXPORT_SYMBOL'
     163 | #define EXPORT_SYMBOL(sym)              _EXPORT_SYMBOL(sym, "")
         |                                         ^~~~~~~~~~~~~~
   drivers/xen/balloon.c:684:1: note: in expansion of macro 'EXPORT_SYMBOL'
     684 | EXPORT_SYMBOL(xen_free_unpopulated_pages);
         | ^~~~~~~~~~~~~
   In file included from drivers/xen/balloon.c:68:
   include/xen/xen.h:56:6: note: previous declaration of 'xen_free_unpopulated_pages' with type 'void(unsigned int,  struct page **)'
      56 | void xen_free_unpopulated_pages(unsigned int nr_pages, struct page **pages);
         |      ^~~~~~~~~~~~~~~~~~~~~~~~~~


vim +612 drivers/xen/balloon.c

   605	
   606	/**
   607	 * xen_alloc_unpopulated_pages - get pages that have been ballooned out
   608	 * @nr_pages: Number of pages to get
   609	 * @pages: pages returned
   610	 * @return 0 on success, error otherwise
   611	 */
 > 612	int xen_alloc_unpopulated_pages(int nr_pages, struct page **pages)
   613	{
   614		int pgno = 0;
   615		struct page *page;
   616		int ret;
   617	
   618		mutex_lock(&balloon_mutex);
   619	
   620		balloon_stats.target_unpopulated += nr_pages;
   621	
   622		while (pgno < nr_pages) {
   623			page = balloon_retrieve(true);
   624			if (page) {
   625				pages[pgno++] = page;
   626	#ifdef CONFIG_XEN_HAVE_PVMMU
   627				/*
   628				 * We don't support PV MMU when Linux and Xen is using
   629				 * different page granularity.
   630				 */
   631				BUILD_BUG_ON(XEN_PAGE_SIZE != PAGE_SIZE);
   632	
   633				if (!xen_feature(XENFEAT_auto_translated_physmap)) {
   634					ret = xen_alloc_p2m_entry(page_to_pfn(page));
   635					if (ret < 0)
   636						goto out_undo;
   637				}
   638	#endif
   639			} else {
   640				ret = add_ballooned_pages(nr_pages - pgno);
   641				if (ret < 0)
   642					goto out_undo;
   643			}
   644		}
   645		mutex_unlock(&balloon_mutex);
   646		return 0;
   647	 out_undo:
   648		mutex_unlock(&balloon_mutex);
   649		xen_free_unpopulated_pages(pgno, pages);
   650		/*
   651		 * NB: free_xenballooned_pages will only subtract pgno pages, but since
   652		 * target_unpopulated is incremented with nr_pages at the start we need
   653		 * to remove the remaining ones also, or accounting will be screwed.
   654		 */
   655		balloon_stats.target_unpopulated -= nr_pages - pgno;
   656		return ret;
   657	}
   658	EXPORT_SYMBOL(xen_alloc_unpopulated_pages);
   659	
   660	/**
   661	 * xen_free_unpopulated_pages - return pages retrieved with get_ballooned_pages
   662	 * @nr_pages: Number of pages
   663	 * @pages: pages to return
   664	 */
 > 665	void xen_free_unpopulated_pages(int nr_pages, struct page **pages)
   666	{
   667		int i;
   668	
   669		mutex_lock(&balloon_mutex);
   670	
   671		for (i = 0; i < nr_pages; i++) {
   672			if (pages[i])
   673				balloon_append(pages[i]);
   674		}
   675	
   676		balloon_stats.target_unpopulated -= nr_pages;
   677	
   678		/* The balloon may be too large now. Shrink it if needed. */
   679		if (current_credit())
   680			wake_up(&balloon_thread_wq);
   681	
   682		mutex_unlock(&balloon_mutex);
   683	}
   684	EXPORT_SYMBOL(xen_free_unpopulated_pages);
   685	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

--MGYHOYXEY6WxJCY8
Content-Type: application/gzip
Content-Disposition: attachment; filename=".config.gz"
Content-Transfer-Encoding: base64

H4sICC3yfGEAAy5jb25maWcAnDzJcuQ2snd/RUX7MnNwuzYtHS90QJEgCRc3AWAtujDKUrWt
GC2ektoz/fcvE+ACgGC13nM4bFVmYkskErmBP//084R8e399Prw/3h+enr5P/ji+HE+H9+PD
5Ovj0/F/JmExyQs5oSGTn4E4fXz59t9fD6fny+Xk4vPs4vP0l9P91WR9PL0cnybB68vXxz++
QfvH15effv4pKPKIxXUQ1BvKBSvyWtKdvPl0OJzu/7xc/vKEvf3yx/395B9xEPxzMpt9nn+e
fjLaMVED5uZ7C4r7vm5ms+l8Ou2IU5LHHa4DE6H6yKu+DwC1ZPPFVd9DGiLpKgp7UgD5SQ3E
1JhuAn0TkdVxIYu+FwdRF5UsK+nFszxlOR2g8qIueRGxlNZRXhMpeU/C+G29Lfi6h6wqloaS
ZbSWZAVNRMGN0WTCKYGl5lEB/wESgU1ht36exGrznyZvx/dvf/X7x3Ima5pvasJh6Sxj8mYx
B/J2jkVW4swkFXLy+DZ5eX3HHnqCLeW84CaqZWMRkLTl46dPPnBNKpOVamm1IKk06EMakSqV
ap4ecFIImZOM3nz6x8vry/GfHYHYkrLvWuzFhpXBAID/D2Taw8tCsF2d3Va0on5o36TnAZFB
UiushxEBL4SoM5oVfI/bS4LEbFwJmrKVpx2p4Fz2c0jIhsImwUAKgbMgqTFzB6r2HMRn8vbt
97fvb+/H537PY5pTzgIlXSB6K2OlJkokxXYcU6d0Q1M/nkYRDSTDCUdRnWkp9NBlLOZEooAY
y+QhoARsYM2poHnobxokrLTPSVhkhOU+WJ0wypF1exsbESFpwXo0jJ6HKQinf0xWsiEiEwyR
owjvvBSuyLLKXDgO3c7Y6lHNteABDZsDzvLYEOWScEGbFp1YmfMO6aqKI2Gf3+PLw+T1qyMi
7hqUotkMZK1FB3Ca1yAGuTQ4pmQUFZtkwbpe8YKEATD6bGuLTImufHw+nt580qu6LXIKQmh0
Clo0uUN1lSlp6vgAwBJGK0IWeM6YbsWA8WYbDY2qNPWqPIX2dJawOEGZVVxTMtRxebCaTueV
kXPEKYDq38yTrxi6JbnstF5PongFPy1GdTNFumbzPPMdDNQAumEaTjZrsEfpByk5pVkpgS05
9fKrJdgUaZVLwveeuTQ0hsptGgUFtBmAmb3JIkjgbAQFtyagOVFWv8rD278m77AFkwMs5e39
8P42Odzfv357eX98+cORLGhQk0ANq49ZN8qGcemgUZY9q8FDp46O1ZG5y3rGZBPbJ12DZUJ5
RlJcrBAVN9TzSoSosQOAY99yHFNvFubc0RIQkkjh3yHBvMrhA8zrbjngCxNF2qpzxXweVBPh
OcGwiTXghrutgd284GdNd3B+pYfJwupB9emAcM2qj0bjeFADUBU6U8P2wLk07ZWLgckp7Jeg
cbBKmVJeHe/stXeSsdZ/GMp93fGgCMzFs3UCqh4Uide4QnMJDnfCInkzuzLhuBMZ2Zn4ec9n
lss12FgRdftYmAdWUbE8pDvP4K3+bk4davF2w8X9n8eHb0/H0+Tr8fD+7XR8M9VRBXZ8VipO
e8XN09rSgaIqSzB3wWSuMlKvCHgFgXW0GosaZj+bXzsKtGvsYsc6s+GdUqQ52t2GVRLEvKhK
4wIsSUy13qKGKQ8GYBA7Px0rVcPW8D/jXKfrZgR3xHrLmaQrEqwHGLUzPTQijNc2pjfwI7h8
wfTYslAmXuUASs9o6zNwNbpkobB61mAeZsTbb4OP4ODeUZ8H0RAkVUxlujIWWYLNbFoceHJw
+AYzYEdINyygAzBQ2zq0XQjlkWchGRPBuYUoK8tnY4B7AjYaaOZ+pAqF2PitLgsTgL6J+RvW
xS0ALtf8nVOpf/fTSmiwLgsQdzRKpHM5WhcO+mGtjPWX6l6AbIQUdHNApL3zvXDQlPjucxRb
YLty27ghiuo3yaBjUVRg0RouHQ/r+M406gGwAsDcgqR3GbEAuzsHXzi/l9bvOyEt+V8VBRoZ
+LdPBIO6AGsjY3cULXAlGgXczXlgGYwumYA/fFo7rAtegqEP1hw3LhLXCVUWQsXC2aVLA7dh
QJX5AxcesScxelE6PWWgxRjKk9U57ohr5kfaJ3H94M68ta4L04839BxNI2WYGWgC3goa18ZA
laQ752dtOluKIxocZOUuSMwRysLsS7A4J6kZ6FHzNQHK5zABIrF0LmGGDLGirrh1MZBwwwRt
2WUwAjpZEc6Zydo1kuwzMYTUFq87qGIPHiv0n51AAVdXUORTwp3X1U8CZpgHDvPXwD7jPAhq
OY3QlIahV8mrHUDxrzt/T13tTXSwPJ6+vp6eDy/3xwn9+/gCRiKBSz1AMxE8n972s7voRlbK
UyNhnfUGzF+wK7xWwgdHbAfcZHq49kY2dkKk1UqPbB3mIisJ+Fh87dV4IiW+aA32ZfZMVrAT
HAyBxm6wNCti8d5Dm7HmcMiKbHSsnhBDI2B6+RWxSKooSqk2PhTziPTG5dSi0UYsCZeMpJYW
kDSrQyIJBkBZxAInOKPjlNZhUGpI3TKWw2tHG3shzS4NdXy5XJnupxUOUaR6Na4Rq1HwQ9al
bNFLHzYLh1g4JllGwC7J4XphcA9nLL+ZXZ8jILubxcJP0ApL19HsA3TQ3+yy47oEC05xsTVR
Dd2TpjRGRxD5Cwd6Q9KK3kz/+3A8PEyNf3rzP1jDhT3sqDXZLdVsADuF0w7liYAlW8rixBfH
EVXmgZKUrTgYDnACwEZwrPEsKVFTIXvgLmuCo9q0NgTS1FVrynOa1lkBDlpOTamM4E6ihKf7
QHdlyGusg+QqVCkcKegcgkrFQN0IljIq16g9dWKj0Xfl0+Ed9Q5I9tPx3s6F6OhsgGfG7U1U
+Y45MJKWVj5AA8sydWGrIJtfLy6G0OWXqevmABSMR+1KWnDKU2YFTTSYSYw3jl0oKx5kQq6c
vuhunxdi0BcGIncXY12tF04vIBQgZwEp3eWm8WztgBImXO6tKV50A7miIQOZc9uDBW5KjIZt
QPO7sJ3Lt1s4uYOVckpSGGRsqRyOgCCuCMCerO2otebaYu5CKJFyIAR4LFOwmoOojInbYp/f
gi9j2h0KLmnMB7SlaY9rsqQCV3/QWEPd2VU5KxM2oN6A+YnhKhcMThOoYnfzdqglHNgdLCIr
zUvEc9ZMmyPqQwwKDJp/cjydDu+HyX9eT/86nMAUeHib/P14mLz/eZwcnsAueDm8P/59fJt8
PR2ej0hlnl68ODDbRsAVQp2dUjDVAwIuknsvUQ6arcrq6/nlYvZlHHt1FrucXo5jZ1+WV/NR
7GI+vboYxy7n8+kodnlxdWZWy8VyiAXPBW1LpWnPErbY2XS+vJpdj6KXs+vpcjBFg/mipEHV
3ElEjvYzu7y4mI+yaQbsX1xejaIvFtMv88WZWXBawmGsZbpio53Mry+vp+NjLC8X8/noVs0u
lvNzbLyYXi9nxvoCsmEAb/Hz+cIUAxe7mC2X57AXZ7BXy4vLUexiOpsNx5W7ed/eXFRU/QaG
T9UhpzMwWmaGewfqPWV4fXcLv5xdTqfXU2PpqInriKRrcLB7MZsufkjxxaG4DSM4etN+NtPL
i/Od0Nl0aUw33zC4ZWDVPAOVHORlS2iYLkUAVgDYDb1uxiA3s63k/5/GskVluVZWsnMdI2Z2
2aC8DoOmuVz+mGZDtN26+OK98EyS5eDEN5ib5bUNL0dblH2L3icDf2WFDmoOjPdZK0iQMrw2
GxpjK1SIKwtciMjM9CFXwcOb+UVnmCeFLNNKdW3QVWb4KQdjVLguBvqv4MjijFQIGYlqZty5
OgFEpQ416owSWBRGt5hUaFHKJwfNy8EDDOBKXt/Y2U0QcJ+7flfPL6YO6cImdXrxdwMcmdp8
SzjmyQZWBSahwfgeGPHJ1vH5LbtOXSop+jZlDFarmekjnGDGzVxDC3OTa56Zr+mOGluufuJQ
VkhFQ4U/9MeJSOqwMn0QcNNyoQtveuCO5pi1n1oQQ/dh4l4lZO5AIRQcDa3eS6xydIEa3wZu
Gpoa/fBC+eIYK/OkH5xTKra1lCs+BSb5zXkkkiSOMd4bhrwm5p2m/VODXyrgnNC0bDPZfT+b
65GocGuF/X39eTbBMrDHdzDbvmEcwEgHWRMC6SBRuMqGSsA014USlDQkJR9CBRoIRcYC4XZy
BoWH1EabSvncAoxFzscX6WxOCSdjdFNA0MClkrk7R7hYhvMaHdOY1+KDzC8lx9B/MmB+A2/k
0pASnV8Dtz7XHrKEjQrAShoWvGEYFhEVz5W42a6B3jpoO4AFEQP9F2PcgBMMjkg6ZMLoAg0m
LD/IBJJVLvf1TLSkL13mgC2IIbvYM63RIY1pXfx4WubwA8NxJQeWKID+Dzvl64FOS9cn1FFJ
l7CZWyYHHlHm26fRxRoMufrgPlGtEpwRRlvbjcVmOOEirDBemkqP6VQKWoVFnWfMc2o5VdFV
+xbQ/MIEEAbwffBmQE5jTN/YCRC1XWgVYDAQd4sGEvNIewHkhuFio9FEaEo83eh4ZHF69Qor
eP0LPWiPciJByfBqXWOaG3svgsJXLxRkoSpg7VN2FA6rkGbgGyD9jzBj5tSsWXRLagoxuwtI
R9le/3M8TZ4PL4c/js/HF3PybbsKPESzOLABtPlk07lYweFAhYLpGsyXiyHSrkHsgbXISYmV
ZpjNNIyTDNYd6hC6tAtcEZVSWtrECGnimb01k6nEq8L5y3KyekvWKG1rXxFImTm9jWWgARWk
a2tCbZRWlxsaDNne1mWxBcGiUcQCRvuqs3PtPUt2KQqj0E2lHwzlgqTxXsV2U0cPmXtRFkKw
1SAyZpLokhnXOG1Ew2jfx5jGJK2tHmsoso6iDTchjj08HY1aeKyBshKmLUQnXUus7+Rs45hU
HVFcbOoULkt/NYRJldG8Gu1C0sLTPpSaQl2pXfoOPdB2IZPwBJ7myda82LW9JgSWImA/xvSl
r5bHOxzPqDfTLO0YHJ2O//52fLn/Pnm7PzxZ1Xq4Zjjstza3EaK4gIX0tV0NYqLdYq4Oifxx
WasQrQWOrY06AH9JiLcRnisBav7jTdAKV7UjH29S5CGFifmzhN4WgINhNirWNiJ4gzbKFawk
S0fYaxdKeClabozgu6WP4Nt1ju5vv6gREnMNncB9dQVu8uCeCiDT/LBlq4GBRUGkdVmo+zUo
8ZLTVDfPoyhwUZ0DBXfWluU5pvOr/GLKOsp8g7muZ4sWOB6SenG123Vj2bZNS3K9bgn8bgkw
p2RGHwamyQnVZCP8BCzbmTx6tifQZmh+ML5LBp6ivVYVp7N58X0Un2xtJLhcJVwafG8s8tle
fjayfJVTmU/PIGfz5Tns9eU57BdP29uCs1trQw196dGQJnpwezk3Y5MDRUG0JdaR3/Y6j4WL
CQICRu1txbgTlkCkMkli74Wm8KIMeBdQsZvSwPdwwaSw3EcErEDpU753oZWUVvYPgRHJByNK
4teaeiVghY1NpCm8BpPcuRARmQVR7FMGKVs54K6bwcxY6fVEFM4bp9Tr0XXknphbs1zMjVcl
iF3oTtrFeXZ1nFUlmAAiLXy1aHr5RS7BLrDsNLUSjwAFlZAFqgOZFGd2ZxV7S98UDuSywrcz
WD+zJZzC1ZG6MtLEde1Ok4z4OtUvsZQAltQ9DSOgOk6sCoMOLszAbw9uKiIiwlLrAUBPQVn+
22DGGoOh4h9skf57/Ggxq3xEawAZuqCylHZ8NmNYCald3JF3Eat9SfA9HMlJbEoAxnUrkrI7
xxlbbwzFrlgPEOzJzqWbmMgNtjfwmheV5y3Gui0RM9shMMvMQsCONhNuZSJC0bTAKpqdytRz
LNO0e9tE3t50rj1d1VFaicQpCtwYfhTwZ481++qFZxMEGFmn5rEHuVGzrHJdLZ00YSxjtF2E
MYWijisKQtQ8Pe1fPm0SWtN0PuppNoFLuFetN7Lqdy0SMr+4rJ0isB55MZs3yOchctb2Tb39
nsV2HSPe0/dibNhsYbbrregWvezQ3gSCoooTzCOMTi/ggZxNQxaNz5BQMcK0DuPr2UTCJZ2d
J1iZAYIBARZcKRJ3biBD8C+YQ6oka8ijskj3s8X0QuH9LokmzJNR0rFJrcTNs/222YgFHn95
OP4FdpA3eKRzO05lrMoFNbA+Q6RrwzzT+a3KSvDWV9R6CozeIxzWNd0LUO1p5L6bbsgGJWf6
6V8Xcqly0IRxjqmaIKDDo+xtvuZUehFRlauitFq91Qb99BsN3Fe3QJZnhl7TFYmoTFMSi2FF
Yf8cWVEmRbF2kGFG1E3P4qqoPPWEAvinogT6TeuQQCGxuFsnSz1mDLiYkkX79i3BkGBNaek+
QeiQ0Gtzz44gQeUCo+Cqcu+Zpj5KaWIheQVE24RJ2rwBM/vCd5vqjT/LhfmyX/cjMgx6Nc/h
3W2DaxREHWthMOzbSAJc8e7t01Rxe3ccX/WPNky24MxRoh+JODiVs8UZ+OAqOahnZSdIe+5Y
x+MM1ix1b8iyrKpjgsZrY4ZiSNeLxhd4PpJmF7VM69dug2cDejLNKWs2ESshHIqmnf5uwQgu
LKphVFI92G3KfjHArV9ptx9E8PBE0ADJz6CaVHlPMWgyIOwVU4NR5Wyj97cxJO5uCsLhzMdO
QRgjfwiOjC6stxSWF5rijYLf+vghAZw+8009wvH98Vg7zCo6HesdBP2ERTqow9ZDy3Dkxa9D
9ePXvlmBJ6dyzVINzlxwq1VzLKrA2wBfwHlEU0s54PC5hKselfgppK6CJ9xtDoqnrd2gARb7
G0dMpaqEypLjAx48ox4dqVBtfss3OauO3unAxvUF+J7WRvH8WCcmiVODb72cl0UZFttcN0zJ
vrC+1ZKCCNWYIQI3MTTGKvC7JCxu8ghGxVkzbIMnzq3aYBdzmJaSEB+PcO/0KTF8IQ+sb9Gn
FNdaBxdRpAPd/bM8P0nLhnPvh+CEMlCFTUkK3+7MszyKcpu3yU5Pcx+qX1zzwRleJz4suJbp
Yt5mYD119iixcKdzihxsCoo6rmAizXwM5PV+24XAGG4eSUnS2CM+Y5JRji81mGtzdNqoeewE
J1o91Llpv9ATFJtffj+8HR8m/9JZ3L9Or18fm6xH/2UPIGv24Nz8FVn7YSHtVfavc86MZK0H
P8mEwSVmPy01wN4nWh+0x9uhQMlm+LbPNFzVMziBz8D6jzA1asmcSSNMusgqLYjv6VpDU+WI
H22s0V4XxTDRxvDYj+BB92GjkU+HtJTeirMGiScAy2XaC81t3OHxtey5UTrC3d2HyPBp7DlC
FNYtPoMWeA92z5prlimx9q9IOSQg6zK5+fTr2++PL78+vz6AtP1+/ORsq/6EQwqOhGnrr5rP
C3Q/9bvilYgHKTwDZ8VW+7fIGGJncn8GVYMzbvK8JcDaPT9zWgpwBwopU6ca0SLbrvzf0Orf
+NcMv6BB82D/Y8KgGPkkl0VVcubLButZoxqKhLteAQZxURK/BCOB/pBZDdNEl9wJ9en6jcPp
/REP+UR+/8suiOtqJvAdLeYHvUdWhIUwyiu6DcOKExPc5/GdES35GZQ34iqyWwxUD2Bo85mB
OgSXmSOQdQJXPlxSfR1kq8SB291nLIyIA3TMCl0/G4LXaH8IzkCu9yvbbm8Rq+jWq2rt8doe
+2/ygH/MrOd8RORGKXuVN5spwE9WOnBY2tvliFStZM0zI5mm9LZuDDsKlpXpnvCtoNkYUrFx
BNdd5eqbaqEiU1UwPck4xm3Mt/6mA3h3deY4I1DlKflf1t6sOXIcSRd9P79CNg9nuu1MTQUZ
G+Oa1QOCZESwxE0EI4LKF5oqU1UlG2Uqj6Sc7vr3Fw5wAUB3UD33llllZsA/Yl8cDl/KEra6
Tn+xtZ6jR55HWYK310p8oLdj1EWScyP+5+PnH+8Pvz0/SgeMN9J++V2bJfskP2SgBKzryvSc
7ZTUWfD1hEFbcnILBqKpXT100jE/AwlcB2j7ovjAloRJS0i47Y+qyCJX2kVNVy8eVklpcGEd
wXanoRXTyRSGOU71m+zU7PHry+tf2gsnoivWK6drvOior96Ic0dnzUfSpbNQndil2ghb+sJ4
3R4nEisQRknzfHORdU89uvMk/StVeI/qHvsMtsCgUCzhJBvR6OJiNCpNwKBa7ZdgC7HCMuhg
4k6poJN27IFNMI5llaAmMnZDstKkzXcVw55j3KQRZ4F6xfpL8hyuBsvjKSSUksq2Z8j7upzu
udKWrxFr9WF7HVNvuTbJ+oUiJ1GWKEXoX1aL3cao2LDBUo9+k/TRcuNaFmLi5J1MFxl8txwB
o4o+uLJ7gytAYZnyg4EL9cF0UoqaUPKhEr0Nvo9QLVPjIVb8dLxlDlTbu6FGl85N8IJasLvh
v3i78YtPZVHgnM8nPnVK0d+HOom1tEKHt9NYbQqae4tDXFWmoFH6wkFLUoJvgPRyKddFT0n0
1CFuyGEGRCmN8E0hETC0IKKfpkzskcUxwZVzQ5FFK98D9LZ1tk60dzmxE9L+Y6UMHR7k5cIE
5zn4o7TeFimwMjxXxGEV12qDl4dCBCZ17PPnx7e3m+zl29P7y6t1i45YZj9IdacN9W1Ppw+c
vjq5rnUIjpnECJoGEJAYW2n8dg+HUZz3bwGyuvnjOxj9gSLa5FwTW+dtbBlIQUobJQybMoLZ
02Qu8Av0nLTRPqjEotjrmco0O8txb0jxUW8OVSYfCnAfmjHIkTDPUYnRe0mpVGc716DjEimH
64N81Uc1jASozEsjM/G7jU7hNBH8QJVWCZBesQq/ZMtxLYkbuCIegWOKszPmRE8h2vqcg93G
V6PcTLYId/NyDwdpcZsQFpsq20udkNRDcXbRxkrhBcDwtAz3FCdpMce7JFFVgxOfGPWxM/RE
mHjaaElcWPbJZvbnqKQnqkRU7DqDAKoYNXiowC/hULr459F1fx0w4XmvC9YHMXRH/+XfPv/4
7enzv5m5Z9EalxCJkd2Yc+Wy6aY/XPkOeKsApNyTcXibjggpF7R+4xrajXNsN8jgmnXIknJD
U5MUdxMoidaE1kk8qSddItLaTYUNjCTnkbh7SLvc+r6MzUUvyGoaOtrR6/LLp0dimUggvY5V
NePjpk2vc+VJ2CljuPdBNQfK9AMZJQXLZgoUAymfZTGZTFkb+yYsFpk2WYuCAppDcCxnrMK0
JuHbsi7hTY7z5HCPfS14b/loIhiLrMR5IAG1n0SHpGF5GnfPKomO8QiaCK7Cl9dHOHPFPfP9
8ZUKejAWMp7sev07InRmksuXe5z5mUInTuQd2LTAt7EpsuAHrPfAM1+eSx5z3HRFKmiZCa5Z
/KWvLB3e2uOKo4ClxLg5AwRarwedN9KJU09xBhnmh1hj8zUZJtI8VM5/qta1MpBro1BfCzqF
hzVBEaeTuDvHZGMYmDPgm6CBO9QfaMVp6S/nUUmFbyoGSMyifVKAw9J5LM8/0sVl+ZEmcEY4
FDdRFAtmDL+rz+p+neBjnrPaWB3iN4Q0ECvV1o0WxOmRMFmUjcJoedokyxiykaKvt5vPL19/
e/r2+OXm6wuIew2pup6HY3HqKOgdG2mU9/7w+sfjO11MzaojMIMQeGKmxT1W+qQFd3Ff3Xn2
58J8K/oPkMY4P4h4SLLuE/CJPCyn0H+pFnDTl+5JP/xFivKbKNLavhEIfTqPUDX9ndmItIx9
vDfzw/zJpaM/ciaOeHA5SAkbUHys1Pw+2Kvayp/pFVGND1cC9Dabj892wXRlnLwAYnDB/4P6
RUku9q8P75//1K3urR0FItyA+FJyzFTLFQwCRcxWTUHVM+WH0emZ1x9ZKx28yDLBPXwcnuf7
+5q+WGMfTJjl2Q8gxNK/8sFH1uiI7pk5Z64lKQGwocDmfBgbX/6l0fzYDqywcYgrj2NQ4o6K
QEEz/18aD+UP58PoD08Mx80ZRUv/Ix+Fpz7F+yDYOD8SYQAw9L/Sd9T9FYV+5AjtsPIyXlQf
rkd++MB1bEBbNycnFN6wPwoub2vYST8KvzsXNXEzmII/fAJ28JiluPtpFBz+C1sq3IU+jIVg
UB/PGZ66/xWwlH19/IOK0uNB0B89jTu0YPc+ij0vffSJwimlMETJnOhSQboYVVbKK+X/8wHh
xwHEmBWTQqWVJSFQoygp1H1L8TpOSASqSw46CChIubwi25+P1CqGp9K+8mN/CFJSDnczvafy
Q88AEcJRDUKdVDqmKqfSJxRY15ggTiE6wZfVgoGphTZOm9GR+X0+YTgNnHHnNT7F+V8D4rgO
WJUkOe++E/JjSpfTsYPE/d+AukelZ5NrSnYqpw27Oqg8Ds+gP+iAiAmLCYx7PS7H0uvW5n9v
XKsTX4W4wN1YhSSkW4WbuWW0mQgPzcSk3NCLa/OB1aVh4nOywbcFAwbb0zwKLkXzKIKNMzDQ
YKUKNY/NPtDMmR1CR1L7u4bhlbNIVMhhQqabzWZmt9l8dLvZUCt94151G2rZmQhrJ9OrRW1l
OiYva2K5ulYjelRuSGG6epVA29k/WBzaeO94btrPnCjkPQ5YBIpJqyK8MMFv45wUq3E+0r6B
dMm8LsehOYrtcfyV6T9UH9i/2+SYicrnRVEaamId9ZKyvJu2VhjHDpAR/ENHDg+Yw075QMyZ
dcGGJHCtKrb43XLp0d9JEPjP6XXXv1IAmtJCSJDw3gEowWt5HlGVFJfYNKzimLxiDcgjvzr0
G3qU+HsWE38ElNXzVbrluC2DjqnqdNWymVEowjgtarwXFa0NFr53R/XiXTjfIDEFd8sF8Qyj
4fivzPMW61mc2C3ANGoW11R8u1hgWidyVfTtmqS1x0ulvV1phEwRhtIiwVDFGOMmppbeY+Kn
T2wVLMVHu/HxjkhZuUcJ5anIiVvOJi2uJSNYvziOoXFr9JoAp1YXKlHyVnc/Hn88Pn374+dO
2d7SJuvwbbi/I0cH6Kcab8NAPxAxBnuAbc4xAUh5iLsSFWHJ0tP5wV1JbpsiWPQ6viMlXwqw
R5+jhz4038ZkorgbTxNrBt1hr1CgHOfaGHGXkElCxN8xKRdRmVSY1tkwEndU7fjtfnYcw1Nx
S8oJJOJuZhhC8KbpRBzuPgAK2Uw9ZqpxOpESNDWjE8x5Sk/t9SuQXrS13SeAmODuh+GbGsOq
Nf388Pb29PvT56nWh7hzWlqcIgFsFZPQriIQ6nASQ3eCkTpChKSjgxxwHrgnT6REdgn8Qp/i
PYC4BfY1EBupE+B+yFG9VFKrvi9B3jAm38k7DGVQCaBYIhx5s7C2FHQgCVyLJKjnnh4ABt16
jY5M6XJg8f/6b7IE9LztdgCFs6xM6aXE5GWaFIBKes7c9DKOaIG8qkRCvzMowO1+NhMI+OYE
iIbSSw8AwFo4AY43xL6aGeEPbujMg7uzlRYcoYU8ToHafu4Uq7rX1XZsXIfkUBgcU4jNmigH
Q3NepBfT6m8vrlJMWkiiTSgEf38RzLk17Qf6RQmAyDGQSmGkGqxz9HKOF3ni5Fko66k8ohpZ
pUu4gtfSjPKCfHxX1ZrIAX61PIusFDGK9vjkIce0RUuwUgBL3So+hLq/m0oP3l0duHSYo1sX
gEVU1SjdPPAGZF44mxILew0VIQ95DaM0XQidDih1f+b3rRnidn+XmocQbJ7qNc4yG7h5f3x7
R3jV8rY+xvQKjKqibMX9NLFCiA7ij0n2FkE3V9DmCMsqFqH2yCHTLsPiBwh+zIS9fimGhOPV
8DcmUn71dmaMIoOa8KKe6j8Iyk30+N9Pn3X318Z3l5DYqySxcVF5GuLRigQNFoTRnpClITgw
AUVtI6g9CDLSuFFdZOR/rFyl314Y+GkqwyQ+EO6gBaqBgK7OVkAsTwc13G7xsEKy08HxDssd
5WfO3MuY3SIt0CdKyCpr6ogUVajdX3DRXhBBkCS9ONjhhIZJwkuxqUBo4d8fPj9OJskpWXoe
zujJRoalv56n293UP/dNix+qdeZ7R7UC2O8khCg4zribziOg4wymBNTgCIivA7pxR3cR3TR1
QbJwz5wAOU1cgPNkkml9a/Wh+aXykiD6UfCK+NMNsoUMO7UmYdpDTOk4Ms95scUfQBaIiyLF
F3mMiU4F5ZREpT6/IYkQDoPWIJ5JGkfcqk/GD7XF2uhkVvDSQXYZYwoy5hJRRSh5/vH4/vLy
/ufNF9WTE6/r+1qFQDU7VD8UoDNrk34XMuP3KUz2tRhuu+O6ZBWPQ3l5Inq9R+7DzOq4gWTJ
MREEVBP5mONnoyKfWVXbbYE00aeV4W5eI51W02IkIS9uE1x+qYH2IaFKpWFYfVrSrZWQFGmr
JCyvSUW8eowgOebuAtChkJQKfT/XADA/8E/ZcdPgW5oGyqoL4SVFjWiY+YulK5d9KQ4kJ+BA
7WqKfhH/U2RX7SbjZnxY39pT0SJD6/GeBbf7ikvXP1FOVdDdk1z5YwbsIBjhinp0OrS3Ib5/
ZiH67gTTLjVMb8PDEUTBnnGTSGWStFyGwDT40dJ9COdDnIIXDekVTPAQqMV5j+7c5csgaWDA
Gh+j/bQ20j9H72wNINKtLILrrQqti8hIprzoD5Cwipjm43WaxxW/7WYs7DvOSlE+1HSfgj2h
CsEXAq8r/Y6lUwe3CR9B/fJvX5++vb2/Pj63f75rdpQDNIs5Jhsa6PYROBBcR5meO+8N9SmV
MTNHGbvHVSFeM6mZKmNGSov+wQFadbhNUu2EU7/7JpiJSV6eTZ+AKv1YoocMXPt2pXmt3JWj
NyTjfigIjeP6uCtdLhtYgot2wrgElVJUuHYwxasHcId+TGqGbe9AzcPE/iCHoAQlYRfd0e1t
zQBYO213zX54vTk8PT5/uQlfvn798a0TGt/8TXzx925HMy1oRE6dq3sokiztEFHqbWFb5uvl
kmR3R0TiU9ZdCuG7Gwznh7MUXstecxXTQZwd35R2T+gZLA/XKl/rKkZDIpRsD7MiBVjTBhHF
h8ZszLackdxSgkbM0LYjRRDM1wwsf6wKsQRS+32h55itZHHegBDP8poDvks071MsSYuLbhwb
16daQHoR4OAtw5Z/9EcrxAvK9pqPEBmjpmUn7bRSXqF1R2r2j2mQOS2x951iEjuPWkai9Ai0
PxubdR/7BL4BCDoOQGCogwhJ4bp3tz5FC3pn5gM0dyAvEwan6ofAeEQxDQZBZO3qtGWNqalA
dxhRKroE6ap4CMqm0YAdueVW7o5NHKiV8l7a+1WCqxOJhSCRJLE8TOgaldXWxIlDZg5Yr7IT
Z2dzxrRJcbHbVFa4bBjcCnLdZSsk2f7Lx9mGJvZxk9DpqcKq7HFOVQeGJXEs6CB+Mtlh5XVR
fPj55dv768vz8+Pr9Aotq8Gq6MLMsB5yJik5YJtf8TsDfHuoxZ94vHEgy83BXEpKFncqdLf4
Y7oRMTJMJG7i1XMgjBsFVnFydfUNC0tqpTSQs1mgTJosoRhMb4oQS5NR32ABo8RpRgwU0+zO
UonTlSubX5/OObicLOPMQZ0sDtHVRXhrxsoxktXofLU6baBSoUkB1Mdom0fA4C2pfa0LKDep
Q5aEohp9FelCTgmHoEdTZw7R49vTH9+uD6+PcmlIqwn+4/v3l9d3Y1HEbXS1eie69rPWLEuk
w0jP1KhH0Z3Xxs19XqBRXWHfypqNvXHB3a8GF12uokcUKjZUe9q9OI9CVtqHiUahv4a+troK
bvz2RO6DDE76b5hXXQfTfXgbx4L1uP8giqqwQCSVddp1MwamnHlAxlxXyZTIPigfkYwvnoFK
1+qScPGzTvBZds6T8pQQmn4Gwrk+bRe+vYMzx7JQLjVffhMnx9MzkB9dyyYr9sklTiw+bUjG
GzdQYYlQ/aPNRbF1KDFm73+Nrp26aD18efz2+VGRx+Pw7eZtaINZoZBFsWC7PrKwDahjdf+6
9b2Zlaogdh79k8JsGwa/x/iZP/AD8bcv31+evpkjJ3i2yAr6oqcO0eEssmDU4CpizXeZntuK
jVr1hioMlXr7x9P75z9xXsXkG6+d+kAdh2T+dG6acKFJ4SWdGA3BjOAPlBUrE0sSOgacevrc
XZluCtszHzsD18HAHap5YTmr8ANTQ+L+Yhhf6qzUe75PEevmrA8Yr8FbTGoEPSkrlf0hqTIZ
6XB/TtJBh/Xw9Pr1H7Dqn1/E9Hoda3u4Stf5hufiPkleLCORkeZ3GFzmsqEQLfb5+JWMEKRa
qTcfBYiLqorLjg7B+EnvqB7pNgHqr9PD1LCbO4h/VTyQi+5quB826eEep1mpQ/2690EZ1htt
wPCAWBHGGwoAK6vLplW+eVGwhDF+n4c9WHrYR/pE3KHb073oX3HW6BF5emelMq6NuLTJ73Hy
5ZyKH2wv5nKd6NEZuGBq93pQryo+Gu5F1W8poLHTeJpk8O1XO12PTzWkZdNEMyxjX1J1N/1a
rJgIpP1jWRCUTAbDkVP6YM5OIB7k/i5jmiF92neOCtFTlEVaHO+nfSfJQ0hRPSjGdM9Qz58/
3jRhYZdbH2j5mMDLZGX45MyKpkYV8IG1SRPxo01L464EUZmvcYJdgmSo5HifaI5fu1jTUeyb
4yzSG3H15xrr1MmExK/csgJTlCMaunZgYMQ0rePMLOUSNyokhfqtbUs8bbPQ3lS71DODgMLq
EQMXxJ+S6SHQP0NpI6AdG6pRxfRuMewuo9RMpkOAe/7X2/vjV7AJgwPp5kGUoHmLTXpNg5vy
9eX95fPLsylxk6GnpcewsDBi93YkKXBTHpnNIK0GgJ8mEbElcfiwzViS7ovGieGZMYcQxPRl
b9IUKQYbpE5Dj/+PesrMvaQ7qkQK1gFRrOK0HvCFHmVJEpl7QzL1JD0uLh6CdG1/wJakHmx8
ODTNQzE8HEk/1fIFHFwSsDppvAW894MuythgG1Dxs6YkCWubmy/kfVoLobDgcIUQLLEjOBRU
zdh+ZIJUJk7jAya5EzcbHhqjM+4K56pKgJ1p2upKWAzCEB0ObJxnWBGx4G/yRnA7Vz37Y1Ec
IahP19GThRsfkpu/xf98f/z29gQRBYaFPMy2v09vOxB2JOb6aoOUC6t4W4r7tjmeFml4z4wS
DpJSpCldVBOWcXCNLpoeWSVVEFYui/sIE9ykDhE16/PepIh+hMQ2EsfIwOIZFdW/bVWozDbM
ZICS7gt0gOBTcJk8sGZ5XRXYS0csFQBLDgGE8Bo4XINDyDJWywBmmeBAjswONmNk1PWvEl1n
DN3m/5XRH44q2QYjsMeQBD1sdrn0AR/aMWu6MOacR3UXWsT0sA+nc8QxcQFQeKiFdu8S2lIT
VkvRRcutDb+EJWiujiFZeuJDryBdILMMNv9QY9/MdOjtEFpyb+28kgj8YTJcPOrHP14fbn7v
u1rdzsbFpdiE5KKVpZL2pRkHBM9HFvHpr2//9yYr+UuIncxdrp/u8zsZHHO6B1sk7Omjq4Sz
pMndw1YIPOZc43zhF+zn4MzeTMzq25Ew7m0Sn1SHjoYuBQk67xsE08+W2gyDVkdyEU79wYxB
lb4/vL5Z93P4jFVbGY6J0JKox71kgtIwxUGRtfmspYJ+12q3COwqD3R4yoTLDhWdDep54DP1
lCFdKnHg4C8JABGXBtjyZjJSClCCo0Vgk1hVfbfKfj2Lf95kyrfnDRPQ+vXh29uzepxOH/4y
A0qJovbprbhWWt3WR5dR+gkv7483738+vN88fbt5e/n6ePP54U3kft4nN789v3z+L6jf99fH
3x9fXx+//OcNf3y8gUwEXWX0n/qIHwgHKTlFSEhKdYjI7Dg/RLhGAc/Ij+SMKEp6XOxwI/bo
q5Bi4l6obFIma0Gczj+Ls/nnw/PD2583n/98+j59YJMT/pDYM/XXOIpD6poOAHEIt9Y1vMsK
TICk83Yj1GVPzAtolV0cUPaCN7qHUBmuVgMw/SjwGBdZXFeYsRRA4L69Z/lte02i+tR6ZmUt
qu+krqYNTTwkzZ/sCKi634AHNjluaqSPs4jX0TSd14xNU891ktoli8lBbxsFTWN7PnGn1m0S
jvmmhPQP37+DmU2XCEGxFOpBhi6xd2oQnonW9+ZL1FYMAY+y6ZTqkjvHxO5vxcZMfQ7hMQUP
R+jS6MhjnAlmlISpK8+lEisA509lXimrJwPTPyLM9J7sPv74/PtPIFZ+kG6XRZ5T7XSzxCxc
rzH/H0CMWM0OKeMnu3cGgmDvk1rGCKdcH5vwgnDcItdUeCr95a2/xg17e8gqSDcr7EFfbpm8
9teTuc5T12wvTy6q+N9FlkeOn5lhSNVT7tPbf/1UfPsphDGi7bVk/xThcYkO+vx4qkOT5ZG5
p0NKawfEkztOHgON6D8INgLk/jSuHv7xszjxH56fH59lKTe/q8U9PvAg5UaiiHRypmiktkS1
52xUVKN5hOxAHUuSnrHqEuuqWAMF5JOyeV8nJJDIJYcQLTBr8MN9AEgZoxsCUs71AvPcMUC6
Z2mkfMLNjFbBZKaG8noykwncyNwQWxN3iuiVStyo7lHSDWIV44Sd3YBRu2p6nCmvf8OfLNLs
6e2zvRrlF/AHT+ayTcICty0eZ3LCb4vcLtvcncqktZekkvuEodgH/hArX3sItguI9Quvngov
kSeWZZYvKQICt2B3Szr83jbg7sUUSGUH/VXYnmST0jKKqpv/rf72b8owu/mqgpMR55P6ACtw
Pqv/ZXey/qakJUqrhZUM/lIXFZ+cHh2KX0uHQIxAQqjYiwyTmU62Yh0OkTbxC0SZdMofB3qA
4HJE0eSDmvWG0JGjWps7Jg9UyMBqtS3pGqniPK8h/LWeQRdNECXdFvtfjYToPmdZYlSgD1tr
pBnPZOJ3rgdbKw5S5ib2e9i/MpsAXgqMtE6QZWZ4NuM3ipsVIb81QrPJuGydeYS0qBgC4PWi
f12PMS87TcsuoYvBrZfbh+XOz2kKP9AR7UGg28E5HA1JufQbzHNWD03FJXNSsEyVET5D+Ugf
TIuQobILwDlrElV71PKwb83etKzqknkTOHOleK4wAmlzeVuH0QVXgBC8phxmUB1H6tWIi6uS
QqiYnnFuSJY0Mrzv41aV6gUJcNj4Wf0xpXNzuBQHd8niqRAfUhUX93XSr4JkWBIAVLkWZ5Q/
dICcrpMokjqZ2GQkraa830ui9D6J7tRG24ZjFzM1YdHaXzdtVBa4fD06Z9k97Ai4VsyJ5TVx
da2TQyZ7Epf6hHy39Plq4aFkwaukBT+D+Zt6ycJlNqdks/K9y2axIKt4KtskxVko+cQVFkkO
JhU0AiI1k4aFZcR3wcJnVCREnvq7BeHeTxF93NWAuPNzcTS2tQCt127M/uRR/hV6iKzojjAj
PWXhZrnG7fcj7m0CnASHjhgawaeUy+4VHnsXrJjBY0fXtoHr6cQWo59TupKZrUrW6Wnz6GDr
eg0zgsPpfRvf06b+vn3YKN4vLkEKM+H7VLrY5HxNwXNMXOvV65KV9018YitExppNsMWdGHaQ
3TJs8Hv5AGialRORRHUb7E5lzPFx72Bx7C3Me9LIY5qdonXifustJsu7e8n558PbTQIGlz/g
if7t5u3Ph1dxl34HUTXkc/MMTOsXsSU9fYd/6hsSPArjm9r/IN/pOkgTTtu8dbr1vGYl8WwS
59c7fEOLwxNhDB1m7YW4TUKISZaKXrSv5yakqnnzAQQ14U9sz3LWMlTFBvwYGcqal5Ll9t22
F4jph4iSfoEbpU4+Mlk5Ut8hKzShacWSCB5rK+19S6Jsgw5INH91cajHAYU0aThxmL5JyWp1
9bl5/+v7483fxKz4r/+4eX/4/vgfN2H0k5jVf9e0qHoeyeBMwlOlUglPFv1HuHRx+BrbFPtv
9/yIlkj47Or6Kge9TuJ5SULS4nikLI0lgIPXEqkhiPdd3S8pg1lQn5aJGkI690M4h1C6MBOQ
UQ7j3VT5a5KeJnvxF0IQ5wqSKq1fuKmSqYhVidW0FwVaPfG/zC6+pmDPbzzQSwrFtCmqfB2k
lYTUCDfH/VLh3aDVHGifN74Ds499B7Gbo0txYIv/5OKlSzqVhPdmSRV57BrCV0YPECNF0xmp
fq3ILHRXjyXh1lkBAOxmALsVeu1T7U/UZLOmX5/c2QNafdYTOzcCgxaQMpek65JdnJ2VXc6Z
Y1LIoLdiCjoQoFWKb2uSHovifeJRRfA+cpvP4yvlPm7ATBklGzHt0aysl5D61U71oSelP4Rj
/IvnB9hXBt3qNJWDo1fLZJk5OgW8BdflHXbKSvr5wE9hNJkEKpmQzxuI0XpwkoO4pefcLQoe
oNE1BPeUGNiGSvn4VyQPzKrPxnRmYNOP686wxV3NPXpwDmRlG4fmfyKcgHf7VJ0Q8hU1yveV
42tBxWcISDHU2deJOBzzZMJemWxOs/R2nuP7g9JWJRlCdcASWg6KmCcTTzsWnXmECzzVhJpw
WKyo99l6GQbiyMDvjV0FHUvpTjAwSdiKReqoxF3K5o6/KFzu1v907HNQ0d0W96wsEddo6+0c
baXN3xWDms2cS2UWLAgZiKRjTpGM8vG3AYwvN3T0SnkDn9gjm/wTYCy7bEhSzie58RU8SO8L
HoONrS70B5IoQldFhiTbCF4W9aksIkz4J4lKza+Lvz7auv3j6f1Pgf/2Ez8cbr49vD/99+Po
pk+7ishCT7pNvkwCO0NQOpWeGNIkvB/96AyfYN10kh4FQmNzlIlJhnEIkhTGF+MGIxNxP3CK
dBFza/IB/fApyZNXR51oGbHLtLuiSu4mQ6GKigVvTLEhgBL7ROhtfGJ5qHEWbJvMjRpXnqT+
ypwcYij7oYZR/WwP9+cfb+8vX2+k+q421OMVNhL3j4lyr17oHZ84rTXq1GCvxkDZZ+oaqion
UvAaSpghZoUZnCSOnhKnMk3McBfPkpY7aCC8SThq+AVk6RbVHnoxII6eSYhjRRIvuP93STyn
xD4tNw/C0WBHrGPOp3Km8uPdL7ctRtRAETN8k1bEqiZYBkWuxcg66WWw2RLeJwAQZtFm5aLf
T2waTYC4NhB24HILF7zvBhcUDnRX9YDe+DgrPwJwGbekW5uiRawD33N9DHTH979KFxCO2nXK
KTQgj2vyBUABkvxXRgRQUAAebFceLs6VgCKNyOWvAIItpbYsdVZHob/wXcME254ohwaAX23q
2qcAhEqtJFIyKUWEB+HqWlS3juzFzrIhGLrStbkopqPgp2Tv6KC6SsADNg2gNhlJvCb5vkA0
Qsqk+Onl2/Nf9kYz2V3kGl6QTLmaie45oGaRo4NgkiB7OcHLqU8O6L1RDfcn29G1Ybf++8Pz
828Pn//r5ueb58c/Hj6jGiNlz83hLIkgdsZDdKtoIYAmOe6FUabX0CwCxf6Y2PyySMqs8A7t
iDjr3ROdn64otclo5lVYAKSYB38h2ksjdaQ7huf/TJrs17rHkpGmd0+UOe4ngngG35lJSYRB
EgCpkEARec5KfqLejbO2PiVSY/2S8KTIKXE0lGI3WCdKdVcnIt4TJvOCRGjgQaHgFQHpZUGC
8CxFZXUkhCwFfwS8ZIQanQDZd72R8imuCitH9ySRY5cyfI4A8Uw8S8C4Sg8PFPWQMiueiU4F
xWJiZsKY0/FEuj6S40UOCGgPHskC+pi9lNLA4cwt2z4V9TaO4xtvuVvd/O3w9Pp4Ff//HXPk
ckiqmHQn3RPBXsKqXR/O01XMoD8S150beE3xLdGunXnXQEOPRZw85PoABQyUArU9nimxeHx3
FgzvJ0ckQELxJHFEdqtjhskLMxZCsB7Dwe+lZobr+aQk4/lcGooCZwfh42LPqvhM+D89Ujrv
LOSE3gDwgEXOC1TTEOLHjGaHZrsErb3IQa0KznEn+pe4PmmxFJUuk9KqGyuQUlpCrLLjKPba
7u+vT7/9eH/8csOVdxv2+vnPp/fHz+8/XjHn+OuloRe2Xsq3PIdXEoBkkajrHAasMaYYvaCK
7TvEpA7gmh57BeyjVcIDOj/4WJBNUlWuB5ySSvCtGcvzD4Y0FTOxTu4+ENU0q7frJc4fDJBL
EMSbxWYGNXiwu+Wfdqvt9uPoYLtzBwRVNWjQV6sBw8OwPcRp0mA9LKlc7Gipw7ktAKdhbSeQ
j4Qw7cKS0v6CLVxG+aDvgXchC9xDDj5Kwf0gJ97MhuqLvujDtc7WzwDPVrITcbQXHm6XTUO7
Qibw+MNP78rtgxvFoNtUn8CfvG4DF8kYlVolBH8RFVW7tOwnLkVFvQzU9+WpKLBAR1p+LOyN
GIfvimsKwfvCmQ8jVgo20ZCWqiTQ5qkO1qmPZHCMLQcNtbf0qHXTf5SyULKnhrkWB9c6qAcq
49NUXDlz09MBP+er5COtFfO1MN2VhDH1qtQpNdWoGFDPNGOfzEzjnA2TYe5b411T/Aw8z7P1
gcdrHxxopjxl/LJtjrqNK5TSy62NdaDcr16wXPSaCTZI7Oim4P3OdhGBfFcZkwnGBLVpQb6E
HjNfJlmdUhGOU3zLBAI2XpBuuDNn6cwc3VcFi6xlul9h8u3OhF4Mu772RepRpujHdt4QwZ6o
SVgnxwJ17gpZNZquNfwU3IJyytwnHkXvWz8ReYdyEiX9HZl1nZm8oofAOsrooJwKDd5905lT
aVskC/fmL2njcrqK7cdUPJI0/LXfKOCSnLXG9b57RQe3pWE3olMuWPRUHbA/NnielSSMAymL
b0uCkU6Tu7Pt83BCxGujt1GwZNwMHNEltTW+LAYyLi8eyPiD7kierRn4LTG3wmRmTxZ3ujrJ
jX1G2SejW+h4vZvdWyPzWJPXsHM6twtFne/+saDUx9kgcehEhEd5LT/wmx4bU2Qf+7N1jz91
TqXHjpQpbV6CKk4uTt0MfFHGszkdBOcO7v61JXeItU0BjEkPIscxJSoZg9doVouJzBbrxTJY
6zWBL8q7CW+mURu50UjmRx/VhOXWc4v2jSq1Ppk1g1SfShaLDKRR4a1dO0Weilw0CHSc1Qsy
Saw9LDWJqz2W3rVxkq5XbUK8K6x4E91QKedaRpddZmbX4JBwzPCUNOtT5Lfd3j/kJXXmDjaP
pJHLxYowRDrl3GrpSXeYAWTBXB/MFPM0FClL81d7CtOj0doxFd1mJNnMVe+JM7vGZnyAZHbv
SQJ/3TRofiocnr4Acd/8kLwYc5A/dfdxx73xQxk1GUkX41RKBBeHi5eAvaMpFzzuT7JaEB8J
AvUNIac9ZN4C3wqT40xHy9s3BADVm/prNjO7U3FFMLZOmSD/xCeqXuLEsv5iTuEMhE+6B5JL
WZpOTyCBPMnLhnmbgOTU+e0R1R64vTfKgN+Op4YihPtK3fgtw4dqBBAhveH9u6ak+Xp30XqJ
BioVV3PdrWWWNmLX0CWYkGDaAcok2UjrO4CBqNI30tf95+NIQOKhPGK85fAB1MLMJs7FbUT3
9tynVk1+CK1k0y+0QqoTxEpV8VDsGqcQ2Lq2UiGWuYxuZEyrocJJWaABuSQCnHOLaV7ZNvGS
ho+1oImvyEcAQT7geiaCsj+I8xmdstYqNjfFWx4EK/xKA6Q1zo0qkigWVx0AAV2wmhjuELvK
hFHKQz/4lZAdCmLjrwQVJ4vJvV0tZy6Gai+Ldd/JUthXhHFa9BHZwdLCmMITxEwh95XplUT8
9hZHYmOOWZrP1DpndVfncfmrJHxr4MEy8LEDT88zFltLYso+uE/cbi7N3PQS/6yKvDADMeWH
GYY9N9sklfX+NRY5WO4W5k3Bv52ffPlF3NWMa4tU14xmT6bi1qixwBczp2cJ5t3QkmOSx2aI
Lib4uRM+hPcxOFw/JDMCmzLOORP/MpiQYpZ1UprG+kd3KVtSliJ3KSnhEHmCDjhFvouxh2G9
ImcwBMwsH7xsK/gwUhzc04lIq8plN/DPoxv1TIlypuVXkdEL1WaBunzSv1Byc/2rwFvuCOsn
INUFvqaqwNvs5grLY9MW5GTepyp20VhU/csCfJgabSsIr6baV+LAExdj48ziwJ8SVwv9yzi+
QyvCi1Sc4+J/Y2OgnIxwiO8IU2Jm3ouLEzN3rnDnL5aYgzHjK9N0IuE7St8/4d5uZibAY4c2
Mlm48wx+Ny6TEL92wJc7z0TLtNXcps2LEFwx6q76uNg1me5+BBLEJ1wXFOhZ1PIM1PB1Bjd+
9Vo71kelDkEWsWYoyCCT1BU9rkABmxtxXyZmj8L0scu+mslJeRcsNs00Twev2wOMWEUqUW0K
9Qlu7xZpCAJmpYuuBq51kgya6EhiMElMsiaY1l95kiIC/ChIHwFp+nFaFPmR8p7VD8fc2cfP
uXkKleV9FhMuc2E7iAkXKYxzyhNhnmCBfPVK3OdFyU1PzzBdmvQ4+xBUx6dzbRzDKmXmK43l
q5M2YpcE4q/agq4avFcLTrw83cPkxyTLSXu7bFm2WStkfubcysGgK44xinGNdQNNWDfXlqbI
tHEXk5kRP9vqlOQ4xwlUiMkdWhpJ02yvySdLYUOltNc1ZSk1AJbo1qdlrrxa6Jl3fi7g8AYx
AZp/h2HN9MnQxqSpmBgU5hBFRCzJpCyxqSS3kKRktr4A39v6pB1RzCArEC0kaMc1v4oUQ0IS
R6DQezxC7JoTNjaHpImlK1DzMEUcziXJDWRBe+WER0e8EOUy/diksiD92S0C3Ub0m/7Fsatb
n9oEwXa32XcZdan945yVGmbrlQfKxFYqWDDbNRHJwSoIPLs2BmCrvqPobXh/FGuXaBAAYHi7
QdPKDpMQQvhROXdPIiQdNp6u8YQAr0yntRrnSFPTn8qzpbmye/pzsGOuvYXnhdToK9mbOQx9
orjF2kPRk4Kg8cV/ZMkZa5TWcnskIWNMTKpyUohhTrJROciu2UCoJxNFh8A92l5TWVGLC6G4
mZDtyWXIBZbSgKZsw9W6rUEByDEVAUdg+mVUB4tlY1fxrq838kWv3WN90t0nqI/6CJRG90qd
HqtneR17C8L4BwSWYuEkIT2HoxLkE/RUAXodBh69vGUOq8BN32xn6DuiI3pFI6v3umPlKPZW
v4I/8UmspugtD3a7dYZKPaVyodSX1WYxJBqhng7XHGLPmILv4mAlyODJlnC8y78yxQ0yWSrb
UHWyLCVVlZJ6z/KjnRpmdsTfIf2cJ8btWxKGl32zOrSjV6DOvHpJTHahHAApMojuxFARHlYB
osTwNF1cRVYLb+cEiLsK6nIXyJ3CwS+d/aR8es1+PL8/fX9+/Kfp2LibA212bqYzA1L7s9nz
mdXBPUAfGbOaPcLuc7QYqaWfxo0e2sVEZElRxce+VWXIp7xGz/eIraARf+iRYnmb3nfM3xCv
cpKD9hJSEs4LcJUAMSWU1qDUvTXDTApSyGp8RgHxll3x+yoQy/jIuB6hDxKrOg289QJL9M1E
EFEHTWMmiv8N8VRfeWCevG1DEXattw3YlBpGodS90PdrjdbGMabMriNy08K7J6lH2h5B9l+f
S7ZHI+oNQ5PtNgsPK4dXuy3KUGuAYLGYthxOqu3a7t6eslOUSXHHdOMvsG26B+TALwVIecCn
7afJWci3wXKBlVXlUcInwW+RzuPnPY97jzjoGHcQuxRwZ56tN4TZpkTk/hYVMwFxH6e3uoWV
/KDKxLl3buxVFJdiK/KDAHewKpdS6ONStL4dn9i5kqtpOoOawF96C/KJtsfdsjQjLBx7yJ3g
kq5XwtYCQCeOn0F9BoKtXnsN/hoGmKQ8uarJE9DHaSldKIBcUupRa+iP086fgbC70PPoWqoN
adnGIbYsr6muRQS/RiXjzJJ3i5TA9zBZK6tPvVO7r2hetaEzDHD6/VxQ17jGgqSQRqeCuiO/
2922J2LzD1mV7jzCo6j4dHOLi8hYtV77uGreNRGbi4etAJGft7gde0n9bk2PITIJXGh9NSoC
qeyEMz0dmVNqih3d4pmsj/MiRIp0jtQAIDy8dRCIHmvZfPVdFebLjblDd0lYvujcysznbZlA
VGa7CdeLie9IJFdckRgfbZFOWvWC2xQZHkcXYoC/MVzaCaSDwUX3KSpwpGDzIl05uCdyS5o5
ECgmeczW8ktrILBxMwDRHh1TrSN75VKENNHWSsqrT8kXgUbthMk1Xe02uKmNoC13K5J2TQ7Y
tciuZsXNCEdwlBPRoQQLlhEmoeV61W2TM0WOelCjACfZx1VNeGzridIKGSL2YXw+NDU2FlqX
NNk1LDJMEewz8gJ2TQPsncZoYSfyMW4rYnkuvDOep6D9c+GiUdE+BM130eg8F0v6O29N0zZL
Os/NkorHtt058tz5qIGE0aOYXo04iOAtckEfDCMClX7rJVTMVrOuar9BWXbjs+nLueRJCOcY
irZFMhUUOKwjg3GU8J1PaD92VO6kRjR16y+Zk0pod6pGBLGzXAdV8FmOcqG9+BQDatM0FPFq
Mu3YYJleDMXPdocahukfceOpKLx6/uykMN/xrqnnE2pnQEItOgXBuFJfU1sDUaWQE1sRDWO/
K0j6boeXbRlYDD+7Pt1HbCJf+BSJluPNAJLnVdeZbpGvKXFuWlbc1bn7qBbEYCGyBwMcQuJl
3kSvpHF6UtWtfSaOHcqm7gjAMcDz49vbjSDqz0zTm1cn7zE+6PtAKhNJZwJk1IyOjETNGGuf
NWBqh9IO51+Tmp9b4mhWuXNUdAH9dmBJClE/DHaFR4h7hm/ff7yTTsKTvDxrOhzyJzz/cTvt
cIB4M2lsPjErGpeRWW8zhonAFCRjdZU0typu4RBK9RmiyQ9O5IxXwe6z4sxj6sVaQX4t7i2A
QY4vVtSZPtm6Q2h9NYldZ3x5G9/vC7Hpjx3Up4j7qHFd0dLL9ZoQT1ggTA9rhNS3e2MaDpS7
2lsQUSoMDHGp1DC+Ryi9Dhhp29RGSbUJcC52QKa3t2ionAEAEmC0PUAAl5Ap4RxnANYh26w8
3BOQDgpW3kz/qxk606AsWBI3bAOznMFkrNku17gkfwSF+M4wAspK7OGu/uX5hbfltRIJ6MTE
3WXq5JaHLfV1Hl9r4r1i7HoyDN8AKco4h6NvprWdSuAMqC6u7Eq47RlR5/yWiFmkY1ZJm1aM
cMo2Vl/sabjB49gJmd/WxTk8UY5/BmRTz6wYeCVuTZPEkcZKeLt1l7AnJObjrKoFvyF4d3or
hz1Ze4yBn23JfSSpZWnJsfT9fYQlgzaw+LssMSK/z1kJz7lOYssz4/FyhHRuHDESSBVuZcgb
8+m9p8fglyQmPC9plYhBgJAQj4RjaXIqJGiM3gF0KEK4pRiGI2NBXRutzB0R5xWAlWUay+Id
INB/oZwyK0R4z0oitqakQ3eRLjoU5MLFrYC5MqFfZFVbhwF3FzTiKOnAwEZwASMs0ySkhjcQ
bNQ6MvQrBx83hlqjlizOeL4NiKBBJm4bEJ5oJjD8FDFhhFcAHVN5gmG3+xIDgjCzzRrjwQcF
tPXyA004i3M+acIEd2+kQ/dn31sQrkonOH++W0A0UeRxm4R5sCS4Awq/JvzoGPj7IKwz5q1w
fmoKPXqEx0MTWte8pO2zptjVx8AQnrKs8CWn404sK/mJ8uOmI+O4xq9tBujIUkb4rJnAXDuc
gW7C5YKQzeq47g42M+WPRRGZ7pmM/kgiKpSpAbsXieLP1YY4oXWwuPWLOfwhXE141DJgoIYx
i+Ibfr/d4NICozvO+acPDP5tffA9f34HiKmrvwman5hXBtqMV9Kh/xRLnRw6UrDqnhd8IEvB
rq8/MueyjHsefroasDg9QMCUhGAuDSw/+pvl/A6W0Ue/MV2yZnNO25rP906Sxw1xTBsF3249
XBFAR4l7QAaxWWeWYxzV7aFeN4sNtSQrxst9XFX3ZdISxqo6XP67So4n/F18Ar0m8xP2g2fa
NaqldvBHZqJUGCqysuCUSvqkpklN+fY2oDyUG+v8OAqkP4lVSOLmj0iFm98jqqylLBL0DSxJ
Y4Zf60wYzTMauNrzCfUVE5YdPlI5W9+RQFUfYBcE6sDCeElaJhrgJtisPzBkJd+sF4SDcx34
Ka43PiEEMXDSkHV+aItT1rFs83kmd3z9gePzk4ywg4k2uhtswsOpSFBw0x4RBqADSM5W3LLp
bVQB94LrI6RxnfRx2SxEo+safXhVmDILdiuvl978NSGCMcIl2VesNp0ld03MWLBy1kGK2PaC
dSE8i2qoKA6LaB4ma+Psv6St4qyoY3xVDfJVXor7o0K6gE39K87ld31UXOMqY8487mP5hOhA
hJm3cJUCToBTGAOwX6uJu3/X/qb0F4045lzlneVfrmaFh2BNXM87xDVDBnYCkcM1nTnVbbBY
d9NubsSrombVPfhDmJkfEdv6waLrIiJWc7cIm3TpXIVJBtH88AfFDnHH/c3ONRMFYuNvXIgw
Y/YNwqDDA9DtPqLeh7p3kSLsVrm4X1eEVLLroOrib8TkmO8hidysP4zcYkgDJ7Xb5WpRO82Q
TZUl08ujfCg5Pbx++cfD6+NN8nNx0wcq7b6SrIRhFgYJ8Kcd+Nmgs2zPbk3XEopQhiATJL9L
k70SPlqfVYwIh6NKU245rYztkrkP+ueubKpwJg9W7t0AJWh2Y9RzCAE507zbkWWx3enDuyc2
hoOzdezRUD3P/fnw+vD5/fFVC2ffH8G1dk5dtFfFULn2BjFrzlPWO5kdkD0AS2t5KraykXK6
ougxud0n0p27pjucJ80uaMv6XitVKciRiSI3cRP5xdsMpEhGiz7XRVqwqH/E5I+vTw/PU0sD
JadoY1alcO/XjJgUIfDXCzRRnLVlFYfi1IpkvBGjp3RcmZc4wdus1wvWXphIymtuL4wedgAt
MjSApAaa9LRR04wRVTPivGmEuGEVTskr6UWD/7LCqJUYiiSLXZC4gS04jqjmZiwX4yqWAhFA
S4OKy2Msev9CuPXQofzEwANTdUcVG8V1HNaAmC224pjuv5HZ1bTa1Uj7MPOD5Zrp5jrGaPOU
GMQrVfWq9oMAjbergQr1oE9QYEcowFT4TICyerPebnGaWLXlKYmJCSPfFcm+2Ppbb0I0Y/HI
5Zu/fPsJvhHNk+tYBixHQld0OcARJfJYoIrUNmZagZGkLSy7jH7LAGuHFgwrCSONDq6cTNgl
KeMsavWOzlXQdLXM2pWbPlmGPZUqFR8xmdrW4ZmmODorY82SjJSqQxzzOMmmawYevql2AE3b
1+3yoHNsnwFWR51ajuyQKnncCb0AB5CjqsjkkdPRsV27C4gyTXR0/a8cDV3cdTrPpnOSZ2Td
pUuDY5xPe2WgOKrCk0NChCnpEWGYE1bCA8LbJHxLRSBXILGzbJZuSMdX/lqzo31+EFD3MdOZ
+pZc4ibdY5IdfSQYVVddqpJisAURfM6mJVr+SCLHVkKSHILD0VmMdEcbQnA4JHiaNkqOSSj4
MCKGaDeiZYVGs+1mI0R3xftUkajmFNfpSQpBEvRq91GATebQLiasq3SiAdURc5FbzfKICi+U
t0eO63HkxaeC8sZ3BkckqKuV0yXs48P8pacp1kZLaHT/mF0CegOWOYbYa3LXRKk7eZ5yt5Au
u0bUVHqTH9l8FblnMjJJmSXikptHqTQ21VMj+F9Kryw4cAK9Nu14bZYUBg7ZJyG8jFylybyy
wwBBrFUoN+ykVJLYo/CbOlCvDPzyFLhuk6oU3M6LA5nHflInbJCv4lKcR2ZM+SER4krDRTIj
vCyNwD1boQ7ONIRiR8d+GUnyLbKt8qOvW86OdMlRovWbxuKeQGTMeyRT5U8AIVg+ukZC5yYA
+6S+xZLj5j7XfXppLSrrOMabFIqJTqi0aZUHs040qvSIkcxiFoZhCxkaNnNlCa69scNaTBkx
2OPCEL/NBVeH4v/SMDmTSUSg0I5Gv0r09Pv87iymKPE81qESP2zDihBh66CJeR2CASOk3Ara
otPz86WgdBkBR5vwAbXPnQSITZKkhRWulgS0Sw2R0auiIQL2CcgBIDVhuTH0eL1cfir9Ff3u
ZQOpMRQMR3ovtm2aSKlZ9btMdebikC8JixAdtC+KGoQt9kTpjtepJErpcIsmTtXcfc1IUXoq
gVEvyio+JoYjdZEq1SDFkBZmMjy9stpKE/d/pV6uJSqfGcrFxuhdQ9Yr/PPpO3a/lNO42is5
n8g0TeOc8NLblUCrx40A8acTkdbharnAtdF6TBmy3XqF7fYm4p/GOdqTkhxOcmcBYgRIehR/
NJcsbcLSDr7czRPnIOitOcVpGVdSxmeOqKVSKkcrPRb7pO4HGvId5Kn7H2/aIHdeSW5EJiL9
z5e3dy2QMeYPTWWfeOslYSTa0zf4g+lAJ2KCS3oWbYn4uR05oEz4O3qblcQrHvSkih5B0hNK
oUYSqVDXQIQQzsTbF2zj8s2ZLld5WxZLg3g+grFO+HpNxPXr6Bsi8GBH3m3oZUcFwe5olv6d
nBUyujMxTXhosvrjBvjX2/vj15vfxIzrPr3521cx9Z7/unn8+tvjly+PX25+7lA/vXz76bNY
E3+fTkLb57++S9osXpdoe2OSyWBfXu/tLaKL4kR2SAgufggnQWp74MkxvzIppzDd+lpknjI0
BooFw0J12xDC1wPA4ixG46FJmmQP12a/yMvfVzMTeQTI+NSCrfg1DmvilquWGccsCeUi0qVa
XYK4qRvnoNw8TfmhTKo3RjgTmXbZrJqmsTsmF9x6lBDP2XDATuw6dKIhO5Yp19QuQZwuaHhF
HdKwyVcNc465lCqFYWLO3lEKZSafrWpWSWL1YnW7tDqMn9pMHBDpZFbyJKuJILiSXBI3fknE
GGeNbolYh6R2X5pB0IDSy9eJvHpye7A/BEdWrE6IgKSyUOVojN4GldiKJqflDjWxlX0dssGF
WfxPwf59e3iGPe9ndcA+fHn4/k4frFFSgHHCmeCD5bZT+huPPgCqYl/Uh/OnT21BXuqhDxgY
6lzwu7QEJPm9bZMga1u8/6k4la5F2iZuMLS9LRDEQM7jycpRARp5mmSUVrc6dOxL9fgGTPE0
1qSsz5jvEklKlT9wEw+JbRyLWtGdo0Dg71vMQ0IbRm7M+/ORVm8fIcCuzUAmlxqtG5CWL1HR
VmnqL0B8Z9tZjUbLGETV0SRgkBYPr1NwB8se3mA2hyPHGE0nNnxHHtaSWGXgKXa5XSzs+oH/
YvhbhYUgvp8c9loivDna6e2d6gk9tXPf+NUsHuEBplSwQo8mOY6nsll+dO0eOcxxuBIOyTsi
uBE081Gy7UmxkDzWxyhDKtLcnvMyJoQ6AwjCC1yW6B4HGPDECgJxpAyCHwISnPlW90JlcXcD
PXXar+rxUPwrDM0OGQiH0C5H8Qxkm8GmMKfE9YJeqO2QpgtWwV+R3VVUxiUeksp04ft23wm2
AHfdAMTB/b710eCM1goVoUPEzDrYXVLR/S4ZDblEjP41GI0BZzIkkMyXIXBjdkV56AXicrJA
X3KALlgSnhSTior0EyXukXTH8xqQKY6lJ4K3bhpAuIHtaJvJ/HcLD+VkaxLirUsQJT/kewu5
hN0oykpjzGYh5kTKOBG7TYeRSqYS5WKXAICxagagASdONJXmtiQ5JV5GBe2T6O2sbI93rgnC
MqMnx7NLE7xgShUwVqaIavi0fH15f/n88tydf7pmlZxVCUjdrHmcFkUJzjgk20B3dhpv/IZQ
GYC8iWuDPCbuc5bpvD8vLYVF+RIlNvjlZovqiAAdHsLBwBokfsaLGXqZK0tDhUv8nLIUSsRU
8pvPz0+P397fsN6GD8M0gVhWt/KlB+0BDSUV3uZA9mk01OSPx2+Prw/vL69TUVhdinq+fP6v
qZQW4p166yCwg56a6Z1eHEtJQFTHJO1OHBZ3w/3h28Nvz483yrX+DTgjyeP6WlTSX7l8EJPx
o8Hh3PuLaODjjeDNxRXjy9P70wvcO2RD3v6TakJ7ezGECRY1ierALwlnEVMsYblv944dAap3
azzp96HOSsA6dlkXCqcntMeqOOt2/CLdcAyt4UEYeziLz0zNRchJ/AsvQhGG9ih23CX17esl
Fepx5fwBkuG7fE/PxG1vyReYF6oeojEGFoWLiWHe8AdK460J+80BUmcHjBcZasaa7XbjL6bF
qk0ZK1bq7jtLVcED3V0yRCvg5CNDj72N42zPMI2CoUBdX2Jo+3aBtAuCYE1T+7vHhKBekjsF
CouWc797h5nOCL4kvOAMJcaVODDb/XEVYioAQ/m6iE1LFIzYGSUEWUak50Q6Mudk+h2efkfk
f9cQGUVNinURkM4p5sxpmCOgIzPNs7tnsjJYbEhqWHoeMs7DHbVBulUplE3HcurwHscEbozL
s76GIZzrG4jtCpupd5uFF2AtEA0LfB9/idExG8Irk47ZzWGkq3Pc2tLAENIvvaxm6+oJWRtv
QzV4tyaOPB2z3cwVsEO6WhGQyacIwZRwF/LVAsnpLjr4DTYX5a1McnJlZsauNBF8n1COdIYd
L9x6AbYThmAuhR4sIfipnDlZosyaLlNAsFqj2UfN2j34PNt4M/MDIP7aVX4mwxRMm52ZdhFa
+hJLT0vGObxqiKuA5OcqwXW+PbzdfH/69vn9FbHLGA5KO57lUNSpLfWozn26SGyrgG23ux1y
FGlUpJojFWuERvVc1I2z3I0z540zZ2wGjtStk8oQavXp6COH/vDRKnRluYpdlV0xJ3Xv/aIp
YFLTYTLotkJ8T+iUuoh0OLI2K3QZgdiDh7vAvQxlBEfsc2kSxghvMBpqjV/KNcRG5LPE39on
qJa4E464QOAIM20LRV1qTFSwdLOiI+yjdfsQ7rR0j4qEtBUxNIJ6IZwma6gd1Ht2ABWqxR7h
9GFeCNgGOaNGWlvRVA9ltkei49sTsun0JOSQHUiuLDee60sP/dZ62TSSPR/pmV7OR32D8Q7q
rbSBWCoTmmaNNBnH4ak0jdxs5gAUN5cPInka4X5dsDzdx/KIbAhLUqRBG+xtD8F5yLaskbFr
rF6fZS+RyR6/PD3Uj/9FH+FxktdSCXfK4hGJ7cXH07PCMHzRSSWrEmTjz2p/66G5bbbYAQ3p
2x2evtti6eLKj+YfeBsUH3jbJZ4eEOk7H5vEkuJi2gRgiTcxWGMrWjRxKZs4KuJRYzv51FRK
MZLbY7NH1ucQKpQgBYIVx+6V8jPWIGf/QHJ9KeOfUZ8iS2KIqDzdfLLysjXEIiDZMAw+u4T2
wHhdQsiaNMmS+pe15/eI4mDJQ6Q2EWiQTXNJqjv7uUtJ3ogXRqWbami7DkntxbNS+2jaZmoV
H5V6f7fWv768/nXz9eH798cvN7JYRGtDfrhdNSrSG1Ux9fytPwmo5CwqMRmOqo3mJirWRSTK
NUoIdgPc1mdTtKlCm+oL8jVb+VFRoZ6tzKIrK6dZxYlDGUghGoYzO0qFrIa/cFNVfYRQpTcF
qEjxn6Tb2mcWNb066g6OXsMLdjWW5GwfbPi2sToqK8PAuJGrVFMUpdIae8TKdLGx52inSWQk
IY/AkiCuCGwd+WK5FntceVTB6LdSRXeOKL+H3YHqFIsHGtO8YDOpL/amqNOn1tWdCx97f5LJ
1zDaLVeanodMtaJ0jmktn85nxyOkohOvkJIIEm+aCtrIB1tneDhzyD1mUJaVqY///P7w7Qu2
97i8t3eA3FH347WdaKYbcxV8gaOeZkay30z6s0u3XQsYcx4085f2eulSba8FI42QjncAcD7k
GMa6TEI/sG+umiqV1dnqIDhE00Ew9ttIVMvLrhdrBk7fSNQ6Sv0AzAEmx8FVSg3xiTKtQ6e5
n8xNkH0dELovXZ8lbQIRSwk39T0oVigfvxmo7SkKl77XoA1AKjo8p880QJyuHiFF77t56e3s
cqeTGJczKEC4XAbEfVh1QMIL7jjPmgo86S7RpiNNVCEm+B5revcVQpXky9Pr+4+HZzdDwo5H
wcwwSjtbtVkcJmfHzuDQvUTrMH5+xQxypI2oYLEgGOdfSCLGtehk+rHPAsE/a8q4XQeTHIIO
AtUYkR08GLsbZXoV0AlS3l5KQ068iDr0d2vizqsXIK4slHhLgw0u3z6A/FhHXQT7Cb7pZzrA
OnB1kmIdqKFVVNSKuENXMVjbiSmrW0p3n5m0oYAcrEd1Ill7fi7L9H5aOZVOqsgaoNM1s9oX
MYXAF1jH3bIobPesFpcDwoRSjJAjGzDwO4JNmOABFoRv5C77Nrz6C+JlpIdE3N8Sm6ABcRck
IZiWXw/geyMiWd8IkYzmm7GcIXQr0/2dvzW4b4vQ2VhOatuTo7o9izETHQ4zB61I7yCRHI4+
T3DKvF2sMKbJgvhYRyS8BJpzxMX3wc4+byxMWgZbwsN1DyE31bEc2fnucurlhohGNkLClbfx
cX2ZHqS8Uclwjo232hAGgD1avWJme9yct0eJ4V15a5w1MDA7fN7rGH/t7kzAbAmrSA2ztuqD
IMTQjqykTtgFC2zGAIly3D4sr2y/XOEN6CflkZ2PsTqOVu41fizS6JAQqqU9qKrXC+Khpa9U
Ve9WxItuD5FmJIIZKjF3KQaoDE9HfYn3xHPIvcUCP1+HHox2u90aUxqY7OwyobftEJdx/Rvl
tuvhXXBEGG/G45wXFQdfvktKfXeErD4CwS9+IySDwBkfwOCDYGLwBWlicC0VA0M8+OkYjwgv
omF2PuGKesTUopfnMasPYebqLDAbykemhiFuryZmZixO9VyNQQW9yMpzDbvqOo8bytNThyd1
zkZEKC6yM33QJO2BSb9udVVgLi8GJLgDCTPDnZZOscxKhjqA40N3FeqmdFcyFH+wRGwYlNWZ
DSw5Lk/rcdItUR1nlPuuDsU3vruHI+7NdXCyvgUnfU7MATR21rjdn44J/ANhAzSA1svtmnJH
2WFqXsfnGpgmJ+6Yrr2AcAilYfzFHGa7WeAG6hrCvQg7+2Xc30kPOiWnjUdY0Q+Dsc8Y4YpI
g5Qx5Y6tg4Ao+poRvlkGVB24t8Nfw5W72YJnrTx/ZgqKq27MCL8eA0YyB+4NSmG2pDcXG0ca
b+g4gj8zMe5OkEwowajqGJ+4JhkYf74sf76fVj6hFGli3HWWMWBmDijAEHcBHbJZEGHhDRCh
impgNm7GBDC72fosve1MPyvQzFoVoM3c5ioxy9mGbTYzK01iCLdQBuZDrZ+Z9VlYLufYuzqk
4msMiJL7y2BuklVbsUHj3PzIvYSk+8luOmeEV5gRMMOJCMBsDjPLLpthLgXAPXnTjJCSaIC5
ShLBaTUAFtJ9JO+Mi6CWPrMvZbu5mu3W/tI9YSSGuCGaGHcjyzDYLmc2QMCsZnauvAanDnGV
JZwSew7QsBZbk7sLALOdmUQCsw2IO6WO2RFynAFThhnt1rXDfGrq9rZit3HuLrAIw7YMZs9d
+Uq2I7QuM8vRgP3tNQP2SbP47Qi6toK6Mk8g2LvXQNvXhDB+RFSE49ABIS5G7lETiJndUiCW
/5xDrGYR4UwpDi9Ow4Ugi8XB5p74cRZOX52mGN+bx2xAPOyudMbD1Tb7GGhmG1Kw/XLmEOTh
ab2ZWfwSs3SLJnhd8+0M58ezbDPD/IjzzfODKJgVuvBt4H8As525UItRCebuhDmzbAwRQNNM
F6NIX/q+h63FOiTi9wyAUxbOsDh1Vnoz26OEuOelhLg7UkBWMxMXIHNMUlauiVB0PQR7BJuC
ErYJiMg9A6b2/Blu/VIH/oyU7Bost9ul+w4PmMBzi0wAs/sIxv8Axt2DEuJeYQKSboM1GQZD
R20oLyYjSuwdJ7csRIHiGZR82dQRTtd3w/oFR56T16IOJPkVZtg3dkltHtekQ4YeI5+kORE3
qQfFWVyJmkPImO5ptY3ilN23Gf9lYYN7ObeVXBywKl6rRIabbusqKV1ViGLlLO5YXESd47K9
JjzGctSBBxC8yeAlzj7QP4EoQy0vGRXSD/lEvd+yNC1C8rW8/46uFQJ0thMA4GlI/jFbJt4s
BGg1ZhzHsDxrc01LPFTxHTYLo/iik5zT66yiJWHtJLRhpXshpFQwTKZLVGbLw3dftfQgy7T0
Ib/bJZbdQO41sxxlSk8M0yKVhc2kRwc3PJMPQI0TwUOqWJvLKamzNJ6kg97/FJxJXVWNIHei
/evLw5fPL1/BIcTrVywEFNitbz1vWt/OoB0hKP0c9Is259O6QTqvjNHu9IfI6imVsIevbz++
/UHXvbNvQzKmPlXvctK96k39+MfrA525MrPhRSizH1s5uio05ltXsDPvcd7peh/I1JPVvPvx
8Cz6xjF28um7hmNGX0Kj4a/MPcOsJUYMPFmI/YLpTZTUNDvpDSNr03802Mkgq1oaGtJLrA8s
ME6ZPmXiMXUg5MWV3RdnTGt+wKhgC9JBdxvncE5FSBFFCXFlkywWuYnjcFoUv+cHnBEZS6qk
s5pWcIZdTpPhvD68f/7zy8sfN+Xr4/vT18eXH+83xxfRhd9eTLZhyHTMDLZ2OsNIxb/DPO4V
h9odtkHpm7oQ14jVEAAaJXaBXZwZfEqSCtwkYqC+np1EYJwJX7VdUEwfiPU5nSWStudMJw3F
ao4a3PXrvfe56rcM/ZW3QKoQXdHCxbEjZoQzS7Cq1durn0kQvsdd6eHgchQhTkUfRm6sbXd+
QtpX48zdntOSHGS14zkKkvuFyrSv3mADhQypIqJNj8XmWce3rsK6GBLIWHTW8l2Th0z75OoT
s1po71zYSMqtyzkUpXQi4cb0BgtuFEuTbOstPHIkks1ysYj53gZYR7Yx5hBnbrEM7EHPxKbH
fLqoRoV9n+w6ZZj89NvD2+OXcf8JH16/GNsOhEINZzaV2nJz2WtCz2YOKkDuzDtvP87VJ/qw
LDhP9lYIJ44ZkoouZCgcCJNGSH9yv//49hmcb/XBSSdnd3aIJocbpHXhtpi34Nh1UYOIYyk7
VpPvwzrYrda46AEAymr/WArmgMSAIgghmujJxHuc8hgHpijEI7P8ntV+sF3QHnElSIYxB/ei
IeGBd0Sd0tDRGjFK690C9agpyYPVxqQrPdTgRdKkDqjGlA9pZhAPLb3SDbbl8HeOkZWxolF0
BuFE8DGUPRyx3WKJvxbA50Be++SDugah3ggGCC6n6cmElsVAxgVBHZkKPi/JaY6pDgOp4/ql
VxVjRxO0ozg9wDEeb4+EV0DZu6G3BF1fV//0GFcHZaW/8TGhKxBPyWYl9lfb+Y5GAv6b/ni9
biYfn+qwFc1OQrxfgSzqS9lxpaUgE0ErgEYFtIAKQcCuVNQHPywkAoKV01PyV5Z/asOsiAhF
Y8DcirsIUXcgB4E4aokwmiOdnrCSviG8EqlV13ir9RZ7cO3IvRmX/ZlId0xmBQjwt4kRQIhN
B0CwcgKCHeE0a6ATyp0DnXiFGem4CF7S680S9SLTEzsbez01zg++t8/w9RV/kjF7cHU6uXs6
qZekjCsZIomE5HVDRDgAqrh74Qp/QCzDw1psbvRwSI64KrFYEPIMxtxyyVIxyzmdXq8C4kFA
kUlNa0kO1/XafPTWqbfBIphUKF/XGw/zOynbEYcoE8OT1XbTTM53AyGWeqw2Dvu8HN6H7Vyz
NfHCI6m394FYvfSBxEOw8Jj4OjMxdVaSVZYOiMoqzKzqTmyaILUGh8PLpdjEax66eK20XO4c
CxuMNwir3q6YNHNMVJZmjAiDV/KNtyBMIoC4XhDqxYpImNfKSkmAY79TAEKpaQD4Hr0fQbtF
zzh4oA6xJt5ytVIcvQuAgAiUNAB2RD9pADejNYBcDIkAicOPWPz1NV0tlg6OWgA2i9UMy31N
PX+7dGPSbLl2bDF1uFwHO0eH3WWNY2JcmsDBcaZFeMrZkfAnIVntKvlU5MzZ2z3G1dnXLFg5
OA1BXnpu3rCDzBSyXC/sXEwAeI/8auzSxSkTV5atF5iu9XWaYOzpOT1mMA8SF6MmO+Nvomq7
hN3UsScTzoNl4wZnDdaFLvQ3C3ff3p5YxEDrkd74lK0tsIvU2dW/48P+XcWGzEeKK3npXgiK
I868RUuxMLIjeXZ2tkUCJrNEjwlIiRJGsVdn52sKvbpE0mx1RBySJhb9UaQ1O8Z4JmADflax
rfmZ8so+wuG5Ur5WfvQDwZofqX12RIFsIyD2cw0VrZcEp6qBcvEXzj5qoM4+xdl7tiRgpIyr
FCEhMoeR3EkGZqoHV2hCn8UA+ah3HQviYdU8sHy9XK/XeC0l1fKWMAHZkcNHiroFOz9WkMt6
ucBqpy7JeOYJT3dL4i5ooDb+1sMFLSMMWDRCR8sC4dynDgq2xCXZBBGnoAZSJ+0HUJstft6O
KLj3rgPMkbGBmVx+DWqwWc3VRqIIPV8TFRB3YRNlOUvAMdLvHJ6BuFITtowaLCw9wavODWxW
rlfeTA+WQbDeEZURtNntLyvvtjtCrKqhxGWbkN1aoLkpNvUzgULWAdEmoM1OCQGa2UEG6cGE
An6AVmt0bygPQbMgKOdPsbcgJnJ5ERva7BSVKEL330Lt3I0rrxlWyV5+cCKJPIsAQNOtmC8W
+cz37YUKkD1idW3uujiHJx5WMbwc1XYgrOmnnThhShC8JV4zkG4QN3wdtPFmB0iAKKMDHXTn
e4SJg47KLrOLTmS12RKyhxHF/axkC/eRBxjueXgH8XUWbDf4rVhDpce1mOBzdeb3gbcgdFQN
VOCv5rYmidri1osjSlxh157YU+ZhG5+yBzFhYmOeOygwaQUO8paGGw6LanXClOeduKrT2Gfw
nYnn7VQn1mB3WRY6A0CMWMx9GL4LpGyf7LEXz6qT62naa61yiTlklSYVdm+t4D0rLCJxATD0
+qo2jwcSWjcBqcL1PGQzB/n1MlsQL/L7WQzL74tZ0IlV5RwoExeh2300B2uy2ZwS5XJipoey
DMPoA3RJwtgYH5HK6kTMj6yoiSilVWspP+skZyh1VW9nmyp2dfSeFX/W+LoWl8yE7IwDXNNv
kW6AjKX/3q9mYVI3pSaC/gIzQoSRFvP7fClquplVHFWsJmLdi4lUVzHLPhFPGtDQY1GV6fno
6ovjWdxrKWpdi0+JnhLD38eloz5XnmMTbEpB9WWQALMveVwlhN4tUOmqNPuiaaMLEWFatKTA
WI8wtjctSMmLOjlYHtGlmpGkVoRgZgCAW6+iwpRtFKaj68pNWrKYfqkROren7qPq0rJzXfA4
jcP6F92teC/nef/r+6OuMKLqxDKp+9EVa2UsRj8tjm19oQBRckxqlpoIq9kVA/+Osw2PKqqQ
3lUvXYR0Z4aUYPrgNjuiL+OSRHHRqsCKZtcU0t9Iqvd3dNn3c6Jzmvjl8WWVPn378c+bl+8g
VdN6WOV8WaX+mPWYZr5TaekwmrEYTdNbiQKw6DIVwFkYJX7Lklzy2/kRjUQvSzr5G00aLJOy
OPPBv53RH5JyuObgCc9MZPw+D3W1XqxDtKn4eQzoPHaXvUyGfofuJieMBqviuzPMANVlSq3s
+fHh7RG+lCP+58O7jGH4KCMffpnWpnr8vz8e395vmJKcCiZKbDZZnIvJrTvPJFshQdHTH0/v
D8839QVrHcydLCM2ZCDmMbY85GesEUPPyhq4IG+jk7rgnGq8jSNYUmOITMhjGZhQbMkQN4jQ
cgP4OY2x6dU1HmmevssMGmmqL9TPm9+fnt8fX0WXP7yJ3J4fP7/Dv99v/v0gCTdf9Y//3d6e
4Fo5rnqlpvz42+eHr91a1labvIHKBRCmSpMHJ7RJXp7rNr5YalIAO/IyxM87oJZXfHfvMi8T
hvMr8O2narlZEfbYspH17TXei92YRvg+IcRT5QtMPVXqZt8enl/+gCGDc37sNOvj8lIJOl59
hThFAuOgiwZ44h7dQkhegmlRwGOxXZiKJVpFf/4yzjFnhdl5Qb03dcPR+EuP6HCFqLONdam1
FzFRA7lSCK6po7UXvC+BLPmmdn+OjjGu/TSCIkJmzzPpuq4Vpz6Zw94P/U7dsXRWl3HLolZb
Zv8B3fC3B2Ns/u4eGXGAWH6hlfHNy+/v/3h4fRQf/v70TewBrw9fnl6orKBxLKl4ibsvBfJJ
8JYV/pQI5Iwn/pp6clVsRZg4uBLZmP354Fs84JiOHOwyXRyfRckxSpSpYys5ovll0syO+pAf
jbN35IqkpzBz6++WADuIu0yYOHetaegGe6XR7tEUwApmbdCkVEDsaqZmpaINpm3gl9S1s6gw
ZZ2e5krAHeCpv32zTDCPC8XUsDkySbgk+bSaSr85RKNUD4iNREw/FlfgEDVRghEceC1qAMV8
iI+VYE4v+EbRDWER4WeWIoONRtngXMeACNpfy9jFVA6WFB/FXUr8Md2CZZGrZiM3CtfuKqXM
cHu0NBKJCYtyczbxddkefcz35xQHbbYnjE7PDvaqtSYtaA9PZlxnRnKISg9ZHB31V7Mb8RzC
ksr8wtHM+5VXHZl76V7i/IwsXWWs+rFRUdiqAHd+5Blkb2ZIreCCiOx501UsaIch1k4W/sxB
RRhuEg9fHr6/2xZt4iQFwPQoNW+Olo6EOkFOolBxRw6TNGXgf1pew82798O3z0/Pzw+vfyEW
G+qKXdcsPPUfJZWMFqGwNw8/3l9+Gpjm3/66+XcmUlTCNOd/t2+eIMHxw74rHn6I8/Y/bv4b
Lmgy5rs6gMfi3v4H5Y2XYJmlLEOc559fvmhXgfDh6+Prg+jWb28vrzTjcErWhGvmYZvyCacd
I8DDXO1q5N10MkP6ei5fwnPJCCCUDwfAkhCzjwDi5UgDuNh/ADjvBwKw8lwcfnFZ+FTwzR7h
bwjnuCOAeKIdAcQ7pwZwNUMAtqgH9J68FlW0t0OZup4OvUzHn780gGtuFBfSK9+YA+F6TgO4
W7zeEO5NesDWJ5wQDQBKS2QAzA3sdq4V2+1MDkHgXN4AIHSxesDOD9wTeDfXit3cYO22zmVY
XLxl4NwsLnyzIWLZdFxKvcsWxKu0hiBeNUcE5ZlzQJSUcu+AqGfrUXvOLUMgLou5elxm23Jx
t4VXi+WiDAlnnAqTF0W+8OZQ2TorUtf1oYpYmBGv8zrCVd3q1/Uqd7ZnfbthLpZdAvCXnQGw
isOja0kLyHrP8Ptxd28IXT0R10F865rofB1ulxkemQg/8eWRn4o0zLlRL99eB87uZ7fbpXO3
jK67LeHffgQQTmQHQLDYtpcwQ9tmNEC24PD88PanQ1QVgcaXazhBB55QTxgAm9UGrY5Z+BD6
6v8Htk4xsJAZQxjnsIn8IFiAqvEM72zkYDK/9TmPq55BrX98Ezzv/7zS05w7qyD7YUfR6ogF
vh4PY0LcNiTRE1SPpO6CYIsTs9pfNES2Tegv/ICirRcLoq5NuCJpWbha8WCx7PsYrkGH15dv
7zBC/1/nByiTv70Lvv/h9cvN394e3h+fn5/eH/9+83tXwhsB/QyPMDf/50bMiNfHt/fXJxAq
Tj4Sdf2Ju/MFSH3zt/l8wq5QhMxqLqj5y+v7nzdMbFtPnx++/Xz78vr48O2mHjP+OZSVjuoL
kkfCow9URKLMFv3vD37aC6U11M3Lt+e/bt5h0bz9XKZpD+Vx2D9Q9dvCze9iF5bdOVzJXr5+
ffl2k4hSXn9/+Px487c4Xy983/u7/rilb9PGkp7eaiXm+Prw/c+nz283bz++fxcdql1Ij+Km
W2n26l2CfNk6lmf9VUu5BzkVvPa0laKntoekiq8s1XxCRbq/IfGjzRLYmHhiQNqobNm5afem
UEOjQNyWKCak6gCT4Vl4nB7gzRl7rhOg24y3pzgt5d6mpR/kw67u3mxCLC5xpcTA3mJhFp0W
LGrF2o6g+dmVEbYkXWPCGNOmAmJdW111qViG1lcg0fRjnLXgwqKj/WW3naLBd/wEAj2MysNT
HPUbFZxfj9+kHOFGTN4/H5+/i399/vPpuyZBga8EUAzadrHYmHWEdJ6knv7C3afnTSm36V3Q
2NPAINt3BS2eJ1U3taVUGfpuJPI/RWmICR3llGWpmLIJL1N2b9frthDbOkOro5dmflQxwTzg
b3FAZll0RMWLQMyL8yVm57HzuoQ2jY8svG/Dupnqa/QYS043Bchl9MsaTe6dKf6yHKtrAjLC
QtVEiV3l5G5cC/pJaXI8GSolahbv+5Egu+9yJOJ0SKJYB0ThSiTcT/SwqsPJLOmkxocko+aK
QqxXy6VUzbP2EkXdDiQs8yxpCJ0/DSTYz6lXnVjN/Tcp8tu/Pn3549FalN3XavvF8jWl/lP6
KcoSrEmtsnFXB92P335CLhIa+Ei8BJhdjD+PaRgpuyYceWowHrIU1ZCUS7GPsD1qwPZCeKVk
lTSiUxC/j2GU44ToavWSTpmefuNrW54X1JfpJTK1OMeHAvz9eATcLhebjcyXXhPZ9XjA76xA
Pke4bp/cqjjxVA7b5pEdfdSxjux4+SRwNg8B9QyYZUhq361TiuycafKFl+ZMlangyDaG7cU6
4+Ax0cxEvS92ZRoNGymO01yBoKQ4jyY5b9QssJPh8QZrpyLJnQEj1CHoshalXdG7hh45Fe23
pQ8aCG/71UoAuHRFHNv7BxCr+JhwCEEmls0xyTFj1B4qO+8UhdYQASnC0mx+sUts/SDP2vJ0
T1AXTip8G+w2CxrirVwZeM7stxhRcsv2MCkWmlYfHDGi6x0dW7I8HjzCRk9v358f/ropH749
Pk82Yglt2b5u7xdLcfNdbLa44EsDw6SJKy5Y5JTmcDssP/P202JRg1vSct3m9XK93uFS5vGr
fRG3pwSM+fztjjpgR2h98Rbe9Sy4hnRjd6lCwTCEmG+WETLdPFT6IKFAso3TJGLtbbRc1x7h
ImEEH+KkSfL2Ftz9JZm/Z4SJofHFPTiMPtwvtgt/FSX+hi0X9ImpvkrSBN7tk3S3JFy2Idhk
tyTCuqDgIPDoQ7lDi1MsFfe1+Fcxrwgd9Sm6XGx3nwgNvxH9a5S0aS06JYsXa8ruaYR33gNq
viDeFjSoWFQdWynGdbHbRkQYF23ixCyCfknrW5H/aemtNrhlA/qJqP4p8gIieqY2DTt1hTTa
LYgnFC1/gdsvluu72SkGyONqTURWGnFgypOnwWIVnFLiKUADFxepOiIXO/FeiaI3m60/N/Ya
fLdADXBHbMbyWrBtWcoOi/X2Gq89fB0XaZLFTSsufvDP/CzWKe6zTPukSjhELT61RQ1OJ3Zz
9S54BP+L1V/762DbrpdErIPxE/En40WehO3l0niLw2K5ymcnO2HA6eynit1Hidg/q2yz9XZE
J2mgwJ+vRpHvi7bai0UaES8+08nN6pwtlyBm/eAH0X67+nDufBN5m+jj6Hh5IvSFUfRm+eui
IcKaEB9k/0JlgoAtWvFztfbjA/EqiH/I2IeLKQ4i71l0nNwW7Wp5vRw8mk/psNJaLr0T077y
eDNfb4Xni+X2so2uH8evlrWXxvP4pBYzU+wJvN5uUcNcCrvEV4UBCna0XLKDgxkiC5uVv2K3
hKHBBLzerNktLclQ4Doq2joVy+3KT7NLoi4FOFr4QS22sLk+68CrZVbH7EPg8uihHkg0WHVO
7ztucNte75rjhBlWwEvCkyIvGth2dv5u7pi8JlEM113eXrlPhQca4WKjL2Mx8ZuyXKzXoW+7
8xjsKgwWWm/Ovkoi6UNnypn2FIMLHwX6o1zGqFgY5VIuQ9YcmlfkcZuE+YYKJ6RwYmKCxyIQ
vjq4094pLcub7SbAnCcBqmeKRJLgBcD3kMErp6IoOBzSOth5/p4i7jae56Kdm3Ai761FU+vN
hnJ8IzMRvDto2RLK+PIyBkJROTF4HZUNOHo9xu0+WC8uy/ZwJVqdX9NRUmNVDITQZZ0vV8TD
sJoJIOFtSx5sTF4cx6wWEwlDAltMElhBpA1Eslv4EzE5JFvRHA2qdMbYTVHzSeGUiMlVn8LN
UnSrJ+4dk1tqwU/JninPb1TY5f+XsmvrbhtH0n/FT/s2uyJ1o2dPP0AkJSHmLQQpy3nRcSfq
7px14l47OTP97wcFkBIIVAHqh05bqI+4o6pwqSoESCvSFhB/74UA8UcCLpB4j6CAUkvaNlQk
+AEhqtVSzgDUkaYFcTagUECTRbGYEe5X1OnZeMIoF+FqTvixsIHrBPVwPYFlzlHQJIdVjMUK
UcsuBq/eh/XSXrAG4cT6TPl6IshpntqnQ4q7lfusSZYLSndHD76GxBPbb4ZiUTKPhY8MNbIJ
k/VtMXyXW0/aWsoOToV1bHBInRUjk0KnhLlUfQ/8MM1qSHQD7ABRBVSSk7y0mqTSH3jLK+vU
bnjRj6ciXV4ehXWgdRTbjf25qJ1y4JH/dRCns69Nmx1+N6SkaS33K7Sk4m3bi9PHnLhdAsyu
jOJ+7tlAaNYn/0IR4ORGdeIxmS/X+FHLiIGDkJjwsGxiqJMVE7MgXGSOmJJLZW3+kQjXMYDa
vGENcWU0YqSaugyUBZrsfEndkzRy/+/sECF2xFapGxV1XCe32Mw5X5PfiM7lmBnhHUUNcE+W
oO49bY7TZZ4bjTYiTBRVn+/oPf2B0zTBDmyH+RSenB6A5bKy+f3Y8/ZBjHri9u352/nu15+/
/XZ+G+L8GFd3280pLbNCSujrypRpyuXBk5lk9sL4GEE9TUCqBZnK/7a8KFrtmmBKSOvmSX7O
HIIc0V2+Kfj0E/Ek8LyAgOYFBDOva81lreo257vqJCcWZ9gpxlgiWPSZmWb5Nm/bPDuZEkqm
l1JNHF43CKssOM+GKnTWybo7MH88v33RtpLu9SZ0jmJU6ASR1KbEVSZJYm2ZWs8PTLIUOBQp
fdrkbUydhULWUpWUPYhzEJW36LDnMpKUb7nVUxBBC6wuyTaKKFPRFCj6EDWNoLb8QNI49Yod
xpbJzThZpuexBfRP90QxA00lm4pvrYDiMIIJlTCThN7Ja7kcOL6bkfSHpxY/n5S0OcXvJO1Q
11ld49IIyJ3cZ5Ct6eRmIafnD2txRzJqwpOZpnLGc8LJEPTRXq7XjVyWJzLeC6BKkfZ0q6lr
a5hMGylQjt2CskOWENdeddJl2k0usm6USFQvxkbBaK2hMoeTo7okG19u5HCgKj4Qj3MrP63Y
kH0k5IIkwkWoLlzbdgTj82VMIOlQk8+f/+/l6+9//Lj7rztgWoPzluvTwksBcLCuXTtoR1RI
ky4PfSbASeilC+Khy+Ilthe7QsDL4jfsWx25rCDspa84loGDTnxWWCjC7OaKgsfh8xnO0SwU
FlvGgMht0/KINwy8NYVKOCzj2brAjx2vsE22ioiZYrS8TY9phXNTo0S7n8cwoP6pc3mDCm/r
LYE9kIb3McNb2e/vry9SGA+7tsE403njmvVlqU6wRF2YR3Zmsvx/0ZeV+CWZ4fS2fhS/xJeH
cduWlfmm30plw80ZIcqJ3UnF6NS0UuNpJ9oqhlYvmzgltdDsB7WnYw85vFVF+z/QY2P9i3o3
ceUMv0/qgkyyZeKKzMAcdgy9oDMgadF3cbz4xYjk6rxRHj8TdV8Z4TyF9UNF9GynSY0ZumNI
OOVF5ibyPL1fJtP0rGR5tYPjMCcfyUW0L/l6u4Vnv1Pqh8mzojFl8GtjebUBai0EvDlGumqs
3ti2yWdDDFLiM8fvkEGDR91S9Gbil3lspo9ezOoiG3w1mfVo6/S0tXI6QNAdkSviVtg1vFJ5
RfjRU1UlPNarLEomOrftAjxKVSndetdlg0qGtUzWg4FLPJJadg3D73d0hcD33amPVkvilYHK
o+kX6LWTHmhu15dlUUL4/NYVFnNCddFkvlwQhqeK3nFOOJ64ktWOCT8tUaA+SYjT05FMnMaM
ZOK2SpEf8a2Son3q5nNCYwf6pkuIiDVqAbNZNMPPQRS55Fa4yumCPT7tcpwpq6/FIk7obpfk
FbE1UuTuuKWLzlhbME+PSn7lIxfsyfu5zh4/qr9kT5N19jRdig1cD1JEYkcItDzd13P8thnI
vMr4DhdIVzKhIF0B2YdgDvSwjVnQCMnjo9kDPS8GuieDSkRzQt280j0FiOh+Tq8YIBN3KkDe
lpSvbiWMMkFzEiDSLEQq+pGz/bDpnkmlArMkR7pfRgBdhYe63UWxpw5FXdCTsziuFqsFcRqi
5W0u5G4P3wbrqX9ktmdMg1yVMWGar+XGcY+f+gK15U0n9WiaXuaE+fdAJZ5rXqiEF3QtFIkY
B4oIT5sOfOPpN9+Zg1IOOEtiDysd6AERpjbxtaC5w+EYE08pgfpUbrHQxvvsHwy8rVz3H3ol
TB46DEl6hhJqAdCd58IjYf+Y5b51x05trhO8IK2abvJAXg0EWFZ2bsQ1wwhUl/GyaIhcTOt9
V6S+lbwBKPiuZFZfEVDrjB7F2HdUU6rnHNcCimQxo9U0A1hX+ZE6hbWgUkPxKFZToGcFG0B1
2XdTJ89nS5rfAlCqP1LhxW4zL3OlfgQDb4isNdqLza67vMvqcMfFdOY3pkpNdleB09zSPM6/
flPCk5iqc0kNzMGihjZ9yn9ZLSa7HXuH04uNrYArP4c9FcN2RPQs8ohGQKSMs49exApsZr2I
Pd9SnryUwptm5AXAmEVT4wdfBn3vR3Syo10vzhbowORmCDu51Hw/nXa7TBjnk2/PDbBx3+1s
B2t4dkBrzYpeQoRv33anVI/uqEm9Scs4mS9VXjwWNtuQ5NVcxY8Wp8c9F13h4ZFZLhlZpW7l
JN6RHeI1vVPLQxmGb9/O5/fPzy/nu7Tp3y0L8St0cPmLfPLPqQwSah8PxhltOl1qI0UwhyuO
pPIj6vvNzLaXTPVIZGzaOk0ITaacwiGkXNcGqwtPt7wgvhpahzbimBKucq12xHsiMICJa5tS
UKcXaq6Af8e0hKntVhWI0GG91WGQLuqLb7jrKA+nYtYof/3v8nj36+vz2xc12E49IbtcJNZ+
GQGJXVdMPVlMqPQoMbU8WZvRbeRHbDyASlolmiCnn1FU6kSAHiSOd01Z+wW5hPd8FUcze3VO
Nw28fXis68zmGUi9AvVW7zQf8rzcEObMI7Ls4rVH0mjIak3E9b5Ckogw+TAhSQjycNp06UHQ
AmPM6d6zRRghS4cLMhgyc76zby+vv3/9fPfny/MP+fvb+5Sv6ZdHjPfTKTgkH+ElxLYmaW2W
tRSxq33ErIRnClIt7XIvSDnjBBHuAZmvthxi3XcUVR2OI+vPQMDa9eUAdLr4JisxEpR46jte
CJSq1Mld0aNN3h0D1ZZbcrn1qZnKxgMA9tEhEmeI7XI/i5bm674b5pWdE1wbuvkXDVxVSgZC
kUY3CxSdNR+TWbTC2KLo6hazWLxoM/rTk9ggMlx7dVaO3hFiJppVkGpr4Vca2/pIpwyT1ldy
KpXxB0Ei7Fl2JbVy7vJqR34pyC8ZGOKStUKmjYB4WghBZGWivFTa6WUSL2foKKbrCI12OAJc
twM2BdM1J3S5Mm8o4CK76YxKdrwn4hc62LazHXZeIA9Sy0iG17rOtt4Fz+/vT7u2H6733L7V
tkmOwj+YLDW2EzgEo1oeRPkkvVERiMP44Iu4huIDVVBz6JKtv1GArWrcxHQE1Flbc79YZm2V
MeK9iN0EuZvLxd9pc8nB4PaxjJKpgYpHl23P38/vz+9Afcc0WLFfSD0T8/F+mUtSjCDL6JPJ
+m8oGym63oJThSI/eM6dFLCZ6p66uV359fPbq3LW9vb6HW62ZdI8vgOt8dmsi+nG6298pXWl
l5d/ff0O/vmcJjq9qf3lk+YyAyb5G5jQ+Z2ELmc01qmcZnlO8pWFjZLc02p7IqBHqBdCPDux
NKA2j0A5t2/ChTjKiAszB4Wcyyrue9zNiw20ikYLjnR+7pK5kDNw5kOT3VEaqVGyOknZ+uD5
WEp6hu0ltX8LdeQmxQJr9qN2iLdVCyL60OsKlOxrTTj5dID3hB2vDbz3XVtdgV3LS1Fwz9md
0fIiXVIRU6dITFx7Oml9w+S+bP/dvZjDNLvzvyXL5N/ff7z9/Hb+/uPCurWvUIcqNTDze/SY
ImMHXqX8VKZseptI1EGfeNz96+uPP+j6OKV8WMdRfsoPuPvYm1vqZjxGhPV2tH5QGmQOA0wv
hMv28pZPwuzk2G2bHQswCWXJVY2n5EM/gjxw4iSMXzyWJ8lPUGUVeGtInKgjXNZH87UKvXcb
UDSBQ18Aho5MNGgV3VYsAG8pdj0j3G9MQFEkdWW/NnfBBav3sIgIfyUmJKLv+AfIgvCgbkCW
S8y41ACsojk6EyRlEeiXh+WcsFEyIMtQHYGREs/ZR8wmi8kn7xdMJ3dxtaetowH1eErh5JCK
+bIIsHSN8ddEY/zjqzG4UdoU4+9geMJUBMZJYZbhVaNxt+R1Q50C55aACXbRIibiGJgQzzub
C+S2tq/D/AJgx2N4hUvcPPI8mBsxhMnhBELfV2vIcl6ESjrGMypuxVWkS2mLPdafAO5dRRBX
PrUZrXseCLRcrKP5Ak2PFxG2MuFKJPJPOn1rEhyYAWaNswXaQURDtCJcjUiARyjHkODHMbB2
tWKIunKYQObLNbohUsRlQJAo0NRUH0Pcx2uyiPl6HuzXC1BkfiGpgQFtWFfad8Clzv6i1ekx
zYaNKnE+OGCG+MpYG5u0jFaeZ6AjZp3cB7tB4e6PN+NC/AZwyeq2/AB3Q37z2Wp2S34K518n
gJJdh1yXjpQhbhaav6LfUOFlNCO8jU1A8b9vaZXChQqF007Pi2UNSSLfomoLqa+gLKTtpGBI
gusEYHBtkGE+T66g5TJCOKlOV1sCtAbLVYCbAoQIemNC0PhREwByCg/pS0SQQPoK1UWBksQ3
dJlU5W9BRdHNqJTdBF3ejHIztID0zf7gDYbJf/mW23eYBsJ5paBo1L2CEGU8n/kVLcAsA/sR
wKxm4a3eiAutVolbLAknMxdMx+YBxQYgHksPDeEnETosZCJeBpRjhSEc7ZgYysfOBBPQayVm
OUswsy0TsY7QtxyK5LEuGDByAxioqFQKF0Q8vgtmy+6T9Q2Ye/84dsVhHs8YT+OwNmJiQ9Px
giWjXLvI+Li4vQ4KfXstwsLexN6Yb5Yeo9Dpq5izOF4Hzj6F3gGFQZ53qYDpMxZRgRpHjNTb
7q1YjS7iVG72yB5DfbtAJ78iJccgx34sE8orqgkJHEsoSKCdEkLEcjQga8KHnAkJKC0ACUh1
BfHzXIAE9q3qDD/cosAxP0ACXFBB/KoMQIhohwYkmYVX9AALLTn3XgIDIFobpK8Qua/SY3Qq
S8rad76nAAn1aeJdW+oaGamNYEmCi5VPxTyZEcb45tZuTYQ2vWC61dxjDnmB+Ge7gtxQ0P2J
pWmW0y+lB+Qq0LKK9cmccB5nYpYBRlwFTDUvGI+tyxUTEOANW8ntyNR/roXRT6DksMuxS9va
nREacLjSnWI0oj1qhLdGGtqh0NEqfnK9MamN1n+px24GeUoIXWNSfrMmIB2gwSRr+yKeuS4O
ZKL5Ukb+PG3UxdGTVEbbvNp1e7QcCWwZLrb6Peo1CrIeHu1f4r38ef4Mcc/gA+eSCPBsAR6z
7QrKVdIrT9VUzSSi7TFrAkVrmiJ3soREjt+WKbogzHoUsQebEaK4TV488Mrp47yrm9MWv3VT
AL7bwFhviWzTPbjsNtxbqDQufz3ZZaV1K5inbWnd7xhNltOfFQX+yhjoTVtn/CF/ovvHY0ak
yLL3On7IT2IzW6IbeYV6cuw4IFnOwl1dgW91Mv+8FL6ezguGG2ZrYp7W+NsqTcbueRTlk+wS
u7K7vNxw+7W5Sd8SXgYVsahbXnum4b4mbefU93W9kzxnz8qSuBYG1IEfWEHYxahculUypz+X
jfavzIcneqD6FByN4qoP0B9Z0RHuFnTV80dlIkpX/qmlnaMAgKcsw5wNKVrncI0PbNPS87p7
5NUedUGne6oSXLLX2uENRaos4ch8KV9EmlbVB2pOQu9i/HRMhx8N3r8XCLGQgN725abIG5bF
PtTufjHz0R/3eV54F6zydFbKlUDPpFLOlNYzziV72hYMDSYH5DbXbGXKXksOF7f1trOSQRq3
ucWLy77ouFoKpggHStXRq6vqWsLuFqh161vfDavA7avkEvT0aPJKdlyFa5ga0LHiiXBfpgBS
xFAOBxVdclPl4J4IRT1gnoTHTZGWKhDOhyS34AuNsFFX9DpNGd1MKQ99XTm8SqXpeen/Xkph
mtjkOXjk9Hze5YyWA5IqF0gOL2xpTF81hUdUtIT1lGKSEP2DCY/AFiVruw/1k7cIKdFx/VoR
60bkHjYGPsV3dBd0+7YXnfbzQ0sTUFBPDeFtUSHi7aec2AVoeeOT/Y+cl3VHT8Ejl2uNpELB
3v779JTBvoNeIUIKkLo9UQ88lWJaNHQBZdrEse0jf3xMjCjmSmPvxQbfR2hzY2cv0RCPyge4
E5d3KN8u5hJAFi0bHp5prb8xbDbG1Hpy13BNBYUo40e0fLsoO8/B2uVqnI5goYn1PuUncBAr
FS/tkPYqJYDuhFtVlt/a0OavaW8VufJugT2DVgblRcNVEGQrq6pSjv6myawFYc/EaZ9mE8oU
ZrmXUl9WlZQfaX6q8sfB5aJrjFx+ff98fnl5/n5+/fmuxnKwNJ5Ol8HI/wR++rjo7KK2sgRe
8U7xeorZqXwmfsuI/qm7nV2ATFKblz7tCk5EoxxxGRdsA4N4lCynYgW57MYPtgLnHMNQCjWW
u7yFBNs63uxvudGVW08pt8EEHKIIx9O8yimHuC7S1/cf4LVvDPyduX6H1QRZrY+zGcwDogJH
mMF6mkw+VOnZZpcyLO7rBQFT6BuWKke1ygUTGHW0gcOKBDv5ja/EsntAPywP+QYLWHkBKGuQ
v5xkbQUwSc8hfdOmpazKtP5oYn7tQju1resOptKp6xBq18Ey00G0XSqyOlX6VmBHEWZFwJu4
y2DyS2t9nw+hjt3qQL7UyNXHPo5m+8aeZxMQF00UrY5ezFYuLbAF8GGk2jhfxJFnTtfogNSX
VqQcoWANr0MN7wcAWVlRJJFT1QmiTdhqBTGP6PYMSwn+3mue/s2StLKKENxeuTW6JZPRiwBw
Eu3C9y59eX5/d0/pFJNKS7tE5b+RUM6A/pjR7LGbxm9WFamkpvXPO9VjXd2Ck+wv5z+l8H2/
A48WqeB3v/78cbcpHkAonUR29+35r9Gy4Pnl/fXu1/Pd9/P5y/nL/8pMz5Oc9ueXP9Wz/W+v
b+e7r99/e502b8DZYzske6KvmiifZ6NJbqxjW0bLlhG3lVo6pZ2aOC4yKvaeCZN/E9slEyWy
rCW8FtmwJX79YMI+9GUj9nW4WFawPsO3IyasrnL67MkEPrC2DGc3HDie5ICk4fGQq+fUb1Yx
cdmoff64qhIsMP7t+fev338ffBo7IrrM0sQzgupUwjOzIOB4TfgJUhoABNgZ9FCCNZRdP7dn
P6Sd9rVHbVKIHct2uS/fU9YzCP5YOOtLUwlHrwqgWFvWps6XiuCtG/zjr5vSLI26qWFpBnv/
u93Lz/Nd8fzX+W3KK0qt1VdHRzYryhg8x1WZFaeVs/Lb65ezOQPUZ1KBl7N7egZvKsCPqTM+
kKY2BbTaDAhvLymEt5cUItBLWvO8E9iOUX2PSVZFcASxrjJrMDDcQICrKYR0df2AEOVGcIjY
7NKUEwc3mZfHpGwQgrancggxMjix0/Wq63bPX34///if7Ofzyz/ewOE2zIe7t/P///z6dtZ7
KQ252Jv9ULLt/P3515fzF5t3qILk/oo3+7xFr6guKHId6jwI37bXz71SUEG6Fnxal1yIHI7I
ttRWDdwF8Cy3BmtMPfVZSlCgRwmSM5UuFAhWj1PkMBOU6zUmRkV2DKDbrlczNNHVRDUhGlrq
KMnqG9lUNVpedRqQev06WATprGOYbWqOoVqf9l9tK36DV2vE2x8G84SgMFCMy73Z5gZc+zCP
iPfEBkzfyIZQ6Z6yiTFAj3ve5fvcpzppILz6h3vrvHB84SFFN3KPcyR6dlRLSvzNiYHMyyan
ZOcA2XYZl4NQE2UduKhpHX4A8YbwU2higrnkcpaSXgIR3Im4RTEbl0QxYSAzRS3n+EWDOZ9V
2JlwVxAvIgxIj4eiMyAgyRpWnRqfzjuBBmEFER7WxEDYnJNIgyNQpt2pv6FjVbiaIKgWa+r9
rwVLiNdKJuzY3zKHKnYow53WFPGcsOo3UHXHVwnx/suAfUxZH5xkHyUDhsPfINds0iY5ejZY
A4xtgyxT8Lxt2SNvJWMiYuiZ6KdyU+MeTQxUeGWq2GMQ4cLPnR4fWTU9Shs7vYG7Q4Jp1WXF
K+IRnZVHSlyvGLAjXLPIvUhQEnCx39REYCqzC0Uf+fbjw0zogsurb7J1sp2tCYtLswlB5uso
bxfxPz3KR4LXQS55yQlbg4Ea0zKZZX3nXRkH8R/Krqy5bSRJv++vUMxTT8T2GgcJgg/9AIAg
iRUKhFAgCfsF4ZHZbkXLlkOWY8b767eyCkdVIROko8MtKfND1n3mUSm9r8zT3aEmjSUkYuZq
rV9Kk/erJKBHevJePqdK77Q2tDEC8OUiS1oZyUoA67PuwWwUJAEt22btNuJ1so8q4pk4WWcZ
Fz9OxGOUslLoOhGb9CJJT1lcRfXM2p8dzlFVZTMIuG+k+8Seiz2pvJLcZk19nLmfyDg8DLWl
F9b34mu6A6UfZBM0dP+E63fx01u6DaVY2PMsgV/8pTM5aPe8RUD4v8oKz4p7eOoirebrRbTs
gYtFHckHqBZadRlQsKjU9+jlXz+/Pz1+fFYXEvhuvdxrBirFoZTEJkmzk10gUBe2p5hQTfcH
Bp+IkAF81nBIj6hMFTfGyA+Q4a5iSpFGXZ2K1NAOE2XWv1cnn0nx1Hlo/ryqg+Bt0hntowml
zrQdCqoVTBbPf3gIt79LLI6sVa90cUPdNyyf6ukudMIuL69P3/66vIqaGbV/9oTdq1GOxBOJ
Mk/VLLtXS9ykkoCD7BeC7U9UB03kEe/wyM51ms0XsH1KUcILdRlqKeEFVYiUSpzJrR0UErNJ
B2a8SbAzesQ2y6UfzOVS7E88b0XPSZJPeOLIxjnc08eIdOc59BTT9bWZVypluaUSbdJDJsO4
UU1rXvbI5+8mOi198KKdVJeeZ7GM0c/B6tLoOttO3aRPFONdhEFNYd22v8ag2/YQp41NK+x0
tm2KkNIJiR9jsbzZ1KoQK7xNZOBj0CuYLN7WQqtfKWpfMNv+QzGjxL7l6jmy5DirID9K5zh9
+XGAqgbi45QSa9STNd4G0LbN4d1S6lpxhJnvzlnMY5TQS5uF654QvxFOj3cNxzLC+trC7Wcs
q/RkT/QspMEQfe2wpHQXzt9eL48vX769fL98unt8+frn0+cfrx97sx5DLmlUJ2dH8m0MOXcR
7iZy5oIOeWVe29IL9fZYJHBsnIHovWwmG2qk0VJECyJqE0vINQ15slGPV8gpcEaOGNktm9me
KEvkGf5cR9qBiQ9uEa7Y5zROCFtVuc5HZ7QmtLXgeu/qB3H9vtSD+Mg/2zopGUJLjHgTilzV
7sp18f6lfQhrX4YFSFaYLexZHG8q/pigwWY7ySUXG4mwsbO63/ic+57nTOXxWqTkBg6+SCuM
DNtdsmxqMAFVW//8dvk9uWM/nt+evj1f/nN5fbe5aH/d8X8/vT3+hYV9VeLZsRHHDV+WeGnf
+Glt+KsJ2TmMnt8ur18/vl3uGKi7kGsGlZ9N2UZ5bRuxYFkhJBp7UHj9lp+zWjpEdAzGNK1O
ea54+tCmijjkpSPzTbgKsf1vz7e0ikJKG0Msc4TUv7nqa9t9Dp6AR+qRN/jUPkoqTTJL3vHN
O/j6FiNAkEMp2YEXVUz8yMw8y263YblJleGGIeS5XoeSsdnbEiSpFQUEnQjnB/Ph1RFh6R0n
fGnyi0gu83rLMMZB7B+riEcFnh6wpYE+Wekjrl5j77IamBR+I1PanBPG99gGe4SBQ1KRpFhR
pHBTSzkyeyUkkjL38S2BVntNdML8xkfEFn76Dp4Ay/I4jY6Ylktre3gA2Mx5/8iDLVXR4TUZ
a+swTZmzyccNXdo627KWY6dFKbLMiAq0onbrEpno0+YRs/sOkyVEvefwzM9MH8jUKyBgcwxA
U24fP9aWncQrwm8buKcsUsOUSHVzNlPZnIfxZM4bZzF7HdNtluZUfQiIbd7RkfeZv1qHyclz
nAnv3keSoqcCwRxeRbAreQ8/iOi2si6OMfUgsqxga3xaTNE8gVhHMJ9VmXpnCKS3zMM+mXSF
Pcc1qLJHHfg+i6OZ4nfPjFljqb7HpoXeQBlhNWlxoGZFhlp5a9MwC5YLU+jhnBvCUpFuhmp8
wJUATOLH76WBfJJHprvvSG0nznsYSG58k0NOXFJLZFzB7XIBWoD9Ga5fi106jcgPHpfIpkRK
iAqxG1yu8ct2hTh7jourF1Qe4B04ImDKCCB0jKq8leO4C9fFL6AlJM3dpef41HN/EpMzf0mo
k0Y+fojt+VakXpu79gyzBkmH0BcettpIbplEa5Ho5KuOLm+rqW87xxcrk6W/XsxUFPCJ6Fod
f+kQYYd6/rJpOieeOVgYEmE8xvItZ9IBQEAYLkjAJkpcb8EdNLaKEnFmk+qp0t0xJ1U/qjtu
vJAIVK2KVvvL9Ux/r5MoWDp4aB8FyJPlmoqBNfTE5X9ofsZ9d5v7LhHJS8dYMaSs8a6Cxj8/
ff37N/ef8oBR7eK7zgP7x9dPcLaZ+srd/TY6Mf5zMmPEoA3CDpiSK3YEiTkPq1GSNxWhCJX8
IyfuEpRQcA57T9wjqDrPRKUekW4rs799/vj9r7uP4phVv7yKg5w5IQ51Vr8+ff5sqJ50Vyd7
gu89oOqMmTsYg3sQk7NlJI7BNhm/J2WwGtufGJB9Kk5aYtdak0LiKLnPYbW4Jgqe96KEREmd
nbIavzE0kHMT21DozoNO9hfZCk/f3sAQ9Pvdm2qKsZsWl7c/n+BU3F2v3P0GLfb28fXz5W3a
R4e2qaKCZ9SL2maxI9GMmO+QgSqjIkvI6inSeuISikuBEDUz0+tQ3+Rto1lMokXU6TSLs5xq
s0z8vxD7swLrYamYg6c+nkA1/+qukWHsm1fTkkkdzyVzt0+nX0grLeoLqYbmSVSm+qIqWfX+
WGzSCp80O8l1SoS8UIUVe/2SE7FgJKIB01CavWHJ0sP201WdgFZorDgg9HtEjbRPxI75PU7s
PFb/+Mfr26PzDx3AwXh8n5hfdUTrqyG/AKHaBnjFiUl9hhxcgnD39FUMvz8/Kh8PDSgOeNuh
7W26eUweyCJPerPr9PaYpW0qdr9oLctcVyf88gj8niGnyGa3/y6K4+WHlPCqH0Hp4QPuKDRC
mtDBYjT1gMlRpWdsuOs7RpBwk9MmYr46Vvh41aErfBuoQYIVtp3tAfv3LFyagYJ7FouaYO1Q
/bhDrFZBGEzLV92HTogJrfgy8QmtcY/JeO56Dn5WMDFE0DYLhFtu9aBGQHA7xB5RJlsyMqWB
cQLsDGBAfLyuJY+w3zIw4VwKbOHWoYO2peS05w2+CA799cH3cC+sHsHF8Wnt4LNnj9ky8rmG
oRuIgePOdS0BWIYu2oPEp958g6VMnGexa+1BxkkA8P4pOP7cgKlOYej4ow5kqJglsyczSd6I
0RxOJikIe3llkoImI44gBuTqBOATBx0DMl+hAFnM50VC8AORDiHeKjDmHML9YWiBNfW00dhF
FkviDQJjHlrMzzFqApyvPDEoPffK3MCScrXGTrByxZu+OAWdA84p05VsUqG+53vY6gL0dn9m
evwnM8vo4iPHxZpQ8o+1G7jm2DU95q70a9ELPOKhIw2yJAL06hAi4q2+9oXLdhuxjAj9pyFX
xLM/I8RbmMaR9pyzzdDxX9+7qzq60tEWYX2lSgBCvHCkQ4gQrQOEs8C7UtL4YUFdjQw9oFwm
V4YgdKT5of7hffHAsCvZHtA9MdWPipevv4tT6bXelbFmg10yD2sTB48hBv7Y+gvVQwVJNc1J
/Dny9hHEdfRB+Z5MR5NgoO2OX+0OYzB3/LnlD/guktixCNBuxk4zwsBVfBP5YYN92Snn5hf0
Wvw2v16XLGyaZlqhEx3ekGNCp6Xx29PcQsyLE5+ml4GKLUG3QLVnPVw5AQT+Gp0WWb0KvLlP
5YEQK2W1soyMhyi2/PL1O7zCO9+dd4d8s83QIH8b0agqeJGe8EglPCLAQXszeOn3dwTizJtA
nOC0kCGCQIlQpPnEtEB8LCC7THdRBhpE6z1Kh0P5HTe5poIbKIetnmd1IBeT025DxDSIGGiP
cifEj/VRk1EayBhs+cTHVZRpYYohDxOVExDVANO6wOY8Jx1mk1Tw9NIA7YEqyD7jUhh+DyP6
rsXTONxKB1SqOThuRAG2Lt37rfqg+5uJXnqo7L/FEDM0XA0ncsAav83kpaBJaLPqgf+x6KmH
c24mW+a+77RW1st8UtCBB4ppIg/Dm8VlbCZivK9rmPJ2uuWW2Q04hTQkRI5uMsPdA6RX2Gq1
uxVVUjhW37d7PsdNyL4HXLDFEfWH1680iYkjZjeXpO/KScfV2XvoiC3bMe2ScGQYM9R5Mpps
HumqD6p4qngdD74lnt3YtkTBe1N+o1NBLC3LXEEz+Veccfn5YEHrDEbg0eymA63d5cdU3WLa
7JJnuT2dbMoo8iaTyjCdJ89P8ECvvn4MEzpZWyyyb88mc7yaNH8OCcXH7TQKnkwI3Ev0TPOz
pOMDrpNE5EqwWnYQO67iUGdbfN/ewWj/lw7A03wLpcSvcjvQPo2ICJO9FLjVhJePbDmdyZ5V
M1ojHJs5h7gjqhw5bfVIh/BXmx0YO0rzQdfiiHX3YWvEtZPk4iA/IaTL0HWmfc9AZsotyyaL
taaZkifp9iHE0OJKBKNUI5ILfZ3hvQZ2GGJHlJ1SNDyiei5Ay6L8W+bduHDv6CwtjhgYFyAV
GxNWHOX5wdRydpysKFHDsT5xZqr0NXKbMAirm2JhKUe8mA4w6TKeRleyESyplC+x4sJBi3ex
PRFvgC4e5uPry/eXP9/u9j+/XV5/P919/nH5/obZ3e5FR63wmKjXpEgxzeVrr7mehEmFtyPG
iteIPKmOcVtGO7nxlSpFEwBKhfQkdrPWh6ASFUU3iLoSAzBgwx7VGAcUMqq8EGbC5Il/4CrX
P3VhMndFrdQfOq2KilpmFEpoHCs1NmyogY10AbFdP9R5DGhTMnRjXh/jCVVGmgPGFzOt8gQP
JvD5dzp0YFeNSKYkSgxc0bXN5NWNiUaAQKFtI+YQtZZ0fQbpDmMWdlX6nnLzFK2WoncBYioX
y5sRS1VkkDMPFnbiUJqH7trD/dUEU8wx5Hcrz4/xDFahOJASMkM3DFMqPb6k1COnOgiIsHWS
FUwGdiZWoe9vXfQ20xwieny8PF9eX75c3qzjaSTWNTfwiNASHdeOddG1pyVVpfT14/PLZ4gD
9enp89Pbx2dQ8IusTNNdhcTtsGBNvA37FOek6+n37H89/f7p6fXyCAs6mZN6NXlF2UzvmjQl
7uO3j48C9vXxclPxVws8zety1C5OZkT8UGz+8+vbX5fvT1Yq65AwkZOsBZoBUrKKfXl5+/fL
69+yan7+3+X1v++yL98un2R2E6Ksy7X9NHyX1I3Cuj78Jvq0+PLy+vnnnexz0NOzxEwrXYX2
G3tDd6UEKJ345fvLM8xNNzSex13PNmnuUrkmZgjqjYxW7awQt5xRb8VJ1zRGWKSx7aYtTim6
qKjZUsX903dBm/TQ7uVLCeM5SKeqGHP4F7qxs8GGmw6VUhe+9el/WLN8F7xbvQvv2OXT08c7
/uNfWpxJ++tVm/BMj2s+L0DfhoGE7gJ4k1LbUAD1mb+Gk7bTKF95Hp+I1x/U1x8OFRFvQ/En
cY7Hg8spbqPTCtPSRF8/vb48qSB7w3SlSNrxrWvy+BARD3HkddruNmzlLfD+tBNbh3IXxQcq
NGqRia0TL4k3m5QJX5vk92I/UDTwy/kDkRXR6estnso9X+G31nArKCuxOwYNX3SXgu1JNC9u
zw6Pk3WombaZQ5TZwp7Y+k1QlsNto6i7bItbfEk/BRmAgThHPeSE2+d5S7QUfcOc7CuxhRpO
dcY9s+IdeFvHqJnWqLwxCfINc11OR65KxjEjpJ7P9SvknlhWh/owkXYfy/eFZo0dewkQhgb2
4V9shvww1qOp95xTjJRKXkXoh4Mh3/KFi72+9R5YprVUT7ZcRCVZzN3lprsRMT0S8jwqDg16
8u477LHaRgnRjD3Tb+NjXRPG3iNIPurUHsoq3VEP3/TgXUncwnX8/aEuc+L6ZshydbgpY9FO
nAN2tsV3fxwF9Z2YQMaa7ilCfipmIO0eZJx3+muv5Pnl8W/dkDoSlVxd/ry8XmC78UlscT6b
3uNZQgTHgRR5GaITEvBOaaNiOR14oh+AbsyCNjmze2dBbeG0qbU337oBt16gJvgaSFl8ITXZ
7jNxJGlQFk9YRjBMxzWdlS2pqJYWinj11EQRDicmiHC2MEHE67oaKNkk6cq5Wt8AW3tX6jvh
nuM4bVKi9SfV3HnamNOmyecRUfceK7nrEtUP2jDxc5dij8IB4OFQZQ+aYEHKuet4IWjw8k22
QxPtNahTjvLwmNJPyRKlx5uVGzaGj45e8KwRSwPctRHZj2SABW4WANRafKl7+Q3UFUpd21TY
EIgNmdialVOGoYbUMmv5l3bwtuDelMgrk1ZFvIzhfU39PSFjVIrxESQn38ipxV+TrOU6onhB
QEoMViRr6khpTiEQX0BTxEDsNVCmjjS4xkLBGsPMG5gYGAtDRxCzz9GsTHmSYQitQGglQnuY
0h4aDVhnItGsy814ShiosBTG8GLCgbVmHDkNKr1uZhcvef6pL3/f8ZdkPDvpU30X3B1tBWVB
QcwLiilGH2k6PwVnbHc7+H/LnTht3Y5n212yxfcXCJjdLvj0S9k4pYWNxrDBKliSNQtM5QZy
U7oSnkS3FUmCd0l6O/jGupLYW1tYgk/yLepfyMj2F4SzrMyc6Bfx8a/h3V+U7/6ifO8X5Xu2
fBy9Ws/0vNX69gYX2NsbHMDlrd1OgG/v0AJ88xhV6OkYnauOGycWCRaj9qY2WK9m2mC9ur0N
BPb2NhDgX6gpQN82m4G5HFkeYEKQrJtSleB9tr0dfFuNh26wIhY5YHVS5hCqlucQqqPMItgV
EV3rkJCVP8O6Ij6kvw39YbmZw6ghOYe4UkmhsiGDWzh842eB3GugaJNfl1MUc5grrRZer9ar
rQYQNZBIyJoeP8BEevkM+NapU4JvnT06cNlmWdKeqwgPsYZ8cuOkL8Hsxu2kAt84MSvwL1QJ
40Qc1CmUJ6XohPzWyrh59lXo22bfUBzs6N4jmGjvoW6bjDODdqzoH++RN1Jfnl8+Pz3efet8
QL4ThwvQrVTpzjAymgDgDZdNdppBsDInhrlkl/uIp+iht+PPfs3hV0ifFnCSD4Dn7XwuowP8
kcwg0vQaIhET1uZ9QSW0a+IYZUQNPoMJuprZ0dJ1z0tZfWG+oXsxysmgjUqR53af5qVu2tgx
/VXTmCfu4avQCcawESYzKV3XmTCVUeqGJxapKlmC16j5EpYER0tfdYZRfyLJK0FFRplkymos
Ew7ONOHaDSyRHTtR7HUwET58zzfNErvkG1CcbaA4SAKCutcFR+WDOMMlbeiE+E0lABibQ2QC
EZWct1bRp4DAcXHjk6zLxcJx10i5ejZ8r2c+GzIf4CoqAOQIYPL9amEoRzhT9CBAg1v17LU5
W450H3emGgFE8BsA5LOAjZIg+LjH5AhwcR0iAPJZgMiDavC5XKpiEH50I4BwMtfSuI5YY04K
YxJrPfTWSA1Mai8rQMHhpBnLY8e5mrsQHYi8689Gv+IJbKgEfeUS4c0FAgx/b4RYZksjYNcJ
0K4yO6IXOlaOZBW4IRFpVQDyEuKJwSb6SrZUpd2AoIK7c5j7+KwEpXufT2XAEPUjRoBqhnCx
1C/7eTd2AqLfA1+2+hxAFZFCQMeojxWYSCyIFzMA8hBwXh9KG2PlE7L/878maU/IfX1MGF0/
UnSjFLLNFYsoaSOzQFgM8qGGrSdhR36ftgAYiXdN4BKz08AnHPl7vk+lq7r7Uh8aHdHDiL5N
VFU8EaDI08IMde8SxlU6hno/l5csk4GOYQkXOzpq6d9vrT3JPay6TYKaWcCubdu1tMiFzPsX
ndu/UW8qh8JotVpELkaNUWriYNQUw66XGDHABIjlC6WiElaohBClrnEqKjeysYKy2jmLhUUG
f6Ck3JkOBQNnlxY+sBEWvMwj/oIYyTzNLcCHnWeTOi8jSEtMpLZer/dVyk7aKqhtc6eWdVJ/
1Ph2Me9939DYdzQPoQUIbb2e0JYBbgHAI8aPhVY1Kp4qbPCDhQacAsQ5lUsRxt6/4wr64Vib
uVBekfyQgPnZDCvQWle6HGK5kAyerMPAoRh+ZHJkcc2QqQNJ9QGOccpKvjmhvLtJbjjLXevK
UJWerscUpKWTtRHUOEZ3wZqAYlQoax8QZJdiDII0Gx5RrDYK/Ro4qP0SAPb+RKKgblIPI1u5
hapSBpdxqWtnFU0e97e5NQixqMSdk+YJzabW3ZUX5yhvf+ZlVnRh0wdpI5WKTashurMr9rEd
yRnFQM/SQdo9Dn/58fp4mQYZkSENlae2QTG9uRVNaqeNCuRV0js6dUTwpC7jIVIiQjUSG2xs
rQ/AvMIiidItMpuoGtciiglH/Ev283TwE+J1lUaMRBwOeXs+VPdRdTjqrj3SIbyqovoo4I4T
LkNtyQF7hRwebBwgbuA68r//b+3LmhvHkXX/iqOfZiJmpq3V8o2oB4ikJLa5maBkuV4Y7ip1
lWLKdl0v53SfX38zsVAAmEl5TtyHbpeQH7EjkQkkMr2CYIVaAGRwPR71FpIlb4uborwr/M9N
FWW1uHSZ3L20bvwkupSO3Je6+DQ47FRkcWFakEeTu0vP9o2Xc5fqYXWSetUOWUaN7/w7jWDw
ceirtJlPg5c13tFUMHe75og0W5Z7v1fyjcd3TBLtY0JZoXs5WOvJMJsqm4wvFZY+d3EOvuq7
JueRyAPGVbaVPKRbEiHC1iXyTGutWwUabC2d/WY2KR48SozglosC/tTu9EXzmeADbWxjE09j
qEeg56HPlXPVIVhaReGa3ciql59+gi+zNAdWw/cQGkJVcTTQZmUVV+txcLVG9XQ+j2+5T83L
/LRKgw5QrBV9VwQ1VuuHyUw1P63cc0r9xjctdyJMEy671Uknd5yKj6/xccrxy4V+9Fs9fDso
B6oXMnw9aQtpq3WDfj76xVsKKhSeYTwJ6B5YU0so/ACWwu5KDuapIWSu3cI/19gwe2OZzdbQ
+p9V3j+aOo2afhVdTCY+M15UPSjqY80Gdoc1ZVlfrjQ8HADfAYFd7hbqyky4C3CPvPUyMlMl
+NSIzr1PncNW/GyXS+qNsY7hGgvXFSwy0rAUm2adwsZNu0yLOC3W1EB06DiVah4s75U6u7zv
P+XtsP5pfpe8m5D12E1auSP9msC6D4ZCr86wz+3bbrbj1ILvkc0jscfnt8PPl+cvhC+3JC+b
xBh6nlh9l9pG3FMP3KROOPqEs1Gm1BwLqtIMnf86l0HmCkWVqwTagHQ7381OFP9iQ9HCu88e
ADRaKk8YcDrDu4iMhqcAIDz0q3gXFXiLkWZeOCrlWwPqdq7HNLCesbjuwV5vSPVQ/3x8/UaM
Mj5vcZY2/lSPTzx3Uyq1oJqrSfrOC12vh1mdKP6NUY8qczfWo0OWuedHQlP0pKc7wGtotxui
OIyh2O3zPZDQnr7eHV8OjtOp05KxaK2bU8pfh1Dr3WYKg/I3+dfr2+Hxony6iL4ff/794hV9
2P8BO0Mcdj6qDFXexiBipYXsXU76ZLup2ptO+Uw4YDSXs6LYCWc2m1R1eSvk1gugY8IC4fGD
WnF9ilcFj5gkA0SZRFCSDzg97SMaoVq3fHl++Prl+ZFunpUN1XMfZzKdTMpDEjSr7+xYSWO5
m6ARbZW7lSTrol8N76tfVy+Hw+uXB9jhb59f0lu6wtZJjjuDbRossyS6ga2HXO+IWoKoy8e0
Vv68BhG32zSKjM8cYg5jButt44yc9nMCtfP0Y+XkJ9JxkX1sHfk9dq5fuoezdG/hxrGuot2Y
nFY4lPblrveItl9E8qREr+z4dtDU5fvxBzrq79YiFXEmbRK1DrCtTV1mWRj1wZT58dy1hxLH
ToUq10r4jBAAuywoJM5iRsGgWNXCMwbDVHWEjwZPfjLss55B1ymNXr1AtoZkJ/8oVBtUI27f
H37AGmEWrNan0IuLd/Ck7QVgt0YHs/EyJFR1kAJKVgoMxV1FOl0u6WfMippl5NWEot3U92Wb
jb0QeS49B8kwK0Wc1L3dv4xgq2Ill7g2fLwnTeQpQ6nzBqPwuvuftRjZBNXCpCruJ/bSZJ6E
9hm01QYClQ+ppEcAtb+XJnvfm32DknWips4Cgqhq9w08OXvcBd+7JVJnXd3FRpjeu01xky/J
5BmTPCKT53TeczqTOZ3JgkZf0cmCTPYuvpzkhCzSu1Jzkpe95P4dUy0b1eHecVtEJvW6302+
JJNp8JxJpvNwu9lJXtDoKzpZkMleNzvJCVmk181OstvNnfa8rqlT5bTUHJkgcZsid4uFH6Vx
L7lydcoujchaXdXky20vTdb+CTSePivVfoQxSt2XgQ4N3WBytNFiztOup3yek4CG3aFJq61M
yPSsvFN8iaBVOZmVEinXwCGDaxqF8K4c1Ks4qi+N9gbCnoh6zhhPorer7VX1llQwTSmgmKBn
2rTtpov2UXb8cXz6k96MzVFhICHbVFJOp7KztI8pO7YYzD/Zrerk1lbV/LxYPwPw6dmtqSG1
63JnQv22ZREnKC64veTCYF/FY3DBuYz2sNgDUuwoodjFYdwvWYnIC+bjZSSkTP1svKYRMYHx
5McsOuMuQyHpwycUiB3UaS81xAV0alxHDt0rR09foggPpe/MMTjQIPQ0gG2yC4JWdcykiU7h
spI/3748Pxn1muoKDW9FHLW/iYgO72EwKymup4xJloGEMb1Cei72kwlp12oAVVPMRjMvSomh
aEEHrWTyVNLHMwZZN4vrqwkTw0lDZD6bXVJ3O4auYr97CtiJEDnuS8J8FRnDmk/IEE8g5pW1
56MDx77KRlfjNq9IVylWK46rVaD3pSs3Vi7qE667BGsJUldRunKCsqvZ6If77hwkJ2QNUrcb
UvRtuV2t/LvvU2ob0b7uHATr4NqD9BVmCoghTUEn3uYJ5dwDgTfoLQfhpz7AZBMXDR3B6NY8
+vnrf9I3A6fP/X6xNZHIBzvI2M9Y3hn3nWzTAGG+ZSGn2ve4wAd989HOLyyVNm0W8T6bTGfo
pGeQjhFKWDrM9HN0Lv9lLjiLUCCNmYgSQJoyMWGXeQS8RqmftFX7Mk8vF4sBQCw4O9dYTJgg
JTC565jx86FpdPcrGhP0erXP5OJ6PhYrtvccCDcAahIbR0OqzYS/V3+qNgY3QcdUJOxmL2O6
PTf76LebERc4OI8mYyZMVJ6Lq+mMn4eWzjUT6ZzxLtAWUyY6LtCuZ4zbGE1jmrKPYAYylvj7
aD7mLGwjwYYzRhoX1ls2N4vJiG4D0pYitEH9/+N88/J6VNMtAeJozLw9AdI150/yajzn/Xle
czwMSHyGjLU/kKZXbFnzyzlst8rplKhFljHcwEPyXO7qim/V1XzRsu26YngNkvjeuGLihKG7
1AX9wgRI10zYKiRNuf3h6pqJRwwbi/INJJinkmJfjS/3g2TkwwwZrxKUNxwekdRZWoxZehSN
YKWNWHpS7JKsrND1dpNEtCsxa5Uae8LVJl1MGVd/m/0Vs0WkhRjv+e5AR5YxS82aaDy9ojNW
tAVdHUW7pmempjHPkcR+FATU82ijEcOnNJF5fQO0MePIC2kTMpgi+iKbj7zAgHlUgSzO+DUF
2pSJEom0a2Z4rB8c9Hswu0J3APtgMDqguoQDnuFPikJsrxak/qG0nB1qY8w9utKAUrq4EwBz
CA59VTokz5wLXnuoZWroBKxYj7NWJ522DjXl2ryMB+KnN6qMy8WIvUBXZMb9nCVP5eWY7nqN
GI1HE3reGPrlAp2KDeawkJfMPm8Q85GcM9FBFQJKYB6waDKeag+QFxPGb5whzxcDLZQ68P0Q
YDJKeECTRdMZs7yQLKPxZehL2pB3q7mKpcNEw9FW0OF6+M+9ba9enp/eLpKnr777RBA66wSE
nywZyt752FzX//xx/OPYE1kWE2Yn3uTRNHx91N2ad3n9r3x09x4J/Wc+uqPvh8fjF/ShrUKE
+bk3GWj81cb4FaW3UoVJPpdDoGWezBlZI4rkgtu1xC2+IGQOrtAXHi1SyCieXLbsp1jPtE6R
ka4rRiXwMKFreYupJBTDKQ2aKpM6FbRwt/u8CIUbO3LhkHiHAp6rV/3G0j+KCBC9k4gggywF
Plyss/6B5+b41QaOQ0/g0fPj4/OT68uZBnSO/tHfJjWtlKaHNKrxvQ+1DY6sbElONdz8ZHXy
fktm3M/C7TTQPG2HoM/gR4YmXf+GAc2MhPF8r1cbLLwHzUK49Tu7nHOKzGzCKJVIYkX32ZTZ
6pDE8GBF4oTw2ex6zKx9pE14GvNaFUjz8bQe0Ghmc7w7GiBfzwdOjWZXjAKsSJy+Nruas/12
xY8Rr3uBJHfJ9s2AfjVhA10sFsw5W1yVTRtzYc7kdMooyyCGj7iTCxTR54xclc/HE44k9rMR
K7zPFszkBPF4esW8z0XaNSNWg3AB7b5cjEF6YYUnQMxmjAajyVfc4Zohz5njDy289Hq+i1Ix
wAU6Nvn1/fHxL3MT53LXHk0RVy+H//t+ePryVxf04n8gt4s4lr9WWWaDqegHK8p6/eHt+eXX
+Pj69nL8/R2jggTRN3qx5r03L0wWOgbz94fXwz8zgB2+XmTPzz8v/gZV+PvFH10VX50q+sWu
phNGmlW0cLBMnf7TEu13ZzrNY9nf/np5fv3y/PMARfclInWgfckyX6Ry0egtleMX6qic5fj7
Wo6ZcOaKOGW6c5mvR0ymq72QY1CmuWPPaju5nPESjtn+1vd1OXBemzZr0JdpEZXvci1/HB5+
vH13JAib+vJ2UT+8HS7y56fjWzhCq2Q65TioojHOQ8R+cjlwsoDEMdkKskIO0W2DbsH74/Hr
8e0vcoLl4wmjBcabhmFSG9RQmTMJoI0vmVP+TSPHDD/eNFuGItMr7vAZSeGtie2HsM2a/QFz
eTvCDHg8PLy+vxweD6BmvUMfEouOu3QxVHbhKOoVJxAoKnsJlMLSGbg+UmROTFntS7mArhq4
QDEALoebfM+IJGmxa9MonwK7GFifLoi9ogEQLPT54EJ3MEE+PivIZD6P5b4nIZt0UrK2NC1Z
h8wFqNexpKfUwORRsyc7fvv+Rq6xqEpbkdH8SsS/xa3kxAERb/Fwkplr2YRbaUACLsiEm65i
ec3dvSgi51RJyKvJmKnpcjPiYjMhidPGc8hwwUQyABoX5iGH5tE8F0hzhl0gae7ffxF6qoqN
gm++vReU62osqkvmSE4Tob8vL1dE7p2iJzPYUkcL71DSo40Z12NI5LzJ/CbFaMyIi3VVX84Y
vpo19YwR77MdzKtpRE9Y2JtgU+M3LiTSql1RCpBV6FaUVQNTkq5OBQ0cX7JkmY5GTMghJHHe
gZqbyYRZPcAItrtUMh3eRHIyZQJrKNoVc3VphrqB0ZzN6Qor2mKAxqhxSLtiygXadDahv9vK
2WgxpgJb7qIiw2F2J6tO40JDJXk2v2RkUU1kYojssjlnF/EZ5sW4Z+1hGLLPcPUziYdvT4c3
fQFMsuIb1pubIjHb9s3lNXeXYmwwcrEuBnbuE4a91BfryYiZj3keTWZBxEl/31JZK6G4t+HZ
mg2RoVIduTdfN3k0W0wn/MljgONaaHF1PhkNiBEBjMvtXuRiI+CPnIVzzj43oeaCniXvP96O
P38c/jz0DwrzLX1I6n1jhMkvP45PxFzr5AWCrgDNy/HbN1QI/4nhDp++gqr+dAgrgo8G63pb
NWetqXQIbxJlqkIXaKSWJ9AnLiAR/vv2/gP+/fP59ajCeRKN+gjcU29/Pr+BnHQkTblm3IQH
0pjhZrEEXsHYqYj9bDpwTDRlBA1NY86QomrKeQRF2ohhrEjjmK76jpPcmipjNT+mT8n+hnH2
tZosr65HvX2byVl/rU9dXg6vKO6S7HRZXc4vc/rx4TKvaOeGrrS1FCrA5ml4sw1sFLTLn7iS
3I69qZg5kUbViFezq2w0GrDD0mRaBQEi8GvPN2MuZ3Puxh1IE3qGGT6sgqPRM2LGnS9sqvHl
nK7750qA8ExH0+2N6El9ecLQq9RAy8l1uO+7u7D3nZk2z38eH1EDR17x9fiqbwaJvO1UyG+W
lZK70zxtGJs9FIRZqTWNRa0eYAZub06jsBxxGkXFPaGtVxiWmBH8Zb1ijnfk/pqVLvfQBIYE
+TGhr0H0mnCK4C6bTbLLfX8idwM+OBb/i1C/7MkgRgFmeMyZEvTOeHj8iee/DL/BO4JrRjwG
Lp7mbbNJ6ryMym0V3rBbWLa/vpwz4rsmcsYdOSiAjD0FkujlDaQRcz/RwMbNzGVFGtNsEA8H
R4sZvbapDnQ0sIa2bt/lSRsEmrfrwo1PBz+6uJ6nlXOXazc09LoCqmjyJAPVaEnnfzJ/80uy
seMe/dy0KRyXlXml/+gm2ucOQUbxHc06kaYiDDY5S9+kyx39XB6pab6nThkMaXwV1gRf6DQV
X9pNkuRLcc9kqYy0/BarJ9+prIJUG/4sKL6KxPWcuc1Cuu8ZgXrvpFCR8vfhppgnHE21DQg9
J55qZoUvEFViNl5EVRaHdQ79ArokdJjnF6heiIRZNGkSMXE9DHlTwz+YUnYpeuxvUnsDn9a3
F1++H3/agAKOQ4L61m8svplZp1Evoa3yfhqs9raoP43C9N2YAO8mVFqbNpJLh8FPWZr25OCQ
M9gmE3ww6D0BgqWSkk9/ovzqcrJosxH2Qd9RRjb20423xDRqnIeVJ7eCgIUdPF0nRf+VEPax
86bSTBrUoTy7RWPdhcmUXGo9RzjPknbA2bBLqjAtdX1w6qQydh8w6bTKHWedJBMHlUl8euV1
AyTJaLU23WynnKibFGN34tucqOo5dIK+gb9LGB73UQ+kWlefrUjjxHWKqEw7EeG/EzMOCFzn
bdAtgJNN4uWdq34Edbn3dhWS6/6sd5+c9ogwH/y5oH1xidSLFdxbY45kWInohtnD1FvfDb4l
U4E1cdlqxxzuPBqm6E3HMTDVqaFPGC/ZGPqFVDR+DtM0C6cSdTwTaMIyLLzzihF+141g8AEZ
M9WQlL0sxuHe3Lf+w2YN8EMZmzT1praX6rsH1ol67D95LsBsuop8QoyaRjieasn0dp1t+5F1
bQRVMlqrJVJBVz1HulqP2dxfyPffX9UT5RNTR4+NNbLszf0pDydRRSgEjdUlY7KNBHzaarDH
0f9OLQoZJemOfAmIKO0IFgbJz9G4aOyKe/TzVq6T8St6o9MI9LeHjz6ZktVMXCyVq2+/cOvf
KeNpo7E4S5zgNpRQCAzpM0RT7UZAKwqRletBXH84dGxh06mnkwtIvSkLXW/EsX2nAxYr3Acw
XP8Wckw0ElPxHW9cx0GllUts0QgiuTc9TAtN9sG0i5MiStqmrOvgFSaJi4d6woJkiu57z8NE
tqOCVCNGPQ5WcYX7zcnTPegS7mx3iMZdazCamqK8uw4tAx3AOYR4AGTquMv2phEKKbCzFaWd
6f4EUJuHGjF+kmgMX7qWHcQEL/ChDr0quPRtk6dhJSx9sTefD5ajo1J15RA5aQSWxLap2ot2
vChAW5Ipo2q5qHARuUWiB2eqKpC+XdHHZpa+lwONBfoGpbbHMFXPMJmG7DQCZakanEc5iC6b
EsXkOIc5Rx+UILCMkqxEc946TvgmGIdHt4vL+XR4Chm/u7cYoGqwhhaIEac+kCWyDm5gjFOq
yu9AnaqWQj8dWdpG+pO3I8iiArUjyZuy3fXWkfP5wHxyUGpenQcy5669rhrqU+tMiuuoUxSN
PqM/0fr7pEebhLOxewAVM3qsj8Ffe+pE3sMluavzeSTF4voLxqdTLNBHRDIN9xIWG2ssU6Dq
TJrU3Fe+iwuPyjNa8wwyrnTMG78nDFFxB0v2CrCukKBenBinjzmQbwWCnCX0JoHOdIaUnjDQ
CcL9z1zSJKxoRxyo6kl33LinBEjSgvK+tz+rdPS2VI234WwV+Xw2Pcfvfrsaj5L2Lv1MItCP
/LC0hc5LRuMRN8tB41jnaWpC1Xhf6ggq5qxNrQK2EB86xBfMiYP2j0QfznsKhvM1+hfiDqhy
/zBVayqHFwxaqY72H7VhqHMYdTquqfM2Uh6maE/Pml7wtJzS1pQfGNcnmEkIAmq4LqsRHvga
iuU2rJehWpkQXRWZLw1Fe2kc+6XrxImf2Gy2RZzU+3FYtPa/P9Qhshqmx3k0B8mTrruSDivj
cNuO+sBgdSqp8A7aYZpNe4Munr6+PB+/egNcxHWZxuRks3D31mxZ7OI0p/fJWFAe/oud5xhS
/exfDOhkdU6UUqeoJ3oZlU0V5tcRWukdtYFwlvh+2bS4sapqP4qMqRY+G5axoGpw2vJMhqfj
CUuB8tmqo2pFVt04uHPd5nWsNKi78YGsEt2rZB0JeK8p5NCYooqdbLNqXdHmIRpEcR8DUH7d
e4V4X9faqag2Jb+7eHt5+KJue/usRTI3JppdNhtyShJZdoteR7nq8sHfbb6ubZgrsrAQhCGe
6HWrI4hUNQh4/OvNLjsLl7wFdgCNdtTcOdWvqUWT7o1Hw0ciH7N5nC0vjZLpgGG4heUi2uzL
nv8iF7as03jtzUTbiw6ZYv+6xas6ST4nRC6mJdDXcaIvZ6lTLlVGnaxT9z6rXAXpfsPiFf3c
tWu1cU14fr7s0J1fNgCUVLc1SWKPCuGffX+JZaUR7s9WbvK22MIGWafo/2+dyE8j5w7Xyafj
E9usSaHb9uooNLRiIz1Cb9EBx/rqekw3x9DlaMqYHCAg9IfnkEz8K8pArlf7ChhlVblLWaZk
7BiMgYO+Qh/dBOPQ2fMDfEov1nFAU5Zz8O8iiZwLDzcVNxfP+j+gLZjtsI+jZKE+6pauXBDm
o0dSO8yubLx7lx7IRurm2nMCMSGfGfQVFde1jy0xHvRkuPTbSNJhYvtQdE4Nsq+UqR/ChwR6
Pvx6CBmFEXiHoEHUYQrDhyAm0Or052OFx3kQ3pbC0OHUCWS+GLlhUknE+Cxicg6h/YBzw26U
WbKzYANAKM10SiYyUuABVL9NPf44XGjFyfX7GsE+l2AAu9h4Zne7difQTqxJgJ3jpaqkNyIV
Q8j1gZ/sm3Hry7cmqd2LpqH9KTWT/icTVXApU+C+Eb11WZQKfhGYwp0g09Y9QDAJp5yDYqdc
hj6oZ8hjiL8tY+9MB3+zYPRDv1SD4N/4pdDZK7QqIMv/jSftedJ6JcccDSSXHtGQlo2uyWmK
2xS6BzuqCrehpvqa7ckOXG/x1L8AnAqvQddSo3kLKk0XEjqPvqI5FZesUIhJV3S1ijQb6KzV
mO9krB+pCAbd1c0kjN8Wznyd1i51TNCKGpVViqHXShXPxJP7ZZsUUX1foQEEV0NsOblWVrIo
G+gUx9AkTEh1gvLVfEpdiRBnUwxfQVuMPIWtqnTddN9uy8ZTW1RCWySNilGk2CR62KNOqGqg
GvydqIugHzSBnyq3q7xpd7RFoaaRLrswV8/mRmybciV9BqPTvCTUGr01FAVarIkqRq7AEsYr
E/f6+9OS7VJhNsdpjVsJ/Bn8/oQU2Z24hzqWWVbeuR3ngNMiTpgYlSfQHiaEavE5YJ5A15WV
N+2MV6Uv3/1wUCupWCK5uRm0hsf/rMv813gXq/3ttL2dNlpZXuNtJrNat/GqR7Ll0HnrBwSl
/HUlml+TPf6/aILSuxXQBHtaLuFLeox3Hdr52sYQjMo4QdXn03RyRdHTEiOIyaT59Mvx9Xmx
mF3/c/SL050OdNusaBVGtYXrp6LhOR7SJlwvDvaUPop9Pbx/fb74g+pB5ecxMKHFpJvwCMIl
7nLl7Sf8Ricbh8xtvM2pAweFRDMbd4mrxEpFQi1hgyrrXt7RJs3iOqEUnJukLtxhtUd/5meT
V72f1D6hCUp8ckvXybAC42RO6QzKnKsL1LvZroGxLt0C+STVYvfwLV+B8lgnXuCazlxsna5F
0aRR8JX+E/DCZJXuRG3H1R7y9qdBV3QqI7XfQd81Se5Nh7IWxTrhJ6eIB2grnpaoLZSjbvgP
gaRi9zLk5UBdlwPVGZIFBySVqBY5yW7k7VbIjTcxTYqWLHoiqU/Wm8hAvursKq9amaL7MjIj
g1CnNfR5K4U0Np3DH3BqRgf4nKVLslLZZ+aNyglAb3SnsunbuFPRsqHfKnSIqYpBtsxuoPc+
M37yLDbJl0kcJ5R992nEarHOExCWtLKHmX6aOJLHgMqQpwVwIk5nyAeWQcXTbov9dJA656k1
UajlxLIp3UiL+ne38d1gGMvlfYPnh5fj6WUflqGqizOtDvRgA4Gh78j0JabFTT+K20QfQi6m
4w/hcG6RQB/mtHG4E/pRd4McOsAvXw9//Hh4O/zSq1Ok4xgOVRsjjA7RV00tmCAKBlEL+hAS
dowdK/sNsNu65GYZqCZ3ZX0T7EeWGOx0+Ns1kVe/PfMCnRIeb7jEaQiXd4K8Z1PgdhSUNm1d
S4fCMnCQycttE1CUvumYiCh0BqIb9YUtr1WmzchfhLK5T2MbIemXfx9eng4//vX88u2XoMX4
XZ6uaxFqqT7IHsJA4cvENbQuy6YtgivUFdqNJl2gaTJ6rgWhVJZkCPIbZONOb+PKia0e1n0M
apSIW9znaYl4JSmGvK6VV3nQvUvnthP7PPypR90p1DiI7g1tK0E0CsPYym1RV1H4u127C96k
LQXe3Yqi8E08DJXXnqOk2rAyR8oQZL5Ei5Ydc5wJSo7gRTVmOV5XgX6gEs4cGmrMwJFhkbnz
InPYnKNeOWSrn7Wgn3nzxaVdMY+afRDjVsMDLRjnQQGINvwJQB8q7gMVXzB+kAIQfeASgD5S
ccYpTACihbkA9JEuYDyJBiDGl48LumZ8DPqgjwzwNfP21gcxrmP9ijNuXhCUyhInfEsfGnjZ
jMYfqTag+EkgZJRSN8duTUbhCrMEvjssgp8zFnG+I/jZYhH8AFsEv54sgh+1rhvON4Z5ue1B
+ObclOmiZUxlLJnWw5CciwiFdUGfQVtElIBKR9sOniBFk2xrWuvqQHUJosS5wu7rNMvOFLcW
yVlInSR08DyLSKFdoqDVvA5TbFP6ksLrvnONarb1TSo3LIY974szWmTeFimuVWIRpmV7d+ue
2Xh3itoX+OHL+ws6T3j+iW5unKO8m+Te26fxN4hRt9tEGsWUlu+TWqYgZYP2Cl9gPE/G8Ue9
BVSssqVFen0pMgQBQhtv2hLKVHIpI8VYmTTOE6newjV1Sp+FGKQjdZkUX2TpcjS6xXCxlfCN
w6zCLXYJ/K+OkwLaiJczeNbeigwEShGcWfZgZIkrEH7x/kaW25rRvjCMdRqpbHKYM1oQHa6+
zLnIkx2kKfPynjllsRhRVQLKPFMYBhSvUnoBdSD0jnWmzmKFLx5DO9F+aSC6l3cFesY8gwTm
gGhqkdnr0tDGYa2rkq4LAWueXJ8dCh/CeopLysVhzIWuFb4JjNuy7hbSElQseiHtKPNQe8py
Wh3C0UCgQz798uPh6Sv6rf4H/u/r838//eOvh8cH+PXw9efx6R+vD38cIMPj138cn94O35CL
/OP3n3/8ohnLjVIlL74/vHw9KAc6JwajDbwOj88vf10cn47odvT4Pw/Gm3bXNWmDszW6aYvS
f1SqSPjyEVdK1w7m7tSC0XiPwVptJlLn4p+TugT2luGjT+jVOll7S58g++VagzG6eZbM904X
YSFkzLaeexhzpfc7d5NC3hews+w7dbi6RVsQjEroHP2HIMyph1JMt7RmeNHLXz/fni++PL8c
Lp5fLr4ffvxUftU9MIzEWriG8F7yuJ8OujiZ2IfKmyitNq6uHBD6n8AgbsjEPrR2HXKc0khg
/2TNVpytieAqf1NVfTQkOpfNJgc8tutDQcoQayJfk+4ZsxjSlrYF8j/sZoYy6Ohlv16Nxot8
m/UIxTajE6maVOovXxf1h5gf22YDIoF7n24oWFk+O5nm/cx0/Fpr9129//7j+OWf/z78dfFF
zfdvLw8/v//Vm+a17K0TED96g5ZEEZGmgGHVIVnSfL4D1GcQMqfMHmxfbutdMp7NRte2reL9
7Ts6wfvy8Hb4epE8qQajf8P/Pr59vxCvr89fjooUP7w99HogivJe09ZRTrQs2oCEKMaXVZnd
s35xu6W/TuWIcQ9sm5ncpju+oQkUBqx+Z/nWUsVbeHz+enjtN2JJzaJoRb2Zs8Smpj5pqAOu
rkZL4pOsvhtqZbmiH1t1S2dJuXYx1H0jiRJBRr6rmYdWtv9j0FmaLS0C2eZgGHcXoF9MPLx+
53oZxMbeXNnkIiJYwj5oV0jf5X5MEOsT8vD61i+3jiZjqhBFGOi9vdo4whovM3GTjKmh1JSB
GQAFNqPLOF31Gakpqje+H1gseUyZDXTEGZFtnsLqUI4FBnu5zuMRadRrl+BGjPr7MCzy2bzX
bZA8GxHb+UZM+th8QlQalLQkWZbMabbG3FUz3ze4llmOP797rxQ6NiOJaQGpLXOdbRHFdsnE
47CIOqIPbrqpUt6tOJ3fzhaRJ1mWDvL6SMhmcHIgYM6PYJxQHGLV25B7PGQjPgtalwrY/TAL
TwbzAAmlCjx1hBNlSm7/g30GCnrY9XqWPD/+RFehntbR9ZO6VSVmC2dMYMiLKePS3349OE3U
9fIQILRE0L4tQUt7frwo3h9/P7zYEENUq0Qh0zaqKKE3rpdoMFRsaQrDtjVNDM9rBYpI4w4H
0Sv3t7RpEnTcUpfVfY+K0mwr/CAXAelsxTqgVSX4GnZQ7LuBIlFNiMRucLPtwKjwfKDIpFAS
ebnEO3nXksvRbEDLXYUq24/j7y8PoIG+PL+/HZ+IDTpLl4YlEunA0CjpBUhntz1jYbZLFFwz
hh7PP5GsXymmOA3iS1OYTso9l1kHHM5Q88l+ut2fQRNAk5xrspCPbOKnltESch9t9llqsDRb
DGbFXX8lJzs8MrlLC+1Gr7dQga69cJGWKD5qAZwkIXrZJQ/dRhPos4zEBSMX+zC4+TD4XMvx
oX4kRH6K/zyEMesBfe0ksi8Me2Ch1vGHsEy3d1lxL1co7G/1cLXU+T091z0c43RyuFvIKUp1
3+0ZaNd5w7DqJjoPQh4+BIorIcZD4yChNoyPMAdlXKl8ZGbOBvcTtayVD+IkGhQeTkDkJZfT
s1WMorMF53vZxhxM7NItDOOwaIm5FCns8vs2KorZbE8/X3DLFMDEMxitZPhgBLFl1CRl0ew/
UguLHX8EbBr3OT3bRbfkWxgPUOaMYIFk66zhXDnmJbhgvM84SP1wZbhSyrFetWWn+CrZRwll
AefNH9DgmByU1xCZnOEZFjUmmZSi3vYPpDoajA5P3FRuqOeQ2ugBIVZQnpXoRHi9z5imOYgP
7oBivKXNnhyQdcdTRlKprLDp/yefbCLKd4uQ93me4G2oukpFp1LedYElVttlZjByu/Rh+9nl
NaxFvHlMIzRF1e9OPWvcm0gulDsApGMu7NtUhF6hgxCJlid0VlfqxBfzoe/s0jXelFaJtptU
bwaxZoHdopaVMejdH+ow9PXiD/RSc/z2pP3Lf/l++PLv49O3k9ysjUfdi+s6dXWpPl1++sWx
ozT0ZN+g+4xTj3E3j2URi/o+LI9G66xBNo9uslQ2NNi+k/pAo22blmmBdVBP91ZWw8hY1aIW
aTxvK8cjgE1pl0kRgR5Z3ziXjGmRiLpVD0Jc02Zh30h2lWjqBB1YONNOKRhK1aCo1lethHUc
Vfftqlbe8NwrExeSJQVDLdAbb5O61oWWtEqLGP5XQ28v/bvbqKxj5qgNOjJP0DvGEipMzH9t
x+D6Ve7c7qJ7af/Ztmo+GsdGebWPNtoUtU5WAQJvNVcCo2FpNxuew+EuD1jtrSiKUhsFO+2F
ZuoHiJ4n7aiO0NFW07hcMhrNfUT//DNq02bberdo0SS4JoIEdGG2Yi92FAA4UrK8XxCfagrH
HxVE1HfcytOIJWPqA1TGRjEKDgFPyVfulF+aA2q32xYOO93795fKMKBTa4NkNXh4RShYSI/a
1ReWXVzmw12Nr27wcCHz3pB91jpykOo+tvBT9WugMH1KpnsPIk6dpJIp/P4zJoe/2/1i3ktT
PueqPjYV82kvUdQ5ldZsYOn2CBI2qn6+y+g3t79NKtPTp7a168+u83iHsATCmKRkn90rfIew
/8zgSyZ9SqZj9/dZkmuq1DGLJqnRpgBP750eEXUNkohiQK6EIcsoBX6jWDkAXPaunFS4jth0
Ehr4tx4XxHTPggF+4BN8xx48ge1TagKw+nWzCWhIQN+LaB0VvpVEmkC/fE07n2pG75QDfZQJ
9WZmo04rCdYrk2Zb9SvV0RvYA5UREg9RhhtIXpW1eQ97DuVFUeggSIURrYj6yru0bDLvjR2i
rbUcSlRlSUn8iCrKwubY5t7oILUjYQ4+qU56aLPbEJQoHOUqqWErtQR9K3j44+H9xxvGXno7
fnt/fn+9eNSmOA8vh4cLjFX/f5yjULSmSj8nba7fmU3GPYrEizNNdXcal4wPHPE1zZrZULys
GOM2H0T6o0CIyEC6xac7nxb+OOmTI07bsBO8E8KI7OU60yva2ZurbVv7w3DriiZZ6c0X/D20
mxSZeQ1ts88+t41w2CkG7KhK15Ykr1L98NOWn+beb/ixip1ZXKbKJgtE4NrhJttIjlHQ86RK
JUFaVraLpcMRbeo6aRqQ18pVLIhACPhN2yh5zvUCUBYN9RIJ00m3IIhf/LkIclj86cpSch2s
Hf1MHM3j7kTmiNQSOJQeMCeEXSCth+3Qu7l2SynVFLhLYrueOkM1qwyp1J8vx6e3f+uAa4+H
129962GlMdyo7vH0N52MBnSc3Sk2Sj0fbJfbFMPckLck+o0iSLzrDIT/rLPOumIRt9s0aT5N
u5lldMxeDtNTXdCk0lY5TjIySFV8X4g8NU+vnInqJreR984VRO1liQp1UteAcigaDf+BPrMs
jddOM45sn3fXmccfh3++HR+NGveqoF90+oszQieuoErDuyNqXtZQM+Wn5dP4crpwB6hOK9i7
0Slqzrz5TUSsbq0EY1e7AUCCgcELGO6M3FVU3UALVk8U81TmoomcfTukqJq2ZZHdB4vkTsBq
0o2pSiWeuIvVTfe2PlU8bKQwDe8ScYM8vu29YrcK9Uf7XnW+uqE9frErKz78/v7tG5qApk+v
by/vj4enN2cd5QLPkkC/d+MHOYmdTau+J/x0+eeIQoFym7paZZ+GFlZbjF6BZxZ+L8hwgq4M
m8D/E72mX2UqQI7e0Ogtyc8JjXyJaXBS82/WsbfZ4G/qSMuKOtulFMZBFW6rQU0VlSvvJsJP
UfhNMzMtzEh/aOz8vtIPV8MeRA8ZlsUaU+EuM3eJqgdYyb5JCsl5h9IZIlDt3vSxA2YDMibD
cxUZVoEsC+6E6VQKeuIagNRlLBrBqTknSVSB7/b96XNHyT7dKUiDfmC8HUWl6G+Zt6g633L5
WxIxbspktl1aGPP4ABGoH1B7uJo1ZrhhG82AYfTbZSkDVdT27lvJSZIy2qAmo1BJEWt/bed7
eZe31boRS9+th6UN1Of04QcKSetmKwh2YAgsj4duKet7Zajf/9iwXRRe2Y7X7EHAmqWOBxUB
tBuQNNeSB2zOAXZ5KBzr9wKa2jt98ai90g0V3w7BggPmd+JToGoGzixUHsONXynG7X6jUsjd
qsduerNwg6HoeuaWiL8on3++/uMie/7y7/efepPbPDx9c+U+aEiEDy5KT5X1kvHRwTY5RX3U
RCVpb5tPnZ8PPM1EzTlpYN26hwyyXDUsEWW2SsC+7sJUCR/BhFXT+bcbDF3RCHnj8nG973ak
rgGj8WW/oBOMrUsACatydwuyDEg6cem5zVN3IboJ5HAPj5t+Awgyy9d3FFTIPUhzHc6qQFON
AZL/TY9dnh63ECWG0xC78yZJ2NjVhkHUSZL797X6jgLtv0/7899efx6f0CYceuHx/e3w5wH+
cXj78q9//evvp8mrvDeqfNe4LAktrqrLXefFkayWygNbPrRH4ll8k+yZu1qzDKHl4ZOzAHI+
k7s7DYL9q7wLHyKGtbqTCSPQa4BqGi9kaJBoStR7ZAZDdyavVJtadEcGdNmqVFji+IauJ1Z0
qFNDifMHZ1quzmcVyVgXeifShjpUsYr1fzDFekpXfbvKxJra004KsDvxlHqjnp0VaEeLT8/U
+f1AF99oiYfh5NrVy8XXh7eHC5Rdv+AFIKEe4nXi0Po7Q2f8BGmi8jeaBjdhJ+1bSWOtEidB
ga63hIdUj8kxTQpLjWrov6IBnUf2+qaOtjQTBEKLAU8H5g1Czk4uBKErWzovB4RSj1KOu31l
PHLpvRmCickt6WzXxqj3GtdjFbdG360JTdcuDajUBvarTAuryvGUiipLr1wAFNF9U5Lej8pK
t6EOZK7VttCq/TB1XYtqQ2Ps2cvK9hFPbO/SZmMfeXrlaHKu3HkDAO90Awh6nVTjg0h1hhBm
EpkPdS4nos47Us6bukQ8nYQ5v1q57Ul2eG6OeO/sEnsdtEI8tMezj7AXenirPjFAZ6ezByO9
6YVyijrsNN9QR0bcyJ0ZNG68zg9VlzHsy6tOWXcZqSmMnJ8Y97lcrYYgRrwYgmgBaACwuYOF
MAQoZQG6dzIEwZ6vz2RjuslMS87rAn7eygL0qU1J8Z4l7CswpUyH9h5f23RjKoDvztUHXNAz
C4d1MghE54lotJSWbc93nD2zgcyWiV4Ssj9LwnQaPbyufSqaRVQocquzzG6u4aME77G/vC9g
ZuqS6BmAJjlNna7X3F6ny9WrPS3CbduHKVZDX+WcNoMTMzmDtCWLTN0Q4WgNzS7dY/hnW7NH
UnYmNqLGu09+M3Rq+R+BuzgHiiPFSQZq09D6TdVBKbq15kVDgV7xaIEML0DNFYk77mnp03rS
xMPL43zKHOylqDRZRp7G9JIWdT6fQmejowNeXi3rRKbrDR1aIqyDe6vTHF7fUHRFfTB6/q/D
y8O3g1vJm23BebwxkhteYZS1mbLsdNAurylM105zlnQTlbveMYkEvlHuzEytPCMWxFMCFCxf
tVdBn+G0MU+bTpLJTcxE81LqdA4js0mYR7MKEac7xgxo2V1foSYyMJ2XaCIxQFdGC2VWYlR3
FuXZW/Aw7YKXp2ulDWPwDmlPquWbZB+64vauhlCaOJuJAWr3MwxHNDgZMd5utBEoIJqSthlX
AG25OFBCJIoBsr5O5enbLeNjRlG12QtPR1/7K1DMeUSN1mC9E9hgRLiHM4oKfJInZjcDqwDa
HkSy8OnmRHSgc/ANG+utSJdRDXU+mrNu8BIX+CvNWdAGE+p5bo/D3FZpnYMWPdCR2o38QHt6
d8DhbFXOlVh3VXrG5uXAjIFdJAIpb2DGKak25fiyzWQYoJzhqMhsHC9G0QeyQbRzadglhH5s
6I2k5+xG2xD8Py2bOL2t2QMA

--MGYHOYXEY6WxJCY8--


From xen-devel-bounces@lists.xenproject.org Sat Oct 30 10:33:46 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 30 Oct 2021 10:33:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.218753.379321 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mglgD-00010l-CC; Sat, 30 Oct 2021 10:33:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 218753.379321; Sat, 30 Oct 2021 10:33:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mglgD-00010e-6B; Sat, 30 Oct 2021 10:33:41 +0000
Received: by outflank-mailman (input) for mailman id 218753;
 Sat, 30 Oct 2021 10:33:39 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mglgB-00010T-So; Sat, 30 Oct 2021 10:33:39 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mglgB-0003Iy-OD; Sat, 30 Oct 2021 10:33:39 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mglgB-0000nf-Cy; Sat, 30 Oct 2021 10:33:39 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mglgB-00012v-CU; Sat, 30 Oct 2021 10:33:39 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=RVbl6HEbo951eFOdxrI2thAZsOFgx4fm6+T1evFAvJU=; b=6wIsurN5X5YnLLXBfeUXMRUI72
	72ImJ/eL7alC22ag1R76OXm+PBK8kGBMZ+AZUew5SZn4wnFCT8CyGkpVV3T/PZrZBXxc5Wu0uHTN/
	kYU7fAL5KvgxQ3dY/ATT0D+50SOrZl0W8wrWlpSaece0ocRokPhsCuoSa0m9rhNgmfN8=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165941-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 165941: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-unstable:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=6f1d6682de832d12b728f856331e700a89737a1e
X-Osstest-Versions-That:
    xen=c91c967f329f866b1826b04e73e32aea936930cd
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 30 Oct 2021 10:33:39 +0000

flight 165941 xen-unstable real [real]
flight 165945 xen-unstable real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/165941/
http://logs.test-lab.xenproject.org/osstest/logs/165945/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 165945-retest

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds    18 guest-start/debian.repeat fail REGR. vs. 165929

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 165929
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 165929
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165929
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165929
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 165929
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 165929
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 165929
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 165929
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 165929
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 165929
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 165929
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165929
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 xen                  6f1d6682de832d12b728f856331e700a89737a1e
baseline version:
 xen                  c91c967f329f866b1826b04e73e32aea936930cd

Last test of basis   165929  2021-10-29 01:51:41 Z    1 days
Testing same since   165941  2021-10-30 01:06:41 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Roger Pau Monne <roger.pau@citrix.com>
  Roger Pau Monné <roger.pau@citrix.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   c91c967f32..6f1d6682de  6f1d6682de832d12b728f856331e700a89737a1e -> master


From xen-devel-bounces@lists.xenproject.org Sat Oct 30 11:21:28 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 30 Oct 2021 11:21:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.218761.379334 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgmQB-0005va-Ti; Sat, 30 Oct 2021 11:21:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 218761.379334; Sat, 30 Oct 2021 11:21:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgmQB-0005vT-Qh; Sat, 30 Oct 2021 11:21:11 +0000
Received: by outflank-mailman (input) for mailman id 218761;
 Sat, 30 Oct 2021 11:21:10 +0000
Received: from us1-rack-iad1.inumbo.com ([172.99.69.81])
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=b4cL=PS=citrix.com=roger.pau@srs-us1.protection.inumbo.net>)
 id 1mgmQA-0005vN-1F
 for xen-devel@lists.xenproject.org; Sat, 30 Oct 2021 11:21:10 +0000
Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144])
 by us1-rack-iad1.inumbo.com (Halon) with ESMTPS
 id f89ef690-770e-4cff-9b09-9d50a47bb8f8;
 Sat, 30 Oct 2021 11:21:07 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f89ef690-770e-4cff-9b09-9d50a47bb8f8
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1635592867;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=6tpULM4ZD1M+wixY1TQGNkm6mlHW/JJWzfgQUhduvMg=;
  b=NJol3vGs/CkfH5eHAsW2FRedpx3fCGutjbTVxk5O6WsdCU7Q0tNW59PM
   zBn/YQdt2mgt+5mLX1FsicqaOYxOXd45NC4BlOJ7B+v16hX02tFCElvRc
   H83P4ndFCPm+qm1JZSBN+tW511t0DWshyZDdEI2YploCReeYQhYQ5fQs9
   c=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: v2R6uMXalIAMQYJ4EFPs7ugp4dMr3OHgreGRSlq1OaFYAf5qAXyGJJmmWJ2hXrAo8o2Cvrn/Np
 eQ5ZiUlL6A34JG92CvW3XSPiPyxKP6+WTsd+237VUgOCbBhM8bBXxaLNK6/eVsqnnHdK/bHR3T
 EM89pucHnCbC0FjvMGvdIT9NPZSkWrMg7lpqivs2MpIwvowWz2BX1oTHQ4ycPyjl9QESd0G3hp
 sUqikMNN8DtfsHb4GXpddaZjSnAaiEIPcfbLznyUjdeCZJ8X2qqyl0QYEmxojs55M6f66faVar
 K6ZzM+LRYOf4npHfLF2bJn20
X-SBRS: 5.1
X-MesageID: 58636649
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:1sVfn67Z9gbup8bFdjmVLgxRtKvAchMFZxGqfqrLsTDasY5as4F+v
 mAXWW/QaareZGOnL9Agbd6z9EtSsZXXnd9rHgpqqys3Hi5G8cbLO4+Ufxz6V8+wwmwvb67FA
 +E2MISowBUcFyeEzvuV3zyIQUBUjclkfJKlYAL/En03FVAMpBsJ00o5wrdh2dYw2LBVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Z4
 o4TmZOWEisTFYbgk8gnXhhmNxhMIvgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALNs7kMZlZonh95TrYEewnUdbIRKCiCdpwgWdu3Z4QQae2i
 8wxSSpBXjb+eAV2IFI4OsJnwaCDn0H4SmgNwL6SjfVuuDWCpOBr65D2K8bccNGOQcRTn26bq
 3jA8mC/BQsVXPSAzRKV/3TqgfXA9Qv5RYYTGbuQ5vNsxlqJyQQ7GBAQEFe2v/S9okq/QM5Eb
 VwZ/DI0qqo//1DtScPyNzW5v3ysrhMaQ8BXEeAx9EeK0KW8yySzC3UATzVBQMc7r8JwTjsvv
 mJlhPuwW2Yp6ufMDyvAqPHE9lteJBT5M0coPnEoQi1ez+PIi604oijCT+hHKZyq24id9S7L/
 xiGqy03hrM2hMEN1rmm8V2vvw9AtqQlXSZuuFyJAzvNAhdRIdf8Otf2sQSzAeNodd7BFjG8U
 G44d99yBQzkJbWEj2SzTeoEB9lFDN7VYWSH0TaD83TMnglBGkJPn6gMv1mSx28za67onAMFh
 meJ4Wu9A7cIZROXgVdfOd7ZNijT5fGI+S7Zfv7VdMFSRZN6aRWK+ipjDWbJgTuwzRN2wP5nY
 87AGSpJMZr8If4/pNZRb7xEuYLHOwhknT+DLXwF503/uVZhWJJlYehcawbfBgzIxKiFvB/U4
 75i2ziikH1ivBnFSnCPq+Y7dAlSRVBiXMyeg5EHJ4arf1s9cEl8WqC5/F/UU9E890ijvryTp
 S/Vt44x4AeXuEAr3i3TMS0+M+yzBc4XQLBSFXVEAGtEEkMLOO6HxKwea4E2bf8g8ulixuRzV
 P4LZ4OLBfEnd9gN0211gUDVoNMweRK1qxiJOib5MjEzc4Q5H17C+8P+fxup/y4LV3Llucw7q
 rym9wXaXZtcGFgyUJeIMKqinwGroHwQuONuRE+UcNNdT1rhrdpxICvrg/5pf8xVcUffxiGX3
 hq9CAsDobWfuJc89dTE3PjWr4qgH+ZkMFBdGm3XseS/OSXApzLxyo5cSueYOzvaUTqsqqmlY
 OxUydD6MeEGwwkW49YtTe4zwPtntdX1prJcwgB1J1nxbgymWuF6P32L/chTrakRlLVXjhS7B
 xCU8d5ANLTXZM68SAwNJBAoZ/io3O0PnmWA9uw8JUj36XMl/LeDVkkObRCAhDYEcelwOYIhh
 +wgpNQX+0q0jR9zaoSKiSVd9mKtKH0cUvp46sFGUdGz0gd7mEtfZZH8CzPt5MDdYtpBBUAmP
 zuIifeQnL9b3EfDLyI+GHWlMTCxXnjSVMSmFGM/Gmk=
IronPort-HdrOrdr: A9a23:HraR9aGgIJ/IIjHkpLqE7MeALOsnbusQ8zAXPidKOHtom62j5q
 STdZEgviMc5wx8ZJhNo7+90cq7IU80l6Qa3WB5B97LNmTbUQCTTb1K3M/PxCDhBj271sM179
 YET0GmMqySMbGtt7eZ3DWF
X-IronPort-AV: E=Sophos;i="5.87,195,1631592000"; 
   d="scan'208";a="58636649"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=mll9BnUoqrMnYSSkxMOupgQPnlrh9KRa1YjOoQ3P4JiOqLWD62Otf5J1MloIVbQPhMnIj/RD1d0ZThDDOJFd2PoPE5g6hBVJ/i0lE4csdiYp5HALH/PLQtF/+XM8rrElnU5JmmE2r8F57s74GmIEzQRtMz5JQBxMclzhMcVeE3057Yo2DdlGpGi9RQ8KeaAfW+vGuoHzmEnSSowN6jK48t9kO1un1jdHyQV6I764x+YbaggK4E/gN1tuRl+yzNiWkiIQ2Zj7ouNae5pcIWnHh55AbOo5QyErf98M4LarCvU3ODcqvgfeOWmkWGxXXnpOvB0dA7ne86HE2C84EoTr9g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=eL9d3AAwjismmBUI/evhcZFncUj6y6jknF/XdMOfg6M=;
 b=SHN6KAc0y56wCDihIDTBrxa99QQhSquiITBJCuPh7vIn9bTfgxrZLmGND30OpBx3Zluiohf594QYrCHsB4iao41IYT3Zlr/TP8sGcIsXQKy4PQDLgUidmxNiDZB1CCLcls1LMUSCK6s3kKQqmczaCKYstTM8u/4nY4vGHbrRXnCfL22WquaaLryeHSw2HTsiW/OWq0jtkXM98vVTV6rDaWySSToHC0SkgUaUtiWG2K9Gb98MlvdnqU0obO+/R/QM8EeuJhj0jMF2mc5+iHNQplgPprLD97AHSMw9MSVB4zHmruM5i94ASOsGOW/DMIlysEjWkf2QoBP76Kfk57nMjQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=eL9d3AAwjismmBUI/evhcZFncUj6y6jknF/XdMOfg6M=;
 b=Y/wh1lAQU4lGPbofmyydPhxd86M+BJXbgQbTbB4cBrVDJLYqVTagzdJfOUU9oE0wSRhkcvFI8A0sw+l3WXf7+Bzjgr/dq/PTjL1Z2j+a8ZLpd6+wDHFBd69uXNJ7YRw8KgLYDkkxTEO4G+/la5drHse9c/oVBZyUmwz2Fm5Aev0=
Date: Sat, 30 Oct 2021 13:20:57 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>, George Dunlap
	<George.Dunlap@eu.citrix.com>, Ian Jackson <iwj@xenproject.org>, Jan Beulich
	<JBeulich@suse.com>, Stefano Stabellini <sstabellini@kernel.org>, Wei Liu
	<wl@xen.org>, Julien Grall <julien@xen.org>, Christian Lindig
	<christian.lindig@citrix.com>, Edwin =?utf-8?B?VMO2csO2aw==?=
	<edvin.torok@citrix.com>
Subject: Re: [PATCH for-4.16 2/2] xen: Report grant table v1/v2 capabilities
 to the toolstack
Message-ID: <YX0qmTXBD3jSXjBI@Air-de-Roger>
References: <ffd27f87-9e47-12cf-2cfd-1688a19c445f@citrix.com>
 <20211029173813.23002-1-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20211029173813.23002-1-andrew.cooper3@citrix.com>
X-ClientProxiedBy: MR2P264CA0047.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500::35)
 To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 1d185b53-f1a7-4f5d-e773-08d99b975bfb
X-MS-TrafficTypeDiagnostic: DM6PR03MB4058:
X-Microsoft-Antispam-PRVS: <DM6PR03MB405843FC1697546CD520DF3B8F889@DM6PR03MB4058.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: J6K+LudxGhpkizwajrSo+lXBbE/PsT32z0ILFEI8TaNgPLPTxqGd9Z3/iy78YnsbB2gKfe7p8Cuie8bT6+YQ+1VZlJd3bcpr8kxLnvdmIwevxSmMFLfGC52j5Xa8r8vsT9oxb8eOT8ePfFTkL2UR909GsXFuksoNbhv4gOIKKMFKLRqQUGN5fRAfOCNSd8mC8jL9F6WS0sjsdDeoXTaYCjl/PtTdrBXXpOoRhQs+/0EgZaRkcgaXFF+cmi3vuqB6DGu6Nt9TjT24WHl2vcIuodIoZ/RL1eEuj+/sH6ZOXv1+/rPTpQgunMXxaYZeAxqQrrRku4JJOc+JCw4oSOKCz4Hjn1xyqf+9gnUucX6Wgs5r14S9xoosHyQ102vs5230foxuIqz6yL8wVkoAjkjAog5AICmK/M/Xl0U6NliBHw79kUQ+hajNLUj3C1AvzwczsZ8reNq5V1HlTDxPw4EV/YYpuRp6jijeB7JIWsLtmLP9M6bXLJR39ERmOrdgyun4vrZkHVBPn95d3eyeznh1Erk0TSL0iLFOmo8jf1D/FOoXd0ZU6F2Ox5C8JGm/GUZ6NzVpzTpcYSQ/9ALzXpBjGULB6Lq1QTGxxrLMtTb05Im5wtums0IEjYcc1WWc1W3SodfuEKPsX9+g/Xjy6Wn01g==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(7916004)(4636009)(366004)(2906002)(8676002)(54906003)(186003)(6486002)(508600001)(85182001)(316002)(38100700002)(26005)(66946007)(8936002)(4326008)(66556008)(956004)(66476007)(83380400001)(86362001)(6666004)(33716001)(4744005)(5660300002)(107886003)(6496006)(6862004)(9686003)(82960400001)(6636002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TFBUR1V2TU1QV3d5RU1EZlVwNllBL0Q4dSt2NjZpNTdQVUxtR2UyVzVhQ3N5?=
 =?utf-8?B?MDk2cnhIdFRUS1dOWTM5bXBzcHErWDRpN0RVSjh2eEU2N0VNZ1AzVUZSYlBX?=
 =?utf-8?B?NkFLdzM3OVlRZytUTWpTenUwMGtiWVBzV3dDNU1za21Ea3pCUGtnbzBkYlVB?=
 =?utf-8?B?dndNRlF4SzNxRlNkTDA4MStLYkdCSlBpdUhmUGRSZDFOL21IZThmOWpnNnhr?=
 =?utf-8?B?bjV3VXJiMVBBZWtIcDlGMSs1bmhINHNYMUZWWXk0azZ4V3RGQ1A5ZlhkZEtn?=
 =?utf-8?B?TmFFZHh4UklJZDRTUTF6cWxwK1p1S2FxdjZwOUdTNnVhVCtvQzJSSi9wcVAx?=
 =?utf-8?B?akJ6Z0J2N3JDK1VjWG1mVXRpM0ZWMFZRYytCRFhpbUI2YStrSDkrRElIamNE?=
 =?utf-8?B?b1piRmlxV0F4bWk3UXZhZmVPb2NsM0FpdnZFK0ptb2NsajE0cENoaEJCSTBi?=
 =?utf-8?B?R1JRWGswUGJwc1RmTWxwQnBvKytkRHVLeXVscktIdWVGcitqYnZDTlgwQ0oy?=
 =?utf-8?B?Sk5SWEZxYi9aQ2VQSnR4ZkErVkk2Nm5xY2IyQTZGL2tmS3lmcnRGcmRrZWx6?=
 =?utf-8?B?U2lTeU9EajlPaTZIZDBsUURTa2VaZHNHdXNlNHoyQ25iSjN5RXJiZHZISFhG?=
 =?utf-8?B?LzNTb0xWcWlEZ21xQnVoNGNFenZPb1VEQlFDTnhsWG0yR3NqdENUNHNPblRG?=
 =?utf-8?B?eE5jbVRzRVVobGlzMWlxcEw4ZTdXNjJuc2FuL2tnNFJqeExiczd5VFFqaXhX?=
 =?utf-8?B?d2VsVWxZbSs1czRXdWRrVlFPTVJUWGszUUxVaFBkQTFQTTN6ODFYS0RCZjA5?=
 =?utf-8?B?cGU3cDdQNHRQR3ZKbklsNnhwQno0Vm1kOTF2c1h2L1MyVzBmODNITFRDcUVV?=
 =?utf-8?B?WjRFVjQrTWtJYSs3Qkk3bGtrWFcxa2haWHJENHE2MGxGbHNodVZiS1BQeTNL?=
 =?utf-8?B?MDZINzJXNitMdWw5aG5NRjBCODJIY2Z2NW5ubEZ4UnJsaGFSNFhaZldKN2Uz?=
 =?utf-8?B?a2JDOFpxMERkNlFNS3k1SERFbXdZNmlIUFRMWGlubkd0a3ozUGcySTQvM3lW?=
 =?utf-8?B?cjFRb3pLbnhoYjlncHpNaktqbW5HMGpQSFNCN0laeDRNdWY4SU1YaU9iRzY5?=
 =?utf-8?B?Tjkxa0ZHUm9iUVhISXF4b1ZCbkppZ3lzeExOTlF1b3c2WkhTU1RhYVdiaExC?=
 =?utf-8?B?cmNTNi90L1BMWUxMOUlkYXdyYm4vWVRoZkx0emllTVU4cGZ0UXZqWjdKeFBs?=
 =?utf-8?B?bFdDNFJTZ05vMGlmQlJnV1Z1RTJHejhZRmtzdm1BUENpdFM5aEZOR05qQ3Bz?=
 =?utf-8?B?ZDdrODA3dzVabzI1bkM1NGd6TlpzeEV0ZkN0RXlNWDNid1pLYlNCOG9lOWlO?=
 =?utf-8?B?YzVxNUxuSy9ZTHVTeGUreXl3djNKb2RFOWxXaGN6Y1BsRFE3M1BxUTFiZ0pr?=
 =?utf-8?B?MGJkQXZGTzJtNzNXZXNBdG1ySFlzTThMelkzd0VZMS9oUUo4ZzRxbys2cU1S?=
 =?utf-8?B?YWhDSUFHNHNPWmRQZDc4MW13YXZJb3pmcytCc3BYTngrUW1wcVpHNEhVUTlT?=
 =?utf-8?B?MGNkalhzdVFzV1V6Y1Zhd1d6T0xUZXVMVTNsVzJuNEVpSkhlMmV4UStwYlN2?=
 =?utf-8?B?TEFuYWdUVEVGVE8yYitVaThvUWM4dGY0NEtQSFJnS2huSHdWeHZIUzNLVVBj?=
 =?utf-8?B?Q0RNNEJqYllwckRBaEF6Y3ZObUg5d0kzRmh3dzRwMTgzd3lONjd2RmhQVldP?=
 =?utf-8?B?a3lhL29HVUMyMFpWL21Ncng0VWgxc1VRdGJOT3JVL2lWUHBzTWZXdldIS2Z0?=
 =?utf-8?B?V3IxcDNpYklKSWI0bHYzU29BeDVzR3BlekpiTEloOXhQRGI3ZmFEWlZDdHdI?=
 =?utf-8?B?VmRTWjdNZVoyQUZoVDJacVFmdjNpOXgwWit6bHEwcmZENityYVZ3V3NVYjJa?=
 =?utf-8?B?UlVBcDZEQmhtaHZUZ3FBQ0pDak9sTmt2RVlsM1hja2ljZGNyQkQrNkdYbU5t?=
 =?utf-8?B?cnk3UzdjRFBIM2FqOVhmTzlZN0lYaVo5WnlXRXRpYStOZG85aEVXNVRwTlpO?=
 =?utf-8?B?YmVMdC9LMVZNN0Q0VFdUanZxalRHS1hDSkRGTWQ1VUFBLzNQTlJoOWQ5QnRj?=
 =?utf-8?B?VVFESmpGZGFQYU96UEpscnMrT09zdGlQd240a29PM2pSVS9MemN3VHdndWZZ?=
 =?utf-8?Q?cuWt8tM6QJlsBT4XYiflLR0=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 1d185b53-f1a7-4f5d-e773-08d99b975bfb
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Oct 2021 11:21:03.7040
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: r6l4DrIFb6KDLolPdJYTIsh8bL0WGdFbeE4zzY6SEScPB0s2AQSkGMbgRDTPNbNg3pJaIsDmgOANWm0305Xscg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4058
X-OriginatorOrg: citrix.com

On Fri, Oct 29, 2021 at 06:38:13PM +0100, Andrew Cooper wrote:
> In order to let the toolstack be able to set the gnttab version on a
> per-domain basis, it needs to know which ABIs Xen supports.  Introduce
> XEN_SYSCTL_PHYSCAP_gnttab_v{1,2} for the purpose, and plumb in down into
> userspace.

I did consider exposing the versions supported together with
max_{grant,maptrack}_frames using a new grant-table dedicated sysctl,
but maybe it's fine to expose the version as a physcap and fetch the
other two separately?

I certainly didn't look much into this, maybe it's pointless to expose
max_{grant,maptrack}_frames. I think the toolstack will need to be
able to fetch grant related limits on a per-domain basis like we plan
to do with the grant version in order to assert the destination host
supports the current limit applied to the domain.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Sat Oct 30 11:25:33 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 30 Oct 2021 11:25:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.218769.379345 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgmUJ-0006di-Jt; Sat, 30 Oct 2021 11:25:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 218769.379345; Sat, 30 Oct 2021 11:25:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgmUJ-0006db-Gl; Sat, 30 Oct 2021 11:25:27 +0000
Received: by outflank-mailman (input) for mailman id 218769;
 Sat, 30 Oct 2021 11:25:26 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mgmUI-0006dR-64; Sat, 30 Oct 2021 11:25:26 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mgmUI-00048W-1f; Sat, 30 Oct 2021 11:25:26 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mgmUH-0002Sk-Lt; Sat, 30 Oct 2021 11:25:25 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mgmUH-00037K-LM; Sat, 30 Oct 2021 11:25:25 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=kFSPv7mq3mDoSpbVsl8bhlyKobhNVynQNbH1eXubWbw=; b=LbGU0KemD2FpbcPD/U7tKqRVDh
	hJCcN0Dtqd8ZJiNrs+ApBow2vUBJYjlQbEHvGXYEuRlvJZjcG85GCbXEV7dVK+QiEqMSnWrMyQPBh
	pXbiyO/BHg6ZDobO+SkIRKvJNyWwGx+Bc9izsDjhafUWIGZadhH/8j9EU6eWW+fI6ar4=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165942-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 165942: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:allowable
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=119c85055d867b9588263bca59794c872ef2a30e
X-Osstest-Versions-That:
    linux=a379fbbcb88bcf43d886977c6fb91fb43f330b84
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 30 Oct 2021 11:25:25 +0000

flight 165942 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165942/

Failures :-/ but no regressions.

Regressions which are regarded as allowable (not blocking):
 test-amd64-amd64-xl-rtds     20 guest-localmigrate/x10   fail REGR. vs. 165937

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 165937
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 165937
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165937
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 165937
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165937
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 165937
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 165937
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165937
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass

version targeted for testing:
 linux                119c85055d867b9588263bca59794c872ef2a30e
baseline version:
 linux                a379fbbcb88bcf43d886977c6fb91fb43f330b84

Last test of basis   165937  2021-10-29 19:09:21 Z    0 days
Testing same since   165942  2021-10-30 02:25:07 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Alexey Kardashevskiy <aik@ozlabs.ru>
  Asmaa Mnebhi <asmaa@nvidia.com>
  Bartosz Golaszewski <brgl@bgdev.pl>
  Jonas Gorski <jonas.gorski@gmail.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Michael Ellerman <mpe@ellerman.id.au>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     fail    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   a379fbbcb88b..119c85055d86  119c85055d867b9588263bca59794c872ef2a30e -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Sat Oct 30 12:15:12 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 30 Oct 2021 12:15:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.218781.379359 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgnFu-0003EM-Lk; Sat, 30 Oct 2021 12:14:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 218781.379359; Sat, 30 Oct 2021 12:14:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgnFu-0003EF-HG; Sat, 30 Oct 2021 12:14:38 +0000
Received: by outflank-mailman (input) for mailman id 218781;
 Sat, 30 Oct 2021 12:14:37 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mgnFt-0003E5-OK; Sat, 30 Oct 2021 12:14:37 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mgnFt-0004yv-Fy; Sat, 30 Oct 2021 12:14:37 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mgnFt-0004hp-5z; Sat, 30 Oct 2021 12:14:37 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mgnFt-0001Oo-5T; Sat, 30 Oct 2021 12:14:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=VNpD3uA+nrgvV2t7cHMtZLJhIEIPjtMmZXtLQtbkgbw=; b=36KXejrY4iPPfDUuuyxhAABFcj
	hq01QHTNlbvLCragBg7v5dp8eAMfZsWN4nnMjk7sIGQqd/HZyBSU+cGzj9lqqCQ3A1RDWf9dJe2mV
	s1+Ap3mrPZ5ZoxQ6nddPFcqZaPpll6P71ch1hptBamNrt/rUY+wKlyVoLDEvb3ys54Vs=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165943-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 165943: regressions - FAIL
X-Osstest-Failures:
    qemu-mainline:build-i386-xsm:xen-build:fail:regression
    qemu-mainline:build-i386:xen-build:fail:regression
    qemu-mainline:build-armhf:xen-build:fail:regression
    qemu-mainline:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-amd:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-pair:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-freebsd10-i386:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-freebsd10-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-coresched-i386-xl:build-check(1):blocked:nonblocking
    qemu-mainline:build-armhf-libvirt:build-check(1):blocked:nonblocking
    qemu-mainline:build-i386-libvirt:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-intel:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-shadow:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-vhd:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=a856cce31b48ef1b04ea80893458766ec16e7194
X-Osstest-Versions-That:
    qemuu=50352cce138ef3b30c1cda28a4df68fff5da3202
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 30 Oct 2021 12:14:37 +0000

flight 165943 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165943/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-i386-xsm                6 xen-build                fail REGR. vs. 165682
 build-i386                    6 xen-build                fail REGR. vs. 165682
 build-armhf                   6 xen-build                fail REGR. vs. 165682

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl           1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-credit2   1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-cubietruck  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-multivcpu  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-rtds      1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-vhd       1 build-check(1)               blocked  n/a
 test-amd64-i386-qemuu-rhel6hvm-amd  1 build-check(1)               blocked n/a
 test-amd64-i386-pair          1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-freebsd10-i386  1 build-check(1)               blocked  n/a
 test-amd64-i386-freebsd10-amd64  1 build-check(1)               blocked  n/a
 test-amd64-coresched-i386-xl  1 build-check(1)               blocked  n/a
 build-armhf-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-arndale   1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-credit1   1 build-check(1)               blocked  n/a
 test-amd64-i386-qemuu-rhel6hvm-intel  1 build-check(1)             blocked n/a
 test-amd64-i386-xl            1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-pvshim     1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-qemuu-debianhvm-amd64  1 build-check(1)         blocked n/a
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow  1 build-check(1)  blocked n/a
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm  1 build-check(1)      blocked n/a
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 1 build-check(1) blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a
 test-amd64-i386-xl-qemuu-win7-amd64  1 build-check(1)              blocked n/a
 test-amd64-i386-xl-qemuu-ws16-amd64  1 build-check(1)              blocked n/a
 test-amd64-i386-xl-shadow     1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-vhd        1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-xsm        1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165682
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165682
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165682
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 qemuu                a856cce31b48ef1b04ea80893458766ec16e7194
baseline version:
 qemuu                50352cce138ef3b30c1cda28a4df68fff5da3202

Last test of basis   165682  2021-10-19 21:09:14 Z   10 days
Failing since        165694  2021-10-20 18:09:12 Z    9 days   24 attempts
Testing same since   165943  2021-10-30 02:48:19 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Alexey Baturo <baturo.alexey@gmail.com>
  Alexey Baturo <space.monkey.delivers@gmail.com>
  Alistair Francis <alistair.francis@wdc.com>
  Anatoly Parshintsev <kupokupokupopo@gmail.com>
  Andrew Jones <drjones@redhat.com>
  Ani Sinha <ani@anisinha.ca>
  BALATON Zoltan <balaton@eik.bme.hu>
  Bin Meng <bmeng.cn@gmail.com>
  Chenyi Qiang <chenyi.qiang@intel.com>
  Chih-Min Chao <chihmin.chao@sifive.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Cédric Le Goater <clg@kaod.org>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  David Gibson <david@gibson.dropbear.id.au>
  David Hildenbrand <david@redhat.com>
  Dr. David Alan Gilbert <dgilbert@redhat.com>
  Eduardo Habkost <ehabkost@redhat.com>
  Eric Auger <eric.auger@redhat.com>
  Eugenio Pérez <eperezma@redhat.com>
  Frank Chang <frank.chang@sifive.com>
  Frédéric Pétrot <frederic.petrot@univ-grenoble-alpes.fr>
  Gavin Shan <gshan@redhat.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Greg Kurz <groug@kaod.org>
  Gustavo Romero <gromero@linux.ibm.com>
  Igor Mammedov <imammedo@redhat.com>
  Jason Wang <jasowang@redhat.com>
  John Wang <wangzhiqiang02@inspur.com>
  John Wang <wangzq.jn@gmail.com>
  Jose Martins <josemartins90@gmail.com>
  Laurent Vivier <laurent@vivier.eu>
  Laurent Vivier <lvivier@redhat.com>
  Luc Michel <lmichel@kalray.eu>
  Luis Pires <luis.pires@eldorado.org.br>
  Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
  Markus Armbruster <armbru@redhat.com>
  Matheus Ferst <matheus.ferst@eldorado.org.br>
  Mathieu Poirier <mathieu.poirier@linaro.org>
  Michael S. Tsirkin <mst@redhat.com>
  Mingwang Li <limingwang@huawei.com>
  Oğuz Ersen <oguzersen@protonmail.com>
  Pavel Dovgalyuk <Pavel.Dovgalyuk@ispras.ru>
  Peter Krempa <pkrempa@redhat.com>
  Philipp Tomsich <philipp.tomsich@vrull.eu>
  Philippe Mathieu-Daudé <f4bug@amsat.org>
  Philippe Mathieu-Daudé <philmd@redhat.com>
  Richard Henderson <richard.henderson@linaro.org>
  Shuuichirou Ishii <ishii.shuuichir@fujitsu.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Taylor Simpson <tsimpson@quicinc.com>
  Thomas Huth <thuth@redhat.com>
  Tong Ho <tong.ho@xilinx.com>
  Travis Geiselbrecht <travisg@gmail.com>
  Vincent Palatin <vpalatin@rivosinc.com>
  Vivek Goyal <vgoyal@redhat.com>
  Xueming Li <xuemingl@nvidia.com>
  Yanan Wang <wangyanan55@huawei.com>
  Yifei Jiang <jiangyifei@huawei.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               fail    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          blocked 
 test-amd64-i386-xl                                           blocked 
 test-amd64-coresched-i386-xl                                 blocked 
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  blocked 
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       blocked 
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           blocked 
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     blocked 
 test-amd64-i386-freebsd10-amd64                              blocked 
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          blocked 
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          blocked 
 test-armhf-armhf-xl-arndale                                  blocked 
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  blocked 
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  blocked 
 test-armhf-armhf-xl-cubietruck                               blocked 
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         blocked 
 test-amd64-i386-freebsd10-i386                               blocked 
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         blocked 
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                blocked 
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         blocked 
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 blocked 
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    blocked 
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     blocked 
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              blocked 
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    blocked 
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      blocked 
 test-amd64-i386-xl-vhd                                       blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5374 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Oct 30 18:20:23 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 30 Oct 2021 18:20:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.218793.379373 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgsxB-0001kn-AI; Sat, 30 Oct 2021 18:19:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 218793.379373; Sat, 30 Oct 2021 18:19:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgsxB-0001kg-6l; Sat, 30 Oct 2021 18:19:41 +0000
Received: by outflank-mailman (input) for mailman id 218793;
 Sat, 30 Oct 2021 18:19:40 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mgsxA-0001kQ-3A; Sat, 30 Oct 2021 18:19:40 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mgsx9-00030p-R9; Sat, 30 Oct 2021 18:19:39 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mgsx9-00059G-G2; Sat, 30 Oct 2021 18:19:39 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mgsx9-0001CB-FV; Sat, 30 Oct 2021 18:19:39 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=HcYj5zGMvGtx98DvuY3I3oRH3mNqPg65q6C/pM+Sp+8=; b=q69ockskYgAAb97vsDwMFdXam5
	GqsiTPNy3vUwjiCV1t1Ya5fhh/x+z26U5LGLQBiw1XLeByVb9YO72Bg6DOPY6oOKgKmCd6/IgNqAQ
	baKewAQ30Ynpfh1lvWIf7M/1mG3Io7rGgsezUVdVX1EG+2z0Ht38q876qFsP0/Z95xdo=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165946-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 165946: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-unstable:test-armhf-armhf-xl-rtds:guest-start:fail:allowable
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=3030a73bf849a50411da95e94abf23cb7e8642fc
X-Osstest-Versions-That:
    xen=6f1d6682de832d12b728f856331e700a89737a1e
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 30 Oct 2021 18:19:39 +0000

flight 165946 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165946/

Failures :-/ but no regressions.

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds     14 guest-start              fail REGR. vs. 165941

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 165941
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 165941
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165941
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165941
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 165941
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 165941
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 165941
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 165941
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 165941
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 165941
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 165941
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165941
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 xen                  3030a73bf849a50411da95e94abf23cb7e8642fc
baseline version:
 xen                  6f1d6682de832d12b728f856331e700a89737a1e

Last test of basis   165941  2021-10-30 01:06:41 Z    0 days
Testing same since   165946  2021-10-30 10:36:57 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Stefano Stabellini <stefano.stabellini@xilinx.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   6f1d6682de..3030a73bf8  3030a73bf849a50411da95e94abf23cb7e8642fc -> master


From xen-devel-bounces@lists.xenproject.org Sat Oct 30 20:03:29 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 30 Oct 2021 20:03:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.218805.379398 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mguZK-0003aP-5o; Sat, 30 Oct 2021 20:03:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 218805.379398; Sat, 30 Oct 2021 20:03:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mguZK-0003aI-2o; Sat, 30 Oct 2021 20:03:10 +0000
Received: by outflank-mailman (input) for mailman id 218805;
 Sat, 30 Oct 2021 20:03:08 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mguZI-0003a8-7T; Sat, 30 Oct 2021 20:03:08 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mguZH-0004lq-Rp; Sat, 30 Oct 2021 20:03:07 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mguZH-0000Q1-FE; Sat, 30 Oct 2021 20:03:07 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mguZH-00085W-Eh; Sat, 30 Oct 2021 20:03:07 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=ZMIOSaXJ5kmXe5yGIIWCE29GtLPVYJIAmuORLVgxQHw=; b=owwdVX390TQnw1AVs+jPG+vOIX
	FYbVI5V6mE/tugLKnyL8SBhL+Ne4H+R+zp429X/UrXebfLzitfrXId/Bz0Lfz2Vk6M8FxjeG3F1ln
	VH6GSQiNMUlPZeZzhKl/O63VjPXrO3M9nspT6VcNpnJ3npr3jFN/BaX5KRn0ueRKPGfY=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165947-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 165947: regressions - FAIL
X-Osstest-Failures:
    qemu-mainline:build-i386-xsm:xen-build:fail:regression
    qemu-mainline:build-i386:xen-build:fail:regression
    qemu-mainline:build-armhf:xen-build:fail:regression
    qemu-mainline:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-amd:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-pair:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-freebsd10-i386:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-freebsd10-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-coresched-i386-xl:build-check(1):blocked:nonblocking
    qemu-mainline:build-armhf-libvirt:build-check(1):blocked:nonblocking
    qemu-mainline:build-i386-libvirt:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-intel:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-shadow:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-vhd:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=dd61b91c080cdfba1360a5ea1e4693fffb3445b0
X-Osstest-Versions-That:
    qemuu=50352cce138ef3b30c1cda28a4df68fff5da3202
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 30 Oct 2021 20:03:07 +0000

flight 165947 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165947/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-i386-xsm                6 xen-build                fail REGR. vs. 165682
 build-i386                    6 xen-build                fail REGR. vs. 165682
 build-armhf                   6 xen-build                fail REGR. vs. 165682

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl           1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-credit2   1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-cubietruck  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-multivcpu  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-rtds      1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-vhd       1 build-check(1)               blocked  n/a
 test-amd64-i386-qemuu-rhel6hvm-amd  1 build-check(1)               blocked n/a
 test-amd64-i386-pair          1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-freebsd10-i386  1 build-check(1)               blocked  n/a
 test-amd64-i386-freebsd10-amd64  1 build-check(1)               blocked  n/a
 test-amd64-coresched-i386-xl  1 build-check(1)               blocked  n/a
 build-armhf-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-arndale   1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-credit1   1 build-check(1)               blocked  n/a
 test-amd64-i386-qemuu-rhel6hvm-intel  1 build-check(1)             blocked n/a
 test-amd64-i386-xl            1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-pvshim     1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-qemuu-debianhvm-amd64  1 build-check(1)         blocked n/a
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow  1 build-check(1)  blocked n/a
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm  1 build-check(1)      blocked n/a
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 1 build-check(1) blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a
 test-amd64-i386-xl-qemuu-win7-amd64  1 build-check(1)              blocked n/a
 test-amd64-i386-xl-qemuu-ws16-amd64  1 build-check(1)              blocked n/a
 test-amd64-i386-xl-shadow     1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-vhd        1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-xsm        1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165682
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165682
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165682
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 qemuu                dd61b91c080cdfba1360a5ea1e4693fffb3445b0
baseline version:
 qemuu                50352cce138ef3b30c1cda28a4df68fff5da3202

Last test of basis   165682  2021-10-19 21:09:14 Z   10 days
Failing since        165694  2021-10-20 18:09:12 Z   10 days   25 attempts
Testing same since   165947  2021-10-30 12:39:31 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Alexey Baturo <baturo.alexey@gmail.com>
  Alexey Baturo <space.monkey.delivers@gmail.com>
  Alistair Francis <alistair.francis@wdc.com>
  Anatoly Parshintsev <kupokupokupopo@gmail.com>
  Andrew Jones <drjones@redhat.com>
  Ani Sinha <ani@anisinha.ca>
  BALATON Zoltan <balaton@eik.bme.hu>
  Bin Meng <bmeng.cn@gmail.com>
  Chenyi Qiang <chenyi.qiang@intel.com>
  Chih-Min Chao <chihmin.chao@sifive.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Cédric Le Goater <clg@kaod.org>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  David Gibson <david@gibson.dropbear.id.au>
  David Hildenbrand <david@redhat.com>
  Dr. David Alan Gilbert <dgilbert@redhat.com>
  Eduardo Habkost <ehabkost@redhat.com>
  Eric Auger <eric.auger@redhat.com>
  Eugenio Pérez <eperezma@redhat.com>
  Frank Chang <frank.chang@sifive.com>
  Frédéric Pétrot <frederic.petrot@univ-grenoble-alpes.fr>
  Gavin Shan <gshan@redhat.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Greg Kurz <groug@kaod.org>
  Gustavo Romero <gromero@linux.ibm.com>
  Igor Mammedov <imammedo@redhat.com>
  Jason Wang <jasowang@redhat.com>
  John Snow <jsnow@redhat.com>
  John Wang <wangzhiqiang02@inspur.com>
  John Wang <wangzq.jn@gmail.com>
  Jose Martins <josemartins90@gmail.com>
  Laurent Vivier <laurent@vivier.eu>
  Laurent Vivier <lvivier@redhat.com>
  Luc Michel <lmichel@kalray.eu>
  Luis Pires <luis.pires@eldorado.org.br>
  Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
  Markus Armbruster <armbru@redhat.com>
  Matheus Ferst <matheus.ferst@eldorado.org.br>
  Mathieu Poirier <mathieu.poirier@linaro.org>
  Michael S. Tsirkin <mst@redhat.com>
  Mingwang Li <limingwang@huawei.com>
  Oğuz Ersen <oguzersen@protonmail.com>
  Pavel Dovgalyuk <Pavel.Dovgalyuk@ispras.ru>
  Peter Krempa <pkrempa@redhat.com>
  Philipp Tomsich <philipp.tomsich@vrull.eu>
  Philippe Mathieu-Daudé <f4bug@amsat.org>
  Philippe Mathieu-Daudé <philmd@redhat.com>
  Richard Henderson <richard.henderson@linaro.org>
  Shuuichirou Ishii <ishii.shuuichir@fujitsu.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Taylor Simpson <tsimpson@quicinc.com>
  Thomas Huth <thuth@redhat.com>
  Tong Ho <tong.ho@xilinx.com>
  Travis Geiselbrecht <travisg@gmail.com>
  Vincent Palatin <vpalatin@rivosinc.com>
  Vivek Goyal <vgoyal@redhat.com>
  Xueming Li <xuemingl@nvidia.com>
  Yanan Wang <wangyanan55@huawei.com>
  Yifei Jiang <jiangyifei@huawei.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               fail    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          blocked 
 test-amd64-i386-xl                                           blocked 
 test-amd64-coresched-i386-xl                                 blocked 
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  blocked 
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       blocked 
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           blocked 
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     blocked 
 test-amd64-i386-freebsd10-amd64                              blocked 
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          blocked 
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          blocked 
 test-armhf-armhf-xl-arndale                                  blocked 
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  blocked 
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  blocked 
 test-armhf-armhf-xl-cubietruck                               blocked 
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         blocked 
 test-amd64-i386-freebsd10-i386                               blocked 
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         blocked 
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                blocked 
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         blocked 
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 blocked 
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    blocked 
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     blocked 
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              blocked 
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    blocked 
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      blocked 
 test-amd64-i386-xl-vhd                                       blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5608 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Oct 30 20:30:41 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 30 Oct 2021 20:30:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.218818.379413 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mguzf-0006l4-99; Sat, 30 Oct 2021 20:30:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 218818.379413; Sat, 30 Oct 2021 20:30:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mguzf-0006kx-65; Sat, 30 Oct 2021 20:30:23 +0000
Received: by outflank-mailman (input) for mailman id 218818;
 Sat, 30 Oct 2021 20:30:22 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mguze-0006kn-3l; Sat, 30 Oct 2021 20:30:22 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mguzd-0005Dk-V0; Sat, 30 Oct 2021 20:30:21 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mguzd-00014L-Ks; Sat, 30 Oct 2021 20:30:21 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mguzd-0006NB-KL; Sat, 30 Oct 2021 20:30:21 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=zXK67/tijakaXvUDcYFuqnM0w5ISs+n6PQ/7pz8rdIs=; b=vnlmnN+VnAfjaKH5xbXQ3vrSYi
	nmPh7jz1mXJaSPcwcsnGitWTA3RLc4UZ1EoP3C9LfEfVJ59MS4iFMtrFDNYtFB12fjJUuTi+sHtlx
	5myyafFc++aWADKmqJ/B+D+wt69Mw2dp9N9L4mWI58V/T6pklfubXttlnr3FECFukiK4=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165948-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 165948: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=e7663fdd82a2bf934c51b66f4af3e4479b131923
X-Osstest-Versions-That:
    ovmf=1bc232aae32e812341f10c9b938350cd93308eee
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 30 Oct 2021 20:30:21 +0000

flight 165948 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165948/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 e7663fdd82a2bf934c51b66f4af3e4479b131923
baseline version:
 ovmf                 1bc232aae32e812341f10c9b938350cd93308eee

Last test of basis   165934  2021-10-29 08:11:27 Z    1 days
Testing same since   165948  2021-10-30 15:11:20 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Guo Dong <guo.dong@intel.com>
  Kesavan Balakrishnan, ThiyaguX <thiyagux.kesavan.balakrishnan@intel.com>
  Thiyagu Kesavan Balakrishnan <thiyagux.kesavan.balakrishnan@intel.com>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   1bc232aae3..e7663fdd82  e7663fdd82a2bf934c51b66f4af3e4479b131923 -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Sun Oct 31 00:18:55 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 31 Oct 2021 00:18:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.218832.379426 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgyYQ-0001gu-OW; Sun, 31 Oct 2021 00:18:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 218832.379426; Sun, 31 Oct 2021 00:18:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgyYQ-0001gn-LR; Sun, 31 Oct 2021 00:18:30 +0000
Received: by outflank-mailman (input) for mailman id 218832;
 Sun, 31 Oct 2021 00:18:28 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mgyYO-0001gd-Hu; Sun, 31 Oct 2021 00:18:28 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mgyYO-0001NX-C1; Sun, 31 Oct 2021 00:18:28 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mgyYN-0002NZ-Va; Sun, 31 Oct 2021 00:18:28 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mgyYN-00077i-Uu; Sun, 31 Oct 2021 00:18:27 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=WEUSZxaOQ5XfMyjl5H70dKtXVvm4NfOp59PQswpTErk=; b=w2qMain33Qbmhf4SzKL6kU6ojH
	VklKEN8gY2okyveRX4uYy7pr/areaXcA68rjwclkuNBHizDP2Qe9PWdyM4m7lIcvl0Z9mlpK8ZOFo
	h980/or9sNe4oJeu3B8qEtS8zfWRm+EtRdQ2PKecNuRZqtdNs5fS2w27N2TDqNht/NGo=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165949-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 165949: regressions - FAIL
X-Osstest-Failures:
    qemu-mainline:build-i386-xsm:xen-build:fail:regression
    qemu-mainline:build-i386:xen-build:fail:regression
    qemu-mainline:build-armhf:xen-build:fail:regression
    qemu-mainline:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-amd:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-pair:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-freebsd10-i386:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-freebsd10-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-coresched-i386-xl:build-check(1):blocked:nonblocking
    qemu-mainline:build-armhf-libvirt:build-check(1):blocked:nonblocking
    qemu-mainline:build-i386-libvirt:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-intel:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-shadow:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-vhd:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=dd61b91c080cdfba1360a5ea1e4693fffb3445b0
X-Osstest-Versions-That:
    qemuu=50352cce138ef3b30c1cda28a4df68fff5da3202
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 31 Oct 2021 00:18:27 +0000

flight 165949 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165949/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-i386-xsm                6 xen-build                fail REGR. vs. 165682
 build-i386                    6 xen-build                fail REGR. vs. 165682
 build-armhf                   6 xen-build                fail REGR. vs. 165682

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl           1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-credit2   1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-cubietruck  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-multivcpu  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-rtds      1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-vhd       1 build-check(1)               blocked  n/a
 test-amd64-i386-qemuu-rhel6hvm-amd  1 build-check(1)               blocked n/a
 test-amd64-i386-pair          1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-freebsd10-i386  1 build-check(1)               blocked  n/a
 test-amd64-i386-freebsd10-amd64  1 build-check(1)               blocked  n/a
 test-amd64-coresched-i386-xl  1 build-check(1)               blocked  n/a
 build-armhf-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-arndale   1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-credit1   1 build-check(1)               blocked  n/a
 test-amd64-i386-qemuu-rhel6hvm-intel  1 build-check(1)             blocked n/a
 test-amd64-i386-xl            1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-pvshim     1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-qemuu-debianhvm-amd64  1 build-check(1)         blocked n/a
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow  1 build-check(1)  blocked n/a
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm  1 build-check(1)      blocked n/a
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 1 build-check(1) blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a
 test-amd64-i386-xl-qemuu-win7-amd64  1 build-check(1)              blocked n/a
 test-amd64-i386-xl-qemuu-ws16-amd64  1 build-check(1)              blocked n/a
 test-amd64-i386-xl-shadow     1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-vhd        1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-xsm        1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165682
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165682
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165682
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 qemuu                dd61b91c080cdfba1360a5ea1e4693fffb3445b0
baseline version:
 qemuu                50352cce138ef3b30c1cda28a4df68fff5da3202

Last test of basis   165682  2021-10-19 21:09:14 Z   11 days
Failing since        165694  2021-10-20 18:09:12 Z   10 days   26 attempts
Testing same since   165947  2021-10-30 12:39:31 Z    0 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
  Alexey Baturo <baturo.alexey@gmail.com>
  Alexey Baturo <space.monkey.delivers@gmail.com>
  Alistair Francis <alistair.francis@wdc.com>
  Anatoly Parshintsev <kupokupokupopo@gmail.com>
  Andrew Jones <drjones@redhat.com>
  Ani Sinha <ani@anisinha.ca>
  BALATON Zoltan <balaton@eik.bme.hu>
  Bin Meng <bmeng.cn@gmail.com>
  Chenyi Qiang <chenyi.qiang@intel.com>
  Chih-Min Chao <chihmin.chao@sifive.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Cédric Le Goater <clg@kaod.org>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  David Gibson <david@gibson.dropbear.id.au>
  David Hildenbrand <david@redhat.com>
  Dr. David Alan Gilbert <dgilbert@redhat.com>
  Eduardo Habkost <ehabkost@redhat.com>
  Eric Auger <eric.auger@redhat.com>
  Eugenio Pérez <eperezma@redhat.com>
  Frank Chang <frank.chang@sifive.com>
  Frédéric Pétrot <frederic.petrot@univ-grenoble-alpes.fr>
  Gavin Shan <gshan@redhat.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Greg Kurz <groug@kaod.org>
  Gustavo Romero <gromero@linux.ibm.com>
  Igor Mammedov <imammedo@redhat.com>
  Jason Wang <jasowang@redhat.com>
  John Snow <jsnow@redhat.com>
  John Wang <wangzhiqiang02@inspur.com>
  John Wang <wangzq.jn@gmail.com>
  Jose Martins <josemartins90@gmail.com>
  Laurent Vivier <laurent@vivier.eu>
  Laurent Vivier <lvivier@redhat.com>
  Luc Michel <lmichel@kalray.eu>
  Luis Pires <luis.pires@eldorado.org.br>
  Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
  Markus Armbruster <armbru@redhat.com>
  Matheus Ferst <matheus.ferst@eldorado.org.br>
  Mathieu Poirier <mathieu.poirier@linaro.org>
  Michael S. Tsirkin <mst@redhat.com>
  Mingwang Li <limingwang@huawei.com>
  Oğuz Ersen <oguzersen@protonmail.com>
  Pavel Dovgalyuk <Pavel.Dovgalyuk@ispras.ru>
  Peter Krempa <pkrempa@redhat.com>
  Philipp Tomsich <philipp.tomsich@vrull.eu>
  Philippe Mathieu-Daudé <f4bug@amsat.org>
  Philippe Mathieu-Daudé <philmd@redhat.com>
  Richard Henderson <richard.henderson@linaro.org>
  Shuuichirou Ishii <ishii.shuuichir@fujitsu.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Taylor Simpson <tsimpson@quicinc.com>
  Thomas Huth <thuth@redhat.com>
  Tong Ho <tong.ho@xilinx.com>
  Travis Geiselbrecht <travisg@gmail.com>
  Vincent Palatin <vpalatin@rivosinc.com>
  Vivek Goyal <vgoyal@redhat.com>
  Xueming Li <xuemingl@nvidia.com>
  Yanan Wang <wangyanan55@huawei.com>
  Yifei Jiang <jiangyifei@huawei.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               fail    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          blocked 
 test-amd64-i386-xl                                           blocked 
 test-amd64-coresched-i386-xl                                 blocked 
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  blocked 
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       blocked 
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           blocked 
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     blocked 
 test-amd64-i386-freebsd10-amd64                              blocked 
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          blocked 
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          blocked 
 test-armhf-armhf-xl-arndale                                  blocked 
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  blocked 
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  blocked 
 test-armhf-armhf-xl-cubietruck                               blocked 
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         blocked 
 test-amd64-i386-freebsd10-i386                               blocked 
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         blocked 
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                blocked 
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         blocked 
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 blocked 
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    blocked 
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     blocked 
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              blocked 
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    blocked 
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      blocked 
 test-amd64-i386-xl-vhd                                       blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 5608 lines long.)


From xen-devel-bounces@lists.xenproject.org Sun Oct 31 00:40:51 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 31 Oct 2021 00:40:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.218840.379441 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgytu-0004q2-SL; Sun, 31 Oct 2021 00:40:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 218840.379441; Sun, 31 Oct 2021 00:40:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mgytu-0004pv-Oj; Sun, 31 Oct 2021 00:40:42 +0000
Received: by outflank-mailman (input) for mailman id 218840;
 Sun, 31 Oct 2021 00:40:42 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mgytt-0004pj-Vn; Sun, 31 Oct 2021 00:40:41 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mgytt-0001iY-Ng; Sun, 31 Oct 2021 00:40:41 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mgytt-0003Yu-FJ; Sun, 31 Oct 2021 00:40:41 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mgytt-00086B-Eo; Sun, 31 Oct 2021 00:40:41 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=aE1XOUqbTWcXyYElAfETfhAWYApUhzBWz4FgQ6vtf40=; b=7GgvCjXaCrKXtsV0/LatI+fF+0
	L/9T1YrDhgSpnJ1z6PdjEKWuTwi6YCnW3jVHJcxF2V2izxtFXkdYlL4K1PKNBtN/zE+Vt30QL5OsI
	3ouwAEnW4wlbZlRDHmCaN9ix1/ToWnyBMeehkV6qySsr7Xzq0LPKJezUSmflCrby09T0=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165950-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 165950: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=91b772ab626913bf740e9e1b20387b25bcb2de97
X-Osstest-Versions-That:
    ovmf=e7663fdd82a2bf934c51b66f4af3e4479b131923
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 31 Oct 2021 00:40:41 +0000

flight 165950 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165950/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 91b772ab626913bf740e9e1b20387b25bcb2de97
baseline version:
 ovmf                 e7663fdd82a2bf934c51b66f4af3e4479b131923

Last test of basis   165948  2021-10-30 15:11:20 Z    0 days
Testing same since   165950  2021-10-30 20:41:07 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abner Chang <abner.chang@hpe.com>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   e7663fdd82..91b772ab62  91b772ab626913bf740e9e1b20387b25bcb2de97 -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Sun Oct 31 05:25:06 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 31 Oct 2021 05:25:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.218850.379455 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mh3Kd-00076D-Ij; Sun, 31 Oct 2021 05:24:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 218850.379455; Sun, 31 Oct 2021 05:24:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mh3Kd-00075k-B0; Sun, 31 Oct 2021 05:24:35 +0000
Received: by outflank-mailman (input) for mailman id 218850;
 Sun, 31 Oct 2021 05:24:33 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mh3Kb-00075a-TM; Sun, 31 Oct 2021 05:24:33 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mh3Kb-0000Jw-KC; Sun, 31 Oct 2021 05:24:33 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mh3Kb-0000Co-7Y; Sun, 31 Oct 2021 05:24:33 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mh3Kb-0008Fq-6r; Sun, 31 Oct 2021 05:24:33 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=Bg4g/yLkasRtR9wj9R39bffu6Re6kulAIxSGEKIaOCM=; b=S1x0t86vSUz3BbGvT4JmiBsr/j
	CO+3RDhCEFAbSLdF3dP4GCo2SLBF7b8sSfJH6XmU2l5CFAwO00j06yn7Svkd8PRWOWYkK2b6fQSpj
	jWcz3HX+r10r1mVaBBBCll7FAjLJhfNLt6uINgGJkcfDfg0CuO2tY1SPtrWilXz5gC6c=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165951-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 165951: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-xl-shadow:guest-start/debian.repeat:fail:heisenbug
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=3a4347d82efdfcc5465b3ed37616426989182915
X-Osstest-Versions-That:
    linux=119c85055d867b9588263bca59794c872ef2a30e
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 31 Oct 2021 05:24:33 +0000

flight 165951 linux-linus real [real]
flight 165954 linux-linus real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/165951/
http://logs.test-lab.xenproject.org/osstest/logs/165954/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-xl-shadow 22 guest-start/debian.repeat fail pass in 165954-retest

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 165942
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 165942
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165942
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 165942
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165942
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 165942
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 165942
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165942
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass

version targeted for testing:
 linux                3a4347d82efdfcc5465b3ed37616426989182915
baseline version:
 linux                119c85055d867b9588263bca59794c872ef2a30e

Last test of basis   165942  2021-10-30 02:25:07 Z    1 days
Testing same since   165951  2021-10-30 21:09:19 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Alex Bee <knaerzche@gmail.com>
  Alexandre Ghiti <alexandre.ghiti@canonical.com>
  Chen Lu <181250012@smail.nju.edu.cn>
  Chen-Yu Tsai <wens@csie.org>
  Linus Torvalds <torvalds@linux-foundation.org>
  Martin Blumenstingl <martin.blumenstingl@googlemail.com>
  Palmer Dabbelt <palmerdabbelt@google.com>
  Stephen Boyd <sboyd@kernel.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   fail    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   119c85055d86..3a4347d82efd  3a4347d82efdfcc5465b3ed37616426989182915 -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Sun Oct 31 06:15:36 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 31 Oct 2021 06:15:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.218858.379469 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mh47p-0003cI-AQ; Sun, 31 Oct 2021 06:15:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 218858.379469; Sun, 31 Oct 2021 06:15:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mh47p-0003cB-73; Sun, 31 Oct 2021 06:15:25 +0000
Received: by outflank-mailman (input) for mailman id 218858;
 Sun, 31 Oct 2021 06:15:23 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mh47n-0003c1-Rr; Sun, 31 Oct 2021 06:15:23 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mh47n-0001E2-JJ; Sun, 31 Oct 2021 06:15:23 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mh47n-0002Ld-81; Sun, 31 Oct 2021 06:15:23 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mh47n-0001ci-7X; Sun, 31 Oct 2021 06:15:23 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=cHOC2QkpGjyT9AdaDATTAkJJtQS5LnPMfYw0hQfREEc=; b=OHt4pBJ3b5fKRxnHWEnyzh7dy/
	rItnw2rgP6y2/vi64oOwPGiHZvzrcv6xprzy0Q9FARfVST36Vu3QI9dZSHiEfrcFG03MluUx7jbrX
	m7HrX9Nb+KvwJuItUyapbeHjwM/07/AoARGcL26aqW9gZP2lNdyLSkDAHiH0ZZXsLbms=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165952-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 165952: regressions - FAIL
X-Osstest-Failures:
    qemu-mainline:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression
    qemu-mainline:build-i386-xsm:xen-build:fail:regression
    qemu-mainline:build-i386:xen-build:fail:regression
    qemu-mainline:build-armhf:xen-build:fail:regression
    qemu-mainline:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-amd:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-pair:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-freebsd10-i386:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-freebsd10-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-coresched-i386-xl:build-check(1):blocked:nonblocking
    qemu-mainline:build-armhf-libvirt:build-check(1):blocked:nonblocking
    qemu-mainline:build-i386-libvirt:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-intel:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-shadow:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-vhd:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=af531756d25541a1b3b3d9a14e72e7fedd941a2e
X-Osstest-Versions-That:
    qemuu=50352cce138ef3b30c1cda28a4df68fff5da3202
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 31 Oct 2021 06:15:23 +0000

flight 165952 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165952/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-arm64-arm64-libvirt-raw  8 xen-boot                 fail REGR. vs. 165682
 build-i386-xsm                6 xen-build                fail REGR. vs. 165682
 build-i386                    6 xen-build                fail REGR. vs. 165682
 build-armhf                   6 xen-build                fail REGR. vs. 165682

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl           1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-credit2   1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-cubietruck  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-multivcpu  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-rtds      1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-vhd       1 build-check(1)               blocked  n/a
 test-amd64-i386-qemuu-rhel6hvm-amd  1 build-check(1)               blocked n/a
 test-amd64-i386-pair          1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-freebsd10-i386  1 build-check(1)               blocked  n/a
 test-amd64-i386-freebsd10-amd64  1 build-check(1)               blocked  n/a
 test-amd64-coresched-i386-xl  1 build-check(1)               blocked  n/a
 build-armhf-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-credit1   1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-arndale   1 build-check(1)               blocked  n/a
 test-amd64-i386-qemuu-rhel6hvm-intel  1 build-check(1)             blocked n/a
 test-amd64-i386-xl            1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-pvshim     1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-qemuu-debianhvm-amd64  1 build-check(1)         blocked n/a
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow  1 build-check(1)  blocked n/a
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm  1 build-check(1)      blocked n/a
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 1 build-check(1) blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a
 test-amd64-i386-xl-qemuu-win7-amd64  1 build-check(1)              blocked n/a
 test-amd64-i386-xl-qemuu-ws16-amd64  1 build-check(1)              blocked n/a
 test-amd64-i386-xl-shadow     1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-vhd        1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-xsm        1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165682
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165682
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165682
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 qemuu                af531756d25541a1b3b3d9a14e72e7fedd941a2e
baseline version:
 qemuu                50352cce138ef3b30c1cda28a4df68fff5da3202

Last test of basis   165682  2021-10-19 21:09:14 Z   11 days
Failing since        165694  2021-10-20 18:09:12 Z   10 days   27 attempts
Testing same since   165952  2021-10-31 00:39:26 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Alexey Baturo <baturo.alexey@gmail.com>
  Alexey Baturo <space.monkey.delivers@gmail.com>
  Alistair Francis <alistair.francis@wdc.com>
  Anatoly Parshintsev <kupokupokupopo@gmail.com>
  Andrew Jones <drjones@redhat.com>
  Ani Sinha <ani@anisinha.ca>
  BALATON Zoltan <balaton@eik.bme.hu>
  Bin Meng <bmeng.cn@gmail.com>
  Chenyi Qiang <chenyi.qiang@intel.com>
  Chih-Min Chao <chihmin.chao@sifive.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Cédric Le Goater <clg@kaod.org>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  David Gibson <david@gibson.dropbear.id.au>
  David Hildenbrand <david@redhat.com>
  Dr. David Alan Gilbert <dgilbert@redhat.com>
  Eduardo Habkost <ehabkost@redhat.com>
  Eric Auger <eric.auger@redhat.com>
  Eugenio Pérez <eperezma@redhat.com>
  Frank Chang <frank.chang@sifive.com>
  Frédéric Pétrot <frederic.petrot@univ-grenoble-alpes.fr>
  Gavin Shan <gshan@redhat.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Greg Kurz <groug@kaod.org>
  Gustavo Romero <gromero@linux.ibm.com>
  Igor Mammedov <imammedo@redhat.com>
  Jason Wang <jasowang@redhat.com>
  John Snow <jsnow@redhat.com>
  John Wang <wangzhiqiang02@inspur.com>
  John Wang <wangzq.jn@gmail.com>
  Jose Martins <josemartins90@gmail.com>
  Laurent Vivier <laurent@vivier.eu>
  Laurent Vivier <lvivier@redhat.com>
  Luc Michel <lmichel@kalray.eu>
  Luis Pires <luis.pires@eldorado.org.br>
  Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
  Markus Armbruster <armbru@redhat.com>
  Matheus Ferst <matheus.ferst@eldorado.org.br>
  Mathieu Poirier <mathieu.poirier@linaro.org>
  Michael S. Tsirkin <mst@redhat.com>
  Mingwang Li <limingwang@huawei.com>
  Oğuz Ersen <oguzersen@protonmail.com>
  Pavel Dovgalyuk <Pavel.Dovgalyuk@ispras.ru>
  Peter Krempa <pkrempa@redhat.com>
  Philipp Tomsich <philipp.tomsich@vrull.eu>
  Philippe Mathieu-Daudé <f4bug@amsat.org>
  Philippe Mathieu-Daudé <philmd@redhat.com>
  Richard Henderson <richard.henderson@linaro.org>
  Shuuichirou Ishii <ishii.shuuichir@fujitsu.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Taylor Simpson <tsimpson@quicinc.com>
  Thomas Huth <thuth@redhat.com>
  Tong Ho <tong.ho@xilinx.com>
  Travis Geiselbrecht <travisg@gmail.com>
  Vincent Palatin <vpalatin@rivosinc.com>
  Vivek Goyal <vgoyal@redhat.com>
  Xueming Li <xuemingl@nvidia.com>
  Yanan Wang <wangyanan55@huawei.com>
  Yifei Jiang <jiangyifei@huawei.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               fail    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          blocked 
 test-amd64-i386-xl                                           blocked 
 test-amd64-coresched-i386-xl                                 blocked 
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  blocked 
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       blocked 
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           blocked 
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     blocked 
 test-amd64-i386-freebsd10-amd64                              blocked 
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          blocked 
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          blocked 
 test-armhf-armhf-xl-arndale                                  blocked 
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  blocked 
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  blocked 
 test-armhf-armhf-xl-cubietruck                               blocked 
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         blocked 
 test-amd64-i386-freebsd10-i386                               blocked 
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         blocked 
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                blocked 
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         blocked 
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 blocked 
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    blocked 
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 fail    
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     blocked 
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              blocked 
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    blocked 
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      blocked 
 test-amd64-i386-xl-vhd                                       blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 6076 lines long.)


From xen-devel-bounces@lists.xenproject.org Sun Oct 31 06:58:13 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 31 Oct 2021 06:58:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.218868.379486 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mh4mw-0007jj-J4; Sun, 31 Oct 2021 06:57:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 218868.379486; Sun, 31 Oct 2021 06:57:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mh4mw-0007jc-FV; Sun, 31 Oct 2021 06:57:54 +0000
Received: by outflank-mailman (input) for mailman id 218868;
 Sun, 31 Oct 2021 06:57:52 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mh4mu-0007jS-Qy; Sun, 31 Oct 2021 06:57:52 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mh4mu-0001uE-Lo; Sun, 31 Oct 2021 06:57:52 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mh4mu-0003xk-BT; Sun, 31 Oct 2021 06:57:52 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mh4mu-0003QJ-B0; Sun, 31 Oct 2021 06:57:52 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=FKBNQn6kZDJ7emnU1+dJ5VYcq4Z3fnBD/OgHnGbz9cA=; b=fvFajDy74QvP7BLhEWRXC+UmqL
	uNJ8pQGPWENA67P2T5zNNNW7gbPDmQXAxev32l/dI1vcfSXK99qaIKAHD1XDNszACuxKeIhfSm2dr
	xwftT0zrspieQdBDEIAo6JdrbNP28yXQjRXhGS/jH8NENw48fqAn8jjOFQl11x5WcSpM=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165955-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 165955: regressions - FAIL
X-Osstest-Failures:
    libvirt:build-armhf-libvirt:libvirt-build:fail:regression
    libvirt:build-amd64-libvirt:libvirt-build:fail:regression
    libvirt:build-i386-libvirt:libvirt-build:fail:regression
    libvirt:build-arm64-libvirt:libvirt-build:fail:regression
    libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    libvirt=301eb149cef569d4fb3a662bd9ef2460fb7c5e3b
X-Osstest-Versions-That:
    libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 31 Oct 2021 06:57:52 +0000

flight 165955 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165955/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-armhf-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-amd64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-i386-libvirt            6 libvirt-build            fail REGR. vs. 151777
 build-arm64-libvirt           6 libvirt-build            fail REGR. vs. 151777

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-libvirt-vhd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a

version targeted for testing:
 libvirt              301eb149cef569d4fb3a662bd9ef2460fb7c5e3b
baseline version:
 libvirt              2c846fa6bcc11929c9fb857a22430fb9945654ad

Last test of basis   151777  2020-07-10 04:19:19 Z  478 days
Failing since        151818  2020-07-11 04:18:52 Z  477 days  463 attempts
Testing same since   165944  2021-10-30 04:20:11 Z    1 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
    Adolfo Jayme Barrientos <fitoschido@gmail.com>
  Aleksandr Alekseev <alexander.alekseev@virtuozzo.com>
  Aleksei Zakharov <zaharov@selectel.ru>
  Andika Triwidada <andika@gmail.com>
  Andrea Bolognani <abologna@redhat.com>
  Ani Sinha <ani@anisinha.ca>
  Balázs Meskó <meskobalazs@mailbox.org>
  Barrett Schonefeld <bschoney@utexas.edu>
  Bastian Germann <bastiangermann@fishpost.de>
  Bastien Orivel <bastien.orivel@diateam.net>
  BiaoXiang Ye <yebiaoxiang@huawei.com>
  Bihong Yu <yubihong@huawei.com>
  Binfeng Wu <wubinfeng@huawei.com>
  Bjoern Walk <bwalk@linux.ibm.com>
  Boris Fiuczynski <fiuczy@linux.ibm.com>
  Brian Turek <brian.turek@gmail.com>
  Bruno Haible <bruno@clisp.org>
  Chris Mayo <aklhfex@gmail.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Ehrhardt <christian.ehrhardt@canonical.com>
  Christian Kirbach <christian.kirbach@gmail.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Cole Robinson <crobinso@redhat.com>
  Collin Walling <walling@linux.ibm.com>
  Cornelia Huck <cohuck@redhat.com>
  Cédric Bosdonnat <cbosdonnat@suse.com>
  Côme Borsoi <fedora@borsoi.fr>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniel Letai <dani@letai.org.il>
  Daniel P. Berrange <berrange@redhat.com>
  Daniel P. Berrangé <berrange@redhat.com>
  Didik Supriadi <didiksupriadi41@gmail.com>
  dinglimin <dinglimin@cmss.chinamobile.com>
  Dmitrii Shcherbakov <dmitrii.shcherbakov@canonical.com>
  Dmytro Linkin <dlinkin@nvidia.com>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Eric Farman <farman@linux.ibm.com>
  Erik Skultety <eskultet@redhat.com>
  Fabian Affolter <mail@fabian-affolter.ch>
  Fabian Freyer <fabian.freyer@physik.tu-berlin.de>
  Fabiano Fidêncio <fabiano@fidencio.org>
  Fangge Jin <fjin@redhat.com>
  Farhan Ali <alifm@linux.ibm.com>
  Fedora Weblate Translation <i18n@lists.fedoraproject.org>
  Franck Ridel <fridel@protonmail.com>
  Gavi Teitz <gavi@nvidia.com>
  gongwei <gongwei@smartx.com>
  Guoyi Tu<tu.guoyi@h3c.com>
  Göran Uddeborg <goeran@uddeborg.se>
  Halil Pasic <pasic@linux.ibm.com>
  Han Han <hhan@redhat.com>
  Hao Wang <wanghao232@huawei.com>
  Hela Basa <r45xveza@pm.me>
  Helmut Grohne <helmut@subdivi.de>
  Hiroki Narukawa <hnarukaw@yahoo-corp.jp>
  Ian Wienand <iwienand@redhat.com>
  Jakob Meng <jakobmeng@web.de>
  Jamie Strandboge <jamie@canonical.com>
  Jamie Strandboge <jamie@ubuntu.com>
  Jan Kuparinen <copper_fin@hotmail.com>
  jason lee <ppark5237@gmail.com>
  Jean-Baptiste Holcroft <jean-baptiste@holcroft.fr>
  Jia Zhou <zhou.jia2@zte.com.cn>
  Jianan Gao <jgao@redhat.com>
  Jim Fehlig <jfehlig@suse.com>
  Jin Yan <jinyan12@huawei.com>
  Jinsheng Zhang <zhangjl02@inspur.com>
  Jiri Denemark <jdenemar@redhat.com>
  John Ferlan <jferlan@redhat.com>
  Jonathan Watt <jwatt@jwatt.org>
  Jonathon Jongsma <jjongsma@redhat.com>
  Julio Faracco <jcfaracco@gmail.com>
  Justin Gatzen <justin.gatzen@gmail.com>
  Ján Tomko <jtomko@redhat.com>
  Kashyap Chamarthy <kchamart@redhat.com>
  Kevin Locke <kevin@kevinlocke.name>
  Kristina Hanicova <khanicov@redhat.com>
  Laine Stump <laine@redhat.com>
  Laszlo Ersek <lersek@redhat.com>
  Lee Yarwood <lyarwood@redhat.com>
  Lei Yang <yanglei209@huawei.com>
  Liao Pingfang <liao.pingfang@zte.com.cn>
  Lin Ma <lma@suse.com>
  Lin Ma <lma@suse.de>
  Lin Ma <morecache@gmail.com>
  Liu Yiding <liuyd.fnst@fujitsu.com>
  Luke Yue <lukedyue@gmail.com>
  Luyao Zhong <luyao.zhong@intel.com>
  Marc Hartmayer <mhartmay@linux.ibm.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Markus Schade <markus.schade@hetzner.com>
  Martin Kletzander <mkletzan@redhat.com>
  Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
  Matej Cepl <mcepl@cepl.eu>
  Matt Coleman <matt@datto.com>
  Matt Coleman <mcoleman@datto.com>
  Mauro Matteo Cascella <mcascell@redhat.com>
  Meina Li <meili@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Michał Smyk <fedora@smyk.it>
  Milo Casagrande <milo@milo.name>
  Moshe Levi <moshele@nvidia.com>
  Muha Aliss <muhaaliss@gmail.com>
  Nathan <nathan95@live.it>
  Neal Gompa <ngompa13@gmail.com>
  Nick Chevsky <nchevsky@gmail.com>
  Nick Shyrokovskiy <nshyrokovskiy@gmail.com>
  Nickys Music Group <nickys.music.group@gmail.com>
  Nico Pache <npache@redhat.com>
  Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
  Olaf Hering <olaf@aepfle.de>
  Olesya Gerasimenko <gammaray@basealt.ru>
  Or Ozeri <oro@il.ibm.com>
  Orion Poplawski <orion@nwra.com>
  Pany <geekpany@gmail.com>
  Patrick Magauran <patmagauran.j@gmail.com>
  Paulo de Rezende Pinatti <ppinatti@linux.ibm.com>
  Pavel Hrdina <phrdina@redhat.com>
  Peng Liang <liangpeng10@huawei.com>
  Peter Krempa <pkrempa@redhat.com>
  Pino Toscano <ptoscano@redhat.com>
  Pino Toscano <toscano.pino@tiscali.it>
  Piotr Drąg <piotrdrag@gmail.com>
  Prathamesh Chavan <pc44800@gmail.com>
  Praveen K Paladugu <prapal@linux.microsoft.com>
  Richard W.M. Jones <rjones@redhat.com>
  Ricky Tigg <ricky.tigg@gmail.com>
  Robin Lee <cheeselee@fedoraproject.org>
  Roman Bogorodskiy <bogorodskiy@gmail.com>
  Roman Bolshakov <r.bolshakov@yadro.com>
  Ryan Gahagan <rgahagan@cs.utexas.edu>
  Ryan Schmidt <git@ryandesign.com>
  Sam Hartman <hartmans@debian.org>
  Scott Shambarger <scott-libvirt@shambarger.net>
  Sebastian Mitterle <smitterl@redhat.com>
  SeongHyun Jo <caelus9536@gmail.com>
  Shalini Chellathurai Saroja <shalini@linux.ibm.com>
  Shaojun Yang <yangshaojun@phytium.com.cn>
  Shi Lei <shi_lei@massclouds.com>
  simmon <simmon@nplob.com>
  Simon Chopin <chopin.simon@gmail.com>
  Simon Gaiser <simon@invisiblethingslab.com>
  Simon Rowe <simon.rowe@nutanix.com>
  Stefan Bader <stefan.bader@canonical.com>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Berger <stefanb@linux.vnet.ibm.com>
  Stefan Hajnoczi <stefanha@gmail.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Szymon Scholz <szymonscholz@gmail.com>
  Thomas Huth <thuth@redhat.com>
  Tim Wiederhake <twiederh@redhat.com>
  Tomáš Golembiovský <tgolembi@redhat.com>
  Tomáš Janoušek <tomi@nomi.cz>
  Tuguoyi <tu.guoyi@h3c.com>
  Victor Toso <victortoso@redhat.com>
  Ville Skyttä <ville.skytta@iki.fi>
  Vinayak Kale <vkale@nvidia.com>
  Wang Xin <wangxinxin.wang@huawei.com>
  WangJian <wangjian161@huawei.com>
  Weblate <noreply@weblate.org>
  Wei Liu <liuwe@microsoft.com>
  Wei Liu <wei.liu@kernel.org>
  Wei-Chen Chen <weicche@microsoft.com>
  William Douglas <william.douglas@intel.com>
  Yalei Li <274268859@qq.com>
  Yalei Li <liyl43@chinatelecom.cn>
  Yang Fei <yangfei85@huawei.com>
  Yang Hang <yanghang44@huawei.com>
  Yanqiu Zhang <yanqzhan@redhat.com>
  Yaroslav Kargin <ykargin@virtuozzo.com>
  Yi Li <yili@winhong.com>
  Yi Wang <wang.yi59@zte.com.cn>
  Yuri Chornoivan <yurchor@ukr.net>
  Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
  zhangjl02 <zhangjl02@inspur.com>
  Zheng Chuan <zhengchuan@huawei.com>
  zhenwei pi <pizhenwei@bytedance.com>
  Zhenyu Ye <yezhenyu2@huawei.com>
  Zhenyu Zheng <zheng.zhenyu@outlook.com>
  Zhenzhong Duan <zhenzhong.duan@intel.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          fail    
 build-arm64-libvirt                                          fail    
 build-armhf-libvirt                                          fail    
 build-i386-libvirt                                           fail    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           blocked 
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-libvirt-xsm                                 blocked 
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-libvirt                                     blocked 
 test-arm64-arm64-libvirt                                     blocked 
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-libvirt-pair                                blocked 
 test-amd64-i386-libvirt-pair                                 blocked 
 test-arm64-arm64-libvirt-qcow2                               blocked 
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-libvirt-vhd                                 blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 81290 lines long.)


From xen-devel-bounces@lists.xenproject.org Sun Oct 31 09:52:18 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 31 Oct 2021 09:52:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.218885.379509 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mh7VD-0007Me-Bn; Sun, 31 Oct 2021 09:51:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 218885.379509; Sun, 31 Oct 2021 09:51:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mh7VD-0007MX-8l; Sun, 31 Oct 2021 09:51:47 +0000
Received: by outflank-mailman (input) for mailman id 218885;
 Sun, 31 Oct 2021 09:51:46 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mh7VC-0007MN-2R; Sun, 31 Oct 2021 09:51:46 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mh7VB-0005Cy-Pz; Sun, 31 Oct 2021 09:51:45 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mh7VB-0007BC-Gv; Sun, 31 Oct 2021 09:51:45 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mh7VB-0001Aq-GR; Sun, 31 Oct 2021 09:51:45 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=ejNykp6iBPMW+5vHQKgOeCvxVmlVl6VOGBb65M1JKAk=; b=w0NtnqGf2HJeuyLFPYWi/AAn6F
	q3fT2tQ0Uml0yQqFFFufZPt4NvBWBcxoKrXPFqC3rS/S03iHyLjKj4YMPdzu1uP+GnKvVqGV2NNsr
	5zGTqHFzJTVKHsWDmQH4oEztRd9NkZsBk+vRCQxUH9bo/XFj4jRAy2oTzm6OVko/dntY=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165960-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-coverity test] 165960: all pass - PUSHED
X-Osstest-Versions-This:
    xen=3030a73bf849a50411da95e94abf23cb7e8642fc
X-Osstest-Versions-That:
    xen=b0fce57a6a491c120f2554ad7cc9a0c43ee5defa
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 31 Oct 2021 09:51:45 +0000

flight 165960 xen-unstable-coverity real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165960/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 xen                  3030a73bf849a50411da95e94abf23cb7e8642fc
baseline version:
 xen                  b0fce57a6a491c120f2554ad7cc9a0c43ee5defa

Last test of basis   165895  2021-10-27 09:18:35 Z    4 days
Testing same since   165960  2021-10-31 09:19:38 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Roger Pau Monne <roger.pau@citrix.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Stefano Stabellini <stefano.stabellini@xilinx.com>

jobs:
 coverity-amd64                                               pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   b0fce57a6a..3030a73bf8  3030a73bf849a50411da95e94abf23cb7e8642fc -> coverity-tested/smoke


From xen-devel-bounces@lists.xenproject.org Sun Oct 31 11:20:13 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 31 Oct 2021 11:20:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.218896.379523 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mh8sP-0006XW-E2; Sun, 31 Oct 2021 11:19:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 218896.379523; Sun, 31 Oct 2021 11:19:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mh8sP-0006XP-AW; Sun, 31 Oct 2021 11:19:49 +0000
Received: by outflank-mailman (input) for mailman id 218896;
 Sun, 31 Oct 2021 11:19:48 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mh8sO-0006XF-Bh; Sun, 31 Oct 2021 11:19:48 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mh8sO-0006hF-3t; Sun, 31 Oct 2021 11:19:48 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mh8sN-0002wa-NO; Sun, 31 Oct 2021 11:19:47 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mh8sN-000785-Mv; Sun, 31 Oct 2021 11:19:47 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=pPFWBzxWWG0mcQGvNGJktg0f3aDS7vio7kiN9jIMLAU=; b=kx1lgDHbeIyOO2mLlKsZATX0Rq
	0n607b5DU0VYguF9CULua+agcxrvg1lLw3hgUdhfMW/IFbGJyNwiKuwiXDGdFYwQLqHZLyBey9fk/
	hzZ0MIT0LFnFAILQiUk3CVYn/ZK0bTqugE8TJt6Iyd707kxyOzjJ6KHNbgaKNbKK8hwk=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165953-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 165953: tolerable FAIL
X-Osstest-Failures:
    xen-unstable:test-armhf-armhf-xl-rtds:guest-start:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:heisenbug
    xen-unstable:test-arm64-arm64-libvirt-raw:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=3030a73bf849a50411da95e94abf23cb7e8642fc
X-Osstest-Versions-That:
    xen=3030a73bf849a50411da95e94abf23cb7e8642fc
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 31 Oct 2021 11:19:47 +0000

flight 165953 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165953/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-armhf-armhf-xl-rtds     14 guest-start      fail in 165946 pass in 165953
 test-amd64-amd64-xl-rtds     20 guest-localmigrate/x10     fail pass in 165946
 test-arm64-arm64-libvirt-raw 17 guest-start/debian.repeat  fail pass in 165946

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 165946
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 165946
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165946
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165946
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 165946
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 165946
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 165946
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 165946
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 165946
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 165946
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 165946
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165946
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 xen                  3030a73bf849a50411da95e94abf23cb7e8642fc
baseline version:
 xen                  3030a73bf849a50411da95e94abf23cb7e8642fc

Last test of basis   165953  2021-10-31 01:52:53 Z    0 days
Testing same since                          (not found)         0 attempts

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 fail    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     fail    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Published tested tree is already up to date.



From xen-devel-bounces@lists.xenproject.org Sun Oct 31 13:03:33 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 31 Oct 2021 13:03:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.218905.379536 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mhAU5-0008Dt-3J; Sun, 31 Oct 2021 13:02:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 218905.379536; Sun, 31 Oct 2021 13:02:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mhAU5-0008Dm-0F; Sun, 31 Oct 2021 13:02:49 +0000
Received: by outflank-mailman (input) for mailman id 218905;
 Sun, 31 Oct 2021 13:02:48 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mhAU4-0008Da-EU; Sun, 31 Oct 2021 13:02:48 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mhAU4-0008Rq-6g; Sun, 31 Oct 2021 13:02:48 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mhAU3-00074V-SA; Sun, 31 Oct 2021 13:02:47 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mhAU3-00060P-Rf; Sun, 31 Oct 2021 13:02:47 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=o61uiFrtVBiwpujhBl4sXpYL8EcolkDZUgXA2di63sU=; b=LMaC7Qo/i61OOKL0IrgFZGMn7+
	VnNIOZgia3Dwsk6Lug0rUXCLerXA1DSdilwOYoNOJATTs1XFTYgLnwRVYz6W2m2D+2Ztyt6hZp0no
	yd/w6uOzyQ2JajzgJhejZFmiQhau59MVIay3ec5PmCMyKz493PeDsPZfw8NLWk1dVrKg=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165956-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 165956: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=180eca540ae06246d594bdd8d8213426a259cc8c
X-Osstest-Versions-That:
    linux=3a4347d82efdfcc5465b3ed37616426989182915
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 31 Oct 2021 13:02:47 +0000

flight 165956 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165956/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 165951
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 165951
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165951
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 165951
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165951
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 165951
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 165951
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165951
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass

version targeted for testing:
 linux                180eca540ae06246d594bdd8d8213426a259cc8c
baseline version:
 linux                3a4347d82efdfcc5465b3ed37616426989182915

Last test of basis   165951  2021-10-30 21:09:19 Z    0 days
Testing same since   165956  2021-10-31 05:28:15 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Avri Altman <avri.altman@wdc.com>
  Bean Huo <beanhuo@micron.com>
  Brian King <brking@linux.vnet.ibm.com>
  Chanho Park <chanho61.park@samsung.com>
  James Bottomley <James.Bottomley@HansenPartnership.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Martin K. Petersen <martin.petersen@oracle.com>
  Tyrel Datwyler <tyreld@linux.ibm.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   3a4347d82efd..180eca540ae0  180eca540ae06246d594bdd8d8213426a259cc8c -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Sun Oct 31 15:38:15 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 31 Oct 2021 15:38:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.218913.379551 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mhCtz-0004qw-Oq; Sun, 31 Oct 2021 15:37:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 218913.379551; Sun, 31 Oct 2021 15:37:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mhCtz-0004qp-Ld; Sun, 31 Oct 2021 15:37:43 +0000
Received: by outflank-mailman (input) for mailman id 218913;
 Sun, 31 Oct 2021 15:37:42 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mhCtx-0004qf-VP; Sun, 31 Oct 2021 15:37:41 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mhCtx-0002ak-Jn; Sun, 31 Oct 2021 15:37:41 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mhCtx-0002H8-7n; Sun, 31 Oct 2021 15:37:41 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mhCtx-0007yd-7H; Sun, 31 Oct 2021 15:37:41 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=akTA1QA8H35K8xJ9XtB41dSIkTeEWxbtAQap4kdL1vw=; b=oj6F+wh1TVNZAL0NoJwCFdjXhS
	+KmE25v2u6Z1RJrJYZxapr/HxC5gSrSLY17lRenYR8qO9goq9NWqzEk+RINqZPuhTq22pLD9nLwek
	XxEpoBz5bW4+96pf0BGBm3kzvxQIhXUVzO6QWWXZVV7LAB59NJzgQ8Ec+eWaVLAkTw8s=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165957-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 165957: regressions - FAIL
X-Osstest-Failures:
    qemu-mainline:build-i386-xsm:xen-build:fail:regression
    qemu-mainline:build-i386:xen-build:fail:regression
    qemu-mainline:build-armhf:xen-build:fail:regression
    qemu-mainline:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-amd:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-pair:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-freebsd10-i386:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-freebsd10-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-coresched-i386-xl:build-check(1):blocked:nonblocking
    qemu-mainline:build-armhf-libvirt:build-check(1):blocked:nonblocking
    qemu-mainline:build-i386-libvirt:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-intel:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-shadow:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-vhd:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=af531756d25541a1b3b3d9a14e72e7fedd941a2e
X-Osstest-Versions-That:
    qemuu=50352cce138ef3b30c1cda28a4df68fff5da3202
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 31 Oct 2021 15:37:41 +0000

flight 165957 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165957/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-i386-xsm                6 xen-build                fail REGR. vs. 165682
 build-i386                    6 xen-build                fail REGR. vs. 165682
 build-armhf                   6 xen-build                fail REGR. vs. 165682

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl           1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-credit2   1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-cubietruck  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-multivcpu  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-rtds      1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-vhd       1 build-check(1)               blocked  n/a
 test-amd64-i386-qemuu-rhel6hvm-amd  1 build-check(1)               blocked n/a
 test-amd64-i386-pair          1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-freebsd10-i386  1 build-check(1)               blocked  n/a
 test-amd64-i386-freebsd10-amd64  1 build-check(1)               blocked  n/a
 test-amd64-coresched-i386-xl  1 build-check(1)               blocked  n/a
 build-armhf-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-arndale   1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-credit1   1 build-check(1)               blocked  n/a
 test-amd64-i386-qemuu-rhel6hvm-intel  1 build-check(1)             blocked n/a
 test-amd64-i386-xl            1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-pvshim     1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-qemuu-debianhvm-amd64  1 build-check(1)         blocked n/a
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow  1 build-check(1)  blocked n/a
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm  1 build-check(1)      blocked n/a
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 1 build-check(1) blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a
 test-amd64-i386-xl-qemuu-win7-amd64  1 build-check(1)              blocked n/a
 test-amd64-i386-xl-qemuu-ws16-amd64  1 build-check(1)              blocked n/a
 test-amd64-i386-xl-shadow     1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-vhd        1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-xsm        1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165682
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165682
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165682
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 qemuu                af531756d25541a1b3b3d9a14e72e7fedd941a2e
baseline version:
 qemuu                50352cce138ef3b30c1cda28a4df68fff5da3202

Last test of basis   165682  2021-10-19 21:09:14 Z   11 days
Failing since        165694  2021-10-20 18:09:12 Z   10 days   28 attempts
Testing same since   165952  2021-10-31 00:39:26 Z    0 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
  Alexey Baturo <baturo.alexey@gmail.com>
  Alexey Baturo <space.monkey.delivers@gmail.com>
  Alistair Francis <alistair.francis@wdc.com>
  Anatoly Parshintsev <kupokupokupopo@gmail.com>
  Andrew Jones <drjones@redhat.com>
  Ani Sinha <ani@anisinha.ca>
  BALATON Zoltan <balaton@eik.bme.hu>
  Bin Meng <bmeng.cn@gmail.com>
  Chenyi Qiang <chenyi.qiang@intel.com>
  Chih-Min Chao <chihmin.chao@sifive.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Cédric Le Goater <clg@kaod.org>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  David Gibson <david@gibson.dropbear.id.au>
  David Hildenbrand <david@redhat.com>
  Dr. David Alan Gilbert <dgilbert@redhat.com>
  Eduardo Habkost <ehabkost@redhat.com>
  Eric Auger <eric.auger@redhat.com>
  Eugenio Pérez <eperezma@redhat.com>
  Frank Chang <frank.chang@sifive.com>
  Frédéric Pétrot <frederic.petrot@univ-grenoble-alpes.fr>
  Gavin Shan <gshan@redhat.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Greg Kurz <groug@kaod.org>
  Gustavo Romero <gromero@linux.ibm.com>
  Igor Mammedov <imammedo@redhat.com>
  Jason Wang <jasowang@redhat.com>
  John Snow <jsnow@redhat.com>
  John Wang <wangzhiqiang02@inspur.com>
  John Wang <wangzq.jn@gmail.com>
  Jose Martins <josemartins90@gmail.com>
  Laurent Vivier <laurent@vivier.eu>
  Laurent Vivier <lvivier@redhat.com>
  Luc Michel <lmichel@kalray.eu>
  Luis Pires <luis.pires@eldorado.org.br>
  Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
  Markus Armbruster <armbru@redhat.com>
  Matheus Ferst <matheus.ferst@eldorado.org.br>
  Mathieu Poirier <mathieu.poirier@linaro.org>
  Michael S. Tsirkin <mst@redhat.com>
  Mingwang Li <limingwang@huawei.com>
  Oğuz Ersen <oguzersen@protonmail.com>
  Pavel Dovgalyuk <Pavel.Dovgalyuk@ispras.ru>
  Peter Krempa <pkrempa@redhat.com>
  Philipp Tomsich <philipp.tomsich@vrull.eu>
  Philippe Mathieu-Daudé <f4bug@amsat.org>
  Philippe Mathieu-Daudé <philmd@redhat.com>
  Richard Henderson <richard.henderson@linaro.org>
  Shuuichirou Ishii <ishii.shuuichir@fujitsu.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Taylor Simpson <tsimpson@quicinc.com>
  Thomas Huth <thuth@redhat.com>
  Tong Ho <tong.ho@xilinx.com>
  Travis Geiselbrecht <travisg@gmail.com>
  Vincent Palatin <vpalatin@rivosinc.com>
  Vivek Goyal <vgoyal@redhat.com>
  Xueming Li <xuemingl@nvidia.com>
  Yanan Wang <wangyanan55@huawei.com>
  Yifei Jiang <jiangyifei@huawei.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               fail    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          blocked 
 test-amd64-i386-xl                                           blocked 
 test-amd64-coresched-i386-xl                                 blocked 
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  blocked 
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       blocked 
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           blocked 
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     blocked 
 test-amd64-i386-freebsd10-amd64                              blocked 
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          blocked 
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          blocked 
 test-armhf-armhf-xl-arndale                                  blocked 
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  blocked 
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  blocked 
 test-armhf-armhf-xl-cubietruck                               blocked 
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         blocked 
 test-amd64-i386-freebsd10-i386                               blocked 
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         blocked 
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                blocked 
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         blocked 
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 blocked 
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    blocked 
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     blocked 
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              blocked 
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    blocked 
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      blocked 
 test-amd64-i386-xl-vhd                                       blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 6076 lines long.)


From xen-devel-bounces@lists.xenproject.org Sun Oct 31 19:27:22 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 31 Oct 2021 19:27:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.218927.379565 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mhGTZ-0000Je-Iu; Sun, 31 Oct 2021 19:26:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 218927.379565; Sun, 31 Oct 2021 19:26:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mhGTZ-0000JX-FB; Sun, 31 Oct 2021 19:26:41 +0000
Received: by outflank-mailman (input) for mailman id 218927;
 Sun, 31 Oct 2021 19:26:40 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mhGTY-0000JJ-B4; Sun, 31 Oct 2021 19:26:40 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mhGTY-0006zF-6t; Sun, 31 Oct 2021 19:26:40 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mhGTX-0001hs-UT; Sun, 31 Oct 2021 19:26:39 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mhGTX-0000hX-Tz; Sun, 31 Oct 2021 19:26:39 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=fuPUnKVREy3d14eqnRAxPY8sZkpn2M/HRMSEW8Epy2s=; b=SPGdDVPbHTQIcHn0G6j+n/aG3B
	uk0ezmDCw201ngmx7WnfduBXYjxffsSWMbknYjk0/Q1B4A6GgOoBFlayN0xkU7/M5qtVZ11xMJRY7
	ua1aKePlx2BoKlLb8wNW5RpPNPxK/e7arH/DRg0yOUnFn30m35n5T3Fie+FWVFt2CnzU=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165962-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 165962: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=c8594a53119c72022f8ff5977b01e4e632ca7a04
X-Osstest-Versions-That:
    ovmf=91b772ab626913bf740e9e1b20387b25bcb2de97
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 31 Oct 2021 19:26:39 +0000

flight 165962 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165962/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 c8594a53119c72022f8ff5977b01e4e632ca7a04
baseline version:
 ovmf                 91b772ab626913bf740e9e1b20387b25bcb2de97

Last test of basis   165950  2021-10-30 20:41:07 Z    0 days
Testing same since   165962  2021-10-31 17:10:05 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Guomin Jiang <guomin.jiang@intel.com>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   91b772ab62..c8594a5311  c8594a53119c72022f8ff5977b01e4e632ca7a04 -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Sun Oct 31 20:04:39 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 31 Oct 2021 20:04:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.218935.379579 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mhH43-0004NG-GT; Sun, 31 Oct 2021 20:04:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 218935.379579; Sun, 31 Oct 2021 20:04:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mhH43-0004N9-Cw; Sun, 31 Oct 2021 20:04:23 +0000
Received: by outflank-mailman (input) for mailman id 218935;
 Sun, 31 Oct 2021 20:04:21 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mhH41-0004Mz-U4; Sun, 31 Oct 2021 20:04:21 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mhH41-0007f0-LU; Sun, 31 Oct 2021 20:04:21 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mhH41-0002oU-7D; Sun, 31 Oct 2021 20:04:21 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mhH41-0001pX-6P; Sun, 31 Oct 2021 20:04:21 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=EFFjv+4hPWltpOw7KUGcCwvTJEUNe9x728qagVqGlEE=; b=da02L7pHGMbcvQHZmEBwVGLJVt
	jgpY7Ir2yX1TMoMyUZBVb+gi7bLv0KDs8KKOOP8PoM+xeWLoGsgPjk94y141jsWkjAFNzJqKp/rSa
	No1pN8unE8VB7dUNS3JstaMzhCAyD5GyQDvLlpKz95V8KNaWW+CyHjW+Q68agIZcFnA0=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-165961-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 165961: regressions - FAIL
X-Osstest-Failures:
    qemu-mainline:build-i386-xsm:xen-build:fail:regression
    qemu-mainline:build-i386:xen-build:fail:regression
    qemu-mainline:build-armhf:xen-build:fail:regression
    qemu-mainline:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-amd:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-pair:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-freebsd10-i386:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-freebsd10-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-coresched-i386-xl:build-check(1):blocked:nonblocking
    qemu-mainline:build-armhf-libvirt:build-check(1):blocked:nonblocking
    qemu-mainline:build-i386-libvirt:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-intel:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-shadow:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-vhd:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-i386-xl-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=af531756d25541a1b3b3d9a14e72e7fedd941a2e
X-Osstest-Versions-That:
    qemuu=50352cce138ef3b30c1cda28a4df68fff5da3202
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 31 Oct 2021 20:04:21 +0000

flight 165961 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165961/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-i386-xsm                6 xen-build                fail REGR. vs. 165682
 build-i386                    6 xen-build                fail REGR. vs. 165682
 build-armhf                   6 xen-build                fail REGR. vs. 165682

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl           1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-credit2   1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-cubietruck  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-multivcpu  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-rtds      1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-vhd       1 build-check(1)               blocked  n/a
 test-amd64-i386-qemuu-rhel6hvm-amd  1 build-check(1)               blocked n/a
 test-amd64-i386-pair          1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-freebsd10-i386  1 build-check(1)               blocked  n/a
 test-amd64-i386-freebsd10-amd64  1 build-check(1)               blocked  n/a
 test-amd64-coresched-i386-xl  1 build-check(1)               blocked  n/a
 build-armhf-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-arndale   1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-credit1   1 build-check(1)               blocked  n/a
 test-amd64-i386-qemuu-rhel6hvm-intel  1 build-check(1)             blocked n/a
 test-amd64-i386-xl            1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-pvshim     1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-qemuu-debianhvm-amd64  1 build-check(1)         blocked n/a
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow  1 build-check(1)  blocked n/a
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm  1 build-check(1)      blocked n/a
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 1 build-check(1) blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a
 test-amd64-i386-xl-qemuu-win7-amd64  1 build-check(1)              blocked n/a
 test-amd64-i386-xl-qemuu-ws16-amd64  1 build-check(1)              blocked n/a
 test-amd64-i386-xl-shadow     1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-vhd        1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-xsm        1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165682
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165682
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165682
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 qemuu                af531756d25541a1b3b3d9a14e72e7fedd941a2e
baseline version:
 qemuu                50352cce138ef3b30c1cda28a4df68fff5da3202

Last test of basis   165682  2021-10-19 21:09:14 Z   11 days
Failing since        165694  2021-10-20 18:09:12 Z   11 days   29 attempts
Testing same since   165952  2021-10-31 00:39:26 Z    0 days    3 attempts

------------------------------------------------------------
People who touched revisions under test:
  Alexey Baturo <baturo.alexey@gmail.com>
  Alexey Baturo <space.monkey.delivers@gmail.com>
  Alistair Francis <alistair.francis@wdc.com>
  Anatoly Parshintsev <kupokupokupopo@gmail.com>
  Andrew Jones <drjones@redhat.com>
  Ani Sinha <ani@anisinha.ca>
  BALATON Zoltan <balaton@eik.bme.hu>
  Bin Meng <bmeng.cn@gmail.com>
  Chenyi Qiang <chenyi.qiang@intel.com>
  Chih-Min Chao <chihmin.chao@sifive.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Cédric Le Goater <clg@kaod.org>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  David Gibson <david@gibson.dropbear.id.au>
  David Hildenbrand <david@redhat.com>
  Dr. David Alan Gilbert <dgilbert@redhat.com>
  Eduardo Habkost <ehabkost@redhat.com>
  Eric Auger <eric.auger@redhat.com>
  Eugenio Pérez <eperezma@redhat.com>
  Frank Chang <frank.chang@sifive.com>
  Frédéric Pétrot <frederic.petrot@univ-grenoble-alpes.fr>
  Gavin Shan <gshan@redhat.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Greg Kurz <groug@kaod.org>
  Gustavo Romero <gromero@linux.ibm.com>
  Igor Mammedov <imammedo@redhat.com>
  Jason Wang <jasowang@redhat.com>
  John Snow <jsnow@redhat.com>
  John Wang <wangzhiqiang02@inspur.com>
  John Wang <wangzq.jn@gmail.com>
  Jose Martins <josemartins90@gmail.com>
  Laurent Vivier <laurent@vivier.eu>
  Laurent Vivier <lvivier@redhat.com>
  Luc Michel <lmichel@kalray.eu>
  Luis Pires <luis.pires@eldorado.org.br>
  Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
  Markus Armbruster <armbru@redhat.com>
  Matheus Ferst <matheus.ferst@eldorado.org.br>
  Mathieu Poirier <mathieu.poirier@linaro.org>
  Michael S. Tsirkin <mst@redhat.com>
  Mingwang Li <limingwang@huawei.com>
  Oğuz Ersen <oguzersen@protonmail.com>
  Pavel Dovgalyuk <Pavel.Dovgalyuk@ispras.ru>
  Peter Krempa <pkrempa@redhat.com>
  Philipp Tomsich <philipp.tomsich@vrull.eu>
  Philippe Mathieu-Daudé <f4bug@amsat.org>
  Philippe Mathieu-Daudé <philmd@redhat.com>
  Richard Henderson <richard.henderson@linaro.org>
  Shuuichirou Ishii <ishii.shuuichir@fujitsu.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Taylor Simpson <tsimpson@quicinc.com>
  Thomas Huth <thuth@redhat.com>
  Tong Ho <tong.ho@xilinx.com>
  Travis Geiselbrecht <travisg@gmail.com>
  Vincent Palatin <vpalatin@rivosinc.com>
  Vivek Goyal <vgoyal@redhat.com>
  Xueming Li <xuemingl@nvidia.com>
  Yanan Wang <wangyanan55@huawei.com>
  Yifei Jiang <jiangyifei@huawei.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               fail    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          blocked 
 test-amd64-i386-xl                                           blocked 
 test-amd64-coresched-i386-xl                                 blocked 
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  blocked 
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       blocked 
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           blocked 
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     blocked 
 test-amd64-i386-freebsd10-amd64                              blocked 
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          blocked 
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          blocked 
 test-armhf-armhf-xl-arndale                                  blocked 
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  blocked 
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  blocked 
 test-armhf-armhf-xl-cubietruck                               blocked 
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         blocked 
 test-amd64-i386-freebsd10-i386                               blocked 
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         blocked 
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                blocked 
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         blocked 
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 blocked 
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    blocked 
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     blocked 
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              blocked 
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    blocked 
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      blocked 
 test-amd64-i386-xl-vhd                                       blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 6076 lines long.)